Using pydantic model's methods as field resolvers

Feature Request Type

[ ] Core functionality
[x] Alteration (enhancement/optimization) of existing feature(s)
[ ] New behavior

Description
Using computable properties or methods of the pydantic model instead of strawberry.field
class User(BaseModel):
    first_name: str
    last_name: str

    def full_name(self, separator: str) -> str:
        return f"{self.first_name}{separator}{self.last_name}"

@strawberry.experimental.pydantic.type(model=User, all_fields=True)
class UserType:
   pass

Now the scheme looks like this:
type UserType{
  first_name: String!
  last_name: String!
}

But it would be convenient to have a scheme that looks like
type UserType{
  first_name: String!
  last_name: String!
  full_name(separator: String!): String!
}

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

I imagine this is now solved by https://strawberry.rocks/docs/guides/accessing-parent-data...


tf.signal.rfft crashes when fft_length is [0]

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.17.0
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
When setting the fft_length to [0], the tf.signal.rfft will raises a program abort. If this parameter is invalid, raising an invalid argument error looks more clear to me instead of a program abort.
Standalone code to reproduce the issue
import tensorflow as tf
input = tf.constant([0.27], dtype='float32')
tf.signal.rfft(input, fft_length=[0])

### Relevant log output

```shell
Skipping registering GPU devices...
DUCC FFT r2c failed:
bazel-out/k8-opt/bin/external/ducc/_virtual_includes/fft/ducc/src/ducc0/fft/fftnd_impl.h: 139 (static void ducc0::detail_fft::util::sanity_check_cr(const fmav_info &, const fmav_info &, const shape_t &)):

Assertion failure
axis length mismatch

Aborted (core dumped)

I notice that this issue also occurs when using the tf.signal.irfft
import tensorflow as tf
input = tf.constant([0.27], dtype='complex64')
tf.signal.irfft(input, fft_length=[0])

error:
Skipping registering GPU devices...
DUCC FFT c2r failed:
bazel-out/k8-opt/bin/external/ducc/_virtual_includes/fft/ducc/src/ducc0/fft/fft1d_impl.h: 2948 (static Trpass<Tfs> ducc0::detail_fft::rfftpass<float>::make_pass(size_t, size_t, size_t, const Troots<Tfs> &, bool) [Tfs = float]):

Assertion failure
no zero-sized FFTs

Aborted (core dumped)

Hi @maybeLee ,
Apologize for the delay. I tried to run your code on Colab using TensorFlow version 2.17.0, nightly and encountered the same issue. As an alternative, I have provided a Gist for your reference. This issue is already being tracked, so it is a duplicate. Could you please check and let me know if i am wrong.
Thank you!


Add CDN get piece tasks result logs

Signed-off-by: sunwp<EMAIL_ADDRESS>
Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #1019 (fcd9059) into main (2889ea3) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   45.64%   45.96%   +0.31%
==========================================
  Files         128      128
  Lines        9107     9134      +27
==========================================
+ Hits         4157     4198      +41
+ Misses       4479     4463      -16
- Partials      471      473       +2

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.96% <ø> (+0.31%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cdn/supervisor/progress/progress.go
91.04% <0.00%> (-5.98%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
57.33% <0.00%> (-0.02%)
:arrow_down:

scheduler/config/config.go
0.00% <0.00%> (ø)

scheduler/resource/resource.go
82.60% <0.00%> (+0.79%)
:arrow_up:

scheduler/resource/task.go
81.33% <0.00%> (+1.33%)
:arrow_up:

client/daemon/peer/peertask_manager.go
44.15% <0.00%> (+2.26%)
:arrow_up:

scheduler/service/callback.go
70.96% <0.00%> (+2.75%)
:arrow_up:

scheduler/resource/cdn.go
54.20% <0.00%> (+5.53%)
:arrow_up:

scheduler/resource/cdn_mock.go
23.21% <0.00%> (+23.21%)
:arrow_up:


Call reducer events on failed updates

Description of Changes
Apply Alessandro's bugfix to call reducer events on failed updates.
I couldn't directly open a PR for Alessandro's branch because it's based on v0.11.0-beta, which is an orphan commit.
This is the original commit:
commit efbb0ccc7633276876801c719e9f8e91f7ac9e51 (origin/alessandro/bugfix/v0.11.0-beta-bugfix)
Author: Alessandro Asoni<EMAIL_ADDRESS>Date:   Fri Sep 6 15:49:50 2024 +0200

    Call reducer event for failed updates

diff --git a/Scripts/SpacetimeDBClient.cs b/Scripts/SpacetimeDBClient.cs
index 89774b5..dd7193c 100644
--- a/Scripts/SpacetimeDBClient.cs
+++ b/Scripts/SpacetimeDBClient.cs
@@ -352,6 +352,15 @@ namespace SpacetimeDB
                                 }
                                 break;
                             case UpdateStatus.Failed(var failed):
+                                // Convert the generic event arguments in to a domain specific event object
+                                try
+                                {
+                                    reducerEvent = ReducerEventFromDbEvent(transactionUpdate);
+                                }
+                                catch (Exception e)
+                                {
+                                    Logger.LogException(e);
+                                }
                                 break;
                             case UpdateStatus.OutOfEnergy(var outOfEnergy):
                                 Logger.LogWarning("Failed to execute reducer: out of energy.");

API
No
Requires SpacetimeDB PRs
None

Based on the discussion in discord it sounds like Ingvar/Jeremie are pushing this forward, please reassign me if you want me to take a look


Update Import-SPEnterpriseSearchCustomExtractionDictionary.md

Fix example text.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Import-SPEnterpriseSearchCustomExtractionDictionary.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Gotcha in documentation

The documentation mentions:

The HTTP method defaults to GET, so if you wish, the following is valid:
 request('/search', function(res) {

 });

'res' is not the actual result, but the error object (or null if none) so the callback should be 'function(err, res) { ...'

fixed


Prepare for "mapbox-gl-style-spec" package changes

Hello!
I work on at Mapbox on Mapbox GL. We are preparing to make some changes to the mapbox-gl-style-spec package which may affect you:

the mapbox-gl-style-spec package will be deprecated and replaced by @mapbox/mapbox-gl-style-spec
mapbox-gl-style-spec package will begin using es6 features, requiring the use of transpilation (if you're using browserify, this'll happen automatically via bubleify)
the file structure of mapbox-gl-style-spec will change (which will affect the use of require(mapbox-gl-style-spec/lib/**/*.js))

You can read more about these changes at https://github.com/mapbox/mapbox-gl-js/pull/3946 and https://github.com/mapbox/mapbox-gl-js/issues/3656.
Let me know if you have any questions or need any help!

Thanks for the heads-up @lucaswoj! I'll make the required changes as soon as @mapbox/mapbox-gl-style-spec is published.

Done with 13fbd1fd61bc98efaaaeb81895d333f3a39bcbcf.


NBA Datasets Download Links are Broken

Hi, there, thanks for your nice work.
I attempted to download the NBA basketball datasets. However, all the download links seem to be broken. NBA Dataset
I contacted the author and hadn't received a reply. Can you share the data with me?
I will follow the License of the original data, btw, the corresponding zip code.
Thank you.

the datasets owner answered me.

@urbaneman any idea where to get the "ball-annos" from? it doesnt seem to be included in the dataset :thinking:


fix(import-flow): optmize import flow api requests

Fixes

https://issues.redhat.com/browse/HAC-4812
Description

Type of change

[ ] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
Get UX suggestion on the modal text

How to test or reproduce?

Browser conformance:

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

The placement of the helper text should be closer to the progress bar.
See PF styling here: https://www.patternfly.org/components/progress#helper-text
Also, the length of the track (light blue bar) should be fixed. It seems to change based on the percentage being displayed.

We should also probably remove the 'x' button since it doesn't do anything

For the progress bar title, although "Hold onto your hats!!" made me laugh, we should change it to "Importing components" to match PatternFly's guidance https://www.patternfly.org/components/progress/design-guidelines/#content-considerations

@rottencandy @Misjohns Addressed review comments.
Progress bar length was changing because of change in percentage outside the progress bar.

The placement of the helper text should be closer to the progress bar.
See PF styling here: https://www.patternfly.org/components/progress#helper-text

There is no extra styling applied to the progress bar or the helper text. This is the styling coming from the patternfly.


Warnings when initialize FileDialog

For example, my code in Main.qml
Components.FilesDialog
{
    id: filesDialog
}

And FilesDialog.qml
FileDialog
{
    id: filesDialog
    // ...
}

When i launch the app, i get two warnings
.../.nuget/packages/qml.net.linuxbinaries/0.7.0/runtimes/linux-x64/native/qml/QtQuick/Dialogs/DefaultFileDialog.qml:102:33: QML Settings: Failed to initialize QSettings instance. Status code is: 1
.../.nuget/packages/qml.net.linuxbinaries/0.7.0/runtimes/linux-x64/native/qml/QtQuick/Dialogs/DefaultFileDialog.qml:102:33: QML Settings: The following application identifiers have not been set: QVector("organizationName", "organizationDomain")

Version of qmlnet: 0.7.0

I was able to reproduce the warnings on my Windows machine. Qml's FileDialog component uses the QQControlsFileDialog section of the application-specific QSettings. AFAIK we currently don't support configuring these settings.
More: https://doc.qt.io/qt-5/qml-qtquick-dialogs-filedialog.html#details

Ok, now i know what reproduces these warnings.
Thanks for your reply!

Not sure if we should close this issue just yet. I think we need to support this. What do you think @pauldotknopf ?

Yeah, this needs to be done IMO.


[0.9.6] Copyright needs changing in other areas of code

Once you build Feathercoin-Qt.exe in windows, the Copyright in the file properties of windows shows 2003-2016  (right click Feathercoin-Qt.exe->Properties->Details tab   )
The date should be updated to 2017
With the same Feathercoin-Qt.exe build, when you open it and navigate to Help -> About Feathercoin Core
The copy right on the about page shows the correct date 2013-2017
0.9.7-dev  banch should be updated.

Fixed in https://github.com/FeatherCoin/Feathercoin/pull/161


plex-mpv-shim: pin to python311

Description of changes
Python 3.12 broke it. Pinning to python311.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/pull/325179 should resolve this once it hits unstable -- plex-mpv-shim currently builds for me on master with this change. Pinning to 3.11 should not be required.

#325179 should resolve this once it hits unstable -- plex-mpv-shim currently builds for me on master with this change. Pinning to 3.11 should not be required.

Ah, thanks... did this late last night and didn't check master first.


RE4R + REFramework crash

Describe the bug
Using REFramework causes game to crash on startup
Upload logs and any crash dumps
re2_framework_log MODS.txt
re2_framework_log.txt
couldn't find the dump file
Identify the REFramework version
exact version unknown, but latest version (and nightly build- nightly crash log not included) were tested.
To Reproduce
Steps to reproduce the behavior:

launch game with d8input.dll in game folder
wait

Expected behavior
REFramework should launch and not cause the game to crash
Desktop and VR (please complete the following information):

OS: Win 10
GPU: 1050ti
CPU: Core i3-10100

Additional context
I included the crash log with mods and without because I happened to have opened RE4R with mods too
removing or bypassing the dll will make the game work (for obvious reasons) but the game loads up to "Quixel Megascans" and starts the next loading scene but crashes instead.

Pirated copies are not supported.


Fix some bugs of encoder/decoder ( for #93 )

Codecov Report

Merging #94 (3682ec0) into master (020aaff) will decrease coverage by 0.07%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   76.25%   76.17%   -0.08%
==========================================
  Files          38       38
  Lines       36628    36679      +51
==========================================
+ Hits        27931    27942      +11
- Misses       7856     7894      +38
- Partials      841      843       +2

Impacted Files
Coverage Δ

encode_vm.go
68.81% <0.00%> (-0.05%)
:arrow_down:

encode_vm_escaped.go
79.46% <0.00%> (-0.05%)
:arrow_down:

encode_vm_escaped_indent.go
81.59% <0.00%> (-0.05%)
:arrow_down:

encode_vm_indent.go
77.08% <0.00%> (-0.05%)
:arrow_down:

decode_interface.go
64.50% <17.24%> (-8.02%)
:arrow_down:

decode_unmarshal_json.go
100.00% <100.00%> (ø)

decode_compile.go
82.64% <0.00%> (+1.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020aaff...3682ec0. Read the comment docs.

Codecov Report

Merging #94 (3682ec0) into master (020aaff) will decrease coverage by 0.07%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   76.25%   76.17%   -0.08%
==========================================
  Files          38       38
  Lines       36628    36679      +51
==========================================
+ Hits        27931    27942      +11
- Misses       7856     7894      +38
- Partials      841      843       +2

Impacted Files
Coverage Δ

encode_vm.go
68.81% <0.00%> (-0.05%)
:arrow_down:

encode_vm_escaped.go
79.46% <0.00%> (-0.05%)
:arrow_down:

encode_vm_escaped_indent.go
81.59% <0.00%> (-0.05%)
:arrow_down:

encode_vm_indent.go
77.08% <0.00%> (-0.05%)
:arrow_down:

decode_interface.go
64.50% <17.24%> (-8.02%)
:arrow_down:

decode_unmarshal_json.go
100.00% <100.00%> (ø)

decode_compile.go
82.64% <0.00%> (+1.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 020aaff...3682ec0. Read the comment docs.


Could not resolve the JSON path '...' because no document path is available.

I am trying to generate c# classes from json schema files. The json schema files contain references to other json schema files which are available locally, in the same directory as the "main" json schema file.
For instance a "my_main_schema.json" file contains a reference to a "my_second_schema.json" file, like this:
...
"$ref": "my_second_schema.json"
...

The JsonSchema.FromJsonAsync() call (see code below) throws the exception
"Could not resolve the JSON path 'my_second_schema.json' because no document path is available."
...
var jsonSchema = File.ReadAllText($"my_main_schema.json");
var schemaFromFile = await JsonSchema.FromJsonAsync(jsonSchema);
var classGenerator = new CSharpGenerator(schemaFromFile, new CSharpGeneratorSettings
  {
      ClassStyle = CSharpClassStyle.Poco,
      JsonLibrary = CSharpJsonLibrary.SystemTextJson
 });
...

How can NJsonSchema be configured to search the referenced json schema files in the same directory as the json schema main file, as it does not seem to be the case by default?

Same issue.
Example JSON:

{
  "$id": "https://example.com/person.schema.json",
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "title": "AddressUpdated",
  "type": "object",
  "properties": {
    "address": { "$ref": "address.json" },
    "custom-property": {
      "type": "string",
      "description": "Something"
    }
  }
}

Current process is set at the location of the loaded JSON file via Directory.SetCurrentDirectory.

Are you loading the JSON via JsonSchema.FromFileAsync ?
If you do then the file will resolve.

@daneel3001 I am actually using JsonSchema.FromJsonAsync, and adding a JsonSchemaResolver:
...
var jsonRefSchema = File.ReadAllText($"my_ref_schema.json");
var jsonRefSchemaFromFile = await JsonSchema.FromJsonAsync(jsonRefSchema);
var jsonSchema = File.ReadAllText($"my_main_schema.json");
var schemaFromFile = await JsonSchema.FromJsonAsync(
        jsonSchema,
        ".",
        ref_schema =>
        {
            JsonSchemaResolver schemaResolver = new JsonSchemaResolver(
                ref_schema,
                new JsonSchemaGeneratorSettings());
            var resolver = new JsonReferenceResolver(schemaResolver);
            resolver.AddDocumentReference("my_ref_schema.json", jsonRefSchemaFromFile);
            return resolver;
        }
        );
...

Would this not be necessary if loading the json schema with JsonSchema.FromFileAsync? Would the referenced json schema automatically be searched in the same directory as the json schema from which the code is generated ?
Another question: did you find a possibility to set the name of the generated c# class for the referenced json schema to another name than the referenced json schema file name (seems to be the default setting) ?

Loading via FromFileAsync did resolve to schemas located on the same filesystem using relative paths from the loaded file.
I haven't tried with a resolver like you have.

@daneel3001  Ok, thanks, I will try it.
Were you also able to set any name you want for the generated class representing the referenced schema?

By convention it's taking the name of the file as the class name.
I haven't tried overriding it.

I am getting the same thing as well.
System.AggregateException: 'One or more errors occurred. (Could not resolve the JSON path 'file:tags/reference-tags.json' because no document path is available.)'
Schema is located at E:\JsonSchema.json
Tags are located in E:\tags\reference-tags.json


"entries" always returns only the "_id", when using "fields" to reduce the response. How to?

I try to reduce the key/values in the response with: 'fields'. I tried like this:
let filtered = {
    filter: {"title":"Home"},
    fields: ["title", "items"],
    //fieldsFilter: ["title"],
    populate: 3
}
app.$axios.$post('/api/collections/get/Pages/',filtered)

But instead of returning only the fields i wanted, the only thing returned in entries is:
...
"entries": [
        {
            "_id": "5a31439f1a605doc706042998"
        }
    ],
...

I also tried fieldsFilter, no luck.
Try it online:
https://api.renethiel.info/api/collections/get/Pages/?token=87ed395beee01f27e0715b0e63ab79
Maybe i am holding it wrong, but what i want to achieve is the same when using graphql. Let cockpit just respond with the fields, that i need, not all the metadata. What is the right way to do it?
Side question, there must be a way to get rid of the schema that is sent in 'fields', too.
A graphql side-example with the same dataset:
query {
  allPages(skip: 0, limit: 1, populate: 3) {
    title
    items{
	title
   }
  }
}

would return only:
{
	"data": {
		"allPages": [
			{
				"title": "Home",
				"items": [
					{
						"title": "Projects"
					},
					{
						"title": "About"
					}
				]
			}
		]
	}
}

I want to achieve this result with the normal api without graphql by using fields/fieldsFilter. I hope it is possible to do that.

fields: {'_id': 1 ,'title': 1, 'slug': 1}
you'll then get only the fields _id, title and slug in the resultset
or fields: {'title': -1, 'slug':- 1} get all fields except title and slug


Better Ruby fetch builtin switch

Don't apply fetch switch on shorthand arrays.

Right, hadn't realized there would be a conflict there -- makes sense.


Trivia--initial version without scorekeeping

TEST PLAN (Requires 5 people)

go to (----TRIVIA LOCATION-----)
Designate one tester as "Trivia Master" (TM) and have each of the remaining 4 be contestants by standing at a podium on the blue/green square
Upon entering a podium space, each contestant should see a question panel that says "Questions will appear here" and 4 overlay answer panels visible only to themselves that say ""Select an answer here"
TM should stand  near the middle of the podiums, open the app (via running script trivia.js), and click "Lets get Started!". An announcer should say "Ladies and Gentleman..."
TM clicks "Gimme a question" and checks that the question and answers are compatible meaning    that:                 1) They do not have special characters
2) The answers are not more than a few words long
Once the TM has a good question, click "Yes! Show it!" to display it and start the timer with its clock sound effect
Each contestant should see the question displayed on their podium with the possible answer options below
The question and answers should appear on the large text panels behind the podiums with the answer still hidden
After 10 seconds, the timer should ding and each contestant's answer should display on the front of their podium for the audience to see.
When TM is ready to show the correct answer, click "Show correct answer".  The correct answer should display on a panel beneath the large version of the question and answers behind the podiums. Each contestant's answer should display with a green background if correct and red if incorrect.
TM clicks "Gimme a question", finds a new question and clicks "Yes! Show it!". All contestants displayed answers should return to the original background color and display a "?" again. Repeat previous steps

@RebeccaStankus do you want to keep this PR open? I noticed you add DNM to it


[Sample Onboard Request] Graph Connector Bot

Owner:
@formulahendry
ID:
graph-connector-bot
Title:
Graph Connector Bot
Description:
This sample app showcases how to build a Teams command bot that queries custom data ingested into Microsoft Graph using Graph connector.
Tags:

TS
Bot
Microsoft Graph connectors

Time:
20mins to run
Configuration:
Manual configurations required
Thumbnail:
https://github.com/OfficeDev/TeamsFx-Samples/blob/dev/graph-connector-bot/assets/thumbnail.png
(Optional) Demo GIF:
https://github.com/OfficeDev/TeamsFx-Samples/blob/dev/graph-connector-bot/assets/sampleDemo.gif
(Source code in this Repo) Source Code PR:
https://github.com/OfficeDev/TeamsFx-Samples/pull/469
(Source code NOT in this Repo) Sample URL:
N/A
(Optional) Minimum Teams Toolkit Version:
V5
(Optional) Maximum Teams Toolkit Version:
N/A

Add @MuyangAmigo for awareness.

@tecton Please update config to onboard this sample.

Onboarding PR: #1075

@formulahendry I've onboarded sample to TTK sample gallery. It will be available in next release version, and you can also check it in TTK daily build versions.

checked already in Gallery, hence close the tricket.


Ability to set flags/extra_args & extra binds for kubernetes components in the UI

All the components have configurable flags that might need to be adjusted for a particular need, or added to get extra functionality. As of today, this is only possible using RKE and import.
As this can break clusters, we can add an Advanced Options which allows users to add flags to kubernetes components with the warning this can break their cluster/use at your own risk etc.

@loganhz This is going to need design and consideration so I wouldn't just go build something...

@vincent99 can we do something like edit RKE config in yaml?

So how to use RKE to achieve that for now?

@loganhz Can you do:

Add an advanced options at the bottom of cluster config, which takes the YAML for the contents of the rancherKubernetesEngineConfig field.
You'll probably need a blacklist of things to remove from the displayed YAML because they have custom UI options.
On save, convert to JSON (yamljs is already loaded) and overlay/recursively merge the custom settings into the resource
Drop etcd heartbeat/interval, and flannel/canal iface options from the UI, since they're not that common and can be set in YAML now.
For bonus points, read the schema and construct YAML with all the fields that are possible shown but commented out so it's easy to find what you want and edit the YAML.

Version - 2.0 master 6/4
Verified fixed

@agasbzj until I can pull this change into my environment, I used the suggested workaround of creating an environment using rke up (extra_args in the config can be used to pass additional args to kubelet and others) and then importing that created env into the Rancher UI via the import option.

rancher/rancher:master 6/19
Cluster options are being displayed in YAML and editing works correctly.


[Request] Fun with variables

At first, I want to thank the developer of this nifty, little editor. It's very easy to use and runs like a charm.
But, unfortunately, it is still very limited in many functions
Would it be hard, to implement something like this:
https://i.imgur.com/K0O1xQE.png
This is just a little sketch, but I hope you understand the concept.
The the same with the "if statements" for variables. Would be really nice to be able to compare variables with each other.
It would also be great to have something like "get_player_x" and "get_player_y", to make things like a menu possible. (https://github.com/chrismaltby/gb-studio/issues/70, https://github.com/chrismaltby/gb-studio/issues/55)

Regarding your last two requests.
PR #84 implements a lot of useful Math functions, including a If Variable Compare, to compare two variables.
PR #81 Implements extended Actor scripting, including Get Actor Position, and Set Actor Position To Value

Combining some math or move functions in the script editor might be nice, using a drop down picker to call the dedicated functions in code, for speed.
Drop down box like the compare variable function.

Thank you for your quick answer! I will definitely check this out!

When using "Math Variable Subtract" I found the formulation "Subtract (var1) BY Value (var2)" to be quite irritating. Especially strange when using "Math Subtract", and there it reads ""Subtract (var1) FROM Value (var2)", which is much easier to understand, I think.
I also don't like the fact that some of the functions are named in such an "inconsistent" way.
Like "Actor Move", but then "Hide Actor". Wouldn't it be better, to use one style and keep things sorted?
But I don't want to be petty, as these are probably low priority things. :)

I think it is open for debate. You could make a separate issue with your suggestions


Outline doesn't show 'container' type

Testing #52799

The symbol quick pick shows the 'container' type from the symbol provider. Like from unit test navigate:

But they aren't shown in the outline view:

Was that on purpose? It's useful for the unit-test-navigate extension. Not sure what other extensions might use it for.

Yeah, that on purpose. The containerName exists in the old API only as a weak hint towards the containing/parent type. With the new API, there is that as parent-node and a symbol can have a detail property for extra information.


Added stale bot github action 🤖

This PR proposed adding a Github action to mark inactivity issues with stale? tag and then it will be closed after some time if no further actions initiated.

Background
Twill's GitHub community is receiving new issues every day, and there are many old issues that haven't been properly taken care of for many reasons.
There definitely has a large room for Twill to improve, and every feature request or suggestion is appreciated, however, because the resource is limited, I think the Twill community may like to focus on one thing at one time.
As from my understanding, Twill's goal is rather to be a CMS toolkit that could handle 10,000 jobs in a mediocre degree, it more likely wishes to be a tool focus on 10 jobs but doing them perfectly.
There always has a reason that an issue getting no replies, maybe itself is invalid, maybe it's a very edge case, maybe there are some blockers. The community didn't reply to them because Twill has a large space to grow, people have other higher priority things to focus on. We don't want to say the word "No" because we think we will find time later to come back handle them. but time gets wasted when more and more such issues deluged, and some truly valuable suggestions getting submerged inside them.
A stale 🤖 is more objective and say no to people with no bias 😉, so as to mandatorily help everyone here to focus on the paramount thing to make Twill move faster. The best way to save a stale issue is to create a PR now! We do need everyone's help from the community.
What the stale bot will do?

The action uses a fork from https://github.com/gatsbyjs/stale
It can be configured in .github/workflows/stale.yml
The action will run every day at 12:00.
It will find all issues that have been inactivity for longer than 3 months and mark stale? tag on them, as well as leaving a comment.
If a stale issue has been inactivity for another month, it will be closed.
Users could reply with anything under the issues to prevent it to be closed.
Specific exempt tags could be set that the bot will not deal with those issues.

I have set up the demo bot in my forked Twill repo, you could take a look and try it there, it's running every 5 mins for all issues for testing purpose: https://github.com/yanhao-li/twill/issues/9
I do understand this is a controversial proposal, so please leave feel free to leave any commented below and let's discuss.

Closing this as this is going to be rolled out with a new configuration. Cheers @yanhao-li!


number of connections at a time

As it's said in the title,if i use this plug-in to create an application, how many points inside the same network can have access to this service at the same time? Is there any limitations?

Any rate limits would be from Yahoo. Check out the YQL docs for that info - https://developer.yahoo.com/yql/.


oas3-schema rule returns OpenAPI specification is invalid: /required missing properties: 'paths' when a webhooks path exists

For a document that documents webhooks as opposed to an path in a 3.1 spec this rule returns saying the document is invalid.

Actually also returns OpenAPI specification is invalid: /additionalProperties additionalProperties 'webhooks' not allowed

should prob detect one or other is not present

Apologies I opened this in haste, the spec I had they had incorrectly entered the version number, but changing this to 3.1.0 it linted correctly without the above issues


 What Unity game was involved?

@puckey it was very hard to isolate the problem that we had, because Unity games are developed by another company and it's not open source code, so we were not able to provide a repro.
Basically steps to reproduce were described in https://github.com/doublesymmetry/react-native-track-player/issues/2110 - when you play an audio after you played a game you will not see a song in notification center.
I've tried to debug this problem a little bit - from my observation our Unity module just changes category to ambient on mount and set it to playback when game gets closed:
#if TARGET_IPHONE_SIMULATOR

#else
#import "ReactNativeUnityView.h"
#import "ReactNativeUnity.h"
#import <AVFAudio/AVAudioSession.h>

NSDictionary* appLaunchOpts;

@implementation ReactNativeUnityView

-(id)initWithFrame:(CGRect)frame
{
    self = [super initWithFrame:frame];
    if (self) {
        [ReactNativeUnityView changeAudioSessionCategory:AVAudioSessionCategoryAmbient]; // <- ambient on mount
        _uView = [[[ReactNativeUnity launchWithOptions:appLaunchOpts] appController] rootView];
        [FrameworkLibAPI registerAPIforNativeCalls:self];
    }
    return self;
}

+ (void)changeAudioSessionCategory:(AVAudioSessionCategory)category {
    // schedule async operation and execute it as soon as possible
    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{
        NSError *setCategoryErr = nil;
        NSError *activationErr  = nil;
        [[AVAudioSession sharedInstance] setCategory:category error:&setCategoryErr];
        [[AVAudioSession sharedInstance] setActive:YES error:&activationErr];
        NSLog(@"AVAudioSession changed. Category error<EMAIL_ADDRESS>Activation error: %@", [setCategoryErr localizedDescription], [activationErr localizedDescription]);
    });
}

- (void)layoutSubviews
{
    [super layoutSubviews];

    [_uView removeFromSuperview];
    _uView.frame = self.bounds;
    [self insertSubview:_uView atIndex:0];
}

+ (void)pauseUnity:(BOOL * _Nonnull)pause
{
    [[ReactNativeUnity ufw] pause:pause];
}

+ (void)unloadUnity
{
    UIWindow * main = [[[UIApplication sharedApplication] delegate] window];
    if(main != nil) {
        [main makeKeyAndVisible];
        if ([ReactNativeUnity ufw]) {
            [self changeAudioSessionCategory:AVAudioSessionCategoryPlayback]; // <- playback on unmount
            [[ReactNativeUnity ufw] unregisterFrameworkListener:[ReactNativeUnity ufw]];
            [[ReactNativeUnity ufw] unloadApplication];
        }
    }
}

+ (void)UnityPostMessage:(NSString*)gameObject methodName:(NSString*)methodName message:(NSString*) message {
    dispatch_async(dispatch_get_main_queue(), ^{
        [[ReactNativeUnity ufw] sendMessageToGOWithName:[gameObject UTF8String] functionName:[methodName UTF8String] message:[message UTF8String]];
    });
}

- (void)sendMessageToMobileApp:(NSString *)message {
    if (self.onUnityMessage) {
        NSDictionary* data = @{
            @"message": message
        };

        self.onUnityMessage(data);
    }
}

@end

#endif

I've tried to add setAmbient/setPlayback methods in RNTP (and call them by pressing on a button) to reproduce the problem, but it didn't work out - everything was working fine 🤷♂ Maybe there are other conflicts with unity module and RNTP implementation, but I wasn't able to identify them.
Are you concerned by this fix? Or maybe want us to test any upcoming PR?


Button is not working properly

Describe the bug
A clear and concise description of what the bug is.
"Link to Github Repository" button is not working properly, after clicking, it has to show respected
github repo
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

need help in this isuue

is anyone there to help me out?

is anyone there to help me out?

Your ISSUE Description was unclear as you forgot to delete the template😅
Can you please elaborate on the issue with the GitHub button?

@smaranjitghose pls go to the achievements page and trying to press the link to GitHub  repo button and you will find that button is not working accordingly, so to solve that bug I need help .

What help do you need

I understood the problem.
Link to Github Repository in project card doesn't work.
Can I work on this issue?

@smaranjitghose I have added a PR #952  regarding this issue

may i work on this issue?

may i work on this issue?

I think the issue is resolved.

I think the issue is resolved.


Problems around associating a value with a type

Take the following example (tests/experiments/generic/type-to-value-4.slang)
RWStructuredBuffer<int> outputBuffer;

enum class Enum
{
    A, B
};

interface IGetE
{
	static Enum getE();
};

public struct A : IGetE
{
    static Enum getE() { return Enum::A; }
};

public struct B : IGetE
{
    static Enum getE() { return Enum::B; }
};

[numthreads(4, 1, 1)]
void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
{
    int index = dispatchThreadID.x;

    B b;
    IGetE g = b;

    let e = g.getE();
    outputBuffer[dispatchThreadID.x] = int(e);
}

This doesn't work without at least 'public' on struct B. This is necessary such that those implementations of IGetE are visible for dynamic dispatch.
Otherwise the error

tests/experiments/generic/type-to-value-4.slang(21): error 50100: No type conformances are found for interface 'IGetE'. Code generation for current target requires at least one implementation type present in the linkage.
interface IGetE
^~~~~

This is somewhat 'surprising' because the code explicitly instantiates B, so why is it necessary to make it
public?
If we make both struct A and struct B public, the generated code uses dynamic dispatch in order to implement e.getE(). When it does this it introduces
struct Tuple_0
{
    uint2 value0_0;
    uint2 value1_0;
    AnyValue16 value2_0;
};

Tuple_0 _S1;

[numthreads(4, 1, 1)]
void computeMain(uint3 dispatchThreadID_0 : SV_DISPATCHTHREADID)
{
    int _S7 = U_S3tu05IGetE4getEp0p3tu04Enum_0(_S1.value1_0);

    // ...
}

But _S1 is never initialized (in HLSL it becomes a Global in a constant buffer). Why does creating a local variable produce something in a global which now needs binding/initialization?
Moreover it is perhaps surprising that dynamic dispatch is used in the example, and in doing so is less efficient/more complex than it needs to be.

There's really a few issues here (and we might need to split this so we can track them individually).
A Dynamic-Dispatch Lowering Bug?
@csyonghe I think the most important thing to deal with on this issue is to resolve whether there is indeed a codegen bug relate to dynamic dispatch in that last example @jsmall-nvidia posted. My assumption is that the IGetE g = b part should have generated an existential with the data of b and the ID for the conformance B : IGetE. The fact that a global variable (or shader parameter?) of tuple type is getting introduced doesn't seem right.
A Specialization Optimization Bug?
The second issue that seems clear to me is that this code should have been able to yield fully statically-specialized output. There is no question at the IR level of what the concrete type inside the existential g is, and we should have thus been able to specialize the callee to the type and witness table in the existential value.
We definitely want to keep working on our optimizations for the existential case, since users seem inclined to lean on it more and more.
A Design Question
The final issue is the high-level question of why public is needed to get the code to compile, because it sure seems like it should Just Work.
This is slightly tangled up with the previous item, since my strong opinion is:

For any code where our IR optimization passes can fully specialize it such that dynamic dispatch is no longer needed, we should happily compile it without public ever being needed. Since that should have been the case for this example, this high-level problem shouldn't have even come up for this code.

For any cases where we find that IR-level specialization does not do all the work, and dynamic dispatch appears to be needed, we probably need some kind of opt-in from the user to indicate their intention to use dynamic dispatch. Currently the API user can explicitly opt in to dynamic dispatch for specific interfaces by manually including lists of the conformances they want to be accounted for. In cases where the user doesn't provide those lists (or can't because they are using command-line slangc) we seemingly need a way to say "just enable dynamic dispatch for everything that the compiler thinks it needs"... a flag like -enable-dynamic-dispatch.

There's a more nuanced thing here, though, where it seems that at the very least we ought to be able to detect cases where the code we are generating creates an existential value based on the conformance B : IGetE, and determine that we probably need to account for that conformance when generating dynamic-dispatch logic for IGetE.
Summary
I'd like to address all these separate pieces, in approximately the order outlined above. I've assigned this issue to Yong so he can ideally get the first item resolved quickly.

This issue is fixed as I can no longer reproduce the error on top of tree.
The test has been enabled.


Show 'failed' result same as 'fail' result (error) in Heatmap

Fixes #1580

Codecov Report

Merging #1615 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1615   +/-   ##
=======================================
  Coverage   26.47%   26.47%
=======================================
  Files          72       72
  Lines        4537     4537
=======================================
  Hits         1201     1201
  Misses       3168     3168
  Partials      168      168

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5fec7b...b0021ab. Read the comment docs.


cannot use one time data binding when expanding array

If I use {{::val}} and I expand the tbody, the data is not updated. Can this be somehow fixed? Because I think using one time data binding here should work.

                           {{::val}}

If you use track by $index (in the rows repeater) you cannot use one time binding because ng repeat reuses the same elements. Either use one time binding OR track by $index


Add custom fonts section

Can we add a section about adding custom fonts i.e font-face etc.

@owenwas do you have an example? Adding custom fonts is just the same as adding it into any other site right?

@daviddarnes I was referring to how to include font assets. A font-face generator will throw out standard css i.e
src: url('/fonts/custom-webfont.eot');
src: url('/fonts/custom-webfont.eot?#iefix') format('embedded-opentype'),
etc.
etc.
So how do we include those assets in our template? -> switch 'url' to 'image' and include the font files in the structure as you normally would. I just think it would give any dev a helping hand if we have a little section relaying this info. What do you reckon?

@owenwas yea, I can see how that could be useful. Not a super high priority though as it can be worked out. Definitely something to return to.


commit conflict

as you can see, there are some open pull requests. some of them are has conflict on it. we are openly looking for anyone who able to fix it.
please let us know if you want to take this by comment in this issue. thank you ✨✨✨

should we move to using .json file?

this issue is fixed by #286 By using 1 JSON file/anime in folder datasources


fix(graph-circular.html/graph-grid-life.html/graph-label-rotate.html/…

…graph-multiple-edges.html/graph-simple.html/graph-symbol.html/graph.html/gridSimple.html): Max and Min zoom for graph charts. close #16178

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?

fix:Max and Min zoom for graphs charts.
Fixed issues

#16178
Details
Before: What was the problem?

Max and Min zoom for graphs charts was not good. It either zoom in too much or zoom out too much.

After: How is it fixed in this PR?

Max and Min zoom for graphs charts is improved, now it has both upper and lower limit.

Misc

[ ] The API has been changed (apache/echarts-doc#xxx).
[ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs
N.A.
Others
Merging options

[x] Please squash the commits into a single one when merging.

Other information

Hi! Thanks for your contribution. Please do not include the changes under dist.

I am trying to figure out the way so either I have to force push it or I have to close the pr and raise another one.
Or do you have any better suggestions then plz let me know?

Is it allowed to force push?

@sahilsaini110 You can do anything on your branch. We will squash merge your PR

Hi! Thanks for your contribution. Please do not include the changes under dist.

i have done this you may plzzz check now

@Ovilia @pissang may u now check this as I have done the changes

@pissang may u plz review this pr

What's this PR for. It only changes the test cases

What's this PR for. It only changes the test cases

that was the issue I think that the zoom effect was working properly.

What's this PR for. It only changes the test cases

that was the issue I think that the zoom effect wasn't working properly.

ooo ok ok I have made the changes in test file not in src sorry sorry I will correct may you plz help me a little bit.

I'm going to close this PR. Feel free to open a new one for the source code fix.


lib: ignore VS instances that cause COMExceptions

Checklist

[ ] npm install && npm test passes
Some tests are failing, but they also fail without my change.  I assume the CI system will catch actual failures.
[ ] tests are included
I see that find-visualstudio has pretty good test coverage, but I didn't see an obvious way to simulate this COM failure
[ ] documentation is changed or added
Are there user-facing docs for find-visualstudio?  I'd be happy to add a blurb about ignoring certain instances.
[x] commit message follows commit guidelines

Description of change
I have quite a few instances of VS installed and it looks like Find-VisualStudio.cs enumerates all of them, even when find-visualstudio.js already knows which one it wants (from the environment variable in the developer command prompt).  One of them (from 15.7.2, if that's interesting) causes a COMException on the ISetupInstance2.GetPackages call.  Ignoring such packages seems harmless and unblocks the rest of the run.
Note: an alternative approach would be to print a JSON blob with an empty packages list and let the caller reject it with an explicit error message.

@amcasey thanks for opening this PR! Ideally we would print an error message mentioning the COM issue, but I'll happily take this as is.
One thing though, I fear this might make any other problem in InstanceJson extremely confusing to debug. Can you catch the COMException explicitly?

@joaocgreis Works for me. :smile:

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/174/ ✔
The Travis failures are unrelated.
I'll land this early next week (we need to wait at least 48h).


chore: Add gitattributes for line endings

Docs Build status updates of commit 56b85e1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.gitattributes
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nschonni : Thanks for your contribution! The author, @, has been notified to review your proposed change.

Fixed in f25442f


Infer parameter matcher from route parameters

Describe the problem
Parameter matching is really useful, but could lead to increased / redundant complexity. For example, matching a UUID parameter is straightforward: src/routes/post/[id=uuid] whilst matching a slug parameter for a same-level route might be: src/routes/post/[slug=slug].
Describe the proposed solution
If a parameter matcher could be inferred from the route parameter, this could lead to simpler routes. For example, the route src/routes/post/[slug] would use the src/params/slug.js (or src/params/slug.ts) matcher if it existed, inferring the route parameter matcher as being slug. It should still be possible to explicitly define the route parameter matcher to use.
Alternatives considered
No response
Importance
nice to have
Additional Information
No response

I don't think that we'd want to add this, because with a growing code base you could run into situations where you want to name something slug but don't have it related to the matcher. Matchers are (in my view at least) not that commonly needed, so in my opinion this should be opt-in (as it is currently), not opt-out.

Good point @dummdidumm.
Personally, I didn't think I'd find matchers useful, but I have. I had a specific use case where I needed to make a request based on either the id or email and being able to separate the two routes simplified things. But beyond that, using a matcher to guard an endpoint and not make a metered API call is even better (yes, I did put this in shared module previously, but this feels tidier.)

The original plan was to do this, but it's a bad idea — aside from the case @dummdidumm brought up, it has several concrete downsides:

when creating a new route with a dynamic parameter, you have to check that you're not using the name of a matcher you don't intend to use
when creating a new matcher, you have to check that there aren't any routes that currently use it as the name of a dynamic parameter
the same goes whenever you're renaming parameters or matchers
there's no way for SvelteKit to distinguish between 'this route specifies a matcher that doesn't exist, throw an error' and 'this route doesn't specify a matcher' when the matcher is implicit
the route compiler loses the ability (which we're not currently taking advantage of, but might in future) to detect if two routes conflict, at least without introducing constraints on the order in which things happen
it's less explicit — someone learning the codebase must be aware of which matchers exist in order to parse the rest of the filesystem (and you have to keep that list in memory at all times)

I've often regretted APIs that attempted to save keystrokes; I've never regretted APIs that required explicitness!


How can I use function like vsprintf_s in wasm app

As the title.
I want to use vsprintf_s. but I got compile error when put it directly in my code.
I want to import it from native, but I don't know how to deal with the param va_list or ...

You'll need a libc implementation - most of that stuff is built into a libc, like WASI, which will give you access to them.


Properly bubble up InsertBlockFatalError

ref https://github.com/paradigmxyz/reth/pull/10217#pullrequestreview-2228744443
We need to introduce a way to handle any fatal errors that were encountered when calling insert_block.
This happens in two places not already handled, first in on_downloaded_block:
https://github.com/paradigmxyz/reth/blob/0ee689f3577048bebf3b97d642af69cded17a9c0/crates/engine/tree/src/tree/mod.rs#L1638-L1643
And in try_connect_buffered_blocks:
https://github.com/paradigmxyz/reth/blob/0ee689f3577048bebf3b97d642af69cded17a9c0/crates/engine/tree/src/tree/mod.rs#L1394-L1396
on_backfill_sync_finished calls try_connect_buffered_blocks here:
https://github.com/paradigmxyz/reth/blob/0ee689f3577048bebf3b97d642af69cded17a9c0/crates/engine/tree/src/tree/mod.rs#L502
The other call to try_connect_buffered_blocks is here:
https://github.com/paradigmxyz/reth/blob/0ee689f3577048bebf3b97d642af69cded17a9c0/crates/engine/tree/src/tree/mod.rs#L1628
However, we need to bubble the error in this method anyways or include it in TreeEvent somehow, because we call insert_block here and need to handle the error:
https://github.com/paradigmxyz/reth/blob/0ee689f3577048bebf3b97d642af69cded17a9c0/crates/engine/tree/src/tree/mod.rs#L1638-L1643

Is anyone on this? Could I take a stab at it?

Is anyone on this? Could I take a stab at it?

sure! let me know if you have any questions or need review

@Rjected emitting a fatal event is not ideal. we should properly bubble it up. @martinezjorge feel free to change the return types of methods in the flow in question


I'm completely lost but need a backup for Vaultwarden

Hello,
first of all thanks a lot for your tool which seems to be intended for a audience with better it-knowledge than I have.
I'm running Vaultwarden in a docker container on my mini-server with ubuntu 20.04 LTS.
If I understand you readme correct first of all I have to install and configure rclone. Which is the easiest way to do this on the Linux host using Microsoft OneDrive as cloud-storage?
The next step after succesfull installation/configuration of rclone would be to start docker-compose.yml for your tool and configure the environment variables and that's all there is to do?
After setting this up and running your container a backup is made every hour?
How exactly does rclone on the host interact with your container? This is something I don't understand.

If I understand you readme correct first of all I have to install and configure rclone.

Yes, Rclone just needs to be configured, you need to get the  on your computer and then enter the  into the server. See Rclone's documentation for more information.

Which is the easiest way to do this on the Linux host using Microsoft OneDrive as cloud-storage?

Using Rclone is the easiest way I know of to use cloud storage.

The next step after succesfull installation/configuration of rclone would be to start docker-compose.yml for your tool and configure the environment variables and that's all there is to do?

You can use the docker image without setting environment variables, but environment variables allow you to implement more features. After you finish configuring environment variables, start the container and that's all. Of course you can set some configurations for vaultwarden, you can read the WIKI for vaultwarden.

After setting this up and running your container a backup is made every hour?

How often to backup is configured by CRON, and there are also instructions for crond configuration in the documentation.

How exactly does rclone on the host interact with your container?

The backup tool is built on the rclone image (Dockerfile), so it includes the rclone command. It just uses the Rclone API to upload backup files to remote storage.

Thanks a lot for your answer ttionya.
How does rclone inside your container make use of the config/setup I have to configure on the host system?

https://rclone.org/remote_setup/#configuring-using-rclone-authorize

I finally managed to configure rclone in your docker image.
How often and when will vaultwarden be backed up?

Please read the Environment Variables carefully.

Works like a charm now!
Thanks a lot for helping.


test and use the (newly-inserted) delete with empty payload for truncate

Test, expose and then look into using it in the integrations (e.g. langchain)

Including in tests!


Gitter sidecar

@hexylena previously enabled embedding the Gitter sidecar to quickly access the admin Gitter channel from the admin tutorials. This allows the same to be specified on the tutorial level.
The sidecar will open the tutorial-level Gitter channel if defined, otherwise the topic-level Gitter channel, and defaults to the GTN lobby if neither are defined
Since @nomadscientist recently had the great idea to create a dedicated single-cell Gitter channel, I have specified this channel for the various single-cell tutorials (let me know if I've missed any)

Ace! I made a big speech at the end of the course about how nice you guys
were with helping, so hopefully! Also don't make me a liar! :-P
On Fri, Jun 12, 2020 at 11:19 AM Helena Rasche<EMAIL_ADDRESS>wrote:

@hexylena approved this pull request.
Tested it, it looks good! Big improvement, hopefully it helps users get in
touch with us more easily 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/galaxyproject/training-material/pull/1914#pullrequestreview-429627334,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUKCSPUGSKGSOVSARIFTMTRWH6KLANCNFSM4N4FMXLQ
.

Looks good, thanks a lot @shiltemann!


ccache: Cache is not building/restoring/saving

I've been debugging loooooong CMake build times on pimoroni-pico with ccache being the culprit. I remembered I probably inherited the ccache code from here, so when I figure out how to fix it, should probably fix it here too!
Check any action with ccache and you'll see a cache miss, and a fail to upload the resulting cache, it looks like ccache has changed to not use /home/runner/.ccache (~/.cache) by default anymore.

On non-Windows systems, the default is $HOME/.ccache if such a directory exists
if such a directory exists
🤔  we have a good ol' fashioned paradox.

Maybe we should set CCACHE_DIR explicitly like the mac build does... though it seems that one isn't working either.

Well that worked (and is extremely cursed!)
https://github.com/pimoroni/pimoroni-pico/pull/1032/commits/92902439107135407f911445d2441bbd27269785

My best sleuthing suggests that this change happened with ccache 4.0 on 2020-10-18.
I think we might have been riding on having an existing cache - which implicitly created the directory when restored - for much longer. It wouldn't break until cache misses started landing, and all branches get access to the default branch cache so that could have taken some time (long enough between main builds for the cache to expire?). That's my best theory for "why stable not stable" anyway.

This also seems to work: https://github.com/32blit/32blit-sdk/commit/9d6adb338d462e061c09781ed50bf636ff899c87
Relying on a fallback was probably always a bad idea, it's just weird that it suddenly broke now...


Fix progress bar behavior

Summary
Fixes #312

Technical Notes

custom 'proxied-content-lenght' header is removed from progress bar calculation, since the standard content-length is available in the latest version of Epinio
'Compress files' is now part of progress bar

I saw something much different than before after testing.

User is shown the Downloading Image step pretty much straight away (this is probably due to a super quick transition past the previous steps). This is ok
User is stuck on this step for a few minutes (we have an issue to check in production where the backend isn't local that this doesn't happen). This is possibly ok
User is shown the Compressing Files step but the progress bar does not change from what is was. Needs investigating
User is shown the browser download file dialog and we remove the dashboards export app dialog underneath. Think this is ok, but it feels like we should wait until the user has finished in the browser dialog before closing our's

The dialog is closed just before to show the progress reaching 100%
Agree, but I don't if there is a browser API to wait until the browser dialog is shown.

I would say, adding a debounce time of 1-2 seconds will solve both 3 and 4 . What do you think ?

Resolved conflicts with main

Edit: just re-read the quote. the original request should have read Image step.
Edit2: the progress bar goes from 0 --> 10 --> 100. I'd expect it to go 0 --> 10 (values completed) --> 20 (chart completed) --> 90 (image completed) --> 100 (compression completed

Do you mean for what you see from the video? Sorry it is misleading. I just remove the image phase to do a quick test and upload a short video.
In a real test it works as expected.

@torchiaf I think we discussed this in our sync up, I think there was something still left to do?

@torchiaf I think we discussed this in our sync up, I think there was something still left to do?

@richard-cox yep, there is still to solve that annoying issue when the bar freezes going from chart phase to image phase; I think this will require some fix on proxy request side.


LieGroup Python bindings.

I open this to start a discussion on the code. At the moment, the intended usage for the bindings is the following:
import pinocchio
R3 = pinocchio.liegroups.R3()
SO3 = pinocchio.liegroups.SO3()
R3xSO3 =R3 * SO3
R3xSO3.difference(...)

This is currently independent of the rest of pinocchio.
Here are the points which should be addressed / discussed before merging:

[ ] the code is not tested yet
[ ] if I understand the code correctly, dIntegrateTransport(Jin, Jout) is equivalent to dIntegrate(J); Jout = J * Jin;. In HPP, we also have the inverse operation and we have equivalent functions for dDifference.
[ ] should we add a LieGroupGeneric::operator== ?
[ ] maybe we should provide a way of create the lie group for a model.
[ ] integrateCoeffWiseJacobian_impl is not implemented. @jcarpent should it be ?

Feel free to edit this list and/or to push to my branch.

Thanks a lot @jmirabel for this very nice job, not finished yet, but promising.
For the second point, I would say that it would be useful to move all the features on the Parallel Transport on Lie groups inside Pinocchio. In this way, the feature would be complete and used by a broader audience. In terms of usage, your intuition is correct. The idea is to have access to the sparse multiplication in this way.
I think the operator== is always useful, and should be easily implemented thanks to current Variant API, in a similar that works for Joints.
Finally, we definitely need to have the possibility to extract a Cartesian product of the tree of joints for a given model. But, this feature might be implemented later on if needed.
On which part of the code do you need help?

On which part of the code do you need help?

The most orthogonal part is probably unit-testing.

For the second point, I would say that it would be useful to move all the features on the Parallel Transport on Lie groups inside Pinocchio. In this way, the feature would be complete and used by a broader audience. In terms of usage, your intuition is correct. The idea is to have access to the sparse multiplication in this way.

Does this really correspond to the mathematical meaning of a transport (https://en.wikipedia.org/wiki/Parallel_transport) ?
If no, then, I think the name is a bit misleading.

For the second point, I would say that it would be useful to move all the features on the Parallel Transport on Lie groups inside Pinocchio. In this way, the feature would be complete and used by a broader audience. In terms of usage, your intuition is correct. The idea is to have access to the sparse multiplication in this way.

Does this really correspond to the mathematical meaning of a transport (https://en.wikipedia.org/wiki/Parallel_transport) ?
If no, then, I think the name is a bit misleading.

In case of Lie groups, this is fine.

@jcarpent I don't have the rights to stop CI on travis. I think I used to have it...

me neither.

How should we call the operations:

dIntegrate * A: dIntegrateTransport(A)
A * dIntegrate: ?
dDifference * A: ?
A * dDifference: ?

Maybe, we should add an argument like applyOnTheRight, applyOnTheLeft.

I have always found it confusing because I never know what is applied on the left or right of what. In HPP, I added this enum which is more explicit

The API in HPP is space.dIntegrate_d[qv]<DerivativeTimesInput>(...) (and same for space.dDifference_dq[01]).

Yes, I do agree.
Or something like: dIntegrateRightAction and dIntegrateLeftAction.

Another possibility is to do the following.

Let dIntegrate return a temporary expression object of class DIntegrateReturnType that stores all the required information to compute the derivative.
Add two operators for matrix * DIntegrateReturnType and DIntegrateReturnType * matrix, that returns a DIntegrateProductReturnType`
Add method DIntegrateReturnType::evalTo(matrix_t& result)
Add method DIntegrateProductReturnType::evalTo(matrix_t& result)

This leads to the following API:
lg.dIntegrate_dq(...).evalTo(J);
( lg.dIntegrate_dq(...) * A ).evalTo(J);
( A * lg.dIntegrate_dq(...) ).evalTo(J);

Obviously, it is not as elegant as making DIntegrateReturnType and DIntegrateProductReturnType Eigen expressions, but it is far much easier (especially when dealing with several versions of Eigen).

Another notable point: I don't know how to nicely bind this API in Python.

The resulting struct will need a lot of information to be relevant. I was thinking of such a solution, but due to the variant and so on, I would say this might be very painful.
Maybe something like dIntegrate(SELF,A) and dIntegrate(A,SELF) introducing the SELF empty struct to mention the position of the operands.

The resulting struct will need a lot of information to be relevant.

If you implement it only for CartesianProductOperationVariantTpl, then it is not so verbose. I made a quick prototype. It looks like (with class CartesianProductOperationVariantTpl):
    template<typename Config_t, typename Tangent_t>
    struct DIntegrateReturnType {
      CartesianProductOperationVariantTpl const& self;
      const Eigen::MatrixBase<Config_t > & q;
      const Eigen::MatrixBase<Tangent_t> & v;

      DIntegrateReturnType(const CartesianProductOperationVariantTpl& self,
          const Eigen::MatrixBase<Config_t > & q,
          const Eigen::MatrixBase<Tangent_t> & v)
        : self(self), q(q), v(v) {}

      template <typename Derived>
      Derived& evalTo(const Eigen::PlainObjectBase<Derived>& result);

      Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic> eval()
      {
        Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic> result;
        evalTo(result);
        return result;
      }

      template <typename Derived>
      DIntegrateProductReturnType<Config_t, Tangent_t, Derived, true>
      operator* (const Eigen::MatrixBase<Derived>& other);
    };

    template<typename Config_t, typename Tangent_t, typename MatrixType, bool dIntegrateOnLeftSide>
    struct DIntegrateProductReturnType : DIntegrateReturnType<Config_t, Tangent_t> {
      const MatrixType& other;

      DIntegrateProductReturnType(DIntegrateReturnType<Config_t, Tangent_t>& self, const Derived& other)
        : self(self), other(other) {}

      template <typename Derived>
      Derived& evalTo(const Eigen::PlainObjectBase<Derived>& result);

      Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic> eval()
      {
        Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic> result;
        evalTo(result);
        return result;
      }
    };

Then outside class CartesianProductVariantTpl, define the operator*(matrix, cartesianproduct) as
  template<typename Derived,
    typename _Scalar, int _Options, template<typename,int> class LieGroupCollectionTpl,
    typename Config_t, typename Tangent_t>
  typename CartesianProductOperationVariantTpl<_Scalar,_Options,LieGroupCollectionTpl>::DIntegrateProductReturnType<Config_t, Tangent_t, Derived, false>
  operator* (const Eigen::MatrixBase<Derived>& lop,
             typename CartesianProductOperationVariantTpl<_Scalar,_Options,LieGroupCollectionTpl>::DIntegrateReturnType<Config_t, Tangent_t>& rop)
  {
    return typename CartesianProductOperationVariantTpl<_Scalar,_Options,LieGroupCollectionTpl>::
      DIntegrateProductReturnType<Config_t, Tangent_t, Derived, false>(rop, lop);
  }

Then you need to implement a visitor for each cases (as required for any other solution). We can easily make the ReturnType be templated by either difference or integrate.
This is probably more verbose than the solution you proposed, which would look like
lg.dIntegrate_dq(q, v, SELF, A, J);
lg.dIntegrate_dq(q, v, A, SELF, J);

I am fine with your solution too.

We may start with the first solution, producing easy Python bindings. And maybe think to the second one later. What do you think?
In the meantime, it would be nice if people like @proyan or @cmastalli can provide feedback, because, after HPP's developers, they are two more concerned people.

We may start with the first solution, producing easy Python bindings. And maybe think to the second one later. What do you think?

By first, you mean the following right ?
lg.dIntegrate_dq(q, v, SELF, A, J);
lg.dIntegrate_dq(q, v, A, SELF, J);

I am fine with this.

We may start with the first solution, producing easy Python bindings. And maybe think to the second one later. What do you think?

By first, you mean the following right ?
lg.dIntegrate_dq(q, v, SELF, A, J);
lg.dIntegrate_dq(q, v, A, SELF, J);

I am fine with this.

Yes, by the simplest solution.

@jcarpent I implemented what we agreed on for dIntegrate_d[qv]. Could you validate before I do the same for dDifference ?
I am a bit lost in how the argument position should be handled. Sometimes, there is a suffix _dq, sometimes an argument and sometimes a template argument... What is the reason for all those possibilities ?

This is fine for me. Just a minor remark. Thanks a lot !

I think I am done now.

I don't get CI failure. It seems the failure is unrelated (or something like exhausted memory or time). I tried to re-run the jobs but I don't see them being effectively re-run...

Can you rebase?

@jmirabel I think this PR is ready for merging, isn't it?

From my side, this is ok as a first implementation. Merging will allow people to give feedback.

I will make a new release in the following hours.


Cut release of vision API.

Also bumping the version on the uber-package.

I'm starting release notes from:
$ git log vision-0.25.0..HEAD --pretty=%H -- vision/
987dc826fe1ff16e4b3f06909ae9d9870a2faba2
14e570a3f435f8904ed9fa52d545a35ba5868ad1
3d9461b91963fcc6e6a864f6f0eacad3d92bbf2d
da3a7bbe8c7770540c2149fabfc6f74db89f7ce4
bc7b0fdb9fd99b2c86de9830a25cfaaa295b1c45
b9cb6d17236528ddce982c3e802af3221de80880
39feb3e23d451963ca31b383d8b395afcf7ab817
8ab1afec399b51a1114b7dc223cd2b4e386a3314

Not in release:

This PR: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/987dc826fe1ff16e4b3f06909ae9d9870a2faba2
PyPI links change: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/14e570a3f435f8904ed9fa52d545a35ba5868ad1
Author change in setup.py: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/da3a7bbe8c7770540c2149fabfc6f74db89f7ce4
nox change: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/bc7b0fdb9fd99b2c86de9830a25cfaaa295b1c45
nox change: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/b9cb6d17236528ddce982c3e802af3221de80880
LICENSE header change: https://github.com/GoogleCloudPlatform/google-cloud-python/commit/39feb3e23d451963ca31b383d8b395afcf7ab817

Release notes:

Fixing broken links after docs rename (#3631)
Add the ability to specify AnnotateImageRequest items in single-feature methods. (#3554)

After @lukesneeringer and I realized https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/vision-0.25.0 contained #3373, this has been downgraded to a micro release.

LGTM

Tag Build: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2591
Release: https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/vision-0.25.1

The build failed so I had to manually push to PyPI, but release is done: https://pypi.org/project/google-cloud-vision/0.25.1/


Show PnL on Leverage bot

blocked by https://github.com/VolumeFi/paloma/issues/1166
Formula:
(current price - price at deposit) * collateral amount - gas cost

@verabehr What is the gas cost in formula? Can I get this from the mybots api?

If there's a twap with multiple prices, the pnl in USD is
current_price * collateral_amount - (price_swap1 * amount_swap1 + price_swap2 * amount_swap2 + ...) - gas cost
where in the () we sum up price_swap * amount_swap for all swaps

The original formula (current price - price at deposit) * collateral amount - gas cost is still valid. There will be a small update on the backend to take twap into account, but it is not changing the structure of the data returned on the API

Fixed with https://github.com/VolumeFi/palomabot/pull/345


01-name.md

This is an  header, which is the largest
This is an  header
This is an  header, which is the smallest

nice


Disable tagify style sheets from modules

awkward that we need to do this. I'd expect since our tagify elements are more specific, they'd override the module ones.


Fix Saving

Again, this PR works without Discord.NET 1.0.0-rc because I did it in the browser. It should be a simple one to merge. Having tested on Everything Bot, this should fix saving. I've also implemented auto saving and a nice debug log for when it loads the save files.

Try that.

It should work now.

do you even test your code?
[Info] TicTacToe: Games file found. Loading.

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at gamebot.TicTacToe.ToClass (TicTacToeStruct t, Discord.DiscordClient client) <0x4171cc80 + 0x000a4> in <filename unknown>:0
  at gamebot.gamebot.Start () <0x416e4700 + 0x002db> in <filename unknown>:0
  at gamebot.gamebot.Main (System.String[] args) <0x416a9d50 + 0x00033> in <filename unknown>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
  at gamebot.TicTacToe.ToClass (TicTacToeStruct t, Discord.DiscordClient client) <0x4171cc80 + 0x000a4> in <filename unknown>:0
  at gamebot.gamebot.Start () <0x416e4700 + 0x002db> in <filename unknown>:0
  at gamebot.gamebot.Main (System.String[] args) <0x416a9d50 + 0x00033> in <filename unknown>:0

I do test it..

yes i did, i started it, then restarted and there's the error

Hmm. I'm not sure what's causing it. Are you able to uncomment the Console.WriteLines in TicTacToe.ToClass to see where it's erroring?

[Info] TicTacToe: Games file found. Loading.
146793203805192193
140564059417346049
313355648882704404
d
is null

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at gamebot.TicTacToe.ToClass (TicTacToeStruct t, Discord.DiscordClient client) <0x41286c80 + 0x001e6> in <filename unknown>:0
  at gamebot.gamebot.Start () <0x4169a700 + 0x002db> in <filename unknown>:0
  at gamebot.gamebot.Main (System.String[] args) <0x4165fd50 + 0x00033> in <filename unknown>:0
[ERROR] FATAL UNHANDLED EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object
  at gamebot.TicTacToe.ToClass (TicTacToeStruct t, Discord.DiscordClient client) <0x41286c80 + 0x001e6> in <filename unknown>:0
  at gamebot.gamebot.Start () <0x4169a700 + 0x002db> in <filename unknown>:0
  at gamebot.gamebot.Main (System.String[] args) <0x4165fd50 + 0x00033> in <filename unknown>:0

As the one who knows D.NET 0.9 (I've learnt 1.0.0-rc), why is client.GetChannel(t.Channel) returning null? I've checked in python and the t.Channel is a correct channel ID which I can use to get a channel, but in D.NET, it doesn't work. Any ideas?

Okay. I've undone the moving of the code out of Ready. I believe that that is the best bet. I'm not sure why Ready isn't firing for you as it is for me.

"As the one who knows D.NET 0.9 (I've learnt 1.0.0-rc), why is client.GetChannel(t.Channel) returning null?"
I believe client.GetChannel requires a channel ID, not a channel object.

I'll gove that a try in the morning. I also think that it's because it was being ran before the dapi had finished (it was outside the ready function).

I'm going to close this because I think it's another thing caused by D.NET 0.9 being a bit buggy.


fix: prevent Chinese examples from being converted to Unicode encoding

Using secure_ascii=False provides better support for Chinese characters directly
before:
[[ ## json_output ## ]]
[{"type": "narration", "content": "\u5c0f\u660e\u8d70\u51fa\u5bb6\u95e8\uff0c\u8ddf\u90bb\u5c45\u6253\u62db\u547c"}, {"type": "dialogue", "name": "\u5c0f\u660e", "reaction": "\u9ad8\u5174", "content": "\u4f60\u597d\u5440"}, {"type": "narration", "content": "\u90bb\u5c45\u5fae\u7b11\u671d\u4ed6\u70b9\u5934"}, {"type": "voiceover", "name": "\u90bb\u5c45", "reaction": "\u5185\u5fc3\u5947\u602a", "content": "\u8fd9\u5c0f\u5b50\u4eca\u5929\u600e\u4e48\u5bf9\u6211\u8fd9\u4e48\u6709\u793c\u8c8c"}]

[[ ## completed ## ]]

after:
[[ ## json_output ## ]]
[{"type": "narration", "content": "小明走出家门，跟邻居打招呼"}, {"type": "dialogue", "name": "小明", "reaction": "高兴", "content": "你好呀"}, {"type": "narration", "content": "邻居微笑朝他点头"}, {"type": "voiceover", "name": "邻居", "reaction": "内心奇怪", "content": "这小子今天怎么对我这么有礼貌"}]

[[ ## completed ## ]]

If examples containing Chinese strings are converted to Unicode encoding, the LLM tends to reply with Unicode encoded strings, resulting in a decrease in reply quality and additional decoding work

Thanks a lot @coolmian !


Code Coverage report stating last closing brace as uncovered

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:
Here is my class:
import { container, inject, injectable } from 'tsyringe';

import AppError from '@shared/errors/AppError';
import ILogger from '@shared/infra/logger/interfaces/ILogger';

import User from '../models/User';
import CheckIfUserExists from './CheckIfUserExistsUseCase';

interface IRequest {
  requestedUserId: string;
  requestingUserId: string;
  requestId: string;
}

@injectable()
class ShowUserUseCase {
  constructor(
    @inject('logger')
    private logger: ILogger
  ) {}

  public async execute({
    requestedUserId,
    requestingUserId,
    requestId,
  }: IRequest): Promise<User> {
    this.logger.log('info', 'Showing a User', {
      requestedUserId,
      requestingUserId,
      requestId,
    });

    const checkIfUserExists = container.resolve(CheckIfUserExists);
    const doesUserExist = await checkIfUserExists.execute({
      id: requestedUserId,
    });

    if (!doesUserExist) {
      this.logger.log('info', 'Requested user does not exist.', {
        requestedUserId,
        requestingUserId,
        requestId,
      });

      throw new AppError('User not found', {}, 404);
    }

    this.logger.log('info', 'User found.', {
      requestedUserId,
      requestingUserId,
      requestId,
    });

    return doesUserExist as User;
  }
}

export default ShowUserUseCase;

Here is the lcov output alongside jest

This happens to every single class of mine. As you can see, it is the only factor that makes this particular class not 100% on coverage of statements and lines. Also not sure why branches is not 100% covered here.
Expected behavior

I expected to a closing brace be a covered line of code.
envinfo

  System:
    OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (4) x64 Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz
  Binaries:
    Node: 12.19.0 - ~/.nvm/versions/node/v12.19.0/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.19.0/bin/npm
  npmPackages:
    jest: 26.6.1 => 26.6.1

This is an issue either with the transformer not providing correct source maps or with istanbul.
At the very least we'll need a full minimal reproduction we can pull down to run and test. Regardless I highly doubt it's a bug in Jest itself, but I've been surprised before 🙂

@SimenB okay! I'll work on the reproduction and get back to you soon. Made some tests here and looks like the problem is when two closing braces are after each other, whithout any characters between them (except for \n), like:
01: class A {
02:     method(){
03:      return;
04:     }
05: }

Line 4 will be marked as uncovered every single time.

@SimenB I've managed to reproduce the bug in: https://github.com/VIMGAS/jest-coverage-bug-reproduction
The README.md file states how to make it happen.

@VIMGAS I don't see the same:

(same for the other test files)
I'm unsure about the branches stuff - I'm guessing it has something to do with some generated code adding guards that are not hit?

Ah no wait! It works on Node 14 correctly, but with node 12 I get the same result as you do. Probably something to do with babel's transform then. I don't think it's an issue with Jest, tho?
Closing, but if you still think it's a bug in Jest we can reopen


Updates for SR2022 microgames

Update the API to be inline with sr-robot3. This just provide a minimal empty arena so the simulator can be used with microgames to move around and get used to the API.

I know about the issue in the typing tests. I don't want to put type hints into the example code so I need a way to just ignore typing in that file.

I haven't got time to do a full review I'm afraid. Looks like great work though, especially as we weren't planning to ship simulation this year. 🎉
A lot of the boilerplate code could be replaced by pulling in j5 as a dependency. I'm happy to do that after the physical kit is sorted out, but need to prioritise at the moment.

A lot of the boilerplate code could be replaced by pulling in j5 as a dependency.

This was my feeling but this was just a quick fix to get us through kickstart and microgames.


Tooltip for Heatmap

As a user I want to have more information in the heatmap itself.
While discussing changes regarding the trend or individual metrics I don't want to scroll to the table serveral times.
It would be great to show

the total score, the treshold and how many metrics are evaluated as yellow/red in the headline (score)
the actual value, the treshold and whether it's a key metric for every sli

Great request. I think this is super helpful when analyzing the heatmap - trying to get a quick understanding on why a certain metric is all of a sudden yellow or red. In a "day2day" life of a quality engineer you will analyze the heatmap with your peers and therefore hovering over and then seeing the score, the actual value and threshold as a tooltip would be extremely useful as it avoids annoying scrolling


Cleanup

Cleanup learned MACs when controller goes to inactive
Use peer name to get peer controller state instead of peer hostname

Yes... took me too long to figure out what pop() was doing in that context,
seems unnecessarily obscure.
On Fri, Nov 1, 2019 at 4:21 PM Yufeng Duan<EMAIL_ADDRESS>wrote:

@didovesei commented on this pull request.
In forch/faucet_state_collector.py
https://github.com/grafnu/forch/pull/46#discussion_r341781070:

@@ -177,6 +177,12 @@ def get_switch_state(self, switch, port, url_base=None):

     return result

def cleanup(self):

   """Clean up internal data"""

   self.learned_macs.clear()

   for switch_data in self.switch_states.values():

       switch_data.pop(LEARNED_MACS, None)

Do you mean switch_data[LEARNED_MACS].clear()?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/grafnu/forch/pull/46?email_source=notifications&email_token=AAIEPD62UCN53XKFP5H55GTQRS2XTA5CNFSM4JH5R4K2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCKCW2TY#discussion_r341781070,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEPD5ER6WASAPV3IA4ZB3QRS2XTANCNFSM4JH5R4KQ
.


Add ability to authenticate with IAP

Adds support for authenticating using the IAP jwt (prioritised over bearer token to avoid forged JWTs)
Add cryptography package for verifying the OAUTH audience

Yeah I think that's a great idea, I'll merge this for now to fix the issue, and move code to cpg-utils :)


Onece, onclose and company are missing arguments

There are a few places where arguments are not properly passed to events inside uws.js. The function "once" is somewhat broken and so is onclose. Easy to fix, up for grabs.

Example, this one is not passing close code or message to f:
https://github.com/uWebSockets/uWebSockets/blob/master/nodejs/dist/uws.js#L57


Dependencies are not installed by pip

pip install unifiedlog does not install the dependencies. Need to add install-requires to setup.py.

This is correct, if you want this you can add install_requires to your setup.py. Here is a write up of the tradeoffs https://caremad.io/posts/2013/07/setup-vs-requirement/

If you do plan to add it to setup.py I recommend to have it read them from requirements.txt, it is easier to control python2 or python3 only dependencies from there.

Sure, I knew this was your intent. That is dev-friendly. But I also believe the library must be user-friendly, easy to install and use.
Is there a way to have setup.py read from requirements.txt? I mean a built-in one liner instead of calling file open() and read() from within the setup.py code?

Is there a way to have setup.py read from requirements.txt? I mean a built-in one liner instead of calling file open() and read() from within the setup.py code?

yes, e.g. https://github.com/google/timesketch/blob/master/setup.py#L61

Great! Will look into it.

How do you generate a distribution package? When I use python setup.py sdist, it generates one without requirements.txt.
When I include code for install_requires, it renames the file to requires.txt and adds it to egg-info folder. Is there a way this can be controlled?

You should add it to MANIFEST.in e.g. include requirements.txt
E.g. https://github.com/google/timesketch/blob/master/MANIFEST.in

I'm still trying to understand this. Is that what you did when you generated the distribution package? Because yours (one on pypi) does have that file, but the current MANIFEST.in does not include it. So did you use a different MANIFEST.in? I'm just trying to replicate your work first before making changes.

I did not add it to MANIFEST.in. I just ran the commands described here: https://github.com/log2timeline/l2tdocs/blob/master/process/PyPI.md

which version of setuptools are you using? (I need to look) maybe that makes a difference

pip 9.0.3
setuptools  39.0.1

setuptools 40.4.3

I tried different versions of setuptools (including latest), and still can't get it to show up , without including it into MANIFEST.in
So, I will just do that for now.


CI: metrics: Jenkins: Do not run QA checks for metrics CI

When we are running the metrics CI we presume (or have checked)
that the QA tests already work. We do not need to run them again
before we run the metrics CI.
Thus, only run the QA checks when we are not under the METRICS_CI.
Fixes: #710
Signed-off-by: Graham Whaley<EMAIL_ADDRESS>

Seems like a network issue too on Fedora...
14:30:40 Cloning into '/home/jenkins/jenkins_slave/workspace/clear-containers-tests-fedora-26-PR/go/src/github.com/clearcontainers/runtime'...
14:30:40 fatal: unable to access 'https://github.com/clearcontainers/runtime/': Could not resolve host: github.com

rebuilding


net/textproto: ReadLineBytes() returns strange []byte

What version of Go are you using (go version)?
1.10.1
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
linux on x86 (64 bits). Testing same code on android and it's ok
What did you do?
with 1.9.4, it works
With my bot on irc, sometimes, it reads some things with the code as follow:
reader := bufio.NewReader(bot.conn)
tp := textproto.NewReader(reader)
line, err = tp.ReadLineBytes()
…

I try with tp.ReadLine() to get a string but it's the same error.
Sometimes, i have this:

ircbot[1179]: [202B blob data]
ircbot[1179]: [125B blob data]

If possible, provide a recipe for reproducing the error.
yes and no. If my friend speaks yes, it's me, no:
As i said before, my code works with go-1.9.4

11:46:03.872 event ▶ DEBU 0a2 ><EMAIL_ADDRESS>PRIVMSG #archlinux-fr :ça pourrait arriver en construisant une page web avec le bon titre par exemple
panic: runtime error: slice bounds out of range
ircbot[1049]: goroutine 11 [running]:
ircbot[1049]: main.(*Bot).searchToManyHL(0xc42009e5a0, 0xc4203c6020, 0xc42004fd78, 0xc420056600)
ircbot[1049]:         /home/julien/ircbot/event.go:465 +0x970
ircbot[1049]: main.event(0xc42009e5a0, 0xc4200565a0, 0xc420056600, 0xc420056660, 0xc420060120, 0xc42004fef8)
ircbot[1049]:         /home/julien/ircbot/event.go:153 +0xccd
ircbot[1049]: main.eventManagement(0xc42009e5a0, 0xc4200565a0, 0xc420056600, 0xc420056660, 0xc420060120)
ircbot[1049]:         /home/julien/ircbot/readWriteEventProcess.go:45 +0x1c9
ircbot[1049]: created by main.main
ircbot[1049]:         /home/julien/ircbot/app.go:52 +0x2ac
systemd[1]: ircbot.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
systemd[1]: ircbot.service: Failed with result 'exit-code'.

yes and no. If my friend speaks yes, it's me, no:

I'm sorry, what does that supposed to mean ?
Please post a self-contained working code which reproduces the issue.
Also, the error message that you have posted shows a panic on slice bounds out of range. But the issue you have reported is about ReadLineBytes() returning unexpected output. So which is the issue ? the panic or the unexpected output ?
Label suggestions - WaitingForInfo

My bad, i found my big mistake. Sorry for the inconvenience


[in_app_purchase] Expose the NSLocale object

This PR exposes the majority of the NSLocale object via the SKProductWrapper.
The values for NSLocaleExemplarCharacterSet and NSLocaleCalendar have been omitted, as they appear to be significantly more complex.
Related issues:

flutter/flutter#26610

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

Was there further discussion somewhere beyond what's in the issue? The issue suggested waiting and seeing if anyone actually needed this information before deciding to expose it, and I don't see anything there to suggest people have requested other information or provided use cases related to other fields, so it's not obvious why this is being done.

Was there further discussion somewhere beyond what's in the issue? The issue suggested waiting and seeing if anyone actually needed this information before deciding to expose it, and I don't see anything there to suggest people have requested other information or provided use cases related to other fields, so it's not obvious why this is being done.

Hi @stuartmorgan, this issue was on the list of "planned" items discussed offline between product managers. Since it was on the list treated as one of the issues agreed to be resolved. If you prefer we can rollback the changes and wait for more feedback on the issue.

Yes, let's revert this; adding a lot of API surface to maintain without any known clients doesn't seem like a good tradeoff.