Add ability to look up SMILES from ChEBI, PubChem, and ChEMBL

Rather than putting in SMILES into the fields, you can now use CURIEs like the following to get SMILES (all of these examples are for alsterpaullone:

chembl.compound:CHEMBL50894
chebi:138488
pubchem.compound:5005498

@torbengutermuth I've tested this locally and it appears to work. I added to the README an example as well:
curl -vvv -d 'smiles=chebi:138488' localhost:8000/api/names

You can try this yourself

Thank you very much for your contribution?
I just uploaded a commit that adds some information on correct/unbuildable/skipped molecules for the string input version of the SmartChemist.
Could you maybe
a)
Move your contribution to smart_chemist.py and call your function in the hand_string_input function, this would make it more-similar to existing handling of molecules.
b)
Could you also add a check if a smiles could be found and if not add +1 to the number problems variable so that this is tracked?
It is possible - even though it might be insufficiently documented - to enter , seperated lists into the SmartChemist and this would allow for easier handling of those and even mixed lists.


avoid use of identity

Pull Request Test Coverage Report for Build 2627
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 79.199%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

builtin/intrinsics.mbt
0
1
0.0%

Totals

Change from base Build 2624:
0.02%

Covered Lines:
3381

Relevant Lines:
4269

💛  - Coveralls


python package xgboost: libxgboost.so, 6: image not found?

Issue description
i can use numpy package to enter the repl, but it failed with xgboost.
even i add system library dependecy in default.nix, it still fail with "image not found"
in fact, it's dylib format on my mac os
larrys-MBP:tmp larluo$ ls -l /nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/
total 4120
-r-xr-xr-x  1 larluo  wheel  2106704 Jan  1  1970 libxgboost.dylib

Steps to reproduce
nix-shell -p python37Packages.numpy --run "python3"
nix-shell -p python37Packages.xgboost --run "python3"

larrys-MBP:tmp larluo$ cat default.nix
with import <nixpkgs> {};
with python37Packages;

buildPythonPackage rec {
  name = "larluo";
  src = ./. ;

  buildInputs = [ pkgs.xgboost ];
  propagatedBuildInputs = [ xgboost  ];

}

nix-shell

the log:
adding 'xgboost-0.72.dist-info/METADATA'
adding 'xgboost-0.72.dist-info/WHEEL'
adding 'xgboost-0.72.dist-info/top_level.txt'
adding 'xgboost-0.72.dist-info/RECORD'
removing build/bdist.macosx-10.6-x86_64/wheel
installing
/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/dist /private/var/folders/_3/80s5534109d2j8
3cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package
Processing ./xgboost-0.72-py3-none-any.whl
Requirement already satisfied: scipy in /nix/store/mhgmmg0bb3q8b37l7p2qfhfcrsw8kw89-python3.7-scipy-1.2.1/lib/python3.7/site-packages (from xgboost==0.72) (1.2.1$
Requirement already satisfied: numpy in /nix/store/6xh6gincdymys2wkzl2mwgf0742njad2-python3.7-numpy-1.16.2/lib/python3.7/site-packages (from xgboost==0.72) (1.16$
2)
Installing collected packages: xgboost
Successfully installed xgboost-0.72
/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package
post-installation fixup
strip is /nix/store/xcvvrjbck0n51603nnkyba3dszmhndi0-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib
patching script interpreter paths in /nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72
/nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib/python3.7/site-packages/xgboost/build-python.sh: interpreter directive changed from "/bin/s
h" to "/nix/store/yvw6l7vm91jnm2rb3ypzp563vnlns30s-bash-4.4-p23/bin/sh"

...
...
/nix/store/kfr460zka09dh3va1xkpyijqx9q7859k-python3.7-xgboost-0.72/lib/python3.7/site-packages/xgboost/rabit/test/local_recover.py: interpreter directiv[496/1883]
from "/usr/bin/python" to "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/bin/python"
running install tests
EEEEEEEEEEEEEE
======================================================================
ERROR: Failure: OSError (dlopen(/nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/libxgboost.so, 6): image not found)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/failure.py", line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/loader.py", line 417, in loadTestsFromName
    addr.filename, addr.module)
  File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/nix/store/d5b785bkqal1vnfbv8scjqqizfcgk5wj-python3.7-nose-1.3.7/lib/python3.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/tests/python/test_basic.py", line 3, in <module>
    import xgboost as xgb
  File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/__init__.py", line 11, in <
module>
    from .core import DMatrix, Booster
  File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/core.py", line 115, in <mod
ule>
    _LIB = _load_lib()
  File "/private/var/folders/_3/80s5534109d2j83cfgtwjcjc0000gn/T/nix-build-python3.7-xgboost-0.72.drv-0/xgboost/python-package/xgboost/core.py", line 109, in _loa
d_lib
    lib = ctypes.cdll.LoadLibrary(lib_path[0])
  File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/ctypes/__init__.py", line 434, in LoadLibrary
    return self._dlltype(name)
  File "/nix/store/8kzdflq0v06fq0mh9m2fd73gnyqp57xr-python3-3.7.3/lib/python3.7/ctypes/__init__.py", line 356, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: dlopen(/nix/store/nxvar5633zkqfkg23mkd5f27pp2avsl9-xgboost-0.72/lib/libxgboost.so, 6): image not found

Technical details
larrys-MBP:tmp larluo$ nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.01 MiB download, 0.03 MiB unpacked):
  /nix/store/qdgab1z17d2pff5ipzrlhhmhcpv8zyrr-nix-info
  /nix/store/w6j2wz4dkb2ma2v64ramg0z7nngisi2r-DarwinTools-1
copying path '/nix/store/w6j2wz4dkb2ma2v64ramg0z7nngisi2r-DarwinTools-1' from 'https://cache.nixos.org'...
copying path '/nix/store/qdgab1z17d2pff5ipzrlhhmhcpv8zyrr-nix-info' from 'https://cache.nixos.org'...
 - system: `"x86_64-darwin"`
 - host os: `Darwin 16.0.0, macOS 10.12`
 - multi-user?: `no`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.2.2`
 - channels(larluo): `"nixpkgs-19.09pre178484.8bc70c937b3"`
 - nixpkgs: `/Users/larluo/.nix-defexpr/channels/nixpkgs`

Closed in  #122234.


required property in referenced response

In this scenario my required properties are checked in the main response, not in nested config object. So it fails validation
yaml:
/system/config:
 get ...

responses:
        '200':
          description: Config list
          content:
            application/json:
              schema:
                allOf:
                  - $ref: '#/components/schemas/Config'
                  - $ref: '#/components/schemas/dataToken'

components:
  schemas:
   Config:
     type: object
      properties:
        systemName:
          type: string
     required:
        - systemName

if I change systemName to config  on required, it passes validation. which menas doesnt matter where required is, it always checks from main response object ?

Hi @gbkwiatt, thanks for raising this.
What’s in your dataToken schema, and what’s the validation error you’re getting?

dataToken schema is  just  another properties which are fine in this case.
without it I get same errors
dataToken:
      type: object
      properties:
        errorMessage:
          type: string
          example: ''
        errorCode:
          type: string
          example: ''
          enum:
            - ''
        token:
          type: string
          example: hbGciOiJIUzI1NiIsInR5cCI6...

validation error just says response should have required systemName, which it does but in response.body.config.systemName, but it looks for systemName inside response.body instead.

Okay, it looks like this isn't a bug, and your response schema is slightly different to your response body.
Your response body has response.body.config.systemName, but your response schema currently does not actually mention a config property. (Calling your schema Config does not make a difference in this respect).
Try this response schema:
        content:
            application/json:
              schema:
                allOf:
                  - type: object
                     properties:
                       config:
                         $ref: '#/components/schemas/Config'
                  - $ref: '#/components/schemas/dataToken'

Does that resolve your error?
(And if you get another error to do with allOf, check you are using allOf correctly - see this explanation https://github.com/RuntimeTools/OpenAPIValidators/issues/46#issuecomment-634572398)

Not sure what do you mean doesn't mention config?
I'm the code above under properties there is config property which schema is referenced, also if I add there required: - config, it is saysfied.
But then I can check required properties in the config itself.
I did read a bit about allOf problem, seems like it's widely misunderstood. But I can't see any workaround or correct way to do such a thing.


"japanese" Branch for Japanese translation.

I'd like to translate this excellent guideline to Japanese, our native language.
That's useful to add "japanese" branch so that we able to switch the language of this guideline.
Japanese Sencha community and I will translate it and send a pull request to the branch.
Hope you considering about it. :) :santa:

Just go ahead and fork the repo, then issue a PR and someone can merge/add the branch. @dongryphon is likely to be that person :-)

This issue was solved at #8 & #7.


HPA cannot scale down and kubectl top unstable

prometheus-operator: v0.29.0
kubeadm: 1.14.2
metrics-server: not installed
HPA:
It Can expand, but can not be reduced！
cat hpa-hpa.yaml
apiVersion: autoscaling/v1
kind: HorizontalPodAutoscaler
metadata:
name: php-apache-hpa
labels:
app: hpa-test
spec:
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: php-apache
minReplicas: 1
maxReplicas: 10
targetCPUUtilizationPercentage: 50
TOP:
the data is jittery
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
load-generator                0m           3Mi
php-apache-6696b744c7-974xv   0m           11Mi
php-apache-6696b744c7-gpn6w   0m           11Mi
php-apache-6696b744c7-wp4sn   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
load-generator                0m           3Mi
php-apache-6696b744c7-974xv   0m           11Mi
php-apache-6696b744c7-gpn6w   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
php-apache-6696b744c7-974xv   0m           11Mi
php-apache-6696b744c7-gpn6w   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
php-apache-6696b744c7-974xv   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
php-apache-6696b744c7-974xv   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
php-apache-6696b744c7-974xv   0m           11Mi
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
php-apache-6696b744c7-974xv   0m           11Mi
kubectl top pod
W0718 11:36:06.568216  110313 top_pod.go:266] Metrics not available for pod default/load-generator, age: 39m1.568199776s
error: Metrics not available for pod default/load-generator, age: 39m1.568199776s
kubectl top pod
NAME                          CPU(cores)   MEMORY(bytes)
load-generator                0m           3Mi
php-apache-6696b744c7-974xv   0m           11Mi
php-apache-6696b744c7-dsxcw   0m           11Mi
php-apache-6696b744c7-gpn6w   0m           11Mi
php-apache-6696b744c7-wp4sn   0m           11Mi
kubectl get pod
NAME                          READY   STATUS    RESTARTS   AGE
load-generator                1/1     Running   0          39m
php-apache-6696b744c7-974xv   1/1     Running   0          12m
php-apache-6696b744c7-dsxcw   1/1     Running   0          13m
php-apache-6696b744c7-gpn6w   1/1     Running   0          13m
php-apache-6696b744c7-wp4sn   1/1     Running   0          39m

cc @s-urbaniak @paulfantom we should look into this

same issue...

same issue...

Are you all successfully scraping cadvisor metrics? Can you share a graph of up{job="kubelet"}?

A signle Test node

And I found some logs from kube apiserver
loading OpenAPI spec for "v1beta1.metrics.k8s.io" failed with: OpenAPI spec does not exist

Can you share a screenshot of your /targets page of the Prometheus UI? There should be more than one kubelet target.

Can you share a screenshot of your /targets page of the Prometheus UI? There should be more than one kubelet target.

I am sorry for late reply

Curious. This does seem like it's a bug in the prometheus adapter.

At least for metrics present in k8s >= 1.15 we have a flaky metric:
sort(sum(rate(container_cpu_usage_seconds_total{namespace="monitoring",container!="POD",container!="",pod!=""}[1m])) by (pod,container))

container_cpu_usage_seconds_total returns different results upon subsequent executions. we have to look into cadvisor, why that is the case.

Example:

vs. (executed a few seconds later)

It seems that data is jittery because cadvisor library, which is vendored into kubelet and is responsible for providing basic pod metrics, decided to include timestamps to metrics exposition (added in google/cadvisor PR). This small change causes that basic container metrics might not be available at points in time (can be seen on a picture below) and causing kubectl top pod to be unreliable.

let's fix the query in https://github.com/coreos/kube-prometheus/blob/f458e85e5d7675f7bc253072e1b4c8892b51af0f/jsonnet/kube-prometheus/prometheus-adapter/prometheus-adapter.libsonnet#L22 then to a [5m] rate.

This is fixed in kube-prometheus.


Actually pass a task to the callback

andThen is broken if you don't pass tasks to callbacks.

Crap, thank you!


Export the DynamoDB table Stream Arn as an stack's output

Is your feature request related to a problem? Please describe.
Currently, there is no easy way to add a stream event, for example, to trigger a Lambda function, because the Stream Arn is not available in any stack. I've created a function using amplify function add, now, I want to edit the template to add an AWS::Lambda::EventSourceMapping but it is not possible except if I hardcoded the Stream Arn in the template, but, It will fail if I create a new environment.
Describe the solution you'd like
It will be awesome to have the DynamoDB table Stream Arn as an output, and exported using the process described in #986 and we will be able to add an AWS::Lambda::EventSourceMapping config to a function's template. Something like
"EventSourceMapping": {
	"Type": "AWS::Lambda::EventSourceMapping",
	"Properties": {
		"EventSourceArn": {
			"Fn::ImportValue": {
				"Fn::Join": [":",
                    [
                        { "Fn::Sub": "${ParentStackName}" },
                        "GetAtt",
                        "MyDynamoDBTable",
                        "StreamArn"
                    ]
                ]
			}
		},
		"FunctionName": {
			"Fn::GetAtt": ["LambdaFunction", "Arn"]
		},
		"StartingPosition": "TRIM_HORIZON"
	}
}

I can see that if I add the @searchable directive to one of my models, then the StreamArn is exported, but it is really hard to import that value because of the name of the export. If we have a friendly export name like suggested in #986 then it would be easy. But, the StreamArn  should be always exported and not depending on the @searchable directive.

Hi @mikeparisstuff,
I have the solution for this one, but, I'm having a hard time with the tests. I thought that my changes were breaking something, so, I revert it, then run the tests again, and it still fails. Removed my local copy of the code, clone it again, run npm install, npm run setup-dev, npm run test and it still fails. This is a small part of the error

lerna ERR! npm run test exited 1 in 'amplify-graphql-types-generator'
lerna ERR! npm run test stdout:

<EMAIL_ADDRESS>test G:\amplify-cli\packages\amplify-graphql-types-generator
jest
lerna ERR! npm run test stderr:
FAIL test/loading.ts (9.515s)
● Validation › should extract gql snippet from javascript file
expect(value).toMatchSnapshot()
Received value does not match stored snapshot "Validation should extract gql snippet from javascript file 1".

I'm attaching the full error in amplify-cli-error.log
Are the tests working for you? Am I missing some config in my local copy?
I would like to make a PR but I'm stuck :-(

We would highly benefit from the Stream ARNs to be outputs as well. There's no way to export that ARN from a nested template, as far as I can tell. I also attempted to edit the Amplify CloudFormation templates to add output variables, but my changes get overwritten of course. I ended up writing a command line process to use the AWS command line to output the Stream ARNs to a file as a workaround.

@kstro21 - has this feature been released?

@zfarrell, that is a question for @kaustavghosh06 and @mikeparisstuff

@mikeparisstuff As I can see this is merged to master may I know why it hasn't been released yet? @kstro21 Could you please confirm the same?

Hey, @babu-upcomer, it has been released, I can confirm that.
For example, if you have a model named Article, running amplify api gql-compile will generate a template in amplify\backend\api\[my-api-name]\build\stacks\Article.json containing an output
"GetAttArticleTableStreamArn": {
    "Description": "Your DynamoDB table StreamArn.",
    "Value": {
        "Ref": "GetAttArticleTableStreamArn"
    },
    "Export": {
        "Name": {
            "Fn::Join": [
                ":",
                [
                    {
                        "Ref": "AppSyncApiId"
                    },
                    "GetAtt",
                    "ArticleTable",
                    "StreamArn"
                ]
            ]
        }
    }
},

After deploying it, you can check the outputs in the AWS CloudFormation console if you like.
Hope it helps

Thanks for the reply! I thought that it would be exported into
aws-exports.js.
On Tue, 6 Aug 2019 at 7:56 PM, Castro Roy<EMAIL_ADDRESS>wrote:

Hey, @babu-upcomer https://github.com/babu-upcomer, it has been
released, I can confirm that.
For example, if you have a model named Article, running amplify api
gql-compile will generate a template in
amplify\backend\api[my-api-name]\build\stacks\Article.json containing an
output
"GetAttArticleTableStreamArn": {
"Description": "Your DynamoDB table StreamArn.",
"Value": {
"Ref": "GetAttArticleTableStreamArn"
},
"Export": {
"Name": {
"Fn::Join": [
":",
[
{
"Ref": "AppSyncApiId"
},
"GetAtt",
"ArticleTable",
"StreamArn"
]
]
}
}
},
After deploying it, you can check the outputs in the AWS CloudFormation
console if you like.
Hope it helps
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-cli/issues/987?email_source=notifications&email_token=AEYGSBHLFQWRENEIMOD2FGTQDGCZZA5CNFSM4G4KFGJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VKBGY#issuecomment-518693019,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEYGSBHTW2C355PHGHHDC3DQDGCZZANCNFSM4G4KFGJQ
.

--
Babu
Cofounder & CTO | Upcomer Inc.,
site: www.upcomer.com
skype: babu.somasundaram

Thanks for the reply! I thought that it would be exported into aws-exports.js.

Since the CF template sits in stacks/ and is nested I wasn't able to refere to the variable in my custom lambda CF template (custom category). I can only access the api's GraphQLAPIIdOutput output variable. Currently as work-around i am extracting the StreamArn via:
"Fn::ImportValue": {
	"Fn::Sub": [
		"${apiId}:GetAtt:MyModelTable:StreamArn",
	{
		"apiId": {
			"Ref": "apiresourcenameGraphQLAPIIdOutput"
		}
	}
	]
}

Is there any way to avoid the above work-around?

Hi, @psporysz, I think it is not a workaround, it is the way to do it. Note you can write it like
"Fn::ImportValue": {
	"Fn::Sub":  "${apiresourcenameGraphQLAPIIdOutput}:GetAtt:MyModelTable:StreamArn"
}

It is easy to read

Hi. Thanks for feedback above. If it helps anyone, I summarized the recommendations above in this project:
https://github.com/matwerber1/aws-amplify-subscribe-lambda-to-dynamodb-api-table-stream/


Mystery text discussion of cpi.txt

Post your screenshots and discuss your findings about cpi.txt here!

image1:
image2:

image3:

Through my studying and discovering in AntConc, I found that the larger the N-Gram size, the smaller the word's frequency. When I choose N-Gram size 1, the largest words frequency that appear in the text is "the"; the text has 3060 "the"; which means "the" is the highest frequency words in the whole text. The N-Gram size 5 and 6 have the word frequency that under "5", those words are the low frequency words within the text. The "KWIC" help me to see the lest content and right content of the selected words or phrase. This is very helpful for people who want to manage the word or to quickly find where the specific word or phrase is.

Frequent phrases:
of the - 330
the prime minister - 42
shook his head - 18
i don't know - 9
the london and scottish bank - 6
In AntConc, I also found that the n-gram size increases, the word's frequency decreases. The words "the" and "of" are used the most in the text. I also noticed that the phrase "the london and scottish bank" is used quite often. I'm assuming that the text has something to do with money. The setting of the story seems to take place in Europe because of the references to the phrase "the prime minister". I am going to guess and say the story is about a bank robbery or detectives trying to backtrack a bank robbery.


Enhanced Due Date Handling

Improving the input experience for due dates, including natural language phrasing such as "today", "tomorrow" etc.

Closed as functionality was implemented as a part of a bugfix


⚠ Bofrost.at has degraded performance

In 7e67576, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 900 ms

Resolved: Bofrost.at performance has improved in 8af0d24 after 26 minutes.


fix(search): hide x icon on IE

Hides the X icon added on IE11 search inputs.
Closes https://github.com/carbon-design-system/carbon-components/issues/412

Thanks @joshblack @tw15egan


test(router-link): new tests for router-link

New tests for router-links.
Note: These tests fail, leaving them here for visibility.

:+1:


Networking stack buffer management update

This is an umbrella issue for the set of architectural changes and optimizations discussed during Zephyr Networking Forum, 12th of December 2017.  The forum materials are under this link
A key dependency to it is the new design of networking buffers, proposed by @jhedberg  in #3283
In terms of implementation, we have identified the following breakdown:

[ ] Introducing compound buffer to the net stack

[ ] Introduce the buffers to core stack
[ ] Validate 6LoWPAN and TCP scenarios
[ ] Prototype use of external buffers

[ ]  Socket API update
[ ] IP stack high-level API update

[ ] API update
[ ] Update protocols

[ ] IP offloading API update

One thing I am curious about -- are we planning on introducing some method to have the network stack use a user-suppiled set of buffers or allocation function?
I think we are going to want to provide a way for User Mode threads to work with the network stack, which I think would require that the buffers involved be in a section of memory writable to user mode. As yet nobody has looked into this in detail, but I hope we can take this into consideration if we are doing an API overhaul.

@tbursztyka : Probably worth posting an update here.

This issue is quite old and mostly bitrotted. We have the code mostly changed/converted anyway, there are couple of PRs still pending. I suggest that this is closed.

Closing this as the net_pkt work is done.


Improve FutureOr usage only when necessary

:scroll: Description
We should only use FutureOr<T> when we don't know its type.
We should always use Future<T> or T when we know the return type.
We should only await if its a Future, we can check the return type of a FutureOr<T> method.
We always implement an interface and only extend when we need to make use of its default methods.
Tests should only be async if its awaiting for a Future.
We should always honor the return type of an interface, for example, SentryEvent? instead of SentryEvent.
:bulb: Motivation and Context
Also fixes https://github.com/getsentry/sentry-dart/issues/1336
Screenshots and View hierarchy should only be added to errors and not transactions.
:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[ ] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[ ] All tests passing
[ ] No breaking changes

:crystal_ball: Next steps

@marandaneto Would it be possible to check this by a lint rule?

@marandaneto Would it be possible to check this by a lint rule?

only if we make the linting rules ourselves, they don't exist just yet afaik.


Please add licensing information

This repository is lacking licensing information. As such, everything included in this repo is "All rights reserved".
Please note that in order to re-license this project you'll legally need ack from all existing contributors.

Closed by bdbda6e


Add synchronous helpers for HTTP1 pipeline setup

Motivation:
We recently added a synchronous view of the ChannelPipline so that
callers can avoid allocating futures when they know they're on the right
event loop. We also offer convenience APIs to configure the pipeline for
particular use cases, like an HTTP/1 server but we don't have
synchronous versions of these APIs yet. We should have parity
between as synchronous and asyncronous APIs where feasible.
Modifications:

Add synchronous helpers to configure HTTP1 client and server pipelines

Result:
Callers to synchronously configure HTTP1 client and server pipelines.

Is there any reason you asserted in event loop, instead of preconditioned?

Existing checks are all assertions (all the way down to implementations in ChannelPipeline). Should we add preconditions to the top-level methods in SynchronousOperations?

@glbrntt sadly 5.4 allocs aren't happy
13:47:34 ++ max_allowed=468050
13:47:34 ++ assert_less_than_or_equal<PHONE_NUMBER>50
13:47:34 ++ [[ ! 469000 -le 468050 ]]
13:47:34 ++ fail 'assertion '\''469000'\'' <= '\''468050'\'' failed'
13:47:34 ++ echo 'FAILURE: assertion '\''469000'\'' <= '\''468050'\'' failed'
13:47:34 FAILURE: assertion '469000' <= '468050' failed
13:47:34 ++ false


⚠ Bofrost.es has degraded performance

In 3090d30, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1974 ms

Resolved: Bofrost.es performance has improved in 2e940a7.


Add note on owner references back to garbage collection page

Fixes: https://github.com/kubernetes/website/issues/29480
Adds note on owner references back to garbage collection page that was removed in https://github.com/kubernetes/website/pull/28870
/kind cleanup
/kind documentation
/language en
/sig api-machinery
/sig docs
/priority important-soon
/cc @liggitt
/assign @jimangel @sftim

/hold for reviews

@kubernetes/sig-api-machinery-pr-reviews please provide a tech review and verify this PR fixes issue https://github.com/kubernetes/website/issues/29480

/approve

/lgtm
/hold cancel
thanks for the quick fix

Thanks for the PR and sorry for the oversight here @liggitt


Enable use of release drafter

Make use of release-drafter for building release notes and computing
the next version using semver meaning of merged PRs.
This config is based on the one already used by molecule and
ansible-lint. Results can be seen at https://github.com/ansible-community/molecule/releases
The release manager still has the freedom to change the release
notes manually.
Fixes: #558

This needs a discussion. I don't like the idea of untracked change fragments.

They are not really untracked, we could easily add a rule to update tracked release notes before a release. Keep in mind that this change brings us a decent level of information regarding what was included in a release, including ability to open a discussion thread on each release. It is low maintenance approach, and much better the the current zero-release notes.
We can keep the original ticket open if you want. IMHO, it is an ok tradeoff which proved to work fine for a number of years.

The fragments are not tracked in Git. It's a vendor-lock on GitHub without any ability to build the change log offline.

Point is that I cannot generate a changelog with a simple tox command having GitHub unavailable.

recheck

@webknjaz Please reconsider this. Lets put it from another point of view: I do not expect this to change the project process for producing changelog. I only want to get something meaningful as comment on https://github.com/ansible/ansible-navigator/releases page. Currently we have zero content there.
Argumentation that this does not make everything perfect does not help improving the situation. I propose to activate this now, until we find a replacement that fits all requirements. I prefer a progressive improvement today, than the perfect implementation that never happens to be implemented.

@ssbarnea Given the flurry of work in the repo recently is this still needed?


Incorrect warning when using web updater

Using Orchest whilst updating is NOT recommended. should not be displayed when using the web updater.

Why should it not be displayed? The functionality is different then before. We used to shutdown containers whilst now we don't and so Orchest now is usable during the update in contrast to before.

I consider this as not a bug and will close the issue. Feel free to reopen if you don't agree.


History Time To Live cannot be null

I'm trying to deploy process using api deploymentApi.createDeployment. Unfortunately I have error:
Caused by: org.camunda.community.rest.client.invoker.ApiException: {"type":"ParseException","message":"ENGINE-09005 Could not parse BPMN process. Errors: \n* History Time To Live cannot be null: History Time To Live cannot be null}
I found in the documentation that I need to set the property camunda.bpm.generic-properties.properties.historyTimeToLive
https://forum.camunda.io/t/camunda-7-20-history-time-to-live-cannot-be-null-cannot-deploy-wf-created-in-7-18/48159
or change default value enforceHistoryTimeToLive to false
https://docs.camunda.org/manual/latest/reference/deployment-descriptors/tags/process-engine/?_gl=1*116lgtf*_ga*MjAwNzkwOTQ5My4xNjg0OTk3MDM0*_ga_4EYN8X5FNR*MTcwNTM0NzIxMy4yMi4xLjE3MDUzNDczMzguNTkuMC4w#configuration-properties
Setting in application.yml file:
camunda:
  bpm:
    generic-properties:
      properties:
        historyTimeToLive: P1D

don't work.
How can I set this value using camunda-platform-7-rest-client-java library?

@mrynasiewicz the property to set a default history time to live is set to the engine.
If you want to have a default TTL being set by this client, you should provide a feature request.


[BUG] Budget "Printing Improvements" are condensed onto half width of page

Describe the bug
When attempting to print a month's budget, the budget is condensed into a column about half the width of the page. It appears that the right sidebar is merely blanked out, but still physically takes up room in the printing layout.
I initially thought this was due to Microsoft Edge being weird again, but it occurs in Chrome as well. I have not tested Firefox. No other browser extensions (i.e. uBlock, etc.) are enabled that might cause interference. Issue occurs regardless of portrait or landscape orientation, as well as with both my settings and default Toolkit settings.
Likely as a result, the column headers don't align properly with the columns themselves. I've also seen the column text overlap with adjacent columns due to the text being so condensed (doesn't show in screenshot due to everything being zeroed out). In addition, the month label shows up but  "to be budgeted"/age of money/etc. does not appear (unsure if this is intentional or not).
To Reproduce
Steps to reproduce the behavior:

Activate the "Printing Improvements" feature under the "General" settings of the YNAB Toolkit
Open any month's budget
Attempt to print the page

Expected behavior
The budget should take up the entire width of the page.
Screenshots

Without Printing Improvements

With Printing Improvements

Desktop (please complete the following information):

OS: Windows 10 Education 20H2
Browser: Microsoft Edge (Chromium) 87.0.664.66, Google Chrome 87.0.4280.141
Toolkit Version: v2.30.0 from Chrome Webstore

Setting Export
Please replace the text below with your exported Toolkit settings. You can export these by going to the Toolkit Options page, click the Import/Export Settings button at the bottom left and copying the text in the modal which appears.
Note: This occurs with default Toolkit settings as well.
[{"key":"AccountsDisplayDensity","value":"0"},{"key":"AccountsEmphasizedInflows","value":true},{"key":"AccountsEmphasizedOutflows","value":false},{"key":"AccountsStripedRows","value":true},{"key":"AccountsStripedRowsColor","value":"#fdfdfd"},{"key":"AccountsStripedRowsDarkColor","value":"#1e1e1f"},{"key":"AssistedClear","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"AutoEnableRunningBalance","value":false},{"key":"AutomaticallyMarkAsCleared","value":false},{"key":"BetterScrollbars","value":"0"},{"key":"BottomNotificationBar","value":false},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":true},{"key":"BudgetSpendingGoal","value":true},{"key":"BulkEditMemo","value":true},{"key":"BulkManagePayees","value":false},{"key":"CalendarFirstDay","value":"0"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"2"},{"key":"CategorySoloMode","value":"0"},{"key":"ChangeEnterBehavior","value":false},{"key":"ChangeMemoEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":true},{"key":"ConfirmKeyboardCancelationOfTransactionChanges","value":true},{"key":"CreditCardEmoji","value":true},{"key":"CtrlEnterCleared","value":false},{"key":"CurrentMonthIndicator","value":false},{"key":"CustomFlagNames","value":false},{"key":"DateOfMoney","value":true},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingDate","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DeselectTransactionsOnSave","value":false},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":true},{"key":"EasyTransactionApproval","value":false},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"FilterCategories","value":true},{"key":"GoalIndicator","value":true},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"2"},{"key":"HideAgeOfMoney","value":false},{"key":"HideClosedAccounts","value":false},{"key":"HideDebtRatio","value":false},{"key":"HideHelp","value":true},{"key":"HideReferralBanner","value":true},{"key":"HideTotalAvailable","value":false},{"key":"HighlightNegatives","value":true},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"1"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":true},{"key":"LinkToInflows","value":true},{"key":"MasterCategoryRowColor","value":true},{"key":"MemoAsMarkdown","value":false},{"key":"MonthlyNotesPopupWidth","value":"2"},{"key":"NavDisplayDensity","value":"0"},{"key":"NotesAsMarkdown","value":true},{"key":"POSStyleCurrencyEntryMode","value":false},{"key":"Pacing","value":"0"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconcileBalance","value":true},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":true},{"key":"RemoveZeroCategories","value":true},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"SeamlessBudgetHeader","value":true},{"key":"SetMultipleFlags","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"SpareChange","value":false},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":true},{"key":"StealingFromFuture","value":true},{"key":"StripedBudgetRows","value":false},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleAccountColumns","value":true},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"2"},{"key":"ToolkitReports","value":true},{"key":"UnclearedAccountHighlight","value":true},{"key":"ViewZeroAsEmpty","value":true},{"key":"l10n","value":"0"},{"key":"options.dark-mode","value":false}]

I'm seeing the same issue, on the following system:
Desktop (please complete the following information):

OS: Linux Mint 20.2 Uma (based on Ubuntu 20.04)
Browser: Brave Browser Version: 1.29.81 Chromium: 93.0.4577.82 (Official Build) (64-bit)
Toolkit Version: v2.35.1 from Chrome Webstore.


[WIP] Reduce broker/apb sandbox permissions

Describe what this PR does and why we need it:
Changes proposed in this pull request

Update asb cluster role binding to admin cluster role instead of
cluster-admin.
Update the apb sandbox cluster role that we target for the namespaced
role binding to be edit instead of cluster-admin.

I used catasb to create a cluster:
➜  linux git:(da22d0a) ✗ cat ../../config/my_vars.yml
---
dockerhub_user_name: changeme
dockerhub_user_password: changeme
dockerhub_org_name: ansibleplaybookbundle
asb_template_url: file:///home/dzager/go/src/github.com/openshift/ansible-service-broker/templates/deploy-ansible-service-broker.template.yaml

broker_image_name: docker.io/djzager/origin-ansible-service-broker
broker_tag: latest

Relevant portion of template deploy-ansible-service-broker.template.yaml:
- apiVersion: v1
  kind: ServiceAccount
  metadata:
    name: asb
    namespace: ansible-service-broker

- apiVersion: v1
  kind: ClusterRoleBinding
  metadata:
    name: asb
  roleRef:
    name: admin
  subjects:
  - kind: ServiceAccount
    name: asb
    namespace: ansible-service-broker

Cluster role binding for ansible service broker:
➜  linux git:(da22d0a) ✗ oc get clusterrolebindings asb -o yaml
apiVersion: v1
groupNames: null
kind: ClusterRoleBinding
metadata:
  creationTimestamp: 2017-08-23T19:07:03Z
  name: asb
  resourceVersion: "1358"
  selfLink: /oapi/v1/clusterrolebindings/asb
  uid: 3f8be27d-8836-11e7-a068-54e1ad07cf60
roleRef:
  name: admin
subjects:
- kind: ServiceAccount
  name: asb
  namespace: ansible-service-broker
userNames:
- system:serviceaccount:ansible-service-broker:asb

The running broker:
➜  ansible-service-broker git:(apb-sa) ✗ oc get pods asb-1-wwqdv -o yaml
apiVersion: v1
kind: Pod
spec:
  containers:
  - env:
    - name: BROKER_CONFIG
      value: /etc/ansible-service-broker/config.yaml
    - name: INSECURE
      value: "false"
    image: docker.io/djzager/origin-ansible-service-broker:latest
    imagePullPolicy: IfNotPresent

The apb sandbox rolebinding:
➜  ansible-service-broker git:(apb-sa) ✗ oc get rolebindings -n my-project apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1  -o yaml
apiVersion: v1
groupNames: null
kind: RoleBinding
metadata:
  creationTimestamp: 2017-08-23T19:16:14Z
  name: apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1
  namespace: my-project
  resourceVersion: "2220"
  selfLink: /oapi/v1/namespaces/my-project/rolebindings/apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1
  uid: 88337c29-8837-11e7-a068-54e1ad07cf60
roleRef:
  name: edit
subjects:
- kind: ServiceAccount
  name: apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1
  namespace: my-project
userNames:
- system:serviceaccount:my-project:apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1

Projects after provisioning (and binding) MediaWiki + MariaDB:
➜  ansible-service-broker git:(apb-sa) ✗ oc get pods -n my-project
NAME                                       READY     STATUS      RESTARTS   AGE
apb-093048c8-89f1-4a29-861c-ac7dae56dc0d   0/1       Completed   0          16m
apb-2568682c-3983-42df-b6c3-4da8a85b813f   0/1       Completed   0          18m
apb-8c8ff2f7-2fd7-4b72-95af-baa3bc545de1   0/1       Completed   0          17m
apb-9fa7ab1c-1bac-4150-af36-81d95ff100f8   0/1       Completed   0          9m
apb-bc69af0d-97da-4113-a4c8-32fa0442ed1c   0/1       Completed   0          9m
apb-e076764d-43e6-4800-bd93-3962aae9c3f1   0/1       Error       0          9m
apb-e6d7e68f-c575-4fe1-97da-230bf3bcd4ef   0/1       Completed   0          16m
mediawiki123-2-jd2f0                       1/1       Running     0          14m
rhscl-mariadb-1-4v030                      1/1       Running     0          15m

Relevant portion of MediaWiki config:
➜  ansible-service-broker git:(apb-sa) ✗ oc get pods -n my-project mediawiki123-2-jd2f0 -o yaml
apiVersion: v1
kind: Pod
metadata:
  name: mediawiki123-2-jd2f0
  namespace: my-project
spec:
  containers:
  - env:
    envFrom:
    - secretRef:
        name: dh-ansibleplaybookbundle-rhscl-mariadb-apb-latest-2mbl5-yghly

Running tests:
➜  ansible-service-broker git:(apb-sa) ✗ make ci
./scripts/broker-ci/local-ci.sh
+ provision
+ oc create -f ./scripts/broker-ci/mediawiki123.yaml
instance "mediawiki" created
+ oc create -f ./scripts/broker-ci/postgresql.yaml
instance "postgresql" created
+ ./scripts/broker-ci/wait-for-resource.sh create pod mediawiki
+ ./scripts/broker-ci/wait-for-resource.sh create pod postgresql
+ error-check provision
+ set +x
+ bind
+ print-with-green 'Waiting for services to be ready'
+ echo -e '\033[0;32mWaiting for services to be ready\033[0m'
Waiting for services to be ready
+ sleep 10
+ oc create -f ./scripts/broker-ci/bind-mediawiki-postgresql.yaml
binding "mediawiki-postgresql-binding" created
+ ./scripts/broker-ci/wait-for-resource.sh create bindings.v1alpha1.servicecatalog.k8s.io mediawiki-postgresql-binding
+ error-check bind
+ set +x
+ pickup-pod-presets
+ print-with-green 'Checking if mediawiki recieved bind credentials'
+ echo -e '\033[0;32mChecking if mediawiki recieved bind credentials\033[0m'
Checking if mediawiki recieved bind credentials
+ bind-credential-check
+ set +x
pod "mediawiki123-1-s3s0n" deleted
Pod presets not found in the Mediawiki pod
Retrying...
pod "mediawiki123-1-ptgv3" deleted
Pod presets found in the Mediawiki pod
+ error-check pickup-pod-presets
+ set +x
+ verify-ci-run
++ oc get route -n default
++ grep mediawiki
++ cut -f 4 -d ' '
+ ROUTE=mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page
++ curl mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page
++ grep 'div class'
++ cut -f 2 -d \'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13665    0 13665    0     0  39248      0 --:--:-- --:--:-- --:--:-- 39267
+ BIND_CHECK='

catlinks

p-navigation

p-tb

'
+ print-with-yellow 'Running: curl mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page| grep "div class" | cut -f 2 -d "'\''"'
+ echo -e '\033[0;33mRunning: curl mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page| grep "div class" | cut -f 2 -d "'\''"\033[0m'
Running: curl mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page| grep "div class" | cut -f 2 -d "'"
+ '[' '

catlinks

p-navigation

p-tb

' = error ']'
+ '[' '

catlinks

p-navigation

p-tb

' = '' ']'
+ print-with-green SUCCESS
+ echo -e '\033[0;32mSUCCESS\033[0m'
SUCCESS
+ print-with-green 'You can double check by opening http://mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page in your browser'
+ echo -e '\033[0;32mYou can double check by opening http://mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page in your browser\033[0m'
You can double check by opening http://mediawiki123-default.<IP_ADDRESS>.nip.io/index.php/Main_Page in your browser
+ error-check verify-ci-run
+ set +x
+ convert-to-red
+ set +x
##### CLUSTER SETUP VARIABLE LIST #####
BUILD_ERROR: false
CLUSTER_SETUP_ERROR: false
MAKE_DEPLOY_ERROR: false
##### GATE VARIABLE LIST #####
RESOURCE_ERROR: false
BIND_ERROR: false
PROVISION_ERROR: false
POD_PRESET_ERROR: false
VERIFY_CI_ERROR: false

 Sandbox APB Service Account is currently applying 'cluster-admin' scoped to the target namespace with a RoleBinding.  Limit this to 'admin'

Not seeing this work in my catasb environment, latest master catasb + applied this patch on top of latest master broker.
apb-logs.txt
broker-logs.txt

Dylan sanity checked this for me and it sounds like it's working for him. I suspect it's something to do with my environment, I'm going to try to reset and see if I can get things working this morning.

Let's wait to confirm @eriknelson verifies success with his setup before merging.

@jwmatthews @djzager debugged this with @dymurray, problem came from stale images. We were able to confirm the roles of both the broker and the dynamic SAs as correct, and saw success with mediawiki and postgres.

@eriknelson @jwmatthews hey guys, we are doing some poc development using the ansible service broker. Wondering with this change, would things like adding a role to a service account no longer work?
I am working on an apb that deploys an application that runs using a service account. The application interacts with the the resources in that namespace, such as configmaps. To allow this I was running
oc policy add-role-to-user edit system:serviceaccount:'{{namespace}}':mobile-server -n '{{namespace}}'

and that was working as expected.
However this morning after updating I started to get permission errors. Is this kind of action something you want to specifically stop from happening as part of an apb.
If you would prefer me to open an issue I happy to do that too

@maleck13 please open an issue describing the use case, this is good timing.  We are in the process of designing how we want to control the permissions on the service account running an APB.  Expecting to have a better idea of how we can annotate an APB to express what it requires later next week.
For short term, I'd suggest we make a quick change of allowing the APB SA role to be specified in the broker's ConfigMap.  We will default it to 'edit' for now, but this would allow you to change it to 'admin' for your testing.
@djzager would you implement this change to make the role for the apb serviceaccount be looked up from broker config, then in the template deploying the broker expose a parameter, APB_SVC_ACCT_ROLE or whatever name you deem appropriate?

Discussed this in IRC but adding here for posterity, edit will explicitly disallow viewing and modifying RoleBindings:
https://kubernetes.io/docs/admin/authorization/rbac/#user-facing-roles
Some kind of operator override makes sense to me to elevate permissions to admin.


routing.loader service is private deprecation in Symfony 3.4

When decorating routing.loader in a compiler pass I get the following deprecation error when the container is built:

Just merged the PR that fixes this.


Fix poster on drop upload

This one will fix #1001 and maybe some more (anything related to drop upload -> video posters/video on page preview).
In recent days, the id has been removed (replaced with videoId) from Media items. It is needed for poster generation (also used in UPDATE_MEDIA_ELEMENT).
It would be nice to remove videoId (currently also on image elements) and just stick to id. Will check the impact of that (do we need migration?).
We now generate the video poster right after drop upload.

I believe if we are going to trigger poster upload, this should also be done on the media selector. If you need help with this, then let me know and I can point you in the right direction.

We also need to tweak this logic https://github.com/google/web-stories-wp/blob/f688826f5043f9619d7e8fde7ab31bb21e1a0e95/assets/src/edit-story/components/canvas/useInsertElement.js#L42-L57
As this uploadVideoPoster function no longer take elementId, resource as args anymore. CC @ndev1991

There is still improvement left: drop to media library, right now poster generation is not triggered because media.length doesn't change, so it's generated on insert (or if you switch tabs). I will trigger the generation on drop (maybe unify the code with canvas drop?) - but that can also be a separate PR.

I also think we should change updateVideoElementsById (which I already renamed from updateVideoElementsByVideoId) because it has nothing to do with Video, it’s the same as updateElements just for all pages instead of the current page.
Any suggestions for names?
updateElements really is updateCurrentPageElements
updateVideoElementsById should be updateAllPagesElements?
or maybe just updateElements with allPages flag?

I also think we should change updateVideoElementsById (which I already renamed from updateVideoElementsByVideoId) because it has nothing to do with Video, it’s the same as updateElements just for all pages instead of the current page.
Any suggestions for names?
updateElements really is updateCurrentPageElements
updateVideoElementsById should be updateAllPagesElements?
or maybe just updateElements with allPages flag?

updateVideoElementsById still uses the video id to update the elements, so it is still heavily related to video, as I can see.

Where as this PR been left? Is it still a WIP?

right now poster generation is not triggered because media.length doesn't change, so it's generated on insert (or if you switch tabs).

Should we just change it to media instead of media.length

updateVideoElementsById still uses the video id to update the elements.

Yes

, so it is still heavily related to video, as I can see.

No, I can update images too.
It should be named ~updateElementsByResourceId

It should be named ~updateElementsByResourceId
Works for me :+1:

Should we just change it to media instead of media.length
I remembered why I did this, because updating the media by adding a poster meant that it would trigger another reprocess. Even with the process queue, it did mean that the browser would start to really slow down.

updateElementsByResourceId done.
Media Library drop upload - fixed, for now, we can go back and improve the processing part later (so we don't loop over all items on every page fetch).

I also think we should change updateVideoElementsById (which I already renamed from updateVideoElementsByVideoId) because it is not tied with Video.
updateElementsByResourceId?

Good idea.

@googlebot I consent.

@dvoytenko Is this PR good to merge then?


[Access Request] report 1200 "Create Direct Debit Collection"

Could you please change the access socpe of the following variables to protected?
protected var
    FromDate: Date;
    ToDate: Date;
    OnlyCustomersWithMandate: Boolean;
    OnlyInvoicesWithMandate: Boolean;
    PartnerType: Enum "Partner Type";

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Fix issue with duplicate parsing of Cache-Control header

This PR fixes a bug where the same Cache-Control f3f07a3 header is parsed twice, leading to incorrect performance issues. The parsing code has been extracted from the calculateFreshnessLifetime method and is now enhanced to include the main cache control directive that the isExplicitlyNonCacheable method uses to make its decision. This makes the decision based on the main cache control directive instead of parsing the header twice.
Additionally, this PR adds a new method parseCacheControlHeader to the CacheControlParser class which parses the Cache-Control header and returns a CacheControl instance. This new method improves the parsing of the Cache-Control header and provides more accurate parsing of the different directives.
This PR also includes some code cleanup and refactoring.

Committed as 8ba0b17aebdcc59a43a3785d751e63cddc2c8a58 with some changes to the parsing code.
@arturobernalg The trick was to reverse the parsing flow and make it simple and linear. Fewer lines of code, fewer intermediate garbage as a result.
I committed by code under your name as going back and forth with each and every line of change would have taken too long. Please take a look at my changes.
And why on earth did you choose to use deprecated DateUtils methods in your tests?

8ba0b17

Hi @ok2c
The change look good.
now I'm lost here -->"And why on earth did you choose to use deprecated DateUtils methods in your tests?"

@arturobernalg
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ httpclient5-cache ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/opt/java-1.8]
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 44 source files to /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/target/test-classes
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[920,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[921,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[942,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[943,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[964,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[965,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[986,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[987,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated

@arturobernalg
[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ httpclient5-cache ---
[INFO] Toolchain in maven-compiler-plugin: JDK[/opt/java-1.8]
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 44 source files to /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/target/test-classes
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[920,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[921,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[942,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[943,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[964,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[965,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[986,54] [deprecation] formatDate(Date,String) in DateUtils has been deprecated
[WARNING] /home/oleg/src/apache.org/httpcomponents/httpclient/httpclient5-cache/src/test/java/org/apache/hc/client5/http/impl/cache/TestResponseCachingPolicy.java:[987,57] [deprecation] formatDate(Date,String) in DateUtils has been deprecated

damn.
you right.  I'll tackle that later.
TY


Some apps are crashing with v2

Some apps especially Hitman Sniper & World Cricket Championship 2 were crashing during launch. Working fine in non jailbreak mode.

Yeah, that's not the jailbreak buddy, that's the game's/app's jailbreak detection. You need some jailbreak detection bypass.

I used those apps while running all unc0ver versions including the latest 1.1.4 version. There isn’t an issue earlier but it happened after latest changes of unc0ver v2. I reinstalled those apps again to see if they work but it’s same issue.

This is not a code-level issue and is therefore closed.
Please submit all eta/wen/halp/etc to https://reddit.com/r/jailbreak or https://discord.gg/jb


Unable to use internationalizedArrayText

Describe the bug
It is not possible to add internationalizedArrayText. After registering the field type in sanity.config.ts and try to use it in my field it throws an runtime exception realted to textInputRepresentationStyle
No difference if I will try use defined type 'text' in fieldTypes or try to hack it with creating my own type with text inside, if only it contains text it is not able to create it after opening the internationalized field value.
To Reproduce

internationalizedArray({
languages: [
{id: 'da', title: 'Danish'},
{id: 'en', title: 'English'}
],
defaultLanguages: ['da'],
fieldTypes: ['string', 'text'],
})

defineField({
name: 'content',
type: 'internationalizedArrayText',
title: 'Content',
})

try to insert content.

Expected behavior
The internationalized array of texts render, open and be able to consume text.
Screenshots

Which versions of Sanity are you using?
Run sanity versions in the terminal and copy-paste the result here.
@sanity/cli (global)          3.23.1 (latest: 3.28.0)
@sanity/eslint-config-studio   3.0.1 (up to date)
@sanity/vision                3.23.1 (latest: 3.28.0)
sanity                        3.23.1 (latest: 3.28.0)
What operating system are you using?
windows
Which versions of Node.js / npm are you running?
Node.js v18.12.1.
yarn 1.22.19

Unable to reproduce, are you using the latest version of the Studio and plugin?


[Feature][Connector-V2][Google Sheets] Add Google Sheets option rules

Purpose of this pull request
Add Google Sheets option rules

The schema has been modified.If google sheets is not modified, it will build failure.
Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

@EricJoy2048 @Hisoka-X @TyrantLucifer PTAL


Add links and upgrade authors in the generic RDF

As discussed during the meeting (https://github.com/bioimage-io/bioimage.io/issues/28#issuecomment-869141291), we should add links and upgrade the authors format to synchronise with the model RDF.

RDF.links are already added<PHONE_NUMBER>870fc0293e3568ff9fb4d01af1b62b

This is implemented already, @FynnBe please reopen if not.

in general RDF 0.2.0 (current) authors still can be a string or the new authors scheme with name, affiliation and orcid... I'd keep this open until we disallow the simple author strings in genral RDF 0.3.0 or later


No module named 'ddpm2d.models.geom'

Report the error of 'ModuleNotFoundError: No module named 'ddpm2d.models.geom'', when excute the code of 'module = importlib.import_module(cfg.model.module)' in diffhoi_barely_clean/ddpm2d/utils/train_util.py(27). It seems ddpm2d.models.geom in your local code. Can you help me to check it? Thanks.

I have met the same problem.

I found the solution.

I met the same problem and I have solved it.
Modify the line 40 of "config.yaml" under ${environment.output}/release/ddpm2d/config.yaml.
Change "module: ddpm2d.models.geom" to "module: ddpm2d.models.glide".


Typing with Pinyin-Simplified Input Source while selecting text, the navigation box is positioned incorrectly

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Use macOS
Copy a large text and paste it into the TextField
Select a few lines of text
Switch Input Source to Pinyin - Simplified
Type nihao

See the attached video and screenshots.
Expected results
The Input Source navigation box should be below the typing text.
Actual results
Wrong position.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: Scaffold(
        appBar: AppBar(
          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
          title: const Text('Title'),
        ),
        body: const Center(
          child: TextField(
            maxLines: null,
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Video
https://github.com/flutter/flutter/assets/5484841/5f27fe3d-7453-4fa3-b92f-6ee7db82de9d

Screenshots

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
➜  ~ flutter doctor -v
[✓] Flutter (Channel stable, 3.13.9, on macOS 13.0.1 22A400 darwin-x64, locale en-CN)
    • Flutter version 3.13.9 on channel stable at /Users/fan/.fvm/versions/3.13.9
    • Upstream repository git@github.com:flutter/flutter.git
    • Framework revision d211f42860 (7 days ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/fan/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 113.0.5672.126

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @fanpei91. Thanks for filing this. I can reproduce this on the latest master and stable channels following the steps highlighted above.
stable, master flutter doctor -v

[!] Flutter (Channel master, 3.16.0-20.0.pre.33, on macOS 14.0 23A344 darwin-arm64, locale en-NG)
    • Flutter version 3.16.0-20.0.pre.33 on channel master at /Users/damilolaalimi/fvm/versions/master
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/damilolaalimi/fvm/versions/master. Consider adding /Users/damilolaalimi/fvm/versions/master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 1333e16a4a (8 hours ago), 2023-10-31 23:26:23 -0400
    • Engine revision a0ac6b432c
    • Dart version 3.3.0 (build 3.3.0-83.0.dev)
    • DevTools version 2.28.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • Damilola’s iPhone (mobile) • 00008110-001964480AE1801E • ios            • iOS 17.0.2 21A351
    • macOS (desktop)            • macos                     • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)               • chrome                    • web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

[!] Flutter (Channel stable, 3.13.9, on macOS 14.0 23A344 darwin-arm64, locale
    en-NG)
    • Flutter version 3.13.9 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    ! Warning: `dart` on your path resolves to
      /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/damilolaalimi/sdks/flutter.
      Consider adding /Users/damilolaalimi/sdks/flutter/bin to the front of your
      path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (7 days ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio
      Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • Damilola’s iPhone (mobile) • 00008110-001964480AE1801E • ios            •
      iOS 17.0.2 21A351
    • macOS (desktop)            • macos                     • darwin-arm64   •
      macOS 14.0 23A344 darwin-arm64
    • Chrome (web)               • chrome                    • web-javascript •
      Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

This looks like it's using the final index of the selection area instead of the first index.

Got a fix out for this in #137863; as we suspected we were using the selection base offset rather than the selection start.

This is now fixed on master branch.

@cbracken The bug is still here. See the following video:
https://github.com/flutter/flutter/assets/5484841/748f693e-7448-4a2c-86be-296eeacbd8c5
I expected your solution, and I tried your solution before you. The solution can't fix the bug.

This bug is not fixed. Please reopen this issue.

Hi @fanpei91. You have to switch to the latest master channel 3.17.0-1.0.pre.60 to see this. I can see this has been fixed there.
https://github.com/flutter/flutter/assets/53122008/a7e4630c-e6ab-4dc4-8731-411d520fbec1

@fanpei91 nice catch - you're correct. My patch fixed the horizontal positioning but in the case where editing the text causes the cursor location to change in a vertical direction, the vertical position will be incorrect. A fix for the vertical offset is relatively straightforward but likely to get lower priority since affects a pretty small subset of cases, and moving the entire widget around as the user types is generally already quite poor UX.


SOLR-16230: JWT nested roles support

16230
Description
JWT-Auth: Support for Keycloak-Style nested roles
Solution
Introduce the support for dot-notation in rolesClaim which assumes that the underlying element is a map with nested resolve capability.
Tests
Please see the contained test
Checklist
Please review the following and check all that apply:

[ ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Thanks for looking at this


Starting/Stopping Specific Workers for SolidQueue

Currently, if I need to update the code for a single job, I find myself restarting the entire SolidQueue system, which disrupts all running jobs. Is there any guidance on how to:

Stop a worker for a specific queue.
Start (or restart) it without affecting other workers.

Hey @bmb1603, you can use signals to terminate specific workers as described in the README. However, I wouldn't recommend running mixed code between workers or updating code in production without deploying your app, and in most setups, if you deploy your app, the deployment would take care of restarting all your workers (or at least it should).

Thank you Rosa! So in other words SolidQueue should completely shutdown and restart with every new deployment? Which probably would happen automatically when using the whole pipeline with Kamal/etc.?
We are running SolidQueue as an Ubuntu Service. Sounds like this is the root of the issue then?

So in other words SolidQueue should completely shutdown and restart with every new deployment?

Not just Solid Queue, but any Active Job backend, otherwise you might be running old code 🤔  You might want a short period to finish in-flight jobs, but eventually you'd need to restart it.
With Kamal, depending on how you configure it, it should happen automatically, yes. You might want to check stop-wait-time.
I'm not sure about Ubuntu services or what the issue is 🤔  Is Solid Queue not getting restarted when you deploy or is it something else?

I'm running solid_queue in production with kamal. After a month or two of development I have ended up with pages of workers without knowing what to do with them. My concurrency is off the charts!

Huh, @jmarsh24, how has that happened? Are they all running because they've never been stopped? Running old code?

Is there an easy way to prune these workers?

You could simply delete the records in the DB and they'd terminate when they realise their records are gone. However, if I were you, I'd try to find where the actual processes are running and why they weren't sent the proper signals to terminate when you deploy, and then I'd send them TERM signals. I think I'd ask about that in https://github.com/basecamp/kamal if you can't figure it out.

I will also try to figure out why it's not being cleared, but could you please help me figure out how to get back to useable state? I tried running SolidQueue::Process.delete_all. Its look like the processes get deleted but then in the interface I still see them.


[iOS] Enhance image freshness check before stored into cache

Summary
Currently, before we store the image to cache, we only respect Cache-Control, actually, we also may need to check Expires、Last-Modified, refer to MDN docs, and  okhttp respect the MDN, so in iOS, we can also respect this.
Changelog
[iOS] [Fixed] - Respect MDN cache strategy before cache the image.
Test Plan
After PR, if image's response do not contains Cache-Control, it would also checks Expires、Last-Modified refers to  MDN docs.

Just landed this one again in https://github.com/facebook/react-native/commit/fb8ba3fe959fd2a0c4ef0025fd84f6deffd9d03b


Publishing a project with UI class library publishes cshtml files from class library

The issue crops up regardless of CopyRazorGenerateFilesToPublishDirectory  setting. When publishing, Razor SDK removes cshtml files from the current project from being published, but it does not prevent views from referenced UI class libraries from being published.
Relevant code: https://github.com/aspnet/Razor/blob/dev/src/Microsoft.NET.Sdk.Razor/build/netstandard2.0/Sdk.Razor.CurrentVersion.targets#L504-L510

cc @rynowak \ @DamianEdwards, is this something we want to consider for 2.1.0-rtm?

Yes, should be considered

Fixed in a94323499bd0bdb048495035b4bab349ed816123


Dimension material uses Chisel variant

I tried to create a flat Glowstone world but it ended up generating with a Chisel variant instead. I created a second world via a digit dimlet and the same variant was used.
This is the same issue as https://github.com/McJty/RFTools/issues/1040 but I'm making an issue here for better tracking.
RFTools Dimensions v1.1x-4.55
RFTools v1.1x-5.88
(Direwolf v1.8.1 Pack)

I can reproduce this. Will try to fix it

Fixed next release


Is this plugin dead?

Latest commit 4e1078b  on 4 Jan 2015
and issues are not being responded to..

Sadly but it seems to be dead. The lib was great.

An issue of mine was processed a few days ago so I am still believing in this plugin

Any alternative?


md-progress-circle customize svg

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Current progress circle doesn't allow you to customize the SVG.
What is the expected behavior?
Add the ability to inject your own SVG for progress circle.
What is the motivation / use case for changing the behavior?
Flexibility to have a different SVG and capability to override animations to customize to fit your own theme.

@bsteffl If you want to use a different SVG with a different animation, then I think you just want your own custom component; there's very little the progress circle does beside those two things.


Intraday and swing data slicing for better backtests

There needs to be a better capability provided by the software to enable users to be able to slice the intraday or long term data by start-end times and start-end dates to check the performance of the given scan categories within the given window.

In progress: Added support to take key input for sliding windows: a5b76140d765b0192beb8dc019bee50f26108f69


gdb: bump to 10.1

Existing package

[x] I am the maintainer of this package.

I forgot to update the version file on previous PR.

PR needs resubmitting due to conflicts.


Add aria-label for accessibility

Since there is no visible text displayed along with the Button icon, adding aria-label will be useful for voiceover users.

thank you @itssiva


Update .openpublishing.redirection.json

The redirect_url needs to point to a valid URL, not to a *.md file.

Thanks @NKarolak for catching this. For validation reasons, we'll fix this on the private repo first, so closing this one. Thanks!


added data_definition_type_id and fix auto_now_add

added data_definition_type_id in data.json/data_definitions
removed auto_now_add in models.py/ReportSchedule

Sorry not meant to pull into masters but our own branch


Add 'make lint' to pull_request_template file,

it will print out coding style mistake and use can fix it.
Signed-off-by: mgold1234<EMAIL_ADDRESS>Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run go fmt ./... to check that my code is properly formatted
[ ] I run go vet ./... to check that my code is free of common Go style mistakes

Test results are available in Ibutsu. The test run IDs are:
aa2c6e7a-8aba-42c0-9455-0122bb9baf63
dfddec3f-f3a0-436f-8c2f-54ab6e7fbbc1


docker build . fails

Hi all,
I'm trying to build a docker image for an hello world dart server and I'm having connection error during the build.
The build log:
> $ docker build .
Sending build context to Docker daemon  43.01kB
Step 1/4 : FROM google/dart-runtime
# Executing 4 build triggers
 ---> Using cache
 ---> Running in 2883a4ca31d6
Resolving dependencies...
Downloading appengine 0.6.1...
Downloading gcloud 0.6.0+4...
Downloading googleapis_auth 0.2.7...
Downloading http 0.12.0+2...
Downloading logging 0.11.3+2...
Downloading path 1.6.2...
Downloading http2 1.0.0...
Downloading http_server 0.9.8+1...
Downloading fixnum 0.10.9...
Downloading protobuf 0.9.1...
Downloading stack_trace 1.9.3...
Downloading _discoveryapis_commons 0.1.8+1...
Downloading googleapis 0.53.0...
Downloading crypto 2.0.6...
Downloading async 2.2.0...
Downloading pedantic 1.7.0...
Downloading http_parser 3.1.3...
Downloading mime 0.9.6+3...
Downloading typed_data 1.1.6...
Downloading collection 1.14.11...
Downloading convert 2.1.1...
Downloading string_scanner 1.0.4...
Downloading source_span 1.5.5...
Downloading charcode 1.1.2...
Downloading meta 1.1.7...
Downloading term_glyph 1.1.0...
It looks like pub.dartlang.org is having some trouble.
Pub will wait for a while before trying to connect again.
HTTP error 503: Service Unavailable
package:pub/src/http.dart 218:5                 _ThrowingClient.send
===== asynchronous gap ===========================
package:http_throttle/http_throttle.dart 33:31  ThrottleClient.send
===== asynchronous gap ===========================
package:pub/src/source/hosted.dart 309:37       BoundHostedSource._download
===== asynchronous gap ===========================
package:pub/src/source/hosted.dart 204:13       BoundHostedSource.downloadToSystemCache
===== asynchronous gap ===========================
package:pub/src/entrypoint.dart 374:48          Entrypoint._get.<fn>
===== asynchronous gap ===========================
package:pub/src/http.dart 271:51                withDependencyType
package:pub/src/entrypoint.dart 370:12          Entrypoint._get
dart:async                                      Future.wait
package:pub/src/entrypoint.dart 231:18          Entrypoint.acquireDependencies
dart:async                                      _completeOnAsyncReturn
package:pub/src/solver/version_solver.dart      VersionSolver.solve
dart:async                                      _completeOnAsyncReturn
package:pub/src/solver/version_solver.dart      VersionSolver._result
This is an unexpected error. Please run

    pub --trace get

and include the logs in an issue on https://github.com/dart-lang/pub/issues/new
The command '/bin/sh -c pub get' returned a non-zero code: 69

The Docker fil contains:
FROM google/dart-runtime

ADD keyfile.json /project/key.json
ENV GCLOUD_KEY /project/key.json
ENV GCLOUD_PROJECT dartlang-pub

The Docker image used is the latest one:
google/dart-runtime                        latest              2275a30e88c2        12 days ago         600MB

I suspect an issue with the DNS record update that has been migrated from pub.dartlang.org to pub.dev...
Any ideas?
thanks

The pub clients are intentionally still supposed to be talking to pub.dartlang.org.
Is this still a problem, there was a few 500s yesterday, we haven't tracked them all down yet.
Given that it replies:

HTTP error 503: Service Unavailable

I'm not convinced it's DNS related at all.
(thanks for reporting)

Indeed solved. thanks for the help.

For the record, it's likely that this was related to:
https://status.cloud.google.com/incident/cloud-networking/19009
or
https://status.cloud.google.com/incident/compute/19003

Please, do let us know if you experience 503 errors often, the pub client is supposed to retry requests and we do monitor our service to keep the number of errors low.


Update nr1-account-maturity

Acceptance Criteria

[x] Upgrade to node 16
[x] Resolve any app deprecations planned for march 1st

[x] "errors" is deprecated, use "error?.graphQLErrors" instead
[x] "errors" is deprecated, use "error" instead
[x] "plain" type for header controls has been deprecated. Use any of "primary", "secondary", "tertiary" instead

[x] update .nvrmc file to Node 16
[x] Confirm if we need to set the NODE_VERSION environment variable
[x] Ensure all documentation is updated.

nr1-account-maturity-products repo PR https://github.com/newrelic-experimental/nr1-account-maturity-products/pull/32

I confirmed with @jospdeleon and she said by 3/18 she'd be able to review the PR to approve the merge.

I confirmed with @jospdeleon and she said by 4/01 she'd be able to review the PR to approve the merge.

Looks like this was taken care of.


[WIP]mplementation of add/sub operations -RSTensor

Description
Implementation of add/sub operations to RSTensor. fixes #156 and #157
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?

To be added

Checklist

[x] I have followed the Contribution Guidelines and Code of Conduct
[x] I have commented my code following the OpenMined Styleguide
[x] I have labeled this PR with the relevant Type labels
[ ] My changes are covered by tests

RSTensor does not have a nice structure like ShareTensor where we have a single apply_function to all the operations., Instead of customizing it for a single operation.I have modified it like MPCTensor having appy_public_op and apply_private_op functions since each is customized for RSTensor.


env shim: make sure we clean up all the memory we allocate

Machine memory is not leak-checked, so if we forgot to deallocate part of the env shim memory, we wouldn't even notice. Thus add a dedicated memory kind that is leak-checked.

@bors r+

:pushpin: Commit 204c13b8c724b208b8e26148ba21087b543e960b has been approved by RalfJung

:hourglass: Testing commit 204c13b8c724b208b8e26148ba21087b543e960b with merge b67dbca5d0d7c3b9f1d78fd26af41d0182eb7b5c...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing b67dbca5d0d7c3b9f1d78fd26af41d0182eb7b5c to master...


Importing Anthropic SDK crashes Vercel Edge Runtime

When importing<EMAIL_ADDRESS>in Vercel Edge Runtime, the following exception occurs:
TypeError: Cannot read properties of undefined (reading 'custom')
    at (node_modules/object-inspect/index.js:69:0)
    at ([native code])
    at (node_modules/side-channel/index.js:5:0)
    at ([native code])
    at (node_modules/qs/lib/stringify.js:3:0)
    at ([native code])
    at (node_modules/qs/lib/index.js:3:0)
    at ([native code])
    at (node_modules/@anthropic-ai/sdk/core.js:91:0)
    at ([native code])

It does seem like the issue stems from the usage of qs, which is unsupported by Vercel Edge Runtime.
Reproducible repository: https://github.com/dqbd/anthropic-vercel-edge
cc: @jacoblee93

@dqbd how are you building/deploying to Vercel Edge? It doesn't seem like there's a build command in your reproduction repo.
I can successfully deploy to Vercel Edge with an API route that looks like this:
import { NextRequest, NextResponse } from 'next/server';
import { Anthropic } from '@anthropic-ai/sdk';

const anthropic = new Anthropic();

export const config = {
  runtime: 'edge',
  unstable_allowDynamic: [
    // Note: this is due to a redundant error in Next.js that has
    // been fixed in the latest version
    '/node_modules/function-bind/**',
  ],
};

export default async (request: NextRequest) => {
  console.log(anthropic);
  return NextResponse.json({ foo: true });
};

Extra Details
package.json:
{
  "name": "vercel-edge-test",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "lint": "next lint",
    "vercel": "vercel"
  },
  "dependencies": {
    "@anthropic-ai/sdk": "^0.5.4",
    "ai": "2.1.9",
    "next": "13.4.6",
    "react": "18.2.0",
    "react-dom": "18.2.0"
  },
  "devDependencies": {
    "@types/node": "20.3.3",
    "@types/react": "18.2.13",
    "@types/react-dom": "18.2.6",
    "edge-runtime": "^2.4.3",
    "typescript": "5.1.3",
    "vercel": "^30.2.3"
  }
}

tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noEmit": true,
    "esModuleInterop": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "jsx": "preserve",
    "incremental": true,
    "paths": {
      "~/*": ["./src/*"]
    }
  },
  "include": ["next-env.d.ts", "**/*.ts", "**/*.tsx"],
  "exclude": ["node_modules"]
}

@RobertCraigie We're sending the source code of the Vercel Edge Function directly. We're also not using Next.JS or Webpack at the moment.

Thanks @dqbd – we're talking to Vercel about ways to resolve this.

This should be resolved as of 0.3.7, which is published on GitHub and should be live on npm shortly!


fix(grouper): make sure that pile tip levels are sorted

That's a nice and effective fix ;) but let's also add a test


add load shell and workflow

add shell to load the data into nebula graph
add workflow to test via sf0.1

refer https://github.com/HarrisChu/ldbc_snb_interactive_implementations/actions/runs/4123040857/jobs/7120573634


I'm unable inspect teams mobile client

Much more like last time (https://github.com/MicrosoftDocs/msteams-docs/issues/4795#issue-1072079632), I'm unable to inspect teams mobile app.
I've got dev preview enabled, and I can successfully view all the tabs from chrome, but I don't see any (com.microsoft.skype.teams.dev) from the teams app (my tab app is open while I'm checking)
Teams version I've got is 1416/<IP_ADDRESS>2331702/0623
Device SM-G781B

@Niegrozny - We are looking into this I will get back to you soon.

I've done that already (I've stated this in the OP). It was working before but now (maybe teams update) it doesn't

@Niegrozny -We are checking this. Are you getting same as given below?

@Niegrozny -Could you please confirm if your issue has resolved or still looking for any help?

@Niegrozny - Could you please confirm whether you are getting same result as share above ?

Yes, only difference is that I can see also my tabs from chrome for mobile

Ok. We are checking it internally and let you know if we get any updates.

Hello @Niegrozny - Are you facing the same issue in Teams Desktop Client?
Also, are you trying to display the contents from this domain "com.microsoft.skype.teams.dev" in your tab ?
Because Teams Tab uses IFrame, while showing the content, so it blocks the sites or domain which are not Iframable or not configured in the manifest file.
Please check & let me know if you need any further assistance.

@Niegrozny - Are you able to see the tab in mobile client & not able to see it in inspect window ?

@Niegrozny -Could you please share the screenshots if possible?

@Niegrozny - We are able to repro that issue , We have raised bug for the same and concerned team is looking into it. We will inform you once we get any update.

@Niegrozny -Issue is Resolved with  Latest Canary 2nd September Build (Version 1416/<IP_ADDRESS>2381101<PHONE_NUMBER>)
Could you please check it once and confirm?

I confirm. Working fine :)

@Niegrozny - Could you please share your valuable feedback via Microsoft Teams Developer Feedback link.


migrate meson lexer

Thank you! I'll take a proper look hopefully this weekend.

Updated via https://github.com/orbitalquark/scintillua/commit/48a6fc9511ec67993e43ac7f5a33efc616b7ea32


It would be better to update 'container' to 'Container' on the 'Open Direct Link' dialog

Storage Explorer Version: 1.30.0-dev
Build Number: 20230519.1
Branch: main
Platform/OS: Windows 10/MacOS Ventura 13.3.1 (Apple M1 Pro)
Architecture: x64/arm64
How Found: Exploratory testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Blob Containers.
Right click one blob container -> Click 'Copy Direct Link to Blob Container'.
Paste the direct link to browser to open storage explorer.
There is an 'Open Direct Link' dialog -> Observe the dialog.
Check whether the first option is 'Navigate to Container'.

Expected Experience
The first option is 'Navigate to Container'.
Actual Experience
The first option is 'Navigate to container'.

Verified this issue on the build main 20230521.1. Fixed. So, we are going to close it.


Fix hyperlink in the NOTICE file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks, typos everywhere!  Much appreciated.


Add video from camera roll to segments array

This adds an "Add" button in player in order to import video from camera roll. You can merge videos from camera roll with video from SCRecorder app.

Hi @AnthoPakPak , do u know of a way to adjust the video orientation from the import from camera roll? I seems to have some issue importing as I'm using protrait orientation.

It's missing some code to adjust the videoComposition on the generated AVPlayerItem to handle mixed orientation metadata in segments. Great demo anyway!

could u help point me to some reference to do that? Thanks!


Windows aborts sockets on drop

The event loop will drop a socket once the Handler declares the response is done (and keep alive is disabled). When the Server is running on Windows, it seems that this behavior causes a client to receive a WSACONNABORTED error. The docs of msdn say that this means the server is aborting the socket before the TCP shutdown is completed.
This might be related to how mio imitates readiness on Windows: the is_writable event doesn't mean the socket can actually send more data right away, but that it has finished sending it's last queued buffer. So calling socket.write(data) for the last time means the data is queued, and it could be that dropping the socket then makes the IOCP thread decide to abort completely.

I've been investigating this issue but still not sure what causes it. First I patched hyper to drop the socket after everything have been written and the final write have been confirmed with write_done in mio/tcp. Introduced an additional Writing::Flushing state in which connection waited for the socket to be writable again before closing it. That did not help much.
This commit resolved it but I have no idea why and I'm quite sure that's not the best way to fix it:
https://github.com/ethcore/mio/commit/3842d3b250ffd7bd9b16f9586b875ddcbac2b0dd
Setting SO_LINGER socket option might also help, but I haven't tried this.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms738547(v=vs.85).aspx
https://msdn.microsoft.com/en-us/library/windows/desktop/ms740476(v=vs.85).aspx

This appears to be fixed in newer mio, will close this bug once hyper has incorporated it.

This is no longer happening in the tokio branch.


comparisonString overriding does not work for Webfonts

The Webfont setting from the Manifest.json overrides the setting from the themes Font.js file. And you can only declare the comparisonString in the latter one.
The screenshot shows the problem for the FABrands webfont. The Font.js part is in the prototype and gets overriden by the instance setting (which comes from the manifest)

I am not really sure if this is a compiler problem or should be fixes in the qooxdoo sources.

One addition: when I manually remove the qx.$$fontBootstrap stuff from the generated boot.js evenrything works fine.

Webfonts defined in the Manifest are defined automatically. Adding conflicting names via Fonts.js is not supported and should not be done.

Ok I misread the documentation here, but then there is still one point remaining. If I add the comparisonString setting to the Manifest.json font definition I get:
Error: No such property: comparisonString

In the Manifest the property is called testCharacters using that adds the comparisonStringto the generated $$fontBootstrap but it gets lost somewhere. The Font-Validator still uses the default comparison string.