Catalog which analyzers must be in the 6.0 SDK product to allow excluding others from the build

To get this started, I took Microsoft-built dotnet-sdk-6.0.100-rc.2.21505.57-linux-x64.tar.gz and used find:
wget https://download.visualstudio.microsoft.com/download/pr/20283373-1d83-4879-8278-0afb7fd4035e/56f204f174743b29a656499ad0fc93c3/dotnet-sdk-6.0.100-rc.2.21505.57-linux-x64.tar.gz
tar -xf dotnet-*
find . -ipath '*/analyzers/*.dll' -not -iname '*.resources.dll' | sort

./packs/Microsoft.AspNetCore.App.Ref/6.0.0-rc.2.21480.10/analyzers/dotnet/cs/Microsoft.AspNetCore.App.Analyzers.dll
./packs/Microsoft.AspNetCore.App.Ref/6.0.0-rc.2.21480.10/analyzers/dotnet/cs/Microsoft.AspNetCore.App.CodeFixes.dll
./packs/Microsoft.AspNetCore.App.Ref/6.0.0-rc.2.21480.10/analyzers/dotnet/roslyn4.0/cs/Microsoft.Extensions.Logging.Generators.dll
./packs/Microsoft.NETCore.App.Ref/6.0.0-rc.2.21480.5/analyzers/dotnet/cs/System.Text.Json.SourceGeneration.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk/analyzers/ILLink.CodeFixProvider.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk/analyzers/ILLink.RoslynAnalyzer.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk/analyzers/Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk/analyzers/Microsoft.CodeAnalysis.NetAnalyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk/analyzers/Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk.Web/analyzers/cs/Microsoft.AspNetCore.Analyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk.Web/analyzers/cs/Microsoft.AspNetCore.Components.Analyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk.Web/analyzers/cs/Microsoft.AspNetCore.Mvc.Analyzers.dll
./sdk/6.0.100-rc.2.21505.57/Sdks/Microsoft.NET.Sdk.Web/analyzers/cs/Microsoft.AspNetCore.Mvc.Api.Analyzers.dll

I'm not 100% sure that all analyzers will follow this path pattern, so it might still be worth doing a quick find whenever disabling one.

This appears to be completed above.  Closing.


WIP: Auto Form

The feature were fully implemented. Left documentation. @sadeghbarati  do help look through the code and test out some cases ya 😁

zod default() is working for most of the fields but Select component is not selecting the default value in zod schema

I see Vue warn in my Devtools

We can prevent this error like registry/default/ui/form/useFormField.ts

This feature is so nice 🔥optional custom wrapper/style/ui for AutoFormFields

This feature is so nice 🔥optional custom wrapper/style/ui for AutoFormFields


Fork point is not correctly inferred after fast forward merge

Step to reproduce:

create sample repo by script form blogpost
rebase build-chain onto parent
do Fast Forward Parent Branch To Match Current Branch action on build-chain
Then listed commits from allow-ownership-link will disappear:

git fetch . <refspec> reflog entries should NOT be taken into account when finding the fork point... that should fix the issue.

The solution would most likely entail skipping the reflogs of merged children of X when finding fork point of X

Or maybe: skipping the reflogs of all merged branches of X when finding fork point of X - so that fork point algorithm doesn't need to know what the children of X are (so far it needs to know what parent of X is, alas... originally it knew nothing about the branch layout completely)

A sample repository state where this can be seen: https://drive.google.com/file/d/1Ed2dVcnk3bKORFn1Iv7DycHYMYOnr-k_/view?usp=sharing

There's a yellow edge b/w develop and master solely b/c backport/v0.8.0 has been merged to the former... this makes no sense, really :/

Whoops... that's not so easy. Specifically, it's not easy to determine which branches are merged to the X (and not just X's ancestors that have never been merged to X) without heavily relying on branch layout... I don't want to further complicate the fork point algorithm unless absolutely necessary.
As a partial light-weight solution, I'd suggest https://github.com/VirtusLab/git-machete-intellij-plugin/issues/633 instead.


why "Loading checkpoint shards:"  take me so long time

whait is  "Loading checkpoint shards:", why "Loading checkpoint shards:"  take me so long time

How much memory do you have? VRAM and RAM? And if you monitor them at that stage, does it get full?

VRAM 3060Ti 12G
RAM 32G

I added loading from safetensors now, but it needs re-download, I don't know if it would help with this at all though.

yes, very quickly now, the 8G only 1 second now。 thx very much


Reduce configuration cache report overhead

By:

generating the configuration cache report asynchronously
keeping a running summary of the problems instead of maintaining all problems
in memory until the end of the build

@bot-gradle test and merge

OK, I've already triggered a build for you.

@bot-gradle test ACC

OK, I've already triggered AllConfigCacheTestsReadyForMerge build for you.

@bot-gradle test ACC

OK, I've already triggered AllConfigCacheTestsReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

OK, I've already triggered a build for you.


Mobile Tab Behavior (Menu + All)

tabs.html has a spacebars condition to set the tab to to aria-hidden="false" on lines 19 and 48.
We need isFirst to return aria-hidden="true" if the window width < 768.
Thoughts on the best way to accomplish this?

Spacebars conditions leave a lot to be desired.  I'd recommend using a helper for this:
// tabs.html
<article data-id="{{id}}" aria-hidden="{{#if hidden}}true{{else}}false{{/if}}" data-editable="{{editable}}" class="{{#if isAdmin}}admin{{/if}}">

// tabs.js
Template.tabs.helpers({
    /**
     * @summary Determines whether or not to show the tab by default
     * @function
     * @returns {string}
     */
    hidden: () => !Template.currentData().isFirst && window.innerWidth < 768,
});

Also need to check links behavior from outside the menu.

And deep linking.

Forms are dark blue for some reason.

Although isFirst doesn't seem to be returning true/false correctly.

@micchickenburger : is it possible to have the data-id on tabs to match the URL string?
Perhaps  not. But I've been having trouble with collapsing tabs on mobile and have placed a jquery solution on the coming branch which hides the tabs after being rendered if their data-id does not match the deep-link URL. (I know, not very elegant... Perhaps you can help me with this one) Otherwise lets talk some more. However deep-linking aside: it is essential for all tabs to be collapsed in order for the mobile menu to work properly.
Stay tuned for the pull request...

Need to make sure this doesn't affect the masthead which should have it's first tab open.

Mobile tabs have been configured to work properly.


NDK warning on build

When initiating a build on the command line, I am seeing a very old NDK warning. I have ndk-bundle installed. There is no local.properties file at project root. Log:
Android-CleanArchitecture git:(master) ./gradlew clean build
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing
Configuration on demand is an incubating feature.

> Configure project :data
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to /Users/shipit/Library/Android/sdk/ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

It's same with me on Android Studio Bumblebee.
I fixed bottom files. Finally, I can build it.

build.gradle

    classpath 'com.android.tools.build:gradle:3.0.1'
to
    classpath 'com.android.tools.build:gradle:4.1.2'

data/build.gradle

apply plugin: 'me.tatarka.retrolambda'
to
//apply plugin: 'me.tatarka.retrolambda'

gradle/wrapper/gradle-wrapper.properties

distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
to
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip

buildsystem/dependencies.gradle

  androidBuildToolsVersion = "27.0.1"
to
  androidBuildToolsVersion = "29.0.2"

presentation/build.gradle

    sourceCompatibility JavaVersion.VERSION_1_7
    targetCompatibility JavaVersion.VERSION_1_7
to
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8


Fixing Issue #4437 - Failing tests for unhandledRejection

In regards to issue #4437 I've made two fixes to the angular tests: (i) awaiting all validateTypeScript calls as to not hide failures and (ii) fixing the test that was (silently) failing by updating its gql mutation/subscription to fit the actual schema.
Other than that, this PR also includes a setup file for jest which makes sure the execution fails if there's an unhandledRejection so that they may not stay hidden.

Great catch. Thank you so much @asafh !


Needed: Complete set of Basic Widgets

Fidgetty has enough core widget APIs to start creating new widgets. The one's I've create are largely for testing api's and making demos.
There's a good list of basic widgets from RayGUI.

[x] Button
[x] LabelButton
[ ] Toggle
[ ] ToggleGroup
[x] CheckBox
[ ] ComboBox
[x] DropdownBox
[x] TextBox
[x] TextBoxMulti
[ ] ValueBox
[ ] Spinner
[x] Slider
[ ] SliderBar
[x] ProgressBar
[ ] StatusBar
[ ] DummyRec
[ ] Grid

[ ] Trees / TreeWidget
[ ] Code editor

@matkuki any thoughts on those? Also, have you played with the new "theming" setup?

@elcritch I have to be honest here, most of my experience with GUI design is with libraries Qt and IUP, so please keep this caveat in mind when reading my comments. Also, when I'm talking about a GUI library, I always mean a non-HTML/CSS/JavaScript library!

Trees / TreeWidget: Conceptually should be easy to implement, as it's only images and text in rows layed out from an internal structure, but I will defer to you how hard it actually should be to implement. Qt goes overboard here for example, using a Model with parent/child cross references, which is nice once you get the hang of it, but a pain with regards to complexity and customizibility. But it is a widget that I use a lot, that's why I added it.
Code editor: This is my main problem with any non-C++ library and especially immediate-mode libraries, no mature code/text editor. Most C++ based libraries just wrap Scintilla editor component and I have battle tested it thoroughly, so I can vouch for it, but still it's C++, wrapping it is non-trivial. There are a couple of possibilities here:

Make a new editor component from scratch, starting from Araq's NimEdit, taking out the editor, upgrading it and integrating it into Fidgetty. This would be the preferred option, as the code is SDL/OpenGL based (I think), and Araq's code is known to be concise. But you will be a better judge of the integration difficulty.
Instead of NimEdit, moe could also be used as a base. It also uses a GapBuffer that seems stable, but I haven't looking into it deeply.
Make a wrapper for Scintilla. From my experience, C++ wrappers are painful, but could be an option.

Color picker: Shouldn't be that hard to implement given the abilities of Fidgetty (and Fidget), but is not a high-priority widget for me.
Popup message dialog (modal): No idea how this can be made in an immediate-mode library. But the concept is very useful to me.

Also, have you played with the new "theming" setup?

I love it! In my opinion the more fine control you give to a user the better 👍
Currently I have not found anything lacking in regards to theming. If I do, I'll post about it.

Great thoughts!
You seem to share a fair bit of my own background. I've only done a moderate amount of CSS and Qt as well.

trees won't be too bad I reckon. The question would be more if its better to use say templates or some data structure dsl's
color picker should be easy
popup's aren't too bad. Dropdowns are basically popups currently!
code editor - that ones hard, as you say theres a few options. I think that treeform's updated font/styles in pixie 5 could enable a basic text editor. But it may be better to use an existing one.


Use Constraints info does not display for a sample record

Describe the bug
For C2098742955-LARC, use constraints errors should display in the summary output. pyQuARC does not display these errors.
To Reproduce
Steps to reproduce the behavior:

Run pyQuARC for C2098742955-LARC (dif10)
See lack of use constraints error

Expected behavior
Expected to see a use constraints error

Checked 10/3, still seems to be an issue

Noting to add: it looks like use constraints is in the "Collection_Info" tab, but should be provided under the "Use_Constraints" tab now. Maybe some rec to provide the info in the new space?


Add --set-value flag that requires less escaping

Output of helm version:
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

Hello!
I like Helm, but this issue does not give me rest.
According to: https://docs.helm.sh/using_helm/#the-format-and-limitations-of-set

Sometimes you need to use special characters in your --set lines. You can use a backslash to escape the characters; --set name="value1,value2" will become:

name: "value1,value2"

I can't guarantee that some value contains or not contains the comma.
So I forced to escape each value at my CI.
Its absolutely uncomfortable.
As I understand, you don't want to break compatibility for 2.x.
You can consider to introduce another CLI parameter.

-s
-S
--set-value
... or something like this.

Related issues I found:

https://github.com/helm/helm/issues/1751
https://github.com/helm/helm/issues/1556
https://github.com/helm/helm/issues/4173
https://github.com/helm/helm/issues/2952

I'm re-marking this as a feature request, and re-titling it appropriately.

Or alternatively, make --set not treat , in a special way when --disable-the-damn-coma is passed. One way or another, how things are now is extremely inconvenient. Hope this can get straightened up. :)
CC @bacongobbler

closing as a duplicate of #4030 so we can keep the conversation all in one place. Thanks!


issue

if (ump_select_dev(handle, params.dev) < 0)
{
fprintf(stderr, "Select dev failed - %s\n", ump_last_errorstr(handle2));
ump_close(handle);
exit(2);
}
Hello, what is the above code used for? How to solve the problem of select dev failed

This error means that the requested device cannot be seen by the computer. Maybe the device id is incorrect? Maybe the device is powered off? Check to make sure that everything is powered on and connected, or maybe give things a reboot.


cargo install fails on openSUSE Tumbleweed

error: failed to run custom build command for `x11 v2.18.1`
process didn't exit successfully: `/tmp/cargo-installzhYMGX/release/build/x11-89e8a677ff79890c/build-script-build` (exit code: 101)
--- stdout
cargo:rustc-link-search=native=/usr/lib64
cargo:rustc-link-lib=X11

--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failure { command: "\"pkg-config\" \"--libs\" \"--cflags\" \"xscrnsaver >= 1.2\"", output: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "Package xscrnsaver was not found in the pkg-config search path.\nPerhaps you should add the directory containing `xscrnsaver.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'xscrnsaver\' found\n" } }', src/libcore/result.rs:997:5
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

warning: build failed, waiting for other jobs to finish...
error: failed to compile `xidlehook v0.7.0`, intermediate artifacts can be found at `/tmp/cargo-installzhYMGX`

I tried to look for a package named xscrnsaver using the opensuse package manager but I didnt find any matches:
zypper se xscrnsaver
Loading repository data...
Reading installed packages...
No matching items found.

There is a package called xscreensaver, but its already installed:
zypper se xscreensaver
Loading repository data...
Reading installed packages...

S | Name                    | Summary                                           | Type
--+-------------------------+---------------------------------------------------+--------
i | xscreensaver            | A screen saver and locker for the X Window System | package
i | xscreensaver-data       | Selection of screensavers from xscreensaver       | package
  | xscreensaver-data-extra | Selection of screensavers from xscreensaver       | package
i | xscreensaver-lang       | Translations for package xscreensaver             | package

Is this just the case that opensuse has a different name for the package xidlehook is trying to look for?

It should be called libXScrnSaver according to https://software.opensuse.org/. Let me know if this works!

That package already seems to be installed
sudo zypper in libXScrnSaver
Loading repository data...
Reading installed packages...
'libXScrnSaver' not found in package names. Trying capabilities.
'libXss1' providing 'libXScrnSaver' is already installed.
Resolving package dependencies...

Nothing to do.

However trying to look for any file with that name fails:
find / -iname "*xscrnsaver*" 2>/dev/null
<no results>

Is there a particular file that is being looked for?
Btw if you wish to try reproduce this yourself, you could probably use docker
docker run -ti opensuse/tumbleweed

What about libXss1? I found it in the, perhaps related, issue https://github.com/atom/atom/issues/13354.

@jD91mZM2 yep that was it!
sudo zypper in libXss-devel
Maybe we can add this to the wiki or README?

Hmm, I don't know. I just saw it says

Xidlehook with the default settings requires libXScrnSaver (or libxss) and libpulseaudio. On debian/ubuntu, don't forget to install the -dev versions, also.

I don't want to get too specific in the README, as there are so many distros it'd take a lot of space to list them all. Maybe I could make a wiki entry?


To PHPDocumentor or not to PHPDocumentor

:wave: This is mostly a question. Feel free to close as a wontfix if you want. I just wanted to bring it up as it differs from a textmate rule we have had in Atom for the past 5 years 🙂
The textmate grammar has since forever highlighted PHPDocumentor comments as invalid if they don't follow the syntax rules. This is from the initial commit 5 years ago 😱
It is still technically valid PHP syntax to not follow PHPDocumentor so tree-sitter-php is technically not wrong but there is a difference from the old textmate highlighting in Atom. Do you consider these things in tree-sitter or not? 🙂
Textmate

Scopes at Cursor

text.html.php
meta.embedded.block.php
source.php
comment.block.documentation.phpdoc.php
invalid.illegal.missing-asterisk.phpdoc.php

tree-sitter

Scopes at Cursor

text.html.php
source.php
comment.block

If we want to get something up and running real quick, I suppose it is better to skip this initially.
Also, if possible, perhaps it could be implemented this time so that it wouldn't be coupled to the main PHP grammar. I haven't had a chance to tinker around with tree-sitter much, so I cannot really tell if this is feasible or not.

You can compose tree-sitter grammars (https://github.com/atom/atom/pull/17551) but I'm not sure myself how (or if) that would work for comment nodes.

Make a parser for doc comments and use injections if we want to add this to Atom. See https://github.com/tree-sitter/tree-sitter-jsdoc

Also of note is how it was integrated into language-javascript: https://github.com/atom/language-javascript/pull/629


removed a lot of unused (?) ToJSON and FromJSON instances

Following the discussion in #307 here's a PR that removes a large number of ToJSON and FromJSON instances. Maybe you could finish the job in ServerClient.hs, @stschiff.
If we don't use the instances then I'm all for removing them :slightly_smiling_face:!

From my point this is good to merge into typeMania, where I'll have a final look.


wall stone time

When I build source x (I didn't change any code)
After casting stone wall magic → archive → close server → open server → 13:56:00 WARNING:FixWeirdness on Item (UID=040001fd6): timer unreasonably long (> 90 days) on a top level object.
The stone wall timer increases automatically.
Does anyone have the same problem as me?
The client is <IP_ADDRESS>

@Jhobean do you still have same issue? Because when I was working with evening, I sent him my build and he tested it is working fine for him, but when we download latest sphere source and build it on his computer, this issue happening.
I thought it was because of visual studio version but he said after he changed the version to 2019 this still occur for him, so maybe it's a toolchain issue? Or maybe something else, I am not sure about it yet

Seem to be a good theory because that happn to me when i build in local...

Just for information, I am using Visual Studio 16 2019 as generator and do not specify any toolset, can you change your build with this and try it again?

The problem is caused by GIT


how to calibrate ADXL354

Is there a method in this library to calibrate the ADXL3545?
The library reads values but the numbers never settle to zero even if the device is taped to the desk

Please help
------------------ 原始邮件 ------------------
发件人:                                                                                "Seeed-Studio/Accelerometer_ADXL345"                                                                                @.>;
发送时间: 2021年4月3日(星期六) 晚上10:37
@.>;
@.***>;
主题: [Seeed-Studio/Accelerometer_ADXL345] how to calibrate ADXL354 (#11)
Is there a method in this library to calibrate the ADXL3545?
The library reads values but the numbers never settle to zero even if the device is taped to the desk
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi there，
I don't have the library to calibrate the ADXL3545, But I may know the reason for the abnormal data.
After continuous breakpoint tracking, I found that when the vibration value is large, there will be several singular values in the collected data. For example, when the sensor is stationary, the normal data is generally around 250, but occasionally one or two zeros or a value of 500 will pop up. These two singular values are in an array, and after FFT transformation, a small vibration value will be displayed at many frequencies.
I guess the data protection is not good, the single-chip to read the FIFO and the chip to write the FIFO affect each other.
This is a chip problem, and there is no good way to completely solve it, although you can try to average out readings by using the average of multiple measurements to reduce the error.

Prueba que tal si haces X*(16/255) si estas en rango 16, sino cambia por 8, 4, o 2. Son valores de salida de un ADC.

Does this problem still exist? If calibration is not possible, you can try using some filtering algorithms (such as Kalman filtering, etc.) to solve this problem.

Hello,
I'm going to close this issue, feel free to re-open it if you have any other questions.
[Autocommentary]


Add event types

Events are part of the DOM, so shouldn't we define foreign types for them in this library instead of, for instance, as new foreign types in thermite?  It'd be a shame for every event handling library to need to define their own, incompatible foreign types for the same underlying events.

I started to give this a go tonight and discovered there is no obvious un-opinionated way to represent the event types due to significant inheritance.  Discovered that this has come up before in the purescript simple dom library (see issue 3).  I'm going to go ahead and close this.

FYI I am getting a start on trying out common event types here.  I'm fine with rolling them over into purescript-dom if it seems like they will have a place here.  Otherwise I'll keep doing my own thing.


"Getting Started" section of Read The Docs needs more information for SQL

Read the Docs only has documentation for OrientDB. More information is needed to easily get started with SQL.

I think it does:
https://graphql-compiler.readthedocs.io/en/latest/supported_databases/sql.html

Oh nice, but I think we should communicate that better on our home page https://graphql-compiler.readthedocs.io/en/latest/index.html. Right now it just shows the OrientDB stuff and isn't intuitive. Might be better to make the home page completely generic and have links to all supported end-to-end examples.

Oh ok that's fair. I see your point.


Build script class names depend on the absolute path

It seems like we use the absolute path for the class names of build scripts, see https://github.com/gradle/gradle/blob/a138710ab109e271b17ee48dc49b359284cd3f66/subprojects/core/src/main/java/org/gradle/groovy/scripts/TextResourceScriptSource.java#L76-L79.
As a consequence, Closures defined in build scripts (build.gradle) also will have a reference to the absolute path of the build script. The class name looks something like this: build_cy3ca74runcdcinr48br22m24$_run_closure2$_closure4.
This means that nested beans, like CommandLineArgumentProviders, defined by Closures in build scripts will cause the task to become non-relocatable.
For example, this is what happened in the spring boot build: https://ge.spring.io/c/4odyr2tkwjse6/aha5vme4vawuo/task-inputs
This is the corresponding code: https://github.com/wilkinsona/spring-boot/blob/7e400d1e73b0d008b6e4f4c200fe1bec9cb7a10c/spring-boot-tests/spring-boot-smoke-tests/spring-boot-smoke-test-data-cassandra/build.gradle#L23-L32
As a workaround, an actual class can be defined in the build script, which causes the class name to not contain a reference to the build script.

cc: @gradle/build-cache

We should probably use the same logic as we use for determining the class name of task actions: https://github.com/gradle/gradle/blob/bf64fff701e3d2033d41b891079969f1156d0cc4/subprojects/core/src/main/java/org/gradle/api/internal/AbstractTask.java#L773-L780
In other words, we should use ScriptOrigin when available.

How did we not find this problem before? Ah, because we don't have a way to check if script sources load from the cache. Using the execution pipeline for this would have fixed/highlighted the problem.

How did we not find this problem before? Ah, because we don't have a way to check if script sources load from the cache. Using the execution pipeline for this would have fixed/highlighted the problem.

This has nothing to do with loading the script sources from the cache. The problem here is that a nested bean is defined by an anonymous inner class a build script. The reason we missed this seems that we simply didn't have a test for it.

We should probably check if this is a problem for Kotlin as well.

I guess this would be easy to fix when we make Groovy DSL compilation via the execution engine, right?

I guess this would be easy to fix when we make Groovy DSL compilation via the execution engine, right?

I don't see how using the execution engine and fixing the absolute path names in script classes is related.

Let's put it this way: the conversion will present an opportunity to fix both.

Still an issue.


Heads-up 2024.2: UtilityMeterSensor.init() missing 1 required keyword-only argument: 'sensor_always_available'

System Health details
as always a heads up....
rendering a failure to setup the integration completely
Checklist

[X] I have read the FAQ to see if there is a known solution to my problem.
[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
please see log for details
Reproduction steps

update to beta 2024.2

...
Debug logs
Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:326
Integration: Sensor (documentation, issues)
First occurred: 08:31:58 (7 occurrences)
Last logged: 08:31:58

Error while setting up powercalc platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 326, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/powercalc/sensor.py", line 308, in async_setup_platform
    await _async_setup_entities(
  File "/config/custom_components/powercalc/sensor.py", line 370, in _async_setup_entities
    entities = await create_sensors(hass, config, discovery_info, config_entry)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/powercalc/sensor.py", line 618, in create_sensors
    return await create_individual_sensors(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/powercalc/sensor.py", line 774, in create_individual_sensors
    await create_utility_meters(hass, energy_sensor, sensor_config),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/powercalc/sensors/utility_meter.py", line 78, in create_utility_meters
    utility_meter = await create_utility_meter(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/powercalc/sensors/utility_meter.py", line 189, in create_utility_meter
    utility_meter = VirtualUtilityMeter(**params)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: UtilityMeterSensor.__init__() missing 1 required keyword-only argument: 'sensor_always_available'

Diagnostics dump or YAML config
No response

just found this PR was merged https://github.com/home-assistant/core/pull/103481

Thanks for reporting. I will have a look this weekend.

cool.
I know you are always faster than you promise ;-)
though, these dev blogs tend to have impact on your Integration, and for beta testers, it would be nice if we could fully test that.
the endless errors I throws now practically force us to completely disable Powercalc during Beta, which is not good, nor profitable for Powercalc itself
Seems best for your own users too, to be able to prevent throwing these issues on release if we could have tackled them before that.

Should be fixed with v1.10.1
Could you verify?

Yes,as posted in #beta I can confirm this to be fixed.
thank you !

Btw the new option sensor_always_available for utility meter is meant to keep the utility meter available regardless of the source entity being unavailable.
This is in line with the ignore_unavailable_state option of powercalc.
So I have also made a modification now that sensor_always_available is automatically set to the right value depending how you have set ignore_unavailable_state in powercalc.

a yes, I already tried to imagine something like that. very nice indeed.
keeps getting better this way
great integration !


Create anonymizer

i failed to disable the lint check at this branch @zivnevo

Do you mean renaming the variables as the linter suggests doesn't help?

I cant rename them, the names should be the same as in the  nsx_sdk.go file

please ignore, I figure it out
tnx


AirPlay module: Needs Apple HLS livestream transcoding to extend range of media AppleTVs can play

We've been porting @butterproject over to @watson's brilliant airplay-protocol and bonjour libraries.
As part of that, I discovered a serious AppleTV streaming problem that affects both WebTorrent and Butter (which uses WebTorrent for streaming).
The issue is being tracked at @butterproject's repo, so to avoid duplication I'll point everyone to the comment with the most relevant summary:
https://github.com/butterproject/butter-desktop/issues/528#issuecomment-267760909
In short: The AppleTVs support an extremely narrow range of containers, along with very specific H264 profiles and audio codecs. It isn't possible to just tell it to stream a ".mkv" file that WebTorrent serves. There needs to be transcoding in the middle. Otherwise the AppleTV fails to stream the video.
Solution (volunteers welcome): Both projects need a suitable Apple HLS (HTTP Live Streaming) proxy to sit in-between WebTorrent and the AppleTV. Such a proxy should be based on FFmpeg (because re-encoding will be needed), and should take care of:

Generating the main .m3u8 playlist, using the correct machine IP for all URLs (given by the caller to the library), so that we can be sure to bind to the correct network interface. The AppleTV is very picky about IPs.
Converting the external subtitle file (.srt, .ass, etc) to WebVTT instead.
Running a small HTTP server which serves the converted subtitle.
Embedding the URL to the WebVTT subtitle in the .m3u8 playlist, along with the URL to the FFmpeg .ts media chunk sub-playlist.
Running FFmpeg to transcode all non-H264 video and non-AAC audio to H264/AAC. But if the media codecs are already supported, tell it to use "codec:copy" to avoid wasting CPU. Most media simply need a container change.
Telling FFmpeg to chunk everything into MPEG2TS Transport Stream (.ts) containers.
Handling the communication between WebTorrent <-> FFmpeg <-> AppleTV, such as the ability for the AppleTV to seek in the file and have it pass through to WebTorrent to change the position in the stream (perhaps FFmpeg's server handles this communication for us).

Tons of projects have achieved all of this before us, so I know there are reference implementations all over the web (and perhaps even a working Node implementation). As this is a pretty big project, I am listing it on both trackers. I am going on a long trip and won't be around, and the other Butter devs aren't AppleTV users. So volunteers are welcome if anyone is interested in fixing AppleTV support in WebTorrent.

Thanks for cross-posting here. If such a project is undertaken, it would definitely benefit us as well. Using ffmpeg would sadly require compiling the app on each platform we want to support -- requiring a lot of VMs to do a single release, but that's acceptable if it solves this problem.
@SteveJobzniak Is it possible to use FFmpeg on a video file that is not completely downloaded? Otherwise, we lose the ability to stream to the Apple TV.

@feross I agree that it's really unfortunate to need FFmpeg. This is one of those times when Apple's walled garden approach really hurts us. They could have supported MKV and DLNA streaming and proper subtitles, but they insisted on AirPlay and MP4. "Not invented here" comes to mind. And also "Please buy all your media via our iTunes store instead of streaming your own".

Is it possible to use FFmpeg on a video file that is not completely downloaded? Otherwise, we lose the ability to stream to the Apple TV.

Yeah. FFmpeg can use live-streams as input and Apple HLS as output. Here's an example from a mailing list which turned up on Google:
https://ffmpeg.org/pipermail/ffmpeg-user/2013-November/018558.html
And there's more info here:
https://trac.ffmpeg.org/wiki/StreamingGuide
It seems like it would be possible to do the following:

Start FFmpeg, with input set to WebTorrent's server address. And output set as m3u8 and HLS in a folder.
Do the other things I listed above to generate the master playlist, the WebVTT file, provide web-access to the FFmpeg output folder, etc.
Serve the master playlist via a Node HTTP server, and tell the AppleTV to connect to that.
The AppleTV will then load the master playlist, load the WebVTT subtitle, and start streaming from the FFmpeg HLS playlist.

The main unsolved question is: Can the user scrub through the video on their AppleTV? If not, perhaps we can tell FFmpeg (perhaps via "FFserver"?) to generate an output .mp4 stream URL with embedded subtitles instead, which should allow the AppleTV to do seeking in the livestream.
Anyway, as mentioned, I need to leave now, so I won't be around to help. If someone is interested in tackling this project then contributors are very welcome. There are tons of projects who have already achieved this type of FFmpeg HLS transcoding. One that comes to mind is airflowapp.com, which uses FFmpeg and even lets the AppleTV control the playback via the AppleTV remote, so it looks like it is possible to allow seeking in the stream.

@SteveJobzniak Thanks for the excellent write-up! Waiting for our hero...

One more potential issue to watch for is quality.
I tried using https://www.strem.io/ as a solution to stream torrent files directly to airplay.
It did work (and I assume they are doing something similar to what is described). However I have to say the video/audio quality was terrible - and I checked the original file and it was fine.
I'm going to try to dig into this and see how tough it is.


Adding longer location name transformation

will generate transformation like.
(Michael Jordan is a professor at Berkeley ., B-PER I-PER O O O O B-LOC O) ->
(Michael Jordan is a professor at Eastern Berkeley ., B-PER I-PER O O O O B-LOC I-LOC O)

@ashish3586 please fix the PR so that the build can pass.

@ashish3586 would you like to address the reviewer comments.

@ashish3586 would you like to address the reviewer comments.

Changes are ready. will push shortly. Thanks for reminding me.

@ashish3586 would you like to address the reviewer comments.

Changes are ready. will push shortly. Thanks for reminding me.


Test script regex

Hi,
I've generated a project lately and experienced some issues when running the package.json test script. I had to add single quotes ' around the regex in order to make mocha work and dive recursively into deeper directories:
"test": "npm run build && mocha --compilers ts:ts-node/register --recursive 'src/**/*.spec.ts'"
So, basically src/**/*.spec.ts becomes 'src/**/*.spec.ts'.
Just saying in case anybody experiences this too!

Are you on windows? I use mac and haven't seen this problem. But I see the single quotes works on mac too so I guess I'll simply make the change in the generator itself.

I am using Mac too! 🙂

Alright 😃, thanks for reporting it. I'll make the change in the coming release which should be soon.

Great! You are welcome 😉


User-made Music SR output samples

@RetroCirce @haoheliu
I was not sure where to post it (or if I should submit a PR,) but I figured you may be interested in adding user-made output samples to your repo somewhere to showcase real-life applications/performance of your model.
Here is the link:
https://soundcloud.com/aleksandr-sigalov-61/sets/music-super-resolution-16khz-48khz
Output samples are very nice considering the input WAVs. Your model seems to perform well on music, especially at higher frequencies like Violin frequencies.
Let me know if its appropriate.
Sincerely,
Alex

@asigalov61 Will build a HF Space demo later - then you can share your sample at the discussion area. Alternatively you are welcomed to join this discord channel https://discord.gg/HWeBsJryaf and share your sample!

@haoheliu Ok. Thank you very much.


[mio] error linking executable related to lib mio after updating my vcpkg

Describe the bug
I updated my vcpkg today to this commit: https://github.com/microsoft/vcpkg/commit/871e20cf67ebaa80c048b868be53c8e7375c79f3
And I started to have a linking problem related to library "mio".
https://github.com/mandreyel/mio
There was no relevant change in the Canary project that could generate this problem, I started to have it exactly after updating my vcpkg.
Environment

OS: Windows 11
Compiler: Visual Studio 17.3

To Reproduce
Steps to reproduce the behavior:
Install dependencies to compile project Canary and before generating the executable the error will happen.
https://github.com/opentibiabr/canary
Expected behavior
Compile normally.
Failure logs
[148/149] Building CXX object src\CMakeFiles\canary.dir\server\network\protocol\protocolgame.cpp.obj
   [149/149] Linking CXX executable bin\canary.exe
   FAILED: bin/canary.exe
   cmd.exe /C "cd . && "C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E vs_link_exe --intdir=src \CMakeFiles\canary.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100220~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10 \bin\100220~1.0\x64\mt.exe --manifests -- C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\ link.exe /nologo @CMakeFiles\canary.rsp /out:bin\canary.exe /implib:src\canary.lib /pdb:bin\canary.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem: console /INCREMENTAL:NO /LTCG && cmd.exe /C "cd /D G:\GitHub\otbr\canary-fork\build\windows-release\src && C:\Windows\System32\WindowsPowerShell\v1.0\powershell. exe -noprofile -executionpolicy Bypass -file G:/GitHub/vcpkg/scripts/buildsystems/msbuild/applocal.ps1 -targetBinary G:/GitHub/otbr/canary-fork/build/windows-release/bin/canary.exe -installedDir G:/GitHub/otbr/canary-fork/build/windows-release/vcpkg_installed/x64-windows-static/bi n -OutVariable out""
   LINK Pass 1: command "C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1434~1.319\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\canary.rsp /out:bin\canary.exe /implib:src\canary.lib /pdb:bin\canary.pdb /version:0.0 /machine:x64 /debug /INCREMENTAL /subsystem:console /INCREMENTAL:NO /LTCG /MANIFEST /MANIFESTFILE :src\CMakeFiles\canary.dir/intermediate.manifest src\CMakeFiles\canary.dir/manifest.res" failed (exit code 1169) with the following output:
G:\GitHub\otbr\canary-fork\build\windows-release\fileloader.cpp.obj : error LNK2005: "class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator< wchar_t> > __cdecl mio::detail::win::s_2_ws(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?s_2_ws@win @detail@mio@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@AEBV?$basic_string@DU?$char_traits@D@std@ @V?$allocator@D@2@@5@@Z) already defined in cmake_pch.cxx.obj

      Creating src\canary.lib library and src\canary.exp object

G:\GitHub\otbr\canary-fork\build\windows-release\bin\canary.exe : fatal error LNK1169: Found one or more defined multiple symbols

   ninja: build stopped: subcommand failed.

Could you please provide me with a detailed repro steps?
Please include the vcpkg install command and the steps of building canary. Thank you!

G:\GitHub\otbr\canary-fork\build\windows-release\fileloader.cpp.obj : error LNK2005: "class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator< wchar_t> > __cdecl mio::detail::win::s_2_ws(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?s_2_ws@win @detail@mio@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@AEBV?$basic_string@DU?$char_traits@D@std@ @V?$allocator@D@2@@5@@Z) already defined in cmake_pch.cxx.obj

The same symbol was found in __cdecl mio::detail::win::s_2_ws, please check the link list.

Could you please provide me with a detailed repro steps? Please include the vcpkg install command and the steps of building canary. Thank you!

In the aforementioned project we used the vcpkg manifest, the libs are installed by vcpkg.json: https://github.com/opentibiabr/canary/blob/main/vcpkg.json

The same symbol was found in __cdecl mio::detail::win::s_2_ws, please check the link list.

I already checked... No problem, the lib is only included once. Even when I return my vcpkg to the older version (around December), the problem stops showing in the lib. It seems to have started after some update to the mio lib.

Maybe it's an upstream bug.

@dudantas Could you please submit an issue on upstream to report this issue?

I assume there is already an issue regarding this.
https://github.com/mandreyel/mio/issues/87

This has been fixed at: https://github.com/mandreyel/mio/pull/88, thanks for attention.

Please reopen, vcpkg side also need integrate this changes.

We don't need upstream-changes label now.


[iOS] Beginning of sample header cut off

Current behavior

Expected behavior

How to reproduce it (as minimally and precisely as possible)

Launch app
Open Burger menu
Select a sample
Notice that the beginning of the header is cut off

Environment

Nuget Package:
Package Version(s):
Affected platform(s):

[x] iOS
[ ] Android
[ ] WebAssembly
[ ] UWP

Anything else we need to know?

Fix verified


Fix CI

CI fails with a mongo installation error.
Ref: https://travis-ci.org/fat-code/storage/jobs/508102606

FIxed


Web Audio method chaining example

R: @samdutton @addyosmani
A templatized version of @samdutton's https://github.com/GoogleChrome/samples/pull/261
There's a live version at https://jeffy.info/samples/webaudio-method-chaining/ to test.

Thanks Jeff! LGTM.


Localization

Also offer german language for all pages.
You dont need to speak german for this issue. You could set up the structure for the localization and I translate all the words and phrases to german.

In the account setting it says that this feature is coming soon

Idk if the button to change languages should be on every page tho or just in the account settings?


Update expensify-common

Details
Updates the expensify-common version to include markdown for heading1.
Fixed Issues
https://github.com/Expensify/Expensify/issues/225615
Tests

[ ] Verify that no errors appear in the JS console

QA Steps

Run the app
Open any chat and send a text message containing lines starting with a # and a space and then text.
Check that the lines from the previous step are rendered as headings
copy the message to the clipboard and paste it into the composer (input text area)
check that the message is parsed correctly and that the headings are pasted as lines starting with # and space

QA for regressions

Sending messages with all the markdowns should be tested to check that the markdown rules are applied correctly in different markdown combinations
Copy-Paste the above messages to check that they are correctly converted back from html to markdown

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I have read the CLA Document and I hereby sign the CLA

@cristipaval I am trying to test this. As soon as I send the # heading, it shows up a heading and then immediately rolls back?
https://user-images.githubusercontent.com/3069065/196980892-e250fabb-43e5-4964-af7f-c2736237cc93.mov

@mananjadhav that's strange..it's working as expected for me.

@mananjadhav that's strange..it's working as expected for me.

Ohh! I checked with @cristipaval. This is because the change on the backend is yet to be deployed. Can you update here @cristipaval once it is deployed and I can take a look at it again?

I think we can leave that for QA!

PR Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

I think we can leave that for QA! @cristipaval what do you think?

@youssef-lr , I didn't realise that this PR won't work without the web PR being deployed. It worked on your local machine because you tested against dev. @mananjadhav tested against staging and the web pr is not in staging yet.
My suggestion is to mark this PR on hold until the web PR gets deployed. So even if you both approve it, I can't merge it before web changes are deployed.

Sounds good to me.

@cristipaval I found one issue while testing the PR. I saw this is deployed to staging, so I am connecting to the staging backend and testing it.
Android H1 with long text

Hey @mananjadhav I can't reproduce this on my Android device. Is it always reproducible on your end? What Android version you run and on what mobile phone?

Hi @cristipaval I am using an Android emulator to test this. I used Pixel 5 Android emulator.

Added CP staging label because this is the last thing blocking #churnedcustomers_engaged25

@cristipaval I think we can remove the hold and merge this.

Hi @cristipaval I am using an Android emulator to test this. I used Pixel 5 Android emulator.

Thanks @mananjadhav and @youssef-lr ! I tested with real Samsung Galaxy S20 and Samsung Galaxy A03 and I couldn't reproduce it. I'm discussing with the team atm to decide if we merge it as it is for now or we want more investigation.

Merged because this is blocking #churnedcustomers_engaged25

@cristipaval Just saw this was merged. I tested this on a real device - OnePlus 6, and I can still reproduce the issue. Guessing we would now want to fix this with a follow up PR?

With further testing it turns out if the text didn't have the link it worked fine. If I added the link, it cuts off.

🚀 Cherry-picked to staging by @cristipaval in version: 1.2.19-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @chiragsalian in version: 1.2.19-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This wasn't an emergency, just a dependency bump.


Could not allocate DHCP request (IDFGH-7715)

I have a problem with the mesh level: in fact I have two devices (one as  root and the other as node),  at the beginning
when I open the access point everything was fine and the mesh network was established and each device
obtained an ip address, However, after turning OFF the AP, I pressed the reset button of the node device so the node couldn't have an IP address even after opening the AP, So here I have a root (THE DHCP server) with an IP address and a node without IP address displaying
this message on the pc terminal side: "dhcp_select: could not allocate DHCP request".
PS: when I press on the reset button of the root the problem is solved(The node is able to have an IP address)

Closed by https://github.com/espressif/esp-idf/issues/9282.

Thanks for reporting, feel free to reopen.


[All] Consider wrapping raylib structs and methods into managed classes

Before submitting a new issue, please verify and check:

[x] The issue is specific to Raylib-cs and not raylib
[x] I checked there is no similar issue already reported
[x] My code has no errors or misuse of Raylib-cs

Issue description
I came across raylib-cpp recently and was wondering if maybe a similar approach would be good for raylib-cs
https://github.com/RobLoach/raylib-cpp
Environment
NA
Issue screenshot
NA
Code example
    int screenWidth = 800;
    int screenHeight = 450;

    Window window = new Window(screenWidth, screenHeight, "raylib-cs - basic window");
    Texture logo = new Texture("raylib_logo.png");

    window.SetTargetFPS(60);

    while (!window.ShouldClose())
    {
        window.BeginDrawing();

        window.ClearBackground(RAYWHITE);

        var text = "Congrats! You created your first window!"
        text.Draw(190, 200, 20, LIGHTGRAY);

        // Object methods.
        logo.Draw(
            screenWidth / 2 - logo.GetWidth() / 2,
            screenHeight / 2 - logo.GetHeight() / 2);

        window.EndDrawing();
    }

    // UnloadTexture() and CloseWindow() are called automatically using finalizer and IDisposable.

This would make the bindings rather opinionated and force users to write code in a specific way, potentially kneecapping non-standard/common architectures. I would suggest leaving this to downstream frameworks and libraries.
I believe we want Raylib-cs to be a direct bindings to raylib; choosing a design pattern should be left up to users.

The current approach with structs closely matches how raylib uses them. I have considered wrapping the structs into classes though having multiple types for the same thing makes it more confusing to learn/maintain.
That said, I want to continue improving the utils where possible and wrapper classes may be useful here in some places.

I think getting rid of structs is not possible, because we directly use them to interop with the native raylib library. Raylib c uses structs as well.
Heres an example:
        [DllImport(nativeLibName, CallingConvention = CallingConvention.Cdecl)]
        public static extern void ClearBackground(Color color);

This is the color struct:
https://github.com/ChrisDill/Raylib-cs/blob/master/Raylib-cs/types/Color.cs
Raylib doesn't support multiple windows as well:
https://github.com/raysan5/raylib/wiki/Use-multiple-windows
Writing a Window class in C# would require you to use a singleton.
Using finalizers doesn't work either since dotnet core. U will have to implement IDisposable and/or use the ProcessExit event in AppDomain:
https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/finalizers
So here is an example of how this could look like:
using Raylib_cs;

public class Window : IDisposable
{
    //singleton
    private static Window? s_instance;
    private int _width, _height;
    private string _title;
    private static bool s_disposed;

    private Window(int width, int height, string title)
    {
        Raylib.InitWindow(width, height, title);
        (_width, _height, _title) = (width, height, title);
        s_instance = this;
        //in case someone forgets to dispose
        AppDomain.CurrentDomain.ProcessExit += (s, e) => Dispose();
    }

    public int Width { get => _width; set { _width = value; Raylib.SetWindowSize(_width, _height); } }

    public int Height { get => _height; set { _height = value; Raylib.SetWindowSize(_width, _height); } }

    public string Title { get => _title; set { _title = value; Raylib.SetWindowTitle(_title); } }

    public bool ShouldClose => Raylib.WindowShouldClose();

    public static Window Instance(int width, int height, string title)
    {
        if (s_instance is null)
        {
            return new(width, height, title);
        }

        (s_instance.Width, s_instance.Height, s_instance.Title) = (width, height, title);
        return s_instance;
    }

    public void BeginDrawing() => Raylib.BeginDrawing();

    public void EndDrawing() => Raylib.EndDrawing();

    public void ClearBackground(Color color) => Raylib.ClearBackground(color);

    public void Dispose()
    {
        //make sure the window can only be closed once
        if (s_disposed)
        {
            return;
        }

        Raylib.CloseWindow();
        s_disposed = true;
    }
}

I don't really care about structs to much, the only thing I dislike is pointers and manual memory management.
I would love to see the whole library get rid of anything unsafe.
If someone needs a lower level c# raylib library auto bindings could be made, they would be needed anyways.

I have thought about it some more and decided to try a separate branch to experiment with the idea. I am cautious about making the project too opinionated but I can see the benefit in examples like what @JupiterRider has provided.

The first step is to further separate binding code from the wrapper. From there we can experiment with some ideas to improve the wrapper and see how it goes.

@ChrisDill Yeah, I think Raylib-cs should be a binding only. So Creating a extra project for additional stuff could be useful or at least fun.

Yeah, changing the approach to the library (e.g. combining functions into classes and such) is not a good idea for this library, as it's better to keep it as close to the original as possible, so the same documentation could be used.
BUT changing the way it works to get rid of any unsafe code is absolute requirement. The fact I have to fiddle with the unsafe code was sadly a deal breaker for me...

Agree a more direct mapping/binding makes sense (as then it's easier to translate existing C++ examples/docs/etc...) and leave more abstraction to building on top of it.
However, as long as the structs size and positioning is the same that's how interop directly with raylib is done right? In that case, it could be nice to at least PascalCase the public struct field names to make them to align to C# style guidelines. See https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions#pascal-case

Yeah, changing the approach to the library (e.g. combining functions into classes and such) is not a good idea for this library, as it's better to keep it as close to the original as possible, so the same documentation could be used.
BUT changing the way it works to get rid of any unsafe code is absolute requirement. The fact I have to fiddle with the unsafe code was sadly a deal breaker for me...

@ChrisDill Yeah, I think Raylib-cs should be a binding only. So Creating a extra project for additional stuff could be useful or at least fun.

Guys you know raylibcs-lo is a binding only library right?
It literally just generates bindings for C#
We don't have to use classes we can use structs but I would just use classes because they can be inherited and extended.
I think also requiring a window to create resources like textures would be good too since you can't really do that anyways.
so something like...
using Raylib_cs;
Raylib.InitWindow(0,0, "Example");

var texture = Raylib.LoadTexture("myImage.png");
while(!Raylib.ShouldWindowClose())
{

    Raylib.BeginDrawing()
    Raylib.DrawTexture(texture,0,0);
    Raylib.EndDrawing()
}

Raylib.UnloadTexture(texture);
Raylib.CloseWindow();

using Raylib_cs;
would be this...
using (var window = new Window(0,0, "Example"))
{

      var texture = new Texture(window, "myImage.png"); // Texture is kept track of by window.
      while(!window.ShouldClose())
      {
            window.BeginDrawing()
            texture.Draw(0,0);
            window.EndDrawing()
      }

}   // Window disposed with IDisposable and Texture unloaded
// If Window is not disposed here window is disposed with AppDomain.ProcessExit Event and ICLRPolicyManager::SetTimeout

That would amazing!

i like Raylib.DrawTexture(texture,0,0); more but i think automatically unloading texture is a good idea because if someone forget to unload texture it will cause memory leaks

i like Raylib.DrawTexture(texture,0,0); more but i think automatically unloading texture is a good idea because i sometimes forget to unload Textures

Not a bad idea, I think just changing it to this:
///
/// Texture2D type

/// NOTE: Data stored in GPU memory
///
[StructLayout(LayoutKind.Sequential)]
public partial struct Texture2D : IDisposable
{
    ///
    /// OpenGL texture id
    ///
    public uint id;

    ///
    /// Texture base width
    ///
    public int width;

    ///
    /// Texture base height
    ///
    public int height;

    ///
    /// Mipmap levels, 1 by default
    ///
    public int mipmaps;

    ///
    /// Data format (PixelFormat type)
    ///
    public PixelFormat format;

    /// Unload texture from GPU memory (VRAM)
    public readonly void Dispose() => Raylib.UnloadTexture(this);
}

should work, however I wouldn't know if this is a disired feature.

if you want the binding to be as close to Raylib as possible then this is unnecessary, but then again this is C# and this is good reminder to the user that this can cause memory leaks if not being unload correctly

i like Raylib.DrawTexture(texture,0,0); more but i think automatically unloading texture is a good idea because i sometimes forget to unload Textures

I don't like static Raylib methods because it means we can accidentally call functions without initializing raylib.
I think at least they should be tried to a Window class that we create by using the constructor or a static singleton Instance() method.
The only reason to use a constructor is if raylib-cs supports multiple windows

The idea of using the window to make sure raylib is initialized seems interesting. Though not sure what the full api for that approach would look like and I would only want that to apply to methods that need raylib initialized if I add something like it.
I don't want to spread all the methods that require a window across all the resource types but moving a large chunk of graphics methods into a window class is not great either. Maybe additional module classes that can be accessed from the window? Not quite sure what that should look like but worth considering.

To clarify the goal of Raylib-cs. I don't mind adding utilities and maybe wrapper classes but there should be a good balance of being both close to the raylib while adding enough to be nice to use in C#.

yeah

I want to create a pull request for it :)

Pls give me some feedback #188


refactor: guidelines 3 button style

Resolves #253

this is going to be developed in the new repo.


Added a more generic error reporting function: generic_error().

First of all, thanks for this great piece of code. Made my life a lot easier by eliminating a lot of boilerplate code. :) :+1:
I'm working o a project right now that requires me to perform certain authorization operations on various operations. Some operations are permitted only to a certain group of people. For example it would make sense to return a 401 to a user if they are not part of a specific privileged group. Or, maybe there is something specific about a request that makes it simply off-limits always. And in that case returning 403 would fit even better.
Please, take a look at this PR. It's introducing a new function generic_error() that allows the user to specify particular details about the error they want to return to the user. For the above examples I'd be able to e.g.:
return fastapi_chameleon.generic_error("errors/my_unauthorized_template.ts", 401)

Works just like not_found(), but allows to specify the status code.

Hi @Prezu Thanks a bunch for this. Sorry it took so long for me to find and merge it.
There is a minor error. You didn't import the generic error into the top-level package space. See https://github.com/mikeckennedy/fastapi-chameleon/commit/2115234f7fb2e8cfad98d1487b5f76c30cfa4213
I'll push this to pypi soon.

Here you go, 0.1.14:
https://pypi.org/project/fastapi-chameleon/0.1.14/
Thank you!


Introduce the Dependency Review GitHub Action to CI ✅

The Dependency Review GitHub Action is very powerful for scanning pull requests for dependency changes and is capable of raising a CI error if vulnerabilities or invalid licenses are being introduced.
I'd recommend using the following workflow setup:
name: 'Dependency Review'
on: [pull_request]

permissions:
  contents: read
  pull-requests: write

jobs:
  dependency-review:
    runs-on: ubuntu-latest
    steps:
     - name: 'Checkout Repository'
       uses: actions/checkout@v4
     - name: Dependency Review
       uses: actions/dependency-review-action@v4
       with:
        comment-summary-in-pr: always
        fail-on-severity: high
        allow-licenses: MIT
        fail-on-scopes: development, runtime

@

@joeyyy09 - thanks for taking this on! Can you drop a comment below and we should be able to assign this ticket to you! Great work ❤ 🤗

Yeah sure!


fix: fix deprecation warnings for Logger.warn/1

Current dependencies on/for this PR:

main

PR #10   👈

This comment was auto-generated by Graphite.


Cast string to integral type not compatible with Spark

scala> val inputs = Seq("123", "-123", "86374").toDF("n")
inputs: org.apache.spark.sql.DataFrame = [n: string]

scala> inputs.write.parquet("test.parquet")
24/02/13 07:40:14 INFO src/lib.rs: Comet native library initialized

scala> val df = spark.read.parquet("test.parquet")
df: org.apache.spark.sql.DataFrame = [n: string]

scala> import org.apache.spark.sql.types._
import org.apache.spark.sql.types._

scala> val df2 = df.withColumn("converted", col("n").cast(DataTypes.ShortType))
df2: org.apache.spark.sql.DataFrame = [n: string, converted: smallint]

scala> df2.show
+-----+---------+
|    n|converted|
+-----+---------+
|86374|    20838|
| -123|     -123|
|  123|      123|
+-----+---------+

scala> spark.conf.set("spark.comet.enabled", false)

scala> df2.show
+-----+---------+
|    n|converted|
+-----+---------+
|86374|     null|
| -123|     -123|
|  123|      123|
+-----+---------+

Yea, I can reproduce this. I debugged this a bit. Looks like it is because the function we use to do string to integer cast: https://github.com/Alexhuszagh/rust-lexical/issues/105, which doesn't handle overflow case.

Waitting for a fix from lexical may be not practical as the ticket was created 6 months ago, I'm going to fix it at arrow-rs instead.


Delete plugin directory when uninstalling

When uninstalling a plugin, we should delete the plugin as well. This way if a user has a problem they can get a fresh copy of the plugin by uninstalling and reinstalling it.

@JeroenBoersma do you have time to review this pr?

I will look at this, was at a conference :)

Yeah I saw the conference tweets! Looks like you had fun! [:


Kubernetes integration not disabling other inputs

I'm trying to use the Kubernetes integration and it's only disabling the data streams in the same input and not disabling the other inputs.
For example when I deploy kubernetes.kube-state-metrics.state_replicaset.kubernetes_metrics only the Kubernetes Replicaset metrics data stream is enabled for Kube State Metrics but all of the other inputs & their data streams are still enabled. See the screenshot below.

I thought I had fixed that with 68117a6390609538a0ff6dc96b45166d88706ec2. Are you running the latest commit?

Yea, I ditched my local fork last week and built the binary from the latest code you released

I think I see the issue. It may also need to disable every unused package_policy too. I was operating under the assumption that if the request did not include anything for those unused package policies that they would be treated as enabled: false. Here's the request from Kibana.

So I probably need to modify the fleet_package_policy TF module to insert an entry into inputs for each of those unused package_policy+input_type combos.

That's kind of annoying... Too bad all inputs are disabled by default as that would make life easier in many ways.

I have an untested fix if you would like to try this: 6a59ab08c2158bb9562bde651a142c633a484be6

Sure, i'll grab it and report back shortly

Looks like that did the trick.

I just updated all of the kubernetes integration policies I was adding to this fleet agent policy and they all look good now

Sweet. I'll clean this fix up and open a PR. Thanks for testing.


The bottom nav bar should sustain its state

If the nav bar is minimized when I click on a post, it should remain that way when I go back to the previous page.

I actually purposely make it big again when you return


cpu 100%

Type: Performance Issue
my vs code is high performance
VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:22:44.506Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD Ryzen 3 4300U with Radeon Graphics          (4 x 2695)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
7.37GB (1.32GB free)

Process Argv
--crash-reporter-id 2766a21b-e979-41a3-b059-ee0d0ee2fadb

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    96	 29916	code main
    0	    26	 14068	   crashpad-handler
    1	   147	 15676	   utility-process
    0	    92	  4896	     electron-nodejs ("C:\Users\lenovo\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node c:\Users\lenovo\.vscode\extensions\onecentlin.laravel-blade-1.32.0\server\out\htmlServerMain.js --node-ipc --clientProcessId=15676)
   52	   188	 12544	     c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint_managed-jre\jre\jdk-11.0.15+10-jre\bin\java -jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\server\sonarlint-ls.jar 56965 -analyzers c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarjava.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarjs.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarphp.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarpython.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarhtml.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarxml.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonarcfamily.jar c:\Users\lenovo\.vscode\extensions\sonarsource.sonarlint-vscode-3.15.1-win32-x64\analyzers\sonartext.jar
    0	    10	 23384	       console-window-host (Windows internal process)
    0	     5	 27708	     "C:\Program Files\Git\cmd\git.exe" status -z -uall
    0	    10	  8568	       console-window-host (Windows internal process)
    6	    77	 22096	       git.exe status -z -uall
    0	   154	 29100	     electron-nodejs ("C:\Users\lenovo\AppData\Local\Programs\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node c:\Users\lenovo\.vscode\extensions\pranaygp.vscode-css-peek-4.2.0\server\out\server.js --node-ipc --clientProcessId=15676)
    0	   282	 24320	   window (checkout.blade.php - example-app - Visual Studio Code)
    0	    39	 27356	   utility-network-service
    1	    84	 29204	   issue-reporter
    1	   223	 30140	   gpu-process
    0	   127	 30180	   shared-process
    0	    73	 14628	     ptyHost
    0	    76	 29212	     fileWatcher

Workspace Info
|  Window (checkout.blade.php - example-app - Visual Studio Code)
|    Folder (example-app): 12280 files
|      File types: php(7609) svg(1623) md(272) js(186) json(172) scss(108)
|                  stub(84) css(57) png(47) rst(39)
|      Conf files: dockerfile(7) package.json(2) makefile(2) jsconfig.json(1);

Extensions (40)

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
1.9.5

package-json-upgrade
cod
1.6.0

dart-code
Dar
3.60.1

composer-php-vscode
DEV
1.31.12740

adonisjs-snippets
Ema
1.0.1

code-runner
for
0.12.0

vscode-pull-request-github
Git
0.60.0

go
gol
0.38.0

adonisjs-snippets
Hri
1.0.2

composer
ika
0.8.0

adonis-vscode-extension
jri
0.9.1

composer-intellisense
kai
0.7.0

edge
luo
0.3.2

vscode-docker
ms-
1.24.0

anaconda-extension-pack
ms-
1.0.1

isort
ms-
2022.8.0

python
ms-
2023.4.0

vscode-pylance
ms-
2023.3.10

jupyter
ms-
2023.2.1000592019

jupyter-keymap
ms-
1.1.0

jupyter-renderers
ms-
1.0.15

vscode-jupyter-cell-tags
ms-
0.1.6

powershell
ms-
2023.2.1

debugger-for-chrome
msj
4.13.0

laravel-blade
one
1.32.0

material-icon-theme
PKi
4.24.0

vscode-css-peek
pra
4.2.0

open-php-html-js-in-browser
Pri
2.2.0

vscode-yaml
red
1.12.1

LiveServer
rit
5.7.9

flutter-dart-utils
Rod
0.4.5

sonarlint-vscode
Son
3.15.1

open-in-browser
tec
2.0.0

vscode-npm-scripts
tra
0.2.1

errorlens
use
3.7.0

volar
Vue
1.2.0

JavaScriptSnippets
xab
1.8.0

php-debug
xde
1.32.0

html-css-class-completion
Zig
1.20.0

php-intellisense
zob
1.1.2

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vscaac:30438847
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848:30662994
nodejswelcome1:30587005
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
a9j8j154:30646983
pythonb192:30669360
funwalk2:30676043
pythonms35:30680984

/confirmPlease

Thanks for creating this issue! To help narrow it down, please take the time to follow below steps. Thanks a lot and happy coding 🙏
Is the issue caused by an Extension?
Stop VS Code and from the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If it still reproduces, jump to the next chapter.
If you see it is an issue with the extension, please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.
Is the issue caused by VS Code Core?
If the issue is not caused by an extension, it is maybe caused by your configuration. Try to run code --disable-extensions --user-data-dir <directory> where <directory> is an empty folder. This will ensure Code is starting with a fresh data directory, e.g. no specific settings and without any extensions running.
If it still reproduces, it was maybe fixed already in our nightly release. Please download from https://code.visualstudio.com/insiders/ and see if you can reproduce the issue.
Finally, to help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

npx --yes vscode-bisect@latest
follow the instructions until you found the offending build
report back the commit range in this issue

Thanks!

@gjsjohnmurray @usernamehw @IllusionMH fyi you can also use /confirmPlease to trigger the bot message in https://github.com/microsoft/vscode/issues/176545#issuecomment-1559877057 🙏

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Radius should support postgres datastore for users

As a user, I want to be able to use Postgres DB as my Radius datastore. I should have the option of using a pre-existing Postgres database, or optionally setup and use Postgres container as part of Radius installation.
As part of rad init and rad install, we should provide an option to choose postgres as datastore. We should also provide the users with an option between BYOD and installing postgres as part of Radius install. Upon choosing Postgres, we should setup postgres container ( if required), configure the postgres to have ucp and applications-rp databases and corresponding users, and neccessary tables for the 2 services.
AB#13382

included this requirement in #7975


model is not updated

Question
sometimes model is not updated with fields because i set fields dynamic i can't catch the problem but it always this is problem when set dynamic fields ?

try to force update model input in order to properly detect changes: this.model = { ...this.model }.


Needs read exception handler

OpenRead call needs to handle IOException which can occur due to sharing violation.

IOException is now handled in v1.0.3


Update s3-release-blobstore

I've heard the folder-related question come up in Slack a couple times.

folder option will eventually be removed because we are moving towards using s3cli everywhere.


Unable to load histology image

Currently using HERBS on Windows 10. I am however unable to upload my own histology image and receive this error message in the terminal when I select an image to upload:
"...image_curves.py", line 277, in reset_plot for i in range(len(self.hist_data)):
TypeError: object of type 'NoneType' has no len()

Hi, what type of histological image did you upload? .jpg? .tif? .czi? OR?

Hi I tried uploading .tif and then tried again with .jpg

Both don’t work? Could you please state the procedure/steps you did? If ok for you, could you share the image with me so I can find the problem immediately without guessing the error here. As I can upload both format without problems. You can find my email address on the front page of my GitHub. Thanks.
Best,

在 2022年9月29日，14:22，ishiangoli @.***> 写道：

Hi I tried uploading .tif and then tried again with .jpg
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

We can not re-produce the problem you had. We have Windows 10 with virtual env or Conda. We have no problem uploading histological images within both env with 64bits operating system and 64bits Python. What is your operating system? 64 bit or 32 bit? What about Python? which version? 64bit Python or? What are the versions of all dependencies you have? did you make a new env before you install HERBS? Or do you have old dependencies installed for other projects?

I am facing the same issue with the same error message on Windows 10, Python v3.9, with a new environment made before installing HERBS.

Hi @nataliekoh, I wonder which type of image you tried? .czi?

If it is not .czi, can you close HERBS and reopen it and try again, make sure there is no other error message before you load images.
If it is .czi, can you try the follow code, where czi_path is a string of the path of your .czi file.
from aicspylibczi import CziFile
czi = CziFile(czi_path)
czi_info = czi.dims
dimensions = czi.get_dims_shape()
is_mosaic = czi.is_mosaic()
pixel_type = czi.pixel_type
len(dimensions)
if you print out and show me czi_info, dimensions, is_mosaic, and pixel_type, we probably can find the problem :-)

Hi Jingyi, thank you for replying so quickly! I tried uploading a couple of TIF images. I did close the conda terminal and HERBS application twice, but that didn't work.
Here are the error messages I am getting:
Python 3.9.13 (main, Aug 25 2022, 23:51:50) [MSC v.1916 64 bit (AMD64)] :: Anaconda, Inc. on win32
Type "help", "copyright", "credits" or "license" for more information.

import herbs
herbs.run_herbs()
test multi series
Traceback (most recent call last):
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\herbsgui.py", line 4507, in load_image
self.load_single_image_file(self.current_img_path, image_file_type)
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\herbsgui.py", line 4562, in load_single_image_file
self.image_view.set_data(image_file)
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\image_view.py", line 262, in set_data
self.volume_img = copy.deepcopy(self.image_file.data['scene 0'])
KeyError: 'scene 0'
test multi series
Traceback (most recent call last):
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\herbsgui.py", line 4507, in load_image
self.load_single_image_file(self.current_img_path, image_file_type)
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\herbsgui.py", line 4562, in load_single_image_file
self.image_view.set_data(image_file)
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\image_view.py", line 243, in set_data
self.curve_widget.reset_pressed()
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\image_curves.py", line 671, in reset_pressed
self.curve_plot.change_line_type('gamma')
File ...\anaconda3\envs\herbs\lib\site-packages\herbs\image_curves.py", line 317, in change_line_type
self.reset_plot()
File "...\anaconda3\envs\herbs\lib\site-packages\herbs\image_curves.py", line 277, in reset_plot
for i in range(len(self.hist_data)):
TypeError: object of type 'NoneType' has no len()

Hmmmm, TIF... To be honest, .tif is in testing. the problem for me is that we don't have so many different TIFs to test.  So if you could share one of your tif file with me, I can fix the problem. you can find my email on the front page of this GitHub.
From the error messages you reported (there is a line says 'test multi series', it is what I write in the code to tell me it is in testing phase), either you tif contains multiple scenes or multiple pages or it is a big tiff. No matter which type, I do not have such a tif to test before. I would be very grateful if  you could share one of the image with me 🥰

Ah, okay. Yes, I'll email you a couple of TIF images! Thanks so much for looking into this!

Hello, I just thought I would add that I am experiencing this issue too but also with .jpg files. When saving images on imageJ which we often use for histology it is usually in a tif or jpg format, I am not sure how to save as a czi.

Hi, thank you all for the feedback. @ishiangoli, could you please share one jpg image with me that you can not upload? The best will be the jpg you saved from imageJ. I have update the tif reader on GitHub today, not on PyPI yet. Trying to finish some more before updating PyPI.

Hi @nataliekoh, as what we discussed through emails. I update the code on GitHub and PyPI for your .tif file. I can upload your tif file locally without any problem now. Please let me know how it goes with you.

Hi Jingyi, I am able to load my .tif images now. Thank you so much for resolving this issue!


Add Organizations of a user

Currently, the organizations a user belongs to is not displayed. Also, if a repo belongs to an organization instead of an individual as is the case with this repo, the link of the organization won't work.
So we need an organization screen and on the profile page, the list of organizations the user is a part of. Where do you think we could place it? (It'd just be a row(s) of profile pictures)

Below the yellow line or above the contributions graph or anywhere else?

I'm not sure. Seems both would be OK?

@pd4d10 I need some help. I'm trying to add the organization connection in gh_user.graphql. Under repositoryOwner and inside ... on User is where I'm trying to place it. But for some reason it affects the results of ... onOrganization in gh_user.dart. Am I doing anything wrong?

It seems an issue of the artemis lib: https://github.com/comigor/artemis/issues/18
I tried to upgrade its version before but got another problem: https://github.com/comigor/artemis/issues/63#issuecomment-590172267

Alright. Also in the org_repo
screen some organizations have to enable permission for us to be able to fetch details. For example, I'm able to view the Google organization but not the git touch organization (it is stuck on loading forever). Do you think if would be good to add a timeout option and tell display a pop-up telling the user about this? But as far as I know you are already displaying an error message if an error occurs. Still no error message pops up. Maybe because we should add a timeout feature?

I'm not sure if the permission you mentioned is related to this:
https://github.com/git-touch/git-touch/blob/805f065def16e008d65d5fc230eb1a212df93319/lib/screens/gh_org_repos.dart#L10-L15
We have changed it from GraphQL to RESTful API to avoid the access restriction.

. Maybe because we should add a timeout feature?

Agreed. We could have one.

I'm not sure if the permission you mentioned is related to this:
https://github.com/git-touch/git-touch/blob/805f065def16e008d65d5fc230eb1a212df93319/lib/screens/gh_org_repos.dart#L10-L15
We have changed it from GraphQL to RESTful API to avoid the access restriction.

Yeah, I saw this but for some reason it still doesn't load even though the organization is public( I'm talking about git-touch). Timeout sounds like a hacky fix for now. Doesn't point to the underlying problem.


Native Support

To support calling natives from other plugins and getting callbacks for other plugins to work (like FCNPC) we need to implement native support in the plugin.

I am fairly sure that this has been addressed in cf1057ab0c9a6cd50a0d18512c95817cb42ee899 - instead of natively calling, we can wrap the "CallNativeFunction" in python, and use it that way.
Down the line it would be fun to provide modules that cover the most common plugins.