WIP: NuclideFraction and Element

Closes #8.
Initial impl of NuclideFraction and Element

NuclideFraction is restricted to Nuclides of the same element, implements ChemElement
Element represents the naturally abundant nuclide fraction, except for unnatural elements where the most stable isotope is represented instead

Impl cleanups

use let (...) = SYMBOL_INDEX[...] for clarity in impls instead of tuple subsetting
Abbreviate some Nuclide impls with Option<> methods and question mark operators

I was hoping you could give me some feedback on the direction this is taking @JASory. So far, I think NuclideFraction has limited use since all except one of its methods implementing ChemElement really just forward to one of its Nuclides, since it is (so far) limited to single element type fractions.
Either NuclideFraction stays as-is, with limited usefulness really aside from the fact that library clients can look up the exact isotopic composition of natural samples, or we could drop the restriction, not implement ChemElement, and instead look at implementing some isotope decay features with it.
What do you think?
Aside from that, I know I've meddled a fair bit in your Nuclide impls. I can happily remove those changes from the MR, but I thought they added clarity or also possibly performance in some cases. Just let me know how you feel about them.
TODO

[ ] More tests
[ ] Documentation
[ ] Calculate mass for each element in const fns and ensure those are exact

It looks good, thank-you for cleaning up the code the majority was written back when I was writing "C but in Rust".
It seems like both of our initial goals were satisfied, adding generic Element structs while still being user-definable fractions for versatility.
I was planning on extending it to provide for some decay properties, like the approximate decay energy per atom. If you have other ideas let me know.
"Is so far limited to single element fractions"
Unfortunately I intend for it to remain so. Nuclide is meant to model individual nuclides, theoretical nuclides or a nuclide representing an average of some sort, going to model mixtures of different elements is too far. I don't want it to feature-creep into a computational chemistry library, but stick to the same direction. That being said, if there is functionality that makes sense for nuclides and helps with chemistry or other applications I would be willing to implement it.

I'm not sure the purpose of printing the nucleon_fractions argument in from_nucleon_fractions, since the user can just print it before it's passed to the function if they want to. So I'm removing it.

Unfortunately I intend for it to remain so.

A-okay with me. I just felt it had limited utility and wanted to offer some options.

So I'm removing it.

Of course. I titled this Work In Progress on purpose, I had actually meant on cleaning this up a bit more, removing the dbg statements and adding documentation :see_no_evil:


Unable to install rspec-rails using README.md instructions

What Ruby, Rails and RSpec versions are you using?
Ruby version: ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-darwin19]
Rails version: Rails 5.2.3
RSpec version: RSpec 3.9

Observed behaviour

As per the README.md I made this change:

diff --git a/Gemfile b/Gemfile
index 0fc37a4..4e8b9d3 100644
--- a/Gemfile
+++ b/Gemfile
@@ -39,6 +39,7 @@ group :development, :test do
   gem 'byebug'
   # Use sqlite3 as the database for Active Record
   gem 'sqlite3', '~> 1.3.6'
+  gem 'rspec-rails', '~> 4.0'
 end

 group :test do

Then install:

$ bundle install
Fetching gem metadata from https://rubygems.org/.............
Fetching gem metadata from https://rubygems.org/.
Could not find gem 'rspec-rails (~> 4.0)' in any of the gem sources listed in your Gemfile.

Expected behaviour

rspec-rails installs without errors

Can you provide an example app?

N/A as this is easily reproduced in any repo

My research into the issue
Currently, 3.9.0 seems to be the latest available non-prerelease version released:
$ gem search -qre --no-prerelease rspec-rails
rspec-rails (3.9.0)

The pessimistic version constraint won't include prerelease versions of gems, so Bundler is unable to find a version of the gem that matches the version constraint that we're advising users to use in the README.
Assuming that we don't want users to install prerelease versions by default, I think the README has been updated a bit too soon, and until 4.0 is released, the README should instruct users to add gem 'rspec-rails', '~> 3.9' to their Gemfiles.
I'm happy to patch this in a PR, if desired 🙂

:wave: README.MD is for the 4.0.0 series / master branch, it is installable as 4.0.0.beta3 although we are hoping to have the final release out soon. The 3.9 branch refers to 3.9 etc in the readme, and if you look on Rubygems you'd get the right readme.


Create walkthrough/sample for source and config file transformations

Copied from https://github.com/MicrosoftDocs/mvp-hackadoc-2018/issues/44
https://docs.microsoft.com/en-us/nuget/create-packages/source-and-config-file-transformations describes the capability, but we lack a good example that also shows the impact on the consuming project. The impact also needs to show what happens in both packages.config and PackageReference cases (according to NuGet/docs.microsoft.com-nuget#516, the statement at the top about PackageReference is wrong, but needs verification).
Request is to update the article with a walkthrough. Recommend approaching from a basic CLI standpoint using a folder structure to create the .nuspec.
Include dotnet and nuget CLI commands in all examples.
Relevant issues:
#237
#516

Not eligible for docs day.
Note to self - find the dupe and close it.


options=-c support in connection URLs

Fixes https://github.com/cockroachdb/docs/issues/10069.

This change is


Add i18n + German translation

I added internationalization and a German translation. This works as follows: Everywhere in the popup the strings to be translated are replaced with <i18n>*title of the message*</i18n>. A for loop iterates through all <i18n> elements replacing their innerText with the translation message.
Example: Instead of Search Engine Redirects there's now <i18n>popupTitle</i18n>.
Btw: I love your addon already ☺

Thank you for this. I just cloned your repo by downloading zip. However, all I see on the popup is this, in the picture. Is this expected, or should I be seeing the words you've set?

Oh, I'm sorry for that. I used browser.i18n.getMessage(msg); since I'm used to working with Firefox. But Chrome (the browser you obviously used) only supports chrome.i18n.getMessage(msg); so I switched to that (Firefox supports both). Everything should work now 😊
Here's the English localization:

And the German one:

Thank you for this! Amazing!!

@realpixelcode May I ask you to help us translate for German? Here is the transifex page. Although, there won't be much to translate.

@aapl-yumi Yeah, of course! It would be an honor for me 😊

Thank you!


[release-2.8] Fix Hosted mode framework test (#141)

Manual cherry-pick:

#141

Ref: https://issues.redhat.com/browse/ACM-6966

/retest

@dhaiducek could you please try rebasing to see if that fixes the Prow issue?


raw_invitation_token not matching invitation_token saved in DB after invite!

devise (4.8.0)
devise_invitable (2.0.5)
I have the following issue :
1 - Opening a console in local development, I run User.invite!(email<EMAIL_ADDRESS>2 - It creates a User  in the DB with a particular invitation_token. The invitation email is displayed in the terminal (config.action_mailer.default_url_options = { host: 'localhost', port: 3000 })
3 - I get the MY_TOKEN_IN_EMAIL in the link provided in the email, and try:
Devise.token_generator.digest(User, :invitation_token, MY_TOKEN_IN_EMAIL)  it returns different token that the on saved in DB.
The result of this is that the link in the email is not working.
However, if I keep the user created (let's call it my_user), and run :
raw, enc = Devise.token_generator.generate(User, :invitation_token), and the my_user.update(invitation_token:  enc), the raw token will work.
Any idea ?
Happy to give more information if need. Thanks a lot.

I have tested in new app, and I can't reproduce it
DeviseInvitable uses Devise.token_generator.generate and Devise.token_generator.digest, as devise does in recoverable module. Can you try with a user and code from recoverable? Try calling raw = set_reset_password_token and User.with_reset_password_token(raw). These methods in Devise.token_generate are defined in devise gem, you may get more help creating an issue in devise project.

@scambra  It's totally my fault. After hours, I realised that in the mail displayed inside the terminal the token was prefixed with 3D(see quote-printable system). When you remove it, it works perfectly 😅
I can either suggest something to add to the Readme (if you think more people will struggle with it) or close the issue. Let me know.

You can push a pull request improving README, it would only happen if email is read from rails console or rails log, if you receive email, email reader will display right url

Thank you @LeonardSellam!!! I just encountered the same issue, doing a copy paste from the log, and the '3D'-prefix was included.

Same issue here, I kept copying the accept URL with the 3D= in the token, removing that before visiting the URL fixed it.


Proofread Roadmap

https://unikube.io/docs/roadmap/

[x] Named Cluster State (Please check file name - asset loader - again @Schille)
[ ] Helm Overrides
[ ] Health check for projects
[ ] Remote Cluster Provider

To Dos @Schille

Named Cluster State: Please check file name/slug - asset loader - again
Health Check for Projects: Are there two health checks described in the text? One is called "Project Health Check", the other one is called "Project Check service" - If so, a new headline in between would be helpful. If its one and the same check, the naming should be consistent.


Update ZipFile.cs

AddUpdate method previously had index which was adjusted by -1 so, that it could with with updates_ generic list.
For some reason, -1 adjustment was removed in the latest code which was causing index out of bound error.
FindExistingUpdate method returns the one based index whereas updates_ generic list is zero based, so adjusting "index" by -1 is necessary.

Under evaluation.
-Neil

Closed due to lack of MIT and activity


[client] adding two standard field on all JSONRPC response

These two field is needed to assist stateful client to detect stale response from server side.

@xli @andll  can you guys take another look?

@bors-libra r=xli

:pushpin: Commit 69d652f has been approved by xli

:hourglass: Testing commit 69d652f2bd9fef80cee4dc12dc608525ae283b74 with merge 69789448fffbf5f691f66c473ecce494af5cd1ee...

@thefallentree and @xli, the spec needs to be updated as well.

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: xli
Pushing 69789448fffbf5f691f66c473ecce494af5cd1ee to master...

@aching yeah, will send additional PR for that.


[BUGS] Register Button Turns White While Focusing

Description
On the user registration page, the register button's bg color turns white while focusing.
Screenshots

Additional information
I saw the class name of the register button is login-btn is it by mistake? when I give it register-btn its background color turns red to blue. Which is it's original color? for reference see line 261 in src/pages/user/UserRegister.jsx
🥦 Browser
Google Chrome
👀 Have you checked for similar open issues?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

Great spot @codewithrabeeh  That sure is an acessibility issue. When you would hover over the button it would have a minimal whitish effect. Can we fix this for focus ?
Also when we are focusing on the input fields they turn out to have a blue color box shadow, can we make it the same color as our theme  #e26959


Update Suhyun's KCC 2024 photos and posters

[ ] bibtex
[ ] photo
[ ] DBpia paper link
[ ] poster file pdf
[ ] paper pdf

See https://www.dbpia.co.kr/search/topSearch?searchOption=all&query=Exploring+Hallucination+Types+in+Question-Answering

And https://aiml-k.github.io/publication/2024kcc-bae-lee/


Loki in NativeScript: avoid using LokiFsAdapter

When using Loki in NativeScript, using "new Loki()" (in Loki itself, e.g. in Loki.prototype.copy) fails, since it by default uses LokiFsAdapter, which requires the unavailable node fs module.
So either the configured persistence adapter could be used:
Loki.prototype.copy = function(options) {
//var databaseCopy = new Loki(this.filename);
var databaseCopy = new Loki(this.filename, (this.persistenceAdapter === null)?{}:{adapter: this.persistenceAdapter});

LokiPartitioningAdapter.prototype.loadDatabase
this.dbref = new Loki(dbname, {adapter: this.adapter});

// doesn't work, since we're using a copy without a persistenceAdapter (removeNonSerializable)
Loki.prototype.serializeDestructured
/dbcopy = new Loki(this.filename);
      dbcopy = new Loki(this.filename, (this.persistenceAdapter === null)?{}:{adapter: this.persistenceAdapter});

Or a default persistence for NativeScript could be provided:
    Loki.prototype.configureOptions = function (options, initialConfig) {
      var defaultPersistence = {
          'NODEJS': 'fs',
          'BROWSER': 'localStorage',
          'CORDOVA': 'localStorage'
//		  'NATIVESCRIPT': 'nativeScript'
        },
        persistenceMethods = {
          'fs': LokiFsAdapter,
          'localStorage': LokiLocalStorageAdapter
//		  'nativeScript': LokiNativeScriptAdapter // would need a require somewhere
        };

and then this would work in NativeScript:
global.ldb = new Loki(path, {
	adapter: partitioningAdapter,
	env: "NATIVESCRIPT",
	throttledSaves: true,
	verbose: true
});

I am not sure I understand what exactly you are trying to do to begin with.   Are you including the loki nativescript driver which is separately included in the src directory?  Then instantiating it and passing into loki constructor?  I see you (or want to) instatiate loki with a partitioning adapter but I cant see what adapter you passed into its constructor.
For normal nativescript adapter I would expect you would do something like this :
const loki = require ('lokijs');
const LokiNativescriptAdapter = require('lokijs/src/loki-nativescript-adapter');
let db = new loki('loki.json',{
            adapter:new LokiNativescriptAdapter()
});

For partitioning with nativescript I would expect you would do something like this :
const loki = require ('lokijs');
const LokiNativescriptAdapter = require('lokijs/src/loki-nativescript-adapter');
const pa = new loki.LokiPartitioningAdapter(new LokiNativescriptAdapter());
let db = new loki('loki.json',{
            adapter: pa
});

I'm doing exactly what you described in the second case:
const Loki = require ('lokijs');
var LokiNativeScriptAdapter = require("loki-nativescript-adapter");
var lokiNativeScriptAdapter = new LokiNativeScriptAdapter();
var partitioningAdapter = new Loki.LokiPartitioningAdapter( lokiNativeScriptAdapter, { paging: true, pageSize:5*1024*1024});

global.ldb = new Loki(path, {
	adapter: partitioningAdapter,
	env: "NATIVESCRIPT",
	throttledSaves: true,
	verbose: true
});

This works fine, if one prevents Loki from requiring the node fs module.
This ugly hack does the trick:
   function LokiFsAdapter() {
      //this.fs = require('fs');
    }

Obviously, this is not a real solution, so that's why I'm suggesting the approaches outlined above.
Note that part of second solution is already in the Loki sources, but commented out:
      var getENV = function () {
        // if (typeof global !== 'undefined' && (global.android || global.NSObject)) {
        //   //If no adapter is set use the default nativescript adapter
        //   if (!options.adapter) {
        //     var LokiNativescriptAdapter = require('./loki-nativescript-adapter');
        //     options.adapter=new LokiNativescriptAdapter();
        //   }
        //   return 'NATIVESCRIPT'; //nativescript

I think I get what is going on...  I made a few fixes which should resolve this issue.  Feel free to try out and let me know your results.
Our nativescript adapter is separate module and our feature detection was commented out because we can't require it and remain browserify compatible.  I am (now) letting the fallback be 'no persistence adapter'.
Separate from your problem, if you were running in NATIVESCRIPT or any other environment which is not properly environment detected, you could pass in 'MEMORY' to use our LokiMemoryAdapter.   If you never intend to call save or load, you can pass in any other string like 'NA' to bypass environment detection and leave the persistence adapter null.

I tested it, and it does fix the issue. There is a small error:
04-23 21:52:28.050  2242  2242 W System.err: TypeError: Cannot read property 'adapter' of undefined
04-23 21:52:28.050  2242  2242 W System.err: File: "file:///data/data/net.nexus0.lms.LMSlib2go/files/app/tns_modules/lokijs/src/lokijs.js, line: 674, column: 23
04-23 21:52:28.050  2242  2242 W System.err: StackTrace:
04-23 21:52:28.050  2242  2242 W System.err: Frame: function:'getENV', file:'file:///data/data/net.nexus0.lms.LMSlib2go/files/app/tns_modules/lokijs/src/lokijs.js', line: 674, column: 24

Solution:
      var getENV = function () {
        if (typeof global !== 'undefined' && (global.android || global.NSObject)) {
           // If no adapter is set use the default nativescript adapter
           if (options && !options.adapter) {
             //var LokiNativescriptAdapter = require('./loki-nativescript-adapter');
             //options.adapter=new LokiNativescriptAdapter();
           }
           return 'NATIVESCRIPT'; //nativescript
        }

After changing that, the issue should be solved. Thanks.


with ionic 4+ when app is closed the onIntent is callback is not triggered

When the app is running in the background everything is working as expected.
this.webIntent.onIntent().subscribe((intent: { extras: any; }) => {
     console.log('Received Intent: ' + JSON.stringify(intent.extras));
     alert('Received Intent: ' + JSON.stringify(intent.extras));
});

The above code is placed inside platform ready.
Not able to retrieve the extras when the app is closed

Hi, does subscribe register a broadcast receiver?  Although this plugin is listed as the implementation for webIntent I didn't actually write any of the code for the webIntent API.
Closing the app will cause Android to unregister any existing dynamic broadcast receivers so this is expected behaviour if I have correctly understood the question.

thanks for the quick response, I had not registered a brodcast receiver just using the package name to startActivity with extras. It works well when the app is in the background. Have not found a way to make it work when the app is closed.

Perhaps the subscription is getting cleared when you close the app? https://github.com/ionic-team/ionic-native/blob/master/src/%40ionic-native/plugins/web-intent/index.ts#L215

I was able to use getIntent when the app was closed. Sorry didnt notice that at first. Thanks for the help.


[overlay] Declaring MAP_FAILED

Clang importer is unable to handle ((void *)-1), therefore manually
declaring the said constant in both Darwin and Glibc modules.

Resolves rdar://problem/26689135

@swift-ci Please smoke test

@DougGregor can you take a look please?

LGTM!


allow unfollow / unblock of abandoned or blocked content

[ ] if you've blocked channels that have been DMCA's, you can't remove them since the follow button is hidden and they are hidden from the block list

[ ] if you've blocked channels that have been removed, you can't unblock from since they don't resolve

Has this been started in the branch https://github.com/lbryio/lbry-desktop/tree/feat-channelAbandon?

@bitcoinbrisbane I believe that branch is to allow deletion of channels (and publishes) directly from their respective pages and is not related to the above issue. @jessopb please confirm or correct.

Ok, Ill take a look at this today.

Hi @bitcoinbrisbane, are you still working on this item?

Hi @bitcoinbrisbane, are you still working on this item?

Sorry :(

@bitcoinbrisbane no problem! It was just merged! 🙂


packaged clients

Post 0.2.0 let's try to get some more convenience packagings in place so that folks can use the package management system of their choice.

maven central
yum
apt
brew

anything else?

:+1:  for aur (arch user-contributed package repo)


Great project

To the moon

Awsome Project Awakening technology 🔥🔥🔥🔥
Love to have you in WALLET

What's so interesting on the Moon?All Doge-like chasers and the others copydogs over there. Let's get out of this solar system at least😀

Alright thank you so much
On Mon, 19 Jul 2021 11:07 am adamparol, @.***> wrote:

What's so interesting on the Moon?All Doge-like chasers and the others
copydogs over there. Let's get out of this solar system at least😀
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Aircoin-official/AirCash/issues/19#issuecomment-882421587,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUYD43W56QVELTAB2RDPBDDTYP2NXANCNFSM5AS2AUNA
.


Mismatch between article title and header

The header in the article shows "Platform-supported migration of IaaS resources from classic to Azure Resource Manager in Linux" which is misleading or incorrect. The title is: "Overview of platform-supported migration of IaaS resources from classic to Azure Resource Manager"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: abb30484-04e7-3ba3-2d5c-51b312ad5c69
Version Independent ID: f9a80b3f-ad3e-2985-dfbf-b69b6f614daa
Content: Overview of platform-supported migration of IaaS resources from classic to Azure Resource Manager - Azure Virtual Machines
Content Source: articles/virtual-machines/migration-classic-resource-manager-overview.md
Service: virtual-machines
Sub-service: classic-to-arm-migration
GitHub Login: @tanmaygore
Microsoft Alias: tagore

Thanks for brining this to our attention. We will investigate it further and update you shortly.

@sercast -  Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


feat(menu): add menu component

Summary
Type

Feature

Summarise concisely:

Migration of old component OptionsMenu & DropdownMenu to one component Menu

Some menus in storybook are slightly truncated on their left side. Maybe some extra margin left just so all the menu is visible.

Should we validate this with UI team? The sub menu looks a bit odd? (round corners, alignment, etc.)

Some menus in storybook are slightly truncated on their left side. Maybe some extra margin left just so all the menu is visible.
You right, it's fixed.

Should we validate this with UI team? The sub menu looks a bit odd? (round corners, alignment, etc.)
Iit's just a suggestion that shows we can make the submenu work properly. I didn't work on this part and i think if we have to use it we need to validate with ui-team at this time.

@philibea yeah I was more thinking do we want to integrate "Work in progress" things like the sub menu? Or should we just not show it for now and make it "public" once we have something really clean?

@philibea yeah I was more thinking do we want to integrate "Work in progress" things like the sub menu? Or should we just not show it for now and make it "public" once we have something really clean?

You right, I added a WIP in the title.


Question: which organizations are shown?

As you can see in the last/bottom screenshot I'm owner of the greenitglobe/environments organization...
Why can't I see this in the top organizations view, while I can see greenitglobe/environments/uk-g8-1? See first screenshot.
In order to access greenitglobe/environments I currently need to click through greenitglobe/environments and then use the breadcrumb navigation to get to the greenitglobe/environments; see second/middle screen shot
Is this by design? Why? Wouldn't it be better to see the top level organizations where I'm owner?

This is not intended, however it should be solved in issue #387, #388, and #390


esp-idf platform mDNS implementation fails at initialization

As of 27d3ea89f ("Make CHIP devices advertise as operational devices via mDNS (#4132)") we cannot use the esp-idf mDNS implementation.
This should be possible after 2c820d0f6 ("Add platform implementation for Advertiser (#4345)") but this is not working as there is an error at initialization:
E (677) chip[DL]: esp mdns internal error: ESP_ERR_INVALID_STATE
E (678) chip[DIS]: mDNS initialization failed with Error 4000172 (0x003D09AC)
E (681) chip[DIS]: Failed to initialize platform mdns: Error 4000172 (0x003D09AC)
I (690) spi_flash: detected chip: gd

Repro: Set chip_mdns_advertiser = "platform" and chip_enable_rotating_device_id = false for ESP32 build. Error shows at boot and the device cannot be discovered.

Ack, will investigate.


[flutter] replace 'checked mode' with 'debug mode'

This was renamed many years ago....

test-exempt: only affects comments
that said, it might be good to add a test that checks for the string "checked mode" in any file in flutter/flutter or flutter/engine and flags said usages.

I think it depends on the context, since for the CLI --checked / checked mode because --enable-asserts but it is still referred to as checked mode in the dart API docs. We could definitely run a test at least for dart:ui and the flutter packages.

I added an analyze.dart check for the phrase "checked mode" in flutter/packages.


Bluetooth: provide struct bt_gatt_indicate_params to bt_gatt_indicate_func_t

Is your enhancement proposal related to a problem? Please describe.
As noted by the function documentation, bt_gatt_indicate is an asynchronous function, and therefore the struct bt_gatt_indicate_params provided to it must valid while it is active. The required lifetime of the struct bt_gatt_indicate_params is presumably until the member function bt_gatt_indicate_func_t is called (this is not specified). Currently, it is not possible to determine from the callback which struct bt_gatt_indicate_params is now available to be reused.
This is an issue when multiple indications need to be queued, with the structs allocated from some kernel mechanism (k_mem_slab or other), as there is no way to free the instances once they are no longer needed.
Describe the solution you'd like
const struct bt_gatt_attr *attr parameter to bt_gatt_indicate_func_t changed to struct bt_gatt_indicate_params *params.
The attr element is still accessible from the *params, but the params instance can also be freed in the callback.
Describe alternatives you've considered
None, there is no user data parameter or similar to retrieve the struct bt_gatt_indicate_params pointer from the completing indication.

Superseded by #29357


Implement code actions

This allows the user to remove unused anchors using quick actions.

I’m merging this, because I want to create a new release.


build currently broken -- CI always uses the feature fuel-core-lib

If we run cargo build --no-default-features we'll get:
error[E0425]: cannot find function `is_free` in this scope
   --> packages/fuels-test-helpers/src/lib.rs:192:52
    |
192 |         Some(config) if config.addr.port() != 0 && is_free(config.addr.port()) => config.addr,
    |                                                    ^^^^^^^ not found in this scope
    |
help: consider importing this function
    |
3   | use portpicker::is_free;
    |

error[E0425]: cannot find function `is_free` in this scope
   --> packages/fuels-test-helpers/src/lib.rs:193:26
    |
193 |         Some(config) if !is_free(config.addr.port()) => panic!("Error: Address already in use"),
    |                          ^^^^^^^ not found in this scope
    |
help: consider importing this function
    |
3   | use portpicker::is_free;
    |

For more information about this error, try `rustc --explain E0425`.
error: could not compile `fuels-test-helpers` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...

It seems that our CI always runs fuels-rs with --all-features which renders some of the code disabled due to the conditional compilation based on the flag 'fuel-core-lib`. As such we have parts of our code that are basically unchecked by the CI.
Fix the CI and make the build pass.
Ideally, we'd have a test run with fuel-core as a lib and another one with it as a binary, for maximum regression protection.

Ideally, we'd have a test run with fuel-core as a lib and another one with it as a binary, for maximum regression protection.

Yes, my only concern here is that the CI time could increase significantly 🤔
As for the issues w.r.t feature flag, I'm pinging the fuel-core-lib flag creator @Salka1988.

Perhaps  @Salka1988 can measure the impact? At the very least we need a cargo check without the feature to keep it buildable.


patch: removed unneeded exports

:tada: This PR is included in version 11.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Install failed on macos x64 using clang

When I install the nodejs on my mac os, it failed with this output:
npm ERR! code 1
npm ERR! path /usr/local/lib/node_modules/pulsar-client
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! CC(target) Release/obj.target/nothing/node_modules/node-addon-api/nothing.o
npm ERR!   LIBTOOL-STATIC Release/nothing.a
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/addon.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Message.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/MessageId.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Authentication.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Client.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/SchemaInfo.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Producer.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/ProducerConfig.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Consumer.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/ConsumerConfig.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/Reader.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/ReaderConfig.o
npm ERR!   CXX(target) Release/obj.target/Pulsar/src/ThreadSafeDeferred.o
npm ERR!   SOLINK_MODULE(target) Release/Pulsar.node
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using<EMAIL_ADDRESS>npm ERR! gyp info using<EMAIL_ADDRESS>| darwin | x64
npm ERR! gyp info find Python using Python version 3.10.8 found at "/Library/Frameworks/Python.framework/Versions/3.10/bin/python3"
npm ERR! gyp info spawn /Library/Frameworks/Python.framework/Versions/3.10/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args   'binding.gyp',
npm ERR! gyp info spawn args   '-f',
npm ERR! gyp info spawn args   'make',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/pulsar-client/build/config.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args   '-I',
npm ERR! gyp info spawn args   '/Users/aaronrobert/Library/Caches/node-gyp/16.16.0/include/node/common.gypi',
npm ERR! gyp info spawn args   '-Dlibrary=shared_library',
npm ERR! gyp info spawn args   '-Dvisibility=default',
npm ERR! gyp info spawn args   '-Dnode_root_dir=/Users/aaronrobert/Library/Caches/node-gyp/16.16.0',
npm ERR! gyp info spawn args   '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
npm ERR! gyp info spawn args   '-Dnode_lib_file=/Users/aaronrobert/Library/Caches/node-gyp/16.16.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args   '-Dmodule_root_dir=/usr/local/lib/node_modules/pulsar-client',
npm ERR! gyp info spawn args   '-Dnode_engine=v8',
npm ERR! gyp info spawn args   '--depth=.',
npm ERR! gyp info spawn args   '--no-parallel',
npm ERR! gyp info spawn args   '--generator-output',
npm ERR! gyp info spawn args   'build',
npm ERR! gyp info spawn args   '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! gyp info spawn make
npm ERR! gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
npm ERR! warning: /Library/Developer/CommandLineTools/usr/bin/libtool: archive library: Release/nothing.a the table of contents is empty (no object file members in the library define global symbols)
npm ERR! In file included from ../src/addon.cc:23:
npm ERR! In file included from ../src/Producer.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! In file included from ../src/Client.cc:21:
npm ERR! In file included from ../src/Client.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! In file included from ../src/Producer.cc:20:
npm ERR! In file included from ../src/Producer.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! In file included from ../src/Consumer.cc:20:
npm ERR! In file included from ../src/Consumer.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! In file included from ../src/ConsumerConfig.cc:21:
npm ERR! In file included from ../src/Consumer.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! In file included from ../src/Reader.cc:21:
npm ERR! In file included from ../src/Reader.h:24:
npm ERR! In file included from /usr/local/include/pulsar/c/client.h:22:
npm ERR! /usr/local/include/pulsar/c/client_configuration.h:168:15: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers]
npm ERR! PULSAR_PUBLIC const unsigned int pulsar_client_configuration_get_stats_interval_in_seconds(
npm ERR!               ^~~~~~
npm ERR! 1 warning generated.
npm ERR! clang: error: no such file or directory: '/lib/libpulsar.dylib'
npm ERR! make: *** [Release/Pulsar.node] Error 1
npm ERR! gyp ERR! build error
npm ERR! gyp ERR! stack Error: `make` failed with exit code: 2
npm ERR! gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:203:23)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:527:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)
npm ERR! gyp ERR! System Darwin 21.6.0
npm ERR! gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /usr/local/lib/node_modules/pulsar-client
npm ERR! gyp ERR! node -v v16.16.0
npm ERR! gyp ERR! node-gyp -v v9.3.0
npm ERR! gyp ERR! not ok

npm ERR!      /Users/aaronrobert/.npm/_logs/2022-12-02T09_26_18_539Z-debug-0.log

I think it should be the problem with the current compilation is not compatible with clang. But we need to fix it or provide some documentation for it.

@RobertIndie Currently you can't install the client based on the README of the master branch, because we haven't released the latest version yet.

https://github.com/apache/pulsar-client-node/pull/239#pullrequestreview-1169426379 This PR merger is early.

Is it not currently possible to install pulsar-client? I followed the instructions here to that says to install brew install libpulsar and then I get the same error above when I try to install pulsar-client@latest (which is currently 1.7.0.

Closed. This should be resolved on master. Cannot reproduce.

We could close this issue as 1.8.0 is already released.


Fixed documentation typos

Please remember the Contributing Guidelines :heart:
:star2: What does this PR do?

:bug: Recommendations for testing
All changes should be tested across Chrome and Firefox.

:memo: Links to relevant issues or information

enhanced code readability

Hey, @zalaksola! Thank you for your submission, but we think this would actually make UX a little worse. "Continue latest" is more descriptive of what that button does than "Resume", because it'll start your latest entry regardless of when you stopped it.
If you'd still like to contribute, you can try one of these issues: https://github.com/toggl/toggl-button/issues?q=is%3Aopen+is%3Aissue+label%3Ahacktoberfest+no%3Aassignee
Have a fun Hacktoberfest! :)


Update bastion-faq.md

updated from icm investigation.

#please-close Created in the wrong repo accidentally.


[GIT PULL] Several small man fixes

Several small man fixes:

fix grammar in io_uring_prep_recv.3 and io_uring_prep_recvmsg.3
fix function signature in io_uring_buf_ring_add.3
fix references in io_uring_register_buf_ring.3

git request-pull output:
The following changes since commit e5bb0e647ae8e51e6da7d1673420c2faf822c932:

  man/io_uring_setup.2: add not on SQPOLL and privileges (2022-12-24 07:38:17 -0700)

are available in the Git repository at:

  https://github.com/wlukowicz/liburing man-fixes

for you to fetch changes up to 071793cd1f837daced99227362488524f6a04e16:

  man/io_uring_register_buf_ring.3: fix references (2022-12-26 17:06:50 +0000)

----------------------------------------------------------------
Wojciech Lukowicz (3):
      man: fix grammar
      man/io_uring_buf_ring_add.3: fix function signature
      man/io_uring_register_buf_ring.3: fix references

 man/io_uring_buf_ring_add.3      | 12 ++++++------
 man/io_uring_prep_recv.3         |  2 +-
 man/io_uring_prep_recvmsg.3      |  2 +-
 man/io_uring_register_buf_ring.3 |  2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

Click to show/hide pull request guidelines
Pull Request Guidelines

To make everyone easily filter pull request from the email
notification, use [GIT PULL] as a prefix in your PR title.

[GIT PULL] Your Pull Request Title

Follow the commit message format rules below.
Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

The first line is title (don't be more than 72 chars if possible).
Then an empty line.
Then a description (may be omitted for truly trivial changes).
Then an empty line again (if it has a description).
Then a Signed-off-by tag with your real name and email. For example:

Signed-off-by: Foo Bar<EMAIL_ADDRESS>
The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).
Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.
Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.
If the commit is a fix for an issue, add a Fixes tag with the issue
URL.
Don't use GitHub anonymous email like this as the commit author:
<EMAIL_ADDRESS>
Use a real email address!
Commit message example:
src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe<EMAIL_ADDRESS>

By submitting this pull request, I acknowledge that:

I have followed the above pull request guidelines.
I have the rights to submit this work under the same license.
I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

Thanks!


[Search] Refactor indexing process to use streams

🌊  What / Why
Search indexing is very inefficient, currently.  Each part of the process expects that the entire contents of an index is available in memory at once.  The proposal here is to alleviate this by reimagining each component of the search indexing process as a stream:

Collator is just a Readable stream of IndexableDocument objects.
Decorator is just a Transform stream operating on the same objects
SearchEngine::index() is just a Writable stream, accepting the documents.

Which are then composed into a stream pipeline in the IndexBuilder, something like this:
import { pipeline } from 'stream';
pipeline([collator, ...decorators, indexer], callback);

A cool benefit of this is that we open ourselves up to a world of stream-based sources for indexing.  A use-case we have internally is indexing gigabyte-sized newline-delimited JSON files in cloud storage, which could now be accomplished by reading such files in as streams.
Supporting Changes
Streams can be difficult and unintuitive to implement.  These additions/modifications were made to improve developer experience for plugin developers (new and existing):

Collators: For existing collators, they are largely the same, except the execute methods have been modified to return AsyncGenerator<IndexableDocument>;  those generators are then converted into readable streams via Readable.from(collator.execute()).
Indexers: A BatchSearchEngineIndexer base class has been introduced into @backstage/search-backend-node to simplify writable stream implementations for search engines.  The batch size is configurable and there are convenience hooks for async initialization and teardown.  Backpressure is handled by respecting the promise returned by the main index method.
Decorators: A DecoratorBase base class has been introduced to simplify transform stream implementations. Similar to the batch indexer, there are convenience hooks for async initialization and teardown.  It supports document modification, filtration, and fanning.  Backpressure is handled by respecting the promise returned by the main decorate method.

Backwards Compatibility
Given the search platform is still in alpha, I've decided to implement all changes as breaking.  TechDocs and Catalog are considerably more mature, at this point, so I've opted to make the changes to these plugins backward compatible.  Thus:

Adopters can upgrade (and continue to upgrade for a time) their TechDocs and/or Catalog backends without having to upgrade search.
If an adopter chooses to upgrade their search backend implementation, they will also have to upgrade TechDocs and Catalog backends.

How to review
Recommend going commit-by-commit.

Closes #6734
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] All your commits have a Signed-off-by line in the message. (more info)

Over to you @backstage/maintainers


beforeDetach hook

I am now trying to write a list view component for Vue.
And I had a problem saving state of current items before detach.
I want to collect boundingClientRect of all list items on beforeDetach, so that I can restore the ListView when re-attach .
So, I wonder, if there is a way to exec certain code right before detach, or is there any plan for it?

Currently no, but it is easy to add. For now you can use a transition's leave hook...

Thanks a lot.

+1

If I may ask, what is a list view component @zenozeng ?
Scott

See https://github.com/CatchLabs/vue-list-view
On Thu, Mar 24, 2016 at 12:34 PM, Scott<EMAIL_ADDRESS>wrote:

If I may ask, what is a list view component @zenozeng
https://github.com/zenozeng ?
Scott
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/vuejs/vue/issues/1469#issuecomment-200660146

Thanks @zenozeng.
Scott

Dropping this because in most cases you can do this before you manipulate the data instead.
For items with transitions, do it in the beforeLeave hook.
Also in 2.0, attach/detach hooks are being deprecated. If a component is being removed then it is being destroyed.


Convert repository names to lowercase before referring to them as docker names.

References

Description
In PR (#187 ), we converted the repository names to lowercase before using them. However, there are still two actions using the unconverted repository names. This PR fixes the problem.
Validation performed

Commit msg: Convert repository names to lowercase before using them in docker image names. (#273)?

LGTM


Support scripts in Invoke-TaskFromISE.ps1

I'm following the Invoke Task from ISE instructions. Does it require that I install Invoke-Build as a module? I'm trying to use the script form of Invoke-Build (scripts in .\Invoke-Build\ folder):
$null = $psISE.CurrentPowerShellTab.AddOnsMenu.Submenus.Add(
    'Invoke Task in ISE', {Invoke-Build\Invoke-TaskFromISE.ps1}, 'Ctrl+F5')

And I get:

The module 'Invoke-Build' could not be loaded.

A suggestion would be for it to support both module and script forms of Invoke-Build.
Much thanks!

Does it require that I install Invoke-Build as a module?

No. Your syntax makes PS think it is a command from a module.
Replace Invoke-Build\Invoke-TaskFromISE.ps1 with the full path or put Invoke-TaskFromISE.ps1 somewhere in the path and use just its name (like in the instructions).

Thanks. I now see that Invoke-TaskFromISE.ps1 isn't downloaded with the scripts, so this won't work even with correct syntax.


[Potential Bug] Summary remaining count

When being redirected to summary after finishing final review item, the item count was still at 1.
Could be due to requesting user/me for a count update at almost the same time as posting the final review as correct.
Race condition not allowing server enough time to update count?
Or could just be an incorrect remaining count calculation.
Requires further monitoring.

Possibly related: when exiting quiz early and navigating to summary, we clear the current item (but it is not returned to the queue!).


Issue #2203 - Reconnection

PR is still not complete, but good to get comments.
Missing parts:-

reconnection during cachemanager lifecycle
of course more tests

test this please

Depends on https://github.com/Terracotta-OSS/terracotta-core/pull/846

Its complete


Error determining version of yarn dependency with "+git" in version

Saw this today running osv-scanner indirectly through Scorecard.
Failed to determine version of domino while parsing a yarn.lock - please report this!

The offending line is here, which was added recently here
"domino@https://github.com/angular/domino.git#f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a":
  version "2.1.6+git"
  uid f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a
  resolved "https://github.com/angular/domino.git#f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a"

I see the + symbol is used for build info in npm semver, but I have no idea if this is a valid yarn.lock file (similar to #142 )  with any version of yarn.
Not a yarn user, tried a few things and got different (valid) lockfiles. Not sure what Angular did to get theirs. Running yarn add<EMAIL_ADDRESS>yields:
<EMAIL_ADDRESS>  version "2.1.6"
  resolved "https://registry.yarnpkg.com/domino/-/domino-2.1.6.tgz#fe4ace4310526e5e7b9d12c7de01b7f485a57ffe"
  integrity sha512-3VdM/SXBZX2omc9JF9nOPCtDaYQ67BGp5CoLpIQlO2KCAPETs8TcDHacF26jXadGbvUteZzRTeos2fhID5+ucQ==

And yarn add https://github.com/angular/domino.git#f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a proudces:
"@angular/domino@https://github.com/angular/domino.git#f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a":
  version "2.1.6"
  resolved "https://github.com/angular/domino.git#f2435fe1f9f7c91ade0bd472c4723e5eacd7d19a"

@G-Rath Can you take a look? Thanks!

That is the actual version of the package: https://github.com/angular/domino/blob/main/package.json#L3
It's a valid semantic version but Yarn v1 strips out build metadata - Yarn Berry and NPM v7+ however don't

It shouldn't because build metadata is meant to be ignored when comparing versions


Tessa Water Quality Assignment

Overall nice job Tessa, some of the early questions, I didn't see you interpret your results, but the code was clean and the analyses you conducted at the end had the correct interpretation.


Add someone to GitHub

Please include:

GitHub ID to add: @celder628

Lab to be added to: https://github.com/hyperledger-labs/fabric-ansible-collection

Role:

Admin (& maintainer)

GitHub ID to add: @MuthuSundaravadivel

Lab to be added to: https://github.com/hyperledger-labs/fabric-ansible-collection

Role:

Admin (& maintainer)

@modemn invites sent!


PuppetPuppeteerFier fireRoomJoin() resolve payload fail

Whenever someone invite someone into the group, I'll get the following warning output by Puppeteer:
20:11:17 WARN PuppetPuppeteerFier fireRoomJoin() resolve payload fail.
20:11:17 WARN PuppetPuppeteerEvent checkRoomSystem message: <"XXX"邀请"YYY"加入了群聊> not found

It seems you are using a very old version of wechaty-puppet-padchat because I can not find your log messages in the latest code.
Could you please tell me what's the Wechaty version you are using, and try with the latest code to see if there still has this problem?

Sorry, I was using WECHATY_PUPPET=puppeteer
22:06:49 INFO Wechaty start() v0.17.117 is starting...
22:06:49 INFO Wechaty initPuppet() using puppet: puppeteer

OK. I'll try the latest.

If you are using puppeteer, then this issue might be duplicated with #588

Ah, true

Hmm... maybe there is another cause:
23:50:49 WARN PuppetPuppeteerFier fireRoomJoin() resolve payload fail.
23:50:49 WARN PuppetPuppeteerEvent checkRoomSystem message: <"Sensei"邀请"林 昊坤"加入了群聊> not found

Agreed.
We need more information with WECHATY_LOG=silly.

enabled. Finger-crossed.

Caught one,  after just logging in on second attempt (was trying to give up as I haven't caught anything for a day, but decided to give it another try). Anyway:
22:12:51 INFO Messenger: Contact<me> login
22:13:03 SILL Wechaty memoryCheck() free: 701 MB, require: 4 MB
22:13:03 VERB Wechaty start() throttleQueue.subscribe() new item: [object Object]
22:13:03 VERB MemoryCard <puppeteer> set(PUPPET_PUPPETEER, [object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object])
22:13:03 VERB MemoryCard <puppeteer> save() file: /path/to/default.memory-card.json
22:13:03 VERB MemoryCard <> save() file: /path/to/default.memory-card.json
22:13:18 SILL Wechaty memoryCheck() free: 701 MB, require: 4 MB
22:13:33 SILL Wechaty memoryCheck() free: 701 MB, require: 4 MB
22:13:34 VERB PuppetPuppeteerFirer parseRoomJoin("Melody"邀请"louis"加入了群聊)
22:13:34 SILL PuppetPuppeteerFirer checkRoomJoin() inviteeList: louis, inviter: Melody
22:13:34 SILL PuppetPuppeteerFirer fireRoomJoin() retry() ttl 59
22:13:34 VERB Puppet roomMemberSearch(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, "louis")
22:13:34 VERB Puppet roomMemberSearch(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, {"roomAlias":"louis"})
22:13:34 VERB PuppetPuppeteer roommemberList(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
22:13:34 VERB PuppetPuppeteer roomRawPayload(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
22:13:34 SILL PuppetPuppeteerBridge getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry attempt 1
22:13:34 SILL PuppetPuppeteerBridge proxyWechaty(getContact, @@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
22:13:34 VERB PuppetPuppeteerFirer parseRoomJoin("louis"与群里其他人都不是微信朋友关系，请注意隐私安全)
22:13:34 SILL PuppetPuppeteerFirer checkRoomJoin() ""louis"与群里其他人都不是微信朋友关系，请注意隐私安全" is not a join message
22:13:34 VERB PuppetPuppeteerFirer fireRoomLeave("louis"与群里其他人都不是微信朋友关系，请注意隐私安全)
22:13:34 SILL PuppetPuppeteerFirer fireRoomLeave() no match
/home/u/wechaty1.log:22:13:34 WARN PuppetPuppeteerEvent checkRoomSystem message: <"louis"与群里其他人都不是微信朋友关系，请注意隐私安全> not found

I noticed that checkRoomJoin() has already found everything:
22:13:34 SILL PuppetPuppeteerFirer checkRoomJoin() inviteeList: louis, inviter: Melody

So I don't know what else checkRoomSystem is trying to find...

So I guess the two warnings in my OP, although seems to be showing up together always, have their difference causes. For e.g., this time I only caught checkRoomSystem warning, not fireRoomJoin() resolve payload fail.
Will continue watching.

22:13:34 WARN PuppetPuppeteerEvent checkRoomSystem message: <"louis"与群里其他人都不是微信朋友关系，请注意隐私安全> not found

This message is ok and you can treat it as neither an error nor a warning, you can be safe to ignore it.
This message displayed here is only because @lijiarui insisted to add it to her PR (and she even want to throw an Error over the top, which I can not agree), she might like to explain why she wants to show you this message.

Found some fireRoomJoin() resolve payload fail cases. Folded up to protect PPA data from the innocent eyes.

Debug Logs

Full output logs here with WECHATY_LOG=silly set
## Case #1

23:07:05 VERB Puppet roomMemberSearch(@@013f4fab7068f77094a867dd174b27f42acd9
1fc969547cc9db5154e44d26fc2, {"contactAlias":"Mary Guan  伦敦理财"})
23:07:05 VERB PuppetPuppeteer roommemberList(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
23:07:05 VERB PuppetPuppeteer roomRawPayload(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
23:07:05 SILL PuppetPuppeteerBridge getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry attempt 1
23:07:05 SILL PuppetPuppeteerBridge proxyWechaty(getContact, @@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
23:07:05 SILL PuppetPuppeteer roomPayload() this.bridge.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) MemberList.length:(prev:0, curr:319) at ttl:6
23:07:05 SILL PuppetPuppeteer roomPayload() puppet.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry at ttl:6
23:07:06 SILL PuppetPuppeteerBridge getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry attempt 1
23:07:06 SILL PuppetPuppeteerBridge proxyWechaty(getContact, @@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
23:07:06 SILL PuppetPuppeteer roomPayload() this.bridge.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) MemberList.length:(prev:319, curr:319) at ttl:5
23:07:06 SILL PuppetPuppeteer roomPayload() puppet.getContact(@857611455f2c8f
a958b13eb97882a3013d8bb382c86e3e875261d5eebd98fee0) done at ttl:5 with length:319
23:07:06 VERB Puppet contactSearch(query={"alias":"Mary Guan  伦敦理财"}, idList.length = 319)
23:07:06 SILL Puppet contactSearch() searchIdList.length = 319
23:07:06 VERB Puppet contactQueryFilterFactory({"alias":"Mary Guan  伦敦理财"})
23:07:06 SILL Puppet contactSearch() searchContactPayloadList.length = 0
23:07:06 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, contactId=@9f673b0e2eed298af1b7b6b69059b0d6ac80ad359d66526e8dff1964de55bda6)

 ... skipping loads of the roomMemberPayloads (IMHO, this should not be in the debug output unless expressively requested) ...

23:07:06 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b2
7f42acd91fc969547cc9db5154e44d26fc2, contactId=@e10e30536e2dd036b7bf694dd7f68
731ff44800141e171e4926ba62697e513e0)
23:07:06 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b2
7f42acd91fc969547cc9db5154e44d26fc2, contactId=@c459c1baad08142db863023eece61
68256995631a894782e326f41a0034d3301)
23:07:06 WARN PuppetPuppeteerFier fireRoomJoin() resolve payload fail.
23:07:06 VERB PuppetPuppeteerFirer fireRoomLeave("NK 刘旭伟法律留学4163589377"邀请"Mary Guan  伦敦理财"加入了群聊)
23:07:06 SILL PuppetPuppeteerFirer fireRoomLeave() no match
23:07:06 WARN PuppetPuppeteerEvent checkRoomSystem message: <"NK 刘旭伟法律留学4163589377"邀请"Mary Guan  伦敦理财"加入了群聊> not found
23:07:06 VERB Message static create(4904610157633791086)
23:07:06 SILL Accessory #2984<Message> constructor()
23:07:06 VERB Message constructor(4904610157633791086) for class Message
23:07:06 VERB Message ready()

## Case #2

01:15:15 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, contactId=@81beed378a44396dd79acf5b99290dfdf11aa3e0c9777113df56421712d5ca17)
01:15:15 VERB Puppet roomMemberSearch(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, {"contactAlias":"快乐燕子"})
01:15:15 VERB PuppetPuppeteer roommemberList(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
01:15:15 VERB PuppetPuppeteer roomRawPayload(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
01:15:15 SILL PuppetPuppeteerBridge getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry attempt 1
01:15:15 SILL PuppetPuppeteerBridge proxyWechaty(getContact, @@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
01:15:16 SILL PuppetPuppeteer roomPayload() this.bridge.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) MemberList.length:(prev:0, curr:325) at ttl:6
01:15:16 SILL PuppetPuppeteer roomPayload() puppet.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry at ttl:6
01:15:17 SILL PuppetPuppeteerBridge getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) retry attempt 1
01:15:17 SILL PuppetPuppeteerBridge proxyWechaty(getContact, @@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2)
01:15:17 SILL PuppetPuppeteer roomPayload() this.bridge.getContact(@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2) MemberList.length:(prev:325, curr:325) at ttl:5
01:15:17 SILL PuppetPuppeteer roomPayload() puppet.getContact(@857611455f2c8fa958b13eb97882a3013d8bb382c86e3e875261d5eebd98fee0) done at ttl:5 with length:325
01:15:17 VERB Puppet contactSearch(query={"alias":"快乐燕子"}, idList.length = 325)
01:15:17 SILL Puppet contactSearch() searchIdList.length = 325
01:15:17 VERB Puppet contactQueryFilterFactory({"alias":"快乐燕子"})
01:15:17 SILL Puppet contactSearch() searchContactPayloadList.length = 0
01:15:17 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, contactId=@9f673b0e2eed298af1b7b6b69059b0d6ac80ad359d66526e8dff1964de55bda6)

 ... skipping loads of the roomMemberPayloads (IMHO, this should not be in the debug output unless expressively requested) ...

01:15:17 VERB Puppet roomMemberPayload(roomId=@@013f4fab7068f77094a867dd174b27f42acd91fc969547cc9db5154e44d26fc2, contactId=@81beed378a44396dd79acf5b99290dfdf11aa3e0c9777113df56421712d5ca17)
01:15:17 WARN PuppetPuppeteerFier fireRoomJoin() resolve payload fail.
01:15:17 VERB PuppetPuppeteerFirer fireRoomLeave("快乐燕子"邀请"李菊"加入了群聊)
01:15:17 SILL PuppetPuppeteerFirer fireRoomLeave() no match
01:15:17 WARN PuppetPuppeteerEvent checkRoomSystem message: <"快乐燕子"邀请"
李菊"加入了群聊> not found
01:15:17 VERB Message static create(6271236879510998245)
01:15:17 SILL Accessory #3169<Message> constructor()
01:15:17 VERB Message constructor(6271236879510998245) for class Message
01:15:17 VERB Message ready()
. . .

Thanks for the log in details!
I believe this is an old bug that related to the emoji strip function in PuppetPuppeteer.
From the beginning, we try to strip all the emoji XML from the contact name, but at the same time, we are trying to search a contact with the name that did not strip the emoji XML(like what we did in your logs).
The potential two solutions would be:

remove all the emoji XML, including all the search methods;
do not remove the emoji XML, keep its original text.

Currently, I'd like to use the solution 2, which keeps the emoji XML.
Please feel free to let me know what you thought if you have some, thanks.

I don't have a preference but believe what your choice make sense.
However, I do want to point out that in case 2, 邀请"李菊"加入了群聊, there is no emoji. I especially find a case to put it there. So be careful to fix all causes.

Move to https://github.com/Chatie/wechaty-puppet-puppeteer/issues/35


Is it possible to add an 'around' interface to the Interceptor top-level interface. Similar to the @Around annotation in AOP

What would you like to be added?
Is it possible to add an around interface to the Interceptor top-level interface. Similar to the @Around annotation in AOP.
Similar to the following:
   @Around("point()")
    public Object test(ProceedingJoinPoint joinPoint) throws Throwable {
         // pre-enhancement
         ............

         //Execute pointcut
         Object result = joinPoint.proceed(args);
         // post-enhancement
        .....................
        return result;

Why is this needed?
Because some functions may need to run before and after the entry point. Although you can use Context to pass parameters between contexts, it is cumbersome to use and writing code is not smooth enough.

In our design, we use @Advice.OnMethodEnter and @Advice.OnMethodExit to achieve the @around effect, which is done by the interface encapsulated by bytebuddy. Another point is that it is common to enhance the same method multiple times or mount multiple Sermants. We also need to manage the execution order of the before method and after method that are enhanced multiple times. So this issue is not suitable for current situation.

Did you solve it ???

没有解决，看了下代码不太好改动。目前是用serment提供的上下文接口进行的参数传递。
在before里面
context.setLocalFieldValue("xxx", xxx);
在after
context.getLocalFieldValue("xxx");

Other solutions have been provided. No other questions are replied. Therefore, this issue is closed.


Automated tests required!

We have a significant number of command line parameters, path resolver behaviour, background types & sources, and models that can all vary - manually checking is now time consuming & error prone - time to automate please!

Given we already have cmake in place this somewhat calls for CTest …


Make Style/RedundantArgument aware of Array#sum

This PR makes Style/RedundantArgument aware of Array#sum.
For example, by omitting the initial value argument of sum it could be simply updated by Style/SymbolProc.
# Before
items.sum(0) { |item| item.price }

# After
items.sum(&:price)

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice!


Format Object/Attributes Into JSON

Format the objects and their attributes into a JSON format.
Time estimate: 1D
Check story #11 for more details/context.

Bryce completed and test this.


Remove TODO that is not going to happen

This TODO I think was done already.

Should we be removing the replace directive and depending on a released thing if this is done?

/lgtm
/approve

/remove apporve

I had to dig through the past
https://github.com/aws/eks-anywhere/blob/v0.5.0/go.mod#L39:40

Yeh, we aren't going to used the versioned module and if we have to, we can address that at that time, no need for a TODO. I generally don't like TODOs, they should be issues if they are issues.

/approve


aur-repo-filter: add --sysroot

Recent versions of pacinfo have an easy to parse, line-by-line format. Use this to implement pacutils-sysroot(7).
Issue #490

Just compared to master branch and as I suspected, it's broken.

https://github.com/andrewgregory/pacutils/issues/26

Superseded by #549, I'll leave out --sysroot for now.


Adding testcase for Podman Pull Images

Can you squash your PR's and then I can merge.

Hello Dan, I have squashed the PR. Thanks

@ nehajain1809 PTAL

@ renuHadke PTAL

/lgtm


Tracking issues of integration unftp-sbe

https://github.com/apache/opendal/pull/4765 has added most features around unftp-sbe, this issue is used to track the remaining issues.
Tasks

[ ] Add README for this project
[ ] Add basic example for this project

cc @George-Miao, would you like to take a look?

Sure. I'll add the README and examples.

Sure. I'll add the README and examples.

Thanks a lot!

How should the CI part be done? @Xuanwo

How should the CI part be done? @Xuanwo

We can setup some basic CI first like clippy and tests

All tasks have been done. Should we close the issue?

Hi, do you think it's a good idea to add some tests for ubftp-sbe integration? I feel like we can at least test it with fs, s3, gcs and azblob.
You can finish the tests part and I'm willing to get it ready in our workflow.

I'm happy that unftp upstream is gooding to use this integration directly: https://github.com/bolcom/unFTP/issues/183
Before we start the work at upstream side, how about finishing the test work first? I want to avoid the unexpected issues at upstream.

Current docs for unftp-sbe-opendal doesn't look good

Would you like to track it in a new issue or in this tracking issue?


convert from argb to grayscale

asciimg/src/io/korhner/asciimg/image/matrix/GrayscaleMatrix.java
The blue sample extracted from rgb color seems incorrect.
Shouldn't it be "blue = color & 0xFF" instead of "blue = (color >> 8) & 0xFF"?

Hey, sorry for that late response, I missed this comment somehow. Nice catch, I will fix it in few days or you can send a patch as a pull request if you want. Cheers

Thanks for your response. I filed a pull request. In addition to fix the formula above, I also removed an unchecked exception and delete several unused variables.

Merged. Thanks!


impl(pubsub): add universe domain support to the publisher stub

Part of https://github.com/googleapis/google-cloud-cpp/issues/13293

This change is

I think we just want the corresponding service endpoint to work. Updated it for the publisher service.

I think we should close this. pubsub has UniverseDomainOption support as of: #13334

I see... so we're making it a common option instead?

I see... so we're making it a common option instead?

I am not sure what you mean. We are defaulting the EndpointOption to incorporate the UniverseDomainOption in a common place (PopulateCommonOptions), which pubsub already uses.


Maui conversion

Convert QuickStart from Xamarin Forms to Maui.
The conversion from multiple projects into a single project will be a separate PR.

Note: Won't actually complete this until we've released the Mobile SDK  publicly (for 5.34)


Adding ARM64 intrinsics support

Playing with the lib on the new Apple macbook air with M1, I found out that the performance of the native version is slower than the emulation of the x86_64 version.
After a bit of investigation, the performance difference come from the arm version not using  intrinsics. A small modification of the cmake header detection script and clang.h/gcc.h files to import arm_neon.h instead of x86intrinsics.h when compiling on arm64, greatly improved the performances, see table. The performance boost should translate to others arm platforms. All tests are OK but I'm not able to check if everything works fine on windows or Android, so I didn't make a pull request.
CKKS performance test, degree 8192, on macbook air M1 8Go, timings in microseconds.

native arm w/o intrinsics
native arm with intrinsics

encode
683
441

decode
1309
900

encrypt
4356
2551

decrypt
245
112

add
38
37

multiply
808
280

multiply plain
368
106

square
597
203

relinearize
4253
1931

rescale
1014
474

rotate 1 step
4279
1972

rotate rd
17199
7821

Thanks for sharing this! This could be really valuable to get into SEAL, obviously. Could you submit the pull request to the contrib branch and we can help evaluate that it's all good to go.

Thanks for sharing this! This could be really valuable to get into SEAL, obviously. Could you submit the pull request to the contrib branch and we can help evaluate that it's all good to go.

Thanks for your contribution! This is now released. :)


Change Created by in Neaby export

We should probably change the Created by at
app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java
Also maybe change creator= at https://github.com/commons-app/apps-android-commons/blob/main/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.java#L492 unless that one is a required value somehow.
For instance to Wikimedia Commons Android app.

Working on it.


Review threat modelling guidance

make links more correct (mostly so that emacs markdown-mode stops
complaining)
add caveat around STRIDE that it's not a categorization
tool (source: Threat Modelling by Adam Shostack, page 64)
add reference to diagrams.net threat modelling library, I've been
using it and found it helpful

Looks good to me


GEODE-680: Chunk refactoring encountered while writing unit tests.

Promoted constant fields to default access level.
Modified getAddressForReading to delegate to getUnsafeAddress.

this change looks good


Wallet Designs for (Transaction approval, balances + spam protection maybe)

Work in progress designs can be seen here: https://www.figma.com/file/W8SV56AAtXpRoQJDQW9ZYt/Vega-Wallet?node-id=1317%3A18325
The goal is to make some changes to the app "chrome" so that we can support some new features

notifications and approve/deny of transactions
balances
possible spam protection
Little bit of thinking about future features (key admin transaction history etc)

There has been a bunch of work on this and I think we can market this ticket as done. Designs for these features are available as and when needed.


XML escape error

When I had tried to open .gexf file, the following error had been displayed.

I opened the .gexf file in text editor and found it out.

I think it's better for this app to escape 「"」.

Could you please attach the file to the ticket? I guess I have already fixed something similar, but nevertheless I would like to check it. Thanks!

No problem.
I already fixed the problem. So, I make the file before fixing. Since I edited a bit, the line number of error changes to 219.
2018年12月23日：HoloMagnet5構成図.zip
When I try to open this file, the following window is shown.

Ok, there was a bug with storing GEXF files.
I've added html escaping to the string attributes, hope now it should work.


Resolving issues related to iQMC

We temporarily skip iQMC regression tests to achieve more concurrent developments in the same code base.
This Issue tracks the progress in resolving appearing issues.
The PR where the issue (partially failing some regression tests) started: #198

attempted fix #215

@sam, iQMC currently passes all the tests except iqmc_kornreich_pi in Numba mode.

That's odd. Thanks for the heads up. I'll give this a look as soon as I can.

It is addressed in #223. This turns out to be a non-issue. It seems to be my local environment.


BUG FIX: Explicitly include UIKit for projects that don't build with a precompile header

The ChimpKit SDK doesn't build as a git submodule for projects that don't use a PCH.
Also, I've added a .gitignore to eliminate Finder's .DS_Store files from getting committed into the repo.

Are you taking pull requests against this repository? Anything I can explain on my end to help?


send complete msg appears in different window

Using /send command while in [1:chat]
23:24:49 initiated file transfer to...
...waiting...waiting...
over in [0:console]
23:24:49 send completed...

This is by design.  The complete only goes to the console.


Fix up test case checks

In the test files of the practice exercises, our rule is that the test cases should be marked as skipped and only the first one should be active (un-skipped).
The test files are all the .spec.js files in the folder exercises/practice/.

Fixing up https://github.com/exercism/javascript/issues/1666


File name displayed on the tab is automatically changed when saving file changes

Issue Type: Bug
To Reproduce:

Make a folder and open it in VS Code.
Make a file. Let's suppose the new file name 'Example.js'.
Change the file name to 'example.js'. Then the file name displayed on the tab will be changed to 'example.js' too.
Make any changes on the file and save changes.
The file name on the tab changes to wrong name, 'Example.js'.
If I click 'example.js' on project tree again, the file name on the tab changes back to 'example.js'.

This occurs regradless of file extension and only occurs when a file name is same but only case is different. For example, 'eXaMPlE.js', 'EXAMPLE.js' too.
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
AMD FX(tm)-8300 Eight-Core Processor            (8 x 3293)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
11.97GB (6.85GB free)

Process Argv
--crash-reporter-id d5d4fffc-5da6-4dd4-b82d-ea7089ca55d8

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

intellij-idea-keybindings
k--
0.2.41

vscode-language-pack-ko
MS-
1.52.2

A/B Experiments
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221877
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30211401
wsl2prompt:30224612
pythonvsdeb440cf:30242243
unusedprompt:30224610
folderexplorercf:30224615
openfilemenucf:30224648
pythonvsded773:30236629
pythonvspyt875:30241730

Closing as dup of https://github.com/microsoft/vscode/issues?q=is%3Aissue+tab+casing+is%3Aclosed
fyi @bpasero

Closing as dup of https://github.com/microsoft/vscode/issues?q=is%3Aissue+tab+casing+is%3Aclosed
fyi @bpasero


Menu scrolls to wring position after site revisit

Reproduction:

click on the link library initialization in the Axes, title, tooltip' chapter
click on the browser's back button
click on a tutorial chapter in the menu

Problem:
The site scrolls up to the example section

fixed 0.7 site


add middleware hook/s?

hook = func(w http.ResponseWriter, r *http.Request)

It will be passed as part of middleware.Opts. It can be nil in which case a no-op func will be used.
It will be called by recoverer middleware instead of trace middleware so that it’s handled properly if it happens to panic.
People can use it for things like, implementing tracing/metrics.

should we have two hooks? One called as request starts and the other at the end?
if it’s just one hook, should it be called once or twice (start and end)?
if one hook and it’s called twice, we could add something in r.Context so that hook authors can know when is start and when is end?
do we really need hooks? Users can implement observability in their own handlers without relying on ong. Look at komuw/otero, what in the current state of ong prevents someone implementing something like it?

people should just write middleware.


Aetos 3.0 should include Karaf client scripts by default

Aetos 3.0 should include Karaf client scripts by default

$ git push origin 3.0.x
Counting objects: 45, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (8/8), 734 bytes | 0 bytes/s, done.
Total 8 (delta 3), reused 0 (delta 0)
To https://github.com/savoirtech/aetos.git
d4d5dff..32d5efa  3.0.x -> 3.0.x


faraday-agent-dispatcher: 3.3.0 -> 3.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for faraday-agent-dispatcher is: Tool to send result from tools to the Faraday Platform
meta.homepage for faraday-agent-dispatcher is: https://github.com/infobyte/faraday_agent_dispatcher
meta.changelog for faraday-agent-dispatcher is: https://github.com/infobyte/faraday_agent_dispatcher/releases/tag/3.4.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.4.1 with grep in /nix/store/4ah818iynn4i0r3kvrpmpnqwx1rxskqf-faraday-agent-dispatcher-3.4.1
found 3.4.1 in filename of file in /nix/store/4ah818iynn4i0r3kvrpmpnqwx1rxskqf-faraday-agent-dispatcher-3.4.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

faraday-agent-dispatcher

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4ah818iynn4i0r3kvrpmpnqwx1rxskqf-faraday-agent-dispatcher-3.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A faraday-agent-dispatcher https://github.com/r-ryantm/nixpkgs/archive/2ced1d73b211c978188f4fcc48c480f2e6ff2aa0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2ced1d73b211c978188f4fcc48c480f2e6ff2aa0#faraday-agent-dispatcher

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4ah818iynn4i0r3kvrpmpnqwx1rxskqf-faraday-agent-dispatcher-3.4.1
ls -la /nix/store/4ah818iynn4i0r3kvrpmpnqwx1rxskqf-faraday-agent-dispatcher-3.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 315009 run on x86_64-linux 1

2 packages built:

faraday-agent-dispatcher
faraday-agent-dispatcher.dist


Receiving mysterious Error: Cannot find module '@vue/compiler-dom' alert this morning

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
Currently running a continuous integration step which is resulting in the following error. This code has not changed so I can't wrap my head around why this is now occurring, but seems to point to Mocha.
Error: Cannot find module '@vue/compiler-dom'
Require stack:
-<EMAIL_ADDRESS>- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/graphql-tools/index.cjs.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/src/schema.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/src/utils/test.server.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/src/domains/accountInformation/resolvers.test.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/mocha/lib/esm-utils.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/mocha/lib/mocha.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/mocha/lib/cli/one-and-dones.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/mocha/lib/cli/options.js
- /home/runner/work/Titan/Titan/applications/gql/titan-gql-gateway/node_modules/mocha/lib/cli/cli.js

Versions

The output of mocha --version and node node_modules/.bin/mocha --version: 8.2.1
The output of node --version: 13.7.0
Your operating system

name and version: Macos
architecture (32 or 64-bit): 64

Your shell (e.g., bash, zsh, PowerShell, cmd): zsh
Your browser and version (if running browser tests): n/a
Any third-party Mocha-related modules (and their versions): n/a
Any code transpiler (e.g., TypeScript, CoffeeScript, Babel) being used (and its version): n/a

This seems related to @graphql-tools

to those interested https://github.com/ardatan/graphql-tools/issues/2542


Update MutableMapping import for Python 3.10

The ABCs were moved to collections.abc in Python 3.3, but aliases were in the collections module to avoid breaking code.  Python 3.10 removed those aliases.
The Travis config in the repo declares compatibility with Python 3.2, which does not have collections.abc.  I don't know if this package still runs on 3.2, and virtualenv doesn't support 3.2 (according to its docs, I didn't try), so I couldn't test it on 3.2.  On the assumption that no one cares about 3.2 anymore, this commit does not catch ImportError and fall back to the old import.

Unfortunately I have been locked out from the GitHub account; the fix is now applied to the new repository in https://github.com/tpircher/pycrc


No syntax coloring for .ejs files

Test tour MERN - https://github.com/Microsoft/vscode/issues/22277

VSCode Version: Insiders
OS Version: macOS

Steps to Reproduce:

Clone MERN starter kit
Open a *.ejs file.

I expect to see syntax coloring. There is no syntax coloring.

These are embedded JavaScript files.

https://marketplace.visualstudio.com/search?term=tag%3Aejs&target=VSCode&category=All categories&sortBy=Relevance

+1 for this. Filed a similar issue with the language itself.


Documentation

Hello! sorry but this package have a lack of documentation about the credentials, can you please explain which firebaseconfig JSON does it need? actually the credentials crash and have multiple errors.
maybe it works for you, but can you give the format of the json or the credentials needed to make it work please? if you teach me maybe i can redact a kind of Documentation to make it more understandable.
Thanks for your work brother.

It does ! 🚀


Select placeholder color cannot be set

Describe the bug
The Select.Trigger component in shadcn-svelte sets placeholder:text-muted-foreground on the SelectTrigger primitive in bits-ui. But this doesn't have any affect on the placeholder because it is not implemented as an input.
The tailwind docs indicate that the placeholder modifier only applies to placeholder text in inputs.
Here's the shadcn svelte component
<SelectPrimitive.Trigger
	class={cn(
		"flex h-10 w-full items-center justify-between rounded-md border border-input bg-transparent px-3 py-2 text-sm ring-offset-background placeholder:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50",
		className
	)}
	{...$$restProps}
	let:builder
	on:click
	on:keydown
>
	<slot {builder} />
	<div>
		<ChevronDown class="h-4 w-4 opacity-50" />
	</div>
</SelectPrimitive.Trigger>

Because of the way bits-ui implements Select.Value, there doesn't seem to be a way to set the color of the placeholder element. Here's the bits implementation of Select.Value
{#if asChild}
	<slot {label} {attrs} />
{:else}
	<span bind:this={el} {...$$restProps} {...attrs}>
		{label ? label : placeholder}
	</span>
{/if}

Reproduction

Go to the select component in shadcn-svelte

Notice that the "Select a fruit" placeholder text is the standard foreground color, even though it should be set to text-muted-foreground.
You can see the same behavior on the bits-ui demo page for the Select component.
Logs
No response
System Info
System:
    OS: macOS 14.1.2
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.83 GB / 64.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.1/bin/npm
    pnpm: 8.12.0 - ~/.nvm/versions/node/v18.17.1/bin/pnpm
    bun: 1.0.15 - ~/.bun/bin/bun
  Browsers:
    Chrome: 120.0.6099.234
    Safari: 17.1.2

Severity
annoyance

Yeah it's not a traditional placeholder in the sense you're referring to because it's not actually an input. If no label is present, it uses the placeholder prop. Perhaps we can make this better by applying a data-* attribute if the label isn't defined!


FR 6: Accept multiple files as input

FR6: Accept multiple files as input

Estimate: 5

Priority: Should have

Story:  As a pyWhat user, I want the app to be able to take multiple files as input so that I can input more than 1 files one time.

Acceptance criteria:

1.The app can take multiple inputs.

2.The app can correctly output the results for multiple inputs.

Adding Zichuan to this issue because his issue is now closed.


Use ci/latest as image for k8s_linux_apiserver

Issue:
The CI Image for APIServer is static is require manually change for updating.
Steps to change it:
$ vi sync/shared/variables.yaml
k8s_linux_apiserver: "ci/v1.22.0-alpha.3.31+a3abd06ad53b2f"   <---- removed
k8s_linux_apiserver: "ci/latest"   <------ added

How to test after the change?
# git clone https://github.com/kubernetes-sigs/sig-windows-dev-tools.git
< do the changes listed above>
# sig-windows-dev-tools# make 2

Goal: make sure it's using the latest kubernetes image for CI without breaking the build process.
See discussion here for more info: https://github.com/kubernetes-sigs/sig-windows-dev-tools/pull/148

/good-first-issue

@knabben already fixed that using stable:
k8s_linux_apiserver="stable-${kubernetes_version}"


dnd-kit/core package does not include or declare its license

The NPM package format provides support for declaring a package's license:
https://docs.npmjs.com/cli/v6/configuring-npm/package-json#license
The above does not appear to be used by at least the dnd-kit/core package.  Haven't check others.
Additionally, while the repository has a LICENSE file, it does not appear to be included in with the package build.

Good callout, this was definitely an oversight, thanks for pointing this out.
Will be resolved in https://github.com/clauderic/dnd-kit/pull/56

Good callout, this was definitely an oversight, thanks for pointing this out.
Will be resolved in https://github.com/clauderic/dnd-kit/pull/56


Added Visualizations for the IPL deliveries dataset

I added Visualizations for the IPL deliveries dataset but more visuals can be added.

Deleting this file was a mistake

No problem just put a new contributors.md (blank or copy the same from here)

To add yourself to our contributors' list, please check our Contribution Guidelines

@all-contributors please add @KemmieKemy for code


[enhancement] Read server interceptors as spring beans (TestRestfulServer.java 166-173)

This will make it possible to configure other loggers or interceptors without recompiling the code.

Created a pull-request for this:
https://github.com/jamesagnew/hapi-fhir/pull/153

Closing this as the pull request has been merged. Thanks again!


MAX30010 issues when connected to PaHub

Hi, In case of multiple I2C devices which one of them is MAX30010, making issues with MAX30010 device, such that the results are invalid, note that the I2C addresses between devices are different.

Hello @YonatanAmir1996
what are the I2C addresses of all the I2C devices you have connected? Note: If they are all different, then there is no need for a PaHub - you could simple connect them all directly to the core.
Thanks
Felix

There is one I2C device which has the same address, but anyway, physically the max30100 can't be connected in a middle of row. Is there an alternative or changes needed to be done in MAX30100 API code?

Hello @YonatanAmir1996
I do not have a max30100 - so I cannot try myself whether it should work through PaHub or not. Sorry.
Thanks
Felix

Are you using Unit Heart?


[RFC] Extensible EFI loader

Bareflank is a hypervisor for making prototypes and proof-of-concepts.  We want to bring this capability to the early boot environment to enable people to do hypervisor-related things before an operating system starts.  An EFI loader for bareflank exists, but isn’t extensible or well-integrated into the bareflank build system and someone who wants to extend it would have to modify its source code directly.  This RFC proposes a way to build hypervisor applications for EFI in a way that follows the bareflank philosophy.
When building an EFI loader for Bareflank, the build system will be able to compile multiple modules with a minimal bootable implementation as the ‘base’ module.  A user can add as much or as little as they’d like without having to reimplement most of the base logic.  A user’s EFI extension should be checked out to ../build and added to the cmake configuration with a new cmake function add_efi_module.
Design:
The general control flow during boot is “registered prestart functions” → “start function” → “registered poststart functions”
An extension adds functionality to the loader during a setup phase at runtime with very minimal code and no special makefile.
extension code:
ret_t my_prestart_fn()
{
	Print(L”Hello world!\n”);
}

void register_module() // special function name recognized by build system
{
	boot_add_prestart_fn(my_prestart_fn); // API call
}

The build system for generating bootable executables, currently based on gnu-efi, lives in extended_apis and does the compilation of extension code and generates the actual EFI executable.
extended_apis code:
void base_start_fn()
{
	// Platform multiprocessor startup calls start_vmm on all cores
}

EFI_STATUS efi_main()
{
	register_modules(); // calls register_module for each module added via cmake
	boot_start();
}

ret_t base_poststart_fn() // return value
{
	// Act as bootloader for next target unless another extension does it first
}

register_module()
{
	boot_set_start_fn(base_start_fn);
	boot_add_poststart_fn(base_poststart_fn);
}

A platform-independent API for achieving extensible control flow and launching of VMM without modifying OS driver-centric and monolithic common.c.
hypervisor code:
boot_add_prestart_fn(void (*fn)());
boot_set_start_fn(void (*fn)());
boot_add_poststart_fn(void (*fn)());
boot_set_vmm(void*, int);
boot_start_vmm_on_core(void*); // uses bfelf_loader to launch vmm

boot_start()
{
	execute_prestart_fns();
	execute_start_fn();
	execute_poststart_fns();
}

How exactly is the build system in the extended APIs adding code to the existing build system in the base hypervisor?
It would be nice to see more concrete examples with full file paths to see how this is going to work. On paper, it seems to make sense, and is similar to other schemes that we have used in the past for extending the VMM, but I don't see the whole picture with that this RFC currently provides.

Building an EFI application with gnu-efi is pretty much just a C project with particular CFLAGS and LDFLAGS and can probably be built by CMake without a hardcoded makefile
Here's a more fleshed-out version:
extension code (all of it):
my_extension/hello.c
ret_t my_prestart_fn()
{
    Print(L”Hello world!\n”);
}

void register_module() // special function name recognized by build system
{
    boot_add_prestart_fn(my_prestart_fn); // API call
}

my_extension/CMakeLists.txt
add_efi_module(
    NAME hello
    SOURCES hello.c
)

extended_apis code:
extended_apis/boot/efi_main/efi_main.c

EFI_STATUS efi_main (args) // EFI application's entry point
{
    // display banner etc
    register_modules();
    boot_start();
}

extended_apis/boot/efi_main/CMakeLists.txt
// CMakeLists file for building C project, linking against depends/gnu-efi
//
// Also build other objects added by add_efi_module and generate
// body of register_modules using C preprocessor or another method

extended_apis/boot/core/core.c
void base_start_fn()
{
    // Platform multiprocessor startup calls start_vmm on all cores
}

ret_t base_poststart_fn() // return value
{
    // Act as bootloader for next target unless another extension does it first
}

register_module()
{
    boot_set_start_fn(base_start_fn);
    boot_add_poststart_fn(base_poststart_fn);
}

extended_apis/boot/core/CMakeLists.txt
add_efi_module(
    NAME core
    SOURCES core.c
)

Hypervisor code:
(maybe not bfdriver directory since the OS driver model is different from the boot model)
hypervisor/bfdriver/src/boot.c
boot_add_prestart_fn(void (*fn)());  // Implement using an array of fn pointers to avoid allocation?
boot_set_start_fn(void (*fn)());     // Probably just _start_fn = fn
boot_add_poststart_fn(void (*fn)()); // same as prestart
boot_set_vmm(void*, int);            // do bfelf_loader loading and relocation
boot_start_vmm_on_core(void*);       // use bfelf_loader to execute vmm's entry point on core
                                     // NOTE: no platform-specific code in this file

boot_start()
{
    execute_prestart_fns();
    execute_start_fn();
    execute_poststart_fns();
}

renaming 'core' to 'base' to not confuse things with processor cores
put base.c in architecture folder to make room for arm targets in the future?  efi_main should be able to be used for both intel and arm

I like it. When you are done working this code, we should create an example project that provides an example of how to add custom logic. Also, the EFI code that is being added to the extended_apis should be added to a bfdriver folder, and have the same structure as the bfdriver logic in the base hypervisor.

+1

Merged


CAM-10840: Add property to disable CamundaBpmWebappAutoConfiguration

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Roland,
thank you for your contribution and sorry for the late response.
I have looked into your changes and I think you did a great job! :)
I will add documentation regarding the new property accordingly.
Cheers,
Tassilo


Dame sprint oct tests

Add and implement tests.
Controller tests were fully implemented to the extend that I was able to.
Repository tests were only partially implemented.
Directive tests were not implemented.

Coverage increased (+64.8%) to 78.661% when pulling e087dfe263cf163b924b7dab8f8a286ae7c0092a on dame-sprint-oct-tests into 47eb6955bd9570d703c586b42e57f7c4c2817e26 on master.

This is ready to merge.


Add mouse navigation support for actions

Description of the new feature/enhancement
Follow-up on #10801: the added browser_back and _forward keys are the keyboard keys, not the mouse buttons. It might be nice to add support for these buttons as well, usually they are VK_XBUTTON1 and VK_XBUTTON2.
Proposed technical implementation details (optional)
The implementation will be a bit more complicated than just adding the key definitions, as now the mouse handlers should also check for keychord bindings. My proposal would be to add this to TermControl::_PointerPressedHandler. This would limit the support to when hovering the terminal control, so that might not be ideal. I am not sure what is actually desirable here.
Things to consider:

Add support for "just" XBUTTON1/2, or also for other buttons?
What should the textual representation of these buttons be? Make them coincide with browser_back and _forward, or separate names mouse_back and _forward?
How do mouses with more macro buttons operate?

Team decision: We're cool with these being allowed as keys in actions _if they come through as keys in PreviewKeyDown, where keybindings are processed. In 1.11, we thought you might just be able to get away with vk(5) (for VK_XBUTTON1 for example).
However, our cursory investigation makes us think that these don't come through as keys. This might be better off being dealt with by #1553. Probably as a sub-task of the bigger feature over there.
Thanks!

I tried myself by adding these VK_XBUTTON1 entries, but those are not registered through any KeyDown or similar methods. I think it would be much neater to combine it with the issue you linked indeed.