Formatting issues with CN or HK regions

So this is weird...when I type in the following code as a test, I noticed that the formatting is off:
    NBAsYouTypeFormatter *f = [[NBAsYouTypeFormatter alloc] initWithRegionCode:@"CN"];
    NSLog(@"%@", [f inputDigit:@"1"]); // "1"
    NSLog(@"%@", [f inputDigit:@"2"]); // "12"
    NSLog(@"%@", [f inputDigit:@"3"]); // "123"

    NSLog(@"%@", [f inputDigit:@"4"]); // "1234"
    NSLog(@"%@", [f inputDigit:@"5"]); // "12345"
    NSLog(@"%@", [f inputDigit:@"6"]); // "12345 6"
    NSLog(@"%@", [f inputDigit:@"7"]); // "12345 67"

    NSLog(@"%@", [f inputDigit:@"8"]); // "12345 678"
    NSLog(@"%@", [f inputDigit:@"9"]); // "12345 678 9"
    NSLog(@"%@", [f inputDigit:@"0"]); // "1234567890"
    NSLog(@"%@", [f inputDigit:@"0"]); // "12345678900"

Anyone else run into this issue?

Does "12345678900" number can use phone number format in CN ?

For more information, you can check below link.
http://libphonenumber.googlecode.com/svn/trunk/javascript/i18n/phonenumbers/demo-compiled.html

12345678900 is not a valid CN number but I was hoping they could still format it to be like:
123 4567 8900
I can't control what the end user types in a UITextField so was just hoping for that...
in the end, it's still an invalid number.
Also, this might not be an issue with your library...but when I typed in<PHONE_NUMBER>0, and then hit the backspace key until I see 12345, I wasn't able to erase the 12345 from the UITextField embedded in UITableViewCell. I'm also using XLForm as the library to do the UITextField layout. This could be an issue with XLForm but not sure...
Any other number like<PHONE_NUMBER>4 works fine though...

Ah, I see..
It seems need some result method.
something like callback with error code.
I will consider it.

감사합니다 !

Sorry for late.
Use latest updated code in github (just add delegate)
{
...

NBAsYouTypeFormatter *formatter =

[[NBAsYouTypeFormatter alloc] initWithRegionCode:@"US"];
[formatter setDelegate:self];

NSLog(@"%@", [formatter inputDigit:@"2"]);

NSLog(@"%@", [formatter inputDigit:@"1"]);

NSLog(@"%@", [formatter inputDigit:@"2"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

NSLog(@"%@", [formatter inputDigit:@"5"]);

}

(void)formatter:(NBAsYouTypeFormatter *)formatter
didFormatted:(BOOL)withResult

{
NSLog(@"didFormatted : %@", withResult ? @"YES":@"NO");

}
Shows
2015-04-01 01:08:34.195 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.195 libPhoneNumber[10967:3095377] 2
2015-04-01 01:08:34.195 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.195 libPhoneNumber[10967:3095377] 21
2015-04-01 01:08:34.195 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.196 libPhoneNumber[10967:3095377] 212
2015-04-01 01:08:34.196 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.196 libPhoneNumber[10967:3095377] 212-5
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] 212-55
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] 212-555
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.197 libPhoneNumber[10967:3095377] 212-5555
2015-04-01 01:08:34.198 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.198 libPhoneNumber[10967:3095377] (212) 555-55
2015-04-01 01:08:34.198 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.198 libPhoneNumber[10967:3095377] (212) 555-555
2015-04-01 01:08:34.198 libPhoneNumber[10967:3095377] didFormatted : YES
2015-04-01 01:08:34.199 libPhoneNumber[10967:3095377]<PHONE_NUMBER>
2015-04-01 01:08:34.199 libPhoneNumber[10967:3095377] didFormatted : NO
2015-04-01 01:08:34.199 libPhoneNumber[10967:3095377]<PHONE_NUMBER>5
Please give me some feedback.
On Wed, Jan 21, 2015 at 12:11 PM, jonathanxie<EMAIL_ADDRESS>wrote:

감사합니다 !
—
Reply to this email directly or view it on GitHub
https://github.com/iziz/libPhoneNumber-iOS/issues/42#issuecomment-70777729
.

--
from zen<EMAIL_ADDRESS>http://about.me/ishtar
SungMin Ha (ishtar)
[image: http://]about.me/ishtar
http://about.me/ishtar

No problem on the late reply. Appreciate you trying to fix the issue.
I still get an issue:
2015-04-01 17:26:13.049 testapp[1246:469459] formattedNumber = 1
2015-04-01 17:26:13.051 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:14.387 testapp[1246:469459] formattedNumber = 12
2015-04-01 17:26:14.388 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:14.389 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:15.682 testapp[1246:469459] formattedNumber = 123
2015-04-01 17:26:15.682 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:15.682 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:15.683 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:18.166 testapp[1246:469459] formattedNumber = 1234
2015-04-01 17:26:18.166 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:18.167 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:18.167 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:18.168 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:20.124 testapp[1246:469459] formattedNumber = 12345
2015-04-01 17:26:20.125 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:20.126 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:20.127 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:20.130 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:20.130 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:22.809 testapp[1246:469459] formattedNumber = 12345 3
2015-04-01 17:26:22.811 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:22.811 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:22.813 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:22.817 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:22.817 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:22.818 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:24.068 testapp[1246:469459] formattedNumber = 12345
2015-04-01 17:26:24.069 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.070 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.071 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.075 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:24.076 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.896 testapp[1246:469459] formattedNumber = 12345 6
2015-04-01 17:26:24.897 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.897 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.898 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.901 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:24.902 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:24.904 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:26.772 testapp[1246:469459] formattedNumber = 12345
2015-04-01 17:26:26.774 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:26.774 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:26.775 testapp[1246:469459] didFormatted : YES
2015-04-01 17:26:26.778 testapp[1246:469459] didFormatted : NO
2015-04-01 17:26:26.780 testapp[1246:469459] didFormatted : YES
Also on my text field, I have to hold down the backspace button on the keyboard for quite some time to erase the "12345".
This also breaks for numbers that don't make sense in China: 12456, 12366, etc

Ah... I see, could you show me your test code ?

Here you go:
https://github.com/jonathanxie/libPhoneNumber-Test

Were you able to use my test code?

Yes please wait a few days :)

I think "delegate" is not good for this, so I removed it and check it for "isSuccessfulFormatting".

Please give me any feedback :)

@iziz sorry, haven't had a chance to test yet...but I'l let you know as soon as I get a chance =)

Nop :) don't worry about that ~


Source control stuck

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.74.3
OS Version: Windows

Steps to Reproduce:

Start computer. Open fresh vscode.
Source control icon stuck on loading and doesn't show changes even if there are some.
To get rid of it I need to reload vscode or use Fetch from dropdown list because fetch in console doesn't help.

This is a buggy version .. a few things are broken

I had this also in previous versions.

@js-writer, we are showing a progress indicator while scanning the folder/workspace for possible git repositories. Is there a chance that this is a large workspace and it just takes a long time for the initial repository discovery to complete? What is the value of the git.repositoryScanMaxDepth setting? Also could you please share the contents of the git output window? Thanks!

No, does are small projects. And no matter how long I wait progress indicator doesn't disappear.
git.repositoryScanMaxDepth is set to 1.
Logs:

@js-writer, are you able to reproduce the issue if you start VS Code as code --disable-extensions? Thanks!

Ok I did and have the same result:

@js-writer, are you able to reproduce the same behaviour using VS Code Insiders?

Yes.
Same issue:

@js-writer, puzzling. Could you please try the following:

Close all windows of VS Code Insiders
From a terminal run code-insiders --log trace
Open the folder/workspace containing the git repository
Wait for 2 minutes, and share the contents of the git output window

@js-writer, are you able to reproduce the same behaviour using VS Code Insiders?

VS code insiders seems to work for me and it is my new default version.

@lszomoru Here:

@js-writer, thank you very much for sharing the logs, and apologies for not getting back to you on this. The logs show that there is a "Status" operation that starts which show the progress but for some reason the operation never completes. I will investigate the code and see what could be the reason behind that, and update the issue with my findings.

@lszomoru thx for replay. I think the problem was because I had old git version on my pc. After update everything is working fine. Unfortunately I don't know which version of git I had.
Thank you for support.

@sergeybaklanov my version is 2.40.0.windows.1

I updated git to version 2.40.0 but still have this problem. When I try to implement some interface or extend some class source control goes to infinity update.

Same issue for me, can't even format a saved file with prettier. Something broke hard

@sergeybaklanov, could you please use the steps described here and share the contents of the git output window. Hopefully that will help us track down the root cause of the issue.
@arieller, it seems that in your case Prettier is trying to format the document. Could you please try to disable the Prettier extension and see if you are still able to reproduce the problem? Thank you!

@lszomoru
User@WIN-2BVQ3PFI2R7 MINGW64 ~
$ code-insiders --log trace
bash: code-insiders: command not found

@sergeybaklanov, do you have VS Code Insiders installed?
Could you please try running code --log trace from the Terminal instead?

Closing as the requested logs were never provided to further investigate the issue.


[Data]: Add RUM annotations to grant details UI elements

Why is this issue important?
We want to be able to accurately and intuitively track user interactions with various page elements in Datadog RUM, but automatic element names can be unreliable.
Current State
Datadog RUM views and actions are fully reliant on auto-generated UI element names.
Expected State
UI elements related to with which users may interact (buttons, toggles, etc.) are annotated with the data-dd-action-name attribute. This issue focuses specifically on the "grant details" modal.
Implementation Plan

Update the grant details modal component so that UI elements are annotated. The following screenshots display examples of the minimum set of elements (additional elements may be annotated if it seems valuable to do so):

Update element callback handlers to include calls to datadogRum.addAction() as follows (fill in <placeholder> values accordingly):

User submits team a status:

Name: submit team status for grant
Context:{ team: { id: <team id> }, status: <selected status text>, grant: { id: <grant id> } }

User removes a team status (by clicking trash can icon):

Name: remove team status for grant
Context:{ team: { id: <team id> }, status: <previously selected status text>, grant: { id: <grant id> } }

User assigns a team:

Name: assign team to grant
Context:{ team: { id: <assigned team id> }, grant: { id: <grant id> } }

User removes a team assignment (by clicking trash can icon):

Name: remove team assignment from grant
Context:{ team: { id: <unassigned team id> }, grant: { id: <grant id> } }

User closes grant details modal (regardless of button):

Name: close grant details modal
Context: { grant: { id: <grant id> } }

Relevant Code Snippets
No response

cc @ClaireValdivia


Creating TFrecord does not work for me. It runs the code and does exactly nothing.

Can you post your command and folder structure for the raw dataset? It is better to test the scripts with small datasets like the Middlebury-other.

Thank you for your reaction!
It seems in the create_vimeo90k_tfrecord.py files it should be: def main(argv=None)  (the argv is missing)
otherwise the code is not executable.
and the beam pipeline is not working for me.
but doesn't matter I tried creating it without beam.
though tfrecord is unsuitable for me as I want to Train your FILM-network on X-Train (200 gb xD) to compare it.
Important:
Have you tried to train your network on X-Train? It seems to be the only high motion Training Dataset freely available.
Thank you in Advance!

Thanks for pointing the X-Train data.

Fixed by 86200bdfb1cd715d6e3fbb4a87b4babf24db4d07


Rebox userEK during self provision

adds ephemeralKeyReboxer to encapsulate some of the reboxing logic to use during provisioning and refactors kex2 to use this as well

fixes a chat but where pairwise mac errors are displayed correctly:

instead of


Rewrite world mocking

World mocking using WorldTrait is quite painful and causes some problems and inconsistency especially after merge of https://github.com/hyperledger/iroha/pull/2284
We need to find another way to mock World for tests.
Some solutions I can see right now:

Use mockall crate
Remove mocking at all and do some test runtime preparation using genesis, instructions and other supported things
Like 2 but use procedural macro for that

The option 1. should be the first thing that we try. We don't want to maintain a separate non-compliant mocking library inside of Iroha. To me this is a relatively large change, so we should put this off until after the LTS is released.
The option 2 is something that we will need to do eventually, since test_network only crudely approximates the behaviour of a real system. I think that we need to have a lot more real integration tests, and improve the coverage with unit tests.


feat: use data uri for card fallback image

Description
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

So this is failing on
https://github.com/openedx/paragon/blob/1b90fdacf3dd6738c61a7dfdfe3de5683ecf8faf/src/Card/tests/CardImageCap.test.jsx#L122-L130
now, but I'm not sure what "hiding component if it isnt fallbackSrc and src dont work" is supposed to be testing, or if it's accomplishing it's intended purpose.
It was passing before because the fallback png would lead to
https://github.com/openedx/paragon/blob/1b90fdacf3dd6738c61a7dfdfe3de5683ecf8faf/__mocks__/fileMock.js#L1
I tried throwing
jest.mock('../CardFallbackDefaultImage', () => ({ cardSrcFallbackImg: 'test-file-stub' }));

into the test file to see if I could fix the error really quickly, but it still failed.
Before spending any real amount of time fighting this test I'd like to understand what it is actually trying to verify.

@PKulkoRaccoonGang I checked the git blame on the test and it looks like you added it last year as part of https://github.com/openedx/paragon/pull/1994.
Any chance you remember what
expect(srcImg.src.endsWith('test-file-stub')).toEqual(true);

is verifying?

@brian-smith-tcril, thank you for these changes!
In the package.json, we have the following configuration:
"moduleNameMapper": {
  "\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$": "<rootDir>/__mocks__/fileMock.js",
  "\\.(css|scss)$": "identity-obj-proxy"
}

This setup is necessary because Jest does not natively handle media files. Instead, a stub is provided to prevent errors during test execution. We use this approach in the Avatar component, as it requires mocking a .svg image.
expect(srcImg.src.endsWith('test-file-stub')).toEqual(true);

This check verifies that the mocked file (test-file-stub) is used as the source for the component’s src attribute when the actual image loading fails.
Since we now want to use an image in base64 format, there is no longer a need to mock the image. I propose updating the test as follows:
it('renders the default image if both src and fallbackSrc fail to load', () => {
  render(<CardImageCapWrapper src="fakeURL" fallbackSrc="fakeURL" srcAlt="Src alt text" />);

  const srcImg = screen.getByAltText('Src alt text');
  fireEvent.load(srcImg);
  fireEvent.error(srcImg);
  expect(srcImg.src).toEqual(cardSrcFallbackImg);
});

I tested this change locally, and it works as expected.

Thanks for the advice @PKulkoRaccoonGang! I've updated the test and everything looks good now!


How to continue to this action after a test failure?

This action seems to work great when there are no test failures, but when I do have a failure it is never hit since my testing step fails and exits.  How to I make it always continue on to always report regardless?
Here is my action setup
name: Pull Request Sanity Check

on:
  pull_request:
    paths-ignore: ['.vscode/**', 'README.md', '.*']

permissions:
  contents: write

jobs:
  pr-sanity-check:
    concurrency: ci-${{ github.ref }}
    runs-on: ubuntu-latest
    steps:
      # Preparation ----------------------------------------------------
      - name: ⏬ Checkout
        uses: actions/checkout@v4
        with:
          ref: ${{ github.event.pull_request.head.sha }}

      - name: 💻 Set up Node.js version
        uses: actions/setup-node@v3
        with:
          node-version: 20

      - name: 📦 Install Packages
        run: npm ci

      # Building ----------------------------------------------------
      - name: 🛠 Build UI (Angular)
        working-directory: app
        run: npm run build

      - name: 🛠 Build Server (NestJS)
        working-directory: server-nest
        run: npm run build

      # Unit Testing ----------------------------------------------------
      - name: 🧪 Unit Test Runner (NestJS) 🌮
        working-directory: server-nest
        run: npx jest --coverage --coverageReporters=text --coverageReporters=json-summary --reporters=jest-junit --reporters=github-actions && exit ${PIPESTATUS[0]}

      - name: 🧪 Unit Test Reporter
        uses: MishaKav/jest-coverage-comment@main
        with: #we can have this report on code coverage in multiple projects
          title: Code Coverage Report
          multiple-files: |
            NestJS Server, ./server-nest/coverage/coverage-summary.json
          multiple-junitxml-files: |
            NestJS Server, ./server-nest/junit.xml

And this is what I see in the output

The key part to focus on here I suppose is how I run my tests, which is this:
npx jest --coverage --coverageReporters=text --coverageReporters=json-summary --reporters=jest-junit --reporters=github-actions && exit ${PIPESTATUS[0]}

I've tried forcing && exit 0 at the end as well, but even that results in it reporting Process completed with exit code 1. and I dont understand why

It's been a few weeks since I created this, can anyone provide the info?  This feels pretty basic, I mean this is entirely what this project is about - reporting test failures. What do I need to do to make that happen?

The purpose of the current action is to generate the tests report from provided files.
The problem is that you don't reach the step of the current actions because the previous step is failing.
I suggest you try the following:

add continue-on-error: true - it will continue to next step, even if the current is failing

- name: 🧪 Unit Test Runner (NestJS) 🌮
  working-directory: server-nest
  continue-on-error: true
  run: npx jest --coverage --coverageReporters=text --coverageReporters=json-summary --reporters=jest-junit --reporters=github-actions

add if: ${{ always() }} the will always execute the step of current action:

- name: 🧪 Unit Test Reporter
  uses: MishaKav/jest-coverage-comment@main
  if: ${{ always() }}
  with: #we can have this report on code coverage in multiple projects
    title: Code Coverage Report
    multiple-files: |
      NestJS Server, ./server-nest/coverage/coverage-summary.json
    multiple-junitxml-files: |
      NestJS Server, ./server-nest/junit.xml

Excellent, thank you so much! That did it and it makes a lot of sense.
What I ended up doing was only adding if: ${{ always() }} so that the PR script will still fail if the tests fail.


Add ability to export Arduino code for a registered site

Once a user has registered a site and added sensors to it, add a button to the site details/registration page that exports a code block with the following:

SamplingFeatureUUID
Time zone/UTCOffset Information
SecurityToken
ResultUUIDs for any attached sensors

This would enable us to use standardized code for the rest of the Arduino code, but the users can paste this code into the standard code. Still need to define exact content and format of the code that is exported.

We'll be basing the snippet generator off this .ino file:
https://github.com/EnviroDIY/ModularSensors/blob/master/examples/logging_to_EnviroDIY/logging_to_EnviroDIY.ino

@fryarludwig, please let me know if there's anything in that .ino that you don't understand!

As of my latest push, the devices page creates code that has each of the device's and sensors' UUIDs (see screenshot below). This is far from a full .ino file generator, but there are enough challenges (pins used, calibration values, header includes, and sensor initialization) that reliably generating full files would optimistically take about a week.
To generate the full .ino file, we would need to gather all of the sensor class names and constructors from the sensor repository, know which sensors require which pins and which calibration values (we could leave these blank for the user to fill in), and assume serial port details. We would also need a way to handle new sensors that are added after the release of this tool. There would still be a lot of values for the user to fill in, but it may save enough time to be useful. What's the group consensus on this? (We could also wait on the full .ino file generator for a later release, if there are higher priorities right now)

@fryarludwig - rather than displaying the code on the page, let's add a button that opens a modal window.
@SRGDamia1 and @aufdenkampe - I think we probably need some feedback from you guys on this.

@fryarludwig, thanks for all this hard work! What you just showed looks like a great help, and I'm leaning toward releasing the next version based on just generating the code snippets with the UUIDs and leaving the full .ino generation for a later release, because, as you point out, @SRGDamia1  and I will need to do some work to provide additional information about the pin configurations for each sensor, etc.
I also agree that there may be some higher priority issues to work on, which you could do in parallel to the our work.
Let's meet this week to discuss next steps.


Apple store issues

I have been using the main hosts list on my Edgerouter for some months now, without any issues. Since recently I am having trouble downloading apps on my iPhone from the Apple store. This problem is gone when I disable the adblocker.
Any idea which entry could be causing this?

Hi @liquidox it's hard to tell without examining the requests involved.  Tough to do that on iOS.
Does anyone have ideas on this?

I'm using the main hosts file on my Edgerouter+ as well.   I just updated to the latest hosts file and downloaded from the appstore.   No problem.    I think you might have a problem with your phone configuration.
You could turn on detailed traffic logging to try to see what is failing.

Strange, but thanks for testing on your end. Haven't changed anything on my iPhone and the problem was gone immediately after the change on the ERL.
I will close this then, as jac has confirmed it's not an issue in the hosts list.


Updating disable status of switch

There was a bug when "ng-disable" became true and then false.

@ab192130 in #28 I removed the hacky implementation of the disabled state and purely rely on ng-disable now, can you test your use-case again and tell me if it works now?


Suggestion: if try to place a breakpoint on a non-executable line, put a break point on the next line which is executable

Problem Description
Currently, if you try to place a break point on a non-executable line, no break-point is inserted. For example, if like # 47 is blank, then left clicking next to line # 47 fails to place a break-point on that line. Suppose # 51 is the next line after 47 which is not blank or a comment. It would make sense to place the break-point there is a user tries to place one on # 47
What steps will reproduce the problem?

open a file containing a mix of executable and non-executable lines of code
For a line which is non-executable (line is blank or is a comment),  left click to the left of a line number f
observe that red dot (denoting a breakpoint) fails to appear

What is the expected output? What do you see instead?
Expect to see break point placed on next executable line. Instead, no break-point is placed anywhere.
Package Versions

Spyder: 3.2.3
Python:  3.6.2 64 bit
Qt:  5.6.2
PyQt:  5.6
Operating System: Windows & Ultimate service pack 1

Dependencies
IPython >=4.0    :  6.1.0 (OK)
cython >=0.21    :  0.26 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
numpy >=1.7      :  1.13.1 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pyflakes >=0.6.0 :  1.6.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.7.2 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
sympy >=0.7.3    :  1.1.1 (OK)

@ccordoba12 Thoughts on this? I'm ambivalent...

@GalacticStarfish, how does this work in other IDEs or editors (e.g. VSCode or PyCharm)?

VSCode will let you put it anywhere.

If that's possible, then we should do it too.


Clarify the function is using radians for input.

It can be confusing to not know the units being used for the Sine and Cosine functions. Probably need to update other trig functions also but these are the one I was using.

@microsoft-github-policy-service agree [company="Microsoft"]

* @microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@shsagir

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @rodneykorn thanks so much for making the effort to update this missing information.

Approved by ADX docs
#sign-off

#sign-off


Fixed crash

There was a crash when you go to select ringtone again. The default selection is also moved to on post execute.

@ranaparamveer Thank you for the PR. I reviewed the code. Please see the code review comment.

Please check now.

Approved.


Wind SFX missing?

Where did they go? Why only sometimes? Is this because of randomized ambience?
Who will tell us?

Maybe this should be addressed via Everest. So Modder doesn't have to deal with it.
https://github.com/max4805/Everest-ExtendedVariants/blob/495796772be2c62c6643d7f43eeb6916a734cdba/ExtendedVariantMode/Variants/WindEverywhere.cs#L90

concerning. sometimes modding this game feels like prodding around in the dark with a stick.


Home kit configuration code

Hello, i try to connected my esp with apple home, but where i found configuratione code for home kit?
thank

Hi, predefined setup code is 111-22-333, but you are free to provision any code by RPC call
I will update the readme for this


[BERT] BERT for Named Entity Recognition

Since that gluon-nlp already has very good tools for BERT and also that it has basic data processing for named entity recognition ready from https://github.com/dmlc/gluon-nlp/pull/466 , I wanted to build upon these and implement BERT for NER. I have started implementing this for a personal project, but please let me know if you have concerns or suggestions.

Thanks! That will be great. Do you plan to reproduce result reported by BERT on the CoNLL 2003 dataset?

Yes, I will mainly aim to reproduce BERT result on CoNLL 2003 English. I may try couple other datasets like OntoNotes or CoNLL 2002 Spanish if this goes well!

I also implemented a pre-training NER project with reference to https://github.com/kyzhouhzau/BERT-NER, which was originally used to play the couplet. If there is any problem, you can discuss it together.

I am reusing BIO/BIOES data processing code (utils_func) from https://github.com/dmlc/gluon-nlp/pull/466 ; should we move this to gloun.nlp.data? I guess code under /script is not supposed to be shared across scripts? Also it is unclear this could should go to /script/bert or /script/named_entity_recognition. Any suggestions?

@bikestra right. If you find the utility useful, feel free to propose it as a utility function in gluonnlp.data. Alternatively, there's already a number of datasets in conll in gluonnlp. Maybe we can expose a base class for conll formats too. In case you wonder, we didn't offer conll2003 due to license.

@bikestra do you intend to introduce the hybridizable CRF too?

@szha I was planning to start with simple softmax loss and replicate the BERT paper, but it sounds interesting to try.

@bikestra @fierceX I was planning to start on the same task. Do you have initial version of the commit ?

@bikestra @fierceX @parry2403 feel free to open a feature branch for collaboration if that's helpful to you.

@bikestra Can you commit an initial version?

@fierceX @parry2403 I have an initial version of the code but it is very rough and does not yet achieve good F1 scores yet. Let me do a minimal exploration & cleanup and commit an initial version by tomorrow. Would it be OK?

@bikestra Sure. I have seen BERT forums where reproducing CoNLL scores has been issue since authors used document context.

@fierceX were you able to reproduce results from https://github.com/kyzhouhzau/BERT-NER and replicate with gluon-nlp? I am getting F1 scores only around 89. I am using bert_12_768_12 instead of bert_24_1024_16 but according to the paper that should make only a small difference... I will anyways share what I have today, but was curious of your experience.

@bikestra I haven't scored an F1 yet, so let's take a look at your implementation.

I get an F1 score around 0.91 with smaller learning rates, so it might just be a hyperparameter tuning problem. I will explore a bit.

This might be close to upper bound since based on lot of discussions from other frameworks, it seems that they got 92.2 with document context rather than sentence context.

I tried a lot of tricks but could not improve beyond test F1 of 91.7.  The package @fierceX mentioned does much worse than this, because their dev F1 score (which is much easier than test F1, usually 3 point higher) is only 93 https://github.com/kyzhouhzau/BERT-NER/issues/2 .
Is anyone aware of the codebase that successfully replicated BERT paper's results on CoNLL 2003 English?

BERT base model's finetuning result on conll2003, on test F1 is 92.4, so it's close now. They mentioned in the paper that they did this without using the context around, and the scoring is based only on the first subtoken of each word, with later subtokens all omitted. Is that what you did too?

@szha Yes, 91.7 is close but I think 0.7% point is a meaningful gap, since non-contextual word embeddings can get pretty close to this. And yes, I am only predicting the first subtoken of each word. I actually tried different strategies - predicting every subtoken to IOBES, and then using CRF on top of it - but any of these things didn't help.
@parry2403 kindly shared me the link to the relevant conversation which claims BERT authors did use document context: https://github.com/allenai/allennlp/pull/2067#issuecomment-443961816

With BERT large, I could get dev F1 96.0 and test F1 91.9. This would not be a state-of-the-art NER tagger (you can certainly do better with ELMo) and takes tens of iterations which is unusually slow, but is better than non-contextual word embeddings, and I couldn't find anyone who got better than this with BERT. Would this still be a good addition to gluon-nlp? If so, I could do a clean-up and update the pull request.

@bikestra yes, let's add that as is. Once it got more eyes, maybe someone who work on NER in the community could offer some hint.
I actually heard a similar story on sequence tagging performance of BERT from @jdchoi77. We discussed that it might be due to the BPE tokenization, because sequence tagging for Chinese seems to work well where the tokenization is usualy already at character level. If that's indeed the case, we could potentially do the subword sampling that's offered from sentencepiece to learn more robust subword representation, or do character-level embedding similar to ELMo.

Sure, will do the clean up and push. FWIW I could get dev F1 96.1 and test F1 92.2 so this is comparable to reported ELMo numbers. Of course this is somewhat overfitting to test F1 score...

@szha, @bikestra, The CoNLL03 model is probably not the most useful one in practice. We should release the one trained on OntoNotes instead which gives more entity types and diversities in genres.

@jdchoi77 I agree OntoNotes is much more interesting than CoNLL 2003 Eng, and I can certainly provide numbers on it. But they wouldn't be useful for the benchmarking purpose since ELMo/BERT papers and their implementations don't reports OntoNotes results.

@bikestra For a benchmarking purpose, CoNLL'03 is indeed better. We are going to provide scores on OntoNotes for POS, NER, dependency parsing, and semantic parsing so hopefully people will use it for new benchmarks.

Sure, will do the clean up and push. FWIW I could get dev F1 96.1 and test F1 92.2 so this is comparable to reported ELMo numbers. Of course this is somewhat overfitting to test F1 score...

@bikestra Could you share your hyperparameter settings for test F1 92.2? I saw your PR. Are the hyperparameters what you used to produce 92.2? It's pretty close to 92.8. Actually Facebook is using smaller lr for LM during fine-tuning. I'd like to try that on top of your work.

The default hyperparameters result in a quite low score:
dev f1: 0.934 test f1: 0.896

Hi @hankcs  , sorry for the late reply. I refactored the code a bit, and after that I was only able to achieve 91.8 and couldn't reproduce 92.2, which was the reason my reply was delayed. I am playing around with hyperparameters but I haven't got a good success yet. I will need to more debugging / navigating commits to figure out why 92.2 is not reproducible. Just to make sure others can also take a look, I pushed the current state of the code that achieves 91.8. Check out the pull request or the master of  https://github.com/bikestra/gluon-nlp . Below is the command I used to get 91.8 test F1.
GPU=0
OPTIMIZER=bertadam
BATCH=8
CONCAT_MAX_LEN=0
DROP=0.1
LR=1e-5
EPOCH=50
expname=lr${LR}_d${DROP}_b${BATCH}_o${OPTIMIZER}_reale${EPOCH}_c${CONCAT_MAX_LEN}
python3.6 ./train_bert_ner.py --train-path ${DATA_PATH}/train.txt --dev-path ${DATA_PATH}/dev.txt --test-path ${DATA_PATH}/test.txt --gpu ${GPU} --learning-rate ${LR} --dropout-prob ${DROP} --num-epochs ${EPOCH} --batch-size ${BATCH} --optimizer ${OPTIMIZER} --save-checkpoint-prefix ./models/${expname} --bert-model bert_24_1024_16 --seed 13531 |& tee log_${expname}.txt

By running it for 100 epochs with the same command above, I was able to get test F1 of 92.1. So I think this is a matter of hyperparameter optimziation/random error and the code itself is (mostly) correct.

@bikestra I could not find train_bert_ner.py used in the comment above. Is it same as train_ner.py contained in the repository?

@ikuyamada this script will be included as part of the 0.7.0 release coming soon. The doc can be found at: http://gluon-nlp.mxnet.io/master/model_zoo/bert/index.html#bert-for-named-entity-recognition
If you'd like to try it out now, you can install the master version of GluonNLP by following the guide here: http://gluon-nlp.mxnet.io/master/install.html#install-from-master-branch

@szha Thank you for your prompt reply! I will try it out!

@bikestra Hi, could you tell me how you get 91.7 with bert-base and what tricks do you use? I am trying to reproduce the result of bert-base but I can only get 91.3 with bert-base.

In order to reproduce the conll score reported in BERT paper (92.4 bert-base and 92.8 bert-large) one trick is to apply a truecaser on article titles (all upper case sentences) as preprocessing step for conll train/dev/test. This can be simply done with the following method.
#https://github.com/daltonfury42/truecase
#pip install truecase
import truecase
import re

# original tokens
#['FULL', 'FEES', '1.875', 'REOFFER', '99.32', 'SPREAD', '+20', 'BP']

def truecase_sentence(tokens):
   word_lst = [(w, idx) for idx, w in enumerate(tokens) if all(c.isalpha() for c in w)]
   lst = [w for w, _ in word_lst if re.match(r'\b[A-Z\.\-]+\b', w)]

   if len(lst) and len(lst) == len(word_lst):
       parts = truecase.get_true_case(' '.join(lst)).split()

       # the trucaser have its own tokenization ...
       # skip if the number of word dosen't match
       if len(parts) != len(word_lst): return tokens

       for (w, idx), nw in zip(word_lst, parts):
           tokens[idx] = nw

# truecased tokens
#['Full', 'fees', '1.875', 'Reoffer', '99.32', 'spread', '+20', 'BP']

Also, i found useful to use : very small learning rate (5e-6) \ large batch size (128) \ high epoch num (>40).
With these configurations and preprocessing,  I was able to reach 92.8 with bert-large.


publish

I don't have access to crates.io yet -- @stjepang could you maybe add me? Thanks!

@yoshuawuyts I think this issue is done.


[CI] Set up workflows

Closes #4

Changes proposed in this pull request:

Set up docker build, codespell, and lint workflows
Set up dependabot

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
[x] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[x] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

:rocket: PR was released in v0.1.0 :rocket:


Wrong argument "store_data" in documentation of SimilarityModel.index()

The method index() from SimilarityModel uses "data" as an argument in the code, but "store_data" is described in the documentation.

Thanks for catching this, fix pushed to master in 6e166711f6774a34cc8c7f4d1a7280d4fed6efb8


Light hint

How can I get a visualisation like the right one?

What kind of light should I use?

80038032{18}.zip

Hello,
The reason the right and left sides look different is because the positions of the lights are different.
On the right side, the light's position appears to be set according to the camera's position.
Please refer to the attached example of setting the light position according to the camera position.

LightHintExample.zip

@hjoykim
I'm having some difficulty with PointLight.
The image rendering is much better with PointLight but compared to the view on the left it remains darker for me: perhaps a positioning problem.
I saved camera position and light info from a threejs model in the "modeldata.dat" file.

Lights.zip
sample_1m_lights.zip


Minor fixes for issues found in our sources

Description
Minor fixes for issues found in our sources

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.48%. Comparing base (3371fd2) to head (e12f8ec).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   95.48%   95.48%
=======================================
  Files          56       56
  Lines        2390     2390
=======================================
  Hits         2282     2282
  Misses        108      108

Files
Coverage Δ

ols/utils/auth_dependency.py
77.55% <ø> (ø)

ols/utils/config.py
100.00% <ø> (ø)

/lgtm
/approve


Roll engine 12bf95fd49b7..db60ebc6325c (20 commits)

https://github.com/flutter/engine/compare/12bf95fd49b7...db60ebc6325c
git log 12bf95fd49b7..db60ebc6325c --first-parent --oneline
2019-12-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from h4iiT... to otkJA... (flutter/engine#14327)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/dart bd008dd1e406..d9fa37e85d5c (1 commits) (flutter/engine#14325)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/skia 5afc7b2af854..75799967be60 (2 commits) (flutter/engine#14324)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/dart bcd18e67dcae..bd008dd1e406 (3 commits) (flutter/engine#14322)
2019-12-11<EMAIL_ADDRESS>Verify accounting for loop counts in Gif and WebP assets is consistent. (flutter/engine#14321)
2019-12-11<EMAIL_ADDRESS>[fuchsia] Do not Execute paint tasks when there is no vsync (flutter/engine#14298)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/dart c74a8ec2c46e..bcd18e67dcae (9 commits) (flutter/engine#14317)
2019-12-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from nqJnP... to UdfLO... (flutter/engine#14316)
2019-12-11<EMAIL_ADDRESS>Roll src/third_party/skia 732c49739fa5..5afc7b2af854 (16 commits) (flutter/engine#14315)
2019-12-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 9C6UA... to h4iiT... (flutter/engine#14314)
2019-12-11<EMAIL_ADDRESS>[web] Update build_web_compilers to 2.7.1 (flutter/engine#14305)
2019-12-11<EMAIL_ADDRESS>Cleanup the IO thread GrContext (flutter/engine#14265)
2019-12-10<EMAIL_ADDRESS>Fix for tab not working (flutter/engine#14165)
2019-12-10<EMAIL_ADDRESS>[SkParagraph] Convert the height override flag in text styles (flutter/engine#14283)
2019-12-10<EMAIL_ADDRESS>Roll src/third_party/dart 02a8b015ad..98c13ba18f (5 commits) (flutter/engine#14280)
2019-12-10<EMAIL_ADDRESS>Remove specificity on Android and iOS (flutter/engine#14282)
2019-12-10<EMAIL_ADDRESS>Create separate objects for isolate state and isolate group state (flutter/engine#14268)
2019-12-10<EMAIL_ADDRESS>Roll src/third_party/dart 8b8894648f..02a8b015ad (26 commits) (flutter/engine#14278)
2019-12-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from Zkpa_... to nqJnP... (flutter/engine#14274)
2019-12-10<EMAIL_ADDRESS>Roll src/third_party/skia e56cc054dbae..ab26643258ad (3 commits) (flutter/engine#14273)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Looks like this manual roll is outdated? I am going to close it.


Trigger cannot handled XML field

hello
nice trigger works for  me at 95%.
i receive an error when trigger is assign to a Table containing a XML field.
Any suggestion how to be able to handle XML field old and new value.
Thank's

Hi,
I didn't had to handle xml field when I were using it.
I will check it in the next few days for a solution.
Maybe I can add a check if it's a xml field and handle it differently.
Thanks.

Hi,
I think the issue should be fixed now.
Here is my test case:
Test table:
DROP TABLE IF EXISTS dbo.Products
GO
CREATE TABLE dbo.Products (
	IDPerson int IDENTITY(1,1) NOT NULL PRIMARY KEY,
	Title varchar(20) NOT NULL,
	Price DECIMAL NOT NULL,
	Qte INT NOT NULL,
	Items XML)
GO

I run the script: "Install audit trail script for SQL Server Database.sql"
Performing some operations:
DELETE FROM dbo.Products

INSERT INTO dbo.Products (Title, Price, Qte, Items)
VALUES ('Aaaa', 10.99, 1, '<items><item>11</item><item>22</item></items>')

INSERT INTO dbo.Products (Title, Price, Qte, Items)
VALUES ('Bbbb', 4.99, 8, NULL)

UPDATE p
SET Price = Price + 10
	, Items = '<items><item>11</item><item>55</item></items>'
	, Title = 'Cccc'
FROM dbo.Products p
WHERE Title = 'Aaaa'

DELETE FROM dbo.Products
WHERE Title = 'Bbbb'

I got the error:
The XML data type cannot be compared or sorted, except when using the IS NULL operator.
The issue look like the comparison of xml fields.
ex:
DECLARE @xml1 XML = ''
DECLARE @xml2 XML = ''
SELECT 1 WHERE @xml1 <> @xml2

The fix were to convert it to varchar(max) before comparison.
DECLARE @xml1 XML = ''
DECLARE @xml2 XML = ''
SELECT 1 WHERE convert(varchar(max), @xml1) <> convert(varchar(max), @xml2)


Convoy-Gluster - Can't reuse volume name after Deleting Volume and Purging

EDIT: This is copied from a from a forum post: https://forums.rancher.com/t/cant-delete-storage-pool-volumes-and-reuse-the-volume-names/1797

Create a stack with a volume using convoy-gluster storage driver
Put some data in the volume
Delete the stack
From the Infrastructure -> Storage Pools page. Delete and then Purge the volume.

Volume should no longer be listed

Recreate the stack. Use the same volume name.
The container creation will fail and you might see a 500 "Couldn't find Volume" or a 404 "no such file or directory" .
Sample 500 error from the rancher server logs:

2016-02-21 00:31:13,114 ERROR [:] [] [] [] [rviceReplay-103] [i.c.p.e.e.i.ProcessEventListenerImpl] Unknown exception running process [instance.start:253938] on [10577] io.cattle.platform.eventing.exception.EventExecutionException: 500 Server Error: Internal Server Error ("Couldn't find volume.")

Sample 404 error from the rancher server logs:
2016-02-20 23:40:59,975 ERROR [c33013a0-c24d-4cb9-9a25-4851e5f68c2d:253519] [instance:10569] [instance.start] [] [rviceReplay-110] [c.p.e.p.i.DefaultProcessInstanceImpl] Unknown exception io.cattle.platform.eventing.exception.EventExecutionException: 404 Client Error: Not Found ("open /var/lib/rancher/convoy/convoy-gluster-f84579f3-1548-43b5-b934-f445bd6011e5/glusterfs/mounts/data01/test: no such file or directory")

There are a lot of containers involved in gluster and convoy, so I'm not sure which logs might help. Please let me know if you would like me to post other logs.
Rancher Versions:
Rancher v0.59.0
Cattle  v0.148.0
User Interface  v0.90.0
Rancher Compose v0.7.2
Test docker-compose.yml
test:
  labels:
    io.rancher.container.pull_image: always
  tty: true
  image: busybox
  volumes:
    - test01:/test
  stdin_open: true
  volume_driver: convoy-gluster
  command:
    - /bin/sh
    - -c
    - while true; do echo hello world; sleep 1; done

Test rancher-compose.yml
test:
  scale: 1

Please let me know if there any other server or container logs you need.

Looks like the fix is going to be to implement /VolumeDriver.List and /VolumeDriver.
I can pull that change in from longhorn work

Tested with latest build from master and convoy agent - rancher/convoy-agent:v0.6.0
When NFS volume is deleted and purged , it is still being listed in host (docker volume ls) and is still present in the nfs server.
@cjellick , Will retest this scenario once deletion of volumes gets fixes.

OK, lets try again @sangeethah.
Use my catalog again. New image is rancher/convoy-agent:v0.7.0

Tested with latest build from master and using rancher/convoy-agent:v0.7.0.
Tested the following scenario:
Create nfs-convoy (v0.3.0)  stack from catalog url - https://github.com/cjellick/rancher-catalog/
Create a stack.
Create as service with a volume name - "testdelete1" using convoy-nfs volume driver
Put some data in this volume
Delete the stack
From the Infrastructure -> Storage Pools page. Delete and then Purge the volume.
Volume is no longer listed in the host.
It is also removed from the nfs server.
Create another stack with service that has same volume name - "testdelete1" using volume driver - "convoy-nfs"
Activate service.
Containers of the service are able to start successfully.
Able to write data into this volume as well.

Not able the test the scenario mentioned in the bug using convoy-gluster , since I see the  convoy-gluster instances keep restarting . I have updated the comments to existing bug - https://github.com/rancher/rancher/issues/3984

@sangeethah do not test any of these convoy bugs against gluster. test against nfs

@cjellick , I have  tested against convoy-nfs and it works. I have already added comments to the bug.
I wanted to make sure that the convoy-gluster scenario which is what is initially reported in the bug works as well before

@cjellick , I have  tested against convoy-nfs and it works. I have already added comments to the bug.
I wanted to make sure that the convoy-gluster scenario which is what is initially reported in the bug works as well before this issue is closed.
Do we need the new rancher/convoy-agent:v0.7.0. to be used by convoy-gluster ?

Ah, ok @sangeethah. Then I think we are on the same page. It is fixed for convoy-nfs, so thats sufficient for GA. This bug can stay open until we get to gluster, which I wont focus on until after GA.

@cjellick , we still want the new convoy-agent - rancher/convoy-agent:v0.7.0 to be used for convoy-gluster for GA , right ?

@cjellick , With the latest gluster-fs version - 3.7.9 , I am able to  create gluster-fs and convoy-gluster stacks successfully. But volume remove is not working.
Steps to reproduce the problem:
Create glusterFS stack
Create convoy gluster stack
Launch a service with volumes using volume-driver convoy-gluster
Delete the service.
remove and purge the volume.
Purged volume continues to be listed in the docker volume ls command:
Also I see this error - "list convoy-gluster: invalid character 'H' looking for beginning of value" when listing docker volumes.
root@sangeemyrc1-10acre-2:/home/sangeethahariharan1# docker volume ls
list convoy-gluster: invalid character 'H' looking for beginning of value
DRIVER              VOLUME NAME
local               f9f5998d80e40031c19274069db0245a2eaabd2eccb3c066e9ec9afbd2f84a55
local               a25506dbda733a505fea83a2b26f4757f8b8aa85d7ec1f5f793fa90a2f257c66
local               fed7bf62e63f0e2755e822128618c27217e9b817b6b9f4167fd7794de9256b3a
local               1d80100d5a14bb6fc42eb4ab0ccee24270a0d0e1e6815e045a9ba02d068d497d
local               cd5b18f15269b4046b9ea7dda1dcc44d3430bfae2cadcf1407ae7c28ceb4d829
local               ee0e649506b3cc03e5bb5f00a109eb196ff74be90e6c64472c341f7572c3cf7e
convoy-gluster      test1
root@sangeemyrc1-10acre-2:/home/sangeethahariharan1#

rancher/convoy-agent -v0.3.0 is being used convoy-gluster instances.

In my own attempts to get convoy-gluster working ( #3670  ) I've come to this point as well - with a test container mounting the my_vol and using the convoy-gluster, I see the above error, but the container is sucessfully created, and a test command to access the glusterfs mount works as expected.
Using
rancher/convoy-agent:v0.3.0 this error is present
rancher/convoy-agent:v0.7.0 presents another error
Error": "BUG: glusterfs.GlusterFSVolume doesn't have required field Name"
https://github.com/rancher/rancher/issues/3568
rancher/convoy-agent:v0.6.0 presents the same as v0.7.0
rancher/convoy-agent:v0.5.0 works as expected

docker volume ls works without error
docker run -d --name test_mount --v a_vol:/data --volume-driver=convoy-gluster guruvan/bash /bin/true && docker run -it --rm --volumes-from test_mount guruvan/bash ls -la /data

shows correct mount & expected files

launching a service with sidekick data container works as expected -glusterfs volume is mounted in the data container with convoy-gluster driver, data is available in service container as expected.

This configuration was achieved by downgrading the convoy-agent images on the fly with a running convoy-gluster service. Storagepool operation with the same convoy-agent image is not yet tested.

similar problem here except in my case the volumes won't delete from the storage pool.  The volume is not mounted anywhere.  This is happening for every volume I delete.  Using Convoy-NFS from catalog. Rancher 1.0.1.
4/29/2016 4:25:59 PMtime="2016-04-29T23:25:59Z" level=error msg="Error processing event" err="Cannot delete volume 1711. Name: gl-var. Error: Cannot delete volume gl-var. It is still mounted\n" eventId=eb1cfa5d-ee7f-4fc2-b2f1-649d476c885a eventName=storage.volume.remove resourceId=1vspm901

@cloudlady911 @guruvan To focus on the original issue, would you be able to create new separate issues as your use cases are slightly different. Thanks!

This issue has been fixed for Convoy-nfs, but is still an underlying issue for convoy-gluster

I am not using Convoy at this time, so you can just remove my question.
On Mon, Jun 6, 2016 at 10:53 AM, Denise<EMAIL_ADDRESS>wrote:

@cloudlady911 https://github.com/cloudlady911 @guruvan
https://github.com/guruvan To focus on the original issue, would you be
able to create new separate issues as your use cases are slightly
different. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rancher/rancher/issues/3671#issuecomment-224035645,
or mute the thread
https://github.com/notifications/unsubscribe/ALYDajTXg24NfXfmtdvTujQlPi5siS0sks5qJF6cgaJpZM4HfsGT
.

--
Laurie Kepford
*AWS *
Certified Solutions Architect
Cell:<PHONE_NUMBER>
email<EMAIL_ADDRESS>LinkedIn: www.linkedin.com/
http://www.linkedin.com/pub/laurie-kepford/2/392/6a5/

Hi @deniseschannon, I'm use Convoy-Gluster and have many troubles because this issue. There are any chance to this issue be included in future version?

Closing due to inactivity, please reopen if you think this is still relevant to current releases & important.  ConvoyNFS is being replaced with RancherNFS.  Please use that and open a new ticket if you are hitting similar issues for RancherNFS.


Project picker: Consider keyboard support and/or filter

It's painful to pick the right project in a long list. I would like to:

Be able to filter
Be able to start typing the project name in the drop-down

Will see if we can just use a combobox, the keyboard should work though...


Logged out vs logged in homepages are very different

Context
During Dockstore storytime today, Julian and I mentioned that Dockstore's homepage should maybe contain some of the information currently on our docs. We then remembered that what a logged out and logged in user sees is different. Even outside the context of documentation though, I think the juxtaposition is a little jarring, and honestly, I really like the look of our logged out homepage and want to see it more often.
Is your feature request related to a problem? Please describe.
We seem to be assuming that anyone who is logged into Dockstore has already been sold on Dockstore as a platform and knows how it works, as our homepage for logged in users is totally different than the homepage for logged out users. I'm not sure if that's the approach we should be taken.
Describe the solution you'd like
Logged in users should see something like the logged out homepage, with a link that takes them to a "dashboard" or something similar which shows what is the current logged in page.
Additionally, I think "recent activity" should be at the top of the logged in user page/dashboard, rather than a news section followed by links to featured material.
Describe alternatives you've considered

No "dashboard"; logged out and logged in users see the same thing almost everywhere.
Logged out users see the "news" section that logged in users see.

Additional context

┆Issue is synchronized with this Jira Story
┆friendlyId: DOCK-2145
┆sprint: Backlog
┆taskType: Story

Note: this is part of the zeplin-based UI redesign


Reject null bodies in REST API

When sending an empty body to an endpoint, instead of throwing a parse exception, Jackson returns null which breaks some of our endpoints.

@drexin, do you think a part of this solution would be that Jackson (or some other selected JSON library) should raise on parsing empty body? Wondering if there is another library to use that would handle this better, or if we can contribute to Jackson.

@hekaldama We started moving over to play-json wich will error on null bodies.

@drexin cool. I was trying to grab this cause it is labeled "good first bug". Is someone already working on it then?


fix(jsx/dom): Fixed a bug that caused Script elements to turn into Style elements.

Script elements with empty props or only src were inserted as style elements by typo.
The author should do the following, if applicable

[x] Add tests
[x] Run tests
[x] bun run format:fix && bun run lint:fix to format the code

@usualoma
Thanks! Merging now.


feat: Add basic key-value pair field support

Hi @pnehrer , thanks for the useful crate!
I recently used this crate in a project that made heavy use of the slog support for key value pairs and added some basic support to this library for serializing those to a new field, slog.fields and thought I would contribute that change upstream in case it would be useful for others as well.
Feel free to decline this PR if you don't think this kind of addition makes sense here. I gated the new functionality behind a kv feature because it does have some slight allocation overhead per log generated if a key-value pair is in use. I made this feature opt-out but would be happy to swap that to opt-in.

Thank you for your submission @lpraneis! I'll have a look and provide feedback shortly.


Upgrade to babel 6.0

This message currently gets printed when installing via npm.

npm WARN deprecated<EMAIL_ADDRESS>Babel 5 is no longer being maintained. Upgrade to Babel 6.

Will upgrade, thanks for reporting it

I actually tried to do the upgrade. It seems that is not something possible without finding how to make the babylon parser to understand the bind short hand "::". Something not really that possible.

It is very easily solved. Use the stage-0 preset since the function bind operator is in stage zero.
Alternatively you can add just the function bind plugin.

@LinusU  not really, esformatter-jsx in reality uses babylon, not babel-core. as I mention, I made the changes to use babylon here if you can configure babylon to make the tests pass it would be awesome! I won't have time to investigate it this weekend.
Regards

Ah, I see, thanks for explaining. I'll try to have a look at it :)

@LinusU actually your suggestion drove me in the right direction. I was successful replacing babel-core with babylon. I had made a major release, since I don't know what other syntax might be needed to be enabled.
<EMAIL_ADDRESS>won't print that deprecation warning.

Super, thank you!


Removed from Ansible Galaxy?

The following page returns 404.
https://galaxy.ansible.com/mivok0/users/
Is this role no longer published in Ansible Galaxy?

+1

+1

Oops, didn't mean to close this.
@mivok transferred ownership of the ansible-users repo back in November 2016. After doing so, the mivok0 galaxy link continued to work which seemed like a good thing.
However, due to this issue I had to delete and re-add the role in galaxy in order to import any new releases. After deleting and re-adding the role, the mivok0 link ceased to exist anymore. Apologies if this caused any trouble/confusion.
The correct link is now https://galaxy.ansible.com/singleplatform-eng/users/.

I see, thanks!

I see this is now
https://galaxy.ansible.com/singleplatform_eng/users
or singleplatform_eng.users with an _ instead of a -


Overloading "profile" term

I'm concerned that using "Profile" as the parameter name will confuse users who've been trained to interpret "profile" as their Windows PowerShell profile (e.g. about_Profiles).
Also, given that the Profile parameter takes a variable or file name, but not a hash table, users are likely to create a $Profile variable that replaces their $Profile automatic variable.
Can we use something like Arguments or ParamHash?

Thanks for the suggestion.
We will use "Configuration" (instead of profile)
https://github.com/PowerShell/PSScriptAnalyzer/commit/b09da3cf56c75b0a2cb072fdd454b39b347e7f42

I'd be happier and more feel it would be more appropriate if it was called RuleSet as that's essential what it will be.
Configuration latches onto the DSC area and we should be staying away from typical Commonly used keywords IMO
Many Thanks
Ryan
http://uk.linkedin.com/in/ryanyates90
https://www.twitter.com/ryanyates1990https://mobile.twitter.com/ryanyates1990
Follow my Blog at http://www.kilasuit.org/
Organiser of Get-PSUGUK Manchester
Co-organiser of Get-PSUGUK London
www.get-psuguk.orgx-apple-msg-load://9DA9AF0F-2E26-4E4B-9A7F-E675C39B794F/www.get-psuguk.org
Co-organiser of PSConfEU www.psconf.eux-apple-msg-load://9DA9AF0F-2E26-4E4B-9A7F-E675C39B794F/www.psconf.eu
On 25 Nov 2015, at 21:01, Raghu Shantha [MSFT] <notifications<EMAIL_ADDRESS>wrote:
Thanks for the suggestion.
We will use "Configuration" (instead of profile)
b09da3chttps://github.com/PowerShell/PSScriptAnalyzer/commit/b09da3cf56c75b0a2cb072fdd454b39b347e7f42

Reply to this email directly or view it on GitHubhttps://github.com/PowerShell/PSScriptAnalyzer/issues/350#issuecomment-159730592.


New dsl groovy scripts

Thank you for submitting this pull request
JIRA: (please edit the JIRA link if it exists)
BXMSPROD-1012
referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

referenced pull request 1
referenced pull request 2
referenced pull request 2
etc.

How to retest a PR or trigger a specific build:

* a pull request please add comment: Jenkins retest this

Jenkins retest this


I only can use Lightning node pro...

Hey !
First at all, forgive my english.
I'm using an arduino Micro (32u4). I tried this with the Lightning Node Pro, and everything work fine in Icue.
But, when I choose LT100 ou LS100, my Arduino is still recognize as Nightning Node Pro...
How to do ? Anyone else had this issue ?

Hey !
First at all, forgive my english.
I'm using an arduino Micro (32u4). I tried this with the Lightning Node Pro, and everything work fine in Icue.
But, when I choose LT100 ou LS100, my Arduino is still recognize as Nightning Node Pro...
How to do ? Anyone else had this issue ?

Choose LS100 instead of Node Pro when choosing a board model.
Tools- Devices - LS100
I have the same scarf and everything works fine.

Thank you so much ! It works. I just choosed it on exmaple.
Have a nice day ;-)


JOSS REVIEW: paper doesnt reference all figures

In the paper 8 figures are used showing various graphs which are all very well done but only figures 1 and 3 are referenced in the text.  It would be good to see the others referenced and more detail given to what they show and there relevance.

@https://github.com/openjournals/joss-reviews/issues/6841

looks much better and really adds context and detail to the figures.  thanks


perf: update to latest miniforge, since mambaforge is deprecated and miniforge nowadays contains both mamba and conda

It seems like the task runs the installer with -u: https://github.com/IKIM-Essen/EMCP-config/blob/97636d71fdd926d981ee83f20ccc5c9444bae917/ansible/roles/mambaforge/tasks/mambaforge.yml#L31-L35
IIRC, the "update" functionality of (Conda-)constructor-created installers is not very sophisticated and does not uninstall previously installed packages, i.e., the environment is not very "clean" afterwards.
With an update from Miniforge <24.5 we'd, e.g., end up with 2 different python installs since we updated python to 3.12 in Miniforge 24.5.0.
This is at least how I remember things (haven't looked into constructor for a long time).
So, you definitely want to make sure to test this out on one/a couple of nodes before rolling it out generally.
If it indeed works as pictured above, we may want to change that task's step to always do a clean install via something along the lines of
if [ -e '{{ mamba_home }}' ]; then
  mv '{{ mamba_home }}' '{{ mamba_home }}'.old
  if ! { /tmp/mambaforge.sh -bp '{{ mamba_home }}' && '{{ mamba_home }}/condabin/conda' --version | grep -F '{{ mambaforge_conda_version }}'; }; then
    if [ -e '{{ mamba_home }}' ]; then
        mv '{{ mamba_home }}' '{{ mamba_home }}'.deleteme
        rm -rf '{{ mamba_home }}'.deleteme
    fi
    mv '{{ mamba_home }}'.old '{{ mamba_home }}'
    exit 1
  else
    rm -rf '{{ mamba_home }}'.old
  fi
else
  /tmp/mambaforge.sh -bp '{{ mamba_home }}'
fi

(N.B.: The above is untested/just quickly written down and might not be without fault (e.g., using trap would be cleaner).)

Following Marcel's comment, I've added a commit which deletes the current installation if it's different from the one being installed. It doesn't implement the revert logic from the suggested script, but it takes into account that Ansible stops on failure, leaving cleanup to the user in case of a failure in the middle of the run. I think it's enough for normal operation, but it can be expanded if needed.

@mbargull I've added a commit taking your feedback into account. From your table above, I'm handling the "matches" and "differs" cases explicitly. The "unknown" case is handled implicitly by the installer given that it fails if the installation directory already exists.

If the logic looks ok to you, Johannes can go ahead and test it.

This has been deployed to almost all nodes.
Thanks everyone!


PoS for fox-ess

PoS for fox-ess
https://github.com/StealthChesnut/HA-FoxESS-Modbus
https://github.com/rsaemann/HA-FoxESS-H3-Modbus
https://community.home-assistant.io/t/foxess-inverter-modbus/459313
https://pl.fox-ess.com/wp-content/uploads/2021/08/AIO-User-Manual.pdf

start with H1-6.0-E

https://www.eevblog.com/forum/dodgy-technology/foxess-inverter-ethernet-data-to-pc-data-and-other-monitoring-lie/


call "exportTo" instead of "export" in iMachine.export_to(...)

As described in https://github.com/mjdorma/pyvbox/issues/40, I had to change the call to "export" to "exportTo" to make export_to(...) work with the latest VirtualBox version 5.0.8 r103449; this fix is possibly required for all 5.x.y versions and should probably be done conditionally based on the version of the underlying VirtualBox package for backwards compatibility; unfortunately, I don't know how to determine that version...

Was trying to create a separate pull request for the typo fix, but it seems my github skills are limited :-/

Thanks for the PR.
I dropped off the planet for a few months.  This change will be included in the latest distribution which moves support to the 5.0.x interface.
Cheers


Fix num bug in QueueList

fixes #4722

Looks good, can you add a test?

no. because it doesn't surface anywhere

If it's not surfaced anywhere can we delete it?

@brettfo Looks like the count of elements in the collection is used as part of a heuristic here: https://github.com/Microsoft/visualfsharp/pull/4727/files#diff-fdeacbc4b3c85e494b84658903f6e4f9R16
The fix is good, I don't think it will make any real difference either way but we may as well have correct code.

Yes it only fixes the push heuristic
Don Syme<EMAIL_ADDRESS>schrieb am Do., 19. Apr. 2018, 00:48:

@dsyme approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/pull/4727#pullrequestreview-113418702,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNIt53Dgaxca75O7PT4QvUAFiCQ6Uks5tp8LYgaJpZM4TV9b6
.


Cancel safety for channels

Hi,
I would like to know if the Recv future is cancel safe. Such that it could be used in a select! Macro.
I read the other issue about a select! and know that a select can create some annoying issues.
Thank you!

The futures in this crate are cancel safe. Let me know if you have any other questions.


[DUOS-1740][risk=no] Update @types/react 18.2.33 -> 18.2.35

Addresses
https://broadworkbench.atlassian.net/browse/DUOS-1740
Summary
Update types react to latest

Have you read Terra's Contributing Guide lately? If not, do that first.

Label PR with a Jira ticket number and include a link to the ticket
Label PR with a security risk modifier [no, low, medium, high]
PR describes scope of changes
Get a minimum of one thumbs worth of review, preferably two if enough team members are available
Get PO sign-off for all non-trivial UI or workflow changes
Verify all tests go green
Test this change deployed correctly and works on dev environment after deployment

Dependabot will update this


[#115403965] Disable debug logging for Cloud Controller

What
The logs from cloud_controller_ng are nedlessly verbose as they contain every single SQL query performed against the ccdb - We wish to make the logs less verbose as they are currently very difficult to search through when necessary.
There are two parameters within the manifest which control logging from the cloud_controller - db_logging_level sets the logging level at which all db query messages will be regsitered, whereas logging_level defines the level at which logs will be emitted from cloud_controller_ng and fed into syslog. The distinction between these two logging values is poorly documented, but important to understand - If db_logging_level is set to a value of error then the totallity of the SQL query logs will be emitted when logging_level is set to a value equal or higher than error (e.g. error, warn, info, debug etc).
The different logging levels available are described in https://github.com/cloudfoundry/steno#log-levels
How to review this PR.

Deploy as per the instructions in the README.md
After deployment has completed, bosh ssh onto the api_z(n) nodes and check the cloud_controller_ng config file in /var/vcap/jobs/cloud_controller_ng/config/cloud_controller_ng.yml - observe that logging.level is set to info and that db.log_level is set to debug
Examine /var/vcap/sys/log/cloud_controller_ng/cloud_controller_ng.log logfile - You should note that log messages are now emitted with a logging_level of info, and that the SQL debug logs are no longer no longer included by default.

Who can review this PR.
Anyone on the team with the exception of @combor and @jimconner

Works correctly.


Custom directives

Hey 👋🏻
I was wondering whether custom directives are supported inside the <script setup> tag.
From my current test it seems they are not but I might do sth. wrong 🤔
Example component:
<script setup>
// enables v-focus in templates
const vFocus = {
  mounted: (el) => el.focus()
}
</script>
1
<template>
  <input v-focus />
</template>

UPDATE
Seems that const focus = {} works but const vFocus = {}  does not.

Try move vFocus to another file and import this.


Added Icons to Navbar

Hello Project Admin
I Added Icons to Navbar - Solved #2734
Kindly Please go through this PR @anuragverma108

@anuragverma108 kindly please go through this PR

this issue isnt assigned yet and you created a PR?!! it is against our code of conduct! also the icons on nav is not looking good!!

Yeah okk no problem @huamanraj

Now I see that git assigned me I thought it was assigned to me

Yeah okk no problem @huamanraj

do open new relevant issues anytime i will assign that! 😊

Okk Thank you @huamanraj ☺


Adds lcov report to srcview

Summary of the Pull Request
Adds lcov report generation to srcview alongside cobertura
PR Checklist

[ ] Applies to work item: #xxx
[x] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
New public Report::lcov() API for generating lcov reports from modoffs
Validation Steps Performed
Generate an lcov file
cargo run lcov foo.pdb foo.coverage.txt foo.coverage.info

Validated against popular lcov html report generation tool genhtml.perl
perl genhtml.perl coverage.info --no-prefix

Codecov Report

Merging #3226 (c7a8eda) into main (512bb07) will decrease coverage by 3.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3226      +/-   ##
==========================================
- Coverage   29.55%   25.63%   -3.92%
==========================================
  Files         332      152     -180
  Lines       39199    16293   -22906
==========================================
- Hits        11584     4177    -7407
+ Misses      27615    12116   -15499

see 180 files with indirect coverage changes

What is the current status of this PR? Found that I might be needing this feature implemented as well.

This PR has been moved to an internal fork. And can be closed, as srcview is not maintained nor owned by onefuzz.


[feaLib] take in a path or a file-like object

as discussed in https://github.com/behdad/fonttools/issues/443#issuecomment-199252850 and following comments

Looks good to me.


some questions about select_data

Hi @leoxiaobin
Thanks for sharing your excellent work!
I am curious about following line in the select_data function in you code.
metric
metric = (0.2 / 16) * num_vis + 0.45 - 0.2 / 16

num_vis is the number of labelled joints.
Would you please explain how to calculate the metric?
Is 16 the number of symmetric joints in coco dataset?
Do you use the select_data only in COCO dataset？
What is 0.45 ?
Why minus 0.2 / 16?
Why select those data which are greater than the metric?
if ks > metric:
                db_selected.append(rec)

greater than the metric

The code is for experiments of 14/20 http://presentations.cocodataset.org/COCO17-Keypoints-TeamOKS.pdf, but we did not use in our simple baseline.

Thank you!


View log buttons on bottom are either cut off or missing when text in logs

Steps:

Go to Pods
Show the cattle-system namespace
Select View Logs for one of those pods

results:  Since the log is full, you can't see the buttons on the bottom.  As more info goes it, the buttons slowly get cut off the bottom as well.

Design of View logs has changed so this issue isn't valid anymore.


[Bug]: Grouping widgets in a Modal makes the resulting container move to the main canvas

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When I group multiple widgets which are in a modal, the resulting canvas  automatically moves to the main canvas, rather than staying in place
https://user-images.githubusercontent.com/20532920/148173902-7fa57daf-d300-4a32-bcd5-5de1e2301208.mov
Steps To Reproduce

Create a modal
Select the 2 existing buttons (close and confirm)
Group them

Environment
Production
Version
Cloud

@riodeuno @rahulramesha is this something we'll be able to cover as part of the Dynamic Height or  Copy Paste Improvements project?

@vuiets This seems like a bug with grouping. I have seen this in the Form widget as well. We should pick this up as a bug fix. @jsartisan Could you help triage this as this seems related to the grouping feature.

Stats

Stat
Values

Reach
120

Effort (months)
0.5

For reach,
People using modals in their apps in the last 6 months: 1223
Expect about 10% of these to group widgets in the modal: 120
Added effort as 2 person-weeks for this but feel free to correct me if wrong here.

This is a duplicate of https://github.com/appsmithorg/appsmith/issues/12320, Which was fixed in https://github.com/appsmithorg/appsmith/pull/13658. Closing this.
cc: @btsgh


Configure ring buffer depth at build time

Description
This PR leverages stackrox/falcosecurity-libs#11, which makes it possible for us to configure the desired ring buffer depth when compiling the collector userspace component and drivers. Right now the depth is set in 2 separate places, we might want to refactor our build system to make it possible to configure both the userspace and driver builds from the same point in the repo.
Merge order for the PR:

[x] Merge #601 into master.
[ ] Merge stackrox/falcosecurity-libs#11 into master
[ ] Change this PR to point to the new commit in the master branch of stackrox/falcosecurity-libs and merge into master.

Checklist

[ ] Investigated and inspected CI test results
[ ] Updated documentation accordingly

Automated testing

[ ] Added unit tests
[ ] Added integration tests
[ ] Added regression tests

If any of these don't apply, please comment below.
Testing Performed

[ ] Double check the configured ring buffer depth is the same when building userspace and drivers.
[ ] Rebuilding all drivers works.
[ ] Drivers themselves work.

This PR is outdated, #1343 will already enable this.


Crashing upon preparing a world's spawn

Using griefprevention-1.12.2-<IP_ADDRESS>9 with project worlds. The issue im having with this is that when the multiple worlds start preparing their spawn gp freaks out for some reason.
[EDIT] I forgot to include a paste of console. https://pastebin.com/jCCFn7dn

GP <IP_ADDRESS>9+ requires Spongeforge 1.12.2-2768-7.1.6-RC3610+
Recommended Spongeforge to use is 1.12.2-2768-7.1.6-RC3616 at this time.


Issue with rule edit

While creating the rule in the UI, we probably spotted some wrong behavior: Try to create a criteria based on the slack channel name (trigger.channel.name). While it is possible to do that during rule creation, the save button will be disabled if you ever want to edit the rule again and do not delete the criteria referring to trigger.channel.name again:
"criteria": {
    "trigger.text": {
      "pattern": "^Comment on <https://github\\.com/.*$",
      "type": "matchregex"
    },
    "trigger.channel.name": {
      "type": "contains",
      "pattern": "git"
    }
  },

Note : report came in via support

The suggestion box in StackStorm does not show any nested attribute of trigger.channel, I guess this is related to the same root cause

@jonico Same as #184—you can expect some progress later this week. :) Thanks a lot for reporting!


Update dependencies

Most notably, rebase onto Kubernetes v1.25 (which is the base to OpenShift v4.12).
A prerequisite of OSASINFRA-2981

/retest

/retest

/retest

The CI failure is unrelated:

job history
bug report

@mandre can you override CI?

/override e2e-openstack-nfv-intel
/approve

Let's try again, with the correct incantation this time.
/override ci/prow/e2e-openstack-nfv-intel


Publish-Module failure "Publish-PSArtifactUtility : The property 'Count' cannot be found on this object.

Attempting to publish a module fails with the error in the title. I have tried with PowerShellGet <IP_ADDRESS> on multiple machines and I get the same error. I'm still exploring if there is a work around and will include additional info as I figure out more.
Expected Behavior
I would expect my module to be published.
Current Behavior
VERBOSE: Repository details, Name = 'PSGallery', Location = 'https://www.powershellgallery.com/api/v2/'; IsTrusted =
'False'; IsRegistered = 'True'.
VERBOSE: Using the provider 'PowerShellGet' for searching packages.
VERBOSE: Using the specified source names : 'PSGallery'.
VERBOSE: Getting the provider object for the PackageManagement Provider 'NuGet'.
VERBOSE: The specified Location is 'https://www.powershellgallery.com/api/v2/' and PackageManagementProvider is
'NuGet'.
VERBOSE: Searching repository 'https://www.powershellgallery.com/api/v2/FindPackagesById()?id='WintellectPowerShell''
for ''.
VERBOSE: Total package yield:'1' for the specified package 'WintellectPowerShell'.
VERBOSE: Performing the operation "Publish-Module" on target "Version '<IP_ADDRESS>' of module 'WintellectPowerShell'".
Publish-PSArtifactUtility : The property 'Count' cannot be found on this object. Verify that the property exists.
At C:\Users\john\Documents\WindowsPowerShell\Modules\PowerShellGet\<IP_ADDRESS>\PSModule.psm1:1227 char:17
+                 Publish-PSArtifactUtility -PSModuleInfo $moduleInfo `
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Publish-PSArtifactUtility], PropertyNotFoundException
    + FullyQualifiedErrorId : PropertyNotFoundStrict,Publish-PSArtifactUtility

Possible Solution
Still experimenting as to possible fixes.
Steps to Reproduce (for bugs)

Use the open source module I am trying to publish: https://github.com/Wintellect/WintellectPowerShell/tree/7763b350c4d80de9c48cc3229dcdaf6d842de23c
Execute .\Support\UploadWintellectPowerShell.ps1 to run the Publish-Module command (provide your own API key as a parameter)

Context
This is the first I have tried publishing my updated <IP_ADDRESS> version. I've had no trouble publishing in the past.
Your Environment

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.15007.1000
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15007.1000
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

> Get-Module
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Computer, Add-Content, Checkpoint-Computer, Clear-Con...
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Security       {ConvertFrom-SecureString, ConvertTo-SecureString, Get-Acl...
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Manifest   <IP_ADDRESS>    Microsoft.WSMan.Management          {Connect-WSMan, Disable-WSManCredSSP, Disconnect-WSMan, En...
Script     <IP_ADDRESS>    PackageManagement                   {Find-Package, Find-PackageProvider, Get-Package, Get-Pack...
Script     <IP_ADDRESS>... Posh-Git                            {Add-SshKey, Enable-GitColors, Get-AliasPattern, Get-GitDi...
Script     <IP_ADDRESS>    PowerShellGet                       {Find-Command, Find-DscResource, Find-Module, Find-RoleCap...
Script     1.2        PSReadline                          {Get-PSReadlineKeyHandler, Get-PSReadlineOption, Remove-PS...
Script     <IP_ADDRESS>    WintellectPowerShell                {Add-NgenPdbs, Compare-Directories, Expand-ZipFile, Get-Du...

> Get-Module -ListAvailable PowerShellGet,PackageManagement

    Directory: C:\Users\john\Documents\WindowsPowerShell\Modules

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-Packa...
Script     <IP_ADDRESS>    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}

    Directory: C:\Program Files\WindowsPowerShell\Modules

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Binary     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-Packa...
Script     <IP_ADDRESS>    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}

> Get-PackageProvider
Name                     Version          DynamicOptions
----                     -------          --------------
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, ...
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

> Get-PackageProvider -ListAvailable
Name                     Version          DynamicOptions
----                     -------          --------------
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, ...
PowerShellGet            <IP_ADDRESS>
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

Here's some additional findings:
In my .psd1 file, I had CmdletsToExport = '@()' because the PSSCriptAnalyzer reported that my original setting of CmdletsToExport = '*' was a warning. When I commented out the line, I got a little further and now it's not liking spaces in my tag
 #CmdletsToExport = '@()'

The above line is the issue! I guess you shouldn't be reporting an empty array on PSD1 files.

@JohnWintellect
Please note the single quotes around @() in your module manifest file.
CmdletsToExport = '@()' should be CmdletsToExport = @().

Thanks! Yes, that is true. However, I would vote for a better error message that would point to the cause a little more directly. :)

@JohnWintellect This should be handled in Test-ModuleManifest cmdlet. Do you agree?

Yes! That's an excellent idea. Also, changing the PSSCriptAnalyzer rule that told me to change '*' to '@()' would be good too.

@kapilmb @chunqingchen Could you please take a look at this and open corresponding issues in your GitHub repositories?

for the test-modulemanifest part, i have created issue:
Adding '@()' check in test-modulemanifest #3016 track this

Closing as already tracking in https://github.com/PowerShell/PowerShell/issues/3016


Additional tests for connection

Tests for increasing code coverage for Connection Management Service, Connection Utils, and Connection Store

Coverage increased (+0.2%) to 35.416% when pulling 9e938f774499cd2694cc617f85d81d6d89effe2a on alex/additionalconnectiontests into 381a747b623f877db5f58970e2c72838c54691d1 on main.


Link order generation to state machine

Moving order generation to state machine transition from doctrine persist event. #281
Solve #174 #235 adding some state configuration :
winzou_state_machine:
    sylius_payment:
        callbacks:
            after:
                sylius_invoicing_plugin_order_placed_producer:
                    on: ['complete']
                    do<EMAIL_ADDRESS>'__invoke']
                    args: ['object.getOrder()']
                sylius_invoicing_plugin_payment_complete_producer:
                    disabled: true
    sylius_order:
        callbacks:
            after:
                sylius_invoicing_plugin_order_placed_producer:
                    disabled: true

I had to use the identifier instead of the number, because the order number is not yet persisted to the entity at the time of the transition.

Hello @ehibes !
Why do you change all the orderNumber references to id ?
Changing the moment where the invoice item is created could help.

I did it because orderNumber was not yet generated.

I made changes according to you reviews. PhpSpec & behat tests passed. I don't know how to add your behat scenario...

I made changes according to you reviews. PhpSpec & behat tests passed. I don't know how to add your behat scenario...

Perfect, thank you for your work, I will ping the devs about it to start approving it 😉

Yes it will avoid getting the issue again indeed 👌

I love this feature.
Can I help with anything on those falling checks? Let me know if I can.


Non-authenticated users or users without access are circularly redirected to the homepage

To reproduce this behavior:

Attempt login with a non-consortia, unauthenticated email (either Google or Auth0 work for this purpose)
You should be redirected to the homepage
Attempt to login again by clicking on the login button

You can force yourself to the login page by repeatedly clicking on the login button (not sure why this works)
Desired behavior is:
"if you try Google auth but have not signed the embargo or not part of the consortia you get redirected to a proper error page"

The two cookies that seem to be persisting the user state are named auth0 and auth0_compat. Deleting these two auth cookies seems to stop the circular redirect. Possible using the "react-cookies" package to clear these cookies could help.

The auth0 and auth0_compat cookies are HttpOnly, so don't appear when trying to list using document.cookie or the "react-cookie" package. May need to simply make a logout call without redirecting when routed to the error page.


Hub(s) 'undefined'

Hi, thanks, I'm enjoying the hue node-red integration.
One issue I've noticed…I have two bridges, and both appear in the UI as 'undefined' in the pop-up. How can I rename the devices?
Thanks, Terry

The Unknown is probably some bug. I use the nuPnP function to detect the devices, this only returns name and id. To get the device node I would need to create another step that queries the devices for their names, which is non trivial (timeout handling).
When you create an bridge node you can set your own name that will be used when configuring the lights.

The Unknown is probably some bug. I use the nuPnP function to detect the devices, this only returns name and id. To get the device node I would need to create another step that queries the devices for their names, which is non trivial (timeout handling).
When you create an bridge node you can set your own name that will be used when configuring the lights.

Thanks, sounds like that’s not worth the effort.
When I add a bridge node, I don’t see an option to name the Bridge/s. In my setup I have either Hue Pull or Hue Set, neither seems to offer an option to define the name for the Bridge(s). Apologies if I’m missing something obvious.
Thanks, Terry

When adding an hue input/output node you need to add/select bridge node, on this page you can set the name of the hub
input/output node

bridge node

That’s interesting, but not what I see, see attached.

When adding an hue input/output node you need to add/select bridge node, on this page you can set the name of the hub
input/output node
bridge node

"Hue Pull" and "Hue Set" is the nodes from "node-red-contrib-hue" which is another hue package


Generate Testbench when benchmark have BUS PORT

When running OpenFPGA with "openfpga_shell_scripts/write_full_testbench_example_script.openfpga", with the benchmark uses ports that are wider than 1 bit
In the testbench that is auto generated:
counter REF_DUT(
		.clk_counter(clk_counter),
		.rst_counter(rst_counter_shared_input),
		.q_counter_0_(q_counter_0__benchmark),
		.q_counter_1_(q_counter_1__benchmark),
		.q_counter_2_(q_counter_2__benchmark),
		.q_counter_3_(q_counter_3__benchmark),
		.q_counter_4_(q_counter_4__benchmark),
		.q_counter_5_(q_counter_5__benchmark),
		.q_counter_6_(q_counter_6__benchmark),
		.q_counter_7_(q_counter_7__benchmark)
	);

, but file verilog is generate by Yosys is
module counter(
clk_counter,
rst_counter,
\q_counter[0] ,
\q_counter[1] ,
\q_counter[2] ,
\q_counter[3] ,
\q_counter[4] ,
\q_counter[5] ,
\q_counter[6] ,
\q_counter[7]
);

This causes an error when runs vvp_verification
**_```

error: port q_counter_0_'' is not a port of REF_DUT. error: port q_counter_1_'' is not a port of REF_DUT.
error: port q_counter_2_'' is not a port of REF_DUT. error: port q_counter_3_'' is not a port of REF_DUT.
error: port q_counter_4_'' is not a port of REF_DUT. error: port q_counter_5_'' is not a port of REF_DUT.
error: port q_counter_6_'' is not a port of REF_DUT. error: port q_counter_7_'' is not a port of REF_DUT.

@anhdv2000 Please refer to the bus group support: https://github.com/lnis-uofu/OpenFPGA/tree/master/openfpga_flow/tasks/basic_tests/bus_group/auto_gen_bus_group/config