Histogram colors do not match map colors, especially 0

The histograms that accompany the map layers on the left panel also act as a kind of legend.
For some reason, the colors represented do not always match the full range of colors on the map.
Here is GHG Intensity for example.
Histogram:

Map:

The blue color in particular, is not represented, although that is the color for total_ghg_emissions_intensity = 0
This is not a new issue, and has probably been present all along. In fact there is a cryptic explanation by way of a comment in the building_bucket_calculator.js colorGradient prototype function:

// This is how we calculate the colors for the dots on the map.
// But they don't line up with the colors in the histogram. Why not?
// The domain is "fieldValues", which is an unordered list of all of the building value for this field.
// But the domain for the histogram color ramp is just linear max and min for the given field.
// And more importantly, it needs to be the max and min that's set according to the config file. That's how the colors get determined in the histogram

The config file seattle.json does set the proper min and max.
Here's total_ghg_emissions_intensity:
        {
            "title": "Seattle GHG Intensity",
            "field_name": "total_ghg_emissions_intensity",
            "display_type": "range",
            "range_slice_count": 18,
            "section": "Greenhouse Gas Emissions",
            "color_range": ["#1f5dbe","#599b67","#ffd552","#da863f","#ab2328"],
            "hatch_null_css": true,
            "unit": "Kilograms CO₂e/ft²",
            "formatter": "fixed-1",
            "filter_range": {"min" : 0, "max" : 10},
            "

So I don't know if this is an oversight, or what exactly is going on

The way this works is incredibly complicated and circular

D3 is used to set up a quantile scale, based on the color range specified in seattle.json and the values for the given variable. In the case of total_ghg_emissions_intensity, that amounts to a domain of ~3600 values, and a range comprised of the original colors spread across 18 derived colors (unclear why not let d3 derive the colors in the scale function itself? Most likely to give a bigger spread to the map, which is hard wired CartoCSS ranges, not D3 functions, see below).

But then, when the actual color is applied to a bar on the historgram, the xpos of the bar (a pixel value?) is fed into yet another D3 scale (linear), before getting passed to the original quantile colorScale.

This same quantile scale is used indirectly to make the CartoCSS. In the end, to me, this seems much more akin to a threshold scale (directly specify the cut values that separate the classes) than the original quantile scale (intervals of similar sizes), as you can see in the resulting CartoCSS statements and the code. Each "stop" is derived from a call to d3.scale invertExtent on each color in the range - which is the equivalent of a threshold

The end result is that a value of 0 gets the expected color value for 0 on the map, but in the original scale function (xPos passed to a linear scale, passed to a quantile scale), a value of 0 is assigned to the color class #b5bb5b, which is the 7th position of 18 in the defined range, even though the actual data value is 0.

(18) ['#1f5dbe', '#306fa5', '#40808c', '#519273', '#6ba165', '#90ae60', '#b5bb5b', '#dac857', '#ffd552', '#f7c34e', '#efb24a', '#e6a045', '#de8f41', '#d57b3c', '#ca6537', '#c04f32', '#b5392d', '#ab2328']

Questions and observations

I have no idea what the original intent was behind passing the bars x-position through a linear scale, prior to getting the color from a quintile scale. It kind of works, but I don't understand the logic whatsoever.
Colors in the map will be different than colors on the historgrams because the methods used to compute them are totally different
Using a quantile scale to develop thresholds for the map kind of seems like a bad idea. They should use the same scale concept to the extent possible
If we didn't have to pass this through CartoCSS/Carto, we could use the exact same D3 scale to color both the map and the histogram

After a bit more thought, I think this is a wontfix
Each bar in the histogram represents a large range, not a discrete value. That's what the linear scale on the xpos is trying to model
The first bar in Total Seattle GHG Emissions, for example, isn't just representing 0, it's representing a range of values, something like 0 - 20 (there are no scales printed, so it's not easy to say exactly):

Buildings, on the other hand, are painted according to a specific value for that one building.
There is no way to "fix" this. The histogram is not a legend, it is a broad brush stroke showing the range and distribution of all the values

This came up again in today's call. I think my notes above are still valid. There is however an easy way to get a better visual idea of what is going on, and that is to increase the range_slice_count in seattle.json for any single map layer.
Here's what it looks like if we increase range_slice_count from 18 to 100 for "Total Seattle GHG Emissions" (total_ghg_emissions):

With that, it's much more obvious that

There are a lot of buildings with very low values (blue and green)
These are not visible when there are fewer bins, because that color variation gets collapsed to a single greenish yellow

Not sure if that's a solution to the issue, but it can at least serve as additional explanation

Seems like another way to mitigate this issue would be to use fewer buckets again, eg 18, but then set the max to a lower number, like 100, so the upper bucket gets bigger and the smaller buckets are better distributed across the color scheme

Unfortunately, although this does bring the values further down into the blue/green range, the sheer number of buildings that get lumped in with 100+ makes it more difficult to see any kind of distribution pattern
Here's 18 buckets with a max of 100:

Here's 18 buckets with a max of 200:

Finally, 18 buckets with 300:

That last one is maybe the best. At least there's a decent indication of values that are not strictly yellow-red.

Belatedly realized the above snaps had the building type restricted to high rise multifamily.
300 is significantly better with all building types showing:

Current plan:

First remove or recalculate buildings that have isCompliantFlag false as null for GHG and other measures (separate issue, not yet submitted)
This should in principle remove many of the lowest blue buildings that are not showing up well in the histogram
Also modify the upper limit of the histograms to optimize for showing the full color range

I believe this is all set, total_ghg_emissions has a filter range of 0 to 300


Fix usage of -with-rtsopts

When I added -qg to the default RTS options in
57cfa03c23047bb0c731428e97ca716d9a1cf312 (#385) I neglected to consider that it
the -with-rtsopts flag would override the previous flag setting -I0. This
had the effect of reenabling idle GC, causing GC time to regress terribly. I
likely didn't notice this since I had passed the flags directly to the hadrian
executable with +RTS while testing.
Moreover, I mistakenly wrote -qg0, which (somewhat confusingly)
actually enables parallel GC. Instead I wanted to write -qg.

Thanks @bgamari, merged!


make plugin configurable

allow a 'custom' menu command that sources tree command options from a config

created milestone


Moved zedUpload under eve/libs and made it its own module.

Hey @kalyan-nidumolu -- I see you pushed new commits -- is there anything I should be looking for that addresses "wait, before we merge this -- shouldn't it be hooked up to our build (and as a result CI/CD)? How else would we know that it is still functional @kalyan-nidumolu ?"

Hey @kalyan-nidumolu -- I see you pushed new commits -- is there anything I should be looking for that addresses "wait, before we merge this -- shouldn't it be hooked up to our build (and as a result CI/CD)? How else would we know that it is still functional @kalyan-nidumolu ?"

Ring0 ran after the changes. Its pretty much taking care of Yetus errors / warnings. No change in logic.

Handle return values

Original code ignored return values. I fixed it by assigning return values to _

Removed unused code as flagged by yetus.
Removed unreachable statements as flagged by yetus
Removed variables that were set, but not used
Ignored 1 lint error as it needed newer aws version

_, _ = io.Copy(writer, creader)

Filed a pivotal story to properly handle the return calls. What I did just addressed Yetus for these errors - formally ignore return values. We should ideally check them and take appropriate action.


Add contact details module

Coverage decreased (-0.2%) to 40.017% when pulling 1081e35c8506512bd63754e55af3d4d86f2f035e on ele828:contact-details into 65ba5f3f846ced61625914bb00ba093d080d72be on ringcentral:master.

Coverage decreased (-0.2%) to 40.022% when pulling 2853d0a8f7c8ab0fa75ec85f7433e1a944895af4 on ele828:contact-details into 65ba5f3f846ced61625914bb00ba093d080d72be on ringcentral:master.


[SPARK-25248] [CORE] Audit barrier Scala APIs for 2.4

What changes were proposed in this pull request?
I made one pass over barrier APIs added to Spark 2.4 and updates some scopes and docs. I will update Python docs once Scala doc was reviewed.
One major issue is that BarrierTaskContext implements TaskContextImpl that exposes some public methods. And internally there were several direct references to TaskContextImpl methods instead of TaskContext. This PR moved some methods from TaskContextImpl to TaskContext, remaining package private, and used delegate methods to avoid inheriting TaskContextImp and exposing unnecessary APIs.
TODOs:

[x] scala doc
[x] python doc (#22261 ).

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2563/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2566/
Test PASSed.

Test build #95280 has started for PR 22240 at commit c2624ed.

Test build #95280 has finished for PR 22240 at commit c2624ed.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95280/
Test FAILed.

Test build #95329 has started for PR 22240 at commit 7e2975b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2602/
Test PASSed.

Test build #95329 has finished for PR 22240 at commit 7e2975b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95329/
Test FAILed.

retest this please

Test build #95361 has started for PR 22240 at commit 7e2975b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2627/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2641/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95379 has started for PR 22240 at commit 365e7b8.

Test build #95379 has finished for PR 22240 at commit 365e7b8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95379/
Test FAILed.

test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2656/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95398 has started for PR 22240 at commit 365e7b8.

Test build #95398 has finished for PR 22240 at commit 365e7b8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95398/
Test FAILed.

retest this please

Test build #95418 has started for PR 22240 at commit 365e7b8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2670/
Test PASSed.

Test build #95418 has finished for PR 22240 at commit 365e7b8.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95418/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2806/
Test PASSed.

Merged build finished. Test PASSed.

Test build #95639 has started for PR 22240 at commit b6a3c5b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2807/
Test PASSed.

Test build #95640 has started for PR 22240 at commit ae4a8e6.

Test build #95639 has finished for PR 22240 at commit b6a3c5b.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95639/
Test FAILed.

Test build #95640 has finished for PR 22240 at commit ae4a8e6.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95640/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2808/
Test PASSed.

Test build #95641 has started for PR 22240 at commit 47ebd08.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2809/
Test PASSed.

Test build #95642 has started for PR 22240 at commit c61eec3.

Test build #95641 has finished for PR 22240 at commit 47ebd08.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95641/
Test FAILed.

Test build #95642 has finished for PR 22240 at commit c61eec3.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95642/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2814/
Test PASSed.

Test build #95648 has started for PR 22240 at commit 9b6a47b.

Test build #95648 has finished for PR 22240 at commit 9b6a47b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95648/
Test FAILed.

Test build #95661 has finished for PR 22240 at commit 9b6a47b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95661/
Test PASSed.

LGTM

Merged into master. Thanks for review!


fix: Hacky fix for running the experimental scheduler when spawning task

Until I figure out the best solution (which hopefully is close).
Pushing just to benchmark and test stuff successfully.
To run the tokio console debugger:

Download the CLI:cargo --locked tokio-console

Build/Run local with new just commands (along with --debug-tokio flag):just run-debug-tokio local --debug-tokio

NOTE: This builds in a new target directory: unstable-tokio-target so as to not mess up with existing target directory (which can cause issues with LSP etc.).

is it possible to require/switch to the new scheduler via the command line.

No, unfortunately have to set it for the session.


New Endpoint: UTxOs with specific assets

Is your feature request related to a problem? Please describe.
It is not a problem per se but I believe the community would benefit from this query. The Beacon Token standard I am trying to create allows for fully p2p dApps such as these. They do not require any middle-men (batchers) due to using dedicated NFTs for indexing the UTxO set. In addition to this, since there are at least as many UTxOs as there are users, the concurrency of these p2p dApps scales with the number of users.
Blockfrost has this query that I have been using for the proof of concepts. Koios does not have an equivalent endpoint.
Describe the solution you'd like
To reach the full potential of using beacon tokens, there needs to be an endpoint for getting the information for all UTxOs with a specific asset. Blockfrost requires first knowing the address but ideally it should be a direct query. The query should require a policy id but optionally take an asset name like this Koios query.
Describe alternatives you've considered

Using both Blockfrost and Koios. Blockfrost does not allow querying based only on the policy id while Koios does not allow querying UTxOs with a specific asset. Neither application can be used in isolation since both queries are required for some p2p dApps. This is not ideal since Blockfrost is centralized and requires its own api key.
Getting all the UTxOs from the address using Koios and filtering the UTxOs locally. This would put a burden on the end user who may be trying to interact with the dApps from a smartphone or light wallet. It would be better if the endpoint did the filtering.

Additional context
The query response should return:

The address where the UTxO is located.
The tx hash.
The output index.
The asset balance for the UTxO.
The datum hash.
The inline datum (if present).
Whether or not it has a reference script.

The query can also return other information but these are the things I need for the p2p dApps.

There is already asset_txs endpoint , which will be enhanced further with utxo_info as part of #186 . Unlike other API layers, you currently do (and will have with utxo_info) ability to specify multiple utxos in bulk to utxo_info endpoint

@rdlrt Will the enhanced versions have a way to query UTxOs that have a specific combination of assets? For example, "show me all UTxOs that have asset X AND asset Y". It is okay if there are other assets in the UTxO but it would need to have at least the supplied assets.

asset_utxos  would provide that, yes..while address_utxos (the original request) in linked issue already has that in desired output fields

I am asking to have the Koios database do the filtering before sending the response to the end user.

well with asset_utxos, you would be able to supply multiple assets and return utxos relevant to those assets only from server side. If instead you want to go from address -> utxo, that will not be done on free tier as it predominantly spams the servers allowing queries against tokens with millions of utxos going from address > utxo > ma_utxo joined with asset.
Ofcourse, with a dedicated infra plan - custom queries will be possible. The idea is giving a mid-way between viable options (that are sustainable in long term) on public tier, while non-sustainable exponentially increasing data to be queryable on custom solutions with desired filters using dedicated tiers

/asset_utxos added in #227 , where you can submit multiple assets as input query, and filter output to only return address if needed, also has _extended flag which could be set to true to list out asset_list or any scripts associated

I would like this issue to be re-opened because the new /asset_utxos endpoint does not actually satisfy what I am looking for.

For example, "show me all UTxOs that have asset X AND asset Y". It is okay if there are other assets in the UTxO but it would need to have at least the supplied assets.

I only want UTxOs returned if they have both asset X and asset Y. The current endpoint has two issues:

It returns UTxOs that have at least one of the assets specified. In other words, it is matching asset X OR asset Y.
The returned asset list only seems to contain the asset that was matched, even if the UTxO contains more than just that asset. This may be a bug?

I only want UTxOs returned if they have both asset X and asset Y. The current endpoint has two issues that make it unsuitable for my use case:

It returns UTxOs that have at least one of the assets specified. In other words, it is matching asset X OR asset Y.

Note that utxos endpoint by itself will list entire details, the server-side filtering can be done within URL itself, which is not specific to this endpoint, but valid across all Koios gRest API endpoints - and gives wide array of options for you to filter on. Your use case sounds like the below:
curl -sX POST -H "content-type: application/json" 'http://<IP_ADDRESS>:18050/rpc/asset_utxos?asset_list=cs.[{"fingerprint":"asset1fzp34lzx6zm59fsr94jh2ev98ll6xnsdheldzt"},{"fingerprint":"asset1qcezj4ju2c0an65t8ql4f92dfhp9md3jykfssp"}]' -d '{"_asset_list":[ ["46f987f7ed1886ba771b077c3ed5bbf3df158f54e0e3fa88d3d1e46e","744345525241"], ["ac54f96ff8a6952a0d803a435839ab64c99f4037a5a1ee9ba9349bcd","74575254"] ], "_extended": true }' -g

As regards your second point, thanks for flagging it was indeed the case - fixed on preprod , and being actioned by instance providers on other network.
curl -sX POST -H "content-type: application/json" 'http://<IP_ADDRESS>:18050/rpc/asset_utxos?asset_list=cs.[{"fingerprint":"asset1fzp34lzx6zm59fsr94jh2ev98ll6xnsdheldzt"},{"fingerprint":"asset1qcezj4ju2c0an65t8ql4f92dfhp9md3jykfssp"}]' -d '{"_asset_list":[ ["46f987f7ed1886ba771b077c3ed5bbf3df158f54e0e3fa88d3d1e46e","744345525241"], ["ac54f96ff8a6952a0d803a435839ab64c99f4037a5a1ee9ba9349bcd","74575254"] ], "_extended": true }' -g | jq -r '.[].asset_list[].fingerprint' | sort | uniq -c | sort -n

Let us know if I am missing something.

Awesome. Thanks for showing the example. I had to move the -g flag to the beginning of the curl command but otherwise everything is working now. I appreciate the quick response.


Set DPAI to correct ksp version

Fixes https://github.com/KSP-CKAN/CKAN-meta/pull/1270

What is making it set a min_version of 1.2.0? When I run on the existing netkan, I get a clean 1.3.0 ksp version, as per Spacedock. Was it wrong on Spacedock? I can't see an AVC .version file in the 6.6.0 download I have.

Ah, that explains it.  I uploaded 6.6.0 to spacedock originally with the wrong .version file in it. I noticed this within a minute, so re-uploaded the zip file with a fixed .version file, but the NETKAN scrape must have occurred by that point.
What's the easiest way to rectify this - should I delete 6.6.0 on spacedock and submit a new version?

 I dont have to remind myself to add the vref back in for the next release.

Alright, I'll publish 6.7.0 just to make everyone's life easier!
On Wed, May 31, 2017 at 2:30 PM, Arne Peirs<EMAIL_ADDRESS>wrote:

I you want to do that, go ahead. I dont have to remind myself to add the
vref back in for the next release.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/KSP-CKAN/NetKAN/pull/5565#issuecomment-305323494, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADXbOy7ETJhtqimcJE1ve9lR77maC5yZks5r_dv-gaJpZM4NsMUs
.


BUG [USER] 'About' button on the menu block is dissabled on the registration page when the Tabulation is used

Steps to reproduce:

Go to the https://ita-social-projects.github.io/GreenCityClient/#/welcome
Click on the "Sign up" link in the upper corner
Verify the tabulation on the 'About' button
Expected Result:
Buttons and links are selected while tabulation is used
Actual Result:
The 'About' button is not tabulated on the registration page

Environment: Chrome Версія 80.0.3987.122 (Розробка) (64-розрядна версія) Windows7 Ultimate
#352

Not relevant


Resolved: python2 can't use after brew upgrade

brew升级后python2不能用的解决方案

brew install python@2

rm -rf /usr/local/bin/python
rm -rf /usr/local/bin/pip
rm -rf /usr/local/bin/python-config
sudo ln -s<EMAIL_ADDRESS>/usr/local/bin/python
sudo ln -s<EMAIL_ADDRESS>/usr/local/bin/python-config
sudo ln -s<EMAIL_ADDRESS>/usr/local/bin/pip

vim .bash_profile，add：
export PATH="/usr/local/Cellar/python@2/2.7.14_3/Frameworks/Python.framework/Versions/2.7/bin:/usr/local/Cellar/python@2/2.7.14_3/bin:$PATH"

Check:
python --version
python3 --version
pip --version
pip3 --version
virtualenvwrapper is ok.

None of that is necessary. Please read https://github.com/Homebrew/brew/blob/master/docs/Homebrew-and-Python.md#python-3x-or-python-2x
In the future, please always fill out the issue template. Also, please note that this is the wrong repository for formula specific issues.

@ilovezfs Thank you very much. I will fill out the issue template next. Thank you!


add support postgresql as storage backend

add support postgresql as storage backend

Thanks for the help.
This looks like a straight port of the mysql one, right?
We do have demand, but if we added it, we should use the v2 codebase (ex
you can look at the cassandra or elasticsearch ones for an example). Also
we'd want to consider the schema, if it is best or not.

if doing postgresql, let's make the schema a bit quicker. Everything is v2 type now, so it should be possible!
#1232


sbt 1.9.6 still seems to have the Zinc issue

sbt 1.9.5 generates Zinc compiler errors when running ScalablyTyped. Version 1.9.6 also seems to exhibit the same problem:
info] ZincCompiler.scala:234 msg.get() Non-compiled module 'scala2-sbt-bridge' for Scala 2.13.12. Compiling... [project => <project-name>, ms => 25084]
/var/folders/0c/mqgg_cgs2fddcd981gkpvbfc0000gn/T/sbt_8c978be6/scala/tools/xsbt/API.scala:20: error: not found: object xsbti
import xsbti.api._
       ^
/var/folders/0c/mqgg_cgs2fddcd981gkpvbfc0000gn/T/sbt_8c978be6/scala/tools/xsbt/API.scala:21: error: not found: object xsbti
import xsbti.VirtualFile

sbt 1.9.4 works fine.

Thanks for the report. Could you provide reproduction steps so we can reproduce your problem on our computers or on GitHub Actions?

I was hoping the error messages would be the same you referred to in the 1.9.6 release notes.
I have a project using Scala 2.13.12, Scala.JS, Vite, and ScalablyTyped.
package.json should have JS dependencies that are transformed by ScalablyTyped, which then fails with the above message.
If you don't have something similar lying around, I can try to set up a minimal project over the next few days.

Non-compiled module 'scala2-sbt-bridge' for Scala 2.13.12. Compiling...

Is it actually compiling the bridge? Seems like it ought to be using a retrieved binary bridge

I can try to set up a minimal project over the next few days.

yes please, that's what we need in order to diagnose this

It doesn't need to be a minimal project necessarily, is your project open source?
It seems very likely that this needs to be addressed in the ScalablyTyped sbt plugin. @eed3si9n maybe it's easy for you to spot? https://github.com/ScalablyTyped/Converter/blob/f593f499941944e5a373e3c7c42c88ca95b60875/sbt-converter/src/main/scala/org/scalablytyped/converter/internal/ZincCompiler.scala#L128-L151
cc @oyvindberg; the corresponding change in sbt: https://github.com/sbt/sbt/pull/7374/files. For Scala 2.12.13 and newer we publish compiler bridge as a binary jar with every Scala release.

Thanks for the ping. Tracked in https://github.com/ScalablyTyped/Converter/issues/565

Seems like a fairly straightforward plugin issue, so I'll close this out. Thanks for the pointers @lrytz

Thanks guys!


Example plot fails (tickfont_pointsize) (Plots regression)

See this comment

This is a Plots regression. I reported it.

This was fixed and will be in the next Plots release (1.27.3).


DataFrame indices can't map through dictionaries or series

A DataFrame index has the map function, which expects a mapper. However, unlike mapping a Series, it only accepts callables, and won't work when mapping through dictionaries or series.
Code Sample:
df = pd.DataFrame({'col1': range(5)})
d = {0: 'zero', 1: 'one', 2: 'two', 3: 'three', 4: 'four'}
df.col1.map(d) # perfectly valid
df.index.map(d) # TypeError: 'dict' object is not callable
s = pd.Series(d)
df.col1.map(s) # perfectly valid
df.index.map(s) # TypeError: 'Series' object is not callable

Expected Output:
I would expect the same output for df.col1.map(s) and df.index.map(s), or at least that it returns an nparray with the mapped values, as it does when we do pass a callable, but not that it breaks like it does.
output of pd.show_versions():
INSTALLED VERSIONS
commit: None
python: 2.7.6.final.0
python-bits: 64
OS: Linux
OS-release: 3.16.0-67-generic
machine: x86_64
processor: x86_64
byteorder: little
LC_ALL: en_US.UTF-8
LANG: en_DE.UTF-8
pandas: 0.18.0
nose: 1.3.7
pip: 8.1.1
setuptools: 20.6.6
Cython: 0.23.5
numpy: 1.11.0
scipy: 0.17.0
statsmodels: 0.6.1
xarray: None
IPython: 4.1.2
sphinx: 1.4
patsy: 0.4.1
dateutil: 2.5.2
pytz: 2016.3
blosc: None
bottleneck: None
tables: None
numexpr: 2.5.1
matplotlib: 1.5.1
openpyxl: 2.3.4
xlrd: 0.9.4
xlwt: None
xlsxwriter: None
lxml: 3.6.0
bs4: None
html5lib: 0.9999999
httplib2: 0.9.2
apiclient: None
sqlalchemy: 1.0.12
pymysql: None
psycopg2: 2.6.1 (dt dec pq3 ext lo64)
jinja2: 2.8
boto: 2.39.0

@sinhrks and I had this exact discussion very recently: https://github.com/pydata/pandas/pull/12532#discussion_r57884489
so yes, these should be unified, but are a bit non-trivial to do so. welcome to have pull-requests!

Yes, currently I think Index.map should be fixed prior to #12532. Will take a look.

xref #12766


Add AppendCommandTest & made small bug fixes

Added test for append command and made minor bug fixes! Will work on remove command test soon

When you merged with master I think you didn't keep the changes made (like the command usage in remove), so I reverted your revert of those changes lol (6766a42)


Auto-inject event metadata in exception logging

When one of my event handlers fails, I want to be able to find the event and event chain by simply looking up the correlation ID. At the moment I have to inject the Metadata as parameter and manually log this, which is annoying and prone to errors/omissions.
I was looking into extending the loggers with an annotation scanner to see if an eventhandler annotation is present, but I still need the Axon framework to inject the metadata parameter...
Any suggestions on how to solve this problem in a different fashion are also always welcome!

Event Handling in Axon has two layers of Exception handling:

The ErrorHandler in the EventProcessor
The ListenerInvocationErrorHandler in the EventHandlerInvoker (read: object that wraps your Event Handling classes)

Level 2 is what you should be looking at, which the framework defaults to a LoggingErrorHandler.
For your specific use case, I would provide another implementation of the LoggingErrorHandler that additionally pulls the correlation ID from the EventMessage#getMetaData().
Configuring this can be done by using the EventProcessingConfigurer#registerDefaultListenerInvocationErrorHandler(Function<Configuration, ListenerInvocationErrorHandler>) for example, thus setting your custom LoggingErrorHandler for every Event Handler you have.
Although doable to put the entire MetaData object permanently in any of the Logging Handlers in Axon (albeit the ListenerInvocationErrorHandler or the MessageDispatchInterceptor/MessageHandlerInterceptor) I think is overdoing it a little. Some users might have quite a lot of MetaData entries which would obstruct the usefulness of the log message I assume.
As such, I will be closing the issue for now, hoping that my suggestion to provide a custom LoggingErrorHandler will be sufficient in your use case.
Feel free to further the discussion after this though, as any suggestions are always welcome.


Seems that autoscaler can be applied to multiple node pools now?

This page states that 'Cluster autoscaler should only be tested in preview on AKS clusters with a single node pool.'
But I find that when a cluster has multiple node pools, autoscaler still can be set for every node pool, using 'az aks nodepool update' command, and this page seems to be outdated.
So, I wonder that when there are multiple node pools, which node pool will be selected to scale out? What's the mechanism behind?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077f1bb5-2ba9-490c-2c6e-0de292266539
Version Independent ID: 0fd87b4f-88a4-c2eb-3ebc-f2b113ac203c
Content: Use the cluster autoscaler in Azure Kubernetes Service (AKS)
Content Source: articles/aks/cluster-autoscaler.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@dpatrickx Thank you for your query. We will investigate and update the thread further.

@dpatrickx Thanks for the feedback. I am assigning the issue to the author for adding his comments.

@mlearned Can you please add your comments.

will verify today.

@dpatrickx you are correct, we now support a cluster autoscaler setting per node pool. We are in the process of fixing/refactoring all the docs for this and can add in more of the details.
You are able to select specific scale operations per nodepool now, these will abide by min/max pods per nodepool as long as it has been enabled for it. When using multiple nodepools you'll need to specify which nodepool you want to scale by passing in the node pool name.
This is all still driven by the cluster autoscaler upstream project being instrumented on your cluster: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler


Add Armeria version metric

Hello, I've added Armeria version metric.
Motivation:

Want to check Armeria version with Grafana
FYI:
In Prometheus best practices, this kind of metric is described as follows.
https://prometheus.io/docs/practices/naming/

foobar_build_info (for a pseudo-metric that provides metadata about the running binary)

e.g.
# HELP node_exporter_build_info A metric with a constant '1' value labeled by version, revision, branch, and goversion from which node_exporter was built.
# TYPE node_exporter_build_info gauge
node_exporter_build_info{branch="master",goversion="go1.7.5",revision="840ba5dcc71a084a3bc63cb6063003c1f94435a6",version="0.14.0"} 1

Modifications:

Add Armeria version metric

Result:
It's exported as follows
Labels:

commit
version

# HELP armeria_build_info A metric with a constant '1' value labeled by version and commit hash from which Armeria was built.
# TYPE armeria_build_info gauge
armeria_build_info{commit="74700d402178e00045b1ca23006f7f6131b2a92d",version="0.94.1-SNAPSHOT",} 1.0

example dashboard:

That is awesome, @matsumana. I love it! What do you think about adding other labels such as repoStatus whose value is clean or dirty?

What do you think about adding other labels such as repoStatus whose value is clean or dirty?

Sounds good.
Added!
# HELP armeria_build_info A metric with a constant '1' value labeled by version and commit hash from which Armeria was built.
# TYPE armeria_build_info gauge
armeria_build_info{commit="74700d402178e00045b1ca23006f7f6131b2a92d",repostatus="dirty",version="0.94.1-SNAPSHOT",} 1.0

I added repostatus, not repoStatus.
I followed node_exporter's label naming.
e.g.
node_filesystem_free{device="/dev/sda2",fstype="ext4",mountpoint="/"} 8.4968587264e+10

I added repostatus, not repoStatus.
I followed node_exporter's label naming.

Oh, just found this comment. Armeria currently is using camel case convention for label names, e.g. hostnamePattern, so I changed it to repoStatus. Do you think we should make them all lower-cased?

Oh, just found this comment. Armeria currently is using camel case convention for label names, e.g. hostnamePattern, so I changed it to repoStatus. Do you think we should make them all lower-cased?

It was my misunderstanding.
I remembered that you guys were discussing about metrics naming conventions in a issue/PR before, so I misunderstood that you are going to migrate from camelCase.
Thank you for changing the label.
Could you merge?

Ah, it was about meter names rather than label names :-) Will merge soon!

Much appreciated, @matsumana ! :+1:


Fix popup text

Signed-off-by: Philipp Meyer<EMAIL_ADDRESS>Fix popup text of upload message, so that it corresponds to the action upload.

[x] Ensure that the commit message is a good commit message
[x] Change in CHANGELOG.md described
[x] Screenshots added (for UI changes)

Can one of the admins verify this patch?


NFT Website Clone

Project title
NFT Website Clone
Project Description
It is clone of a NFT Single page Website of Solana
Web stack
HTML, CSS
Screenshot(mandatory)

Additional Context(mandatory)
It is responsive with all types of devices.
Are you contributing under any open-source program ?
Kwoc 2023

@anand-harsh Welcome to METAVERSE!!!!!!!!
Please go through contributing.md before contributing.

@anand-harsh Are you contributing this issue in CODEPEAK'23 also?

Yes @apu52


Issues with Gulp Test

Configuration:
Web browser and its version: Firefox 56.0.2
Operating system and its version: Ubuntu 14.04.5 LTS / macOS 10.13.3
PDF.js version: Latest
Is a browser extension: No
Steps to reproduce the problem:
1. npm install -g npm@latest
2. npm install -g gulp-cli
3. git submodule init
4. git submodule update
5. npm install
6. npm update
7. gulp makeref
8. gulp test
What went wrong?
Server running at http://<IP_ADDRESS>:65521/
2018-08-17 13:23:02.258 Google Chrome[23477:1473136] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36
TEST-PASS | eq test filled-background-range | in Chrome
2018-08-17 13:23:03.864 plugin-container[23510:1473640] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x8303, name = 'com.apple.tsm.portname'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:03.993 plugin-container[23510:1473640] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x837f, name = 'com.apple.coredrag'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:04.073 plugin-container[23515:1473713] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x6d07, name = 'com.apple.tsm.portname'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:04.172 plugin-container[23515:1473713] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x6d47, name = 'com.apple.coredrag'
See /usr/include/servers/bootstrap_defs.h for the error codes.
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
2018-08-17 13:23:04.526 plugin-container[23521:1473844] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x7143, name = 'com.apple.tsm.portname'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:04.631 plugin-container[23521:1473844] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x713f, name = 'com.apple.coredrag'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:05.096 plugin-container[23527:1473986] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x6f3f, name = 'com.apple.tsm.portname'
See /usr/include/servers/bootstrap_defs.h for the error codes.
2018-08-17 13:23:05.195 plugin-container[23527:1473986] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x7ba7, name = 'com.apple.coredrag'
See /usr/include/servers/bootstrap_defs.h for the error codes.

I get this output when attempting to run PDF.JS tests. I have not seen these errors before in previous runs. Some tests continue to pass after these errors, however, I am not sure what is causing these errors to begin with.
Once tests complete, the program hangs. It opens a Chome window with reftest-analyzer.html and shows several pdf's. This is also a new and unexpected behaviors that I have not had in the past. I can  not seem to find any information on the Wiki about what to do with this window.
Any information about these errors and the reftest window would be great.

The analyzer only shows up when one or more reference tests failed. It allows you to see why the reference test failed, i.e., it compares the reference image to the snapshot made in the tests and shows the differences. This is normal behavior and also happens on our bots. For example, see http://<IP_ADDRESS>:8877/2e32685a6b7f20b/reftest-analyzer.html from a recent pull request. You can click the failed reference test and compare the before/after snapshots.
However, the fact that the reference tests fail directly after makeref should not happen. I'm not sure if those errors are all related though; I have seen more verbose logging on the bots lately too, presumably because of browser updates and/or PDF.js patches, and https://github.com/mozilla/geckodriver/issues/706 seems to indicate that this should not really be a problem.
Could you try upgrading to the most recent Firefox version to see if that helps?

Sorry about that, I made a mistake when listing my browsers. I actually am running the tests on Firefox and Chrome on their latest versions.
Are there any other troubleshooting steps I should attempt? I am performing these steps on the latest code in master.
As for the ref tests, is there a way to execute gulp test without opening this window? I can not seem to find a way to make the process terminate other than forcing it.

You can try using gulp botmakeref and gulp bottest instead since that is what we use on our bots. It will run the tests in headless mode and should not open any windows.


isNaN shouldn't be considered a number

One of the reasons I've chosen Flowtype is to get rid of NaN crazyness in my team's code.
I expect functions not to return NaN if I annotate them to return number.

IMHO this should not be valid. Any reason why we should care this JS legacy in Flow?
Cheers

It's hard to track when operations might return NaN. Say we do ban NaN: number, In your example, what would you expect to happen when you do divide(0,0)? Right, we'd have to say that the return type of divide is number | NaN or something like that, then force NaN checks on all callers of divide. So the question really is, would that be a net benefit?

I think numbers should stay as they are, but it would be nice to have a separate type for finite numbers (no NaN or Infinity).
Then we can define signatures of operators as following:
 + : (number, number) => number
 + : (number, finite_number) => number
 + : (finite_number, number) => number
 + : (finite_number, finite_number) => finite_number

 / : (finite_number, finite_number) => number

etc

+1 for finite type.
That said, it'd be a nice DUX to somehow in my first image, get an alert.
It'd make more sense to get this alert due to params that I'm expecting rather than what's returning.
Elm way of handling is sort of cool:

plot twist: you'd agree Number.MAX_VALUE is finite, right?
(Number.MAX_VALUE + Number.MAX_VALUE) === Infinity // true

I would strongly support to add the type finite.
To get away from the headache how exactly it should behave, I suggest to use Lodash isFinite function as Blueprint (with unavoidable minor modification, unfortunately, see below).
It has been there for ages for a good reason, even before Lodash existed, as one of the core utilities from Underscore, and Lodash still defers to it:
https://github.com/lodash/lodash/blob/master/vendor/underscore/underscore.js#L1311-L1314
// Is a given object a finite number?
_.isFinite = function(obj) {
    return !_.isSymbol(obj) && isFinite(obj) && !isNaN(parseFloat(obj));
};

Note it does not use the native Number.isFinite function
(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite),
but instead the less predictable global isFinite
(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite),
perhaps for historical reasons.
What we likely don't want is this:
isFinite('1') // true

Which also caused people some headaches:
http://stackoverflow.com/questions/5690071/why-check-for-isnan-after-isfinite
The signature is affected by several constants incl. Number.MAX_VALUE:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
However, the resulting type depends on the value (instead of only type):
Number.isFinite(Number.MAX_VALUE + 1) // true, because of the rounding
Number.isFinite(Number.MAX_VALUE + Number.MAX_VALUE) // false

So what can we do?
I personally would stay sane and regard Number.MAX_VALUE as NOT of type finite.
That makes type checking really dead simple:

Any expression involving Number.MAX_VALUE, Number.MIN_VALUE, Number.MAX_SAFE_INTEGER, Number.MIN_SAFE_INTEGER is automatically NOT of type finite.

The reasoning: If you have any of those inside your code, you are at clear risk of getting infinities. So the mere reason you put  type finite is that you want to be warned about those risks.
And perhaps, to avoid questions like "why is that not of type finite even when Number.isFinite says so", make a clear statement that finite is not a native type.

Just to attempt some clarification. As a professional mathematician, I would like to have a proper mathematical type for real numbers. That would be clean and intuitive to anyone not familiar with implementation details.
The basic idea is simple. Mathematics clearly defines what real numbers are and what operations are permitted. Entities like Number.MAX_VALUE fail that definition. Entity like

Number.EPSILON: The smallest interval between two representable numbers

is not mathematically distinguishable from 0. Therefore, it must be treated as 0 for real-number typechecking purposes.
In other words, only mathematically unambiguous real numbers can be whitelisted. Only for them, algebra rules guarantee operational safety. All other entities may lead to potential bugs.
As example, this function should be considered safe:
function safeSquare (x: finite): finite {
    return x * x
}

The fact that it might get evaluated to Infinity at run-time by JS engine bares no difference, because that result can only be a side-effect of the current engine implementation. That may well change in the future. Or the result will depend on the engine. Or the platform. Or the OS...  But people writing code know that. They don't need to be warned their argument x might get too large. After all, it is not the fault of the library maintainer if the consumer tries the library with all possible crazy values. Which includes Number.MAX_VALUE. In fact, those numbers normally have no place in my code.
But here is the real problem -- what if some puts this number somewhere in the code for presumably "legitimate" purpose. Or your dependency third party library has it somewhere down the code. Then, if there is any risk, I want to be warned!
Here is a concrete example of unsafe function where I want to be warned:
function unsafeDivide (x: finite, y: finite): finite {
    return x / y
}

Here there is a clear risk that y is 0 or close to it.
On that other hand, that one would be safe:
function safeDivide (x: finite, y: nonzero): finite {
    return x / y
}

So I need the type nonzero. Or it needs to be inferred from the context.
The type nonzero signature can be again defined mathematically following the risk-free principle:

The result of any expression is whitelisted as having the desired type T if and only if it guaranteed to be evaluated to the desired type at the run-time.

For instance, the above function unsafeDivide cannot guarantee it, so it fails the type check. The above function safeDivide guarantees safety, so it passes.
Note that this guarantee philosophy is orthogonal to JavaScript's don't fail at any cost. The latter tells you that 1/0 === Infinity or 1/-0 === -Infinity, throw this back into your expression and hope for the best ;) And, as will all know, our hopes can be fullfilled sometimes. But sometimes they aren't. Which is why we are here ;)
Yes, it makes a perfect business sense to keep your app running suppressing all those errors that might be of no relevance to the user. Or the user will be presented with the payment bill of 1e+30 dollars. ;)
That no one forces the user to accept.
But in 98% cases, it is probably ok to move on, and the user won't even notice.
But the fact that if users don't notice, or did not notice yet, does not mean it is ok if your code has room for potential bugs. In contrast, we do want to see this failure to catch that bug. Which is why we are here.
 It should not be a human task to write all imaginable unit tests to safeguard again all possible troubles. Not even mention, many teams don't even bother writing tests at all or write only minimum possible. The right "person" to deal with this problem is the compiler!

Any expression involving Number.MAX_VALUE, Number.MIN_VALUE, Number.MAX_SAFE_INTEGER, Number.MIN_SAFE_INTEGER is automatically NOT of type finite

This is not enough, any expression involving should not evaluate to finite as well.

would like to have a proper mathematical type for real numbers

I think it's impossible to use javascript numbers for this.

This is not enough, any expression involving should not evaluate to finite as well.

Exactly what I tried to say by "NOT of type finite":

Any expression involving non-mathematical entities fails the finite type check.

I think it's impossible to use javascript numbers for this.

What are the problems?

I meant to say, any expression involving finite. There is nothing special about Number.MAX_VALUE, you can get it by adding two finite numbers

What are the problems?

For starters, real numbers are an infinite set, javascript numbers are a finite set

I meant to say, any expression involving finite. There is nothing special about Number.MAX_VALUE, you can get it by adding two finite numbers

Adding two of those numbers will give you Infinity. That is what is special.
Therefore my proposal to fail them for being finite.

What are the problems?
For starters, real numbers are an infinite set, javascript numbers are a finite set

How is this a problem for my proposal?

@dmitriz

Adding two of those numbers will give you Infinity

Not true, (8.988465674311579e+307 + 8.988465674311579e+307) ===  Number.MAX_VALUE

How is this a problem for my proposal?

It's not a problem with your proposal, it's a problem with 'proper mathematical type for real numbers' idea

The fact that it might get evaluated to Infinity at run-time by JS engine bares no difference, because that result can only be a side-effect of the current engine implementation. That may well change in the future. Or the result will depend on the engine. Or the platform. Or the OS...

This behavior is part of the spec and is not implementation-dependent:
http://www.ecma-international.org/ecma-262/6.0/#sec-ecmascript-language-types-number-type
Unfortunately I don't think this is something that Flow will be able to prove.


Please provide an example using UI-Router in separate modules as recommended in Styles Y270 and Y271

Can you provide an example of how to use UI-Router's $stateProvider to set up my states in multiple modules?
Per Style Y270 and Style Y271, you recommend using UI-Router and defining routes for views in the module where they exist, however UI-Router's FAQ doesn't do a very good job of explaining how this can be accomplished and the majority of examples provided show $stateProvider defining states in the main app's module's config as shown in the following example.
(function () {
'use strict';
angular.module('app').config(stateConfig)
function stateConfig($stateProvider, $urlRouterProvider){
$urlRouterProvider.otherwise('/home');
$stateProvider.state('primary' {
url: '/primary',
template: '/primary.html'
})
$stateProvider.state('secondary' {
url: '/secondary',
template: '/secondary.html'
})
}
})();

primary.routes.js
(function() {
   'use strict';

   angular
    .module('app.primary')
    .config(stateConfig);

   function stateConfig($stateProvider){
      $stateProvider.state('primary' {
        url: '/primary',
        template: '/primary.html'
     })
})();

secondary.routes.js
 (function() {
    'use strict';

    angular
      .module('app.secondary')
      .config(stateConfig);

   function stateConfig($stateProvider){
      $stateProvider.state('secondary' {
        url: '/secondary',
        template: '/secondary.html'
     })
})();

core.routes.js
 (function() {
   'use strict';

   angular
     .module('app')
     .config(stateConfig);

   function stateConfig($urlRouterProvider){
      $urlRouterProvider.otherwise('/home');
})();

What version of UI router does this work with? I am using "version": "0.2.15" and the provided solution isn't working. Can you please provide a working plunkr?

What do you mean "isn't working"? Do you get an error in the console or does the change of state not responding at all?

No error in the console, the change of state is not responding.

Maybe i need to have an updated version of UI-router? With #492 merged (v0.2.8)... https://github.com/angular-ui/ui-router/wiki/Frequently-Asked-Questions#how-to-configure-ui-router-from-multiple-modules

My mistake! My closures weren't structured properly. Thanks for the soluiton.

If anyone still having a hard time finding this implementation like me.
There is a separate repo for this created by @johnpapa
johnpapa/gulp-patterns


FR: add localization support to this extension

it looks like the standard way for vscode is json string replacement via https://github.com/microsoft/vscode-nls.
See https://github.com/microsoft/vscode-extension-samples/tree/master/i18n-sample how to integrate it.
I won't recommend to use Transifex, instead just add the necessary infrastructure and let people PR to the new i18n directory providing the translations.

Sample implementation as suggested in another extension: https://github.com/JohnstonCode/svn-scm/pull/1058/files
Note: The strings don't need to be manually extracted, https://github.com/Microsoft/vscode-nls-dev can do this.

I have tried this in the past but found two problems:
Package.json is expanded on the fly, so the marketplace just shows the unexpanded fields
Next, I could not get it working with webpack
The first problem is problematic, as someone viewing the extension information before install needs to see the information... Irrespective of locale.

Package.json is expanded on the fly, so the marketplace just shows the unexpanded fields.

Which fields should be translated in the marketplace? The command titles and other descriptions aren't so if in question I'd say just leave whatever the marketplace shows directly in English.
I think_ there's a solution for the second one, most of the extensions that are under MS umbrella use that and I guess webpack is used in one of these, too.

Which fields should be translated in the marketplace? The command titles and other descriptions aren't so if in question I'd say just leave whatever the marketplace shows directly in English.

I would aim to translate as much as possible and the more that is done, the worse experience occurs in the marketplace, for example, look at this extension:

Yes, that's a very bad user experience. I'll check some MS extensions.

I'll save you some time..

and

"Known issue", tracked at https://github.com/microsoft/vscode/issues/54111... and very likely the reason the package description itself is not yet translated in the samples above.

will naturally revisit this when Microsoft fix the issue above


update: add bundle step to doc

Codecov Report

Merging #4 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop       #4   +/-   ##
========================================
  Coverage    99.04%   99.04%
========================================
  Files           41       41
  Lines          940      940
========================================
  Hits           931      931
  Misses           9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d1ca7...71ee5cd. Read the comment docs.


Image title fields’ usage as alt text (Accessibility features documentation)

Image title fields’ usage as alt text
This is an Accessibility feature which needs documentation that is needed.

Setting alt text for images
While in the editor view, you may want to add an image. Wagtail allows you to add the alt text of the image directly during the upload.
Click on Upload to select your image. On the upload window, edit the Title of the image and add the necessary tags.

Click on the Upload  button and this opens another window where you can Choose a format for your image. To change the alt text of your image, fill the Alt text field with an appropriate description. Finally, click on Upload.

@thibaudcolas please review and give me your feedback.

@ginandze could you:

Clarify which page(s) this would live on
Remove the point about tags, this is completely off-topic
Rewrite this to require less screenshots

@ginandze could you:

Clarify which page(s) this would live on
Remove the point about tags, this is completely off-topic
Rewrite this to require less screenshots

Thank you for the feedback, I'm on it!

This documentation will be included into the Manage Images section, specifically under Add, edit, and remove images

Setting alt text for images
By default, Wagtail uses the Title you give an image as the alt text. You can change the default alt text of an image during the upload. Giving an a descriptive alt text to your images makes your work more accessible to all users. To do this:
Click on Upload to select your image. On the upload window, edit the Title of the image.
Click on the Upload  button and this opens another window where you can Choose a format for your image. To change the alt text of your image, fill the Alt text field with an appropriate description. Finally, click on Insert Image.

@thibaudcolas  I have done the corrections, what do you think?


windows api using CONTEXT type.

r? @Amanieu
(rust-highfive has picked a reviewer for you, use r? to override)


Option to default to popout stream on stream click

Is your feature request related to a problem? Please describe.
Currently you click the stream and it opens the twitch page. You can also click the dots next to the stream title to open the stream in a popout tab - something that I think should be toggleable!
Describe the solution you'd like
Create a toggle in settings to automatically open streams in popout.
Describe alternatives you've considered
Being sad.
Additional context
Nothing to add other than my thanks for the superb extension!

This is actually the only issue i have with this overall really good extension.
I only browser in incognito mode and there is no way to automatically open streams in the same windows... im always forced to click the right mouse button to do so, plus cant use the dots on the right because it would always open the streams in another window.
So i agree, adding an option where you can choose how to open streams (in my case on a new tab but always in the same window) would be really helpful.


core-api: remove deprecated registerRoute and deprecate addRoute

Removing some really old deprecated stuff, and setting up for more migrations :grin:

Those instructions made me think that the create-plugin template now uses the deprecated route thing, and does not contain an example of the (admittedly a bit complex) incantation needed to formulate an extension. But in die time!

Those instructions made me think that the create-plugin template now uses the deprecated route thing, and does not contain an example of the (admittedly a bit complex) incantation needed to formulate an extension. But in die time!

@freben yep, got a local branch that gets about halfway in updating the template :p Just don't wanna switch to it before we've migrated enough things to make it usable in the app.
Gonna look at adding extensions to the template though

@freben yep, got a local branch that gets about halfway in updating the template :p Just don't wanna switch to it before we've migrated enough things to make it usable in the app.
Gonna look at adding extensions to the template though


Adding privacy event tags to each telemetry event.

Summary of the Pull Request
This change basically adds a PartA_PrivTags field to all telemetry events.  It is up to the individual event to specify the value of PartA_PrivTags.

References

PR Checklist

[x] Applies to #2878
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Note:  Version number is hard coded.  This will be removed post .18 in #3040

Validation Steps Performed
Here are the Data Viewer Log files:
Microsoft.PowerToys.LauncherBootEvent.txt
Microsoft.PowerToys.SettingsEnabledEvent.txt
Microsoft.PowerToys.SettingsBootEvent.txt
Microsoft.PowerToys.MarkdownFileHandlerLoaded.txt
Microsoft.PowerToys.MarkdownFilePreviewed.txt
Microsoft.PowerToys.SvgFileHandlerLoaded.txt
Microsoft.PowerToys.SvgFilePreviewed.txt
Microsoft.PowerToys.SvgFilePreviewError.txt
Microsoft.PowerToys.LauncherFirstDeleteEvent.txt
Microsoft.PowerToys.LauncherQueryEvent.txt
Microsoft.PowerToys.LauncherResultActionEvent.txt
Microsoft.PowerToys.LauncherShowEvent.txt
Microsoft.PowerToys.LauncherHideEvent.txt

@enricogior .   I think this is what we need, but I'm not entirely sure how to validate.  @AirYang919 do you have any expertise on privacy tagging for open source projects, or how to validate the C# events are tagged correctly?

@ryanbodrug-microsoft
I'm getting these build errors:

@enricogior Thanks Ill fix.  Ill also look at why stylecop doesnt report in debug once im back in office

@enricogior Thanks Ill fix.  Ill also look at why stylecop doesnt report in debug once im back in office

The events are generated, but we need to add the PT version to the boot event and the AppSessionGuid to all events.
I've attached examples of Launcher events and for comparison an event for the runner, at the end of the runner's event you can see:
"data": {
"Version": "v0.17.0",
"Elevated": 0,
"AppSessionGuid": "00001E00-0001-001C-AB45-DD072128D601"
}

That is not present for the Launcher events, in C++ it's done like this:
https://github.com/microsoft/PowerToys/blob/1de93be0f0ca5ccb033397fa9a61f11ea8627a62/src/runner/trace.cpp#L28-L31
runner-boot-event.txt
launcher-boot-event.txt
launcher-show-event.txt

"Version")

@enricogior:   I'll add a bool property for UTCReplace_AppSessionGuid to all the C# events.   Are you sure we need the version # in all events.  It seems to only be in the launcher boot event.  If the answer is yes, I'm guessing I would have to export get_product_version from common.cpp.
Also are those event logs from Kusto?

The events are generated, but we need to add the PT version to the boot event and the AppSessionGuid to all events.
I've attached examples of Launcher events and for comparison an event for the runner, at the end of the runner's event you can see:
"data": {
"Version": "v0.17.0",
"Elevated": 0,
"AppSessionGuid": "00001E00-0001-001C-AB45-DD072128D601"
}

That is not present for the Launcher events, in C++ it's done like this:
https://github.com/microsoft/PowerToys/blob/1de93be0f0ca5ccb033397fa9a61f11ea8627a62/src/runner/trace.cpp#L28-L31
runner-boot-event.txt
launcher-boot-event.txt
launcher-show-event.txt

@enricogior: I'll add a bool property for UTCReplace_AppSessionGuid to all the C# events. Are you sure we need the version # in all events. It seems to only be in the launcher boot event. If the answer is yes, I'm guessing I would have to export get_product_version from common.cpp.
Also are those event logs from Kusto?

It seems to only be in the launcher boot event

Yes,  that is what I meant.

Also are those event logs from Kusto?

No, they are from the local telemetry service.

It seems to only be in the launcher boot event

Yes, that is what I meant.

Sorry I meant 'Runner' launch event.
Trace::EventLaunch(get_product_version(), isProcessElevated);
I couldn't find any where else we were passing in the product version.  Is there a telemetry spec somewhere that outlines what fields are required for the different types of events.

A custom build with these changes, and the replaced private TelemetryBase.cs has been build here:
https://github-private.visualstudio.com/microsoft/_build/results?buildId=2714&view=results

@enricogior I think all the outstanding issues have been addressed.

Telemetry.dll needs to be added to the msi for svg and markdown before this gets merged.

Telemetry.dll needs to be added to the msi for svg and markdown before this gets merged.

Done.  Tested with msi:
https://microsoft-my.sharepoint.com/:u:/p/ryanbod/EVnJCIlZIZpEoZ_YM1_CEYsBGdhHap3zxRYXzDxABamsBw?e=2PKNKq


GH-13175: Add automated Cypress test for "Can change Android App Download Link setting"

Summary

This pull request adds a Cypress automated test for https://github.com/mattermost/mattermost-server/issues/13175 on admin console customizations page
Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/13175
Related Pull Requests
Awaiting on https://github.com/mattermost/mattermost-webapp/pull/4376

Looks good to me, thanks @themaverikk!
@saturninoabril what is this PR waiting on?

@devinbinnie This one - https://github.com/mattermost/mattermost-webapp/pull/4376

@themaverikk Please update and fix merge conflicts, then ready to merge, thanks!

@saturninoabril I've fixed the merge conflicts. Please merge the PR.


Refactor single column distinct executors.

This PR moves the common logic process into the base single column distinct executor class.
Tested in unit tests.

Codecov Report

Merging #10859 (1e04f87) into master (3b2e31c) will decrease coverage by 10.41%.
The diff coverage is 4.16%.

@@              Coverage Diff              @@
##             master   #10859       +/-   ##
=============================================
- Coverage     34.52%   24.12%   -10.41%
+ Complexity      462       49      -413
=============================================
  Files          2174     2158       -16
  Lines        116848   116294      -554
  Branches      17692    17602       -90
=============================================
- Hits          40339    28051    -12288
- Misses        72991    85280    +12289
+ Partials       3518     2963      -555

Flag
Coverage Δ

integration1
24.12% <4.16%> (+0.14%)
:arrow_up:

integration2
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...BaseRawBigDecimalSingleColumnDistinctExecutor.java
0.00% <0.00%> (ø)

.../raw/BaseRawBytesSingleColumnDistinctExecutor.java
0.00% <0.00%> (ø)

.../raw/BaseRawFloatSingleColumnDistinctExecutor.java
0.00% <0.00%> (-77.78%)
:arrow_down:

...ct/raw/BaseRawIntSingleColumnDistinctExecutor.java
0.00% <0.00%> (-88.89%)
:arrow_down:

...t/raw/BaseRawLongSingleColumnDistinctExecutor.java
0.00% <0.00%> (ø)

...raw/BaseRawStringSingleColumnDistinctExecutor.java
0.00% <0.00%> (ø)

...RawBigDecimalSingleColumnDistinctOnlyExecutor.java
0.00% <0.00%> (ø)

...BigDecimalSingleColumnDistinctOrderByExecutor.java
0.00% <0.00%> (ø)

.../raw/RawBytesSingleColumnDistinctOnlyExecutor.java
0.00% <0.00%> (ø)

...w/RawBytesSingleColumnDistinctOrderByExecutor.java
0.00% <0.00%> (ø)

... and 11 more

... and 513 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add some missing closing parentheses in code examples

I came across two lost closing parentheses, I hope this is the right place to return them.

Yes, thank you!


Sandbox build workaround for no such table: main.catalogue_product__old

This ticket extends #2898 and specifically addresses users attempting to setup the oscar sandbox. I believe it would be best to note the issue described here in the README/docs until a patched version of Django is released to PyPI.
When attempting to make the django-oscar sandbox with the latest sqlite and Django versions (3.26.0 and 2.1.4 for me, respectively), one will likely run into the following exception:
django.db.utils.OperationalError: Problem installing fixture '/Users/Mike/website/django-oscar/sandbox/fixtures/child_products.json': Could not load catalogue.ProductCategory(pk=1): no such table: main.catalogue_product__old

This is due to the bug noted in #2898 and addressed in this Django PR: https://github.com/django/django/pull/10733
A simple temporary workaround is to use an older sqlite. I switched to 3.19.0 and the build succeeds. The process for doing this is OS/environment specific.

So For the bug in the sandbox of oscar one should use an older sql lite database?3.19.0 to prevent saving products in the shop and get did of this error?
Where to get it? https://www.sqlite.org/src/timeline

Request Method:
POST

http://localhost:8000/nl/dashboard/catalogue/products/create/koffiebbonen/

2.1.4

OperationalError

no such table: main.catalogue_product__old

/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/lib/python3.7/site-packages/django/db/backends/sqlite3/base.py in execute, line 296

/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/bin/python

3.7.1

['/Users/timvogt/Software_projects/Backend/django-oscar/sandbox',  '/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/lib/python37.zip',  '/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/lib/python3.7',  '/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/lib/python3.7/lib-dynload',  '/usr/local/Cellar/python/3.7.1/Frameworks/Python.framework/Versions/3.7/lib/python3.7',  '/Users/timvogt/.virtualenvs/django-oscar-jB0wsp9N/lib/python3.7/site-packages',  '/Users/timvogt/Software_projects/Backend/django-oscar/src']

zo, 23 Dec 2018 08:15:17 +0000


estimation quality assessment branch（SOT）

Hello, could you tell me how is the ground-truth of the IoU experiment in the quality assessment branch calculated?  The ground-truth bounding box B*  and the corresponding location of B on the input image  are known, but how to determine the width and height of the predicted bounding box B

The output contains the bounding box of the target, which including the width and height

The output contains the bounding box of the target, which including the width and height

Do you mean using the output of the regression branch?

The output contains the bounding box of the target, which including the width and height

Do you mean using the output of the regression branch?

Yes, that is right

The output contains the bounding box of the target, which including the width and height

Do you mean using the output of the regression branch?

Yes, that is right


fix: npm test

There were errors in tests because availableClusters have been removed from TokenService.

[test]

[test]


Very slow

I don't know if this is the linter, xo or some plugin, but XO results are extremely slow. It is as if every keystroke results in a lint, instead of only linting if the previous run completed and the text is dirty again.
On "larger" files (400 lines) this becomes very noticeable, taking tens of seconds/minutes.
Anything I can do to troubleshoot?

Thanks for reporting @wmertens. Personally, I never had issues with this. You can easily check if it's this plugin since the new release (1.7) as you can easily disable the other extensions. Mind doing that and check this again?

I have no ieda what was happening but it stopped happening. I'll close this and investigate more if it happens again.

Thanks for following up!

It's happening again :) I think it started when I upgraded XO in the project, and indeed, in another project XO is fast.
Any ideas for how to troubleshoot?

Just to add to the issue, I have a somewhat big project and I'm having performance issues as well. Really sluggish. Any ideas?

Same here, having performance issues on large files. Any ideas on how to improve performance? 😄

The same here. I've recorded a gif about it:

I have fixed the performance issue with #35 but seems like this repo is no longer maintained.
So I published it myself https://marketplace.visualstudio.com/items?itemName=bryan-chen.linter-xo-2

It still is maintained, just had other things on my mind.

@xlc if you want I can add you as a maintainer of this project. Let me know if you would be interested.


Also allow rabbitmq_ssl_private_key to accept the key itself (or a varialbe contianing the key) or a value in hiera; in this case, the will be written to a file.

This should retain the current functionality and add the option to use heira, a variable containing the key, or a string with the key itself.  Any of these three options would cause the key.pem file to be written with the value given.

Would you squish these commits into one, add some tests, and I'll merge it?  Thanks!

@brianwhigham have you had a chance to look at this?

I was just looking for exactly this functionality.  Should the same logic also apply to the CA chain file?

I'm not sure that we should allow puppet:/// sources for these files as it promotes forking modules and keeping sensitive information tightly coupled with a module. Instead we should prefer content while also allowing local sources to be used, in case the files are managed elsewhere such as a package.

This will change the behavior of rabbitmq_ssl_private_key and rabbitmq_ssl_cert_chain

Isn't that functionality (at least the main part) already included in the module ?
https://github.com/sensu/sensu-puppet/blob/v2.24.0/manifests/rabbitmq/config.pp#L78-L87
https://github.com/sensu/sensu-puppet/blob/v2.24.0/manifests/init.pp#L151-L156

Which functionality? I'm saying that I don't think allowing puppet:/// sources are a good idea, even though it currently exists.

@Phil-Friderici ping

Sorry, I got confused because this PR tries to add the feature to allow ```puppet://``.  Actually this feature is already in the code [1]. Wanted to point out that there is no need to merge this anymore.
[1] https://github.com/sensu/sensu-puppet/blob/master/manifests/rabbitmq/config.pp#L64-L78

It appears this functionality already exists. Please reopen if we missed something. Thank you.


check SkE account on linking

When connecting Lexonomy account to SkE account, check if same SkE account is already connected with another Lex account.

speaking of linking... might it become a problem that there seemingly is only a one-one connection between SkE and lexonomy.eu - what about lexonomy.elexis.eu (or others, like beta.lexonomy.eu)?

And to add, what about linking between local installations of Lexonomy and SkE?

Linking between local installation of Lexonomy and SkE works
Linking between Lexonomy and anything else is not supported -- there is no other SSO provider at the moment and it is unlikely there will be one anytime soon

i think, i misunderstood the linking. there seem to be two directions, and i was concerned about what is usually referred to as the one-click dictionary, i.e. SkE -- sending data --> lexonomy. if i unterstand this correctly, then this direction is pre-set in SkE to lexonomy.eu - and maybe the only thing necessary here would be to be (more) explicit about this: OCD works only with lexonomy.eu.
the other direction, lexonomy <--grabbing data-- SkE seems to be working from different lexonomy installations but (if i understood @mjakubicek correctly) is pretty much only supported for SkE.

You did misundersand but on a different level, this is just about linking user accounts, nothing else.  OCD or push/pull is entirely unrelated.

i see, yes.
for what it's worth:

lexonomy.elex.is doesn't seem to be prominently linked at the moment
beta.lexonomy.eu announces itself as being 'special'

and if there will ever be

confusion about "to where can i push one-click dictionary data from SkE?"
the need to "push data from SkE somewhere else than lexonomy.eu"

that will be go into a new issue.
sorry for the confusion, back to @rambousek

meanwhile fixed in beta :)


Make InputSet support device-specific variations

Today, you can create an input set with iPad-specific variations. However, the current device type is by default used to select which variation that is applied.
This means that once the input set is generated, the variation information is lost. This makes it impossible to use it in other ways, e.g. to render an iPhone-specific layout on iPad for a floating keyboard.
To support this, the input set will be refactored to be initialized with a base set, while allowing for DeviceType-specific variations. This will let us later get an input set for a certain device.

This is done and can be tested in the v9 branch.
This will drastically simplify how to work with input sets and make device variations, and will for instance make it possible to implement #478, although this will require some additional changes.


Update vLLM

Update vLLM dockerfile to 0.5.3.post1 to support Llama 3.1 models

Let's close this for now and revisit when flash-infer is fully tested


QUOTED_IDENTIFIER is set off in some stored procedures when migrating 46 stored procedures using Flyway

What version of Flyway are you using?
4.0.3
What database are you using (type & version)?
MS SQL server 2014
What operating system are you using?
Windows Server 2012
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
I'm running Flyway Migration for 46+ stored procedures,
command : Flyway Migrate
In the initial run, out of those 46 procedures 6 of them get the QUOTED_IDENTIFIER value as OFF. The default value of this attribute is ON in MS SQL. But when i execute the those stored procedures individually then the QUOTED_IDENTIFIER value is set ON.
What did you expect to see?
All the stored procedures to have the QUOTED_IDENTIFIER attribute set to ON in the initial migration.
What did you see instead?
some stored procedures having the value OFF

Flyway does not do anything special with it. It is your responsibility to ensure it is set and stays set. You can also easily enforce this with the beforeEachMigration callback.

why does Flyway set this attribute differently ? i mean in the initial migration at the stage where we apply flyway versioning then this attribute is set to OFF and then when i execute it individually it is set to ON ?


ARROW-6652: [Python] Fix Array.to_pandas to retain timezone

https://issues.apache.org/jira/browse/ARROW-6652

Codecov Report

Merging #5462 into master will decrease coverage by 22.41%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #5462       +/-   ##
===========================================
- Coverage   88.62%   66.21%   -22.42%
===========================================
  Files         958      505      -453
  Lines      127421    69783    -57638
  Branches     1495        0     -1495
===========================================
- Hits       112926    46206    -66720
- Misses      14130    23577     +9447
+ Partials      365        0      -365

Impacted Files
Coverage Δ

python/pyarrow/tests/test_pandas.py
94.57% <ø> (-0.01%)
:arrow_down:

python/pyarrow/array.pxi
79.24% <100%> (+0.29%)
:arrow_up:

python/pyarrow/tests/test_array.py
93.54% <100%> (+0.02%)
:arrow_up:

cpp/src/arrow/util/memory.h
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/date_utils.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/util/memory.cc
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/decimal_type_util.h
0% <0%> (-100%)
:arrow_down:

cpp/src/arrow/compute/logical_type.h
0% <0%> (-100%)
:arrow_down:

cpp/src/parquet/hasher.h
0% <0%> (-100%)
:arrow_down:

cpp/src/gandiva/basic_decimal_scalar.h
0% <0%> (-100%)
:arrow_down:

... and 703 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2785d3...0e15f8f. Read the comment docs.

LGTM, thanks for the quick fix!

It looks like this didn't completely solve the issue. When there is a ChunkedArray it still removes the timezone:
>>> import pyarrow as pa
>>> a = pa.array([1], type=pa.timestamp('us', tz='America/Los_Angeles'))
>>> table = pa.Table.from_arrays([a], ['a'])
>>> c = table.column(0)
>>> c
<pyarrow.lib.ChunkedArray object at 0x7f1eecf51318>
[
  [
    1970-01-01 00:00:00.000001
  ]
]
>>> c.to_pandas()
0   1970-01-01 00:00:00.000001
Name: a, dtype: datetime64[ns]

My fault, I should have also mentioned ChunkedArray in the JIRA, but I assumed it was the same code path.

@jorisvandenbossche is it just a matter of applying the same fix to the ChunkedArray method?

Ah, yes, didn't think of ChunkedArray. The fix is probably the same yes. Will have a look.

Applied the fix for ChunkedArray in https://github.com/apache/arrow/pull/5471


Homepage link on PyPi incorrect

/kind bug
Looking on https://pypi.org/project/kfserving/ and clicking on the homepage button on the left under project links goes to a page that does not exist (https://github.com/kubeflow/kfserving/python/kfserving). It should probably be changed to https://github.com/kubeflow/kfserving/tree/master/python/kfserving.

Good catch @DavidSpek ! Can you help fix here ?

@yuzisun Fixed it in https://github.com/kubeflow/kfserving/pull/1431


Added web link to an item

This commit adds the web link to a media item as parameter.

Good job!


Fix model cleanup failure due to dead machine

Fixes this exception coming from _cleanup_model:
Traceback (most recent call last):
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/pytest_asyncio/plugin.py", line 362, in finalizer
    loop.run_until_complete(async_finalizer())
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/pytest_asyncio/plugin.py", line 354, in async_finalizer
    await gen_obj.__anext__()
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/pytest_operator/plugin.py", line 153, in ops_test
    await ops_test._cleanup_model()
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/pytest_operator/plugin.py", line 282, in _cleanup_model
    log.info(f"Destroying machine {machine.id}")
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/juju/model.py", line 278, in __getattr__
    return self.safe_data[name]
  File "/opt/github-runner/_work/layer-calico/layer-calico/.tox/integration/lib/python3.8/site-packages/juju/model.py", line 371, in safe_data
    raise DeadEntityException(
juju.exceptions.DeadEntityException: Entity machine:2 is dead - its attributes can no longer be accessed. Use the .previous() method on this object to get a copy of the object at its previous state.

This occurred because the test prior to this had just cleaned up an application that was on machine 2. The machine is already dead, no need to destroy it again.

https://github.com/charmed-kubernetes/pytest-operator/pull/45 should fix the test failure seen here. Once that PR has been merged, I'll rebase this one on top.


Capacity Type Distribution

Some application deployments would like the benefits of using Spot capacity, but would also like somewhat of a stability guarantee for the application. I propose a capacity-type percentage distribution of the k8s Deployment resource.  Since Capacity-Type is likely to be implemented at the cloud-provider level, this too would need to be at the cloud-provider layer.
For example:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: inflate
spec:
  replicas: 10
  template:
    metadata:
      labels:
        app: inflate
        node.k8s.aws/capacity-type-distribution/spot-percentage: 90
    spec:
      containers:
      - image: public.ecr.aws/eks-distro/kubernetes/pause:3.2
        name: inflate
        resources:
          requests:
            cpu: "100m"

The above deployment spec would result in the deployment controller creating Pods for the 10 replicas. Karpenter would register a mutating admission webhook which would check if the pod's deployment spec has these labels and then check any current pods belonging to the deployment to determine which capacity-type label to apply. The pod resource after the admission webhook would look like this:
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: inflate
    pod-template-hash: 8567cd588
  name: inflate-8567cd588-bjqzf
  namespace: default
  ownerReferences:
  - apiVersion: apps/v1
    kind: ReplicaSet
    name: inflate-8567cd588
spec:
  containers:
  - image: public.ecr.aws/eks-distro/kubernetes/pause:3.2
    name: inflate
    resources:
      requests:
        cpu: "100m"
  schedulerName: default-scheduler
  nodeSelector:
      node.k8s.aws/capacity-type: spot

^^ duplicated 8 more times, and then:
apiVersion: v1
kind: Pod
metadata:
  labels:
    app: inflate
    pod-template-hash: 4567dc765
  name: inflate-4567dc765-asdf
  namespace: default
  ownerReferences:
  - apiVersion: apps/v1
    kind: ReplicaSet
    name: inflate-4567dc765
spec:
  containers:
  - image: public.ecr.aws/eks-distro/kubernetes/pause:3.2
    name: inflate
    resources:
      requests:
        cpu: "100m"
  schedulerName: default-scheduler
  nodeSelector:
      node.k8s.aws/capacity-type: on-demand

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle stale

/remove-lifecycle rotten


[bn] Need to add approvers for Bengali Localization

We need more maintainers for Bengali Localization to keep the PRs checked .

@jihoon-seo I hope this PR is okay, right? Created just 1 PR with both files changed

Hi @Imtiaz1234
Please read Policies for localization approvers (to be confirmed by candidates) #723
All candidates need to leave a comment in the PR that you understood policies and information in #723. (l10n teams: please share this message to candidates)

@seokho-son , I have gone through he policies ☺


mkpr package.json [{"op":"test","path":"/devDependencies/npm-pkgbuild","value":"^6.3.6"},{"op":"replace","path":"/devDependencies/npm-pkgbuild","value":"^6.3.8"}]

Pull Request Test Coverage Report for Build 1529

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.399%

Totals

Change from base Build 1525:
0.0%

Covered Lines:
301

Relevant Lines:
302

💛  - Coveralls


Auto select first match

Is there a way to make hstr auto select first in the list without having to hit c-n  ?

f80e3d1 has some code to do this, but I gather that branch has some issues that need fixing before it can be merged.

any new on this ? would be very nice to have.


:seedling: Bump version to 1.3.2

Summary
Related issue(s)
Fixes #
Tests

[ ] Unit/function tests have been added and incorporated into make unit-tests.
[ ] Integration tests have been added and incorporated into make integration-test.
[ ] E2E tests have been added and incorporated into make e2e-test-all.
[ ] List other manual tests you have done.

/retest due to create KinD cluster is failed.

/test test-e2e

/lgtm

/test test-integration


Disable failing hwy tests on Windows build.

we could also add the "DISABLED_" prefix to the test (and a TODO, of course)

we could also add the "DISABLED_" prefix to the test (and a TODO, of course)

ahh no, that would not work, this is not a normal test...


Keptn CLI: Disable Kube context check

As a Keptn user, I frequently work with a Keptn running on a K8s cluster where I do not have a Kube context for. However, the CLI keeps asking me
Kube context has been changed to XYZ
Do you want to switch to the new Kube context with the Keptn running there? (y/n)n

As a Keptn user, I would like to disable this Kube context check.

I changed the type of this issue into a bug, as this question makes the CLI user-unfriendly.

@agrimmer The current CLI supports the the y/--yes    Assume yes for all user prompts flag.
Does this solve your ptoblem?


fix(app-shell): enhancement to be resizable app-shell

Description
The help option panel is now resizable to the left, it can now scroll with a maximum width of 600 px. Help panel text wraps automatically
What's included?

This PR includes the functionality to make the Help Panel resizable

Test Steps

[ ] npm run start
[ ] then this
[ ] finally this

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

Screenshots or link to StackBlitz/Plunker

@vicalcantFrontEnd In general this is looking good! i did notice the delay is from the transition-property...not sure how you want to handle this but looks like while we are resizing we want to disable the transition property, but have it enabled when the use clicks open/close action.
transition-property: width;
transition-duration: 200ms;

Looks very nice visually. A couple functional tweaks:

It's laggy, the mouse can move independently of the drag line and it takes a bit to catch up
Probably related: the highlighted drag line doesn't stay highlighted while dragging if the mouse has moved off of it
The panel resets to the default width every time it's closed. It should reopen to the previous width for some duration of time, probably just for the current session
A double-click on the drag line should reset the width to the default starter width

@adamnel  I push the version with the features that are in the comments, please let me know if you have some questions or changes.

I also notice when in small view the help panel no longer takes up the full width of the screen. this is a regression and should be accounted for as well.

Fixed the responsive mode

We don't want to limit the width of the help panel, or rather, any limitation should come from a minimum width or other control on the main content.
Right now the help panel looks to be maxed out at 600px wide, but this forces it to be artificially narrow on wide screens, but still allows it to crush the content on narrower ones. That main content should handle its own min width to prevent the crushing, not the panel itself setting an arbitrary max value.

Thank you for your comments. To make sure I'm understanding the proposed changes, I'd like to confirm a couple of points:

Remove the 600px width restriction to allow for greater flexibility on larger screens?
Add a min-width to the main content to ensure its usability and legibility under all conditions. What do you think would be an appropriate value in pixels for this min-width?
Behavior on Small Screens, currently, the help panel covers 100% of the width on small screens. Would you like to maintain this design, or is there any modification we should consider to improve the experience on small devices?

Remove the 600px width restriction to allow for greater flexibility on larger screens.

Correct

Add a min-width to the main content to ensure its usability and legibility under all conditions. What do you think would be an appropriate value in pixels for this min-width?

The main content to be able to override this value on any given screen but set a default of 600px.

Behavior on Small Screens, currently, the help panel covers 100% of the width on small screens. Would you like to maintain this design, or is there any modification we should consider to improve the experience on small devices?

The behavior on small screens is good as is.

Remove the 600px width restriction to allow for greater flexibility on larger screens.

Correct

Add a min-width to the main content to ensure its usability and legibility under all conditions. What do you think would be an appropriate value in pixels for this min-width?

The main content should be able to override this value on any given screen but set a default of 600px.

Behavior on Small Screens, currently, the help panel covers 100% of the width on small screens. Would you like to maintain this design, or is there any modification we should consider to improve the experience on small devices?

The behavior on small screens is good as is.

@adamnel I remove the max-width 600px restriction in the help pannel and add min-width to main  to ensure its its usability and legibility under all conditions.

:tada: This PR is included in version 8.12.1 :tada:
The release is available on:

v8.12.1
GitHub release

Your semantic-release bot :package::rocket:


fix: replace variable group with the working one

Which issue this PR addresses:

Fixes
What this PR does / why we need it:
The original variable group is not working, most likely due to bad linkage to the keyvault.
Replaced with the one that has the same keyvault with the same variables.
Signed-off-by: Petr Kotas<EMAIL_ADDRESS>
Test plan for issue:

Is there any documentation that needs to be updated for this PR?

@petrkotas I think there is linting issue wiith CI failing, we can merge in and test pipeline once CI passes

Closing as I believe the issue is elsewhere.


Degradation to infinite loop when reading broken files on 3.3.0

After upgrade to 3.3.0, reading damaged xls files (e.g. ~test_broken.xls.zip) with a specific pattern will result in an infinite loop.
On 3.2.0, an exception occurred correctly.
Sample code:
using(var fs = File.OpenRead("~test_broken.xls"))
using(var reader = ExcelReaderFactory.CreateReader(fs)) { }
// on 3.2.0, Exception thrown: System.InvalidOperationException "SST read position out of range"
// on 3.3.0, The CreateReader method does not be returned, it loops infinitely.

I think that the fix of #286 is affecting this.

Confirmed. Definitely need to fix this and review for other potential DoS vectors
May I ask how the broken file was produced?

The sample Excel book file I uploaded is what I intentionally broke in the binary editor.
A third party library for Java has a problem of outputting a broken Excel workbook when the number of characters of the cell becomes larger than a certain number.
I encountered this problem with the file output by that library.
But unfortunately, I do not know the name of the library for that Java....

Thank you!
It doesn't loops infinitely anymore!


[BUG] Density setting doesnt change anything

Godot version
v3.5.stable.official [991bb6ac7]
Plugin version
1.1.0
Platform
Windows 10
Issue description
Density Setting doesnt change anything
Steps to Reproduce
I followed youtube tutorial https://www.youtube.com/watch?v=AqRz0URe3bo&list=PLtsfK5HW0bX-TKR8eO_uKEguii8w9dGIh&index=1
And when painting density is really sparce for grass, so I tried increasing density, but it does nothing, I tried restarting godot engine, still same issue, both in editor and game

I've created a fresh scene and tried drawing with brush size from your screenshot - 6.41 units.

I painted at low density 100 to get the feel of if
I switched to your density 1880.9
I cranked it up to 10 000
And finally with 100 000

For now I assume your scene's scale is not very big and thus you need way bigger density.
Try cranking it up and tell me the result. It would be best if you show me a comparison side by side of different densities.

ohhhhhh I can go further than 2000 that explains everything... tyyy didnt realise that... 😅😅

also i didnt change anything to fix it not painting, I jsut uploaded video, tried again and it worked

I tried to show you the issue, created gardener again but now it wont paint at all

Sounds like a collision issue. In-editor collision can be finicky sometimes. Reloading a scene usually helps.
Anyway, glad this is solved!
BTW, you can increase slider limit in the project settings. Both for density and brush size if you need to.