Do not use Google's HTTP client to get the default project ID

As described in this issue, Quarkus w/ the Google clooud services and OpenCensus shim does not startup due to a static initialization issue.
com.google.cloud.ServiceOptions is used by the extension to get the Google cloud default-project-ID, which uses Google's HTTP client, which uses OpenCensus, which triggers an initialization of OpenTelemetry, which conflicts with the OTel init from Quarkus.
This change updates GcpDefaultsConfigSourceFactory to use Java's HTTP client.
See also #487, the alternatives mentioned in this comment to implement a ConfigSource and in this comment to set otel.java.global-autoconfigure.enabled=false) end in the same OpenCensus/OpenTracing init race.
Fixes https://github.com/quarkusio/quarkus/issues/35500

Manually verified that Quarkus starts w/ the OpenCensus-shim.

Also manually verified (in jshell in a GCP VM) that the getAppEngineProjectIdFromMetadataServer() function yields the default project ID

@loicmathieu I personally don't mind (can wait for 3.4, if the 3.4 platform-bom references it), but could be useful for other users to have this also in 3.3.x.

@all-contributors please add @snazy for code

2.5.0 is released with the fix.
If there is a strong need to backport it ot 2.4.0 (which is based on Quarkus 3.3) I can do it.


feat: AppMap installer for Python

The Automated install via AppMap CLI button now uses the Python extension to create a Python terminal to run the command in. The Python terminal will use the users own configured interpreter/virtual environment.
The overall flow is as follows:

If the user does not have the extension installed, they are prompted to install it.

Clicking Yes to install waits for the extension to install then continues on to the CLI installation. If the extension was already present, this step is skipped.

Before running the CLI, we check to see if the Python extension knows of any virtual environments within the project directory. If the user doesn't have one selected, we'll prompt them to reconsider:

The CLI installer is then run within a Python context:

Resolves #702

I've pulled out the logic to perform the install and configure the interpreter based on feedback. If the extension is not installed, we'll just optionally open up the extension in the sidebar without installing it or waiting on it.

I've pulled out the logic to perform the install and configure the interpreter based on feedback. If the extension is not installed, we'll just optionally open up the extension in the sidebar without installing it or waiting on it.

OK let's start there and see if telemetry informs us that more is needed.

:tada: This PR is included in version 0.85.0 :tada:
The release is available on:

v0.85.0
GitHub release

Your semantic-release bot :package::rocket:


fix(sui): fix sui validator display-metadata for pending validators

Description
Fix the DisplayMetadata command when a validator is still pending
Without this change the ValidatorV1 can't be correctly decoded as the first bytes of the bcs are for the Field as the object is a dynamic field resulting in this error: Can't convert bcs bytes of object 0x17792bdce1d0c032e64f5dff96a4e80eb453ab43f290ef6d091b1ebe50a511eb to ValidatorV1: malformed utf8
Porting the fix from https://github.com/iotaledger/iota/pull/3611
Test plan
Running these commands
# increase faucet amount (just setting 30 million didn't work)
sed -i 's/200_000_000_000/4_000_000_000_000_000/g' crates/sui/src/sui_commands.rs
cargo run start --force-regenesis --with-faucet

# other terminal
cargo install --locked --bin sui --path crates/sui
sui client switch --env localnet
# get enough coins
sui client faucet --url http://<IP_ADDRESS>:9123/gas
sui client faucet --url http://<IP_ADDRESS>:9123/gas
sleep 2
sui validator make-validator-info validator0 description https://sui.io https://github.com/MystenLabs/sui <IP_ADDRESS> 1000
sui validator become-candidate validator.info
sleep 2
# stake enough coins
for run in {1..8};
do
    coinObjectId=$(sui client gas --json | jq '.[0].gasCoinId')
    validatorAddress=$(sui client active-address)
    sui client call --package 0x3 --module sui_system --function request_add_stake --args 0x5 $coinObjectId $validatorAddress --gas-budget 10000000
done
sleep 2
sui validator join-committee
sleep 2
sui validator display-metadata

Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] Indexer:
[ ] JSON-RPC:
[ ] GraphQL:
[x] CLI: fix sui validator display-metadata for pending validators
[ ] Rust SDK:
[ ] REST API:

Thanks @Thoralf-M. I will have a look asap.


MSVC warning 4146 on radix sort

This was on VS 16.9.5 not sure if it's harmless or not, I silenced it with a #pragma.

Which warning? And where? Without more information I cannot solve this.

Sorry that's C4146 on the error.
in radix_sort.hpp

Which line?

Also I don't have MSVC

C4146 is the actual content of the error.   'unary minus operator applied to unsigned type, result still unsigned'.
It's line 93 looks like the -y triggers it.

This is perfectly fine. The C++ standard states:
A computation  involving  unsigned  operands  can  never overflow, because  a  result  that  cannot
be  represented  by  the  resulting  unsigned  integer  type  is reduced  modulo  the  number  that  is
one  greater  than  the  largest  value  that  can  be represented by the resulting type.

 Negating unsigned numbers is of course not so common, but it's perfectly defined and has a precise meaning. Here it's used in order to make turn a floating point value into a key that can be sorted using integer radix sort. The only assumption there is that floats are represented with IEEE-754, which is reasonable I think.

@madmann91, don't you want to add #pragma warning ( disable : 4146 ) at the top of the file? This warning is threated as error and compilation fails.

I don't want to enable/disable warnings like this. MSVC has a lot of spurious warnings anyway and who knows which ones will trigger the next time I touch this code (and also which ones I'll have to disable once I update the code if they no longer apply). However, I also see that this can be annoying if you compile with warnings as errors (which I wouldn't recommend in general -- but you do you), so I can think of the following compromise: Try the patch below, if it works create a PR and I'll merge it. If not, well, try something in the same vein, basically negating a signed integer and putting that back into an unsigned one.
// replace this version...
static typename SizedIntegerType<sizeof(T) * CHAR_BIT>::Unsigned make_key(T x) {
    using U = typename SizedIntegerType<sizeof(T) * CHAR_BIT>::Unsigned;
    auto mask = U(1) << (sizeof(T) * CHAR_BIT - 1);
    auto y = as<U>(x);
    return (y & mask ? (-y) ^ mask : y) ^ mask;
}
// ...with that version
static typename SizedIntegerType<sizeof(T) * CHAR_BIT>::Unsigned make_key(T x) {
    using U = typename SizedIntegerType<sizeof(T) * CHAR_BIT>::Unsigned;
    using I = typename SizedIntegerType<sizeof(T) * CHAR_BIT>::Signed;
    auto mask = U(1) << (sizeof(T) * CHAR_BIT - 1);
    auto y = as<U>(x);
    return (y & mask ? static_cast<U>(-static_cast<I>(y)) ^ mask : y) ^ mask;
}

Looks like now it works same way but without warning. I checked it with numbers which are close to 2^n (sign bit is used). And also compared traverse statistic - it was the same.

How do you make PR here? I can't create branch, but i see merged PRs like that:
madmann91 merged 1 commit into madmann91:master from newr5:master

I have no idea how to do this trick.

You can click the fork button (top right when on the project page), then this will create your own fork of the project. Then you can commit into it via normal means. Once that is done, you can go on to your fork in the web browser and create a pull request from there. I'll review it and merge it. Once that is done then you can delete your fork. Thank you for putting that extra effort!

Done! Thank you for cooperation.

Should be fixed by commit 93a7cdc


[MetaSchedule][M4a] Add Tuning Scripts for TIR / TE / Relay

This PR is part of the stage M4a of the meta schedule project (#8473).
The architecture is re-designed by Junru and Xiyou. In this PR we introduced the tuning scripts for tir, te & relay workloads with meta schedule. Unittests are added for each type of tuning, and for relay workloads we added tests of ResNet18, MobileNetV2 and BertBase.
Thanks to all co-authors for contributing!
Co-authored-by: Junru Shao<EMAIL_ADDRESS>Co-authored-by: Bohan Hou<EMAIL_ADDRESS>Co-authored-by: Ruihang Lai<EMAIL_ADDRESS>Co-authored-by: Hongyi Jin<EMAIL_ADDRESS>Co-authored-by: Wuwei Lin<EMAIL_ADDRESS>Co-authored-by: Siyuan Feng<EMAIL_ADDRESS>

Let's wait for the rest 3 rules to be upstreamed before merging this PR :-)


add basic test for groupby with string agg

This is a rudimentary test to demonstrate #1427

Resolved by #1430


LFS-1125: Split LFS forms into semantic sections

To check:

are all the fields still present?
does the new order make sense?
should the sections have labels, or is it OK without any demarcation of the sections?

There is a problem with radio form. I created a form, entered all required info and saved it.

When I open it, it show only one field Radiation therapy:

When I click on edit button; other fields appear, however Radiation therapy field seems to be blank.

Start and end date now have Height and Weight fields in between them.

The above issue has been addressed in https://github.com/ccmbioinfo/lfs/pull/621#pullrequestreview-648706699

Radio and Chemo form in view mode only show the very first question and the last one even though all fields are populated.


Show GLSL Preview not working

On the latest version of vsCode (1.50.1) the command to open the preview is not working:

Command 'Shader Toy: Show GLSL Preview' resulted in an error (command 'shader-toy.showGlslPreview' not found)

The version 0.10.12 works for me but 0.10.13 does not seem to work

'tis no good. I'll take a look soon.
Thanks for letting us know  :pray:


[ENH] test_methods_have_no_side_effects should test for side effects in all key arguments

See #1673.
The prophet wrapper has side effects on X.
This was not discovered by test_all_estimators/test_methods_have_no_side_effects since its key dependency _make_args, which creates default arguments, does not create non-trivial X (this is set to None).
_make_args should be modified that all arguments of critical functions are properly tested for side effects.

This is automatically happening since we upgraded to test scenarios in #1819, accidentally this issue did not get linked and closed.


Roadmap to reactphp/event-loop v3

ReactPHP v3 is going to happen! 🎉
We're committed to work on the next major version of ReactPHP. We've started working on this a while ago and believe it's time to finally make this public and give people a chance to see what we're up to and to contribute. In order to show the ongoing development towards ReactPHP v3, we're using dedicated roadmap tickets (like this one) for each component.
Our plans towards EventLoop v3

✅ Create 3.x branch #272
Once this is created, we can start working on the new v3.0.0 milestone. The default branch will be 3.x and the previous 1.x branch still stay in place at least until v3.0.0 is released.

✅ Drop deprecated APIs #273, #274
All APIs marked as @deprecated in v1 will be removed in v3. Each occurrence should have a clear upgrade path described.

Require PHP 7.1+ and recommend PHP 8.1+
Time to upgrade! The new v3 will make use of newer language features, so we will upgrade to PHP 7.1+ as a minimum requirement (to run absolutely anywhere) and recommend PHP 8.1+ looking forward (Fibers).

Type-Safe APIs with PHPStan on max level
All our public APIs should use native type declarations to avoid invalid API usage and guide IDEs and static analysis tools.

Release reactphp/event-loop v3.0.0
Planned around mid-2024, approaching our 12th birthday? To ensure a smooth release, we will coordinate the process across all our components.

How you can help
We're optimistic to get the above things done in the near future, so this ticket aims to serve as a basic overview and is subject to change as we progress. For more details, see also the milestone links and any referenced tickets. If you have any additional input for ReactPHP v3, we invite you to join our discussion about the roadmap for the next major version.
Working on the next major version involves a lot of work and we're always looking for sponsors to allow us spending more time on ReactPHP. Check out ReactPHP's sponsors profile and consider supporting the ongoing development ❤
We'll do our best to keep this ticket updated as we make progress. To keep things organized, let's try to limit the discussions in here and please use new tickets and discussions for input. Help us spread the word! We are excited to move forward together! 🚀

In documentation said:
As of v1.2.0, we highly recommend using the Loop class this way and omitting any explicit run() calls. For BC reasons, the explicit run() method is still valid and may still be useful in some applications, especially for a transition period towards the more concise style.

Removing the run() method from the code will break the PHP execution logic. If any exception/error/exit occurs in the ReactPHP registered shutdown function within user code that is called by the loop during queue processing, this will prevent registered functions of other classes (such as error handlers, loggers, and other application logic) from executing and capturing the exception/error/exit.

@MyNameIsRoman As @clue wrote above, this ticket is used as a overview for the v3 development and is not supposed to be a place for discussion, use new tickets and discussions for input.

To keep things organized, let's try to limit the discussions in here and please use new tickets and discussions for input.


PING to network devices

Hi,
What would be the best approach to monitor network devices? I would like to monitorign the presence and RTT of BGP Peer IP's and Azure Firewall IP's using simple PING.
Kind regards, Arjen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3bf662d1-53fb-f651-ee67-6e174836d739
Version Independent ID: 67782b9a-1dd5-acb4-6d93-62ee9ff60d43
Content: Tutorial - Monitor network communication using the Azure portal
Content Source: articles/network-watcher/connection-monitor.md
Service: network-watcher
GitHub Login: @damendo
Microsoft Alias: damendo

Hi again,
I was to swift with my quesion. I found out that BGP Peer IP's are reachable on port 179 en therefore we can Manually Specify IP address and port, which works fine. However for Azure Firewall, which replies to PING, I cannot determine an appropriate (telnet) port.
Please advise.

@aggerritsen , Thanks for your feedback. We are looking into this query and will update you as soon as possible.

@aggerritsen , Appreciate your patience. We use tools like tcpping. (i.e. ICMP not supported with the public LB we use under the hood).

@aggerritsen ,We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Before you close...
Azure Network Watcher Connection Monitor (Preview) allows TCP, HTTP as well as ICMP. The latter slipped my attention. I now successfully configured ICMP Connection Monitoring for Azure Firewall as part our monitoring scheme.
However TCP Ping - as you suggested - requires a TCP port I presume. What would be the TCP Port of Azure Firewall to use?
Kind regards, Arjen


Switch to using PackageLicenseExpression

License expression is the preferred way (shows in NuGet.org and used in license validations)
https://learn.microsoft.com/en-us/nuget/create-packages/package-authoring-best-practices#licensing
Example:
<PropertyGroup>
    <PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>

Thank you for the recommendation! :-)


Asset not compiled unless referenced via {{ asset }}

[x] I tried updating to the latest version.

[ ] I can't, there is an issue.

[ ] I Am on Windows

[ ] Ubuntu Bash on Windows
[ ] Fedora Bash on Windows
[ ] Other  Bash on Windows

[ ] I Am on Linux

[ ] Ubuntu
[ ] Fedora

[ ] I Am on macOS
[ ] I'm on Docker

[ ] I understand Docker may be unsupported.

Description
I suspect this may be by design, but when I only reference an asset via the asset collection, it isn't copied to the asset folder. I must include it somewhere using the asset tag.
To work around this, I add a page that includes the complete asset list to ensure everything is copied, and then delete the page prior to deploying.
{% for asset in assets -%}
    {% asset '{{ asset[0] }}' %}
{%- endfor %}

Steps

Add an image to the asset folder
Reference it somewhere using {{ assets[myasset.jpg].digest_path }}
delete _site and then restart the server.

Output
The asset will not be copied.
Expected
The asset should be copied to the asset folder.

This is by design because assets is just a reference point.  As for working around it, there is no need to do that, you can do precompile: [] just like on Rails and have those assets found and compiled when you chose to reference them in that way.  But {{ assets[myasset.jpg].digest_path }} is the same as {% asset myasset.jpg @path %} if you want to have the asset compiled & reference just data portions.

But {{ assets[myasset.jpg].digest_path }} is the same as {% asset myasset.jpg @path %} if you want to have the asset compiled & reference just data portions.

Ah nice, that's good to know. My Ruby knowledge is pretty mediocre, since the nomenclature is different between the two methods, I can't just reverse engineer the properties available. Is there a way to inspect the properties available via the @ syntax, or is @path the only one that I'd ever want to reference that way?

Ah, never mind, I assume that is what is documented here: https://github.com/envygeeks/jekyll-assets#arguments


The ":" came back

In the output pass when the source css gets copied to dest a ":" get's added in the dest folder.

Turns out it was in topdoc-default-theme, so closing this because we fixed it there.

@misterbrownlee I just published v1.0.6 (beta) with the updated dependency included.


Bump Ruby to 2.6.6

What
Use Ruby 2.6.6 now that PaaS ships v1.8.17 that includes that Ruby version. (Verified with cf buildpacks in production.)
How to review
Observe that CI still passes. Not much more than that, really.
Links
https://trello.com/c/B4bzl5Zl/109-upgrade-to-ruby-266-for-all-forms-apps-when-the-cloudfoundry-ruby-buildpack-releases-a-new-version-that-supports-it

I had to push an empty commit (that I've now rebased away) to trigger the tests again after a GitHub incident that lead to "an unexpected error" occurring with the workflow.


Support for storybook 8.X.X

Hello, thank you for your work on this package. I thoroughly enjoy using this functionality, but with the introduction of storybook version 8+, it looks like this package has become incompatible due to explicitly relying on the 7.X.X major version in the package.json.
Happy to offer my support as well if needed! 😎
🩺 The doctor is checking the health of your Storybook..
╭ Incompatible packages found ───────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                │
│   The following packages are incompatible with Storybook 8.0.4 as they depend on different major versions of Storybook packages:   │
│   -<EMAIL_ADDRESS>                                                                                │
│    Repo: https://Sotaneum.github.io/storybook-addon-useragent                                                                      │
│                                                                                │
│                                                                                │
│   Please consider updating your packages or contacting the maintainers for compatibility details.                                  │
│   For more on Storybook 8 compatibility, see the linked GitHub issue:                                                              │
│   https://github.com/storybookjs/storybook/issues/26031                                                                            │
│                                                                                │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

You can always recheck the health of your project by running:
npx storybook doctor

This message can be generated by upgrading an existing project using your add-on and storybook using the command:
npx storybook@latest upgrade

Followed by the auto migrate step, which will output the warning above:
npx storybook automigrate

My package details:
...
"storybook": "^8.0.4",
"storybook-addon-useragent": "^7.0.0",
...

@thenick775
Thank you for creating the issue. The add-on is now available in Storybook v8.
Updates can be done as follows:
npm i -D storybook-addon-useragent@8


shearn89: Watch excellentinteriorthanjai.com

shearn89 requests the watch of the watch_keyword excellentinteriorthanjai\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

excellentinteriorthanjai\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ


Version constraints break 'use-latest-versions' when property-based versions are present

Description:
In version 2.2 of the versions-maven-plugin, the 'use-latest-versions' would ignore versions that were declared as a property. This issue has already been identified by #99 and #109.  However, this change in behavior also introduces another problem documented in this issue where the specification of version constraints ( allowMajorUpdates, DallowMinorUpdates, allowIncrementalUpdates) breaks when a property-based version is encountered.  Ideally it would be beneficial to have the behavior of the 2.2 version restored as it would eliminate this issue and also restore the ability to use a combination of property-based and non-property based versions within a given pom.  The versions could then be managed via the 'update-property' and 'use-latest-versions' goals respectively without conflict.
There may be a relationship to #205
Test Case (developed using with Maven 3.5.0)
Project 'a'
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>test</groupId>
    <artifactId>a</artifactId>

    <version>1.0.1-0-SNAPSHOT</version>
    <packaging>jar</packaging>
    <name>${project.artifactId}</name>

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    </properties>
</project>

Project 'b'
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>test</groupId>
    <artifactId>b</artifactId>

    <version>1.0.2-0-SNAPSHOT</version>
    <packaging>jar</packaging>
    <name>${project.artifactId}</name>

    <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <dependency.a.version>1.0.4-SNAPSHOT</dependency.a.version>
    </properties>

    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>test</groupId>
                <artifactId>a</artifactId>
                <version>${dependency.a.version}</version>
            </dependency>
        </dependencies>
    </dependencyManagement>
</project>

File Structure:
test
├── a
│   └── pom.xml
└── b
    └── pom.xml

Test setup:
Stage 1.0.1-0-SNAPSHOT and 1.0.2-0-SNAPSHOT versions of project 'a'
(cd a; mvn clean install)
(cd a; mvn build-helper:parse-version versions:set -DgenerateBackupPoms=false -DnewVersion='${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}-${parsedVersion.nextBuildNumber}-SNAPSHOT')
(cd a; mvn clean install)

Build 'b' that depends on version 1.0.1-0-SNAPSHOT of 'a' (verifies build works)
(cd b; mvn clean install)
Test steps:
Attempt to bump version to next incremental snapshot buildnumber using specific version of versions-maven-plugin (version > 2.2):
(cd b; mvn org.codehaus.mojo:versions-maven-plugin:2.5:use-latest-versions -DgenerateBackupPoms=false -DallowMajorUpdates=false -DallowMinorUpdates=false -DallowIncrementalUpdates=false -DallowSnapshots=true)

Results with versions-maven-plugin > 2.2:

[ERROR] Failed to execute goal org.codehaus.mojo:versions-maven-plugin:2.5:use-latest-versions (default-cli) on project b: Execution default-cli of goal org.codehaus.mojo:versions-maven-plugin:2.5:use-latest-versions failed: Invalid segment, 2, for the 1 segment version: '${dependency.a.version}' -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

Attempt to bump version to next incremental snapshot buildnumber using specific version of versions-maven-plugin (version = 2.2):
(cd b; mvn org.codehaus.mojo:versions-maven-plugin:2.2:use-latest-versions -DgenerateBackupPoms=false -DallowMajorUpdates=false -DallowMinorUpdates=false -DallowIncrementalUpdates=false -DallowSnapshots=true)

Results with versions-maven-plugin = 2.2:

Nothing changes since the version is declared as a property

Attempt to bump version without constraints using specific version of versions-maven-plugin:
(cd b; mvn org.codehaus.mojo:versions-maven-plugin:2.5:use-latest-versions -DgenerateBackupPoms=false -DallowSnapshots=true)

Results with versions-maven-plugin > 2.2:

The property is replaced with the new version

git diff b/pom.xml
diff --git a/b/pom.xml b/b/pom.xml
index f893352..318627f 100644
--- a/b/pom.xml
+++ b/b/pom.xml
@@ -19,7 +19,7 @@
             <dependency>
                 <groupId>test</groupId>
                 <artifactId>a</artifactId>
-                <version>${dependency.a.version}</version>
+                <version>1.0.1-1-SNAPSHOT</version>
             </dependency>
         </dependencies>
     </dependencyManagement>

Results with versions-maven-plugin = 2.2:

Nothing changes since the version is declared as a property

Looks like the old behaviour has been reverted by #340. Can be closed @slachiewicz


operator new emulation and coverity

The emulation of the new operator to throw bad alloc and provide aligned memory for the VMCS is causing issues with Coverity. To be honest, Clang-Tidy and some of the -W warnings were also having issues with the code, so I think it makes sense to see if there is a different approach that these checks aren't as finicky about.

The PR seems to have addressed this issue. We will need to at some point apply this code to the other unit tests, but so far Coverity doesn't seem to be upset about those, so I am closing this.


package_project() creates strange install paths for CMAKE_INSTALL_INCLUDEDIR

my CMakeLists.txt contains this:
# ---- Create library ----

# Note: for header-only libraries change all PUBLIC flags to INTERFACE and create an interface
# target: add_library(${PROJECT_NAME} INTERFACE)
add_library(${PROJECT_NAME} ${headers} ${sources})
add_library(${PROJECT_NAME}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})
target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_20)

# being a cross-platform target, we enforce standards conformance on MSVC
target_compile_options(${PROJECT_NAME} PRIVATE "$<$<COMPILE_LANG_AND_ID:CXX,MSVC>:/permissive->")

# Link dependencies
target_link_libraries(${PROJECT_NAME} PUBLIC fmt::fmt)

# FIXME: should be PRIVATE! CK
target_link_libraries(${PROJECT_NAME} PUBLIC project_warnings project_options)

# target_include_directories with the SYSTEM modifier will request the compiler
# to omit warnings from the provided paths, if the compiler supports that
target_include_directories(
  ${PROJECT_NAME} SYSTEM PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
                                $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
)

if(CMAKE_SKIP_INSTALL_RULES)
  return()
endif()

# ---- Create an installable target ----
# this allows users to install and find the library via `find_package()`.

# Add other targets that you want installe here. Or be default we just package
# all targets recursively found for the current folder if not specified.
package_project(
  NAME ${PROJECT_NAME}
  TARGETS ${PROJECT_NAME} project_options project_warnings
  PUBLIC_INCLUDES ${PROJECT_SOURCE_DIR}/include
  PUBLIC_DEPENDENCIES_CONFIGURED "fmt 8.1.1"
  # FIXME: not yet used! PRIVATE_DEPENDENCIES_CONFIGURED project_options project_warnings
)

cmake -B ./build-ModernCmakeStarter-Debug -S /Users/clausklein/Workspace/cpp/ModernCmakeStarter/all -D OPT_ENABLE_COVERAGE=NO -DOPT_WARNINGS_AS_ERRORS=NO
-- CPM: adding package<EMAIL_ADDRESS>(v3.0.0 at /Users/clausklein/.cache/CPM/cxxopts/0c1df694f5ab3306e541038e6a2ed62926062894)
-- CPM: adding package greeter@ (/Users/clausklein/Workspace/cpp/ModernCmakeStarter/standalone/..)
-- CPM: greeter: adding package<EMAIL_ADDRESS>(v0.20.0 at /Users/clausklein/.cache/CPM/project_options/f4f28e0d6a43eb4247d834f6b906d21040cf1ef9)
-- CPM: greeter: adding package<EMAIL_ADDRESS>(v1.8.0 at /Users/clausklein/.cache/CPM/packageproject.cmake/987b02f8a9fe04de3c43e0e7a1afbb29c87adc5e)
-- Module support is disabled.
-- Version: 8.1.1
-- Build type: Debug
-- CXX_STANDARD: 20
-- Required features: cxx_variadic_templates
-- CPM: greeter: adding package<EMAIL_ADDRESS>(8.1.1 at /Users/clausklein/.cache/CPM/fmt/15c05aa781ab44fa13a906fe5737c1d14e5edee9)
-- Developer mode is ON. For production, use `-DENABLE_DEVELOPER_MODE:BOOL=OFF`. Building the project for the developer...
-- The default CMAKE_C_STANDARD used by external targets and tools is not set yet. Using the latest supported C standard that is 90
-- /usr/local/bin/ccache found and enabled
-- CPM: adding package<EMAIL_ADDRESS>(v2.4.8 at /Users/clausklein/.cache/CPM/doctest/367f22d2dff85570a9f727b99741f9e40b17df46)
-- CPM: adding package<EMAIL_ADDRESS>(v1.7.3 at /Users/clausklein/.cache/CPM/format.cmake/17e103764947115e78d95ecc29c4bee54dc64e08)
-- CPM: adding package Greeter@ (/Users/clausklein/Workspace/cpp/ModernCmakeStarter/test/..)
-- CPM: adding package m.css@0 (a0d292ec311b97fefd21e93cdefb60f88d19ede6 at /Users/clausklein/.cache/CPM/m.css/23b42fe3166cf5c34c25c267ae0664557edd2200)
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/clausklein/Workspace/cpp/ModernCmakeStarter/build-ModernCmakeStarter-Debug
DESTDIR=/Users/clausklein/Workspace/cpp/stage cmake --install ./build-ModernCmakeStarter-Debug --prefix /usr
-- Install configuration: "Debug"
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/cxxopts/cxxopts-config.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/cxxopts/cxxopts-config-version.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/cxxopts/cxxopts-targets.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/cxxopts.hpp
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/pkgconfig/cxxopts.pc
-- Installing: /Users/clausklein/Workspace/cpp/stage/usr/lib/libfmtd.a
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/fmt/fmt-config.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/fmt/fmt-config-version.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/fmt/fmt-targets.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/cmake/fmt/fmt-targets-debug.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/args.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/chrono.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/color.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/compile.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/core.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/format.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/format-inl.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/locale.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/os.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/ostream.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/printf.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/ranges.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/include/fmt/xchar.h
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/lib/pkgconfig/fmt.pc
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter/greeter.h
-- Installing: /Users/clausklein/Workspace/cpp/stage/usr/lib/libgreeter.a
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterConfigVersion.cmake
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterConfig.cmake
-- Old export file "/Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterTargets.cmake" will be replaced.  Removing files [/Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterTargets-debug.cmake].
-- Installing: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterTargets.cmake
-- Installing: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/greeterTargets-debug.cmake
-- Installing: /Users/clausklein/Workspace/cpp/stage/usr/share/greeter/usage
-- # The package greeter provides the following CMake targets:

    find_package(greeter CONFIG REQUIRED)
    target_link_libraries(main PRIVATE  greeter::greeter greeter::project_options greeter::project_warnings)

bash-3.2$

This installed CMake config packages contains:
# Create imported target greeter::greeter
add_library(greeter::greeter STATIC IMPORTED)

set_target_properties(greeter::greeter PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_std_20"
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "fmt::fmt;greeter::project_warnings;greeter::project_options"
  INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "include"
)

# Create imported target greeter::project_options
add_library(greeter::project_options INTERFACE IMPORTED)

set_target_properties(greeter::project_options PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_std_20"
  INTERFACE_COMPILE_OPTIONS "-fsanitize=address,undefined"
  INTERFACE_LINK_OPTIONS "-fsanitize=address,undefined"
)

# Create imported target greeter::project_warnings
add_library(greeter::project_warnings INTERFACE IMPORTED)

set_target_properties(greeter::project_warnings PROPERTIES
  INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:-Wall;-Wextra;-Wshadow;-Wnon-virtual-dtor;-Wold-style-cast;-Wcast-align;-Wunused;-Woverloaded-virtual;-Wpedantic;-Wconversion;-Wsign-conversion;-Wnull-dereference;-Wdouble-promotion;-Wformat=2;-Wimplicit-fallthrough>;\$<\$<COMPILE_LANGUAGE:C>:-Wall;-Wextra;-Wshadow;-Wcast-align;-Wunused;-Wpedantic;-Wconversion;-Wsign-conversion;-Wnull-dereference;-Wdouble-promotion;-Wformat=2;-Wimplicit-fallthrough>;\$<\$<COMPILE_LANGUAGE:CUDA>:-Wall;-Wextra;-Wunused;-Wconversion;-Wshadow>"
)
``

Where is the strange part?

-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter
-- Up-to-date: /Users/clausklein/Workspace/cpp/stage/usr/.//include/greeter/greeter.h

It seems correct to me. I don't see any issue here.

It seems correct to me. I don't see any issue here.

Yes, it is correct, but my be prevented to be clear.
It looks strange in context of the other install messages.
see normal-path

The correct usage message should:
find_package(greeter CONFIG REQUIRED)
target_link_libraries(main PRIVATE greeter::greeter)

It seems correct to me. I don't see any issue here.

Yes, "seems" it is correct, but may be prevented to be clear. It looks strange in context of the other install messages. see normal-path
And discourse.cmake.org/t/target-include-directories-mylib-system-is-exported-without-import-prefix/5359 !

The reporting is just for information and debugging purposes. CMake itself should normalize the paths before installation if that is important for you.

target_link_libraries(main PRIVATE greeter::greeter)

That is subjective. When you export greeter::project_optinos, you cannot expect CMake to hide that target. Someone might really want to link with project_options.

The correct usage message should:
find_package(greeter CONFIG REQUIRED)
target_link_libraries(main PRIVATE greeter::greeter)

This links fmt::fmt;greeter::project_warnings;greeter::project_options implicitly.


⚠ AGEG website (prod) has degraded performance

In 0cbb14d, AGEG website (prod) (https://www.ageg.ca/) experienced degraded performance:

HTTP code: 200
Response time: 3088 ms

Resolved: AGEG website (prod) performance has improved in 28a9e33.


Add class to dates in range

Hi,
Can you please add a class to dates which are placed between the start and the end date of a selected range?

Hi @vlio20, can you prepare a pull request for that?

@jandudulski take a look at my repo https://github.com/outbrain/pure-angular-date-range-picker

I believe this has already been added in 333cf6d83204c166f4d4488a71ab601a9134a9ab.


Is there an alternative?

Is there an up to data version of this plugin? Or something similar? Looks like developement has stopped. Are there alternatives for this plugin? Or was it replaces with something else? Looks like really cool plugin. Please let us know :)

sbt-revolver is working nicely also with the current SBT versions.
Is there sth that doesn't work for you?

sbt-revolver doesn't seem to be published anywhere, at least not where sbt is expecting it at https://repo1.maven.org/maven2/io/spray/sbt-revolver_2.12_1.0/0.9.1/sbt-revolver-0.9.1.pom
Do you know if it is published somewhere else?

Do you know if it is published somewhere else?

Yes, it is published to https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases (and sbt will normally find it there), but this repo is currently down. You can track this at https://github.com/sbt/sbt/issues/7202


Make Kafka Page generic to work with multiple services - not only kafka

Goal

Tasks

We need to remove Kafka as mentioned service (use catalog item possibly
We need to have database that we will use - Mongo/Postgress
We need to have descriptions.
We need to have icon (as svg inline string)
We need node.js app that will look if /bindings folder to exist)

const fs = require("fs")

if(fs.existSync("/bindings")) process.exit(1)

Requirements

Sample PR: https://github.com/redhat-developer/app-services-openshift-console-plugin/pull/169


Bug: README is incorrect

README includes:

npx @defi-wonderland/natspec-smells --include src

But --include src will error out with Error: There must be at least one file to compile.

Thanks for the report, the readme should say --include "src/**/*.sol".


Write zarr stores with manifest.json files to non-local storage

Awesome to see this develop, Tom!
Is there a goal of being able to write to non-local storage devices? If so we'd need a different (fsspec?) opener for the context manager?
Originally posted by @cisaacstern in https://github.com/TomNicholas/VirtualiZarr/pull/45#discussion_r1535907782

@cisaacstern I think now that Icechunk exists this is probably out of date? Or is there still something to do if someone wanted to dump kerchunk references into a bucket?

👋 @TomNicholas, I guess it depends if you want these methods
https://github.com/zarr-developers/VirtualiZarr/blob/7a35bd41d980e1809ba2e6a1777a740ae41d184f/virtualizarr/manifests/manifest.py#L439-L452
to be able to read json from a cloud bucket or any other non-local device.
If so, then I would say this issue is still open. If not, then fine to close!
Not sure if/how the existence of Icechunk relates to this, but at the level of those specific methods it appears to my naive eye as unrelated?
In terms of my own requirements (none), I am personally fine if this is out of scope / wontfix.

Thanks for the clarification @cisaacstern - I think this can be closed, see https://github.com/zarr-developers/VirtualiZarr/issues/359 for the reasoning.


Update contact panel

This PR:

adds guidance on how to propose content changes (open PRs) using GitHub to the Community section
includes a new design of the "Get in touch" panel at the bottom of the pages in the Design System
adds a "Help improve this page" section to the bottom of style, component and pattern changes with links to the backlog, the markdown file and the new guide on proposing changes
removes empty research sections from component and pattern pages

You can preview this change here:
Built with commit dd4b002be165c21bd87995572d071ae8b5a7a766
https://deploy-preview-969--govuk-design-system-preview.netlify.com

Hey Amy,
Do you want some help squashing these commits down to clean them up?

We split the GitHub guide into its own branch and opened #970 – once that's reviewed we can rebase this branch and squash it down to just include the changes to the contact panel.

Rebased onto add-github-guide (because the tests will fail if we rebase onto master because of broken links to the GitHub guide) and split out the addition of the 'Propose a change using GitHub' guide.
Before force-pushing, I diff'ed against dd4b002 and made sure the only differences were in the community section (and Dave's change to img widths in src/stylesheets/main.scss):
$ git diff --name-only origin/update-contact-panel
src/community/contribution-criteria/index.md.njk
src/community/design-system-working-group/index.md.njk
src/community/develop-a-component-or-pattern/index.md.njk
src/community/propose-a-component-or-pattern/index.md.njk
src/community/propose-a-content-change-using-github/checkboxes-folder-github.png
src/community/propose-a-content-change-using-github/checkboxes-lowercase.png
src/community/propose-a-content-change-using-github/checkboxes-uppercase.png
src/community/propose-a-content-change-using-github/create-pull-request-first-view-github.png
src/community/propose-a-content-change-using-github/create-pull-request-view-github.png
src/community/propose-a-content-change-using-github/design-system-github-repo.png
src/community/propose-a-content-change-using-github/fork-this-repo.png
src/community/propose-a-content-change-using-github/github-edit-file-pencil-icon.png
src/community/propose-a-content-change-using-github/index.md.njk
src/community/propose-a-content-change-using-github/propose-file-change.png
src/stylesheets/main.scss


cli: Support clean up for persist-nic-names command

The whole workflow:

Use nmstatectl persist-nic-names to pin every ethernet interface to its
MAC via systemd .link file.
After boot into new environment, nmstatectl persist-nic-names --cleanup
will remove un-required systemd .link file.

Key tech point:
Use `udevadm test-builtin net_id /sys/class/net/<iface_name>` to check
systemd preferred interface name and compare to current interface
name.

Extra changes:

Removed should_persist_nic_for() as we are pinning every ethernet
interface.
Comment changed from \\\ to \\ as this is not public
documentation.
The --cleanup might require chroot if running environment holds
different systemd/udev config than real host.

Tested:

CentOS stream 9 VM by renaming a existing interface to new name.

RHEL 8.8 and CentOS stream 9 on Mellanox MT27710:

Not from upgrade, just reinstall CentOS stream 9 and restored the
nmstate created .link files.

Test log on Mellanox MT27710:

RHEL 8

[root@hpe-apache-cn99xx-03 nmstate]# nmstatectl  persist-nic-names
[2023-04-11T05:32:24Z INFO  nmstatectl::persist_nic] Would persisting the interface enp11s0f0 with MAC f4:03:43:fe:60:f6
[2023-04-11T05:32:24Z INFO  nmstatectl::persist_nic] Systemd network link file created at /etc/systemd/network/98-nmstate-enp11s0f0.link
[2023-04-11T05:32:24Z INFO  nmstatectl::persist_nic] Would persisting the interface enp11s0f1 with MAC f4:03:43:fe:60:f7
[2023-04-11T05:32:24Z INFO  nmstatectl::persist_nic] Systemd network link file created at /etc/systemd/network/98-nmstate-enp11s0f1.link

CentOS stream 9:

[root@hpe-apache-cn99xx-03 ~]# nmstatectl persist-nic-names --cleanup --dry-run
[2023-04-11T08:12:20Z INFO  nmstatectl::persist_nic] Found persisted NIC(enp11s0f0) file: 98-nmstate-enp11s0f0.link
[2023-04-11T08:12:20Z INFO  nmstatectl::persist_nic] Found persisted NIC(enp11s0f1) file: 98-nmstate-enp11s0f1.link
[2023-04-11T08:12:20Z INFO  nmstatectl::persist_nic] Systemd generate interface name 'enp11s0f1np1' != pinned name 'enp11s0f1', will keep config file /etc/systemd/network/98-nmstate-enp11s0f1.link
[2023-04-11T08:12:20Z INFO  nmstatectl::persist_nic] Systemd generate interface name 'enp11s0f0np0' != pinned name 'enp11s0f0', will keep config file /etc/systemd/network/98-nmstate-enp11s0f0.link

The --cleanup might require chroot if running environment holds
different systemd/udev config than real host.

Yes, this is currently going to be required; in the OCP flow we're shipping this nmstate binary in a privileged container which is based on rhel8.

@cgwalters New patch uploaded. Thanks for the review!

Looking forward to this!  One thing that'd probably be good as a followup is some sort of automated CI for this.

Our current CI setup is running tests inside of a container where there is no real ethernet interface to play with.
I am afraid we need downstream QE on CI automation like we did for tests on SR-IOV, Infiniband and etc.

I have uploaded RHEL 8(also works in RHEL 9) compiled binary for this PR:
https://people.redhat.com/fge/bz_2182769/nmstatectl_persist_nic_names_2

Should --cleanup delete the stamp file too? One could imagine wanting to do this again in the future (e.g. for RHEL9 to RHEL10) and it'd make sense to reuse the same stamp file instead of having different ones each time since nmstate itself is agnostic to the RHEL version transition happening. But also from the MCO point of view, being able to key off of the presence of the stamp file to know if to run --cleanup would be helpful so that we don't have to maintain our own secondary stamp.

Threw something up in https://github.com/nmstate/nmstate/pull/2316! Let's chat there.


ValueError: invalid literal for int() with base 10: ''

I am getting the following error when I try to render a graph with vim-jukit, can you help me solve this?
## -- End pasted text --
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [7], in <cell line: 160>()
    156 smart_house = Agente(ambiente_atuacao)
    157 smart_house.executa_agente(20)
--> 160 Imprime.imprime_resultado(smart_house)

Input In [7], in Imprime.imprime_resultado(agente)
    129 plt.plot(historico_dias, agente.ambiente.historico_preco, 'bo--', label='Historico (preço)')
    130 plt.legend()
--> 131 plt.show()
    133 # Segunda impressão: historico qtde itens comprados
    134 fig, ax = plt.subplots()

File ~/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/matplotlib/pyplot.py:368, in show(*args, **kwargs)
    324 """
    325 Display all open figures.
    326
   (...)
    365 explicitly there.
    366 """
    367 _warn_if_gui_out_of_main_thread()
--> 368 return _backend_mod.show(*args, **kwargs)

File ~/.vim/plugged/vim-jukit/helpers/matplotlib-backend-kitty/__init__.py:66, in _BackendICatAgg.show(*args, **kwargs)
     65 def show(*args, **kwargs):
---> 66     _Backend.show(*args, **kwargs)
     67     Gcf.destroy_all()

File ~/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/matplotlib/backend_bases.py:3524, in _Backend.show(cls, block)
   3522 for manager in managers:
   3523     try:
-> 3524         manager.show()  # Emits a warning for non-interactive backend.
   3525     except NonGuiException as exc:
   3526         _api.warn_external(str(exc))

File ~/.vim/plugged/vim-jukit/helpers/matplotlib-backend-kitty/__init__.py:38, in FigureManagerICat.show(self)
     36 # gather terminal dimensions
     37 px = icat('--print-window-size')
---> 38 px = list(map(int, px.split('x')))
     40 # resize figure to terminal size & aspect ratio
     41 dpi = self.canvas.figure.dpi

ValueError: invalid literal for int() with base 10: ''

also, my %paste is not working!
Idk if I configured wrong, but I get in line one and go to the last with shift+v and then press Y, when I hit enter it dosent work.
How it realy work?

Hi!
Please specify the kitty version you're using (kitty --version in your terminal).
In your terminal, what is the output of kitty +kitten icat --print-window-size?
For the mappings used to send code to the terminal please refer to the readme, by default simply press enter to send the current line, press enter while in visual mode to send the current visual selection, +space to send code within current section (i.e. between cell markers), etc.. If you already have other mappings for those keys or want to set different ones, you can do so in your vim config.

kitty 0.24.4 created by Kovid Goyal

 > kitty +kitten icat --print-window-size
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/usr/bin/../lib/kitty/__main__.py", line 185, in <module>
    main()
  File "/usr/bin/../lib/kitty/__main__.py", line 176, in main
    namespaced(['+', first_arg[1:]] + sys.argv[2:])
  File "/usr/bin/../lib/kitty/__main__.py", line 129, in namespaced
    func(args[1:])
  File "/usr/bin/../lib/kitty/__main__.py", line 112, in run_kitten
    rk(kitten)
  File "/usr/bin/../lib/kitty/kittens/runner.py", line 120, in run_kitten
    runpy.run_module(f'kittens.{kitten}.main', run_name=run_name)
  File "/usr/lib/python3.10/runpy.py", line 212, in run_module
    return _run_code(code, {}, init_globals, run_name, mod_spec)
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/usr/bin/../lib/kitty/kittens/icat/main.py", line 613, in <module>
    main()
  File "/usr/bin/../lib/kitty/kittens/icat/main.py", line 518, in main
    ss = screen_size_function(tty)()
  File "/usr/bin/../lib/kitty/kitty/utils.py", line 176, in __call__
    self.ans = read_screen_size(self.fd)
  File "/usr/bin/../lib/kitty/kitty/utils.py", line 156, in read_screen_size
    if fd < 0:
TypeError: '<' not supported between instances of '_io.TextIOWrapper' and 'int'

I instaled kitty as an pacman package with -Syu.

Thank you! I'll refer that issue on kitty repo.
As you help me I am closing that issue.

Hey it worked!!!
I instaled kitty just for this, usualy I use alacritty with tmux, but, I read on kitty page that uses tmux with kitty is bad, how you've been doing to switch betwen panes?
I looked on web for how doing that but I didnt find nothing about how to configure kitty.
Can you tell me more about your setup? @luk400

You should find most of what you'll need here. But for reference, my config file (@~/.config/kitty/kitty.conf) currently has (among others) the following (probably not super well thought out) mappings:
# use <alt> key as kitty_mod
kitty_mod alt

# close/create windows/tabs
map kitty_mod+enter new_window_with_cwd
map kitty_mod+q close_window
map kitty_mod+t new_tab_with_cwd

# move to next tab
map kitty_mod+space next_tab

# move between windows
map ctrl+j neighboring_window down
map ctrl+k neighboring_window up
map ctrl+h neighboring_window left
map ctrl+l neighboring_window right

# font size
map ctrl+plus change_font_size current +2.0
map ctrl+minus change_font_size current -2.0

# Clear the terminal screen by erasing all contents
map kitty_mod+backspace combine : clear_terminal clear active : send_text

# window resizing
map kitty_mod+< resize_window wider 3
map kitty_mod+shift+< resize_window narrower 3
map kitty_mod+plus resize_window taller 3
map kitty_mod+minus resize_window shorter 3

window_resize_step_cells 2
window_resize_step_lines 2

# moving windows around
map kitty_mod+k move_window up
map kitty_mod+h move_window left
map kitty_mod+l move_window right
map kitty_mod+j move_window down

# switch between layouts
map ctrl+, next_layout

# clipboard
map ctrl+shift+c copy_to_clipboard
map ctrl+shift+v paste_from_clipboard

# scrolling
map ctrl+shift+k scroll_page_up
map ctrl+shift+j scroll_page_down
map ctrl+shift+space scroll_end

I also have a file ~/.config/kitty/theme.conf which I load at the end of kitty.conf with include ./theme.conf, which contains the following:
background #1A1F36
foreground #ffffff
cursor #f0cb09
selection_background #18344f
color0 #000000
color8 #38fbdc
color1 #ff0000
color9 #92e117
color2 #37dd21
color10 #3bcf1d
color3 #fee409
color11 #ecc809
color4 #1460d2
color12 #5555ff
color5 #ff005d
color13 #ff55ff
color6 #00bbbb
color14 #6ae3f9
color7 #bbbbbb
color15 #ffffff
selection_foreground #122637
font_size 12
font_family JetBrains Mono Regular
background_opacity 0.9
cursor #ffffff


Bugfix2219

The bug is: when using --no-prelude to generate compiledDefinition for an empty module, there will be a NoSuchElementException. The is due to a lack of checks for the Optional (Java) or Option(scala) types before extracting values from them. To fix the bug, we created an empty-module for unit test and added checks for Optional and Options.  After adding checks, we were able to create a CompiledDefinition with its topCellInitializer of null value.
To further avoid Exceptions when running Krun program caused by having no cells in compiledDefinition, we passed the noPrelude flag from kRunOption.output to CompiledDefinition. Then we disabled definition parsing and rename anonymous variables when generating K program result for the empty-module. Meanwhile, we added more checks to avoid exceptions for null value K and null KApply's klable value.
Finally, we added test cases for non-empty module without --no-prelude parameter for regression test. We also added more test cases for kast program, KAST and BINARY pretty print modes.
┆Issue is synchronized with this Asana task

@cos  Thank you for your suggestions. Do you mean that we can create a placeholder Sort:
E.g. val KNull  = Sort("KNull") as a built-in Sort in Sorts.java and use Sorts.KNull to replace all null value check for Sort?
Should we have null value placeholders for KLable and KApply as well?

You can use the top sort, i.e., K as a "null" sort. For terms, yes, I'm suggesting to add a KLabel, named something like "", and make a term of arity 0 from it, i.e., KApply(KLabel("<empty>"), List()) .

@cos Thank you. So we should use Sorts.K to replace null sort right?

So we should use Sorts.K to replace "null" sort right?

Yes.

Could we use the KORE.KLabel("") for "null" KLabel?

No, use something like "", obtained by adding a production to the definition.

Hi @cos. Thank you for providing more details. However, I still have a hard time to understand what type of KLabel should be used. Could we schedule an appointment with you at any time on Dec.12(Mon) after 5:00pm or any time after Dec.12?

We can meet today at 5pm if you like.

@cos Thank you. Where can I find you?

Thanks to @cos explanation, we found that we misunderstood the root cause of this bug. A better description and fix is in this newer pull request: https://github.com/kframework/k/pull/2249.


Feature/new forms

Description
Forms for the Agri and Forestry apps. Tons of code duplication, can start the extracting out for refactoring from here.
Some wording/UI still TBD

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

SonarQube Analysis: https://sonarqube-vmvfjv-tools.pathfinder.gov.bc.ca/dashboard?id=common-forms-toolkit-pr-82


DynamicResource color not working on Border

This doesn't work
<yummy:PancakeView.Border>
   <yummy:Border  Thickness="3" Color="{DynamicResource AccentColour}" />
</yummy:PancakeView.Border>

but this does
<yummy:PancakeView.Border>
     <yummy:Border Thickness="3" Color="{StaticResource AccentColour}" />
</yummy:PancakeView.Border>

That sounds odd. Not quite sure what be causing that to be honest. Would have to dig deeper.
Not quite sure when I'd get around to that though.

It looks like this problem starts after upgrading 1.4.2 to <IP_ADDRESS>1+.  Downgrading to 1.4.2 solves the problem for us.

Yes, seeing this today with my app as well :(

This is most likely due to the object that this border is created by doesn't get notified appropriately by the changing runtime resource and hence doesn't cause a redraw. However, the bindable property itself has not been changed, just moved elsewhere, so I would kind expect the same behavior. So far I don't have a fix.

This problem is also happening with the GradientStop colors in the BackgroundGradientStops collection.
       <custom:PancakeView
        BackgroundGradientStartPoint="0,0"
        BackgroundGradientEndPoint="0,1"
        HasShadow="False"
        CornerRadius="0">

        <custom:PancakeView.BackgroundGradientStops>
            <custom:GradientStopCollection>
                <custom:GradientStop
                    Color="{DynamicResource GradiantBlueToOrange_End}"
                    Offset="0" />
                <custom:GradientStop
                    Color="{DynamicResource GradiantBlueToOrange_Start}"
                    Offset="1" />

            </custom:GradientStopCollection>
        </custom:PancakeView.BackgroundGradientStops>

Got the same problem with BackgroundGradientStops =/

Hi @sthewissen , same here - Border color set by DynamicResource is not working
commented xaml was for previous versions of PancakeView.
Also, the changes made in this XAML doesn't reflect when using Xamarin HotReload. Any clue on that also ?
                              <yummy:PancakeView
                                    x:Name="SDPancakeView"
                                    Margin="5"
                                    BackgroundColor="{DynamicResource MainMenuItemsBackgroundColor}"
                                    BackgroundGradientEndPoint="1,0"
                                    BackgroundGradientStartPoint="0,0"
                                    CornerRadius="{DynamicResource SDPancakeViewCR}"
                                    HeightRequest="50"
                                    HorizontalOptions="FillAndExpand"
                                    IsClippedToBounds="True">

                                    <!--

The issue still appears.

@sthewissen  hi there . Would you be able to look at this one, I am implementing DarkMode app and dynamic resource on the border does not work!. Oh can you suggest any workaround?

Ye same issue here when setting the Border and BackgroundGradientStops

it's a pity that is not supported as it's a wonderful control, we removed pancakeView from all our projects as we could not make it work with dynamicResource and it was essential as we had to support darkmode.

it's a pity that is not supported as it's a wonderful control, we removed pancakeView from all our projects as we could not make it work with dynamicResource and it was essential as we had to support darkmode.

might need to do the same tbh

Sorry to hear it. I simply don't have the time to investigate/implement this right now. I wish it were different, but the repo is open to PRs if it's a must-have for you.


transport_mqtt_1 times out

Using the develop branch from https://github.com/ScreamBun/openc2-oif-device
Running docker-compose -f device-compose.yaml up fails during bootstrap:
...
actuator-base_1    | Connected to amqp://queue:5672 on queue oc2ls_version_1.0_json_schema with [Bind:{Exchange actuator(direct)->oc2ls_version_1.0_json_schema},Bind:{Exchange actuator_all(fanout)->actuator_all}] and waiting to consume...
queue_1            | 2022-07-06 17:29:48.250622+00:00 [info] <0.729.0> accepting AMQP connection <0.729.0> (<IP_ADDRESS>:34060 -> <IP_ADDRESS>:5672)
queue_1            | 2022-07-06 17:29:48.256921+00:00 [info] <0.729.0> connection <0.729.0> (<IP_ADDRESS>:34060 -> <IP_ADDRESS>:5672): user 'guest' authenticated and granted access to vhost '/'
transport-mqtt_1   | KEY: oc2ls_version_1.0_json_schema -> aafdb86e-d9f1-4867-ad47-7a8be38f82b4
transport-mqtt_1   | KEY: slpf -> d08d5cd8-e5b3-471f-861e-c88583658507
transport-mqtt_1   | Traceback (most recent call last):
transport-mqtt_1   |   File "./MQTT/mqtt_transport.py", line 74, in <module>
transport-mqtt_1   |     client.connect(
transport-mqtt_1   |   File "/usr/lib/python3.8/site-packages/paho/mqtt/client.py", line 914, in connect
transport-mqtt_1   |     return self.reconnect()
transport-mqtt_1   |   File "/usr/lib/python3.8/site-packages/paho/mqtt/client.py", line 1044, in reconnect
transport-mqtt_1   |     sock = self._create_socket_connection()
transport-mqtt_1   |   File "/usr/lib/python3.8/site-packages/paho/mqtt/client.py", line 3685, in _create_socket_connection
transport-mqtt_1   |     return socket.create_connection(addr, timeout=self._connect_timeout, source_address=source)
transport-mqtt_1   |   File "/usr/lib/python3.8/socket.py", line 808, in create_connection
transport-mqtt_1   |     raise err
transport-mqtt_1   |   File "/usr/lib/python3.8/socket.py", line 796, in create_connection
transport-mqtt_1   |     sock.connect(sa)
transport-mqtt_1   | socket.timeout: timed out

Expected all the containers to come up w/o errors. Wondering if it's my environment or something else the matter. Any thoughts would be appreciated.

A transport would error like this when it cannot connect to the intended host. In the case of MQTT, it is likely due to not being able to connect to the broker.
The docs should have instructions to change the broker that is being used. Updating the MQTT_HOST key from the environment of the transport-mqtt service in the device-compose.yaml file should resolve the connection timeout. The value given should be the MQTT broker that you intend to use.


The DDL subsystem generates a wrong install.sql for EPC

The type EPC_CLNT_OBJECT depends on STD_OBJECT but it will be created first since listed alphabetically.

Maybe a good solution is to add a creation date order to the list of objects (USER_OBJECTS.CREATED). Change the type number (R__.[.]FUNCTION or .[.]TABLE) into a sequence number sorted by creation date.

Or -

A new interface version (pkg_ddl_util v5) has been introduced. The sequence number depends on file install_sequence.txt which initially depends on the object dependency order (the less dependencies the lower the sequence number). This file can be edited by the user.

The sequence number in that case is a 4 digit number (zero left padded).


test swap router

I have created a PR #94 on top of this one. I prefer using the assert_eq on the base types rather than mapping those onto felt252.


Elixir 1.12.0-rc.1 and cowlib 2.11.0 create unbootable release

At the moment, the mix.lock file is set to cowlib 2.9.1 and this version works. Something changed with cowlib 2.11.0 that causes rebar3 to not build any cowlib .beam files. You can see this by updating to 2.11.0 (mix deps.update --all is easiest) and then looking in _build/.../lib/cowlib/ebin. Only the .app file is there. Since this is not an error, firmware is made, but it will fail to boot since modules can't be loaded.
Building with Elixir 1.11.4 and cowlib 2.11.0 works fine.
The original thought was that this was due to using an old version of rebar3. This was the case, but updating it did not fix the issue:
$ rebar3 --version
rebar 3.14.4 on Erlang/OTP 23 Erts 11.2

I'm able to reproduce this on OSX and Linux computers and I have cleared both of all rebar3 binaries that are not 3.14.4. The only ones left are the ones installed by mix local.rebar.
So far I have been unable to reproduce this issue on smaller projects. I was suspecting that it might have something to do with Mix targets, but that doesn't seem to be the case. The only other hint may be that Nerves sets some environment variable that interferes with whatever changed in mix's invocation of rebar3.

I figured out how to reproduce: https://github.com/elixir-lang/elixir/issues/10978


fix(@angular/ssr):  include Content-Language header when locale is set

The server now includes the Content-Language HTTP header in responses whenever a locale is explicitly set.

The changes were merged into the following branches: main, 19.0.x


Arreglo de getAmount()

@cesarcf Can you please do this PR under the repository https://github.com/PaymentSuite/paymentsuite please? This one is read-only :)
And could you please explain a little bit about your fix?
Thanks :)

ok! me acabo de descargar ese repositorio, y ya viene arreglado! ;)

@cesarcf wow, this is not a good notice indeed! We need to check how this repository is splitted :)
Thanks!


Use assert/require in test code of exporter

#266
Signed-off-by: Hui Kang<EMAIL_ADDRESS>

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #286   +/-   ##
=======================================
  Coverage   73.13%   73.13%
=======================================
  Files         111      111
  Lines        6446     6446
=======================================
  Hits         4714     4714
  Misses       1488     1488
  Partials      244      244

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ab342...c49b8a0. Read the comment docs.


net: lookupIPAddr mapErr causes panic

What version of Go are you using (go version)?

$ go version
go1.18.10

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_arm64"
GOVCS=""
GOVERSION="go1.18.10"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3128295910=/tmp/go-build -gno-record-gcc-switches"

What did you do?

parse dns domain when send http request
What did you expect to see?
no panic
What did you see instead?
panic: runtime error: invalid memory address or nil pointer dereference

 0  0x000000000046d1e1 in runtime.raise
    at /usr/local/go/src/runtime/sys_linux_amd64.s:168
 1  0x000000000044e8a5 in runtime.dieFromSignal
    at /usr/local/go/src/runtime/signal_unix.go:852
 2  0x000000000044f276 in runtime.sigfwdgo
    at /usr/local/go/src/runtime/signal_unix.go:1066
 3  0x000000000044d607 in runtime.sigtrampgo
    at /usr/local/go/src/runtime/signal_unix.go:430
 4  0x000000000046d1e1 in runtime.raise
    at /usr/local/go/src/runtime/sys_linux_amd64.s:167
 5  0x000000000044e8a5 in runtime.dieFromSignal
    at /usr/local/go/src/runtime/signal_unix.go:852
 6  0x0000000000438969 in runtime.crash
    at /usr/local/go/src/runtime/signal_unix.go:944
 7  0x0000000000438969 in runtime.fatalpanic
    at /usr/local/go/src/runtime/panic.go:1092
 8  0x0000000000438137 in runtime.gopanic
    at /usr/local/go/src/runtime/panic.go:941
 9  0x000000000044e77d in runtime.panicmem
    at /usr/local/go/src/runtime/panic.go:220
10  0x000000000044e77d in runtime.sigpanic
    at /usr/local/go/src/runtime/signal_unix.go:818
11  0x00000000005306b3 in net.(*Resolver).lookupIPAddr
    at /usr/local/go/src/net/lookup.go:344
12  0x000000000052d99a in net.(*Resolver).internetAddrList
    at /usr/local/go/src/net/ipsock.go:288
13  0x00000000005151bb in net.(*Resolver).resolveAddrList
    at /usr/local/go/src/net/dial.go:221
14  0x0000000000516128 in net.(*Dialer).DialContext
    at /usr/local/go/src/net/dial.go:406
15  0x000000000072b6db in net.(*Dialer).DialContext-fm
    at <autogenerated>:1
16  0x000000000071509a in net/http.(*Transport).dial
    at /usr/local/go/src/net/http/transport.go:1169
17  0x00000000007181bf in net/http.(*Transport).dialConn
    at /usr/local/go/src/net/http/transport.go:1607
18  0x0000000000716a50 in net/http.(*Transport).dialConnFor
    at /usr/local/go/src/net/http/transport.go:1449
19  0x000000000071696a in net/http.(*Transport).queueForDial.func1
    at /usr/local/go/src/net/http/transport.go:1418
20  0x000000000046b8a1 in runtime.goexit
    at /usr/local/go/src/runtime/asm_amd64.s:1571

It's similar to this issue. https://github.com/golang/go/issues/60029

Ctx is done and then ctx.Error() returns nil. It's a random occurrence in our production environment. we use ip to avoid resolving domain，but this is not a long-term solution. we use custom context,but we can promise the context has no problem.

Ctx is done and then ctx.Error() returns nil. [...] we use custom context

That's not a valid implementation of context.Context. The interface docs say:
https://pkg.go.dev/context#Context
// If Done is closed, Err returns a non-nil error explaining why:

Therefore I don't think there's anything to fix on Go's side.

Sorry, I hit the wrong button closing. Reopening. But I still don't know what we'd fix.

On the one hand, mapErr could perhaps panic with a more helpful message in this case.
On the other hand, in general Go APIs do panic if the program violates invariants that are supposed to always hold in a correct program.
If you have a Context implementation that may close its Done channel but return nil from Err, that's not a valid implementation and it's likely to break way more than just the net package. Fundamentally you need to fix your Context implementation.

On the one hand, mapErr could perhaps panic with a more helpful message in this case.
On the other hand, in general Go APIs do panic if the program violates invariants that are supposed to always hold in a correct program.
If you have a Context implementation that may close its Done channel but return nil from Err, that's not a valid implementation and it's likely to break way more than just the net package. Fundamentally you need to fix your Context implementation.

Thank you for your patient reply. I will colse my issue.


Unable to use import / require file in craco.config.js from src folder in create react app

SyntaxError: Unexpected token 'export'
at wrapSafe (internal/modules/cjs/loader.js:979:16)
at Module._compile (internal/modules/cjs/loader.js:1027:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Object. (/Users/ak/office/evenheathcare/dashboard-app/craco.config.js:2:15)
at Module._compile (internal/modules/cjs/loader.js:1063:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
(Use node --trace-warnings ... to show where the warning was created)
(node:87435) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:87435) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

make sure the config is in your root.

With Webpack 5, es6 modules are supported but it looks like craco does not support this?
Error [ERR_REQUIRE_ESM]: require() of ES Module .../craco.config.js from .../node_modules/cosmiconfig/dist/loaders.js not supported.
craco.config.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead rename craco.config.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in .../package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead).

same problem

The same problem

same here

This issue will now be tracked by #429


Can't add a sprite from a big size image

Code:
var bg = PIXI.Sprite.from('***');
bg.width = 5789;
This image has a big size, then display a black screen.

pixi.js version:  5.0.3_
Browser & Version:  Mobile Chrome 74_
OS & Version:  Android And iOS_

Webgl limit is 4096 on most of devices

Thanks a lot!


Custom text selection color causes text selection not to be visible in FireFox when in High-Contrast mode

When text is selected by the user, a background highlight is shown to indicate the range of text that is selected. For users of the FireFox browser on Windows machines running High-Contrast mode the text selection highlight is invisible when custom colors are used. For accessibility purposes, it is best practice to not overwrite text selection colors.
Please consider removing the following.
::-moz-selection
{ background-color:#b3d4fc; color:#000; text-shadow:none }
::selection
{ background-color:#b3d4fc; color:#000; text-shadow:none }

Certainly, I’ll either need to test this to be certain or get a citation from you. Could you do that? This rule was added to improve accessibility, because text selections with text shadows are much harder to read.

The problem with overwriting the selection colors comes when you are using Windows High Contrast mode without IE. IE will not allow the overwrite to work, as WHC mode overwrites the styles inline. The problem comes with non-native browsers as it is not able to enact on the overwriting of styles and thus can render out incorrectly.

@robgeorge9, does Firefox support a high contrast mode media query? I could make this change wrapped in that media query.

Since FF is not a native browser to the OS, Windows High Contrast mode is not supported to the full extent. Unfortunately, this is a limitation of the system built into the OS. Both FF and IE are both preferred browsers for PCs, so it's a bit unfortunate that it was overlooked in development, as they did create a media query for IE using WHC, just not FF.

Would you be able to provide some screenshots? If so, I think we can make this change, despite the slight downgrade it means for other, aforementioned scenarios.

Yes sorry, I'll be back in the office on Friday. I will send through screenshots then.

Jonathan,
Here are the screenshots you requested. I've supplied both how IE and Firefox treats text selection on our website along with Yahoo.
Firefox

IE

Let me know if you need anything else.

Thank you for the feedback, and I apologize for the late response. Yes, I will remove this in the next major release.

Thank you for making this change to restore the correct selection colors to HCM users.
I’m curious, does:
::-moz-selection {
  text-shadow: none;
}

::selection {
  text-shadow: none;
}

…have the same problem? Disabling text-shadow was a pretty good usability move, in my opinion.

@tigt, good point, and thanks for bringing it up because I hadn’t considered that. @robgeorge9, any concerns with disabling text-shadow, which was originally done in the service of usability?

I can’t test HCM in Firefox due to my company’s draconian installation policy, but I can confirm that by default IE ignores text-shadow altogether in High-Contrast Mode, so barring weird side-effects, it should be safe to remove for everyone inside a selection.

@jonathantneal @tigt - No issues with the text-shadow. Feel free to add that back.


Release tool to create releases on github; Automated release; Increment build script

The packaging/increment_build.sh will automatically increment build number, commit and tag.
The packaging/keybase.sh will build, create a release and upload tgz automatically (or do nothing if release already exists).
I want to add packaging/keybase.sh to travis so a release gets built automatically whenever version changes.
Then we can make the packaging/increment_build.sh happen every night, and then we have nightlies.

Includes a release tool under tools/release which does the magic. Bash is just really annoying so maybe move all our release stuff here (if possible).
cc @oconnor663

What's the relationship between this and client/packaging/release/release.sh? Once this goes in, will we need to run both?
What changes did we make when we forked https://github.com/aktau/github-release?
(Sorry for the wall of questions. Let me know if it would be easier to just do a hangout.)

The github-release stuff is a bit overkill, isn't a library and not really maintained so I pulled in the 10% i needed (with attribution at top) instead of forking and vendoring.


Uncaught TypeError: Chart is not a constructor

Hi,
I'm having trouble getting this working in my project, and I'm hoping I'm missing something obvious.
When I include the dist folder in my React/Reduc project, and open a view that includes some simple example code,  I'm getting the following error within the react-chart.js file on the browser:
react-chartjs.js:143 Uncaught TypeError: Chart is not a constructor
Code in question, with > next to line causing issue:

	    classData.initializeChart = function(nextProps) {
	      var Chart = __webpack_require__(5);
	      var el = ReactDOM.findDOMNode(this);
	      var ctx = el.getContext("2d");
> 	      var chart = new Chart(ctx)[chartType](nextProps.data, nextProps.options || {});
	      this.state.chart = chart;
	    };

Chart seems to be getting initialised to the literal integer value 3.
My skeletal code in the view:
...
import React, { Component } from 'react'
import { connect } from 'react-redux'
...

import { Chart } from 'Chartjs'
import { Line } from 'react-chartjs'

...

class ChartView extends Component {
...
  render() {
...
    var chartData = {
    labels: ["January", "February", "March", "April", "May", "June", "July"],
    datasets: [
        {
            label: "My First dataset",
            fillColor: "rgba(220,220,220,0.2)",
            strokeColor: "rgba(220,220,220,1)",
            pointColor: "rgba(220,220,220,1)",
            pointStrokeColor: "#fff",
            pointHighlightFill: "#fff",
            pointHighlightStroke: "rgba(220,220,220,1)",
            data: [65, 59, 80, 81, 56, 55, 40]
        },
        {
            label: "My Second dataset",
            fillColor: "rgba(151,187,205,0.2)",
            strokeColor: "rgba(151,187,205,1)",
            pointColor: "rgba(151,187,205,1)",
            pointStrokeColor: "#fff",
            pointHighlightFill: "#fff",
            pointHighlightStroke: "rgba(151,187,205,1)",
            data: [28, 48, 40, 19, 86, 27, 90]
        }
    ]
    }

    var chartOptions = {

    };

    return (
      <div id='chart'>

      <Line data={chartData} options={chartOptions} width="600" height="250"/>

      </div>
    )
  }
}

export default connect(..., ...)(ChartView)

The react-chartjs.js file being downloaded to the browser is the file created by npm run build. I think I'm missing some basic webpack step (which I'm new to) perhaps? Any pointers?
Cheers,
Leigh.

If I butcher the react-chart.js file with some diagnostics, I notice that __WEBPACK_EXTERNAL_MODULE_5__ is getting passed in as the value 3 - I must be doing something wrong with my includes - I'll carry on investigating and update here.
(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
	{
		console.log('A')
		module.exports = factory(require("react"), require("react-dom"), require("Chartjs"));
	}
	else if(typeof define === 'function' && define.amd)
	{
		console.log('B')
		define(["react", "react-dom", "Chartjs"], factory);
	}
	else if(typeof exports === 'object'){
		console.log('C')
		exports["react-chartjs"] = factory(require("react"), require("react-dom"), require("Chartjs"));
	}
	else{
		console.log('D')
		root["react-chartjs"] = factory(root["React"], root["ReactDOM"], root["Chart"]);
	}
})(this, function(__WEBPACK_EXTERNAL_MODULE_3__, __WEBPACK_EXTERNAL_MODULE_4__, __WEBPACK_EXTERNAL_MODULE_5__) {
return /******/ (function(modules) {

	console.log('__WEBPACK_EXTERNAL_MODULE_3__:')
	console.log(__WEBPACK_EXTERNAL_MODULE_3__)
	console.log('__WEBPACK_EXTERNAL_MODULE_4__:')
	console.log(__WEBPACK_EXTERNAL_MODULE_4__)
	console.log('__WEBPACK_EXTERNAL_MODULE_5__:')
	console.log(__WEBPACK_EXTERNAL_MODULE_5__)

B
react-chartjs.js:23 __WEBPACK_EXTERNAL_MODULE_3__:
react-chartjs.js:24 Object {Children: Object, PropTypes: Object, DOM: Object, version: "0.14.7", __SECRET_DOM_DO_NOT_USE_OR_YOU_WILL_BE_FIRED: Object…}
react-chartjs.js:25 __WEBPACK_EXTERNAL_MODULE_4__:
react-chartjs.js:26 Object {version: "0.14.7"}
react-chartjs.js:27 __WEBPACK_EXTERNAL_MODULE_5__:
react-chartjs.js:28 3

OK, so found seemingly related issue over in angular-chart.js, whereby they tweaked the require calls to work around a requirejs issue - see https://github.com/jtblin/angular-chart.js/issues/194.
I made the following change and the chart is now appearing. I'll carry on investigating - not sure if this is a workaround masking some underlying issue in my code.
(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory(require("react"), require("react-dom"), require("Chartjs"));
	else if(typeof define === 'function' && define.amd)
//		define(["react", "react-dom", "Chartjs"], factory);
		define(["react", "react-dom", "Chart"], factory);   // <- tweaked this reference
	else if(typeof exports === 'object')
		exports["react-chartjs"] = factory(require("react"), require("react-dom"), require("Chartjs"));
	else{
		root["react-chartjs"] = factory(root["React"], root["ReactDOM"], root["Chart"]);
})(this, function(__WEBPACK_EXTERNAL_MODULE_3__, __WEBPACK_EXTERNAL_MODULE_4__, __WEBPACK_EXTERNAL_MODULE_5__) {

I've confirmed that the following change resolves the issue for me:
https://github.com/venari/react-chartjs/commit/f0639fa70fa874a571e2bc6b66967f8ce856d6b5
Still not 100% sure this isn't a problem with my code, so I won't submit a PR now - but would be interested to hear if others experience this issue - judging by lack of people reporting it, I'm suspecting it's just me.

Same here, same error.

Unfortunately, my workaround doesn't appear to work in the chartjs-v2 branch. :disappointed:

Are you trying to use Chartjs v2 with the current release of react-chartjs? The master only works with v1 right now.

Hey @austinpray ,
I apologise I realized that chartJs v1 is required for this to work :)
I think we should add this to readme?
Cheers,

@gor181 shoot a PR over!
This should fix it as well https://github.com/jhudson8/react-chartjs/pull/104

Similar error here:
npm WARN<EMAIL_ADDRESS>requires a peer of chart.js@* but none was installed.

Can we get this PR: https://github.com/venari/react-chartjs/commit/f0639fa70fa874a571e2bc6b66967f8ce856d6b5 in AS SOON AS POSSIBLE. :)

@polguixe read the error message. It's telling you exactly what's going on.
Install chartjs 1.x

Are you trying to use Chartjs v2 with the current release of react-chartjs? The master only works with v1 right now.
Hi @austinpray, my intention has been to be matching the two versions - I've been trying the following combinations - see my package.json file:
Version 1 (encountering this issue):
"dependencies": {
...
    "chart.js": "^1.1.1",
...
...
    "react-chartjs": "^0.7.3",

And then my fork, which resolved this issue for me:
"dependencies": {
...
    "chart.js": "^1.1.1",
...
...
    "react-chartjs": "git://github.com/venari/react-chartjs.git",

Version 2 (encountering the same symptoms as this issue):
"dependencies": {
...
    "chart.js": "^2.0.0",
...
...
    "react-chartjs": "git://github.com/venari/react-chartjs.git#chartjs-v2",

Another thing - we're starting to think this may be to do with the fact we're using Dojo to load libraries - anyone else whose experiencing this issue, are you using Dojo?


Update Chinese and Japanese localization files (24.1)

Update resx files with localization.zh-CHS.csv and localization.ja.csv that we got back from translators. The commands that I executed were:
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\readResxFiles.bat
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe importLocalizationCsv
pwiz_tools\Skyline\Executables\DevTools\ResourcesOrganizer\scripts\exe\ResourcesOrganizer.exe exportResx ResxFiles.zip
and then unzip "ResxFiles.zip"

localization.zh-CHS.csv
localization.ja.csv

You have some punctuation-only changes that are changing from Chinese colons and ellipses to Roman punctuation. These changes need to be reverted.

Fixed. It sounds like the .csv files that were sent to the localizers were generated before the July 14th commit "normalize punctuation use across translations".


LUCENE-9916: add a simple regeneration help doc

This probably isn't most efficient or the best, but its a start.
Some notes:

Using these steps to "force regenerate" results in local diffs. These look to be hashmap ordering differences or similar. We should fix these so that regeneration is fully idempotent?
Might not be the most efficient, for example when using --rerun-tasks the tidy is unnecessarily rerun even if its not necessary, which is actually quite slow. Is the tidy task really necessary or is it automatically/more efficiently done as some prerequisite of regenerate?

I have a question: why do we need this "tidy" at end of command line? If it is always required, it could be triffered automatically?
I know this is unrelated to the documentation issue, but whenever I see any of those instructions, this puts questions in my eyes: 🤔

Leave this patch open, Robert. There is one more non-trivial bit (checksum saving) that I need to explain there - I'll do it once I get back home.

sure, please anyone push improvements, i just wanted to get it started.


Cannot install stern

Maybe a silly question, I am a novice on golang and I try to install stern on my own machine (with go get -u github.com/wercker/stern)
package k8s.io/client-go/1.4/kubernetes: cannot find package "k8s.io/client-go/1.4/kubernetes" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/kubernetes (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/kubernetes (from $GOPATH)
package k8s.io/client-go/1.4/tools/clientcmd: cannot find package "k8s.io/client-go/1.4/tools/clientcmd" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/tools/clientcmd (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/tools/clientcmd (from $GOPATH)
package k8s.io/client-go/1.4/kubernetes/typed/core/v1: cannot find package "k8s.io/client-go/1.4/kubernetes/typed/core/v1" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/kubernetes/typed/core/v1 (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/kubernetes/typed/core/v1 (from $GOPATH)
package k8s.io/client-go/1.4/pkg/api: cannot find package "k8s.io/client-go/1.4/pkg/api" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/pkg/api (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/pkg/api (from $GOPATH)
package k8s.io/client-go/1.4/pkg/api/v1: cannot find package "k8s.io/client-go/1.4/pkg/api/v1" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/pkg/api/v1 (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/pkg/api/v1 (from $GOPATH)
package k8s.io/client-go/1.4/pkg/watch: cannot find package "k8s.io/client-go/1.4/pkg/watch" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/pkg/watch (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/pkg/watch (from $GOPATH)
package k8s.io/client-go/1.4/rest: cannot find package "k8s.io/client-go/1.4/rest" in any of:
	/usr/local/Cellar/go/1.7.3/libexec/src/k8s.io/client-go/1.4/rest (from $GOROOT)
	/Users/eric/go/src/k8s.io/client-go/1.4/rest (from $GOPATH)

Is there any package management tool do I need to install as well?

duplicate of https://github.com/wercker/stern/issues/6

Closing as duplicate of #6. Not at all a silly question, sorry for the confusion (see https://github.com/wercker/stern/issues/6#issuecomment-259163640)


Bug fixed saves and rings

Fixed bug in manual Update Saves dialog which prevented changes.
Fixed Change Weapon dialog to put rings in correct hand.

Added v1.4.05 back into script.json previous versions to comply with Roll20 request.  Will explore in future how to remove pevious versions that have bugs so they can't be loaded by accident by users


NATS websocket Connection error

I tried to use NATS install by helm install with a values.yaml file  to connect  using WebSocket
nats:
image: nats:alpine

jetstream:
  enabled: true

  memStorage:
    enabled: true
    size: "2Gi"

  fileStorage:
    enabled: true
    size: "10Gi"
    storageDirectory: /data/
    # storageClassName: standard
    storageClassName: gp2

websocket:
  enabled: true
  port: 8443

cluster:
  enabled: true
  noAdvertise: true

replicas: 2

affinity:
  nodeAffinity:
     preferredDuringSchedulingIgnoredDuringExecution:
      - weight: 1
        preference:
          matchExpressions:
          - key: node.kubernetes.io/zone
            operator: In
            values:
            - ap-south-1
  podAntiAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - nats
                - stan
        topologyKey: "kubernetes.io/hostname"

but I can't connect to my  server link from react app where the demo " servers: ["wss://demo.nats.io:8443"] " works fine in this react example https://nats.io/blog/getting-started-nats-ws/
import {
  connect,
  NatsConnection,
} from "nats.ws";

import {
  useEffect,
  useState,
} from "react";

export default function Home() {
  const [nats, setNats] = useState<NatsConnection>();

useEffect(() => {
  (async () => {
    const nc = await connect({
      servers: ["wss://demo.nats.io:8443"],
    })
    setNats(nc)
    console.log("connected to NATS")
  })();

  return () => {
    nats?.drain();
    console.log("closed NATS connection")
  }
}, [])

return (
  <>
    {nats ? (

Connected to {nats?.getServer()}

    ) : (

Connecting to NATS...

    )}
  </>
)}

so what is the proper configuration in helm install to connect from react app using WebSocket?

Hello @aricart, I have been having the same issue however, I'm running my NATS server in a cluster served behind an ec2. Whenever I try to connect I get the connection error. I have followed the guideline from the doc:
// nats.conf file

websocket {
  port: 8843  # Specify the WebSocket port (adjust to the desired port)
  no_tls: true  # Disable TLS (set to true for non-secure WebSocket)
  # Other WebSocket configuration options can be added here
}

I have used this configuration in a docker where I set it in the nats config:
FROM nats-streaming:latest

# Copy your custom nats.conf into the image
COPY nats.conf /etc/nats/nats.conf

# Expose client and management ports
EXPOSE 4222 8222 8843

# Run the NATS server with the configuration file
CMD ["--config", "/etc/nats/nats.conf"]

That image is the one I use in the pod to run NATS with the new config to make the websocket available
  spec:
      containers:
        - name: nats
          image: <...>/nats-websocket:<tag>
          args:
            - "-p"
            - "4222"
            - "-m"
            - "8222"
            - "-hbi"
            - "5s"
            - "-hbt"
            - "5s"
            - "-hbf"
            - "2"
            - "-SD"
            - "-cid"
            - "caytu"
            - "-c"
            - "/etc/nats/nats.conf"
          resources:
          ...
    ```

    So, till now, I couldn't connect from my nextjs frontend app and seeing the same error (NATS websocket Connection error).
    Could you please help with this ?

@jmndao your server logs say the server is serving we socket?
What does the client connection options look like?

Thank you for your quick reaction @aricart.
Yes, it actually is:
kubectl logs -f nats-depl-5fdf58c84b-kvrgp
[1] 2023/09/03 11:11:45.499335 [INF] STREAM: Starting nats-streaming-server[caytu] version 0.25.5
[1] 2023/09/03 11:11:45.499375 [INF] STREAM: ServerID: VlL66tnDTFrJqmZYwZWtu0
[1] 2023/09/03 11:11:45.499377 [INF] STREAM: Go version: go1.19.10
[1] 2023/09/03 11:11:45.499380 [INF] STREAM: Git commit: [abfd5a3]
[1] 2023/09/03 11:11:45.528908 [INF] Starting nats-server
[1] 2023/09/03 11:11:45.528927 [INF]   Version:  2.9.19
[1] 2023/09/03 11:11:45.528930 [INF]   Git:      [f4f3cce]
[1] 2023/09/03 11:11:45.528933 [INF]   Name:     NCZCCADHCKDSKXUVDW2DW5JKWOAEG4WGA7UVL2UUYJ3FFIB5AFZ7KPEQ
[1] 2023/09/03 11:11:45.528935 [INF]   ID:       NCZCCADHCKDSKXUVDW2DW5JKWOAEG4WGA7UVL2UUYJ3FFIB5AFZ7KPEQ
[1] 2023/09/03 11:11:45.531114 [INF] Using configuration file: /etc/nats/nats.conf
[1] 2023/09/03 11:11:45.541559 [INF] Starting http monitor on <IP_ADDRESS>:8222
[1] 2023/09/03 11:11:45.544007 [INF] Listening for websocket clients on ws://<IP_ADDRESS>:8843
[1] 2023/09/03 11:11:45.544017 [WRN] Websocket not configured with TLS. DO NOT USE IN PRODUCTION!
[1] 2023/09/03 11:11:45.544217 [INF] Listening for client connections on <IP_ADDRESS>:4222
[1] 2023/09/03 11:11:45.544318 [INF] Server is ready
[1] 2023/09/03 11:11:45.554719 [INF] STREAM: Recovering the state...
[1] 2023/09/03 11:11:45.554731 [INF] STREAM: No recovered state
[1] 2023/09/03 11:11:45.554954 [DBG] STREAM: Did not detect another server instance

And the client connect options?

const connectionParams: ConnectionOptions = {
  servers: [`ws://${process.env.NEXT_PUBLIC_API_URL}:8843`],
  name: "web-depl",
};

process.env.NEXT_PUBLIC_API_URL: somedomain.com

The rest goes like the doc in nats.ws
...
const EventListenerProvider = ({ children }: EventListenerProviderProps) => {
  const [nats, setNats] = useState<NatsConnection>();

  /**
   * Connect to NATS
   */
  useEffect(() => {
    (async () => {
      const connectToNats = async () => {
        // If already connected, return
        if (nats) return;

        await connect(connectionParams)
          .then((conn) => {
            setNats(conn);
            console.log("Connected to NATS");
          })
          .catch((err) => console.error("Error connecting to NATS", err));
      };

      connectToNats();
    })();

    return () => {
      nats?.drain();
      console.log("NATS connection closed");
    };
  }, []);
  ...

Hi @aricart, thank you very much for the help. Fortunately, I did find a fix to the related issue which was not truly a NATS server problem.
Here is what was happening,
As I said at the very beginning I was running my cluster behind an ec2 with ingress (NGINX) then it was much more likely that the issue was about a connection problem. After a little dig in, I had to:

Enable the port behind the security group of my ec2
Enable WebSocket handling in the ingress configuration

    nginx.org/websocket-services: "nats-srv"
    ...
     - path: /nats-ws
            pathType: Prefix
            backend:
              service:
                name: nats-srv
                port:
                  number: 8843

So, in account of all of that, the issue was more related to a networking problem and finally got resolved.
Thanks once again


cancelBubble not working

I have an onContentMouseDown event on the stage and an onClick handler on a rect. Neither e.cancelBubble = true; or e.evt.cancelBubble = true; in the onClick seem to stop the onContentMouseDown from firing. The same applies for an onMouseDown event on the stage.
I'm trying to have the onContentMouseDown event fire when drawing on empty space but not when clicking an existing rect. Am I doing something wrong?

Alright, so it's an issue with konva and not react-konva, but cancelBubble doesn't stop onContentMouseDown events. The best solution as far as I can tell is to create an invisible rect with the same width + height as the stage/layer and use mouseDown/mouseMove/mouseUp. That way, bubbling will be cancelled when called on the other shapes.

@blueberryfan do not use onContentWheel for your case. Just use onWheel for the stage too.
All "content" events are our of usual event bubbling flow.

@lavrton Thanks for the tip, Anton, I'll have a look at that.
From memory, I chose the content event because I built a zoom feature similar to what you'd find in a geographical map tool where you use the mouse scroll to zoom in and out, and because I needed it to zoom when scrolling anywhere, not just when the mouse pointer is over a shape, I had to use the content event.
Cheers

@blueberryfan the behavior of many events slightly changes recently. Almost all events now trigger on empty space too.