Connection reset by peer in MultiStreamImageCompleter on Android

Steps to Reproduce
We are using FlutterView inside our Android RecyclerView (Android add-to-app). On this FlutterView we are rendering the Flutter Dart UI. The UI consists for Carousel sliders with CachedNetworkImage. We have integrated the crashlytics inside the flutter module and we are seeing one crash a lot:
Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Connection reset by peer. Error thrown Instance of 'ErrorDescription'.
       at FirebaseCrashlytics.recordError(firebase_crashlytics.dart:119)
       at FirebaseCrashlytics.recordFlutterError(firebase_crashlytics.dart:141)
       at FirebaseCrashlytics.recordFlutterFatalError(firebase_crashlytics.dart:156)
       at FlutterError.reportError(assertions.dart:1184)
       at ImageStreamCompleter.reportError(image_stream.dart:733)
       at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:32)
       at _AsyncStarStreamController.addError(_AsyncStarStreamController.java)
       at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:25)

We are not sure how to reproduce this issue as its happening in the live build. We are sure that its happening when the CachedNetworkImage is trying to download the image from network but still unable to trace this error in the app as it is not pointing to the exact code that we have control over. Could any one help us on this?
Flutter doctor result:
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.5.1 21G83 darwin-arm, locale en-IN)
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[!] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    ! CocoaPods 1.10.2 out of date (1.11.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.70.0)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 2 categories.

Hi @ashish-bb-16
Is this issue reproducible locally? If so, can you please share the output of flutter run -v and a completed and minimal reproducible code sample?
May be related/similar: #102494

I have the same problem on the production app. Lots of crashes with a similar stack trace. Looks like it's crashing after various problems with getting the image. All were reported as Crash in Crashlytics. I can't repro any of this locally.
on Android
Invalid image data
Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Exception: Invalid image data. Error thrown Instance of 'ErrorDescription'.        at .instantiateImageCodecFromBuffer(.java)        at PaintingBinding.instantiateImageCodecFromBuffer(binding.dart:153)        at ImageLoader.loadBufferAsync.<fn>(_image_loader.dart:68)        at ImageLoader._load(_image_loader.dart:121)        at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:25)
Connection refused
Fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Connection refused. Error thrown Instance of 'ErrorDescription'.        at FirebaseCrashlytics.recordError(firebase_crashlytics.dart:119)        at FirebaseCrashlytics.recordFlutterError(firebase_crashlytics.dart:141)        at FirebaseCrashlytics.recordFlutterFatalError(firebase_crashlytics.dart:156)        at FlutterError.reportError(assertions.dart:1184)        at ImageStreamCompleter.reportError(image_stream.dart:733)        at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:32)        at _AsyncStarStreamController.addError(_AsyncStarStreamController.java)        at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:25)
on iOS
Connection closed while receiving data
Fatal Exception: FlutterError 0  ???                            0x0 FirebaseCrashlytics.recordError + 119 (firebase_crashlytics.dart:119) 1  ???                            0x0 FirebaseCrashlytics.recordFlutterError + 141 (firebase_crashlytics.dart:141) 2  ???                            0x0 FirebaseCrashlytics.recordFlutterFatalError + 156 (firebase_crashlytics.dart:156) 3  ???                            0x0 FlutterError.reportError + 1184 (assertions.dart:1184) 4  ???                            0x0 ImageStreamCompleter.reportError + 733 (image_stream.dart:733) 5  ???                            0x0 new MultiImageStreamCompleter.<fn> + 32 (multi_image_stream_completer.dart:32) 6  ???                            0x0 _AsyncStarStreamController.addError (dart:async) 7  ???                            0x0 new MultiImageStreamCompleter.<fn> + 25 (multi_image_stream_completer.dart:25)

Same problem here, I've also used Carousel sliders with CachedNetworkImage.
Non-fatal Exception: io.flutter.plugins.firebase.crashlytics.FlutterError: Connection reset by peer. Error thrown Instance of 'ErrorDescription'.
       at FirebaseCrashlytics.recordError(firebase_crashlytics.dart:119)
       at FirebaseCrashlytics.recordFlutterError(firebase_crashlytics.dart:141)
       at FlutterError.reportError(assertions.dart:1177)
       at ImageStreamCompleter.reportError(image_stream.dart:728)
       at new MultiImageStreamCompleter.<fn>(multi_image_stream_completer.dart:32)


EmbeddedAssetBlock JSON doesn't contain asset

The jsonSerialize method on the class Contentful\RichText\Node\EmbeddedAssetBlock looks like this:
/**
 * {@inheritdoc}
 */
public function jsonSerialize(): array
{
    return [
        'nodeType' => self::getType(),
        'data' => [
            'target' => $this->asset->asLink(),
        ],
        'content' => $this->content
    ];
}

The content is empty, but it would be a lot more useful if $this->asset was returned instead. From that, I could access the file's url and other useful meta information
Would you like me to raise a pull request?

This is resolved with v4.0.0 :)
See https://github.com/contentful/rich-text.php/commit/e957a837e58d1b0502b6152005c24cf34b7152f0

Did this solution actually address what @twhite94 was suggesting?  To me, it sounds like he wanted  'content' => $this->asset . But maybe I misunderstood his request.


D Pad selection not working?

I opened the program up from homebrew and whenever I try using up/down on the dpad there's no response. I tried pressing every button and nothing seems to happen.

Could be caused by the recent HID change. Are you on 9.0.0 by any chance?
I'll probably make a new working build tomorrow then.
On Sun, Sep 15, 2019, 11:14 PM meisaboo<EMAIL_ADDRESS>wrote:

I opened the program up from homebrew and whenever I try using up/down on
the dpad there's no response. I tried pressing every button and nothing
seems to happen.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/3096/nut/issues/7?email_source=notifications&email_token=ABVYCEKARTY6AADDUBCIHQ3QJ4P23A5CNFSM4IW6ER7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLPY57Q,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVYCEI2YAP5FJLWZAK57YDQJ4P23ANCNFSM4IW6ER7A
.

Yeah I believe I'm on 9.0.0 right now. That's probably the problem, but
anyways thanks for the quick response! L
On Mon, Sep 16, 2019, 3:29 AM Frank<EMAIL_ADDRESS>wrote:

Could be caused by the recent HID change. Are you on 9.0.0 by any chance?
I'll probably make a new working build tomorrow then.
On Sun, Sep 15, 2019, 11:14 PM meisaboo<EMAIL_ADDRESS>wrote:

I opened the program up from homebrew and whenever I try using up/down on
the dpad there's no response. I tried pressing every button and nothing
seems to happen.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/3096/nut/issues/7?email_source=notifications&email_token=ABVYCEKARTY6AADDUBCIHQ3QJ4P23A5CNFSM4IW6ER7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLPY57Q
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABVYCEI2YAP5FJLWZAK57YDQJ4P23ANCNFSM4IW6ER7A
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/3096/nut/issues/7?email_source=notifications&email_token=ANGPUKN63BRNQGDE4CT7Y4DQJ47WLA5CNFSM4IW6ER7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6YN74A#issuecomment-531685360,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANGPUKILGZ6X4SSJ4R65V6LQJ47WLANCNFSM4IW6ER7A
.

Fixed! https://github.com/3096/nut/releases

Thank you so much! I really appreciate it
On Wed, Sep 18, 2019, 2:21 AM Frank<EMAIL_ADDRESS>wrote:

Fixed! https://github.com/3096/nut/releases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/3096/nut/issues/7?email_source=notifications&email_token=ANGPUKNUX2KTLAMTGQHYPA3QKHJGJA5CNFSM4IW6ER7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67CNKI#issuecomment-532555433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANGPUKIIFNCDZ3PTJW6FKVLQKHJGJANCNFSM4IW6ER7A
.


[TASK] Implement reusable UploadNotesModal component

Task Description
The purpose of this task is to implement a reusable UploadNotesModal components that can be exported for external use. The below fields are used to upload user’s spend notes so that users can easily manage and view their available spend notes on the Webb dApp.
Task Deliverable

[ ]  Create a folder UploadNotesModal
[ ]  Implement a UploadNotesModal component with the below mentioned props
[ ]  Ensure the implementation reflects the intended design
[ ]  Document each component with an example
[ ]  Ensure component is exportable
[ ] Add component documentation to /stories dir

UploadNotesModal Component
Props:
Type="upload" | "paste";
State="loading" | "default" | "filled" | "success" | "error" | "stacked";
dark mode=false;
Example usage:
< UploadNotesModal
  type="upload"
  state="default"
  dark-mode="off"
/>

Relevant links

Figma Design System

Included in #671


Generate backend shader code from C# code

Combine the ideas from

https://github.com/mellinoe/ShaderGen
https://devblogs.microsoft.com/dotnet/introducing-c-source-generators/

Programming GPUs should not be done in C#.


Assignment 1 - Selection Sort

When you ask someone to sort a list of numbers in ascending order, you will see that the common intuition will be like "Select the minimum card and put it in the first place. Select the second minimum and put it in the second place. And so on". This is called selection sort.

Write a selectionSort function that takes an integer array and returns it as sorted in ascending order. Don't mutate the original array (don't use inout). Note that there is already a swap function in the standard library. When using the swap, you need to guard it from swapping a location with itself.

Turn the function into a generic function so that it can sort any type of array. Only constraint is that elements of the array should conform to the Comparable protocol.

Instead of sorting the array in ascending order, modify your function to accept a closure that takes two arguments of the same type as the array’s contents, and returns Bool. You can name this closure parameter isOrderedBefore (as in sort function of the standard library). Check what @noescape means in Swift. Also you now use another function to do the comparison, you can remove the Comparable constraint.

Instead of only sorting arrays, modify your function to sort any type conforming to SequenceType. Make your function to be an extension of SequenceType so that we can use it as [1, 3, 2].selectionSort(<) and [1: "b", 2: "a"].selectionSort {$0.0 > $1.0}.

Due Date: Next Wednesday 25.11.2015
Next assignment will be about writing an insertion sort (as you guessed). Feel free to send comments :smile:

Excellent initiative. I'm travelling at the moment but I'll submit a PR before the deadline.

Thank you @phelgo!
Will be waiting for your PR.

@gmertk Awesome idea! I like people who like to teach.
I found this repo just yesterday and missed the deadline for assignment 1, but I'd try to present some helping comments on the current pull requests if that's ok (actually I already started). :)

@gmertk Nice work! Me too. I just found this repo so I can't meet the deadline for assignment1. Would you still accept PR for assignment1??

@gmertk I just thought:
Maybe a nice idea is to not have deadlines at all, but just different tasks that can be done and whenever someone new finds the repo, PRs are possible for every tasks, which lead to reviews and discussions, which again lead to improving us all.
That sounds nice. :)

@DominicFrei It could be nice. But I would like to have a soft deadline to keep going. Deadlines are good. It motivates you to solve one assignment every few days.
@K-jpn PRs are still possible for older assignments so that everyone can comment them. Though I'm not sure if we should keep them open for all the time.


Lidl HG06106A description is wrong

I've bought some cheap Lidl surplus GU10 lamps and noticed that the description for them here is wrong. They are described as "Livarno Lux GU10 9W RGB Bulb".
While they are actually just 4.5 W and not "RGB", but "RGBCT":

Not sure if the profile is correct or somehow it was created for two lamps and that's why it's 9 W? 🤔

Not sure if the profile is correct or somehow it was created for two lamps and that's why it's 9 W? 🤔

The measurements looks correct for 4.5W

Might be the description was picked from blackadder DB: https://zigbee.blakadder.com/Lidl_HG06106A.html, which seems to be wrong.
I will correct it.

@bramstroker maybe we should rename "Lidl" to "Livarno Lux"? While yes, they are primarily sold at Lidl, you can also buy them from third party sellers, at least as surplus and nowhere on the packaging is says "Lidl".

Are all the lights under Lidl from LivarnoLux?
Also when renaming the directory we need to make sure lidl is added as an alias in manufacturer.json for LivarnoLux.
Otherwise it will break all existing user installations where they reference manufacturer lidl.

@bramstroker maybe we should rename "Lidl" to "Livarno Lux"? While yes, they are primarily sold at Lidl, you can also buy them from third party sellers, at least as surplus and nowhere on the packaging is says "Lidl".

Are all the lights under Lidl from LivarnoLux?

Yes they are. That's Lidl's branding for lights.

Also when renaming the directory we need to make sure lidl is added as an alias in manufacturer.json for LivarnoLux. Otherwise it will break all existing user installations where they reference manufacturer lidl.

Yeah sure

@bramstroker I think this can be closed as fixed?
Or do you want to keep it open because of the Lidl -> LivarnoLux rename thing?

Yes I prefer to keep it lidl for now as that's also the manufacturer as listed in HA device info for most integrations.


Detect default Git branch during deploy

Rill currently defaults to using main as the production branch in Git during the first deploy from a Github-connected projected. We should infer the default branch from the repository instead.

This is already implemented here : https://github.com/rilldata/rill/blob/6c4acf1873911fbe83635102c5d9451c81c2dffa/cli/cmd/deploy/deploy.go#L233-L234
I also tested and we are inferring the default branch from the repository.


Page breaks show up as synopses

Took me a while to realize why a seemingly random one of my headers would get a "==" synopsis underneath it; I have a page break (signified by three equals - "===") at one point in my script, and the outline is interpreting that as a synopsis of two equals signs.

Can you provide a short script that causes this issue?

Sure thing.

Text to copy/paste:
#Section 1
=Steve washes his car

FADE IN:

INT. CAR WASH

STEVE washes his car.

STEVE
Boy I love washing my car blah blah blah.

He drops dead.

===

#Section 2
=The funeral

INT. FUNERAL PARLOR

The MINISTER delivers a eulogy.

MINISTER
He died doing what he loved: washing his car.

THE END

Don't worry about it, and no snark perceived. Having a minimal test case that demonstrates the problem is one of the most important things in bug fixing. This should be fixed in the latest release, 0.8.2. Please close the issue if it works on your side.

Unfortunately, it still seems to be occurring. I tried uninstalling and reinstalling the package too, just to be sure. Let me know if there's any other info I can give you.

Interesting. Can you confirm you have version 0.8.2? Is your page break line exactly ===, no spaces at the end?

Yeah, it's 0.8.2, and no spaces. And if I make a new file and paste in the example I gave above, I'm seeing the exact same thing.

That's really odd. This is what it looks like on mine with 0.8.2 installed:

That is weird. I tried rebooting and I tried a second computer and it's still happening.
Why do your three equals signs merge together like that? Mine look like:

But yours are:

Could that have anything to do with the problem? Do I not have some setting enabled somewhere?

That's just a ligature from the Firacode font I have installed. It shouldn't affect anything.

Gotcha. Well, let me know if there's anything else I can do to help. I'm trying to think what else could matter. Both computers I tried were on the latest version of Windows 10 (Build 18362), both have all their packages updated, both are relatively recent installs of Atom. On the one computer literally the only community packages are this and the required pdf-view.
If all else fails, it's certainly not a workflow-breaking bug, I can live with it.

That's really odd. If you look at your installed packages, it definitely say version 0.8.2? I just tried it on a Chromebook (in Crouton) and it works fine there. I can see synopses in the outline, but if there are exactly three equal signs, it isn't in the outline.

As far as I can tell, unless there's some other screen somewhere or box I have to check:

Is there any way there's some other package that's interfering with this? Maybe a package you have that I don't, maybe there's a package I need to disable? Some setting somewhere I need to turn off?

There shouldn't be, and that looks like the right version. This is pretty weird. @jrbostic, any idea if there is some setting that might be causing @DaTedinator to not use the latest outline view module?

@superlou The only thing that comes to mind is hidden characters, often added by Microsoft products and honored by other applications.  I've ran into that more than once at work with copying code from Word and Skype into an IDE.
@DaTedinator Have you tried manually retyping the same script section to see if it parses differently?  Sometimes letters or spacing that look normal can have encoding that causes problems for parsers... Like what we rely on to find elements of a fountain script... So, I'd try and rule that out first.  Can you make this happen without copy/paste?
If it's not that, I'd have to take a closer look... At the grammar stuff... And the outline rendering.

Yeah, manually typing === gets the same result.

Don't worry about it. It's probably a bad assumption somewhere. @jrbostic did it behave as expected for you, or are you having the same issue as @DaTedinator?

@superlou @DaTedinator  Just installed atom fresh on my Windows machine... added only the fountain-atom package... and this is verified reproducible.

I see where the match is failing at line 195 of fountain-outline-view.coffee: arr[i].match(/^===+$/).  The crazy thing is that arr[i] is "===", and it matches correctly in the console as well... but during processing it's getting caught by the match that comes directly after and labeled as a "synopsis", which also strips the first '=' character.  Not sure what could be going wrong at this point.

Okay, it's related to spaces and newlines.  We need a more robust match, I suppose.

I'm not set up to put this into PR easily... but I think this matcher will fix it: arr[i].match(/^===.*$/s)

@DaTedinator, see if that helps. I made the page break matcher more lenient per @jrbostic's code, though I think this is technically more lenient that the fountain spec says it should be.  @jrbostic, the trailing single-line flag wasn't supported, so this might have the same problem. Unfortunately, I still can't reproduce it on my side.

It wasn't supported?  That's strange since it ran in the console fine.  Was there an exception or warning or something?

apm test failed out with a syntax error.

No, looks like it's still happening.

Yea, it needed that 's'.  I guess we need to work on another matcher.  Which is probably for the better if it sticks closer to the fountain spec.  Or maybe there's another way to encapsulate the regex...?

I hope you'll excuse the drive-by comment, but I think your issue is with your synopsis regexp /^\s*=\s*(.+)/ which looks to be too greedy. /^=\s*([^\n=].*)/ should do the trick. (I'd avoid permitting a leading space in case the writer wants to indent something beginning with =.)

@rnkn I'd never fault a drive-by looking to help, thanks! I've committed the change to master.
The weirdest part to me is that I still can't reproduce it on my end. If someone who's seeing the problem can suggest an automated test case, maybe that would help me understand what's happening.

So that change stopped it from showing up as a synopsis, but it still gets caught as a scene header, so with that change it's showing up as:

Which, to be honest, I almost kind of really like, now that it's showing up in order, as an indicator of where page breaks are. But it's also clearly not intended.
So with @rnkn pointing out where the root of the original issue was, it's easy to figure that this problem is in the scene heading regex: /(^EXT\.)|(^INT\.)|(^\.[A-Z]+)|(^\s*=\s*.+)/ So when I changed it to /(^EXT\.)|(^INT\.)|(^\.[A-Z]+)|(^\s*=\s*[^=].*)/ then yeah, it fixed the problem. That's obviously not the ideal regex to use (I imagine you'd at least want to make it [^=\n], I'm a bit rusty on my regex) but it worked for its purpose of identification.

@DaTedinator I’m not sure about your scene heading regexp there, as the last group will match only a synopsis. Are you sure you want a synopsis element to be matched as a scene heading?
Tangentially, the scene heading regexp will not match scene headings beginning with “I/E” or “EST” or scene headings where the writer might omit the dot. For a wider net, I’d go with something like this (untested):
/^(\.\<|(INT|EXT|EST|I/E)\.?\s)/

If helpful, this the regexp I use for Emacs:
/^(?:(?1:\.)(?2:\<(?4:.+?)(?:(?5: --? )(?6:.+)?)?)|^(?2:(?3:(?:E(?:[SX]T)|I(?:/E|NT(?:\.?/EXT)?))\.? +)(?4:.+?)?(?:(?5: --? )(?6:.+?)?)?))(?:(?7: +)(?8:#)(?9:[0-9a-z\.-]+)(?10:#))? *$/

I actually don’t use Atom, I’m just a casually interested observer.

No sorry, I wasn't saying that's what I wanted; that's what's currently in the code. I know some regex but basically everything else there is greek to me, so maybe the stuff I was saying was obvious, or the things I thought meant one thing actually meant something else.
My point was basically just, with this change now pagebreaks are getting caught as scene headings, and to me it looks like it's that regex that's catching them.

Ah I see. Sorry, yep I think you’re on the money.

@superlou Sorry I kind of dropped off on this one.  I had trouble getting the tests to run (ironically) and didn't have enough time to troubleshoot.  :(

@DaTedinator, we might have figured something out in #99. Can you try changing your checkout settings to use Unix-style endings? On Windows, the default Git install will try to silently change line-endings to Windows-style on checkout and then silently back to the repo format during commit. I think this is messing with some of the regexes.

That fixed it immediately! I can toggle back and forth and watch the === appear and disappear in the outline.

I'm going to close this in favor of #100.


[proposal] fork cri-tools to make the test cases more complete

Ⅰ. Issue Description
For some specific need of Alibaba Group, we have expanded the CRI (only v1alpha2).
However the community will not write test cases for these expanded features.
Maybe we need to fork the cri-tools from its official repo and write test cases for these expanded features by ourselves to make them work as expected.
Ⅱ. Describe what happened
Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Done.
https://github.com/alibaba/cri-tools/pull/1


PMOS, PNP & NPN symbols

just the symbols for now, no devices... one step at a time...

Thanks :)
The PMOS looks good for me. But the BJTs miss labels for name/value. And could you rotate the BJTs so they have the same rotation as mosfets?

Oops, I completely forgot this pull request, sorry! :scream:
In the meantime these symbols were already added to this library, so this PR no longer needed ;)


Chain infusion targeting both full AC and spell resistance with thunderstorm composite blast

A few versions ago the chain infusion was fixed so it is now prone to spell resistance independent of the blast it is used with.
The correct way would be that it would inherit those properties from the blast:

Energy blast like eletricity: touch AC and spell resistance
Physical blast like thunderstorm: full AC and no spell resistance

The problem is currently that if you use it with the thunderstorm composite blast you have to go through the full AC and the spell resistance.

That was an error on my part and is easily fixed

fixed

Thx for fixing it. Do you know when the Implementation is planned, because I couldn't find it in the last change log.
thx

Hi I tested it on the current release and the thunderstorm composite blast still shows that it's affected by spell resistance with chain. All other forms with thunderstorm show that it is not affect by it.
Maybe I am doing something wrong.

Oh sorry. I did fix it, but then immediately changed it back somewhere else. In fact I accidentally applied SR to all blasts (impale too).
Fixed in next release.

Thx for fixing it. Looking forward to the release. :)

I pushed a late night version for you yesterday. Hope it's working now.

Thx. I just installed the update and the physical infusion is working now correctly without SR.


[WIP] This adds context.Context to the interfaces used by the pkg webhook.

See also: knative/pkg#332
Based on https://github.com/knative/build/pull/581 for now.

/retest

/retest

/retest

/retest

/retest

/lgtm


Attribute names that shadow Cedar keywords are rendered in the keyword's color instead of an attribute

Before opening, please confirm:

[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

Bug Category
Syntax Highlighting features
Describe the bug
A resource with an attribute name that shadows any Cedar keyword is rendered as the keyword's color.
Expected behavior
Attribute text color should be applied to attribute names, even if they shadow keywords
Reproduction steps
Add the following fields to the User entity in the Playground's PhotoApp schema
"principal": {"type": "String"},
"action": {"type": "String"},
"resource": {"type": "String"},
"permit": {"type": "Boolean"},
"forbid": {"type": "Boolean"},
"when": {"type": "String"},
"unless": {"type": "String"},

Then write the following policy:
permit (
    principal is PhotoApp::User,
    action == PhotoApp::Action::"viewPhoto",
    resource == PhotoApp::Photo::"vacationPhoto.jpg"
) when {
    principal.principal == "some_string" &&
    principal.action == "some_string" &&
    principal.resource == "some_string" &&
    principal.permit == true &&
    principal.forbid == false &&
    principal.when == "some_string" &&
    principal.unless == "some_string" &&
    principal.userId == "user_id"
};

and the principal/action/resource/forbid/permit/when/unless attribute accessors will be colored with the keyword colors, but userId will not be.

Code Snippet
N/A
Log output
N/A
Additional configuration
When I tried adding the attribute "true": {"type": "Boolean"}, to the User entity, schema validation passed, but policy syntax errored with the message:
this identifier is reserved and cannot be used: `true`

This was also the case for other reserved keywords.
Additional information and screenshots
No response

Where are you testing that / which version of prism-cedar.js are you using?
  keyword: /\b(?<!\.)(?:permit|forbid|when|unless)\b/,
  // don't worry about excluding . before boolean reserved identifiers
  boolean: /\b(?:false|true)\b/,
  variable: /\b(?<![\.\?])(?:principal|action|resource|context)\b/,

I have checks for leading . in regex and test/data/identifier.cedar has coverage.  I added your test case locally, and it looks fine.

Also, if you are referring to https://www.cedarpolicy.com/en/playground - there is nice "Copy inputs as shareable link" feature.  That might be using a different syntax highlighting library.

Since the playground is using an ACE editor, it seems to be different than this. Closing as this is not a prism-cedar issue


Hi, I cannot reproduce the result.

Hi，I have used your code and failed to reproduce the result. Here are my results.
I used the master branch.
When load the imagenet weight, I skip 'conv1.weight' and 'layer1.0.conv1.weight' cause their shape is different with the official Resnet18.
The results are all best IOU on the cityscape eval set during training.

Baseline:  0.619
Baseline + PI: 0.397
Baseline + PI + PA: 0.414
Baseline + PI + PA + HO: D_loss NAN

Could you send me your log?

By the way, I found that training more iteration on the baseline can make the result better.

Baseline: 0.619

Resume the 0.619 ckpt and train more 400k iters: 0.676

Resume  the 0.676 ckpt and train more 400k iters: 0.700

I have already sent the training log to you through the email.

I will close the issue. If you have further questions, please feel free to contact me.

Actually, I came across the same problems and get the similar results as @aachenhang .....
Have you fixed it?

Hi，I have used your code and failed to reproduce the result. Here are my results.
I used the master branch.
When load the imagenet weight, I skip 'conv1.weight' and 'layer1.0.conv1.weight' cause their shape is different with the official Resnet18.
The results are all best IOU on the cityscape eval set during training.

Baseline:  0.619
Baseline + PI: 0.397
Baseline + PI + PA: 0.414
Baseline + PI + PA + HO: D_loss NAN

Could you send me your log?

I also have the same problem and cannot reproduce the result. Have you fixed this?


Graphical update (wfreerdp)

Access to the 2012R2 desktop in windows10 system found that there will be gray blocks when moving
the freerdp is the latest master branch

Please provide ALL the information required, this is a nice and colorful screenshot, but without some context it is useless.

How are you connecting (command line, ...)

There are some issues with it, try with a build against OpenH264 1.8.0  (only this specific version) or FFMPEG
Alternatively disable AVC444 by using /gfx:rfx or /gfx as argument.

With https://github.com/FreeRDP/FreeRDP/pull/7489 it will be disabled for upcoming nightly builds


Add ability to include only named chunks

Part of #6 . I can add exclude option in a later PR.

I signed it!

Once again, thank you for working on this @bekos. I also appreciate you adding in tests + updates to the docs ✨


Update feature_column_v2_test.py

Nagging Reviewer @rohan100jain: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the awaiting review label has been applied.

Nagging Reviewer @rohan100jain: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 29 days with no activity and the awaiting review label has been applied.

Thanks @larrytin  Can you please resolve the conflicts?

@larrytin could you please resolve the conflict?

closing this PR based on latest comments from reviewer.


Fixes #4100 - Use output_file option in FetchUri

mesos.proto defines URI message type with output_file option.
Make FetchUri use this option in order to be able to define the name of
files we want to add to the mesos task.

Hello, I do not quite understand the error I got inside TeamCity Build.
It seems that it has nothing to do with my patch. Could you help me, please?
Thanks.

@mchataigner Thanks for this PR! One small comment regarding naming, otherwise looks good.
Would be great, if you could add the new property also to the example public/api/v2/examples/app.json and the schema public/api/v2/schema/AppDefinition.json.
The failure in TeamCity does not seem related to your PR. Will try to rerun.

Done.
Thanks for your help.

Thanks! LGTM. Waiting for the tests to pass.


Adding integration test for the example

Added integration test , please review

This has gone stale. @hhtong @hemantdwave let's close this one today. What happened with the other integration tests that use @retried?

From what I can tell, the circuit equivalence and factoring examples are the only ones who need @retried (n-queens too, though the decorator wasn't used). @hbarovertwo , while implementing, did you find that this example was always finding a valid solution for the default problem, or were there occasional failures?

It is not guaranteed to find a valid solution, which is why I thought the @retried decorator was here. I think we can get away without using it by expanding the test to capture the output of failures as it is expected behavior of the example.

I do think there's value in making sure that a valid solution is found eventually though (assuming that success rate is quite good).

@hbarovertwo @hhtong
I have moved all the interaction tests to our repo as we need to add more tests and lot more validation related to leap which we dont want to maintain here.
I am ok with having above test here. My initial reason to have retired due to we get wrong results when ran against SIM solver running multiple time increase chances of test to pass

I'm not entirely certain that I understand: what does "our repo" refer to @hemantdwave ?


Pagination after applying dancer filter is broken

If filter results in more than one page, using the Pagination ignores the filter and shows the entire list of dancers.

Fixed with pull request #23


Build failed when building a project with the plug-in

🐛 Bug Report

I installed this plug-in yesterday and tried the getCurrentPosition and getLastKnownPosition features. It worked just as expected. Then I did other non-related changes in my project (updated an asset) and when I tried to build again I got this error.

Execution failed for task ':geolocator:compileDebugJavaWithJavac'.
Unable to find source java class: '/Users/lauraroige/Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/geolocator-1.5.0/android/src/main/java/com/baseflow/flutter/plugin/geolocator/tasks/CurrentLocationTask.java' because it does not belong to any of the source dirs: '[/Users/lauraroige/Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/geolocator-1.6.0/android/src/main/java, /Users/lauraroige/Downloads/flutter/.pub-cache/hosted/pub.dartlang.org/geolocator-1.6.0/android/src/debug/java, /Users/lauraroige/ecolocal_app/ecolocal_app/build/geolocator/generated/source/r/debug, /Users/lauraroige/ecolocal_app/ecolocal_app/build/geolocator/generated/source/buildConfig/debug, /Users/lauraroige/ecolocal_app/ecolocal_app/build/geolocator/generated/source/aidl/debug, /Users/lauraroige/ecolocal_app/ecolocal_app/build/geolocator/generated/source/rs/debug]'

I tried changing the version of the plug-in, but when I delete the directory and install it again it always installs the 1.6.0 version regardless of what I try to install (tried with version 1.4.0 as the error mentions versions 1.5.0 and 1.6.0).
The project builds correctly if I eliminate the geolocator import from the pubspec. The build fails as soon as I add the import (even if I don't use it in the project code).
Expected behavior
Build correctly.
Reproduction steps
Add the plug-in to a project.
Configuration
Version: 1.6.0
Platform:

[ ] :iphone: iOS
[x] :robot: Android

Can you try to execute:
flutter clean

and then build your project?

As @audkar mentioned running flutter clean should solve this problem. Here is what (most probably) happened:

Yesterday we release version 1.6.0 of the Geolocator;
In your pubspec.yaml you probably registered the dependency to the Geolocator plug-in as geolocator: '^1.5.0' (meaning all version bigger then 1.5.0 and smaller then 2.0.0);

So when we released version 1.6.0, Flutter automatically updated the Geolocator package in your project. Unfortunately when updating the package the cache is not updated and still holds a reference to the 1.5.0 version causing the conflict you experienced. Running the flutter clean command will reset the cache and make sure the new version will be cached resolving your problem.


Issue with “Using Cordova with iOS and WebRTC”

I followed the instructions of “Using Cordova with iOS and WebRTC” and deploy the application on iPhone/iPad and it doesn’t work.
I try to debug the javascript by adding alert messages before and after each line of javascript code.
The message displayed after the following code was not display:
var SIP = cordova.require("com.onsip.cordova.Sipjs");
It seems like there is an issue with that line of code.
Here the code used (https://github.com/onsip/onsip-cordova):
<video id="localVideo"></video>
<video id="remoteVideo"></video>
<input id="target" type="text">
<button id="makeCall">Make Call</button>

document.addEventListener("deviceready", function() {
  var SIP = cordova.require("com.onsip.cordova.Sipjs");
  var PhoneRTCMediaHandler = cordova.require("com.onsip.cordova.SipjsMediaHandler")(SIP);
  var mediaOptions = {
    media : {
      constraints: {
        audio: true,
        video: false
      },
      render: {
        local: {
          video: document.getElementById('localVideo')
        },
        remote: {
          video: document.getElementById('remoteVideo')
        }
      }
    }
  };

  window.ua = new SIP.UA({
   uri: 'xxxxxx',
wsServers: 'ws://xxxxx:8088/ws',
authorizationUser: 'xxxxxx',
password: 'xxxxxx',
    mediaHandlerFactory: PhoneRTCMediaHandler,
    traceSip: true
  });

  document.getElementById("makeCall").addEventListener("touchstart", function() {
    if (window.session) {
      alert("Only one call at a time.");
      return;
    }
    window.session = window.ua.invite(document.getElementById('target').value, mediaOptions);
    window.session.on('terminated', function () {window.session = null;});
  });
  window.ua.on('invite', function(_session) {
    if (window.session) {
      alert("Only one call at a time.");
      _session.reject();
      return;
    }
    window.session = _session;
    window.session.accept(mediaOptions);
    window.session.on('terminated', function () {window.session = null;});

  });
});
app.initialize();

Chances are the onsip-cordova project needs an updated WebRTC library. Interest in that project has been pretty minimal and the amount of work needed to get those libraries updated is not trivial. I haven't had the time to put into it recently, and not many other people here know how to recompile it. There are some other WebRTC wrappers out there that might work for you like PhoneRTC.

Hi @excendia We use this project in production for iOS:
https://github.com/BetterVoice/iOS-SIP.js
It is basically the same concept as the PhoneRTC project, except rewritten in a way that uses a native socket for signaling communication so that iOS VoIP backgrounding can happen properly. We also have Hold, Transfer, Mute, Hold Music, etc all working properly. Oh, also it works with 64bit builds as well.

Hi @lylepratt , thank you for your reply.
Would you happen to have an example of iOS-SIP.js on how to register (with username, password, domain, websocket), call, and receive calls, along with all the other functionalities? Basically, I'd like to know how to use your plugin. Thank you.

@excendia it is used almost exactly like the PhoneRTC based plugin you've previously tried. It uses SIP.js as well. The only difference is you need to add this to your UA setup:
        mediaHandlerFactory: function defaultFactory (session, options) {
            if (window.cordova && device.platform === 'iOS') {
              var PhoneRTCMediaHandler = cordova.require('com.sipjs.phonertc.mediahandler')(SIP);
              return new PhoneRTCMediaHandler(session, options);
            }
            else {
              return new SIP.WebRTC.MediaHandler.defaultFactory(session, options);
            }
          },

Follow the install instructions once you've added the plugin to your cordova project. We will try to get some documentation in the repo written soon.

I added some instructions to the repo.

@lylepratt I followed the instructions, but I get linker errors when attempting to build a test application. Here are the steps I've taken: created project, added iOS platform, added SIP.js plugin, added iOS-Sip.js plugin, performed all the operations on step 4 for HelloCordova.xcodeproj, For CordovaLib.xcodeproj, I did the same, but I couldn't find Objective-C Bridging Header and Swift Optimization level. Anyways, I pressed the build button and it fails. Oh yeah, I added webrtc-ios-unified.a to my cordova iOS project folder and added it to linked frameworks and librairies.

I'm going to close this issue for now, but any further issues can be linked directly at our cordova project, or, more likely, over at lylepratt's project.


Added angularjs client

Hi Christian,
I would rather keep the UI from the service separately. Suggestion: create the UI in your repository and I'm going to link to it. I could add the CORS filter, so any external client could communicate with hell sockets. What do you think?

I do like that the client is shipped together with the application. Would you rather have a client, not coupled with the rest-resources, and if so, why?
I could see some benefits do to building separate technologies, separately (grunt and yeoman setup would help the build process.).

I think there could be several clients. Also I would like to use different frameworks (just for fun).  Also the client could be a HTML 5 offline app which is able to connect to multiple hellsockets generators at the same time.
But the main reason is: I would choose vanilla angular with material design. No other deps. I would also implement a separate UI for my purposes.
In long term we could ship hellsockets with a library (whatever is easier, leaner nicer). If you would create a separate project in your repo, I could use it a bit later. With a link from this repo you would get the same visibility without being dependent on me.


Implement water flood fill

Hi @TxN
I just download and run VoxelLand, it is awesome Minecraft-like!
Could you please continue to implement water flood fill and some sand gravity?
Thank you so much!

Thanks!
If I have some spare time, I will implement falling blocks on top of current entity system, this seems to be relatively simple task.
What's about water flow and fill, this seems to be more complicated (and performace-concerning), so it's in lower priority for now, but this is a decent challenge indeed.

Hi @TxN
Thank you so much
By the way, I think the current update of Light Game Core breaks the Voxel Land build. It works in the old version (Download on May 15)

Hello!
If you're still interested, I've added basic support for flying/falling blocks. Now, gravel and sand will fall down until hit solid block underneath. Additionaly, you can now launch blocks in air by pressing 'N' key on your keyboard.

Hi @TxN Thank you I will check it out now!

Hi @TxN I did a stress test and the Sand support work very well!
Now I hope you can implement Water and Water Fall flood fill soon!
Thank you very much for bringing it to the VoxelLand!

@TxN I am very Happy to see you are coming back to this awesome project.
If you have time, please implement simple water fill system, to make game more real
Have a nice day! Best wish!


Allow relative URLs

Files in dist/ are generated by npm run build. The only actual change is adding base url in URL constructor in src/ButtonPanel.tsx.


Fixing Class Name and Incorporating Isis CubeFile

First off, I fixed the typo in PlanetaryImage.
Then I reimplemented the Isis CubeFile class as a sublcass of PlanetaryImage.

Oh, note that I also changed PlanetaryImage.image to PlanetaryImage.data to be consistent with the original implementation.


Error on frappecloud installation

The error that shows up, the moment I send a simple message to the client. The installation is done on frappe cloud
`### App Versions
{
	"chat": "0.0.1",
	"doppio_bot": "0.0.1",
	"erpnext": "14.22.3",
	"frappe": "14.33.1",
	"helpdesk": "0.8.1",
	"hrms": "14.2.2",
	"payments": "0.0.1",
	"sales_commission": "0.0.1",
	"surplus_asset_management": "0.0.1"
}

Route
doppio-bot

Traceback
Traceback (most recent call last):
  File "env/lib/python3.10/site-packages/redis/connection.py", line 559, in connect
    sock = self._connect()
  File "env/lib/python3.10/site-packages/redis/connection.py", line 615, in _connect
    raise err
  File "env/lib/python3.10/site-packages/redis/connection.py", line 603, in _connect
    sock.connect(socket_address)
OSError: [Errno 99] Cannot assign requested address

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 66, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 54, in handle
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 45, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1607, in call
    return fn(*args, **newargs)
  File "apps/doppio_bot/doppio_bot/api.py", line 43, in get_chatbot_response
    return conversation_chain.run(prompt_message)
  File "env/lib/python3.10/site-packages/langchain/chains/base.py", line 213, in run
    return self(args[0])[self.output_keys[0]]
  File "env/lib/python3.10/site-packages/langchain/chains/base.py", line 106, in __call__
    inputs = self.prep_inputs(inputs)
  File "env/lib/python3.10/site-packages/langchain/chains/base.py", line 193, in prep_inputs
    external_context = self.memory.load_memory_variables(inputs)
  File "env/lib/python3.10/site-packages/langchain/memory/buffer.py", line 39, in load_memory_variables
    return {self.memory_key: self.buffer}
  File "env/lib/python3.10/site-packages/langchain/memory/buffer.py", line 24, in buffer
    self.chat_memory.messages,
  File "env/lib/python3.10/site-packages/langchain/memory/chat_message_histories/redis.py", line 50, in messages
    _items = self.redis_client.lrange(self.key, 0, -1)
  File "env/lib/python3.10/site-packages/redis/client.py", line 1975, in lrange
    return self.execute_command('LRANGE', name, start, end)
  File "env/lib/python3.10/site-packages/redis/client.py", line 898, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "env/lib/python3.10/site-packages/redis/connection.py", line 1192, in get_connection
    connection.connect()
  File "env/lib/python3.10/site-packages/redis/connection.py", line 563, in connect
    raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 99 connecting to localhost:6379. Cannot assign requested address.

Request Data
{
	"type": "POST",
	"args": {
		"prompt_message": "Can you tell me your name",
		"session_id": "38vGQU8_UO9mqNKbOyD9L"
	},
	"headers": {},
	"error_handlers": {},
	"url": "/api/method/doppio_bot.api.get_chatbot_response"
}

Response Data
{
	"exception": "redis.exceptions.ConnectionError: Error 99 connecting to localhost:6379. Cannot assign requested address."
}

Looks like redis is not running on the assumes port, for now you can manually pass the redis url on this line:

message_history = RedisChatMessageHistory(session_id=session_id)

I will figure out a better way in the meantime (for FC).

Fixed with 596d2cec368eebb33a370d09df86c063d9462ed3


freetalk: fixed cross-compilation

Motivation for this change
Some build-time and run-time dependencies were mixed. I put them in a right place!
(I hope texinfo isn't really required at runtime, but moving it to a build-time dependency seemed to work, so it doesn't link to it.)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @7c6f434c

@GrahamcOfBorg build freetalk

Works fine, thank you.

Thanks!


Tooltips don't dismiss on escape

Description
According to https://www.w3.org/TR/WCAG21/#content-on-hover-or-focus content that appears on hover or on focus needs to be dismissible. Pressing the escape key should dismiss tooltips when they are being shown.
Steps to reproduce

Go to https://primer.style/components/tooltip/react
Hover over the tooltip in the example
Press 'escape'
The tooltip is still there

Version
v36.1.0
Browser
Chrome

Hi there, @jdrush89! I believe some of the shortcomings in the existing Tooltip component are being addressed with the new component in drafts (Link).
@broccolinisoup just wanted to check, did I get that right? 👀 And is there any guidance that we have for folks who are dealing with a11y remediations with the existing tooltip?

@joshblack yes, that is perfect!

And is there any guidance that we have for folks who are dealing with a11y remediations with the existing tooltip?

Not that I am aware of sorry. Might worth to check with #accessibility.

@jdrush89 if you'd like to follow along on further progress on the new Tooltip component, you may be interested in subscribing to https://github.com/github/primer/issues/1244.
We'll also announce in PRC release notes and the Primer Changelog when the improved Tooltip is officially rolling out, if you'd prefer to hold off on adoption until then.

Tooltip v2 is available from the next bundle https://primer.style/components/tooltip/react/beta and adopting it should resolve the problem reported ✨ I'm closing this issue but please feel free to reopen if you have any concern 🙌


Add a license to project

Wondering what type of lisence to add to project @JJJ62

Added lisence file


Confused by the interaction between ROI features and proposal features

Thx for your interesting work and the code. I am confused by some points as follow when fusing ROI feats and proposal feats:

In this setting, the transformed proposal feature serves as a key, and the transformed ROI feature is regarded as a query. Firstly, producing an attention weight between ROI feature and proposal feature. Then, combining the attention weight with the other transformed proposal feature, which is a value. In this case, none of the appearance features (ROI) are kept, the interacted and output feature is a re-weighted proposal feature.  The ROI feature only plays a role to compute an attention map. I do not understand why it works, predicting bounding-box without the appearance features. Additionally, it also looks different from the original paper:

And it is inversed to the multi-head attention in Detr. @PeizeSun

Hi~
In fact, our dynamic interaction is not same as multi-head attention. We do not recommend you understand dynamic interaction by the concepts of query, key and value.

Hi~
In fact, our dynamic interaction is not same as multi-head attention. We do not recommend you understand dynamic interaction by the concepts of query, key and value.

Thx for your reply. I still have a question about ablation studies. Could you provide more details about the multi-head attention setting in Table 8, e.g., query, key, and value?

In fact, our dynamic interaction is not same as multi-head atten

Hi, thank you for your novel work and replies.
I noticed that parameters was separated into two parts and interact with RoI separately, does it have special significance?
thx in advance!

Hi, thanks for your work.
I have the same question as BreezeHavana that why parameters was separated into two parts and interact with RoI separately? Has the question been answered?

auto reply


Show quick open results as preview while navigating through them

VSCode Version: 1.3.0
OS Version: Windows 10 64bit & Mac OS X 10.11.3

Steps to Reproduce:

Open the Quick Open box
Type a file name that returns several results
A new Preview editor pops up and receives focus with the first result loaded into it
Scroll through the results in the Quick Open box and the Preview editor changes to the file that's highlighted
Selecting a result will fully open the file. Canceling can close the Preview editor or leave it open. I'd prefer if it closed the preview.

I myself have been wanting this very same thing.  I tend to open several files up front, and then I have to double-click each one.
I think that opening something via Quick Open as a fully-opened file makes sense in this case, because if you had the opportunity to see a preview and still committed via enter or a click to open it then you probably intend to keep it around for a while.

Just to be clear, the point of this is to see the contents of a file as I scroll through the results of Quick Open. As far as permanently opening a file from quick open, that would be good too.

Previewing files as you move up and down the list of results makes a lot of sense. For files that are currently open we would bring them to the front.

I'm glad I found this issue (under this not-so-much clear title), so I don't have to create it myself.
I just got annoyed by this behaviour of closing files - I evidently wanted to have opened - for the 451th time in the last two weeks.
Please, let's make it into the next release. :)

Ive spent some time working through this.  Have a good understanding of the organization of the editorPart, groups, stack model, etc.  Pushing up a PR, but I'd really like to fix some UX issues below.

The preview editor will remain and whatever you last were looking at in Quick Open will also remain inside that preview editor—exception: if you were on a preview editor when you opened Quick Open and previewed some items but never selected any (e.g. escaped out of it) then we will restore whatever you previously had open in that preview tab, since that would indicate that the preview tab is likely something you want to keep and not replace.

I think a better UX would be to close a preview editor if there were none open.  Hitting escape should remove all side effects e.g. opening a new preview editor.

Upon hitting Enter, the open editor will be kept open (i.e. no longer preview).

Would we prefer to honor the user preference workbench.editor.enablePreviewFromQuickOpen (this is how Ive implemented it)

Another UX issue that I discovered while previewing in a current previewEditor: the scroll positions are lost.
We could keep track of a selection/cursor when opening with TextEditorOptions, however, this feels kind of kludgy to keep track of this just if we are swapping the contents of a preview editor.  An easier approach could be to render a tab-less editor that would be show while previewing files that are not find in the current editor groups.
Thoughts?

Sublime preserves the cursor position of each file, and when you preview that file, it shows the cursor in that position. If you haven't visited that file before, it defaults to the top of the file.

Sublime preserves the cursor position of each file, and when you preview that file, it shows the cursor in that position. If you haven't visited that file before, it defaults to the top of the file.

actually, they use a brand new editor buffer when displaying a file that has no editor associated with it.  otherwise, you're effectively just swapping the viewable editors (VS Code also will preserve line and viewport position in this respect).  this is what Im doing now in my PR.
Im lobbying for a new buffer with no tab, so we can have a similar experience to what ST has.

Also, Sublime will put focus on an open tab if what you have selected in Quick View is already open.

yeah, see my PR.  these behaviors are implemented.

@wprater yes, the preview editor has to go away when I cancel my quick open session without picking an item. I cannot see how the scroll positions can get lost unless you actually provide options with line/col information. We always persist the view state of the editor and restore it on open unless you provide your own view state.

We always persist the view state of the editor and restore it on open unless you provide your own view state.

The issue is that I need to render another temporary editor and display it as an eager preview.  Its not really a preview (or pinned) editor until one selects it.
Do you know of a method in which I could create such an editor?  I can keep looking around, but if there are some mechanics already, I'd like to utilize them.

@wprater I do not understand why you would want to open a temporary editor...

@wprater I do not understand why you would want to open a temporary editor...

Might make it easier around the logic of maintaining when a new preview editor was opened or not.  As well as the issue Im having when previewing in the preview editor, where the new files seem to be opened at the final line, vs. the top of file (they were not previously opened.)
If you did not have a preview editor open and the eager preview display opened an editor, then when cancelling, Im not certain how rest the editor group's state of active/preview editors.

Whatever we end up doing, you cannot open a "preview editor", it can only be the file imho. I think in order to restore the previous state you probably have to capture it and restore it.
As for opening on first line, you can pass options for the open to have it open at line/col 1. it is interesting if that is the desired behaviour though.

Maybe my nomenclature is a bit off.  I believe the current PR follows suit to the UX meetings notes.  However, I would prefer we not allow any side effect when cancelling out of a quick open widget.  If you agree, I need to determine if a new preview editor was opened when not one presently.  If there was not one open, I need to be sure to close the preview editor that was created to preview the focused items in the tree.  I'll look into that again tomorrow.
I don't desire to have them open on the first line/col, unless the file was not already present in an editor buffer.  If I continually swap the preview editors, I was seeing many of my files loaded into the preview on the last line.  The other files editors that are selected seem to work great!

Ok I think I was confused by terms here. We agree on this behaviour:

editors open as files when you navigate through the list
they open as preview editors (not pinned) no matter what the user has configured to prevent accumulation of many editors
they open on whatever line/col they used to be
if there was no preview editor opened, the preview editor closes upon cancel
if there was a preview editor, it gets restored upon cancel

thanks for outlining these.
I have these all complete in the PR with exception of comments below:

if there was no preview editor opened, the preview editor closes upon cancel

need to determine best way to achieve this functionality.
also, can you edit your list to include a not about history?  I want to be sure Im not including history events.  there are two types, from what I can tell: handleEditorEventInStack and handleEditorEventInHistory.  Do we need stop inclusion in both, or just the stacks?

@wprater IEditorGroupService.getStacksModel() gives you complete access about what is going on in the editor stacks world (1 stack contains 3 groups side by side of N editor tabs). I think the best is to just store the current preview editor before doing the magic and then restore either the previous one on cancel or close the opened one if there was no preview editor before.
Yes you are quite right that these are the two methods that need to ignore the preview editors. The former is a stack of editors that you can go back and forward via the Go menu and the latter is the editor history that is persisted across restarts and accessible from Cmd+P. As you can see there is already a boolean blockStackChanges for the stack and we need to have a new method that flips another boolean for the duration of the previewing that also blocks changes to history imho.

Updated design notes above.  Thanks :)

@bpasero @roblourens Right now if we use CMD + P with right arrow key it will open file, but without preview mode. So basically if we improve right arrow key in file navigation to open file in preview mode this feature will be done. Of course it will be a little bit different from ST 3, because you see file content simultaneously while navigating.

What's happening with this feature? It looks like it's been discussed since 2016 but I'm not seeing it in the latest VS Code, even with workbench.editor.enablePreview and workbench.editor.enablePreviewFromQuickOpen set to true

I'm interested too because this feature in Sublime is OP, we definitely need this in VS Code!!!

Unfortunately it seems like there are some technical issues blocking this. See this comment here: https://github.com/Microsoft/vscode/issues/12892#issuecomment-286149590

@stevencl @bpasero The issues mentioned in
#12892 (comment)  should not be a blocker. It could simply just work like preview mode currently does when selecting any new file from the file explorer. It will open a preview tab, and if selecting another file, then the preview tab name and content changes. It's not necessary to augment the core workbench UI with a whole new way of viewing files without any visible tab.
Wouldn't this be easy enough to implement if reusing the preview mode from the file explorer?

I submitted #60822 to request a feature to immediately switch tabs when pressing Ctrl-Tab (as opposed to switching when Ctrl is released), but it was closed for being a duplicate of this one.
I don't see why it's a duplicate. I mean it's sort of related, but that one was much easier to implement. Maybe they're planning something big?

Any news? Trying to switch from Sublime to VS Code and I miss this feature a lot.

I need this so badly!

There is a very nice extension that has begun to implement this functionality.  It could use some improvement if anyone was the time to contribute (and if the author is accepting contributions of course).
https://marketplace.visualstudio.com/items?itemName=Cmacu.gotoanything
https://github.com/Cmacu/gotoanything

@mmcintyre123 Thanks.
I will look into ways to improve the performance and add other features this weekend.
Contributions are welcome.

I'd also very much like this feature!

What is the issue here? This is a show stopper for us, any plan to release this functionality?

I surprised that vscode does not support it....

I surprised that vscode does not support it....

Yes, Sublime Text has it and it's awesome. Any news on this?

Yes, Sublime Text has it and it's awesome. Any news on this?

+1

Is there an open PR for this? I would like to contribute if possible

Yes, Sublime Text has it and it's awesome. Any news on this?

+1

For now, I'd just go for https://marketplace.visualstudio.com/items?itemName=Cmacu.gotoanything Does exactly this :)

What's the status??? This feature was a major performance enhancer for me while playing with VIM.

Things I miss in quick open after switching to VSC compared to Sublime Text:

file preview
file path in a separate row

For now, I'd just go for https://marketplace.visualstudio.com/items?itemName=Cmacu.gotoanything Does exactly this :)

Not exactly, it messes up searching with multiple words, e.g. if I have a file path c:/fruits/bananas/File.js searching with "bananas file" won't return results. Without the plugin it does.

It also doesn't show file icons in front of the results. I've submitted https://github.com/Cmacu/gotoanything/issues/8 and https://github.com/Cmacu/gotoanything/issues/9

Not exactly, it messes up searching with multiple words, e.g. if I have a file path c:/fruits/bananas/File.js searching with "bananas file" doesn't return results. Without the plugin it does.

It also doesn't show file icons in front of the results. I've submitted Cmacu/gotoanything#8 and Cmacu/gotoanything#9

Got it. I can resolve both of these over the weekend.

I feel like there's prior art here in the suggest widget:

I feel like there's prior art here in the suggest widget:

@TylerLeonhardt, Which dialog is that? It looks like a different dialog than the "quick open, go to file" (Crtl/CMD-p) which the OP seems to indicate in step 2:

Type a file name that returns several results

@dpidan I think the screenshot is referring to one of VSCode apis.
Basically if you press the right arrow with one of the files selected from quick open, it opens the file without closing the quick open dialog.
The only issue is that those files are opened permanently, so pressing the right arrow key subsequently on different files will just open a whole bunch of tabs, rather than replacing the previous editor.

@dpidan it's Intellisense in an editor... that has items, with additional context, and is keyboard driven.

While we wait for this feature, this extension FindItFaster does a pretty good job. It would be great if we get this built-in.

7 years later and counting ⏳ 😄

While we wait for this feature, this extension FindItFaster does a pretty good job. It would be great if we get this built-in.

It will be amazing to have fzf with that preview build in to VsCode.

Dear Diary,
Its been December 2023. This feature is not implemented in VS Code. I will share more updates later.
:(

I'd pay for that feature. I really miss it.

This feature is missing so much... PLEEEEESEEE

I made a little extension 🫧 Periscope last year to give me an experience as close as possible whilst constrained by the existing vscode UI primitives.
It's evolved a bit to lean in to ripgrep but its remained my daily driver for grepping across the workspace.
Might be useful to some of you! :v:

@joshmu this kinda looks like the built-in "Quick Search" feature that VSCode has been iterating on for the past few releases, no? https://code.visualstudio.com/updates/v1_88#_quick-search-improvements

@joshmu this kinda looks like the built-in "Quick Search" feature that VSCode has been iterating on for the past few releases, no? https://code.visualstudio.com/updates/v1_88#_quick-search-improvements

however, there's no quick preview, i would guess it's because of the limitations with the vscode ui primitives, as @joshmu mentioned
that telescope.nvim ui is wicked, i'm seriously considering nvim

@jbrodriguez not sure what you mean. As you arrow-through the results using VSCode's Quick Search, the currently-focused editor shows you a preview of that result in the file where it exists. Seems the same as the video in the extension I was replying to.

you're right, yes, not as straightforward, but does the job

@macintacos the Quick Search (experimental) is similar to Periscope in regards to file previews as you navigate across results.  The biggest difference would be that Periscope provides access to more of ripgrep.  eg: pattern matching, file type & sub folder filtering, etc.  You can personalise this to your needs and create abbreviations for your common searches.
If there is no interest in those type of advanced grep features then Quick Search would be sufficient

@macintacos but the quicksearch feature which you mention, does not work when you go to "open file" search dialogue or? Just for full text seach, not for file search.

@h0jeZvgoxFepBQ2C right. I wasn't saying that that feature in VSCode takes care of this issue. I was just saying that that feature is very similar to the Periscope extension that was linked to earlier in the thread.
I don't think that the issue described in the original description is "solved", by any means.

Would love to have this feature in the editor picker (when you press Ctrl+Tab) too.

Any news from the dev team on this ? A built in telescope in vscode would make the programming experience soo much better...

Bump, still waiting ;)

Hi @Alan-MQ would you make this open? Looks like you got to an interesting point and i would love to take a look and see if i can help in anyway since i am really looking for this feature in VScode and it's the reason why i am still not switching from nvim to vscode.

Hi @Alan-MQ would you make this open? Looks like you got to an interesting point and i would love to take a look and see if i can help in anyway since i am really looking for this feature in VScode and it's the reason why i am still not switching from nvim to vscode.

yeah , sure I've updated that comment, check it out, and feel free to let me know if I missed something~~

It would indeed be very useful to automatically show the preview of a searched file.
Are there any chances of this being prioritized any time soon @TylerLeonhardt? :)

https://github.com/jpcrs/binocular
Might be a good workaround if you can get it to work.  I wasn't having any luck on Windows, despite having all the dependencies.


Add icons for Adobe Illustrator files and AppleScript

TODO

[x] Use cargo fmt
[x] Add necessary tests
[x] Add changelog entry
[ ] Update default config/theme in README (if applicable)
[ ] Update man page at lsd/doc/lsd.md (if applicable)

Codecov Report

Merging #636 (c6133a3) into master (728ee11) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   86.12%   86.10%   -0.02%
==========================================
  Files          37       37
  Lines        3957     3959       +2
==========================================
+ Hits         3408     3409       +1
- Misses        549      550       +1

Impacted Files
Coverage Δ

src/icon.rs
97.69% <100.00%> (+0.01%)
:arrow_up:

src/meta/inode.rs
62.50% <0.00%> (-6.25%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728ee11...c6133a3. Read the comment docs.

Thank you for the PR :D


sway/workspaces: make clicking on workspaces idempotent

Previously, clicking on the same workspace you were on would throw you
to another workspace if workspace_auto_back_and_forth yes was
specified in your sway config. This also fixes workspace output moving
misbehaving and doing the same.

LGTM except the comment 😃

Thanks!

Previously, clicking on the same workspace you were on would throw you
to another workspace if workspace_auto_back_and_forth yes was
specified in your sway config.

Isn't that what this config flag was supposed to do? I used it to toggle between two workspaces. Any way to re-enable this behavior?

@Xyene Hi, just to let you know #1014 was just merged into master.
In order to keep the behavior you introduced with this PR, there is a new config flag disable-auto-back-and-forth you have to set to true in the Sway/Workspaces config.


Add multiple PTC accounts and cycle through them for faster cell refresh

Due to the API throttling now, it would probably be good to increase the performance by being able to add multiple PTC  accounts and have the program cycle through them to request cell refreshes at a faster rate since single accounts are now throttled severely and cannot request more than one thing at a time.
Just a thought! :)

Agreed

are you sure the throttling is account based?   I've been testing that theory myself.   I used to be able to run 14 instances at the same time without degradation (using 0.1.3).    Today I can run 6 without degradation... The moment I start the 7th instance is when things start to break... I tested using another PTC account on my 7th instance and it has the same results as if I was using the same account.   That leads me to believe the throttling happens on either an IP address based or a session based criteria (or maybe both)..

@calgar Tested and definitely account-based throttling.

if the above is true then the solution can be a distributed model (client/servers) with several VPN endpoints which is I guess where they're trying to migrate the software to (since 0.1.5 opens listeners on your host)

@andrewda how many instances do you run per account?

I can run 2 fine. any more and the app even tells me it has outages that affect all scans


Evaluation data calculation

Dear author, it is a great honor to read your paper, and thank you very much for making your code public. I have some questions about the code problem, and I hope you can help me to answer them.
I looked at the code for test, but found that it only had the function of saving images. May I ask how the value of the evaluation index in the paper is calculated? Is this done through external software?

Hi @AArutoria ,
Thanks for your interest in our work. We didn't release the evaluation script. But the computation of Dice score is provided as follows:
def dice(im1, atlas):
    unique_class = np.unique(atlas)
    dice = 0
    num_count = 0
    for i in unique_class:
        if (i == 0) or ((im1 == i).sum() == 0) or ((atlas == i).sum() == 0):
            continue

        sub_dice = np.sum(atlas[im1 == i] == i) * 2.0 / (np.sum(im1 == i) + np.sum(atlas == i))
        dice += sub_dice
        num_count += 1
    return dice / num_count

The evaluation was done with Python script using numpy and pytorch.


only enlarge mediacard on first row

Like name

shouldn't Made for you and Replay be big as well?


Repo sync for protected CLA branch

The pull request is created from master637696571878178861 to master to fix git push error for protected CLA branch

#label:"aq-pr-triaged"

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Existing Login Form a Flat Responsive Widget Template :: W3layouts

VS Code Version:
OS Version:

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

/needsMoreInfo


Add issue_template.md

Creating and adding a new custom issue template for this project.

Issue resolved. Closed.

Hey @AstroAirafar ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Bring you own cluster - masking kubeconfig

Description
Improvements in handling of bring own cluster plan
Changes proposed in this pull request:

Masking kubeconfig before logging it
Decoding kubeconfig - it should be base64 encoded in the request

Related issue(s)

/test all


ci: Assorted fixes for scheduled runs

filter example
clang_tidy

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

pushing through to fix scheduled CI


Basic GLTFExporter support

Dependent on https://github.com/mrdoob/three.js/pull/23857

PR was merged into three.js, we're now depending on a commit on three.js dev branch. Also I've exposed the window.exportScene() method so you can export the current state of the scene


Top News Headlines

Describe the project
Introducing a dynamic news website that brings you the latest and most relevant news stories from around the world in real-time. With the use of a cutting-edge news API, this website ensures that you stay up-to-date with the most current headlines from various reputable news sources. Whether it's breaking news, politics, sports, or entertainment, this website is your go-to destination for all the latest happenings from across the globe. Stay informed and ahead of the curve with our constantly updating news feed, available to you 24/7.
Issue Type:

[x] New Project

Screenshots

Shall I work on this issue?

Create a fresh issue after 1st June


Add instructions for 1.3 input system workaround

Summary
Adds instructions for fixing a compilation issue with plugin samples and the new Unity input system.
Tests

N/A
ArcGIS Maps SDK Version

1.3

Looks great! Just two quick comments:

Should we use a screenshot that shows the Unity.InputSystem is already added for better illustration?

Also, the new Input System package is not included by default. If this package is not installed, users will not be able to find  Unity.InputSystem  .asmdef from the list. Should we also mention this in case some users might not be aware of this?


Remove use of base_url from DataAPIClient

This is no longer needed as _get in the BaseAPIClient prepends it. It hasn't been causing any problems because urlparse.urljoin is sensible.

:+1:


ValueError: Could not parse output - map_rerank

System Info
Langchain version: 0.0.325
Python version: Python 3.11.6
Who can help?
@hwchase17
chain_type="map_rerank" is not working when the search cannot be found on the DB
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[X] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
Code:
from dotenv import load_dotenv
from langchain.vectorstores.chroma import Chroma
from langchain.chains.retrieval_qa.base import RetrievalQA
from langchain.chat_models.openai import ChatOpenAI
from langchain.embeddings.openai import OpenAIEmbeddings
import langchain

load_dotenv()
chat = ChatOpenAI()
embeddings = OpenAIEmbeddings()

db = Chroma(
    persist_directory="emb",
    embedding_function=embeddings,
)

retriever = db.as_retriever()
chain = RetrievalQA.from_chain_type(
    llm=chat,
    retriever=retriever,
    chain_type="map_rerank",
    verbose=True
)
result = chain.run("Who was Michael Jackson?") # <-- not in the database
print(result)

Prints:
raise ValueError(f"Could not parse output: {text}")
ValueError: Could not parse output: I don't know.

Expected behavior
Print: "I don't know"

I added this: https://github.com/langchain-ai/langchain/pull/11519. Looks like we may need to do something similar for retrievalqa chains.

Facing the similar issue. Is this solved?

Same issue here, it seems sometimes the LLMChain returns a text that lacks the Score, and then the RegexParser fails in here.


Global Theme

This commits changes lots of things related to themes.
This adds android and ios specific folders, because of the inclusion of /assets
This added 13 palette colors, and 2 fonts (WIP)
This adds padding to most important elements (Not sure why that isn't a thing out of the box?)
This addresses #16

This should be good to go, @PatHealy or @nicksmider make sure this looks good.
Change the initialRoute location in App.js to 'Theme' and you can check out the theme screen.
I only styled the components we'll use, and make sure the palette is fine, I just used a generator for it


Homepage fact tile

@blisteringherb and @DFurnes what did you do to get the Charleston as the main tile on the homepage?
we need to do a similar thing for the yahoo partnership, where the main tile doesn't link to a campaign node (@mikefantini remembers creating a dummy campaign node and changing the redirect on it)
The image should link to an 11-facts page.

Yep, dummy campaign (which lets us set the title, description, and tile image), which is set to redirect to another URL. Kinda hacky, but it works.

ah yeah ok we just created a redirect in the drupal interface. i can just have @ArielSD make this happen.


AVR-UART-lib && Atmega328

Hi,
Sorry for the rather vague issue, but I am having some problems getting your library to work with AtmelStudio 7 and Atmega328.
Even a clean project with the example multiple usart.c, and the required headers fails with multiple undeclared warnings.
Is this a known incompatibility?
Regards,
Petter.

Could you paste whole compilation log?

------ Build started: Project: usart, Configuration: Debug AVR ------
Build started.
Project "usart.cproj" (default targets):
Target "PreBuildEvent" skipped, due to false condition; ('$(PreBuildEvent)'!='') was evaluated as (''!='').
Target "CoreBuild" in file "C:\Program Files (x86)\Atmel\Studio\7.0\Vs\Compiler.targets" from project "c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\usart.cproj" (target "Build" depends on it):
	Task "RunCompilerTask"
		Shell Utils Path C:\Program Files (x86)\Atmel\Studio\7.0\shellUtils
		C:\Program Files (x86)\Atmel\Studio\7.0\shellUtils\make.exe all --jobs 4 --output-sync
		Building file: .././main.c
		Invoking: AVR/GNU C Compiler : 5.4.0
		.././main.c: In function 'main':
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(39,5): error: implicit declaration of function 'uart1_init' [-Werror=implicit-function-declaration]
		     uart1_init(BAUD_CALC(115200));
		     ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(48,5): error: implicit declaration of function 'uart1_puts_P' [-Werror=implicit-function-declaration]
		     uart1_puts_P("hello from flashed, usart 1\r\n"); // write string to usart buffer from flash memory // string is parsed by PSTR() macro
		     ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(49,5): error: implicit declaration of function 'uart1_puts_p' [-Werror=implicit-function-declaration]
		     uart1_puts_p(foo_string);
		     ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(55,5): error: implicit declaration of function 'uart1_gets' [-Werror=implicit-function-declaration]
		     uart1_gets(buffer, 25); // read at most 24 bytes from buffer (CR,LF will not be cut)
		     ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(80,9): error: implicit declaration of function 'uart1_putfloat' [-Werror=implicit-function-declaration]
		         uart1_putfloat(0.1337f);
		         ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(81,9): error: implicit declaration of function 'uart1_puts' [-Werror=implicit-function-declaration]
		         uart1_puts("\r\n");
		         ^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(82,9): error: implicit declaration of function 'uart1_putstr' [-Werror=implicit-function-declaration]
		         uart1_putstr(buffer); // write array string to usart buffer
		         ^
		cc1.exe: some warnings being treated as errors
		make: *** [main.o] Error 1
		"C:\Program Files (x86)\Atmel\Studio\7.0\toolchain\avr8\avr8-gnu-toolchain\bin\avr-gcc.exe"  -x c -DDEBUG -DBOARD=ATMEGA328P_XPLAINED_MINI  -I"C:\Program Files (x86)\Atmel\Studio\7.0\Packs\Atmel\ATmega_DFP\1.2.203\include" -I"../src/ASF/common/boards" -I"../src/ASF/mega/utils/preprocessor" -I"../src/ASF/mega/utils" -I"../src/ASF/common/utils" -I"../src/ASF/mega/boards" -I"../src/ASF/mega/boards/atmega328p_xplained_mini" -I"../src/ASF/common/services/gpio" -I"../src/ASF/common/services/ioport" -I"../src" -I"../src/config" -I"../src/ASF/mega/drivers/cpu" -I"../src/ASF/common/services/clock" -I"../src/ASF/common/services/delay" -I"../src/ASF/mega/drivers/usart"  -O1 -fdata-sections -ffunction-sections -fdata-sections -fpack-struct -fshort-enums -g3 -Wall -mmcu=atmega328p -B "C:\Program Files (x86)\Atmel\Studio\7.0\Packs\Atmel\ATmega_DFP\1.2.203\gcc\dev\atmega328p" -c -std=gnu99 -fno-strict-aliasing -Wstrict-prototypes -Wmissing-prototypes -Werror-implicit-function-declaration -Wpointer-arith -mrelax -MD -MP -MF "main.d" -MT"main.d" -MT"main.o"   -o "main.o" ".././main.c"
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\Debug\Makefile(133,1): error: recipe for target 'main.o' failed
	Done executing task "RunCompilerTask" -- FAILED.
Done building target "CoreBuild" in project "usart.cproj" -- FAILED.
Done building project "usart.cproj" -- FAILED.

Build FAILED.
========== Build: 0 succeeded or up-to-date, 1 failed, 0 skipped ==========

Why van i read these messages?
8 lut 2018 22:22 "Petter Wahlman"<EMAIL_ADDRESS>napisał(a):

------ Build started: Project: usart, Configuration: Debug AVR ------
Build started.
Project "usart.cproj" (default targets):
Target "PreBuildEvent" skipped, due to false condition; ('$(PreBuildEvent)'!='') was evaluated as (''!='').
Target "CoreBuild" in file "C:\Program Files (x86)\Atmel\Studio\7.0\Vs\Compiler.targets" from project "c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\usart.cproj" (target "Build" depends on it):
Task "RunCompilerTask"
Shell Utils Path C:\Program Files (x86)\Atmel\Studio\7.0\shellUtils
C:\Program Files (x86)\Atmel\Studio\7.0\shellUtils\make.exe all --jobs 4 --output-sync
Building file: .././main.c
Invoking: AVR/GNU C Compiler : 5.4.0
.././main.c: In function 'main':
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(39,5): error: implicit declaration of function 'uart1_init' [-Werror=implicit-function-declaration]
uart1_init(BAUD_CALC(115200));
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(48,5): error: implicit declaration of function 'uart1_puts_P' [-Werror=implicit-function-declaration]
uart1_puts_P("hello from flashed, usart 1\r\n"); // write string to usart buffer from flash memory // string is parsed by PSTR() macro
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(49,5): error: implicit declaration of function 'uart1_puts_p' [-Werror=implicit-function-declaration]
uart1_puts_p(foo_string);
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(55,5): error: implicit declaration of function 'uart1_gets' [-Werror=implicit-function-declaration]
uart1_gets(buffer, 25); // read at most 24 bytes from buffer (CR,LF will not be cut)
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(80,9): error: implicit declaration of function 'uart1_putfloat' [-Werror=implicit-function-declaration]
uart1_putfloat(0.1337f);
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(81,9): error: implicit declaration of function 'uart1_puts' [-Werror=implicit-function-declaration]
uart1_puts("\r\n");
^
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\main.c(82,9): error: implicit declaration of function 'uart1_putstr' [-Werror=implicit-function-declaration]
uart1_putstr(buffer); // write array string to usart buffer
^
cc1.exe: some warnings being treated as errors
make: *** [main.o] Error 1
"C:\Program Files (x86)\Atmel\Studio\7.0\toolchain\avr8\avr8-gnu-toolchain\bin\avr-gcc.exe"  -x c -DDEBUG -DBOARD=ATMEGA328P_XPLAINED_MINI  -I"C:\Program Files (x86)\Atmel\Studio\7.0\Packs\Atmel\ATmega_DFP\1.2.203\include" -I"../src/ASF/common/boards" -I"../src/ASF/mega/utils/preprocessor" -I"../src/ASF/mega/utils" -I"../src/ASF/common/utils" -I"../src/ASF/mega/boards" -I"../src/ASF/mega/boards/atmega328p_xplained_mini" -I"../src/ASF/common/services/gpio" -I"../src/ASF/common/services/ioport" -I"../src" -I"../src/config" -I"../src/ASF/mega/drivers/cpu" -I"../src/ASF/common/services/clock" -I"../src/ASF/common/services/delay" -I"../src/ASF/mega/drivers/usart"  -O1 -fdata-sections -ffunction-sections -fdata-sections -fpack-struct -fshort-enums -g3 -Wall -mmcu=atmega328p -B "C:\Program Files (x86)\Atmel\Studio\7.0\Packs\Atmel\ATmega_DFP\1.2.203\gcc\dev\atmega328p" -c -std=gnu99 -fno-strict-aliasing -Wstrict-prototypes -Wmissing-prototypes -Werror-implicit-function-declaration -Wpointer-arith -mrelax -MD -MP -MF "main.d" -MT"main.d" -MT"main.o"   -o "main.o" ".././main.c"
c:\users\petter\Documents\Atmel Studio\7.0\usart\usart\Debug\Makefile(133,1): error: recipe for target 'main.o' failed
Done executing task "RunCompilerTask" -- FAILED.
Done building target "CoreBuild" in project "usart.cproj" -- FAILED.
Done building project "usart.cproj" -- FAILED.
Build FAILED.
========== Build: 0 succeeded or up-to-date, 1 failed, 0 skipped ==========
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jnk0le/AVR-UART-lib/issues/4#issuecomment-364252558,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZdbw4NopUPeIA_bMZa6Y3IM6tD7ImNuks5tS2WvgaJpZM4R_CLS
.

Code containing uart1_* calls should not compile at all for atmega 328P (not PB which has 2 usarts).
If you disable -Werror linker should complain about unresolved symbols.
On 328P both uart_* and uart0_* namings are valid.

@jnk0le I hoped/thought that I could define multiple software UARTs for the atmega 328P, like arduino software serial that I am trying to phase out.
I am fairly new to atmega development, so it seems that I just exposed my ignorance ;)
I would really appreciate if you have any pointers to doing that, as my google fu has been insufficient the last couple of hours.
Thanks, and feel free to close this issue

At the moment I'm only bug fixing and unweirdening this lib.
Even if I meka a soft library it will be completely separated from this one.


IPython Tab Completion causes logged warnings

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below):  .1.15.0 (git version v1.15.0-rc3-22-g590d6ee, 1.15.0)
Python version: 3.6.6

Describe the current behavior
Tab-completions in IPython spam the console with The name ___ is deprecated logging warnings.
Code to reproduce the issue
I am using Python 3.6.6 with IPython 7.8.0. If you do:
$ ipython
imporPython 3.6.6 | packaged by conda-forge | (default, Oct 12 2018, 14:43:46)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.8.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import tensorflow as tf

In [2]: tf.

and press tab after the ., you get dozens of warnings like:
WARNING:tensorflow:From /opt/anaconda/envs/ctrldev/lib/python3.6/site-packages/jedi/evaluate/compiled/access.py:347: The name tf.parse_example is deprecated. Please use tf.io.parse_example instead.

WARNING:tensorflow:From /opt/anaconda/envs/ctrldev/lib/python3.6/site-packages/jedi/evaluate/compiled/access.py:347: The name tf.parse_single_example is deprecated. Please use tf.io.parse_single_example instead.

WARNING:tensorflow:From /opt/anaconda/envs/ctrldev/lib/python3.6/site-packages/jedi/evaluate/compiled/access.py:347: The name tf.parse_single_sequence_example is deprecated. Please use tf.io.parse_single_sequence_example instead.

WARNING:tensorflow:From /opt/anaconda/envs/ctrldev/lib/python3.6/site-packages/jedi/evaluate/compiled/access.py:347: The name tf.parse_tensor is deprecated. Please use tf.io.parse_tensor instead.

You can actually reproduce this with the docker images, although that produces fewer deprecation warnings than the released package does:
$ docker run -it tensorflow/tensorflow:1.15.0rc1-py3-jupyter ipython
Python 3.6.8 (default, Aug 20 2019, 17:12:48)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.8.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import tensorflow as tf
tf.
In [2]: tf.WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/jedi/evaluate/compiled/access.py:347: The name tf.AUTO_REUSE is deprecated. Please use tf.compat.v1.AUTO_REUSE instead.

(Unfortunately, I wasn't able to find a more up-to-date official docker image).

@alanhdu,
I tried to replicate the issue on Ipython IDE 7.8.0. But it worked as expected.
Please look at the screenshot below.

I could reproduce the issue on Ipython with Tf 1.15.0. Thanks!

Yes -- this is a TF 1.15.0 problem. We have a pretty large Tensorflow 1 codebase, so a migration to TensorFlow 2 will take some time and isn't currently feasible.

This can help you suppress the deprecation warning messages;
from tensorflow.python.util import deprecation
deprecation._PRINT_DEPRECATION_WARNINGS = False

@ymodak: Is there a reason this issue got closed? You posted a work-around, but AFAICT the issue still exists.

This seems related to the way deprecation warnings are printed. Unfortunately, I don't think we have a quick fix to this.
One idea for a workaround would be to try to evaluate len(tf.__dict__) but I'm not sure this will hide all deprecation warnings.

The other option is to start by following the code in
https://github.com/tensorflow/tensorflow/issues/35550#issuecomment-570661108

Hi @mihaimaruseac . Coming from that different issue. I recently upgraded to TensorFlow 2.1 and am now having a slightly different (but still related issue).
Looks like in 2.1, all those deprecation errors are gone, which is awesome! Unfortunately, what happens now is:

I get a few errors of the line of

import tensorflow.2020-03-13 16:17:02.351299: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer.so.6'; dlerror: libnvinfer.so.6: cannot open shared object file: No such file or directory
2020-03-13 16:17:02.352383: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'libnvinfer_plugin.so.6'; dlerror: libnvinfer_plugin.so.6: cannot open shared object file: No such file or directory
2020-03-13 16:17:02.352454: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:30] Cannot dlopen some TensorRT libraries. If you would like to use Nvidia GPU with TensorRT, please make sure the missing libraries mentioned above are installed properly.

At this point, my IPython session either hangs, or actually let's me interact with the top level directory and choose something (albeit after all the warning messages). Having trouble replicating the first; I think I must have CTRL+C'ed or something during the warning dump.
Assuming I was able to keep control of the IPython session. I can now exit out...but now I see a new error that I've never seen before:

Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/home/cheinich/anaconda3/lib/python3.7/logging/__init__.py", line 2034, in shutdown
    h.close()
  File "/home/cheinich/anaconda3/lib/python3.7/site-packages/absl/logging/__init__.py", line 864, in close
    self.stream.close()
AttributeError: 'StdoutProxy' object has no attribute 'close'

So long story short, looks like things are improved...but I'm not sure what's causing the new issues.

For 1, there's nothing to worry about. They are just warnings and tell you that GPU couldn't be found so it won't be used.
2 and 3 look more like IPython issues than TF, but we can look at them sometimes.

Thanks for the response. I would argue that it's still a bug because I don't expect to see any messages at all...since I haven't done anything other than try to tab complete!
Plus, to be frank, I don't need the messages telling me it can't use the GPU. I know it won't use the GPU because I installed the CPU version of TensorFlow! I get the need to let users know, but I'd much rather look up the information in some config file when I need it (or global variable, or whatever makes sense), rather than have it given to me every time TensorFlow is imported.

As for the other, my first thought honestly was that it was my IPython terminal, not TensorFlow...but I tried it with a few other libraries (pandas, numpy) and didn't see it show up. It might still be my IPython, but appreciate you looking into it!

If you only want the CPU version of TensorFlow, you have to install tensorflow_cpu. tensorflow is a combined package which contains both CPU and GPU

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Broken Link

The link at the bottom of the page is broken Using the kit: Report your issue here <>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca7cc938-0b2d-7c1e-27d3-2681a3c7f058
Version Independent ID: ca7cc938-0b2d-7c1e-27d3-2681a3c7f058
Content: Microsoft Power Platform Automation CoE starter kit (preview) - Power Platform
Content Source: power-platform/guidance/automation-coe/automation-coe-starter-kit.md
Service: power-platform
Sub-service: guidance
GitHub Login: @kathyos
Microsoft Alias: kathyos

Thanks for your comment, @pab74. This issue has been assigned to the doc author for review.

Documentation is rewritten and the link provided now (aka.ms/automation-kit-issues) works. Apologies for late response.