Update sample application README ; corrections, v1.0 and one sample app focus

rather than installing all apps at once. show install of one.  Corrected some of the steps to achieve install and removed v0.6 steps as deprecated.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

this is to cover #77


add post-rewrite hook (called after git rebase)

I just copied PR #12, but this hook will run after git rebase.

Thanks! :+1: :grinning:

Published to npm: +<EMAIL_ADDRESS>


programmatically open a row?

I don't see any methods to do that, is it possible to programmatically open a row from the adapter?

Currently there is no direct way to do it. I will add this feature in the next version.

this would be a really cool feature, right now our app design requires something like that..

This can be easily done in ViewBinderHelper class. Does it help if I add a method called openRow(String id), which id is the unique id that identifies the data object?

that would be exactly what I was thinking about.

Check out the new version. I've implemented viewBinderHelper.openLayout(String id) and viewBinderHelper.closeLayout(String id).

I'm trying it but I don't understand what id I'm supposed to put in.
I tried this inside the adapter:
holder.plusBtn.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {
                        binderHelper.openLayout(""+v.getId());
                }
            });

but it doesn't work.

I tried the convertView.getId(), the item.getId() ... but apparently nothing happens. Wouldn't it better to pass the index of the row? so it's kind of standard

It's the same id when you use viewBinderHelper.bind(String id).  It's the unique id which identifies the data object that you binds to the view. ViewBinderHelper doesn't store row index, because it may change when the user removes or adds new row. You can implement open/close row position like this:
    public void removeRow(int position) {
        if (dataSet != null && 0 <= position && position < dataSet.size()) {
              YourDataObject dataObject = dataSet.get(position);
               viewBinderHelper.openLayout(dataObject.getId());
        }
}

It's up to you to define the id of the dataObject.

great stuff! thanks for your quick response!


Row Selected/NotSelected Class

Is there any way to have an active row class for the selected rows?
What I want to achieve is mainly having a different row color for the selected row elements.

Use selectedTo data variable and row-class prop.  I think someone has already asked about this, please search in the Issues, both open and closed ones.

I checked the opened/closed issues, unfortunately, there isn't really an exact solution mentioned in anyone.
Can the row-class prop be added only to the selected rows? How exactly can I modify a column's row-class prop?

I got the solution. As you said using row-class and the selectedTo prop

If this can help someone. (don't forget to add the id property to your data object!)
methods: {
  onRowClass(dataItem) {
    let selected = this.$refs.vuetable.selectedTo;
    let result = "c-contacts-index__row";

    if (selected.includes(dataItem.id)) {
      result += " c-contacts-index__row--active";
    }

    return result;
  }
}


[WIP] Automate Coverity analysis with Travis CI

Closing PR, due to branch_pattern problem
$ export PROJECT_NAME=ARMmbed/mbedtls -e:1: unknown regexp options - javka -e:1: syntax error, unexpected tINTEGER, expecting end-of-input ...velopment' =~ /\Adev/jainvikas8/travis-coverity\z/ ? 1 : 0 ...


Test with Python 3.13

Poetry 1.8.4 (via poetry-core 1.9.1) automatically adds the Python 3.13 trove classifier when using poetry build
https://github.com/bufbuild/protoc-gen-validate/issues/1173

I have read the CLA Document and I hereby sign the CLA


CI doesn't execute integration tests

In #5398, I was suprised to see CI succeed when I as expecting it to fail. Upon investigation, it looks like we use vitest's --changed to only run integration tests that import code that was changed in the PR.
The way our integration tests execute the CLI, a lot of the integration tests don't import these files though, and instead execute it in a subprocess via execa. This leads to tests being skipped, that shouldn't be skipped.
The obvious fix to this would be to not use --changed for integration tests, but i'm unsure if this might increase our CI time to an unbearable level.
Originally posted by @Skn0tt in https://github.com/netlify/cli/issues/5398#issuecomment-1385454759

cc @danez, it looks like you last worked with the --changed flag in https://github.com/netlify/cli/pull/5269.


how can i solve this problem?

python3 -m p4runtime_sh --grpc-addr <IP_ADDRESS>
CRITICAL:root:StreamChannel error, closing stream
CRITICAL:root:P4Runtime RPC error (UNAVAILABLE): failed to connect to all addresses
CRITICAL:root:Failed to establish session with server

As the last error message says "Failed to establish session with server", I would guess that the p4runtime_sh process attempted to open a TCP connection to the P4Runtime API server on the host with IPv4 address <IP_ADDRESS>, and something caused that connection attempt to fail.  Possible causes (but there are many more possibilities, which it would take experimentation and/or looking at your setup to determine which it might be):

There is no process listening on the default TCP port running on the host with IPv4 address <IP_ADDRESS> (the default TCP port for P4Runtime API servers to listen on, and for clients to connect to, is 9559)
There is such a listening process, but L2 switches, and/or IP routers between the host where you ran the p4runtime_sh command and the host where the process listening for incoming connections are not configured correct to forward IP packets between them, or a firewall is actively blocking these packets


Issue with remap_restarts.py, the catchment restart, and merra2 in older tags

Note I'm putting this here, bucause it's not 100% clear which constituent repo has the problem without a little more investigation
A user using v11.2.0 of the fixture, using remap_restarts.py reported a problem which I was able to replicate. He had regridded restarts from merra2. He was using said restarts for an experiment and the model was failing when it got to the catchment restart. I dig some digging, and tried to regrid my own set of restarts from merra2 with this version of the fixture and there is a problem.
The merra2 restarts are binary and each variable gets written to a record of the Fortran binary.
Using this code
/home/atrayano/bin/tell_rec you can see the number of records in a file.
The merra2 restarts in archive have 57 records in the catchment restarts
So one would expect an output file with probably 57 records. But when I regrid from merra2 to say c90, 360x180 data Ocean, using the "newland" here is what my catchment restart has:
catch_internal_rst.20180101_21z.nc4: Record 1: 294720034 words

one record, not 57! Something has just gone wrong.
Now it looks like remap_restart.py was changed and it now converts the restart to netcdf before regridding. I tried v11.4.0 of the fixture which is now producing netcdf restarts even from merra2, and the catchment restart you get is fine. The model is happy, it has the right number of variables.
So something is wrong with regridding the catchment restart when it is binary.
The question, is it worth doing anything, or just say if you want merra2, get a recent enough version of the model that you get the netcdf restarts even for merra2?
I leave it for others, just reporting what I see as if this user hit this, maybe others will

@weiyuan-jiang or @gmao-rreichle can chime in but I think we wanted to abandon binary catch version as far as support goes.  People can still use regrid.pl for those older model restarts.

@biljanaorescanin we do want to abandon binary, couldn't agree more. However, users are still using older tags with this bug. The simplest solution is to just tell users to use a new enough model version (The binary from netcdf came in in v11.3.3 of the GEOSgcm fixture) they will get a netcdf file from merra2. Even if this were fixed, it's not like Scott can change an older release tag anyway so not sure what can be realistically done. In newer tags this is just not an issue.
I made this more for reference in case other people hit this so we are aware.  I don't think that there's any real way to fix this that would get into a tag that would matter


Update import path for HuggingFace's randn_tensor

Fixes import https://github.com/huggingface/diffusers/issues/5025

What
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[ ] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable)

[PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
[Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
[Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
Recent benchmark results
Wasm size tracking

Thanks for the PR @hu-po!


Implement fastest pow() function base on the work of Harrison Ainsworth

With a precision table set to 11 bits (8KB table), mean error is < 0.01%, and max error is < 0.02%.
On my computer i7-2630QM @ 2.0GHz I observe the code running 11 times faster than the glibc pow().
This implementation is based on work of Harrison Ainsworth.
http://www.hxa.name/articles/content/fast-pow-adjustable_hxa7241_2007.html

make distcheck failed as mentioned in my patch there are error (less than 0.02 %)
Could you change the gold test to accept these margin errors of the test should pass even if the function is 11 times faster ?

@olajep Please change the golden data for now. Would like to see this function in there.

@olajep I updated the golden values and the reference test too.

Please sign off commits.

done

@aolofsson @olajep : Do you have any issue to merge this pull ?

@aolofsson
You're ok with that the mantissa table is 8192 bytes?
https://parallella.github.io/pal-stats/pr-153/codesize.arm.html


struct is not supported ("undefined: struct")

I was trying to load() paths.bzl from skylib:
$ go install go.starlark.net/cmd/starlark@latest
$ starlark paths.bzl
paths.bzl:309:9: undefined: struct

It's not part of the standard language, but you can easily add it to your application's set of predeclared symbols with this line:
       predeclared["struct"] = starlark.NewBuiltin("struct", starlarkstruct.Make)

That said, cmd/starlark includes time and json in its default set, so perhaps it should struct too for convenience.

Ah, thanks for that. I was trying to determine this before opening the issue, but I guess I didn't dig deep enough. Agreed that it would be a nice to have, though!


Error while selecting time

I got error while selecting minutes or hours..
bootstrap-datetimepicker.js:1061

Uncaught TypeError: widget.find is not a functionactions.showPicker @ bootstrap-datetimepicker.js:1061actions.selectMinute @ bootstrap-datetimepicker.js:1100doAction @ bootstrap-datetimepicker.js:1123jQuery.event.dispatch @ jquery.js:4430jQuery.event.add.elemData.handle @ jquery.js:4116

Please provide a jsfiddle of your issue. You can use this fiddle as a base.

I solved my problem. My own directive had action onblur which caused this error.

Hi Parismo
My time part is still a bit buggy, any idea why? It says widget.find() is not a function. Please find attached a widget. You said you had a problem with onblur. I do not have that. Any ideas?
http://jsfiddle.net/fbosler/516zsh7b/7/
Thanks again!

Hi Fbosler
Try this http://jsfiddle.net/d71m6nau/
changes when blur (click out of widget)


Changed decode to use UTF-8 and backslash notation

Changed decode to use UTF-8 and backslash notation for unknown characters.
Fixes #37
Might need some testing?

thanks for this :)


Set the Minimum OS version in XCProj

Set the Minimum OS version target in the Xcode project file to fix Carthage builds defaulting to only the latest OS sometimes

@ystrot @f3dm76 Just another small fix that would avoid some build issues I've seen.

Hey @benniebotha, thank you so much for your contribution, your PR is merged, have a great day!


[Feature Request]: Implementing Versatile Graph Theory Toolkit for Solving DSA Problems.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I propose developing a versatile graph theory toolkit designed to address a wide range of DSA problems. This toolkit would include implementations for fundamental graph algorithms such as depth-first search (DFS), breadth-first search (BFS), Dijkstra’s algorithm, Kruskal’s algorithm, and more. These tools will be packaged in an easy-to-use interface, allowing users to solve various DSA problems efficiently.
Use Case
This feature would enhance my use of the project by providing a comprehensive set of graph algorithms that can be applied to numerous DSA challenges. For example, in scenarios involving network connectivity, shortest path problems, and spanning trees, this toolkit would offer robust solutions, streamlining the problem-solving process.
Benefits
Implementing this versatile graph theory toolkit will provide comprehensive solutions to a wide range of DSA problems, enhancing efficiency by offering pre-implemented algorithms. It will serve as a valuable educational resource, helping users learn and understand graph algorithms.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Ajay-Dhangar sir, kindly assign me this issue under GSSOC'24


php artisan api:routes error on laravel 8

Q
A

Bug?
yes

New Feature?
no

Framework
Laravel

Framework version
8.12

Package version
3.0.5

PHP version
7.4.15

Actual Behaviour
i got error when use command php artisan api:route
Expected Behaviour
it must show route api list

me too.
Framework version 8.28.0

v8.28.0
Fixed
Fix undefined property with sole query (#36216)
Resolving non-instantiables corrupts Container::$with (#36212)
Fix attribute nesting on anonymous components (#36240)
Ensure $prefix is a string (#36254)
Add missing import (#34569)
Align PHP 8.1 behavior of e() (#36262)
Ensure null values won't break on PHP 8.1 (#36264)
Handle directive $value as a string (#36260)
Use explicit flag as default sorting (#36261)
Fix middleware group display (d9e28dc)

me too.

getting same error

me too

same here

The problem is a change done in this commit on https://github.com/laravel/framework
https://github.com/laravel/framework/commit/d9e28dcb1f4a5638b33829d919bd7417321ab39e

The issue is caused by the change done in this commit laravel/framework@d9e28dc

so how do we resolve this?

The issue is caused by the change done in this commit laravel/framework@d9e28dc

so how do we resolve this?

What I did was to add this code:
    /**
     * Flush the router's middleware groups.
     *
     * @return $this
     */
    public function flushMiddlewareGroups()
    {
        return $this;
    }

on the file vendor/dingo/api/src/Routing/Router.php to be able to run the api:routes command.

Thanks a lot, it fixed everything. Are you going to make a PR @gonpre?

Thanks a lot, it fixed everything. Are you going to make a PR @gonpre?

yes, I already did, hope this could be merged soon

Thanks a lot, it fixed everything. Are you going to make a PR @gonpre?

yes, I already did, hope this could be merged soon

i will close this issue when yout PR has been merged

Will this ever be merged?

Will this ever be merged?

no idea, meanwhile I changed my composer file to use my repo with the fix instead, maybe this will help you too
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/gonpre/api"
        }
    ],
    "require": {
        "dingo/api": "dev-bugfix/1770_api_routes_error_laravel_8",

Will this ever be merged?

https://github.com/dingo/api/pull/1771#issuecomment-811459676 refer to this, maybe no

Same issue here.

Hey guys, this fix is merged and tagged, thanks for your patience.
https://github.com/dingo/api/releases/tag/v3.0.6


Fix docs for /tenant/logout endpoint

It tells that accessToken required in request body but it actually needs token

Request body here incorrect too


jsmpp documenation

Hi,
Can you please create documentation for all classes available in jsmpp.jar
Our life will become easy, we can refer online  documentation for Classes available in jar

Good point. Together with the SMPP 5 additions I want to make I will do some cleanup and add the JavaDoc.


Fix: audit log part for response body for JSON format to be E

Fix for issue-2066.

Merged! Thanks!


left TOC scrollbar position lost on transition

What version of starlight are you using?
0.22.2
What version of astro are you using?
4.8.2
What package manager are you using?
yarn
What operating system are you using?
windows,linux,macos
What browser are you using?
edge
Describe the Bug
It would be great of if the left TOC could scroll the selected page item into view. Currently, it resets the scroll position so, if the TOC is long enough, the select page item is hidden after a transition.
Link to Minimal Reproducible Example
https://microsoft.github.io/genaiscript/reference/cli/
Participation

[ ] I am willing to submit a pull request for this issue.

Thanks for your feedback :raised_hands:
This is indeed something that has been heavily discussed in this thread, which also contains a few existing solutions/workarounds for it. The feature is also being worked in this PR at the moment.
I'm going to close this issue as a duplicate of the existing discussion, but feel free to comment there if you have any questions or suggestions.

Thank you for the quick answer!


Code Base Restructuring

Check List
Resolves: #95

[ ] I added tests for the changed code.
[ ] I updated the documentation for the changed code.
[ ] I ran the full tox test suite locally, so the CI pipelines should be green.
[ ] I added the change to the History section on the README.

This is a full restructuring and rework of rstcheck as a library. The CLI API should stay the same but small tweaks may be possible.

Update: Main functionality is restored, but need further tests and some improvements. Tests are written next. CLI is missing.

Update: Tests for CLI and checker module are missing. And some further improvements of the code.

ToDos

fix skipif for "Requires python3.9 or lower" to run on <=3.9 and not <=3.8
fix e.g. tests/test_checker.py::TestSourceChecker::test_code_block_lint_error_on_set_ignore_not_ignored_pre310
behavior changed to let code block errors be ignorable by ignore_messages .. tests need to be updated
investigate macos errors in all versions

FAILED tests/integration_tests/test_cli.py::TestWithConfigFile::test_file_1_is_bad_without_config
finds 7 errors instead of 6
FAILED tests/integration_tests/test_cli.py::TestWithoutConfigFile::test_error_without_config_file
finds 7 errors instead of 6


Reading Si446x PART_INFO not working

When powering up the Si446x the first time, for some reason reading the PART_INFO register gives back 0x00. Not sure what causes this, is a minor bug but still needs to be fixed.

It seems to have something to do with the fact that the first command after POR never seems to have an effect. Sending NOP command before doing anything else seems to work.


Explain how to activate ImageAutomationPolicy

As a Flux 1 user, we did not have these abstractions, and no comments were needed.
This is better!
I was aware of neither kyaml nor any other approach to comment templating on Kubernetes,
This paragraph would have helped me, and I think it can help others.

This is a good change, IMHO - except that ImageAutomationPolicy is a new string that doesn't precisely refer to one thing, rather mixes a few concrete ideas. Either ImageUpdateAutomation or ImagePolicy are concrete things that are in the API, perhaps just saying "Image Automation Policy" without the quotes/pre-formatting would be an improvement?

I will review verbiage to prevent confusion!


Outline view

Is support for the outline view on the roadmap?
Thanks for the awesome extension

Now supported through https://github.com/grafana/jsonnet-language-server/releases/tag/v0.9.0


Blacklist artist "Trance Classics"

https://open.spotify.com/artist/5ZDwdxvPhW0lNrf1SSsUB6
All these guys seems to do is redo classic trance songs but they don't credit the original artist throwing a wrench in our tagging system which is meant to prevent the "nearest" song from being an endless series of remixes of the same track.

I should make a "Blacklist Artist" which the job reads from which checks primary artist instead of track ID for exclusion (similar to my Blacklist playlist for tracks).


chore: apply whitespace fixes to component assets

Description
This PR applies whitespace, logical property rename, and opacity conversions to all provided assets. The eslint changes applied include newlines after curly braces and converting single to double quotes in *.js files.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps

[ ] Expect to see no VRT regressions.

Regression testing
Validate:

The documentation pages for at least two other components are still loading, including:

[ ] The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

[ ] VRTs have been run and looked at.
[ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

[x] I have read the contribution guidelines.
[ ] I have updated relevant storybook stories and templates.
[ ] I have tested these changes in Windows High Contrast mode.
[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[x] ✨ This pull request is ready to merge. ✨

@castastrophe the storybook build was failing here due to a wonky import for a react hook, after our move to SB8. I pushed up a fix for this.


Feature/engi 228

Updated tab styles:
Tabs

Pills

I think the changes in this PR are good. Just need to resolve the stuff from the other PRs

Realized that the nav/tab changes were living on another branch and was never pushed. Included said changes as well as implemented given feedback.


Faster Gaussian features

I've made some changes to improve performance and reduce memory use during Gaussian feature extraction.

Approx. half memory footprint of get_gauss_feat_multi, as features are copied directly into imfeats thereby avoiding intermediate list.
2-5 times faster feature extraction, depending on desired floating point type (float32 or float64). float32 is now default.

Reduced number of calls to filter2D from 30 to 20 by storing intermediate values.
Faster operations by using more optimal array layout (values are ordered differently).

This code is also relevant for the insegtpy, see https://github.com/vedranaa/insegtpy/blob/main/insegtpy/models/gaussfeat.py.
Also, bump...


feat(bindings/ocaml): support layer

Introduced layer in OCaml binding.

Thanks for the PR, but bindings should not expose layers AS-IS. Instead, they should provide their own wrapper.
Some layers could be enabled by default like retry and blocking.

It is easy to add retry to the layer enabled by default, but I'm sorry I don't fully understand what wrapper you are referring to.

but I'm sorry I don't fully understand what wrapper you are referring to.

My general idea is that we should not expose rust layers to ocaml side directly. Instead, we should implement something called OcamlLayer in which we will call ocaml code. So users can integrate with ocaml's native logging/metrics/tracing libs.
The call path will be like:
ocaml: op.read()
|
v
rust: call inner rust code
|
v
rust: call ocaml layer
|
V
ocaml：call users provided layer implement (like https://github.com/dbuenzli/logs)
|
v
rust: return value to ocaml binding
|
v
ocaml: return value to user

but I'm sorry I don't fully understand what wrapper you are referring to.

My general idea is that we should not expose rust layers to ocaml side directly. Instead, we should implement something called OcamlLayer in which we will call ocaml code. So users can integrate with ocaml's native logging/metrics/tracing libs.
 This may require implementing a layer for ffi callback in rust.

It is not a simple matter to implement such a universal OCaml layer.

Yes, I'm quite hesitant about adding this in OCaml. How about finishing the release and gaining our first user? We can improve the ocaml binding based on real users feedback.

It is not a simple matter to implement such a universal OCaml layer.

Yes, I'm quite hesitant about adding this in OCaml. How about finishing the release and gaining our first user? We can improve the ocaml binding based on real users feedback.

Okay, let's put aside the layer and solve the release problem first.

Okay, let's put aside the layer and solve the release problem first.

Thanks a lot!


ParentSize disableHieght disableWidth

Often children interested only in one of dimensions or positions, so its handy to limit redraw events with dome flags so redraw not fired if disableHieght = true and parent changed height only

Hi @Zaitsev, great idea. Will look to add this in a future release.

would happily review a PR for this 👀


It should be possible to configure key server and home did for rvm gpg_key

I'm using vagrant with the newest Ubuntu (ubuntu/trusty64) and I have an issue with hkp://keys.gnupg.net being blocked by firewall. I would like to be able to configure key server in my cookbook.
Also there is an issue if you run cookbook as vagrant user - signature is saved in the /home/vagrant/.gnupg directory and when later you try install rvm::system cookbook tries to find signature in /root/.gnupg so installation fails. It would be great to be able to configure both key server and home dir then.
Actually I've already did that and I'll make pull request in a minute, I just wanted to be consistent and add issue too.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


check_psf_peak of ska-gridder-nifty-cuda does not fail the assertion.

As mentioned in #183, the ska-gridder-nifty-cuda predict_wg fails with the following error:
Traceback (most recent call last):
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/cProfile.py", line 190, in <module>
    main()
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/cProfile.py", line 179, in main
    runctx(code, globs, None, options.outfile, options.sort)
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/cProfile.py", line 19, in runctx
    return _pyprofile._Utils(Profile).runctx(statement, globals, locals,
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/profile.py", line 62, in runctx
    prof.runctx(statement, globals, locals)
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/cProfile.py", line 100, in runctx
    exec(cmd, globals, locals)
  File "time_execution.py", line 74, in <module>
    test_create_detection_from_ms()
  File "time_execution.py", line 60, in test_create_detection_from_ms
    convolved, restored, residual = imager.imaging_rascil(
  File "/home/vincenzo/Karabo-Pipeline/karabo/imaging/imager.py", line 240, in imaging_rascil
    result = continuum_imaging_skymodel_list_rsexecute_workflow(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/pipelines/pipeline_skymodel_rsexecute.py", line 392, in continuum_imaging_skymodel_list_rsexecute_workflow
    ) = ical_skymodel_list_rsexecute_workflow(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/pipelines/pipeline_skymodel_rsexecute.py", line 154, in ical_skymodel_list_rsexecute_workflow
    skymodel_list = deconvolve_skymodel_list_rsexecute_workflow(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/skymodel/skymodel_rsexecute.py", line 396, in deconvolve_skymodel_list_rsexecute_workflow
    deconvolve_model_imagelist = deconvolve_list_rsexecute_workflow(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/imaging/imaging_rsexecute.py", line 510, in deconvolve_list_rsexecute_workflow
    return deconvolve_list_singlefacet_rsexecute_workflow(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/imaging/imaging_rsexecute.py", line 457, in deconvolve_list_singlefacet_rsexecute_workflow
    clean_list = rsexecute.execute(imaging_deconvolve, nout=len(dirty_list))(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/workflows/rsexecute/imaging/imaging_rsexecute.py", line 446, in imaging_deconvolve
    comp, _ = deconvolve_list(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/processing_components/image/deconvolution.py", line 128, in deconvolve_list
    check_psf_peak(psf_list)
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/rascil/processing_components/image/deconvolution.py", line 170, in check_psf_peak
    numpy.testing.assert_approx_equal(
  File "/home/vincenzo/miniconda3/envs/karabo_dev_env_rascil_7/lib/python3.9/site-packages/numpy/testing/_private/utils.py", line 698, in assert_approx_equal
    raise AssertionError(msg)
AssertionError:
Items are not equal to 6 significant digits:
check_psf_peak: PSF 0 does not have unit peak 0.9996356147582426
 ACTUAL: 0.9996356147582426
 DESIRED: 1.0

The function which raises the assertion error is the following:
def check_psf_peak(psf_list):
    """Check that all PSFs in a list have unit peak

    :param psf_list: List of PSF images
    """
    for ipsf, psf in enumerate(psf_list):
        pmax = psf["pixels"].data.max()
        numpy.testing.assert_approx_equal(
            pmax,
            1.0,
            err_msg=f"check_psf_peak: PSF {ipsf} does not have unit peak {pmax}",
            significant=6,
        )

Every other test of ska-gridder-nifty-cuda or rascils succeeds, so I want to be sure that we use the ska-gridder-nifty-cuda correctly

In the newest version of Rascil, the test is not located in the SKA SDP: https://gitlab.com/ska-telescope/sdp/ska-sdp-func-python/-/blob/main/src/ska_sdp_func_python/image/deconvolution.py
I will move my issue there.

@deiruch How important do you think this is? Basically, GPU acceleration does not work in Rascil currently. I can fix it directly in the ska-spd-func.

Removing the assertion is the wrong way. The gridder does not work - we track that in the  issue #349 and #360


Discarding the master-slave language

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

@sushilks  Travis is probably broken. Could you force merge it pls. Thanks.


V2

Add trailing slash to 'homepage' in component.json

Why did you create this PR? Normalize is currently at v8. This is not wanted.


Failed to enable cloudshell addon with latest version(0.0.8) for kubevela 1.8

Describe the bug
Failed to pull image "hub.kubevela.net/oamdev/cloudshell-operator:v0.3.0": rpc error: code = Unknown desc = failed to pull and unpack image "hub.kubevela.net/oamdev/cloudshell-operator:v0.3.0": failed to resolve reference "hub.kubevela.net/oamdev/cloudshell-operator:v0.3.0": failed to do request: Head "https://hub.kubevela.net/v2/oamdev/cloudshell-operator/manifests/v0.3.0": x509: certificate has expired or is not yet valid: current time 2023-06-13T13:19:25+08:00 is after 2023-05-24T23:59:59Z
To Reproduce
Steps to reproduce the behavior:

VelaUX / 平台扩展
搜索 cloudshell 然后 enable
大约十分钟后依然在“workflowRunning”
查看pod实例状态，可以看到上述错误信息

Screenshots

KubeVela Version
1.8
Cluster information
1.25.6

Hi, this is a known issue for hub.kubevela.net as mentioned here https://github.com/kubevela/kubevela/issues/6061.
You can change the registry to docker.io to solve that. Or try to use the latest cloudshell addon.

/duplicated #6061

Hi, this is a known issue for hub.kubevela.net as mentioned here #6061.
You can change the registry to docker.io to solve that. Or try to use the latest cloudshell addon.

how to specify the newer version (0.0.9?) or registry from VelaUX ?

You can try to run vela addon enable cloudshell in your command line. I guess the UI has not been fully synced.

You can try to run vela addon enable cloudshell in your command line. I guess the UI has not been fully synced.

I tried but not work, it still leverage the 0.0.8 version but not the fixed new one. May (and how) I specify the desired version (0.0.9) via cli or pass the image registry arguments ?

The "cloudshell" addon is poorly designed and not expose parameters for now. So I guess you have to either manually edit the addon application and rewrite the image field, or you can use the 0.0.9 version.
You can run vela addon registry update KubeVela --type helm --endpoint=https://kubevela.io/catalog/official and enable it again. I guess it is because the old registry is outdated.

The "cloudshell" addon is poorly designed and not expose parameters for now. So I guess you have to either manually edit the addon application and rewrite the image field, or you can use the 0.0.9 version.
You can run vela addon registry update KubeVela --type helm --endpoint=https://kubevela.io/catalog/official and enable it again. I guess it is because the old registry is outdated.

Neither works. To be specified, even no addon cloud be found via "vela addon list" after do that.
While yesterday evening I went back to enable the latest version (0.0.8) from VelaUX and then modify the image registry via UX as below, but nothing changes until now.

To be specified, even no addon cloud be found via "vela addon list" after do that.

Are you accessing it from mainland China? If so, it could be a network problem as the "kubevela.io" is served behind GitHub which could be probably blocked. You can try to use a proxy and retry.

If you edit the addon-cloudshell manually, remember to actually "Deploy" it. On VelaUX, you have to click the "Deploy" button to make it take effect. If you go with the CLI, the addon applications have a "publishVersion" annotation and you need to update this field (to any value other than the current one) to make the change take effect.

In fact, the "Deploy" button is gray and not clickable on VelaUX, any idea ?

 In fact, the "Deploy" button is gray and not clickable on VelaUX, any idea ?

Hmm, I think it is because this application is deployed through addon so it is forbidden to deploy it manually. Well, I think you can try to use the CLI which should not have any restrictions. You can run vela up addon-cloudshell -n vela-system --publish-version <any version name you would like to use>.


Psy3

Closes several issues related to HVDC and some parsing issues.
closes #999
closes #944
Tests are expected to fail

Current status


Tools: add extract data tool for calibration, just a proto type for now

Is this for vehicle calibration or perception calibration? Better to rename the folder to be more clear :)

@freeHackOfJeff  this is the sensor calibration. Create a new directory under modules/tools/ for this tool.

Yep, also the current folder can be re-name to VehicleCalibration to be more precise, @freeHackOfJeff

BTW, C++ is much preferred and easier to maintain in the long run. Python tools are not protected by CI or unit tests.

@jinghaomiao @xiaoxq @Capri2014 thanks for all your comments. Yep, Jinghao has already renamed calibration to vehicle_calibration, I'll add another sensor_calibration to indicate the purpose,. For now, let's keep the current input arguments simple, we can refactor or add other arguments according to the design and requirements in future.
@xiaoxq we has discussed that to supply a Python version currently.  In the long run, maybe we would have a C++ version. :)

ACK. Thanks!

@freeHackOfJeff  Please make the change to your pull request and resubmit it.

Close the current PR, use the new ticket to follow up.


feat: add static_openssl feature for linking OpenSSL statically

When the static_openssl feature is enabled, binaries that use this crate will contain a copy of OpenSSL statically linked, instead of depending on the OpenSSL being installed in the system.

The 0.4.0 release has been published with this new feature flag.


update with missing icons from slp-token-icons, resized incorrect sizes

Updated with missing icons from the hosted slp-token-icon repository, and resized images that were incorrectly sized by their original authors.

Thanks @kosinusbch! I appreciate your work 🎩


Keyring naming from server's returning content-disposition: foo.pub like artifactory

When using server like artifactory, that maintains the .rsa.pub keys on URL like:
https://artifactoryHostFoo/artifactory/api/security/keypair/public/repositories/development-alpine-virtual

We cannot use such keys using rules_apko, at the resolved path is not *.pub.
The URL returns:
< HTTP/2 200
< content-disposition: attachment; filename=alpine.rsa.pub
< content-type: application/jso

but it's too late in bazel's processing phases to interpret.
The download stores as the URL path:
https://github.com/chainguard-dev/rules_apko/blob/1ca116a155e82fac815b34a1316b036f1fdce278/apko/private/apk.bzl#L149-L152
So https://github.com/chainguard-dev/rules_apko/blob/1ca116a155e82fac815b34a1316b036f1fdce278/apko/private/apk.bzl#L127-L130 does not matches it with *.pub:
Solutions to consider:

Pass the downloaded file explicitly to APK_KEYRING_TMPL to avoid *.pub resolution.

State that downloading *.pub keys from the internet (likely from the same server as artifacts is not safe), as compromised server could serve both: compromised pub key and artifacts...
(it's not that bad as resolved json file contains the checksums of the files - including the pub.key - but it's easy to overlook).
But if that's the recommendation, we should add explicit support for "keyrings" attribute in the apko_image rule.

This is now DONE.


A few errors

Permissions are set for read and write access to everyone. Running Ubuntu 22.04. Same errors on both Snap and Flatpak
   at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirError)
   at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, UnixFileMode openPermissions, Int64& fileLength, UnixFileMode& filePermissions, Func`4 createOpenException)
   at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
   at ATL.AudioData.AudioDataManager.UpdateTagInFile(TagData theTag, TagType tagType, ProgressManager writeProgress)
Inner Exception BEGIN
Permission denied

Error 2
(NickvisionTagger.GNOME:1670913): Gtk-CRITICAL **: 14:10:26.134: Allocation height too small. Tried to allocate 99x46, but GtkBox 0x557430d3ed50 needs at least 99x47.
Error 3
(NickvisionTagger.GNOME:1670913): Gtk-WARNING **: 14:11:50.446: Failed to set text 'Unable to save file.mp3' from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity — escape ampersand as &

Thanks for the report, could you please provide a file that caused the first error? We will try to investigate what causes the problem.

Are the files outside of home directory? Network drive, USB, or something like that? Unusual filesystem maybe?

With flatpak, could you try giving the app access to the required folder, and if it doesn't work give it full filesystem access? You can do that with Flatseal


Merge master branch to prTesting1_202004271927 branch

Docs Build status updates of commit 5cfbe11:
:clock10: Pending: waiting for processors (11 builds ahead of you)
:warning: Docs Build is busy, currently there are 11 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 5cfbe11:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon1.md
:warning:Warning

Details

split/updateTestCon1.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 0: [Warning] Markdown content is not allowed before H1.
Line 1: [Suggestion] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning on 04/01/2020.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


surge-xt: fix shifting hash

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This builds and runs fine for me, just could you please change the name of the commit to something like surge-xt: fix shifting hash, as we expect commit names to start with the name of the program they are changing? (needed for instance by bots as far as I know)

Thanks, done.


[Bug] Graph optimization bug

Description
The recent merged https://github.com/apache/incubator-mxnet/pull/18690 has broken the CI of GluonNLP. The tests that are related to relative positional embedding which contains the unique operator. See https://github.com/dmlc/gluon-nlp/pull/1432/checks?check_run_id=1391543133 for the error message.
Need some help in investigating the issue.
@mseth10 @sandeep-krishnamurthy @szha @leezu

Thanks for reporting the issue @sxjscience . This issue happens during training when the model is hybridized. It is a known bug #18823 with MXNet that we are currently working on. Meanwhile, what we can do is disable the graph partitioning by default. Will create a PR shortly.

keeping this open for now to make sure the case is tested when actual fix is added.

@szha Would it be a 2.0-release issue?

Fixed by #19614


The route parsing behavior of redirect in configuration is different from push() method

Version
3.0.1
Reproduction link
https://jsbin.com/cikacabasa/1/edit?html,js,output
Steps to reproduce
click the link: /redirect.
What is expected?
show id: 222, like using push() method.
What is actually happening?
show id: default id.
the params property in prototype has been ignored.

The location you redirect to should be a plain object:
let loc = {name: 'target', params: {id: 222}};

@posva
But why can the push() method accept params from prototype?
I think the behavior of parsing location should be consistent.

It's just a coincidence but it was not meant to be used like that


Server container on multiple overlay networks and routing client packets

Dear Community and Owner,
This piece of image has been a great asset to our tooling in recent months. We have been using it at least on 5 deployments. Easy to configure, deploy and use.
However in our latest deployment as an OVPN client we would like to:

Access several Docker Overlay networks at once;
Use Docker embedded DNS on each network to resolve containers by name.

Our current server container is deployed to a system  network. Current networks defined are:
NETWORK ID          NAME                DRIVER              SCOPE
aa6eb2a61e12        bridge              bridge              local
nzfc85vuzmn7        development         overlay             swarm
5c05f6707db2        docker_gwbridge     bridge              local
zhxqi5qtif9t        experiment          overlay             swarm
7e0400d4e510        host                host                local
ct1yvji5mikp        ingress             overlay             swarm
82724fdfb0ec        none                null                local
30o2rm16vt56        production          overlay             swarm
qz5r53r7eb7j        system              overlay             swarm

The client uses the same DNS server that Docker provides to the OVPN server on the system network, so every container is accessible by a connected client by name on the system net. Of course, for that the
system network's subnet's traffic is routed through the OVPN gateway on the client side; and there is also a DNS entry in the ovpn configuration.
route <IP_ADDRESS> <IP_ADDRESS>
route <IP_ADDRESS> <IP_ADDRESS>
route <IP_ADDRESS> <IP_ADDRESS>
route <IP_ADDRESS> <IP_ADDRESS>

dhcp-option DNS <IP_ADDRESS>

We would like to achieve the same name resolving and access from each client to other networks' containers, for example containers from development or production network.
When the server container is attached to another network, within the container the new network appears on another interface (eth2, eth3, ...).
default         <IP_ADDRESS>      <IP_ADDRESS>         UG    0      0        0 eth1
<IP_ADDRESS>      *               <IP_ADDRESS>     U     0      0        0 eth1
<IP_ADDRESS>     *               <IP_ADDRESS>     U     0      0        0 eth2 // development network
<IP_ADDRESS>     *               <IP_ADDRESS>     U     0      0        0 eth0 // system network
<IP_ADDRESS>   <IP_ADDRESS>   <IP_ADDRESS>   UG    0      0        0 tun0
<IP_ADDRESS>   <IP_ADDRESS>   <IP_ADDRESS>   UG    0      0        0 tun0
<IP_ADDRESS>   *               <IP_ADDRESS> UH    0      0        0 tun0

However, in this setting, packets from client can not reach the development network. If the server container is restarted, packets can not reach the system network, but can reach the development network.
Has anyone tried a setup like this? How one could refine routes or interfaces in this containerized OVPN server to have correct routing to different networks attached to different interfaces?
Thanks for the help!
Cheers,
Zoltán

I have the same setup and trying to find a solution. One solution is to enable NAT on the docker-openvpn container. This works but is not the ideal solution.
I think the host  where docker is running does not know how to route back the packets from the openvpn IPs. If I set static routes "ip route add VPNSUBNET via VPNServerIP" where VPNServerIP is in your development network, then it is possible to reach all hosts from the development network as a VPN client.
If I use the VPNServerIP from the system network then I can reach all system network clients.
I have not found a solution to reach both networks.
So imho this is a routing issue.

I have enabled NAT and it works fine so far for my use cases.
A guide would indeed be nice on how to fix the routing.
On 2018-02-17 23:12:38, Erhan<EMAIL_ADDRESS>wrote:
I have the same setup and trying to find a solution. One solution is to enable NAT on the docker-openvpn container. This works but is not the ideal solution.
I think the host where docker is running does not know how to route back the packets from the openvpn IPs. If I set static routes "ip route add VPNSUBNET via VPNServerIP" where VPNServerIP is in your development network, then it is possible to reach all hosts from the development network as a VPN client.
If I use the VPNServerIP from the system network then I can reach all system network clients.
I have not found a solution to reach both networks.
So imho this is a routing issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/kylemanna/docker-openvpn/issues/336#issuecomment-366475228], or mute the thread [https://github.com/notifications/unsubscribe-auth/AH--TbtrDEoxu0xNZ4zNY5p4pvBQw9-cks5tV07VgaJpZM4Qyajn].

Yeah that's fine if you use your network alone but you won't know which VPN client connected to your various services. If you have logging enabled in any of your services, you will only see the VPN container IP as you are using NAT now.

I have similar issue - would like to enable routing for extra network used to assign static IP for dns server. As a workaround I followed the suggestion and provided custom setupIptablesAndRouting definition on ovpn_env.sh hardcoding MASQUERADE for extra network.
I think It could be enough though to accept OVPN_NATDEVICES to be a list of interfaces and loop through them in the starting script.

can you guys show how did you configure NAT on docker containers and did you configured the DNS on VPN Clients to point to <IP_ADDRESS> so you could access a service through its name instead of its IP address?

Wow after two years and searching a solution, I find my same problem again :D I am trying it again here:
https://github.com/kylemanna/docker-openvpn/issues/622


Elemental spell 50% conversion not working with Elemental Bloodline conversion

As above, while the 100% elemental conversion from the metamagic feat is overriding the elemental bloodline conversion (or being applied afterwards) the 50% conversion is not producing the expected 50% result.
Save game:
https://www.dropbox.com/s/hhnvekeo3zf6xn7/Quick_5.zks?dl=0
Mewsifer bug report:
https://www.dropbox.com/s/nlitntouelggi4s/b5ov17lg.mew?dl=0

Okay update to latest TTT and it should work
https://github.com/Vek17/TabletopTweaks-Base/releases/latest
https://github.com/Vek17/TabletopTweaks-Core/releases/latest
This should have been just addressed today.

Fantastic, working as expected!
On Sun, 12 Mar 2023, 5:06 am Sean Petrie, @.***> wrote:

Okay update to latest TTT and it should work
https://github.com/Vek17/TabletopTweaks-Base/releases/latest
https://github.com/Vek17/TabletopTweaks-Core/releases/latest
This should have been just addressed today.
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/588#issuecomment-1464986542,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4S52J2TA2ICUARPHCTR65DW3TEMNANCNFSM6AAAAAAVXMPGP4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Okay, not sure where this issue is coming from but Chain Lightning with
Zippy Magic is only affecting enemies once (every enemy should be struck
twice due to zippy magic but instead are only being struck once). Is that a
Tabletop Tweaks bug or a regular WotR bug?
On Sun, Mar 12, 2023 at 10:55 AM Aram Madigan @.***>
wrote:

Fantastic, working as expected!
On Sun, 12 Mar 2023, 5:06 am Sean Petrie, @.***>
wrote:

Okay update to latest TTT and it should work
https://github.com/Vek17/TabletopTweaks-Base/releases/latest
https://github.com/Vek17/TabletopTweaks-Core/releases/latest
This should have been just addressed today.
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/588#issuecomment-1464986542,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A4S52J2TA2ICUARPHCTR65DW3TEMNANCNFSM6AAAAAAVXMPGP4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Shouldn't be TTT, but I haven't tested this behavior in a while. Nothing
about how chain works should prevent it afaik.
On Sat, Mar 11, 2023, 21:57 CaptOcto @.***> wrote:

Okay, not sure where this issue is coming from but Chain Lightning with
Zippy Magic is only affecting enemies once (every enemy should be struck
twice due to zippy magic but instead are only being struck once). Is that a
Tabletop Tweaks bug or a regular WotR bug?
On Sun, Mar 12, 2023 at 10:55 AM Aram Madigan @.***>
wrote:

Fantastic, working as expected!
On Sun, 12 Mar 2023, 5:06 am Sean Petrie, @.***>
wrote:

Okay update to latest TTT and it should work
https://github.com/Vek17/TabletopTweaks-Base/releases/latest
https://github.com/Vek17/TabletopTweaks-Core/releases/latest
This should have been just addressed today.
—
Reply to this email directly, view it on GitHub
<
https://github.com/Vek17/TabletopTweaks-Base/issues/588#issuecomment-1464986542
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A4S52J2TA2ICUARPHCTR65DW3TEMNANCNFSM6AAAAAAVXMPGP4

.
You are receiving this because you authored the thread.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/588#issuecomment-1465085749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPBE5O5GDSHZSLX52HTW3VCSZANCNFSM6AAAAAAVXMPGP4
.
You are receiving this because you commented.Message ID:
@.***>

This works fine in my testing


Add CODEOWNERS file

this will auto-request a review from the @crate/docs team (but a review from the team is not mandatory)

@mkleen we have a few repos using this feature
I want to add this because I want the docs team to get notifications when documentation is updated
engineers often do not request a review from the docs team when making documentation changes. which means that errors can go unnoticed for quite some time.
requiring a docs team review on every PR is too much work. so this is sort of a middle-ground approach. it means we get a notification and can decide to weigh in if we want, but it's not required
this was the result of a conversation with @joemoe  about what to do to better enable oversight for our public-facing docs projects

retest this please


SMB/Samba client functionality does not work in Files.app

After performing the jailbreak the phone is unable to connect to Samba servers in Files.app anymore – seems to be related to https://github.com/checkra1n/BugTracker/issues/1467
When I try to connect to a server, Files app gets stuck on "Connect to Server". The issue disappears when I reboot the phone into a non-jailbroken state. Apart from that, this only happens on Odyssey, and I don't have this issue on unc0ver (Odyssey is more stable in general in my experience, so that's why I'm using it)
Device: iPhone XR
iOS Version: 13.5
Odyssey version: 1.2.2
Tell me if you need any other information or logs. Thanks in advance!

Fixed by updating to libhooker 1.3.1


IOptionsMonitor is singleton but listener registration is not thread safe

Bad things might happen if two consumers subscribe concurrently.
Also if subscription happens during invocation.
/cc @HaoK

Yuck, yup not threadsafe

Discussed with @ajcvickers will fix with either using a SynchronizedCollection or explicit locks

You can also use event internally it is already synchronized.

Good idea, this is pretty much the exact usage pattern for events...

ff4200632970c53a3a6c860219d10477d74060d6


Prepare registry doc for registry admin persona

With the restructure of the landing page (https://github.com/devfile/api/issues/441), we are going to provide docs for different persona. One of the targeted persona is the registry administrator who will be interested in the docs related to the devfile registry. This item is to start preparing the content that we can include as part of the registry administrator persona.
Here are the list of things that we can include:

Intro to devfile registry
Type of registries (community vs product vs private (custom/user-owned, on cluster)
Registry related schema (index.json, extraDevfileEntries.yaml, etc.)
Registry index, API (both REST and Go library) for registry access
How to provide your own registry (with tools integration, installing new and updating existing)?
Life cycle of registry
Security
Registry build + validation and registry source repo
OCI based registry structure with content structure

I am working on 3 and 4 in the list and will push my docs to John's temporary repo above.

Closing this one out since we delivered the temporary docs to https://github.com/johnmcollier/registry-docs/, and awaiting on doc review from the docs team (@jc-berger specifically)


build: Fix installing with the wrong prefix

When DESTDIR is specified and it doesn't exist, cp -R will not create
it, which will cause the first part of the prefix to be omitted.
For example, prefix=/usr/x86_64-pc-linux-gnu and DESTDIR=/tmp/soletta
will cause it to be installed on /tmp/soletta/x86_64-pc-linux-gnu, if
/tmp/soletta doesn't exist.
Signed-off-by: Vinicius Costa Gomes<EMAIL_ADDRESS>

I will make another PR shortly, with another path related fix. Closing this.


Fixed various issues and fixed clean up of temporary directories

Fixed various issues reported by SonarQube.
Used SonarQube to perform an analysis of gradle's source code to get an insight in possible issues and technical debt. This commit fixes various issues reported by SonarQube such as code duplication, performance issues and code readability.
Fixed clean up of temporary directories.
Gradle does not properly delete temporary directories.
This commit completes 2 todos:
subprojects\core\src\main\java\org\gradle\testfixtures\internal\ProjectBuilderImpl.java
// TODO deleteOnExit won't clean up non-empty directories (and it leaks memory for long-running processes).
subprojects\core\src\main\java\org\gradle\api\internal\file\DefaultTemporaryFileProvider.java
// TODO: This is not a great paradigm for creating a temporary directory.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

@jthols Could you please rebase your changes?

@jthols I'd also recommend splitting out the "delete on exit" changes since they're a change in behavior.  I took a quick look at the other changes and they seem non-controversial/fine.

@jthols I am sorry that we didn't around to review this PR earlier. Unfortunately, we can't merge it as is. Please submit a new PR if you are still interested in providing portions of the changes. Please separate non-critical changes from the "delete on exit" change as suggest. Thanks again and we hope you are willing to contribute again in the future.


Exam/#2/search form

First example of a visual component in Angular 4.x with Angular-cli for ngPuzzle

:+1:


Add ability to specify SMBIOS details in kubevirt-config

What this PR does / why we need it:
This PR adds functionality to mention cluster wide SMBios details in kubevirt-config, these details will further be taken into domain of the VMs
Details that can be mentioned are:- Family, Product, Manufacturer, Sku, Version
Example configMap
apiVersion: v1
data:
  feature-gates: DataVolumes, CPUManager, LiveMigration, ExperimentalIgnitionSupport,
    Sidecar
  smbios: '{"manufacturer":"None","product":"test","version":"1.0","sku":"1.0","family":"test"}'
kind: ConfigMap
metadata:
  creationTimestamp: 2019-08-21T06:54:55Z
  labels:
    kubevirt.io: ""

or smbios can also be mentioned like this
  smbios: |-
    manufacturer=None
    product=test
    version=2.0
    sku=1.0
    family=test

Release note:

Added ability to specify a cluster-wide SMBios details in kubevirt-config configMap, which will be taken into all VM domains
Details that can be mentioned are:- Family, Product, Manufacturer, Sku, Version

/cc @davidvossel @phoracek we need a backward compatible way to pass an additional context. Can you have a look?

we need a backward compatible way to pass an additional context. Can you have a look?

If I understand grpc/protobuf correct, just adding a new field to the VMIRequest message is easy to handle:

new client (handler), old server (launcher): server will just not read the new field, and works as before adding the new feature
old client, new server: the server needs to deal with the fact that the new field might be empty / have its default value. This needs to be done here [0]

See [1], 2nd bullet
[0] https://github.com/kubevirt/kubevirt/pull/2472/files#diff-5cb08b427cc4fd814e525c608650acaeR173
[1] https://developers.google.com/protocol-buffers/docs/proto3#updating

Can someone explain why these SMBIOS details don't belong on the VMI's spec? I'm okay with the cluster wide kubevirt-config options, it's just unclear why we're avoiding adding this information to the VMI directly.

We can add them to the VMI too if we want. Right now it is not needed there. The background is, that OS vendors (like microsoft) check the SMBIOS details to find out which manager is managing them (vmware, openstack, ovirt, ...). This allows them to install e.g. virtio drivers automatically on boot. I guess on the long run we will have applications which will require custom values there too. I would have no objections if it is configurable on the VMI too.

We can add them to the VMI too if we want. Right now it is not needed there.

If there's any chance it ever makes sense to add these options to the VMI, we need to do it now.
If we don't do it now, then we're going to be stuck with an awkward handler->launcher communication someday where SMBIOs info is passed in both on the VMI and potentially using extra args that we'll never be able to get rid of because of backwards compatibility.

/retest

Maybe worth checking what is wrong with the tests?

/retest

Please adjust the title and release note to mention which details can be provided.

/retest

@fabiand updated description now

/retest

nice!
/lgtm
/approve

/retest

/test pull-kubevirt-e2e-os-3.11.0-crio

/test pull-kubevirt-e2e-k8s-1.11.0

/test pull-kubevirt-e2e-k8s-1.11.0


Modify features to allow grouping rows

The grouping functionality is underway, thanks to @jpdesigndev.  Grouping will introduce grouping rows, which are not part of the core data set, but are visible in the grid and appear in grid.rows.
It is desirable to exclude these rows from some actions, particularly actions that some of the features implement, for example we might not want these rows to be editable, to be selectable, or to be exportable.
In order to implement this in a generic way it would be nice to allow each of these features to be suppressed for individual rows - so set a flag on a given row that says "don't do xyz".  The proposition is that we have a flag for each feature - so a flag on the row that says "enableSelection", another that says "enableFocus", another that says "enableEditing".  These are sort of like options on the columnDefs, but they're on rows instead.
At this stage the intention is for these to have internal use only - other features can set the flags, so in a sense they're part of the API set of a given feature, and able to be consumed by other features.  At a later date these flags might also be user settable - so if your data entity had an attribute of enableFocus: false then that row wouldn't be focusable.  That's for future discussion.
Also, a given feature that creates rows (such as grouping) might have gridOptions that control this behaviour.  So maybe by default grouping doesn't export the group rows.  But maybe you can set "groupingExportGroupRows: true" and it then allows export on those rows.  Again perhaps a future extension.
This issue is an umbrella to track that work as I implement it.  My current list of items to implement is:

cellNav.  @jpdesigndev has implemented the core logic, I need to extend with unit tests and some documentation: COMPLETE
edit.  An enableEditing flag, true by default.  You can't edit any cells in a row with this flag set to false. COMPLETE, but didn't work out a way to unit test as the flag is only settable in code, and that is hard with the current unit testing structure for this module (it assumes it can compile the grid element and then it works)
expandable.  Ignoring for now, don't think we need this at this stage
exporter.  exporterEnableExport, true by default.  When set to false we ignore that row in the export.  COMPLETE
importer.  Nothing needed
infinite-scroll.  Nothing needed
move-columns.  Nothing needed.
pagination/paging.  Nothing needed.
pinning.  Nothing needed
resize-columns.  Nothing needed.
row-edit.  Should work off edit - if you can't edit the row then row-edit will never kick in
saveState.  Nothing needed, however grouping options might need to be added to saveState
selection.  enableSelection, true by default.  When set to false you cannot select the row, needs to deal with rowHeader as well.  COMPLETE, but no special handling on rowHeader - the header is still there, clicking it does nothing.

Closing this, as I think the core bits are done.

Woah, just saw this. Where can I test this functionality? Sorry, I haven't been more responsive.

I merged them into master Jarod, so should be all available when you're ready to use them.

Awesome. I'll follow up tomorrow. Thank you!


write delta table regression with 0.6

Environment
Delta-rs version: 0.6.0
Binding: Python
Environment:

Cloud provider:
OS: Windows 10
Other:

Bug
this code used to work fine
`from deltalake import write_deltalake
import duckdb
con = duckdb.connect()
result =con.execute('''
with xx as (select *,extract ( year from l_shipdate) as year  from 'C:/Users/TPC-H-SF10/Parquet/lineitem.parquet')
select * from xx ;
''').fetch_record_batch()

write_deltalake("C:/delta2",
                       result,
                       partition_by=['year'])`

Now it generate errors, it does not works at all if I don't create the folder manually, and when I created manually it generate this error
File "C:\Users\mimoune.djouallah\AppData\Local\Programs\Python\Python310\lib\site-packages\deltalake\writer.py", line 201, in visitor
path, partition_values = get_partitions_from_path(table_uri, written_file.path)
File "C:\Users\mimoune.djouallah\AppData\Local\Programs\Python\Python310\lib\site-packages\deltalake\writer.py", line 301, in get_partitions_from_path
path = path.split(base_path, maxsplit=1)[1]
IndexError: list index out of range

@wjones127 any update on this, this is a very big regression ?

I'll look at this when I get back from vacation. This looks like it is specific to Windows paths, which we aren't currently testing. So we'll want to add Windows tests.

Okay, so this wasn't Windows-specific at all. Turns out we had broken writing tables to directories that didn't exist yet, which we weren't testing. I've added a test and fix for that in #811.
@roeap actually fixed the second issue as a part of #799, so are good there.
Thanks for reporting this.

@wjones127 thanks a lot, please just keep releasing new binary revisions :)


Dashboard Token Listing: DAI

Discord Handle of Submitter: Sunny | Superfluid#7782
Network Explorer Link: https://polygonscan.com/token/0x8f3cf7ad23cd3cadbd9735aff958023239c6a063
Is a Super Token? false
SVG Logo Link: https://cryptologos.cc/logos/multi-collateral-dai-dai-logo.svg?v=010
Coingecko Link: https://www.coingecko.com/en/coins/dai
Token HEX Color: #F5AC37

Airtable testing looks good!


Vite build fails to emit HTML file when generated by virtual file plugin

Describe the bug
When a file is generated by a virtual file plugin such as https://github.com/patak-dev/vite-plugin-virtual, the corresponding module ID may look like /@virtual:vite-plugin-virtual/some/path/to/file.
When the HTML entry point specified for vite build is provided by such a virtual file plugin, its content is correctly loaded, but bundling fails because shortEmitName looks like "../../../../@virtual:vite-plugin-virtual/Users/fwouts/dev/vite-virtual-html/index.html":
✓ 6 modules transformed.
rendering chunks (1)...[vite:build-html] The "fileName" or "name" properties of emitted files must be strings that are neither absolute nor relative paths, received "../../../../@virtual:vite-plugin-virtual/Users/fwouts/dev/vite-virtual-html/index.html".
error during build:
Error: The "fileName" or "name" properties of emitted files must be strings that are neither absolute nor relative paths, received "../../../../@virtual:vite-plugin-virtual/Users/fwouts/dev/vite-virtual-html/index.html".
    at error (file:///Users/fwouts/dev/vite-virtual-html/node_modules/.pnpm/rollup@2.77.3/node_modules/rollup/dist/es/shared/rollup.js:1858:30)
    at FileEmitter.emitFile (file:///Users/fwouts/dev/vite-virtual-html/node_modules/.pnpm/rollup@2.77.3/node_modules/rollup/dist/es/shared/rollup.js:15472:24)
    at Object.generateBundle (file:///Users/fwouts/dev/vite-virtual-html/node_modules/.pnpm/vite@3.0.7/node_modules/vite/dist/node/chunks/dep-0f13c890.js:41599:22)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Overriding fileName with just the hardcoded value "index.html" here fixes it, although that's obviously not the right approach :)
Note 1: This appears related to https://github.com/vitejs/vite/issues/2321 but I don't think it's quite the same issue.
Note 2: In case you're wondering, one example where this would be useful is in Preview.js to allow users to generate a static, precompiled version of a particular component so they can share it around. For now, I can work around it by patching Vite on my end.
Note 3: I'd be happy to make a PR for this.
Reproduction
https://github.com/fwouts/vite-virtual-html
System Info
System:
    OS: macOS 12.5
    CPU: (8) arm64 Apple M1
    Memory: 87.44 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.0 - ~/.nvm/versions/node/v16.15.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.9.0 - ~/.config/yarn/global/node_modules/.bin/npm
  Browsers:
    Chrome: 104.0.5112.79
    Firefox: 103.0.1
    Safari: 15.6
  npmPackages:
    vite: ^3.0.7 => 3.0.7

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I encountered the same problem


Webview keypress dispatch sometimes stops working

I found something more interesting:

Open a text editor, keep pressing ctrl+`, the terminal keeps toggling
Open markdown preview, keep pressing ctrl+`, the terminal toggles for a few times and then nothing happens anymore

This happens even without the experiment settings. I also toggled the keyboard shortcut troubleshooting and when ctrl+` went dead, the keybinding service doesn't get any keyboard events as well.
Originally posted by @rebornix in https://github.com/microsoft/vscode/issues/109702#issuecomment-719062237

As this is a serious accessability issue and does not involve any experimental settings, why not add to the November milestone rather than backlog? Thanks.

I tried creating a minimal electron repo (https://github.com/electron/electron/issues/26309) but it can be fixed by changing .focus() to .contentWindow.focus(). However since VS Code is already using .contentWindow.focus() the repo must not be complete
Also this is fixed by using iframe based webviews: webview.experimental.useIframes

@mjbvz I just installed Code 1.52 and can't find any webview.experimental.useIframes. It says Unknown Configuration Setting in settings.json

I found something more interesting:

Open a text editor, keep pressing ctrl+`, the terminal keeps toggling
Open markdown preview, keep pressing ctrl+`, the terminal toggles for a few times and then nothing happens anymore

This happens even without the experiment settings. I also toggled the keyboard shortcut troubleshooting and when ctrl+` went dead, the keybinding service doesn't get any keyboard events as well.
Originally posted by @rebornix in #109702 (comment)

I found something more interesting:

Open a text editor, keep pressing ctrl+`, the terminal keeps toggling
Open markdown preview, keep pressing ctrl+`, the terminal toggles for a few times and then nothing happens anymore

This happens even without the experiment settings. I also toggled the keyboard shortcut troubleshooting and when ctrl+` went dead, the keybinding service doesn't get any keyboard events as well.
Originally posted by @rebornix in #109702 (comment)

I'm closing this since I cannot reproduce using iframe based webview, which are now enabled by default for all webviews except those that enable search. We should be converting those over to use iframes too shortly


Interaction of frontend, backend, location and notifications

@fionnfuchs
Chatbot has a function get_usease instead of get_context. The keyword dictionary holds the Usecase classes directly instead of code words like $$work_session that the Controller would need to map back to the Usecase.

Controller checks UsecaseStore for running usecases before contacting chatbot. After an advance it asks the usecase if it is finished and hands the information to the UsecaseStore.


Add extra arguments to the objective function

Is there a simple way to add additional parameters to the objective function? These parameters are not supposed to be tuned.  In scipy.optimize.minimize you can add *args to the objective function. Is there a similar functionality in the BayesianOptimization package?

problem already solved, see https://github.com/fmfn/BayesianOptimization/issues/146


Update authors and re-release

We need to update the citation with all chapter authors and code reviewers

Done. I did not yet include tbargman, and possibly other that have been more behind the scenes.


Remove not maintained DRF-JSON-API

This project had a commit yesterday?

It might be confusing cause in the patch I removed the word (also) on the active project, if you recheck carefully the diff, you will notice that I removed drf-json-api (on github https://github.com/kevin-brown/drf-json-api) which clearly state that is not maintained.

Ah ha! Yes, I clicked the wrong link, sorry! :)

Thanks :)


Add travis configuration

Install dependencies, lint and build client code
Add 'Build Status' image to README
Use nvmrc to specify node version implicitly

Closing this now that #5 is closed.


Repo grouping (folders) in Workspace

When dealing with many repos in a workspace, the flat listing of them in the explorer becomes difficult to work with. An ability to group them into folders would be great.

This is a fari feature request however we do not have it on our immediate plan.
There might be similar issue already open which might help with your scenario. You can search for them and upvote them. For example working sets might help.

Okay, thanks, will search for such requests although didn't see much when searching before. Ideally what I would like is that my VS Code workspace can mirror my folder structure which groups repos by site (e.g. GitHub, BitBucket, other site) and account (company provider,  personal account etc). This is in fact a two-level grouping but I wanted to start with a simple request!
(And, to reduce maintenance, it would be great if the folder structure and repos in a workspace could be auto-detected. 😀 See https://github.com/microsoft/vscode/issues/87888.)
Just giving some context and hoping this can be taken account of in future planning.
I appreciate your reply. Happy 2020!


Change react icons for SVGs

Fixes #48

Blocked until we fix this issues https://github.com/frontity/saturn-theme/issues/51 and check that the notification icons are ok.

:tada: This PR is included in version 0.7.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"node" command not found

Just installed this extension, but does not work

sorry for late.
this extension is required nodejs.
please check node -v command is working.
this extension is detect nodejs from:
which node
/snap/bin/node
/usr/local/bin/node
solution:
if nodejs is not installed in your system.
i recommend install via snapcraft
snap install node --classic
if you don't want register in PATH.
make symlink to /snap/bin/node or /usr/local/bin/node.
hope this helps


feat: hyperparameter optimization for fnn models

Closes #861
Summary of Changes
Added fit_by_exhaustive_search method to NNClassifier, NNRegressor
Added FittingWithChoice and FittingWithoutChoice Error
Added Choice options for neuron_count params of all layers
Added contains_choices method to all layers
Added _get_layers_for_all_choices method to all layers
Added ClassifierMetric and RegressorMetric as Enums
fit_by_exhaustive_search currently only works for tables as input, images and timeseries will be added in a later pr

:tada: This PR is included in version 0.27.0 :tada:
The release is available on:

v0.27.0
GitHub release

Your semantic-release bot :package::rocket:


chore: Remove unused hash_utils.rs

Which issue does this PR close?

N/A
Rationale for this change

I spent quite a lot of time fixing some unsafe code in hash_utils only to discover that it is not actually used :facepalm:
What changes are included in this PR?

Delete unused code
How are these changes tested?

Existing tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.13%. Comparing base (32c61f5) to head (344302d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #561       +/-   ##
=============================================
- Coverage     54.78%   34.13%   -20.66%
- Complexity      795      809       +14
=============================================
  Files           103      106        +3
  Lines          9690    38586    +28896
  Branches       1844     8566     +6722
=============================================
+ Hits           5309    13172     +7863
- Misses         3427    22674    +19247
- Partials        954     2740     +1786

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


(fix): changing image tag from ci to latest

Signed-off-by: Raj<EMAIL_ADDRESS>
What this PR does / why we need it:
changing image tag from ci to latest
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Checklist:

[x] Fixes #
[x] Labelled this PR & related issue with documentation tag
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] PR messages has document related information
[ ] Labelled this PR & related issue with breaking-changes tag
[ ] PR messages has breaking changes related information
[ ] Commit has unit tests
[x] PR messages has upgrade related information
[ ] Commit has integration tests

A PR raised after this has successfully been built by circle ci. Should we merge this @chandankumar4 !


⚠ Bofrost.lu has degraded performance

In 57a967e, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2054 ms

Resolved: Bofrost.lu performance has improved in b7190c5 after 20 minutes.


Add sort functionality (by number of courses)

Add ability to sort the contacts in address book.
Contacts in the address book are sorted by the number of courses taken.
Command Format: sort-course
Tests not written yet. Tests will be written to this branch.

hi, can u also help to change this target branch to master so i can see the diff?


Module/mutsig/1.0

Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for New Module
Required

[X] I used the cookiecutter template and updated the placeholder rules.

[X] The snakemake rules follow the design guidelines.

[X] All references to the rules object (e.g. for input files) are wrapped with str().

[X] Every rule in the module is either listed under localrules or has the threads and resources directives.

[X] Input and output files are being symlinked into the CFG["inputs"] and CFG["outputs"] subdirectories, respectively.

[ ] I grouped the input symlinking rule to the next job that uses the input files.

[X] I updated the final target rule (*_all) to include every output rule.

[X] I explained important module design decisions in CHANGELOG.md.

[X] I tested the module on real data for all supported seq_type values.

[X] I updated the default.yaml configuration file to provide default values for each rule in the module snakefile.

[X] I did not set any global wildcard constraints. Any/all wildcard constraints are set on a per-rule basis.

[X] I ensured that all symbolic links are relative and self-contained (i.e. do not point outside of the repository).

[X] I replaced every value that should (or might need to) be updated in the default configuration file with __UPDATE__.

[X] I recursively searched for all comments containing TODO to ensure none were left. For example:
grep -r TODO modules/<module_name>/1.0

If applicable

[X] I added more granular output subdirectories.

[ ] I added rules to the reference_files workflow to generate any new reference files.

[ ] I added subdirectories with large intermediate files to the list of scratch_subdirectories in the default.yaml configuration file.

[X] I updated the list of available wildcards for the input files in the default.yaml configuration file.

I wrapped the installation inputs into ancient() and this is ready for re-review (or approval)

I have also wrapped the sample subsets file into ancient because I realised once you add a new subset to the table, it will want to re-run all previous subsets as well. This modification prevents from unnecessary re-runs, confirmed :heavy_check_mark:


ionscale tailnets list: Error: unauthenticated: invalid token

➜  ~ ionscale genkey
833d03421cf4f5e8ef5ba00cd0605bea022ddd10694a0fb1dacb6484afa5953a
➜  ~ ionscale tailnets list --system-admin-key 833d03421cf4f5e8ef5ba00cd0605bea022ddd10694a0fb1dacb6484afa5953a
Error: unauthenticated: invalid token
➜  ~ export IONSCALE_ADMIN_KEY=833d03421cf4f5e8ef5ba00cd0605bea022ddd10694a0fb1dacb6484afa5953a
➜  ~ ionscale tailnets list
Error: unauthenticated: invalid token

and tried write to /etc/default/ionscale, doesn't work.

hi @liveej
When using a system admin key with the CLI, you should use the same key as configured for your server.
If that is the case, something else is going on and a little bit more information of your setup is needed.


Separate vsphere datacenterconfig validation from rest of the cluster validation

Issue #, if available:
Prep for #870
Description of changes:

Move vsphere datacenter validation and setDefaults to its own method

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Precision of float/double values during output

This is a wonderful library, am trying it now, and have noticed that double values are truncated at output to 6 digits.
A possible solution could be adding a printf format specifier in parens after the type argument:
-r double(.12f)

Would be awesome to be able to print exact hexadecimal contents of the returned value since most IEEE 754 to decimal string conversions will lose information.

Hmm,  good idea. I'll try to prototype some code today.

I think writing it in hex is the correct solution, but doing it by default makes it harder to interact with the numbers in bash. What about having a rawdouble:/rawfloat: type for when you don't want to lose precision?

Fine by me, thanks!

Hm, not sure why Github didn't auto-tag this issue from b862cd0d1753cb0bcab35088b672a5ce3bf74c4b. It's related. Maybe sufficient for your needs? Did you have something else in mind, or are you aware of any way it is deficient? Thanks.

Thanks, looks good to me, I can imagine how someone wants to chain a bunch of libm operations without losing precision until the final operation...perfect.


(1/2 optimize charts) Create DOMUtils#isElementOnTop

This method returns false if there are any elements covering it.

Very cool. Once @mlunoe's comment is addressed, let's merge.

@kennyt Bump :)


Fix get_next_pass for Keplerian predictors

Fix #33.

Coverage increased (+0.1%) to 94.898% when pulling a3afb816b8ef1bf9a1e9738dc9db4fd532aa081f on Juanlu001:fix-pass-all-predictors into 00413a4ee1e1766b4fff08c2042676f1b4301143 on satellogic:master.

Coverage increased (+0.1%) to 94.898% when pulling a3afb816b8ef1bf9a1e9738dc9db4fd532aa081f on Juanlu001:fix-pass-all-predictors into 00413a4ee1e1766b4fff08c2042676f1b4301143 on satellogic:master.


Add Docker image

Adds a working Dockerfile to generate a ready to use Docker image.
Ideally you would have a CI job that does build the image and push automatically on success. If interested I could send another PR doing just that using GitHub actions / CircleCI.

Hi @mgcrea! It looks good and addresses #22. 👍
Do you mind changing the target branch to dev?

@hwwhww thanks! Just changed the target branch, looks like there is no conflicts.

How about a .dockerignore file
# Prevent your local modules and debug logs from being
# copied onto your Docker image and possibly overwriting
# modules installed within your image
.git
__pycache__

@ltfschoen Thanks for the review+suggestions, just pushed a new commit including them.

Just spent the better part of an hour trying to make a Dockerfile myself. Finally got it working, then I come here to see that someone already thought of it... 😅
Also, this version is probably better because it produces a smaller image (mine was almost 1GB because I didn't know the right packages to install, so I used buster instead of alpine).
Just tested this PR and seems to work fine for me.
One suggestion I have is perhaps using a multi-stage build to make the final image size even smaller, so it can be more easily distributed (say, via Docker Hub).
I was able to reduce the final image size by about 220 MB by adding the following lines to the Dockerfile:
FROM python:3.7-alpine

WORKDIR /app

COPY --from=0 /app /app

ENTRYPOINT [ "python3", "./eth2deposit/deposit.py" ]

All this does is basically start over with a new image, copy the files from the build, and then package that up, so the final image does not include the compiler and libraries that were necessary to build the app.

Another useful resource is this https://github.com/stefa2k/prysm-docker-compose

@ltfschoen that setup is what I use to run my validators for Medalla and also the reason why I wanted to dockerize the deposit CLI.
Stefan has done a great job making the key import as simple as possible, but it still took a bit of work to get the deposit CLI working, so I thought if only there was a docker image for that, this could literally become a one stop shop for setting up a validator, no futzing around with different compilers etc. required.
Unfortunately I did not find your PR there, @ltfschoen?
@mgcrea I think one improvement that would be nice to have would be a smaller image size. Yours was 264 MB, which is already a huge improvement over my 957, but I think it could be trimmed down quite a bit using a multi-stage build, which could basically drop the compiler and devtools required for the build process and only contain what's necessary to run the actual CLI.
I tried my hand at that, but unfortunately I failed, because my image did not include the compiled eggs, so it wouldn't run.

@PandaWhisperer FYI this is the PR with what I did https://github.com/ethereum/eth2.0-deposit-cli/pull/83

@ltfschoen oh okay, I misunderstood you then. I thought you made a PR on stefa2k/prysm-docker-compose.

Is there anything left I can do to help this being merged? Thanks!

Hey @mgcrea 👋 are you still working on it?

Hey @hwwhww, yes will gladly add any changes required for this to land. I've added the make build_docker step.

Looks good to me too. Thanks for your work on this @mgcrea!

Thank you @mgcrea!

Ideally you would have a CI job that does build the image and push automatically on success. If interested I could send another PR doing just that using GitHub actions / CircleCI.

Would you like to help with the CI job? #123 will change the command line interface so we should have dockerfile build in CI.


Checking for certificate in certificate chain would reduce dependency to server certificate renewal

Even if it is possible to include 2 fingerprints in the call to check the certificate presented by a server, this requires that a renewed certificate is created in advance, its fingerprint is included in the code of the mobile application and that the mobile application is deployed to all users before the new certificate can be installed on the server. I find that this creates too many constraints.
I would suggest that the plugin is extended to be able to check for the fingerprint of any certificate in the certificate chain presented by the server. This would allow certificate pinning to the certificate of a specific issuing CA (usually with a longer validity period). As long as server certificates are issued by the same trusted CA, this could give a good enough level of security while reducing considerably the need to update mobile applications with updated certificate fingerprints.
I already have some code working for Android and iOS. The plugin could be extended with another method (checkInCertChain) while leaving the ability to check specifically for the server certificate (check).
Before creating a pull request for it, are there comments in favor or against it?

Was this finished with #19?

Absolutely!


Spotify API Token doesn't work

hello! im trying to build the app, but in the documentation the api key stuff isn't clear.
on spotify, i have a client key, and a secret, but no api key, and im not sure how to get it. in the documentation it says: "Create a Spotify app and get the keys on the Spotify developer dashboard.
Fill SPOTIFY_API_TOKEN in firstfm/Config/Secrets.xcconfig."
It says keys, but theres no api key. only the client and the secret.
i just need help finding what the api token is, many thanks!


Remove unnecessary calls to glActiveTexture

Since wlroots shaders only use one texture at a time (ie there is only one
sampler2D variable in any shader), it is unnecessary to switch between active
texture units at this time.

I wonder if at some point it would make a performance impact if we prepared lots of surfaces for rendering and render them all in one go on the shader.


command callback

Hi ! I'm use  'this.mpv.command('screenshot-to-file', filePath) '  to take a  screenshot .
How can I get the callback? thanks

Not possible right now. Closing in favor of #26.


Recording Rule "kubevirt_vm_container_free_memory_bytes" is not working

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
When try to execute recording rules: "kubevirt_vm_container_free_memory_bytes" shows "No datapoints found."
I debugged more and found that metrics used in this recording rules expression is changed.
What you expected to happen: It should work and show output.
How to reproduce it (as minimally and precisely as possible): 100%
Anything else we need to know?: This is the updated expression need to use --> sum by(pod, container) ( kube_pod_init_container_resource_limits_memory_bytes{pod=~'virt-launcher-.*'} - on(pod,container) container_memory_working_set_bytes{pod=~'virt-launcher-.*'})
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@sradco Can you please take a look into it.?

It seems that the container is "volumecontainerdisk" and there is no "compute".
We should update the recording rule to kube_pod_container_resource_limits{resource='memory', unit='byte', pod=~'virt-launcher-.*'}

New query should be :
sum by(pod, container) ( kube_pod_container_resource_limits{resource='memory', unit='byte', pod=~'virt-launcher-.*'}

on(pod,container) container_memory_working_set_bytes{pod=~'virt-launcher-.*'})


Wrong username being displayed

Each time I refresh the page I see a new name on the navbar. Seems like logged username is being cached and I'm being served someone's cache.

@fabiogiolito This should be fixed now. You may need to sign out and sign back in for it to pick up the proper username/avatar.


Refactoring for checkstyle and PMD usage.

I corrected some of PMD violations.
Other corrections require refactoring so I add suppress for PMD check in those places.
I think that we should start using the PMD to avoid new violations, old violations can be resolve later.


Fixed BaseKoreanPhonemizer to use voice color

Fixed the bug that BaseKoreanPhonemizer was not appling voice color suffix.

This bug fix has been applied in #1305, I'll close this PR.


Localization support

Hi,
cool converter. It's a pain to use in Finland though, since both CSV-separarator and decimal separator is different and not recognized by the app.
I'll probably just fork it and hack it to parse my exact case better, but it would be cool if you could select the separator formats (and the date formats) from a dropdown or something.
http://en.wikipedia.org/wiki/Decimal_mark#Hindu.E2.80.93Arabic_numeral_system

Hmm, that's interesting. I didn't know that. Yeah, right now I am dropping commas all together in the amount field. Because there could be numbers like, "$2,432.43". I'm not sure what the best way to handle that is, I'll keep it in mind though.
I do plan at some point to add an option to select the CSV separator and date format https://github.com/halloffame/ynab-csv/issues/9

+1

+1
In Czech we use as decimal separator character "," instead of "."
It will help me much as well to let the user select the separator.
Plus it would be nice to let user select incoming file encoding (like windows-1250, iso-8859-2, utf8, etc.)

In the meantime, here's a simple fork for the decimal comma people:
https://workflow.github.io/ynab-csv/
(also strips out any dots)


reduce verbosity of mvn build log

Current mvn build log (that is, output on executing mvn verify) is very long. We should investigate if we can cut back the verbosity a little.

Test suites spitting out a lot of data include the elasticsearch tests, as well as the test suites relying on embedded jetty and the tests for the federate command in the console. That last one is by design (see issue #614 ) so I will leave that alone for now. The others are simply misconfigurations of the test logger, I will adapt to reduce length of the build log.
Everyone, keep in mind that you when you are debugging something, you can of course change the log level locally to get more detailed data, but please do not commit such a change. Log level INFO or WARN should be more than enough for regular builds.


I can not export the dataset after I labeling the rectangle dataset today. I can export successfully before.

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar.
[X] I read/searched the docs

Steps to Reproduce

Expected Behavior
export the dataset successfully. I have checked the network, but i can not find any error.
Possible Solution
No response
Context
No response
Environment
No response

There were some server-side issues this morning. We apologize for that.
Now the instance is working. Please, try export one more time .