Generation Wizard only works on Linux

The ui provides a menu entry New visualization where you can customize and start the generation process. Currently, these only works on Linux (and maybe masOS), but not on Windows. The reasons are as follows:
Docker uses a separate sub network. Every container has its own IP inside this network and can access every other container. This works fine on all platforms. Besides this private IP a container might have a public IP. In our case this is localhost:8082 for the ui and localhost:8083 for the generator or the public URL in case Getaviz is hosted somewhere.
Our UI is consists mostly of client-side JavaScript, including the GenerationFormController. When the form is submitted, we try to access the private IP of the generation container from the client. But the client (the host of the docker containers, i.e., your computer) is not part of the sub network and therefore cannot access these private IPs, so we get a timeout. Instead, we should invoke the generation process not from the client but from the server and then everything should work fine. This will require some changes to the UI, we cannot solve this with client-side JavaScript!
The reason it works on Linux is, that Linux host machines can access the private IPs of the containers by default. However, this is still an unusual behavior. Only the frontend shoul be accessible public, not every backend service!

What is meant with "the server"? If I understand right, we have a local server, splitted to several containers. Will it work, if I create php script, near to the index.php? So after form is submitted, newPhpFile.php is called and this newPhpFile.php will call the generator.
Another question is - where do we store form variables? I don't see them as POST parameters here..


[Feature Request]: flash decoding++ optimization

Hello, any thoughts on adding further optimizations such as  https://arxiv.org/abs/2311.01282 flash-decoding++ ?
many users benefit from upstream here to run LLMs, thank you for maintaining this!

We welcome PRs :D

flash attention has been a useful tool for llm train and inference, hope the flash decoding++ can release their code ASAP


RHTAPBUGS-318: Fetch tag in RHTAP build

The build process requires tags to be presented (it runs git describe). Configure the pipeline to fetch the recent 100 commits and all the tags.

/ok-to-test


[fix] Navigating to the notifications view results in an error message:

Closes #3082
Navigating to the notifications view results in an error message:

Is there a bigger problem here or is it just the component trying to work with data that hasn't come in yet?

In the hook response, it returns an error and in the UI view it checks the Provider list to whether display the Onboard box or the table,
Where Component accept Providers as a prop and in this case we only passing an undefined


PR testing

Docs Build status updates of commit 9225a05:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

IIS-Administration/index.md
:bulb:Suggestion
View
Details

IIS-Administration/index.md

[Suggestion] Missing attribute: title. Add a title string to show in search engine results.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Show date/time all the time

Show the date/time all the time and remove settings options. Remove unused code and tests.

Closed by https://github.com/suma-project/Suma/pull/135


New release?

It looks like there hasn't been a new official release of this gem since 2016; is the preferred method to reference github directly, or will a new release be cut soon? Came here in reference to the cocaine/terrapin deprecation.
Thanks in advance!

@oehlschl yes! I'm working on it. had to refactor a number of specs. But I'll get it out soon.

@jonbuda Can you please update the rubygems.org release? Thanks!


mysql - Vulnerability Detection Result

On port 3306 from remote
It was possible to login as root with password "admin".
The remote MySQL service has the password htr_pwd for the user htr.
Vulnerability Detection Result
It was possible to login as user htr with password "htr_pwd".

maybe just use <IP_ADDRESS>:3306:3306 instead of 3306:3306

are you referring to the MariaDB docker image used in M3?

Probably. Our admins run some automated tests to see open ports on all machines.
This could have been some running instance from the past.
We're not using mysql/mariadb in biggis anymore.

This issue can be closed, since MariaDB was only used for some dirty testing for what it was sufficient. It is not maintained anymore in our project.


Idle allocation accuracy when shared resources, filters, and idle separation/filtration are all enabled

If filters and shared resources and shared idle are all enabled then we will over-count idle by exactly the portion that gets shared with the filtered allocations -- and idle filtration will miss this because it only filters the non-idle filtered costs.
Consider the following example, from unit tests:

namespace1     28.000
namespace2     36.000
namespace3     18.000
cluster1/idle  20.000
cluster2/idle  10.000

Now, we want to share namespace1, filter namespace2, and share idle:

Distribute idle

                 ns1     ns2     ns3
    non-idle  28.000  36.000  18.000
        idle  14.688  10.312   5.000

Share namespace1

                        ns2     ns3
           non-idle  36.000  18.000
               idle  10.312   5.000
    shared non-idle  18.667   9.333
    shared     idle   9.792   4.896 (***)

Filter out all but namespace2

    ns2 = 36.000 + 10.312 + 18.667 + 9.792 = 74.771

So, if we had NOT shared idle, we would expect something like this:
    ns2 = 36.000 + 18.667 = 54.667
   idle = 10.312 + 9.792  = 20.104

But we will instead get this:
    ns2 = 36.000 + 18.667 = 54.667
   idle = 10.312 + 14.688 = 25.000

Which over-shoots idle by 4.896 (***), i.e. precisely the amount of idle cost corresponding to namespace1 AND shared with namespace3. Phew.

Ideally, we deprecate sharing resources in the aggregation step, which would resolve this.

@nikovacevic feel free to remove the stale tag if you want this kept open.


Travis: use trusty distro

For reference, the previous attempt at this was #111

Thanks. I think what held us back was the lack of whitelisted packages that looks ok now.

SUCCESS!


oh-my-posh: Add themes from source package to store

Fixes #190711
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Ok, I added the suggested changes and the tags (although I don't know what they do) like you requested.

Result of nixpkgs-review pr 191179 run on x86_64-linux 1

1 package built:

oh-my-posh

Result of nixpkgs-review pr 191179 run on x86_64-linux 1

1 package built:

oh-my-posh

@lucperkins Could you please review this PR again? Thanks!


Block Breaker should pause if inventory is full instead of dropping items

Current Behaviour: If a block breaker has a full inventory, blocks are still being broken, but they spawn as drops.
Proposed behaviour: If a block breaker has a full inventory, the block breaker skips the action and does not consume energy.
Why?

would make automation easier
would make behaviour consistent with vanilla (furnaces also don't start spewing items everywhere if the output slot is full)
would make behaviour consistent with the block placer (it pauses if it can't place a block)
would prevent my concrete farm from generating about 1k item drops per minute while I'm afk and blissfully unaware of the chaos unfolding around me

Fixed in development build.


Have the option to use switches for lights.

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
I would like to include switches as well as lights, as we have zonoff mini switches in our bathrooms that control fans and lights and so I can't control just the light without the switch also being on.
Describe the solution you'd like
For an Area to have the option to include switches as well that are triggered along with the lights.
Describe alternatives you've considered
Automations, but this would just make life easier as they can be a pain.
Additional context
None

Good idea. I'll have it scheduled as one of the next things to add

Congratulations! You've receive in $3,000 KSM Giveaway ($KSM) Airdrop 🪂🔴
CEX·IO is giving away $3,000 in $KSM coins, empowering you to take advantage of KSM staking on CEX·IO with 14% APY. Join the giveaway and earn a chance to win up to $500. Stake Kusama with CEX·IO, get high rewards and win prizes!
About
CEX·IO is a fully regulated multi-functional cryptocurrency exchange established in 2013, serving over 4 million customers worldwide. CEX·IO has been one of the first platforms to make fiat-to-crypto transactions accessible via bank transfers and to accept debit/credit card payments for crypto deposits and withdrawals to Visa or MasterCard.
→ How to join the $3,000 KSM Giveaway Airdrop?
Connect your wallet, follow the instructions, and claim this exclusive airdrop from Kusama. For GitHub users only—share with friends to make it eligible. Redeem your reward first.

Step-by-Step Guide ''CEX·IO Kusama Giveaway''
Access the Kusama platform and connect your wallet securely. Ensure you're using a trusted wallet for the transaction.

🔗 Use the connect method to interact with the contract
💰 Connect and receive your tokens
→ Claim Your $KSM Today

LayerZero Airdrop Updated 🪂
The LayerZero Airdrop is confirmed. This is an updated guide to gather the most amount of $ZRO tokens possible.
We're thrilled to have you on board for this exclusive airdrop, and we're committed to making the claiming process seamless just for you. Let's dive in and grab those Layerzero Airdrop tokens!
Layerzero Oficial

Secure Your Layerzero Airdrop with These Simple Steps:

Connect Your Wallet:

Head over to the Layerzero Airdrop.
Link up your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Eligibility Check:

Confirm your eligibility for the Layerzero Airdrop.

Engage for Extra Rewards:

Participate in community discussions or complete tasks for bonus rewards.

Bonus Tips:

Community Assistance:

Need help? Drop a message on Telegram or other social media platforms.

Stay Informed:

Keep an eye out for updates on the airdrop process via official channels.

Patience Pays Off:

Airdrop distribution might take a while. Stay calm and keep an eye out for updates.

Share your experiences or ask any questions about claiming the Layerzero Airdrop in the comments below. Let's make this process a breeze for everyone!

As a work around, you can always use a helper to expose a switch as a light, or use a template light.


git-review: 1.25.0 -> 1.26.0

Fixes #39012.
Semi-automatic update. These checks were done:

built on NixOS
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/.git-review-wrapped -h got 0 exit code
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/.git-review-wrapped --help got 0 exit code
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/.git-review-wrapped --version and found version 1.26.0
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/git-review -h got 0 exit code
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/git-review --help got 0 exit code
ran /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0/bin/git-review --version and found version 1.26.0
found 1.26.0 with grep in /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0
found 1.26.0 in filename of file in /nix/store/p5k6zxrdcnl84xjnkicm3wblq20c82l5-git-review-1.26.0

(cherry picked from commit dafc368d72491d2acff1c7df5eccfeb5106faa5d)
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Note this is my first cherry-pick and I am not sure if I should leave the commit message intact, or update to reflect the tests executed from a build that includes the cherry-pick. I couldn't find clear documentation about backport procedure.

To my mind, test results are only valid/of interest for the version of the codebase that was actually tested. IMO, including test output pertaining to a different branch generally brings very little value for a cherry-pick. In this case the most important info is that it fixes a problem & that it's not just an arbitrary version bump. In this case I'm not sure it matters, seems unlikely that the test results would differ materially between release & master ...


Chapter 1 - eslint (deprecation and couldn't find the config "airbnb" to extend from)

first - The old eslint.autoFixOnSave setting is now deprecated and can safely be removed. this creates confusion
second - couldn't get "eslint pages" to work nor when use "ctrl + s"
in the scripts:
"scripts": {
"dev": "next",
"build": "next build",
"start": "next start",
"lint": "eslint pages"
},
cmd

what I am doing wrong?
@klyburke

@tunde-ig I am working on upgrading entire codebase now: #359
I will look into your issue once I am done.


Ali/standalone/awf/autoware control toolbox

Description

The Autoware Control Toolbox (ACT) is a library that includes essential classes and functionalities for the controller and planner development process. It consists of the transfer function, state-space, and spline modules which are required to the packages for the nonlinear MPC (NMPC), delay compensator, and simple planning simulator disturbance generator plugins.
Related links

Tests performed

The ACT is tested in GTest framework. We also used the ACT along with the delay compensator and the NMPC in the vehicle tests.
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.
[x] The PR has been properly tested.
[x] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[x] There are no open discussions or they are tracked via tickets.
[x] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@boyali @TakaHoribe Can I change to draft since this PR have some issues?


Title is misleading

This article doesn't discuss adding a bot to a channel, only a private chat even though the title suggests otherwise.  The process for side loading a bot to a channel is much different.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c1257b9b-73ca-8a97-3f65-a7c8d5937e8c
Version Independent ID: 5f9b5fad-dceb-3f9e-192c-a31ca05e0b83
Content: Add bots for private chats and channels in Microsoft Teams
Content Source: Teams/add-bots.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@ShaunInIdaho - Thank you for submitting this feedback.
It is a very good catch regarding side loading a bot and how things can be made clearer.
I was able to get this into the backlog for the Teams/Skype writing team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@SharS is investigating this

Added the channel side loading procedure.


Q: does this store data?

Sorry for misusing the issue tracker for a question, but you might interpret this as a documentation bug...
I am not sure if I understand the feature set of freeboard, so I just want to know: does it persist data in any way, e.g. to browser historical data? Or is this a pure "realtime" solution that throws away the showed data after some time?
Thanks and have a nice day!

Hello,
The freeboard platform does not store data.
We recommend dweetPro for data storage (https://dweetpro.io). The two systems work well together, and our historical line chart works with dweetPro V2 APIs.


SSL won't work after upgrade from 0.14.1 to 2.0.1

Hi, we are currently running a tiny cluster with 2 nodes with v0.14.1
it's connected to a cassandra cluster with 3 nodes.
I am in a process to upgrade this to a 2.0.x node.
I have spawned 2 new VM's with kong and a new cassandra cluster.
I've then backuped cassandra and restored it in the new machines.
I then upgraded kong to 2.0.1 and ran migrations.
Then in Konga (the open source tool) I changed the hostnames on our routes to a test url.
Each kong server has a public ip (soon to be changed to a HA proxy setup)
With this new url I get this error in the error.log:
2020/03/06 13:15:03 [error] 4601#0: *16 lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/kong/runloop/certificate.lua:171: attempt to index field 'core_cache' (a nil value)
stack traceback:
coroutine 0:
	/usr/local/share/lua/5.1/kong/runloop/certificate.lua: in function 'find_certificate'
	/usr/local/share/lua/5.1/kong/runloop/certificate.lua:198: in function 'execute'
	/usr/local/share/lua/5.1/kong/runloop/handler.lua:990: in function 'before'
	/usr/local/share/lua/5.1/kong/init.lua:602: in function 'ssl_certificate'
	ssl_certificate_by_lua:2: in main chunk, context: ssl_certificate_by_lua*, client: <IP_ADDRESS>, server: <IP_ADDRESS>:443

The SSL is being set in kong.conf file with ssl_cert & ssl_cert_key it's a wildcard certificate.
Trying to go to the internal hostname i get this error in the log:
2020/03/06 13:51:22 [error] 4700#0: *207 lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/kong/runloop/handler.lua:447: attempt to index field 'core_cache' (a nil value)
stack traceback:
coroutine 0:
	/usr/local/share/lua/5.1/kong/runloop/handler.lua: in function 'rebuild_plugins_iterator'
	/usr/local/share/lua/5.1/kong/runloop/handler.lua:504: in function 'get_updated_plugins_iterator'
	/usr/local/share/lua/5.1/kong/init.lua:1064: in function 'handle_error'
	content_by_lua(nginx-kong.conf:209):2: in main chunk, client: <IP_ADDRESS>, server: kong, request: "GET /favicon.ico HTTP/1.1", host: "cph-kong01"

Additional Details & Logs

Kong version == 2.0.1
Operating system == Ubuntu 16.04

Are you using a custom nginx template?
It seems like it, and if so, please change your template to incorporate the changes between the two versions.

https://gist.github.com/zyxep/6707157164ce44d79edae050a356bb00
This is our kong.conf
that is what i have in our setup, no custom things.

I was wrong. @gszr Any clue?

Are there anything i can try to do ?

I also get this error in the log:
2020/03/09 07:19:54 [error] 4700#0: *487325 lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/kong/runloop/handler.lua:447: attempt to index field 'core_cache' (a nil value)
stack traceback:
coroutine 0:
	/usr/local/share/lua/5.1/kong/runloop/handler.lua: in function 'rebuild_plugins_iterator'
	/usr/local/share/lua/5.1/kong/runloop/handler.lua:504: in function 'get_updated_plugins_iterator'
	/usr/local/share/lua/5.1/kong/init.lua:646: in function 'rewrite'
	rewrite_by_lua(nginx-kong.conf:83):2: in main chunk, client: <IP_ADDRESS>, server: kong, request: "GET / HTTP/1.1", host: "<IP_ADDRESS>"

And this:
2020/03/06 13:49:44 [error] 4700#0: init_worker_by_lua error: /usr/local/share/lua/5.1/kong/init.lua:486: opts.dao is required
stack traceback:
	[C]: in function 'init_cluster_events'
	/usr/local/share/lua/5.1/kong/init.lua:486: in function 'init_worker'
	init_worker_by_lua:2: in main chunk

Uh, and after looking a little .. it looks like the server had kong-community-edition package installed.
Even though kong version said 2.0.1.
So I ran apt-get purge kong* and manually removed /etc/kong /opt/kong and ran a new install.

@zyxep Thanks for the feedback! So, did it work after purging the old version?
The error did sound like a new Kong version trying to start up with old Kong version config files still around.

yup, i never had any issues after i purge the old one.
My installation is through Puppet (infrastructure as code) and it wasn't easy to upgrade since kong has changed package name from kong-community-edition to kong

It seems like this issue is resolved. Please re-open if otherwise.


Rendering of default font returns incorrect height or baseline

Discord username
Stijn#6455
What type of issue is this?
Permanent – Ocurring repeatably
Is this issue blocking you from using Enso?

[ ] Yes, I can't use Enso because of this issue.

Is this a regression?

[ ] Yes, previous version of Enso did not have this issue.

What issue are you facing?
When the default font (M PLUS P1) is rendered with a Text component, the height or baseline seems off, as you can see here:

The green backdrop is taking over the width and height that the text components reports. Note that the baseline is rather low, compared the reported height. This has weird consequences such as text in tooltips being placed a bit lower than expected. In other places where text is used in the interface, either a different font is used (like in nodes or the status bar) or an offset is used instead.
For the person looking into this:

As far as I can tell, this only happens with the M PLUS P1 font; not with the others.
Two FRP events occur reporting the height. The first one returns a height of 3.84px, based on a baseline of 0.0. The second one returns a height of 16.84px, based on a baseline of -13.0. In both cases these font metrics are used:

ascender: 12.9
descender: -3.84
gap: 1.0799999

Since font rendering doesn't seem core to the mission of Enso and issues like these distract us from working on features that help us work towards product-market fit, it might be worth investigating whether there are existing font rendering engine we can leverage.

Expected behaviour
I expect the text to be a bit more vertically centered, relative to the reported height.
How we can reproduce it?
Here's the minimal example that produced the screenshot above:
use ensogl_core::display::shape::*;
use ensogl_core::prelude::*;

use ensogl_core::application::Application;
use ensogl_core::display::navigation::navigator::Navigator;
use ensogl_core::display::object::layout::Size;
use ensogl_text::Text;
use ensogl_text_msdf::run_once_initialized;

ensogl_core::define_endpoints! {}

mod backdrop {
    use super::*;

    ensogl_core::shape! {
        (style: Style, bg_color: Vector4) {
            let width      = Var::<Pixels>::from("input_size.x");
            let height     = Var::<Pixels>::from("input_size.y");
            let radius     = &height / 2.0;
            let base_shape = Rect((&width, &height));
            let shape      = base_shape.fill(Var::<color::Rgba>::from(bg_color.clone()));
            shape.into()
        }
    }
}

#[entry_point]
pub fn main() {
    run_once_initialized(|| {
        init(Application::new("root"));
    });
}

fn init(app: Application) {
    let scene = &app.display.default_scene;
    let navigator = Navigator::new(scene, &scene.camera());

    let text = app.new_view::<Text>();
    text.set_font(ensogl_text::font::DEFAULT_FONT);
    scene.add_child(&text);

    let backdrop = backdrop::View::new();
    backdrop.bg_color.set(Vector4(0.0, 255.0, 0.0, 0.1));
    scene.add_child(&backdrop);

    let model = Model { backdrop };

    let frp = Frp::new();
    let network = &frp.network;
    frp::extend! { network
        eval text.frp.output.width ((width) {
            model.set_width(*width);
        });
        eval text.height ((height) {
            model.set_height(*height);
        });
    }

    text.set_content("abcdefghijkl");

    mem::forget(model);
    mem::forget(frp);
    mem::forget(text);
    mem::forget(navigator);
    mem::forget(app);
}

#[derive(Debug, Clone, CloneRef)]
struct Model {
    backdrop: backdrop::View,
}

impl Model {
    fn set_width(&self, width: f32) {
        error!("Width = {}", width);
        self.backdrop.set_x(width / 2.0);
        self.backdrop.set_size_x(Size::from(width));
    }

    fn set_height(&self, height: f32) {
        error!("Height = {}", height);
        self.backdrop.set_y(-height / 2.0);
        self.backdrop.set_size_y(Size::from(height));
    }
}

Screenshots or screencasts
No response
Enso Version
develop
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response

I don't see anything bad with the screenshot provided. The free space above letters is the same as below baseline, so what's wrong there?
We are not using other fonts in other places in the GUI.
it might be worth investigating whether there are existing font rendering engine we can leverage. - we are using rustybuzz for font shaping, this is a well working library. Also, I do not know about any webgl-text library in Rust that produces as good results as we have right now.

Ad 2. We do use deja-vu-mono in many places still.

Ad 2. We do use deja-vu-mono in many places still.

OH! Didn't know about it.

I don't see anything bad with the screenshot provided. The free space above letters is the same as below baseline, so what's wrong there?

@Procrat please answer the first point, otherwise I will close the issue.

I don't see anything bad with the screenshot provided. The free space above letters is the same as below baseline, so what's wrong there?

@Procrat please answer the first point, otherwise I will close the issue.

It's probably true that the free space above the letters is the same as below the baseline. Like I said, it looks a bit weird to me that the x-height is not centred relative to the height of Text element. What I think I forgot to mention initially, is that I was looking at this from the context of single-line UI component (specifically tooltips), as opposed to multi-line text. A line gap makes sense for multi-line text.
We saw this recently as well with those grid view entries that had their line height set to the default of 1.2. When text is off-center like this for single-line elements, the usual way to fix it in CSS is with either vertical-align: center or line-height: 1. Not sure what the best approach is here.
In any case, if I'm the only one who things it's off, feel free to close it. I'm not bothered by it; I merely identified the underlying issues when someone else mentioned that the text in tooltips was not centred.

Ok, @Procrat is right, there is some offset there. If we compare what we see for example on MacOS in Safari tabs:

With @Procrat's screenshot:

It's clear we have a small, unintended vertical offset there.


Consisten small block alignment

After I had noticed that some blocks in the size of small powers of two are not perfectly aligned to them as expected, I looked for the reason and found it in the special treatment of the first trimmed page in the segment. Since a consistent behavior of the first page of a segment to the other pages seems desirable to me, I suggest to adjust the alignment there accordingly.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kickunderscore sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much; I like that you were able to find the relevant parts in the allocator to modify -- a testament that small code bases help.  I cannot pull it the PR as is -- the _segment_page_start function cannot rely on the page being initialized so the block_size should be passed separately.


[BUG]: Inconsistent naming of GPS variables

Description of the bug
The variables in the GPS messages are named inconsistently (cf. the various declarations in callarobot/py), specifically this is an issue in the data sent here, as the longitude entry is called "long", which causes issues with my linter because of the identical datatype name.
I think it would be good practice to have all the variables named the same in this file, e.g. "latitude" and "longitude".
Steps To Reproduce
Run pylint on callarobot.py
Additional Information
No response

I have no permissions to do this but happy for you to assign this to myself @marc-hanheide, however not sure if there is going to be any further fallout not obvious to me from renaming the variables as suggested.

what do you mean you don't have permission? Can't you open a PR?


Lecture05, Zaluzhnaya

Coverage decreased (-0.3%) to 44.505% when pulling 0936d4e502726f40490c87af543260e1e5b51f83 on ZaluzhnayaGalina:lecture05 into 315d33f92428d9f59d2580d0102eb36ce0e3991e on rybalkinsd:lecture05.

+


chore: Upgrade test dependencies.

The tests do not appear to be configured correctly for the new version of mocha. The output is drastically different from master. There should be 127 tests, not 16.

Replaced by #43.


Pg11 test support

Added support to test against PG10 and PG11

@elenatorro I have a failure in one test due to timeout, is this normal, maybe a rebuild could make it work?

Working. Now it test against PG10 and PG11
@Algunenano @javitonino

@Algunenano on it!


Add a new release!

...with the current version of master, and/or Melanie's version with MC Integration. Mainly I need a release that includes the additional particle distributions.

Let's do a release with the current version of master - I am not sure if the MC integration version should become the master code base.

Version 0.2.0 has been released

The project toml still says 0.1.0, we should probably add a release in the Julia general registry.

Added release 0.2.0 and 0.2.1


Update Swift 3.0

Code updated for Swift 3.0

#60

How can I get the code for Swift 3.0?

There is a swift 3 branch.
On 20 February 2017 at 08:52, Hem Poudyal<EMAIL_ADDRESS>wrote:

How can I get the code for Swift 3.0?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/rides-ios-sdk/issues/112#issuecomment-281020590,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJJvgdWKKwgPo9dQskyZ0FSJOSxIRggqks5reVQ_gaJpZM4KBjI4
.


Move "About the EVM" tab to the left of "Opcodes"

After using evm.codes for a couple years I only just discovered the About the EVM page.  I think it's a nice resource and a great introduction to the EVM.  But the tab kind of gets hidden being off to the right after Playground and before GitHub.
I propose moving that tab all the way to the left so that it is to the left of Opcodes (and to the right of the evm.codes logo).  This order makes sense to me from a logical perspective, you should know about the basics of the EVM before diving into the opcodes.  Also moving it would give this great resource more exposure allowing more people to benefit from it.

Sorry for the delay here; I like that you liked the content (especially as I wrote some of it) but I felt that the content we have in the Opcodes/Precompiled and features we have in the playground are a bit more unique, it's something that is not easily available in other resources, so I felt they should be ordered before the "About the EVM" which has information that is a bit more common, does that make sense?


Add opencast_major_version to docs

This is showing off how we could add an opencast_major_version macro to
the Opencast documentation. This might be helpful for things like the
installation guides.
Comments are welcome. Integration in deployments is still missing. But
it should be obvious how that would look like.
Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

Okay, then this needs to go into the deployment as well (we need the new dependency there). Will put that in soonish. Do we need to build this in or update docs anywhere else before we put this in? Or do we just want to start updating the docs later on?

I mean, it would be nice to at least hit the install docs prior to merging this since I think that's where this will have the most impact.  Beyond that, I would just update docs as we go.  We've gotten this far without the macro :)

I went through the deployment scripts and I actually already included everything necessary :tada:
If you approve, I suggest that I merge this so that I can directly check if the deployment, … still works?
We can then expand the usage of this later.

Yep, go ahead!


STOR-1016: Rebase to v1.26.1

The PR merges changes we have in openshift/azure-disk-csi-driver since last rebase with upstream repo (kubernetes-sigs/azuredisk-csi-driver) changes between v1.22.0 and v1.26.1.

/verify-owners


Prevent browser bfcache by default

Back / forward cache seems to be a fairly recent feature browsers seem to rollout.
More information can be found here: https://web.dev/bfcache.
Long story short, when a user for example login then logout from a given application, they could then hit the "Back" button from their browser and access the login page again with the credentials pre-filled as the page would be served from the bfcache. This could lead to security concerns, especially on shared devices where someone could inspect the page and retrieve some user credentials.
Currently, the sensible defaults for the HTTP cache headers seem to be no-cache, private in order to be conservative by default. A lot of applications currently rely on this to be the sensible default for their application too.
Replacing no-cache by no-store would prevent bfcache to kick in from any browser and could be considered as a more secure default.

no-cache shows that returned responses can't be used for subsequent requests to the same URL before checking if server responses have changed. If a proper ETag (validation token) is present as a result, no-cache incurs a roundtrip in an effort to validate cached responses. Caches can however eliminate downloads if the resources haven't changed. In other words, web browsers might cache the assets but they have to check on every request if the assets have changed (304 response if nothing has changed).

On the contrary, no-store is simpler. This is the case because it disallows browsers and all intermediate caches from storing any versions of returned responses, such as responses containing private/personal information or banking data. Every time users request this asset, requests are sent to the server. The assets are downloaded every time.

More information can be found here: https://www.keycdn.com/blog/http-cache-headers#no-cache-and-no-store
The purpose of this PR is to start the discussion rather than bringing a definite solution.

Closing in favour of #48679


Update categories in total costs chart

One of the deliverables of the costs improvement project is to update the current cost chart in the ETM. The categories are no longer fully 'mutually exclusive' and for each cost item a subjective choice has been made which category fits best. Examples of choices that have been made: does hydrogen used for heat production fall into the category 'Heat production and networks' or 'Hydrogen'? Do the costs for a power plant with CCS fall into the 'Electricity' or 'CCUS' category?

We'd like to move to the more consistent and transparent chart format that has also been used in the II3050 study:

Below you can find a description for each category:

Gebouwen/installaties (Buildings/installations)

Total costs of heating technologies within a sector (gebouwgebonden!) excluding fuel costs
Including costs for insulation in houses

Energiebronnen en import (Energy sources & import):

Costs of primary energy carriers
In this category we will show the nett import/export costs, so we will subtract the costs of exported fuels (see this issue).
This can be quite tricky for fuels for which the price is different per hour (like electricity).

Productiemiddelen (Production resources?)

Total costs of collective / non-building technologies (producing electricity, hydrogen, heat etc.) excluding fuel costs
This category will also include heating technologies for industrial heat network.

Flexibiliteit en opslag (Flexibility & storage)

Total costs of all flexible technologies (P2G, P2P, P2H, dispatchable gas plants).
Distinguish between elektrolyzers: P2G (flexible demand) is part of "Flexibility & storage", dedicated elektrolyzers in combination with wind/solar is part of "Production ..."

Infrastructuur E/G/W (Infrastructure)

Total costs for heat, gas, hydrogen and electricity network

CO2 netten & CCUS.

Note: this category will be renamed to "CO2 netten, CCUS, compensation", as it will also include the CO2 ETS costs
So it will include investment costs for carbon capture, CO2 infrastructure, storage of CO2 and CO2 ETS costs

Notifying @ChaelKruip @MartLubben
A few tips:

It would be good to remove many of the costs queries that we use at the moment and start building the new queries from scratch. This current queries are messy and hard to understand
It would be good to add the categories one by one
We will probably have to revise the node-groups that are used for our cost calculation
Keep it simple :)

This issue is closed by #3927


exception from the observatory backend

When sending the observatory a command via the json-rpc protocol, it throwing an exception (an NPE trying to get the keys property of a map) if the params field is not sent in. This is for method calls that do not take args, like getVM.
NoSuchMethodError: method not found: 'keys'
Receiver: null
Arguments: []
Stack Trace:
#0      Object._noSuchMethod (dart:core-patch/object_patch.dart:42)
#1      Object.noSuchMethod (dart:core-patch/object_patch.dart:45)
#2      _HashVMBase&MapMixin.addAll (dart:collection/maps.dart:58)
#3      Message.Message.fromJsonRpc (message.dart:39:12)
#4      WebSocketClient.onWebSocketMessage (server.dart:32:29)
#5      WebSocketClient.WebSocketClient.<anonymous closure> (server.dart:14:32)

@johnmccutchan

I'm pretty sure I fixed this last week, but in the meantime, send an empty params map
{
"method": "getVM"
"params": {}
}

Yup, I switched to sending that, I just want to give you a heads up :)

This is for 1.11.0-dev.5.2.

This was fixed in 983395f5f3d9d0714bf0e6ed47e58ac16ca47341


Example electron test

going to merge this one @lf94 I forgot playwright doesn't run on PRs not pointed at main. I shouldn't conflict, I'm mostly working in my own corner.


Multiple application support documentation - Wiki

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[ X] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

We are using Angular Seed for our application, would like to add one more application to the same repository so that we can use the same seed.. I do not see any documentation/Wiki for instructions on this
Expected behavior

If there is any Wiki on how to add an application to the existing angular Seed, that would be great
Minimal reproduction of the problem with instructions

Add an application to the existing Angular seed application
What is the motivation / use case for changing the behavior?

Add multiple applications to the same Angular Seed so that base configuration can be reused
Please tell us about your environment:

Windows 10, WebStorm

Angular Seed Version: aaaaf75

Node: node --version = 7.4

Hey @skolli853780, you can use the same seed instance for multiple applications following these practices:

Create directory in src/client/APP_NAME.
Inside src/client/APP_NAME you should have main.ts (and main-prod.ts for you want to use AoT).
Run your dev build with: npm start -- --app APP_NAME and your production: npm run build.prod -- --app APP_NAME.

Thank you..


Would like to write an article on mlops

Description
points to be covered in the blogs:
top tools used in mlops
what is the fiel dof mlops
Published Link
No response
🔄 Websites
Medium
Checklist ✅

[X] I checked and didn't find similar issue
[X] I am from GSSoC23
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no)

@hardiksharma02 assigned


feat: Implement target selectors for policies.

What this PR does / why we need it:
This PR implements target selectors for policies
Which issue(s) this PR fixes:
Fixes #3607

/retest

@arkodg, @liorokman, I installed v1.1.0-rc.1 and tried to create a SecurityPolicy with the target selectors. It failed on validation. #3901 is logged for this.


merge from arlac77/npm-package-template-esm-only

package.json

chore(package<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 -x 'tests/**' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   93.05%   93.05%
=======================================
  Files           6        6
  Lines         216      216
  Branches       39       39
=======================================
  Hits          201      201
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d455c01...9992116. Read the comment docs.

:tada: This PR is included in version 1.0.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


rmsd: init at 1.5.1

Description of changes
Adds the python package RMSD, used to calculate alignment of coordinate sets. Part of the ongoing effort to upstream packages from NixOS-QChem, see https://github.com/markuskowa/NixOS-QChem/issues/146
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build python3Packages.rmsd


Add footer to the project

Hi @Nejjari001

I added a footer to the project you can review that.
Kindly check my pull request.

Thank You.

Hi @SaboorSohaib  ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
good job following the instructions of the previous CR
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.


[Event Request] page 5703 "Location Card" - OnAfterUpdateEnabled

Could you please add the following event?
procedure UpdateEnabled()
begin

  ...

    UseADCSEnable := not Rec."Use As In-Transit" and Rec."Directed Put-away and Pick";
    PickAccordingToFEFOEnable := Rec."Require Pick" and Rec."Bin Mandatory";
    OnAfterUpdateEnabled(Rec); //NEW
end;

[IntegrationEvent(true, false)]
local procedure OnAfterUpdateEnabled(Location: Record Location)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add a method on map to reorder layers

See #451.
Possible interface:

Using a permutation array map.layerOrder([0, 3, 1, 2]), where the numbers are the indices of layer in map.layers().
map.layerOrder() returns the current permutation array.
Using a compare function  map.layerOrder(function (layer1, layer2) {...}) à la Array.prototype.sort

I am unclear what map.layerOrder() would return - wouldn't it always be an array [0, 1, 2, 3, ..., N-1]? If not, that means there is some internal permutation state that the user needs to be aware of which seems overly burdensome to maintain and understand. I would expect the internal list of layers is directly modified instead of having a separate permutation. So I'd vote against the second bullet, and question the value of the first bullet.

Thats the complication I brought up in #451. What I'm proposing is that what is returned by map.children() would only change by adding or removing a layer.  The display order would be decided solely by the z-index property.  The return value of map.layerOrder() would be computed on demand.
Ex the defaults would look like this:
>>> map.children()
[{id: 0, 'z-index': 0}, {id: 1, 'z-index': 1}, {id: 2, 'z-index': 2}]
>>> map.layerOrder()
[0, 1, 2]

Then reordering:
>>> map.children()[1].moveUp()
>>> map.children()
[{id: 0, 'z-index': 0}, {id: 1, 'z-index': 2}, {id: 2, 'z-index': 1}]
>>> map.layerOrder()
[0, 2, 1]

>>> map.children()[1].moveDown()
>>> map.children()
[{id: 0, 'z-index': 0}, {id: 1, 'z-index': 1}, {id: 2, 'z-index': 2}]
>>> map.layerOrder()
[0, 1, 2]

>>> map.children()[0].moveUp(2)
>>> map.children()
[{id: 0, 'z-index': 2}, {id: 1, 'z-index': 0}, {id: 2, 'z-index': 1}]
>>> map.layerOrder()
[2, 0, 1]

etc.
I am open to changing these semantics if it is too confusing.  One reason, I don't want to have the display order determined by the place in the children array is because it uses the css z-index, which could change independent of the geojs api.  Also, I have been using the convention in a few applications where I'm storing the index of the layer as a kind of serialization so that I get it back by map.children()[iLayer].
One idea I've had for a while is to allow naming layers so that map.layers() would return an object mapping layer names to layer objects.  This would certainly help confusion because an object would imply no ordering.

Ah, ok. Thinking a bit more, I think if there is direct z-index setting capability, permutation ordering (i.e. what this issue is all about) seems like it may not be a great idea in general, since the two modes of ordering could conflict with each other.

What I mean is: there is a consistent way to have both, but it's a different mental model.

I took convention when permuting to swap z-index values rather than try and do anything smarter.  So if you start with a set of z-indices {0, 5, 100}, layerOrder or moveUp/moveDown will always retain the same set.  Only a call to layer.zIndex will change it.  I had originally though about making zIndex protected, but I think there could be some legitimate public use cases.

Done in #451.


allow transaction from another sender for identity tx

Currently we require a transaction sent from the public key that the overlay derivation is based on. This makes running a bee node with swap disabled difficult as sending a tx from the internal or the clef key in that case is quite difficult.
Instead of requiring the tx to be signed from that account we could also accept an additional type where the tx data matches the eth address for which the proof is for. Then the identity tx can also be created using any wallet which supports tx data.
As the required data for every address is different this still should enforce the same security as the current approach. It is good to support both types as nodes with chequebook will already have a tx satisfying the current type.

done


feat: add help prompt functionality to merged mining

Description

Adding help prompt button and functionality to MergedMining box.

Motivation and Context
#185
How Has This Been Tested?

Unit tests

https://user-images.githubusercontent.com/69508715/169555091-3ea85340-670a-4cc5-90e5-b7d5a0528f06.mov
https://user-images.githubusercontent.com/69508715/169555158-cd9d9dc0-91ea-49f8-9c94-8bb64c46a3a3.mov

you'll probably not like it, but I've got two thoughts when looking at the last recording:

the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?

you'll probably not like it, but I've got two thoughts when looking at the last recording:

the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?

This isn't covering the TBot / message animations at all, that's coming in another PR where I'll do the timing and sequencing with the loading dots, etc.

you'll probably not like it, but I've got two thoughts when looking at the last recording:

the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?

This isn't covering the message animations at all, that's coming in another PR where I'll do the timing and sequencing with the loading dots, etc.

ah! that makes sense then @2
if @1 is also coming in next PR I'm good

I'm assuming changes in TBot animation come later

Yes 👍


Cell type terms required by GO

 * AV bundle cell
 * DCT cell
 * His-Purkinje system cell
 * Malpighian tubule principal cell
 * Malpighian tubule stellate cell
 * Malpighian tubule tip cell
 * R1/R6 cell
 * R2/R5 cell
 * R3/R4 cell
 * R7 cell
 * R8 cell
 * S1 cell
 * T1 stage B cell
 * T2 stage B cell
 * abventricular progenitor cell
 * adrenal chromaffin cell
 * anterior lateral line ganglion neuron
 * anterior lateral line nerve glial cell
 * anterior lateral line neuromast hair cell
 * anterior lateral line neuromast mantle cell
 * anterior lateral line neuromast support cell
 * axial mesoderm cell
 * camera-type eye photoreceptor cell
 * candelabrum cell
 * cardiac blood vessel endothelial cell
 * cardiac endothelial cell
 * cardiac fibroblast cell
 * cardiac glial cell
 * cardiac neuron
 * cardiac septum cell
 * cardiac vascular smooth muscle cell
 * carotid body glomus cell
 * central nervous system neuron
 * cerebellar Golgi cell
 * cerebellar Purkinje cell
 * cerebellar basket cell
 * cerebellar stellate cell
 * cerebellar unipolar brush cell
 * cerebral cortex GABAergic interneuron
 * cerebral cortex neuron
 * chorionic trophoblast cell
 * chromatophore precursor
 * collenchyma cell
 * compound eye cone cell
 * compound eye photoreceptor cell
 * definitive RBC
 * early stripe melanocyte cell
 * embryo sac central cell
 * embryonic arthropod blood cell
 * embryonic plasmatocyte cell
 * endocardial cushion cell
 * endocardial precursor cell
 * epicardium-derived cardiac endothelial cell
 * epicardium-derived cardiac fibroblast cell
 * epicardium-derived cardiac vascular smooth muscle cell
 * extrathymic T cell
 * forebrain astrocyte
 * forebrain neuron
 * forebrain radial glial cell
 * gLL neuron
 * germarium-derived oocyte
 * glomerular epithelial cell
 * glomerular parietal epithelial cell
 * growth plate cartilage chondrocyte
 * heart valve cell
 * hypothalamus cell
 * hypothalamus gonadotrophin-releasing hormone neuron
 * inner cell mass cell
 * intermediate mesoderm cell
 * internal mammary gland bud epithelial cell
 * juxtaglomerulus cell
 * kidney smooth muscle cell
 * late stripe melanocyte cell
 * lateral line nerve glial cell
 * lateral mesoderm cell
 * lens fiber cell morphogenesis during
 * limb basal epidermal cell
 * limb granular cell
 * limb spinous cell
 * lung basal cell
 * lung cell
 * lung ciliated cell
 * lung epithelial cell
 * lung goblet cell
 * lung neuroendocrine cell
 * lung secretory cell
 * male gametophyte sperm cell
 * mammary gland epithelial cell
 * mature dendritic cell
 * mechanoreceptor
 * medial motor column neuron
 * mesonephric glomerular epithelial cell
 * mesonephric glomerular mesangial cell
 * mesonephric glomerular parietal epithelial cell
 * mesonephric interstitial cell
 * mesonephric juxtaglomerulus cell
 * mesonephric mesangial cell
 * mesonephric mesenchymal cell
 * mesonephric nephron tubule epithelial cell
 * metanephric DCT cell
 * metanephric glomerular epithelial cell
 * metanephric glomerular mesangial cell
 * metanephric glomerular parietal epithelial cell
 * metanephric interstitial cell
 * metanephric juxtaglomerulus cell
 * metanephric mesangial cell
 * metanephric mesenchymal cell
 * metanephric nephron tubule epithelial cell
 * mystery cell
 * nephron tubule epithelial cell
 * neural crest-derived cardiac fibroblast cell
 * neural crest-derived cardiac glial cell
 * noradrenergic neuron
 * ocellus photoreceptor cell
 * paraxial mesodermal cell
 * peripheral mammary gland bud epithelial cell
 * peripheral nervous system neuron
 * polarized epithelial cell
 * posterior lateral line ganglion neuron
 * posterior lateral line nerve glial cell
 * posterior lateral line neuromast hair cell
 * posterior lateral line neuromast mantle cell
 * posterior lateral line neuromast support cell
 * pronephric nephron tubule epithelial cell
 * renal vesicle progenitor cell
 * retrotrapezoid nucleus neuron
 * rhombomere cell
 * root epidermal cell
 * root hair cell
 * satellite cell
 * sebaceous gland cell
 * seed hair
 * sepal giant cell
 * socket cell
 * somatic motor neuron
 * sorocarp spore cell
 * spermatid nuclear
 * spinal cord association neuron
 * spinal cord oligodendrocyte cell
 * spinal cord radial glial cell
 * spongiotrophoblast
 * sporocyte
 * stomach neuroendocrine cell
 * striatal medium spiny neuron
 * tapetal cell
 * ureter epithelial cell
 * venous endothelial cell
 * ventral spinal cord interneuron
 * ventricular cardiac muscle cell
 * vessel element cell
 * visceral motor neuron

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 Feb 2013 at 8:34

WARNING: This issue has been automatically closed because it has not been updated in more than 3 years. Please re-open it if you still need this to be addressed – we are now getting some resources to deal with such issues.


goto v0.5 of login plugin

pull in the fix for @csrwng 's "ec2" scenario
@bparees fyi

[test]

test passed ... merging


Add video link

This video was particularly helpful for me to get an understanding of what each of these technologies are and their differences.

Hello @samuelwine ... We can't (usually) cross-link to videos (or blogs for that matter) due to framework churn. They go stale rather quickly. We don't have the capacity to keep up with all of the content in videos and blogs relative to each release. The framework changes, but videos and blogs are rarely ever updated by their authors ... even MS video and blog resources.

That makes sense!
Thanks for responding.


[CT-1587] [Feature]  Allow ephemeral models to be temporary tables

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Add support to materialize ephemerals as temporary tables instead of just inserting the code as a cte.
Cte are slow and a full materialized table is not always required.
This way we preserve the ephemeral purpose improving speed.
Describe alternatives you've considered
Instead of using an ephemeral materialization use table in another schema and have a post-hook that deletes the table.
Who will this benefit?
Everyone using ephemeral models to add modularity and that use intermediate-intermediate models as tables for performance when they're not actually needed.
Are you interested in contributing this feature?
yes but will take time
Anything else?
No response

Thanks for suggesting this idea @rloredo!
Between this and #6234, it seems like temp tables are in the air ❄
The general idea of your feature suggestion has these essential qualities:

Provide a table-based alternative to ephemeral materializations
Don’t persist such tables beyond the end of dbt execution

I think the alternative you suggested using an on-run-end hook is the way to go for achieving those goals! 💥
"Temp" tables within a dbt "session"
Here’s a concrete example of using on-run-end hooks to mimic the behavior of Snowflake temporary tables (taken from here):
my_data.sql
{{ config(materialized="table") }}

select ...
from {{ ref('my_other_dbt_model') }}

dbt_project.yml
on-run-end:
  - "drop table if exists {{ ref('my_data') }};"

Rationale
Here are a few reasons for this approach (rather than an ephemeral materialization variant that uses Snowflake’s temporary tables):

This approach is already possible today
It works across other dbt adapters beyond just Snowflake
It avoids re-materializing the table each time it is referenced. If it is used 3 times, it is still only created 1 time and then dropped at the end of the dbt execution

A key drawback of an approach that uses the ephemeral approach with temp tables is that it would end up re-creating the table every time it is referenced. If it is used 3 times, then it would be re-created 3 times.
Are there any good reasons that I’m overlooking for using Snowflake-native temp tables instead?

It avoids re-materializing the table each time it is referenced. If it is used 3 times, it is still only created 1 time and then dropped at the end of the dbt execution

I think the idea was not re-materialize the snowflake-native table each time is referenced. Right now a model marked as ephemeral is  implemented as a CTE  that is re-evaluated" for each other  model that reference it.
My expectation (and I think  @rloredo is the same) would be that the ephemeral would be implemented as a snowflake-native temp table that is materialized once for the whole run and will be reused for all models that reference it , the same way a "full materialized table" model (deleted at the on-run-end) would be.
Maybe this changes the meaning of "ephemeral" on dbt as per current documentation and that is what the confusion is.
I guess a new materialization called "temporary" would be maybe more correct in the sense that "temporary" is could would not have the same Pro/Cons as the current ephemeral Cons and Pros . This new materialization could be implemented as snowflake-native temp table in snowflake or as a regular table materialization with random suffix in the table name and an  implicit drop at the end of the run on other databases.

Are there any good reasons that I’m overlooking for using Snowflake-native temp tables instead?

in projects with lots of these  temp tables you will get lots of DROP TABLE IF EXISTS at the end of the run

this will happen regardless if the dbt run actually created these tables or not. For example if I have 50 of this temporary tables, and I do dbt run --select "+the_model_im_working_on_that_uses_0_temp_tables"  I would see 50 DROP TABLE commands that are superflous, add some delay to the operation, and clutter the query log.  If using snowflake-native temp tables this won't happen, we won't see the explicit DROP TABLE commands, and no delay will happens waiting for the 50 drops to finish.
it temporarily clutters the schema with many temporary table that are visible to other users.  Snowflake-native temp tables are only visible in the current session, other users or even other sessions for the same user can't see those.

Snowflake-native temp tables like transient tables, are not part of the "Time Travel" so there are some savings on storage cost for that as well.

I completely agree with @ecerulm response above. The "temporary"-feature would be really nice for BigQuery as well.
I don't know why "triage" was removed without any further comments? I'm sure this feature would be helpful to a lot of people.

I've only used "desktop" databases (ie, postgresql, mysql) and Snowflake. I believed that temporary tables are ubiquitous, but I'm assuming from an above comment (the second rationale here) that they may not be?
In my case I am generating ID's in an intermediate model to be used in a couple of downstream models. For me the session-only visibility, no time travel, and throwaway nature of a temporary table would be helpful.


Py_Initialize: can't initialize sys standard streams error when creating a kernel

Description of your problem
IPython console fails to start
What steps will reproduce the problem?

Launch Spyder 3.1.3 (same pb. with 3.1.4)
IPython console fails to start

**What is the expected output?
IPython console start
What do you see instead?**
An error ocurred while starting the kernel
Fatal Python error: Py_Initialize: can't initialize sys standard streams
OSError: [Errno 9] Bad file descriptor

Current thread 0x00007fffc12213c0 (most recent call first):
Fatal Python error: Py_Initialize: can't initialize sys standard streams
OSError: [Errno 9] Bad file descriptor

Please provide any additional information below
Versions and main components

Spyder Version: 3.1.3 (BTW : I add the same pb. with 3.1.4)
Python Version: 3.6.1
Qt Version: 5.6.2
PyQt Version: 5.6.0
Operating system: Mac OS X 10.12.5

Dependencies
jedi =0.9.0      :  0.9.0 (OK)
matplotlib >=1.0 :  2.0.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
numpy >=1.7      :  1.13.0 (OK)
pandas >=0.13.1  :  0.20.2 (OK)
pep8 >=0.6       :  1.7.0 (OK)
psutil >=0.3     :  5.2.2 (OK)
pyflakes >=0.6.0 :  1.5.0 (OK)
pygments >=2.0   :  2.2.0 (OK)
pylint >=0.25    :  1.6.4 (OK)
qtconsole >=4.2.0:  4.3.0 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
sphinx >=0.6.6   :  1.6.2 (OK)
sympy >=0.7.3    :  None (NOK)

Sorry, I have no idea why this is happening.
@minrk or @takluyver, have you seen this error before?

Does spyder do anything to redirect standard streams? I wonder if the kernel is trying to inherit its standard streams from the parent process, and picking up something that's not a valid fd.

Can you please fix this issue before releasing Spyder 3.2 because I do need the IPython console for debugging with Spyder ?

@takluyver I think I understand a little bit of your question.
If I run Spyder with this command :
spyder &
exit

the IPython console cannot start, but if I run it with this command spyder & without existing the calling shell before Spyder+IPython finishes to start, it seems to work.
Hope this helps you fixing this.

Does spyder do anything to redirect standard streams?

Yes, we redirect the kernel stderr output to a file, as can be seen here
https://github.com/spyder-ide/spyder/blob/master/spyder/plugins/ipythonconsole.py#L1293
but we haven't seen other errors as the one reported here, so I don't know why this is happening.

@sebma, I can't reproduce this on Linux and I don't even know how to address this, sorry.
But at least you have a temporary solution.

Where do you run those lines? Are you typing them into a shell, or using them in some sort of script?

@takluyver On macos, I'm typing them into a shell

OK, so you close the shell, which presumably results in the terminal it's running in being cleaned up. So the standard stream fds Spyder is using are invalidated. I can kind of reproduce something similar with the Qtconsole on Linux - calling sys.__stderr__.flush() after exiting the terminal I launched it from gives me [Errno 5] Input/output error.
It's up to @ccordoba12 , but I'd be inclined to compare the situation to this old joke:

Doctor, it hurts when I do this!
Don't do that.

@takluyver, yep, that's my feeling about this situation ;-)
@sebma, I don't know how we could fix this because if you abruptly remove the carpet under which Spyder is running, then things are expected to fail.
@takluyver, thanks a lot for chiming in!

I don't want any spyder on my carpet !
Let them do what they were created for : catching mosquitoes from their web and eating.
LOL


Improve the error for missing trust policy

What is the areas you experience the issue in?
Notation CLI
What is not working as expected?
The current response is:
notation verify $APPLICATION_IMAGE
Warning: Always verify the artifact using digest(@sha256:...) rather than a tag(:kubeconeu-demo-v1) because resolved digest may not point to the same signed artifact, as tags are mutable.
Error: open trustpolicy.json: no such file or directory

What did you expect to happen?
Similar behavior as in #620
How can we reproduce it?
Delete the trust policy file and try to verify image
Describe your environment
N/A
What is the version of your Notation CLI or Notation Library?
Notation: Notary v2, A tool to sign, store, and verify artifacts.
Version: 1.0.0-rc.3
Go version: go1.20.1
Git commit: https://github.com/notaryproject/notation/commit/233c0ea71edfb68b951eb54a739a101e2a05cd26

Need to design what the error message should look like before implementation.

Closed as fixed by PR https://github.com/notaryproject/notation-go/pull/311 in notation-go

@yizha1 I do not see the design for the error message. Is this documented somewhere in guidelines how we should handle error messages?

@toddysm Sorry to update the error message for this specific case.
If the trust policy is not created,
The original error message is Error: open trustpolicy.json: no such file or directory
The new one is:
Error: trust policy is not present. To create a trust policy, see: https://notaryproject.dev/docs/quickstart/#create-a-trust-policy
After this is fixed, the troubleshooting guide will be updated accordingly. The current https://notaryproject.dev/docs/troubleshooting/#when-i-verify-an-artifact-i-get-the-error-error-open-homeconfignotationtrustpolicyjson-no-such-file-or-directory, I will create an issue for it.
Do you mean other document that we need to create for all the error messages for trust policy handling or else?

update milestone to v1.0.0-rc.6 per discussion in community call on 5/22/2023

Ok, this seems friendlier. Thanks!

Closing this issue as we have reached agreement. (This issue is fixed by PR https://github.com/notaryproject/notation-go/pull/311 in notation-go.)


Whats the url for Teams Admin center ?!

cant see it !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b51b67a-d89c-723f-3520-87cb2dc93b90
Version Independent ID: 78d10cbc-d75b-2b02-d49c-2c3fe1579807
Content: Manage teams in the Microsoft Teams admin center - Microsoft Teams
Content Source: Teams/manage-teams-in-modern-portal.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@andyjballgit  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@andyjballgit thank you for reaching out and helping improve MS Docs. Please have a look here - https://answers.microsoft.com/msoffice/forum/all/teams-admin-center/35f61cd0-d69e-4db0-a94f-1489b5807f43

@andyjballgit Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

https://admin.teams.microsoft.com/dashboard


Side-By-Side comparison adds extraneous escape

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest version
[X] Search the existing issues.

Steps to reproduce
$rightText = @("  This is other", "example text used!") -join [Environment]::NewLine
$leftText = @("This is some", "example text.") -join [Environment]::NewLine
compare-text $leftText $rightText -view side | out-string -str | %{$_.replace("`e","``e")}

Expected behavior
the escape sequence should be correct

Actual behavior
The output looks as follows:

`e[0m1 | `e[0mThis is `e[1;9;31msome`e[0m`e[0m `e[0m | `e[0;1;32m  `e[0mThis is `e[0;1;32mother`e…`e[0m
`e[0m`e[0m`e[1;9;31m`e[0m`e[0m`e[0m`e[0;1;32m`e[0m`e[0;1;32m`e[0m2 | `e[0mexample text`e[1;9;31m.`e[0m`e[0m | `e[0mexample text`e[0;1;32m…`e[0m

before the ellipsis of the first line of output there is an extraneous "`e" (or perhaps an escape sequence which is incomplete)

Error details
there is no error

Environment data
Name                           Value
----                           -----
PSVersion                      7.3.0
PSEdition                      Core
GitCommitId                    7.3.0
OS                             Darwin 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Version
0.4.0 preview2
Visuals
No response

it looks more like the truncation is not tracking whether it's in the middle of an escape sequence

Use PSStyle class to remove escape sequences to calculate length/width correctly


The "expand" button for the bottom panel has disappeared.

Type: Bug
Previously, there was an "expand" button right here (as shown in the screenshot).

This button would expand the bottom panel to full screen. It seems to have disappeared in one of the versions. Is there a way to bring it back through settings? That button was extremely convenient for me.
Thank you.
VS Code version: Code 1.84.1 (2b35e1e6d88f1ce073683991d1eff5284a32690f, 2023-11-06T12:37:31.808Z)
OS version: Darwin arm64 23.1.0
Modes:

What alignment option have you set for the Panel?

@gjsjohnmurray oh you are right, thank you


[modify][gws][schedule] add cur_user and cur_group options to portlet's schedule_member_mode

Coverage decreased (-0.6%) to 84.171% when pulling 75ee215a8450d5bb12e1bddca0acc4608688c280 on sunny4381:feature/gws-schedule-portlet into 5edac7d88ff9a76b90585524ff4f7361feb163a1 on shirasagi:master.

Coverage decreased (-0.6%) to 84.171% when pulling 75ee215a8450d5bb12e1bddca0acc4608688c280 on sunny4381:feature/gws-schedule-portlet into 5edac7d88ff9a76b90585524ff4f7361feb163a1 on shirasagi:master.


Rewrites AVAudioSession outputVolume KVO using Swift 4 key path syntax

Thank you, I've been meaning to clean up that mess, this is great. 👍


How to get CVV number?

I see it returns card number, first name, last name, expire month and year. How can i get CVV number?

@shafiqhossain as far as I know, credit card readers/swipers don't provide cvc/cvv number in data string. So you need to paste cvc/cvv number manually.

That is correct. The CVV isn't in the magnetic stripe data at all.


Compability with i18next version > 2 ?

With i18next version 2.0.21 I got undefined error, it seems that i18next.functions does not exist:
https://github.com/jcbvm/require-i18next/blob/master/require-i18next/i18next.js#L13

Currently I've not tested yet with version 2.0, will update soon.


Dynamic ops

With this PR, we introduce dynamically generated TRTEngines, that is TRT Engine construction time is postponed to execution time to support graphs where shape inference fails.

Is that related or flaky?
147/375 Test #144: T:/src/github/tensorflow/tensorflow/python/kernel_tests/fifo_queue_test.py ..............................................***Failed   24.19 sec
......................................................................FF.........
======================================================================
FAIL: testResetOfBlockingOperation (__main__.FIFOQueueTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "T:/src/github/tensorflow/tensorflow/python/kernel_tests/fifo_queue_test.py", line 1299, in testResetOfBlockingOperation
    t.join()
  File "C:\Python35\lib\site-packages\tensorflow\python\framework\test_util.py", line 1032, in join
    self._testcase.fail("Error in checkedThread: %s" % str(self._exception))
AssertionError: Error in checkedThread: Exception of type <class 'tensorflow.python.framework.errors_impl.CancelledError'>: Session has been closed.
======================================================================
FAIL: testResetOfBlockingOperation (__main__.FIFOQueueTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Python35\lib\site-packages\tensorflow\python\framework\test_util.py", line 738, in tearDown
    thread.check_termination()
  File "C:\Python35\lib\site-packages\tensorflow\python\framework\test_util.py", line 1065, in check_termination
    self._testcase.fail("A checked thread was not joined.")
AssertionError: A checked thread was not joined.
----------------------------------------------------------------------

@drpngx it is very unlikely the error is because of this PR. This module is disabled on Windows builds.

Thanks for checking! Let's see what @aaroey has to say.

@aaroey I am getting issues with model tests but these seem to be related with current state of the master. FATALs are happening during execution of native graphs. Our tests pass fine.


Added new fields - index, type and score for Hit

Added a new test for score.

Thank you for your contribution @sunilalmond !


Implementations of FinishedSpan [start\end]Timestamp use inconsistent units

Describe the bug
FinishedSpan defines two long-returning methods, getStartTimestamp() and getEndTimestamp(). The return type and the documentation don't really enforce a precision / unit of time. Looking at the three implementations of FinishedSpan, it appears they are indeed inconsistent:

SimpleSpan uses milliseconds (btw the fields are named endMicros, but they're initialized via Clock#wallTime())
OtelFinishedSpan uses nanoseconds (via SpanData#getStartEpochNanos())
BraveFinishedSpan uses microseconds (via Span#start(long) and clock.currentTimeMicroseconds())

(Environment omitted as this is an API design issue)
To Reproduce
I discovered this issue while writing a SampleTestRunner integration test (see micrometer-tracing-integration-test), trying to sanity-check the approximate duration of each span.
There might be other rare cases where an OTel/Brave span is compared to eg. a SimpleSpan?
Expected behavior
I would like to avoid pondering which unit is used by an arbitrary FinishedSpan when dealing with timestamps. Currently, one needs to look at the concrete class or at least ensure that two compared spans are of the same concrete class.
Suggested improvements, In order of least-breaking to most-breaking:

introduce a synthetic Duration getDuration() method that computes the duration of the span from its two timestamps (interpreting each as the relevant unit)
deprecate the two timestamp methods and introduce alternatives returning an Instant
break the API and change the return type from long to Instant

Note that the getDuration() would be a bonus in any case.

We've decided to go with option no 3.


Tag with list widget don't add escape

Hi,
my tag list widget no longer accepts spaces since the last update.
  '- label: "Tags"       name: "tags"       widget: list       required: false'
i use this script for use decap :
** **

important to fix this

Hi @Juniors017, please fill out all the fields in the issue template. The information you provided is not enough to debug the problem.
I'm closing the issue for now. Once you add the missing information, I can open it again.


manual bootstrap and ngAnimate

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (see above))

Current behavior:
NgAnimate throws this error:

$$animateJs is not a function

Expected / new behavior:
NgAnimate don't throw an error.
Minimal reproduction of the problem with instructions:

Fetch data from the Server before angular is bootstraped (or a timeout)
Manual bootstrap the application
See same error in the console which can be prevented if you set $animate.enabled(true); in the config block
Have a hyperlink element like Click me ('site/test' is in the same application just a different view for ng-view)
Press the hyperlink with the middle mouse button
$$animateJs is missing in the new tab for $$AnimateJsDriverProvider

Angular version: 1.6.4
Browser:
Could only be produced in Chrome 58.0.3029.110 (64-bit), works fine in IE 11.0.42 and Firefox 53.0.3
Anything else:
Like i said in "6." $$animateJs isn't just missing at the beginning. It's missing till you refresh the application on the new tab

Out of curiosity, are you using something like ocLazyLoad or anything to lazy load certain things ?

Hello @frederikprijck,
Yes i'm using ocLazyLoad and thanks for both of the issues, didn't find the first one here.
So it's not a problem from angular but from ocLazyLoad. The moment i injected $$animateJs as a dependency for the ocLazyLoad function it worked.
Also $animate.enabled(true); is not required anymore if it is injected in the ocLazyLoad function.
But weird that this error only occured in Chrome.
Thanks again for your time, i wasted hours into this.


implement Call.call function

Coverage decreased (-0.003%) to 40.497% when pulling 2cc120027fa78f686c14d4e10646ea247600b40a on u9520107:enhance/call into 7329a360fe60412f65c8adf34503e33b295a78d3 on ringcentral:master.


enums comments should be displayed as the method comments and not inline

Doesn't it look weird to you ?

Also the "-" is not necessary as the styles are different enough


APEXCORE-578: Amend javadoc syntax

@tweise  please review and merge.

By mistake created APEXCORE jira.


fix: show zero for negative prices

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
#1069
What's this PR do?

Fixes the frontend when discount price is more then actual price and the price shows negative value.

How should this be manually tested?
Good steps mentioned in #1069
For Reviewer
Are there any other places you think this should be fixed too?
Screenshots (if appropriate)

@jkachel In this specific case we are actually calculating the prices on the frontend, I fixed this in the display format function to make it applicable in all the places that it uses. Does this make sense, or there might be some other way you would have liked this to be fixed?


Integration Test - Release - 2019/09/06 21:42:56

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


ensure project.properties are in place

project properties removed in latest build system (poms 2.0,0)


[dynamic-igemm][bwd-xdlops]enable asm igemm generic tensor contraction for backward_data

To reduce compilation time, re-implement the implicit gemm in assemble, and make parameters dynamic as well.

refactor the asm-igemm to reduce index caculation.
support range is the same as rocm3.7 HIP source code.
avg performance drop within limitation.
perf data and comparison with rocm3.7 HIP  is here: perf_data
validated user cases are here: https://github.com/ROCmSoftwarePlatform/iGEMMgen/blob/master/script/gtc_conv_model.sh

All kernel is in src/kernels/dynamic_igemm/igemm_gtc_bwd/ folder

igemm_bwd_gtc_gfx908.s
igemm_bwd_gtc_gfx908_004x064.inc
igemm_bwd_gtc_gfx908_008x064.inc
igemm_bwd_gtc_gfx908_016x032.inc
igemm_bwd_gtc_gfx908_016x064.inc
igemm_bwd_gtc_gfx908_016x128.inc
igemm_bwd_gtc_gfx908_016x256.inc
igemm_bwd_gtc_gfx908_032x016.inc
igemm_bwd_gtc_gfx908_032x032.inc
igemm_bwd_gtc_gfx908_032x064.inc
igemm_bwd_gtc_gfx908_032x128.inc
igemm_bwd_gtc_gfx908_032x256.inc
igemm_bwd_gtc_gfx908_064x004.inc
igemm_bwd_gtc_gfx908_064x008.inc
igemm_bwd_gtc_gfx908_064x016.inc
igemm_bwd_gtc_gfx908_064x032.inc
igemm_bwd_gtc_gfx908_064x064.inc
igemm_bwd_gtc_gfx908_064x128.inc
igemm_bwd_gtc_gfx908_064x256.inc
igemm_bwd_gtc_gfx908_128x016.inc
igemm_bwd_gtc_gfx908_128x032.inc
igemm_bwd_gtc_gfx908_128x064.inc
igemm_bwd_gtc_gfx908_128x128.inc
igemm_bwd_gtc_gfx908_128x256.inc
igemm_bwd_gtc_gfx908_256x016.inc
igemm_bwd_gtc_gfx908_256x032.inc
igemm_bwd_gtc_gfx908_256x064.inc
igemm_bwd_gtc_gfx908_256x128.inc

perf data can be found in:
https://github.com/AMDComputeLibraries/MLOpen/issues/2535

@atamazov,
Hi artem, would you help to review this PR, since it's scheduled to meet the 3.10 release. thks

@jane-zxy Please add a kernel list which you validated for applicability.

@DrizztDoUrden Please review invokers.

@jane-zxy Please add a kernel list which you validated for applicability.

ok, I've add this infor into this pr's description.

I am beginning the reviewing process. At first I need to better understand what is the essence of the proposed changes.

To reduce compilation time, re-implement the implicit gemm in assemble, and make parameters dynamic as well.

The PR doesn't reduce compilation time. It adds new solver at the end of GetImplicitGemmSolvers(). In normal Find mode this can't lead to better wall time. Perhaps you means some other Find mode? Let's make the description formally valid at least.

refactor the asm-igemm to reduce index caculation.

I do not see any changes in the existing solvers/kernels. Perhaps some of the existing iGemm HIP kernels was copied (which one?) and then that copy has been reworked?

support range is the same as rocm3.7 HIP source code.

Could you please elaborate? Do you mean then the new Solver has the same applicability as some other existing Solver?

avg performance drop within limitation.

What is the limitation?

validated user cases are here: https://github.com/ROCmSoftwarePlatform/iGEMMgen/blob/master/script/gtc_conv_model.sh

What is the ./out/conv_driver.exe used in the script? What kinds of validation have been performed?

perf data can be found in:
AMDComputeLibraries/MLOpen#2535

Please look at https://github.com/AMDComputeLibraries/MLOpen/issues/2535#issuecomment-701453772, there are some important questions that must be answered. Thanks.

Hi @atamazov

The PR doesn't reduce compilation time. It adds new solver at the end of GetImplicitGemmSolvers(). In normal Find mode this can't lead to better wall time. Perhaps you means some other Find mode? Let's make the description formally valid at least.

The goal of these solvers is to add a dynamic version of igemm. and this is implemented in asm, so we add a new solver. These solver will have IsDynamic() return true, so I think this solver will be utilized in find mode that use dynamic

I do not see any changes in the existing solvers/kernels. Perhaps some of the existing iGemm HIP kernels was copied (which one?) and then that copy has been reworked?

I think what @jane-zxy means is refactor some index calculation logic used in original HIP igemm. the existing solver is not changed, and this is a new solver.

Could you please elaborate? Do you mean then the new Solver has the same applicability as some other existing Solver?
Yes, this new solver have same applicability as HIP version backward data. I updated the applicability table in https://github.com/AMDComputeLibraries/MLOpen/issues/2535

What is the limitation?
Previous we sync with Daniel, that average performance drop should within 10% compared to HIP version. So according to current result in https://github.com/AMDComputeLibraries/MLOpen/issues/2535, we have some cases better than HIP, some worse than HIP, and the average is improved.

What is the ./out/conv_driver.exe used in the script? What kinds of validation have been performed?
Since we use https://github.com/ROCmSoftwarePlatform/iGEMMgen to generate all the asm kernels in these PRs, so in that repo we have a small host driver code (accept the same commandline args as MIOpenDriver), then we do layer wise validation & performance measue listed in gtc_conv_model.sh. And again, after integrate into MIOpen, we also run that script with MIOpenDriver, force to use the solver in these PR.

@carlushuang

Let's make the description formally valid at least.

Thanks for the explanations. Please update PR description. It still confuses the reader.

Previous we sync with Daniel, that average performance drop should within 10% compared to HIP version. So according to current result in AMDComputeLibraries/MLOpen#2535, we have some cases better than HIP, some worse than HIP, and the average is improved.

What I see looks like huge performance gain that makes HIP solvers unnecessary. However I am not sure if this is correct because some non-standard tool have been used to collect data. I am asking for additional testing round. Please see https://github.com/AMDComputeLibraries/MLOpen/issues/2535

What is the ./out/conv_driver.exe used in the script? What kinds of validation have been performed?

...in that repo we have a small host driver code ... then we do layer wise validation & performance measue listed in gtc_conv_model.sh. And again, after integrate into MIOpen, we also run that script with MIOpenDriver, force to use the solver in these PR.

Please use MIOpenDriver for performance and correctness testing. Please let me know if anything prevents your team from doing so before merging.

Hi @atamazov I've updated the PR description. And for the tool used to measure performance, that is just a tool to speedup the debug/perf-measure process, and after that is done, we also double-checked that perf using MIOpenDriver. Because the tool in iGEMMgen use the same command line arg, so that make the whole process much easier and smooth. Any further information will update in MLOpen#2535