[ENHANCEMENT] Add AWS Security Hub integration with AWS Organizations

Accelerator Version:  (eg. v1.2.3)
Install Type: (Upgrade)
Install Branch: (Standalone)
Upgraded from version: (v1.2.2)

This feature is to simplify the ASEA's codebase and reduce technical complexity by integrating Security Hub with the organization (just announced, more info at https://aws.amazon.com/about-aws/whats-new/2020/11/aws-security-hub-integrates-with-aws-organizations-for-simplified-security-posture-management/).
Implementation:

Designate a Security Hub administrator account (this API call is done in the organization root account across all regions):
AWS CLI: aws securityhub enable-organization-admin-account --admin-account-id <security account ID>

Automatically enable new organization accounts for Security Hub (this API call is done in the security account across all regions):
AWS CLI: aws securityhub update-organization-configuration --auto-enable

Ensure that ALL accounts in the organization are enabled as Security Hub member accounts (this API call is done in the security account across all regions):
AWS CLI: aws securityhub create-members --account-details '[{"AccountId": "123456789111"}, {"AccountId": "123456789222"}]'

Verification:
The  "describe-organization-configuration" AWS CLI command can be performed in the security account to confirm that AutoEnable is to "True". Also, the "aws securityhub list-members --no-only-associated" AWS CLI command can be performed in the security account to confirm that all of the organization's accounts have MemberStatus set to "Enabled".

While possible today, making this enhancement will prevent #497 from being implemented.  Will need to do a more detailed requirements analysis before making this enhancement.

While possible today, making this enhancement will prevent #497 from being implemented.  Will need to do a more detailed requirements analysis before making this enhancement.

As Security Hub has a robust roadmap - suggest NOT altering this codebase in the next 6 months and waiting to see how Security Hub team enhancements improve functionality in this area.

Hello, is this feature being considered for a release?

Whether Org enabled or ASEA enabled - we are still enabling SH in all accounts in the Org.  We've had numerous requests to allow control customization per OU, which can only be implemented if we stay with individually enabled accounts, so we are not planning on this feature at this time.

ASEA not working on new features see README.


man pages no longer available

Issue description
As of latest unstable, man pages for c functions no longer works.
Steps to reproduce
In /etc/nixos/configuration.nix:
  environment.systemPackages = with pkgs; [
    ...
    manpages
    ...
  ];

andy@xps:~$ man memcpy
No manual entry for memcpy

Technical details

System: 16.09pre82105.7465bcd (Flounder)
Nix version: nix-env (Nix) 1.11.2

Ah, well, sections 2 and 3 are in a separate output. In any case, you should get them if you add manpages.docdev.
Perhaps we could have a top-level alias for these. I split them, as those sections seem not needed by most man-page users, and they took the vast majority of space – du reports 8.5 MiB docdev and 1.4 MiB out.

Ah thanks. This makes sense. As a user though I have no way to know that I should update my configuration (apart from your helpful comment). I'm not sure how to solve this problem though apart from reading every commit to nixpkgs!

I also don't know. Note that this isn't much package-specific. man3 pages and gtk-doc are either split or deleted by default.

Why was this issue closed?

@edolstra: do you have a suggestion about what to change?

Propably manpages should not have a split docdev output, or docdev should be installed by default.

At least, I'm assuming that pretty much the only people who install manpages are developers, but I might be wrong about that...

I assumed that C(++) systems programming isn't that common, compared to using (shell) commands, but I don't have any statistics about that. I certainly don't feel strongly about either way.

Example: Debian+Ubuntu split these into manpages-dev package, but our .dev has a bit different meaning than their -dev so it doesn't really seem to fit. Fedora seems not to split them.

Just confirming. The comment says that man 3 and man 2 are kept in docdev. But the expressions seems to only move man 2:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/data/documentation/man-pages/default.nix#L12-L1

@CMCDragonkai: man3 is auto-moved by the generic code https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/setup-hooks/multiple-outputs.sh#L143. I didn't add any general magic for man2 because I couldn't see any package providing them except for explicit manual packages.

Did this ever get resolved?
$ nix-shell -p manpages --run 'man memcpy'
No manual entry for memcpy
$ nix-shell -p manpages.docdev --run 'man memcpy'
error: attribute 'docdev' missing, at (string):1:94

Missing section 3 strikes me as a bug for a standard Linux operating system. Feel free to strip it out of embedded devices, of course. But when lots of utility pages refer to lib pages, it's a poor experience to have them mysteriously missing. (e.g. getopt(1) referring to getopt(3))

Looks like this still isn't solved. Is there a solution ?

Yeah, more or less. See https://nixos.wiki/wiki/Man_pages for how to get man pages (and https://github.com/NixOS/nixpkgs/issues/11501 for context).


Weird error installing php oci8

PHP Warning:  PHP Startup: Unable to load dynamic library 'oci8.so' (tried: /usr/local/lib/php/extensions/no-debug-non-zts-20170718/oci8.so (libclntsh.so.12.1: cannot change memory protections: Permission denied), /usr/local/lib/php/extensions/no-debug-non-zts-20170718/oci8.so.so (/usr/local/lib/php/extensions/no-debug-non-zts-20170718/oci8.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
here is my dockerfile : https://gitlab.com/vitoo/docker-codeception-oci8/blob/master/Dockerfile
i used your example
any idea ?
thank you

Fixed with this commit : https://gitlab.com/vitoo/docker-codeception-oci8/commit/5b1f20497438fbf88a5c82466eaccd9af019447c


turbo fails if there is no lockfile

What version of Turborepo are you using?
all
What package manager are you using / does the bug impact?
npm, pnpm, Yarn v1, Yarn v2/v3 (node_modules linker only)
What operating system are you using?
Mac
Describe the Bug
If we cannot detect a package manager backend either via packageManager key in package.json or through lockfile inference, turbo throws an error. This is problematic for folks using turbo with other languages like Rust or Go where they may not require even installing node_modules
Expected Behavior
If turbo doesn't find a packageManager we should likely fallback to npm for now.
To Reproduce
Run turbo without a lockfile or packageManager key
Suggested Solution
If a lockfile does not exist at the root,  we should alter hashing behavior and still allow task running. Thus, we need to conditionally change conditionally hash lockfile as. a global dependency in npm and pnpm, and in the case of yarn, change how we conditionally resolve external dependencies.

Currently this error also occurs (for me) if packageManager is defined in package.json (but the package manager specific lockfile does not exist).

I'm also having this issue even with the packageManager field set, just like @thasmo<EMAIL_ADDRESS>

On turbo 1.12 turbo will just emit a warning instead of failing.
glob-example on  main [!] via  v21.6.2
❯ rm pnpm-lock.yaml

glob-example on  main [✘!] via  v21.6.2
❯ pnpm build

> glob-example@ build /Users/arlyon/Programming/glob-example
> turbo build

 WARNING  Issues occurred when constructing package graph. Turbo will function, but some features may not be available: could not resolve workspaces: io error: No such file or directory (os error 2)
• Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, web
• Running build in 5 packages
• Remote caching disabled
web:build: cache miss, executing 3965897bf3332cee
docs:build: cache miss, executing 34458b17d801c86b
# rest of build...


fix(module:date-picker): disable year and month selection if set nzDi…

…sabledDate property (#3425)
close #3425

fix(module:date-picker): setting the date after today is not optional, the year and month after today should be disabled

add test

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 3425
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@ZhiDanLuo 感谢 PR。有个地方不太合理：先选了2018年9月，再选择年份，此时2019年不可选。必须要月份小于当前月才行。有无更好的解法？
https://deploy-preview-3589--ng-zorro-master.netlify.com/components/date-picker/zh#components-date-picker-demo-disabled-date

@ZhiDanLuo 感谢 PR。有个地方不太合理：先选了2018年9月，再选择年份，此时2019年不可选。必须要月份小于当前月才行。有无更好的解法？
https://deploy-preview-3589--ng-zorro-master.netlify.com/components/date-picker/zh#components-date-picker-demo-disabled-date

ok, 确实这样。我先把 PR 关闭。有其他方案时再提交。


Failed to (first) start when out of space

I gave a try to elvish as my new shell but there was no space left on my home volume. Elvish has failed to start with the following error:
/: write failed, filesystem is full
warning: cannot create data directory ~/.elvish

(0x91ca00,0xdef020)

, 0x30, 0x999fc0)
        pkg/cli/histutil/store.go:54 +0x26
github.com/elves/elvish/pkg/cli/histutil.initStores(...)
        pkg/cli/histutil/fuser.go:31
github.com/elves/elvish/pkg/cli/histutil.NewFuser(0x0, 0x0, 0x0, 0x0, 0x0)
        pkg/cli/histutil/fuser.go:23 +0x39
github.com/elves/elvish/pkg/edit.NewEditor(0xa8c4e0, 0xc0000840a0, 0xc00010c000, 0x0, 0x0, 0xc00006a358)
        pkg/edit/editor.go:29 +0xd0
github.com/elves/elvish/pkg/program/shell.interact(0xc000010018, 0xc000010020, 0xc000010028, 0xc00010c000, 0xc000029340, 0x11, 0xc00010c000)
        pkg/program/shell/interact.go:25 +0xa7
github.com/elves/elvish/pkg/program/shell.(*Shell).Main(0xc000102200, 0xc000010018, 0xc000010020, 0xc000010028, 0xc0000201b0, 0x0, 0x0, 0x0)
        pkg/program/shell/shell.go:54 +0x320
github.com/elves/elvish/pkg/program.Main(0xc0000201b0, 0x1, 0x1, 0x0)
        pkg/program/program.go:119 +0x1f4
main.main()
        main.go:14 +0x45

goroutine 6 [syscall]:
os/signal.signal_recv(0xc000040787)
        /usr/local/go/src/runtime/sigqueue.go:147 +0x9c
os/signal.loop()
        /usr/local/go/src/os/signal/signal_unix.go:23 +0x22
created by os/signal.init.0
        /usr/local/go/src/os/signal/signal_unix.go:29 +0x41

goroutine 8 [chan receive]:
github.com/elves/elvish/pkg/eval.init.13.func1()
        pkg/eval/port.go:49 +0x53
created by github.com/elves/elvish/pkg/eval.init.13
        pkg/eval/port.go:48 +0x49

goroutine 10 [runnable]:
github.com/elves/elvish/pkg/program/shell.handleSignals.func1(0xc00006a1e0, 0xc000010028)
        pkg/program/shell/shell.go:75
created by github.com/elves/elvish/pkg/program/shell.handleSignals
        pkg/program/shell/shell.go:75 +0x8a

@ant5 What behavior would you prefer? Should elvish simply ignore that it can't create the files to save its state? What do other shells such as bash, ksh and zsh do in the situation you reported for elvish?

I just was scared that some unpredictable things can prevent me to login to a system.   I had not any thoughts about shell reliability before this case.  Now I think that reliability for the shell mean  only the one thing:  be able to start in every (may be bad) circumstances and allow user to execute a commands.
May be, the bad circumstances may be considered in design and elvish will have Plan B to drop all feature for startup ability.

@ant5 I don't fully understand your previous comment since you and I seem to have different primary languages. However, I agree that an elvish interactive shell should continue to run even if it cannot open, or write to, its history file. Elvish should display an appropriate diagnostic and continue to process interactive commands.

since you and I seem to have different primary languages

My poor english had never been noticed in such subtle manner.  :thumbsup:

elvish interactive shell should continue to run even if it cannot...

It will be great cause to switch to elvish as a default shell.

See also issue #126 and #596. Using a text based history mechanism would make it much easier to deal with this scenario. It also makes it much easier for humans to examine the command history file.

Elvish should definitely fail gracefully when the disk is full. Tagging this as a bug and aiming to fix it before the next release.


[WIP] Added support for multus in OCS

Description of your changes:
Multus enables pods to attach multiple networks.
The StorageClusterSpec now includes a network section where user can
specify public network and cluster network which references the
NetworkAttachmentDefinition object in multus.
Note: A working OCP cluster with multus is a prerequisite.
Also NetworkAttachmentDefinition objects should be created before creating the StorageCluster CR.
The StorageCluster CR has the following fields
  network:
    public: ocs-public
    cluster: ocs-cluster

Here ocs-public and ocs-cluster are the NetworkAttachmentDefinition objects in multus which should exist before the StorageCluster CR is created.
Signed-off-by: rohan47<EMAIL_ADDRESS>Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.
[x] Code generation (operator-sdk generate k8s) has been run to update object specifications, if necessary.

Will add Unit tests

/ok-to-test to help catch code-generation issues.

/ok-to-test

looking into CI issues

/assign @jarrpa


[New Feature] Alert if balance of a certain account goes below N

please specify where to add the feature...

https://etherscan.io/myaddress
Similar to this feature as etherscan has, which implies account system... how can we do this in a lightweight way?

Seems not important


Rename find_closest ?

We have the following methods for getting near(est) neighbors:

find_closest
find_k_nearest_neighbors
find_near_neighbors

I find this a little inconsistent. Should we rename find_closest to find_nearest_neighbor?

Agree on this one.

Done with doxygen.

Done with doxygen.


[SUPPORT]Does Flink-cdc support Schema Evolution?

@danny0405
Hi~please ask a question, I use kafka(debezium) as source table, and hudi as target table, create a cdc application.
How can I do schema evolution use flink-cdc?

Hmm, schema evolution is not supported yet. When there are new records come in, you may need to re-start the streaming pipeline.


ENH add ratio-of-uniforms method for rv generation to scipy.stats

General method to sample random variates based on the density only.

can be useful to generate rvs in case a distribution is not part of scipy.stats and cdf cannot be easily inverted (such as the generalized inverse Gaussian).
I intend to add the generalized inverse Gaussian in a separate project based on this method (approach is referenced in the docstring which should also fix current restriction on parameters of invgauss.rvs as a special case)
once gen. inverse Gaussian is available, one can also add generalized hyperbolic distributions

Tests to be added, but I checked that the approach works in general using stats.kstest and a couple of examples (see docstring).

@andyfaff: I added more  test cases in 32fbb81, I hope this is fairly complete now.

i added normal distribution as a test case and the generalized inverse Gauss which is not part of scipy yet and which is a Distribution for which rvs generation is nontrivial (test is a bit ugly since I added the cdf calculation via integrate.quad by hand). I didn't add a test case to check whether finding x1,x2 numerically works since a) it would be rather a test of minimize_scalar b) distributions that come to my mind have generally tails that decay fast and should not make the maximization hard c) there is a disclaimer in the notes saying that one should pay attention when x1, x2 are not specified.

"repeatable rv streams" : i tested that results are the same if size = 9 or size = (3, 3) (after reshaping) if the same seed is used. is that what you meant?

Tests of size Arguments

tested some exception handling of x1, x2, y2

Let me know if you would like to see further tests.

@andyfaff : Hi, did you already have time to look into the changes? FYI: I started to work on adding the generalized inverse Gaussian to scipy.stats which would rely on this method, see https://github.com/chrisb83/scipy/tree/geninvgauss.

@andyfaff hi, it would be great if you could provide your feedback on this PR. Thanks

@chrisb83 Just wanted to say that this would be a great contribution. Please don't be discouraged by the lack of action here, it's just the bandwidth issue from our side.

Hi,
just FYI: #8681 that uses ratio_of_unif is not finalized yet, but shows that the function can be used to generate rvs as intended. It would be great to get your feedback.

After digging into numpy's implementation of the hypergeometric distribution sampler, I know a bit more about ratio-of-uniforms method than I did back in January, so I feel more comfortable about reviewing this pull request now.  However, I'll be traveling for a few weeks, so I won't get to it until the end of August.  (If anyone else wants to jump in sooner, please do.)

This needs a rebase as well.

I removed the parameter maxiter in bec7dc0 for the following reason:

to generate a single rv, one has a success probability p given by the ratio of the areas of A and R in each try.
the first time that success occurs has a geometric distribution (mean 1/p)
having no success for a single rv until step k is equal to (1-p)**k, so even for small p, this will be very unlikely after a while
if we want to generate N rvs, we do the same experiment N times independently

I think it is enough to display a warning if p is small (<5% in the implementation) because the method will be very slow in that case but there is no need to enforce a limit on the number of iterations .
I also renamed shift to c

@andypfaff do you want to take a look at this PR again? The changes you requests have been implemented.

I plan to merge this soonish. @andyfaff @WarrenWeckesser if you still want to review before merge, let me know.

I think the functionality in this PR is a great addition to scipy.
My main reservation about the PR is that the functionality is related to #6466, creating an rv_continuous from an arbitrary PDF function. The functionality here is pretty much the rvs method that I would expect from such a distribution.
Would it be better to have such an rv_arbitrary, with this code supplying the rvs method functionality? Or does it merit standalone inclusion?

Would it be better to have such an rv_arbitrary, with this code supplying the rvs method functionality? Or does it merit standalone inclusion?

I think this is a well-known method, has a clean API and solves a real problem (e.g. the generalized inverse Gaussian in gh-8681, pretty hard to do otherwise). It's likely also faster than putting it inside rv_arbitrary. So I'd say standalone.
Note that this then doesn't preclude introducing something like rv_arbitrary - this is a necessary building block for an rv_arbitrary.rvs. Regarding gh-6466, I think that could be useful, but re-reading the discussion there it's mostly a matter of being very clear on use cases it solves and API it offers (plus not too much code duplication with rv_continuous). It could use a new summary; the description at the top is outdated (e.g. it talks about histogram, but we now have rv_histogram).

I'm working on it this evening; I'll comment on the PR within the next 24 hours.

@WarrenWeckesser thanks for your comments.
Main changes I will do:

use u, v as in the original paper (since I started to work on this when looking at the GIG paper, I took over the notation), rename to vmin, vmax etc
move code to a separate file

Regarding the option to find bounds: I am fine to remove it, indeed, it makes more sense to find the bounds outside of the function (for speed and to avoid problems to find the min /max).

We would certainly use ratio of uniforms, but we'd probably customize the implementation for the specific distribution.

there are indeed various techniques to speed up the method, but i think it is a nice general tool. for GIG, it is also applied directly for most of the parameter ranges in the paper by Hörmann and Leydold.

Splitting stats.py into categories sounds like a useful thing to do to me. Not 100% sure we won't run into more import cycle issues though. Maybe split up as needed when we work on it? E.g. now create _rvs_sampling.py and put just this function in it; then in a separate PR move the other sampling functions, but not create any other new files.

I moved the function to a new file _rvs_sampling.py. TravisCI passes and the test failure on CircleCI seems unrelated:

Worker 'gw1' crashed while running 'build/testenv/site-packages/scipy/stats/tests/test_distributions.py::TestLevyStable::()::test_pdf_nolan_samples'

Not sure about AppVeyor though:

+++++++++++++++++++++++++++++++++++ Timeout
[gw1] node down: Not properly terminated
Replacing crashed worker gw1
........................................................................ [ 96%]
.....
........................................................................ [ 99%]
================================== FAILURES
___________________ scipy/_lib/tests/test_import_cycles.py ____________________
[gw1] win32 -- Python 3.7.0 C:\Python37-x64\python.exe
Worker 'gw1' crashed while running 'scipy/_lib/tests/test_import_cycles.py::test_modules_importable'

Now all tests pass, so I guess the crash last time was just a coincidence.
@WarrenWeckesser all your comments should be addressed now

Can this PR be merged? Then i could continue with #8681 at some point. thanks

@WarrenWeckesser and @andyfaff looks like all comments from both of you were addressed. Could you check and update your review approval? Would be good to merge this for 1.2.0

I've no further comments at this time. I can't get back to looking at it for a couple of weeks, so I'm happy for it to be merged if others are happy.

I'll get back to this by Monday, if not sooner.

does anyone recall if we have an established convention for documenting the signature of a callable argument?

Normally we just do:
func : callable
    A function with signature, `callable(x, y, ...)` that <etc>

Easy part: I adjusted the documentation.
More difficult: force algorithm to terminate. I removed one approach in bec7dc09110a5fdc53d3da415f731df02e39cefe .
Now i had a better idea: If we want to simulate N rvs, assume we still don't have a single success (i.e. a single (U, V) in the acceptance region A) after i iterations of the loop. this means we have tested whether (U, V) in A iN times without success. if each event has probability p, this occurs with probability (1-p)**(iN). Assuming that we only have a success rate of 1/1000, this probability below 21e-22 if iN > 50000. and in that case, i raise an exception.
BOM: I don't think there is an option to disable it in Spyder and for Windows users, it seems hard to avoid adding it to a file (Notepad adds it according to Wikipedia). Would it really be the only file that has this BOM in scipy? I can check how to remove remove it tomorrow if really needed.

@WarrenWeckesser BOM is gone as well, very easy with Notepad++, I will try to keep it in mind in the future.

@WarrenWeckesser it would be great If you take a look before it is too late for 1.2.0. thanks

@WarrenWeckesser I addressed the main points you mentioned. I mainly used single backticks now, with the exception of longer expressions . rgommers asked for double backticks in his review  some time ago and I also prefer it for readability. I think this is not consistent in scipy, maybe we have a separate discussion on that after 1.2.0.

I mainly used single backticks now, with the exception of longer expressions . rgommers asked for double backticks in his review some time ago and I also prefer it for readability. I think this is not consistent in scipy, maybe we have a separate discussion on that after 1.2.0.

It isn't consistent everywhere, but what it should be in every case is reasonably well-defined. Basic rule: references to modules/functions/classes in our API as well as references to function parameters should be single backticks; everything else that's code-like needs double backticks for typesetting as code.
The current state of this PR looks good enough to me.

Could we have that basic rule written down to refer to, doc formatting is
something that is always tripping me up.
On Sun., 4 Nov. 2018, 12:19 Ralf Gommers<EMAIL_ADDRESS>wrote:

I mainly used single backticks now, with the exception of longer
expressions . rgommers asked for double backticks in his review some time
ago and I also prefer it for readability. I think this is not consistent in
scipy, maybe we have a separate discussion on that after 1.2.0.
It isn't consistent everywhere, but what it should be in every case is
reasonably well-defined. Basic rule: references to
modules/functions/classes in our API as well as references to function
parameters should be single backticks; everything else that's code-like
needs double backticks for typesetting as code.
The current state of this PR looks good enough to me.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/pull/8293#issuecomment-435633899, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAq51p6jgCvvXW7zmi54lmRqmEbp6Vw7ks5urkCFgaJpZM4RdSnz
.

Could we have that basic rule written down to refer to, doc formatting is something that is always tripping me up.

I see it's not very explicit at https://numpydoc.readthedocs.io/en/latest/format.html, although what's mentioned there about backticks is correct. If we improve that doc is that enough, or would you expect to find this somewhere else?

@WarrenWeckesser i updated the PR yesterday and addressed your comments. Please review again.

Looks good.  My only remaining request is to squash the commits before merging.  (And yeah, I should have squashed the commits over at https://github.com/scipy/scipy/pull/9435.  I didn't think to check the commits there until after hitting the merge button.)

Everyone happy now, so squash-merged. Great to have this one in! Thanks @chrisb83 and all reviewers!


NewConfig routine code copied.

Should solve #266

There you go.

Let me know if we are good.

Look good?


LKL BBR SSR Config can't compatibility GoFlyway

LD_PRELOAD=/root/lkl/liblkl-hijack.so LKL_HIJACK_NET_QDISC="root|fq1" LKL_HIJACK_SYSCTL="net.ipv4.tcp_congestion_control=bbr;net.ipv4.tcp_wmem=4096 16384 30000000" LKL_HIJACK_OFFLOAD="0x9983" LKL_HIJACK_NET_IFTYPE=tap LKL_HIJACK_NET_IFPARAMS=lkl-tap LKL_HIJACK_NET_IP=<IP_ADDRESS> LKL_HIJACK_NET_NETMASK_LEN=24 LKL_HIJACK_NET_GATEWAY=<IP_ADDRESS> ./goflyway -k=12345 -l=12345 > GoFlyWay.log &
Same config SSR has been working but above config could't.

I have never used BBR on openvz so hope someone else can help.
Try running shadowsocks-go on the server with this config, see whether it can work or not.
If works, it's an issue solely with goflyway, if not, it's an issue with all the programs written in golang.


removed irrevelant question in znap rm

I was deleting pure and it asked this
zf_rm: remove '/data/data/com.termux/files/home/.znap/pure'?
for almost every file and directory
so this will make it not ask this.

Thank! Merged to main in dedc497.


Enums codegen implementation

For syntax, see #460

Just gonna use this as a scratchpad:
func (td TargetData) TypeAllocSize(t Type) uint64
func (td TargetData) TypeSizeInBits(t Type) uint64
func (td TargetData) TypeStoreSize(t Type) uint64

So, how do we want to specify the type when we instanciate? e.g do we do something like this:
s: Option = Option.Some(...)

or do we do something else?

@kiljacken Pretty sure it's this:
s: Option = Option::Some(...)

Ugh, this'll be rough. The rest ain't exactly bad

This'll be extremely hacky, or require rewriting a lot of things. One problem is that Tuple-construction is amigous with call-expressions, the other problem is that the tagged enum would have to be inject a module with the same name, or we'd have to implement a mechanism for storing things statically on types.

This is partly completed with #549.
Final parts (struct-style enum literal) still remain.

As of c04a5cc1c93f86cb25306ac3624a5f6445829167 only the generation of values for global enums is missing.

After much trial, implementation of global enum union literals is a lot more tricky than expected. Main reason is the lack of casting aggregate types in LLVM, or just plain union support.

@kiljacken Whats left?

As I said, initializing a global variable to an enum literal does not currently work.

@kiljacken Oh yeah, okay


Add image versioning

Problem
We must have option of rollback if some issue happened after update of image.
Solution
Segregate Docker images by unique version in image's tag.
ToDo

[x] Add version to global dependencies
[x] Add semver version to metadata.json of each image
[x] Combine both versions in image tag like g%globals_version%-%image_version%
[x] Do not push image from master branch to registry if tag already exists

https://github.com/puzl-ee/docker-images/pull/13

https://github.com/puzl-ee/docker-images/pull/13


CNV-33044: New VM Cloning API

📝 Description
Using the new cloning API
Removing namespace and description fields as they are not supported by the new API
🎥 Demo

/hold

/unhold


Since 2.1.1+dfsg1-0ubuntu<IP_ADDRESS> update, Window7 connection disconnect

With Apache Guacamole  installed on a Ubuntu 20.04, since last update, connection to Windows 7 or 2008R2 are disconnected every few seconds.
Start-Date: 2020-06-02  06:46:06
Commandline: /usr/bin/unattended-upgrade
Upgrade: libwinpr-tools2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libwinpr2-dev:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libwinpr2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-server2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-shadow-subsystem2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), freerdp2-dev:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-shadow2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-client2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), winpr-utils:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>)
End-Date: 2020-06-02  06:46:08

@olivier-morin any logs?

Ok, how can i generate logs for freerdp in guacamole ?

@olivier-morin well, I don´t know. You could give me a short install instruction to reproduce your setup, maybe that is sufficient.

Hello, I have the same pb, only on Windows 7, here is syslog.
I can see that I can connect on workstation if no windows are open on desktop, but if I clic on start menu I was disconnected. some windows could be open but other not if the windows is minimized no problem but when you restore it session is disconnected like you clic on start menu... hope theses informations will help...
Jun  3 20:28:52 guacamoleServer guacd[6039]: Connected to RDPDR 1.12 as client 0x0002 Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: INFO:#011Connected to RDPDR 1.12 as client 0x0002 Jun  3 20:28:52 guacamoleServer guacd[6039]: RDPDR user logged on Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: INFO:#011RDPDR user logged on Jun  3 20:28:52 guacamoleServer guacd[6039]: Connection closed. Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: ERROR:#011Connection closed. Jun  3 20:28:52 guacamoleServer guacd[6039]: Internal RDP client disconnected Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: INFO:#011Internal RDP client disconnected Jun  3 20:28:52 guacamoleServer guacd[6039]: User "@c20a66c5-c1e2-4516-b360-6254567f4986" disconnected (0 users remain) Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: INFO:#011User "@c20a66c5-c1e2-4516-b360-6254567f4986" disconnected (0 users remain) Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[6039]: INFO:#011Last user of connection "$2bec2d1a-5cc2-4be9-a9a5-02e3b83754a2" disconnected Jun  3 20:28:52 guacamoleServer guacd[6039]: Last user of connection "$2bec2d1a-5cc2-4be9-a9a5-02e3b83754a2" disconnected Jun  3 20:28:52 guacamoleServer guacd[957]: Connection "$2bec2d1a-5cc2-4be9-a9a5-02e3b83754a2" removed. Jun  3 20:28:52 guacamoleServer guacd[957]: guacd[957]: INFO:#011Connection "$2bec2d1a-5cc2-4be9-a9a5-02e3b83754a2" removed. Jun  3 20:28:52 guacamoleServer tomcat9[2294]: 20:28:52.860 [Thread-189] INFO  o.a.g.tunnel.TunnelRequestService - User "myuser" disconnected from connection "DEFAULT". Duration: 4607 milliseconds Jun  3 20:28:52 guacamoleServer tomcat9[2294]: 20:28:52.860 [Thread-189] DEBUG o.a.g.net.InetGuacamoleSocket - Closing socket to guacd. Jun  3 20:28:52 guacamoleServer tomcat9[2294]: 20:28:52.887 [https-openssl-nio-8443-exec-10] DEBUG o.a.g.w.GuacamoleWebSocketTunnelEndpoint - Connection to guacd closed. Jun  3 20:28:52 guacamoleServer tomcat9[2294]: org.apache.guacamole.GuacamoleConnectionClosedException: Connection to guacd is closed.

Same issue here. I have desktops with Windows 7/ Windows 2008 Server R2, and the server is running Ubuntu 18.04 with guacamole-server (guacd) 1.1.0 manually compiled, with libfreerdp2-2 (2.1.1+dfsg1-0ubuntu<IP_ADDRESS>). When the user makes some action (as clicking the Start menu or browsing the local network), the RDP session is closed and the user is disconnected. Downgrading libfreerdp2-2 to the version previously installed (2.0.0~git202003120736-0+remmina202003121121.r3b673be.d287a1e7~ubuntu18.04.1) solves the problem.
The following are sample log entries for a desktop running Windows 7.
tomcat log:
11:42:24.726 [http-nio-8080-exec-41] INFO  o.a.g.tunnel.TunnelRequestService - User "userxxx" connected to connection "291".
11:42:59.610 [http-nio-8080-exec-19] INFO  o.a.g.tunnel.TunnelRequestService - User "userxxx" disconnected from connection "291". Duration: 34883 milliseconds
guacd log:
11:42:24 guacd[999]: Processing instruction: size
11:42:24 guacd[999]: Processing instruction: audio
11:42:24 guacd[999]: Processing instruction: video
11:42:24 guacd[999]: Processing instruction: image
11:42:24 guacd[999]: Processing instruction: timezone
11:42:24 guacd[999]: Parameter "console" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "console-audio" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "disable-auth" omitted. Using default value of 0.
11:42:24 guacd[999]: No security mode specified. Defaulting to security mode negotiation with server.
11:42:24 guacd[999]: Parameter "port" omitted. Using default value of 3389.
11:42:24 guacd[999]: User resolution is 1366x657 at 96 DPI
11:42:24 guacd[999]: Parameter "dpi" omitted. Using default value of 96.
11:42:24 guacd[999]: Using resolution of 1364x657 at 96 DPI
11:42:24 guacd[999]: Parameter "read-only" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "client-name" omitted. Using default value of "Guacamole RDP".
11:42:24 guacd[999]: Parameter "enable-wallpaper" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-theming" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-font-smoothing" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-full-window-drag" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-desktop-composition" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-menu-animations" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "disable-bitmap-caching" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "disable-offscreen-caching" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "disable-glyph-caching" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "color-depth" omitted. Using default value of 16.
11:42:24 guacd[999]: Parameter "disable-audio" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "enable-printing" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "printer-name" omitted. Using default value of "Guacamole Printer".
11:42:24 guacd[999]: Parameter "enable-drive" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "drive-name" omitted. Using default value of "Guacamole Filesystem".
11:42:24 guacd[999]: Parameter "drive-path" omitted. Using default value of "".
11:42:24 guacd[999]: Parameter "create-drive-path" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "timezone" omitted. Using default value of "America/Buenos_Aires".
11:42:24 guacd[999]: Parameter "enable-sftp" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "sftp-hostname" omitted. Using default value of "HOSTXXX".
11:42:24 guacd[999]: Parameter "sftp-port" omitted. Using default value of "22".
11:42:24 guacd[999]: Parameter "sftp-username" omitted. Using default value of "".
11:42:24 guacd[999]: Parameter "sftp-password" omitted. Using default value of "".
11:42:24 guacd[999]: Parameter "sftp-passphrase" omitted. Using default value of "".
11:42:24 guacd[999]: Parameter "sftp-root-directory" omitted. Using default value of "/".
11:42:24 guacd[999]: Parameter "sftp-server-alive-interval" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "recording-name" omitted. Using default value of "recording".
11:42:24 guacd[999]: Parameter "recording-exclude-output" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "recording-exclude-mouse" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "recording-include-keys" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "create-recording-path" omitted. Using default value of 0.
11:42:24 guacd[999]: Resize method: none
11:42:24 guacd[999]: Parameter "enable-audio-input" omitted. Using default value of 0.
11:42:24 guacd[999]: Parameter "gateway-port" omitted. Using default value of 443.
11:42:24 guacd[999]: User "@xxxxxxxxxx-xxxxx-xxxxx-xxxx-xxxxxxxxxxxx" joined connection "$xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" (1 users now present)
11:42:24 guacd[999]: Client is using protocol version "VERSION_1_1_0"
11:42:24 guacd[999]: Loading keymap "base"
11:42:24 guacd[999]: Loading keymap "en-us-qwerty"
11:42:24 guacd[999]: freerdp_connect:freerdp_set_last_error_ex resetting error state
11:42:24 guacd[999]: Support for CLIPRDR (clipboard redirection) registered. Awaiting channel connection.
11:42:24 guacd[999]: Support for static channel "rdpdr" loaded.
11:42:24 guacd[999]: Support for static channel "rdpsnd" loaded.
11:42:24 guacd[999]: Local framebuffer format  PIXEL_FORMAT_BGRX32
11:42:24 guacd[999]: Remote framebuffer format PIXEL_FORMAT_RGB16
11:42:25 guacd[999]: primitives autodetect, using optimized
11:42:25 guacd[999]: freerdp_tcp_is_hostname_resolvable:freerdp_set_last_error_ex resetting error state
11:42:25 guacd[999]: freerdp_tcp_connect:freerdp_set_last_error_ex resetting error state
11:42:25 guacd[999]: Unable to find a match for unix timezone: America/Argentina/Buenos_Aires
11:42:25 guacd[999]: CLIPRDR (clipboard redirection) channel connected.
11:42:25 guacd[999]: SVC "rdpdr" connected.
11:42:25 guacd[999]: SVC "rdpsnd" connected.
11:42:26 guacd[999]: Connected to RDPDR 1.12 as client 0x0003
11:42:26 guacd[999]: Ignoring server capability set type=0x0001, length=44
11:42:26 guacd[999]: Ignoring server capability set type=0x0002, length=8
11:42:26 guacd[999]: Ignoring server capability set type=0x0003, length=8
11:42:26 guacd[999]: Ignoring server capability set type=0x0004, length=8
11:42:26 guacd[999]: Ignoring server capability set type=0x0005, length=8
11:42:26 guacd[999]: Sending capabilities...
11:42:26 guacd[999]: Capabilities sent.
11:42:26 guacd[999]: Client ID confirmed
11:42:26 guacd[999]: Clipboard data received. Reporting availability of clipboard data to RDP server.
11:42:26 guacd[999]: [cliprdr_packet_format_list_new] called with invalid type 00000000
11:42:26 guacd[999]: Clipboard data received. Reporting availability of clipboard data to RDP server.
11:42:26 guacd[999]: [cliprdr_packet_format_list_new] called with invalid type 00000000
11:42:57 guacd[999]: rdp_set_error_info:freerdp_set_last_error_ex resetting error state
11:42:57 guacd[999]: ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off their session on the server.
11:42:57 guacd[999]: rdp_set_error_info:freerdp_set_last_error_ex ERRINFO_LOGOFF_BY_USER [0x0001000C]
11:42:57 guacd[999]: rdp_recv_tpkt_pdu: rdp_recv_deactivate_all() fail
11:42:57 guacd[999]: transport_check_fds: transport->ReceiveCallback() - -1
11:42:57 guacd[999]: RDP server closed connection: Manually logged off.
11:42:57 guacd[999]: Disconnect reason code: 0xC.
11:42:57 guacd[999]: SVC "rdpdr" disconnected.
11:42:57 guacd[999]: SVC "rdpsnd" disconnected.
11:42:57 guacd[999]: Internal RDP client disconnected
11:42:59 guacd[999]: User "@xxxxxxxxxx-xxxxx-xxxxx-xxxx-xxxxxxxxxxxx"disconnected (0 users remain)
11:42:59 guacd[999]: Last user of connection "$xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx" disconnected
11:42:59 guacd[999]: Requesting termination of client...
11:42:59 guacd[999]: Client terminated successfully.
Also, in the kern.log I have some occasional segfaults (apparently solved with the downgrade):
10:57:55 guacamole kernel: [394677.038721] guacd[13418]: segfault at 48 ip 00007efe504f0406 sp 00007efdcdfface0 error 4 in libfreerdp2.so.2.1.1[7efe50482000+161000]
11:09:47 guacamole kernel: [395388.672124] guacd[17220]: segfault at 7efdaa4b701c ip 00007efe60132c7b sp 00007efdb9fd2d20 error 4 in libguac-client-rdp.so.0.0.0[7efe6010d000+3b000]
11:43:52 guacamole kernel: [397434.053707] guacd[38623]: segfault at 4 ip 00007efe37d4fb07 sp 00007efda57a13b8 error 4 in libwinpr2.so.2.1.1[7efe37ce5000+f6000]

@javiers ok, that log is interesting. looks like the session is disconnected on the server end (ERRINFO_LOGOFF_BY_USER is a server side disconnect)
As for the segfault, sorry for the inconvenience, we had a resource cleanup order issue with 2.1.1  that should be fixed with #6259

@javiers could you try to reproduce with a session using only xfreerdp?

Bonjour,
On my ubuntu 18.04 server i revert to 2.0.0, i recompile guacd and every ting is now fine.
The solution was here : http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/Guacamole-FreeRDP-disconnect-td8575.html thanks to "ivanmarcus".
ldconfig -v | grep libfree (show current version)
apt install aptitude (it dealt with dependencies much better)
apt-cache showpkg freerdp2-dev (show packages available)
aptitude install freerdp2-dev=2.0.0~git20170725.1.1648deb+dfsg1-7 (choose and [re]install 2.0.0)
ldconfig -v | grep libfree (check correct package installed)
The other solution is to install a guacd sever proxy with freerdp 2.2.0 to connect on W7 W2008 machines and install freerdp 2.1.1 for secutity on your main guacamole serer.
This solution is OK and in production at my job.

@javiers could you try to reproduce with a session using only xfreerdp?

I've tried to reproduce the error using fresh installed Windows 7 + Ubuntu 18.04, but until now everything works fine. I'll keep trying to adapt the xfreerdp command line parameteres to match the guacd connection ones.

@javiers I think to get xfreerdp 2.1.1 you´ll need to test on ubuntu 20.04.
Other option would be to give me a short install how to for the guacamole you´re using so we have matching setups.

@javiers I think to get xfreerdp 2.1.1 you´ll need to test on ubuntu 20.04.

The version included in Ubuntu 18.04 is 2.1.1 (since 2020-06-01, the upgrade that broke my setup): https://launchpad.net/ubuntu/+source/freerdp2/2.1.1+dfsg1-0ubuntu<IP_ADDRESS>
I've installed guacamole 1.1.0 as described in the official docs (https://guacamole.apache.org/doc/gug/), using pre-compiled guacamole-client and manually-compiled guacd server (using FreeRDP 2.0.0~git202003120736-0).

Bonsoir,
My production Guacamole server (Ubuntu 20;04) was originaly with the version 2.0.0 of freeRDP and every things was fine, but the 2020-06-02 Ubuntu made an auto update (see logs), and then RDP goes wgrong with W7.
So i tried with my previous Guacamole server (Ubuntu 18.04) and the same bug came after updating freedrp from 2.0.0 to 2.1.1.
So i revert it to 2.0.0 and rerun the script, now it is ok again...
Il use this script to installa Guacamole : https://github.com/MysticRyuujin/guac-install
Logs of Auto update :
Start-Date: 2020-06-02  06:46:06
Commandline: /usr/bin/unattended-upgrade
Upgrade: libwinpr-tools2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libwinpr2-dev:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libwinpr2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-server2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-shadow-subsystem2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), freerdp2-dev:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-shadow2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), libfreerdp-client2-2:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>), winpr-utils:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>)
End-Date: 2020-06-02  06:46:08
Start-Date: 2020-06-02  06:46:12
Commandline: /usr/bin/unattended-upgrade
Upgrade: ca-certificates:amd64 (20190110ubuntu1, 20190110ubuntu1.1)
End-Date: 2020-06-02  06:46:15
Start-Date: 2020-06-02  06:46:18
Commandline: /usr/bin/unattended-upgrade
Upgrade: freerdp2-x11:amd64 (2.0.0~git20190204.1.2693389a+dfsg1-2build2, 2.1.1+dfsg1-0ubuntu<IP_ADDRESS>)
End-Date: 2020-06-02  06:46:19
Start-Date: 2020-06-02  06:46:22
Commandline: /usr/bin/unattended-upgrade
Remove: gstreamer1.0-plugins-base:amd64 (1.16.2-4)
End-Date: 2020-06-02  06:46:22
Start-Date: 2020-06-02  06:46:24
Commandline: /usr/bin/unattended-upgrade
Remove: libxv1:amd64 (2:1.0.11-1)
End-Date: 2020-06-02  06:46:24
Start-Date: 2020-06-02  06:46:27
Commandline: /usr/bin/unattended-upgrade
Remove: libcdparanoia0:amd64 (3.10.2+debian-13)
End-Date: 2020-06-02  06:46:27
Start-Date: 2020-06-02  06:46:29
Commandline: /usr/bin/unattended-upgrade
Remove: liborc-0.4-0:amd64 (1:0.4.31-1), libgstreamer-plugins-base1.0-0:amd64 (1.16.2-4)
End-Date: 2020-06-02  06:46:30
Start-Date: 2020-06-02  06:46:32
Commandline: /usr/bin/unattended-upgrade
Remove: libvisual-0.4-0:amd64 (0.4.0-17)
End-Date: 2020-06-02  06:46:32

Bonjour,
I've made a fresh full install of an ubuntu 20.04 server an run the guacd script : https://github.com/MysticRyuujin/guac-install/blob/master/guac-install-server.sh
This script install the last version of freerdp i.e. the 2.1.1.
So the result is still the same, on W7 or WS2008, rdp is deconnected after few seconds or when you click to open a soft.

I am running into the same problem I think but with some weird quirks.
Using guacamole 1.1.0, freerdp 2.1.1 because of MysticRyuujin script on ubuntu 18.04:

I cannot rdp to windows 2003 servers unless i set the colors to 16 bit or above.  Definitely not 256 colors.  Else I get server unavailable.
When I do connect with other colors, the connections works great until I launch ms word 2003 and when rendering the menus - i get kicked out.  Message is then server unavailable.  Yet for most programs there is no issue.  Excel causes the kick out also.

I could not find anything of value in the logs besides, you got disconnected...
Out of desperation, I reverted back to an older version of Guac with and older freerdp.  Too puzzled by the weird way it disconnects...
Gonna try to make oliver's suggestion and let you know how it goes.

Bonjour !
I gonna try a reinstall with Ubuntu 20.04, guacd 1.1.0 but freerdp 2.0.0.
I'll tell you ASAP.

Ok, but could you tell me how to find or generate freerpd logs ?

If we are just talking the syslog, guac logs... mine didn't show anything but generic connection dropped messages.   But yeah, I'd be glad to get freerdp logs to you.  I saved one of the attempts in a vm i can spin it back up to look.  Let me know how to generate those logs too.

@olivier-morin I'm gonna try to your changes!  to see if they fix the color issues disconnect I was having.  WIsh me luck and thanks again for sharing!

@olivier-morin @yur7530 you can get better freerdp logs if you start with environment variable WLOG_LEVEL=debug or trace set

Bonjour,
I would like to test teh 2.1.2 version on ubuntu focal, where to get it ?

https://ci.freerdp.com/job/freerdp-nightly-binaries/
that should give you latest master

Any update on this one?

Bonjour,
I am wainting for the 2.1.2 ubuntu package update to try a new install from scratch.

@olivier-morin ok. 2.1.2 sadly has a nasty bug #6299 which was fixed with was fixed with #6300, so check the package has that applied once it arrives.

Bonjour,
Still waiting...

Closing as already fixed with 2.2.0 release.
@olivier-morin 2.2.0 has been released, so build from source or you need to wait for ubuntu to update their packages.

Using FreeRDP 2.2.0 (libfreerdp2-2_2.2.0+git202007201338-0+remmina202007220704.rd2ba84a.d97f0237~ubuntu18.04.1_amd64) with guacd 1.2.0 (compiled from source). The bug is still there:
Jul 27 18:40:06 test guacd[867]: invalid bitmap bpp 0
Jul 27 18:40:06 test guacd[867: SECONDARY ORDER [0x00] Cache Bitmap failed
Jul 27 18:40:06 test guacd[867]: order flags 03 failed
Jul 27 18:40:06 test guacd[867]: Fastpath update Orders [0] failed, status 0
Jul 27 18:40:06 test guacd[867]: fastpath_recv_update() - -1
Jul 27 18:40:06 test guacd[867]: fastpath_recv_update_data() fail
Jul 27 18:40:06 test guacd[867]: transport_check_fds: transport->ReceiveCallback() - -3
Jul 27 18:40:06 test guacd[867]: freerdp_check_fds() failed - 0
Jul 27 18:40:06 test guacd[867]: Connection closed.
Jul 27 18:40:06 test guacd[867]: SVC "rdpdr" disconnected.
Jul 27 18:40:06 test guacd[867]: SVC "rdpsnd" disconnected.
Jul 27 18:40:06 test guacd[867]: Internal RDP client disconnected

@javiers no, that is something different. Run the same thing again with WLOG_LEVEL=trace to get a better log and create a new issue with that.

I troubled Windows2003R2 too.
but "disable-glyph-caching: true" seems improve it.

Bonjour
On Windows 2008R2 and Windows 7 set "Disable glyph caching" to true and it's OK ! with 2.1.1 !

Confirmed: setting "Disable glyph caching" eliminates the issue in Windows 2008 R2 and Windows 7.

Disable glyph caching solve the problem for me too, thanks everyone!

i can confirm that bug still exists.
I use arch linux with latest freerdp 2.2.0 and yesterday i download latest guacamole 1.3 from github and compile everything from the beginning. after i connect with guacamole to windows 7 i am disconnect. works with windows 10 and windows server 2016&2019
after i disable glyph caching in guacamole i can connect to windows 7 without disconnecting

@joksik could you try a build utilizing current master? we fixed a parsing issue recently which could affect this.

Bumping this to confirm this bug still exists on Ubuntu 20.04 with freerdp2-dev, Guacamole 1.3.0, fresh install.

@Coolguy3289 @romanad even if you use disable-glyph-caching: true?

@Coolguy3289 @romanad even if you use disable-glyph-caching: true?

Thank you very much. I disabled it in connection settings in web interface and now everything's fine : )

I did disable glyph caching to fix it, however I would presume this is a workaround, not a fix to the true issue.

@Coolguy3289 the fix is updating to a newer version of freerdp where we actually fixed the glyph-cache ;)
See https://github.com/FreeRDP/FreeRDP/blob/stable-2.0/ChangeLog


Add conversions of existing macro code base to Autotouch

convertMacros has untested Autotouch support. We should organize testing and then build convert.sh scripts to handle the macro conversions for all existing scripts.

AnkuLua sample should be in my latest batch of updates

Hi, when you have some time could you show me how to enter commands into convertmacro.py.
I got it to run in python3 command line, but when I enter the commands i get syntax error. Could you send me a sample of what I have to type in to the command line to convert a macro from MEmu 720x1280 to 720x1280 Nox, I do not need to swap any x or y values.

 Your the man. This is awesome!!!!

Ok, so when going from MEmu 720x1280 to Nox, I put in --in-x 720 --in-y 1280 --flip-y to get the results I wanted. My question to you is why does --flip-y flip the x values? Why does it produce a mirror image instead of keeping the X and Y values the same? Shouldnt a 1:1 conversion be the default if entering the X and Y values?
The MEmu value is 0000100--VINPUT--MULTI:1:0:349:1099

Running with just -i and outtype commands gives me this 0|-379|349|0|0|0|0|720|1280
Added  --in-x 720 --in y 1280 and got 0|371|1099|0|0|0|0|720|1280
Added --flip-x and got 0|371|1099|0|0|0|0|720|1280
Changed --flip-x to --flip-y and got 0|349|1099|0|0|0|0|720|1280


#991 Specifying Trusty image for build

Specifying dist for JDK8 to pass (https://travis-ci.community/t/install-of-oracle-jdk-8-failing/3038/8)

@piotrkot/z this pull request is too small, just 1 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @paulodamaso/z please review this and merge or reject

@piotrkot Thanks!

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 31min)

Job gh:yegor256/takes#992 is not assigned, can't get performer

This job is not in scope


Improve syntax of Json configuration file of ROBFW-AIO

Hi Son,
thank you for you pull-request.
This I will merge for coming 0.5.3 version.
Please provide also selftest!
Thank you,
Thomas

Hi Holger,
thank you for fast testing!
Yes, this you found an issue. null and None must be string (text) if they are set in quotes.
@namsonx : Please fix this.
Thank you,
Thomas

Hello Thomas,
 I have just run the test with debug mode, and I observed the value of "${params}['global']['null_val']" is converted to string and remained until it is set by BuiltIn().set_global_variable("${%s}" % k.strip(), v)
 I could not attach the screenshot of my debug session to this github comment, I will show you in the sync up meeting.
 So, the root cause of the case which Holger mentioned comes from the core of ROBFW, I think!

Thank you,
Son

Hi Son,
unfortunately the SelfTest and Documentation update is still missing.
By when can I expect this?
We disussed a lot on this one month ago. Is there something remaining open / or a dependency? What about the "None" issue?
Thank you,
Thomas

Hello Thomas,
 I had checked the case with "None" issue which Holger mentioned, and I recognized that this issue also occurs with "True" and "False" cases.
 I had updated the commit to correct them all in this pull request.

 For the Selftest documentation of this JsonPreprocessor repo. I will update in another pull-request.

Thank you,
Son

Hi Son,
unfortunately the SelfTest and Documentation update is still missing.
By when can I expect this?
Thank you,
Thomas

Hi Son,
thank you for the update.
Please look into my findings.
Thank you,
Thomas


Pyaml update

Using new version of pyyaml because of security alert.
https://nvd.nist.gov/vuln/detail/CVE-2017-18342

Yes, this should be enough.
Am Sa., 5. Jan. 2019 um 15:29 Uhr schrieb h4nc<EMAIL_ADDRESS>
Is it enough to run this command
sudo pip3 install --upgrade plantgateway
to bring everything up to data?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ChristianKuehnel/plantgateway/pull/30#issuecomment-451660146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATCWCDz-bAc9RTdb6tkR_M24yCMYmo2zks5vALa4gaJpZM4Zw9xd
.


VTO Example - Colors

Hi,
Congratulations for your great projects. I have a question regarding VTO example in jeelizFaceFilter. In JeelizThreeGlassesCreator file we find the following code for lenses:
const mat=new THREE.MeshBasicMaterial({
envMap: textureEquirec,
opacity: 0.7,
color: 0x2233aa,
transparent: true
});
If I change the values of opacity, color & transparent everything works fine and the lenses are modified accordingly.
We also find the following code for frames:
//custom material with fading at the end of the branches
const uniforms=Object.assign(THREE.ShaderLib.basic.uniforms,
{
envMap: {value: textureEquirec},
color: {value: new THREE.Color(0xf0f0f0)},
uBranchFading: {value: new THREE.Vector2(-90,60)} //first value: position (lower -> to the back), second: transition brutality
});
Unlike lenses, if we change the value of color, we see no changes to the grey frame(0xf0f0f0). Is there something wrong or not?
Thank you.

Hi,
The frame material is a custom shader material initialized here: https://github.com/jeeliz/jeelizFaceFilter/blob/master/demos/threejs/VTO/JeelizThreeGlassesCreator.js
It seems it does not use the color uniform.
Best,
Xavier


corrected logic to respect snipe = true

move_to_map was ignoring pokemons which were beyond "max distance" (which is normal for sniping); an "or" had to be changed to "and" in order to only ignore such pokemons if sniping was turned off.

:+1:

Closes #4837

Oops, did not realize there was an open issue for this. :)
Just wanted to fix it and get rid of manually editing the file upon new checkouts :D

Can you rebase, I just merged something else.

sure... how do I do that? :)

Actually the label says it can be automatically merged, so you should be able to merge regardless?...

https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

There are no conflicts, you can just merge this PR without rebasing...

"This branch is out-of-date with the base branch
Merge the latest changes from dev into this branch."

Try now please (looks like this rebase can be taken care of by using "update branch"...).

From what I can tell, the little pull approved thing changes what I see for conflicts. Sorry to be a pain, not sure if it would have made a difference.
Thanks for the PR!

@mjmadsen please revert, this should not be merged. The issue was caused by an incorrect config by @dummyaja, @warxhead1, @daemonsyn, @DBa2016 . If anything, the readme should be updated.
The MoveToMapPokemon handler and it's config block handle the logic for sniping. The Max_distance in there needs to be correctly set to limit the snipe distance. Some people only want to snipe within 10km for example, others want to snipe the entire world. That's the sole purpose of max_distance.
This merge breaks that functionality. Which was restored in https://github.com/PokemonGoF/PokemonGo-Bot/pull/4772


404 - page not found

Under the heading How does DEI Project Badging work? a link that should lead to how to create DEI.md and what it entails is broken.

@c0d33ngr  we have mostly moved all the badging work from All In to this repo and https://github.com/badging/BadgingAPI. If you are looking for references on project badging consider going to https://badging.chaoss.community/project-badging.
Please let me know where you are trying to access the link from so that we can update it

Hi @kaxada it's the README.md of this repo. The first bullet point of the heading How does DEI Project Badging work?. The link here is pointing to in the readme is broken

@c0d33ngr thank you for the vigilance. this has been fixed and closed.


fix: replaced BadRequest.yml with Error.yml to fix CLI codegen

In tasks.yml, the BadRequest.yml breaks Go codegen in the CLI tool when used as the 400 response schema, this PR replaces it with the working Error.yml.

@jstirnaman sorry that was a bit of a hacky fix when working on the CLI, latest fixes codegen and should have no impact on the docs.


Version 1.2 breaks pypa/build on Python 3.8 and 3.9

1.2 has broken build's test suite when using backend-path on Python 3.8 and 3.9 (and check-sdist's setuptools test, though I just dropped the setuptools test there). See https://github.com/pypa/build/pull/820, https://github.com/python/importlib_metadata/issues/508, https://github.com/henryiii/check-sdist/pull/55. I've finally narrowed it down to this package's 1.2 release.
Backend path is ".", and setuptools is making test_no_prepare.egg-info, which is then getting picked up as a nameless distribution, which causes a confusing error when trying to get the name and falling back on None, then not handling the None case.
Originally posted by @henryiii in https://github.com/pypa/pyproject-hooks/issues/199#issuecomment-2395287934
Traceback (most recent call last):
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/compat/py39.py", line 19, in normalized_name
    return dist._normalized_name
AttributeError: 'PathDistribution' object has no attribute '_normalized_name'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/build/.tox/py39/lib/python3.9/site-packages/pyproject_hooks/_in_process/_in_process.py", line 389, in <module>
    main()
  File "/build/.tox/py39/lib/python3.9/site-packages/pyproject_hooks/_in_process/_in_process.py", line 373, in main
    json_out["return_val"] = hook(**hook_input["kwargs"])
  File "/build/.tox/py39/lib/python3.9/site-packages/pyproject_hooks/_in_process/_in_process.py", line 280, in build_wheel
    return _build_backend().build_wheel(
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/build_meta.py", line 421, in build_wheel
    return self._build_with_temp_dir(
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/build_meta.py", line 403, in _build_with_temp_dir
    self.run_setup()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/build_meta.py", line 318, in run_setup
    exec(code, locals())
  File "<string>", line 1, in <module>
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/__init__.py", line 117, in setup
    return distutils.core.setup(**attrs)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 183, in setup
    return run_commands(dist)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 199, in run_commands
    dist.run_commands()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 954, in run_commands
    self.run_command(cmd)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/dist.py", line 950, in run_command
    super().run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 973, in run_command
    cmd_obj.run()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/command/bdist_wheel.py", line 433, in run
    self.run_command("install")
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 316, in run_command
    self.distribution.run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/dist.py", line 950, in run_command
    super().run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 973, in run_command
    cmd_obj.run()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/command/install.py", line 91, in run
    return super().run()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/command/install.py", line 706, in run
    self.run_command(cmd_name)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 316, in run_command
    self.distribution.run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/dist.py", line 950, in run_command
    super().run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 973, in run_command
    cmd_obj.run()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/command/install_egg_info.py", line 32, in run
    self.run_command('egg_info')
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 316, in run_command
    self.distribution.run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/dist.py", line 950, in run_command
    super().run_command(command)
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 973, in run_command
    cmd_obj.run()
  File "/build/.tox/py39/lib/python3.9/site-packages/setuptools/command/egg_info.py", line 302, in run
    for ep in metadata.entry_points(group='egg_info.writers'):
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 1051, in entry_points
    return EntryPoints(eps).select(**params)
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 1048, in <genexpr>
    eps = itertools.chain.from_iterable(
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/_itertools.py", line 17, in unique_everseen
    k = key(element)
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/compat/py39.py", line 23, in normalized_name
    return Prepared.normalize(getattr(dist, "name", None) or dist.metadata['Name'])
  File "/build/.tox/py39/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 889, in normalize
    return re.sub(r"[-_.]+", "-", name).lower().replace('-', '_')
  File "/usr/local/lib/python3.9/re.py", line 210, in sub
    return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object

It would appear #199 returns a stdlib (importlib.metadata) distribution which setuptools then attempts to operate on using the backport (importlib_metadata) and the two are incompatible on Python 3.8 and .9.

/cc @jaraco @takluyver @abravalheri for awareness.

Responding to https://github.com/pypa/pyproject-hooks/pull/199#issuecomment-2395367699:

I'm sorely tempted to declare that pyproject-hooks now requires Python 3.10 or above, and you should just pin whichever version works for you on older Python versions. I'm normally pretty keen on backwards compatibility, so I'd welcome a better solution, but I don't have the time or energy to wade through importlib stuff to figure this out. And I don't know how we can trust that the next solution won't just lead to another of these bugs popping up somewhere.

I have two concerns with that:

pip won't be able to upgrade to a newer version of pyproject_hooks, because pip can't be dropping support for Python 3.9 just yet. So, the underlying https://github.com/pypa/pip/issues/11812 issue can't be resolved until at least an year from now. Plus, pip won't be able to pull in any bugfixes etc from this project outside of maintaining its own fork... which is unappealing to say the least. 😓
If we do this, we should yank 1.2.0 and release a 1.3.0 with the right python-requires, so that anyone using 3.8/3.9 isn't going to get a broken release by default.

My inclination is to say that this is either a bug in setuptools (which should spot when it gets a stdlib object and deal with it) or in the importlib_metadata backport (which should offer some sort of compatibility).
None of which helps that much, unless those projects can release fixes ASAP, but at the same time, I sympathise with @takluyver's point that if we can't rely on being able to safely pass distribution objects around, we're going to be at risk of yet more areas of incompatibility popping up.

If we do this, we should yank 1.2.0 and release a 1.3.0 with the right python-requires...

We might then need to yank 1.1.0 as well, since that was already reported as a regression (#192) and 1.2.0 was meant to fix it. And then I presume people would be upset about the problem that #165 was written to fix again. I totally agree that I don't want to do this.
A slightly less drastic version might be to change the conditional added in #199 - if sys.version_info >= (3, 8): - to (3, 10). This would mean no importlib[._]metadata integration on Python 3.8 or 3.9 (like v1.1), but keep the integration (like v1.2) for newer Pythons.
If setuptools is committed to using the backport on 3.8 & 3.9, we could decide that compatibility with setuptools is more important than anything else and insist on using the backport for those versions as well. But that presumably breaks other code that does the right thing and uses the stdlib version. And it's an extra headache for anyone who cares about bootstrapping, since importlib_metadata needs setuptools & setuptools_scm to build it. I really don't like that option.

Has this issue actually been observed anywhere outside of a contrived test case? Build re-exposes setuptools without the prepare hook to test reading a project’s metadata from a wheel. Unless this incompatibility is causing builds to fail in the wild, yanking’s probably an overreaction at this point.
Sent with Proton Mail secure email.
On Sunday, 6 October 2024 at 14:31, Thomas Kluyver @.***> wrote:

If we do this, we should yank 1.2.0 and release a 1.3.0 with the right python-requires...

We might then need to yank 1.1.0 as well, since that was already reported as a regression (#192) and 1.2.0 was meant to fix it. And then I presume people would be upset about the problem that #165 was written to fix again. I totally agree that I don't want to do this.
A slightly less drastic version might be to change the conditional added in #199 - if sys.version_info >= (3, 8): - to (3, 10). This would mean no importlib[._]metadata integration on Python 3.8 or 3.9 (like v1.1), but keep the integration (like v1.2) for newer Pythons.
If setuptools is committed to using the backport on 3.8 & 3.9, we could decide that compatibility with setuptools is more important than anything else and insist on using the backport for those versions as well. But that presumably breaks other code that does the right thing and uses the stdlib version. And it's an extra headache for anyone who cares about bootstrapping, since importlib_metadata needs setuptools & setuptools_scm to build it. I really don't like that option.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

It broke check-sdist’s tests too, where it was just building an SDist for setuptools. I believe it breaks any package that has a local backend at “.” and uses setuptools. Including setuptools itself (https://github.com/pypa/setuptools/blob/66a8aee91de7ed8b0f819fb836e5543212e4b860/pyproject.toml#L4) and setuptools-scm. I’ve verified locally that you can’t build setuptools-scm anymore.

No, it fixed setuptools local backend at "." based on our actual usage of build to bootstrap setuptools.

This is only about Python 3.8 and 3.9, everything works fine after that.
It breaks both:
$ git clone https://github.com/cvxpy/cvxpy
$ cd cvxpy
$ pipx run --python 3.9 build --sdist
...
TypeError: expected string or bytes-like object
$ pipx run --python 3.9 build --wheel
...
TypeError: expected string or bytes-like object
$ pipx run --python 3.13 build --sdist
...
Successfully built cvxpy-1.6.0.tar.gz

It would appear #199 returns a stdlib (importlib.metadata) distribution which setuptools then attempts to operate on using the backport (importlib_metadata) and the two are incompatible on Python 3.8 and .9.

As a reminder, importlib.metadata prior to Python 3.10 was considered "provisional", so it's probably preferable to use importlib_metadata at least on those versions.
importlib_metadata has attempted to accommodate objects from those implementations, but it's complicated due to the two API surfaces that library manages (providers and consumers). In python/importlib_metadata#486, we're exploring ways to shore up some of those relationships, but that still won't fix the fact that importlib.metadata on Python 3.9 and earlier will never honor the newer interfaces and guarantees of later releases. Later versions of importlib_metadata will provide an error earlier when the Name key is missing, but only for Distributions constructed from importlib_metadata.
That said, an egg-info directory containing no metadata is in fact invalid, right? Shouldn't the solution be to address the root cause (prevent that invalid metadata from existing)? What is the origin of these empty metadata directories?

Oh, do we understand why this issue only affects Python 3.9 and earlier? If the underlying problem is a distribution with no Name, I'd expect that also to cause problems. I guess it doesn't because Distribution.name (or ._normalized_name) happens to return None for these invalid distributions and because the unique check when scanning entry points happens not to care if it gets None where it expects a str. That means that this issue will also affect Python 3.14, where importlib.metadata.Distribution.name will now raise a KeyError when no name is present in the metadata.

Isn't this the problem we were discussing in https://github.com/pypa/pyproject-hooks/pull/195#discussion_r1587336156?
We are in the "complicated zone" when importlib_metadata exists in path.

That said, an egg-info directory containing no metadata is in fact invalid, right? Shouldn't the solution be to address the root cause (prevent that invalid metadata from existing)? What is the origin of these empty metadata directories?

@jaraco, I suspect that this problem is a problem in setuptools because it uses entry-points to generate the .egg-info directory itself. So setuptools create a .egg-info folder, but then it fails while populating it.

@henryiii in https://github.com/pypa/setuptools/pull/4670, I am trying to change the code path so that the conflict between importlib.metadata and importlib_metadata is never reached. Does that solve the problems you initially reported?
You probably can test the PR specific version of setuptools by installing https://github.com/abravalheri/setuptools/archive/refs/heads/issue-pyproject-hooks-206-take2.zip

I could confirm this affecting Debian 11 (i.e. Python 3.9) and Ubuntu 20.04 (i.e. Python 3.8).
My OBS packages are most likely fine with setuptools v59.6.0 (for Python <= 3.7) and v75.2.0 (for Python >= 3.8), but only Debian 11 and Ubuntu 20.04 coming with compile error, see https://build.opensuse.org/project/monitor/home:alvistack?defaults=0&failed=1&arch_x86_64=1&repo_Debian_11=1&repo_xUbuntu_20_04=1:

This happened since pyproject-hooks 1.2 get released; I am now going to pin pyproject-hooks 0.13.1 for those legacy OS, and let's see if it could help the condition :-(

Have you tried updating setuptools? This should have been fixed there.

Have you tried updating setuptools? This should have been fixed there.

Already having setuptools v75.2.0 with Debian 11 and Ubuntu 20.04, but still failing :-(

@jaraco, I suspect that this parish aspect is an issue in setuptools because it uses entry-points to generate the .egg-info directory itself. So setuptools create an empty .egg-info folder, and then it fails while populating it (race-condition-ish unravelled by the change).

In that case, maybe the issue could be addressed in Setuptools by keeping the egg-info directory off sys.path until it's populated.

@jaraco, I suspect that this parish aspect is an issue in setuptools because it uses entry-points to generate the .egg-info directory itself. So setuptools create an empty .egg-info folder, and then it fails while populating it (race-condition-ish unravelled by the change).

In that case, maybe the issue could be addressed in Setuptools by keeping the egg-info directory off sys.path until it's populated.

@jaraco just some quick update that may help: with https://github.com/alvistack/adrienverge-yamllint/commit/3de73c2b3ebb3e352cf4b14c4f18ec71dcdc49d0 I had try to git add --force *.egg-info*' so embed the local pre-build egg-info directory into the source for packaging, but still fail with Debian 11 and Ubuntu 20.04. It seems running install_scripts` step couldn't be triggered.
In case of Ubuntu 22.04 (see https://build.opensuse.org/package/live_build_log/home:alvistack/adrienverge-yamllint-1.35.1/xUbuntu_22.04/x86_64):
[   20s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.10/dist-packages/yamllint/parser.py to parser.cpython-310.pyc
[   20s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.10/dist-packages/yamllint/cli.py to cli.cpython-310.pyc
[   20s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.10/dist-packages/yamllint/config.py to config.cpython-310.pyc
[   20s] running install_egg_info
[   20s] Copying yamllint.egg-info to /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.10/dist-packages/yamllint-1.35.1.egg-info
[   20s] Skipping SOURCES.txt
[   20s] running install_scripts
[   20s] Installing yamllint script to /usr/src/packages/BUILD/debian/tmp/usr/bin
[   20s] find debian/tmp/usr/lib/python*/*-packages -type f -name '*.pyc' -exec rm -rf {} \;
[   20s] fdupes -qnrps debian/tmp/usr/lib/python*/*-packages
[   20s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   20s]    dh_install -O--buildsystem=pybuild
[   20s]    dh_installdocs -O--buildsystem=pybuild
[   20s]    dh_installchangelogs -O--buildsystem=pybuild
[   20s]    dh_systemd_enable -O--buildsystem=pybuild
[   20s]    dh_python3 -O--buildsystem=pybuild
[   21s]    dh_installinit -O--buildsystem=pybuild
[   21s]    dh_systemd_start -O--buildsystem=pybuild
[   21s]    dh_lintian -O--buildsystem=pybuild
[   21s]    dh_perl -O--buildsystem=pybuild
[   21s]    dh_link -O--buildsystem=pybuild
[   21s]    dh_strip_nondeterminism -O--buildsystem=pybuild
[   21s]    dh_compress -O--buildsystem=pybuild
[   21s]    dh_fixperms -O--buildsystem=pybuild
[   21s]    dh_missing -O--buildsystem=pybuild
[   21s]    dh_installdeb -O--buildsystem=pybuild
[   21s]    dh_gencontrol -O--buildsystem=pybuild
[   21s] dpkg-gencontrol: warning: Depends field of package yamllint: substitution variable ${shlibs:Depends} used, but is not defined
[   21s]    dh_md5sums -O--buildsystem=pybuild
[   21s]    dh_builddeb -O--buildsystem=pybuild
[   21s] dpkg-deb: building package 'yamllint' in '../yamllint_1.35.1-1_all.deb'.
[   21s]  dpkg-genbuildinfo -O../python-yamllint_1.35.1-1_amd64.buildinfo
[   21s]  dpkg-genchanges -O../python-yamllint_1.35.1-1_amd64.changes
[   22s] dpkg-genchanges: info: including full source code in upload
[   22s]  dpkg-source --after-build .
[   22s] dpkg-buildpackage: info: full upload (original source is included)

In case of Debian 11 (see https://build.opensuse.org/package/live_build_log/home:alvistack/adrienverge-yamllint-1.35.1/Debian_11/x86_64):
[   34s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.9/dist-packages/yamllint/rules/commas.py to commas.cpython-39.pyc
[   34s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.9/dist-packages/yamllint/rules/anchors.py to anchors.cpython-39.pyc
[   34s] byte-compiling /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.9/dist-packages/yamllint/rules/octal_values.py to octal_values.cpython-39.pyc
[   34s] running install_egg_info
[   34s] Writing /usr/src/packages/BUILD/debian/tmp/usr/lib/python3.9/dist-packages/yamllint-1.35.1.egg-info
[   34s] find debian/tmp/usr/lib/python*/*-packages -type f -name '*.pyc' -exec rm -rf {} \;
[   34s] fdupes -qnrps debian/tmp/usr/lib/python*/*-packages
[   34s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   34s]    dh_install -O--buildsystem=pybuild
[   34s] dh_install: warning: Cannot find (any matches for) "usr/bin/*" (tried in ., debian/tmp)
[   34s]
[   34s] dh_install: warning: yamllint missing files: usr/bin/*
[   34s] dh_install: error: missing files, aborting
[   34s] make: *** [debian/rules:15: binary] Error 25
[   34s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2

In that case, maybe the issue could be addressed in Setuptools by keeping the egg-info directory off sys.path until it's populated.

@jaraco I have already implemented something in setuptools>=75.1.1 that tries to solve that. Initially I was tempted to use a temporary dir and then rename it at the end similar to what you are suggesting (see https://github.com/pypa/setuptools/pull/4670), but I went for a smaller change (call the importlib.metadata APIs before creating the directory, see https://github.com/pypa/setuptools/pull/4680). We can revisit the more holistic approach in https://github.com/pypa/setuptools/pull/4670 if necessary.

@hswong3i could you maybe try to reduce the reproducer to its most basic form using only setuptools APIs (maybe also pypa/build) without the extra Ubuntu/Debian stack on top of it? Please feel free to open an issue in the setuptools repository with the minimum reproducer. Version 75.1.1 should have solved the error related to importlib-metadata initially reported in https://github.com/pypa/pyproject-hooks/issues/206#issue-2568455313. The error traces in https://github.com/pypa/pyproject-hooks/issues/206#issuecomment-2442863422 don't look very similar to the original problem.


input组件中使用:input-attrs="{type:'seach'}"修改input的type无效

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version<EMAIL_ADDRESS>Framework version: vue 3.2.38
Browser: chrome<IP_ADDRESS>

What is expected?
希望相关api有官方实例指引
Steps to reproduce

通过 <Input.Search /> 使用搜索框


[TACHYON-456] Rename tachyon-core to tachyon-servers

https://tachyon.atlassian.net/browse/TACHYON-456
Update module name and move files from core/ to servers/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/3217/
Test PASSed.

+1 LGTM

+1 LGTM. Please also check if documentation need any updates (unless that is planned for later). Thanks!

@abhirajbutala  Thanks for the reminder.
A followup PR (https://github.com/amplab/tachyon/pull/929) cleans up documentation


Add testing for timestamp formats and CI action workflow

This adds the tests for the different formats. As of this PR, it fails on 3.9 and 3.10 since the fromisoformat was made more powerful in 3.11.
To help with the testing, I also created a basic CI action that will test on all available python versions that are supported. If you don't want to include this quite yet, let me know, and I will remove it from the PR. You can see a sample run here: https://github.com/RTnhN/logmerger/actions/runs/11080227626

The CI addition looks good too, I was going to add something very similar. Leave it in.  I'll fix the code so that the pipelines pass.

The CI addition looks good too, I was going to add something very similar. Leave it in. I'll fix the code so that the pipelines pass.

Sounds good. I pushed changes to fix the two problems that you found. Let me know how they look.


Improve search functionality

Look into search libraries, indexing, etc. to improve the site search from simple text-based comparison.

search results page added with https://github.com/anders-swanson/site/commit/874941b0f8b587016dc7639cec6051d022f00bb0

Search is currently disabled, until it can be improved.


Initial attempt to support tuples to parfors.

Partially resolves #5282 This is to get the discussion going.  This patch convert tuples of size less than 10 to individual parameters.  Are the cases we know about with really large counts UniTuples?  If so then maybe conversion to an array would be better?
We can try to generate a better error message in this area where I check types but it is still in lowering.  I can add something to check it before lowering as well.  Thoughts?

I did some work to try to support named tuples.  It kind of works.  The tricky part is re-creating the named tuple inside the gufunc.  I can easily create the correct syntax but that won't compile because the name of the named tuple is an unrecognized global.  My current fix is to lookup the definition of the original tuple var in the original function (that gives something like call $2load_global.0(...)) then get the definition of $2load_global.0 which gives me global(TestNamedTuple: <class 'numba.tests.test_parfors.TestNamedTuple'>).  From that, I can add the equivalent of globls["TestNamedTuple"] = exec(path_to_test_name_tuple_from_the_global) and that globls is used to exec the gufunc into existence.  This isn't very elegant.  Is there a better way?

@DrTodd13 thanks for looking at this. It's now scheduled it for discussion at tomorrow's core dev meeting.

From core developer meeting:

@DrTodd13 to merge https://github.com/numba/numba/pull/5283 into this branch and edit the check/messages as needed.
@stuartarchibald to checkout this branch and see what the impact of tuple size is on LLVM (i.e. does it break ever, what's it do to compilation time and memory etc).
Result of the above will guide how to proceed with any restriction on tuple size.


fix: update deps and unpin was-bindgen over leptos and leptos-use

Failed CIs are related to cached version of cargo-leptos used in workflow even though I updated it. Merging may help.

Failed CIs are related to cached version of cargo-leptos used in workflow even though I updated it. Merging may help.

CI don't use cache, I know I should but eh, the reason is just that you did'nt update cargo-leptos for those tests, see review

Failed CIs are related to cached version of cargo-leptos used in workflow even though I updated it. Merging may help.

CI don't use cache, I know I should but eh, the reason is just that you did'nt update cargo-leptos for those tests, see review

There were multiple of it...

Thanks!


Android, Backup wallet, extra dialog/modal/image display?

From Settings > Backup wallet, after selecting Drive, giving the backup a name and saving, LCW briefly shows the progress modal as expected, but there's another modal / image displayed over the progress indicator (perhaps it's the animated dots).

Not a problem, Android / Drive "Preparing to upload your file"

Not a problem, Android / Drive "Preparing to upload your file"


Clarify instructions on city office

See exercism forum post for details.
I read through the instructions and also found, that when one has some knowledge about PHPDoc comments (or JSDoc or JavaDoc) the wording is misleading.
I rephrased the instructions to reflect the intended PHP type declarations / type hints.

I really must read more of the docs while writing...it was type hints all over the docs until Oct 9, 2021. Thanks for proof reading!


Errors with asciidoctor-pdf

When I try to run the following command:
asciidoctor-pdf -r asciidoctor-bibliography sample-default.adoc
I see these errors:
asciidoctor: ERROR: failed to parse formatted text: Hello this is from the paper [1], [2]
asciidoctor: ERROR: failed to parse formatted text: [3]
asciidoctor: ERROR: failed to parse formatted text: [3, P. 10]
asciidoctor: ERROR: failed to parse formatted text: [3, Ch. 10]
asciidoctor: ERROR: failed to parse formatted text: [3, P. 10]
asciidoctor: ERROR: failed to parse formatted text: [1, P. 42], [2, Op. 12]

Do I need to do anything special for asciidoctor-pdf to work?
If I run the normal asciidoctor command asciidoctor -r asciidoctor-bibliography sample-default.adoc it works as expected and I get the correct html file.

Works fine for me (more than one year later).

Works fine for me (more than one year later).

I encountered this error as well after changing from Harvard to IEEE style, so I did some looking into it and found this thread.
TLDR: the problem is that asciidoctor-pdf doesn't support the escaped square brackets used by asciidoctor-bibliography ([ and ]) and instead requires them to be written in their numeric forms (&#91 and ])


Setuptools and Values from Environment Variables

In docs it only says how to usem with the __name__ fuction, but I'm using Setuptools.
Can you document how do we do this?

I'm not sure 100% what you are asking for.
The documentation on environment variables is here:
https://click.palletsprojects.com/en/7.x/options/#values-from-environment-variables
The documentation for using setuptools and click is here:
https://click.palletsprojects.com/en/7.x/setuptools/?highlight=setuptools
Something like this should work with setuptools.
@click.command()
@click.argument('src', envvar='SRC', type=click.File('r'))
def echo(src):
    """Print value of SRC environment variable."""
    click.echo(src.read())

Sorry, I wasn't clear. How to use auto_envvar_prefix with a project with Setuptools:
@click.command()
@click.option('--username')
def greet(username):
    click.echo('Hello %s!' % username)

if __name__ == '__main__':
    greet(auto_envvar_prefix='GREETER')

I don't have this if __name__ == '__main__' on my project.
How could we use that on the setuptools example? I think that's missing on the docs.

I see what you mean. I don't think that particular scenario is shown anywhere explicitly outside the api docs.
auto_envar_prefix is a parameter under context in the api docs, so it could be passed in a context dictionary.  https://click.palletsprojects.com/en/7.x/api/?highlight=context settings#context

I have tried something like this:
CONTEXT_SETTINGS = dict(
    help_option_names=['-h', '--help'],
    auto_envvar_prefix='COZER'
)

# ...

@click.group(cls=DYMGroup, context_settings=CONTEXT_SETTINGS)
@click.version_option()
def cli():
#...

@click.option('-r','--recipiente','recipiente',metavar='<recipiente>', envvar="RECIPIENTE", show_envvar=True, required=True)
@click.option('--como', 'como', metavar='<descricao>', help='descrição de como deve ser realizado a operação, ex: --como "com cuidado para não quebrar"')
#...

I have tried:
export COZER_RECIPIENTE=oiooo
export COZER_COMO="que bom"
export COZER_DESCRICAO="que bom"

export RECIPIENTE=oi  # only this one works... but doesn't have the prefix

I don't know how to call it. Is there an example somewhere?

I made a small code, can you help with this one?
https://gist.github.com/edusantana/dd484f492c3310745ae51a409bb2810a

def main():
    greet(auto_envvar_prefix='GREETER')

Point the entry point at main.


ci-automation: Fix unbound variable errors

FLATCAR_VERSION and FLATCAR_SDK_VERSION are defined in the version
file, so it should be sourced before trying to use those. Here we try
to do it in a limited scope.
Also, SDK container link should use the dockerized version in a
directory name.
Should fix an issue that appeared during nightly:
Your branch is up to date with 'origin/main'.
/home/build/workspace/workspace/container/sdk/scripts
jenkins/systemd-run-wrap.sh: line 110: FLATCAR_SDK_VERSION: unbound variable
Finished with result: exit-code
Main processes terminated with: code=exited/status=1

Cherry picked to 3227, 3277, 3346, 3033 and 2605.

Hm, looks like you already did it, and my script did nothing. :) Thanks.

We have this SHOW_PATCHES=0 ~/kinvolk/flatcar-build-scripts/is-pr-in-branches https://github.com/flatcar/scripts/pull/510 helper to quickly check but GitHub also shows it here now :)


Team 10 Review

Missing email generation component in FMEA table that can introduce some hazards.

Added a failure mode for email generation


Add Support for AutoModelForSequenceClassification Models

Feature request
LoRAX currently only supports text generation models (e.g., causal language models). It lacks support for sequence classification models like AutoModelForSequenceClassification. This issue proposes adding support for AutoModelForSequenceClassification models to LoRAX. This would enable users to serve and perform inference with fine-tuned sequence classification models. This would expand LoRAX's capabilities, allowing users to serve a wider range of models and perform tasks like sentiment analysis, topic classification, and more.
Motivation
Currently, users who want to serve sequence classification models with LoRAX have to rely on external inference APIs or implement their own solutions. This can be cumbersome and less efficient. Adding native support for AutoModelForSequenceClassification would streamline the process and make LoRAX more versatile.
Your contribution
I'm willing to contribute to this feature.

+1 This would be very useful.


Create packages and jobs for Harbor bosh-release

Might be:
packages
- Docker
- docker-compose
- Harbor
-python?
jobs:
- harbor
- smoke-test?

Create packages:

docker
docker-compose
common
harbor app

create job harbor


Add existing imagePullSecrets support in addition to credentials

Add support of existing imagePullSecrets in addition to registry credential

@arzhr Is this something you will eventually work on again? We need that feature too and would be happy to take over/continue.

Closing as stale


Inserting new images inside the existing gallery

Hello again,
(There's no wiki or mail list about bootsy, and I have no idea where I post my doubts.)
In new action  of my controller, Bootsy allows me to upload local files to store inside my application. And  the bootsy_image_gallery columns seems ok. All fields is populated properly, like this (real) example:
#<Bootsy::ImageGallery id: 43, bootsy_resource_id: 11, bootsy_resource_type: "Doc", created_at: "2016-05-02 18:56:21", updated_at: "2016-05-02 18:56:48">
I imagine, the bootsy_resource_id is my doc.id. (Right?)
My controller has :bootsy_image_gallery_id strong parameter, and my model has include Bootsy::Container
But when I call edit action of Doc, my Bootsy cannot open gallery, only shows the URL http:// to insert images.
Thanks in advance. :smile:

It's hard to help without having an app that reproduces the error. My best guess is that you probably have an issue with the form on the edit page.

The application is a legacy application that uses a lot of gems and (some) integration with cloud services, now I'm in process to migrate the application to use local storage, and doesn't depends of cloud services anymore.
I'm reporting here the major "difficulties" here. Because I don't know if it is a common behavior, a issue, or is a casual situation that other people face in use of Bootsy.
I really appreciate this gem. :smiley:  And I know, the legacy application has a many ways to conflicts with Bootsy (and some others gems), and I only report here, some behavior that I really have doubts about it.
Now, I'll investigate the app looking for the conflicts. (I only needed to know, if the gallery is available in edit action, and looking in the sources I found it)
Thanks.


traffic metrics check in

At this point, there are both linkerd and istio implementations of the traffic metrics piece of the spec in the smi-metric repo.
@grampelberg @pothulapati - do ya'll have any thoughts or want to propose any changes at this point? Would love to hear feedback from any other folks who have implemented it as well.

I have been working with @nicholasjackson to add the support for Consul Connect! It required k8s metadata to be a part of the envoy metrics. Once that is done, It wouldnt be that hard to add the support for it.
Also, @nicholasjackson has some idea's on improving the spec.

@grampelberg do u know the Kiali folks' github handles? How do we get in touch with them?

Alas, I don't have any good connections, just a ton of respect for the product.

cc @lucasponce @jotak @jmazzitelli

Hi @michelleN @grampelberg ,
We discussed a little bit about that a couple of months ago ( https://github.com/deislabs/smi-spec/issues/43 ) but TBH there hasn't been much time spent here on our side. I don't know if there's some news in SMI spec about the items discussed in that issue?

Hi @michelleN we have IRC in freenode or Slack in istio.io.
Also you can create any issue in Kiali project as well.

@jotak that's a great starting point, I wanted to make sure that was all still valid and such. I'm gonna need to dig into the kiali code a little bit to get a better feel for how you're using everything.

The core kiali graph code is here: https://github.com/kiali/kiali/blob/master/graph/telemetry/istio/istio.go
You can see how we utilize the telemetry in Prometheus.
@jshaughn is the subject-matter-expert for that code

Alas, I don't have any good connections, just a ton of respect for the product.
o
@grampelberg thanks for the feedback! Happy to see this.

@grampelberg A little while back I re-organized the graph code in Kiali to better prepare for possible addition of a non-istio telemetry vendor.  If SMI now offers a fleshed-out API that can front-end Istio it would be a nice experiment to see what we could generate using the SMI telemetry API in addition to having the explicit Istio impl.  If promising then we'd be able to potentially provide some support for non-istio mesh, like Linkerd and whatever else that may become available.

@jshaughn We now have a functioning implementation of SMI metrics for Istio here. How can we help with getting Kiali to attempt to utilize the SMI metrics APIs?

I guess what would need to happen is to start work on a Kiali graph "telemetry vendor".  Today the only supported vendor is "istio", meaning we directly query prometheus for istio metrics, and we directly query istio/k8s for any additional resource info (namespaces, services, worklods, etc).  The root of the code is here.  The api package shows the entry points to graph generation.  In telemetry/istio is the istio package, holding all of the graph gen code.  We'd want to start a new provider like telemetry\smi that could start serving up a valid TrafficMap data structure in response to API requests.  It won't be super straightforward but perhaps you could use SMI "deployment" resources for "workload" or something like that.  Kiali does not try to visualize pod-level metrics, but rather higher level aggregates.