Geolite Database dependency

Geolite database is used for testing GeoIP feature in OpenSearch, it has sample data to test against.
It uses mmdb  format built by Maxmind (https://dev.maxmind.com/geoip/geoip2/geolite2/).
Today we just depend on Elastic to get this information and we have to build our own sample data to remove the dependency.
org.elasticsearch:geolite2-databases:20191119 is used in the ingest-geoip processor for tests.
https://github.com/opensearch-project/OpenSearch/blob/main/modules/ingest-geoip/build.gradle#L48

@saratvemulapalli maybe edit this issue to say what we actually want to do here?

Hi @saratvemulapalli, I see PL already submitted to replace elasticsearch dependencies. Could you please close the issue if there is nothing else pending.

Closing the issue, please feel free to re-open if needed

@anasalkouz some how i missed this.
I know we have taken care of Securemock, mocksocket and JNA.
But did we also remove the geolite test data dependency?

@anasalkouz some how i missed this. I know we have taken care of Securemock, mocksocket and JNA. But did we also remove the geolite test data dependency?

I am pretty sure we haven't. Do you know where this is and how it's used @saratvemulapalli?

Yup, looks like its not.
Ref: https://github.com/opensearch-project/OpenSearch/blob/main/modules/ingest-geoip/build.gradle#L48

This is a dependency we need to get rid of but we are still using it for Search. @anasalkouz  is this something you can look into since it is related to Search?

attempting to trim down a docker image I came across modules/ingest-geoip/GeoLite2-City.mmdb today which still ships with opensearch-2.6.0-linux-x64.tar.gz.
Is this supposed to be there? I was under the impression that maxmind forbids redistribution of the geolite2 database, especially if they're older than 30 days (https://www.maxmind.com/en/geolite2/eula 6c)
(If I'm misunderstanding this and the files shipped with opensearch are up to date and properly redistributable... even better)

@vamshin ^

Hi @unilynx, could you kindly share what was your reason of trimming down a docker image?


PyPdu: Histogram diffs

histA = histSeries[0]
histB = histSeries[1]
delta = histB - histA
delta.buckets()

Implemented in v0.0.13, commit 4ee171e


Persistent Drawer with No Icons

Describe the desired behavior
Make the persistent Drawer look good when closed without icons.
Describe the current behavior
It doesn't.  The text overlaps.
Is this request related to a current issue?
No
Additional Context

What is going to be the default appearance for the closed nav items with icons?
Should we shrink the text or hide the text?


Add operation_list to radiotherm

Description:
Add operation_list to radiotherm platform so the mode selector UI populates options.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for configuration.yaml (if applicable):

climate:
  - platform: radiotherm
    host:
      - <IP_ADDRESS>
    hold_temp: True

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If code communicates with devices, web services, or a:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

You have a lint error and a comment. 🐬  when both addressed


Update ISic

Many thanks for your comments and sorry about the many oversights, hopefully all fixed now!


Do not show wp embeds in AMP

amp-iframe resizing doesn't work with iframes from the same domain. Revert changes in https://github.com/frontity/saturn-theme/pull/188 and use the processor when the build is AMP.
Related to #74

:tada: This issue has been resolved in version 0.12.9 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

follow deploy

follow deploy


Fix Page element attributes

Let's make them in the same format as the rest of the schema

Talked with the Kavita developer and it looks like no one uses the Page element, so we are going to drop it.
refer to: #40


Command: yank

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/1197513-command-yank?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

Migrated to limetext/lime-backend#42.


Updates for jikanpy_v4 release

Addressing #103 I've gone ahead and updated a few things in getting ready to push the new package:
New Package Name: jikanpy_v4
As discussed in #103, there are potentially people who still rely on jikanpy for functionality on self-hosted versions of Jikan v3. So the plan is to publish the updated version as jikanpy_v4 on pypi. The old version will be untouched and the source code has been moved to the branch jikanpy_v3.
New Changelog
Since jikanpy_v4 will be its own package I decided we should start over with the changelog. The history could be nice to have, but considering the version numbers won't match I thought it would be confusing. That being said, I figure version 1.0.0 is a good place to start.
Misc README Updates
All of the links should be updated correctly and new install install instructions have been included.
Authorship and License
@abhinavk99 what do you think of putting myself as the author for this when pushing to pypi?  I've also included myself on the license file, if this is alright with you.
Docs
The last thing we probably want to consider is the readthedocs page. Currently, I believe it reads from the master branch although I'm not entirely sure how it works. Perhaps we want to make separate pages for the new and old versions?
If you approve of these changes @abhinavk99 I'll go ahead and merge to master and push to pypi.

When will jikanpy_v4 be on pypi? Can't currently find it

@BisericaOrtodoxa I should be able to have it up today. Workin on it now.


A daily post to #Announcement channel of the days' events

Perhaps the target channel would be configurable, depending on where users would want to see this information. (Perhaps some users would prefer #general or #resources or #bookings or #somethingelse.)
Sort by time (chronological) or subgroup by venue?
Possible format:
Here's the events happening at [Church Name] today!
Women's Bible Study
Room 105 (1300-1430)
resources.planningcenter.com/eventIDurl
Thursday Night Basketball
Gymnatorium A (1800-2230)
resources.planningcenter.com/eventID2url

I love this idea! Long term I'd like to see sms support and integrated sms lists so this would be fantastic to txt out as well!

We could roll the birthday's #15 into this same feature.

Scheduled announcements can be placed here:
https://github.com/pastorhudson/pcobot/blob/master/plugins/pco/announcements.py
Perhaps call the related functions directly when making an announcement?
pco_setlist_lookup(self, message, sunday

Look at the will.plugins.admin.keepalive.py
There is a ping command that is called as a webhook from /ping. It has no channel info and doesn't receive or pass a message object in the say command. I bet if you just don't take or give message object it will post in default channel. Default channel can then be set to announcements.
@route("/ping")
    def ping(self):
        self.say("Someone pinged me!")
        return "PONG"

I have a proof-of-concept working for calling a WillPlugin function from within another WillPlugin.
https://github.com/pastorhudson/pcobot/pull/55
Now we just need to create the Resources functions that will return events.

Do you have any ideas how this could be turned on and off through slack? A guiding principle for this project is that we need to be able to control things through slack. So what if I want to turn off birthday notifications? Or turn on setlist?


Simplification proposal

Updated document
Contains the following amendments:

Added usage guidance, to hopefully make it clearer what the protocol achieves
Removed any Opdex-specific backend implementation information, as the protocol should not be concerned with this
Replaced the base64-encoded JSON payload with the Stratis ID URI

Easier dApp implementation - no need to encode base64 or JSON
Easier wallet implementation - no need to decode base64 or JSON
Shorter - easier and quicker to scan the QR code

Added a requirement for the callback URI to be HTTPS
Included dApp implementation requirements

WRT to signature expiration, I can think of 3 separate options:

dApp uses a database to store signatures
dApp generates an expiry datetime as query string &exp=1668427584 that is signed in the callback
Wallet uses a default expiry to insert into callback before signing

1. Database
2. Query String
3. Wallet Default

Advantages
Disadvantages
Advantages
Disadvantages
Advantages
Disadvantages

      - Easy for wallet

      - dApp determines whether a signature can be reused or not

      - Requires dApp to use a database

      - More complexity for dApp

      - Centralization encouraged over security

      - Problem of no signature expiry still exists

      - Fully flexible

      - Easy for wallet

      - Signatures can be reused

      - dApp must set sensible expiry

      - Larger QR code

      - Signatures can be reused

      - Can enforce a sensible expiry

      - Signatures may be able to be reused

      - dApp cannot determine expiry period

      - Signatures may be able to be reused

I've gone ahead and amended to use option 2. My thought is that it would be useful to include signature expiration within the protocol, however it should not be mandated and should be as flexible as possible for the dApp.

I think the query strings are a good idea vs a specific nonce, the entire callback URL can be the message that is signed.
This doc can expand overtime suggesting more query strings that wallets can choose to integrate with or not
Expiry is fine in the query string for the wallets to act on but I think this spec should still encourage storing to validate against the returned signature. Any API running multiple instances will need to do something of this sort anyways and in between retrieving the QR code and signing the message, the expiry can be changed. It's somewhat worthless if the dapp being authenticated doesn't enforce it.


Cannot use GraphicsPipelineAbstract in draw_indexed function if using a tuple as VertexSource

Related to #1429 and #676.
The response in #676 implies that one can use a Arc<GraphicsPipelineAbstract + Send + Sync> instead of a Arc<GraphicsPipelineAbstract> for a pipeline in a struct in order to issue a call to draw_indexed. However, this only works if sending a Vec<Box<dyn BufferAccess + Send + Sync>> as the VertexSource. Attempting to use a tuple as a VertexSource gives the following:
error[E0277]: the size for values of type `dyn vulkano::pipeline::GraphicsPipelineAbstract + std::marker::Send + std::marker::Sync` cannot be known at compilation time
   --> keeshond/src/renderer/vulkan.rs:295:29
    |
295 |                     builder.draw_indexed::<(BufferSlice<[Vertex], &Arc<ImmutableBuffer<[Vertex]>>>, BufferSlice<[&VertexInstance], &Arc<CpuAccessibleBuffer<[&VertexInstance]>>>), _, _, _, _, _>
    |                             ^^^^^^^^^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `dyn vulkano::pipeline::GraphicsPipelineAbstract + std::marker::Send + std::marker::Sync`
    = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
    = note: required because of the requirements on the impl of `vulkano::pipeline::vertex::VertexSource<(vulkano::buffer::BufferSlice<[renderer::vulkan::Vertex], &std::sync::Arc<vulkano::buffer::ImmutableBuffer<[renderer::vulkan::Vertex]>>>, vulkano::buffer::BufferSlice<[&renderer::vulkan::VertexInstance], &std::sync::Arc<vulkano::buffer::CpuAccessibleBuffer<[&renderer::vulkan::VertexInstance]>>>)>` for `dyn vulkano::pipeline::GraphicsPipelineAbstract + std::marker::Send + std::marker::Sync`
    = note: required because of the requirements on the impl of `vulkano::pipeline::vertex::VertexSource<(vulkano::buffer::BufferSlice<[renderer::vulkan::Vertex], &std::sync::Arc<vulkano::buffer::ImmutableBuffer<[renderer::vulkan::Vertex]>>>, vulkano::buffer::BufferSlice<[&renderer::vulkan::VertexInstance], &std::sync::Arc<vulkano::buffer::CpuAccessibleBuffer<[&renderer::vulkan::VertexInstance]>>>)>` for `std::sync::Arc<dyn vulkano::pipeline::GraphicsPipelineAbstract + std::marker::Send + std::marker::Sync>`

How do I make the call to draw_indexed in this scenario, where I need to pass a Vertex and Instance buffer, and the pipeline needs to be stored in a struct?

The way that vertex buffers are specified is completely different now, and GraphicsPipelineAbstract doesn't exist anymore either. So this can be closed.


#![feature] may not be used on the stable release channel

Hi,
I'm on step 02_runtime_init and when i try to make qemu compilation fails with next error
Compiling kernel - rpi3
   Compiling tock-registers v0.6.0
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /Users/myuser/.cargo/registry/src/github.com-1ecc6299db9ec823/tock-registers-0.6.0/src/lib.rs:5:1
  |
5 | #![feature(const_fn)]
  | ^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0554`.
error: could not compile `tock-registers`

To learn more, run the command again with --verbose.
make: *** [target/aarch64-unknown-none-softfloat/release/kernel] Error 101

Would be very thankful to any help with it.

Issue was in missing rust-toolchain file


Rename ExpansionPanel

Cleanup
What should be cleaned up or changed:
The ExpansionPanel component was renamed to Accordion and
the change generated errors at the console.
Provide any links for context:
https://ibb.co/zXkxpPQ
that's my suggestion

Hi @silvanavlima good suggestion. Feel free to open a PR to us with :)

fixed by https://github.com/ResultadosDigitais/matrix/pull/351


Navigation drawer and romanian translation update

Hi, can you provide a description of the changes in this pull request? Why did you change the height of the navigation drawer from the default height resource to 144dp?

Also, this should be separated into two PRs, instead of one.

@fadils i refered to http://www.google.com/design/spec/patterns/navigation-drawer.html, followed the specs and come up with this, as you told me in #693. What i did wrong?

@danielFerecatu why close the PR? You can answer some of my questions above (and Ezra's), then revise the PR.
We all want good, clean code and clear git history. Going back and forth during PRs is pretty usual and you shouldn't be discouraged by it..

@fadils i'm not discouraged by it but all this thing with github is new for me and i barely know how things work, i don't have a workflow in Android Studio and beside that i don't even know Java programing. I wanted to contribute somehow but this project is far bigger than i thought and realised that this isn't appropriate for me.
I closed this PR because i want the people that know what they are doing to manage it, but still i'll answer the questions if you are willing to know my opinion.
Probably an new PR with romanian translation updated will be my last on this repo because i want this app in my language too :smiley:
I hope that a newer version will be in play store soon and good luck with it.


Fix BatchedMatMul bugs

Fixed https://github.com/gorgonia/gorgonia/issues/552
Three things in BatchedMatMul function included.
When BatchedMatMul is performed on matrix with (1, 1) shape, it will return error as the Slice operation will return a scalar as the operand. This will cause matrix multiplication requirements invalid.
Originally if the matrix C for result of matrix A x B is nil, its shape will be set to pre-defined A.row and B.col. But if transpose flag is set for either A or B, the matrix for C will be set incorrectly as it doesn't consider the transposition.
Fix incorrect newShape for matrix C re-uses the slice backing data by adding Clone for newShape.

LGTM. Merged. I've also sent you an email @wzzhu


'content' ignored in '::before' pseudo declarations

For some reason the 'content' property is ignored in '::before' pseudo element declarations.

The content property needs to be wrapped in quotes in CSS, so in JS it needs to be "double-wrapped", e.g. {content: '"foo"'}. Maybe what you're experiencing could be due to this?

@rtsao thanks for getting back, I tried your suggestion, it works like a charm.


Stopped working with latest Alexa update

Wemos D1 mini and relay setup has been working consistently until today.
The Alexa app can no longer find it when detecting devices

Any changes in your WiFi? Could you provide more details, such as WiFi pw changed, type of router / accesspoint, visibility of the Wemos in your LAN, did Alexa an update etc. ? Mine still working fine (multiple, different ESP devices), so Alexa still seems to be stable.
Am 05.12.2018 um 20:46 schrieb pacostello <notifications<EMAIL_ADDRESS>Wemos D1 mini and relay setup has been working consistently until today.
The Alexa app can no longer find it when detecting devices
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/kakopappa/arduino-esp8266-alexa-wemo-switch/issues/39, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKwM-3z_Vdxw0U-5KkiQSEm1NUp1sZ5Zks5u2CKHgaJpZM4ZEqcl.

No changes to my network so all I can think is an Alexa update. I can see and ping the wemos as normal.
I am in the UK so may get different updates to other countries

Somehow it is now working. Switched it off and on again and it's now detecting it.
Sorry to waste your time.

 Be happy - it works :-)
Am 05.12.2018 um 21:12 schrieb pacostello <notifications<EMAIL_ADDRESS>Somehow it is now working. Switched it off and on again and it's now detecting it.
Sorry to waste your time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/kakopappa/arduino-esp8266-alexa-wemo-switch/issues/39#issuecomment-444629080, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKwM-z2cWyEy5VlOBXVH84r1zo2d_0ylks5u2CiSgaJpZM4ZEqcl.


Synchronization of histogram widgets

All widget endpoints are going to return the data with and without their filters applied so that widgets can be refreshed/synchronised correclty.

There has been no activity on this issue for several months and that's why we are closing it (automatically). If you think this still needs to be addressed please reopen it. The good news is that we are now working on the next version of CARTO.js, stay tuned.


iOS App Signer

ERROR：A valid provisioning profile for this executable was not found.

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

Yes

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

Yes

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

噗..你可以来中国UTM群，QQ群：1051884885

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

Yes

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

噗..你可以来中国UTM群，QQ群：1051884885
I don't quite understand. Can you speak English?

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

Yes

You need to create a provisioning profile for utm on developer.apple.com, if you are a developer, you should know how to do it

Do I need to enroll in ‘Apple developer program’ which is 99$ per year?

噗..你可以来中国UTM群，QQ群：1051884885

I don't quite understand. Can you speak English?

@cs-sugar I used google translate to translate and here it is in english:
Puff.. You can come to China UTM group, QQ group:<PHONE_NUMBER>


JS lambda runtime to Rust

This is a work in progress.
Issue # (if available)
Description of changes

This PR migrates the current runtime of js to rust.

Add runtime in Rust.
Change the call of<EMAIL_ADDRESS>to src/runtime.rs

Checklist

[ ] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[ ] Made sure my code didn't add any additional warnings: make check
[ ] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I've converted this PR to a draft because the implementation is not complete. It looks like returning responses, and errors are not implemented.

Yeah that's true,  I should have made it like that since the beginning :sweat_smile:

I would recommend to adopt Tower service trait for runtime implementation. It is battle tested and extensible with the Tower eco-system.
To support both buffered response and streaming response, the response from the handler should be a trait like IntoResponse.
Lambda Rust runtime is a good starting point. Recommend to take a look.

I would recommend to adopt Tower service trait for runtime implementation. It is battle tested and extensible with the Tower eco-system.

I recon this would a bit to much complexity for the capabilities that we need. Although, I have not worked with tower before so can't make the best judgement. @bnusunny how "heavy" is it in terms of deps and increased binary size?

Tower is a light package. Here is the cargo-depsize results.


Update build script to the Zig HEAD version

I merged your PR and regenerated to reflect the changes in raylib/raygui.
Thanks again :)


Game score prompt - conditional

Have the game only prompt for a score if it was built with the leaderboard API URL + PSK

The game now stores the required data for accessing the leaderboard in a config object in /Resources. During scene load it checks whether the config is enabled and tries to log in. If it's disabled or the login failed the "post your score" prompt remains hidden.


[GHSA-r23g-3qw4-gfh2] RedCloth Cross-site Scripting vulnerability

Updates

Affected products

Comments
Fix package name's case (s/redcloth/RedCloth). To verify change, see https://rubygems.org/gems/RedCloth web site.

Good morning @jasnow! I checked the JSON file for GHSA-r23g-3qw4-gfh2, and RedCloth already has the proper capitalization. This is an instance of a bug that prevents RubyGems package names from appearing as anything other than all lowercase on the github.com/advisories pages.
https://github.com/github/advisory-database/blob/6a137bfd822977ab84ea195de052a85541fe13ae/advisories/github-reviewed/2017/10/GHSA-r23g-3qw4-gfh2/GHSA-r23g-3qw4-gfh2.json#L18
There's an ongoing issue related to Rubygems packages appearing as all lowercase on advisory pages regardless of whether any capital letters are used in package names in the JSON files. You can read more about it here: https://github.com/github/advisory-database/issues/52#issuecomment-1499691164


Discrepancy with re-frame API in terms of event IDs

Documentation of reg-event-db and reg-event-fx says: id is typically a namespaced keyword  (but can be anything). So, it can be an ICollection, but in order for such event IDs to work with re-frame-async-flow-fx, they have to be wrapped in yet another collection.

As there seems nothing to action at this point, closing.


Event Images<>Text correlation

seems the images and text of the events do not match

Closing as this was a Road to Devcon issue. No longer relevant.


Samples are too wide

Some of the samples on this page are both tall and wide. This means that the reader often needs to use a horizontal scroll bar that is off the bottom of the screen. Would it be possible to add some wrapping in to make them fit a bit better please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd35c7d9-2c89-45b8-24e3-c06c746e0260
Version Independent ID: 98d24e04-582a-52fa-1b4b-63a514064cc9
Content: How to: Implement a Discoverable Service that Registers with the Discovery Proxy
Content Source: docs/framework/wcf/feature-details/discoverable-service-that-registers-with-the-discovery-proxy.md
Product: dotnet-framework
GitHub Login: @Lxiamail
Microsoft Alias: wcfsrvt

Thanks for your comments @martingbrown.
Site feedback should be logged at https://aka.ms/sitefeedback.
But I think the samples on this page can be changed a bit to not rely on the need of scrollbars.
For example,
AnnouncementEndpoint announcementEndpoint =
    new AnnouncementEndpoint(new NetTcpBinding(), new EndpointAddress(announcementEndpointAddress));

Would you like to submit a PR to change this?


Elements selection/focus should be disabled when swiping/dragging

Ionic version:  (check one with "x")
[x] 3.x
[x] 4.x
I'm submitting a ...  (check one with "x")
[x] bug report
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
When do the swipe "ion-button" element stay selected:

Expected behavior:
Elements selection/focus should be disabled when swiping/dragging.
Steps to reproduce:

Create a list of buttons
Try swipe back

insert short code snippets here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
$ ionic info

cli packages: (/Users/shal/my_projects/ios-app/node_modules)

    @ionic/cli-utils  : 1.10.2
    ionic (Ionic CLI) : 3.10.3

global packages:

    Cordova CLI : 7.0.1

local packages:

    @ionic/app-scripts : 2.1.3
    Cordova Platforms  : ios 4.4.0
    Ionic Framework    : ionic-angular 3.6.0

System:

    ios-deploy : 1.9.1
    Node       : v8.2.1
    npm        : 5.3.0
    OS         : macOS Sierra
    Xcode      : Xcode 8.3.3 Build version 8E3004b

cordova-plugin-wkwebview-engine 1.1.6 "Cordova WKWebView Engine"

Hello! Thank you for opening an issue with us! Would you be able to provide a sample application via GitHub that demonstrates the issue you are having?
Thanks for using Ionic!

Closing due to inactivity. If you can provide a sample application via GitHub that we can use to troubleshoot this issue I will be happy to reopen it.


model 803 repeated string group count should be top level NStr

Model 803 has a repeated group named string, which currently has its count attribute incorrectly set to 0 within the json specification file.
According to the device information model specification, such count attribute should be (section 4.1.2):

defined as a constant in the point group definition or be specified as the value of another point in the model definition. If the point group count is specified in another point, that point MUST be defined in the top-level point group of the model before the point group definition.

As far as I understand, the current 0 value works with pysunspec2 because of a feature deducing the number of repetitions in the group based on the group length and the parent group lenght.
In the case of model 803, the strings group will be repeated once per spring, s.t. count should be NStr: the number of string in the bank.
This PR fixes the model 803 json specification specification, in a similar way as is done in other models (e.g. model 705)

Hi sv3ndk,
Model 803 is one of the legacy models that was written in XML. The old format is indicated by defining the repeating block with a count of 0 in the model definition. It is constructed based on the rules of legacy models. And any change to it would cause issues with backward compatibility.

Hi Kudrat9,
Thanks for the explanation, I now understand why we can't change this model specification file.
Since this  behaviour needs to be maintained for legacy models, how about it be mentioned in the spec (or maybe it's there and we missed it?)? Our team is currently using those files outside of pysunspec2, in a server-side library, and were surprised to stumble upon those 0 values.

Hi sv3ndk,
I will check with my internal team and get back to you.


add php8.1 support

fixes #12

Any idea when this feature can be add :) I have the same issue with php 8.1 :(

@fheider @schmidfelix hoping we can get this merged soon 🙏

@schmidfelix i updated the dependencies


Spooky 8 Ball

Nice and clean eight ball setup. Made a few solid Halloween type responses. Made it so that either there will be a single message response or 2 messages to make it look like the eightball is thinking or talking to the 'powers above'.

closes #12

@jodth07 in terms of the sleep it should be an asyncio sleep.

@jodth07 in terms of the sleep it should be an asyncio sleep.

I think what he means by this is that if multiple people are using this command in the same channel, it isn't clear which output is for what question (if that makes sense)

I feel you. We can sort out a little embed with the title as the question and the answer below.

Regarding the sleep/embeds I haven't had a change to make the changes. Will attempt to get them made and sent today.

Regarding the sleep/embeds I haven't had a change to make the changes. Will attempt to get them made and sent today.

Whenever you are ready

I finished implantation of a command, just need to add the results/answers of the 8ball

Hi @RohanRadia, have you found some time to make the desired updates?

Hey @sco1 - Forgot about this. Will make the updates and submit within 72 hours. Sound good?

Changes made @sco1 @jodth07 - ready for merge I believe. Made all changes as requested.

So you don't want an embed? @sco1 - I thought show in the questions and answer was decent. We could have an embed for the basic one too. Your choice. LMK.

We try to limit embeds as much as possible since they can take up a significant amount of room; I don't think this cog suffers by not having it and this keeps the behavior consistent with the existing 8ball command.
That aside, if we are including embeds then the behavior should be consistent across the cog.


Update Documentation

This is an issue / project scheduled for the CRS developer summit in October 2021. This is supposed to take several days.
There is a separate wiki page for this project: DevRetreat21UpdateDocumentation

The foundations have been laid for the new documentation system.
Most of the agreed-upon sections now exist, however a few still need to be created.
Some content needs to be moved. Much content still needs to be written. Much content needs to be checked and possibly reworked.


[Feature] [Backend] support build be with c++20

Proposed changes
Issue Number: close #9312
Problem Summary:
Describe the overview of changes.
Checklist(Required)

Does it affect the original behavior: (Yes/No/I Don't know)
Has unit tests been added: (Yes/No/No Need)
Has document been added or modified: (Yes/No/No Need)
Does it need to update dependencies: (Yes/No)
Are there any changes that cannot be rolled back: (Yes/No)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Wow

you need to update dist/LICENSES-dist.txt


Remove vertexSkinning and vertexAnimation from GLShader_generic2D

UI, which is what this shader is used for, doesn't have bones (vertexSkinning). It also doesn't use .md3/.mdc (vertexAnimation is used to interpolate vertices in those formats).
I'm not entirely sure if vertexSprite is unused, so I've kept it there for now.

There's a lot more stuff that should be removed from the generic2d shader. It was made by copy and pasting one for 3D rendering without deleting any of the 3D-specific stuff

I'm aware, yeah. I haven't checked which other stuff can be removed there.


⚠ Elibs has degraded performance

In 42ee780, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 5697 ms

Resolved: Elibs performance has improved in 6e786f5.


Fix copyright 2015-2016 => 2015-2017

It seems that the end of period of copyright is 2017.
So I fixed it :)

Thanks!


Fix checking if nonblocking sockets work on OpenBSD

diff by Todd C. Miller
https://marc.info/?l=openbsd-tech&m=166189857323524&w=2

Thank you for the patch! Committed it. The change to configure happens when autoconf is run, no need to make changes to configure.ac.


[Enhancement] switch the spill IOTaskExecutor to ScanExecutor

Fixes #issue
Switch the spill IOTaskExecutor to workgroup::ScanExecutor, to leverage resource group isolation.
According to the performance test:

With pipeline_sink_io_pool, it cannot isolate resource at all
With the ScanExecutor, it could optimize the resource isolation to some extent, but not ideal.

What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

@Mergifyio rebase

@Mergifyio backport branch-3.1


fix unable to find modules

Fixes #262
you dont need to include the 'package.json' in the require.resolve which solves the
unable to find xyz, are you sure xyz is installed? message
also fixes if you use @types/ dependencies as they cant be included because they dont have any main

Yes, these messages are pretty annoying in the development workflow


unexpected EOF

While running CC under Windows (!) I've managed to resolve all issues, but this one:
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
unexpected EOF, unexpected EOF
too many errors

How can I debug this? How to organise error line reporting or something, I don't have any clue :(

And trying to compile windows headers on OS X, leads me to the same thing:
unexpected EOF, unexpected EOF (and 8 more errors)

How can I debug this?

I think we shall start by having a reproduction case ;-)
However, no Windows or OS X here. Maybe I can infer something from the reproduction case, if it will be small...

still no clue how to debug.

Look for the report object, set it's PanicOnError property to true, paste the stack trace here.
(Should become an standard option.)

@xlab Gentle ping.

I forgot what this was about.


Fix bug in source data not being loaded by geojson source

When adding the Source, data don't get loaded.
This fix this behavior by adding a one-time listener to map:load and setting source data.
This guarantees data being available after the load event has occurred.
This PR also adds a onSourceLoaded which is similar to onSourceAdded and gets called after the map:load event.
I also updated the API.md docs

@alex3165 I added a basic test for source. It will not highlight the problem that I've fixed, though, since map is mocked (like for layer test). Anyway it's a beginning...

@lamuertepeluda Good job for the test 👍, there is one last thing to add I think and it should be good to go

@alex3165 you were right, source could be undefined. Now I added the check.


Split KafkaConnectSource into an abstract and impl

Motivation
We do extra processing steps and send back a different Record type than what is provided by KafkaConnectSource, but still desire to reuse a majority of the code. Having an Abstract implementation allows us to reuse the majority of the code while still being able to customize the Record and processRecord method.
Modifications
KafkaConnectSource was split into AbstractKafkaConnectSource with KafkaConnectSource extending the abstract. The processRecord method was made public to allow overriding of the method. The inner class KafkaSourceRecord was also split into an abstract implementation to allow different types of Records.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
The change should only be a splitting of code with no behavioral changes to the KafkaConnectSource class.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

Does this pull request introduce a new feature? no

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Exception from Tracker afterFlush function: dtp.setDate is not a function

I think in new 4 version setDate func doesnt exists. use date()

I'm getting this too after updatinf from 3 to 4 =>
tsega:bootstrap3-datetimepicker*  upgraded from 3.1.3_3 to 4.0.0_4

I can do a release that supports 4 eventually, but for now you'll have to pin to 3.x.x.

You may use https://github.com/aldeed/meteor-autoform-bs-datetimepicker/issues/7 for support V4 now.

+1 :)

Any updates on this and can you add the api.use 5.0.0? Thanks

Now that AF5 is out, I'll be getting through issues and updating to datepicker 4 soon. I've released with api.use 5.

+1 this error is annoying

Any updates on this?

+1

+1, Still occurring

About a month ago I implemented the picker in my own form using tsega's package.  The timepicker docs are pretty good.  I'd recommend giving it a shot if you keep having issues with the autoform addon... I was in the same boat.
Package: https://atmospherejs.com/tsega/bootstrap3-datetimepicker

Fixed the setDate, but converted to String and added support for format: https://github.com/Kostanos/meteor-autoform-bs-datetimepicker
Need to test for return Date vs format before open pull request.

Closing all issues. The plugin was a proof of concept which others have forked and made better alternatives.


Unable to set --gasprice parameter to auto when running hardhat node

Note: I originally posted this in the hardhat repo but I was redirected here since --gasprice is a part of hardhat-deploy.
I'm trying to run a forked mainnet on a closed source codebase using the following command:
npx hardhat node --fork https://eth-mainnet.alchemyapi.io/v2/REDACTED --fork-block-number 11095000 --gasprice "auto"
Compilation works until I get to a specific error in a deployment file (in this case, I simply mean a file whose sole function is DeployFunction). The error is the following (note that it has been amended to not reveal any information about the codebase:
Error HH604: Error running JSON-RPC server: ERROR processing /root/REDACTED:
Error: invalid BigNumber string (argument="value", value="auto", code=INVALID_ARGUMENT, version=bignumber/5.4.2)
Is there a way to do this?

Thanks. We were able to get it deployed.


try adding pytorch-cuda

@gwbischof, what's the state of this PR? Did the resulting environment work locally?


Mistake in README

The README needs to be corrected. Following is not a UIColor extension. I think it should be UIImage extension.
extension UIColor {
    init(_: DMNamespace, light: UIImage, dark: UIImage)
}

https://github.com/microsoft/DarkModeKit/blob/master/README.md#images

@me-abhinav Thanks for reporting this! We'll fix this.


[v1alpha2] Delete resources according to cleanuppolicy exactly once

When the resource is deleted here: https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v2/tensorflow/job.go#L110, the delete event will send to the operator, then the operator will run the delete logic again.
The second delete request will add an error event to the TFJob, which will confuse users. It is not what we expected.

ref #824

The second delete request will add an error event to the TFJob

I don't see an error event is sent in the deletePodsAndServices method. Am I missing something ?

https://github.com/kubeflow/tf-operator/blob/c45db42ad7d87cd4418817281fd50166a019afd6/vendor/k8s.io/kubernetes/pkg/controller/controller_utils.go#L592

It is not in the function, but in the pod control implementation.

Do we still need this issue?

Not sure, I will have a look

/close
Do not need it


🐛 BUG: Always see strange internal assertion error in debugger when I encounter an exception.

Which Cloudflare product(s) does this pertain to?
Workers Runtime
What version(s) of the tool(s) are you using?
3.22.3
What version of Node are you using?
20.9.0
What operating system are you using?
Windows
Describe the Bug
Whenever I'm running the debugger and I encounter an error I see the following output:
[wrangler:err] AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, import_assert5.default)(prepareStackTrace !== void 0)

    at getSourceMapper (C:\Users\Tom\Downloads\webapp\winter-tree-e15e\node_modules\miniflare\dist\src\index.js:5747:30)
    at getSourceMappedStack (C:\Users\Tom\Downloads\webapp\winter-tree-e15e\node_modules\miniflare\dist\src\index.js:5820:10)
    at reviveError (C:\Users\Tom\Downloads\webapp\winter-tree-e15e\node_modules\miniflare\dist\src\index.js:5854:17)
    at handlePrettyErrorRequest (C:\Users\Tom\Downloads\webapp\winter-tree-e15e\node_modules\miniflare\dist\src\index.js:5859:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async #handleLoopback (C:\Users\Tom\Downloads\webapp\winter-tree-e15e\node_modules\miniflare\dist\src\index.js:8572:20)

It never shows me the correct stack trace so it makes debugging very annoying.
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

I got the same problem.
On the exception, it appears despite the fact that I have caught them. (when using Fetch)
And it cannot proceed.


Unable to use ticker

I'm receiving the following error when trying to use the ticker method. I'm still able to access coinmarketcap.com regularly.
Traceback (most recent call last):
  File "C:/Users/Hepworth/Documents/portfolio.py", line 23, in <module>
    value = coinMarketCap.ticker(coin, limit=3, convert='USD')
  File "C:\Python36\lib\site-packages\coinmarketcap\core.py", line 54, in ticker
    response = self.__request('ticker/' + currency, params)
  File "C:\Python36\lib\site-packages\coinmarketcap\core.py", line 31, in __request
    raise Exception('An error occured, please try again.')
Exception: An error occured, please try again.

Hello @JacobHepworth,
can you share the whole code snippet you're trying to use? (Pastebin or Gist will do).
Cheers.

Getting the same error! Seems to happen when adding an optional currency.
Here's a code snippet:
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from coinmarketcap import Market
>>> coin = Market()
>>> coin.ticker(currency='CAD')

@404-brain That's mainly because you need to use the full name of the currency, so 'bitcoin' instead of 'BTC'.
Cheers.

@404-brain That was the problem. I was just confused by the exception that was given.

@mrsmn Any chance the ticker function could be improved to accept ticker symbols as well? It's hard to integrate with other libraries at the moment.


Rendering of average table is still under old logic of initial callback firing

https://github.com/AMP-SCZ/eeg-qc-dash/blob/1603cf370b0b0d5f31606efd198e6e528b834078/app.py#L445-L452
Change it to click-record base.

Closed by
https://github.com/AMP-SCZ/eeg-qc-dash/commit/b618b5368073092275ba67ef8b919aeb6def6da9


Invalid Isoformat String

Hi!
When I ry the demo code I get the following Error:
Traceback (most recent call last):
  File "/home/pi/wetter/cmc_api_test.py", line 9, in <module>
    token_states = coinmarketcap.listings_latest(sort_by=SortOption.MARKET_CAP, limit=5)
  File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/core.py", line 83, in listings_latest
    return _listings_latest(self, sort_by, sort_dir, start, limit, convert, aux_fields, filters)
  File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/v1/cryptocurrency/listings/latest.py", line 59, in _listings_latest
    token_states = [TokenState.from_dict(token) for token in response['data']]
  File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/v1/cryptocurrency/listings/latest.py", line 59, in <listcomp>
    token_states = [TokenState.from_dict(token) for token in response['data']]
  File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/types/token_state.py", line 100, in from_dict
    quote_map[currency] = Quote.from_dict(currency, dct_quote_data)
  File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/types/token_state.py", line 57, in from_dict
    last_updated = datetime.datetime.fromisoformat(last_updated_str)
ValueError: Invalid isoformat string: '2024-03-28T13:22:00.000Z'

The code I used is quite simple:
from coinmarketcap import Market
from coinmarketcap import SortOption
API_KEY = 'my-api-key'
coinmarketcap = Market(api_key=API_KEY)
token_states = coinmarketcap.listings_latest(sort_by=SortOption.MARKET_CAP, limit=5)
for token in tokens:
print(token.name, token.symbol, token.quote_map['USD'].price)
Can you help?

I just used a newer version that should have more reliable date parsing to address this, can you give that a try?
https://pypi.org/manage/project/byteforge-coinmarketcap/release/1.1/

Sorry, that's an admin only link.  In theory you just need to update to the latest version of the library
pip install --upgrade byteforge-coinmarketcap

Now I get the following exception:
" File "/home/pi/.local/lib/python3.9/site-packages/coinmarketcap/core.py", line 62, in _request
    raise Exception(f"Server returned {response_object.status_code} - {response_object.text}")
Exception: Server returned 400 - {"status":{"timestamp":"2024-04-02T09:20:27.442Z","error_code":400,"error_message":"\"Your plan is limited to 1 convert options","elapsed":0,"credit_count":0,"notice":null}}"

That’s an API restriction, for example if you are just using their free tier you can only do one conversion
So this code wouldn’t work unless you upgraded to Hobbyist
tokens = coinmarketcap.listings_latest(sort_by=SortOption.MARKET_CAP, limit=5, convert=['USD', 'BTC'])
But this would:
tokens = coinmarketcap.listings_latest(sort_by=SortOption.MARKET_CAP, limit=5, convert=['USD'])
I’ll update the docs to make this more clear.

Sorry my bad, thank you for the hint :)
Now it works. Great!


Consolidate badge URL generation functions

This consolidates all the badge URL generation functions into a single place, and updates the rest of the calling code to use it. It renames some things and updates labels to bring the names into alignment with the current API.
I think this should resolve #2027. It has a small conflict with #3012.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @paulmelnikow!

:book:

Thanks for contributing to our documentation. We :heart: our documentarians!

  Generated by :no_entry_sign: dangerJS against 95e8d356e5886294718951e7993ceb6aff997b20

This is blocking #3024. It would be great to merge it today if possible.

This is blocking #3024. It would be great to merge it today if possible.

I will review this evening (US Time) if no one else is able to get to it beforehand


Ideas for AIF <-> JSON conversions

I've written some simple AIF2JSON and JSON2AIF convertors, located in https://github.com/dwsideriusNIST/adsorptioninformationformat/tree/sandbox
This is intended to be a discussion starter. Writing the converters revealed the need for kludges due to differences in approach between AIF and NIST-JSON; this will be informative for developing uniform standards.

thanks for the work Dan. I have integrated these changes into a recent version and added a few missing items to the AIF dictionary.
NISTjson branch
After you have reviewed this branch I will push the changes to the main branch and include the ability to download aif or json in the web app.

Jack,
I reviewed the NISTjson-integration branch and it is ready for merge into main/master, except that it failed the circleci tests. I think the issue is in the requirements.txt file, where json does not need to be included. So I made a PR into that branch, which after acceptance should facilitate a merge of the NISTjson branch into master.
-Dan
From: Jack Evans @.>
Reply-To: jackevansadl/adsorptioninformationformat @.>
Date: Friday, November 12, 2021 at 12:04 AM
To: jackevansadl/adsorptioninformationformat @.>
Cc: "Siderius, Daniel W. (Fed)" @.>, Author @.***>
Subject: Re: [jackevansadl/adsorptioninformationformat] Ideas for AIF <-> JSON conversions (#12)
thanks for the work Dan. I have integrated these changes into a recent version and added a few missing items to the AIF dictionary.
NISTjson branchhttps://github.com/jackevansadl/adsorptioninformationformat/tree/NISTjson_integration
After you have reviewed this branch I will push the changes to the main branch and include the ability to download aif or json in the web app.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jackevansadl/adsorptioninformationformat/issues/12#issuecomment-966822990, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIYBJTVEJI5QKTQWFAWY5LULSN4RANCNFSM4442V4LA.
Triage notifications on the go with GitHub Mobile for iOShttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|daniel.siderius%40nist.gov|dc7863906d9947da26c308d9a599de56|2ab5d82fd8fa4797a93e054655c61dec|1|0|637722902573390857|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gwymzDXkTkD9CZkjaOdyCTwSMMBojHv6EBYD2iGbPac%3D&reserved=0 or Androidhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|daniel.siderius%40nist.gov|dc7863906d9947da26c308d9a599de56|2ab5d82fd8fa4797a93e054655c61dec|1|0|637722902573400813|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=M1J1yauK5Vct95qTvFYCg%2BZPHVdxt13bhPrzdm%2B6tx0%3D&reserved=0.


Allow empty authority in absolute URIs

Fixes #323
This removes the restriction preventing empty authority in URIs.  The canonical example of this is file:/// which has a zero-length authority.  While these may not be relevant for a web server, there are many domains that need these sorts of alternative URIs (for example Webview-based software which reads local resources).
https://datatracker.ietf.org/doc/html/rfc3986 pretty clearly describes the authority as optional in all situations AFAICT, but it mentions that schema-specific restrictions may be in place.
This is the case for HTTP addresses, described in https://www.rfc-editor.org/rfc/rfc9110.html#name-identifiers-in-http

The origin server for an "https" URI is identified by the authority component
...
A sender MUST NOT generate an "https" URI with an empty host identifier. A recipient that processes such a URI reference MUST reject it as invalid.

It's possible that some users of this library in a strictly-http context may be relying on this checking the validity of the HTTP identifier for them.  I'm not sure how to handle this, maybe with a version bump? The legacy behavior could be considered a bug though.
Eventually a separate HttpUri type or something that performs the additional checks when constructed might be useful.

I'm not immediately against this change, but I am a bit skeptical. Notably, this crate is purposefully meant for the HTTP usecase, not a general URL parser. (HttpUri seems like it already exists, http::Uri).

Also, recently opened: #696.

FWIW I opened this because I thought @carllerche had given the okay for it in #323 , but you're right, this is http::Uri after all.
Despite varied requirements, the rust ecosystem still hasn't seen a second Uri crate and this is used pretty widely - I'm not sure the ecosystem could support a second ground-up more flexible Uri crate.  Is there a way some of the core functionality could be shared with another crate with a more permissive frontend in such a way that the types would be trivially convertible?
On the other hand, I don't think any software relies on this check for correct operation... I think this error is at most used to detect user mistakes early.  And in that case, I think other code that consumes Uri probably already performs such a check - for instance, "".to_socket_addrs().unwrap() returns Error { kind: InvalidInput, message: "invalid socket address" } which conveys more or less the same information.  From a user perspective you'd troubleshoot "" the same way you'd troubleshoot any other incorrect host name.


[Bugfix] Fix a memory leak in OpManager

Add destructor in OpManager to delete frontend_funcs.
Memory leak caught by LeakSanitizer:
==2522658==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 32 byte(s) in 1 object(s) allocated from:
    #0 0x48f130 in operator new(unsigned long) (/data/users/hlu/tvm/sparse/tvm_sparse_benchmark.cc+0x48f130)
    #1 0x7efd36d620dd in tvm::relay::$_2::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const tvm/tvm/src/relay/ir/op.cc:152
    #2 0x7efd36d613e8 in std::_Function_handler<void (tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*), tvm::relay::$_2>::_M_invoke(std::_Any_data const&, tvm::runtime::TVMArgs&&, tvm::runtime::TVMRetValue*&&) third-party-buck/platform007/build/libgcc/include/c++/7.3.0/bits/std_function.h:316
    #3 0x7efd37fa4d08 in std::function<void (tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*)>::operator()(tvm::runtime::TVMArgs, tvm::runtime::TVMRetValue*) const third-party-buck/platform007/build/libgcc/include/c++/7.3.0/bits/std_function.h:706
    #4 0x7efd37f9d022 in tvm::runtime::TVMRetValue tvm::runtime::PackedFunc::operator()<char const (&) [4], char const (&) [13], tvm::runtime::TypedPackedFunc<tvm::Schedule (tvm::Attrs const&, tvm::Array<tvm::Tensor, void> const&, tvm::Target const&)>&, int>(char const (&) [4], char const (&) [13], tvm::runtime::TypedPackedFunc<tvm::Schedule (tvm::Attrs const&, tvm::Array<tvm::Tensor, void> const&, tvm::Target const&)>&, int&&) const tvm/tvm/include/tvm/runtime/packed_func.h:1205
    #5 0x7efd37f9acf4 in tvm::registerTopiSchedules()::$_0::operator()() const caffe2/caffe2/fb/tvm/topi/topi_init.cc:53
    #6 0x7efd37f99abc in void std::__invoke_impl<void, tvm::registerTopiSchedules()::$_0>(std::__invoke_other, tvm::registerTopiSchedules()::$_0&&) third-party-buck/platform007/build/libgcc/include/c++/7.3.0/bits/invoke.h:60
    #7 0x7efd37f99a8c in std::__invoke_result<tvm::registerTopiSchedules()::$_0>::type std::__invoke<tvm::registerTopiSchedules()::$_0>(tvm::registerTopiSchedules()::$_0&&) third-party-buck/platform007/build/libgcc/include/c++/7.3.0/bits/invoke.h:95
    #8 0x7efd37f9972c in std::invoke_result<tvm::registerTopiSchedules()::$_0>::type std::invoke<tvm::registerTopiSchedules()::$_0>(tvm::registerTopiSchedules()::$_0&&) third-party-buck/platform007/build/libgcc/include/c++/7.3.0/functional:80
    #9 0x7efd37f9957a in void folly::basic_once_flag<folly::SharedMutexImpl<false, void, std::atomic, false, false>, std::atomic>::call_once_slow<tvm::registerTopiSchedules()::$_0>(tvm::registerTopiSchedules()::$_0&&) buck-out/dev/gen/folly/synchronization/call_once#header-mode-symlink-tree-with-header-map,headers/folly/synchronization/CallOnce.h:110
    #10 0x7efd37f99165 in void folly::basic_once_flag<folly::SharedMutexImpl<false, void, std::atomic, false, false>, std::atomic>::call_once<tvm::registerTopiSchedules()::$_0>(tvm::registerTopiSchedules()::$_0&&) buck-out/dev/gen/folly/synchronization/call_once#header-mode-symlink-tree-with-header-map,headers/folly/synchronization/CallOnce.h:101
    #11 0x7efd37f99165 in void folly::call_once<folly::SharedMutexImpl<false, void, std::atomic, false, false>, std::atomic, tvm::registerTopiSchedules()::$_0>(folly::basic_once_flag<folly::SharedMutexImpl<false, void, std::atomic, false, false>, std::atomic>&, tvm::registerTopiSchedules()::$_0&&) buck-out/dev/gen/folly/synchronization/call_once#header-mode-symlink-tree-with-header-map,headers/folly/synchronization/CallOnce.h:57
    #12 0x7efd37f99165 in tvm::registerTopiSchedules() caffe2/caffe2/fb/tvm/topi/topi_init.cc:26
    #13 0x4369e4 in main tvm/sparse/tvm_sparse_benchmark.cc:125
    #14 0x7efd1c7c81a5 in __libc_start_main /home/engshare/third-party2/glibc/2.26/src/glibc-2.26/csu/libc-start.c:308:16
    #15 0x432ce9 in _start /home/engshare/third-party2/glibc/2.26/src/glibc-2.26/sysdeps/x86_64/start.S:120

@tqchen, @jroesch, please review.

==2869722==
==2869722== HEAP SUMMARY:
==2869722==     in use at exit: 285,243 bytes in 5,642 blocks
==2869722==   total heap usage: 65,516 allocs, 59,874 frees, 15,923,160 bytes allocated
==2869722==
==2869722== LEAK SUMMARY:
==2869722==    definitely lost: 32 bytes in 1 blocks
==2869722==    indirectly lost: 1 bytes in 1 blocks
==2869722==      possibly lost: 47,811 bytes in 964 blocks
==2869722==    still reachable: 237,399 bytes in 4,676 blocks
==2869722==                       of which reachable via heuristic:
==2869722==                         stdstring          : 44,616 bytes in 914 blocks
==2869722==         suppressed: 0 bytes in 0 blocks
==2869722== Rerun with --leak-check=full to see details of leaked memory
==2869722==
==2869722== For counts of detected and suppressed errors, rerun with: -v
==2869722== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

In this particular case, we intentionally not delete the front_end_funcs in this case. Mainly because sometimes the frontend functions are destructed after the python env already unloaded, and deleting them(calling into ctypes deleter) causes segfault, as in the CI

Sounds good

Thanks @hlu1 for raising the PR, I think we will welcome a PR that adds an additional comment to the code so we see what is going on :)

@tqchen, not deleting the frontend_funcs is the right behavior when the python frontend is used, because the relay frontend_funcs are registered and then deleted by python. However, in pure C++ environment (our case), we have to register those funcs in C++, not deleting them results in a memory leak. What do you think is the most proper way to fix it?

Good point, I think a better way would be pass in an additional flag(when registering global) (frontend_func) to indicate whether it is native c++ or a frontend function and handle them differently.


Move from docker machine to just docker

Machine was the only way to run Docker on Mac or Windows previous to Docker v1.12. (from the docs)
I would like to try and switch from docker machine to just docker.

it is default
even though I tried to run tests on mac - I had some troubles switching
currently DOCKER_MACHINE_IP option is spread in places it shouldn't be (e.g. polls app it overrides host from config)

👍 good idea, when I started docker-machine was way to go


Automatic delay of task end upon submisison

Currently, when a submission is entered close to the end of a task the expected prolongation of the task duration is not triggered.

This should be fixed as well.


SWITCHYARD-2787 Multiple SwitchYard tests fail for a single RESTEasy …

…endpoint

Can one of the admins verify this patch?

ok to test


Adding New Mixins for Journey Orchestration

https://github.com/adobe/xdm/issues/843
Files Added :
a) journeyStepEventActionExecutionFieldsMixin : to provide Journey Event  Fields
b) journeyStepEventCommonFieldsMixin : Generic Journey FIelds
c) journeyStepEventDataFetchFieldsMixin  : Mixin for Data Fetch Fields
d) journeyStepEventIdentityFieldsMixin
e) journeyStepEventJourneyFieldsMixin
Please link to the issue #…

Hello @cmathis ,
can you please review this one.

@cfraser : Please review this

Updated the Review with the following changes :
a) Restructured the files.
b) Updated Journey Namespace.
Also followed the camelcase in the fields (ID, Properties) and in the directory structure. Please let me know if there will be an issue that will change accordingly.

Hello @cfraser, : please have a look

@khanna-vikas please review.

In addition to mixins, this PR is introducing two new standard AEP classes (Journey Orchestration Class, and Journey Step Event). This will be in addition to the existing standard Profile and ExperienceEvent classes.
@nikshar  - The Journey Orchestration makes sense, but why how is the Journey Step Event different from an ExperienceEvent?
cc @khanna-vikas , @cfraser

In addition to mixins, this PR is introducing two new standard AEP classes (Journey Orchestration Class, and Journey Step Event). This will be in addition to the existing standard Profile and ExperienceEvent classes.
@nikshar - The Journey Orchestration makes sense, but how is the Journey Step Event different from an ExperienceEvent?
cc @khanna-vikas , @cfraser

Hello @cmathis :  This is because in the Journey Step event schema we only have a relationship with journey step events and not with profile there will be a different experience event-based schema for that jourrneyStepProfileEvent.
Please let me know if it is fine.

Hi @khanna-vikas : As per the review the path has been updated.
Please take a look and let me know if something I've missed.

@nikshar I have left comments to be corrected.

Hello @khanna-vikas   : Updated as per review comments please take a look.


[VL] Set a GitHub Actions workflow run for TPC-DS Q67/Q95 low memory case

Q67 and Q95 SF30 will be run within 8 threads, 72 partitions, and 3g/5g off-heap memory for each PR.
Failures will be ignored temporarily.

@zhouyuan

@zzcclp CH CI didn't pass however the PR is unrelated to CH backend. Let's ignore the failure temporarily?

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3194_time.csv
log/native_master_09_18_2023_bb48a9970_time.csv
difference
percentage

q1
42.93
43.04
0.110
100.26%

q2
24.50
24.97
0.470
101.92%

q3
35.09
36.87
1.779
105.07%

q4
41.44
41.75
0.313
100.76%

q5
69.39
69.76
0.377
100.54%

q6
6.80
5.05
-1.754
74.21%

q7
86.75
86.37
-0.385
99.56%

q8
79.38
80.53
1.151
101.45%

q9
115.82
117.29
1.462
101.26%

q10
47.96
47.13
-0.835
98.26%

q11
19.23
19.27
0.038
100.20%

q12
24.23
25.24
1.011
104.17%

q13
49.00
50.78
1.782
103.64%

q14
17.80
18.15
0.352
101.98%

q15
31.37
28.92
-2.451
92.19%

q16
16.35
15.70
-0.648
96.04%

q17
120.10
120.19
0.092
100.08%

q18
162.30
161.67
-0.630
99.61%

q19
12.20
12.35
0.149
101.22%

q20
28.44
28.67
0.229
100.80%

q21
236.08
243.12
7.040
102.98%

q22
15.18
15.16
-0.019
99.87%

total
1282.33
1291.96
9.634
100.75%


cold wallet - mwc713 process exits when restoring new wallet from seed

Create a brand new cold wallet installation following instructions in https://github.com/mwcproject/mwc-qt-wallet/blob/master/DOC/cold_wallet_software_installation_guide.md
When you first run mwc-qt-wallet, try to recover a wallet from seed. Get error in attached screenshot.

currenly mwc713 report error correctly. It require the node connection for restore. This usecase need to be fixed

mwc713 is not only the problem.  Because of that we will need to show the resync progress.  Currently qt wallet will show that with notification messages.

In cold wallet, when restoring new wallet from seed, not observing issue.
Hence closing this ticket.


handshake should have a separate key for handshakes per second terse output

Full output of command includes both "Average time per handshake" and "Handshakes per second" values:
LD_LIBRARY_PATH=${HOME}/openssl-3.0-test ./handshake 10 -s ${HOME}/test
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Failed to create SSL_CTX pair
Average time per handshake: 2.142800us
Handshakes per second: 2002803.925496

Expected result: handshake should a key to show only "Average time per handshake" or "Handshakes per second" value.

IMO average time per handshake is the more relevant value.

Gotcha! In that case this issue can be closed.


Crash of har_dump.py

I sometimes get either b'' is not JSON serializable or  Object of type 'bytes' is not JSON serializable
I used mitmproxy to extract such a flow and uploaded it here
Steps to reproduce the problem:

Any other comments? What have you tried so far?
It seems, that the error mostly occurs for POST and HEAD requests. Sometimes with an empty response body, sometimes not. Seldomly a GET requests triggers this error
System information
mitmproxy 1.0.2
macOs Sierra 10.12.3
Edit: Updated the Gist link to point to a working binary gist

Thanks. Could you please upload the flow somewhere else? Gists don't work with binary data, the file is corrupted.

I now used https://github.com/mbostock/gistup to upload binary data as a gist.
Link

That works, thanks!

A short update from my side: I used the fix from https://github.com/mitmproxy/mitmproxy/pull/1650/files to address this issue. Seems to work as well.

@Junkern Does that work in case of an empty response?

I implemented the fix in the har_dump and tested it on the flow with an empty response (the one  I posted above). No error was thrown

Any update? Should I use the fix I posted above or will this issue be fixed in the mitmproxy code?

I made a PR with the fix. If everything is fine it will probably be merged.


VSTest Task unable to find custom test logger when testSelector: testPlan

Problem
I have written a custom logger to log test results in a kusto database. I added the loggers friendly name to my runsettings file like:
<Logger friendlyName="KustoTestLogger" />
The assembly of the test logger is located in the same folder as the test container .dll is.
When executing tests via the VSTest task and settng the testSelector: testAssemblies, everything works fine, the logger gets executed.
However, when settings testSelector: testPlan, the task fails to find the test selector:

2020-09-14T08:51:28.0307526Z ##[debug]ProxyDiscoveryRequest: HandleLogMessage Entered
2020-09-14T08:51:28.0410963Z ##[error]DiscoveryMessage : Microsoft.VisualStudio.TestPlatform.Common.Exceptions.InvalidLoggerException: Could not find a test logger with AssemblyQualifiedName, URI or FriendlyName 'KustoTestLogger'.
2020-09-14T08:51:28.0427960Z ##[debug]Processed: ##vso[task.logissue type=error;]DiscoveryMessage : Microsoft.VisualStudio.TestPlatform.Common.Exceptions.InvalidLoggerException: Could not find a test logger with AssemblyQualifiedName, URI or FriendlyName 'KustoTestLogger'.
2020-09-14T08:51:28.0431675Z    at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.TestLoggerManager.Initialize(String runSettings)
2020-09-14T08:51:28.0432367Z    at Microsoft.VisualStudio.TestPlatform.Client.TestPlatform.CreateDiscoveryRequest(IRequestData requestData, DiscoveryCriteria discoveryCriteria, TestPlatformOptions options)
2020-09-14T08:51:28.0433451Z    at Microsoft.VisualStudio.TestPlatform.CommandLine.TestPlatformHelpers.TestRequestManager.DiscoverTests(DiscoveryRequestPayload discoveryPayload, ITestDiscoveryEventsRegistrar discoveryEventsRegistrar, ProtocolConfig protocolConfig)
2020-09-14T08:51:28.0434203Z    at Microsoft.VisualStudio.TestPlatform.Client.DesignMode.DesignModeClient.<>c__DisplayClass24_0.b__0()
2020-09-14T08:51:28.0434876Z ##[debug]ProxyDiscoveryRequest: HandleDiscoveryComplete Entered
2020-09-14T08:51:28.0435330Z ##[debug]ProxyDiscoveryRequest: Dispose Entered
2020-09-14T08:51:28.0435743Z ##[debug]ProxyDiscoveryRequest: Abort Entered

I tried to also set the custom adapter path but this didnt fix the issue (however since the logger is located at the same place as the test container, this shouldn't be required).
I have had a look into your code in this repo, however I am at the point DTAExecutionHost gets called (I couldn't find the source code of this one). Everything looks good so far and I couldn't find the issue, so I am guessing there is maybe something wrong in the execution host?
Or is it not possible to add a custom logger when executing tests with testSelector: testPlan? Do I have to add another custom adapter path?
I execute the tests as container job btw.
Expected behavior
I can set the custom logger in the .runsettings file. VSTest task takes the custom logger (as well as the default trx logger) and uses it during test execution. I do not need to add any additional test adapter path if the path to the test logger is the same as the path to the test container.
Current behavior
Custom test logger is not found when added to .runsettings file. Tests won't get executed.

Any updates on this?

@davidguidali Can you please share the .runsettings file as we need to ensure it follows the desired structure for logger:

foo.trx

@davidguidali any update on this?

Closing due to no response.

Closing due to no response.


[WAITING ON CHECKLIST] [HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] NewDatePicker

Coming from https://github.com/Expensify/App/issues/25397#issuecomment-1743272245, we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.
This issue is specific to refactoring src/components/NewDatePicker/index.js
cc @kowczarz
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e08fcb9456de83d2
Upwork Job ID:<PHONE_NUMBER>708163072
Last Price Increase: 2023-10-05

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

I will refactor this component with DateOfBirthPage, EditRequestCreatedPage and MoneyRequestDatePage because separating these tasks would require big overhead.

Pr for this one has been merged

Payment Summary:

Contributor: @kowczarz (Invoiced)
C+: @mananjadhav $500 (New.Dot)

NO UPWORKS JOB NEEDED

@mananjadhav bump to complete the checklist (if required)!

@jliexpensify There won't be any payout for me. @aimane-chnaif reviewed the PR, and their payout will be handled in this issue.

Thanks Manan, closing this one out!


Testframework

Create basic test framework for component test.

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/1726/


Add an ability to use non-https registries

In order to make the "per WC" cache work, we need to use http://<IP_ADDRESS> in a containerd config, because the caching registry is exposed as a node port.
It would also be possible to use tls, but then we need to have a cert that is trusted by containerd, and it doesn's sount that easy
Issue: https://github.com/giantswarm/giantswarm/issues/30596
What does this PR do?
This PR is supposed to let use http registries mirrors, when it's explicitly provided via endpoints
Currently, when I try to set http://<IP_ADDRESS>:5000 as a mirror, I'm getting a config that contains https://http://<IP_ADDRESS>.
What is the effect of this change to users?
It should not affect users.
Any background context you can provide?
It would make per WC cache deployment a way easier
What is needed from the reviewers?
Check, if this change doesn't affect users unless they explicitly want to be affected
Do the docs need to be updated?
I don't think so
Should this change be mentioned in the release notes?
I don't think so

[x] CHANGELOG.md has been updated (if it exists)

@giantswarm/team-turtles what about setting this as a hardcoded string? Meaning adding "http://<IP_ADDRESS>" directly underneath the range?
That would at least prevent adding more non-https value endpoints. So we basically don't add additional endpoints via https and http.
Thoughts?

what about setting this as a hardcoded string?

We won't be able to hardcode the port though, would you be ok with something like that:
#values
localMirror:
  enable: true
  port: 33445

# template
...
{{ - if .Values.localMirror.enabled -}}
"http://<IP_ADDRESS>:{{ .Values.localMirror.port }}
{{- end -}}
...

But with that values structure, I'm a bit uncertain where to put that localCache entry and what it should look like when creating a cluster via happa, do you have ideas?

@giantswarm/team-turtles  Is it better now?

@weseven or @njuettner
May I please ask you to review it again?

LGTM, only nitpicks would be naming of values:

instead of localCache I would use localRegistryCache
instead of mirrors I'd use mirroredRegistries
But I don't feel strongly about these, so not blocking.

Not sure if .internal it's the right place: I think so, but better wait for @njuettner confirmation on that before merging.

Agree it makes sense to name them as Daniel suggested
localCache ->localRegistryCache
mirrors -> mirroredRegistries
to make it more explicit 🙂
Other than that LGTM, feel free merge it once you changed the names


Bug: Mentions Typeahead Positioning (iOS Safari)

Currently live on the playground. If you open the mentions typeahead from iOS safari, you'll see it render over your text, rather than below it. This doesn't appear to be happening on Android, so it may be safari-specific.

Lexical version: 0.3.2
Steps To Reproduce

Open the playground from iOS safari
Type '@' followed by search text
See mentions results overflow over your text

Link to code example:
playground code will do!
The current behavior
Mentions typeahead covers your search text
The expected behavior
Mentions typeahead positions itself below your search text

I've tried a few different ways to try to replicate this and break iOS Safari, but without much luck. I think this may have inadvertently been fixed since been reported.

I've tried a few different ways to try to replicate this and break iOS Safari, but without much luck. I think this may have inadvertently been fixed since been reported.

Yes looks like you're right. Thanks @thegreatercurve !


Indexed TMX support limiting colors too much.

I'm using this tool to batch convert tmx files to indexed 8 bit, but most of them end up with incredibly limited colors. Some turn out fine but most are completely incorrect.
The command I pass to it is converting the tmx to png, halving the resolution, then converting the png to tmx like this:
for %%f in (*.png) do for %%g in ("%%~nf") do "C:\Users\drewk\OneDrive\Desktop\Mod Porting\TMX\tools\GJConv\gjconv" "%%f" -id "%%~pf%%~nf.tmx"
The output files look something like this:

Any ideas? Or is 8 bit tmx support not fully fleshed out?

Think I found the issue. When passing indexed as an argument it sets the palette count to 1, instead of 0 like everything else. At least I think that's the issue.

The current color limiting implementation is very bare bones and simply chooses the most used colors and doesn't actually care about what colors those are, a proper color quantization algorithm is planned to be added soon but for now I recommend the of a  different program(such as pngquant or imagemagick) to limit the colors of your images before converting.

Adressed in: 01755df


Add version code generation in CI

Current dependencies on/for this PR:

main

PR #59   👈

This stack of pull requests is managed by Graphite.


Initial PR getting tests to pass

This is an initial commit for for the cluster splitting pipeline, more work will need to be dont to deal with the actual goal the pipeline is supposed to address.
Currently there appears to be some issues in how some files are being constructed e.g. column order changes. This may be due to how the config file specific to arborator is set up.
But this commit can serve as a good starting point for the rest of the pipeline.


Ast_traverse.ast_mapper_of_map replacement?

Hi,
I'm trying to update ppx_fun to ppx_core v.0.9.0, but couldn't find replacement for Ast_traverse.ast_mapper_of_map. I used to have Ast_traverse.map which was converted to Ast_mapper and registered — https://github.com/little-arhat/ppx_fun/blob/master/src/ppx_fun.ml#L133. Is it possible to do something like this in current ppx_core or I have to use some ppx_driver or remove ppx_core entirely?
Thanks!

Ah, indeed this was removed during the port to ocaml-migrate-parsetree. It could be re-added since now ocaml-migrate-parsetree captures Ast_mapper as well. Note that you only need to fill in the structure and signature fields of the mapper, so you can just use:
{ Ast_mapper.default_mapper with
  structure = fun _ -> map#structure
; signature = fun _ -> map#signature
}

BTW, you should also consider switching to the ocaml-migrate-parsetree driver and distribute your rewriter as a library. This is the way forward using ppx. Alternatively using ppx_driver is fine as well since it integrates with the omp driver.

That's what I've tried at first:
let ast_mapper_of_map (map : #map) : Ast_mapper.mapper =
  let open Ast_mapper in
  { default_mapper with
    expr = fun _ -> map#expression}

but:
This expression has type
         Ppx_core.Light.expression -> Ppx_core.Light.expression
       but an expression was expected of type
         Parsetree.expression -> Parsetree.expression
       Type Ppx_core.Light.expression = Ast_403.Parsetree.expression
       is not compatible with type Parsetree.expression

What is the correct way to convert version-specific parsetree to "current" parsetree? Is there documentation somewhere I miss?
Thanks!

There is just a quick mention of this here. You can try this:
{ Ast_mapper.default_mapper with
  structure = fun _ -> Ppx_ast.Selected_ast.to_ocaml_mapper Structure map#structure
; signature = fun _ -> Ppx_ast.Selected_ast.to_ocaml_mapper Signature map#signature
}

But really you should do this:
Migrate_parsetree.Driver.register ~name:"fun" (module Ppx_ast.Selected_ast)
  (fun _ _ ->
    { Ppx_ast.Selected_ast.Ast_mapper.default_mapper with
      structure = fun _ -> map#structure
    ; signature = fun _ -> map#signature
    })

@diml thanks, Ppx_ast.Selected_ast.to_ocaml_mapper is indeed what I was looking for (and I saw it, but couldn't figure how to use it %( ).
I did use ppx_driver in previous version, but than removed it (https://github.com/little-arhat/ppx_fun/commit/1d67ea83f4593a2092952cb162102a60427ac279) because the code was easier without it. I'll try ppx_driver again, thanks.

Yh I guess sometimes it's easier to do things directly. Basically what ppx_driver gives you is robust checks and merging of all rewriters into a single pass with a clear semantic. These are things we care about at least for our critical code but it might not be that important in general and it only works if you use only ppx_driver based rewriters.
BTW the patch you showed me mostly fiddles with the build system, you should try jbuilder, it would simplify things a lot :)


Generation of typescript classes for CTOs/CTS

My understanding was that we intended to generate the class definitions for the transport structures via CobiGen or at least if that is not possible, replicate them manually. Now we have own definitions with differing names and small structural changes which makes it difficult to understand.
Example:
export class BookingInfo {
    booking: ReservationInfo;
    invitedGuests?: [{email: string}];
}

export class ReservationInfo {
    bookingDate: string;
    name: string;
    email: string;
    bookingType: number;
    assistants?: number;
}

vs.
public class BookingCto extends AbstractCto {

  private static final long serialVersionUID = 1L;

  private BookingEto booking;

  private TableEto table;

  private List<InvitedGuestEto> invitedGuests;

  private OrderEto order;

  private List<OrderEto> orders;

  private UserEto user;
  [...]
}

Protocol:

consistent structure and naming on server and client representing the contract.
there might be a wrapper on the client side to transform the data structures from the contract to whatever is needed or more appropriately on the UI

Protocol 24.08. (architects meeting):
My-thai-star should describe the reference implementation in future. Therefore, we should provide examples for both worlds --- contract-first development as well as server data model first.
The decision is to reuse the data model from the server to be generated into typescript data model. This can be directly used for CRUD dialogs.
To show contract-first development, we should go for at least two use cases on the client UI, which need different data model to best handle data for the UI. This data has to be transformed in intermediate layer/service from the server etos to UI tos and vice versa.


Form.select's selected argument cannot be number

Example:
{{ form.select('location', {1: 'USA', 2: 'Canada'}, 1, 'Empty option label', {class: 'form-control'}) }}
The USA will not be selected.
The bug is in the Form/index.js
_makeOptionsAttributes (value, selected) {
    const attributes = {
      /* selected is currently a number and a number doesn't have indexOf function
      * maybe a toString() could be called on it
      */
      selected: selected.indexOf(value)  > -1 ? true : null,
      value: value
    }
    return this._makeHtmlAttributes(attributes).join(' ')
}

I have temporary solved by calling toString() on my selected value.

Booooom! Will fix it. Thanks for reporting


Issue with CocoaPods install

Below is what I have in my podfile
platform :ios,'14.0'
target 'XXX' do
pod 'Alamofire', '~> 5.2'
pod 'AlamofireObjectMapper'
...
....
end
At  the command line with the following command

pod install

I get the following issue
[!] CocoaPods could not find compatible versions for pod "Alamofire":
In Podfile:
Alamofire (~> 5.2)
AlamofireObjectMapper was resolved to 5.2.1, which depends on
  Alamofire (~> 4.7)

Specs satisfying the Alamofire (~> 5.2), Alamofire (~> 4.7) dependency were found, but they required a higher minimum deployment target.

@Maverick1000 Have you tried to upgrade CocoaPods by running this command, and then retry pod install?

$ sudo gem install cocoapods

Drop AlamofireObjectMapper, it's necessary. Then you should be able to install Alamofire 5 just fine.


Add TF parsers ResizeByNearestNeighbour

These ops appears in EfficientDet model.

Hi , we cannot add this resize functionality to initial data parsers right?
as we know in tf.resize has this resizebynearestneighbour functionality so its usually done at the time of image processing , so thats after we parse the input data.
But i think we can do like if our aim to resize along with parsing, we can do that by taking the data batch by batch or all at and convert it ..by applying map functionality


issue with https://kubernetes.io/zh/docs/setup/production-environment/tools/kubeadm/install-kubeadm/

Hi Team,
this part had removed in english V1.2 version. could you check why Chinese version still have this?
I mean this issue had fixed on version V1.2 or?

/triage accepted
/assign

/triage accepted
/assign

Thanks Teng!
that makes me confused when team told me cn version still dont allow using iptables.
appreciate for your help.
closed issue and waiting for your pull.

Thanks Teng!
that makes me confused when team told me cn version still dont allow using iptables.
appreciate for your help.
closed issue and waiting for your pull.

Thanks Teng!
that makes me confused when team told me cn version still dont allow using iptables.
appreciate for your help.
closed issue and waiting for your pull.

Thanks Teng!
that makes me confused when team told me cn version still dont allow using iptables.
appreciate for your help.
closed issue and waiting for your pull.


Fix runner data buffer

If the amount of data received from .eim in certain cases does not fit in a single packet (1024 * 1024 bytes), it will not be parsed as valid json, and therefore the user will see
No data or corrupt data received error.

@Alex-EEE , I'm ready to merge this, but I have one doubt - what if the actual data has 0x0 at the end of 1024 byte chunk? I guess we'd get No data or corrupt data received error again, but it's hard to say how common these situations will be.
The only way to prevent that is to terminate packets from .eim with something else...

it seems the only way we could get binary 0 (not ascii 0) is if we had a unicode string.  Don’t see any way that could happen
We concluded that this can be safely merged.


Need help with Setting up

Can we not setup this application other than default environment?

You can install Project for the web accelerator solution in all environments (Trial (Subscription based), Sandbox, Production).

so to install project accelerator in different environment, we need to install first project online right?

You need to deploy Microsoft Project Service Core after environment is created. Please follow the steps here: https://learn.microsoft.com/en-us/project-for-the-web/deploying-project


Loading particular pdf crashes pdf-lib

What were you trying to do?
Loading this pdf crashes pdf-lib
How did you attempt to do it?
const page = await PDFDocument.load(pdfData);

What actually happened?
error:
_this.catalog.Pages().traverse(function (node, ref) {
                          ^

TypeError: _this.catalog.Pages is not a function
    at PDFDocument.computePages [as populate] (C:\Users\user\bSmart-downloader\node_modules\pdf-lib\cjs\api\PDFDocument.js:28:27)
    at Cache.access (C:\Users\user\bSmart-downloader\node_modules\pdf-lib\cjs\utils\Cache.js:13:31)
    at PDFDocument.getPages (C:\Users\user\bSmart-downloader\node_modules\pdf-lib\cjs\api\PDFDocument.js:479:31)
    at PDFDocument.<anonymous> (C:\Users\user\bSmart-downloader\node_modules\pdf-lib\cjs\api\PDFDocument.js:648:43)
    at step (C:\Users\user\bSmart-downloader\node_modules\tslib\tslib.js:141:27)
    at Object.next (C:\Users\user\bSmart-downloader\node_modules\tslib\tslib.js:122:57)
    at fulfilled (C:\Users\user\bSmart-downloader\node_modules\tslib\tslib.js:112:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v18.10.0

What did you expect to happen?
To load the pdf
How can we reproduce the issue?
Easy way to reproduce the issue is to just open https://pdflabeler.enrico.wtf/ , open the console, and try to pen the pdf i linked to
Version
1.17.0 (i tried older ones, they have the same issue)
What environment are you running pdf-lib in?
Browser, Node

Any update on this. Having the same issue

Not that i know of, unfortunately hopding doesn't have much time that they can dedicate to maintain this library


Slice assign value

This is useful for setting a part of an matrix to a certain value, e.g. zero

Coverage remained the same at 100.0% when pulling 377ceba3e29e65b614df6418e968ce542e8f15ad on kamilritz:slice_assign_value into a8009a36a3668da0cbab0cb028b6997cd8179dc1 on PX4:master.


[Win] Fix .msi generation for the apps whose names include whitespaces

Arguments with values that include spaces must be put in quotes:
https://msdn.microsoft.com/en-us/library/bb483085.aspx
BUG=XWALK-4810

Cherry-picked, many thanks.


3.5.0: x86: local APIC: CPU core enumeration is broken on some platforms

z_acpi_get_cpu() used to retrieve the local apic on enabled CPU, where n was about the n'th enabled CPU, not just the n'th local apic. The system indeed keeps local apic info also about non-enabled CPU, and we don't care about these as there is nothing to do about it. Because on the incorrect code, the enumeration is broken on some platforms, like up_squared.

Fixed by #64513


Add audio db

This code should already be merged into master by https://github.com/WordPress/openverse-catalog/pull/111.
I've had audio_popularity_calculation based on add_audio_db, which was already merged. However, for some reason, when I merged #111, the base of the latter didn't change?

Closing this in favor of #124. The problem of base branch not changing after merge, and wrong diff calculation is really confusing.


RedisGraph commands partially supported

Expected behavior
I'm using Jedis to send query command to RedisGraph, like this:
graph.query key, "MERGE(:User{dbId: 123})"
it is supposed to create a node labelled as User in RedisGraph.
Actual behavior
No node created. No failure response. The "MERGE" clause appears not supported yet.
But this can work:
graph.query key, "CREATE(:User{dbId: 123})"
Steps to reproduce:
Code:
jedisPool.getConnection()..sendCommand("graph.QUERY", new String[]{graphId, preparedQuery, "--COMPACT"});
in which graphId is the graph key name, and prepared query is the query string mentioned above.
Redis / Jedis Configuration
spring.redis.host=xxxx
spring.redis.port=xxxx
spring.redis.password=xxxx
spring.redis.timeout=10000
spring.redis.jedis.pool.max-total=1000
spring.redis.jedis.pool.max-wait=10000
spring.redis.jedis.pool.max-idle=200
spring.redis.jedis.pool.min-idle=10
spring.redis.block-when-exhausted=true
Jedis version:
3.1.0
Redis version:
5.0.5, with RedisGraph module enabled
Java version:
1.8

BTW, the command:
graph.query key, "MERGE(:User{dbId: 123})"
can be executed successfully in redis command line tool.

Hi @siphonelee
I'm an engineer at RedisLabs and part of the RedisGraph team.
First, I was unable to reproduce the problem based on your description. Can you please provide a valid sample of the code you tried to execute, as well as the RedisGraph version?
Second, I have tested your query with our Java client, JRedisGraph which uses Jedis 3.1.0 as its Redis driver. JRedisGraph is basically doing what you have tried to achieve with native Jedis API. Executed the following test code:
package com.redislabs.redisgraph;

import com.redislabs.redisgraph.impl.api.RedisGraph;
        import org.junit.Assert;
        import org.junit.Test;

public class JedisIssueTest {

    @Test
    public void testJedisIssue2087(){
        RedisGraph api = new RedisGraph();
        ResultSet resultSet = api.query("g", "MERGE(:User{dbId: 123})");
        Assert.assertEquals("1", resultSet.getStatistics().getStringValue(Statistics.Label.NODES_CREATED));
        Assert.assertEquals("1", resultSet.getStatistics().getStringValue(Statistics.Label.PROPERTIES_SET));
        Assert.assertNotNull(resultSet.getStatistics().getStringValue(Statistics.Label.QUERY_INTERNAL_EXECUTION_TIME));
        api.deleteGraph("g");
        api.close();
    }
}

The test executed against RedisGraph master branch, that you can clone or get on docker with
docker run -p 6379:6379 -it --rm redislabs/redisgraph:edge
The tests executes the MERGE command and tests the response for indications about the amount of nodes created, amount of properties set and the existance of the query exection time. The test has passed seccusfully.
I'm waiting for your response with the code sample, regarding the Jedis API. If you think it is a RedisGraph issue, open us an issue at https://github.com/RedisGraph/RedisGraph/issues.

Hi @DvirDukhan
Sorry for replying late because I changed my code to lettuce and had to revert it back to Jedis. Interestingly I can't reproduce the issue any longer @_@ Guess it's my issue, but thanks for the help!
BTW, hope you guys could support the full cypher syntax soon :)


Keeping only 3 latest version in mkdocs

Type of change

[ ] Refactor
[x] New feature
[x] Bug fix
[x] Optimization
[ ] Documentation Update

Description
Keeps only 3 latest tags in the mkdocs, deleting the older ones. In order for the older tags to disappear we need to completely delete from the record as we do not have control over the drop down in mkdocs UI.
Related Tickets & Documents

Related Issue # https://github.com/cloud-bulldozer/kube-burner/issues/418

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing
Tested in a hacky way by modifying the github action workflow in my clone repo. More details here: https://github.com/vishnuchalla/kube-burner/actions/runs/6268275151/job/17022888601
Docs: https://vishnuchalla.github.io/kube-burner

@rsevilla87 is this one good to go?


Feature Request - before, after, success, failed hooks for crudify

The gem https://github.com/citrus/crudify that is based off the refinery code has hooks
before_create
before_update
after_create
after_update
successful_create
etc...
I'd like to see the same thing in refinery either by change refinery's crudify, or by switching refinery to use the crudify gem directly.

I'd like to add you to my professional network on LinkedIn.

Brian

Brian  Kierstead
Information Technology and Services Professional
Ontario, Canada
Confirm that you know Brian  Kierstead:
https://www.linkedin.com/e/-v2fo6-gui8p2qd-3b/isd/4773952454/jauG6S1s/?hs=false&tok=0IKXVqMGiIM4Y1
--
You are receiving Invitation to Connect emails. Click to unsubscribe:
http://www.linkedin.com/e/-v2fo6-gui8p2qd-3b/vXw_9xslRDt5wCZFhummeWyuW3AeSt6bi2HzGJ49geVWRAV_1wuz5js9ceCZlXVq-6qH50sRPsVWOOCmEtqHY_9wX9aYXGh-Q7qxJf/goo/reply%2Bi-900752-9182c34002c85b20b04990a10125fe9e6a8b3833%40reply.github.com/20061/I1659926531_1/?hs=false&tok=3nU3P_Yq6IM4Y1
(c) 2011 LinkedIn Corporation. 2029 Stierlin Ct, Mountain View, CA 94043, USA.


Use purescript-github-actions-toolkit library

Removes the src/Actions tree
Adds a the github-actions-toolkit dependency
Implements setup-purescript using the external bindings

This intends to close #4

I'm not sure how to get CI to run on this branch - I have run it on a private copy I have of this repo, but ideally I'd be able to run it here as well.

I created https://github.com/purescript-contrib/setup-purescript/pull/9 which I believe will make CI run on the commits to future PRs

Closes #4 also.

Aha! Tests are running :)


Introduce a repository introduction document for Project Veraison

Veraison Org has myriad of repositories. We need a high level document/README.md that explains what all repositories exists in Project Veraison and how they should be logically navigated to set the correct context!

See Issue https://github.com/veraison/docs/issues/6


[Feature request] Add a feature to dataset

Is there a straightforward way to add a field to the arrow_dataset, prior to performing map?

Do you have an example of what you would like to do? (you can just add a field in the output of the unction you give to map and this will add this field in the output table)

Given another source of data loaded in, I want to pre-add it to the dataset so that it aligns with the indices of the arrow dataset prior to performing map.
E.g.
new_info = list of length dataset['train']

dataset['train'] = dataset['train'].map(lambda x: some_function(x, new_info[index of x]))

def some_function(x, new_info_x):
    # adds new_info[index of x] as a field to x
    x['new_info'] = new_info_x
    return x

I was thinking to instead create a new field in the arrow dataset so that instance x contains all the necessary information when map function is applied (since I don't have index information to pass to map function).

This is what I have so far:
import pyarrow as pa
from nlp.arrow_dataset import Dataset

aug_dataset = dataset['train'][:]
aug_dataset['new_info'] = new_info

#reformat as arrow-table
schema = dataset['train'].schema

# this line doesn't work:
schema.append(pa.field('new_info', pa.int32()))

table = pa.Table.from_pydict(
    aug_dataset,
    schema=schema
)
dataset['train'] = Dataset(table)

Maybe you can use with_indices?
new_info = list of length dataset['train']

def some_function(indice, x):
    # adds new_info[index of x] as a field to x
    x['new_info'] = new_info_x[indice]
    return x

dataset['train'] = dataset['train'].map(some_function, with_indices=True)

Oh great. That should work. I missed that in the documentation- thanks :)


chore: cleanup after session finish

At the end of the test suite file _event is deleted, but _event.lock is not. This PR fixes it

:tada: This PR is included in version 5.2.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: