NameError: name 'dbutils' is not defined

When executing train_dolly.py, an error is reported, and the error message is as follows:
NameError: name 'dbutils' is not defined

If you're not executing on Databricks, just ignore those, and instead set the variables that those widgets set to whatever value you want directly in the script.


Improvements of module PvAPI

I have made some changes in the module PvAPI. The most changes are in the CPP file

   modules/videoio/src/cap_pvapi.cpp

The following changes have been made:

Some minor bugs have been removed.
In the PvAPI module the option CAP_PROP_MONOCROME has been REMOVED because
this option DOES NOT MAKE SENSE: For a b/w camera the option MONOCROME=false converts
a one-channel gray image into a three-channel color image with red, green, and blue equal.
This is NONSENSE and can be done by the user himself outside this module.
On the other hand, in the case of a COLOR camera the option MONOCROME=false causes
an ERROR and a CRASH of the program. Furthermore, this option has never been used by myself
or by any other people that I know and that are using the PvAPI module,
Instead the new option CAP_PROP_PVAPI_PIXELFORMAT has been added which allows
to activate the different pixel formats (color modes) of an AVT camera. For a color camera
you can retrieve alternatively a one-channel gray image or a three-channel rgb image.
This feature REPLACES the MONOCROME option and works much better.
There are some related changes in the header files

   modules/videoio/src/cap_pvapi.cpp
   modules/videoio/include/opencv2/videoio/videoio_c.h

The changes have been tested successfully with an b/w AVT camera by myself and
independently by Nick D'Ademo who has made the last major changes in the PvAPI module.
Furthermore, in the header files I have found two identical defines
(a)     CAP_PROP_MONOCROME = 19
(b)     CAP_PROP_MONOCHROME = 19
where the first one has an orthographic error. For this reason, I have removed the first one
in favor of the second one. The changes are made in the above mentioned header files and
in the following files

   modules/java/generator/gen_java.py
   modules/videoio/src/cap_dshow.cpp

The changes have been tested by a successful compilation on WINDOWS with the module
DSHOW switched on.
Sincerely,    Prof. Dr. Rudolf Haussmann, Uhldingen-Mühlhofen, Germany

@polarfuchs99 thank you very much for updating an API which is broken as hell. That is why me and @ShaiV went on a debugging rampage in the 2.4 branch to get the interface fixed in several ways

We ensured that the manta series is working there, and not only a preconfigured proscilla type
We ensured that multiple AVT gigE cameras could be read at once

The result of this fix (https://github.com/Itseez/opencv/pull/3322), was that the cap_pvapi worked for the 2.4 but I now see that many of the fixes never got into master.
What I suggest is that we try to unify both approaches and make sure that both 2.4 and master branch have identical working implementations. What do you think?
Is suggest that I will try out my AVT Manta BW camera to see if your interface is working or not. However I do think that a simple interface, like the sample (https://github.com/Itseez/opencv/blob/2.4/samples/cpp/videocapture_pvapi.cpp) added in our previous pull request should work without errors.

Dear Steven,
thank you for your response on my contribution. I have a Manta G31 b/w camera and tested the module on Linux and on Windows. It works perfectly. Also Nick D'Ademo, who has made a major contribution to the PvAPI module last year, has tested it successfuly with a Manta G31 camera. I think it will work also on your computer. I understand the OpenCV modules so that one can operate with a camera in a basic way. If one wants to have more features, one must write his own module. Maybe that your feature with multiple cameras was not integrated for this reaseon.
I suggest that we should clarify the things in a private communication. Here is my e-mail address<EMAIL_ADDRESS>If you send me your e-mail address, I can send you the files for opencv3.0.0-beta for which I have done the tests. Then you can test my files and integrate your features. Once we have a good solution, we can go to public and make a further pull request.
Best regards,
Rudi

@polarfuchs99 I got the camera connected and will try out your code this morning. Probably it will work perfectly fine. As to the feature of multiple camera access, it does work on the 2.4 branch, by simply iterating over the number of found cameras through the PvAPI.
Lets keep the communication focussed here, that allows future users to follow which changes have been applied for which reasons.
Feel free to sent the files to<EMAIL_ADDRESS>Steven

@polarfuchs99 I tested your code and it works like a charm on the AVT cameras we have lying around here. What I suggest is the following.

Expand this PR with the same sample as the 2.4 branch, but keep PR in mind. I forgot to add this information and it is quite important to know!
Lets make also a 2.4 PR which copies this functionality and cleaner interface to the 2.4 branch instead of some of the workarounds that me and Shai implemented.
Lets clean up the cpp file. All lines of code which are commented out should be removed, it happens to much and it clugs up the code.

I will add some remarks here and there in the available code also!
Good work!

BTW it seems that the master interface has way more accessible attributes than the 2.4 branch one. Will you supply the downwards merge or should I supply it myself?

@StevenPuttemans
I have sent you my changed files together with the original files for the OpenCV versions 2.4.10 and 3.0.0-beta. You can make your changes there and send me your files.
Can you please describe once again which features you want to add?
As one feature I understand that you want to use the PvAPI with two and more cameras. When you tested the software, does it work only for one camera or also for two and more cameras?

:+1:

@polarfuchs99 could you also upload your fixes for 2.4 like you suggested by mail? It all seems to work now :)


Missing support for m4a audio files for the Whisper speech-to-text API

Currently there is no support for m4a files. Is it as simple as implementing case m4a = "audio/m4a in MIMEType.Audio?
Also, it seems the default way to record audio in iOS using AVFoundation and AVAudioRecord is to create .m4a files, making it necessary to support.

I tested it, and it is as simple as adding the above case. Works with .m4a audio files creates using AVAudioRecord. Will create PR for this issue.


Error on building brand new este

I am getting an error on brand new este build on
OSX El Capitan
Node Version 6.2.1
Npm Version 3.8.6
[00:40:54] Requiring external module babel-register
(node:83474) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
(node:83474) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[00:40:56] Using gulpfile ~/Downloads/este-master/gulpfile.babel.js
[00:40:56] Starting 'env'...
fatal: Not a git repository (or any of the parent directories): .git
[00:40:56] 'env' errored after 13 ms
[00:40:56] Error: Command failed: git rev-parse HEAD
fatal: Not a git repository (or any of the parent directories): .git

    at checkExecSyncError (child_process.js:486:13)
    at execSync (child_process.js:526:13)
    at Gulp.<anonymous> (env.js:11:30)
    at module.exports (/Users/anlar/Downloads/este-master/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/Users/anlar/Downloads/este-master/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/Users/anlar/Downloads/este-master/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (/Users/anlar/Downloads/este-master/node_modules/orchestrator/index.js:134:8)
    at /usr/local/lib/node_modules/gulp/bin/gulp.js:129:20
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Function.Module.runMain (module.js:577:11)
    at startup (node.js:160:18)
    at node.js:456:3```

Yes, I should add to the readme, that git cmd tool is required. Can you please send readme pull request? Thank you.

Oh! :( yes, Thank you =)

Now pay your debt to open source, and send PR with readme update. Thank you ;-)


False positive: ignored hashes isn't a good strategy at long term

Hi there!
What would you like to be added:
A better strategy for ignoring false positives or for generating the Reference Hash.
Why is this needed:
We know that for each vulnerability found in a project, Horusec computes a Reference hash which is used as vulnerability identifier.
It seems that the hash is computed based on the type of the vulnerability, the Line it was found and the File Path of the class, relative to project directory.
Well it’s a bad strategy as the hashes are used in the config file or through Horusec Manager Dashboard for ignoring vulnerabilities (e.g. if they're false positives).
Developers change the code inside a project every time (bug fixes, refactors, new features…) and it causes the hash to change (a simple forgotten newline would change it)! So, in a project with a large number of false positives, Horusec Manager would contain a list with a large number of useless hashes. How could a developer determine the old useless hash to be replaced with the new one generated after the changes made?
Furthermore, an ignored false positive is able to become a real vulnerability by a simple change which keeps the line and doesn't affect the vulnerability type and file path. If hash doesn’t change, the now supposed “true positive” would be kept as ignored.
Maybe you could use a reference hash based on the line content. It is also possible to include more information in ignored list, for identifying whether analysed code keeps the same...

after some time we have an update about it, check #950


npm build error

#0 0.450
#0 0.450 ><EMAIL_ADDRESS>build
#0 0.450 > tsc && cross-env NODE_OPTIONS=--max-old-space-size=6096 vite build
#0 0.450
#0 17.66 vite v2.9.15 building for production...
#0 17.71 transforming...
#0 25.07 ✓ 692 modules transformed.
#0 25.07 [vite:load-fallback] Could not load /src/plus/parcels/SiteSettings (imported by src/pages/siteSettings/index.tsx): ENOENT: no such file or directory, open '/src/plus/parcels/SiteSettings'
#0 25.07 error during build:
#0 25.07 Error: Could not load /src/plus/parcels/SiteSettings (imported by src/pages/siteSettings/index.tsx): ENOENT: no such file or directory, open '/src/plus/parcels/SiteSettings'

已修复

ok 已经编译通过了~


Get human-readable errors

As discussed in #35,  I would like to have a way to get nice human-readable errors that can be displayed/logged to the end user. My PR exposed .context on error but that's probably not the way to go.
Could this be achieved, if so how and should I make a PR for that?

Could you provide an example of what the current output is and an example of what you'd want changed?

This is the code I have:
let messages: Vec<_> = CargoBuild::new()
    .current_release()
    .current_target()
    .manifest_path(&manifest_path)
    .target_dir(&self.directory)
    .exec()?
    .collect();

for message in messages {
    match message {
        Ok(message) => match message.decode() {
            Ok(message) => trace!("{:#?}", message),
            Err(err) => error!("{:#?}", err),
        },
        Err(err) => error!("{:#?}", err),
    }
}

Currently this shows me the following error:
[2019-12-10T09:02:53Z ERROR project] CargoError {
        kind: CommandFailed,
        context: Some(
            "error: failed to parse manifest at `...\\project\\target\\example\\Cargo.toml`\n\nCaused by:\n  Invalid character `$` in package name: `${short_name}`\n",
        ),
        cause: None,
    }

So basically what I want is just the context (hence my PR):
error: failed to parse manifest at `..\\project\\target\\example\\Cargo.toml`

Caused by:
  Invalid character `$` in package name: `${short_name}`

Why are you using {:#?} instead of {}?  You are getting Debug rather than Display which would be terrible to show users.

Oh right that's exactly what I wanted, because escargot::format::Message doesn't implement  Display I assumed it would be the same for errors. My bad for wasting your time.

It is understandable.  Once I saw the code, I assumed they were being treated the same.


Error on schema mistmatch after repository fetch

Hi, I just found a problem in my project which uses the redis-om-node package. My redis database changes over time, and the schema also. Some entities contain extra fields which fields are not defined in the schema. If I do a fetch on these objects the OM throws an error.  The error comes from this line, I think the OM tries to fetch the field from the schema, I think there should have been some checks, or I missed some configurations.
Error:

The error comes from here:

Version: 0.3.6

So you have fields in Redis that aren't defined in your schema? That would certainly create an error. This will be resolved in version 1.0 but in the meantime, can you add the missing fields to your schema? Redis OM for Node.js can handle missing fields in the data just fine but not missing fields in the schema.

It depends on when you wanna release the 1.0 because this will be a lot of maintenance.

This was fixed with the release of Redis OM 0.4.0 Beta. Install it with npm install redis-om@beta.


Add raiplay.it site

Could you also add the raiplay.it/raiplay.it.test.js file with the tests?

@freearhey Sure, i will ASAP. Let me know if something is wrong with the files of the request, I created them but sincerely i don't know how to test the workflow.

You can run a check on a particular config file by using the command:
npm test -- raiplay.it

You can run a check on a particular config file by using the command:
npm test -- raiplay.it

Do I have to clone the whole repository first? Until now, I have created the files from the site.
I installed epg-grabber to test the result and noticed that the end times are not correct. How can I debug the code?

Great job!

The guide is already available at this link:
https://iptv-org.github.io/epg/guides/it/raiplay.it.epg.xml

and tomorrow it should also appear on the homepage.


libeduvpn-common: 1.2.1 -> 2.0.1 and eduvpn-client: 4.2.1 -> 4.3.0

Description of changes
Packaging of upstream changed and needed some manual tweaks, replaces https://github.com/NixOS/nixpkgs/pull/317353
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am not sure why the client now needs the postInstall thing, but the folders are not copied to the right place else, maybe you @jwijenbergh have a better idea what is happening there.

Yeah I think my setup.cfg was not completely correct here, does it work without changes with this patch? https://github.com/eduvpn/python-eduvpn-client/pull/595

yes this works, and also get's rid of one of the nix specific patches 👍

yes this works, and also get's rid of one of the nix specific patches 👍 EDIT: let me know if you tag a 4.3.1 and I'll update the PR accordingly and remove the manual patch

4.3.1 has been tagged, thank you for testing this!

@benneti i tagged another common version for some translations and some tiny changes
https://github.com/eduvpn/eduvpn-common/releases/tag/2.0.1

sorry for the delay, bumped and squashed

Thanks! @h7x4 @benneti


Feature-Request -> Typings for typescript

Can you add that?
Thanks!

Can, but won't at this time. I don't use TypeScript anywhere and it's just another tool to try and support when there's already Babel.


Support for Vapor?

I'm working on a Swift project that has a server side, and client side. I'd like to unify the definition of endpoints across both builds.
Something like this would be very useful:
let routesBuilder = ...
let provider = Provider(baseURL: "https://api.example.com/")
let users: Users = UsersAPI(provider: provider)

routesBuilder.addRoutes(from: users)

Excellent idea - this is actually in progress. Hoping to have an MVP up soon.
Will keep you posted!

Great to hear!
I have a feeling my needs my slightly differ from whatever the base implementation is, so would be very useful to have a means of accessing an array of path components for each route, so I can process them manually.

How do you think your needs might differ? I can try and work something specific in.


[Dashboard] [Welcome] "New Dataset" button opens "New Map" modal

Steps to reproduce

Login to the New Dashboard.
Click the "New Dataset" button in the Welcome module.

Actual result
The "New Map" modal opens:

Expected result
The "New Dataset" modal opens:

cc: @csubira


fix: Disambiguate timeout behavior for response headers and body

There is a single timeout option which applies to both the receiving of
response headers and the receiving of the entire response body. Once
the response is received, the socket timeout must be cleared to allow
the timeout to apply to the receiving of the entire response body.
Without clearing the socket timeout, if the nearing the idle timeout
when the Promise for the body is created, then the request's timeout
handler will abort the request, emitting ERR_STREAM_PREMATURE_CLOSE in
the body Promise.
By clearing the socket timeout once the response headers are received,
the timeout for the entire body can be started when the body is awaited.
Since the request will no longer be aborted by the socket timeout,
destroy is called on the body to prevent it continuing to emit data
events.

Picked from #768

Responding to @jimmywarting https://github.com/node-fetch/node-fetch/pull/768#issuecomment-612234113

That is a changing/breaking behavior for ppl using timeout already. in fact, timeout is discouraged and was something we added long ago in the beginning before AbortController where even a thing

Using a abort-singal is the way to go now and is more cross node/web compatible. You have control over when it should timeout (request, response or both)...

Let's set aside the desire to remove timeout, since it is still here, and I believe this is a useful bug fix as long as timeout remains.
I don't think this is a breaking change - can you elaborate on why you see it that way?
I'm sure you noticed that test should allow custom timeout on response body is flaky - that's what is being fixed here. I left that test unchanged to demonstrate that it would reliably pass now, and I added a new test to demonstrate why.
Previously, if timeout was specified and the response headers were received before the timeout, the body Promise may have rejected with a ERR_STREAM_PREMATURE_CLOSE due to the abort call from the timeout handler that was added to the request. I considered this a bug because a timeout led to a rejection which was not recognizable as such.
Further, the timer that is started when the body is awaited covers all data events emitted by the stream, which is to say the entire body must be received before the timer is due. The socket timeout is an idle timeout, which is reset on each data event. So, the change that I have made only affects use cases where there was a significant delay between the response being received and the body being awaited. The impact on such cases is that when the body is awaited, the promise will no longer reject with ERR_STREAM_PREMATURE_CLOSE if the socket was idle between the response being received and the body being awaited.
So, I would say the existing behavior was "undefined" for this edge case, and now it is defined in a way that is consistent with how the API has long been described to work.

Thanks for the reviews @tinovyatkin and @NotMoni 🙏  I rebased to resolve the merge conflict.


gherkin-dotnet: Support for .NET Standard 2.0

Summary
.NET Standard 2.0 is not supported.
Trying to use the Gherkin parser under .NET Core 2.0 and .NET Standard 2.0 will cause a fallback to .NET 4.x and the parser will try and fail to load System.Web.Extensions.
Expected Behavior
Parse feature files successfully using .NET Core 2.0 and .NET Standard 2.0.
Current Behavior
Considering a web project targeting netcoreapp2.0 that consumes a library targeting netstandard2.0 and this library tries to use the Gherkin parser.
The parser try to load System.Web.Extensions on Gherkin.GherkinDialectProvider.ParseJsonContent() and fail with a System.IO.FileNotFoundException: Could not load file or assembly 'System.Web.Extensions' exception.
Possible Solution
Update the project to support .NET Standard 2.0.
Your Environment
Windows 10, Visual Studio Code, dotnet core SDK 2.0.0, dotnet core 2.0.0.

This is mostly done in #174 I think

Looks like it will be fixed after this PR, but something went wrong in the build, although it passed. The version number was not upgraded and the nuget package was not published. https://ci.appveyor.com/project/aslakhellesoy/gherkin

No idea why AppVeyor does not find the nuget package and uploads it.

Ok, after some small changes in https://github.com/cucumber/gherkin-dotnet/pull/10, the build finds the nuget package and creates a correct looking version number for it.

I believe this is fixed now. Let me know if I got it wrong.


[FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

What is the purpose of the change
The lifecycle/scope of WatermarkStatus is tightly coupled with watermarks. Upstream watermarks are cut off in the TimestampsAndWatermarksOperator and therefore watermark statuses should be cut off as well.
Verifying this change
Added tests in:

TimestampsAndWatermarksOperatorTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure


When creating a group with a concierge, the icon is displayed in the old style.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
and login
Create a new chat with Concierge

Expected Result:
The Concierge icon should be in the new format (with a green triangle)
Actual Result:
When creating a group with a concierge, the icon is displayed in the old format.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.2.33-1
Reproducible in staging?: Y
Reproducible in production?:  (New feature)
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01aeb420f5c4a00dfc
Upwork Job ID:<PHONE_NUMBER>925869056

Proposal
Inside ReportActionItemSingle, I notice that we are still using the old Concierge icon image url so that's why this issue happend

Solution
We need to update the icon url to new Concierge icon url, also add new condition to make it detect that's Concierge.
  const {avatar, displayName, login} = props.personalDetails[props.action.actorEmail] || {};
    const avatarUrl = (props.action.automatic || props.action.actorEmail === CONST.EMAIL.CONCIERGE)
        ? CONST.CONCIERGE_ICON_URL
        // Use avatar in personalDetails if we have one then fallback to avatar provided by the action
        : (avatar || props.action.avatar);

I can reproduce the issue, though building on what @hungvu193 post above, what's interesting is that as soon as you mouse over any message, the new avatar is applied. Here's a screenshot for reference.

I'll go ahead and apply the external label, though I'd like to see commentary from @NikkiWines, as she was on the original PR and probably has the best context. Thanks!

Looks like changes is needed in backend. api?command=OpenReport is returning https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png as avatar in reportActions.
{
	"1": {
		"person": [
			{
				"type": "TEXT",
				"style": "strong",
				"text": "Concierge"
			}
		],
		"actorEmail"<EMAIL_ADDRESS>		"actorAccountID": 8392101,
		"message": [
			{
				"type": "COMMENT",
				"html": "👋 Welcome to Expensify! I'm Concierge. Is there anything I can help with? Click the + icon on the homescreen to explore the features you can use.",
				"text": "👋 Welcome to Expensify! I'm Concierge. Is there anything I can help with? Click the + icon on the homescreen to explore the features you can use.",
				"isEdited": false
			}
		],
		"originalMessage": {
			"html": "👋 Welcome to Expensify! I'm Concierge. Is there anything I can help with? Click the + icon on the homescreen to explore the features you can use."
		},
		"avatar": "https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png",
		"created": "2022-09-21 06:12:08.178",
		"timestamp":<PHONE_NUMBER>,
		"automatic": false,
		"sequenceNumber": 1,
		"actionName": "ADDCOMMENT",
		"shouldShow": true,
		"clientID": "",
		"reportActionID": "2154625890648324009"
	}
}

@sobitneupane yeah I saw that too, I also saw that piece of code I mentioned was there since 18 months ago. Should we keep that or fix this issue from backend?

We mainly use the avatar from personalDetails, and the avatar from the report actions as a fallback. The avatar from personalDetails is the newest and is set to the avatarUrl. I think updating the API response will not resolve this issue.

The question is:

Why the avatarUrl is changed from .../concierge_2022.png to .../concierge_2021.png while the avatar from personalDetails still has the latest avatar?
Why does the avatar shows the correct image after hovering the chat message?

@mollfpr You may have noticed that avatarHighResolutions needs to be updated as well.

@mollfpr You may have noticed that avatarHighResolution needs to be updated as well.

@sobitneupane I couldn't understand what you mean. Could you elaborate more?

Could you elaborate more?

@mollfpr I am just letting you know that avatarHighResolution in personalDetails also contains https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png which is not expected.
To answer your questions:

Why the avatarUrl is changed from .../concierge_2022.png to .../concierge_2021.png while the avatar from personalDetails still has the latest avatar?

Resopnse from api?command=OpenApp also contains https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png as avatar.

So, when [Onyx] set()  is called for key: personalDetails properties, avatarURL changes to ../concierge_2021.png

Why does the avatar shows the correct image after hovering the chat message?

On hovering the chat message, ReportActionItemSingle re-renders and gets the correct value from the updated personal Details.
I am not sure when and where personalDetails gets updated to have concierge_2022.png as avatar, as server is not returning it. I guess somewhere in the frontend CONST.CONCIERGE_ICON_URL is used to update personalDetails in onyx.

Thanks! Yeah, I just find out too about the response from api?command=OpenApp. Since we already implement CONST.CONCIERGE_ICON_URL to update the concierge avatar, we could fix this issue in the App.
Any thoughts @yuwenmemon @JmillsExpensify?

Hello 👋 I still have the old concierge icon even on main chats page ( iOS simulator )

@hungvu193 Your proposal did fix the issue, but I am more inclined to fix why ReportActionItemSingle didn't show the latest concierge personalDetails.

@mollfpr damn, I found a very funny bug in this line:
const {avatar, displayName, login} = props.personalDetails[props.action.actorEmail] || {};

The values of props.personalDetails[props.action.actorEmail] has avatar: https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2022.png
But when I tried to console.log the avatar value from destructuring it returned: https://d2k5nsl2zxldvw.cloudfront.net/images/icons/concierge_2021.png

@hungvu193 Yup, that makes me confuse at first 🤣

@mollfpr but look at the preview, the avatar is 2021, so now I'm confused with myself :|

I saw the same thing for hover in this comment.

Yeah.
But again the issue here's the way avatarUrl's calculated:
    const avatarUrl = props.action.automatic
        ? `${CONST.CLOUDFRONT_URL}/images/icons/concierge_2019.svg`

        // Use avatar in personalDetails if we have one then fallback to avatar provided by the action
        : (avatar || props.action.avatar);

props.action.automatic is false even with Concierge message, so the condition always return (avatar || props.action.avatar), so if we fix the condition, we don't need to care about the weird rendering.

Oops, yep definitely missed this when updating the avatar.
Some potentially helpful context<EMAIL_ADDRESS>will have the old (2021) avatar in the personalDetails because we want to maintain the old avatar for www.expensify.com. There are a lot more places to update the avatar on that site, it was simplest to maintain the old avatar in the personalDetails and overwrite it only for new.expensify.com.

Super helpful. Curious for your take: Should we keep this external given the theories above, or should we include this as part of PR polish and take internal?

I think @hungvu193's proposal would be fine based on what @NikkiWines is saying.
However, I'm also noticing that since we grab Personal Details on App Init, we do indeed have "App-only" logic in PHP that's sending over the personal details and could probably replace the avatar there. @NikkiWines what do you think?

Nice, yeah that sounds great to me @yuwenmemon 👍

All right, assigning myself and taking this internal then.

Because the issue requires updating the API, this issue is internal and requires access to a private repo. Removed the bounty from the title and closed out the Upwork job as well.

Linked PR is merged and internal, so once that hits production, this issue should close out automatically.

Oh, since this was cross repo it didn't close out when it got deployed to prod. Closing this out now! This has been on prod for a few days

Is it deployed to new.expensify.com? I'm still able to reproduce it

@yuwenmemon @JmillsExpensify The issue is still there on staging and production.

Interesting, will take a look!

@yuwenmemon
The response from API is still using the old concierge image avatar.

@mollfpr Yes I have an internal PR open!

Circling back on this issue when I return on Tuesday.

The associated internal PR has been deployed to prod: https://github.com/Expensify/Web-Expensify/pull/35814
Closing!

I'm not sure if this is deployed to staging, still can reproduce it!

Version: v1.2.43-1

Also reproducible on production v1.2.42-2 Web. I can't reproduce it on mWeb iOS Chrome.
https://user-images.githubusercontent.com/25520267/209061029-0bf43fa9-f196-42d5-ac46-76bef5d487f8.mov

I still can reproduce on IOS

Hmmm... Curious. I guess there's somewhere else in the API where the old Avatar is getting sent from.

@hungvu193 I updated that lone remaining Avatar in the PR above but that's not going to fix the issue since we're not dealing with an automatic: true action with that opening 👋 Hey there, I'm Concierge! message.

Proposal
Inside ReportActionItemSingle, I notice that we are still using the old Concierge icon image url so that's why this issue happened

Solution
We need to update the icon url to new Concierge icon url, also add new condition to make it detect that's Concierge.

-    const avatarUrl = props.action.automatic

-       ? `${CONST.CLOUDFRONT_URL}/images/icons/concierge_2019.svg`

-

-        // Use avatar in personalDetails if we have one then fallback to avatar provided by the action

-       : (avatar || props.action.avatar);

+    const avatarUrl = (props.action.automatic || props.action.actorEmail === CONST.EMAIL.CONCIERGE)

+        ? CONST.CONCIERGE_ICON_URL

+       // Use avatar in personalDetails if we have one then fallback to avatar provided by the action

+       : (avatar || props.action.avatar);

I wonder why we need the props.action.automatic, can we remove it too? I checked the log and see even with Concierge, the props.action.automatic is still false.
https://user-images.githubusercontent.com/16502320/204432846-cf9c9a57-aa83-4a10-b404-a709d6d6e093.mov

@yuwenmemon Yeah because in most cases, prop.automatic is always false, let update as my proposal here with a check when email is Concierge

@yuwenmemon are we External this issue?

Good question. If we are, then we would need to create another issue. I'll leave the decision to @yuwenmemon though.

@yuwenmemon is OOO this week, so I'm removing the daily and we can align on next steps when he returns.

I'm back! @hungvu193 I see what you're saying. My one concern is that this would be a "band-aid" fix that masks the true reason why we're seeing the old icon in the first place.

@yuwenmemon the root cause is that the api?command=OpenReport is still returning the 2021 icon.
So I think the decision is yours, we can keep up with the front end check that we already have or we will fix this in the backend 😄

Looks like this issue will re-close again once the Web PR hits production. That should happen tomorrow.

Closing as the linked PR has hit production.


[BACKLOG-36433] - Don't show authentication dialogue for Filerepository connect in PDI

[BACKLOG-36433] - Don't show authentication dialogue for File repository connect in PDI

:white_check_mark: Build finished in 6m 37s
Build command:
mvn clean verify -B -e -Daudit -amd -pl plugins/repositories/core

:ok_hand: All tests passed!
Tests run: 20, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Fixes to flow notification e-mails

(Original PR: https://github.com/azkaban/azkaban/pull/680, here squashed into a single commit)

Removed misleading mention about "executor bounce"[1]
Fixed e-mail subject of first error message: "failed" => "encountered a failure"
All flow notification e-mails to include flow status (as asked by @georgezhlw and @HappyRay)
Created a unit test for DefaultMailCreator

--
[1] One of the "Reason" messages for all flow failure alerts used to be this:

Executor no longer seems to be running this execution. Most likely due to executor bounce.

Usually the alert comes because a job itself failed. It's confusing to suggest that executor node would've been restarted, when it's not.

Thanks!


BUG: Can't show git status for files with a single character filename

Did you check docs and existing issues?

[X] I have read all the docs.
[X] I have searched the existing issues.
[X] I have searched the existing discussions.

Neovim Version (nvim -v)
NVIM v0.10.0-dev
Operating System / Version
wsl2 ubuntu-22.04
Describe the Bug
Hey, there. I've noticed that when the filename is only a single character, it doesn't show its git status correctly, as shown in the following screenshot:

After digging deeper, I found that the following code snippet filters out some items that are not long enough, in my case files 1,2,3
https://github.com/nvim-neo-tree/neo-tree.nvim/blob/3c68ae5968b75aea8d445b3bb024e007b0bd0b65/lua/neo-tree/git/status.lua#L57-L59
I didn't find any explanation for this change in the docs, but I did find an associated issuse #187 here. i'm not sure the effect of this change is exactly what was expected, @cseickel sorry to bother you, can you take a look at this when you have time?
Screenshots, Traceback
No response
Steps to Reproduce

touch 1 2 3 45 67 89
nvim
:Neotree

Expected Behavior
Correct display of file status
Your Configuration
All configurations are disabled, only neotree's default setup is retained.
require("neo-tree").setup()

Is there anything else going on here?🤔


Regression with<EMAIL_ADDRESS>

Sails version: 1.0.0-33
Node version: 7.5.0
NPM version: 4.4.4
Operating system: macOS Sierra 10.12.4

Hello, when I start my sails app, I'm experiencing this error with<EMAIL_ADDRESS>> NODE_ENV=development node $NODE_DEBUG_OPTION app.js

info: ·• Auto-migrating...  (alter)
info:    Hold tight, this could take a moment.
error: A hook (`orm`) failed to load!
error: Could not tear down the ORM hook.  Error details: Error: Consistency violation: Attempting to tear down a datastore (`default`) which is not currently registered with this adapter.  This is usually due to a race condition in userland code (e.g. attempting to tear down the same ORM instance more than once), or it could be due to a bug in this adapter.  (If you get stumped, reach out at http://sailsjs.com/support.)
    at Object.teardown (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails-mongo/lib/index.js:346:19)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline/lib/waterline.js:327:27
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:3047:20
    at eachOfArrayLike (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1002:13)
    at eachOf (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1052:9)
    at Object.eachLimit (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:3111:7)
    at Object.teardown (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline/lib/waterline.js:311:11)
    at Hook.teardown (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails-hook-orm/index.js:246:30)
    at Sails.wrapper (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/@sailshq/lodash/lib/index.js:3250:19)
    at Object.onceWrapper (events.js:291:19)
    at emitNone (events.js:86:13)
    at Sails.emit (events.js:186:7)
    at Sails.emitter.emit (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails/lib/app/private/after.js:56:26)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails/lib/app/lower.js:67:11
    at beforeShutdown (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails/lib/app/lower.js:45:12)
    at Sails.lower (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails/lib/app/lower.js:49:3)
error: Failed to lift app: Error: The model `token` has attributes with non-unique column names. Each attribute in the model must have a unique column name.
    at parseCollections (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline-schema/lib/waterline-schema/checks.js:44:13)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/@sailshq/lodash/lib/index.js:3228:15
    at baseForOwn (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/@sailshq/lodash/lib/index.js:2199:14)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/@sailshq/lodash/lib/index.js:3198:18
    at Function.<anonymous> (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/@sailshq/lodash/lib/index.js:3501:13)
    at sanityChecks (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline-schema/lib/waterline-schema/checks.js:15:5)
    at new WaterlineSchema (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline-schema/lib/waterline-schema.js:48:3)
    at Object.initialize (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/waterline/lib/waterline.js:155:26)
    at buildOntologyAndRunAutoMigrations (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails-hook-orm/lib/build-ontology-and-run-auto-migrations.js:55:7)
    at async.auto._buildOntology (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/sails-hook-orm/lib/initialize.js:436:7)
    at runTask (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1660:17)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1602:17
    at processQueue (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1612:17)
    at taskComplete (/Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1630:13)
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:1653:21
    at /Users/eliottvincent/Development/tmp-family-abcde/node_modules/async/dist/async.js:339:31
error: (You are seeing this error message because no callback was provided to `.lift()`.)

Process finished with exit code 0

This is my package.json:
{
	"name": "somename",
	"private": true,
	"version": "0.0.1",
	"description": "somedescription",
	"keywords": [somekeywords],
	"dependencies": {
		"sails": "^1.0.0-33",
		"grunt": "1.0.1",
		"sails-hook-orm": "^2.0.0-0",
		"sails-hook-sockets": "^1.0.1",
		"sails-hook-grunt": "^1.0.4",
		"lodash": "3.10.1",
		"async": "2.0.1",
		"mongoose": "^4.9.0",
		"request": "^2.75.0",
		"sails-mongo": "^1.0.0-7"
	},
	"devDependencies": {
		"eslint": "3.19.0",
		"jshint": "2.9.4"
	},
	"scripts": {
		"start": "NODE_ENV=production node app.js",
		"start-dev": " NODE_ENV=development node $NODE_DEBUG_OPTION app.js",
		"test": "npm run lint && npm run custom-tests && echo 'Done.'",
		"lint": "npm run eslint && npm run jshint",
		"eslint": "node ./node_modules/eslint/bin/eslint . --max-warnings=100 && echo '✅  ESLINT validated'",
		"jshint": "node ./node_modules/jshint/bin/jshint api/. && echo '✅  JSHINT validated'",
		"custom-tests": "echo \"(No other custom tests yet.)\" && echo",
		"debug": "node debug app.js"
	},
	"main": "app.js",
	"repository": {
		"type": "git",
		"url": "someurl"
	},
	"author": "Eliott VINCENT<EMAIL_ADDRESS>	"license": "MIT"
}

And my config/datastores.js :
 * Datastores
 * (sails.config.datastores)
 *
 * A set of datastore configurations which tell Sails where to fetch or save
 * data when you execute built-in model methods like `.find()` and `.create()`.
 *
 *  > This file is mainly useful for configuring your development database,
 *  > as well as any additional one-off databases used by individual models.
 *  > Ready to go live?  Head towards `config/env/production.js`.
 *
 * For more information on configuring datastores, check out:
 * https://sailsjs.com/config/datastores
 */

module.exports.datastores = {

  /***************************************************************************
  *                                                                          *
  * Your app's default datastore.                                            *
  *                                                                          *
  * Sails apps read and write to local disk by default, using a built-in     *
  * database adapter called `sails-disk`.  This feature is purely for        *
  * convenience during development; since `sails-disk` is not designed for   *
  * use in a production environment.                                         *
  *                                                                          *
  * To use a different db _in development_, follow the directions below.     *
  * Otherwise, just leave the default datastore as-is, with no `adapter`.    *
  *                                                                          *
  * (For production configuration, see `config/env/production.js`.)          *
  *                                                                          *
  ***************************************************************************/

  default: {

    /***************************************************************************
    *                                                                          *
    * Want to use a different database during development?                     *
    *                                                                          *
    * 1. Choose an adapter:                                                    *
    *    https://sailsjs.com/plugins/databases                                  *
    *                                                                          *
    * 2. Install it as a dependency of your Sails app.                         *
    *    (For example:  npm install sails-mysql --save)                        *
    *                                                                          *
    * 3. Then pass it in, along with a connection URL.                         *
    *    (See https://sailsjs.com/config/datastores for help.)                  *
    *                                                                          *
    ***************************************************************************/
    adapter: 'sails-mongo',
    url: 'mongodb://<IP_ADDRESS>:27017/family-db-local',

  },

};

@eliottvct thanks! Looking into it

No problem, let me know if you need extra information

Hey @eliottvct, would you post your Token module?  (or feel free to do it in the separate issue-- that sounds like a good idea)
The first error is definitely confusing, but fortunately can safely be ignored.  It's just being displayed because Sails is trying to terminate the ORM before it ever successfully started up.  This is something we can improve upon (basically we just need to use a flag in sails-hook-orm).  I'll flag this issue as orange in regards to that.

@mikermcneil Thanks for your fast support! I opened issue 4072 with Token.js model

@eliottvct @mikedevita : Hello,
I am getting same error. Please find error message and below.
error: A hook (orm) failed to load!
error: Could not tear down the ORM hook.  Error details: Error: Consistency viol
ation: Attempting to tear down a datastore (mongodb) which is not currently re
gistered with this adapter.  This is usually due to a race condition in userland
code (e.g. attempting to tear down the same ORM instance more than once), or it
could be due to a bug in this adapter.  (If you get stumped, reach out at http:
//sailsjs.com/support.)
at Object.teardown (E:\Artisantech\node-wagbuddy\node_modules\sails-mongo\li
b\index.js:390:19)
at E:\Artisantech\node-wagbuddy\node_modules\waterline\lib\waterline.js:327:
27
at E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:3047:20
at eachOfArrayLike (E:\Artisantech\node-wagbuddy\node_modules\async\dist\asy
nc.js:1002:13)
at eachOf (E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:105
2:9)
at Object.eachLimit (E:\Artisantech\node-wagbuddy\node_modules\async\dist\as
ync.js:3111:7)
at Object.teardown (E:\Artisantech\node-wagbuddy\node_modules\waterline\lib
waterline.js:311:11)
at Hook.teardown (E:\Artisantech\node-wagbuddy\node_modules\sails-hook-orm\i
ndex.js:246:30)
at Sails.wrapper (E:\Artisantech\node-wagbuddy\node_modules@sailshq\lodash
lib\index.js:3250:19)
at Sails.g (events.js:292:16)
at emitNone (events.js:86:13)
at Sails.emit (events.js:185:7)
at Sails.emitter.emit (E:\Artisantech\node-wagbuddy\node_modules\sails\lib\a
pp\private\after.js:56:26)
at E:\Artisantech\node-wagbuddy\node_modules\sails\lib\app\lower.js:67:11
at beforeShutdown (E:\Artisantech\node-wagbuddy\node_modules\sails\lib\app\l
ower.js:45:12)
at Sails.lower (E:\Artisantech\node-wagbuddy\node_modules\sails\lib\app\lowe
r.js:49:3)
error:
error: TypeError: Cannot read property 'indexOf' of undefined
at normalizeDatastoreConfig (E:\Artisantech\node-wagbuddy\node_modules\sails
-mongo\lib\private\normalize-datastore-config\index.js:61:19)
at Object.registerDatastore (E:\Artisantech\node-wagbuddy\node_modules\sails
-mongo\lib\index.js:206:7)
at E:\Artisantech\node-wagbuddy\node_modules\waterline\lib\waterline.js:283:
27
at E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:3047:20
at eachOfArrayLike (E:\Artisantech\node-wagbuddy\node_modules\async\dist\asy
nc.js:1002:13)
at eachOf (E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:105
2:9)
at Object.eachLimit (E:\Artisantech\node-wagbuddy\node_modules\async\dist\as
ync.js:3111:7)
at Object.initialize (E:\Artisantech\node-wagbuddy\node_modules\waterline\li
b\waterline.js:219:11)
at buildOntologyAndRunAutoMigrations (E:\Artisantech\node-wagbuddy\node_modu
les\sails-hook-orm\lib\build-ontology-and-run-auto-migrations.js:55:7)
at async.auto._buildOntology (E:\Artisantech\node-wagbuddy\node_modules\sail
s-hook-orm\lib\initialize.js:436:7)
at runTask (E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:16
60:17)
at E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:1602:17
at processQueue (E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.
js:1612:17)
at taskComplete (E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.
js:1630:13)
at E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:1653:21
at E:\Artisantech\node-wagbuddy\node_modules\async\dist\async.js:339:31
error: Could not load Sails app.
error:
error: Tips:
error:   First, take a look at the error message above.
error:   Check that you're using the latest stable version of Sails.
error:   Have a question or need help?  (http://sailsjs.com/support)
Below are the dependencies I am using.
"dependencies": {
    "async": "2.0.1",
    "grunt": "1.0.1",
    "lodash": "3.10.1",
    "sails": "^1.0.0-36",
    "sails-hook-grunt": "^2.0.0",
    "sails-hook-orm": "^2.0.0-16",
    "sails-hook-sockets": "^1.4.0",
    "sails-mongo": "^1.0.0-9"
  },
  "devDependencies": {
    "eslint": "3.5.0"
  }

please im facing same problem, how can i solve this

@preciousemmanuel npm uninstall sails-hook-orm

Getting same issue when deploy on the server, Can anyone help me please.
I am using sails-mysql adapter
error: A hook (orm) failed to load!
error: Could not tear down the ORM hook.  Error details: Error: Invalid data store identity. No data store exist with that identity.
at Object.teardown (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-mysql/helpers/teardown.js:60:26)
at wrapper (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/@sailshq/lodash/lib/index.js:3275:19)
at Deferred._handleExec (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/machine/lib/private/help-build-machine.js:1076:19)
at Deferred.exec (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/parley/lib/private/Deferred.js:286:10)
at Deferred.switch (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/machine/lib/private/help-build-machine.js:1469:16)
at teardownDatastore (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-mysql/lib/adapter.js:94:18)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3047:20
at replenish (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:884:21)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:888:13
at eachLimit$1 (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3136:26)
at Object. (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:920:20)
at Object.teardown (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-mysql/lib/adapter.js:89:13)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/waterline/lib/waterline.js:758:27
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3047:20
at eachOfArrayLike (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1002:13)
at eachOf (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1052:9)
at Object.eachLimit (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3111:7)
at Object.teardown (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/waterline/lib/waterline.js:742:11)
at Hook.teardown (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-hook-orm/index.js:246:30)
at Sails.wrapper (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/@sailshq/lodash/lib/index.js:3275:19)
at Object.onceWrapper (events.js:322:30)
at emitNone (events.js:115:13)
at Sails.emit (events.js:218:7)
at Sails.emitter.emit (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails/lib/app/private/after.js:56:26)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails/lib/app/lower.js:67:11
at beforeShutdown (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails/lib/app/lower.js:45:12)
at Sails.lower (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails/lib/app/lower.js:49:3)
at Sails.wrapper [as lower] (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/@sailshq/lodash/lib/index.js:3275:19)
error:
error: Exception: registerDataStore failed ("badConfiguration").  The configuration was invalid.  (Also got an additional error -- see .raw).
at Object.registerDatastore (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-mysql/lib/adapter.js:54:17)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/waterline/lib/waterline.js:714:27
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3047:20
at eachOfArrayLike (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1002:13)
at eachOf (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1052:9)
at Object.eachLimit (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:3111:7)
at Object.initialize (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/waterline/lib/waterline.js:650:11)
at buildOntologyAndRunAutoMigrations (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-hook-orm/lib/build-ontology-and-run-auto-migrations.js:55:7)
at async.auto._buildOntology (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-hook-orm/lib/initialize.js:456:7)
at runTask (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1660:17)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1602:17
at processQueue (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1612:17)
at taskComplete (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1630:13)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1653:21
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:339:31
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:847:20
at async.auto._checkAdapterCompatibility (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/sails-hook-orm/lib/initialize.js:428:14)
at runTask (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1660:17)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1602:17
at processQueue (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1612:17)
at taskComplete (/var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1630:13)
at /var/www/projects/abang/abang/fernline-api-fresh/node_modules/async/dist/async.js:1653:21

Yo tenia el password de la base de datos asi: "90a9d8$0s*/*@" y lo cambie solo por letras y numeros y ya jalo.

I faced the same issue with MySQL adapter and datastore config. It got fixed when I used a plain alphanumeric mysql password without special characters. FYI my earlier password was K!a(HK$%{K. Thanks for https://github.com/balderdashy/sails/issues/4069#issuecomment-495046633 for the tip!


Remote drivers

I love everything about this package and how it treats data. But it is really hard to incorporate for non-local data. Is there a sanctioned way to deal with data hosted on, say, AWS S3 or similar?

Thanks. Basically we'll need storage drivers for each type of remote data API. So far I haven't had time to make a solid implementation of this, but there was some discussion in #26 related to a Downloads-based backend.
One fairly easy option for cloud storage is to use rclone mount (via Rclone_jll) to mount an S3 prefix. I've got a prototype of that kind of thing lying around separately.

Btw, on master Downloads.jl is now thread-safe. I know that was a blocker in various use-cases.

Yes that's great news! I've been following along with some of the Downloads changes but I got a little lost in the list back and forth. It seemed like a difficult fix.

It was painful. Hopefully it's actually thread-safe now.

Any new and exciting development on this front? Some of the online sources would be AWS, FigShare, Zenodo, and growing...


Disable dial turning clockwise if at max value

I was expecting to need to track the quadrant of the dial the mouse was in and make calculations from there to determine if the mouse movement indicated a clockwise or counterclockwise turn, but after an hour of research on calculating angles and ways of using the .transform() and .rotate() methods, I was able to complete this task in about 5 minutes using a single if statement and without needing to do any of that. Oops.
The implementation I stumbled upon does not feel very fine-tuned, however, so if there is enough time left later in the sprint, I may choose to create another task to refine it further.


Documentation update for dynamically loading MSAL configuration of MSAL Angular 2.x library using APP_INITIALIZER

To load MSAL configurations dynamically we can use APP_INITIALIZER with Factory Providers. For a working example please check following sample https://github.com/vinusorout/msal-angular-dynamic-configuration-sample

Hello @jasonnutter , this is the first time I have created a PR here, and I couldn't figure out what is this Beachball Check and why it is failing. Could you please  let me know what to do to make this work!

@vinusorout Navigating to the root of the repo, run npm install if you haven't already, then run npm run beachball:change, follow the prompts, and then push your updated branch to github.

Thanks for the quick response @jasonnutter , but after running this command I am getting following output:
WARN: There are untracked changes in your repository:

lib/msal-angular/package-lock.json
lib/msal-browser/package-lock.json
lib/msal-common/package-lock.json
lib/msal-core/package-lock.json
lib/msal-node/package-lock.json
lib/msal-react/package-lock.json
Changes in these files will not trigger a prompt for change descriptions
Checking for changes against "origin/dev"
fetching latest from remotes "origin/dev"
No change files are needed

I am running this in, forked branch https://github.com/vinusorout/microsoft-authentication-library-for-js

Finally fixed the beachball check

@vinusorout I am unable to reproduce your instructions in our angular11-sample-app. Could you please ensure that no instructions are missing?

Hello @jo-arroyo I used these same files in a sample and working as expected, available here https://github.com/vinusorout/msal-angular-dynamic-configuration-sample
Could you please check this! Or let me know what exact error you are getting!

Hello @jo-arroyo , just fixed the configuration.json file path(assets/configuration.json) in app.module.ts file, it should work now, please check!

Hello @jo-arroyo have you got round to check this!

Hello @jo-arroyo thanks for the suggestions , please let me know if anything left from my side for this PR!

Hello @jasonnutter , could you please review these changes! so that we can close this asap.

Thanks @jasonnutter , I have resolved the conflicts.


TST: fix stats.iqr test to not emit warnings, and fix line lengths.

@ev-br this may be worth backporting to 0.18.x

Thanks Ralf, it's in.

Backported in https://github.com/scipy/scipy/pull/6355.


Created the beginnings of the nue tool

I was able to remove the dependency of watchexec.  Currently, NimForUE.nimble has the bin variable commented out, but once I do some more work on nue the user will be able to nimble install nimforue, which will build nue and pull the dependencies (fusion) properly.
The idea behind nue is once the user installs NimForUE, they'll have a command line tool to initialize an Unreal Project and do all the building and watching with it without having to clone the repo to run nimble tasks.

Squashing and merging.


Fix outbound date format

Outbound Date: header and Received headers were in the wrong format triggering INVALID_DATE in SpamAssassin.

Ok - updated.   Might as well keep the ip_to_long etc. functions in as I'll be submitting the dnsbl plugin soon anyway.


potential bug in update_validator_registry?

Since get_entry_exit_effect_epoch's return has a +1, in update_validator_registry
Should:
if validator.activation_epoch > get_entry_exit_effect_epoch(current_epoch)
validator.exit_epoch > get_entry_exit_effect_epoch(current_epoch)
be:
if validator.activation_epoch >= get_entry_exit_effect_epoch(current_epoch)
validator.exit_epoch >= get_entry_exit_effect_epoch(current_epoch)
??

No, it should be >. We want it to no-op if someone tries to exit or activate twice in an epoch.
For example:

Validator A (not previously exited) submits an Exit. It is included near the start of the epoch.
Validator A's exit_epoch is set to entry_exit_epoch(current_epoch)
Validator A submits another exit in the same epoch. It is attempted to be included in the block.
Two possibilities:

If the condition is: "Verify that validator.exit_epoch > get_entry_exit_effect_epoch(get_current_epoch(state))", then we see that the exit_epoch is not greater than the entry exit epoch of the current epoch and it is a no-op.
If the condition is: "Verify that validator.exit_epoch >= get_entry_exit_effect_epoch(get_current_epoch(state))", then we see that the exit_epoch is greater than or equal (equal in this case) and this condition does not guard against the op.

got it, thx for the explanations!


[Android] Unexpected End of Stream Error when retrying after Connection closed by server

The issue:
When the connection is closed to the server, okhttp will try to reconnect and retry the request. This is expected because React Native Blob Util sets retryOnConnectionFailure to true on okhttp client.  To re-create the request, okhttp client will call ReactNativeBlobUtilBody. writeTo(@NonNull BufferedSink sink) at which point ReactNativeBlobUtilBody will use the private variable requestStream to write into the BufferedSink. The problem is that the requestStream has already been used and closed when okhttp was making the first request. So this results in the requestStream not writing anything into the BufferedSink and okhttp will throw an error because the content length does not match the length of what was written into the BufferdSink (ie 0).
This started happening in our app when okhttp upgraded versions when we upgraded react-native. We would intermittently see "Unexpected End of Stream"
We have created an internal repro using an express mock server:
app.get('/connectionWillBeDestroyed', (req, res) => {
  res.send('Whats up?', { root: '.' });
  res.socket.destroy();
});

And then requesting it twice via React-Native-Blob-Util:
import RNFetchBlob from 'react-native-blob-util';
...
const headers = {
  Connection: 'keep-alive',
};

await RNFetchBlob.config({
  timeout: 3000,
}).fetch('POST', mockServerUrl + 'connectionWillBeDestroyed', headers, 'request body');

// wait to allow the mock server to close the connection. Anything less than 5 seconds did not suffice
await wait(5000);

// we expect this to fail internally within okhttp, at which point, okhttp will retry by recreating a request, which will fail
await RNFetchBlob.config({
  timeout: 3000,
}).fetch('POST', mockServerUrl + 'connectionWillBeDestroyed', headers, 'request body');

I have a patch for my app that fixes this issue for us. I will submit a PR.

Thank you very much for the detailed explanation and fix!

@enagorny Sorry I wasn't able to do anything due to private reasons the last two weeks. I will make a new release this week.


Can't change remote jupyter notebook kernel

Hi,
-pointed here from stackoverflow-
With the new version i am able to connect to a remote jupyter session and that works great, but there does not appear to be a way to change the remote kernel. This feature would be very helpful.
Thanks,
Mike

This is problematic--vscode is defaulting to a kernel that isn't even python for me.

Is this something similar to what the Hydrogen package provides in Atom?
e.g. after configuring the remote Jupyter Server it gives the following options when selecting the "Connecting to Remote Kernel":

It would be great to have the ability spacify the kernel e.g. in conda environments.

If you support this feature, I would give up Atom and use vscode!

Hydrogen also has an option to "remember" multiple jupyter servers the user might want to connect to. The first choice is then "which remote" and then what kernel. Very handy

+1 For this feature

Bumping for this feature. Having the ability to reconnect to and/or select which remote jupyter server and which kernal to use would be very useful to me and my team.

This would be great to have. BTW is this possible locally?

Another +1 for this feature!

+1 for this feature

+1 for this feature

+1 for this feature! I am loading a custom kernel installed by django-extensions to have the ORM initialized inside of the notebook.  This would be grand!

+1 for this feature.  I run multiple kernels with different packages installed.

Thanks everyone for adding your interest. However please could you vote on the main comment (👍 ). This way its easier for us to  check the reactions (interest) on this issue, else we'd have to scroll down to look for +1 or the like.

Remote doesn't seem to show up in our new (about to release) UI. Investigating

Validated


relap5 code interface operator node

Issue Description
Feature request
A user requested to add the possibility to read the content of some cards from the original input file of RELAP5 and then use those values in an expression to modify the content of such cards.
Do you have a suggested fix for the development team?
Add an option in RELAP5 code interface.
Please attach the input file(s) that generate this error.  The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Approved to close via #915.


Component: Date picker (getting rid of material-ui)

Description
App-frontend-react currently uses the DatePicker from material-ui/pickers, this package is no longer maintained and should be replaced. The best option in my opinion is not upgrading to a newer version of material-ui, but rather getting rid of material-ui entirely and having all such components in the design system.
Additional Information
NAV has started building their own Datepicker in their design system, this could be a source of inspiration:

https://aksel.nav.no/designsystem/komponenter/datepicker
https://aksel.nav.no/designsystem/komponenter/monthpicker

Having the ability to select time is also an interesting concept, as it is likely a fairly common need. This could either be a part of the same component or a separate component.

Modern browsers have built-in date/time pickers that can be accessed by <input type="date"/> or <input type="time"/>. We will probably use that when implementing a date picker in our design system. Meanwhile, you can apply the type attribute to TextField.


Clarity icons don't move correctly in spear/shield fight

Would probably be better to just pass MemoryManager.render a drawX/drawY from the character every time, rather than repeating that state in MemoryManager where we can forget to update it

Resolved by #117


fix(vscode): display annotations only in files under the path of unocss.root

After v0.40.0, configuring unocss.root does not work, decorations and tooltips are displayed in all files.

/cc @QiroNT

I guess the real issue in here
https://github.com/unocss/unocss/blob/main/packages/vscode/src/index.ts#L22toL28
the registerAutoComplete and registerAnnotations function always be called , even though the project does not contain any unocss config files, and the ContextLoader would create a default context.

Hi, @TrickyPi  thanks for your comment. I updated a commit. The extension shouldn't be activated when the config file is not found under unocss.root, right?
This is my first PR on unocss and my changes may be ill-considered. Hope someone more experienced can fix it if I'm in the wrong direction.

The extension shouldn't be activated when the config file is not found under unocss.root, right?

Yes


WIP Update namespace scheduler to enqueue resources on scheduling change

Previously the scheduler enqueued resources contained by a namespace when the namespace was reconciled for any reason. This change updates the scheduler to keep track of namespace scheduling decisions and only enqueue contained resources if the scheduling is changed by the controller.

Rebased and updated.

@imjasonh do you have time to 👀 ?


Configurable filesystem overhead

MTV 2.5.3
Resolves https://issues.redhat.com/browse/MTV-810 by adding a note describing how filesystem overhead can be configured for a migration that allocates persistent volumes without CDI and whose  storageclass is filesystem.
Added scope (after comment by Arik and Liran, and clarifications with Arik): Added a new section, "Configuring the MTV Operator" to Chapter 3, which is now called "Installing and configuring the MTV Operator"
Previews:

https://file.emea.redhat.com/rhoch/overhead_config/html-single/#about-storage_mtv [third note]
https://file.emea.redhat.com/rhoch/overhead_config/html-single/#installing-the-operator [new introduction to Chapter 3]
https://file.emea.redhat.com/rhoch/overhead_config/html-single/#configuring-mtv-operator_mtv [new section]

@liranr23 @ahadas I have made the changes Arik and I discussed. Please review this PR again.

@ahadas I made the change you suggested. Please review this PR again.

@qiyuann Please review. Thanks.


chore: remove forgot password screen; reset password module to MVVM

Fixes #1100
Checklist:

[x] I have checked for PMD and check-style issues
[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream development branch.

Changes:

Removes the forgot password screen
Removes package auth.fogot.request
Renames package auth.forgot.submit to auth.reset
Improves Reset Password screen's layout
Converts auth.reset module to MVVM

GIF for the change:

@mishuvs Please attach a GIF of the current procedure of password reset.

Yes, wait :sweat_smile: .. don't generally get a review that fast
@srv-twry Please review again.

Made the change @srv-twry @Masquerade0097 @sridharjajoo @iamareebjamal
Please review.


feat: add support to vaults

https://docs.konghq.com/gateway/3.0.x/kong-enterprise/secrets-management/advanced-usage/

Codecov Report
Base: 53.02% // Head: 53.01% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (40c4f53) compared to base (d7a89dc).
Patch coverage: 52.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   53.02%   53.01%   -0.02%
==========================================
  Files          45       46       +1
  Lines        4043     4142      +99
==========================================
+ Hits         2144     2196      +52
- Misses       1435     1469      +34
- Partials      464      477      +13

Flag
Coverage Δ

2.0.5
39.64% <1.01%> (-0.95%)
:arrow_down:

2.1.4
39.49% <1.01%> (-0.95%)
:arrow_down:

2.2.2
?

2.3.3
39.49% <1.01%> (-0.95%)
:arrow_down:

2.4.0
39.49% <1.01%> (-0.95%)
:arrow_down:

2.5.1
39.49% <1.01%> (-0.95%)
:arrow_down:

2.6.0
39.49% <1.01%> (-0.95%)
:arrow_down:

2.7.0
39.49% <1.01%> (-0.95%)
:arrow_down:

2.8.0
39.49% <1.01%> (-0.95%)
:arrow_down:

3.0.0
38.82% <1.01%> (-0.93%)
:arrow_down:

community
39.64% <1.01%> (-0.95%)
:arrow_down:

enterprise
49.92% <52.52%> (+0.06%)
:arrow_up:

enterprise-<IP_ADDRESS>
?

enterprise-<IP_ADDRESS>
48.69% <1.01%> (-1.17%)
:arrow_down:

enterprise-<IP_ADDRESS>
?

enterprise-<IP_ADDRESS>
48.69% <1.01%> (-1.17%)
:arrow_down:

enterprise-<IP_ADDRESS>
?

enterprise-<IP_ADDRESS>
?

enterprise-<IP_ADDRESS>
48.69% <1.01%> (-1.17%)
:arrow_down:

enterprise-<IP_ADDRESS>
?

enterprise-<IP_ADDRESS>
49.25% <52.52%> (+0.08%)
:arrow_up:

integration
53.01% <52.52%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

kong/types.go
36.00% <0.00%> (-2.03%)
:arrow_down:

kong/vault_service.go
56.66% <56.66%> (ø)

kong/client.go
60.38% <100.00%> (+0.19%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


使用Typescript 4.1.5, react ts template项目 , store.ts中的"Se"有类型报错

复现方式:

npx create-react-app demo-app --template concent-ts
使用VS Code打开, 稍等片刻就能见到 ./src/types/store.ts文件中, 所有的Se都是报类型错误

影响:
项目编译失败, 无法运行

Here is the English version:
Title: When using TypeScript 4.1.5, there are type errors in the react template project. Mainly happens in the store.ts file.
How to reproduce:

npx create-react-app demo-app --template concent-ts
Open it with VS Code, just wait for a moment until the editor indexed all the codes, then you can see the type error in this folder: ./src/types/store.ts. All the "Se" type has this warning.

Impact:
Run project failed.

你好，问题已经修复了，欢迎重新安装再体验，但貌似cra有更新延迟，你可以克隆模板原项目直接运行
git clone git@github.com:concentjs/cra-project-concent-ts.git

Thanks for you fast action! I just test, it works perfectly.

Thanks for you fast action! I just test, it works perfectly.

Cool, just notice useSetup in App.tsx, it gives you a totally new way to organize your logic code(including event， ref computed, lifecycle etc features)😀


Tesseract 5

Hi,
Any plans on supporting Tesseract 5 ?
Thanks!

Not at the moment, but feel free to submit a pr with your changes.


return current storage.Storage

What is the purpose of this change?

What is the purpose of this change?

when I want to read cookies which had stored in storage.Storage, The only way is
c.store.Cookies(&url.URL{})
but as you see, the store cannot be read by others, so I add this method.

@jony4 you have to pass the storage to the collector when you initialize it. At this point you have access to the storage, so you can use it later without getting it from the collector. I don't find this addition very useful at first, but I'm keeping it open, if others need it too, I'm going to merge it.


How do I use an existing Rust struct as a message in a gRPC service?

Feature Request
Crates
Probably a tonic_build feature, possibly prost. This may already exist.
Motivation
I have an existing service that I'd like to expose via a gRPC interface using Tonic. The service currently has request/response structs defined as vanilla Rust structs. I know that I can get Prost to build proto equivalents for these structs like so:
use prost::{self, Message};

#[derive(Message)]
pub struct RequestOne {
  #[prost(uint32, tag = "1")]
  pub f1: u32,
  ...
}

#[derive(Message)]
pub struct ResponseOne {
  #[prost(uint32, tag = "1")]
  pub f1: u32,
  ...
}

How do I use the resulting protos from within a gRPC service definition? For example, I have a proto file that looks like this:
syntax = "proto3";
package myservice;

service MyService {
  rpc ReqOne(RequestOne) returns (ResponseOne);
}

But when I try to build it in my build.rs:
fn main() -> Result<(), Box<dyn std::error::Error>> {
  tonic_build::compile_protos("proto/myservice.proto")?;
  Ok(())
}

I get the error
$ cargo build
error: failed to run custom build command for `foo v0.1.0 (/Users/greg/foo)`

Caused by:
  process didn't exit successfully: `/Users/greg/foo/target/debug/build/foo-7b891a7d35c99239/build-script-build` (exit code: 1)
  --- stderr
  Error: Custom { kind: Other, error: "protoc failed: myservice.proto:5:19: \"RequestOne\" is not defined.\nmyservice.proto:5:41: \"ResponseOne\" is not defined.\n" }

Which makes sense, since myservice.proto doesn't include or import those proto defs.
How do I import the derived proto definitions? My mental model is that build.rs is executed before the project code is compiled, which means that the derived Message implementations for RequestOne and ResponseOne don't exist yet.
Proposal
I don't actually have a proposal here; I'm just wondering if this is already supported and if so how to make it work.
Thanks!

And I asked in the prost Discord channel and someone wrote back that its probably not possible. Perhaps you could try opening an issue in the prost repo and see what they say https://github.com/danburkert/prost
I think I'll close this for now as this is more of a prost issue than a tonic issue.

@GregOwen Where you able to find a workaround? I'm having the same dilemma
I'm also not sure I'm buying the fact that this is a prost issue. It seems that all that is needed to be done is to add the relevant use statement (e.g. use crate::RequestOne;) in the .rs file that is generated from the .proto file.


Precision when saving data to ASCII

Question: How to handle precision by default in the save function when saving data to ASCII?
Does it need to be conservative and safe for all types (my opinion)?
Does it need to handle safely mixing types, e.g., for a curve x as int and y as float (also my opinion)?
Some examples:

'%.7g' is safe for float32 but not float64 and int

By default numpy.savetxt saves with '%.18e'. This is safe for float32 and float64, but not for int
>>> numpy.savetxt('test.txt',<PHONE_NUMBER>0000001,))
>>> numpy.loadtxt('test.txt')
array(1e+16)

If we want to be conservative we could try to detect the data type for each column when the user doesn't specify which format he wants. My suggestion would be:

%d for integers
%.7g for float32
%.18e for float64

If the user specifies a format we should assume he knows what he is doing and not try to check types.
We can do something similar to numpy.savetxt (http://docs.scipy.org/doc/numpy-1.10.0/reference/generated/numpy.savetxt.html):

fmt parameter:

single format (%10.5f), a sequence of formats, or a multi-format string, e.g. ‘Iteration %d – %10.5f’, in which case delimiter is ignored.

Except we could set fmt=None as default and assign our default format depending on the type.
Should we handle complex values ?
But again, I would not have any moral problem if we just assumed that a vast majority users who don't bother defining a custom format would be happy with %.7g for all values, because it looks nicer and uses less disk space. We would just need to specify in the documentation that the default behavior is not safe for extremely large integers and very precise floats.

Yes, that's why I asked the question.
Do we want a conservative default behavior or a simple one?

Simple one. If it turns out to be not enough we change. A bit of Extreme Programming should make no harm. If we start from "Cogito ergo sum" we are not going to get very far.


Is it possible to automatically link to pages?

Firstly, thanks for a wonderful theme. Secondly, is there a way to automatically show links to pages (as opposed to posts) in either the top or side navigation? It would be nice not to have to update the navigation whenever I add a new page.
(I have read the docs, but they are so long I might have missed this...)

There are, but the theme doesn't ship with them as they have a performance hit on build times.
I believe there are mentions of doing the same with the default theme Minima if you want to search through their issues for ideas on how to do it.

Thanks for the answer, indeed I was aware of it via Minima. I bit the bullet and coded the navigation manually, it's best to deliver something after all. :)


python3.6: 3.6.2 -> 3.6.3

Motivation for this change
Python 3.6.3 is available.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks. I pushed f906d6d18e87f4e2ee8a47d4f6040c77fd6c7f1e to staging and df8e85f22f2bd1550e1ba5afc38935bf25d81cda to 17.09.


IE Scrollbar "Disabled"

Any clue what could cause this? Notice the scrollbar seems to almost be disabled. There are approx 50 items in that dropdown, and for reference the scroll works just fine in Chrome/FF.

May be caused by `overflow-y: auto;'
https://github.com/lordfriend/nya-bootstrap-select/blob/master/src/nya-bs-select.js#L929-L932
Could you tell me Which IE version has this bug?

I found the issue. Guess I just needed to sleep on it. Someone used disabled instead of ng-disabled, which caused the IE scrollbar to disabled because IE processes the disabled tag a little differently. Thanks for your time.


[modify] opendata dataset : aggregate_areas order

Coverage increased (+5.4%) to 84.892% when pulling 7bb84201c5568d84b98316906e536e65feb46ee9 on itowtips:fix-opendata into a61df333a78c3b14b43ac83f51ff5d9eca5e0326 on shirasagi:master.


One more simplification for Domain to do

Praveen and I were talking briefly about slice sampling,
and this nugget that Rob and I wanted to simplify came up:

restart: with(Hakaru): with(NewSLO):
y, kb := KB:-genType(y, HReal(Bound(>,0), Bound(<,densityGaussian(0))), KB:-empty):

m := Bind(Gaussian(0,1),x,
piecewise(And(0<y,y<densityGaussian(x)),
Weight(densityUniform(y),
Ret(x)),
Msum())):

fromLO(improve(toLO(m),_ctx=kb),_ctx=kb);
Weight(2 * sqrt(-ln(2)-ln(Pi)-2ln(y)),
Uniform(-sqrt(-ln(2)-ln(Pi)-2ln(y)),
sqrt(-ln(2)-ln(Pi)-2*ln(y))))

It's great that simplification produces such a nice term, but it's
annoying to have to provide the bounds of y in the input kb.  Shouldn't
the new domain geometry facility figure out those bounds?  I.e., I want
non-urgently for this to happen:

restart: with(Hakaru): with(NewSLO):

y, kb := KB:-genType(y, HReal(), KB:-empty):

m := Bind(Gaussian(0,1),x,
piecewise(And(0<y,y<densityGaussian(x)),
Weight(densityUniform(y),
Ret(x)),
Msum())):

fromLO(improve(toLO(m),_ctx=kb),_ctx=kb);

piecewise(And(0<y, y<densityGaussian(0)),
Weight(2 * sqrt(-ln(2)-ln(Pi)-2ln(y)),
Uniform(-sqrt(-ln(2)-ln(Pi)-2ln(y)),
sqrt(-ln(2)-ln(Pi)-2*ln(y)))),
Msum())

This seemed like a particularly interesting problem; and something we should definitely be able to do! So I was compelled to try to fix it.
Two things needed to change for this simplification to occur:

Domain:-Apply will now place constraints (that is, piecewise/Partition) outside of a subterm if that constraint is free of variables enclosed in that subterm. This was a fairly straightforward change, but could potentially lead to the simplification of lots of new things! Other parts of reduce will occasionally do something like this as a byproduct of other simplification, but this is something that should fire much more reliable now. (026a821ae6)

The much less trivial change is that the condition y<densityGaussian(x) must become And(y<densityGaussian(x),y<densityGaussian(0)). This is only necessary because solve doesn't get the solution to the former constraint without the latter constraint in the context. I've implemented this with minimize, which could potentially be very costly (and simultaneously do nothing, or even make the condition much worse); so this new simplification is applied very conservatively. (5c64091e3, 0c46ba3c,  1c97d48d0)

The new test case added by 09084c3aff now passes; but I leave the issue open because I feel like the 2nd point needs a much better solution.

Yes, this is rather a non-trivial issue.
@ccshan I completely understand why this is desirable, but did you think this would be easy/hard?

I only vaguely thought that the new domain geometry facility would make this "less trivial change" easier, because after all the entailment from 0<y<densityGaussian(x) to 0<y<densityGaussian(0) is a matter of domain geometry. In particular, note that the relationship between ln(y) and x is a quadratic inequality. But I am ok with this change being on the back burner. It would make a nice demo.

I don't see how this is "domain geometry"?  If it were, then minimize/maximize would not be needed.  If you can explain your reasoning, then maybe we can "get" this particular case much more easily (i.e. we might have missed a way to "reason out" this case).
It is worth noting that although it is easy for humans to see ln(y) as a (fresh) variable, this is significantly harder to automate reliably.

In the old example from disintegration, domain geometry is reasoning from 0<x<1, 0<y<1, t=x-y to discover which values of t are possible (i.e., yield a non-empty set of x,y,t triples). Here we'd like to reason from -infinity<x<infinity, 0<y<exp(-x^2/2)/sqrt(2*Pi) to discover which values of y are possible (i.e., yield a non-empty set of x,y pairs).

And here we can do it because exp is monotone increasing (or, if you prefer, exp(-z) is monotone decreasing).  That is very special.  And tricky, because exp(-x^2) is not so well-behaved.  In other words, back to 'discovering' that ln(y) is a better "coordinate" than y.

I hope I've managed to answer your question 'how this is "domain geometry"?'!
As for using ln(y) as coordinate, I tried doing it manually as below, and it didn't work just now:
> restart: with(Hakaru): with(NewSLO):
> ly, kb := KB:-genType(ly, HReal(), KB:-empty);
> m := Bind(Gaussian(0,1),x,
       piecewise(And(exp(ly)<density[Gaussian](0,1)(x)),
                 Weight(density[Uniform](0,density[Gaussian](0,1)(x))(exp(ly)),
                        Ret(x)),
                 Msum())):
> fromLO(improve(toLO(m),_ctx=kb),_ctx=kb);
Bind(Lebesgue(-infinity, infinity), x, PARTITION(...))

(The Weight is missing a Jacobian factor, but it doesn't really matter.)

the entailment from 0<y<densityGaussian(x) to 0<y<densityGaussian(0) is a matter of domain geometry

Yes! But it just isn't the type of domain geometry we have been solving up until now.
In particular, we have been 'solving' things of the form A = B, where A,B are domains; and by 'solving', I mean replacing A with B (or vice versa) based on which is "simpler" or "better". The most basic explanation of how that is done is to manipulate A into a form which a Maple solver (e.g. solve, SemiAlgebraic, previously LinearMultivariateSystem) understands, call that solver to produce B (which we simply trust will be "simpler"), and just replace A with B.
This particular case has to be solved with a more complicated technique. Here we have A' => A, where A,A' are domains, and A is the input domain. Of course, we cannot simply replace A with A', or v.v.! In the previous case, the reasoning we use to arrive to the answer is obvious; here we need more complicated reasoning: A becomes A' and A; and then A is solved in a context containing A' (which is solved and which is placed in the context could be decided by the variables occurring in each; right now, since {max/min}imize are used to determine A', we know A' must be free of the domain variables, so it is always in the context; this is just an implementation detail) to produce A' and B, where (A = B) assuming A'.
We want to eventually see the expression B(e) (where e is the body of the expression from which the domain was extracted; and B(.) is Domain:-Apply(B)) because that expression gets recognized as a "nice" Hakaru term. By this point, the information of B will have been moved into the bounds of a binder like Int, because that is the form which gets recognized by fromLO. This simplification was already being done, but is also an essential part of seeing the right output in this case (indeed, it is essentially to basically every domain improvement of which I can conceive).
As Ken's last example shows, this is currently quite fragile - the new simplification only happens when a relation is a bound on a variable (one side of the relation is precisely a name), and exp(ly)<density[Gaussian](0,1)(x)) is not a bound on a variable. This relation might (should?) be turned into a bound by KB:-try_improve_exp - I'm not certain this isn't just a very mechanical issue (I only have one test case for this new logic, and one test case does not define a semantics).
To summarize, the call to {min/max}imize is needed only to discover that A' => A given the domain A; everything else is genuine "domain geometry" manipulations; it is just that these new manipulations are almost entirely disjoint, i.e. using different laws of domain geometry (which are really just laws of propositional logic), from the old manipulations which were being done.

As for using ln(y) as coordinate, I tried doing it manually as below, and it didn't work just now:

Fixed by 4753a28, and added as a test case by 4e965064.
Please reopen if there are more cases like these which don't simplify.

I'm not sure why, but the tests "clamp condition to move it out of integral" and "clamp condition to move it out of integral (ln coordinate)" in NewSLOTests.mpl fail nowdays...

Thanks for finding this. Should be fixed by a063fc58356bd2b11619974f36aa729ec5daf030.


Add Ahmed Hassanin as approver

Ahmed was now a reviewer in this working group for more than 9 month and contributed and review a lot of PRs. Further we joins the WG meetings regularly and try to catch up with all changes in the community.
List of own PRs: https://github.com/search?q=org%3Acloudfoundry+a-hassanin&type=pullrequests

@rkoster @beyhan can you please check?


How to change language by set user account?

Dear all
As my understanding, SetEndpoint directive is for country setting, and SettingsUpdated eventis for changing language.
Do I have to send SettingsUpdated event for changing language? Is it the only way to change language?
Attached file is my test case which come from amazon. I saw that it only need change the account country setting , that can send a SetEndpoint directive to my device. But no way let me know the language information, So I don't know how to send SettingsUpdated event based by SetEndpoint .
Something wrong with my understanding?

Hi @howardguo, are you writing your own application using the SDK? You can refer to Settings.cpp to see how language may be changed.

Hi, master
We don't use the SDK, :(. But I also read the Settings.cpp source code. I understand it is still need to send SettingsUpdated event actively to change the language.
My question is that's the only way(send SettingsUpdated event) to change the language?:).
If I don't send SettingsUpdated , have anther interface to change language(ex: modify account setting or others)?

The SettingsUpdated event is sent only after the language is changed. To change your language settings on your device you should be able to log into alexa.amazon.com, click settings on the left and find your device.

Hi @howardguo , in 3P devies, you cannot change language from account setting. If you have a echo or echo dot, you can change the language from the account setting. In few months, we will have the directive to update settings, at that time, you can change the language from the account.

OK，Thanks all! 👍


Added README stuff

Maybe will upadting alot, i will advise when finish

Add it this for more faster and for new users of GitHub

@twizmwazin can you check this please :)?

I'm closing this, open a new pr when you have this all in 1 commit.


Support roles or permissions

I've just come to use this package and look like it only support filter for when(), this way it is needed to create many filters as permissions and roles for routes. I think it is better to support something like this:
Permissions
Trusty::when('users*', ['permissions' => ['manage_users']]);
Roles
Trusty::when('users*', ['roles' => ['administrator', 'manager']]);
Filter
Trusty::when('users*', ['filter' => ['manage_users']]);
or
Trusty::when('users*', 'manage_users');// Default
I was used Entrust and it can do like this:
Entrust::routeNeedsPermission('users*', 'manage_users')
Entrust::routeNeedsRole('users*', 'admin')

Thank for your suggestion. Maybe I would add this feature in the next release.


Bug/user status update

Update user's online status on login and logout
Fixed #13

Still the same bug exists. The status is not getting updated when the user is at the home screen, without any chat opened

So you want to show user status as offline when user is at home screen without a chat open? That's kinda weird tho.
The vercal preview here is not showing my changes properly because of some cors issue.
You have provided https://h-chat.vercel.app as the origin in the cors options but it is now getting https://h-chat-git-fork-ozair-dev-bug-user-status-update-thahobbyist.vercel.app as the origin, so It won't show my changes unless you push the changes to production.
Or simply, you should run my code locally, hopefully you will see everythinhg working correctly.

I want the status to be online when user is even in the home page without
chat open, but currently in your pr, it is the opposite
On Mon, 31 Oct, 2022, 11:33 am Ozair, @.***> wrote:

So you want to show user status as offline when user is at home screen
without a chat open? That's kinda weird tho.
The vercal preview here is not showing my changes properly because of some
cors issue.
You have provided https://h-chat.vercel.app as the origin in the cors
options but it is now getting
https://h-chat-git-fork-ozair-dev-bug-user-status-update-thahobbyist.vercel.app
as the origin, so It won't show my changes unless you push the changes to
production.
Or simply, you should run my code locally, hopefully you will see
everythinhg working correctly.
—
Reply to this email directly, view it on GitHub
https://github.com/ThaHobbyist/HChat/pull/16#issuecomment-1296580986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANN5LELKQ6T45JXKMOEF7P3WF5OM7ANCNFSM6AAAAAARSDUHGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Did you run changes on your machine?

I deployed it on vercel and ran it
On Mon, 31 Oct, 2022, 11:53 am Ozair, @.***> wrote:

Did you run changes on your machine?
—
Reply to this email directly, view it on GitHub
https://github.com/ThaHobbyist/HChat/pull/16#issuecomment-1296594858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANN5LEPYHNKGRD34MMFM3A3WF5QXZANCNFSM6AAAAAARSDUHGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Means you didn't read me comment completely


Add @ignoreNativeValidation for opting out of native validation

This should fix the other issue we identified when integration headless-form and toucan-core.

Thanks for the review, applied your suggestions!


Destructure state and props

https://github.com/d-ivashchuk/memory-helper/blob/0ea43d5c6eb9e4175ceabf94ad60727c184a231f/src/Entry/entry.jsx#L44

Notice with what frequency you use this pattern: this.state.smth, this.props.smth in your components? It could be overwhelming, as we generally understand from where this variable comes from. That's where destructuring comes to the rescue. You could hame smth like :
const {smth1,smth2,smth3} = this.state


[got] Handling of reconstructed (unattested) spellings

Historic languages like Gothic (got) contain some pronunciations derived from the reconstructed spellings. This reside in reconstruction: namespace  which ends up in the corresponding spelling prefixes, e.g. reconstruction:gothic/𐌷𐌻𐌰𐌸𐌰𐌽.
Some strategy needs to be worked out on how to handle such cases, perhaps by introducing a flag to weed out or keep the reconstructed entries.

Agreed. Do you have time to look into this or should we?

I can't look into this this month unfortunately.

What I meant above, if you guys have cycles to look into this that would be great!