Allocating a FlutterViewController after app startup is slow

On iPhone6 more than 300ms cost
On iPhoneX more than 80ms cost
I add Flutter to my existing app, it is a bad user experience when open Flutter ViewController first time
Is it possible to improve performance here ？

#22363, #22133 look related

flutter doctor -v
[✓] Flutter (Channel master, v0.10.1-pre.40, on Mac OS X 10.13.6 17G65, locale zh-Hans-CN)
• Flutter version 0.10.1-pre.40 at /Users/zjq/Documents/flutter_biz/flutter
• Framework revision 8e2ca93f52 (3 days ago), 2018-10-12 21:07:55 -0700
• Engine revision 50c2e69daf
• Dart version 2.1.0-dev.7.0.flutter-b99bcfd309

Would you mind adding the full flutter doctor -v output?

[✓] Flutter (Channel master, v0.10.1-pre.49, on Mac OS X 10.13.6 17G65, locale
zh-Hans-CN)
• Flutter version 0.10.1-pre.49
• Framework revision 707eaf5edf (30 hours ago), 2018-10-15 21:30:40 -0700
• Engine revision 08272ee6aa
• Dart version 2.1.0-dev.7.1.flutter-b99bcfd309
[✗] Android toolchain - develop for Android devices
✗ Unable to locate Android SDK.
Install Android Studio from:
https://developer.android.com/studio/index.html
On first launch it will assist you in installing the Android SDK
components.
(or visit https://flutter.io/setup/#android-setup for detailed
instructions).
If Android SDK has been installed to a custom location, set $ANDROID_HOME
to that location.
You may also want to add it to your PATH environment variable.
[!] iOS toolchain - develop for iOS devices (Xcode 10.0)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.0, Build version 10A255
• ios-deploy 2.0.0
! CocoaPods out of date (1.5.0 is recommended).
CocoaPods is used to retrieve the iOS platform side's plugin code that
responds to your plugin usage on the Dart side.
Without resolving iOS dependencies with CocoaPods, plugins will not work
on iOS.
For more info, see https://flutter.io/platform-plugins
To upgrade:
brew upgrade cocoapods
pod setup
[!] Android Studio (not installed)
• Android Studio not found; download from
https://developer.android.com/studio/index.html
(or visit https://flutter.io/setup/#android-setup for detailed
instructions).
[✓] VS Code (version 1.28.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 2.19.0

Pre-warm your engine by allocating a FlutterEngine (e.g. in your AppDelegate) first and using the FlutterViewController initWithEngine initializer.  It should speed things up.

Can FlutterEngine be allocate at a thread (not platform thread)  @dnfield
Thanks

It's not a configuration we really test for.  I think it's possible but I'm not sure what might go wrong.  Basically the engine will assume whatever thread it's running on is the platform thread.  I suppose you could try spinning up a thread and starting the engine on that.

I Found there are three expensive operation:
1、IOSGLContext  allocate first time ( for iOS)
2、Dart_CreateIsolate call first time (Low-end machine）
3、Engine allocate ( Android) (almost cost 70% start up time)
```
engine = std::make_unique(*shell,                        //
shell->GetDartVM(),            //
std::move(isolate_snapshot),   //
std::move(shared_snapshot),    //
task_runners,                  //
shell->GetSettings(),          //
std::move(animator),           //
std::move(snapshot_delegate),  //
std::move(resource_context),   //
std::move(unref_queue)         //

**Any ideal  why Engine allocate so expensive on Android**

/cc @jason-simmons @chinmaygarde @matt-carroll

Pre-warm your engine by allocating a FlutterEngine (e.g. in your AppDelegate) first and using the FlutterViewController initWithEngine initializer. It should speed things up.

I setup an instance of Engine in AppDelegate:
var flutterEngine: FlutterEngine!
    func setupFlutter() {
        if nil == self.flutterEngine {
            flutterEngine = FlutterEngine(name: "flutter.safe2save", project: nil)
            flutterEngine.run(withEntrypoint: "/")
        }
    }

push view controller here:
if let appDelegate = UIApplication.shared.delegate as? AppDelegate {
            let engine = appDelegate.flutterEngine
            let viewCon = FlutterViewController.init(engine: engine, nibName: nil, bundle: nil)!
            viewCon.setInitialRoute("/register")
            let _ = viewCon.view
            self.navigationController?.pushViewController(viewCon, animated: true)
        }

But it shows blank black screen

@xster I wonder with the new Add to App work, is this going to be better?

There has been some work to improve performance: https://github.com/flutter/flutter/issues/32945#issuecomment-513387195
If you're still seeing this, can you see if it's better on the current stable version of Flitter?


Projection classes generate invalid constructors

The projection classes in my project generated a class using an extra argument that the parent class does not need
public class Shows_FooProjection extends BaseSubProjectionNode<ShowsProjectionRoot, ShowsProjectionRoot> {
  public Shows_FooProjection(ShowsProjectionRoot parent, ShowsProjectionRoot root) {
    super(parent, root, java.util.Optional.of("Foo"));
  }
}

This is from the example repository, the optional foo is marked as an error.

can you pull the latest from the example repo and try again. a number of changes have been made, I'm not seeing this issue now.

I'm still having trouble. The generated projection class generated this import
import com.netflix.graphql.dgs.client.codegen.GraphQLQuery; it was unresolved, and I cannot import it. Is there something I'm doing wrong?

Hi @ReyhanPatria  - if you want to use the generated client could you'll need to add the following dependency to your project.
<dependency>
            <groupId>com.netflix.graphql.dgs.codegen</groupId>
            <artifactId>graphql-dgs-codegen-client-core</artifactId>
        </dependency>

I'll close this issue in a day or so if I don't hear back from you.

I don't see this problem anymore, thanks!

I am also facing the same issue, even after adding

com.netflix.graphql.dgs.codegen
graphql-dgs-codegen-client-core


How do you get rid of line breakpoint dots?

Whenever I add a breakpoint by clicking left of the line number, a breakpoint circle is also added at a seemingly random spot within the line?? like in the middle of a word or something??
Such as seen here: https://github.com/Microsoft/vscode/issues/21164
How do you make the breakpoint only show next to the line number and not anywhere in the file??

/duplicate of #83018 which asks for an option to turn these off


COMPAT: Set 'Accept-Range' header for all ranges in getObject API

If Range parameter is given to getObject API, the 'Accept-Range'
header should be set to 'bytes' regardless whether or not the
given range is valid. Prior to this change, this test
would not return an object with an AcceptRanges key-value pair.

@ironman-machine

Hello @bennettbuchanan
Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "SCALITY_S3_BRANCH": "dev/COMPAT/return_proper_object_for_invalid_range", "DEFAULT_BRANCH": "master"}
Please follow http://ci.ironmann.io/gh/scality/Integration/6136 for CI status.

@ironman-machine after rebase

Hello @bennettbuchanan
Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "SCALITY_S3_BRANCH": "dev/COMPAT/return_proper_object_for_invalid_range", "DEFAULT_BRANCH": "master"}
Please follow http://ci.ironmann.io/gh/scality/Integration/6228 for CI status.


Bug - Admin Area: Update 'Change password' tooltip

Issue
In the admin area, when trying to change a password, the tooltip is outdated.
It still says minimum 6 characters, when the new requirements are minimum 8 characters, of which at least one uppercase letter, one lowercase letter, one special character and one number.
Fix
Change the tooltip to reflect the actual password requisites.

Approved

Tested  by trying to change to an admin password that was too short, didn't contain the necessary characters and using a password confirmation that didn't match. All three errors were picked up and the correct error message shown.

Will ask users to do UAT.

Passed UAT on staging 3/11/2020.
Tested successfully on live 6/11/2020.


Group double click bug

If there is a table, with click on row to select it, and you group it with a parameter, creating a group the size of 1, when you double click the row, it selects & unselects it.
Does not happen when the group size is 2 or more

either i could not reproduce, or i didn't understand what you are doing. i took one of my examples and set it to enable checkbox selection on the group and have group span entire row. dblclick on the group row expands the group, doesn't select. unless you click the checkbox - which does select as expected.
can you demonstrate in a plunker?

Sure, here is a plunker:
http://plnkr.co/edit/IWn5IDBa9roECqcv36Fv?p=preview
Open both groups.
Now that they are open, please double click the first row in the first group, It will select-unselect it,
Go to the second group, and double click the first row. It will just select it.
If you still don't see it, I might not explain myself very well, Ill make a short video.
Let me know

ok fixed it. it will be in the next release (not yet planned, but this looks minor, so no rush??)
the problem has nothing to do with dbl click, it's single click.
a single click should not unselect a row. you need to have rowDeselection=true to allow this.
the problem was rooted in when groupSelectsChildren=true, then the groups were appearing in the selected list - they should not.

Very minor. Does not really a concern for me. Just found a bug and thought I should report, because you guys are actively perfecting the library

cool. will be fixed in next release so.


Downsample by number of points instead of time

I'd like to downsample points by their count instead of time, e.g.
select mean(value) from series group by count(10)

to get averages of 10 consecutive points. Is something like this possible to implement?

There is no way to do this, currently. It is more of a relational database query than a time-series query, as time is not involved at all.

Actually StatusWolf for OpenTSDB does this with Largest-Triangle-Three-Buckets
http://blackops.io/blog/2014/05/time-series-graphs-and-downsampling/

My use case would be the drawing of control charts, where I'd like to average always over a fixed number of samples to get closer to normally distributed data. Throughput of the process varies a lot, so averaging over time leaves me sometimes with too few samples in a bucket. Obviously I can handle all this afterwards in my application code, but having a suitable (continuous) query would be useful.

Still interested in this.

Now that influxDB is being sold as a tool for manufacturing use cases, this should be implemented as in many areas of production and quality departments, being able to aggregate by unit produced, batch, and so is much more useful than by grouping by time. I know this can be done in a SQL database, but storing all the production data in the same DB is easier and lighter.
Example: a glass industry where quality team wants a mean value of the wall thickness windowed by every 10 bottles to monitor trends, where bottles are not being produced with a fixed rate over time.


[Haxe][CodeComplete] Added support for autocomplete with a possible values of the switch cases.

Super!

Outstanding!


[Bug]: DWM crashed while running match_spec on R

Guidelines

[X] I agree to follow this project's Contributing Guidelines.

Project Version
No response
Platform and OS Version
Windows 11 OS 22621.2861
Existing Issues
No response
What happened?
I have been using the package on R for a month or so without encountering any issues. Yesterday, when running the exact same code without changing anything on the system, R returns an error message saying that it cannot handle a vector with a size of 10GB++ (I can't remember the exact size). I wasn't sure what is wrong so I updated my R to the latest version and made sure I install the latest openSpecy package. This time, it resulted in Desktop Window Manager crashes after running for >15 min.
I'm not sure if its a problem with my laptop? I ran some Windows integrity check with these codes but everything seems fine:
sfc /scannow
Dism /Online /Cleanup-Image /ScanHealth
Dism /Online /Cleanup-Image /CheckHealth
Dism /Online /Cleanup-Image /RestoreHealth

I also tried running the codes in clean boot environment but the issue did not resolve.
Steps to reproduce
These are the codes I used to run the matching:
library(OpenSpecy)
#get_lib(type="derivative")
lib <- load_lib(type="derivative")

spec.dir <- list.files(path="C:\\Users\\User\\spectra\\20231229",pattern = "*.JDX",recursive=T,full.names = T)

spec.list <- lapply(spec.dir,read_any)
names(spec.list) <- sub("\\.JDX$", "", basename(spec.dir))
bg<- spec.list[grep("bkg1$", names(spec.list), value = TRUE)]
spec.list <- spec.list[grep("bkg1$", names(spec.list), value = FALSE,invert=T)]

######### spectra preprocessing #########
processed.spec <- list()
for (i in 1:length(spec.list)){
  trans <- spec.list[[i]] |>
    adj_intens(type = "transmission")
  processed1 <- process_spec(trans,
                             active = TRUE,
                             conform_spec = TRUE,
                             conform_spec_args = list(range = lib$wavenumber, res = 5,type = "interp"),
                             smooth_intens = T,
                             smooth_intens_args = list(polynomial = 3, window = 11,derivative = 1, abs = TRUE),
                             subtr_baseline = FALSE,
                             subtr_baseline_args = list(type = "polynomial",
                                                        degree = 8, raw = FALSE,
                                                        baseline = NULL),
                             make_rel = TRUE)
  processed.spec[[i]] <- processed1
  names(processed.spec)[i] <- names(spec.list)[i]
}

######### identify polymer #########
match.list <- list()
for (i in 1:length(processed.spec)){
  print(paste(Sys.time(),"|","Matching spec",i,"/",length(processed.spec),"..."))
matches <- match_spec(x = processed.spec[[i]], library = lib,
                      add_library_metadata = "sample_name", top_n = 5)
matches <- matches[order(matches$match_val,decreasing=T),]
match.list[[i]] <- matches
print(paste(Sys.time(),"|","Matching spec",i,"/",length(processed.spec),"completed."))
}

I also tried running match_spec without loop but the same issue occurred.
Expected behavior
Previously, a match could be generated in <2 min per spectra, and I was able to match ~800 spectra at one go without running into this problem, but now it just seems to be stuck at the 1st spectrum.
I apologise in advanced if this is due to some silly mistakes on my end. Any assistance is greatly appreciated!
Attachments
No response
Screenshots or Videos
No response
Additional Information
No response

Sorry we are just now getting to this, not sure how I missed it earlier. Could you share the dataset you're working with? Nothing stands out as being problematic currently but I after I see the data something may stand out.

@zzhui43, do your JDX files have multiple spectra in them? I know I deprecated that ability not too long ago because reading the multi jdx files became overly buggy. Might need to revisit it.

Hi Cowger, no worries! Each of my jdx file contains only one spectrum. I did a trial with the attached dataset but still have the same problem.
S11A8bkg1.zip
Error message:

[1] "2024-01-24 14:52:19.114426 | Matching spec 1 / 5 ..."
Error: cannot allocate vector of size 14.5 Gb
In addition: There were 50 or more warnings (use warnings() to see the first 50)

But I managed to do the matching in RMarkdown though. Here's my RMarkdown code:
knitr::opts_chunk$set(warning = FALSE, message = FALSE, results = 'asis')

Loading package and library
library(OpenSpecy)
get_lib("derivative")
lib <- load_lib("derivative")
setwd("C:\\Users\\User\\OneDrive - National University of Singapore\\Grad\\Research\\Heavy metal and microplastics\\Data\\Microplastic\\FTIR\\spectra")

spec.dir <- list.files(path="C:\\Users\\User\\OneDrive - National University of Singapore\\Grad\\Research\\Heavy metal and microplastics\\Data\\Microplastic\\FTIR\\spectra\\20231229\\jdx",pattern = "*.JDX",recursive=T,full.names = T)
spec.list <- lapply(spec.dir,read_any)
names(spec.list) <- sub("\\.JDX$", "", basename(spec.dir))
bg<- spec.list[grep("bkg1$", names(spec.list), value = TRUE)]
spec.list <- spec.list[grep("bkg1$", names(spec.list), value = FALSE,invert=T)]

for (i in 1:length(spec.list)){
spec1 <- spec.list[[i]]
cat(paste("### Spectrum", i,names(spec.list[i]), sep=" "))
cat("\n")

proc <- spec1 |>
  process_spec(conform_spec_args = list(range = lib$wavenumbers),
               smooth_intens = T, make_rel = T)

compare <- c_spec(list(spec1,proc),range="common")

cat("\n")
cat(paste("#### Raw vs processed spectrum - ", names(spec.list[i]),sep=" "))
cat("\n")
print(plot(compare))
cat("\n")
cat(paste0("*Black = raw; Red = processed*"))
cat("\n\n")
cat(paste0("#### Top Matches:"))
cat("\n")
top_matches <- match_spec(proc, library = lib, na.rm = T, top_n = 5,
                          add_library_metadata = "sample_name",
                          add_object_metadata = "col_id")
top_matches <- top_matches[order(top_matches$match_val,decreasing=T),]

print(knitr::kable(top_matches[, c("SpectrumIdentity","match_val", "SpectrumType","object_id", "library_id")]))
cat("\n")

compare <- c_spec(list(proc,filter_spec(lib, logic = top_matches[[1,"library_id"]])),range="common")

cat(paste("#### Processed spectrum vs top match - ", names(spec.list[i]),sep=" "))
print(plot(compare))
cat("\n\n")
cat(paste("---------------------------------------------------------------------------------------------------------------------------------"))
cat("\n\n")

}

@zzhui43
Thanks for sharing this, trying to reproduce now.
If I am understanding you right, the function works if in R markdown with the configuration listed but not with vanilla R operations, is that correct?

This function is giving me some warning messages
spec.list <- lapply(spec.dir,read_any)

JDX file inconsistency: Minimum of spectrum != MINY: difference = -4.4e-07 (-44 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = 3.2e-07 (32 * YFACTOR)
JDX file inconsistency: Minimum of spectrum != MINY: difference = -1.6e-08 (-16 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = 1.92e-07 (192 * YFACTOR)
JDX file inconsistency: Minimum of spectrum != MINY: difference = 1.2e-07 (12 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = -3.6e-07 (-36 * YFACTOR)
JDX file inconsistency: Minimum of spectrum != MINY: difference = -1.6e-07 (-16 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = 3.6e-07 (36 * YFACTOR)
JDX file inconsistency: Minimum of spectrum != MINY: difference = 3.2e-07 (32 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = 1.2e-07 (12 * YFACTOR)
JDX file inconsistency: Minimum of spectrum != MINY: difference = 3.34e-07 (334 * YFACTOR)
JDX file inconsistency: Maximum of spectrum != MAXY: difference = -1.68e-07 (-168 * YFACTOR)

Looks like the list items in processed spec is not a properly described Open Specy object.
check_OpenSpecy(processed.spec[[i]])

Seems like an errror is happening to the objects at this point:
trans <- spec.list[[i]] |>
        adj_intens(type = "transmission")

check_OpenSpecy(trans)

Error in if (!(cr <- ncol(x$spectra) == nrow(x$metadata))) warning("Number of columns in spectra is not equal to number of rows ",  :
argument is of length zero
In addition: Warning messages:
1: Names of the object components are incorrect
2: Spectra are not of class 'data.table'

Yep, I'm able to run the code after changing to 'transmittance' too. Thank you so much!


Unexpected "invalid memory address" error

When I run this code with the latest Crystal
abstract struct X
end

struct A < X
  getter value : String

  def initialize(@value)
  end
end

struct B < X
  getter inner : X

  def initialize(@inner)
  end
end

struct C < X
  getter inner : A | B

  def initialize(@inner)
  end
end

C.new(B.new(A.new("foo")))

it errors with
Invalid memory access (signal 11) at address 0x13e
[4352549] *CallStack::print_backtrace:Int32 +117
[4345048] __crystal_sigfault_handler +56
[4511336] sigfault_handler +40
[140088497677264] ???
[4582256] ???

which I do not expect to happen.
Update: I found out that it works when running it with the --release flag.

The compiler should detect this and give a compile error.
You can't have a struct with a field whose type is that struct itself, either directly or recursively, because there's no way to represent that in memory.
Use classes in this case.


fix: segment file can have multiple leaderboard entries

Hi folks!
Thank you for pretty handy SDK. I found that currently a segment file can have the only one leaderboard entry. This is not expected behaviour. Multiple leaders should be supported by design. In the case of Strava segment it is quite often that a segment has atleast three leaderboard entries like KOM, QOM and Personal Best.
This PR makes possible to add multiple leaderboard entries to a segment file.
Keep going!
Regards, Ilya

Hi, thanks for contributing, nice catch on segment leaderboard entry! I can confirm that it should have been multiple values after exporting segment from Strava. I have minor request on the field naming, since it's now a slice, can you rename it into its plural form, SegmentLeaderboardEntries will do.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.94%. Comparing base (06080c4) to head (f9b7d8f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   99.94%   99.94%
=======================================
  Files          42       42
  Lines        3689     3689
=======================================
  Hits         3687     3687
  Misses          2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@muktihari, good catch! Done.

Sorry @Drey , one more thing, I didn't see it earlier since it was minimized in code diff. On line 65 - 68:
var size = 4 // non slice fields
size += len(f.SegmentPoints) + len(f.DeveloperDataIds) +
	len(f.FieldDescriptions) + len(f.UnrelatedMessages)

Please change it to:
var size = 3 // non slice fields
size += len(f.SegmentPoints) + len(f.SegmentLeaderboardEntries) + len(f.DeveloperDataIds) +
	len(f.FieldDescriptions) + len(f.UnrelatedMessages)

By calculating the correct slice's len, this will prevent runtime to reallocate the resulting messages.
Other changes look good to me, I will merge it after this change. Thanks!

@muktihari, no worries, it's my bad. Done.

Merged, I appreciate the work. Thanks!


Go over the load module

Previously in the load.py module docstring:
TO DO:

Checking, fixing

Does the sig_mat_to_dict_join do anything now?

Make it easier/clearer to preserve/skip IBurst, RawAltimeter etc..

Time: Specify epoch?

Investigate what the RuntimeError is in the tilt function..

Look over what print messages are necessary (definitely cut some from the
reshaper)

I think I may have dealt with the two later ones at some point.

Looks ok now - I've cleaned up the code, sig_mat_to_dict_join is removed, and there doesnt seem to be any issues with epoch. No runtime error, and print messages seem appropriate. Closing.


refactor aws sqs queue scaler configuration

Refactor AWS sqs queue scaler configuration
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #5797

/run-e2e aws_sqs

lgtm, thank you!

My pleasure!


RFC: Cancel async effects

This proposal proposes to

Provide AbortSignal when executing effects.
Provide a way to stop async effects automatically.

useEffect(function* () {
    setLoading(true)
    // React automatically stops if the deps array outdated.
    setText(yield getData(props.id))
}, [props.id])

useEffect(signal => document.addEventListener('event', () => something(), { signal }))

View rendered RFC

I utilized a similar methodology within this repository and ended up here while delving into its history. Another notable benefit we now possess, as opposed to when this RFC was initially suggested, is our alignment with the using syntax in TypeScript 5.2 and upcoming ECMAScript versions. I don't believe there's currently a viable means of seamlessly integrating the using syntax with the existing useEffect approach.

closed because looks like there are no interest of this for one year


add curl_exec and curl_multi_exec to install requirements

1. Why is this change necessary?
The PHP methods curl_exec and curl_multi_exec may be disabled in the server configuration for security reasons. They are needed e.g. for the plugin manager to connect to the store and for guzzle to make multiple requests in parallel mode.
2. What does this change do, exactly?
Add  curl_exec and curl_multi_exec to this list of required functions in the install routine.
3. Describe each step to reproduce the issue or behaviour.

Disable  curl_exec and open the plugin manager. It will throw an error that it cannot connect to the shopware store.
😢

4. Please link to the relevant issues (if any).
This PR is especially for @mnaczenski 😉
5. Which documentation changes (if any) need to be made because of this PR?
/
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-22311
Please use this issue to track the state of your pull request.

Hey @larsbo,
thank you for your contribution! 💙


make local functions in ecp_nistz256-sparcv9.S indeed local

Fixes a linking issue on Solaris 11.4 by making all local functions to adhere to common scheme.
I used the solaris64-sparcv9-cc build target and used Oracle Developer studio 12.5 + Solaris linker for building. e.g. libcrypto.so was built like this:
cc -KPIC -xarch=v9 -xstrconst -Xa -xO5 -xdepend -L. -G -dy -z text -Wl,-Bsymbolic -mt  -Wl,-h,libcrypto.so.3 \
        -o libcrypto.so.3 -Wl,-M,libcrypto.ld crypto/aes/libcrypto-shlib-aes-sparcv9.o
... number of object files elided
                 -lsocket -lnsl -ldl -lpthread -lc

i.e. it used the -z text option that uncovered the problematic ecp_nistz256_point_add_vis3 function definition.

Ideally this should be backported to 1.1.x branch.

So a name scheme makes a difference? 'cause -z text is about avoiding relocation updates, isn't it? I'm surprised a different names makes a difference...

The main fix is removing .globl from ecp_nistz256_point_add_vis3, the naming scheme just makes it nice and tidy.

Oh! Didn't see the .globl change...
How about you reduce the change to just that, since that's the significant bit?

I split this into 2 changesets.

The reason the fix works is quite simple: if the symbol is global, it could be overridden by another library so linker needs to cater for this, hence the relocation. There is very good explanation on https://eli.thegreenplace.net/2011/08/25/load-time-relocation-of-shared-libraries/ under the 'Extra credit' paragraph.
For completeness, the object file was compiled like so:
cc  -I. -Icrypto/include -Iinclude -Icrypto -KPIC  -Xa -DSOLARIS_OPENSSL -Qoption cg -xregs=no%appl -xO5 -xstrconst -xdepend -m64 -xspace -DB_ENDIAN -DOPENSSL_PIC -DOPENSSL_CPUID_OBJ -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPOLY1305_ASM -DOPENSSLDIR="\"/usr/local/ssl\"" -DENGINESDIR="\"/usr/local/lib/engines-1.1\"" -D_REENTRANT -DNDEBUG  -c -o crypto/ec/ecp_nistz256-sparcv9.o crypto/ec/ecp_nistz256-sparcv9.S

Notably, the compiler uses -KPIC. So, if the ecp_nistz256_point_add_vis3() function was invoked via call instruction rather than be instruction the problem would not exist.

Individual CLA was submitted.

The Oracle CCLA will need to be updated too.

Yep, that's in the works.
Dne st 12. 6. 2019 11:22 uživatel Pauli<EMAIL_ADDRESS>napsal:

The Oracle CCLA will need to be updated too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openssl/openssl/pull/9132?email_source=notifications&email_token=AAWMMDC5M24QBWYBDLMZD5DP2C543A5CNFSM4HW6COW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXPZKGQ#issuecomment-501191962,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWMMDE3IS2ZXVS23KLR2DLP2C543ANCNFSM4HW6COWQ
.

Note that the CCLA does not need to be changed, just an updated "Schedule A" with the right list of names.  The CLA file in the internal repo has the contact name for each company.

I sent the individual CLA more than a week ago. Is this waiting on this or rather the corporate CLA ?

The corporate CLA list of people who can contribute needs to have your name added to it.
The changes also require two approvals (one now).
Both of these preventing merging.

I'm still going to be picky about the internal symbol name changes. If that is to be done, it should happen across all sparc assembly files, not just one seemingly picked at random. That's an argument to make that kind of cleanup in a separate PR.

All right, I dropped the changeset and will file a new issue to track the naming changes.

Thanks for obliging

closing to kick the CLA bot

Pushed to master and 1.1.1. Thanks.


Istio metrics causes Kiali to show incorrect graph - "unknown" instatead of "istio-ingressgateway"

Bug description
My workloads are deployed in the default namespace along with the gateway and the virtualService that I use to configure the istio-ingressgateway which is installed in the istio-system namespace.
When I use Kiali to visualize any graph in the default namespace, it shows that the entry of the traffic in the mesh is represented by the object unknown instead of istio-ingressgateway.  In all demos and images on google it shows that the edge/entry is represented by the istio-ingressgateway from istio-system namespace.
Is this the normal behavior of istio newer versions or it is a bug ?
First I raised this issue on Kiali google group kiali-users and I was advised to raise the issue to Istio because Kiali is only showing the graphs based on the metrics from the mesh.
Gateway:
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: gateway-default
  namespace: default
spec:
  selector:
    istio: ingressgateway # use Istio default gateway implementation
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "*"

VirtualService
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: vs-default-vs    # also tried with "default/gateway-default" value
  namespace: default
spec:
  hosts:
  - "*"
  gateways:
  - gateway-default
  http:
  - match:
    - headers:
        Host:
          exact: mail.kube.avan.local
    route:
    - destination:
        host: mailhog.default.svc.cluster.local
        port:
          number: 8025
... ...a long list of matching rules based on host header

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x ] User Experience
[ ] Developer Infrastructure
Expected behavior
The edge/entry in the mesh should represented by the istio-ingressgateway from istio-system namespace:
What I expect in the graph
(https://aws1.discourse-cdn.com/business4/uploads/istio/original/2X/1/1d7f31ba3168e3b657b94fbf9f90ed97e738e4af.png)

What i get - with "unknown" as entry in the mesh

Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version if you used Helm)
# istioctl version --remote
client version: 1.7.3
control plane version: 1.7.3
data plane version: 1.7.3 (66 proxies)

kubectl version --short
Client Version: v1.19.2
Server Version: v1.19.2

PS: I have also tried with kubernetes 1.18. and istio 1.6.1 and I get the same result.

How was Istio installed?
istioctl manifest generate --set values.global.jwtPolicy=first-party-jwt --set profile=demo | kubectl apply -f -
+
kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.7/samples/addons/kiali.yaml
+
$ kubectl apply -f https://raw.githubusercontent.com/istio/istio/release-1.7/samples/addons/prometheus.yaml

Environment where bug was observed (cloud vendor, OS, etc)
CentOS Linux release 7.7 -> single node kubernetes installed with kubeadm

Hi everyone. Any thoughts on this issue ?  Have anyone faced this ?
Thank you in advance.

It seems that I had a misconfiguration that caused the behavior I described. It is mandatory to name the ports of the Services in order to get the correct graphs in Kiali.
apiVersion: v1
kind: Service
metadata:
  labels:
    app: core-www
  name: core-www
spec:
  ports:
  - port: 8081
    protocol: TCP
    targetPort: 8081
    name: "http-8081"
  selector:
    app: core-www
  type: ClusterIP


[iOS] Uncaught Exception when capturing image

Steps to reproduce

I have the  component rendered in my layout and I can see through the viewfinder just fine
The crash occurs when I call Camera.capture()

Expected behaviour
I expect the photo to be created and the path passed back to me in the capture() promise handler
Actual behaviour
My app freezes due to xcode breaking:

Xcode console has just this message:
libc++abi.dylib: terminating with uncaught exception of type NSException
Once my promise catch handler was called with this error:
Error Domain=AVFoundationErrorDomain Code=-11800 "The operation could not be completed" UserInfo={NSLocalizedDescription=The operation could not be completed, NSUnderlyingError=0x9461380 {Error Domain=NSOSStatusErrorDomain Code=-16800 "(null)"}, NSLocalizedFailureReason=An unknown error occurred (-16800)}
Note:

This only occurs on my real device.  The simulator doesn't have this issue.  (I now see this line is only run in the real device case)

I just upgraded to xcode8 but I did see this before the upgrade.

Environment

Node.js version: 3.9.5
React Native version: 0.33.0
React Native platform + platform version: iOS 10.0

react-native-camera
Version: master (I just re-downloaded it)

I found that i do not get this crash if i wait a little bit after calling capture() before removing the Camera view from my layout.  I'm suspecting the crash could be related to a memory issue as I was changing too many things at the same time when the user pressed the capture button.
I will close this issue as there is not really enough information to investigate it well.


openstack-deploy: fix list_package role - no attribut artifacts

CI runs
When no old jobs with artifacts found:
https://ci.suse.de/job/cloud-ardana8-job-gate-entry-scale-kvm-update-x86_64/383/
When there are old jobs with artifacts for the run:
https://ci.suse.de/job/cloud-ardana8-job-gate-entry-scale-kvm-update-x86_64/390/artifact/.artifacts/rpms/
https://ci.suse.de/job/openstack-ardana/792/artifact/.artifacts/rpms/
https://ci.suse.de/job/openstack-crowbar/1009/artifact/.artifacts/rpms/


Add msgs api endpoint + utilities

Adds a common "path" to add sim API endpoints
Adds basic auth protection on API endpoints
Adds gson by google dependency for easy JSON encoding
Move code for fetching public timeline content into own method

Consider if we should just move it directly into it's own class that can work as a independent server seperate from the WebApplication class, and perhaps create a new class for all the common functions. It's pretty easy right now and I think we might get it as a task later around 29/3.

I haven't exactly tested the sim, but as I read the code we just have to tell them that the app url is something like http://ip:port and the api url is http://ip:port/api as they just append paths to the "base" url, and the sim will be fine with it. But I guess its something we should test before handing in :D

That makes sense! Hopefully it's possible. If not we can just create a new issue. So I think merging now is fine, unless someone else wants to take a look as well. :)


Confirmation dialog's colors get fudged sometimes

Typically it looks like this

sometimes though for whatever reason the cancel button picks up a different color:

Listing as a11y just bc it's user context related but it's not a typical a11y issue as the semantics are fine its just the wrong color for sighted users

fixed w/ LitElement converions of HAX


Reference to the IPAG report

I miss the inclusion of numerous aspects from the preliminary work of the IPAG, cf. report:
https://www.e-health-suisse.ch/fileadmin/user_upload/Dokumente/2016/D/160119_eAustrittsbericht_Bericht_IPAG_D.pdf
For example, more comprehensive use cases are addressed there or the different views of the professional groups.
Daniel Ratschiller, Cistec AG

See also https://github.com/hl7ch/ch-etoc/issues/4#issue-953837328:
A reference to eToC / eÜberweisungsbericht
should be added and the relation between the IG and the IPAG document be described.

For me it looks good and I close the issue


[BugFix] Fix Lowcardinality optimization could not work in Materialized View

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/statistic/StatisticExecutor.java
1
2
50.00%
[146]

:large_blue_circle:
com/starrocks/statistic/StatisticsCollectJobFactory.java
1
1
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-2.5

https://github.com/Mergifyio backport branch-3.0


Add tag to Post view more

What does this pull request aim to achieve? 💯
Add tag to Post view more, and small fixes
Just noticed that my PR #1046 had left off a commit. Didn't noticed that my push failed

Looks good on the build URL version!!


Javadoc for Task should mention TaskProvider as a dependency type

The Javadoc of the Task interface is missing the mention of TaskProvider as a potential parameter to dependsOn(). mustRunAfter() and shouldRunAfter(). There's a list of the options both on the interface's Javadoc and also at the Javadoc of dependsOn() itself (we could perhaps have one list instead, too).

@lptr Do you want to code review this PR: https://github.com/gradle/gradle/pull/5863


There is an error 'AuthorizationPermissionMismatch' when updating one entity under an attached table (SAS permissions 'Query, Update')

Storage Explorer Version: 1.22.1
Build Number: 20220113.2
Branch: hotfix/1.22.1
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.6.1
How Found: Ad-hoc testing
Regression From: Previous release (1.21.3)
Steps to Reproduce

Expand one storage account -> Tables.
Create one table -> Add one entity.
Right click the table -> Click 'Get Shared Access Signature...'.
Select 'Query & Update' permissions -> Create the SAS URL -> Copy the URL.
Attach the table using the copied URL.
Go to the attached table -> Click 'Edit' on the toolbar -> Click 'Update' on the Edit Entity dialog.
Check there is no error.

Expected Experience
There is no error.
Actual Experience
There is an error indicating 'AuthorizationPermissionMismatch'.

Additional Context
This issue also reproduces for one table which is attached by the SAS URL (generated via access policy).

According to the Azure documentation, both Add and Update permissions are required for "upsert" operations (updates an existing entity or adds a new entity if it doesn't already exist). We are using upsert for editing entities, which is why the operation doesn't work in this case. We can fix that by switching to explicit update operations, since we already know we are editing an existing entity.

Verified this issue on the build main/20220114.4. Fixed.


New failures on CI?

Downloads                          (2) |         failed at 2020-10-21T16:40:46.531
Test Failed at /usr/home/julia/buildbot/worker-tabularasa/tester_freebsd64/build/share/julia/stdlib/v1.6/Downloads/test/runtests.jl:198
  Expression: 11 ��� length(progress) ��� 12
   Evaluated: 11 ��� 10 ��� 12
Test Failed at /usr/home/julia/buildbot/worker-tabularasa/tester_freebsd64/build/share/julia/stdlib/v1.6/Downloads/test/runtests.jl:201
  Expression: all((p.dl_now == max(0, i - shift) for (i, p) = enumerate(progress)))

https://build.julialang.org/#/builders/33/builds/4986/steps/5/logs/stdio

It's not new, that test is just too fussy to be run all the time. I'll make a fix. Largely a dup of https://github.com/JuliaLang/Downloads.jl/issues/31.

I'll bump the Downloads version on master as soon as I've finished some API work that is also almost ready.


Add kyverno policy for security context

Reason

AC

Additional information / links

non-root user policy deployed to all clusters
also fixed memory limits which were set too low for dev and int clusters


git rebase?

Can someone add guidelines to using git rebase with forks of this repo to CONTRIBUTING.md? I'm still confused about how to go about syncing my fork with this repo using git rebase.

This would be a great last pull request!

Added in #85 — thanks, @ahmetoguzlu!


Support for API Versions

Are there any plans to support API versions?

I don't have substantive work plans for this repository: I happily review & usually accept pull requests for fixes & features that fit the intended scope, but don't actively write new code here because, well, the project does what it set out to do.
The approach we took for Mapbox was that REST API documentation, published with docbox, is for a single version: the active version. Changes to that documentation are published as a page, which is just a usual page. No fancy system for that. And documentation for old versions is just formatted Markdown, without a docbox site.
I'd be interested in approaches here, but cautious about doing too much more to promote other versions. What I've seen is that documenting older versions of APIs can be a trap: unless you make sure that there are bright red warning signs everywhere saying that "this is the old stuff, don't use it for new development", people will use it for new development. Even if you add bright red warning signs everywhere, people will often ignore them and still use old APIs for who knows why :)
Have you seen approaches that work well for this? Or have a usecase in mind?

Closing - happy to continue the conversation, but not seeing an action here.


no module named 'azure.functions'

https://github.com/Azure/batch-scoring-for-dl-models/issues/2

@asavaritayal @pragnagopa

can you give us more details? link you provided gives 404

Keeps getting a message like "cannot find azure.functions module" even though I walked through the install instructions

Can you manually install -
pip install azure-functions
pip install azure-functions-worker

Closing due to no repro.


As a developer I expect that any service domain is available at any time and that it responds to a call.

Feature Request
As a developer, I expect that any service domain is available at any time and that it responds to a call.
Description of Problem:
Mercury framework uses knative/camel-k serverless approach, which means that if there no calls the service will be down.
that can cause delays in the response time
Potential Solutions:

is it possible to have a service up all time? at least for most frequent used

note: this problem exists only when interacting with REST API

The operator is creating a deployment. It is not necessary at the moment to involve other technologies like KNative


How i can get left align collections item?

HI!
Is there any way for create this?

I CAN DO WHEN THESE WILLING TO PAY?
ÓSCAR MARTINS
PROGRAMADOR
Telemóvel.: +351 913859014
2016-06-27 13:54 GMT+01:00 evgenosiptsov<EMAIL_ADDRESS>
HI!
Is there any way for create this?
[image: components_cards8]
https://cloud.githubusercontent.com/assets/17506504/16380387/64fa8ad6-3c7f-11e6-9b8f-9120e3a5626f.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Dogfalo/materialize/issues/3322, or mute the thread
https://github.com/notifications/unsubscribe/AC8z32B9K3M4p4_nyga8e_HW5SuSbTpAks5qP8gJgaJpZM4I_ECI
.

Haha, thanks, I can do it myself for free) But i'm interesting complex solution via Google Materfial Design.

Very well :) Yes it seems to me a good idea that you use Google Material
Design: P
ÓSCAR MARTINS
PROGRAMADOR
Telemóvel.: +351 913859014
2016-06-27 15:11 GMT+01:00 evgenosiptsov<EMAIL_ADDRESS>
Haha, thanks, I can do it myself for free) But i'm interesting complex
solution via Google Materfial Design.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Dogfalo/materialize/issues/3322#issuecomment-228756757,
or mute the thread
https://github.com/notifications/unsubscribe/AC8z31aXXEUNFxSHhz3FjKxPXeM-9HmOks5qP9oJgaJpZM4I_ECI
.

Can you not just mark an image as secondary-content? We use the secondary-content class to pull items to the right of a collection

Thanks @acburst i didn't see that materializecss have .secondary-content class
@evgenosiptsov here is the code pen demonstrates collection list with images on the right - http://codepen.io/kmmbvnr/pen/xOpoBX

Closed due inactivity, feel free to reopen it if it is still necessary.


[BUG] Standings

Describe the bug
Issue with the standings where it outputs "Preseason, No Standings Yet" following week 1 of fantasy season.
To Reproduce
Steps to reproduce the behavior:

Go to 'Standings'
See error

Expected behavior
Page loads and displays no standings
Screenshots

Standings should be displaying now. It waits until Sleeper has officially declared week 1 over (usually towards the end of day Tuesday) to update standings.
If yours stop isn't working, feel free to re-open!


sqlalchemy: limit statement tag length

related to https://github.com/reddit/baseplate.py/pull/613
I logged some spans and saw that the ORM was generating a statement that grows with the length of a list of ids. I need to change that query but it still seems like it could be a good idea to limit what is allowed.
We could also log a warning in when binary annotations are created on the span with really long strings too.

tried upgrading typed-ast after CI failed. That didn't work so I added a commit removing the line pinning the version so PIP could resolve it.


fix transparent backgrounds with opaque text

fix for #87
I had a typo
aliases a little on the edges of glyphs when fully transparent

seems like there is no aliases on old version, I guess we can improve it later


Change OS Major Version Detection Dev3.0.0 Branch

With Windows Server 2019, we change the build number often. Need to change how we detect the Major Version that we are on. Look at using the property Caption on the Win32_OperatingSystem WmiObject class for all the server versions. Let's return a string for the MajorVersion type that it is.
From issue #252

We may also get the product version by checking Kernel32.dll:
(Get-Item $env:windir\system32\kernel32.dll).VersionInfo
(Get-Item $env:windir\system32\kernel32.dll).VersionInfo.FileBuildPart

@lusassl-msft what does your Windows Server 2019 show for that? I would assume that the kernel32.dll would still change with the Updates

PS C:\windows\system32> (Get-Item $env:windir\system32\kernel32.dll).VersionInfo | fl *

FileVersionRaw     : 10.0.17763.1158
ProductVersionRaw  : 10.0.17763.1158
Comments           :
CompanyName        : Microsoft Corporation
FileBuildPart      : 17763
FileDescription    : Windows NT BASE API Client DLL
FileMajorPart      : 10
FileMinorPart      : 0
FileName           : C:\windows\system32\kernel32.dll
FilePrivatePart    : 1158
FileVersion        : 10.0.17763.771 (WinBuild.160101.0800)
InternalName       : kernel32
IsDebug            : False
IsPatched          : False
IsPrivateBuild     : False
IsPreRelease       : False
IsSpecialBuild     : False
Language           : English (United States)
LegalCopyright     : © Microsoft Corporation. All rights reserved.
LegalTrademarks    :
OriginalFilename   : kernel32
PrivateBuild       :
ProductBuildPart   : 17763
ProductMajorPart   : 10
ProductMinorPart   : 0
ProductName        : Microsoft® Windows® Operating System
ProductPrivatePart : 1158
ProductVersion     : 10.0.17763.771
SpecialBuild       :

I feel like that is going to follow the WMI object, so we would still be in the same boat. We can do the great than option for the time being, but would need to be addressed once the next Window Server version comes out.

Okay, stumbled over it and thought it would be helpful


[engsys][credscan] review and improve suppression list

CredScan tool has a limitation/issue that it would suppress the whole
line if any part of the line matches a suppression pattern. It failed to detected real leak that might be in the form of
<variable_whose_name_matches_suppression_pattern> = "<real secret value>";

This PR improves the suppression list (not perfect but should be better):

Remove patterns that is likely to be in variable name, e.g., "password"

Make patterns more specific thus less likely to mask real secrets,
e.g., "SecretBaseUnion;" => "password: SecretBaseUnion;"

Move fake test secrets into separate files and suppress the files instead.

Add some fake test secrets in test-utils so that they can be
re-used.  Packages that have secrets specific to them still use
their own test secret files.

API change check
API changes are not detected in this pull request.

CredScan is passing for 3a407ff
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1868987&view=results (MS INTERNAL ONLY)


Bit width issue

Fixes #855
Describe the changes you have made in this pr - In Node.js I wrote to diisplay the obj type of the two elements between which the BitWidth error occurs . if the connection to the second element is made indirectly from a wire node then it displays string "Wire" else the name of the first object.
Next i wrote to delete the last wire added.
Screenshots of the changes (If any) -

Coverage remained the same at 83.902% when pulling 3defc1b5fa78e53c991d2b608540aa0b4988aada on jha11aditya:BitWidth_issue into d679f82e139ba10ac1c85f8b54670e57b109c33a on CircuitVerse:master.

This above push is because previously the branch had earlier commits form a different issue as I had committed in the master earlier. Now this pull request is clean and has commits only for this issue.

@MrBartusek
1> If the wire is still being dragged how will i know which element is the target.
And yes in the case the mouse is above the target node in the dragging phase , the specific wire is being dropped after you attach it.
2> Why should the target node be lit red, it is not possible to determine whether the target or source node's bitwidth is at fault when seen as a whole. So the wire is lit RED and dropped thereafter.
3> The error prompt is necessary otherwise how will the user know what was the error he did.

@jha11aditya So if I understand correctly the current state of simulator code is not allowing to make these things work?

Good attempt! It partially solves the issue, though I am not very sure if this is the way to go. Pending for now.

@mahmodHammad can u take a look on this PR ?

This  PR it's just for displaying clear info about the Bit width issue, along with deleting the last connected wire.
so this can get merged @satu0king

Closing this issue because of the following reasons:

New UI is in a different codebase
Wiring needs to be completely redone as a separate task


Performance issues on Windows

I'm not sure if it is specific to my work environment but pancake takes an extremely long time to run on Windows using latest LTS of node (currently 8.11.3).
If I use node 6.14.3 it is significantly faster but still a lot slower than on a mac.

@alex-page any chance this is related to https://github.com/govau/pancake/issues/72? Or is it something specific to Windows?

I think this was before #72 however I can investigate it further.

This is being moved into QA, waiting for publishing of new versions of components ( with updated pancake ) to test.

@rooby I did a test just after moving back to node-sass. The test was done on a slower older windows computer and a 2015 macbook pro. I used the gnomon package to see how long tasks were taking.
This is definitely an issue, installing 25 components took 171.98s on a slower windows computer vs 50.41s on a faster macbook pro.
Main points to note:

node-sass is a pretty big install and slower internet connections without an already cached binary can slow it down ( 9 seconds to download the windows binary vs 0.07s seconds for a cached mac binary )
pancake is a pretty intensive script and can probably be optimised for windows devices, currently it takes around 3.7 seconds per component on windows vs 0.86s on mac
The install of the packages were also slower on my windows laptop taking 20.35 seconds versus 8.49s on the macbook pro

This ticket would mainly be looking into the second point around optimising the pancake post install script for windows devices.
Some things to note are that the main things that take time in the pancake script are the compilation of sass -> css and minification of javascript.  These are dependencies of the project and can be slower depending on the hardware.  This ticket would be more looking into ways to speed up the pancake postinstall process, maybe we could try running the css and js tasks in parallel instead of synchronously.


Implement ArcTo

I required the HTML Canvas arcTo method for my project. So might as well implement it into Blazorex for other people to use rounded corners.

thanks for adding this!

@mizrael It works, thank you very much. If I come across anything that is missing I will add it in the future.


Convert reduce_dim_naive kernel to use the #[cube] derive macro

Pull Request Template
Following a discussion with @nathanielsimard on discord, I wanted to try to convert the reduce kernel to use the cube derive macro.
(originally because I wanted to know how to set the CubeCount for a kernel).
The new macro is pretty ergonomic, it's actually crazy that it also works for impl Trait.
I have a couple remaining issues though:
Checklist

[x] Implement CubeType for a tuple of CubeTypes: https://github.com/tracel-ai/cubecl/issues/48
[ ] How do I get the max value/min value of a Numeric? Do I need to add a trait for it?
[x] Need to add the computation of the CubeCount
[x] Confirmed that run-checks all script has been executed.
[x] Made sure the book is up to date with changes in this PR.

Testing
Unit tests

Some changes to be done, but that's crazy how flexible cube is, I never though we would be able to migrate the reduce trait to cube with that amount of ease.

Yes, it's crazy that the code just works like normal rust but is still handled correctly! Very nice that it works across traits as well


Update crypto deps

Update to the latest version of a bunch of crypto libraries. These libraries, especially the ones that belong to RustCrypto, have to be updated at the same time.
There have been a lot of API changes and deprecation warnigns, which needed quite some adaptation of our codebase.
Moreover, remove der and scrypt deps.
These dependencies are also exported by the x509-cert crate. We're going to consume them via this crate to simply dependency management.
These two dependencies must move in sync with x509-cert, hence it makes a lot of sense to leverage the export provided by this crate.

Great!  I've trying to do it as well (diff) but you are much further ahead :)

+1
For the pem crate version, you didn't want to move to 2.x or plan to do it later / separately?

I forgot about that! Let me update the PR to cover that one

@Xynnn007 , @dmitris : I've just pushed one more commit that updates pem

@Xynnn007 can you please take another look at this PR? It needs to be approved again because I made one additional commit that updates the pem crate

Thanks!


Canonical Hot Reload page doesn't seem to mention Hot Restart

I was looking for a canonical page on the differences between Hot Restart and Hot Reload, some sort of canonical page about the two technologies.
I found https://flutter.io/hot-reload/ but I didn't see the words "Hot Restart". I did see "full restart", but that might be misleading and confusing (what does "Full" mean? rebuild the APK?)
This request is about providing a canonical page on flutter.io that helps a developer understand our three build mechanisms: Hot Restart, Hot Reload, and Full Rebuild (if those are indeed what they are called :)
FWIW this is coming from an eval where there is some confusion that the two options are Hot Reload  and Full Restart (implying a very long full rebuild).

cc @mit-mit


LBFGS optimizer

Issue #, if available: #75
Description of changes: This is a draft pull request to add LBFGS optimizer for optimization of deterministic loss functions. I found this works much better than the current default optimizer for vanilla GPs.
If you don't object to the approach I use here I will take the time and add tests and tidy the code up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #187 into develop will increase coverage by 0.1%.
The diff coverage is 96.36%.

@@            Coverage Diff             @@
##           develop     #187     +/-   ##
==========================================
+ Coverage    88.15%   88.26%   +0.1%
==========================================
  Files           80       80
  Lines         4085     4140     +55
  Branches       693      699      +6
==========================================
+ Hits          3601     3654     +53
- Misses         310      311      +1
- Partials       174      175      +1

Impacted Files
Coverage Δ

mxfusion/inference/batch_loop.py
93.15% <96.36%> (+9.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d4e36...9da81a4. Read the comment docs.

@marpulli Is this pull request ready for merge?

My only open question is whether BatchInferenceLoopScipy is actually a good name as it only let's you use one specific scipy optimizer. I think BatchInferenceLoopLbfgs would be better?

BatchInferenceLoopLbfgs is better. It should be BatchInferenceLoopLBFGS.

Now renamed, I think it's ready to merge


Protobuf module fails to import on Windows

(env) D:\github\reverse-engineering-assistant\reverse-engineering-assistant>reva-chat
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "c:\users\-\.local\bin\reva-chat.exe\__main__.py", line 4, in <module>
  File "C:\Users\-\pipx\venvs\reverse-engineering-assistant\Lib\site-packages\reverse_engineering_assistant\chat_client.py", line 22, in <module>
    from .protocol.RevaChat_pb2_grpc import RevaChatServiceStub
ModuleNotFoundError: No module named 'reverse_engineering_assistant.protocol'

https://github.com/cyberkaida/reverse-engineering-assistant/blob/280bfe8fecaf5a11927e3175b5c9e5b492624072/reverse-engineering-assistant/reverse_engineering_assistant/chat_client.py#L19-L23

Is there a better way than this hack to make the protobuf generated code import?

Probably did not run the makefile
https://github.com/cyberkaida/reverse-engineering-assistant/blob/280bfe8fecaf5a11927e3175b5c9e5b492624072/Makefile#L21
Unfortunately the pyproject.toml does not trigger the protobuf build like the gradle does in Java.