Topic recognition: Siamese model classifier ADNI dataset

Name: Minh Tieu
Student Number: 46419712
Task 7: Create a classifier based on Siamese network to classify Alzheimer’s disease (normal and AD) of the ADNI brain data set having an accuracy around 0.8 on the test set. [Hard Difficulty]
This pull request include the the implementation of the OneShot Siamese network that will take an image and return 4096 feature vectors. After the Siamese network is finished training, the feature vector will be run through a binary classifier (5 fully connected classifier) to classify whether the image is Alzheimer's or disease.
Instruction on how to reproduce the run is inside README.md and other detail.
To run the code, there are two file you should run. If the model is train and generate siamese.pt and classifier.pt, you can run python3 predict.py to generate prediction on a random batch of 12 images. The image will include the predict classification and the real label. In addition, it will also return test accuracy result. If siamese.py or classifier.py don't exist, run python3 train.py and everything will be generate. Please download the dataset yourself and update utils.py for the save path as well as path to look at the train data. The final accuracy is around 77%
Commit File and Folder
Result folder
The folder include all the image related to the accuracy of the training and testing. For example, the accuracy of use the classifier on validating data, classifier loss, siamese loss, t-SNE diagram about feature vector on train dataset, validate dataset and test dataset (only the last epoch is include) and the classify image compare between the predict vs actual label.
Research image
The folder include all the theory based research from online source that help explain Siamese model theory.
README.md - This is the report of this project. It include everything you need to know about this project, model, implementation, result and how to reproduce the data. All images in both result and research is included inside this.
utils.py: This include the path that use to load/store the model or plot.
dataset.py: This include all relevant information about dataloader, typically, data augmentation, custom data preprocessing for splitting train data to 80% and 20% validating (Patient-wise to prevent data leakage) and Pair data loader for Siamese train.
modules.py: This file include Siamese model convolution layer, Binary classifier fully connected layer and Contrastive loss for Siamese model. Everything related to construct the model.
train.py: This file include all the training, this is where the both model is train. The Siamese is finished training first then it will be used to extract the feature vector to train the binary classifier. After finish training, it will also print out the test accuracy to stdout but also save loss model for siamese and  classifier as well as save siamese and classifier parameters in siamese.pt and classifier.pt. In addition, for the purpose of testing, the main function from predict.py is also include in train.py so, when running train.py, it is the same as running train.py then running predict.py. For more information, look in README.md.
predict.py: This file load the model and print out the test accuracy in stdout and also save the image about the classification of the test data predict label vs real label.
slurm.sh: Script for rangpur job -> showing what I run when training.
There are a total of 15 file inclusive

This is an initial inspection, no action is required at this point
Difficulty: Hard
Readme: Very good

clear flow of information
very detailed information on algorithm, training choices, hyperparameter tuning, usage
relevant plots and figures shown
results followed with good discussion/interpretations

Commit messages: Good
Code:

good design
sufficiently commented
algorithm seem to be correctly implemented

Functionality/Performance:

both siamese and classifier overfit massively
classifier achieves 77% accuracy on test set

General comments:

algorithm solves the problem apporpriately with slightly below-expected performance

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks missing -1
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Hard
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe acceptable/good
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good


lbryfilemanager.EncryptedFileDownloader lbry://xxxxx (xxxx) is unknown

The Issue
Log file shows lbrynet.lbryfilemanager.EncryptedFileDownloader:32: lbry://three-2 (8e70cc) is unknown for many files. Seems like an odd warning.
Steps to reproduce

Download some content, check log

Expected behaviour
no warning/error
Actual behaviour
warning/error logged
System Configuration

LBRY Daemon version:
LBRY App version: v11.9
LBRY Installation ID:
Operating system: Windows

Anything Else

2017-06-01 18:07:37,059 INFO     lbrynet.core.client.ConnectionManager:38: Connection Manager Steemit Open Mic Week 35.mov initialized
2017-06-01 18:07:37,094 INFO     lbrynet.lbryfilemanager.EncryptedFileDownloader:32: lbry://three-2 (8e70cc) is unknown
2017-06-01 18:07:37,387 INFO     lbrynet.core.client.BlobRequester:395: Offered rate 0.000000/mb accepted by <IP_ADDRESS>
2017-06-01 18:07:37,967 INFO     lbrynet.lbrynet_daemon.Downloader:78: Downloading stream data (2 seconds)
2017-06-01 18:07:38,967 INFO     lbrynet.lbrynet_daemon.Downloader:78: Downloading stream data (3 seconds)
2017-06-01 18:07:39,099 INFO     lbrynet.core.client.BlobRequester:545: Blob 7547e869845edf68 has been successfully downloaded from <IP_ADDRESS>:3333
2017-06-01 18:07:40,006 INFO     lbrynet.lbrynet_daemon.Daemon:962: Collected 1 lbry files
2017-06-01 18:07:40,007 INFO     lbrynet.lbrynet_daemon.Daemon:962: Collected 1 lbry files
2017-06-01 18:07:40,059 INFO     lbrynet.lbrynet_daemon.Daemon:2208: Got unused wallet address: bUPgTKAzzUZsvAgWuwYv3cbcPbJB8rBngR
2017-06-01 18:07:40,275 INFO     lbrynet.lbrynet_daemon.Daemon:962: Collected 1 lbry files
2017-06-01 18:07:40,549 INFO     lbrynet.lbrynet_daemon.Daemon:962: Collected 1 lbry files
Screenshots

This would be a lbry issue, and not likely one to get any attention, so let's see if this crops up again.


Move functionality to model to allow API use

:+1:
as in - via web API? , or just other parts of the system accessing?

API as in other parts of the system.


add space after <

otherwise markdown does not convert it to < and the rest of the line
just disappears in my printed copy.
Signed-off-by: Serge Hallyn<EMAIL_ADDRESS>

LGTM

LGTM
or, nit, can just say "prior to"

That's what my first patch did :)  I have no preference.


Adding the Home Webview view panel

Home view to contain all our actions and main functionality. and the other view for deployments.

@diaabadr After merging your first PR, there's conflicts, can you solve them?

@viferga Solved.


Run Test Job as Matrix

Closes #4426. This will run the test job against all supported platform runners in GitHub Actions on SingleThread and MultiThread mode.
Currently tests are flaky so I'm not sure how to fix this.

I would like to remark Test Reporting will be broken since this PR includes the proper fixes.

Aside from the culture test failures, which are to be addressed by the PR above, I am also locally seeing failures at:

[ ] GameHostSuspendTest.TestPauseResume
[ ] TestSceneSampleLooping.TestZeroFrequencyOnStart

Probably best addressed before proceeding with this merge.


Don't Give Up: continue with liquidation recovery when the electrs connection fails

Currently, when a user has a non-working electrs connection configured and an extended public key as their beneficiary address, we are unable to complete liquidation recovery because we error out trying to verify that a derived address is unused.
This PR changes that behavior to log the failure as an error, and then continue on with processing using the index supplied by local persistence.
Tagging @nkuba for review
closes #840

@nkuba anything else you want to see here?


[Feature Request] Option to disable comments in prompts (in settings)

Description
Currently, there is no option to disable the removal of "comments" from the processed prompt, except for disabling Dynamic Prompts altogether. Please add an option to opt-out of the use of the comment syntax within prompts, via a persistent setting.
To Reproduce

Enter a prompt with # somewhere in between, which is intended to be used as part of the prompt.
Click on Generate
Prompt is cut off at # due to comment feature, which (afaik) cannot be disabled or escaped.

Checkbox: Dynamic Prompts enabled is checked.
Local install

Expected behaviour
Preferred: Ability to disable comment-syntax (especially Python-style # comments) in persisted settings
Alternative: Ability to escape comment-syntax, e.g. \#
Additional context
Unfortunately, if you intend to use e.g. the # character as part of the prompt, there is, as far as I know, no way to escape it otherwise. Thus, every use of # will just comment out the rest of the line.
I use # as a prefix for all embeddings, to make it easy to identify them in a prompt, and avoid accidental usage of an embedding.
This means that I currently always have to disable Dynamic Prompts manually before using any embedding (and remember to do so).
Another option could be to add an option to disable Dynamic Prompts by default, though I would prefer to keep it enabled, as it otherwise does not conflict with my prompts, as far as I know.
I understand that this issue might be specific to my workflow, however I think that such a setting (and possibly similar ones for other parts of the syntax) could be useful for others as well.
There was once an option to disable comments, see https://github.com/adieyal/sd-dynamic-prompts/commit/efe24266bbeed94d19d9441fac2d13995d302049, however I would prefer to have a persistent setting in the settings tab, which would keep state when launching webui again.

FYI, 1.8.0 handles comments directly and has an option to disable them, so I think comment handling can just be removed from sd-dynamic-prompts.  I haven't checked processing order yet to see if the built-in comments interact with sd-dynamic-prompts correctly (removing comments before processing combinations and not after, so it doesn't generate combinations from commented-out options).


Prepare lab page header

No change of style and add 3 config options in index.html to deploy the
lab banner.
1 bug fix, the hamburger menu is invisible on / in narrow screen as it
is white.

Once the flag is switched to True the banner will change for the following:

I suggest merging and iterating as it does not change the current website layout.

Let's wait until the blog post is ready though ;-)
On Mon, Feb 12, 2018 at 3:49 PM, J Forde<EMAIL_ADDRESS>wrote:

@jzf2101 approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/pull/266#pullrequestreview-95984648,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABr0FtkMea31sFxOdm3MiTLmvvfOr4Pks5tUM4jgaJpZM4R-y5c
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Again:

This does not change the website
This does not modify the content
This does not change the style.

The lab_header: false will need to be changed to true and the following two values filled in:
binder_lab_url: TODO
blog_lab_url: TODO
So YES this should be merged before the blog post is live.

Closing as this would have needed to be merged and refined and I won't have the time to take care of that if the iteration cycle is a week long.

We talked at the JupyterLab meeting this morning about this PR. Our plan is
to review it once the blog post is final. We may want to update the
screenshot based on the blog/docs. Should happen in the next day or so.
On Wed, Feb 14, 2018 at 10:32 AM, Matthias Bussonnier <
<EMAIL_ADDRESS>wrote:

Closing as this would have needed to be merged and refined and I won't
have the time to take care of that if the iteration cycle is a week long.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/jupyter.github.io/pull/266#issuecomment-365701478,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABr0DJwuEK4wTdMwecBnksLUPGTlX3tks5tUyargaJpZM4R-y5c
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Again, this PR did not change the theme. It's just base work. The change of theme was still hidden behind a flag that need to be switched to be activated and get conditionally build by Jekyll.
Working on hundreds of line diff is  painfull.

Did you push @Carreau ?

No, I removed my branch as I'll not be working on it.

@Carreau I am aware your original PR did not deploy the changes (they were hidden behind a flag). However, for design work that is this high profile, I am not OK with it being merged without any design review, or discussion with the JupyterLab team about what needs to happen before it is launched.
I appreciate your working on this and don't expect you to carry the burden of keeping this PR up to date with out PRs that you are working on. I or others can take responsibility for dealing with merge conflicts if you have done other work in the meantime or want to begin other work that conflicts with this.


[stable/grafana] Revert "[stable/grafana] move datasource provider to containers (#209…

…85)"
This reverts commit 18e4853b
fixes #20909
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
We need it to fix #20909 - datasources are read by Grafana provisioning on startup.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @rtluckie

/assign

/assign
/ok-to-test

/lgtm


Test: add test_named_primary_key_constraint_names_are_visible()

Follows https://github.com/crate/crate/pull/14999.
Enabling PK names to be visible in information_schema.table_constraints also enabled pg_catalog.pg_constraint. This PR is just to add the missing test.

retest this please


Added President Obasanjo

Can you use a different image of the President Obasanjo and send it on a new pr?

Can you use a different image of the President Obasanjo and send it on a new pr?

Yeah, I initially did that but had an issue displaying the different image when I clicked Read more, it still referenced the former image, not the new one I added.


Fix IndexError when log message contains positional placeholders

If the log message contains {} or {0} positional placeholders, an IndexError
will be raise when LogstashFormatter attempts to format the message, passing
only keyword arguments.
For example, this happens when using LogstashFormatter with boto.
This patch silently ignores IndexError and leaves the log message unchanged.

Thank you @andyhd!


High resolution postpone

Hi, need your kind help again.
I want to generate high resolution mesh, say resolution = 0.01 or 0.005.
I already set
 size_t integrator_threads =7;
However, the calculation speed is still super slow, which result in postpone of mesh generating( rviz showing is also performing bad)
INFO] [1537326932.820455652]: Integrating a pointcloud with 220873 points.    [ INFO] [1537326937.923834207]: Finished integrating in 5.103299 seconds, have 16916 blocks. [ INFO] [1537326937.934127858]: Integrating a pointcloud with 220745 points. [ INFO] [1537326941.288767739]: Finished integrating in 3.354571 seconds, have 17747 blocks. [ INFO] [1537326941.298774226]: Integrating a pointcloud with 220395 points. [ INFO] [1537326946.805919204]: Finished integrating in 5.507082 seconds, have 18205 blocks.
The ideal processing speed is supposed to be integrating one point cloud in around 0.1 seconds, But I don't know how to make this comes true. Is it a limitation of PC?(Actually I tried on two computers and both failed to perform well)
Here is the launch file.
fail.launch.txt
Look forward and thanks a lot!!!!!!!!!!!!!

Honestly getting down to below 1 cm with Voxblox in realtime is going to be difficult.
First one small point. If you don't set the integration_threads parameter voxblox will automatically use the same number of threads as you have CPU cores, which should be optimal for processing speed.
There are two main issues limiting Voxblox's performance on very small voxels:

Voxblox integrates rays all the way from the detected point to the sensor. This means whereas other TSDF libraries scale with the square of the voxel size, Voxblox scales with the cube. Because of this we have only run the system in realtime down to about 3cm. Going from 3cm to 1cm will use around 27 times the CPU and RAM. You can disable full ray integration and just use the area around the truncation distance by setting voxel_carving_enabled to false, which will improve the scaling. However, this will prevent Voxblox from removing noise and outliers that occur in freespace.

Voxblox accesses memory in a fairly random order. This means it makes terrible use of the cache and the CPU is continually stuck waiting for data. You have probably noticed on quite powerful CPUs Voxblox doesn't get anywhere near 100% CPU usage even when falling behind. This means while a more powerful computer will always help, you will hit diminishing returns fairly quickly.

Thnxx a lot!


Recovery Services Vault must be in same Subscription as the resources

I couldn't find it referenced in any of the docs pages.
Please add specific mention that RSV can only backup VMs in the same Subscription as itself.
The docs do mention 'same Region' but not 'same subscription' and this is not intuitive.
Recommend adding it here: https://docs.microsoft.com/en-us/azure/backup/guidance-best-practices#single-or-multiple-vaults
and here: https://docs.microsoft.com/en-us/azure/backup/guidance-best-practices#subscription-design-strategy

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 88eb23b4-5aaa-f95e-6f73-4a89553cea58
Version Independent ID: e53b6a88-5c18-b119-debb-0c19f2abf62c
Content: Guidance and best practices - Azure Backup
Content Source: articles/backup/guidance-best-practices.md
Service: backup
GitHub Login: @v-amallick
Microsoft Alias: v-amallick

Thanks for the feedback. Will review the content and make appropriate changes.

@MikeWedderburn-Clarke Please check this portion of the support matrix section: https://docs.microsoft.com/en-us/azure/backup/backup-support-matrix-iaas#supported-backup-actions

Hope that answers!

@MikeWedderburn-Clarke As there are no documentation charges, we will close the issue for now. If there are further questions , please revert and we will be glad to assist you.


traceback when running

Traceback (most recent call last):
File "/home/jrwren/sublimvenv/bin/subliminal", line 11, in
sys.exit(subliminal())
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/core.py", line 722, in call
return self.main(*args, **kwargs)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/core.py", line 697, in main
rv = self.invoke(ctx)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
return callback(*args, **kwargs)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/click/decorators.py", line 27, in new_func
return f(get_current_context().obj, *args, **kwargs)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/subliminal/cli.py", line 403, in download
hearing_impaired=hearing_impaired, only_one=single)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/subliminal/core.py", line 211, in download_best_subtitles
for s in subtitles], key=operator.itemgetter(1), reverse=True)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/subliminal/score.py", line 106, in compute_score
matches = subtitle.get_matches(video)
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/subliminal/providers/opensubtitles.py", line 99, in get_matches
matches |= guess_matches(video, guessit(self.filename, {'type': 'movie'}))
File "/home/jrwren/sublimvenv/local/lib/python2.7/site-packages/subliminal/subtitle.py", line 235, in guess_matches
if video.format and 'format' in guess and guess['format'].lower() == video.format.lower():
AttributeError: 'list' object has no attribute 'lower'

This issue was fixed long time ago in develop branch. With the new release 2.1.0, this is also fixed in master


VS code available by default [enhancement]

Description
Some people like using VS code. They do not have access to VS code as part of the default deployment. We could make these people happy.
Suggestion
We use this project. They build a wheel using make build-package, and then build a docker image and copy it inside. If I can get my hands on the Dockerfile for qhub-jupyterlab I could hack this together and submit a pull request for feedback.
Context
I am not one of the above mentioned people but can sympathize with them and so can add this help with the addition of this feature for the sake of maximizing global utility.

This sounds quite cool! Thanks, @leej3! Let us know if there is something we can do to help with the development of that feature.
May the dev-force be with you 🎯

Here’s a nice write up Quansight/aes-management#38

I don't have access to this repo. Hopefully someone from the team will.

Yes, @viniciusdc is on it. He can close this upon success and glory.

Yes, @viniciusdc is on it. He can close this upon success and glory.

Yuhuuuul!!! He got this!

Solved by #469

Solved by #469


St/sdk 1434

Description
This PR fixes that debug_traceCall RPC method incorrectly returns an error response for reverted transactions.
In addition, it adds a test for verifying that a transaction created with a gas limit = to its intrinsic gas is a valid transaction, even if it fails for out of gas.
Jira Ticket
SDK-1340
Changes
Changed exception handling in EthService.scala in traceCall method.
Breaking Changes
Checks

[x ] Project Builds
[ x] Project passes tests and checks
[ ] Updated documentation accordingly
[ ] Breaking changes have been correctly tagged and notified

Additional information
It needs the following pull requests:

libevm https://github.com/HorizenOfficial/libevm/pull/19

Merged into st/interop_final branch.


Scroll bug (jerky, vibration) with "parentScroll" and variable item sizes

Hello,
I have a bug I do not use the "parentScroll" attribute with a custom HTML element and variable size item.
This creates a visual bug that jerks, vibrates or scrolls backwards.
This is an example, scroll to the bottom and you will see the bug :
https://plnkr.co/edit/g8WLBOgqDJjPsoffETEA?p=preview
Thank you.

Hi @twjacobsen, It is not possible to implement a smooth scroll with items with variable size as in the example. All the calculations are based on the first item and first item only. So if other items in the list don't match the width and height of the first (visible) item in the list, the calculations would go wrong.
Considering every item's size in the list without affecting the performance is tricky. Please share if you have any ideas about how to fix this.

If it's possible to scroll a number of pixels, it's possible to animate it.
Just scroll a subset of pixels every x milliseconds.
But the alternative of just providing a method of getting the number of
pixels to scroll, instead of scrolling, would be nice too.
On Wed, 6 Sep 2017, 11:17 Rinto Jose<EMAIL_ADDRESS>wrote:

Hi @twjacobsen https://github.com/twjacobsen, It is not possible to
implement a smooth scroll with items with variable size as in the example.
All the calculations are based on the first item and first item only. So if
other items in the list don't match the width and height of the first
(visible) item in the list, the calculations would go wrong.
Considering every item's size in the list without affecting the
performance is tricky. Please share if you have any ideas about how to fix
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rintoj/angular2-virtual-scroll/issues/104#issuecomment-327425523,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAh7JOYg4buE1PvrLB6TyZ2FWAsK-W4Yks5sfmMXgaJpZM4POEHX
.

Setting a fixed height to my rows fixed the problem.
I assume that some scenarios will not work here, but in my case I set the minimum height expected for the row.
Doing this fixed the inner calculations issues while scrolling
thanks @rintoj

https://github.com/rintoj/angular2-virtual-scroll/pull/110 smooth scroll implemented here

Closing this since I haven't received a response from the original poster. Please re-open if you continue to experience this issue.


Make our monitoring instances m5.large instead of t2

The monitoring instance that runs Icinga and Smokey in Integration has
begun running out of CPU credits. This is making it difficult to
diagnose problems elsewhere in the stack. Making it an m5.large costs
~$77pcm instead of ~$36pcm, and doubles the RAM.

Seems only in the last few days, but I think it's an important enough instance to not want to sorry about it for the sake of $35pcm.


WIP: QR Code Configuration

QR CODE DASHBOARD

QRCODE PRODUCT ATTRIBUTE UI

SUMMARY
Currently no QRCode implementation until digital ocean spaces utilisation. Currently CRUD and usability for QRCodes and their associated Product Attributes

Updated attribute header

Now features a header displaying the selected qrcodes data


logs file naming and path

Describe the bug
in Windows files names cant have :

but the logs file is talker_logs_2023-02-24 00:13:22.710122.txt which is forbiden
To Reproduce
Steps to reproduce the behavior:
Talker screen
share logs file
Expected behavior
it should save the file with diffrent naming.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows
Version 10

Additional context
Add any other context about the problem here.

i created a pull reuqest to fix it https://github.com/Frezyx/talker/pull/99


Chain 4 not found Smart Chain Tasks and Research

Description

Steps to Reproduce the Bug

Run the smart tasks chain with research
let it get to step 4
error will appear

Expected Behavior
Its supposed to perform whatever step 4 does in the chain for smart task and research.
Operating System

[X] Linux
[ ] Microsoft Windows
[ ] Apple MacOS
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[X] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[X] Local - You run AGiXT in your home network
[ ] Remote - You access AGiXT through the internet

Runtime environment

[ ] Using docker compose
[ ] Using local
[ ] Custom setup (please describe above!)

Acknowledgements

[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of AGiXT.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Fixed in #761 and #762


Currently not working

This page/function should be removed until it is working/supported.  Looks like this was added too early

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1d1b44e3-4af5-1458-d931-72a0f698732b
Version Independent ID: 1751767f-1d8a-7750-35b9-725b5a3ad705
Content: Start-SPOSiteRename (sharepoint-online)
Content Source: sharepoint/sharepoint-ps/sharepoint-online/Start-SPOSiteRename.md
Service: sharepoint-powershell
GitHub Login: @joseOrtega
Microsoft Alias: j0rt3g4

Error Code: -5,It's not supported

@officedocsbot assign @yogkumgit

This command doesn't work, is there any timeline when this will be supported?

This cmdlet is only available for the Preview admin center. Please Enroll here: https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR3CCKNES_u9Bul1dZT-hbi5UNTFUODdKQVNFQUJMRzAxTVhUMUsyWFlOOC4u

Hello everyone,
Thanks for your feedback.
I can confirm that the cmdlet is not yet available for production use.
Thank you

@get-itips  Thank you very much for the contribution and sharing this explanation. @Troy-Phillips
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


Remove automatic file names in @optimize_or_load

DrWatson's philosophy of automatically naming output files in DrWatson.@produce_or_load did not do well with @optimize_or_load. Deducing some automatic filename from a given problem is cumbersome to say the least. In practice, I almost always want to pass an explicit filename.
Thus, file (the combination of the previous path and filename) must now be passed as the first positional argument to @optimize_or_load. The keyword arguments filename, prefix, savename_kwargs, that controlled the automatic file naming have been removed. The dry_run keyword argument has been removed, since it now has no effect.
The @optimize_or_load macro now returns only the optimization result, instead of a tuple consisting of the optimization result and the output file.
The optimization_savename and default_optimization_savename_kwargs routines have been removed.

Codecov Report

Merging #41 (59c0f00) into master (9ac6881) will decrease coverage by 3.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   83.22%   80.22%   -3.01%
==========================================
  Files          13       13
  Lines         799      789      -10
==========================================
- Hits          665      633      -32
- Misses        134      156      +22

Impacted Files
Coverage Δ

src/QuantumControlBase.jl
100.00% <ø> (ø)

src/optimize.jl
83.87% <75.00%> (-5.02%)
:arrow_down:

src/saving.jl
0.00% <0.00%> (-95.24%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Vscode template error

Steps to reproduce
base16-builder -s eighties -t vscode -b dark
Expected Behaviour
output vscode template
Actual Behaviour
An unexpected error occured while building your theme: {"path":""}
Node and npm versions
node v8.5.0
npm 5.3.0

Base16-Builder version
1.3.0

Additional Information

I'm getting the same error with the vscode template. Other templates seem to work fine.
~ $ base16-builder -s Brewer -b dark -t vscode
An unexpected error occurred while building your theme: {"path":""}

Version Info

Node v8.7.0
npm 5.5.1
base16-builder 1.3.0

Well, after a quick investigation, the error with the template was following.
ReferenceError: ejs:551
    549| 	</array>
    550| 	<key>uuid</key>
 >> 551| 	<string><%- uuid %></string>
    552| </dict>
    553| </plist>
    554|

So my workaround to that was to delete this line from vscode template, and rebuild whole package. Then, everything was working fine.  Also this problem is related to textmate, which has same template, so the error persists.


[🐞] Elements processed out of order with no SSR

Which component is affected?
Qwik Runtime
Describe the bug
When I run pnpm vite and view the page as defined below I see 2, 3, 1 printed to the browser console.  However when I run pnpm vite --mode ssr and view the page I see 1, 2, 3 printed to the server console.
If you add additional children it just trickles down, the FIRST is always executed LAST in non-ssr.  In the DOM it appears in the correct order in both scenerios.  This makes component testing challenging when you are expecting a precise ordering.
import { component$ } from<EMAIL_ADDRESS>
const Child = component$((props: { order: string }) => {
  console.log(props.order);
  return
{props.order}
;
});

export default component$(() => {
  return (

          <Child order="1" />
          <Child order="2" />
          <Child order="3" />

  );
});

Reproduction
https://stackblitz.com/edit/qwik-starter-tvnpeu?file=src/root.tsx
Steps to reproduce

Allow the blitz to run as default
See 1,2,3 printed to the server console
Ctrl-C to kill the server
Start server in non-ssr with npm run start-nossr
See 2,3,1 printed to the browser console

System Info
System:
    OS: macOS 13.1
    CPU: (8) x64 Intel Xeon Processor (Cascadelake)
    Memory: 18.87 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.asdf/installs/nodejs/18.16.0/bin/node
    npm: 9.5.1 - ~/.asdf/plugins/nodejs/shims/npm
  Browsers:
    Firefox: 110.0.1
    Safari: 16.2
  npmPackages:
    @builder.io/qwik: 0.105.0 => 0.105.0
    @builder.io/qwik-city: ~0.104.0 => 0.104.0
    undici: 5.22.0 => 5.22.0
    vite: 4.3.3 => 4.3.3

Additional Information
No response

Related to #4757

Here's a playground demonstrating the issue.
Interestingly, the second time you render on the client it does do it in order.
However, I don't think this will get fixed. There's no guarantees on rendering order, and implementing such guarantees takes effort, continued maintenance, and might impact performance.
@mhevery what's your take on this?

This has to do in dev mode we lazy load code, which means there is a promise that causes a delay in rendering. I don't think this is something we can fix without a perf penalty, so I would say it works as intended.
I am tempted to close issue as working as intended. WDYT?

The workaround for this problem is to use "inline components" that allow you to track the right order
This is what we did in Qwik UI
https://github.com/qwikifiers/qwik-ui/blob/main/packages/kit-headless/src/components/tabs/tabs.tsx#L76
Closing as working as intended for now

we need docs on this

Thanks @PatrickJS ! good suggestion!
Let's open a new issue about it and reference this issue so we won't forget.


dg box approval section

Develop frontend component for approval/denied section on the Admin Dashboard page
Build a separate component for the individual Box Information with all the details listed on the mockup
Figma Sheet
closes #11

I updated the code quite a bit to try and make things cleaner, but I believe all of the issues you addressed are fixed! Let me know if there is anything else to edit.


How to integrate  superset with zitadel for SSO login

Hi ,
There there any option for integrate superset with zitadel for SSO login .If there is any docs for there please share.Or We can do customize that Please give ther setps. I am using this  https://github.com/apache/superset.git repo. and doing docker install.

Closing this in favor of https://github.com/apache/superset/issues/28058 since that's more actionable, and this would be better as a Q&A Discussion. In short, Preset allows you to write a custom security manager. Here's an entry point for some docs. https://superset.apache.org/docs/installation/configuring-superset/#custom-oauth2-configuration

Hi,
 Hi I followed the same

On Tue, 16 Apr, 2024, 9:54 pm Evan Rusackas, @.***>
wrote:

Closing this in favor of #28058
https://github.com/apache/superset/issues/28058 since that's more
actionable, and this would be better as a Q&A Discussion. In short, Preset
allows you to write a custom security manager. Here's an entry point for
some docs.
https://superset.apache.org/docs/installation/configuring-superset/#custom-oauth2-configuration
—
Reply to this email directly, view it on GitHub
https://github.com/apache/superset/issues/28055#issuecomment-2059481438,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQCUYDTFQ5RJMIQLSEVTDL3Y5VGE5AVCNFSM6AAAAABGJFCHZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZGQ4DCNBTHA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Restore pydoclint, add class docstrings

This reverts #4235
Flake8 is necessary as it is the only way to get realtime feedback during development using VsCode.
In this PR, the flake8 and pydoclint configurations are restored to what they were.
The latest version of pydoclint added class atribute checking in the class docstrings.  Included are those docstrings such that precommit should pass the check.
This will also keep the pydoclint configuration consistent with dome of the other team repos:
pytest-ansible
tox-ansible
ansible-creator
ansible-dev-environment
ansible-dev-tools

tox/tox/pkg failure appears to be identified upstream with work happening on it: https://github.com/pypa/twine/pull/1124


Sinopia Stage indexing not updating

When working on templates in Stage, the changes to labels on the list page is not happening. I have hard refreshed many times, restarted Chrome, etc. It has been this way since Saturday (it worked fine then). Seems like the indexing is not happening.

@NancyL Can you provide exact steps to reproduce the issue? I want to make sure I'm looking at the right thing.

As an example, I changed the label _PCC BF2 Monograph Item to _PCC BF2 Item (Monograph) on Saturday afternoon in the resource template. Until then, any time I updated a label, it changed immediately on the listing page. When it didn't change, I did a hard refresh. That did not work. I did it several times, and also logged out, logged in several times. Nothing has changed since Saturday afternoon. The only step I did was to change a label.

Hmmm ... log shows that it indexed correctly:
Indexing https://api.stage.sinopia.io/resource/pcc:bf2:Monograph:Item (template) into index sinopia_templates:
{
    "id": "pcc:bf2:Monograph:Item",
    "uri": "https://api.stage.sinopia.io/resource/pcc:bf2:Monograph:Item",
    "author": "PCC",
    "date": "2020-09-20",
    "resourceLabel": "_PCC BF2 Item (Monograph)",
    "resourceURI": "http://id.loc.gov/ontologies/bibframe/Item"
}

well, does it show up for you correctly on the template list?

Oh no. I can replicate your problem @NancyL. Just puzzling over the cause.

When I re-indexed, the document was indexed twice.

I wonder if there is a missing unique index on stage.

Yes, we were missing the proper unique index. I've remediated duplicate data and added in all 3 environments.

OK @NancyL. This should be resolved. Thanks for reporting.


Classes of LibLog should have the [ExcludeFromCodeCoverageAttribute]

I have a small project that uses LibLog. When I run my tests with OpenCover to see my coverage, I see that my coverage is quite low. My coverage holes are mainly in LibLog.cs. I obviously don't want that since LibLog.cs is not my code.
Lots of people already use the ExcludeFromCodeCoverageAttribute to flag code that should not be included in code coverage. I think that the LibLog code should use this attribute to make it easy for everyone to get rid of coverage holes in LibLog.cs.
For sure people could put an exclusion on LibLog.cs. But since most people already exclude coverage for code that have the ExcludeFromCodeCoverageAttribute, it would be simpler for them if LibLog used this attribute.

Sure. Please send a PR?

PR is here: https://github.com/damianh/LibLog/pull/122

Going to tweak this a bit as I need the code coverage when I am developing LibLog... I've made this opt-in via compiler directive LIBLOG_EXCLUDE_CODE_COVERAGE. Change is here https://github.com/damianh/LibLog/commit/141510c7cfcb6c0f0f69bd8b7c18799692eb63d9


Broken

make it so the minimap server looks in spectate mode and uses ball-id to get true position.

See #66


Unexpected differences between 1.21 source tarballs

There are unexpected differences between the automatically-generated tarball and the manually-generated tarball of 1.21. The expectation is that the automatically-generated tarball contains the same files as the manually-generated tarball but that the latter has had the appropriate autoconf commands already run. This is not the case with your two tarballs.
Your manually-generated tarball is from Oct 22, 2016 at 04:25 CST, while the automatically-generated tarball is from 21 minutes later, at 04:46. There are significant differences, for example the automatically-generated tarball contains a Changelog entry for 1.21, but the manually-generated tarball does not. There are also differences in the installation and configuration instructions.
Did you perhaps inadvertently upload an earlier prerelease version of the manually-generated tarball? If so, could you release a new version 1.22 with the correct tarball?

I apologize for the inconsistencies. I just created 1.22 release and hope that tarballs are in sync. Thank you for issue creation and detailed description of the problem!

Fixed.


Index out of bounds in capturePhotoProcessedUpToFilter:withImageOnGPUHandler:

We continuously receive crash reports, when a subset of users are trying to capture a still image with GPUImage.
The exception
The exception occurs at [GPUImageStillCamera capturePhotoProcessedUpToFilter:withImageOnGPUHandler:] at line 283:
[photoOutput captureStillImageAsynchronouslyFromConnection:[[photoOutput connections] objectAtIndex:0] completionHandler:^(CMSampleBufferRef imageSampleBuffer, NSError *error) {
    // -------------------------------------------------------------------------------^^^^^^^^^^^^^^^
    ...
}

The code
Our part of the capture code looks like this:
@weakify(self)
[self.stillCamera capturePhotoAsImageProcessedUpToFilter:self.filter withCompletionHandler:^(UIImage *processedImage, NSError *error) {
    @strongify(self)
    [self.stillCamera stopCameraCapture];
    [self.useCommand execute:processedImage];
    UIImageWriteToSavedPhotosAlbum(processedImage, nil, nil, nil);
}];

This stillCamera is initialized as follows:
_stillCamera = [[GPUImageStillCamera alloc] initWithSessionPreset:sessionPreset cameraPosition:squareCapturing ? AVCaptureDevicePositionFront : AVCaptureDevicePositionBack];
_stillCamera.outputImageOrientation = UIInterfaceOrientationPortrait;
_stillCamera.horizontallyMirrorFrontFacingCamera = YES;

and the filter like this
_filter = [[GPUImageCropFilter alloc] initWithCropRegion:CGRectMake(0.f, 0.125f, 1.f, .75f)];
[_filter addTarget:cameraView]; // A GPUImageView
[self.stillCamera addTarget:_filter];

The hunch
It is as if the connection to the camera is prematurely interrupted, causing the [[photoOutput connections] objectAtIndex:0] to fail - unless the camera was never initialized properly, i.e. the user saw no preview onscreen due to an initialization error.
Due you have clues as to why this happens and maybe some tips for handling this more gracefully?

@BradLarson

I'm having the same issue...

Is this a known issue?

I am having the exact same issue on some devices.

@philipengberg were you ever able to solve this issue?

@sluitel No, unfortunately not

Same problem here, I hope there is a way to solve this 👍


Why are some of the images smaller on certain websites?

Sorry if this has already been answered or this is....ABSURDLY obvious because I'm great at pointing out such things smh, but I can't figure out why images on, say, chan.sankaku are INCREDIBLY small and then I look at zerochan and they're MASSIVE.
Examples are here on the bottom. I also honestly just wanted to say this is BY FAR the coolest thing I HAVE EVER USED! This is a life saver. I wasted my time on websites FAR too much and I thank you for all the work everyone has put into this. Really awesome stuff.

I can guess that thumbnails images has defferent resolution depending of type of site, where are they from.  Usually all booru sites on same engine has same thumbnail size and images per page number. Looks like the most common type is 150px150p thumbnails and 20 images per page. But sites on another engine may have their own parameters(like yande.re with giant thumbnails or zerochan with 100 images per page)
I hope Bionus will correct me if Im'mistaken in something.

OH OKAY I got it my bad that, actually makes a lot of sense. Thank you very much for the quick response as well.

It's exactly as MasterPetrik said.
Note that if you have a huge screen (4K or something) and find the thumbnails too small, there's a thumbnail upscale setting to make them bigger. :smile:

As the issue already closed, I want to ask some related questions:

Where is this thumbnail upscale setting?
Is there some setting in grabber to set images per page number for merged results?


Pagination and check button loose tooltip

Need to look into why the paginated buttons and checkboxes retain the tooltip when press and move away but toolbar and action bar do not

This has been fixed


import statement in README was incorrect for me

I needed to do the following to import:
import DebounceQueryParams from 'debounce-query-params/mixins/debounce-query-params';

versus what is in the README:
import DebounceQueryParams from '../mixins/debounce-query-params';

Thanks for the great plugin.  This is super useful!

Thanks! I'll fix the error in the documentation.
Cheers.


Roadmap

Development
Timezone

[ ] Support Timezone

Props

[ ] only support String type for startDate and endDate
[ ] support maxYear and minYear
[ ] support maxSpan
[ ] dateRender to customize the rendering of date cells in the calendar

Calendar

[x] add year select(a dropdown menu)
[ ] add month select(a dropdown menu)
[ ] support single calendar
[ ] unlinked calendar

Presets(or Ranges)

[x] set the location of the shortcut on the left

Events

[x]  change

Docs

[x] add jsfiddle example

[x]  add docs and get it online

[x] add playground example

[ ] add docs about timezone

[ ] integrate comment system with document

[ ] add usage about resgistration in component

Code Review

[ ] provide MindMap and design idea for code review (辅助源码阅读的思维导图或者设计思路)

Get me troubled

[ ] how to import font icon or svg icon only used 如何按需引入 font icon 或 svg  icon
[ ] how to support multi theme or design system

i18n

support multi language

how can we reset date once it applied.

Will it ever be use-able in IE?

Will it ever be use-able in IE?

actually it is unavailable in  IE8 and below
The Vue.js document:
`
Compatibility Note
Vue does not support IE8 and below, because it uses ECMAScript 5 features that are un-shimmable in IE8. However it supports all ECMAScript 5 compliant browsers.
`

O.o For me it's not working either on IE 11

O.o For me it's not working either on IE 11

oops，i will try it later，thanks for your feedback

How I can use multi language?

I need start of calendar been from monday


Login failed: Could not login: could not pre-login: Not Found:

version 0.3.3 / running on NixOS
$ goldwarden vault login --email NNN

Login failed: Could not login: could not pre-login: Not Found:

The config was set with goldwarden config set-server https://vault.bitwarden.eu && systemctl --user restart goldwarden
$ goldwarden config get-environment

{"api":"https://api.bitwarden.eu","identity":"https://identity.bitwarden.eu","notifications":"https://notifications.bitwarden.eu","vault":"https://vault.bitwarden.eu"}

@barolo Are you using vault.bitwarden.eu?

Likewise:

...using:

PS /home/RokeJulianLockhart> flatpak info com.quexten.Goldwarden

Goldwarden - A Bitwarden compatible desktop client

          ID: com.quexten.Goldwarden
         Ref: app/com.quexten.Goldwarden/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: v0.3.3
     License: MIT
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 11.1 MB
     Runtime: org.gnome.Platform/x86_64/45
         Sdk: org.gnome.Sdk/x86_64/45

      Commit: 1a8f7ea53dae75d092edfc78a62fb3a242e5e66077e9585e32db795d6bc14002
      Parent: b49d4270b375e72aa8e0680d654a84d14f0a2292bf5b016c90e829ea0a8640ee
     Subject: Update 3 modules (9194568a)
        Date: 2024-06-03 21:37:00 +0000

...on:

Operating System: Fedora Linux 40
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Kernel Version: 6.10.3-200.fc40.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 7600X 6-Core Processor
Memory: 30.5 GiB of RAM
Graphics Processor: AMD Radeon RX 5700
Manufacturer: ASRock
Product Name: X670E Taichi

https://github.com/quexten/goldwarden/issues/274#issuecomment-2284806360

Ah, I fixed it by entering the optional values at https://github.com/quexten/goldwarden/discussions/276#discussioncomment-10318472.

I get the same issue but with the default setting
{"api":"https://vault.bitwarden.com/api","identity":"https://vault.bitwarden.com/identity","notifications":"https://notifications.bitwarden.com","vault":"https://vault.bitwarden.com"}
v0.3.3

Fixed for me by setting client id and client secret from the web vault: https://github.com/quexten/goldwarden/discussions/276#discussioncomment-10318472


upload datasets

Created data folder and uploaded raw datasets.

wage.csv : minimum wage data
bigmac_price.csv : bigmac prices data

Looks good, thank you beth!

Linked to Issue #10 - Find and store the right dataset (https://github.com/UBC-MDS/DSCI-532_2024_12_bigmac/issues/10)


Changed file location to posts

@eah13 attempt to fix issue #618

Looks good but you need a space between layout and post. Maybe @EternalFootman can merge once you've done that. I'll be out of contact starting soon.


0.2.7 includes a semver breaking change

0.2.7 includes commit https://github.com/time-rs/time/commit/a93d32efffba2f96512fe3758d56cb3ac037fe82, which is a (silent) semver breaking change. This is causing cookie-rs to fail to test. I also don't see this panicking behavior documented anywhere.
This is at least the third semver breaking change without a semver version bump this library has experienced since moving to 0.2, not to mention the failure to build in 0.2.8. This makes using the library a hazard. My advice is to consider asking for external review before releasing a new version. At present, I am considering a migration away from the library.

Without seeing the backtrace I can't be positive, but given the error I believe this actually has nothing to do with the overflow checks in Duration. Rather, it is a result of the clearly-stated validity guarantee that has been present since the initial 0.2.0 release:

Years between -100_000 and +100_000 inclusive are guaranteed to be representable. Any values outside this range may have incidental support that can change at any time without notice. If you need support outside this range, please file an issue with your use case.

With regard to 0.2.8 possibly not building, I presume you've seen #233. As is standard practice, I allowed the usage of any semver version back to the most recent major (0.1). I naïvely assumed this would work; this was obviously not the case. I have since verified all other direct dependencies work at both the minimum and current version in the semver range.

Are there any tools that would allow me to perform something along the lines of a crater run? If I could manually give something a list of libraries (starting with all reverse dependencies) and ensure that there are no regressions, that would be ideal.
External review is far from perfect — we don't need to look any further than the standard library where breaking changes have been introduced (without an FCP) on the unverified assumption that it wouldn't break anything. This is precisely what occurred with overflow checks on Duration arithmetic. I could not conceive of a single use case where one would actively want a Duration to overflow, given it is capable of storing lengths of time vastly longer than the age of the universe, and it does not appear that this is the cause of the CI failure in the cookie crate.

Without seeing the backtrace I can't be positive, but given the error I believe this actually has nothing to do with the overflow checks in Duration. Rather, it is a result of the clearly-stated validity guarantee that has been present since the initial 0.2.0 release:

The error is:

thread 'tests::format' panicked at 'year must be in the range -100000..=100000 (was 219250468)', <::std::macros::panic macros>:5:6

Looking at the test, it's obvious this comes from Duration. But, here are the relevant lines in the backtrace:

14: time:: date::Date::from_julian_day
at ./<::std::macros::panic macros>:5
15: <time:: date::Date as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/date.rs:1027
16: <time::primitive_date_time::PrimitiveDateTime as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/primitive_date_time.rs:549
17: <time::offset_date_time::OffsetDateTime as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/offset_date_time.rs:768

Are there any tools that would allow me to perform something along the lines of a crater run? If I could manually give something a list of libraries (starting with all reverse dependencies) and ensure that there are no regressions, that would be ideal.

Besides crater itself, not that I know of, but writing such a script yourself wouldn't be too difficult, for instance using cargo-edit-locally.

External review is far from perfect — we don't need to look any further than the standard library where breaking changes have been introduced (without an FCP) on the unverified assumption that it wouldn't break anything. This is precisely what occurred with overflow checks on Duration arithmetic.

Changes to the standard library don't make it to stable for ~12 weeks after they're introduced, allowing time for catching bugs. What's more, one can easily roll back to an older version. Changes to this library affect all of its dependencies immediately, and rolling back a transitive dependency can be difficult.

I could not conceive of a single use case where one would actively want a Duration to overflow, given it is capable of storing lengths of time vastly longer than the age of the universe, and it does not appear that this is the cause of the CI failure in the cookie crate.

Unfortunately it doesn't matter if it's reasonable behavior or not. What matters is what's specified. In this case, even now, it's not specified that year needs to be within a given range, neither in Duration nor OffsetDateTime nor PrimitiveDateTime. As it stands, it is impossible to know, aside from reading the code or running into this issue inadvertently, that a panic can happen under any Add operation. What's more, I'd argue that this is incredibly odd behavior for a time library: nothing should ever panic; something reasonable should always happen. For instance, if you must cap the year (why do you need to?), then simply bound the year or wrap around. But panicking is incredibly odd.

The error is:

thread 'tests::format' panicked at 'year must be in the range -100000..=100000 (was 219250468)', <::std::macros::panic macros>:5:6

Looking at the test, it's obvious this comes from Duration. But, here are the relevant lines in the backtrace:

14: time:: date::Date::from_julian_day
at ./<::std::macros::panic macros>:5
15: <time:: date::Date as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/date.rs:1027
16: <time::primitive_date_time::PrimitiveDateTime as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/primitive_date_time.rs:549
17: <time::offset_date_time::OffsetDateTime as core::ops::arith::Addtime::duration::Duration>::add
at .cargo/registry/src/github.com-1ecc6299db9ec823/time-0.2.9/src/offset_date_time.rs:768

As I suspected, it does originate from Date (see line 14). A Duration has no concept of a "year", let alone with a fixed epoch. What is happening is you're adding a Duration to a PrimitiveDateTime (and therefore Date), causing the year to go out of the valid range.

Besides crater itself, not that I know of, but writing such a script yourself wouldn't be too difficult, for instance using cargo-edit-locally.

Thanks, I wasn't aware of that crate. I'm definitely going to take a look into this, along with possible integration into CI. If I can get it to work with GitHub Actions, I should be able to trigger it via a variety of methods.

Changes to the standard library don't make it to stable for ~12 weeks after they're introduced, allowing time for catching bugs. What's more, one can easily roll back to an older version. Changes to this library affect all of its dependencies immediately, and rolling back a transitive dependency can be difficult.

Ironically, this still isn't perfect. There have been plenty of stable-to-stable regressions. But that's not the point here, so there's no purpose in continuing. If I can get an automated crater-like system for time, it should catch a variety of real-world use cases.

What's more, I'd argue that this is incredibly odd behavior for a time library: nothing should ever panic; something reasonable should always happen. For instance, if you must cap the year (why do you need to?), then simply bound the year or wrap around. But panicking is incredibly odd.

It is my intent to saturate Dates in 0.3. Times already wrap. UtcOffset methods will return a Result, as macros now provide the capability for values known at compile-time.
The reasoning for capping the year was to allow for the possibility of restructuring internally, namely bitpacked fields. I still haven't ruled it out, but I'd want to do some performance checks first.


Matlab R2017a pdf generation fails

I found a similar error reported by tonegas, but his was resolved by updating to the master copy, which has not had any discernible positive effect on my installation:
>> export_fig test.pdf
Error using eps2pdf (line 107)
Error: /undefined in bdef
Operand stack:
   dom   --nostringval--
Execution stack:
   %interp_exit   .runexec2   --nostringval--   --nostringval--   --nostringval--   2   %stopped_push
   --nostringval--   --nostringval--   --nostringval--   false   1   %stopped_push   1932   1   3
   %oparray_pop   1931   1   3   %oparray_pop   1915   1   3   %oparray_pop   1803   1   3   %oparray_pop
   --nostringval--   %errorexec_pop   .runexec2   --nostringval--   --nostringval--   --nostringval--   2
   %stopped_push   --nostringval--
Dictionary stack:
   --dict:1185/1684(ro)(G)--   --dict:0/20(G)--   --dict:77/200(L)--
Current allocation mode is local
Current file position is 64
GPL Ghostscript 9.07: Unrecoverable error, exit code 1

Error in export_fig (line 406)
        eps2pdf(tmp_nam, pdf_nam, 1, options.append, options.colourspace==2, options.quality);

In my case, the culprit was the very old version of export_fig, which I had no recollection of.
which('export_fig') helped me find it.
On a separate note, export_fig produces much worse output than matlab print, when you have transparency. It looks OK in the viewer, but after including it into a LaTeX document, it looks horrible. Even the box around the graph (I have a 3D mesh) has gaps in it and wiggly bits. png looks a bit better than eps, but worse than pdf. Has very noticeable fuzziness.


Fix broken Scala.js test

Current coverage is 78.72%

Merging #243 into master will increase coverage by +0.17% as of b50e9dd

Powered by Codecov. Updated on successful CI builds.


constructor arguments

Regarding the pull request #20 and #21, it is recommended to pass the mandatory parameters of the Kaufland class (keys, locales, storefront, client) as constructor arguments. This prevents inconsistent states that have to be checked at high cost.
However, since this causes compatibility breaks, this should be planned for the upcoming major version.

You can see the possible result at https://github.com/SeifertDaniel/kaufland-php-client/tree/features/kaufland-v2_refactored. If you would like to adopt this as a PR, please leave a message.


Chrome extension

api.helper.get.visible_emails_pre function: 'start' returns NaN as gmail have changed their markup.
suggest replacing the current evaluation with this:
`//var start = $(".aqK:visible .Dj").find("span:first").text().replace(",", "").replace(".", "");
	var start = 0;
	//if gmail changes again startdiv could be undefined
	var startdiv = $('div[class^="J-J5-Ji amH"][role="button"][aria-expanded="false"]')[0];
	if(typeof startdiv != 'undefined'){
	  //if gmail changes again startdiv_2 could be undefined
	  var startdiv_2 = startdiv.childNodes[0].childNodes[0].childNodes[0];
	  if(typeof startdiv_2 != 'undefined'){
	    //this will return string... *1 to make '151' numeric. If it returns anything else it won't be numeric. ( parseInt() is problematic as testing for NaN is difficult.... )
		start = startdiv_2.innerHTML.trim()*1;
	    if(Number.isInteger(start)){
	        start = start - 1;
	    }
	  }
	}
    if ( (start > 0) ) {
        url += "&start=" + start +
               "&sstart=" + start;
    } else {
        url += "&start=0";
    }`

There seems to be some errors with this PR. The diff doesn't make any sense, and it doesn't contain any actual commits made by you.
Can you try recreating one from scratch, and maybe use Github's web-editor to make your changes if you're unfamilier with git's command-line interface?

It also appears that on top of updating the core library functions, the PR is adding the sample chrome extension to this repo as well. I'd suggest that we keep the chrome extension code to the boilerplate repo


Update operators.mdx

Description
Appears that https://flow.bigdipper.live/ isn't working, removing link

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

closing, effort not needed at this time, migrating to new dev portal.


Postage stamp indexing

this PR extends postage stamps with indexes

indexes enable replacing stored chunks at the discretion of the owner: storer nodes store  only the latest chunk stamped with the same stamp (same batch same index)
offer an easy way to catch overissuance as part of stamp validity check
makes it possible to limit spoofing density proofs by mining chunks to a batch
makes it possible to transfer ownership of arbitrary indexes

the index is a 64-bit serialisation of

bucket depth (uint8, 1st byte, <24)
bucket index (neighbourhood index, uint32 <2^depth, bytes 2-4)
and the within-bucket index (uint32 <2^(batchdepth-bucketdepth), bytes 5-8)

superceded by #1625


MSID: 96515 Version: 1 DOI: 10.1101/2<IP_ADDRESS>7365

MSID: 96515
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>7365
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=96515
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>7365

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/96515v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>7365
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/96515/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

duplicate content in reference, otherwise fine to QC

Thanks @rkcook312. Pretty sure the authors mean to cite https://doi.org/10.1152/jn.19<IP_ADDRESS>3.  I'm going to update that particular ref. This should be good to go in a couple of hours.

Hi @fred-atherden, somethings going wrong with the preview link, its going to 90972 but the link says 96515?

No worries, I tried a hard refresh but still the same for me.

Preview link is correct now, seeing the same as screenshot, thanks!


.NET 9 locking

Ah!  I thought I fixed this.  Will correct soon.

Wait.  I'm confused.  What's wrong with the implementation as-is?
Why would I introduce another dependency?

It's a source generator and won't add a transitive dependency.

Ok, but how will it make anything better than how it is?

It will allow you to use the full feature set of System.Threading.Lock rather than be limited to just the lock keyword. For more information please take a look at https://github.com/MarkCiliaVincenti/Backport.System.Threading.Lock?tab=readme-ov-file#why-not-keep-it-simple

Ok.  Thanks for the intro.  But I see no reason or benefit to introduce this here.
Curious why you thought it would be an improvement for this repo.


Request sample outputs differently according to paths in swagger.json

I have a Jersey API running on a Grizzly server and have recently starting using swagger to annotate it and ReDoc to output the swagger. Most of the endpoint requests and responses are output as expected with readonly fields in the response but not the request, except for one PUT operation in a certain class called Partner, which outputs all fields (readonly as well as not) in the request, same as the response.
I was able to easily recreate this issue in a new test project I created and noticed that removing the GET operation from this Partner class caused the PUT request to remove the readonly fields from the request and so behave how it should. I added the GET back in to check and the readonly fields were coming through in the request sample again.
Each time the request body in the middle area is correct and does not display the readonly fields, just the request samples on the right hand side.
The swagger.json that produces the incorrect request sample is as follows:
{ 	"swagger": "2.0", 	"info": { 		"description": "Provides endpoints", 		"version": "1.0", 		"title": "API" 	}, 	"host": "localhost:443", 	"basePath": "/v1", 	"tags": [{ 		"name": "Partner", 		"description": "Partner operations" 	}], 	"schemes": ["http", 	"https"], 	"consumes": ["application/json"], 	"produces": ["application/json"], 	"paths": { 		"/partner/{partner_id}": { 			"put": { 				"tags": ["Partner"], 				"summary": "Update Partner", 				"description": "Updates a partner as specified in the PUT payload", 				"operationId": "update", 				"consumes": ["application/json; charset=utf-8"], 				"produces": ["application/json; charset=utf-8"], 				"parameters": [{ 					"name": "partner_id", 					"in": "path", 					"description": "ID of partner to be updated", 					"required": true, 					"type": "integer", 					"format": "int32" 				}, 				{ 					"in": "body", 					"name": "partner", 					"description": "PartnerFacade object that needs to be updated in the database", 					"required": true, 					"schema": { 						"$ref": "#/definitions/PartnerFacade" 					} 				}], 				"responses": { 					"200": { 						"description": "Partner updated", 						"schema": { 							"$ref": "#/definitions/PartnerFacade" 						} 					}, 					"400": { 						"description": "Invalid Partner object supplied" 					} 				}, 				"security": [{ 					"basicAuth": [] 				}] 			} 		} 	}, 	"definitions": { 		"PartnerFacade": { 			"type": "object", 			"properties": { 				"enabledFl": { 					"type": "boolean", 					"example": true, 					"default": false 				}, 				"logoUrl": { 					"type": "string", 					"example": "http://example.com/url-of-logo" 				}, 				"name": { 					"type": "string", 					"example": "Partner 1" 				}, 				"partnerId": { 					"type": "integer", 					"format": "int32", 					"example": 100, 					"readOnly": true 				}, 				"salesforceId": { 					"type": "string", 					"example": "123456", 					"readOnly": true 				} 			} 		} 	} }

And the swagger.json that produces the correct request sample is as follows:
{ 	"swagger": "2.0", 	"info": { 		"description": "Provides endpoints", 		"version": "1.0", 		"title": "API" 	}, 	"host": "localhost:443", 	"basePath": "/v1", 	"tags": [{ 		"name": "Partner", 		"description": "Partner operations" 	}], 	"schemes": ["http", 	"https"], 	"consumes": ["application/json"], 	"produces": ["application/json"], 	"paths": { 		"/partner/{partner_id}": { 			"get": { 				"tags": ["Partner"], 				"summary": "Get Partner", 				"description": "Gets a partner with the given id", 				"operationId": "get", 				"produces": ["application/json; charset=utf-8"], 				"parameters": [{ 					"name": "partner_id", 					"in": "path", 					"description": "ID of partner that needs to be retrieved", 					"required": true, 					"type": "integer", 					"format": "int32" 				}], 				"responses": { 					"200": { 						"description": "Partner retrieved", 						"schema": { 							"$ref": "#/definitions/PartnerFacade" 						} 					}, 					"400": { 						"description": "Invalid partner ID supplied" 					} 				}, 				"security": [{ 					"basicAuth": [] 				}] 			}, 			"put": { 				"tags": ["Partner"], 				"summary": "Update Partner", 				"description": "Updates a partner as specified in the PUT payload", 				"operationId": "update", 				"consumes": ["application/json; charset=utf-8"], 				"produces": ["application/json; charset=utf-8"], 				"parameters": [{ 					"name": "partner_id", 					"in": "path", 					"description": "ID of partner to be updated", 					"required": true, 					"type": "integer", 					"format": "int32" 				}, 				{ 					"in": "body", 					"name": "partner", 					"description": "PartnerFacade object that needs to be updated in the database", 					"required": true, 					"schema": { 						"$ref": "#/definitions/PartnerFacade" 					} 				}], 				"responses": { 					"200": { 						"description": "Partner updated", 						"schema": { 							"$ref": "#/definitions/PartnerFacade" 						} 					}, 					"400": { 						"description": "Invalid Partner object supplied" 					} 				}, 				"security": [{ 					"basicAuth": [] 				}] 			} 		} 	}, 	"definitions": { 		"PartnerFacade": { 			"type": "object", 			"properties": { 				"enabledFl": { 					"type": "boolean", 					"example": true, 					"default": false 				}, 				"logoUrl": { 					"type": "string", 					"example": "http://example.com/url-of-logo" 				}, 				"name": { 					"type": "string", 					"example": "Partner 1" 				}, 				"partnerId": { 					"type": "integer", 					"format": "int32", 					"example": 100, 					"readOnly": true 				}, 				"salesforceId": { 					"type": "string", 					"example": "123456", 					"readOnly": true 				} 			} 		} 	} }

The issue you've reported has been fixed since ReDoc version v1.6.0.
I've just checked your sample on our demo page and it works as expected.
Please update to the latest version.

Thanks - I still had 1.5.2 in my project - will be updating it more regularly now

@lucychild I suggest you to wait for the next minor release which will be released in an hour.
The current has some critical issues :(

Will do - thanks!

v1.6.1 is available now


Make the app trust proxy

Trust the proxy (http://expressjs.com/en/guide/behind-proxies.html)

This is specifically an issue for us because... we use nginx


Changes codegen for failing IL generation tests for generic comparison

These are the changes needed to fix the last failing tests mentioned here: https://github.com/Microsoft/visualfsharp/issues/915
@manofstick The changes are the removal of tailcalls in some generated IL code due to the recent changes in IL comparison in FSharp.Core.
I've looked at these cases carefully and they all look OK to me: tailcalls are not taken further down the chain in any case, or the structures involved are not recursive. The tailcalls are not an essential part off the specification of the generated code in these particular cases.

@dsyme
Hmmm... This spans both the philosophical and practical.
I'll lay out the thought processes, and maybe this can lead us to the "best" solution.
Why remove tail?

On 64-bit JIT for value types > 64-bit there can be a significant performance cost when included. This cost can be greater than an order of magnitude over the underlying equality (compare/gethashcode) operation.

Why insert tail?

For recursive functions we can end up blowing the stack otherwise
Potentially we can have performance improvement due to less cache bleeding out of cache.

What about the real world?

Equals/CompareTo/GetHashCode are unlikely to be written using recursive calls that require the tail call instruction. i.e. list<> Equals gets rewritten by the compilers as an imperative loop.
But; personally I have found value types to mostly be more trouble than they are worth (i.e. unmeasurable performance improvements).
Except when < 64 bit
Except when used in big chunks in arrays
Except when passed around by reference (which means marking as mutable)

My thoughts from typing this?
Argh, don't ask me for my opinion! OK, well if I have to. Given that making values types useful (i.e. performance improvement) requires lots of bending over backwards currently anyway, I think that removing tail from the standard equality operations is probably more risky that it's worth, even though I think it unlikely that any "real" type would require tails functionality. This does perpetuate the bad name that values types have though, condemning them basically to always remain a second class citizen. (i.e. you should never basically use them in standard contexts)
(A possibly way out of this malaise might be a parallel interfaces along the lines of:
type IEquatableValueType<'T> =
    abstract Equals : byref<'T> -> bool

type IComparableValueType<'T> =
    abstract CompareTo : byref<'T> -> int

which could be created at some stage would would bypass the problem by only passing reference cells which would be "tail" safe, as well as fast. (Purely theoretical, I haven't persued this line in reality; probably would have to be an alternative operator, as existing operators will all act on the actual type...))

@manofstick My concern is that we just keep things exactly as they were before (no regressions) for the cases we care about.
These are mostly about generic hash, compare and equality on structures such as
type List<'T> = Nil | Cons of 'T * List<'T>

and similar recursive types.  These generally tailcall via direct jumps within the critical routine, hence coping with very long lists.  Please check there are no changes in tailcalling here - I don't think there are.
The problem with removing tailcall would with mutually recursive types of a similar "right-heavy" shape, e.g.
type List<'T> = Nil | Cons of ListData<'T>
and ListData<'T> = ListData of 'T * List<'T>

The type List<'T> still effectively appears in "tail position" within the recursive type.  I believe we are still tailcalling here or at least there is no change in codegen.  But please check.  I poked around a bit myself looking at the diff between old and new in these cases and I think they are fine. If those two cases (and any variations are covered then I think I'm comfortable, unless someone points out a specific test case where behaviour has changed
So, could you poke around with testing and determine if there has been actual behaviour change here I'd be grateful.
thanks
don

...this message is just part of some notes as I explore the space, [1 of n]...
Functionality in code below is unchanged from current release to master.
Note is: If you don't "tail" tuples on recursive union types then you will blow up with stack overflow. Side note: possibly worth of a warning (to blow up code below #define WANT_PROGRAM_TO_STACKOVERFLOW)
type List<'T> = Nil | Cons of ListData<'T>
#if WANT_PROGRAM_TO_STACKOVERFLOW
and ListData<'T> = ListData of List<'T> * 'T
let createListData a b =
    ListData (a, b)
#else
and ListData<'T> = ListData of 'T * List<'T>
let createListData a b =
    ListData (b, a)
#endif

let rec createList make n l  =
    if n = 0 then l
    else createList make (n-1) (createListData (Cons l) (make n))

let lots = 1000000

let make n =
    n, float n, float32 n, int64 n, decimal n

let a0 = createList make lots (createListData Nil (make 0))
let a1 = createList make lots (createListData Nil (make 0))
let b = createList make lots (createListData Nil (make -1))

let sw = System.Diagnostics.Stopwatch.StartNew ()

let good = a0 = a1 && a0 <> b && a1 <> b

System.Console.WriteLine ("{0} ({1})", good, sw.ElapsedMilliseconds)

Side, side note: When not blowing the stack, this is another good example of performance improvement of #513 ! :-)

@dsyme

First, was the removal of tailcall deliberate here, or just an outcome of the changes in FSharp.Core? Thx

It is more an outcome of changes of FSharp.Core. That was deliberate, because testing with > 64 bit value types had proven a performance bottleneck that I was trying to eradicate. But I didn't think though the ramifications that all generated equality/comparison operators through all bits of code would then be affected.

@dsyme
BADNESS! ...modifying the example in note 1 with the Pair structure causes StackOverflow... I think I need to remove those eliminate_tail_calls....
type Pair<'T,'U> = Pair of 'T * 'U

type List<'T> = Nil | Cons of ListData<'T>
and ListData<'T> = ListData of Pair<'T, List<'T>>
let createListData a b =
    ListData (Pair(b, a))

let rec createList make n l  =
    if n = 0 then l
    else createList make (n-1) (createListData (Cons l) (make n))

let lots = 1000000

let make n =
    n, float n, float32 n, int64 n, decimal n

let a0 = createList make lots (createListData Nil (make 0))
let a1 = createList make lots (createListData Nil (make 0))
let b = createList make lots (createListData Nil (make -1))

let sw = System.Diagnostics.Stopwatch.StartNew ()

let good = a0 = a1 && a0 <> b && a1 <> b

System.Console.WriteLine ("{0} ({1})", good, sw.ElapsedMilliseconds)

@dsyme
Actually there is current release badness too! If I change those equals to getting the hash, then current release blows up as well!
type Pair<'T,'U> = Pair of 'T * 'U

type List<'T> = Nil | Cons of ListData<'T>
and ListData<'T> = ListData of Pair<'T, List<'T>>
let createListData a b =
    ListData (Pair(b, a))

let rec createList make n l  =
    if n = 0 then l
    else createList make (n-1) (createListData (Cons l) (make n))

let lots = 1000000

let make n =
    n, float n, float32 n, int64 n, decimal n

let a0 = createList make lots (createListData Nil (make 0))
let a1 = createList make lots (createListData Nil (make 0))
let b = createList make lots (createListData Nil (make -1))

let sw = System.Diagnostics.Stopwatch.StartNew ()

let good = (hash a0 = hash a1) && (hash a0 <> hash b) && (hash a1 <> hash b)

System.Console.WriteLine ("{0} ({1})", good, sw.ElapsedMilliseconds)

Very bad badness... I removed all my eliminate tail call calls and was still getting stack overflow errors. I've had a small investigation into what is the cause of the problem and it appears that in my building block types the compiler isn't adding tail.
Now I'm currently at my daughter's swimming lessons and not sure if I'll get another chance to get to code today, but I hope that my initial investigation is wrong or it's a compiler bug, as opposed to some fundamental reason. I.e. being able to tail call on a constrained type call. Otherwise I might be in trouble here...

Here is a version of the issue (not a particularly great example of programming; but should recurse until it gets a null reference exception; but doesn't. Gets a stack overflow)
type SomeConstrainedTypeCall<'a when 'a : null and 'a :> System.IEquatable<'a>>() =
    member __.ShouldBeTailable (x:'a, y:'a) =
        x.Equals y

[<AllowNullLiteral>]
type ListOfSorts(parent:ListOfSorts) =
    member __.Next = parent
    interface System.IEquatable<ListOfSorts> with
        member this.Equals other =
            let e = SomeConstrainedTypeCall<ListOfSorts> ()
            e.ShouldBeTailable (this.Next, other.Next)

let rec createList n l  =
    if n = 0 then l
    else createList (n-1) (ListOfSorts l)

let a0 = createList 100000 (ListOfSorts null)
let e = a0 :> System.IEquatable<ListOfSorts>
let value = e.Equals a0

So the problem is that ShouldBeTailable does not get a tail. The IL is as follows:
IL_0000: nop
IL_0001: ldarg.1
IL_0002: stloc.0
IL_0003: ldloca.s 0
IL_0005: ldarg.2
IL_0006: constrained. !a
IL_000c: callvirt instance bool class [mscorlib]System.IEquatable`1<!a>::Equals(!0)
IL_0011: ret

This is a REALLY BIG PROBLEM. Hmmm... I'm thinking I might have backout #513 if can't mix constrained with tail...

@manofstick I'm closing this in favour of https://github.com/Microsoft/visualfsharp/pull/941.  We will likely commit the updates to the tests, and then open a separate issue about whether the tailcall issue means we need to backout #513 for now


Feature/add references

Hey as discussed, here are the proposed changes to add references to collections.
Essentially it is now possible to convert all items in a collection to references. These references are stored inside Addressables.

It is then possible to add references or items to the collection by using the add (plus) button:

For the sake of simplicity, I'll provide examples using the names of the Weapons collection shown in the screenshots.
The conversion process entails several steps:

Marks every ScriptableObjectCollectionItem of the collection as Addressable. An Addressable group is created (or reused) for this scenario.
Creates new item base class type (WeaponBase).
Creates a new reference class type (WeaponReference) as inherits the new item base class (WeaponBase).

This reference class contains a reference object that only contains a GUID to the target item.

Swaps the the base class (ScriptableObjectCollectionItem) of the item class ( WeaponBase) for the new base class ( WeaponBase). This step does not fully regenerate the class, it just finds and replaces the base class type.
Updates the collection class (WeaponCollection) swapping the type argument of the generic collection class (previously Weapon) for the new base class (WeaponBase).

This also does not fully regenerate the class. (if the developers wrote code in the collection class it won't be overridden)

Creates scriptable object items of the reference class. These SOs are created in a new directory named "References" next to the Item collection directory.
Regenerates the static class code.
Once the process is complete, developers can use the Load util method provided for each item on the static class (example LoadAK47()) to load the item.

Some advantages of the reference system:

[+]Unified solution that can be applied to any collection the same way
[+]The only thing getting into the resources are GUIDs
[+]Automatically sets the required assets as addressables in a isolated group
[+]More control, can partially load/unload collections

Additionally, this PR includes fixes to the core system that I've stumbled upon testing the references feature.
Keep in mind this is the first iteration and more improvements are possible in the horizon. (For example, better editor UI to manipulate references in the collection)
Also as you asked, I've updated the wiki. But this update is only in my fork (Not possible to create a PR to the wiki repo nor I have permissions to push commits to it)

Awesome! I will get the branch and do some local tests with it, but overall looks really good!

Thank you for the review, glad you liked it!
All the comments have been addressed. I have also made some minor improvements and fixes which were mostly code styling related.


Issue #373

Summary
Add a new field (city) into Dataframe so that we can tell which city the current dataset is inside MapViz. Change index.tsx and socrataResultsToDataframe.ts files accordingly so that we can get the city abbreviation. Add a json file to store location of each city (for now, it only has Chicago and New York).
Screenshots or Videos (if applicable)
Example of what it looks like when click on map under visualize tab for a dataset in Chicago.

Example of what it looks like whne click on map under visualize tab for a dataset in New York.

Related Issues
N/A
Test Plan

Go to Explore
Choose a city (Chicago or New York)
Click on any dataset
Click on Visualize tab
Change to map
It should zoom in whichever city of the dataset that you choose on step 2 (only works for Chicago and New York for now)

Checklist Before Requesting a Review

[ ] I have performed a self-review of my code
[ ] My code follows the Style Guidelines and Best Practices outlined in the project wiki
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made changes to the documentation, if applicable
[ ] My change generates no new warnings or failed tests
[ ] If it is a core feature, I have added thorough tests
[ ] I have implemented analytics, if applicable

Hi Juan, thank you for reviewing my pull request. I have changed my code as you requested. Please tell me if there is anything else that I need to change.


[Macros] Name lookup and type checking fixes for freestanding declaration macros

Introduce two significant fixes for freestanding declaration macros:

Ensure that we do not check the arguments of a freestanding declaration macro twice
Fix name lookup in macro arguments by adding them to the ASTScope tree

Fixes rdar://107388151.

@swift-ci please smoke test


Bugfixes: save related note/record, missing table headers in view context

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


[Chore]: Clean up VIRIDIS usage in workflow components

We added a colour coordination for simulate operations around the time of the July hackathon, currently this is both a) not really working, and b) no longer needed because simulate ops no longer take in multiple config. If we need to have a colour coordination scheme later we will redo it properly.
We should:

Remove VIRIDIS_14 and associated functions from tera-workflow.vue
Remove VIRIDIS_14 and associated functions from tera-workflow-node.vue

It would be useful to keep the utils for VIRIDIS as we are going to use it for the border colours of tasks withing a drilldown modal.

It would be useful to keep the utils for VIRIDIS as we are going to use it for the border colours of tasks withing a drilldown modal.

We have like 3 or 4 (possibly different) VIRIDIS palettes all used independently - so I would rather clean house than to figure out which VIRIDIS might be the correct version.


mocks: update list, fix unexported interfaces in bfd

During various refactors (e.g. #3862), some of the mocks were updated without updating the list of mock targets in tools/gomocks. Fixed by semi-manually syncing the mock target list with the actually existing mocks.
The interfaces in go/pkg/router/bfd/ were not directly exported and gomock refused to generate the mock code.

This change is

/rebase


"illegal instruction (core dumped)" running all demos

Configure the project with CMake 3.10.2, and compile with make 4.1 and gcc (Ubuntu 7.5.0-3ubuntu1 ~ 18.04) 7.5.0, and when I try to run the demos I get the following error:

./SPHSimulator
Illegal instruction (core dumped)

This might be an AVX issue. Try to reconfigure the project with -DUSE_AVX=Off and build afterwards. You may have to do a complete reconfigure (delete CMakeCache.txt) for this to work.

Good, I compiled the program again and the error was solved, but I still do not see the demos now I get this error:

./SPHSimulator ../data/Scenes/DamBreakModel.json
Initialize dynamic boundary simulation
Initialize fluid particles
Number of fluid particles: 5054
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
X Error of failed request:  GLXBadContext
Major opcode of failed request:  154 (GLX)
Minor opcode of failed request:  6 (X_GLXIsDirect)
Serial number of failed request:  48
Current serial number in output stream:  47
X Error of failed request:  BadValue (integer parameter out of range for operation)
Major opcode of failed request:  154 (GLX)
Minor opcode of failed request:  24 (X_GLXCreateNewContext)
Value in failed request:  0x0
Serial number of failed request:  47
Current serial number in output stream:  48

Seems to be an OpenGL issue. Can you run other OpenGL applications?


Es6 writebackindex fix

Hi I'd like to introduce some features I've added to elastalert:

As when using "use_query_terms" in flatline rule, it is only possible to aggregate on one field, I've added the new feature of elasticsearch v6 to use composite key ( https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-composite-aggregation.html ).
As the composite key may cause problem when using none ".keyword" fields with unindexed fields, you can configure the rule to use or not the ".keyword" field suffix with the following rule config :
" use_keyword_suffix: false/true "

As related to following issue : https://github.com/Yelp/elastalert/issues/1919 , it was not possible to detect whenever a "service" is back again when using flatline rule. As the state kept by elastalert in its writeback index doesn't change whenever the service is detected again. I added the possibility to write to elastalert writeback_index whenever a service is detected again. 2 more config rules are now possible in a flatline rule :
writeback_events_up_enabled: true => whether to write in elastalert writeback index whenever a service is detected again
event_up_rule_name_suffix: "_UP" => the suffix of the "rule_name" field that will be used when inserting in writeback_index
For example when creating a flatline rule alert named "Service Down", elastalert will write in writeback index a doc with the field rule_name set to "Service Down", a same doc will be written with the rule_name "Service_Down_UP" whenever the service is detected again.
So for instance you can create a frequency rule watching elastalert writeback with:
filter:

query_string:
query: "rule_name: Service\ Down_UP"
and it will notice you of services up again

As it is now possible to use_query_terms with composite keys, I've added the possibility to run the query at once (not sliced by buffer_time/run_every), very useful when combined with the new feature (not mine, but I've merged it here) of limit_execution where you can set cron for each rule.
rule config :
query_all_timeframe_at_once: true
Very useful when running a rule every hour for instance but your sliced query has a size of 1 min, instead of doing 60 sequential queries of 1 min, you can query your whole time frame at once.

use_timeframe_as_max_limit: true/false
This parameter allows to limit the starttime limit of a query. Imagine you want to check if services are up from 7:00 to 19:00. When using limit_execution cron, the rule will wake up at 7:00 and detect that is hasn't run for 12 hours, so it will queries the whole timeframe "gap" from 19:00 to 7:00. With this parameter , the start_time of the query will be the max between now - timeframe and the last query run.

Small bug fix with limit_execution, as the  "has_run_once" bool var may sometimes never be set and so the rule will never run

You appear to be trying to push the beta branch into master.
I would also suggest splitting this into multiple PRs (one for each feature) and change them to go to the beta branch


Analysis error - larvae

https://drive.google.com/file/d/1DniNag7JIZQbRIbfkUp6sPQbGTY6Tuzm/view?usp=sharing
This is our video.
The program is crashing for me. Can you please run this video for me and help me understand what the problem is?
Does the crash has anything to do with color of the background or the larvae?  or does larvae have to be black and the background has to be white?

Hi, I have updated easyFlyTracker and fixed the crash problem, please upgrade easyFlyTracker to the latest version(0.14.0).
Meanwhile, I also tested your video and found that it did not meet the optimal operation conditions of easyFlyTracker:
1, The camera is shaking. Please keep the camera stable.
2, There was a big change of light during the shoot. Please keep the light steady.
thanks.


Update code to support jose 4.x

Hi Curity Team,
Any plan to update this project to support jose 4.x. It seems to change many things since de 1.25 used in current version ?
It will be great if you can update this demo project to promote this lib.
Best regards

Hey @salievn,
Thanks for pointing that out! I've just released version 2.0.0 of our library with jose upgraded to 4.x. It simplified the code and made some classes redundant. The change did end up being a breaking one, but I hope it will not be that much of a problem. I also added a changelog which summarises the breaking changes.


Can I buy that used?

Stuff to figure out:

From an browser extension: Extract content from a page and search another page
How to do this in a smart phone browser
Tell users that this page is supported?
Tell users that you got results on i.e. FINN
Do an OR-search on specs from IKEA page
What kind of taxonomy does FINN have on their products
Grab geo-position of users device - use for searching within area (not state/county, but actual radius from where you are)
Which HTML tags on IKEA's page that are easiest to extract, no matter which product you are on.
GDPR: What can we do and what shouldn't we do. What do we need to tell the users.

Make some quick mockups - create a presentation:

Basic idea
More indepth idea: Why it may work very well for both the consumers, FINN and IKEA
How an easy and simple implementation could be (OR-search on title and description from IKEA)

Basic idea:

Tell me if this product is available used
IKEA - more realistic environmet friendly approach than greenwashing. Own part of the used sale market
FINN - Fewer, more qualified buyers on each product. Sellers are not fighting so much to be one of the top 10 results.

First a get request to check if any results
Then a link to the search results.


review and increase the capability labels for bpf-specific functions.

Is your feature request related to a problem? Please describe.
We have just looked at map_read, sys_info etc. labels, need to scan and identify more capability labels.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Closing as tracked here: https://github.com/eBPFDevSecTools/ebpf-projects-annotations/issues/21


Create packet class

Change the driver to use a class representing packets with communication support functions instead of a class representing communication alone.

do you want the class itself to handle sending and receiving, or can the send/receive code be in the driver?
If the class needs to handle sending and receiving, it will need a dedicated reference to the driver instance.

The easiest thing I can imagine is doing something like this:
struct VexProtocolPacket {
    unsigned char type, size, *data = new unsigned char[100];
    ~VexProtocolPacket {
        delete[] data;
    }
}
``` and from there replacing the methods that use the three fields with one like this. It also would probably eliminate the need for the buffer if coded correctly.

Am I misinterpreting this?


Notification system

We need some kind of visual notification system. Could be system-provided or custom.

Custom notification window is now implemented. OS-specific notifications depend on https://github.com/AvaloniaUI/Avalonia/issues/2155