Using tsyringe in migration file

Is your feature request related to a problem? Please describe.
Hi! First I would like to thank you, I've just set up your lib in the project of my company, this is dope!
I came across an issue when using tsyringe in db migration files
import 'reflect-metadata';

import { UsersRepository } from<EMAIL_ADDRESS>
import { autoInjectable, container } from 'tsyringe';

@autoInjectable()
class Migration {
    constructor(private userRepo: UsersRepository) {}

    // eslint-disable-next-line no-empty-function
    async up() {
        const users = await this.userRepo.find({ filter: { }});
        console.log(users.length);
        console.log('Migration up usersssss');
    }

    // eslint-disable-next-line no-empty-function
    async down() {}
}

const migration = container.resolve(Migration);

export async function up(): Promise<void> {
    await migration.up();
}

export async function down(): Promise<void> {
    await migration.down();
}

but when I try to run the migrations, I have this error
npx migrate up -f .env.local

Synchronizing database with file system migrations...
Failed to run migration with name '1' due to an error
Cannot read properties of undefined (reading 'find')

It's like, it can't resolve the class with the depedencies (userRepo is undefined here)
maybe its due to
Describe alternatives you've considered
I've considered to just instanciate class and not using tsyringe but it would be awesome to be able to do this.

It's ok I've found a workaround
I added a .swcrc file
{
    // this file is used for db migrations, the tool/package that we use to make our migration use SWC to compile the code
    "jsc": {
        "parser": {
            "syntax": "typescript",
            "decorators": true,
            "dynamicImport": true
        },
        "target": "es2022",
        "keepClassNames": true,
        "loose": true,
        "baseUrl": "./src",
        "paths": {
            "@config": [
                "config.ts"
            ],
            "@main": [
                "main.ts"
            ],
            "@helpers/*": [
                "helpers/*"
            ],
            "@microservices/*": [
                "microservices/*"
            ],
            "@modules/*": [
                "modules/*"
            ],
            "@plugins/*": [
                "plugins/*"
            ],
            "@services/*": [
                "services/*"
            ],
            "@agenda-jobs/*": [
                "agenda-jobs/*"
            ],
            "@tasks/*": [
                "tasks/*"
            ]
        }
    },
    "module": {
        "type": "commonjs"
    },
    "sourceMaps": true
}

and I use the keywork @inject provided by tsyringe and it works!
import { UsersRepository } from<EMAIL_ADDRESS>import 'reflect-metadata';

import { autoInjectable, container, inject } from 'tsyringe';

@autoInjectable()
class Migration {
    constructor(@inject(UsersRepository) private userRepo: UsersRepository) {}

    // eslint-disable-next-line no-empty-function
    async up() {
        const users = await this.userRepo.find({});
        ...
    }

    // eslint-disable-next-line no-empty-function
    async down() {

    }
}

const migration = container.resolve(Migration);

export async function up(): Promise<void> {
    await migration.up();
}

export async function down(): Promise<void> {
    await migration.do
```wn();
}


Feature Request: More customizations like font sizes and disabling favicons on timeline layout for a more simplistic look

So far i really like this app! In terms of simplicity, FeedMe (https://github.com/seazon/FeedMe) takes the cake (at least for me). I am using the "list" view with "summary" turned on. And that one is the main reason i still have my android around.
Now to my request:
I need more visible content, so i would like to disable the favicons (I only want to see white on black and nothing else). Also the read / unread indicator takes precious space. I think having the font of the read item greyed out would be sufficent. The indicator could be smaller and move down just next to the name of the feed.
The settings in timeline layout should consist of:

Favicons - toggle Switch
Font - Size slider
Headlines - Number of lines slider
Summary (or: first few sentences of the article) - Toggle Switch
Summary - Number of lines slider

Although i am pretty happy with article layout, it should also have settings like:

Font sizes

slider for headlines
slider for paragraphs

Title picture - Toggle switch
... just to name a few

Keep up the good work!

Thanks for the suggestion.  It looks like you put a lot of thought into it.
One of the things that we strive to avoid on NetNewsWire is overwhelming the user with configuration options.  It is very doubtful that we ever make the timeline as customizable as you suggest for this reason.  In fact, the main reason that the timeline is customizable on iOS is because of accessibility.  Large dynamic type sizes made our standard timeline layout unusable at larger sizes without some customization available to the user.
That isn't to say none of your suggestions will never be implemented.  I could see us allowing the feed icon (favicon) to be hidden.  (I've added issue #1877 to track this)  We might also implement an article image preview to the timeline.  See #1551.
As for customizing the article view, you'll be happy to see that is on the roadmap.  See issue #19.
Since this issue is too big to implement on its own and we largely have other issues that overlap it, I'm going to close it.


Error: Cannot find module 'glob'

cordova plugin add cordova-plugin-cocoapod-support --save
Fetching plugin "cordova-plugin-cocoapod-support" via npm
Installing "cordova-plugin-cocoapod-support" for ios
Saved plugin info for "cordova-plugin-cocoapod-support" to config.xml
~/app$ cordova build ios
Error: Cannot find module 'glob'
Any ideas, I also installed npm -g install glob, still the same issue

Can you run "npm list" in your project and post a gist of the output?  What
version of npm are you using? glob is a dependency of shelljs so it should
be available.
On Wed, Feb 1, 2017 at 1:42 AM, Jarratt<EMAIL_ADDRESS>wrote:

cordova plugin add cordova-plugin-cocoapod-support --save
Fetching plugin "cordova-plugin-cocoapod-support" via npm
Installing "cordova-plugin-cocoapod-support" for ios
Saved plugin info for "cordova-plugin-cocoapod-support" to config.xml
~/app$ cordova build ios
Error: Cannot find module 'glob'
Any ideas, I also installed npm -g install glob, still the same issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/blakgeek/cordova-plugin-cocoapods-support/issues/28,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyU3mZ_rAeoFbGGENtlrytga01Q4w0Fks5rYClUgaJpZM4LziiB
.

  Check out my
games on www.bggamecentral.com or download them from the App Stores
https://itunes.apple.com/us/artist/henry-lawton/id895605107
[image:
https://play.google.com/store/search?q=pub:BG Games&utm_source=global_co&utm_medium=prtnr&utm_content=Mar2515&utm_campaign=PartBadge&pcampaignid=MKT-Other-global-all-co-prtnr-py-PartBadge-Mar2515-1]
https://play.google.com/store/search?q=pub:BG Games&utm_source=global_co&utm_medium=prtnr&utm_content=Mar2515&utm_campaign=PartBadge&pcampaignid=MKT-Other-global-all-co-prtnr-py-PartBadge-Mar2515-1
Get it on Google
https://play.google.com/intl/en_us/badges/images/generic/en-play-badge.png

npm --v == 3.10.7
node v6.6.0
This is a much older project not ionic so there is actually no local node modules for this project.
I manually installed shelljs and restarted the console, it builds correctly now thanks


ContextMenu should be opened on the control that the mouse was released on

WPF ContextMenus seem to open on the control that the mouse was released on, not the control that it was pressed. So if you press right mouse button on control A and move to control B and release it there Avalonia will display the ContextMenu of control A.

@grokys @kekekeks PointerReleased is invoked only on that control, on which PointerPressed was initially invoked, and not on which pointer is over. How does it work in WPF?


Remove customBuilds, nixos-generate has --flake

nixos-generators now has --flake support, so theres no reason for us to export all the builds here. Lets just offload this responsibility to nixos-generators.
Somewhat blocked by nix-community/nixos-generators#138, so that we don't need to make our hosts overridable.

Nice. I had to work around customBuilds in the darwin-support branch since it's not usable on darwin hosts. I was going to propose via that branch that we make the module optional or loaded only for Linux hosts, but offloading it to nixos-generators is even better.

I used to use bud to generate ISOs for my configs, but now that https://github.com/nix-community/nixos-generators/pull/138 just closed, how do I use nixos-generate with this?
I'm using this PR and the latest commit of nixos-generators. I used nixos-generate -f iso --system x86_64-linux --flake .\#rog-bootstrap but it throws attribute 'extendModules' missing'. Does this have anything to do with the old bud behavior (see https://github.com/divnix/bud/blob/a789d710851441ba7e7cd59be378623b1fe05688/scripts/hosts-build.bash)?

The extendModules error is likely from your host being evaluated with an older version of the module system, so you would have to update to 21.11 or after. If you are already updated, then I'm not really sure whats wrong.
This is the the commit that added extendModules  https://github.com/NixOS/nixpkgs/pull/143207, so can you check to see if you have that commit. You can also investigate in nix repl, to see if extendModules is in your config.
I was able to build an iso with my host, and it seems like it includes my entire hosts closure in the iso. I think the install-iso format feasibly replaces our bootstrapIso with everything but the networking part. If that was to be upstreamed to nixos-generators, then we could remove bootstrapIso and isoConfig.

I can only find Flake.outputs.nixosConfigurations.<host>._module.args.extendModules, but not top-level extendModules. I forked https://github.com/danielphan2003/nixos-generators/blob/module-args-extendModules/nixos-generate.nix to use _module.args.extendModules instead, and it seems to work. I think this is a hack, so any idea why this happens?

Also remove https://github.com/Pacman99/digga/blob/2f6bcd38f148a8ffc367400de532f070a0a74294/flake.nix#L51 since we're not depending on nixos-generators for customBuilds.

bors try

bors try

#443

bors try

bors try

This should be ready to merge with NixOS/nixpkgs#166148 in which should fix @danielphan2003's error
Users will need to update their own nixpkgs input for the feature.


Clarify parser behavior

Parser was unterminated when multiple confs were given; fix by terminating.  This also left a few ambiguities open around whitespace handling in options, so make those explicit as well.  This also could have been fixed by allowing for an empty opt, but I didn't want to think about such an abomination.
What does this PR do?
Changes the behavior of the parser and adds a small number of clarifying tests.
Motivation
We had a warning during build.  This also makes the behavior more strict.
Additional Notes
No additional notes
How to test the change?
Tests included

Deleting in favor of #266 which is a more comprehensive fix.


Use XCTest private API to input text on iOS

Proposed Changes
Use XCTest private API "_XCT_sendString:maximumFrequency:completion:" instead of looking up the element and typing to the element.
In complex UI's the element lookup can fail. By using the private API the element lookup is no longer needed.
Testing

git clone git@github.com:curlyCoder15/AwesomeProjectMaestro.git
npm install -g npx
Install cocoa pods
Change the innermost  element in App.js to
npx react-native start
create a flow file with text input

appId: org.reactjs.native.example.AwesomeProject
---
- inputText: "Hello wørld 🙃"

maestro test flow.yaml

Something I've been thinking about - if a call to private API fails, do we want to fallback to a previous behaviour? I am a bit torn on that as in case of a fallback we won't really know whether that happened or not, possibly contributing to flakiness

Something I've been thinking about - if a call to private API fails, do we want to fallback to a previous behaviour? I am a bit torn on that as in case of a fallback we won't really know whether that happened or not, possibly contributing to flakiness

Internally XCTest will call the same method. I don't think we gain anything by falling back to the public API in case of an error.
The only case I can think of when the public API would work but the private fails, is when an Xcode update changes the private API. This is something we should test for when a new major beta release of Xcode is available.

Something I've been thinking about - if a call to private API fails, do we want to fallback to a previous behaviour? I am a bit torn on that as in case of a fallback we won't really know whether that happened or not, possibly contributing to flakiness

Internally XCTest will call the same method. I don't think we gain anything by falling back to the public API in case of an error.
The only case I can think of when the public API would work but the private fails, is when an Xcode update changes the private API. This is something we should test for when a new major beta release of Xcode is available.

Agree with everything here - sounds like we should just be diligent about proactively testing Xcode updates


Create wordpress recipe

show how to install MySQL and Wordpress (tutum/wordpress:latest) and connect these together (dependency?) from a Vamp blueprint, and have our VGA expose wordpress to the outside world (using virtual host name like https://docs.mesosphere.com/1.8/usage/tutorials/wordpress/ f.e.?)

@gggina let's use the wordpress tutorial to make a recipe for it


Max Length Subarray with sum k added

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
CPP solution for max length subarray with sum k added
Checklist

[ Yes] I've read the contribution guidelines.
[ Yes] I've checked the issue list before deciding what to submit.
[ Yes] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1813

Readme has been updated. please have a look.

Readme has been updated. please have a look.

@thevivekpande Are you still working on this? Please reply to reopen this PR.

@thevivekpande Are you still working on this? Please reply to reopen this PR.


MatAutocompleteList Filtering improvements

Add the possibility to handle large lists (e.g. using some database, using some API which filters data based on some text).
Proposed solution:
Having the next interface in MatBlazor:
public interface IAutocompleteSource<TItem>()
{
    IAsyncEnumerable<ITem> GetFilteredList(string inputText);
}

have a property of type IAutocompleteSource on the MatAutocompleteList which can be provided as a parameter instead of ItemsSource.
When the text value is changed, the items in the dialog will be updated based on the result of this alternative source if it exists.
What do you think about this?
If it's ok with you, I can implement this as I'm already using this approach in a Blazor Project.

@sandrohanea will this be another PR on top of your recent edits?

Yes, this is an idea of an improvenent. But after thinking about it maybe it's better to be done on the new Autocomplete component which is currently in progress. Who is working on that? @SamProf ? Is there anything I can do to help?


Samsung SSD 950 PRO 512GB fails (almost) every command

Strangely, all command but identify seems to fail on my Samsung SSD 950 PRO 512GB.
unvme: 1a671ccc46ee9c305f1805865dc9c944b20db018 (current as of today)
Host: Supermicro X11SAE w/Xeon E3-1275
OS: Ubuntu 16.04 (kernel 4.4.0-31-generic, gcc version 5.4.0)
The output and log from a successful identify (ns = 1 works too but isn't shown)
https://gist.github.com/ttDSSD-EMC/e0dd1cd78ba0adc08425085482f02b78
Any attempt at anything else fails.  Here's a get log example
https://gist.github.com/ttDSSD-EMC/4e35e763ec9ead574adfe727bdf1ff14
In desparation I tried the experiments suggested under Issue #7 but they had no effect (hacks to r64() and -O0).

Deyoung is out for a bit so responses may be delayed.
Do the admin cmds still fail if you change the NSID to 0?  Some controllers violate spec with respect to interpreting the NSID.
Maybe you could pull the error logs too?  One of the failed completions had the More bit set, suggesting some detail may be available in the logs.

Thanks, I tried that, but unfortunately the only command that seems to succeed is the identify.  In particular the get-log command fails for all arguments.  I tried the six [01] [123] combinations.
There's nothing usual in syslog.
It's not urgent, but I thought it mysterious and spent an hour trying to debug it.

Some observations: Looks like the failure of the nvme_mts_test is different.  Both my target devices (Intel 750 IIRC and the Samsung 950 PRO) have (intentionally) never been used prior.  The Samsung reports 0 blockcount (nuse):
$ nvme_identify 7:0.0 1
Identify Namespace
==================
nsze    :<PHONE_NUMBER>
ncap    :<PHONE_NUMBER>
nuse    : 0
nsfeat  : 0
nlbaf   : 0
flbas   : 0
mc      : 0
dpc     : 0
dps     : 0
lbaf.0  : ms=0   lbads=9   rp=0  (formatted)

and that seems to break assumptions in the code.  I still haven't decided if this is expected or not.

It looks like there is a problem with the drive.  If nuse is 0, UNVMe would fail to initialize.
However, for NVMe command examples, which is below the UNVMe layer, we've provided a couple examples of how to construct admin commands.  I don't have the Samsung 950 PRO drive, so I can't verify it.  Enabling UNVME_DEBUG to check the NVMe command and response, you can tell (as good as I can) if the command is correct or not, or the drive does or not conform to NVMe spec.
Sorry, I'm still on leave so I may be slow to respond.  Thanks.

I have a 950 PRO
I get the following output
$ test/unvme/unvme_sim_test 3e:00.0 (Fri Sep  2 11:30:08 MST 2016)
SIMPLE WRITE-READ-VERIFY TEST BEGIN
ERROR: vfio_create group not viable 0
ERROR: unvme_init vfio_create
ERROR: EXIT

$ sudo bash test/unvme-setup show
3d:00.0 Samsung Electronics Co Ltd NVMe SSD Controller - (mapped to nvme0)
3e:00.0 Samsung Electronics Co Ltd NVMe SSD Controller - (enabled for UNVMe)

# cat /dev/shm/unvme.log
unvme_init
ERROR: vfio_create group not viable 0
ERROR: unvme_init vfio_create
unvme_cleanup

I am running an Intel SkullCanyon NUC
*-core
description: Motherboard
product: NUC6i7KYB
vendor: Intel Corporation

What OS and kernel are you running?
$ cat /etc/system-release
$ uname -a

$ cat /etc/issue
Ubuntu 16.04.1 LTS \n \l
$ uname -a
Linux g-skull 4.4.0-36-generic #55-Ubuntu SMP Thu Aug 11 18:01:55 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

According to Alex Williamson (vfio owner), group not viable error indicates failure to access vfio device descriptor, possibly due to another device in the same group binding to another driver. Try
% unvme-setup reset
% unvme-setup 3e:00.0
If that doesn't work, check Alex posting http://vfio.blogspot.com/2014/08/iommu-groups-inside-and-out.html.  This is a vfio configuration issue, so you can ask Alex how 2 of your devices are in the same group and how to separate them.
On my system with multiple NVMe devices, each device belongs to a separate iommu group, so they can work with different drivers.

There are 2 different issues in this thread, and I want to check on the progress.  If you have info, please share, so others may benefit.

Hi ttDSSD-EMC.
Regarding the Samsung 950 PRO reporting the nuse value of 0.  For some SSD, after formatting, nuse may be 0 until a namespace is explicitly created specifying its size (create-ns).    And for the admin commands, have you tried using the nvme commands from https://github.com/linux-nvme/nvme-cli.git?

Hi cinterloper,
I'm assuming the "vfio_create group not viable" issue you have is due to certain configuration that does not allow 2 of your drives to use different drivers.  That should not be a problem if you run 'unvme-setup' without argument so both drives use the same driver.  Are they actually 2 physical SSDs or is it a virtual setup?

Thanks.


docs(server): show JSON deserialization in API example

The previous version only showed a JSON GET API.
Deserializing the body of a POST request is not
trivial so the example should show it.
The new example takes the JSON body sent in a
POST request, deserializes it, adds a field, then
serializes it and sends it back.

@seanmonstar Thanks for the review. Your comments make sense, I have fixed both.


Flight path generation - droneMapGUI

I've been trying to create a trajectory with the parrot mambo using the pyparrot library but I have not got it. Has anyone been able to achieve it? Im trying to recreate the trajectory to do some image processing and land the drone by using openCv library, but the only way out I have found is try to approximate the dron movement on pitch, yaw and roll and generate the "flight path" but its not very useful to me. Maybe I've thinkig if is possible to load the droneMapGUI map into the code in someway or load it into the mambo firmware and generate a kind of mission?.... Has anyone found out how to run the dronMapGUI with the drone?. Thanks.

mission stuff exists in the parrot SDK I believe.  I won't be releasing it since the GUI was entirely intended for my class and not really for the public release.

Amy, May I ask if your GUI class is available online?  If so, can you share the details?
Secondly,  are you aware of good talent with Python or C experience, Drone knowledgable, located on the east coast of the USA that is open to product development targeting a patent application?
As always, thank you for sharing your knowledge and information!

the droneMapGUI that was referenced above is just a quick script that my AI class uses as part of learning to do intelligent navigation.  It is in the GitHub repo in coursework.


Replace projectReference.path as relativePath

Fix https://github.com/yonaskolb/XcodeGen/issues/729

There is a test somewhere that validates that all the relevant relative paths are updated. Could you add this case to it as well?


Error when get token

I tried running it but it shows the log as below. I want to know what happens with this error. Could this be from the docker container I develop or something? Please give me advice ? Thank you !

You have to states what you are running and which version you are using.  Winthout any context, we can't help you.


CoffeeScript -> JS

This PR updates all coffeescript files to JS ES6 to be compatible with Hubot 3.

submitted to the wrong repo?

Hm, no it was as intended. We are relying on hubot-giphy downstream, but it is incompatible with the latest version of Hubot (3). This PR is intended to make this package work on Hubot 3.

ah sorry, i didn't realize this repo is what is published to npm.

it looks like the coffeescript linter is still being applied, you probably want to get rid of that too

Should I remove all coffeescript related build tooling and replace it with
the equivalent for ES? Can do that tomorrow when I have my laptop again.
Op ma 4 dec. 2017 om 19:07 schreef Pat Sissons<EMAIL_ADDRESS>
it looks like the coffeescript linter is still being applied, you probably
want to get rid of that too
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/patsissons/hubot-giphy/pull/14#issuecomment-349050600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFrDb234oVL67OLl83NFbWVl6HJ89mS4ks5s9DTMgaJpZM4Q0lMY
.

yea go ahead.

So that took a lot of figuring out, but eventually I got there. @patsissons check it out :smile:

Coverage decreased (-3.9%) to 96.067% when pulling 7df3f4fccf384d4c7c72df57527c2e050f135750 on WISVCH:develop into 64b23639c28c0bbb2ce4c90218c7840db198966a on patsissons:develop.

Coverage decreased (-3.9%) to 96.067% when pulling ad673e0bcc04b2bb0037e4fd9e36923803a72944 on WISVCH:develop into 64b23639c28c0bbb2ce4c90218c7840db198966a on patsissons:develop.


refactor: make crossplaneImage less special

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run earthly +reviewable to ensure this PR is ready for review.
[ ] Added or updated unit tests.
[ ] Added or updated e2e tests.
[ ] Linked a PR or a docs tracking issue to document this change.
[ ] Added backport release-x.y labels to auto-backport this PR.

Need help with this checklist? See the cheat sheet.

LGTM - tested thanks for this


Release v0.1.19

v0.1.19 Mar 21, 2018

More descriptive DFS progress bar (#69)
Convert text variable to string before NumWords (#106)
EntitySet.concat() reindexes relationships (#96)
Keep non-feature columns when encoding feature matrix (#111)
Uses full entity update for dependencies of uses_full_entity features (#110)
Update column names in retail demo (#104)
Handle Transform features that need access to all values of entity (#91)

Codecov Report

Merging #114 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   88.26%   88.27%   +0.01%
==========================================
  Files          73       73
  Lines        7457     7457
==========================================
+ Hits         6582     6583       +1
+ Misses        875      874       -1

Impacted Files
Coverage Δ

featuretools/utils/gen_utils.py
66.66% <0%> (+2.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5d9e4...d2e3de3. Read the comment docs.


ARROW-8486: [C++] Fix arrow-utility-test's failures on big-endian platforms

This PR supports big-endian platforms of bit operations such as Bitmap, BitRead, BitWriter, and others. Ths PR can fix arrow-utility-test's failures.
This PR still assumes that data layout in buffer is in little-endian. This PR converts data layout to native-endian to process data.
This PR also updates Bitmap.ShiftingWordsOptimization to support big-endian platform.

@pitrou would it be possible to review this?

retest this please

This PR can fix test failures in arrow-utility-tests as shown in
https://travis-ci.org/github/apache/arrow/builds/685085866#L2071
https://travis-ci.org/github/apache/arrow/builds/685085866#L2705
On exception is Bitmap.ToString. This is addressed by #7134
https://travis-ci.org/github/apache/arrow/builds/685085866#L2213

I will split this PR into multiple PRs. Each PR will focus on a different issue.

This PR can fix test failures in arrow-utility-tests as shown in
https://travis-ci.org/github/apache/arrow/builds/685085866#L2071
https://travis-ci.org/github/apache/arrow/builds/685085866#L2705
With this PR, the number of failed tests is reduced. BitArray.TestBool and BitArray.TestValue are succeeded.
https://travis-ci.org/github/apache/arrow/jobs/685247134#L8164


[storage-blob] Links, examples, and some doc fixes

GA doc check for storage-blob
Changes:

Added a few more samples to inline doc comments in storage-blob (if an example was in the README, I added it to the inline samples for related methods)
Added intra-package links to related types using @link syntax for everything I could catch. This should help make the docs a lot more navigable, as now most options types (which have their own HTML pages) link to their consumer methods as well as vice-versa.
Fixed occasional typos as I noticed them

CC @ramya-rao-a

Better check the typedoc output when removing either. I believe both are needed for a good looking rendering of example code.
Sent from my Windows 10 device
From: Will<EMAIL_ADDRESS>Sent: Tuesday, October 29, 2019 15:46
To<EMAIL_ADDRESS>Cc: Jeremy<EMAIL_ADDRESS>Review<EMAIL_ADDRESS>Subject: Re: [Azure/azure-sdk-for-js] [storage-blob] Links, examples, and some doc fixes (#5924)
@willmtemple commented on this pull request.

In sdk/storage/storage-blob/src/BlobClient.tshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fpull%2F5924%23discussion_r340361406&data=02|01|Jeremy.Meng%40microsoft.com|650df9716b964226d88008d75cc1d341|72f988bf86f141af91ab2d7cd011db47|1|0|637079859848811825&sdata=necRdvYq8sed10vB23mehte953msgN56fthclwOmTrw%3D&reserved=0:

@@ -1044,6 +1044,49 @@ export class BlobClient extends StorageClient {
* @param {BlobDownloadOptions} [options] Optional options to Blob Download operation.
* @returns {Promise}
* @memberof BlobClient

@example

Ramya and I resolved to leave the @examplehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fexample&data=02|01|Jeremy.Meng%40microsoft.com|650df9716b964226d88008d75cc1d341|72f988bf86f141af91ab2d7cd011db47|1|0|637079859848811825&sdata=NgTmtF0Zj7L%2BJNwBzyX%2BQ9td%2FFtD13KCDu6AiTzuFyM%3D&reserved=0 tag in for now, as the rest of the package does this as well. We will figure out what to do with @example vs markdown-body examples after GA, but it requires some more discussion and a more comprehensive review of all of our packages.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fpull%2F5924%3Femail_source%3Dnotifications%26email_token%3DABZ3QX4AV5QDH2AXTEURQBTQRC4L7A5CNFSM4JGQA4S2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJUR72A%23discussion_r340361406&data=02|01|Jeremy.Meng%40microsoft.com|650df9716b964226d88008d75cc1d341|72f988bf86f141af91ab2d7cd011db47|1|0|637079859848821818&sdata=m1fbS3PL554Kiob7%2BB7GnMQNc4%2FLNxftUhUf%2B3pZFfo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABZ3QX32BYU7AWBJVF2NQ5LQRC4L7ANCNFSM4JGQA4SQ&data=02|01|Jeremy.Meng%40microsoft.com|650df9716b964226d88008d75cc1d341|72f988bf86f141af91ab2d7cd011db47|1|0|637079859848821818&sdata=Cf6Rcw70EEgaL7rHHcVIbBxYs1dDCLvUX8vQ5MsIVuA%3D&reserved=0.


Trans eig output broken

Code like this is missing from trans eig:
https://github.com/mirnylab/cooltools/blob/34ba9a347010b614f483871baa74d29dbe23dd9d/cooltools/eigdecomp.py#L344-L348
It leads to this:
Traceback (most recent call last):
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/bin/cooltools", line 11, in <module>
    load_entry_point('cooltools==0.1.0', 'console_scripts', 'cooltools')()
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/exports/igmm/eddie/wendy-lab/ilia/condaenvs/Hi-C/lib/python3.6/site-packages/cooltools/cli/call_compartments.py", line 157, in call_compartments
    eigvals.to_csv(out_prefix + '.' + contact_type + '.lam.txt', sep='\t', index=False)
AttributeError: 'numpy.ndarray' object has no attribute 'to_csv'

should be working now


Scraping prometheus metrics endpoint crashes falco process

Describe the bug

Followed the prometheus support section in the docs to enable the /metrics endpoint. A soon as you make a request to this endpoint the falco process crashes without any indication on stdout/stderr what went wrong.
How to reproduce it

engine:
  kind: nodriver

metrics:
  enabled: true
  interval: 1h (also tried with 1m and waiting ~ 5 mins before /metrics request)
  output_rule: true
  rules_counters_enabled: false (tried with only this one enabled)
  resource_utilization_enabled: false (tried with only this one enabled)
  state_counters_enabled: false
  kernel_event_counters_enabled: false
  libbpf_stats_enabled: false
  convert_memory_to_mb: true
  include_empty_values: false

webserver:
  enabled: true
  k8s_healthz_endpoint: /healthz
  listen_port: 8765
  prometheus_metrics_enabled: true

Enabled debug logging as well:
libs_logger:
  enabled: true
  severity: debug
log_level: debug

This doesn't give any output when requesting the /metrics endpoint. So, it is not helping narrowing down what it happening just before it crashes.
This is what happens with a port forward to the falco pod:
% curl localhost:8765/healthz
{"status": "ok"}

% curl localhost:8765/metrics
curl: (52) Empty reply from server

After the /metrics request has been done, Kubernetes shows pod termination:
      lastState:
        terminated:
          exitCode: 139
          reason: Error

Expected behaviour

Expected to see some metrics, or at least not to crash the entire falco process.
Screenshots

Environment

Falco version: 0.38.0 (x86_64)

System info:

Cloud provider or hardware configuration:
OS:

Kernel:

Installation method: Kubernetes (docker.io/falcosecurity/falco-no-driver image)

Additional context

This is a dedicated github plugin instance of falco (running as a k8s pod), i.e. not using syscall at all (--disable-source syscall).
2024-05-31T09:43:33+0000: Loaded event sources: syscall, github
2024-05-31T09:43:33+0000: Enabled event sources: github
2024-05-31T09:43:33+0000: Opening event source 'github'

No clue if this has anything to do with the crash though.

I confirm the situation:

falco without a plugin: OK
falco with a plugin and no driver: KO

Each call to the /metrics endpoint crashes the falco container in the pod.

Also cc @incertum @sgaist

Opened the PR with the fix :point_up:

@sboschman thanks a bunch for testing it so promptly. We still have no good metrics support when running Falco with a plugin only. We should perhaps add a note to the website about that as well. For example CPU usage calculation still won't work for plugin only given a regression here: https://github.com/falcosecurity/falco/issues/2821

Also the Falco number of events won't be available atm in Prometheus as it would have required a major refactor and we ran out of time. Please follow this issue for things we spotted that we still need to address: https://github.com/falcosecurity/falco/issues/3194

I see @incertum , didn't realise running with plugin only has limited prometheus metrics support atm. Was indeed looking for cpu + memory metrics, and Rules Counters Fields (hoping to do something with total events processed and total rules matched, as to determine how much unnecessary events we sent to falco or missing rules we have)

I know yes it's annoying, we will work on that for Falco 0.39.0 plus we will offer custom plugin metrics system where you can emit custom plugin metrics when you write your own plugin. I'll CC you on that other issue so you stay in the loop.

on a side note @incertum , I also noticed that it is mandatory to enable the output rule (or output file I suppose) when using prometheus metrics output, which is not mentioned in the docs as requirement.
This config
  output_rule: false

results in falco failing to start with:
Error: Metrics are enabled with no output configured. Please enable at least one output channel

Is this already a known limitation or do you want me to open a separate issue for it?

on a side note @incertum , I also noticed that it is mandatory to enable the output rule (or output file I suppose) when using prometheus metrics output, which is not mentioned in the docs as requirement.
This config
  output_rule: false

results in falco failing to start with:
Error: Metrics are enabled with no output configured. Please enable at least one output channel

Is this already a known limitation or do you want me to open a separate issue for it?

uhhh no we messed up for sure on that. It should also work with you have prometheus enabled and no other output.
Adding this on the list for fixes. @FedeDP and @sgaist we could address that in the next patch release.
Thanks a bunch for your help Sverre on spotting these things!

/milestone 0.38.1


Deployment - New Environment Package

When attempting to deploy the new environment package into our sandbox instance the package deployer just sits at "Initializing 1 of 5 connection threads for detailed data import." The header status reads "Reading the Config file."
Any guidance here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c9cbb89-bde6-60dc-e5fb-10eca6fd0822
Version Independent ID: 0f4e2868-008b-2a73-3b0b-919bc2072bba
Content: Deploy sample Unified Service Desk for Dynamics 365 Customer Engagement applications using Package Deployer
Content Source: ce/unified-service-desk/admin/deploy-sample-unified-service-desk-applications-using-package-deployer.md
Service: dynamics-365-customerservice
GitHub Login: @kabala123
Microsoft Alias: kabala

@jdvachal : Reviewing your query. Will get back to you. Thanks for your understanding.

@jdvachal : Can you share the logs with us?

@jdvachal : Can you review the following items.

Can you check if the folder used has read/write permissions
Try another version of PD from another machine

What is the your Package Deployer version, CRM version and USD client version?

Im experiencing the same issue with USD <IP_ADDRESS>3 and CE Version 1710 (<IP_ADDRESS>46) online

HI Kabala,
Tried running as admin, although my user has full control over the folder, and the folder and all childs are not read only.
The USD package comes pre-packed with a specific version, any way of getting access to previous versions of usd 4?
Regards


Error Login

Forbidden (403)
CSRF verification failed. Request aborted.
More information is available with DEBUG=True.

Please provide more information

When I go to login it brings me to this error

Clear your cookies and try again

Tried that and still didnt work

I'm sorry, I do not see any issues on my end.


[BUG] PermissionsBoundary is not used to create IAM Role during module manifest deployment

Describe the bug
I have configured the IAM permissions_boundary in deployment manifest and it is being used to create the deployment role. However permissions_boundary is not used to create the module specific IAM role when it deploys a module manifest.
Please check log given below to investigate further. mdo.permissions_boundary_arn is coming None for manifest deployment[Deploy-0-sagemaker-studio-studio] at https://github.com/awslabs/seed-farmer/blob/ca53f4448b01415336af2c38351cf0d714154c4c/seedfarmer/commands/_deployment_commands.py#L201
To Reproduce
Use below manifest to deploy the sagemaker module
Deployment manifest
name: mlops-sagemaker
toolchainRegion: eu-west-1
forceDependencyRedeploy: true
groups:
  - name: sagemaker-studio
    path: manifests/mlops-sagemaker/sagemaker-studio-modules.yaml
targetAccountMappings:
  - alias: primary
    accountId:
      valueFrom:
        envVariable: PRIMARY_ACCOUNT
    default: true
    parametersGlobal:
      permissionsBoundaryName: plt/security/plt-devops-mlops
    regionMappings:
      - region: eu-west-1
        default: true
        parametersRegional:
          permissionsBoundaryName: plt/security/plt-devops-mlops

Sagemaker module manifest ->
name: studio
path: [modules/sagemaker/sagemaker-studio](git::https://github.com/awslabs/aiops-modules.git//modules/sagemaker/sagemaker-studio?ref=release/1.7.2&depth=1)
targetAccount: primary
parameters:
  - name: vpc_id
    value: vpc-123
  - name: subnet_ids
    value:
      - subnet-123
  - name: data_science_users
    value:
      - ds-user-1
  - name: lead_data_science_users
    value:
      - lead-ds-user-1
  - name: server_lifecycle_name
    value: studio-auto-shutdown
  - name: studio_bucket_name
    value: mlops-*
  - name: retain_efs
    value: 'False'
  - name: enable_custom_sagemaker_projects
    value: 'False'

Expected behavior
The configured permissions_boundary in deployment manifest should be used while creating any the IAM role as part of deployment of module manifest.
Screenshots
Below is the log items to help check the bug
[2024-12-09 11:09:58,239 | DEBUG | _deployment_manifest.py:461 | MainThread ] get_permission_boundary_arn permissions_boundary_name None
[2024-12-09 11:09:58,240 | INFO | _deployment_commands.py:193 | Deploy-0-sagemaker-studio-studio ] _execute_deploy permissions_boundary_arn:: None
[2024-12-09 11:09:58,240 | DEBUG | _stack_commands.py:472 | Deploy-0-sagemaker-studio-studio ] /aiops-modules/modules/sagemaker/sagemaker-studio/modulestack.yaml
[2024-12-09 11:10:00,333 | DEBUG | utils.py     : 89 | Deploy-0-sagemaker-studio-studio ] HASH generated is bf1e667a
[2024-12-09 11:10:00,333 | INFO | _stack_commands.py:134 | Deploy-0-sagemaker-studio-studio ] create_module_deployment_role permissions_boundary_arn None
[2024-12-09 11:10:00,333 | DEBUG | _iam.py      : 46 | Deploy-0-sagemaker-studio-studio ] Creating IAM Role with name: aiops-mlops-sagemaker-sagemaker-studio-studio-bf1e667a
[2024-12-09 11:10:00,333 | DEBUG | _iam.py      : 47 | Deploy-0-sagemaker-studio-studio ] create_check_iam_role permissions_boundary_arn: None
Additional context
It will be good to have some way to configure permissions_boundary for module manifest so it can be used while creating any the IAM role as part of deployment of module.

@nileshlathiya we are reviewing...

released in 5.0.2

Thank you. I'll check it out

released in 5.0.2

Thank you. I'll check it out


[WIP] Add patch to fix some guestinstance tests

After enabling verbose logging, it appeared that some guestinstance tests were crashing as a result of
[25755:0522/121849.511223:ERROR:sync_point_manager.cc(136)] Client did not release sync token as expected

errors.
This error was also seen here, and subsequently repaired in chromium with this CL, which is the patch i've backported in this PR.
/cc @alexeykuzmin @deepak1556

> backport_3743d0f.patch failed to apply =(

There is no need to backport commit 3743d0f, it has already been backported to M66 in commit 4ec34bb.

https://chromium-review.googlesource.com/c/chromium/src/+/969968 should also be backported.

I'll do it separately.


Capacitor3

Hi Martin,
This is the updated plugin that works with Capacitor 3. We are using this now to integrate in our frontend.
I wanted to update this together with the vue starter project, but there still some errors that I could not resolve. This will have to be done at a later moment.
Can you check this and update the NPM package so that we can build it into our app?
Thanks
Merge state

Hi Martin,
This is the updated plugin that works with Capacitor 3. We are using this now to integrate in our frontend.
I wanted to update this together with the vue starter project, but there still some errors that I could not resolve. This will have to be done at a later moment.
Can you check this and update the NPM package so that we can build it into our app?
Thanks

Closes #40


Allow spaces in executable name when temp file is used

This issue was originally created at: 2005-06-22 13:26:12.
This issue was reported by: sbaranov.
sbaranov said at 2005-06-22 13:26:12

When temp file is used to execute long commands,
their names could not contain spaces, for example:
env.Replace(LINK = r"C:\Program Files\Microsoft Xenon
SDK\bin\win32\link.exe")
Now spaces are universally suported in command
names, regardless of whether temp file is used or not.

stevenknight said at 2005-08-20 17:26:53

Integrated for next release.  Thank you!  --SK

stevenknight said at 2005-09-29 01:07:24

Had to back this out due to regressions introduced.
Re-opening while another solution is found.

issues@scons said at 2005-09-29 01:07:24

Converted from SourceForge tracker item 1225795

stevenknight said at 2006-05-26 04:23:27

Created an attachment (id=33)
Patch, copied from SourceForge tracker.

stevenknight said at 2009-01-07 19:11:33

Bug party triage:  SK to research and prioritize as part of general Visual
Studio work.

stevenknight said at 2009-11-10 18:00:19

stevenknight => issues@scons

gregnoel said at 2010-02-03 13:14:40

Bug party triage.  Quoting in the command file is an interaction with subst(),
so this issue should be part of those revisions.

stevenknight attached scons-tempspace.diff at 2008-03-25 11:08:15.

Patch, copied from SourceForge tracker.

Fixed in 2010.  Likely first appeared in 2.0.0.final.0 release.


feat: added Saturday class to CalendarGrid

Adding Saturday class column to CalendarGrid if there are Saturday classes.

This change is

any progress

Another dev is trying to implement a dynamic version of this for more edge cases. Closing this PR.

@vinsonzheng499 gg


343/save users answers when submitting questionaire

Context
The AP application form is fairly long and from research we have heard the current version can be completed over the course of a few days by probation practicioners. Our current implementation of sessions expire when the user is either logged out or closes their browser. It would be convinient for probation practicioners to be able partially fill in the form and then come back to it at a later time to complete it without having to keep the tab for the form open. This PR intends to allow that behaviour.
Link to Trello ticket here
Changes
Now when the persistData method of the Form class is called we write the session to a JSON file with the sessionID as it's file name.
When the initialize method on Form is called (which is each time the user submits a response to a form page or loads a form page) we check whether the request has a body:

If it does have a body then the body is a new answer to a question so we persist that data.
If it doesn't have a body the call to initialize is a user loading a page so we check to see if there is a JSON file with the sessionID of the request and if there is we load their previous answers from JSON if they exist for that question.

Considerations
Saving the session to JSON is a short term solution to prove the concept. In beta stage the session should be saved to database.
If, during development, the form changes (IE a question that previously required checkbox answers changes to a text field) this could cause errors when we load data from the session. In future we would like to be able to version the questions and then check that the saved responses are valid for that version of the questions but this work will be completed in a future PR.

@pezholio ah yes, good spot 🤦♂


Page is wrong

This page is incorrect. There is no "Resources" section on this page.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8ccc5e95-049b-4132-3353-85804949edeb
Version Independent ID: 8ccc5e95-049b-4132-3353-85804949edeb
Content: Step 2 - Create a resource account - Microsoft Teams
Content Source: Teams/hybrid-meetings-device-config-account.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hello @sid-swirl
If you refer to

Go to Resources in the left panel, and then select Rooms & equipment. If these options aren't available in the left panel, you may need to select Show all first.

You need to search that in the admin center and Resources option is there.
Thanks


Just a question

Please tick all applicable boxes.

[x] I am using Python 3.5 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update_dependencies script

Which version are you using?

[x] The latest master version (1.9.7)
[ ] The latest review version

What type of issue are you creating?

[ ] Bug
[ ] Feature request
[x] Question

Description of issue
my bot auto skips when I'm no on voice chat, how can i stop it from skipping when im not on voice chat?
Steps to reproduce

Log file
Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.

AutoPause=Yes in options.ini I believe should help with this, this will only work if no-one else is in the voice chat though.

SeeSkipAbsent in https://github.com/Just-Some-Bots/MusicBot/blob/master/config/example_permissions.ini#L94

@AutumnClove u did that and didn't work
@MattBSG where is that link again? its not working

@Geesmen fixed my comment

@MattBSG I put my user id on that music master and put skipwhenabsent to no and it still skips when im not on voice chat.

Please attach your permissions.ini and musicbot.log files.

I'm running into the same issue currently, attaching my logs here if you don't mind :
musicbot.log
permissions.txt
The IDs I put are roles IDs. originally I did not have any roles attributed to anyone.
I have tried with both the option skipwhenabsent and without, it still behaves the same way.

for both of you I would try remove = no and see if that does anything also Kurata-Saiaku this may not be a problem but your ID's are giving it to the role if this is ment to be like that then its ok but if it only ment to be two people then move it to userlist

Sorry, that did not resolve the issue.

please also make sure that UseExperimentalEqualization = no in options.ini as it does bug the player out sometimes.

Did not solve my issues, unfortunately.
The IDs are indeed roles IDs, not users IDs.
I have tried to both set remove = no and remove = yes without any change.
I removed UseExperimentalEqualization = yes since it made my bot bug by well, making it stop playing music suddenly.
Logs do not reveal anything about skipping.

kurata-saiaku from your log it looks like the UseExperimentalEqualization option is still being used. If both of you could send the .last long when the bot next does the skip as that will have only that log in it and means that we can see what exactly is causing it to skip.

Still having the issue, disabled the option you recommended
Here's my log
musicbot.log

@Kurata-Saiaku @DetectiveMecha are you both the owners (set in options.ini) for your bots? If so, does it skip for other people out of their channel with the permission to not skip?

Created a Test Account on discord, seeing as my friends are all missing when I need them to test things, and gave it perms.
The test account does not have any issues.
Here is the log for that session.
musicbot.log

Confirmed, I am the owner and it skips only for me, not other users who are also musicmaster.

I am aware that there are two separate permissions files that are involved in the Music Bot. The first one is labeled as an .ini, the second as a .py.
The one I modified to achieve results was the .py, under the actual bot files, and not just the one under the config folder.

Just found a weird behaviour again, When I queue a music while not being in the vocal room, it skips my song which is "normal", however if I join afterward and queue music again, it still tells me I'm not in the room. Will add logs this evening.

@DetectiveMecha Those values in permissions.py are default values. Changes in the config should override those.
Anyway, closing due to lack of activity


ActiveMQ isn't able to create another thread when running in docker.

By default it creates ~500 threads so lets reduce that number to 30. I haven't experienced any perf drop by smoke testing.
more info here:
https://developer.jboss.org/thread/268397

@filipb would it be hard to run the perf tests either on the resulting container or on a hawkular-services that are started with this additional param -Dactivemq.artemis.client.global.thread.pool.max.size=30?

Performance CI is not currently running against docker containers. This will have to be checked manually. I will report perf drop if there is any once it's done.

I run perf tests against latest h-services master with -Dactivemq.artemis.client.global.thread.pool.max.size=30 and it had no impact on performance

retest this please

Just wanted to confirm that this does fix the issue I see currently on Fedora 24.  I'm still not sure why only Fedora 24 (Server Version: 1.10.3) runs into this limit though.

@pilhuhn can you please review/merge?


Optimization on OpenFlow control interface

Add support for matching original connection info in conntrack.
Simplify OpenFlow actions in the control interface.
Add support for "note" action.

I have a question on how will new flows look like if ct_nw_src, ct_nw_dst fields are used. If there is network policy with egress rule consists of pod label X to Label Y. Label X corresponds to two local pods A and B.
Will there be two flows with separate ct_nw_src matches corresponding to pod A and pod B IPs?
I am trying to understand the purpose of these fields in relation to following statement. Thanks.
"Support match field of ct_nw_src, ct_nw_dst, ct_nw_proto and ct_tp_dst. This feature could help collect statistics ofpackets matching network policy."

If we have Pod A and Pod B, and an egress Network Policy Rule to allow traffic from PodA to PodB. There is only one flow which is using ct_nw_src=$PodA_IP. It is because the traffic from PodA to PodB, and the reply from PodB to PodA are belonging to the same connection. And the ct_nw_src is used to represent the original source IP IP of the connection. So is th ct_nw_dst (PodB IP in this example). The fields ct_nw_xx(and ct_tp_xx) are supported since OVS 2.8.0. With these fields, we could manage the flow according to connection, and we don't need to differentiate request and reply packets.

I have a question on how will new flows look like if ct_nw_src, ct_nw_dst fields are used. If there is network policy with egress rule consists of pod label X to Label Y. Label X corresponds to two local pods A and B.

If we have Pod A and Pod B, and an egress Network Policy Rule to allow traffic from PodA to PodB. There is only one flow which is using ct_nw_src=$PodA_IP. It is because the traffic from PodA to PodB, and the reply from PodB to PodA are belonging to the same connection. And the ct_nw_src is used to represent the original source IP IP of the connection. So is th ct_nw_dst (PodB IP in this example). The fields ct_nw_xx(and ct_tp_xx) are supported since OVS 2.8.0. With these fields, we could manage the flow according to connection, and we don't need to differentiate request and reply packets.

Wenying, I did not mean to have network policy to allow connections between podA to podB. But from pod label X (corresponds to local pods A and B) to label Y.
Current flow for established connections of egress rule table (#50):
cookie=0x11000000000000, duration=17599.565s, table=50, n_packets=6857, n_bytes=671986, priority=210,ct_state=-new+est,ip actions=resubmit(,70)
I am presuming above OVS flow stats correspond to all network policy egress rules. To get separate statistics for each network policy egress rule. Will above rule broken into fine-grain rules to track the statistics using the new matches? Wondering if that is the intent?

Wenying, I did not mean to have network policy to allow connections between podA to podB. But from pod label X (corresponds to local pods A and B) to label Y.
Current flow for established connections of egress rule table (#50):
cookie=0x11000000000000, duration=17599.565s, table=50, n_packets=6857, n_bytes=671986, priority=210,ct_state=-new+est,ip actions=resubmit(,70)
I am presuming above OVS flow stats correspond to all network policy egress rules. To get separate statistics for each network policy egress rule. Will above rule broken into fine-grain rules to track the statistics using the new matches? Wondering if that is the intent?

In my opinion, these new fields are not used to to change current implementations for egress/ingress flow entries. The requirements for them are for the metrix of NetworkPolicy rule. So I would like to use another table(after egress/ingress rule table) specific for metrix to avoid flow confliction. @tnqn could you add your thoughts about how you expect to leverage these ct fields( ct_nw_xx/ct_tp_xx fields )?

/test-all

Wenying, I did not mean to have network policy to allow connections between podA to podB. But from pod label X (corresponds to local pods A and B) to label Y.
Current flow for established connections of egress rule table (#50):
cookie=0x11000000000000, duration=17599.565s, table=50, n_packets=6857, n_bytes=671986, priority=210,ct_state=-new+est,ip actions=resubmit(,70)
I am presuming above OVS flow stats correspond to all network policy egress rules. To get separate statistics for each network policy egress rule. Will above rule broken into fine-grain rules to track the statistics using the new matches? Wondering if that is the intent?

In my opinion, these new fields are not used to to change current implementations for egress/ingress flow entries. The requirements for them are for the metrix of NetworkPolicy rule. So I would like to use another table(after egress/ingress rule table) specific for metrix to avoid flow confliction. @tnqn could you add your thoughts about how you expect to leverage these ct fields( ct_nw_xx/ct_tp_xx fields )?

My plan was removing the generic "-new+est" flow and let each rule's conjunction match flow to allow the first and following packets because even if we don't do it here we will need another table to match packets with rule's ct 5-tuples anyway, so didn't want to introduce extra flow management. @wenyingd do you see problem in this approach? what did you mean by flow conflict?

Wenying, I did not mean to have network policy to allow connections between podA to podB. But from pod label X (corresponds to local pods A and B) to label Y.
Current flow for established connections of egress rule table (#50):
cookie=0x11000000000000, duration=17599.565s, table=50, n_packets=6857, n_bytes=671986, priority=210,ct_state=-new+est,ip actions=resubmit(,70)
I am presuming above OVS flow stats correspond to all network policy egress rules. To get separate statistics for each network policy egress rule. Will above rule broken into fine-grain rules to track the statistics using the new matches? Wondering if that is the intent?

In my opinion, these new fields are not used to to change current implementations for egress/ingress flow entries. The requirements for them are for the metrix of NetworkPolicy rule. So I would like to use another table(after egress/ingress rule table) specific for metrix to avoid flow confliction. @tnqn could you add your thoughts about how you expect to leverage these ct fields( ct_nw_xx/ct_tp_xx fields )?

My plan was removing the generic "-new+est" flow and let each rule's conjunction match flow to allow the first and following packets because even if we don't do it here we will need another table to match packets with rule's ct 5-tuples anyway, so didn't want to introduce extra flow management. @wenyingd do you see problem in this approach? what did you mean by flow conflict?

@tnqn The "conflict" I mentioned is based on the assumption we keep the current flow implementation(I mean we still use "-new+est" state to allow the later packets in established connection). My original thought was using a table focusing on statistics collection. And after the packets are passed the check in networkpolicy, they go to the new table, and then we could have fine-grained flows for each connection. But if you plan to use the new fields instead of the generic state(“-new+est”), please ignore the word.
If we use the new field in network policy, do we keep conjunction flows? If yes, how to collect the statistics for the first packet? I don't think the existing flow with match "conj_id=xxx" could match every single connection(The conjunctive match flow don't have statistics, so we can't leverage them for the first packet). On the other side, if we add flow with match "ct_state=+new, ct_nw_src=xxx,ct_nw_dst=xxx" for each flow in the same table, it looks we don't need the conjunction flows any more, and the packet can't match two flows in the same table.

Wenying, I did not mean to have network policy to allow connections between podA to podB. But from pod label X (corresponds to local pods A and B) to label Y.
Current flow for established connections of egress rule table (#50):
cookie=0x11000000000000, duration=17599.565s, table=50, n_packets=6857, n_bytes=671986, priority=210,ct_state=-new+est,ip actions=resubmit(,70)
I am presuming above OVS flow stats correspond to all network policy egress rules. To get separate statistics for each network policy egress rule. Will above rule broken into fine-grain rules to track the statistics using the new matches? Wondering if that is the intent?

In my opinion, these new fields are not used to to change current implementations for egress/ingress flow entries. The requirements for them are for the metrix of NetworkPolicy rule. So I would like to use another table(after egress/ingress rule table) specific for metrix to avoid flow confliction. @tnqn could you add your thoughts about how you expect to leverage these ct fields( ct_nw_xx/ct_tp_xx fields )?

My plan was removing the generic "-new+est" flow and let each rule's conjunction match flow to allow the first and following packets because even if we don't do it here we will need another table to match packets with rule's ct 5-tuples anyway, so didn't want to introduce extra flow management. @wenyingd do you see problem in this approach? what did you mean by flow conflict?

@tnqn To do conjunctive flow match on every packet other than the first packet will probably add overhead in flow lookups right? Will adding ct_label as the network policy UUID/conjunctive ID in conjunctive flow action for the first packet and matching ct_label along with "-new+est" for rest of the packets can help track the stats for network policy rules better? This was discussed in Radio paper shared by @antoninbas

/test-all

@srikartati

To do conjunctive flow match on every packet other than the first packet will probably add overhead in flow lookups right?

I am not an OVS expert but I do not think so because of how datapath flow caching work in OVS. Ideally we would run tests to compare the 2 approach but intuitively I think it should not increase the number of datapath flows and that it should not increase cache misses and deteriorate performance.
I didn't follow the whole conversation too closely but IMO, being able to stop relying on "-new+est" would be a good thing, because it would enable us to enforce network policies on existing connections, which cannot be done for CNIs relying entirely on conntrack. I personally think it's a good thing to have.
@wenyingd @tnqn would you mind submitting a proposal with the changes you have in mind for the OVS pipeline once you reach an agreement?

@srikartati

To do conjunctive flow match on every packet other than the first packet will probably add overhead in flow lookups right?

I am not an OVS expert but I do not think so because of how datapath flow caching work in OVS. Ideally we would run tests to compare the 2 approach but intuitively I think it should not increase the number of datapath flows and that it should not increase cache misses and deteriorate performance.

Ok. I see that in OVS data plane flow cache both flow specific rules and actions are cached. Yes in data plane there is only one flow, caching of flow specific rules helps and does not deteriorate the performance. Thanks for the clarification.

@srikartati

To do conjunctive flow match on every packet other than the first packet will probably add overhead in flow lookups right?

I am not an OVS expert but I do not think so because of how datapath flow caching work in OVS. Ideally we would run tests to compare the 2 approach but intuitively I think it should not increase the number of datapath flows and that it should not increase cache misses and deteriorate performance.

Ok. I see that in OVS data plane flow cache both flow specific rules and actions are cached. Yes in data plane there is only one flow, caching of flow specific rules helps and does not deteriorate the performance. Thanks for the clarification.

@srikartati Sorry for my late reply. I think @antoninbas is correct. In current way, the following packets cannot reuse the datapath cache for the first packet as reply packets has different src, dst ip, and the datapath cache should have "+new-est" as part of the fields of datapath flow because they are ever used when matching the high-priority flow "ct_state=-new+est". So the following packets has to do a flow lookup anyway and it will match the high-priority "ct_state=-new+est" flow.
In the proposed way, the first packet of following packets will also do a flow lookup, and it will match the "-new" goto flow and there will be a corresponding datapath flow generated. Then the other following packets will hit it. So it's still 2 flow lookups for each session.
Please see design in https://github.com/vmware-tanzu/antrea/issues/776#issuecomment-637639005

/skip-all

Ok. I see that in OVS data plane flow cache both flow specific rules and actions are cached. Yes in data plane there is only one flow, caching of flow specific rules helps and does not deteriorate the performance. Thanks for the clarification.

@srikartati Sorry for my late reply. I think @antoninbas is correct. In current way, the following packets cannot reuse the datapath cache for the first packet as reply packets has different src, dst ip, and the datapath cache should have "+new-est" as part of the fields of datapath flow because they are ever used when matching the high-priority flow "ct_state=-new+est". So the following packets has to do a flow lookup anyway and it will match the high-priority "ct_state=-new+est" flow.
In the proposed way, the first packet of following packets will also do a flow lookup, and it will match the "-new" goto flow and there will be a corresponding datapath flow generated. Then the other following packets will hit it. So it's still 2 flow lookups for each session.
Please see design in #776 (comment)

Hi @tnqn, Thanks for the reply. My question was about OVS flow/openflow lookup for match and not dataplane flow lookup--my bad I should have been clearer. In the existing scenario, the following packets just do a lookup on high priority "ct_state = -new+est", whereas in the proposed way it has to match the conjunctive flow again for subsequent packets in the same direction.
As you alluded and I came to know from OVS documentation, the matches from OVS flows are also cached in data plane flow cache along with actions. In virtual switches, I was aware that actions are cached but did not know about the caching of OVS flows/openflow rules match fields.


[exercises/concept/fruit-picker] Exercise requires users to be familiar with the throw statement

While I was doing the exercise myself (which is made to test users about the Arrow functions and Callbacks concepts), I came across something that I found a bit confusing: task 3 of this exercise requires users to

[...] throw a new error if err is not null.

This implies using the javascript throw statement as part of the function the exercise asks you to build. However, the Errors concept (where the throwstatement is developed) is to be found much further down the syllabus tree, and the way the instruction is described in the task might make users think that "throwing an error" just means returning a string with an message with an error text as opposed to using the error statement. This is what I did myself, which meant that when running the tests, I got a message from the debugger saying that I was supposed to use something I didn't even know existed to complete the exercise.
I believe this can be easily fixed by either:

Making sure the instruction of the task is clear about what the user needs to use (the errorstatement). An easy fix to this would be to add a link to its MDN page in the very same paragraph.
Removing the need to use such statement. This would imply modifying the exercise so that users are required to simply return a string with an error message instead.

Thanks for bringing this up.
It seems indeed that the prerequisite is missing. We'll have a talk about what's wise here.

Yes, great catch indeed. I will take a closer look what's the best way forward here.

I know very well how to use arrow functions but I'm really struggling with callback functions, which are poorly explained in the exercise. I'm ok with leaving behind the callback topic until I'm more familiar with it, but why is that blocking my arrow functions as well? This is really annoying...

@pikkus I agree the introduction could probably be improved. I am not sure what would be gained by decoupling callbacks from arrow functions though. You are already free to choose to not do the Callbacks exercise but instead first proceed down the Classes path in the syllabus. But in the end callbacks are needed to understand all of the array utilities (map, forEach, filter, etc.) in the next "layer" of the concept tree and those are also one of the most common use cases for arrow functions and one reason arrow functions were added to the language. That's why I think it makes sense to learn about callbacks and arrow functions in the same exercise.

Hello, in Task 3 it says "Finish the purchaseInventoryIfAvailable callback function to be used with the grocer's checkInventory API function.", but the checkInventory callback  takes a query and a callback. I'm confused as to how I'm to use checkInventory in this exercise.

Hello, in Task 3 it says "Finish the purchaseInventoryIfAvailable callback function to be used with the grocer's checkInventory API function.", but the checkInventory callback takes a query and a callback. I'm confused as to how I'm to use checkInventory in this exercise.

I'm stuck at the same point. Came here for help.

Heya @sergioreynoso @obrunopereira ,
I believe what they mean by saying that, is that "purchaseInventoryIfAvailable" is going to be that callback that goes into "checkInventory"
You do not need to use "checkInventroy" in the 3rd task.


Fixed operator keyword typo

Fix typo in TOC
Currently the TOC lists the operator keyword as operator2. This PR corrects it.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


Getting start with module is bad

Hi
I want to getting start with your module but not successful while found out you set some variable to simple-frame. I think users confuse about it and I recommend to review your demo and create a simple getting start to your module in documentation.
Thanks

Sounds like you looked at the source code of the demo rather than the demo itself. If you follow the links in the readme you come to http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/simple, which shows all the code you need (which is not very much)


[GLUTEN-2961][VL][CORE] Decimal sum avg use row_constructor

What changes were proposed in this pull request?
Decimal sum and avg have the meaning of overflow when the child field is null, and gluten's row_constructor_with_null cannot be used.
How was this patch tested?
SPARK-28067: Aggregate sum should not return wrong results for decimal overflow
SPARK-35955: Aggregate avg should not return wrong results for decimal overflow

@JkSelf Please take a look.

@liujiayi771 Can you help to rebase? Thanks.

@liujiayi771 Can you help to rebase? Thanks.

Done.


FilePathProcessor.js - ERR_FILE_NOT_FOUND

I'm getting the following error on my mid 2015 macbook pro. I've tried removing and reinstalling the extension. The solutions to the other issues related to FilePathProcessor.js have not worked for me.
Failed to load resource: net::ERR_FILE_NOT_FOUND file:///Applications/Brackets.app/Contents/www/file/FilePathProcessor.js

The FilePathProcessor is a feature for a forked version of Brackets that never got released and should be harmless. Do you encounter any issues when trying to sync your code?

I'm thinking it probably isn't a contributing factor to my bigger issue. I'm attempting to hunt down what's causing excessive CPU usage when I run AEM. I figured since this extension deals with some file syncing it couldn't hurt to bring it up and see if any useful information came out of it.

I'll just leave this issue open as a reminder that we should probably remove the FilePathProcessor from the main build. However, if you encounter specific sync errors please report them in a new issue.

The plug-in isn't working at all for me. Running AEM 6.3 and Brackets 1.11.0-17524 and the Plug-in version 0.0.13
On start-up, RequireJS loading for CRXDEFilePathProcessor.js is failing and throwing an error because it apparently can't find  FilePathProcessor.js
require.js:1903 GET file:///C:/Program%20Files%20(x86)/Brackets/www/file/FilePathProcessor.js net::ERR_FILE_NOT_FOUND

CRXDEFilePathProcessor.js:52 Cannot load module file/FilePathProcessor

Any ideas? The console for the tool just reports timeouts when I try any synchronization action.

Ha. I just re-started Brackets and it works now. I'm relieved and happy to say this does indeed look like a red herring. There's an error in the console but synchronization seems to be working fine :D


The prometheus service account does not have enough Permissions

The issue can be seen when looking at the Prometheus logs
./kubectl logs prometheus-deployment-5cfdf8f756-mpctk --namespace=monitoring
level=error ts=2018-03-06T15:18:52.981806942Z caller=main.go:221 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:268: Failed to list *v1.Endpoints: endpoints is forbidden: User "system:serviceaccount:monitoring:default" cannot list endpoints at the cluster scope"
level=error ts=2018-03-06T15:18:52.981851051Z caller=main.go:221 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:354: Failed to list *v1.Node: nodes is forbidden: User "system:serviceaccount:monitoring:default" cannot list nodes at the cluster scope"
level=error ts=2018-03-06T15:18:52.981878974Z caller=main.go:221 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:269: Failed to list *v1.Service: services is forbidden: User "system:serviceaccount:monitoring:default" cannot list services at the cluster scope"
level=error ts=2018-03-06T15:18:52.981907841Z caller=main.go:221 component=k8s_client_runtime err="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:296: Failed to list *v1.Pod: pods is forbidden: User "system:serviceaccount:monitoring:default" cannot list pods at the cluster scope"
I seem to be getting the same errors above.
I tried to edit this file and just changed https://github.com/prometheus/prometheus/blob/master/documentation/examples/rbac-setup.yml
the namespace value to "monitoring" which is the namespace I am using.
I then tried to run the following command using that rbac-setup.yml file:
./kubectl apply -f rbac-setup.yml
clusterrole "prometheus" created
serviceaccount "prometheus" created
clusterrolebinding "prometheus" created
And checked the service account was there:
./kubectl get serviceaccounts --namespace=monitoring
NAME         SECRETS   AGE
default      1         5d
prometheus   1         24s
However I am still getting the same errors and there is nothing under metrics, targets or Service Discovery in the Prometheus UI. Could you please advise asap what else needs to be done?

Yup, that's an issue. Check out the prometheus-kubernetes.yml https://github.com/karan-kapoor90/wls-K8s/blob/master/prometheus/prometheus-kubernetes.yml
I faced the same issue #770

Hi @maryjomcguinness  , please let me know if this example solved your issue https://github.com/karan-kapoor90/wls-K8s/blob/master/prometheus/prometheus-kubernetes.yml

@maryjomcguinness  are you still experiencing the same problem?


[Web, Canvas] Crash in Skiko with RoundedCornerShape

Drawing a Surface with certain RoundedCornerShapes crashes Skia. It doesn't crash with RectangleShape or RoundedCornerShape(16.dp), only seems to crash when setting radii per corner, e.g. RounderCornerShape(topStart = 8.dp, topEnd = 8.dp).
From the browser console:
skiko.wasm:0x266c94 Uncaught RuntimeError: remainder by zero
    at skiko.wasm:0x266c94
    at skiko.wasm:0x2674ce
    at skiko.wasm:0x272f76
    at skiko.wasm:0x2d65f2
    at skiko.wasm:0x34aa97
    at skiko.wasm:0x2c3c7e
    at skiko.wasm:0x2c6aa3
    at skiko.wasm:0x279300
    at skiko.wasm:0x269ade
    at skiko.wasm:0x269522

Sample project
Run ./gradlew jsBrowserDist && ./gradlew jsBrowserRun, click the bottom option to repro the crash

Add reproducer to GitHub:
https://github.com/dima-avdeev-jb/reproduce-js-canvas-rounded-corner-shape

This was fixed in https://github.com/JetBrains/compose-multiplatform-core/pull/550 and fix is available in 1.4.1

Fixed in 1.4.1

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


semver?

I'm a bit ambivalent about doing semver, because it implies doing releases, which are just toil. OTOH it might make using this lib easier; because you can version check if you're on the right version (can see a need for this in coredns/coredns).
We could just version without actually releasing?
Can we automatically bump a minor an each PR merged? Start with 1.0.0 --> 1.0.1 etc?

I don't see a distinction between implementing semver and doing releases. A release has as much fanfare as a project can muster. As long as it's clear what a release/version implies somewhere prominent in the readme and package doc anything's fine.
A bump on every PR shouldn't be too onerous at current contribution levels.

One thing I haven't understood, is how does a user utilize versions in go packages. Unless they're doing vendoring, they just get the latest master whenever they run go get. Do enough people use vendoring (or something similar)? Recently at corp we had to stick a package to a particular version (tag) and we had to go in and manually add a build step to cd into the repo in the gopath and check out the older tag.

I don't know much about it but dep is on the road to being the official solution and so I assume the community will rally around it.

[ Quoting<EMAIL_ADDRESS>in "Re: [miekg/dns] semver? (#592)..." ]

One thing I haven't understood, is how does a user utilize versions in go packages. Unless they're doing vendoring, they just get the latest master whenever they run go get. Do enough people use vendoring (or something similar)? Recently at corp we had to stick a package to a particular version (tag) and we had to go in and manually add a build step to cd into the repo in the gopath and check out the older tag.

There isn't user versioning (yet). dep is the first step and at least let's
you vendor the local deps for the package. Users still get master.


Add devolved_administration_availability to local_transaction schema

What?
This schema has been added as part of a task to enable publishers to specify devolved administration (DA) service availability for local transactions.
Why?
In the Frontend application, by default, users will be shown a link to a local authority website when inputting a postcode for a local transaction.
In some cases, the service is handled by a devolved administration. In other cases the service is unavailable to devolved administrations.
Currently, the devolved administration availability cannot be set by publishers and the logic is defined in the Frontend application.
As part of the overall task, functionality is being added to the Publisher application to allow this information to be set within the publishing tool.
Therefore, this schema validates the DA availability values set in Publisher.
Only the 'unavailable' and 'devolved_administration_service' related values will be presented from Publisher. This will be enough information to determine what to display on the Frontend as it will fall back to displaying the local authority results page.
Useful links
Final naming decisions were agreed as a team during Dev chat on 26/05/2021.
We changed the type value from alternative_url to devolved_administration_service as we felt it was confusing having alternative_url as a field name and as a type value. We also felt it better described the type of service.
Modelling PR in Publisher.
Spike content schema branch.
Spike write up.
Spike PR for modelling in Publisher.
Trello.
Paired with @kevindew

Thanks @kevindew. I split up the commits and added an example file. The schema regeneration commit seems to be failing to build and I am not sure if it is related. I'll look at it first thing tomorrow.


Storage tests

Along with just having more tests we should create a set of storage tests. This will both facilitate refactoring of storage as well as development of any new storage backends that are desired.

Storage tests started to be added in 3fb3291563db7164482a2e0a283ed6abefd5faec and now reside in /storage/test/


Build Autoware + CARET failed due to "error: too few arguments to function ‘void ros_trace_rclcpp_publish"

Checklist

[X] I've read the contribution guidelines.
[X] I've read document and no solution were found.

Issue type
Bug
Step where the issue is related to
Build
Environments

OS: Ubuntu 22.04.1 LTS
Kernel version: 5.14.0-1052-oem
ROS 2: Humble
CPU: Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz x 12
Memory: 32.0 GiB

CARET version

CARET: v0.4.1
CARET_analyze: v0.4.1
CARET_trace: v0.4.1

Target application

Application name: Autoware
URL: https://github.com/autowarefoundation/autoware
Version: main branch at 2023/01/17
How to run: Rosbag replay simulation
- https://autowarefoundation.github.io/autoware-documentation/main/tutorials/ad-hoc-simulation/rosbag-replay-simulation/

Description
Build failed in obstacle_velocity_limiter and euclidean_cluster due to the following error
/opt/ros/humble/include/rclcpp/rclcpp/publisher.hpp: In member function ‘void rclcpp::Publisher<MessageT, AllocatorT>::do_inter_process_publish(const ROSMessageType&)’:
/opt/ros/humble/include/rclcpp/rclcpp/publisher.hpp:452:5: error: too few arguments to function ‘void ros_trace_rclcpp_publish(const void*, const void*, uint64_t)’
452 |     TRACEPOINT(rclcpp_publish, nullptr, static_cast<const void *>(&msg));
       |     ^~~~~~~~~~
/ros2_caret_ws/install/tracetools/include/tracetools/tracetools/tracetools.h:168:1: note: declared here
168 | DECLARE_TRACEPOINT(
       | ^~~~~~~~~~~~~~~~~~

Steps to reproduce

Update ROS 2 (as  of 20220117)
Install CARET
Download Autoware (as of 20220117)
Build Autoware with CARET

Commands
git clone https://github.com/autowarefoundation/autoware.git
cd autoware
./setup-dev-env.sh
mkdir src
vcs import src < autoware.repos
rosdep install -y --from-paths src --ignore-src --rosdistro $ROS_DISTRO

source ~/ros2_caret_ws/install/local_setup.bash

colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=Off
# colcon build --symlink-install --packages-up-to obstacle_velocity_limiter --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=Off
# colcon build --symlink-install --packages-up-to euclidean_cluster --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=Off

Logs
#20 1713.7 Starting >>> euclidean_cluster
#20 1744.3 --- stderr: euclidean_cluster
#20 1744.3 CMake Warning at /opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake:66 (add_library):
#20 1744.3   Cannot generate a safe runtime search path for target cluster_lib because
#20 1744.3   there is a cycle in the constraint graph:
#20 1744.3
#20 1744.3     dir 0 is [/ros2_caret_ws/install/rclcpp_components/lib]
#20 1744.3     dir 1 is [/autoware/install/tier4_perception_msgs/lib]
#20 1744.3     dir 2 is [/opt/ros/humble/lib]
#20 1744.3       dir 0 must precede it due to runtime library [libcomponent_manager.so]
#20 1744.3       dir 5 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3       dir 6 must precede it due to runtime library [libtracetools.so]
#20 1744.3       dir 14 must precede it due to runtime library [librclcpp.so]
#20 1744.3       dir 15 must precede it due to runtime library [librclcpp_action.so]
#20 1744.3       dir 16 must precede it due to runtime library [librcl_action.so]
#20 1744.3       dir 17 must precede it due to runtime library [librcl.so]
#20 1744.3     dir 3 is [/autoware/install/tier4_pcl_extensions/lib]
#20 1744.3     dir 4 is [/autoware/install/pointcloud_preprocessor/lib]
#20 1744.3     dir 5 is [/ros2_caret_ws/install/rcl_yaml_param_parser/lib]
#20 1744.3       dir 2 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3     dir 6 is [/ros2_caret_ws/install/tracetools/lib]
#20 1744.3     dir 7 is [/autoware/install/autoware_auto_geometry_msgs/lib]
#20 1744.3     dir 8 is [/autoware/install/autoware_auto_perception_msgs/lib]
#20 1744.3     dir 9 is [/autoware/install/autoware_auto_planning_msgs/lib]
#20 1744.3     dir 10 is [/autoware/install/autoware_auto_vehicle_msgs/lib]
#20 1744.3     dir 11 is [/autoware/install/autoware_auto_mapping_msgs/lib]
#20 1744.3     dir 12 is [/autoware/install/tier4_debug_msgs/lib]
#20 1744.3     dir 13 is [/autoware/install/tier4_autoware_utils/lib]
#20 1744.3     dir 14 is [/ros2_caret_ws/install/rclcpp/lib]
#20 1744.3       dir 2 must precede it due to runtime library [librclcpp.so]
#20 1744.3     dir 15 is [/ros2_caret_ws/install/rclcpp_action/lib]
#20 1744.3     dir 16 is [/ros2_caret_ws/install/rcl_action/lib]
#20 1744.3     dir 17 is [/ros2_caret_ws/install/rcl/lib]
#20 1744.3
#20 1744.3   Some of these libraries may not be found correctly.
#20 1744.3 Call Stack (most recent call first):
#20 1744.3   CMakeLists.txt:16 (ament_auto_add_library)
#20 1744.3
#20 1744.3
#20 1744.3 CMake Warning at /opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake:66 (add_library):
#20 1744.3   Cannot generate a safe runtime search path for target
#20 1744.3   euclidean_cluster_node_core because there is a cycle in the constraint
#20 1744.3   graph:
#20 1744.3
#20 1744.3     dir 0 is [/opt/ros/humble/lib]
#20 1744.3       dir 3 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3       dir 4 must precede it due to runtime library [libtracetools.so]
#20 1744.3       dir 6 must precede it due to runtime library [libcomponent_manager.so]
#20 1744.3       dir 12 must precede it due to runtime library [librclcpp.so]
#20 1744.3       dir 16 must precede it due to runtime library [librclcpp_action.so]
#20 1744.3       dir 17 must precede it due to runtime library [librcl_action.so]
#20 1744.3       dir 18 must precede it due to runtime library [librcl.so]
#20 1744.3     dir 1 is [/autoware/install/tier4_pcl_extensions/lib]
#20 1744.3     dir 2 is [/autoware/install/pointcloud_preprocessor/lib]
#20 1744.3     dir 3 is [/ros2_caret_ws/install/rcl_yaml_param_parser/lib]
#20 1744.3       dir 0 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3     dir 4 is [/ros2_caret_ws/install/tracetools/lib]
#20 1744.3     dir 5 is [/autoware/install/autoware_auto_geometry_msgs/lib]
#20 1744.3     dir 6 is [/ros2_caret_ws/install/rclcpp_components/lib]
#20 1744.3     dir 7 is [/autoware/install/autoware_auto_perception_msgs/lib]
#20 1744.3     dir 8 is [/autoware/install/autoware_auto_planning_msgs/lib]
#20 1744.3     dir 9 is [/autoware/install/autoware_auto_vehicle_msgs/lib]
#20 1744.3     dir 10 is [/autoware/install/tier4_debug_msgs/lib]
#20 1744.3     dir 11 is [/autoware/install/tier4_autoware_utils/lib]
#20 1744.3     dir 12 is [/ros2_caret_ws/install/rclcpp/lib]
#20 1744.3       dir 0 must precede it due to runtime library [librclcpp.so]
#20 1744.3     dir 13 is [/autoware/build/euclidean_cluster]
#20 1744.3     dir 14 is [/autoware/install/tier4_perception_msgs/lib]
#20 1744.3     dir 15 is [/autoware/install/autoware_auto_mapping_msgs/lib]
#20 1744.3     dir 16 is [/ros2_caret_ws/install/rclcpp_action/lib]
#20 1744.3     dir 17 is [/ros2_caret_ws/install/rcl_action/lib]
#20 1744.3     dir 18 is [/ros2_caret_ws/install/rcl/lib]
#20 1744.3
#20 1744.3   Some of these libraries may not be found correctly.
#20 1744.3 Call Stack (most recent call first):
#20 1744.3   CMakeLists.txt:32 (ament_auto_add_library)
#20 1744.3
#20 1744.3
#20 1744.3 CMake Warning at /opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake:66 (add_library):
#20 1744.3   Cannot generate a safe runtime search path for target
#20 1744.3   voxel_grid_based_euclidean_cluster_node_core because there is a cycle in
#20 1744.3   the constraint graph:
#20 1744.3
#20 1744.3     dir 0 is [/autoware/build/euclidean_cluster]
#20 1744.3     dir 1 is [/opt/ros/humble/lib]
#20 1744.3       dir 4 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3       dir 5 must precede it due to runtime library [libtracetools.so]
#20 1744.3       dir 7 must precede it due to runtime library [libcomponent_manager.so]
#20 1744.3       dir 13 must precede it due to runtime library [librclcpp.so]
#20 1744.3       dir 16 must precede it due to runtime library [librclcpp_action.so]
#20 1744.3       dir 17 must precede it due to runtime library [librcl_action.so]
#20 1744.3       dir 18 must precede it due to runtime library [librcl.so]
#20 1744.3     dir 2 is [/autoware/install/tier4_pcl_extensions/lib]
#20 1744.3     dir 3 is [/autoware/install/pointcloud_preprocessor/lib]
#20 1744.3     dir 4 is [/ros2_caret_ws/install/rcl_yaml_param_parser/lib]
#20 1744.3       dir 1 must precede it due to runtime library [librcl_yaml_param_parser.so]
#20 1744.3     dir 5 is [/ros2_caret_ws/install/tracetools/lib]
#20 1744.3     dir 6 is [/autoware/install/autoware_auto_geometry_msgs/lib]
#20 1744.3     dir 7 is [/ros2_caret_ws/install/rclcpp_components/lib]
#20 1744.3     dir 8 is [/autoware/install/autoware_auto_perception_msgs/lib]
#20 1744.3     dir 9 is [/autoware/install/autoware_auto_planning_msgs/lib]
#20 1744.3     dir 10 is [/autoware/install/autoware_auto_vehicle_msgs/lib]
#20 1744.3     dir 11 is [/autoware/install/tier4_debug_msgs/lib]
#20 1744.3     dir 12 is [/autoware/install/tier4_autoware_utils/lib]
#20 1744.3     dir 13 is [/ros2_caret_ws/install/rclcpp/lib]
#20 1744.3       dir 1 must precede it due to runtime library [librclcpp.so]
#20 1744.3     dir 14 is [/autoware/install/tier4_perception_msgs/lib]
#20 1744.3     dir 15 is [/autoware/install/autoware_auto_mapping_msgs/lib]
#20 1744.3     dir 16 is [/ros2_caret_ws/install/rclcpp_action/lib]
#20 1744.3     dir 17 is [/ros2_caret_ws/install/rcl_action/lib]
#20 1744.3     dir 18 is [/ros2_caret_ws/install/rcl/lib]
#20 1744.3
#20 1744.3   Some of these libraries may not be found correctly.
#20 1744.3 Call Stack (most recent call first):
#20 1744.3   CMakeLists.txt:45 (ament_auto_add_library)
#20 1744.3
#20 1744.3
#20 1744.3 In file included from /opt/ros/humble/include/rclcpp/rclcpp/service.hpp:34,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/callback_group.hpp:25,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/any_executable.hpp:20,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/memory_strategy.hpp:25,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/memory_strategies.hpp:18,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/executor_options.hpp:20,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/executor.hpp:37,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/executors/multi_threaded_executor.hpp:25,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/executors.hpp:21,
#20 1744.3                  from /opt/ros/humble/include/rclcpp/rclcpp/rclcpp.hpp:155,
#20 1744.3                  from /opt/ros/humble/include/pcl_conversions/pcl_conversions.h:42,
#20 1744.3                  from /autoware/src/universe/autoware.universe/perception/euclidean_cluster/include/euclidean_cluster/utils.hpp:23,
#20 1744.3                  from /autoware/src/universe/autoware.universe/perception/euclidean_cluster/lib/utils.cpp:14:
#20 1744.3 /opt/ros/humble/include/rclcpp/rclcpp/publisher.hpp: In member function ‘void rclcpp::Publisher<MessageT, AllocatorT>::do_inter_process_publish(const ROSMessageType&)’:
#20 1744.3 /opt/ros/humble/include/rclcpp/rclcpp/publisher.hpp:452:5: error: too few arguments to function ‘void ros_trace_rclcpp_publish(const void*, const void*, uint64_t)’
#20 1744.3   452 |     TRACEPOINT(rclcpp_publish, nullptr, static_cast<const void *>(&msg));
#20 1744.3       |     ^~~~~~~~~~
#20 1744.3 /ros2_caret_ws/install/tracetools/include/tracetools/tracetools/tracetools.h:168:1: note: declared here
#20 1744.3   168 | DECLARE_TRACEPOINT(
#20 1744.3       | ^~~~~~~~~~~~~~~~~~
#20 1744.3 gmake[2]: *** [CMakeFiles/cluster_lib.dir/build.make:76: CMakeFiles/cluster_lib.dir/lib/utils.cpp.o] Error 1
#20 1744.3 gmake[1]: *** [CMakeFiles/Makefile2:145: CMakeFiles/cluster_lib.dir/all] Error 2
#20 1744.3 gmake: *** [Makefile:146: all] Error 2
#20 1744.3 ---
#20 1744.3 Failed   <<< euclidean_cluster [30.6s, exited with code 2]
#20 1760.9 [Processing: euclidean_cluster, shape_estimation]
#20 1760.9 Aborted  <<< shape_estimation [2min 9s]
#20 1761.0
#20 1761.0 Summary: 68 packages finished [29min 20s]
#20 1761.0   1 package failed: euclidean_cluster
#20 1761.0   1 package aborted: shape_estimation
#20 1761.0   6 packages had stderr output: compare_map_segmentation euclidean_cluster map_loader ndt_omp pointcloud_preprocessor velodyne_pointcloud
#20 1761.0   163 packages not processed
#20 ERROR: process "/bin/sh -c cd autoware &&     . /opt/ros/\"$ROS_DISTRO\"/setup.sh &&     . /ros2_caret_ws/install/local_setup.sh &&     colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=Off" did not complete successfully: exit code: 2
------
 > [15/17] RUN cd autoware &&     . /opt/ros/"humble"/setup.sh &&     . /ros2_caret_ws/install/local_setup.sh &&     colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=Off:
#20 1744.3 ---
#20 1744.3 Failed   <<< euclidean_cluster [30.6s, exited with code 2]
#20 1760.9 [Processing: euclidean_cluster, shape_estimation]
#20 1760.9 Aborted  <<< shape_estimation [2min 9s]
#20 1761.0
#20 1761.0 Summary: 68 packages finished [29min 20s]
#20 1761.0   1 package failed: euclidean_cluster
#20 1761.0   1 package aborted: shape_estimation
#20 1761.0   6 packages had stderr output: compare_map_segmentation euclidean_cluster map_loader ndt_omp pointcloud_preprocessor velodyne_pointcloud
#20 1761.0   163 packages not processed

LTTng trace log file
No response
Screenshots
No response

Cause
SYSTEM is added as dependencies in ament_cmake_auto by https://github.com/ament/ament_cmake/commit/799183ab9bcfd9b66df0de9b644abaf8c9b78e84 . As a result, ros2/rclcpp is used rather than CARET/rclcpp in some packages.
Workaround

Modify the following two files:

/opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_executable.cmake
/opt/ros/humble/share/ament_cmake_auto/cmake/ament_auto_add_library.cmake

<   ament_target_dependencies(${target}  ${${PROJECT_NAME}_FOUND_BUILD_DEPENDS})
---
>   ament_target_dependencies(${target} SYSTEM ${${PROJECT_NAME}_FOUND_BUILD_DEPENDS})


Improve the time taken by Github Actions on pull requests

Coming from https://github.com/opensearch-project/opensearch-clients/issues/53, update the workflows to reduce the amount of time taken by Github actions for integration tests.

[ ] Cache plugin build for existing integration tests (low impact, high benefit). See example: https://github.com/opensearch-project/opensearch-dsl-py/blob/2b9e688aa314098956fe7b7bd47618fc10340182/.github/workflows/integration-unreleased.yml#L31-L48
[ ] Cache entire OpenSearch build (very low benefit)
[ ] Use OpenSearch docker container (very low benefit)
[ ] Run integration tests in parallel on all cluster types (low impact, high benefit)
[ ] Add cache save-restore before and after cluster configuration procedure (high impact, low benefit) - need to do big changes in the test framework
[ ] Add integration tests on unreleased versions and use cache as shown in p1

Looks like this is already done for this repo.


Option to Add Multiples Notes to a Folder

If possible, please add the option to add multiple notes to a single virtual folder (whether by shift-clicking the notes and then right clicking to select the option in a context menu, and/or through command palette.
I tried using another plugin https://github.com/technohiker/obsidian-multi-properties for this purpose, but when I tried adding the property Folders and linked note as the value [[Example]] to a set of 3 selected files,  it only shows up on the VirtFolder tree for the single note in that set I right-clicked before clicking the Add props to selected files option, even though all 3 notes received the same property addition.
I then have to go into 1 of the other non-right clicked individual files and manually enter the folders value or add another one (whether its fake or not) for the VirtFolder tree to become updated with the previous addition.
Given this inefficiency, it would be helpful if either the option requested could be natively added or if the bug with VirtFolder not updating for when multiple notes have their Folders values added with the multi-properties plugin were rectified.

I don't fully understand the question. You can add any number of children to any note. But it is done through the child, in which the parent is referenced.

I don't fully understand the question. You can add any number of children to any note. But it is done through the child, in which the parent is referenced.

Essentially I want to to be able to bulk add multiple children to a note (virtual folder) in one step (whether through the context menu or command palette).
As described in my previous comment, I tried another plugin to try to do that but the VirtFolder tree display didnt update with the initial bulk addition without additional input afterwards.

Essentially I want to to be able to bulk add multiple children to a note (virtual folder) in one step (whether through the context menu or command palette).

ok, and how do you see this in implementation? The note selection menu searches one at a time.