Error while using relative urls

Hi, I'm getting following error
ERROR   -  Error reading page 'quickstart/index.md': relpath() argument must be str or bytes, not 'PosixPath'
Traceback (most recent call last):
  File "/usr/lib/python3.5/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/__main__.py", line 192, in <module>
    cli()
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/__main__.py", line 152, in build_command
    build.build(config.load_config(**kwargs), dirty=not clean)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/commands/build.py", line 271, in build
    _populate_page(file.page, config, files, dirty)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/commands/build.py", line 168, in _populate_page
    'page_markdown', page.markdown, page=page, config=config, files=files
  File "/usr/local/lib/python3.5/dist-packages/mkdocs/plugins.py", line 94, in run_event
    result = method(item, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/plugin.py", line 8, in on_page_markdown
    return _on_page_markdown(markdown, page, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/event.py", line 107, in _on_page_markdown
    markdown)
  File "/usr/lib/python3.5/re.py", line 182, in sub
    return _compile(pattern, flags).sub(repl, string, count)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/event.py", line 91, in found_include_markdown_tag
    destination_path=page_src_path,
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/process.py", line 134, in rewrite_relative_urls
    markdown
  File "/usr/lib/python3.5/re.py", line 182, in sub
    return _compile(pattern, flags).sub(repl, string, count)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/process.py", line 124, in found_href
    rewritten_url = rewrite_url(href)
  File "/usr/local/lib/python3.5/dist-packages/mkdocs_include_markdown_plugin/process.py", line 108, in rewrite_url
    destination_path.parent)
  File "/usr/lib/python3.5/posixpath.py", line 460, in relpath
    genericpath._check_arg_types('relpath', path, start)
  File "/usr/lib/python3.5/genericpath.py", line 143, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: relpath() argument must be str or bytes, not 'PosixPath'

for this snippet
{%
    include-markdown "../../_snippets/where-to-go-next.md"
    start="<!--intro-start-->"
    end="<!--intro-end-->"
%}

With  rewrite_relative_urls=false  it works.
Maybe it is related to the snippets not being part of the docs folder
.
├── README.md
├── dictionary.txt
├── mkdocs.yml
├── src
│   ├── _snippets
│   ├── docs
├── tsconfig.json
└── tslint.json

mkdocs.yml
site_dir: 'build'
docs_dir: 'src/docs'

This also brings me to feature request, yould it be possible in the plugin configuration to specify default source folder?
Thanks for looking into this.

Thank you for open this. :+1:
The problem is that you are using Python v3.5, when that version reached his end of life in September of this year. Sorry, this package it's supported from version 3.6 onwards. I'm going to add a flag in setup to display a warrning trying to install in older versions.

@mondeja Seems you released as 2.2.1, instead of 2.1.1? (while the versions in the files are correct, being 2.1.1)

Seems you released as 2.2.1, instead of 2.1.1? (while the versions in the files are correct, being 2.1.1)

Ups :sweat_smile: Thanks for advising @YannickJadoul

Small and easy mistake ;-)

@mondeja Thank you for the quck reply, I did not notice the python version.
But I think I have another issue with relative urls, when using mailto. contact us is translated to contact us

Thank you so much for the report :pray:
This has been fixed in new release 2.1.2. Could you check that everything is OK?

This also brings me to feature request, yould it be possible in the plugin configuration to specify default source folder?

This has not been done, correct?

{%
include-markdown "docs/includes/header.md"
heading-offset=1
%}

Also the example above in the README documentation is not working for me.
Is there a way to provide absolute paths starting with "docs/..."? (only absolute paths of File System are currenltly working for me)

This has not been done, correct?

That's right, could you open another issue to track it?

Sure, done. https://github.com/mondeja/mkdocs-include-markdown-plugin/issues/55


Song Blacklist; Restrict Playlist Playback

I've looked through the bot a couple times and couldn't find this feature, but I think it's a really needed one. I'd like to be able to block certain songs from being played in my server. A command to blacklist the current song would be good, as well as an option to add songs to the blacklist, either via a command or by adding them directly to a file, perhaps blocked.txt? The command to block a song could be something like "!block " and "!skipblock" could be used to skip the song and add it to the block list. "!unblock " could be used to remove a song from the blocked list. Anyway, this is a feature I'd really like to see in the bot and I think it's important for larger communities that use this bot so they can filter out any inappropriate music for their server.
Python is still relatively new to me, but if I'm not the only one looking for this features, I'd be happy to try and contribute to adding these features. I do think they are important for moderated communities.

The issue with this is that people could just upload videos with fake titles.

Well, that might be true, however, that's not really what I was thinking at all. I was just thinking of something as simple as a blocked.txt file with a list of links (YouTube links, SoundCloud links, what have you) and the bot would simply not download those links or allow those links to be played.
The commands would just add the media link to the blocked.txt file.

The problem with this kind of thing is the cat and mouse game you have to play.  Blocking specific links means someone just plays one from a different source.  Blocking entire sites is probably ok for NSFW sites but there's plenty legitimate sites with mixed content.  Blocking by regex is unreliable.  If someone really wanted to, they could just upload something and play that file directly.  Blocking "generic" files is bad because that would break a few things.  Its not easy to do this well, and people will always try to find a way around any block.  Obviously moderating your users is another way, but people can just make a new account and queue links, unless you set the verification timeout in the server settings.  There's always a way around it.  I'll probably add some sort of site blacklist at least, but moderating your users is pretty much the best way of content curation.

Of course. However, I always like having a few moderation tools under my belt.
Speaking of blocking sites, that's also an interesting idea and would help my community out a lot actually. I'd prefer that my particular community only be allowed to pull media from certain sites and not any site they choose. How hard is that to implement?

Just adding my two cents that yes, there will always be a way around "blocked" videos, and user moderation is ultimately necessary. While this will not outright prevent abuse, it can still be useful to help reduce it. Rick rolls, for example are usually "harmless" but annoying and if the most commonly used urls/links are blacklisted, it might help prevent some impulsive abuse.
Possibly a whole different feature request would be to implement a "timeout" system where the bot can place users into a muted role for a temporary period of time. It could be invoked manually my moderators as a user moderation tool, OR automatically if a user attempts to play a blacklisted song or blacklisted "title" term like from #520


UITable Support movable, editable etc. Columns

Currently it isn't possible to move columns PrimeReact does supprt movable columns. Check movable property in column metadata

When this is fixed, close #52 aswell


ClickInventoryEvent Slots have no properties

When reading the slot from a ClickInventoryEvent, none of the properties seem to have any value.
Example code which causes issues:
@Listener
@Include({ClickInventoryEvent.class})
public void onInventoryOffHandSlotClick(ClickInventoryEvent event) {
    event.getCause().first(Player.class).ifPresent(player -> {
        event.getTransactions().forEach(slotTransaction -> {
            System.out.println(slotTransaction);
            slotTransaction.getSlot().getInventoryProperty(EquipmentSlotType.class).ifPresent(equipmentSlotType -> {
               if(equipmentSlotType.getValue() != null && equipmentSlotType.getValue().equals(EquipmentTypes.OFF_HAND)) {
                   slotTransaction.setCustom(ItemStack.empty());
                   event.setCancelled(true);
               }
            });
        });
    });
}

I've also attempted this with the following method combinations:
slotTransaction.getSlot().getInventoryProperty(SlotIndex.class);
slotTransaction.getSlot().getInventoryProperty(EquipmentSlotType.class);
slotTransaction.getSlot().parent().getProperty(slotTransaction.getSlot(), EquipmentSlotType.class, "equipmentSlotType");
slotTransaction.getSlot().parent().getProperty(slotTransaction.getSlot(), EquipmentSlotType.class, slotTransaction.getSlot().parent());
slotTransaction.getSlot().parent().getProperty(slotTransaction.getSlot(), SlotIndex.class, "slotindex");
slotTransaction.getSlot().parent().getProperty(slotTransaction.getSlot(), SlotIndex.class, "slotIndex");
slotTransaction.getSlot().parent().getInventoryProperty(slotTransaction.getSlot(), SlotIndex.class)

None of them return anything
Environment
SpongeAPI 7.0.0
SpongeVanilla 7.1.0
(Also had this problem on SpongeForge 2655)

you could try checking it on slot.transform() which returns the slot in the Inventory (as opposed to in the Container)

I also tried this without results unfortunately. I'll update the issue to reflect this

https://github.com/SpongePowered/SpongeCommon/issues/1912
try again


Request new module: terraform-gitops-ubi

(Click Preview to navigate to guides) Please read the guides on how to create a module for the catalog:

Guide for a GitOps Module

Related user story/epic
https://github.com/cloud-native-toolkit/software-everywhere/issues/511
Type of module
gitops
What is the purpose of the module?
A module should just deploy a pure ubi image (Red Hat Universal Base Image) as a container with Helm. With the values.yaml in the Helm chart we can configure replica count of the pods. The deployed containers are only a basic ubi operating system.
The ubi helm-chart example based on the ubi-helm repository.
Soon it also should provide a command line parameter as input to execute a command during the startup of the UBI container.
The module implementation is already available, but not in the cloud-native-toolkit org and this is the existing module implementation terraform-gitops-ubi .
This module was developed in the context of operate learning lab 4 -create own module.
What is the category of the module?
cluster, iam, network, database, integration, dev-tool, sre, infrastructure, util, software etc
util or new category example
FYI: @nheidloff @Vishal-Ramani

Hi @seansund
We have to create new module in cloud-native-toolkit need your assistance to publish new module and create a repository.

@seansund Thanks
The module link: https://github.com/cloud-native-toolkit/terraform-gitops-ubi


Add 42 Quebec

Official website URL
The page on the official website where a long-term (>1 year) IT related course is offered by the university
Thanks

@xitope Pull request merged. Thank you!


git-lfs push does not appear to make appropriate SSH request

I'm trying to push a repository to an ssh remote, however the client never appears to make a git-lfs-authenticate request. When I run git-lfs push origin master the SSH server receives git-upload-pack /test/lfs/lfs-test.git but nothing else. The output on the client is as follows:
charlie@charlie-pc ~/git-lfs-test $ git remote -v
origin	ssh://charlie@<IP_ADDRESS>:2222/test/lfs/lfs-test.git (fetch)
origin	ssh://charlie@<IP_ADDRESS>:2222/test/lfs/lfs-test.git (push)

charlie@charlie-pc ~/git-lfs-test $ git-lfs push origin master
(0 of 18 files) 0 B / 522 B  0.00 %
Username for '://':

My suspicion is that this problem relates to the ssh:// URL format.

Thanks for the report!

Hey, just a heads up. We just completed a big rewrite of our test suite (#306), which unblocks us from implementing and properly testing little bugs like this.  We should be able to get to this next week, and definitely for the next release of Git LFS.

Added way back in v0.5.3 :)


Fitting failed

Hi,
I tried to use deMultiplex 2 package for my MULTI-seq data.
However it returns Fitting Failed for my first tag group but works fine for other tags.
Do you guys have any idea why does it happen?
PS: I tried to use another dataset and it works fine too.

rm(list=ls())
data1 <- Read10X('/Users/admin/R/day3raw_feature_bc_matrix')
10X data contains more than one type and is being returned as a list containing matrices of each type.
tag_mtx <- t(data1$Multiplexing Capture)
data(multiseq_oligos)
tag.ref <- multiseq_oligos[3:6]
cell_ids <- Matrix::rowSums(tag_mtx) > 100
tag_used <- Matrix::colSums(tag_mtx) >1e4
tag_mtx <-tag_mtx[cell_ids, tag_used]
res <- demultiplexTags(tag_mtx, plot.path ="./", plot.name = "demux", plot.diagnostics = T)
Running EM for TDBonly
Iteration 1; Q diff: 41543.1943022717
Fitting failed.
Running EM for TDBUrelumab
Iteration 1; Q diff: 41702.5440420353
Iteration 2; Q diff: 3491.6057314845
Iteration 3; Q diff: 4585.20532365606
Iteration 4; Q diff:<PHONE_NUMBER>18252
Iteration 5; Q diff:<PHONE_NUMBER>6846
Iteration 6; Q diff:<PHONE_NUMBER>56333
Iteration 7; Q diff: 91.3320290341871
Iteration 8; Q diff: 32.8050920890091
Iteration 9; Q diff: 0.000563061577850021

Hi, sorry for the delayed reply. Could you please upload the diagnoistic plot for the "TDBonly" sample produced by deMULTIplex2? Thanks!


where is ItemsRepeater control in toolbox?

Hello. I'm using WIUI 2.4, can't find out ItemsRepeater control in toolbox, see only ItemsControl and ItemsPresenter.
Do I need to install something others to get the ItemsControl?
thanks!

@jevansaks and/or @MikeHillberg I don't know how the VisualStudio ToolBox feature works. Is there a step we are missing when publishing Winui 2.x to enable this?

It's a nuget feature. You include a specially named XML file and put it in the right place in the nupkg and then the gallery will show items from it. Our config file is here:
https://github.com/microsoft/microsoft-ui-xaml/blob/master/build/NuSpecs/VisualStudioToolsManifest.xml
And then if you want to add icons, they come from the design dll that's built and also included in the nupkg. It's here:
https://github.com/microsoft/microsoft-ui-xaml/blob/master/dev/Microsoft.UI.Xaml.Design/Microsoft.UI.Xaml.Design.csproj#L60

@StephenLPeters documentation about the nuget feature is here: https://docs.microsoft.com/en-us/nuget/guides/create-ui-controls#add-toolboxassets-pane-support-for-xaml-controls

@StephenLPeters documentation about the nuget feature is here: https://docs.microsoft.com/en-us/nuget/guides/create-ui-controls#add-toolboxassets-pane-support-for-xaml-controls

@jevansaks thanks! @jsman123 We haven't included ItemsRepeater, and a couple of other controls in the appropriate manifest. Thank you for bringing this to our attention!

@StephenLPeters @ranjeshj Mind if I update the file to include the (new) WinUI controls? It seems there are a few missing.

@StephenLPeters @ranjeshj Mind if I update the file to include the (new) WinUI controls? It seems there are a few missing.

That would be awesome!


No highlighting after if(xxxx

I have not highlight it by neocmakelsp , this highlight is by textmate. Emm.. I do not know how to highlight it will be better

Maybe Semantic Tokens ?

EXISTS is a keyword. It is used for if statements. The color should be the same as if.


Implement "equilibrium state" test for SA part of calibration process.

Need to expand upon the concept that is drafted in "mads_calibration/equlibrium_check.py".

Thinking that this might get built as part of drivers/Sensitivity.py such that the "collate results" function will run the various equilibrium state checks (stability, slope, etc) and output a file equilibrium_state.csv in each sample directory. Each column of the csv file may have a boolean value for whether each of the respective tests pass. Then this csv file can be read at a later date to assess whether the sample run reached equlibrium via various metrics.

So far checks we have thought of are:

slope of a linear regression over N years
"stability" which is the coefficient of variation over N years
long term stability where you look at a long time series and see if there are periods of equilibrium separated by distinct steps from one equilibrium state to another

Propose that the "equlibrium check" logic is added to the util/metrics.py module.

In general, it would be nice to build the equilibrium check into the C++ code of the dvm-dos-them. This will eliminate the extra steps that need to be taken to make sure that the model is equilibrated. In addition, this could help with the overall model -eq case when the model will check and decide when the equilibrium run needs to be terminated without the user specifying the number of years because some cases might take longer or shorter to equilibrate. When we provide a hard number, usually 2000 years, if the model is not at equilibrium, then it will continue to lose carbon during the -tr and -sc stages, which would make it harder to match observations.

@Elchin yeah, we would like to put this in the C++ code but decided that we should implement in Python first as a "post hoc" check because it will be faster for development and will allow us to experiment with different methods of testing for equilibrium state.

And just a reminder here - the parameters/tolerance to assess the stability of an eq run might vary depending on the variable and associated turnover.

On Feb 5, 2024, at 10:59 AM, tobey @.***> wrote:
Yes! Have been thinking along those lines. Current thought is that there
will be a step in the end of each run that makes a bunch of measurements
about the equilibrium “quality” of the equilibrium and then summarizes this
info in a csv file (similar to the results.csv).
Then in post hoc analysis, user can filter list of runs based on the
quality measurements, similar to the n top runs.
On Mon, Feb 5, 2024 at 10:42 AM valeriabriones @.***>
wrote:

@tobeycarman https://github.com/tobeycarman not sure if this
structurally makes sense, but in thinking about the workflow post SA, right
now the equilibrium check is for all samples run from SA, but am curious if
there's another way to have it work from the
SA_post_hoc_analysis.n_top_runs(), which selects the samples which meet
these criteria based on r2lim and have an equilibrium check work from these
top samples as a way to complement or supplement the SA results? Just a
thought! Have been trying to work through it but its messy
—
Reply to this email directly, view it on GitHub
https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/issues/666#issuecomment-1927923606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMYT6HBZZ3PIDEFQ5GD63YSEYZTAVCNFSM6AAAAABCJQJOIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXHEZDGNRQGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub https://github.com/uaf-arctic-eco-modeling/dvm-dos-tem/issues/666#issuecomment-1927999053, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANVJF6ADDY26H7U6ELFEV3YSE23JAVCNFSM6AAAAABCJQJOIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXHE4TSMBVGM.
You are receiving this because you are subscribed to this thread.

@valeriabriones, @Benjamin-Maglio, @jsclein-uaf, just pushed changes (commit: ffd82c0) implementing a draft roughly as discussed above. Details in the commit message.🤞 that it might run for you. Note that I did not push anything that actually "checks" the equilibrium - the code I pushed makes various "measurements" and summarizes the data. The "check" still needs to be written...i.e. "only use samples with slope < .1" or "only use samples with cv<.5".


Java client fails to deserialize WorkflowTemplate

Checklist

[x] Double-checked my configuration.
[x] Tested using the latest version.
[x] Used the Emissary executor.

Summary
What happened/what you expected to happen?
I'm using the java-client to get a WorkflowTemplate (any) form the server. This results in an IllegalStateException.
java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 165 path $.metadata.creationTimestamp
	at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:385) ~[gson-2.9.0.jar:na]

the server returns a valid JSON with the following metadata (double checked that via cURL):
  "metadata": {
    "name": "********",
    "namespace": "argo",
    "uid": "9b1039c0-f710-458e-b510-945337dd4bac",
    "resourceVersion": "15460",
    "generation": 1,
    "creationTimestamp": "2022-06-21T12:57:34Z",
    "labels": {
      "kustomize.toolkit.fluxcd.io/name": "argo-pipelines",
      "kustomize.toolkit.fluxcd.io/namespace": "flux-system"
    }

I also checked the schema.json
"creationTimestamp": {
"$ref": "#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.Time",
"description": "CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.\n\nPopulated by the system. Read-only. Null for lists. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata"
}

"io.k8s.apimachinery.pkg.apis.meta.v1.Time": {
"description": "Time is a wrapper around time.Time which supports correct marshaling to YAML and JSON.  Wrappers are provided for many of the factory methods that the time package offers.",
"format": "date-time",
"type": "string"
}

So GSON understandably expects a BEGIN_OBJECT for the creationTimestamp value.
How can I solve this issue?
What version are you running?
Server: v3.3.1
Java Client: v3.3.8
Diagnostics
Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.
not applicable, relates to the client.

# Logs from the workflow controller:
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

# If the workflow's pods have not been created, you can skip the rest of the diagnostics.

# The workflow's pods that are problematic:
kubectl get pod -o yaml -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

# Logs from in your workflow's wait container, something like:
kubectl logs -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

I also encountered this problem, looking forward to the official solution to it

I also faced this issue.
An easy way to reproduce it is to mock the response from a server and pass it through io.argoproj.workflow.JSON
My example:
import com.google.gson.reflect.TypeToken;
import com.google.gson.stream.JsonReader;
import io.argoproj.workflow.JSON;
import io.argoproj.workflow.models.IoArgoprojWorkflowV1alpha1Workflow;

import java.io.StringReader;
import java.lang.reflect.Type;

public class Main {

    public static void main(String[] args) {
        JSON json = new JSON();
        String mockResponseBody = "{\"metadata\":{\"name\":\"test\",\"creationTimestamp\":\"2022-08-01T07:51:04Z\"}}";

        JsonReader jsonReader = new JsonReader(new StringReader(mockResponseBody));
        Type localVarReturnType = new TypeToken<IoArgoprojWorkflowV1alpha1Workflow>(){}.getType();

        json.getGson().fromJson(jsonReader, localVarReturnType);
    }
}

Despite the json is valid, the result is:
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 49 path $.metadata.creationTimestamp

Just wondering which version this issue occurs from? Is there any working 3.3.x Argo Workflows Java SDK?

I have the issue with 3.3.8 java SDK

Can you try latest?

It is maybe not the same case for me. I was migrated from an old argoproj-lab SDK client and no 3.x version works for me in fact.
I have: Failed making field 'java.time.Instant#seconds' accessible; either change its visibility or write a custom TypeAdapter for its declaring type
So it is related to Gson parsing and basic java type protection.
I got the same error with "Expected BEGIN_OBJECT but was STRING" after an ugly patch to the jvm:
"--add-opens",
"java.base/java.time=ALL-UNNAMED",
But I don't know if it is the same issue I don't want to change this issue target.
For information my server is version 3.3.8 if it helps.

io.argoproj.workflow.models.IoArgoprojWorkflowV1alpha1Workflow has an attribute metadata which is an object of io.kubernetes.client.openapi.models.V1ObjectMeta
In turn, V1ObjectMeta has creationTimestamp which is custom DateTime format org.joda.time.DateTime.
So, the reason of the error is that io.argoproj.workflow.JSON can't deserialize this joda creationTimestamp, since there is no proper type adapter registered for it.
Proposing fix taken from here https://stackoverflow.com/questions/15972856/json-using-gson-library-error-expected-begin-object-but-was-string:
In io.argoproj.workflow.JSON in constructor:
public JSON() {
    gson = createGson()
            .registerTypeAdapter(Date.class, dateTypeAdapter)
            .registerTypeAdapter(java.sql.Date.class, sqlDateTypeAdapter)
            .registerTypeAdapter(OffsetDateTime.class, offsetDateTimeTypeAdapter)
            .registerTypeAdapter(LocalDate.class, localDateTypeAdapter)
            .registerTypeAdapter(byte[].class, byteArrayAdapter)
            .registerTypeAdapter(DateTime.class, new JsonDeserializer<DateTime>() {
                @Override
                public DateTime deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context)
                        throws JsonParseException {
                    return new DateTime(json.getAsString());
                }
            }).create();
}

Version 3.3.9 solves the issue for me.

It seems that it was fixed after I moved to v3.3.9 but I still have to use --add-opens java.base/java.time=ALL-UNNAMED Is there a way around that? I'm using Java 17.

After I used v3.3.9, I found that there was still a serialization problem. It was not the original DateTime problem but the java.time.Instant problem. I created a new package io.argoproj.workflow in my project, which added JSON.java, then copy io.argoproj.workflow.JSON in the sdk source code and modify it in my JSON.java, and modify the JSON constructor as follows:
public class JSON {
//add
private InstantTypeAdapter instantTypeAdapter = new InstantTypeAdapter();
//edit
public JSON() {
        gson = createGson()
                .registerTypeAdapter(Date.class, dateTypeAdapter)
                .registerTypeAdapter(Instant.class, instantTypeAdapter)
                .registerTypeAdapter(java.sql.Date.class, sqlDateTypeAdapter)
                .registerTypeAdapter(OffsetDateTime.class, offsetDateTimeTypeAdapter)
                .registerTypeAdapter(LocalDate.class, localDateTypeAdapter)
                .registerTypeAdapter(byte[].class, byteArrayAdapter)
                .create();
    }
//add
public static class InstantTypeAdapter extends TypeAdapter<Instant> {

        private Instant dateFormat;

        public InstantTypeAdapter() {
        }

        public InstantTypeAdapter(Instant instant) {
            this.dateFormat = dateFormat;
        }

        public void setFormat(Instant instant) {
            this.dateFormat = dateFormat;
        }

        @Override
        public void write(JsonWriter out, Instant date) throws IOException {
            if (date == null) {
                out.nullValue();
            } else {
                out.value(FORMATTER.format(date));
            }
        }

        @Override
        public Instant read(JsonReader in) throws IOException {
            try {
                switch (in.peek()) {
                    case NULL:
                        in.nextNull();
                        return null;
                    default:
                        String date = in.nextString();
                        if (date == null) {
                            return null;
                        }
                        return FORMATTER.parse(date, Instant::from);

                }
            } catch (IllegalArgumentException e) {
                throw new JsonParseException(e);
            }
        }
    }

}

}

@alexec could the fix described by @sanqiuli  be included in the next release? I can also open a new issue if needed.


Synthetic Data Generation Error

Hi @ylabbe ,
I followed your script and tried to generate the synthetic data by running:

python -m cosypose.scripts.run_dataset_recording --config ycbv --local

However, it showed me an error that cannot extract anything useful from mesh 'data/assets/cage/plane.obj', could you please let me know how to fix it? Because I want to use this synthetic data generation script for our own case!
Thank you in advance!

[Memory]1.3s, 0.0min    : Loading parse_image_dir...
Loaded EGL 1.5 after reload.
GL_VENDOR=NVIDIA Corporation
GL_RENDERER=GeForce RTX 2080 Ti/PCIe/SSE2
GL_VERSION=4.6.0 NVIDIA 460.80
GL_SHADING_LANGUAGE_VERSION=4.60 NVIDIA
Version = 4.6.0 NVIDIA 460.80
Vendor = NVIDIA Corporation
Renderer = GeForce RTX 2080 Ti/PCIe/SSE2
Loaded EGL 1.5 after reload.
b3Warning[examples/Importers/ImportURDFDemo/BulletUrdfImporter.cpp,1159]:
data/assets/cage/: cannot extract anything useful from mesh 'data/assets/cage/plane.obj'
b3Warning[examples/SharedMemory/plugins/eglPlugin/eglRendererVisualShapeConverter.cpp,855]:
issue extracting mesh from COLLADA/STL file data/assets/cage/plane.obj

Hi @Jing-lun , did you find a solution for this issue? I have the same error and couldnt move forward. please help


Added optional parameter to ago to allow short output

Example of output with parameter set:
ta.ago(new Date()-1000, true);  =>  "1s"
ta.ago(new Date()-1000 * 60, true); => "1m"
ta.ago(new Date()-1000 * 60 * 60, true); => "1h"

@digplan Is this feature something that your are interested in merging, or should I put my fork up separately on NPM?

Thanks!

Please put the latest release on NPM as well. Thank you!

It seems latest release is not at NPM yet, right?


Fix text cannot be wrapped in "<{space} text {space}>"  in welcome message in new room

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/20874
PROPOSAL: https://github.com/Expensify/App/issues/20874#issuecomment-1593890453
Tests

Go to any room settings
Go to the welcome message
Type the following :
Click save
Verify that the page shows invalid character error
Type another text:
Verify that the page shows invalid character error
Type another text:
Verify that page does not show invalid character error
Click save
Verfiy that the welcome message can be saved successfully
Type another text:
Repeact 9->11

[x] Verify that no errors appear in the JS console

Offline tests

Changes in this PR are not affected by network
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/9639873/4366247a-a0b2-442a-a4e4-7753ac341662

Mobile Web - Chrome

Uploading Screen Recording 2023-06-28 at 23.37.57 - android chrome.mov…

Mobile Web - Safari

https://github.com/Expensify/App/assets/9639873/83541eaa-2200-443d-ada8-0af8241438a2

Desktop

https://github.com/Expensify/App/assets/9639873/bc126314-22ba-43c0-b42f-780893d537f1

iOS

https://github.com/Expensify/App/assets/9639873/04476040-3221-4260-a6fd-91f02731ade8

Android

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/1f23ffd8-c34a-41ef-bc20-03ad52470ef5

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/9ef92819-75df-4879-b7db-3face0de3686

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/8b2b93ce-e96f-4d0d-94ae-18f4f997a908

Desktop
https://github.com/Expensify/App/assets/28352309/d56305ce-4dfc-4de5-b449-343e48da6e5c

iOS
https://github.com/Expensify/App/assets/28352309/c42b5ac9-b097-4166-b20e-af651ce55cfe

Android
https://github.com/Expensify/App/assets/28352309/0b875e4b-b5d0-4f0e-aa3c-d903d710e6fe

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.3.35-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.35-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Auto-generate changelog

Hey @peritus ,
I wonder, if automatic changelog generating would be within a scope of bumpversion? I've got some rough code to do this, I could polish.
Idea is to in one command:

update changelog and commit
print out the changelog (for 3party systems, wiki, or ticket about preparing release or particular deployment)

Configuration would be based probably by defining regexps.

Hi @fizyk,
I don't think bumpversion should generate the change log, because this is a different subject which isn't relevant to versioning. In my own opinion, the change log should be generated in parallel with the documentation: maybe with a Sphinx extension (see: changelog extension).
In order to generate the change log, you need to:

define rules (a small grammar) that developers should follow to have formatted commit messages (see, for example: Angular JS – Git Commit Guidelines),
define a way to filter messages (select only relevant messages);
define a change log format to layout your change log (using reStructuredText or Markdown together with a template engine: jinja).

JavaScript developers can use: git-changelog.
Long is the road…

@fizyk thanks for opening this issue
However, as @tantale outlined already (thanks for the great overview!), this is indeed outside of the scope of this project. While I'd love to have auto-generated changelogs for all of my projects, this is probably not the place for this to be implemented. bumpversion exists to bump version numbers, not more not less.
However, I'm open to accept ideas/concepts/pull requests/etc. that allow interaction with tools generating changelogs. Given that bumpversion knows about how to bump versions for the project, inspecting that information might be a useful property when generating changelogs.

Hmmm... @peritus  you're right. Maybe i've just looked to broad at this. With ie pypi releases being triggered by tagged builds on travis, bumpversion does get a central point of each release ;) Though it could be more valuable to trigger a command just before bumping versions...

+1 on having the ability to execute a command before committing. I for example use auto-changelog to update my changelog. I now have to do the following steps:

Call bumpversion (While having specified that it doesn't create a tag.
Create the versioning tag myself.
Run auto-changelog.
Commit.

@rickstaa take a look at that pull request to bumpversion's fork:
https://github.com/c4urself/bump2version/pull/101
Till it lands there I'm using my fork of a fork and install it from git


EVM: Update EVM Related Dependencies

Summary
Reth and revm has undergone lots of changes lately, thus we should upgrade other EVM related dependencies before getting started with more RPC related issues.
Dependencies to update

reth-primitives
reth-rpc-types
reth-revm
revm
revm-primitives

New versions of dependencies adds CANCUN upgrade. CANCUN upgrade introduces EIP-4844 aka proto dank-sharding. Proto dank sharding introduces new blobspace in blocks to support arbitrary data, especially to increase rollups throughput. Does it makes sense to introduce or even allow this upgrade to Sovereign SDK produced rollups?


npm support

Could you put js-emoji on npm as well? It'd be cool if we could keep track of js-emoji versions the same way we do with our other packages. (we'd prefer not to add bower just for js-emoji).

sure - send a pull request?

@iamcal there's nothing to change in the code, just run npm publish

I am unable to publish the package as it's too large (~90MB) and just breaks npm. Because it contains the emoji images, it's hard to make it a lot smaller. i'll try stripping more of the source images and see if it will upload then.

nope, just times out again (51MB now). i'm not sure what to do, since the js-library needs the correct rev of the images to work. npm does not seem like the correct mechanism for distributing 50MB of images, so maybe some workflow that tars the images and puts them elsewhere?

this is being fixed in the emoji-data repo by packaging just the spritesheets. once that works, i can make that a dependency

:+1:
Sounds like you've got it from here, @iamcal, but if anything comes up, lmk and I'd be happy to help get this resolved.

Any updates, or need any help, @iamcal? :) I'd be willing to put in some time to get this worked out, if there's anything I can do.

Bump?

sorry, i just don't use npm. patches welcome

You can't submit a patch - you need to install npm, run 'npm init', fill out the relevant fields, and run 'npm publish'

@MaxLeiter did you read the above comments? He tried, and it was timing out. It seems like we'll need some source updates before the request can go through. Would you have time to try your hand at making the changes @iamcal suggested above?

FWIW I was just having some trouble with yarn hanging while installing the package and I did a yarn cache clean and then yarn install was able to install js-emoji without issues.  Yarn is just a wrapper for NPM, so maybe this issue is resolved?

Workaround to at least get this require'd:
node_modules/js-emoji/index.js:
module.exports = path/to/bower/js-emoji

Then copy package.json to that directory.

@iamcal can you publish this without the emoji-data submodule?
This way we can use the data in lib/emoji.js through dependency management.
E.g.:

Empty the submodule directory (or temporary move it away)
npm publish

Hmmm...it seems I'm unable to get this package installed from a git SHA. I went back to an old project, cleared node_modules, and tried to reinstall. It just hangs. I'm using the same version of Node and npm as before.
 You can look around, make experimental
npm verb checkoutTreeish changes and commit them, and you can discard any commits you make in this
npm verb checkoutTreeish state without impacting any branches by performing another checkout.
npm verb checkoutTreeish
npm verb checkoutTreeish If you want to create a new branch to retain commits you create, you may
npm verb checkoutTreeish do so (now or later) by using -b with the checkout command again. Example:
npm verb checkoutTreeish
npm verb checkoutTreeish   git checkout -b <new-branch-name>
npm verb checkoutTreeish
npm verb checkoutTreeish HEAD is now at 65bb0c5... cut release 3.0.2
npm info git [ 'submodule', '-q', 'update', '--init', '--recursive' ]

Versions:

Now using node v6.7.0 (npm v3.10.3)

And lastly, the dep from package.json:
"js-emoji": "git+https://github.com/iamcal/js-emoji.git#65bb0c504efc6dd875fb251b77e6f27e84e67d1a",

Is anyone else having this issue? 🤔

it's now on npm as emoji-js, not including any of the images.
my intention is to split the images into their own npm packages, maybe one per image set

that work is tracked here: https://github.com/iamcal/emoji-data/issues/84

@iamcal , I just now switched over to the npm package. It works great. Just wanted to say thanks!


Why the CrossCurrentActivity.Current.Activity hack (Activity isn't used)?

OpenBrowser unfortunately just opens and independent Chrome chrome instance (latest NuGet, XF <IP_ADDRESS>, compiled against API level 25, phone is an S6 with API level 24). Works fine on iOS! Any hints on how I could diagnose this?

Ok, this seems to be because of that if condition here:
            if (CrossCurrentActivity.Current.Activity == null)
            {
                var intent = new Intent(Intent.ActionView);
                intent.SetData(Android.Net.Uri.Parse(url));

                intent.SetFlags(ActivityFlags.ClearTop);
                intent.SetFlags(ActivityFlags.NewTask);
                Application.Context.StartActivity(intent);
           }

That activity is not set by the framework, but through a lot of callbacks in the sample's main activity. However, it's not used at all to actually launch the tabs. Why is this necessary in the first place?

The current activity lays down a "MainApplication.cs" file into your application and it is required.

It is used below: intent.LaunchUrl(CrossCurrentActivity.Current.Activity, Android.Net.Uri.Parse(url));

My bad about the usage. That's an embarassing one, sorry :/
About the MainApplication.cs - I don't have that file, and just setting the activity in the MainActivity as posted above works fine: My custom tabs are working now. You sure about that requirement?

Yeah, it should add in: https://github.com/jamesmontemagno/CurrentActivityPlugin/blob/master/files/MainApplication.cs.pp when you install the dependency. Not sure what mechanism you used to install the nuget though, but it should.


Polymorphic Node npm module (Error: Cannot find module)

My Environment

Software
Version

Operating System
OSX Catalina 10.15.2

Jets
2.3.12

Ruby
2.5.3p105

Expected Behaviour

From the root directory of the project, i have installed npm module, eg: npm i file-type --save
I should be able to require that npm module and use it on node files.

Current Behavior
Jets::PolyFun::NodeError:     at Function.Module._load (internal/modules/cjs/loader.js:552:3)
        at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
        at Module.load (internal/modules/cjs/loader.js:620:32)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
        at Module._compile (internal/modules/cjs/loader.js:721:30)
        at Object.<anonymous> (/privateapp/controllers/images_controller/node/resize.js:5:18)
        at require (internal/modules/cjs/helpers.js:20:18)
        at Module.require (internal/modules/cjs/loader.js:657:17)
        at Function.Module._load (internal/modules/cjs/loader.js:529:25)
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
        Error: Cannot find module 'file-type'

Step-by-step reproduction instructions

On app root directory npm install file-type --save
Defined routes, controller and node folder as according to docs
Required npm module on the file
Got an error when trying to use that npm module

Here is the screenshot:

Guessing this might work at the function folder. Since a polymorphic shim handler really only knows about what's in it's own folder. Closing this out to clean up issues.


Updating debug scripts path.

The current wcnscripts are referring to invalid locations. This pr takes care of referring to valid locations.

/assign @daschott @debj1t @kestratt

Same set of changes required for other scripts in the repo: starthnstrace.ps1 startpacktcapture.ps1 dumpVfpPolicies.ps1

Addressed

/cc @daschott @kestratt @debj1t


Training on Mutiple GPUs

Hi there, @zc-alexfan!
Does HOLD support training on mutiple gpus?
I've tried to modify train.py so that the trainer can use four gpus at the same time using strategy="ddp" in pl.Trainer() and specifying the devices beforehand, but there seems to be an error saying that the tensors are expected to be on the same device, and therefore I can't use more than one gpu. I'm wondering if there are any methods to solve this problem :D
Thank you for your time!

Hi,
Sorry I didn't try multi-gpus. It should be feasible as the framework is in PL.

Thanks for the quick reply @zc-alexfan !


change patternfile enpoint

Description
Almost forgot in this commit
the patternfile endpoint is renamed to  /pattern
This PR fixes #
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Alright   , one sec let me sync my fork


blank page in some browsers while others show successfully

@wang0618 Hi, I am running below code on centos and using PyWebIo of 1.6.0 version. It shows successfully on my Google Chrome and my mobile safari, but it shows empty on Safari (including private mode). However, it shows empty on Chrome and shows successfully on 360 browser on my other laptop. Eventhough, it shows successfully on safari if I ran the code locally. And it did work well on safari earlier.
I am so confused , this bug doesn't come out in an expected pattern or rule.
from pywebio.output import *
from pywebio.session import info as session_info

def pywebio_test():
    put_info(session_info.user_agent)

start_server(pywebio_test,host='<IP_ADDRESS>',debug=True, port=3000,cdn=False)

Sorry for late reply, if you provide me your server address, maybe I can help to diagnose the problem


Save me ! Please help me . I am crashed.

i was trying to upload a pic to the server. I use AsyncHttpClient to send a post request.
i should get the response like  this
<meta http-equiv='Refresh' content='0; url=bbsupload2?board=Pictures
&file=10104&name=LilyDroid0605184406.jpg&exp=UploadByLilyDroid
&ptext=
'>

but i got nothing!   nothing!
i dont know what was wrong. when i debug, i can step into the onSuccess method.  the headers is ok! but the responseBody is empty. why! I am crashed.
this is the code:
public static void uploadFile(Context context,final WaitDialog waitDialog,File file){

        AsyncHttpClient ahc=new AsyncHttpClient();

        String url=Constants.getUploadUrl();

        ahc.addHeader("Content-Type", "multipart/form-data");

        String cookie=BaseApplication.getCookie();
        if(cookie==null){
            cookie=BaseApplication.autoLogin(context, true);
        }

        //njubbs_upload36649831.jpg
        ahc.addHeader("Cookie", cookie);
        RequestParams rp=new RequestParams();

        try {
            rp.put("up", file);
        } catch (Exception e1) {
            e1.printStackTrace();
        }

        rp.put("exp", "");
        rp.put("ptext", "text");
        rp.put("board", "Pictures");

        ahc.post(url, rp,new AsyncHttpResponseHandler() {
            public void onSuccess(int statusCode, Header[] headers, byte[] responseBody) {
                LogUtil.d("结果："+statusCode);//Content-Encoding: gzip
                waitDialog.dismiss();
                if(statusCode==200){
                    try {
                        String result=new String(responseBody,"gb2312");
                        LogUtil.d("result:"+result);
                    } catch (Exception e) {
                        e.printStackTrace();
                    }
                }
            }

            public void onFailure(int statusCode,
                    Header[] headers,
                    byte[] responseBody, Throwable error) {
                waitDialog.dismiss();
                LogUtil.d("结果："+statusCode+ new String(responseBody).toString());
                error.printStackTrace();
            }

        });
    }

求大神帮忙啊！折腾一天没解决！我现在处于崩溃边缘！大哭

Have your tried a normal http post request other than asyn-http? Is the response correct in that way?

Issues in this project are meant to track bugs and feature requests, not general programming questions.


Nuget Gallery is out of date

The nuget gallery seems to be quite out of date. Could it be udpated to the latest version?

Done - https://www.nuget.org/packages/MSBuild.Extension.Pack/1.9.1 has the <IP_ADDRESS> bits

Thanks

Why not have the version numbers in the NuGet feed line up with the ones on GitHub? It's confusing - I had to find this issue to know that 1.9.1 is actually up to date.


Bug: eqmac preventing macbook to sleep with coreaudiod

Disclaimer:
Please go through existing issues to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

[x] I have checked for a similar issue and sure it hasn't been reported before.

Describe the bug
Playing video on safari even with any player with eqmac turn on prevent macbook to sleep even the player is close. Quiting the eqmac app solved the issue
Steps to Reproduce
Steps to reproduce the behaviour (feel free to change the placeholder as you need):

Open Safari then go to Youtube then play any vid or play any song or vid locally on your mac
Quit the Safari or Player
Close the lid or put your mac on sleep
eqmac now preventing the mac to sleep or can't go to sleep

Expected behaviour
The mac cant go to sleep mode and just wake immediately
Setup information:

Audio device used for playback: [MacBook Speaker]
Audio transmission interface: [MacBook Speaker]
macOS Version: [Ventura 13.6.4]
eqMac Version [v1.8.7] (if audio related issue)

Screenshots or Console.app logs
If applicable, add screenshots to help explain your problem. Also you can run Console.app and apply filter for eqMac

Additional information
Quiting the eqmac solved the problem

I'm having a similar issue. 2018 Mac Mini (Intel) using an external display via HDMI.

I'm having a similar issue. 2018 Mac Mini (Intel) using an external display via HDMI.

Even I don't even use HDMI on this mac, I have other laptop for that

Duplicate of https://github.com/bitgapp/eqMac/issues/645, find solution in there - I can see your Pause Audio Processing is set to Never which is causing the prevention from sleep


Fixed : Dark mode in shop section

fixes #706

In dark mode , the item cards have white background, which may not look good to the user , I have made them according to the dark theme

Fonts of the header part where discription of fruits , herbs , etc was written was not visible so I changed its color in dark mode.

Before:
https://github.com/Anushkabh/krishiconnect/assets/162733812/ff430f37-30d1-482b-a97d-69026e27c77b
After :
https://github.com/Anushkabh/krishiconnect/assets/162733812/b19a3ce1-fb82-4084-acf6-af24adc7feaa

@himanshu-03 Please review my PR and merge it...Thank you!

Great work there

Thank you !


Suggestion details layout issues

On Edge
run monaco-editor/test/index.html?editor=dev
Type something like window.add
Press Ctrl+Space

Focus out or close suggestions. Press Ctrl+Space again:

I could reproduce this on Chrome too.
The only difference that I can think of is the editor fixedOverflowWidgets option, which is true in VS Code and false in the standalone editor.
Here are the scenarios where the suggest widget should be positioned correctly:

when the editor is in a fixed element: mouse-fixed.html
when the editor is in a scrollable body: mouse-scrollable-body.html
when the editor is in a scrollable element: mouse-scrollable-element.html

And the browser matrix is: IE11, Edge, latest Firefox, latest Chrome, Safari.
The setup details for running the editor from source are here. Remember to click on the dev to run the editor from sources!

Fixed with https://github.com/Microsoft/vscode/commit/80a557774822998c698ac0f7eee44043de5f5a21
The issue was that I used the StorageService to store user choice of expanding docs.
Storage Service is not available in Monaco editor

Thank you for looking into this promptly and thank you for fixing the details not showing up again.
The test pages can be edited to change the language to javascript and then JavaScript code can be copy-pasted in the editor to try out suggestion details. e.g. for mouse-fixed.

The following issues remain:
1. The suggestions are positioned to the bottom (away from the cursor)

v0.8 on Chrome
master on Chrome
VS Code

2. Once details are shown once, the suggestions permanently remain positioned wrongly

test page test/mouse-scrollable-element.html with an edit to change the language from xml to javascript.

v0.8 on Chrome
master on Chrome
VS Code

3. The details are not positioned under the suggestions if the page is narrow

test page test/mouse-scrollable-body.html with an edit to change the language from xml to javascript.

v0.8 on Chrome
master on Chrome
VS Code

First issue is fixed with https://github.com/Microsoft/vscode/commit/97331424b12948ddac23e00302e72c8a6fac4591
Second issue, your gif doesn't work, so am not sure what the problem is :(
The third one I can repro only after re-sizing and no refresh. Can you confirm? If that is so, then this is due to https://github.com/Microsoft/vscode/issues/27676. Is this a blocker?

Turns out fixing https://github.com/Microsoft/vscode/issues/27676 (I just did) won't fix the third issue.
Because changing the window size doesn't mean changing the editor size which is what I was listening to in the fix for https://github.com/Microsoft/vscode/issues/27676.
Any other event you know that I can listen to?

Attaching recording of the recording playing for me

Re 3:
I typically avoid caching window sizes or dom node positions between paints if there is a likelihood that they have changed.
So I think it is totally ok if the widget is shown, and the browser is resized while the widget is shown, and then the widget does not immediately react to the new browser size (i.e. I don't think there is a need for a listener). But, if the widget is hidden and then shown again, it should adopt to the new window size.
The problem is that very many things can lead to a change, i.e. there could have been a user scroll on some parent dom node, or perhaps the integrator inserts new dom nodes to the page, etc. so IMHO there is no event that can capture all these cases except perhaps some specialized mutation observers, but I don't think we should go down that path.

But, if the widget is hidden and then shown again, it should adopt to the new window size.

This is tough to do as well. The widget has no knowledge about the window size. It only has knowledge about the editor size.
In VS Code, I overcame this problem by re-using the max-width set on the widget by the editor.layoutContentWidget(). But in the case of test/mouse-scrollable-element.html, the max-width on the widget doesn't react to the window size.

@ramya-rao-a with document's scrollLeft, we should be able to know where the widget is position in current window. And then with document.documentElement.clientWidth, we can know the window size and check if there is enough space for rendering the suggestion details side by side.

@rebornix That would mean accessing the document in the window. suggestWidget is not aware of that

:+1:
Let's postpone the corner cases for now.
The suggest widget works a lot better now with the two changes from @ramya-rao-a . Thank you!

Is there a way I can force the suggestion to always appear below the cursor? I have some cases where it appears on top of it and it gets cut off by the container overflow

@belohlavek The suggestions should always appear below the cursor as long as there is space for it.

@ramya-rao-a is the space based on the wrapper container? I'm creating one/four lines expression editors for one of our products. Kind of excel like. We need to guarantee that hover suggestions appear under the cursor. Is there any way I can force this?

The decision to show the widget either above or below the cursor is decided by the layout. @alexandrudima can answer if there is a way to force it

Hey @alexandrudima is there actually a way to achieve this?

Closing as this will not be fixed.


Setting: only show notifications for messages from contacts

I cleaned up and made minor additions to the work done in PR #1395

lgtm


Start documentation chapter for plugin tests

Lets start from here. I will continue as soon as I have something working...

Format looks ugly...
Will fix tomorrow
Good night :-)

Looks better now.

Thanks. I added your comments. I think we can publish it for the moment and add details as soon as we have them.

In the "do some work here" I think it would be a good idea to have some examples of what testing might actually be performed

Definitely...
But that's the next chapter :-)


Error stripe ignores scale display settings

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.71.2 (user setup)
OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

Change scale to 125% in Display Settings (Windows 10 Control Panel)
Write something that appeals as error/warning:

Expected behavior:

I'm unable to repro, but I'm also on Windows 11.
Is this issue still occurring for you on the latest Insiders?

I can't reproduce it anymore. May be fixed now.

Closing for now. Let me know if it reappears again


Fix type error

Fix type error displayed in strict mode when using common patterns

The point of the types is to make sure you use the right parameters, which seems to have been curbstomped in this fix

if I understand what you mean correctly, from the many attempts I made, there doesn't seem to be a good way to make the parameters specific to types of components show up in auto-complete for the World.Component.Build function
I can continue looking, it'd help if you could show how you've been testing it


only wrap fill in url css function when url is detected

this lets you use colors with the fill prop:
<Hexagon fill={"red"}/>
<Hexagon fill={"#f00"}/>
<Hexagon fill={"http://foo.bar/some-image.jpg"}/>

@json2d I think it is actually better to remove the "smartness" of the Hexagon and just expose the api of the underlying component.
Ill let this PR open to keep track of this issue, but have no intention to merge. Thanks for your effort, hope you will be ok with a slightly different solution.


Automated cherry pick of #5277: fix: 新加gcp region 翻译

Cherry pick of #5277 on release/2.13.
#5277: fix: 新加gcp region 翻译

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@af7d67c). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.13   #5280   +/-   ##
==============================================
  Coverage                ?   6.81%
==============================================
  Files                   ?     530
  Lines                   ?   90016
  Branches                ?       0
==============================================
  Hits                    ?    6135
  Misses                  ?   83372
  Partials                ?     509

Flag
Coverage Δ

#aFlag
6.81% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7d67c...42426d7. Read the comment docs.

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm

/approve


allegro4: 4.4.2 -> <IP_ADDRESS> (fixes atanks & racer)

Motivation for this change
Fix atanks, which was marked broken as part of
ZHF: #80379
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"[511 built, 1202 copied (7508.4 MiB), 1807.6 MiB DL]
8 package built:
allegro atanks cgui dumb garden-of-coloured-lights lutris lutris-free racer

[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Maintainer: @7c6f434c

@ofborg build atanks


Disable authentication fallback

Review app deployed to https://teaching-vacancies-review-pr-3097.london.cloudapps.digital


Bug relation mutators on to array

Resolves #26404
Not sure if relationsToArray was the best place to fix this, I think it is because it is also used in the attributesToArray method. (Both are used in the toArray() method.)

I’m not sure mutators were really ever intended to work with relationships. I know I personally never intended to work that way when I wrote them and this would be a breaking change.

I think they do, when accessing relations in a normal way, the mutators do get triggered. And the toArray() method should be an 'exact' copy of the model's properties.
But it could be a breaking change. Should I make a pull request for the next version?


req: Add searchable View List/Trace List

Trace Compass's Trace Servers are getting more and more views. This is a positive, but now we must manage the views in a better way than just a simple list.
It would be good to have a search to find the type of view that we want to display.
This also applies to traces. I have 200+ traces in my trace server, so having a way to find which one I was viewing would speed up my workflows.

+1 for flat list not being sufficient with a larger number of views!
Re view organization - There are a few existing issues that discuss view organization suggestions in a fair amount of detail #156, #157, and #158.


No Toaster Containers have been initialized to receive toasts.

I'm using angular2-toaster with angular-2 rc.2, and I get this error above. I have an example set up exactly like that on the front page, with the <toaster-container></toaster-container> in the template.

Never mind, figured out this one was because I was trying to do it on ngOnInit, instead of ngAfterViewInit.

I'm getting the same error reported in the console when I try to use pop(message: string), but I can't see anything in the docs telling me I need to initialize the container, or how I might do such a thing, or when.
tchoulihan is doing something in the ngAfterViewInit event, but what?

@brianlowe can you please provide a bit more context on what you are doing and how your code is structured?  Most likely you are calling pop from the constructor, before the container is rendered to the DOM.

@Stabz - thanks for a rapid response!
I'm just beginning with Angular2 (no experience of Angular 1) so my app is quite simple so far. I have a component with a clickable button wired to a handler that just raises an alert in the browser. Obviously that's not going to be testable so I need to replace it with a toaster.
So far I've added the import { ... } from ...  line at the head of my component, and added providers: [ToasterService], directives: [ToasterContainerComponent] in the @Component decorator, and added private _toasterService: ToasterService as a constructor argument.
My layout includes <body>     <toaster-container></toaster-container>
Now, in my button's click handler I replaced alert("todo - act on this click"); with this._toasterService.pop("todo - act on this click"); and as soon as I click the button I get this error in the browser tools console.
I can't see anything in the sources or in the test specs that might show me where I would initialize the toaster, so I don't know what I've missed.

Hmmm, my layout has the component's markup as a child of the  element, but in the examples the component's tag is always given inline with the calling element's template. Maybe the initialization I'm looking for is automatic when the toaster component is found and parsed within my view...
I've tried moving my <toaster-container> tag to include it as part of the markup loaded by my component, but that raises a different error: Template parse errors:
Can't bind to 'ngSwitchCase' since it isn't a known native property

@brianlowe It is difficult to pin down the exact cause of the issues you are having without a plunker, so if you continue to have difficulties, please create one and I'd be happy to walk through it.  That said, here are a few observations:

The pop call is incorrect and will cause issues.  The first argument for pop() is the toast type, not a title or body.  As a result, if it tries to map the string you've passed as a type, it'll certainly cause issues.  Perhaps better error handling can be added around this.
Your setup of the actual container seems very reasonable and your inclusion of both the service and the container component looks perfect.  However, as you noted in your subsequent comment, the component markup IS inline with the calling element template.  This is for bootstrapping purposes in your Angular 2 app.  Angular 2 is a bit different in how it initializes and you need to make certain that the app is initialized before rendering subsequent components.
Now, this brings us to the next point...it looks like by moving your <toaster-container> inclusion to your template, you are now properly bootstrapping the library, which is great!  However, it looks like you have a mismatch in version.  Since angular2-toaster 0.3.5-rc.2, Angular 2.0.0-rc.2 or higher has been required due to changes in Angular 2's switch/case syntax.  As a result, please make sure you are using a current version of angular 2 (I recommend rc 3 or 4) or use a more deprecated version of angular2-toaster, which I don't recommend since I've made additional bug fixes in the last few versions.

If that doesn't help you get going, please feel free to create a plunker and I'll be more than happy to take a look and help you get it up and running.

@Stabzs Thanks for this. I've reworked my code a little so I now have the latest angular (rc4) and dependencies, and by passing the correct arguments in to the pop() method I can get a toast to appear in my page.
Now my problem is with the configuration.
When I include [toasterConfig]="toasterConfig" in my tag errors are thrown in ng_class.ts line 111 where it tries to trim a className but className is undefined. If I leave out the config and rely on the defaults, this line is hit several times with various class names, or empty strings, but never with undefined. If I use an empty toasterConfig, or one with all of its members populated I hit the same undefined className problem.
I've tried to set up a plunker to illustrate the problem, but that seems like another learning curve to struggle with right now. I get nowhere.
I don't expect you to spend lots of time on this, but thanks for your help so far.
One other thing though... I wonder why pop's first argument accepts an argument of type string | Toast when there are only 5 usable string values. You could check the passed value at the start to make sure it's valid, but maybe it would be better to rely on TypeScript's typing by creating a ToastType enum as info | wait | error | success | warning and requiring the first argument to be ToastType | Toast.

So, if I create a config object with
this.toasterConfig = { positionClass: "toast-top-full-width" }
then TypeScript is happy because the object meets the ToasterConfig interface definition, but deep into the generated ToasterContainerComponent.template.js code it finds an array
["toast-top-full-width", undefined]
and passes each member to ng_class_toggleClass, which crashes out trying to apply .trim to the undefined className.
If I create a config object with
var cfg = new ToasterConfig();  cfg.positionClass = "toast-top-full-width";  this.toasterConfig = cfg;
then the array found in the generated code is
["toast-top-full-width", ""]
and the ng_class._toggleClass code is OK with the empty string passed.
I now have a working setup. Yayy!


Update README.md

Typo - brakes -> breaks

Thanks for fixing that @AlexNodex!

Typo - brakes -> breaks

Typo - brakes -> breaks

Already been submitted and merged!


My Stake green highlight doesnt light up for pending stake

Description
You get the green text on your pending stake column which is nice.
But really it should presumably also light up the My Stake button over the STAKE button.
At the moment it doesnt, and therefore it also doesnt appear if you set the toggle to Staked by Me
Steps to Reproduce

Go to validators
Click on STAKE and add some stake to someone
You will see some pending stake
But you wont see the other things I mentioned

Expected behavior
MY STAKE shoudl light up and be included in the toggle
Screenshots

Additional context
Add any other context about the problem here.

@JonRay15 this is by design. The green indicates the things that are specific to me. And My Stake is what I have staked this epoch, which is why the stake button for PathrockNetwork isn't green because you don't have anything staked for them this epoch. Next epoch, you would have a green my stake button.
We are pretty comfortable this makes sense, but will keep an eye out for feedback from anyone else that indicates this is confusing 👍


haddock-library fails due to invalid cabal file?

I see this when trying to build haddock-library on nixpkgs-unstable today:
Setup: ./haddock-library.cabal:5: Parse of field 'license-file' failed.

The field in question is given as:
license-file: LICENSE vendor/attoparsec-<IP_ADDRESS>/LICENSE

Pinging @peti

Works fine:
$ nixpkgs-build -A haskellPackages.haddock-library
/nix/store/j867bs249ysh84wnz02j4fx984vxc80k-haddock-library-<IP_ADDRESS>

Hello,
I have exactly same problem. I tried to set up my environment to GHC 8.2.2 by changing haskellPackages to ghc822. If I try to compile haddock-library sources with cabal <IP_ADDRESS> by hand, everything works normally.
% sudo nixos-rebuild switch -j 1
... output omitted ...
building '/nix/store/jg11ns87cy5qz9sjrlqzlz2ajyvrdjlj-haddock-library-<IP_ADDRESS>.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/sfzz2izjjzjf5zjaz77vp41ay12i55gq-ghc-8.2.2.
ignoring (possibly broken) abi-depends field for packages
unpacking sources
unpacking source archive /nix/store/m19zmc1vfgvj1wdb8sacgkanpd7j73gn-haddock-library-<IP_ADDRESS>.tar.gz
source root is haddock-library-<IP_ADDRESS>
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file haddock-library-<IP_ADDRESS>/vendor/attoparsec-<IP_ADDRESS>/LICENSE
patching sources
Run jailbreak-cabal to lift version restrictions on build inputs.
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j1 -threaded
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/z6hvnji7bqadyk6klp70fywlmajvr930-haddock-library-<IP_ADDRESS> --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j1 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --disable-executable-dynamic --disable-tests --enable-library-vanilla --enable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/s2n99784krxl91mfw3cnn9ylbb5fjvkx-ncurses-6.1/lib --extra-lib-dirs=/nix/store/rxaclc3vhxbzgfllv7601i85z854h48a-gmp-6.1.2/lib
CallStack (from HasCallStack):
  dieWithLocation', called at libraries/Cabal/Cabal/Distribution/PackageDescription/Parse.hs:595:9 in Cabal-<IP_ADDRESS>:Distribution.PackageDescription.Parse
  action, called at libraries/Cabal/Cabal/Distribution/Utils/Generic.hs:263:35 in Cabal-<IP_ADDRESS>:Distribution.Utils.Generic
  withUTF8FileContents, called at libraries/Cabal/Cabal/Distribution/PackageDescription/Parse.hs:611:22 in Cabal-<IP_ADDRESS>:Distribution.PackageDescription.Parse
  withFileContents', called at libraries/Cabal/Cabal/Distribution/PackageDescription/Parse.hs:592:3 in Cabal-<IP_ADDRESS>:Distribution.PackageDescription.Parse
  readAndParseFile, called at libraries/Cabal/Cabal/Distribution/PackageDescription/Parse.hs:611:5 in Cabal-<IP_ADDRESS>:Distribution.PackageDescription.Parse
  readGenericPackageDescription, called at libraries/Cabal/Cabal/Distribution/Simple.hs:243:19 in Cabal-<IP_ADDRESS>:Distribution.Simple
  confPkgDescr, called at libraries/Cabal/Cabal/Distribution/Simple.hs:209:33 in Cabal-<IP_ADDRESS>:Distribution.Simple
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:174:19 in Cabal-<IP_ADDRESS>:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:119:27 in Cabal-<IP_ADDRESS>:Distribution.Simple
  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: ./haddock-library.cabal:5: Parse of field 'license-file' failed.
builder for '/nix/store/jg11ns87cy5qz9sjrlqzlz2ajyvrdjlj-haddock-library-<IP_ADDRESS>.drv' failed with exit code 1
building '/nix/store/5f6kkgwc5f48k9b32ki3z083g0darkmb-hint-0.8.0.drv'...
cannot build derivation '/nix/store/6q1rp0iq759s24zw4nxm1d741mhm2b04-pandoc-2.2.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fklyv27dwsiadm6z23x24jr8z58vnjd5-xen-4.8.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/s7j5qdv7xh7naajrssi6ckfybxw5h3j6-libvirt-glib-1.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7gv3s3psgnmf83iw25cgkx2ps2n6wz9n-virt-manager-1.5.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7nm7nc0akpk6p4ymdqirk5hz9jw6spv5-system-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0phjyzzzsa2xxa92xda6gj83y6cgbyng-nixos-system-the_nix_tcz-18.09.812.8cfce968b1a.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0phjyzzzsa2xxa92xda6gj83y6cgbyng-nixos-system-the_nix_tcz-18.09.812.8cfce968b1a.drv' failed

System Information
% nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.74, NixOS, 18.09.812.8cfce968b1a (Jellyfish)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.1.1`
 - channels(jirka): `"nixpkgs-19.03pre154487.0a7e258012b"`
 - channels(root): `"nixos-18.09.812.8cfce968b1a"`
 - nixpkgs: `/home/jirka/.nix-defexpr/channels/nixpkgs`

packageOverrides = super: let self = super.pkgs; in rec {
  ... output omitted ...
  haskellPackages = self.haskell.packages.ghc822;
}


Apply a bunch of python 3 compatibility filters

This branch is partial progress towards making Zulip support Python 3.
The approach I've been taking is applying safe filters from the 2to3, futurize, and modernize libraries to make the Zulip code closer to Python 3 support without breaking anything in Python 2.
This partial progress should pass tests and be basically mergable; the only one in this pull request that I feel does something problematic to the code is libmodernize.fixes.fix_dict_six, which changes a bunch of cases that are in iterator context and don't need to be; I think my plan would be to skip merging that commit for now.
This branch passes tests on Python 2 and with a bit of hackery (removing dependencies, fixing some encoding things, etc.) I got it passing like 90% of our tests on Python 3.  We'll need to fix those issues properly so I'm leaving them out of the PR and just including the stuff that seems sane.

Automated message from Dropbox CLA bot
@timabbott, it looks like you've already signed the Dropbox CLA. Thanks!

@lfaraone this can't be merged as-is since it conflicts with some other stuff, but I can easily regenerate it by just rerunning the filter commands.  Can you review this branch for being something we should merge (assuming I regenerate it on top of current master)?

This looks reasonable to me. My only concern is preventing python3 regressions if we don't have test coverage. Do you think adding skipifs to the 10% of tests that fail on python3 and getting a travis build running for the rest would make sense?

It's a bit more complicated than that, in that one needs a bit of dependency hackery to get to 90% passing (e.g. ripping out python-ldap and python-twitter).  My theory is that python3 regressions aren't a super big deal in a codebase of our size, and we can open tickets to track the work needed to get it the rest of the way.  But if we wanted to, we could add a build that just runs the N 2to3 tools that have been fully applied, and errors if the result is not a nop.


Bug with users signing up where they are not sent to dashboard

After a user fills out data and hits save, they should have been redirect to dashboard. On the docker-compose-fixes-nginx branch this doesn't happen
Workaround: user goes back to login page and logins in with the account they just made.
Branch bug was found in: docker-compose-fixes-nginx

Could be related to http to https rerouting?

Fixed in docker-compose-fixes-nginx. There was a none object that sunk into the return method breaking the system. I removed the object from return method and it worked


Update Citation

Updated the ORCID, DOI, and year in the CITATION.cff file to reflect the latest metadata. Also updated the DOI reference and citation year in the README file to ensure consistency with the new Zenodo release.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.50%. Comparing base (ae2b2ce) to head (cff60a8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   99.50%   99.50%
=======================================
  Files           6        6
  Lines         405      405
  Branches       22       22
=======================================
  Hits          403      403
  Partials        2        2

Flag
Coverage Δ

unittests
99.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PHP argument lists

Something I find myself wanting to do a lot is split and join PHP argument lists, as per PSR-2.
, separated argument lists are handled nicely for arrays in PHP (and no doubt other languages); if I were to make changes for argument lists, is the preference to add on functionality or generalise the array implementation? Thanks.

this would be nice, any progress sean?

Also interested!

In honesty, I'd forgotten about this. Think I did get something working though so I'll try and find it then put a pr up. Will be the weekend at the earliest though.

On 28 Jan 2015, at 18:26, Gonzalo Serrano<EMAIL_ADDRESS>wrote:
Also interested!
—
Reply to this email directly or view it on GitHub.

:)

This should be implemented now in master, thanks to @naquad. Could you all try it out and let me know if it seems to work alright?

Only a year later but this works now.

Glad to hear it :). This reminds me I also have quite a few year-late issues I should be taking care of...


svcat CLI can now filter the classes return by broker in svcat get classes via a --broker flag

This PR is a

[x] Feature Implementation
[ ] Bug Fix
[ ] Documentation

What this PR does / why we need it:
Adds filtering by broker to the svcat get classes subcommand via the --broker flag.
It also consequencely adds the broker providing the class to the table output of the get command.
Which issue(s) this PR fixes
Partially fixes #1749 but does not include the plans filtering (personally I filtering by broker as more appropriate on the classes as it almost the "parent" of that.  Let me know if you feel differently!
One think to note is that I've added a BrokerFiltered property to the GetCmd, I see that similar things are done on some commands, such as get instances but others like get plans uses a ClassFilter string. I chose the former but I would be interested if there was any context between the two choices!
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:

[ ] New feature

[ ] Tests
[ ] Documentation

[ ] SVCat CLI flag
[ ] Server Flag for config

[ ] Chart changes
[ ] removing a flag by marking deprecated and hiding to avoid
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update

looks like make verify didn't like your comment formatting?

Yep! Having problems getting verify running on my machine! Will fix that commit and try and get that sorted

/ok-to-test

other than the comment hiccup this looks great!
/lgtm

Ive added in the License that my previous commit removed, seems one of the make commands popped it out but still seems to be breaking.  My colleague is working on a branch hopefully that should mitigate some of the make verify problems.  Sorry for the blindish commits, hard to replicate locally!

Hi. @gmrodgers
you can always check the travis job: https://travis-ci.org/github/kubernetes-sigs/service-catalog/jobs/665834302?utm_medium=notification&utm_source=github_status
at the end of logs you will see there problem reported by verify
Boilerplate header is wrong for: ././pkg/svcat/service-catalog/service-catalogfakes/fake_svcat_client.go
Makefile:207: recipe for target 'verify' failed
make: *** [verify] Error 1

the make verify can be also executed locally. I'm able to do it on MacOS

Hey @mszostok I've reverted the changed to the boilerplate, hopefully will flow through now :)

I've tested that and it works like a charm :)
Please see this comment: https://github.com/kubernetes-sigs/service-catalog/pull/2786#discussion_r396624158 and introduce that const and this will be ready to merge 👍

I think making it a const so the blank value seems less magic is a good idea. Not sure how I feel about the funcs as args, though.

Hmmm so I squashed the commit into one feature commit but Im struggling to see whats causing the error above as it's logically equivalent to the one with the magic empty strings?  I can take more of a look at it next friday when I have time

/lgtm

/approve


show the onedrive-personal tab

Is your feature request related to a problem? Please describe.
I link to both ondrive-personal and onedrive for business services, but on the side panel there's only onedrive for business tab.
Describe the solution you'd like
Add a new tab for onedrive-personal, like traditional file explorer.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here. Ex: What device type/UI layout and app version?

This issue should be resolved with v0.20.


Problem with nonlocal variables

Simple example:
from numba import jit
def run():
  @jit
  def f(a):
    return n*a
  for n in range(5):
    print f(n)

prints five 0s. The pure python version correctly prints 0,1,4,9,16. This is using numba version 0.16.0, and python version 2.7.8.
I suspect it has to do with n being an integer (thus immutable) and so being re-assigned rather than modified in the loop. I don't know though.
I don't think this is a major problem - in most cases this can be fixed by passing another argument, and I could imagine the fix could be a lot slower. It's mostly just a notice that it doesn't quite work, and possibly it should be noted in the documentation somewhere.

Yes, closure variables are frozen when the function is compiled. In this case n is 0 when the function is first compiled, hence what you are witnessing.
This is a limitation we're going to document once the documentation overhaul is finished.

Closing as won't fix (we may want to do better one day, just not now :-)).


Rename BuildAlloc to BuildAllocRef for consistency?

Awesome work on this repo! You've packed a whole lot of improvements in!
Since you've renamed Alloc  to AllocRef, do you think it would make sense to change BuildAlloc to BuildAllocRef?

Thanks!

Since you've renamed Alloc to AllocRef, do you think it would make sense to change BuildAlloc to BuildAllocRef?

I think that might lead to confusion. You could interpret BuildAllocRef as build-AllocRef or as BuildAlloc-ref. What do you think?

Good point. That is potentially confusing. I think it might be worth it for consistency, though. As soon as you see that it's a trait, that confusion should be cleared up. And since there would no longer be a BuildAlloc to reference, BuildAlloc-ref probably would not be the default parsing.
(This is the same Scott, btw. Accidentally used work-dedicated account again.)

As soon as you see that it's a trait, that confusion should be cleared up.

Good point also. I'll re rename it to BuildAllocRef and wait for feedback if anyone will get confused. At least it's a trivial change and could easily be reverted :)