Data Generation

Tried to run demo_skel2RR.m file after copying the .mat generated in the first step and I got the following error
>> demo_skel2RR
 1

Error using svd
Input to SVD must not contain NaN or Inf.

Error in myscript_5_calculate_RR_W (line 32)
[U, S, V] = svd(S0);

Error in skel2RR (line 20)
[ R, ~, ~ ] =  myscript_5_calculate_RR_W( hip_points_wangchuyu2, hip_points_scape, weights );

Error in demo_skel2RR (line 40)
  [ RR,  R ] = skel2RR( skel, skel_scape );

I printed the values, and found it has a nan, what could be the reason, how to fix it?
skel =

   1.0e+06 *

    0.0000         0         0
    0.0000    0.0000    0.0000
         0    0.0000    0.0000
    0.0000    0.0000    0.0000
    0.0000    0.0000       NaN
    0.0000    0.0000    0.0000
    0.0000    0.0000    0.0000
    0.0000    0.0000    0.0000
   -0.2052    0.2239   -0.1732
    0.9907    0.1787   -0.1732
    1.0224    0.0280   -0.1732
    1.6550   -0.1944    0.3118
    0.9785    0.1787   -0.1732
    1.4086   -0.5319   -0.6151
    1.5216   -0.1191   -0.6151

Are your input be some， weird skeletons？
Or there are two same points in one skeleton?
If so, SVD will output error.
You may choose skeletons from CMU mocap dataset

I  followed the exact steps in your description . This means the same data you have used  when runnign  run demo_generateskel.m, an I got cmu_skeletons.mat which has a nan, I do not know why there is a nan in your dataset(which you said is taken from mocap dataset)
Human Poses

To generate human models, you should define their poses first. We use CMU Mocap Database as pose sources. This database contains about 4 million poses. To better cover the pose space, we also learn a Bayesian network from these poses.

To generate poses, You can enter 1-skel directory and run demo_generateskel.m directory. It will generate cmu_skeletons.mat, which contains part of poses from CMU Mocap Database.

To acquire more poses, you can download the asf & amc format zipfile from CMU Mocap Database and unzip them in data/asfamc directory.

Note that the code doesn't include the Bayesian network code. You can download it from the original website and use the generated poses as input to learn the model.

We adjust pose format from CMU format to our own format. See images in sources directory. Then we use poses to generate human models.

Human models

To generate human models, we adopt SCAPE. This model decomposes a human mesh into a set of pose parameters and shape parameters. You can generate infinite meshes by adjusting different poses and shapes.

To generate models, first you need to copy the cmu_skeletons.mat into 2-model directory. Then you can run demo_skel2RR.m and demo_RR2obj.m. The first m file will generate cmu_RR.mat file, which is used to transfer poses to rotation matrices. The scond m file will call scape to generate human models. The models are generated in data/models directory.

So you mean that you find a nan in cmu_skeletons.mat?
It must be something wrong because a skeleton should be real number rather than nan.
Which step lead to nan? demo_generateskel.m?

yes! demo_generateskel.m

I am sorry
I directly downoad the code and test the demo
but it seems everything goes well...
for i = 1:14
a = skeletons(i).data;
b = find(isnan(a(:)));
disp(b)
end
are you using data from my data folder or your own data?

data from your folder


shell: Make autocomplete work with non-sorted commands

This allows declaring the commands in any order which sometimes is
convenient when commands are conditional making it undesirable to
sort everything.
Signed-off-by: Luiz Augusto von Dentz<EMAIL_ADDRESS>

Codecov Report

Merging #10262 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10262   +/-   ##
=======================================
  Coverage   53.05%   53.05%
=======================================
  Files         214      214
  Lines       26200    26200
  Branches     5646     5646
=======================================
  Hits        13900    13900
  Misses      10027    10027
  Partials     2273     2273

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d177a...f5a168e. Read the comment docs.

@pfalcon fixed

@jarz-nordic can you review this one?

I think it is also worth to update documentation.

@jarz-nordic Does the documentation say anything about entries required to be sorted?

@Vudentz : yes, it is few times mentioned in shell.rst

@jarz-nordic I removed the references about alphabetically sorted from shell.rst, Ive also removed references of that in code as well.

@Vudentz : I will testdynamic commands as well. Possibly lines 64 - 65 must be removed as well.

@Vudentz : I tested it just now. Dynamic commands also work fine without sorting.
So shell.rst lines 64 - 65 shall be alo removed.

@jarz-nordic done


add a way to convert .dat playerdata  into .json playerdata

Describe the feature
add a something to convert minecraft base playerdata into multiverse playerdata.
How is the feature useful to all Multiverse users?
it will be usefull to transfer worlds form vanilla minecraft to multiverse worlds
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.

Although useful, this is a tad out of scope for MVINV. PRs welcome though!


import file resolution lower than web viewers

hi, when I import my GLTF file in blender it comes in with a lot lower resolution than what I see on web viewers. why is that?

well i also just now tried to export that same file back out from blender and it matches the input file in web viewers, so now my question is why does blender show the file at lower resolution?

Hello,
Not sure what you mean exactly by "resolution", but if you mean the visual size of your model : Most of online viewer do autozooming to the model, where Blender doesn't. There is no bug here.
I can't check in detail, because you don't fill the required information that you have in template when you create the issue (for example an sample .blend file and/or .glb file).

@anonMcAnonface Is there a sample model you can share, or screenshots to clarify the problem?

hello, sure take a look at the model attached
fountain_meadow_2ndver.gltf.zip

What I mean is that I load the GLTF file into blender and zoom in on it (or just press 7). Then compare that with some web viewers for GLTF (I like the babylonJS Sandbox). You will see that details in the model are readily apparent in the web viewer but in blender they look 'low res'.

What version of Blender, and what viewport mode are you in?  Try Blender 2.81, and click the "Viewport shading: Material Preview" button in the upper-right section of the 3D view.  It's the sphere with the checkerboard on it.

Ah ok, thank you! Will try that. I am currently using 2.81 but I have to switch back to 2.79. I cannot get the boolean operation to work correctly in 2.81. It is a different issue, I may open a new ticket?

You can always open a new ticket, but I don't think what you're seeing here is any kind of bug with the glTF-Blender-IO addon.  It's just that Blender displays the landscape without a texture on it, by default.  So you're seeing the "resolution" of the actual vertices, which is far less than the resolution of the pixels in the texturemap.  2.79 had a viewport shading mode too, across the bottom, that you might be able to change to see the texturemap.


Better UI for blame.email

HI,
I like the blame.email project, so I designed a better interface for it.

What do you think?

Hi! Sorry it's taken me so long to respond. I really like this.
If you'd like to PR the CSS for this, I'll gladly learn from you and merge it! If you couldn't tell already, I'm a hacker who throws spaghetti at walls, not a designer. I can't reiterate enough how much nicer this is than what I made. Thank you!! :)

OK, I'll share it soon.


add breaking change notice to all krew cmds

Looks like this:
$ out/build/krew-darwin update
W0912 12:58:28.998960    8579 root.go:43] Upcoming breaking changen notice:
+++++++++++++++++++++++++++++++++++++++++++++++++
WARNING: krew will soon introduce breaking changes to move to
the new plugin system introduced in kubectl v1.12 and it will stop
working until it a newer version of krew is reinstalled.This version of krew is compatible only with kubectl v1.11.
+++++++++++++++++++++++++++++++++++++++++++++++++
Updated index

/cc @lbb
what do you think

Manually flipping CLA bit (not sure what tipped it off).


how much disk space does some topics occupy?

The issue tracker is ONLY used for bug report(feature request need to follow RIP process). Keep in mind, please check whether there is an existing same report before your raise a new one.
Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration and other improvements.
Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:
BUG REPORT

Please describe the issue you observed:

What did you do (The steps to reproduce)?

What did you expect to see?

What did you see instead?

Please tell us about your environment:

Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):

FEATURE REQUEST

Please describe the feature you are requesting.

Provide any additional detail on your proposed use case for this feature.

Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

sub-task1-issue-number: sub-task1 description here,
sub-task2-issue-number: sub-task2 description here,
...

Please describe the feature you are requesting.
i want to know every topic in rocketmq broker occupied how much disk space?
&
i want to know every queue of the topic occupied how much disk space?
&
i want to how can i see the ordered topics which ordered by disk space?
Provide any additional detail on your proposed use case for this feature.
all the topics data are stored in the one file named commitlog so i can not know how much does each topic occupied.
Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
yes. this is very import to me.  so i really need know how to fix this problem.

Sorry, RocketMQ temporarily does not support such fine-grained occupancy classification.


DOCS: update CONTRIBUTING.md

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows dataverse guidelines link:
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been updated (for bug fixes )

What does this PR do?
seperated -> separated

Hello @eltociear . Thanks for your contribution.
I've also fixed a few typos in the CONTRIBUTING.md.
I am going to merge this in main with my changes. Thanks a lot again! 💟


[IntelliJ] iOS device selector shows idevice info in the dropdown + doctor output

[✓] Flutter (Channel dev, v0.10.0, on Mac OS X 10.14 18A391, locale en-US)
    • Flutter version 0.10.0 at /Users/andrewgrosner/flutter
    • Framework revision d954ae6850 (3 weeks ago), 2018-10-09 16:21:06 -0400
    • Engine revision bf377896ff
    • Dart version 2.1.0-dev.6.0.flutter-a50dfd6698

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/andrewgrosner/Library/Android/sdk
    • Android NDK at /Users/andrewgrosner/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/andrewgrosner/Library/Android/sdk
    • Java binary at: /Applications/Android Studio 3.4 Preview.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.4 Preview.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.3 Preview.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[!] IntelliJ IDEA Ultimate Edition (version 2018.3 Beta)
    • IntelliJ at /Users/andrewgrosner/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[✓] Connected device (2 available)
    • Usage: ideviceinfo [OPTIONS]
      Show information about a connected device.

        -d, --debug             enable communication debugging
        -s, --simple            use a simple connection to avoid auto-pairing with the device
        -u, --udid UDID target specific device by its 40-digit device UDID
        -q, --domain NAME       set domain of query to NAME. Default: None
        -k, --key NAME  only query key specified by NAME. Default: All keys.
        -x, --xml               output information as xml plist instead of key/value pairs
        -h, --help              prints usage information

        Known domains are:

        com.apple.disk_usage
        com.apple.disk_usage.factory
        com.apple.mobile.battery
        com.apple.iqagent
        com.apple.purplebuddy
        com.apple.PurpleBuddy
        com.apple.mobile.chaperone
        com.apple.mobile.third_party_termination
        com.apple.mobile.lockdownd
        com.apple.mobile.lockdown_cache
        com.apple.xcode.developerdomain
        com.apple.international
        com.apple.mobile.data_sync
        com.apple.mobile.tethered_sync
        com.apple.mobile.mobile_application_usage
        com.apple.mobile.backup
        com.apple.mobile.nikita
        com.apple.mobile.restriction
        com.apple.mobile.user_preferences
        com.apple.mobile.sync_data_class
        com.apple.mobile.software_behavior
        com.apple.mobile.iTunes.SQLMusicLibraryPostProcessCommands
        com.apple.mobile.iTunes.accessories
        com.apple.mobile.internal
        com.apple.mobile.wireless_lockdown
        com.apple.fairplay
        com.apple.iTunes
        com.apple.mobile.iTunes.store
        com.apple.mobile.iTunes

      Homepage: <http://libimobiledevice.org> • 00008020-000E11A10168002E            • ios • iOS Usage: ideviceinfo [OPTIONS]
      Show information about a connected device.

        -d, --debug             enable communication debugging
        -s, --simple            use a simple connection to avoid auto-pairing with the device
        -u, --udid UDID target specific device by its 40-digit device UDID
        -q, --domain NAME       set domain of query to NAME. Default: None
        -k, --key NAME  only query key specified by NAME. Default: All keys.
        -x, --xml               output information as xml plist instead of key/value pairs
        -h, --help              prints usage information

        Known domains are:

        com.apple.disk_usage
        com.apple.disk_usage.factory
        com.apple.mobile.battery
        com.apple.iqagent
        com.apple.purplebuddy
        com.apple.PurpleBuddy
        com.apple.mobile.chaperone
        com.apple.mobile.third_party_termination
        com.apple.mobile.lockdownd
        com.apple.mobile.lockdown_cache
        com.apple.xcode.developerdomain
        com.apple.international
        com.apple.mobile.data_sync
        com.apple.mobile.tethered_sync
        com.apple.mobile.mobile_application_usage
        com.apple.mobile.backup
        com.apple.mobile.nikita
        com.apple.mobile.restriction
        com.apple.mobile.user_preferences
        com.apple.mobile.sync_data_class
        com.apple.mobile.software_behavior
        com.apple.mobile.iTunes.SQLMusicLibraryPostProcessCommands
        com.apple.mobile.iTunes.accessories
        com.apple.mobile.internal
        com.apple.mobile.wireless_lockdown
        com.apple.fairplay
        com.apple.iTunes
        com.apple.mobile.iTunes.store
        com.apple.mobile.iTunes

      Homepage: <http://libimobiledevice.org>
    • iPhone XS Max                                                                                • 0AE4C4FA-17EE-4067-AFB7-5DF20D1D2164 • ios • iOS 12.1 (simulator)

! Doctor found issues in 1 category.

It appears instead of showing a device properly, the usage docs about ideviceinfo show up in the UI of intellij (and probably Android Studio). To note I have a device Im connecting to a computer for the first time post update (12.1 iOS Iphone XS Max).

Are you still seeing this?

it appears fixed as I am running v1.1.4.

Related to #24030

I'm also seeing this issue in Android Studio 3.4.1.


Fill out README sections

Empty sections in README:

[x] Installation
[x] Usage

Make changes to documentation_dev branch

This got merged in #24, could still probably use some work but I'm closing this for now.


Combiner option setReduceOnFullCompactionOnly not honored

Combiner option setCombineAllColumns(..., true) prevents the other option setReduceOnFullCompactionOnly(..., true) from being honored. The issue is likely related to the init() method bailing out once the first option is determined to be true instead of continuing to parse the initialization options.
https://github.com/apache/accumulo/blob/9f29f37d87809ac6a86f185348c517a104b7dec6/core/src/main/java/org/apache/accumulo/core/iterators/Combiner.java#L281

Thanks @sixfootbeard for creating the issue.  What version of Accumulo are you seeing this issue?  It looks like this issue exists in 1.9 as well.

I'm using version 1.9.3.


Add an option to turn off syntax highlighting

You can currently omit the syntax highlighting style block using omit style-syntax-highlighting. However, Bikeshed still inserts a bunch of spans that are meant to be styled, which add unnecessary weight to the document. It would be nice if there was a way to turn off syntax highlighting completely, both the spans and the style block.
(Spun off of #1239.)

All right, this (and your other "please remove usability features" issues) have been grouped together under the Slim Build Artifact: yes metadata. Turn it on and all of these go away. Feel free to bug me for more features to remove when this is turned on.

Web IDL still seems to be syntax highlighted. Otherwise, looking pretty great!!

Ah, indeed, that's a different code path that relies on the IDL parsing. Will fix.

And done. WebIDL no longer looks highlighted, and the spans that are added solely for highlighting purposes are removed.

Nice. Down to 877 KiB, and I think that's pretty much everything I could imagine stripping. \o/

There's definitely some classes I could go thru and remove if you wanted. ^_^


Anchor tags display the whole href url alongwith the inner text, anyway to hide the url?

Html file contains :
Google!
Its displayed as:
Google! (www.google.com)
I want just:
Google!

Same here. Did you solve the problem?

@raviverma89 @SehoAhn  i have found a work around if you still interested , just add this to your main css
  a[href]:after {
    content: none !important;
  }

it worked for me :)


Regex usage causing error with python > 3.6

This function:
https://github.com/joepie91/python-whois/blob/7b0ddf755b3d706860d5d8cb80c598fd854a48ca/pythonwhois/parse.py#L203
causes an error re.error: bad escape \s at position 0 when using python > 3.6. You can try it here: https://wandbox.org/permlink/D6ZEUWfMIs7wYK77
Please note, that in python 3.7: "Unknown escapes consisting of '\' and an ASCII letter in replacement templates for re.sub() were deprecated in Python 3.5, and will now cause an error." (https://docs.python.org/3/whatsnew/3.7.html).
It seems that that's the only problem with python > 3.6.

i have this issue too!

Yes this issue still remains.

Ended up doing it this way:
TARGET=/usr/local/lib/python3.7/dist-packages/pythonwhois/
cd $TARGET
sed -i 's/\(\s*regex = re.sub(r"\\\\s.*\)r"\\s\(.*\)>\\S\(.*\)/\1r"\\\\s\2>\\\\S\3/' parse.py

still same on python3.8

Ended up doing it this way:
TARGET=/usr/local/lib/python3.7/dist-packages/pythonwhois/
cd $TARGET
sed -i 's/\(\s*regex = re.sub(r"\\\\s.*\)r"\\s\(.*\)>\\S\(.*\)/\1r"\\\\s\2>\\\\S\3/' parse.py

thanks alot <3 works with 3.8

FYI this was also fixed in @kilgoretrout1985 fork of pythonwhois: https://github.com/kilgoretrout1985/pythonwhois-alt/commit/81abd1aab2a1e450d97d006327b47bf801df334a
pip3 install pythonwhois-alt


📒 Handle notebook cell ids and outputs in jats

Give notebook cell blocks an id and type (code or content)
Give notebook cell code/output ids
Make code cells sec elements in JATS
Add cell outputs to JATS

Tested out locally, this is a massive improvement!


setVolume() not working correctly on Firefox

Wavesurfer.js version(s)
1.4.0
Browser version(s)
Firefox Quantum 58.0.2 (64-Bit)
Code needed to reproduce the issue
As seen on https://dateimaschine.de/audio/20389730a3c82adc
Issue
setVolume() (called by the range slider) does only have an impact after having clicked into the waveform.
Description
As you might notice when using Firefox, after you hit the play button (or press space) on the website mentioned above, the volume slider  does not do anything, except for muting (at value 0 setMute(true) is called). If you click anywhere on the waveform it's working again. This behaviour seems to be Firefox only. Edge and Chrome work fine, Internet Explorer as well (it's got more severe problems, e.g. not showing the waveform at all (dont't care about IE), but - hey -, volume works correctly there!)
Debugging done
#volume-slider is the range input
$('#volume-slider').on('input change', function() {
	wavesurfer.setVolume(parseInt($('#volume-slider').val()) / 100);
	console.log(wavesurfer.getVolume());
});

In spite of not audibly reacting to setVolume() the desired getVolume() number gets written to the console! After the song finishes, the same problem occurs again.
However, the initial setVolume() works:
wavesurfer.on('ready', function() {
	wavesurfer.setVolume($('#volume-slider').val() / 100);
});

It's not the parseInt(), juggled around with that for testing.

@MichaelRoehrig you are using a really old version. Can you reproduce this with the latest version?

Oh, didn't see that. Always worked with the one mentioned on wavesurfer-js.org :-)
Switched to the 2.0.0-beta01 version on cloudflare and I isolated everything:
https://jsfiddle.net/83vnwzd3/10/
The problem is still there.

@MichaelRoehrig why do you think beta01 is the latest version?

I didn't have npm available earlier. This 2.0.0 version did not seem too old :-).
Now I tried the newest version (2.0.4): works! Easier than I thought... thanks for your help!


make virtual package selection a strategy

so that users can provide their own selection strategy

implemented in https://github.com/demarey/cargo/commit/e82362fe31b38efc55fe3bfb3cf27b89b9686474


Revisit fonts in throughout the application

All the btn text should be Space Grotesk, not Lato (like in Settings) or Kanit.

Should be: Kanit for the logo, Lato for text, Space grotesk for the headlines and buttons and roboto mono for numericals.

What exactly needs to be changed here?

@lsaether All fonts in app checked are according to design (my first comment here) and changed if aren't.

Awesome!


Refs #31700 -- Added formatted description to highlight different ope…

Added formatted description to highlight different operations in makemigrations output.
I wasn't sure whether to add color style to the output or not as it wasn't determined in the ticket discussions too. I have added it now. If you feel it's too noisy, I can remove it and we can have just text formatting. Plus, I think letting the describe() method return two parameters is a clean way to implement such a feature without too overengineering.
Here are sample outputs:

@felixxm @adamchainz
Unfortunately, I had forgotten to update this PR to pass all the tests. This PR backs to 6 weeks ago, and its issue is older. I'll appreciate it if you take a look at it.

Please don't tag people for review, it's not necessary. The fellows, or volunteers, review all PRs eventually, if the ticket is set to "needs review".

I replied in the forum: https://forum.djangoproject.com/t/makemigrations-highlighter-interesting-or-noise/24039/6


Crosshair sync in different timeframe attaches to the nearest candle instead of exact location

Description
Thanks for implementing the crosshair sync in  multiple windows. I am using this code to create two different windows stacked on top of each other ->
main_chart = Chart(width=1820, height=980, inner_width=1, inner_height=0.5)
chart2 = main_chart.create_subchart(width=1, height=0.5, sync=True, sync_crosshairs_only=True)

When I hover my mouse crosshair in one of the windows, the crosshair in other windows arrive at the correct candle but it always is attached to that candle. If I hover my mouse in the empty region above the candles, the crosshair is still attached to the candle. This makes measuring support and resistance lines tough. If we could make the crosshairs sync in the empty region above and below the candles as well, it would make the MTF analysis much easy. It would be a neat little addition.
Code example
No response
Method of implementation
No response

Hey @gigasurgeon,
I'm not sure if this would be wise, as synced charts may have wildly different price values.
Louis


Set Up Kanban Board for Recipe Blog App

Hello Reviewer
@danielmatama and @Newtayo would be working on the Recipe Blog App
@danielmatama would be working on the Food List, Public Recipe List, General shopping list view also implementing test for all these
while @Newtayo would work on setting up the login page, registration page, recipe list, recipe details and the project navigation menu.
Here is a link to the github project

Hi @Newtayo @danielmatama 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

All team members info provided 👍
Link to board works 👍

Required Changes ♻

Kindly add the missing column (In Review)

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @davidsoky007 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Davidosky007 This has been updated

Hello Reviewer
In review column has been added to our project kanban board

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

All cards assigned ✔
Changes fixed ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


gold_states.json

I cannot find this file, though it seems to be used at multiple steps.
For example, data/multiwoz22/preprocess.py fails to run, as cfg.gold_states is not defined. I couldn't find this file in the config either.
Thanks!
Dilek

Ah, I now see that load_multiwoz22() generates that file, so I used that to generate gold_states.json. But, pls note that this is not included in the following data preparation steps in README.md:
cd data/multiwoz22
bash data_preparation.sh
Thans,
Dilek

Hi Dilek,
Could you tell me how can I get gold_states.json file?
I can see load_multiwoz22() function in E2E_TOD.mwzeval.utils. Do I have to run utils.py before running data/multiwoz22/preprocess.py?

I created a dummy python file with the following in it:
from mwzeval.utils import load_multiwoz22
unused1, unused2 = load_multiwoz22()
and ran it to download and create all files.
Previously I had just downloaded multiwoz2.2 from the website myself, and it doesn't include gold_states.json.

Thank you so much!

Hi, @dilekh
Did you try to train TOATOD model by any chance?
I ran it with smaller batchsize and I got worse performance.
How about you?

@min942773 If you used 1 batch while run reinforce.py, the performance degradation can be occured. Can you give us your parameter setting and your reproduced score? We will check the problem and report the reason of the problem to you.


Add Dense GCN Conv

This PR adds dense_gcn_conv to dense conv layers of PyG. This will be useful for evaluating dense architecture like DiffPool over a vanilla GCN framework.

Super cool. Thank you. Will try to merge it tomorrow :)


[Feature] support for forming teams

Do you support forming teams with more than one user?
Thanks!

We plan to add "Organizations" actually! Hopefully coming in the next ~4 months -- do you have any particular deadlines or anything? Do you have a design in mind for this feature already, if you don't mind sharing it? We could take maybe the best pieces of all approaches :)

Sorry, we are trying to host the challenges next week. But, in the next cycle, we would love to have this feature.  I can share some of our thoughts in couple of weeks.

The organization feature is now implemented.


[Sprint: 51][1.2 GA] XD-3132 Adding JAVA_HOME to be able to run in more deployment environ…

…mnts

tested with hdp cluster, lgtm. merging.

merged


Longevity test release-1.6 CN OOM

"!!! longevity Result!!!"
Today's date:2024-01-22
Result               FAIL
Pipeline Message     Test v1.6.1-rc
TestBed              kubebench/3264g-medium-3cn-all-affinity
RW Version           v1.6.1-rc
Test Start time      2024-01-21 17:00:08
Test End time        2024-01-22 05:02:24
Namespace            usrlngvty-20240121-165055
Queries              nexmark_q0,nexmark_q1,nexmark_q2,nexmark_q3,nexmark_q4,nexmark_q5,nexmark_q7,nexmark_q8,nexmark_q9,nexmark_q10,nexmark_q12,nexmark_q14,nexmark_q15,nexmark_q16,nexmark_q17,nexmark_q18,nexmark_q19,nexmark_q20,nexmark_q21,nexmark_q22,nexmark_q101,nexmark_q102,nexmark_q103,nexmark_q104,nexmark_q105
Grafana Metric       https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=Prometheus:%20test-useast1-eks-a&var-namespace=usrlngvty-20240121-165055&from=1705856408000&to=1705899744000
Grafana Logs         https://grafana.test.risingwave-cloud.xyz/d/liz0yRCZz1/log-search-dashboard?orgId=1&var-data_source=Logging:%20test-useast1-eks-a&var-namespace=usrlngvty-20240121-165055&from=1705856408000&to=1705899744000
Memory Dumps to S3   https://s3.console.aws.amazon.com/s3/buckets/test-useast1-mgmt-bucket-archiver?region=us-east-1&prefix=k8s/usrlngvty-20240121-165055/&showversions=false
Buildkite Job        https://buildkite.com/risingwave-test/longevity-test/builds/954
Crash Container logs https://rw-qa-artifacts-public.s3.us-east-1.amazonaws.com/longevity/954_logs.txt
Report               https://rw-qa-artifacts-public.s3.us-east-1.amazonaws.com/longevity/954_report.txt

================================================================================
Restarted/Crashed Containers Details
================================================================================
CONTAINER crashed/Restarted: benchmark-risingwave-compute-c-0 restart_count:1  phase:Running status:True
CONTAINER crashed/Restarted: benchmark-risingwave-compute-c-2 restart_count:1  phase:Running status:True

Collapsed files: https://buildkite.com/risingwave-test/generate-collapsed-heap-files/builds/14#018d2fc4-1df1-435d-85b5-58d88d1a990d

rerun include nexmark_q6_group_top1
"!!! longevity Result!!!"
Today's date:2024-01-22
Result               FAIL
Pipeline Message     longevity test v1.6.1-rc
TestBed              kubebench/3264g-medium-3cn-all-affinity
RW Version           v1.6.1-rc
Test Start time      2024-01-22 05:39:43
Test End time        2024-01-22 15:01:42
Namespace            usrlngvty-20240122-053033
Queries              nexmark_q0,nexmark_q1,nexmark_q2,nexmark_q3,nexmark_q4,nexmark_q5,nexmark_q6_group_top1,nexmark_q7,nexmark_q8,nexmark_q9,nexmark_q10,nexmark_q12,nexmark_q14,nexmark_q15,nexmark_q16,nexmark_q17,nexmark_q18,nexmark_q19,nexmark_q20,nexmark_q21,nexmark_q22,nexmark_q101,nexmark_q102,nexmark_q103,nexmark_q104,nexmark_q105
Grafana Metric       https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=Prometheus:%20test-useast1-eks-a&var-namespace=usrlngvty-20240122-053033&from=1705901983000&to=1705935702000
Grafana Logs         https://grafana.test.risingwave-cloud.xyz/d/liz0yRCZz1/log-search-dashboard?orgId=1&var-data_source=Logging:%20test-useast1-eks-a&var-namespace=usrlngvty-20240122-053033&from=1705901983000&to=1705935702000
Memory Dumps to S3   https://s3.console.aws.amazon.com/s3/buckets/test-useast1-mgmt-bucket-archiver?region=us-east-1&prefix=k8s/usrlngvty-20240122-053033/&showversions=false
Buildkite Job        https://buildkite.com/risingwave-test/longevity-test/builds/956
Crash Container logs https://rw-qa-artifacts-public.s3.us-east-1.amazonaws.com/longevity/956_logs.txt
Report               https://rw-qa-artifacts-public.s3.us-east-1.amazonaws.com/longevity/956_report.txt

================================================================================
Restarted/Crashed Containers Details
================================================================================
CONTAINER crashed/Restarted: benchmark-risingwave-compute-c-0 restart_count:25  phase:Running status:True

Collapsed files: https://buildkite.com/risingwave-test/generate-collapsed-heap-files/builds/17

Collapsed files: https://buildkite.com/risingwave-test/generate-collapsed-heap-files/builds/17

MZ executor uses 1.4GB, does it make sense?
And the total memory only uses less than 10GB, but somehow it generates a dump, does it make sense?

is it because if we set request to 13GB also, the pod cannot be scheduled? cc: @huangjw806

And the total memory only uses less than 10GB, but somehow it generates a dump, does it make sense?

Auto memory dump is triggered by OS memory usage (rss), while the heap dump is made by jemalloc, which is usually less than the rss for up to 30%.

is it normal that only the materialize executor takes a large chunk of memory? cannot find other executors using comparable amount of memory
I suppose the materialize executor does not need any cache in it, only temporary memory allocation which disappears after the chunk gets flushed into the storage?

is it normal that only the materialize executor takes a large chunk of memory? cannot find other executors using comparable amount of memory

Ohh, indeed. The Materialize executor should not validate data here. Need to dive in.

is it because if we set request to 13GB also, the pod cannot be scheduled?
I think it’s work, because it seems that the total resources have not reached the limit.

Whether a pod runs into OOM depends on the limit, right
yes.

The total memory of the machine also seems to be sufficient.

node exporter: https://grafana.test.risingwave-cloud.xyz/d/LDL_mx9nz123/kubernetes-node-exporter?orgId=1&var-DS_PROMETHEUS=P2453400D1763B4D9&var-node=ip-10-0-43-102.ec2.internal&var-internal_ip=<IP_ADDRESS>&var-diskdevices=[a-z]%2B|nvme[0-9]%2Bn[0-9]%2B|mmcblk[0-9]%2B&from=1705893102767&to=1705983763575

The process was killed by the OOM killer. You can find the logs here.
oom-kill:constraint=CONSTRAINT_MEMCG,nodemask=(null),cpuset=cri-containerd-89ddc6d34df8009759c8a68262451ea93278c07d6330a80b7c8504bc57be1196.scope,mems_allowed=0,oom_memcg=/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod455a7760_dc45_4b38_b624_977c170dd1d9.slice,task_memcg=/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod455a7760_dc45_4b38_b624_977c170dd1d9.slice/cri-containerd-89ddc6d34df8009759c8a68262451ea93278c07d6330a80b7c8504bc57be1196.scope,task=risingwave,pid=733811,uid=0

Memory cgroup out of memory: Killed process 733811 (risingwave) total-vm:44901588kB, anon-rss:13531468kB, file-rss:396436kB, shmem-rss:0kB, UID:0 pgtables:77204kB oom_score_adj:838

is it normal that only the materialize executor takes a large chunk of memory? cannot find other executors using comparable amount of memory

Ohh, indeed. The Materialize executor should not validate data here. Need to dive in.

No. We made a mistake. The ~1.5GB memory was not taken by Materialize executor itself, but by the children executors. Rust's async is based on polling, so the children executors are under Materialize in the stack tree.
In the below graph, the highlighted boxes contain keyword "stream::executor::" i.e. they are all stream executors.

I think this issue is same as https://github.com/risingwavelabs/risingwave/issues/14736. See the analysis at https://github.com/risingwavelabs/risingwave/issues/14736#issuecomment-1905247180.

It could because we disable the memtable spill because of the inconsistent issue
on release-1.6 https://github.com/risingwavelabs/risingwave/commit/06058f046de38e91078c1d54f880eccfc934f3de
on main https://github.com/risingwavelabs/risingwave/commit/89a8297ff9082737ccf01f853e2ea3458413de28

Rerun https://buildkite.com/risingwave-test/longevity-test/builds/980
with imm_merge_threshold=4 and mem_table_spill_threshold=4MB, and disabled check_compaction_result

May be due to an extra copy of block during decode after #13558. The fix #14786 just gets merged. Let's wait for today's longevity to see whether the situation is improved.

nightly-20240125 cn still oom.
================================================================================
longevity-test Result
================================================================================
Result               FAIL
Pipeline Message     @Nightly run all nexmark (8 sets of nexmark queries) with 10k throughput
Namespace            reglngvty-20240125-150209
TestBed              medium-arm-3cn-all-affinity
RW Version           nightly-20240125
Test Start time      2024-01-25 15:11:13
Test End time        2024-01-26 03:13:24
Test Queries         nexmark_q0,nexmark_q1,nexmark_q2,nexmark_q3,nexmark_q4,nexmark_q5,nexmark_q6_group_top1,nexmark_q7,nexmark_q8,nexmark_q9,nexmark_q10,nexmark_q12,nexmark_q14,nexmark_q15,nexmark_q16,nexmark_q17,nexmark_q18,nexmark_q19,nexmark_q20,nexmark_q21,nexmark_q22,nexmark_q101,nexmark_q102,nexmark_q103,nexmark_q104,nexmark_q105
Grafana Metric       https://grafana.test.risingwave-cloud.xyz/d/EpkBw5W4k/risingwave-dev-dashboard?orgId=1&var-datasource=Prometheus:%20test-useast1-eks-a&var-namespace=reglngvty-20240125-150209&from=1706195473000&to=1706238804000
Grafana Logs         https://grafana.test.risingwave-cloud.xyz/d/liz0yRCZz1/log-search-dashboard?orgId=1&var-data_source=Logging:%20test-useast1-eks-a&var-namespace=reglngvty-20240125-150209&from=1706195473000&to=1706238804000
Memory Dumps         https://s3.console.aws.amazon.com/s3/buckets/test-useast1-mgmt-bucket-archiver?region=us-east-1&bucketType=general&prefix=k8s/reglngvty-20240125-150209/&showversions=false
Buildkite Job        https://buildkite.com/risingwave-test/longevity-test/builds/985

================================================================================
Restarted/Crashed Pods Details
 ================================================================================
Pod crashed/Restarted: benchmark-risingwave-compute-c-2 restart_count:2  phase:Running status:True


Optional custom error for constraints?

Sometimes it's can be useful to have a special error code for constraints because this can provide a clear error message. Possible syntax:
#[account(constraint = <expression> ? MyError)]

Maybe not limited by constraint only?

Agreed. I think this would be useful for any constraint, particularly those where there can be more than one, e.g., has_one, so that one can differentiate between the scenarios.
I like the ?. Another possibility would be to use a ;.
#[account(constraint = <expression>; MyError)]

Though I don't have a preference. Tag @Henry-E who I previously discussed this with as well.

In the case of ; how few constraints will look like?
#[account(
  constraint = <expression>; MyError,
  constraint = <expression>
)]

vs
#[account(
  constraint = <expression> ? MyError,
  constraint = <expression>
)]

but in general, I do not care about symbols if a custom error will be possible.

Another one that I like in addition to ? is
constraint = <expression> ! MyError

Not sure but there might be better error logging in general coming soon
which solves this problem without needing extra syntax
On Thu, Oct 7, 2021, 4:49 AM acamill @.***> wrote:

Was hoping for this. Voting for ! as it implies unwrapping/error, ?
implies conditional (to me, coming from Swift).
Or possible to have something rustier like :
Constraint = (condition).map_err(Error)? Not very rust savvy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/project-serum/anchor/issues/509#issuecomment-937420443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAHMGGMZZ2XVOGUNJQKAJDUFUKE5ANCNFSM5AEHSIKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Yes would be amazing, I am trying to debug some code, and it's incredibly exhausting trying to understand where the error originated from (i.e. from one of the macros)


Fixed label?

I see in code there are som references to .fixed regarding Label in input compontent. I would like to set the label fixed on top of Input when wanted. Is there a way today?
For example:
<Input fixedLabel=boolean
Anyways, awesome job so far, I think we will contribute with some components in future. We really like the setup.
/Eduardo

@eduardoinnorway: Using <Input floating />, will indicate if the label is floating in the input field or not. Floating is set to true by default. So what do you want, could you elaborate?

@eduardoinnorway: Override css like it's described in Customizing components part on http://react-toolbox.com/#/install
Use something like this:
@import "react-toolbox/lib/input/theme.css";

:root {
    --input-label-font-size_custom: var(--font-size);
}

.inputElement {
    &:focus:not([disabled]):not([readonly]),
    &.filled,
    &[type='date'],
    &[type='time'] {
        & ~ .label:not(.fixed) {
            font-size: var(--input-label-font-size_custom);
            top: var(--input-focus-label-top);
        }
    }

    & {
        & ~ .label:not(.fixed) {
            font-size: var(--input-label-font-size_custom);
            top: var(--input-focus-label-top);
        }
    }
}

.counter {
    font-size: var(--input-label-font-size_custom);
}

@drager I think they may mean like the "Fixed Floating Label Text" example from here: http://www.material-ui.com/#/components/text-field where the label is permanently above the input, allowing the placeholder attribute to be used without the label overlapping the placeholder text.
IMO it would be worth adding .inputElement[placeholder] to the list of rules that triggers the label to be raised, as currently specifying a placeholder causes unsightly overlapping text. Unfortunately I don't have time at the moment to make a PR.


New release notes for MTV version 2.4.0

@ahadas @mavital @anarnold
MTV 2.4.0 release notes:
Added 2 new features, 3 known issues and 3 resolved issues.
I still need information for "Technical changes, which I left empty with placeholders.
Please review ad reply with mussing info.
Thanks

btw, I've commented on changes that are part of this PR in #365 by mistake..

@ahadas @anarnold
Implemented all of Arik's comments in MTV 2.4.0 release notes.

Closed - obsolete


HAWQ-926. Remove pycrypto from HAWQ source code

User need to install it by pip before install HAWQ

+1  +🍉

+1.

This PR should be closed, right?
It is already in:
https://github.com/apache/incubator-hawq/commit/ac031357b3b29978772f1e7478d97d21da653df4


Update dev-pt with main branch

Describe your changes
Update dev-pt with main branch
Related issue number or link (ex: resolves #issue-number)
N/A
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

cc @jessicalins @brunoguidone @MrErlison

Thanks !


Correcting example of authentication

Description
The return type it is IAzure not Azure.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[x] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

Can one of the admins verify this patch?

Hi @Nepomuceno, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, AZPRBOT;

@azuresdkci test this please


Increase integration limit

Increased the integration limit for the Temporal server interface. This is to allow for the four Temporal cluster services (frontend, history, matching, worker) to be deployed as separate scalable applications and all be integrated with the same Temporal admin charm.

The change itself LGTM. I'm still not too sure about all the server instances needing an Admin charm though, it feels like there's got to be a better alternative.
Why did you remove the ingress.py charm stuff?

I might have introduced that previously to use ingress but we don't use any ingress for Temporal admin.


Add code of conduct. (Fixes #119)

This adds a code of conduct to the repository.
This is for 1.6.0, merge after 1.5.0 release.

This is ready for review.
Wait to merge until #127 is merged.

Rebased to master, ready for review.


Wiki: Explanation of RAM (Read Write memory) Timestamp Rangecheck

Spice describes this in Figure 2. The goal is to avoid reordering attacks. We need to guarantee that the prover's insertions happen in the correct order.
Current implementation: Proveread timestamps <= global_timestamp for all insertions in 2^n.

Rangecheck 0 <= every read timestamp <= 2^n
Rangecheck0 <= global_timestamp - read_timestamp <= 2^n

https://jolt.a16zcrypto.com/how/read_write_memory.html#timestamp-range-check


Adding PWA support

based on ethereum-boilerplate/ethereum-bolierplate:main branch
This feature is added based on this GitHub issue: https://github.com/ethereum-boilerplate/ethereum-boilerplate/issues/79
Changes

Adding service workers
Adding manifest.json + logo assets for PWA

Beneftis

Higher performance loading due to caching by service workers
Native-app like experience on Mobile + Desktop with Native app capabilities (geofencing, camera, push notifications, etc)
Enable developer to build platform-agnostic dApp, plus can be listed in Google Play Store, Microsoft Store, etc.

Nice work!


Do not use ReadObjectThreaded on scene objects!

In  unity 2019 -
I upgraded ActionRecognizer
public class ActionRecognizer : MonoBehaviour
{
	public RawImage  costMatrixTexture;

but when I build I get error Do not use ReadObjectThreaded on scene objects!
any ideas?

This was a project I did in 2012 and haven't been current with Unity since, so I'm afraid I don't know, sorry.


Refactor version

Version is used in a bunch of places, but as a string. Refactor as a simple class instead and make it possible to get it as string for where printing is needed. It can then be moved from core/utils to core/version.
Tests need to be fixed after too!

Done in f852f8726603f059674959c46e8f010d18fdc200


best way for non-periodicity data?

Description
the base dataset class: PandasDataset(dataframes=code2df.values(), target="lastPrice", freq="3s", unchecked=True)
must input parameter "freq" or will be auto infered, and AddTimeFeatures based on it.
I'm dealing with this:
timestamp: [
2010-10-11 09:15:00,
2010-10-11 09:15:03,
2010-10-11 09:15:06,
...,
2010-10-11 09:25:00,
2010-10-11 09:30:00,
2010-10-11 09:30:03,
...
]
Most of the data is at 3-second interval, But in some places, there are 5-minute intervals, such as 9:25 to 9:30.
I would like to know if there is an official way to handle this situation? Or maybe I need to define a set of methods myself

@NeoWang9999 was the data sampled at 3-second frequency, and some time windows happen to be missing? If that's the case, you probably want to just resample your DataFrame to have 3s frequency, and fill in missing observations with nan

For example using https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.asfreq.html

@NeoWang9999 was the data sampled at 3-second frequency, and some time windows happen to be missing? If that's the case, you probably want to just resample your DataFrame to have 3s frequency, and fill in missing observations with nan

thanks for reply!
it's not quite missing, but there actually is no value at some points.
I think this issue is very similar to mine:
https://github.com/awslabs/gluonts/issues/227

@NeoWang9999 were you able to resolve the issue? Did you use any custom method? Looking forward to hearing

@NeoWang9999 were you able to resolve the issue? Did you use any custom method? Looking forward to hearing

yes, I did little code change, rewrite some functions. looks like no better way to me.


Fix resolving logic for IntelliJ EAP snapshot build

Reasoning
It showed up that after merging https://github.com/VirtusLab/ide-probe/pull/275 there is a new bug that needs fixing. If user uses probe.resolvers.intellij.repositories patterns together with a snapshot build version of IntelliJ - then the uri of the artifact to download is resolved badly - for example:
https://www.jetbrains.com/intellij-repository/snapshots/com/jetbrains/intellij/idea/ideaIC/223.6160.11-EAP-SNAPSHOT-EAP-SNAPSHOT/ideaIC-223.6160.11-EAP-SNAPSHOT-EAP-SNAPSHOT.zip
the EAP-SNAPSHOT part is inserted two times.
Acceptance criteria

snapshot builds are resolved properly
improve tests from OfficialResolversTest (or add new ones?) - currently these tests do not check the resolved uri for equality, but just check if they end with "EAP-SNAPSHOT", like this:
assertTrue(artifact.uri.toString.endsWith("-EAP-SNAPSHOT.zip"))
improve SingleRunFixtureTest by adding some test/tests with IntelliJ snapshot build (as for now all tests use the official release)

OCH
Just realized that this is not true, our logic is fine... used 223.4884.69-EAP-SNAPSHOT as the version in another project :/ Closing this one


Fallback for Postgresql DB in AsyncSession

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import sessionmaker

primary_engine = create_async_engine("PRIMARY_DATABASE_URL", echo=False, future=True)
replica_engine = create_async_engine("REPLICA_DATABASE_URL", echo=False, future=True)

async def get_primary_session() -> AsyncSession:
    async_session = sessionmaker(primary_engine, class_=AsyncSession, expire_on_commit=False)
    async with async_session() as session:
        yield session

async def get_replica_session() -> AsyncSession:
    async_session = sessionmaker(replica_engine, class_=AsyncSession, expire_on_commit=False)
    async with async_session() as session:
        yield session

Description
I am currently having two Postgresql Clusters attached to my Python FastAPI server (see the source code).
Now assume, that the replica crashes. What would be the best strategy to redirect the traffic back to the primary?
I currently have tried this:
async def get_replica_session() -> AsyncSession:
    try:
        async_session = sessionmaker(replica_engine, class_=AsyncSession, expire_on_commit=False)
        async with async_session() as session:
            yield session
    except:
        async_session = sessionmaker(primary_engine, class_=AsyncSession, expire_on_commit=False)
        async with async_session() as session:
            yield session

However, it used to throw Runtime errors? Hence, it would be great if you could give me some thoughts about it.
Operating System
macOS
Operating System Details
No response
SQLModel Version
0.0.8
Python Version
3.10
Additional Context
No response

This is not about SQLModel actually but SQLAlchemy, your example also literally only imports sqlalchemy libs. Maybe you'll have better luck asking there or in StackOverflow with sqlalchemy tag.
Am also interested in the answer though :)

First Check

[x]  I added a very descriptive title to this issue.
[x]  I used the GitHub search to find a similar issue and didn't find it.
[x]  I searched the SQLModel documentation, with the integrated search.
[x]  I already searched in Google "How to X in SQLModel" and didn't find any information.
[x]  I already read and followed all the tutorial in the docs and didn't find an answer.
[x]  I already checked if it is not related to SQLModel but to Pydantic.
[x]  I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[x]  I commit to help with one of those options 👆

Example Code
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import sessionmaker

primary_engine = create_async_engine("PRIMARY_DATABASE_URL", echo=False, future=True)
replica_engine = create_async_engine("REPLICA_DATABASE_URL", echo=False, future=True)

async def get_primary_session() -> AsyncSession:
    async_session = sessionmaker(primary_engine, class_=AsyncSession, expire_on_commit=False)
    async with async_session() as session:
        yield session

async def get_replica_session() -> AsyncSession:
    async_session = sessionmaker(replica_engine, class_=AsyncSession, expire_on_commit=False)
    async with async_session() as session:
        yield session

Description
I am currently having two Postgresql Clusters attached to my Python FastAPI server (see the source code).
Now assume, that the replica crashes. What would be the best strategy to redirect the traffic back to the primary?
I currently have tried this:
async def get_replica_session() -> AsyncSession:
    try:
        async_session = sessionmaker(replica_engine, class_=AsyncSession, expire_on_commit=False)
        async with async_session() as session:
            yield session
    except:
        async_session = sessionmaker(primary_engine, class_=AsyncSession, expire_on_commit=False)
        async with async_session() as session:
            yield session

However, it used to throw Runtime errors? Hence, it would be great if you could give me some thoughts about it.
Operating System
macOS
Operating System Details
No response
SQLModel Version
0.0.8
Python Version
3.10
Additional Context
No response

I have tried to use asyncSession which import from sqlalchemy, and then the problem solved. I hope it is useful


add color theme and design for pets page (CSS)

https://colorhunt.co/palette/f3f3e0133e87608bc1cbdceb
these are the colors this link has the color names or hexvalue number just hover over the card


Godot4: init_library: does not have a library for the current platform.

Godot version
v4.0.alpha1.official [31a7ddbf8]
System information
Windows 10
Issue description
The attached demo project works in current stable, but not in 4.0 alpha.
I get this first error:
W 0:00:00:0047   _debug_messenger_callback: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message
	ReadDataFilesInRegistry: Registry lookup failed to get layer manifest files.
	Objects - 1
		Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 128357280
  <C++ Source>   drivers/vulkan/vulkan_context.cpp:154 @ _debug_messenger_callback()

... but I seem to get this with other projects as well, so it's probably not related.
Then ...
@onready var DLL := preload("res://DLLTest.gdns") causes ...
  E 0:00:00:0632   init_library:  does not have a library for the current platform.
  <C++ Error>    Condition "lib_path.length() == 0" is true.
  <C++ Source>   modules/gdnative/nativescript/nativescript.cpp:1446 @ init_library()

The dll is based on a free pascal example which works in current stable.
"Latest" and "Stable" show the same text in the docs, so I don't know what I'm doing wrong.
I had the issue with stable first as well, but that was apparently just me messing something up with the gd* files.
Steps to reproduce
See attached zip-file.
 I've apparently ignored that they need to be changed.
Now I just need to figure out what to actually change, and how.

Note that GDNative doesn't exist in 4.0 anymore, it has been replaced by GDExtension: https://godotengine.org/article/introducing-gd-extensions
The setup is different, and not extensively documented yet as it's still WIP.

Note that GDNative doesn't exist in 4.0 anymore, it has been replaced by GDExtension: https://godotengine.org/article/introducing-gd-extensions
The setup is different, and not extensively documented yet as it's still WIP.

Are you sure? It's both still in the engine and the docs as well!
I guess, I can scratch writing dlls directly. There was one freepascal example for 3+, but that's it.
I have zero understanding of how this works, or how to get it to work, and trying to learn how it works hasn't really helped.
I'm no fan of using sockets for IPC with a native process, especially because I'm not convinced zero-copy is supported.
Why does this have to be so unnecessarily complicated?
Why can't we simply have (shared) memory mapping and save people, me included, tons of unnecessary work?

Yes, I'm sure :)
As I mentioned, the documentation hasn't been updated yet.
Godot 4.0 is in alpha, which is an unstable stage of development where features still change on a daily basis and are not meant for use in production. Accordingly, they are not documented yet to the level that you would expect, and this is intended.
If you want it to "just work", you can use Godot 3.4.x, or wait for Godot 4.0 to reach a more stable phase with up-to-date documentation.


Use react-virtualized for recents rendering

Creates a smoother scrolling experience for recents widgets and removes the need for "load more".

Deploy preview for hopeful-hamilton-4090b9 ready!
Built with commit baf9f1efb7ef2908c9b5ad7cc53ec838402e99be
https://deploy-preview-761--hopeful-hamilton-4090b9.netlify.com

Still needs some journey test work for the selectors because of the virtual table


Allowing empty search body.

Super easy win.

Could you add a test that ensures we can search with only a sort as well?
Otherwise it looks fine

4f96049418b33118809cc0c0fdc9a1d74245aef2