v2.3.0 Roadmap

Overview
v2.2.1v2.3.0 is going to contain a host of new features and additions, as well as bug fixes and updates, dealing with problems in all modules and polishing up most of the components provided. Due to the fact that v2.2.1 was delayed a lot, I decided to drop the minor patch update and merge it with v2.3.0, so that more things can be added and fixed in one single release.
New features & components

[x] A modal component will be added, as requested in the past (see the discussion in #46).
[x] An Android-style switch component will be added. Mainly targeted at PWAs and mobile-centric flavors.
[x] .scrollable tables, allowing a better view for data. Bear in mind this might be pushed back to the next update, as it is certainly unstable so far.
Some atomic CSS classes might be added to help make layouts and other things easier for beginners. (See comments)

Bug fixes/updates/polishing up

[x] Reworked color palette, especially the gray tones, making buttons and code markup easier on the eyes.
[x] Slight update to the progress module's bars to make them look more modern (rounded edges and a bit less thickness are what I'm thinking of).
[x] Updates to the input_control module, especially .input-group components for convenience. This might actually happen either under the hood or not at all, based on internal tests and use-cases. Please report any trouble you had with the module and/or layout ideas that you had trouble implementing with the specific components.

Documentation
N/A yet.
Miscellaneous

[x] Updates to the package.json file, removing the doc folder to minimize download size, as well as updating the structure etc.
[x] .npmignore should now ignore the docs folder.
[x] Any and all work for updates will move to the next branch from now on.
[x] Add a $_1px variable to calculate the rem value of 1px whenever possible.
It is possible that variable mapping might make it into this update, but 99% it will be pushed back to the next one, as it will require a lot of creative thinking and changes to existing code.

Release date
There is no solid estimate yet, but this update will be releasing sometime this month. I will take as much time as required to make this update stable and content-rich, so that later updates build upon it and start addressing #19, which is becoming a reasonably pressing matter.

I'm you fan.

Update
Due to me working more on the React library for the framework, the next release will be later this month, but it is going to be a substantial one, adding the last few much needed components (such as modals and switches). There might also be a couple of hotfixes coming this week or the next one to make everything smoother. From there on out, it's going to be patches and bug fixes until everything is stable and #19 has been resolved fully to move to v3.0.0. Thank you all for the support and patience! 😉

Update
Rebranded as v2.3.0. The update is substantial enough to be a minor update instead of a patch, plus the fact that the bug fixes are very vaguely described so far and there is a lot of uncertainty as to what bug fixes will actually be included in this version.

Update
As far as atomic css classes are concerned, I took a long, hard look and I realized that, without a basic understanding of CSS, they wouldn't do anyone any good. That, combined with the fact that most of these classes are very situational and not really all that useful (they bloat the framework and ruin semantic markup), ultimately led to the decision to not add the atomic css classes, as there is no actual use-case I can find for any of them and/or I have to alter parts of the framework that work well as-is. However, I'm going to provide more templates in the future, showcasing neat tricks (such as aligning a <header>'s menu differently) for beginners. I think that is to the benefit of everyone using the framework. More notes might also be added in the future to certain components.

Regarding the model class, in the documentation http://minicss.org/contextual#modals on the 'Do' Note the example is wrong, unless so intended. The  should be first and the  right before the
Besides that, the modal in the Nord & Dark flavor is transparent. Is it supposed to be so ?

@anselal I see it, it seems like I made a mistake there. Thanks for pointing that out, I will be fixing it shortly.
As far as the transparency issue is concerned, I'm pretty sure the .modal itself has nothing to do with it. It seems to be a problem in the .card module's code. I'll open an issue and look into it soon.

@anselal The documentation has been updated and the issue seems to have been resolved. Thanks for reporting these problems! :)


RFR: Refactor heckell differ

Refactor the original heckel differ from loops to higher order functions in a number of places.
Brake up the tests into bite size chunks.
Add a tests to make sure the refactored differ and the old differ match
Once we get a few weeks of production usage will decide to kill the old differ in favor of the new one.

Looks like a big improvement overall.


Remove the build of shared lib and dynamic linking

Dynamic lib and dynamic linking are good for the situations to avoid re-linking the executions for minor changes in the libraries. But it also increase the complexity of deployment (all shared libraries need to be deployed to the correct paths).   By linking everything statically, we can avoid the deployment complexity.
@LucasMull   If you don't have objections, I will change the Makefile to remove the steps to build a shared lib.

Of course. No objections!

Of course. No objections!


Updating TIDashboard as the Landing page for TIs

Description
Please explain the changes you made here.
Release notes:
Describe the change as it should be communicated to partners in the release notes.
Checklist
General

[ ] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Issue(s) this completes
Fixes #<issue_number>; Fixes #<issue_number>...

Codecov Report

Merging #3752 (ff1d651) into main (285e5ae) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3752      +/-   ##
============================================
- Coverage     80.82%   80.79%   -0.04%
- Complexity     2448     2454       +6
============================================
  Files           296      297       +1
  Lines          9647     9668      +21
  Branches        658      659       +1
============================================
+ Hits           7797     7811      +14
- Misses         1596     1602       +6
- Partials        254      255       +1

Impacted Files
Coverage Δ

...lers/applicant/ApplicantInformationController.java
80.00% <ø> (ø)

server/app/models/Application.java
91.89% <0.00%> (-2.71%)
:arrow_down:

server/app/repository/ApplicationRepository.java
97.84% <0.00%> (ø)

server/app/models/PersistedDurableJob.java
71.42% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


WIP: PoC - custom middleware

Issue link

#296
Auto-close the issue?

Closes #296
Types of changes

Bug fix (non-breaking change that fixes an issue)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)

Test failed because of lint (unnused var).


Status effect icons sometimes don't match player state

Is _condition_bits even releated to m_nPlayerCond?

More info:

Status Effects seem to get stuck after ubers occasionally, a player might still have an indication of the ubered status effect, while not even being healed.

Additionally some effects that are 'missing' could be added:

Jarate & Milked (reuse the bleeding icon with a different color)
Burning/on fire
Spy invisibility

Possibly look at an icon for the 'slowed' natascha/stun effect, parachuting and if there should be a difference for the 'self-mark for death' with the Escape Plan and the 'being marked for death' with the Fan O'War.


LE Audio: Fix response code expected by ASCS/SR/SPE/BI-18-C

When handling ASE Control operations requested by client, first verify that the requested ID is within the allowed range. If it does, lets assume that the NULL returned from ase_find() means the ASE state is set to idle.
This will fix ASE Notification Response code expected by the ASCS/SR/SPE/BI-18-C PTS test case.

I don't quite understand the issue. Can you elaborate on what the problem is?

In ASCS/SR/SPE/BI-18-C test case the PTS skips the Codec Config procedure and tries to trigger Config QoS, Enable, Disable, Update Metadata and Release operations.
Because the Codec Config procedure has never been performed, the selected ASE is in Idle State or at least it should be.
After looking into Zephyr's ascs.c I've notice that until ascs_config() is called, the ascs->ases list will remain empty. Thus the checks like this
ase = ase_find(ascs, id);
if (!ase) {
    ascs_cp_rsp_add(qos->ase, BT_ASCS_QOS_OP,
        BT_ASCS_RSP_INVALID_ASE, 0x00);
    ...
}

which appears in ascs_qos() ascs_enable(), etc., will always result in sending notification with BT_ASCS_RSP_INVALID_ASE instead of BT_ASCS_RSP_INVALID_ASE_STATE.
In the proposed commit I assumed, that if the requested by PTS ASE id is legit and the ASE itself is absent in the ascs->ases list, we could treat the ASE just as unconfigured, thus in Idle state.
Other solution I was thinking about was to replace ase_find() usages with ase_get(), but then others checks broke, so I stayed with this safe-feeling solution for now.

In ASCS/SR/SPE/BI-18-C test case the PTS skips the Codec Config procedure and tries to trigger Config QoS, Enable, Disable, Update Metadata and Release operations. Because the Codec Config procedure has never been performed, the selected ASE is in Idle State or at least it should be.
The PTS expects to receive ASE Control Point notification with response code BT_ASCS_RSP_INVALID_ASE_STATE (0x4). But without this fix it receives BT_ASCS_RSP_INVALID_ASE(0x3) instead.
After looking into Zephyr's ascs.c I've noticed that until ascs_config() is called, the ascs->ases list will remain empty. Thus the checks like this
ase = ase_find(ascs, id);
if (!ase) {
    ascs_cp_rsp_add(qos->ase, BT_ASCS_QOS_OP,
        BT_ASCS_RSP_INVALID_ASE, 0x00);
    ...
}

which appears in ascs_qos() ascs_enable(), etc., will always result in sending notification with BT_ASCS_RSP_INVALID_ASE instead of BT_ASCS_RSP_INVALID_ASE_STATE.
In the proposed commit I assumed, that if the requested by PTS ASE id is legit and the ASE itself is absent in the ascs->ases list, we could treat the ASE just as unconfigured, thus in Idle state.
Other solution I was thinking about was to replace ase_find() usages with ase_get(), but then others checks broke, so I stayed with this safe-feeling solution for now.

Thanks - Yeah that makes sense.
The reason for this is of course that we dynamically allocate the ASEs, and we handle the read part of it specifically by
	ase = ase_find(ascs, ase_id);

	/* If NULL, we haven't assigned an ASE, this also means that we are currently in IDLE */
	if (!ase) {
		ascs_ep_get_status_idle(ase_id, &ase_buf);
	} else {
		ascs_ep_get_status(&ase->ep, &ase_buf);
	}

The problem with the suggest approach, is that we now basically duplicate the state checks, as BT_ASCS_RSP_INVALID_ASE_STATE is also the response later on.
I'll add some specific suggestions in the code


📝 Document git clone over ssh

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Minimize scope of expensive lock

We've seen this section hang, eating up the lock when shutdown takes a long time. This should minimize the size of the critical section to a single copy of self.last_access_times.items() so that it still avoids #27501 (which the lock was introduced for) without hanging too long.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @tvalentyn


Avoid name collisions with Int64 and values beginning with digits.

This fix prevents us from generating invalid code when certain proto fields are "Int64" or start with digits, which apparently is allowed for at least proto enums.

I am not able to compile a proto with an enum-value starting with a digit.
If you are able to, please add a test/protos/x.proto file deomnstrating this, and a test importing and using it. That is a much  stronger test than a golden file test.

I believe this can only happen in cases where the name starting with a digit is also prefixed with an underscore. So, the name mangling removes the underscore and makes it an invalid Dart name. I'll fix up the tests as you described.

Ahhh - that makes sense. Good find!


[installer] [rhel] Un installing the ballerina installer not works

Description:
Uninstalling the ballerina installer not works on Redhat linux.
Steps to reproduce:

install the ballerina installer

[root@ballerinaonrethat3 sw]# rpm -ivh  ballerina-runtime-linux-installer-x64-0.970.0.beta1.rpm
Preparing...                          ################################# [100%]
Updating / installing...
1:ballerina-runtime-0.970.0.beta1-1################################# [100%]

Uninstall using below [1]

[root@ballerinaonrethat3 sw]# rpm --erase Ballerina
error: package Ballerina is not installed

But when check the location is has installed

[root@ballerinaonrethat3 sw]# ls /opt/
Ballerina  node-v8.11.1-linux-x64
[root@ballerinaonrethat3 sw]# ls /opt/Ballerina/
ballerina-runtime-0.970.0-beta1

[1] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/deployment_guide/s2-rpm-uninstalling
Affected Versions:
ballerina-runtime-linux-installer-x64-0.970.0.beta1.rpm
OS, DB, other environment details and versions:
rhel 7.3 | oracle jdk 1.8.0_161
Suggested Labels (optional):
Type/bug
Priority/High

This issue has been fixed in latest RPM installer.

Thanks @ThilinaManamgoda .
Verified with beta13 installer as below, hence closing.

[root@ballerinaonrethat3 cloud-user]# rpm --erase ballerina-platform
[root@ballerinaonrethat3 cloud-user]# ls /opt/Ballerina/
[root@ballerinaonrethat3 cloud-user]#


fix go vet error and some typos.

don't use generic names such as "this" or "self"
fix go vet errors
fix some typos.

Signed-off-by: Bo-Yi Wu<EMAIL_ADDRESS>

lgtm 👍


[SPARK-30129][core] Set client's id in TransportClient after successful auth.

The new auth code was missing this bit, so it was not possible to know which
app a client belonged to when auth was on.
I also refactored the SASL test that checks for this so it also checks the
new protocol (test failed before the fix, passes now).

Test build #114874 has started for PR 26760 at commit 6c94d63.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19697/
Test PASSed.

Test build #114874 has finished for PR 26760 at commit 6c94d63.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114874/
Test FAILed.

Test build #114880 has started for PR 26760 at commit 0c52757.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19703/
Test PASSed.

Test build #114880 has finished for PR 26760 at commit 0c52757.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/114880/
Test PASSed.

Merged to master. Could you make a backporting PR to branch-2.4?


MM-23357 - Add e2e test for issue MM-23357

Summary
Created a test where three users are added to a GM and search for a certain user by a substring of their name which is not their display name.
Ticket Link
Jira: https://mattermost.atlassian.net/browse/MM-23357
Test case: https://automation-test-cases.vercel.app/test/MM-T1226

This was pretty tricky because the selector looked like this id="switchChannel_usere95217, userfefd0b" but the Id is dynamic, so sometimes the order of the users would be switched, which would cause the test to fail. For some reason, testing library's findByText method also failed for finding the span text that contained the username of the user we searched for, so I had to select the element by class and make sure the div contained the username text of the user we searched for. Please let me know if I should refactor this :)

I implemented the suggested changes :)
Thanks @saturninoabril and @josephbaylon for taking the time to review this!

/update-branch


Step 5 of "Retrieve an item using the SDK" is incomplete

If you run the command dotnet run -- --name 'Mica Pereira' in step 5 of "Retrieve an item using the SDK" is incomplete", you get
Option '--state' is required.
Option '--country' is required.
It appears the command should be:
dotnet run -- --name 'Mica Pereira' --state 'Washington' --country 'United States'

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: af90dbc6-bff5-0f9a-7969-ac94b0352987
Version Independent ID: ec5de32b-ad0a-be2f-144f-6376ca55ccd9
Content: Tutorial: Develop a .NET console application with Azure Cosmos DB for NoSQL

Content Source: articles/cosmos-db/nosql/tutorial-dotnet-console-app.md
Service: cosmos-db
Sub-service: nosql
GitHub Login: @seesharprun
Microsoft Alias: sidandrews

@perktime
Thanks for your feedback! We will investigate and update as appropriate.

@perktime, this is being fixed and published soon.


DO NOT MERGE use next endpoint for smaller imgs

dependent on on media.artblocks being whitelisted by next


Two-and-three body support for UFCalculator and UFLammps

[WIP] Three-body contributions for UFCalculator for multicomponent systems are experiencing some minor bugs
Three-body contributions for UFLammps will require a tensor-product spline evaluator in C++ for LAMMPS

Three-body contributions for UFCalculator for multicomponent systems have been fixed (5f67d5f2442185b4b9a04980d89faeafe8991edf and 274c0babbf6907d2a5d98c587dc99d61d696be97).
Three-body contributions in LAMMPS is under development in a fork of UF3.


No SD15 item in selections

You need to use Layer Diffuse Cond Joint Apply node instead. The joint node only supports SD15 and produces conditioned FG/BG + blended image in single pass.


Internal process: remove the usage of the stable branch

Currently, when doing releases of Meilisearch, we use and provide a stable branch. Basically, the stable branch contains the latest stable commit, so it corresponds to the latest Meilisearch release.
See our full process.
However, we found some issues using and providing this stable branch

this adds complexity by adding an intermediate step for each release -> merging the release-vX.X.X branch into stable
this leads to a struggle with some git conflicts

Pros and cons of removing stable
Pro

we remove complexity: we only do GitHub release on the release-vX.X.X and the release-vX.X.X branch is brought back to main once the release is done. When a patched release is needed (ex: v0.30.1), we start the new release-v0.30.1 branch from release-v0.30.0 instead of stable
we remove some git conflict. However, not all will be avoided, for example, when bringing back release-vX.X.X into main after a release.
Integration team, cloud team, and docs team do not use stable in their internal processes.

Cons

we don't provide a git reference (stable) anymore to access the latest stable version of Meilisearch without caring of the version number
the official documentation of Meilisearch refers to it here (in the Source tab)

Final possibility

[x] Stop using stable and rename it stable-archived to avoid removing it, and make anyone understand not to use it.
[x] Only create GitHub releases on the release-vX.X.X branch and bring back the release-vX.X.X commits into main.
[x] When releasing a stable GitHub release of Meilisearch, create a git tag latest to replace the stable reference we provided with the stable branch -> PR submitted https://github.com/meilisearch/meilisearch/pull/3172
[x] Update the documentation part accordingly -> https://github.com/meilisearch/documentation/pull/2026
[x] Update our internal process guide -> https://github.com/meilisearch/engine-team/pull/35

Closing this issue, stable branch is officially out of our process


test

[ ] test 1
[ ] test 2
[ ] test 3

Finally, I can sleep safely tonight now that this issue is closed.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:26: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:33: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:33: missing_description: The recipe is missing a description
ERROR: /tmp/abs_e6ryd3d2e2/clone/recipe/meta.yaml:33: missing_dev_url: The recipe is missing a dev_url
Errors were found


fix: crash when lassie is not allowed to merge

How to reproduce

Configure a protected branch with Allowed to merge set to No one.
Let lassie try to merge into this protected branch.
:boom:

Closed by #64


Improvements for the dropdown chevrons

@msbt suggested at https://github.com/crate/crate-docs-theme/pull/417#issuecomment-1669014083:

Quick question about the chevrons you're using for up/down: Wouldn't it be nicer to have only one that turns 180° when you open it instead of two that show/hided depending on the status?

Like
details.sd-dropdown .sd-summary-down {
  transition: 180ms;
}

details.sd-dropdown[open] > .sd-summary-title .sd-summary-down {
  /* visibility: hidden; */
  transform: rotate(-180deg);
}

Dear @msbt,
thanks for your suggestion. An improvement like this should probably be directed to https://github.com/executablebooks/sphinx-design.
With kind regards,
Andreas.

@amotl ah alright, I thought that was your thing 😀

Dear Matthias,
this humble repository is just building upon the excellent work by @chrisjsewell and contributors, whom all credits are due. Unfortunately, I've not made it in time to reach out to them properly yet, and now I am kind of heading to the beaches already. I hope to be able to do it properly after vacation.
With kind regards,
Andreas.


Message marked as read but has not yet been Opened!

[PT]
Após enviar a Mensagem no Painel ela já é marcada automaticamente como Entregue e Lida pelo Usuário!
Porém a Mensagem não foi lida ainda!
Alguma Solução?
[EN]
After sending the Message in the Dashboard it is already automatically marked as Delivered and Read by the User!
But the Message hasn't been read yet!
Any solution?

Same here! will try to solve it but If anyone has already fix it... will help a lot. ty

I partially fixed this, I thought I had solved it but later realized i didn't solve everything.
After you open the ticket and leave it, the other messages will appear correctly as unread. Only the first message of the ticket doesn't seem to work.
Examples:

Client sends 1 message (the ticket is created but doesn't show as unread)
Client sends 2 messages (the ticket is created and shows that there is 1 unread message instead of 2)
After the ticket is read once, if the client sends more messages it counts correctly.

Found it, it happens when whaticket assigns the queue to the ticket:

wbotMessageListener.ts
And when you open "UpdateTicketService"

UpdateTicketService.ts
Just gotta find the right way to solve it now

UpdateTicketService.ts
This seems to be working.

wbotMessageListener.ts
This change I had been using for a while, if fixes the quantity of unread messages.

@Horgun so the change in the UpdateTicketService.ts seems to work? I have to add the '+1' in the wbotMessageListener.ts file also? or it was a temporal fix this last one?


Hi, could you help me to fix this error

[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Error! Errno: No such device or address
[mpu9250driver-1] Accelerometer Range: +-2g
[mpu9250driver-1] Gyroscope Range: +-250 degree per sec
[mpu9250driver-1] DLPF Range: 94 Hz
[mpu9250driver-1] Accelerometer Offsets: x: -0.00359253, y: -0.00359253, z: -9.81359
[mpu9250driver-1] Gyroscope Offsets: x: -0.0458015, y: -0.0458015, z: -0.0458015
[ERROR] [mpu9250driver-1]: process has died [pid 24861, exit code -8, cmd '/home/vis/Desktop/ros2_mpu9250_driver/install/mpu9250driver/lib/mpu9250driver/mpu9250driver --ros-args -r __node:=mpu9250driver_node --params-file /home/vis/Desktop/ros2_mpu9250_driver/install/mpu9250driver/share/mpu9250driver/params/mpu9250.yaml'].

this is my output, I could get data of IMU in arduino ide, my IMU is MPU6500, I read from several articles that MPU9250 registers have the same construction with MPU6500, please help me to understand what error is this,
Thanks)

@Narek-939 you may have to adjust the bus number for your sensor.
The LinuxI2cCommunicator allows to specify the bus number in the constructor. The default value is 1 which may not be the same as in your case.
You can pass the number in this line: https://github.com/hiwad-aziz/ros2_mpu9250_driver/blob/482aa093c36dae0303a103c3d6e9296151146f65/src/mpu9250driver.cpp#L13
See the constructor for reference:
https://github.com/hiwad-aziz/ros2_mpu9250_driver/blob/482aa093c36dae0303a103c3d6e9296151146f65/lib/i2c/src/LinuxI2cCommunicator.cpp#L15C7-L15C7

I fixed that error but after that I am encountered to this
[mpu9250driver-1] /dev/i2c-1
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error powering down magnometer
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error reactivating magnometer
[mpu9250driver-1] [INFO] [1691413297.969331678] [mpu9250driver_node]: Calibrating...
[mpu9250driver-1] Accelerometer Range: +-2g
[mpu9250driver-1] Gyroscope Range: +-250 degree per sec
[mpu9250driver-1] DLPF Range: 94 Hz
[mpu9250driver-1] Accelerometer Offsets: x: -5.92275, y: 1.4816, z: -15.5174
[mpu9250driver-1] Gyroscope Offsets: x: 0.21629, y: 3.40532, z: -1.80744
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error
[mpu9250driver-1] Error! Errno: Remote I/O error


Configure Google Healthcare extension?

Our webapp presents the user with a list of DICOM studies related to cases in a cohort that the user has created based on various criteria. The user can then select a one more studies to view in separate tabs. In our current implementation, using OHIF 1.x, I just pass the study ID in the URL. BTW, we don't expose the studylist button.
I'm interested in moving to Google Healthcare as our PACS, but don't see a similar ability to command OHIF 2.0 to open a specific study in a chc datastore via the URL. Ideally, I think I'd like to be able to set the default project/location/dataset/dicomstore in a config file, but then override any of those in the URL. E.G., having configured the default project/location/dataset/dicomstore as chc-tcia/us-central1/foo/bar, I could then override the dataset/dicomstore in the URL. Something like:
https://viewer.ohif.org/dataset/tcga-brca/dicomstore/tcga-brca/StudyInstanceUID/1.3.6...
Is there any such functionality now or planned?
Thanks.

+1 I'd like that functionality too but I don't believe it's available yet.  It would be great if someone could add an example.

This sounds like a nice value add. A couple of ways to approach this:
Option 1

Configure a default Server
Provide an alternative server config with query parameters

Option 2

Configure multiple servers, identify one as the default
Specify a configured server's alias or index in the URL to use instead of the default

If I'm missing the mark, or you think there are alternative implementations worth considering, don't hesitate to chime in ^_^

Hi @dannyrb  - It would be ideal if one could visit the url @bcli4d provided and then get redirected to a google oauth login / permissions page.  Then if you have permissions you would get redirected back to the ohif viewer with the correct tokens to access the study in the original url.  There shouldn't need to be any custom servers involved.

Hi @dannyrb . We currently only expose TCGA images, but there are 21 TCGA cancer types with DICOM images, and Google Healthcare has dedicated a separate dataset/datastore to each in its TCIA public data set. If I understand your proposal, you would have us create and configure a server for each? (Not to mention the 56 other Google Healthcare dataset/datastores.)

@bcli4d, I didn't have a clear understanding of the problem. @pieper's comment is a much more appropriate solution.

This would definitely be a nice addition! We'd be happy to review a PR.

If I understand your proposal, you would have us create and configure a server for each? (Not to mention the 56 other Google Healthcare dataset/datastores.

You don't have to add all of them, you can add the one you need dynamically based on the URL. This is exactly what currently happens via the DICOM Store picker. It erases all other servers and adds a DICOMWeb server for the specific DICOM Store when it is selected, and makes that server active:
https://github.com/OHIF/Viewers/blob/f547fdf83296c1d57fc0a9f99ead249f28c60074/src/googleCloud/DicomStorePickerModal.js#L22-L36
I think you would need to do this:

Add a custom route for '/dataset'/ here: (https://github.com/OHIF/Viewers/blob/40bf1a2efd42a22f89648cc332132f46e390e9b3/src/OHIFStandaloneViewer.js#L115-L123) if enableGoogleCloudAdapter is true (https://github.com/OHIF/Viewers/blob/40bf1a2efd42a22f89648cc332132f46e390e9b3/src/studylist/StudyListWithData.js#L207-L213)
The custom route component parses dataset/tcga-brca/dicomstore/tcga-brca (I think you would need to include the project as well, or make that configurable somewhere?) and calls setServers. It then parses the rest of the URL (e.g. IHEInvokeImageDisplay) and displays the Viewer or Study List.

If you have configured the OIDC settings then the redirect behaviour should work automatically.
Hope that helps!

Erik,
Thanks for the suggestions. I think I understand what you propose. I don't have any React experience so might be back for help!
Regards,
Bill

Related to #790
Scoped here: https://github.com/OHIF/Viewers/issues/753#issuecomment-520315169
Added to backlog with Story 🙌  label


TotalOriginalDataSize does not mention the Unit of measurement. Is it Bytes ?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edf45cf2-2f81-6063-01eb-6195d2e04054
Version Independent ID: 5d1e0dd2-d14c-8a59-ce77-1b9f90fbe828
Content: Diagnostic information - Azure Data Explorer
Content Source: data-explorer/kusto/management/diagnostics.md
Service: data-explorer
GitHub Login: @orspod
Microsoft Alias: orspodek

Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @gbmsft,
Sorry for the delay in response. Yes, the unit of measurement for 'TotalOriginalDataSize' output parameter is 'bytes' .
Hope this answers your query. We will now proceed to close this thread. If there are further questions regarding this matter, please feel free to comment or open a new issue. We will gladly continue the discussion.
Thank you


Move from Python 2 to Python 3 on Heroku deployment

I'm submitting a ...

[ ] bug report
[x] feature request

Current behavior:

Currently, app deployed on heroku using python 2
Expected behavior:

Move from Python 2 to Python 3 on Heroku deployment
Steps to reproduce:
Others can claim

@bhaveshAn Hi, Can I work on this. Any tips before get started? :)

First https://github.com/fossasia/query-server/issues/565 has to be solved. Contributors should create PRs against python3 branch

Can I work on this issue.


New Version of Chrome cannot render dd function in network preview window

Laravel Version:  5.4.* and 5.5.*
PHP Version: 7.0.13
Database Driver & Version: Mysql 5.6

Description:
When updated to chrome version 62.0.3202.66, dd function cannot be rendered by chrome network preview window.

And I have found the changelog of chrome. Commit f674b40baf2d44d1b27f33b3ed39e60b2b9169da says it will not render as HTML agressively if requested via XHR.
Steps To Reproduce:

Update to chrome version 62.0.3202.66
Execute a dd function
Check the chrome network preview window

it is releated to issue #21317 . I think the reason is new version of chrome consider the javascript is agressive, so it will not render.

I read the chrome source code, it will use base64 to encode the response body first, and then render the html, so it may cause javascript not be rendered?

This is symfony/var-dumper issue.

ok, i will transfer this issue to symfony

I think this is Chrome issue, have you find any solution for this issue?
The dd() or var_dump() only present html but with the 500 error, chrome still render correctly.
I see the different is the html tag, the 500 error has the  but the dd() missed these tag.

How to fix this???

@tonghia  I tested after adding  tag, it also doesn't work.
@alinasiri1367 there are some approaches to solve it in this issue

This function works pretty well for me. Only handles the HTML Dumper, not the CLI dumper, so it wont work in artisan commands, but if your using those you can just use the normal dd() function.
function _dd(...$args)
{
    $content = "<!DOCTYPE html>";

    foreach ($args as $arg) {
        $val = (new \Symfony\Component\VarDumper\Cloner\VarCloner)->cloneVar($arg);
        $dumper = new \Illuminate\Support\Debug\HtmlDumper;
        $content .= $dumper->dump($val, true);
    }

    $content .= "";

    return response($content, 500)->header('Content-Type', 'text/html')->send();
}

@jakewtaylor is there a way not to return a response but to dump or print and perform die in your helper function()? so that you dont need to pass it out from the controller?

Great. Thank you for your help.
On Wed, Mar 7, 2018 at 3:23 AM, Arjon Jason Castro<EMAIL_ADDRESS>
wrote:

@jakewtaylor https://github.com/jakewtaylor is there a way not to
return a response but to dump or print and perform die in your helper
function()? so that you dont need to pass it out from the controller?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/21808#issuecomment-371060275,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQHkElJjbTV9boH0RH3mBNtyYlFqwPaXks5tb5jygaJpZM4QFYCt
.

--
max

chrome has fixed this bug...

Im using chrome version 67.0.3396.99 and i still have the issue, @friparia in which version has been fixed?

@quarkmarino in chrome 67 i had to use this custom function somewhere in the helpers directory.
if (!function_exists('_dd')) {
 function _dd($args)
    {
        http_response_code(500);
        dd($args);
    }
}

then use this function _dd($your-collection) to dump

I had the same problem on my mac. I had a Chrome version 67.xxx
and after updating to 68.0.3440.75 I can scroll again.

Yeah, I've updated to 68 and it works again, "Sweet sweet preview scroll, never leave me again"

If you want to change status to 500 for your ajax requests you just need to update
project/vendor/symfony/var-dumper/Dumper/HtmlDumper.php
class on line 111 where dump() method exists.
Just add line http_response_code(500); at the beginning of function. It works for Laravel 5.6 version.

for me it is because Access-Control-Allow-Origin,
200 can go through but 500 error not showing
.. no preflight error or what, 2 hours wasted

Laravel Version:  5.4.* and 5.5.*
PHP Version: 7.0.13
Database Driver & Version: Mysql 5.6

Description:
When updated to chrome version 62.0.3202.66, dd function cannot be rendered by chrome network preview window.

And I have found the changelog of chrome. Commit f674b40baf2d44d1b27f33b3ed39e60b2b9169da says it will not render as HTML agressively if requested via XHR.
Steps To Reproduce:

Update to chrome version 62.0.3202.66
Execute a dd function
Check the chrome network preview window

Put header('Content-Type: text/html'); before the dd or dump.

Same here... any thoughts?

@tnatanael  new version should work tho.

Laravel 5.4 is not even supported and  out of support :)

There was an update to Chrome recently (72) that broke this again. Laravel 5.4 being unsupported is irrelevant here.

There was an update to Chrome recently (72) that broke this again. Laravel 5.4 being unsupported is irrelevant here.

Put header('Content-Type: text/html'); before of the dd or dump.

header('Content-Type: text/html');
Also does not work! Thanks for the try!

This bug is back on Chrome 72. Also for laravel 5.5. The easiets solution (for me and for now), is downgrade google-crome-stable to version 71.
You can download here: https://www.slimjet.com/chrome/google-chrome-old-version.php

This seems to be a bug in Chrome 72, indeed.

Thank you, I've already installed chrome 70 and just havent updated it to
any onther version
El mar., 12 de feb. de 2019 a la(s) 09:54, Rafael Souza (
<EMAIL_ADDRESS>escribió:

This bug is back on Chrome 72. Also for laravel 5.5. The easiets solution
(for me and for now), is downgrade google-crome-stable to version 71.
You can download here:
https://www.slimjet.com/chrome/google-chrome-old-version.php
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/21808#issuecomment-462814847,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2m7Xr87wh6skVRLXUnLr3--Lszei64ks5vMuPPgaJpZM4QFYCt
.

Same problem :( with Version 72.0.3626.109 (Official Build) (64-bit)

As this is just becoming a dumping ground for people reporting that they have the issue I'm locking this. We can't do anything to fix this ourselves.


upvoting/unvoting and creating posts and comments

Removed all the "return reject" that caused a lot of errors when we last uploaded a build with those functions


Error on vessel encoded run

Looks to be related to changes to definition of Extras in quantiphyse. Straightforward VE run on Tom's data:

v0.9.2


LUA error with latest release.

Getting this issue today with the latest version Bagnon_ItemLevel-1.0.50-Release-bcc.zip just downloaded from CurseForge. This happens when opening Bagnon
Message: Interface\AddOns\Bagnon_ItemLevel\main.lua:169: attempt to index global 'color' (a nil value)
Time: Mon May 30 18:04:43 2022
Count: 13
Stack: Interface\AddOns\Bagnon_ItemLevel\main.lua:169: attempt to index global 'color' (a nil value)
[string "=[C]"]: ?
[string "@Interface\AddOns\Bagnon_ItemLevel\main.lua"]:169: in function <Interface\AddOns\Bagnon_ItemLevel\main.lua:100>
[string "=[C]"]: in function Update' [string "@Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua"]:40: in function <...face\AddOns\Bagnon\common\Wildpants\classes\item.lua:34> [string "=(tail call)"]: ? [string "@Interface\AddOns\Bagnon\common\Wildpants\classes\itemGroup.lua"]:124: in function func'
[string "@Interface\AddOns\Bagnon\common\Wildpants\libs\MutexDelay-1.0\MutexDelay-1.0.lua"]:36: in function <...mon\Wildpants\libs\MutexDelay-1.0\MutexDelay-1.0.lua:30>
Locals:

Fixed in 1.0.51-Release which should be available shortly!


Switch learning engine to Emmental

Please try to annotate types when your memory is fresh.

Use pip install torch==1.3.0+cpu -f https://download.pytorch.org/whl/torch_stable.html in travis to install a much lighter version of torch (travis does not provide GPU, does it?).
Details can be found at #309.

torch==1.3.0+cpu doesn’t exist last night?

Maybe but now 1.3.0+cpu is listed on https://download.pytorch.org/whl/torch_stable.html.
Are you sure about >=1.3.0? It's just released yesterday. We don't know its stability yet.

Great! It works now. I will use 1.3.0+cpu for linux. 1.3.0+cpu is the latest stable version. :)

You probably want to update the Acknowledgement block in the README in this PR also.

Good catch! Will update this PR tonight.

I asked ReadTheDocs about the memory issue with PyTorch. This was their response:

Thanks for reporting this to us.
This is a known issue. It seems that there is some memory leaking with that package and pip because it consumes a lot of memory to be installed. Unfortunately, there is not too much we can do at this time.
I'm taking the suggestion to include pytorch as a system package. Although, we don't upgrade the Docker images too often, so it pytorch will probably be outdated immediately.
I'm not sure how are you using pytorch to build the docs, but in case that you want to document the code itself, you may want to give a try to https://sphinx-autoapi.readthedocs.io/en/latest/ that documents the code without executing it, so there is no need to install a lot of dependencies.

That said, I doubt the autoapi extension really doesn't need the package to be present, as it sounds essentially the same as the autodoc extension we are using. We should still look into it.

Looking further, it seems the autoapi extension was built by readthedocs directly to help address the limitations of autodocs:

Sphinx AutoAPI provides "autodoc" style documentation for multiple programming languages without needing to load, run, or import the project being documented.
In contrast to the traditional Sphinx autodoc, which is Python-only and uses code imports, AutoAPI finds and generates documentation by parsing source code.

https://github.com/readthedocs/sphinx-autoapi
So, migrating over to this may save us the hassle of dealing with imports in the future.

autoapi lacks the ability to show inherited members. See autoapi_options in
https://sphinx-autoapi.readthedocs.io/en/latest/reference/config.html
This is an autodoc feature we are heavily using, so it doesn't seem like a good drop-in replacement.


foreign-library component is not recognized

cabal GenericPackageDescriton doesn't return related information.
How do we get those?

6dddffc553b78eda28536d681eaa0480e2af696d solves this issue.


Mocha 3.4.2 | Error: Resolution method is overspecified. Specify a callback or return a Promise; not both.

Hi,
Even though issue #2407 and #2413 are closed, I am still getting same error with mocha 3.4.2.
Thanks,
Sanjeev

Is this a bug? It seems odd to return a promise and pass a callback. Why not choose one? Wouldn't changing return promise.then to promise.then in your test(s) fix this?

aah...Thanks for pointing this.
It does work!


Update AutoRest C# version to 3.0.0-beta.20231109.1

Update AutoRest C# version to 3.0.0-beta.20231109.1

close since it's covered by https://github.com/Azure/azure-sdk-for-net/pull/39890


Remove references to Shwifty

Shwifty was the original name for Moat because it only supported Swift. We now support Swift, Kotlin, and soon Typescript

The only problem I have with this is that "getShwifty" makes sense, whereas "getMoat" does not. Otherwise LGTM

We could call it getMoatyMcMoatFace if you like?

I am not sure what the name should be. I have never liked the name moat, and would prefer the library to be re-named before initial version release, but that's not up to me (and may not be worth your time). perhaps get prefix should be renamed to gen, so it makes a bit more sense.


Support hsl() colors

Currently, hsl() colors are not supported. The following is considered invalid
<mjml>
  <mj-body>
    <mj-section>
      <mj-column>

        <mj-image width="100px" src="/assets/img/logo-small.png"></mj-image>

        <mj-divider border-color="#F45E43"></mj-divider>

        <mj-text font-size="20px" color="hsl(0, 100%, 50%)" font-family="helvetica">Hello World</mj-text>

      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

and the error message is Attribute color has invalid value: hsl(0, 100%, 50%) for type Color
Can we add support for hsl color in the validation function or is there a particular reason to avoid that?
https://github.com/mjmlio/mjml/blob/50cd15b194d39eef7a3cdc399796e6618e4a9e1a/packages/mjml-core/src/types/color.js#L16-L18

If I recall those are the only format that are supported in older clients. So I’m not sure we want to allow hsl here as we can’t really guarantee it to work On 19 Sep 2023, at 15:32, Mika Andrianarijaona @.***> wrote:
Currently, hsl() colors are not supported. The following is considered invalid

    <mj-image width="100px" src="/assets/img/logo-small.png"></mj-image>

    <mj-divider border-color="#F45E43"></mj-divider>

    <mj-text font-size="20px" color="hsl(0, 100%, 50%)" font-family="helvetica">Hello World</mj-text>

  </mj-column>
</mj-section>

and the error message is Attribute color has invalid value: hsl(0, 100%, 50%) for type Color
Can we add support for hsl color in the validation function or is there a particular reason to avoid that?
https://github.com/mjmlio/mjml/blob/50cd15b194d39eef7a3cdc399796e6618e4a9e1a/packages/mjml-core/src/types/color.js#L16-L18
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

If I recall those are the only format that are supported in older clients. So I’m not sure we want to allow hsl here as we can’t really guarantee it to work On 19 Sep 2023, at 15:32, Mika Andrianarijaona @.> wrote: Currently, hsl() colors are not supported. The following is considered invalid       Hello World     and the error message is Attribute color has invalid value: hsl(0, 100%, 50%) for type Color Can we add support for hsl color in the validation function or is there a particular reason to avoid that? https://github.com/mjmlio/mjml/blob/50cd15b194d39eef7a3cdc399796e6618e4a9e1a/packages/mjml-core/src/types/color.js#L16-L18 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.>

@iRyusa I tried to find data about that but there was no hsl entry on https://www.caniemail.com/features/css-rgba/. Looking at https://caniuse.com/?search=mdn-css_types_color_hsla, there is pretty good support among browsers but that may not be representative. I did some tests on OSX Mail and GMail in browser and it works fine


Pascalcase mismatched types

someTypeDAO won't work correctly with pascalcase, we really need to type check our generated folder

@jordanshatford while I found a solution, it doesn't feel good and I think we should overhaul our architecture. Final values are often (always?) determined from model.base which can be any string – string, 'string', or stringModel. I'm not sure there's a reliable way to determine which one of these should be transformed. What I am doing in my fix is assuming if there's a match in the $refs array, it's a reference to top-level type which would get transformed, and therefore we should transform base too.


ES6 IntelliSense Preview is very broken

I have a node 4 file that uses ES6 backtick templates but I am getting errrors with the ES6 Preview enabled
This image shows the problem

The ES6 is active as the comboboxes at the head of the file show and tehre are no red squiggles on the backticks.
However there are many errors for line 16 (with backtick). @madskristensen  says these are form the language services -though important identifying information is omitted from the errors. Also the Error windo was not opened so it's easy to miss them.
If the errors are clicked on the src file is reopened without the combo boxes and with red squiggles on the backticks

All in all it's very broken.

It may not be at all related but when I had full intellisense option enabled (not ES6) webanalyzer crashed when trying to edit my eslintrc or running it on a file. Enabling ESc6 stop the crash

@billti - any ideas?

Having what appears to be very similar errors:
With or without ES6 intellisense enabled i am getting lots of errors around ES6 code including:

template literals
arrow functions
import statements

Additionally suffering from Visual Studio crashing very frequently (see https://github.com/Microsoft/nodejstools/issues/656#issuecomment-171604581)

With the latest preview builds and ES6, arrow and template strings seem to be working.
import statements still are broken: Cannot compile modules unless the '--module' flag is provided with a valid module name type ...
Please open more targeted issues to track any issues you run into with the new preview builds.


Add ansible for provisioning network resources on new cloud

This adds some new provisioning code for bootstrapping our new cloud
with network resources. It creates a new 'cloud_bootstrap' role that will
supercede the old 'create-hosts' role.  The new one will encompass more than
just hosts and encompass managing production users/projects/roles,  networks,
servers, etc.
Resolves-Issue: BonnyCI/projman#133

@j2sol nodepool doenst need to see any of these security groups, it will only ever be booting instances on the nodepool network with the default security group. The security group relevant to the slaves here is the sg-zuul-merger, which allows inbound git clones to the merges from the nodepool network, but again the nodepool side doesnt need to be concerned with that.

@gandelman-a that's an excellent point! I rescind my concern.
I'll wait for the spec to get approved and then lift my negative review.


Change symbol to Symbol

Since symbol is a class and initiated with new it should be named Symbol, but it would break a lot of existing code...

symbol() is now renamed to Symbol(), but we keep it backwards compatible for the moment, but it will be removed in a future version.


Felix requires ACCEPT-by-default on iptables

As discussed in the Calico mailing list, Felix doesn't cope with iptables being set to DROP by default on the INPUT or FORWARD chains. Traffic does not get to VMs. That's obviously a problem.
We should look at enhancing Felix to program the appropriate rules in this situation.

This is trivial to fix - probably worth just fixing it ASAP to get rid of it.

We don't want to go nuking a compute host's security rules because that could have some serious side effects - and so we expect to document this as a manual requirement (and add an alarm so that if you get it wrong you can diagnose the problem).
To get past this on an OpenStack system you can run the following commands.
iptables -A FORWARD -i tap+ -j ACCEPT
iptables -A FORWARD -o tap+ -j ACCEPT
iptables -A INPUT -i tap+ -j ACCEPT

Doing so means that traffic from / to tap interfaces (i.e. VMs) is accepted if Felix permits and no earlier rule has barred it.

In my Fuel work, I've had to add these incantations on the controller:
# Allow BGP through the Fuel firewall
iptables -I INPUT 1 -p tcp --dport 179 -j ACCEPT

# Allow Calico API connections through the Fuel firewall
iptables -I INPUT 1 -p tcp --dport 9901 -j ACCEPT
iptables -I INPUT 1 -p tcp --dport 9903 -j ACCEPT
iptables -I INPUT 1 -p tcp --dport 9904 -j ACCEPT
iptables -I INPUT 1 -p tcp --dport 9905 -j ACCEPT
iptables -I INPUT 1 -p tcp --dport 9906 -j ACCEPT

and these on each compute node:
# Allow BGP through the Fuel firewall
iptables -I INPUT 1 -p tcp --dport 179 -j ACCEPT

# Allow Calico API connections through the Fuel firewall
iptables -I INPUT 1 -p tcp --dport 9902 -j ACCEPT

This is because Fuel installs chains for INPUT that end in DENY.

Key to the fix is that the chains have been restructured. The original structure was as follows.

We used to have a felix-INPUT and felix-FORWARD chain. All INPUT packets were sent to felix-INPUT and all forwarded packets to felix-FORWARD.
There was a per-endpoint chain for both inbound and outbound for each endpoint. These DROPPED traffic which was not allowed, and permitted other traffic.
felix-INPUT and felix-FORWARD matched on the tap interface to send to the relevant per-endpoint chain.

The new structure is as follows.

felix-INPUT and felix-FORWARD are gone, replaced by a new felix-MAIN chain. All INPUT and FORWARD packets are sent to felix-MAIN.
felix-MAIN sends all packets that are from a tap+ interface (i.e. an interface starting with tap) to a new felix-FROM-ENDPOINT chain, and all packets that are to a tap+ interface to a new felix-TO-ENDPOINT chain. felix-MAIN then ends by accepting any traffic that is to or from a tap interface.
The per-endpoint chains for both inbound and outbound exist exactly as before, but have moved to the felix-TO-ENDPOINT and felix-FROM-ENDPOINT chains.
The net effect is that felix-MAIN does the following.

Traffic to a tap interface passes through felix-TO-ENDPOINT, then to the endpoint specific chain which either DROPs or RETURNs. If it RETURNs, the packet is ACCEPTed at the end of felix-MAIN.
Traffic from a tap interface passes through felix-FROM-ENDPOINT, then to the endpoint specific chain which either DROPs or RETURNs. If it RETURNs, the packet is ACCEPTed at the end of felix-MAIN.
Traffic that is both to and from a tap interface passes through both sets of chains, and if both RETURN then it is ACCEPTed at the end of felix-MAIN.
Traffic that is neither to nor from a tap interface passes through felix-MAIN without hitting any rules.

There are some simplifications we could make.

We could get rid of felix-MAIN and put the rules it holds directly into INPUT and FORWARD. This won't work (because you cannot match on outbound interface in the INPUT chain). (It's also more complex to manage, which is a major argument against it.)
We could remove a level of indirection by putting all of the rules in (say) felix-TO-ENDPOINT directly into felix-MAIN. That's not efficient since it means that packets will hit more rules than they need to (since we might match eth0 against 100 tap interfaces - best to avoid if we can).
We could have two versions of felix-MAIN, one for packets coming from INPUT and one for packets from FORWARD, and restrict the rules in the version of felix-MAIN that is used for packets from INPUT. However, that only saves us traversing at most two rules, at the cost of having to duplicate some chains, and so seems like premature optimisation.

Hence I think this is the right fix.

@plwhite I have a follow-on for your final point about two versions of felix-MAIN. What your discussion doesn't cover but might want to is that the INPUT and FORWARD chains apply to different packets. Specifically, the INPUT chain applies to packets destined for the compute host. It is entirely plausible that we may want to do a different kind of filtering here (e.g. DROP by default rather than ACCEPT by default) for this kind of traffic from tap interfaces.
Just something to consider.

That is certainly possible. As it stands, we could implement this fairly simply by having two different versions of the felix-MAIN chain. That's a relatively straightforward thing to add later if we decide to do so.

FWIW, the merging of INPUT and FORWARD logic does feel a little strange to me.

I should add: all of the other details of your fix sound excellent.

Note that in the end I split felix-MAIN into felix-INPUT and felix-FORWARD.
Fixed in PR #103


Update awssdk:auth, awssdk:core, ... to 2.17.147

Updates

software.amazon.awssdk:auth
software.amazon.awssdk:core
software.amazon.awssdk:regions

from 2.17.141 to 2.17.147.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #50.


Google Books

The CC books from google books.
The dataset isn't huge. There was already agreements to release the data, but that was a while ago.

I can take a look if no one hasn't.

Hi @blester125 wanted to ask your advice on how I should start with Google Books.
I have a feel of what I should scrape, which is the books that have full preview, but I'm not sure what the best way to iterate over. Searching with * doesn't seem to work, atleast in the web browser when also toggling full preview only

@craffel might know, or might know someone who knows

My internal contacts on Google Books was the product counsel, who likely has left (and honestly I can't remember who it was).


auth-mongoengine does not run throws ValidationError

mongoengine.errors.ValidationError
ValidationError: u'22' is not a valid ObjectId, it must be a 12-byte input of type 'str' or a 24-character hex string
is it because, flask_login is trying to load_user(user_id) where user_id is not a valid ObjectId?

from flask import Flask
from flask_mongoengine import MongoEngine
from flask_login import LoginManager, UserMixin, login_user, login_required, logout_user
app = Flask(name)
app.config['MONGODB_SETTINGS'] = {
'db': 'your_database_name',
'host': 'your_mongodb_uri'
}
db = MongoEngine(app)
login_manager = LoginManager(app)
Define your User model, which should inherit from UserMixin
class User(db.Document, UserMixin):
username = db.StringField()
password = db.StringField()
Flask-Login's user loader function
@login_manager.user_loader
def load_user(user_id):
try:
return User.objects.get(id=user_id)
except User.DoesNotExist:
return None
Sample route for logging in
@app.route('/login/<user_id>')
def login(user_id):
# Ensure that 'user_id' is a valid ObjectId
if len(user_id) != 24:
return "Invalid user_id", 400
# Load the user and log them in
user = load_user(user_id)
if user:
    login_user(user)
    return "Logged in as " + user.username
else:
    return "User not found", 404

Sample route for a protected resource
@app.route('/protected')
@login_required
def protected():
return "This is a protected resource"
Sample route for logging out
@app.route('/logout')
@login_required
def logout():
logout_user()
return "Logged out"
if name == 'main':
app.run()

I am closing this issue as we're removing support for flask-mongoengine in the next release, because that library is no longer being maintained and is incompatible with recent versions of our core dependencies (eg flask, wtforms, etc).


Hoist every single associated method as a proper top-level

Currently methods are mostly translated as fields in dependent structs.
Hositing methods out of impl blocks will be useful for:

F* when dealing with mutually recursive definitions within an impl block;
F* when we want to output an interface (we cannot just val my_instance: my_trait, this breaks associated type)

TODO when this is done:

[ ] make -i +: drop the bodies of methods, see #612, commit "feat(engine): drop only some bodies"

@W95Psp can you estimate the size of this?

That's still something we need to do.


Fixing the examples's dashboard positioning

Coverage decreased (-0.2%) to 81.248% when pulling c7dc10b82a97d422d3e99eeedd1903c3a5c9014d on mistercrunch:fix_load into ab71ee4f93abe6a2f83f367258fcc6f812640008 on airbnb:master.


Form cancel should redirect to form selection

Erroring-out of form entry took the user back to the module selection screen, whereas it should take one back to the form selection screen.
ticket

Wait,
Phillip: Was the last thing the user did before entering the form select a
case?
The correct workflow should be that cancelling a form takes you back to the
last activity you were using before the form entry started...
On Fri, May 8, 2015 at 12:25 AM, wpride<EMAIL_ADDRESS>wrote:

Merged #277 https://github.com/dimagi/commcare-odk/pull/277.
—
Reply to this email directly or view it on GitHub
https://github.com/dimagi/commcare-odk/pull/277#event-299812831.

@ctsims In the example that I tested, no cases were selected. I neglected to test escaping out of a form when a case has been selected.


how to add some commands like !help !sell ! buy

please help

someone help me to do everything with bot and i can pay

You're spamming our E-mails.
#427 #527


Change delimiter

Is there a way wherein I can use custom delimiter?
I want to use {{text}} or #text# or <>

https://github.com/Matt-Esch/string-template/issues/1


added project_downloader.bat

... for easy batch processing

I'm back from vacation, and I had a look at your pull request. It looks fine; however, I'd like to veto against adding batch files, as the codebase has so far been fully cross-platform. I'd happily recreate the behavior of project_downloader.bat in javascript or accept a PR for it, though.


Name change? Google Spreadsheets -> Google Sheets

Since Google Docs was rebranded to Google Drive and Google Spreadsheets to Google Sheets, I'm wondering if as time goes on if gspreadsheet_fdw will be harder to find as the way people query for it change.
Since the official Google python libraries are so robust, even a more general wrapper exposing more services might be in order.
Kudos on gspreadsheet_fdw,
Jeff

Thanks Jeff, fully agree with this. Perhaps gsheets_fdw?
I'll rename as soon as I get it working again.


To add Real-Time Chat Application

Project title
Real-Time Chat Application
Project Description
Real-Time Chat Application
Doc Domain

[] Solidity , Html, Css , JavaScript , Web3.js / Ether.js
[] Solidity , ReactJs /NextJs , Web3.js /Ether.js
[] Solidity , Python3 , Web3.py
[] Other , feel free to mention below

Are you contributing under any open-source program ?

@yashhibare7 please describe about tech stack and let me know whether you're a SSOC contributor or not.


Geojson coordinate system unclear (example, collection-global\ca\on\city_of_pickering-addresses-city.geojson)

Hi there,
I have a question about the coordinate reference system that is used in the geojson files that can be downloaded from
the OpenAddresses website. I will use the City of Pickering  in Onterio, Canada as an example, but this question can be applied to numerous files in the batch download.
The source JSON for the City of Pickering does not explicitly state the "srs" property. The "data" property links to the ArcGIS REST specification for the data source. The REST json shows the layer's Spatial Reference as 26917, aka NAD83 / UTM zone 17N, which has a unit of meters. However, the downloadable geojson file uses Lat/Long Decimal Degrees. See the first record for reference:
{"type":"Feature","properties":{"hash":"b5763344d75152cd","number":"1001","street":"Lytton Crt","unit":"","city":"Pickering","district":"","region":"","postcode":"","id":""},"geometry":{"type":"Point","coordinates":[-79.1281625,43.8040079]}}
I have searched the website and this repository for information about the spatial reference system that each file uses, but I have not found anything that explicitly states the CRS for each geojson. Are all files projected to the same CRS during preprocessing? How can users know which CRS each layer uses? What transformation was used to convert EPSG 26917 meters into Decimal Degrees? Please let me know!
Thanks so much for your hard work on this open source data project.

We output GeoJSON, which is WGS84 as specified in the spec: https://datatracker.ietf.org/doc/html/rfc7946#section-4


JettyServer.start() blocks due to Jetty server.join()

This is related to #273.
Using v0.8, I want to start up some background threads that depend on the web server being fully started, but the call to JettyServer.start() also blocks the main thread from initializing any web server dependencies.  The Spark micro web service framework handles this using a CountDownLatch.
In master, I see that the runtime environment will affect whether server.join() is called, but then an equivalent, public method for .join() needs to be implemented across all web server implementations.

I have a solution. I will resolve today the issue.

Can you help me with a minimum unit test?

@sl33nyc, @barrantesgerman Please try the fix. I updated the SNAPSHOT.
I will make some tests to see if I must to do the same thing for Tomcat. I know that Undertow is not affected by this behavior.

I tested all servers (jetty, tomcat, undertow and tjws). Everything is OK. I am impressed to see that the tiny TJWS makes a good job :smile:

👍

Sorry, this week I've been kind of busy but I'll try the fix

Sorry for taking so long, I've been kind of busy.
I did some tests and I think that all is well.
I would like to share the test is performed if help someone else.
https://github.com/barrantesgerman/pippo-test-server
I discovered two interesting things about Rest Assured

If you want to test using the session, you must add:

SessionFilter sessionFilter = new SessionFilter();
given().filter(sessionFilter)

If you want to test using any of the pippo-session modules, you should also add:

RestAssured.config = RestAssured.config().sessionConfig(new SessionConfig().sessionIdName("SESSIONID"));

To use CookieSessionStrategy

@barrantesgerman Thanks


vSphere CSI volume attachment issues

What happened:
randomly pods cannot be created, I am getting a volume is currently in use error on container creation when restarting pods.
this issue is critical as the production cluster I am running is now becoming more and more unstable, I use renovatebot to keep deployment images and helm charts up to date, each day I am finding randomly pods that cannot start cause of this volume attachment issue, causing downtime, please make this a priority.
Warning FailedAttachVolume 17m attachdetach-controller AttachVolume.Attach failed for volume "pvc-e1610bdf-5420-444e-99bd-a274642b66e7" : rpc error: code = Internal desc = failed to attach disk: "6b284a9a-582d-4ecc-bb94-bf49017e587a" with node: "<IP_ADDRESS>" err failed to attach cns volume: "6b284a9a-582d-4ecc-bb94-bf49017e587a" to node vm: "VirtualMachine:vm-5190 [VirtualCenterHost: vcenter.vsphere.xxx.xxx UUID: 421d6be9-800f-38ca-557d-4fa14b7895a9, Datacenter: Datacenter [Datacenter: Datacenter:datacenter-3, VirtualCenterHost: vcenter.vsphere.xxx.xxx]]". fault: "(*types.LocalizedMethodFault)(0xc000c4f8e0)({\n DynamicData: (types.DynamicData) {\n },\n Fault: (*types.ResourceInUse)(0xc000c6d140)({\n VimFault: (types.VimFault) {\n MethodFault: (types.MethodFault) {\n FaultCause: (*types.LocalizedMethodFault)(<nil>),\n FaultMessage: ([]types.LocalizableMessage) <nil>\n }\n },\n Type: (string) \"\",\n Name: (string) (len=6) \"volume\"\n }),\n LocalizedMessage: (string) (len=32) \"The resource 'volume' is in use.\"\n})\n". opId: "101159e7"
What you expected to happen:
pod restarts to work without volume attachment issues
How to reproduce it (as minimally and precisely as possible):
create a vSphere cluster, enable DRS, install deployment with a PVC that uses standard storage class, move eks worker nodes to different esxi nodes, restart pods
Anything else we need to know?:
everything was working fine till I enabled DRS in vCenter, after awhile this issue started to occur, I believe it has to do with DRS moving around the worker nodes and vSphere CSI not properly detaching/attaching CNS volumes
this is also similar to issue https://github.com/aws/eks-anywhere/issues/896
Environment:

EKS Anywhere Release: 0.11.4
EKS Distro Release: 1.23

Another thing I am noticing, the volumeattachment resource is referencing a nodeName that the CNS volume is not attached to anymore when looking in vSphere, so it seems this is not getting updated either.


Users: Do not confuse dotenv with python-dotenv

Note to users: Do not accidentally confuse this dotenv package with the python-dotenv package which is different.

I think name-spacing in python needs abit of work.


push parser shouldn't throw a NPE when it receives no input

fixes #1710

Tested against Blather, all good.

Sorry for the ping but I would like to update beyond 1.6 this side of our PCI-DSS audit.

I'm going to vote for merging this, but would like to file a bug report to get MRI implementation in line with this JRuby behavior (if possible / feasible). @jvshahid if you agree, please merge this and I can cut a release in the next few days.

merged and opened https://github.com/sparklemotion/nokogiri/issues/1758 to address the inconsistencies between MRI and JRuby


YAML module missing from image

As of the new version, the image does not have the yaml module inside of it for the Python script to run. That would likely need to be added otherwise you get errors when running the image.

Will update, thank you!


feat: Update README.md with instructions on setup and usage of Virtual Environment

Description
Virtual Environments are a great way of containerizing your code and making sure that you have a compatible development environment irrespective of whatever packages you may have on your local system. Virtual Environments in python help manage compatibility across different versions of the same package and enables faster setup via the requirements.txt file.
Proposal
Proposal is to add detailed instructions as to how one can get started with their own virtual environment. This would not just help them setup this project, but also act as a best practice for future projects.

I think it's pretty much helpful...
Go ahead, I've assigned it to you only!
GL ✌

@RAOexe have raised a PR for this issue. Kindly do review it. Thanks !

Will review it no time!
Thanks 👍


Cleaning up things =)

Just to make people happy LOL

wow this is a f**king PR!
Thank you very mush!


[GLUTEN-7496][DOCS] Add View the Surefire reports of velox test in NewToGluten.md

What changes were proposed in this pull request?
Add View the Surefire reports of velox test in NewToGluten.md
(Fixes: #7496)
How was this patch tested?
No need.

@zhouyuan would you like to review this PR? thanks


A Plague Tale

Hi, how to get files from A Plague Tale Innocence or Requiem please?

Sorry, this tool does not work on those games. The format has changed quite a bit since the games that this was made for.

Hi, thanks for your answer. I managed to find a tool, and it works kinda =)
https://github.com/amrshaheen61/APT_DPC_Tool

I recommend checking out
TotemTech Modding Resources (specifically the Tutorials)
Reverse Engineering Tools


Update Restlet to 2.4.3 for Java 11 compatibility

Fixes #15

Thanks a lot for the contribution. Just released 1.3.0 on central.

Thank you for including this so quickly.


Project Feedback!

👍 Nice work! The point of this homework was to get a chance to implement a TableView (one of the most common views in iOS) and to work with real data over the network (in this case from the Movies Database API).
A key part of these projects is that you add additional features and tweak the UI / UX because that will provide the most learning opportunities. We encourage you to complete the projects early each week with the required stories and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
We have a detailed Assignment 1 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.
Check out the assignment grading page for a breakdown of how submissions are scored.
If you have any technical questions about the project or concepts covered this week, post a question on our Discussions Forum and mark the question as type, "Curiosity". For general questions email us at<EMAIL_ADDRESS>

Looks like you did not link your gif walkthrough for this assignment or it is not rendering (animating) properly when viewed in the README 😬. The gif helps us to make sure we don't miss any required or optional stories you have completed.
Render your gif:
Once you have uploaded your gif to a site like imgur you can render it using the following syntax.

Make sure all you have completed the following steps to completing your README:

Make sure you have the correct README for this assignment, go to the "Setup" section in Assignment Tab for the corresponding week in the course portal.
Please mark of all completed stories [x]
Add a link to your animated gif walkthough to your README and make sure it renders (animates) when viewing the README.

Your assignment is incomplete until the README and gif is complete. Once completed, please push your updates and submit your assignment again so we can regrade it.
Still confused about how to properly submit your assignment? Check out the Submitting Coursework for detailed instructions.
Whenever you make updates to your project that require re-grading, you need to re-submit your project using the submit button on the associated assignment page in the course portal. This will flag your project as “updated” on our end and we know to re-grade.
You should re-submit your assignment anytime you:

Update a previously incomplete assignment
Add optional and additional features to an already completed assignment
/cc @codepathreview

Nice work! The point of this homework was to get familiar with two common forms of navigation in iOS (push and tab bar). It also provided a chance to extend your Flicks app in new ways.
We have a detailed Project 2 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. While we won't be reviewing further revisions to this unit's submission anymore, you should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.
Check out the assignment grading page for a breakdown of how submissions are scored.
If you have any technical questions about the project or concepts covered this week, post a question on our Discussions Forum and mark the question as type, "Curiosity". For general questions email us at<EMAIL_ADDRESS>/cc @codepathreview


Finalize split

Summary
On top of https://github.com/facebook/jest/pull/3376, this now finalizes the split of "InitialOptions" into "ProjectConfig" and "GlobalConfig". The only overlap between the two is rootDir, which should be alright. I have about five more PRs coming that clean up various things, but this one makes everything that is tested by Jest work. I'm sure I missed one or two things that aren't properly typed, but we have a fully week to stabilize this :)
Test plan
jest

Codecov Report

Merging #3388 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #3388      +/-   ##
==========================================
+ Coverage    64.2%   64.23%   +0.03%
==========================================
  Files         176      176
  Lines        6546     6532      -14
  Branches        4        4
==========================================
- Hits         4203     4196       -7
+ Misses       2342     2335       -7
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/index.js
26.08% <ø> (ø)
:arrow_up:

packages/jest-config/src/validConfig.js
100% <ø> (ø)
:arrow_up:

packages/jest-config/src/defaults.js
100% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/index.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/runTest.js
15.55% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/setup-jest-globals.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/runJest.js
0% <0%> (ø)
:arrow_up:

packages/jest-cli/src/reporters/SummaryReporter.js
26.15% <0%> (ø)
:arrow_up:

packages/jest-cli/src/generateEmptyCoverage.js
90% <100%> (+1.11%)
:arrow_up:

packages/jest-runtime/src/shouldInstrument.js
68.18% <100%> (ø)
:arrow_up:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c2eff...f333646. Read the comment docs.


Update secure-swarm-tls.md

Proposed changes
Fix broken link

Deploy preview for docsdocker ready!
Built with commit 7960e87cbd9b8ffa8232fcfd6063ede19725cd9a
https://deploy-preview-8706--docsdocker.netlify.com

This link is currently working as is, does it still fail for you @paulcosma?

I've checked the "Docker security" link from the bottom of this page
https://github.com/docker/docker.github.io/blob/master/swarm/secure-swarm-tls.md
This is returning 404 for me.

Oh I see. Yes, you're correct. Thanks for discovering that miss!


Clarify forking process

While running through the process, I hit a couple snags. Hopefully this is an improvement, feedback welcome.

🚨 Hey @nphilbrook, looks like there was an issue processing your fork request!   Please ensure you've committed a properly-formatted YAML (.yml) file to the requests/fork/ directory.


Auto-sort collections on initialization

This PR implements the following change:
When a Collection instance is initialized, if models are passed to the constructor and if a comparator exists on the collection, the collection's sort method is automatically called.

+1 if it's listed in the docs as "working like backbone" backbone will auto sort when initialized if there's a comparator, was about raise a bug before I saw this

@skysteve, we're planning to remove collections entirely - so adding any extra functionality now would be pointless. The documentation will have all references to backbone removed accordingly and you will be able to do JS sorting via the native Array.sort().

thanks for the quick reply :) what's the logic behind removing collections?
I've only started using bookshelf about 2-3 weeks ago having come from a backbone background and find collections rather useful. I know I can just hard code my bookshelf version and they'll continue to work, but seems a shame to remove them.

what's the logic behind removing collections?

The general consensus is that they don't add very much to Bookshelf's functionality, but do introduce a lot of needless complexity. There is a bit of discussion throughout the issue history, some in #552.

This is stale. We can refer to this if we later want to have collections automatically sort themselves on initialization.


Zabbix Data Sources integration with grafana 1.9

Hi,
Could you please help me in configuring zabbix with grafana 1.9??
How to run grafana 1.9?

@Diwahars, do you have problems with this manual http://docs.grafana.org/v1.9/installation/?

After grafana installation take this branch https://github.com/alexanderzobnin/grafana-zabbix/tree/release-1.0 and read instructions
If you have problems with zabbix let me know

@nucleusv Thanks will look into it..


Creating Expressions via Script is very slow with GUI

I have a script that creates ~170 expressions. If I run visit -s myscript.py, it will take about 10-20 minutes for all my expressions to be created.
There must be some kind of performance bottleneck in the GUI for defining expressions. This occurs whether or not the expression window is open. I can provide my script on the RZ, although it should not be difficult to create a new script that just defines a large number of expressions.

The more expressions there are already in the window, the longer it takes to create new ones via my script.

yes, our gui behavior for this is horrendously bad. I recall patching some performance issues a long while ago on a prev. release candidate.
The code managing exprs in GUI needs to be wholly overhauled.
In addition, there is a ton of speculative expression generation that compounds problems...thats when we generate an expression just in case it might be useful during a VisIt session. We need to switch this to on-demand generation and make it easy for users to generate these useful expressions only when they know they want/need them.


Update portable runner test timeout

Increases the timeout of the portable runner test for spawning up a portable runner process from 30 to 300 seconds.
Related issue https://github.com/apache/beam/issues/22115
Previously the total test timeout was 60 seconds and an attempt to make the tests less flaky was done by increasing the total timeout to 600 (see https://github.com/apache/beam/pull/12633).
However, tests were timing out on the 30 second timeout in spawning up the portable runner service.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik

R: @tvalentyn


Remove ajax

Trello
https://trello.com/c/j7tWmjbO/324-remove-ajax-from-smart-answers
Desire
Using AJAX to navigate through smart answers does not have any positive effects.

A performance test resulted in quite insignificant speed improvements
with AJAX when compared against the same without AJAX.
When we removed the AJAX from 3 specific Smart Answers,
it didn't have any impact on user behaviour at all.

Outcome
JSON rendering functions have been removed from the main smart answers controller; tests for these have been removed and in some cases refactored to test the standard html flow.
Smart answer views have be refactored into a set of partials with a smart answer specific layout file.
The updates do not affect the actual content of smart answers.

@pmanrubia I've reworded the commits and did a slightly messy rebase with master - all tests pass after i resolved the conflicts (mainly around A/B testing code). Let me know what you think.

My interpretation of this:

A performance test resulted in quite insignificant speed improvements
with AJAX when compared against the same without AJAX.
When we removed the AJAX from 3 specific Smart Answers,
it didn't have any impact on user behaviour at all.

Is that AJAX provides a small benefit? How small were those benefits?
Did we find that the AJAX ever impeded users?
(I can't see the Trello card linked to as it's private)

Hi @fofr, thank you for your feedback (I have added you to our board)
Our main reason for deleting the AJAX support is the way it is implemented. It is increasing the complexity of the codebase, which is one of the biggest issues with smart-answers, so far. Happy to follow a different approach if you have any other suggestion.

I've been doing some thinking around how we can improve the 'One thing per page' pattern, really the main impact I can see is reducing the amount of round trips a user has to go through.
For example if we cached X pages in the journey with a Service Worker etc.
This AJAX approach does not reduce the journey in that way so I think it's reasonable to make this codebase simpler and explore the above later.

CI is failing: https://ci.integration.publishing.service.gov.uk/job/smartanswers/job/remove-ajax/6/console


UADP NetworkMessage support

Great work. Very useful, but still some topics are not clear.  @randy-armstrong  as you asked I try to do my homework. Let me stress, the main purpose of the following questions is to learn how to improve (update) the description I have provided many years ago and maybe it is obsolete now.

UA Part 14: PubSub Main Technology Features.

What is the reason to use JSON encoding? Is it possible to use binary encoding instead?
What is the relationship between the metadata and the Information Model? (see also What is Information Model vs Semantic-data
Is there any relationship between the metadata, Information Model, and MQTT topic?
PubSub can use four protocols and two encodings. It yields an impressive number of incompatible combinations. How to select an appropriate one? Are there any best practice rules helping to select the appropriate combination?
Based on this example what I need to do to select a different combination of the underlying protocol/encoding?
Somones call MQTT a transport protocol. I know it is not a transport layer, but what is the difference between a transport and no transport protocol? Is IP a transport protocol for UDP for example? Is proposed by me the Transport protocol stack architecture correct?

The StarterKit is a teaching tool. JSON makes it easier to see what goes on the wire. Later versions will support binary.

The metadata includes a subset of the information model (specifically properties and their values). The WG is looking a including subsets of the address space using a JSON nodeset format.

The metadata contains properties from the information model. The MQTT topic name is the BrowseName of the Object being monitored (not required - just what the sample is doing).

Users look for products that support the TransportProfile(s) they want to use. There are exactly 2 for MQTT:
PubSub MQTT UADP
PubSub MQTT JSON

OPC UA profiles exist to reduce the number of permutations and combinations to a manageable set.

The current example only supports the 'PubSub MQTT JSON' profile. Future updates will add more.

The OSI model is not the right frame of reference. MQTT is a transport from the perspective of OPC UA and that is why the term is used. From a UA perspective any protocol that allows applications to send OPC UA messages is a "transport protocol".

Different applications have different requirements and there is no "one size fits all".
UA Binary is faster and provides end to end security but requires a UA binary parser on both ends. This is not a reasonable expectation if you are sending data to the cloud.
UA JSON is easier for non UA applications to consume but is less efficient.
OPC UA manages the complexity of multiple profiles with a layered model and a common configuration model. This makes it it easier build and maintain support for multiple transports.

@opcfoundation-org  I know why people use different protocols for ages addressing many needs, namely performance, security, robustness, round trip time, jitter, and even power consumption. For this approach, we complain that it doesn't work in a multi-vendor environment.
Now we claim that there is a standard the relaxes this problem by using a common name. Instead of different protocols, we have different profiles still not interoperable profiles. Again, it doesn't work in the multi-vendor environment. My point is that we cannot call it standardization. We cannot even call it normalization. Maybe harmonization is a good term.
I am aware that it is impossible to have just one profile. The question is how to deal with that. Just ad hoc, I have the following proposals:

limit the number of profiles
select only one that must be implemented in all products
postpone the selection of the working profile up to the run-time

BTW, from my recent research, I can derive a conclusion that JSON serialization is useless for PubSub (and in general for OPC UA) because direct interoperability based on the edge concept is not applicable to all scenarios. I proposed a solution that can be applied to any cloud (not only Azure) without any additional assumptions. To get more check out my presentation on YouTube
Object-Oriented Internet Cloud Interoperability; Presentation - executive summary on YouTube
To get more check out the full story
Object-Oriented Internet Cloud Interoperability
Removing useless JSON from the specification will limit the number of profiles significantly and it also removes some critical errors like custom JSON schema definition.
In general, try to follow the current science, but not try to be in front of the science. The specification is only a snapshot of what we have but not a guide to custom products.

@opcfoundation-org BTW From MQTT is a transport from the perspective of OPC UA i can derive the statement that OPC UA  is just one of infinitive number of user applications from the perspective of MQTT.
In this context, my next doubt is what is a reason to put a pubsub protocol (OPC UA PubSub) atop of next pubsub protocol (MQTT).

JSON is useful when the consumers of the data know have no ability to parse UA binary messages.
This is the case when data is being pushed to cloud based analytics engines or to browser based UIs.
UA binary is most useful when both sides are full UA applications.
This is the case for controller to controller communication between factory applications (which can be communicating via the Internet).


Fix conditional for Linux report templating

Default var references true as a boolean, however the template is using "true" as a string causing the condition to never be met.
https://github.com/shadowman-lab/shadowman.reports/blob/47fcf11ea6ed4a87e2093150918e21f54f2a78c3/roles/build_report_linux/defaults/main.yml#L2
Setting the condition to evaluate as a boolean instead of string.

Changing default var to be a string instead to work with AAP surveys


Add DescentMethods.CholBFGS to main

DescentMethods.CholBFGS is used by CubicEoS.jl so need to add this method to package. For now, I am restricted to use package's Manifest.toml, where DescentMethods comes from chol_bfgs branch.

I think we can assume the new functionality works based on CubicEoS.jl experience


User-reported issues don't trigger notification

Describe the bug
When a user reports an issue on a media item, no Telegram notification is sent.

The notification system for Telegram isn't hooked up to issues, issues are currently only sent to email. We're in the process of rebuilding our backend api and this is a valid enhancement but not a bug.


Scope remote_desktop_client.xml to non-main window

This is a proposed enhancement for #632
I didn't test other remote desktops apps, only Microsoft Remote Desktop.
It should not do any harm for users of other rdp clients: window name would be different.
Potentially, other REMOTEDESKTOPCONNECTION (and maybe VIRTUALMACHINE) can benefit from it with including their own Main window in Remote_Desktop_Main_Window .

I think this issue is solved by <bundleidentifieroverridedef> since Karabiner 10.18.7.
https://github.com/tekezo/Karabiner/issues/632#issuecomment-219480124
Please confirm the latest beta version.

Great!


Q: BroadcastException - Fail gracefully if no Pusher server is running?

Hi
I am using Laravel Broadcast together with a websocket server. But I got a question regarding failing gracefully in the case the pusher server ist not running.
Right now, if the websocket serve is running all is working fine. But if the server is not running, all events trigger a
Illuminate \ Broadcasting \ BroadcastException
No message
exception in vendor\laravel\framework\src\Illuminate\Broadcasting\Broadcasters\PusherBroadcaster.php.

I could try/catch all events I am firing, but as I am also listening to Eloquent events this will become complicated.
Is there a way to fail gracefully in general? It shouldn't crash everything if the server e.g. has a hiccup, or should it?
I already checked the BroadcastServiceProvider with auth:api to support my Passport bearer and am allowing all channels for all users. Still, the issue.
Thanks a lot in advance

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


Updated with best practice according to SC2086

I noticed that a couple of variables where subject to shell globbing/expansion. I rewrite some lines according to best practices which make the code compliant with ShellCheck SC2086 (Double quote to prevent globbing and word splitting).
More information can be seen here: https://github.com/koalaman/shellcheck/wiki/Sc2086

Great input. But now we cannot include this.  too old I'm afraid. (back then was readonly)
This is fixed now though.


Implementation of SAC

Since SAC is really similar to TD3, we are able to re-use most of its components. The differences are:

The actions to update the q-functions and policy are sampled using the current policy (instead of taking the mode).
There is no target policy.
The log variance of the policy depends on the state.
The policy is entropy regularized.

The current implementation does not support multi-step td-learning.

Maybe we can use the ClippedDoubleQLearning and add a parameter whether the action should be sampled from the target policy or if the mode should be taken?

Wow you're fast!

Maybe we can use the ClippedDoubleQLearning (instead of introducing a "Soft" version that is basically the same) and add a parameter whether the action should be sampled from the target policy or if the mode should be taken?

Yes, that would probably be cleaner.

I personally prefer the not to have too many arguments exposed to the user. Perhaps it's worth the duplication. I don't feel strongly one way or another. Do what you think is best for new users.

Yes, I also went with the duplication because it better separates both methods conceptually and there probably won't be many complicated refactorings that can't be applied easily to the duplicated code. I will leave a comment though as a pointer.


Change cert existance logic

Add checking commonName and subjectAltName in old certificate
if it exists. In other way we could not regenerate a new certificate
if any of these fields change.

I like the idea in this PR, but I think I'd rather associate a new ensure value to this behavior (e.g. ensure => synced).

I'm not sure  ensure => synced makes sense. This just adds a check on the name to make sure the cert has correct values, why would we want to hide this only to occur if you use ensure => synced? That's not a standard puppet pattern is it?


First chop textures are sometimes incorrect

See #156. Might just be happening for logs that lack a stripped variant

Can confirm, and it occurs for logs that have a stripped version too

Fixed in TreeChop 0.18+ versions, currently only for Minecraft 1.19.4+