ECONNRESET fetching https://sts.googleapis.com/v1/token

Is this a client library issue or a product issue?
This is a client library issue, sometime between https://github.com/googleapis/nodejs-storage/compare/v6.5.2...v6.9.5

Did someone already solve this?
I have been unable to find a previous report. This is affecting the Google GitHub action: https://github.com/google-github-actions/upload-cloud-storage/issues/320.

Do you have a support contract?
I am a Googler, but customers have reported this through their Google support contracts.

Environment details

OS: ubuntu
Node.js version: 16
npm version: (not sure, whatever exists on GitHub Actions by default)
@google-cloud/storage version: v6.9.5

Steps to reproduce

https://github.com/google-github-actions/upload-cloud-storage/issues/320

Hey @sethvargo 👋🏽
Looking at the log, it appears some uploads were successful until we got ECONNRESET. I'm not sure why V0 of the uploader works while V1/main is having some issues [diff], however I see the upload config is missing a retry strategy. By default, we retry ECONNRESET for upload if the ifGenerationMatch precondition option is set:
https://github.com/googleapis/nodejs-storage/blob/be0c410ebfa25e0590d5897fed737215c57c7cf4/src/bucket.ts#L4239-L4251
Additionally, I don't see any changes in auth (seems to be where the error is raised) and storage between the version diff that might trigger networking issues.

Hi @danielbankhead v1.0.0 works - v1.0.1 broke. That delta is much smaller, mostly consisting of dependency and documentation updates.
We can definitely add a RetryStrategy, but this worked in previous versions of the Cloud Storage SDK. Additionally the ECONNRESET is coming from the call to get an auth token, not a call to upload a file.

Deep-diving in following repos (and contacting a few colleagues) I'm not seeing anything that would cause new networking issues nor would stop prevent that error from being retried:

storage https://github.com/googleapis/nodejs-storage/compare/v6.5.2...v6.9.5 (release: Mar 30, 2023)
https://github.com/googleapis/google-auth-library-nodejs/compare/v8.5.2...v8.7.0 (release: Nov 9, 2022)
https://github.com/googleapis/gcp-metadata/compare/v5.0.1...v5.2.0 (release: Jan 3, 2023)
https://github.com/googleapis/gaxios/compare/v5.0.2...v5.1.0 (release: Mar 6, 2023)

Additionally, I'm not seeing any recent ECONNRESET issues across googleapis.
I have a few follow-ups:

How often is this happening on v1.0.1 (in terms of error rate and % of customers affected)?
Were there any outages affecting the workload(s) at the time (Github, GCP, etc.)?

We can definitely add a RetryStrategy, but this worked in previous versions of the Cloud Storage SDK. Additionally the ECONNRESET is coming from the call to get an auth token, not a call to upload a file, so I'm not sure that adding a retry strategy will actually affect this.

It would be retried because of the auth error would be propagated here and treated as a retryable error.

Additionally, I'm not seeing any recent ECONNRESET issues across googleapis.

I agree - I checked first before filing an issue 😄.

How often is this happening on v1.0.1 (in terms of error rate and % of customers affected)?

We're getting user reports on https://github.com/google-github-actions/upload-cloud-storage/issues/320. Relative to the total user base, it's very small.

Were there any outages affecting the workload(s) at the time (GitHub, GCP, etc.)?

No - the reports are over multiple days from multiple different users. There does not seem to be a common denominator.

Thanks for the additional details - I think the best path forward would be to add retry logic; not only to resolve this spike in errors, but as a best practice. I think this can be exposed as an overwrite option to upload-cloud-storage customers where:

true: set IdempotencyStrategy.RetryAlways (here's a sample) (seems like this is default behavior, and can be set as the default)
false: set a ifGenerationMatch: 0 precondition

This way, both cases are retried automatically and it's an easy, new feature for customers 🙂
Additionally, I'll work on retries directly within auth this quarter - if you'd like to review a proposal for that I can share internally once it's ready.


Is this project still being maintained?

It works well with express and socket.io in node.js as the server.

bump. I am also interested in this, although it seems it is not.

@olav35 I use websocketpp now.


chore(tonic): Use BoxBody type alias

We can use this type alias.

clippy ci is fixed in #1283.

https://github.com/hyperium/tonic/pull/1288 Should fix clippy :)


Possible licensing issue with WordPress plugin

@pmeenan  I really prefer permissive licenses and therefore laud your choice of the MIT license for the Edge-Cache WordPress plugin. However, I believe that you have to change it to the GPL, because a piece of software that relies on a GPL'ed software to run (in this case WordPress core) must be GPL licensed, too (your plugin is a derivative work of WordPress core).
I am not a lawyer, but my understanding is, that if your code would not work with any other non-GPL'ed software (e.g. as a plugin for another CMS) there is no way around the GPL.
I am really sorry that I have to point this out, but I would not want you or Cloudfare to run into any licensing problems with the WordPress project. So better check/fix it now.

Good catch, thanks.

This is not correct. This code should stay MIT-licensed.
(Disclaimer: I am not a lawyer, but I've worked with a lot of lawyers in regards to open source licenses. I work for Cloudflare, but the following should be considered my own personal opinion and not a legal opinion from Cloudflare.)
The code Cloudflare is distributing is not a derivative work of WordPress's code, and therefore there is no legal basis for WordPress's license terms to apply to this code. Cloudflare is the sole copyright owner of this code, and therefore Cloudflare can distribute it under any license it chooses. The fact that the code is designed to work with WordPress does not cause it to be a derivative work of WordPress; to be a derivative work, it has to incorporate code that is copyright by WordPress.
GPL virality applies to derivative works that incorporate GPL'd code. Usually, the derivative work is a compiled binary. If you take some GPL'd code X and some non-GPL'd code Y, and compile them into a binary, and distribute that binary, then the GPL says that you are required to also distribute the code of both X and Y under GPL-compatible terms. In this case, Cloudflare is not distributing any compiled binary and not distributing WordPress's code at all; it is only distributing its own code.
Even if Cloudflare were distributing a derivative work, there is no exclusivity requirement on the license of the code. The GPL says that people receiving the derivative work must also receive the code under GPL-compatible terms, but this does not mean the code can't also be made available to other people under other terms. The copyright holder has the right to give the same code to different people under different licenses, as well as to give the receiver the option of multiple licenses. (E.g. you often see companies offering code "dual-licensed" under GPL and some proprietary license.)
Finally, the MIT license is recognized to be a GPL-compatible license. That is, distributing code under the MIT license satisfies the GPL's requirements for code distribution. This is because the MIT license does not contain any restrictions that the GPL did not already have. So even if Cloudflare were distributing a derivative work based on combining this code with GPL'd code, distributing this code under MIT license only (not even dual MIT/GPL) would in fact be sufficient to satisfy the terms of the GPL.
We should definitely keep this code MIT-licensed as changing it to GPL may discourage people from building on this example.

WordPress themselves appear to feel pretty strongly that plugins need to inherit the GPL license (I checked before updating). I'm happy to switch it back if lawyers give it a green light but going by the WordPRess docs it doesn't look like it is optional.

Wow that's... quite an extreme opinion.
I think they are asserting that the code will be relicensed upon distribution in plugin form -- essentially the WordPress plugin equivalent of a "compiled binary". That's still a stretch but I can see that argument. But that would not prohibit the author from distributing the original source files under MIT as well.
If you're happy making the code GPL, though, then there's no issue here...

@kentonv I would be happy, if you were right. But I think @pmeenan chose the safer option.
Before I posted, I read what the Software Freedom Law Center is said to have answered conc. WordPress themes and I feel that this would apply also to this plugin. I know: If you ask 3 different lawyers you get at least as many different opinions... therefore, I will not participate in any further discussion on this.

Yikes, this argument seems to be saying that writing code against an API makes your code a derivative work of that API, that an API can be covered by copyright, and that use of an API is not covered under "fair use". That's an extremely scary position to take. :(
I was not familiar with WordPress's assertions here when I wrote the comment above -- I was speaking generally. Given WordPress's assertions then I guess it makes sense not to rock the boat.


Github Actions

Let's set up some basic Github Actions!

Greetings action as added. Not sure how to implement Deno testing yet but would like deno to run like deno fetch mod.ts to make sure it can run properly i assume. Perhaps even deno fmt, deno lint etc...

This is done nicely. Deno cache is already working and #26 added in deno fmt --check as well


[Feature suggestion] Make remote screen shortcuts configureable (same way as side menu)

Just wrote a "+1 comment" regarding adding a favorites shortcut to the side menu and noted that I would love a remote screen shortcut too, except there's no space for it.
That's fine and I really like the clean style of Kore, but on the other hand, why not make the remote screen shortcut buttons configurable just as the side menu items are? That way users could configure them based on personal preference, replacing default buttons with for example PVR or Weather.

Closing this as I believe #355 fixes this.


docker: use ubuntu:noble

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e7cf53bad96e25edd394e175814a7ade213392e0
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Ability to lock the editing of a picker

It would be great to be able to Lock the editing of a picker , for instance, you wouldn't want to have a team accidentally override a ui, what i would imagine, is that a team would use a command to run the "viewer" or the "editor".
The viewer is merely the main UI (file load), with no other options to edit any of the buttons.
something like this :
Editor :
import dwpicker
dwpicker.show(edit=True)
And for the viewer :
import dwpicker
dwpicker.show(editor=False, "paths to picker A", "path to picker B", "path to picker C", "etc")
This way, an entire team will be able to open pre made pickers, without accidentally override them.

I Buy this too

Hi, this is now implemented in the latest commit !
pickers = [ "paths to picker A", "path to picker B", "path to picker C"]
dwpicker.show(editable=False, pickers=pickers, ignore_scene_pickers=True)

editable: bool, if false it is not possible to edit the opened pickers
pickers: pre open some pickers
ignore_scene_pickers: if the scene contains picker data, this will ignore them but preserve the data of edition.
Sorry for the delay, as this was a request, it is not prio but i'm trying to keep going and do not forget them :).

You are awesome, thank you for the update.


Duplicated string in code TouchImageView.java

    @Override
    public boolean onTouch(View v, MotionEvent event) {
        if (getDrawable() == null) {
            setState(State.NONE);
            return false;
        }
        mScaleDetector.onTouchEvent(event);
        mScaleDetector.onTouchEvent(event);    //!!!!!!!!!!   Duplicate. As a result - Unexpected scroll behavior
        mGestureDetector.onTouchEvent(event)

Thank you for the report https://github.com/hannesa2/TouchImageView/pull/13

https://github.com/hannesa2/TouchImageView/releases/tag/2.1.1 This is a AndroidX version or do you need a supportLib one ?

https://github.com/hannesa2/TouchImageView/releases/tag/2.1.1 This is a AndroidX version or do you need a supportLib one ?

Just TouchImageView.java file in my project.
Thank You


returns keyword is not suggested when there is a defaultable parameter

Description:
$title.

Steps to reproduce:
public function bar(int i, public float f = 1.0) re {
}

Affected Versions:
$ ballerina -v
Ballerina 1.0.0-rc1-SNAPSHOT
Language specification 2019R3

Closing since the fix has been merged


Provide a more helpful error for http vs https "Getting Error path: undefined when trying to migrate from v3 to the experimental"

Hello,
I am having trouble even getting this to spin up. I've installed the plugin, included it in the gatsby-node file:
  resolve: 'gatsby-source-wordpress-experimental',
  options: { url: config.graphlWPUrl }

And as soon as I run gatsby develop, I get this error:
 ERROR

 gatsby-source-wordpress  (undefined)
         GraphQL Request must include at least one of those two parameters: "query" or "queryId"

 Error path: undefined

 If you haven't already, try adding define( 'GRAPHQL_DEBUG', true ); to your wp-config.php for more detailed error messages.

 ERROR

 gatsby-source-wordpress  Encountered errors. See above for details.

not finished createSchemaCustomization - 0.909s

The URL provided to the plugin does return the following response:
"message": "GraphQL Request must include at least one of those two parameters: \"query\" or \"queryId\"",
But, according to the WPGraphQL documentation, this is to be expected.
Can anyone please point out what I'm doing wrong?

Hi @bogdancss , thanks for opening this issue. It's hard to tell from your description what the problem could be. Can you share your /graphql endpoint with me? My email is<EMAIL_ADDRESS>Additionally a reproduction repo would be helpful here.
Thank you!

Hey @TylerBarnes  -  I've sent earlier today.
I have simply spun up the starter provided in the examples (gatsby new wordpress-gatsby https://github.com/TylerBarnes/using-gatsby-source-wordpress-experimental) and replaced the url in gatsby-node with our Wordpress graphql one.

Hi, thanks for sending that over! I just had a look and the reason is that you've added an http url but your server is hosted on https. Once you change that url to http://yoursite.com/graphql it will get a little further. It appears you have a firewall which is preventing GraphQL requests. You'll need to whitelist the /graphql endpoint (or your IP) to allow sourcing from your site. It looks like a few requests get through and then your server blocks the rest.

I'll see what I can do about providing a more helpful error message around http vs https 🤔 . Thanks for bringing this to my attention!

This was implemented previously - this plugin will warn if the origin WP server url uses a different protocol than you've entered in the plugin settings


Navbar collapsed property binding

A very minor issue, but I noticed when updating my webapp to the 1.0.0-beta.2, that the upgrade actually broke my (very simple) manual approach to navbar collapse (likely due to the now built in method).
For example, this code works in beta.1 to collapse the navbar, but does not work in beta.2 (it seems the navbar's collapsed property isn't listening to changes or something?)
template
{{#bs-navbar collapsed=collapseValue as |navbar|}}
    {{#navbar.content}}
        {{#navbar.nav as |nav|}}
            {{#nav.item}}{{#nav.link-to "dashboard" collapseNavbar=false}}Dashboard{{/nav.link-to}}{{/nav.item}}
        {{/navbar.nav}}
    {{/navbar.content}}
{{/bs-navbar}}

controller
collapseValue: true, // Start navbar as collapsed
route
actions: {
    willTransition() {
        // Collapse navbar on every transition
        this.controllerFor('application').set('collapseValue', true);
        return true; // Bubble
    }
}

While I don't need to bind the collapsed property of the navbar anymore, I do believe it's broken, and someone else out there might need it to work

I updated the navbar example with a check box controlling the collapsed state: http://www.ember-bootstrap.com/#/components/navbars
The collapsed property was private before, and there was not care taken to make it one-way only. Now it is, so when the navbar is expanding, you will not see this in your collapseValue, unless you listen for the onCollapse(d) / onExpand(ed) actions, where you can update that value. So when you are setting collapseValue to true, but it was still true (because not being updated), it might not trigger the collapsing.
I am closing this, as as I said the collapsed property is only public as of beta.2, and using its current API things should work as in the example...

Oops, didn't realise it was private before! My bad, thanks for clearing that up.


Crash on server start

Hello,
My server has Neruina installed, and started perfectly well at first, but after a few reboots and hours of gameplay, the server started crashing on startup, with the attached stacktrace.
Game version is 1.19.2, Neruina is 1.1.0, Java is 17 running Fabric 0.14.22, removing Neruina fixes the issue.
I did not find any similar issues on the repo
crash_log.txt

Remove Erroring Entity Remover, they're incompatible with Neruina, more precisely EER is redundant as it's functionality is already included in Neruina. I'll update the mod dependencies to clearly state that the incompatibility.


#1 Update dependencies

[x] Dependencies updated
[x] Styleguidist tested
[x] Fixed styleguidist errors
[x] Checked if breaking changes could affect application

Closes #1

Hi @mikebarkmin yarn isn't running properly at Circle CI. Is there anything I can do about it?

@eliamartani thank you very much for your pull request. Everything works as excepted. The CI failure has nothing to do with your pull request.
I have tests it locally and everything has work great. So I will merge it and fix the CI later.
Thanks :sparkles:


Remove rake requirement from gemspec

As discussed in issue #12.

can you please @RandieM merge the current master to your PR again? Switch to CircleCI is now done, so that I can see that with your changes all tests will still work properly, thanks!

Done!

thx, hope will work when merged because the CI was disabled for forked branches, from the next one should be triggered correctly

changes are now present in the published v1.0.4 of the gem

https://rubygems.org/gems/qr-bills/versions/1.0.4


Fix Package.swift to allow import NewRelic to multiple targets

Fixes issue #20

the main branch And 7.4.5 contain these changes, please use latest 7.4.5 instead.


Fix OSError if gtfs_path is URL

Encountered the following problem with URL https://www.transportforireland.ie/transitData/Data/GTFS_All.zip which is now getting considered in the exception handling of the get_files function:
OSError: [Errno 22] Invalid argument: 'https://www.transportforireland.ie/transitData/Data/GTFS_All.zip'

hey @pichlerpa thanks for contributing. I saw this pull request had some conflicts with the latest version so I took your changes and included them in the last update. I hope that's ok.
I'll close this PR for now. Thanks again for contributing.


can't access motif search

https://curation.pombase.org/cgi-bin/sanger_motif_search

This probably happened with the move to the virtual server?

I forgot to copy it over to oliver1.  It's fixed now although the image at the top is missing.  I fix that before closing.

the image at the top is missing.

I've fixed that.


Change "Getting started" example to fit restrictions of VS Code plugin

The systemticks.c4-dsl-extension for VS Code has important features
like in-editor previews but disallows some valid DSL. This commit caters
to the lowest common denominator in the interest of smoothing adaption.

Thanks for this. Have you raised an issue on the extension itself? I think I'd prefer this was fixed at source, rather than patching over the underlying issue.

Hi! No, I haven't contacted them yet. I agree that the issue should be fixed at the root, but they are aware of the problems and have this to say in their documentation:

Divergences
The goal is, that the Xtext grammar (used in this extension) is compliant to the origin language reference.
However the Xtext grammar is a bit more strict in some points:

Double quote characters ("...") are mandatory, even when a property does not contain whitespaces
You can't use keywords like person or container as variable names

I hope that they will find a fix for this in the longer run, but right now, I can live with some capriciousness on part of the extension if it means that I get a working close-to-real-time preview function.

if people are using the extension, I imagine they would look there for examples anyway.

Maybe they will.  I know it never occurred to me, because I was perusing your sites and found the following:

https://github.com/structurizr/cli -> https://github.com/structurizr/cli/blob/master/docs/getting-started.md
https://structurizr.org/#code -> https://github.com/structurizr/dsl#tooling-support -> VS Code extension - syntax highlighting and PlantUML previews

So, following instructions on your sites, I got an editor with red squigglies.  That's what I am trying to fix for my colleagues and others who might follow a similar path.
I absolutely plan to open tickets and one day PRs with the plugin, but I don't see it as an either-or.
As for your comment on removing double-quotes, yes, I saw the irony too.  They have built a grammar that's too strict, and whether that is fixable without swapping out the grammar engine remains to be seen.  In the meanwhile, having examples that work with the admittedly slightly broken plugin that you link to can't be such a bad idea, can it?


Sync/release41

PR with the correct branch that should have been merged here: https://github.com/tv2/tv-automation-state-timeline-resolver/pull/24
This one contains all the Viz changes

Codecov Report

Merging #26 (2178551) into develop (e46b6cf) will increase coverage by 69.83%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           develop       #26       +/-   ##
=============================================
+ Coverage    30.16%   100.00%   +69.83%
=============================================
  Files           51        19       -32
  Lines         8036       519     -7517
  Branches      2028        50     -1978
=============================================
- Hits          2424       519     -1905
+ Misses        5112         0     -5112
+ Partials       500         0      -500

Impacted Files
Coverage Δ

packages/timeline-state-resolver-types/src/obs.ts
100.00% <ø> (ø)

...ckages/timeline-state-resolver-types/src/device.ts
100.00% <100.00%> (ø)

packages/timeline-state-resolver/src/conductor.ts

...es/timeline-state-resolver/src/devices/abstract.ts

...ages/timeline-state-resolver/src/devices/device.ts

...line-state-resolver/src/devices/deviceContainer.ts

...es/timeline-state-resolver/src/devices/httpSend.ts

...timeline-state-resolver/src/devices/httpWatcher.ts

...ackages/timeline-state-resolver/src/devices/osc.ts

...ges/timeline-state-resolver/src/devices/shotoku.ts

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46b6cf...2178551. Read the comment docs.


[Bug]: File picker does not show content (data) of files with size of 5MB or above

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When working with the file-picker widget if you select a file bigger than 5MB it doesn't show its content instead it shows something like blob:sfsafdas....?type=Binaray. If the size of one file is bigger than the frontend limits, we need to show an error to the user instead of providing a file with some false content.
Also with file-picker, we have a property for Max File Size that can be up to 100MB , if there is a file limit like 5MB in the frontend, we need to change the Max File Size maximum value for better UX.
Steps To Reproduce

Use the File Picker button to select a file bigger than 5 or 20 MB
You can access the file data, but the content is incorrect and it is something like this blob:361ee7b1-93e9-43e4-b120-7c264019a0f3?type=Binary

Environment
Production
Version
Cloud

@mojtab23 actually the content isn't false. That is the blob location of the file since we store it in memory. Is there another solution to this?

Oh right @Nikhil-Nandagopal, how I can use this location to access the file content? Is there any documentation for that?

@mojtab23 I believe appsmith does that for you automatically when the API call is triggered. @hetunandu am I right here?

@mojtab23 @Nikhil-Nandagopal that is correct. The blob is resolved automatically when uploading/downloading it

@mojtab23 @Nikhil-Nandagopal that is correct. The blob is resolved automatically when uploading/downloading it

Can you help me in case we selected a large file (50MB) with a file picker button how we can send it (upload it) with for example S3 plugin? When I try to send file data it just sends the blob location to the server, not the actual file content.

@mojtab23 can you reach out to me on slack? I can guide you, If this is happening then you have to change the s3 query to text/binary and back to base64 again and try running the query.

Hello,
We are using content of data to hit a python API and hence cant access the data, is there a way in current state I can get the data of the file for my use case

@shubhransh-locale you can achieve this by binding the filepicker1.files[0].data property

@Nikhil-Nandagopal Thank you for the update.


App crashing when trying to login with Twitter on Android

I have an action in my Redux authentication module. I try to get the access token but app crashes. I'm sure I'm doing something wrong on my end but not sure what. Here is my code...
import OAuthManager from 'react-native-oauth';

export function handleAuthWithFirebase () {

    return function (dispatch, getState) {

    dispatch(authenticating())

    const manager = new OAuthManager('Nimbus')

    const config =  {
        twitter: {
    	    consumer_key: 'MY-CONSUMER-KEY',
            consumer_secret: 'MY-CONSUMER-SECRET'
  	},
    }

    manager.configure(config);

    manager.authorize('twitter', {scopes: 'profile email'})
        .then(resp => {
            	              firebaseAuth.signInWithCustomToken(resp.response.credentials.access_token).catch(error => {
    // Handle Errors here.
    var errorCode = error.code;
    var errorMessage = error.message;
    // ...
    });
})
    .catch(err => console.log('There was an error'));
    }
}

I have the same issue.
Code:
const config = {
  twitter: {
    consumer_key: 'abcd1234',
    consumer_secret: 'efgh5678'
  }
};
const manager = new OAuthManager('MyAwesomeApp');
manager.configure(config);

class MyComponent extends React.Component {
  constructor() {
    super()
  }
  auth = () => {
    manager.authorize('twitter')
      .then(res => {
        console.log(res);
      }).catch(err => {
        console.log(err);
      });
  }
  render() {
    return (
      <View style={styles.container}>
        <Button
          title='Twitter Auth'
          onPress={this.auth}
        />
      </View>
    );
  }
}

@MaxwellGover Did you resolve it? I see that you try to get access token with access_token key. Try accessToken instead since this is the key in the response on Android (it's access_token on iOS).
I assume that you have fake keys on purpose:
twitter: {
    	    consumer_key: 'MY-CONSUMER-KEY',
            consumer_secret: 'MY-CONSUMER-SECRET'
  	}

experience the same thing with @shanewignall


Option to have debugge's output's terminal auto closed on TermClose

On nvim-dap-ui .close(), every dap-ui thing gets closed except for the debugee's output's terminal (I'm using terminalKind = 'integrated' on vscode's bashdb wrapper configured for nvim-dap).

I wished to have a nvim-dap-ui option for auto closing this dangling terminal on its TermClose.
Context: https://github.com/neovim/neovim/issues/14986#issuecomment-902705190

An alternative (possibly tied to nvim-dap instead of the dap-ui?), is to have the debugge's terminals titled to be more distinguishable, so that I could put up an autocmd myself:
autocmd TermClose term://*dap-ui execute 'bdelete! ' . expand('<abuf>')

At the moment the terminal names are generic.

This problem is unrelated to nvim-dap-ui as the integrated terminals are completely handled by nvim-dap. There is no control of them from nvim-dap-ui unfortunately. You'll have to raise an issue in the nvim-dap repo

Thanks. Done.


chore(deps): update terraform terraform-ibm-modules/secrets-manager/ibm to v1.19.6

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.19.4 -> 1.19.6

Release Notes

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.19.6
Compare Source
Bug Fixes

deps: DA updates:- locked ibm provider version to 1.73.08 updated KMS module version to 4.18.1 (#257) (51b861f)

v1.19.5
Compare Source
Bug Fixes

updated the region selector in the DA to only show Secrets Manager supported regions (#251) (b43e33b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline


Fingerprint: Updated Lexus_RX Ecu.engine

Fingerprint
Description [Added Ecu.engine, 0x700 fingerprint for Lexus_RX ]
Verification [After adding the fingerprint openpilot no longer displays "Dashcam Mode Car Unrecognized" on my 2018 Lexus Rx350 ]

+rep

What's your dongle id?

Sorry I didn't realize that it was required. My dongle_id = cec359d176016f40
On Mon, Mar 1, 2021 at 5:48 AM Willem Melching<EMAIL_ADDRESS>wrote:

What's your dongle id?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/commaai/openpilot/pull/20198#issuecomment-787961265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATA22F2B55S4NS2OGYMWYVLTBOLKBANCNFSM4YLL53VA
.


Events Receivers - don't stay connected

Running on Windows.

Start the registry
Use Riedel NMOS Explorer 1.5.5 to monitor the nodes and other objects
Start the nmos-node sample program
For the data sender, use nmos explorer to turn the sender on. Should turn green
In nmos explorer, drag data sender to data receiver. Receiver should turn green.
Put breakpoint in make_node_implementation_events_ws_message_handler where the temperature event is being handled. About line 338.
When the breakpoint is hit, wait a few seconds until the nodes disappear from the nmos explorer.
Remove the breakpoint
Hit continue

When the nodes come back, the data sender is green, but the data receiver is not. (usually) For the video sender/receiver pair, the video receiver usually comes back green.
Is there something missing for the data receivers that the connection info is not maintained as it is with the video sender/receiver pair?

I suspect this is a known spec, or QoI issue for connection-oriented protocols with IS-05, as opposed to connection-less ones like RTP. Basically the spec says that it's up to the implementation how many times to retry when a connection breaks before signalling that it's broken via master_enable / subscription.active.
The relevant passage of the IS-05 spec is here:
https://github.com/AMWA-TV/nmos-device-connection-management/blob/v1.1.x/docs/4.0. Behaviour.md#connection-status
On the implementation side see here:
https://github.com/sony/nmos-cpp/blob/8b8b269ff9e5d33d8e1b27ec2dec82e84f813b11/Development/nmos/connection_events_activation.cpp#L134-L138
Opinions/contributions on improvements to how this is handled are welcome!

Many of the embedded systems I have worked on have clients retry forever to reestablish a connection to their server. An error message can be logged but the device is not going anywhere and just continually tries to reconnect. We typically try once a second. The devices might have at most a dozen or so connections.
This might not be appropriate in all cases but it seems like it should be a possibility.

Agreed.
Retry probably ought to be configured with similar min/max/backoff-factor properties as DNS-SD (plus whether to ever give up completely).
I heard another data point of IS-07 panels with upwards of 500 Senders/Receivers.

The IS-07 events will add a lot more connections. (would MQTT reduce this?)
Our worst case would probably be a single physical device with about 100 signals where each signal has one audio receiver, 4 event senders, and 5 event receivers.  I am not sure that all would be exposed via NMOS at the same time but they could be.

(would MQTT reduce this?)

It depends on connection patterns.
IS-07 recommends a WebSocket server endpoint per Device or per Node rather than per Sender, which means that making a lot of connections from one Node's IS-07 Receivers to another Node's IS-07 Senders can be achieved with a single WebSocket connection.
If a Node has Receivers which are to be connected to Senders of many different Nodes, then MQTT would result in fewer connections overall.


SNOW-1528937: Pytest Breaks When Using Multiple Filter Clauses

Please answer these questions before submitting your issue. Thanks!

What version of Python are you using?
3.11

What are the Snowpark Python and pandas versions in the environment?
pandas==1.4.3
snowflake-snowpark-python==1.14.0

What did you do?
When filtering using session.table, if multiple filters or when clauses are applied to the same table the unit test fails with the response "'IndexError: single positional indexer is out-of-bounds'"

What did you expect to see?
Unit tests passing

can you share a minimal repro

Hello @jordan-herbert1 ,
Thanks for raising the issue, could you share the code snippet to reproduce the issue.
Regards,
Sujan

Hello @jordan-herbert1 ,
Could you share the code snippet to reproduce the issue.
Regards,
Sujan

Hello @jordan-herbert1 ,
Closing the issue, please reopen when you have the code snippet.
Regards,
Sujan


Lock blocks queue while node is free

Hi,
Example for incorrect behavior
Lockable_job_1 is running with LOCK_A on node 120.
Starting Lockable_job_2 with LOCK_A on node 110, but getting locked by LOCK_A, so it remains in the waiting queue, which is the correct behavior.
Starting Lockable_job_3 with LOCK_B on node 110, but it gets locked by Lockable_job_B in the queue, while node 110 is free.
I think the plugin should not block the entire queue.

Yes, you can build deadlocks by unfortunate combinations between lockable resources and nodes where a job is able to run. This is not a bug. If you need finer control over your critical sections, use pipeline jobs.


AttributeError: module 'tensorflow' has no attribute 'layers'

Hi there,
The source code of tutorial

https://www.tensorflow.org/tutorials/layers
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/layers/cnn_mnist.py

cannot run on my MacAir.
It just reported: AttributeError: module 'tensorflow' has no attribute 'layers'
Is that a version problem?

Can you please post the output of python -c 'import tensorflow as tf; print(tf.__version__)'
Layers was only recently introduced out of contrib. Please post output of above and we can go from there.

Hello,
I am using Mac OS. Currently I have tensorflow 0.12 running on my laptop. Can you help me how to upgrade tensorflow to latest version, which has attribute 'layers' in it.


Please correct npm maintainers configuration.

ioBroker adapter checker for npm access
Access right check for adapter ecoflow returned the following issue:
Bluefox was not found in the collaborators on NPM!.
Please execute in adapter directory: "npm owner add bluefox iobroker.ecoflow"
Current maintainers are
realnewan<EMAIL_ADDRESS>Please fix the above error as soon as possible.
All adapters listed at ioBroker repositories must have 'bluefox' added as maintainer.
Future version updates at the repositories will be suspended until this problem is fixed.

@GermanBluefox  @mcm1957 User already has a pending invite

@newan
Please check invite. Maybe its timed-out.
At least @GermanBluefox has not yet accepted the invite
C:\Users\Martin>npm owner list iobroker.ecoflow
realnewan<EMAIL_ADDRESS>

@Newan
Please check invite. Maybe its timed-out.
And/or create a new one please.
At least @GermanBluefox has not yet accepted the invite
until now.
C:\Users\Martin>npm owner list iobroker.ecoflow
realnewan<EMAIL_ADDRESS>

npm owner add bluefox iobroker.ecoflow

npm notice INFO: User bluefox invited to package iobroker.ecoflow successfully.

bluefox (iobroker.ecoflow)

@mcm1957 I added it multiple times


Feature Request - TTL / auto deletions and reloading

Hi,
Thinking of 3 scenario's which could benefit from a Time to live type solution. Apologies in advance is terminology isn't correct but hopefully you get the intent.
Scenario 1: Something as simple as needing Noria to delete out anything not accessed in last x (configurable) days.
Scenario 2: Bit smarter, and when Noria reaches x% of resources e.g. has 5% or 1Gb free Memory remaining, starting deleting out old un-accessed data e.g. delete chunks of 100 (configurable) records at a time. Simply trying to ensure Noria doesnt run out of resources that would result in performance penalties as it creates/swaps between maps etc.
Scenario 3: Bit harder to explain. Follow the sun type load/drop/load solution. E.g. e-Commerce platform operating in multiple countries around the world. At midnight when Country A sleeping/low load drop data in Noria, and pre-load with new data from another Country B that is about to come online. I have seen discussions about loading from DB directly (Noria's RocksDB) as well as syncing data from another DB to Norias RocksDB or reading from other DB directly. Trick is, how to identify and re-load any newly listed products for sale during the e.g. 12 hours from Country A which we would want in Noria followed by the data dumped from Country A the day before in a most recently accessed first in priority, should Noria run out of resources (memory) then the oldest accessed data gets loaded last or not at all if memory is all consumed.
But to extend this scenario further, it is more realistic that several countries are online at once. So I am really wanting a way to configure each country or a generic single time (e.g. midnight for that country) data should be dropped and not a TTL of e.g. 18 hours for last accessed. I.e. User can add a new product for sale at 9pm so wouldn't want that to hang around for 18 hours in Noria when that country is asleep from midnight / 3 hours from when created. So as a guess, that would mean some way of tagging a product as being from country X, Y or Z (or 'worldwide' tag if its a global available or popular product that never gets deleted) and a backend scheduler job looking at config for IF and when to drop the data and a time as to when to reload it back the next day.

I agree that would be neat! Noria's current eviction model is simply to evict randomly from the largest views when memory approaches some threshold, but in a more production-oriented setting you'd want some more smarts like the above.
Now, implementing a TTL specifically is a little tricky since you'd need something to regularly check all the TTLs for all the entries in all the views, but in theory it's doable. I'm no longer actively working on Noria now that I've graduated, but maybe someone will pick this up and implement it :)


Default to rendered request URL when name is not present

Closes #1505
This PR implements the ability to use a Request's URL as its sidebar "name" in lieu of a defined value.
When creating a new request the initial value remains "My Request", but the placeholder is now "Your request URL":

Similarly, the Request settings displays the current URL (when available) as the placeholder:

The name in the sidebar automatically updates as you change the URL in the Request pane:

It supports environment variables:

And template tags (within reason)...
A Prompt template tag does not have a value until request time, so it yields nothing:

Dynamically generated string template tags, such as Hashes, Timestamps, and UUIDs, render once and don't change (so a timestamp, for example, may not accurately represent the request's name):

And finally, if there's an error with a template tag or environment variable we fall back to the raw, un-rendered URL:

This could probably use some tests, but I can't seem to find any integration or component-level tests (maybe I'm just blind) - if you have suggestions for testing I'll be happy to add them.

@gschier updated to reflect your feedback. Notably:
A truly empty request name now displays an "Empty" label, which looks slightly visually different than a valid name/URL value:

And, the New Request modal now has a helper label next to "Name" that indicates the default will be your request URL (cc @develohpanda):


intercepts all requests and log it

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


WIP: metamask - changes - dApp support (Trust, Metamask...)

live: https://pr3552.swaponline.site/
Checklist

[x] I have read the CONTRIBUTING guide
[x] Good naming, keep simple
[x] Tested desktop/mobile
[x] Tested bright/dark
[x] Tested en/ru
[x] Affects money; I checked the functionality once again
[x] I checked the PR once again

Original issue

Video / screenshot proof

https://github.com/swaponline/MultiCurrencyWallet/issues/3543

[ ] не показывает окно "переключите сеть" (поменял в метамаске на кован, мейннет и ринкеби, везде переподключился норм и баланс подхватил)

[ ] check liuality interoperability https://github.com/liquality/wallet/commit/afb68bc70a995253c8ae38611c9bdc1431f9d59e ,  @monokh can you review it ?

[ ] нажал deposit и выбрал эфир перескочило на https://swaponline.github.io/#/eth/Not connected/receive  и там ероры

It seemed to work from what I tried. We conform to the ethereum API so as long as it works with metamask, users shouldn't have an issue with liquality wallet.
Also consider that the Liquality wallet also provides bitcoin injection (window.bitcoin)
It has the core functions to function for any bitcoin application: getAddresses, signMessage, sendTransaction, signPSBT ...
The swap UI here can swap using the liquality wallet on both sides of the atomic swap
This example also demonstrates the core functionality.

Just realised signPSBT is not available in prod yet, so some parts of the examples will not work until the next release


List loaded plugins in banner

Is your feature request related to a problem? Please describe.
When you download a plugin from the release folder and copy the files into the folder of the wacs executable you can't see right after startup if the loading of the plugin succeeded or not.
Describe the solution you'd like
Right after startup a banner is shown above the menu (the method in code is called ShowBanner(). It would be great if here the dynamically loaded plugins would be listed as a comma separated list. Maybe grouped by the kind of plugin (Store, Target, etc.)
Describe alternatives you've considered
Step through the various options and try to configure and run the plugin to see if it is there or not.

Good idea!


Trivia: Fix misleading category description embed

The current formatting for the .quiz help command is misleading, where the spaces causes the wrong categories descriptions to be matched.

I experimented with that format but decided on this one because that way makes the list quite spaced out. This way is easier to scan from top to bottom.
I can definitely change it if there's a very good reason you see why putting it on the same line is better.

The other two formats, for reference:

I like the second one more

I have made it follow the more concise format (second screenshot) as per request from @Xithrius.

Diff of the force-pushed changes.
diff --git a/bot/exts/fun/trivia_quiz.py b/bot/exts/fun/trivia_quiz.py
index 6041d031..d624e0fe 100644
--- a/bot/exts/fun/trivia_quiz.py
+++ b/bot/exts/fun/trivia_quiz.py
@@ -625,7 +625,7 @@ class TriviaQuiz(commands.Cog):

         for cat, description in self.categories.items():
             embed.description += (
-                f"- **{cat.capitalize()}**\n{description.capitalize()}\n\n"
+                f"- **{cat.capitalize()}**: {description.capitalize()}\n"
             )

         return embed


How to change helper text while dragging

In the attached image, the helper text has the same text as node title ("One more"), how can I change the helper text displayed while dragging?, for example, display the parent title of dragged node ("Child 2").
jstree

Sorry, you can't and for the time being I do not plan on adding such an option.
If you want to you can manually hook to the DOM object of the helper and change the html / text. Listen for the drag start event and change the text inside the handler:
http://www.jstree.com/api/#/?q=vakata&f=dnd_start.vakata
Best regards,
Ivan


Make some docs on how every piece of the code works

It would be great if every piece of this code was documented, so that it would open the path for the jailbreakers to come.

true

Or once the ETA is out.

I would also love to see more documentation! I do firmly believe the more things are detailed, the more it'll help others become jailbreak exploit researchers and developers.

@haidev12 he won't have the iphone 5s and the iphone 6 to test on until this weekend.

@RypeDub420 yea instead of putting song lyrics in the code, he could put documentation. jk @xpwn

the code is very complicated and would take a long time to document for the few people who could understand it.

@meyer9 if 2 or 3 people get it, then it would already sufficient for the effort, if you are not capable of understanding an exploit, even with a documentation don't go judging others like that, for there are a lot of people interested in learning.

@meyer9 out of topic, but are you working to add support to the 6 and 5s or will you just wait until luca releases it?

@meyer9 Even commenting lines of code here and there with what it does would still help a lot of people.
It doesn't matter who would understand or who wouldn't, it only matters that the most amount of details were documented as much as possible.
Anyone can always learn, so if today no one understood, perhaps tomorrow someone could understand.
I know I'm hoping for that.

I'll definitely be working more on the iP6 support, but Luca might beat me to it

https://github.com/kpwn/iOSRE

#131

@bobbysn0w commenting the code is far more accessible than creating a website that users have to go to...

Agreed! I took a look at the code as I am interested more in creating a jailbreak than anything but really couldn't tell much of what was going on.

here's some good docs for you:
pagetables are now not real anymore, they're real af


Double clicking on touch browsers creates multiple nodes and difficulties in editing or finalising polygon due to "Shape edges cannot cross" error

[x] I'm reporting a bug, not asking for help
[x] I've looked at the documentation to make sure the behaviour is documented and expected
[x] I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

Leaflet version I'm using:
1.0.3
Leaflet Draw version I'm using:
0.49+
Browser (with version) I'm using:
Chrome  57.0.2987.133 (64-bit)
OS/Platform (with version) I'm using:
Mac OSX

How to reproduce
In the main example, using a touch enabled browser (Chrome) and a desktop computer, start drawing a polygon.
Double clicking on a point does not close the polygon (like it does in Firefox). Instead it zooms in and moves the map giving the user difficulty in continuing the polygon creation. If the mouse is moved by mistake when double clicking, new vertexes are created and the user easily gets to the situation where he has multiple vertices on top of one another and is not able to continue the polygon because of the "Shape edges cannot cross" error.
What behaviour I'm expecting and which behaviour I'm seeing
A new node should not be added unless there is a minimal distance between the last node and the new one (the mouse is out of the square marking the last node). If the user tries to create a new node it should snap to the current one.
Double clicking should close the polygon on all browsers on desktop computers.
Minimal example reproducing the issue
The main example on the page causes the same issues like I get with the new versions of Leaflet and Leaflet.draw. http://leaflet.github.io/Leaflet.draw/docs/examples/full.html
A video of the behavior can be seen here https://youtu.be/sCnKx9zOD5c
Disabling the touch from Javascript would cause problems on mobile devices and I expect them both to work.

[x] this example is as simple as possible
[x] this example does not rely on any third party code

Using jsfiddle or another example site.

Drawing a rectangle using a drag motion also has problems.

Nice issue report, the issue also occurs in Edge on Windows 10.
There is also an issue when polygon drawing is enabled and the user drags the map a new vertex is added.

anyone find a fix for this issue?


[Issue] nes-input

resolves #322
Description
The input, nes-input is overlap the parent tag because the width is over by margin and border width.
Then, I've remove the width of input and let it stretches to parent. So, the input is fill to parent and not bleed to outside.
If you have any feedback or suggestion, please comment on this PR.
Thank you 😎
PS: Sorry, for my branch's name, it have to be issue/nes-input. 😅

I should thanks to you 😄.
However, this problem affected to nes-select, nes-textarea, and nes-progress also.
In my opinion, I think these cause of width.

ref #364


R cannot work

<leader>R works fine if I start a project:
$ sh unix/vim.sh test.exvim
but won't work by sh test.exvim.
also works fine in this way:
vim -u ~/main/.vimrc --cmd "let g:exvim_custom_path='~/main'" test.exvim

Cause sh test.exvim is not a vim command. How does vim can expect working on it?

I find that its /etc/vimrc makes the shortcuts not work.


Add labels.json

A few days ago I create similar labels.
I'll share them with you in case one of them could inspire you...

[
  {
    "name": "good first issue",
    "color": "7057ff",
    "description": "Good for newcomers"
  },
  {
    "name": "priority: critical",
    "color": "b60205",
    "description": ""
  },
  {
    "name": "priority: high",
    "color": "d93f0b",
    "description": ""
  },
  {
    "name": "priority: low",
    "color": "0e8a16",
    "description": ""
  },
  {
    "name": "priority: medium",
    "color": "fbca04",
    "description": ""
  },
  {
    "name": "status: can't reproduce",
    "color": "dda035",
    "description": ""
  },
  {
    "name": "status: confirmed",
    "color": "215cea",
    "description": ""
  },
  {
    "name": "status: duplicate",
    "color": "cfd3d7",
    "description": "This issue or pull request already exists"
  },
  {
    "name": "status: have to reproduce",
    "color": "077f53",
    "description": ""
  },
  {
    "name": "status: need more information",
    "color": "fef2c0",
    "description": ""
  },
  {
    "name": "status: wontfix",
    "color": "ffffff",
    "description": "This will not be worked on"
  },
  {
    "name": "type: bug",
    "color": "d73a4a",
    "description": "Something isn't working"
  },
  {
    "name": "type: discussion",
    "color": "d4c5f9",
    "description": ""
  },
  {
    "name": "type: documentation",
    "color": "006b75",
    "description": ""
  },
  {
    "name": "type: enhancement",
    "color": "84b6eb",
    "description": ""
  },
  {
    "name": "type: feature request",
    "color": "fbca04",
    "description": "New feature or request"
  },
  {
    "name": "type: help wanted",
    "color": "008672",
    "description": "Extra attention is needed"
  },
  {
    "name": "type: question",
    "color": "d876e3",
    "description": "Further information is requested"
  }
]

My reasoning for pushing back on a large number of label kinds is that it adds to the mental overhead when categorizing bugs.

This is mostly the set of labels we already use in the CLI and other tools projects, with the addition of the package labels. We've talked about about pruning the Status labels, but didn't reach a conclusion. I already sync'ed these labels to the repo, so just wanted to commit the file I used. I think we can revisit them incrementally.

If we update labels.json will be be able to update the labels in github?

Yes. I'm using git-labelmaker which allows bidirectional syncing: https://github.com/himynameisdave/git-labelmaker
But now that I mention it, the only reason I had been doing this before was to standardize labels across repos, which isn't necessary with a monorepo... 🤔

Yeah... closing this as unnecessary


New package: AMCL v0.201.0

Registering package: AMCL
Repository: https://github.com/blenessy/AMCL.jl
Created by: @blenessy
Version: v0.201.0
Commit: 187b791fdaf952d8c0b41edf66616a6debd8ea7b
Git reference: master
Release notes:

PoC Release

[noblock]

This package is bound to https://github.com/JuliaBinaryWrappers/AMCL_jll.jl. Please consider making exception to the naming rules as it would just disassociate these two symbiotic packages.
From the version number (0.201.0) I can easily conclude that it (transitively) pulls in 2.0.1 of the  underlying C library. I can change the version to 0.0.1 if you guys prefer, but it will decrease the traceability for the developers.

2. From the version number (0.201.0) I can easily conclude that it (transitively) pulls in 2.0.1 of the  [underlying C library](https://github.com/apache/incubator-milagro-crypto-c). I can change the version to 0.0.1 if you guys prefer, but it will decrease the traceability for the developers.

The version number is fine.

1. This package is bound to https://github.com/JuliaBinaryWrappers/AMCL_jll.jl. Please consider making exception to the naming rules as it would just disassociate these two symbiotic packages.

I would very strongly recommend a longer and more descriptive package name.

Thanks for your quick feedback @DilumAluthge !
Ok, I will change the name to something more descriptive for the general public. However, I'm a little torn about calling it ApacheMilagroCryptoLibrary - which is what AMCL abbreviates - as it contains some arguably superfluous parts e.g. Apache and Library.
With that said, I have proposed a shorter name to the AMCL maintainers, and will wait for the rest of this week for their input.
Once decided I will create a new PR with the Registrator tool, so please feel free to close this one.


Opt Out Message on Bot Join

When the bot joins the server, it creates a message that prompts users that want to opt out to react with a thumbs down emoji.

The value of JOIN_MESSAGE_CHANNEL_ID can be modified for testing. Currently hardcoded the value.

This appears to get part of the way through #5 by presenting a target for the opt-out interaction. Perhaps you and @hum can discuss how best to complete the task.


error when used with nginx only.

i get an error message when i restart nginx service after linking the config files.
* Restarting nginx nginx                                                       nginx: [emerg] unexpected ">" in /etc/nginx/conf.d/letsencrypt.conf:16 nginx: configuration file /etc/nginx/nginx.conf test failed
any ideas?

It looks like you might be trying to use the Apache conf file provided in the project with Nginx.  This won't work as the two web servers have very different configuration file formats.  With Nginx you need to manually add the Let's Encrypt webroot mapping to each site's configuration directly.
Check the Nginx Configruation section of https://github.com/interbrite/letsencrypt-vesta/blob/master/README.md for specific details.


Enhance User Selection in Add Users Modal

Enhance the user selection functionality in the "Add Users" modal, allowing multiple users to be selected without closing the dropdown after each selection, improving usability.

@ShubhamPatel2305 Please review the PR and merge it.


Bluetooth

This moves GATT Service samples under subsys/bluetooth/lib and make changes to its API.
Fixes #1166

I have a bit mixed feelings about this for various reasons. One is that anything we expose under include/bluetooth/ has much stricter API stability requirements than anything else. Another is that a lot of this is not really product code, rather sample code. If we are to provide something like BAS in the kernel, it should at least have one reference implementation for real battery hardware.

Note this was done as a library, so the services don't actually do much without user feeding proper values and I tried as much as possible to make a stable API out of that thus the various patches working on proper namespace, etc. As for the actual header location Im open for suggestions though the idea was to avoid including other paths like done before.

After discussing this a little bit with Johan we decided to do this a little bit differently and have the stack itself implementing these services whenever possible, so things like DIS, BAS and CTS will probably be enabled via Kconfig in the stack directly while other services may be used for a single application.


Increase visiblity of checkbox

Thank you for developing the Sakura Night theme. Its design, inspired by sakura trees, is both beautiful and calming. As a Japanese user, I find it especially appealing and well-crafted.
I am writing this with the help of GPT, as I am not a native English speaker.
I’ve encountered an issue regarding checkbox visibility.

The background color of checkboxes appears the same whether they are checked or unchecked, making it difficult to distinguish their state.
This may be a bug, but the published screenshots don't show the checkbox, so I couldn't be sure this is correct.
The contrast between the checkmark and the background is relatively low, which makes it harder to notice at a glance.
While this may be an intentional design choice, I think improving the contrast or adjusting the background color for checked checkboxes would make the theme even more user-friendly.
I tried with IntelliJ IDEA 2024.3 (Ultimate Edition) #IU-243.21565.193
I will be glad to provide any information that is needed.
Thank you again for your excellent work. I hope you’ll consider this suggestion for a future update.

Hi @Manapia, thanks for the kind words! I will of course look into this in the next couple of days for you 👍

Hi @Manapia, I've uploaded an update to the JetBrains marketplace which should be usable in the next couple of days. They've been fairly quick recently.
Regarding the fix, I couldn't find much I could do with it unfortunately. It seems like JetBrains have a bug where in themes marked as dark mode themes, the background of the checkbox is always the selected color, whereas on light themes it's transparent. Marking the theme as a light mode theme would have other implications so it doesn't seem like a good idea.
Hopefully this helps with the visibility at least.
Let me know how you get on with it, I'll close this in the meantime 👍
Thanks again for raising this issue

Thank you for the feedback, and glad that it has helped. Looking at some other themes, they tend to keep the checkbox background transparent, which I could change it to if needed

You're right—many other themes tend to use transparent checkboxes, which might make it easier for users migrating from other themes to feel more familiar.
To preserve the uniqueness of this theme, I think using a lighter shade of pink could also work well

![image](https://github.com/user-attachments/assets/a5da4db5-6a0e-4078-ba3e-38f83138c9ad)

That said, I’m not familiar with JetBrains IDE theme settings. If making the checkboxes transparent or using lighter colors unintentionally affects the background of other controls, it might be better to leave things as they are. The background color of the "OK" button, for example, doesn't seem to have changed (though it looks a bit too bright), so my concern may be unnecessary.
In any case, I’m happy with the current design. Thank you!


remove httptransport

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 13.35%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
271

Relevant Lines:
2030

💛  - Coveralls


There is way to listener all keyboard input event?

Please speak English, this is the language everybody of us can speak and write.
Please ask questions or config/deploy problems on our Gitter channel: https://gitter.im/go-vgo/robotgo
Please take a moment to search that an issue doesn't already exist.
Please give all relevant information below for bug reports, incomplete details will be handled as an invalid report.

You MUST delete the content above including this line before posting, otherwise your issue will be invalid.

Robotgo version (or commit ref):
Go version:
Gcc version:
Operating system and bit:
Can you reproduce the bug at Examples:

[ ] Yes (provide example code)
[ ] No
[ ] Not relevant

Provide example code:

Log gist:

Description
...

Please see issues/21 and issues/61, I will think about it or add it in future.

@iann0036 Thanks for support, which will be implemented in v.0.47.0 or v0.48.0

Have not found a good program, I think again.

a node module named "iohook" can do the same thing, may be it can provide some idea!


chore(test): fix flaky tests

Summary
chore(test): flakiness caused by assuming order
Generally, if the API definition does not require data ordering, we should not make assumptions about the ordering. Otherwise, the test could be flaky.
fix(test): flakiness due to time
We should always update the time before a time-sensitive test.
sleep implicitly updates time, but we need an accurate start time before sleep.
Thanks to @ADD-SP's help.
Issue reference
Fix KAG-2417

ce -> ee cherry-picked in kong/kong-ee#6321

@StarlightIbuki pls manually backport the change as the bot failed.

@AndyZhang0707 It's cherry-picked by CE-EE merge and that's the reason the bot failed.


calling for resource npwd_crypto export

SCRIPT ERROR: @CryptoMining/Server/Difficulty.lua:18: No such export GetCryptoValue in resource npwd_crypto
I'm using the renewed-phone with the 4 cryptos
https://github.com/Renewed-Scripts/qb-phone
how would I change this? Under difficulty.lua?
Citizen.CreateThread(function()
Wait(5000)
while true do
Wait(10000)
local Worth = exports["npwd_crypto"]:GetCryptoValue()
    if Worth ~= nil then
        Difficulty = ((Worth * GetPriceDivider()) * 0.0005) + (GetRandomFloatInRange(0.1, 1.0) / 10)
    end

    TriggerClientEvent("CQBMININGV2:UpdateDifficulty", -1, Difficulty)
end

end)

Hey, sorry for the late reply;
Without some code changes, this only supports single coin, so you would want to pick a single coin and swap the export over to that.
Also be sure to change the payout function as well.

The renewed phone with the 4 crypto choices has the names abbreviated with 4 letters I tried changing each one at a time to them but I think your right Imma have to change some code to make it work renewed phone also has a funny way to install it to function as well you gotta change a line of code then change it back for certain functions to work like a manual on off switch for code it gets annoying with the phone script also when you add in more jobs to the management. I'll have to fiddle with it more I find your crypto mining scripting unique and different than most and thing it would blend well with my test server.


Relicense as MIT

https://github.com/gratipay/inside.gratipay.com/issues/1161

Merging in the wake of https://github.com/gratipay/gratipay.com/pull/4626.


Fix #15684: JsonExpression in Command::update() method

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes (except hhvm)

Fixed issues
#15684, #15677

Thank you for finding it out

In my point of view this feature is breaking BC. For example I have a SerializerBehavior  and it is attached to the model like this:
  'serialize' => [                 'class' => '\path\to\SerializerBehavior',                 'attributes' => ['category_ids'],                 'serializer' => new JsonEncodeClosure(),                 'deserializer' => new JsonDecodeClosure()             ]
Column type in database is  json. So I have 2 options

To change all db types to string and continue using SerialzerBehavior
To change all my models and  remove the Behavior.

Also there is a third option to add something like IsValidData() in BaseJson, so it will not break BC, and can be dropped in 2.1

Manually applied, works for me (PostgreSQL 9.6 JSONB filed).

@schmasterz that's separate issue.

I will write the unit tests in this evening

@berosoboy Thank you, I will push a commit with test and another issues fixed soon

Closed in favor of https://github.com/yiisoft/yii2/pull/15732
@berosoboy I've mentioned you in a changelog. Thank you

Thank you


Missing documentation for new IDE code style rule IDE0270

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0270 returns a 404 page not found. IDE0270 was first added in VS2022 17.5 release with https://github.com/dotnet/roslyn/pull/65371.

Customer report: https://developercommunity.visualstudio.com/t/Compiler-error-for-IDE0270-after-upgradi/10301675

This is covered by https://github.com/dotnet/docs/issues/30361.


Add Google Analytics

https://github.com/react-ga/react-ga

The actual GA id should be provided via an environment variable and jenkins will provide that during the build. Especially while there are few users it would be annoying to be logging calls on dev machines.

I want dev statistics! :)


Option to customize Default Public Gateway

Good suggestion by @lockedshadow  from https://github.com/ipfs/ipfs-companion/issues/16#issuecomment-331079306:

Maybe it's possible to add an option to select which public gateway to substitute in generated URL, if there are more than one in Preferences? For now it seems to be hardcoded on ipfs.io.

Yes, right now  https://ipfs.io/ is hardcoded.
A good feature would be to specify custom one and use it in:

Copy public gateway URL function
links made by linkifyDOM experiment
custom protocol handlers when IPFS API is down (fallback to public gateway)

FYI this feature landed in v2.0.11 🚀


Add a variety of panzoom improvements

Zoom control in top right (and reset zoom button)
0-dimensional diagrams
Reset panzoom when switching diagrams
Fixes toast z-index

Fixes #79, fixes #110, fixes #120

Nathan this is gorgeous 🥇

The dot for a 0-dimensional diagram is a bit too small, could we make it 3 times the size please?


pluto tv tab is missing from channel editor

pluto tv tab is missing from channel editor after i rebooted my windows pc. pluto tv and pluto tv instance and xmltv is enabled.

It will be missing until channels are populated into the database. I would need to see a log during the channel retrieval for pluto to determine why it is not working.

I managed to fix it by deleting the config file and starting a fresh
config. It happened again after a fresh uninstall and reinstall of
cabernet. I thinks it happens right after I replace your pull request
files. I'm not sure how to get you the logs.
On Wed, 1 Mar 2023, 10:51 am rocky4546, @.***> wrote:

It will be missing until channels are populated into the database. I would
need to see a log during the channel retrieval for pluto to determine why
it is not working.
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1450379611,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPI22BKXNP6CS6IVAA3WZ5WBTANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Well, there are many different ways to get logging.  I personally like to enable file logging in the settings and set it to DEBUG.  The log file then appears at data/logs/cabernet.log
But, I believe you have figured it out.  I suspect the issue is that you are deleting the database files in the data/db folder when you do something causing the issue to appear.

All I did was replace the 2 .py files you gave me though, I didn't delete
anything
On Wed, 1 Mar 2023, 11:26 pm rocky4546, @.***> wrote:

Well, there are many different ways to get logging. I personally like to
enable file logging in the settings and set it to DEBUG. The log file then
appears at data/logs/cabernet.log
But, I believe you have figured it out. I suspect the issue is that you
are deleting the database files in the data/db folder when you do something
causing the issue to appear.
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1451282445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPOA362ATPHHYDAG2V3W2AOQLANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Also I noticed the ffmoeg path was blank on first install again and ffprobe
path was already set. I had to change those again.
On Wed, 1 Mar 2023, 11:33 pm Max Powers, @.***> wrote:

All I did was replace the 2 .py files you gave me though, I didn't delete
anything
On Wed, 1 Mar 2023, 11:26 pm rocky4546, @.***> wrote:

Well, there are many different ways to get logging. I personally like to
enable file logging in the settings and set it to DEBUG. The log file then
appears at data/logs/cabernet.log
But, I believe you have figured it out. I suspect the issue is that you
are deleting the database files in the data/db folder when you do something
causing the issue to appear.
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1451282445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPOA362ATPHHYDAG2V3W2AOQLANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>

I think you are saying you are creating a new instance of cabernet all the time. Why would you be doing that instead of just doing the upgrade from the home page?

I haven't been creating a new instance. I only ever close cabernet before I
reopen it.
On Thu, 2 Mar 2023, 10:28 pm rocky4546, @.***> wrote:

I think you are saying you are creating a new instance of cabernet all the
time. Why would you be doing that instead of just doing the upgrade from
the home page?
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1452906876,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPJ22T5VUABX42JAFPTW2FQMJANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Oh to do a fresh install Ive been uninstaling cabernet from the windows
control panel and then reinstalled it
On Thu, 2 Mar 2023, 10:40 pm Max Powers, @.***> wrote:

I haven't been creating a new instance. I only ever close cabernet before
I reopen it.
On Thu, 2 Mar 2023, 10:28 pm rocky4546, @.***> wrote:

I think you are saying you are creating a new instance of cabernet all
the time. Why would you be doing that instead of just doing the upgrade
from the home page?
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1452906876,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPJ22T5VUABX42JAFPTW2FQMJANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>

yea, don't do that... Cabernet has an easy way.  (exception: the new tvguide plugin is manual upgrade right now,.. will be fixing that) To upgrade... the "Check for upgrade" task runs once a day and when you hit the home page will let you know there is an upgrade available.  If the task has not run and you know there is an upgrade, go to the scheduled tasks > applications and run Check for Upgrades... Wait a few seconds then go back to the home page.  If you are right, it will tell you an upgrade is available.  All you have to do is click the button.  Once upgraded, just refresh the home page and the version number will update and everything will be upgraded (except the tvguide...)

Oh ok sweet. I'll check out all the new stuff either later tonight or
sometime tomorrow during the day. It's pretty awesome that your project is
actively being updated.
On Thu, 2 Mar 2023, 11:12 pm rocky4546, @.***> wrote:

yea, don't do that... Cabernet has an easy way. (exception: the new
tvguide plugin is manual upgrade right now,.. will be fixing that) To
upgrade... the "Check for upgrade" task runs once a day and when you hit
the home page will let you know there is an upgrade available. If the task
has not run and you know there is an upgrade, go to the scheduled tasks >
applications and run Check for Upgrades... Wait a few seconds then go back
to the home page. If you are right, it will tell you an upgrade is
available. All you have to do is click the button. Once upgraded, just
refresh the home page and the version number will update and everything
will be upgraded (except the tvguide...)
—
Reply to this email directly, view it on GitHub
https://github.com/cabernetwork/cabernet/issues/42#issuecomment-1452938435,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AODRSPNTAIKVZEJ57SPX7ULW2FVRZANCNFSM6AAAAAAVLR6MHI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Peer Dependency Warning with @sanity/ui@^1 and Installed Version 2.0.12

Hello,
I've encountered a peer dependency warning while working with<EMAIL_ADDRESS>in a project. It appears that the plugin expects @sanity/ui version ^1.x.x, but the latest is version 2.0.12 , which is leading to the following warning during package installation with pnpm:
 WARN  Issues with peer dependencies found
.
└─┬ @focus-reactive/sanity-plugin-inline-svg-input 1.0.1
  └── ✕ unmet peer @sanity/ui@^1: found 2.0.12

Just wanted inform you.

Thanks @ciruz, we will soon release a new version with support for @sanity/ui@2. We will close the issue after that, so you will be informed.

Hey @chenaski , any updates? Can't install the plugin for new Studio configs.

Hey @ciruz @guillermo-avalos!
Sorry for the delay, we've just released the new version<EMAIL_ADDRESS>with support for both @sanity/ui@1 and @sanity/ui@2.


Lunademo Linux Must be ran with root

Root is needed for the how to full demo

Working on a fix for this now


Update enemy rendering, players who haven't eaten cannot be eaten again, large mass blobs on top.

I changed the enemy rendering to be like drawPlayer.
The player/enemy with larger mass will come out on the foreground.
mass loss won't drop below 10.
Players who haven't eaten won't be checked for collisions.

That's awesome, but could you pretty please try to fix the merge conflicts on it? Thanks in advance :)

definitely

@Buskcoin please run gulp lint-client and gulp lint-server and fix accordingly.

Ok, should be good to merge.


Add note saying that NameCheap doesn't allow you to expedite transfers

The email they send you only contains a link to cancel the transfer, and not one to expedite the transfer. You have to wait 5 days.

Commit addressed by PR referenced above.


upgrade aws provider

Upgrading the aws provider version to be "~> 3.0" because the current "2.0" does not work if we have another resources depend on version 3.0

Error :

Initializing provider plugins...

terraform.io/builtin/terraform is built in to Terraform
Finding hashicorp/null versions matching "~> 2.0"...
Finding hashicorp/aws versions matching "~> 3.0, ~> 2.0"...
Using hashicorp/null v2.1.2 from the shared cache directory

Error: Failed to query available provider packages
Could not retrieve the list of available versions for provider hashicorp/aws:
no available releases match the given constraints ~> 3.0, ~> 2.0

Hi @AlyRagab
We are using lower bound pinning going forward.
Could you please adjust this for Terraform and for the providers?

Here's an example https://github.com/cloudposse/terraform-aws-codebuild/pull/70

Thanks @aknysh for your comments

/test all

/rebuild-readme

/test all

/test all

/rebuild-readme

/test all

/test all


Missing VITE_DESKTOP_HOSTNAME and VITE_DESKTOP_HTTP_PORT in builds

when building the app in CI or with build-desktop, the buildInfoUrl cannot be created because it is missing the env variables

    const buildInfoUrl = `${process.env.VITE_DESKTOP_HOSTNAME}:${process.env.VITE_DESKTOP_HTTP_PORT}/debug/buildinfo`

duplicate #1656


Update hvac module version to 0.11.2

Closes #3761 by picking up https://github.com/hvac/hvac/pull/762 introduced in hvac 0.11.2. In this new version of hvac, the X-Vault-Request: true header is added to all requests which provides additional protections against SSRF vulnerabilities when interacting with a Vault Agent.

Thanks for the PR  @bobmshannon. Merging now.


You can push entities on top of a medical scanner by moving while inside

Enter a medical scanner.
Spawn a locker on top of it.
Move.
The locker will be nudged to the side.

Not an issue anymore with it's collisions fixed. Closing.


silent error if a CDX entry does not exists in the warc path

val rdd: RDD[WarcRecord] = ArchiveSpark.load(sc, WarcCdxHdfsSpec(cdxPath = "/data/example.cdx.gz", warcPath = "/tmp/empty_directory"))
rdd.foreach(println)

in this case, the warcPath is an empty directory, so no entries from the CDX file will be found. The issue is that rdd.foreach will silently ignore this problem.
Shouldn't it throw an error? or is there a way to force to throw an error or warning?

This is due to the way the DataSpec is implemented and not a limitation of ArchiveSpark. The DataSpec internally creates a map of all available WARC files and if a CDX files does not match, it simply skips it, as it assumes that your CDX records match the WARC files that you want to work with. If you need to check for existence, please feel free to create a project in which you copy the WarcCdxHdfsSpec and modify it so that it throws an error in that case.

ok.

We now have instructions on how to create DataSpecs:
https://github.com/helgeho/ArchiveSpark/blob/master/docs/Dev_DataSpecs.md


Add config_diagnostics to our configuration files.

The change to a more configuration based approach to enable FIPS mode operation highlights a shortcoming in the default should do something approach we've taken for bad configuration files.
Currently, a bad configuration file will be automatically loaded and once the badness is detected, it will silently stop processing the configuration and continue normal operations.  This is good for remote servers, allowing changes to be made without bricking things.  It's bad when a user thinks they've configured what they want but got something wrong and it still appears to work.
The bad carries over into things the configuration is trying to do.  E.g. a bad FIPS MAC would cause the configuration to stop loading (until #16168).
Reported in #16163, #16165 and #16166.

[ ] documentation is added or updated
[ ] tests are added or updated

Perhaps "Comment out the next line to ignore configuration errors" seems better ?

Good suggestion, applied.

This pull request is ready to merge

OTC vote in progress.

OTC vote passes (6 for, 1 against, 1 abstain, 2 not voted), this has been merged.  Thanks for the review.


1709 image and docker support

Just copied the contents and modified the FROM.
Created a docker image installing the docker-cli and docker-compose.
Published the results here.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: riezebosch sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@riezebosch 1803 is already released so probably it would be good idea migrate to that one?

@olljanat I lost my faith a little

How does this compare with #91 ? I am not very familiar with the versioning/tags for windows containers

@dakale Looks like what I've done manually can be done with the Update.ps from that PR.


[FEATURE REQUEST] Blur with ImGui shader post processing

@danielkrupinski (probably original) code:
https://github.com/danielkrupinski/GOESP/tree/master/GOESP/Resources/Shaders
https://github.com/danielkrupinski/GOESP/blob/master/GOESP/PostProcessing.cpp
https://github.com/danielkrupinski/GOESP/blob/master/GOESP/PostProcessing.h
Might be helpful

Material attempt: https://www.unknowncheats.me/forum/counterstrike-global-offensive/496282-blur-material.html

do not see any reason to add it to base


Persistence: Add support for LightGBM and XGBoost

EDITED
Resolves #226
Description
LightGBM already worked out of the box, so for this, only tests were added. For XGBoost and CatBoost, extra code was added to support them.
Implementation
Dependencies were extended to include xgboost, lightgbm, and catboost for testing, so that they should be covered by CI. If those libraries are not installed, the tests should be gracefully skipped.
~For xgboost, the xgboost-specific persistence format was chosen, which can be used through estimator.save_model and estimator.load_model. I could not verify (yet) that this format is 100% secure. However, since it's a binary json file (.ubj), it should as secure as json. More information here:~
~https://xgboost.readthedocs.io/en/stable/tutorials/saving_model.html~
~The actual implementation for xgboost mirrors the one for numpy arrays, which also stores its data in an external file. However, I did not apply any caching here, as it seems it wouldn't be useful.~
I decided to create a new test file, test_external.py, to put the new tests, instead of cramming more into test_persist.py. Since some functions from test_persist.py were required here, I moved them a new _utils.py module.
Interestingly, I found some potential bugs where some values returned by get_params() may differ for xgboost models after loading. This is independent of skops. Those edge cases are documented but were excluded from tests, as it appears that they should be inconsequential. We may want to report them.

I removed the xgboost bug (?) docstring, since I couldn't find how to exclude it from running with doctest. Replicating it here so that it doesn't get lost. Ideally, someone with more experience in xgboost could comment on whether this really is a bug or not. If so, we could submit it to the xgboost issue tracker.
>>> import xgboost
>>> print(xgboost.__version__)
1.7.1
>>> estimator = xgboost.XGBClassifier(tree_method=None)
>>> X, y = [[0, 1], [2, 3]], [0, 1]
>>> estimator.fit(X, y)
XGBClassifier(...)
>>> print(estimator.tree_method)
None
>>> print(estimator.get_params()["tree_method"])
exact
>>> # after save/load roundtrip, tree_method's get_params value changes from exact to auto
>>> import tempfile
>>> tmp_file = f"{tempfile.mkdtemp()}.ubj"
>>> estimator.save_model(tmp_file)
>>> estimator.load_model(tmp_file)
>>> print(estimator.tree_method)
None
>>> print(estimator.get_params()["tree_method"])
auto
>>> # a similar thing happens with gpu_id
>>> estimator = xgboost.XGBClassifier(tree_method='gpu_hist', booster='gbtree')
>>> estimator.fit(X, y)
XGBClassifier(...)
>>> print(estimator.gpu_id)
None
>>> print(estimator.get_params()["gpu_id"])
0
>>> # after save/load roundtrip, gpu_id's get_params value changes from 0 to -1
>>> estimator.save_model(tmp_file)
>>> # for gpu_id, the estimator needs to be re-initialized for the effect to occur
>>> estimator = xgboost.XGBClassifier()
>>> estimator.load_model(tmp_file)
>>> print(estimator.gpu_id)
None
>>> print(estimator.get_params()["gpu_id"])
-1

So looking at this again, I don't understand why you think using __setstate__ would be error prone. It can be the case that somebody creates a custom .skops file where they put odd attributes there, but if the user loads a file where the input to __setstate__ is exactly what we got from __getstate__, then there shouldn't be any issues.
It seems the issue we have is that we don't support bytearray, I think. So maybe a better solution here would be to add support for that, which in turn would fix the issue for xgb w/o us explicitly having to do an xgb specific kinda thing.

@adrinjalali I tested your suggestion to add support for byterray and it is indeed sufficient for supporting xgboost. The more general point still stands to be decided.

The more general point still stands to be decided.

I agree. But I think for now we can do with only supporting bytes/byte array, and figure out supporting custom formats of 3d party libraries later.
One thing I wonder: should we store bytes in a binary file instead? I feel like it'd make save/load much faster, and keep the schema json file cleaner.

I agree. But I think for now we can do with only supporting bytes/byte array, and figure out supporting custom formats of 3d party libraries later.

Okay, then let's start with that.

One thing I wonder: should we store bytes in a binary file instead? I feel like it'd make save/load much faster

It'll probably depend. In this case, maybe, but having the additional i/o is probably a big overhead if we have multiple small bytes.

It'll probably depend. In this case, maybe, but having the additional i/o is probably a big overhead if we have multiple small bytes.

I wanted to suggest having a threshold for having them in the schema or in the file, but then I realized another thing to think of, is that if we allow binary data in the json schema, then people can create .skops files where there is a ton of binary data there, and we'd read them. That doesn't sound like a good idea to me. I'd be more comfortable reading those only from files. WDYT?

then people can create .skops files where there is a ton of binary data there, and we'd read them. That doesn't sound like a good idea to me

I'm not against your proposal, I just want to understand what the concern is. Is it only about readability? Since you could argue that even if there is a big blob in the json, it's only one line so doesn't distract much (it could slow down some editors though).

Slowing down an editor is one thing, loading a massive json into memory is another thing. I'm not sure how people could exploit this, but I kinda feel like keeping them in separate files is cleaner.
Besides, I don't think there are many cases where we'd encounter small byte arrays. So my guess is that in most cases those byte arrays are large rather than small, and therefore having all of them in files would speed things up on average.

@adrinjalali I made the changes as you suggested, please review again. For good measure, I checked if adding the bytes support is sufficient for making catboost work and indeed it does, so I added tests for it as well.

@adrinjalali I addressed your comments, please review again.
Regarding the issue of forgetting to add bytes/bytearray to trusted: It's a bit of a sign that our test coverage could be improved, right? As is, those oversights were not caught with the standard set of tests we have.

tests failing @BenjaminBossan

@adrinjalali sorry, I made a list minute change and rolled it back, introducing the bug. Tests are green now.


headless: false improvements

The debug option is very helpful! Referring to:
browser = await puppeteer.launch({
  headless: false,
  slowMo: 100,
})

However, it doesn't activate/focus the opened Chromium app so you need to wait for the app to open then quickly activate it. Example:

Ideally it would be awesome to have a pause/play button and Chromium opens paused at first by default, but even just automatically focusing the Chromium window when it opens would be helpful (if this can be done cross platform? electron does this, but I'm not sure how). I could add a unix-specific sleep {someAmount}; open -a "Chromium" to the script that runs puppeteer, but this would create race conditions and tie the script to mac/linux.
Anyways, not a big deal but something to think about :) Thanks for all the great work with Puppeteer.

Sounds good! There's been talk about adding a protocol method to focus the inspected page. I'll see what I can do about this one.
In the meantime you can debug your Puppeteer script with node --inspect-brk, and then step through it with DevTools.

I think this focusing problem is all based on your window manager. On Linux for example, mine focuses on any interaction or creation of a new window. The only time it doesn't is if I'm on another physical workspace (since workspaces aren't shifted based on window behavior.) This looks to be the same thing happening on Mac OS.

@Garbee Window managers per operating system play a role in the default behavior of new windows, but I believe Puppeteer can still do something about it as some tools I use auto-focus launched apps. For example, the create-react-app tool opens localhost:3000 and focuses it and electron starts up your electron app and focuses it. Here is an example with electron where I'm not pressing any buttons or using the mouse (completely automated) after I run electron:

@JoelEinbinder you can focus the tab with Page.bringToFront

@trevordmiller Apologies as this is totally unrelated to your question, but what test runner are you using? That output looks nice.

@AndrewGuenther No worries :) It is Jest, which I highly recommend! https://facebook.github.io/jest/

any news on this? What would be the equivalent of Selenium's browser.wait()?

Closing for lack of activity. Feel free to reopen if someone is going to work on it :)

how do you run puppeteer inside electron app??


Insert Link modal does not works on Chrome.

Hi guys, thanks for your great work.
I've had problems since the last google chrome update.
I get this error in console when I try to open the insert link modal. Do somebody have same problem? there's a way to solve it?

Thanks in advance.

Try removing the boolean parameter from the focus method.  Instead of  self.editor.currentView.element.focus(false);, do self.editor.currentView.element.focus();
or change to self.editor.currentView.element.focus({preventScroll:false})
See https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus
It doesn't look like this project is actively maintained so I just made the change directly in my project.


Elbow from multiple blocks

An option to specify how many axial blocks to create an elbow from to keep consistent circular cross-section

Replaced by using chaining, see examples/shapes/elbow


⚠ Bofrost.lu has degraded performance

In 07a7fac, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 969 ms

Resolved: Bofrost.lu performance has improved in 1f5a934 after 16 minutes.


Bad Magic Number .pyc related error

Describe the bug
Sometimes after git checkout to other brach some .pyc are causing problems to start Pype with following error
ImportError: bad magic number in 'pype.lib': b'\x03\xf3\r\n'
Expected behavior
Pype could capture this error and emedietly after try to ./pype clean itself. Only after it tried and unfortunately was not successful due to some host being using Pype it would send Error exception with some human readable instruction like:
Please close all hosts and Pype and reopen. This is an python related problem which will be fixed automatically after next start of Pype
Or something similar..

had been refactored in new pype3

had been refactored in new pype3


feat: 3897 - now we display localized images

What

We used to rely on one image URL per product field (e.g. product.imageFrontUrl).
Which meant that if we changed the app language, the image wouldn't change.
But there are cases when the image is different, depending on the language.
With the current PR, we always instantly get the "best" image if we change languages: the image specific to the new language, and as a fallback the product image URL we used before
This is only the first step to multilingual images.
The next steps are multilingual image edits and OCR.

Screenshot

specific front image in French
specific front image in Spanish
default front image in Italian

Part of

#3897

Impacted files

background_task_crop.dart: added language to transient file key
background_task_image.dart: added language to transient file key
background_task_unselect.dart: unrelated removal of not used fields
edit_ingredients_page.dart: now we display localized images
image_upload_card.dart: added language to transient file key
ocr_widget.dart: added language to transient file key
product_cards_helper.dart: now returns a localized image; refactored; new method getLocalizedProductImageUrl
product_image_carousel.dart: now we display localized images
product_image_gallery_view.dart: now we display localized images
product_image_swipeable_view.dart: now we display localized images
product_image_viewer.dart: now we display localized images
product_query.dart: unrelated removal of not used field
product_refresher.dart: unrelated minor refactoring
smooth_product_image.dart: now we display localized images
transient_file.dart: added language to transient file key
up_to_date_changes.dart: unrelated removal of not used fields

Codecov Report

Merging #3900 (797bfdd) into develop (85a3525) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3900      +/-   ##
===========================================
- Coverage    10.68%   10.67%   -0.02%
===========================================
  Files          270      270
  Lines        13428    13448      +20
===========================================
  Hits          1435     1435
- Misses       11993    12013      +20

Impacted Files
Coverage Δ

...mooth_app/lib/background/background_task_crop.dart
0.00% <0.00%> (ø)

...ooth_app/lib/background/background_task_image.dart
0.00% <0.00%> (ø)

...h_app/lib/background/background_task_unselect.dart
0.00% <ø> (ø)

...th_app/lib/cards/data_cards/image_upload_card.dart
0.00% <0.00%> (ø)

...ib/cards/product_cards/product_image_carousel.dart
0.00% <0.00%> (ø)

...smooth_app/lib/data_models/up_to_date_changes.dart
0.00% <ø> (ø)

...ckages/smooth_app/lib/database/transient_file.dart
0.00% <0.00%> (ø)

.../lib/generic_lib/widgets/smooth_product_image.dart
0.00% <0.00%> (ø)

...s/smooth_app/lib/helpers/product_cards_helper.dart
0.00% <0.00%> (ø)

...pp/lib/pages/product/common/product_refresher.dart
1.75% <ø> (ø)

... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thank you @M123-dev for your review!
This PR opens the way to more interesting PRs and use cases.


feat: added holder role to contact types

Codecov Report

Merging #105 (d0a99c0) into develop (ba38097) will increase coverage by 2.77%.
 Consider uploading reports for the commit 728c8e1 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
+ Coverage    45.89%   48.67%   +2.77%
===========================================
  Files           65       66       +1
  Lines         2412     2718     +306
  Branches       539      658     +119
===========================================
+ Hits          1107     1323     +216
- Misses        1305     1395      +90

Impacted Files
Coverage Δ

...ckages/contact-manager/src/agent/ContactManager.ts
0.00% <0.00%> (ø)

...re/src/migrations/internal-migrations-ormconfig.ts
0.00% <0.00%> (ø)

packages/did-utils/src/didFunctions.ts
0.00% <0.00%> (ø)

packages/did-utils/src/x509-utils.ts
0.00% <0.00%> (ø)

...onic-seed-manager/src/agent/MnemonicSeedManager.ts
90.78% <ø> (ø)

packages/ssi-sdk-core/src/utils/database.ts
0.00% <0.00%> (ø)

...kages/vc-handler-ld-local/src/ld-context-loader.ts
100.00% <ø> (ø)

packages/vc-handler-ld-local/src/ld-suites.ts
80.00% <ø> (ø)

...andler-ld-local/src/suites/JsonWebSignature2020.ts
10.71% <0.00%> (ø)

...igrations/postgres/1659463079428-CreateContacts.ts
3.12% <3.12%> (ø)

... and 28 more

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more