Gltf scene is not properly rendered.

Bevy version
0.9.0
[Optional] Relevant system information
If you cannot get Bevy to build or run on your machine, please include:

the Rust version you're using (you can get this by running cargo --version)

cargo 1.65.0 (4bc8f24d3 2022-10-20)

the operating system or browser used, including its version

macOS 13.0

What you did
Load a gltf scene from file.
What went wrong

what were you expecting?
The whole scene should be rendered properly.
Here is the screen shot from https://gltf-viewer.donmccurdy.com/

what actually happened?
Only one model is rendered.

Additional information
Here is a minimal code to reproduce. Make sure to enable "jpeg" feature for bevy in Cargo.toml.
use bevy::prelude::*;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_startup_system(setup)
        .run();
}

/// set up a simple 3D scene
fn setup(mut commands: Commands, server: ResMut<AssetServer>) {
    // load asset
    commands.spawn((SceneBundle {
        scene: server.load("/Users/allen/Downloads/shu.glb#Scene0"),
        ..default()
    },));

    // camera
    commands.spawn(Camera3dBundle {
        transform: Transform::from_xyz(-2.0, 2.5, 5.0).looking_at(Vec3::ZERO, Vec3::Y),
        ..default()
    });
}

Here is the gltf model to repo.
shu.glb.zip

@alice-i-cecile I know the core dev of bevy may not have time to fix it now, I'm wondering if you or anyone could give me a hint about where should I start to look at, I could start fixing this and contribute a PR.

This looks like a gltf file with multiple sub-scenes. Have you tried changing or removing #scene0?

@alice-i-cecile Removing #scene0 still the same.

And changing it to e.g. #scene1? Does that change what's displayed? Are there multiple scenes withing the gltf file?

@alice-i-cecile I'm loading it directly with file path and omit #scene section like server.load(path). I think all meshes are loaded, because I can read all kind of information like face count, vertex and AABB from them, just cannot see them.

@mockersf you've looked into 3D much more than I have; any ideas on where to look?

after opening the glb file in blender and re-exporting it, I get something similar to the online gltf viewer:

and when moving the camera inside the cube

Do you know how the original gltf file was produced? Would it be possible to create a smaller file showing the same kind of issue?

@mockersf It is created by Blender. Here is the blender file.
lowpoly_final.blend.zip

@AllenDang there are two scenes in your blender file (and your glb too I guess)

If in blender you delete the "Library" scene, or if you try to display the second scene in Bevy, you will get what you expect.

@mockersf I think we should iterate and display all models from all scenes if no scene is specified.


Don't continue if list namespaces failes

We had some networking issues in our cluster. This caused a ListNamespaces to fail. This caused the sbom-operator to delete all sboms in our git directory.

While having a second look at the code there is another problem around. Let's imagine the following Situation:

sbom-operator sees a new pod, analysis it, add the SBOM to the target and annotate the pods.
In the next run, the ListPods fails hence, the pod is not part of allImages, thus t.Cleanup(allImages) will delete the SBOM from the target.
In the next run, ListPods works again, sees the annotations and will thus not analyse the pod. --> the SBOM will never get added to the target again.

I see two options to solve this:

Calling t.Cleanup(allImages) only if we are 100% sure we discovered all images currently deployed to the cluster. No error occured while listing pods or namespaces.
Adding a monotonic increasing "background run" number as annotation to every pod. If the number is != current-1, we will analyse the pod again and upload the result. This will create heavy load scanning on pod restarts and has a problem, if there is more than one instance of the SBOM operator running.

While having a second look at the code there is another problem around. Let's imagine the following Situation:

sbom-operator sees a new pod, analysis it, add the SBOM to the target and annotate the pods.
In the next run, the ListPods fails, because there is a transient network issue, hence the pod is not part of allImages, thus t.Cleanup(allImages) will delete the SBOM from the target.
In the next run, ListPods works again, sees the annotations and will thus not analyse the pod. --> the SBOM will never get added to the target again.

I see two options to solve this:

Calling t.Cleanup(allImages) only if we are 100% sure we discovered all images currently deployed to the cluster. No error occured while listing pods or namespaces.
Adding a monotonic increasing "background run" number as annotation to every pod. If the number is != current-1, we will analyse the pod again and upload the result. This will create heavy load scanning on pod restarts and has a problem, if there is more than one instance of the SBOM operator running.

Yes, that's a valid error-case. I prefer the first option to solve this. Do you want to create another PR for that?

Yes, will create another PR for that refactoring.


[GPT-63] Search: Page excerpts are sometimes not displayed

From SyncLinear.com | GPT-63

It seems that there is an issue with displaying the body content of pages. All pages do not display any info when searched

Closing since we are removing search feature for launch.


Thatched Roof Tiles not rendering properly

I love your mod, but I am having trouble placing a thatched roof. When I place the first block it looks as expected with three shingles. However, when I place an adjacent block the lower shingle disappears and the wood framework is exposed. How does one place these blocks properly?
I am using ChineseWorkshop version 1.15.2-2.4.2

Thank you, it is fixed now!
CM


When changing the display size in the OS settings while launching an app on an Android 12 (API level 31) device, the setting is not reflected.

While using an app developed with Flutter on an Android 12 device, we found a bug in which changing the display size in the OS settings is not reflected in the app. In more detail, the bug states that the first time you change the display size, the change is not reflected, and if you change the display size again, the settings from the first change are reflected.
We have investigated the conditions under which this bug occurs and have confirmed that it is limited to Android 12 and does not occur on Android 10, 11, 13, or iOS 15-17.
We have also investigated multiple Flutter and non-Flutter apps and have confirmed that this bug only occurs in apps developed with Flutter.
The following are the steps to reproduce the bug.
Steps to reproduce

Launch any app developed with Flutter on an Android 12 emulator or device.
Open the OS settings screen and change the size on the Display -> Display Size page.
Open the original app and check to see if the size has changed.
Open the OS Settings page again and change the display size.
Open the original app and check if the size has been changed.

Expected results
After Step.3 & Step.5
The display size of the application has been changed to the one you set.
Actual results
After Step.3
The app's display size has not been changed.
After Step.5
The display size is the same as the size set one time before (and this event repeats every time the size is changed afterwards).
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.8, on macOS 13.3.1 22E772610a darwin-arm64, locale ja-JP)
    • Flutter version 3.13.8 on channel stable at /Users/yuki.ezawa/.asdf/installs/flutter/3.13.8-stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c4930c4ac (4 months ago), 2023-10-18 10:57:55 -0500
    • Engine revision 767d8c75e8
    • Dart version 3.1.4
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/yuki.ezawa/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile)         • emulator-5554                        • android-arm64  • Android 13 (API 33) (emulator)
    • sdk gphone64 arm64 (mobile)         • emulator-5556                        • android-arm64  • Android 12 (API 31) (emulator)
    • iPhone SE (3rd generation) (mobile) • 812919F4-7E51-4EC4-9368-262C7BC99202 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)                     • macos                                • darwin-arm64   • macOS 13.3.1 22E772610a darwin-arm64
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

• No issues found!

can i get the release / debug application to test my self. and also instead of changing by going ( Display -> Display Size page.) do this by going Settings -> developer options -> dpi for android (in your case) . also verify that is this this problem with all android 12 devices or is that your specific.

@RudraOp9
Thank you for your comment.

can i get the release / debug application to test my self.

We are sorry, but due to an event that occurred in the development of an application for business use, we are unable to provide you with the application.
Instead, we can confirm that it can be reproduced with "Google Ads," one of the Flutter-made apps available on the Google Play Store. We believe we can also reproduce it with other Flutter default apps.

and also instead of changing by going ( Display -> Display Size page.) do this by going Settings -> developer options -> dpi for android (in your case) .

This issue is not intended to be a developer option, as this bug is caused by general Android user operations.

also verify that is this this problem with all android 12 devices or is that your specific.

Thank you for pointing this out. We believe it occurs on all Android 12 devices, but indeed we have only confirmed it on some Android 12 devices. Below are the specifications of the Android 12 devices used in our investigation

Xperia 10 II SOV43
AQUOS zero2 SHV47
Android Emulator (6.4 inch, 2380 * 1080)

Hi @ezawa-arise, it appears that you are using an older version of the flutter framework, can you upgrade to the latest version of flutter stable (3.16.9) to see if you still experience this issue?
Please provide the updated output of flutter doctor -v if you still experience this issue after the upgrade.
Thank you

@danagbemava-nc
I still experience this issue after upgrade to flutter 3.16.9-stable.
Attached below is a log of flutter doctor -v.
[✓] Flutter (Channel stable, 3.16.9, on macOS 13.3.1 22E772610a darwin-arm64, locale ja-JP)
    • Flutter version 3.16.9 on channel stable at /Users/yuki.ezawa/.asdf/installs/flutter/3.16.9-stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (12 days ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/yuki.ezawa/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile)         • emulator-5554                        • android-arm64  • Android 12 (API 31) (emulator)
    • iPhone SE (3rd generation) (mobile) • 812919F4-7E51-4EC4-9368-262C7BC99202 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)                     • macos                                • darwin-arm64   • macOS 13.3.1 22E772610a darwin-arm64
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Reproducible only on android 12 using any flutter app and the steps outlined above.
Labeling for further investigation.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.9 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (14 hours ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 120.0.6099.234

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.20.0-2.0.pre.17, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.20.0-2.0.pre.17 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6322fef7e0 (29 minutes ago), 2024-02-05 21:53:12 -0500
    • Engine revision 808886312e
    • Dart version 3.4.0 (build 3.4.0-104.0.dev)
    • DevTools version 2.32.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

try this in your code it my fix the problem
  builder: (context, child) {               final originalTextScaleFactor = MediaQuery.of(context).textScaler;               final boldText = MediaQuery.boldTextOf(context);               final newMediaQueryData = MediaQuery.of(context).copyWith(                 textScaler: originalTextScaleFactor.clamp(                   minScaleFactor: 0.8,                   maxScaleFactor: 1.0,                 ),                 boldText: boldText,               );               return MediaQuery(data: newMediaQueryData, child: child!);             },
add this under MaterialAppWidget if this property is doesn't available try use GetMaterialApp
like this
  return GetMaterialApp(             builder: (context, child) {               final originalTextScaleFactor = MediaQuery.of(context).textScaler;               final boldText = MediaQuery.boldTextOf(context);               final newMediaQueryData = MediaQuery.of(context).copyWith(                 textScaler: originalTextScaleFactor.clamp(                   minScaleFactor: 0.8,                   maxScaleFactor: 1.0,                 ),                 boldText: boldText,               );               return MediaQuery(data: newMediaQueryData, child: child!);             },             getPages: route,             locale: const Locale('ar'),             debugShowCheckedModeBanner: false,             initialBinding: IntialBindings(),             title: 'First Method',             // You can use the library anywhere in the app even in theme             theme: AppThemes.appLightTheme,             home:                 // Directionality(textDirection: TextDirection.rtl, child: )                 child!             //  ),             );       },       child: const Home(),


Middle Oil -> Light Oil (tar-refining-tops)

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[X] pyalienlife
[X] pyalternativeenergy
[X] pycoalprocessing
[X] pyfusionenergy
[X] pyhightech
[X] pyindustry
[X] pypetroleumhandling
[X] pypostprocessing
[X] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?
Recipe is unlocked by Tar Processing but cannot be used.
Steps to reproduce
No response
Additional context
No response
Log file
No response

This means that Carbon Black cannot be produced, because Anthracene Oil is locked away.

Resolved by using script from Discord.
/c for _,player in pairs(game.players) do player.force.reset_recipes() player.force.reset_technologies() player.force.reset_technology_effects()end


Update move-users-from-on-premises-to-teams.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2659
Added tip.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


CIF-1039 - Revisit the MiniCart and Checkout implementation (Part 2)

Description
Fix an import issue due to code merge
Related Issue
CIF-1039
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #130 into master will decrease coverage by 12.62%.
The diff coverage is 28.05%.

@@              Coverage Diff              @@
##             master     #130       +/-   ##
=============================================
- Coverage     54.29%   41.67%   -12.63%
=============================================
  Files           114       83       -31
  Lines          3153     2102     -1051
  Branches        521      413      -108
=============================================
- Hits           1712      876      -836
+ Misses         1369     1226      -143
+ Partials         72        0       -72

Flag
Coverage Δ
Complexity Δ

#jest
33.62% <28.05%> (ø)
0 <0> (ø)
:arrow_down:

#karma
93.61% <ø> (ø)
0 <ø> (ø)
:arrow_down:

#unittests
?
?

Impacted Files
Coverage Δ
Complexity Δ

...script/minicart/src/components/Minicart/product.js
78.94% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ascript/minicart/src/components/Minicart/header.js
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...in/javascript/minicart/src/components/Mask/mask.js
71.42% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ascript/minicart/src/components/Minicart/footer.js
20% <ø> (ø)
0 <0> (ø)
:arrow_down:

...pt/minicart/src/components/Minicart/productList.js
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...icart/src/components/Minicart/emptyMinicartBody.js
60% <ø> (ø)
0 <0> (ø)
:arrow_down:

...t/minicart/src/components/Checkout/editableForm.js
4% <0%> (ø)
0 <0> (ø)
:arrow_down:

...pt/minicart/src/components/Checkout/addressForm.js
23.52% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rt/src/components/Checkout/paymentMethodSummary.js
28.57% <0%> (ø)
0 <0> (ø)
:arrow_down:

...cript/minicart/src/components/Checkout/overview.js
9.09% <0%> (ø)
0 <0> (ø)
:arrow_down:

... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e47bfe...6f32e26. Read the comment docs.


Updating Codeowners to manage access and deployment

TL;DR
Update codeowners, to team members who are managing the service now

👍


Fix the issue of energy dispersion interpolation

This pull request fixes the issue #94 about the interpolation of the energy dispersion. With this solution the renormalization is performed along the migration axis. I confirm that this fix works for my Crab samples.

Let me merge this branch to the master since we agreed in the issue #94. It closes #94 .


utils: Also exclude the deprecated kotlin-stdlib from slf4k

Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

This change is

Merging despite the unrelated AppVeyor failure of

Build execution time has reached the maximum allowed time for your plan (60 minutes).


Add missing or incorrect type hints to QueryBuilder

Changes
Update QueryBuilder.stub with missing or incorrect type hints

Thank you for your contribution.
Great to have three more methods.
Could you add some tests?

For sure! Tests you linked asserting return types, how do i go about asserting argument types (for find and aggregate)?

Thank you!


Edge Functions Don't Work With Custom Domain

While using a custom domain with the JS client, Edge Functions do not work.  Switching back to the Supabase URL works.

Yes, looks like the JS client library uses the configured SUPABASE_URL to make the request while functions are only reachable using the default domain. I have not found any Supabase CLI flags to deploy with a custom domain nor any settings in the dashboard to change the domain of a deployed function.


Lithuanian language pack no longer on Google Play

There isn't available to download lithuanian language pack on Playstore. I remember, there always was that pack, but for quite long time it's gone.

This is a duplicate of #168. The pack is now resurrected, and we're working on transitioning its ownership.


feat: add text for location target info

Adds text for location icon.
See: https://github.com/Problematy/goodmap/issues/136

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 72.569%

Totals

Change from base Build<PHONE_NUMBER>2:
0.1%

Covered Lines:
168

Relevant Lines:
230

💛  - Coveralls


Image placeholders don't work in IE 11

When I tried this, it looked like the blurred SVG placeholder wasn't being clipped, resulting in it extending over the surrounding text. Maybe I can just hide the SVG elements on IE.

e1c8ec07b90d425271a6740212d05a2df9f2dc27 hides the placeholders.


perf: adds --no-deploy (when appropriate) to hardhat fork command

What I did
Updated HardhatForkProvider to use --no-deploy when running hardhat node --fork [...] when the hardhat-deploy plugin is installed to prevent contract deployments from being automatically run.
How I did it

HardhatProvider now loads package.json and reads the installed Hardhat plugins (assuming hardhat- package prefixes)
If no_deploy is set to true (default), and the hardhat-deploy plugin is installed, it will add --no-deploy option to the hardhat node [...]

How to verify it
pytest

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

@unparalleled-js so that type check failure doesn't seem related to my PR (I didn't touch pyyaml at all).  Is this something you'd want me to address in this PR?
I was able to get my pre-commit hook working locally  with this change to .pre-commit-config.yaml :
-        additional_dependencies: [types-requests]
+        additional_dependencies: [types-PyYAML, types-requests]

But I don't think that will fix the GH Action.  Looks like types-PyYAML is installed in the job so it's not immediately clear why this would fail.

@unparalleled-js I think I addressed your feedback.  I also added a couple of changes to .pre-commit-config.yaml you should be aware of that fixes some issues I was having using the pre-commit hooks.

Err, I completely forgot about the config key change.  Will have that up a little later.

Okay, should be all set now.  Thanks for the feedback.

Addressed your other feedback, btw.


Parse/combine the results of coloc_runner.py

This script concatenates the results of running coloc_runner.py (output is per gene) into a single CSV file.

batch: https://batch.hail.populationgenomics.org.au/batches/445369


Loader states

Hi, this is great work.
I think it would be a great idea to also incorporate a isLoading prop to control any loading states? Wdyt @anatoliygatt ?

Hi @TheGooner93. Thank you, glad you liked it!
I'm not sure what it's actually for, nor have I ever seen this pattern being used in any of the libraries that are implementing form inputs (including toggle switch).
I can see two possible use cases where isLoading might be useful, but we can easily overcome it with the already existing attributes and best practices:

If you want to make a toggle switch's state immutable while submitting a form, you can use a disabled or an aria-disabled attribute for this very purpose.
If you want to load a form's state from an API, you shouldn't display a form in an unknown state in the first place. Use some sort of a loading spinner and then render the whole form whenever its state will become available.

Let me know what you think!

Yeah what I'm thinking of is your point regarding integration with an API. Suppose toggling this switch is not being used as part of a form, but as a standalone input to perform an action ( for eg.  adding a product to a wishlist in an ecommerce website) then a loading state would be sensible.
The loading state within the input(as opposed to an entire page loading) would be definitely optional and nice to have. Feels like better UX too imo

I see. In this case, I would use another best practice, optimistic UI. Think of a "Like" button on Twitter, when you click on it, it will animate immediately and then if something goes wrong, it will just restore itself to the original state and show some sort of toast with an error message.

Yes exactly. I do have a PR ready for this. I will update once I fix the snapshot tests.

Well, PR is not required here. When implementing optimistic UI you can, for example, set checked to true immediately and then set it back to false if an error is returned from an API.

Ah I see what you mean. Lets close this issue then


Require 2FA for admin login

Closes #534

Coverage remained the same at 88.543% when pulling 6b8a85631e6821d162f44374d56a365f571b0e98 on enable-2fa into c7444afbccb3819eded663362ac64d90f75ad901 on master.

Replaced by https://github.com/gnosis/safe-transaction-service/pull/753


[Fix #10103] Add AllowHttpProtocol option to Bundler/InsecureProtocolSource

Fixes #10103.
This PR adds AllowHttpProtocol option to Bundler/InsecureProtocolSource.
This AllowHttpProtocol option is true by default for safe autocorrection.
If user don't allow http://, set false to the option.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks @koic

Looks good. Thanks!


Latest 1.9.x branch: user.cshtml throws MissingMethodException for ItemDisplayText

I tried to upgrade a local website (1.9-int branch) to the latest 1.9.x. branch.
I can't run the website at all with these changes. user.cshtml throws an exception at startup:
System.MissingMethodException: Methode niet gevonden: System.Web.Mvc.MvcHtmlString Orchard.Mvc.Html.ContentItemExtensions.ItemDisplayText(System.Web.Mvc.HtmlHelper, Orchard.ContentManagement.IContent).
About a week ago, this was merged to the 1.9.x branch:
https://github.com/OrchardCMS/Orchard/pull/5313/files
As you can see, the signature of ItemDisplayText changed from:
public static MvcHtmlString ItemDisplayText(this HtmlHelper html, IContent content)
to
public static MvcHtmlString ItemDisplayText(this HtmlHelper html, IContent content, bool encode = true)
The call in user.cshtml is:
@Html.ItemDisplayText(WorkContext.CurrentUser)
Since 'encode' is an optional parameter, I'm not sure why this isn't working... But it doesn't (or at least not on my machine).
When optimizeCompilations is set to 'false' in web.config, it runs fine. Does razor has issues with optional parameters?

I can confirm that I'm seeing this error message in my logs on a 1.9.x site.

Please try again.

That commit was wrong - you forgot to pass the HtmlHelper along.
public static MvcHtmlString ItemDisplayText(this HtmlHelper html, IContent content) {
    return ItemDisplayText(html, content, true);
}

New PR #5351 5351


When using Vulkan rendering for Android, app presents black screen when resuming.

Describe the bug
When using the app and then navigating away from the app (to home screen, app switcher, or locking device) causes the app to display a black screen when reopened. This only occurs with Vulkan rendering enabled, and does not when using the default EGL rendering. I have not tested software rendering.
To Reproduce
Modify xplat template MainActivity.cs to have the following app builder code
        return base.CustomizeAppBuilder(builder).With(new AndroidPlatformOptions
        {
            RenderingMode = new [] { AndroidRenderingMode.Vulkan }
        }).UseReactiveUI();

Run app on a physical android device, navigate away and then back to app.
Expected behavior
The app resumes without issue.
Avalonia version
11.1.1
OS
Android
Additional context
See my related discussion post here:
https://github.com/AvaloniaUI/Avalonia/discussions/16717

We are probably not handling device loss condition for Vulkan yet. Suspend/Resume is likely to trigger those

Could you test with the latest nightly builds?

I have tested with the nightly builds (11.2.999-cibuild0051406-alpha) and can confirm that the bug still persists.


Add new header to tar files

See https://github.com/ipfs/js-ipfs-api/issues/263

What actually needs to be done here? Its not entirely clear from the linked issue. cc @diasdavid

@whyrusleeping https://github.com/ipfs/js-ipfs-api/issues/263#issuecomment-218784226 and https://github.com/ipfs/go-ipfs/issues/1824

Ah, okay, so issue https://github.com/ipfs/go-ipfs/pull/2427


bug: cp.asarray out of memory [5.0.0b4]

import numpy as np
import cupy as cp

# c = cp.zeros((3001000, 600), dtype=np.float32)  # no bug if alloc directly

n = np.zeros((3001000, 600), dtype=np.float32)
c = cp.asarray(n)

cupy.cuda.runtime.CUDARuntimeError: cudaErrorMemoryAllocation: out of memory
cupy                      5.0.0b4
(BTW, same code no problem with previous version v4.x)
Ubuntu 16.04.5 LTS
cuda-9.1
$ nvidia-smi
Mon Aug 27 19:37:43 2018
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 396.44                 Driver Version: 396.44                    |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX TIT...  Off  | 00000000:01:00.0  On |                  N/A |
| 22%   40C    P8    16W / 250W |    100MiB / 12205MiB |      1%      Default |
+-------------------------------+----------------------+----------------------+
|   1  GeForce GTX TIT...  Off  | 00000000:02:00.0 Off |                  N/A |
| 22%   29C    P8    13W / 250W |      1MiB / 12212MiB |      0%      Default |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                       GPU Memory |
|  GPU       PID   Type   Process name                             Usage      |
|=============================================================================|
|    0      2407      G   /usr/lib/xorg/Xorg                            98MiB |
+-----------------------------------------------------------------------------+

maybe np.float32 is missed in cp.asarray call (become np.float64)?

cupy.cuda.runtime.CUDARuntimeError: cudaErrorMemoryAllocation: out of memory

Could you share the full stack trace?

$ python3 cupybug.py
Traceback (most recent call last):
File "cupy/cuda/pinned_memory.pyx", line 303, in cupy.cuda.pinned_memory.PinnedMemoryPool.malloc
File "cupy/cuda/pinned_memory.pyx", line 177, in cupy.cuda.pinned_memory._malloc
File "cupy/cuda/pinned_memory.pyx", line 178, in cupy.cuda.pinned_memory._malloc
File "cupy/cuda/pinned_memory.pyx", line 29, in cupy.cuda.pinned_memory.PinnedMemory.init
File "cupy/cuda/runtime.pyx", line 228, in cupy.cuda.runtime.hostAlloc
File "cupy/cuda/runtime.pyx", line 134, in cupy.cuda.runtime.check_status
cupy.cuda.runtime.CUDARuntimeError: cudaErrorMemoryAllocation: out of memory
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "cupybug.py", line 8, in
c = cp.asarray(n)
File "/miniconda3/lib/python3.6/site-packages/cupy/creation/from_data.py", line 60, in asarray
return core.array(a, dtype, False)
File "cupy/core/core.pyx", line 2174, in cupy.core.core.array
File "cupy/core/core.pyx", line 2213, in cupy.core.core.array
File "cupy/cuda/pinned_memory.pyx", line 212, in cupy.cuda.pinned_memory.alloc_pinned_memory
File "cupy/cuda/pinned_memory.pyx", line 286, in cupy.cuda.pinned_memory.PinnedMemoryPool.malloc
File "cupy/cuda/pinned_memory.pyx", line 308, in cupy.cuda.pinned_memory.PinnedMemoryPool.malloc
File "cupy/cuda/pinned_memory.pyx", line 177, in cupy.cuda.pinned_memory._malloc
File "cupy/cuda/pinned_memory.pyx", line 178, in cupy.cuda.pinned_memory._malloc
File "cupy/cuda/pinned_memory.pyx", line 29, in cupy.cuda.pinned_memory.PinnedMemory.init
File "cupy/cuda/runtime.pyx", line 228, in cupy.cuda.runtime.hostAlloc
File "cupy/cuda/runtime.pyx", line 134, in cupy.cuda.runtime.check_status
cupy.cuda.runtime.CUDARuntimeError: cudaErrorMemoryAllocation: out of memory

Thanks for the details.
This out of memory error is coming from pinned memory allocator (i.e. your host memory is not enough). In v4.2.0 and v5.0.0b2, we changed the allocation strategy of pinned memory; the allocation size is now round-up. Prior to these versions, your code requires<PHONE_NUMBER>4 (approx. 7.2 GB) host memory, whereas 8.0 GB in and after these versions.
We originally thought this change does not affect most of users, but you are affected ;)
After discussion with @okuta, we decided to implement a workaround for this case.  Thanks again for reporting this.

Thanks. Yes, extra 0.8G, or 10% of the memory required is a bit too much.

@mingwugmail #1593 fixed this issue and will be included in the next release.


HTTP 400 error

Get this error when trying to log into  1.8.0 using the same log in I use for 1.7.0
I can still log into 1.7.0 no problem

i am getting that error too. in fact, after i downloaded the new version, i was able to get online for the first time since May 2016. i even had some brief chat with 2 guys before the http 400 error kept appearing constantly (took about 5 times clicking ok before it cleared, i also saw something that said "primus grindr requires authentication" or something like that). and now i cant get online at all. the program WILL open, but everytime i try to connect, this error comes up.
i read in an older thread somewhere, that someone said IF the account is created on fuckr, increases chances it will be banned by grindr. but if a person creates the account on their cell phone or smartphone, reduces the chances of a ban. can anyone confirm if this is true or not?
if this is true, i may try to create a "new" account on my phone and see how it goes. i personally prefer interacting on the computer. i dont know why grindr still wont create their own desktop version.
i have never created a grindr account on my phone, always on fuckr, maybe this is why i keep getting error messages? :peace_symbol:

Same thing, i just got it working for 10min then error http/400, allowing you to search for others but no message or profile setting. Does this error means Grindr banned the account?
My account was created by phone 1 year ago. By the way can someone share a line command that could update all fuckr/nw/npm/... versions and its depedencies?
Sorry for my English I'm French

Seems like since the latest update we are having ban issues. I was using the previous version, as soon as i updated i got banned

@victorgrego
I don't think it's a ban issue, the v2 API has been fully shut down.


Removed causing part in yeld

Hi there
As described in the ticket https://support.swimlane.com/support/tickets/7023 we had the problem, that the search stopped working from version 10.1.3 on. We had problems to have you reproducing the problem since it was tied to specific data on our side. I hence took the liberty of forking your library.
The investigation showed, that our linked applications (see Ticket, entry from the 10th of August) cause the issue. In line 62 of record.py there's an iteration over all fields. The generator in iter called field.get_python(). This call lead to a infinite loop, since a given record1 of App1 points to a given record2 of App2 points to the record1 of App 1 and so on. Including some debugging statements resulted in smth like this:
(<class 'swimlane.core.resources.app.App'>, 'id', 'aJ7PHD19fSvGeduuF')              MissionControl
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aVC2Oo2L3qZudKaiU')        MC-386
(<class 'swimlane.core.resources.app.App'>, 'id', 'aPgWzppJNfcALxlrg')              Customer Management
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aYnF7qwiOWAoujZ86')        CM-1
(<class 'swimlane.core.resources.app.App'>, 'id', 'acrwv2XppnZJfj_Hk')              Customer Specific Message Templates
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aMFBni2nXS2aYwWbL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aRUBEIQYNXO_Y43JL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aZJdTsQ8Fcpqv0d7S')        IGCT-27
(<class 'swimlane.core.resources.app.App'>, 'id', 'aPgWzppJNfcALxlrg')              Customer Management
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aYnF7qwiOWAoujZ86')        CM-1
(<class 'swimlane.core.resources.app.App'>, 'id', 'acrwv2XppnZJfj_Hk')              Customer Specific Message Templates
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aMFBni2nXS2aYwWbL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aRUBEIQYNXO_Y43JL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aZJdTsQ8Fcpqv0d7S')        IGCT-27
(<class 'swimlane.core.resources.app.App'>, 'id', 'aPgWzppJNfcALxlrg')              Customer Management
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aYnF7qwiOWAoujZ86')        CM-1
(<class 'swimlane.core.resources.app.App'>, 'id', 'acrwv2XppnZJfj_Hk')              Customer Specific Message Templates
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aMFBni2nXS2aYwWbL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aRUBEIQYNXO_Y43JL')        none
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aZJdTsQ8Fcpqv0d7S')        IGCT-27
...
(<class 'swimlane.core.resources.record.Record'>, 'id', 'abLprrTYneTuFxP3E')        MC-300
(<class 'swimlane.core.resources.app.App'>, 'id', 'aeGhvd7AXYl2b_3OJ')              Messages
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aDAVK_hVpnZd7_Fgp')        IGCC-66
(<class 'swimlane.core.resources.app.App'>, 'id', 'aJ7PHD19fSvGeduuF')              MissionControl
(<class 'swimlane.core.resources.record.Record'>, 'id', 'abLprrTYneTuFxP3E')        MC-300
(<class 'swimlane.core.resources.app.App'>, 'id', 'aeGhvd7AXYl2b_3OJ')              Messages
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aDAVK_hVpnZd7_Fgp')
(<class 'swimlane.core.resources.app.App'>, 'id', 'aJ7PHD19fSvGeduuF')
(<class 'swimlane.core.resources.record.Record'>, 'id', 'abLprrTYneTuFxP3E')
(<class 'swimlane.core.resources.app.App'>, 'id', 'aeGhvd7AXYl2b_3OJ')
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aDAVK_hVpnZd7_Fgp')
(<class 'swimlane.core.resources.app.App'>, 'id', 'aJ7PHD19fSvGeduuF')
(<class 'swimlane.core.resources.record.Record'>, 'id', 'abLprrTYneTuFxP3E')
(<class 'swimlane.core.resources.app.App'>, 'id', 'aeGhvd7AXYl2b_3OJ')
(<class 'swimlane.core.resources.record.Record'>, 'id', 'aDAVK_hVpnZd7_Fgp')
(<class 'swimlane.core.resources.app.App'>, 'id', 'aJ7PHD19fSvGeduuF')
(<class 'swimlane.core.resources.record.Record'>, 'id', 'abLprrTYneTuFxP3E')
Since I was not able to find a usage of the part "field.get_python()", I removed it. All unit tests were green afterwards. But I did not run the functional test, since the setup would cost me another couple of hours.
So please double check this change and run the functional tests. It might also be good to include our data constellation into the tests (most likely into the functional tests). Please let me know, if you want a db dump for a reproducer.
Feel free to contact me at any time and tnx for the review, Ingo

@ingoguard this should be fixed by https://github.com/swimlane/swimlane-python/pull/114 now. Once we verify and test it, we'll release a new version of swimlane-python which you can install in your python packages tab on the integrations page.


Feat: Adding a Zomato Scraper

Describe the feature
This Zomato Scraper will allow you to scrape data of a restraunt listed on Zomato
The scrapper will scrape details like name of restraunt, menu items and their prices etc.
This scraper will work on Selenium as Zomato does't allow to scrape their site normally
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC 23 contributor
[X] I want to work on this issue

Go ahead @Swapnil-Singh-99
Note

Create a separate module for this, as per the folder and project structure
Do not use the `selenium web driver as it is not compatible with all devices as well as cloud platforms.
Before making any changes, check if the module you want to add already exists or not. If yes, then add your functionality as a method only else make a separate module and class for it.

All the best 👨💻


bump versions to remove semver warnings

semver was complaining cause it didn't have any numbers to work with. so made initial version numbers for the affected repos. There are no functional changes, just added release numbers to what we were already pulling.
EDIT: unfortunately this won't remove the warnings. It won't be fixable until we convert the sqlops extension and the dataprotocol node repos into npm packages.

unfortunately this won't remove the warnings. It won't be fixable until we convert the sqlops extension and the dataprotocol node repos into npm packages.

Yeah i'm going to close this cause it doesn't seem like it actually does anything useful


file_input works on your example site, not with local example code.

Hi. When I use your site and select an image, here, http://serratus.github.io/quaggaJS/examples/file_input.html I am  able to get the code from the image, but when I use the file_input.js, quagga.js and the file_input.html code locally, I am not able to decode the image. The image is being processed, but I never get to the onDetected event. Am I missing something, or is there a way to debug the process?
Thanks

@attentiondotnet How did you solve the problem? Maybe some security-restrictions when using file:// protocol?


Unhandled Exception in Saving Feature List task

Basic information

My operating system and version: Mac OS X 12.6.1
My MZmine version: 3.2.8

What happened
Attempting to save my project led to the following error:

Project: I have 48 DDA files whose MS/MS spectra I would like to gather into a single .mgf file.
Actions taken:
Raw data import → Mass Detection (MS = 1) and Mass Detection (MS = 2) → MSn feature list builder → 13C Isotope Filter → Join Aligner → Export as GNPS - Feature Based Molecular Networking
Attempting to save my project at this stage leads to the error in the screenshot.

Hi hhabra, thanks for reporting the issue.
can you test the auto build from this PR and let us know if it works?
https://github.com/mzmine/mzmine3/pull/995

Hello Steffen,
Unless I did things incorrectly, I'm afraid I'm getting the same error (I pulled repository with git and built using ./gradlew). The version of the app appears to be 3.2.53.

Is it chromatography data? Then you should consider using the local minimum resolver or similar to split the chromatograms into features.
Another way to download is to scroll down here:
https://github.com/mzmine/mzmine3/actions/runs/3468498870

Yes, it is liquid chromatography data. Are the peak resolving steps necessary if I only want to gather the MS2 data into a MGF file? My current process is: Raw data import → Mass Detection (MS = 1) and Mass Detection (MS = 2) → MSn feature list builder (MS level = 2) → 13C Isotope Filter → Join Aligner → Export as GNPS - Feature Based Molecular Networking
The issue is that MZmine is not able to save the results of MSn feature list builder as a project. Saving a batch file works fine I think, but not the chromatogram files.

We will release a new version soon and hope this is fixed there but might be a more specific problem. So please try the version once pushed. Thanks you.


Technologies for creative industries, social media and convergence

Look into the "Technologies for creative industries, social media and convergence" research project the guys from Greece want us to partner on:
http://ec.europa.eu/research/participants/portal/desktop/en/opportunities/h2020/topics/9085-ict-19-2015.html
High level summary of due date for proposals, potential dollar value of awards, themes or areas of focus for the grants, date by which work must be complete, that kind of thing.

Read latest proposal before Thursday call.


Camfib webpage generation

Refactors webpages.camfiber to separate the html file generation into two functions (for fibernum and focalplate)
This also prevents issues with newer versions of bokeh that don't allow the same column data source object to be used in multiple layouts

Ready to merge, tested on a few exposures

refactored summary camfib plots to update plot_components dictionary in summary.py
updated summary template to include one large gridplot object for camf iber metric plots instead of multiple small ones
this also addresses the issue in newer versions of bokeh which prevent sharing columndatasource objects across multiple gridplots

success.  thanks.  merging now.


CORS ERROR while creating a POST request on 'https://lib.openlaw.io/api/v1/default/app/login' from localhost or public IP

Earlier, I was able to get the access token from OpenLaw API, but now I am facing this error while login From the Angular framework.
I changed the host from <IP_ADDRESS>:4200 to 192.168.1.x:4200, but nothing works.
Anybody else faced this issue, please update.

You usually see a CORS error if the login fails. What url are u using to log in?

Login URL: https://lib.openlaw.io/api/v1/default/app/login
private apiClient = new APIClient("https://lib.openlaw.io/api/v1/default");     let adminEmail =<EMAIL_ADDRESS>    let password = "xxxxxx";     this.apiClient.login(adminEmail, password);

usually you get a CORS error if there was another issue previously. When the server returns an error (5xx or 4xx http code) then the header for CORS is not added and you see this error.
Do you see another error in the network logs ?


fix empty configs on initial install

Updates creation of config files so that audiorecorder doesn't have to be run twice on initial install to have config settings reflected in files.
Assigns some default values to config
Exits after config settings made (doesn't auto continue to capture)

thanks @ablwr! I'll let this hang a bit more and then merge/make new release


Xp 273 scripts cleanup

References
XP-273 Cleanup scripts folder, check docker files
Summary
Audit the shell scripts in the scripts directory and clean them up if needed:

[x] create_git_hooks.sh: kept as is
[ ] ls_running_instances: I need some credentials to run this command? But it seems a little weird to have that script in a public repo so I'd be enclined to remove it altogether.
[X] format.sh: minor changes
[X] rm_cache.sh: minore changes
[X] test.sh: kept as is
[X] test_slow.sh: removed
[X] setup.sh: removed
[X] setup_pyenv.sh: removed

Reviewer checklist
Reviewer agreement:

Reviewers assign themselves at the start of the review.
Reviewers do not commit or merge the merge request.
Reviewers have to check and mark items in the checklist.

Merge request checklist

[X] Conforms to the merge request title naming XP-XXX <a description in imperative form>.
[x] Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
[x] Linked the ticket in the merge request title or the references section.
[X] Added an informative merge request summary.

Code checklist

[x] Conforms to the branch naming XP-XXX-<a_small_stub>.
[x] Passed scope checks.
[x] Added or updated tests if needed.
[x] Added or updated code documentation if needed.
[x] Conforms to Google docstring style.
[x] Conforms to XAIN structlog style.

Thanks for updating the scripts. Also agree to the removing of ls_running_instances.

Done!

rebased


[EPIC] New feature: Notes

Description:
Note taking is a common task for personal information management tools.
Implement basic note features:

Add note
Edit note
Delete note
View note
List notes

Note properties:

Id
Title
Content
Category
Author
Created time
Updated time
Tags

Author is the user id provided by the login.
Only the author
Times should be persisted as UTC times, they can then be converted to user time zones for display purposes.
For now note content will be plain text only, so we don't have to consider sanitizing or formatting content, as well as storing resources (images, attachments,).

Completed the notes feature implementation, see:
https://github.com/KinaUna/Examplium/tree/master/Documentation/Code/Notes


Change favicon for Inbox tab to airy icon

Currently, the tab icon for the Inbox is a black and white globe. We should change this so that the Airy icon is displayed on the tab instead (the icon on the right tab in the image).

this problem turns out to be a Bazel build issue.


the resoult  is not good by combining llama2 and sd

thanks for sharing this good project. i want to generate the picture by using language model.
i download the llama2-7b and the adapter as provided, but the resoult i got is not as good as the paper shows.  so i want to know what's the precision about llama2-7b and sd-v1.4 models. i can see the code that is using llama2-7b in fp16, but not sure for the vae and u-net ,
i tested in fp32 and fp16, the picture style and detail is pretty strange.

You can perform inference according to the settings provided in the script. Considering that our training data includes both low-quality COCO data and high-quality internal data, we recommend using descriptive words in prompts to enhance the quality of generated images, as this aligns better with the distribution of our high-quality internal dataset. You can refer to the prompts in the paper for further guidance. You can also refer to the Section D in the appendix of our research paper.

Thank you for your interest in our LaVi-Bridge! In our experiments, we utilize fp16 for obtaining the text embedding and subsequently convert it to fp32 for image generation, following the same way as shown in the script. We have made some updates, so please update the repository and give it another try.


Created a short URL

I did it for my Python book, but I guess I could as well include it here, just in case. Easier to remember, too. It's using Github's own shortener, check it out, it's quite nifty.

Hi @JJ thanks - which book is that?

This one
https://www.amazon.es/dp/B073T47421/ref=sr_1_4?s=books&ie=UTF8&qid=1499598466&sr=1-4&keywords=jj+merelo
It's in Spanish :-)

o.k. - sadly I don't speak spanish :(
BTW: We already have a another short url provided by another user: https://github.com/pyenv/pyenv-installer/issues/41


Verify memory access fault

Randomly assert error bit for instruction fetch and load/store.
Expect the core to raise memory access fault exception
Verify the fault load instruction won't modify GPR
Verify the context of the exception is captured correctly in privileged CSRs

mstatus, mcause, mepc, mtval

Also see #87

This feature of the core has been tested, finding a bug regarding to a prefetcher error after an I-Mem fault, and a bug regarding faulting misaligned data memory accesses. Fixes have been merged for these bugs, so will close this tracking issue.


[Refactor] Spelling Mistakes

File Name
backend/testing.json, other/roadmaps.json, placement_prep/job-portals.json
Reason for Refactoring the Code
These are few spelling mistakes which I noticied at first sight.
LinkdedIn -> LinkedIn
plaform -> platform
fronted -> frontend
Backned -> Backend
Additionally I would suggest to add few extensions like code spell checker in LinksHub Contributing Guidelines.
Checklist

[X] I have checked the existing issues.
[X] I have read the Contributing Guidelines.
[X] The changes don't break the code and don't introduce new functionality.
[X] I am willing to work on this issue (optional).

I have already resolved these, will raise PR once you assign these to me.

I have already resolved these, will raise PR once you assign these to me.

sure, assigning it to you!

@rupali-codes and @anantgna, we already have a spellchecker extension: https://github.com/rupali-codes/LinksHub/blob/main/.github/workflows/spellcheck.yml

Okay @CBID2.

Okay @CBID2.

Maybe you can improve it @anantgna?

Oay will have a look at this @CBID2


Please could the provider support the User ID Authenticated checkbox within the Options selector for a Policy

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
Please can the provider support the setting of the User ID Authenticated checkbox within the Options selector for a Policy please. This was introduced in PF10 (and we've just upgraded from PF9 so found it!).
Normal authentication is fine without setting this value - however, when you have a PingID adapter then if you don't tick the checkbox (which relates to the incoming userID from an HTMLForm adapter, the previous step in our policy) then new users (or users pairing a new device) never get prompted for the enrollment process... so always fail authentication!
New or Affected Resource(s)

/authenticationPolicies
Potential Terraform Configuration
I suspect that the config should be something like the following...
              input_user_id_mapping {
                source {
                  type = "ADAPTER"
                  id   = pingfederate_idp_adapter.emp_all_attrs_form_adapt.id
                }
                value = "UserPrincipalName"
                useridauthenticated = true
              }

References

https://docs.pingidentity.com/r/en-us/pingfederate-112/pf_specify_incoming_user_ids   (point 5)

duplicate of #215


[Bug]: ValueError: Client secrets must be for a web or installed app

Bug Description
Hi, I am using llama-index-readers-google = "^0.2" in my project and I am getting this error:
    flow = InstalledAppFlow.from_client_config(self.client_config, SCOPES)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/google_auth_oauthlib/flow.py", line 159, in from_client_config
    raise ValueError("Client secrets must be for a web or installed app.")
ValueError: Client secrets must be for a web or installed app.

When I was using llama-index-readers-google = "^0.1.7", I could read Google Docs from my Google Drive using the credentials.json service account token.
Now with llama-index-readers-google = "^2.0" it's as if I need to use an OAuth token for it to work, because when I use an OAuth token it directs me to a browser page with an error saying that it couldn't authenticate me instead of raising this error on console log I mentioned above
My code is:
def setup_ingestion_pipeline():

        vector_store = RedisVectorStore(
            index_name="redis_vector_store",
            index_prefix="vector_store",
            redis_url="redis://localhost:6379",
        )

        cache = IngestionCache(
            cache=RedisCache.from_host_and_port("localhost", 6379),
            collection="redis_cache",
        )

        pipeline = IngestionPipeline(
            transformations=[
                SentenceSplitter(),
                Settings.embed_model,
            ],
            docstore=RedisDocumentStore.from_host_and_port(
                "localhost", 6379, namespace="document_store"
            ),
            vector_store=vector_store,
            cache=cache,
            docstore_strategy=DocstoreStrategy.UPSERTS,
        )

        index = VectorStoreIndex.from_vector_store(
            pipeline.vector_store, embed_model=Settings.embed_model
        )

        loader = GoogleDriveReader("./credentials.json")
        . . .
        . . .

I was following this doc https://docs.llamaindex.ai/en/stable/examples/ingestion/ingestion_gdrive/
Is there any recent doc or README of llama-index-readers-google = "^0.2" or any solution to this problem?
I also tried to change llama-index version several times but it didn't help.
I also commented on another post about an issue that forced me to change to llama-index-readers-google = "^0.2" and that is very strange because one day my code was running ok in dev environment and another day after cloning again my project and executing a poetry install with the same pyprojec.toml my code broke as follows: https://github.com/run-llama/llama_index/issues/12750#issuecomment-2051871742
Version
0.10.28
Steps to Reproduce
Follow this https://docs.llamaindex.ai/en/v0.10.23/examples/ingestion/ingestion_gdrive/ using llama-index-readers-google = "^0.2"
pyproject.toml is:
[tool.poetry.dependencies]
python = "^3.10"
flask = "^3.0.2"
llama-index = "^0.10.20"
python-dotenv = "^1.0.1"
llama-index-storage-docstore-redis = "^0.1.2"
llama-index-vector-stores-redis = "^0.1.2"
llama-index-readers-google = "^0.2"
docx2txt = "^0.8"
schedule = "^1.2.1"
llama-index-storage-chat-store-redis = "^0.1.2"
gunicorn = "^21.2.0"
flask-cors = "^4.0.0"

Relevant Logs/Tracbacks
Traceback (most recent call last):
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/arbiter.py", line 609, in spawn_worker
    worker.init_process()
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/workers/base.py", line 134, in init_process
    self.load_wsgi()
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/workers/base.py", line 146, in load_wsgi
    self.wsgi = self.app.wsgi()
                ^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
                    ^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
    return self.load_wsgiapp()
           ^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
    return util.import_app(self.app_uri)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/gunicorn/util.py", line 371, in import_app
    mod = importlib.import_module(module)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/anaconda3/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/yago-janos/Desktop/AgoraVai/projeto-ia-hub/hub_ia/api/app.py", line 36, in <module>
    init_app()
  File "/home/yago-janos/Desktop/AgoraVai/projeto-ia-hub/hub_ia/api/app.py", line 19, in init_app
    execute_ingestion()
  File "/home/yago-janos/Desktop/AgoraVai/projeto-ia-hub/hub_ia/rag/rag.py", line 17, in execute_ingestion
    docs = loader.load_data(folder_id=folder_id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/llama_index/readers/google/drive/base.py", line 511, in load_data
    self._creds = self._get_credentials()
                  ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/llama_index/readers/google/drive/base.py", line 170, in _get_credentials
    flow = InstalledAppFlow.from_client_config(self.client_config, SCOPES)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/yago-janos/.cache/pypoetry/virtualenvs/hub-ia-tauPM_lo-py3.11/lib/python3.11/site-packages/google_auth_oauthlib/flow.py", line 159, in from_client_config
    raise ValueError("Client secrets must be for a web or installed app.")
ValueError: Client secrets must be for a web or installed app.
[2024-04-12 18:42:12 -0300] [717992] [INFO] Worker exiting (pid: 717992)
[2024-04-12 18:42:12 -0300] [717982] [ERROR] Worker (pid:717992

Solved, it's not a bug, now we have to use 'service_aacount_key_path' on
loader = GoogleDriveReader(service_account_key_path="./credentials.json")


2.14.2 Windows Tray Icon Weird

My Setup

Operating System: Windows 10 - 1703
App Version: 2.14.2
Installation type: exe

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description
Icon is almost useless on resolution 1920x1200
Current Behavior
Icon always stay Red with small green dot.
What this green dot mention - if status, then not changed when I change status
When new messages arrives - only small red circle with white dot or number showing - very hard to notify when new messages exists
Expected Behavior
Restore older bahavior - 2.10.x
When no new messages  - black/gray icon
When new non-personal messages arrived - red icon
When new mentions or personal messages - red icon with big green number

For @-mentions or direct messages, it would be okay to blink up to three times in quick succession, especially if the user has the capability to turn off that feature. However, I don't think it's needed, since Rocket.chat already provides the capability for desktop notifications.
Continuous blinking would be extremely distracting.

Here's a screenshot of my taskbar and notification area, showing why the current icon is so jarring:

The red colour, white background, and green dot all draw the eye, making it look as though there must be something important down there. But this is what it looks like when I'm completely caught up!
The "nothing to see" state needs to be much more muted. Black/grey, as the original poster suggests, or white, possibly with a thin black background. Red is the colour of alerts.

In Windows 7, the gray icon in the notification panel (especially when it is hidden) becomes almost invisible. The problem with the gray icon (it’s not possible to see it in Windows 7) has already been raised here several times. Gray icon is a bad option.

In Windows 7, the gray icon in the notification panel (especially when it is hidden) becomes almost invisible. The problem with the gray icon (it’s not possible to see it in Windows 7) has already been raised here several times. Gray icon is a bad option.
The red icon is clearly visible in the panel.

I have seen those complaints - A black or dark-grey stroke around or shadow behind the icon would solve the issue, without having to resort to red, which we have become accustomed to meaning that there is a message waiting for us.

In Windows 7, the gray icon in the notification panel (especially when it is hidden) becomes almost invisible. The problem with the gray icon (it’s not possible to see it in Windows 7) has already been raised here several times. Gray icon is a bad option.
The red icon is clearly visible in the panel.

I have seen those complaints - A black or dark-grey stroke around or shadow behind the icon would solve the issue, without having to resort to red, which we have become accustomed to meaning that there is a message waiting for us.

I think it's just a matter of habit. Now on the tray icon display two additional icons. One for messages in the channels and one for direct messages. This is very convenient (users like different indicators for direct messages and for groups).

Because main icon in all 3 states stays Red/White, it is hard to notify when status changed. Also on high resolutions, those additional circle (for group) and numbers (for mentions), which also Red/White, looks so small to be alerted

As others have already said, when there's nothing new, the red icon is quite prominent and catches the eye. To cite the WIndows UX guidelines for the notification area:

"If you use notifications, make it a good user experience. Don't try to force users to see your notifications. If users are so immersed in their work that they don't see your notifications, your design is good."
https://docs.microsoft.com/en-us/windows/desktop/uxguide/mess-notif

However, what makes the red icon even less usable is the fact that it doesn't really stand out anymore when there is something new...

Regarding the green dot, I also don't think that it's very useful. At least for me, "being online" is the default, so I don't need information about that. Maybe it makes sense, to add an overlay if you're in any other status 🤷♂

I guess I don't have any constructive suggestion besides: please restore the old behavior

The old behavior is bad for installations on Windows 7. Look at this issue #852 for demonstration.
It will be good if there is an option that solves both problems. Without this, a return to the old will return a big problem with an invisible icon in Windows 7. Old problem with Windows 7 icon is more significant than problem with red icon.

Funny enough - look at the flag icon right above where "Rocket Chat" is supposed to be sitting.  The grey stroke around the flag...  Why not go that route, like other Windows 7 compatible apps with white icons?

(green dot stays green even if you are busy, away, or invisible - no idea what that dot actually does)

I don't know why developers didn't do so. May be there were some problems. If it possible to do white icon with some black line around it then it would be great.

I just tried to simulate the issue on Windows 10 by giving the task bar a light color and indeed, Slack is doing the same:

@luchsamapparat I honestly surprised by these monochromatic icons on Windows 10. AFAIK, Electron just support template icons (monochromatic and adaptive to the system theme) for MacOS.

Hey everyone, We've made a new version to fix these issues. The idea is the tray to be subtle and works on any background colour so we changed it to grey.
The normal status is just the rocket icon and the user has a mention will appear a grey circle.

In my opinion, It should be grey, unless there is an actual notification.  Then you can splash some color to it to indicate that there is something that needs attention.
As long as it still will catch attention when attention is needed, then I think this is a fantastic change.

That one can be grey :-)

If icon stays grey all the time - it will be more unusable than now (IMHO)

We've changed the circle from grey to red. I t'll appear when the user has an @mention or private message.

@brunosquadros what about badge with number of unread messages? Red circle is not the same as badge with a digit

@brunosquadros what about just unread messages, not @-mentions or private?
Also this type of notification (red cirlce etc.) can be more bigger by size.

@sergeydeg For some workflows, you need to differentiate them. I'm myself subscribed in my channels with constant conversation which very occasionally need my attention.

@tassoevan Hi!
The current behavior is that where there is a new message in a channel where I'm member of, I get a red dot. When someone mentions me or DM me, I get a red dot with a badge.

First of all it is really hard to distinguish if there is a dot or a badge on a small screen.
Second it would be really cool if I could turn of "Notification" completely for a channel. So that I do not even get a red dot. I mean I really don't need to have a red dot just because some channel I'm member of is written to, without even mentioning me.

What you think?

I' d disable change of task bar icon in any condition and keep tray icon changes? Is there an option?


Dimitri sync with main

Sync with main branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.4 out of 27 committers have signed the CLA.:white_check_mark: matthewdupre:white_check_mark: lx1036:white_check_mark: doublek:white_check_mark: dimitri-nicolo:x: Michael Zappa:x: dcbw:x: silenceper:x: mjwaxios:x: dpward:x: squeed:x: tklauser:x: AkihiroSuda:x: mmirecki:x: gojoy:x: fwiesel:x: benmcmahon100:x: devbv:x: danwinship:x: akhilles:x: aristaMircea:x: mansikulkarni96:x: jpsim:x: Kern--:x: joejulian:x: jingyuanliang:x: MikeZappa87:x: EmilyShepherdMichael Zappa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Dummy PR to test allocated container resources for PR check - RHINENG-11566

…-11566
## Secure Coding Practices Checklist GitHub Link
- https://github.com/RedHatInsights/secure-coding-checklist

## Secure Coding Checklist
- [ ] Input Validation
- [ ] Output Encoding
- [ ] Authentication and Password Management
- [ ] Session Management
- [ ] Access Control
- [ ] Cryptographic Practices
- [ ] Error Handling and Logging
- [ ] Data Protection
- [ ] Communication Security
- [ ] System Configuration
- [ ] Database Security
- [ ] File Management
- [ ] Memory Management
- [ ] General Coding Practices

/retest


Resources can't handle missing fields from Betfair

The following MarketCatalogue JSON was received from Betfair and caused the following error:
{
	"marketStartTime": "2017-06-06T09:00:00.000Z",
	"competition": {
		"id": "11330922",
		"name": "Prostejov Challenger 2017"
	},
	"marketId": "1.132045327",
	"totalMatched": 17.06,
	"marketName": "Match Odds",
	"event": {
		"timezone": "UTC",
		"openDate": "2017-06-06T09:00:00.000Z",
		"id": "28260245",
		"countryCode": "CZ",
		"name": "Marrero/Paes v Knowle/Zelenay"
	},
	"runners": [
		{
			"handicap": 0,
			"runnerName": "Knowle/Zelenay",
			"selectionId": 5717065,
			"sortPriority": 1
		},
		{
			"handicap": 0,
			"runnerName": "Marrero/Paes.",
			"selectionId": 8786145,
			"sortPriority": 2
		},
		{
			"handicap": 0,
			"sortPriority": 3,
			"selectionId": 8781561
		}
	]
}

Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 754, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/aaron/workspace/sportsrisq.traderng/sportsrisq/traderng/feed/betfair_market_feed.py", line 42, in betfair_market_feed
    locale=config.get('markets', {}).get('locale')
  File "/home/aaron/tmp/venv/betfairlightweight/local/lib/python2.7/site-packages/betfairlightweight/endpoints/betting.py", line 158, in list_market_catalogue
    return self.process_response(response, resources.MarketCatalogue, elapsed_time, lightweight)
  File "/home/aaron/tmp/venv/betfairlightweight/local/lib/python2.7/site-packages/betfairlightweight/endpoints/baseendpoint.py", line 100, in process_response
    return [resource(elapsed_time=elapsed_time, **x) for x in result]
  File "/home/aaron/tmp/venv/betfairlightweight/local/lib/python2.7/site-packages/betfairlightweight/resources/bettingresources.py", line 231, in __init__
    self.runners = [RunnerCatalogue(**i) for i in kwargs.get('runners', [])]
TypeError: __init__() takes at least 5 arguments (4 given)

The third runner is missing the runnerName field - which is listed a required field in the Betfair API docs: http://docs.developer.betfair.com/docs/display/1smk3cen4v3lu3yomq5qye0ni/Betting+Type+Definitions#BettingTypeDefinitions-RunnerCatalog
Because of this (and I think rightly so) the constructor for a RunnerCatalogue doesn't have a default value for runnerName: https://github.com/liampauling/betfairlightweight/blob/master/betfairlightweight/resources/bettingresources.py#L190-L195
I'm not really sure what the solution is here - maybe it's just to do nothing and accept that Betfair sends malformed data sometimes - however that will cause a listMarketCatalogue call to error in the above way. If all you want is the JSON then you can avoid it by using the lightweight parameter in the API call.
I have raised a ticket with BDP but I imagine the response will be it was just a mistake.
The bigger question is whether resources should handle fields which are missing which are listed as required in the API specification? It's also a question which I don't have the answer to :)

From BDP:

Hi Aaron,
I have had a reply from our market operators, there was an issue when loading up the runners and they were not visible on site so we had to manually add the runners with a (DOT) at the end.
Please observe that the two ‘real’ runners have a RunnerStatus of ACTIVE and the ‘dead’ one of LOSER; The option would be to amend your market validation to only count ACTIVE runners.
This does seem like a very rare occurrence and we will monitor this moving forward.
Kind Regards,
Anthony.


Merge Request Review Guidelines

Whoever will be the maintainer of this repository, please ensure there are no merge conflicts with the main branch before you accept the merge request. Since we faced this issue earlier.

Exactly, i had to deal with a lot of conflicts in the past hw. We should be careful.

So who is the maintainer then?

This is the nice approach as well as a precaution.

This is the nice approach as well as a precaution.

I think @sharmistharanit is the maintainer.

Yeah, we encountered this issue, Be careful.

I hope the issue is resolved, closing the issue, if you need anything else, please reopen it.


✨ Add LEB128Lib

Description
Add  library to encode and decode values based on LEB128 compression scheme. Useful for non-standard way of encoding calldata to decrease calldata size. See the usage example.
Checklist

[✔ ] Ran forge fmt?
[✔] Ran forge snapshot?
[✔] Ran forge test?

@Shungy how much this method is efficient in compare to LibZip.cdCompress() and LibZip.flzCompress() methods.

Might not accept.
Tried it on this sample calldata:
0x4a04a1c90000000000000000000000000000000000000000000000000000000000000020000000000000000000000000ca1694433e499862ee242f2f403cb1e73ae91cfb000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000001f5d295778796a8b9f29600a585ab73d452acb1c0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000ffffffff0000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000026000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000

which, broken up into uint256s, will give:
function testBenchBE128Compress() public {
        uint256[] memory a = new uint256[](21);
        a[0] = 0x0000000000000000000000000000000000000000000000000000000000000020;
        a[1] = 0x000000000000000000000000ca1694433e499862ee242f2f403cb1e73ae91cfb;
        a[2] = 0x0000000000000000000000000000000000000000000000000000000000000001;
        a[3] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[4] = 0x0000000000000000000000001f5d295778796a8b9f29600a585ab73d452acb1c;
        a[5] = 0x0000000000000000000000000000000000000000000000000000000000000001;
        a[6] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[7] = 0x00000000000000000000000000000000000000000000000000000000ffffffff;
        a[8] = 0x0000000000000000000000000000000000000000000000000000000000000200;
        a[9] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[10] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[11] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[12] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[13] = 0x0000000000000000000000000000000000000000000000000000000000000220;
        a[14] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[15] = 0x0000000000000000000000000000000000000000000000000000000000000260;
        a[16] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[17] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[18] = 0x0000000000000000000000000000000000000000000000000000000000000014;
        a[19] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        a[20] = 0x0000000000000000000000000000000000000000000000000000000000000000;
        uint256 total = 0;
        for (uint256 i; i < a.length; ++i) {
            total += LEB128Lib.encode(a[i]).length;
            total += 1; // We need at least 1 byte denote how long the bytes is.
        }
        console.log(total);
    }

This gives a total of 93 bytes + 4 function signature bytes = 97 bytes.
cdCompress gives a total of 79 bytes.

             total += 1; // We need at least 1 byte denote how long the bytes is.

In LEB128 the length is already encoded in the value. So if you are decoding all your calldata at once then there is absolutely no need to define lenghts or offsets for values. So 97 becomes 76, beating cdCompress.
Added benchmark to the tests. Basically this is possible:
        bytes memory encodedData;
        for (uint256 i; i < a.length; ++i) {
            encodedData = abi.encodePacked(encodedData, LEB128Lib.encode(a[i]));
        }
        assertEq(encodedData.length, 72);

        // Test that we can decode these values.
        uint256 ptr;
        assembly {
            ptr := add(encodedData, 0x20)
        }
        for (uint256 i; i < a.length; ++i) {
            uint256 result;
            (result, ptr) = LEB128Lib.rawMemDecodeUint(ptr);
            assertEq(result, a[i]);
        }

@Shungy how much this method is efficient in compare to LibZip.cdCompress() and LibZip.flzCompress() methods.

I haven't tested. I guess it depends on the data as this is a different method of compression (?). But LEB128 length can be easily determined based on the most significant bit position of the value: https://github.com/Shungy/solady/blob/d75459dab1ae8c31664070ec92f6c558a46bd9d0/test/LEB128Lib.t.sol#L68-L75

@Shungy Can you write a PoC to demonstrate using BE128 on any calldata?

Very simple example: https://github.com/Shungy/leb128-nooffset/blob/14f6ae06d39a95733a60ebcc2a62c3cd2e8ac80b/src/examples/EncodedCalldataERC20.sol#L31-L36
It's not plug and play.
I can write a PoC for complex calldata encoding as well but that's beyond the scope of this library, as there can be different ways to standardize that based on how you want to decode  non integer values.

Lemme think about it. For specific cases, LEB might offer slightly better compression.
I have another example where the inputs don't lend well to simply LEB every 32 byte chunk.

I have another example where the inputs don't lend well to simply LEB every 32 byte chunk.

Yea that wasn't my intended way of using. If you're encoding right padded 32 bytes then the encoded value will be 36-37 bytes.

My OCD is slightly itching over having two separate compression sol files.
LEB definitely need more SLOC, so copypastaing it into LibZip will bulk up the file.

After much thought, I think it’s best to just stick with LibZip for Solady. The best case of LEB128 can save a few bytes, but it requires more work (on both solidity side and client side) and is not general.
JFC, it took quite a while for sound to integrate LibZip cdCompress, even tho there’s already a JS plug and play solution.
On average, LEB128 use 22.86 bytes for an address. This is similar to cdCompress’ usage of 22 bytes per address. The case where LEB shines is where there are many small numbers in the calldata.
I greatly appreciate the work and thought put into this. I’m very sorry. 🙇♂

Thanks for looking into it :pray: :pray:


add Royal Grammar School, High Wycombe

@MattIPv4 Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Newsletters: add 254 (2023-06-07)

Lede, releases/RCs, topic entries @harding
Feerate estimates @glozow
Bitcoin Core 26485 @glozow
LND 7645 @bitschmidty

Added missing lede and releases/RCs, added topic links, reviewed contributions from @bitschmidty @glozow @Xekyo (thanks!).  Thanks everyone!

Is it necessary to update 2023-05-17-policy.md as well?

@azuchi it is, thanks for thinking about that.  I'll make that change.

Made edits for @LarryRuane and @azuchi feedback, thanks!

Squashed and merged, thank you @harding @glozow @Xekyo and @LarryRuane for contributing this week!


Overly optimistic F1 scoring

Your code is overly optimistic when comparing two different labelings. This becomes important when CRF decoding is not used and predicted BIOES labels can be invalid.
For example, your function get_ner_fmeasure will return F1=1.0, but token accuracy acc=0.5. This does not make any sense to me.
Here is the test code that fails, because computed f1 is 1.
from utils.metric import get_ner_fmeasure

def test_metric():
    acc, p, r, f1 = get_ner_fmeasure(
        [['O', 'B-PER', 'I-PER', 'E-PER']],
        [['I-PER', 'B-PER', 'O', 'E-PER']],
    )

    assert f1 < 1.0

@jiesutd Here is the comparison: http://blog.innodatalabs.com/7776_ways_to_compute_f1_for_ner_task/
To conclude: there is no problem with your scoring, but it is not fair to compare with others who may have used a different method.

@mkroutikov Very detailed comparison, impressive!  It seems you compared different F1 on the LSTM without CRF model.
May I know what's the difference of the F1 computing method on the model with CRF? I believe with the CRF, the difference would be significantly reduced.  And in better CRF models (e.g. adding character LSTM/CRF), the difference would be even less.

You are right, I only tried BidiLSTM (single layer), did not try attaching CRF layer (yet). Will post if I do.
I agree that with the more advanced models we will get much less token errors, and therefore less ambiguity in decoding entities.
With CRF layer on top I would suggest to always use constrained weights.
It automatically guarantees correct decoding and does not cost more in terms of CPU/GPU time.


🐛 Bug Report: Not enough padding for danger cards

👟 Reproduction steps
On a window less than 767px

Log in to the Console
Click on the user in the top right
Click on "Your account"
Scroll down to "Delete account"

👍 Expected behavior
There is some padding after the danger alert
👎 Actual Behavior
There is no padding:

🎲 Appwrite version
Appwrite Cloud
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

still a problem on 1.5.6

Related: https://github.com/appwrite/console/issues/918.

Hi @stnguyen90 here is PR for this issue:
https://github.com/appwrite/console/pull/1107


Maven cannot find Mahuta Version

<dependency>
  <groupId>net.consensys.mahuta</groupId>
  <artifactId>mahuta-core</artifactId>
  <version>0.3.8</version>
</dependency>

When I copy the Maven dependency import into my pom.xml, the jars cannot be found. Maven gives me no possibility to find them no matter what version I try. I'm using IntelliJ IDEA 2019.1.3.

Hi, Thanks for pointing this out.
The packages are hosted on a specific repo, so you need to this to your pom.xml
	<repositories>
		<repository>
			<id>consensys-kauri</id>
			<name>consensys-kauri</name>
			<url>https://consensys.bintray.com/kauri/</url>
		</repository>
	</repositories>

I should probably mirror the repository with Maven central to offer a wider access without requiring to configure a repo.
Greg

Thank you very much!


Publish RPMs: sync less data

The core idea is to use --recycle-pkglist to skip recalculating metadata for all the old packages, which avoids the need to have the old packages there to begin with.

I'm going to merge it and see what happens


allow to pause backup schedule

Description
Allow the user to pause the ACM backupSchedule
Related Issue
https://issues.redhat.com/browse/ACM-13242
Changes Made
Updated BackupSchedule CRD to include an optional property named paused
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[x] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[x] I have added/updated relevant unit tests (if applicable).
[x] I have ensured that my code follows the project's coding standards.
[x] I have checked for any potential security issues and addressed them.
[x] I have added necessary comments to the code, especially in complex or unclear sections.
[x] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/cc @dislbenn

/lgtm


Theming: add new themeable global variable for retroachievements

Hi @fabricecaruso , I know that there is a variable for compatible systems with retroachievemens ("ifCheevos="true"), but a global themeable variable for retroachievements is missing, something like ifCheevosGlobal¿? would be great for theming.
Thanks a lot for the work

done in #1249
Thanks again for your work


Fix memory leaks with events.

This PR adds a WeakEventManager class to fix all kinds of memory leak issues that the different Xaml platforms have. Since these changes could break existing applications that depend on the strong references it would be great to add this to RxUI 6 before it is released.
Problem

Button instances attach to the CanExecuteChanged event on an ICommand instance. This causes a leak when the ViewModel exists longer than the View. Details: https://github.com/MvvmCross/MvvmCross/issues/552 and http://social.msdn.microsoft.com/Forums/silverlight/en-US/34d85c3f-52ea-4adc-bb32-8297f5549042/command-binding-memory-leak?forum=silverlightbugs
LongListSelector instances attach to the CollectionChanged event on an INotifyCollectionChanged instance. Same problem as above. Details: http://social.msdn.microsoft.com/Forums/en-US/11684ea3-5c71-4354-a4e4-c337198f52b1/wp8-longlistselector-memory-leak?forum=wpdevelop
It seems that other controls like Pivot have similar issues.

Solution
To fix all memory leaks related to event subscription from the UI, WeakEventManager instances have been added.

The CanExecuteChanged event of ReactiveCommand is now handled with a CanExecuteChangedEventManager.
The CollectionChang(ing|ed) events of ReactiveList are now handled with a CollectionChang(ing|ed)EventManager.
The PropertyChang(ing|ed) events of IReactiveObject are now handled with a PropertyChang(ing|ed)EventManager.

Implementation
The implementation is based on the WeakEventManager class in WPF and the code in http://social.msdn.microsoft.com/Forums/silverlight/en-US/34d85c3f-52ea-4adc-bb32-8297f5549042/command-binding-memory-leak?forum=silverlightbugs
It contains a ConditionalWeakTable for the Target <-> Delegate mapping to keep the reference to the event handler alive as long as the control itself is alive.
The second ConditionalWeakTable exists to make sure the event manager does not leak the source of the event. This would be the ICommand instance in the case of the CanExecuteChanged event.
TODO:

[x] Add unit tests that verify there are no leaks. I already verified with test applications that these changes solve the above issues.
[ ] Verify that this does not break RxUI View bindings that might rely on the strong reference.

@jlaanstra Why does ReactiveList need to use the event manager here?  It seems like it should only be needed in the controls and view controllers. Other containers like ObservableCollection don't do this, so I'm trying to understand why ReactiveList needs to.
This seems to be breaking Xamarin.Forms ListViews that bind to ReactiveList since Xamarin.Forms already uses an event manager.
https://github.com/reactiveui/ReactiveUI/issues/806