Discuss differences between monikers and SymbolDescriptors

SourceGraph introduced the concept of a SymbolDescriptor to identify / locate a symbol (see https://github.com/sourcegraph/language-server-protocol/blob/workspace-dependencies/extension-workspace-references.md)
LSIF defines monikers which are used to relate symbols without the need of interpreting the moniker (at least not the programming specific part). Moniker might be needed to be interpreted in terms of know to which module system and to which module they relate.
We should see if the two concepts can be unified.

Thanks for posting this. This is a super interesting development, and I’m really excited to see what it enables!
We (Sourcegraph) were actually planning to move away from the problem of “defining a name for a symbol” in a way that is standardized across languages. We are building the next generation of our code intel in such a way that if such a name is required, it is an implementation detail of the language server.
The reason is that in our experience, doing anything cross-language yields a huge (and possibly fatal) increase in complexity. It is much better to have a tiny bit of TypeScript code executing on the client to act as glue rather than to try to have a truly language-independent format, at least for our requirements.
I would love to understand why you chose LSIF instead of just recommending that each language server (as an implementation detail) be able to produce and read an index, and use it to satisfy requests without access to the code or causing side effects. What requirements on your end would that not satisfy?

Thanks for reaching back.
The dump format as the LSP is language neutral. Please note that the LSIF is not a symbol database. You can't ask anything than LSP requests. It has no language knowledge as the LSP has none. This is why we also choose the concept of a moniker and not a symbol descriptor since at least the language specific part of the moniker is opaque. The LSIF only allows to related symbols not to search for a specific one. I agree that searching for symbols always needs a language specific server.
Having one format opens the possibility serve them with one server even from a database. Furthermore the dump can be interpreted generically on the client side without knowing or installing a language server.

Got it. :+1: Now that we have Sourcegraph extensions (which are small bits of TypeScript code that run on the client), we don't need SymbolDescriptor's greater expressiveness anymore. We can rely on the small bits of code (each language extension) to do the glue work to fetch the relevant references.
Here is what I think folks (and maybe you) might find useful about SymbolDescriptors.

We designed SymbolDescriptors to support finding references both with AND without strict version matching. For example, require('mobx') yields different (but "kind of" the same) things depending on whether your package.json has<EMAIL_ADDRESS>or<EMAIL_ADDRESS>Sometimes the distinction matters, sometimes it doesn't:

Sometimes you want a references query to ignore the version when finding references. (The "show me usage examples" use case.)
Sometimes you want a references query to respect (strictly) the version when finding references. (The "I want to upgrade my whole company's codebase from mobx 1.2.3 to mobx 4.5.6, so show me only usages of the old version" use case.)

The way that SymbolDescriptors supported this is by encoding arbitrary key-value pairs associated with each reference and letting you provide a mask object to query for matching references. Instead of the string moniker npm:mobx:ObservableMap, the SymbolDescriptor would be an object like:
{
  "package": "mobx",
  "dependencyVersion": "1.2.3",
  "source": "npm",
  "name": "ObservableMap"
}

Then consumers could query the indexer database by providing a mask query object whose fields must all match. For example, it could issue the following queries:

{"package": "mobx", "source": "npm", "name": "ObservableMap"} (to ignore the version) or
{"package": "mobx", "source": "npm", "name": "ObservableMap", "dependencyVersion": "1.2.3"} (to respect the version)
OR other things, such as {"package": "mobx", "source": "npm"} ("find me ALL references to anything defined in the mobx npm package", because it specifies no name property, so references to all names are matched)

There are other things like version that you might want to be strict or loose on, such as the canonical vs aliased import paths (Go), the path used to import the value (when you have reexports in JS/TS), etc.
This worked fine for our needs up to now, but it too complex overall to get anyone who wasn't very familiar with our stack and these concepts to implement this for a new language. Moving to Sourcegraph extensions is a better solution for us to retain this power but not need to specify/store this index in a complex, semi-language-agnostic manner.
I see the moniker scheme is simpler and only explicitly supports exact matches in a language-agnostic way (because LSIF tools will treat the monikers as opaque strings). I think this is a good choice. I can see how you could provide some of the other query capabilities that SymbolDescriptors provided above just by encoding other information in the moniker or by performing string manipulation (such as finding all references to everything in mobx by looking for all things with monikers prefixed npm:mobx:). As long as the opacity of the moniker is only "broken" in the same tool that generates it, you still retain the nice property of opacity.
So, I am curious about a few things:

Do you intend for LSIF-based systems to, e.g., support both queries that (a) ignore versions AND (b) strictly respect versions? If so, how will that work? (Perform version matching out-of-band, or encode it in the moniker?)
Do you intend for monikers to be stable? For example, I publish an LSIF dump of my package today to GitHub/npm with a moniker npm:@sqs/foo:myFunc. Will that moniker (and all of my published LSIF dump) still be valid in 3-5 years? Is it important for it to still be valid?
Who generates and publishes the LSIF dump of a given library? The maintainer at the same time they npm publish? Or in CI separately from npm publishing (so that each commit has LSIF data)?

(The last 2 are difficult questions we faced with SymbolDescriptor, too.)

A little bit of history on SymbolDescriptors, we discussed just adding an id field to SymbolInformation in the past. The reason we chose an object instead of a string ID was that not all languages have a unique identifier for a Symbol, but rather individual known properties about a symbol that together can identify a symbol "as uniquely as possible". The object is language-dependent and opaque to the client. This allowed us to take a SymbolDescriptor returned by the server and simply put it into a JSON column in a Postgres database, then take a different SymbolDescriptor returned form a language server instance on a different project (where a SymbolDescriptor could be constructed from dependencies) and run a Postgres JSON containment query to find the matching definition symbol. In this case, it was possible that the SymbolDescriptor to query with actually was less specific (had fewer fields), but the query could still find a result. For example, the query in dependencies would return { name, containerName, fileBaseName } and still match the definition SymbolDescriptor { name, containerName, fileBaseName, fullFileName }, because the three common properties matched. This would not be possible with a string ID.
One common property in all SymbolDescriptors was package, which we called a PackageDescriptor and worked the same way.
In practice however, this fuzzy-query capability wasn't really needed afaik. Our TypeScript support now uses declaration maps instead of fuzzy matching and we use the npm dependents API or Sourcegraph search instead of querying PackageDescriptors from our database. String monikers would likely work very well us. It may be interesting though to see if some semantics to it can be useful - for example, defining that it should become "more specific" left-to-right, so that an npm moniker transformer only prefixes monikers, and you could e.g. do a string prefix search to find all symbols in a package. I don't have a use case in mind, just a thought.

Thanks for your feedback on this. Very interesting and valuable. @sqs regarding your questions:

I am pretty sure that we will need version information (see https://github.com/Microsoft/lsif-typescript/issues/10 and https://github.com/Microsoft/lsif-typescript/issues/11). There are use cases where users for sure want to query for references to foo only in version 3.0 or above. But we haven't looked into how to best model this. So your experiences here are very valuable.
yes, we want to keep them as stable as possible. One thing we already discussed is whether we need to support moniker mappings to allows some sort of evolution. But nothing concrete yet.
this is still under discussion. I think that producing a LSIF for every commit is not necessary. Every published package might be enough. But this is me :-). One other idea was that we can produce the LSIF as a side effect of running a language server. But as said nothing concrete yet (see https://github.com/Microsoft/lsif-typescript/issues/6).

@felixfbecker I do agree that we need to define a little bit more around monikers (see https://github.com/Microsoft/lsif-typescript/issues/11). And I like the approach of saying it gets more specific left to right. Our current thinking is that we at least define segments in the moniker. So far we have the following segments:

package: defines the package manager from which the package came from npm, nuget, ...
name: the package name
symbol: the symbol path (that should be opaque).

If we can't find a symbol we would at least know from which package it came and we could try to index it. This is another use case where a version number is helpful as well.

It would be interesting if we did left-to-right precision in the moniker. I might argue that the package version be to the right of the symbol name rather than next to the package ID, but I suspect that would be controversial.
Anyway unless we're talking about tooling that will look at these monikers and accept fuzzy matching based on allowing matches on at least several of the first segments in the moniker to match, I'm not sure what else defining it would be useful for.

The issue has not gain any traction over the last years. I therefore close the issue.


Why are dependencies package in package.json to be build as external resource？And i can not change it...

Describe the feature
The option rollup.inlineDependencies don't match the dependencies packages in package.json.Is there a way to fix it or provide new option to handle it.
Additional information

[ ] Would you be willing to help implement this feature?

Ok, i could put it in devDependencies.


Handle nil database passwords for create_db and drop_db.

Commit ce7ab0a4c2a606dbeef4212db0e74dba67ba81f7 introduced a bug where
if the database configuration didn't specify a password attempts to
create/drop the database would fail. The underlying cause was that prior
to the above the code used blank? to which would catch both nil values
and empty values. The new code uses empty? which fails if used on a
nil value.
This patch fixes that by checking for nil in addition to an empty string.
This can be reproduced by creating a brand new app, using postgresql or
mysql, and setting the database configuration to this:
 postgres://localhost/nilpassword_development
And then running rake sq:create which will result in this:
  $ rake sq:create
  => Creating database 'nilpassword_development'
  rake aborted!
  NoMethodError: undefined method `empty?' for nil:NilClass
  .../gems/padrino-gen-<IP_ADDRESS>/lib/padrino-gen/padrino-tasks/sql-helpers.rb:10:in `create_db'
  .../gems/padrino-gen-<IP_ADDRESS>/lib/padrino-gen/padrino-tasks/sequel.rb:52:in `block (2 levels) in <top (required)>'
  .../gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
  .../bin/ruby_executable_hooks:15:in `eval'
  .../bin/ruby_executable_hooks:15:in `<main>'
  Tasks: TOP => sq:create
  (See full trace by running task with --trace)

I should have mentioned the above fails with the Sequel adapter. I didn't try the others, but imagine it's broken there too.

Thanks @phallstrom


Getting TypeError: 'PDFObjRef' object is not iterable

When trying to load a PDF, I get the following error
TypeError: 'PDFObjRef' object is not iterable
The error happens at pdfquery/pdfquery.py line 631
def _add_annots(self, layout, annots):
        """Adds annotations to the layout object
        """
        if annots: # and not isinstance(annots, PDFObjRef):
            for annot in annots:
                annot = annot.resolve()
                if annot.get('Rect') is not None:
                    annot['bbox'] = annot.pop('Rect')  # Rename key
                    annot = self._set_hwxy_attrs(annot)
                try:
                    annot['URI'] = annot['A']['URI']
                except KeyError:
                    pass
                for k, v in annot.iteritems():
                    if not isinstance(v, basestring):
                        annot[k] = unicode_decode_object(v)
                elem = parser.makeelement('Annot', annot)
                layout.add(elem)
        return layout

The error goes away by adding the second check that is commented out from the above code

Can you by any chance point to a PDF that has this problem for testing? There's probably a better solution than that second check, but I'd like to test. Thanks!

Fixed in version 0.3.1 on PyPI. Thanks for the report.

Confirmed working


Which go methods, functions, structs are bound by gomobile bind command

What version of Go are you using (go version)?

$ go version
go version go1.11.1 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/qeeyou/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/qeeyou/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11.1/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dz/s6p42lmd62x7d7sk4h06h1z40000gn/T/go-build434811796=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

use gomobile bind --target=ios /xx/xxproject/
What did you expect to see?
I want to know,Which go function, method, struct to objective c will be bound to the gomobile bind command? Is there a flag to tell the gomobile bind command, xx methods, functions need to be bound
What did you see instead?

Hi @FatChou,
This appears to be a question rather than a Go bug. We do not use the issue tracker for general discussions or questions like these. The Github bug tracker is only used for tracking bugs and proposals going through the Proposal Process.
For further questions, please have a look at Questions wiki page; it has a list of good places for asking questions.
Closing since this is not a bug.


Add Dark Reader lock

Thanks! Although it should really go in index.html, not blog.html, which is largely incomplete.


fix(deps): update terraform terraform-ibm-modules/cbr/ibm to v1.28.0

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
minor
1.27.0 -> 1.28.0

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.28.0
Compare Source
Features

added two new inputs to the fscloud profile: allow_vpcs_to_iam_groups and allow_vpcs_to_iam_access_management. By setting these to true, the following FSCloud SCC rules will pass:- Check whether IAM access management can be accessed only thorugh a private endpoint (Context-based restrictions or service) and allowed IPs<br>- Check whether IAM access groups can be accessed only through a private endpoint (Context-based restrictions or service) and allowed IPs` (#548) (10c5bc9)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.1.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] \n does not work for /alert

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When you type /alert test\ntest for example, it doesn't send it as 2 lines, it just sends that raw text.
Expected Behavior
Like in EssentialsX's /broadcast, it should split it up to 2 lines.
Steps To Reproduce
/alert test\ntest
Plugin Version
latest
Velocity Version
3.0.0
Java Version
11
Operating System
Linux
Relevant log output
No response

Thanks for reporting this bug! I'll take a look at it and try to release an update when the bug is patched.


ossl_rsa_sp800_56b_check_public: Be more lenient with small keys

Fixes #13995
For small keys the MR test on the modulus can return
BN_PRIMETEST_COMPOSITE_WITH_FACTOR status although the modulus
is correct.

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master. Thank you for the review.


Update OVN tests to run on Ubuntu Jammy

The OVN daily tests currently depend on a feature that was removed from OVN :(
See https://github.com/ovn-org/ovn/issues/124
We should update our OVN tests to not rely on this feature by adding a static route manually.

@tomponline shouldn't that be on the lxc-ci repo?


VM Sizing & Hugepages only on Master for ONS tutorial lab

Need to size VMs accordingly:

Master - 4 gigs RAM, 1 cpu
Nodes - 1 gig RAM, 1 cpu

Need to make sure hugepages is disabled on nodes.

Left a stash of work for making hugepages enablement optional, but, seems I have something baked into the image which is not letting it spin up when either one of two conditions is not met: 1. hugepages parameter for VM spinup, or less than 4 gigs of ram. Might have to left the RAM overprovisioned.


python -m unittest is successful , but run panorama = stitcher.stitch([image1, image2])  is failed, error:  numba.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)

import stitching
image1 = '/home/cq/stitching/tests/testdata/boat1.jpg'
image2 = '/home/cq/stitching/tests/testdata/boat2.jpg'
stitcher = stitching.Stitcher() # OK
panorama = stitcher.stitch([image1, image2]) #error

print(panorama)

can you run it with stitcher = stitching.Stitcher(crop=false) and show the result?

can you run it with stitcher = stitching.Stitcher(crop=false) and show the result?

Thanks, error has solved.  I have other problem: I try to stitch images longitudinally, but I get a misshapen  result image.
Can this code get a result images with auto height?

the default camera correction is horizontal. You can set it to vertical using wave_correct_kind=vert (see camera_wave_corrector

Thanks very much, It's just what I need!


Components with default prop value for v-model that are not using one aren't being updated after an update event is emitted

Version
3.0.5
Reproduction link
https://jsfiddle.net/6x0yahsb/
Steps to reproduce

click update button on the bound test component
watch input getting updated
click update button on the default test component
watch input not being updated

What is expected?
The default component - component which has a default prop value and is not bound with v-model:value should be updated as well.
What is actually happening?
The default component is not being updated whilst the component with v-model:value gets updated correctly.

Why do you think this is not up to expectations? Obviously, you need to use v-model.

Then what in case I have a component that has two v-models but sometimes I only care about one value? If I don't pass the second v-model, the component wouldn't work internally. And creating a data value for every instance of this component seems like a big overhead to me.

Yes, you need a data property. You can create a composable to handle it. I created a mixin with Vue 2 in mind to handle this case: https://github.com/posva/vue-prop-data-fallback


Fix #571 - pfTableView: ng-include inside ng-repeat hurts performance

Add new configuration property to columns object to define a template function
The goal of this PR is to provide a fix to performance issues caused by the use of ng-include inside ng-repeat to parse and include the content of each table cell that has a template.
This change is backward compatible and doesn't affect existing code that depends on the htmlTemplate property of the columns object. This change adds a new property called tempateFn as a potential replacement to htmlTemplate.

Note: This new property is light and simple but doesn't support AngularJS directives in the template, therefore it doesn't support things like ng-click.

List of changes:

Add new templateFn property to documentation
Inject $sce into controller to tell AngularJS to trust the template HTML
Remove hasHTMLTemplate and getHTMLTemplate functions from controller because we can check whether the columns have a template by just checking the existence of the htmlTemplate and templateFn properties
Use ng-bind-html to invoke the template function and inject the results in the cells
Add a new unit test for this feature

PR Checklist

[ X ] Unit tests are included
[ ] Screenshots are attached (if there are visual changes in the UI)
[ ] A Designer (@beanh66) is assigned as a reviewer (if there are visual changes in the UI)
[ ] A CSS rep (@cshinn) is assigned as a reviewer (if there are visual changes in the UI)

Thanks @akieling , LGTM :+1:


[T513] Test MR

A new configuration was created for openacademy80 with task id t512. You can deploy it here.

A new configuration was created for libreacademia80 with task id t512. You can deploy it here.

The instance created for openacademy80 with task id t512 has been deleted.

A new configuration was created for openacademy80 with task id t513. You can deploy it here.

The instance created for libreacademia80 with task id t512 has been deleted.

A new configuration was created for libreacademia80 with task id t513. You can deploy it here.

The instance created for openacademy80 with task id t513 has been deleted.

A new configuration was created for openacademy80 with task id t512_001. You can deploy it here.

The instance created for libreacademia80 with task id t513 has been deleted.

A new configuration was created for libreacademia80 with task id t512_001. You can deploy it here.

WARNING: Could not create a deploy configuration. Task ID not found in the title of the PR, supported formats:
{ task type }#{ number }
{ task type }{ number }

Available task types: task, t, vx, issue, i, us, hu (case insensitive)
Examples:

task#123

Issue123

US#123

The instance created for openacademy80 with task id t512_001 has been deleted.

The instance created for libreacademia80 with task id t512_001 has been deleted.

A new configuration was created for openacademy80 with task id t512_002. You can deploy it here.

A new configuration was created for libreacademia80 with task id t512_002. You can deploy it here.

The instance created for openacademy80 with task id t512_002 has been deleted.

A new configuration was created for openacademy80 with task id t513_002. You can deploy it here.

The instance created for libreacademia80 with task id t512_002 has been deleted.

A new configuration was created for libreacademia80 with task id t513_002. You can deploy it here.

The instance created for openacademy80 with task id t513_002 has been deleted.

The instance created for libreacademia80 with task id t513_002 has been deleted.


Invalid URLs

visit https://contributors.ohc.network/contributors/Ashe
It is showing 500 Server Error

visit https://contributors.ohc.network/dsfdsfdsf/Ashe

Expected behavior:
Handle All Invalid URLs with a redirect or Not Found page
cc : @rithviknishad

@rithviknishad
can you please suggest the expected behavior for these urls

https://contributors.ohc.network/contributors/Ashe
https://contributors.ohc.network/dsfdsfdsf/Ashe

Reference: https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#dynamicparams


Max-workers flag and rate=0 do not work in v12.7.0

Question
Hi guys, from the commits I see that are included in v12.7.0, there should be a capability to specify -rate=0 and -max-workers flag. However, when I run the following command
echo "GET http://localhost:8080/test" | vegeta attack -rate=0 -max-workers=10
It returns an error saying flag provided but not defined: -max-workers and rate frequency and time unit must be bigger than zero. The command help message also does not include usage of max-workers flag. I have checked and I am definitely using v12.7.0 of vegeta. Any ideas what might be the cause?

That's so strange. I must have messed up the last release. I'll update the assets of that release.

Actually, scrap that. I just downloaded the latest v12.7.0 release (https://github.com/tsenart/vegeta/releases/download/v12.7.0/vegeta-12.7.0-linux-amd64.tar.gz), and I can run that command without any issue.
Are you sure you unpacked the right tarball? It also happened to me that I unpacked an old vegeta tarball I had in my dowloads directory, hence the previous message :)

I have never downloaded/installed a different version before as I just started using this library.
But anyway, I just tried downloaded the tar and tried again and it's working now. Not sure what happened before. Sorry for the false alarm.


RandomRotation for instance segmentation

I checked augmentations available in mmdetection and I found RandomAffine augmentation, but it seems it only works for bboxes and not for masks:
https://github.com/open-mmlab/mmdetection/blob/main/mmdet/datasets/transforms/transforms.py
if 'gt_masks' in results:
    raise NotImplementedError('RandomAffine only supports bbox.')

It would be great to have a RandomRotation augmentation which would also support instance segmentation tasks.
Something to consider:
Bounding boxes should not be rotated, but rather defined as minimal rectangles encompassing the mask after rotation.
Consider the below example. Let's say we are rotating 45 degrees to the left.

If we just naively rotate the bounding box, it will become way wider than the thin pencil. But if we recalculate the bbox based on rotated mask, we will get a precise fit.
Would someone be kind enough to implement this?

@Macok how did you installed mmdetection in system, im not able to install it bcz no update fro mmdetection 3 version,tried collab notebook which provided in Redme for instance segmentation.
also in docker not able to run it

Ok it seems I figured it out.
There's in fact a Rotation class which can rotate both bboxes and masks.
https://github.com/open-mmlab/mmdetection/blob/main/mmdet/datasets/transforms/geometric.py#L429
After this transformation, I'm using my custom transformation to create bboxes out of masks:
@TRANSFORMS.register_module()
class BoxesFromMasks(BaseTransform):

    def transform(self, results: Dict) -> Dict:
        results['gt_bboxes']=results['gt_masks'].get_bboxes('hbox')
        return results

Can someone please verify if this is the correct way to do it?

@Macok can you tell me how to create custom model cfg for instance segmention ,for mask2former or any new instance segm model?


Add test-only command to bypass build.

Great utility for CI. Add test-only for when you need to separate build and test steps. Our test step was taking 3 minutes after we would do a build. This was due to the shear size of our project.

see also https://github.com/leancodepl/patrol/issues/1982 which where I proposed this feature

Thanks @scottandrewzip for the input.
I checked how it works and looks like the behavior of this command varies between platforms. On Android, the _execute method invokes the ./gradlew connectedAndroidTest task, which rebuilds the test by updating it. On iOS, however, the xcodebuild --test-without-building command is used, which utilizes already built instrumentation so even if we change something in the test code we won't see it.
We need to find a way to solve the disparity by making it work the same way on both platforms


Adds googletest CPM to fix cmake errors from SPIRV

Need to add googletest as a CPM to avoid error messages while generating build files with cmake from SPIRV.

The SPIRV library will not use system google test.

Thank you for your contribution


Why doesn't Tensorboard get invoked from Spyder - everything works now except this

Dear assignees,
Thank you for your time.
Summary
Everything with Spyder is working now beautifully.
Spyder: 5.0.2
IPython from within Spyder: 7.23.1
Python: 3.8.9
NOTE: don't know whether this is a bug or installation problem.
Problem
When I invoke the script in Spyder, I get this

Tensorboard is invoked, but I don't see the the tensorboard.
I am running a simple script that is supposed to invoke the tensorboard.

For your information the program is test_notebook.ipy
NOTE: This is not about tensorflow. It is about why tensorboard is not invoked from IPython despite being installed.
import tensorflow as tf

import datetime,os

%load_ext tensorboard

mnist = tf.keras.datasets.mnist
(x_train,y_train), (x_test, y_test) = mnist.load_data()

x_train, x_test = x_train/255.0 , x_test/255.0

model = tf.keras.models.Sequential([
	tf.keras.layers.Flatten(input_shape=(28,28)),
	tf.keras.layers.Dense(512, activation='relu'),
	tf.keras.layers.Dropout(0.2),
	tf.keras.layers.Dense(10,activation='softmax')
])
%reload_ext tensorboard
%tensorboard --logdir logs

Summary:
Tensorboard is invoked but not displayed even though the tensorboard is installed.
Why can't I see the tensorboard.
Thank you, merci, gracias.
Anthony of Sydney

Hi @AnthonyTheKoala thanks for the feedback! I'm not totally sure but maybe the output from running tensorboard is not being handled by QtConsole properly. Seems like there is some output but it gets printed as <IPython.core.display.HTML> Also, just in case, is the plots pane empty, right?
@ccordoba12 what do you think?

Yeah, if I'm not mistaken, Tensorboard is a web application and we can't display web content yet in Spyder.
We'll try to address that in Spyder 6, to be released next year.

Dear Daniel and Carlos,
Thank you for your reply.
Here is the output from the console at bottom and the plots panel at the top:

I wrote this a few minutes before you closed the issue, researching a method to work out if there are any other ways to get the HTML object.
Look forward to v6.
Thank you, merci, gracias,
Anthony of Sydney

Encountered the same error.
For anyone coming across this: to go around it, I started TensorBoard from conda pointing at the log directory and just went to localhost 6006.
There might be a solution within spyder, but I didn't find it.


Vulkan SDK release feature cut-off Friday Dec 4

LunarG is planning the next Vulkan SDK release in the week of Monday Dec 7.
MoltenVK PRs approved by Friday Dec 4 will be included, and a MoltenVK SDK release will be made Monday Dec 7.
@cdavis5e @HansKristian-Work @richard-lunarg

Completed with PR #1177 and release v1.1.1.


[BUG] elewise_binary_op.cc:: add_alias(" ?") ? in ["_sub", "_mul", "_div"]

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System:
ubuntu 15.10
Compiler:
gcc 4.9.x
Package used (Python/R/Scala/Julia):
Python
MXNet version:
0.11.1
Or if installed from source:
MXNet commit hash (git rev-parse HEAD):
e81a3a88abaa2c4847602dfb2864e05adc5a5f56
If you are using python package, please provide
Python version and distribution:
python2.7
If you are using R package, please provide
R sessionInfo():
Error Message:
Please paste the full error message, including stack trace.
Minimum reproducible example
It raises error when ops such as _sub, _mul, _div call  .add_alias().
dmlc-core/include/dmlc/registry.h:66: Check failed: e == fmap_.at(alias) (0x24622b0 vs. 0x232b020) Trying to register alias _mul for key elemwise_mul but _mul is already taken

Trying to register alias _div for key elemwise_div but _div is already taken

Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

Compile from source
python setup.py install
import mxnet

What have you tried to solve it?
After I delete them in elemwise_binary_op_basic.cc, it works well.

delete .add_alias("_sub")
delete .add_alias("_mul")
delete .add_alias("_div")

This will be fixed soon.


Adding more data cleaning techniques in the specified folder

Issue : #623
All changes have been made
Please see the folder 'Data Filling and cleaning techniques'

Please assign the respective labels and levels of contribution

@jeet-Abhi123 Data analysis plays a major role  in data cleaning ,I cant found in your code.


Generated code is not reproducible when multiple plugins are specified

So far this is not a problem, as there is only one plugin built in to protoc-gen-go.  However when more than one plugin is registered the generator may behave unexpectedly.
This is caused by two issues:

RegisterPlugin is called from init() and the execution sequence is not guaranteed (though it's possible to manually control the import sequence and hope go doesn't change it's behavior on handling import packages).
Registered plugins are filtered against the list of plugin to use from user input at runtime. Meaning, the order of plugins to use doesn't affect the final output -- it will always be unpredictable. What makes things worse is that, unknown plugin will be ignored silently.

I think the second place is the best place to fix this issue.

The Go language spec specifies that package initialization occurs in declaration order. Given that, I don't really see an issue.

You are right about that.
I should have made it more clear about the problem here. As the plugins are
registered as side effect of importing a package, so the import sequence
matters. Although govet checks if all the side effect imports are in main
package, there is no way to guarantee that a plug-in is only imported in
main. As it’s possible that a plug-in package is imported by another
package for using one of its method and in that case the plug-in will be
registered in an undetermined order.
Even if we can assume that all these plug-ins are only imported from main
only, controlling the output sequence with import order is not clear.
Especially that the packages are always sorted with gofmt unless additional
empty lines are inserted around all the plug-in imports.
IMHO the issue still exists and needs to be fixed.
Joe Tsai<EMAIL_ADDRESS>周五上午2:56写道：

The Go language spec specifies that package initialization occurs in
declaration order https://golang.org/ref/spec#Package_initialization.
Given that, I don't really see an issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/protobuf/issues/474#issuecomment-351803378,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAp9B6bQEHhCpbe6GkEnCr-Smk8uIWlSks5tAW91gaJpZM4RB_F5
.

The generator plugin API is something that could use an overhaul. We probably don't have time to think about it today, but will keep this issue in mind for the future.


[DISCUSS] Added possibility to link with CVODES

This PR adds the possibility to link with CVODES instead of CVODE. It does not enhance functionality, since the new release of Sundials introduces a new interface for solvers and I am not sure what the correct way of coupling with MFEM would look like.
I wanted to get an opinion from the devs if this option is intended to reside in the library or if we should keep a local patch because it may be too specific.
Todo

[X] GNU Make
[ ] CMake
[ ] Default to NO

This could definitely be useful to add to the library, provided we can keep the interface relatively light.
Do you have a particular application in mind?

The CVODES interface would be of interest for users who use objective functionals for time dependent problems. Particular examples include gradient computation in optimization problems.

What will the interface to that look like in MFEM (even at the mockup level)?

I imagine the interface very similar to CVODESolver with a few additional methods that have to be implemented. The user has to implement the methods for

Forward equation
Quadrature function(s) (depends on the use case, definitely one objective function)
Backward (adjoint) equation

Then there are three steps for solving

Solve forward
Solve backward
Request the quadrature

Forward and adjoint equation are of type TimeDependentOperator.
This could be done using a very similar implementation to CVODESolver (which handles the memory of CVODE directly) or through the new interface which came with Sundials 4. In either case I'm not sure if the interface will be light enough to be part of the library.

@gardner48 has a branch in to make the various changes in MFEM SUNDIALS interface here:
https://github.com/mfem/mfem/tree/sundials-interface.

This will be addressed by recent efforts from @jonwong12. Therefore I'm closing this PR.


Changes for react-apollo/pull#1978

Hey @marnusw, I went to review your PR at https://github.com/apollographql/react-apollo/pull/1978 and realized it would be easier to suggest changes directly. I've updated the react types, and then just any-typed the "private" properties which will probably never be accepted to @types/react.

Thank you for the review and fixes @mike-marcacci! After rebasing and changing my branch I just cherry-picked your commit over, so I will close this now.


TypeError: (0 , _addonStoryshots.imageSnapshot) is not a function

I have storyshots working correctly as far as I can tell.  The next step was to add imageSnapshot, and test with it.  Here's my Storyshots.test.js file:
import initStoryshots, {imageSnapshot} from '@storybook/addon-storyshots';
initStoryshots({
  configPath: 'storybook-config',
  suite: 'Button',
  test: imageSnapshot({storybookUrl: 'http://localhost:9009'})
});

In my package.json I have:
  "dependencies": {
    "babel-core": "^6.26.0",
    "babel-preset-env": "^1.6.1",
    "babel-preset-react": "^6.24.1",
    "react": "^16.2.0",
    "react-dom": "^16.2.0"
  },
  "devDependencies": {
    "@storybook/react": "^3.3.15",
    "@storybook/addon-storyshots": "^3.3.15",
    "babel-jest": "^22.4.3",
    "jest": "^22.4.3",
    "react-test-renderer": "^16.2.0",
    "regenerator-runtime": "^0.11.1"
  }

I am getting the error:  TypeError: (0 , _addonStoryshots.imageSnapshot) is not a function
As far as I can tell from the documentation and the provided examples, my syntax is correct.  Is this a bug or am I doing something wrong here?

I had to upgrade my @storybook to 3.4.0-rc.3:
 "devDependencies": {
    "@storybook/addon-storyshots": "^3.4.0-rc.3",
    "@storybook/addons": "^3.4.0-rc.3",
    "@storybook/react": "^3.4.0-rc.3",
    "babel-core": "^6.26.0",
    "babel-jest": "^22.4.3",
    "babel-preset-env": "^1.6.1",
    "babel-preset-react": "^6.24.1",
    "jest": "^22.4.3",
    "react": "^16.2.0",
    "react-dom": "^16.2.0",
    "react-test-renderer": "^16.2.0",
    "regenerator-runtime": "^0.11.1"
  }


Initial commit for complex numbers

Complex numbers are now in the lexer (with a couple of additional hand-written pre-parsing steps
Need to be added to the actual parser.
A full set of tests and edge cases and technical documentation is prepared waiting on getting the full tests working.

One quick note: In APL, dyadic | is the modulo operator. I believe in erlang it is rem.
In APL (tested the following on GNU APL and Dyalog), it does operate on imaginary numbers:
      1J1|1J2
¯1
      1J1|1J3
0
      1J2|1J3
0J1

Not immediately clear what equation it is performing to arrive at this.

https://aplwiki.com/wiki/Residue#Caveats


Read pressure/altitude fails with struct.error exception

I just received a Wemos D1 Mini and BMP180 pressure sensor.
Trying this library, I'm getting 0.0 for pressure and altitude. Looking at bmp180.py, it seems this is the result if struct.unpack returns an exception while unpacking.
Unless I have misunderstood the purpose of L153-155, the library is trying to unpack MSB, LSB, and XLSB as little endian integers.
However above on lines 105-107, it is only reading 1 byte from each {M,L,XL}SB register.
This will cause a struct.error exception to be thrown when trying to unpack as a little endian integer, as struct.unpack is expecting at least two bytes, but only one byte has been read from the register. Tested in full Python interpreter:
# MSB_raw value returned from sensor via i2c.readfrom_mem(119,0xF6,1)
>>> MSB_raw = b'\x9e'
>>> MSB = unp('<h', MSB_raw)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
struct.error: unpack requires a buffer of 2 bytes

Page 18 on the Bosch datasheet seems to confirm that MSB, LSB, and XLSB are only one byte, not two.
Shouldn't L153-155 be instead:
            MSB = unp('B', self.MSB_raw)[0]
            LSB = unp('B', self.LSB_raw)[0]
            XLSB = unp('B', self.XLSB_raw)[0]

With this modification, I'm getting somewhat sensible values from the sensor:
>>> bmp180.pressure
b'\x9e'
b'0'
b'@'
96486.3
>>> bmp180.altitude
b'\x9e'
b'4'
b'\xc0'
389.85

(The altitude of my location is ~500m)
Here are the compvalues for my BMP180:
>>> bmp180.compvaldump()
[8230, -1187, -14490, 33554, 24764, 22644, 6515, 47, -32768, -11786, 2964, 2]

I haven't touched this code in a while, but what you explain seems quite reasonable. This code definitely worked back in the days, maybe I accidentally relied on a different bug in the interpreter.
If you figure it out, I'd be happy about a pull request. If you are interested, I can also add you to the organization, so you can become a maintainer.

Sorry for the delay, I'd forgotten about this until now.
Pull request is here: https://github.com/micropython-IMU/micropython-bmp180/pull/5


Load button sub menu gone.

I was having trouble with my install so I backed up the main folder and started comfy from a fresh install.
I tried to drag over the folder that the load button uses. it was a symbolic link and disappeared when i tried.
Now i forget the name of the folder some thing like pyssssWorkflows or like that.
Without that wilder the drop down arrow is missing in the GUI.
Folder name please?

Nevermind i found it.
"pysssss-workflows"


Dripsy not using color modes

Hello, I'm having issues with dark and light values not being applied. Here is a small snack showing the problem. The color scheme is set to light so the text should be blue, but instead it is red.
I also think there should be a color mode example in this repo, when this is resolved I can make a PR.

Hey I think the move is to avoid our color modes and just handle it with React context yourself, and edit the theme at the root of your app

That's how restyle does it

Got it, thanks.


Appears to be removed from Firefox addons

The Firefox extension appears to be absent from addons.mozilla.org.

Hi @rcrx, I am sorry for that.
I received a notification from Mozilla Add-ons the other day about the removal. The reason is that this extension "contains obfuscated code or logic, which is not permitted by our policies". However the takedown notification didn't specify which functions has been deprecated.
I am afraid that it'll take me some time to figure out what should be fixed due to the ambiguity of the message.

Thanks for the explanation, @chitsaou
Looking forward to copy-as-markdown's return; it comes in quite handy.

Hi there,
It's now back to store. Sorry for the long wait. I have to rebuild the whole application to make it approvable on Firefox Add-ons. (See #71  for technical details)
Thanks, and have a good day!


Rescanning of image files as results of an extended search brakes with an error

Trying to rescan all images of a fileset by executing a custom search by fileset with the number of results set to 100.
After all images of the fileset are listed as search results, i select all files and click "Rescan" (context menu or menu in title bar).
It seems that some images are getting rescanned, but soon an error is displayed:
Call to a member function setColumnSortDirection() on null
Repeating the rescan process reveals that a handful of image files are getting processed each try, until the error is shown again. The progress indicator ("1 of 60") doesn't count down, but on each try of rescanning the number gets smaller.

I have had the error that you're describing (although it happens after the rescanning completes) but strangely I can't seem to verify it on my local install.

I have tried this now on a fresh installation of 8.4.0.RC1.
No error is thrown now, but only 5 files are getting rescanned, instead of all selected files.
Steps to reproduce:

Add a new thumbnail type.
On Files, do a custom search by fileset (instead of keywords), and set the number of results to 100.
Select all files of the result, select option "Rescan".
Only the first 5 files are getting rescanned.

The same happens even if no search is done:
Steps to reproduce:

On Files, select 10 files, select option "Rescan".
Only the first 5 files are getting rescanned.

Just found out that in any case only 5 images inside a folder are getting rescanned, regardless how many and even which files have been selected.

This is fixed now. Additionally, Rescan Files shows up as the title of the progressive operation, and there should be no more error complaining about setColumnSortDirection. It's not perfect – there's some weirdness in the file manager around behavior in search in general – but it's much better, and it should rescan all the files now.


Adding a new post - AWS Amplify Pull-Request Previews for public GitHub repository

Issue #, if available:
NA
Description of changes:
AWS Amplify Pull-Request Previews currently only supports private GitHub repository. This amplify-preview-actions GitHub action enables the ability to deploy AWS Amplify Pull-Request Previews for your open source and public GitHub repository.
With this amplify-preview-actions GitHub action, you can define your own rule to deploy the Pull-Request branch to the AWS Amplify console app page for a preview. For example, you can setup a rule only a pull request is labeled with Ready for review and is assigned to a reviewer; and clean up the previews after the pull request is merged or closed.
GitHub Marketplace page
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dabit3 @jamesonwilliams please let me know if there is anything need me to do. Thanks!


fix connected props derived props generation

This commit fixes https://github.com/reduxjs/react-redux/issues/965
The essence of the problem is that getDerivedStateFromProps is called when the incoming props OR incoming local state changes. So we cannot store anything in state that is needed in shouldComponentUpdate.
This commit splits up the tracking of incoming props, incoming store state changes, and removes getDerivedStateFromProps and the usage of local state to store any information.
Instead, local state is used as a flag solely to track whether the incoming store state has changed.
Since derived props are needed in shouldComponentUpdate, it is generated there and then compared to the previous version of derived props.
If forceUpdate() is called, this bypasses sCU, and so a check in render() compares the props that should have been passed to sCU to those passed to render(). If they are different, it generates them just-in-time.
To summarize:

shouldComponentUpdate is ONLY used to process changes to incoming props
runUpdater (renamed to triggerUpdateOnStoreStateChange) checks to see if the store state has changed, and stores the state, then updates the counter in local state in order to trigger a new sCU call to re-generate derived state.

Because of these changes, getDerivedStateFromProps and the polyfill are both removed.
All tests pass on my machine, but there is at least 1 side effects to the new design:

Many of the tests pass state unchanged to props, and pass this to child components. With these changes, the two updates are processed separately. Props changes are processed first, and then state changes are processed.

I updated the affected tests to show that there are "in-between" states where the state and props are inconsistent and mapStateToProps is called with these changes. If the old behavior is desired, that would require another redesign, I suspect.

Skimming this very briefly.  My first reaction is that I'm pretty sure we're supposed to be avoiding keeping stuff on the component instance in order for async/Suspense compatibility to work going forward.  I'll try to look at it in more detail in the near future.

If we can't put any data on the component instance, then we would probably
need to set up a component registry, and use a unique key in component
state to fetch the current stuff. Starts to feel hacky. I hope you're
wrong! Have a nice vacation, I'll try to read about the async and suspense
stuff and if there is an obvious no-no, I'll see if I can update the PR to
fix it.

The impression I've gotten is that for things to be properly async-safe, both "data" variables and "non-data" variables should both be kept in component state.  React keeps props and state internally consistent between re-renders, per https://github.com/facebook/react/issues/11527 .
Rough example, based on what I know.  Say React starts to re-render a connected component, and we run some logic that updates an instance field on the component.  However, React pauses the update process partway through calculating the diff for the whole tree, then another update happens (like a keystroke) during that pause.  React sets aside the WIP diff, calculates a new component tree state from the keystroke, applies it, then goes back to look at the previous update that got interrupted.  Depending on where that logic lived, it could get run again, except that if it's basing its decision off an instance field, that field got bumped without the end result actually being applied to the component tree.  So, when our update logic runs again, it could be doing so against incorrect information.
That's why gDSFP is static, to avoid users referring to this and instance fields - in order to be safe, decisions need to be made just based on a properly matched pair of component state and component props.  It does seem that can lead to a lot of awkwardness as you start to shoehorn other variables into component state, especially since React devs have always been told / assumed that component state was "only for values that affect re-rendering".  On the other hand, ReasonReact does indeed use this approach of putting other values (including refs) into component state, so there's precedence.
I'm honestly not sure how this is going to affect our overall memoization approach.  v5 (and to a lesser extent v4) relies on internal memoization for all the handling of mapState and mapDispatch, and I can imagine the sequence I described causing the memoization to not handle things correctly.

The key to fixing redux is understanding what it means to "continue an update." What I've seen looks like the lifecycle will restart, so we could see multiple calls to pre-render methods, and multiple calls to render(). The main thing about redux is that we aren't deriving local state from props alone. We derive it from props and an external state mechanism that is outside of React. Thus it is logically impossible to derive state from props, and that is why 5.1.0-test-1 breaks in React 16.4. The implementation uses closures to simulate an instance method (getting store inside gDSFP).
In other words, if the user is going to load something to populate redux state, and wants to take advantage of the new React stuff, instead of using middleware, they will want to write a fetcher that dispatches an action on completion. Then, when the state updates, it will trigger a local state update that reloads the component.
I could see this as providing a ReduxPromise that can be used in a fetcher:
new store.ReduxPromise(loader, result => actions.loadedStuff(result))

(or some such similar API)
But I don't see how there is any way the async stuff will mess up the PR, unless there is some weird path by which shouldComponentUpdate is called, and then state is changed, and render() is called without re-calling sCU, which would pretty much break everything, wouldn't it?

I'd also suggest reading through Brian Vaughn's recent React blog post about this stuff: https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html

The current implementation is broken in 16.4 precisely because of the content of the article by Brian that you posted above. It's not possible to compare performance when one implementation doesn't work.
However, I do see your point on performance, because of the following:
sCU is invoked in 3 situations:

props change
local state changes
parent re-renders

I forgot about #3. However, this is easily fixed by adding a 1-line test at the top to see if props and state have changed. I don't understand why that makes this approach invalid?
sCU is the only instance method that is called when either props or state changes before render that is async-safe. gDSFP is intended only to construct local state from changes in props, which is not how the current implementation uses it, and that is why it breaks in 16.4

On further reflection, I think that you're right. The only thing we need sCU for is to detect props changes and local state change, so the answer is to move the derived props generation into render() and we can do a "did redux state change change the derived props?" test in the listener and cache those results. This way, we only re-generate derived props for prop changes or for redux state changes.

@timdorr I did another deep dive, and have found a few of things

shouldComponentUpdate is called 1 times less often as getDerivedStateFromProps (only on initialization is it not called and also if forceUpdate is called), so there is no performance difference from the old version in that regard. In other words, gDSFP is called any time the parent re-renders, when props change, or when local state updates. sCU does the same (https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html#anti-pattern-unconditionally-copying-props-to-state)
using PureComponent breaks several tests, because react-redux is supposed to also work with impure components beneath it. So that solution actually doesn't work.
what this means is that react-redux already was expected to re-run the mapStateToProps upon parent re-render, so the solution I've provided works.
I tried updating dev dependency for the master branch to 16.4, and the existing test suite had 12 failures that exactly match the behavior I saw in the wild, reported in #965
@markerikson had a concern in https://github.com/reduxjs/react-redux/issues/965#issuecomment-405083947 that instance props were not async-safe, but that turns out to be untrue (https://github.com/reduxjs/react-redux/issues/965#issuecomment-405350906)

So, I don't think you're right, I encourage you to take another look. Sorry for the churn, this is actually a rather vexing issue to solve right.

P.S. just confirmed in the wild that the PR fixes my app's issues

I've spent the last few hours trying to wrap my head around a bunch of stuff (lifecycle methods, some Suspense info, behavior of React-Redux, etc).  To be honest, my head hurts and I think I'm feeling more confused than I was when I started.
I have a vague feeling that part of the issue here is that v5 currently tries to handle all the update work in one giant super-selector.  But, that's largely due to the way that either changes in store state or own props can cascade through and change the output of mapState, mapDispatch, or even mergeProps.
Per this specific PR: doing work like that in sCU feels very wrong to me, but we were already doing all that work in cWRP originally, and cWRP always precedes sCU, so I think it may be the same perf-wise.  (As a related note, we really ought to collect some of the various benchmark repos that have been floating around since v5 was put together, and put together some formal perf test suites somehow.)
I don't like keeping the current store state as an instance variable.  If we're updating the component state anyway, we ought to include the store state along with the update count there.
I'm also concerned by the changes to the tests where we're bumping up the expected number of mapState calls.  How do things behave currently in regards to passed props and mapState calls, and why are we calling mapState more now?  That there does have some perf implications.

I think it's because of the change from this:
https://github.com/reduxjs/react-redux/blob/76dd7faa90981dd2f9efa76f3e2f26ecf2c12cf7/src/components/connectAdvanced.js#L211-L220
to this:
https://github.com/cellog/react-redux/blob/9f44bed4e80fb7b9e8585dc86987e897a417051c/src/components/connectAdvanced.js#L197-L215
In the original v5 implementation, the subscription callback immediately checks to see if we need to re-render based on the new store state and the existing props.  It then either notifies child subscribers right away if this component is fine, or notifies them after this component has updated.  That way, the children never see the new store state but the old props from the parent.
The prior PR for this task changed the logic to only read the new store state inside a setState() updater function, and then notify children after the component state has been updated.  As a result, the children will see both updated parent props and old store state, and then updated parent props and new store state.
That's bad, and we should figure out a different approach.

Nice, now that I understand how it did it before, I think I can make that happen. I'll take a look tomorrow morning when I have time. Thanks for the logic debug!

Superseded By #980


Add amdserver

This adds documentation for the AMD Inference Server: #2149
Proposed Changes

Adds an example guiding users to build an image and running an example
Adds YAML files and input data for examples

Since we don't have a distributable image right now, I haven't modified servingruntimes.md or serving_runtime.md because using one of the KServe runtimes requires a predefined image in the clusterservingruntimes definition.

@varunsh-xilinx Is this good to review again now?

@yuzisun I'm currently working on documentation for adding a new serving runtime as we discussed earlier. Testing with ModelMesh will take some time so I'm thinking I'll remove the multi-model example for now and focus on the single model case. I'm hoping it'll be ready to review this week

@yuzisun this is ready to review again, thanks

Looks great! Thanks @varunsh-xilinx !
/lgtm
/approve

Thank you for your help @yuzisun!


Is metasv compatible with breakseq2?

Hi @marghoob，
I just noticed breakseq2 repo. Can I replace (old) breakseq with  breakseq2 output as input for metasv?
Best wishes,
Fengyuan

Hi @boboppie ,
MetaSV is compatible with BreakSeq2. In fact, for our paper, we used BreakSeq2. You should try to use the native GFF output of BreakSeq2 as an input to MetaSV.
Regards,
Marghoob.


Linux compile Error

Getting this error on a linux compile:
In file included from ../../include/Polycode.h:108:0,
from ../../include/polycode/bindings/lua/PolycodeLua.h:2,
from ../../src/core/PolyResourceManager.cpp:35:
../../include/polycode/core/PolySDLCore.h:40:42: error: invalid use of incomplete type ‘class Polycode::CoreMutex’
class _PolyExport SDLCoreMutex : public CoreMutex {
^
In file included from ../../include/Polycode.h:71:0,
from ../../include/polycode/bindings/lua/PolycodeLua.h:2,
from ../../src/core/PolyResourceManager.cpp:35:
../../include/polycode/core/PolySoundManager.h:38:11: note: forward declaration of ‘class Polycode::CoreMutex’
class CoreMutex;
^
make: *** [../../src/core/PolyResourceManager.o] Error 1

This is on goodbye_cmake, right?
I made a PR that fixes it, but it's yet to be merged.
For now, you could grab my branch here: https://github.com/sanghakchun/Polycode/tree/linux-build-fix

Ya, gooodbye_cmake. I'll check it out, thanks!


pre-download all the files when packaging  elastic in universe

can elastic pre-download all the files when packaging in universe instead of downloading from the remote when installing it?
I've got into a trouble that when installing elastic, it will download a lot of files from remote such as https://downloads.mesosphere.com/java/jre-8u112-linux-x64-jce-unlimited.tar.gz.
I have an unstable network and the downloading may be very slow. What's more frustrating is that mesos will kill the job after 10 minitues and restart it for new downloading... Everytime I see this 77MB file completed 60MB or more I just feel very complex...
As for quick recovery, I think it's also reasonable for packaging it in previously process so that it takes less time for reinstallation.

There's no support for this at the moment.  However, perhaps the mesos-fetcher cache could help.


left sidebar: Disable "gray-out" feature for new users.

If a user has 30 subscribed streams or less, don't gray
them out if they haven't had recent activity.

Testing Plan:
GIFs or Screenshots:

A small thing, but less make the threshold < 30, rather than <= 30. Just thinking about the various strings we'll eventually need.

I've updated this to turn on the feature at page load (so as not to cause churn, plus it also prevents some performance problems that @timabbott mentioned).
@rishig I also made it so the feature triggers on subscribed_streams >= 30.

Looks great, merged, thanks @showell!


Add support for @iconify/json icon sets in customCollections

As mentioned here, @iconfiy/json style icon sets are currently not supported by the customCollections attribute of unplugin-icons. Support for this feature would be very helpful to integrate commercial icons like Font Awesome Pro.
As an alternative to supporting json style icon sets a the loader function could be extended to apply the fill="currentColor" attribute and other useful defaults (see @iconify/utils/lib/customisations) to SVG files. This way commercial icons like Font Awesome Pro could be loaded directly.
Personally, I lean towards the alternative because it removes the JSON build step that's required for the first approach. Having said that, I'm not familiar with the implications of not going with the JSON approach.

I am not sure if what ./json/fab.json in your code snippet really is. But if it's compatible with Iconify's json data, I think we could export the icon resolver and maybe add an IconifyLoader to be reused for custom sources.
Meanwhile, I see your use FileSystemLoader in your first approach, https://github.com/antfu/unplugin-icons/issues/12#issuecomment-937631130, if that's preferable, we could have a custom transform function to FileSystemLoader as mentioned in #52.
So the usage could be like
"fap-brands": FileSystemIconLoader(
  "PATH_TO/node_modules/@fortawesome/fontawesome-pro/svgs/brands",
  svg => svg.replace(/^<svg /, '<svg fill="currentColor" ')
),


Cancel scan In android device ,application go back two page.Does anyone know how to avoid it？

I'm having the exact same issue. We'll try to fix this internally and I'll provide possible workaround (if succeeded)

I have fix it through update barcodescanner version from 2.0.1 to 4.0.1.Maybe can have a try.
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2016年1月28日(星期四) 下午4:20
收件人<EMAIL_ADDRESS>抄送<EMAIL_ADDRESS>主题: Re: [phonegap-plugin-barcodescanner] Cancel scan In android device ,application go back two page.Does anyone know how to avoid it？ (#115)
I'm having the exact same issue. We'll try to fix this internally and I'll provide possible workaround (if succeeded)
—
Reply to this email directly or view it on GitHub.

Was this ever resolved?


[WIP] Investigation: Missing 'file' key on request.data and missing files

Plan
The plan is to partially pickle requests from customers, load them locally and try to reproduce the issue, peeling off the middleware layers until we find the likely culprit.
Done

[x] rule out multipart boundary
[x] add logs to sentry for inspecting data
[x] copy request and report to sentry
[ ] solve failure with demo 'memo' object not picklable
[ ] try to reproduce on a trimmed-down stack to determine if a middleware triggers the consumption of the request.data iterator-like object.

outdated:
Since the request.data attribute features either file and files as a key depending on whether one or multiple files are multi-parted, I want to see if by any chance the multi-part boundaries mislead QField into considering a single file as many, leading to the absence of the file key.

Task linked: QF-2540 Failed to upload photos. Debug EmptyContentError: Empty content when uploading files

Hm, I thought the file or files are not exclusive alternate key names, but are up to the client to decide and part of the request.
E.g. if you change files on this line with whatever:
https://github.com/opengisch/qfieldcloud/pull/662/files#diff-b7990bb83695b969d33fffd6004e4e9c03377483bd308265aed63950b7b5fc32R96
The server should be able to access the file as request.data.get("whatever")? If this is correct, then you can already have multiple files in request.data.get("file").

@suricactus Is there 100% certainty that any form POST-ing requests meet the requirement mentioned here https://stackoverflow.com/a/5567063/4500155?

As discussed in a call, yes, I would say there is 100% certainty about request being encoded as multipart/form-data.

@why-not-try-calmer I see you requested a review, but the title says WIP and there are some open todos. Do you need a review or do you have specific questions and in the latter case, which ones?

@why-not-try-calmer I see you requested a review, but the title says WIP and there are some open todos. Do you need a review or do you have specific questions and in the latter case, which ones?

Sorry it's a misfire of mine; the few tests I ran locally worked fine but the payload used by one of the tests made it not work anymore. I will ping you when it's ready.

@why-not-try-calmer one small request, can you push instead of force push (i.e. avoid the rebasing)? It makes it quite complicate to follow what is going on for a reviewer with the current workflow.

@m-kuhn Ready for review! The main question is: Do you think that'll work to extract the data we need? (Please consider edited first comment above for an overview).

The approach using 'get_serializers()' did not work, because contrary to my expectations the post method uses only parsers, no serializers per se, resulting in the get_serializers() never being called. This PR now turns to a custom middleware to work around this shortcoming.

Is the update to the libqfield sync module related?

Is the update to the libqfield sync module related?

Squashed and cleaned-up

Looks good to me, can you confirm it is manually tested to behave as expected and then it's good to merge !

Yes:

traceback
File "/usr/local/lib/python3.10/unittest/case.py", line 549, in _callTestMethod\n    method()\n  File "/usr/src/app/qfieldcloud/core/tests/test_qgis_file.py", line 96, in test_push_multiple_files\n    should_fail_on_empty = self.client.post(\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 295, in post\n    response = super().post(\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 209, in post\n    return self.generic(\'POST\', path, data, content_type, **extra)\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 233, in generic\n    return super().generic(\n  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 473, in generic\n    return self.request(**r)\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 285, in request\n    return super().request(**kwargs)\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 237, in request\n    request = super().request(**kwargs)\n  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 714, in request\n    response = self.handler(environ)\n  File "/usr/local/lib/python3.10/site-packages/django/test/client.py", line 145, in __call__\n    response = self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/test.py", line 257, in get_response\n    return super().get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 130, in get_response\n    response = self._middleware_chain(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/debug_toolbar/middleware.py", line 49, in __call__\n    return self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/src/app/qfieldcloud/core/middleware/requests.py", line 16, in middleware\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/utils/deprecation.py", line 117, in __call__\n    response = response or self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django_currentuser/middleware.py", line 34, in __call__\n    response = self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/auditlog/middleware.py", line 41, in __call__\n    return self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/src/app/qfieldcloud/core/middleware/timezone.py", line 25, in __call__\n    return self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/src/app/qfieldcloud/core/middleware/test.py", line 16, in __call__\n    return self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/axes/middleware.py", line 37, in __call__\n    response = self.get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/exception.py", line 47, in inner\n    response = get_response(request)\n  File "/usr/local/lib/python3.10/site-packages/django/core/handlers/base.py", line 181, in _get_response\n    response = wrapped_callback(request, *callback_args, **callback_kwargs)\n  File "/usr/local/lib/python3.10/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view\n    return view_func(*args, **kwargs)\n  File "/usr/local/lib/python3.10/site-packages/django/views/generic/base.py", line 70, in view\n    return self.dispatch(request, *args, **kwargs)\n  File "/usr/local/lib/python3.10/site-packages/rest_framework/views.py", line 506, in dispatch\n    response = handler(request, *args, **kwargs)\n  File "/usr/src/app/qfieldcloud/core/views/files_views.py", line 150, in post\n    print_stack(limit=50, file=buffer)\n`

Pre
  {'file_key': 'dict_keys([])', 'meta': "{'HTTP_COOKIE': '', 'PATH_INFO': '/api/v1/files/543a4c9a-298c-4077-91dd-05b7cd6aa938/file.txt/', 'REMOTE_ADDR': '<IP_ADDRESS>', 'REQUEST_METHOD': 'POST', 'SCRIPT_NAME': '', 'SERVER_NAME': 'testserver', 'SERVER_PORT': '80', 'SERVER_PROTOCOL': 'HTTP/1.1', 'wsgi.version': (1, 0), 'wsgi.url_scheme': 'http', 'wsgi.input': , 'wsgi.errors': <_io.BytesIO object at 0x7f952fb87290>, 'wsgi.multiprocess': True, 'wsgi.multithread': False, 'wsgi.run_once': False, 'CONTENT_LENGTH': '20', 'CONTENT_TYPE': 'multipart/form-data; boundary=BoUnDaRyStRiNg; charset=utf-8', 'QUERY_STRING': '', 'HTTP_AUTHORIZATION': 'Token ze191Q5rUl15DelidbF1NfZUEzZtFYxN9MkJWFVgVIiSoP946vy7yIcZ4tIfXOIJYeTsbrnWJDkTzG3q0V4ELPsqwr4oFXtonuPc'}"}

Post
  {'data': 'dict_keys([])', 'files': 'dict_keys([])', 'meta': "{'HTTP_COOKIE': '', 'PATH_INFO': '/api/v1/files/543a4c9a-298c-4077-91dd-05b7cd6aa938/file.txt/', 'REMOTE_ADDR': '<IP_ADDRESS>', 'REQUEST_METHOD': 'POST', 'SCRIPT_NAME': '', 'SERVER_NAME': 'testserver', 'SERVER_PORT': '80', 'SERVER_PROTOCOL': 'HTTP/1.1', 'wsgi.version': (1, 0), 'wsgi.url_scheme': 'http', 'wsgi.input': , 'wsgi.errors': <_io.BytesIO object at 0x7f952fb87290>, 'wsgi.multiprocess': True, 'wsgi.multithread': False, 'wsgi.run_once': False, 'CONTENT_LENGTH': '20', 'CONTENT_TYPE': 'multipart/form-data; boundary=BoUnDaRyStRiNg; charset=utf-8', 'QUERY_STRING': '', 'HTTP_AUTHORIZATION': 'Token ze191Q5rUl15DelidbF1NfZUEzZtFYxN9MkJWFVgVIiSoP946vy7yIcZ4tIfXOIJYeTsbrnWJDkTzG3q0V4ELPsqwr4oFXtonuPc'}"}


Inline error handling for forms

Code: https://github.com/ExpressionEngine/ExpressionEngine/pull/4093

Closed in favor of #883


CaffeModel2Json Error on running caffemodel2json.py

Hi,
I am getting error while converting the caffe model 2 json using caffemodel2json.py
Command run:
python ./caffemodel2json.py caffe-master/src/caffe/proto/caffe.proto bvlc_alexnet.caffemodel > dump.json
Error:
protobuf: calling protoc Traceback (most recent call last):   File "./caffemodel2json.py", line 65, in <module>     subprocess.check_call(['protoc', '--proto_path', os.path.dirname(args.caffe_proto), '--python_out', args.codegenDir, args.caffe_proto])   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 535, in check_call     retcode = call(*popenargs, **kwargs)   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 522, in call     return Popen(*popenargs, **kwargs).wait()   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__     errread, errwrite)   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child     raise child_exception OSError: [Errno 2] No such file or directory
Could you please help with this.
Thanks

Your problem in on line 65 in caffemodel2json.py which has to do with protoc. I had this issue and what fixed it was uninstalling the versions of protobuf I had previously installed. I did a fresh install using macports with the command port install py27-protobuf. This will install the right dependencies for python2.7 which is the default python on OSX.
I hope this helps.


onSketchSaved can not return filepath in android and also in success it return false

onSketchSaved can not return filepath in android and also in success it return false
onSketchSaved={(success, filePath) => {
    console.log('onSketchSaved', 'filePath: ' + filePath);
 }}

What is your android version?

Fix this by giving permission (Hard permission using permission dialog)to write file


Invalid URL error if resize optional arguments are omitted in plain mode

In the resize section of the docs it states "All arguments are optional and can be omited to use their default values".
I specified resize, resize type, width and height, and it returns an error: http://imgprxy.vinvin.co/resize/fit/100/100/plain/s3://vinvin-assets-prod/boxed-water-is-better-1464049-unsplash.jpg.
If i specify all options, it works correctly: http://imgprxy.vinvin.co/resize/fit/100/100/no/0/plain/s3://vinvin-assets-prod/boxed-water-is-better-1464049-unsplash.jpg.
Am I doing something wrong, or are the docs out of date?

Hi,
You are referring to the advanced URL format docs while using the basic one. Basic URL format requires all options to be specified.
If there is any chance you're using Ruby, you can use the official imgproxy gem for URL generation.


feat: show the day on the calendar

closes #52
Added the day on calendar (with font-light weight). What do you think? @ije
BEFORE

AFTER

Thanks for your reviews!


False [Topic authorization failed] error for topic

Describe the bug
Broker reports [Topic authorization failed] for a topic that KafkaJS could publish to before in the same Producer instance.
Broker provider: Confluent
To Reproduce

set up ACL for your API key (eg. this.is.my.env, PREFIXED)
create a producer instance
send a message to a topic that matches your ACL, like 'this.is.my.env.created', it will pass
send a message to a topic that does NOT match your ACL, like 'this.is.my.otherenv.created', it will fail with error above (as expected)
as in step 3. send a message to a topic that matches your ACL, like 'this.is.my.env.created', it will fail again with the same error (unexpected)

Expected behavior
Messages that matches the ACL will pass even if there were failing attempts before
Environment:

OS: [e.g. Windows 10]
KafkaJS version [e.g. 1.14.0, 1.15.0, 2.0.0]
NodeJS version [e.g. 16.14.0]

Additional context
During debugging I found that the Metadata protocol message buffer contains the forbidden topic name after encoding, even at step 5. send() gets only one topic (that matches the ACL) as a parameter, still the buffer contains the topic name from my previous send attempt.

I was able to reproduce this here: https://github.com/tulios/kafkajs/blob/8cbfb1b88505b2dbf5bcb9bc6e8234d771f1e9bb/src/admin/tests/createAcls.spec.js#L255-L304

Since my report I found an additional use case which leads to the same issue. Regardless of ACLs on your topics publishing to an existing topic after an attempt to publish to a non-existing one has the same effect, except that the error message will be "This server does not host this topic-partition", presumably because of the very same beheviour on metadata fetching as described above.

@Nevon as I see #667 is still open and not approved. Any plans to incorporate it in the next release?

I have a similar issue here: #1377

Sorry to disappoint, but the direction in #667 isn't going to work, as I realized once I spent a few days on it and the cracks started to show. I've elaborated in https://github.com/tulios/kafkajs/pull/667#issuecomment-1143543733
In the meantime, I think this specific issue can probably be solved with a bit of a quick-fix by just removing the topic from targetTopics when we get an authorization error on metadata refresh.

Fixed by #1385


feat: Add opentelemetry extension

name: 🎉 New Feature
about: Add opentelemetry extension for PHP 8.0 to 8.4
labels: enhancement

A Pull Request should be associated with an Issue.
Related issue: #2670
Description
This PR adds OpenTelemetry auto-instrumentation extension for PHP >= 8.0.
PECL: https://pecl.php.net/package/opentelemetry

@siketyan Please add the missing Dir.chdir "opentelemetry-#{version}" line in<EMAIL_ADDRESS>

@shivammathur Added!

:beers: @BrewTestBot has triggered a merge.


Refactor: Remove unused schema validator code

The IngestionSchemaValidator logic was not used in any code path except for 3 unit tests. It appears as if it was used to validate the schema of a segment versus an Avro schema (as Avro was the only implementation of the Schema Validator). But the validator itself is never executed in any code path of Pinot.
This also removes the getColumnStatisticsCollector from SegmentIndexCreationDriver as that method was never being called anywhere.

@jackjlli I saw you contributed this. Is this still in use?

@ege-st They are part of pinot-spi which is intended to be used by some external tool (not maintained in this repo). Do you run into issues with them?

No worries.
On Fri, Feb 23, 2024, 6:49 PM Jialiang Li @.***> wrote:

@.**** requested changes on this pull request.
Hi @ege-st https://github.com/ege-st, this schema validator is actively
being used inside LinkedIn. Basically it attempts to detect any schema
mismatch during segment generation. The stats would be useful to know the
quality of the input data. So please do not remove this part of code.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/pinot/pull/12481#pullrequestreview-1899099705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAASDJ2OCAF3LX75WHSUVILYVETHNAVCNFSM6AAAAABDW5F3ZGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZGA4TSNZQGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

No issues,  but since I couldn't find any path within core Pinot that was
using this logic, I thought the code which uses it might have been removed
at some point.
On Sat, Feb 24, 2024, 1:42 PM Xiaotian (Jackie) Jiang <
@.***> wrote:

@ege-st https://github.com/ege-st They are part of pinot-spi which is
intended to be used by some external tool (not maintained in this repo). Do
you run into issues with them?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/pinot/pull/12481#issuecomment-1962511791, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BAASDJZUIINJY2QDVSRCEE3YVIYALAVCNFSM6AAAAABDW5F3ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGUYTCNZZGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


fixing fn tab after Passing Server Children to Islands heading to if …

New Code: "selected()==index"
This replaces ... "selected()" in the 2nd code block after the chapter heading: "Passing Server Children to Islands".
The new code is already present in the complete code solution further down the page, but for people like me who try coding up block by block, this fix will make such progressions less painful.

Thanks!


Add system packages for ODBC support

Is your feature request related to a problem? Please describe.
To support native ODBC, add apt install odbc-postgresql

Pull requests

https://github.com/Senzing/docker-senzing-base/pull/53


Add links to underlying Boto3 API page

Types in the AWS SDK require users to pass parameters according to the Boto3 API's.
We should provide links to help users get the info they need.
For example: for VPC: http://boto3.readthedocs.io/en/latest/reference/services/ec2.html#EC2.Client.create_vpc

Fixed un #117


fixed menus reacting to held button (switched from IsPressed to IsNewlyPressed)

really, alek? who even uses IsPressed for buttons

👍can you bump the version?


Documentation

function.py:20
Two lines seem to have disappeared here, noticed because the grammar is now wrong.
Secondly, lever=level? Good idea to pull the documentation through a spell check before the next release maybe?
ps. Notwithstanding, I very much like the documentation, and am surprised it took me a year to stumble across this issue ;-)

Fixed in edbf096, thanks for spotting! Also, spell check before release, check!


Enhancement - Allows for inputting initial parameters programmatically…

… via cmd line arguments.
I was attempting to run npx quorum-dev-quickstart via docker and realised it might be a little tricky to get through the prompt menu. To fix this problem I've used https://www.npmjs.com/package/yargs to allow for either cmd line options or the original prompt. This doesn't affect the original method, however it does take an all or nothing approach (as in, either you give all the arguments via command line, or you use the prompt)

… via cmd line arguments.
I was attempting to run npx quorum-dev-quickstart via docker and realised it might be a little tricky to get through the prompt menu. To fix this problem I've used https://www.npmjs.com/package/yargs to allow for either cmd line options or the original prompt. This doesn't affect the original method, however it does take an all or nothing approach (as in, either you give all the arguments via command line, or you use the prompt)

Hi @travis-payne
Thanks for the submission. Could you give us a little bit more context into this use case please? The tool especially in the npx flavour is intended to use used by and for developers to try out various options on the fly
Cheers

@joshuafernandes
Hey, sure!
So I'm currently writing up some unit tests for some Besu functionality, and our current test ledger that we fire up is insufficient for what I'm writing, so I want to run this private network within a docker container. This is part of our automated test suite, so instead of simulating the input to the prompt that pops up when you run the npx command, I want to be able to just add some command line args, such like:
npx quorum-dev-quickstart --elk true --privacy true --clientType besu
To achieve the same result without having to step through the prompt.

@joshuafernandes Any update on this?


Argument of type 'Sound' is not assignable to parameter of type 'DisplayObject'

Usage example encounter TS error:

Usage example encounter TS error:

I forgot to update the example in readme. You should use addSound instead. I will update readme later.

After deep investigation, I find out the solution 😂


[New game]: 3D Car Racing Game

🎮 Game Request
It will be a game website with controls, speed, score, time, and a wonderful viewing experience. I want to develop it using HTML5, CSS3, Javascript, JQuery, etc.
Point down the features

Control Features
Score Detection Features
Time Taken Features

Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @Raisa-12 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @Raisa-12 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Rethrow provider exceptions

When using/developing extensibility providers it’s difficult to follow the execution when exceptions inside the providers isn’t exposed. You could use the trace log capabilities but that give you a little bit too much, I just what the error.
Suggestion:

Log the exception as an error
Rethrow the exception

Hi @afsandeberg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks for your contribution, it has just been merged!


[ROCM] Support rocblas_sgemm_strided_batched

Support rocBLAS batched GEMM and prioritize rocBLAS strategy over codegen when no costs are provided via a tuning config. Also canonicalize invocation of column major rocBLAS APIs for matmul and batched_matmul.

cc @masahi

please take a look at the CI problem

thanks @csullivan

Thank you @masahi !


added resources for gate notes.

I have added another useful resource of GATE notes(even I am currently studying them and found them really useful).
Also a slight typo fix(INstitute --> Institute)

Have a look now.

I guess this looks good now @vicky002 .


How to generate k8s resource manifest?

Question
How should I operate to generate k8s resource manifests ?
I don't want to use operator-sdk custom resource ClusterServiceVersion.
I hope the whole process is completed through pure k8s resources, controllable.
$ operator-sdk version
operator-sdk version: "v1.21.0-6-g28033559", commit: "280335593c76c1fb14ce96100938f140ddb42659", kubernetes version: "v1.23", go version: "go1.18", GOOS: "darwin", GOARCH: "amd64"

@zc2638 Could you please elaborate the question. Do you mean adding generic K8s resources as a part of Custom Resource Definition? Or do you mean that the controller not reconciling the Custom resource and instead just a k8s object?In second case, we don't need to generate/apply manifests of k8s resources since the api-server will already know about it.

Hi @varshaprasad96 ,
I run make bundle to get the ClusterServiceVersion resource.
I hope that I can get the generated Deployment resource by command to deploy the operator, which will be very useful for my business.

/help

Hi @zc2638,
The make bundle creates the bundle.
The bundles are required for you to integrate your solution with OLM.
That means distributing your solution via https://operatorhub.io/ or for example via the RedHat community (https://github.com/redhat-openshift-ecosystem/community-operators-prod/) to add your Project on Openshift/OKD catalogs by default.
The CSV contains only the pods/conatiner which will be used to install the Operator/manager itself.
Therefore, your Operator/magaer will reconcile Kinds ( GKV/CRDs ) with the goal to ensure a desired state on the cluster. In this way, if you have your Operand (app/service) managed by our Operator and configured accordingly on the cluster you need to create a Deployment that MUST be done via the reconciliation. (you can check under the testdata/samples how it is done, see: https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v3/memcached-operator/controllers/memcached_controller.go#L139-L174 )
For Golang projects, you will implement the code, see the Memcached tutorial: https://sdk.operatorframework.io/docs/building-operators/golang/tutorial/
I'd like to suggest to you before beginning to create your project check the following docs which will not be too much effort/time spent and will give to you a better idea:
a) Follow up the tutorial and create the Memcached sample: (like 30 min): https://sdk.operatorframework.io/docs/building-operators/golang/tutorial/
b) Check the Common Suggestions section : (like 15 min) : https://sdk.operatorframework.io/docs/best-practices/common-recommendation/
c) Ensure that you check out the FAQ: https://sdk.operatorframework.io/docs/faqs/#can-i-customize-the-projects-initialized-with-operator-sdk ( like 5 min )


Microsoft.Hadoop.Avro.Tools code generation not converting Avro doc strings to XML comments

Avro schemas can be documented with "doc" fields in their schema definitions.
The Apache.Avro code generator uses these "doc" fields as the XML comments on generated properties, but they are ignored by the Microsoft.Hadoop.Avro.Utils.CodeGenerator.
Example:
...
{
  "name": "title",
  "type": "string",
  "doc": "The title of the position",
  "default": "-"
} ...

Current output:
    /// <summary>
    /// Gets or sets the title field.
    /// </summary>
    [DataMember]
    public string title { get; set; }

Expected output:
    /// <summary>
    /// The title of the position
    /// </summary>
    [DataMember]
    public string title { get; set; }

The Avro SDK is no longer supported by Microsoft.


Allow profile-specific time tracking

Is your feature request related to a problem? Please describe.
When playing across multiple account profiles (e.g. leagues vs. main game), it's difficult/impossible to track which patches are planted on which profile since the timers are shared.
Describe the solution you'd like
Profile-specific time tracking. If I'm in a league world, show my league profile's time tracking. If I hop to a normal world, show my normal profile's time tracking (and/or a drop-down to switch between them manually at will)
Describe alternatives you've considered
Let me clear currently tracked items in the 'time tracking' plugin.

Having notifications persist across profiles could be useful, e.g. to get a reminder to switch back to your main profile to do birdhouses while you are mostly playing your league profile.

This should be done in general for any place there is a per-user configuration saved for something

Profile support was added in f0787178229d967477fea5d52ae35022f712fbde. While leagues has ended, this work will remain in the client, available for us to utilize for future alternate-profile game modes.

Profile support was added in f0787178229d967477fea5d52ae35022f712fbde. While leagues has ended, this work will remain in the client, available for us to utilize for future alternate-profile game modes.


change README.md to make certain actions more detailed

Awesome @raigon44. We're added a list of popular projects on github with issues you can solve towards the end of Readme file. Could you look through them and gimme some feedback on how useful it was for you.