Fix: Private notes page shows not found in offline mode

Details

Private notes page shows not found in offline mode. This PR fixes that.
Fixed Issues

$ https://github.com/Expensify/App/issues/27591
PROPOSAL: https://github.com/Expensify/App/issues/27591#issuecomment-1722975789
Tests

Create a new workspace
Go offline
Go to #admins
Click on header
Go to Private notes

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Create a new workspace
Go offline
Go to #admins
Click on header
Go to Private notes

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/113963320/e4a53812-3a0a-4da3-9f76-20b215cbe9d3

Mobile Web - Chrome

https://github.com/Expensify/App/assets/113963320/c003db89-afc1-4946-ba1f-651ae615c9c7

Mobile Web - Safari

https://github.com/Expensify/App/assets/113963320/e3152265-4340-4cd4-80ea-537e0f8b6062

Desktop

https://github.com/Expensify/App/assets/113963320/58fdba8f-9933-4da7-990a-3f96abf3e030

iOS

https://github.com/Expensify/App/assets/113963320/b71f2d08-3128-455c-ac6a-e594c1c6834f

Android

https://github.com/Expensify/App/assets/113963320/a746fbf6-f9f3-4644-a177-5d1bc5b99111

@tienifr can you please also upload video for web - seems missing - thanks!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/f7f13b4c-332b-44a0-9694-d64eb5eb4394

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/b2657332-9640-49ee-90e2-686b1348987d

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/b98fc28d-4b24-4c6b-b097-8880209e46c4

Desktop
https://github.com/Expensify/App/assets/28352309/78fe6661-2ada-4396-9654-031523aec875

iOS
https://github.com/Expensify/App/assets/28352309/026b6d69-7765-4418-b959-d7c7d29bd020

Android
https://github.com/Expensify/App/assets/28352309/dd0ddfdc-8c08-4cb8-9230-fadb6bedb55a

Sometimes - empty screen is shown and replaced by loading

@narefyev91 You mean the Not found page shows briefly before loading, right?

Yup - forgot how to name it correctly lol - Not Found page

@tienifr @narefyev91 merged!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

QA mentioned this is still failing the linked issue, can you please investigate?

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Use working region/subscription for search deployments

We are running into deployment issues with the search RP and deletion metadata. This switches our search deployments to a working region/subscription until their fix rolls out

/azp run net - search - tests-weekly


Fix minor modification

I heard your presentation in RubyKaigi 2022.
This gem is great! I try something to improve my developed environment with using it.
So, I found little minor modification when trying to do tutorial while reading README.md.
Please check it.
Thanks.

@m11o Thank you first contributor!


Views are under stepBar

The views of my controllers are under the stepBar. How can I remake the constraints ?

Hi there!
You can override - (void)adaptToEdgeInsets:(UIEdgeInsets)newInsets in your view controllera your are presenting with RMStepsController. This tells your where the steps bar is and makes it possible for you to adjust your constraints.
For example, RMStepsController.m contains a category on UITableViewController for adjusting the UITableView content insets based on where the steps bar is.

I have an issue with - (void)adaptToEdgeInsets:(UIEdgeInsets)newInsets. The first controller receive a bad edgeInsets (0 for top, left, right and bottom). The others controllers receive the right edgeInsets.

Hmm, I have seen that issue before, too. But I wasn't able to reproduce it. Do you have some more information? For example a demo project?


decodeLog always returning nil

When I call web3.eth.getTransactionReceipt it returns a TransactionReceipt with one EventLog this Event log has only one topic and the inputs of the event are always greater than 0 so when the ABIv2Decoder calls decodeLog it return nil due to this validation
 if (logs.count == 1 && event.inputs.count > 0) {                   return nil    }
that is on line 216 in the file ABIv2Decoding

Hello @Dusknoir06
This check was intended to filter malformed ABIs in case when there are indexed inputs, but there is only 1 log topic. Apparently there was an error there. Now I've changed it to
        if (logs.count == 1 && indexedInputs.count > 0) {
            return nil
        }

Would you check a latest "master" for your case?
Sincerely, Alex

Closing due to inactivity. Feel free to reopen


Grok implementation details

not an issue but would be nice if it was in the readme/model.py header:
314B parameters
Mixture of 8 Experts
2 experts used per token
64 layers
48 attention heads for queries
8 attention heads for keys/values
embeddings size: 6,144
rotary embeddings (RoPE)
SentencePiece tokenizer; 131,072 tokens
Supports activation sharding and 8-bit quantization
Max seq length (context): 8,192 tokens

@morozover you can find most of the values in https://github.com/xai-org/grok-1/blob/e50578b5f50e4c10c6e7cff31af1ef2bedb3beb8/run.py#L33
Additional see Rotary Embedding implementation @ https://github.com/xai-org/grok-1/blob/e50578b5f50e4c10c6e7cff31af1ef2bedb3beb8/model.py#L635

@andrewgcodes since it is merged at https://github.com/xai-org/grok-1/pull/27, I think this issue can be closed.


ENH new info command to print information about a benchmark

Example of output:
$ benchopt info benchmark_ols -e --dep
Info regarding 'benchmark_ols'
# Datasets
----------
## Boston
- install cmd: conda
- dependencies: scikit-learn
✓ available in env 'benchopt_benchmark_ols'
----------
## Simulated
- parameters: n_samples, n_features
- no installation required
- no dependencies
✓ available in env 'benchopt_benchmark_ols'
----------
# Solvers
----------
## cd
- install cmd: conda
- dependencies: numba, scipy
❌ not available in env 'benchopt_benchmark_ols'
----------
## GD
- doc: Gradient descent solver, optionally accelerated.
- parameters: use_acceleration
- no installation required
- no dependencies
✓ available in env 'benchopt_benchmark_ols'
----------
## sklearn
- install cmd: conda
- dependencies: scikit-learn
✓ available in env 'benchopt_benchmark_ols'
----------

Note: the lines "available/not available" are colorized in green/red (resp.) in the terminal.
The output format/aesthetic is open to suggestion.

This looks awesome! A few questions/comments:

how do you display pip dependencies?
would it be possible to replace install cmd and dependencies with the install line such as conda install pkg and pip install pkg? This would allow to check the install by copy pasting the line.

@tomMoral

I display the pip dependencies like they are written in the solver/dataset object pip:package which could be improved actually.
ok, I'll manage something to improve the printing of conda and pip dependencies.

@tomMoral I am really sorry, I will not have time to finish this before tomorrow. My schedule is full.
Here is what remains to be done:

[ ] rewrite output to directly print install command like conda install pkg or pip install cmd
[ ] add some test in benchopt/tests/test_cli.py

Maybe, it could be for the next release.

@gdurif I stumbled onto this PR and I think that would be a super nice feature ! any chance you can look into it to add a test ? I think the rewriting of install output is not mandatory at this step (my 2 cents, if it's easy to do ignore me)

@mathurinm I move it up at the top of my ToDo list where it kind of got buried under a lot of stuff from the past few months (sorry for that).

Codecov Report

Merging #140 (1a3d537) into main (08f82b0) will decrease coverage by 1.17%.
The diff coverage is 18.96%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   62.66%   61.49%   -1.18%
==========================================
  Files          41       41
  Lines        2100     2158      +58
  Branches      372      385      +13
==========================================
+ Hits         1316     1327      +11
- Misses        688      735      +47
  Partials       96       96

New output:
$ benchopt info benchmark_lasso
Info regarding 'benchmark_lasso'
Checking benchamrk requirement availability in env 'benchopt_dev'.
----------
# DATASETS
----------
## finance
> requirements:
    pip install libsvmdata
✗ not available in env 'benchopt_dev'
----------
## leukemia
> requirements:
    conda install -c conda-forge scikit-learn
✗ not available in env 'benchopt_dev'
----------
## libsvm
> parameters:
    'dataset': 'bodyfat', 'leukemia', 'rcv1.binary'
> requirements:
    pip install libsvmdata
✗ not available in env 'benchopt_dev'
----------
## Simulated
> parameters:
    'n_samples, n_features': '(100, 5000)', '(100, 10000)'
    'rho': '0', '0.6'
> no dependencies
✓ available in env 'benchopt_dev'
----------
# SOLVERS
----------
## Blitz
> requirements:
    pip install git+https://github.com/tbjohns/blitzl1.git@master
✗ not available in env 'benchopt_dev'
----------
## cd
> requirements:
    conda install -c conda-forge numba
✗ not available in env 'benchopt_dev'
----------
## Celer
> requirements:
    pip install celer
✗ not available in env 'benchopt_dev'
----------
## Cyanure
> requirements:
    conda install -c conda-forge mkl
    pip install cyanure-mkl
✗ not available in env 'benchopt_dev'
----------
## glmnet
> requirements:
    conda install -c conda-forge r-base rpy2 r-glmnet r-matrix
✗ not available in env 'benchopt_dev'
----------
## glum
> requirements:
    conda install -c conda-forge glum
✗ not available in env 'benchopt_dev'
----------
## Julia-PGD
> requirements:
    conda install -c conda-forge julia
    pip install julia
✗ not available in env 'benchopt_dev'
----------
## L-BFGS-B
> no dependencies
✓ available in env 'benchopt_dev'
----------
## Lightning
> requirements:
    conda install -c conda-forge cython
    pip install git+https://github.com/scikit-learn-contrib/lightning.git
✗ not available in env 'benchopt_dev'
----------
## Python-PGD
> parameters:
    'use_acceleration': 'False', 'True'
> no dependencies
✓ available in env 'benchopt_dev'
----------
## R-PGD
> requirements:
    conda install -c conda-forge r-base rpy2
✗ not available in env 'benchopt_dev'
----------
## sklearn
> requirements:
    conda install -c conda-forge scikit-learn
✗ not available in env 'benchopt_dev'
----------
## spams
> requirements:
    conda install -c conda-forge python-spams
✗ not available in env 'benchopt_dev'
----------

Note: the lines "available/not available" are colorized in green/red (resp.) in the terminal.

The output is very beautiful and I find this very informative.
A few remarks by decreasing importance:

it takes a bit of time to run, is there a reason for that ?
do you think it would be useful to have -s and -d to filter the output of benchopt info ?

parameters:

'use_acceleration': 'False', 'True'
I would not use quotes, it makes me think that I should pass  a string instead of a bool

conda install pip:packagename does not work I think. To my knowledge there is no single command line starting wih conda to install a package from PyPI
The cross is way bigger than the checkmark
✓ available in env 'base'

Cyanure

dependencies: conda install mkl pip:cyanure-mkl
❌ not available in env 'base'

@mathurinm sorry I forgot to push the latest version :disappointed:
The cross is now smaller, the pip and conda install instructions are separated.
I'll integrate your other suggestions.

Beautiful! Maybe I would put the tick/cross on the same line as the solver name but not sure about this.
I think it is slow because there is a lot of imports by default. Not sure if we can make something better. Usually we use the benchopt.utils.safe_import:skip_import but it can break how we detect if the package is installed or not.
@mathurinm I don't see where you have the conda install pip:...?

I had them for julia-PGD and Cyanue but Ghislain latest push fixes it :tada:

It is slow because I call the method is_installed() for each solver/dataset. Maybe another way to speed this up ?

I added an option for short/long description.
$ benchopt info benchmark_lasso
Info regarding 'benchmark_lasso'
Checking benchamrk requirement availability in env 'benchopt_dev'.
----------
# DATASETS
finance, leukemia, libsvm, Simulated
----------
# SOLVERS
Blitz, cd, Celer, Cyanure, glmnet, glum, Julia-PGD, L-BFGS-B, Lightning, Python-PGD, R-PGD, sklearn, spams
----------

and benchopt info benchmark_lasso -v for the full description as above.
@mathurinm @tomMoral do you think, the long description should be an opt-in (with the --verbose option as it is now), or the short description should be an opt-in (e.g. with a --short option) ?

I would say short description should be the default, to list solvers and datasets available. But no strong opinion on this.

@tomMoral I am writing some tests in benchopt/tests/test_cli.py. I'll finish this on Monday and it will be ready to merge.

Oh! I am super sorry, I did not see your answer and I merged too fast! :/
No big deal as we can add the tests in a follow up PR but I should have double checked, sorry about that.

@tomMoral No problem, I'll open another pull request when I'll finish writing the test.
Thanks


How to dynamicaly pass middlewares into store?

My application uses redux and works on server and client sides. So I need to create 2 different stores, one for server side and one for client. For example, I don't want log actions on server side but want to do it on client. But middlewares passes to store not like an array and I can't dynamicaly create it.
It looks like:
// createStore.js
import { createStore, combineReducers, applyMiddleware } from 'redux';
import thunk from 'redux-thunk';
import callAPIMiddleware from './utils/middlewares/call-api-middleware';
import logger from 'redux-logger';

import * as reducers from './reducers';

export default function(state = {}) {
    const reducer = combineReducers(reducers);
    const createStoreWithMiddleware = applyMiddleware(logger, callAPIMiddleware, thunk)(createStore);

    return createStoreWithMiddleware(reducer, state);
}

How could I remove logger middleware on server side? If it will be array of middleware it will be very simple:
/* global __SERVER__ */
const middlewares = [].concat(
  (__SERVER__ ? [] : [logger]),
  [callAPIMiddleware, thunk]
);

ups, sorry. If anyone wants to get solution - you could simply use spread two times:
/* global __SERVER__ */
const middlewares = [].concat(
  (__SERVER__ ? [] : [logger]),
  [callAPIMiddleware, thunk]
);

applyMiddleware(...middlewares)(createStore);

:+1:


neonvm/runner: Add overcommit factor for CPU limits

Copy-pasting the added comment:

cpuLimitOvercommitFactor sets the amount above the VM's
spec.guest.cpus.use that we set the QEMU cgroup's CPU limit to.
e.g. if cpuLimitOvercommitFactor = 3 and the VM is using 0.5 CPUs, we
set the cgroup to limit QEMU+VM to 1.5 CPUs.
This exists because setting the cgroup exactly equal to the VM's CPU
value is overly pessimistic, results in a lot of unused capacity on
the host, and particularly impacts operations that parallelize between
the VM and QEMU, like heavy disk access.
See also: https://neondb.slack.com/archives/C03TN5G758R/p1693462680623239

With the factor at 4x, this should also resolve neondatabase/cloud#6243 as well (given that the slow starts were only happening when the cgroup was moved from 1 CPU to 0.25 CPUs, and this would bump it up to 4 -> 1 CPUs). But we should wait & see first.

Oh, I think this also supersedes #404 - @hlinnaka to confirm.


Update William Findlay's GitHub username

He has a new GitHub account.

@joestringer we can go ahead and merge this when ready


Verifier error on Linux 5.x (arm64)

Hi  @ti-mo ,  i have an arm64  device running linux  kernel  5.0.0,   i  build  my 5.0.0 version ebpf probe,
but  an  error occurred during   initialize pipeline:
Error: initialize pipeline: initializing BPF probe: loading probe 5.0.0: creating collection: program kretprobe____nf_ct_refresh_acct: can't load program: invalid argument

i  haven't a clue about the problem,  current kernel missing  some necessary configuration ?

Hi @unixisevil, thanks for reporting! I'm currently not actively working on this project, and I don't have an arm64 machine to test this on.
This is likely an eBPF verifier error; is there any more output after this? Could you try upgrading the cilium/ebpf dependency on your local checkout to 0.4.0 or master? The version that's currently used here might be lacking the necessary endianness support.

This is likely an eBPF verifier error; is there any more output after this?

no other output

Could you try upgrading the cilium/ebpf dependency on your local checkout to 0.4.0 or master?

after update cilium/ebpf  lib to  0.4.0,  prev  error disappear, but  another  popped up:
Error: initialize pipeline: initializing BPF probe: loading probe 5.0.0: creating collection: map currct: map create: RLIMIT_MEMLOCK may be too low: operation not permitted

i  run it with root  account, 'operation not permitted' ?

Ah, right. conntracct was built against a branch on my fork of cilium/ebpf, which contains a few patches that aren't included upstream (yet). You could try your hand at rebasing it yourself. I might try my hand at this over the weekend, but no promises. :slightly_smiling_face:

@unixisevil I managed to do a quick rebase of the branch, please try it out. I've removed the commit that automatically sets rlimit, so you'll temporarily have to add that somewhere to conntracct itself (https://github.com/ti-mo/ebpf/blob/conntracct-patches/examples/kprobe/main.go#L33-L40). Just plunk it in main(), doesn't matter. Good luck!

@ti-mo , thanks,  i' ll try it  on Tuesday,  arm device not at hand

@ti-mo ,  I already update  cilium/ebpf  point at  your conntracct-patches  branch, add Setrlimit call  in main()  like this
go.mod:
replace github.com/cilium/ebpf => github.com/ti-mo/ebpf v0.0.0-20210402140228-f520d9212011

main.go:
if err := unix.Setrlimit(unix.RLIMIT_MEMLOCK, &unix.Rlimit{
		Cur: unix.RLIM_INFINITY,
		Max: unix.RLIM_INFINITY,
	}); err != nil {
		log.Fatalf("failed to set temporary rlimit: %v", err)
	}
}
cmd.Execute()

but  same  invalid argument  error:
Error: initialize pipeline: initializing BPF probe: loading probe 5.0.0: creating collection: program kretprobe____nf_ct_refresh_acct: load program: invalid argument

@ti-mo ,  I already update  cilium/ebpf  point at  your conntracct-patches  branch, add Setrlimit call  in main()  like this
go.mod:
replace github.com/cilium/ebpf => github.com/ti-mo/ebpf v0.0.0-20210402140228-f520d9212011

main.go:
if err := unix.Setrlimit(unix.RLIMIT_MEMLOCK, &unix.Rlimit{
		Cur: unix.RLIM_INFINITY,
		Max: unix.RLIM_INFINITY,
	}); err != nil {
		log.Fatalf("failed to set temporary rlimit: %v", err)
	}
}
cmd.Execute()

but  same  invalid argument  error:
Error: initialize pipeline: initializing BPF probe: loading probe 5.0.0: creating collection: program kretprobe____nf_ct_refresh_acct: load program: invalid argument

@unixisevil Thanks for trying it out. This seems to fail in a similar way than https://github.com/cilium/ebpf/issues/266. Will close this for now, as this looks like we have some work to do on the library, and I'm not sure what's causing this at the moment.


ASB-298: Acceptance tests for ASB-289

Also changed styling to remove green background for project header

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error fetching forecast data

After working well for a few months, this week the module stopped successfully updating. On reviewing logs, it seems to be having trouble parsing the response from the NOAA API:
0|MagicMirror  | [2024-06-27 22:38:59.821] [ERROR] Error fetching forecast data: TypeError: Cannot read properties of undefined (reading 'value')
0|MagicMirror  |     at /home/magicmirror/MagicMirror/modules/MMM-2Day-NOAA-Forecast/node_helper.js:84:41
0|MagicMirror  |     at Array.forEach (<anonymous>)
0|MagicMirror  |     at Class.parseData (/home/magicmirror/MagicMirror/modules/MMM-2Day-NOAA-Forecast/node_helper.js:73:22)
0|MagicMirror  |     at /home/magicmirror/MagicMirror/modules/MMM-2Day-NOAA-Forecast/node_helper.js:46:30
0|MagicMirror  |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@davidrea - it looks like the API is no longer returning a relative humidity value in the response data for the forecast.
For a quick fix, add a check to only parse the humidity if it exists in the parseData function in the node_helper.js file:
humid: element.relativeHumidity?.value
Now if there is no humidity value present, it will default to undefined. This will at least let the data get parsed, although your humidity line in the forecast will now show undefined.
To fix that, add a conditional to the lines that add the humidity to the display. In MMM-2Day-NOAA-Forecast.js in the getDom function, wrap the humidity related elements in a check if the humidity value is not undefined:
if(this.forecast[i]?.humid){
     forecastDetail.appendChild(humidIcon);
     forecastDetail.appendChild(humidText);
     forecastDetail.appendChild(humidBr);
}

Thanks for the guidance @taylornoss!
Looks like there is an open pull request that disables the humidity function since it is officially deprecated by NWS: https://github.com/jinserk/MMM-2Day-NOAA-Forecast/pull/3
I added "Closes #4" to the comments of the PR but not sure if that'll auto-close this if/once @jinserk merges it.

Sorry guys and late reply, just merged #3


feat: Spring Data JDBC Dialect

I want to work on this issue

Checklist:

[ ] init commit, add necessary dependencies
[ ] github action to run tests in a module
[ ] Dialect implementation
[ ] integration tests
[ ] README.md
[ ] Github CI


[Bug] baichuan2 7b-13b cannot be 8-bit weight quantized with different error stack.

Checklist

[ ] 1. I have searched related issues but cannot get the expected help.
[ ] 2. The bug has not been fixed in the latest version.

Describe the bug
baichuan2 7b-13b cannot be 8-bit weight quantized.
for baichuan2 7b, the error is: torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 40.00 GiB. GPU 0 has a total capacty of 79.21 GiB of which 32.42 GiB is free.
for baichuan2 13b, the error is: RuntimeError: Currently, quantification and calibration of BaichuanForCausalLM are not supported. The supported model types are InternLMForCausalLM, InternLM2ForCausalLM, QWenLMHeadModel, BaiChuanForCausalLM, LlamaForCausalLM.
Reproduction
lmdeploy lite smooth_quant $path_to_Baichuan2-13B-Chat --work-dir /nvme/qa_test_models/Baichuan2-13B-Chat-inner-w8a8

lmdeploy lite smooth_quant $path_to_Baichuan2-7B-Chat --work-dir /nvme/qa_test_models/Baichuan2-7B-Chat-inner-w8a8

Environment
sys.platform: linux
Python: 3.10.0 (default, Mar  3 2022, 09:58:08) [GCC 7.5.0]
CUDA available: True
MUSA available: False
numpy_random_seed:<PHONE_NUMBER>
GPU 0,1,2,3,4,5,6,7: NVIDIA A100-SXM4-80GB
CUDA_HOME: /usr/local/cuda-11.7
NVCC: Cuda compilation tools, release 11.7, V11.7.64
GCC: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
PyTorch: 2.1.0+cu118
PyTorch compiling details: PyTorch built with:
  - GCC 9.3
  - C++ Version: 201703
  - Intel(R) oneAPI Math Kernel Library Version 2022.2-Product Build 20220804 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v3.1.1 (Git Hash 64f6bcbcbab628e96f33a62c3e975f8535a7bde4)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX512
  - CUDA Runtime 11.8
  - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_90,code=sm_90
  - CuDNN 8.7
  - Magma 2.6.1
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=11.8, CUDNN_VERSION=8.7.0, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-invalid-partial-specialization -Wno-unused-private-field -Wno-aligned-allocation-unavailable -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Werror=cast-function-type -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_DISABLE_GPU_ASSERTS=ON, TORCH_VERSION=2.1.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=1, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF,

TorchVision: 0.16.0+cu118
LMDeploy: 0.2.3+c13f840
transformers: 4.33.0
gradio: 3.50.2
fastapi: 0.109.2
pydantic: 2.6.1

Error traceback
for Baichuan2-13B-Chatm, the error is:
/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
Xformers is not installed correctly. If you want to use memory_efficient_attention to accelerate training use the following command to install Xformers
pip install xformers.
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 3/3 [00:19<00:00,  6.56s/it]
Move model to GPU.
Move lm_head to CPU.
Loading calibrate dataset ...
Token indices sequence length is longer than the specified maximum sequence length for this model (1138791 > 4096). Running this sequence through the model will result in indexing errors
Traceback (most recent call last):
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/bin/lmdeploy", line 8, in <module>
    sys.exit(run())
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/cli/entrypoint.py", line 18, in run
    args.run(args)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/cli/lite.py", line 152, in smooth_quant
    smooth_quant(**kwargs)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/lite/apis/smooth_quant.py", line 74, in smooth_quant
    model, tokenizer, work_dir = calibrate(model, calib_dataset, calib_samples,
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/lite/apis/calibrate.py", line 193, in calibrate
    calib_ctx.calibrate(all_data)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/lite/quantization/calibration.py", line 310, in calibrate
    _ = model(data.to(self.device))
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/zhulin1/.cache/huggingface/modules/transformers_modules/Baichuan2-13B-Chat/modeling_baichuan.py", line 467, in forward
    layer_outputs = decoder_layer(
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/zhulin1/.cache/huggingface/modules/transformers_modules/Baichuan2-13B-Chat/modeling_baichuan.py", line 244, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/zhulin1/.cache/huggingface/modules/transformers_modules/Baichuan2-13B-Chat/modeling_baichuan.py", line 186, in forward
    attn_weights = torch.matmul(
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 40.00 GiB. GPU 0 has a total capacty of 79.21 GiB of which 32.42 GiB is free. Including non-PyTorch memory, this process has 46.79 GiB memory in use. Of the allocated memory 43.48 GiB is allocated by PyTorch, and 2.51 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

for Baichuan2-7B-Chat the error is:

/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/fuzzywuzzy/fuzz.py:11: UserWarning: Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning
  warnings.warn('Using slow pure-python SequenceMatcher. Install python-Levenshtein to remove this warning')
Xformers is not installed correctly. If you want to use memory_efficient_attention to accelerate training use the following command to install Xformers
pip install xformers.
Move model.embed_tokens to GPU.
Move model.layers.0 to CPU.
Move model.layers.1 to CPU.
Move model.layers.2 to CPU.
Move model.layers.3 to CPU.
Move model.layers.4 to CPU.
Move model.layers.5 to CPU.
Move model.layers.6 to CPU.
Move model.layers.7 to CPU.
Move model.layers.8 to CPU.
Move model.layers.9 to CPU.
Move model.layers.10 to CPU.
Move model.layers.11 to CPU.
Move model.layers.12 to CPU.
Move model.layers.13 to CPU.
Move model.layers.14 to CPU.
Move model.layers.15 to CPU.
Move model.layers.16 to CPU.
Move model.layers.17 to CPU.
Move model.layers.18 to CPU.
Move model.layers.19 to CPU.
Move model.layers.20 to CPU.
Move model.layers.21 to CPU.
Move model.layers.22 to CPU.
Move model.layers.23 to CPU.
Move model.layers.24 to CPU.
Move model.layers.25 to CPU.
Move model.layers.26 to CPU.
Move model.layers.27 to CPU.
Move model.layers.28 to CPU.
Move model.layers.29 to CPU.
Move model.layers.30 to CPU.
Move model.layers.31 to CPU.
Move model.norm to GPU.
Move lm_head to CPU.
Loading calibrate dataset ...
Token indices sequence length is longer than the specified maximum sequence length for this model (1138791 > 4096). Running this sequence through the model will result in indexing errors
model.layers.0, samples: 128, max gpu memory: 8.35 GB
model.layers.1, samples: 128, max gpu memory: 10.35 GB
model.layers.2, samples: 128, max gpu memory: 10.36 GB
model.layers.3, samples: 128, max gpu memory: 10.36 GB
model.layers.4, samples: 128, max gpu memory: 10.37 GB
model.layers.5, samples: 128, max gpu memory: 10.37 GB
model.layers.6, samples: 128, max gpu memory: 10.37 GB
model.layers.7, samples: 128, max gpu memory: 10.38 GB
model.layers.8, samples: 128, max gpu memory: 10.38 GB
model.layers.9, samples: 128, max gpu memory: 10.38 GB
model.layers.10, samples: 128, max gpu memory: 10.39 GB
model.layers.11, samples: 128, max gpu memory: 10.39 GB
model.layers.12, samples: 128, max gpu memory: 10.40 GB
model.layers.13, samples: 128, max gpu memory: 10.40 GB
model.layers.14, samples: 128, max gpu memory: 10.40 GB
model.layers.15, samples: 128, max gpu memory: 10.41 GB
model.layers.16, samples: 128, max gpu memory: 10.41 GB
model.layers.17, samples: 128, max gpu memory: 10.42 GB
model.layers.18, samples: 128, max gpu memory: 10.42 GB
model.layers.19, samples: 128, max gpu memory: 10.42 GB
model.layers.20, samples: 128, max gpu memory: 10.43 GB
model.layers.21, samples: 128, max gpu memory: 10.43 GB
model.layers.22, samples: 128, max gpu memory: 10.44 GB
model.layers.23, samples: 128, max gpu memory: 10.44 GB
model.layers.24, samples: 128, max gpu memory: 10.44 GB
model.layers.25, samples: 128, max gpu memory: 10.45 GB
model.layers.26, samples: 128, max gpu memory: 10.45 GB
model.layers.27, samples: 128, max gpu memory: 10.46 GB
model.layers.28, samples: 128, max gpu memory: 10.46 GB
model.layers.29, samples: 128, max gpu memory: 10.46 GB
model.layers.30, samples: 128, max gpu memory: 10.47 GB
model.layers.31, samples: 128, max gpu memory: 10.47 GB
Traceback (most recent call last):
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/bin/lmdeploy", line 8, in <module>
    sys.exit(run())
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/cli/entrypoint.py", line 18, in run
    args.run(args)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/cli/lite.py", line 152, in smooth_quant
    smooth_quant(**kwargs)
  File "/home/zhulin1/miniconda3/envs/lmdeployv23/lib/python3.10/site-packages/lmdeploy/lite/apis/smooth_quant.py", line 84, in smooth_quant
    raise RuntimeError(
RuntimeError: Currently, quantification and calibration of BaichuanForCausalLM are not supported. The supported model types are InternLMForCausalLM, InternLM2ForCausalLM, QWenLMHeadModel, BaiChuanForCausalLM, LlamaForCausalLM.

Apologies for the inconvenience this issue may have caused. At present, the quantization of Baichuan2 through W8A8 is not supported. And related functions will be developed as soon as possible.

Apologies for the inconvenience this issue may have caused. At present, the quantization of Baichuan2 through W8A8 is not supported. And related functions will be developed as soon as possible.

ok, I try it according to https://github.com/InternLM/lmdeploy/blob/main/docs/en/supported_models/supported_models.md.

@HIT-cwh please update supported_models.md


White page is what i get after going to localhost:3000

It seem this is the issue most of us are facing using this deploying the dex - pls, kindly help us fix this.

I am facing the same issue

Same thing on Chrome, Brave, Edge explorer - blank page - title on tab on top of browser only
View Source shows following (Shields down on Brave)
<!doctype html>Hydro SDK Web


Handling multimodule dependencies with shared version

Is your feature request related to a problem? Please describe.
Some libraries split their functionality into multiple modules distributed as separate artifacts so that their users can depend only on the artifacts they really need. One inconvenient thing from the users' perspective here is that the version of each module needs to be specified separately even though in most cases they need to be kept in synch, e.g.
using lib "org.foo::foo-abc:1.2.3"
using lib "org.foo::foo-def:1.2.3"
using lib "org.foo::foo-ghi:1.2.3"

Describe the solution you'd like
We could introduce some way of specifying a dependency on multiple modules of the same library without duplicating the version. Some possibilities:

Specify multiple modules in the same dependency string of a using directive, e.g.

using lib "org.foo::{foo-abc, foo-def, foo-ghi}:1.2.3"

Specify multiple modules in the same using directive with a more explicit nested structure, e.g.

using lib:
  org "org.foo"
  artifacts "foo-abc", "foo-def", "foo-ghi"
  version "1.2.3"

Specify the version of a library just once and then try to infer the versions of the remaining modules, e.g.

using lib "org.foo::foo-abc:1.2.3"
using lib "org.foo::foo-def"
using lib "org.foo::foo-ghi"

This might be tricky however because different artifacts coming from the same organization don't have to be different modules of the same library.

Allow defining constant values inside using directives and referring to them in other directives, e.g.

using value "fooVersion" "1.2.3"
using lib "org.foo::foo-abc:${fooVersion}"
using lib "org.foo::foo-def:${fooVersion}"
using lib "org.foo::foo-ghi:${fooVersion}"

This solution seems both most powerful and most complicated to implement as we would need a new mechanism for defining and substituting constants. To simplify this some restrictions could be added, e.g.:

a constant has to be defined in the same file where it's referenced
a constant has to be defined before it's referenced (when parsing top-down and left to right).
Also this would potentially clash with the proposed syntax for resolving paths https://github.com/VirtusLab/scala-cli/issues/1098

Rely on tooling support, e.g. when a user changes the version of one module, provide a code action for changing the versions of the remaining ones. Here, however, we have similar problems to those from 3)

I vote for syntax 1
using lib "org.foo::{foo-abc, foo-def, foo-ghi}:1.2.3"

Thanks for reporting the issues, based on the examples showed, I don't think there is a sensible solution and is out of scope for Scala CLI especially with the simplified using directives.


Add token mapping strategy

Part of https://github.com/pulumi/home/issues/2609

Is a provider update?

Is a provider update?

No I just bumped the pulumi sdk version, tf-bridge version was already up to date. Strange that there are schema changes

Is a provider update?

No I just bumped the pulumi sdk version, tf-bridge version was already up to date. Strange that there are schema changes

I think we need to run down why we are seeing a schema change when we are only updating the sdk.


Documentation issues

The documentation for the two functions seem to be the same. What's the difference?
The example shows that 'import Pymrmre' should work, but on Ubuntu actually it worked with lowercase letter only.

Hi @gorogm,
I just opened a pull request updating the documentation. I have updated the import statement to use the lowercase version. As far as I can tell, mrmr_ensemble_survival is an incomplete package feature. The only difference between it and the normal mrmr_ensemble function was that it expected targets to have only two columns, event, and survival_time. I removed this function from the main documentation since it has a subset of features of the mrmr_ensemble function.
I recommend just using the mrmr_ensemble function in all cases since you are free to use survival data as whichever features you like.
Best,
Christopher Eeles

Great, thanks a lot!


Feat/section: add test codes, change scss variable

Type of PR (check all applicable)

[x] Feature (feat)

pr 이름을 바꿔야 할 것 같아용! feat(vs-section), feat(vs-page) : ~


Support for Calico 3.5

Rancher version:
v2.2.4
Description:
We need to work with Calico Ver 3.5 because of the pool per name space functionality.
Currently the default is 3.4, when is 3.5 expected?
https://www.projectcalico.org/whats-new-in-calico-3-5/

@jambajaar calico images are updated to the v3.7 for k8s 1.15 - the version that will be default in Rancher v2.3
https://github.com/rancher/kontainer-driver-metadata/pull/3

https://github.com/rancher/rke/issues/1168

Tested with latest build from master using master-head
Create a cluster with network provider set to calico using K8s version - v1.15.0-rancher1-1.
Calico version v3.7.4 gets deployed.
Cluster gets deployed successfully.

All existing automation runs work as expected.


Add Grafana Health Check on GCP

Hey @JoshArmi
Working through this and found out Health checks are not supported for serverless backends. Therefore, backend services containing serverless NEG backends cannot be configured with health checks.
more info on GCP docs - https://cloud.google.com/load-balancing/docs/negs/serverless-neg-concepts
Any thoughts?


build with -DZOSLIB_OVERRIDE_CLIB for creat()

The (new) overridden creat() in zoslib creates a file as ISO8859-1 and tags it, so user no longer has to chtag the generated build files manually, as was previously instructed in the initial z/OS port.
Note that GN build currently fails on z/OS - pending recent PRs in internal zoslib yet to be promoted to ibmruntimes/ (resolve warnings now treated as errors by GN, resolve a pause followed by garbage emitted in V8's gn run, overrides creat(), etc.).
The only file that will be tagged as mixed binary and text in V8's gn-generated files is toolchain.ninja (m ISO8859-1 instead of t ISO8859-1), because of the std::ios_base::binary in NinjaToolchainWriter::RunAndWriteFile's std::ofstream open(). However, zopen's vim, grep and ninja can still read it fine, so I left this change out:
+#if !defined(OS_ZOS)
   file.open(FilePathToUTF8(ninja_file).c_str(),
             std::ios_base::out | std::ios_base::binary);
+#else
+  file.open(FilePathToUTF8(ninja_file).c_str(), std::ios_base::out);
+#endif

fyi the required zoslib commits have now been upstreamed to ibmruntimes.

Excellent! Many thanks. I’ll merge it in morning.

I will attempt to see if it builds in Jenkins.  It fails to build for me.  Same error as before the patch.
/run tests

I will attempt to see if it builds in Jenkins. It fails to build for me. Same error as before the patch.
/run tests

Hey John, we'll need to merge the zoslib zopen branch with main. The Node.js team is currently using the main branch and z/OS Open Tools is using zopen. I going to try to update zopen and create a PR for main so that we can use one branch going forward. For now, you will probably need to do a build of zoslibport and change the branch to main to pick it up or you can cherry-pick Gaby's latest changes into your local zopen branch.

Hello John. Following Igor's comment above (using main branch of https://github.com/ibmruntimes/zoslib), has your build/test of gnport been successful?

Hello @gabylb and @IgorTodorovskiIBM , my understanding from speaking with Igor is that its not just a simple matter of re-directing the zoslib port to a different branch.  Since the code as configured in buildenv simply states that zoslibport is a dependency, I'm not even sure at this point, how/if we can specify a particular branch for a dependency.  ie. your patch is for zoslib:main and zoslibport uses zoslib:zopen.  (repo:branch)
Rather than work on that at the moment.  I'm working on depot_toolsport at the moment.  I will most certainly circle back to this issue.  Perhaps we can discuss best approaches and I can use your input as a guide.  FWIW, I'm thinking maybe we adjust your patches to be based on zopen branch.
Thanks for getting back to me.

@netskink till zoslib's zopen branch contains the latest commits from main branch, you may want to try building it as follows:
cd ~/tmp
git clone https://gn.googlesource.com/gn
cd gn
git apply <path-to-gnport>/patches/build.gen.py.patch

mkdir third_party
cd third_party
git clone https://github.com/ibmruntimes/zoslib
cd zoslib
./build.sh -c -r -t

cd ~/tmp/gn
build/gen.py --zoslib-dir `pwd`/third_party/zoslib
ninja -C out -j 8 -v
out/gn_unittests

Thanks!  I'll give that a shot. I appreciate it.


Feature:  Link within the comments open in new tab

Every time I click on links within the comments of a post it opens the url within the same tab and when I go back I lose my place in the comments.   It would be great if hn-special could add target _blank to all links within comments.

To learn how to read these recently

Closing as a dupe of #21, which I see you also created some years ago :P We'll keep the discussion there.


Content Fragment Import has stopped working

Required Information

[Adobe Experience Manager 2024.5.16544.20240530T165853Z-240500 ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: _______
[5.4.0] ACS AEM Commons Version: _____
[ yes ] Reproducible on Latest? yes/no

Expected Behavior
When uploading an Excel sheet, all works fine, but when I start the process, it takes a second and after that nothing is imported. We have tried different excel sheets and also several users, with same result.
When I return to the overview screen, I don't get an error message, but as you can see in the screenshot added to this case, it looks strange stating "n/a" under Started and Completed columns.
Actual Behavior
Please describe briefly the actual behavior, i.e. when I do X, Z happens.

Steps to Reproduce
The url where I have worked on (prod)
https://author-xxx-xxx.adobeaemcloud.com/apps/acs-commons/content/manage-controlled-processes.html
Links
Links to related assets, e.g. content packages containing test components

Do you have a Excel file you can share that is breaking?

Hello David,
Yes, please find the attached file, this is one that's not working.
Thanks,
Jonas
Jonas Kullberg
Stena Line Scandinavia AB | 405 19 Gothenburg, Sweden
Office: +4631858155 | Mobile: +46704858155
From: david g. @.>
Sent: den 25 juni 2024 19:42
To: Adobe-Consulting-Services/acs-aem-commons @.>
Cc: Kullberg Jonas @.>; Author @.>
Subject: Re: [Adobe-Consulting-Services/acs-aem-commons] Content Fragment Import has stopped working (Issue #3361)
Do you have a Excel file you can share that is breaking?

Reply to this email directly, view it on GitHubhttps://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/3361#issuecomment-2189592511, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BJIHQS7CHU5OVE6ER2M2ORTZJGTXNAVCNFSM6AAAAABJNY4YHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGU4TENJRGE.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

@JonasSweden I dont see your Excel - but i did try with this simple import file:

..And it works  with AEM 6.5. SP21 and ACS Commons 6.6.2.

You have to make sure you have ae CF Model defined at the template path in the Excel, and that model is allowed under whatever path youre created the CFs at.
You also cannot have content at the part the new CF will resolve to (for example, if you careated a folder a /content/dam/we-retail/test-1 the import fails because there's a folder at the location youre trying to create a CF at.

Thanks for looking into this.
Not sure why the excel file gets stripped off the email when I send it to you.
The excel file we’ve worked with previously (same as I attached)  have worked fine up until last week. Then all of a sudden none of our excel sheets that we are using, both by me and my colleagues, stopped working.
We have an older version of AEM commons, so we will try also to upgrade it to latest to see if it will help.
I have attached the file again, this time on the web form.
Thanks,
Jonas
AppTexts bulk import.xlsx


Examples section and APIs section of documentation not building properly

I cloned the repo and created a test branch off Master. I followed the instructions to build  the docs and they built but with a bunch of errors. The API section is blank and the Example section has broken images and errors. I have attached my local build so you can see the issues too
build.zip
.

@JennaPaikowsky, do you run the script in ci/build_doc.bat? that might help

Hi @JennaPaikowsky, I guess this is ok now, closing as stale. Please reopen if still relevant.


Update .gitignore

Uhm. This is a little much for this project i'm afraid. We can probably add some additional items to our gitignore, but we really don't need any django or celery (to name a few). Why add so much?

@Kilian in case you need it in the future :)

Agree with @Kilian, this seems excessive.


[cluster-test] Add --deploy and --run_ci_suite to run from Circle

Unlike existing --run, --run_ci_suite will only run suite once and indicate with exit code whether run was successful.
This also adds --deploy <hash> to optionally deploy new version before performing other actions. At the moment --deploy will only work for cluster-test workplace, but this can be changed later to support custom workplaces.

@bors-libra r+

:pushpin: Commit 490b36b has been approved by ankushagarwal

:hourglass: Testing commit 490b36ba642fa857275eeee0b9f77990a2b198b2 with merge cc49d136ac32cfc3abc7c97cb28c02452cd39923...

@bors-libra r-
Needs small edit

@bors-libra r=ankushagarwal

:pushpin: Commit 33b9b62 has been approved by ankushagarwal

:hourglass: Testing commit 33b9b624e8dc7d27703889a2226d4e21032fc6f1 with merge 5791f9a352bb8f0e5f310c882b339d34b081ab30...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing 5791f9a352bb8f0e5f310c882b339d34b081ab30 to master...


put youtube conf teaser videos on website

What do you think @jancborchardt ?

Turns out that changing the thumbnail image makes the video fit in way better ;-)

@jancborchardt ok with this?

On the conf subpage, the first thumbnail looks wayyyy better at least. But is it possible to use 2 different ones?
On the main page, we should also have a header for the video like »Join us at the ownCloud Contributor Conference« (oCC being linked to /conf)
And on the conf page, it should be theme=dark (or default) instead of light.

I can't have two different thumbnails, but I can fix the theme and add a header for the video.

I’d prefer the first thumbnail then (just white logo over Brandenburg Gate). It also works ok for the main page if we have the header with link to /conf there.
@owncloud/designers what do you think?

Go go go :)

ok, ok ;-)


BUG: The onLoadChildren method cannot be executed

When I press the home key, switch the app to the background and then switch to the foreground. click the  "Genres" item， The onLoadChildren method cannot be called。。。why???

oh， new BrowserRoot(MEDIA_ID_ROOT, null)。here cannot be null.......

mRootHints {EXTRA_CLIENT_VERSION:CLIENT_VERSION_CURRENT},
the value of mRootHints is removed，so when switch to the foreground，The Service cant return the MessagerImpl，therefor i cannot registerCallbackMessenger() , i cannot subscribe successfully。。
is  that  the bug of support-v4 ????

Sorry, but I'm not sure exactly what you mean. I suspect it may be fixed with the latest version of the support library (which I just updated the project to)?

the latest version of the support library doesnt work. The MusicService should run in another process. It dose work.

Running the MusicService in a separate process isn't supported, for the very least reason that the Cast SDK doesn't support multiprocess playback.


Support other dbase/foxpro files (.dbc, .dbf, .frx, .lbx, .mnx, .pjx, .scx, .vcx)

Visual FoxPro uses tables to store data that defines different file types. The following list includes the file types that are saved as tables:

Database (.dbc)
Form (.scx)
Label (.lbx)
Menu (.mnx)
Project (.pjx)
Report (.frx)
Table (.dbf)
Visual class library (.vcx)

You can use and browse these files in the same way that you browse any table file because these files are actually tables.

https://learn.microsoft.com/en-us/previous-versions/visualstudio/foxpro/st4a0s68(v=vs.80)

Currently, tables (DBF) and the associated memo (FPT) files are supported and database tables (DBC) and the associated container (DCT) files can be opened to the extent that the tables belonging to the database can be read. Relations and other data are not read because I do not know how to interpret them. I have not yet found any documentation on this.

@Valentin-Kaiser  I got error
dbase-io-opentable-5:dbase-io-preparedbf-2:dbase-io-validatefileversion-1:untested DBF file version: 3 (0x3)
Do you will support this version?

Hi @nicola-spb
According to the visual studio foxpro documentation, 3 (0x3) is not a valid file type. See the Table Header Record Structure.
This error simply means that this file type was not tested by me, you can easily bypass the check by setting Untested to true in the configuration.


Confirmation email link completely broken

Describe the bug
In the confirmation email received after registration, the Confirm button changes colour, but clicking on it does nothing. When I look at the actual HTML, I see:

                                            Confir=
m

which looks like an encoding issue (').
To Reproduce
Steps to reproduce the behavior:

Register a new email
Open email
Find email from Venue
Attempt to click on Confirm
See that it doesn't go to a new link

Expected behavior
Clicking on Confirm should open a link to the signup screen.
Screenshots

Additional context
n/a
Reported by @Lyncis.

This seems to be working on Dev; I wonder if it was a problem with an old container on localhost again.


refactor deleteDataSource interface

Description
Fixes: https://github.com/dust-tt/tasks/issues/1175
Context: https://github.com/dust-tt/dust/pull/2972
Risk
N/A pure interface change.
Deploy Plan

deploy front

cc @flvndvd @tdraier error discussion

PMRR


Update faq.html

Update links for NHS digital Practice Level prescribing pages (Inc main page, more information and glossary)
Practice level prescribing in England: a summary
More Information section
Glossary

These look good but there are another 5 to change (same link).

[ ] Line 92
[ ] Line 127
[ ] Line 144
[ ] Line 190 (x2 links)

@chrisjwood16 have updated those lines. Please may you review.

@richiecroker are you able to merge this branch pls? I am not an authorised user


Cmdlet does not work in Windows PowerShell

The cmdlet does not work in Windows PowerShell, only in PowerShell 6+.
It should also work in Windows PowerShell 5.1 (or at least give a notification on that it doesn't work in Windows PowerShell
C:\...> New-AzDoServiceConnection @Parameters -Verbose -AzDoConnectionName ...
VERBOSE: Starting Function New-AzDoServiceConnection
VERBOSE: Scope set: /subscriptions/...
VERBOSE: No start date provided - using the current time as default.
VERBOSE: No value specified for -EndDate parameter; setting the value to one year after start date.
VERBOSE: No application id provided - created new AD application with application id '...'
WARNING: Assigning role 'owner' over scope '/subscriptions/...' to the new service principal.
VERBOSE: Role assignment with role 'owner' and scope '/subscriptions/...' successfully created
for the created service principal.
VERBOSE: Created ServicePrincipal example
VERBOSE: GET https://dev.azure.com/.../_apis/projects?api-version=6.0 with 0-byte payload
VERBOSE: received 537-byte response of content type application/json; charset=utf-8; api-version=6.0
VERBOSE: Collected Azure DevOps Projects
VERBOSE: Collected ID: ...
ConvertFrom-SecureString : A parameter cannot be found that matches parameter name 'AsPlainText'.
At C:\Users\...\WindowsPowerShell\Modules\NewAzDoServiceConnection\0.0.3\NewAzDoServiceConnection.psm1:178 char:92
+ ...  = ($ServicePrincipal.Secret | ConvertFrom-SecureString -AsPlainText)
+                                                             ~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [ConvertFrom-SecureString], ParameterBindingException
    + FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.ConvertFromSecureStringCommand

VERBOSE: Creating Connection
VERBOSE: POST https://dev.azure.com/.../.../_apis/serviceendpoint/endpoints?api-version=6.0-preview.4 with
0-byte payload
Could not create Connection: Value cannot be null.
Parameter name: endpoint
At C:\...\Documents\WindowsPowerShell\Modules\NewAzDoServiceConnection\0.0.3\NewAzDoServiceConnection.psm1:209 char:9
+         Throw "Could not create Connection: $($ErrorMessage.message)"
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Could not creat... name: endpoint:String) [], RuntimeException
    + FullyQualifiedErrorId : Could not create Connection: Value cannot be null.
Parameter name: endpoint

Version 0.0.4 has been pushed to the Gallery, which fixes this issue.
The cmdlet now works in Windows PowerShell


[py2py3] Fix unittest from dmwm#10529, Proxy_t

Fixes the Proxy_t unittests from #10529
Status
Ready
Description
Does the proper bytes/string conversions needed for remove py3 related Errors from Proxy_t unittest.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
NA
External dependencies / deployment changes
NA

test this please


TestGoFuzzCrashers fails on 32-bit systems

On i386, the tests fail by trying to create too large a slice:
=== RUN   TestGoFuzzCrashers
--- FAIL: TestGoFuzzCrashers (0.00s)
panic: runtime error: makeslice: len out of range [recovered]
	panic: runtime error: makeslice: len out of range

goroutine 374 [running]:
panic(0x824b780, 0x186a60a8)
	/usr/lib/go-1.7/src/runtime/panic.go:500 +0x331
testing.tRunner.func1(0x186a8200)
	/usr/lib/go-1.7/src/testing/testing.go:579 +0x14f
panic(0x824b780, 0x186a60a8)
	/usr/lib/go-1.7/src/runtime/panic.go:458 +0x40b
github.com/streadway/amqp.readLongstr(0x8345dc0, 0x1885a0a0, 0x0, 0x0, 0x0, 0x0)
	/build/golang-github-streadway-amqp-0.0~git20170313.0.afe8eee/obj-i686-linux-gnu/src/github.com/streadway/amqp/read.go:112 +0xeb
github.com/streadway/amqp.readTable(0x8345dc0, 0x1885a0a0, 0x0, 0x0, 0x0)
	/build/golang-github-streadway-amqp-0.0~git20170313.0.afe8eee/obj-i686-linux-gnu/src/github.com/streadway/amqp/read.go:269 +0x7e
github.com/streadway/amqp.(*reader).parseHeaderFrame(0x18824f1c, 0x18851610, 0xefbfbd5b, 0x0, 0x0, 0x0, 0x0)
	/build/golang-github-streadway-amqp-0.0~git20170313.0.afe8eee/obj-i686-linux-gnu/src/github.com/streadway/amqp/read.go:363 +0x3cc
github.com/streadway/amqp.(*reader).ReadFrame(0x18824f1c, 0x0, 0x0, 0x0, 0x0)
	/build/golang-github-streadway-amqp-0.0~git20170313.0.afe8eee/obj-i686-linux-gnu/src/github.com/streadway/amqp/read.go:64 +0x2f0
github.com/streadway/amqp.TestGoFuzzCrashers(0x186a8200)
	/build/golang-github-streadway-amqp-0.0~git20170313.0.afe8eee/obj-i686-linux-gnu/src/github.com/streadway/amqp/read_test.go:21 +0x20b
testing.tRunner(0x186a8200, 0x829c998)
	/usr/lib/go-1.7/src/testing/testing.go:610 +0x8c
created by testing.(*T).Run
	/usr/lib/go-1.7/src/testing/testing.go:646 +0x2a5
exit status 2
FAIL	github.com/streadway/amqp	1.985s

AFAICS a slice can not be larger than the maximal value of (signed) int. Since the test is trying to create a slice of length<PHONE_NUMBER>, it fails in this case since this value exceeds the range of a 32-bit signed integer.

Might be unrelated, but === RUN   TestGoFuzzCrashers fatal error: runtime: out of memory just failed: https://travis-ci.org/streadway/amqp/jobs/231620575


Idea: Main screen should be "exchange" directly

On mobile (Android) the first screen i see is token listing.
since the token listing is visible at the bottom, I rather put the exchange screen with 1 EOS <=> USD

Should look like this :


Fails on my own videos.

Hey guys!
I followed the instructions and trained on the UCF101 dataset and it reports test accuracy of 86%+ with a batch size of 10 clips and 16 frames per clip. but  when I try it with my own video, almost none is predicted correctly. Is there something wrong or it's just overfitted?

I have the same problem as you. Have you solved it yet？

nope. I think it's over fitted.

@joshualeung Please how did you train with you own videos, I'm having challenge figuring out how to fine tune the model to train on my own videos


Bugfix/essifi 162 rule all submission requirements

One important bug fix in Presentation Definition Validation process.
Some test cases added regarding Gataca test VCs and PD

Codecov Report

Merging #79 (9a3c485) into develop (4aba7e6) will increase coverage by 4.09%.
The diff coverage is 97.19%.

@@             Coverage Diff             @@
##           develop      #79      +/-   ##
===========================================
+ Coverage    91.58%   95.68%   +4.09%
===========================================
  Files           57       59       +2
  Lines         1950     1970      +20
  Branches       358      362       +4
===========================================
+ Hits          1786     1885      +99
+ Misses         163       84      -79
  Partials         1        1

Flag
Coverage Δ

unittest
95.68% <97.19%> (+4.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

lib/PEXv1.ts
92.85% <ø> (+83.92%)
:arrow_up:

lib/evaluation/evaluationClient.ts
89.36% <ø> (ø)

...b/evaluation/handlers/abstractEvaluationHandler.ts
90.00% <ø> (ø)

lib/signing/types.ts
100.00% <ø> (ø)

...ib/validation/bundlers/presentationSubmissionVB.ts
100.00% <ø> (ø)

lib/validation/bundlers/submissionRequirementVB.ts
100.00% <ø> (ø)

...uationHandler/sameSubjectPresentationSubmission.ts
100.00% <ø> (ø)

.../validation/bundlers/presentationDefinitionV1VB.ts
98.00% <83.33%> (-0.98%)
:arrow_down:

lib/types/SSI.types.ts
71.57% <87.50%> (-14.63%)
:arrow_down:

lib/types/SSITypesBuilder.ts
96.15% <88.88%> (-0.28%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aba7e6...9a3c485. Read the comment docs.


Search bar on android

This is what the search bar looks like on android at the moment:

thanks @elie222 this should now be fixed!

Search bar now crashes the app:

I'm using the latest version and the searchbar's still look the same as @elie222 mentioned... This should be reopen.

I'll check this out today, hope to have a fix and a new version out asap.

@monte9 This may be a good issue to jump on if you have the time, thanks.

@lednhatkhanh unfortunately, I am unable to reproduce this. I am using SearchBar like such and it looks fine to me:
<SearchBar
   placeholder="Search Players..."
/>

Can you share the code you are using that's causing this? Afaik, it should be fixed.

Ok, closing this, it also worked for me but removed the default underline and improved the border radius on Android. Thanks @Monte9 for checking this out.


[release-0.22] Upgrade to latest dependencies

webhook fixes -dprotaso
/cc knative-sandbox/source-wg-leads
/assign knative-sandbox/source-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/pkg 952fdd9...983897f:
  > 983897f [release-0.22] allow unknown metadata fields (# 2257)
  > 6ea2c43 Drop redundant pointers and decoders (# 2262)
bumping knative.dev/serving baed25a...3e9a4e3:
  > 3e9a4e3 [release-0.22] run kind e2e in release branches (# 11139)
  > 95fe811 Change magic DNS to sslip.io (# 11299)
  > 813aa65 dont add labels with empty values (# 11114)
  > 5dba505 Redo 10615 - add UID labels (# 11108)
bumping knative.dev/eventing 8f35d42...6aa0b41:
  > 6aa0b41 Use new label for defining a cluster-local Knative Service (# 5403)
  > 6d63984 Add podAntiAffinity labels to remaining HA control plane pods (# 5414)
  > 0d8411e Drop --strict flag on ko (# 5513)
  > 7c0b477 fix(PingSource): remove annotation based conversion logic (# 5234)

/lgtm
/approve


Whatsapp PUSH notifications

Ubuntu 20.04
Node 16
WhatsApp <IP_ADDRESS>(the same error was on previous versions)
iOS 16.0 (the same error was on previous versions)
Wppconnect 1.7.3
after connecting whatsapp to wppconnect
push notifications stop coming to the phone, as soon as I disconnect from wppconnect, everything starts working (notifications come)
config.json
{   "secretKey": "THISISMYSECURETOKEN",   "host": "http://localhost",   "port": "21465",   "deviceName": "WppConnect",   "poweredBy": "WPPConnect-Server",   "startAllSession": true,   "tokenStoreType": "file",   "maxListeners": 15,   "customUserDataDir": "./userDataDir/",   "webhook": {     "url": null,     "autoDownload": true,     "uploadS3": false,     "readMessage": false,     "allUnreadOnStart": false,     "listenAcks": true,     "onPresenceChanged": true,     "onParticipantsChanged": true,     "onReactionMessage": true   },   "archive": {     "enable": false,     "waitTime": 10,     "daysToArchive": 45   },   "log": {     "level": "error",     "logger": ["console", "file"]   },   "createOptions": {     "browserArgs": [       "--disable-web-security",       "--no-sandbox",       "--disable-web-security",       "--aggressive-cache-discard",       "--disable-cache",       "--disable-application-cache",       "--disable-offline-load-stale-cache",       "--disk-cache-size=0",       "--disable-background-networking",       "--disable-default-apps",       "--disable-extensions",       "--disable-sync",       "--disable-translate",       "--hide-scrollbars",       "--metrics-recording-only",       "--mute-audio",       "--no-first-run",       "--safebrowsing-disable-auto-update",       "--ignore-certificate-errors",       "--ignore-ssl-errors",       "--ignore-certificate-errors-spki-list"     ]   },   "mapper": {     "enable": false,     "prefix": "tagone-"   },   "db": {     "mongodbDatabase": "tokens",     "mongodbCollection": "",     "mongodbUser": "",     "mongodbPassword": "",     "mongodbHost": "",     "mongoIsRemote": true,     "mongoURLRemote": "",     "mongodbPort": 27017,     "redisHost": "localhost",     "redisPort": 6379,     "redisPassword": "",     "redisDb": 0,     "redisPrefix": "docker"   } }

This is not an error, Whatsapp itself works that way.

This is not an error, Whatsapp itself works that way.

and this is not how not to fix it?

This is not an error, Whatsapp itself works that way.

and this is not how not to fix it?

When you connect to whatsapp web through a window it automatically stops sending notifications to the phone. As far as I know it's not possible.

This is not an error, Whatsapp itself works that way.

and this is not how not to fix it?

When you connect to whatsapp web through a window it automatically stops sending notifications to the phone. As far as I know it's not possible.

As far as I know, you can disable this feature using google chrome
settings/advanced/alerts.
But how to do it for wppconnet
in Ubuntu?

identificado que o comportamento normal da própria whatsapp e não da aplicação wppconnect.

--disable-notifications
add this to "browserArgs" list & try to restart yarn

Check this link out for various Chrome related Commands
CHROME CLI

can we do something like this?
https://github.com/code-chat-br/whatsapp-api/commit/bee0a5c4ed2ed7835e0031f30ee9429e9cb8ce17
@renat473 @icleitoncosta

can we do something like this?
https://github.com/code-chat-br/whatsapp-api/commit/bee0a5c4ed2ed7835e0031f30ee9429e9cb8ce17
@renat473 @icleitoncosta

You can do it, but you stop receiving important notifications.

can we do something like this?
https://github.com/code-chat-br/whatsapp-api/commit/bee0a5c4ed2ed7835e0031f30ee9429e9cb8ce17
@renat473 @icleitoncosta

I reopened the issue to include the function of setting the online status as false here on the server, using the setOnlinePresence from the library, so that you can do that.

can we do something like this?
code-chat-br/whatsapp-api@bee0a5c
@renat473 @icleitoncosta

You can do it, but you stop receiving important notifications.

Important notification like what?


[BUG] Admin topup doesn't work with the Blink funding source

Describe the bug
The admin topup from Users TOPUP button or the User - Wallet list does not work when using the Blink funding source.
Tested that it works when using CLN.
To Reproduce
Steps to reproduce the behavior:
Attempt top up a wallet with Users TOPUP button or the User - Wallet list
Expected behavior
Have the balance change with the topped up amount.
Screenshots
screenshots showing topup success notification, then the balance back to 0

Desktop (please complete the following information):

LNbits version: 0.12.10 (on Raspiblitz v0.11.2)
Database postgres

Additional context
Logs of a topup attempt:
Aug 29 12:44:46 raspberrypi sh[2798814]: 2024-08-29 12:44:46.52 | INFO | <IP_ADDRESS>:0 - "GET /favicon.ico HTTP/1.1" 200
Aug 29 12:44:49 raspberrypi sh[2798814]: 2024-08-29 12:44:49.86 | INFO | <IP_ADDRESS>:0 - "GET /users/api/v1/user/23c64d8ad70340de9390a28d17405c69/wallet HTTP/1.1" 200
Aug 29 12:45:13 raspberrypi sh[2798814]: 2024-08-29 12:45:13.97 | INFO | <IP_ADDRESS>:0 - "GET /users/api/v1/user/4a653d2b80d743cd9ff62b4cb4aa8991/wallet HTTP/1.1" 200
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.36 | DEBUG | lnbits.core.services:calculate_fiat_amounts:116 | Calculated fiat amounts wallet.id='c2adfafd57574442914c9b874ef73574' amount=100000 currency='sat': extra=None
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.39 | INFO | lnbits.tasks:internal_invoice_listener:111 | > got internal payment notification
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.39 | INFO | <IP_ADDRESS>:0 - "PUT /users/api/v1/topup HTTP/1.1" 200
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.40 | DEBUG | lnbits.core.models:check_status:296 | Checking incoming pending payment 557abc3a405de2a3bd4d9d3cd8e10cf016f2f14948e4be893c9bb35b6512928b
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.42 | INFO | <IP_ADDRESS>:0 - "GET /users/api/v1/user?limit=10&offset=0&sortby=balance_msat&direction=desc HTTP/1.1" 200
Aug 29 12:45:21 raspberrypi sh[2798814]: 2024-08-29 12:45:21.84 | DEBUG | lnbits.core.models:check_status:307 | Status: pending
Aug 29 12:45:47 raspberrypi sh[2798814]: 2024-08-29 12:45:47.76 | INFO | <IP_ADDRESS>:0 - "GET /users/api/v1/user/4a653d2b80d743cd9ff62b4cb4aa8991/wallet HTTP/1.1" 200

Closing as now fixed after several restarts and running the latest commit of the dev branch v0.12.11.


Extend nunit switches - Closes #330

@jrnail23 Could you rebase this against develop to a single commit so I can merge this? Would appreciate it! Thanks!

@patriksvensson, I just got back from vacation, sorry to take so long to respond.  I'll work on this today.

@patriksvensson, I think this is ready to merge now.

@jrnail23 this is now merged, thanks for you contribution :+1:


fix!: align roles for service registry

Motivation
UI using some different values so we see this as confusing/mixed UX that should be aligned.
New roles are introduced in breaking fashion as we can easily provide feedback to users about the change
Verification
rhoas service-registry role add --role Viewer --username wtrocki_kafka_devexp
rhoas service-registry role list

@bredamc Link to content team review:
https://github.com/redhat-developer/app-services-cli/pull/1413/files?file-filters[]=.toml&show-viewed-files=true

Fun fact: More than 70% of the code in this PR were entirely generated by AI bot:


Angle with bert-multilingual-base

I wanna ask whether it is possible and How to combine Angle and bert-multilingual-base to obtain a model similar to angle-bert-multilingual-base-uncased-nli-en-v1?

hi, it needs to prepare multiligual data to train AnglE with bert-multilingual-base.


Provide utilities to gracefully shut down the GTK event loop

Heyho!
The work on ThreadButler (renamed from Appster) is progressing quite nicely and the docs are shaping up to.
I'm currently wanting to provide a global "shutdown" mechanism for all threads.
For the owlkettle integration I would like some utility to kill that event-loop as well in a graceful manner, in my case from within a timeout proc.
This is mostly a nicety and not a hard requirement, just would be nice.
I've found g_main_loop_quit which we appear to not have wrapped.
The problem I'm seeing here is that g_main_loop_quit requires access to the loop that needs to quit.
Which is... kinda difficult when I am not entirely sure we have that.
At least a glimpse into mainloop.nim does not inspire recognition of what in there I'd be calling g_main_loop-quit with.
Any idea what the way to go here would be?

Sorry for the delay, I am currently recovering from COVID. According to https://discourse.gnome.org/t/best-practice-to-quit-a-gtkapplication/3660, you just need to close all windows. Something like this might work:
import owlkettle

viewable App:
  discard

method view(app: AppState): Widget =
  result = gui:
    Window:
      Box:
        margin = 12
        Button:
          text = "Quit"

          proc clicked() =
            proc closeTask(): bool =
              app.closeWindow()

            discard addGlobalIdleTask(closeTask)

brew(gui(App()))

I call close window inside an idleTask here to prevent a potential use after free, since clicked will trigger a redraw after it is called.


Configure LND Node to work with ZAP for IOS wallet.

Like connecting the ZAP Desktop, also the ZAP for IOS app can work with your LND node.

Sorry AmazingDroopy i remake your guide, if you can check it. Pull #414

Thanks for this pull request @AmazingDroopy. As it provides just the pure step-by-step instructions, not considering the navigation or general style of the guide I was happy that @giulnz took that up and your contribution lives on, now neatly formatted.


The Enter key doesn't work when I try to create whether file or folder

I use the latest version of Atom Code Editor. Today I found out that while creating whether file or folder the Enter key doesn't fire. When I typed the file name and tried to press Enter nothing happened. But if I write text in any file the Enter key works perfectly. What is the problem?

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Double click to Open (Install) APK file to Leapdroid

Is there any way to Associate apk file with Leapdroid

Will support that soon.

Another thing,
Please a change screenshot location Desktop to **C:\Users\Documents**@leapdroid


French S-band radar profiles are processed incorrectly.

This is because the French radar data at Baltrad (so far) does not provide the radar wavelength as an attribute. See also adokter/vol2bird#106.
Radars affected: fropo, frale, frbol, frcol, frnim

Does anything need to be done at the repository level?


Editor: IME input problem

Issue Summary

As the screen recording above shown, I want to input 你好 using Chinese Pinyin Input method of Mac OS X on the start of line，I type nihao，then got i好n.
The first typed n is inserted after cursor.
To Reproduce

Switch Input method to non-latin languages, e.g. Chinese Pinyin Input method, Japanese
Type some letter like nihao, expect to get 你好, but get i好n

It is the bug of Mobiledoc-Kit, can reproduce on https://bustle.github.io/mobiledoc-kit/demo/, too.
Technical details:

OS: Mac OS X, v10.13.6
Node Version: v8.11.1
Ghost-CLI Version: 1.9.0
Browser/OS:  Chrome/67.0.3396.99
Database: sqlite3

Hey @minwe 👋 Thanks for the report. Unfortunately this is a known issue, it's being tracked in the upstream mobiledoc-kit repo in https://github.com/bustle/mobiledoc-kit/issues/548 and I believe the underlying problem is similar to this issue https://github.com/bustle/mobiledoc-kit/issues/589.

Yes, this is same as https://github.com/bustle/mobiledoc-kit/issues/548.
It maybe caused by composition event (more about omposition event:  http://blog.evanyou.me/2014/01/03/composition-event/)
I'll check mobiledoc-kit source code later.

It would be great if you were able to look. None of the core team use IME input so it's difficult to find and debug these issues.
https://github.com/bustle/mobiledoc-kit/issues/589 is a good read as I believe it's likely the root cause and has more info in it. Unless you are seeing the same buggy behaviour when not typing the first word in a blank paragraph?

@kevinansfield It always happens when typing the first word of paragraph, headline, list and other block element.
I'm looking at the issues you mentioned above, but have no idea so far.

Korean has the same problem.

It seems using IME in markdown section or title section works fine.  Hoping there is a option to disable Koeing Editor before it can work along with IME.

So when can it solved?

@buchijiang whenever the upstream issue (https://github.com/bustle/mobiledoc-kit/issues/548) is solved - there's no explicit timeline publicly available

@vikaspotluri123 OK,i know and thanks for answer

There should be an alternative editor to this issue.

When to fix it in master?

Is it technology that can not be fixed?

This is an issue in the upstream mobiledoc-kit library and the underlying problem is being tracked in multiple places on that repo, with the two most prominent issues being:

https://github.com/bustle/mobiledoc-kit/issues/589
https://github.com/bustle/mobiledoc-kit/issues/548

As such I'm going to close the issue here, any further discussion/PRs should be directed to the mobiledoc-kit project.

This is an issue in the upstream mobiledoc-kit library and the underlying problem is being tracked in multiple places on that repo, with the two most prominent issues being:

bustle/mobiledoc-kit#589
bustle/mobiledoc-kit#548

As such I'm going to close the issue here, any further discussion/PRs should be directed to the mobiledoc-kit project.

As a blog platform, issues relating to editor is a core issue. This is not something like a development or dependency issue. This issues occurs at every paragraph when user write. Can you image how annoying it is everytime when you start a new paragraph, your first character jumps off.
It has been here for 2 years, and you don't resolve it, given the condition that one user has provided a solution after long time suffering.
If you check out that user's blog, he has decided to leave ghost because of the attitude of the official team.
This issue has caused so much trouble to all Asian language speakers.
Very disappointed to the official team.

This is an issue in the upstream mobiledoc-kit library and the underlying problem is being tracked in multiple places on that repo, with the two most prominent issues being:

bustle/mobiledoc-kit#589
bustle/mobiledoc-kit#548

As such I'm going to close the issue here, any further discussion/PRs should be directed to the mobiledoc-kit project.

As a blog platform, issues relating to the editor is a core issue. This is not something like a development or dependency issue. This issue occurs in every paragraph when user writes.
Can you imagine how annoying every time when you start a new paragraph, your first character jumps off?
It has been here for 2 years, and you don't resolve it, given the condition that one user has provided a solution after a long time suffering.
If you check out that user's blog, he has decided to leave ghost because of the attitude of the official team.
This issue has caused so much trouble for all Asian language speakers.
Very disappointed with the official team.

In fact, what they want to say is that Asian users are not important, otherwise they would have solved the problem. After all, the users of this blogging platform are mainly Europeans and Americans. But I'm surprised that this bug has been resolved by some people, why don't they merge to master

For anyone who wants to push this bug to be fixed, Please show your support underhttps://github.com/TryGhost/Ghost/issues/11460


doesn't work with brand accounts

hey,
just wanted to inform you this doesn't work on brand yt accounts. url is a bit different there
https://myactivity.google.com/u/1/page?hl=en&utm_medium=web&utm_source=youtube&pli=1&page=youtube_comments
any chance you could update your script to work for yt brand accounts too??
many thanks

As I have no means to test this myself, could you edit the script yourself and verify that it actually works for brand accounts?
Change the URL here to match yours:
https://github.com/fonic/Youtube-Comment-Cleaner/blob/0603758b9fb5f9546d02e915a36c360ebedb7c4a/Youtube Comment Cleaner (YCC).user.js#L51-L54


#64 Category Routes

Hey, @Kanika637  I have added three category routes, from which users can explore the items of a particular category.
Issue: #64
Preview
https://user-images.githubusercontent.com/91705825/193993951-c1b76be4-c696-4a70-a1ce-8c159ab49af0.mp4

Great Work @Shivam-Katare !🚀 There are some minor typos which need to be fixed.

Okay @Kanika637 and @Jai-Solania-29  I will fix all the typos.

Any updates @Shivam-Katare ?

Any updates @Shivam-Katare ?

Yes! Just committing all the changes. I will push the changes within 10 minutes.


⬆ Upgrade pip in CI, try and see if that handles the conflicts

It seems that doesn't do it. Probably needs upgrading Flit, but I can only do that when dropping support for 3.6, so I'll have to do that first.


Deprecated POSIX time function used in the utilities

The function GetMilliCount() in utilities.cxx makes use of the ftime() system (POISX) function which is now deprecated. https://man7.org/linux/man-pages/man3/ftime.3.html
GCC 9.x.y reports this as a warning. The function may in principle be absent on some systems.

Fixed on the master, thanks!


[BEAM-8226] Alter getInputElementsConsumed computation for monitoring…

…Infos in RegisterAndProcessBundleOperation.java (#9571)
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @markflyhigh

Java precommit failures may related to Dataflow service. The change is tested in https://github.com/apache/beam/pull/9571 will all tests passed. I'll go ahead and cherry-pick to release branch.


QEMU emulation of stanc3 on architectures without provided binaries

Description:
My suggestion is that QEMU is used for unsupported architectures (probably mainly ARM64) to run stanc3. On my Android phone I replaced the stanc3 binary with a script calling the linux-stanc3 binary through QEMU, which worked very well. An alternative would be to provide ARM64 binaries of stanc3, although I have literally no idea whether they would work on both say Android and Mac OS X.
Current Version:
v2.25.0

Thanks.

whether they would work on both say Android and Mac OS X

They would not but for MacOS we are fine as long as the user has Rosetta 2 installed, which most if not all M1 macOS users will have anyways.
We probably could make Linux ARM binaries but emulation seems like an easier solution to me. Especially given that compiling form Stan to C++ is not nearly the bottleneck and emulating it is fine performance-wise.
The idea I have right now would be to have a makefile flag like STANC3_EMU that users of ARM CPUs would set. For example you would set
STANC3_EMU=qemu-x86_64
and that would mean that instead of bin/stanc we run qemu-x86_64 bin/stanc.

We now offer a linux ARM tarball for cmdstan releases (they include a stanc3 binary built for Linux ARM) so we can close this: https://github.com/stan-dev/cmdstan/releases/tag/v2.26.1


Add GitHub Actions workflows from Plugins CI shared workflows

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@xnyo I think we can go for merge, or something is missing?


TINKERPOP3-982: valuesDecr, valuesIncr, keysDecr, and valuesDecr is lame.

https://issues.apache.org/jira/browse/TINKERPOP3-982
I made it so the Column enum implements Function<Object,Object> and where Column.keys and Column.values project out the respective "column" for Map, Map.Entry, Path, etc. What is cool about this is that now we no longer need SelectColumnStep -- select(keys) == map(keys). Of course, like where(traversal) == filter(traversal), I left select(column) in GraphTraversal and don't plan to remove it.
Given that this is a minor version push (3.1.1), I will NOT deprecate Order.valueDecr/etc. until 3.2.0 and have the following ticket to remind me.  https://issues.apache.org/jira/browse/TINKERPOP-1021
Finally, mvn clean install and a full publish-docs.sh are happy happy long time.
VOTE +1.

Looks good, tests pass.
VOTE +1

Nice one.
VOTE: +1

This was merged.


fix(checks): typo causing panic in checks endpoint

Closes #16988
This fixes a typo that caused a panic.

@AlirieGray is working on pipeline tests to handle this case.


[BUG] CI isn't used/reliable/circular dependency?

What is the bug?
Something as trivial as an upgrade of a dependency or a version can't seem to be able to rely on CI. Log4j upgrade changes were merged with failures. An attempt in upgrading to 1.17 in a similar manner as a previous commit is failing CI (https://github.com/opensearch-project/performance-analyzer-rca/pull/106).

What is the expected behavior?
CI should be all green for any change
Do you have any additional context?
Is this a circular dependency problem with PA?

The recent commits 940e461 and 9fcf19fmerged into 1.2 branch (log4j and version upgrades) have failing CI due to failing integration tests (spins up a docker using docker artifacts and runs the test suite). The docker artifact was not available when this change was committed (as infra team was still working on generating the artifact). The next commit bf7f59ee updates the docker artifact link and thus have a passing CI.
On commits merged into main the CI has failures due to following reasons,

Failing Link checker (which is fixed now as part of this PR)
OS Snapshot not available for 1.2.2 and 1.2.3. We should update main to 1.3 instead of using minor versions.

Currently, PA and PA-RCA have circular dependencies causing issues like failing CI's like 6cebefab9 and making release process tedious. PA-RCA is a standalone application/library that PA depends on.
PA-RCA CI's checks out PA and run its unit tests which can be removed. Additionally the integration tests which run as a part of PA-RCA CI need to be moved to PA CI's. Tracking fixing circular dependencies using the same issue.