python311Packages.types-awscrt: init at 0.19.0, python311Packages.botocore-stubs: init at 1.31.34

Description of changes
Needed to fix aws-sam-cli.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251387 run on x86_64-linux 1

8 packages built:

python310Packages.botocore-stubs
python310Packages.botocore-stubs.dist
python310Packages.types-awscrt
python310Packages.types-awscrt.dist
python311Packages.botocore-stubs
python311Packages.botocore-stubs.dist
python311Packages.types-awscrt
python311Packages.types-awscrt.dist


OAuth Token Authentication Issues

Hi,
When entering in an oauth token, should the "oauth:" portion be included or excluded in the string? I've tried both ways with the same results.
I'm having trouble authenticating and using the library currently.
Here's my test code:
string username = my_channel;
string oauth = "xxxxxxxxxxxxx";
string channel = my_channel;
TwitchClient client = new TwitchClient(new ConnectionCredentials(username, oauth), channel);
client.SendMessage(my_channel, "Test");
Console.WriteLine(client.TwitchUsername);
Console.WriteLine(client.IsConnected);
 Console.WriteLine(client.JoinedChannels[0].Channel);

Which returns the correct username, false, and an OutOfRangeException.
Is there something I'm missing? Do I need to manually start the connection to the IRC sever?
Thanks!

Hi there, I'm going to format your post, and then respond to you shortly.

Regarding your first quesiton on oauth suffix, yes you need it if you are using the NuGet package. However, if you are using the latest GitHub code, I just added a check that makes it so you don't need to have it (it's optional).
Regarding your second part, you need to call Connect() on the client after initializing it, as such:
TwitchClient client = new TwitchClient(new ConnectionCredentials(username, oauth), channel);
client.Connect();

(This was not originally part of the example implementation in the README, I have since added it)
Additionally, to detect when the client has connected and joined the channel, you want to listen to the OnJoinedChannel. To do this, you'll need a method that is fired when the event happens, and subscribe to the client's OnJoinedChannel. Example:
Method to fire on event:
public static void clientJoinedChannel(object sender, TwitchLib.TwitchClient.OnClientLeftChannelArgs e)
{
        client.SendMessage(my_channel, "Test");
        Console.WriteLine(client.TwitchUsername);
        Console.WriteLine(client.IsConnected);
        Console.WriteLine(client.JoinedChannels[0].Channel);
}

and subscribe to event:
client.OnJoinedChannel += clientJoinedChannel;

I would highly recommend you check out the Example application provided in this project. It has examples on how to do almost everything.

@swiftyspiffy Alright, thanks so much for your reply!
Sorry, I'm really new to C# and the whole event/delegate model, and I didn't see the Connect command in the sample project.
Another question that's honestly pretty stupid: how do I prevent the application from exiting before the event fires? Running into that issue with this implementation and the other project I'm working on.
Thanks again so much for your work on this project!

Assuming you're referring to a ConsoleApplication, you'll want to read input. If you want to read input repeatedly, you want to do a loop for it. Something like:
while(true) {
        Console.ReadLine();
}

This will continually read input from the keyboard without exiting.

Alright, sorry for troubling you with that. I've now compiled the example project in this repo, and after inputting my credentials in the form, I'm unfortunately still unable to receive or send any messages at all. Is there anything I might be missing or doing wrong? I'm using the latest commit from github, if that matters, and I've also verified that the credentials work through WebIRC clients.
Thanks again for your patience and replies.

Just to confirm, you are putting your username into the User textbox, and your oauth into the OAuth textbox, then in the CHannel textbox you're putting a channel, and then clicking Add, correct? And are you getting an exception I assume?

And no worries, glad to help 👍

Yeah, I'm putting in the correct username/token, clicking add, and then attempting to send/receive messages through the appropriate tabs. Would it help at all if I PM'd you my oauth token and username? It's a throwaway account anyways that I made yesterday, so nothing important is linked to it.

ya, if you want to. It would at least allow me to test it. When you click add, you should see some messages in the output box in Visual Studio indicating connection is attempting to be made to Twitch.

Alright, emailed you the credentials!

Just responded with a video of my logging in and sending/receiving chat and whispers.

Alright, looks like something was just janky with the network my school. Thanks for your help!

Awesome, that's what I thought it was. Glad you got it working!


Create set_build_number_repository.rb

This new action allows the build number to be set from the repository (currently supports svn, git-svn and git)
I'm not a ruby programmer, so please feel free to pull this apart and reimplement (I won't be offended :)), we just needed this functionality quickly.

@pbrooks thanks for submitting the pull request. Could you please move the new action into the actions folder?
If you need this now, just copy your action into your local fastlane/actions folder and you can already use it :+1:
The next fastlane will be in a few days probably, so better use it as a local action for now.

Should be sorted now :)

Thanks, looks great :+1: Only thing missing (sorry I forgot to mention this before), could you add your new action to Actions.md in the Using git section?
Thanks again for your work :+1:

Done :)

Thank you @pbrooks, this will be in the next release. As mentioned above if you need this action right now, please use it locally for now, as I won't release a new version today.


Razor Pages _ViewImports documentation could be more clear

From @tstivers1990 on June 18, 2018 12:48
https://docs.microsoft.com/en-us/aspnet/core/mvc/razor-pages/?view=aspnetcore-2.1&tabs=visual-studio#using-layouts-partials-templates-and-tag-helpers-with-razor-pages
The part of this documentation that details the @namespace declaration could be made more clear. It has led some people to believe @namespace should be used as though it is a using statement. See the linked StackOverflow answer below for an example of this. I believe part of the reason it isn't clear, is because it doesn't explain @using directives in the context of a _ViewImports file.
In short, the wording could be made more clear, and a section should be added detailing @using directives in the context of a _ViewImports file.
https://stackoverflow.com/a/50322359
Copied from original issue: aspnet/Identity#1839

This doesn't appear to be an identity issue, so moving.

Thanks. I derped and put it in the wrong place.

Thanks for bringing this up, @tstivers1990.
We'll try to clarify this.

After reading through the article I think it is pretty concise in regards to what @namespace accomplishes. It's specific in what pieces it describes and only explains pieces that are essential to what's being asked of the user (they're adding an @namespace). Therefore, I don't think it's the right place to add information about the using. That's accomplished elsewhere.
All that being said i did find the last sentence in that paragraph a bit confusing, I'll remove it.

1521b50a66fc1056bf186f2b9d81a4ba07783d5d