WIP: Messaging infra

Add the MessagingInfra CRD
Add the messaginginfra-controller reconciler. This reconciler creates the routers and brokers belonging to an instance of MessagingInfra as well as managing a per-infra CA and per-component certificates signed by that CA. The reconciling loop also takes care of certificate renewal.
Add support to broker-plugin for deploying the broker in 'shared infra' mode.
Add a new template component for deploying the enmasse-operator in shared infra mode to avoid impacting existing functionality.
Add support for generating java types from Go types, only applied to the new MessagingInfra type in the first instance.
Add initial systemtest for shared infra that validates routers and brokers being deployed.

TODO: unit tests of certificate renewal, router and broker reconciliation.

@enmasse-ci run tests profile=isolated-shared-infra

:x: Test Summary :x:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 0
FAIL: 1
SKIP: 0
BUILD_NUMBER: 181
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testInfraCreated in io.enmasse.systemtest.sharedinfra.MessagingInfraTest

@enmasse-ci run tests profile=isolated-shared-infra

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 194

@enmasse-ci run tests profile=isolated-shared-infra

:x: Test Summary :x:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 0
FAIL: 1
SKIP: 0
BUILD_NUMBER: 197
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testInfraCreated in io.enmasse.systemtest.sharedinfra.MessagingInfraTest

@enmasse-ci run tests profile=isolated-shared-infra

:x: Test Summary :x:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 0
FAIL: 1
SKIP: 0
BUILD_NUMBER: 198
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testInfraCreated in io.enmasse.systemtest.sharedinfra.MessagingInfraTest

@enmasse-ci run tests profile=isolated-shared-infra

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 201

@enmasse-ci run tests profile=isolated-shared-infra

@enmasse-ci run tests profile=isolated-shared-infra

:x: Test Summary :x:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 0
FAIL: 1
SKIP: 0
BUILD_NUMBER: 222
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testInfraStaticScalingStrategy in io.enmasse.systemtest.sharedinfra.MessagingInfraTest

@enmasse-ci run tests profile=isolated-shared-infra

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

@enmasse-ci run tests profile=isolated-shared-infra

@enmasse-ci run tests profile=isolated-shared-infra

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 227

@enmasse-ci run tests profile=smoke

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0
BUILD_NUMBER: 228

@enmasse-ci run tests profile=isolated

@lulf looks good

@enmasse-ci run tests profile=isolated

:x: Test Summary :x:
TEST_PROFILE: isolated
TEST_CASE:
TOTAL: 142
PASS: 132
FAIL: 6
SKIP: 4
BUILD_NUMBER: 346
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testConnectorMutualTLS in io.enmasse.systemtest.isolated.bridging.ConnectorsTest
testSendThroughConnector1 in io.enmasse.systemtest.isolated.bridging.ConnectorsTest
testCreateBindingCreateAddressSendReceive in io.enmasse.systemtest.isolated.catalog.ServiceCatalogWebTest
testSendMessageUsingBindingCert in io.enmasse.systemtest.isolated.catalog.ServiceCatalogWebTest
testSendReceiveInsideCluster in io.enmasse.systemtest.isolated.catalog.ServiceCatalogWebTest
testConsoleErrorOnDeleteAddressSpace in io.enmasse.systemtest.isolated.catalog.ServiceCatalogWebTest


Delink individual app access from Authorized Apps page

As an end-user who has linked an app with my wallet account and is on the Authorized Apps page, I want to de-authorize that app so I can rest easy that they no longer have access to my data.
Acceptance Criteria

[ ] Select a single Authorized App on the Authorized Apps page to open details
[ ] Mobile works and matches mobile view
[ ] Includes same placeholder "Authorized To" text as the authorization flow shows the user initially when authorizing that application
[ ] Does NOT include "Recent Transactions" tab
[ ] Includes placeholder images for apps (we haven't wired this up yet)
[ ] Does NOT include the website for the app (haven't wired this up yet)

Assets
NOTE: waiting for updated lite mockup from Jake as of 5/25/19 to show how the frontend should look.

Full mockup (shows more features than currently building) https://projects.invisionapp.com/share/Y5QIVUGTVER#/screens/356310180
Expanded view (shows more features than currently building): https://projects.invisionapp.com/share/Y5QIVUGTVER#/screens/356310179
Pixel perfect Zeplin files at https://app.zeplin.io/project/5c801b27f9e6e211c76f94f2/screen/5cb0a9fda8666961127d6169

NOTES

Spin out story: Log out of app when it's de-linked


Tasks for fully qualified name

Spec:

[x] 1. Publish helper API to generate compliant class and method names that adhere to the standard specified in  0017-Managed-TestCase-Properties.md (Related PRs: #2611, #2714)

[ ] 2. Publish helper API to standardize TestCase.Id generation (Related PRs:)

Adapters should be able to call this API and get back a deterministic and unique Id Guid given the same set of inputs (strings).

Inputs would include the same method and class names returned by the API in #2 above. For parameterized tests, the inputs would also include argument values (which could be any value that can appear in a .NET attribute).

[ ] 3. Publish helper API to standardize test hierarchy display information (Related PRs: #2724)

This can be accomplished by adding an out parameter on the API in 1 above that returns an array with default display name values for each level in the hierarchy (namespace, class, test group and test).

When creating Testcase objects, Test Adapter authors can choose to supply different values than what is returned in the out parameter) for any level, based on their own display name rules. However, having the out parameter on the above API would make the hierarchy functionality easier to discover (we could hang documentation comment on it) and would also avoid code duplication / parsing for computing the levels of the hierarchy that typically have fixed names that the end user can’t change (such as for namespace and class).

[ ] 4. Update guidance for test adapter authors (Related PRs:)

Update 0017-Managed-TestCase-Properties.md to include recent updates (including changes around how test hierarchy will be encoded, how names with special Unicode characters will be handled etc.).

Understand whether it is possible to encounter names with special Unicode characters in the Roslyn symbol API. Our current assumption is that this should not be possible for source symbols (since such names are not legal in C#) however they may be encountered in metadata symbols from referenced F# assemblies. (Preliminary investigation did reveal that C# cannot interop with methods and classes containing special Unicode characters in their name.)

FYI @peterwald @Haplois @pavelhorak

Added https://github.com/microsoft/vstest-docs/pull/247 to update 0017-Managed-TestCase-Properties.md.


[Feature request] Support attention logits cap with tanh

The grok model uses tanh to cap the attention logits. This can make training more stable. Could you support this feature in flashinfer? If you need community help, any instructions on how to add this will be appreciated.
Grok (jax):
https://github.com/xai-org/grok-1/blob/7050ed204b8206bb8645c7b7bbef7252f79561b0/model.py#L864-L865
SGLang implementation (triton):
https://github.com/sgl-project/sglang/blob/2cea6146d8735780da602c0dfa0569b0fb5d47ba/python/sglang/srt/layers/extend_attention.py#L101-L102

Sounds good, should be easy to support.

Is there is formal name with this "Attention with Logits Cap" method?

@yzh119 Any progress on this issue?
FYI, TensorRT-LLM recently added this feature https://github.com/NVIDIA/TensorRT-LLM/blob/db4edea1e1359bcfcac7bbb87c1b639b5611c721/tensorrt_llm/functional.py#L4519-L4521

Done in #298


best configuration to avioid softban ?

i always getting softbanned and search not working for some minutes... what are the best configurations ?

I have not been using the tool , since i dont own the game. Anyone if you have the best configuration , please share here..

I usually use 3-4 wait time 1 concurrent search and after 10/20 minutes i usually stop it for 5 minutes to let everything sell. Then refresh the page and go on.

For me, it depends, during the day I use 5-10 sec, because there are not that many new cards on the market and the risk is not worth it, still get a decent amount of cards, and during evening I use 1-4, or 2-5 and I always run the search for 4-5 min, than take a break and run it again. Until now only got 1 captcha screen, no soft bans.

For me, it depends, during the day I use 5-10 sec, because there are not that many new cards on the market and the risk is not worth it, still get a decent amount of cards, and during evening I use 1-4, or 2-5 and I always run the search for 4-5 min, than take a break and run it again. Until now only got 1 captcha screen, no soft bans.

Could u tell me ur discord or something so u can maybe chat about the buyer etc

I usually use 3-4 wait time 1 concurrent search and after 10/20 minutes i usually stop it for 5 minutes to let everything sell.

I use the default 7-15 seconds, 1 concurrent search and 1 buy attempt during the day, with 1 minute wait after 15 search. Never get softbanned

I usually use 3-4 wait time 1 concurrent search and after 10/20 minutes i usually stop it for 5 minutes to let everything sell. Then refresh the page and go on.

Hello! What's a concurrent search? Does the tool allow multiple searches at the same time?


Unable to disconnect

When I use wcClient.disconnect() to disconnect, but Dapp shows that I am still connected.

@lijidada use killSession instead of disconnect

Thanks @AyushBherwani1998


Document third party billing flow

From scratch how a service can bill a user

Add some example code in Typescript (might need to extend the client first)

Verified Docs has been added for the third party billing flow.


Suggestions for improving the specification document

Add more examples that show how the developer uses the APIs such as how to inject an LRAClient.
Reference the Javadoc from the specification
Clearly articulate the use cases for the specification, for example,

identify JAX-RS versus non JAX-RS use cases
add more text on why the developer would use the programmatic as opposed to the CDI/annotation based APIs

Improve the javadoc for the Forget, Status and TimeLimit annotations
The state model for an LRA (section 3.1 of the spec) should have its own diagram and needs more descriptive text about the states and the transitions between them.

#6 requests a test for timelimits on LRAs but that issue also requested a javadoc change. The javadoc change would be better in this issue. Therefor this issue should improve the javadoc for the Forget, Status and TimeLimit annotations

@tomjenkinson I raised a separate issue #33 to cover your comment

PR merged


Autogeneration code failing in < character

see https://travis-ci.org/NREL/PowerSystems.jl/jobs/614313755#L348
The characters <: are being rendered as &lt

This can be fixed by wrapping the data_type in {{{data_type}}} instead {{data_type}} in src/utils/generate_structs.jl.  This must be the first time someone defined a data_type with <:


Can we show the password validator only when text field is on focus ?

Sharing an example where I have both Email and password and for a better user experience, I want to be able to show a password validator only when someone starts to type the password.
Moreover, is there a way to shift the validator to align perfectly under the field ?

For the first one, you can use an Opacity widget and set its value to 0.0 in the initial stage. Then add a listener to the field controller so you can change the opacity value to 1.0 when it has a text value.
And the second problem you can use the provided sizes in widget constructor.


very talented work, still waiting for the code~

waiting for the code!

me too

We just released the code and checkpoints: https://github.com/PrieureDeSion/visualnav-transformer/releases/tag/code_release


[Clone][Bugfix] Handle source VM with unbounded volumes

What this PR does
Bug:
This PR addresses a bug in the clone API.
If a VM with an unbound DV is being snapshotted, the DV is skipped and is not being snapshotted [1][2].
This makes sense for "regular" snapshots (i.e. that are not being created for cloning). Since the DV was not bounded there is nothing to snapshot, and when the VM is being restored all needs to be done is to restore the original spec with the DV volumes and possibly DV templates defined.
However, for cloning this might result with the following bug:

A stopped VM is being created with a DV template with a WFFC binding mode.
A clone is being created.
The clone controller snapshots the VM and the DV/DV template are skipped.
The clone controller restores the VM into a new instance.
The new instance points to the same DV.

The scenario where the target and source VMs point to the same DV is a bug.
The above can occur with a WFFC PVC as well, not necessarily a DV.
Solution:
Now the clone controller handles this situation in the following way:

If the unbounded volume is a DV backed with a DV template: the DV's and DV template's names are changed, which will result in a distinct DV.
If the unbounded volume is a PVC: the PVC's name is changed, which will result in a distinct PVC.
If the unbounded volume is a DV that is not backed with a DV template: ignore the DV and drop it from the target.

[1] https://github.com/kubevirt/kubevirt/blob/cd6d77a5f96fcea1765583fa9bdb0bfe754386ef/pkg/storage/snapshot/snapshot.go#L614-L617
[2] https://github.com/kubevirt/kubevirt/blob/cd6d77a5f96fcea1765583fa9bdb0bfe754386ef/pkg/storage/snapshot/snapshot.go#L551-L554
Before this PR:
In some situations (see above), source and target VMs point to the save volume.
After this PR:
In some situations (see above), source and target VMs point to different volumes.

Fixes https://issues.redhat.com/browse/CNV-38559
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[X] Design: A design document was considered and is present (link) or not required
[X] PR: The PR description is expressive enough and will help future contributors
[X] Code: Write code that humans can understand and Keep it simple
[X] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[X] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[X] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[X] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[] ~Community: Announcement to kubevirt-dev was considered~

Release note

[Clone][Bugfix] Handle source VM with unbounded DataVolumes

/kind bug
/area clone

@mhenriks @ShellyKa13 Can one of you, or someone else from storage, help review this PR? I think it's important to have an LGTM from storage before this PR is merged. Thanks!

@mhenriks @ShellyKa13 Can one of you, or someone else from storage, please help review this PR? I think it's important to have an LGTM/approve from storage before this PR is merged. Thanks!

In addition, please look at the third bullet under Solution in the PR description.
TBH, I'm not sure what's the desired outcome in that case where a VM has an unbound DV without a DV template is cloned. I can think of a few alternatives:

Drop this volume (what's currently implemented)

Con: If the root disk is defined as a DV without a template and it is not bound, the cloned VM will be invalid.

Change its name.

Con: A new DV would need to be created, which is confusing.

Another possible alternative is going for the second bullet above (changing the name), but also to search for a corresponding DV in the cluster and "clone" it as well (that is, create a similar DV with a different name).
Thoughts? @ShellyKa13 @mhenriks

@iholder101 I wonder if it would be better for snapshot controller to wait for all VM PVCs to be bound before taking the snapshot.  Assuming the target PVC storageclass supports snapshots of course.  What do you think?
This may also be relevant:  https://github.com/kubevirt/kubevirt/pull/11964#discussion_r1643488521
cc @ShellyKa13

@iholder101 I wonder if it would be better for snapshot controller to wait for all VM PVCs to be bound before taking the snapshot. Assuming the target PVC storageclass supports snapshots of course. What do you think?
This may also be relevant: #11964 (comment)
cc @ShellyKa13

I guess this means that (in the WFFC case) a VM must be started in order to become snapshottable, and therefore clonable. A user needing to start and stop and VM for it to be cloned seems like a bad UX to me, and I think we should avoid this limitation if it's possible to do so technically.
From a technical POV, we have 3 different cases as described in the PR description:

If the unbounded volume is a DV backed with a DV template: the DV's and DV template's names are changed, which will result in a distinct DV.
If the unbounded volume is a PVC: the PVC's name is changed, which will result in a distinct PVC.
If the unbounded volume is a DV that is not backed with a DV template: ignore the DV and drop it from the target.

IMO the first two cases are pretty easily solvable. Do you agree with the proposed solutions there?
The third case is a bit trickier, because it relies on an external DV (which doesn't necessarily even exist when the VM is being cloned). We can declare this case as a limitation for clone and either ignore the DV or do something else. But since the other two cases (which I think are anyways more common to use) are solvable, I think we shouldn't disallow cloning VMs with unbounded volumes altogether.
WDYT?

I probably missed something but how this issue:

If the unbounded volume is a PVC: the PVC's name is changed, which will result in a distinct PVC.

actually works, how will you end up with 2 distinct PVCs? who will create the cloned VM pvc?
Regarding the standalone dv issue, I think skipping it is wrong since the resulted vm will not include a volume which was in the original vm.. so its not actually a clone.. I think similarily if you want to clone a pvc or snapshot a pvc you need it to be bound or else the clone/snapshot will never be ready, then same for vm with all its volumes they need to be bound for it to be cloned..

I guess this means that (in the WFFC case) a VM must be started in order to become snapshottable, and therefore clonable. A user needing to start and stop and VM for it to be cloned seems like a bad UX to me, and I think we should avoid this limitation if it's possible to do so technically.

It's not great, but let's dig into the details and see why it may be necessary.  Given your three bullet points:

DataVolumeTemplates:  sure no problem, the scheme in this PR is fine
Standalone PVC:  I don't think the solution in this PR is particularly helpful.  Who is responsible for creating the new PVC and making sure it is initialized correctly?  I think users will be surprised when the clone op succeeds and the cloned VM never starts because the PVC does not exist.  This is the hardest case to solve programmatically (assuming the PVC actually exists).  Snapshot code would have traverse PVC dataSourceRef and squirrel away populator sources.
Standalone DV:  I don't think it is particularly helpful to drop the volume either, as is proposed in this PR.  User could be expecting critical data.  What if it's the root disk?  However, if PVC/DV exist, Snapshot code could store the DataVolume definition and create a modified version at restore time

Alternatively you can start the VM and wait for all sources to bind.  I think that's a lot cleaner

Thank you @ShellyKa13 and @michaelhenkel for this discussion!
I think that:

On the DV template case: keep this PR's approach.
Standalone DV/PVC: clone should fail/wait it to be bound.

I think that the clone API should follow whatever will be decided with Snapshots, which is currently being discussed in https://github.com/kubevirt/kubevirt/pull/11964#discussion_r1643488521

/remove-lifecycle stale
This is still blocked because of https://github.com/kubevirt/kubevirt/pull/11964.


Cleanup in netcdf output

This PR tries to cleanup our netcdf io by:

removing the infamous vars hack
replacing some code duplication by loops

@charleskawczynski - could you take a quick look? Is it along the lines you were suggesting? Also I'm confused about end vs end+1 when doing the output (for example line 86 vs 99)
@edejong-caltech - could you take a look and see if it's compatible with what you were thinking?

Thank you @charleskawczynski! Without the vars hack and the temporary stuff the output file is much cleaner and more readable.
Does it mean that without the hack I can just have end +1 in all the output writing? I'm double checking because in TC.jl we  have end when we write the fields, but end+1 when we write the timeseries. And I'm little confused why it shouldn't always be end +1
https://github.com/CliMA/Kinematic1D.jl/blob/7c644533fdca1fbc14baccebdf49a72edc52452b/src/NetCDFIO.jl#L86-L98

Hi @ajaruga, here are few TODO's before we close this out:

[ ] It should be ts+t[end +1], but ncdfvar[end]. See comment above.
[ ] KiD_output should only search for the variables specified in the constructor's output_profiles, not all moisture vars
[ ] We should implement the timeseries output for at least some dummy variable as a check, or just remove it for now. How about surface moisture flux? Or T or P at a particular altitude? This also raises the question of postprocessing, and whether that should be automated to run within KiD, or left to the user.

Thank you @charleskawczynski! Without the vars hack and the temporary stuff the output file is much cleaner and more readable.
Does it mean that without the hack I can just have end +1 in all the output writing? I'm double checking because in TC.jl we have end when we write the fields, but end+1 when we write the timeseries. And I'm little confused why it shouldn't always be end +1
https://github.com/CliMA/Kinematic1D.jl/blob/7c644533fdca1fbc14baccebdf49a72edc52452b/src/NetCDFIO.jl#L86-L98

Thank you @charleskawczynski! Without the vars hack and the temporary stuff the output file is much cleaner and more readable.
Does it mean that without the hack I can just have end +1 in all the output writing? I'm double checking because in TC.jl we have end when we write the fields, but end+1 when we write the timeseries. And I'm little confused why it shouldn't always be end +1
https://github.com/CliMA/Kinematic1D.jl/blob/7c644533fdca1fbc14baccebdf49a72edc52452b/src/NetCDFIO.jl#L86-L98

Based on my testing, it should be end + 1 when writing the time (or writing the next time step for any variable in a given group), and then simply end for other variables. My guess is that once you write to end + 1 once within a group, it automatically extends all other variables in the group to remain consistent. If we write end + 1 everywhere as you have, you'll see that the size of the netcdf file is far too large in the time dimension, with many missing entries.


[rnpm] Pass params to postlink

This is a dupe of https://github.com/rnpm/rnpm-plugin-link/issues/96, I'm not sure if I should continue to file issues in the RNPM repo or here now that RNPM has been merged in.
rnpm link/react-native link is great, however there are some patches specific to our plugin that developers need to make when instrumenting their app with our plugin. We intend to automate these extra steps for them in a postlink script.
Some of these patches require information that the user needs to provide to us (in our case, a deployment key). We tried to do something like this to prompt the user for the key:
{
  "rnpm": {
    "params": [
      {
        "message": "What is your CodePush deployment key for iOS (hit <ENTER> to ignore)",
        "name": "iosDeploymentKey",
        "type": "input"
      }
    ],
    "commands": {
      "postlink": "rnpm codepushify-ios ${iosDeploymentKey}"
    }
  }
}

However, the ${iosDeploymentKey} syntax doesn't actually get replaced with the key when our script is called. The alternative is for us to poll for that additional param ourselves, but it would be great if we can add support for parameterized strings in the postlink declaration.
@Kureev @grabbou

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/rnpm-pass-params-to-postlink
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Is this library suitable for LP maximization problem?

Hi
 Is this library suitable for LP maximization problem?
 Do you mind provide more detailed example with physical meanings?

Thanks

making the objective function of a minimisation problem negative means you will inversely be maximising it.


Fix: Don't wrap set operations in brackets in SQLite

From https://github.com/kayak/pypika/issues/537, SQLite doesn't support set operations with brackets. Luckily there already exists this flag to disable adding brackets to set operations - enable for SQLLiteQueryBuilder.

Could you also add a test for this feature?


Development sidebar with pdf modal

Motivation and Context

Description

Contribution Checklist

[ ] I have built and tested the code locally and in a deployed app
[ ] For frontend changes, I have pulled the latest code from main, built the frontend, and committed all static files.
[ ] This is a change for all users of this app. No code or asset is specific to my use case or my organization.
[ ] I didn't break any existing functionality :smile:

The overall color palettes where updated to a more pastel environment as of other modifications like size, shape, location, spelling grammar and language to Spanish . The PDF Modal was updated to be able to resized as needed. In the answer response we incorporated a copy to paste button so that users can easily copy the response and paste elsewhere as needed. In the citations panel a Button was included to access the document chosen in references and also a Page Button where enables users to navigate directly to the page number where the citation is located. The structure for FAQ was added.


process: removes TARGET_OS_IPHONE for process.c ios build break

Removing TARGET_OS_IPHONE macro to include posix spawn headers for iOS build. Previously #3257 introduced posix spawn with __APPLE__ platform only, which resulted in a number of spawn related definitions not found for ios (e.g. uv__posix_spawn_fncs_tag).

cc @drfloob  @HannahShiSFB

@vtjnash can/will this be landed in a patch release any time soon?

yes, we just were waiting for it to pass on CI


attr doesn't replace type

I have {{ field|add_class:"mdl-textfield__input"|attr:"type:date"}} and I expected <input type="date" name="start_date" value="2016-07-08" class="mdl-textfield__input" required id="id_start_date"> but in fact it produced <input type="text" name="start_date" value="2016-07-08" type="date" class="mdl-textfield__input" required id="id_start_date"> (notice the two types, with Google Chrome ignoring the second type)

Just a wild guess based on the code at https://github.com/jazzband/django-widget-tweaks/blob/8580200e861193f9aa174d0613b84c4a9178778b/widget_tweaks/templatetags/widget_tweaks.py#L167
Can you try type=date with = rather than :?

check #77

This should be fixed by #77.


Ask all downstream data users to remove all mentions of public-apis

Each project (both in source form and their websites) should only link to and only reference this repository, not that of public-apis.
The lineage, acknowledgement and the situation could be mentioned in the readme here in a few words.
Wait for #20 and #24 with this.

Hey, I  am Bhavesh Sonje. How can I contribute to this open source project for my open source class? Please assign me a task.
Contact Me<EMAIL_ADDRESS>GitHub: bhaveshsonje

Hi, I’d love to contribute. Let me know how I can help with open issues?

Hi @faradeen-ja, thank you for offering it!
For the time I'd appreciate the help in moving all the open PRs from public-apis/public-apis to this project here.
I've started from oldest to latest, and I've left a comment on those PRs to know if they're done/invalid.


Activation error for ZABAPGIT three-digit number XXX required in the Message

Hi Team,
I am getting an error while activating the program. Is there any way any one can please help me ?
Thanks in advance.

Quick fix: Comment the line

@Seemanaths what SAP_BASIS version are you running?

fixed in https://github.com/larshp/abapGit/pull/2743, closing

@larshp we are in 702 .

Thanks #2743 fixed my issue.


feat: Configure the OC stack during deployment

Closes #1678
Changelog

Configure the preview instance to listen to the port 8000
Configure the ALB to forward traffic to the port 8000 of the preview instance
Document in the openchallenges-infra README how to configure and start the stack

Issue
Elasticsearch nodes fail to start with this issue:
bootstrap check failure [1] of [1]: the default discovery settings are unsuitable for production use; at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured

Another issue from Elasticsearch?
{"type": "deprecation.elasticsearch", "timestamp": "2023-06-22T18:41:43,287Z", "level": "CRITICAL", "component": "o.e.d.x.s.s.SecurityStatusChangeListener", "cluster.name": "openchallenges-elasticsearch", "node.name": "openchallenges-elasticsearch-node-2", "message": "The default behavior of disabling security on basic licenses is deprecated. In a later version of Elasticsearch, the value of [xpack.security.enabled] will default to \"true\" , regardless of the license level. See https://www.elastic.co/guide/en/elasticsearch/reference/7.17/security-minimal-setup.html to enable security, or explicitly disable security by setting [xpack.security.enabled] to false in elasticsearch.yml", "key": "security_implicitly_disabled", "category": "security", "cluster.uuid": "IPBM0ePwT9qmxMI035CUUw", "node.id": "anneTZJDRJy768H5tLCQ7A"  }


remove logo for unidentified contributors

closes #707

this doesn't seem to be working. see dandiset 4 as an example. still several orcid logos pointing to undefined.

one the topic of identifiers, i suspect that name is being processed the same way independent of whether it's a person or organization:

we should not put a , in the organization names.

we should not put a , in the organization names.

The , appears the names are in the "Last name, First name" format. through the UI "edit metadata" option I don't see a place where you can put the last and first names separately. any idea where that comes from?

ah no worries then. we need to fix this at the metadata level.

@waxlamp - this is ready for review. the main issue is handled.

There is more in this PR than just the orcid badge fix--can you explain why the other changes are included?

to remove the rows if there is no list of contributors or keywords.

There is more in this PR than just the orcid badge fix--can you explain why the other changes are included?

to remove the rows if there is no list of contributors or keywords.

Thanks for explaining. In general, it's good to keep PRs scoped as narrowly as possible, to make reviewing easier to and lessen the risk of a bug being introduced in any given PR.


Error pushing backend updates after modifying @connection field in the schema

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

Amplify CLI Version
6.1.1
What operating system are you using?
Mac
Amplify Categories
auth, storage, function, api, hosting
Amplify Commands
push
Describe the bug
There's a blocking issue when replacing @connection directive with @function directive and pushing updates to the cloud.
Initially, I had the API schema like this:
type ProductGroup
    @model
    @key(
        name: "..."
        fields: ["..."]
        queryField: "..."
    )
    @auth(
        rules: [
            { allow: groups, groups: ["...", "..."] }
            { allow: groups, groupsField: "...", operations: [read] }
        ]
    ) {
    updatedBy: ID
    updatedAt: AWSDateTime
    id: ID
...
    product: Product @connection
...
}

So I needed to update the field "product" not to be connected anymore to the 'Product' model but to call the Lambda function that handles the data and the new schema looked like this:
type ProductGroup
    @model
    @key(
        name: "..."
        fields: ["..."]
        queryField: "..."
    )
    @auth(
        rules: [
            { allow: groups, groups: ["...", "..."] }
            { allow: groups, groupsField: "...", operations: [read] }
        ]
    ) {
    updatedBy: ID
    updatedAt: AWSDateTime
    id: ID
...
    product: SomeProduct @function(name: "SomeResolver-${env}")
...
}

After that amplify push worked fine but when I decided to switch back to the @connection or remove the product field entirely the amplify push will fail throwing an error:
....-20190502193839-....-AZBRWSS9N6CU-FunctionDirectiveStack-60LHSAFFSWX8 AWS::CloudFormation::Stack Wed Oct 06 2021 11:57:14 GMT+0300 Export ....:GetAtt:....ResolversLambdaDataSource:FunctionId cannot be deleted as it is in use by ....-20190502193839-....Client-AZBRWSS9N6CU-ConnectionStack-IMWH6COIO4PX
So basically it looks like this Lambda function is being referred to in ConnectionStack (probably because I used the same field name but removed the @connection directive) and so the FunctionDirectiveStack update task is throwing errors.
The same kind of problem is described also here and here.
Is it possible to somehow manually remove the reference to the Lambda function inside of ConnectionStack so that I could successfully remove the 'product' field and then add it back later on?
Expected behavior
If the @connection directive (not the field itself) is removed from the schema then it should clean up the ConnectionStack properly.
Reproduction steps

Add @connection directive to some schema field and do amplify push
Replace the @connection directive with @function directive and do amplify push
Try now to remove this field or switch back to @connection and do amplify push

Additional information
Unfortunately, that's another point to the category why not use Amplify in production because this issue probably prevents rolling back to some previous commits when updating the API will fail.

@ray415 to unblock could you do iterative deployments by

Removing the @connection directive first from the product field
Do an amplify push
Add the @function directive to product field
Do another push.

It would be helpful to have the complete project including the stack mapping if any to debug this issue. Could you share your project and by sending email to<EMAIL_ADDRESS>Please redact any sensitive information from the project before sending it over.

@yuth any ideas?

Hey @ray415 :wave: apologies for the delay! Are you still experiencing this issue with the latest version of the CLI?

Closing due to lack of follow up. If you are still having problems please open a new issue.


Explain what hack and tell is

Should we maybe explain what hack and tell is on the website? Right now it's just a collection of the hacks but maybe we could add a short paragraph at the top to explain to newcomers what they are looking at? That way we could link to that page to explain to people what BHNT is instead of having to link to the Meetup page.
What do you all think?

What do you all think?

love the idea - that said I will realistically have no time to work on this any time soon ..

@k-nut That's a very good idea. In case you'd like to draft such a paragraph, please go ahead.

@ligi you can close this. it's been merged.


Column cannot be sorted in "Record mode"

Description
The sorting in record mode used to work.  After I updated to <IP_ADDRESS>212251901, the sorting arrow was gone.
DBeaver Version
<IP_ADDRESS>212251901
Operating System
Window 10
Database and driver
Sybase
jConnect (TM) for JDBC(TM)/16.0 SP03 PL02 (Build 27403)/P/EBF27518/JDK 1.6.0/jdbcmain/OPT/Mon Aug 28 18:41:14 PDT 2017
Steps to reproduce

query a table
click record
The arrow in missing in coulumn_name column

Additional context
No response

thanks for the report.
Closed as a duplicate of #18618


tiledbsoma 1.4.0

Following

https://github.com/TileDB-Inc/tiledbsoma-feedstock/pull/36
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases

"Queued" for 3+ hours; not sure what's going on ...

@Shelnutt2 all checks are passing


Relative error quantiles

This is not done, but it is easier for folks to review and leave comments if it is in PR form.
When it is all done and reviewed, I will do the merge.
Thanks.

This is very close to release quality.  There are a few more things I'd like to check but I can do that once this is in master.

The LGTM "alert" above is a False Positive and I can't make it go away.  I placed the error suppress comment on the "offending" line, so now it doesn't highlight it, but it still causes the error.  I presume this is a bug in LGTM.
This code has already had several folks look at it, all with good suggestions. I'm going to go ahead and merge this


Added support to send a Telegram notification & a few minor improvements

Added support to send notification to Telegram
Set the paths variable for the "Added Files Hook"
Fixed a bug in the hook that failed due to overriding the categories_verbose with the slug
Added in the notification hook a couple of environment variable checks before using them (so that it doesn't fail on forks)

During my testing I added a file to the notices folder and then deleted. That's why there are so many writes and deletes. Sorry.
Contributor Checklist
For Site Improvements

[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by the Bug Alert team if needed.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have run Pelican locally to ensure my changes have not disrupted the look, feel, or functionality of the site.
This worked for me yesterday, but post reboot - I'm unable to reach the site - I get that the connection is refused. But, I didn't make changes in the pelican site.
[x] I have checked my code and corrected any misspellings.
[x] I have added a pull request description which details the nature of this change.

Leave the following intact, which notifies our volunteer team: @BugAlertDotOrg/volunteer-team

I'd feel better getting @mattlorimor's eyes on this too, before merging.


Move the Error Strings Global.vi to the Utilities library

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Moves the Error Strings Global.vi to a common library so that it can be used in other libraries without causing circular dependencies.
What testing has been done?
None.

Are all of the other VI changes just because of updating based on the location change?

Are all of the other VI changes just because of updating based on the location change?

Yep. Changing libraries will update all of the callers.

I have mixed feelings about this change. Can you provide a little more detail of how you plan to take advantage of this in the future?
My concerns  are:

Having a global errors file that is referenced from multiple libraries seems like a bad idea from an encapsulation standpoint. Why not just put everything in or under a single top level library at that point? This isn't something we would think about in other programming languages so what's different about LV that would make this OK or necessary?
By Making this public within the utilities library, it seems like it would be easy to add this as a dependency to the measurement service template code at some point without realizing it. If that happens, we're locked into maintaining this global errors VI in this library forever (or until we're comfortable breaking customer code). We can make the VI community scoped to help prevent that, but then we're promoting even more things to friendship status.  Maybe that's OK, but I fear our rampant use of friends will come back to bite us at some point.

I have mixed feelings about this change. Can you provide a little more detail of how you plan to take advantage of this in the future?
My concerns are:

Having a global errors file that is referenced from multiple libraries seems like a bad idea from an encapsulation standpoint. Why not just put everything in or under a single top level library at that point? This isn't something we would think about in other programming languages so what's different about LV that would make this OK or necessary?
By Making this public within the utilities library, it seems like it would be easy to add this as a dependency to the measurement service template code at some point without realizing it. If that happens, we're locked into maintaining this global errors VI in this library forever (or until we're comfortable breaking customer code). We can make the VI community scoped to help prevent that, but then we're promoting even more things to friendship status.  Maybe that's OK, but I fear our rampant use of friends will come back to bite us at some point.

For the Get Connections user story, there are a few cases where I will need to throw errors. I would like to use the Error Strings Global.vi to do that so it is easier to verify that I am not reusing an error code. I view Error Strings Global.vi as measurementlink-labview's error database. Yesterday we discussed other ways we can single source our error codes (like the Error Ring), and we should probably do that some day, but I don't want it to distract from our features.
Would it be better if I just made it a loose VI that wasn't part of any library? Or put it in its own library? Both of those are possible and might alleviate your concern about the template.

Jason and I discussed this offline. We are going to make the error VI a loose VI for now and create a user story to handle errors better in the future.


About the images

Hello! I have some problems when I run the codes.
What's the format of NSD_images and where can I download them?

They should be available when you download the dataset from https://naturalscenesdataset.org/.

Hello! The names of the 10,000 images being read from within are based on specific IDs. How can I obtain these 10,000 images that conform to the required code ID format?

These specific IDs are their IDs in COCO image dataset,instead of IDs in NSD dataset. An alternative solution is downloading the whole COCO 2017 train/val image dataset and set the COCO dataset as the stimuli folder.


How to set the dialog to always be at maximum height with a customView

([x] becomes a filled in checkbox, [ ] is an empty one)

[ x] I understand that dialogs which require a combination of different dialog types provided by this library (e.g. list + progress, input + checkbox) require a custom view.
[ x] I have verified there are no duplicate active or recent bugs, questions, or requests
[ x] I have verified that I am using the latest version of Material Dialogs.
[ x] I have given my issue a non-generic title.
[ x] I have read over the documentation (before asking questions on how to do something).

Include the following:

Material Dialogs version: <IP_ADDRESS>
Device OS version: 7.1.1
Device Manufacturer: Google
Device Name: Pixel XL

I have a custom view dialog, and i want it to be at maximum height and for my content to match its height...

There is no way to do that, other than to make your content taller.


minecraft: 2.2.1441 → 2.2.1867

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114134 at 8628e29c run on x86_64-linux 1

1 package built:

minecraft

This appears to have broken the game for me. Weird.


Combine multiple Android fs libraries

[X] https://pub.dev/packages/file_saver
- [ ] https://pub.dev/packages/file_picker
[ ] https://pub.dev/packages/jsaver
[ ] custom native file saving code

You are right, it's best to support all platforms. Since this issue was created file_picker had 2 (3?) major versions, which look very promising. I removed it from the issue and added the platform specific code.
jsaver on the other hand is still not ideal and doesn't support linux/windows platforms anyways. I still depend on it because it's the only package I'm aware of that supports saving files to a directory the user picked once (OPEN_DOCUMENT_TREE). I opened a related feature request with file_picker and noticed some related PRs so this might be combined soon.
In general is solid support for more platforms currently quite difficult since there is still some manual testing involved with upgrades and data migrations. I agree tho that specifically Linux is quite important (for the reasons you mentioned and potentially linux phones). There is  a similar case for IOS with lots of people that could benefit from the app but no way for me to properly test the app and unfamiliar (expensive?) publishing.

While debugging android build failures in the latest flutter beta jsaver blocks updating gradle (with that agp and flutter) from updating. Since jsaver seems to be unmaintained I'm considering a custom fork. @pimlie I saw you have a PR there, what do you think?

Unfortunately file_pickers saveFile doesn't allow persisting directory access (they have a open PR like this). file_saver is a different use case. I asked around the flutter community and they couldn't help, so I think I will try my luck on a simple custom package.


BUG: special.log_wright_bessel: fix non-log for 1<x<=2

Reference issue
Closes gh-21651 @dskoch
What does this implement/fix?
Add a missing log check in the {log_}wright_bessel implementation in xsf.
Additional information
cc @lorentzenchr @steppi @WarrenWeckesser

Failures seem unrelated. Thanks @lucascolley @lorentzenchr et al!


Correction for raw affiliation Centre d'études Alexandrines; Histoire et Sources des Mondes antiques

Correction needed for raw affiliation Centre d'études Alexandrines; Histoire et Sources des Mondes antiques
raw_affiliation_name: Centre d'études Alexandrines; Histoire et Sources des Mondes antiques
new_rors: 051a9ap09;01yx7av22
previous_rors: 051a9ap09;04yavcg77
works_examples: W4316672857
contact: a296d9ff2cd5866cd4fcfab4529d4014:1afdcda40ebaa49ec1ed9d28d5b5 @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-01. The new affiliations should be visible within the next 7 days.


[BUG] Cannot be enabled on iPad

Describe the bug
In Community Plugins, I click the enable toggle. It makes a momentary animation, but does not switch on.

This plugin only works on desktop because it has a strong dependency on Electron, which the Obsidian mobile app does not use.


Live Display Implementation

There has been interest in live updating when it comes to using rich.
Proposal
The main goal of this is to provide an abstraction of the Progress feature that can be used with any RenderableType -- Live.
Progress
I'm currently working on this in #382.

Significant portions of the code and logic from rich.progress have been re-used for the implementation.  There is a working example going with some extremely raw tests included python -m rich.live
Potential Areas of Concern

Lots of duplicate code exists between Progress and Live

Perhaps they should share a common abstract parent class?

Limited by the height of the users console.

Any tables or renderable larger than the display cannot be properly cleared (limitation of consoles). As such, the console begins to expand as parts of the
There is a flag hide_overflow turned on by default, that will render "Terminal too small" when the renderable is too tall. This comes with some performance overheads of having to pre-render the Renderable to check its height.
I'm curious if something along the lines of the pager functionality could be used on an oversized renderable

Tasklist

[x] Unit tests
[ ] Testing / considerations for an IPython console. Currently does the same thing as Progress.
[x] Documentation of usage
[x] An assortment of examples

Feedback
Let me know if there are any features needed or different design decisions you would like to see.

Thanks @nathanrpage97 This will be in the next release


bump app-proxy

/e2e

/e2e

Codecov Report

Merging #185 (b645ea9) into main (c8504f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   24.86%   24.86%
=======================================
  Files           1        1
  Lines         189      189
=======================================
  Hits           47       47
  Misses        136      136
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8504f4...b645ea9. Read the comment docs.

already bumped to 0.0.14


stable fluids is not work when didn't set pointer

Need to work without setting the pointer

https://github.com/ukonpower/ore-three-ts/commit/29f35762e8b280f038f7661c4255629f35d57cb9


Passing all args to sample_rep() in TransformedDistribution

sample_rep() in TransformedDistribution was not passing num_samples to base_distribution.sample_rep(). num_samples argument was added.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Looks good! Thanks!


[zkserver] Unexpected session error

Sever errors like this occured in zkserver
2021-03-20 16:08:09 [SES][ERR] sessionWriter write failed cb83f9f185c4b89dff9689a32c
cb742a5194a32d0097030fff2b8800d4d8d106: could not write push: could not marshal

The failure occurred in the xdr.Marshal call. Unfortunately, the xdr package is too loud in its errors so it always returns a generic could not marshal error. The likely failure is the underlying network connection being wedged somehow. The XDR marshal call does not fail in zkserver since the data has been curated before the marshal occurs. It is likely that this was an OS or network level issue. Under normal circumstances the connection would have been terminated and that obviously did not happen.
func (kx *KX) writeWithKey(data []byte, k *[32]byte) error {
        payload := secretbox.Seal(nil, data, &kx.writeSeq, k)
        incSeq(&kx.writeSeq)
        if uint(len(payload)) > kx.MaxMessageSize {
                return ErrOverflow
        }
        _, err := xdr.Marshal(kx.Conn, payload)
        if err != nil {
                return ErrMarshal
        }
        return nil
}


win-menu-command crashes when ng-repeat directive is used

I'm unable to use ng-repeat on the win-menu-command, which is kind of ironic when the sample (README.md) says it's a good idea...
Exception:

Code:
<button id="menuAnchor">Show a menu!</button>
<win-menu anchor="'#menuAnchor'">
    <win-menu-command ng-repeat="(key, value) in settings.flickr.sortList" label="'Test'"></win-menu-command>
</win-menu>

    var sortList = {
        'date-posted-asc' : 'Date uploaded',
        'date-taken-asc': 'Date taken',
        'interestingness-desc' : 'Interesting',
        'relevance': 'Relevent'
    };

I also tested with a "item in items" style ng-repeat and an array with two elements of key and value, same error.
Is this a bug or am I doing this wrong?

I have the same problem to create a dynamic AppBar...
Is it possible to add new commands in the html content (with angular binding like above on @sondreb's code) or directly in the controller ?
Thank's for reading :)

What is the status of this issue?  This was reported on April 25th.  There has been no activity and I am experiencing the same problem.


[image_picker] Add "DateTimeOriginal" to EXIF copied attributes.

Description
Adds DateTimeOriginal to EXIF copied image attributes. Since it corresponds to the time when the photo is taken, it is an important information.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[X] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I read and followed the [Flutter Style Guide].
[X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[ ] I updated CHANGELOG.md to add a description of the change.
[X] I signed the [CLA].
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[X] No, this is not a breaking change.

(Hello, I am from China and my English is not good) In ios environment of flutter module, image_picker cannot be used. The first time you open it, there is nothing corresponding. The second time you directly report an error: Platform Exception (Multiple _ Request, Canceled by a Second Request, Null)

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
Per Flutter policy (and as indicated by the checklist) this will need tests before it can move forward.

Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks!


flagset.Output() missing from methods

Its in the stdlib flag interface; and when you're doing flagset specific Usage() functions, you kinda need it if you want to use the same output as the flag.Usage()...

Nope; its there: just doesn't have a tag.

@yarbelk What do you mean when you say it's there, just does not have a tag? I can't find the method in FlagSet.

https://github.com/spf13/pflag/blob/d5e0c0615acee7028e1e2740a11102313be88de1/flag.go#L258-L265
In master branch, the Output() method is found. (PR https://github.com/spf13/pflag/pull/220)
But latest tagged version v1.0.5 does not include it.

Hey, I use a commit with PR #220 merged extensively in my projects.
It would be great to have new tagged version containing it!
And this issue closed that way.


[Suggestion] Compress trades

Make trades load faster by decreasing json size.
Could be done by sending item array and using skus only in trades so we dont repeat so much data

Added in dev


Potential memory overwritten in console module

unios fails to start-up after e8a1562 and behaves like a panic occurred before tty & console fully setup.
parts mentioned below requires further fixup:

concurrency issues in fork, wait, exit, execve and memory allocation
memory access bound check
execution flow of out_char
design of vga ctrl

fixed and run well in v0.8.0-rc1 62521611edbf47293692953489eed4c2e3be7aa9.


test_mode bug

I want to test the SR and SRGAN model. Now, I find a question :
Traceback (most recent call last):
File "test.py", line 49, in
for data in test_loader:
…
…
File "/opt/BasicSR-master/codes/data/util.py", line 262, in calculate_weights_indices
if not math.isclose(weights_zero_tmp[0], 0.0, rel_tol=1e-6):
TypeError: a float is required
I tried to tranform the weights_zero_tmp[0] to floattensor, but it still don't work.
weights_zero_tmp_1 = torch.sum((weights == 0), 0)
print(type(weights_zero_tmp_1))                                     #torch.ByteTensor
weights_zero_tmp = weights_zero_tmp_1.float()
print(type(weights_zero_tmp))                                       torch.FloatTensor
print(type(weights_zero_tmp[0]))                                   torch.FloatTensor
print(weights_zero_tmp[0])           #120 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 120[torch.FloatTensor of size 18]#
if not math.isclose(weights_zero_tmp[0], 0.0, rel_tol=1e-6):
indices = indices.narrow(1, 1, P - 2)
weights = weights.narrow(1, 1, P - 2)
if not math.isclose(weights_zero_tmp[-1], 0.0, rel_tol=1e-6):
indices = indices.narrow(1, 0, P - 2)
weights = weights.narrow(1, 0, P - 2)

Sorry for the late reply.
I do not encounter this problem.
In the code, the corresponding line is
if not math.isclose(weights_zero_tmp[0], 0, rel_tol=1e-6): # maybe you should change 0.0 to 0
And I print the type of weights_zero_tmp[0], it is torch.LongTensor. There is no float tensor.
Hope it can help.
If you still have the problem, you can first generate LR images using matlab temporarily.


Enable more doctests.

Enable doctests in series.py and make run-tests.sh handle doctest failures properly.

This is great.


fix missing " in screenshot for OR

it tries to source .../sc_write_images.tcl" which is not a file


knife supermarket share errors with 'ERROR: Multipart POST part 'tarball' is corrupt: "\x80\x00\x00\x00\x0E:\xBFD" is not an octal string'

Description
When trying to upload cookbook to Chef Supermarket, I get the error ERROR: Multipart POST part 'tarball' is corrupt: "\x80\x00\x00\x00\x0E:\xBFD" is not an octal string
Example:
$ knife supermarket share stig -VV -o ../ -c ~/.chef/knife-chefio.rb
INFO: Using configuration from /Users/isuftin/.chef/knife-chefio.rb
INFO: Validating ruby files
INFO: Validating templates
INFO: Syntax OK
Generating metadata for stig from /var/folders/58/n9bfwg050sdg1dmn9688wrcm001rp_/T/chef-stig-build20190410-52953-ff735p/stig/metadata.rb
Making tarball stig.tgz
DEBUG: Signing: method: post, url: https://supermarket.chef.io/api/v1/cookbooks, file: #<File:0x00007ff745d18988>, User-id: isuftin-usgs, Timestamp: 2019-04-10T13:06:07Z
ERROR: Multipart POST part 'tarball' is corrupt: "\x80\x00\x00\x00\x0E:\xBFD" is not an octal string

I did try switching gem versions as mentioned here:

https://github.com/chef/chef-dk/issues/1549#issuecomment-387342439

This did not help.
Possible related issues:

https://github.com/rubygems/rubygems/issues/2213
https://github.com/cerner/cerner_splunk/issues/143

ChefDK Version
Using Chef Workstation.
$ chef -v
Chef Workstation: 0.2.53
  chef-run: 0.2.8
  chef-client: 14.10.9
  delivery-cli: 0.0.52 (9d07501a3b347cc687c902319d23dc32dd5fa621)
  berks: 7.0.7
  test-kitchen: 1.24.0
  inspec: 3.6.6

$ chef gem -v
2.7.6

Platform Version
MacOS:
$ sw_vers
ProductName:    Mac OS X
ProductVersion: 10.12.6
BuildVersion:   16G1917

Replication Case
What i do locally for a cloned tagged checkout of https://github.com/USGS-CIDA/stig:
$ knife cookbook metadata stig -o ../
Generating metadata for stig from /Users/isuftin/Chef/cookbooks/stig/metadata.rb

$ knife supermarket share stig -VV -o ../ -c ~/.chef/knife-chefio.rb

INFO: Using configuration from /Users/isuftin/.chef/knife-chefio.rb
INFO: Validating ruby files
INFO: Validating templates
INFO: Syntax OK
Generating metadata for stig from /var/folders/58/n9bfwg050sdg1dmn9688wrcm001rp_/T/chef-stig-build20190410-60032-1e5qcb1/stig/metadata.rb
Making tarball stig.tgz
DEBUG: Signing: method: post, url: https://supermarket.chef.io/api/v1/cookbooks, file: #<File:0x00007fc414f2f398>, User-id: isuftin-usgs, Timestamp: 2019-04-10T13:14:14Z
ERROR: Multipart POST part 'tarball' is corrupt: "\x80\x00\x00\x00\x0E:\xBFD" is not an octal string

My knife-chefio.rb file looks like:
$ cat  ~/.chef/knife-chefio.rb
current_dir = File.dirname(__FILE__)
log_level                :info
log_location             STDOUT
node_name                "isuftin-usgs"
client_key               "#{current_dir}/isuftin-usgs-chefio.pem"
chef_server_url          "https://supermarket.chef.io/"

Stacktrace
https://gist.github.com/isuftin/e8bb0804d5510a0258ead2ea65638fca

FYI: We hit the same issue - turns out that the error was coming from the supermarket server, not the chef-workstation/chefdk knife client (I think chef-workstation is using an older version). As a workaround, we rolled back our supermarket instances to the previously installed version or rolled back rubygems on the supermarket server as a workaround. We didn't need to change knife at all

... turns out that the error was coming from the supermarket server

Good finding. Supermarket 3.2.2 included an upgraded RubyGems to close several CVEs. Can you open this issue on chef/supermarket?

This was resolved by migrating Supermarket to libarchive from built in ruby archive handling.


solito.dev website is unavailable

The link to the website https://solito.dev/ does not load

must be a regional thing, it works for me

It works now, I'll close it. It was down for at least 15 minutes, thought it vanished. Thanks

it actually just works on mobile, not in Chrome on OS X.
This site can’t be reachedsolito.dev’s server IP address could not be found.
"Not?A_Brand";v="8", "Chromium";v="108", "Google Chrome";v="108" is one of the headers.
nslookup:
Name:	solito.dev
Address: <IP_ADDRESS>
using same router on mobile phone.
same issue on Firefox, both also with caching disabled.
Any ideas?


[SMALLFIX] Fix typo for HDFS listStatus

@calvinjia

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15229/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.master.file.FileSystemMasterIntegrationTest.concurrentRename
Test FAILed.

Merged build finished. Test FAILed.


Add import functionality

One more important thing, update the user guide

Codecov Report

Merging #104 (f72cfbe) into master (68434ea) will decrease coverage by 1.70%.
The diff coverage is 1.96%.

@@             Coverage Diff              @@
##             master     #104      +/-   ##
============================================
- Coverage     70.60%   68.90%   -1.71%
  Complexity      582      582
============================================
  Files            96       98       +2
  Lines          2004     2055      +51
  Branches        246      253       +7
============================================
+ Hits           1415     1416       +1
- Misses          502      552      +50
  Partials         87       87

Impacted Files
Coverage Δ

...address/logic/commands/schedule/ImportCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
66.66% <0.00%> (-2.90%)
:arrow_down:

...ess/logic/parser/schedule/ImportCommandParser.java
0.00% <0.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
92.85% <100.00%> (+0.54%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68434ea...f72cfbe. Read the comment docs.

LGTM!

LGTM for me, @hanqinilnix, @markbiju anything?

can help add test for this command on AddressBookParserTest.java as well?


Relay disconnection

Hello,
I was experiencing an issue with a listener disconnecting from service bus periodically, so I implemented the RelayConnectionStatus code that wires up the ConnectionStatusBehavior. Here is what was written to my log file:
2016-09-07 08:36:10,116 [58] DEBUG  - Lost Connection. Reconnecting Event. Last error encountered Exception of type 'System.ServiceModel.CommunicationException' was thrown.
2016-09-07 08:36:13,554 [12] DEBUG  - Going Offline Event. Last error encountered Generic: ExpiredToken:
2016-09-07 08:36:13,555 [12] DEBUG  - Relay Echo ServiceHost faulted. Generic: ExpiredToken:
2016-09-07 08:36:13,627 [12] DEBUG  - Relay Echo Service encountered permanent error Generic: ExpiredToken:
It seems the server this was running on was a couple of minutes behind. I've adjusted the server time and am monitoring the relay today to see if that resolves the issue, but was wondering if that is the case, is this a scenario that can be worked around or handled in some way that doesn't require adjusting the server time? I guess I need to back up a little, is that "ExpiredToken" error due to server times being off or something else?

Update: Listener disconnected again even after correcting the server time on the client side.
2016-09-07 09:20:22,713 [11] DEBUG  - Going Online Event
2016-09-07 10:19:52,700 [21] DEBUG  - Lost Connection. Reconnecting Event. Last error encountered The connection was inactive for more than the allowed period of time.
2016-09-07 10:19:56,156 [12] DEBUG  - Going Online Event
2016-09-07 11:19:57,622 [17] DEBUG  - Lost Connection. Reconnecting Event. Last error encountered Exception of type 'System.ServiceModel.CommunicationException' was thrown.
2016-09-07 11:20:00,984 [12] DEBUG  - Going Offline Event. Last error encountered Generic: ExpiredToken:
2016-09-07 11:20:00,985 [12] DEBUG  - Relay Echo ServiceHost faulted. Generic: ExpiredToken:
2016-09-07 11:20:01,000 [12] DEBUG  - Relay Echo Service encountered permanent error Generic: ExpiredToken:

Please see our new service / samples repo, and refile if necessary: https://github.com/azure/azure-relay


"Render stateful interactive components from Razor pages and views" guidance is severely lacking details

The section in your docs suggest that all you need to do is use "await Html.RenderComponentAsync...." tags.
In reality you also need to add extra using statements into your _Imports.razor file (that  are only apparent after going through the downloadable samples), an extra tag into the Head of the page, extra extra endpoints and services in to your Startup.cs (which to be fair I did pick up from other parts of the doc).
I've been using components in this way for the last 6 months in various preview versions, and having to put "extra" using statements in the _Imports.razor file was the last thing I thought of - taken me 2 hours to work this out, could have taken 5 minutes if there was a proper document for this hybrid style of usage rather than a single paragraph that was mixed up in the middle of the other two hosting scenarios.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 542f38c4-1502-f739-372a-80c86c377491
Version Independent ID: 72c2a844-ffb2-4799-2c7a-a7a73d3b6833
Content: ASP.NET Core Blazor hosting models
Content Source: aspnetcore/blazor/hosting-models.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Correct, we haven't had how to convert or hybrid coverage to date.
This seems like an extension of your earlier remarks on https://github.com/aspnet/AspNetCore.Docs/issues/13546. I've moved your remarks here over to that issue, which is awaiting triage by engineering. They'll get to it soon enough. Stand-by for their response.

Thanks for the feedback, understood. Apologies for my rant, I was just frustrated the time it took to get to the bottom of it, which I thought would have been covered in the docs for the final release, but we're all busy people so it's cool :)

One of the background problems is the degree of churn. Engineering is still cranking away on framework scenarios. I agree we need the coverage, but it might be that 3.1's release is a good time to address this problem. The 3.1 release is coming soon. Preview 3 just landed. It won't be long now. Your issue is on the list, and they will see it and triage it shortly. To get a sense of everything we're doing, take a look at the Blazor.Docs project ... you'll see what I mean. 🏃🏃😅
https://github.com/aspnet/AspNetCore.Docs/projects/35


Cleaned up feature flags and imports

A conditional no_std is kinda weird to see. Should be unconditional, and then do an extern crate std; if std is ever set.

Looks good, thanks for the PR =)


Support for dynamic stats tags

The problem I'm facing is being able to add custom tags to a certain metrics, which their value is dynamic. Taking a counter stat for example, I would like to add a tag which its value is only being known at runtime. Ideally, when calling inc(), on a counter, I would also like to provide that tag: inc(key, value) or inc(set_of_tags_with_values).
An example use case (although I wouldn't do this, but just to show what I mean in practice), is a call for inc("time", getCurrentTime()), which is placed in onNewConnection(). Here the time value varies, so every time onNewConnection() is being called, it gets a different value
Would it be possible to add an overload to inc() as in the example above to cope with this? Otherwise, I'll appreciate help figuring out this problem.

You can pass a tag vector to the counters, e.g. https://github.com/istio/proxy/blob/master/source/extensions/filters/http/istio_stats/istio_stats.cc#L736. The value can be any StatName, including pool allocated strings.

Thanks @kyessenov, I'm not sure if I got your suggestion correctly though, can you elaborate on the underlying process when doing so? An example with relevance to the example use case I showed in the original message would be useful (regarding time tag).

@ohadvano The example doesn't quite make sense, but the way you'd do it is:

Create a long living stats scope that holds all metrics with different tag vector combinations.
Create a stat name pool to define symbols for tag vector values - ideally during configuration, but can be done per request.
Create a stat with counterFromStatNames with symbols from the pool.
Increment the metric.

Take a look at grpc_stats filter for some examples - it's following this pattern.

cc @jmarantz

Thanks @kyessenov, I tried that approach and generally I was able to create a stat, however I encounter some problem which I'm not sure whether it's a bug or I have misunderstood how something works here.
In my .yaml, I am using stats_config.stats_tags to add general tags to all stats. If I create a stat using the following code, then the stat is created successfully with the general tags list added:
Stats::StatName name = config_->statsNamePool().add("test_stat");
config_->statsScope().counterFromStatNameWithTags(name, absl::nullopt).inc();

However, if I create the stat using the following code (which adds custom tags), then the tagExtractedName() is "test_stat", the name() is "test_stat.test_tag_key.test_tag_val" and the tags list only has "test_tag_key" tag, omitting all the globally defined tags:
Stats::StatName test_tag_key = config_->statsNamePool().add("test_tag_key");
Stats::StatName test_tag_val = config_->statsNamePool().add("test_tag_val-should-be-some-dynamic-value");
Stats::StatNameTagVector tags{{test_tag_key, test_tag_val}};

Stats::StatName name = config_->statsNamePool().add("test_stat");
config_->statsScope().counterFromStatNameWithTags(name, tags).inc();

Any idea why this happens and what can I do to fix this? cc @jmarantz

What's a globally defined tag and how would counterFromStatNameWithTags know about it?

Sorry, I misunderstood the context. I think you are expecting counterFromStatNameWithTags to combine with the config-based tags and the default tags, but I think that's not what it does.
I think it only uses the default and configured tags when the optional tags parameter is omitted.

I think you are expecting counterFromStatNameWithTags to combine with the config-based tags

Yes.

I think it only uses the default and configured tags when the optional tags parameter is omitted.

Seems like it, because when I don't specify the optional tags then I do get the config-based tags.
I am wondering isn't it expected that the tags would be combined?
Is there something that can be done on stat creation to support this merge of tags? (tags from code and config both).
Thanks @jmarantz

It doesn't seem too difficult but would require some mechanism to control whether the current behavior is preferred or the combined behavior. I would guess the control here should be a new optional flag provided to counterFromStatNameWithTags (and its 3 siblings for gauges, text-readouts, and histograms). It's going to be quite a bit of toil to do this for these 4 methods and the half-dozen or so derived classes of Stats::Scope, but it wouldn't be that hard.
If you decide to embark on this, please be sure to also make a parallel semantic change to isolated_store_impl.cc, which should be kept in sync as that's used for lots of tests.
The code controlling this is here: https://github.com/envoyproxy/envoy/blob/4dd9cbc306aa042eaeef1a14d908cd18adc801ca/source/common/stats/thread_local_store.cc#L428
You can see there it only calls the tag-producer to aggregate the well-known tags with the configured tags if the stat_names are not specified by API.
I can help review this.

Thanks @jmarantz, I'll try to get to work on this soon. Can we mark this is help-wanted until then so the issue wouldn't close itself?


Add a Gen for Enum values

There is no nice way to get a Gen for enums.
Unfortunately the current version of Kotlin (1.0.5), does not support iterating over the values of an enum class specified as a generic.
The good news is that it is supported from Kotlin 1.1-M3, see https://github.com/Kotlin/KEEP/blob/master/proposals/generic-values-and-valueof-for-enums.md and https://youtrack.jetbrains.com/issue/KT-10569
The fix is trivial with newer versions of kotlin:
inline fun <reified T : Enum<T>> oneOf() = oneOf(enumValues<T>().toList())

This allows developers to do the following:
enum class MyEnum { ENTRYA, ENTRYB }

Gen.oneOf<MyEnum>().generate()

If you make this PR against the v2.0 branch, I'm happy for that to be 1.1+
@helmbold you agree?

I like the extension for enums. I expect Kotlin 1.1 to be released at the beginning of 2017, so it shouldn't be an issue to couple KotlinTest 2.0 with Kotlin 1.1. If Kotlin 1.1 would be delayed unexpectedly so that we our release would be delayed too, we could push this change to 3.0, so it is low risk to include it now.

Can't be much longer for 1.1 surely, been a long time already.

Added


close the first modal  with animation,  then open the second modal  immediately, the second modal can't be showed

Description
close the first modal  with animation,  then open the second modal  immediately, the second modal can't be showed
if the first modal without animation, the second modal show ok;
Steps to reproduce
close the first modal  with animation,  then open the second modal  immediately
React Native Version
0.73.6
Affected Platforms
Runtime - iOS
Output of npx react-native info
empty

Stacktrace or Logs
empty

Reproducer
empty
Screenshots and Videos
empty

Also face the same issue in iOS, In my case i use
InteractionManager.runAfterInteractions(() => {       setModalVisible(true)   })


web_sys::CanvasRenderingContext2d missing method 'get_image_data'

Description
In the web_sys documentation, the get-image-data method should be on the CanvasRenderingContext2d. However, when calling the method on an instance of the context, I get the error:
error[E0599]: no method named `get_image_data` found for type `web_sys::CanvasRenderingContext2d` in the current scope

I am on web-sys version 0.3.14, js-sys 0.3.14, and wasm-bindgen 0.2.37.
Steps to reproduce
Run the following lines:
let window = web_sys::window().unwrap();
let document = window.document().unwrap();
let canvas = document
    .create_element("canvas")?
    .dyn_into::<web_sys::HtmlCanvasElement>()?;

let context = canvas
    .get_context("2d")?
    .unwrap()
    .dyn_into::<web_sys::CanvasRenderingContext2d>()?;

let _tmp_context = context.get_image_data(0, 0, 50, 50).unwrap(); // error thrown here

This will throw the compiler error above.
Let me know if any additional information is required.

From the get_image_data docs:

This API requires the following crate features to be activated: CanvasRenderingContext2d, ImageData

Are you enabling those features? If not, then that is likely your issue.
If you are enabling those features and are still getting the error, can you share a whole crate that reproduces the error, rather than just the src/lib.rs? Thanks!

Oops sorry about that. Thanks!


Impossible to have several botkit slackbot on for the same slack team

Hi,
I have a production bot and a testing bot, each one in the same slack instance.
I was becoming crazy after seing only one was working, but never the two at the same time.
Then i debugged and saw that in the team storage, the bot token was stored and taken from there instead of using the one of process.env.token, for whispers and interactive messages.
{
    "_id": {
        "$oid": "5b1db854e166d948cd2fc706"
    },
    "id": "TAK1PSEHK",
    "createdBy": "UAJQ4BAD9",
    "url": "https://dxco4sf.slack.com/",
    "name": "DXC.technology",
    "state": "botkit",
    "bot": {
        "token": "xoxb-359057898597-378195724309-nYW0tFbJk1kJ5N9lycnopsq6",
        "user_id": "UB45RMA93",
        "createdBy": "UAJQ4BAD9",
        "app_token": "xoxp-359057898597-358820384451-378813533125-901739b5ab74809b8374524555ea07d0",
        "name": "lelamanul"
    },
    "token": "xoxb-359057898597-378195724309-nYW0tFbJk1kJ5N9lycnopsq6"
}

Structure show that a team can have only one bot.
Would it be possible to have bots intead of bots property, to store several bots and their associated tokens ?
Note: a first workaround could be to change function configureRTM to not override a token when there is already one
    bot.configureRTM = function(config) {
        if (!bot.config.token)
               bot.config.token = config.token;
        return bot;
    };

Changes to this will have to be made carefully to not break any other user's existing application, The current prescribed workflow is to have a user create another slack app instance with its own storage for dev, prod, workflows to avoid the problems you point out.


build: use vite to bundle deps at main/preload package to avoid using broken electron-builder deps function.

Main purpose of this PR
Currently deps used at main/preload package is put under dependencies under package.json and building of those packages is using vite's ssr mode, which means deps will not be handled by vite but electron-builder instead. This PR will use vite to bundle deps at main/preload package just as the same as the renderer package to avoid using broken electron-builder deps function.
Why switching how deps get bundled?

Because deps bundle function is broken in electron-builder:
You need to maintain good old npm node_modules structure.
electron-builder internally uses develar/app-builder whose node_modules bundling function (nodeModuleCollector.go) only recognize good old npm node_modules structure.
It doesn't recognize pnpm's soft-linking node_modules structure. So if your deps used in main/preload have their own sub-dependencies, it will NOT get copied by electron-builder resulting in runtime error because of missing deps (https://github.com/electron-userland/electron-builder/issues/6289). The workaround currently is to tell pnpm using hoist deps mode which is basically to force pnpm using good old npm node_modules structure and forgets about soft-linking packages. It's painful if you are using pnpm in monorepos to avoid files copying.
I don't use yarn but I suppose yarn's PnP structure will also been rejected. (https://github.com/electron-userland/electron-builder/issues/6639)
For monorepos, it has to maintain the same structure. This has been reported in https://github.com/electron-userland/electron-builder/issues/6933 , https://github.com/electron-userland/electron-builder/issues/7371 .
Those issues don't seem to be addressed by the maintainers.
Poor deps bundling
The deps bundling by electron-builder is poorly done:

Only *.md and *.d.ts gets removed. Other files (e.g. sourcemaps, artifacts of different archs) will be copied as-is.
No vite's tree-shaking. Unused code chunks, cjs+esm codes will be bundled.
No minify at all. Code in deps will be copied as-is with no minify.
Optional devdeps will be bundled. For example rxjs which is optional devdep of typed-emitter, which is dep of electron-updater, will be bundled. The dep search strategy of electron-builder is just "grab all deps and optional deps" regardless of whether a optional dep is devdep.

In my opinion, this is done poorly compared to vite/esbuild. It will increase the whole production build size which electron apps are often criticized for.
How this PR is going to fix it?

Use builtin-modules and electron-builtins to determine node and electron builtin modules.
Use build.rollupOptions.external to externalize those modules. Optionally you can use vite-plugin-commonjs-externals if any cjs-esm interop issues is met.

      external: src => {
        const [name] = src.split('/');
        const externalNames = [
          ...nodeBuiltins,
          ...nodeBuiltins.map(name => `node:${name}`),
          ...electronBuiltins,
        ];
        return externalNames.includes(name);
      },

Forbid electron-builder from copying any node_module files as now all deps are bundled by vite.
Move vue to dependencies under package.json (revert #901). Any further deps used by all three packages can also be added for distinguish which will be ships to builds clearly.

Have this PR been tested?
I've tested the template and my own rush + pnpm monorepo setup on Windows 10 which is flawless. Both watch and production build work as intended.
I want to share package/code between main/preload package
For packages, if it's written in ESM and the code used in main/preload is from different chunk, it will be fine due to vite's tree-shaking feature. Otherwise you can transform this project's structure to utilize vite's multi-entry feature to achieve the goal of reusing codes.

Hi there. Thanks for you contrib. Basically you propose a kinda revert https://github.com/cawa-93/vite-electron-builder/commit/d002d6f2267418407d173e538e3792e012a67415.
From another issue

Previously it works exacly as you described. But this led to numerous problems (#664, #655, #613), because there are a huge number of packages that he will not be able to fully bundle. Usually these are packages that depend on native APIs directly or transitively.

As example: axios.
In your case you can't use axios in main anymore. AFAIR vite will resolved axios to browser-specific XHR adapter if ssr: false. To solve this, you forced to add axios to external packages. If so, you also forced to include full node_modules  into compiled app. And I didn't found any way to do that partially.
Also I remember some issues with electron-updater since it use semver that not bundling properly.

Thanks for your quick reply and the summary. It seems I've totally missed the point that ssr is the mode for node env. I've found that vite-node is using ssr mode. But I wonder using ssr bundle and ssr.noExternal will result in a better solution than electron-builder. Surely there's some deps that seems not working after bundling. I'll investigate into them later.
Anyway, turn back to web mode like this PR is the wrong way. I'll close this PR now. Thanks for your time.

I've tried using ssr.external and ssr.noExternal but they are nowhere convenient than build.rollupOptions.external.

ssr.external accepts string[]
ssr.noExternal accepts string | RegExp | (string | RegExp)[] | true
build.rollupOptions.external accepts string | RegExp | (string | RegExp)[] | ((source: string, importer: string | undefined, isResolved: boolean) => boolean | NullValue)

It's odd that you can specify one external pattern and one anti-pattern since you'll wonder how they overwrite the other one once colliding. ssr.external does NOT support RegExp and contains sub-paths (like fs/promises). And neither of them accepts function.
If I specify all node/electron externals in ssr.external and set ssr.noExternal to true, I cannot handle sub-paths. If I specify ssr.noExternal I need to resolve the dependency tree to find out every deps I installed including there sub-deps. I found it extremely inconvenient but the good old build.rollupOptions.external still works:
import nodeBuiltins from 'builtin-modules/static';
import electronBuiltins from 'electron-builtins';
export const config = {
  // ...
  build: {
    ssr: true,
    rollupOptions: {
      // ...
      external: (src) => {
        const [name] = src.split('/');
        const externalNames = [
          ...nodeBuiltins,
          ...nodeBuiltins.map((name) => `node:${name}`),
          ...electronBuiltins,
        ];
        return externalNames.includes(name);
      },
    },
  },
  ssr: { noExternal: true },
  // ...
}

There are a few amendments to ssr.external like https://github.com/vitejs/vite/pull/11817, https://github.com/vitejs/vite/pull/10939, https://github.com/vitejs/vite/pull/11093. But none of they accepts functions. Just use rollup external interfaces, please.

The remaining questions are now:

vite's package.json source resolving (https://github.com/cawa-93/vite-electron-builder/issues/655 axios)
Other tricky libs problems (https://github.com/cawa-93/vite-electron-builder/issues/664, https://github.com/cawa-93/vite-electron-builder/issues/613, https://github.com/npm/node-semver/issues/381). They may related to esm-cjs interop or minify stuffs.

I'll setup some reproductions and see if those problem exist.

If I specify all node/electron externals in ssr.external and set ssr.noExternal to true,

This have no sence, since noExternal: true have highest priority
https://github.com/vitejs/vite/blob/d953536aae448e2bea0f3a7cb3c0062b16d45597/packages/vite/src/node/ssr/ssrExternal.ts#L42-L44

Update: axios (repro) and file-type (repro) is fine.
For node-opcua (repro) I've got a different error:
VM543 renderer_init:2 Error: error:06000066:public key routines:OPENSSL_internal:DECODE_ERROR
    at createPrivateKey (VM476 keys:620:12)
    at message_builder.js:37:1
    at Module.<anonymous> (message_builder.js:508:1)
    at Module.<anonymous> (index.ts:6:1)
    at Module._compile (VM508 loader:1174:14)
    at Module._extensions..js (VM508 loader:1229:10)
    at Module.load (VM508 loader:1044:32)
    at Module._load (VM508 loader:885:12)
    at f._load (VM540 asar_bundle:2:13330)
    at o._load (VM543 renderer_init:2:3109)

Which tends to be their invalid key was not compatible with node:crypto.
(link to code)
export const invalidPrivateKey = createPrivateKey(`-----BEGIN RSA PRIVATE KEY-----
MB0CAQACAQ8CAwEAAQIBAQIBBQIBAwIBAQIBAQIBAg==
-----END RSA PRIVATE KEY-----`);

The new PR is going to be sent from branch fix-ssr。
Is there any other issues related to this PR? Let me know if any still exists, thanks!

Pls. check also ipfs-http-client, usb, electron-devtools-installer, koa and @koa/router

Update:

The invalidPrivateKey code block mentioned above is causing the exact same error seperately.
ipfs-http-client (repro) works in renderer.

I was able to perform a fix for the binary node issues.

Using build.rollupOptions.output.preserveModules to keep the file structure so those modules who relies on __dirname or __filename will works as intended.
Using build.rollupOptions.output.preserveModulesRoot to eliminate packages/preload/src under preserveModules mode so the entry point for main/preload will not be changed.
Set build.commonjsOptions.ignoreDynamicRequires to allowing dynamic requires to binary node native modules instead of shabby commonjsRequire which just throw an error.
Using vite-plugin-static-copy to manually copy those binary node native modules to the exact place as they were in the original node_modules package.
Now rollup will generate node_modules folder under dist. Just set includeSubNodeModules to true to tell electron-builder to copy those modules while compling and we're ready to go.

I've test it in both watch mode and prod builds. Both work flawlessly. I'll apply the fix to previous repros to see if there is any further bugs.

I've encountered some build bugs when applying the same methods for main package with rollup and vite. That issue was tracking at https://github.com/vitejs/vite/issues/12012

Workaround: set rollupOptions.preserveEntrySignatures to strict

Re-checking all repros.

axios (repro): OK
file-type (repro): OK
semver (repro): OK
node-opcua (repro): Same error as above
ipfs-http-client (repro): OK
usb (repro): OK
electron-devtools-installer (repro): OK
koa (repro): OK

All repros passed except node-opcua which contains buggy code.


Lesson 1: Syntax

Please use this ticket for discussions about Lesson 1: Syntax

I don't really understand, what should go here. The basic "semicolon ends a statement, curly braces mark borders of scope"? I think, it's better to introduce syntactic constructs one by one together with code that uses them.

shrug
Let's close it, than.


Addon builder doesn't applied

Hey all,
I have tried to create addon, library loads and displays template for it, but does not apply custom builder function (passed as 4th argument to schemaFormDecoratorsProvider.defineAddOn)
I have looked for example here
What am I missing? Any thoughts?

@gnom7 sorry I've been on holidays, did you solve your issue? If not can you make a plunker or provide an example of what you are trying?