showIncludesExcludes doesn't hide query details

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.89.0
OS Version: Windows 10.0.19045

Steps to Reproduce:
Create a keybinding to workbench.action.findInFiles with the showIncludesExcludes argument set to false.
    {
        "key": "ctrl+shift+f",
        "command": "workbench.action.findInFiles",
        "args": {
            "showIncludesExcludes": false,
            "useExcludeSettingsAndIgnoreFiles": false,
        }
    },

The search sidepanel appears but if the includes and excludes fields were shown from a prior search they are still visible.
The same happens even though the includes and excludes are cleared:
    {
        "key": "ctrl+shift+f",
        "command": "workbench.action.findInFiles",
        "args": {
            "showIncludesExcludes": false,
            "useExcludeSettingsAndIgnoreFiles": false,
            "filesToInclude": "",
            "filesToExclude": "",
        }
    },

Hmm, that isn't currently an option in findInFiles. But it can be added. You can see the existing fields here: https://github.com/microsoft/vscode/blob/220eb8e2a5b62834c963484eefcca0c0a9d80141/src/vs/workbench/contrib/search/browser/searchActionsFind.ts#L39-L51

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

To verify, try binding a keyboard shortcut like this:
    {
        "key": <keybinding>,
        "command": "workbench.action.findInFiles",
        "args": {
            "showIncludesExcludes": true,
        }
    },

And verify that setting showIncludesExcludes to true and false correctly shows the files to include and files to exclude fields in the search view.


Error on Import

When importing a character from Pathbuilder2e (android), A secondary actor is created and deleted but the original sheet is not updated, remaining blank. The import dialog is stuck on "Cooking (Equipment)". I am using some 3rd party feats (everything shields) but all my equipment is core. The error log is saying cant read properties of undefined, so it is hard to tell what part it is having problems with. Even unchecking all the import options except my name still fails.
To Reproduce
Steps to reproduce the behavior:
Create a character using Pathbuilder2e
Click on Export
Export as JSON
Note export number
Enter export number into Pathmuncher dialog
Click import
Expected behavior
Character values should be imported from Pathbuilder and copied into Foundry PF2 actor sheet
Environment:
Chrome
Foundry Version 10.291
Pathfinder System Version 4.12.5
Module Version 0.5.1
Does this behaviour occur with other modules disabled: Yes
In Pathbuilder please got to Export -> "Share Copy of Character" and provide the link.
https://pathbuilder2e.com/launch.html?build=435733
Details of any errors in the browser console (press F12).
pathmuncher.log

This imports for me (although with some parsing errors, which I will take a look at), but I don't get the same problem as yourself - when you export can you use the option to get the json file, then copy the contents here? Wondering if there is a slight difference between the web and android versions.

import.txt
Second.log
Here is the json. I tried copying the json in from mobile, same issue. I also tried copying the json from the web app and also doing the ID from the web app and same issue.

Updated to 4.12.6 and still having the issue.

Can you try on the latest version of Pathmuncher (v0.5.4) this might be a bug with the containers on v0.5.1

That was the fix, thanks for all the help!


docs: update readme with mod panel instructions

Resolves #698
🔧 What changed
Before there were no clear instructions on how to work in the moderation panel on dev. Due to the data being protected behind auth. There are now instructions that link those to the backend README so that they can set up the backend and then instructions how to run the backend and frontend so they connect. How to log in and then see the changes in the mod panel on the frontend.

LGTM but @ProgressChris88 and @ShizuokaTerrier are also taking a look at it and following the steps to confirm that they work.

Followed the steps and successfully logged into the mod dashboard in dev.
Note: For anyone using nvm for the first time, it might take a long time to install and look like a clip from the matrix while doing so.

Followed the steps and had no issues. There could possibly be confusion when logging into Firebase CLI for the first time through their error report system. Maybe we could just mention that logging into Fireblase CLI for the first time will prompt you to login and you can login through your Google account for example.

Followed the steps and had no issues. There could possibly be confusion when logging into Firebase CLI for the first time through their error report system. Maybe we could just mention that logging into Fireblase CLI for the first time will prompt you to login and you can login through your Google account for example.

@ProgressChris88 I will make a ticket for this on the backend README as I think it was part of that one you were linked to.

This will need approval from @ermish to be merged since he requested changes.


har generated from chrome produces: "Missing request method (24)"

        "request": {
          "method": "",
          "url": "ws://localhost:2992/sockjs-node/248/gp0g1n1n/websocket",
          "httpVersion": "",
          "headers": [],
          "queryString": [],
          "cookies": [],
          "headersSize": -1,
          "bodySize": 0
        },

Thank you for reporting the issue. There is currently no support for compiling "websocket requests" (Yet).
I'm adding a Type: Improvement label 👍

Closing this issue in favor of https://github.com/loadimpact/har-to-k6/issues/47. We will look into adding WS support in the future 👍

@legander would it not make sense for now to output a warning that a specific URL has no method and skip generating the code for the websocket as its not supported yet?

@BradErz That is a good idea, I will add a reference to your suggestion in #47 👍


[Feature] Inject cluster name as an environment variable into head and worker pods

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
The cluster name should be easily available from inside Kubernetes pods inside the cluster. An env var would be more convenient than e.g. a Ray API call, so that this would be available both from inside Python and from e.g. bash scripts.
Use case
I'd like to use the cluster name for namespacing extra information I'll be storing in an external Redis.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

@Yicheng-Lu-llll are you interested in this issue?

Sure

Hi @JoshKarpel.  I would like to double-check if this is what you want.
In the head or worker pod:

Oh, I think maybe that isn't what I meant, though that looks useful too. What I was thinking of was the same name that ends up getting used in keys for GCS Fault Tolerance with Redis, which is presumably uniquely generated across different instances of the cluster during e.g. a rolling deploy.

Oh, I think maybe that isn't what I meant, though that looks useful too. What I was thinking of was the same name that ends up getting used in keys for GCS Fault Tolerance with Redis, which is presumably uniquely generated across different instances of the cluster during e.g. a rolling deploy.

So, It is not the ray cluster name defined in ray cluster CR but the Redis's key?
I wonder if you could give me an example so that I can better understand what env var you want.

I get your idea, thank you for explaining!  https://github.com/ray-project/kuberay/pull/934 actually meet your need.
In your case, rayservice name is rayservice-sample. raycluster name is rayservice-sample-raycluster-svl4r.
In my previous example, I use raycluster directly while in your case, you use rayservice.
So, in my PR, After running  kubectl apply -f config/samples/ray_v1alpha1_rayservice.yaml:

You can get the a unique, cluster-global, cluster-instance-unique string  from env var CLUSTER_NAME

D'oh! I get it! That is indeed exactly what I need. Thanks for bearing with me!


Include exception when no server is found

Recently we found an issue when the log No server found for request was printed. This log implies there is an exception that don't let us find servers to query, but the exception is not printed.
This PR modifies the log to include a the first exception found. In case more than exception is affecting the system, we only log the first one, but we include the total number of exceptions in the log.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (50935d2).
Report is 1500 commits behind head on master.

:exclamation:  There is a different number of reports uploaded between BASE (59551e4) and HEAD (50935d2). Click for more details.
HEAD has 53 uploads less than BASE

Flag
BASE (59551e4)
HEAD (50935d2)

integration
7
1

integration2
3
1

temurin
12
1

java-21
7
1

skip-bytebuffers-true
3
0

skip-bytebuffers-false
7
1

unittests
5
0

unittests1
2
0

java-11
5
0

unittests2
3
0

integration1
2
0

custom-integration1
2
0

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #14709       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436        3     -2433
  Lines        133233        6   -133227
  Branches      20636        0    -20636
=============================================
- Hits          82274        0    -82274
+ Misses        44911        6    -44905
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Scope doesn't display nodes that have not had the scope command run directly on them.

Submitter: jacob Gadikian
Email<EMAIL_ADDRESS>Scope doesn't display nodes that have not had the scope command run directly on them.

Hi @faddat; thats the case I'm afraid - Scope needs to be running on the machine to monitor that machine.  This is mentioned a bunch of times in the readme.


Please uninstall the 32-bit version of Code while installing this 64-bit version.

I uninstall Visual Code to installl 64-bit version of Visual Code, but it pops up a window with the conent of "Please uninstall the 32-bit version of Code while installing this 64-bit version."

VSCode Version: forgot
OS Version: Windows 7

Steps to Reproduce:

uninstall 32-bit version of Visual Code
install VSCodeSetup-x64-1.17.2.exe or reboot and install it

You can try reinstalling 32, uninstalling it and then install 64.


Side bar menu link highlight not working

I am using
"@coreui/angular": "^2.2.0",
    "@coreui/coreui-pro": "^2.1.3",

and in side menu the currently selected menu item is not highlighted.
IOT Disc Agreement should be highlighted. but not working

When I debug that I found the active class is getting removed.

 class="ng-star-inserted nav-link"
and the above code is blinking.
Please help. it's causing the problem of Highlight Menu Item and something like system slow.

@all any update on this??


[FluentTheme] Addition of ColorPaletteResources and automatic system accent resource colors

What does the pull request do?
Status: API is ready but doesn't work properly because of another static resources bug.
TBD, going to write a full documentation here, which will be reused in the actual docs page later.
<FluentTheme>
  <FluentTheme.Palettes>
    <!-- redefines all colors of the Fluent Light variant -->
    <ColorPaletteResources x:Key="Light"
                           Accent="#FF34854D" AltHigh="#FFFFFFFF" AltLow="#FFFFFFFF"
                           AltMedium="#FFFFFFFF" AltMediumHigh="#FFFFFFFF" AltMediumLow="#FFFFFFFF"
                           BaseHigh="#FF000000" BaseLow="#FFC2DB65" BaseMedium="#FF7D9728" BaseMediumHigh="#FF4F6A00"
                           BaseMediumLow="#FF668114" ChromeAltLow="#FF4F6A00" ChromeBlackHigh="#FF000000"
                           ChromeBlackLow="#FFC2DB65" ChromeBlackMedium="#FF4F6A00" ChromeBlackMediumLow="#FF7D9728"
                           ChromeDisabledHigh="#FFC2DB65" ChromeDisabledLow="#FF7D9728" ChromeGray="#FF668114"
                           ChromeHigh="#FFC2DB65" ChromeLow="#FFE6F3BB" ChromeMedium="#FFDFEEAA"
                           ChromeMediumLow="#FFE6F3BB" ChromeWhite="#FFFFFFFF" ListLow="#FFDFEEAA"
                           ListMedium="#FFC2DB65" />
    <!-- will use default values for other coloors -->
    <ColorPaletteResources x:Key="Dark"
                           Accent="#FF34854D" />
  </FluentTheme.Palettes>
</FluentTheme>

Yes, it is compatible with output of Fluent XAML Theme Editor, if anybody remembers it (store link). With some minor edits like xmlns removal. Also in Avalonia ColorPaletteResources can be used only on FluentTheme.Palettes (i.e. globally), avoiding bugs like UWP has, when users attempt to use it in the middle of the visual tree.
What is the current behavior?
There is no easy way to redefine some base colors of the FluentTheme.
FluentTheme still uses hardcoded blue accent color (we have low level API already and it was used in the ControlCatalog for a while, but this PR moves this code to the FluentTheme package).
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
Internal structure of FluentTheme was once again changed. But hopefully nobody will need to use it directly anymore (unless some extremely special cases).
Fixed issues
TBD

And no, I am not considering adding anything like this to the SimpleTheme.
We can potentially have a special dictionary for the highlight colors there (equivalent of accent colors in fluent).
But I am going to leave it to the community, if anybody needs it.
ColorPaletteResources probably is useless there, as simple theme has a very little number of resources to override.

If the ColorPaletteResources is specific to FluentTheme, wouldn't it make sense to call it FluentColorPaletteResources? So it is clear for which Theme it is and other theme libraries could follow a similar naming scheme if they wanted to.

My theme library (semi avalonia) is a good example of independent theme. How would I use this mechanism? What would happen if someone wants to switch from fluent to semi?

How would I use this mechanism?

I'm not the author but I expect it would be best to copy the code into your theme for the moment. I suspect it may be something we want to expose as a general-purpose public API at some point, but I imagine we'd want to spend some time tweaking it as part of the fluent theme for a while first.

@grokys sorry I misunderstood this PR. It is reasonable to have this specific to fluent theme class.


Add support for filesystem based routing

Is your feature request related to a problem? Please describe.
A client-side routing definition has several disadvantages:

There are multiple ways of defining routes

Difficult to document
Different across projects
We can't easily read it on the server to provide appropriate HTTP codes

Users have to define access control twice: in the client-side routing file and in the Spring Security config
It's difficult to support web crawlers with appropriate metadata on the first request
Having a separate route definition file is boilerplate

Describe the solution you'd like
I would like us to explore having a filesystem path-based routing solution similar to NextJS and other full-stack frameworks.
Additional context
At least these issues would be simplified by having the file system routing:

Building hybrid applications
Returning appropriate HTTP response codes for missing content
SEO stuff like having appropriate metadata and title in the initial response
Server-side rendering
Users would not have to do access control to views separately in the client and Spring Security config

Some notes off the top of my head based on a recent discussion:

One particular challenge in our case is that routes are associated with view implementations in TS files whereas the metadata (e.g. access control configuration) is mostly needed by server-side Java.

Could run a TS parser from Java
Could use a neutral format (e.g. a JSON file) for the metadata at the expense of losing the direct association with the TS file implementing the view
Could make the TS build export metadata in a Java-friendly format (e.g. JSON) - might be problematic for development mode that is based on incremental builds
Could maybe rely on a 1:1 mapping between typical endpoint classes and views. In this way, the metadata could be picked up from the endpoint class - if you already have access control on an endpoint that is used by only a single view, then that view would probably have the same access rules as the endpoint.

There's an opportunity to use a view interface similar to HasUrlParameter in Flow. In this way, the view could implement the interface and automatically get URL parameter values in a typesafe way. The same interface could also be used for navigating to a view so that parameters of the appropriate types are passed to the view.


Add a proposal for count(where:)

This is a proposal for count(where:).
Pitch thread: https://forums.swift.org/t/count-where-on-sequence/11186
Recommended implementation: https://github.com/apple/swift/pull/16099

Just double checking on the status of this! Anything else I can do to push it forward?

This review is going to be scheduled for the week of August 6.

That sounds great. Thanks for heads up, Ted!

Why not use reduce to count things?

Scheduled for review August 6 - 12, 2018

Now AKA SE-0220


SCFilePlanPropertyReferenceId

Pull Request (PR) description
Initial Release
This Pull Request (PR) fixes the following issues
N/A

This change is

Codecov Report

Merging #242 into Dev will increase coverage by 0.11%.
The diff coverage is 98.18%.

@@            Coverage Diff            @@
##              Dev    #242      +/-   ##
=========================================
+ Coverage   87.38%   87.5%   +0.11%
=========================================
  Files          55      56       +1
  Lines        5210    5265      +55
  Branches       10      10
=========================================
+ Hits         4553    4607      +54
- Misses        647     648       +1
  Partials       10      10

Impacted Files
Coverage Δ

...eferenceId/MSFT_SCFilePlanPropertyReferenceId.psm1
98.18% <98.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5639f04...9cb0a2a. Read the comment docs.

@ykuijs for review

@ThorstenLoeschmann up for a code review?


Fixed the new path

there were some double entries after i changed the path to include /analytics/ . This pull fixes that and changes the method for loading configurations.

Looks good


adding rosdep tutorial

@jacobperron @clalancette done

/* cough *
This ready to merge?

@clalancette Want me to write one on bloom for idiots? I commonly distribute https://gist.github.com/SteveMacenski/1c321d1c9edca096ae4d763d8327c2ee to folks that ask about it. Its definitely not exhaustive, but its more or less what I do and its the minimal needed for users to do it and follow decent practice.
As good as https://github.com/ros2/ros2_documentation/pull/2375 is, its alot more than is typically required and I've had ROS novices use my guide and not come back with any additional questions

As good as https://github.com/ros2/ros2_documentation/pull/2375 is, its alot more than is typically required and I've had ROS novices use my guide and not come back with any additional questions. Most people releasing don't need to release a 3rd party package, use ros2-gbp or most of that non-sense, they just want to know how to get something they built out there.
That guide is honestly so complicated and detailed that if I were trying to release something and that was the documentation, I probably wouldn't bother. There's realistically only a few things folks need to know.

I totally agree with your points here, we should have the case that covers 90% of user cases in the ros2 docs, and have a link to bloom readthedocs that should cover every option in more detail.


Change all the icons and logos to the latest version

The perfect one with the rounded corners.
The favicon is wrong.

@ricburton is this the latest version of favicon? https://walletconnect.org/favicon.ico


Carry v0.4.3 master bump

Carries patches from v0.4.3 back to master - the delegation key import panic fix and netgo flag for server flag panic.
There was some messiness because of repeat lint commits that already made it to master, so I removed those in this PR.

@riyazdf can you rebase then assuming tests pass we're good to merge.

green after rebase!  Merging.


Fix a bug in moving interaction from full position

The floating panel must work well when it's moving from full position even if the tracking scroll view's
content offset isn't the top.
Ref #30

I merged this to master for @ffittschen work,


remove overuse of with lib in pythonPackages.textblob

Adapts the later changes suggested on init PR (#334134 )
@dotlambda @FliegendeWurst
Thank you!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Imma, re-pull and push. Some history got messed up.


Cannot add an account outside the init method

Hi,
I'm trying to use the account section to implement a sing in, but when I get the result code from the login activity, I'm not able to add an account to the navigation drawer. I can do it if a manually insert an account in the init method.
This is what I'm doing right now:
    @Override
    public void onAccountOpening(MaterialAccount materialAccount) {
        if (materialAccount == null) {
            Intent intentLogin = new Intent(getApplicationContext(), LoginActivity.class);
            startActivityForResult(intentLogin, RESULT_LOGIN_SUCCESS);
        }
        else {
            Toast.makeText(getApplicationContext(), "Current account is " + materialAccount.getTitle(), Toast.LENGTH_SHORT).show();
        }
    }

    @Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        if (resultCode == RESULT_LOGIN_SUCCESS) {
            MaterialAccount materialAccount = new MaterialAccount("Elovendo","account@elovendo.com",this.getResources().getDrawable(R.drawable.home),this.getResources().getDrawable(R.drawable.nav_drawer_background));
            this.addAccount(materialAccount);
        } else {
            Toast.makeText(getApplicationContext(), "Not signed in", Toast.LENGTH_SHORT).show();
        }
    }

Don't know if I'm missing something or this is not currently supported yet.
Thank you for your fantastic work ;)

@qgadrian  please try to add the notifyAccountDataChanged(); after this.addAccount()

Hi @neokree  still not working, fails at notifyAccountDataChanged(). Here is the full stacktrace:
java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=1, result=1, data=null} to activity {com.elovendo/com.elovendo.ElovendoMain}: java.lang.NullPointerException
at android.app.ActivityThread.deliverResults(ActivityThread.java:3365)
at android.app.ActivityThread.handleSendResult(ActivityThread.java:3408)
at android.app.ActivityThread.access$1300(ActivityThread.java:135)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1244)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:136)
at android.app.ActivityThread.main(ActivityThread.java:5017)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NullPointerException
at it.neokree.materialnavigationdrawer.MaterialNavigationDrawer.notifyAccountDataChanged(MaterialNavigationDrawer.java:1005)
at com.elovendo.ElovendoMain.onActivityResult(ElovendoMain.java:336)
at android.app.Activity.dispatchActivityResult(Activity.java:5423)
at android.app.ActivityThread.deliverResults(ActivityThread.java:3361)
            at android.app.ActivityThread.handleSendResult(ActivityThread.java:3408)
            at android.app.ActivityThread.access$1300(ActivityThread.java:135)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1244)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:136)
            at android.app.ActivityThread.main(ActivityThread.java:5017)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
            at dalvik.system.NativeStart.main(Native Method)
I noticed a few problems. Now there is no click event on the drawer header (onAccountOpening(MaterialAccount materialAccount) ). Also, it's not clear that which type of drawerType is needed for an image and account, I guess should be <item name="drawerType">@integer/DRAWERTYPE_ACCOUNTS</item> but in the wiki it's not reference to this.

sorry but I don't catch how your activity is still visible if you add the account into the
onActivityResult(). That should be used when the activity is gone, and it returns back his work. So adding the account when the activity will be destroyed is useless.
The accounts drawer type is the default, so you don't have to declare anything to your theme.

This was just an example. intentLogin sends back the user information, but I was only catching the result code and testing how should be adding an account, just for testing.
Anyway, I changed it for using with a fragment, but still throws the same error. I tried to create the MaterialAccount in fragment, and set it to the drawer thru onChangeAccount(MaterialAccount materialAccount), but still same result...

Well, Basicly in a real situation an account will be setted asyncronously, when the user send back the informations you need to add the account information.
For emulate it, I used an asynctask that will add an account after 5 seconds and then update his content.
public class NavigationDrawerTest extends MaterialNavigationDrawer implements MaterialAccountListener, MaterialSectionListener {

    MaterialAccount account;
    MaterialSection section1, section2, section3, section4, section5, section6, recorder, night, last, settingsSection;

    @Override
    public void init(Bundle savedInstanceState) {

        this.allowArrowAnimation();
        // add first account

        account = new MaterialAccount(this.getResources(),"Hello " + getUsername(), "", null, R.drawable.mat2);
        this.addAccount(account);

        // set listener
        this.setAccountListener(this);

        // create sections
        section1 = this.newSection("String1", new FragmentIndex());
        section2 = this.newSection("String2", new FragmentIndex());
        section3 = this.newSection("Help", new FragmentIndex());
        section4 = this.newSection("Send Feedback", new FragmentIndex());
        section5 = this.newSection("Rate our app", new FragmentIndex());
        section6 = this.newSection("About", new FragmentIndex());

        Intent i = null;
        settingsSection = this.newSection("Settings", this.getResources().getDrawable(R.drawable.ic_settings_black_24dp), i);

        // add your sections to the drawer
        this.addSubheader("Header1");
        this.addSection(section1);
        this.addSection(section2);

        this.addSubheader("General");
        this.addSection(section3);
        this.addSection(section4);
        this.addSection(section5);
        this.addSection(section6);

        this.addBottomSection(settingsSection);

        this.addMultiPaneSupport();

        t.start();
    }

    private String getUsername() {
        return "Username";
    }

    @Override
    public void onAccountOpening(MaterialAccount account) {

    }

    @Override
    public void onChangeAccount(MaterialAccount newAccount) {

    }

    // after 5 second (async task loading photo from website) change user photo
    Thread t = new Thread(new Runnable() {
        @Override
        public void run() {
            try {
                Thread.sleep(5000);

                runOnUiThread(new Runnable() {
                    @Override
                    public void run() {
                        MaterialAccount account = new MaterialAccount(getResources(),"Hello " + getUsername(), "", R.drawable.photo2, R.drawable.mat2);
                        addAccount(account);
                        notifyAccountDataChanged();
                        Toast.makeText(getApplicationContext(), "Added 'from web' account", Toast.LENGTH_SHORT).show();
                    }
                });

            } catch (InterruptedException e) {
                e.printStackTrace();
            }
        }
    });
}

NOTE: this code use the dev version of this library, that you could find into gihub.

But in a real situation, you also need to get user input for login/password. That's my point, you need a Fragment to get that user input, and you need to pass it to the drawer in order to add the a new account with the user info.
A workaround is create an "empty" account on init(), and "update" it when a successful login.

Or you can set a base account with sample images like youtube app, then when the user is logged in you need only to change the informations.
However, if the user is obligatory for your app I suggest you to move your sign in/sign up form outside the navigation drawer, like the email app.

check the new library version, 1.3.2


Changing the default storage provider?

Environmental Info:
K3s Version:  v1.21.0+k3s1
Node(s) CPU architecture, OS, and Version:
5.8.0-1021-raspi #24-Ubuntu SMP PREEMPT Tue Apr 13 11:00:57 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux
Cluster Configuration:
3 servers in HA
Describe the bug:
Local-path storage-class always reverts to being the default provisioner.
Steps To Reproduce:

Add a second storage-class (in my case the NFS client provisoner)
Set that storage-class as the default
Restart a node
Local-path storage-class is now also the default storage class, giving us 2 default storage classes

Expected behavior:
Local-path should not be the default storage on reboot
Actual behavior:
Two local storage classes, the new storage class and the defualt shipped class.

The source of truth seems to be /var/lib/rancher/k3s/server/manifests/local-storage.yaml (https://github.com/k3s-io/k3s/blob/02a5bee62f5d7a0811a6a9401fc9ff5b1399c0bc/manifests/local-storage.yaml#L91) which is re-applied on every reboot of k3s. Looks like you can change the default there.
Unfortunately, this component is not deployed as a helm chart. Otherwise I would point you to the documentation of HelmChartConfig: https://rancher.com/docs/k3s/latest/en/helm/#customizing-packaged-components-with-helmchartconfig

A better option may be to install K3s using --disable local-storage. You can then install the local-storage provider by using a Helm chart if you still need it: https://github.com/rancher/local-path-provisioner/blob/01eaa8c41a31796581b707a00418eaae7369d3aa/deploy/chart/README.md#installing-the-chart

Yes, --disable local-storage is the best way to do this. If you want to still use local-storage, you can copy and customize /var/lib/rancher/k3s/server/manifests/local-storage.yaml into something with a unique name before disabling the built-in local-storage component.


MM-17023: Plugin Marketplace

Summary
Merging the feature branch for the plugins marketplace MVP.
Ticket Link
https://mattermost.atlassian.net/browse/MM-17023
Test Information
This PR was tested on: Chrome

Thanks for offering to help out, @jwilander!


Enable tests

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: rogeralsing:x: Roger JohanssonRoger Johansson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Site selector displaying HTML entities on the Flagging Preferences page

It shouldn't display the raw HTML entities

The page in the screenshot above is New flagging preference. However, I'd expect this to happen on all of the site selection dropdowns.


Reconsider usage of bigint in generated JS code

Summary
#3164 set the precedent that WBG should not emit bigint literals in generated JS code, and I wanted to ask whether this could be reconsidered and #3164 be reverted.
I'm asking for this, because (1) this is a blocker for #4222 in its current form, and (2) #3164 didn't actually solve anything.
What #3164 tried to achieve
The motivation behind #3164 was to solve a specific esbuild error. Here's the error:
[vite:esbuild-transpile] Transform failed with 1 error:
assets/index.baa0f021.js:431:63: ERROR: Big integer literals are not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari13" + 2 overrides)

Big integer literals are not available in the configured target environment ("chrome87", "edge88", "es2020", "firefox78", "safari13" + 2 overrides)
429|          const v = getObject(arg1);
430|          const ret = typeof(v) === 'bigint' ? v : undefined;
431|          getBigInt64Memory0()[arg0 / 8 + 1] = isLikeNone(ret) ? 0n : ret;
   |                                                                 ^
432|          getInt32Memory0()[arg0 / 4 + 0] = !isLikeNone(ret);
433|      };

This error means that esbuild wasn't able to convert the generated JS code of WBG into JS code supported by all configured target environments. In particular, safari 13 doesn't support bigint. So esbuild correctly errors out, as it cannot fulfill the request to support bigints (specifically bigint literals) in safari 13.
The "solution" #3164 implemented was to replace the bigint literal 0n with BigInt(0), so the constant is created at runtime instead. BigInt(0) is simple JS and so the transpiler doesn't need to do anything and so won't error.
However, the approach taken in #3164 does nothing to fix the compatibility issue. Even BigInt(0) isn't supported in safari 13. The example function in the issue will still not work in safari 13. The only thing that changed is that this compatibility problem is no longer detected by esbuild. #3164 did not fix the underlying issue, it hid it. Even the other code example given in #3164 doesn't work on safari 13, it's just that esbuild didn't detect that and so didn't emit an error.
There's also no point in emitting BigInt(value) for older browsers, because it will always fail at runtime or (if polyfilled) be unusable. As the author of esbuild explains in this issue, polyfilling bigint is pretty much impossible. And even if you somehow hack together a spotty polyfill, it wouldn't help. The WebAssembly JS API uses bigint for i64, and a polyfill wouldn't be compatible with that.
So all #3164 did was to make esbuild misrepresent which target environments are actually supported.
IMO, users that encounter this error should either:

Suppress the error.
Don't use anything in their wasm API that requires bigint.
Accept that they cannot support certain older browsers and adjust their target environment accordingly.

If users still insist on not using bigint literals, then I think they should use a transpiler for that. 64-bit integer types require bigint, and I don't think it's WBG's job to hide this fact.
Why this blocks support for u128 (#4222)
To support u128 with the ABI implemented in #4222 (pass one u128 as two u64), we need to perform bit-shifts on bigints. This operation is impossible to polyfill, so #4222 requires that bigint be supported.
However, #3164 sets the precedent that bigint doesn't need to be supported. The only ABI for u128 that would be compatible with a hypothetical bigint polyfill is the same ABI as js_sys::BitInt: a string of decimal digits. For performance reasons, I would like to avoid this.
ES version policy
Similar to a MSRV, it would probably be a good idea to have a similar policy for ES versions. Right now, I'm not sure which features I am allowed to use in generated JS code.
We extensively use ES2015 features, so I would assume that the minimum supported ES version is at least ES2015. However, we also use bigints which are ES2020, but we also apparently don't target ES2020 because of #3164. So what ES version do we target?

I think the desire was to make an application only fail at runtime so if the usage of BigInt is avoided, during runtime, the rest of the application can run just fine. This is probably a quite questionable approach, but it has already been done this way.
Do we actually need BigInt literal support? Can't we continue to use constructors? Eventually we can move on to literals with the next breaking change, unless we find good reasoning for the argument above.

ES version policy
Similar to a MSRV, it would probably be a good idea to have a similar policy for ES versions. Right now, I'm not sure which features I am allowed to use in generated JS code.
We extensively use ES2015 features, so I would assume that the minimum supported ES version is at least ES2015. However, we also use bigints which are ES2020, but we also apparently don't target ES2020 because of #3164. So what ES version do we target?

I agree that a policy around this should be established. Unfortunately I have no idea where we stand or what we should do about this. A more informed opinion from somebody actually knowledgeable about JS/TS and the ecosystem would be much appreciated.

I think the desire was to make an application only fail at runtime so if the usage of BigInt is avoided, during runtime, the rest of the application can run just fine.

That might be the case. I did some digging to find how how Safari 13 even supports the WebAssembly JS API when it doesn't support bigint. The answer is that an old version of the JS API spec (wayback) just doesn't support i64. If you try calling a WASM function that uses i64 anyway, you get a runtime error. The release notes of Safari 14.1 (the version that added bigint) also mention something in that regard.
Note that this only affects the JS API of WebAssembly. You can use i64 internally just fine and even import/export functions that use it. You just can't call any function that use i64.

This is probably a quite questionable approach, but it has already been done this way.

On a related note, this also means that changing the WASM ABI of any type to use i64/u64 is a breaking change. Good thing we went with f64 in #4183...

I agree that a policy around this should be established. Unfortunately I have no idea where we stand or what we should do about this.

Maybe we could start by documenting which browser versions are supported? The browser support page doesn't say. Going back to safari, they added wasm support in Safari 11 (released Sep 2017), but thanks to sign-ext being a default feature, WBG mostly just supports Safari >=14.1 (released Apr 2021). Recently, Rust enabled multivalue and reference-types by default too, and reference-types are supported started Safari 15 (released Sep 2021).
Luckily, there's this handy page, so we "just" have to pick out what's relevant to WBG. Knowing exactly what browsers we currently support would probably also be good to know to inform such a policy.

reference-types are supported started Safari 15

Not trying to hijack this issue, but worth noting despite claimed support Safari 15 has issues with reference-types, at least as it relates to using the wgpu backend of Ruffle, which results in this error message:
RuntimeError: Out of bounds table access (evaluating 'b._dyn_core__ops__function__FnMut__A____Output___R_as_wasm_bindgen__closure__WasmClosure___describe__invoke__h281f2f93d3d6cf28(n,e,t)')

I think the desire was to make an application only fail at runtime so if the usage of BigInt is avoided, during runtime, the rest of the application can run just fine.

That might be the case. I did some digging to find how how Safari 13 even supports the WebAssembly JS API when it doesn't support bigint. The answer is that an old version of the JS API spec (wayback) just doesn't support i64. If you try calling a WASM function that uses i64 anyway, you get a runtime error. The release notes of Safari 14.1 (the version that added bigint) also mention something in that regard.
Note that this only affects the JS API of WebAssembly. You can use i64 internally just fine and even import/export functions that use it. You just can't call any function that use i64.

This isn't part of Wasm v1.0, its a proposal called "JS BigInt to Wasm i64 Integration". You can find it on the Wasm feature page as well.

This is probably a quite questionable approach, but it has already been done this way.

On a related note, this also means that changing the WASM ABI of any type to use i64/u64 is a breaking change. Good thing we went with f64 in #4183...

Uff, true!

I agree that a policy around this should be established. Unfortunately I have no idea where we stand or what we should do about this.

Maybe we could start by documenting which browser versions are supported? The browser support page doesn't say. Going back to safari, they added wasm support in Safari 11 (released Sep 2017), but thanks to sign-ext being a default feature, WBG mostly just supports Safari >=14.1 (released Apr 2021). Recently, Rust enabled multivalue and reference-types by default too, and reference-types are supported started Safari 15 (released Sep 2021).
Luckily, there's this handy page, so we "just" have to pick out what's relevant to WBG. Knowing exactly what browsers we currently support would probably also be good to know to inform such a policy.

We shouldn't confuse wasm-bindgen with Rust though, we do have an MSRV of v1.57 after all. Not to mention the new wasmv1-none target should alleviate most of these issues (when it comes out in Rust v1.84).

reference-types are supported started Safari 15

Not trying to hijack this issue, but worth noting despite claimed support Safari 15 has issues with reference-types, at least as it relates to using the wgpu backend of Ruffle, which results in this error message:
RuntimeError: Out of bounds table access (evaluating 'b._dyn_core__ops__function__FnMut__A____Output___R_as_wasm_bindgen__closure__WasmClosure___describe__invoke__h281f2f93d3d6cf28(n,e,t)')

Indeed, Safari's v15 implementation of the reference type proposal was faulty (don't remember the details), we should pretend that support was added in Safari v16.

Okay, so taking this all together: For documentation, we need one table that explains which stable Rust versions with the target wasm32-unknown-unknown map to which features being enabled by default and another for the browser support of each (important) target feature. Did I get that right?
We might have to amend the Rust table in the future for other target and nightly tricks, but at least the target feature browser support table should be rather unchanging.

This isn't part of Wasm v1.0, its a proposal called "JS BigInt to Wasm i64 Integration". You can find it on the Wasm feature page as well.

I think proposals that are purely about the JS API raise an interesting issue regarding browser support. What #3164 established is essentially partial browser support.
From my understanding, things like target feature (e.g. simd128) are a lot more cut and dry. AFAIK, if you try to WebAssembly.compile a WASM file with unsupported instructions, compilation just fails, meaning that the JS fail fails to load properly. So if you use it, your whole package doesn't support the browser/runtime anymore. It's all or nothing.
The question is: should this "all or nothing" mantra for supporting certain browser versions apply to all WASM features, or should we support partial browser support?
On that note: are there other JS-API-focused WASM features for which partial support would also apply? I quickly scanned through the list of features, but couldn't find anything that sounded like it.

Okay, so taking this all together: For documentation, we need one table that explains which stable Rust versions with the target wasm32-unknown-unknown map to which features being enabled by default and another for the browser support of each (important) target feature. Did I get that right?
We might have to amend the Rust table in the future for other target and nightly tricks, but at least the target feature browser support table should be rather unchanging.

What should actually be required of us is to specify which browsers we support considering no target features are enabled and note that we don't control what target features are enabled by the Rust compiler and it does already enable some target features by default.
Anything more, including what you wrote, would be very appreciated, but isn't absolutely necessary.

The question is: should this "all or nothing" mantra for supporting certain browser versions apply to all WASM features, or should we support partial browser support?

I would like to see some substantial use-case for partial browser support, otherwise I remain unconvinced. But its already here, so we can only change it with the next breaking change.
There are some cases where this is required however, e.g. WBG does some TextDe/Encoder shenanigans to support Strings, but it has some built-in detection where it fails during runtime if TextDe/Encoder is not available. Mainly this is done to support Worklets. There might be more things like this in the future.

On that note: are there other JS-API-focused WASM features for which partial support would also apply? I quickly scanned through the list of features, but couldn't find anything that sounded like it.

I'm not aware of one.


OBS studio problem in RDP

Failed to open NVEMC codec when trying to stream.

Colab uses custom Linux based on Ubuntu, which has some library issues. I will see in your matter and update you accordingly.

Colab uses custom Linux based on Ubuntu, which has some library issues. I will see in your matter and update you accordingly.

Any progress?

Cause and tried solutions
I tried some solutions, but they result in errors. The NVENC Codec is causing a problem. I tried to install it, upgrade it or build from source, but every time it fails.

Try some on your own:

Fix 1: not working
Fix 2: not tried yet (it takes time to build packages)

So there is a fix, not sure you like it

Take a GPU Runtime in Colab (To get it, click on: runtime > change runtime type > GPU)
Install obs into the machine
Open Settings of OBS and change the encoder to software encoder

I tried it and its working.

Cause and tried solutions
I tried some solutions, but they result in errors. The NVENC Codec is causing a problem. I tried to install it, upgrade it or build from source, but every time it fails.

Try some on your own:

Fix 1: not working
Fix 2: not tried yet (it takes time to build packages)

So there is a fix, not sure you like it

Take a GPU Runtime in Colab (To get it, click on: runtime > change runtime type > GPU)
Install obs into the machine
Open Settings of OBS and change the encoder to software encoder

I tried it and its working.

I have been using software encoder but it cant take much load. I am not being able to stream in 1080p it says consider using hardware encoder.

I have been using software encoder but it cant take much load. I am not being able to stream in 1080p it says consider using hardware encoder.

As you know Google Colab has its own limits or even Cloud VM has limits.

this is same problem with ffmpeg, since obs uses ffmpeg, ffmpeg requires nvidia driver v455 in order to use GPU power, while google uses nvidia driver v418 (use nvidia-smi on terminal)
that's why it doesn't work. and no you can't update driver since drivers aren't installed into your colab at the first place,
these are docker containers, and with that way drivers are installed into the HOST and SHARED but NOT installed with Containers (the colab we create for free)
So there's no solution for this unless you contact google tell them to update nvidia drivers to v455 and they agree.

to fix it install the ffmpeg program in in the colab package installer it has to be apt install and on the middle one which says package name type ffmpeg

to fix it install the ffmpeg program in in the colab package installer it has to be apt install and on the middle one which says package name type ffmpeg for more info https://obsproject.com/wiki/install-instructions#linux

did you test this by yourself?

to fix it install the ffmpeg program in in the colab package installer it has to be apt install and on the middle one which says package name type ffmpeg for more info https://obsproject.com/wiki/install-instructions#linux

did you test this by yourself?

yes i had that issue two

Can we change the operating System to Windows server.I think after changing the operating system.All error has removed.I want to contribute and i have another project and i need your help too.so kindly contact me.I was unable to contact you.
<EMAIL_ADDRESS>

you won't be able to use obs for this. but you can use vokoscreen which worked perfectly fine for me. the thing is i think you can't use voko to stream which is a red flag.

@Vishesh987 when you buy colab pro they offer gpu so you can stream in 1080p. cost of colab pro is 10 dollor per month


Order Notifications on facebook

I appreciate your work, I have a feature request it would be great if you add feature that can send order notifications direct on messenger. notifications such as order shipment,  when order status change, invoice update etc.

@blopa Thanks a bunch and keep up the good work!

Hello @bloggerpact.
That is a good idea for a feature, indeed. Is that from a existing module? Can you share it?

Yes, this is an existing module, but it is a subscription-based has lot of features like answering each message and commen but would be great if you include only notifications related with orders  https://marketplace.magento.com/magetrend-mt-messenger.html @blopa

I can't promise you a date, but I'll work on that.

Thanks :+1: Will wait for this feature


Is it working with OpenCV 3.4 in Ubuntu?

Hi, Nice to see trhat this repo is updated recently.
Can I expect that this works with OpenCV 3.4 inside Ubuntu 16.04?
Have you tested this?
Thanks...

Yes, I think this samples works on Ubuntu. But, It is not tested yet.

Not, I am having this error with Ubuntu 18.04:
UVCVideoCapture::open ERROR: can't find device
terminate called after throwing an instance of '
cv::Exception
'
what():  OpenCV(3.4.4) /home/raub/code/opencv/modules/core/src/matrix_wrap.cpp:130: error: (-213:The function/feature is not implemented) Unknown/unsupported array type in function 'getMat_'


Option to open silently in background automatically at windows startup

technically I can set this to start at startup by placing shortcut in startup folder but whenever I log in on the first startup after shutdown or restart it open in text grab full screen and i have to click it away which is annoying.
so it should start silently in background on startup.

Same as #133 I plan on adding this functionality. First attempt will be similar to how it works here:
https://docs.microsoft.com/en-us/uwp/api/Windows.ApplicationModel.StartupTask?view=winrt-22000

Same as #133 I plan on adding this functionality
so how soon can I see this implemented?

Are you looking for the change in code, in the released EXE on the GitHub repo, or in the app from the Microsoft Store?

Initial commit here: https://github.com/TheJoeFin/Text-Grab/commit/317530c1b099361a3dce5a8061bac225e83f7771

[ ] Check for Startup Setting
[ ] Set Startup Setting in Settings Window
[ ] Investigate if there are new ways to do StartupTask with packaged desktop apps

Are you looking for the change in code, in the released EXE on the GitHub repo, or in the app from the Microsoft Store?

looking for changes in the app available on GitHub, haven't used the store app it's paid anyways

Unfortunately with Windows 10 the API used to set startup tasks is not compatible with the single unpackaged EXE distribution. I don't think there is a new API so this feature will be only available through the MSIX packaged app via the Microsoft Store.
I am still looking into this, but it could be a major roadblock for getting this feature released.

I understand.
But at least change it so that when I manually set the program to start using "startup" folder, it doesn't immediately go to full screen grab and just start SILENTLY without doing anything.
cause right now it just goes to automatically goes to full screen grab even when I open the app for the first time after shutdown/restart which is really annoying.
simple feature suggestion is -> when opening for first time after shutdown/restart WAIT for my keyboard shortcut to do anything; or show a GUI with all the things that are currently accessed via "settings" menu in taskbar.
I would prefer silent opening in background to a GUI (keyboard shortcuts are more efficient than a GUI interface)
so show this GUI interface on opening and do not go into screen grab by itself,

this I think is the least you could do to make UX a little better cause honestly that is the only drawback rn of the wonderful and fast app.

@shockproof22 please try pre-release 2.5.0 and see if that works well.

@shockproof22 please try pre-release 2.5.0 and see if that works well.

will do!


Resolve cloud foundry key issue

Context

Cannot install cloud foundry CLI
Because https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key seems to be blocking curl/wget requests

Changes

Cache the above key in version control and use this instead

Review notes

Note sure if they is a way to have global environment variables for all workflows which would reduce the duplication
But this will work for now
Please feedback if you have a more elegant solution to resolve this issue

closing in favour of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data/pull/1480


[QUERY] What does the visibilitytimeout mean in the Storage Queue

Library name and version
Azure.Storage.Queue
Query/Question
There are SDK APIs that use the visibilityTimeout like ReceiveMessage and SendMessage:
https://docs.microsoft.com/en-us/dotnet/api/azure.storage.queues.queueclient.receivemessageasync?view=azure-dotnet
https://docs.microsoft.com/en-us/dotnet/api/azure.storage.queues.queueclient.sendmessage?view=azure-dotnet
In the SendMessage, it says:

"Adds a new message to the back of a queue. The visibility timeout specifies how long the message should be invisible to Dequeue and Peek operations."

and the default value is 0, which means by default, the message can be immediately dequeued right?
However, for ReceiveMessage, the default value for visibilityTimeout is 30 seconds.

What does the visibilityTimeout mean here?
Is ReceiveMessage a dequeue operation? Or it just sets the queue message invisible? Will the queue message appear after the timeout?

Thanks!
Environment
No response

@rmt2021 Here are the answers to your questions

and the default value is 0, which means by default, the message can be immediately dequeued right?

Yes

However, for ReceiveMessage, the default value for visibilityTimeout is 30 seconds.
What does the visibilityTimeout mean here?

The new visibility timeout which makes the queue message invisible for some time (while it is being processed essentially) and would be made visible after this time.

Is ReceiveMessage a dequeue operation? Or it just sets the queue message invisible? Will the queue message appear after the timeout?

Yes, its a dequeue operation. The message will appear again after the visibility timeout if the message is not deleted or the visibility timeout isn't updated.
The SDK builds upon the underlying REST API. You can read more about he send and receive behaviors in their REST API reference docs as well.


Create a macro to ease the configuration of indexes

Description
It would be cool if we could somehow create a kind of builder macro but with the settings of Meilisearch.
Some settings do not apply here; you can't set your stopwords or synonyms from a document for example.
But anything related to a field should be handled without any issue I think :thinking:
Basic example
#[derive(Serialize, Deserialize, Document)]
struct Movie {
  #[document(primary_key)]
  movie_id: u64,
  #[document(displayed, searchable)]
  title: String,
  #[document(displayed)]
  description: String,
  #[document(filterable, sortable, displayed)]
  release_date: String,
  #[document(filterable, displayed)]
  genres: Vec<String>,
}

I'm not sure Document is the best name here.
This should generate something like that;
// this trait is not generated, it's just hanging somewhere in our crate
pub trait Document {
  fn generate_settings() -> Settings;
  async fn generate_index() -> Result<Index>;
}

impl Document for Movie {
  fn generate_settings() -> Settings {
    Settings::new()
        .with_displayed_attributes(["title", "description", "release_date", "genres"])
        .with_searchable_attributes(["title"])
        .with_filterable_attributes(["release_date", "genres"])
        .with_sortable_attributes(["release_date"])
  }

  async fn generate_index(client: &Client) -> Result<Index> {
    client.create_index("movie", Some("movie_id"))?
        .wait_for_completion(client)?
        .try_make_index(client)
  }
}

The macro should check as many errors as possible at compile time.
Like setting two primary keys or two distinct attributes.
I think that would be a great addition to the crate and make it way more accessible / easier to test.
Other
I don't think I'll have the time to work on this issue, so if someone else thinks it's a good addition and wants to implement it, please do not hesitate to ask questions when you're not sure about something!
Also, if you don't know anything about rust macros but would like to learn, you can start by following this workshop; https://github.com/dtolnay/proc-macro-workshop

I'll try this.

Could you point me to the Document trait mentioned in the description? I can see a mention in the lib.rs as well, but I'm unable to find its declaration in the code base. It's the only piece left in the implementation.

Hey @romilpunetha :) Document is a structure that you define yourself containing the structure of your documents!
For example
https://github.com/meilisearch/meilisearch-rust/blob/920cdd6975b243e37c934047e3d9f44cf212e0f8/src/search.rs#L399-L426
The mentioned lib is about the structures related to the documents API:
https://github.com/meilisearch/meilisearch-rust/blob/920cdd6975b243e37c934047e3d9f44cf212e0f8/src/documents.rs#L5-L20

I don't think I did a good job of explaining the problem. Let me try again:
// this trait is not generated, it's just hanging somewhere in our crate
pub trait Document {
  fn generate_settings() -> Settings;
  async fn generate_index() -> Result<Index>;
}

This part in the description of the issue states that a Document trait exists somewhere in the crates. I couldn't find the trait and the requirement is that this trait needs to be implemented for the structs with the macro. If this trait does not exist, I'll create it. If it does, I'm unable to locate it.
Or am I still missing something here?

I think, from what I understand of the issue, is that Document does not exist and should be created with a better name.
@irevoire can you clarify the situation?


horizontal scrollable component for contents

Description
I'd like to use horizontal scrollable contents component.
If material-ui has this component, it makes the capacity of developer's option larger, especially mobile design.
Images & references
https://jsfiddle.net/pp9quLey/1/

Do you have a reference to the Material Specification for this type of component?

@sottar Material UI strongly based on Google Material Design specification. Did you find any mention about horizontal scrollable contents in GMD?
I've found it on Grid lists:

Horizontally scrolling grid lists are discouraged because the scrolling interferes with typical reading patterns, affecting comprehension. One notable exception is a horizontally-scrolling, single-line grid list of images, such as a gallery, which is compatible with typical reading patterns.

One notable exception is a horizontally-scrolling, single-line grid list of images

This part sounds relevant @sottar, thanks for digging into it.
@sottar That sounds simple to implement on user side. Why the needs for creating a new component here?

@oliviertassinari I think for all that type questions the good answer will be adding the implementation to the docs. Maybe this can be done by requester, maybe not. But adding that into Demos reduce the number of issues like that. I believe.

Anyway, this shouldn't be new component. This might be an property for existed GridLists like onelined but not a new component.

Thanks @oliviertassinari  @ashl1
I didn't know one-line grid lists.
And good idea for add this type of property to demos.
So will I implement it into GridLists example?

@sottar Think you can open a PR about this. Think the behavior won't be changed in next branch, and because this will change only docs it can be merged not to wait next release, can it @oliviertassinari ?

@oliviertassinari @ashl1
Sent a PR #5300 with this change.


password protect only some routes

Hi,
I was wondering if it was possible to add a user/password request on some routes (not all).
Thanks.

This feature was added to the release 1.105. Please consult the Release Notes for more info.
I would appreciate if you could try it out and let me know if the current implementation matches your use-case.


[operation waitUntilFinished] not working

Hi, I'm using reskit inside my cocoapods library I have an example library where I reference my own library to make the call, so when I make the call from IOS example code I get empty result. This is my code.

I know that this is async but, if I use wait it should return the value, now is always empty

GitHub Issues is for reporting bugs in RestKit and discussing changes to RestKit itself. Please check the documentation, wiki, and existing issues before opening a new issue.
Additionally, please do not post general usage questions to Issues, but instead take them to Stack Overflow.


Exporting to single file breaks on timestamp change

System information:

Operating system (distribution) and version: Windows 10
DBeaver version: 6.3.0
Additional extensions: None

Connection specification:

Database name and version: MySQL 8.0.12
Driver name: MySQL 8+
Do you use tunnels or proxies (SSH, SOCKS, etc)?  No

Describe the problem you're observing:
"Write to the single file" in Export actually writes to multiple file when the timestamp in the filename changes, eg. minute change. There will be files like "export_201912031336.sql" and "export_201912031337.sql".
Expected to be one file with the start time as the filename.
Steps to reproduce, if exist:

Select some tables
Export Data

Select "SQL" format
Select "Write to the single file"
Set the filename to "${table}_${timestamp}"

When the clock reads 50+ seconds, press Start.

Thanks for the bug report

Fixed (time of data transfer process start will be used).
Additionally I've added configuration for timestamp pattern (you can use seconds/milliseconds there if you need).

Tables are still exported to a different files (try to begin export of several tables at 57 sec.)

One more fix added

Verified.


[MM-21923] Enforce channel mentions permission

Summary

Disables the confirmation dialog when sending a message with @channel or @all if user lacks the permissions
Hides the "Special Mentions" autocomplete when the user does not have the use_channel_mentions permission

Ticket Link
https://mattermost.atlassian.net/browse/MM-21923
Checklist

[x] Added unit tests for post_textbox @channel alert
[x] Minor redux changes to Permissions list
[x] Has UI changes

Device Information
This PR was tested on: IOS 11
Screenshots

What server version was this permission added?

The server PR is still in review https://github.com/mattermost/mattermost-server/pull/13781
I should have linked it here earlier, Will have to wait till that gets merged before we can really do anything with this and the redux one. I will ping you when this is actually testable.

That means that we need to check for the server version in order to check for the permission

thats a good call - I will address that before moving forward - thanks

Both redux and server changes have been merged now.

@srkgupta did you test against a server prior to 5.22? this should only apply to servers 5.22 and above right?
@fm2munsh there are conflicts that need resolution

@enahum I tested it on the latest master. The dependent server and redux code was already merged into master.

@srkgupta right, but we need to test that on previous servers this  check does not apply

@srkgupta right, but we need to test that on previous servers this check does not apply

Ok sure. Let me recheck.

I have tested this PR against an older server version of Mattermost and the Special mention options are shown as expected and is not hidden.

Conflicts resolved @enahum


Custom language highlight

Is your feature request related to a problem? Please describe.
I've written a compiler myself I wanna syntax highlight it.
Describe the solution you'd like
I'd like to syntax highlight via regex.
Describe alternatives you've considered
Nothing really.

Hey @Stevemoretz - that's awesome!
This isn't really the repo for it, though, because RSH pulls all of its languages and styles from whatever's bundled in Highlight and Prism (well, and some additional Prism themes).
Highlight isn't accepting any more core languages, and has switched to recommending people generate third-party packages. Check out Prism's guide to contributing new language definitions, though... that might be the best place for you to start.


Obsidian timeline fixes

-Fixed regex used to parse "Timeline" plugin  tags to allow for new line characters.
-Fixed issue with parsing of events from the "Timeline" plugin setting the month wrong.

The month is an issue: there are array-index numbered months, vs. for human months. The -1 doesn't work if you want to display 2023-01-01 and have that mean January 1st, does it?
What I would like to do is switch this to a more fc-cal friendly format: fc-year, fc-month, fc-day, where you can then use either the number or the name prefix (Jan, Feb, Ches, Greengrass, ...). Intercalary months (which are present in the Harptos Calendar, as an example) really mess with Month referencing, as they muck with the array index.


Design Meeting Notes, 9/17/2021

Import Assertions
https://github.com/microsoft/TypeScript/pull/40698

Basic idea, adds some additional syntax to import statements.
Doesn't affect us, we just need to "support" it by ignoring it.
Allows a runtime to assert that some import shouldn't have any executable code.
Looks like an object that you can stuff some options into.
Do we need a global interface that declares the valid properties?

This would only affect dynamic import() right?

Liked the idea of just supporting this and washing our hands of the host-specific details.

But seems like any host where this matters would have users savvy enough to add details here.

Where do these live?

JSON is "universally accepted" in TC39, so maybe that goes in lib.es****.d.ts
CSS - maybe lib.dom.d.ts.

How does this affect bundlers vs browser?

In theory shouldn't affect things.
This is contentious in the community.
Not sure what to do about this. 🤷♂

Feels incomplete to pass in non-string values,
We'll start with the current changes, then follow-up with stricter types.

Type Display for Unresolved Types
https://github.com/microsoft/TypeScript/issues/45893
https://github.com/microsoft/TypeScript/issues/38836

Hover over parameters: we can preserve the type
Hovering over the type gives you type Thing = any
Now find all references works at least for within the file.
Dotted names are trickier.

What if you can resolve the namespaces but not the name itself.

Shying away from the idea of displaying unresolved types differently - we try to preserve what you wrote in print-back.
Currently only works for types - we could make it work for variables.

If we supported variables that are unresolved, it would light up misconfigured JS projects.
Deeper properties would be nice!

In fact, namespaces and property accesses are necessary to support namespace-style imports (i.e. import * as yadda).
Dotted type names, we intend to support.
Can speculate we try to create a symbol on the fly for a property.

Only aids find-all-refs.
Rename too.

Might not recommend doing that.
Not a safe refactoring.

How would you represent this?

Global map in checker?

Doesn't only work in syntax-only mode - also is supported in full semantic mode where code is broken.

Regarding import assertions, being a host that is ready to implement it (@denoland) we are totally fine with TypeScript "washing their hands of it" and just allowing it to be parsed.  We already do all of our dependency decisioning and resolution outside of tsc and so we only expect the compiler to request the specifier to the host like it always has, and we will worry about if it is code and how to represent it (or not) from a type perspective to the compiler.  We believe our only blocker at the moment is that the compiler currently "chokes" on the syntax.
We are ready though to integrate it and give feedback when it lands in the beta.

It's looking more like we will keep ourselves open to being able to check specifiers based on a global type (in the same spirit of ImportMeta. That way, Deno's .d.ts files would be able to communicate exactly which extensions it supports.

Certainly wouldn't argue with that. We have been happy with how ImportMeta works.


Default cmake build isn't release

cmake ideally wants you to pass the build type as an argument when calling it. Currently a release type isn't passed, so it uses whatever cmake does by default.
I'm not sure what that default behavior is in cmake, but for my case passing doing the following manually:
cmake -DCMAKE_BUILD_TYPE=Debug"

Made by executable 500% faster.
Ideally this would be a config option? But probably a good idea to make default behavior RELEASE.

Thanks for reporting this. I agree with adding a "Release" default as well as making it configurable, however I do not want sbt to interfere with the native build configuration beyond what is strictly required. IMO, configuration of how to build the native library should be described in the native build tool and only there, that way it can also be invoked directly from the user without any surprises.
My counter-proposition is to pass a special flag to cmake, lets say "-DSBT:BOOLEAN=true", and let CMakeLists handle it accordingly, for example by setting a CMAKE_BUILD_TYPE=Release.
Would that work out?

Hmm, I just read some online discussions on setting CMAKE_BUILD_TYPE in the CMakeLists file itself, it seems rather complicated.
I think the best solution is to just add -DCMAKE_BUILD_TYPE=Release to the sbt build, we can revisit configuration when it is required.

Thanks! Yes agree ideally it would be nicer in CMakeFile itself (and you can do it, but it's a bit ugly).


link to open tickets in this website

The issue tracker takes you immediately to open a new ticket. It should instead take you to just .../issues, so you can search first.

Noted when answering https://github.com/Raku/problem-solving/issues/397

This appears to be the case for many of the links, we should remove "/new" from all of them.

.oO ( What are the odds someone added the /new as a poor mitigation of part of the issue @bazzaar described in Raku/problem-solving#397? )


trace_methods does not take effect

I want to monitor all methods under multiple different classes at the same time, but the configuration does not take effect. In most cases, only the first one takes effect, and the ones after the comma do not work.
wrapper.java.additional.22=-Delastic.apm.application_packages=com.orchestral.rhapsody.modules.http
wrapper.java.additional.23=-Delastic.apm.trace_methods=com.orchestral.rhapsody.modules.http.client.AbstractHttpClientConnection#*,com.orchestral.rhapsody.modules.http.server.RhapsodyCommPointServlet#*

Please set -Delastic.apm.log_level=debug and see if it takes effect and if so, look in the logs.
It should provide hints of whether the properties were properly picked an apply. If you cannot sort it out, please share the full debug log, from startup.

Closing now as we got no feedback. Feel free to reopen if you want to follow up on this.


[docs] Add CONTRIBUTING.md

This commit updates the CONTRIBUTING.md file in the repository to provide clear guidelines for contributing to the project. The changes include the following:
Added a section on how to report bugs and issues, including steps for reproducing them and providing relevant information.
Included instructions on how to suggest new features or improvements, including the preferred format for feature requests.
Clarified the code formatting and style guidelines to ensure consistency across contributions.
Provided examples and explanations on how to submit pull requests, along with the necessary steps for the review process.
Added a section on how to communicate effectively with the project maintainers and other contributors, emphasizing the importance of respectful and constructive discussions.
These updates aim to streamline the contribution process and provide contributors with clear instructions on how to get involved. The goal is to foster a welcoming and collaborative environment for anyone interested in contributing to the project.

please assigne me under GSDSoC


Column description improvement

#368 Second part (Grid View)

Hi @berhalak,
In this second part of the feature, one behavior can be improved : I think that the edit popup should open on click only if the column is preselected. At the moment when the column has a long label, we can't select the column without opening the popup.
I can't do it, can you help me on this point ?

Looking at the broken tests on part MultiColumn, it seems that function selectColumnRange in gristUtils.ts does not work anymore, maybe linked?

(might be worth rebasing this PR, there was a small tweak to previous description change https://github.com/gristlabs/grist-core/commit/aa3faae25b0b8da9bda4c612c8b56c282d29cc8e, don't know if it affects this PR but just a heads-up)

Hi @CamilleLegeron.
Would you like me to take over and finish implementing this feature (mainly the test parts)? I think there are multiple places in tests that we would need to change or adjust now that the column headers behave differently (for example, this MultiColumn test that is failing). Also, we have some internal tests that will be affected by this behavior change, so it would be much easier if I could finish this feature and adjust all affected tests.

Hi @berhalak, Of course, I also think it will be better. Thank you ! I'm interested to see the final state of the PR before the merge, if you could tag me when it's finished it would be great

Hi @CamilleLegeron,
I did the bulk of the work internally, as we still have some internal tests that are affected by this change, but here is a preview of how this feature looks now https://grist-column-info.fly.dev/ (this is a temporary Grist version just for this preview). Let me know what you think about it.

Hi @berhalak
Thanks for this works, it seems very nice to me.
I just noticed a small issue, when the cursor is in the description field from the grid view I would expect that the enter key create a new line and not validate. What to you think ?

Hi @berhalak Thanks for this works, it seems very nice to me. I just noticed a small issue, when the cursor is in the description field from the grid view I would expect that the enter key create a new line and not validate. What to you think ?

Yes, that makes sense, thanks for the feedback.

Hello @berhalak,
You've closed this branch ? Finally you don't want to do it or there were some problem ?

Maybe if it's the "rename column" part that's the problem we can validate a first part with only the tooltips ?
It's true that it change a lot of behaviour and the tab behaviour to rename all colmuns one after the other


[TB] Gradient calculations are wrong

Problem/Concern
All the gradients.... gradients-1 on-gradinents-1, gradient-2, on-gradient-2,  gradient-3 and on-gradient-3, --text-gradient-a, --text-gradient-a in both light and dark are coming in wrong - they are coming in as the light mode.
Proposed Solution

The values for lm and dm are being calculated and are different from each other.  The current calculations need to be reviewed by @lwnoble and will be corrected if necessary.


Fix links to DOC.md in README.md

Really tiny fix, the links to the configuration were outdated, and the link to DynamicNode led to FunctionNode instead.
Also, thank you for this plugin, I really like the Lua snippets.

Ah, thank you!


Support setting PR status

I don't doubt that this is already on the radar for the vsts-cli team, but supporting setting PR statuses will be a very valuable addition to the supported commands.  For our environment, it's actually the only REST API call we're really using right now so that we can block PR completion until an external build/test process has finished.
For general reference, the REST API docs for PR statuses is here:
https://www.visualstudio.com/en-us/docs/integrate/api/git/pull-requests/pullrequeststatuses
Thanks!

Thanks for the feedback.  This is definitely a command we would like to add.  It is on our backlog.

Great! I love that you finally did a CLI! Can you please post some of your backlog/roadmap? Is there also a plan for a PowerShell cmdlets (using PSSwagger you could even auto-generate those cmdlets from the REST API).

@tedchamb @warrenrumak Please have a look at the PR #127


cmake does not clean enough

Description

Type: Bug
Priority: Minor

Bug
Expected behavior
In a cmake build tree, make clean removes all files generated by the build and all auxiliary files left behind by tests.
Actual behavior
Some generated files remain after make clean: *.datax, Testing/Temporary/*, possibly others depending on what you build and test.
Steps to reproduce
git checkout mbedtls-2.16.0
mkdir build
cd build
cmake ..
make
make test
make clean
find \( -name 'CMake*' -o -name Makefile -o -name '*.cmake' -o -name DartConfiguration.tcl \) -prune -o -type f -print

ARM Internal Ref: IOTSSL-2773


LOG-2674:Suppressed error message if trying to remove non-existent watcher

Signed-off-by: Vitalii Parfonov<EMAIL_ADDRESS>This PR fixed https://issues.redhat.com/browse/LOG-2674:

Upgrade fsnotify lib to v1.6.0 (was v1.5.1)
Suppress error message if trying to remove non-existent watcher
Add to the .gitignore vendor and bin folders

/retest-required


Warm White issue

First of all, this is working almost perfectly, thanks so much! It looks like my particular bulbs respond to HomeKit commands perfectly for color and brightness, but toggling to white sends it to a 'cool white' instead of the 'warm white' that Magic Home sets it to. I tried editing the preset, switching to warm in Magic Home, and then saving the preset, but that didn't work (that does work nicely for any RGB setting).

Hey, first of all thank you. It's good to hear that it's working almost perfectly. May I please see your log.txt and a link to the exact bulbs you bought?
How exactly are you toggling to white? I'm afraid I haven't explained that functionality yet in the readme. Once you get close to the center of the RGB reticle, the bulbs turn white. The left side controls the cool white brightness, the right side controls the warm white brightness. That is, if you have both white types.
Alternatively you can simply say "hey siri, set the bulbs to warm/cool white"
Do your bulbs have a dedicated "cool white" and "warm white" LED (RGBWW) or just "warm white" (RGBW).
We'll get this working. Don't worry.

Here is the link for the bulbs. They do have both dedicated white types built in, though annoyingly they default to the cool white (that could be the cause of the issue). I am successfully toggling to warm white through the Magic Home iOS app. And wow! Asking Siri to set them warm white does work, but asking for just 'white' sets them to cool white. This is the same behavior as I have with Alexa voice commands, again due to the fact that they default to the cool white.
Here is a fresh log after restarting Homebridge:
[5/27/2020, 21:09:31] Loaded config.json with 0 accessories and 1 platforms.
[5/27/2020, 21:09:31] ---
[5/27/2020, 21:09:32] Loaded plugin<EMAIL_ADDRESS>[5/27/2020, 21:09:32] Registering platform 'homebridge-config-ui-x.config'
[5/27/2020, 21:09:32] ---
[5/27/2020, 21:09:32] Loaded plugin<EMAIL_ADDRESS>[5/27/2020, 21:09:32] Registering platform 'homebridge-magichome-dynamic-platform.homebridge-magichome-dynamic-platform'
[5/27/2020, 21:09:32] ---
[5/27/2020, 21:09:32] Loading 1 platforms...
[5/27/2020, 21:09:32] [homebridge-magichome-dynamic-platform] Initializing homebridge-magichome-dynamic-platform platform...
[5/27/2020, 21:09:32] [homebridge-magichome-dynamic-platform] Loading accessory from cache... 8
[5/27/2020, 21:09:32] [homebridge-magichome-dynamic-platform] Loading accessory from cache... 8
[5/27/2020, 21:09:32] [homebridge-magichome-dynamic-platform] Loading accessory from cache... 8
[5/27/2020, 21:09:32] [homebridge-magichome-dynamic-platform] Loading accessory from cache... 8
Setup Payload:
X-HM://0023ISYWY4CM6

In your homebridge html page please go to settings (3 vertical dots) >UI Settings>Click on "Advanced" > make sure "Enable / disable debug level logging" is checked, then restart homebridge, then send me your log after changing from red to white back once or twice using your voice.
Then drag and drop your homebridge.log as a file here.
I just tried telling siri to "set my lights to white" and it gave the same order as if I said "set my lights to warm white". I find it odd that it would do something different on your end. I do not interface with the magichome app. Instead I message the lights directly in the same manor that the magic-home does.
There should be no default color as my plugin is listening for Siri to give me a specific Hue and Saturation value "white, warmwhite, or cool white". Let's see what the logs say.
While you're at it, in addition, in the homekit rgb control screen (not temperature control) drag your finger accross the equator of the circle. It should go from teal>cool white>both whites> warm white> red. Let me know if this is or isn't the case.

I'll need to figure out how to get homebridge to write the logs to homebridge.log tomorrow (lots of leads from google, but need to sleep first haha). In the meantime, I have discovered (by doing the obvious thing and looking at the actual LED array) that these bulbs have dedicated warm white LEDs, but the cool white seems to use the same RGB modules as any of the color settings. That would be why, when going across the color wheel via homekit, warm white is never activated - only the cool white.

homebridge.log
Attached is the log file - I cleared it out and restarted the service, then toggled the lights. The last three commands I made were to set the lights red, then warm white, then white (all by Siri), which sets them correctly as red, then correctly as warm white, then as a cool white (which is not its own designated set of LEDS as mentioned above).

Thank you for the log. It has shed light on the issue although I cannot duplicate it on my end. I will investigate the code.
 Current HSL and Brightness: h:0 s:0 l:50 br:100
 Setting colors without white: r:127 g:127 b:127

Here shows the exact bug you were describing. saturation "s:0" is set to 0. The code is supposed to translate this as warm white. In fact. Anything less than 10 saturation (depending on your config) is supposed to set colors rgb to 0,0,0 and warmwhite whatever brightness you're set at.
My temporary solution to you is to continue saying "warm white" when directing Siri. Additionally go to your config file and temporarily change "colorWhiteThreshold": 10, to something extreme like "colorWhiteThreshold": 50, save and restart. Then try moving the reticle to the center of the color wheel. Let me know the results.
I will get back to you about this bug and let you know when to update the plugin. Thanks again.

Okay, I have added a new case to check for saturation and hue both at 0. Please update the plugin, restart homebridge. Let me know how it goes.
npm install -g homebridge-magichome-dynamic-platform

The recent update you made works perfectly! I didn't have to make a single change, my existing config and scenes now work flawlessly. Thanks so much!

Happy to be of service. Enjoy.

Issue was solved by adding a check if hue and saturation were both set to 0. Perhaps caused by the hue function being called before saturation had a chance to truely be set to 0.

Issue was solved by adding a check if hue and saturation were both set to 0. Perhaps caused by the hue function being called before saturation had a chance to truely be set to 0.