How to compile with -Dskip_frames=false?

I saw on https://github.com/Genymobile/scrcpy/issues/244 there is a flag to disable the skipping of frames. However, when I use the command meson x -Dskip_frames=false and then compile, the resulting exe still skips frames. I also tried cd x and then ninja as well as meson x --reconfigure to no avail. Am I missing something obvious or does that no longer work? I am trying to compile the latest dev build for the lost focus bug fix if that makes a difference.

the resulting exe still skips frames

How do you see that? If you show fps with Ctrl+i, does it still print "skipped frames" (sometimes)?

Yes, it still shows up as (+2 frames skipped).
On Wed, 29 May 2019 at 17:02, Romain Vimont<EMAIL_ADDRESS>wrote:

the resulting exe still skips frames
How do you see that? If you show fps with Ctrl+i, does it still print
"skipped frames" (sometimes)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Genymobile/scrcpy/issues/563?email_source=notifications&email_token=ABFLTCYOUEFLRS5EI7PQJDTPX2SI5A5CNFSM4HQOI4TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPZ7YQ#issuecomment-497000418,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFLTC5S452YOBK5IWEFYF3PX2SI5ANCNFSM4HQOI4TA
.

Do I need to do anything specific after running meson x -Dskip_frames=false

@BaconCatBug
Just ninja -Cx then ./run x to execute.

Ok I just compiled the latest dev build and I am still getting the +x Frames Skipped message when I press Control+i
I am running on windows and cross compiling on my Ubuntu laptop, both the 32 and 64 bit ones have the skipped frames.

This is very weird, I cannot reproduce.
If I pass -Dskip_frames=true or nothing, I have (+x frames skipped). Otherwise, I don't.
What is the result of meson configure x?

https://pastebin.com/1gmBDF1n

https://pastebin.com/0ZbxBrHn

cat x/app/config.h

?

https://pastebin.com/0PxUUVdV

#undef SKIP_FRAMES

config.h is correctly included in fps_counter.h:
https://github.com/Genymobile/scrcpy/blob/8c8649cfcd710859ce18eab557ed2af8cedb9a42/app/src/fps_counter.h#L7
The code which prints (+x frames skipped) is in a #ifdef SKIP_FRAMES block:
https://github.com/Genymobile/scrcpy/blob/8c8649cfcd710859ce18eab557ed2af8cedb9a42/app/src/fps_counter.c#L31-L36
So it should not be executed (or even compiled) in your binary. The only reason I can think of is that you don't execute the correct binary. What command do you type to execute?

I run scrcpy -c 1080:1920:0:120 -m 1024 -b 20M on Windows 8.1

after compiling with make -f Makefile.CrossWindows

This generates the release in dist/.

Yes, I know. I then transfer the zip to my windows machine and extract it, then run scrcpy.exe

From the right directory? Do you have another scrcpy.exe somewhere accessible from your PATH?
What if you execute .\scrcpy.exe from your release directory?

I do not have any other scrcpy.exe in my path (scrcpy is not recognised).
Using the exe from the scrcpy-win64 folder instead of the zip is the same result, skipped frames.
The linux version works, no skipped frames.

Oh, ok, I get it. meson x/ninja -Cx is just for your local build.
Makefile.CrossWindows generates the release with its own build dir and configuration.
diff --git a/Makefile.CrossWindows b/Makefile.CrossWindows
index 0f7b14a..1e59969 100644
--- a/Makefile.CrossWindows
+++ b/Makefile.CrossWindows
@@ -57,6 +57,7 @@ build-win32: prepare-deps-win32
                        --buildtype release --strip -Db_lto=true \
                        -Dcrossbuild_windows=true \
                        -Dbuild_server=false \
+                       -Dskip_frames=false \
                        -Doverride_server_path=scrcpy-server.jar )
        ninja -C "$(WIN32_BUILD_DIR)"

@@ -67,6 +68,7 @@ build-win32-noconsole: prepare-deps-win32
                        --buildtype release --strip -Db_lto=true \
                        -Dcrossbuild_windows=true \
                        -Dbuild_server=false \
+                       -Dskip_frames=false \
                        -Dwindows_noconsole=true \
                        -Doverride_server_path=scrcpy-server.jar )
        ninja -C "$(WIN32_NOCONSOLE_BUILD_DIR)"
@@ -81,6 +83,7 @@ build-win64: prepare-deps-win64
                        --buildtype release --strip -Db_lto=true \
                        -Dcrossbuild_windows=true \
                        -Dbuild_server=false \
+                       -Dskip_frames=false \
                        -Doverride_server_path=scrcpy-server.jar )
        ninja -C "$(WIN64_BUILD_DIR)"

@@ -91,6 +94,7 @@ build-win64-noconsole: prepare-deps-win64
                        --buildtype release --strip -Db_lto=true \
                        -Dcrossbuild_windows=true \
                        -Dbuild_server=false \
+                       -Dskip_frames=false \
                        -Dwindows_noconsole=true \
                        -Doverride_server_path=scrcpy-server.jar )
        ninja -C "$(WIN64_NOCONSOLE_BUILD_DIR)"

Ah, thank you,
Adding those four -Dskip_frames=false \ to the Makefile.CrossWindows file has fixed the issue, it is now no longer skipping frames on Windows.
Thank you for your help and apologies for taking up your time!

You're welcome.
Do you see any difference in practice (except in the console)?

I do but it could be placebo for all I know. I'd need to do a proper side
by side with recording to be sure. Even so it's still a little choppier
than when I view the image on the phone but that might be down to my pretty
old CPU/GPU combo.
On Mon, 3 Jun 2019 at 16:27, Romain Vimont<EMAIL_ADDRESS>wrote:

You're welcome.
Do you see any difference in practice (except in the console)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Genymobile/scrcpy/issues/563?email_source=notifications&email_token=ABFLTCZIX4PPACNUKJJN7WTPYUZ5PA5CNFSM4HQOI4TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZYPOA#issuecomment-498304952,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFLTC5X4FNK3ZNPI23FON3PYUZ5PANCNFSM4HQOI4TA
.

How many frames were skipped each second with skip_frames enabled?

Between 1 and 5, with the occasional 6 or 7.
On Mon, 3 Jun 2019 at 16:31, Romain Vimont<EMAIL_ADDRESS>wrote:

How many frames were skipped each second with skip_frames enabled?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

On dev branch, I replaced the compilation flag skip_frames by a runtime command-line parameter:
# equivalent to the old compilation option skip_frames=false
scrcpy --render-expired-frames

Apologies for posting on a closed issue, but by replaced, you mean that if we're to run scrcpy without frame skips, we cannot compile it with the previous -Dskip_frames=false flag, so that it runs by default without frame skipping, and we absolutely have to use the new runtime command-line parameter?
I noticed that -Dskip_frames=false is a flag that's passed to mason, so I just edited the makefile to include -Dskip-frames=false on the build-win32/64 rules, including the no console ones, for a total of 4 times, to no avail, and then I found this thread. It would appear from the posts above that you had done something similar in an older version of scrcpy. I have pasted the makefile in a pastebin, if it helps: https://pastebin.com/KrHZpfSt
If we can only stop the frame skipping using that parameter, is it possible to make it so that it can read some sort of configuration file so that I don't have to run it from the command line every time?
Thank you for your time.

Just make a batch file or shell file to run the command with the parameters you want.


Add Wii and 3DS function

Your tool is great ! Can you please add Wii and 3DS function to your tool ?
I will try to provide similar info for a 3ds title asap !

I had to remove the title key you posted.
I have no plans to support the Wii with this tool and I don't even think it's possible with this algorithm.
This tool already supports 3ds, it uses the exact same algorithm, however only the non-encrypted keys are correct for the 3ds. The encrypted keys that are generated by this tool are encrypted with the Wii U common key so naturally they wouldn't work on 3ds. I'm not too familiar with the 3ds and so I have no knowledge of the 3ds common key or how the keys are encrypted. It's possible that it's exactly the same as Wii U but using the 3ds common key instead??. I have no idea though, the key encrypting process could be different for the 3ds but I lack knowledge in the 3ds scene..

Wii works the same way as wiiu, what seems to change is the password (chosen between the 2 unsecure ones provided from the source leak). About 3ds i do not know too How it exactly works but many info are in 3dswiki website.
-----Original Message-----
From: "Brian (life-elevated) dojafoja"<EMAIL_ADDRESS>To: dojafoja/Kii-U-Generator<EMAIL_ADDRESS>Cc: buggii<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Sent: Ven, 19 Giu 2020 6:07
Subject: Re: [dojafoja/Kii-U-Generator] Add Wii and 3DS function (#1)
I had to remove the title key you posted.
I have no plans to support the Wii with this tool and I don't even think it's possible with this algorithm.
This tool already supports 3ds, it uses the exact same algorithm, however only the non-encrypted keys are correct for the 3ds. The encrypted keys that are generated by this tool are encrypted with the Wii U common key so naturally they wouldn't work on 3ds. I'm not too familiar with the 3ds and so I have no knowledge of the 3ds common key or how the keys are encrypted. It's possible that it's exactly the same as Wii U but using the 3ds common key instead??. I have no idea though, the key encrypting process could be different for the 3ds but I lack knowledge in the 3ds scene..
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/dojafoja/Kii-U-Generator/issues/1#issuecomment-646423743

it really is as simple as inputting the 3DS slot 0 common key in ckey.json (that is "64CxxxxxxxxxxxxxxxxxxxxxxxxxxB98"), I've tested it in combination with https://github.com/plumber-craic/3ds-cdn-cia. It provides valid cia files for installation from the encrypted CDN context if you edit maketicket_from_enctitlekeys_v3.py to use the generated encrypted title key instead of trying all the ones from the encTitleKeys.bin file. Now all that remains is just hooking your script into 3ds-cdn-cia and you are good to go

Thanks for doing the testing on 3ds. I don't own one and was never involved in the scene. I could easily make a PR to the project repo that you linked. I will look into it very soon.

@buggii how did you figure it out? when i try the both 2 keys from wii, keygen is throwing "invalid common key" error, the digest of wiiu keys dont match wii

@chaeyan oops! I accidentally deleted your comment. Sorry about that ☺

it really is as simple as inputting the 3DS slot 0 common key in ckey.json (that is "64CxxxxxxxxxxxxxxxxxxxxxxxxxxB98"), I've tested it in combination with https://github.com/plumber-craic/3ds-cdn-cia. It provides valid cia files for installation from the encrypted CDN context if you edit maketicket_from_enctitlekeys_v3.py to use the generated encrypted title key instead of trying all the ones from the encTitleKeys.bin file. Now all that remains is just hooking your script into 3ds-cdn-cia and you are good to go, meaning one doesn't need encTitleKeys.bin anymore, and one isn't limited to whichever games people uploaded title keys for back in the day

Thanks for your help, I've successfully retrieved the TitleKeys but I don't know how to tell maketicket_from_enctitlekeys_v3 to use mines, would you be able to help ?


Rancher 2.6.x does not allow to download RKE downstream KUBECONFIG provisioned without network CNI (network: plugin: none)

Internal reference: SURE-5307
Reported in 2.6.1 to 2.6.8
Issue description:
RKE downstream cluster provisioned by Rancher as CNI none (network: plugin: none) keeps the cluster greyed out, so users are unable to download the KUBECONFIG or interact with it.
This worked until 2.5.x; they were able to download KUBECONFIG from RKE provisioned by Rancher as CNI network: plugin: none.
Troubleshooting steps:
Create a RKE downstream provisioned by Rancher as CNI none (network: plugin: none)
Repro steps:

Create a RKE downstream as CNI network: plugin: none
The cluster stays greyed out
You are unable to download KUBECONFIG

Workaround:
It's not easy and not acceptable.

SSH into CP node
Generate local KUBECONFIG
Install any CNI that works
cattle-agent connects to Rancher * note that the cluster goes from grey to blue (active)
then download the KUBECONFIG from UI.

Actual behavior:
Unable to download KUBECONFIG from RKE provisioned by Rancher as CNI network: plugin: none.
Expected behavior:
Ablity to download KUBECONFIG from RKE provisioned by Rancher as CNI network: plugin: none.

We should confirm what we did in 2.5.x or at least with the older Ember UI to determine how the button becomes active (are we waiting for the cluster to be ready?).

On 2.6.9

Download Kubeconfig is not available on cluster when

network:
    mtu: 0
    plugin: none

On 2.7-head commit id: 28a84c7

Kubeconfig download option is available and as a user, I am able to use this yaml file to perform kubectl actions on the cluster that has not come up Active yet


Unable to format

I made one of these a while ago, but was never successful flashing it, so I put it aside. I saw the Wili was updated, and gave it a try, and it worked! I plug it in, and it asks to format the drive. Unfortunately, it fails. What am I missing?

Yes, I think I remember. You have built it before the 1.3 release, so you
should have 1.2 revision hardware, correct? The flashing procedure for
these is shown in this video (fragment from 0:00 to 4:43) :
https://www.youtube.com/watch?v=t0oajBFZcZY&feature=youtu.be
Is this the procedure you have followed?
Because you cannot run 13000 firmware on older hardware, in your case
you would need 12005 firmware

If you followed the right procedure and it fails to format anyway, it might
be because the seller of the W25Q256FVFG memory chip did not ship it to
you pre-erased, as it should be. In this case, you should erase all the memory
yourself. If you flashed 13000 firmware into 1.2 device you should also erase
all memory before flashing the correct 12005 firmware. The easiest way to do
so is to flash 12003 firmware (disk size should become 32MiB), and then overwrite
all memory to 0xFF bytes using some hex editor (on linux I use hexedit). The process
could take quite a bit of time, like 10 min, because 12003 firmware was not very good.

I originally assumed I made some mistake building it, but it looks like you're right. I flashed 12003, and suddenly I had a 32MB flash drive. I was lazy, so I tried doing a long format, but that didn't work. I used HxD to flash FF's to everything, flashed 12005, and I have a 24MB drive now. Is it supposed to be 32MB?

Also, if new firmware won't be compatible with old hardware, is it easy/possible to upgrade the hardware to 1.3?

Yes, it is supposed to be 24MiB. This is due to the fact that versions 12004 and up
have a Flash Translation Layer built in, and 8MiB are allocated for overprovisioning
and other stuff like that. The 12003 firmware did not have that, and directly
translated logical block addresses into physical block addresses.

Great, thanks. I looked at the hardware, so I'm guessing it's not practical to physically upgrade :)

Well yes, you would have to buy new PCB's and memory chips to upgrade the hardware.
Does your device seem to work OK with 12005 right now?

Yes, so far. I'm running H2testw (Endless verify), and it passed. Now I have to figure out how to use it :)

OK, good


Support for multiple APIC frames when saving.

A file containing multiple APIC frames will lose all but the last one when parsing.
iTunes appears to be perfectly capable of parsing files with multiple pieces of artwork (APIC) attached. When parsing such file with id3v2, we see only a single APIC coming out of the "AllFrames()" factory. When then saving we did effectively delete all those additional APIC frames.
The AddFrame implementation of sequence is rather confusing to me. It tries to find out if a key already exists within the sequence and if so, does not add the frame but replaces the existing frame in the sequence. What is the point of a sequence if we only ever add a single element?
Anyway, by patching AddFrame as follows, we get proper amounts of pictures out of the parser;
func (s *sequence) AddFrame(f Framer) {
	s.frames = append(s.frames, f)
}

Not sure what I am breaking here though....

After reading a bit more through the code, I am beginning to understand what I am breaking here. Not a good approach assuming that indeed the "description" is supposed to be unique and thus feasible for hashing a picture in id3v2.
Turns out I did also not observe iTunes' behaviour correctly. When fed with the file/s I am testing with, iTunes also reduces the file to a single image - iTunes uses the one advertising itself as a "COVER_FRONT" - thus ignoring the "Description" but using the "Picture type" for additional hashing.


[Zattoo] Fix information extractor (closes #1244)

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[ ] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
This PR fixes the Zattoo information extractor (as described in #1244). The most important change is the ability to log in again. Furthermore, it successfully extracts videos from the 7-day-replay, ondemand and recording section.
You need a Zattoo premium account to test it. Unfortunately I cannot provide one. If anyone can provide an account to a maintainer to test this PR, let me know. To the maintainers: It should also be possible to create a new account on zattoo.com (with a Swiss IP) and you can get 30 days free premium for free.
Here is a short summary of what works and what doesn't:
Works:

Login
Videos from the guide (7 day replay)
Recorded videos
Ondemand videos

Doesn't work:

Ondemand series (haven't tried to add this, maybe this can be done in a follow-up PR)
Live TV: The dash streams do get extracted successfully by using _extract_mpd_formats, but the streams cannot be downloaded. Here is the output that I get:

[info] srf_zwei: Downloading 1 format(s): dash-5002-A-0+dash-601-A-2
[download] Destination: srf_zwei 2022-01-10 13_26 [srf_zwei].mp4
[https @ 0x556d7b5f8040] HTTP error 404 Not Found
[dash @ 0x556d7b578480] Failed to open fragment of playlist
[https @ 0x556d7bb56b80] HTTP error 404 Not Found
[dash @ 0x556d7b578480] Failed to open fragment of playlist

Resellers: They are most definitely still broken, but I cannot fix this, since I do not have access to any of them.

@pukkandan Everything worked fine except the extractraction of the recordings. I got this error:
ERROR: no such group
Traceback (most recent call last):
  File "/home/alex/Projects/repos/yt-dlp/yt_dlp/YoutubeDL.py", line 1403, in wrapper
    return func(self, *args, **kwargs)
  File "/home/alex/Projects/repos/yt-dlp/yt_dlp/YoutubeDL.py", line 1473, in __extract_info
    ie_result = ie.extract(url)
  File "/home/alex/Projects/repos/yt-dlp/yt_dlp/extractor/common.py", line 639, in extract
    ie_result = self._real_extract(url)
  File "/home/alex/Projects/repos/yt-dlp/yt_dlp/extractor/zattoo.py", line 265, in _real_extract
    vid1, vid2 = self._match_valid_url(url).group('vid1', 'vid2')
IndexError: no such group

I've fixed it in https://github.com/yt-dlp/yt-dlp/pull/2288/commits/2b83b0a996b86bb2f116eeeef76e9ea542937cc1.
Let me know if that is an appropriate fix.

I've fixed it in https://github.com/yt-dlp/yt-dlp/commit/2b83b0a996b86bb2f116eeeef76e9ea542937cc1.
Let me know if that is an appropriate fix.

That looks fine


CA.gov logo update to meaningful  from deocrative.

Coded as: Decorative
Accessible name: ca.gov logo
Change to: <img>

If ca.gov was removed we would only hear State of California in. It impacts the page so should be made an  instead of decorative. The footer can remain decorative since it would be repetitive.

WCAG 2.1 Guideline 1.1.1 Non-text Content
Every image must be correctly coded as either meaningful or decorative.
If the image conveys information that isn't available through other page content, it's meaningful.
If the image could be removed from the page with no impact on meaning for function, it's decorative.

@jaredwyee Ca.gov is actually link. It's not just the image (link has a title attribute that is read by assistive technologies) The ca.gov image inside of the link has aria-hidden=true attribute, but it's information is conveyed in the link's attribute title text. So, I am not sure if we have any problem there.
As far as arrows on the menu, I agree, we need to make sure they have aria-hidden attributes.

I think in this case the svg itself would be considered meaningful and not decorative and it would make sense to remove aria-hidden=true and add alt="Ca.gov logo" https://www.w3.org/WAI/tutorials/images/functional/.
I agree about adding aria-hidden to the menu arrows.

Menu being aria-hidden agreed.
For the ca.gov logo, sounds like there is the potential to 1) rely on the link being the information/description for assistive tech OR 2) have the image svg with an alt text.
It does not seem like we need BOTH. Is there a better approach for which one? @zakiya @kkoryaka Or please clarify on why we might need both 😁

I would prefer to use an alt tag on the logo and remove the the title attribute from the a tag. https://www.a11yproject.com/posts/title-attributes/ https://www.deque.com/blog/text-links-practices-screen-readers/ We could also ask the CDT Accessibility Engineer since she was the original reporter.

I'm good with proceeding as you stated: use alt tag on logo and remove the title attribute.
Original recommendation from Tiffany was the , with  alt tag anyways.

Confirmed working. Closing. Pending move to Done once release merge complete.


put: Require explicit assignments

Make both implicit and explicit put procs require that every expression
have an explicit assignment.
Closes #2997

@philrz I did my best to do the doc changes in this pr as well.


Bug: Cursor jumps to the end of the document after undo checkbox adding

Cursor jumps to the end of the document after undo checkbox adding. Only reproducible when collaboration mode is on
Lexical version: v0.14.5
Steps To Reproduce

Launch playground with collaboration mode on
Add several paragraphs
Add checkbox in between paragraphs
Undo

The current behavior

The expected behavior
Cursor stays where undo was done

Similar issues are mentioned in #4846

Also related: #5975 #5974

Hey, I am working on it.

Closed in #6070

Is it ok to copy&paste codes from other pull request already exists?
If it is ok with rule of Lexical.js but I have bad feeling now.
mine
https://github.com/facebook/lexical/pull/5975/files#diff-3d291634235852090f5aa491928d6d43fa366302bf0222b0629adf3580e64ab2R549
yours
https://github.com/facebook/lexical/pull/6070/files#diff-3d291634235852090f5aa491928d6d43fa366302bf0222b0629adf3580e64ab2R552


web UI ，File write exception occurred at the end of task execution

Issue Description / 问题描述
I deployed xAgent through Docker, and from the following logs, it can be seen that the operation is normal.

Then I tested the basic functionality through webui
It can be seen that a step has been repeatedly executed, and upon reviewing the logs, two errors were reported.
One prompt request  /execute_tool 500. ERROR:  Temporary failure in name resolution  I don't quite understand what the problem is，How to handle it。This error should have caused  ** I will try using a Python notebook cell to ---compute the answer to '1+1'. ** 。 The error is as follows：

一处为Exception in ASGI application。May I ask what is the reason for this? The error is as follows:

Expected Behavior / 预期行为
Describe the behavior you expected to see. / 请描述您期望的正确行为。
Environment / 环境信息

Operating System / 操作系统：Ubuntu
Python Version / Python 版本：3.1

It is worth noting that this issue is always present in any task being performed.At the same time, I found that one container in the Docker's container did not start, but when I checked the logs, I found no issues

Here are the logs I checked through Docker Logs：

I want to know if the state of this container is normal

That's expected behavior based on current docker-compose.yml and ToolServerNode Dockerfile.
In this case, even though the Dockerfile has an ENTRYPOINT that should keep the container running continuously by running a uvicorn server, the entrypoint in the docker-compose.yml overrides this, causing the container to exit after printing "Build complete. Exiting..."
Reference: https://docs.docker.com/compose/compose-file/compose-file-v3/#entrypoint
For the error, can you upload running_records here and we will see.

/execute_tool 500. ERROR: Temporary failure in name resolution.
Is it also caused by the ToolServerNode container startup failure?

Like i said, it's not a failure which needs to worry about.
For execute_tool, it is in here

Okay, thank you


Tables - Visual design

Tables
Very simple styling in regards to #101 . I'm wary of zebra stripes from a UX perspective because it runs the risk of positing false significance on highlighted cells. Adding additional padding in cells seeks to increase legibility as zebra stripes intend to.

Closed by #193


Migrate from v2 to v3

This is the guide to migrate a workflow from v2 to v3 (aka releases).

Are we explaining the implications of a bump in .tinyenv VERSION and how to work with releases?


Duplicated buttons in v10

Button is duplicated 4 times
Symbols > Theme: grey 10 > button > 01 primary > default text > 01 enabled
Button has 2 instances
Symbols > Theme: grey 10 > button > 01 primary > default text and icon > 01 enabled
Button is duplicated 3 times
Symbols > Theme: grey 10 > button > 01 primary > small text > 01 enabled
Button has 2 instances
Symbols > Theme: grey 10 > button > 01 primary > small text and icon > 01 enabled
Button has 2 instances
Symbols > Theme: grey 10 > button > 04 ghost > small text and icon > 01 enabled

Button mentioned above are corrected now, thank you.
Seems like these in other themes also need a clean up:
Theme: gray 90 > button > 01 primary > default text > 01 enabled has three copies now
Theme: gray 100 > button > 01 primary > default text > 01 enabled has two copies
Theme: gray 100 > button > 01 primary > small text > 01 enabled has two copies

fixed ! 🎉

[x] Theme: gray 90 > button > 01 primary > default text > 01 enabled has three copies now
[x] Theme: gray 100 > button > 01 primary > default text > 01 enabled has two copies
[x] Theme: gray 100 > button > 01 primary > small text > 01 enabled has two copies


System requirement aapt not listed

Hi! Thanks for this cool project. I've been working on setting it up on my system and I ran into an issue where running the examples would give an error while installing Wireguard on the emulator.
Error: Failed to automatically install WireGuard app. Try again or install it manually.
    at Object.ensureDevice (file:///ABC/node_modules/appstraction/dist/index.js:382:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///ABC/analysis.js:21:5 {
  [cause]: Error: Failed to install app: "/tmp/cb0bf978e9c8165113e29ba2f08d7ee5.apk" is not a valid APK.
      at file:///ABC/node_modules/appstraction/dist/index.js:473:35
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Promise.all (index 0)
      at async Object.installApp (file:///AB/node_modules/appstraction/dist/index.js:472:29)
      at async Object.ensureDevice (file:///ABC/node_modules/appstraction/dist/index.js:377:21)
      at async file:///ABC/analysis.js:21:5
}

After some testing and digging around in the code, I realized it is due to this line in util.ts: https://github.com/tweaselORG/appstraction/blob/main/src/util.ts#L75, which uses aapt to check the apk file. Turns out I didn't have aapt installed (I'm on a relatively fresh install of ubuntu 22.04). A quick apt install aapt fixed this problem.
From a quick look, I couldn't find aapt mentioned as a requirement for this project. So, maybe it would be possible to add this somewhere in the documentation and/or to improve the error message to make this more clear?
Let me know if you need any more info from me. Thanks!

aapt is part of the Android Build Tools, which we mention in the host dependencies for Android of appstraction. Maybe you didn't install the build tools or you don't have your PATH set up correctly?
Thanks for the feedback on the README, though. I think we could provide clearer steps on how to install the dependencies and maybe also check they have been correctly installed.

Ah yes, I see the problem. My installed build tools where in $ANDROID_HOME/build-tools/33.0.2/, but I simply copied the PATH lines from the README which uses version 33.0.0. Changing that solves it.
Thanks for the explanation!

Since appstraction v0.3.0, we're now installing the Android SDK tools automatically, so I think this can be closed.


Create bbns.txt

This seems to be a K-12 school; this project is for higher education (post-secondary) institutions only. Closing.


feat: add missing skins

This PR is up to date #1745 (Made new PR because old one is outdated and half of stuff is broken, resource pack caching, reindeer pet etc..)

Description
Adds missing pet skins
Closes #1729
Closes #1710
Closes #1706
Closes #1757
Closes #1783
Closes #1802
Closes #1809
Animations for skins are missing

Following skins are missing animations: PET_SKIN_BLACK_CAT_PURRANORMAL, PET_SKIN_SHEEP_CHROMA_WOOLY, PET_SKIN_TIGER_NEON, GOLDOR_CELESTIAL, NECRON_CELESTIAL, STORM_CELESTIAL and PET_SKIN_ROCK_NORTH_STAR

I think we should merge this PR so users can actually see skins in pets menu. Just having texture is better than having nothing for animated ones. If this PR gets merged we should make issue for animated skins

I think we should merge this PR so users can actually see skins in pets menu. Just having texture is better than having nothing for animated ones. If this PR gets merged we should make issue for animated skins

Definitely, we should keep track of these types of things we're missing.

Added new skins, animations are missing for following skins
LUNAR_RABBIT_HAT, PET_SKIN_RABBIT_LUNAR, WITHER_GOGGLES_CYBERPUNK, WITHER_GOGGLES_CELESTIAL,  PET_SKIN_REINDEER_AURORA and PET_SKIN_GRIFFIN_REINDRAKE

Added new skins, animations are missing for following skins LUNAR_RABBIT_HAT, PET_SKIN_RABBIT_LUNAR, WITHER_GOGGLES_CYBERPUNK, WITHER_GOGGLES_CELESTIAL, PET_SKIN_REINDEER_AURORA and PET_SKIN_GRIFFIN_REINDRAKE

lgtm, re-tested


Updated patch for nginx 1.14.0

Latest patch doesn't apply to nginx-1.14, and patch for nginx-1.14.0 was unviable. I took latest patch and adopted it to nginx-1.14.

I'll take a look.

Looks good to me.


Make using implicit system Charset an error

The rule is enforced via Error Prone.
Implicit system charset is replaced with explicit UTF-8, with a single exception in LocalDataSegmentPuller, where system charset is used explicitly.

Do any of these accept the String argument instead of the Charset argument? IIRC String is generally better to use.
Also, does this mean https://github.com/druid-io/druid/blob/druid-0.10.0/java-util/src/main/java/io/druid/java/util/common/StringUtils.java#L79 should be updated as well?

@drcrallen replaced usages of String.getBytes() and new String() with fast methods from StringUtils.
Regarding https://github.com/druid-io/druid/blob/druid-0.10.0/java-util/src/main/java/io/druid/java/util/common/StringUtils.java#L79, added English locale, but a bigger problem is that there are more than 700 direct usages of String.format() in the project, made #4335 issue to track that.

BTW @nishantmonu51 I'm not sure that UTF-8 should be used here: https://github.com/druid-io/druid/pull/4326/files#diff-642712b19dd6ec8879e4288fef68a75fR84, could you please review that?

@gianm thanks for review, are you sure about https://github.com/druid-io/druid/pull/4326#issuecomment-304366983? Also pinging @nishantmonu51 again

I think the change in https://github.com/druid-io/druid/pull/4326#issuecomment-304366983 is fine, because the base64 encode should return a byte array in ascii encoding, and decoding ascii as utf-8 will work as expected.

It would better to explicitly decode the strings using StandardCharsets.ASCII in this case.


Animation

Create a set of default animation helper classes that do nice things, sort of like our very nice http://pdx.esri.com/blog/ or hover on https://developers.arcgis.com/features/

[ ] Brand type animations. Things like fade in, fade out
[ ] story type animations (dancing watches)
[ ] feedback type animations (hey you need this, hey modal went over here)

Stubbed this out, ready to put lots of animation helpers in w/ #538


How can run WPF in macOS?

Run WPF in macOS.
I want to run WPF in macOS, but run error is "It was not possible to find any compatible framework version The specified framework 'Microsoft.WindowsDesktop.App', version '3.0.0-alpha-27128-4' was not found", I can't find this runtimes in macOS version.

reopened

Basically, you can't.
Although .NET Core 3 supports WPF, WinForms and UWP XAML they're only for Windows. You can read about this topic in .NET Blog.
I don't really know if there are any hacks that you can do to get WPF running on MacOS, but I suppose this is not the place to talk about it.

@William201807 the blog post and WPF repo both contain information, that WPF is Windows-only. Currently there are no plans to make it cross-platform. See https://github.com/dotnet/wpf/issues/48

For those of us coming to this page from a websearch for "WPF on MacOs" I guess what we'd like is a pointer to good options for https://www.bing.com/search?q=netcore+cross+platform+gui
I appreciate that this isn't what dotnet/core/issues is for, but this page now ranks high

I had the same problem with WPF and found a solution of sorts. I ended up using Unity to create a C# UI interface that works on MacOS, Windows, and more. Here is a basic tutorial I made on how to do it: https://medium.com/@A51/how-to-easily-develop-a-c-ui-app-that-works-on-mac-and-windows-8eaf32ea0ed6. I am happy to help with any questions I can.

Yes, good point. I guess MAUI is due to be our way forwards but really, Unity has been working for years and let's face it, most games are more demanding than LoB apps.


Cleanup and fix cycle handling #285

(going through the changes our fork is missing rn) This seems to not contain the perf regression we observed on other changes


Install alternative runtimes

[ ] kata-containers (https://github.com/kata-containers/kata-containers/releases/download/2.4.3/kata-static-2.4.3-x86_64.tar.xz)
- name: kata-containers
  hidden: true
  version: 2.4.3
  binary: kata-runtime
  check: ${binary} --version | head -n 1 | tr -d ' ' | cut -d':' -f2
  needs:
  - docker
  - qemu
  tags:
  - runtime
  download:
  - url: https://github.com/kata-containers/kata-containers/releases/download/2.4.3/kata-static-2.4.3-x86_64.tar.xz
    type: tarball-xz
    path: ${target}
    strip: 3

[x] gvisor

[ ] sysbox (https://github.com/nestybox/sysbox/blob/master/docs/developers-guide/build.md)

gvisor installed by #150

FROM ubuntu:22.04 AS prepare
RUN apt-get update \
 && apt-get -y install --no-install-recommends \
        git \
        ca-certificates \
        build-essential \
        golang-go \
        cargo \
        make

FROM prepare AS source
ARG version=2.4.0
WORKDIR /kata-containers
RUN git clone -q --config advice.detachedHead=false --depth 1 --branch "${version}" https://github.com/kata-containers/kata-containers .

FROM source AS build
RUN make PREFIX=/target

Migrated to https://github.com/uniget-org/tools/issues/77


Problem Set 3 Submission

Zip folder of submission: pset3.zip
Pset is in /problemsets/pset3
@jhaber-zz @euniceyliu

comment


Error: Timed Out

It always happen every around 30 minutes

i have the same error

Any news on this?

Anyone know how to fix this ?

same problem here too, if somebody know how to fix, please share here.

Same error here

same error here

This depends on a lot of factors. I can't just determine the cause of the issue from this simple screenshot at all


forgotPassword endpoint added - generates a temporary password sent t…

…o the email of the user

This endpoint takes as input the email. Determines if it is a student or organization, and then handles operations approprietly to update the password of the student or org to be the newly generated password (hashed) and sends the unhashed one through email to the student or user.


[athena] fixing logger format string and using lambda alias for invocation

to: @austinbyers
cc: @airbnb/streamalert-maintainers
size: small
Background
@austinbyers observed the following stack trace:
%d format: a number is required, not unicode: TypeError
Traceback (most recent call last):
File "/var/task/stream_alert/athena_partition_refresh/main.py", line 212, in handler
AthenaRefresher().run(event)
File "/var/task/stream_alert/athena_partition_refresh/main.py", line 180, in run
sqs_rec['attributes']['SentTimestamp'])
File "/usr/lib64/python2.7/logging/__init__.py", line 1155, in debug
self._log(DEBUG, msg, args, **kwargs)
File "/usr/lib64/python2.7/logging/__init__.py", line 1286, in _log
self.handle(record)
File "/usr/lib64/python2.7/logging/__init__.py", line 1296, in handle
self.callHandlers(record)
File "/usr/lib64/python2.7/logging/__init__.py", line 1336, in callHandlers
hdlr.handle(record)
File "/usr/lib64/python2.7/logging/__init__.py", line 759, in handle
self.emit(record)
File "/var/runtime/awslambda/bootstrap.py", line 446, in emit
msg = self.format(record)
File "/usr/lib64/python2.7/logging/__init__.py", line 734, in format
return fmt.format(record)
File "/usr/lib64/python2.7/logging/__init__.py", line 465, in format
record.message = record.getMessage()
File "/usr/lib64/python2.7/logging/__init__.py", line 329, in getMessage
msg = msg % self.args
TypeError: %d format: a number is required, not unicode

Changes

Fixing above error by using %s format string
Updating event source mapping to invoke production alias instead of $LATEST

Testing
Deployed in test account

Coverage remained the same at 96.961% when pulling 549dc7cc5fd93020037238539f78c8670296c08b on ryandeivert-athena-logger into b0612e5646c3944d369683e270f001e339c26d5e on master.


Unsupported datatypes should be imported as strings

There are a large number of Excel date, time, duration, post code, etc formats which are not supported by OpenRefine, but are currently imported as either numbers or datetimes. Anything unsupported should be imported as a string instead of a number or datetime.
To Reproduce
Steps to reproduce the behavior:

Import an Excel worksheet containing dates such as 09:46:00 AM in a column
Open the project

Current Results
The cell is converted to 1899-12-31T09:46:00Z.
Expected Behavior
The column should be kept as a string.
Additional context
I have not found any way to disable cast on import.

Similar to #4838 which proposes to add an option to import all cell contents as strings in the excel importer.

Indeed, it seems a duplicate, sorry.

In this specific case, I would suggest that time should not be cast, no matter if the user selects to cast dates or not, since time is not a date. Having an option to disable automatic cast would be useful, nonetheless.

Would you be able to provide a sample XLS file with a time value? I would then mark this as a good first issue.

Internally these are all just datetimes with formatting strings to Excel. Also, OpenRefine doesn't have a time (or date) data type - only datetime.
Converting Excel dates to strings my require a full and faithful implementation of the Excel date formatting (unless there's a cached version of the pre-rendered string available). I'm not sure that would be super easy as a first issue.

Would you be able to provide a sample XLS file with a time value? I would then mark this as a good first issue.

openrefine-5390.xlsx

I've updated the description to generalize the issue to all unsupported data formats. The biggest question, in my mind, is dates (without times), which OpenRefine doesn't technically support, but it seems like importing dates as (perhaps locale-specific) strings and then forcing the users to deal with them is (almost?) worse than importing them as datetimes with a time of midnight.

One big issue I have had with importing dates as datetimes with a time of midnight is the timezone-sensitivity. If somehow the importer takes it to be midnight in the local time determined by the user's settings, and then the datetime is represented in UTC, then you can get off by one errors on the date components. It can be really frustrating.
For that reason I think I prefer importing them as strings - in the spirit of "what you see in Excel is what you get in OpenRefine".

For that reason I think I prefer importing them as strings - in the spirit of "what you see in Excel is what you get in OpenRefine".

👍 agree

For comparison - opening this file in Mac Numbers app interprets the time as: 31/12/1899 19:00:00
However, it only displays "19:00:00" based on a custom format applied to the cell.
I'm not an Excel expert, but a quick look suggests that this is, in fact, how Excel stores the time as well (based on https://www.exceltactics.com/definitive-guide-using-dates-times-excel/#How-Excel-Stores-Times - although this says it uses 1st Jan 1900 - so not sure why I see 31/12/1899 instead - possibly timezone conversion?)

For that reason I think I prefer importing them as strings - in the spirit of "what you see in Excel is what you get in OpenRefine".

Isn't this what https://github.com/OpenRefine/OpenRefine/pull/5397 enables?

The change in #5397 is very helpful to work around this problem indeed, but I think it is still worth discussing what the behaviour of the importer should be when the option introduced in #5397 is not enabled, for those unsupported datatypes.
Say I have a spreadsheet with numbers and dates without times: I would like to be able to import the numbers directly as numbers (because OpenRefine supports them okay) but the dates as strings (because OpenRefine does not support dates without times, at least not yet).

Sure, but the problem is that OpenRefine (and the Java date support in general) does have support for timezones, and that is creating those off-by-one errors. Those errors would not be there if we were not trying to shoehorn dates without timezones into datetimes with timezones. So I do think it is relevant for this issue.

Say I have a spreadsheet with numbers and dates without times: I would like to be able to import the numbers directly as numbers (because OpenRefine supports them okay) but the dates as strings (because OpenRefine does not support dates without times, at least not yet).


Repo name vs URL inconsistent between time periods

Hi!
Thanks for putting this together. I noticed that the repo.name and repo.url fields are not consistent between end of March 2012 and end of 2014. Specifically, it seems like repo.name just gets collapsed to the repo name and not [user]/[reponame] as it is in the URL whereas after 2014 and before 2012, repo.name is [user]/[reponame] as it is in the URL. Perhaps this could be backfilled?
Thanks

Assuming the data is there, backfilling would be a non-trivial exercise. Not impossible, but non-trivial..
We ran a large transform/refactor ~1.5 years back (see https://github.com/igrigorik/githubarchive.org/issues/112) and https://github.com/arfon/gh_archive_parser/ — perhaps that could be re-used. That said, first thing to validate would be to check if the necessary data is there for the 2012-2014 period in question.
@mrwillis do you have bandwidth to explore this?


chore(main): release iso-signatures 0.1.7

:robot: I have created a release beep boop
0.1.7 (2023-07-10)
Bug Fixes

add missing type exports and declarations (#39) (3456e89)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/hugomrdias/iso-repo/releases/tag/iso-signatures-v0.1.7 :sunflower:


[HUDI-5845] Remove usage of deprecated getTableAvroSchemaWithoutMetadataFields.

Change Logs
JIRA: HUDI-5845. Remove usage of deprecated getTableAvroSchemaWithoutMetadataFields.
Impact
none.
Risk level (write none, low medium or high below)
none.
Documentation Update
none.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@danny0405 Thank you very much for your help in reviewing the code!

@hudi-bot run

@danny0405 Thank you very much for your help in reviewing the code!


⚠ Bofrost.at has degraded performance

In e62057f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1766 ms

Resolved: Bofrost.at performance has improved in ca6ac18 after 10 minutes.


Added Node.js URL Module examples

Is your feature request related to a problem? Please describe.
Added Node.js URL Module examples
Describe the solution you'd like

Create a folder at the root level for this module example.
Add all relevant code examples in separate files.
Add a Readme like another module example
Update the main Readme to link your module example.

Additional context
Please DO NOT COPY-PASTE Code examples from the other websites/resources.

@all-contributors please add @atapas for code, infra, bug

url module added #5  has been updated to follow the description guide

@atapas Is this issue still open? if yes I would like to work on it.

Hey @saloni137 It's being worked by @VictorChukwudi
How about you create an issue for another module and contribute?


Docking a window can stop Evaluation

Using the version with the new window docking (revision 79f4fa1 on dev)
When dragging a window to the Output window in order to have it as a extra tab, the evaluation stops.
Evaluation runs again on taking the window away from Output.

This is be design. Only visible output windows are processed (evaluated) and only evaluated parts of the graph are being updated.
Is there a specific use case you need updating something that is not being rendered? Maybe sending Midi/Osc signals that don't need visual output?

aww, got it. closing the issue.


Memory usage reduction

compute_fourier_basis uses self._e, self._U = np.linalg.eigh(self.L.toarray()) this could be replaced with scipy.linalg.eigh(self.L.toarray(), overwrite_a=True) to reuse the memory used by the output of self.L.toarray().

Could also add a spectrum_only param to skip the eigenvectors as they aren't required for some stuff.

Thanks for the suggestions! Reusing the memory is definitely a good idea. Care to make a PR?
I'm less sure about a spectrum_only parameter. In general, adding parameters adds complexity. In most cases, the eigendecomposition is to be avoided altogether. Which cases are you thinking about where we'd want the eigenvalues but not the eigenvectors? Also, the computational cost isn't reduced and the memory must be available for L.toarray() anyway.

Btw, I have an implementation of graphwave (about 10 lines), if that would also be of interest.

Let's discuss that in #97.


Typos

Location: https://github.com/microsoft/sqlworkshops/tree/master/k8stobdc#-----learning-objectives
Second bullet point: "Hardware considerations for setting up a production Kubernetes Cluster on -remises". The last word should read premises.
Last paragraph, “Solution Architects, to understand how to put design an end-to-end solution” Remove “put”

Corrected. Thanks for the catch.


Remove precondition on extra node pool which prevent using windows pool with overlay

Remove precondition on extra node pool which prevent using windows pool with overlay since the feature is now GA
Describe your changes
Issue number
#511
Checklist before requesting a review

[ ] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[ ] I have passed pr-check on my machine

Thanks for your cooperation!

Hi @zioprot this feature looks like in GA now, would you please give this pr a review? Thanks!


Reformat LocalChangeUtils.kt to avoid spotless divergence

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #823
Description
Update and reformat the comment on line 113-130 so the spotlessCheck can converge
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
The alternative way for fixing this can be: Change the way how spotless handles the comment format. But Spotless is out of our control and the android-fhir project scope.
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Code health
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

feel free to merge!

@jingtang10 I think this commit is good enough for fixing this issue. One more thing I saw may not relevant is:
When I run ./gradlew connectedCheck, I got the error of
> Task :engine:connectedDebugAndroidTest
Starting 182 tests on Pixel 4a (5G) - 11

com.google.android.fhir.db.impl.DatabaseImplTest > search_date_less_or_equal_noMatch[encrypted=true][Pixel 4a (5G) - 11] FAILED
        expected to be empty
        but was: [org.hl7.fhir.r4.model.Patient@ded08ae]

com.google.android.fhir.db.impl.DatabaseImplTest > search_date_less_or_equal_noMatch[encrypted=false][Pixel 4a (5G) - 11] FAILED
        expected to be empty
        but was: [org.hl7.fhir.r4.model.Patient@4c99c4b]
> Task :engine:connectedDebugAndroidTest FAILED

FAILURE: Build failed with an exception.

I saw this with and without my change. Do you see the same thing? Any idea about this?


Fix Azure Remote Rendering tests by adding now missing dependencies and changed conversion error messages

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - remoterendering - tests

/azp run java - remoterendering - tests

So, that change isn't great. The test fixes are absolutely fine, but the test framework fixes are kinda bad.
Problem is, that the new HTTP client azure-core-http-jdk-httpclient doesn't work with Java 1.8. From the matrix config file it looks like it shouldn't be run in tandem, only with 1.17, but it somehow does anyway. So I disabled Java 1.8 tests for now and will contact the person that added the azure-core-http-jdk-httpclient tests to see if we can find a better solution.
I would still go forward with this PR, as we are currently testing nothing and there is a risk of missing breaks in the releases for normal ARR (not the java SDK itself).


💡 Feature Request - Enable service health alerts on provisioned subscriptions

Describe the solution you'd like
Enable service health alerts on provisioned subscriptions to enable better workload reliability through various alerts generated from service health
Describe alternatives you've considered
N/A
Additional context
Add any other context or screenshots about the feature request here. 📷

Im assuming that the ALZ AMBA guidance here would address the Service Health requirement?

Im assuming that the ALZ AMBA guidance here would address the Service Health requirement?

Yes, good point for customers we are using AMBA and applying the policies at the management group level


Add web server support to save NL page feedback

Thanks. Could you clarify the datastructure sent?

Will update with the client side PR


Coffeescript support

Mocha allows me to use CoffeeScript (v2) files for my unit tests with:
mocha tests/unit/*_tests.coffee --compilers coffee:coffeescript/register

Would it be possible to have a similar option in codecept ?
PS: Thank you for your great framework that deserves more traction.

There is the same compilers option for codeceptjs run. Did you try it?

I tried but it doesn't even recognize CoffeeScript function arrows:
$ codeceptjs run --compilers coffee:coffeescript/register

Unexpected token >

/home/laurent/myproject/tests/e2e/layout_tests.coffee:3
Before((I) ->
            ^
SyntaxError:
    at createScript (vm.js:53:10)
    at Object.runInThisContext (vm.js:95:10)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at /home/laurent/.config/yarn/global/node_modules/mocha/lib/mocha.js:222:27

My CS code is ok because I can run my CS tests if I compile them in a directory (.js) like so:
coffee -b -o ./tests/e2e/.js -c ./tests/e2e/*.coffee && codeceptjs run ./tests/e2e/.js --config ../codecept.json

(For page objects I also had to declare I before module.exports, something you hardly do in CS, but that's fine.)
That compilation directory workaround is quite dirty…

Yes, I understand. Can you look around into source code to find how this can be solved?
Anyway, CodeceptJS uses Mocha so the implementation for compilers should be pretty easy to add.
I don't have much time to work on this feature but as you I'd really like to see CoffeeScript support.

Sure, I will try to look around asap.

I had a look but it's not obvious… Something to do with commander.js ?

Actually it seems that all mocha command line options other than --reporter are not taken into account. For instance -C (forcing no colors) has no effect.

I closed #538, I was using 0.5.1 and (some) mocha options seem to work in 0.6.0.
Maybe the problem is with mocha options that take an argument? (such as --compilers)

Issue still here with CodeceptJS v1.0.2.


build: run the different actions in parallel

My target here is to make the build command a little faster by running all the build actions that create the apk content (smali, resources, copying files) in parallel.
Here is a before/after of the different threads and CPU profile as measured by IDEA Profiler:

Notes:

Doing the actions in parallel doesn't seem to collide in any of my tests and the output files seem pretty separate but maybe i'm missing something.
I used parallelStream instead of the ExecutorService strategy used in baksmali as it appeared simpler to me but I'm not very well versed in the Java ecosystem so this is very open to suggestions
I've preserved BrutException by rethrowing instead of wrapping but i'm not sure that it is what should be done.

Thanks for PRs. Caught me on a vacation weekend, I'll peek in detail on Tuesday.

Oh no problem, I don't do java most of the time so i'm happy to follow whatever style you intend for your codebase. I'll fix that.

thanks. I'll take this for a spin locally this weekend.

Thanks for kick starting this effort. The rewritten method was merged this morning by another contributor - https://github.com/iBotPeaches/Apktool/commit/81aae6936a4d0228e9b10aaeffaaaeda04eaf81c
Closing this one.


Fix race conditions related to building embarkjs, make web3 connector an internal plugin

This PR includes refactoring performed by @iurimatias and @andremedeiros, with help from @michaelsbradleyjr.  It replaces PR #1661.

I've just tried this branch locally. Started embark blockchain in a separate process, then embark run in our demo template:
pid 95668 listening on /var/folders/rh/8228xgcd1lx3srcl_15y236r0000gn/T/embark-8270f318/embark.ipc
/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/.embark/chains.json file not found, creating it...
ready to watch file changes
Cockpit UI available at http://localhost:55555
IPFS node not found, attempting to start own node
Starting ipfs process
Webserver available at http://localhost:8000
Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-ens'
Error running embarkjs code:  Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-ens'
Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-whisper'
Error running embarkjs code:  Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-whisper'
Unknown messages provider
Error running init console code:  Unknown messages provider

Okay, even with the correct branch, I can still confirm that this is failing:
Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-web3'
{ VMError: Cannot find module '/Users/pascalprecht/projects/embark/embark/dapps/templates/demo/embarkArtifacts/modules/embarkjs-web3'
    at _require (/Users/pascalprecht/projects/embark/embark/node_modules/vm2/lib/sandbox.js:246:25)
    at /Users/pascalprecht/projects/embark/embark/packages/embark-code-runner/dist/vm.js:5:28
    at Object.<anonymous> (/Users/pascalprecht/projects/embark/embark/packages/embark-code-runner/dist/vm.js:22:99)
    at NodeVM.run (/Users/pascalprecht/projects/embark/embark/node_modules/vm2/lib/main.js:419:27)
    at VM.doEval (/Users/pascalprecht/projects/embark/embark/packages/embark-code-runner/dist/vm.js:96:24)
    at CodeRunner.evalCode (/Users/pascalprecht/projects/embark/embark/packages/embark-code-runner/dist/index.js:126:13)
    at events.request.code (/Users/pascalprecht/projects/embark/embark/packages/embark-code-runner/dist/index.js:102:12)
    at EventEmitter.events.setCommandHandler.cb (/Users/pascalprecht/projects/embark/embark/packages/embark-code-generator/dist/index.js:101:7)
    at EventEmitter.listener (/Users/pascalprecht/projects/embark/embark/packages/embark/dist/lib/core/events.js:81:8)

Getting to the bottom of this now.

I did a full yarn:reboot and still had the error.
After debugging a little, the error all of a sudden disappeared. I'm not sure if this means I missed something the whole time, or if there's still a race condition that's just super hard to reproduce (which I wouldn't be surprised of)

embark test is indeed broken with this PR.
Doesn't output anything and just hangs. Looking into this now.

Fixed hanging tests with  https://github.com/embark-framework/embark/pull/1680/commits/ee5ad0d536f6a54f139e4e1742049866f3905dff and https://github.com/embark-framework/embark/pull/1680/commits/123bb5e0ce3eafd77ba4d09239afd73d8305b61c
Those probably should be squashed into the second commit of this PR.

Added https://github.com/embark-framework/embark/pull/1680/commits/4421ca1d245ed66c5669a7ccedea111e7473e20f which fixes another bug in this PR.

This PR branch (refactor/connector-web3-3) has just been reset with the changes in refactor/connector-web3-4, which came at a long day of refactoring with @jrainville (primarily), @iurimatias, @andremedeiros, and @michaelsbradleyjr. Additional tests remain to be done, and the commits will be cleaned up prior to merge, if/when that occurs.

Testing has finished with monorepo embark and locally-released production embark. Race conditions related to embarkjs code/symlink generation seem to be eliminated. WIP commits have been squashed appropriately, a commit has been added updating the docs, and this branch is up-to-date with master.


x/crypto/ssh: msgNewKeys interpreted too soon

"We've also run into a different issue during the kex/handshake.
panic: ssh: no key material for msgNewKeys
goroutine 31868301 [running]:
panic(0x7ce020, 0xc42414c260)
/usr/local/go/src/runtime/panic.go:500 +0x1a1
bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh.(*connectionState).writePacket(0xc422774068, 0xc4218a8480, 0xa90080, 0xc42000c2d0, 0xc420010790, 0x9, 0x9, 0x0, 0x0)
/go/src/bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh/transport.go:163 +0x226
bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh.(*transport).writePacket(0xc422774000, 0xc420010790, 0x9, 0x9, 0x0, 0x0)
/go/src/bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh/transport.go:144 +0x77
bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).pushPacket(0xc422326140, 0xc420010790, 0x9, 0x9, 0x0, 0x0)
/go/src/bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh/handshake.go:211 +0x51
bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).kexLoop(0xc422326140)
/go/src/bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh/handshake.go:291 +0x303
created by bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh.newServerTransport
/go/src/bitbucket.org/bitbucket/conker/vendor/golang.org/x/crypto/ssh/handshake.go:126 +0x227
This is on a server running on golang/crypto@41d678d
We were previously running golang/crypto@ca7e7f1"

Ah, thanks for opening this. I wasn't sure if I should open a new issue because it also seemed related to the kex rewrite. Let me know if there's any additional information you need to help debugging this.

I took a look at this , but it's puzzling.

In handshake.go line 291, we are writing a packet coming from pendingPackets with a msgNewKeys.

pendingPackets is only populated from handshakeTransport.writePacket, and we check that the packet type is not msgNewKeys at the top of the function.

Can you confirm that your code runs cleanly under the race detector?

We run all our tests with the race detector and haven't had any complaints from that lately.
What would happen if a client sends a kex with FirstKexFollows set? I can try to test that (using dropbear), but it's just a guess at this point.

After looking through the code, I think the most likely reason is that the error from prepareKeyChange is ignored which would mean that the key change data wouldn't be set.

good catch, yes the error check is certainly to blame for the panic, but then what error does it print?

ok, so
	t.pendingPackets = t.pendingPackets[0:]

looks plausible in codereview, but is actually a pretty dumb thing to do. I wonder if we should find this automatically with go vet.

https://go-review.googlesource.com/c/36056/1

Fixed in https://go.googlesource.com/crypto/+/641ab6b32049cabca26c30bf27baaae445bf4175


enhancement: Improve logging of SQL statements

These shouldn't be multiline logs

This should have been fixed recently, will validate and then close this with a link to the commit.

This was added in this PR #76


Apps dependencies

updating dependency list before releasing (release needed since #29 fixed master)

@vrabaud @severin-lemaignan  FYI: releasing nao_robot to fix upstream nao_apps

+1

+1


Error loading DLL, unable to find the specified module

Other DLLs required by the DLL are already in the same file directory.
ERR:unhandledRejectionError: Failed to load shared library:The specified module could not be found

I have the same error with koffi.load.
Can it be linked to a corrupted DLL ? I have all the DLLs in my folder but for some reason it fails for one of them.
Or can it be related to path containing special characters ? Some user names has accents or dash in their names for example

Can you try with Koffi 2.6.9 or Koffi 2.6.10 and report to me if it works better?

Closing this issue, because it might fixed.
Don't hesitate to comment if that's not the case.


Allow to continue after checking using an option

With the following config, the task checks missing dependencies, eventually install them and continue running the end of the grunt task.
options:
packageManager: 'npm'
install: true
continue: true

I implemented this logic in this way because if a user loaded all their tasks and then runs grunt-check-dependencies (a common scenario, especially with plugins like load-grunt-tasks) then after updating packages still the old tasks will be invoked as they're already in memory.
So if I'm going to land this I'd like this option to be described as advanced, I'd like to have a mention that if you don't know all the consequences then don't enable it and I'd like to have the scenario I described above written in the README with an advice how to use it properly.
Do you want to do it? :)

Ok I understand. Do the modifications look sufficient?

Thanks and sorry for such a long wait! I've merged it and released 0.10.0.

Thank you too!


Implement support DeepL Write

Can you please implement support for https://www.deepl.com/write?

Hi @jirutka,
unfortunately DeepL currently only provides a translation api. There is no api for DeepL writing yet.
However, as soon as this is available, I will consider its implementation.
I hope you enjoy the current deepl integration!
Best regards
Sören


Embed templates inside dd agent binary

What does this PR do?
It embeds templates files into the agent binary at compilation time.
Motivation
It makes the agent binary able to run agent status without requiring
to the original template file.
Additional Notes
It relies on go-bindata that has been added to the dependencies.

I wonder if we could also do this for the html files we use in the agent launch-gui command? I guess not because the embedded browser component needs to be able to find them?

IMHO that would worth trying but in the meantime we have a windows issue likely related to this change. I  will try to follow up on that topic.


Black samples

Hello,
Using timesteps = 1000, sampling_timesteps = 250, at epoch 3 or so, it seems generated samples are complete black outputs whereas epoch 1 and 2 produces at least visible samples.
Did you (or anyone) encountered this issue before ?
Thank you

I have also encountered this problem.Could you tell me how to deal with it?


ComponentHoldingPacket Enhancements

Some packets implementing ComponentHoldingPacket do not consider every component they're holding.

Made EntityMetaDataPacket#components() also include SetSlot-type entries
EntityEquipmentPacket now also considers the lore of equipment items
Added a missing null-check in ChatPreviewPacket

Commit 73b4fa47917c3bce78f9d3baa1cd0f3cc1169644 is a bit controversial as I'm not really sure what the aim of these methods really is. If they're only there for Adventure translation then this commit is pretty counter-productive. But I myself for example use these methods to implement my own translation-system into Minestom. This still wouldn't justify this commit as null values are skipped by translation-systems, but I tought maybe other developers can take advantage of these changes.

@TheMode is there anything wrong with this PR which I should fix?

My bad, seem good to me. Though we will likely to think of a better solution for items, I highly doubt the current approach to be efficient


is there a way to trigger action with fields? or just action?

the button can trigger events, those events  can have listeners, those listeners can share the same code  your Nova actions are using. But currently there is not a way to run an action. Will add it eventually.

first thanks for quick response, love the package
i would like to help you
you can point me to a reference on how to add an action fields to the button or re use an action class already made by me for example,
i saw your source code but i could not figure out on how to do that , or exactly, where to put changes
i saw you have a title and the body for the confirmation and i saw the vue code but couldnt quite figure out , i think the best course of action is to reuse the action classes and get theire data,  like fields, insted of something else

https://github.com/dillingham/nova-button/issues/18


Get Started button not proper in mobile view

Description
The "Get Started" button is out of allignment in mobile view, "Started" text is not inside the button
Expected Behavior
"Started" text to be properly alligned inside the button

Please assign me this issua


ability to capture errors from exporters

Is your feature request related to a problem? Please describe.
It's not clear to me how one could programmatically capture errors from an exporter, e.g. when the URL or authentication is misconfigured or the endpoint is down.
You can set a logger with diag.setLogger() to log errors which is better than nothing, but without this there will be nothing to indicate a error condition.
Describe the solution you'd like
Exporters could provide an event or callback that gets invoked when there's a fatal error so the application or middleware can act accordingly. Depending on the circumstance, it might want to ignore the error, disable or backoff the exporting, or completely crash the program.
Describe alternatives you've considered
Implementing a DiagLogger that acts when it is asked to log an Error could work, but it seems like a misuse of a Logging interface and places the behavioral logic far from the caller.
I also believe this would be global for all errors in the API, not just errors from an Exporter, or a specific Exporter.
Additional context
Apologies in advance if there's some existing solution for this problem, as I'm a bit new to this implementation.

Hi,
Any feedback or guidance on this issue?

@nferch to capture errors programmatically using OpenTelemetry, you can create an exporter class that integrates with OpenTelemetry's tracing capabilities. This implementation will allow you to track errors when exporting data and invoke appropriate callbacks based on the circumstances.
Below is an example code that demonstrates this concept:
const { trace } = require('@opentelemetry/api');
class Exporter {
constructor(url, auth, errorCallback = null) {
this.url = url;
this.auth = auth;
this.errorCallback = errorCallback;
this.tracer = trace.getTracer('exporter');
}
async exportData(data) {
    const span = this.tracer.startSpan('exportData');

    try {
        // Simulate a data export attempt
        if (!this.url || !this.auth) {
            throw new Error("URL or Authentication is misconfigured.");
        }

        // Simulate a network error
        if (this.url === "http://down.endpoint") {
            throw new Error("The endpoint is down.");
        }

        // Simulate successful data export
        console.log(`Data exported successfully to ${this.url}.`);
        span.setStatus({ code: 0 }); // OK

    } catch (error) {
        span.setStatus({ code: 2, message: error.message }); // Error
        this.handleError(error);
    } finally {
        span.end();
    }
}

handleError(error) {
    console.error(`Error occurred: ${error.message}`);
    if (this.errorCallback) {
        this.errorCallback(error);
    }
}

}
// Example error handling functions
function ignoreError(error) {
console.log("Ignoring the error.");
}
function disableExporter(error) {
console.log("Disabling the exporter due to error.");
}
function crashProgram(error) {
console.error("Crashing the program due to fatal error.");
throw new Error(error.message);
}
// Usage example
const url = "http://down.endpoint";  // Change this to test different scenarios
const auth = "my-auth-token";
// Set the error callback based on the desired behavior
const exporter = new Exporter(url, auth, crashProgram);
// Attempt to export data
exporter.exportData({ key: "value" });
Explanation:

OpenTelemetry Integration: The code uses OpenTelemetry's tracing API to create a span for the exportData operation, allowing you to capture traces and errors.
Exporter Class: This class contains methods for configuring the exporter, exporting data, and error handling.
exportData Method: This method simulates exporting data and throws errors based on misconfiguration or simulated network conditions. It tracks the status of the operation via spans.
Error Handling: The handleError method logs the error and invokes the specified error callback.
Error Handling Functions: You can define various functions to handle errors differently, like ignoring them, disabling the exporter, or crashing the program.
Usage Example: An instance of the Exporter is created with a potentially faulty URL to demonstrate error handling. You can modify the URL or authentication details to test different scenarios.

Note:
To use this code, you need to have OpenTelemetry set up in your project. Make sure to install the necessary OpenTelemetry packages, such as @opentelemetry/api, and configure the OpenTelemetry SDK as required for your application.


{AzureWebApp} Documentation for "--slot-setting" in "storage-account"

Documentation for "--slot-setting" in "storage-account" for webapp should be made clear.
fixes Azure/azure-cli#27343
--slot-setting
With slot setting you can decide to make BYOS configuration sticky to a slot, meaning that when that slot is swapped, the storage account stays with that slot.

default value: False

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

AzureWebApp

@StrawnSC Could you please help review the app service related PR?

@anthonychu Could you please review this PR once you get a chance ?

/azp run

/azp run


Document font requirements

Please forgive my ignorance but I'm probably missing something very obvious: The icons don't work at all for me.

What's weird is that I can not even see any icons in the browser (e.g. on the project's start page on github):

Could you maybe add some notes on which font is required to make this work?
OS: Linux Mint
Neovim 0.5.1

I understand your confusion, please take attention to this:
    -- can be either 'default' (requires nerd-fonts font) or
    -- 'codicons' for codicon preset (requires vscode-codicons font)

in configuration example. There is also an issue #18 to have preset which doesn't require extra font and awesome input from @fenux, however I didn't have a time to properly test this approach.

Thanks. I've seen this comment but somehow missed its meaning. Maybe a short introductory note would still be helpful.
Anyway this can be closed then.


Apply instantaneous velocity on D&D release

[ ] Get position from previous frame
[x] Get delta time between frames
[x] Get vector from old position to new position
[ ] Get magnitude of difference vector and apply delta to calculate instantaneous velocity

In the pendulum-scene branch I have a sample implementation for throwing the ball in falling.js


dist folder is missing for version with Events

Hi! I am interested in the new version of perfect-scrollbar, that includes the events. However, I couldn't find it for download, only the sources. I checked the examples and it is trying to include the js files from a dist folder, but that folder is missing from the repo.
Are you planning to release the .min.js files with the events soon? Thank you!

@pmtarantino Currently there has not yet been an official release with the events implemented. I'd still like to do some further testing and possible optimisation before I give the green-light for @noraesae to release.
Is this urgent? I can generate the .min.js files if you need it soon.

Hi Daniel, if you could generate the .min.js would be great because we are needing it to keep working on this project. We are using the jQuery plugin, by the way.

Just sent you an email with the files.

Thank you Daniel, you are the best :) It worked like a charm!


debt: remove dist/ from VCS. fixes #481

as per the discussion in issue #481

closing in favor of  #549 :)


No icon on tray for Linux

At least, running under Mate (Gnome 2.x fork). But should be the same for another Desktop Environment?
Actually, there is an icon, but not the brackets one, a pseudo window icon (white with blue bar)

thanks @MadcapJake to the less savvy you need to create file on your desktop with a name
bracket.desktop
and add this to it:
[Desktop Entry]
Name=Brackets
Type=Application
Categories=Development
Exec=/opt/brackets/brackets %U
Path=/opt/brackets
Icon=brackets
MimeType=text/html;
save the file.


@key directive doesn't get applied on entities of exported SDL

@key directive doesn't get applied on entities even when federation is enabled.
This is the following code example that I tried.
#[derive(Debug, Clone, SimpleObject)]
pub struct User {
    pub id: &'static str,
    pub name: &'static str,
}

#[Object(extends)]
impl Query {
    pub async fn users(&self) -> Vec<User> {
        User::all()
    }

    #[graphql(entity)]
    pub async fn find_user_by_id(&self, #[graphql(key)] id: ID) -> User {
        User::find_by_id(id)
    }
}

The exported SDL for the above User type is
type User {
    id: String!,
    name: String!
}

whereas what I expect is
type User @key(fields: "id") {
    id: String!,
    name: String!
}

Let me know if I am missing something..

Federation will use the query { _service { sdl } } to get SDL, the SDL obtained by Schema::sdl method is not provided for Federation.
println!(
        "{}",
        schema
            .execute("{ _service { sdl} }")
            .await
            .into_result()
            .unwrap()
            .data
    );

Output:
{_service: {sdl: "\n\n\n\nextend type Query {\n\tusers: [User!]!\n}\n\n\ntype User @key(fields: \"id\") {\n\tid: String!\n\tname: String!\n}\n\n"}}

@sunli829 Thanks.. :)


feat(validate): add lint warnings

Closes https://github.com/prisma/prisma/issues/16441
I explicitly set getConfig's ignoreEnvVarErrors: false, where it was implicit for better visibility

Checking the failures 👀

Note in a next PR we want to disable warnings when PRISMA_DISABLE_WARNINGS is truthy https://github.com/prisma/schema-team/issues/373


HBASE-23688 Update docs for setting up IntelliJ as a development environment

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 57s
master passed

+0 :ok:
refguide
6m 21s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 26s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
6m 16s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

26m 34s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1041/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1041

Optional Tests
dupname asflicense refguide

uname
Linux 5e92215947f6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1041/out/precommit/personality/provided.sh

git revision
master / 499ff32f00

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1041/1/artifact/out/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1041/1/artifact/out/patch-site/book.html

Max. process+thread count
86 (vs. ulimit of 10000)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1041/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


[SwiftASTContext] Fix printing for Obj-C enum.

The value is not an increasing number [starting from zero] as
it happens for the pure no-payload swift-enum, they can have
arbitrary values.
rdar://problem/51678061

@swift-ci test

Addressed Adrian's comments.

@swift-ci test


ci: expand severity policy for CVE detection

:tada: This PR is included in version 3.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update CODEOWNERS

This introduces a more fine-grained codeowners for certain files. Removing the * for subdirectories, as bridge/* has a different meaning than just bridge/ (includes nested directories and files).
Also, added another reviewer for Keptn Bridge

Codecov Report

Merging #1978 into master will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1978      +/-   ##
==========================================
+ Coverage   33.39%   33.53%   +0.13%
==========================================
  Files         146      146
  Lines        9354     9354
  Branches      129      129
==========================================
+ Hits         3124     3137      +13
+ Misses       5810     5795      -15
- Partials      420      422       +2

Flag
Coverage Δ

#moduleA
35.22% <ø> (ø)

Impacted Files
Coverage Δ

distributor/cmd/main.go
58.88% <0.00%> (+1.11%)
:arrow_up:

platform-support/openshift-route-service/main.go
35.00% <0.00%> (+7.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4006b6f...c7a811e. Read the comment docs.


PR doesn't support templates on .github repository

Current version work fine with PR templates in the same repository.
Many Companies work with unified templates on the ".github" repository located commonly at https://github.com/<username>/.github
I can see this working as detecting that repository if no template is located in current repository. Or as a configuration where the user can define the path to the PR template file
settings sample:
{
  "pr_template_url": "https://github.com/GuillermoMarcel/.github/blob/main/PULL_REQUEST_TEMPLATE.md"
}

I would also like to see this implemented.


x1082 As TS (Katy) I would like to record if the RNA extraction is manual or automated and if automated which machine is being used, for tracking and billing purposes

Dropdown list to state Manual or automated Plus machines (edited on config) - Manual, Automated - EZ2,  Automated - QiCube
same information for all the labware scanned in
Default on all dropdown to be blank so lab users have to select option
Column to be added to Extract_view
Story Size: Medium

@khelwood can you add the equipment to the Extract_view please?

@KatyTudor OK that is updated on test.


Not able to extract data from captcha

Hi There,
Your script is awesome, it is able to resolve many captchas but I have a capctha for which script is not returning correct string from capctha. I am attaching that capctha. Please have a look.

Create a bitmap of the showing font in the image and change the captcha letter count to 6.

@abhinavpathak14 have you created a mask as @reshadman pointed out? if yes, can you paste it here?

@ptigas
Hi
I testing with my mask and part of mask but its not worked.
can  you help me please.
this is my mask:

and this is part crop of mask that I used for test.jpg

but the result was just : 0125c
also set alphabet="0123456789abcdefghijklmnopqrstuvwxyz" in captcha_decoder.py
can you help me pleas

@ptigas Can you please share your parameters for creating mask. I am facing trouble with spaces too.


remove the xwaretech domains

I control these domains and while they were pointed for some years to Mailinator, they are not anymore.

Whitelisted in https://github.com/disposable/disposable/commit/0d3fd08d7ed078735c127347487159752ce18803


Allow to disable depth camera + move parameter node to tango_common

Allows to enable/disable the depth camera using Settings Activity or the ROS parameter server.
The PR also moves the parameter node to the tango_ros_common module since it is written in a generic way and can be reused in other Tango-ROS apps.

Perhaps we can do the same for color images? I'm guessing this could also save some battery power.

+1
On May 5, 2017 8:21 AM, "Marieke Copejans"<EMAIL_ADDRESS>wrote:

Perhaps we can do the same for color images? I'm guessing this could also
save some battery power.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Intermodalics/tango_ros/pull/265#issuecomment-299493985,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYbcD8JFehU_c7MtGWy6c3ev2b7s1J9ks5r2z4_gaJpZM4NSBRi
.

@mcopejans I will make a new issue to do the same for color image.

Currently implemented like other settings, but needs fix described here: https://github.com/Intermodalics/tango_ros/issues/268


Improve settings sync trouble shooting

Data is very important to trouble shoot settings sync issues, especially logs (current and previous sessions) and other data. Currently Settings Sync data activity views (local & remote) provide very good information to diagnose issues. Sometimes it requires to ask more information. So would be adding a troubleshoot view that provides

All settings sync logs
Last sync resource states

and actions to download them

To verify:

Make sure settings sync is enabled
Run command Settings Sync: Show Synced Data
Enable Troubleshoot view from ... menu
Make sure you can access settings sync logs and last sync states.
Also verify it in web.

Please wait until following fix is available to verify this
https://github.com/microsoft/vscode/issues/127480

On Windows:

I'm not sure whether the file is actually gone, or if it's somewhere else?

Are you seeing the same for all files or just for that particular entry?
Can you please open the logs folder on the disk and check?

The log folders exist, but the log file for that entry doesn't.
The log files for the later entries such as the one labelled Current in the picture above exist. Maybe it's amore recent change?

Yea same, new logs are fine, old ones are not. I was a few versions of Insiders behind on my desktop before this morning.
Works fine otherwise, so I will leave the label.

I know why, it seems I am assuming the log files exist always. It might happen that the sync log file is not created due to some reasons. So I shall better check and add it to the list.


Any advise on the config for the MC server in a VM?

I want to run my MC-server on a debian VM in my ProxMox server

Minimum version # for MC
Can it be headless? UI needed?
If headless are there limitations?
Which one? jriver-x11vnc versus jriver-xvnc
Any other things? Like choice of audio card?

best results are achieved with MC32 or higher as that provides the MCWS Browse/Rules call which is used to automate detection of playlists for display in HA, earlier versions should work fine though. I only actively test against latest though.
I don't believe MC on linux can run truly headless, I don't run it like this though so don't know details, there are some posts on the MC linux board from people who aim for this
N/A
see https://yabb.jriver.com/interact/index.php?topic=125124.0
depends on your needs and what type of interface you want, best to ask on interact if unsure

Qs 2 onwards are better handled on interact so suggest posting there


Old content in Crowdin due to combination of sections?

See this thread: https://crowdin.com/translate/microbitorg/6686/en-ja#333360

I'll look at this one on Monday. The sync doesn't delete files so we should carefully review and see if anything needs deleting.

The diff just shows intentionally non-translated content (e.g. the Python module - Reference mapping metadata).
I'll revisit the Crowdin report.

File is "Decreasing variables". It's still in the CMS but it's unreferenced so it's not part of the toolkit in practice. We need to review for unreferenced toolkit topic entries and similar and delete them. I'll prep a list for Giles to review. Then we'll have the problem I thought we had in the first place, which is the sync won't delete them. But the first step is to remove them from the CMS.

*[ _type == "toolkitTopicEntry" && language == "en"]
  {_id, "refs": count(*[ references(^._id) ])}
    [ refs == 0 ]
      ._id

This query against the apps Sanity dataset shows 43 documents with no references. These documents cannot be part of the Reference docs as it's a tree of references. Giles and I reviewed a sample of them and he confirmed that they are documents left over from modifications made to the Reference documentation based on past feedback.
There are no unreferenced topics, just topic entries.
I'll work to remove them from the CMS and Crowdin today.

Notes on deletion:
ids-to-delete.txt
The sync task won't run again before tomorrow morning so no need to worry about it interferring.
Take a CMS backup first.
Check for no references to the IDs in English documents:
cat ~/ids-to-delete.txt| while read id; do grep -R "$id" documents; done | egrep -v '_ja|_zh|_es|_fr|_ko|_crowdin'

Note that we also exclude the crowdinSourceDetails document.
Find and delete all variants of the documents, including translations and crowdinSourceDetails:
cat ~/ids-to-delete.txt| while read id; do find . -name "$id"'*'; done | while read n; do rm "$n"; done

Then import the backup into the apps dataset.
Then take a CMS backup.
Then think about Crowdin removal.

Worked through deleting these from Crowdin manually with Rob. Document count in Crowdin now matches the CMS at 106 topic entries.
I think we're all done here. I'll check again after the Crowdin sync in the morning


packet time ordering V2

looks like somthings loose with the 20G v2 packet ordering. guessing there`s a bit thats not being set or drained correctly. causes the opposite packet ordering.. somthimes e.g. ~ 6 ns backwards time delta

same problem exists on f80. suspect its something in the logical pipeline when it arb the incoming ports

capinfos2 was miss calculating the first packet as a time diff
stream_cat does not use the short sort buffer, thus outputs in the raw order. due to arbing this can be slightly off by 1-2 packets.
another bug in capinfos2 was showing incorrectly negative timestamps.. core code is working fine has been for many years.


Service configuration should allow automatic token refresh via refresh token

At the moment service configuration only allows to setup a silent refresh for the token(s).
It should alle to configure token refresh using refresh tokens, too.

Maybe everything is already okay. And maybe it has to do somethin with #1056.
I was told there are two ways of doing the refresh:

Silent refresh
Refresh by using the refresh token.

What I expect is to allow the configuration of either type of refresh without code. Only by setting the authConfig.
authConfig allows the automatic configuration of "silent refresh". It is not clear if this works for refreshs using the refresh token, too.


lib/cmsis_rtos_v1: Check if osKernelStart() is called from ISR

Check if osKernelStart() is called from ISR and return error code
appropriately.
Signed-off-by: Spoorthi K<EMAIL_ADDRESS>

Codecov Report

Merging #9678 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #9678      +/-   ##
==========================================
- Coverage   52.31%   52.31%   -0.01%
==========================================
  Files         212      212
  Lines       25937    25939       +2
  Branches     5589     5590       +1
==========================================
  Hits        13569    13569
- Misses      10122    10123       +1
- Partials     2246     2247       +1

Impacted Files
Coverage Δ

lib/cmsis_rtos_v1/cmsis_kernel.c
80% <33.33%> (-20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b80998...f3103c3. Read the comment docs.


Exposito-Alonso 2018

Reference
doi or URL: 10.1371/journal.pgen.1007155

Actually this paper didn't study metagenomic content but was reutilised for that purpose in #118