chore(noir): Release 0.11.0

:robot: I have created a release beep boop
0.11.0
0.11.0 (2023-08-31)
⚠ BREAKING CHANGES

Update to acvm-backend-barretenberg v0.12.0 (#2377)
abi: Replace struct name with fully qualified struct path (#2374)
Remove keys from preprocessed artifacts (#2283)
nargo: Remove -p short flag from the --program-dir flag (#2300)
nargo: Replace --contracts flag with contract package type (#2204)
nargo: remove flat_witness feature flag (#2208)
nargo: Require package type be specified in Nargo.toml (#2134)
Allow specifying new package name with --name flag (#2144)
nargo: Remove unused flags on LSP command (#2170)
Support workspaces and package selection on every nargo command (#1992)
nargo: Require package names in Nargo.toml files (#2056)
Update to ACVM 0.21.0 (#2051)
Drop support for the legacy SSA (#2049)
nargo: Rename nargo gates to nargo info (#2038)
nargo: Default to new SSA code for compilation
ACIR bytecode encoding with Base64 (#1935)
Update to ACVM 0.18.1 and implement missing brillig blackboxes (#1914)
ssa_refactor: Add Slices (#1728)
nargo: Make proving and verification keys optional (#1880)
update to ACVM 0.16.0 (#1863)
Update to acvm 0.14.0 (#1594)
update to ACVM 0.13.0 (#1393)

Features

ACIR bytecode encoding with Base64 (#1935) (347cfc4)
acir_gen: RecursiveAggregation opcode and updates to black box func call generation (#2097) (5cb8166)
Add assert_constant (#2242) (a72daa4)
Add assert_eq keyword (#2137) (b467a2d)
Add deprecated attribute (#2041) (9e2cf6f)
Add nargo build as alias for nargo compile (#1940) (13618d4)
Add nargo init command (#1859) (2d87c87)
Add Option<T> to noir stdlib (#1781) (920a900)
Add test(should_fail) attribute for tests that are meant to fail (#2418) (74af99d)
Add ability to create a proof for a workspace member using nargo prove -p {crate_name} (#1930) (266126f)
Add Acir debug information (#1864) (5ff8b53)
Add basic benchmarking (#2213) (c8fe617)
Add full call stacks to runtime errors (#2310) (9004181)
Add multi-line comments (#1936) (cfb1765)
Add signed division (#1831) (d0894ad)
Add slice append (#2241) (90c5d18)
Add support for bitshifts by distances known at runtime (#2072) (b0fbc53)
Add support for nested arrays on brillig gen (#2029) (8adc57c)
Add support for slices of structs and nested slices in brillig (#2084) (620517f)
Add syntax for specifying function type environments (#2357) (495a479)
Add to_radix and to_bits support to brillig gen (#2012) (3eef41c)
Add trait definition representation in DefCollector and HIR (#2338) (406a595)
Add unit literals and unit types to parser (#1960) (ea80de5)
Adding internal keyword (#1873) (7a85493)
Allow arrays of arbitrary types in the program ABI (#1651) (811ede1)
Allow calling higher-order functions with closures (#2335) (75fd3e0)
Allow main to be a brillig function (#1861) (1330a2a)
Allow returning nested arrays from brillig (#2047) (4378bb8)
Allow shadowing by default (#2000) (88a4f74)
Allow specifying new package name with --name flag (#2144) (e932599)
attributes: Enable custom attributes (#2395) (179611b)
Avoid unnecessary witness assignments in euclidian division / bound constraint  (#1989) (c23257d)
Basic implementation of traits (#2368) (df9f09e)
brillig_gen: Return slices from foreign calls (#1909) (6fa3144)
brillig: Added locations for brillig artifacts (#2415) (3771e52)
brillig: Foreign calls with dynamic-size objects (#1705) (fe7bb99)
brillig: Implemented blackbox functions (#1788) (f9f38de)
brillig: Wrap brillig fns to be top level (1330a2a)
ci: Update noir to build wasm with a nix flake file (#1208) (2209369)
Compile to brillig reachable acir fns (#1919) (2b4237d)
Create equivalence relationships for intermediate witnesses from multiplication (#2414) (cc2a2d8)
Defunctionalization pass for ssa refactor (#1870) (1d5d84d)
driver: Remove Driver struct and refactor functions to take Context (#1867) (8895853)
driver: Remove Driver struct and refactor functions to take context (8895853)
Drop support for the legacy SSA (#2049) (3f33e44)
Dynamic arrays for experimental-ssa (#1969) (08d199a)
Execute brillig opcodes with constant inputs at compile-time (#2190) (79af8e6)
Format strings for prints  (#1952) (3c82721)
frontend: Aztec syntactic sugar (feature flagged) (#2403) (a894a6e)
Implement parsing of traits (#1886) (3ba1e72)
Implement references in brillig (#1901) (3a078fb)
Implement traits - parser support #2094 (#2230) (589f173)
Implement type aliases (#2112) (ce94cb4)
Improved error message for unexpected return type (#2302) (d7e1e65)
Include struct names in ABIs (#2266) (9824ca5)
Initial implementation of slices in brillig (#1932) (ea47936)
Issue warning for signed integers (#2185) (1be1bcc)
lsp: Add Compile code lens for main function and contracts (#2309) (5fe69c6)
lsp: Add Execute code lens for main functions (#2330) (5aa59e0)
lsp: Add a codelens that runs test when clicked (#1835) (5d64f8a)
lsp: Publish diagnostics on file save (#1676) (c53bfc8)
Make array indexes polymophic integers (#1877) (0fc93fa)
Make arrays and slices polymorphic over each other (#2070) (ef91286)
Make for-loop range be a polymorphic integer instead of just Field in unconstrained functions (#1583) (77fba56)
Make use of type information when serialising inputs (#1655) (310368d)
Multiple item imports in use statement (#1466) (1dcd2ee)
nargo: Add --exact flag to nargo test (#2272) (1ad9199)
nargo: Add --workspace flag to run commands in every package (#2313) (d6deb0c)
nargo: Add lsp command to start server that reports no capabilities (#1560) (e28529d)
nargo: Add support for contracts in nargo check (#2267) (3d1b252)
nargo: Allow user-specified file for prover inputs instead of Prover.toml (#1531) (91cbec6)
nargo: Default to new SSA code for compilation (ce37718)
nargo: Replace --contracts flag with contract package type (#2204) (968e12c)
nargo: Require package type be specified in Nargo.toml (#2134) (1c991d0)
nargo: Support custom entry points specified in TOML (#2158) (effb02a)
nargo: Support optional directory in git dependencies (#2436) (84fdc55)
Only create new witnesses for distinctiveness when duplicates exist (#2191) (14cbdbc)
Open functions are unconstrained (be44c7b)
Optimize x < 0 for unsigned x to false (#2206) (25bc969)
Optimize away constant calls to black box functions (#1981) (47b372c)
Optimize equality checks between a boolean and constant (#2201) (478c026)
Optionally output a debug artifact on compile (#2260) (edded24)
Perform input validation on user's package names (#2293) (87174ac)
Perform more checks for compile-time arithmetic (#2380) (1be2b1e)
Perform sorting of constant arrays at compile time (#2195) (c46d7a0)
Recursion working in brillig (#1854) (e55b5a8)
Refactor Logging to use Brillig foreign calls (#1917) (c15f9aa)
Remove comptime and warn upon usage (#2178) (98d0de3)
Remove an unnecessary witness in mul_with_witness (#2078) (9f3198e)
Replace boolean ANDs with multiplication (#1954) (435ab35)
Report compilation warnings before errors (#2398) (a1d1267)
ssa refactor: Implement first-class references (#1849) (e5773e4)
ssa_refactor: Add Slices (#1728) (4bee979)
ssa: Add additional BinaryOp simplifications (#2124) (50b2816)
ssa: Merge slices in if statements with witness conditions (#2347) (76f7e43)
ssa: Perform dead instruction elimination on intrinsic functions (#2276) (3fe3f8c)
ssa: Reuse existing results for duplicated instructions with no side-effects (#2460) (93726c4)
ssa: Switch mem2reg pass to be per function rather than per block (#2243) (0d548b9)
Standard library functions can now be called with closure args  (#2471) (feb8d0e)
stdlib: Add multiple slice builtins (#1888) (008a16b)
stdlib: Add secp256r1 builtin function   (#1858) (f3800c5)
stdlib: Implement str as_bytes and into_bytes function (#2298) (92549d4)
stdlib: Vec type (#1905) (3734e25)
Support contract package type in nargo info command (#2249) (d309cc0)
Support workspaces and package selection on every nargo command (#1992) (940b189)
Syntax for environment types now works with generics (#2383) (4609c1a)
Update acvm to 0.15.1 (#1764) (b52f25d)
Update to acvm 0.22.0 (#2363) (e050fab)
Update to acvm 0.14.0 (#1594) (f2d6b7b)
Update to ACVM 0.15.0 (#1616) (3109239)
Update to ACVM 0.16.0 (#1863) (9c89def)
Update to ACVM 0.18.1 and implement missing brillig blackboxes (#1914) (2bc7d25)
Update to ACVM 0.21.0 (#2051) (ad118eb)
Use equivalence information from equality assertions to simplify circuit (#2378) (ec5b021)
Use RAM/ROM opcode when supported by the backend (#1282) (242f07b)

Bug Fixes

9_conditional end to end test (#1951) (2f6741f)
regression end to end test (#1965) (59f92e3)
Account for missing indices in flattened witness map (#1907) (3972410)
acir_gen: Pass accurate contents to slice inputs for bb func calls (#2435) (054642b)
acir: Attach locations to MemoryOps in ACIR (#2389) (d7d7f22)
Add foreign impl error (#2216) (a53f5ed)
Add missing follow_bindings when checking if a type can be casted (#2022) (537c2bd)
Add Result to acir gen (#1927) (1f8fd51)
Assignment to arrays of structs (#1998) (2c3d976)
Avoid non-determinism in defunctionalization (#2069) (898a9fa)
Avoid non-determinism in defunctionalize (898a9fa)
Avoid potential panic in two_complement (#2081) (63c4da0)
brillig_gen: Pass correct size of complex types input for brillig foreign calls (#1922) (04c89d2)
Closure lvalue capture bugfix (#2457) (632006a)
Correct off-by-one errors in lexer spans (#2393) (bbda9b0)
crates: Do not process relative dependencies twice (#1856) (b2e71bb)
Create FileManager with a root and normalize filenames against it (#1881) (50c1648)
Differentiate stdlib CrateId from others (#1895) (211e251)
Display warning if last expression of block is unused (#2314) (8110136)
Divide by zero should fail to satisfy constraints for Field and ints (#2475) (1b85816)
Don't panic when checking if an undeclared variable is mutable (#1987) (0449518)
Emit Opcodes in correct order from GeneratedAcir::radix_le_decompose (#1903) (e5fe839)
Emit opcode in correct order from GeneratedAcir::radix_le_decompose (e5fe839)
Emit opcodes for sorting variables in order of execution (c43efab)
Emit opcodes for sorting variables in order of execution (#1941) (c43efab)
Fix 3 parser test cases in parsing (#2284) (094aef1)
Fix an ICE happening when we call a closure result from if/else (#2146) (928b3ad)
Fix an ICE when reassigning a mutable lambda variable to one with a different environment type (#2172) (a56db3e)
Fix assignment when both mut and &mut are used (#2264) (b07a7ff)
Fix auto-deref operations assigning the wrong result type (#1904) (827f78c)
Fix methods not mutating fields (#2087) (6acc242)
Fix nargo not showing compiler errors or warnings (#1694) (4233068)
Flattening pass no longer overwrites previously mapped condition values (#2117) (f7742ab)
frontend: Avoid panic if dependency cannot be resolved (#1719) (f35b346)
globals: Accurately filter literals for resolving globals (#2126) (1c21d0c)
Implement .len() in Acir-Gen (#2077) (ab61e3a)
Implement constant folding during the mem2reg pass (#2464) (5361ebd)
Implement handling of array aliasing in the mem2reg optimization pass (#2463) (7123fa9)
Implement new mem2reg pass (#2420) (7714cd0)
Implement slices of structs (#2150) (6abcb79)
Initialize numeric generics' type to a polymorphic integer when used in an expression (#2179) (c74b228)
lsp: Avoid storing Context until recompiles are possible (#1891) (fb5f20b)
lsp: Ensure LSP can compile on Windows (#1794) (2992915)
lsp: Ensure lsp does not crawl past the root specified (#2322) (d69e372)
lsp: Ensure stdlib is always added before the check_crate phase (#1840) (cb607f5)
lsp: Ensure that stdlib is always added to the driver during the check_crate phase (cb607f5)
lsp: Improve dependency resolution in context of Nargo.toml (#2226) (8846bf2)
lsp: Pass --program-dir to test command from codelens (#2292) (92e1802)
lsp: Remove duplicated creation of lenses (#2433) (41b568d)
Method resolution when calling an &mut method with an &mut object type (#1947) (73c2e94)
Methods called after being passed through a generic type were not being detected (#1785) (e560cd2)
Mutating a variable no longer mutates its copy (#2057) (e85e485)
nargo: Allow --program-dir flag anywhere in a command (#2290) (7834fce)
nargo: Indicate which TOML file is missing package name (#2177) (9529157)
nargo: Make dependencies section optional in TOML (#2161) (099f4d4)
nargo: Prevent -p arg clash (#1605) (4867f4e)
nargo: Remove -p short flag from the --program-dir flag (#2300) (cc2af74)
nargo: Update acvm-backend-barretenberg to allow wasm backend compilation (#1771) (97da745)
noirc_driver: Move error printing into nargo (#1598) (561cd63)
old ssa: Fix to_be_bits (#1765) (2541fbd)
Only flatten main (#1984) (ac865b1)
Open contract functions are unconstrained (#2052) (be44c7b)
Optimize contracts built by nargo info (b30b3f4)
Optimize contracts built by nargo info (#2259) (b30b3f4)
Overflowing assignment will result in an error (#2321) (bc645fc)
Parse an if followed by a tuple as a block (#1924) (8df4f05)
parser: Fixes for the parsing of 'where' clauses (#2430) (fa31015)
Perform occurs check before binding function types (#2027) (1544786)
Prevent if and for from parsing constructor expressions (#1916) (6d3029a)
Prevent comparisons from being used on Fields (#1860) (c8858fd)
Prevent dead instruction elimination of brillig functions which may contain side-effects (#2340) (ba8ffd8)
Prevent panic when passing relative paths to --program-dir (#2324) (9eb45da)
Properly capture lvalues in closure environments (#2120) (#2257) (ed5273c)
Rebuild tests plus script to include secp256r1 change (#1908) (ca68666)
Remove duplicate T in expected T, found T error on tuple assignment (#2360) (c964ee8)
Remove duplicated name option in nargo new (#2183) (68f5887)
Remove last vestige of array of structs to struct of arrays conversion (#2217) (34be264)
Rename Option::value to Option::_value (#2127) (8a1ace7)
Require package names to be non-empty (#2293) (87174ac)
Run wasm nodejs tests with no fails (#2387) (67b6710)
Set location before cast instructions in SSA (#2202) (a72cc96)
Show types in error message in same order as in source code (#2353) (feebee4)
Simplification of overflowing integer operations (#2153) (4a5d2de)
ssa refactor: ACIR gen NOT integer (#1749) (af749a0)
ssa refactor: Add missed call to resolve (#1817) (fa9be1d)
ssa refactor: Add missing calls to resolve in Instruction::simplify (#1678) (07b07d0)
ssa refactor: Allow simplified call inserts & fix const radix arg handling (#1774) (46facce)
ssa refactor: BigUint for radix (#1715) (00cf462)
ssa refactor: Change the result of simplifying Eq and Lt to bool (#1672) (1d48929)
ssa refactor: Do not remove enable_side_effects instructions in die pass (#1673) (cbee4c0)
ssa refactor: Euclidean division for unsigned (#1721) (a1596bc)
ssa refactor: Filter unreachable blocks from cfg (#1523) (202c345)
ssa refactor: Fix array element propagation through constant folding and DIE (#1674) (301e244)
ssa refactor: Fix array elements not being mapped to new values (#1717) (4ebcbeb), closes #1688
ssa refactor: Fix bad constant type caching (#1593) (37c0be6)
ssa refactor: Fix constant folding looping forever (#1611) (afe58cc)
ssa refactor: Fix failed_to_inline_a_function being set for intrinsics (#1675) (377ac5c)
ssa refactor: Fix flatten_cfg for ifs with no else (#1671) (7ce8cce)
ssa refactor: Fix flattening pass inserting loads before stores occur (#1783) (4293b15)
ssa refactor: Fix mem2reg pass not always removing unused stores (#1677) (8310544)
ssa refactor: Fix panic in acir-gen from multiplying values of different types (#1769) (1f9a132)
ssa refactor: Fix recursive call to create_value_from_type (#1815) (890a63b)
ssa refactor: Fix stack overflow during loop unrolling (#1666) (c7a7216)
ssa refactor: Function inlining orphans calls (#1747) (f30a90f)
ssa refactor: Ignore array out of bounds errors when enable_side_effects is false (#1797) (7b7682a)
ssa refactor: Implement array equality in SSA-gen (#1704) (0d31d83)
ssa refactor: Implement merging of array values during flattening pass (#1767) (8f24751)
ssa refactor: More comprehensive instruction simplification (#1735) (97d6747)
ssa refactor: Pad radix result (#1730) (8e9b612)
ssa refactor: Prevent stores in 'then' branch from affecting the 'else' branch (#1827) (e068fd4)
ssa refactor: Recursion_level decrement (#1745) (e449b92)
ssa refactor: Recursive branch analysis (#1759) (635b574)
ssa refactor: Reset condition value during flattening pass (#1811) (2e330e0)
ssa refactor: Resolve replaced value ids for printing (#1535) (08ca847)
ssa refactor: Schnorr signature handling (#1727) (98ecf93)
ssa refactor: Speedup acir-gen (#1793) (1e75f0e)
ssa refactor: Speedup find-branch-ends (#1786) (861e42c)
ssa refactor: Translate strings as arrays of characters (#1669) (2ba2ef6)
ssa refactor: Truncate when simplifying constant casts (#1714) (a2108d7)
ssa: Codegen missing check for unary minus (#2413) (1435a86)
ssa: Conditionalise array indexes under IF statements (#1395) (ddca3b4)
ssa: Do not optimize for allocates in constant folding (#2466) (9e272f3)
ssa: Handle right shift with constants (#2481) (13a8c87)
ssa: Remove padding from ToRadix call with constant inputs (#2479) (37bb781)
stdlib: Correct tecurve::contains formula (#1821) (6a10ecf)
Switch from HashMap to BTreeMap in merge_stores (#2035) (4d179e3)
Update array type when processing staged memory (#1751) (27eb748)
Update int division optimization (#1928) (fb872c6)
Various fixes for defunctionalization & brillig gen (#1973) (f99f4bf)
Workaround for LSP dependency resolution (#1865) (a8ac338)

Miscellaneous Chores

abi: Replace struct name with fully qualified struct path (#2374) (0920dd0)
nargo: Make proving and verification keys optional (#1880) (be36c1e)
nargo: Remove flat_witness feature flag (#2208) (32d52d3)
nargo: Remove unused flags on LSP command (#2170) (ccba78e)
nargo: Rename nargo gates to nargo info (#2038) (5907e96)
nargo: Require package names in Nargo.toml files (#2056) (bb28223)
Remove keys from preprocessed artifacts (#2283) (4554287)
Update to acvm-backend-barretenberg v0.12.0 (#2377) (1467275)
Update to ACVM 0.13.0 (#1393) (22dee75)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/jonybur/noir/releases/tag/v0.11.0 :sunflower:


How to apply the transition for 2 videos

Please help for transition 2 videos

Were you able to ever find a solution for video transitions? @newit-quyetvv

I give up

am also looking for the same, i have done some more changes to this project to make it work for videos too. but I cant run two video decoder for transitions..
so I need to apply these transitions between videos


Unable to build package using Xcode

Here's what I did:

Fork repo
Clone
git submodule update --init --recursive --remote

The swift-cassandra-driver fails to build, because libuv is looking for sys/epoll.h on my system.

I can't reproduce this in Xcode 14.1 (14B47b). I don't think I did anything special. Curious to see if others have run into the same issue as well.

Hmm, I don't understand what the difference could. To fix this, I had to add the following to the libuvExclude variable for !os(Linux)
"./libuv/src/unix/linux.c",

However, now I'm hitting a linking failure:
"datastax::internal::core::OpenSslContext::set_min_protocol_version(CassSslTlsVersion_)", referenced from:
  vtable for datastax::internal::core::OpenSslContext in CDataStaxDriver.o

Ahh, user error! The correct method is:
git submodule update --init
--recursive isn't needed in this case, but the real problem was my use of --remote. That checks ignores the recorded commit in the submodule.


hyperglass: frontend: delete build dir before copying generated code to it

fixes #244

See comment in #244


Pull instructlab images out of local storage

Also create a Makefile.common in training so that the different hardware vendors Makefiles can share options.

LGTM

If you can @rhatdan include the workflow changes when possible.

@Gregory-Pereira what did I change in workflows?

The workflows used those make targets to build. I added a commit updating the workflows to use the new bootc make target instead of the image target it was previously

Ok. sorry.
This patch is broken.  Will be opening another.


Mod doesn't work with Cloth Config v. 11.1.118 - 1.20.1

The game refuses to launch. It asks version 11.1.106 or lower.

Why "wontfix" tag? Is this will not be anyhow solved?

I'm sorry, I accidentally clicked

fixed in alpha 1.6
https://github.com/Dalynkaa/Game-Highlighter/releases/tag/alpha-1.6


Get-MigrationUser -status IncrementalFailed is missing in the documentation

Get-MigrationUser -status IncrementalFailed
is missing from the list of Microsoft.Exchange.Data.Storage.Management.MigrationBatchStatus values
Get-MigrationUser -status IncrementalFailed
`Get-MigrationUser -status IncrementalFailed
Identity                                 Batch                          Status                    LastSyncTime

<EMAIL_ADDRESS>                  Move-users-DAG1-1              IncrementalFailed         25.08.2021 15:06:09`

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8d404737-9599-a21f-41f1-d31a0baa4fe6
Version Independent ID: 440c9461-7510-e9bd-6d6c-ddd8fa2d06b4
Content: Get-MigrationBatch (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Get-MigrationBatch.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@rsedlacz Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


create edu

let's me use  the jetbrains product study coding

@ReadyCheng lib/domains/moi/edu: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@ReadyCheng I have to close the request without merging. Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Docstring: Fix inaccurate documentation on how summary and log work together

In response to this slack thread, quick docstring fix
https://weightsandbiases.slack.com/archives/C0108SLEP6K/p1614801627101100
Tim Sweeney Today at 12:00
Is this a bug or working as intended? (logging after a summary assignment overwrites summary assignment?)
run = wandb.init()
run.log({"A": 1})
run.summary["A"] = 2
run.log({"A": 3})
run.finish()
Screen Shot 2021-03-03 at 12.00.23 PM.png
Screen Shot 2021-03-03 at 12.00.23 PM.png
Carey Phelps  6 hours ago
Ah, working as intended but perhaps worth changing? log updates summary so if you wanted to set summary to say the best value instead of the last value, you would do that at the end, outside of the loop that's calling log
Tim Sweeney  6 hours ago
ok, makes sense. FWIW, this is fine to me - just wanted to double check :slightly_smiling_face:
Fariz Rahman  6 hours ago
Logging a value will update the summary values for any metrics logged. The summary values will appear in the run table at app.wandb.ai or a local server. If a summary value is manually set with for example wandb.run.summary["accuracy"] = 0.9 wandb.log will no longer automatically update the run's accuracy.
https://docs.wandb.ai/ref/run/log
Either bug or bad docs. As a dev my unbiased opinion is that its bad docs.
Chris Van Pelt:speech_balloon:  6 hours ago
This is how it's always worked and how we intended it to work.  The docs are WRONG.
Fariz Rahman  6 hours ago
phew

If this looks good could someone squash and merge?


Yahoo data downloader does not download any data??

PG: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

TRV: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

UNH: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

CRM: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

VZ: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

V: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

WBA: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

WMT: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

DIS: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

DOW: No data found for this date range, symbol may be delisted

ValueError                                Traceback (most recent call last)
 in <cell line: 17>()
15
16
---> 17 df = YahooDownloader(start_date = TRAIN_START_DATE,
18                      end_date = TEST_END_DATE,
19                      ticker_list = DOW_30_TICKER).fetch_data()
/usr/local/lib/python3.9/site-packages/finrl/meta/preprocessor/yahoodownloader.py in fetch_data(self, proxy)
58                 num_failures += 1
59         if num_failures == len(self.ticker_list):
---> 60             raise ValueError("no data is fetched.")
61         # reset the index, we want to use numbers as index instead of dates
62         data_df = data_df.reset_index()
ValueError: no data is fetched.

PG: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

TRV: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

UNH: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

CRM: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

VZ: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

V: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

WBA: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

WMT: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

DIS: No data found for this date range, symbol may be delisted
[100%**]  1 of 1 completed

1 Failed download:

DOW: No data found for this date range, symbol may be delisted

ValueError Traceback (most recent call last) in <cell line: 17>() 15 16 ---> 17 df = YahooDownloader(start_date = TRAIN_START_DATE, 18 end_date = TEST_END_DATE, 19 ticker_list = DOW_30_TICKER).fetch_data()
/usr/local/lib/python3.9/site-packages/finrl/meta/preprocessor/yahoodownloader.py in fetch_data(self, proxy) 58 num_failures += 1 59 if num_failures == len(self.ticker_list): ---> 60 raise ValueError("no data is fetched.") 61 # reset the index, we want to use numbers as index instead of dates 62 data_df = data_df.reset_index()
ValueError: no data is fetched.

Yahoo Finance seems not work in China, and some other regions. Please check other data sources at: https://github.com/AI4Finance-Foundation/FinRL-Meta/tree/master/meta/data_processors

Xio
I am based in us and it is giving me this error???
On Wed, Apr 5, 2023, 9:38 AM Xiao-Yang Liu @.***> wrote:

PG: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

TRV: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

UNH: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

CRM: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

VZ: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

V: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

WBA: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

WMT: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

DIS: No data found for this date range, symbol may be delisted
[100%**] 1 of 1 completed

1 Failed download:

DOW: No data found for this date range, symbol may be delisted

ValueError Traceback (most recent call last) in <cell line: 17>() 15 16
---> 17 df = YahooDownloader(start_date = TRAIN_START_DATE, 18 end_date =
TEST_END_DATE, 19 ticker_list = DOW_30_TICKER).fetch_data()
/usr/local/lib/python3.9/site-packages/finrl/meta/preprocessor/yahoodownloader.py
https://localhost:8080/# in fetch_data(self, proxy) 58 num_failures +=
1 59 if num_failures == len(self.ticker_list): ---> 60 raise ValueError("no
data is fetched.") 61 # reset the index, we want to use numbers as index
instead of dates 62 data_df = data_df.reset_index()
ValueError: no data is fetched.
Yahoo Finance seems not work in China, and some other regions. Please
check other data sources at:
https://github.com/AI4Finance-Foundation/FinRL-Meta/tree/master/meta/data_processors
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1497796721,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2K3HHUMXSNCJBBNMRTW7WNXDANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'm getting the same error (also based in the US). This is by just running the introduction notebook at
https://colab.research.google.com/github/AI4Finance-Foundation/FinRL-Tutorials/blob/master/1-Introduction/Stock_NeurIPS2018_SB3.ipynb

Same error, I´m from Brazil and Yahoo Finance work here.
https://colab.research.google.com/github/AI4Finance-Foundation/FinRL-Tutorials/blob/master/2-Advance/FinRL_Ensemble_StockTrading_ICAIF_2020.ipynb

Hi, all,
I have to say that the data from Yahoo Finance is not satisfactory.  I would encourage to use FinnHub: http://www.columbia.edu/~tmd2142/free-stock-api.html

Thanls Xiao.
Can you share the new notebook??? Or how to change logic to use new data???
Or just replace yahoodownload section???
Not sure how finrl works umder hoos??
On Thu, Apr 6, 2023, 6:11 PM Xiao-Yang Liu @.***> wrote:

Hi, all,
I have to say that the data from Yahoo Finance is not satisfactory. I
would encourage to use FinnHub:
http://www.columbia.edu/~tmd2142/free-stock-api.html
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1499813494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2J7V7JBEY7VS6VUFWLW75SV5ANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

To me, the problem was the new Pandas version (2.0.0), which creates conflict with yfinance. Downgrading pandas to 1.5.3 resolved the issue for me. Hope this helps!

Thanks can you please put the code that you used ??? To fix the issue in
pandas??
On Fri, Apr 7, 2023, 10:00 AM shql-tgr @.***> wrote:

To me, the problem was the new Pandas version (2.0.0), which creates
conflict with yfinance. Downgrading pandas to 1.5.3 resolved the issue for
me. Hope this helps!
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1500464830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2LKIJJY3MM2DFOYORDXABB4DANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Just do:
!pip install pandas==1.5.3

Exactly. I am working from colab, and there you just need to run !pip install pandas==1.5.3 before importing libraries. Otherwise, you could create a virtual environment, in which you could install the packages you need for the project with the right version

Thank you i am also doing colab
So yahoo code and downliader no changes there???
On Fri, Apr 7, 2023, 11:59 AM shql-tgr @.***> wrote:

Exactly. I am working from colab, and there you just need to run !pip
install pandas==1.5.3 before importing libraries. Otherwise, you could
create a virtual environment, in which you could install the packages you
need for the project with the right version
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1500532999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2LHDKQCGMOPPMACK6TXABPZ3ANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

No, just downgrading Pandas should do the trick. Let me know if it works!

Thanks let me try appreciuate it
On Fri, Apr 7, 2023, 12:42 PM shql-tgr @.***> wrote:

No, just downgrading Pandas should do the trick. Let me know if it works!
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1500585618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks let me try appreciuate it
…
On Fri, Apr 7, 2023, 12:42 PM shql-tgr @.> wrote: No, just downgrading Pandas should do the trick. Let me know if it works! — Reply to this email directly, view it on GitHub <#962 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA . You are receiving this because you authored the thread.Message ID: @.>

can you run the colab using Yahoo data sucessfully?

Many thanks for all your help
Yes it works for me now
I only did this i.e. as sql-tgr suggested
I just ran !pip install pandas==1.5.3 before importing libraries.
On Mon, Apr 17, 2023 at 6:46 PM GongYanfu @.***> wrote:

Thanks let me try appreciuate it
… <#m_5968349911874801398_>
On Fri, Apr 7, 2023, 12:42 PM shql-tgr @.> wrote: No, just downgrading
Pandas should do the trick. Let me know if it works! — Reply to this email
directly, view it on GitHub <#962 (comment)
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1500585618>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA
https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA
. You are receiving this because you authored the thread.Message ID: @.>
can you run the colab using Yahoo data sucessfully?
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1512318610,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2LTQGJBJXEYE4IIUOLXBXW7HANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>

I had a quick question.
it looks like that dow_30_ticker is some where hardcoded in the code but I
cannot find the same?
['AXP', 'AMGN', 'AAPL', 'BA', 'CAT', 'CSCO', 'CVX', 'GS', 'HD', 'HON',
'IBM', 'INTC', 'JNJ', 'KO', 'JPM', 'MCD', 'MMM', 'MRK', 'MSFT', 'NKE',
'PG', 'TRV', 'UNH', 'CRM', 'VZ', 'V', 'WBA', 'WMT', 'DIS', 'DOW'
if I want to input my own ticker symbols  instead of dow , 30 , what
should I do?
How can  change dow_30_ticker so that it uses my own input tickers?
On Tue, Apr 18, 2023 at 9:12 AM aqureshi @.***> wrote:

Many thanks for all your help
Yes it works for me now
I only did this i.e. as sql-tgr suggested
I just ran !pip install pandas==1.5.3 before importing libraries.
On Mon, Apr 17, 2023 at 6:46 PM GongYanfu @.***>
wrote:

Thanks let me try appreciuate it
… <#m_-7350991941299608723_m_5968349911874801398_>
On Fri, Apr 7, 2023, 12:42 PM shql-tgr @.> wrote: No, just
downgrading Pandas should do the trick. Let me know if it works! — Reply to
this email directly, view it on GitHub <#962 (comment)
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1500585618>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA
https://github.com/notifications/unsubscribe-auth/AAMLV2L64YLWCJNAXRIBQEDXABUZRANCNFSM6AAAAAAWTUXKMA
. You are receiving this because you authored the thread.Message ID: @.>
can you run the colab using Yahoo data sucessfully?
—
Reply to this email directly, view it on GitHub
https://github.com/AI4Finance-Foundation/FinRL/issues/962#issuecomment-1512318610,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMLV2LTQGJBJXEYE4IIUOLXBXW7HANCNFSM6AAAAAAWTUXKMA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Create a database that contains the candidates table

User Story

As a user, I can request a list of all potential candidates.

As a user, I can request a single candidate's information.

As a user, I want to delete a candidate.

As a user, I want to create a candidate.

Created database and files to recreate the database.

all CRUD Routes created.


[BUG] RPM packaging issue

I think there's a packaging issue with how the desktop files are installed.  If you upgrade, the menu shortcuts get removed.  To fix/avoid this, you have to uninstall the old, and then install the new version.
# dnf install sparrow-1.5.3-1.x86_64.rpm  # sparrow-1.5.2-1.x86_64 is already installed

The above leads to a broken menu.
To avoid the problem, you need to do:
# dnf remove sparrow
# dnf install sparrow-1.5.3-1.x86_64.rpm

I'm on 5.15.6-100.fc34.x86_64

Sparrow v1.5.3 did make a change to the installation menu, specifying the menu folder to be 'Sparrow' rather than the 'Unknown' default. Possibly this is contributing.
In what way is the menu broken?

Hi Craig,
Sparrow simply disappears from the list of applications.  When I search for "sparrow", there's no result.  I think I noticed this in the previous release also.

When "upgrading", I see these messages from dnf:
Remove sparrow-Sparrow.desktop default handler for application/psbt mime type from /usr/local/share/applications/defaults.list file
Remove sparrow-Sparrow.desktop default handler for application/bitcoin-transaction mime type from /usr/local/share/applications/defaults.list file
Remove sparrow-Sparrow.desktop default handler for x-scheme-handler/bitcoin mime type from /usr/local/share/applications/defaults.list file
Remove sparrow-Sparrow.desktop default handler for x-scheme-handler/aopp mime type from /usr/local/share/applications/defaults.list file
/usr/local/share/applications/defaults.list file updated

This is actually a duplicate of #722, closing in favour of that (longer) issue.


Refactor

Codecov Report

Merging #13 into master will decrease coverage by 11.42%.
The diff coverage is 72.41%.

@@             Coverage Diff              @@
##            master      #13       +/-   ##
============================================
- Coverage   100.00%   88.57%   -11.43%
============================================
  Files            6        7        +1
  Lines           59       70       +11
  Branches         2        2
============================================
+ Hits            59       62        +3
- Misses           0        8        +8

Impacted Files
Coverage Δ

src/options.ts
100.00% <ø> (ø)

src/router.ts
11.11% <11.11%> (-88.89%)
:arrow_down:

src/createRoutider.ts
100.00% <100.00%> (ø)

src/index.ts
100.00% <100.00%> (ø)

src/path.ts
100.00% <100.00%> (ø)

src/route.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70dcaf1...289653d. Read the comment docs.


Uncaught SyntaxError: Unexpected token t

[Enter steps to reproduce below:]

Packages --> Remote Edit --> Browse Hosts

Atom Version: 1.0.3
System: Mac OS X 10.10.4
Thrown From: remote-edit package, v1.8.14
Stack Trace
Uncaught SyntaxError: Unexpected token t
At file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.html#%7B%22locationsToOpen%22%3A%5B%7B%7D%5D%2C%22bootstrapScript%22%3A%22%2FApplications%2FAtom.app%2FContents%2FResources%2Fapp.asar%2Fsrc%2Fwindow-bootstrap.js%22%2C%22resourcePath%22%3A%22%2FApplications%2FAtom.app%2FContents%2FResources%2Fapp.asar%22%2C%22devMode%22%3Afalse%2C%22safeMode%22%3Afalse%2C%22profileStartup%22%3Afalse%2C%22appVersion%22%3A%221.0.3%22%2C%22shellLoadTime%22%3A448%2C%22initialPaths%22%3A%5B%5D%7D:1

SyntaxError: Unexpected token t
    at Object.parse (native)
    at /Users/stephenstgo/.atom/packages/remote-edit/lib/model/inter-process-data-watcher.coffee:93:54
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:379:3)

Commands
     -0:00.7.0 remote-edit:show-open-files (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "seti-ui",
      "seti-syntax"
    ]
  },
  "remote-edit": {
    "rememberLastOpenDirectory": true,
    "followLinks": false,
    "foldersOnTop": true
  }
}

Installed Packages
# User
color-picker, v2.0.11
linter, v1.3.0
minimap, v4.12.2
pigments, v0.9.3
remote-edit, v1.8.14
seti-syntax, v0.4.0
seti-ui, v0.7.1

# Dev
No dev packages

Can you send me the contents of ~/.atom/remoteEdit.json? Be sure to sanitize any passwords/IPs. You can post it here or send it to me at sverre.aleksandersen (at) gmail.com.

I sent you an email with the info

Trying to see if there was any update on this.

Hi. I’ve received the email, but have been swamped lately so havent really had time to look at it.
In the meantime, I’d urge you you try and delete ~/.atom/remoteEdit.json to see if that helps.
You’ll lose all the hosts and files you’ve added if you do this, but seeing as how it doesn’t work I’m sure thats allright.
Alternatively, just backup the file.
Let me know if it helps.
I’ll look more into it as soon as I have time.

On 26 Aug 2015, at 20:52, Stephen Santiago<EMAIL_ADDRESS>wrote:
Trying to see if there was any update on this.
—
Reply to this email directly or view it on GitHub https://github.com/sveale/remote-edit/issues/108#issuecomment-135137683.

Ok I will try this out to see if it helps. Besides this problem the package
works very well!
On Wed, Aug 26, 2015 at 2:57 PM, Sverre Aleksandersen <
<EMAIL_ADDRESS>wrote:

Hi. I’ve received the email, but have been swamped lately so havent really
had time to look at it.
In the meantime, I’d urge you you try and delete ~/.atom/remoteEdit.json
to see if that helps.
You’ll lose all the hosts and files you’ve added if you do this, but
seeing as how it doesn’t work I’m sure thats allright.
Alternatively, just backup the file.
Let me know if it helps.
I’ll look more into it as soon as I have time.

On 26 Aug 2015, at 20:52, Stephen Santiago<EMAIL_ADDRESS>wrote:
Trying to see if there was any update on this.
—
Reply to this email directly or view it on GitHub <
https://github.com/sveale/remote-edit/issues/108#issuecomment-135137683>.

—
Reply to this email directly or view it on GitHub
https://github.com/sveale/remote-edit/issues/108#issuecomment-135139322.

Hi! I've published what I hope will be a fix. Let me know if you're still experiencing issues after installing it :)


add support for Team Reactions API

Closes #877.

Hi @urohit011, thank you for the PR.
It looks like there are a few issues that need to be resolved before I start a code review.
Please make sure you take a look at our CONTRIBUTING.md file... it has some important steps for you to run, like making sure the tests pass locally:
go generate github.com/google/go-github/...
go test github.com/google/go-github/...
go vet github.com/google/go-github/...

Also, here is some output from TravisCI to investigate:
# github.com/google/go-github/github
github/reactions.go:274:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions.go:275:27: undefined: strings
github/reactions.go:298:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions.go:299:27: undefined: strings
github/reactions.go:325:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions.go:326:27: undefined: strings
github/reactions.go:346:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions.go:347:27: undefined: strings
github/reactions_test.go:191:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions_test.go:194:30: undefined: strings
github/reactions_test.go:194:30: too many errors
FAIL	github.com/google/go-github/github [build failed]

Got it @gmlewis, I'll do the needful.

Hello @gmlewis, here is what I tried and perhaps I am doing it the wrong way, I ran the following commands that are mentioned in the travis.yml file:
go test -v -race ./...
go test -v -tags=integration -run=^$ ./test/integration
Both these commands run fine on my local machine, but the Travis build is still failing. Could you please help me understand why this is happening?

Sure, @urohit011.
The first command that fails in TravisCI is this:

The command "go get -t -v ./..." exited with 2.
$ diff -u <(echo -n) <(gofmt -d -s .)

This means that it found files where gofmt was not run. I've personally integrated goimports with my editor so that on every save of every Go file, it runs goimports (which has the nice side effect of running gofmt to make sure my code has been formatted properly). I highly recommend goimports integration with your editor.
Then the next command that fails in TravisCI is this:

$ go test -v -race ./...
github/reactions.go:274:55: undefined: mediaTypeGraphQLNodeIDPreview
github/reactions.go:275:27: undefined: strings

Searching for mediaTypeGraphQLNodeIDPreview, I see that it has recently been removed from this repo... so it looks like you need to sync your branch with the main repo. There are help articles on GitHub how to do this, but basically, here is what I usually do:
$ git checkout master
$ git pull upstream master
$ git checkout my-development-branch
$ git merge master
$ git mergetool    # if there were merge conflicts
$ git commit -am 'Merge master into my-development-branch'
$ git push origin my-development branch

Please let me know if this is not clear or you need more help syncing up.
When you git push your update, please do not use --force so that the reviews are easier for the reviewer.

Thank you very much for the clarification @gmlewis, It looks clear so far, I'll fix it and let you know if you know if I face problems.

Hello @gmlewis, the Travis build passed (except for the test that is allowed to fail), can we go ahead with the code review now?

All requested changes made.

@gauntface - Can you please have @willnorris add you as a contributor to this repo and I can start requesting reviews from you? Julia recommended that I contact you while she is unavailable for reviews.
Meanwhile, would you mind reviewing this PR for me and giving it an official LGTM if you approve?
Thank you!

@gmlewis @gauntface I've added Matt as a collaborator with read permissions as @willnorris is out.

Made the changes you suggested, @gauntface .

Thank you so much @urohit011. Over to @gmlewis or @juliaferraioli to merge this PR :100:

Thanks, everyone!
Merging.

Thanks everyone, really enjoyed working on this.


2.6.0 cpp client crash

Describe the bug
A clear and concise description of what the bug is.
*To Reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
call this api, cpp client crash
pulsar_client_create_producer(m_client, topic.c_str(), producer_conf, &producer)
Desktop (please complete the following information):

OS:linux kernel  4.14.105

Additional context
(gdb) bt
#0  0x00007f8307f4c377 in raise () from /lib64/libc.so.6
#1  0x00007f8307f4da68 in abort () from /lib64/libc.so.6
#2  0x0000000000c7c515 in __gnu_cxx::__verbose_terminate_handler () at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95
#3  0x0000000000c27896 in __cxxabiv1::__terminate (handler=) at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:38
#4  0x0000000000c278c3 in std::terminate () at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48
#5  0x0000000000c6e775 in std::(anonymous namespace)::execute_native_thread_routine (__p=) at ../../../../../libstdc++-v3/src/c++11/thread.cc:92
#6  0x00007f8308d00ea5 in start_thread () from /lib64/libpthread.so.0
#7  0x00007f83080148cd in clone () from /lib64/libc.so.6

@firefeifei Can you share the code example so that we can reproduce?

If I configure IP and Port, the Pulsar cluster does not start and crashes
If the configured IP and Port pulsar services are normal, then there is no crash
@sijie

@firefeifei Please provide a simple (complete) code example that reproduce the issue. That would make it far easier to understand what's happening.

m_conf = pulsar_client_configuration_create();
pulsar_client_configuration_set_logger(m_conf, PulsarProducer::pulsar_logger, (void*)this);
m_client = pulsar_client_create(service_url.c_str(), m_conf);
pulsar_producer_configuration_t* producer_conf = pulsar_producer_configuration_create();
pulsar_producer_configuration_set_batching_enabled(producer_conf, 0);
pulsar_producer_configuration_set_max_pending_messages(producer_conf, 1000000);
pulsar_result err = pulsar_client_create_producer(m_client, topic.c_str(), producer_conf, &producer);
 if (err != pulsar_result_Ok) {
    pulsar_producer_configuration_free(producer_conf);
   return NULL;
 }

service_url: <IP_ADDRESS>:5678

Have you tried removing the custom logger?

You can test this code without custom logger

I cannot reproduce the problem, assuming your code is like:
#include <iostream>
#include <string>
#include <pulsar/c/client.h>

int main(int argc, char* argv[]) {
    if (argc < 2) {
        std::cerr << "Usage: " << argv[0] << " service-url" << std::endl;
        return 1;
    }
    std::string topic = "Foo";
    std::string service_url = argv[1];
    auto m_conf = pulsar_client_configuration_create();
    auto m_client = pulsar_client_create(service_url.c_str(), m_conf);
    auto producer_conf = pulsar_producer_configuration_create();
    pulsar_producer_configuration_set_batching_enabled(producer_conf, 0);
    pulsar_producer_configuration_set_max_pending_messages(producer_conf, 10000);
    pulsar_producer_t* producer = NULL;
    auto err = pulsar_client_create_producer(m_client, topic.c_str(), producer_conf, &producer);
    if (err != pulsar_result_Ok) {
        pulsar_producer_configuration_free(producer_conf);
        return 1;
    }
    return 0;
}

The running result:
$ ./examples/SampleProducer pulsar://<IP_ADDRESS>:5678
2020-07-04 02:32:31.475 INFO  [140369736358592] ConnectionPool:85 | Created connection for pulsar://<IP_ADDRESS>:5678
2020-07-04 02:32:31.477 ERROR [140369636267776] ClientConnection:385 | [<none> -> pulsar://<IP_ADDRESS>:5678] Failed to establish connection: Connection refused
2020-07-04 02:32:31.477 INFO  [140369636267776] ClientConnection:1372 | [<none> -> pulsar://<IP_ADDRESS>:5678] Connection closed
2020-07-04 02:32:31.477 ERROR [140369636267776] ClientImpl:180 | Error Checking/Getting Partition Metadata while creating producer on persistent://public/default/Foo -- ConnectError
2020-07-04 02:32:31.477 INFO  [140369636267776] ClientConnection:235 | [<none> -> pulsar://<IP_ADDRESS>:5678] Destroyed connection

Could you provide your log? In addition, could you use a higher version GCC to debug? Your backtrace lost some debug info because of libstdc++'s BUG, see How we discovered why C++ exceptions disappear in stack trace

#0  0x0000000000c3ba64 in boost::asio::detail::task_io_service::wake_one_thread_and_unlock(boost::asio::detail::scoped_lockboost::asio::detail::posix_mutex&) ()
#1  0x0000000000e5902e in boost::asio::detail::task_io_service::init_task (this=0x7f75200022c0) at /usr/local/include/boost/asio/detail/impl/task_io_service.ipp:130
#2  0x0000000000e590e0 in init_task (this=) at /usr/local/include/boost/asio/detail/impl/epoll_reactor.ipp:145
#3  reactive_socket_service_base (io_service=..., this=0x7f7520002b08) at /usr/local/include/boost/asio/detail/impl/reactive_socket_service_base.ipp:34
#4  reactive_socket_service (io_service=..., this=0x7f7520002b08) at /usr/local/include/boost/asio/detail/reactive_socket_service.hpp:77
#5  stream_socket_service (io_service=..., this=0x7f7520002ae0) at /usr/local/include/boost/asio/stream_socket_service.hpp:91
#6  boost::asio::detail::service_registry::create<boost::asio::stream_socket_serviceboost::asio::ip::tcp > (owner=...) at /usr/local/include/boost/asio/detail/impl/service_registry.hpp:81
#7  0x0000000000c3b467 in boost::asio::detail::service_registry::do_use_service(boost::asio::io_service::service::key const&, boost::asio::io_service::service* (*)(boost::asio::io_service&)) ()
#8  0x0000000000e576a9 in use_service<boost::asio::stream_socket_serviceboost::asio::ip::tcp > (this=) at /usr/local/include/boost/asio/detail/impl/service_registry.hpp:48
#9  use_service<boost::asio::stream_socket_serviceboost::asio::ip::tcp > (ios=...) at /usr/local/include/boost/asio/impl/io_service.hpp:33
#10 basic_io_object (io_service=..., this=0x7f7520002ab0) at /usr/local/include/boost/asio/basic_io_object.hpp:183
#11 basic_socket (io_service=..., this=0x7f7520002ab0) at /usr/local/include/boost/asio/basic_socket.hpp:71
#12 basic_stream_socket (io_service=..., this=0x7f7520002ab0) at /usr/local/include/boost/asio/basic_stream_socket.hpp:73
#13 pulsar::ExecutorService::createSocket (this=) at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/ExecutorService.cc:48
#14 0x0000000000f18d2c in pulsar::ClientConnection::ClientConnection (this=0x7f7520004070, logicalAddress="pulsar://pulsar-broker.service.ft:6650", physicalAddress="pulsar://pulsar-broker.service.ft:6650", executor=std::shared_ptr (count 36865104, weak -1) 0x7f753d278f30,
clientConfiguration=..., authentication=std::shared_ptr (count 3, weak 0) 0x2328430) at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/ClientConnection.cc:169
#15 0x0000000000e43564 in pulsar::ConnectionPool::getConnectionAsync (this=0x2328520, logicalAddress="pulsar://pulsar-broker.service.ft:6650", physicalAddress="pulsar://pulsar-broker.service.ft:6650") at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/ConnectionPool.cc:83
#16 0x0000000000f0b840 in pulsar::BinaryProtoLookupService::getPartitionMetadataAsync (this=0x2328748, topicName=...) at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/BinaryProtoLookupService.cc:72
#17 0x0000000000e35ab5 in pulsar::ClientImpl::createProducerAsync(std::string const&, pulsar::ProducerConfiguration, std::function<void (pulsar::Result, pulsar::Producer)>) (this=, topic="persistent://public/data/test_pulsar_ds591", conf=..., callback=...)
at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/ClientImpl.cc:158
#18 0x0000000000e30775 in pulsar::Client::createProducerAsync(std::string const&, pulsar::ProducerConfiguration, std::function<void (pulsar::Result, pulsar::Producer)>) (this=this@entry=0x23281e0, topic="persistent://public/data/test_pulsar_ds591", conf=..., callback=...)
at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/Client.cc:65
#19 0x0000000000e30ee0 in pulsar::Client::createProducer (this=0x23281e0, topic="persistent://public/data/test_pulsar_ds591", conf=..., producer=...) at /data/commlibsrc/pulsar-2.6.0/pulsar-client-cpp/lib/Client.cc:53

Hello， sijie
Basic function debugging, connect pulsar coredump

From the stack we can see the segmentation fault was caused by boost::asio::ip::tcp::socket's constructor. I found some similar issues:

https://stackoverflow.com/questions/45923885/boost-asio-io-service-multiple-objects-from-multiple-source-files-threads-cras
https://github.com/mostphotos/beanstalkpp/pull/6

Could you give the version of boost dependencies by ldd libpulsar.so?

1.54.0
link use static lib

I've reproduced it with boost 1.54.
#include <string>
#include <pulsar/c/client.h>

int main(int argc, char* argv[]) {
    std::string service_url = "pulsar://localhost:65531";
    auto m_conf = pulsar_client_configuration_create();
    auto m_client = pulsar_client_create(service_url.c_str(), m_conf);
    auto producer_conf = pulsar_producer_configuration_create();
    pulsar_producer_t* producer = NULL;
    auto err = pulsar_client_create_producer(m_client, "my-topic", producer_conf, &producer);
    if (err != pulsar_result_Ok) {
        pulsar_producer_configuration_free(producer_conf);
        return 1;
    }
    return 0;
}

The output:
2020-11-06 21:46:16.585 INFO  [140320113425088] ConnectionPool:85 | Created connection for pulsar://localhost:65531
2020-11-06 21:46:16.589 INFO  [140320018294528] ClientConnection:235 | [<none> -> pulsar://localhost:65531] Destroyed connection
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::system::system_error> >'
  what():  remote_endpoint: Transport endpoint is not connected
Aborted (core dumped)

Not sure whether it's the same issue. Or it's just because boost version is too low. I'll look into the issue later.

Please try with following diff and take a look again
diff --git a/pulsar-client-cpp/lib/ClientConnection.cc b/pulsar-client-cpp/lib/ClientConnection.cc
index 22cc420..824d54a 100644
--- a/pulsar-client-cpp/lib/ClientConnection.cc
+++ b/pulsar-client-cpp/lib/ClientConnection.cc
@@ -340,9 +340,15 @@ void ClientConnection::handleTcpConnected(const boost::system::error_code& err,
                                           tcp::resolver::iterator endpointIterator) {
     if (!err) {
         std::stringstream cnxStringStream;
-        cnxStringStream << "[" << socket_->local_endpoint() << " -> " << socket_->remote_endpoint() << "] ";
-        cnxString_ = cnxStringStream.str();
-
+        try {
+            cnxStringStream << "[" << socket_->local_endpoint() << " -> " << socket_->remote_endpoint()
+                            << "] ";
+            cnxString_ = cnxStringStream.str();
+        } catch (const boost::system::system_error& e) {
+            LOG_ERROR("Failed to get endpoint: " << e.what());
+            close();
+            return;
+        }
         if (logicalAddress_ == physicalAddress_) {
             LOG_INFO(cnxString_ << "Connected to broker");
         } else {

After discussing with @firefeifei , the issue is with the link order of libpulsar.a. After putting libpulsar.a before other dependencies like boost, it works well.


using #buildspace and unable to execute anchor test --skip-local-validator

@ChewingGlass / Anchor Team,
I am really sorry writing basic questions,  but I am absolutely new to Solana. I have just learnt rust and i wanted to get started with Solana ecosystem.
I followed all instructions as mentioned in link :
https://github.com/buildspace/buildspace-projects/blob/main/Solana_And_Web3/en/Section_2/Resources/m1_setup.md
However, i get the error as below : anchor test --skip-local-validator error: no such subcommand: build-bpf
Last login: Sat Dec 11 19:01:21 on ttys003 aadyakalra@Aadyas-MacBook-Air solana % cd myepicproject aadyakalra@Aadyas-MacBook-Air myepicproject % yarn -v 1.22.17 aadyakalra@Aadyas-MacBook-Air myepicproject % anchor --version anchor-cli 0.19.0 aadyakalra@Aadyas-MacBook-Air myepicproject % anchor test --skip-local-validator error: no such subcommand: build-bpfaadyakalra@Aadyas-MacBook-Air myepicproject %

Also, if you see my Terminal with cd solana , even the solana local validator is actually running

I am unable to figure out how to proceed, if you could help me I shall be extremely obliged @project-serum/anchor
Thanks and Regards
Suveett Kalra

Have you tried reinstalling anchor?

If it's still actual please move the question to discord.


Update short url http url to https.

Update short url scheme from http url to https (picked up by @stevvooe) from PR https://github.com/docker/containerd/pull/534#pullrequestreview-23051882
Signed-off-by: Alex Ellis<EMAIL_ADDRESS>

LGTM


refactor: the best way for ConnectWallet

https://github.com/rainbow-me/rainbowkit

https://github.com/opensquare-network/ui/issues/19


[PA-1538] New PXE BYOC

What this PR does / why we need it:
This PR re-implements Dockerfile and SSH deployment to reduce build time and enhance flexibility. It also includes a script for collecting test reports and data from /var/cores using a debug pod.
Which issue(s) this PR fixes (optional)
Closes #PA-1538
Special notes for your reviewer:
I have a implemented a Jenkins pipeline on top of these changes and here is an example build:
https://jenkins.pwx.dev.purestorage.com/job/Users/job/krishna/job/tp-pxe-byoc/1140/

You will find that the build took less time than usual (from ~3 mins to < ~1 min).
Test report: https://jenkins.pwx.dev.purestorage.com/blue/organizations/jenkins/Users%2Fkrishna%2Ftp-pxe-byoc/detail/tp-pxe-byoc/1140/tests
Diag collection: https://jenkins.pwx.dev.purestorage.com/job/Users/job/krishna/job/tp-pxe-byoc/1150/execution/node/3/ws/torpedo-1150-078d5986/archives/cluster/
There are various scripts for setting kubeconfig, environment variables, and for pre- and post-test runs.

To make it easy for review, I have modified the Dockerfile and deploy-ssh.sh file in place. I will create new files during the merging process.

Code looks good. But create separate files so that it does not affect the current scripts.


Empty body does not set content-length header

If I send a POST request with a nonempty body (say a simple byte slice), then in create_easy_handle, has_body is true, body_length is the length of the body, and then the Content-Length header is set (via the post_field_size).
If I send a POST with an empty body, then has_body is false, and the Content-Length header is not set. It seems to me that, if the request method is one that permits a body at all, then Content-Length should always be set if the body length is known, including if the known value happens to be zero.

Based on the RFC info here: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.3
We should have a clear distinction between a zero-length body and no body. If an explicit body is given (even zero-length), then we should include a Content-Length request header. But if there is no request body (as opposed to a zero-length one) then Content-Length should not be included. The request method should be irrelevant here.
The short-term fix would be to change Body::is_empty to be self.0 == Inner::Empty instead of looking at the length.
I'm not totally happy with our current API for the request body, as the distinction between no body and a zero-length one is too implicit. I haven't thought through yet what a better API would look like but I am open to feedback.

Sorry I didn’t get back to this for a bit. I don’t think the request method is irrelevant. The very section you linked to says, “A message-body MUST NOT be included in a request if the specification of the request method (section 5.1.1) does not allow sending an entity-body in requests.” Either way, though, I think your fix is fine, because it basically leaves it up to the user to get things right (i.e. to use empty() for places where they don’t want a body at all, or an empty array if they do).
Maybe “An empty body will have a known length of 0 bytes.” (the comment on the empty() function) is a little bit misleading now, since the thing returned by that function isn’t any more just a zero-byte-long body, it’s actually no body?


Incorrect wording

I think "contains" was meant here.

Code review in https://dart-review.googlesource.com/c/sdk/+/215340
Thanks @mnordine !


Update docs for MSB4U resolution troubleshooting and add additional notes

Overview

Adds a note on using MSB4U for your own project dependencies as well as MRTK's
Adds a note on the .bin and .obj folders that can be safely added to your gitignore

These folders are in this repo's .gitignore, but I don't believe that's distributed via our unity packages since it begins with a . and is thus ignored by Unity

Fixes the .csproj reference for step 2 of troubleshooting the DotNetWinRT dependency

/azp run mrtk_docs

/azp run mrtk_docs


Fix use of group id

Fix the usage of the group id
🗣 Description
Previously the user id was used as group id, which is no problem in most cases. Now the group id can be set as described.
💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Add a tag or create a release.

Sorry, I've changed the wrong line -..-


[ar] Netlify preview needs to be configured for the Arabic branch

This is a Feature Request
As the Kubernetes Arabic localizer, I propose configuring Netlify preview on the Arabic branch (dev-1.29-ar.1) to facilitate the previewing of changes, ensure successful website building, and assist reviewers in examining the content.
The dev-1.29-ar.1 branch has been created specifically to host the Arabic localization efforts. The progress of this localization is being tracked through the following issues:
https://github.com/kubernetes/website/issues/44682
https://github.com/kubernetes/website/issues/37546
What would you like to be added
Configure Netlify preview specifically for the dev-1.29-ar.1 branch.
Why is this needed
It is essential to have Netlify preview for the Arabic branch to facilitate the review process. This preview functionality will be particularly useful for identifying and addressing CSS issues related to right-to-left (RTL) layout, as Arabic is the first RTL language supported. For example, issues such as those outlined in the following PR and issue:
https://github.com/kubernetes/website/pull/46042
https://github.com/kubernetes/website/issues/45077
Comments
The Netlify preview will enable contributors and reviewers to visualize and discuss these issues directly within the context of pull requests, enhancing the efficiency and effectiveness of the localization efforts.
Slack discussion : https://kubernetes.slack.com/archives/C1J0BPD2M/p1714297094044239

/triage accepted

PTAL @sftim

@kubernetes/sig-docs-leads FYI

/area localization

I've added a Netlify site that deploys dev-1.29-ar.1, please check if a preview is available on an updated or new PR

I've added a Netlify site that deploys dev-1.29-ar.1, please check if a preview is available on an updated or new PR

updated this PR and waiting for the build  https://github.com/kubernetes/website/pull/46042

Netlify preview is working now on PRs targeting the branch dev-1.29-ar.1
Thanks @reylejano
We can close this issue now

/close


Allow overriding haskell versions

Supersedes #420. Fixes #384

Very nice! Didn't know about callHackage. Does that just have a database of everything on hackage?

Yup. On that note, I feel like we should be updating nixpkgs on every release? Though currently things (like node and go version) are hard coded and might break.


E-hentai wrong url

Source information
E-hentai 1.4.22
Source language
Multi
Source new URL
https://e-hentai.org
Other details
Currently the open in web browser takes you to exhentai.org which does not exist.
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

If you fill out ipb_member_id and ipb_pass_hash in the extension settings (or have it set by logging into WebView) it will use the alternate domain. IIRC, your account needs to be at least 1 week old before you get access.

If you fill out ipb_member_id and ipb_pass_hash in the extension settings (or have it set by logging into WebView) it will use the alternate domain. IIRC, your account needs to be at least 1 week old before you get access.

Do you know if there's any way to log out from the Webbiew? Atm it directs to a blank screen, so I can't figure out a way to access the original website and log out.

I would try clearing out the values in the extension settings and clear cookies in the app settings. Clearing both since I'm not sure if they are synced.


Enable sync between browsers and mobile in draw-tools plugin. Fixes #1030

This uses the sync plugin to sync items drawn by the draw-tools plugin across browsers and mobile devices.

Previously drawn items will be lost, due to the use of a new data-store and format for recording drawn items to allow for sync updates.
Each drawn item is mapped in sync via its latitude, rounded to 3 places, so that the sync isn't a full update every time.
Fixes #1030

Fixes #350 as well.

I keep thinking it would be better to implement Sync using the existing hook subsystem instead of making it so tightly coupled into the DrawTools code itself.


Fix README.md link for jest

The link currently mistakenly links to mocha instead of jest
That's all! Found this while exploring the code following your video. Thanks for this template and the lessons!

Thanks!


Mk/renaming

rename comm to commutator (fixes #20)
hide iteration requirement behind hasgens (fixes #19)

@fingolfin, @thofma

Codecov Report

Merging #22 (293a02b) into main (10a138a) will decrease coverage by 1.35%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   84.84%   83.49%   -1.36%
==========================================
  Files           3        3
  Lines          99      103       +4
==========================================
+ Hits           84       86       +2
- Misses         15       17       +2

Flag
Coverage Δ

unittests
83.49% <81.81%> (-1.36%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/GroupsCore.jl
26.66% <ø> (ø)

src/groups.jl
85.71% <71.42%> (-4.61%)
:arrow_down:

src/group_elements.jl
98.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10a138a...293a02b. Read the comment docs.

Thanks!

I just added a note on the need to implement Base.size if IteratorSize returns HasShape{N}(). @fingolfin when CI passes I'll bump version and merge this


chore: substitute some . with ·

LGTM, thanks!
maintainer merge

bors r+

In case anyone is interested in making this more structural, I opened #12143, but I am unlikely to have the time to act much on it!


Standard library folder (lib) required for OCaml build

If the lib folder does not exist then make -C src/ocaml_output will fail with:
make[1]: *** No rule to make target `../../lib/ml/native_int/prims.ml', needed by `copy_lib_files'.  Stop.
make: *** [all] Error 2

It does not fail for the F# build because the behaviour is not the same (there is the basic directory)
It would be nice to make all the backends consistent and non-dependant on lib at some point...

Actually a better solution would be to make the files in basic/ links to the files in lib/ (or the opposite) so that we don't have several implementations of the same libraries... (I'm thinking about list that has several copies all over the source tree).
./lib/FStar.List.fst
./lib/list.fsi
./src/basic/list.fs
./src/basic/list.fsi

Lots of work on fstarlib and fstartaclib. This is not longer an issue.


[google_maps_flutter] getZoomLevel for map controller

Description
Added getZoomLevel method to the Google map controller
It was implemented in the ios and android side but not yet exposed
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@Kavantix Thanks for the PR. The change looks good. We would need to add some tests for this to be able to land. Also, CI seems to complain about formatting.

@cyanglaz I’ll look into the formatting
But what kind of test would you suggest?
I cannot find any tests related to the controller fetching data from ios/android.
The only test I would be able to think of would basically test the channel.
Note that the actual implementation of the method is already in master, I just copied it to the controller

@Kavantix there should be some existing e2e tests in the plugin. You can add something similar I assume?

@cyanglaz are the tests ok like this?

@Kavantix Tests looks good! Thanks. Please rebase before we can land this.
Also, could you please update a minor version since we are adding a new feature in this PR.
https://dart.dev/tools/pub/versioning#semantic-versions

@cyanglaz done


How do I apply force to the actuator?

Hello,
I want to apply force to ur5 model but I don't found the function.
I use 'sim.data.ctrl' when I use mujoco-python, anyone can tell me which function can I use ?
Thank you for your answer very much.

Simplest working model. Need more details for a better answer.
m = mujoco.MjModel.from_xml_path(<xml>)
d =  mujoco.MjData(m)

while <simloop>:
  mujoco.mj_step(m, d)
  d.ctrl[<act_id>] = <your_control_value>


armagetronad: <IP_ADDRESS>.0 -> <IP_ADDRESS>.1 + refactor

Description of changes
Update to latest and fix potential crash due to --enable-memmanager (#263244). Add an installCheckPhase and the following passthrus for obscure types of game servers:

pkgs.armagetronad
pkgs.armagetronad.dedicated
pkgs.armagetronad."0.2.9-sty+ct+ap"
pkgs.armagetronad."0.2.9-sty+ct+ap".dedicated
pkgs.armagetronad."0.4"
pkgs.armagetronad."0.4".dedicated

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Marking as a draft until I hear back from the Armagetron team about which repos we should be using.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-december/1711/19

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2872

Switched from bzr to git per Armagetron team recommendation.

This is ready for merge.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2924

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2964

Result of nixpkgs-review pr 263675 run on x86_64-linux 1

6 packages built:

armagetronad
armagetronad-dedicated
armagetronad."0.2.9-sty+ct+ap" (run manually, not recursed into)
armagetronad."0.2.9-sty+ct+ap".dedicated (run manually, not recursed into)
armagetronad."0.4" (run manually, not recursed into)
armagetronad."0.4".dedicated (run manually, not recursed into)

Seems to run fine, LGTM. Thanks


CORGI-195: Fix pnode ordering since it's no longer guaranteed

Quick fix for issue in CI tests.

this PR was committed without running checks


Documentation: Clarification question about the aim of the project

Hello
A question regarding the aim of the project:
If you write easy to understand you are mainly refering to the scripts section of the package.json file
https://github.com/BrandonRomano/static-lite/blob/master/package.json#L65
So the project is about something such as here
https://gablaxian.com/blog/using-npm-as-a-build-tool
which refers to this one
https://www.keithcirkel.co.uk/how-to-use-npm-as-a-build-tool/
?

Hey @hhzl -- Yes that is correct.  Everything this library does occurs from the npm scripts.  The two articles that you've shared describe the approach this library takes.
This library takes advantage of the provided CLIs of other tools, and the npm scripts are simply the glue that puts it all together.
Let me know if that answers your question!

Yes,  thank you for the confirmation. Scripts for npm do a good job for many projects which are not too complex. In the end that saves a lot of time and it will still work in two years :-)


Not Working

[Enter feedback here]
Sometimes the microsoft store can't properly working, so fix that bug.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9db96ae7-52a1-83df-3913-35765fc62972
Version Independent ID: 9db96ae7-52a1-83df-3913-35765fc62972
Content: What's new in Windows 11, version 22H2 for IT pros - What's new in Windows
Content Source: windows/whats-new/whats-new-windows-11-version-22H2.md
Product: windows-client
Technology: itpro-fundamentals
GitHub Login: @mestew
Microsoft Alias: mstewart

@Vinothjv10 , You should post your issue in
https://answers.microsoft.com/en-us/windows/forum/windows_11-windows_store?

@RAJU2529 Ok

Closing issue as there is nothing more to do.


[BEAM-10402] Enable checkerframework globally

Instead of opting out whole modules now only existing classes are opted out of type checking. This has the following benefits:

New code will be checked, even in modules that are not yet passing.
Code won't as easily backslide in modules that were partially fixed.
It will produce much more manageable incremental work, and limitless starter bugs!

I produced this by removing the flag and then repeating the following, more or less:
./gradlew compileJava compileTestJava --continue 2>&1 | tee ~/tmp/gradle.log

cat ~/tmp/gradle.log \
    | grep -e "$PWD"'.*error:.*' \
    | cut -d : -f 1 \
    | sort -u \
    | xargs grep -L -e '^@SuppressWarnings' \
    | xargs sed -E -i '' 's/^(public +)?((abstract|final) +)?(class|interface)/@SuppressWarnings("nullness") &/'

./gradlew spotlessApply

There are two ways to still suppress type checking, arguments to applyJavaNature:

generatedClassPatterns to exclude various generated code that is not annotated with nullness types
classesTriggerCheckerBugs a map from classes which cannot be analyzed to their checkerframework bug URL

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit I don't know why I think you would enjoy / be amused by this, but I chose arbitrarily. @jayendra13 may also be interested.
% find . -name '*.java' -or -name 'build.gradle' | wc -l
    5424

So this involved suppression or tweaking on about 2k out of 5.5k files. You can image how it is important to get this done before we grow even bigger...

Oh now I remember - there was some runtime ramification of enabling checker for certain modules. Do you recall?

I am definitely interested in this, but got stuck with my own work. Will resume soon may be in a week or two 🙂 .

New files since I ran it, of course. It may not be possible to review without that happening during review. It doesn't mean much for the review of the concept, I think.

The NPE reproduced on InMemoryJobServiceTest when mockito tried to mock it. I believe it is a bug in the JDK. Annotations that are not present on the classpath should be "as if they were not there" but instead the JDK NPEs. Maybe they should use checker to eliminate those null errors :-)
Since the annotations are MIT licensed they can be compile scope instead of compileOnly scope. That fixed InMemoryJobServiceTest.

Great ideas.
I learned a bit from:

https://stackoverflow.com/questions/20929176/how-can-i-find-modified-lines-that-match-a-certain-pattern-with-git
https://stackoverflow.com/questions/36932309/how-do-i-git-add-only-lines-matching-a-pattern
https://stackoverflow.com/questions/13955390/git-grep-but-restricted-to-new-or-modified-files-in-the-index
https://stackoverflow.com/questions/1751397/git-grep-cached

In particular, I did not know about git grep or git diff-index at all. Now I do, I guess? I never did figure out exactly how to do what you suggest in one go. Perhaps the best way to check that I got it is to separate PRs...
The enabling (somewhat of a leap of faith?) which I will later rebase -i to come after the rest.
git reset HEAD^
git status | grep build.gradle | cut -d : -f 2 | xargs git add
git commit -m 'Enable checkerframework globally'

I figured out I could commit everything that wasn't a new suppression (interactively, somewhat tedious but far less than 2k files)
git add -p $(git diff-index -G ' .*Nullable.*' HEAD | cut -d ' ' -f 5 | cut -f 2)

And the API surface checks all include a new line of pruningPattern
git diff-index -SpruningPattern HEAD

(needed to tweak interactively)
git commit -m 'Allow checkerframework on API surfaces'

Confirmation that the only things remaining are suppressions at the top level:
git diff -U0 | grep '^[+][^+]' | grep -v '@SuppressWarnings'

(oops there were a few more, which I isolated and committed)

Gya, I botched the API surface patches versus moving nullable annotation patches

OK. The commits look right to me. Let me know if it helps to split things any other way. I had hoped this would be a pretty silly PR but it got slightly involved.

Run Java PreCommit

Hmm this might slow the build down enough that it has to be separated from the CI build.

Run Python_PVR_Flink PreCommit

Run Python_PVR_Flink PreCommit

Run Java_Examples_Dataflow PreCommit

Seeing really wonky errors on Jenkins that I cannot repro locally. Could be checkerframework bugs related to particular JDKs?

Run Java PreCommit

Run Java PreCommit

I'm not saying there isn't a problem with this PR, but this setup is strange. The command ./gradlew pullLicenses essentially is doing a full build as part of that single task, and the two builds do not coordinate so they can clobber/corrupt files. Suspect that this PR just changes the timings so that it happens reliably. Filed https://issues.apache.org/jira/browse/BEAM-11116 and I will see if I can resolve it. So far, the commands run by the script don't seem to work as expected anyhow...

In #13189 I develop a fix and simplification. I see that with and without that fix, pullLicenses does not seem to re-run all the targets. So I would conclude that something in this PR causes the subprocess call to build a bunch more stuff. I don't know what it is.

Since there are lingering issues, one way to make this PR more manageable is to break out the monster commit and get it in: #13191.

Confirmed with git bisect that this change causes the java compile.
--- a/sdks/java/container/build.gradle
+++ b/sdks/java/container/build.gradle
@@ -82,7 +82,7 @@ licenseReport {
               project.rootProject.findProject(':sdks:java:io:kafka')]
   excludeOwnGroup = true
   excludeGroups = ["beam.*"] // project dependencies do not match their maven coords
-  configurations = ALL
+  configurations = ["runtime", "shadow", "compile"]
   renderers = [new JsonReportRenderer()]
 }

I did not also bisect but I also guess that excludes = ['org.checkerframwork:jdk8'] causes the compile. That line doesn't work anyhow, because it excludes deps too late.

Excluding the dep from all configurations is safe and effective, not requiring any alteration to the docker container license pull logic.

The changes to the license logic are separated in #13189 but I added the commits here to get precommit signal while waiting on review there.

Run Portable_Python PreCommit

Java precommit seems to have degraded in runtime.

Before: https://scans.gradle.com/s/gohimd5ekkcmo/timeline
After: https://scans.gradle.com/s/z4brjsxfpftxy/timeline

So it went from 40 minutes to 90 minutes. It isn't apples-to-apples as we have a lot of caching effects since they are just running on Jenkins:

Before: 2375 tasks executed in 116 projects in 34m 18.746s, with 162 avoided tasks saving 1h 19.326s
After: 2463 tasks executed in 116 projects in 1h 20m 11.508s, with 38 avoided tasks saving 14m 48.735s

I think zero-cache builds in some semi-controlled environment might give a better sense whether this needs to be treated specially.

 Certainly the core SDK compile is slower, but even with a huge slowdown in compile the test execution should dominate. So I do think it may be caching that is the difference. Running it a few times to warm the build cache might also give a sense of realistic CI times.

run java precommit

Run Java PreCommit

Yea the re-run took 30 minutes so this might be a non-problem.

https://scans.gradle.com/s/smgegyyrcnoua/timeline but I'm not sure I believe the statement "2463 tasks executed in 116 projects in 26m 4.055s, with 174 avoided tasks saving 5h 43m 25.832s"

run java precommit

Is it all the build.gradle changes invalidating the cache?

TBH not sure

Yea on the bad run it is claiming that compiling the SDK took 16 minutes and compiling the SDK's tests took 30 minutes. So that is orders of magnitude more than what I can repro. Something is awry. I'm going to try a rebase which should un-cache those and we can see if it was isolated. I suspect it was not.

The re-run was 38 minutes, pretty normal. Many things pulled from cache. https://scans.gradle.com/s/wyh5rgkbd3rjq/timeline?sort=longest
"2463 tasks executed in 116 projects in 33m 22.938s, with 173 avoided tasks saving 4h 12m 58.349s"

Here are some samples of runs against commits and phrases:

https://scans.gradle.com/s/acfajsh5mnxj2/timeline?sort=longest
https://scans.gradle.com/s/wbqztstpu7pdo/timeline?sort=longest
https://scans.gradle.com/s/7qqcuygtqlaou/timeline?sort=longest

It is hard to determine the real likely slowdown in practice. The tasks that were the longest and most problematic in the bad run are almost always FROM-CACHE.

On my idle desktop machine:

git checkout github/master && ./gradlew :javaPreCommit --continue --no-build-cache --rerun-tasks --scan https://scans.gradle.com/s/cdfrii6qsopii/timeline?sort=longest
git checkout checkerframework-classlevel && ./gradlew :javaPreCommit --continue --no-build-cache --rerun-tasks --scan https://scans.gradle.com/s/2r65rr5mflsro/timeline?sort=longest

Unfortunate that the build seems very unhealthy on master so I am just looking at particular tasks. It does look like compile tasks are perhaps 5x as slow but it does not affect the overall runtime very much. One option is to cease analyzing test java. These seem to have a much greater slowdown factor. I wonder if incorrect types are more expensive than correct ones...

We have fixed some of the module, so I think creating a map somewhere denoting modules fixed and not fixed would help for better tracking this issue. What do you think? I am soon going to start this again.

I think creating a map somewhere denoting modules fixed and not fixed would help for better tracking this issue

Are you thinking something like a spreadsheet that we would keep up-to-date, or would this be a part of the build.
With the change in https://github.com/apache/beam/pull/13191 we could identify fixed vs. not fixed classes and/or modules by grepping for @SuppressWarnings("nullness") // TODO(https://issues.apache.org/jira/browse/BEAM-10402). Maybe that's enough for tracking? We could put a bash one-liner in the BEAM-10402 comments

Are you thinking something like a spreadsheet that we would keep up-to-date, or would this be a part of the build?
Not part of a build, but some where publicly accessible like kanban board on jira or on github .

OK this is finally healthy and ran in a normal amount of time (precommits tend to be in the 30-60 minute range and this was 30). Only the tests for SDK core are skipped. Hopefully we won't have to skip them forever, since carelessness with nulls in tests is an annoying source of false issues. Going to merge it!

Confirmed that there are no breakages introduced in master since the tests ran here.

Since there are 2000+ classes with issues, probably this is too many Jiras and too much for a kanban? I don't know. Actually each class can be enough of a challenge for a Jira. But maybe Jiras for the module level is easier to manage.
A spreadsheet containing the output of a bash script that finds the TODO might make a lot of sense for tracking the burndown.


Passcode

Description
Setting a passcode allows for an additional layer of security to access the app. With a passcode, and Remember Me enabled your files are secure, and can be viewed by only the user, and still you have the benefit of caching.
Expected result
Each account can have a distinct, four-digit passcode and passcode timeout associated with each device. At specific moments in operation of the application, in order to easily authenticate the user, the application challenges the user to present the passcode.
Those moments are:
Return the application after switching to another one, if the amount of time away has been longer than the selected passcode timeout
Access to most actions that change the passcode
Upon changing the passcode, reentering the new one to confirm that what was entered is what was intended
When the passcode challenge is being used to protect access to a logged in account upon return to the app, the passcode can be bypassed by tapping an X in the upper right of the challenge screen. Upon confirming the bypass the application will logout of the current account and the user will be returned to the application login screen.
Any time that the user attempts to satisfy a passcode challenge and fails, they are presented with a notice of the number of immediately successive failure and that the limit is 5. After five successive failure the application logs out of the current account and returns to the login screen, as with passcode bypass, above.
In either case where the challenge was bypassed, the next time that the logged-out account is logged in (on that device), the user will be notified that they had been logged out due to passcode challenge bypass, and offered the choice of retaining or abandoning their current passcode.
The settings screen has an entry for the account passcode when the account is logged in. The entry indicates whether or not the current account has an assigned passcode.
If the account does not have an assigned passcode, then selecting the item prompts for the passcode and confirmation, and if they're identical then the user is returned to the main settings screen with the passcode indicated active
If the account does have an assigned passcode, then selecting the item prompts the user for the current passcode. If the correct passcode is entered, the user is brought to the passcode details screen.
The passcode details screen:
Turn Passcode Off - if the user satisfies another passcode challenge, then the passcode is deactivated. They are returned to the main settings screen.
Change Passcode - if the user satisfies the passcode challenge, then they are prompted to provide and confirm a new passcode.
Require Passcode - this sets a timeout period within which the user will not be passcode-challenged upon returning to the app after suspending. It defaults to Immediately, and can be set to 1, 5, and 15 minutes, and 1 and 4 hours.
When changing the timeout, the user has to hit the back button to return to the passcode settings screen.
Other information
Reported by: Rebecca Watson
Test case number: TC14
Test run: http://spideroak.testlodge.com/projects/3096/runs/142992?tab=2&run_section_id=76801#executed_case_7188812

@rebeccawatson this auto-created from TestLodge integration but you didn't put any feedback in on what actually happened/why it failed.

Ah, the previous ticket #702 I created in GitHub is the Passcode issue in question


Find boolean params

Hi, is there any way to find boolean params?
E.g: find all is_ready or is_ready_for_admin params with true? If search string looks like A is_ready_for_admin is_ready
[
    {
        title: 'A',
        is_ready: true,
        is_ready_for_admin: true
    },

    {
        title: 'B',
        is_ready: false,
        is_ready_for_admin: true
    },

    {
        title: 'C',
        is_ready: false,
        is_ready_for_admin: false
    }
]

Not currently in the pipeline, as boolean search is not a string approximation problem. However, as a work-around, you could transform the booleans to numbers, thus is_ready_for_admin: true would become is_ready_for_admin: 1, which Fuse would internally change to string, thus is_ready_for_admin: "1".
When you search, before you pass the value to .search, change the boolean-like strings ("true", "false") into their respective binary string representation - "0" and "1".
In theory, this could work. Give it a shot?

@krisk Made my own workaround ) convert booleans to array.
Thnks for an answer.

even if it's not a string approximation, I use fuse for every search related, not only string approximation, would be great if we could search for more things than just strings


Failure to compile - (Don't have a clue)

Hey guys, have been working on the DS for the company I work, since yesterday the project has been behaving strange, not compiling and I don't really get it why. No much essentially was changed, I was basically adding values to preexisting tokens, everything was running according to plan.
This is the log I get for that error:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>7 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
8 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/Users/kleverson.morais/Downloads/vue-design-system-master/vue-design-system/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/usr/local/munki
9 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/kleverson.morais/Downloads/vue-design-system-master/vue-design-system
10 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c',
10 silly lifecycle   'npm-run-all --parallel styleguide theo:onchange theo dev' ]
11 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
12 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
13 verbose stack Error<EMAIL_ADDRESS>start: npm-run-all --parallel styleguide theo:onchange theo dev
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack     at EventEmitter.emit (events.js:182:13)
13 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:182:13)
13 verbose stack     at maybeClose (internal/child_process.js:962:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
14 verbose pkgid<EMAIL_ADDRESS>15 verbose cwd /Users/kleverson.morais/Downloads/vue-design-system-master/vue-design-system
16 verbose Darwin 17.4.0
17 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
18 verbose node v10.11.0
19 verbose npm  v6.4.1
20 error code ELIFECYCLE
21 error errno 1
22 error<EMAIL_ADDRESS>start: npm-run-all --parallel styleguide theo:onchange theo dev
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]
Any good soul able to help? Cheers.

@kleversonmorais Based on the error message can’t say much to be honest, but have you changed anything on your system recently? Maybe updated node version, the os or something like that? What OS & OS version are you running?