[regression 4.2.4-4.3.2] TS 4.3 builds .d.ts using import statements referencing absolute project paths instead of relative paths

🔎 Search Terms
regression declaration file .d.ts imports relative absolute projects project-based build 4.3 4.3.x
🕗 Version & Regression Information

This changed between versions 4.2.4 and 4.3.2
Issue remains reproducible in the latest next build, currently 4.4.0-dev.20210602

⏯ Playground Link
Here is a repo with a minimal scenario (5 TS files + tsconfig.json):
https://github.com/ronjouch/ts43-import-regression
Just clone it and run npm run repro (after verifying what the script does)
💻 Code
This bug seems to be about projects, imports/exports through multiple files, so it gets confusing when having to list the multiple files here in a linear issue. Please check the repo.
Or see https://github.com/ronjouch/ts43-import-regression/commit/f55df20fc7cacd946cd3cd2ad5f99a08d7606290
🙁 Actual behavior
TS 4.3 writes .d.ts files that contain import statements referencing the local absolute project folder name (src-types in my example), which is meaningless and will cause dependents of the library to break.
See the second & third section of npm run repro (a helper script that builds under 4.2 & 4.3, and greps the culprit output):
===== Now with TS 4.3: the relative import will no longer be relative but absolute using the
===== project folder name, causing the library to break when used in another context

+<EMAIL_ADDRESS>updated 1 package in 0.688s

><EMAIL_ADDRESS>compile /home/ronanj/ts43-import-regression
> tsc --build src-types src-dogs

    protected static getDogConfig: () => import("src-types").DogConfig;
                     HERE: bad, absolute import ^^^^^^^^^^^

===== And lets see if it is fixed in the last nightly...
+<EMAIL_ADDRESS>updated 1 package in 0.662s

><EMAIL_ADDRESS>compile /home/ronanj/ts43-import-regression
> tsc --build src-types src-dogs

    protected static getDogConfig: () => import("src-types").DogConfig;

🙂 Expected behavior
TS should resolve types in .d.ts using relative imports.
This is what happens with TS 4.2.4, see the first section of npm run repro:
+<EMAIL_ADDRESS>updated 1 package in 0.687s

><EMAIL_ADDRESS>compile /home/ronanj/ts43-import-regression
> tsc --build src-types src-dogs

    protected static getDogConfig: () => import("..").DogConfig;
                  HERE: good, a relative import ^^^^
===== Notice above how the type of getDogConfig type was compiled to a proper *relative* import,
===== through index.ts itself referencing something relative. Good.

OK, I spent way, way too long getting this into a testable baseline format before going "doh" and realizing that this is actually just working as expected ("regression" or no) - we prefer nonrelative paths where possible, and the baseUrl compiler option indicates that nonrelative references from that given path are a-OK (seriously: you're allowed to write these paths in your code and we won't issue an error). If you remove the baseUrl option form your base config, we'll no longer generate paths like this.


Overshoot with position-based ros_control interface caused by internal servoj Pure Pursuit controller?

The problems with the position-based controller is already known, and can be corrected to a certain degree by tweaking the parameters: https://github.com/ThomasTimm/ur_modern_driver/issues/47
My project group tried to use this controller on a UR3-robot, and tried to tweak the parameters to our needs. However we couldn't get this controller to work in a stable manner with the precision we needed. I think I found the root of the problem while documenting our efforts. The parameters defined in the servoj command is usually used in a Pure Pursuit controller. These kind of controllers give smooth trajectories, but doesn't assure that the robot follows the points along the path. I therefore think that the poor performance is caused by Pure Pursuit controller in the robot not being precise enough for the strict position-based controller in ros_control. We tried loosening the constraints by giving the robot "infinite" time to execute the trajectories, and even though it had a lot of overshoot, it succeeded. In conclusion: the position-based approach in ur_modern_driver should probably be based of movej commands with blending instead.
The picture under Look Ahead Distance in this link illustrates the situation pretty well: https://se.mathworks.com/help/robotics/ug/pure-pursuit-controller.html

Thanks for your comment @mortaas. Interesting indeed.

In conclusion: the position-based approach in ur_modern_driver should probably be based of movej commands with blending instead.

At first glance, your statement would seem to go directly against the analysis done by @ThomasTimm and his group (UR10 Performance Analysis). Have you read that report?

I'm closing this as we've officially deprecated this package.
Refer to the announcement on ROS Discourse.

If this appears to stil be an issue with ur_robot_driver, please open an issue on the ur_robot_driver issue tracker.


Migrate to Polymer 1.0

Basically did sed "s/0.5/1.0/g"

What do you think, @crhym3?

It's more than that, unfortunately.
A couple things spotted right away:

there are no more <core-*> elements, most of them have been ported to <iron-*
an element definition like <polymer-element name="post-card"> won't work anymore. It's been changed substantially.

There's a tool called polyup which is like "go fix". Migration guide explains most of it: https://www.polymer-project.org/1.0/docs/migration.html
Also, it's better to use 1.2, well the latest.

btw, I don't think links like https://www.polymer-project.org/1.0/components/polymer/polymer.html actually exist. It's still serving 0.5. Check this out: https://www.polymer-project.org/1.0/components/polymer/polymer.js

// @version 0.5.5

@x1ddos is right unfortunately. Some elements are radically changed in 1.0 version. So a sed "s/0.5/1.0/g" isnt working. Polyup is a great tool to migrate from 0.5 to 1.0, I ve tried it on this project.But still some of it you have to do manually. And what is the replacement for <google-api-loader id="api" name="posts" version="v1" appId="polymer-gopher" root="http://localhost:8080/_ah/api"> in Polymer 1.0 ?

Polymer Project is forewading like wildfire. We have 1.7 stable release and  they are thinking about 2.0. So I think bower will be a good solution for Polymer version upgrades.


People app does not show up after restart

I have quite a peculiar problem. It is 100% reproducible for me.

Pull and build Launcher (current master - https://github.com/StarcounterPrefabs/Launcher/commit/7bd6d3e2fda78e18853e71f91bfc665d97c88ff4) and People (current master - https://github.com/StarcounterSamples/People/commit/52e0f76cb1ef461816eea6bfc818ccdc1df96cba)
Start Starcounter
Clean styles (DELETE http://localhost:8080/sc/layout?all)
Start Launcher and People using a batch file
Restart Launcher and People using the batch file.

For some reason it is reproducible only when restarting the app from the batch file, not when starting from Visual Studio. This is the strangest thing about this problem.
This is my batch file:
cd c:\www\starcountersamples\launcher
star bin\debug\launcher.exe
cd c:\www\starcountersamples\people
star bin\debug\people.exe
cd c:\www

After restart, People app shows empty workspace when loading http://localhost:8080/people/organizations
Interestingly, juicy-tile-list prototype shows some weird input in _defaultSetup. Screenshot below:

@miyconst I need your help with this. Please let me know if you can reproduce it.

It seems that the namespaces in the merged JSON file are sometimes camelcase (when starting from VS) and sometimes lowercase (when starting from the batch file). This might be the reason.

Yeah, I can confirm that this is because juicy-tile-list is totally confused by Starcounter not normalizing the executable name from the CLI:

It also appears like that in Administrator:

@chrhol, @per-samuelsson, @andwah - any advice? I believe this is not desired.

What adds some spice to the problem is that Launcher 3.0.14 was immune to this problem.
Launcher 3.1.0 (first version that supports juicy-tile-table) and master are sensitive to it.
@tomalec can you think of any reason for this?

I created a related issue in Starcounter: https://github.com/Starcounter/Starcounter/issues/3394

@chrhol, @per-samuelsson, @andwah - any advice? I believe this is not desired.

I commented on the Starcounter tracker.

I suspect the reason that juicy-tile-list is more sensitive to that it uses latest juicy-tile-list which shorten, and changed the flow for setup reading, but I'll investigate it deeper.

Closing, because it is related to the old layout editor which was phased out.


[BUG] VariantType does not implement to_glib_full, panics

Bug description
https://github.com/gtk-rs/gtk-rs-core/blob/db041297159cab441865c7cb82b7ea8205141ace/glib/src/variant_type.rs#L99-L106
https://github.com/gtk-rs/gtk-rs-core/blob/db041297159cab441865c7cb82b7ea8205141ace/gio/src/subclass/action_group.rs#L782

See https://github.com/gtk-rs/gtk-rs-core/pull/249

@mahkoh Is it blocking you currently? I would include this in the new 0.14 bugfix release but unless that's urgent for you I'd wait a few days with that.

@sdroege I've locally patched glib to fix the problem. It's not blocking me right now.

Ok, let me know if you need a bugfix release on crates.io with this :) Let's hope I do that before you have to ask though!

Done now, this is in 0.14.5


Fix label name for report link

https://english.stackexchange.com/questions/549295/on-the-link-in-the-link-or-at-the-link

@kadehar @svasenkov could you please review the changes?


Fix tunnel remote host

Fixes https://github.com/microsoft/vscode-remote-release/issues/5613

The original fix for microsoft/vscode-remote-release#5613 caused the "Open in Browser" button in the ports view to stop working. This happened because the NodeRemoteTunnel no longer kept the original host as it's tunnelRemoteHost and instead changed to localhost if the host was localhost or all interfaces. Later, when commands try to find the tunnel, they end up looking for the original host, not localhost, and they don't find the tunnel.


feat(Enterprise management): re-gen service after taits object schema…

… change
PR summary
service after traits object schema change in create account request object
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

:tada: This PR is included in version 0.34.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(live-codeblock): add support for noInline to interactive code blocks

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

These changes were prompted by several new Docusaurus-based sites that Formidable is working on.
For now we've achieved this functionality by swizzling Playground, but it seemed prudent to propose contributing this back upstream so others can use it too.
Test Plan

Tests feel like they may not be required in this case (?) -- however I have included documentation updates which should adequately demo this functionality.
Test links

Deploy preview: https://deploy-preview-7514--docusaurus-2.netlify.app/docs/markdown-features/code-blocks/#imperative-rendering-noinline
Related issues/PRs

p.s. I've also seen the work in https://github.com/facebook/docusaurus/pull/6589 which would replace react-live as the library powering Interactive Code Editors.
The noInline prop isn't required for that library -- and code samples which work correctly with this would continue to do so even if that other PR lands and you move away from React Live 😅
given that context, is it worth me opening a separate PR to update the version of react-live this project currently uses? Docusaurus is currently on<EMAIL_ADDRESS>but the latest is<EMAIL_ADDRESS>I'd love to support that upgrade however I can if that's of interest.

TBH I don't like the idea of introducing render() in the doc for multi statements support, as you can see more and more doc sites are using export default App which is also supported by react-runner seamlessly, and no noInline needed, you are free to switch between inline or noInline mode, like https://www.radix-ui.com/docs/primitives/components/accordion, the source code could be runnable directly in react-runner without any change, and you can see how easy it is to integrate it https://github.com/radix-ui/website/pull/329/files


Deadlocks in database on some inserts because of a deadlock

Sentry issue #BACKEND-35C
(psycopg2.errors.DeadlockDetected) deadlock detected
DETAIL:  Process 80047 waits for ShareLock on transaction 6915883; blocked by process 80050.
Process 80050 waits for ShareLock on transaction 6915882; blocked by process 80047.
HINT:  See server log for query details.
CONTEXT:  while inserting index tuple (459,65) in relation "_hyper_2_12609_chunk"

Increased deadlock_timeout to 2s on the prod database server


Add NC to states coming soon

Learned in Demo Day that North Carolina is working with ReportStream, so added them to coming soon on the map + list!

I think we might have a template/workflow for adding new states now. Right @jayna-SkylightDigital ?

I think we might have a template/workflow for adding new states now. Right @jayna-SkylightDigital ?

@Rebecca-LM we have an issue template for it, but that is for when states go live. North Carolina is being moved to "coming soon" as they've just begun working with the ReportStream team.


TextEditingController makes page rebuild

Steps to Reproduce

The app has 2 tabs, The first tab get user's input and display results. If uncomment line 79
//controller: textController, Then go to the second tab, click the button, navigating to the new page and return back to the first tab, all the data will remain the same. If using TextEditingController, changing line 79 to controller: textController, , do the same thing, the data will lost after getting back to the first tab.
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'test',
      home: DefaultTabController(
        length: 2,
        child: Scaffold(
            body: TabBarView(
              children: [new Search(), new Setting(),
              ],
            ),
            bottomNavigationBar: Container(
              height: 60,
              child: new TabBar(
                tabs: [
                  Tab(icon: new Icon(Icons.search)),
                  Tab(icon: new Icon(Icons.settings)),
                ],
                labelColor: Colors.blue,
                unselectedLabelColor: Colors.grey,
              ),
            )
        ),
      ),
    );
  }
}

class Setting extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return IconButton(
        icon: Icon(Icons.check),
        onPressed: () {
          Navigator.push(context, CupertinoPageRoute(
              builder: (context) =>
              new Scaffold(
                appBar: AppBar(title: Text('3'),),
              )));
        });
  }

}

class Search extends StatefulWidget {
  @override
  createState() => new SearchState();
}

class SearchState extends State<Search> {

  String currentWord = '';
  final TextEditingController textController = new TextEditingController();

  @override
  void dispose() {
    textController.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
        appBar: new AppBar(
          title: new Row(
            children: <Widget>[
              new Expanded(
                child: new CupertinoTextField(
                  style: TextStyle(color: Colors.white),
                  cursorColor: Colors.white,
                  //controller: textController,
                  maxLines: 1,
                  clearButtonMode: OverlayVisibilityMode.editing,
                  onChanged: (text) {
                    setState(() {
                      currentWord = text;
                    });
                  },
                ),
              ),
            ],
          ),
        ),
        body: ListView.builder(
            itemCount: 5,
            itemBuilder: (context, i) {
              return Text(currentWord);
            })
    );
  }
}

Results
The expected result(without controller set):get back and the state keeps the same.

Actual results(with controller set): get back and the state lost

Have you tried with https://stackoverflow.com/questions/53869795/flutters-automatickeepaliveclientmixin-doesnt-keep-the-page-state-after-naviga/53871723#53871723 for the SearchState?
Please consider asking support questions in one of the other channels listed at http://flutter.io/support .


Question about VisEvent Precssion plot diagram

In your paper, the VisEvent Precssion plot  diagarm is displayed below

It can be found that the precision of SDSTrack is 0.767 ,and ViPT is 0.758
But I got a diffierent result when I use the VisEvent benchmark toolkit ,which is displayed below

The number of SDSTrack is 0.736 and ViPT is 0.731
I would like to know what caused this situation, and if there were any special settings made to the VisEvent benchmark toolkit?
Thank you very much

Are you sure you used the evaluation tool I provided here? I just re-tested it and it is fine, it is consistent with the paper

Thank you very much !! I found what make this problem is that line 74 - 75 in Evaluate_VisEvent SOT_benchmark.m


azureiotsolutions.com not available

Why is azureiotsolutions.com not available? Is there any other way to access my existing simulations?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59514d13-30c3-625f-2c52-05c9ea0be129
Version Independent ID: 0a6b26a8-37d4-c45c-350a-6001180504a0
Content: Try and run a device simulation solution - Azure
Content Source: articles/iot-accelerators/quickstart-device-simulation-deploy.md
Service: iot-accelerators
GitHub Login: @troyhopwood
Microsoft Alias: troyhop

@pekanovics What is the exact issue you are facing when you open https://www.azureiotsolutions.com/ ?  It is working fine.
Make sure you are using correct subscription.

It is working now


improve warnings

2 commits;

describe changes when switching to new commands
diplay message when reading from stdin

Codecov Report
Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (26b73bf) 32.89% compared to head (442c23b) 32.83%.
Report is 3 commits behind head on main.

Files
Patch %
Lines

cmd/gateway_validate.go
0.00%
7 Missing :warning:

cmd/file_convert.go
0.00%
6 Missing :warning:

cmd/gateway_diff.go
0.00%
6 Missing :warning:

cmd/gateway_sync.go
0.00%
6 Missing :warning:

cmd/gateway_dump.go
0.00%
5 Missing :warning:

file/readfile.go
0.00%
2 Missing and 1 partial :warning:

cmd/gateway_ping.go
0.00%
1 Missing :warning:

cmd/gateway_reset.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1115      +/-   ##
==========================================
- Coverage   32.89%   32.83%   -0.06%
==========================================
  Files         103      103
  Lines       12839    12859      +20
==========================================
- Hits         4223     4222       -1
- Misses       8207     8227      +20
- Partials      409      410       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Based on feedback so far I think we should keep -s as the default, even in the new aliases. It should be a 1:1 implementation for the existing command (with positional arguments in place so that we don't break BC for people that already migrated).
With that in mind, this PR provides inaccurate guidance and shouldn't be merged.

As discussed, let's make -s/--state and positional arguments for the gateway commands both supported and I think we should change the documentation to say something like the following that indicates why a user may want to switch from the -s to positional:
Use 'deck gateway diff' instead.
Note:
  - see 'deck gateway diff --help' for changes to the command\n"+
  - The new command supports the '-s/--state' flag for backward compatibility but also supports specifying state files as positional arguments which allows for alternative shell expansions (`*.yaml`).

We shouldn’t provide two ways to do the same thing long term. If positional arguments are the future, then the PR is ok, but I’d like @hbagdi to sign off. We chose flags for a reason in the original design

My feedback is driven to help a user understand the differences in capabilities of the two options, which it seems we have established are staying in the tool (-s to maintain BC and positional to maintain BC with early adopters).  IIUC the two options provide different capabilities on the shell, so we should document that.

Here is the change that needs to occur with the current deprecation messages for all commands that have been marked deprecated by this change.
Currently the messages read as follows:
Warning: 'deck sync' is DEPRECATED and will be removed in a future version. Use 'deck gateway sync' instead.

These will change to:
Info: 'deck sync' functionality has moved to `deck gateway sync` and will be removed in a future MAJOR version of deck. Migration to `deck gateway sync` is recommended.
    Note:
        - see 'deck gateway sync --help' for changes to the command
	- files changed to positional arguments without the '-s/--state' flag
	- the default changed from 'kong.yaml' to '-' (stdin/stdout)

@mikefero  @mflendrich - I think this just needs an approval and merge and a new build of Deck. Can you guys help move this along?


Mistake in text?

> "The following example uses Premium Managed Disks and specifies that the underlying Azure Disk should be retained when the pod is deleted:".
Why not when the PVC is deleted?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 724d659c-dcc8-7c77-1994-b3e8cc62eb8f
Version Independent ID: f6c82819-267b-6d05-fb0b-ced6f4eb5ca3
Content: Concepts - Storage in Azure Kubernetes Services (AKS) - Azure Kubernetes Service
Content Source: articles/aks/concepts-storage.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@dealancer Thank you for the reaching out. We are actively investigating and will get back to you soon.

@MicrosoftDocs/aks-pm Please add your comments

Actually I realize that you can bind PV directly to pod or pvc so both options are correct.

Thanks for sharing the update.
We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.
As Vikas hears any other details from the product team, we will be sharing it here.


Renode Error

When running
scripts/setup
cd proj/example_cfu
make renode
I get following error:
`
21:34:35.8609 [INFO] Loaded monitor commands from: /home/halteproblem/Dokumente/CFU-Playground/third_party/renode/scripts/monitor.py
21:34:36.4144 [INFO] Including script: /home/halteproblem/Dokumente/CFU-Playground/proj/example_cfu/build/renode/digilent_arty.resc
21:34:36.4279 [INFO] System bus created.
21:34:37.0805 [WARNING] SimulationFilePath not set!
21:34:37.6377 [INFO] digilent_arty: GDB server with all CPUs started on port :10001
21:34:37.7012 [ERROR] cpu.cfu0: Error while opening dynamic library: /home/halteproblem/Dokumente/CFU-Playground/proj/example_cfu/build/renode/libVtop.so: undefined symbol: tlib_try_interrupt_translation_block
`

If I change the generate_renode_scripts.py to use the antmicro libVtop.so it seems to work.
    result = """ using sysbus mach create \"""" + target + """\" machine LoadPlatformDescription $ORIGIN/""" + target + """.repl $cfuLinux?=@https://dl.antmicro.com/projects/renode/verilated-ibex--libVtop-s_527064-bf919fbb21bc3242cbc09f05a8a8cac4037daaff machine StartGdbServer 10001 showAnalyzer sysbus.uart showAnalyzer sysbus.uart Antmicro.Renode.Analyzers.LoggingUartAnalyzer """     if cfu_lib_filepath:         result += """ cpu.cfu0 SimulationFilePathLinux $cfuLinux """

@Halteproblem , thanks for the report; I reproduced the issue.    And also replicated the workaround that you provide -- thanks!
The background is that we haven't been able to bump the Renode version for many months due to an unknown issue (https://github.com/google/CFU-Playground/pull/794#issuecomment-1581886463).   The issue here might be that we're mixing the old pinned Renode (which should still work) somehow with more recent Renode (I haven't had a chance to look where that might be happening).

This was caused by a recent change to renode-infrastructure that added a dependence on tlib in renode_imports.h:
https://github.com/renode/renode-infrastructure/commit/1858ed0dce8d03e2d1036747b83ab54eff4731bb
scripts/setup grabs files from renode/renode at a particular commit.  But for files from renode/renode-infrastructure it just grabs from current master, which is why we were affected and Renode sim broke even though we made no changes in CFU Playground.
I have a PR in progress to pin our reference to renode/renode-infrastructure to before the commit that caused the issue.   (Other options that we might consider in the future would be to add a patch for renode_imports.h, or, request that upstream they make the 'tlib' dependency conditional using #ifdef.)
FYI @PiotrZierhoffer

@tcal-x I think pinning is a good way forward. Right now we are in progress of a serious overhaul of the native calls layer, so this might repeat in future


Paste from cliboard (wl-paste)

I am not sure if this is intentional or not, but it seems like pasting text into tofi isn't currently supported

Thanks, this is something I just hadn't thought to do yet - it should be working in 0855afdb1ea7734501914679e50be3d324744d83.

can confirm it works, tysm :)


Executable name overlap

Where does the name come from? Maybe not a big issue, but ABINIT package has aim executable, too. See the doc. (abinit package is available in the universe/science repository of Ubuntu.)

Hi @jarnos,
Initially I "aimed" the tool at an file URL to download it. Hence the naming.
I like the naming because you can "aim from X" and "aim to Y", the same way you would use redirection in a shell.
Took a look at the doc, not very familiar with ABINIT but it seems a cool project.

I'm closing this issue since I would like to keep the current naming.


Dolphin7.exe fails to open the default image, when started without arguments

Hi everyone,      (I'm RichardR on c.l.s.dolphin)
Here is my first contributing issue+fix to Dolphin 7.
I will continue later with a Github fork and pull request, also a first for me.
====
Issue:
Dolphin7.exe, when started without arguments,  fails to open the default image "Dolphin.img7" in the same folder.
This functionality is good to have in VM development, when you want to be sure you are using the right (development) VM exe.
It's also handy for (test) deployments that don't use Lagoon. E.g.: Where you deploy an image without stripping the dev env.
The fix is in two places, specified below, with original code commented out.
1 - Change assert that there must be at least two command line arguments
2 - Check before parsing over the "image" command line argument if it was given.
Any comments before proceding?
Cheers,
Richard
==== Proposed sourcecode:
CommandLine>>initialize: anArray
argv := anArray.
"self assert: [2 <= argv size]."
self assert: [argv size >= 1].	"Fix: argv size 1 is OK, open default image"
optIndex := 1.
optionPrefixChars := '-/'.

CommandLine>>parse
arguments := OrderedCollection new.
options := OrderedCollection new.
parsingArgStream := (ReadStream on: argv)
	next; 	"exe"
	"next;" 	"img7"   "Fix: Don't assume image name is 2nd argument"
	yourself.

parsingArgStream atEnd ifFalse: [	"Parse and discard image name"
	parsingArgStream next. ].

[parsingArgStream atEnd] whileFalse: [	"iterate over the argv array"
	self parseNextArg.
].
arguments := arguments asArray.

Hah @jgfoster ,
With your recent fix "CommandLine fix for runtime #42" you almost also fixed this issue.
When Dolphin7.exe it now opens Dolphin.img7 (with DRPO.* renamed to Dolhin.*).
But behind the splash screen there is a walkback error window:

The culprit is:
DevelopmentSessionManager>>processCommandLine
...
arguments := commandLine arguments allButFirst. "leave off image name"
...
Where "allButFirst" fails because the "commandLine arguments" returns an empty array. (no arguments)
James: You you want to fix this one yourself?
Cheers, Richard

@FunctionPoint, Thanks. See https://github.com/dolphinsmalltalk/Dolphin/pull/45.

Fixed by @jgfoster in: Fix problem if no image name provided #45


Can't find accessory code for Envoy after bridge is added to Apple Home

I was using HOOBS with the Envoy plugin, and it was working great. I'm rebuilding everything in native Homebridge. I got the Envoy plugin installed as a child bridge, and added the bridge to the Apple Home app. The bridge shows up in Home Controller. However, when I go to add the Envoy accessory in the Home app, it's asking for a pin or QR code.
The "setup code" in the Homebridge logs that immediately follows the Envoy log entries (e.g. 777-66-555) is NOT accepted by the Home app when tapping on the Envoy accessory. 777-66-555 is the same code as the primary Homebridge bridge, which I'm not using (all child bridges). So I'm confused which code I need when adding the Envoy accessory.
[01/12/2022, 10:57:29] Please add [Envoy-S A2B7] manually in Home app. Setup Code: 777-66-555

The code is always the Homebridge code.


Deprecate Instruction.condition in favor of IfElseOp

What should we add?
Instruction.condition is Qiskit's way of representing classical execution of instructions based on the values in specified classical registers. However, due to it's location as a property on Instruction (but outside params) has historically lead to it being overlooked, resulting in a handful of bugs where this condition information is either lost or not considered e.g. when evaluating instruction order (Some examples: #6475, #6810, #8553, #8040, #7950, #7247, #7006, #6994, #6583, #6192, #6016, #4727, #4672, #3164, #3215, #2667, #2571 .) Additionally, it is one of the pieces of mutable state that is currently preventing us from moving toward more lightweight Operation instances ( to resolve e.g. #3800, #5895, #7624, and  #9372 ).
IfElseOp can currently represent a superset of what can be expressed with Instruction.condition and is more inline with how we expect to handle conditional and control flow operations going forward, so we should plan to deprecate Instruction.condition with equivalent usage of IfElseOp. This issue is to discuss and plan that process.
Deprecating Instruction.conditionwhile maintaining full backwards compatibility seems difficult (due to both a change in Operation type from Instruction to IfElseOp,  and  due to .condition being a property of the Instruction without context of the QuantumCircuit in which it is included). The following are two use cases to consider:
>>> qc = qk.QuantumCircuit(2,1)
>>> qc.h(0)
>>> qc.measure(0,0)
>>> qc.x(1).c_if(0, 0)

qc = qk.QuantumCircuit(1, 1)
qc.x(0)
qc.data[0][0].condition = (qc.clbits[0], 1)

Additionally, we should:
1)Updating existing visualization to inspect IfElseOp operations and, when possible, draw as an equivalent condition
2)Updating qiskit.assemble, similarly to visualization, to replace applicable IfElseOp s with their equivalent condition representation

In practice, the routing performance for conditioned single 1q and 2q blocks is currently very different compared to the .condition path as well, because of the way we do routing.  Explicitly: for a .condition gate, we will apply layout transformations and insert swaps as if the 1q/2q gate is a completely standard gate, but in the IfElseOp form, any routing required for the layout will happen conditionally inside the If and then need to be undone within the same block.  Given that the chance that a condition is true (by a very naive estimate based on us doing exact numeric equality) is less than 50%, this might be the preferred way, but the eager "stop the world and consider only this gate" approach we take right now is likely compromising parallel routing quality.

TBH, I'm personally less concerned about that for this issue at least. It's an optimization/fix we can work on in parallel and also do post-deprecation. For me, to deprecate c_if/condition we need to be able to functionally do all the same stuff with IfElseOp (which offers a superset of functionality). The only big missing piece is #9417 I think.

Agreed - I'm mostly trying to get these thoughts written down.  Kevin and I had a meeting where that routing quality was a concern, so it'll affect some users, but it's likely lower priority than getting the Instruction.condition mutable field gone.

I think this can be taken off 'on hold' since the work for https://github.com/Qiskit/qiskit-terra/issues/9417 is in flight, and doesn't strictly block the development of this issue, only its release.

I looked at this today and I think it's too soon for 0.25 especially with the proposal freeze so close. Besides being blocked on #9417 actually merging (which there are enough moving pieces in progress still that it'll be tight to fit in the release). The actual mechanics of this are more involved than I think is reasonable in the time frame for 0.25, mostly around testing. There are 7685 tests that fail locally because of the deprecation warnings. These will all need to be updated to catch the deprecation warnings. If we want to do this I think the better time frame is to do this early in 0.26/0.45 to ensure we have enough debug time for any issues that will inevitably come up from the deprecation especially for something as core as c_if/condition.


[IN PROGRESS] Feature/encryption

Ported Encryption from CI3

Refactoring in progress, adding EncrypterInterface and handlers for the different providers.
Would you like to see these pushed to this PR, keeping the comments with it, or should this be a new PR?
If a new PR, close this one so I know :)
The changes will be ready sometime this weekend.

Sounds good.
Feel free to keep them in this PR.

Not quite ready yet, but I pushed what I have so you can see where I am going with this :)

@jim-parry Any luck with this one now that you're back from vacation?

Getting back to it :) I'll try to get it ship shape in the next few days.

Simplifying based on investigating Sodium & crypto support in other frameworks.

Debugging; not convinced I have sodium properly installed :-/

@lonnieezell I will deal with the Sodium handler in a separate PR. I suspect I have not configured it properly, and it is causing issues. It is also very different from OpenSSL ... magic cipher/mode selection, for instance.

Ok, sounds good. If you're ready then, merge away. :)


A question in sdsIncrLen

In the function sdsIncrLen, I think the  statement  "assert(sh->free >= 0) " is redundant, because "assert(sh->free >= incr)" makes sure this situation would not happen.
void sdsIncrLen(sds s, int incr) {
struct sdshdr sh = (void)(s - sizeof *sh);
assert(sh->free >= incr);
sh->len += incr;
sh->free -= incr;
assert(sh->free >= 0);
s[sh->len] = '\0';
}

Yeah, the only thing that could make it be less than 0 would be in a multithreaded programs where two threads are trying to modify the same string at once, but that’d be very broken.
Anyway, @antirez seems to have no intention of maintaining SDS and I emailed him a couple of months ago about it but he never replied, so I’m working on a fork currently located at https://github.com/yabok/sds, though it will be moved to (most likely) https://github.com/yabok/yasl soon.

See pull request #45 for a fix.

@lemzwerg If you look at the repo history and the other PRs and issues open you can see how it's pretty useless to open a PR on this repo.

Maybe, yes.  However, the PRs I produce are just a byproduct and quite easy to generate, so why not.  I'm used to normally commit code with associated ChangeLog entries; this essentially means that you have to concisely wrap up your modifications in an atomic way – in most cases this already corresponds to a PR...


DeepSleep function shuts system completely down and never puts ESP32 into deep sleep

Hi guys
I don't think the DeepSleep function works as expected. When I call M5.Axp.DeepSleep(1000 * 1000 * 2); I'd expect the system to restart from deep sleep after about 2 seconds, but instead the system shuts down completely and never wakes up again from deep sleep.
The reason I think is that SetSleep(), called from within DeepSleep(), turns off power to the ESP32 IC and therefore line (time_in_us == 0) ? esp_deep_sleep_start() : esp_deep_sleep(time_in_us); is never executed and the system never goes into deep sleep but is shutdown completely.
Note: If I comment out SetSleep() then deep sleep works as expected.
Thanks
Felix

Hello, could you please provide the complete code you are trying to execute?

Hello @Zontex
sure, here you are. The code below never actually goes into deep sleep and therefore doesn't wake up after 2 seconds.
#include <M5Core2.h>

void setup() {
  M5.begin();

  Serial.println("Deep sleep for 2 seconds.");
  delay(100); // allow print to finish

  M5.Axp.DeepSleep(1000 * 1000 * 2);
}

void loop() {
}

I don't think commenting out SetSleep() is the correct solution here. I think SetSleep() is intended to prepare for deep sleep / light sleep and turn off everything that is not essential to save energy during deep sleep, e.g. everything except power to the ESP32.
BTW: M5StickC uses the same AXP192 and SetSleep() there is coded a bit differently. Maybe have a look there?
Thanks
Felix

Hi @Zontex
Re SetSleep(): I am wondering about below line - I don't think it does what the comment implicates:
Write1Byte(0x31, Read8bit(0x31) | ( 1 << 3)); // short press to wake up
Register 0x31 deals with power off voltages and (1 << 3) which equals to bit 3 is reserved in register 0x31 so in my opinion this line does nothing at all. Or am I missing something?
Thanks
Felix

Hi @Zontex
Re SetSleep(): I am wondering about below lines:
uint8_t buf = Read8bit(0x31);
buf = (1 << 3) | buf;
Write1Byte(0x31, buf);

Register 0x31 deals with power off voltages and (1 << 3) which equals to bit 3 is reserved in register 0x31 so in my opinion this lines do nothing at all. Or am I missing something?
Thanks
Felix

Hi @felmue does it has anything to do with your pull request regarding the AXP192? I've sent it to our engineers to take a look hopefully they will confirm it ASAP and I will merge your pull request, really appreciate your contribution!
If the pull request you've submitted doesn't solve this issue, I'll personally take a look into it to see what's going on.

Hello @Zontex
you are welcome, but no, my recent pull request regarding AXP192 doesn't solve this (deep sleep) issue. It corrects the RTC backup battery charging current which is not related to deep sleep.
Thank you for taking the time to look into this (deep sleep) issue. If I knew a solution I'd propose a pull request, but I am not clear myself what should go into SetSleep() function to prepare for deep sleep.
Thanks
Felix

Hello @Zontex
ok, today I took a stab at fixing light / deep sleep for M5Core2. I also added an example to show how light / deep sleep works.
Please have a look and please let your engineers double-check I didn't miss / broke anything. Pull request
Thanks
Felix

Hi @felmue sorry for the late reply, had a day off yesterday.
I'm super thankful for your contribution to the community, makes the world a better place for all of us.
I'm going to test it today and if no issues found I'll approve the pull request.
again, thanks for your contribution!

Hi @felmue I merged it into our master repo, thanks for your contribution!

Hello @Zontex
no worries, I hope you had a great day off.
Cheers
Felix


Merging segment alignments with edyeet and wfmash

Hi Erik
I have a question about the -M parameter for edyeet and wfmash. Since it produces a better overall mapping by merging the alignments of each segment, wouldn't it be better to use -M every time? Or is it way too costly for whole chromosomes? Whats the general increase in run time using -M for whole genomes/chromosomes? Does leaving out the -M parameter leave artifacts in the alignments/variants? is it something only worth doing for smaller gene regions? Would it be worthwhile using the -M parameter as the final step for the final production level pangenome graph, after all parameter testing is done? Thanks.

I have been experimenting with it. There are two main problems. First, it
tends to use a lot more memory and time to align very long segments, which
makes the runtime a bit hard to control. Second, -M doesn't provide the
same kinds of numerical guarantees as -n, or at least it is incompatible
with the formulation of -n. This makes the resulting alignments somewhat
ragged in length and quality. Both of these issues could be mitigated
various ways. For instance, we could merge the alignments but still align
small fragments to keep memory down.
I wonder if improvements to the chaining algorithm could resolve this. A
dynamic programming model that does a kind of pseudo alignment might help.
That plus breaking up the alignment somehow would probably make this work.
On Fri, Oct 16, 2020, 04:33 Brett Chapman<EMAIL_ADDRESS>wrote:

Hi Erik
I have a question about the -M parameter for edyeet and wfmash. Since it
produces a better overall mapping by merging the alignments of each
segment, wouldn't it be better to use -M every time? Or is it way too
costly for whole chromosomes? Whats the general increase in run time using
-M for whole genomes/chromosomes? Does leaving out the -M parameter leave
artifacts in the alignments/variants? is it something only worth doing for
smaller gene regions? Would it be worthwhile using the -M parameter as the
final step for the final production level pangenome graph, after all
parameter testing is done? Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ekg/edyeet/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDQEI7ZZLVE3V476VBXRLSK6WHZANCNFSM4SSYAS5A
.

Thanks for the explanation. For now I'll leave -M off unless looking at small regions, and later include it down the line if improvements to the algorithm mitigate the costs of using it.


fix typo in kubernetes

Signed-off-by: baude<EMAIL_ADDRESS>

/approve
LGTM

someone needs to /lgtm this

/lgtm


Robotta

Changes / Comments
This PR adds the character sheet for the game Robotta, written by Sirio Sesenra and published by Shadowlands Ed.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Add password option to TextField Component

[x] I've read and followed the contributing guide on how to create great pull requests.
[ ] I've updated the relevant documentation for any new or updated feature.
[x] I've linked relevant GitHub issue with "Closes #".
[x] I've added a visual demonstration in the form of a screenshot or video.

This PR closes #2737
Through the use of a password checkbox, a user can decide whether their TextField should be text type or password type.

Thank you, before we merge we should do the following changes:

run yarn docs:build:api to regenerate the reference docs for the component
add a "password" synonym to the 'TextField' component: https://github.com/mui/mui-toolpad/blob/40f6fc35460a455267c113e842710759973f4d18/packages/toolpad-app/src/runtime/toolpadComponents/index.tsx#L57
add a "Password" component in the library, similar to how we added Markdown/link components in https://github.com/mui/mui-toolpad/pull/2763/files


error during startup: panic: runtime error: slice bounds out of range

Since the slice is of size 2^30, this looks like some Windows mmap limit or setting. It does not appear to be a bug in Influx; are there Windows settings that control how big memory-mapped file can be?


Restructure project + cleanup

From #9
Created new PR so I can push new commits without messing @macreiben-dev main branch

Feel free to rework, I'll merge afterwards. If you're ok, I can pull request directly on your repository.


Circuit breaker return code

In order to determine whether or not the circuit breaker is open, dynamic-dynamodb checks whether or not the circuit-breaker-url returns status code 200. For my service, a healthy endpoint returns 204, rather than 200. So, according to HTTP standards, the request is a success, but according to dynamic-dynamodb the service is offline. I believe it would make more sense if any 2xx status code signified success.

Released in 2.3.0

this commit destroys circuit breaker functionality completely due to an error in line 73 in circuit_breaker.py, condition should be >= 200, not > 200
should I open a new issue for this?

@mbravorus Embarrassing! Thanks for reporting this. I'm shipping version 2.3.1 right now, where this is fixed.


SUGGESTION: Remove Kotlin Annotations

Kotlin annotation @Metadata
can leak class original name, original method and field names

I'm sorry metadata didn't mean to tag you 😭

Sorry for using bug label im dont know github issues yet


Delay when loading settings for a key

It takes about a second for the configured settings of the key to appear when you click on it in the app. Other keys in Stream Deck (not Custom) show their settings right away.

I should check Elgato's plugin template to see if their sample plugin does this too.

It seems like this is an issue with the Stream Deck SDK in general. See: https://www.reddit.com/r/StreamDeckSDK/comments/b3mewx/delay_between_property_inspector_appearing_and/ej0yc86/

Seems like this has been (mostly) fixed in later versions of Stream Deck


Add a statistics table for IP addresses on the "Network" page of the performance test report

Add an additional statistics table "IP Addresses" on the "Network" page of the performance test report. This table should list the IP addresses of the system under test similar to the "Hosts" table. The columns should be "IP Address", "Count", and "Percentage". If possible, the domain name that had been resolved to the respective IP address could also be listed there in a separate column.
This would help, for example, to evaluate the behavior of certain CDN environments.

Once the changes to XLT are rolled out we should also document that there is a new field in result data - prepared in branch buildpath-and-result-data, see link.


cell data not recorded

Description
Neostumbler detects and records wi-fi and Bluetooth beacons, but no cell Tower information is recorded.
A parallel installation of the app Tower Collector does record cells, so I assume an issue with neostumbler.
App variant
full
Version
1.4.1
Device
OnePlus ONE A2003
Android version
10
Logs
No response
New bug

[X] I have checked that this bug has not been reported before

Are you using a custom ROM?

Yes, it's a LineageOS based build from the e. foundation (e_oneplus2).
The build is not available anymore and android 10 is eol anyway. So don't invest time if you cannot think of a quick fix.

Alright. NeoStumbler is using some of the new APIs introduced in Android 10 for cell scanning and I'm guessing those might not be properly supported on custom ROMs.
As a workaround, you could try revoking the phone permission from NeoStumbler. Without the phone permission, cell scanning is only done on the primary SIM card, which doesn't use as many new APIs. Not sure if it works, but it's worth trying
A proper fix would be adding support to use legacy APIs for cell scanning, but yeah I don't think it's worth the effort given that this should only affect a small number of old devices

I also noticed that Towercollector collects much more cell information. I am not running a custom rom, but I wanted to validate that this is not caused by some permission issue. Hence trying trouble shooting and fix the first issue. I wonder why those persmissions were not asked for or granted on two independent installations.

I do have the same problem with the current version from F-droid running on LineageOS 17.1 (the last version available for my old phone) not collecting cell tower information. Revoking phone permission did not help in my case.
I just noticed that LineageOS 17 is based on Android 10, so I wonder if an old API is the underlying issue. Is there an easy way to check, can I somehow collect debugging messages?

@MatthiasHGW the release build does not have logging enabled. You would have to build a debug version and then use logcat to see the logs. There's logging for failed cell scans: https://github.com/mjaakko/NeoStumbler/blob/c3fdf62dd704fb04bf5478f83c46f247fbee2ab3/app/src/main/java/xyz/malkki/neostumbler/scanner/source/TelephonyManagerCellInfoSource.kt#L60 - if that message never appears and no cell data os collected, then there's either an issue in the data which causes it to be filtered (no cell ID etc.) or the cell scan callback is never invoked

I think I found out the reason for the failed recording of cell tower data. For whatever reason in my case the mobileNetworkCode cannot be identified (mMnc=null):
CellInfoLte:{mRegistered=YES mTimeStamp=440378202701337ns mCellConnectionStatus=2147483647 CellIdentityLte:{ mCi=20667139 mPci=445 mTac=48023 mEarfcn=14 mBandwidth=2147483647 mMcc=262 mMnc=null mAlphaLong= mAlphaShort=} CellSignalStrengthLte: rssi=2147483647 rsrp=2147483647 rsrq=2147483647 rssnr=2147483647 cqi=2147483647 ta=0 level=0 android.telephony.CellConfigLte :{ isEndcAvailable = false }}
Replacing the function "fillMissingData" in TelephonyManagerCellInfoSource for test purposes with the following code fixed the issue.
So, if the mobileNetworkCode is not mandatory for collecting data, and if the root cause cannot be identified I suggest to make it optional, i.e. fill in only if available, otherwise set a default or leave empty, if the api allows this.
    private fun List<CellTower>.fillMissingData(): List<CellTower> {
        if (size == 1) {
            return this
        } else {
            val mobileCountryCodes = mapNotNull { it.mobileCountryCode }.toSet()
            var mobileNetworkCodes = mapNotNull { it.mobileNetworkCode }.toSet()

            if (mobileNetworkCodes.isEmpty()) {
                mobileNetworkCodes = setOf("00")
            } else if (mobileNetworkCodes.size > 1) {
                val firstMobileNetworkCode = mobileNetworkCodes.firstOrNull() ?: "00"
                mobileNetworkCodes = setOf(firstMobileNetworkCode)
            }

            return map { cellTower ->
                cellTower.copy(
                    mobileCountryCode = cellTower.mobileCountryCode ?: mobileCountryCodes.first(),
                    mobileNetworkCode = cellTower.mobileNetworkCode ?: mobileNetworkCodes.first()
                )
            }
        }
    }

P.S. Tower Collector uses the implementation https://github.com/mroczis/netmonster-core for evaluation of the cell data and correctly identifies the mnc.

MNC is needed to uniquely identify the cell tower. Cell IDs are not globally unique.
I'll take a look at the library you've linked. It could make cell tower scanning more robust


internal: Don't parse leading unaries in numbers

Should we be parsing these as part of the numbers? My guess is that we should just do it in one place, and so -5 and -foo are parsed similarly.

Note this also reduces the priority of integrating the recent number representations into number, CC @vanillajonathan

In Python and Rust you can also write it as 0b_0000_0000.
Python also provides friendly diagnostic messages:
>>> 0b3
  File "<stdin>", line 1
    0b3
      ^
SyntaxError: invalid digit '3' in binary literal
>>> 0o8
  File "<stdin>", line 1
    0o8
      ^
SyntaxError: invalid digit '8' in octal literal
>>> 0xg
  File "<stdin>", line 1
    0xg
     ^
SyntaxError: invalid hexadecimal literal

Nice! Would be great if we could do something similar!


version and repo tag

Hello,
The package on pip is versioned 0.2.0 whereas the lastet tag / __version__ in pyls_isort/__about__.py in master is 0.1.1

Nice catch, I forgot to push...
Should be okay now https://github.com/paradoxxxzero/pyls-isort/releases/tag/0.2.0

perfect, thanks!


Update to the latest released wasi-libc and declare getcwd/chdir

Update to the latest version of wasi-libc which corresponds to the
version in the wasi-sdk 14.0 release.
And, add declarations for getcwd and chdir, which are now provided
by wasi-libc.

r? @JohnTitor
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+

:pushpin: Commit 5e5cf2c18170e5a3e61e51537bb638f062f92c3f has been approved by Amanieu

:hourglass: Testing commit 5e5cf2c18170e5a3e61e51537bb638f062f92c3f with merge e497f18d6329f3ad34eebb2b8bc3493d1f269143...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing e497f18d6329f3ad34eebb2b8bc3493d1f269143 to master...


KernelDef: 'op: "ConcatV2" device_type: "CPU" constraint

Explain this error
2.1.0 loading annotations into memory... Done (t=0.08s) creating index... index created! Traceback (most recent call last):   File "train_model.py", line 50, in <module>     _ = model((batch_imgs, batch_metas), training=False)   File "/home/advancedtf/lib/python3.6/site-packages/tensorflow_core/python/keras/engine/base_layer.py", line 822, in _call_     outputs = self.call(cast_inputs, *args, **kwargs)   File "/home/16-fasterRCNN/detection/models/detectors/faster_rcnn.py", line 157, in call     rcnn_probs_list, rcnn_deltas_list, rois_list, img_metas)   File "/home/16-fasterRCNN/detection/models/bbox_heads/bbox_head.py", line 121, in get_bboxes     for i in range(img_metas.shape[0])   File "/home/16-fasterRCNN/detection/models/bbox_heads/bbox_head.py", line 121, in <listcomp>     for i in range(img_metas.shape[0])   File "/home/16-fasterRCNN/detection/models/bbox_heads/bbox_head.py", line 188, in _get_bboxes_single     nms_keep = tf.concat(nms_keep, axis=0)   File "/home/advancedtf/lib/python3.6/site-packages/tensorflow_core/python/util/dispatch.py", line 180, in wrapper     return target(*args, **kwargs)   File "/home/advancedtf/lib/python3.6/site-packages/tensorflow_core/python/ops/array_ops.py", line 1517, in concat     return gen_array_ops.concat_v2(values=values, axis=axis, name=name)   File "/home/advancedtf/lib/python3.6/site-packages/tensorflow_core/python/ops/gen_array_ops.py", line 1118, in concat_v2     _ops.raise_from_not_ok_status(e, name)   File "/home/advancedtf/lib/python3.6/site-packages/tensorflow_core/python/framework/ops.py", line 6606, in raise_from_not_ok_status     six.raise_from(core._status_to_exception(e.code, message), None)   File "<string>", line 3, in raise_from tensorflow.python.framework.errors_impl.InvalidArgumentError: OpKernel 'ConcatV2' has constraint on attr 'T' not in NodeDef '[N=0, Tidx=DT_INT32]', KernelDef: 'op: "ConcatV2" device_type: "CPU" constraint { name: "T" allowed_values { list { type: DT_UINT64 } } } host_memory_arg: "axis"' [Op:ConcatV2] name: concat

Hi @moulicm111
This is my old version of tf-eager-fasterrcnn and this error has fixed earlier. You can check this code in the latest codebase and figure it out.The reason is that the input of ConcatV2 op is empty.

Total loss is NaN after some epochs .
What about this warning
WARNING:tensorflow:Gradients do not exist for variables ['faster_rcnn/b_box_head/rcnn_class_conv1/kernel:0', 'faster_rcnn/b_box_head/rcnn_class_conv1/bias:0', 'faster_rcnn/b_box_head/rcnn_class_bn1/gamma:0', 'faster_rcnn/b_box_head/rcnn_class_bn1/beta:0', 'faster_rcnn/b_box_head/rcnn_class_conv2/kernel:0', 'faster_rcnn/b_box_head/rcnn_class_conv2/bias:0', 'faster_rcnn/b_box_head/rcnn_class_bn2/gamma:0', 'faster_rcnn/b_box_head/rcnn_class_bn2/beta:0', 'faster_rcnn/b_box_head/rcnn_class_logits/kernel:0', 'faster_rcnn/b_box_head/rcnn_class_logits/bias:0', 'faster_rcnn/b_box_head/rcnn_bbox_fc/kernel:0', 'faster_rcnn/b_box_head/rcnn_bbox_fc/bias:0'] when minimizing the loss.

Are you using the newest version?

Are you using the newest version and loading weights? Pre-trained weights and ResNet101 weights trained on ImageNet are both acceptable.

I didn't load the pretrained weights
I want to train from scratch as the problem is manipulation detection

There are lots of things you need to think of.
For example,  BN weights are fixed when training in this codebase. So you need to modify this setting. Next, if you want to train BN, you need to use multi-GPU instead of single GPU. So you can't just run this code to train COCO from scratch.
And I suggest you can choose a smaller backbone to train easily, e.g. VGG16 or ResNet18.

Thanks for your time and valuable suggestions.


Starting work on the bootcamp

I wanted to star improving the bootcamp, see #201.
This is adding something about API keys and a brief overview at the top. I'm planning to expand the sections below. Is this the right way to edit this or is this file generated from something? Is there an easy way for me to render the website?

The instructions for setting up openml locally include a dead link to the database: https://github.com/openml/OpenML/wiki/Local-Installation#databases

Yes, this is currently the right way. I plan to move this to markdown.
I fixed the link in the wiki. Also, you can use this docker image:
https://github.com/nodechef/openML_docker_server
I noticed that the search engine doesn't work in this image, will need to fix that, but it's sufficient for working on the bootcamp.

cool, thanks. Can you maybe also add the docker image to the wiki or the developer docs?

Or should the docker files be merged into the main repo? That repo contains a whole version of the website, not only the docker files, right?

Yes, it contains the whole website. It would be better to git clone it on deployment. Also, I need to fix the search engine issue beforehand. There's an open issue about that.
If that's fixed I could merge it into the main repo, although having it a copy on dockerhub is also nice.

ok, cool. It would be nice to have a step-by-step for contributing. The docker container definitely makes that much simpler already.

I got it running now, though :)

Current website:

This PR:

Should I do the layout changes in a separate PR? And across the whole page? Or limit to the guide for now?

my css is not entirely correct, there's a scrollbar at the bottom even if the whole text fits...
Maybe that's because the navbar is outside the main container? Is that allowed in bootstrap? Also, there is no rows, which I'm pretty sure is not allowed in bootstrap....

Ok, I think that's it for now from me. Maybe I'll add some more links and images, but otherwise this should be a net improvement. @mfeurer @janvanrijn @berndbischl any feedback?

Thanks for all your feedback @HeidiSeibold :) I tried to address some (most?) of them and commented on the rest.

I replaced all "dataset" with "data set" which is now hiding some comments I haven't actually addressed :(

thanks @joaquinvanschoren  :)

Thank you! This is great!

@HeidiSeibold If you feel inspired, maybe you can just do a PR do improve upon this, given that it's merged now? ;)


Make scope compatible with Rails 6.1 + Ruby 3.2.2

It seems that scopes with keyword arguments are not supported on Rails 6.1 + Ruby 3.2.
We get the error ArgumentError: wrong number of arguments (given 3, expected 1..2; required keyword: distance)
Swapping the keyword argument for a hash make it to work. 🤷

I opened a similar PR against the source repo: https://github.com/ankane/neighbor/pull/13


Update CTA text to emphasize link between FTM & Find the Makers

Find the Makers became 15% of our total site traffic in its first 48 hours of launch.
Need to update the CTA text on the left-hand side and make it conditional for the FTM index.html or /Maker
Design + Content here: https://www.figma.com/file/qbibGHgcV1LBcpvd2EoHSM/FindTheMasks?node-id=1272%3A9032

I figured out how to restart Heroku. Edit the ReadMe :)


Support sending via unlocked accounts in forge create

Component
Forge
Describe the feature you would like
As discovred in https://github.com/foundry-rs/foundry/issues/2330
forge create is currently limited to sending signed transactions, the error message:
Alternatively, if you're using a local node with unlocked accounts, set the ETH_FROM environment variable to the address of the account you want to use
is not really accurate, because we only try to use a signer (via cli args, trezor, ledger, pk, etc...)
https://github.com/foundry-rs/foundry/blob/7c96807294f51c121f1a2d614b55055bc7cb126c/cli/src/cmd/forge/create.rs#L150-L157
proposing an --unlocked flag that uses eth_sendTransaction with send from field instead
wdyt @sambacha
Additional context
No response

Component
Forge
Describe the feature you would like
As discovred in #2330
forge create is currently limited to sending signed transactions, the error message:
Alternatively, if you're using a local node with unlocked accounts, set the ETH_FROM environment variable to the address of the account you want to use
is not really accurate, because we only try to use a signer (via cli args, trezor, ledger, pk, etc...)
https://github.com/foundry-rs/foundry/blob/7c96807294f51c121f1a2d614b55055bc7cb126c/cli/src/cmd/forge/create.rs#L150-L157
proposing an --unlocked flag that uses eth_sendTransaction with send from field instead
wdyt @sambacha
Additional context
No response

giddy up 🤠
for Metamask eth_sendTransaction works. LMK whenever you need additional testing to validate that it works ser, cheers!


Undefined method `alive?' for nil:NilClass

I see this sometimes in the log. Is it something to be concerned about? Thanks
Error parsing addr: [0, 0, 0, 0]
INFO  network: requesting addrs
#<NoMethodError: undefined method `alive?' for nil:NilClass>
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:287:in `block in handle_info'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:287:in `select'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:287:in `handle_info'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:47:in `block in receive_data'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:33:in `each'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node/command_handler.rb:33:in `receive_data'
/usr/local/rvm/gems/ruby-2.1.5/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run_machine'
/usr/local/rvm/gems/ruby-2.1.5/gems/eventmachine-1.0.7/lib/eventmachine.rb:187:in `run'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/lib/bitcoin/node.rb:237:in `run'
/usr/local/rvm/gems/ruby-2.1.5/bundler/gems/bitcoin-ruby-node-29605f8454b5/bin/bitcoin_node:159:in `<top (required)>'
/usr/local/rvm/gems/ruby-2.1.5/bin/bitcoin_node:23:in `load'
/usr/local/rvm/gems/ruby-2.1.5/bin/bitcoin_node:23:in `<main>'
/usr/local/rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `eval'
/usr/local/rvm/gems/ruby-2.1.5/bin/ruby_executable_hooks:15:in `<main>'

Hi, thanks for bringing it up!
This is not a big problem, it just means that it couldn't parse some peer address it received.
I was hoping https://github.com/lian/bitcoin-ruby/pull/159 would make it into upstream, but I have merged it onto my "next" branch now so we can use the fix.
You might have to bundle update bitcoin-ruby explicitly, after you update bitcoin-ruby-node.


Add context text to expectation exception

When JSON assertion fail we display now in the exception, the json received
When HTTP assertion fail we display the requestion/response formatted (like in printResponse)

fix #47

Hacktoberfest FTW


Improve perfomance issue for DELETE command

Before
                                                                                QUERY PLAN
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Delete on log_hierarchies  (cost=4403.03..6923802.33 rows=169553156 width=6) (actual time=52728.567..52728.567 rows=0 loops=1)
   ->  Seq Scan on log_hierarchies  (cost=4403.03..6923802.33 rows=169553156 width=6) (actual time=52728.564..52728.564 rows=0 loops=1)
         Filter: ((hashed SubPlan 1) OR (descendant_id = 1022566))
         Rows Removed by Filter: 338996939
         SubPlan 1
           ->  Unique  (cost=0.57..4403.03 rows=1 width=4) (actual time=0.085..0.085 rows=0 loops=1)
                 ->  Index Only Scan using log_anc_desc_idx on log_hierarchies log_hierarchies_1  (cost=0.57..4396.98 rows=2420 width=4) (actual time=0.085..0.085 rows=0 loops=1)
                       Index Cond: (ancestor_id = 1022566)
                       Heap Fetches: 0
 Planning time: 0.223 ms
 Execution time: 52728.657 ms
(11 rows)

After
                                                                                QUERY PLAN
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 Delete on log_hierarchies  (cost=1.15..5006.48 rows=11962 width=34) (actual time=11.178..11.178 rows=0 loops=1)
   ->  Nested Loop  (cost=1.15..5006.48 rows=11962 width=34) (actual time=0.126..10.466 rows=561 loops=1)
         ->  Subquery Scan on "ANY_subquery"  (cost=0.57..4403.04 rows=1 width=32) (actual time=0.077..0.172 rows=33 loops=1)
               ->  Unique  (cost=0.57..4403.03 rows=1 width=4) (actual time=0.050..0.111 rows=33 loops=1)
                     ->  Index Only Scan using log_anc_desc_idx on log_hierarchies log_hierarchies_1  (cost=0.57..4396.98 rows=2420 width=4) (actual time=0.048..0.080 rows=33 loops=1)
                           Index Cond: (ancestor_id = 1022533)
                           Heap Fetches: 33
         ->  Index Scan using log_desc_idx on log_hierarchies  (cost=0.57..483.82 rows=11962 width=10) (actual time=0.024..0.306 rows=17 loops=33)
               Index Cond: (descendant_id = "ANY_subquery".descendant_id)
 Planning time: 0.290 ms
 Execution time: 11.246 ms
(11 rows)

This commit fix issue with OR in condition. If we have OR we can't use indexes -> fullscan.
We can run 2 fast queries, because we run them in transaction.

similar PR: #96

Awesome work @zzet .

I wonder why travis didn't pickup the PR.
ping @mceachen

@seuros I updated commit:
explain analyze SELECT DISTINCT descendant_id
  FROM (SELECT descendant_id
    FROM "log_hierarchies"
    WHERE ancestor_id = 1022510 or descendant_id = 1022510
  ) AS x;
                                                                QUERY PLAN
------------------------------------------------------------------------------------------------------------------------------------------
 HashAggregate  (cost=53382.86..53382.88 rows=2 width=4) (actual time=1.008..1.011 rows=22 loops=1)
   Group Key: log_hierarchies.descendant_id
   ->  Bitmap Heap Scan on log_hierarchies  (cost=354.58..53347.42 rows=14179 width=4) (actual time=0.218..0.661 rows=1708 loops=1)
         Recheck Cond: ((ancestor_id = 1022510) OR (descendant_id = 1022510))
         Heap Blocks: exact=65
         ->  BitmapOr  (cost=354.58..354.58 rows=14179 width=0) (actual time=0.202..0.202 rows=0 loops=1)
               ->  Bitmap Index Scan on log_anc_desc_idx  (cost=0.00..86.72 rows=2420 width=0) (actual time=0.045..0.045 rows=56 loops=1)
                     Index Cond: (ancestor_id = 1022510)
               ->  Bitmap Index Scan on log_desc_idx  (cost=0.00..260.76 rows=11759 width=0) (actual time=0.152..0.152 rows=1687 loops=1)
                     Index Cond: (descendant_id = 1022510)
 Planning time: 0.181 ms
 Execution time: 1.067 ms
(12 rows)

@mceachen some problems with travis? https://travis-ci.org/mceachen/closure_tree/jobs/88097080#L181

Thanks so much for the PR! Love the detail, especially the benchmark.
@martin-schmidt fixed the build which I just merged with master, and I'll cut 6.0.0 as soon as this PR builds green on master.


Sending level instead of switch "on" does not turn on the lights

I'm using the latest smartthings-mqtt bridge and my lights won't turn on - they will turn off, but not on.
I commented the part of the code that intercepts "on" and change it to level. And it now works.
Latest Homeassistant + latest smartthings-mqtt + GE Smartbulbs.

I am having this issue as well. I can lower the level of my lights, but I cannot raise the level back up. I can turn off my lights, but I can't turn them back on. I have to use my phone's Smartthings App to turn them back on. I am using the latest smartthings-mqtt-bridge and also GE Link Smartbulbs.
I am using straight MQTT publish commands to the topic to test out the MQTT-bridge.
While running the command "pm2 logs smartthings-mqtt-bridge" I see the following output:
info: Incoming message from MQTT: smartthings/Living Ceiling A/switch = on
info: Passing level instead of switch on
info: Incoming message from SmartThings: smartthings/Living Ceiling A/switch = turningOn
info: Incoming message from MQTT: smartthings/Living Ceiling A/switch = turningOn
info: Skipping duplicate message from: smartthings/Living Ceiling A/switch = turningOn
info: Incoming message from SmartThings: smartthings/Living Ceiling A/switch = on
info: Incoming message from MQTT: smartthings/Living Ceiling A/switch = on
info: Skipping duplicate message from: smartthings/Living Ceiling A/switch = on
info: Incoming message from SmartThings: smartthings/Living Ceiling A/level = 100
info: Incoming message from MQTT: smartthings/Living Ceiling A/level = 100
info: Skipping duplicate message from: smartthings/Living Ceiling A/level = 100

Same here with a couple of Trådfri bulbs.


content: document kep-2305

document kep-2305: metric cardinality enforcement

Linked to https://github.com/kubernetes/enhancements/issues/2305

Hello @rexagod  :wave: please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

Hello, @katcosgrove. The linked k/k PR is no longer tracked and has been moved out of the milestone. I’m assuming this will have to be deferred till the next release?

Ah okay! Updating our tracking sheet, thank you!

Changed base to target latest.

Hello @rexagod 👋, I cannot see any file changes on this PR. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

Hello @rexagod 👋, gentle reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

/remove-language de
/remove-language fr
/remove-language id
/remove-language ru
/remove-language vi
/remove-language zh

/remove-area blog

I see that even though this was mentioned in the KEP readme, this feature was never gated by a feature-gate. I've removed the part from this PR which mentioned the feature-gate. Is that okay?

No objection from me. Thanks for explaining.

Hello @rexagod @logicalhan 👋, gentle reminder to get your PR merged before the deadline, Tuesday 28th November 2023. Thank you!

/assign @sftim
/assign @tengqm
/assign @kbhawkey

/retitle Document dynamic cardinality enforcement (KEP 2305)

Hello @rexagod! The deadline to have this PR merged is Tuesday, November 28. Enhancements that do not include required documentation may not be included in the release. Is there anything I can do to help get this ready to merge? Thanks!

I don't think k8s.io/docs/reference/instrumentation needs any change; [...]

Hmm, I think that's fair. I'll close this PR since we already have documentation on this feature. Sorry for the noise, and thank you for pointing this out!

/reopen
The existing docs do still need an update. I've reopened this PR to make the situation clear.

/lgtm cancel

Updated, PTAL. Also, Han maybe out due to Thanksgiving, so I'm not sure I can get his review here within the limited time-span again.

@sftim Do I need Han's LGTM for this to be merged (after all reviews are addressed)? US folks are out due to Thanksgiving, so that might not be possible within the limited time-frame.

Hi @rexagod! I'm the Docs lead for v1.29. You will need an LGTM from someone, yes. If @logicalhan is still out after Thanksgiving, someone from your SIG's leadership will suffice. Would you like me to find someone for you?

Thanks but we really do need these docs revised in line with the reviews so far.
/hold
/lgtm cancel

/hold cancel


Delay with server

After scanning QR code, if I immediately enter the 6 digit after the refresh on the Authenticator app, it does not verify.
Using the speakeasy.totp() to generate the token and console logging it, it shows the 6 digit from before the refresh.
I have 2 middleware, one is to generate the base32 and QR code. I store the secret in req.session.user.secret. Then in my second middleware, where I do the verification, I put in the secret.base32 in speakeasy.totp() to generate the token.
The 6 digit received from client is the one shown on the Authenticator app, the token generated is shown as the one before the refresh.

I'm experiencing the same issue. Did you ever manage to resolve it?

I'm experiencing the same issue. Did you ever manage to resolve it?

Yeah. You have to set the window of time to 2. Experiment with the number to suit your need. What this does is it will check the code within the specified window of time. 2 will check the last 2 code that was generated, so after an immediately refresh, the previous code will still be valid to authenticate.
https://www.npmjs.com/package/speakeasy#specifying-a-window-for-verifying-hotp-and-totp

Thanks @Rc85


tweakUtils when the tweak is 0 throws

Hi @paulmillr ,
I am coming from https://github.com/bitcoinjs/ecpair/issues/13.
I am using noble-secp256k1 with ecpair.
Since I still need tweakUtils' privatedAdd, ... I decided to copy the code on your tests to my wrapper as you suggest in Release Notes of 1.7.0.
Starting from version 2.1.0, ecpair runs additional tests on the embedded library.
There is this one new test that does not pass:
      ecc.privateAdd(
        h('0000000000000000000000000000000000000000000000000000000000000001'),
        h('0000000000000000000000000000000000000000000000000000000000000000'),
      ),

The reason is normalization of the tweak const t = normalizePrivateKey(tweak); throws because the tweak is zero.
I checked your tests for tweakUtils:
    it('privateAdd()', () => {
      for (const vector of privates.valid.add) {
        const { a, b, expected } = vector;
        expect(secp.utils.bytesToHex(tweakUtils.privateAdd(a, b))).toBe(expected);
      }

This passes.
Then I saw you have other test vectors for privateAdd in test/vectors/privates.json that include the tweak = 0 case:
    "privateAdd": [
      {
        "description": "1 + 0 == 1",
        "d": "0000000000000000000000000000000000000000000000000000000000000001",
        "tweak": "0000000000000000000000000000000000000000000000000000000000000000",
        "expected": "0000000000000000000000000000000000000000000000000000000000000001"
      }

But, for some reason, these vectors are not tested in your tests.
If I add them (see below), they do not pass (because the tweak = 0).
      for (const vector of privates.valid.privateAdd) {
        const { d, tweak, expected } = vector;
        expect(secp.utils.bytesToHex(tweakUtils.privateAdd(d, tweak))).toBe(expected);
      }
    });

(the test above fails)
I know tweakUtils are not part of released noble-secp256k1 anymore but decided to let you know anyway in case you want to take a look to your tests.

Thanks. This should be adjusted then

On the other hand, the current behavior was made on purpose. Why would you add an all-zero private key? It's certainly invalid in ECDH context, and in some others.

On the other hand, the current behavior was made on purpose. Why would you add an all-zero private key? It's certainly invalid in ECDH context, and in some others.

I understand your point. It's more of an interoperability issue with ecpair. Not really a bug.
This issue concerns tweakUtils which aren't exposed anyway.
I copied and adjusted tweakUtils in my project with this little change. I just wanted to share this with you so you are aware.
BTW, in order to make noble-secp256k1 and ecpair work together, I also had to adjust tweakUtils functions so that they throw when the computed private key is zero.
Feel free to close the issue as this is more of a comment than a bug.

@landabaso, I'm also trying to use this with HD wallet paths (to make a fully browser-compatible implementation).
What is "tweakUtils"? Whether I do a search for "tweakutils" on npm or "tweakutils secp256k1" on the web, I don't seem to get back any relevant results.
What privateAdd() function are you referring to? I don't see it in the docs or code here or the ecpair repo.
Could you post a link to your implementation?

For tweak utils, look into secp tests: they have the utils. It was part of the main pkg, then got removed because I think it has bad UX and it's just legacy of other libraries while here we have better primitives (Point).
For hdkey, take a look at scure/bip32.

Could you post a link to your implementation?

I hope it helps @coolaj86: https://github.com/bitcoinerlab/secp256k1

@landabaso I was able to get this to work with our APIs.
For anyone looking on, this is the code that's missing:

privateAdd is known in other libraries as privateKeyTweakAdd
pointAddScalar is known in other libraries as publicKeyTweakAdd

  let tweakUtils = {
    /**
     * @param {Uint8Array} privateKey
     * @param {Uint8Array} tweak
     * @returns {Uint8Array} - a new (derivative) privateKey
     */
    privateAdd: function (privateKey, tweak) {
      const p = Secp256k1.utils._normalizePrivateKey(privateKey);
      const t = Secp256k1.utils._normalizePrivateKey(tweak);
      return Secp256k1.utils._bigintTo32Bytes(
        Secp256k1.utils.mod(p + t, Secp256k1.CURVE.n),
      );
    },

    /**
     * @param {Uint8Array} p
     * @param {Uint8Array} tweak
     * @param {Boolean} [isCompressed]
     * @returns {Uint8Array} - a new (derivative) publicKey
     */
    pointAddScalar: function (p, tweak, isCompressed) {
      const P = Secp256k1.Point.fromHex(p);
      const t = Secp256k1.utils._normalizePrivateKey(tweak);
      const Q = Secp256k1.Point.BASE.multiplyAndAddUnsafe(P, t, 1n);
      if (!Q) {
        throw new Error("Tweaked point at infinity");
      }
      return Q.toRawBytes(isCompressed);
    },
  };

This may need to be updated again for the upcoming major refactor.

Yeah, you can get these functions from there.
BTW, there's a full implementation in the link I copied above as an npm package ready to use and heavily tested:
https://github.com/bitcoinerlab/secp256k1
Let me know if I can help you somehow.


Disable the use of @babel/transform-runtime (solves #111)

As described in #111, the upgrade to 1.9.0 introduces a dependency on @babel/runtime without marking it a (peer)dependency.
This setup works well for projects that already have @babel/runtime@^7 set up, but for those that do not, we will break their build.
The purpose of @babel/transform-runtime is to reuse duplicate pieces of transpiled code, so now that I've removed it, the bundle sizes have increased. The only alternative I can think of is to make @babel/runtime a dependency. This would be a no-op in case a project already depends on it, and it would guarantee that this packages works "out-of-the-box". However, in case a project isn't using @babel/runtime yet, we would introduce the entire babel runtime into their bundle, even though we only use a portion of it.
@mjackson I'd love to hear your take on this (and that of anyone else for that matter). However, if there's no response here after some time I'll just go ahead and publish this :smile:

Yes, we should have @babel/runtime as a dependency. I forgot to include it. The @babel/transform-runtime plugin ensures that we only include the pieces of @babel/runtime that we need so that we don't include the whole thing.

Ah ok, even better then :+1:


Debugging improvements

Add configure_reclient.py --verbose
Make check_reclient_works.py +x

cc @ola-rozenfeld

Thank you, Mac Antoine! Sorry about the time this took, I need to check how to get notified for these, GH doesn't want to send me notifications :-/


updated typo for ep2 to display "गुलामी से मुक्ति", instead of "गुलामी सी मुक्ति"

Closes:  #92

Title : Typo correction
Name:  Shvian Samala
Idenitfy yourself:  GSSOC Contributor

Describe the add-ons or changes you've made 📃
Here I am unable to alter anything that is using API from another repository of yours. So, I have inserted a few lines with which it changes the title/content of episode.
Give a clear description of what have you added or modifications made
Type of change ☑

What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, local variables)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist: ☑

[x] My code follows the Contributing Guidelines & Code of Conduct of this project.
[x] This PR does not contain plagiarized content.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.

Screenshots 📷

Note to reviewers 📄

Feel free to contact me through mail/discord, I am always available over there

May I know what are changes required?


Refactor the qf_init_ext() function

Simplify the qf_init_ext() function.
Use the FOR_ALL_QFL_ITEMS macro in a few more places.
Check for memory allocation failure in qf_free_stack().
Update the README.md file.

It looks like this mixes the status from qf_get_nextline() with
qf_add_entry(), even though their values are quite different: QF_ values
versus OK/FAIL.
--
Apathy Error: Don't bother striking any key.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Hi Bram,
On Sat, Mar 30, 2019 at 2:52 PM Bram Moolenaar
<EMAIL_ADDRESS>wrote:

It looks like this mixes the status from qf_get_nextline() with
qf_add_entry(), even though their values are quite different: QF_ values
versus OK/FAIL.

The QF_OK and QF_FAIL values are defined to be the same as OK and FAIL.
I have changed the qf_add_entry() function to return QF_OK/QF_FAIL instead
of OK/FAIL now.

Yegappan


Bug: Outdated player objects and matches appear on the NA shard

At the beginning of February, due to a bug all matches and players appeared on the NA shard for a short time.
L3oN is a player from EU and has always been in EU.
curl -g "https://api.dc01.gamelockerapp.com/shards/na/players?filter[playerNames]=L3oN" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json"

returns id a84deea2-c360-11e4-ad12-06eb725f8a76, createdAt 2017-02-13T20:08:55Z.
curl -g "https://api.dc01.gamelockerapp.com/shards/eu/players?filter[playerNames]=L3oN" -H "Authorization: Bearer $APIKEY" -H "X-TITLE-ID: semc-vainglory" -H "Accept: application/vnd.api+json"

returns id a84deea2-c360-11e4-ad12-06eb725f8a76, createdAt 2017-07-25T18:33:42Z.
The ids are the same. If the player had changed his region, the id would be different.
This bug makes it hard to reliably tell in which region a player name can be found.

We'll handle this as we slowly remove old and not updated accounts.  Stay tuned...

Any update on this? It still causes a lot of issues


access request

Use this issue template if you do not feel comfortable raising a PR with the required changes to files in the terraform/ directory.
Please supply all the requested information, so that your request can be processed as quickly as possible.
Which MoJ repository are you requesting access to (e.g. money-to-prisoners)?
staff-device-management-intune-scripts-prod
staff-device-management-intune-scripts
What is the GitHub username of the person who needs access?
calkin
What is their full name?
Joshua Calkin
What is their email address?
<EMAIL_ADDRESS>What company/organisation do they belong to (e.g. "MadeTech", "Department for Education")?
Content+Cloud
What level of access should they have?

[x] Read
[ ] Triage
[x] Write
[ ] Maintain
[ ] Admin

Why is this access being requested?
VICTOR development
Which MoJ team/person is responsible for this request? This must be someone with a "*.justice.gov.uk" email address.
<EMAIL_ADDRESS>Team details are preferred, rather than individuals, to make it easier to follow-up at a later date.
PTTP
Review date
Date after which this collaborator's access should be reviewed. This should be a date in the format: 2021-01-15, no more than one year into the future.
2022-04-13

@calkin Hi you have an email invite to staff-device-management-intune-scripts I cannot add or remove you from that repo directly, I would have to create a branch to remove you from the file and other to add you again.

@calkin you have write access to staff-device-management-intune-scripts-prod

Blocked - Awaiting user response.


Update supabase.mdx

Description (required)
When following Supabase & Astro guide, the code examples for the api routes that handle the authentication throw the following error:
Request.formData: Could not parse content as FormData.

Since the project is in hybrid mode, the routes need to specify
export const prerender = false;

@rythmlord on discord

Related issues & labels (optional)

Closes #8798

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any broken links you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/backend/supabase.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Or, we could combine both! What do you think? What feels helpful to you?

Hi Sarah, thanks for checking out my PR, Sorry i wasn't able to see your comment on time. I found your update quite sharp and helpful. 💯

and we're happy to welcome you to Team Docs! 🥳

Thanks it would be an amazing opportunity, Could you please point me in the right direction on how can I be part of the Team Docs, or be considered for it ?

Hi @daniel-moya -- no steps to take, you'll be a Team Docs membger (officially) as soon as this PR is merged! Your avatar will show up in the list of docs contributors shortly!
It's just a friendly name we use, but you are also welcome to join the Astro Discord and self-select the role @team-docs to give yourself a different colour in the Discord. And occassionally we will notify "Team Docs" when there are issues or contributions that we encourage the community to participate in! https://astro.build/chat


Implement missing features

A parallel mapM combinator
Lift everything to MonadBaseControl IO, similar to lifted-async
Implement test suite & benchmark
Proper exports & haddock documentation

meow=w=（逃
你这都是啥，是par monad的一推helper class？

@MarisaKirisame Not a helper library for monad-par, but rather a more lightweight re-implementation of async.


Slackclient passes through slacker rtm start params

Details on these params can be found here: https://api.slack.com/methods/rtm.start
In particular, simple_latest and no_unreads both are helpful for improving performance on startup

Thx for the patch!

@lucywang000 would you be willing to do a release with this?

@louhow Released 1.0.0 version (remove python 2 support too).


only show Überprüfung starten when code exists

otherwise there is not point to it

it's ok, that's not so bad


Implements the dataloads update endpoint.

closes #19
Why was this change made? 🤔
Allow Airflow to provide updates.
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, including data writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡
Unit

@aaron-collier Since I made some changes to the API, I wanted to make sure to get your review. Happy to discuss any of these changes.


User defined templates will be overwritten during manual update

How to reproduce:

download and extract the portable version somewhere
e.g. duplicate and modify a template under Configure Formats

it will be saved correctly

download and extract another portable version on top of the previous one

the previously created template is gone :)

Possible solution:

user templates per category can go into a separate xml file
application will merge the global and user settings into one during app startup

Tested with v3.0.

@chros73 If you have time you can test this version https://ci.appveyor.com/project/wieslawsoltes/batchencoder/build/2025/artifacts.
Hopefully all related issues are fixed.

Thanks. How should I test this?

Download latest CI build, create or duplicate tool or format. Unpack again and check if new configuration is still there.

Thanks, and sorry for the late reply: it's working :)
I created 1 new preset and 2 new formats with b2025 and I overwrote it with latest b2045.
I'll start to use the latest build (b2045) from now on, I'll let you know if I will come up with anything unexpected.

Thanks and congrats for the new release! Performance improvement is also noticeable. :)

@chros73 Thanks!