Improve linking new layers to sdata

This PR allows for the user that if a layer with sdata in the metadata is created and a new layer is created from the napari menu to link the new layer without having to select the layer with sdata in the metadata. In case multiple sdata objects are in the opened layers it will check to see if there is only one sdata in the metadata of the layers in layers.selection. If there is no sdata an error gets thrown. If exactly 1 sdata the layer will be linked. If more than 1 sdata an errow will be thrown.

There seems to be a problem with pytest.raises not catching errors in the Qt event loop. I am not certain how to make that happen yet.

I adjusted the test to just directly call the method. In this way we don't run into problems.

We're currently processing your upload.  This comment will be updated when the results are available.

Looks very good, very useful! I adjusted some docstrings and I split one function to improve a bit clarity and allow for code reuse. Let's see if the CI passes (tests pass locally). Then for me you can merge!


TypeSubTypeValue vertices should be displayed in the same format throughout the UI

On the query page TypeSubTypeValue seeds are required to be in the format:
type,subType,value
or whatever order they are specified in the config.json file.
In the graph view and table view they are presented as:
type|subType|value
and the order does not match the order in the config.json file.

Merged into develop


server.pem not created between 1.10.0 rc1 and rc2

Problem
I get the following error
Error creating machine: Error running provisioning: Unable to verify the Docker daemon is listening: Maximum number of retries (10) exceeded

It appears that no server.pem get generated
If I go back to rc1 of boot2docker then this goes away. Using 1.10.0-rc1 of Docker Engine
Reproduce
$ docker-machine create -d vmwarefusion --engine-install-url=https://get.docker.com/builds/Linux/x86_64/docker-1.10.0 --vmwarefusion-boot2docker-url=https://github.com/tianon/boot2docker-legacy/releases/download/v1.10.0-rc2/boot2docker.iso dev
Running pre-create checks...
Creating machine...
(dev) Downloading /Users/alvinrichards/.docker/machine/cache/boot2docker.iso from https://github.com/tianon/boot2docker-legacy/releases/download/v1.10.0-rc2/boot2docker.iso...
(dev) 0%....10%....20%....30%....40%....50%....60%....70%....80%....90%....100%
(dev) Creating SSH key...
(dev) Creating VM...
(dev) Creating disk '/Users/alvinrichards/.docker/machine/machines/dev/dev.vmdk'
(dev) Virtual disk creation successful.
(dev) Starting dev...
(dev) Waiting for VM to come online...
Waiting for machine to be running, this may take a few minutes...
Machine is running, waiting for SSH to be available...
Detecting operating system of created instance...
Detecting the provisioner...
Provisioning with boot2docker...
Error creating machine: Error running provisioning: Unable to verify the Docker daemon is listening: Maximum number of retries (10) exceeded

Environment
$ uname -a
Darwin vero-3.citrusleaf.local 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10 18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64

@alvinr @nathanleclaire isn't this a docker-machine thing?

Yes -- if provisioning fails the certs will not get copied over to the VM properly, so my suspicion is that the superfluous --engine-install-url=https://get.docker.com/builds/Linux/x86_64/docker-1.10.0 line is causing issues (that flag is meant to specify a URL to a script such as get.docker.com which gets passed directly to shell)

Could this be related to my issue? https://github.com/docker/machine/issues/3092


Error with very small inputs: Please use a computer with more main memory

Expected Behavior
I'm running cluster unit tests on a very small file.  I'm trying to control the memory usage with --split-memory-limit, but it errors unless I give it at least 9GB of memory. This seems like a very disproportionate amount of memory. I haven't been able to create a test dataset that will run with less than 9G of memory, which suggests to me this might be a bug?
Current Behavior
When I try to cluster a very small number of sequences with less than 9G of memory, I get the error: Please use a computer with more main memory.

Input: test.txt

>seq1
GTTTATTTTCTCCTGTTAAATTGTCAGGCCAGAACGGCCAGTTTTCACGGGGTTCAGATA
>seq2
GTTTATTTTCTCCTGTTAAATTGTCAGGCCAGAACGGCCAGTTTTCACGGGGTTCAGATA
>seq3
TATCTGAACCCCGTGAAAACTGGCCGTTCTGGCCTGACAATTTAACAGGAGAAAATAAAC

I've tried easy-cluster and createdb + cluster. I've tried running through docker and conda, and I've tried the latest docker image from master. So far they all raise this error.
Steps to Reproduce (for bugs)
The following commands raise the error. It can only be fixed by using at least 9G of memory (--split-memory-limit 9G).

For self-compiled and Homebrew: Not self-compiled.
Server specifications: 32GB Memory, AVX2 support, although I'm not sure how that interacts with the containers.
Operating system and version: WSL2, Ubuntu 20.04.

The default k-mer size for nucleotides is 15, which indeed requires more than 8GB of RAM.
You can use reduce the k-mer size to 13 (-k 13) so that the k-mer data structures fit in less than 4GB RAM.
Additionally (unrelated to memory use), I recommend to disable spaced k-mers for nucleotides (--spaced-kmer-mode 0). This is an issue we have discovered with regarding sensitivity. We are reworking this currently.

Memory
Thank you so much for your help! I understand now what's happening with the memory, and -k 13 fixes it!
mmseqs easy-cluster test.txt mmseqs tmp --split-memory-limit 2G --threads 1 -k 13

Spaced Kmers
Regarding --spaced-kmer-mode 0, I'm finding that setting is fragmenting my clusters. I wonder if this is at all related to #489?
In this example data, the following 4 sequences are identical except for position 10, which has a T in seq1 and an  A in everything else.
>seq1
CGACGTCAGTGCAGTCGCTAACGTGGCAG
>seq2
CGACGTCAGAGCAGTCGCTTACGTGGCAG
>seq3
CGACGTCAGAGCAGTCGCTTACGTGGCAG
>seq4
CGACGTCAGAGCAGTCGCTTACGTGGCAG

When I run with --spaced-kmer-mode 1, I get the desired clustering result (all are grouped together in one cluster).
mmseqs easy-cluster snp_example.fasta spaced_1 tmp --spaced-kmer-mode 1

# spaced_1_cluster.tsv
seq2    seq2
seq2    seq1
seq2    seq3
seq2    seq4

When I run with --spaced-kmer-mode 0, the sequences are split into two clusters based on that SNP.
mmseqs easy-cluster snp_example.fasta spaced_0 tmp --spaced-kmer-mode 0

# spaced_0_cluster.tsv
seq1    seq1
seq2    seq2
seq2    seq3
seq2    seq4

I can't seem to find any other parameters that will group them all back together again. I am still reading through the manual, but just wanted to document this example data in the meantime.


Dynamically update the operator status based on dependent service status.

The operator should watch for resource dependency updates and update it's status dynamically.

Specifically we are talking about watching the KNativeServing and KNativeEventing objects in their respective namespaces, the Config object for Tekton, and the Deployment objects for the landing page, CLI and Appsody operator.

@mezarin @kaczyns it appears an issue related to this was merged?  Should this be closed or is this still an issue.

@stephenkinder if you are referring to the issue related merged PR 111, this is a follow up work on that issue.

Things have changed a bit since this issue was opened.  I'm not sure we'll be able to do everything we want to do, due to some limitations in controller-runtime (ok they are probably not limitations but I lack the overall understanding of controller-runtime to be able to say what is expected).
Lets start with what we can definitely do.  When the Kabanero controller is created, it should watch the following objects, if the Kabanero instance is the owner (see the existing watch on Collection to see how to do this):

Deployments
Routes
Services

Watching those three things, will let the Kabanero controller re-create any of these things that are inadvertently deleted or modified.
Watching the following cluster-scoped object should also be possible:

Tekton Config (aka config.operator.tekton.dev)

What I'm not sure about, are the namespace scoped objects in other namespaces.  I know that the controller runtime (at least the 0.1.x controller-runtime) would not cache objects outside of the namespace where the controller was deployed, and therefore you had to use unstructured when getting these objects to force the controller-runtime to ignore the cache.  For watches, I don't see a way around the cache.  Now, we're on controller-runtime 0.2.0 now, so maybe things have changed.  We should try watching something like KnativeServing in the knative-serving namespace.  Actually, I don't see a way to specify a namespace on the watch, so perhaps we should investigate that part first (how to specify a namespace).  If there's no way to specify a namespace, then I don't see how we could do this part.  If we can watch in another namespace, then we should also be watching:

KnativeServing in the knative-serving namespace

I'm sort of torn over what to watch for Appsody... it would probably end up being a deployment in another namespace, but that is going to generate a lot of "misses" and probably not worth it.  Perhaps subscriptions in another namespace, to catch the Appsody subscription coming and going?

I think we've come to the conclusion that we can watch what we can watch in our own namespace.  Watching things in other namespaces is hard or impossible until we have a cluster scoped operator.  I am closing this issue for now as "un-implementable" and we'll re-visit this idea when we have a cluster scoped operator or controller.


Add commission and slippage on premium and annual to the quote route

Context
Issue: #60 #61
Changes proposed in this pull request

a helper function to add commission and slippage to the passed value
utilize helper to calculate premium and annual price with commission and slippage

Test plan

Added unit test for the quote route that uses commission and slippage

Checklist

[x] Rebased the base branch
[x] Attached corresponding Github issue
[x] Prefixed the name with the type of change (i.e. feat, chore, test)
[x] Performed a self-review of my own code
[x] Followed the style guidelines of this project
[ ] Made corresponding changes to the documentation
[x] Didn't generate new warnings
[x] Didn't generate failures on existing tests
[x] Added tests that prove my fix is effective or that my feature works

Review
When reviewing a PR, please indicate intention in comments using the following emojis:

:cake: = Nice to have but not essential.
:bulb: = Suggestion or a comment based on personal opinion
:hammer: = I believe this should be changed.
:thinking: = I don’t understand something, do you mind giving me more context?
:rocket: = Feedback

This doesn't feel like the proper place for the slippage and commission calculation but we agreed to merge it and revisit this later. One of the issues with the code right now is the presence of business logic inside the controller - controllers should be skinny as they're not reusable and testing is weirder. Same applies for annualPrice which is calculated in the controller as well. A proper place for the commission and slippage would be inside the sdk. The annual price on the other hand should probably be inside the quote engine itself.

LGTM

Won't merge as we decided to move this to the SDK.


Provisioning profiles should be checked for expiration

I had an older, expired, ad hoc provisioning profile in my ~/Library/MobileDevice/Provisioning Profiles directory that matched the bundle identifier for my target. I did not have the more recently generated (not expired) profile in that directory when I ran codesigndoc the first time.
codesigndoc picked up the expired profile and didn't report any issues with it. After putting the non-expired profile in place (via opening with Xcode), codesigndoc picked up both the expired and non-expired profile during the export process.
It should be fairly simple to add a check for provisioning profile expiration in a similar fashion to the check for certificate expiration. Would this cause any issues?

That's a good point and sure, expiration check would be a great addition. To be honest I guess this slipped through as we always suggest everyone to first make sure they can archive in Xcode and run codesigndoc after that, and Xcode usually resolves this issue.
I'll add the enhancement tag to this as I believe highlighting the fact that a prov profile is expired in the logs would be awesome, maybe with a yellow or red log highlight. Not exporting the expired profile would also be a good idea of course :)
Added help wanted tag too as we probably won't have enough time for this in the near future. We'll definitely check back once we have enough time, but if someone would send a PR we would definitely be glad to review it ;)

Hey look, someone sent a PR! Someone wrote his first Go code!

Awesome, thanks @lyricsboy ! :D I hope it wasn't that painful ;)
Will review it ASAP

Released in v1.2.0 - thanks again @lyricsboy ! ;)


Can i use normalized bbox coordinates for training?

Wanted to inquire whether I can use normalized coordinates between 0 and 1 for training object detection models?

It depends on the algorithm you use.


Only use rack-timeout in staging or production environments

This causes intermittent failures in capybara test suites where js is enabled.
See https://github.com/heroku/rack-timeout/issues/55 for more information.

FWIW, I had been experiencing an issue like the one linked (intermittent failures on Capybara feature specs w/ js: true) on a Suspenders-generated app. Making a change similar to the one in this PR -- at least temporarily, until the linked issue is resolved -- has resulted in 0 non-deterministic spec failures in dozens of runs. Previously, with rack-timeout loaded, the test suite was timing out > 50% of the time on CI.

That's pretty much what we were experiencing. In our case it would almost always fail when running the whole suite, but running individual specs or files was usually fine.
There seems to be open issues on pretty much all the drivers about something similar. This is the one we finally tracked down in our case and it would be great to add this so it doesn't cause others the same headache.

This is interesting. I wouldn't think that a timeout of 10 seconds would cause any tests to fail, so that seems weird to me. But, there shouldn't be any timeout in tests anyway, it's really not that important. So I'm :+1:  on this.

This file was introduced in https://github.com/thoughtbot/suspenders/commit/3f444c82a265865a3294a90d5e6bde86234aa0d8 by @croaky. Would like him to peek this, but I feel positive about this change too.

Thank you!


Unable to build in Azure Devops pipeline using agent specification windows-2019, before the code was building fine using agent VS2017-win2016

Description
Unable to build in Azure Devops pipeline using agent specification windows-2019, before the code was building fine using agent VS2017-win2016(which is decommissioned now)
My VS .net solution is building fine using VS2019 in my local machine but it fails in Azure Devops pipeline using windows-2019 agent.
In my local i had to add one environment variable :
MSBuild with below path
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin
The solution in pipeline was building fine when agent specification used wasVS2017-win2016(which is decommissioned now).
Please help on this.
Platforms affected

[X] Azure DevOps
[ ] GitHub Actions

Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12
[X] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
As this is Company's build i cant share in public.
Is it regression?
yes local development
Expected behavior
The Azure devops pipeline build should be successful using agent-specification windows-2019
Actual behavior
Unable to build in Azure Devops pipeline using agent specification windows-2019, before the code was building fine using agent VS2017-win2016
Repro steps
Unable to build in Azure Devops pipeline using agent specification windows-2019, before the code was building fine using agent VS2017-win2016(which is decommissioned now)
My VS .net solution is building fine using VS2019 in my local machine but it fails in Azure Devops pipeline using windows-2019 agent.
In my local i had to add one environment variable :
MSBuild with below path
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin
The solution in pipeline was building fine when agent specification used wasVS2017-win2016(which is decommissioned now).
Please help on this.

Hey @ShipraRay150.
Please add minimal repro steps with repo how to reproduce the issue.

Sorry i cannot share the repo as it is a organizations so cant share in public.
Issue:
In Azure devops pipeline my .Net framework 4.6 toolversion = 14 was building fine when agent specification used VS2017-win 2016(which is deprecated now). My organization solution is using Fake library to build the solution
But when agent specification used windows-2019 , build is failing at soln.fsx(Fake build script).
(After analyzing the fake build script found 'Fake.DotNet.MSBuild.run' not able to pick the 2019 msbuild) which was completely working fine when agent specification used VS2017-win 2016.
Please help!

I am not able to check the vs2017-win2016(i donot see the link is visible to check software in msdn as this is deprecated) software links to validate which software is missing that needs to be installed in windows 2019

@ShipraRay150 the latest windows-2016 readme is available by this link, you can compare the difference https://github.com/actions/runner-images/blob/493f3c3ee19fc6f2f5456b1f8563f77f0096c3e1/images/win/Windows2016-Readme.md

In my local i am able to build the solution but in Azure Devops Pipeline it is failing.
In my local i have VS2019, but in environment variable i have added:
MSBuild:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin

Please help on this!

@miketimofeev @al-cheb Any suggestions on this issue?

@miketimofeev @al-cheb Any suggestions on this issue?

We can't investigate without repro steps.

Reproducing steps:
1.In Azure devops pipeline my .Net framework 4.6 toolversion = 14 was building fine when agent specification used VS2017-win 2016(which is deprecated now). My organization solution is using Fake library to build the solution
2.But when agent specification used windows-2019 , build is failing at soln.fsx(Fake build script).
(After analyzing the fake build script found 'Fake.DotNet.MSBuild.run' not able to pick the 2019 msbuild) which was completely working fine when agent specification used VS2017-win 2016.

@al-cheb @miketimofeev
Please help on this.

@ShipraRay150, try to add a step:

steps:
- task: BatchScript@1
  displayName: 'Run script C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat'
  inputs:
    filename: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat'
    arguments: x64
    modifyEnvironment: true

@al-cheb
I have one task to execute the Fake build script.
Do i need to add this Batch script before the Fake build script task ?

@ShipraRay150, before the Fake build task.

@al-cheb
Tried but this didnot worked.
MSBuild Path taken: c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe

@ShipraRay150, please attach build logs.

@al-cheb
I need to modify the fakebuild.fsx script to get the msbuildpath to C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin
Can you please help on this ?
What script modification i need to do?
I tried below but didnot worked:
let toolsVersion = "16.0"
let msBuildPath ="C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin"
let setParams defaults =
{ defaults with
Verbosity = Some(Quiet)
ToolsVersion = Some(toolsVersion)
ToolPath = msBuildPath
Targets = ["Build"]
Properties =
[
"Optimize", "True"
"DebugSymbols", "True"
"Configuration", buildMode
]
}

ToolPath should be an exe file, like:
let msBuildPath ="C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe"

@al-cheb
Below is the azure build logs:
2022-09-15T08:57:40.1450368Z ##[command]D:\a\1\s\FAKE\tools\fake.exe "D:\a\1\s\my.fsx" buildcode -fa my.fsx 2021.9.1555277.1 --removeLegacyFakeWarning
2022-09-15T08:57:53.2902202Z targets...
2022-09-15T08:57:53.4913155Z run buildcode
2022-09-15T08:57:53.4913961Z Building project with version: 2021.9.1555277.1
2022-09-15T08:57:53.5010082Z Shortened DependencyGraph for Target BuildCode:
2022-09-15T08:57:53.5010841Z <== BuildCode
2022-09-15T08:57:53.5011120Z
2022-09-15T08:57:53.5463684Z The running order is:
2022-09-15T08:57:53.5464385Z Group - 1
2022-09-15T08:57:53.5464894Z   - BuildCode
2022-09-15T08:57:53.5898143Z Starting target 'BuildCode'
2022-09-15T08:57:53.5919240Z Clean...
2022-09-15T08:57:53.6794089Z Starting task 'MSBuild': D:\a\1\s\source\Common\Common.sln
2022-09-15T08:57:53.7679920Z Building project: D:\a\1\s\source\Common\Common.sln
2022-09-15T08:57:53.7681208Z   c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe  D:\a\1\s\source\Common\Common.sln "/t:Clean,Build" "/m" "/nodeReuse:False" "/p:RestorePackages=False" "/p:OutputPath=D:\a\1\s\build\" "/p:Configuration=Debug" "/p:PlatformTarget=AnyCpu" "/p:Verbosity=Diagnostic"
2022-09-15T08:57:53.8588303Z c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe  D:\a\1\s\source\Common\Common.sln "/t:Clean,Build" "/m" "/nodeReuse:False" "/p:RestorePackages=False" "/p:OutputPath=D:\a\1\s\build\" "/p:Configuration=Debug" "/p:PlatformTarget=AnyCpu" "/p:Verbosity=Diagnostic"
2022-09-15T08:57:54.4908302Z Microsoft (R) Build Engine version 4.8.3761.0
2022-09-15T08:57:54.4909089Z [Microsoft .NET Framework, version 4.0.30319.42000]
2022-09-15T08:57:54.4909531Z Copyright (C) Microsoft Corporation. All rights reserved.
2022-09-15T08:57:54.4909691Z
2022-09-15T08:57:55.1676734Z Build started 9/15/2022 8:57:55 AM.

ToolPath should be an exe file, like: let msBuildPath ="C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe"

tried with this also not worked, for some reason fake build is still taking MSbuild path as: c:\Windows\Microsoft.NET\Framework\v4.0.30319\MSBuild.exe

@al-cheb
Is it possible to add an MSBuild environment variable for this agent windows-2019 in microsoft servers
path: C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin ?

You can add a step to set this variable:
- pwsh: 'Write-Host "##vso[task.setvariable variable=MSBuild]C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin"'
  displayName: 'Set env var'

How to add this ?

You can add a step to set this variable:
- pwsh: 'Write-Host "##vso[task.setvariable variable=MSBuild]C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin"'
  displayName: 'Set env var'

How to add this ?

Click Add a task -> Choose PowerShell:

@al-cheb
My classic build pipeline is working fine but when i ran release pipeline ahent windows-2019 i get this build error:
error CS7034: The specified version string does not conform to the required format - major[.minor[.build[.revision]]]
Can you please help on this??

@ShipraRay150, please share the AssemblyVersion.cs content.

@al-cheb Before the last successful ran with the release pipeline when agent selected was VS2017-win16
I get this error with agent windows-2019

@ShipraRay150, do you have SolutionInfo.cs file?

@ShipraRay150, do you have a SolutionInfo.cs file?

@al-cheb  No we dont have

@al-cheb Any suggestions on this please?

@ShipraRay150, please attach logs of the failed build.

@ShipraRay150, please attach logs of the failed build.

@al-cheb
TestLogs.txt

@al-cheb
Logs:
2022-09-19T17:22:03.9592497Z        "D:\a\1\s\source\TEST.build.Common\TEST.build.Common.sln" (Clean;Build target) (1) ->
2022-09-19T17:22:03.9602035Z        "D:\a\1\s\source\TEST.build.Common\TEST.build.Constants\TEST.build.Constants.csproj" (default target) (14:2) ->
2022-09-19T17:22:03.9603547Z          D:\a\1\s\source\components\Solution\AssemblyVersion.cs(5,28): error CS7034: The specified version string does not conform to the required format - major[.minor[.build[.revision]]] [D:\a\1\s\source\TEST.build.Common\TEST.build.Constants\TEST.build.Constants.csproj]
2022-09-19T17:22:03.9604801Z
2022-09-19T17:22:03.9605560Z     2 Warning(s)
2022-09-19T17:22:03.9606027Z     2 Error(s)
2022-09-19T17:22:03.9606165Z
2022-09-19T17:22:03.9606567Z Time Elapsed 00:00:05.02
2022-09-19T17:22:04.2307568Z Finished (Failed) 'MSBuild' in 00:00:05.6992077
2022-09-19T17:22:04.2311331Z Finished (Failed) 'Release' in 00:00:05.8188469

@ShipraRay150, Please show TEST.build.Constants.csproj content.

@al-cheb
logs.txt

@ShipraRay150, from previous log you passed 2021.9.1646096.1 version. Could you replace the Build part to less than 65535 ( 2<IP_ADDRESS>)  ?

@ShipraRay150, from previous log you passed 2021.9.1646096.1 version. Could you replace the Build part to less than 65535 ( 2<IP_ADDRESS>) ?

@al-cheb Where i need to make this change?

@ShipraRay150, from previous log you passed 2021.9.1646096.1 version. Could you replace the Build part to less than 65535 ( 2<IP_ADDRESS>) ?

sure will do and check

@ShipraRay150, from previous log you passed 2021.9.1646096.1 version. Could you replace the Build part to less than 65535 ( 2<IP_ADDRESS>) ?

sure will do and check

This worked Thankyou..!! (y)

@al-cheb, Hi need one help is there any azure devops pipeline task to copy remote server files to local machine? Please help!

@al-cheb, Hi need one help is there any azure devops pipeline task to copy remote server files to local machine? Please help!

You can publish an artifact and download it manually to the local machine.  How to publish artifacts - https://learn.microsoft.com/en-us/azure/devops/pipelines/artifacts/build-artifacts?view=azure-devops&tabs=classic#publish-artifacts

@al-cheb, Hi need one help is there any azure devops pipeline task to copy remote server files to local machine? Please help!

You can publish an artifact and download it manually to the local machine. How to publish artifacts - https://learn.microsoft.com/en-us/azure/devops/pipelines/artifacts/build-artifacts?view=azure-devops&tabs=classic#publish-artifacts

@al-cheb my requirement like - i want to fetch some certificates from server to my local machine.how can i do that?

Please read message above how to publish artifacts.


Add meta file

There is a lot of boiler plate meta files to be added here. See https://github.com/php-http/boilerplate

Done.


Navbar color Documentation

The new BootStrap 4 docs says that the bg- property, it's now light and not faded anymore. This should be changed in the docs, or explained, at least.

This took me long 3 hours to figure out

ref: https://github.com/twbs/bootstrap/pull/22836#issuecomment-310945638


tiltfile: the helm() command should include requirements

Hello @jazzdan,
Please review the following commits I made in branch nicks/issue1913:
272885b23e9721f50e977b9472128fe4521bf2f7 (2019-07-25 19:37:43 -0400)
tiltfile: the helm() command should include requirements
Fixes https://github.com/windmilleng/tilt/issues/1913

i also considered linking in helm (rather than shelling out). The Helm Go API isn't that complicated, and might be easier to work with than the string-parsing we're doing here. But it might be worth preserving the ability to upgrade helm independently.


Incorrect unicode character handling for chat messages

Idk is it a server issue or a bot issue, I'm having some issues making the chat parser and I don't know how to fix it.
Is it possible to fix it?
Bot Version: 1.20.4
Server Software: Scissors 1.20.4
Library Used: minecraft-protocol 1.50.0
NodeJs Version: v18.17.1
Code:
const mc = require('minecraft-protocol');
const bot = mc.createClient({
host: '',
port: 00000,
username: '',
version: "1.20.4",
});
bot.on('system_chat', (packet) => {
console.log(JSON.stringify(packet))
}
3 Issues
Invalid Emoji Handling
Only Unicode range U+0001 to U+9999 works correctly. Emojis outside this range are displayed as �
Command: /minecraft:tellraw @a "🌫"
Output: {"content":{"type":"string","value":"������"},"isActionBar":false}
Spawnpoint Angle
{"content":{"type":"compound","value":{"italic":{"type":"byte","value":1},"color":{"type":"string","value":"gray"},"with":{"type":"list","value":{"type":"compound","value":[{"insertion":{"type":"string","value":"Username"},"clickEvent":{"type":"compound","value":{"action":{"type":"string","value":"suggest_command"},"value":{"type":"string","value":"/tell Username "}}},"hoverEvent":{"type":"compound","value":{"action":{"type":"string","value":"show_entity"},"contents":{"type":"compound","value":{"type":{"type":"string","value":"minecraft:player"},"id":{"type":"intArray","value":[-304927290,1767587547,-1427566720,-1797465230]},"name":{"type":"string","value":"Username"}}}}},"text":{"type":"string","value":"Username"}},{"with":{"type":"list","value":{"type":"compound","value":[{"":{"type":"int","value":0}},{"":{"type":"int","value":0}},{"":{"type":"int","value":0}},{"":{"type":"float","value":0}},{"":{"type":"string","value":"minecraft:overworld"}},{"insertion":{"type":"string","value":"Username"},"clickEvent":{"type":"compound","value":{"action":{"type":"string","value":"suggest_command"},"value":{"type":"string","value":"/tell Username "}}},"hoverEvent":{"type":"compound","value":{"action":{"type":"string","value":"show_entity"},"contents":{"type":"compound","value":{"type":{"type":"string","value":"minecraft:player"},"id":{"type":"intArray","value":[-304927290,1767587547,-1427566720,-1797465230]},"name":{"type":"string","value":"Username"}}}}},"text":{"type":"string","value":"Username"}}]}},"translate":{"type":"string","value":"commands.spawnpoint.success.single"}}]}},"translate":{"type":"string","value":"chat.type.admin"}}},"isActionBar":false}
Command: /minecraft:spawnpoint @p 0 0 0 0.0
Actual Output: {"":{"type":"float","value":0}}
[Username: Set spawn point to 0, 0, 0 [0] in minecraft:overworld for Username]
Expected Output: {"text":{"type":"float","value":0.0}}
Command: /minecraft:spawnpoint @p 0 0 0 0.1
Actual Output: {"":{"type":"float","value":0.10000000149011612}}
[Username: Set spawn point to 0, 0, 0 [0.10000000149011612] in minecraft:overworld for Username]
Expected Output: {"":{"type":"float","value":0.1}}
Empty Text Field ""
This issue already report by Parker2991, BF5258
Command: /minecraft:tellraw @a {"translate":"","with":[0.1,1]}
Actual Output: {"content":{"type":"compound","value":{"with":{"type":"list","value":{"type":"compound","value":[{"":{"type":"double","value":0.1}},{"":{"type":"byte","value":1}}]}},"translate":{"type":"string","value":""}}},"isActionBar":false}
Command Blocks (e.g., /give or /fill)
Fields such as {"":{"type":"string","value":"@"}} appear unexpectedly.
I have test it long time, it just like "text":"" to "":""
I think the patch code shown by BF5258 is a good way to patch
BF5258 Issues Link

Please make one issue per problem
For the fog emoji issue, after looking into it I can reproduce on Minecraft Java Edition 1.20.6.
In minecraft 1.20+, chat messages are no longer sent as JSON, but as NBT. I looked into this with ChatGPT and the problem lies with our NBT string decoding.
minecraft writes the fog emoji string over the network like this:
ed a0 bc ed bc ab
Inside minecraft-protocol/prismarine-nbt we currently decode the NBT strings as UTF-8, but Minecraft is encoding this string as UTF-16. It's a bit weird as most parts of the protocol are UTF-8 so might have to look into this some more. Maybe NBT is still UTF-16? cc @GroobleDierne
If so we can fix by patching prismarine-nbt's shortString type to decode as UTF-16 which will correctly decode as 🌫

According to wiki.vg Minecraft uses a u16 prefixed modified UTF-8 string as defined here https://docs.oracle.com/javase/8/docs/api/java/io/DataInput.html#modified-utf-8

wiki.vg is not reliable source, have to look at the game code. The encoding above is not valid UTF-8, as the string decoder is falling back to U+FFFD chars which is an error placeholder. It is valid big UTF-16:
ED A0 BC corresponds to the high surrogate D83C in UTF-16.
ED BC AB corresponds to the low surrogate DF2B in UTF-16.

Seems only system_chat command NBT is using UTF-16, other NBT strings are UTF-8 (could be other packets beyond system_chat too). This is a problem as the two encodings are not interchangeable.
This is not easy to fix in prismarine-nbt because the way its protocol spec uses recursion (means we can't just pass down a special flag). Also it seems endianness may be a problem here with Node's Buffer string encoding methods, so that may complicate things further.

Actually you may be right.. I'm not familiar with it, but it could be "modified UTF-8" (bad name). Doesn't really seem like UTF-8 at all based on the website description:
"Supplementary characters are represented in the form of surrogate pairs." Only UTF-16 needs them, and I don't understand why it's needed to introduce them at all here. Basically seems like they switch between UTF-8 and UTF-16 based on the character... kind of surprised this was not picked up earlier.
Seems like we'd need to write a custom text encoder/decoder for this

At this point I really wonder if they on purpose try to make it hard for other people to implement the protocol

After some tinkering I think I have a working decoder for Java's modified utf8

The more annoying thing is that for most network serialization code, the biggest bottleneck is usually text encoding by far. It's expensive to encode/decode unicode like it is to decode Minecraft chunk data as it involves lots of memory operations on a char by char basis. And since strings can get big easily (>1MB), and there's many of them, it's not good idea to do in JS given it's going to create alot of intermediate garbage. We're in Minecraft though so it's not a big deal, but it is something to note.


Update octokit/request to 9.1.1 with ESM support enabled

This unblocks #594 and #593.

Error: [tsl] ERROR in /home/runner/work/scala-steward-action/scala-steward-action/src/action/main.ts(9,23)
TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@octokit/request")' call instead.
To convert this file to an ECMAScript module, change its file extension to '.mts', or add the field "type": "module" to '/home/runner/work/scala-steward-action/scala-steward-action/package.json'.

Those two PRs introduce ESM-only module, which conflicts with the current tsconfig.
We need the below config
    "module": "es2022", // to support ESM
    "moduleResolution": "bundler" // for @vercel/ncc

But tsconfig library does not provide such in https://github.com/tsconfig/bases/tree/main/bases.
(There are some but for specific web app frameworks).
So, tsconfig is now extended instead of copying it every time
Extending is documented:

https://github.com/tsconfig/bases?tab=readme-ov-file#node-20-tsconfigjson
Add to your tsconfig.json:
"extends"<EMAIL_ADDRESS>

Nice! Thanks for taking care of this ❤


:book: move kubestellar clone, release 0.3

Summary
Moved kubestellar clone reference to Get Kubestellar section, release 0.3
Related issue(s)
#692

Remember also that https://github.com/kubestellar/kubestellar/pull/738 makes a bigger change in the main branch.  I am not clear on our position on propagating this to the release-0.3 branch.

@amanroa please let me know if this needs to be approved or not


Node stops responding and memory use keeps growing

Trying to deploy flow-protocol-ethereum makes the node to increase memory use and not responding to rpc calls or producing new blocks. It will run fine for a while then it's like it gets stuck into a loop.
Steps to reproduce the issue
Start frontier node

Build specs

cargo run -- build-spec --dev > specs.json

Update specs.json to give 0xb393de29a6a341a32758735a160f3561b88fded0 some balance

"frameEvm": {
  "accounts": {
    "0xb393de29a6a341a32758735a160f3561b88fded0": {
      "nonce": "0x0",
      "balance": "0xffffffffffffffffffffffffffffffff",
      "storage": {},
      "code": []
    }
  }

Start frontier node

cargo run --  --chain=specs.json --execution=Native --validator --alice --force-authoring --rpc-port=8545 --tmp

Deploy flow-protocol-ethereum
git clone git@github.com:laminar-protocol/flow-protocol-ethereum.git
cd flow-protocol-ethereum
git checkout frontier
yarn install
yarn deploy:development

the deployment will go well for a while and after a few minutes the node will stop responding and producing blocks and memory usage will keep growing.

If the contract does not use CREATE2, then evm v0.18.3 should fix everything even in its stack runner. Contracts with CREATE2 might work but I'm still debugging one final issue.


GH-1882: Added Alias EnsureDirectoryDoesNotExist

@gep13 @augustoproiete @devlead - For #1882

Hey @nikhilagrawaldotnet yes :arrow_right: https://github.com/cake-build/cake/pull/3409#discussion_r674161607

@augustoproiete - Change has been committed. Could you review, approve and merge pls.

@nikhilagrawaldotnet your changes have been merged, thanks for your contribution :+1:


handle task workdir file deletions

Delete files from bucket when deleted on remote instance (so terraform destroy doesn't download them)

Easy for machines: https://github.com/iterative/terraform-provider-iterative/blob/2673108a43d318b5e6c86b5ea8d678764e0db78f/task/common/machine/storage.go#L102

For Kubernetes, it's a bit more involved, though.

I actually was thinking of object storage to local synchronization, not of machine to object storage synchronization. What you asked is as easy as using rclone sync on machines.


It is not possible to send FilterAttributes as Uri Encoded String

The Library currently not allows to send query Params URIEncoded or better to say not retransform the Value.
Please make it possible to send URI Encoded Data.

Resolved in Version 1.4.7


Shrink Dockerfile built image

Hi,
During the build phase of the current Dockerfile, it is being added a node and a npm installation to the final image, and on the next RUN command, a nvm installation is also added. I'm opening this PR to remove this extraneous node/npm installation as it is not being used to run the project. The image size of the current version is 1.1GB, and after this removal, it goes down to 901MB. This update also speeds up the image build process.
Thanks!

I signed it!

That looks reasonable! Thank you very much!


[confidential-transfer] Add confidential burn proof generation and extraction

Problem
There are no proof generation and verification logic for the new confidential mint and burn extension (https://github.com/solana-labs/solana-program-library/issues/6879).
Summary of Changes
Added the proof generation and verification (context extraction) logic for the confidential mint and burn logic. There is already a community PR (https://github.com/solana-labs/solana-program-library/pull/6881) that adds the extension on the program side. This PR just adds the confidential mint and burn zkp logic in the new confidential transfer submodules.
The description of the zkp can be found in https://github.com/solana-labs/solana-program-library/issues/6879, but we basically need the following components:

The confidential burn zkp is essentially the same as that of a confidential transfer. We need the following components:

The ciphertext-commitment equality proof for the newly updated spendable balance in the source account exactly like in a confidential transfer.
The ciphertext validity proof to prove the well-formedness of the ciphertext that encrypts the burn amount. Unlike a confidential transfer, we encrypt w.r.t. source, auditor, and supply authority public keys.
The range proof to prove the remaining balance at the source is a positive 64-bit number and that the burn amount is a 16 and 32-bit number.

The confidential mint zkp is the same as that of confidential burn, but since we don't need to worry about the remaining balance at the source, we remove the ciphertext-commitment equality proof.

I have added ciphertext-commitment equality proof and an extra range proof to the confidential mint proof data. When the supply authority creates a confidential mint instruction, it must add the mint amount to the supply in the mint and prove that this value is a 64-bit number. Since the encrypted randomness that pertains to the supply ElGamal ciphertext is not necessarily known by the supply authority, it must provide an extra commitment to the new supply and generate range proof with respect to this commitment. The ciphertext-commitment equality proof certifies that this commitment holds the same value as the new supply ciphertext.


Package Validator - Check for packages build with licensed features

The Package Validator should check for packages build using licensed features (from the upcoming v3 release) and fail those packages.
Reasoning:
I have noticed a couple of packages that I think were created with package builder given the differences in template format from open source choco. In the future, any (new) packages from the package builder will fail the verifier as it runs open source choco. However, that may not be ideal, as the package install failure would be in the gist, and there may be maintainers asking for help as to why the package is failing. Thus, it would be good for the validator to give an explicit error message.
┆Issue is synchronized with this Gitlab issue by Unito

@pauby adding you here for visibility.  I agree with @TheCakeIsNaOH here, and think we need to get this added prior to the release of v3.0.0 of Chocolatey Licensed.

I agree that we should look at this, but I don't think there will be time to add it to Package Validator prior to the release.


Update zio, zio-test to 2.1.11

About this PR
📦 Updates

dev.zio:zio
dev.zio:zio-test

from 2.1.8 to 2.1.11
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #161.


Fee Rec

Modal:

[ ] show price adjustment in breakdown

Next trade Modal:

[ ] show price adjustment in breakdown

Dashboard:

[ ] show in-progress fee reclamation
>add manual settlement button

Synth swap:

[ ] show fee reclamation
[ ] timer/progress bar in button


(fix) better spacing for job list sort links

before:

after:

 Sort links need spacing from filter section


Rename examples to match raylib more directly

With the upcoming switch to raylib 4.2, some examples have been
re-ordered or removed, while new ones have been added. Rather than
keeping a numbering scheme I figure it's more future proof to simply
use the names of the examples as they appear in raylib (except with
hyphens, of course).

This is fine for now, but IMO these names are already long and we've now made them longer, when it comes to running examples at the REPL -- (claylib/examples/2d-camera-platformer:main)
A nice little addition would be a GUI launcher for all the examples. IIRC cl-bodge had something like this. Good test of Raygui, too.


Fix rsync options

Find out right set of options for efficient and accurate rsync transfers

Fixed thru #66


GEODE-7000: Extract reusable rules from GatewayReceiverMetricsTest

Extract jar-making code from GatewayReceiverMetricsTest into rules for use in other tests:

SingleFunctionJarRule
MetricsPublishingServiceJarRule

For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

@aaronlindsey Please review

It seems like GEODE-7005 has been filed for the failing test in UnitTestOpenJDK11 (also happened on develop https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UnitTestOpenJDK8/builds/903

This was also done in PR #3824, see https://github.com/apache/geode/pull/3824/files#diff-ac14f73a76d33d5c50aca5669b4bbed6

Yeah, I think the idea was to merge this first, but the other PR also got finished around the same time and takes advantage of this extraction

The version in the other PR is more flexible. It allows creating JARs for any class meant to be used by the service loader. It also doesn't create the JAR for you each test. You have to call createJarFor explicitly. This was done because some tests in the test class don't need the JAR.

Oh I looked at the wrong PR was looking at #3829

So, I see some opinions expressed here. Are any of them going to be moved on or should I review this code as it stands?

This work was concurrently done (and merged) as part of #3824, rendering this PR obsolete.


A way to disable home button in left menu

I'm using the left menu to open a drawer. When it's clicked a home button is shown. Is there a way to disable it?

Hi,
Please refer to the sample app, it handles such a case.
Regards,

Alright
On Aug 9, 2016 2:39 AM, "Ari Cheshin"<EMAIL_ADDRESS>wrote:

Hi,
Please refer to the sample app, it handles such a case.
Regards,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/arimorty/floatingsearchview/issues/111#issuecomment-238378230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMO3gezBRFtGZET4rNzYlW_5eRp70guks5qd5r_gaJpZM4JfWc-
.

For the sake of documentation here's the solution:
        mDrawerLayout.addDrawerListener(new DrawerLayout.DrawerListener() {
            @Override
            public void onDrawerSlide(View drawerView, float slideOffset) {
            }

            @Override
            public void onDrawerOpened(View drawerView) {

                //since the drawer might have opened as a results of
                //a click on the left menu, we need to make sure
                //to close it right after the drawer opens, so that
                //it is closed when the drawer is  closed.
                mSearchView.setLeftMenuOpen(false);
            }

            @Override
            public void onDrawerClosed(View drawerView) {
            }

            @Override
            public void onDrawerStateChanged(int newState) {
            }
});

@royale1223 , your question brought to my attention that configuring the menu button with the navigation drawer is not very straightforward, so I added a feature to milstone 2.0.3 to ease the process. Have a look at this  commit.
Thanks for bringing this issue to my attention,
Ari


Can not get macros to work for players.

Can not get  macros to work for players.
For example after dragging the candle to the macro bar it works for the GM but not for players.

So, you dragged the candle to the macro bar as the GM and then it doesn't work when a player uses that macro? Or the player is unable to drag the candle to the macro bar and have it work?

Both seem to work for me

Sorry for the late reply I've been down sick.
I'm running at D&D 5e game through Foundry version 10. I can pull the icon in tot eh macro bar and they function as intended as the GM but nothing happens when I click on the icon as a player.

From: DFreds @.>
Sent: Tuesday, November 29, 2022 4:09 PM
To: DFreds/dfreds-convenient-effects @.>
Cc: dyenrac @.>; Author @.>
Subject: Re: [DFreds/dfreds-convenient-effects] Can not get macros to work for players. (Issue #193)
Both seem to work for me
—
Reply to this email directly, view it on GitHubhttps://github.com/DFreds/dfreds-convenient-effects/issues/193#issuecomment-1331384393, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4CA3KVV62ESKTIMLPUWXSDWKZ5JNANCNFSM6AAAAAASLWKTVQ.
You are receiving this because you authored the thread.Message ID: @.***>

I place the macros in the  players macro tray as the gm

From: DFreds @.>
Sent: Tuesday, November 29, 2022 4:07 PM
To: DFreds/dfreds-convenient-effects @.>
Cc: dyenrac @.>; Author @.>
Subject: Re: [DFreds/dfreds-convenient-effects] Can not get macros to work for players. (Issue #193)
So, you dragged the candle to the macro bar as the GM and then it doesn't work when a player uses that macro? Or the player is unable to drag the candle to the macro bar and have it work?
—
Reply to this email directly, view it on GitHubhttps://github.com/DFreds/dfreds-convenient-effects/issues/193#issuecomment-1331382448, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4CA3KUFXWSRP6CZJ4UFMTDWKZ5BRANCNFSM6AAAAAASLWKTVQ.
You are receiving this because you authored the thread.Message ID: @.***>

I place the macros in the players macro tray as the gm

I'm not sure what you mean by this exactly. How are you placing the macros in the players macro tray as the GM?
My best guess is that this is a permission issue of some sort. What is the permission level for the players on the macro?
Closing this issues as unable to reproduce for now


[QUESTION] Client with the same awesomeness?

Description
Does anyone know a library that can consume a swagger file and provide nice interface for interacting with the API (something similar what suds did for SOAP) ? I'm particularly after auto-generated Pydantic definitions of swagger request/response objects.
I know this is not directly FastAPI related, but since all people here use FastAPI to create awesome APIs I think there is good chance you use similarly-awesome tools to consume those APIs.
Thanks in advance,
Zaar

I'm for it too, as stated in https://github.com/tiangolo/fastapi/issues/71
In the meantime, check this out. It might be what you looking for.

Maybe you're talking about
REQUESTS
http://docs.python-requests.org/en/master/user/quickstart/

No, I'm not talking about requests LOL :)
I'm talking about something like bravado, but with support for:

OpenAPI 3.0
asyncio
Pydantic models.

That's a very interesting idea. In fact, I think is a good idea for a new package.
Bravado seems cool, although as it has to infer and create new methods live from a schema, it doesn't have code generation, so, it can't have completion or type checking.
I think something very interesting to build would be a package that can read an OpenAPI, generate Pydantic classes for the JSON Schemas and generate requests code for the path operations. That would be great.
There are already some code generation tools, but I think they are wrote in Java or something, and the resulting Python code is too verbose. It would be nice to have something that generates these things automatically, and that the generated code is as clean and maintainable as if it was written by hand.
Let's see if someone else finds a tool like that (or gets inspiration from this issue to build one :grin: ).

@tiangolo
Would you commit autogenerated code to git? Or just generate it in dev / docker build in such place that code can import it?
From your experience with Pydantic, do you think implementing JSON Schemas to Pydantic classes conversion will be a straight-forward task?
I guess Path->Python code can be borrowed/inspired by what Bravado does.
P.S.

If the code is as simple enough or comparable to what a developer would write, yes.
For example, I wouldn't add compiled/minified JS code to git. If it was a client that has type declarations, functions, etc, that the whole team can re-use, I would probably commit it. And when the API changes, the client could change, but the changes would be minimal, only in the sections that reflect those changes. But if the client was a binary, or minified JS, the whole thing would change, I wouldn't commit that. But here we're talking about Python, so, probably yes.

From your experience with Pydantic [...]

I think most of the JSON Schema cases (the simplest cases) should be more or less straightforward, the most complex/esoteric cases could be difficult or problematic, but I wouldn't expect a lot of those.

I guess Path->Python code can be borrowed/inspired by what Bravado does.

Yep, most probably yes. The only/main part missing would be actually generating the code.

The only/main part missing would be actually generating the code.

Any particular code-generation tools that you can think of here?

Related: https://github.com/Yelp/bravado/issues/306#issuecomment-485255089

Related!! https://github.com/samuelcolvin/pydantic/issues/643
The above is the first great step.

@tiangolo @haizaar While openapi-generator is written in Java, the vast majority of the code generation work is handled by the mustache templates; given the number of existing python generators, I would expect a pydantic-models/fastapi-friendly generator could be created with minimal effort -- in particular, I suspect it would require zero changes to the java code if all you wanted was to generate pydantic models from an openapi spec. And given that you can specify templates to use at generation time, this would mean it would be usable against the existing release of openapi-generator. (It also wouldn't surprise me if an existing generator could be fully adapted into a full-fledged pydantic+requests client with only changes to the template files.)
While I agree that many of the existing openapi-generator client libraries are currently rather verbose (I haven't looked specifically at the python ones, but the description fits the ones I have seen), I think that is more a reflection of the implementation than of openapi-generator's capabilities. I am currently using a heavily streamlined client with my FastAPI server (in a non-python language) which was produced only by changing the templates of one of the existing clients.
In general, I would expect an approach leveraging openapi-generator to require substantially less initial effort and on-going maintenance. Would this be of interest? I would be happy to put some effort into it, but I would rather not if there is a separate serious effort to build this feature directly into pydantic/fastapi (samuelcolvin/pydantic#643)

@tiangolo @haizaar @dmontagu
I feel the code generation is exciting.
However, I think it's essential to decide what do we create FastAPI controller template before implement.
For example, Java server template has interfaces.
It's mean we can re-generate code And the implementation will be not broken.
Another case, Flask has "connexion" that improve relation flask and openapi.
If we want a simple server template(like a tutorial), then we can create a code generator right now :)
@dmontagu
I agree. We can save time by openapi-generator. It's a good idea.
I think Pydantic should be converted from a few types of file.

Very interesting insights @dmontagu and @koxudaxi !
Also, let me copy some my comment in that PR here:

I started a local experiment to generate Pydantic models from JSON Schema, using Jinja2 templates, and used in a recent project. I'm still not generating models that reference other models.
But I realized that probably a better approach would be to have two separated features (or packages if not suitable for Pydantic?):

From a Pydantic model in memory, e.g. created with create_model, generate the equivalent Python code as a text string e.g.:

from pydantic import BaseModel, Schema

class SomeDynamicModel(BaseModel):
    some_str_field: str
    some_int_field: int = Schema(..., title="Some title")

And from a JSON Schema input, generate a dynamic Pydantic model.

The two features combined would result in being able to generate Pydantic models from JSON Schema.
But the separated components could be extended to, e.g.:

Generate dynamic Pydantic models from DB (e.g. SQLAlchemy) models and then generate the Python code Pydantic models.
Generate dynamic Pydantic models (without Pydantic model code) directly from JSON Schema (might be useful for someone?)
Probably other use cases...

I'm just brainstorming here, but some of these ideas might be useful in case someone ( :wink: @koxudaxi ) implements it before me...

@haizaar @tiangolo @koxudaxi
I created a client generator mostly leveraging openapi-generator here. I haven't been able to test it much yet (hopefully will be stress testing it in the next few days..), and so it probably has plenty of bugs still, but it's a start!
Let me know if you have any thoughts.

@dmontagu
Thank you for the notification.
Great work!
I want to create code-generator for a client. but, I have not started to develop it yet :(
I'm developing datamodel-code-generator  which create pydantic models source code from openapi file.
datamodel-code-generator will support json-schema and  GraphQL as input files.
Next, I will create server/client code-generator for fastapi :)

I think @dmontagu 's fastapi_client and @koxudaxi 's datamodel-code-generator probably solve this use case, right @haizaar ? May we close this issue?

@tiangolo yeap, although I'm not involved with FastAPI anymore (changed hats) but briefly looking both and fastapi_client and datamodel-code-generator I like them both.
/cc @bondi @motinani @worroc


Deprecate MATLAB solver

The EMaligner MATLAB solver has served us well but is a deployment/debugging nightmare and EM_aligner_python has now been battle tested by the largest EM dataset to date.
My suggestion is to keep the code to call the MATLAB solver (excluded from coverage) as well as tests related to them with a skip condition and duplicate those e.g. rough alignment test fixtures using the python solver.

This will relieve some of the issues in #190


Netbeans jus running as Root

I can't run netbeans as a normal user... It throws an permissions exception (java.io.IOException).
As root it runs ok, but not as a normal user.
What can I do?
I'm running OpenJDK 10.0.2 with ubuntu 18.04 and linux 4.15 from the official repositories.
I don't know if this issue has to be posted here, but thank you so much if you answer me what's happening with my netbeans
Netbeans 9 from apache site.. I ran the binary... I didn't compile it

@serpastorg Please don't ask questions here. Instead, please use the mailing lists: https://netbeans.apache.org/community/mailing-lists.html


GH-822: Update contribution docs for GitHub issues

Platforms affected
Website, GitHub
What does this PR do?
As mentioned in https://github.com/apache/cordova-discuss/pull/75, issues will be moving from JIRA to GitHub. This repo, cordova-docs, is the first, and has already been moved. This PR updates the contribution documentation to reflect that issues can be created on JIRA or GitHub.
As well as updating the contribution docs, I have updated the PR template for this repo to remove mentions of JIRA. I have also added a basic issue template, but feedback on that would be greatly appreciated. I guess it could be a separate commit, but it was easier to keep it all together.
Some other things to note:

I have suggested a simple change in commit message style, from CB-822 to GH-822. As you can see, prefixing GH- will automatically link the issue. This is better than #822, because a commit message can't start with # as it marks a comment.
The issue template could be expanded - again, feedback here would be great
Should we still require that users create an issue before submitting a PR? Since everything will be on GitHub, the issue could be redundant.

What testing has been done on this change?
N/A
Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[x] Added automated test coverage as appropriate for this change.

@shazron Thanks for reviewing. I've updated the docs and PR template to make creating a GitHub issue optional.

@shazron @stevengill Thanks for approving. Is there anything else that needs to be done to merge this?


Plugins config compatible with others bundlers

parceljs is another bundler with better and with less configuration.
its not compatible with the actual configuration "if typeof"
if (typeof PLUGIN_FBINSTANT)
it will be compatible if instead of reading that typeof, read a ENV variable and we can be use .env config files
process.env.PLUGIN_FBINSTANT === "true"
so, we can have a .env.production && .env.developtment with different configs
I can submit a PR if you want @photonstorm

Closing this issue due to age. The current solution is less than ideal but works across webpack and rollup, and there are now so many plugins available that adhere to it, it's too late to change it, sorry.


Env variable not passed to vscode extension

I'm trying time to time to see if metals vs-code extension works with Onivim2.
JAVA_HOME variable is not passed to the metals extension in Onivim

But it seems to be available to Onivim

I would expect JAVA_HOME to be available for the extension.
build: 3c720f0e
system: macOS 10.15

Hi @nolondil - this should be fixed now in the latest builds - I was using this scala extension: https://marketplace.visualstudio.com/items?itemName=scalameta.metals
The error message was a bit misleading; it was actually failing here:
https://github.com/scalameta/metals-vscode/blob/3d288d23fc6602dd7531bd9ac6aa2d6eeef2533a/src/extension.ts#L100
due to Onivim not passing in the configuration context (it's expected that metals.javaHome should at least be populated with null) - this was fixed in https://github.com/onivim/oni2/pull/1967

I'll close this out as fixed in #1967 , but please let me know if you're still seeing the issue

@bryphe I confirm that it start the metals server without any configuration done now.


[Web][Regression] - canvas.drawVertices are missing color on web on 2.10.1

Steps to Reproduce

Execute flutter run on the code sample
Vertices drawn with drawVertices don't have colors buffer applied.

    canvas.drawVertices(
      Vertices(
        VertexMode.triangleFan,
        positions,
        colors: positions.map((e) => Colors.red).toList(),
      ),
      BlendMode.src,
      paint,
    );

(see minimum reproducible sample below)
The issue applies to both web renderers (canvas and HTML) and only occurs on the 2.10.1 flutter version.
2.10.1 works fine with desktop apps (macOS, Windows).
The web version was working on 2.10.0 and is not on 2.10.1.
This regression broke our production app, so we had to downgrade the flutter version for now 🔥
Expected results:
On flutter 2.10.0 drawVertices render color buffer properly:

Actual results:
On flutter 2.10.1 drawVertices render vertices without color applied (which results in black):

Code sample

Library bug example: https://pub.dev/packages/ditredi/example (reproducible on 2.10.1).
Minimal reproducible sample:
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Vertex Test',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: MyHomePage(
        shape: [
          /// Creates a 15 sided polygon
          for (int i = 0; i < 16; i++)
            Offset(50, 50) + Offset.fromDirection(2 * pi * (i / 15), 30),
        ],
      ),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, this.shape = const []}) : super(key: key);

  /// The shape to be painted.
  final List<Offset> shape;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Vertex Test'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Expanded(
              child: CustomPaint(
                painter: VertexPainter(widget.shape),
                child: Container(),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

class VertexPainter extends CustomPainter {
  const VertexPainter(this.positions);

  /// Positions should be between (0,0) and (100,100)
  final List<Offset> positions;

  @override
  void paint(Canvas canvas, Size size) {
    canvas.save();
    canvas.scale(size.width / 100, size.height / 100);
    final paint = Paint()..isAntiAlias = true;

    canvas.drawVertices(
      Vertices(
        VertexMode.triangleFan,
        positions,
        colors: positions.map((e) => Colors.red).toList(),
      ),
      BlendMode.src,
      paint,
    );
    canvas.restore();
  }

  @override
  bool shouldRepaint(VertexPainter old) => old.positions != positions;
}

Logs

Issue is reproducible on latest stable 2.10.1 and master but not on stable 2.10.0.
This issue is only on web.
In my testing I was only able to reproduce with canvaskit renderer, but author reports that it affects html as well.
Labeling for further investigation.

screenshots

stable 2.10.0
stable 2.10.1 & master

flutter doctor -v
[✓] Flutter (Channel unknown, 2.10.0, on macOS 12.2 21D49 darwin-arm, locale en-GB)
    • Flutter version 2.10.0 at /Users/nexus/dev/sdks/flutter_rc/flutter
    • Upstream repository unknown
    • Framework revision 5f105a6ca7 (2 weeks ago), 2022-02-01 14:15:42 -0800
    • Engine revision 776efd2034
    • Dart version 2.16.0
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[☠] IntelliJ IDEA Community Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1789:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:351:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:207:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1426:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1861:10)
      #15     runZonedGuarded (dart:async/zone.dart:1849:12)
      #16     runZoned (dart:async/zone.dart:1780:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:205:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:309:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:50:48)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1320:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:94:3)
      <asynchronous suspension>

[✓] VS Code (version 1.64.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.2 21D49 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel stable, 2.10.1, on macOS 12.2 21D49 darwin-arm, locale en-GB)
    • Flutter version 2.10.1 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db747aa133 (7 days ago), 2022-02-09 13:57:35 -0600
    • Engine revision ab46186b24
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[☠] IntelliJ IDEA Community Edition (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue at https://github.com/flutter/flutter/issues.
    ✗ FormatException: Unexpected extension byte (at offset 5)
    • #0      _Utf8Decoder.convertSingle (dart:convert-patch/convert_patch.dart:1789:7)
      #1      Utf8Decoder.convert (dart:convert/utf.dart:351:42)
      #2      InputStream.readString (package:archive/src/util/input_stream.dart:207:30)
      #3      new ZipDirectory.read (package:archive/src/zip/zip_directory.dart:40:30)
      #4      ZipDecoder.decodeBuffer (package:archive/src/zip_decoder.dart:19:30)
      #5      ZipDecoder.decodeBytes (package:archive/src/zip_decoder.dart:14:12)
      #6      IntelliJPlugins._findPluginXml (package:flutter_tools/src/intellij/intellij.dart:130:44)
      #7      IntelliJPlugins._readPackageVersion (package:flutter_tools/src/intellij/intellij.dart:141:40)
      #8      IntelliJPlugins.validatePackage (package:flutter_tools/src/intellij/intellij.dart:63:35)
      #9      IntelliJValidator.validate (package:flutter_tools/src/intellij/intellij_validator.dart:103:15)
      #10     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
      #11     asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:109:18)
      #12     _rootRun (dart:async/zone.dart:1426:13)
      #13     _CustomZone.run (dart:async/zone.dart:1328:19)
      #14     _runZoned (dart:async/zone.dart:1861:10)
      #15     runZonedGuarded (dart:async/zone.dart:1849:12)
      #16     runZoned (dart:async/zone.dart:1780:12)
      #17     asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
      #18     Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:205:9)
      #19     Doctor.diagnose (package:flutter_tools/src/doctor.dart:309:47)
      #20     DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:50:48)
      #21     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1320:12)
      <asynchronous suspension>
      #22     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1161:27)
      <asynchronous suspension>
      #23     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #24     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
      <asynchronous suspension>
      #25     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)
      <asynchronous suspension>
      #26     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #27     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)
      <asynchronous suspension>
      #28     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
      <asynchronous suspension>
      #29     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
      <asynchronous suspension>
      #30     main (package:flutter_tools/executable.dart:94:3)
      <asynchronous suspension>

[✓] VS Code (version 1.64.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.2 21D49 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.11.0-0.0.pre.582, on macOS 12.2 21D49 darwin-arm, locale en-GB)
    • Flutter version 2.11.0-0.0.pre.582 at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (7 hours ago), 2022-02-16 00:00:11 -0500
    • Engine revision b09cf53269
    • Dart version 2.17.0 (build 2.17.0-105.0.dev)
    • DevTools version 2.10.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7772763)

[✓] IntelliJ IDEA Community Edition (version 2021.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin version 213.5744.122

[✓] VS Code (version 1.64.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.34.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.2 21D49 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 98.0.4758.102

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

This started with https://github.com/google/skia/commit/e00afb0a1a68eda6dfad4c3d9558e23dea1dbb3c
@kjlubick @bsalomon Does Flutter Web need to use something like SK_LEGACY_IGNORE_DRAW_VERTICES_BLEND_WITH_NO_SHADER?

I confirm, changing src to dst fixed an issue for web distribution. But from a flutter perspective flags should be consistent between platforms.
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Vertex Test',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: MyHomePage(
        shape: [
          /// Creates a 15 sided polygon
          for (int i = 0; i < 16; i++)
            Offset(50, 50) + Offset.fromDirection(2 * pi * (i / 15), 30),
        ],
      ),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, this.shape = const []}) : super(key: key);

  /// The shape to be painted.
  final List<Offset> shape;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Vertex Test'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Expanded(
              child: CustomPaint(
                painter: VertexPainter(widget.shape),
                child: Container(),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

class VertexPainter extends CustomPainter {
  const VertexPainter(this.positions);

  /// Positions should be between (0,0) and (100,100)
  final List<Offset> positions;

  @override
  void paint(Canvas canvas, Size size) {
    canvas.save();
    canvas.scale(size.width / 100, size.height / 100);
    final paint = Paint()..isAntiAlias = true;

    canvas.drawVertices(
      Vertices(
        VertexMode.triangleFan,
        positions,
        colors: positions.map((e) => Colors.red).toList(),
      ),
      BlendMode.dst,
      paint,
    );
    canvas.restore();
  }

  @override
  bool shouldRepaint(VertexPainter old) => old.positions != positions;
}

OK, I've tried on various platforms and it looks like Dst drops alpha and breaks gradients (when there are multiple colors attached to the triangle).

@bleroux yes, we have fixed the cooler issue with different blend mode.

@jason-simmons  do you think there is something to fix here? The documentation has been updated and using BlendMode.dst is expected to get this code sample working correctly.
The question that’s been bothering me is why this code sample works with BlendMode.src on Android or desktop?

Closing this issue since https://github.com/flutter/engine/pull/31153 improved the documentation for Canvas.drawVertices, especially for the blendMode parameter.


vscode-css-languageservice/test/pathCompletionFixtures/src/data/foo.asar fails the compilation

VSCode Version: latest
OS Version: linux

Steps to Reproduce:

cd extensions/css-language-features/server/ && yarn install

Result:
$ cd server && yarn install
yarn install v1.22.4
warning ../../package.json: No license field
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error https://registry.yarnpkg.com/vscode-css-languageservice/-/vscode-css-languageservice-4.3.4.tgz: Extracti
ng tar content of undefined failed, the file appears to be corrupt: "Invalid package /var/tmp/portage/app-edit
ors/vscode-9999/homedir/.cache/yarn/v6/npm-vscode-css-languageservice-4.3.4-8d8711b31f2b561f78c32e8c85a8584b0b
6dc43b-integrity/node_modules/vscode-css-languageservice/test/pathCompletionFixtures/src/data/foo.asar"

--skip-integrity-check does not help.
I think, there was no such error with versions 1.49.2 (and probably 1.49.3) and older.

Does this issue occur when all extensions are disabled?: N/A

You were right, https://github.com/microsoft/vscode-css-languageservice/commit/a5de5fa48be47a3b0c2cd10f449d843c5f98373f was the cause.
Published<EMAIL_ADDRESS>

Thanks @aeschli
But without bumping it in this repo, it will still pull in 4.3.4 and fail.

done: 362da0a14da717f565383fb7eb27b38d8658f251

Thanks @aeschli
Haven't you forgot ;) https://github.com/microsoft/vscode/blob/795b0dba8d85e0f95f9ffd08a25208af940bfedc/extensions/html-language-features/server/package.json#L12

Thanks, will update.

Thanks @aeschli it compiles fine now.
I have inspected a build log after 362da0a, which should fail, but that action on GitHub in this repository finished successfully:
Installing dependencies in extensions/html-language-features...
$ yarn --frozen-lockfile
yarn install v1.22.5
warning ../package.json: No license field
[1/5] Validating package.json...
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
[2/5] Resolving packages...
[3/5] Fetching packages...
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
warning<EMAIL_ADDRESS>The engine "vscode" appears to be invalid.
[4/5] Linking dependencies...
[5/5] Building fresh packages...
$ cd server && yarn install
yarn install v1.22.5
warning ../../package.json: No license field
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
[5/5] Building fresh packages...

I assume, that because of that, this issue was not caught immediately by GitHub actions.
How could this be so that on my system it fails due to .npmignore, but on GitHub actions this never happens?

To verify check that the published vscode-css-languageservice module (https://unpkg.com/browse/vscode-css-languageservice/) does not contain the test folder

does not contain the test folder

True, but<EMAIL_ADDRESS>has it.


[OPTIMIZER] Fix mismatching type when optimizing kWidth

We need to make sure to convert the while slice of operations in order to make sure the types are always consistent.

We need to make sure to convert the while slice of operations in order to make sure the types are always consistent.

What is the "while slice"?

We need to make sure to convert the while slice of operations in order to make sure the types are always consistent.

What is the "while slice"?

Oops, I meant "whole slice". Meaning we want to take both forward and backward slice recursively. I fixed the typo.


No table to Connect to MySQL via SSH tunnel

What language are you using?
Python
What version are you using?
polars                 0.18.3
connectorx             0.3.1
What database are you using?
MySQL
What dataframe are you using?
Polars
Can you describe your bug?
I need to connect to MySQL via SSH tunnel. In general use case:

we create sshtunnel.SSHTunnelForwarder and put in all the deails.
start the tunnel
Create connection object (conn) via mysql.connector or pymysql
Use that conn in pandas pd.read_sql_query(query, conn)

But in connector-x, we have to use URI like mysql://{mysql_user}:{mysql_password}@{tunnel_host}:{tunne_port}/{mysql_db}
eg. cx.read_sql(con_uri, query)
This same approach we have ti use it for Polars, Which is not working
What are the steps to reproduce the behavior?

we create sshtunnel.SSHTunnelForwarder and put in all the deails.
start the tunnel
Create connection object (conn) via mysql.connector or pymysql
Use that conn in pandas or polars pd.read_sql_query(query, conn)

It gives timeout issue.
Database setup if the error only happens on specific data or data type
NA
Example query / code
tunnel = sshtunnel.SSHTunnelForwarder(
         (ssh_host, ssh_port),
         ssh_username=ssh_user,
         ssh_pkey=ssh_pkey,
         remote_bind_address=(remote_host, remote_port)
)
tunnel.start()

con_uri=f'mysql://{mysql_user}:{mysql_password}@<IP_ADDRESS>:{tunnel.local_bind_port}/{mysql_db}'
query = 'SELECT VERSION();'
cx.read_sql(con_uri, query)
print(cx)```

#### What is the error?

timed out waiting for connection

I run into the same problem with postgresql db. I haven't found a solution yet.

same issue.  when i test with mysql-connector-python:
   # cnx = mysql.connector.connect(
    #     user=MYSQL_USER,
    #     password=MYSQL_PASS,
    #     host=tunnel.local_bind_host,
    #     port=tunnel.local_bind_port,
    #     database=MYSQL_DB,
    #     # connection_timeout=5,
    #     use_pure=True
    # )

it works.
the use_pure flag is the difference between it working and not.
when i try with connectorx or polars - it hangs.
full code:
sshtunnel.TUNNEL_TIMEOUT = 10.0
with sshtunnel.SSHTunnelForwarder(
    (SERVER_HOST, SERVER_PORT), # ssh server
    ssh_username=SERVER_USER,
    ssh_pkey=pkey,
    remote_bind_address=(MYSQL_HOST, MYSQL_PORT), # db server
    local_bind_address=('localhost', 3307)
) as tunnel:
    print(tunnel.tunnel_bindings)
    uri = f"mysql://{MYSQL_USER}:{MYSQL_PASS}@{tunnel.local_bind_host}:{tunnel.local_bind_port}/{MYSQL_DB}"

    # cnx = mysql.connector.connect(
    #     user=MYSQL_USER,
    #     password=MYSQL_PASS,
    #     host=tunnel.local_bind_host,
    #     port=tunnel.local_bind_port,
    #     database=MYSQL_DB,
    #     # connection_timeout=5,
    #     use_pure=True
    # )
    # cursor = cnx.cursor()
    # cursor.execute('SELECT count(1) FROM mytable.order_journal')
    # [print(x) for x in cursor]
    # cursor.close()
    # cnx.close()

    # polars_df = pl.read_database('SELECT count(1) FROM mytable.order_journal', uri)
    query = 'SELECT count(1) FROM mytable.order_journal'
    # print(polars_df.describe)
    cx.read_sql(conn=uri, query=query, protocol='binary', return_type="polars")
    cx.close()
    print('logged off')


ValueError: images do not match (I think during cropping)

I get an error using !fcd -c GOOGLE -s 224 query.csv with a simple query dictionary
searchterm,exclude
keys, key
glasses, glasses
sunglasses, glasses
shades, glasses
remote controll, remote controll
phone, phone
smartphone, phone
mobilephone, phone
wallet, wallet
cash cart, cash cart
atm card, cash cart
credit card, cash cart
when it searches for glasses
Searching: >> glasses <<
I get:
..... trace till imageprocessing.py line 35 then File "/anaconda3/envs/fastai/lib/python3.7/site-packages/PIL/Image.py", line 1442, in paste     self.im.paste(im, box) ValueError: images do not match
From what I found on stack overflow it seems to be that error:
https://stackoverflow.com/questions/12291641/python-pil-valueerror-images-do-not-match
I guess ignoring such an image would be enough (just a try catch). It is 2am so I just quickly did put a try catch within the for loop of imageprocessing.py to resolve it for me and go do bed xD. Maybe there is a better solution to that?
Edit: Later while writing this post I also had a IsADirectoryError in the download so I brainlessly also did put a try catch around im = Image.open(f)....
Nice lib btw.!

Hi
I think there is a misunderstanding of the usage and content of the csv file... The second column (exclude) contains words of your first column that should not be used for naming the classes.
To focus on guitars you specify that for each search, but exclude it for naming...
Example:
searchterm, exclude
guitar fender stratocaster, guitar
gibson les paul,

If you do not want to exclude anything from the search term, simply end the line with an empty column: ", "
For your example I tested that (and it worked with the current code):
searchterm,exclude
keys,
glasses,
sunglasses,
shades,
remote controll,
phone,
smartphone,
mobilephone,
wallet,
cash cart,
atm card,
credit card,

Let me know if this works for you

Yes, that worked for me. That is the problem if you do things during night o_O
It is not important, it works, but I wonder why this triggered that specific error?
Anyway, thx for the help!

Good.
I think there were empty string as a result. I'll mod the code to guard against this...


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Sat Mar 12 2016 22:07:14 GMT-0500 (Eastern Standard Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\Justin Sharp\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\Justin Sharp\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)
    at Function.<anonymous> (C:\Users\Justin Sharp\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\index.js:59:48)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


feat: [WIP] javascript libraries

Description

Copy and paste the URL of a library of your choice into Appsmith to have the library downloaded and ready to use. This statement comes with some limitation though, and is listed below

The library URL that you paste should point to a valid UMD build of the library. Libraries bundled in other module definitions are disallowed.
Evaluations that power Appsmith, run on web worker, and the APIs on the worker are a subset of the ones you find on the main thread. Here's the list of APIs that web workers support.

Libraries that use APIs that are not on web worker are unsupported.

Additionally, libraries that rely on XMLHttpRequest are unsupported.

Installed libraries get autocomplete support.

Additionally, this comes with Appsmith's recommended libraries, which are chosen based on community feedback and popularity

Fixes #2430
Fixes #17310
Fixes #17966
Fixes #17309
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

[ ] https://github.com/appsmithorg/appsmith/pull/17895#issuecomment-1314782428

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

 Front conversations

[ ] Clicking on + adds a scroll bar to the screen since the libraries pop-up window overflows outside the window boundary on the bottom
[ ] Clicking on libraries on the pop-up does not amount to anything.
[ ] Download icon needs a hover and clicked state - design change

/ok-to-test sha=207fb36

/ok-to-test sha=e2af8e4

/ok-to-test sha=6161c30

/ok-to-test sha=08bde86

/ok-to-test sha=9a60d44

/ok-to-test sha=cb23f45

/ok-to-test sha=d2e1ef2

/ok-to-test sha=a6c5ab8

/ok-to-test sha=e0e95fe

/ok-to-test sha=6c85b78

/ok-to-test sha=b19dab0

Fixed all issues mentioned here except

List libraries alphabetically - Will not be worked on since the number of installation in an app will be not more 2 in most cases.
Hitting enter after dropping a library URL does not initiate installation - Will be worked on in an enhancement PR.
Error message should be cleared once link is removed from the input box - This is as per design

/ok-to-test sha=fdaf1ac

/ok-to-test sha=f58c0b0

/ok-to-test sha=90f92b8

/ok-to-test sha=1f46e45

/ok-to-test sha=ad60738

/ok-to-test sha=6de027f

/ok-to-test sha=2510284

/ok-to-test sha=2510284

/ok-to-test sha=3af21dc

Pending fixes from issues raised is mentioned here
Round 2 of QA is complete and the PR can be merged to release with the following caveats:

Git flow hasn't been tested since there's a conflict when merging branches. This also causes issues during git import hence git flow needs a thorough check once backend changes are merged
App and page cloning is failing on a few workspaces due to this issue. But works on other new and old workspaces and custom JS functionality has been verified on new and old apps.

CC: @arunvjn @satbir121

/ok-to-test sha=3c33d5f

/ok-to-test sha=d982f36


show non-debug error if there's a problem with the system-docker config

When the config is unsupported, it tries to start system-docker, and then gives you a kernel crash.
if debug is enabled, there is a log message telling you what's unsupported.

mmm, this isn't going to be 0.9.1 solveable - moving to later.


a word of spelling error

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #3491 (32ffe71) into develop (77a340e) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3491      +/-   ##
=============================================
- Coverage      51.59%   51.46%   -0.14%
+ Complexity      3386     3383       -3
=============================================
  Files            621      621
  Lines          20522    20496      -26
  Branches        2560     2513      -47
=============================================
- Hits           10589    10548      -41
+ Misses          8873     8864       -9
- Partials        1060     1084      +24

Impacted Files
Coverage Δ
Complexity Δ

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 28 more

Codecov Report

Merging #3491 (32ffe71) into develop (77a340e) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3491      +/-   ##
=============================================
- Coverage      51.59%   51.46%   -0.14%
+ Complexity      3386     3383       -3
=============================================
  Files            621      621
  Lines          20522    20496      -26
  Branches        2560     2513      -47
=============================================
- Hits           10589    10548      -41
+ Misses          8873     8864       -9
- Partials        1060     1084      +24

Impacted Files
Coverage Δ
Complexity Δ

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
11.00% <0.00%> (-1.00%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 28 more