PaloAltoPrismaCloud parser not visualising PaloAltoPrismaCloudAudit EventType

Describe the bug
PaloAltoPrismaCloud parser is not visualising audit data from Palo Alto Prisma Cloud. Reviewing the PaloAltoPrismaCloudAudit_CL and PaloAltoPrismaCloudAlert_CL tables confirms both alert and audit data are properly ingested, however only Alert data is visualised when using the PaloAltoPrismaCloud function. Due to that the Palo Alto Prisma workbook is not properly showing Top Sources, Top Users and User Logins queries in group - 5.
To Reproduce
Steps to reproduce the behavior:

Navigate to the LogAnalytics Workspace where Prisma Data is ingested and go to 'Logs'
Confirm if both PaloAltoPrismaCloudAlert_CL and PaloAltoPrismaCloudAudit_CL has data
Run the follwoing query '
PaloAltoPrismaCloud
| summarize count() by EventType
'
The only EventType that should be displayed is PaloAltoPrismaCloudAlert. If properly working, there should be both PaloAltoPrismaCloudAlert and PaloAltoPrismaCloudAudit logs
To confirm, go to the function and:
5.1. replace
| project-away
user_g,
user_s,
resourceName_s,
resourceName_g
with
| project-away
user_s,
resourceName_s

Expected behavior
With the original parser, the only value displayed for EventType is PaloAltoPrismaCloudAlert. When replace the values from the steps above, the displayed values should be for both PaloAltoPrismaCloudAlert and PaloAltoPrismaCloudAudit
Screenshots

Additional context
Due to the error in the parser, Palo Alto Prisma workbook will return errors for the Top Sources, Top Users and User Logins queries in group - 5.

@tbikov : While checking Parser in solution/ folder all the columns were there in Parser please see the screenshot below

Delete the Parser in your environment

Go to Microsoft Sentinel and select your workspace.
Goto Logs and search from Function Palo

3.Delete the function

And try to install the solution steps are given below

Go to Microsoft Sentinel and select your workspace.
Click on content hub (Preview).

Search for Palo alto prisma in search box.

Click on Palo alto prisma and then click on view details.

Once preview page opens click on create.

Select your Subscription, Resource group and Workspace then click on Next: Data Connectors.

Click on Next: Workbooks and fill in the details accordingly and if needed.
10.Click on Next: Analytics and fill in the details accordingly and if needed.
Click on Next: Hunting and fill in the details accordingly and if needed.
Click on Review Create.
Once validation passes. Click on create and solution will deploy in selected workspace.

Once done all the above steps check it parser again. Thanks!

@tbikov Could you please have a look at the previous comment shared by @v-spadarthi

Hello,
I can confirm the Parser we have is the same as the one from the screenshot below, as we’ve been using the Palo Alto Prisma solution from the Content Hub.
Executing the procedure you’ve described reverts the changes I made, and when I use the PaloAltoPrismaCloud function, I can see only records with EventType PaloAltoPrismaCloudAlert.
I guess the reason is that I don’t have the resourceName_g and user_g in the raw data:
@.***
Please advise if there is anything else that I should do to test the behavior.
Regards,
Tsvyatko Bikov
From: v-spadarthi @.>
Date: Monday, 12 December 2022, 13:59
To: Azure/Azure-Sentinel @.>
Cc: Tsvyatko Bikov @.>, Mention @.>
Subject: Re: [Azure/Azure-Sentinel] PaloAltoPrismaCloud parser not visualising PaloAltoPrismaCloudAudit EventType (Issue #6838)
@tbikovhttps://github.com/tbikov : While checking Parser in solution/ folder all the columns were there in Parser please see the screenshot below
[image]https://user-images.githubusercontent.com/101796244/207021800-8e856449-6eb6-45e5-bf5d-2a19ef110b20.png
Delete the Parser in your environment

Go to Microsoft Sentinel and select your workspace.
Goto Logs and search from Function Palo

[image]https://user-images.githubusercontent.com/101796244/207038718-7a557dcc-232b-45cd-b605-e241f78ce164.png
3.Delete the function
[image]https://user-images.githubusercontent.com/101796244/207038908-546f8c66-8ebc-426a-b70c-0ad73bf3fae6.png
[image]https://user-images.githubusercontent.com/101796244/207039006-eafd3b4d-c618-41bb-9efa-58ce07105c80.png
And try to install the solution steps are given below

Go to Microsoft Sentinel and select your workspace.
Click on content hub (Preview).

[image]https://user-images.githubusercontent.com/101796244/207032710-7a52d455-ff2e-4f89-9851-2d9043c07d55.png
5. Search for Palo alto prisma in search box.
[image]https://user-images.githubusercontent.com/101796244/207032892-9e5749a9-4748-4db2-a495-693ce2d37e17.png
6. Click on Palo alto prisma and then click on view details.
[image]https://user-images.githubusercontent.com/101796244/207034466-3e458c91-1dea-4f73-bf15-cac30e5b2ab3.png
7. Once preview page opens click on create.
[image]https://user-images.githubusercontent.com/101796244/207034992-fa52f9b8-8af0-4bfa-abaf-51818c3c18c2.png
8. Select your Subscription, Resource group and Workspace then click on Next: Data Connectors.
[image]https://user-images.githubusercontent.com/101796244/207035728-49b5af61-1de5-4f87-840d-61aee4f202b9.png
9. Click on Next: Workbooks and fill in the details accordingly and if needed. 10.Click on Next: Analytics and fill in the details accordingly and if needed. 11. Click on Next: Hunting and fill in the details accordingly and if needed. 12. Click on Review Create. 13. Once validation passes. Click on create and solution will deploy in selected workspace.
[image]https://user-images.githubusercontent.com/101796244/207037323-b227d886-89df-4987-babc-4ca02789c4fa.png
Once done all the above steps check it parser again. Thanks!
—
Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Sentinel/issues/6838#issuecomment-1346348257, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATMY5FS2YTUNLSNR7VQ2MSLWM4HQHANCNFSM6AAAAAASW2UMK4.
You are receiving this because you were mentioned.Message ID: @.***>

The information contained in this message may be privileged, confidential and protected from disclosure. This message is intended only for the use of the addressee(s) herein. If you are not the intended recipient, please do not save, copy, use, distribute or disclose the information (message and/or attachment(s)) contained herein and please notify the sender of this error by replying to this message and then immediately delete it from your system. Unencrypted Internet communications are not secured. As a result Sunwell Solutions LTD does not guarantee that the sender and/or the content shown is/are the actual sender and/or content.

Hi @tbikov, sorry for the delayed response, we have updated the code in solution, if you are still facing this issue, please let us know, thanks!

Hi @tbikov sorry for the delayed response, we have updated the code and verified and this workbook is giving results for the queries you mentioned

We will be closing this issue, please let us know if you have any further queries, Thank you!


[T3A5][T15-A1] Murray Chen

Ready for Review

@mchen14 Some comments added. Please close the PR after reading comments.

Well done in constructing the formatter class.
Take note that formatter should only format and not performing prints.


Allow the tabs content to define the tab width on xs screens to stop cutting of text

Tabbed title on small screens is getting cut off due to the width setting:

This PR sets the width as auto resulting in:

Thanks @kevinhowbrook! I notice that the tabs now wrap on very narrow screens (<=350px):

- however, the current overlapping behaviour looks pretty bad at that size too, and given that this is a clear improvement for the 350-500ish pixel range, I'm happy to go with this.

Merged in 48c82516dba5c01acd1ed6a67534a6d742ab434f


Memory leak detected

Memory leaks detected when running program sixel2png the input file is map8.six, with address sanitizer.
=================================================================
==8599==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 65536 byte(s) in 1 object(s) allocated from:
    #0 0x7fe68bb70602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fe68b87cae8 in sixel_decoder_decode /home/mfc_fuzz/libsixel/src/decoder.c:277

Direct leak of 1302 byte(s) in 1 object(s) allocated from:
    #0 0x7fe68bb70602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fe68b790377 in image_buffer_resize /home/mfc_fuzz/libsixel/src/fromsixel.c:292

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7fe68bb70602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fe68b798631 in sixel_decode_raw /home/mfc_fuzz/libsixel/src/fromsixel.c:887

Another memory leak detected .
=================================================================
==8561==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x7fc7ef07b602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x7fc7eed9c9ba in sixel_allocator_new /home/mfc_fuzz/libsixel/src/allocator.c:75

The program I ran is img2sixel and the input file is map8.png.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-14072 and https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-14073 has been assigned for these issues (not requested by me).

@fCorleone @fgeek Thanks for reporting!


Add getallheaders Polyfill

This polyfill is a direct copy of https://github.com/ralouphie/getallheaders
Closes #72

Coverage decreased (-2.4%) to 93.775% when pulling 29d39e768aeb786457d64dd190941fb2459dd490 on AddGetAllHeadersPolyfill into 5d7360c0f4bcc93870fa7a9ca3b5efe1632927b2 on master.

Any reason why you have not used composer to add this? See #76.


beit-the question about the analysis of self-attention map

if this piece of code about this part can be open source?
which weights are used in this visualization. The scale display of patch size and image visualized in the paper should not be 224*224 for image size and 16 for patch.

model and code can be found in here

model and code can be found in here

We use 480x480 for input and do interpolation for infering followed by DINO

model and code can be found in here

We use 480x480 for input and do interpolation for infering followed by DINO

Thank you very much. It helps me a lot!

Hi, I tried this code, but if I set the img_size of the model to 480, it would cause a mismatch between the model and the parameters. The error is as follows:
File "E:\visualization\unilm\unilm-master\beit2\visualize_attention.py", line 145, in < module>
msg = model.load_state_dict(state_dict, strict=False)
File "D:\anaconda\lib\site-packages\torch\nn\modules\module.py", line 1497, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for VisionTransformerForMaskedImageModeling:
size mismatch for pos_embed:  copying a param with shape torch.Size([1, 197, 768]) from checkpoint, the shape in current model is torch.Size([1, 901,  768]).
But if I set the img_size of the model to 224 and the weights match, I get the following error:
File "E:\visualization\unilm\unilm-master\beit2\visualize_attention.py", line 182, in < module>
attentions = model.get_last_selfattention(img.to(device))
File "E:\visualization\unilm\unilm-master\beit2\modeling_pretrain.py", line 231, in get_last_selfattention
x = x + self.pos_embed
RuntimeError: The size of tensor a (901) must match the size of tensor b (197) at non-singleton dimension 1
self.pos_embed either 197 or 901 will give an error。I tried setting both input_size and img_size to 224 and it worked。

@zwx519 , the model is pre-trained under 224x224 and the pos_embed's shape should be [1, 197, 768], it will do interpolation while inferring (more details in code).
It seems that the issue is caused by setting the img_size to 480 when creating the model. You can keep the img_size at 224 when creating the model, which allows you to deal with various resolutions using online interpolation op.

Thank you very much！this solved my problem perfectly.


Email Verification Request Issues

this has been copied over from gitea
/account/verify needs to be able to handle failures from /api/account/verify-email/resendwhen requesting via the resend button.
Additionally the UI looks a bit mushed and could use some padding?

Old issue reference: https://git.lumeweb.com/LumeWeb/portal-dashboard/issues/23

fixed


[BEAM-4007] Futurize typehints subpackage

This pull request prepares the typehints subpackage for Python 3 support. This PR is part of a series in which all subpackages will be updated using the same approach.
This approach has been documented here and the first pull request in the series (Futurize coders subpackage) demonstrating this approach can be found at #5053.
R: @aaltay @tvalentyn

R: @charlesccychen

Thanks @RobbeSneyders.  I added some minor comments above.

Is this PR ready to merge?

@pabloem Not yet--finishing running Dataflow benchmarks.

Thanks, this LGTM.


Restore of database backup from S3 storage fails

Restore of a compressed, encrypted database backup fails. Media restore (also compressed and encrypted) works fine though.
Media:
python manage.py mediarestore -z -e --passphrase pass
Restoring backup for media files
Finding latest backup
Restoring: media-2018-10-08-223640.tar.gz.gpg
Are you sure you want to continue? [Y/n] Y

Database:
python manage.py dbrestore -z -c --passphrase pass
Finding latest backup
Restoring backup for database 'default' and server 'None'
Restoring: default-2018-10-08-221305.psql.gz.gpg
Restore tempfile created: 0 B
Are you sure you want to continue? [Y/n]

I thought it might be the size of the backup, so I started with truncated tables but it also shows the same behavior (Restore tempfile created: 0 B)
Does anyone have any clue what might be the issue here?

@MarkDoggen What's your backup size from the storage ?

It is 1.2 GB (compressed and encrypted)

Hello,
I had the same issue.
Looking at the code, the only difference from applying both options together (decrypt and uncompress) is that the function uncompress_file receives a SpooledTemporaryFile instead of a normal file.
Then the following line is responsible of uncompressing the file:
zipfile = gzip.GzipFile(fileobj=inputfile, mode="rb")
Probably GzipFile is not working with SpooledTemporaryFile. A possible solution is to first encrypt the file and then compress it. I check the size of the encrypt-compressed file after changing the order and is even smaller than compressing-encrypting.

You can't compress an encrypted file.
Compress first, the encrypt.

@galt, I tested encrypting first and worked fine. Even, the encrypted-compress backup is smaller than the other way around.

Here a column that recommends encryption before compression for security:
https://blog.appcanary.com/2016/encrypt-or-compress.html
@ZuluPro ZuluPro it's possible to commit this change?

Your results seem miraculous. Please double-check them. Can you decompress and decrypt both of the files and recover the complete and correct original input? Perhaps you have labeled them backwards?


Revert "Syndicate Horn"

Reverts Verbalase/Goob-Station#41
It's breaking my PR currently - reverted until we can fix it

it was NOT this bug

:3


issue with macd

i have a code which looks like this
        d1['RSI'] = d1.ta.rsi().fillna(0).round(2)
        d1['SMA20'] = d1.ta.sma(length=20).fillna(0).round(2)
        d1['SMA50'] = d1.ta.sma(length=50).fillna(0).round(2)

        d1['MACD'] = d1.ta.macd().MACD_12_26_9.round(2)
        d1['MACDH'] = d1.ta.macd().MACDh_12_26_9.round(2)
        d1['MACDS'] = d1.ta.macd().MACDs_12_26_9.round(2)

since last 4 days I am getting an error with MACD calculation
I am copy pasting the error message below.
I have very basic knowledge of python, so any help on how to circumvent this issue would be of great help.
Thanks.
I:\PycharmProjects\pythonProject\fno_indicators.py:58: FutureWarning: reindexing with a non-unique Index is deprecated and will raise in a future version.
  d1['MACD'] = d1.ta.macd().MACD_12_26_9.round(2)
Traceback (most recent call last):
  File "I:\PycharmProjects\pythonProject\fno_indicators.py", line 58, in <module>
    d1['MACD'] = d1.ta.macd().MACD_12_26_9.round(2)
  File "H:\fin\lib\site-packages\pandas_ta\core.py", line 1013, in macd
    result = macd(close=close, fast=fast, slow=slow, signal=signal, offset=offset, **kwargs)
  File "H:\fin\lib\site-packages\pandas_ta\momentum\macd.py", line 67, in macd
    df = DataFrame(data)
  File "H:\fin\lib\site-packages\pandas\core\frame.py", line 636, in __init__
    mgr = dict_to_mgr(data, index, columns, dtype=dtype, copy=copy, typ=manager)
  File "H:\fin\lib\site-packages\pandas\core\internals\construction.py", line 502, in dict_to_mgr
    return arrays_to_mgr(arrays, columns, index, dtype=dtype, typ=typ, consolidate=copy)
  File "H:\fin\lib\site-packages\pandas\core\internals\construction.py", line 125, in arrays_to_mgr
    arrays = _homogenize(arrays, index, dtype)
  File "H:\fin\lib\site-packages\pandas\core\internals\construction.py", line 607, in _homogenize
    val = val.reindex(index, copy=False)
  File "H:\fin\lib\site-packages\pandas\core\series.py", line 4672, in reindex
    return super().reindex(**kwargs)
  File "H:\fin\lib\site-packages\pandas\core\generic.py", line 4966, in reindex
    return self._reindex_axes(
  File "H:\fin\lib\site-packages\pandas\core\generic.py", line 4986, in _reindex_axes
    obj = obj._reindex_with_indexers(
  File "H:\fin\lib\site-packages\pandas\core\generic.py", line 5032, in _reindex_with_indexers
    new_data = new_data.reindex_indexer(
  File "H:\fin\lib\site-packages\pandas\core\internals\managers.py", line 679, in reindex_indexer
    self.axes[axis]._validate_can_reindex(indexer)
  File "H:\fin\lib\site-packages\pandas\core\indexes\base.py", line 4107, in _validate_can_reindex
    raise ValueError("cannot reindex on an axis with duplicate labels")
ValueError: cannot reindex on an axis with duplicate labels

Hello @hanging-man,
Which version of Pandas TA are you running? Do you have TA Lib installed? Has it been working before the previous 4 days? Do you have more code that you are leaving out to share so someone can replicate the Error? Since this is a Pandas Error and not a Pandas TA Error, have you searched here for help on resolving it?
Kind Regards,
KJ

I would like to thank you for pointing out that this is a pandas error and not a pandas ta error. I couldn't have figured that out. However after that I tried to do some research as to where problem was and figured out that data from two dates in may had duplicate values. After I rectifed it the code ran.
Please pardon me for asking such a silly question. I have very basic programming skills.
Thanks again.
Anirban

@hanging-man,

I would like to thank you for pointing out that this is a pandas error and not a pandas ta error. I couldn't have figured that out. ... Please pardon me for asking such a silly question. I have very basic programming skills.

No worries. Glad you were able to figure it out and resolve the duplicated values. 😎
As a new programmer, I understand there is a lot to digest and it can be overwhelming when you see a wall text in a Stack Trace. The good news is, you are not likely to be the only one to receive such an error and many of them have possible solutions already via a search. Keep programming and you will get better. 😎
Kind Regards,
KJ


messageformat requires unsafe-eval in Content-Security-Policy

When using a CSP which does not allow unsafe-eval, the 'new Function' throws an EvalError, as per the spec.
However, messageformat uses this:
if (typeof messages != 'object') {
var fn = new Function(
'number, plural, select, fmt', Compiler.funcname(locale),
'return ' + obj);
var rt = this.runtime;
return fn(rt.number, rt.plural, rt.select, this.fmt, pf[locale]);
}
Is there another way to fix this.

If you build your messages (say, as part of your webpack build), they get built into very small, fast functions that don’t violate unsafe-eval.
Docs: https://messageformat.github.io/build/

I have a use case where the message strings are only available at runtime, not build-time, and I cannot change the CSP to allow eval. Is there any hope for a mechanism that will allow messageformat to work in that environment?

it’s unlikely with our setup I think. The formatjs folks have their own
very similar version though intl-messageformat I’m pretty sure. That’ll
do what you’re looking for.
On Sun, Mar 4, 2018 at 12:23 AM Simon Tesla<EMAIL_ADDRESS>wrote:

I have a use case where the message strings are only available at runtime,
not build-time, and I cannot change the CSP to allow eval. Is there any
hope for a mechanism that will allow messageformat to work in that
environment?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/messageformat/messageformat.js/issues/180#issuecomment-370210895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF5KkodbBRj5qb5JcVa2oCxfGYxUI2Wks5ta6RpgaJpZM4P6xv_
.


[Gluon] Data augmentation

How to augment the data in the data loading for an array dataset like CIFAR in gluon? One way I can think is using image record. Is there any other way to augment the data in the iterator?

Kindly suggest how to go ahead ...Mxnet authors..


Loaded english dictionary from...", fname

Traceback (most recent call last):
File "startquill_cherry.py", line 9, in
from QuillSourceProcessor import QuillSourceProcessor
File "/home/Quillpad-server/QuillSourceProcessor.py", line 131
"Loaded english dictionary from...", fname
^
IndentationError: unexpected indent

Python has a problem if tabs and spaces are mixed in the same script.
When in doubt change your editor to make tabs and spaces visible. It is also a very good idea to have the editor resolve all tabs to 4 spaces or always use tabs to avoid this confusion.


Boilerplate install.sh and

This completes the refactoring of install.sh and its supporting script build.sh so that both now use bash3boilerplate to achieve more sophisticated argument parsing and more robust execution.
Next steps will involve more extensive support for the arguments listed in install.sh-usage and and an option to install the Open Fortran Parser.

[Current coverage][cc-pull] is 54.72%

Merging [#173][cc-pull] into [add-install-script-boilerplate][cc-base-branch] will increase coverage by +15.99%

@@           add-install-script-boilerplate       #173   diff @@
================================================================
  Files                                   2         31     +29
  Lines                                 901       1970   +1069
  Methods                                 0          7      +7
  Branches                                0        736    +736
================================================================
+ Hits                                  349       1078    +729
- Misses                                552        856    +304
- Partials                                0         36     +36

3 files (not in diff) in src/tests/unit/sync were created. more
5 files (not in diff) in .../tests/unit/send-get were created. more
6 files (not in diff) in ...s/unit/init_register were created. more
5 files (not in diff) in ...sts/unit/collectives were created. more
3 files (not in diff) in ...oarrayHeatSimplified were created. more
3 files (not in diff) in ...arrayBurgers/library were created. more
3 files (not in diff) in ...lvers/coarrayBurgers were created. more
1 files (not in diff) in ...rc/tests/integration were created. more
2 files (not in diff) in src were modified. more

Partials +7
Hits -7

[][cc-pull]

Powered by Codecov. Last updated by 548afe6
[cc-base-branch]: https://codecov.io/gh/sourceryinstitute/opencoarrays/branch/add-install-script-boilerplate?src=pr
[cc-pull]: https://codecov.io/gh/sourceryinstitute/opencoarrays/pull/173?src=pr


NFC java file changes for SDK >31

Already included in https://github.com/chariotsolutions/phonegap-nfc/pull/460, thus this PR could be closed as duplicate.


[$250] Web - Console error shows up when creating room and opening room chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/24643
Action Performed:

Go to staging.new.expensify,com
Create a new account
Create a new workspace
Create a public room

Expected Result:
No console error
Actual Result:
Console error shows up when room chat is opened
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.56-7
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/57af92a8-0584-4dba-8eff-c2e7a46263e9
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b3473e5d9167fdde
Upwork Job ID:<PHONE_NUMBER>525639168
Last Price Increase: 2023-11-03

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We are trying to parse the URL and relative href can't be parsed and that's why it jumps to the catch block where we are consoling the error. I think we can just remove console line.
https://github.com/Expensify/App/blob/44eb88a7b6643b6b75978927adc83715e6c06824/src/libs/Url.js#L25

I don't think this is a bug or a blocker as this console.log seems to have been added for debugging purposes. We can decide to remove it if we want, and do so in any of the PRs submitted for this repo, but I suggest we close this

It looks like this is failing in the constructor, and maybe instead of deleting that log line, we should update it to also log the url we're passing to the method

Agreed that this doesn't seem like a bug, and certainly not a deploy blocker. It makes sense to me to remove the console.error there.

Proposal
Please re-state the problem that we are trying to solve in this issue
Web - Console error shows up when creating room and opening room chat
What is the root cause of that problem?
This is due to console.error being present in the places
https://github.com/Expensify/App/blob/44eb88a7b6643b6b75978927adc83715e6c06824/src/libs/Url.js#L25
and
https://github.com/Expensify/App/blob/44eb88a7b6643b6b75978927adc83715e6c06824/src/libs/Url.js#L45
Why did new URL(url) fails?
It is because we are trying to parse links such as /settings/profile/display-name, which causes URL to fail as it requires a proper format (i.e., including origin).
What changes do you think we should make in order to solve the problem?
We should use tryResolveUrlFromApiRoot to append the correct origin to the url if needed here
https://github.com/Expensify/App/blob/44eb88a7b6643b6b75978927adc83715e6c06824/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js#L26
to
const attrHref = tryResolveUrlFromApiRoot(htmlAttribs.href || '');

And remove console.error OR change to console.warn
Maybe Optional
In CONFIG.js
https://github.com/Expensify/App/blob/44eb88a7b6643b6b75978927adc83715e6c06824/src/CONFIG.js#L23
can be changed to get no problem with link rendering in the DEV server.
const expensifyComWithProxy = getPlatform() === 'web' && useWebProxy ? Url.addTrailingForwardSlash(window.location.origin) : expensifyURL;

What alternative solutions did you explore? (Optional)

Switching to monthly since this isn't a priority

No update. Focused on W9 and this is not a priority

No update, focused on detailed design for Wave 9: Violations

It is because we are trying to parse links such as /settings/profile/display-name, which causes URL to fail as it requires a proper format (i.e., including origin).
What changes do you think we should make in order to solve the problem?
We should use tryResolveUrlFromApiRoot to append the correct origin to the url if needed here

@Ollyws can you please review @shubham1206agra 's proposal? I think it looks good but I think we should fix the URL with tryResolveUrlFromApiRoot and not remove the console.error since that's what surfaced this issue. What do you think? cc @roryabraham

@lanitochka17 can you re-test and see if you can still reproduce please?

Issue is not reproduced on latest build 1.3.96-5
Windows10/Chrome
https://github.com/Expensify/App/assets/78819774/eae61f3f-89db-43fa-985f-958ae3bcbd08


weird Texture

Hi @FuxiCV thanks for sharing your great project. I am getting weird textures when i implement your repo. Would you mind to tell where i am doing mistake.
input Image:

Texture made:

Hi @t-qureshi, it looks like the checkpoint file is not loaded correctly, did you download our pre-trained model and put it into the right directory?

Thanks @Agent-INF you are right. I missed to set the correct path of pre-trained model.


Adds a proof harness for s2n_stuffer_*_base64

Please note that while we are transitioning from travis-ci to AWS CodeBuild, some tests are run on each platform. Non-AWS contributors will temporarily be unable to see CodeBuild results. We apologize for the inconvenience.
Resolved issues:
N/A.
Description of changes:

Adds a proof harness for the s2n_stuffer_read_base64 function;
Adds a pre- and post-conditions to the s2n_stuffer_read_base64 function;
Adds a proof harness for the s2n_stuffer_write_base64 function;
Adds a pre- and post-conditions to the s2n_stuffer_write_base64 function;
Adds a stub for the mlock function;

Call-outs:
N/A.
Testing:
N/A.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2068 into master will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #2068      +/-   ##
==========================================
+ Coverage   81.06%   81.07%   +0.01%
==========================================
  Files         247      247
  Lines       18390    18395       +5
==========================================
+ Hits        14907    14914       +7
+ Misses       3483     3481       -2


Add 09 21 2023 cap update.

Had to remove:

Arbitrum LUSD update
Metis Metis update

Due to them being updated too recently
https://gauntlet-network.atlassian.net/browse/RR-216

Queued all updates in optimism, arbitrum, ethereum and metis safes


Add reference to a better way of declaring SF cert

https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-cluster-creation-create-template#add-all-certificates-to-the-virtual-machine-scale-set-osprofile
While the above works, it creates a problem when you renew the cert since the versioned URL will be broken. It'd be great to point to a better option of using Azure Key Vault VM extension pulling down versionless secret which is friendly to auto rollover. It is documented here.
https://docs.microsoft.com/en-us/azure/service-fabric/cluster-security-certificate-management#simplifying-management---an-autorollover-example

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 876be5c9-f2d1-d9c6-3984-916d0d657110
Version Independent ID: 390cccd9-8771-ac2d-f439-f1990aacd64c
Content: Create an Azure Service Fabric cluster template - Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-cluster-creation-create-template.md
Service: service-fabric
GitHub Login: @erikadoyle
Microsoft Alias: edoyle

@chitturs Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@chitturs Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@erikadoyle Can you please check and add your comments on this doc update request as applicable

@erikadoyle Can you please check and add your comments on this doc update request as applicable

@erikadoyle Can you please check and add your comments on this doc update request as applicable

@erikadoyle Can you please check and add your comments on this doc update request as applicable


Please update to 1.19.2

While version 1.1.0 does not natively support Minecraft 1.19.2 with the bundled version of SGUI, you can override the bundled version of SGUI with an updated SGUI version that supports Minecraft 1.19.2.

Hello @haykam821, sorry for the late response.
Everything works, thanks! I think this can be closed now 😊


pptr.dev shows blank page in a case if service worker is not available

pptr.dev uses service worker as its core, but it is possible that service workers are not available. It can be so in older browers, but service workers are also disabled in Firefox when page is open in private browser mode (see reference in documentation and issue). It makes site to display blank page without giving any information for the visitor about reason of the problem.
It would be good to display something on the page in a case if service worker is not available in browser so users will not stuck.

Interesting! I wonder why absense of service worker support results in an empty page: the website should load just fine from network.
Thanks for reporting this.

ETA on a fix for this?  I browse in private mode almost exclusively and this issue is problematic.

It turns out this happens because Firefox Private Browsing prohibits use of IndexedDB.
https://pptr.dev uses IndexedDB to cache documentations and release information for puppeteer versions. Caching is important so that we don't hit github/npm too much.
To fix Firefox Private Browsing, we will need to add a fallback to localstorage.

For the record: this is a long-standing firefox bug - https://bugzilla.mozilla.org/show_bug.cgi?id=781982

Fixed and deployed a new website version - please check it out.

It works now, thank you!!


fix(general): clean up typos and code

Issue #, if available:
Description of changes:

Changes:

Fix some of the markdown used
Removed unused imports
LambdaHandlerProcessor - Make null check easier to read
LambdaJsonLayout - Remove unused objectMapper
Fix typos

Checklist

[X] Meet tenets criteria
[X] Update tests
[X] Update docs
[X] PR title follows conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for the PR Michael, just looking at this now.

@pankajagrawal16 - maybe where possible we make things final as it reduces any kind of side effects. I just did not want to make too many trivial changes.
Maybe there anti-bike shedding type of autoformatter do java like "black" for python or "ktlint" for kotlin. To clean up imports and naming conversions.

@pankajagrawal16 - maybe where possible we make things final as it reduces any kind of side effects. I just did not want to make too many trivial changes.
Maybe there anti-bike shedding type of autoformatter do java like "black" for python or "ktlint" for kotlin. To clean up imports and naming conversions.

Having autoformatter sounds like a good idea, but I will suggest please open a RFC for it so that we can track it. As far as client of the library is concerned, it doesn't impact them directly, but definitely worth evaluating at some point.


fix: arrow position using offsetParent client offset

A tweak to #1023
The arrow's offsetParent may not always be the popper, for example with the following DOM:

This still handles the case where the popper is the offsetParent (the existing test)
What it doesn't handle is the case where the popper is not the offsetParent, but it has a border/scrollbar. (This also includes any arbitrary parentNodes of the offsetParent that have borders/scrollbars I think).
In the cases I am using it, the offsetParent is always the one with the border & styling. I'm not sure if handling all arbitrary parents' client offsets is common or worth it...

@FezVrasta may you publish a patch release with this? Some bordered arrow styles require this with image snapshot tests 😓

2.1.1, done


perf(python): Enhance the Python benchmark script

What does this PR do?
Enhance the Python benchmark script to support more parameter options
Related issues
Does this PR introduce any user-facing change?

[ ] Does this PR introduce any public API change?
[ ] Does this PR introduce any binary protocol compatibility change?

Benchmark

need update ci #1927


Game crashing with mod

Description
so I play with a lot of mods and everything is fine but when I added the shoulder surfing mod, it does not work and the game gives me this error:
" The game crashed whilst exception in server tick loop
Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.world.entity.Entity.m_9236_()" because the return value of "com.github.exopandora.shouldersurfing.api.model.PickContext.entity()" is null "
exit code is -1
the forge version is 47.3.1
I would try and see what causes the issue myself but I am no expert in debugging and coding unfortunately
Steps to Reproduce
unknown
Minecraft version
1.20.1
Game Logs
https://mclo.gs/x0JGOhw
Additional Information
No response

Thanks for reporting! The crash was caused by Project Expansion, and will be fixed in the next release of Shoulder Surfing Reloaded.


Upgrade to SQLAlchemy 2

#1177

[x] Fix issues upstream with Databases https://github.com/encode/databases/pull/582
[x] Update dependencies on Databases and SQLAlchemy
[x] Update Ormar for SQLAlchemy 2 changes

select() now take multiple params rather than a collection
SQLAlchemy now compiles some statements differently, but logically equivalent

I know that we use sqlalchemy only in the core part but to be honest it's much fewer changes than I expected in this codebase for v2.0 support😅
Also appreciate you took it and solved it with databases too 🚀
Great job! 🎉
One test is failing now on parenthesis comparison (I think the one you changed).

Yep, I haven't updated Poetry yet since I'm still waiting on databases to make a release. I can update it to point at their GitHub for now if you just want to see it pass.
Databases has now also dropped support for 3.7, should I do that as well as part of this PR?
It was a lot less changes than I was expecting too lol, I guess databases just bears most of the work for this.

I can wait for the release, they just did 0.9.0 bit not sure if your change was included, guess so as it was merged

Oh yeah 0.9 should be good, I'll finish this up soon then

@collerek We need to remove 3.7 support in order to merge this, should I make another PR to do that? We might want to add 3.12 too while we're at it

You can remove it here, it's removed in pydantic v2 pr already

BTW it seems like a significant performance degradation over the previous version, we need to check if caching is working as described here: https://docs.sqlalchemy.org/en/20/faq/performance.html

How can I and/or others help? I just don't want to step on anyone's toes.

Sorry, I'm going to try to come back around to this soon. I think there's a single PostgreSQL test that is failing still and there are the performance problems mentioned by collerek earlier. If you want, you can fork my branch and send a PR for me to merge into this one. Let me know if you want to try and tackle one of those, thanks for the help!

I'll take a look, I still don't know if I have enough expertise to actually do something useful. If I find something, you'll get PR, of course.

@pmdevita I was at liberty to cherry-pick your changes onto master branch and create feature/sqlalchemy2. On my machine testing signals fails, but I'll leave that for later. I'll try to find what's going on with performance, first.

I don't just want to sell out on the databases project... but with 2.0 SQLAlchemy does support async on its own now. I don't really know that much about Ormar's internals but is it worth cutting out the middle man and just working with SQLAlchemy directly?

Well I went and dug a bit myself, looks like we only use the databases library to execute SQLAlchemy expressions asynchronously in QuerySet, which is very possible now in SQLAlchemy 2. There would be some public API changes since we'd no longer use databases to create the DB connection, but it doesn't seem like it would be a huge hassle and we'd benefit by not having to worry about the state of the databases library. Do you have any thoughts @collerek?


Exactly 0 or 1 blocks of a particular kind in the admin area

I'm currently building a Wagtail model for the website of a student association. We need:

a single field in the admin area that accepts:

exactly one list of:

an arbitrary number of ImageChooserBlock objects

a second single field that accepts:

exactly zero or one of a particular StructBlock instance.

The attributes min_num, max_num and block_counts of StructBlock are clearly not satisfactory, since they only take effect upon validation... this is not understandable by our users.
The issue #2048 seems closely related to this wish. Despite the fact that it is three years old, the problem seems unresolved. However I can't really believe that no solution or workaround has been found in the meantime.
Did I miss anything or is this really impossible to achieve with Wagtail?

Hi @kalsan,
Enforcing min_num / max_num on the client side will be implemented as part of the work on unifying StreamField and InlinePanel UX in #4473.

Thanks for your fast reply. I'm looking forward to try out the new version(s). Wagtail is really really promising and I think this will increase its value once more significantly.


degree_weight._dwpc_disjoint: recurse dwpc call for simplicity

Refs #76
Adds simple functools.lru_cache-ing and a helper DWPC function to make this somewhat more optimized.

I renamed for the mergeable change. Can you remove disk-cache.ipynb


download binary

cant get a valid file (test zip and mp3)
   b2.downloadFileById(fileid).then(function(file){
            // tried   var bitmap = new Buffer(file.data,'base64');
                //fs.writeFile('testload.txt',bitmap)

                   fs.writeFile('testload.mp3',file.data, function(err) {
                        console.log(err);
                });
});

Any idea? thnx

Try tried adding an error function to the then() and let me know what error is being returned like this:
b2.downloadFileById(fileid).then(
   function(file){
      fs.writeFile('testload.mp3',file.data, function(err) {
         console.log(err);
       });
   },
   function(err) {
      console.log('err from b2', err);
   }
);

thnx there is no error (1 bucket with 1 file)

the file is downloaded but double in size
when I do list.files[1].fileId (invalid non excist file) no error

b2.listFileNames({bucketId: data.buckets[0].bucketId}).then(
		function(list)	 {
			b2.downloadFileById(list.files[0].fileId).then(
				function(file){
					  fs.writeFile('testload.mp3',file.data, function(err) {
						 console.log(err);
					   });
			   },
			   function(err) {
				  console.log('err from download b2', err);
			   }
			);
		},
		function(err) {
		 console.log('err from b2', err);
		}
	)

Have reproduced the issue you're having.
Not sure what has changed. I will investigate and make a fix soon. :+1:

@GoNode5 managed to track down the issue.
Seems that for binary data the request module assumes String data. Good news is the fix will be in shortly :+1:

Ah as it turns out I do this in the by filename function but no in the by id function.
:facepalm:

Going to bump the version and publish to npm in the next few minutes :dart:

@GoNode5 v0.9.11 now on npm, thanks for the report and patience :+1:

no problem at all, its now working :-) thnx

Important: need to add 'arraybuffer' as a responseType property to make this work as it should. ```
b2.downloadFileById({
fileId: fileId,
responseType: 'arraybuffer',
...
})


gradle: Allow to specify additional JDKs as Toolchains

Gradle 6.7 introduced the concept of Toolchains.
I think it would be a good idea to parameterize gradleGen adding another argument that takes a list of JDKs that should be registered as toolchains, by adding their paths to org.gradle.java.installations.paths (via an environment variable for the wrapper).

Fixed in https://github.com/NixOS/nixpkgs/pull/119444


cf env appname shows number in scientific format

User provided service with number longer than 10 digits as value gets converted into scientific format when  cf env *appname* is issued.

Reproduction steps :

Create a CUPS :  cf cups longnumbertest -p '{"longNumber":1234567890}'
Bind it to an application
Perform cf env appname
Notice that output shows something similar to :

"user-provided": [
{
"credentials": {
"longNumber": 1.23456789e+09
},
"label": "user-provided",
"name": "longnumbertest",
"syslog_drain_url": "",
"tags": []
}
]

Expectation is that cf env would show number in human readable format ,<PHONE_NUMBER>
Note:  cf curl /v2/apps/appGUID/env shows human readable number format.

CLI Version
cf version 6.21.1+cd086c8-2016-08-18

CC API Endpoint Version
235

There seems to be a related limitation in Golang.
My team tried fixing it but it required changes in code that is used by a lot of commands, and tests started failing after the change.
If it were a simple fix, we'd do it, but as it seems complicated with high risk of introducing regressions, we won't fix it at this time.
We may revisit this at a major version upgrade when the functionality of related commands can be changed.
Cheers,
Dies Koper
CF CLI PM


Cleanup C# profiling code

-- get rid of some no-longer useful profiling points
-- when analyzing async performance, assigning profilers to threadpool threads proved out to be very useful. Setup the building pieces in GrpcThreadPool (but of course no profiling happens by default).

fixed the [i] bug and rebased.


Select mirrord.json as default config choice

Now it there are multiple files in .mirrord folder named *mirrord.json it's not clear which one will be used.
https://github.com/metalbear-co/mirrord-vscode/blob/f8acc3b9d68a06cf701091585afac61623ab3afa/src/config.ts#L205
In my case I have multiple files in that folder one named __mirrord.json, that was being used while I was expecting mirrord.json to be used.
I guess one option is to choose mirrord.json file over others containing mirrord, or document this somewhere.

I think we should restrict the regex to mirrord.{json/yaml/toml} for default config

I guess the only risk there is for people who don't have mirrord.{json/yaml/toml} but something like *mirrord, so for them it will stop working when upgrading.

The plugin sorts default config candidates using String.localeCompare and always picks the first one from the list. We should document it somewhere


Possible optimization

Hey, I just thought about something: the development packages are added to Alpine Linux but not needed to run the app, only to build the gems (right?). Is it possible to optimize this image by removing them after bundle install ?

@sardaukar How much space are the development packages actually using?

Don't know - but it's easy picking in order to slim this image even further, right?

Maybe. Put up a pull request and see? :)

I've made a commit to try and optimize this (https://github.com/sardaukar/alpine-rails/commit/ccdcdc314e8f206f53604d5b619101d9738f0f2a). Is there a quick way to use this container with a Rails codebase? I'm kinda confused as the docker images output for my image shows
slim_alpine_rails   latest              bcdc62ee3397        7 minutes ago       636.8 MB

Thanks for any pointers!


Cannot delete primary wallet

When trying to delete your unlocked wallet it tells you to change wallets to delete.
Is this something that is impossible to do?
Just wondering if there will be cases where people get annoyed about it or something. It's probably ok though.
Small text update for now "You cannot delete your primary wallet. Please create a new wallet or unlock a different wallet and try again.

I think we should not let them delete primary wallet. Will update the text with appropriate error message


help!! NOT AN ISSUE !! The project is build on angular js and the previous developer presented the pdf in iframe.  Is it a good idea?

I'm trying to get the text from the .textlayer class but the iframe on LOAD returns the .textLayer partially completed. I need to highlight the some parts of the text. I wanted to know if pdf find controller will ease the job for me. If some text is found what the controller will return? Can i somehow initialize it on angular js controller from the iframe.

As stated in the other issue, we cannot provide support for Angular-specific issues. The find controller will allow you to highlight parts of the text, but you need to wait until the entire page is loaded.


feat: replace lodash to lodash-es #211

[中文版模板 / Chinese template]
🤔 This is a ...

[x] New feature
[ ] Bug fix
[ ] Site / documentation update
[ ] Demo update
[ ] TypeScript definition update
[ ] Bundle size optimization
[ ] Performance optimization
[ ] Enhancement feature
[ ] Internationalization
[ ] Refactoring
[ ] Code style optimization
[ ] Test Case
[ ] Branch merge
[ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language
Changelog

🇺🇸 English

🇨🇳 Chinese

☑ Self Check before Merge
⚠ Please check all items below before review. ⚠

[x] Follow our Code of Conduct
[x] Read the Contributing Guidelines
[x] Read the docs
[x] Doc is updated/provided or not needed
[x] Demo is updated/provided or not needed
[x] TypeScript definition is updated/provided or not needed
[x] Changelog is provided or not needed

@XiaoDaiGua-Ray CI 挂了

似乎会影响到 GitHub 的 CI， 我先自己看一下哈 @XiaoDaiGua-Ray

@NelsonYong 好的，有需要配合，可以通知一下。


PermissionChecker fails to analyze some APKs

Hi there -- I have a handful of APK files that generate errors and cannot be analyzed due to issues with PermissionChecker.jar. For example, this app here:
https://play.google.com/store/apps/details?id=com.angelcam
generates the following message when passed to PermissionChecker.jar in RiskInDroid.py:get_permission_json:
# java -jar PermissionChecker.jar com.angelcam_20401_apps.evozi.com.apk
PermissionChecker failed to analyze the application!

I'm running everything from within the docker container.  I can give more detail (or a copy of the APK I'm using) if needed.  You mention that PermissionChecker.jar is owned by Talos; is this fixable? Thanks in advance.

Hi @lnarmour, thanks for your interest in this project. The code of the permission checker is from 4 years ago and technology evolves fast, so I'm not surprised to see some errors with the newer apps. I'll investigate the error caused by that app and I'll let you know if it's something easily fixable (I hope to fix the error by just updating some dependencies 😅).

Latest commit 568072b73cd687a8509fc6de396693078e0ce4e1 should solve the issue, let me know if you still have errors.

Great! It looks good from my end, and now works on all the other APKs I was interested in too. Thanks much for you speedy help!


Base Goerli Support on SDK

Is it possible to get Base Goerli support in the SDK library? I see that a subgraph is available here so that data should be available if assume correctly?

Yes, can get that added for you soon. Will let you know when it's available.

Ok @blobitty this is available on the latest release (3.2.3). Let us know if you are having any issues with it.


restore handling of packageTag CLI flags for publish

Fixes #808
This does the following:

Pulls the additionalTags() discovery out of the buildImage section
Has buildImage() report back on all installed packages, which is a good artifact relevant to build stage: "I built this image for this arch, here are the packages I installed"
Runs through those packages by arch, and checks that the versions are identical, per this comment, else error
Use those now-verified-as-identical tags for the additional tags

In doing so, it also moved some funcs that used to just rely on passing build.Context.Options and knowing what they were, to explicit vars. This makes the signature a bit longer, but easier to understand, and no longer dependent on some build context that isn't relevant to that func. I think there is a minimal amount of this after Jon Johnson's restructure last week.

@deitch Looking pretty good. I'm testing it with git and ruby-3.2 packages.
$ apko publish --debug --package-version-tag=ruby-3.2 --package-version-tag-stem ./images/ruby/3.2-dev.apko.yaml localhost:5000/ruby:latest

❕           | Found version, images will be tagged with 3.2.2-r1
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/ruby:3.2.2-r1 localhost:5000/ruby:3.2.2 localhost:5000/ruby:3.2 localhost:5000/ruby:3]
❕           | Found version, images will be tagged with 3.2.2-r1
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/ruby:3.2.2-r1 localhost:5000/ruby:3.2.2 localhost:5000/ruby:3.2 localhost:5000/ruby:3]

$ apko publish --debug --package-version-tag=git --package-version-tag-stem  ./images/git/latest-root.apko.yaml localhost:5000/git:latest

❕           | Found version, images will be tagged with 2.41.0-r0
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/git:2.41.0-r0 localhost:5000/git:2.41.0 localhost:5000/git:2.41 localhost:5000/git:2]
❕           | Found version, images will be tagged with 2.41.0-r0
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/git:2.41.0-r0 localhost:5000/git:2.41.0 localhost:5000/git:2.41 localhost:5000/git:2]

The only remaining issue, which was not mentioned in the original report in #808, is when --tag-suffix is specified. ex:
# --tag-suffix -dev

❕           | Found version, images will be tagged with 3.2.2-r1-dev
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/ruby:3.2.2-r1-dev localhost:5000/ruby:3.2.2-r1 localhost:5000/ruby:3.2 localhost:5000/ruby:3]
❕           | Found version, images will be tagged with 3.2.2-r1-dev
❕           | Adding stemmed version tags
ℹ            | Returning additional tags [localhost:5000/ruby:3.2.2-r1-dev localhost:5000/ruby:3.2.2-r1 localhost:5000/ruby:3.2 localhost:5000/ruby:3]

I have a PR that should fix this in #810 . The fix is fairly simple in just a few lines by moving the appending of tagSuffix to the end of the package stemming logic. It could be added to this PR or #810 could be rebased after this merges.

@joemiller thanks for that. I worked your updates from #810 into this PR, so it should do all you need. Thank you indeed for that, and especially the clear tests.


[Extra] Use name convention (issue) and the same labels across repos

This is not something to put in style guide, but it is something I want to do 😄
See, and create one set:

https://github.com/furdzik/IF.Kamisama/labels
https://github.com/furdzik/IF.Portfolio/labels
https://github.com/furdzik/IF.Japanese/labels
https://github.com/furdzik/IF.Frontend/labels
https://github.com/furdzik/IF.Frontend.JobInterview/labels
https://github.com/furdzik/IF.CSSArt/labels
https://github.com/furdzik/IF.MasterThesisApp/labels

[PROPOSITION]
GENERAL REPOS:

DOCS REPOS:

[PROPOSITION]
###LABELS NAMES

@TODO: Public recommendation in README as Extras

[CONSIDER]

renaming problem to: issue or bug

[PROPOSITION]

Always use one way of creating: propositions, recommendations, things to consider

**[PROPOSITION / RECOMMENDATION / CONSIDER / TODO *]**

Message

/* Choose only one

[TODO]
Public recommendation in README as Extras


Added full-version endpoint

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[ ] Yes
[*] No, because: It's an optionnal usage but useful for strong administration

Have you updated all relevant documentation?

[ ] Yes
[x] No

Description
I added an endpoint to get more details about libraries' versions.
Maybe you prefer to merge into the /version endpoint ?
Or put more or less informations ?
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[x] No : I don't see examples of tests for the API

@ZuluPro It appears your fork or branch is not set up to allow maintainers to make changes, so I cannot merge main in to update the branch, and thus cannot merge the PR

@ZuluPro Yep! Merged.


Token Mismatch when I try to upload a video file

I get the following when I try to save a video file: TokenMismatchException in VerifyCsrfToken.php line 68:
in VerifyCsrfToken.php line 68
at VerifyCsrfToken->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in ShareErrorsFromSession.php line 49
at ShareErrorsFromSession->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in StartSession.php line 64
at StartSession->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Router.php line 561
at Router->runRouteWithinStack(object(Route), object(Request)) in Router.php line 520
at Router->dispatchToRoute(object(Request)) in Router.php line 498
at Router->dispatch(object(Request)) in Kernel.php line 174
at Kernel->Illuminate\Foundation\Http{closure}(object(Request)) in Pipeline.php line 30
at Pipeline->Illuminate\Routing{closure}(object(Request)) in Debugbar.php line 51
at Debugbar->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in CheckForMaintenanceMode.php line 46
at CheckForMaintenanceMode->handle(object(Request), object(Closure)) in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request)) in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request)) in Pipeline.php line 102
at Pipeline->then(object(Closure)) in Kernel.php line 149
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 116
at Kernel->handle(object(Request)) in index.php line 53

That generally means you have not loaded a field for TokenMismatch. Without seeing code it is hard to see but there are various options. Add it to the form you are submitting itself or in header/script.
https://laravel.com/docs/5.4/csrf

How long did it take to upload it?
How big was the video?

The file is 25 MB and it is a .wmv video file. The file upload reaches about 89% and then the error message is shown. It took about 3 seconds from the upload button being pressed to the error page.

The following is my Model:
delete($obj->video);
        	});
    	}

		/**************************************************
		 * Relations
		 **************************************************/
		public function course() {
			return $this->belongsTo('App\Models\Course', 'course_id');
		}

		public function lesson_position() {
			return $this->belongsTo('App\Models\LessonPosition', 'lesson_position_id');
		}

		/**************************************************
		 * Scopes
		 **************************************************/

		/**************************************************
		 * Accessors
		 **************************************************/

		/**************************************************
		 * Mutators
		 **************************************************/
		public function setImageAttribute($value) {
	        $attribute_name = "video";
	        $disk = "uploads";
	        $destination_path = "course/lesson";

	        // if the image was erased
	        if ($value == null) {
	            // delete the image from disk
	            \Storage::disk($disk)->delete($this->video);

	            // set null in the database column
	            $this->attributes[$attribute_name] = null;
	        }
    	}
	}

The following are the fields in my CRUD Controller:
`$this->crud->addField([
'name' => 'title',
'label' => 'Title',
'type' => 'text',
]);
        $this->crud->addField([
            'name' => 'description',
            'label' => 'Description',
            'type' => 'text',
        ]);

        $this->crud->addField([
            'name' => 'video',
            'label' => 'Video',
            'type' => 'upload',
            'upload' => true,
            'disk' => 'uploads' // if you store files in the /public folder, please ommit this; if you store them in /storage or S3, please specify it;
        ]);

        $this->crud->addField([
            'label' => 'Course',
            'type' => 'select',
            'name' => 'course_id',
            'entity' => 'course',
            'attribute' => 'title',
            'model' => "App\Models\Course",
        ]);

        $this->crud->addField([
            'label' => 'Lesson Position',
            'type' => 'select',
            'name' => 'lesson_position_id',
            'entity' => 'lesson_position',
            'attribute' => 'name',
            'model' => "App\Models\LessonPosition",
        ]);`

Wondering if the "setImageAttribute" mutator function is the issue? I am using it to upload an image using the "image" type which works but using the "upload" type for the video file.

The PHP post_max_size variable was set to 2MB and the reason the issue was happening. I changed it to 100MB and the upload went through.

I had the same issue when changing sessions from "file" to "database". with "file" - no issue


Hover only interactions no longer work

Describe the bug
It seems that any hover only interaction is broken.
To Reproduce
Non of the following examples work any more.
Label::new("my label")
        .selectable(false)
        .ui(ui)
        .on_hover_text("tooltip");

let response = Label::new("my label").selectable(false).ui(ui);
response.interact(Sense::hover()).on_hover_text("tooltip");

let response = Label::new("my label").selectable(false).ui(ui);
ui.interact(response.rect, ui.next_auto_id(), Sense::hover())
        .on_hover_text("tooltip");

The tooltip is never shown.
Expected behavior
Tooltip should be shown when hovering with the cursor on the labels.
Platform:

OS: Windows 10
Version 22H2

Additional context
I tried 0.27 and master.
Note that this was working fine on 0.26.

Reproducible in the demo app as well. If you open the settings and tick off "Selectable text in labels", you can no longer see the tooltips for the settings just above it. Also the progress bar in the widget gallery no longer displays an animation when you hover it.

Temporarily until corrected,
Useable Sense::click() or Sense::click_and_drag().

Yes, this works as long as you do not have a widget, with a clickable area and a hoverable area inside of that clickable area (which is what I have unfortunately).


Advanced Customizable Background

I would like to make a fun countdown timer. Say, I could specific a picture of my favorite basketball player as the background image, and resize/reposition the timer to make the whole screen looks like he is playing a timer-alike ball.

[ ] Background Image. The position should only be center / center and no-repeat.
[ ] offset of the timer (x, y)
[ ] scale of the timer (x px)

Needs UI


ToggleButtons Widget optionally extend down vertically

Hey, Flutter development community. I want to make a suggestion about the ToggleButtons widget. The ToggleButtons widget is quite intuitive but lacks feasibility in some use-cases. My proposal is to add the option for the ToggleButtons widget not only to work horizontally but also vertically so it would stack down after there's no room left horizontally.
Here is my use case:

So ToggleButtons would work to an extent with this if it was only one row, not two.

CC @shihaohong

I continue this work now, the previous PR #63880 has been closed without merge.


Github actions

PR checking
cron task for tokenlist.json auto-generation

implemented by #6 #7 #8 #9


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: e74118f69a652b20844e27f4ddac301de0137c72
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: d92ac18db1dffb4e6720ef1f183886afd74dd1cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Small screen width distorts view

Window needs to be at least 1200 pixels to properly view components

Thanks - this is really helpful documentation of exactly where the problem happens. I'll take a look at fixing this stuff.


fix(v-model): fix the lazy modifier is not reset by other modifications

fixed #8546
fixed #6564
We should not block the update if the currently bound value is updated, In this PR, the value of the current element will only be reset if the value of the v-model bound to the current element is modified, since I can't simulate the focus event in jsdom, I can't write a test case for it.

/ecosystem-ci run

The error of ecoystem-ci confuses me, it seems to have nothing to do with this PR.


chore(release): 27.0.0-next.11

Pull Request Test Coverage Report for Build 751555657

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.951%

Totals

Change from base Build 750932569:
0.0%

Covered Lines:
1000

Relevant Lines:
1030

💛  - Coveralls


chore(main): release 1.2.1

:robot: I have created a release beep boop
1.2.1 (2024-10-26)
Bug Fixes

chembl and file inputs (499b298)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/socialgene/sgnf/releases/tag/v1.2.1 :sunflower:


Is there any rollback plan in case of Solution Import failure

Hi,
We are utilizing this extension for solution import in dynamics 365 and we have come to a point where there were some import failures and we wanted to revert the instance to the previous healthy state.
Is there any rollback plan available in such scenarios?

@rupalibolke  normally if the solution imports fail the import operation rolls back. It is a good practice to backup your CRM environment anyway before releases, you can use the tasks provided by this framework to backup/restore CRM Online Environments.


localising headers

Hello,
first I would like to thank you for your package, as I find it very useful and a nice addition.
I would like to ask you what would be the best way to 'localize' the header in French. I am trying to print in French : "Notes des pages m à n" and have used the following code:
\usepackage{postnotes}
\ExplSyntaxOn
\NewDocumentCommand \pnheaderdefault {}
{
\tl_if_eq:NNTF \pnhdpagefirst \pnhdpagelast
{ Notes~de~la~page~ \pnhdpagefirst }
{ Notes~des~pages~ \pnhdpagefirst -- \pnhdpagelast }
}
\ExplSyntaxOff
\postnotesetup{
heading={
\section*{\pntitle}
\markright{\pnheaderdefault}
\addcontentsline{toc}{section}{\pntitle}
} ,
}
But all I get printed in the header is : "Note des pages", without the page numbers.
What am I missing ?
Many thanks for you r help.
With best regards.

Yes the French strings you are proposing are adequate values !

I've just added French localization support, which will be part of the next release.
Thank you!

Thank you very much !
Regards

Le 25 avr. 2022 à 17:46, Gustavo Barros @.***> a écrit :
Yes the French strings you are proposing are adequate values !
I've just added French localization support, which will be part of the next release.
Thank you!
—
Reply to this email directly, view it on GitHub https://github.com/gusbrs/postnotes/issues/1#issuecomment-1108743161, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADPJTNF6OUO4HKWR7UJN6SDVG243ZANCNFSM5UIRN6QQ.
You are receiving this because you authored the thread.


stream_push file descriptor leak

somewhere in the luajit popen is not freeing up resources. end result is io.popen runs out of descriptors and returns nil / refuses to execute

This is a long running issue with luajit seen it many times, but need to resolve it now or find a workaround

running this long term (weeks at a time) and cant seem to reproduce the problem. not sure where the true bug is. f20v1 system was running for  1 week+ on a dedicated test to create the file handle leaks but to noavail.
need to think more on what could cause this

Push V1 has been depreciated, closing


Move PPM/PFM I/O functions to Auxiliary

The PPM/PFM functionality is currently part of the texconv tool. I don't believe it's an important format to support as part of the mainline library, but it could be moved to the Auxiliary folder instead of being side-by-side with texconv

The auxiliary idea is problematic, so I think it would better to just make PPM/PFM a primary library module.


Error when calling QueryDocumentSnapshot.data() for GeoPoint 0, 0

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Operating System version: Ubuntu 16.04 x64
Firebase SDK version: 5.13??
Library version: 5.13??
Firebase Product: firestore

[REQUIRED] Step 3: Describe the problem
Receiving error from Firebase Functions
Error: Argument "latitude" is not a valid number.
at Object.exports.(anonymous function) [as isNumber] (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/validate.js:89:23)
at new GeoPoint (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/document.js:84:18)
at Function.fromProto (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/document.js:143:16)
at QueryDocumentSnapshot._decodeValue (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/document.js:518:33)
at QueryDocumentSnapshot.data (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/document.js:401:34)
at QueryDocumentSnapshot.data (/user_code/node_modules/firebase-admin/node_modules/@google-cloud/firestore/build/src/document.js:782:26)
at exports.handle (/user_code/lib/triggers/SosNotification.js:7:21)
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
I'm not sure if my assumptions are correct,  but the error I am encountering comes from calling QueryDocumentSnapshot.data() for a document reference w/c has a GeoPoint(0, 0) value. I have confirmed that @google-cloud/firestore library allows creating this kind of GeoPoint

Relevant Code:
Just create a document with a field location: new admin.firestore.GeoPoint(0,0).
then fetch that document. you will get this error when you call snapshot.data() function in the then() function
// TODO(you): code here to reproduce the problem

That was quick! Thanks guys!


[github] Make issue templates version agnostic

Can't we remove this checkbox now? I haven't seen a v0.x for weeks.

That checkbox is why you haven't seen it! 😆

@mbrookes It's possible yes, unless people don't even read the template 😆.


style: forbid url do blocks in homebrew/cask

Follow-up to https://github.com/Homebrew/brew/pull/18390
This PR adds a rubocop check that forbids the use of url do blocks in homebrew/cask. It still allows them to be used in non-official taps. There's a little bit more discussion/context in the PR linked above, but basically these blocks require us to make network calls every time we generate the API data. It's very common for the API generation to fail because one of these URL blocks has an issue, and really the generation should be able to happen offline.
This will need to wait for https://github.com/Homebrew/homebrew-cask/pull/186501 to be merged
CC: @Homebrew/cask

As a follow-up: I do think it's worth odeprecateing this functionality. It's both pretty niche and very likely to start breaking in future if we're not using it ourselves in any official taps.

To be explicit: this would ideally be a follow-up PR before we release Homebrew 4.4.0 but after this PR is merged.

As a follow-up: I do think it's worth odeprecateing this functionality. It's both pretty niche and very likely to start breaking in future if we're not using it ourselves in any official taps.

Opened https://github.com/Homebrew/brew/pull/18407 to attempt this.

As a follow-up: I do think it's worth odeprecateing this functionality. It's both pretty niche and very likely to start breaking in future if we're not using it ourselves in any official taps.

I agree with the point about it being untested. Though equally I don't want taps to be encouraged to start doing network requests on cask-load like I've seen third-party formulae do.
I'm overall neutral, though if we do deprecate would suggest very clear messaging in what the replacement is.

Though equally I don't want taps to be encouraged to start doing network requests on cask-load like I've seen way too many third-party formulae do.

Those same taps will just end up complaining when we inevitably break this functionality because we don't use it ourselves. I'm not terribly worried about doing network requests on cask-load given this is not entirely dissimilar.

though if we do deprecate would suggest very clear messaging in what the replacement is.

Will happily take suggestions for what this messaging should be. As far as I can tell: there is no real replacement here.


Add coveralls

Outstanding issues:

coverage can't find the .coveragerc so I have to manually copy it into the directory the tests are run in
it is only happy if I do the editable install (i.e. pip install -e . as opposed to pip install .)

If we don't change directory to not_the_source_root and stay in the initial directory, that includes the .coveragerc file, then pytest-cov picks up the coveragerc file correctly.
I tested using the --cov-config command line argument but it didn't work
I am unable to get around the problem that occurs when installing a non-dev version
i.e. pip install -e . works but pip install . doesn't


feature: add mute functionality

Also fix format errors and add XO as linter

I know it's huge, but I'll try my best to explain if necessary. Good luck!
Best,
G.

After this one, I'm planning to work on a CI tool such as Travis, and avoiding display to turn off. I checked night shift, but I couldn't find a way other than opening the system preferences and changing it.
And I know some people who are waiting for the mute functionality. No pressure, just saying.
Best,
G.

Hi @gokaygurcan
Nice contribution. Thanks to added a lint to the project. It's important :)
About the mute functionality. I think you can use the mute instead of volume 0.  That way we preserve the user volume without the need to reset to 100 after toggle pliim.
set volume with output muted
set volume without output muted

What do you think? Can you make this change?

Hey @zehfernandes,
It's even better, pushing in a minute.

Thanks @gokaygurcan 🎉
I merged with master and committed a new label for Mute https://github.com/zehfernandes/pliim/commit/8d6b7a97a3eb4e8d86486f5e5c8374b7d131e7fa

Hooraay!


Features/example art techpack

This updates the example level with a new theme, updated splash level and updated example level. Tried to do a better job of showing off the engine features, and drawing attention to their use.

Is there supposed to be a dialogue trigger here?

These tiles aren't animating.

Is there supposed to be a dialogue trigger here?

Maybe I should rename that to 'Message Trigger' instead of 'Dialogue Trigger'

Updated the level with some more Triggers, making the 'Dialog Trigger' area a more general 'Triggers' area


chore/Add infrastructure document id support

Resolves: https://linear.app/prefect/issue/PLA-442/deployments-support-infrastructure-document-id
Adds support and tests for infrastructure_document_ids in deployment specs
I believe that the k8s job block is about as simple as I can make an infra block to pull the id from but happy for suggestions

Closing as this field has been deprecated.

@jimid27 - do you happen to know if there's a timeline for this field to be removed entirely? If it's not particularly soon, I'm open to still merging this. In certain cases it could make it easier for folks to adopt the Terraform provider.
cc @parkedwards

It sounds like Cloud still supports this for previous versions of Prefect being used but it is all but removed in OSS per Jake


api: Add GET /users/{email} api endpoint.

This adds GET /users/{email} api endpoint that returns data on a user just as GET /users/{user_id}.

@orientor This is ready for a review.

Once the changes are approved, I'll add documentation as well.

@akashaviator Thanks for working on this. This set of changes(without the documentation) LGTM.

@timabbott I've updated the PR. Can you have a look ?


getRouterParams(event) is always empty in nitro middlewares

Environment
nuxt@latest
Reproduction
https://stackblitz.com/edit/github-fxp3q3?file=middleware%2Fexample.js
Describe the bug
const params = getRouterParams(event)
is always empty in nitro middlewares
Additional context
No response
Logs
No response

To me, this behavior makes sense as the middleware runs before the route handlers, meaning that the middleware might not have any knowledge about possible router params.

@manniL I'm not sure, in theory I agree, but we do have access to the URL, even the nuxt example is:
export default defineEventHandler((event) => {
  console.log('New request: ' + getRequestURL(event))
})

I have a lot of use cases where if I have [_book_id] in the URL I want to make sure the user has access to the the book, the middleware would be a perfect place to do this, so I can be sure any route which has [_book_id] is automatically validated.
If you do have access to the URL, you should have also access to the params, no?

Access to the URL makes totally sense, but as middleware is triggered before any router matching logic happens (AFAIK), the event is not aware of any route parameters yet (when using global middleware)

So would there be a problem if the middleware was given knowledge of the URL that made it to run, and of course the previous one?

Access to the URL makes totally sense, but as middleware is triggered before any router matching logic happens (AFAIK), the event is not aware of any route parameters yet (when using global middleware)

The middleware already knows the URL of the request :)

@manniL Should this be resolved, and router params are able to be read from the event parameter in nitro middlewares, would it impose any security vulnerability?

Any updates?


resolve aliases before checking for terminal quick fixes

We could read all the aliases in our shell integration scripts and send that to VS Code
For all selectors that include a commandMatcher, we could resolve the aliases of the commandLine before running the match

work started here https://github.com/microsoft/vscode/pull/166326/commits/fbf71d876db935f2991e8144e96e5de7f7926985
ran into an issue w zsh where the alias string was too long to send via a command

I haven't seen any requests for this, so closing.


Fix the devtools build and add a test

After the last uberenv update, we can no longer build the devtools via spack. We should fix this and add a test to make sure this doesn't happen again.

This has been fixed but still needs a test so we dont regress.


RwProjectDefinition>>packageNamesInLoadOrder: and RwProjectDefinition>>addPackageNamed: need to be reconciled

packageNamesInLoadOrder and addPackageNamed: needs to be kept in sync ... adding a new package that is not in packageNamesInLoadOrder might throw an error or might be automatically added to the list ...

[ ] verify that the package ivs in specs are no longer used (except for Rowan)
[ ] a test or two verifying loaded packages used for write and repo packages used for read --- exclusively
[ ] use configs when loading .... and track loaded config along with SHA of rep

loadedPackageNames in loadedPackageNames not used (no senders of accessor methods) - still need to remove the methods and instance variables.
RwPackageProjectSpecification:  packageNames packageNamesInLoadOrder packageNamesToLoad; all need to be removed and have senders ripped out ... then tests need to be run ...

Configurations are used for load specification and loaded packages are used for writing ... we're done


feat: video streaming

What does this PR change?
Closes https://github.com/decentraland/unity-renderer/issues/413
How to test the changes?
TBD
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Superseed by #40


[RFR] Wrapped parsing in DOMContentLoaded

Because the DOM queries were performed outside of a DOMContentLoaded event, it made it impossible to include a11y-toggle in the <head> of a page. This PR intends to fix that.

LGTM


Create LICENSE

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (b2b7114) compared to base (b2b7114).
Patch has no changes to coverable lines.

:exclamation: Current head b2b7114 differs from pull request most recent head 1414887. Consider uploading reports for the commit 1414887 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.0.6        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           47        47
  Branches         7         7
=========================================
  Hits            47        47

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix non existing transaction error

While updating the cli to run compute jobs on multiple assets, found this issue:

the logic from this PR would also help by logging the error for each time a send tx will fail https://github.com/oceanprotocol/ocean.js/pull/1785/files#diff-7088cad71f76b13886ab4bb0d5358cdd62a6be1d92e775eb54d7c0a627a97d3cR161-L154


Share some data with a secret test tool by Nyholm

Im currently developing a new tool. Could I start collecting some data from our builds?
It is no big secret but I've got nothing to show yet...

Thank you for merging.

On 5 Dec 2017, at 10:06, David Buchmann<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Merged #237 https://github.com/php-http/HttplugBundle/pull/237.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/php-http/HttplugBundle/pull/237#event-1372184372, or mute the thread https://github.com/notifications/unsubscribe-auth/ABN1RgAQLszTmWVP75o3Qi0hLxbTha0Hks5s9QergaJpZM4Q1aV4.
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png https://github.com/php-http/HttplugBundle https://github.com/php-http/HttplugBundle/pull/237#event-1372184372


Community chat

Will it be possible for you to join a community chat so that we can discuss and help each other?
Gitter or a channel in the Tailwind Discord would be great.
Right now, if we get stuck there is no place to ask for help. and these problem do not fit the Github issues template.

@rishavs I doing my best to answer GitHub issues as soon as possible and almost half of issues are not actual bugs. Issues can be bug reports, feature requests or just asking for help on a specific project setup.
Discord and Gitter are good tools but those places need someone to constantly communicate with people and will take a lot of my time.
Feel free to open issues if you need help with something and me or one of the contributors will help.
Also, GitHub has a "discussions" section. That might be useful too.


Add Lua embedding

Description
This adds a minimal Lua interface for interacting with a store. The motivating example transferring data by exercising FastSlowStore::has_with_results().
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?
local store = get_store("CAS_MAIN_STORE")
local key = storekey("2cf24dba5fb0a30e26e83b2ac5b9e29e1b161e5c1fa7425e73043362938b9824", 5)
print(store:has(key))

Checklist

[ ] Updated documentation if needed
[ ] Tests added/amended
[ ] bazel test //...  passes locally
[x] PR is contained in a single commit, using git amend see some docs

This change is

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Fixed the Bazel build by dropping the vendored feature from the mlua dependency and plumbing a bazel_dep. However, building with nix or cargo requires additional work.

Closing this draft in favour of a WebAssembly component embedding. The exploration of API shape was informative.

@barrbrain could you reference this PR in the WebAssembly component embedding?


New message when grammar file not found #2461

Signed-off-by: Robert D Anderson<EMAIL_ADDRESS>Implements #2461 (also reported as #2475 and reported in Slack today in relation to #3123) by adding new message to distinguish between "file not found" conditions. Currently, if any file cannot be found, we report the file we're trying to read (usually a DITA map or topic) and state that it cannot be found or loaded. If the DTD/Schema is missing, the FileNotFoundException actually applies to that grammar file, but we only report the source file. If the file exists but we receive the FileNotFound condition, then most likely it's a grammar file that was not found, so we should modify the message accordingly.
Old behavior:

If the file cannot be parsed (because the file contents are not valid against the grammar, or because the grammar file itself cannot be parsed), there is a SaxParseException that reports the correct file (source or grammar) along with the parsing error
Otherwise if any file could not be found, catch FileNotFoundException and report the source file that could not be used. If it's the input file end with fatal "Input file could not be located or read, ensure it exists and you have permission", otherwise use an Error "File could not be located or read"

New behavior:

If the file cannot be parsed (because the file contents are not valid against the grammar, or because the grammar file itself cannot be parsed), there is a SaxParseException that reports the correct file (source or grammar) along with the parsing error
If we get the FileNotFoundException for the input file, but the input file really does exist, use a new fatal message "Input file XYZ could not be loaded" and point to the grammar file as the response; after that message include the actual exception text that states what file could not be found, such as map.dtd
If we get the FileNotFoundException for any other file that really does exist, use a new error "File XYZ cannot be loaded" and point to the grammar file as the cause; after that message include the actual exception text that states what file could not be found, such as my-topic.dtd
Otherwise treat the FileNotFoundException as we do today

👍 We periodically have end users who forget to properly integrate their specialization plugins and encounter this problem.


Errors thrown in tests produce log messages even with console is stubbed out.

https://github.com/edx/paragon/pull/153 this PR introduces some errors that get thrown in the Modal when an invalid prop is passed in. A test was added to test that error functionality, but it clutters the logs (despite all tests passing), this could be cleaned up hopefully.

Closing this issue as the Modal component is deprecated and will soon be removed.


fix: avoid voting for the same trigger multiple times

Issue being fixed or feature implemented
We just had a sb voting period and I noticed that the network is way too spammy and produces too many votes (10x+ the expected numbers). It turns out that relying on ProcessVoteAndRelay on mainnet is not enough because rate-check expires too soon and MNs are able to vote again and again. On testnet it was never an issue because the voting period there is really short.
What was done?
Check known votes to make sure we never voted earlier.
How Has This Been Tested?
Run tests, run a MN on mainnet and check logs.
Breaking Changes
n/a
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

because rate-check expires too soon

why not increase this timeout?

ping @knst


Question: Passing handle to factory class

Using the Dog example, I want to pass a database handle (db) to either class Dog or PooledDogFactory(PooledObjectFactory) to create the pool object from storage. How can this be achieved?

You can refer to the documentation by first declaring a Factory class for the database connection object, which is created and returned in the createInstance function of this class.
For database connection objects it is recommended to set time_between_eviction_runs to -1 to disable auto-recovery, which extends the time set in time_between_eviction_runs.

A bit more detail. I have a fastapi startup function:
def app_startup()():
	dao = blahblah() #creates a database connection

I now want to pass the db connection to pond to create an object pool and on success return to app_startup(). How to achieve this?

There's no way to do that at the moment, so I recommend defining the initialization of the database connection object in the createInstance function of the class that implements PooledObjectFactory.
You should use an object pool to manage object creation and destruction.
When a custom Factory class is registered with Pond, Pond automatically uses the custom Factory class's createInstance function to automatically create objects until the maximum number of object pools is reached.

Is it possible to pass the dao like this?
class PooledDogFactory(PooledObjectFactory):
    def __init__(self, dao): -> None
        self.dao = dao

If so, then the next step is to get the createInstance function and the Dog class to use the dao.

class PooledDogFactory(PooledObjectFactory):
    def createInstance(self) -> PooledObject:
        database_connection = create_database_connection()
        return PooledObject(database_connection)

    def destroy(self, pooled_object: PooledObject):
        pooled_object.keeped_object.close()
        del pooled_object

    def reset(self, pooled_object: PooledObject) -> PooledObject:
        pooled_object.keeped_object.re_connect()
        return pooled_object

    def validate(self, pooled_object: PooledObject) -> bool:
        return pooled_object.keeped_object.is_connect()

You should not initialize the database connection object externally, but in the Factory class.

Ok thank-you for your patience :)


SodiumException    secretkey should be SODIUM_CRYPTO_SIGN_SECRETKEYBYTES bytes

Trying to generate the secret key from the keypair and I get the above exception:
See my code below
       if(file_exists($keypair)) {
            $keypair = file_get_contents($keypair, FALSE, NULL);

            dd(Keypair::fromSecretKey($keypair));
        }

After running this, I get that sodium exception.

Got it, needed to pass in the $keypair as an array and thus only needed to json_decode() my keypair


refactor: split rules in multiple files

Split rules into a better organized module.
Ideally, I'd like to create a Rules Engine that include some default rules but also were a user can disable rules or create his own rules.
This is just a first step.

Codecov Report

Merging #61 (5ad767a) into main (41583f1) will increase coverage by 0.13%.
The diff coverage is 92.37%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   95.69%   95.83%   +0.13%
==========================================
  Files           9       15       +6
  Lines         465      480      +15
==========================================
+ Hits          445      460      +15
  Misses         20       20

Impacted Files
Coverage Δ

simplemma/rules/fi.py
80.00% <80.00%> (ø)

simplemma/rules/pl.py
80.00% <80.00%> (ø)

simplemma/rules/ru.py
86.66% <86.66%> (ø)

simplemma/rules/nl.py
91.66% <91.66%> (ø)

simplemma/rules/en.py
92.30% <92.30%> (ø)

simplemma/rules/de.py
97.82% <97.82%> (ø)

simplemma/lemmatizer.py
98.01% <100.00%> (ø)

simplemma/rules/__init__.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Tint color?

Since iOS7 it's possible to set the tint color of views.
Is it possible to define the global tint color and of certain views?

You can set global tint color programatically with [[UIApplication sharedApplication] keyWindow].tintColor = [Color redColor]
Unfortunately, there's no way to load a specific color from the stylesheet, but you could add a class
ThemeColors {
    tint-color: #FF0000;
}

Then use ``[[UIApplication sharedApplication] keyWindow].tintColor = [NUISettings getColor:@"tint-color" withClass:@"ThemeColors"]`

Duplicate of #223.


Expose the Impossible constraint in ByOtherNames.Constraint

Currently it's private.
Useful when defining functions for enum-like types.
Maybe call it Never.

Added in df294aaed899d8cc918e880615f1f7d8c49bde6d.


My Tasks is not showing all tasks assigned to me

in the Not Investigated session i see Nothing to do! when in fact i should have.
see screenshots below:

and on master:

@k0machi

@k0machi , any progress with this issue?

It's fixed as part of PR #174, I could see if it's cherry pickable to the current master branch.

if if will be ready to work soon, then don't bother to cherry pick it, but if it will take some extra few days, please try to apply to current server, please.

Closing as this is now fixed in #174


Charts, Streams and Latency not working in Dashboard

Using Mac, I am not getting Charts.  My selection window for selecting ports is a little different, I am not sure if that is the issue.

Notice that ports is working.  It could be something I am doing incorrectly.

Hi @dlohin ,
Charts(and Stream tables on the 2nd tab) are only displayed for streams, which have PG ID. On your screenshots you have no streams available for charts. Just add PG IDs and you will see charts.
Please check following screenshots:

Added a note to the wiki as well.
Feel free to reopen the issue if you have any problems.


No case for mechs when calculating armory points

ArmouryUtility.GetColonistArmouryPoints does not have a case for colony mechs.
Vanilla uses:
else if (p.IsColonyMech && !p.Downed)
            a = p.kindDef.combatPower * StorytellerUtility.PointsFactorForColonyMechsCurve.Evaluate(wealthForStoryteller);

With the curve ranging from 0.2 to 0.4. Or, put another way, 2-5x as much as animals.
Recommend adding a case for mechs, and a configuration option for mechs.

Thanks, should be added in 67f2446