Add a round_float validator

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
We have a couple of use cases in our code base where we have a pydantic model with a float field, which we want to be rounded. We have an implementation that looks something like:
from pydantic import BaseModel, field_validator

class MyModel(BaseModel):

    my_field: float

    @field_validator("my_field")
    @classmethod
    def round_float(cls, v: float) -> float:
        """Round floats to 2 decimal places."""
        return round(v, 2)

This is okay but we need to repeat the validator on each model which becomes annoying. We then came up with:
from typing import Callable, Annotated

from pydantic import AfterValidator, BaseModel

def round_float(round_to: int) -> Callable:
    def inner_round(v: float):
        return round(v, round_to)

    return inner_round

class MyModel(BaseModel):

    my_field: Annotated[float, AfterValidator(round_float(2))]

Which works well, however again we still need to have this boiler plate in our code, both defining the function and adding an after validator to each field. It would be amazing if this could be done within pydantic itself.. We noticed that there is the decimal_places option in fields however this only seems to be useable for Decimal instances. Would it be possible to:

Support floats with the decimal_places argument
Add a new API for rounding floats?

I imagine for 2 it would look like:
from pydantic import Field, BaseModel

class MyModel(BaseModel):

    my_field: float = Field(round_places=2)

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[X] Field Types - adding or changing a particular data type
[X] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

These both seem like reasonable feature requests, and I believe they'll require some work in pydantic-core! PRs welcome :).

Hi, I'd like to contribute on this issue (as my first contribution). Still trying to understand the whole architecture of the pydantic project.
Is there some documentation or examples I could follow to create a new validator?

@yfalomir,
Awesome! Hmm, yeah we'll have to decide on exactly what we want the API to look like regarding the rounding behavior.
Before we do that, @Zac-HD, do you think there's any place for some sort of rounding annotation in annotated-types? If not, we can implement a solution purely in pydantic, but wanted to get your feedback first :).

Let's start with just Pydantic, and then we can move it to annotated-types if there's wider demand for it and consensus on the semantics 🙂

How do you want to proceed about deciding what the API should look like?
Maybe I can make propositions if you point me to relevant chunks of codes to compare the issue with.

@yfalomir,
Ah, apologies for the delay, this notification got buried in my email. Why don't we start with an implementation that uses Python's round function (for simplicity, and also then the rounding behavior isn't dependent upon custom logic). What do you think about round_to as the setting name (takes an int)? I wouldn't worry too much about adding support for this to types like confloat for now...
I think the decimal_places support for floats is going to be more difficult, due to differing internal storage mechanisms on different machines.

Sorry for the delay, I will make a proposition this week.

I don't feel like I can give on informed opinion on the matter. @sydney-runkle maybe you could help me on this?

@yfalomir,
Yes, certainly! I'll review your PR and the above comments today!

@yfalomir,
Honestly, I agree with @Viicos. It'd be great to not set that precedent.
Closing this for now, as I think the above suggested approach is generally quite clean, and exactly how we expect annotated types to bring great value. Thanks for the feedback and effort, folks!


Why there is clazz.getConstructor(); in ExtensionLoader.loadClass method ?

I found there is a line code clazz.getConstructor(); in  ExtensionLoader.loadClass method.
getConstructor just return it's constructor but there is't a variable to accept it.
Therefore, if it is useless, why not remove it?
ExtensionLoader

When we use clazz.newInstance() to new instance. Default we must have a no-arguments constructor.
I think Dubbo use clazz.getConstructor() to check wheater if a no-arguments constructor in you customer extension. If no exception will cause.


[🐛 Bug]: Using Clerk on Cloudflare Pages: Unhandled ‘default’ Property TypeError Leading to HTTP 500 Errors

next-on-pages environment related information
System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 23.5.0: Wed May  1 20:13:18 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6030
CPU: (12) arm64 Apple M3 Pro
Memory: 18 GB
Shell: /bin/zsh
Package Manager Used: npm (10.7.0)
Relevant Packages:
@cloudflare/next-on-pages: 1.11.2
vercel: 34.1.9
next: 14.2.3
Here's an improved version of your bug description:
Description
Issue Summary:
Intermittent HTTP 500 server errors are encountered when navigating between routes in a web application deployed on Cloudflare. The issue temporarily resolves itself after a short duration or upon restarting the browser. The console logs indicate a cryptic error related to a TypeError.
Error Details:
The error log points to a TypeError concerning an attempt to read a 'default' property of an undefined object, suggesting a possible null reference or an uninitialized variable being accessed.
{
  "outcome": "ok",
  "scriptName": "pages-worker--2581795-production",
  "diagnosticsChannelEvents": [],
  "exceptions": [],
  "logs": [
    {
      "message": [
        "TypeError: Cannot read properties of undefined (reading 'default')"
      ],
      "level": "error",
      "timestamp":<PHONE_NUMBER>345
    }
  ],

Reproduction Steps:
The problem manifests only when the application is deployed to Cloudflare (CF) and not during local development with next dev. A minimal reproduction demo is available in the public repository at zammitjohn/clerk-nextjs-cloudflare-bugger (see README). The issue is absent in the latest main branch commit after removing the Clerk package. However, the error is reproducible in the deployment corresponding to commit 09dcfed9a941f18f439bed262bb03e28d506abce, where Clerk is included as a dependency.
Deployments for Testing:

With Clerk (commit 09dcfed): Deployment Link, where the HTTP 500 error is observed.
Without Clerk (commit 9bac159): Deployment Link, which operates without errors.

Analysis:
The issue is reproducible in a Cloudflare environment, indicating a potential environment-specific problem. The resolution of the issue upon the removal of the Clerk package suggests that the package may be causing or contributing to the problem, potentially due to a configuration error or compatibility issue with the Cloudflare environment.
Pages Deployment Method
Pages CI (GitHub/GitLab integration)
Pages Deployment ID
59977d63
Additional Information
No response
Would you like to help?

[ ] Would you like to help fixing this bug?

Only happens when deployed, all good with next dev.

@dario-piotrowicz @GregBrimble, can you give this a look?

Getting this error too on my preview deployments. Can't find a consistent way to replicate this behavior though.

@dario-piotrowicz, I have reproduced with latest version too<EMAIL_ADDRESS>deployment: https://e7a61adc.my-next-app-buv.pages.dev/. If I understand correctly, issue is happening when navigating between routes which have client components being rendered, with Clerk installed and hosted on Pages.

Getting this error too on my preview deployments. Can't find a consistent way to replicate this behavior though.

My situation is similar to yours. It is easy to reproduce when refreshing the page multiple times quickly and switching routes.

Getting this aswell. Happened after migrating from Clerk Core 1 to Core 2

Same issue here with very similar setup, any updates on this topic?

I got the following response from Clerk support, this week:
Apologies for the delayed response here. Worked with a colleague to try and debug this further. We're thinking it is a node.js compatibility issue with the Cloudflare Worker runtime. Cloudflare is coming out with a new compatibility flag that may resolve this, however, the ETA on when this will be available is still unknown.

I switched my free Workers plan to a paid plan, and now I can't reproduce my issue anymore. It seems this fixed it for me.

I switched my free Workers plan to a paid plan, and now I can't reproduce my issue anymore. It seems this fixed it for me.

Same, i am on the latest node compat, and the issue seems to be resolved(?)

I’m a bit stuck on this issue. @dario-piotrowicz Any chance you could help me out when you get a moment? 😃

@Helferino @jenslys, I reproduced with workers paid plan using compatibility date "2024-05-13". Did you encounter this issue again yourself?

No longer reproducible with the following packages:
@cloudflare/next-on-pages: 1.13.5
vercel: 37.6.1
next: 14.2.5

I don’t know what fixed it.


Synthesis failed for TestClient

Hello! Autosynth couldn't regenerate TestClient. :broken_heart:
Here's the output from running synth.py:
2020-06-06 06:41:11,859 autosynth [INFO] > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-06-06 06:41:12,683 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2020-06-06 06:41:12,686 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2020-06-06 06:41:12,689 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2020-06-06 06:41:12,692 autosynth [DEBUG] > Running: git config push.default simple
2020-06-06 06:41:12,695 autosynth [DEBUG] > Running: git branch -f autosynth-testclient
2020-06-06 06:41:12,698 autosynth [DEBUG] > Running: git checkout autosynth-testclient
Switched to branch 'autosynth-testclient'
2020-06-06 06:41:12,930 autosynth [INFO] > Running synthtool
2020-06-06 06:41:12,930 autosynth [INFO] > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/test_client/synth.metadata', 'synth.py', '--']
2020-06-06 06:41:12,933 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata clients/test_client/synth.metadata synth.py -- TestClient
tee: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api: Is a directory
2020-06-06 06:41:13,159 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-testclient
nothing to commit, working tree clean
2020-06-06 06:41:15,259 synthtool [DEBUG] > Running: docker run --rm -v/tmpfs/tmp/tmpxnnkfx9_/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
DEBUG:synthtool:Running: docker run --rm -v/tmpfs/tmp/tmpxnnkfx9_/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
/workspace /workspace
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  certifi 2.5.1
  google_api_discovery 0.7.0
  google_gax 0.3.2
  hackney 1.15.2
  idna 6.0.0
  jason 1.2.1
  metrics 1.0.1
  mime 1.3.1
  mimerl 1.2.0
  oauth2 0.9.4
  parse_trans 3.3.0
  poison 3.1.0
  ssl_verify_fun 1.1.5
  temp 0.4.7
  tesla 1.3.3
  unicode_util_compat 0.4.1
* Getting google_api_discovery (Hex package)
* Getting tesla (Hex package)
* Getting oauth2 (Hex package)
* Getting temp (Hex package)
* Getting jason (Hex package)
* Getting poison (Hex package)
* Getting hackney (Hex package)
* Getting certifi (Hex package)
* Getting idna (Hex package)
* Getting metrics (Hex package)
* Getting mimerl (Hex package)
* Getting ssl_verify_fun (Hex package)
* Getting unicode_util_compat (Hex package)
* Getting parse_trans (Hex package)
* Getting mime (Hex package)
* Getting google_gax (Hex package)
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
==> temp
Compiling 3 files (.ex)
Generated temp app
===> Compiling parse_trans
===> Compiling mimerl
===> Compiling metrics
===> Compiling unicode_util_compat
===> Compiling idna
==> jason
Compiling 8 files (.ex)
Generated jason app
warning: String.strip/1 is deprecated. Use String.trim/1 instead
  /workspace/deps/poison/mix.exs:4

==> poison
Compiling 4 files (.ex)
warning: Integer.to_char_list/2 is deprecated. Use Integer.to_charlist/2 instead
  lib/poison/encoder.ex:173

Generated poison app
==> ssl_verify_fun
Compiling 7 files (.erl)
Generated ssl_verify_fun app
===> Compiling certifi
===> Compiling hackney
==> oauth2
Compiling 13 files (.ex)
Generated oauth2 app
==> mime
Compiling 2 files (.ex)
Generated mime app
==> tesla
Compiling 26 files (.ex)
Generated tesla app
==> google_gax
Compiling 5 files (.ex)
Generated google_gax app
==> google_api_discovery
Compiling 21 files (.ex)
Generated google_api_discovery app
==> google_apis
Compiling 27 files (.ex)
warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  lib/google_apis/publisher.ex:24

Generated google_apis app
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v1/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v1/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v1/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v1/model/generic_container.ex.
Writing NestedContainer to clients/test_client/lib/google_api/test_client/v1/model/nested_container.ex.
Writing NestedContainerRows to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows.ex.
Writing NestedContainerRowsNestedArrayValue to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows_nested_array_value.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v1/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v2/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v2/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v2/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v2/model/generic_container.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v2/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs

13:41:49.671 [info]  Found only discovery_revision and/or formatting changes. Not significant enough for a PR.
fixing file permissions
2020-06-06 06:41:52,695 synthtool [DEBUG] > Wrote metadata to clients/test_client/synth.metadata.
DEBUG:synthtool:Wrote metadata to clients/test_client/synth.metadata.
2020-06-06 06:41:52,722 autosynth [DEBUG] > Running: git clean -fdx
Removing __pycache__/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 615, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 476, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 555, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 121, in synthesize
    with open(log_file_path, "rt") as fp:
IsADirectoryError: [Errno 21] Is a directory: '/tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api'

Google internal developers can see the full log here.

Autosynth is still having trouble generating TestClient. :sob:
Here's the output from running synth.py:
2020-06-07 06:31:15,372 autosynth [INFO] > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-06-07 06:31:16,539 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2020-06-07 06:31:16,542 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2020-06-07 06:31:16,545 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2020-06-07 06:31:16,548 autosynth [DEBUG] > Running: git config push.default simple
2020-06-07 06:31:16,550 autosynth [DEBUG] > Running: git branch -f autosynth-testclient
2020-06-07 06:31:16,553 autosynth [DEBUG] > Running: git checkout autosynth-testclient
Switched to branch 'autosynth-testclient'
2020-06-07 06:31:16,790 autosynth [INFO] > Running synthtool
2020-06-07 06:31:16,790 autosynth [INFO] > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/test_client/synth.metadata', 'synth.py', '--']
2020-06-07 06:31:16,793 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata clients/test_client/synth.metadata synth.py -- TestClient
tee: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api: Is a directory
2020-06-07 06:31:17,012 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-testclient
nothing to commit, working tree clean
2020-06-07 06:31:18,951 synthtool [DEBUG] > Running: docker run --rm -v/tmpfs/tmp/tmpnk6eqing/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
DEBUG:synthtool:Running: docker run --rm -v/tmpfs/tmp/tmpnk6eqing/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
/workspace /workspace
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  certifi 2.5.1
  google_api_discovery 0.7.0
  google_gax 0.3.2
  hackney 1.15.2
  idna 6.0.0
  jason 1.2.1
  metrics 1.0.1
  mime 1.3.1
  mimerl 1.2.0
  oauth2 0.9.4
  parse_trans 3.3.0
  poison 3.1.0
  ssl_verify_fun 1.1.5
  temp 0.4.7
  tesla 1.3.3
  unicode_util_compat 0.4.1
* Getting google_api_discovery (Hex package)
* Getting tesla (Hex package)
* Getting oauth2 (Hex package)
* Getting temp (Hex package)
* Getting jason (Hex package)
* Getting poison (Hex package)
* Getting hackney (Hex package)
* Getting certifi (Hex package)
* Getting idna (Hex package)
* Getting metrics (Hex package)
* Getting mimerl (Hex package)
* Getting ssl_verify_fun (Hex package)
* Getting unicode_util_compat (Hex package)
* Getting parse_trans (Hex package)
* Getting mime (Hex package)
* Getting google_gax (Hex package)
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
==> temp
Compiling 3 files (.ex)
Generated temp app
===> Compiling parse_trans
===> Compiling mimerl
===> Compiling metrics
===> Compiling unicode_util_compat
===> Compiling idna
==> jason
Compiling 8 files (.ex)
Generated jason app
warning: String.strip/1 is deprecated. Use String.trim/1 instead
  /workspace/deps/poison/mix.exs:4

==> poison
Compiling 4 files (.ex)
warning: Integer.to_char_list/2 is deprecated. Use Integer.to_charlist/2 instead
  lib/poison/encoder.ex:173

Generated poison app
==> ssl_verify_fun
Compiling 7 files (.erl)
Generated ssl_verify_fun app
===> Compiling certifi
===> Compiling hackney
==> oauth2
Compiling 13 files (.ex)
Generated oauth2 app
==> mime
Compiling 2 files (.ex)
Generated mime app
==> tesla
Compiling 26 files (.ex)
Generated tesla app
==> google_gax
Compiling 5 files (.ex)
Generated google_gax app
==> google_api_discovery
Compiling 21 files (.ex)
Generated google_api_discovery app
==> google_apis
Compiling 27 files (.ex)
warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  lib/google_apis/publisher.ex:24

Generated google_apis app
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v1/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v1/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v1/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v1/model/generic_container.ex.
Writing NestedContainer to clients/test_client/lib/google_api/test_client/v1/model/nested_container.ex.
Writing NestedContainerRows to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows.ex.
Writing NestedContainerRowsNestedArrayValue to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows_nested_array_value.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v1/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v2/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v2/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v2/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v2/model/generic_container.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v2/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs

13:31:48.955 [info]  Found only discovery_revision and/or formatting changes. Not significant enough for a PR.
fixing file permissions
2020-06-07 06:31:51,944 synthtool [DEBUG] > Wrote metadata to clients/test_client/synth.metadata.
DEBUG:synthtool:Wrote metadata to clients/test_client/synth.metadata.
2020-06-07 06:31:51,968 autosynth [DEBUG] > Running: git clean -fdx
Removing __pycache__/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 615, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 476, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 555, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 121, in synthesize
    with open(log_file_path, "rt") as fp:
IsADirectoryError: [Errno 21] Is a directory: '/tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api'

Google internal developers can see the full log here.

Autosynth is still having trouble generating TestClient. :sob:
Here's the output from running synth.py:
2020-06-08 06:31:58,216 autosynth [INFO] > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api
2020-06-08 06:31:59,018 autosynth [DEBUG] > Running: git config --global core.excludesfile /home/kbuilder/.autosynth-gitignore
2020-06-08 06:31:59,021 autosynth [DEBUG] > Running: git config user.name yoshi-automation
2020-06-08 06:31:59,024 autosynth [DEBUG] > Running: git config user.email<EMAIL_ADDRESS>2020-06-08 06:31:59,027 autosynth [DEBUG] > Running: git config push.default simple
2020-06-08 06:31:59,030 autosynth [DEBUG] > Running: git branch -f autosynth-testclient
2020-06-08 06:31:59,033 autosynth [DEBUG] > Running: git checkout autosynth-testclient
Switched to branch 'autosynth-testclient'
2020-06-08 06:31:59,251 autosynth [INFO] > Running synthtool
2020-06-08 06:31:59,252 autosynth [INFO] > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'clients/test_client/synth.metadata', 'synth.py', '--']
2020-06-08 06:31:59,254 autosynth [DEBUG] > Running: /tmpfs/src/github/synthtool/env/bin/python3 -m synthtool --metadata clients/test_client/synth.metadata synth.py -- TestClient
tee: /tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api: Is a directory
2020-06-08 06:31:59,459 synthtool [DEBUG] > Executing /home/kbuilder/.cache/synthtool/elixir-google-api/synth.py.
On branch autosynth-testclient
nothing to commit, working tree clean
2020-06-08 06:32:00,965 synthtool [DEBUG] > Running: docker run --rm -v/tmpfs/tmp/tmpc5iz_bxv/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
DEBUG:synthtool:Running: docker run --rm -v/tmpfs/tmp/tmpc5iz_bxv/repo:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir19 scripts/generate_client.sh TestClient
/workspace /workspace
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
Resolving Hex dependencies...
Dependency resolution completed:
Unchanged:
  certifi 2.5.1
  google_api_discovery 0.7.0
  google_gax 0.3.2
  hackney 1.15.2
  idna 6.0.0
  jason 1.2.1
  metrics 1.0.1
  mime 1.3.1
  mimerl 1.2.0
  oauth2 0.9.4
  parse_trans 3.3.0
  poison 3.1.0
  ssl_verify_fun 1.1.5
  temp 0.4.7
  tesla 1.3.3
  unicode_util_compat 0.4.1
* Getting google_api_discovery (Hex package)
* Getting tesla (Hex package)
* Getting oauth2 (Hex package)
* Getting temp (Hex package)
* Getting jason (Hex package)
* Getting poison (Hex package)
* Getting hackney (Hex package)
* Getting certifi (Hex package)
* Getting idna (Hex package)
* Getting metrics (Hex package)
* Getting mimerl (Hex package)
* Getting ssl_verify_fun (Hex package)
* Getting unicode_util_compat (Hex package)
* Getting parse_trans (Hex package)
* Getting mime (Hex package)
* Getting google_gax (Hex package)
The mix.lock file was generated with a newer version of Hex. Update your client by running `mix local.hex` to avoid losing data.
==> temp
Compiling 3 files (.ex)
Generated temp app
===> Compiling parse_trans
===> Compiling mimerl
===> Compiling metrics
===> Compiling unicode_util_compat
===> Compiling idna
==> jason
Compiling 8 files (.ex)
Generated jason app
warning: String.strip/1 is deprecated. Use String.trim/1 instead
  /workspace/deps/poison/mix.exs:4

==> poison
Compiling 4 files (.ex)
warning: Integer.to_char_list/2 is deprecated. Use Integer.to_charlist/2 instead
  lib/poison/encoder.ex:173

Generated poison app
==> ssl_verify_fun
Compiling 7 files (.erl)
Generated ssl_verify_fun app
===> Compiling certifi
===> Compiling hackney
==> oauth2
Compiling 13 files (.ex)
Generated oauth2 app
==> mime
Compiling 2 files (.ex)
Generated mime app
==> tesla
Compiling 26 files (.ex)
Generated tesla app
==> google_gax
Compiling 5 files (.ex)
Generated google_gax app
==> google_api_discovery
Compiling 21 files (.ex)
Generated google_api_discovery app
==> google_apis
Compiling 27 files (.ex)
warning: System.cwd/0 is deprecated. Use File.cwd/0 instead
  lib/google_apis/publisher.ex:24

Generated google_apis app
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v1/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v1/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v1/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v1/model/generic_container.ex.
Writing NestedContainer to clients/test_client/lib/google_api/test_client/v1/model/nested_container.ex.
Writing NestedContainerRows to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows.ex.
Writing NestedContainerRowsNestedArrayValue to clients/test_client/lib/google_api/test_client/v1/model/nested_container_rows_nested_array_value.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v1/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs
{:error, "No URL"}
Revision check: old=20170810, new=20170810, generating=true
Creating leading directories
Writing Container to clients/test_client/lib/google_api/test_client/v2/model/container.ex.
Writing ContainerObjectVal to clients/test_client/lib/google_api/test_client/v2/model/container_object_val.ex.
Writing DateContainer to clients/test_client/lib/google_api/test_client/v2/model/date_container.ex.
Writing GenericContainer to clients/test_client/lib/google_api/test_client/v2/model/generic_container.ex.
Writing Objects to clients/test_client/lib/google_api/test_client/v2/api/objects.ex.
Writing connection.ex.
Writing metadata.ex.
Writing mix.exs
Writing README.md
Writing LICENSE
Writing .gitignore
Writing config/config.exs
Writing test/test_helper.exs

13:32:33.447 [info]  Found only discovery_revision and/or formatting changes. Not significant enough for a PR.
fixing file permissions
2020-06-08 06:32:36,021 synthtool [DEBUG] > Wrote metadata to clients/test_client/synth.metadata.
DEBUG:synthtool:Wrote metadata to clients/test_client/synth.metadata.
2020-06-08 06:32:36,049 autosynth [DEBUG] > Running: git clean -fdx
Removing __pycache__/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 615, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 476, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 555, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 121, in synthesize
    with open(log_file_path, "rt") as fp:
IsADirectoryError: [Errno 21] Is a directory: '/tmpfs/src/github/synthtool/logs/googleapis/elixir-google-api'

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


Bonfire #38, Arguments Optional

Challenge http://www.freecodecamp.com/challenges/bonfire-arguments-optional has an issue. Please describe how to reproduce it, and include links to screen shots if possible.
After running my code, it doesn't pass a few tests. For example:
It is running the following test: 'add(2)(3))' and 'add(2)([3])'. I do not know whether '2)(3)' and '2)([3]'  are  valid arguments.
Maybe the tests are supposed to be written differently?

Sorry about that this is and issue that has been fixed but not yet deployed to the production enviroment. We hope to have it out soon!

Hi, has this fix been deployed yet? I have coded a solution that I think should work, but fails on "expect(add(2)(3)).to.equal(5);expected 6 to equal 5."

No the fix has not yet been deployed but there is no issue with that check your code is wrong. How can 2 + 3 be 6?

Hi @Phadion , I would recommend you review the topic of JavaScript closures before attempting this bonfire. The challenge doesn't have any problem. Please consider closing this issue and discuss on chat room about how to solve this bonfire. Thanks.


Draft: Changes to support conversion of Perfetto traces

Perfetto is a system prfiling/application tracing framework (https://github.com/google/perfetto).
It provides a traceconv tool that converts Perfetto protobuf trace files into different formats, e.g., the Chrome JSON format.
This MR introduces changes to support the OTF2 conversion of Chrome JSON event trace files originally obtained from Perfetto.

Let's start a discussion. IMHO, some changes are not critical, however others might affect the original use case (TensorFlow) of this tool.

Any news here? It would be nice to get this merged.

I do not fee confident in this code, thus @NanoNabla should get active here.


./harlanc test/hello.kfc took a very long time, is that normal?

@eholk I run the command "./harlanc test/hello.kfc" and it took over 2 minutes. But finally I got runnable file "hello". Is that normal? And why it took so long?

6e789cc0f997fd30c481958d7e54fa663eeb2cfa improves performance some more too. Compiling hello.kfc on my machine takes 8.5 seconds now. I'll continue to work on improving the compiler's performance, but I'm going to go ahead and consider this bug fixed.
Please let me know if you're still seeing multiple minute compile times though.


rewrite XmlFrameDecoder.

The old XmlFrameDecoder don't support A full XmlDocument write use more times.
Test old bug: telnet server then write a bigger xml .
telnet <IP_ADDRESS> 8001
`` <XML><TransType>1000</TransType><UserId>7C49FEFBA614BDE18FE32452BF7FDE94</UserId></XML>
旧版不支持一个XML文档多次写完。

AUTOMATED MESSAGE for ADMINS:Please verify and accept the pull request.To accept, say @netkins acceptTo build again, say @netkins buildTo whitelist the author, say @netkins whitelist

@netkins accept

@lhkzh Could you:

Add a test case for the problem you have fixed.
Format your code to adhere to our coding style.
Let us know what changes you have made exactly.

@trustin
ok, I'll do that instantly.

@trustin This PR has been canceled because Jenkins was restarted. Could you launch again?

@netkins build

@recena - Thanks for the heads up ;)

Please address the comments and ping me so we can do another pass of review.  Also, could you let me know if you have filed an ICLA? http://netty.io/s/icla

@trustin http://netty.io/s/icla  ?  404
I am so sorry that I revert the code , I am new to git.

The old XmlFrameDecoder had defect, It can't support XmlDocument into multiple fragments writing.
When I wrote the Xml streaming data It will had problem, I just wan't fix the problem.

@lhkzh so you are still working on it ?

@normanmaurer  I've fixed it. It works fine now.

@lhkzh so can you squash your changes into one commit so we can pull it in ?

Address all my comments?

@trustin yes, address all

@lhkzh please squash into 1 commit

had some probem to revert. restore the code to unmodified.
then commit all

@normanmaurer into one commit


[dv/lc_ctrl] randomize token with constraints

Description
this function:
https://cs.opensource.google/opentitan/opentitan/+/master:hw/ip/lc_ctrl/dv/env/lc_ctrl_env_pkg.sv;l=291
  function automatic lc_ctrl_state_pkg::lc_token_t get_random_token();
    `DV_CHECK_STD_RANDOMIZE_FATAL(get_random_token,, "lc_ctrl_env_pkg");
  endfunction

Randomize token without any constraints. So it is very easy to hit token error failure. I think we should randomize it with constraints, so it has more possibility to pass token check

My bad, csr can be random value so long as the kmac hashed value is correct


Fix rendering of Tiled object layers on isometric maps

This PR:

Fixes a bug

Describe the changes below:
Objects contained in object layers generated by Tiled use orthogonal positioning even when the map is isometric. In the pictures below, note that A has {x:128, y:128} and B has {x:256, y:128} - the y is the same, as one would expect in an orthogonal grid (but not in an isometric one).

The current way to position sprites on createFromObjects uses that position provided by Tiled and applies an origin offset over it - leading to issues as described here.
This PR converts the sprites' position from cartesian to isometric before applying the offset, positioning elements over the grid as expected.

Thanks for the PR - can you please confirm this PR will work correctly with the current changes already made to createFromObjects as part of 3.60?

Thanks 👍


Documentation about command usage and request body?

Hi development team,
I'm building a smarthome app that is runnuing on client devices. I have no servers to build a proxy between.
Is there any documentation how the request is built to implement it directly in JavaScript/NodeJS?

Protocol spec added in https://github.com/teslamotors/vehicle-command/pull/142. Feedback is welcome.


bug: undefined query parameters are added to URLSearchParams

Describe the bug
The when using the route() function, undefined values in the query object are added to the URLSearchParams as param=undefined.
A simple example:
const possibleQueryParam1: string | undefined = "param1";
const possibleQueryParam2: string | undefined = undefined;

return (
  <Link
    href={route({
      pathname: "/",
      query: {
        param1: possibleQueryParam1,
        param2: possibleQueryParam2,
      },
    })}
  >
    Go home
  </Link>
);

This is maybe open to discussion, but I would expect that the link would have an href of /?param1=param1 given that there is no actual value for param2. However in reality, the href is /?param1=param1&param2=undefined.
It would make more sense to me for the route() function to automatically strip any undefined values, forcing the user to explicity include them by converting them to a string. Otherwise, any time I am including a dynamic value that may be undefined, I have to do a conditional check to ensure it doesn't get included in the href.
Taking a look at the code, this could likely be easily solved here by including a check to ensure that value is actually defined.
Something like this I think should work:
  const search = new URLSearchParams();
  for (const key in r.query) {
    if (!params.has(key)) {
      const value = r.query[key];
+     if(value === undefined) continue;
      if (Array.isArray(value)) {
        value.forEach((val) => search.append(key, val));
      } else {
        search.append(key, value as string);
      }
    }
  }

Context (please complete the following information):

nextjs-routes version:
^2.2.3
Are you using the pages directory, app directory, or both?
/app
Are you using nextjs-routes via next.config.js or the CLI (npx nextjs-routes)?
next.config.js
nextjs version:
^14.2.13

Thanks for reporting @sleepdotexe. That's what I get for using a cast 😆


Error while installing Chef server 12.3 on Red hat 6.7

Hi All ,
Getting below issue while installing chef server 12.3 on RHEL 6.7 server.
Can you please help to resolve this?
Recipe: private-chef::opscode-erchef

runit_service[opscode-erchef] action enable
Recipe:

* directory[/opt/opscode/sv/opscode-erchef] action create (up to date)
* template[/opt/opscode/sv/opscode-erchef/run] action create (up to date)
* directory[/opt/opscode/sv/opscode-erchef/log] action create (up to date)
* directory[/opt/opscode/sv/opscode-erchef/log/main] action create (up to date)
* template[/opt/opscode/sv/opscode-erchef/log/run] action create (up to date)
* template[/opt/opscode/sv/opscode-erchef/log/config] action create (up to date)
* link[/opt/opscode/init/opscode-erchef] action create (up to date)
 (up to date)

Recipe: private-chef::bootstrap

template[/opt/opscode/embedded/service/chef-server-bootstrap/bootstrapper-config/config.rb] action create (up to date)

template[/opt/opscode/embedded/service/chef-server-bootstrap/bootstrapper-config/pivotal.yml] action create (up to date)

execute[/opt/opscode/bin/private-chef-ctl start] action run

execute /opt/opscode/bin/private-chef-ctl start

execute[bootstrap-platform] action run

Error executing action run on resource 'execute[bootstrap-platform]'
Mixlib::ShellOut::ShellCommandFailed
Expected process to exit with [0], but received '1'
---- Begin output of /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml ----
STDOUT:
STDERR: /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:in initialize': Connection refused - connect(2) for "<IP_ADDRESS>" port 9463 (Errno::ECONNREFUSED)     from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:inopen'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:in block in connect'     from /opt/opscode/embedded/lib/ruby/2.1.0/timeout.rb:76:intimeout'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:878:in connect'     from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:863:indo_start'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:852:in start'     from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:206:intransmit'
from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:68:in execute'     from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:35:inexecute'
from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient.rb:74:in post'     from ./bin/bootstrap-platform:101:increate_object_in_authz'
from ./bin/bootstrap-platform:47:in bootstrap'     from ./bin/bootstrap-platform:120:in'
---- End output of /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml ----
Ran /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml returned 1
Resource Declaration:
In /opt/opscode/embedded/cookbooks/cache/cookbooks/private-chef/recipes/bootstrap.rb
45: execute "bootstrap-platform" do
46:   command "/opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml"
47:   cwd opscode_test_dir
48:   retries 3
49:   not_if { OmnibusHelper.has_been_bootstrapped? }
50:   notifies :restart, 'service[opscode-erchef]'
51: end
52:
Compiled Resource:
Declared in /opt/opscode/embedded/cookbooks/cache/cookbooks/private-chef/recipes/bootstrap.rb:45:in `from_file'
execute("bootstrap-platform") do
action [:run]
retries 3
retry_delay 2
default_guard_interpreter :execute
command "/opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml"
backup 5
cwd "/opt/opscode/embedded/service/chef-server-bootstrap"
returns 0
declared_type :execute
cookbook_name "private-chef"
recipe_name "bootstrap"
not_if { #code block }
end

Running handlers:
[2016-01-05T18:03:30+05:30] ERROR: Running exception handlers
Running handlers complete
[2016-01-05T18:03:30+05:30] ERROR: Exception handlers complete
Chef Client failed. 22 resources updated in 01 minutes 04 seconds
[2016-01-05T18:03:30+05:30] FATAL: Stacktrace dumped to /opt/opscode/embedded/cookbooks/cache/chef-stacktrace.out
[2016-01-05T18:03:32+05:30] FATAL: Mixlib::ShellOut::ShellCommandFailed: execute[bootstrap-platform](private-chef::bootstrap line 45) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
---- Begin output of /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml ----
STDOUT:
STDERR: /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:in initialize': Connection refused - connect(2) for "<IP_ADDRESS>" port 9463 (Errno::ECONNREFUSED)         from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:inopen'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:879:in block in connect'         from /opt/opscode/embedded/lib/ruby/2.1.0/timeout.rb:76:intimeout'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:878:in connect'         from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:863:indo_start'
from /opt/opscode/embedded/lib/ruby/2.1.0/net/http.rb:852:in start'         from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:206:intransmit'
from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:68:in execute'         from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient/request.rb:35:inexecute'
from /opt/opscode/embedded/service/gem/ruby/2.1.0/gems/rest-client-1.6.8/lib/restclient.rb:74:in post'         from ./bin/bootstrap-platform:101:increate_object_in_authz'
from ./bin/bootstrap-platform:47:in bootstrap'         from ./bin/bootstrap-platform:120:in'
---- End output of /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml ----
Ran /opt/opscode/embedded/bin/bundle exec ./bin/bootstrap-platform ./bootstrapper-config/config.rb ./bootstrapper-config/pivotal.yml returned 1

My apologies no one responded to this issue.  I'm going to close this for now; however, if you still require help please feel free to reopen this issue or open a new issue.


force the encoding to UTF8

Fix issue #1717. Solution is to always read the file in UTF8. Otherwise it will cause problem on windows 10 and updated chrome.

@jackyq2015 interesting...how did you know WHAT to fix based on what was detailed in #1717 ?  We had never had issues before and placing this on controller.js seems wrongly placed...but perhaps I am missing what your Root Cause Analysis has discovered... can you share those details ?

Is it only with Chrome or any browser on Windows 10 ?

For any browsers under 10


consolidate bazel configurations and build_stamp scripts

@ayj: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
563797975084452fa8ef9964863125fa2ac323c4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f984f297d54851874df0ed1725a8abf6ea5357cf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f984f297d54851874df0ed1725a8abf6ea5357cf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
fcb6ebc2ef66dc6ae336026ca436cdd868536fc8
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
3918b748e3f374cf056046f846ea6746ba8bad4a
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like my PR https://github.com/istio/istio/pull/1902 overlaps with this one but each lacks changes/fixes that's in the other.

@mattdelco, I'm happy to drop this PR if you want to roll in any missing changes into yours.

I'll work on trying to make mine a superset.  I think the main thing I have to add is having a few more things sent to stdout by get_workspace_status.

Superseded by https://github.com/istio/istio/pull/1902


nixos/_6tunnel: init

Motivation for this change

6tunnel allows you to use services provided by IPv6 hosts with IPv4-only applications and vice-versa. It can bind to any of your IPv4 (default) or IPv6 addresses and forward all data to IPv4 or IPv6 (default) host.

There was a package already, but a module was missing
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@dotlambda @misuzu Thanks for your input. I've changed your points and made the firewall part optional. Please review!

I've reordered them by their occurrance in https://www.freedesktop.org/software/systemd/man/systemd.exec.html and included your changes.

Short note: after setting ProtectProc = true; it throws this error now when starting:
Mai 06 13:58:00 thor systemd[1]: /nix/store/9rz6s8zplfvwfd2hzkwqcasrdlviv800-unit-6tunnel-5001.service/6tunnel-5001.service:32: Failed to parse /proc/ protection mode, ignoring: true

But I think we can ignore this, as it works fine.

Just a quick bump, anyone ready to have a look at the test?


White layer over simulator problem

Hey people,
I'm experiencing some issue with my simulator. The background of the UI is white in the menu and also during the simulator there is a white layover. I though it might have something to do with the Build Settings and already tried if I need to include maybe UISetupScene from the assets but it didn't help. Any ideas or did some of you experience the same problem? I'm quite a beginner with Unity so far, so sorry if that's an easy question, though couldn't find anything online.
Screenshots are attached:

Same here.....BTW which version of Unity are you using?

same problem..

@mattk90 the reason for that white overlay is the missing textures. When you download the archive from Github using "Download ZIP", the texture files which are stored on git using Git LFS(Large File Storage), are not downloaded. Instead, only the 'pointers' to those files are downloaded. So in order to solve the issue, either install LFS in git and then clone the repo, or use some other git client which supports LFS.
You can find the info here as well:
https://help.github.com/articles/versioning-large-files/


Repo not known as standard HACS repo

Stillr equired to add the repo https://github.com/myTselection/telenet_telemeter as a custom repo within HACS to enable installation.

hacs actions added,
hacs validation requires icon/logo branding to be approved in HA branding repo, ongoing

waiting for pull request approval https://github.com/hacs/default/pull/1689

merged in default HACS repo


Add Story of the day

Don't merge yet

What line is the problem on?

eBane/The-Scribe/blob/master/plugins/writing.js#L1614 start your function after this end.

Err github.com/axeBane/The-Scribe/blob/master/plugins/writing.js#L1614 *

Also I would suggest make it after HOTD ends.

k

Huh, sorry I didn't see you made another commit with fix location, .-.

Finally passing test, now I'm figuring out the html problem


Instead of random wait time in CI, read the resource details using Timeout

+ kubectl rook_ceph -o test-operator -n test-cluster rbd ls replicapool
rbd: error opening pool 'replicapool': (2) No such file or directory
rbd: listing images failed: (2) No such file or directory
command terminated with exit code 2
Error: Process completed with exit code 2.

The CI failed because the wait time was not enough to reconcile the operator completely,
Instead of adding random wait time, we can read the resource until it becomes ready using Timeout,
LIke : https://github.com/rook/rook/blob/ec0c9a7963357fcd9023fc8d7c28720fe6f3c810/.github/workflows/canary-integration-test.yml#L59

after this fix #38 I have not seen a CI issue, before this, I faced but not once was this merged.
try rebasing.

@subhamkrai You can see my PR is already on top of it https://github.com/rook/kubectl-rook-ceph/pull/36
Still, the CI fails with this error,
And anyhow using Timeout would be a good practice in time, when the CI would be growing more with commands:)

right, checking for resource is better
Feel free to raise the pr


NetTcp features and fixes

@BetsyRT try

:hourglass: Trying commit 96a217d with merge 0963a96...

:sunny: Test successful - runtests
State: approved= try=True


📝 Update includes for docs/em/docs/advanced/dataclasses.md

📝 Update includes for docs/em/docs/advanced/dataclasses.md to fix #12554

Thanks for the effort! :cake:
This was handled in another PR, so I'll close this one now. :coffee:


Please change "Login" to "Username" on the login page of IYO

Hello,
A customer of us has requested to change the text "Login" to "Username" on the IYO login page.
Please change the placeholder on the username field currently displayed "Login" to "Username"

Kind regards

As we also allow users to log in with their verified email addresses or phone numbers, changing the text to just Username does not seem to be the best solution. We can however change it to something like "Username, Email address or phonenumber".
@n-dury  toughts about this solution?

@LeeSmet Hi lee, this solution would be just fine.
Thanks in advance


optional  query parameters in url

I need to have two optional parameter passed by url using the query string, I was able to reach this using ui-router ( plunker ) but is not working in mine application based on angular-permission for handling Authorization.
the state definition where i need this parameter is:
     $stateProvider
             .state('schedule', {
                  url: "/schedule?param1&param2",//&?posizioneList&?areaList&?arbplList
                  views: {
                            'header': {
                                templateUrl: "common/partials/header.tpl.html",
                                controller: "HeaderCtrl"
                              },'content': {
                                 templateUrl: "schedule/partials/schedule.tpl.html",
                                 controller:"ScheduleRecapCtrl"
                          }
                  },
                   resolve:{
                	     Filters:'Filters',
                              availableFilters:function(Filters){
                		              return Filters.get().$promise;
                	      }
                   }, data: {
                             permissions: {
                                  only: ['logged'],
                                  redirectTo: 'login'
                              }
                    }
                  })

this is mine groups definition
app..run(function (PermissionStore, authenticationSvc) {
        // Define anonymous permission
        PermissionStore
            .definePermission('anonymous', function (stateParams) {
                // If the returned value is *truthy* then the user has the permission, otherwise they don't
                return !authenticationSvc.isLogged();
            });
        PermissionStore.definePermission('logged', function (stateParams) {
                return authenticationSvc.isLogged();
            });

I noted that after reaching the state with the parameters a new $stateChangeStart is triggered (before the $stateChangeSuccess) but without the parameters that comes from the url.
this is the dependencies section of my bower.json file
"dependencies": {
    "angular": "~1.4.0",
    "angular-bootstrap": "~1.1.2",
    "angular-loader": "~1.4.0",
    "angular-mocks": "~1.4.0",
    "angular-route": "~1.4.0",
    "angular-ui-router": "~0.2.17",
    "html5-boilerplate": "~5.2.0",
    "angular-animate": "^1.4.9",
    "angular-permission": "^2.0.1",
    "bootstrap": "^3.3.6",
    "startbootstrap-sb-admin-2": "^1.0.8",
    "angular-filter": "^0.5.8",
    "angular-block-ui": "^0.2.2",
    "angular-resource": "^1.5.0",
    "angular-local-storage": "^0.2.3",
    "angular-toastr": "^1.7.0",
    "angular-translate": "^2.9.1",
    "angular-sanitize": "^1.5.0",
    "angular-translate-storage-local": "^2.9.1",
    "angular-cookies": "^1.5.0",
    "angular-translate-loader-static-files": "^2.9.1"
  },```

with the 2.0.0 the problems is still present, as soon I can I will try with the 2.1.0-beta version


Removed the left over call to popstate

Replaced with new logic in _indcludes/documentation.html.
This is the remaining fix for #12030

Confirmed


Readme usage + actually returning something meaningful from the modul…

…e (not that it mattered)
Fixes #7

why not make these changes?


Explore data profiling for datalake connector

Explore data profiling for datalake connector
Support conversation link: https://openmetadata.slack.com/archives/C02B6955S4S/p1661257220174859

@ulixius9 would that the same as https://github.com/open-metadata/OpenMetadata/issues/7449?

duplicate with #7449


Polyfilled Array.sort with callback fails when a breakpoint is added.

Code:
function swap(arr, first_Index, second_Index){
    var temp = arr[first_Index];
    arr[first_Index] = arr[second_Index];
    arr[second_Index] = temp;
}

var bubble_sort = function(comp){
    var len = this.length,
        i, j, stop;

    for (i=0; i < len; i++){
        for (j=0, stop=len-i; j < stop; j++){
            if (comp(this[j], this[j+1]) > 0){
                swap(this, j, j+1);
            }
        }
    }

    return this;
}

Array.prototype["sort"] = bubble_sort;
console.log([3, 0, 2, 5, -1, 4, 1].sort(
    function(a,b) {
        return b-a
    }
));

Error message:
Uncaught Error: step(onStep) requires the program to be paused
Screenshot:

Thanks for reporting this! I believe I've tracked the bug down and fixed it here (#425). We'll merge it in and update stopify.org shortly.


refactor: include visibleForTesting annotation on test parameters

Description
Throughout the codebase there are many instances where a class has optional parameters to allow dependency injection during testing, these should be annotated with visibleForTesting.
For example:
// lib/src/commands/create/commands/create_subcommand.dart
  CreateSubCommand({
    required Analytics analytics,
    required this.logger,
    required MasonGeneratorFromBundle? generatorFromBundle,
    required MasonGeneratorFromBrick? generatorFromBrick,
  })

We should intentionally and explicitly denote these as visibleForTesting as:
// lib/src/commands/create/commands/create_subcommand.dart
  CreateSubCommand({
    required Analytics analytics,
    required this.logger,
    @visibleForTesting required MasonGeneratorFromBundle? generatorFromBundle,
    @visibleForTesting required MasonGeneratorFromBrick? generatorFromBrick,
  })

Expected Behavior

To have all parameters that are used exclusively for testing purposes be annotated with visibleForTesting.

Additional Context

visibleForTesting

Hello @alestiago and @BeatriceMitchell,
I hope you're doing well. I'd like to contribute to the very_good_cli and noticed that there's this open issue. Would it be possible to assign this issue to me? I'd be happy to work on it.
Thank you,

Hello @alestiago,
Actually after running the command dart test, some of the tests are failing. So can you please help me out in resolving it?

HI @superiorsd10 , thanks for letting us now! I'm happy to help! Do you mind opening a new issue with the test failure you're getting and information about your system (for example, output of flutter doctor)? This is mainly to avoid polluting this issue and to allow us referencing to the other issue if the same problem occurs.

Hello @alestiago,
I've opened an issue regarding this. Please look into it.
some tests are failing on running dart test
Thank you,

@alestiago Sure! Thank you for the help :)

Thank you @alestiago :) The tests are working perfectly fine now.
I've opened another issue, so could you please consider assigning it to me?
fix: markdown formatting mistake in CONTRIBUTING.md file
Thank you,


Question about velocity of ADC when stopped

System information

OS Platform and Distribution: Ubuntu 18.04
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 7.0 (master branch - commit #14556)

Context:
When analyzing CyberRT record of a specific scenario, sometimes even when seeing ADC completely stopped in stop line (with STOP fence) does not mean that the corresponding linear_velocity extracted from messages in channel /apollo/localization/pose would be 0.0 (the linear_velocity values are decreased really small but never be absolute 0.0).
Meanwhile, Apollo source code has several code snippets to check if ADC is completely stopped. Actually, they do not compare the linear_velocity with 0.0, instead comparing it with a configured threshold max_adc_stop_speed (as 0.2 for the car model Lincoln MKZ).
https://github.com/ApolloAuto/apollo/blob/b09259f8be3ae85b3b3471d45d301175d46c2a8f/modules/planning/scenarios/stop_sign/unprotected/stage_pre_stop.cc#L233-L240
Questions

Why is it sometimes ADC's linear_velocity cannot reach absolute 0.0 at a stop sign, as it is supposed to be?
What is max_adc_stop_speed and how is it considered for checking if ADC is stopped or not?
Is that somehow related to the rolling stop mechanism? Does Apollo decide in each specific scenario to have a complete stop or a rolling stop?

Supporting materials (screenshots, command lines, code/script snippets):
Demo CyberRT Record: https://drive.google.com/file/d/1noE5XO8GPisnOMoaYH_820OGLckKwajC/view

vehicle speed from wheel speed sensor may have error


Avoid writing to /root when running nohup

This PR cherry picks the changes from:
https://github.com/resin-os/meta-resin/pull/614
This allows us to build with Jenkins and adds a changelog.

@resin-jenkins retest this please

@resin-jenkins retest this please

Thanks

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please

@resin-jenkins retest this please


yt-dlp not converting to mp3 when in standalone application MacOS

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[ ] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I am making a standalone application for MacOS using PyInstaller and yt-dlp. My issue is that when my script is packaged as an application, it does not convert the .webm file to .mp3. however, when I run the script through an IDE, it downloads and converts fine. With logging, I traced the problem to  yt_dlp.YoutubeDL(ydl_opts).download([query]) where ydl_opts are the options: 'format': 'bestaudio/best',
'outtmpl': output_path + '.webm',
'default_search': 'ytsearch',
'postprocessors': [{
'key': 'FFmpegExtractAudio',
'preferredcodec': 'mp3',
'preferredquality': '190',
and "query" variable  is basically just a list of the songs.
I have tried other ways to package my script into an application such as py2app and I have the same Issue - files get downloaded and the script gets executed in full - but when packaged as an application, it will not convert to mp3.
Additionally, if I right-click the app and go to Show Package Contents - MacOs - nameOfFile (UNIX executable version) it opens up a terminal, and the code runs properly - it downloads and converts.
Is this just an issue with yt-dlp not being able to get packaged?
I can provide more details if necessary
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
I do not have the verbose output as I am running a standalone application and no errors occur

You need to determine whether ffmpeg is being run in the context of your packaged application. If not, you need to add some weird macOS incantation to your packaging to make it run. If it is, what is the result?


Fix crash on empty terrain types in tile data

When reading a tileset with terrain types, the xml file has entries like
<tile id="1" terrain="1,2,1,0"/>, which defines the terrain type for each corner of each tile.
If a corner has no terrain type set, it is omitted like this:
<tile id="1" terrain=",,,0"/>, on which the current implementation of TiledReader throws a javax.xml.stream.XMLStreamException: (line 8, column 31): Value of <tile> tag's terrain attribute (,,,0) contains a non-integer value.
This PR fixes this, so that the file is read without exception and empty terrain types are represented by null in the TiledTile's terrainTypes array.

Thanks for finding and fixing this.


TRAVIS issue

script:
  - find . -name Dockerfile | xargs dockerfilelint
  - for dockerDir in *; do make $dockerDir; done

The for loop will match the files like README.md and Makefile?
Maybe find .  -maxdepth 1 -mindepth 1 -type d -exec make {} \;

Thanks, Torsten. I've opened PR https://github.com/Linuxbrew/docker/issues/32 to resolve this issue.


Like button using localstorage

The like button, on clicked, sets in localstorage that that post is liked by the user and it can't be liked again
But one can easily clear the localstorage and like it again (see screenshots)
this makes it easier for exploiters to spam like any particular post

There are Chrome extensions to delete localstorage too

There are Chrome extensions to delete localstorage too

That's not very helpful with this issue

@natyavidhan
This type of issue is unlikely to be a primary target for individuals seeking to exploit vulnerabilities.


Install setuptools before installing requirements in CI

skip change file check

I'm trying #4786 to see if that fixes the issue too...

Superseded by https://github.com/pydantic/pydantic/pull/4786


Incremented version to 2.0.1

Description
Increment version to 2.0.1
Part of https://github.com/opensearch-project/opensearch-build/issues/2165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CI failed with "> Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.1/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-anomaly-detection-<IP_ADDRESS>.zip to /home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/org/opensearch/ad/bwc/anomaly-detection/<IP_ADDRESS>-SNAPSHOT/opensearch-anomaly-detection-<IP_ADDRESS>.zip"
Should be temporary once 2.0.1 zip becomes available.

CI failed with "> Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.1/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-anomaly-detection-<IP_ADDRESS>.zip to /home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/org/opensearch/ad/bwc/anomaly-detection/<IP_ADDRESS>-SNAPSHOT/opensearch-anomaly-detection-<IP_ADDRESS>.zip"
Should be temporary once 2.0.1 zip becomes available.

CI failed with "> Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.1/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-anomaly-detection-<IP_ADDRESS>.zip to /home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/org/opensearch/ad/bwc/anomaly-detection/<IP_ADDRESS>-SNAPSHOT/opensearch-anomaly-detection-<IP_ADDRESS>.zip"
Should be temporary once 2.0.1 zip becomes available.

Yes. We would need this to be merged to build the artifacts.

CI failed with "> Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.0.1/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-anomaly-detection-<IP_ADDRESS>.zip to /home/runner/work/anomaly-detection/anomaly-detection/src/test/resources/org/opensearch/ad/bwc/anomaly-detection/<IP_ADDRESS>-SNAPSHOT/opensearch-anomaly-detection-<IP_ADDRESS>.zip"
Should be temporary once 2.0.1 zip becomes available.

I agree and it makes sense for now, however doing this for larger releases on multiple plugins could be annoying as some plugins might have actual changes that fail bwc test that are missed and only found later.


Cannot create styled-component for component:

There is an issue with Internet Explorer 8 till 11
Error: Cannot create styled-component for component: .sc-bZQynM.
I am using :
 "react-items-carousel": "^2.3.0",
    "react": "^16.0.0",
    "react-dom": "^16.0.0"

@AlaeddineMessadi maybe this is related to this issue https://github.com/styled-components/styled-components/issues/1449
This comment suggests a solution for this issue
https://github.com/styled-components/styled-components/issues/1449#issuecomment-420087359
But I think it's not a good idea to add styled-components as a dependency to this package. So I created another issue to remove styled-components and use inline styles instead with inline-styles-prefixer probably...
https://github.com/bitriddler/react-items-carousel/issues/15

@bitriddler This is great! I highly agree with you by using inline styles instead

I made a temporary fix until I find another approach to styled-components. https://github.com/bitriddler/react-items-carousel/issues/15#issuecomment-485387792


xcrun parameters missing?

I created the following script:
#!/usr/local/bin/apous

import Foundation
import CommonMark
import LiterateSwift

print("Hello")

And the following Podfile:
platform :osx, 10.9

plugin 'cocoapods-rome'

use_frameworks!

pod 'CommonMark'
pod 'LiterateSwift'

However, when I run it, I get the following error (regardless of whether I take the hasbang approach or compile everything).
<unknown>:0: error: cannot load underlying module for CoreGraphics
<unknown>:0: note: did you forget to set an SDK using -sdk or SDKROOT?
<unknown>:0: note: use "xcrun -sdk macosx swift" to select the default OS X SDK installed with Xcode

Are you using Swift 2.0? I cannot run your example on OS X 10.11 with Swift 2.0.
Running pod install --no-integrate
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Installing CommonMark (0.0.2)
Installing LiterateSwift (0.0.1)
Installing cmark (0.21.0)
/bin/bash: (cmark.*): No such file or directory
/Users/owensd/tmp/main.swift:4:8: error: no such module CommonMark
import CommonMark

I looked at this again today after getting cmake installed.
$ apous
Running pod install --no-integrate
Updating local specs repositories
Analyzing dependencies
Downloading dependencies
Using CommonMark (0.0.2)
Using LiterateSwift (0.0.1)
Using cmark (0.21.0)
Generating Pods project
dyld: warning, LC_RPATH @executable_path/../lib in /Applications/Xcode-beta.app/Contents/Frameworks/IDEFoundation.framework/Versions/A/../../../../Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/libclang.dylib being ignored in restricted program because of @executable_path
dyld: warning, LC_RPATH @executable_path/../lib in /Applications/Xcode-beta.app/Contents/Frameworks/IDEFoundation.framework/Versions/A/../../../../Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/libLTO.dylib being ignored in restricted program because of @executable_path
dyld: warning, LC_RPATH @executable_path/../Frameworks in /Applications/Xcode-Beta.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/MacOS/Xcode3Core being ignored in restricted program because of @executable_path
Sending stats
Building frameworks
Built 3 frameworks
Copying frameworks to `Rome`
Hello

Thanks! Hm, not sure why it's not working for me then... I am on the latest Xcode beta. I'll have a look at it later this week, with the new beta. Thanks a lot!


[#1401] feat(dashboard): execluded list deletion function.

What changes were proposed in this pull request?

Provides the page deletion function for blacklist pages.
Provide search function for blacklist page.

Why are the changes needed?
Fix: #1967
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
UT.

This function needs to be reviewed after merging the previous PR.

This feature is ready. PATL


Add repeated group component icon.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #726
Description
Icon was missing for Repeated group component in the catalog app.
= > Icon is updated.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

fyi @kevinmost


[SPARK-15392] [SQL] fix default value of size estimation of logical plan

What changes were proposed in this pull request?
We use  autoBroadcastJoinThreshold + 1L as the default value of size estimation, that is not good in 2.0, because we will calculate the size based on size of schema, then the estimation could be less than autoBroadcastJoinThreshold if you have an SELECT on top of an DataFrame created from RDD.
This PR change the default value to Long.MaxValue.
How was this patch tested?
Added regression tests.

Test build #58814 has started for PR 13179 at commit c90d7a0.

So you are changing the default behavior to never broadcast?

@hvanhovell This is only used when you do not know the size of table, for others, like parquet files, will still have reasonable estimation.

Yeah my comment should have been a bit more subtle. That is what I meant. Should we add a comment to the release notes for this?
LGTM

@hvanhovell I think this is not an behavior change since 1.6. Before 2.0, the size estimation will never decrease, so autoBroadcastJoinThreshold + 1L should be enough to make sure that the table will not be used as broadcast. But Spark 2.0 could decrease the size estimation, which break the internal assumption, this PR just fix that to maintain the same behavior as before. cc @rxin

LGTM.

@davies thanks for the explaination

Merging in master/2.0.

Test build #58814 has finished for PR 13179 at commit c90d7a0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58814/
Test FAILed.


Command not found

Tried installing with pip  and received error "rsa requires Python '>=3.5, <4' but the running Python is 2.7.17"
I then installed with pip3 install kube-shell and run kube-shell and receive "kube-shell: command not found"

Hello, @danieniemand. I think you need to update your python version, sudo apt-get install python3.8. Then try pip3 install kube-shell. After you install kube-shell, you need to refresh your bash-shell depend on your shell do u use.
Then try run kube-shell.

Didn't work


Is iOS platform supported?

Please provide information on iOS platform support level,
at least short info.
Thanks!

@mnba The question is not related to the KivyMD library. Contact support here - https://github.com/kivy/kivy/issues/new/choose

Kivy site mentions that iOS is supported, does that automatically means that KivyMD has iOS support? You have many Android mentions on here, but there is no any mentions of iOS platform, that is why I was asking

@mnba KivyMD == Kivy


Fixed GetComputerNameExA calls. #3815

I've just noticed that GetComputerNameEx does not correctly update the lpnSize parameter.
(That bug was already there).
According to https://msdn.microsoft.com/en-us/library/windows/desktop/ms724301(v=vs.85).aspx:

lpnSize: On output, receives the number of TCHARs copied to the destination buffer, not including the terminating null character.

Would be great if you could also fix this.
You can find my ctest here: https://github.com/nfedera/FreeRDP/commit/055c4a4276faa17d69b5283bd4b21dd0bf3894ac which I'll create a PR for once your PR is merged.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In ec0283a, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 5862 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 434937d.


Use a state type for the state field in StateChangedEvent

Be more strict about the state field.

I had implemented Default for State, setting Invalid as the default option of none others are available. Unfortunately, this isn't really correct since "invalid" getting sent over the bus, and a state of invalid characters (for example "fire"), should not have the same behaviour.

Blocked on #91


Update akka-http-session:core to 0.6.1

Updates com.softwaremill.akka-http-session:core from 0.3.0 to 0.6.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.akka-http-session", artifactId = "core" } ]

labels: library-update, semver-minor

Superseded by #2245.


Automate esp-open-sdk and micropython library setup

As the README of micropython/esp8266 describes, you now have to build both the micropython cross-compiler and the axtls library before being able to compile any esp8266 firmware.
I also see no reason not to build the esp-open-sdk when initializing the vagrant box.
Therefor all of this should, in my opinion, be automated by the vagrant provisioning script as these changes do.

Much better.
Either the README should be updated or this should be merged.

@thekrunchyfrog not sure if this is wanted behaviour anymore, but I've synced this pr up to master now.

We have merged this PR. However, we are deprecating this library. It is no longer supported. Please fork if you wish to continue development. Thanks!


Sync package-lock.json to all tracks

Currently we sync root package.json to all exercise directories. Files in exercise directory are served to our users.
Should we also sync package-lock.json to make sure users get exactly the version we intend?
If we decide to sync, we also need to check its integrity.

I don't think we should force npm over yarn and I think that npm is way too talkative when it comes to dependencies of dependencies. It also means that we will have to upgrade all exercises way more often (for every patch-level change), which leads to a lot of exercises being denoted as "outdated" even though the content doesn't change at all.
That said, if we want consistent workspaces, it's well worth the effort? What do you think?

Also: this code doesn't run on the web, not on the internet.

Detection of "outdated" exercises should be smarter and should not stop the housekeeping.
Exercise instructions use npm.

I don't think we should force npm over yarn

yarn would still work with package.json so I would call it recommending rather than forcing.

It also means that we will have to upgrade all exercises way more often (for every patch-level change), which leads to a lot of exercises being denoted as "outdated" even though the content doesn't change at all.

I am not much keen on the security audit fixes. We can safely ignore those since this is not a critical project.

if we want consistent workspaces, it's well worth the effort? What do you think?

I don't have a strong opinion on this. We can leave this issue open & tackle this as and when someone finds time. Right now versioning & bringing all exercises in sync (https://github.com/exercism/javascript/issues/628) is of more priority for me since lot of exercise have gone out of sync with canonical data.

yarn would still work with package.json so I would call it recommending rather than forcing.

yes, but it leads to "2 lock files" for those users, with inconsistent behaviour, meaning support will be more difficult for us.

I am not much keen on the security audit fixes. We can safely ignore those since this is not a critical project.

Exactly my thinking 💯

Right now versioning & bringing all exercises in sync (#628) is of more priority for me since lot of exercise have gone out of sync with canonical data.

💯 agreed


[Application] Translations

Dear lenis0012,
can i help with the translation of LoginSecurity? I can speak french and german! So if you need translated strings, tell me!
Regards Tzzzt123

https://github.com/lenis0012/LoginSecurity-2/blob/master/src/main/resources/lang/en_us.json
you can make a translated version for the upcoming update.
I will make a github project where you can submit translatiosn very soon.
french is "fr_fr" and german is "de_de"
You can start translating if you want, and submit the files when the translation project is up.
Somes notes:
The first argument (ex. "generalNotAuthenticated") should not be translated.
The % arguments are replaces and should not be translated (ex. %min%)
You can't use the " character in your messages
I recommend using http://www.jsoneditoronline.org/

and special chars?

@Tzzzt123 any unicode character should be fine

ok thanks

@lenis0012 Gitter, gitter, gitter, gitter.... returns into the shadows

@sgdc3 lol <3

@lenis0012 what should i put in the branch authors? just lenis or also the translator's name?
Thanks Tzzzt123

translations done, tell me when you need them please

@Tzzzt123 Could you PR them to https://github.com/lenis0012/Translations/tree/master
You can click on https://gyazo.com/607f72f37178238c054b7ec310c4c5e6 "create new file"
and paste your translations in

I put them on a own repository LINK: https://github.com/Tzzzt123/Translations
Regards Tzzzt123

@Tzzzt123 read it

ok, thanks done

@lenis0012 is currently offline for a few days, he should be back at the end of this week.


docs(demo): add demo for pagination directive

Before submitting a pull request, please make sure you have at least performed the following:

[x] read and followed the CONTRIBUTING.md guide.
[x] built and tested the changes locally.
[x] added/updated any applicable tests.
[x] added/updated any applicable API documentation.
[x] added/updated any applicable demos.

Pagination component demo for #202

LGTM. We could add another 2 demos that show:

pagination sizes
events ([(page)])


bosh upload release fails for an older cf-release

$ bosh releases
Acting as user 'admin' on 'Bosh Lite Director'
No releases

$ bosh upload release https://bosh.io/d/github.com/cloudfoundry/cf-release?v=218
Acting as user 'admin' on 'Bosh Lite Director'

Using remote release `https://bosh.io/d/github.com/cloudfoundry/cf-release?v=218'

Director task 1
  Started downloading remote release > Downloading remote release
. Failed: Downloading remote release failed. Check task debug log for details. (00:03:06)

Error 100001: Downloading remote release failed. Check task debug log for details.

debug: https://gist.github.com/shalako/0843619732facfafbe88

This eventually succeeded with bosh upload release releases/cf-218.yml but wow it took a long time. Maybe building it locally would be faster.

Virtualbox networking issue. vagrant reload typically resolves it.


Sysmon service did not start successfully

Operating System Version: Pop OS 20.10
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): Virtualbox
Vagrant Version (if applicable): 2.2.14

Please verify that you are building from an updated Master branch before filing an issue.
Description of the issue:

While building the domain controller host, I'm running into the following error message that causes the build to stop:
dc: [17:25] Downloading PsExec64.exe...
dc: [17:25] Downloading procexp64.exe...
dc: [17:25] Downloading Sysmon64.exe...
dc: [17:25] Downloading Tcpview.exe...
dc: [17:25] Downloading Olaf Hartong's Sysmon config...
dc: [17:25] Starting Sysmon...
dc: [17:25] Verifying that the Sysmon service is running...
dc: powershell.exe : The Sysmon service did not start successfully
dc:     + CategoryInfo          : NotSpecified: (The Sysmon serv...rt successfully:String) [], RemoteException
dc:     + FullyQualifiedErrorId : NativeCommandError
dc: At C:\tmp\vagrant-shell.ps1:114 char:3
dc: +   throw "The Sysmon service did not start successfully"
dc: +   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
dc:     + CategoryInfo          : OperationStopped: (The Sysmon serv...rt successfully:String) [], Ru
dc:    ntimeException
dc:     + FullyQualifiedErrorId : The Sysmon service did not start successfully
dc:

The following WinRM command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

powershell -ExecutionPolicy Bypass -OutputFormat Text -file "C:\tmp\vagrant-shell.ps1"

Stdout from the command:

[17:25] Installing SysInternals Tooling...

    Directory: C:\Tools

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        1/11/2021   5:25 PM                Sysinternals

    Directory: C:\ProgramData

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        1/11/2021   5:25 PM                Sysmon
[17:25] Downloading Autoruns64.exe...
[17:25] Downloading Procmon.exe...
[17:25] Downloading PsExec64.exe...
[17:25] Downloading procexp64.exe...
[17:25] Downloading Sysmon64.exe...
[17:25] Downloading Tcpview.exe...
[17:25] Downloading Olaf Hartong's Sysmon config...
[17:25] Starting Sysmon...
[17:25] Verifying that the Sysmon service is running...

Stderr from the command:

powershell.exe : The Sysmon service did not start successfully
    + CategoryInfo          : NotSpecified: (The Sysmon serv...rt successfully:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
At C:\tmp\vagrant-shell.ps1:114 char:3
+   throw "The Sysmon service did not start successfully"
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (The Sysmon serv...rt successfully:String) [], Ru
   ntimeException
    + FullyQualifiedErrorId : The Sysmon service did not start successfully

Link to Gist Containing Build Logs:

https://gist.github.com/spitfire55/ac9a74009ca25b998bc39fa852aa59b7

It looks like https://github.com/olafhartong/sysmon-modular recently made changes to their sysmon configuration XML. This might be the issue, but I don't know enough about Sysmon configs to confidently identify the underlying issue.

It looks like https://github.com/olafhartong/sysmon-modular recently made changes to their sysmon configuration XML. This might be the issue, but I don't know enough about Sysmon configs to confidently identify the underlying issue.

It looks like https://github.com/olafhartong/sysmon-modular recently made changes to their sysmon configuration XML. This might be the issue, but I don't know enough about Sysmon configs to confidently identify the underlying issue.

It's not that modification. Because it doesn't work with swiftonsecurity settings. And last modification for those was 5 months ago. (https://github.com/SwiftOnSecurity/sysmon-config/blob/master/sysmonconfig-export.xml)

It looks like https://github.com/olafhartong/sysmon-modular recently made changes to their sysmon configuration XML. This might be the issue, but I don't know enough about Sysmon configs to confidently identify the underlying issue.

It's not that modification. Because it doesn't work with swiftonsecurity settings. And last modification for those was 5 months ago. (https://github.com/SwiftOnSecurity/sysmon-config/blob/master/sysmonconfig-export.xml)

I think its due to Sysmon publishing version 13.0.0 today

I think its due to Sysmon publishing version 13.0.0 today

https://docs.microsoft.com/en-us/sysinternals/downloads/sysmon

https://docs.microsoft.com/en-us/sysinternals/downloads/sysmon

I think its due to Sysmon publishing version 13.0.0 today

Yeah, noticed same thing.

I think its due to Sysmon publishing version 13.0.0 today

Yeah, noticed same thing.

I think its due to Sysmon publishing version 13.0.0 today

Yeah, noticed same thing.

Definitely working with old sysmon (12.03) + old Olaf's configuration set.
I don't have ATM time to check why it fails to start with new ones.

I think its due to Sysmon publishing version 13.0.0 today

Yeah, noticed same thing.

Definitely working with old sysmon (12.03) + old Olaf's configuration set.
I don't have ATM time to check why it fails to start with new ones.

Thanks for looking into this folks. If it does turn out to be v13, I may peg the version to 12 until we figure out why it's unahppy.

Thanks for looking into this folks. If it does turn out to be v13, I may peg the version to 12 until we figure out why it's unahppy.

For anyone looking for a quick fix for this until version 13 support is resolved, you can get it running with v12 by editing the URLs to the Sysmon exe and config XML in the following file.
Vagrant/scripts/install-sysinternals.ps1
You can't download v12 Sysmon from Microsoft as far as I'm aware, but it's on archive.org.  Edit the URL on lines 77 and 80 to (changing HTTPS to HTTP on 80):
https://web.archive.org/web/20201219045111if_/https://live.sysinternals.com/Sysmon64.exe
For the config, edit the URL on line 102 to:
https://raw.githubusercontent.com/olafhartong/sysmon-modular/version-12/sysmonconfig.xml

For anyone looking for a quick fix for this until version 13 support is resolved, you can get it running with v12 by editing the URLs to the Sysmon exe and config XML in the following file.
Vagrant/scripts/install-sysinternals.ps1
You can't download v12 Sysmon from Microsoft as far as I'm aware, but it's on archive.org.  Edit the URL on lines 77 and 80 to (changing HTTPS to HTTP on 80):
https://web.archive.org/web/20201219045111if_/https://live.sysinternals.com/Sysmon64.exe
For the config, edit the URL on line 102 to:
https://raw.githubusercontent.com/olafhartong/sysmon-modular/version-12/sysmonconfig.xml

Is this still an issue for folks? It seems to be working okay for me now.

Is this still an issue for folks? It seems to be working okay for me now.


Use generator synced config for FargateProfile

Description of changes:
Use the synced.when pattern in the generator config to manage the ResourceSynced condition from the FargateProfile Status.Status.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The test is expected to fail until new ACK runtime release. I will merge this PR manually for now.


Ignore Index columns from Primary Key map.

Added  i.indisprimary to the search clause. https://wiki.postgresql.org/wiki/Retrieve_primary_key_columns

Added Unit testcase to test this scenario and ensure it works. Without this fix, the Primary key test will fail.

+2 @gbrail give me the perms for this repo.
@sramamoorthy73 merge it for now


Unable to clone the repo

https://github.com/twbs/bootstrap.git", exit code of #128 fatal: unable to access 'https://github.com/twbs/bootstrap.git/': transfer closed with outstanding read data remaining
10:51:04
10:51:04 Additional error details:
10:51:04 fatal: unable to access 'https://github.com/twbs/bootstrap.git/': transfer closed with outstanding read data remaining
10:51:04 Build step 'Execute shell' marked build as failure

Same here:
git clone git@github.com:twbs/bootstrap.git
Cloning into 'bootstrap'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

yes

Its working now

Don't think it's related to Bootstrap, it's related to your network or Github

Apparently it was a Github's infrastructure problem, they resolved after I've sent an email to support. There was no status update at https://status.github.com/messages..

Still happens, apparently is a problem with this repo when trying to execute:
git ls-remote --tags https://github.com/twbs/bootstrap.git

It's happening to me as well, when running my project's bower install:
ECMDERR Failed to execute "git ls-remote --tags --heads https://github.com/twbs/bootstrap.git", exit code of #128 fatal: unable to access 'https://github.com/twbs/bootstrap.git/': transfer closed with outstanding read data remaining

It's happening:
bower bootstrap#~3                      ECMDERR Failed to execute "git ls-remote --tags --heads https://github.com/twbs/bootstrap.git", exit code of #128 fatal: unable to access 'https://github.com/twbs/bootstrap.git/': GnuTLS recv error (-54): Error in the pull function.
Additional error details:
fatal: unable to access 'https://github.com/twbs/bootstrap.git/': GnuTLS recv error (-54): Error in the pull function.


Permit arbitrary websocket URLs

For those of us placing the OBS websocket server behind a proxy, this is kind of necessary.
For myself specifically, because of Reasons*, I can only use HTTPS to connect from my client. Running a proxy isn't difficult, but the current API of this package makes it difficult (to put it mildly) to actually establish a secure websocket connection.

* For completeness: my client runs in the browser, and due to limitations in my hosting service the page is forced to use HTTPS. Browsers will therefore prevent unsecured connections (yes, even connections that would be upgraded to HTTPS).

I feel like allowing any websocket URL while we're at it would be logical, to support a wider range of potential use cases (whatever those may be).

I have a fix for your usecase in https://github.com/haganbmj/obs-websocket-js/pull/201


Added outgoing notification of the weather module

The current weather module seems no notification emission.
Added WEATHER_UPDATED notification when new weather information is provided.
When this PR is accepted, I'll modify wiki page of MM manual.

Codecov Report

Merging #2842 (df0f048) into develop (439690b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2842   +/-   ##
========================================
  Coverage    65.15%   65.15%
========================================
  Files            8        8
  Lines          287      287
========================================
  Hits           187      187
  Misses         100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439690b...df0f048. Read the comment docs.

Hmmm... The optional chaining(?.) made the test fail.
Optional changing has been adopted as standards since NodeJS 14 and ECMA 2020 (Chrome 80 and all the current stable browsers.)
Is this not acceptable?

Hmmm... The optional chaining(?.) made the test fail. Optional changing has been adopted as standards since NodeJS 14 and ECMA 2020 (Chrome 80 and all the current stable browsers.)
Is this not acceptable?

It snot node but eslint that fails due to the optional chaining. As can be read here:
https://eslint.org/blog/2020/07/eslint-v7.5.0-released
you need to use
    "ecmaVersion": 2020

Hmmm... The optional chaining(?.) made the test fail. Optional changing has been adopted as standards since NodeJS 14 and ECMA 2020 (Chrome 80 and all the current stable browsers.)
Is this not acceptable?

It snot node but eslint that fails due to the optional chaining. As can be read here: https://eslint.org/blog/2020/07/eslint-v7.5.0-released you need to use
    "ecmaVersion": 2020

Than ks for hints.