Add alignment

Description of feature
We need both transcriptome and genome alignment for use by different modules associated with Riboseq. This can be adapted from what nf-core/riboseq does.

We ended up implementing this using fastq_align_star (subworkflow) from nf-core/modules. What nf-core/rnaseq does is a bit messy and complicated by igenomes usage which is not currently very helpful for RNA-studies.
I ended up doing a bit of work alongside to fix up that module for better transcriptome alignment handling: https://github.com/nf-core/modules/pull/4927.


Security: Boats

Create boats viewer (if neither viewer or editor is selected hide module completely)

Complete


wrong github repo link in the Rhasspy addon web page

Hello, in the HA Rhasspy addon web page there is text:
Offline voice assistant for Home Assistant.
Visit Rhasspy Assistant page for details.

but link itself points to non existing page: https://github.com/synesthesiam/hassio-addons/tree/master/rhasspy
instead of: https://github.com/rhasspy/hassio-addons

Thanks! Got it fixed now.


gofabric8 deploy to detect no ~/.kube/config is there and to download + install minikube and run minikube start?

this came up in this idea:
https://github.com/fabric8io/fabric8-maven-plugin/issues/299
it'd be nice to simplify the work folks have to do to get fabric8 going. So it'd be nice to run...
gofabric8 deploy -y

or to force minishift:
gofabric8 deploy -y --cluster=openshift

Then it'd detect no ~/.kube/config and download minikube/minishift (if not already downloaded - or update if required using the built in update mechanism), then run mini* start - passing in the right arguments (e.g. forcing xhyve on OS X if not enabled yet in minikube).
Given the context name is minikube or minishift; we should be able to know if minikube or minishift was previously created/installed so that if the cluster is stopped for any reason (e.g. the user reboots) we'd know to do the 'minikube start ....' stuff if its not currently running

we've got gofabric8 install and soon will have gofabric8 start so the deploy command could

prompt the user to install gofabric8, if Y then runs gofabric8 install
prompts the user to start a cluster; if Y then runs gofabric8 start

So that from a clean install, folks could run gofabric8 deploy and it'd just work


cmd/compile: OSX Builds cannot find libcrt0.o

What version of Go are you using (go version)?

go version go1.18beta1 darwin/amd64

Does this issue reproduce with the latest release?
N/A (1.18 Beta1)
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/karlmutch/Library/Caches/go-build"
GOENV="/Users/karlmutch/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/karlmutch/projects/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/karlmutch/projects"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/karlmutch/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/karlmutch/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18beta1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/karlmutch/projects/src/github.com/xxxxxx/xxx-xxxx/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/hv/zjrtcfqs64g1bhyh8wvx919r0000gp/T/go-build3854253269=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?

go build -ldflags="-extldflags=-static" -tags="osusergo netgo" ./cmd/kvserver
What did you expect to see?

# github.com/shirou/gopsutil/disk
iostat_darwin.c:28:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here

What did you see instead?

# github.com/shirou/gopsutil/disk
iostat_darwin.c:28:2: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:132:1: note: 'IOMasterPort' has been explicitly marked deprecated here
# github.com/fetchrobotics/sage-kernel/cmd/kvserver
/Users/karlmutch/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: library not found for -lcrt0.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Related https://github.com/golang/go/issues/50662

macOS doesn't support it.
also, that's not a Go issue
https://stackoverflow.com/questions/5259249/creating-static-mac-os-x-c-build

Thanks !  I had no idea this was the case.


Update CHANGELOG for v2024.03.26

Please let me know of any important changes that you want to make visible by adding to the Change log.

https://github.com/bazelbuild/intellij/pull/6262
https://github.com/bazelbuild/intellij/pull/6310
https://github.com/bazelbuild/intellij/pull/6030
https://github.com/bazelbuild/intellij/pull/6257


Always redeploy agent if agent deployment didn't succeed

https://github.com/rancher/rancher/pull/25290


graph vs space vs cntrl

Following does not add up with regards to 0x20 space:

Equivalence note on [:graph:] says [^[:cntrl:]].
Description on [:graph:] says "graphic characters (all characters which have graphic representation)".
[:graph:] is defined as 0x21-0xFE, and [:cntrl:] as 0x00-0x1F.

0x20 does not have graphic representation, and is not a control character, so graph being 0x21-0xFE is correct, but the equivalence note and description are inaccurate.
I haven't consulted POSIX, but I have checked grep, and graph does not catch space:
$ grep -o '[[:graph:]]*' <<<"a b c"
a
b
c
$

From looking at the referenced wiki table, it looks like there's a space in [^ [:cntrl:]]. I think it's just a typo in this README.

I think it's just a typo in this README.

It might be. Sometimes GitHub's markdown parser mangles special characters, and sometimes our tooling does. Just mentioning that in case you "fix" something and then notice it repear.

Well it looks like a typo but also the original wiki document does not
match with POSIX:

graph

Define characters to be classified as printable characters, not
including the <space>.
In the POSIX locale, all characters in classes alpha, digit, and punct
shall be included; no characters in class cntrl shall be included.
In a locale definition file, characters specified for the keywords
upper, lower, alpha, digit, xdigit, and punct are automatically included
in this class. No character specified for the keyword cntrl shall be
specified.

...which is also what I've observed with grep.

I've posted edit to the wiki page, so you should see it fixed there..

Umm, wait, i acted too fast.  [^ [:cntrl:] on the original wiki page is correct (I've reverted my edit now).


Faction members not being fully kicked, and error upon commands like /f kick, /f leave and /f ban

Please make sure your issue complies with these guidelines:.

[✓] Server Software must be the official PMMP w/o vanilla patching plugins (i.e. TeaSpoon)

[✓] Issue must have not been reported previously

[✓] Make sure you are on the latest version of PMMP & PiggyFactions

[✓] Have a detailed title.

When Factions leader try to kick a player, if the player is possibly offline. It will kick the player by his side, meaning that for the player when does faction commands it will give him no faction msg. But the player is still included in the factions info and his power is still added to the Faction Power
I joined the faction use /f admin and tried to kick the same player again and this the Error
The same error would occur when leaving the faction, or banning the same player

Expected result: What were you expecting to happen?
That the player should be kicked by the Faction and ofc completely get removed by the faction
Actual result: What actually happened?
The player got kicked by his side, but when doing /f info again it will show the player name but without any sign of any rank like recruit...

Steps to Reproduce the Issue

Kick a member when he is offline
Do /f info
3- Try to kick the same player again

OS and Versions

PocketMine-MP: 3.15.0
PiggyFactions: 1.1.2
PHP:
Server OS:

Extra Information
I would also request, to fix /f home
And to fix these issues possibly soon 👍

Unable to reproduce.


Is elm-rpl slow for you too?

Hi, newbie here!
Today I started using elm-repl and to me it feels very slow.
For example:

"hello" ++ "world"
Takes about 7 seconds to return the result

Version numbers:
Ubuntu 16.04
node v6.2.2
elm-repl 0.17.1

This is true for the very first expression. That's because it is downloading packages and building everything. After that, it has all that information, so it's faster.

@evancz I guess it would be really great to have a note in README.md that after installation the first usage might be slow because of that.

For me too.  "1+2" takes about a second on the repl. Constantly.
This is on Mac OS X Sierra.


q: regenerating help dynamically?

Hi. I'm using cli/v2 to parse commands that are typed in a REPL loop. In my use case, the list of available commands is dynamic - the user can call a command "load [foobar]" to load a new command.
Everything is falling into place, except for one thing: after loading a command, the new command does not appear in the help text. My guess is, cli is generating all help text on startup. Is there way to regenerate the help text?

OK, after messing around a bit I narrowed it down to the (*App).Setup() method.
So far, my very crude approach is to vendor and add the following method:
// Reset forces a rerun of the Setup() method.
func (a *App) Reset() {
	a.didSetup = false
	a.Setup()
}

I had a somewhat similar use case—my application has an optional config file as a command-line argument, which modifies the sub-commands and flags that are valid. Because the cli.App is stateful, I actually ended up creating and running multiple cli.Apps, which worked well enough to let me avoid vendoring the library.
The didSetup was definitely the blocker here—it's designed to prevent a cli.App from running more than once, and I'm not 100% sure why that behavior is desirable, or what's stateful in the app other than the flags that have been parsed.

After messing a bit more, I found that my Reset method also has to remove the help command, because it will be regenerated.

The challenge with that approach is that I'm not sure what all of the steps necessary are to ensure that you get an app that's 100% clean of the stateful things from the first call to Run. It might just be the call to didSetup and help, but there could be a dozen other small things you don't notice until later on.
My recommendation would be that if you're changing the app after it's been run, you probably want a factory function that returns a new cli.App with your custom parameters. Call it every time you need a fresh app. This lets you avoid forking, and re-use as much logic as makes sense for your use case.
func NewCustomApp(cfg MyCustomAppCfg) *cli.App {
  // ...
}

@rliebz you are right, this is a much cleaner approach! gonna check this out.

FYI: I ended up simply using the Command.Hidden property to show/hide commands.


Passwords are stored in plain-text in the user's session

When using the login wizard the user's password is stored in plain text in the session store. The information is stored by formtools' wizard class. This is a security risk, depending on the deployment this can easily lead to a leak. Imagine a shared database ...
The information is not required to complete the token step, it would suffice to store the authentication state once the user's username and password are verified and then call login() in the done() method.

An alternate approach I've seen there is to have a 2FA-code model with a foreign key to the user. That way, on the 2FA screen we can just call auth.login(verified_2fa_code.user) instead of auth.authenticate.

@dan-klasson you'd have to present the 2FA view to all users, regardless of the presence of a 2FA device. From a usability standpoint that would not be ideal. If your system doesn't allow users without 2FA than that would be a good solution I think.
@anlutro you'd have to check all 2FA devices in the database when a code is entered to find the right one.
The problem is not storing user information client-side during the authentication process. The problem is storing the password client-side. I have implemented the authentication such that the first step will verify the username/password combo, without logging in the user. The result of this authentication is stored in the cache for a couple minutes keyed with a random string. The string is also stored in a cookie on the client. Upon entering the verification code this cookie is used to retrieve authentication information from the cache and log the user in. It is somewhat cumbersome, but it is a general solution, although it does depend on the presence of a cache.

you'd have to check all 2FA devices in the database when a code is entered to find the right one.

Is that a big deal? If you index it the lookup should be easy. You could also do some GC every now and then to remove expired codes. Also, considering the 2FA token would be a separate model, you certianly wouldn't need to look up all devices to find it.

@anlutro you can't index that, because (at least for some devices like TOTP) the challenge is generated at the moment of verification. In the case of TOTP it includes the current time. So you'd have to generate a fresh challenge for all devices in the database for every login.
Also, generating a challenge for PhoneDevice will trigger an SMS or voice call.
Also see: https://bitbucket.org/psagers/django-otp/src/298ac18b69dfabf944e3ccef3cede6c91855b6a3/django-otp/django_otp/plugins/otp_totp/models.py?at=default&fileviewer=file-view-default#models.py-91

My bad, we actually have an intermediate step - an authentication token we wrote ourselves which has an expiry time which is provided in the URL and used to look up the correct user and device.

Hi,
I would like to ask: What is the status of this issue? Is there anything planned or any workaround that I could apply as user of the package to eliminate this security concern?
Thank you in advance.

No one has proposed any changes that won't either make things worse or will only work with Django's default auth backend.
IMO, fixing https://github.com/Bouke/django-two-factor-auth/issues/221 would possibly solve this issue too (depending on how it's implemented)

I've been noodling on this recently and would like some thoughts on the following proposed approach. I don't want to make a PR that ends up being stalled due to not aligning with the architectural desires of this project.
I think if this project switched to a authentication backend approach that this security issue would be solved. I think it would also be able to keep the goal of two-factor auth being pluggable to an extent so that other first factor auth backends can be used. I think the idea would be to have an auth backend per two-factor type since each would ostensibly take different "credentials" to perform the authentication. An ideal login flow would look something like the following:

The user hits the login form with credentials for the normal logn backend that is used, be it username and password or some other combination of credentials.
The login view, which would have to be the two-factor one or a customized two-factor one that implements the same behavior, would authenticate the user via the normal auth form. This assumes that the auth form being used authenticates the user but does not log them in as the built in auth form does.
The view would, if the form is valid, then check if the user requires a second factor of authentication. If they do, the view redirects to the appropriate two-factor auth view. If they do not, the view logs the user in and proceeds as normal.
The two-factor auth view would use the appropriate two-factor auth form to validate the second factor credentials. These credentials would match the appropriate backend that would authenticate the user. If the form is valid, I.E. the user authenticated again against the two-factor backend, the user is logged in and things continue as normal from there.

The user object cannot be added to the session until the second factor of authentication happens, as the AbstractBaseUser sets is_authenticated to True always, so the mere presence of a user in the session means that it is authenticated. This means that the two-factor backend needs to be able to retrieve the appropriate user based on the passed in credentials or some other metadata. I think this is possible based on the two factor Device having a foreign key to user, but I could be wrong.
I was inspired by the django-axes approach where they use an authentication backend to deny a user access if they exceed a certain number of failed login attempts.

Sorry for the stream of consciousness, but I just though of an additional idea that might make things even more modular.
Rather than having to override the default login views, this could potentially become middleware based wherein a custom two-factor middleware does the "is two-factor required" check after a login request, logs the user back out, and then changes the request to be a redirect to a two-factor view to perform second factor auth and final login. Combined with the auth backend approach, this would potentially become even easier to "bolt on" to existing auth systems.
The trade off is the clunkyness of log out then log back in, but since the log out happens during the same request/response cycle in which the first factor logged the user in, I think it's OK? Definitely need more research to confirm.
Either way I think you could get really crazy and get to the point where two-factor-auth-core is just the middleware piece or login view replacements to do the check and redirect. Then the combination of auth backend + view + form for each two-factor method becomes a pluggable and pip-installable two-factor-auth-*. I.E. two-factor-auth-twilio or two-factor-auth-OTP.

I looked at django-otp a bit. It looks like django-otp deliberately chose not to add an auth backend because that wasn't their project's goal. I can see how that would have influenced the design of the current django-two-factor auth. If this app is really focused on auth, I think it could potentially make sense to add in auth backends for each two-factor provider. It's potentially a bit of maintenance headache if django-otp and its associated plugins move too much, but it might be worth the effort.

How about my proposed solution:
When user successfully authenticates on the auth step instead of storing password anywhere, we:

Sign user_id using django.core.signing module, for even better security use TimestampSigner with expiry like 5 mins.

from django.core.signing import TimestampSigner
signer = TimestampSigner()
signed_hash = signer.sign(user_id)

Return signed hash to user as a cookie.
On token or backup step we simply unsign signed_hash we got from user's cookie:

signer.unsign(value, max_age=300)

Doing this we have a certainty that user with given user_id in the last 300s gave us his correct credentials and we can authenticate him if he provides correct token. No passwords stored anywhere.
What do you think?

@pbakiewicz we have a fix pending in a PR associated with a security alert, tagging this issue and putting it in the README before that fix is live was unintentional.
The going plan now is to verify the user on the 1st page, then set a (changeable) timer on the user within a certain number of minutes they have to finish the entire flow. We're just getting a 500 error in that pull request now and have Github support on it

@pbakiewicz we have a fix pending in a PR associated with a security alert, and will likely be filing a CVE, tagging this issue and putting it in the README before that fix, alert, and CVE is live was unintentional.
The going plan now is to verify the user on the 1st page, then set a (changeable) timer on the user within a certain number of minutes they have to finish the entire flow. It's difficult because the package has to support custom backends.

@nickcatal I can't find PR your are referring to. Could you elaborate a bit?
You mean adding a timer field to auth.User? When user is verified on the 1st page, the timer gets new timestamp, like delta(+5minutes), and in the second step password is not checked at all, only whether the timestamp hasn't expired?

@pbakiewicz it's a private branch being worked on and will be merged in briefly with a new release
There is a timer set when you submit the auth form, it stores a timestamp in your session, and if you do not complete the entire wizard flow within 10 minutes you're sent back to the auth form and forced to re-enter your credentials.

The fix is released in 1.12. Thanks to everyone for their contribution on this item and @nickcatal for coming up with the solution that shipped in 1.12!

Thanks!
I think this issues can now be unpinned.


Readout Mitigator Classes

What is the expected behavior?
Add Readout Mitigator classes bases on the current code in ignis:
https://github.com/Qiskit/qiskit-ignis/tree/master/qiskit/ignis/mitigation
Add the following classes:

BaseReadoutMitgator - base readout error mitigator class
CompleteReadoutMitigator - readout mitigator class based on the A-matrix inversion method
TensoredReadoutMitigator - readout mitigator class based on the tensored method
CTMPReadoutMitigator - readout mitigator class based on the CTMP method (Optional)

All classes should get as an input:

Counts object - counts result from a circuit execution
Assignment matrix(es) produced by qiskit.experiments or backend properties readout_error

and return:

quasi_probabilities (including standard deviation)
expectation_value  (including standard deviation)

The input data format of the mitigator for now can be left up to the method rather than defined in the base class such as assuming an assignment matrix.
Probably the only thing the base class needs to define is the abstract methods for applying mitigation, which as you suggest is just two methods. quasi_probabilities and expectation_value, and for querying which qubits it is defined on (ie if it was a full A-matrix for qubits [0, 2, 4] you should only be able to apply mitigation to for counts coming from measurements on a subset of those qubits).
I think initially we should just focus on the single-qubit tensor product case as the default, and maybe also include the complete case as an option. One current issue to note with the ignis tensor product code is its not as scalable as it should be. IIRC it builds the full diagonal vector as a numpy array (so that limits number of qubits to <32), and it also converts count bitstrings into ints for indexing that vector, which breaks for 64-bit count strings due to Numpy not having bigints. In these cases we need the Callable or Dict way of specifying a diagonal and applying mitigation to avoid computing the full vector. The CTMP code would need a fair bit of work to move over since all the Numba code would need to be re-written in Cython, and updated to support >64 bits which currently have the same issues due to numpy/C use.

If the goal of a base class is for things like algorithms to be able to consume different mitigators internally, then I do not see the point of the most recent changes.  Namely the way of grabbing calibration data and applying the corrections need to be the same, as does the return type(s), or at least the way they get consumed does.  Otherwise each mitigator needs to be hard-coded as is done now.
It also feels odd to attach quasi_probs and expvals to the mitigator itself.  Basically the mitigator is the A-matrix.  The action of A gets applied to the noisy counts (essentially as Ax=b) returning the desired quasi_probs.  The A-matrix does not play a role in computing the expectation values, save for supplying some bound on uncertainties, and thus having it be a method of the mitigator just seems odd.
Having said all that, I have more or less had to forge ahead with the way M3 works given that work in this direction has not progressed far in the 3 months since this issue was brought up.  The design choices there do not align with the thinking presented here, so perhaps a happy medium is out of reach.  However, as someone who is not a big fan of the monolithic nature of the algorithms, I do not think this is the end of the world anyway as the mitigators should not be consumed in the manner they are today.  Instead, they should be used mainly as part of an expval routine and the like.

closing since #6485 is merged.
we will open separate PRs to handle:

The tests framework
Incorporating the M3 method into Qiskit


migrate is not recognized

Hi, Im really new to this
I've tried to install composer require "byjg/migration":"4.2.*"
and tried to run command migrate, the result is migrate not recognized

maybe something missing?
the same issue with vendor command and others

I am closing this issue and moving the discussion to https://github.com/byjg/migration-cli/issues/8.


staslib: Add NBFT support

Codecov Report

Merging #354 (2ff077d) into main (9b99ff8) will increase coverage by 0.13%.
The diff coverage is 68.75%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   58.13%   58.26%   +0.13%
==========================================
  Files          15       15
  Lines        2286     2298      +12
==========================================
+ Hits         1329     1339      +10
- Misses        957      959       +2

Impacted Files
Coverage Δ

staslib/ctrl.py
45.43% <0.00%> (ø)

staslib/stas.py
54.26% <75.00%> (+0.58%)
:arrow_up:

staslib/conf.py
96.85% <100.00%> (ø)

staslib/defs.py
94.28% <100.00%> (+0.73%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix starwars example dependency

Fixed sample app dependency error

Git error. Command: `git rev-list --max-count=1 typeerror2.8-fix`
stdout:
stderr: fatal: ambiguous argument 'typeerror2.8-fix': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
exit code: 128
pub get failed (server unavailable) -- attempting retry 1 in 1 second...
Running "flutter pub get" in starwars...

@zirho idk if my master branch is up to date but I restored the branch for now

I checked out that it was working at the time.
Let me close this then.


IE10 size of divs in carousel 1px

Have a standard slick carousel, nothing special, with some div's inside it which each have a background image and a standard size. Every other browser except IE10 will show the content fine, so seems to be IE10 specific.

Hey @fraserjordan please provide a test case, in a fildde or codepen or something, per the conribution guidelines
Im going to close pending the test case. Thanks!


image-sequencer, infragram + web-based RPi Cam software for use with Raspberry Pi camera

Thanks for opening a pull request! In this repository, opening a PR will initiate the generation of a new Raspberry Pi image, and create an image file you can download and use in your Raspberry Pi.
The changes you add to the pull request, such as adding software to install, will be run on the generated image.
For an example, see the software installed and configured in this pull request: https://github.com/publiclab/image-builder-rpi/pull/15/files
Recipe
Use this space to describe what your "recipe" is intended to install and configure on a Raspberry Pi:

Download instructions
Generating the image will take a few minutes. Once the image is prepared, and if it succeeded, you'll see a green checkmark at the bottom of the pull request. To download the image:

click the green checkmark; you'll go to a page at a URL like https://gitlab.com/publiclab/image-builder-rpi/pipelines/########/builds
On this page, click the Jobs tab, next to Pipeline
Click the green Passed button
Click Download in the right-hand sidebar
Unzip the artifacts.zip file, and also the hypriotos-rpi-camera_web.img.zip within it
Use a program like https://etcher.io/ to flash it to an SD card

You'll also be able to read the output of the image generation in this window.
We hope to create a bot to report back the completed image URL in each pull request. If you can help create such a bot, please contact us at:
https://github.com/publiclab/image-builder-rpi/issues/16
Thanks!

@maykef here we go! Image sequencer installing here. We have to think through how it'd be used. Would all images taken be auto-processed in Node.js in the background? Or would there be a way to open any image taken in the RPi Cam software but in the Image Sequencer interface for conversion in the browser?

@tech4gt @Mridul97 check it out -- image sequencer installed on a Raspberry Pi! 😄

Downloading to test: https://gitlab.com/publiclab/pi-builder/-/jobs/115886766/artifacts/download

We should make image-sequencer runnable via URL maybe? Could relate to https://github.com/publiclab/image-sequencer/issues/198

OK, as of this morning, the latest image-sequencer has demo code that can accept a data URL via the demo url hash!
Now we should try modifying https://github.com/silvanmelchior/RPi_Cam_Web_Interface/ and Infragram to make it possible to open an image in the image-sequencer demo. Here's some code to convert an image to a data URL:
function getDataUri(url, callback) {
    var image = new Image();

    image.onload = function () {
        var canvas = document.createElement('canvas');
        canvas.width = this.naturalWidth; // or 'width' if you want a special/scaled size
        canvas.height = this.naturalHeight; // or 'height' if you want a special/scaled size

        canvas.getContext('2d').drawImage(this, 0, 0);

        // Get raw image data
        callback(canvas.toDataURL('image/png').replace(/^data:image\/(png|jpg);base64,/, ''));

        // ... or get as Data URI
        callback(canvas.toDataURL('image/png'));
    };

    image.src = url;
}

// Usage
getDataUri('/logo.png', function(dataUri) {
    // Do whatever you'd like with the Data URI!
});

Ready for download! https://gitlab.com/publiclab/pi-builder/-/jobs/116657752/artifacts/download

This now includes a button in Infragram to open an image in Image Sequencer.

:-( ok, moving to #50 !


time hero mod doesnt work

when i installed it it gave me this error

i have the same bug

how to fix that problem because also have the same


SK-Learn Pipeline containing KerasClassifier cannot be pickled/persisted

KerasClassifier gives an object that cannot be fully used with Sk-Learn's Pipeline.
The following code works:
model = Pipeline(steps=[
    ('min_max_scale', MinMaxScaler()),
    ('estimator', SVC(probability=True))
])

model.set_params(**params)
model.fit(X, y > TRUTH_THRESH)

with open(model_file, 'wb') as fh:
    dill.dump(nn_model, fh)

If I use a KerasClassifier, fails on dill.dump with a maximum recursion error. I an post the exact traceback if needed but I'd need to obfuscated the paths.
nn_model = Pipeline(steps=[
     ('min_max_scale', MinMaxScaler()),
     ('estimator', model.KerasClassifier(build_fn=model.create_keras_model, epochs=40, batch_size=10, verbose=2))
 ])

nn_model.set_params(**nn_params)
nn_model.fit(X, y > TRUTH_THRESH)

with open(model_file, 'wb') as fh:
    dill.dump(nn_model, fh). # FAILS

System information

Mac OSX
using tensoflow backend
TensorFlow version:  1.5
Keras version:  2.2.0
Python version:  2.7

This is similar to  #4274  however they were not using a Pipeline.  One user said dill worked for them with a Pipeline but it did not for me.

I think this is a feature request, not support.  #4274 didn't get a fix, just a few workarounds. Those workarounds don't work here if the intention is for KerasClassifier to be a mostly drop in replacement for another SK-Learn classifier then this is a troublesome difference

I was able to solve this for myself with a subclass of the sklearn Pipeline.  I think the general fix would be in the keras classifier, not the sklearn pipeline.
Note: quick solution assumes last step is the the classifier (decent assumption) and the unpickled pipeline has just a keras model and not a KerasClassifier because the KerasClassifier is really for exploration, not deployment.
import io
from sklearn.pipeline import Pipeline
from keras.models import load_model
import h5py

class PickleablePipeline(Pipeline):

    def _pickle_steps(self):
        steps = self.steps[:]
        classifier = steps[-1][1]
        bio = io.BytesIO()
        with h5py.File(bio) as f:
            classifier.model.save(f)
        steps[-1] = (steps[-1][0], bio)
        return steps

    def _unpickle_steps(self, steps):
        with h5py.File(steps[-1][1]) as f:
            steps[-1] = (steps[-1][0], load_model(f))
        return steps

    def __getstate__(self):
        state = super(PickleablePipeline, self).__getstate__()
        state['steps'] = self._pickle_steps()
        return state

    def __setstate__(self, state):
        state['steps'] = self._unpickle_steps(state['steps'])
        return super(PickleablePipeline, self).__setstate__(state)

@Permafacture Than you for sharing the solution. Closing this issue as it has been resolved!

Following @Permafacture solution, I ended up with a fix that acts directly on KerasRegressor (I'm interested in dump the KerasRegressor itself, not necessarily a keras model). This solution is slightly more robust, e.g. sometimes I use a TransformedTargetRegressor in combination with the KerasRegressor.
import h5py
import io
from tensorflow.keras.wrappers.scikit_learn import KerasRegressor
from tensorflow.keras.models import load_model
from sklearn.base import BaseEstimator

class PickleableKerasRegressor(KerasRegressor, BaseEstimator):

    def _pickle_model(self):
        bio = io.BytesIO()
        with h5py.File(bio, 'w') as f:
            self.model.save(f)
        return bio

    def _unpickle_model(self, model):
        with h5py.File(model, 'r') as f:
            model = load_model(f)
        return model

    def __getstate__(self):
        state = BaseEstimator.__getstate__(self)
        if hasattr(self, 'model'):
            state['model'] = self._pickle_model()
        return state

    def __setstate__(self, state):
        if state.get('model', None):
            state['model'] = self._unpickle_model(state['model'])
        return BaseEstimator.__setstate__(self, state)

I know this issue was already closed, but I thought it would be nice to share my solution.

@luisfpereira Your solution is nice, but not working in case one passes a callback. For instance,
PickleableKerasRegressor(..., callbacks=[keras.callbacks.EarlyStopping()])
will make the pickling fail with the following error:
Can't pickle local object 'Layer.add_loss.<locals>._tag_callable'


GridMap always visible even when set not visible

hi again again,
Still using the November 13 version, windows 64.
GridMaps seems not to respond the Visibility parameter, neitheir into the editor nor when the scene is played.
They remain always visible, even when the parent node is set to invisible.

Hi, is this issue still valid in 1.1 or in the current master branch?

I just tested in the current master branch. It seems to be still valid (both in editor and game). You can check it with the Platformer 3D demo (stage.xml scene).

This bug is still here in 2.0 beta. The ability of hiding Gridmaps is quite important when building large levels.

Setting "by default" to the 2.1 milestone, but if reduz or someone else wants to try to fix it for 2.0, it can of course be re-prioritized.

Not critical for the upcoming 2.1, so moving to the next milestone.

Wow this is old.

\o/
On Sep 6, 2017 6:49 AM, "Rémi Verschelde"<EMAIL_ADDRESS>wrote:
Closed #907 https://github.com/godotengine/godot/issues/907 via f43a0ef
https://github.com/godotengine/godot/commit/f43a0ef3270737d2b526480ecb0f1337ece9e041
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/907#event-1236492590, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2xlaZwnVWDkjxFvapKTCFnTNHovSks5sfmrFgaJpZM4DAaob
.

A probably related bug remains: although GridMaps can now be made visible or hidden, they do not become hidden when you hide their parent.

If you bake a lightmap in 3.2.3, this issue will pop up again


Run terraform compliance  with only a single feature test from a feature directory

Question:

Is there a way to run only one test feature file from a directory when executing the terraform compliance command?
i am able to run docker command as follows:
docker run --rm -v $PWD:/target -it eerkunt/terraform-compliance  --junit-xml TFCompliance-Report.xml -f git:ssh://bitbucket.org/xyz/tfcompliance.git -p Desktop/Repos/abc/xyz/mainplan.out.json -i .ssh/key
However if i want to run a specific feature from the bitbukcet repo on my TF plan file, i a m getting an error:
docker run --rm -v $PWD:/target -it eerkunt/terraform-compliance  --junit-xml TFCompliance-Report.xml -f git:ssh://bitbucket.org/xyz/tfcompliance/abc.feature.git -p Desktop/Repos/abc/xyz/mainplan.out.json -i .ssh/key
Error:
ValueError: Bad feature directory:ssh://bitbucket.org/xyz/tfcompliance/abc.feature
Is the -f parameter only expecting a directory and not a feature file? Do i need to always segregate the feature files as part of the directories and not on individual level ?

@eerkunt any idea on this issue?

Outside of specifying a single file to run you can get around this by tagging that specific feature file with a custom tag and then telling terraform-compliance to only run against that tag.


Export Canonical Model Zoo

The Decapodes project has accumulated a plethora of models in terms of tests, benchmarks, example scripts, documentation, experiments, and so on. These model locales benefit one another symbiotically; a model for a benchmark serves as a good experiment serves as a good test serves as a good docs page...
The value of Decapodes as a library of useful physics models is hampered by the current fragmentation of component models. The natural place to find a canonical Decapode model should come from a module of the library itself.
As a good first step to provide value, a module should be made under Decapodes.jl that exports example models such as:

[ ] Navier-Stokes
[x] examples
[ ] Physics experiments (pending appropriate publication)
[ ] test
[x] Outstanding PRs
[x] Benchmarks (e.g. CISM)

This issue serves as a first-step in an ongoing project that allows a single model specification that can be re-interpreted as documentation, a benchmark, and a re-producible physics experiment.

Closed by #193


prepare for L6

[ ] remove "minimum-stability": "dev",

I've no real idea why the event test fails now - it seems like the events aren't passed to the mocked dispatcher from inside the console command.
But even with these solutions it doesn't work.
https://github.com/laravel/framework/pull/20296
https://laravel.com/docs/master/mocking#event-fake

1) Spatie\MigrateFresh\Test\MigrateFreshTest::it_will_fire_events
These expected events were not fired: [Spatie\MigrateFresh\Events\DroppingTables, Spatie\MigrateFresh\Events\DroppedTables]
Failed asserting that an array is empty.

It's been included in Laravel since 5.5


fix(pagination): set focus only for explicitly clicked pages

Settings the focus in componentDidUpdate is for when a page button is clicked when there are ellipses included in the pagination. The buttons are re-rendered so the originally clicked button element no longer exists in the DOM, so the focus is lost. The logic in componentDidUpdate puts the focus back on the appropriate button.
However, the current logic puts the focus on the current page button when the currentPage prop is changed, which causes the Pagination component to "steal" the focus on the page incorrectly.
As such, this PR updates the componentDidUpdate logic to only set focus if a page button was explicitly clicked.

Coverage increased (+0.001%) to 99.544% when pulling 9c656f2cfa04e223d2471e9ebac55987760acc4f on astankiewicz/pagination-focus-page-select into 9a025c7702c4ebd28a318b15f7aca90c556854ba on master.

:tada: This PR is included in version 3.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


case sensitive RedshiftWorkspaceBackend::describeTableColumns

Client method RedshiftWorkspaceBackend::describeTableColumns does not convert table names to lower case and for tables with upper case characters returns 0 rows. This is not handled properly in the tests.
Eg. https://github.com/keboola/storage-api-php-client/blob/ffc816a8b1c6945ecc9b53d0038463d9955089bd/tests/Backend/Workspaces/WorkspacesLoadTest.php#L421 should also check for number of rows in the result! Empty result passes through correctly.

https://github.com/keboola/connection/issues/781


Performance improvements, serialization improvements, and added some tests

Summary
This PR includes some refactoring primarily for performance improvements.
Changes include:

Refactored Startup to make opening the WaitHandle optional for testing purposes
Refactored GetData resulting in a ~5x speed improvement and allocating about 20x less
Created Session model which allows for real-time just in time de-serialization of session data

Improved model by adding more enums

Added tests using a serialized ibt file
Introduced ReadString extension to MemoryMappedViewAccessor

This improved perf of GetSessionInfo -  10x faster, allocations 20x less)

Benchmark for old vs new GetData for a simple float int
|     Method |       Mean |    Error |   StdDev | Ratio |  Gen 0 | Allocated |
|----------- |-----------:|---------:|---------:|------:|-------:|----------:|
|    GetData |   242.2 ns |  4.34 ns |  4.06 ns |  0.17 | 0.0057 |      24 B |
| GetDataOld | 1,407.0 ns | 17.08 ns | 15.98 ns |  1.00 | 0.1354 |     568 B |

GetPosition improvements using GetData improvements and Session model.
|          Method |      Mean |     Error |    StdDev | Ratio |  Gen 0 | Allocated |
|---------------- |----------:|----------:|----------:|------:|-------:|----------:|
|    GetPositions | 30.291 μs | 0.6044 μs | 0.7859 μs |  1.00 | 5.3101 |     22 KB |
| GetPositionsNew |  9.315 μs | 0.1622 μs | 0.1437 μs |  0.30 | 1.7395 |      7 KB |

|            Method |       Mean |    Error |  StdDev | Ratio |    Gen 0 |    Gen 1 |    Gen 2 | Allocated |
|------------------ |-----------:|---------:|--------:|------:|---------:|---------:|---------:|----------:|
| GetSessionInfoOld | 3,797.6 μs | 10.07 μs | 9.42 μs |  1.00 | 398.4375 | 394.5313 | 394.5313 |  1,570 KB |
|    GetSessionInfo |   225.0 μs |  4.18 μs | 3.91 μs |  0.06 |   8.3008 |   0.7324 |        - |     68 KB |

Sorry Chris, you mind pointing your PR at dev branch?
Thanks

Sorry Chris, you mind pointing your PR at dev branch?
Thanks

No worries!

Okay, so mostly fantastic, however, irsdkSharp.Serialization is where the models are and serialization happens.
I would love to keep the central lib as close to the c++ version and then have the other bits as add-on.
We do have Data and Session models which would be prime for adjustment.

Okay, so mostly fantastic, however, irsdkSharp.Serialization is where the models are and serialization happens.
I would love to keep the central lib as close to the c++ version and then have the other bits as add-on.
We do have Data and Session models which would be prime for adjustment.

I realize this is a change to the structure, but allow me to explain why I think this is better.
With the old serialization logic, this separation made total sense, because we were taking an all or nothing approach to hydrating the models. The only way to efficiently grab individual data properties was to use the GetData method on the core SDK object. Because getting the strongly typed model was expensive, you'd only want to do it for certain scenarios.
In the new Data class, using the strongly typed model is much more efficient because we never serialize more than the specific property getter requests. It's even more efficient than GetData because we also never need to box to object or perform any logic to determine which type to make the response. Using the strongly typed model is now both the most efficient and the most convenient way to get any of the telemetry properties. Given this, is there ever a reason someone wouldn't prefer to use the model?
Regarding the design being closer to the C++ SDK, I don't think anyone would mind. Most C# developers would prefer to work with objects over requesting properties by name or lookup.
All that said, I respect that this is your project and I won't be offended if you disagree. I just think that with these changes, separating out serialization logic makes things more complicated than they need to be for arguably no real advantage other than a slightly smaller core package. If the dependency on YamlDotNet is a concern, I think we could eliminate the need for it given how predictable the yaml is for Session data.
Thoughts?

BTW, this PR can be closed in favor of #37 (although w can continue the discussion here for context)


Set TZ=UTC before calls to zip

This change allows to make the package build reproducible.

While working on the "reproducible builds" effort 1, we have noticed
that pdf.js could not be built reproducibly.
The attached patch removes timezone-varying timestamps from the
files compressed with zip. Once applied, pdf.js can be built
reproducibly in our current experimental framework.

Bug-Debian: https://bugs.debian.org/793127

/botio-linux preview

Good, thanks!

There are other callers of zip in make.js, see https://github.com/mozilla/pdf.js/blob/master/make.js#L377, so shouldn't this have been set globally instead of just in one place!?

I think this change is only useful for the XPI builds. node make publish is, as far as I can tell, and correct me if I'm wrong, only used by us to only once create the release package. We could make this change global for the sake of consistency (feel free to create a follow-up patch for that), although for the Debian people (and for how I understand the make commands) this should be enough for now.


Add super-res to the pre-processing pipeline

@nrweir commented on Wed Apr 17 2019
Potentially helpful link for making this work with GPU acceleration:
http://deeplearnphysics.org/Blog/2018-10-02-Pinning-data-to-GPU.html
Either way we'll probably want to have it able to work with both GPU and CPU versions. I'm not sure if there's currently a CPU/GPU flag in the config skeleton yaml file, but if not, we should add one.

@nrweir commented on Wed Apr 17 2019
Feel free to change any of the labels, etc. related to the issue if you want.

@jshermeyer I moved this over to the solaris repo, flagging you here so you know where it is.

I'm still open to putting this in solaris.raster instead of part of the in-line augmentation pipeline in solaris.nets if you'd rather do it that way. It would (almost definitely) be easier to do that way and create new image files rather than trying to do it in-line, would just require a little tweaking of the pipeline code to figure out how to pass those images into the model.


feat(status_listen) support HTTP/2

Summary

Previously, only support HTTP/1.1 TLS
Checklist

[ y ] The Pull Request has tests

Full changelog

[Support HTTP2]

Issue reference

Fix #FTI-4582

Once merged, will create a Doc PR.


fix(Pagination): fix wrong behaviour in case of 0 total

Closes #1205

Hello @maeshchenko.
It used to work with total = 0 like total is undefined. If you wants to change current behaviour so I think the PaginationInput can't change page when total is 0.


Explicitly include activities in the list of things not needing trademark approval in certain cases

Thanks for participating in Jupyter governance ✨
Below are a few guidelines for making your proposed change as efficient and productive
as possible.
Questions to answer ❓
Please answer the following questions along with your proposed change:
Background or context to help others understand the change.
Recently we've had some inquiries in the trademarks committee about using Jupyter logos or the word "Jupyter" in advertising activities that used or taught Jupyter.
A brief summary of the change.
This helps resolve some confusion that came up recently about when it
was appropriate to use the word "Jupyter" and Jupyter logos in advertising activities
that used or taught Jupyter. It also reemphasizes that such use must
not imply sponsorship or endorsement.
What is the reason for this change?
This further clarifies to the community appropriate uses of Jupyter trademarks.
Alternatives to making this change and other considerations.
The process ❗
The process for changing the governance pages is as follows:

Open a pull request in draft state. This triggers a discussion and iteration phase
for your proposed changes.
When you believe enough discussion has happened,
move the pull request to an active state. This triggers a vote.
During the voting phase, no substantive changes may be made to the pull request.
The Steering Council will vote, and at the end of voting the pull request is merged or closed.

The discussion phase is meant to gather input and multiple perspectives from the community.
Make sure that the community has had an opportunity to weigh in on
the change before calling a vote. A good rule of thumb is to ask several steering council
members if they believe that it is time for a vote, and to let at least one person review
the pull request for structural quality and typos.
Votes

All votes are limited in time to 4 weeks after the voting phase begins. At the end of 4 weeks, the proposal passes if 2/3 of the votes are in favor (fractions of a vote rounded up to the nearest integer); otherwise the proposal is rejected and the PR is closed. Prior to the four-week limit, if at least 80% of the Steering Council has voted and 2/3 of the votes are in favor (fractions of a vote rounded up to the nearest integer), the proposal passes.

The voting period for the PR is from 22 Aug 2022 to 19 Sep 2022 anywhere on 🌍
@afshin

[ ] YES
[ ] NO

@blink1073

[ ] YES
[ ] NO

@Carreau

[ ] YES
[ ] NO

@damianavila

[ ] YES
[ ] NO

@ellisonbg

[ ] YES
[ ] NO

@fperez

[ ] YES
[ ] NO

@ivanov

[ ] YES
[ ] NO

@jasongrout

[ ] YES
[ ] NO

@jhamrick

[ ] YES
[ ] NO

@minrk

[ ] YES
[ ] NO

@mpacer

[ ] YES
[ ] NO

@parente

[ ] YES
[ ] NO

@rgbkrk

[ ] YES
[ ] NO

@Ruv7

[ ] YES
[ ] NO

@SylvainCorlay

[ ] YES
[ ] NO

@takluyver

[ ] YES
[ ] NO

@willingc

[ ] YES
[ ] NO

@jupyter/steeringcouncil - I've opened this small change to the trademarks policy for voting. Voting ends 19 Sep 2022. This change helps clarify that activities that use Jupyter may also use Jupyter trademarks/logos without requiring approval. This helps answer queries we've received on the trademark committee, for example for training or educational activities that use Jupyter, etc.

A friendly ping to @ivanov, @jhamrick, @mpacer, @parente, @rgbkrk, @Ruv7, @SylvainCorlay, @takluyver, and @willingc to consider voting on this governance PR.

The voting period has closed, and it looks like we have 11 positive votes and no negative votes, so the PR is approved. Thanks everyone!


The latest installer defaults to aarch64 for OSX.

Describe the bug
The installer script forgets the existence of a intel OSX and fails
How To Reproduce
 ./scripts/tornadovm-installer --jdk jdk17 --backend opencl
Checking dependency: cmake-3.25.2-macos-universal.tar.gz
100% [........................................................................] 74421074 / 74421074
Checking dependency: jdk-17_macos-aarch64_bin.tar.gz
100% [......................................................................] 175929432 / 175929432./bin/compile.sh jdk-11-plus opencl

...

mvn -Popencl-backend,ptx-backend,spirv-backend clean
/usr/local/Cellar/maven/3.9.1/libexec/bin/mvn: line 195: /Users/knienart/gaia/workspace/tornadoVM.head/etc/dependencies/TornadoVM-jdk17/jdk-17.0.7.jdk/Contents/Home/bin/java: Bad CPU type in executable
/usr/local/Cellar/maven/3.9.1/libexec/bin/mvn: line 195: /Users/knienart/gaia/workspace/tornadoVM.head/etc/dependencies/TornadoVM-jdk17/jdk-17.0.7.jdk/Contents/Home/bin/java: Undefined error: 0

Expected behavior
Should work on Intel OSX.
Computing system setup (please complete the following information):

OSX 12.15.1
Tornado trunk as of today

Additional context

I think I have found what is the problem, we will provide a fix soon.

Hi @yazun, a fix is now pushed in the latest develop and master. You can try it now on your Intel OSx system. I will close this issue, but feel free to re-open it if you have any problem.


Performance tests for template tag rendering

We've not suffered any problems yet, but we should really be aim to test performance of the various template tags and make changes where necessary, to ensure reasonable performance on larger sites (potentially dealing with 1000s of pages).

I'm interested to hear if anyone with experience in this area has any suggestions for the best way to go about this... so will leave this issue open for discussion. It's very in the 'nice-to-have' category, so not an urgent thing.


Logic App Preview Designer - HTTP Web Request Save error and manual code changes

Describe the Bug with repro steps
Start the generally available designer

step create a rest request
Request Microsoft Graph API (teams with Filter)
Add the following Web Reqest https://graph.microsoft.com/beta/teams?filter=displayName eq 'Test Team' (see screenshots)
Click Safe : Error: Failed to safe Logic App Logicapp1. Definition contains invalid parameters.
Click Code view and safe then it works

Why in the preview with a correct web request an error is thrown in the designer and the saving is not possible, is already a bug and shows that the implementation of requests with filters etc. is not provided, but let's come to the actually critical problem.
Start Preview Designer

step create a rest request
Request Microsoft Graph API (teams with Filter)
Add the following Web Reqest https://graph.microsoft.com/beta/teams?filter=displayName eq 'Test Team' (see screenshots)
the save button is disabled and it cannot be saved
Click Code view: the code view on the right side opens (probably in bad scaling and only on the right edge which limits the usablility enormously) and it is no longer possible to save in the code view
Therefore also correct web requests can not be saved and used in the future

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using Preview Designer or GA Designer
Preview
Workflow JSON
No response
Screenshots or Videos

Browser

Microsoft Edge Version 113.0.1774.50 (Official build) (64-bit)
Firefox 113.0.2

Additional context
If the new preview designer is implemented in this way, manual code chancing will no longer be possible and you will have to rely on the syntax detection in Logic App to work, which unfortunately it does not.
From my point of view, this means that Logic Apps can unfortunately no longer be used in the future and unfortunately the workflows must be migrated to a product of a competitor.

@Eric-B-Wu - This seems to be a uri validation issue, can we work in the new designer to fix this?
This doesn't seem like it was working foe the customer ever since they have shown screenshots of both old and new designer, so not a regression but new bug.

Hi @jme107 thanks for creating the issue and bringing to our attention that there's a mismatch in URL validation between frontend and backend, let me confirm with our backend team and I'll try to get this fixed in our next release in the preview designer ETA  6/9

This also results in multiple problems with the new editor, as it seems like you cannot save with the mentioned characters in the URI field. In the old experience, you were able to switch to the code view and save from there.
In the new experience, the code view is squished on the left and makes reading or even working on that code impossible. Even worse, the functionality to be able to save as long as the code is valid, even when the designer has errors, seems to be gone as well.
Please keep the code view as it is now, the current design is a huge downgrade for the code viewer.

Hi @Eric-B-Wu  Thanks for your feedback.
Would it be useful to allow code view editing and saving in the new designer ? This concerns not only API request, but it is also sometimes necessary to store and save line breaks etc. in the CodeView.
Furthermore, I think it would be more practical if the CodeView opens over the whole page and not only on the right side.

This also results in multiple problems with the new editor, as it seems like you cannot save with the mentioned characters in the URI field. In the old experience, you were able to switch to the code view and save from there. In the new experience, the code view is squished on the right and makes reading or even working on that code impossible. Even worse, the functionality to be able to save as long as the code is valid, even when the designer has errors, seems to be gone as well. Please keep the code view as it is now, the current design is a huge downgrade for the code viewer.

Codeview was never visible in LA standard apps with old designer, that was a feature only for Consumption. In the new designer you could atleast view it in codeview, we will discuss with our team if we need this feature in LA standard workflows.
for now we will only track this issue for fixing the URL validation.

This also results in multiple problems with the new editor, as it seems like you cannot save with the mentioned characters in the URI field. In the old experience, you were able to switch to the code view and save from there. In the new experience, the code view is squished on the right and makes reading or even working on that code impossible. Even worse, the functionality to be able to save as long as the code is valid, even when the designer has errors, seems to be gone as well. Please keep the code view as it is now, the current design is a huge downgrade for the code viewer.

Codeview was never visible in LA standard apps with old designer, that was a feature only for Consumption. In the new designer you could atleast view it in codeview, we will discuss with our team if we need this feature in LA standard workflows. for now we will only track this issue for fixing the URL validation.

That there was no code view for Standard was already a huge issue, as there are so many bugs in the trigger and action validations that most complex workflows can only be saved in code view or via json deployment. Please don't make the code viewer even worse and duplicate existing issues, like the missing code view, with the new UI. The code viewer is an essential part of creating and maintaining logic apps and should not be treated as a secondary feature that is hard to use.


Tooltip cut off at top of screen

If the chart line is too close to the top of the screen, the tooltip extends beyond the top of the screen and is cut off. It would be nice if it would reposition itself so that it is always entirely within the bounds of the screen.

Sorry, I see that there is a flag to control this. Closing.

What flag?

What flag?

What is the flag called @ozzy1873?


Add command search externalconnection schema add

Closes #3171

Awesome work @MathijsVerbeeck. We'll review it ASAP.

Hi @plamber  @Adam-it
I've resolved the comments that you had. Could you please have another look?


fix(HMS-4809): add org_id index to domains table

As this field is present in all searches.

LGTM.  I guess we merge and watch what happens in the Stage logs :)


pubsub: add Debug to ReceivedMessage

I want to derive Debug trait to ReceivedMessage to use with structs which derives Debug trait.
Thanks for your work.

Thanks!


Missing quotes around the container names

This was causing a container to be built based on the microsoft/dotnet image and then passing in the command "microsoft/aspnet,mozilla/firefox,git/git".  When we actually want to build a container based on all of the images @ewilde nice spot!

Thanks for the update Kevin.  I'll be adding this in to other areas of the documentation as well!


statement playground

this really needs to be a discussion, however, i don't think i can do that until one exists

berd talks to tode, though tode does not like berd

tode and berd like each other

Yes! Excellent! 👏
The only bit of feedback I'd give is be careful when using 'good ( )'. There's a fine line between these two:

^ Notice how good ( ) wraps around the symbol above. But before ... doesn't.
So there's a small difference between:

Because if we break it down, we have these in the middle:

doing this top to bottom because i'm separating them out into different lines
tode and berd have an argument (?)
tode and berd have a nice chat (?)

Very close! You're getting the hang of the grammar. The fire/water above a verb changes its form.
Water above wind makes it an instruction: "Berd and tode, talk to each other!"
Fire above wind makes it negated: "Berd and tode aren't talking to each other."
You could achive what you want in a couple of ways:

so THAT'S how this means "berd, be good!"

Yeah! :D

so water above wind turns it into a command, but fire above it says that it's not happening instead of "stop doing this"?

didn't mean to close it

so water above wind turns it into a command, but fire above it says that it's not happening instead of "stop doing this"?

Can you figure out how to say, "do not do ..."? 👀

i'll try

is this "tode, do not talk to berd" or something else, if it's something else then tell me what it says, and maybe hint me to the real phrase

This says tode is doing 'not talking' to berd
Poor berd, getting the silent treatment :)
The real solution is simpler, and it involves combining multiple things together

combining 2 fires?

Hmm as your fire is inside the other fire, it means 'bad not', which I guess is open to interpretation. But probably something like...
tode is struggling to not talk to berd
You're getting closer!

moving the fire out

tode is not not talking to berd
a double negative :)
closerrrr

how is that closer with a double negative?

It's closer because you moved the top fire 'on top'!
How do you say 'do ... !' ?

yeah, that makes sense

Yeahhhhh! You got it :D

would this also work?

either way, adding "do not" to the documentation would be a good idea

would this also work?

Hmm maybe depending on the connect but with the "not" at the top it feels like
tode, do speak! not, to berd
It's more like the lack of an instruction. "There is no instruction to speak to berd"
A lot of this stuff has built up gradually over time with a couple of others who have suggested things. Over time we've found things that have issues or don't make sense, and that's where these 'rules' come from.
Yes! There's also tenses with verbs. Place a fire or water underneath a wind for that

oh god, what do the tenses do?

yeah, that's how i thought if it worked for past future, because you read bottom to top

It comes from the fact that rain is the "bringer" of things - life, growth, etc - the beginnings. And fire is the "taker" of things, destruction, etc - the endings. I believe @Magnogen first came up with that

give me something else to try to say!

There are some important verbs still like "go", and "change". And also a lot to explore with "like" (ie: similar). Oh and animals! And plurals! And questions! Hmm there's a lot... I gotta go now but have a look at the basic vocab and have a think!

blue is a location, purple shows that i'm confused on if it works, same with (?) for translating

tode go somewhere not here (?)

OR

tode go somewhere, don't go here (?)
"here" is the part i'm confused on

i think one of these could be Roughly translated into "talk to two other people" more specifically the second one could be translated to
"tode, talk to two of them"

while this one could be "talk to berd twice"

also i think one of these are "berd has sand"

berd has everything after tode has sand

it would make more sense for tode to have nothing

whoops, bot flipped

bot, do not talk to me

tode and berd like each other

i know why this works now, "tode <= do (good, have thoughts (existence)) => berd" they have good thoughts on each others existence

tode go somewhere, don't go here (?)

I don't think the word for "here" has ever been figured out. I just checked through all the discussions on the discord and couldn't find it.
I imagine here would be place of (this) or maybe place like close. Nobody's figured out 'this' or 'close' yet either.
'close' might use 'similar' in an unusual way, but that brings some issues.
'this' is hard because it feels like it could be some things that feel more like 'mine'.
I'll give a try at translating your sentence though. Looks like uncharted territory with the place you've written.
home of home of before after good/rain
Hmm, because it's so abstract sounding, it's possible that one part of that could be used for 'this' or 'close' 🤔

tode go somewhere, don't go here

tode goes somewhere. somewhere, do not go to place of rainstorm
If you want tode to be the subject of the second sentence you gotta have it connected to tode in some way.
That final word is
place of place of rain
place of rainstorm

Yes this one means
tode speaks to two of them
The like at the top means similar to itself. What's more similar to itself than itself? MORE itself. One dot means plural, more dots for counting.
One dot inside a symbol means 'all'. Two dots inside usually doesn't mean anything

Nice! You just need to change everywhere to everything
The fire on its own line there kinda means 'no' though. If we want these phrases to be part of the same idea, we gotta connect them in some way. I don't think there have been specific ways figured out for connective words like 'after' (other than 'and'), so that's uncharted territory. I think you would need some way of connecting the lines without them getting squished. There needs to be a 'like' in between the bottom 'has' and the fire. And the fire needs to be part of the same word as the top 'has'.

bot, do not talk to me

Yes that's right!

A story

omfg amazing
Reading from bottom to top:

bot doesn't speak to tode
bot goes to tode
bot and tode speak badly to each other
bot goes to berd
bot and berd speak badly to each other
bot and tode don't like each other. bot and berd like each other

bot, speak to tode!
bot goes to tode
bot and tode speak badly to each other
tode goes to berd
tode and berd speak good to each other
bot and tode don't like each other. tode and berd like each other
That's exactly what I tried to say!

How would you say "I want to go home"?

Tode wants to go to the pond?

I that's the case, would this be "I want to go home"?

I that's the case, would this be "I want to go home"?

Yes because it would be home of me

Tode wants to go to the pond?

I can't remember if 'want' had been figured out yet, but your 'want' makes sense! I'll check later if there was one already

Everything:

thing of (all)

nothing (?)

not thing

what isn't able to be made in this language yet?

tode does not know berd (?)

berd tells tode to have a good conversation with bot (???)

i would really like clarification on the prior ones

More story! with perhaps broken language

Making a wall of sticky notes

Making a wall of sticky notes

More story! with perhaps broken language

I don't know if this means "I'm glad they got along" or not, but I tried my best.

tode speaks nonsense

tode speaks nonsense
that's more like tode is speaking to nonsense, here is what I interpret as tode speaks nonsense to nobody

however, I do not believe nonsense is a concept that exists, if it does, I don't know of it

I don't know if this means "I'm glad they got along" or not, but I tried my best.

the top part looks like "I am tadpole" it fully translates to "I be before(tode)"
and the bottom is "tode and berd have good thoughts about eachother" though the 2 statements do not combine

The only bit of feedback I'd give is be careful when using 'good ( )'. There's a fine line between these two:

testing out planning now!

I don't plan to set fire to my home (?)

text-based representation
water -> -
fly -> U (winged: Ū)
tree -> |
rain -> V
fire -> ^
rain-fire -> X
wind -> ] [ =
tode -> ∩
berd -> +
bot -> O
like -> .
for example, the image above would be ∩(∩) ](VO(^))^ -(∩(∩))


Deprecate Mixins?

Hey there,
I need this behaviour in several part of our app but I don't want to drag in a dependency on mixins, since they're not gonna be supported anymore.
I was about to write another component to handle that in  a declarative fashion, but maybe you would like to have a PR here and move away from mixins?

Not "wanting to drag in a dependency on mixins" seems the wrong way to think about code that inherently relies on require calls, but more importantly I don't see any notice about deprecation of mixins anywhere in the React docs, or blog. Got a link to back up that statement?

Exactly because of ES6 classes
https://facebook.github.io/react/docs/reusable-components.html#no-mixins
I don't think it's ok to rely on babel to make use of "deprecated" features.
The trend in the community is to move away from mixins, and https://github.com/rackt/react-router it's probably one of the biggest examples.
Why would you want to stick with mixins?

I don't think you're using that word correctly. Mixins are part of React, and not deprecated. Native ES6 classes (which are not the same as React's classes), howeer, do not currently support mixins so you can't switch over to true native ES6 right now without losing features. Nothing new there, that's been the case since React was released. So: that's your choice. If you want to use native ES6, you lose some features that may be important to you (or should be, depending on your architecture), so you might not be able to switch right now. That doesn't mean mixins are deprecated, it just means React is not 100% ES6 compatible at the moment. So that's status quo: it's never been, but it's getting closer and closer. The React team's looking at how to get mixins working within the ES6 classes concept, and when they do, hurray, we can stop using babel-loader. Until then, not so much.
You perhaps don't understand why mixins exist: they're for blocks of code that impart universal behaviour to components based on functionaly that triggers during lifecycle hooks. The community is not moving away from those, although the way that functionality is achieved may in the future change so that it's ES6/7/8 compatible. At which time I'll switch this code over, but not before then.
Also React-Router is really not really a good example: it's a complex component implementation that never even made sense to try to write as a mixin, so they never did. A better example would be something like the react-draggable component, because that can be implemented as either/or. The author of that went with the component implementation, so you could try to raise that as evidence but most components like these mean you end up wrapping your real content in deeply nested "purely to achieve fuctionality" JSX tags, which is horrible to read and semantically meaningless, so if you've read any of my posts you'll know why I will say that's ridiculous and those things should have been mixins.
(relevant posts here would be http://pomax.github.io/1419289380022/so-you-re-thinking-about-using-react, http://pomax.github.io/1420592591221/taking-react-to-the-next-level-mixins-gulp-and-browserify and http://pomax.github.io/1433888478288/whose-state-is-it-anyway-further-thoughts-about-react)

I didn't use "deprecated" as in deprecated, which is why I used quotation marks, but nevertheless, I was wrong apparently.
Luckily I know the difference between ES6 classes and React.createClass, and I know what mixins are for, but I apparently misunderstood the "mixins are going away" sentiment, as the react-router guys says in the upgrade guide. Apologies for that.
Mixins are not going away anytime soon, but they are not going to implemented in future React as they are now either. The most likely candidate seems to be ES7 decorators, but we'll see.
I don't share your sentiment about the universal ugliness of wrapper components, but I guess that's my point of view there.
See you around and thanks for your time.
Cheers

ES7 decorators would be interesting, as a way to add in the parsing of the mixins array if you need it, moving some of the more complex functionality out into their own decorators.
My beef with components is twofold, really. In part it's the fact that it turns into the kind of code that is super bad for contributors to work on, like:
<Draggable>
  <VisibilityChecked>
    <ColorCorrection>
      <ImageLoader src="..."/>
    </ColorCorrection>
  </VisibilityChecked>
</Draggable>

(in the plain JS notation this is even worse; it becomes  a massive block of "nesting hell")
The other part is related to what React is supposed to be for: writing easy to read, easy to maintain UI code, with JSX syntax for easy to read, easy to write components, and using plain JS for tacked on functionality.
The idea of then writing functionality libraries as components violates that concept, because Draggable and VisibilityChecker and ColorCorrection don't impart UI, they are purely there to achieve some programmatic functionality. So the letter of the law is obeyed ("the code works, and it uses zero hacks, it's all plain React"), the spirit of the law gets completely ignored. While natural given that you always bring experience with you when you move to something new, React is different enough to go "those things do work, yes, but that's not reading up on React, and seeing how it's supposed to work and why, and then following that spirit".

I can see your point against components as a mean to add functionalities, and I agree with you that when is overdone (or over-engineered, for that matter), than it become a problem.
On the other hand, I like very much the declarative essence of it, which makes immediately crystal clear what is going to happen there.
A non existent example could be:
<OnClickOutside clickOutsideDelegate={foo}>
  <SomeOtherComponent />
</OnClickOutside>

vs.
  <SomeOtherComponent onClickOutside={foo}/>

or even worst, without any delegate, which makes it impossible from the outside to know beforehand that some magic is happening inside there.
The most common problem is, as usual, debugging someone else code, where you don't really know immediately what's going on.
Do you still prefer the "mixin approach" regarding code clarity and readability?

I'd have to say so: those examples are equally informative to me; the difference is mostly cosmetic for debugging: "things are wrong, what's my wrapper stack" vs "things are wrong, what's my mixin stack". Mixins without handlers might seem "trickier" on paper, but using reasonable debug tools (say, Chrome + the React debug tools) I haven't run into a situation where I got stuck on anyone's code yet. Plus ideally, you've written tests for your own code so you can tell if something you're seeing is your fault, or whether you need to start code diving. For small projects you don't, but then for small projects the debug tool chains available are quite good.

Hi,
have you read this [blog post] (https://medium.com/@dan_abramov/mixins-are-dead-long-live-higher-order-components-94a0d2f9e750)?
I think that way of composing components  would be nice. Then the API for this package could look something like this:
With experimental ES7 decorator feature:
 @clickOutside
 class ExampleComponent extends React.Component {
   ...

otherwise:
class ExampleComponent extends React.Component {
  ...
}

ExampleComponent = clickOutside(ExampleComponent);


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v4.19.223",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=b68f41c6320b2b7fbb54a95f07a69f3dc7e56c59"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "b68f41c6320b2b7fbb54a95f07a69f3dc7e56c59",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "hamradio: improve the incomplete fix to avoid NPD\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.19.223 by commit b68f41c6320b2b7fbb54a95f07a69f3dc7e56c59. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002790


CountdownController to show readable time

Current view for time display of countdown_controller's time in minute:second format is 2:9 instead showing 02:09, I wonder is this a bug or any reason behind this?

Hello @kwhandy ,
That's entirely on me, I wrote the Countdown controller according to my own use-case at the time which was to show the countdown in words, like I display in the examples:

But zero-padded is a very valid use-case too, so I've added this functionality behind a config flag in #351. If you set data-countdown-pad-zeros-value="true" on your element, it will now have the desired effect:

I'll cut a new release for this shortly.

whoa! tysm, appreciate the response:))


Replace yup and @hookform/resolvers with react-hook-form

Description
In efforts to make the repo lighter, we'll be dropping some redundant package dependencies. yup and @hookform/resolvers could be replaced with react-hook-form and custom validation.
Tasks

[ ] Replace every functionality implemented using yup and @hookform/resolvers with react-hook-form and custom validation.

In case this issue isn't feasible, I'm open to suggestions 😌


Selection shifts the rendering grid

I have the following setup:

Windows 11, Version 10.0.22631.4317
Neovim 0.10.2
Nvy 0.4.1 (started with --disable-ligatures)
guifont=Cascadia Code SemiLight:h11
I do not enable screen scaling -- all my screens are 100%

When I select lines, the renderer looses pixel-alignment.  You can see this on the right-hand screen's fold indicators:

@RMichelsen
I'd like to take a stab at fixing this myself, but I'm having trouble with the build chain...
My cmake output is:
PS C:\jpt\GitHub\nvy\build> cmake .. -GNinja
-- The C compiler identification is MSVC 19.41.34123.0
-- The CXX compiler identification is MSVC 19.41.34123.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.41.34120/bin/Hostx86/x86/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.41.34120/bin/Hostx86/x86/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.42.0.windows.2")
-- Configuring done (1.0s)
-- Generating done (0.0s)
-- Build files have been written to: C:/JPT/GitHub/Nvy/build

And ninja outputs:
PS C:\jpt\GitHub\nvy\build> ninja
[5/9] Building CXX object CMakeFiles\Nvy.dir\src\renderer\glyph_renderer.cpp.obj
FAILED: CMakeFiles/Nvy.dir/src/renderer/glyph_renderer.cpp.obj
C:\PROGRA~2\MICROS~3\2022\BUILDT~1\VC\Tools\MSVC\1441~1.341\bin\Hostx86\x86\cl.exe  /nologo /TP -DMPACK_EXTENSIONS -DUNICODE -IC:\JPT\GitHub\Nvy\src /DWIN32 /D_WINDOWS /GR- /EHs-c- /Zi /Ob0 /Od /RTC1 -std:c++20 -MDd /YuC:/JPT/GitHub/Nvy/build/CMakeFiles/Nvy.dir/cmake_pch.hxx /FpC:/JPT/GitHub/Nvy/build/CMakeFiles/Nvy.dir/./cmake_pch.cxx.pch /FIC:/JPT/GitHub/Nvy/build/CMakeFiles/Nvy.dir/cmake_pch.hxx /showIncludes /FoCMakeFiles\Nvy.dir\src\renderer\glyph_renderer.cpp.obj /FdCMakeFiles\Nvy.dir\ /FS -c C:\JPT\GitHub\Nvy\src\renderer\glyph_renderer.cpp
C:\JPT\GitHub\Nvy\src\renderer\glyph_renderer.h(9): error C2695: 'GlyphDrawingEffect::AddRef': overriding virtual function differs from 'IUnknown::AddRef' only by calling convention
C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\um\unknwnbase.h(125): note: see declaration of 'IUnknown::AddRef'
C:\JPT\GitHub\Nvy\src\renderer\glyph_renderer.h(13): error C2695: 'GlyphDrawingEffect::Release': overriding virtual function differs from 'IUnknown::Release' only by calling convention
C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\um\unknwnbase.h(127): note: see declaration of 'IUnknown::Release'
.
.
.
.

Any advice?

Never mind -- I added STDMETHODCALLTYPE to everything and now it builds.  I'll add that as an update if / when I succeed in fixing the issue


[Bug] Terms of service screen is skipped if network is not available when the app is opened for the first time.

Describe the bug
Terms of service screen is skipped if network is not available. Instead it skips to the survey selection screen and the terms of service screen is showed on the next app reopen.

Having a little trouble resolving this because we actually load the ToS twice, once to know whether to go to the ToS fragment, and once when the fragment is loaded. I'd like to not have to handle errors in both flows, but the sign in flow is very complex, and passing the text through the _uiState flow and Fragment args is not trivial atm. Still brainstorming options...


Misunderstanding in example

In this example here
https://github.com/Sparticuz/chromium/blob/master/examples/serverless-with-lambda-layer
On line 19 of the serverless.yml
https://github.com/Sparticuz/chromium/blob/master/examples/serverless-with-lambda-layer/serverless.yml#L19
There is a reference to chromium.zip. I'm guessing this is the chromium binary. Do I just download the correct version of chromium as a zip to use ?
That is not entirely clear to me and I've read the readme over and over. Happy to do a pull request with the answer to this question and and a readme to this example.

It is referencing the chromium.zip file made by the Makefile. Yes, that's the release zip (layer version).


[INLONG-6629][GIT] Add .gitattributes to format the files

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #6629

Motivation
Declare files that will always have LF line endings on checkout

the failed UT is not affected by this PR, it is processed by another issue.


[2.0] Remove mutability of geometries

I branched off from master, so the shapely-2.0 branch first needs to be reset to master state for this to work (the actual commit is only the last one)

Coverage increased (+0.9%) to 82.393% when pulling 84e86ce365bd7c8228b338ec06d8e2eb647b43c0 on jorisvandenbossche:shapely-2.0-remove-mutability into de4838e102dcfd54aadc8af03ed33def918334e6 on Toblerity:shapely-2.0.

@sgillies could you rebase the shapely-2.0 branch on top of master? (see also #962) Then the diff of this PR should be more correct.

@jorisvandenbossche done. You still need to rebase your own branch, right?

Thnks! Switching branches back and again also seemed to trigger GitHub

@sgillies @mwtoews this is ready for review/merge

keep (and modify) two tests to check that point and linestring geometries now have immutable .coords properties. It might be helpful to the reader to see a comment to say that these were mutable in previous versions.

Good point, will update for that.
Thanks for the review!

Added back tests for point/linestring/linearring to ensure immutability.
We now have those errors:
In [1]: from shapely.geometry import LineString

In [3]: l = LineString([(0,0), (1,1)])

In [6]: l.coords[0] = (5, 5)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-6-41687dadde5d> in <module>
----> 1 l.coords[0] = (5, 5)

TypeError: 'CoordinateSequence' object does not support item assignment

In [7]: l.coords = [(0,0), (1,1)]
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-7-dc6ae96a6b61> in <module>
----> 1 l.coords = [(0,0), (1,1)]

AttributeError: can't set attribute

which are the default errors produced by Python for a property without a setter (the first one about CoordinateSequence is already existing on master, just added to the test for completeness).
Are we OK with that test? I could also add back a setter to the coords property with a more custom error if we want that.

@jorisvandenbossche I'm fine with that. Since we're going to have a warning period, a custom error won't be necessary. If these objects had custom setters, custom exceptions would help users differentiate between Shapely usage bugs and Shapely bugs/Python usage bugs. In 2.0, trying to modify a coordinate sequence is a Python usage bug, and a type or attribute error fits.

OK, this should be good to go then!

@mwtoews @jorisvandenbossche merge when you are ready. I'm happy to let the two of you be stewards of the shapely-2.0 branch while I focus on the others.

I would be happy with managing the shapely-2.0 branch (as noted in https://github.com/Toblerity/Shapely/issues/962, I would also prefer to regularly rebase it on top of master initially), but then you will need to give me commit rights ;) (I can ensure to use them wisely!)

@jorisvandenbossche I'd lost track of that requirement and will make it so.

Thanks!


Adorner on other types of control

Hi, awesome project.
I'm using to drop files onto a UserControl, which is inside a Window. However, there are 2 issues for me:

When you drag a file into a place that can be dropped, the default behavior of most applications is to show the file icon. When I drag a file using this library, the file icon does not show.
The adorner is not shown. It seems there isn't adorners for Window, TextBox or UserControls. I'd like to show some fancy clue to user that the drop can be done.

@JobaDiniz Yes there is no default for this and I will not add this. But it's possible with the current set of interfaces and properties. Take a look at the sample. The issue #85 demonstrates this for a TextBox. Hope this is ok for you. thx

Sorry, I did not quite understand.
Regarding issue 1, is there something that I can do? Some api that I can plug into in order to show the file icon? (I've already have a code to create an image given the file extension).
About issue 2, if I understood right, I should create a class that inherits from DropTargetAdorner, is that it?


Node Interactive blog post: Correct CJ's info

Correct @ceejbot's last name and position at npm, Inc.

Thanks!


Support snake_case Json Response Configuration for Error Responses

My API currently uses the snake_case variable/field naming convention via Spring Boot Object Mapper, is it possible to support snake case rather than exclusively camelCase for json response field names (and their internal references to fields/properties)?
For example:
{
"code": "REQUIRED_NOT_NULL",
"message": "must not be null",
"property": "variableCamelCase",
"rejectedValue": null,
"path": "variableCamelCase"
}
Would become instead:
{
"code": "REQUIRED_NOT_NULL",
"message": "must not be null",
"property": "variable_camel_case",
"rejected_value": null,
"path": "variable_camel_case"
}

It is not possible out of the box, but you can do the following:

Create your own ApiErrorResponseSerializer class extending https://github.com/wimdeblauwe/error-handling-spring-boot-starter/blob/master/src/main/java/io/github/wimdeblauwe/errorhandlingspringbootstarter/ApiErrorResponseSerializer.java
Expose a bean in your application with your custom ApiErrorResponseSerializer.

The bean in your own application will normally take precedence.
E.g.:
public class MyApiErrorResponseSerializer extends ApiErrorResponseSerializer {
  public MyApiErrorResponseSerializer(ErrorHandlingProperties properties) {
    super(properties);
  }

  @Override
  public void serialize(ApiErrorResponse errorResponse,
                          JsonGenerator jsonGenerator,
                          SerializerProvider serializerProvider) throws IOException {
      // add your custom logic here, probably copying over most of the original method body
   }
}

In your own configuration class:
    @Bean
    public MyApiErrorResponseSerializer apiErrorResponseSerializer(ErrorHandlingProperties properties) {
        return new MyApiErrorResponseSerializer(properties);
    }

Do you have any more questions on this? Can I close the issue?


Relationship with symbols-view

https://atom.io/packages/symbols-view

Jump to a function/method in the current editor with cmd-r.
If your project has a tags/.tags/TAGS/.TAGS file at the root...
This package uses ctags.

Is it possible to reuse its ctags integration?
It it possible to integrate with tags/.tags/TAGS/.TAGS file?

Waiting for the completion of https://github.com/atom/symbols-view/pull/204, we can use symbols-view to get tags of a file.

See https://github.com/mrkschan/ctags-status/commit/db809982f0291983f2b46ba083654b7116041b23 on using vendored ctags from https://github.com/atom/symbols-view


feat: support configuring esbuild

A solution was discussed at the time, but there is no time to implement it, so this PR is temporarily closed.


Add 10 min timeout to Test.Hspec.Extra.it

Issue Number
#2192
Overview

[x] Add 10 min timeout to it.

Comments

bors try

bors try

@KtorZ may you also look at #2193 too, which this depends on? 🙏

bors r+


error on foreach if no unsettled transactions

php sample code errors out if no unsettled transactions.  if statement prior to foreach should read:
if (($response->getTransactions() != null) && ($response->getMessages()->getResultCode() == "Ok"))

@CTerrell  Thanks for pointing this out. We will make this update.

Since there hasn't been an update, I'm going to close this issue. If you have more information to provide related to this issue, feel free to reopen it.


Search is returning StringIndexOutOfBoundsException

Exception happens when the search returns no data.

Having fixed the StringIndex exception with  https://github.com/gchq/stroom/commit/d02692e04e98dfe961844a584050f8d4f593eebd
the dashboard now does not update the table when there are no results, it leaves whatever was in the table from the last query.  Raised #374.

Fix will be available when PR #375 is merged down to master


Opening files takes about a second or more in large solutions

Scenario:

open several *.fs files in a large solution
wait while devenv.exe stops consuming CPU
switch from the active document to another

Result: it takes about 1 second or more with freezing UI thread.

(purple areas are UI freezes)

It spends all the time in a deep recursive ParseCanonicalName call. Maybe it's a bug?

Agreed this is broken, and I've noticed this performance problem.  (BTW is that dotTrace above?)
The source code for ParseCanonicalName is in HierarchyNode.cs.  We inherited this code from the C~ project system sample.  It is recursive, and seems to scan along a linked list looking along a linked list and down a tree for a hierarchy item whose Url matches a particular name.
TO be honest I'm not even sure what the code for SelectionElementValueChangedListener.OnElementValueChanged is even doing (it's in vsintegration\src\FSharp.ProjectSystem.FSharp\Project.fs.  After finding the matching Hierarchy node based on expensive name comparisons, it then seems to throw all the information away.  I wonder what would change if we just removed the whole SelectionElementValueChangedListener
@otawfik-ms @jaredpar Perhaps you might know this?  Or perhaps @vasily-kirichenko and @dungpa you might be able to see what this is about?

Tentative fix here: https://github.com/Microsoft/visualfsharp/pull/1048

@v2m says

At glance I would there should be no harm to remove it – I don’t recall any undercover side-effects that will justify this code.

@vasily-kirichenko I tried the fix on VisualFsharp.sln and didn't notice an appreciable difference.  Could you make a repro project?  I'd imagine it depends on project size. We should really add some "big project" tests under tests\projects, perhaps you could add one that contains many small files?

@dsyme yes, it was dotTrace in "Timeline" mode (the only mode that brings meaningful results for my taste).
Yes, this issue is reproduced on a large solution (200 projects, 100 of which are F# ones). No large projects in that solution though, each of them includes up to 10-15 small to middle size files (up to 1000 lines of code, often much less), usually the projects are very small. The notable thing is that the issue is reproduced on any file, regardless of the size of a project or file itself.
I would love to test this fix, but I have always had problems with compiling VFT, actually I've not managed to make it work at all. Is there binaries to try? Should I do the testing in a VM in order to not mess up my current VS + VFT installation?

To trial this fix you should b able to just install the VSIX from the AppVeyor artifacts.  Then test the fix, and uninstall (We have a harder time testing things that invoke the F# compiler from VS or MSBuild builds, but that's not the case here.)
However the build is busted right now, so this PR didn't produce a result, fixing in https://github.com/Microsoft/visualfsharp/pull/1052

Do you mean EnableOpenSource.vsix? I installed it and now VS cannot load any F# project and shows the following error dialog:

I cannot find any mentions of any *.VSIX files in any of the guides. I remember there were steps to test VFT VS integration, which included installing EnableOpenSource.vsix.

Yes, I meant EnableOpenSource.vsix from the zip here.
It could you need to run src\update.cmd to turn of strong name checks. sn -Vr *,* might do the trick, turning them off globally on the machine.
For some reason the instructions about EnableOpenSource.vsix were dropped in a recent integration. I don't understand why. I've added them back in.

I just installed and used that VSIX OK.  Let me know if strong name checking is the problem? Thanks

sn -Vl output:
C:\WINDOWS\system32>sn -Vl

Microsoft (R) .NET Framework Strong Name Utility  Version 4.0.30319.0
Copyright (c) Microsoft Corporation.  All rights reserved.

No verification entries registered

Do I need to build VFT locally before launching https://github.com/Microsoft/visualfsharp/blob/master/src/update.cmd?

I think the only step from update.cmd you need is to turn off strong name checking.  So
sn -Vr *,*

should be enough, or add the entries one by one manually.

Wow, it works! Thanks a lot. Will profile it on my large solution soon.

Before

After

Before

After

It's a great improvement indeed, but it does not fix slowness of opening files. Look at profiler report, here I open two documents:

Select the second UI freeze:

Select the top line (Url.ctor):

Hmmm... The call to IsDocumentInProject must be coming from VS, so the only choice here is to implement IsDocumentInProject more efficiently.  Currently it looks like FindChild is doing a linear search. I'm somehow surprised that it's particularly slow because you really have to have a lot of string comparisons to make a linear search noticeable.
I'm not really sure what the best solution is here.  Using a different lookup would mean maintaining some kind of index. Perhaps we could take a look at the Roslyn Project system (which is not open source) or look a the Shared Project System code to see if there have been fixes in this area.  Or we somehow just improve the perf.

Closing this VS 2015 issue.


ADD: External link to AWS Cloudformation template using ECS and Spot

Description
Link to AWS Cloudformation template using Elastic Container Service with a Spot Instance for cost savings.
Contributions

I updated the README.md

Checklist

[ ] I added one or multiple labels which best describes this PR.
[ ] I have tested the changes locally.
[ ] This PR has a reviewer on it.
[ ] I have validated my changes in a docker container and on Ubuntu. (Only needed for Odin or Docker Changes)

@apeabody i love the CloudFormation work here, can you upgrade your readme to include instructions that would be more beginner friendly? trying to keep the barrier to entry to be low :)

Absolutely @mbround18, I just pushed an updated README.md


New middleware for Uploading files

Ok, it's not a issue. I created a middleware for uploading files, I hope it helps the community.
Middleware: https://deno.land/x/upload_middleware_for_oak_framework

Please consider adding a PR for this repo about your middleware.


Other JSValue compared to gloo-utils serde

Hi! First of all thank you for this crate! :-)
I am a WASM beginner and I am facing a weird issue. I have the following structure which I want to provide as JSValue:
#[derive(Debug, Deserialize, Serialize, PartialEq, Clone)]
#[serde(rename_all = "camelCase")]
pub struct Parsed {
    /// Wraps int64 for serde to string
    pub timestamp: Timestamp,
    pub datapoints: Vec<Datapoint>,
}

#[derive(Debug, Deserialize, Serialize, PartialEq, Clone)]
#[serde(rename_all = "camelCase")]
pub struct Datapoint {
    /// Name of datapoint
    pub(crate) name: String,

    /// A type dependent value
    #[serde(flatten)]
    pub(crate) value: DatapointValue,
}

#[derive(Debug, Deserialize, Serialize, PartialEq, Clone)]
#[serde(tag = "type")]
pub enum DatapointValue {
    #[serde(rename = "sint8")]
    SignedInt8 { value: i8 },
    #[serde(rename = "uint8")]
    UnsignedInt8 { value: u8 },
}

When I use this crate the result is as follows:
JsValue(Object({"ok":{"timestamp":"1716517538000","datapoints":[{}]}}))
When is use gloo-utils with the serde feature I get as expected:
JsValue(Object({"ok":{"timestamp":"1716517538000","datapoints":[{"name":"Level","type":"uint8","value":16}]}}))
The only thing I change is that instead of
serde_wasm_bindgen::to_value(&result).unwrap() I am using JsValue::from_serde(&result).unwrap() for the conversion after adding the extension via use gloo_utils::format::JsValueSerdeExt;
What am I doing wrong?
Thank you!

Okay this was a logging issue! Sorry!