JAXB Annotations Ignored (Default ObjectMapper behavior) for Definitions

To replicate this issue, use a data model similar to this one:
https://gist.github.com/TomDataworks/56e2b6e259fd1b971aa8
The XmlAccessType.NONE configuration requires explicit declaration of all JAXB Elements, and behaves as expected when using a JacksonJaxbJsonProvider in Apache CXF. However, when exposing the API listing via Swagger, the definitions match exactly what the JacksonJsonProvider or a standard ObjectMapper would produce.
The element marked @XmlElement(name="body") does not appear in the definition of Message. While @XmlAccessorType(XmlAccessType.NONE) is specified, any elements that are explicitly defined should appear.
There are a number of ObjectMappers in the Swagger codebase, and I am trying to track down which one is responsible for this particular task (generating the definitions).

Here's a bit of an update, which appears to solve the issue at least for me. I used the singleton class ModelConverters to add a new ModelResolver.
    @Bean
    public ObjectMapper objectMapper() {
        ObjectMapper obMap = new ObjectMapper();
        obMap.setAnnotationIntrospector(new JaxbAnnotationIntrospector(obMap.getTypeFactory()));
        ModelConverters.getInstance().addConverter(new com.wordnik.swagger.jackson.ModelResolver(obMap));
        return obMap;
    }

Upon adding this converter, the examples in Swagger-UI as well as the definitions in the swagger.json schema match what is accepted by the JAX-RS service.

It seems like we overwrote the JAXB annotation parsing of Jackson.
For now, the simple solution would be to add both Json.mapper().registerModule(new JaxbAnnotationModule()); and Yaml.mapper().registerModule(new JaxbAnnotationModule()); and it should solve the related issues.

Hi
trying to get Swagger to reflect JAXB annotations in json model both still unsucessfull trying your suggestions above. I am on release 2.0.0.
@webron When or how should I add or do the new module registrations?
Is there a test for JAXB Annotations in the source?

I assume you mean JAXB 2.0?
You can put it anywhere that loads on start up in your application. If you use BeanConfig, you can set it up at the same place. If you use the Application subclass to register your resources, you can set it there.

Hi webron -
Sorry if this is a newbie question, but can you give an example of how to add the json mapper mentioned above (Json.mapper().registerModule(new JaxbAnnotationModule()); and Yaml.mapper().registerModule(new JaxbAnnotationModule())) via BeanConfig?

@Poohie - you don't do that via BeanConfig. You can just add those two lines wherever you initialize the BeanConfig (simply copy and paste as-is, you'd need to add the proper imports as well).

@webron:  Again, sorry for my lack of knowledge here.  I really do appreciate the pointers & invaluable information!
I believe if I had used a servlet to initialize the BeanConfig, then simply adding the lines and importing appropriate packages for the json mapper would do the trick.  However, I 1) initialized using Swagger's servlet in web.xml and 2) used Spring's Bean declaration to configure Swagger (see snippets below) and not sure how to add the json mapper.
Perhaps the simplest thing is to just convert over to using a servlet?

Initialize w/Swagger servlet:

Jersey2Config
com.wordnik.swagger.jaxrs.config.DefaultJaxrsConfig

api.version
1.0.0

swagger.api.basepath
http://localhost:8080/api

2

Spring Bean declaration

Aha! Yes, if you use Spring to configure the BeanConfig, then you can't easily use that.
Those two lines can be added anywhere in your own code (that is, not configuration) that runs as part of your application start up. If you don't have any, then you'd have to create something like it.
And since you shared your configuration, I may add that you don't need both the servlet DefaultJaxrsConfig and the BeanConfig configuration together, they pretty much override each other.
You can also take a look at the Bootstrap servlet we have in our samples (https://github.com/swagger-api/swagger-core/blob/master/samples/java-jaxrs/src/main/java/com/wordnik/swagger/sample/Bootstrap.java) - that's used to initialize Swagger with more information, and that's also a place where you can put those two extra lines of code.

@webron: Eureka!  Very grateful for your guidance and expertise on helping resolve this!
In summary: Changed from using Spring bean config with Jersey to use Bootstrap servlet to initialize and configure Swagger in order to add the extra lines of code required for Swagger to recognize the JAXB annotations (which aren't automatically picked up with swagger core 1.5).

@Poohie - thanks for the update and confirmation it works.

@webron @Poohie can we close this?

@fehguy - Depends. Do we want to support JAXB annotations by default? If so, I'll fix it in the code. If not, I'll document how to add support for it.

Okay, after some additional research, we never provided full support for JAXB annotations but rather a subset of those. I believe the same subset is supported now as well.
There is a way to add full scanning as mentioned above, but we're not going to add it to the code for now. We'll add documentation for the process so that it would at least be easier for the users.

Any update on this? At least some documentation update?

The documentation wasn't updated yet, but the solution is in the thread, just read it through.

Using Resteasy of WildFly 8.2.0 with a Servlet including an own BeanConfig. Added the above mentioned module (JaxbAnnotationModule) to my JSON mapper, but no fields are exposed via swagger.json.
@XmlAccessorType(XmlAccessType.FIELD)
@XmlRootElement(namespace = "http://namespace/v1")
@AssociationOverride(...)
public class FloatPackage extends AbstractItem {

    @NotNull
    @AttributeOverride(name = "value", column = @Column(name = "FGP_NUMBER", unique = true))
    private PackageNumber packageNumber;

Did I miss anything?

Follow https://github.com/swagger-api/swagger-core/issues/960#issuecomment-100484695 and onwards please.

I am sorry, but I have read it multiple times without success. I think I still miss some small detail.
My servlet looks like the following including the registerModule from the linked comment.
public class SwaggerServlet extends HttpServlet {
    @Override
    public void init(ServletConfig config) throws ServletException {
        super.init(config);

        Json.mapper().registerModule(new JaxbAnnotationModule());
        Yaml.mapper().registerModule(new JaxbAnnotationModule());

        BeanConfig beanConfig = new BeanConfig();

What fields do you find to be missing in the output? Need some explicit examples of what you have and what you expect to see.

For example the XmlJavaTypeAdapter annotation is ignored:
@XmlAccessorType(XmlAccessType.FIELD)
@XmlRootElement(namespace = "http://namespace/v1")
@AssociationOverride(...)
public class FloatPackage extends AbstractItem {

    @NotNull
    @AttributeOverride(name = "value", column = @Column(name = "FGP_NUMBER", unique = true))
    private PackageNumber packageNumber;

The class PackageNumber:
@Embeddable
@XmlJavaTypeAdapter(PackageNumber.Adapter.class)
public class PackageNumber extends AbstractValueObject<String> {

AbstractValueObject:
@MappedSuperclass
public abstract class AbstractValueObject<V> {
    @Expose
    private V value;

XSD output:
  <xs:complexType name="Package">
    <xs:complexContent>
      <xs:extension base="abstractStockItem">
        <xs:sequence>
          <xs:element minOccurs="0" name="PackageNumber" type="xs:string"/>

swagger.json output:
    "PackageNumber" : {
      "type" : "object",
      "properties" : {
        "value" : {
          "type" : "string"
        }
      }
    },

I expect that PackageNumber gets a string in swagger.json like in the xsd.

This may actually be a problem with Jackson. First thing to try is to upgrade the Jackson dependencies to the latest, which I think is 2.5.4 and try (need to make sure the new version overrides the existing ones for all relevant dependencies).
If that doesn't work, we'd need some simple test case that reproduces the problem which we can use for further debugging.

I have tried 2.5.4 and 2.6.0-RC2 without any success. I will prepare a simple test case based on the about provided classes.

Before that, let's run a little test.
Can you add something like @XmlTransient on any of the fields? (I assume you don't use Jackson annotations at all). To be on the safe side and completely clobber it, you can put it on the field declaration, setter and getter just to be on the safe side. Then run it and see if that field disappears from the documentation.
If the property disappears, then the issue is not with the integration with Jackson but rather the Jackson parsing itself.

@XmlTransient was working after adding the JaxbAnnotationMappingModule. There was no need for @ApiModelProperty to overwrite some fields anymore, because you can hide them.

And before JaxbAnnotationMappingModule, @XmlTransient was ignore, correct?

Yes correct. Before I used @ApiModelProperty to hide information with overwritting data types.

Yeah, so as I was afraid, this is an issue with the JaxbAnnotationMappingModule Jackson component and not really within our control. I can open an issue with Jackson about it, but a simple project that reproduces it may help with further debugging there. Can't make any promises regarding to when/if this will be fixed.
For now, I believe you can overcome it by writing your own model converters, but that would indeed require extra coding from your end.

Open an issue and I will attach a sample project.

@CSchulz - thanks for opening the issue on Jackson, I was away for a while. We'll follow up on it.

Please see #1502 for info on configuring the ObjectMapper for Jackson JAXB annotation support.

@Poohie can you share the bootstrap servlet

@aymittal
Maybe you can use the servlet I used:
package com.api.rest.cool.my.base;

import com.fasterxml.jackson.module.jaxb.JaxbAnnotationModule;
import io.swagger.jaxrs.config.BeanConfig;
import io.swagger.util.Json;

import javax.servlet.ServletConfig;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;

public class SwaggerBootstrapper extends HttpServlet {
    @Override
    public void init(ServletConfig config) throws ServletException {
        super.init(config);

        // this makes Swagger honor JAXB annotations
        Json.mapper()
                .registerModule(new JaxbAnnotationModule());

        BeanConfig beanConfig = new BeanConfig();
        beanConfig.setTitle("My cool REST API");
        beanConfig.setVersion("1.0.0");
        beanConfig.setSchemes(new String[]{"https"});
        beanConfig.setHost("localhost:8080");
        beanConfig.setBasePath("/RestAPI");
        beanConfig.setResourcePackage("com.api.rest.cool.my");
        beanConfig.setScan(true);
    }
}

Once I added the line Json.mapper().registerModule(new JaxbAnnotationModule()); (as per @webron's comment), Swagger started listening to my @XmlTransient annotations — that is, it correctly started interpreting those annotations as meaning "hidden = true" .

@billforward-alex tried that and still no luck.

@aymittal I'm surprised that didn't work for you; it's working well on my end. I'm afraid I don't have any other ideas.

@billforward-alex what version of swagger are you using?

@aymittal I am using:
<dependencies>
<dependency>
		<groupId>${swagger-group}</groupId>
		<artifactId>swagger-jaxrs</artifactId>
		<version>${swagger-version}</version>
	</dependency>
	<dependency>
		<groupId>${swagger-group}</groupId>
		<artifactId>swagger-core</artifactId>
		<version>${swagger-version}</version>
	</dependency>
	<dependency>
		<groupId>${swagger-group}</groupId>
		<artifactId>swagger-annotations</artifactId>
		<version>${swagger-version}</version>
	</dependency>
	<dependency>
		<groupId>${swagger-group}</groupId>
		<artifactId>swagger-models</artifactId>
		<version>${swagger-version}</version>
	</dependency>
</dependencies>
<properties>
	<swagger-version>1.5.6</swagger-version>
	<swagger-group>io.swagger</swagger-group>
</properties>

@billforward-alex No luck still :(

@aymittal
The only other parts of my setup are:
From my Spring web.xml:
<servlet>
    <servlet-name>SwaggerBootstrap</servlet-name>
    <servlet-class>com.api.rest.cool.my.base.SwaggerBootstrapper</servlet-class>
    <load-on-startup>2</load-on-startup>
</servlet>

I believe the servlet there must be named SwaggerBootstrap.
Finally, from my Spring MVC applicationContext.xml:
<bean id="apiListingResource" class="io.swagger.jaxrs.listing.ApiListingResource"/>
<bean id="swaggerSerializers" class="io.swagger.jaxrs.listing.SwaggerSerializers" scope="singleton"/>

@billforward-alex thanks for your help but still not working.

@aymittal :( have you tried putting some breakpoints in to double-check that your SwaggerBootstrap servlet actually gets hit?
Also if you've got debug symbols or a decompiler, it's worth stepping through swagger-core's internals to see what it's doing.

@billforward-alex yes, swaggerbootstrap is getting initialized. i have checked that.

@fehguy Is there a difference between using the JaxbAnnotationIntrospector and the JaxbAnnotationModule?
        Json.mapper().registerModule(new JaxbAnnotationModule());

vs
        AnnotationIntrospector primary = new JacksonAnnotationIntrospector();
        AnnotationIntrospector secondary = new JaxbAnnotationIntrospector(TypeFactory.defaultInstance());
        AnnotationIntrospector pair = AnnotationIntrospector.pair(primary, secondary);
        Json.mapper().setAnnotationIntrospector(pair);

I know there is, but to be honest I don't recall.  I'd suggest following the technique in swagger-samples for the appropriate system.

Soved the issue. Just exclude the following dependencies from swagger dependency.
<exclusion>
<groupId>com.fasterxml.jackson.jaxrs</groupId>
<artifactId>jackson-jaxrs-json-provider</artifactId>
</exclusion>
<exclusion>
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-client</artifactId>
</exclusion>
<exclusion>
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-core</artifactId>
</exclusion>
<exclusion>
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-server</artifactId>
</exclusion>
After excluding these i was able to resolve this issue.


This still Supported?

Just wondering if this is still supported? or any forks that are supported?

I'm not having enough time to keep updating it, but I do incorporate any useful pull requests.


[spi_host, spi_device, top_earlgrey] spi_host side passthrough

[ spi_device, spi_host, top_earlgrey ] Add SPI passthrough to spi_host

- Create new corefile for spi_device_pkg
- Add passthrough structure I/O to spi_host
- Uncomment intermodule connections in top_earlgrey
- Correct typo in spi_device PASSTHROUGH_DEFAULT_REQ interhost
- Create temporary workaround for poor naming of intermodule defaults

Signed-off-by: Martin Lueker-Boden<EMAIL_ADDRESS>

Follow on to PR https://github.com/lowRISC/opentitan/pull/5948 :
Adds passthrough capability to spi_host.
Currently this PR has three commits:

spi_device commits from #5948 (will vanish from this PR once that earlier PR lands)
spi_host changes for passthrough
AUTOGEN

FYI @dsandrs, @mateenfaisal, @eunchan, @msfschaffner, @tjaychen

yeah go for it.
I'll kick off a synth tonight with updated constraints.
On Wed, Apr 28, 2021 at 9:47 PM Martin Lueker-Boden <
@.***> wrote:

@.**** commented on this pull request.
Hey Tim,
Thanks for adding that. This change LGTM, shall we merge it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/6293#pullrequestreview-647811893,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSVHGNS7XTTUUMV27JTTLDQE3ANCNFSM43PQYV4A
.


Does not fix REI tooltips

Enchantment Descriptions (version 0.6.1 for 1.18.1) item tooltips in REI are not fixed. Using ToolTipFix version 1.0.4 for 1.18.1. The enchantment used to generate such a long tooltip is from the mod "Fabric Enchantments" (Vanilla respiration should do the trick though).

In case anyone is wondering the cause of the issue, REI has its own tooltips it uses, and therefore u need an REI plugin to get this to work there. This mod could implement that without adding it as a requirement but I'm unsure how much work it would be. The REI wiki is a good resource if a tad hard on the eyes

This should be fixed in 1.1.0

I am running 1.1.0-1.19 and I am still having an issue with REI tooltips:


Add Warsaw (europe-central2)

GCP region Warsaw (europe-central2) is available but not in the tool yet.
This is because carbon data for europe-central2 is not yet available here.
It will hopefully be added to 2020 refresh of the carbon data.

(But anyway, if you are optimizing for lowering carbon impact, you probably should not select this region)

Fixed in https://github.com/GoogleCloudPlatform/region-picker/commit/c7be626a97daebd1b1f7fb9b60ca4113961b2af7


Add remaining leagues: EL1, SD, BL3, FL2

EL1: League One (England)
SD: Segunda Division (Spain)
BL3: 3. Liga (Germany)
FL2: Ligue 2 (France)
These are the only teams on the football-data API that aren't yet included.

Thanks @thurask :+1:


[MB-4636] Edit Branch in TOO Move Allowances

Description
Given that the user is TOO, they should be able to change the branch associated with a moveOrder, and thus change the branch affiliation on the Service Member associated with a moveOrder.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
make db_dev_e2e_populate
make server_run
make office_client_run

In the Move Orders Queue, click in to the move Details page > Edit Allowances > Change Branch > Save
Updated branch should show up in Allowances under Branch, rank
Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

Messages

:book:
:link: MB-4636

  Generated by :no_entry_sign: dangerJS against 5a7c06a7867774e61782a55dc9aa9739f8b85991

@noelledusahel PR Looks good, can you make a minor edit to the tooFlows.js cypress test with the branch being updated? https://github.com/transcom/mymove/blob/master/cypress/integration/office/txo/tooFlows.js#L183

Looks good and seems to function properly

@brooksr4 can you tae a look at the happo diff


Fails when doing the callback with COPY_META

Hi,
I am trying to bind to an NFQUEUE configured with COPY_META only, as I only intend to retrieve the packet mark. I would think that maybe when a Packet() is created, we should indicate the operation mode of the queue somehow...
I'm using the latest version of the code :)
Exception ignored in: 'netfilterqueue.global_callback'
Traceback (most recent call last):
  File "netfilterqueue.pyx", line 69, in netfilterqueue.Packet.set_nfq_data (netfilterqueue.c:2193)
OSError: Failed to get payload of packet.

Bump. I saw this too, last night, after updating my local copy. I think it's an important one because a lot of users might be able to get around the static buffer size by just copying/modifying/updating headers, but because this doesn't work, some users will need to modify the pyx file and recompile.


Synchronization accounts from B2C to Salesforce Platform does not work with shared customer list

Synchronization accounts from B2C to Salesforce Platform does not work with shared customer list
I've executed all the commands from readme file, seems like everything went correct. However, whenever Log in, Checkout, or Job is trying to synchronize the accounts from B2C to Salesforce Platform, the result is "successful" but the accounts are not being synchronized. I found this in the Job log:

[2022-09-21 16:17:20.146 GMT] INFO CustomJobThread|444767850|B2C CRM Sync: Export customers|SynchronizeCustomers Successfully exported the customer profile. Here is the response body: {"actionName":"B2CContactProcess","errors":null,"isSuccess":true,"outputValues":{"Account":null,"errors":["Unable to verify the B2C CustomerList.  Please check the properties of the sourceContact -- and try again."],"Flow__InterviewStatus":"Finished","Contact":{"attributes":{"type":"Contact"},"Email":"i.melnyk@astoundcommerce.com","FirstName":"Ivan","LastName":"Melnyk"},"isSuccess":false}}

The Job is green (no errors shown), "isSuccess":true , however the "errors" in "outputValues" says a completely opposite status: "Unable to verify the B2C CustomerList.  Please check the properties of the sourceContact -- and try again."
How it should be fixed?
To Reproduce
Steps to reproduce the behavior:

Create an account from storefront, or Run the Job for existing accounts
Observe the status of synchronization in the Customer Profile custom attributes (in SFCC BM)
Observe the status of the Job
Open the Job Log and observe the status of the Job in "outputValues".

Expected behavior
The Accounts are synchronized, or if there any error occurred - it should be clearly shown in the profile attributes and/or in the Job status.
My local environment details:

Node version (node -v): v15.2.1
NPM version (npm -v) v7.0.8
SFDX version (sfdx -v) sfdx-cli/7.168.0 win32-x64 node-v15.2.1

My remote environment details:

Salesforce B2C Commerce version: 22.9
Salesforce Core version: 56.0

Screenshots
https://prnt.sc/212UHlsLC61V
https://prnt.sc/BpQ-2tqfECMm

Seems like deploy command was not properly executed, so I've ran it again . Also I've created a separate customer lists for each of my site and reassigned the sites, tested and it worked. Then I've reassigned back all my sites to the one customer list and it was still working, so I'm not sure what is fixed this issue but it is not actual any more. After that, I did the same deploy to another sandbox and it worked.


HDDS-4277.  Support Bucket Namespace Quota Updates

What changes were proposed in this pull request?
add namespaceQuotaUsage and update it when create and delete key in a bucket
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4277
How was this patch tested?
UT

R @captainzmc

@captainzmc @linyiqun comments addressed. Can you take a another look please?

@captainzmc
Comments have addressed and CI has passed.

Merged this. Thanks for @amaliujia's patch, and thanks for the review of @linyiqun


Replace "inPort" and "outPort" in Blocks' documentation

Reported by dietmarw on 2 Jun 2014 22:36 UTC
The documentation of Modelica.Blocks.Discrete and Modelica.Blocks.Nonlinear still makes use of the terms "inPort" and "outPort" although those concepts have been long deprecated (Modelica version 1 I think). They should be replaced by the proper usage of "input" and "output"

Migrated-From: https://trac.modelica.org/Modelica/ticket/1502

Comment by otter on 11 Dec 2015 14:17 UTC
Fixed in 5c28f44a0173c7c1752c2ad8460846cbc537d2fb

Changelog modified by otter on 11 Dec 2015 14:17 UTC
Corrected wrong inPort/outPort by the correct input/output text in the documentation of Discrete and Nonlinear blocks


Improve Tagging

[ ] Type ahead
[ ] Better visual using Labels
[x] Reduce duplication in database

The existing implementation of taggables already reduces duplication in database.


Always create/update DepartmentUser objects with email lower-cased. On delete in AD, set ad_guid field to None.

This change is

Coverage increased (+0.009%) to 49.238% when pulling e219ace187a0ba15b54375931cba5361cb05fc3d on ropable:prod-oldui into 23791ad968233961f909391abc8dcebe1d0877b2 on parksandwildlife:prod-oldui.


Messages: The wrong value is displayed for user 'Last Seen:'

Open FP app and login using valid email/pwd
Navigate to inbox; ensure you have test account to verify the actual last seen value.

Issue: You will observe that user was seen a before only , but system sayd 'Last seen :2 days ago'
Refer below screenshot

@rabbi08 , i think the last seen seem is the person who access the inbox to read the message.  since outbound and inbound msg share the same thread.  I take the screenshot and please check if you see it makes sense.

@rabbi08 , i think the last seen seem is the person who access the inbox to read the message. since outbound and inbound msg share the same thread. I take the screenshot and please check if you see it makes sense.

@adorapham
But why we should display the 'Last seen as' when that user send me message, why not actually. as its user's status nothing related to who he sends message right?
like in Whatsapp if user is online, its online whether they send me message or not, and even if they send me message their last seen is when they were online , activity done or not done doesn't matter.
Do you think that this is not real time status of the user which is wrong?

@rabbi08 i will try to explain what i understand , it might be wrong.  when i see last seen --never . I think the message i send to that person but that person is not reading yet, so that show me status reading message sending from me to that person - never (mean not read).    Last seen 10 min , that mean the person just access the thread message from me to that person  10 min ago.
if that person access the message to re-read again , the last seen start to reset. that is what i understand .  but we can wait to find out from developer

Sure, I think any user's 'Last seen:' timestamp should reflect when that user logged off last. This should be irrespective of whether that user responded to person-a or person b or not responded to anyone.

@rabbi08 @adorapham @tejasm2 - last seen should be to the conversation thread itself. you could have seen inbox at 10:00, then navigate to helpboard at 10:01 and click around there or other parts of the site until 10:10 when you log off.
last seen should still be 10:00 even if logged off at 10:10.
@Zaydme  can you confirm? i do see a bit of a delay with it but didn't se serious issue- but i don't think i was testing as thoroughly as rajbir or adora :)

Current last seen is set to the last time the user entered the conversation itself, not the website or thread.
So if I see last seen 10 minutes ago, this means the last the user clicked on that conversation to read my messages was 10 minutes ago.
But we can change this behavior to when the user turns offline (loggs of or closes the website)

Current last seen is set to the last time the user entered the conversation itself, not the website or inbox page.
So if I see last seen 10 minutes ago, this means the last time the user clicked on that conversation to read my messages was 10 minutes ago.
But we can change this behavior to when the user turns offline (loggs of or closes the website)

I would like to suggest that we should show the 'Last seen' like on social media sites like 'Whatsapp' if user is in Whatsapp, they are online and accordingly the time of 'Last seen:'
Thanks


Color wheel is inverted

Hi!
I'm having an issue with my Neopixels where everything works, but the color wheel seems to be inverted on the HomeKit app. I'm using the Pixels example and RGBW configuration.
By inverted I mean it just seems to be flipped horizontally, and when I pick green on the app, the neopixel lights up red.

By coincidence, @frankonski just posted a similar problem.  See #781 for discussion and expected solution.  Which specific Neopixel are you using?

Oh! I didn't see it on mobile, my apologies. I'll follow that discussion. I'm only using 1 neopixel, this one:
https://shop.pimoroni.com/products/ultra-bright-4-watt-chainable-rgbw-neopixel-led-warm-white-3000k?variant=39432816427091

Thanks for the link --- it seems the protocol for this chip is indeed reversed from the protocol I used in the Pixel library.  Should be able to address shortly.

@honear, please see update in #781

Since everything seems to be working with the update in the dev branch I'll close this issue - please feel free to re-open if needed.


Change out link in the welcome text

At the moment, we link to https://codebuddies.slack.com/files/U0G92F4J0/F8VRAGD0S/CodeBuddies_Slack_Etiquette_for_General_Members in the welcome text.
Non-admin users aren't able to see this link, unfortunately. We've cross-posted the same content (with additional guidelines about promoted posts) to https://codebuddies.org/slack.
TODO:

Change out https://codebuddies.slack.com/files/U0G92F4J0/F8VRAGD0S/CodeBuddies_Slack_Etiquette_for_General_Members to be https://codebuddies.org/slack

The file to edit: https://github.com/codebuddies/greetbot/blob/9fb6a4a0c105d0f61f0d89e8b1778912dad2828e/src/app/routes/endpoints/events/initial.js

@lpatmo If no one has indicated interest, I'd love to work on this.

Marked this as 'claimed' for you.
Btw, are you interested in participating in Hacktoberfest this year? If you open up the PR between October 1st - October 31st, it can count towards one of the five PRs you need to get a free t-shirt from the Hacktoberfest organizers. :)

Lol, that's tempting.

Hey, is this being worked on? Hacktoberfest site reccomended this repo, and it's JavaScript, so I would love to steal it to take this on if the other user isn't interested still

This is claimed by @peoray.
If nothing has been done by next week, it will be marked as unclaimed @cfanoulis

#97


Add AddControllers() and AddRazorPages()

These are new style for configuring MVC in services. We're adding these to make
things feel a bit more tailored to those particular scenarios.

The main reason for this is that we've had repeated community asks for an
API-optimized way of configuring MVC. I don't think that using AddMvcCore
is a suitable building block, because it has too many options that you want.
I've think I've identified the reasonable set of features that should be part
of the default experience for APIs. All of these things are already pay-for-play
and are activated by the presence of attributes. The only additional cost is
loading of assemblies and a few additional inspections of the attributes
(cached).

Given that we're creating AddControllers, it makes sense that we'd flesh out the
rest of the space that folks are saying but what about me???.
Edit: (and then there were three)
You can either:

AddControllers
AddControllersWithViews
AddRazorPages

These are all top-level service collection methods, that return the existing IMvcBuilder. You can use multiple of these. If you end up using AddControllers and AddRazorPages you will end up with what AddMvc does today.
If you do multiple things to multiple different MVC builder instances, then they run in the order you specified - like what would happen if you use AddMvc multiple times in today's landscape. You can't have separate model binders for controllers and pages, or things like that.
Small note - AddRazorPages includes the non-API-focused support for controllers. We'd have to do significant work to take this out. Will do it in the future based on user feedback.

Branding and perception are important, and we've had users ask for more flexibility
in what shows up in their app. The plan is to update the templates to use this experience
in preview4, and see what kind of feedback we get.

@ryanbrandenburg @pranavkm - can you please take a second look at this? I changed how this works based on feedback from @DamianEdwards  and @davidfowl and updated the PR description

Code check failed

Code check failed

That is probably true.

@pranavkm any more feedback?

:shipit:


Better way of writing input validations

For input validations, there are lots of cases of:
if (foo) {
    return jstr({'error: 'description'})
}

Figure out a better way for input validations

Legitimate.
We have added the ZoomBA assertions into the mix.
For JSR we shall also add them as higher functions.
If one can see the route of :
get:
   /error: _/error.zm

In there we are simply doing:
panic(true, "boom!", 418 )

As per the latest commit. This should do it.

b62699a7 Fixes this


Error when ''pip install -r requirements.txt''

Hi @sshaoshuai , thanks for your excellent work! However, when I install packages in requirement.txt. It shows error:
Requirement already satisfied: numpy in /home/lion/anaconda3/envs/pcdet/lib/python3.7/site-packages (from -r requirements.txt (line 1)) (1.18.1)
Requirement already satisfied: torch>=1.1 in /home/lion/anaconda3/envs/pcdet/lib/python3.7/site-packages (from -r requirements.txt (line 2)) (1.1.0)
ERROR: Could not find a version that satisfies the requirement spconv (from -r requirements.txt (line 3)) (from versions: none)
ERROR: No matching distribution found for spconv (from -r requirements.txt (line 3))
I am confused that why it says can not find a version for spconv.
My server and Anaconda environment: Ubuntu 16.04, python 3.7, pytorch 1.1.0
Hope get help from you, thanks!

you need to install spconv before running pip install -r requirements.txt
How you have to install it is explained in the readme just below the line of pip install -r requirements.txt.

Hi @MartinHahner88, thank you for timely answer! I will try to install spconv first. Thanks.


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

3ee04fe: Nothing changed, just experimenting with preview publish

<EMAIL_ADDRESS>Patch Changes

3ee04fe: Nothing changed, just experimenting with preview publish
Updated dependencies [3ee04fe]

<EMAIL_ADDRESS>

<EMAIL_ADDRESS>Patch Changes

3ee04fe: Nothing changed, just experimenting with preview publish

📣 NOTIFICATION
You are receiving this message because we did not publish any packages.
Generated by @thefrontside/actions


[FEATURE] auto-level the main output loudness

Hi!
I tried using the standalon application and I am a bit frustrated the same way as when I got one IR pedal (cuvave). The problems on adjusting volumes of different patches.
I believe that in the future we will have AI engines that would adjust that and make possible the use of totally different presets in a smooth change between all of them.
For now, my suggestion would be an "auto level" in the main output of the standalone application, that would boost or decrease the volume to some sort of "ideal output level".
I am aware that this can be quite hard to make, but even if there's some way of avoiding a really loud preset take place when I'm testing all of the amazing ones available here, it would be great.
This is my first ever github interaction and I hope it can be useful. I really liked the project and I believe it will have a huge impact in the amp modeling systems.

No, this is great--and something I've been meaning to do! (Could've sworn there was already an Issue, but I just checked and I don't see it?)
Version 0.5.1 of neural-amp-modeler will define a new "metadata" part of the model file, which will include a "loudness" value. The intent is to use this value in the plugin to scale up or down the model's output and keep things consistent.

...and done!
There are a few PRs in NeuralAmpModelerCore that I'd like to get sorted first as a courtesy to my collaborators, but this should be in the next release! 😄


Fix builing nuspell[tools] on Mingw

Describe the pull request

What does your PR fix?
Fixes building port nuspell on mingw triplet.

Which triplets are supported/not supported? Have you updated the CI baseline?

All, Yes

Does your PR follow the maintainer guide?

Yes

Already tested feature tools on x86-windows.


Bug: Typemismatch while computing a G1Element value.

What Git revision are you using?
v1.0.24-alpha+46c357d
What operating system are you using, and which version?

[ ] Linux / Ubuntu
[X ] Linux / Other
[ ] macOS
[ ] Windows

Describe what the problem is?
Hello dear Aiken team! Curretly we are working on a library that verifies a zk proof following the Groth16 protocol. The Aiken compiler raises a bug error when performing a test on the verification function.
The source code that raises the problem it is the following (link):
use aiken.{G1Element, G2Element}
// ,MillerLoopResult
use aiken/builtin.{
  bls12_381_final_verify, bls12_381_g1_add, bls12_381_g1_scalar_mul,
  bls12_381_g1_uncompress, bls12_381_miller_loop,
  bls12_381_mul_miller_loop_result,
}
use aiken/list.{head, map2, reduce, tail}

pub type SnarkVerificationKey {
  nPublic: Int,
  vkAlpha: G1Element,
  vkBeta: G2Element,
  vkGamma: G2Element,
  vkDelta: G2Element,
  vkAlphaBeta: List<G2Element>,
  vkIC: List<G1Element>,
}

pub type Proof {
  piA: G1Element,
  piB: G2Element,
  piC: G1Element,
}

pub fn pairing(g1: G1Element, g2: G2Element) {
  bls12_381_miller_loop(g1, g2)
}

pub fn groth_verify(
  vk: SnarkVerificationKey,
  proof: Proof,
  public: List<Int>,
) -> Bool {
  // let n = vk.nPublic

  let eAB = pairing(proof.piA, proof.piB)
  let eAlphaBeta = pairing(vk.vkAlpha, vk.vkBeta)

  expect Some(vkICHead) = head(vk.vkIC)
  expect Some(vkICTail) = tail(vk.vkIC)
  let derived_vkIC = map2(public, vkICTail, bls12_381_g1_scalar_mul)
  let vkI = reduce(derived_vkIC, vkICHead, bls12_381_g1_add)
  let eIGamma = pairing(vkI, vk.vkGamma)
  let eCDelta = pairing(proof.piC, vk.vkDelta)

  let mlr1 = bls12_381_mul_miller_loop_result(eAlphaBeta, eIGamma)
  let mlr2 = bls12_381_mul_miller_loop_result(mlr1, eCDelta)
  bls12_381_final_verify(eAB, mlr2)
}

// Test (3 Factorial problem)

test groth_verify_1() {
  //  Template of VK
  let vk: SnarkVerificationKey =
    SnarkVerificationKey {
      nPublic: 2,
      vkAlpha: #<Bls12_381, G1>"8e3d9e248feda194cb6fa0a3b64fd2a380cb5e94836bf8148bf97ebcbb5819d9a78f63102f0293c104bcbb2f810d8eb4",
      vkBeta: #<Bls12_381, G2>"8cd68a7186a908212680a0234d8210c20328f8fb3ce1d69c9aec9330a5802d6cfaf6d7cf3176133221c19188590cb4141874ea7bbfcb9872931e115d882c46b90c3dcbcee10062d1c9b9b0a691d7bec7d2735f06495c7f71dea210e55b2782df",
      vkGamma: #<Bls12_381, G2>"93e02b6052719f607dacd3a088274f65596bd0d09920b61ab5da61bbdc7f5049334cf11213945d57e5ac7d055d042b7e024aa2b2f08f0a91260805272dc51051c6e47ad4fa403b02b4510b647ae3d1770bac0326a805bbefd48056c8c121bdb8",
      vkDelta: #<Bls12_381, G2>"938231fcec443fbdeb1079ff126b8f69bd8579ffe82d39923214d4345395beee60200288fa20c97ae50f3212131b6f8802af2f9f515c65af6a9a6c294c738590104376a0af44731d6699db6a286608774243f7d1dddc4605eb340e65e15060a5",
      vkAlphaBeta: [
        #<Bls12_381, G2>"93e02b6052719f607dacd3a088274f65596bd0d09920b61ab5da61bbdc7f5049334cf11213945d57e5ac7d055d042b7e024aa2b2f08f0a91260805272dc51051c6e47ad4fa403b02b4510b647ae3d1770bac0326a805bbefd48056c8c121bdb8",
      ],
      vkIC: [
        #<Bls12_381, G1>"b5813c90d3455acb8608fdf66e8601f24ef048f3fdf9384862d77c72cb5cddfde2b307976b1b0319c42ba985f94be60a",
        #<Bls12_381, G1>"a41a0e6370c054be0f9acce08e97f6d5702d9daa9e9a934e8a377f553593baa1c58062adc73d63558653422d54d6f50c",
        #<Bls12_381, G1>"8e02a87c519c3145f984d25fdf769f74fbc36626c385d4554fb4bc1d7a12cbf669d40f257023b8b3c9a31e631aa8f981",
      ],
    }

  //  Template of Proof
  let pk: Proof =
    Proof {
      piA: #<Bls12_381, G1>"b28cb29bc282be68df977b35eb9d8e98b3a0a3fc7c372990bddc50419ca86693e491755338fed4fb42231a7c081252ce",
      piB: #<Bls12_381, G2>"b9215e5bc481ba6552384c89c23d45bd650b69462868248bfbb83aee7060579404dba41c781dec7c2bec5fccec06842e0e66ad6d86c7c76c468a32c9c0080eea0219d0953b44b1c4f5605afb1e5a3193264ff730222e94f55207628235f3b423",
      piC: #<Bls12_381, G1>"886a574105c0da95915c36025637e5b80c7c00c4a264b529b465c273ade3e38f15dc7840498a1aefb44a24a0070a2ff6",
    }
  // Template of public values
  let public_values: List<Int> =
    [562, 3]

  groth_verify(vk, pk, public_values)
}

When perform aiken check it raises this problem:
   aiken::fatal::error
   Whoops! You found a bug in the Aiken compiler.

   Please report this error at https://github.com/aiken-lang/aiken/issues/new.
   In your bug report please provide the information below and if possible the code
   that produced it.

   Operating System: linux
   Architecture:     x86_64
   Version:          v1.0.24-alpha+46c357d

   crates/aiken-lang/src/gen_uplc.rs:4955:73

       called `Result::unwrap()` on an `Err` value: TypeMismatch(ByteString, Bls12_381G1Element)
   ak-381   git:(feature/point-conversions)

What should be the expected behavior?
The test to pass or to fail.

@MicroProofs so I looked into this and it seems like during code gen for some reason bData is being called on a G1Element

@MicroProofs nevermind I think I know the problem
@AgustinBadi you can't use G1Element and G2Element in data types because they are not representable as PlutusData

Excelent, we manage it to compile, thank you very much! <3


initial implementation

For use in https://github.com/nats-io/nats-server/pull/4821

Going to merge this, so I can update the server PR with the @latest reference


How to use this extension?

I installed this extension because I thought the default Rust syntax highlighting was lacking in VS Code, but I can't figure out how to get VS Code to use it. I also have the official rust-analyzer extension installed, and I saw #1, but I'm confused as to how to change the grammar association for Rust. I tried disabling the VS Code builtin Rust syntax extension, but now Rust files have no highlighting at all. Any ideas?

Hi, @dbeckwith. If you have enabled Rust Analyzer, then you don't need this extension. My grammar is merged into Rust Analyzer, and RA's grammar will overrides others when it starts. However, you won't see highlighting based on Textmate scopes unless you have semantic highlighting disabled in VS Code.

Hmm okay, could it just be an issue with my theme then? It seems like most things are colored yellow in my theme and there isn't enough variation. I'm using the Cobalt2 theme.

The Textmate grammar only provides the scopes. If you don't like the color applied to one of the tokens, you can override it in settings.json. It just happens that your theme is using the same color for storage, entity.name..., and function. You can see the scope names for customization using Developer: Inspect Editor Tokens And Scopes.

Okay thanks, I'll try customizing it. Do you have an example theme that assigns different colors to the different scopes that I could try to verify that it's working? Like the one in the screenshot in the README?

My Yarra Valley theme should work. There is a screenshot of Rust code in the README.

Thanks!
With your theme I think I was able to find a parsing bug haha. The macro metavariable type path looks like it's being parsed as pat:

Thanks for catching that—I have pushed a fix.


feat(storybook): switch to next gen storybook

[ ] Rework all existing stories and double check if all functionality is available
[ ] Delete old *.stories.js files (may be hidden from vscode)
[ ] Migrate missing stories
[ ] Fix typography docs
[ ] Check if all slot documentations exist

Proposed Changes
Uses the latest storybook (html), generates custom-elements.json to retrieve prop, slot.

I've just removed the ino- prefix of every property. Now it's time to upgrade our component's stories to the new storybook (see below).
I did not check yet which components stories might be migrated already.
@janivo:

[ ] ino-button
[ ] ino-card
[ ] ino-carousel
[ ] ino-carousel-slide
[ ] ino-checkbox
[ ] ino-chip
[ ] ino-chip-set
[ ] ino-control-item
[ ] ino-datepicker
[ ] ino-dialog
[ ] ino-fab
[ ] ino-fab-set
[ ] ino-form-row
[ ] ino-header
[ ] ino-icon
[ ] ino-icon-button

@AlessaRad:

[ ] ino-img
[ ] ino-img-list
[ ] ino-input
[ ] ino-input-file
[ ] ino-label
[ ] ino-list
[ ] ino-list-divider
[ ] ino-list-item
[ ] ino-menu
[ ] ino-nav-drawer
[ ] ino-nav-item
[ ] ino-option
[ ] ino-option-group
[ ] ino-popover
[ ] ino-progress-bar
[ ] ino-radio

@pfecht

[ ] ino-radio-group
[ ] ino-range
[ ] ino-segment-button
[ ] ino-segment-group
[ ] ino-select
[ ] ino-sidebar
[ ] ino-snackbar
[ ] ino-spinner
[ ] ino-switch
[ ] ino-tab
[ ] ino-tab-bar
[ ] ino-table
[ ] ino-table-cell
[ ] ino-table-row
[ ] ino-textarea
[ ] ino-tooltip


Wallet users SBAT see tobin tax on exchanges

Expected Behavior

Update Exchange Confirmation Screen

"Fee" is now split into "Exchange Fee" and "Security Fee"
Add More Info buttons for each

Add Exchange Fee dialog (new)

Figma Link
Current Behavior
Exchange Fee dialog doesn't exist. Security Fee dialog exists, but isn't linked. Exchange Confirmation screen doesn't include Exchange Fee.

Added designs.

@coreycelo can you provide the new image for Fee exchange information view?

@Pedro-vk Yep, available here:
Figma Link


Add gpt4o-mini

https://github.com/dongri/openai-api-rs/pull/98
I added it a few hours ago.

Please add only this:  gpt-4o-mini-2024-07-18 .

its fine actually i dont use it, haha just was trying to follow your file. just dont merge this, i only use the shorter version anyway.


Schedule to start on sunday and only to be stopped on friday

I want to schedule the instance with the start time on the sunday say 18:00 CST and which needs to be stopped on friday say 19:00 CST.
Is there any way to approach this. I am confused on how many periods would be needed to achieve this?
Thank you

https://docs.aws.amazon.com/solutions/latest/instance-scheduler/appendix-e.html

Thanks maximrozin. I was thinking the same but thought that I should confirm it first.
Thank you for the help


Update distutils.core.setup/run_setup to better match setuptools.build_meta.

Motivation
I noticed that setuptools.build_meta "re-implements" the run_setup function (there are differences between the 2 functions, e.g. distutils.core.run_setup wraps the code in a try...except, but the main idea behind both look similar to me).
There is one major difference: setuptools use tokenize.open and replaces \r\n with \n.
I went through setuptools commit history but did not find any comments/commit messages explaining exactly why, but I assume that it improves encoding detection.
My intention with this PR is to update the distutils code using the same technique as used in setuptools, so eventually the same function could be used.
Changes

Use the same tokenize.open technique as employed by setuptools.build_meta in distutils.core.run_setup.
Additionally, I refactored the origin setup function and split out run_commands, this way, one can use dist = run_setup("setup.py", stop_after="config") to get the configuration and later run run_commands(dist).
I also added some tests.

Side note
In terms of implications for setuptools, I imagine that eventually we could build the "new-static-config-style" distribution objects directly from the setup.cfg/pyproject.toml and then run them with run_commands, instead of always creating a setup.py stub.
Similarly, when setup.py is found, dist = run_setup("setup.py", stop_after="config") could be used to obtain the dist object and then revert to the same flow as a setup.cfg/pyproject.toml-only project...
(Basically a change in the mental model, instead of making setup.cfg/pyproject.toml use the same flow as setup.py one, we can make a setup.py use the same flow as setup.cfg).

Thank you very much @FFY00 for the review.
I updated he code to use tokenize.open directly, since it is available on Python >= 3.2

Thank you very much @jaraco. I will keep that in mind, and I totally understand what you explained.


Add pull_image_master function to pull Shippable service images on master machine

https://github.com/Shippable/pm/issues/10352

this is done, closing


Missing Glyphicons?

I have been having issues with glyphicons lately. Namely the '.glyphicon-triangle-X'. There are others that don't work as expected. I will note that I am running Linux Mint (not windows) so there maybe some reason my OS has issues with them (I don't know). Regardless, when I use the aforementioned glyphicons, I see a circle/dot with a '3' or a '2' in the center (instead of the triangle(s)).
I use the following to create glyphicons:

Another note: The bootstrap files used in my site were obtained via the GitHub repo. Built as instructed (unmodified).

What browser and version?
What version of Bootstrap?
Please post a JS Fiddle of your example.
Please note that Bootstrap only unofficially supports non-Android Linux.

Of course, sorry, I was in a hurry to get off.
Browser Chrome 41.0.2272.76-1
Bootstrap v3.3.2
I'll make a jsFiddle in the am when I get back to my machine...
OS Linux Mint 17.1

JS Fiddle: http://jsfiddle.net/74jhk5a5/

I am unable to reproduce the issue with Chrome v40, v41.0.2272.35, or v42.0.2311.22 on Linux via Sauce Labs using my JS Fiddle.
Either there is some error with how you setup Bootstrap's files on your server, or there is some bug specific to your Linux distro/packages.
Consult StackOverflow (or similar) for help with the former; we are unable to provide help with server environment troubleshooting on this issue tracker.
If it's the latter, please file a bug with your Linux vendor and/or the Chromium project.
Thanks!

I will build Bootstrap again and see if the problem is still there. I will also check this on a Windows OS with various browsers. If I can't replicate in Windows, then there is a chance that there is an issue with the ttf-mscorefonts package (or something like that)... However, not your issue if that is the case :)
Thanks Chris!

The problem was with the /Fonts directory provided by Initializr (Bootstrap version). It is missing the 'glyphicons-halflings-regular.woff2' file. I rebuilt bootstrap and replaced everything (/css, /js, /fonts) with the new files, and it fixed this issue...

@DerekFoulk Cool, could you please file an Initializr bug? Thanks!

Will do! Thanks again Chris...

Reference Initializr Issue #92


Get rid of (negative) lookahead (somehow)

used right now for lexing, e.g. ensuring that an identifier ([a-zA-Z][a-zA-Z0-9]* in regex) is not followed by more identifier characters ((?![a-zA-Z0-9]) in some regex dialects), forcing the rule to match the longest valid identifier (just like most regex semantics out there)
it makes the grammar context-sensitive (when it maybe doesn't need to)
incremental reparsing (#12) would need to track larger input ranges than the SPPF uses
bidirectional parsing (#13) would prefer symmetrical lookbehind, which worsens the problem

either both direction checks both lookbehind and lookahead, or we do an analysis to determine that one or both is unnecessary given its contexts

we could transform what the user writes as look{ahead,behind} into "static context-sensitivity", propagating it up and specializing callers, generating a (much?) larger but context-free grammar, which only accesses input within the success range of each rule invocation

Found a solution while talking to @eternaleye, and it involves #27:
// Existing Rust grammar:
ForLoop = "for" Pat "in" Expr Block;
// Scannerless CFG:
ForLoop = "for" {
    Pat(/*ident_before=*/"1", /*ident_after=*/"1") |
    // NB: WS is *mandatory* whitespace here:
    WS Pat(/*ident_before=*/"0", /*ident_after=*/"1") |
    Pat(/*ident_before=*/"1", /*ident_after=*/"0") WS |
    WS Pat(/*ident_before=*/"0", /*ident_after=*/"0") WS
} "in" {
    Expr(/*ident_before=*/"1", /*ident_after=*/"0") |
    WS Pat(/*ident_before=*/"0", /*ident_after=*/"0")
} WS? Block;

Note that this is a first approximation and we could find some sugar for it, perhaps, especially to avoid having to write WS? everywhere else in the grammar.

While we might be able to implement the machinery to allow writing the explicit version sooner, it's becoming increasingly clear how unergonomic it would be to write such a grammar.
A good middle-ground could be taking lookaround and propagating it up the grammar, and require that it cleanly "intersects" with existing terminals and "dissolves" away, leaving a CFG behind.


[Bug]:

Contact Details
<EMAIL_ADDRESS>What happened?
Invalid API key. Please check your API key and try again. You can do this by clicking on the model logo in the left corner of the textbox and selecting "Set Token" for the current selected endpoint. Thank you for your understanding.
Steps to Reproduce

What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

It's an error with the API key, please check if it is correct. Are you using a reverse proxy?


Share file handles

Can we share file handles for different transports?
The problem is that formatter is the same object as file handle. I.e. I want to use different formats, but the same file.

Found that there's a stream option:
new (winston.transports.File)({
    stream: fs.createWriteStream(filename),
    json: false,
    timestamp: function() {
      return moment().format(TIME_FORMAT);
    },
    formatter: function(options) {
      return "[" + options.timestamp() + "] "
             "[" + options.level.toUpperCase() + "] " +
             "[" + uuid + "] " +
             "[" + timestamp + "] " +
             ((type === "main") ? "[main] ": "") +
             options.message;
    }
  })


Grid support for Pivoting

Need to be able to handle Pivot grid configuration for a client app.
https://www.ag-grid.com/javascript-grid-pivoting/
Requirements:

Hoist Grid/GridModel able to handle Pivot mode for ag-grid
Able to use ag-grid Tool Panel and Row Group Panel for configuring the grid
Grid state (columns, sorting, grouping, pivot) able to be saved and restored easily
Grid features work (if applicable) when in Pivot mode (selection, context menu, etc.)

Closing.  We took an alternative path of Creating AgGridModel for this type of application.


When database is deleted using funk -r without arguments, a backup should be stored

I think a good place for this backup might be /tmp/localalias/backups. This way diskspace is not an issue but user's still have one last chance to save the data before reboot (when /tmp is potentially cleared).

Depends: #100


[Doc] Add apache-dubbo to supported list

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

You don't need to add Component since you don't use it in the plugin. Right?
The document looks like right.

@wu-sheng thanks for pointing out 😄

Coverage decreased (-0.002%) to 13.896% when pulling 065c3b0786994dc3ca46929166fda24b1aafaf1a on kezhenxu94:supported-list into<PHONE_NUMBER>21aa6c3906e05e852c7871d2aa00ef on apache:master.


Query scope preventing pivot data from being accessible

Utilizing a query scope when querying relations appears to be preventing pivot data from being accessible in the results.
Player model's query scope
    /**
     * Query scope for active groups.
     */
    public function scopeActive()
    {
        return $this->whereNull('inactive');
    }

Sample code:
$players = Group::find(1)->players()->active()->get();

foreach($players as $player) {
   dd($player->pivot)); // null
}

If instead of the query scope I use a direct whereNull() it works fine.
$players = Group::find(1)->players()->whereNull('inactive')->get();

foreach($players as $player) {
   dd($player->pivot)); // Pivot object with expected data available
}

This work fine.
/**
     * Query scope for active groups.
     */
    public function scopeActive($query)
    {
        return $query->whereNull('inactive');
    }


Use wget to download the files to speed up tests

Before the  code change, it took nearly half an hour to download on-http static files from the website. With the code change, the time is reduced to around 700s. The configuration file is changed due to the fact that to ssh to vagrant is a little bit different from ssh to other host, as vagrant is doomed to be replaced, instead of using the scp method to get static files, employ more general way of downloading file from the internet. @nortonluo

BUILD RackHD #582 : UNSTABLE

BUILD RackHD #582  Error Logs  ▼Test Name: runTest
Error Details: name 'Falsee' is not defined
-------------------- >> begin captured logging << --------------------
infra.run: DEBUG: relaying set_test((None,)) to all trackers {}
test.run: DEBUG: handle_after_test pluggin progression for  test=test_delete_subscriptions (event_service_tests.EventServiceTests)
test.run: DEBUG: handle_after_test pluggin progression for  test=test_delete_subscriptions (event_service_tests.EventServiceTests)
root: INFO: +1.23 - STARTING TEST: [Failure: NameError (name 'Falsee' is not defined)]
infra.run: DEBUG: relaying set_test((Test(),)) to all trackers {}
test.run: DEBUG: handle_start_test pluggin progression for  test=Failure: NameError (name 'Falsee' is not defined)
test.run: DEBUG: handle_start_test pluggin progression for  test=Failure: NameError (name 'Falsee' is not defined)
--------------------- >> end captured logging << ---------------------
Stack Trace:   File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/jenkins/workspace/RackHD/RackHD/test/.venv/on-build-config/local/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/jenkins/workspace/RackHD/RackHD/test/tests/rackhd20/test_rackhd20_api_notifications.py", line 70, in
    @attr(all=Falsee, regression=False, smoke=True)
"name 'Falsee' is not defined\n-------------------- >> begin captured logging << --------------------\ninfra.run: DEBUG: relaying set_test((None,)) to all trackers {}\ntest.run: DEBUG: handle_after_test pluggin progression for  test=test_delete_subscriptions (event_service_tests.EventServiceTests)\ntest.run: DEBUG: handle_after_test pluggin progression for  test=test_delete_subscriptions (event_service_tests.EventServiceTests)\nroot: INFO: +1.23 - STARTING TEST: [Failure: NameError (name 'Falsee' is not defined)]\ninfra.run: DEBUG: relaying set_test((Test(),)) to all trackers {}\ntest.run: DEBUG: handle_start_test pluggin progression for  test=Failure: NameError (name 'Falsee' is not defined)\ntest.run: DEBUG: handle_start_test pluggin progression for  test=Failure: NameError (name 'Falsee' is not defined)\n--------------------- >> end captured logging << ---------------------"

:+1:


Responding with 401 redirects to login when not using cookie authentication

I have a project that uses Angular for the front-end and JWT authentication, and has no references to any kind of cookie authentication in Startup.cs. Yet when issuing a 401 it responds with a 302 and redirects the browser to /Account/Login.
My searches have yielded this issue https://github.com/aspnet/Security/issues/687 which states you cannot null the redirect because that's how cookie authentication is supposed to work, but as mentioned, I'm not using cookie authentication.
I'm really stumped and I can only think that cookie authentication is used by default (which I haven't seen written down anywhere) or it's a bug. Any ideas?

Are you using Identity or any other auth components?

@Tratcher I am, I map the JWT token to an Identity so I can use it throughout the rest of the app. Is there something I need to disable in its options?

Identity is cookies based, it does not integrate with JWT. Correct @HaoK?

@Tratcher Are you sure? I have a JWT bearer token resolving to an Identity and can be successfully tested with Postman without using any cookies.

I think we're confusing each other. By Identity I mean the Identity management framework https://github.com/aspnet/identity, not just a ClaimsIdentity.

Fair enough, but the project does use the Identity framework to deal with user registration and authentication before a JWT token is generated. Is this where the problem lies?

Ah, that's what I thought. Yes, Identity uses multiple cookie middleware internally. Your best option is not to return 403s directly, but to use HttpContext.Authentication.Forbid("Bearer") or Challenge("Bearer");

Thanks for the input, I'll have to work out how to go down this route cause the problematic endpoint itself is using a custom policy, which I have been unable to get working for other reasons (might be creating a separate issue for it soon). Returning the 401/403 manually was actually a workaround that is also proving problematic.
Anyway, just trying to understand the whole situation with the Identity framework. Is this actually an issue? The login redirect when using Identity (and, as such, indirectly cookies)? The argument for keeping the enforced login redirect with cookie authentication was "If you don't want it, don't use cookies", but surely people want to create an cookie-less API that uses the Identity framework and the redirect kind of breaks everything. Or is using the Identity framework for a web API not a good idea in the first place?

@haok?

Identity basically has two pieces, AddIdentity adds the UserManager and the assorted other APIs needed to use the framework to your service collection.  UseIdentity is really only adding cookie middleware (which SignInManager implicitly works against).  So if you want to use the identity APIs but not cookies, then just remove the UseIdentity in your startup, and do not use SignInManager, you will have to manage the authentication yourself.

@divega @blowdart Maybe we should rename UseIdentity => UseIdentityCookies to clarify what its actually doing.

Works for me

Or we could call it UseSignInCookies, since its really SignInManager that depends on the cookies

Seems a good idea to change the name to make things clearer but we are running out if time for breaking changes. Is "use cookie authentication with Identity" a good way to convey what it means?

Actually now that I think about it, I think we discussed something more specific in the past but decided UseIdentity was better since we could potentially add more than just cookies in the future, so this is better future proofing.

If we decided to add "more than just cookies" in the future,  what is the likehood that we would need a separate method to add an alternative to cookies?

I don't mean as an alternative to cookies, I mean UseIdentity could add some other middleware that is needed for new features

@HaoK this thread: https://github.com/aspnet/Identity/issues/621

Hi,
I found an article that resolve this problem by adding a nice trick 😉
https://devblog.dymel.pl/2016/07/07/return-401-unauthorized-from-asp-net-core-api

It seems like I managed to fix it without having to use the "events" workaround in the following way:
services.AddIdentity<ApplicationUser, IdentityRole>(config =>   {
    // ...
    config.Cookies.ApplicationCookie.AutomaticChallenge = false;
    // ...
});

Let me know if it works for you guys too.

Yeah... your solution for setting the AutomaticChagglenge to false worked for me.

Setting AutomaticChallenge to false worked for me but it also inhibited the ability to login.


feat(build): build abi3 wheels

This simplifies our wheel build process by using the abi3 API.
https://pyo3.rs/v0.14.5/building_and_distribution#py_limited_apiabi3
It allows us to build only a single wheel per target OS/arch.
closes #168

Good news: There's ansolutely no performance impact :tada:
before

after


Clean up CI for new bundler release

Before merging:

[ ] Copy the latest benchmark results into the README.md and update this PR
[ ] If this change merits an update to CHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning

JRuby still doesn't seem to work with this new version of bundler so I'm closing this.


CONCERN: App does not provide clear actions for the user, in the event of "red" status DHM-S1-2

https://docs.google.com/document/d/1Uh1A-h7Ddm6t-rAlHOM90xnsrkLEG9SGcTolf3uIbgQ/edit
The whole purpose of the app is to affect user behaviour.  We maximize our chances of this by providing really clear instructions on what users should do.
Self-isolate?
Review their exposure history, and act based on that?  Folloowing what guidance?
Contact their healthcare provider.
Just providing info that they may be infected without clear steps means we risk missing important opportunities to fix behaviour.
(note: I have not been able to actually test this function yet due to other defects.  This concern is raised on the basis of the screenshots I have seen).

Closing - suggestion for new behavior (updates to specification document) as opposed to issue with code.
It's not a bad suggestion, but should be taken up with the specifications developers.


[backport] Add cuDNN softmax interface

Backport of #1736

[automatic post] Jenkins, test this please.

LGTM!


[Remote Segments] Retry remote refresh on failure

Description
This PR does the following -

Introduces retry on failed sync segment attempts during remote refresh.
Uses dedicated threadpool for RemoteStoreRefreshListener.afterRefresh(didRefresh)`
Integ test that introduces random failures during remote store operations and retries to sync the segments from local to remote store.

Related Issues
Resolves #7363

Check List

[x] New functionality includes testing.

[ ] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

FYI - One of the other is to make changes in scheduleRefresh() method of IndexShard class.
https://github.com/opensearch-project/OpenSearch/blob/01e5c294eba1be7fef5dfbb87f2ecc3012d9dc4f/server/src/main/java/org/opensearch/index/shard/IndexShard.java#L4147-L4176
In the first if condition can be changed to
if (isReadAllowed() && (listenerNeedsRefresh || getEngine().refreshNeeded()) || noRemoteSegmentsLag()) {
However, this is relatively more intrusive and will lead to complete refresh process getting triggered although most of it will be no-op. And on failures this will continue to get retried after every index.refresh_interval time which can be catastrophic if the retries induce more failures (throttling due to more retries).

Codecov Report

Merging #7400 (7589820) into main (01e5c29) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #7400      +/-   ##
============================================
- Coverage     70.70%   70.67%   -0.04%
+ Complexity    59652    59608      -44
============================================
  Files          4877     4877
  Lines        285806   285846      +40
  Branches      41165    41171       +6
============================================
- Hits         202085   202012      -73
- Misses        67144    67268     +124
+ Partials      16577    16566      -11

Impacted Files
Coverage Δ

...opensearch/snapshots/mockstore/MockRepository.java
0.00% <0.00%> (ø)

...search/index/shard/RemoteStoreRefreshListener.java
81.75% <82.50%> (+0.44%)
:arrow_up:

...ain/java/org/opensearch/threadpool/ThreadPool.java
82.47% <100.00%> (-0.14%)
:arrow_down:

... and 477 files with indirect coverage changes

Regarding PR title: Retry remote refresh on failure - not sure what we mean by remote refresh here but could be Retry segment uploads to remote store on failure

Remote refresh is basically the entire process of syncing segments on local to remote store - is what I meant, but can change the title.

org.opensearch.cluster.shards.ClusterShardLimitIT.testCreateIndexWithMaxClusterShardSetting
Looks to be a flaky test, will create an issue for the same if it does not exist.

Looks to be unrelated flaky test again.


logreader: catch exception outside loop

Does this fix the replay getting stuck if the last log is corrupt?

no, I think it can’t. where is it stuck ?  Is it in decompressbz2 or FlatArrayMessageReader?

Will do some more investigation the next time it happens.

@pd0wm  It's stuck in decompressbz2 if log is corrupt


last function not working for array type

Bicep version
PS > az bicep version
Bicep CLI version 0.14.6 (f1dae160cd)
Describe the bug
A clear and concise description of what the bug is vs what you expected to happen
test.bicep(19,28) : Error BCP026: The output expects a value of type "string" but the provided value is of type "null | string".

To Reproduce
Steps to reproduce the behavior:
create a bicep file as below
param keyVaultName string = 'tt-01-kv'
param keyName string = 'red-cmk-2302'

resource keyVault 'Microsoft.KeyVault/vaults@2022-07-01' existing = {
  name: keyVaultName
}

resource cmkey 'Microsoft.KeyVault/vaults/keys@2022-07-01' existing = {
  name: keyName
  parent: keyVault
}

var temp = last(split(cmkey.properties.keyUriWithVersion, '/'))

var version = temp

output keyVersion string = version

output keyName string = cmkey.name

and then execute with the below command.
az deployment group create -g rg-name  --template-file .\test.bicep
Additional context
Add any other context about the problem here.

i used below script and it worked
'${last(split(cmkey.properties.keyUriWithVersion,'/'))}'


Decoding error when loading zone names

Fresh clone and package install on Windows. Python 3.9.
(Had to downgrade pandas to 1.5.3 due to json normalize issue. Fix is in PR #77)
Run python my_experiment.py
Gives the following error
(exp-impact-test) c:\Users\nakersha\Develop\code\misc\experiment-impact-tracker\examples>python my_experiment.py
loading region bounding boxes for computing carbon emissions region, this may take a moment...
 100.00% 454/454... rate=773.76 Hz, eta=0:00:00, total=0:00:02
Done!
Traceback (most recent call last):
  File "c:\Users\nakersha\Develop\code\misc\experiment-impact-tracker\examples\my_experiment.py", line 6, in <module>
    from experiment_impact_tracker.compute_tracker import ImpactTracker
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\site-packages\experiment_impact_tracker\compute_tracker.py", line 25, in <module>
    from experiment_impact_tracker.cpu.intel import get_rapl_power
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\site-packages\experiment_impact_tracker\cpu\intel.py", line 13, in <module>
    from experiment_impact_tracker.utils import *
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\site-packages\experiment_impact_tracker\utils.py", line 15, in <module>
    from experiment_impact_tracker.emissions.constants import PUE
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\site-packages\experiment_impact_tracker\emissions\constants.py", line 77, in <module>
    ZONE_NAMES = _load_zone_names()
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\site-packages\experiment_impact_tracker\emissions\constants.py", line 50, in _load_zone_names
    x = json.load(f)
  File "C:\Users\nakersha\Miniconda3\envs\exp-impact-test\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8d in position 14279: character maps to <undefined>

(exp-impact-test) c:\Users\nakersha\Develop\code\misc\experiment-impact-tracker\examples>

pip list

arrow                     1.2.3
beautifulsoup4            4.12.2
bootstrapped              0.0.2
bs4                       0.0.1
certifi                   2022.12.7
charset-normalizer        3.1.0
click                     8.1.3
colorama                  0.4.6
contourpy                 1.0.7
cycler                    0.11.0
decorator                 5.1.1
deepdiff                  6.3.0
experiment-impact-tracker 0.1.8
filelock                  3.12.0
fonttools                 4.39.3
future                    0.18.3
geocoder                  1.38.1
geographiclib             2.0
geopy                     2.3.0
idna                      3.4
importlib-resources       5.12.0
Jinja2                    3.1.2
joblib                    1.2.0
kiwisolver                1.4.4
MarkupSafe                2.1.2
matplotlib                3.7.1
mpmath                    1.3.0
networkx                  3.1
numpy                     1.24.3
ordered-set               4.1.0
packaging                 23.1
pandas                    1.5.3
Pillow                    9.5.0
pip                       23.0.1
progiter                  1.3.0
psutil                    5.9.5
py-cpuinfo                9.0.0
PyLaTeX                   1.4.1
pyparsing                 3.0.9
python-dateutil           2.8.2
pytz                      2023.3
ratelim                   0.1.6
requests                  2.28.2
scipy                     1.10.1
seaborn                   0.12.2
setuptools                66.0.0
shapely                   2.0.1
six                       1.16.0
soupsieve                 2.4.1
sympy                     1.11.1
torch                     2.0.0
typing_extensions         4.5.0
tzdata                    2023.3
ujson                     5.7.0
urllib3                   1.26.15
wheel                     0.38.4
zipp                      3.15.0

I see the lib does not support Windows. Will try on Linux. Any plans to support Windows?


Can component be protobuf class?

Protobuf generated class is not a pure struct and which has some methods in its definition.So i don't know if it is safe to use it as a component for an entity.
If I can not do this, do you have some suggestions for serialization my entities? It should be note than, I need to deserialization with python and c++14 is the allowed at most.
Thank you for your kindness!

You can use any type as component as long as it's moveable. :+1:

@skypjack Great!
Additionally, Does it lead to performance degratation when component is not pure struct?

It leads to performance degradation in the same measure in which it would do if you put these components in an std::vector and decided to iterate them linearly. That is, most likely not something you can easily measure.

I'm closing this since I think it has been answered.
Feel free to reopen the issue if this isn't the case. :+1:


Update favicon

Curious issue, because when testing the previous PR I saw the favicon at http://localhost:5000/assets/favicon.ico :thinking:

Looks like there is already a favicon.ico in the public folder. Although it is 0 bytes again.


打算 提供绿色安装包不?

Check

[X] Make sure to search for existing issues before filing a new one!
[X] This bug can be reproduced in the latest version.

Bug
d
Steps to reproduce
d
Expected Behavior
d
Screenshots
No response
Environment
- App Version: v0.5.0
- OS  Version: Windows 11 22H2 (22621.1413)
d

Log file
No response
Additional context
No response

没有此计划


zone buff no longer works please help

Unfortunately, the new AzerothCore version no longer works with zone buff
https://github.com/Cloticc/Eluna-scripts/tree/master/Quality of life stuff/zone/sql version
https://github.com/azerothcore/azerothcore-wotlk
the script prevents me from entering any commands in the game chat. If I delete sqlZoneBuffer v2.lua then everything works again. I would be pleased if you could fix it. Sorry I can't describe it better.

Alright ill check it out.

Thank you very much, I think it's good that there are still people who repair or create Eluna scripts. Thank you for the great work.

question: can you also repair other lua scripts? I would also give something for that.


resolve #183 invalid default string next to Save .ini File btn

#183 is labeled as closed, so why does this old branch appear ahead of main by one commit ?
We can even see the line this introduces on main:
https://github.com/WasatchPhotonics/ENLIGHTEN/blob/82d913ce2497e89d68243dc057d81d8c62c203e6/enlighten/file_io/Configuration.py#L92

Also, this means sbee-doc is safe for deletion and should be deleted.


added Id class function for EoL

Added the Encylopedia of Life functions to obtain IDs of given species. Also refactored tests.
Related Issue
#62
Example
c = Ids('panthera tigris')
c.eol()
c.extract_ids()

So some code needs to be re-worked. The EOL API url you used results in "pages" which do have IDs, but are page ids, not taxon ids. To get taxon ids you need to call e.g., https://eol.org/api/pages/1.0/328674.json
In the R get_eolid fxn, I get pages here https://github.com/ropensci/taxize/blob/master/R/get_eolid.R#L143 then get taxon ids for all those pages here https://github.com/ropensci/taxize/blob/master/R/get_eolid.R#L161 - - where e.g., the first page id in the result for your example above is https://eol.org/api/pages/1.0/328674.json - which has taxon name, rank name, etc. - which also sorts out the other issue I commented on that the _make_id call was missing taxon rank (and name too)

I see what you mean. Do you think it's appropriate to limit the queries in some way here? It seems that page IDs for many names generate hundreds of IDs. Do you think we should take e.g. first 10 results, or it is better to pass everything back to the user?

In R taxize we limit result of the pages search to names that match the users query (via regex) - and then fetch the taxon data for each taxon at the /pages/1.0/xxxxx.json routes - does that make sense to do here?

I hope this most recent commit fixes it. It filters the page ids in a similar way to your use of grep in R taxize, and then translates the page ids to the taxa ids.


Reset location after block yielding in macro expansion

This pull request Introduces #<loc:save> and #<loc:reset> new pragma comment, #<loc:save> saves current location and #<loc:reset> resets it. They are useful to keep original location when block yielding in macro expansion.
For example, this code makes broken error message:
macro foo
  a = {{ yield }}
  a.ok
end

foo { 1 }

It cannot be compiled and error message is:
in foo.cr:7: undefined method 'ok' for Int32

Error message points line 7 of foo.cr, but this code consists only 6 lines.
This bug comes from a location is not reset after block yielding in macro expansion. In fact, foo { 1 } expands to:
a =  begin #<loc:"foo.cr",6,7>1 end
a.ok

So, the parser reports a.ok is on line 7 of foo.cr.
This pull request also fixes it by wrapping #<loc:save> and #<loc:reeset> to yielding expanded code, such a like:
a =  #<loc:save>begin #<loc:"foo.cr",6,7>1 end#<loc:reset>
a.ok

It works well.

Super interesting! I actually had this idea too and eventually was going to implement it, though I imagined something more like a stack (push/pop). What do you think if we change it to #<loc:push> and #<loc:pop> and use a stack in the lexer? (I'd use a record to store all the info you are remembering now)

@asterite I'll try to implement #<loc:push> and #<loc:pop>. But, we cannot use record to remember old location. Because it is not immutable, it should be changed by lexer to report correct location.

Hmm... then I misunderstood something. I thought loc:save just saved the current location, then loc:reset reseted it. But it seems when you do loc:save then some tracking is done in many places... why is this needed?

For example, when given block is multiple lines:
macro foo
  a = {{ yield }}
  a.ok
end

foo do
  :foo
  :bar
end

It is expands to:
  a =  #<loc:save>begin #<loc:"foo.cr",7,3>:foo
#<loc:"foo.cr",8,3>:bar
end#<loc:reset>
a.ok

If #<loc:save> makes just copied and copied location's line number is not incremented, its location is wrong on #<loc:reset>.

Oooh... I understand now. Yes, the lexer needs to continue incrementing lines for the old line number. I think like you implemented it it's fine :-)

Thanks. I already implemented #<loc:push> and #<loc:pop> version, and now I run make spec on my environment. I'll write specs for #<loc:push> and #<loc:pop> (it is missing..), then I'll push it.

@MakeNowJust Great! Though now I'm not sure there's a use case for push/pop. I thought it was going to be useful to implement/fix this, but I'm not sure anymore. Can you think of a use case?

@asterite No, so I don't implement location stack at first. However, I think #<loc:save> and #<loc:reset> is not good naming. Perhaps #<loc:push> and #<loc:push> is better even if stack size is 1 only.

@MakeNowJust Thank you! And thank you for extracting a method for incrementing line numbers. I was actually going to ask if you wanted to do that, so it seems you somehow read my mind... :-P


2024-12-18_05-47-34_master-next_aws-cli

Automatically created.

Backport failed for kirkstone-next, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin kirkstone-next
git worktree add -d .worktree/backport-10842-to-kirkstone-next origin/kirkstone-next
cd .worktree/backport-10842-to-kirkstone-next
git switch --create backport-10842-to-kirkstone-next
git cherry-pick -x 86d4a2583e4938ccd02bd8004c13be519528bfea

Successfully created backport PR for scarthgap-next:

#10848

Successfully created backport PR for styhead-next:

#10849


Nucleus Coop cannot be run as Administrator

Title says it all, multiple handlers require to launch NucleusCoop app as administrator but trying to do so fails without any error message shown. Running as non-admin nucleus works fine but almost half of the handlers do not. This was not a problem on previous versions (with the old UI).

You're on the wrong github repo. The new one is https://github.com/SplitScreen-Me/splitscreenme-nucleus
Also, try doing a clean install if you haven't already :)


Spelling, grammar and definition issues.

I noticed a few issues with terms we are using. Below is the suggested wording for the respective terms. Some changes are as subtle as inserting missing hyphens (e.g. in non-coding, etc.).
missense_variant | SO:0001583
A sequence variant that changes one or more bases of a codon, resulting in a polypeptide with a different amino acid sequence but no change in length.

stop_gained | SO:0001587
A sequence variant where at least one base of a codon is changed, resulting in the creation of a premature termination (stop) codon and a shortened polypeptide.
stop_lost | SO:0001578
A sequence variant where at least one base of a termination (stop) codon is changed, resulting in an amino acid coding codon and an elongated polypeptide.
splice_acceptor_variant | SO:0001574
A splice variant that changes the 2 base pair region at the 3' end of an intron.
splice_region_variant | SO:0001630
A sequence variant occurring in the region of the splice site, either within 1-3 bases of the exon or 3-8 bases of the intron.
frameshift_variant | SO:0001589
A sequence variant where the number of nucleotides inserted or deleted is not a multiple of three, causing a disruption of the translational reading frame.
5_prime_UTR_premature_start_codon_gain_variant | SO:0001988
A 5' UTR variant where a premature start codon is gained, resulting in an elongated polypeptide.
chromosome_number_variation | SO:1000182
A type of chromosome variation where the chromosome complement is not an exact multiple of the haploid number.
coding_transcript_intron_variant | SO:0001969
A sequence variant occurring in an intron of a coding transcript.
conserved_intergenic_variant | SO:0002017
A sequence variant located in a conserved intergenic region.
conserved_intron_variant | SO:0002018
A transcript variant occurring in a conserved region of an intron.
disruptive_inframe_deletion | SO:0001826
A sequence variant that deletes bases in multiples of three from the coding sequence starting and ending in existing codons, resulting in an in-frame decrease in CDS length and altered amino acid sequence at deletion start and/or end codon.
disruptive_inframe_insertion | SO:0001824
A sequence variant that inserts bases in multiples of three into the coding sequence in an existing codon, resulting in an in-frame increase in CDS length and altered amino acid sequence at insertion start and/or end codon.
exon_loss_variant | SO:0001572
A sequence variant where an exon is lost from the transcript.
feature_truncation | SO:0001906
A sequence variant that causes the reduction of a genomic feature, relative to the reference sequence.
inframe_deletion | SO:0001822
A sequence variant that deletes bases in multiples of three from the coding sequence.
inframe_insertion | SO:0001821
A sequence variant that inserts bases in multiples of three into in the coding sequence.
intergenic_variant | SO:0001628
A sequence variant located in the intergenic region.
internal_feature_elongation | SO:0001908
A sequence variant that causes the extension of a genomic feature from within the feature rather than from the terminus of the feature, with relative to the reference sequence.

intragenic_variant | SO:0002011
A variant that occurs within a gene but falls outside of all transcript features. This occurs when alternative transcripts of a gene do not share overlapping sequence.
intron_variant | SO:0001627
A transcript variant occurring in an intron.
non_coding_transcript_exon_variant | SO:0001792
A sequence variant occurring in an exon of a non-coding transcript.
non_coding_transcript_intron_variant | SO:0001970
A sequence variant occurring in an intron of a non-coding transcript.
non_coding_transcript_variant | SO:0001619
A transcript variant of a non-coding RNA gene.
rare_amino_acid_variant | SO:0002008
A sequence variant where at least one base of a codon encoding a rare amino acid is changed, resulting in a different encoded amino acid.
regulatory_region_variant | SO:0001566
A sequence variant located in a regulatory region.
sequence_variant | SO:0001060
A non-exact copy of a sequence feature or genome, exhibiting one or more sequence alterations.
stop_retained_variant | SO:0001567
A sequence variant where at least one base in a termination (stop) codon is changed, but it remains a termination codon.
transcript_ablation | SO:0001893
A feature ablation where the deleted region includes a transcript feature.

transcript_variant | SO:0001576
A sequence variant that changes the structure of a transcript.
complex_substitution | SO:1000005
When no simple or well-defined DNA mutation event describes the observed DNA change, the keyword "complex" should be used. Usually there are multiple equally plausible explanations for the change.
Thanks,
Laurens (MGI at Jax)

Thank you for your post. I am a new postdoc and I am currently in training for updating the SO. I will update the terms and let you know when they are updated.

Hi David,
That’s great.
I’ve only looked at a tiny fraction of all the terms. You may want to do a more global search to find instances of for example “whereby” and replace them with more proper wording (“where”).
whereby > where
within > in
non coding > non-coding
terminator codon > termination codon
etc.
Iffy grammar is of course more difficult to search for… And inconsistencies such as “transcript variant” versus “sequence variant” when describing variants that affect transcripts.
Thanks,
Laurens
From: David Sant<EMAIL_ADDRESS>Reply-To: The-Sequence-Ontology/SO-Ontologies<EMAIL_ADDRESS>Date: Monday, 10 June 2019 at 16:37
To: The-Sequence-Ontology/SO-Ontologies<EMAIL_ADDRESS>Cc: Laurens Wilming<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [The-Sequence-Ontology/SO-Ontologies] Spelling, grammar and definition issues. (#469)
Thank you for your post. I am a new postdoc and I am currently in training for updating the SO. I will update the terms and let you know when they are updated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/The-Sequence-Ontology/SO-Ontologies/issues/469?email_source=notifications&email_token=AHATOCAXE3CCFXMH7HPVNV3PZ23QBA5CNFSM4HWWGT2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXLFBTY#issuecomment-500584655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHATOCGPQXZBHDA3NWDJM4TPZ23QBANCNFSM4HWWGT2A.


Update the LLVM patch (HEAD version)

The current version no longer applies cleanly because of the changes
in the libc++ math.h header related to the implementation of the
copysign functions.

Thanks for looking into this! I can confirm that the old patch did not apply, while the updated patch applies cleanly and the toolchain builds successfully afterwards.


When run the train.py, how many iterations will go?

in the config.py, voc = max iter is 12000, coco = max iter is 40000
i haven't changed anything from the default setting and run the train.py
and i saw the message in the terminal that traning SSD on VOC dataset.
but now i'm in iter 17930 and it still goes on.
is this means that this ssd works on COCO? or do i have to set up something else for VOC?
how many iterations did you saw, when you just run the train.py with default setting?

sorry i miscount the zeros,,,, it was 120000 and 400000 ;D

Hi~how many iterations and how long does it take for you to train on coco?


Added new words

Updated X.txt and Y.txt
Removed pycache folder
Updated .gitignore

Looks good! Thanks for cleaning up the .gitignore :)


Release

Codecov Report

Merging #219 (fd45412) into main (2398177) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head fd45412 differs from pull request most recent head 510ab39. Consider uploading reports for the commit 510ab39 to get more accurate results

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   53.58%   53.58%
=======================================
  Files          57       57
  Lines        4130     4130
=======================================
  Hits         2213     2213
  Misses       1917     1917

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2398177...510ab39. Read the comment docs.

Hey @vivbak, I've done a release which should cover anything in this release: https://github.com/populationgenomics/sample-metadata/pull/226
I'll close for now, but let me know if you have any concerns.

amazing thanks @illusional


ARROW-13616: [R] Cheat Sheet Structure

hi !
this is ready to be merged, there weren't more comments

Hey @pachadotdev , I'm going to try to take a look at this next week but feel free to nudge me if I don't get round to it

@pachadotdev Sorry, I didn't get as far with this today as I intended with this, so I'll do some more reviewing when I get back from my holiday!


Remove pcap_reader_command in favor of reader_command

This change removes pcap_reader_command in favor of reader_command and fixes import pcap not working with --read.

Net negative commits FTW! 🥇


Fallback store?

Hello! First of all, thanks for making this module.
Is there a way to use a secondary store (like in-memory) when for whatever reason redis has become unreachable?

Based on the design of the underlying package, express-rate-limit, I don't think so. Certainly an interesting idea, but I'm not sure how useful this would be in production given a horizontally distributed deployment, where now each node would have it's own independent store. I would think that if Redis was unavailable that would be a bigger problem ;)


Does it support Raspberry Pi 3B+?

I have a Raspberry Pi 3 Model B+. Can I use this image on it?
我有一个 RPI 3B+（配置与 3B 略有不同），我能不能把这个系统用在它上面？

I'm not sure. We only got RPI3. A few people said they got a black screen.
The OS is running on the official kernel of Raspberry. You can change the
config.txt or cmdline.txt to support new hardware.
On Sun, Sep 9, 2018 at 2:22 PM ZeroAurora<EMAIL_ADDRESS>wrote:

I have a Raspberry Pi 3 Model B+. Can I use this image on it?
我有一个 RPI 3B+（配置与 3B 略有不同），我能不能把这个系统用在它上面？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/FydeOS/chromium_os_for_raspberry_pi/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGj_7JTRMytkGRu3HKAgwyu6OZasRT1kks5uZLOXgaJpZM4WgKd5
.

I tried the prebuilt image with Raspberry Pi3 B+ and everything is working except for the wifi!
I think is a driver thing for the internal wifi because i plugged a wifi usb external adapter and is working fine.
Chromium is super fast!
I just changed the hdmi settings in config.txt:
hdmi_force_hotplug=1
hdmi_group=2
hdmi_mode=85
Do you know how i can enable the internal wifi?

RPI 3B+ wifi chip: cyw43455. linux driver: cypress.com official driver you can build the kernel by yourself, or wait a while.

Thank you!


Better support for vimeo

A couple things concerning the url-match for vimeo urls:

Doesn't support player.vimeo.com/{id}
Doesn't support videos from accounts set to "Unlisted", which can still be embedded, but do not appear in google search.

Regarding the unlisted videos, they have an additional identifier in their url, which causes the video not to load as it gets stripped from the iframe output. Example
https://www.vimeo.com/{video id}/{additional id}

Would you be able to make a PR here?

@dereuromark appreciate the quick response. Unfortunately my regex game isn't fantastic. I can give it a go, but I'm also not sure how to fulfill the requirements on this one since there's a single id() method for the MediaObject class. Would we add an additional method for the extra id, or return the full path as the id from the id() method, or something else?

Maybe the id is then x/y together?


GRPC-JS Error: Metadata key contains illegal characters

Environment details

OS: Debian (using node:10.15.0 Docker image)
Node.js version: v10.15.0
npm version: 6.4.1 (using yarn 1.12.3 though)
@google-cloud/logging-winston version: 1.1.0

Steps to reproduce

Send logs via this logger
Wait
Get error caught by a reporting library, like Sentry in our case

I've been seeing this error coming up sporadically, with different characters in the key each time:
Error: Metadata key "�é" contains illegal characters
  File<EMAIL_ADDRESS>line 101, col 45, in Http2CallStream.call.on
    const error = Object.assign(new Error(status.details), status);
  File "events.js", line 187, col 15, in Http2CallStream.emit
  File "domain.js", line 459, col 23, in Http2CallStream.EventEmitter.emit
  File<EMAIL_ADDRESS>line 71, col 22, in process.nextTick
    this.emit('status', status);
  File "internal/process/next_tick.js", line 61, col 11, in process._tickCallback

It only appeared once we had a deployment with logging using this library, so I'm pretty sure it's the logging transport, but can't be 100% as the stack trace starts in the grpc-js dependency.
Since I don't know where it is coming from, I don't really know how debug it. I'm guessing because the work is offloaded to the next tick I wouldn't even be able to catch the library error in my client code either 🤷♀
I found this related upstream issue: https://github.com/grpc/grpc-node/issues/519
This might very well be an issue in https://github.com/googleapis/nodejs-logging, but that offending metadata key could also be added by this library, so opening here.

Thank you for opening this issue.  I'm transferring the issue to nodejs-logging since interactions with the logging API are not done by this library but are instead done using the nodejs-logging library.  As such, I don't think this issue is specific to the nodejs-logging-winston library.


codec(ticdc): avro decode float by using float32

What problem does this PR solve?

Issue Number: close #8490
What is changed and how it works?

use float32 as the type for float numbers.

Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`

/run-all-tests

/run-all-tests

/run-all-tests

/run-engine-integration-test

/run-all-tests

/run-all-tests

/run-all-tests