Will it work properly with minimap2 output

Hello!
question in the tittle, since minimap is "deprecated".
Thank you

Hi. Yes, it works with minimap2. However, I've never gotten around to test parameters for minimap2, so I can't say anything about sensitivity, etc. But you can use it with minimap2 like this for example.
/path/to/minidot -M /path/to/minimap2 -m "-x asm20" prochlorococcus.fa

Hello! I have minimap2, so I use
bin/minidot -M path2/minimap2 -m "-x asm20" -o Canu_Flye_full.pdf Canu_PacBio.fasta Flye_PacBio.fasta
But, there's some error in R
[14:43:30] /linuxhome/tmp/jose/minimap2/minimap2 .. ok
[14:43:30] samtools .. ok
[14:43:30] prepping .. done
[14:43:30] mode: -x asm20 ( bp) "-x asm20"
[14:43:30] mapping .. done
[14:44:47] plotting
Error in scan(file = file, what = what, sep = sep, quote = quote, dec = dec,  :
line 2 did not have 18 elements
Calls: read.table -> scan
Execution halted
failed
Thanks

It should because both return PAF... Can you run minimap2 -x asm20 Canu_PacBio.fasta Flye_PacBio.fasta to see if you get proper output (and maybe post that?)
On February 8, 2022 2:46:44 PM GMT+01:00, botellaflotante @.***> wrote:

Hello! I have minimap2, so I use
bin/minidot -M path2/minimap2 -m "-x asm20" -o Canu_Flye_full.pdf Canu_PacBio.fasta Flye_PacBio.fasta
But, there's some error in R
[14:43:30] /linuxhome/tmp/jose/minimap2/minimap2 .. ok
[14:43:30] samtools .. ok
[14:43:30] prepping .. done
[14:43:30] mode: -x asm20 ( bp) "-x asm20"
[14:43:30] mapping .. done
[14:44:47] plotting
Error in scan(file = file, what = what, sep = sep, quote = quote, dec = dec,  :
line 2 did not have 18 elements
Calls: read.table -> scan
Execution halted
failed
Thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/thackl/minidot/issues/12#issuecomment-1032626986
You are receiving this because you commented.
Message ID: @.***>

this is what I get that way. I just renamed to .txt to upload here
canu_flye.txt
y


Is it possible to add 'Mirror to TV'

Mirror to TVIt is a very useful feature，Looking forward to increasing.

Sadly I wasn't able to do this, since I don't understand the nature of chrome cast and other tv mirroring logics,
If someone can provide a dart code for handling it I may be Able to implement it in the app

I made a modified version of a previous Chromecast package. It supports passing some metadata and few other things.
https://github.com/sommye-ctr/video_cast
It definitely has few bugs but maybe this would give a start?

Sadly I wasn't able to do this, since I don't understand the nature of chrome cast and other tv mirroring logics,
If someone can provide a dart code for handling it I may be Able to implement it in the app

https://pub.dev/packages/dlna_dart
I think you can take a look at this

Sadly I wasn't able to do this, since I don't understand the nature of chrome cast and other tv mirroring logics,
If someone can provide a dart code for handling it I may be Able to implement it in the app

https://pub.dev/packages/dlna_dart
I think you can take a look at this，This package scans TV devices within the local area network and broadcasts videos to the TV.

I checked dlna before and couldn't understand it fully that I am able to integrate it
But when I have some free time I will check it again

I made a modified version of a previous Chromecast package. It supports passing some metadata and few other things.
https://github.com/sommye-ctr/video_cast
It definitely has few bugs but maybe this would give a start?

This only works on Android?

I made a modified version of a previous Chromecast package. It supports passing some metadata and few other things.
https://github.com/sommye-ctr/video_cast
It definitely has few bugs but maybe this would give a start?

This only works on Android?

Yes it is only for android as of now

I made a modified version of a previous Chromecast package. It supports passing some metadata and few other things.
https://github.com/sommye-ctr/video_cast
It definitely has few bugs but maybe this would give a start?

This only works on Android?

Yes it is only for android as of now

That's a very limiting factor 😢 I guess a dart solution will be the best

Yeah that's true. I did try to look into the dart ones but weren't sure of them. You could take a look at some of those.

Yeah that's true. I did try to look into the dart ones but weren't sure of them. You could take a look at some of those.

i will try, but no promises since i dont have any knowledge in mirroring


Search by FileNumber

EX.
https://localhost:44369/api/files/civil?location=104.0001&fileNumber=P-241
https://localhost:44369/api/files/criminal?location=83.0001&fileNumber=500-2

@marzmehr, Did you want to have another quick look over this one?  It's been re-targeted from bcgov:master to bcgov:develop.


[Service Bus] Update tests to use credential instead of connection strings

This PR updates tests to use DefaultAzureCredential for all tests excluding those specifically testing authentication scenarios.
Also fixed a few spelling errors / code cleanup as I was going.
Added fixes for some docs links.

API change check
API changes are not detected in this pull request.

/azp run net - servicebus - tests

/azp run net - servicebus - tests

/azp run net - servicebus - tests

/azp run net - servicebus - tests

Confirming that we have at least one connection string and one SAS-based live test for sending, receiving, and admin. We don't need to cover all scenarios, but we do need to ensure that we have basic connectivity for an operation.

There were groups of tests with one for each of AAD, SAS and conn string. Those I didn't touch at all. I'll go through and confirm that there is a group of connectivity test for each of the scenarios you mentioned and add them if not.

@jsquire these seem like they cover the cases

Sending: https://github.com/Azure/azure-sdk-for-net/blob/c04e9184f937ef2820450a0de23c852519c1cedf/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Sender/SenderLiveTests.cs#L17-L63
Receiving: Conn string | AAD | SAS
Admin: https://github.com/Azure/azure-sdk-for-net/blob/c04e9184f937ef2820450a0de23c852519c1cedf/sdk/servicebus/Azure.Messaging.ServiceBus/tests/Administration/ServiceBusManagementClientLiveTests.cs#L928-L987

/azp run net - servicebus - tests


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.15.4",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ef2590a5305e0b8e9342f84c2214aa478ee7f28e"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "ef2590a5305e0b8e9342f84c2214aa478ee7f28e",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "thermal: Fix NULL pointer dereferences in of_thermal_ functions\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.4 by commit ef2590a5305e0b8e9342f84c2214aa478ee7f28e. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002351


can support  aws s3  for dataset?

can support  aws s3  for dataset?

Yeah.
dataset_type = s3
urn = s3a://<bucket>/<key path> or s3://<bucket>/<key path>
Similarly, file:///<full path> is for general file system

Hello, where can the "dataset_type" and "urn" parameters be set?

@ericsun2 @alyiwang can wherehows import object tags from s3?


License

Fix #81

Any reason for BSD-3 vs MIT?

I think I started using the BSD license after reading here that the name is ambiguous. But I now realize that in the same document, under Modified BSD License they suggest to use the X11 Licence, which is one of the two licenses referred to as "MIT".
If you/other people have a preference for MIT I can certainly change this; I have no strong feelings on this topic (mainly because I don't know enough).

I am happy with BSD-3


remove needless "is" from selection string

hey @sef43 this is very cool.  One thing I spotted was that the example selection looks a little odd.  The syntax is just "name X [Y Z]" for select all atoms with name(s) X (or Y or Z).  The current example is selecting atoms called is or C, which will work but isn't what you intended

Thank you for pointing this out!


No longer resetting validations twice

In /lib/grape/dsl/settings.rb there was a call to reset_validations! that seemed necessary. All the tests are passing.

I'll buy that.


Using links for papers' pdf instead of uploading files

too many pdf and too big for this repo.

#28 fixed this.


Account + Wishlist and search icons on Mobile

@karolbzik how it should look like on smartphone resolution? Now account and search icons are simply hidden

@pkarw on mobile we should extend sidebar navigation with search and wishlist buttons on the top

@collymore could you take care of this one guys? it's for next release

Yes will get this done


bug(mat-form-field): anchor mat-icon-button as matSuffix focus misaligned

Reproduction
Demo

Steps to reproduce:

focus the suffix of the Link input

Expected Behavior
Have the same alignment as the Button input's suffix.
Actual Behavior
It's misaligned
Environment

Angular: 10.2.1
CDK/Material: 10.2.6
Browser(s): Chrome latest
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10

You can solve this, this way -
<mat-form-field appearance="fill"> 	<mat-label>Link</mat-label> 	<input matInput placeholder="Placeholder" /> 	<button onclick="window.open('www.google.com', '_blank');" mat-icon-button matSuffix>     <mat-icon>open_in_new</mat-icon>   </button> </mat-form-field>

Hi @Totati!
I created the PR for this.
Temporarily, you can apply the identical fix by adding below on styles.scss.
.mat-icon-button {
  display: flex !important;
  justify-content: center;
  align-items: center;
}


Link arrows with custom node and custom size

Hi! I have a question about a link arrow location when I use a custom component for the Node. When I use a custom node - arrows disappear under my component. How can I move it?
Here is my example with the custom node component when the background is transparent.

It would be nice if I can redefine the arrow position on the link or if I can move the link line anchor to the custom edges of the component.  My example is a simple family tree and I should show the relation dependency direction and use a custom node (it shows the name of the animal for example)
I was trying to update my component in CSS to add some offset by the left to show this arrow, but this is solution works badly with the dynamic width.
Also, it would be nice if I can disable any dragging in the graph canvas to freeze my graph.
Thanks!

Hi!
I've had the same problem, I'm working on PR that solves just that, I'm planning on introducing the PR over the weekend!


fix "fix" for collection figures

Scope & Purpose
Fix "fix" for collection figures

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[ ] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
[x] The behavior change can be verified via automatic tests

Testing & Verification
This PR adds tests that were used to verify all changes:

[x] Added new integration tests (i.e. in shell_server / shell_server_aql)

http://<IP_ADDRESS>:8080/view/PR/job/arangodb-matrix-pr/9135/

http://<IP_ADDRESS>:8080/job/arangodb-matrix-pr-mac-onlycatch/6916/

http://jenkins.arangodb.biz:8080/job/arangodb-ANY-go-driver-matrix/710/


Respect PerUnitDeclaredValue in create fulfillment order

Codecov Report

Merging #11 into master will decrease coverage by 1.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   92.43%   91.10%   -1.34%
==========================================
  Files          17       17
  Lines         423      427       +4
==========================================
- Hits          391      389       -2
- Misses         32       38       +6

Impacted Files
Coverage Δ

pymws/fulfillment/outbound_shipment.py
100.00% <100.00%> (ø)

tests/test_fulfillment_outbound_shipment.py
100.00% <100.00%> (ø)

pymws/utils.py
90.00% <0.00%> (-7.50%)
:arrow_down:

pymws/pymws.py
88.54% <0.00%> (-3.13%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0dd39b...5295b9a. Read the comment docs.


helm install needs "generate-name" option.

I found following error when I used the command on public document. "helm install -f helm-config.yaml application-gateway-kubernetes-ingress/ingress-azure"
"Error: must either provide a name or specify --generate-name"

@hisasima : Thanks for your contribution! The author(s) have been notified to review your proposed change. @caya

@greg-lindsay - Can you review this old PR and determine whether it needs to be closed or merged?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
@MicrosoftDocs/public-repo-pr-review-team

This change is fine but the age of the PR caused a file conflict. I will need to add this information in my own PR. #please-close


Support ESLint v2.x

Hello @bucaran.
Now, fly-eslint fell test of ESLint (npm test).
ecmaFeatures property has moved to parserOptions property in ESLint v2.x.
http://eslint.org/docs/user-guide/migrating-to-2.0.0#language-options
Thank you.

@pine613 Thanks!


Release automation

Is your feature request related to a problem? Please describe.
Generate the body of the release notes using conventional commits enforced through CI via commit-lint.
Describe the solution you'd like

Given It's time for a release
When the hit the release pipeline/run the script
Then the release notes are automated, new tag is pushed, and a release is cut in GitHub.

Definition of done: - When release pipeline is triggered manually, the pipeline generates new version number, tag, release, and release notes and pushes them to GitHub.
Describe alternatives you've considered
Other release automation
Additional context

Link to conventional commits
we have commit-lint examples in kubernetes-fluent-client

After further review, I see I see that the current automation in place handles:

updating the pepr controller image
updating the npm registry
generating a scaffolding of release notes

For me, i think this suffices the need where as my major concerns were around pushing to npm and updating the registry.
The conventional commits are the only part that is still needed

We would like to revisit this after version 1.0.


radio items have a weird halo

Note: for support questions, please use one of these channels:
https://github.com/angular/material2/blob/master/CONTRIBUTING.md#question.
This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?

bug

What is the current behavior?

there is a weird halo after you select an option in a radio.

If the current behavior is a bug,
please provide steps to reproduce and if possible a minimal demo of the problem
via https://plnkr.co or similar.

just run the demo and select a radio. Note: you can make it go away by clicking a disabled option, which does not work since it's disabled, but it makes the halo go away.

What is the expected behavior?

animation finishes and halo disappears.

What is the motivation / use case for changing the behavior?

the halo is weird.

Which version of Angular and Material, and which browser and OS does this issue affect?
Did this work in previous versions of Angular / Material?
Please also test with the latest stable and snapshot versions.

master synced 3/30/2016

Other information
(e.g. detailed explanation, stacktraces, related issues, suggestions how to fix)

oops, this is just indicating focus, my bad!


fix #25

fix #25

fix showing missing definitions
shows more info about the word (B1, [T] etc)
shows language (UK/US) and has an option "--src/-s" that accepts "uk/us/both" (default is both)
Before

consider (verb)
To spend time thinking about a possibility or making a decision.

Examples:
• Don't make any decisions before you've considered the situation.
• [ + question word ] Have you considered what you'll do if you don't get the job?

=====*=====

consider (verb)
To think about a particular subject or thing or about doing something or about whether to do something.

Examples:
• Consider Clara Barton, who founded the American Red Cross.
• We considered moving to California, but decided not to.

After:

consider (verb) UK B1 [ I or T ]
To spend time thinking about a possibility or making a decision.

Examples:
• Don't make any decisions before you've considered the situation.
• [ + question word ] Have you considered what you'll do if you don't get the job?

=====*=====

consider (verb) UK C1 [ T ]
To give attention to a particular subject or fact when judging something else.

Examples:
• You've got to consider the time element when planning the whole project.
• [ + question word ] If you consider how long he's been learning the piano, he's not very good.

=====*=====

consider (verb) UK C2 [ T ]
To care about or respect other people or their feelings and wishes.

Examples:
• Did you consider your mother and how she's going to feel about you leaving?
• She never considers anyone but herself - she's totally selfish!

=====*=====

consider (verb) UK B2 [ T often + obj + (to be) + noun/adj ]
To believe someone or something to be, or think of him, her, or it as something.

Examples:
• He is currently considered (to be) the best British athlete.
• We don't consider her to be right for the job.

=====*=====

consider (verb) US
To think about a particular subject or thing or about doing something or about whether to do something.

Examples:
• Consider Clara Barton, who founded the American Red Cross.
• We considered moving to California, but decided not to.

=====*=====

consider (verb) US
To care about or respect.

Examples:
• Before raising the admission prices, consider the fans.

=====*=====

consider (verb) US
To believe to be; to think of as.

Examples:
• What some people would consider a personal attack, Andy considers a friendly discussion.

Warning: an error occurs if the cache is from old code. Because the cache does not have "Info" and src data.

Personally I only need the UK definitions. But I guess there can be a option to show the US definitions too ie, --dictionary and it should default to UK.
I don't want the output to be verbose and hard to read. We can add the which dictionary it is sourcing from ie, UK/US; but get rid of the other infos like B2 [ T often + obj + (to be) + noun/adj ]. The definition, word type and dictionary source is enough info already.
This should be the final outout for the header:
consider (verb) US

Well, the other info can be useful but it would be hidden if an option is not used like --describe

With the addition of the new field in the table. It does not store all the definitions. It will only store one definition by default.

It should store all definitions by default including both uk,us so that looking up the same word does not scrap the whole page again. Caching of all definitions should NOT depend on what options are being passed.

Thanks for contributing. Looks good.


perf: share constants between Program instances

This reduces Program cloning for building the CairoRunner by 86%
according to our Criterion benchmarks.
Running transactions 68000-68500 with Pathfinder shows a 7% improvement.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[x] This change requires new documentation.

[ ] Documentation has been added/updated.
[x] CHANGELOG has been updated.

Interestingly this shows a slowdown. I guess I'll have to run the benchmarks again in the server and my workstation just in case. Converting to draft in the meantime.


Request for an example for options for select field from a remote API through a service

I'm submitting a support request.
The request is for an example to fetch options for a select field from a remote API through a service.
Below is an option that I tried, however I couldn't get it to work.
I tried extending the FormlyFieldSelect but I am not able to inject a service into the constructor of the child class. The service always comes up as undefined.
import { NgModule, Component, OnInit} from '@angular/core';
import { EntityrecordApi } from '../sdk/services/custom';
import { Injectable, Inject } from '@angular/core';
import { FormlyFieldSelect } from 'ng2-formly';

@Component({
  selector: 'formly-field-lookup-select',
  providers: [EntityrecordApi],
  template:'
Test
'
})

export class LookupSelect extends FormlyFieldSelect implements OnInit{
  constructor(private _EntityrecordApi: EntityrecordApi) {
   super()
  }
  ngOnInit(): void {
   //Do Something here
    this._EntityrecordApi.find()
  }
}

Can you make a simple plnkr so that we can make that work?

Related to https://github.com/formly-js/ng2-formly/issues/277 I believe

Could this pull request be of any help to you? https://github.com/formly-js/ng2-formly/pull/286


Question about downloadfile

How can i set the max file size when i have to download

I think it can be similar to this:
var max_file_size = 1000;  // i think in bytes format
bot.downloadFile(file_id).then(function (resp) {
    if (resp.file_size < max_file_size){
        bot.downloadFile(file_id, "downloads/").then(function (resp) {
            // downloading...
        });
    }else{
        // too large
    }
});

This code is not tested by the concept is true.

@mattiamacr Confirm if it is functional


Added prettier as a dev dependency

@SahanDisa Can you try to add a script to run prettier

@SahanDisa let's remove node_modules files in the PR, and add a script in package.json to run prettier.
https://docs.npmjs.com/misc/scripts

Okey I will do as above
On Thu, 9 Jan 2020, 22:05 Rajika Imal<EMAIL_ADDRESS>wrote:

@SahanDisa https://github.com/SahanDisa let's remove node_modules files
in the PR, and add a script in package.json to run prettier.
https://docs.npmjs.com/misc/scripts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/99xt-incubator/json2bootgrid/pull/5?email_source=notifications&email_token=AMN3HFRY5ICVTHU7BGU2V3DQ45G5NA5CNFSM4KECDZ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIQ5MJA#issuecomment-572642852,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMN3HFUESYEU23YZPPHKHW3Q45G5NANCNFSM4KECDZ2Q
.


[feature request] make  atuin work with  shellclear

[feature request] make great atuin work with  shellclear
https://github.com/rusty-ferris-club/shellclear
That would be so cool!

This would actually be super cool. Perhaps we could use it to not even store sensitive info in the first place

Sometimes there are false positives. So I would still leave the final clearing to the user.


Subtitle Enhancements

Got 3 enhancements for subtitles:

When the subtitle mode is Always (and other selection methods fail), we should prefer a users native language before a non-native one. We could potentially add another option to always show subtitles if and only if one exists for the users native language.
Since the player only processes subtitles in order, we should ensure that order is based on time (I chose start time). In a perfect world, all subtitles are given in order. My specific use case are subs embedded in a mkv where multiple titles are on screen at the same time. This player doesn't support that and it's kind of ambiguous what to do with only a single subtitle box. Emby produces srt with subs that are out of order (based on start/end time). We should do something better than the appearance of missing subs when subs for the credits happen to be ordered before subs of the actual video. It's arguable whether a fix should be server side, but it's always good having more support client-side as well.
An off-by one error when subtitles end with a newline resulting in truncated subs.

Tested on the emulator and a D-series tv.

As of version 1.0.0 the code root has been moved to https://github.com/MediaBrowser/SamsungSmartTV
Can you make this request there please?

Done.
You should make a note of that in the readme of this repo, possibly removing the source files to encourage looking at the readme for why.


Arenadata patchset 58

ADBDEV-5789 #989
ADBDEV-6043 #1009 #1018 #1029 #1041
ADBDEV-5074 #1000 #1031
ADBDEV-6169 #1026
ADBDEV-6155 #1021
ADBDEV-4688 #1017
ADBDEV-6144 #1019
ADBDEV-6214 #1038
ADBDEV-6257 #1045
ADBDEV-6313 #1054
ADBDEV-6343 #1058
ADBDEV-6260 #1049
ADBDEV-6311 #1052
ADBDEV-6369 #1063
ADBDEV-6375 #1064

Fixes to run tests on Ubuntu were reverted to be replaced with the similar changes from develop. There were conflicts without reverting caused by patch ordering.

Allure report https://allure.adsw.io/launch/82496


chore(deps): upgrade rust-bitcoin to 0.32.0

partially fixes #1422
Description
It updates the rust-bitcoin to 0.32.0, the bitcoin crate dependency.
NOTE: The overall BDK update to 0.32.0 still requires and depends on some other crates, please refer to #1422.

Notes to the reviewers
It's open for any comments.

Changelog notice

Update the bitcoin crate dependency to 0.32.0

Checklists
All Submissions:

[x] I've signed all my commits
[x] I followed the contribution guidelines
[x] I ran cargo fmt and cargo clippy before committing

@notmandatory Were you thinking of bumping something else, or having other changes, as we'll have a new release ?
I think we could have #132 as well, but I am unsure if it could slow down things, as for reviewing, and testing ... 🤔


How to train objects to detect the shape of an electronic chip？

Hello: I would like to use dlib training to detect this shape object 100 * 100 size target image, search the large image is 2448 * 2048 size, is there a similar example?

It seems like it could be achieved with something like this: http://dlib.net/imaging.html#object_detector
Example programs:

C++
Python

Yeah that HOG detector should work super well for this.

Thank you, I refer to the example object_detector_advanced_ex.cpp achieve the same effect？

Thank you, I refer to the example object_detector_advanced_ex.cpp achieve the same effect？

I mean, you can, but like the advanced example says at the top, you have to be familiar with http://dlib.net/train_object_detector.cpp.html first before it will make any sense to you.  And for what you want you really do just want the HOG one.


No docs for Bool.isEq

This might have something to do with:
Eq implements
    ## Returns `Bool.true` if the input values are equal.
    isEq : a, a -> Bool where a implements Eq

Maybe this puts isEq in scope, which in turn is exposed in the module header? That's not how ability members would ideally work (they wouldn't get added to scope, ideally), but it might be how it works right now.
Note: Once we fix this, we should move the FAQ entry on function equality into the Bool.isEq docs.

Also happens for Hash.hash


Mac OSX lacks realpath

The gcloud scripts depend on realpath to locate the function library, without it you get
+++ dirname /path-to-my-tfdir/modules/agent-policy/scripts/create-update-script.sh module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): ++ realpath /path-to-my-tfdir/modules/agent-policy/scripts module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): /path-to-my-tfdir/modules/agent-policy/scripts/create-update-script.sh: line 38: realpath: command not found module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): + SCRIPT_DIR= module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): + UTILS_ABS_PATH=/script-utils.sh module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): + source /script-utils.sh module.admin_agent_policy.module.gcloud-upsert.null_resource.run_command[0] (local-exec): /path-to-my-tfdir/modules/agent-policy/scripts/create-update-script.sh: line 41: /script-utils.sh: No such file or directory
Interestingly, the scripts don't elevate that error up to terraform, which thinks the terraform apply worked just fine, but leaving an empty state file and no actual policies.
A workaround is to use homebrew to install coreutils, which has realpath, but the scripts really should either not depend on it, or catch the lack and the failure to execute.

I just realized I accidently opened this on the ansible branch, not the terraform code.

I just realized I accidently opened this on the ansible branch, not the terraform code.

No worries, this is the link for terraform: https://github.com/terraform-google-modules/terraform-google-cloud-operations


Compilation Error with 4.0.4 and 4.1.1

Godot version
Godot 4.0.4 stable and Godot 4.1.1
System information
Windows11
Issue description
When I compiling with lastest Next visual script.it appears:
"D:\Godot\Codes\20230816\godot-4.0.4-stable\godot-4.0.4-stable\modules\visual_script\editor/visual_script_editor.h(38): fatal error C1083: 无法打开包括文件: “scene/resources/style_box_flat.h”: No such file or directory
scons: *** [modules\visual_script\register_types.windows.editor.x86_64.obj] Error 2"
Steps to reproduce
When I compiling with lastest Next visual script.
Minimal reproduction project
When I compiling with lastest Next visual script.

I'll take a look.

% git diff
diff --git a/editor/visual_script_property_selector.cpp b/editor/visual_script_property_selector.cpp
index d79b01b..fe2c3d0 100644
--- a/editor/visual_script_property_selector.cpp
+++ b/editor/visual_script_property_selector.cpp
@@ -42,7 +42,7 @@
 #include "editor/editor_node.h"
 #include "editor/editor_scale.h"
 #include "editor/editor_settings.h"
-#include "editor/visual_script_property_selector.h"
+#include "modules/visual_script/editor/visual_script_property_selector.h"
 #include "scene/main/node.h"
 #include "scene/main/window.h"

I did this.

The next branch is based on master which is 4.2.
I'll post a top commit. https://github.com/godotengine/godot/commit/5444afae63f37cb4b890c781e5679a3b7ee5a392

Can you check?

Can you check?

OK,I'll check it.

diff --git a/editor/visual_script_property_selector.cpp b/editor/visual_script_property_selector.cpp
index d79b01b..fe2c3d0 100644
--- a/editor/visual_script_property_selector.cpp
+++ b/editor/visual_script_property_selector.cpp
@@ -42,7 +42,7 @@
 #include "editor/editor_node.h"
 #include "editor/editor_scale.h"
 #include "editor/editor_settings.h"
-#include "editor/visual_script_property_selector.h"
+#include "modules/visual_script/editor/visual_script_property_selector.h"
 #include "scene/main/node.h"
 #include "scene/main/window.h"

I did this.

I checked it,but still appears this below:
vp8l_dec.c
modules\visual_script\editor\visual_script_property_selector.cpp(45): fatal error C1083: 无法打开包括文件: “editor/visual_script_property_selector.h”: No such file or directory
vp8_dec.c
scons: *** [modules\visual_script\editor\visual_script_property_selector.windows.editor.x86_64.obj] Error 2

The next branch is based on master which is 4.2.
I'll post a top commit. godotengine/godot@5444afa

I'm compiling with 4.2 dev3,but still have some issues:
vp8l_dec.c
modules\visual_script\editor\visual_script_property_selector.cpp(45): fatal error C1083: 无法打开包括文件: “editor/visual_script_property_selector.h”: No such file or directory
vp8_dec.c
scons: *** [modules\visual_script\editor\visual_script_property_selector.windows.editor.x86_64.obj] Error 2

Can you check?

I tried twice and have this:
modules\visual_scrip                                                                                pt\editor\visual_script_property_selector.cpp(45): fatal error C1083: 无法打开包括文件: “editor/visual_script_property_selector.h”: No such file or directory
sharpyuv_dsp.c
[Initial build] sharpyuv_sse2.c
sharpyuv_neon.c
[Initial build] sharpyuv_gamma.c
[Initial build] Compiling thirdparty\libwebp\src\dec\alpha_dec.c ...
scons: *** [modules\visual_script\editor\visual_script_property_selector.windows.editor.x86_64.obj] Error 2
alpha_dec.c
modules\visual_script\editor\visual_script_editor.cpp(2214): warning C4458: “data”的声明隐藏了类成员
.\scene/gui/control.h(262): note: 参见“Control::data”的声明
modules\visual_script\editor\visual_script_editor.cpp(4045): warning C4458: “script”的声明隐藏了类成员
D:\Godot\Codes\20230816\godot-4.2-dev3\godot-4.2-dev3\modules\visual_script\editor\visual_script_editor.h(104): note: 参见“VisualScriptEditor::script”的声明

Can you check?

I tried it with lastest godot main code but I got this:
io_dec.c
modules\visual_script\editor\visual_script_property_selector.cpp(45): fatal error C1083: 无法打开包括文件: “editor/visual_script_property_selector.h”: No such file or directory
[Initial build] Compiling thirdparty\libwebp\src\dec\quant_dec.c ...
[Initial build] Compiling thirdparty\libwebp\src\dec\tree_dec.c ...
[Initial build] quant_dec.c
Compiling thirdparty\libwebp\src\dec\vp8_dec.c ...
tree_dec.c
vp8_dec.c
[Initial build] scons: *** [modules\visual_script\editor\visual_script_property_selector.windows.editor.x86_64.obj] Error 2
Compiling thirdparty\libwebp\src\dec\vp8l_dec.c ...
vp8l_dec.c
modules\visual_script\editor\visual_script_editor.cpp(2214): warning C4458: “data”的声明隐藏了类成员
.\scene/gui/control.h(262): note: 参见“Control::data”的声明
modules\visual_script\editor\visual_script_editor.cpp(4045): warning C4458: “script”的声明隐藏了类成员
D:\Godot\Codes\20230816\godot-master\godot-master\modules\visual_script\editor\visual_script_editor.h(104): note: 参见“VisualScriptEditor::script”的声明

I tested https://github.com/V-Sekai/godot_visual_script.git @ next branch recently. That's odd.

I tested https://github.com/V-Sekai/godot_visual_script.git @ next branch recently on master. That's odd.
It passed cicd. #55

I tried again with lastest main code of 4.2,but still got this:
modules\visual_script\editor\visual_script_property_selector.cpp(45): fatal error C1083: 无法打开包括文件: “editor/visual_script_property_selector.h”: No such file or directory
[Initial build] Compiling thirdparty\libwebp\src\dec\alpha_dec.c ...
scons: *** [modules\visual_script\editor\visual_script_property_selector.windows.editor.x86_64.obj] Error 2
alpha_dec.c
modules\visual_script\editor\visual_script_editor.cpp(2214): warning C4458: “data”的声明隐藏了类成员
.\scene/gui/control.h(262): note: 参见“Control::data”的声明
modules\visual_script\editor\visual_script_editor.cpp(4045): warning C4458: “script”的声明隐藏了类成员
D:\Godot\Codes\20230816\godot-master\godot-master\modules\visual_script\editor\visual_script_editor.h(104): note: 参见“VisualScriptEditor::script”的声明

what are your git hashes?

diff --git a/editor/visual_script_property_selector.cpp b/editor/visual_script_property_selector.cpp
index d79b01b..fe2c3d0 100644
--- a/editor/visual_script_property_selector.cpp
+++ b/editor/visual_script_property_selector.cpp
@@ -42,7 +42,7 @@
 #include "editor/editor_node.h"
 #include "editor/editor_scale.h"
 #include "editor/editor_settings.h"
-#include "editor/visual_script_property_selector.h"
+#include "modules/visual_script/editor/visual_script_property_selector.h"
 #include "scene/main/node.h"
 #include "scene/main/window.h"

I did this.

Well done!
Haha,I got it that I forgot to make this change,when I change this and compile,It works!!
I realized you had updated the codes,then I re-download it,but forgot to check this line.
Thanks very much,and expecting the updates and new funtions.

I tested https://github.com/V-Sekai/godot_visual_script.git @ next branch recently on master. That's odd.
It passed cicd. #55

Now I had compiled it sucessful,and I check it,but I found it,the visual script right click search box still very slow.

Now I had compiled it sucessful,and I check it,but I found it,the visual script right click search box still very slow.

Sounds like progress, I'm thinking of merging the next branch to the main repo then.

Visual script flow nodes are missing.
Survey ux
Fix visual script guess nodes to be "self" instead of "instanced".
Restore visual script native functions.
Slow lookups

Now I had compiled it sucessful,and I check it,but I found it,the visual script right click search box still very slow.

Sounds like progress, I'm thinking of merging the next branch to the main repo then.
TODO

Visual script flow nodes are missing.
Survey ux
Fix visual script guess nodes to be "self" instead of "instanced".
Restore visual script native functions.
Slow lookups

I fixed slow lookups,it is smooth now,but there are some differences in the codes.
Can you check?

Going to close this issue as the branch now is on top of Godot Engine master.
Will make an issue for the slow lookups. We can continue there.


fix: Allowing Images with Hyperlinks

Description
Fixed functionality for adding hyperlinked images into a carousel component.
Added reformatHyperlinkImages function to reformat HTML.
Added an if statement to create proper left/right containers for hyperlinked images
Related Issue
Jira ticket: link
Motivation and Context
Erin asked for it a couple days ago on Slack. Allows hyperlinked images to be in carousels
How Has This Been Tested?
I created a carousel with a few hyperlinked and regular images and tested that the hyperlinks and images were formatted correctly. The hyperlinks also work. Here's a link to the google doc I used to test: link
Note that the first 2 images are hyperlinked and the last is not.
Screenshots
The old functionality:

New Functionality:

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Can you make branch you want to merge into stage?

Yahoo! I think I changed it. LMK if this works.

test url: https://devsite-1185--adobe-io-website--adobe.hlx.page/test/eli


App Size Increased

While adding pdf.js library in my android app , it increased the size of my app by 4 MB.
Is this expected or weird ? since we cant afford increasing the size increase of 4MB.

You need to keep in mind that the PDF is a big and complex format, with a lot of functionality/features included, hence parsing/rendering PDF documents will require a fair amount of code. There's really no way around that!
The only "solution" here would probably may be to use a minified version of the PDF.js library, see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#minified


unit test IDE execution improvements

I was having trouble with running the unit tests locally. With this solution the unit tests can be run one by one from the IDE on the already checked in test json files.
What I did is: load the test data json files from the file system with standard java instead of through android context in order to allow more convenient execution of unit tests.
I've only tested this on Windows.

Ohh well, looks like the CI does not like it yet. I'll check out what's going wrong on Linux.

I don't understand what the problem is you are trying to solve. I admit the current setup has only been tested on Linux and MacOS. But I believe that even on Windows the android gradle plugin should handle the assets inclusion.
https://github.com/xbmc/Kore/blob/master/app/build.gradle#L42
Did you run the testFullDebugUnitTest or testInstrumentationTestDebugUnitTest? As described in https://github.com/xbmc/Kore/blob/master/app/src/test/README.md

Hi @poisdeux
Yes while gradlew.bat testFullDebugUnitTest works.

Select build variant "instrumentationTestDebug"
Set the (Project view)[https://developer.android.com/studio/projects/index.html] to Android
Right-click on the directory "test" and select "Run tests"

This does not work for me. What I get is:
java.io.FileNotFoundException: build\intermediates\bundles\instrumentationTest\debug\assets\Video.Details.Movie.json (The system cannot find the path specified)

	at java.io.FileInputStream.open0(Native Method)
	at java.io.FileInputStream.open(FileInputStream.java:195)
	at java.io.FileInputStream.<init>(FileInputStream.java:138)
	at org.robolectric.res.FileFsFile.getInputStream(FileFsFile.java:78)
	at org.robolectric.shadows.ShadowAssetManager.open(ShadowAssetManager.java:179)
	at android.content.res.AssetManager.open(AssetManager.java)
	at org.xbmc.kore.testutils.FileUtils.readFile(FileUtils.java:26)
	at org.xbmc.kore.testutils.Database.insertMovies(Database.java:87)
	at org.xbmc.kore.testutils.Database.fill(Database.java:48)
	at org.xbmc.kore.provider.mediaprovider.AbstractTestClass.setUp(AbstractTestClass.java:53)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:248)
	at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:174)
	at org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:63)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:140)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:117)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:262)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:84)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

Which is not that surprising considering in the IDE's gradle console this is what I see:
Executing tasks: [:app:generateInstrumentationTestDebugSources, :app:prepareInstrumentationTestDebugUnitTestDependencies, :app:mockableAndroidJar, :app:compileInstrumentationTestDebugUnitTestSources]

Configuration on demand is an incubating feature.
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to D:\android-sdks\ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

Incremental java compilation is an incubating feature.
:app:preBuild UP-TO-DATE
:app:preInstrumentationTestDebugBuild UP-TO-DATE
:app:checkInstrumentationTestDebugManifest
:app:preFullDebugBuild UP-TO-DATE
:app:extractProguardFiles
:app:preFullReleaseBuild
:app:preInstrumentationTestReleaseBuild
:app:prepareAtBlogcExpandabletextview103Library
:app:prepareComAndroidSupportAnimatedVectorDrawable2501Library
:app:prepareComAndroidSupportAppcompatV72501Library
:app:prepareComAndroidSupportCardviewV72501Library
:app:prepareComAndroidSupportPreferenceV142501Library
:app:prepareComAndroidSupportPreferenceV72501Library
:app:prepareComAndroidSupportRecyclerviewV72501Library
:app:preFullDebugAndroidTestBuild UP-TO-DATE
:app:preInstrumentationTestDebugAndroidTestBuild UP-TO-DATE
:app:prepareComAndroidSupportSupportCompat2501Library
:app:prepareComAndroidSupportSupportCoreUi2501Library
:app:prepareComAndroidSupportSupportCoreUtils2501Library
:app:prepareComAndroidSupportSupportFragment2501Library
:app:prepareComAndroidSupportSupportMediaCompat2501Library
:app:prepareComAndroidSupportSupportV132501Library
:app:prepareComAndroidSupportSupportV42501Library
:app:prepareComAndroidSupportSupportVectorDrawable2501Library
:app:prepareComAstuetzPagerslidingtabstrip101Library
:app:prepareComMelnykovFloatingactionbutton130Library
:app:prepareComSothreeSlidinguppanelLibrary331Library
:app:prepareInstrumentationTestDebugDependencies
:app:compileInstrumentationTestDebugAidl UP-TO-DATE
:app:compileInstrumentationTestDebugRenderscript UP-TO-DATE
:app:generateInstrumentationTestDebugBuildConfig UP-TO-DATE
:app:generateInstrumentationTestDebugResValues UP-TO-DATE
:app:generateInstrumentationTestDebugResources UP-TO-DATE
:app:mergeInstrumentationTestDebugResources UP-TO-DATE
:app:processInstrumentationTestDebugManifest UP-TO-DATE
:app:processInstrumentationTestDebugResources UP-TO-DATE
:app:generateInstrumentationTestDebugSources UP-TO-DATE
:app:preInstrumentationTestDebugUnitTestBuild UP-TO-DATE
:app:prepareInstrumentationTestDebugUnitTestDependencies
:app:mockableAndroidJar UP-TO-DATE
:app:incrementalInstrumentationTestDebugJavaCompilationSafeguard UP-TO-DATE
:app:javaPreCompileInstrumentationTestDebug
:app:compileInstrumentationTestDebugJavaWithJavac UP-TO-DATE
:app:incrementalInstrumentationTestDebugUnitTestJavaCompilationSafeguard UP-TO-DATE
:app:javaPreCompileInstrumentationTestDebugUnitTest
:app:compileInstrumentationTestDebugUnitTestJavaWithJavac UP-TO-DATE
:app:processInstrumentationTestDebugJavaRes UP-TO-DATE
:app:processInstrumentationTestDebugUnitTestJavaRes UP-TO-DATE
:app:compileInstrumentationTestDebugUnitTestSources UP-TO-DATE

BUILD SUCCESSFUL

Total time: 1.099 secs

No mention of testFullDebugUnitTest.
This is also the type of exception I get when I try to run a single test class from the IDE say GenresTest.
My goal here in this PR is to allow running any unit tests on it's own from within the IDE.
My concern is that the whole test suit only consists of 33 test (1 ignored) yet it takes about 54.528 secs to run testFullDebugUnitTest. In my opinion this is too long for so few tests. So to help with running new (hopefully faster) unit tests, developers should be able to run their own tests (or a subset of tests) from the IDE without them failing because of asset setup is not working for such a scenario.

Oops, sorry about that. I've updated the docs in PR #460.
Actually the testInstrumentationTestDebugUnitTest should still work AFAICT from the gradle file. However, we use fullDebugUnitTest on travis-ci, so it never occurred to me that the instrumentationTest flavour is broken for local tests.
But your solution is not the right way to fix this. It should be handled by the android gradle plugin.
However, I wouldn't bother fixing this for instrumentationTest. It is included only to be able to disable animations. But that can now be disabled using the android gradle plugin ( \o/ )
testOptions {
        animationsDisabled true
    }

So the instrumentationTest flavour will probably be removed and you should use the fullDebug flavour for local tests. This should also allow you to select individual tests.
Regarding your remark about performance, I wouldn't bother optimising just yet. 58 secs is fine and I wouldn't expect anyone to run these tests on each build. If you do want to do this, I suggest you implement running the local tests in the background so the build finishes quickly while the tests continue to run in the background and provide feedback a few seconds later...
Final remark, if you do want to optimise, have a look at the setUp method. I believe none of the tests actually changes the database so we only have to set it up once. But, well, you know what they say about premature optimisation...

Hi @poisdeux
Just to try and make my point a bit more clear: I'm not having issues with running tests from command line.
Without these changes I can not run some tests individually (the ones that rely on DB setup from the .json asset files), because to me it looks like nothing makes them available where they are expected to be:
java.io.FileNotFoundException: build\intermediates\bundles\full\debug\assets\Video.Details.Movie.json (The system cannot find the path specified)
This is the main issue I was trying to address with this PR.
Having a global setup for UNIT tests is a big no-no for me. In my opinion UNIT tests need to set up and tear down everything for every test run.
To be fair tests touching DB are not really unit tests in my opinion to begin with, so in that regard I see your point, but then for me the solution would be is to move tests that interact with a DB out (so they are not run along with "real" unit tests). Would you consider such an approach acceptable?

Could you test if the fullDebug flavour allows you to run individual tests? If so, this PR can be closed.
I agree that tests using a database aren't generally considered unit tests. That's why the tests under test are usually referred to as local tests. Meaning they do not require an Android device. We could add an extra layer below test to separate the fast from the slow tests or better yet use annotations. But what should be the criteria? 1 second, 2 seconds, 10 seconds, 1 minute? And what do we use as a reference build machine? An octacore with 128 GB RAM?

Without the code from the PR: From within the IDE I can NOT run individual tests with ANY flavor, including fullDebug.
With the code from the PR:  I CAN run individual tests with ANY flavor, including fullDebug
I feel you are being a bit sarcastic there. :D
You'd generally use the most common developer machine for unit test speed measurement.  I'd say maximum 2 mins for 1000 unit tests, that's <=0.12s per test in average.

I am only able to reproduce your issue when using the instrumentationTest flavour.
I think this is more an issue with your Android Studio setup. However, I don't own a windows machine on which I can try to reproduce this. So, I think we should go with your fix.
@SyncedSynapse do you by any chance have a Windows machine at your disposal and able to reproduce this issue?
Can you please refactor this PR to only include only the asset fix and create a separate PR for the performance issue? Than we can merge this and discuss the performance improvements further using the other PR.

The PR is only about asset inclusion already.
The kind of performance improvement I was talking about is perhaps just a perceived one. With this I can run just a single or a selected few tests, which is inherently faster than running all the unit tests.

I thought you added readFile for performance reasons and the actual fix for the assets is in the gradle.build file. https://github.com/xbmc/Kore/pull/459/files#diff-39e7d8c00954e920b98e7636f0ac30b2R176

copyUnitTestResources is a new task that copies the json assets to a build flavor independent location. The other changes are there to load them from this location, instead of using the android context which then would use build flavor dependent path because of context.getAssets().

Ah I see, thx for explaining. Good news, I was able to reproduce the issue on my build environment as well. (./gradlew clean did the trick...)
This problem seems similar to something I encountered when upgrading to android gradle plugin 2.3.3 in PR #431. To fix that, I made sure the assembleFullDebug was called to copy the assets.
If we change testFullDebugUnitTest to compileFullDebugUnitTestSources in app/build.gradle on line 172, it should work for running individual local tests as well.
Can you confirm?

Nope, sorry. Still getting the same error even if I make the change you are proposing.

Can you post the Gradle Console output from Android Studio while running an individual test using the fullDebug flavour?

Executing tasks: [:app:generateFullDebugSources, :app:prepareFullDebugUnitTestDependencies, :app:mockableAndroidJar, :app:compileFullDebugUnitTestSources]

Configuration on demand is an incubating feature.
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to C:\Users\vatam\AppData\Local\Android\sdk\ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

Incremental java compilation is an incubating feature.
:app:preBuild UP-TO-DATE
:app:preFullDebugBuild UP-TO-DATE
:app:checkFullDebugManifest
:app:extractProguardFiles
:app:preFullReleaseBuild
:app:preInstrumentationTestDebugBuild UP-TO-DATE
:app:preInstrumentationTestReleaseBuild
:app:prepareAtBlogcExpandabletextview103Library
:app:prepareComAndroidSupportAnimatedVectorDrawable2501Library
:app:prepareComAndroidSupportAppcompatV72501Library
:app:prepareComAndroidSupportCardviewV72501Library
:app:prepareComAndroidSupportPreferenceV142501Library
:app:prepareComAndroidSupportPreferenceV72501Library
:app:prepareComAndroidSupportRecyclerviewV72501Library
:app:preFullDebugAndroidTestBuild UP-TO-DATE
:app:preInstrumentationTestDebugAndroidTestBuild UP-TO-DATE
:app:prepareComAndroidSupportSupportCompat2501Library
:app:prepareComAndroidSupportSupportCoreUi2501Library
:app:prepareComAndroidSupportSupportCoreUtils2501Library
:app:prepareComAndroidSupportSupportFragment2501Library
:app:prepareComAndroidSupportSupportMediaCompat2501Library
:app:prepareComAndroidSupportSupportV132501Library
:app:prepareComAndroidSupportSupportV42501Library
:app:prepareComAndroidSupportSupportVectorDrawable2501Library
:app:prepareComAstuetzPagerslidingtabstrip101Library
:app:prepareComMelnykovFloatingactionbutton130Library
:app:prepareComSothreeSlidinguppanelLibrary331Library
:app:prepareFullDebugDependencies
:app:compileFullDebugAidl UP-TO-DATE
:app:compileFullDebugRenderscript UP-TO-DATE
:app:generateFullDebugBuildConfig UP-TO-DATE
:app:generateFullDebugResValues UP-TO-DATE
:app:generateFullDebugResources UP-TO-DATE
:app:mergeFullDebugResources UP-TO-DATE
:app:processFullDebugManifest UP-TO-DATE
:app:processFullDebugResources UP-TO-DATE
:app:generateFullDebugSources UP-TO-DATE
:app:preFullDebugUnitTestBuild UP-TO-DATE
:app:prepareFullDebugUnitTestDependencies
:app:mockableAndroidJar UP-TO-DATE
:app:incrementalFullDebugJavaCompilationSafeguard UP-TO-DATE
:app:javaPreCompileFullDebug
:app:compileFullDebugJavaWithJavac UP-TO-DATE
:app:compileFullDebugNdk UP-TO-DATE
:app:compileFullDebugSources UP-TO-DATE
:app:mergeFullDebugShaders UP-TO-DATE
:app:compileFullDebugShaders UP-TO-DATE
:app:generateFullDebugAssets UP-TO-DATE
:app:mergeFullDebugAssets UP-TO-DATE
:app:transformClassesWithDexForFullDebug UP-TO-DATE
:app:mergeFullDebugJniLibFolders UP-TO-DATE
:app:transformNativeLibsWithMergeJniLibsForFullDebug UP-TO-DATE
:app:processFullDebugJavaRes UP-TO-DATE
:app:transformResourcesWithMergeJavaResForFullDebug UP-TO-DATE
:app:validateSigningFullDebug
:app:packageFullDebug UP-TO-DATE
:app:assembleFullDebug UP-TO-DATE
:app:incrementalFullDebugUnitTestJavaCompilationSafeguard UP-TO-DATE
:app:javaPreCompileFullDebugUnitTest
:app:compileFullDebugUnitTestJavaWithJavac UP-TO-DATE
:app:processFullDebugUnitTestJavaRes UP-TO-DATE
:app:compileFullDebugUnitTestSources UP-TO-DATE

BUILD SUCCESSFUL

Total time: 1.158 secs

OK, I've found what was the problem. For the run configuration in the IDE the Working Directory was not set, once I've set it to MODULE_DIR I could run single tests with only the compileFullDebugUnitTestSources change.
Maybe could add this tid-bit to the README.md

I'll close this and opened #463 instead.


Uncaught TypeError: bodymovin.loadAnimation is not a function

Hi ,
I have animation Composition done in after effects then i used bodymovin to create json file. Then i tried to use that in a demo html you have given along with the zip files. and changed the script location to my newly created json.  but i get this error.
"Uncaught TypeError: bodymovin.loadAnimation is not a function." just let me know how to proceed. whether is there any alternative function? to use or we have define the function prior? or any other solution
I also tried to play a little with all the setting options of "bodymovin" in after effects in that there was an option to save as html. that one works but i am not getting the colors information as accurately. It actually took the solid color but i applied a gradient effect on the solid which didnt reflect in the html page, Just let me know what i would have missed.
Thanks,
Muthu

What is the environment you're using bodymovin in? It sounds like you haven't imported the plugin .js file. That would be my first guess as to why you're getting that error.


ctrl + left click in vue cannot jump to components

/needsMoreInfo
Please provide all info required by issue template.
Vue is not supported out of the box and you need to use extension for Vue specific features e.g. Vetour


Should update the CHANGELOG.md after release

Document that step in the manual release steps so that we remember to do it. Pointed out on https://github.com/impress/impress.js/pull/572/files#r69710339

Also it should be updated in js/impress.js.


[ERR]: LY: Too many instances of "interfaces" in "data tree". (/ietf-interfaces:interfaces)

Hi,
I'm still using

libyang-1.0.176
sysrepo-1.4.66
netopeer2-1.1.34

When setting a configuration containing multiple instances of ietf-interface object (among others) get the following error message:
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: LY: Resolving unresolved data nodes and their constraints...
[INF]: LY: All data nodes and constraints resolved.
[INF]: SR: Published event "rpc" "/ietf-netconf:edit-config" with ID 1 priority 0 for 1 subscribers.
[INF]: SR: Processing "/ietf-netconf:edit-config" "rpc" event with ID 1 priority 0 (remaining 1 subscribers).
[INF]: NP: edit-config test-option "set" not supported, validation will be performed.
[ERR]: LY: Too many instances of "interfaces" in "data tree". (/ietf-interfaces:interfaces)
[INF]: SR: Failed processing of "rpc" event with ID 1 priority 0 (remaining 1 subscribers).
[ERR]: SR: Too many instances of "interfaces" in "data tree".
[WRN]: SR: Event "rpc" with ID 1 priority 0 failed (libyang error).
[ERR]: NP: Failed to send an RPC (User callback failed).
[INF]: NP: Session 1: thread 3 event new RPC.
[INF]: NP: Session 1: thread 3 event reply error.
Question: what is the limit of the number of instances in a given configuration request and how this limit can be increased?
Thank you in advance.
Igor

Hi Igor,
the problem is different based on this error, you can have as many instances of /ietf-interfaces/interfaces/interface as you want since it is a list, but you have created multiple instances of /ietf-interfaces/interfaces, which is forbidden as it is a container.
Regards,
Michal

Thank you Michal.
Regards,
Igor
On Tue, Jul 28, 2020 at 5:09 PM Michal Vasko<EMAIL_ADDRESS>wrote:

Hi Igor,
the problem is different based on this error, you can have as many
instances of /ietf-interfaces:interfaces/interface as you want since it
is a list, but you have created multiple instances of
/ietf-interfaces:interfaces, which is forbidden as it is a container.
Regards,
Michal
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CESNET/netopeer2/issues/684#issuecomment-664820377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEX4KWZVG2IQ2MD3ONSBM63R5Z2Q7ANCNFSM4PKBNTPQ
.


neigh: add runtime test for changing next hop address

See commit for details.

test-runtime

(CI green, only runtime needed given nothing else affected)


Appstudio update test-component-pac-obbn

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-obbn-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
1 minute
sast-snyk-check

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
41 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
9 seconds
show-sbom

✅ Succeeded
11 seconds
show-summary

Pipelines as Code CI/test-component-pac-obbn-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
25 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
58 seconds
build-container

✅ Succeeded
6 seconds
sast-snyk-check

✅ Succeeded
36 seconds
deprecated-base-image-check

✅ Succeeded
40 seconds
inspect-image

✅ Succeeded
7 seconds
clair-scan

✅ Succeeded
42 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
25 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary


Week 5 Day 5 morning session

[Optinal]:- That I think your Contact Me session has less text area

Great work @raihan2bd this is very impressive! Just Keep it up!

What you can just consider is the comment from the other code reviewer @Hassaanjbaig-code


concurent queries

Peewee recomends to conect() just before request and close() after executing user code.
i.e. from documentation:
http://docs.peewee-orm.com/en/latest/peewee/database.html#creating-a-database-connection-and-tables
database = SqliteDatabase('my_app.db')

def before_request_handler():
    database.connect()

def after_request_handler():
    database.close()

On async app handlers are coroitines and requests can be processed while another one waiting bigger data.
Is there way to get another connection from pool and do requsts on it instead of using shared database connection?
Context manager maybe?
related #53

Managing your database connections is as simple as calling connect() when you need to open a connection, and close() when you are finished. In a web-app, you would typically connect when you receive a request, and close the connection when you return a response. Because connection state is stored in a thread-local, you do not need to worry about juggling connection objects – peewee will handle it for you.

Is coroutines runnind in one single thread?

@alex-eri If you're using pooled connection driver it internally does acquire connection per request (or per transaction if used). Yes, all connections live on a single thread.

Are coroutines (not about driver, my or server asyncs) running in single thread? If they single threaded - it uses one connection.
So i need context processor  db.execution_context() or not?

I asked https://ru.stackoverflow.com/a/720586/16574 (in russian)
An event loop runs in a thread and executes all callbacks and tasks in the same thread.
Then we acquire connection it stored in thread-local, acquire new connection replaces old. If second call comes before first executes query, then first and second query runs in second connection.
Seems it happened in #53.
So creating connections as db.connect() not safe.
We need rewrite connections to use db.execution_context() API. It stored in variable, not in thread storage.
http://docs.peewee-orm.com/en/latest/peewee/database.html#advanced-connection-management

@alex-eri Not sure if I understand you - It's not really related to ORM itself. There are several async database drivers, i.e. aiopg - it runs many connections on single asyncio loop and is fine with that and we just wrap that functionality into ORM. And we don't use thread-locals of course, we have asyncio-task based context when necessary.

Then we acquire connection it stored in thread-local

Where did you see this?

So creating connections as db.connect() not safe.

And we don't do so (well, supposed no to do so - or there's a bug somewhere). For PosgreSQL we create all coonections via aiopg.create_pool() call, like here: https://aiopg.readthedocs.io/en/stable/core.html#pool

i know about pool.
Where connection stored?

@alex-eri We don't normally manage storing connections, they are stored under the hood of async driver, like that:
@asyncio.coroutine
def acquire(self):
    """Acquire connection from pool.
    """
    return (yield from self.pool.acquire())

Our "database" class for PostgreSQL is actually a wrapper around connection pool from aiopg and that lib stores connections internally.
So normally we're just acquiring a new connection for every request and don't store them anywhere, see _run_sql()

peewee docs

We don't use peewee database management logic, we have our own methods and don't execute original peewee's connect() etc.
Could you provide some code to demonstrate your concerns?

So i dont need to connect() and close() connect in every request as in sync peewee?

looking at _run_sql. it runs database.cursor_async(). it run self.connect_async(). there it stores connection in self._async_conn. i.e. on database instance, which is shared.
Connection can be replaced by another call while first running.
Code is not thread-safe (sync peewee is thread-safe). BTW only thead-safe is not
sufficient with asyncio. One "await" switches context.
We need to remove _async_conn attribute and pass it as argument through.

On the line 875 we have:
       if self._async_conn:
            return

So connect_async() is called once to initialize a connection pool. AsyncDatabase class is not the same as in original peewee, it's just a single instance per application (usually) - wrapper to real async database driver which handles multiple connections under the hood.

Okey. Thanks alot for disribes!


⚠ Minecraft has degraded performance

In 467bbb8, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 944 ms

Resolved: Minecraft performance has improved in faaf6e8.


Proposal: allow ANSI colors in docker ps

Hi,
I've been trying to create a pull request to add a new flag to the docker ps command. I was trying to add -c/--colors to show:

red for the exited containers.
green for the running ones.
yellow for the restarting.

The PR was kinda easy, but the problem is that text/tabwriter from the Golang standard library doesn't seem to allow the special chars needed, for example: \x1b[0m. With "doesn't allow" I mean that the colors are added to the output, but the length of them is added as well and those ANSI codes are invisible which makes the output look weird:

Perhaps this is going to be an issue in the future and the library should be changed? I couldn't manage to escape the lengths with the current situation and I don't think that it's possible (I double checked with some people and they agree). If you think that there is a solution without changing the library or that the change doesn't worth a change of library, please, let me know.

@duglin this make a lot of sense. I would expect something like git has the color.ui=true. Starting this with docker ps is a great idea. I wonder why this thread didn't get a lot of traction ?!?

See grc which now has docker support (Pretty popular general color-izer)
https://github.com/garabik/grc
I made some tweaks to the colors for docker-ps, please let me know if you see any issues:
https://github.com/garabik/grc/pull/27

It's pretty cool @derimagia, thanks!

See https://github.com/docker/docker/pull/22162

@jfrazelle what do you recommend to replace text/tabwriter?

Well you would need something to support colors but this would need to be
approved first before getting started and honestly IMO it's a large change
that will cause a bikeshed of what should be what color and more for
maintainers to maintain
On Wednesday, April 20, 2016, Thomas Gazagnaire<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle what do you recommend to
replace text/tabwriter?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/issues/9417#issuecomment-212353238

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

In #22162 I've just added the ability to add color in the --format string so everyone could add an alias to docker ps with its favorite colors.

We discussed this feature on https://github.com/docker/docker/pull/22162, and decided that we're not going to implement this; it's too much of a "nice to have", and there are existing solutions that allow colorizing the output (see https://github.com/docker/docker/issues/9417#issuecomment-202234604 above).
Thanks for suggesting though! And sorry that it's not accepted


[in_app_purchase_android] Implement BillingClient connection management and introduce BillingClientManager

This PR adds management of BillingClient connection to Android implementation of InAppPurchase. This should fix issues caused by lost connections.
New and previously existing connection management is extracted to a new component, BillingClientManager.
This component is exported in billing_client_wrappers.dart, so that it can also be used when interacting with BillingClient directly.
Fixes https://github.com/flutter/flutter/issues/110663
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I look forward to this PR being merged.
Thanks!!

@GaryQian Ping on this review.

@SynSzakala Overall looks good, just a few small nits. Let me know when you address them!

@SynSzakala It looks like there are some CLA signing issues where your secondary email needs to accept the CLA, or you can amend the commit that used your alternate email address and force-push.

@GaryQian Everything should be ready for merge now.

Thanks for this PR! The issue with lost connections leading to refunded purchases is hitting us pretty hard in production, so this is much appreciated.

@stuartmorgan @GaryQian Is anything preventing us from merging this?

@SynSzakala When you get a chance to fix the failing analyzer checks, we can move forwards with this. Thanks!

@SynSzakala It looks like the analyzer complaints are just warnings to do with 4 unneeded awaits. I was gonna send you a PR that deletes them, but I realized that there might then be CLA-type stuff to deal with. In any case, thanks again for this PR - it's substantial!

@GaryQian @stuartmorgan Cleared all comments (including unnecessary refactors), fixed analyzer issues. Looking forward to merge this!

@stuartmorgan @GaryQian Are there any additional steps needed to merge this? I don't have the access to add "autosubmit" label as suggested in Tree Hygiene

Are there any additional steps needed to merge this?

This needs a second review, per https://github.com/flutter/flutter/wiki/Tree-hygiene#getting-a-code-review
@bparrishMines Could you do the second review here, as the ecosystem-side codeowner for this plugin?

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.
Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.
Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!


HISAT2 aligner

Most of the basic code for running with HISAT2 and building its required references is now written. It seems to compile and start on some of the first processes. There's almost certainly stuff broken, but I figured if I create a pull-request then we can share the testing as it's slow.

Looks real nice, good job. Does it run at all?

It runs a little :) Testing more and bugfixing now, will get back to you when I think it's ready for a final test / merge.

Ok @Hammarn - ready to merge when you're happy (would be great if you could run a test again, haven't run it to completion with more than one file for a while).

Ok I've tested and the Pipeline ran to completion on Milou with human data, so I'm happy to merge this! 👍


Ability to dynamically calculate target table name and/or deprecate previous versions of a table

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2468
Originally created by @aaronsteers on 2020-12-01 23:35:29

Problem to solve
This is not a critical issue or blocker, but it's been coming up a bunch lately in my own organization while using Tapdance. We want to keep target database permissions at a minimum and have everything automated. But there's not a very clean way to do "fresh starts" or "full backfill" on a given table.
Triggering a full backfill is tricky in today's singer ecosystem. There are two steps which need to be performed in the case of either (a) requiring a full backfill or (b) creating a fresh start due to table definition changes.
Singer does a create job of auto-adding missing columns - but (for good reason) there is an aversion in the platform to destructive updates. This proposal would outline two paths to automating "major version" increments which require starting a new fresh version of the target table.
Target audience

As a data engineer, I don't want to have to perform a precise and synchronized manual operations in order to get a fresh start on a table.
As a data team lead, I don't want to have to closely supervise the manual operations required for a full backfill or "fresh start" on an existing table. I want the above to be possible and also to have confidence that no data loss will occur (unless explicitly performed or requested).

Further details
A typical target schema today might look like this:
raw_db
 |- raw_salesforce
     |- account
     |- opportunity
     |- user

After adding version numbers (starting with "2" to avoid confusion), the target schema after updating versions and rerunning the pipeline might look like:
raw_db
 |- raw_salesforce
     |- account          (prev version)
     |- account__v2      (new version)
     |- opportunity      (prev version)
     |- opportunity__v2  (new version)
     |- user             (prev version)
     |- user__v2         (new version)

Assuming this is consumed by a tool like dbt, the downstream transforms now automatically can union the data together and migrate safely to the new version. Optionally, an administrator can later drop the older table versions for data sensitivity reasons or just to reduce confusion.
Proposal
In outline:

Meltano would add a 'major version number' which can be incremented per table. The version number would be (optionally) configured per-table in meltano.yml. A command line interface could auto-bump the version number on a specific table, or on all tables in a given source.
The version number (if set) would be automatically concatenated as a suffix in the target table name, and it could also be concatenated into the state file path.
By optionally and simultaneously changing the state file path (or the bookmark within the state file), we can simultaneously break the connection to the prior version's bookmark - which then triggers a full table reload on next execution.

What does success look like, and how can we measure that?
If usage statistics are available, a metric of feature usage would be a good indicator of whether the feature is valuable to meltano users. Otherwise, it would be measurable in increased adoption of the tool and/or higher product satisfaction metrics on topics such as maintainability.
Regression test
(Ensure the feature doesn't cause any regressions)

[ ] Write adequate test cases and submit test results
[ ] Test results should be reviewed by a person from the team

Links / references
Please note that this was taken from GitLab, to be changed accordingly

View 2 previous comments from the original issue on GitLab

Still relevant, but this is basically Activate Version as I understand it


Broken on Apple silicon M1 arm64 machines

After building on an M1 macOS machine successfully with a brew install dotnet v6.0.103, running the project results in the following error attempting to link in an x64 library. How do you build and run on machines using Apple's current M1 chips? The link printed by the runtime leads me to believe this should work somehow.
`
➜  fhir-codegen git:(main) dotnet run --project src/fhir-codegen-cli
Failed to load Q, error: dlopen(/opt/homebrew/Cellar/dotnet/6.0.103/libexec/host/fxr/6.0.3/libhostfxr.dylib, 0x0001): tried: '/opt/homebrew/Cellar/dotnet/6.0.103/libexec/host/fxr/6.0.3/libhostfxr.dylib' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64'))
The library libhostfxr.dylib was found, but loading it from /opt/homebrew/Cellar/dotnet/6.0.103/libexec/host/fxr/6.0.3/libhostfxr.dylib failed

Installing .NET Core prerequisites might help resolve this problem.
https://go.microsoft.com/fwlink/?linkid=2063366
`

Hi @preston , the main branch is still running on DotNet Core 3.1.
The dev branch has been fully migrated to .Net 6.0.  It has not been merged yet because there is quite a bit of new development happening on it yet and I want a bit more progress before changing over the main branch.
That said, all of the existing functionality from the main branch should work and should contain no breaking changes.

The dev branch has been merged into main, though still at 2.0.0-beta1.  Local testing has worked, with no further external complaints.

@GinoCanessa  Update: I'm trying on main again, and the problem still persists. It seems to fail effectively due to https://github.com/dotnet/efcore/issues/24971 , which is significant because it will fail on every macOS machine released in the last few years, which use Apple's M1- and M2-family SOC silicon. Is there something fundamentally not available in whatever the "hostfxr" library is that will not work on ARM chips? I'd like to avoid beating my head against the wall if it's just not going to work with the current SDK builds. :)

@preston , I am not sure what is happening on your machine - perhaps something with brew?  I went and grabbed my M1 mac, and everything runs fine on 6.0.100, 6.0.202, and (latest) 6.0.401.  I simply ran the installer from https://dotnet.microsoft.com/en-us/download for ARM-64 (in each case... today I installed 401 to double-check).
I tested both the UI:
dotnet run --project src/FhirCodeGenBlazor/FhirCodeGenBlazor.csproj
and the CLI:
dotnet run --project src/fhir-codegen-cli/fhir-codegen-cli.csproj --language-help
Both run as expected.  Looking at the issue you link, I will note that nothing in this repo uses Entity Framework.
If you run a command like dotnet --list-sdks, what is it coming back with?  Looking at https://github.com/dotnet/runtime/issues/49712 , that error message was coming back from some SDK build/installation/compatibility issues (specifically in preview builds).

From what I've been reading there may have been some issues in prior runtime builds that messed up library architecture loading.. or something like that. On my M1 I've completely uninstalled the homebrew versions and am using the SDK and runtime downloads direct from Microsoft at https://dotnet.microsoft.com/en-us/download/dotnet/6.0 , but am still getting references to "x64" in the error ("install the runtime in the global location [/usr/local/share/dotnet/x64]"). I have a personal M2 that is "cleaner" I'm going to try next.
`
➜  fhir-codegen git:(main) dotnet --version
6.0.401
➜  fhir-codegen git:(main) dotnet run -p src/fhir-codegen-test-cli/fhir-codegen-test-cli.csproj
Warning NETSDK1174: The abbreviation of -p for --project is deprecated. Please use --project.
A fatal error occurred. The required library libhostfxr.dylib could not be found.
If this is a self-contained application, that library should exist in [/Users/preston/Developer/git/fhir-codegen/src/fhir-codegen-test-cli/bin/Debug/netcoreapp3.1/].
If this is a framework-dependent application, install the runtime in the global location [/usr/local/share/dotnet/x64] or use the DOTNET_ROOT environment variable to specify the runtime location or register the runtime location in [/etc/dotnet/install_location].
The .NET Core runtime can be found at:

https://aka.ms/dotnet-core-applaunch?missing_runtime=true&arch=x64&rid=osx.10.17-x64
`

Have you pulled this repo recently?  It looks like it is looking for libraries from .Net Core 3.1, which has been out of the main branch for at least 6 months.

AHAHAHA I was using the old TargetFramework definition and not "net6.0": https://github.com/microsoft/fhir-codegen/blob/a2cafc491dd52f43a0534c8b2c605b2662b814e7/src/fhir-codegen-cli/fhir-codegen-cli.csproj#L5
Thank you -- I should have caught that!


ec2 server create fails with error ERROR: undefined local variable or method `i' for #Chef::Knife::Ec2ServerCreate:0x00000000090946e8 for option --iam-profile

Version:
knife-ec2 v1.0.0 and chef v15.1.8 on workstation
Environment:
Doesn't matter
Scenario:
bundle exec knife ec2 server create -I ami-005bdb005fb00e791 -N dh-ubu-14  -U ubuntu --connection-protocol ssh --flavor t2.micro -c E:\Backup\Project\chef-starter\chef-repo\.chef\knife.rb -VV --sudo --yes --iam-profile dh-role

Steps to Reproduce:
Please run above command to create the server from workstation.
Expected Result:
Server should get created and bootstrapped.
Actual Result:
ERROR: undefined local variable or method `i' for #<Chef::Knife::Ec2ServerCreate:0x00000000090946e8>

Fix would be at https://github.com/chef/knife-ec2/pull/587/files#diff-0da44873959aafda9bacd02cd08c8f5cR142

@vsingh-msys Please fix this in https://github.com/chef/knife-ec2/pull/587

Fixed in commit 2a8adc8 of #587


Change name of Inserter to Positioner

As part of rehoming this project and rethinking the name, we now need to change the API before we have any real users 😄

Completed by #7


Flyout bugs

Description

Fixes trace detail flyout being too small
Fixes toggling between throughput/latency/error rate in service flyout

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #540 (9bb2377) into main (150a963) will increase coverage by 18.70%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #540       +/-   ##
=============================================
+ Coverage     53.92%   72.62%   +18.70%
  Complexity      272      272
=============================================
  Files           236       38      -198
  Lines          7653     2130     -5523
  Branches       1571      236     -1335
=============================================
- Hits           4127     1547     -2580
+ Misses         3331      421     -2910
+ Partials        195      162       -33

Flag
Coverage Δ

dashboards-observability
?

opensearch-observability
72.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...mponents/flyout_components/trace_detail_render.tsx

..._analytics/components/common/plots/service_map.tsx

...nents/helpers/custom_modals/custom_input_modal.tsx

...nents/explorer/visualizations/fields_accordion.tsx

...nents/explorer/slices/viualization_config_slice.ts

...-observability/common/constants/trace_analytics.ts

...ponents/common/helpers/ppl_docs/commands/rename.ts

...isualizations/shared_components/toolbar_button.tsx

.../components/explorer/hits_counter/hits_counter.tsx

...common/debounced_component/debounced_component.tsx

... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150a963...9bb2377. Read the comment docs.


Refine GPRs for Alanine, Aspartate and Glutamate subsystem

Description of the issue:

Enzyme
rxn
grRules
GPT result
GPT reason
Action

ENSG00000134864
MAR06972: 5-oxoproline[c] + GSH[c] <=> gamma-glutamylglutathione[c]
ENSG00000006625 or ENSG00000134864
No
the substrates and products of this enzyme do not cover 5-oxoproline
remove the gene, add new rxn Rhea:16961

ENSG00000134864
MAR06971: (S)-2-aminobutanoate[c] + 5-oxoproline[c] <=> gamma-L-glutamyl-L-alpha-aminobutyrate[c]
ENSG00000006625 or ENSG00000134864
No
the substrates and products of this enzyme do not cover (S)-2-aminobutanoate
remove the gene, add new rxn Rhea:16961

ENSG00000147471
MAR07642: D-alanine[c] <=> alanine[c]
ENSG00000147471
No
the substrates and products of this enzyme do not cover alanine and D-alanine. This enzyme is only responsible for binding Pyridoxal 5'-phosphate (PLP) and is not involved in any metabolic pathways associated with alanine and D-alanine.
remove the gene

ENSG00000091483
MAR03831: aspartate[c] => fumarate[c] + H+[c] + NH3[c]
ENSG00000091483
No
the substrates and products of this enzyme do not cover metabolites given: aspartate
remove the rxn

I hereby confirm that I have:

[X] Done this analysis in the main branch of the repository
[X] Checked that a similar issue does not exist already

what about MAR06972, MAR06971, and MAR07642, should they be removed?

Removing the gene from MAR06972, MAR06971, grRule for those rxn are not empty, thus, the rxns are kept. As for MAR07642, I am not sure, I found for this rxn, the annotation in Recon3D was added for modeling purpose. Thus, I would suggest, we need to validate metabolic tasks can still be fulfilled before removing this rxn.

fixed in #559


drafts: Styling enhancements.

GIFs or Screenshots:

I like these changes, particularly the blue box.
I would defer to @rishig on the width/padding tweaks, but I think those are also a clear improvement.
Thanks for working on this,  @vrongmeal!

I agree with using a blue box.  think we should have the blue box surround the whole thing, not just the message content; makes it stand out more.


HTTP requests to DMAX are limited in number

When running the script for a show that has more than 30 entries DMAX returns a HTTP error code 429 (Too Many Requests response status code) after 30 requests.
Therefore it is not possible anymore to retrieve the entire list.
2020-09-29 19:22:47,552 - DMAX - INFO - Getting link 29 of 77
2020-09-29 19:22:47,802 - DMAX - INFO - Getting link 30 of 77
2020-09-29 19:22:48,034 - DMAX - INFO - Getting link 31 of 77
2020-09-29 19:22:48,236 - DMAX - ERROR - HTTP error code 429 for video id 63410
2020-09-29 19:22:48,236 - DMAX - INFO - Getting link 32 of 77
2020-09-29 19:22:48,431 - DMAX - ERROR - HTTP error code 429 for video id 63351
2020-09-29 19:22:48,431 - DMAX - INFO - Getting link 33 of 77
2020-09-29 19:22:48,631 - DMAX - ERROR - HTTP error code 429 for video id 63100
2020-09-29 19:22:48,636 - DMAX - INFO - Getting link 34 of 77
After 40 errors the DMAX site returns valid results from request 70 onward. This may vary slightly.
2020-09-29 19:22:55,700 - DMAX - INFO - Getting link 69 of 77
2020-09-29 19:22:55,900 - DMAX - ERROR - HTTP error code 429 for video id 36066
2020-09-29 19:22:55,910 - DMAX - INFO - Getting link 70 of 77
2020-09-29 19:22:56,130 - DMAX - INFO - Getting link 71 of 77
2020-09-29 19:22:56,370 - DMAX - INFO - Getting link 72 of 77
2020-09-29 19:22:56,590 - DMAX - INFO - Getting link 73 of 77
Maybe a configurable "wait" parameter that would delay the script execution could prevent these errors.

Do you have the latest version of the script? #5 should have fixed this

Ouch, sorry. I used the script that was 4 days older ...
With the new one, I had only 2 failures for 78 shows.
2020-09-30 14:36:08,277 - DMAX - INFO - Getting link 30 of 78
2020-09-30 14:36:08,497 - DMAX - INFO - Getting link 31 of 78
2020-09-30 14:36:08,687 - DMAX - ERROR - Got rate-limited, waiting 5 seconds (attempt 1 of 3)...
2020-09-30 14:36:13,877 - DMAX - ERROR - Got rate-limited, waiting 10 seconds (attempt 2 of 3)...
2020-09-30 14:36:24,067 - DMAX - ERROR - Got rate-limited, waiting 15 seconds (attempt 3 of 3)...
2020-09-30 14:36:39,261 - DMAX - ERROR - Couldn't get episode.
Doubling the NUM_OF_ATTEMPTS value from 3 to 6 did the trick for me.
Thanks for pointing me to the new script, I will look harder next time before posting an issue.

No problem, I will also increase the timeout.


add huber loss function (for robust regression)

The log-cosh loss is not the same as Huber loss.

Yes, this is log-cosh loss.
@osh : The difference is explained here: http://www.cs.cornell.edu/courses/cs4780/2015fa/web/lecturenotes/lecturenote10.html

thanks @the-moliver @Danielhiversen - have renamed it appropriately and fixed PEP8 checks

Le LGTM


454 improve quick start

FIxes #454

https://deploy-preview-499--umh-docs.netlify.app/docs/getting-started/setup-development/

https://deploy-preview-499--umh-docs.netlify.app/docs/getting-started/setup-development/

thanks a lot


Docker: Add the ability to export experimental results out of docker

As @KeleranV pointed on today's call, the current problem with Docker is that while the cc_oop_demo.py script runs flawlessly, the Dataset files, jsons, etc., they remain trapped inside the Docker image :).
As of now, the Python script is parametrized by a single local path parameter, where all results are stored. This will remain true even when replaced by full-experiment script in the future. Thus, we should decide on how to make the experiment results accessible outside of the docker for someone who uses Docker.
We discussed today with @KeleranV that he will investigate the options and pick some suitable one. @J08nY, do you have any opinion on this?

There are several ways of sharing stuff between the docker container and the host, see https://www.digitalocean.com/community/tutorials/how-to-share-data-between-the-docker-container-and-the-host. We should pick one that makes the most sense and go with it.

According to what I've seen, we will need the files contained in the sec-certs/examples/debug_dataset directory, so I think that sharing this specific folder should be enough, a line like docker run sec-certs:latest -v ~/processed_data:/opt/sec-certs/examples/debug_dataset should do the trick

sounds good 👍 , -v could be mistaken with verbose, so we should add the long tag --volume to readme.


Updating Probability figures in Dan's chapter

I changed it so that I could set a width because when I previewed it, the image was much too large. If you know a different way to make it smaller, that is ok. I just couldn’t make it work in markdown.

Amanda Kube, MS, PhD
Preceptor in Data Science
Data Science Institute
The University of Chicago
<EMAIL_ADDRESS>From: Jesse London @.>
Date: Monday, November 7, 2022 at 11:29 AM
To: chicago-cdac/textbook-datascience-1 @.>
Cc: Amanda Kube @.>, Author @.>
Subject: Re: [chicago-cdac/textbook-datascience-1] Updating Probability figures in Dan's chapter (PR #29)
@jesteria requested changes on this pull request.
Cool. Question about the use of the  tag (below).

In textbook/11/1/Rules_Definitions.ipynbhttps://urldefense.com/v3/__https:/github.com/chicago-cdac/textbook-datascience-1/pull/29*discussion_r1015708014__;Iw!!BpyFHLRN4TMTrA!8eKfeU57HAXDfes4B5ZFzyVwuD9CZx_HcfwiKRGIxMr9GLR8Iy-B6D2JWuXkAFvQAP1eZB0ozxQ7L5_ewqOxD3g0Ng$:

@@ -18,7 +18,7 @@

 "\n",

 "**Complement of an event**: The complement of an event $A$ is the event that $A$ does not occur, denoted by $A^C$. For the event $A$ defined above, $A^C$ is the event that more than half of the babies are boys, or the set of integers from 50 to 100.\n",

 "\n",

"\n",

"<img src="./img/complement.png" width="400"/> \n",

Any reason to use  and to set a width?

As far as I can tell, one of the advantages to using the Markdown-native syntax is that the textbook builder detects what you're doing and ensures the image is included. With this version, none of the images are included and these tags are broken. For that reason, I think we don't really want to use  tags at all.
The width is probably fine, but generally it's nice to allow the browser to figure out the best sizing, based on the image and layout. (And if we do need to control the sizing, there might be a more dynamic way.)

I would just tweak these to work with the textbook – the Markdown syntax is both textbook-compatible and less verbose – but, let me know if there's a reason behind the particular form you used.
[image]https://urldefense.com/v3/__https:/user-images.githubusercontent.com/530998/200374685-d70ba13b-80bc-4aa7-bfa4-f919f39ade06.png__;!!BpyFHLRN4TMTrA!8eKfeU57HAXDfes4B5ZFzyVwuD9CZx_HcfwiKRGIxMr9GLR8Iy-B6D2JWuXkAFvQAP1eZB0ozxQ7L5_ewqPnkDmazg$
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/chicago-cdac/textbook-datascience-1/pull/29*pullrequestreview-1170816266__;Iw!!BpyFHLRN4TMTrA!8eKfeU57HAXDfes4B5ZFzyVwuD9CZx_HcfwiKRGIxMr9GLR8Iy-B6D2JWuXkAFvQAP1eZB0ozxQ7L5_ewqNpgohizA$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AECO4REXPWUCPNV77D44QJLWHE4BDANCNFSM6AAAAAARWWGFXI__;!!BpyFHLRN4TMTrA!8eKfeU57HAXDfes4B5ZFzyVwuD9CZx_HcfwiKRGIxMr9GLR8Iy-B6D2JWuXkAFvQAP1eZB0ozxQ7L5_ewqM8m4t9Rw$.
You are receiving this because you authored the thread.Message ID: @.***>

OK cool. For reference, the textbook-standard syntax for setting such extended attributes is using either the image or the figure directive [ref].
(HTML is otherwise not parsed by the textbook builder, rather passed directly through as text. This is mainly an issue for images, which require extra processing.)
That said, there's an extension to catch <img> tags and convert them … so why not? I enabled the extension.
As for the static width, sure, 400px seems perfectly reasonable for this layout. (The layout appears to correctly handle the images regardless of the size of the window/viewport.)
If you think it helpful, I'll just see to it that the images are horizontally centered.