PBR roadmap

[ ] Proof-of-concept - Load glTF 1.0 models with hard-coded materials and shaders from https://github.com/khronosGroup/gltf-webgl-pbr. Use the sun as the sole light source.
[ ] Finish up glTF 2.0 support

[ ] https://github.com/AnalyticalGraphicsInc/cesium/pull/4808
[ ] https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/272
[ ] https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/274 - the material translation here is good for testing, but will be removed once PBR support is complete.

[ ] Support normal mapping

[ ] glTF without TANGENT attribute - compute tangent with screen space derivatives if supported
[ ] glTF with TANGENT attribute - just compute bitangent easily

[ ] Lighting ideas

[ ] Simple ambient factor
[ ] Experiment with default environment maps shipped with Cesium
[ ] Get atmosphere color / ground color
[ ] Render cube map dynamically

[ ] Handle spec-gloss extension.

@moneimne feel free to add ideas/comments as we go through this. The main first goal is to render with PBR shaders but use the sun as the only light source. After that we can experiment with different light sources like environment maps, atmosphere color, area lights, etc. I'll also add more ideas as we go.

CC #4009

Before exploring Lighting ideas and spec-gloss extension, please do the least amount reasonable to get a full glTF 2.0 implementation working - including morph targets - and merged into master.

Idea for applying PBR to geospatial: Altering the metallic and roughness of a model at runtime to achieve certain results, For example, one can add highlights or rim lights to a model to represent selection by manipulating the metallic and roughness parameters.

@lilleyse OK to close this?  Is there anything left in the roadmap that should perhaps move to #4009?

The only thing left unfinished here is Handle spec-gloss extension. so good to close.


Add theme: Collapsed Close Tab

Add theme: Collapsed Close Tab
This PR adds a new theme to the theme library.
Theme Details

Name: Collapsed Close Tab
Description: Shows a close tab button when hovering over tabs when the tab bar is collapsed
Homepage: https://github.com/thatcomputerguy0101/zen-collapsed-close-tab
Author: @thatcomputerguy0101

The tab backgrounds this uses do not work correctly in 1.0.1-a.18 with the macOS transparent background, resulting in a low-contrast close button over some tab content. I'll look into if there are any edits I can make to fix that, but the best solution would probably be making the theme's tab background more opaque to provide sufficient contrast over any content.

I have now updated this theme to be compatible with the current version of Zen at https://github.com/thatcomputerguy0101/zen-collapsed-close-tab (with new chrome.css and demo.png files). What do I need to do to update this PR to match?


add a way to inspect submitted files for public submission approval

Currently, when there is a new PR (with a new data point) in proteobot, we can see the changes in the parsed settings and results, but we do not see the files uploaded by the user (result files and parameter files).
I think that it should be possible, to have an inspection a bit more thorough when we accept the PR.
What do you think? Would this be possible?

Works in #487


Support for custom asserts

Hey,
I have a bit of a custom/strange setup wherein I link against the runtime CRT in debug builds, so I have NDEBUG defined globally, which disable the std asserts.
Would it be possible to switch over to using a macro or something instead of assert( X )? That way a user can easily replace the asserts in enkiTS with their own custom ones.

This has been on my list of things to do for a while, and would also be helpful in my own work, so I'll get on to it shortly.

I have an initial implementation in the branch dev_enki_assert. Let me know if this is sufficient for your needs and if so I'll merge into master.

Works for me :)

This is now merged to master - I'll add readme and comment notes later. Thanks for proposing & testing!

The change is incomplete.
Ln188, ln463 and ln477 need to be changed from assert to ENKI_ASSERT

Thanks - I also missed the ones in the C version, will fix now.

Hopefully the latest commits fix this. I've not switched the example code to these asserts for easier readability.


Search bar and button style

Underline colour is wrong, and the button should be only outlined when not on the homepage:

Should be:
https://app.zeplin.io/project/5878c3481bb7631c20cb161a/screen/5b05b3fce25151ce13d86d48
https://app.zeplin.io/project/5878c3481bb7631c20cb161a/screen/5b06e4704f55d1ef1b1df81d

@rhyslbw @DominikGuzei DONE and MERGED to dev


derive Clone for ProxyType

Now there have no comfortable way to set proxy type for more than one handler since Easy::proxy_type takes the ownership of a ProxyType enum. Deriving a Clone trait for ProxyType ensures such code possible:
let proxy = read_proxy_type();
let handler1 = Easy::new();
let handler2 = Easy::new();
handler1.proxy_type(proxy.clone());
handler2.proxy_type(proxy.clone());

It will be better to modify the Easy::proxy_type function itself. But deriving a Clone trait is not harmful.

Maybe it is safe to derive Copy as well?

Indeed yeah, want to add Copy too? Should otherwise be good to go!


Allow usage of Font Awesome Pro fonts

This PR includes functionality to allow using Font Awesome Pro fonts with the FontAwesome.swift package.
Some notes:

Of course the FA Pro fonts itself cannot be included due to their license. You will have to add these fonts to you app's bundle yourself (and make sure they're correctly set up by adding them to the app's target and including them in the Info.plist).
Using FA Pro instead of Free is simple: just include the fonts (see previous bullet), and include the code below in your AppDelegate.swift
I'm of course open to improvements to the implementation (the way I've implemented it now seemed most simple).
I know FA Free currently doesn't include a Light-variant, so when using the light variant with FA Free, it will fallback to the Regular-variant.

Usage:
In AppDelegate.swift:
// ...
import FontAwesome_swift // if using Cocoapods

class AppDelegate: UIResponder, UIApplicationDelegate {

  // ...

  func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
    // ...
    FontAwesomeConfig.usesProFonts = true
    // ...
  }

  // ...
}

@rbresjer Thanks for your PR! Other than the variable name, LGTM.

Hi @rbresjer !
When I add Pro fonts to my main target I have an error tying to activate them in AppDelegate:
dyld: lazy symbol binding failed: Symbol not found: _$S17FontAwesome_swift0aB6ConfigV12usesProFontsSbvau
  Referenced from: /Users/.../Library/Developer/CoreSimulator/Devices/A6CC0DA5-6EB6-4304-A892-649C772D72C6/data/Containers/Bundle/Application/86CC7FED-C468-4A3B-9B25-4C4AC8115001/my_application.app/my_application
  Expected in: /Users/.../Library/Developer/CoreSimulator/Devices/A6CC0DA5-6EB6-4304-A892-649C772D72C6/data/Containers/Bundle/Application/86CC7FED-C468-4A3B-9B25-4C4AC8115001/my_application.app/Frameworks/FontAwesome_swift.framework/FontAwesome_swift

Looks like FontAwesome_swift expect Pro fonts in their target but not main app target. I have updated pod to last 1.5.1 version. Should I add fonts to framework target instead?

@rbresjer Thank you for this PR!
I have successfully configured the pro icons and styles and have them working in my project, but there does not appear to be any way to use the pro-only icons (For example fa-abacus) with this library. Have you found a way?
My understanding is that they are not part of the icons.json in the FontAwesome repository and thus don't make it into the generated Enum.swift in FontAwesome.Swift.

Hi @alexroode, the raw value of the FontAwesome enum is just a string with a Unicode value. So just look up the value for the pro icon at the FA website, and use that for the string.

@rbresjer Can you please provide any sample of how to use PRO icons?

Hi @bilawal-liaqat, that should be quite straight forward:

Add the FA Pro files to your app's bundle
Add the FontAwesomeConfig.usesProFonts = true somewhere early in your app, e.g. in application:didFinishLaunchingWithOptions
Look up the unicode value of the icon you want to use on the FA website, and use that as the string in a label/button/...


spirv-cross: init at 2020-01-16

Motivation for this change
Add a package for SPIRV-Cross, a disassembler for SPIR-V to glsl.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@timokau Thanks for your review, I updated the package. Can you please re-review this? :)


MSAlertViewController checks on click MSAlertAction on isMemberOfClass

For the customization purposes my AlertAction class is inherited from MSAlertAction. Since there's isMemberOfClass check click handler doesn't work.
The same is with executePresentingAnimation for MSAlertController.
Could you please change this checks from isMemberOfClass to isKindOfClass.

I've finished changing  isMemberOfClass  to isKindOfClass .
Please update ver1.0.1 with pod update.

Thank you. It was really quick.


Use ip link set for MTU instead of setting up/tearing down tunnel

Is there a reason why
ip link set wg0 mtu <MTU>

isn't sufficient for modifying the MTU? Why set up and tear down the tunnel repeatedly? It would also allow this script to work with Wireguard configurations not managed by wg-quick (netplan, systemd, etc.).

To be honest, a VPN is just a means to an end for me. I made the predecessor to this project to solve a real world problem for myself which was to find an optimal MTU pair between my PC and a VPS server that with a limited understanding of how the internals of Wireguard work. I merely followed this tutorial to get it up and running. wg-quick was used in the tutorial and that's the thing I have always used.
Now that you have brought it to my attention, I find the ip link set command very intriguing. I will test it out some time soon and will see if I can integrate it into this project as an alternative mechanism to change the MTUs. I'll keep this issue open and report back my findings. I can't make any promises on the timelines though.

just change a few lines:
                #self.wg_quick_down()
                #self.update_mtu_in_conf_file()
                #self.wg_quick_up()
                self.ip_link_set_dev()

add the function ip_link_set_dev
    def ip_link_set_dev(self):
        """Set new MTU on device."""
        msg = "ip link set dev"
        print(f"{msg:<50s}", end=": ")
        process = subprocess.Popen(
            ["ip", "link", "set", "dev", f"{self.interface}", "mtu", f"{self.current_mtu}"],
            stdout=subprocess.PIPE,
            stderr=subprocess.PIPE,
            universal_newlines=True,
        )
        stdout, stderr = process.communicate()
        self.handle_returncode(
            returncode=process.returncode, stdout=stdout, stderr=stderr
        )


Develop Problem Statement for adoption of FinOps practices

User Need
As a Ops Eng Team
I want a problem statement
so that we understand why we are doing the work and the problem that we are trying to solve.
Value
A well defined problem will help the team understand the work and help develop the right solution. Will also help prioritise the work.
Functional Requirements (What):

Write a problem statement

Non-Functional Requirements (How):

Use insights from stakeholder engagement to better understand the domain and the challenges faced
Document the problem in the standard format.

Acceptance Criteria:

[ ] We have an agreed problem statement

Assumptions (Optional):

Problem statement will be iterated on over time and as we learn more about the domain.

Notes:
Problem Statement

Reviewed. Will use this version and reflect on the statement as discovery progresses.


Use Keyv type for KeyvMulti.Options stores

Closes https://github.com/microlinkhq/keyvhq/issues/210.
As described on https://github.com/microlinkhq/keyvhq/issues/210, the remote  and local types were incorrectly set to a JS Map (used by Keyv core under the hood). These types should be referencing Keyv instead.
I also fixed the definition unit tests to pass a new Keyv instance for each store to reflect these changes.
A Keyv instance is used by default in the Multi class's constructor in case no override is set (not a Map): https://github.com/microlinkhq/keyvhq/blob/master/packages/multi/src/index.js#L6

Thanks a lot!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 96.352%

Files with Coverage Reduction
New Missed Lines
%

packages/redis/src/index.js
2
96.3%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
896

Relevant Lines:
916

💛  - Coveralls

@lucasadrianof btw what are you building? 😆

@lucasadrianof btw what are you building? 😆

Nothing too crazy 😆
We have some data that is cached on Redis since it's very frequently read. Since we work with k8s, we can't use a local cache only, but now we have implemented a dual cache (local first + fallback to Redis) to decrease the latency on these reads even more (with a local cache per pod first).


Is frtest.cpp complete ?

I can't find CWorkerThreadPool.h ?
https://github.com/avaneev/avir/blob/master/other/frtest.cpp#L7
Also is multi threading based on CPU ? because when using test binary, changing --num-threads=x doesn't affects on benchmark results (remains almost around 240). Not sure why. Does it depend on no. of COREs ?
Here's my CPU details:

Well, your CPU has only 2 physical cores, so it's expected behavior, it can't process many threads at once. Set to num-threads=1 to see the difference. By default all threads are utilized. And if you looked closer at figures, at num-threads=2 performance (0.3) is visibly lower than at num-threads=4 (0.24).


minor fixes based on findBugs feedback

Ran findBugs on javaslang and it found a few things, I suggest you run it too and take a look. Iterator.next is supposed to throw NoSuchElementException, and there was this Tuple creation that didn't do anything with it + other things.

Current coverage is 96.08%

Merging #1228 into master will decrease coverage by -0.02% as of 4ad1075

@@            master   #1228   diff @@
======================================
  Files           78      78
  Stmts         9161    9163     +2
  Branches      1717    1718     +1
  Methods          0       0
======================================
  Hit           8804    8804
- Partial         92      93     +1
- Missed         265     266     +1

Review entire Coverage Diff as of 4ad1075

Powered by Codecov. Updated on successful CI builds.

Thank you, I will run it. Best would be to automate it as part of the CI build.
The Iterator.next method intentionally does not throw. The iterator is used internally and there is no chance that it ever will escape to the outside or throw a NoSuchElementException. Usage:
    interface StreamFactory {

        static <T> Stream<T> create(java.util.Iterator<? extends T> iterator) {
            return iterator.hasNext() ? Stream.cons(iterator.next(), () -> create(iterator)) : Empty.instance();
        }
    }

That's one thing that drives me crazy about FindBugs, PMD et al. These tools are good to spot blockers and major bugs.

Thank you Martti!
I ran FindBugs in IntelliJ and it helped!

I investigated all FindBugs findings. All should work fine with the exception of one finding which has to be fixed - after deserializing a HashMap/HashSet the hashCode function will fail. It will be fixed with 2.0.2.


zdf extractor currently doesn't work

Hi, here is the debug:
jachmann@hurx:/tmp>youtube-dl -v  'https://www.zdf.de/filme/taunuskrimi/die-lebenden-und-die-toten-1---ein-taunuskrimi-100.html'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.zdf.de/filme/taunuskrimi/die-lebenden-und-die-toten-1---ein-taunuskrimi-100.html']
[debug] Encodings: locale ISO8859-15, fs ISO8859-15, out ISO8859-15, pref ISO8859-15
[debug] youtube-dl version 2017.01.02
[debug] Python version 2.7.13 - FreeBSD-10.3-STABLE-i386-32bit-ELF
[debug] exe versions: ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] die-lebenden-und-die-toten-1---ein-taunuskrimi-100: Requesting header
WARNING: Falling back on generic information extractor.
[generic] die-lebenden-und-die-toten-1---ein-taunuskrimi-100: Downloading webpage
[generic] die-lebenden-und-die-toten-1---ein-taunuskrimi-100: Extracting information
ERROR: Unsupported URL: https://www.zdf.de/filme/taunuskrimi/die-lebenden-und-die-toten-1---ein-taunuskrimi-100.html
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1669, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2526, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2515, in _XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 141, column 162
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 359, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2486, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.zdf.de/filme/taunuskrimi/die-lebenden-und-die-toten-1---ein-taunuskrimi-100.html
somehow the regex has to be  changend.

ZDF has been broken for a long time. See #11055 and an incomplete fix at #11063

Tue, Jan 03, 2017 at 02:30:04AM -0800, Yen Chi Hsuan :

ZDF has been broken for a long time. See #11055 and an incomplete fix at #11063

Yes, i read that. Any idea whan this works again ?
Or what could i do to help ?
Thanks,
Christian Jachmann

Apparently bastik, the author of #11063 is not going to continue the work. You may want to continue the work based on #11063 or wait for someone else to do that.


[BUG] Session is not AutoCreated on nvim .

Describe the bug
A clear and concise description of what the bug is.
When I open a directory with nvim ., auto-session does not save the session. See the additional context - i think it is an issue with allow_files_auto_save
To Reproduce
Steps to reproduce the behavior:
Set the auto_create option to True. cd to a new directory with no saved session named after it. call nvim . No session is created on startup (fair I guess, as there's no session to restore). But still no session is saved on close.
Expected behavior
A clear and concise description of what you expected to happen.
When I run :q after the "To Reproduce" steps, it should create a new session on save.
Screenshots
If applicable, add screenshots to help explain your problem.
Checkhealth
Paste the contents of checkhealth auto-session here
auto-session: require("auto-session.health").check()

vim options ~
- OK vim.o.sessionoptions

Lazy.nvim settings ~
- OK Lazy.nvim support is enabled
- OK auto-session is not lazy loaded

Config ~
- OK
  {
    log_level = "debug",
    suppressed_dirs = { "~/", "~/Projects", "~/Downloads", "/" }
  }

General Info ~
- Session directory: /home/grabba/.local/share/nvim/sessions/
- Current session:
- Current session file:

Baseline (please complete the following information):

Result of set sessionoptions?: sessionoptions=blank,buffers,curdir,folds,help,tabpages,winsize,winpos,terminal,localoptions
OS. e.g uname -a: Linux HP-Workstation 6.8.0-48-generic #48~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Oct  7 11:24:13 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
Neovim version nvim --version

NVIM v0.10.2
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068

URL to your current config (if public): https://github.com/jack-obrien/kickstart.nvim
Note that I have disabled a bunch of the config options of auto-session for this bug report, see my checkhealth output.

Additional context
I typically run nvim through neovide, but for this report I have just used the command line to call nvim.
With debug enabled, it looks like auto-session thinks my command line argument is a file, not a directory. (This is just when running nvim .)
auto-session DEBUG: args_allow_files_auto_save is false, not enabling restoring/saving
Thanks for reading! Let me know if you need anything else :)

Thank you so much for your detailed help! Lazy loading nvim-tree definitely helped with the path overwriting issue.

Glad it's working!
If you specify keys, cmd, event, or ft in a plugin spec, you shouldn't need to explicitly set lazy = true (but you can't have lazy = false as that will force it to be not lazy):
https://lazy.folke.io/spec/lazy_loading
https://lazy.folke.io/spec#spec-lazy-loading


docs: adjust the Makefile target docs to include untracked files

In #370, I forgot that git ls-files does not include untracked files by default. This means newly created source files that have not been staged using git add are not included in the dependencies of make docs.
This PR is to fix the issue.
To include untracked files, we use the flag -o|--others. We also use the flag --exclude-standard to prevent listing files excluded by .gitignore.

Is this PR ready for review?

@behnazh-w As I discussed, I think it is best that we remove caching for the docs target altogether, as it seems like we don't have a reliable caching mechanism while building the docs is relatively fast already.

Closing this. The fix is in #411.


Add Combine-related packages

A few Combine libraries I've been working on lately. 🙂

Nice username 👍


Line numbers on notebook are too close to code

Environment data

VS Code version: 1.59.0-insider (user setup)
Jupyter Extension version (available under the Extensions sidebar): v2021.8.1055544705
Python Extension version (available under the Extensions sidebar): v2021.8.1057758891-dev
OS (Windows | Mac | Linux distro) and version: Windows_NT x64 10.0.19042
Python and/or Anaconda version: Python 3.9.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Jupyter server running: Local

Expected behaviour
Line numbers have proper spacing before code
Actual behaviour
Spacing is too tight
Steps to reproduce:

Enable line numbers on the notebook settings.

Additionally I believe the spacing was correct before the last update of the plugin (running insiders build).

Duplicate of https://github.com/microsoft/vscode/issues/129145


Please update the ASC requirement - there is no more "standard" tier

Azure Security Center doesn't have a "Standard tier" since Ignite 2020.
Part of the rebrand was to remove this.
Microsoft Defender for Endpoint is included with Azure Defender for servers which is the CWPP integrated inside Azure Security Center.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8aca66a-5a8b-64d2-7201-a7b915c5d309
Version Independent ID: c3cc0543-db20-a8f2-288c-d1dea5ea479f
Content: Minimum requirements for Microsoft Defender ATP - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/minimum-requirements.md
Product: w10
GitHub Login: @mjcaparas
Microsoft Alias: macapara

Closed via #8586
Thanks


Clear button do not trigger onChange

Version "^3.0.7"
If i press clear button, onChange event do not trigger:

    <input name="created_at" value="2018-04-17 to 2018-04-19">

$('.flatpickr').flatpickr({
    wrap: true,
    mode: 'range',
    onChange: (date, val) => {
        //some actions
    },
   //have to use this crutch for trigger `onChange` event
   onReady: (date, val, obj) => {
        $(obj.element.lastElementChild).on('click', () => {
            //some actions
        });
    }
});

Hello @projct1
Could you please test whether this happens in the latest version as well (v4.4)?

@chmln Ye, with 4.4.4 same situation.

@projct1 couldn't reproduce it. See https://jsfiddle.net/y39gu56n/


crashes with Galacticraft (Entity ID is the same)

the ID of the Evolved Enderman is same could you change it so it doesn't cause problems with galaticraft
https://github.com/micdoodle8/Galacticraft/issues/3144

I replied and I'll get this fixed in the next update, thanks for reporting this!


Add support for running a "direct" migration (without blob storage) from GHES or GHAE

In the GraphQL API, it is possible to run a "direct" migration from GitHub AE or GHES to GitHub Enterprise Cloud. In so-called "direct" mode, GHEC connects to the migration source directly to perform the data export, rather than the CLI performing the expert and then uploading the data to a blob storage provider ("indirect" migration).
Right now, this is not supported in the CLI. If you specify the --ghes-api-url argument to gh gei migrate-repo in order to point to your target instance, then the presence of this argument will cause the CLI to use the "indirect" blob storage flow.
We should add a way for a user to specifically request a direct migration when specifying an API URL. This might also be a good time to rename this attribute to be more generic, rather than GHES-specific. When making this change, we should be careful of backwards compatibiltiy.

With GHES 3.8+ I don't think this feature is even possible to support anymore. Because generation of the migration archive now requires S3/Azure to be configured in GHES itself.
Do you agree @timrogers ? if so we should close this issue IMO.

Surely it's still possible to support for people who want to migrate off GHES < 3.8?

With GHES 3.8+ I don't think this feature is even possible to support anymore. Because generation of the migration archive now requires S3/Azure to be configured in GHES itself.
Do you agree @timrogers ? if so we should close this issue IMO.

@dylan-smith  I agree that this is no longer possible for versions 3.8 onwards - unless we make a further change in a future version, of course!

Surely it's still possible to support for people who want to migrate off GHES < 3.8?

@lukens You're right that it would be possible for earlier versions, for the rare case where the Enterprise Server is accessible by GitHub over the internet.
Given the rarity of internet-accessible GHES instances and the new behaviour in 3.8 onwards, this isn't an issue we are likely to address, so I think it is the right choice to close it and signal that.
@lukens If you want to run this kind of migration, then you can trigger that using the GraphQL API.

Do you know it is a rarity, or is that an assumption? I'd also have though, even if a rarity in general, factors that made it more likely you would want to upgrade to Github Enterprise Cloud would include:

You struggle to keep GHES updated
You don't need to be behind a firewall

So, whilst these may be scarce in terms of total GHES instances, they may be more common amongst those migrating to the cloud.
I am aware that this can be done via the APIs, as that is what I eventually did; I was mainly trying to save others the pain I went through to get to that point (some of that pain has been removed anyway, I believe, by fixing the S3 regions bug).
If not addressing this by implementing this functionality, perhaps it could be addressed instead via documentation improvements (eg. a callout in the documentation saying that if you have publicly accessible GHES edition, your life may be simpler using the APIs directly, plus pointers to the relevant documentation).
I'm also curious how it works in GHES 3.8+. If the S3/Azure settings are specified in GHES itself, I'm assuming you therefore don't need to specify them on the command line as well, and instead the tool would just request an archive link from GHES, and this would return a pre-signed blob store link. Would this not effectively be the same as asking for an archive link and getting a pre-signed direct link back?  With what I'm getting at here being: would a solution for this also work as a solution for 3.8+?
Obviously I'm not personally bothered what you do, as I've completed my migration, it just took me a lot longer to do that it would have if I'd been able to do a direct migration with the tool from the start, and so I thought others may benefit from this (on the face of it it also seemed like it'd be a fairly trivial addition, as I was guessing most of what was needed was already there for cloud to cloud migrations - though, that was guess work/assumptions that could well be wrong).

Do you know it is a rarity, or is that an assumption?

My experience with customers shows that the vast majority of those migrating to the cloud have "locked down" GHES instances.
I can't give a hard percentage as we don't collect telemetry from GHES customers - but from my customer interactions, I'd guess less than 1 in 10.

If not addressing this by implementing this functionality, perhaps it could be addressed instead via documentation improvements (eg. a callout in the documentation saying that if you have publicly accessible GHES edition, your life may be simpler using the APIs directly, plus pointers to the relevant documentation).

I think that's a very fair suggestion, and something I'll pick up. That said, there are known issues with that path - for example it doesn't work with repos larger than 2GB. That's the reason for the changes in 3.8.

I'm also curious how it works in GHES 3.8+. If the S3/Azure settings are specified in GHES itself, I'm assuming you therefore don't need to specify them on the command line as well, and instead the tool would just request an archive link from GHES, and this would return a pre-signed blob store link. Would this not effectively be the same as asking for an archive link and getting a pre-signed direct link back? With what I'm getting at here being: would a solution for this also work as a solution for 3.8+?

You're exactly right about how it works in GHES 3.8 onwards, and you're also right that, for an internet-accessible GHES instance, we could feed that URL directly to GitHub.com.
The bit we would have to figure out from a UX perspective is "how we do know if the URL is accessible, or if instead we need to upload it to blob storage?". That's something I can think about. Of course, we'd also need to prioritise this against changes to help 3.8+ users, who will be the majority before long.

Obviously I'm not personally bothered what you do, as I've completed my migration, it just took me a lot longer to do that it would have if I'd been able to do a direct migration with the tool from the start, and so I thought others may benefit from this (on the face of it it also seemed like it'd be a fairly trivial addition, as I was guessing most of what was needed was already there for cloud to cloud migrations - though, that was guess work/assumptions that could well be wrong).

Thanks for the feedback - I do really appreciate it! It's useful to here from a customer with a different perspective, and to hear that "direct" migration turned out to be the better option for you. Thanks for taking the time to share ❤


Rebase clean on top of master

Currently clean is  based on release (1.5.0) because master was throwing errors. Could have been a mistake or transient error. Will rebase on master soon.

This would make integrating our work a lot easier, since it is based on (relatively) recent master.

https://github.com/squaremo/docker/tree/plugins-master has a clean branch rebased on master. It handshakes with plugins, but I need to find a three-phase power supply for my laptop in order to run the docker tests.

That's great, I was planning on doing this. Let me know how tests go. I'm not sure if the tests caught the panic I was seeing, but I can also just try your clean branch to see that it works with the plugin stub manually.

Argh, docker master is in upheaval as people remove the "job engine". Admittedly that really needed to be done.


Move notebooks into Python package?

I have created a tutorial function that downloads the documentation notebooks from github and puts them into the users cwd. This makes it really easy for a user to grab the notebooks and play with Altair using:
from altair import tutorial
tutorial()

However, right now I am downloading the notebooks from github. If we moved the notebooks into the Python package, it solves a couple of problems:

We can always know that the right version of the notebooks will be used by the user and don't have to keep updating the github URL to track the right commit/tag for the release.
No internet required for a user to grab the example notebooks.
Eventually, ipython/jupyter will likely have the ability to allow users to see/explore notebook based documentation. The mostly likely discovery mechanism will be entry points. Moving notebooks inside the package makes this an easy transition.

Eventually, imagine a magic that works like this:
%nbdoc altair

Or
%nbdoc sklearn

The only downside is that a user won't see a top level notebooks directory. But we could keep it and put a README that points the user to the notebooks inside the package.
@fperez @jakevdp @willingc @Carreau

Nice! Pretty cool to open in JLab since the file browser improves the user experience.
Might make sense to standardize on tutorial-altair or tutorial_altair directory so if you had multiple tutorials that they would show up in the same area of the JLab file browser.

Also might make for a very cool RISE and tutorial mashup.

I'd be fine with wrapping them in, as long as it's clear where to find them from the README & other documentation pages.

Done in master, updating all links now, closing.
On Sun, Jul 10, 2016 at 5:29 PM, Jake Vanderplas<EMAIL_ADDRESS>wrote:

I'd be fine with wrapping them in, as long as it's clear where to find
them from the README & other documentation pages.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ellisonbg/altair/issues/154#issuecomment-231614786,
or mute the thread
https://github.com/notifications/unsubscribe/AABr0MTsR-aJO3CRr7bQfJr_iwUQc6xHks5qUXJdgaJpZM4JIvvO
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>


Regarding getting TFS WorkItems using Ids

This issue was created by @sangam-sgm from https://github.com/MicrosoftDocs/feedback/issues/299.
Regarding getting TFS WorkItems using Ids
I was using rest api for tfs to get workitems details by ids but when i am giving all the ids the api is turning to be very large and hence its not processing and returning internal server error message.
My concern is that can you people make this api as post request as well so that i can pass as many ids as we can.
The doc link i used to get the api is https://docs.microsoft.com/en-us/rest/api/vsts/wit/work items/list
In the api GET https://{accountName}.visualstudio.com/{project}/_apis/wit/workitems?ids={ids}&api-version=4.1-preview if i am giving lots of ids comma seperated then its failing because of url length.

@wnjenkin Transferred the issue as you required.

Yes, the getworkitems with large number of ids can reach the maximum json limit and throws error. We do have plans for getworkitems as a POST to support bigger scale of input ids but not available today. For now, as a workaround, can you try breaking up your invocation in two(or more, depending on the number of ids you have) GetWOrkItems with the ids divided between them to get results from getworkitems.

@sangam-sgm does the answer provided by @Baisakhc help?


Fix some of the native notebook API tests

Codecov Report

Merging #4922 (53abfdc) into main (72a8527) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4922   +/-   ##
=====================================
- Coverage     76%     76%   -1%
=====================================
  Files        401     401
  Lines      26569   26585   +16
  Branches    3849    3854    +5
=====================================
- Hits       20324   20265   -59
- Misses      4647    4708   +61
- Partials    1598    1612   +14

Impacted Files
Coverage Δ

...t/datascience/jupyter/jupyterInvalidKernelError.ts
66% <0%> (-34%)
:arrow_down:

src/client/datascience/kernelSocketWrapper.ts
74% <0%> (-13%)
:arrow_down:

src/client/datascience/jupyter/jupyterSession.ts
75% <0%> (-12%)
:arrow_down:

src/client/common/errors/types.ts
69% <0%> (-8%)
:arrow_down:

...science/jupyter/kernels/kernelDependencyService.ts
82% <0%> (-6%)
:arrow_down:

...ascience/raw-kernel/rawNotebookSupportedService.ts
87% <0%> (-6%)
:arrow_down:

src/client/datascience/notebook/kernelProvider.ts
73% <0%> (-5%)
:arrow_down:

src/client/common/cancellation.ts
82% <0%> (-4%)
:arrow_down:

...lient/datascience/jupyter/jupyterSessionManager.ts
72% <0%> (-4%)
:arrow_down:

...t/common/application/webviewPanels/webviewPanel.ts
69% <0%> (-4%)
:arrow_down:

... and 22 more


feat(plugin-chart-table): add small number formatter

🐛 Bug Fix
Realized I didn't commit the changes about small number formatter before merging... https://github.com/apache-superset/superset-ui/pull/1019

@kristw do you mind stamping this as well?


styles and alignment of back to top

📋 Description
Scroll back button and the chatbot are overlapping, resolved the bug.
Fixes #349
BEFORE:

AFTER:

Before submitting the PR, please make sure you have completed the following:

[x] I have followed all the guidlines mentioned in CONTRIBUTING.md.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation (if applicable).
[x] I have tested it locally and it works fine.
[x] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[x] Bug fix (non-breaking change which fixes an issue) 🐛
[ ] New feature (non-breaking change which adds functionality) ✨
[ ] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!

@shriyadindi  It seems the previous PR changes are existing in this PR, open a PRs with different branches and make sure your previous changes of the PR does not included

@Harshdev098 Kindly assign the labels.

@Harshdev098 Add labels to this PR


Map: Make button for showing resources within current area more intuitive

Comment from user group. Button on map for showing resources in current map area is not perfect in regards to intuitivity. Check for options to icon or add text.

Maybe the refresh icon (same as in the box for adjusting the query string above) would make more sense?

I've changed the button to search icon (magnifying glass). We already have a refresh icon for when map changes and resources are refreshing so it didn't work well with that icon. Any comments on this or any other suggestions on how to make this clearer?

I think it is quite clearer now. Maybe we should wait until the next user group meeting and see what the users think ;)


Fixed manufacturer link output in emotion slider

Manufacturer slider builds url's always for the listing.
So if you defines url 'Link to manufacturer website' in shopware backend

it has no affection to the output. With this patch you will be able to overwrite the standard listing url.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-15120.
Please use this issue to track the state of your pull request.

The current behaviour is like intended to be. We won't fix this issue. Closing this PR.


Recognition of ×Woodsimatium (Woodsiaceae)

Author(s) of proposal
Li-Bing Zhang, Ngan Thi Lu
Name of taxon
×Woodsimatium
Rank of taxon
Genus
Approximate number of species affected
1
Description of change
Transfer of one hybrid from Woodsia to ×Woodsimatium.
Reason for change
Lu et al. (2019) proposed to recognize two genera, Woodsia and Physematium, in Woodsiaceae consisting of ca. 65 species (instead of ca. 30 spp. in early estimation) based on deep divergence in the phylogeny, morphological diagnosability, and geographical differentiation (see previous proposal).
If this two-genus classification is accepted, the only hybrid between the two genera, Woodsia ×abbae Butters in Amer. Fern J. 31: 18. 1941 (Physematium oreganum subsp. cathcartianum × Woodsia ilvensis), can be accommodated in the intergeneric hybrid genus, ×Woodsimatium.
This intergeneric hybrid between the deeply diverged (ca. 45 million years ago; Ma) lineages is reminiscent of the French Pyreneen intergeneric hybrid ×_Cystocarpium_ roskamianum, whose parents have been dated to have diverged ca. 60 Ma (Rothfels et al., 2015). This slow evolution of reproductive isolation has been argued to potentially contribute to the lower species diversity in ferns in comparison with angiosperms. The identification and recognition of ×Woodsimatium is additional evidence that slower evolution of reproductive isolation in ferns compared to flowering plants may account for the relative paucity of fern species.
Reference(s) for publication of the name
Rothfels et al. 2015_AmerNat.pdf
Lu et al. 2019_Woodsia.pdf
List the numbers of any related issues
No response
Code of Conduct

[X] I agree to follow the PPG Code of Conduct

@gonggashan88 do you know if the hybrid is fertile?

@joelnitta Hi Joel, good question! According to Wagner (1987: 122; pdf below), the only hybrid between the two "genera" "... is always sterile and must be formed each time anew".
Wagner 1987_Hybrid Woodsia abbae.pdf

Thanks very much @gonggashan88 for sharing the paper!
Just to clarify, the part you quoted is with respect to W. x abbeae found in Michigan: "Woodwardia x abbeae has been found in several localities in that state [Michigan]; it is always sterile..."
Also, Wagner (1987) does mention a partially fertile specimen:

Butters and Tryon (1948) reported a partially fertile frond of W. x abbeae, the upper portion of which bore fertile
spores that germinated when sown. The lower half of the frond was sterile. Measurements that were made indicated that the fertile part of the leaf had probably become polyploid.

This proposal was voted on during PPG Ballot 10 (voting period April 2024). A total of 60 votes were cast. There were 27 'Yes' votes (45%) and 33 'No' votes (55%). The proposal does not pass.


Kotlin project templates

#64 #65

Removal of the legacy WebSocket template. It's broken and includes other gdx-lml modules for no particular reason, making it more confusing for newcomers than it needs to be.
Basic Kotlin template including Kotlin launchers for each platform.

GWT just throws an exception explaining that Kotlin is not compatible with GWT.

Basic KTX template with some basic KTX utilities.

Other changes include:

Switched BadLogic logo with libGDX logo in Classic project templates. I think it's more beneficial to use libGDX branding, especially since it's no longer hosted under BadLogic domain.

I wasn't able to test these on iOS, but other platforms work on Linux. I'd appreciate if someone was able to test the Kotlin iOS launcher.

gdx-liftoff-<IP_ADDRESS>-many-PRs.jar.zip
For testing on iOS, here's a prerelease Liftoff JAR that should, if everything is working as intended, work on Mac, Linux, and Windows. @JojoIce , if you want to test out the new Kotlin launchers on MacOS and/or iOS (I can't remember, but I thought you use Kotlin), testing this JAR would be very welcome. Mostly I need to know that it can make projects correctly at all on MacOS, and iOS simulator testing would also be great, if possible.


New version: GridapGmsh v0.3.0

Registering package: GridapGmsh
Repository: https://github.com/gridap/GridapGmsh.jl
Created by: @victorsndvg
Version: v0.3.0
Commit: 0ab80490b81775a187f1aadd58382be43eaa1511
Reviewed by: @victorsndvg
Reference: https://github.com/gridap/GridapGmsh.jl/commit/0ab80490b81775a187f1aadd58382be43eaa1511#commitcomment-37495970

Needs Gmsh installed to work.


Terraform logo in Built-in Integrations section is not properly scaled

Description
Terraform logo in Built-in Integrations section is not properly scaled
Expected Behavior
To scale the logo properly.
Screenshots

explain your problem.-->
Environment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@leecalcote can you assign this to me.

Thanks for calling this out, @Aditya-150. 👍

can i work on this issue @leecalcote ?

Why do I feel this issue is at the wrong place, @leecalcote? Anyways the terraform logo skewness is already been taken care of in another PR. Will close up this issue.


Add an extra algorithm for finding the next perfect square

@keon my repo is synced with the main one now.

Nice work! but next time be sure to also update the README when you add new file.


Coding Questions related to Stacks and Queues.

I am a LGM-SOC'21 Participant and has opened this issue to add all the coding questions related to Stacks and Queues from various platforms. Could you please assign me this (Language -  C++)? @Ayush7614

@dpshikha476 you can add separate questions. Since this is an open source so everyone needs to contribute so create separate problem issues and then solve.

Sure

@dpshikha476 you can add separate questions. Since this is an open source so everyone needs to contribute so create separate problem issues and then solve.

Sure👍


fix: #14 second half fix, dont allow pathname to write outside of extract path

Fixes for #14

https://github.com/Cobertos/unitypackage_extractor/blob/7f7050a7458d62616b28f46c133b015d2351fd49/unitypackage_extractor/extractor.py#L49
Just something else I've noticed, but the usage notice doesn't tell you you can pass an optional output path.

This can be merged, just make sure to merge #15 first.

Merging this, but requires #16 to fix the improper handling of Path().resolve on Windows


fix(ui): show system badge for system tags

Describe your changes :

Closes: #10487

Type of change :

[x] Bug fix
[x] Improvement
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Frontend Preview (Screenshots) :

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

System badge icon needs to better. Putting the label doesn't look right to me and especially the color we are using.
Thoughts @sureshms

@chirag-madlani and @harshach how about adding the system label only on the right side along with the glossary and glossary term details instead of the left panel?

@harshach @sureshms @devyani-kaushik
Have added badge to details page, let me know your feedbacks if any

@harshach updated badge with new styles, screenshot updated.
P.S. I have kept Badge bit top aligned (superscripted) as discussed


Invalid version number v3.0.10

Hello,
When I pull pixi.js from npm (v3.0.10) it outputs a wrong version number :

It breaks pixi-particles detection logic see pixijs/pixi-particles#25. I also tried a npm i<EMAIL_ADDRESS>--no-cache without success.

all good now it seems! 👍


[DO NOT MERGE] chore: update "dev:teamsAppId" to "teamsAppId"

Code change looks good. Just confirm when to merge and which target branch? Since currently there's an active releasing...

Will be merged after the active pre-release is published. Target brach is v3 (before v3 is merged back to dev).

It seems that a sample was missed. This sample was merged to the v3 branch yesterday.
https://github.com/OfficeDev/TeamsFx-Samples/pull/715

It seems that a sample was missed. This sample was merged to the v3 branch yesterday.
#715

Thank you for the kind reminder. Updated.


[React Native] Improve docs on sourcemap upload / plugin setup

Describe the bug
The bundle sourcemap upload task for react native will not register if the plugin is not applied after the main react native plugin is applied (and the RN bundle task is registered).
This plugin fails silently here if configured otherwise: https://github.com/bugsnag/bugsnag-android-gradle-plugin/blob/76731fac917454eba14cd643167b97e6c8b14f48/src/main/kotlin/com/bugsnag/android/gradle/BugsnagPlugin.kt#L447
The bug is unclear documentation & no misconfiguration warnings in the Gradle build output
Steps to reproduce
Have a project/app/build.gradle that looks something like this:
apply plugin: "com.android.application"
apply plugin: "com.bugsnag.android.gradle"

// some other stuff....

apply from: "../../node_modules/react-native/react.gradle"

// some more stuff....

bugsnag {
    enabled = true
    uploadReactNativeMappings = true
    overwrite = true
}

And run ./gradlew assembleRelease or otherwise do a non-debug build
Environment

Android Studio version: 4.0
Android Gradle version: 6.2
Bugsnag manifest section (if modified): N/A

Hi @sterlingwes
Thanks for highlighting this.
The intention is that for most projects you'd be able to use the @bugsnag/react-native-cli which automates this and applies the plugins in the correct order:
https://docs.bugsnag.com/platforms/react-native/react-native/
The issue with outputting a misconfiguration warning is that for non-RN Android projects we wouldn't want to output any warning but there's not a reliable way to detect that across all of the types of project we support.
Based on your feedback we've just made an update to our documentation for manual setup to clarify the ordering that's required:
https://docs.bugsnag.com/platforms/react-native/react-native/manual-setup/#android

Hi @sterlingwes
Thanks for highlighting this.
The intention is that for most projects you'd be able to use the @bugsnag/react-native-cli which automates this and applies the plugins in the correct order:
https://docs.bugsnag.com/platforms/react-native/react-native/
The issue with outputting a misconfiguration warning is that for non-RN Android projects we wouldn't want to output any warning but there's not a reliable way to detect that across all of the types of project we support.
Based on your feedback we've just made an update to our documentation for manual setup to clarify the ordering that's required:
https://docs.bugsnag.com/platforms/react-native/react-native/manual-setup/#android

The issue with outputting a misconfiguration warning is that for non-RN Android projects we wouldn't want to output any warning but there's not a reliable way to detect that across all of the types of project we support.

The line I referenced above is only relevant for React Native

The issue with outputting a misconfiguration warning is that for non-RN Android projects we wouldn't want to output any warning but there's not a reliable way to detect that across all of the types of project we support.

The line I referenced above is only relevant for React Native

Hi @sterlingwes

The line I referenced above is only relevant for React Native

Yes, sorry - that's what I meant. The line runs on all Android projects using our gradle plugin (React Native or not), but is only relevant for React Native projects.
It therefore fails silently, as for non-React Native projects that's the correct thing to do. We wouldn't want to warn if we can't find RN tasks since for a general Android project there may not be any.
Since we support a wide range of React Native versions, there's not a clean, future-proof way of detecting we're in a React Native project and then warn if we don't find the tasks.
Hopefully now the documentation clarifies the required ordering this is unlikely to cause further issues.
Thanks again for your feedback!


Bugged towns

Version: 1.0.
Mods: CBA, TFAR, ACE(Antistasi edition), RHS.
Environment: MP dedi.
.rpt attatched? NO
have you edited the missionfile?: No
Issue:

On the Official US1 server, on the current mission (Tanoa), it seems the players got to capture 1 town, and when this happened, all the towns on the map where simultaneously given to the SDK, no idea why this happened.

That may happen on some circumstances, I doubt this is a bug


Fix MySQL Connector directory permissions

Pull Request (PR) description
Set the directory permissions of the MySQL Connector directory so users other than root can use the connector.
This Pull Request (PR) fixes the following issues
Fixes #241

Hi,
I redid this on top of current master where I reworked the mysql_connector manifest to use puppet/archive, so I'll close this PR.


JS backend to get Grafana logged user name

Hi, all!
I'd like to get current logged Grafana user name
[dataproxy]
logging = true
send_user_header = true
but I can't write JS backend, pls, help me!!!
var express = require('express');
var cors = require('cors')
var app = express();

app.use(cors());

app.get('/', function (req, res) {
  console.log('index: ',req.header('X-Grafana-User'));
  res.send('Hello World!');
});

app.get('/query', function (req, res) {
  console.log('query: ',req.header('X-Grafana-User'));
  res.status(200);
  res.json({ username: req.header('X-Grafana-User') })
});

app.get('/search', function (req, res) {
	console.log('search: ',req.header('X-Grafana-User'));
  res.status(200);
  res.json({ username: req.header('X-Grafana-User') })
});

app.listen(3002, function () {
  console.log('Example app listening on port 3002!');
});

I can't help you with that. You'll have to investigate on your own.
Try to dump all the headers from intercepted request and see if it's even there.

If you check this https://github.com/simPod/grafana-json-datasource/blob/74774d3c4662fbce18f594478ce902d2268813fb/src/datasource.ts#L5-L24
It's possible we're not forwarding them there. You can investigate options here, if it's the case, we should reopen the issue with details so people with need of this can implement it.


[FX-4486] Lint all deprecation warnings to have a ticket number

FX-4486
Description
When we deprecate something, it MUST have a referencing ticket number for the scheduled removal.
This new set of eslint rules covers that, both @deprecated comments and deprecation warning hooks.
How to test

Temploy
Check out the branch
Search for @deprecated comments, they should now all be warnings
Try to add a ticket number to it, the warning should go away
Look for usePropDeprecationWarning or useDeprecationWarning calls in the codebase
it should also not be possible to use a hook without a TODO + ticket comment combo without spawning a warning

Screenshots

Development checks

[n/a] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[n/a] Annotate all props in component with documentation
[n/a] Create examples for component
[n/a] Ensure that deployed demo has expected results and good examples
[n/a] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[n/a] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


a error raise on python3.6+TF1.11Gpu

from .pse import pse_cpp
ImportError: dynamic module does not define module export function (PyInit_pse)

modify makefile，read readme for reference

yes, I modified the Makefile, and still raise a error:
g++: error: unrecognized command line option ‘-fno-plt’
The changelog page for GCC 6 says: The option -fno-plt is now fully functional.
But how to fix it for GCC 4.8?

g++ 6? I have tried 4.2 , 4.8 and 5.2.

I have fixed this problem from https://github.com/argman/EAST/issues/156

How should I modified the Makefile ? I get same error in pse_cpp . can you tell me in detail @hhliao


Confusing default values for SMTP (TLS/SSL)

Describe the issue
The default values for SMTP are confusing:
https://github.com/WeblateOrg/helm/blob/c009d08912a252305ec0d3bb48ff6c9a468eb91c/charts/weblate/values.yaml#L33-L36
You can always only set one of these to true, otherwise celery complains:
EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.

I already tried

[X] I've read and searched the documentation.
[X] I've searched for similar issues in this repository.

Steps to reproduce the behavior

Create a helm release without setting either emailTLS or emailSSL to false
You won't be able to send emails with the exception below.

Expected behavior
Since port 587 is used in the default values, I would suggest setting only emailTLS to true.
See also here:
https://docs.djangoproject.com/en/4.0/ref/settings/#std:setting-EMAIL_USE_TLS
Screenshots
No response
Exception traceback
celery-notify stderr | [2022-02-28 15:31:11,160: ERROR/ForkPoolWorker-1] Failure while executing task
celery-notify stderr | Traceback (most recent call last):
celery-notify stderr |   File "/usr/local/lib/python3.10/site-packages/celery/app/trace.py", line 451, in trace_task
celery-notify stderr |     R = retval = fun(*args, **kwargs)
celery-notify stderr |   File "/usr/local/lib/python3.10/site-packages/celery/app/trace.py", line 734, in __protected_call__
celery-notify stderr |     return self.run(*args, **kwargs)
celery-notify stderr |   File "/usr/local/lib/python3.10/site-packages/weblate/accounts/tasks.py", line 138, in send_mails
celery-notify stderr |     connection = get_connection()
celery-notify stderr |   File "/usr/local/lib/python3.10/site-packages/django/core/mail/__init__.py", line 35, in get_connection
celery-notify stderr |     return klass(fail_silently=fail_silently, **kwds)
celery-notify stderr |   File "/usr/local/lib/python3.10/site-packages/django/core/mail/backends/smtp.py", line 31, in __init__
celery-notify stderr |     raise ValueError(
celery-notify stderr | ValueError: EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.

Additional context
No response

Fixed in this PR


WurstSetup Exception

Please report this crash with the following info:
Version: <IP_ADDRESS>-jenkins-WurstSetup-50
us.monoid.json.JSONException: JSONObject["buildsByBranchName"] not found.
at us.monoid.json.JSONObject.get(JSONObject.java:419)
at us.monoid.web.jp.javacc.JSONPathCompiler$JSONPathExpr.eval(JSONPathCompiler.java:74)
at us.monoid.web.jp.javacc.JSONPathCompiler$JSONPathExpr.eval(JSONPathCompiler.java:40)
at us.monoid.web.jp.javacc.JSONPathCompiler$JSONPathExpr.eval(JSONPathCompiler.java:40)
at us.monoid.web.JSONPathQuery.eval(JSONPathQuery.java:42)
at us.monoid.web.JSONResource.get(JSONResource.java:130)
at net.ConnectionManager.getJson(ConnectionManager.kt:24)
at net.ConnectionManager.getBuildNumber(ConnectionManager.kt:64)
at net.ConnectionManager.getLatestCompilerBuild(ConnectionManager.kt:79)
at global.InstallationManager.verifyInstallation(InstallationManager.kt:50)
at file.SetupApp.startup(SetupApp.kt:86)
at file.SetupApp.handleArgs(SetupApp.kt:22)
at file.SetupMain.doMain(SetupMain.kt:54)
at file.SetupMain$Companion.main(SetupMain.kt:61)
at file.SetupMain.main(SetupMain.kt)

please post the log and what you did to make this occur

The day that you've fixed the setup issue, was working fine. Then a few days I didn't touch WurstSetup until today, and it ends up with such error. Restarted PC doesn't fix as well.
Log :

2018-02-06 20:49:12 [main] INFO  file.SetupApp - startup setup version: <<IP_ADDRESS>-jenkins-WurstSetup-50>
2018-02-06 20:49:15 [main] INFO  file.SetupApp - ConnectionStatus: ONLINE
2018-02-06 20:49:15 [main] INFO  global.InstallationManager - verify Install
2018-02-06 20:49:18 [main] WARN  global.InstallationManager - Installation is custom.

did you mess with your installation? it says "custom".
You can try deleting the .wurst folder in your user folder and reinstall. Can't look at this issue right now.

The problem occurs for me when I start the setup for the first time, never had wurst on this pc before.
The logfile just contains this:
2018-02-06 19:27:54 [main] INFO  file.SetupApp - startup setup version: <<IP_ADDRESS>-jenkins-WurstSetup-50>
2018-02-06 19:27:55 [main] INFO  file.SetupApp - ConnectionStatus: ONLINE
2018-02-06 19:27:55 [main] INFO  global.InstallationManager - verify Install

Okay, for some reason the json api of our buildserver changed.
I have made the check now more robust and also prevent exceptions from happening for this kind of error.
Thanks for reporting.


Formally specify a minimum maximum message size as part of the gRPC protocol

@ctiller thinks it might be astoundingly low (around 1024 or 2048 bytes) but one should be specified.
This issue arises from this user support thread.

@nathanielmanistaatgoogle Should this be maximum message size?

@kpayson64: no. Perhaps the protocol should also specify a maximum message size, but that's a separate concern.
Oh, but I think I see how the issue title might have been misread. Let me see if I can reword that...

so what is maximum message size for grpc 1.0.0?

@nickdul: as an implementation detail of gRPC 1.0.0, you'll start to see incorrect behavior around 4MiB. But for best results, you should try to limit your messages to tens of kibibytes.

you'll start to see incorrect behavior around 4MiB

is this configurable or hardcoded limit in gRPC 1.0.0?

@nickdul: it depends on which programming language you're using. For gRPC Python 1.0.0 it's configurable by an undocumented intended-for-power-users channel argument on the client-side and it's not configurable on the server-side.

@nathanielmanistaatgoogle: i'm using C#
thanks for your help - i've found appropriate option Grpc.Core.ChannelOptions.MaxMessageLength - it works
maybe you know - does max message length limitation exist for grpc-java (netty-based)?

@nickdul: I don't happen to know but @ejona86 would.

undocumented intended-for-power-users channel argument on the client-side

Hmm... I didn't really see this configuration being for "power users", although I guess it depends on your bar for "power users."

it's not configurable on the server-side.

That sort of seems necessary. Is it is the works?

does max message length limitation exist for grpc-java (netty-based)?

Yes. v1.0.0-pre1 had this in its release notes:

Reduced default max message size from 100 MiB to 4 MiB. ManagedChannelBuilder.maxMessageSize() and ServerBuilder.maxMessageSize() can override the default. Larger sizes are not a problem for grpc, but applications should be aware when they may receive large messages.

We really need a way to increase this limit. We have a lot of message types (>20+) that now require us to convert into a streaming/chunked format. It'll take us some time to do this so we'd really appreciate a stop-gap.

@proteneer, what language are you having trouble in?
Our intention is to support larger message sizes when it makes sense (so it doesn't even need to be a stop-gap), but to still encourage service developers to consider the impact of message sizes getting out-of-hand.

Python and Go. In particular the python server.
On Wednesday, September 21, 2016, Eric Anderson<EMAIL_ADDRESS>wrote:

@proteneer https://github.com/proteneer, what language are you having
trouble in?
Our intention is to support larger message sizes when it makes sense (so
it doesn't even need to be a stop-gap), but to still encourage service
developers to consider the impact of message sizes getting out-of-hand.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/grpc/grpc/issues/7927#issuecomment-248741174, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACLNFJrgAzHJpJ4q2kiCOPyZRpusvHbEks5qsZq3gaJpZM4JwtIe
.

--
Yutong Zhao

Go supports changing it on server-side (https://godoc.org/google.golang.org/grpc#MaxMsgSize). (It looks like the limit was not implemented client-side...)
Assigning to Nathaniel for Python.

@ejona86: note that this issue is not about @proteneer's immediate problem but rather something else entirely.
@proteneer: I think your need was recently addressed by @kpayson64 in pull request 8137. If you are able to work from our master branch, what happens when you change
grpc.server(thread_pool)

in your code to
grpc.server(
    thread_pool,
    options=(('grpc.max_message_length', <a large integer of your choice>,),))

?

Thanks Nathaniel, and sorry for the thread hijack. We will test this out tomorrow. Will #8137 go into the v1.0.x branch?

This fix works. We cherry-picked the patch for the time being because we don't want to use master for production. Other than that we consider the issue resolved. Thanks @nathanielmanistaatgoogle and @ejona86 for the help.

"ChannelOptions.MaxMessageLength" not work in c# client (Grpc v1.1.0). The limit is about 4MB.

Is there a way to specify a max message size in node.js yet?

Yes, you can specify max message size in Node, using a format very similar to what was described for Python. The Server constructor takes a single argument, which is an object that contains these options. I should note that since this issue was opened, this particular option has been split into max size of sent messages and of received messages. So you would write something like this:
new grpc.Server({'grpc.max_send_message_length': <large number>,
                 'grpc.max_receive_message_length': <large number>})

The Client constructors accept the same options in their third argument.

@murgatroid99 Thanks for the info. I discovered the same thing, but only after much digging through the source code.

I am having the issue for a php client interacting with a go server.whereas the go server max was set, I keep receiving this as message:
[null,{\"metadata\":[],\"code\":13,\"details\":\"Max message size exceeded\"}]

I tried adding maxRequestMessageBytes and maxResponseMessageBytes as options of the unaryCall, along with timeout option, but I keep getting the same error. I strongly believe this is due to php client side error, because all the work is done serverside.

If anyone is interested in the NODE solution for this per channel base you can pass as the third argument the following:

Is there a way to set the message size on the client side in C++?

Having the same question as @marcofiocco

How to specify the max_receive_message_length in ruby? I tried by passing it as server_args while creating server as
new(host_port: host_port, server_args: {:'grpc.max_receive_message_length' => 100 * 1024 * 1024})
But I still get the same error as GRPC::ResourceExhausted (8:to-be-sent trailing metadata size exceeds peer limit)

@KirtiChug, max message size is different from max header list size. I think you're looking for grpc.max_metadata_size instead.

@Possum3D I can't implement your solution in PHP.
I've got this code:
$buffer = 8 * 1024 * 1024 // 8Mb buffer
$server = 'localhost:1000';

$client = new MyGrpcService(
     $server,
     [
          'credentials' => Grpc\ChannelCredentials::createSsl($root, $key, $cert),
          'grpc.max_message_length' => $bufferSize
     ]

But it continues faillings with large grpc messages.
Any solution to this issue?
Thanks.

I need to increase the MaxMessageLength and I am using the grpcio python lib, can anyone show me the sample code for configuring it in python?

@Michael-Jing
MB = 1024 * 1024
GRPC_CHANNEL_OPTIONS = [('grpc.max_message_length', 64 * MB), ('grpc.max_receive_message_length', 64 * MB)]
channel = grpc.insecure_channel(api_url, options=settings.GRPC_CHANNEL_OPTIONS)

To the best of my knowledge this should stay open...

Go supports changing it on server-side (https://godoc.org/google.golang.org/grpc#MaxMsgSize). (It looks like the limit was not implemented client-side...)
Assigning to Nathaniel for Python.

Go supports changing it on server-side (https://godoc.org/google.golang.org/grpc#MaxMsgSize). (It looks like the limit was not implemented client-side...)
Assigning to Nathaniel for Python.

Hi
Any idea about the max send message side at gRpc server ?
// MaxSendMsgSize returns a ServerOption to set the max message size in bytes the server can send.
// If this is not set, gRPC uses the default math.MaxInt32.
func MaxSendMsgSize(m int) ServerOption {
return newFuncServerOption(func(o *serverOptions) {
o.maxSendMessageSize = m
})
}
https://github.com/grpc/grpc-go/blob/6b46f470d101e9ad1c8a02a4c8cb06fb53a0d300/server.go#L280
According to above code its math.MaxInt32 which is<PHONE_NUMBER> in bytes according to
https://stackoverflow.com/questions/6878590/the-maximum-value-for-an-int-type-in-go
If I convert<PHONE_NUMBER> bytes to MB I get 2048 or 2GB approximately. Is that correct ?


[Auth] Some svg icons give "Invalid DOM property" warning

Bug report
Describe the bug
In Next.js, when 'azure' or 'discord' is entered into to the providers props array, the above mentioned warning is thrown.

Provider
Warning

azure
Invalid DOM property stop-color. Did you mean stopColor?

azure
Invalid DOM property stop-opacity. Did you mean stopOpacity?

discord
Invalid DOM property clip-path. Did you mean clipPath?

To Reproduce
Use Discord & Azure as Social Providers for the Auth component.
  <Auth supabaseClient={supabase} providers={['discord', 'azure']} />

Expected behavior
Appropriate DOM property name is used.
Screenshots

System information

OS: macOS
Browser: chrome, firefox, safari
Version of supabase-js: "^1.24.0",
Version of supabase/ui:  "^0.35.0",
Version of Next.js: "11.1.2",
Version of Node.js: v14.17.1

:tada: This issue has been resolved in version 0.36.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


opt: Remove the configuration field secret

关联的Issues (Related Issues)

close https://github.com/filecoin-project/venus/issues/5697
改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)
在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

[ ] 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
[ ] 具有清晰明确的commit message / All commits have a clear commit message.
[ ] 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
[ ] 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
[ ] 通过必要的检查项 / All checks are green

Codecov Report

Merging #165 (456f3a8) into master (f4a5a01) will increase coverage by 0.09%.
The diff coverage is 76.92%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   44.48%   44.58%   +0.09%
==========================================
  Files          40       40
  Lines        4372     4338      -34
==========================================
- Hits         1945     1934      -11
+ Misses       2196     2178      -18
+ Partials      231      226       -5

Flag
Coverage Δ

unittests
44.58% <76.92%> (+0.09%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cli/run.go
0.00% <0.00%> (ø)

cmd/mock/main.go
0.00% <0.00%> (ø)

jwtclient/inteface.go
0.00% <ø> (-20.00%)
:arrow_down:

auth/app.go
48.89% <100.00%> (ø)

auth/jwt.go
75.90% <100.00%> (+1.72%)
:arrow_up:

config/config.go
56.52% <100.00%> (+1.11%)
:arrow_up:

integrate_test/mock_deamon.go
58.33% <100.00%> (+4.48%)
:arrow_up:

jwtclient/local_auth_client.go
76.00% <100.00%> (ø)


Make user verification a bit more robust

E.g. remove trailing whitespaces before verifying. Maybe it could also make sense to make the check case insensitive and actually remove all whitespaces, so it also works if people insert spaces in stead of fx writing camel case

Closed by 211f0bb0030c8eac37a31e6f7b52e97014398ac6


OWNERS

What to document
Who are the maintainers?
Also, create an OWNERS file accordingly.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
On Fri, 19 Feb 2021 at 16:01 poiana<EMAIL_ADDRESS>wrote:

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually
close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/falcosecurity/katacoda-scenarios/issues/2#issuecomment-782129181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5J44N7Z4NKPL3V5BXDKTS7Z4OJANCNFSM4OENESDQ
.

--
L.


Dario object new

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\2xcx-s, target branch: master, target branch commit: 8c76936a2430e931d44733a3c8d07caa4927208c, source branch: 7404d648cd6bdb46e5473f9db7534616/Dario-Object-new, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\otjq-s, target branch: master, target branch commit: 8c76936a2430e931d44733a3c8d07caa4927208c, source branch: 7404d648cd6bdb46e5473f9db7534616/Dario-Object-new, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\sh35-s, target branch: master, target branch commit: 8c76936a2430e931d44733a3c8d07caa4927208c, source branch: 7404d648cd6bdb46e5473f9db7534616/Dario-Object-new, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\sqtn-s, target branch: master, target branch commit: 8c76936a2430e931d44733a3c8d07caa4927208c, source branch: 7404d648cd6bdb46e5473f9db7534616/Dario-Object-new, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\j4kt-s, target branch: master, target branch commit: 8c76936a2430e931d44733a3c8d07caa4927208c, source branch: 7404d648cd6bdb46e5473f9db7534616/Dario-Object-new, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/sharepoint-online.md
:x:Error

Details

:x:Error

Details

sharepoint/sharepoint-ps/sharepoint-online/sharepoint-online.md

[Error] Unable to load file: sharepoint-ps/sharepoint-online/sharepoint-online.md via processor: AzureCliDocumentProcessor: :4:(58) '

[Add-SPOGeoAdministrator](Add-SPOGeoAdmini...'
Expect Heading level 2

[Error] Markdown.MAML.Transformer.HelpSchemaException: :4:(58) '

[Add-SPOGeoAdministrator](Add-SPOGeoAdmini...'
Expect Heading level 2
at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.GetInnerContexts(DocumentBuildParameters parameters, IEnumerable1 processors, TemplateProcessor templateProcessor, IHostServiceCreator creator)    at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.BuildCore(DocumentBuildParameters parameters)    at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.Build(DocumentBuildParameters parameters)    at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.BuildCore(DocumentBuildParameters parameter, IMarkdownServiceProvider markdownServiceProvider, BuildInfo currentBuildInfo, BuildInfo lastBuildInfo)    at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.Build(IList1 parameters, String outputDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


streamanalytics: API doesn't support Job Sku StandardV2

There is a new pricing model for Stream Analytics Jobs called StandardV2 but the api spec currently only supports Standard
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/streamanalytics/resource-manager/Microsoft.StreamAnalytics/stable/2020-03-01/streamingjobs.json#L817

Any update on this?


fix on views.py: flush and close file before reading: otherwise file …

The pull request is my solution to my issue
https://github.com/dveselov/docsbox/issues/4
With those patches the service forks for me.

Thanks!


Populate Real Type Functionality

Real is the floating point type of ASN.1. A skeleton of the Real type has been added (include/fast_ber/ber_types/Real.hpp). Populating this skeleton will allow users to use the Real type in their ASN.1 schemas.
Encoding and decoding functionality should be provided, according to the rules specified in X.690. The class should hold the real type in partially encoded state, as with integer to reduce parsing / encoding time. Unit tests and benchmarks should be added.
Acceptance

Functions in the Real type are populated
Real is added to test/ber_types/RealTest.cpp
Real is added to test/ber_types/AllTest.cpp
Real is added to benchmarks/ComponentPerformance.cpp

Hello there,
Taking interest into this project as I use ASN1 everyday 👍
As I am currently implementing the Real type, I was looking to the ITU BER specs and it seems that the document you linked above is not the lastest release. The link is refering to an older one which is deprecated. The correct X690 spec is this one.

Thank you for taking the time  to do so!
I look forward to your contribution. Please make a pull request into master branch when your submission is ready. (Only as devel is currently not building on all platforms, which I will be resolving).
I am glad to hear of your experience with ASN.1 and BER. Have you had the opportunity to run any of your specs through the compiler? If so I'd love to hear of any compilation errors.
Thank you,
Sam

Hey @kurkpitaine, did you make any progress on this?

Hi @Samuel-Tyler !
Yep I made progress. Full spec decoding is ready, encoding is almost done.
I need to finish populating all the functions and write some tests

Thanks, sounds great!
For encoding, no need to support all the possible encodings, pick the one that makes the most sense.
Let me submit some (failing) unit tests to show what I'm expecting.
If you would like, you may submit your work in progress for review.

I've added some initial test cases here:
https://github.com/Samuel-Tyler/fast_ber/pull/19/files
Hope this helps. Feel free to expand them of course.

Have finished Base 2 encoding, I open a PR for review

@Samuel-Tyler
I opened a PR with my work here: https://github.com/Samuel-Tyler/fast_ber/pull/20

Looks very good on first inspection! Thank you very much. I will do a full review later.
I am aware that the standard implementation of std::regex is poor. We could potentially use CTRE to speed this up, if people happen to use the REAL type commonly in their codebase.

std::regex is used only if we decode an Iso 6093 NR1/NR2/NR3 encoded real number. Most of the time, it is a binary base encoding. But indeed this would be better with a better regex implementation 😊

@kurkpitaine I would be interested to hear more about your usage of ASN.1. What do you use it for?
Are there other features you need in fast_ber for your use case?
Thanks

I use ASN.1 for ITS communications protocols, syntaxes are available here: https://forge.etsi.org/rep/ITS/ITS_ASN1
Unaligned PER encoding is exclusively used in upper layer messages.
However, Canonical OER and DER encodings are used on the security layer and this is where I need an high speed ASN.1 implementation. I did not found any suitable C++ implementation which is satisfying: partial implementation, no active maintenance, ...
After some research, I found fast_ber and it sounds promising !
Since BER/DER/COER are not so different, I think we can implement them into fast_ber

Yes, adding support for the different encodings is a priority for me.
By default, everything should be encoded as DER, currently.

Have you attempted to parse any schemas?
Let me know if you've seen any errors in the compiler.

Hey @kurkpitaine
I hope you are well during these times.
I would like to do a release soon, and I would love to include your work on the REAL type. Do you have any more commits that we can work together to get merged?
Thanks,
Sam

Hi @Samuel-Tyler,
I'm good thank you, hope everything is ok on your side !
Yes, I have worked on my side, I still need to finish some tests cases but I can push my code so you can take a look at it.

Good to hear you are well.
That would be great if you could push the changes, I hope the merge will not be too painful as I have made a number of changes.
Thanks.

I pushed the work on my side, changes are available in the same PR.

Thanks! Would you like me to merge the latest changes into your branch?

Yes for sure !

Great, I've done so, I've also added Real to the AllType test and to the benchmarks, the results there look good.
I've left a few comments... once these are resolved we can get this merged.

Hi @Samuel-Tyler,
I made changes today regarding the PR, I let you check!

Ok, it's ready to merge. Great work, thanks again!

I merged the PR, we can close this issue 👍


feat(traffic_light): improved traffic_light_map_based_detector and new traffic_light_fine_detector package

Description

Add new output topic expect/rois to traffic_light_map_based_detector
Use multiple transforms for calculating rough rois in traffic_light_map_based_detector considering timestamp delay
Update traffic_light_classifier models
Update traffic_light_classifier code. Remove the trt_common within the package and replace with the trt_common package
Add new traffic_light_fine_detector which performs traffic light object detection using yolox-s model
The traffic_light_fine_detector uses topic expect/rois to perform detection matcher which could distingush traffic light objects very near to each other
The yolox-s model might be updated later
Add traffic_light_multi_camera_fusion packge

Tests performed

Nothing.
Effects on system behavior

Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

I think it would be better to align the granularity of the package name with traffic_light_ssd_fine_detector. Any idea?
Do you mean showing the mAP and inference time of these two packages?
It can be done, but we need to solve the following problem:

yolox model is trained on over 15000 images while ssd model is trained only on around 1500 images
The inference time is not validated yet.

We have the plan to update the yolox model next month (maybe also re-train the ssd and update).
Could we update the information in next PR?

@miursh
Sorry for the errors.
I just fixed the bugs and now all traffic light launch files should work.
Also updates of traffic_light_classifier and traffic_light_multi_camera_fusion are commited.

@Mingyu1991
General question. When doing the fusion among detections of different cameras you use the current camera_info (the one that triggered the callback) as part of the criteria for comparison among records.
Since you compare rois of different cameras, does not this implicitly assume that all cameras involved share the same resolution? I believe that for our current test case that assumption holds but it is not guaranteed in my opinion.

@Mingyu1991 General question. When doing the fusion among detections of different cameras you use the current camera_info (the one that triggered the callback) as part of the criteria for comparison among records.
Since you compare rois of different cameras, does not this implicitly assume that all cameras involved share the same resolution? I believe that for our current test case that assumption holds but it is not guaranteed in my opinion.

@knzo25
That's not how the fusion node works.
One of the ros param of the node is "camera_namespaces", which is of type vector<string>.
In our system, it is ["camera6", "camera7"].
Then for every camera namespace,
the node will create ExactTime subscribers to subscirbe
[
"/perception/traffic_light_recognition/<camera_ns>/camera_info"
"/perception/traffic_light_recognition/<camera_ns>/rois",
"/perception/traffic_light_recognition/<camera_ns>/traffic_signals"
] .
Therefore, for your question, when handling camera6 results, it will use
"/perception/traffic_light_recognition/camera6/camera_info"
and when handling camera7, it will use
"/perception/traffic_light_recognition/camera7/camera_info".
So it does not require same resolution of cameras

@Mingyu1991 General question. When doing the fusion among detections of different cameras you use the current camera_info (the one that triggered the callback) as part of the criteria for comparison among records.
Since you compare rois of different cameras, does not this implicitly assume that all cameras involved share the same resolution? I believe that for our current test case that assumption holds but it is not guaranteed in my opinion.

@knzo25 That's not how the fusion node works. One of the ros param of the node is "camera_namespaces", which is of type vector<string>. In our system, it is ["camera6", "camera7"]. Then for every camera namespace, the node will create ExactTime subscribers to subscirbe [ "/perception/traffic_light_recognition/<camera_ns>/camera_info" "/perception/traffic_light_recognition/<camera_ns>/rois", "/perception/traffic_light_recognition/<camera_ns>/traffic_signals" ] . Therefore, for your question, when handling camera6 results, it will use "/perception/traffic_light_recognition/camera6/camera_info" and when handling camera7, it will use "/perception/traffic_light_recognition/camera7/camera_info". So it does not require same resolution of cameras

Are not trafficSignalRoiCallback and record_arr_set_ shared among sensors?

@Mingyu1991 General question. When doing the fusion among detections of different cameras you use the current camera_info (the one that triggered the callback) as part of the criteria for comparison among records.
Since you compare rois of different cameras, does not this implicitly assume that all cameras involved share the same resolution? I believe that for our current test case that assumption holds but it is not guaranteed in my opinion.

@knzo25 That's not how the fusion node works. One of the ros param of the node is "camera_namespaces", which is of type vector<string>. In our system, it is ["camera6", "camera7"]. Then for every camera namespace, the node will create ExactTime subscribers to subscirbe [ "/perception/traffic_light_recognition/<camera_ns>/camera_info" "/perception/traffic_light_recognition/<camera_ns>/rois", "/perception/traffic_light_recognition/<camera_ns>/traffic_signals" ] . Therefore, for your question, when handling camera6 results, it will use "/perception/traffic_light_recognition/camera6/camera_info" and when handling camera7, it will use "/perception/traffic_light_recognition/camera7/camera_info". So it does not require same resolution of cameras

Are not trafficSignalRoiCallback and record_arr_set_ shared among sensors?

Yes, you are correct.
That's a bad implementation.
I will solve it.

@knzo25
I added camera_info to FusionRecord and use that in the fusion in the latest commit.
Thank you for pointing that out!

@Mingyu1991
Sorry for insisting on the underscore_case but
fusionedRecordMap and regEleId2BestRecord still follow cammelCase

Modified in https://github.com/autowarefoundation/autoware.universe/pull/3442/commits/93b7b996763f582dc32d76c2200fae4e0908b026

@Mingyu1991 Sorry for insisting on the underscore_case but fusionedRecordMap and regEleId2BestRecord still follow cammelCase

@knzo25
Modified in https://github.com/autowarefoundation/autoware.universe/pull/3442/commits/93b7b996763f582dc32d76c2200fae4e0908b026

@Mingyu1991 Accoding to discussion in https://github.com/autowarefoundation/autoware.universe/issues/2567#issuecomment-1364772138, traffic signal msg should have relation ID (regulatory_element), but it looks current topics have traffic_light ID inside. Could you add change to publish regulatory_element ID?

@Mingyu1991 How do you think about this ?

@Mingyu1991 How do you think about this ?

@Mingyu1991 Accoding to discussion in #2567 (comment), traffic signal msg should have relation ID (regulatory_element), but it looks current topics have traffic_light ID inside. Could you add change to publish regulatory_element ID?

Sorry for late reply.
The discussion #2567 (comment) defined the TrafficSignal.msg of autoware_perception_msgs, but my understanding is autoware_perception_msgs are the interface with other modules, and this PR is only working on the internal nodes of traffic light module using autoware_auto_perception_msgs.
If we want to add the regulatory_element to the traffic signal, wouldn't it be better to achieve that in traffic_light_arbiter?

@miursh
The newest commits has replaced the old autoware_auto_perception_msgs with new autoware_perception_msgs as planned here

@Mingyu1991 Sorry to change the policy so often.
As we discussed offline, we decide to use

new traffic signal msg as output of multicamera-fusion
conventional autoware_auto_msgs as perception internal msg

I'm sorry for the trouble.
I made a mistake and rebased the commits.
I will close this PR and reopen one.

Another PR is opened.
Close this.


Add to semantics of super: < 0 means dropped

LGTM. May want to add another row in students_one for the dropped column.
On Monday, September 12, 2016, Aleks Kamko<EMAIL_ADDRESS>wrote:

Assigned #15 https://github.com/octobear2/ob2/pull/15 to @rogerhub
https://github.com/rogerhub.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/octobear2/ob2/pull/15#event-786154063, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAkgpoU_KKd_eR0AFrcLXLS5XIVVHXkLks5qpXLOgaJpZM4J6uh0
.


add stricter regexp to detect node interfaces

Current node interface detection pattern matches gretap and erspan interfaces which leads to either:

init loop because the matching line count is not equal to clab interfaces count
when clab interface count == 2, the init will possibly start without the real eth interfaces ready and they will never be initialized

This made freertr deployment behave erratically on my clabernetes cluster which includes erspan/gretap.
Old pattern
~# ip -o link show | grep eth | grep -v eth0
3: gretap0@NONE: <BROADCAST,MULTICAST> mtu 1462 qdisc noop state DOWN mode DEFAULT group default qlen 1000\    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
4: erspan0@NONE: <BROADCAST,MULTICAST> mtu 1450 qdisc noop state DOWN mode DEFAULT group default qlen 1000\    link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
14: eth1@if13: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default \    link/ether aa:c1:ab:12:47:93 brd ff:ff:ff:ff:ff:ff link-netnsid 0
16: eth2@if15: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default \    link/ether aa:c1:ab:95:30:3c brd ff:ff:ff:ff:ff:ff link-netnsid 0

New pattern
~# ip -o link show | grep -P 'eth[1-9]\d?@'
14: eth1@if13: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default \    link/ether aa:c1:ab:12:47:93 brd ff:ff:ff:ff:ff:ff link-netnsid 0
16: eth2@if15: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default \    link/ether aa:c1:ab:95:30:3c brd ff:ff:ff:ff:ff:ff link-netnsid 0

Thanks for this PR ! LGTM