Motorcontrol Refactoring

After a bit of experimentation I've settled on a structure I hate the least, though it is far from perfect so I'd like your input. For reference, the code I've made is in the motor_controler_interface_update branch.
My first goal is to remove the extensive templating we used last year. It's a powerful and useful tool, but the way it propagated through our entire codebase created the horrible compiler errors we got last year.
I first tried to put both linear (meters) and angular(radians) units into the same class, but that created issues in converting between units in more complex mechanisms (where you can't just multiply by a constant). Furthermore, having both units doesn't always make sense, meaning half the functions would return null.
Instead I separated linear and angular units into their own classes, and made a method to generate a controller in the other unit type for the common case of a linear conversion. In more complex cases, we can make a custom converter classes. It provides additional benefit since we only need to implement the angular class for each motor controllers and we can automatically generate the corresponding linear controller when required.
This structure unfortunately makes templates really tempting since there is lots of duplicate code with only the units changed. And I did write an implementation using templates that I'm tempted to use since I think it avoids the problems of last year. Since we only need to implement motors in radians, the templating will not propagate through the rest of the codebase. This way the templating does what we want, eliminating duplicate code, without the downsides of a more complex implementation.
The specifics of the interface and what actual functions should go in it is also still up for debate, but I think this method of handling units is the best I found so far. What do you all think?

Exciting! I'll take a look and contemplate stuff once the jet lag wears off 🥱.

@gcjurgiel I really like this interface! 🎉  It's certainly much more concise than what we had before. I personally don't think templating is worth it, but we can discuss this into further detail.
I gave the code a readover and found only on minor issue. I think LinearPositionController is a virtual class and doesn't have a constructor defined.
IMHO, the interface for getting the conversion should be more like this:
class AngularPositionController {
...
LinearPositionController asLinear(ConversionUnit_t conversion) {
    return AngularAsLinearPositionController(*this, conversion); // or whatever the classname is for the conversion class
}
...
}

I think we can avoid pointers almost entirely as the conversion class handles a tiny amount of data (one reference?) and can be constructed every time the asLinear function is called.
I'm itching to use this API. I think this proves that we can write good code if we think about it a little more.
Thanks for doing all of the work!!!
Aiden

Thanks for looking it over, and I'm glad you like it!
I think that LinearPositionController should remain a virtual class since it's just the interface. AngularAsLinearPositionController does the actual converting. However, this means we can't return a raw LinearPositionController object. The simplest solution is to actually return an AngularAsLinearPositionController object. when I originally wrote this, I purposefully used a pointer to erase the underlying type as a way of hiding the converter class from the user, but I don't remember why I thought that was needed so I'll probably get rid of it.
As for the templates, I'm inclined to agree with you. The structure is easier to understand without it, and it will only introduce more errors. My only hesitance comes from some of non unit specific wrapper I've been messing with. Templates reduce duplicate code, but I'm not sure the wrappers are worth putting time into when most of their functionality can be done by the motor controllers themselves. Any that could actually be useful would really only need to done in angular units, and could be implemented twice if needed.
I'll make the changes I mentioned above and we can talk more once school starts again.

I wasn't involved much towards the end of last year but I think this looks very good. I don't see a problem with using smart pointers or references when converting from angular to linear and vice versa. Excited to start implementing this when we get back.

A proposed modification to the asLinear function, but it has to defined outside the original class.
std::unique_ptr<LinearPositionController> asLinear(std::unique_ptr<AngularPositionController> angularController,
                                                   units::unit_t<units::compound_unit<units::meters, units::inverse<units::radians>>> conversion) {

  return std::make_unique<AngularAsLinearPositionController>(angularController, conversion);
}

If I do it right, the converter class now takes ownership over the base controller. This prevents undefined behavior from things going out of scope. It also prevent the possibility of creating two objects that control the same motor controller that could be send contradicting signals.

Thinking about it, Aiden is right, it's probably better to use shared pointers for their flexibility. Our use of abstract classes means that the ownership model isn't always clear. Returning references don't work when the sub-class doesn't own the object being returned, and unique pointers don't work when they do (since we don't want the original to give-up that ownership). Shared pointers can work in both these situations even though it can confuse who "really" controls the object. It also means we will have to watch-out for circular ownership problems, but I don't think that will be an issue.


geohex_grid aggregation results missing doc_count_error_upper_bound and sum_other_doc_count fields

What is the bug?
geohex_grid aggregation results missing doc_count_error_upper_bound and sum_other_doc_count fields.
How can one reproduce the bug?

Index data with a geo_point field (named centroid in the example below).
Run geohex_grid aggregation like:

POST /my_index/_search
{
  "aggs": {
    "grid_geohex_frequency": {
      "geohex_grid": {
        "field": "centroid",
        "precision": 3
      }
    }
  },
  "size": 0
}

The response is like:
"aggregations": {
    "grid_geohex_frequency": {
      "buckets": [ ... 10000 buckets ]
  }
}

What is the expected behavior?
I would expect the response to also have doc_count_error_upper_bound and sum_other_doc_count fields when there are documents which are not covered by by the buckets returned, as is done with term aggregation.
What is your host/environment?
AWS OpenSearch Service 2.5
Do you have any screenshots?
n/a
Do you have any additional context?
no

I believe those parameters are part of term aggregation. Geo hex aggregation will consider all documents unlike terms where you can use size parameter to list only top buckets.

geohex_grid also has a size parameter per the documentation, which defaults to 10000, so this is exactly like terms.
The geoaggregations should be consistent with terms, since they're just another type of bucket value. Not having these fields, especially sum_other_doc_count, limits the usefulness of geoaggregations, since you have to use a heuristic (bucket count is exactly 10000) to determine if there were documents that are not represented in the bucket values and you'd have to run separate count of determine how many documents were not represented.

@philvarner You are absolutely right. Thanks for detailed explanation and reporting this bug, we will look into this issue. However, feel free to contribute if you know how to fix this issue.

@nknize This is not available with other geo aggregations like geo_hash and geo_tile. I believe this can be added to BaseGeoGrid, so that all geo aggregations can inherit this value in response. Do you see an issue in enabling this feature for geo aggregations conceptually? Please share your feedback. Thanks


how to use geo location ?

Hi, I'm new to this nice package, I want to be able to understand how to use  it more.
I'm trying to use the geo location which is mentioned in this page https://leafletjs.com/examples/mobile/
I can't figure out how can use this:
map.locate({setView: true, maxZoom: 16});
I want to keep this nice clean implementation of directives, is there any way to do that ?

I got this working by doing the following:

I've just used:
onMapReady(map: Map) {
map.locate({ setView: true, maxZoom: 16 });
}
and it's related directive in html:
(leafletMapReady)="onMapReady($event)"
as it's mentioned in the package's documentation.
this is really powerful method, it give me access to use the original methods that in the leaflet library.
Thanks a lot.


Compatibility issue with with old qBittorrent 3.1.10

No torrents that are downloading show up in the any list like all etc, but it neither shows any error like unreachable host either. Use to work earlier.
I was using qbittorrent 3.3.6 earlier. Now I moved to 3.1.10 cause of os change to raspbian from Ubuntu mate. I had used this some time back as well. Issue started coming after I downgraded to 3.1.10
Reported by Debsadhan Seth thru qBittorrent report mail

I could check there's an issue when switching between new and old qBittorrent server versions.
Basically the way how authentication is handled before 3.2.x (like 3.1.10) changed.
A possible workaround is to remove the application from the app list and the try to reconnect to the qBittorrent server 3.1.10. At least it worked for me.


Pass custom function to option.clickBehaviour

There are cases where developer will want the custom action on image click.
clickBehaviour: function(){ alert('You have clicked the image'); }

Thanks, makes sense. I've backported your changes to the .coffee file since this project is written in CoffeeScript.


Revisit styling of the Gateway list items and create a reusable component

I have two observations on the styling of the list items.

I'm wondering if we're able to style the Gateway display name with an underline based on the state of the parent to better match the styling of cards in the Gateways manager:

Current:

Comparison (expected from Gateway details):

Quick mockup to illustrate:

Should we think about focus states for the list items? They seem to be absent on a few links throughout the Services portal. Is it possible to use a Chakra Link component (which composes <Box /> and has the desired focus state) instead of a <Flex />  with an onClick event? Might be worth discussing the composition here if we are planning on making a reusable component.

Originally posted by @timng-bcgov in https://github.com/bcgov/api-services-portal/pull/1179#pullrequestreview-2307883242

Some more examples of expected styling from the Portal:
Actions:

Buttons:

Directory cards:


Query parameters do not get added to view history with domCache

This is the same issue as described in #209 but with domCache: true and using #pagename navigation.
If I navigate by clicking on this link:
Page1
And then click on this link within Page 1:
Page 2
And then click on this link within Page 2:
Back
This listener would show an empty query where I would expect to see the "foo: bar" query data:
$document.on('pageReinit', function(e) {   console.log(e.detail.page.query); });
I made a 1 line change that fixes the problem in my case but I am not aware if this causes any other side effects:
--- framework7.js.orig	2015-10-24 18:21:16.000000000 -0300
+++ framework7.js	2015-10-24 18:21:06.000000000 -0300
@@ -2556,6 +2556,8 @@
             var content = options.content;
             var pageName = options.pageName;
             if (pageName) {
+                options.url = '#' + pageName;
+
                 if (pageName.indexOf('?') > 0) {
                     options.query = $.parseUrlQuery(pageName);
                     options.pageName = pageName = pageName.split('?')[0];

Thanks, fixed now in dev version

Confirmed. Thanks for the quick fix!


Book Chapter Modal Alignment Issues

The modal for the book appears in quite a strange place on-screen sometimes. Often it's top bar is in the centre of the sceen, but sometimes it's right at the top and other times it's so low that the bottom of the modal is offscreen. Can we do something more sensible?
I think this uses the standard modal stuff in app/directives/IsaacModal.js

Fixed in https://github.com/ucam-cl-dtg/isaac-app/commit/161a71a67c9adb43025e5636a0a3f08450325639


[18.09] Bump Golang 1.10.6 (CVE-2018-16875)

go1.10.6 (released 2018/12/14)

crypto/x509: CPU denial of service in chain validation golang/go#29233
cmd/go: directory traversal in "go get" via curly braces in import paths golang/go#29231
cmd/go: remote command execution during "go get -u" golang/go#29230

See the Go 1.10.6 milestone on the issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.10.6

Experimental failed on a flaky, but restarted it
01:01:13 FAIL: docker_api_swarm_test.go:296: DockerSwarmSuite.TestAPISwarmLeaderElection
01:01:13
01:01:13 [d61d7f09b27d0] waiting for daemon to start
01:01:13 [d61d7f09b27d0] daemon started
01:01:13
01:01:13 [d6ddc19befe49] waiting for daemon to start
01:01:13 [d6ddc19befe49] daemon started
01:01:13
01:01:13 [d8aa72ad406ae] waiting for daemon to start
01:01:13 [d8aa72ad406ae] daemon started
01:01:13
01:01:13 [d61d7f09b27d0] exiting daemon
01:01:13 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded
01:01:13 [d6ddc19befe49] exiting daemon
01:01:13 [d8aa72ad406ae] exiting daemon

ping @andrewhsu @seemethere PTAL


Behavior of back button/key

When I search for something and I want to go back to main timeline the back button/key closes AndStatus despite going back as expected. Same thing for going back from Mentions to main timeline.
I think that's no big problem but a bit confusing compared to other (social networking) apps.

Actually a User has a clue when he is on a Home screen: no Up button on an Action bar.
But I agree that maybe we should have a "Default Timeline" as suggested in #236, and Back button would return to this timeline first?!

BTW,  Back and Up buttons are not the same...

Agree, back button should go back from current view state to previous view state. If I change the view state and back button closes the app, that's confusing -- especially when in a "custom" mode like search. I have closed AndStatus many times due to this.

@clacke I recently thought about allowing the Timeline Activity to have multiple instances. The main problem,  which we may face in that case, will be "Out of memory" error.
Anyway, I will definitely try this. Now I'm redoing Timeline content loaders #313 , so this change, maybe as an option, looks like natural...

I think that we don't need multiple instances of a Timeline. We could just remember a history of timeline switching. And go back that history (switching in reverse direction...

I just posted #356 which is pretty much the same issue. Is it not possible to have a "home/back-option with the home setting being the default TL position?

referred of #422
Yes, I think we mean the same.
I summarize again:
This symbol is above if I am the start time line on. on the left:

I have this back arrow at many but not all undersides:

It would simplify the navigation very much if this arrow on every underside existed.

@b2410 What you show on your screenshots is "Up" button, which is about navigation in a hierarchy of views. "Back" button is a hardware button below the device's display. That button is about history of navigation between views (e.g. history of switching between different timelines of AndStatus.
Please read this carefully: https://developer.android.com/design/patterns/navigation.html (I did this right now...)
Taking that Android guidelines and terminology into account I think that "Up" button, which you showed above, works correctly (at least in most cases...).
What definitely needs to be improved - the dedicated (usually hardware) "Back" button, which generally looks like this:

or like this (onscreen button):

Excuses my mistake. I have never noticed the difference.
It is working now as described in the link. Perfect.

Implemented in v.30.00. Please test: the Open Beta testing channel https://play.google.com/apps/testing/org.andstatus.app

@yvolk It functions perfectly. Thank you.

@b2410 Actually the change was trivial. Why I didn't do this earlier: I was afraid that this would cause out of memory issues. Please report if you have them after this change.

@yvolk I test it 5 days without problems. The app or the phone was not restarted. More Ram is not required.

@b2410 Thank you for the feedback!


Added the Longest Palindromic Substring Solution

All Submissions:

[x] I have read the CONTRIBUTING document.
[x] My code is written in Python3 and is ending with .py
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have checked that my submission does pass the test on LeetCode.com
[x] Does your filename follow the naming Conventions?
[x] Have you linked your PR to an Issue?

Closing issues
Closes #5

Leetcode Submission Result:-

@vJechsmayr Kindly check this once.
Also, please add a "hacktoberfest-accepted" label if everything is fine and then merge the PR.


Add mock-token-metadata-server --port CLI option

Overview
Allows the mock server to use a fixed port - otherwise it's a bit annoying.
Documentation
Usage: mock-token-metadata-server FILE [--port PORT]

Available options:
  -h,--help                Show this help text
  FILE                     Path to the JSON file containing metadata.
  --port PORT              Port to listen on (default: random unused port)

This serves only the `POST /metadata/query' endpoint of Cardano metadata-server.
Other endpoints are unimplemented because they are not used by cardano-wallet.

The OpenAPI specification of the real metadata-server is here:

  https://github.com/input-output-hk/metadata-server/blob/master/specifications/api/openapi.yaml

To use this, create a `registry.json' file in the same format of that returned
by the metadata-server query endpoint. That is:

  { "subjects": [entry1, entry2, ...] }

Each entry should match what is usually submitted to the metadata server. There
are some example json files in this registry:

  https://github.com/input-output-hk/metadata-registry-testnet

To connect your wallet backend to the mock metadata server, use the URL which is
printed out when this program starts.

Pass the URL to the wallet like so:

  cardano-wallet serve --token-metadata-server URL ...

On every request, the server will read the file, filter and return the queried
metadata. So you don't need to restart the mock server after editing metadata.

You can make test requests to the metadata server using curl:

  curl -i -H "Content-type: application/json" \
    --data '{"subjects":["entry1", "entry2", ...],"properties":["name","description"]}' \
    http://localhost:PORT/metadata/query

bors r+


is communication helpful in the MARL

Dear author, I am wondering is it helpful if the agent incorporates other agents' information (e.g., state, policy) during testing, or it is not necessary for DER to communicate with each other when they are connected to the main grid. Thank you for your time and insights!

Dear Derekabc,
Thanks for your insightful question. Yes, you are right that DERs can comminicate with each other and surely this could promote the cooperation and cope with the emergent situation happened, which is highly correlated to the emergent communication in MARL and as I know there is a bunch of works strives on it.


profile.username vs profile.name

If I'm not mistaken, it seems like if someone logs in with username/password their username gets copied to profile.username, while if they use Twitter it gets copied to profile.name. Maybe it'd be better to harmonize both?

Yeah, absolutely!
If this is actually what's happening, we need to fix it!
I'll have a look

I can also confirm that logging in via Facebook creates a profile.name field.

I'd say this line is the one causing the profile.name to be set after facebook signup...
And this is the one for google, twitter, etc.
So we'd need to change this line to be:
options.profile.name = signupInfo.username;

but this would be somehow break retro compatibility?

+1, as this makes integrating with a package like simple schema more of a hassle

This won't be a retro-compatible change...
But since I don't think many people is using this, lets close an eye ;-)
v2 will be for something else...


Create the partition file if id doesn't exist

so that the caller doesn't have to care if it's the first time the partition is encrypted or not.
Signed-off-by: Dimitris Karakasilis<EMAIL_ADDRESS>

Looks good here!

To bump kcrypt and have it in kairos now:

Bump kcrypt version here: https://github.com/kairos-io/packages/blob/main/packages/system/kcrypt/definition.yaml#L3 (searches for a matching tag on the repo, version after + excluded)
Bump initrd versions https://github.com/kairos-io/packages/blob/63bb7de35ecc9ec89b08aa502901b07a8f23f6af/packages/initrd/collection.yaml#L4 and https://github.com/kairos-io/packages/blob/63bb7de35ecc9ec89b08aa502901b07a8f23f6af/packages/initrd/collection.yaml#L10
Once they get built, run https://github.com/kairos-io/kairos/actions/workflows/bump_repos.yml manually - it will automatically create a PRs to kairos-io/kairos to bump the repositories


Modify the test class to use the new configuration

Modify the test class to use the new configuration

/azp run java - spring - tests

/azp run java - spring - tests

/azp run java - spring - tests

Hi, @lu-cheng , IMU, merge latest master branch to your dev branch can solve your problem.

@lu-cheng , When you close a PR. it's better to add a comment. Like this: https://github.com/Azure/azure-sdk-for-java/pull/18191#issuecomment-748792891

Created a new PR: https://github.com/Azure/azure-sdk-for-java/pull/18317


Screenshots?

Got any screenshots?

check out http://avatarmanager.meteor.com/

Sweeet. A link in the README would be great!

I forgot about that. Thanks.
published


⚠ Bofrost.at has degraded performance

In 7b2530c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 991 ms

Resolved: Bofrost.at performance has improved in e971596 after 306 days, 22 hours, 29 minutes.


add angular as dependency to bower.json

I had to add angular as a dependency in the bower.json to help wiredep determine the order of injection in the index file of my project. Thought that it could be useful for others as well.

fixed in version 6.0.4


Improve performance of tokenization for seq2seq/translation

by reducing compilation time of regular expression

Can one of the admins verify this patch?

@mithrandir Please sign our CLA neither late, nor early, but precisely when you mean to.

Hi Daniel,
Actually I'm employee of Microsoft and I'm now checking if I'm ok with
signing that. It would be great to know if there was similar case before.
Thanks,
Jiin
On Wed, Sep 7, 2016 at 5:08 AM, Daniel W Mane<EMAIL_ADDRESS>wrote:

@mithrandir https://github.com/mithrandir Please sign our CLA neither
late, nor early, but precisely when you mean to.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4182#issuecomment-245073545,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN58eOWDADRSnrQ4F1xCbje68j_sJo6ks5qnchDgaJpZM4J0AYq
.

I believe that Microsoft is already covered under a Google CLA. You may need to switch the commit author email in the git log to your microsoft.com email address.

After reviewing internal policy, I decided to use my personal email instead
of @microsoft.com address because I did this not for my work. I'll sign
this when I come back to home.
Thanks,
Jiin
On Fri, Sep 9, 2016 at 3:43 AM, Daniel W Mane<EMAIL_ADDRESS>wrote:

I believe that Microsoft is already covered under a Google CLA. You may
need to switch the commit author email in the git log to your
microsoft.com email address.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4182#issuecomment-245697228,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN58UXIYvGVoMXuhKAACzbYvF3VV267ks5qoFdSgaJpZM4J0AYq
.

Ok, I signed it with<EMAIL_ADDRESS>Thanks,
Jiin
On Fri, Sep 9, 2016 at 11:15 AM, Park Ji-In<EMAIL_ADDRESS>wrote:

After reviewing internal policy, I decided to use my personal email
instead of @microsoft.com address because I did this not for my work.
I'll sign this when I come back to home.
Thanks,
Jiin
On Fri, Sep 9, 2016 at 3:43 AM, Daniel W Mane<EMAIL_ADDRESS>wrote:

I believe that Microsoft is already covered under a Google CLA. You may
need to switch the commit author email in the git log to your
microsoft.com email address.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/4182#issuecomment-245697228,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAN58UXIYvGVoMXuhKAACzbYvF3VV267ks5qoFdSgaJpZM4J0AYq
.

@lukaszkaiser PTAL

Looks good to me, when tests pass let's get this in. Thanks!

Sorry -- not meant to close. Adding vrv to merge.

Can one of the admins verify this patch?

Please merge.

@tensorflow-jenkins test this please


YARN-11701. [Federation] Enhance Federation Cache Clean Conditions.

Description of PR
JIRA: YARN-11701. [Federation] Enhance Federation Cache Clean Conditions.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 26s

trunk passed

+1 :green_heart:
compile
0m 24s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
compile
0m 20s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
checkstyle
0m 20s

trunk passed

+1 :green_heart:
mvnsite
0m 26s

trunk passed

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 56s

trunk passed

+1 :green_heart:
shadedclient
20m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 20s

the patch passed

+1 :green_heart:
compile
0m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javac
0m 19s

the patch passed

+1 :green_heart:
compile
0m 16s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
javac
0m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 10s

the patch passed

+1 :green_heart:
mvnsite
0m 20s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed with JDK Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

+1 :green_heart:
spotbugs
0m 53s

the patch passed

+1 :green_heart:
shadedclient
20m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 38s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 24s

The patch does not generate ASF License warnings.

83m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6889/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4ed937eae3e7 5.15.0-106-generic #116-Ubuntu SMP Wed Apr 17 09:17:56 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b774950b2e28df63d5433620665db1115b7559cc

Default Java
Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.23+9-post-Ubuntu-1ubuntu120.04.2 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_412-8u412-ga-1~20.04.1-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6889/1/testReport/

Max. process+thread count
611 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6889/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn Thank you for helping review the code! I will merge the code into the trunk branch to address the unit test failure issue.


fix res. Pinned 1.4.0 version of webpack-dev-middleware due to incompatability…

Resolves issue with new version of webpack-dev-middleware
TypeError: res.send is not a function
    at processRequest (/home/gbelken/Projects/clones/react-redux-starter-kit/node_modules/webpack-dev-middleware/middleware.js:189:8)
    at continueBecauseBundleAvailible (/home/gbelken/Projects/clones/react-redux-starter-kit/node_modules/webpack-dev-middleware/middleware.js:59:5)
    at Array.forEach (native)
    at /home/gbelken/Projects/clones/react-redux-starter-kit/node_modules/webpack-dev-middleware/middleware.js:58:8
    at nextTickCallbackWith0Args (node.js:456:9)
    at process._tickCallback (node.js:385:13)

Thank you for the fix!

I don't think this is necessary anymore with the 1.5.1 fix.


Implement feature that allows user to specify seed values for bootstrapped CIs  MET-274

John Halley Gotway created issue - 06/Jun/13 4:01 PM

This feature has been implemented some time ago. Users can provide <boot_random_seed> in XML or
input a value in UI


YouTube not downloading

Greetings. Ive tried downloading YouTube videos now on 2 different devices both report the same error...." Could not retrieve video url". Don't know why. One minute it was working fine thennn nothing.

FetchIt relies on the Cobalt API to access and download content from YouTube, Tumblr and other platforms. However, following the recent discontinuation of the Cobalt API, the app is no longer able to download videos from these platforms.
https://github.com/imputnet/cobalt/discussions/860


[Image Vulnerability] Vulnerabilities Found in "cassandra" Image (Example image)

Container Image Vulnerability Report
The container vulnerability scanning GitHub action has found 169 vulnerabilities of High and Critical severity with fixes available for the cassandra container image.
Image
ghcr.io/kanisterio/cassandra
Tested Version
v9.99.9-dev
Details
The detailed report can be found here.

Upstream images still have vulnerabilities

https://github.com/kanisterio/kanister/actions/runs/9233654378/job/25406350441

Need to check after https://github.com/kanisterio/kanister/pull/3042


Support updating setup.py through a pip freeze

I am looking for a tool which can do a pip freeze > setup.py since this might be very common when building something inside a Virtual Environment

+1 This would be very useful for packaging complete "end products" (e.g. web applications) with pinned dependencies. A dot in requirements.txt refers to a package from current directory. Maybe pip-compile could check whether requirements.txt contains one line with a dot and nothing else, and if it does, assume that this is an "end product" and write pinned dependencies to install_requires in setup.py?

I think this is not in the scope of pip-tools.  pip-tools takes care of dealing with requirements.in/requirements.txt to keep the set of concrete dependencies fresh and sane, and be able to reproduce a given virtualenv.
I'm not ready (as an active contributor to pip-tools) to endorse and then maintain such a feature.
Thank you for your suggestion!


[JAX] Use PocketFFT for FFTs on CPU instead of Eigen.

PocketFFT is the same FFT library used by NumPy (although we are using the C++ variant rather than the C variant.)
For the benchmark in https://github.com/google/jax/issues/2952 on my workstation:
Before:
907.3490574884647
max:     4.362646594533903e-08
mean:    6.237288307614869e-09
min:     0.0
numpy fft execution time [ms]:   37.088446617126465
jax fft execution time [ms]:     74.93342399597168

After:
907.3490574884647
max:     1.9057386696477137e-12
mean:    3.9326737908882566e-13
min:     0.0
numpy fft execution time [ms]:   37.756404876708984
jax fft execution time [ms]:     28.128278255462646

Submitted #4699 which is a clone of this PR (for reasons to do with version control.)


Bug in tutorial single item recommender system: can't instantiate abstract class RecEnv

In the tutorial single_item_recommender_system.ipynb when calling RecEnv(list(actions.values())[:100], model, history_length) I get
TypeError: Can't instantiate abstract class RecEnv with abstract method observation_space

Since RecEnv inherits from class Environment which has abstract method observation_space a solution is to override it in RecEnv with something like:
def observation_space(self):
    pass

In this tutorial, having an empty observation space is that wanted?

Thank you for reporting. This should be fixed now.

Since RecEnv inherits from class Environment which has abstract method observation_space a solution is to override it in RecEnv with something like:
def observation_space(self):
    pass

In this tutorial, having an empty observation space is that wanted?

In this example, the observations are the obtained reward, which has a range from 0 to 1, so the observation space is a Box from 0 to 1. This has been included in our latest commit. Thank you.


Update staging after creating new BUILD version in finishReleaseCycle

Fixing https://github.com/Expensify/Expensify/issues/157916
Following up on https://github.com/Expensify/Expensify.cash/pull/2329
What happened?: After creating the new BUILD version in finishReleaseCycle, we did not update the staging branch. Therefore, a staging deploy did not occur. That means that a new StagingDeployCash was created, including all the deferred PRs, but that those PRs were not actually deployed. That's no bueno, so this PR fixes it.

🚀 Deployed to production in version: 1.0.45-0🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging in version: 1.0.44-2🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


specify payment size with buy request

Looks like during the LDK 121 and liquidity library upgrade PR this got missed.  The payment size was not being set with the BuyRequest being issued and so later in the flow when the invoice params are surfaced via the LSPS event the payment_size_msat was being returned as None.  Mutiny was then bailing on the flow because it requires a payment size to be set.
This PR stores the payment amount in the "JitChannelInfo" struct that is used to store the fee information between the get_info and buy requests so that we can pass it along with the buy request.

closing in favor of #1050


Crashed: session queue EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000e2685270

Crashed: session queue
0  libobjc.A.dylib                0x1a4bdcd70 objc_msgSend + 16
1  Foundation                     0x1a6468140 NSKeyValueWillChangeWithPerThreadPendingNotifications.llvm.10547614101533924569 + 580
2  AVFoundation                   0x1abac5968 -[AVCaptureFigVideoDevice setVideoZoomFactor:] + 384
3  AVFoundation                   0x1abae4a80 -[AVCaptureSession _updateDeviceActiveFormatsAndActiveConnections] + 2716
4  AVFoundation                   0x1abae3850 -[AVCaptureSession _buildAndRunGraph] + 104
5  AVFoundation                   0x1abadd818 -[AVCaptureSession _commitConfiguration] + 120
6  AVFoundation                   0x1abade578 -[AVCaptureSession addInput:] + 724
7  QRCodeReader                   0x1053a045c $S12QRCodeReaderAAC26configureDefaultComponents33_B9DC3D797F478C8B92B825BD13CC6026LL25withCaptureDevicePositionySo09AVCaptureqR0V_tF (QRCodeReader.swift:151)
8  QRCodeReader                   0x1053a6730 partial apply for QRCodeReader (<compiler-generated>)
9  QRCodeReader                   0x1053a0798 $SIeg_IeyB_TR (<compiler-generated>)
10 libdispatch.dylib              0x1a542d6c8 _dispatch_call_block_and_release + 24
11 libdispatch.dylib              0x1a542e484 _dispatch_client_callout + 16
12 libdispatch.dylib              0x1a53d5be0 _dispatch_lane_serial_drain$VARIANT$mp + 592
13 libdispatch.dylib              0x1a53d6728 _dispatch_lane_invoke$VARIANT$mp + 432
14 libdispatch.dylib              0x1a53deec8 _dispatch_workloop_worker_thread + 600
15 libsystem_pthread.dylib        0x1a56100dc _pthread_wqthread + 312
16 libsystem_pthread.dylib        0x1a5612cec start_wqthread + 4

I got the crash from my ios app.
Here's my code:
lazy var readerVC: QRCodeReaderViewController = {
        let builder = QRCodeReaderViewControllerBuilder {
            $0.reader = QRCodeReader(metadataObjectTypes: [.qr], captureDevicePosition: .back)
        }
        builder.showSwitchCameraButton = false
        return QRCodeReaderViewController(builder: builder)
    }()

I only call this when pressing the button, the crash happened before this is called:
@IBAction func onScanClicked(_ sender: Any) {
        readerVC.delegate = self
        readerVC.modalPresentationStyle = .formSheet
        present(readerVC, animated: true, completion: nil)
    }

I'm seeing the same error from our users but haven't been able to reproduce the issue myself.
Looking at the code shouldn't the addInput line be wrapped in something like this?
if session.canAddInput(_frontDeviceInput) {
session.addInput(_frontDeviceInput)
}


[AutoPR automation/resource-manager] Adding patch API for Configurations

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2688

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/1411


Upgrade dependencies to show off latest PCF 1.11 Features

Upgrade to SpringBoot 1.5.4 to show off apps manager health integration
Upgrade to maven wrapper to use maven 3.5.0
Update the manifest to use at least 1GB for the application since
the app was crashing randomly with a metaspace out of memory
exceptions.

Thanks for the updates Adib!


Add color coding to projections, group by color and make list more co…

…mpact
After:

Before:

Great work! :) I added some notes with things that might clean it up a bit, but a lot of it is just nitpicking that you might find helpful.
The most important thing here is the inline-styling comment, but if you find it too difficult to implement, or not worth your time, feel free to merge it! :)

The notes were very helpful and allowed me to implement it correctly by myself, although I did some changes where it seemed good to do so. Very useful to learn by doing and then getting constructive feedback, so thanks a lot!


Pyrealsense2 : Can't able to build from source

| Camera Model                       | D455 |
| Operating System & Version | Ubuntu 22.04  |
| Language                            | python |
I'm trying to install Pyrealsense 2 by building it from source. However, during the build process, it keeps showing an error.
I have attached the error for your reference.build_error.txt

Hi @Muthukumar4796  Are you able to install the librealsense SDK without the pyrealsense2 wrapper?  If so then you could afterwards install the wrapper separately from packages instead of source code with the command pip install pyrealsense2
At the time of writing this, the pip install method of installing the wrapper supports Python 3.7 to 3.11 on computers / computing devices with x86 / x64 architecture (such as laptop and desktop PCs) and Python 3.7 to 3,9 on Arm architectured devices (such as Nvidia Jetson and Raspberry Pi).

My main goal is to fully build the pyrealsense2 library from source with CUDA on my Ubuntu 22.04 PC, and ensure that it only uses the GPU and not the CPU. If you have any ideas on how to accomplish this, please provide step-by-step instructions.

I have a laptop with a built-in Nvidia-1650 graphics card that supports CUDA version 12.2. It runs Ubuntu 22.04. However, you mentioned that Nvidia-equipped PCs not work for building pyrealsense2. Therefore, I am unable to build pyrealsense2 for my PC. Could you suggest an alternative method for me to do this?

PCs with an Nvidia GPU have difficulty enabling librealsense's CUDA support but CUDA is not required for pyrealsense2 and you can build the wrapper on PC without enabling it.

Yes but it consumes CPU, and I have another process that requires CPU power.Thats why I tried to build with GPU.

The librealsense SDK has an alternative to CUDA for offloading work onto the GPU called GLSL processing blocks, and it is 'vendor neutral' meaning that it can work with any GPU brand and not just Nvidia.  However, it is meant for use with C++ and so may not be helpful to you if your project requires Python.  Please see https://github.com/IntelRealSense/librealsense/pull/3654 for further details about GLSL.
There are not other options than CUDA and GLSL for offloading RealSense processing to the GPU, unfortunately.


Lua 5.3 bitwise operators

would be useful and better for performance than the bit32 library
& bitwise AND
| bitwise OR
~ bitwise exclusive OR
>> right shift
<< left shift
~ unary bitwise NOT

We do not plan to introduce bitwise operators in Luau.
We have some reasons described here below the table https://luau.org/compatibility#lua-53
In addition, operators are actually less performant than library methods in native code generation.


Is this project still active?

Just curious since last commit was in June 2022.

Seems like the dev is currently developing in private: https://twitter.com/firecubestudios/status/1612053922100682752
Private beta 17 January

Seems like the dev is currently developing in private: https://twitter.com/firecubestudios/status/1612053922100682752 Private beta 17 January

well that's not talking about fluent svelte, It's about a browser

@Tropix126 would really love to see this being continued, is there anything we can do to help.

For all those who love this project and want to use Fluent UI in their projects, remember that you can use the official library, it goes without saying that you can use any library in Svelte that uses Vanilla JS, HTML and CSS
Demo Here:
https://svelte.dev/repl/317e16c270b84d2dba580f8a19445c92?version=4.0.0
This demo is not my authority

This library looks more fluent than Microsoft's offical libary ngl

This library looks more fluent than Microsoft's offical libary ngl

That's the official library, LOL

I mean, fluent-svelte looks more fluent than Microsoft's offical library.


Missing kitchen-vagrant dependency

Can not use bundle exec kitchen list without this dependency.
Add kitchen-vagrant into Gemfile

I think we should actually remove the Gemfile, and encourage people use ChefDK instead.
https://github.com/chef-cookbooks/chef-server/issues/97

We already have this discussion on https://github.com/openstack/openstack-chef-repo, and even if it's a good practice to use ChefDk, not everybody use it nor wanna use it.
Personally, I like to use Bundler, Rbenv, and manage multiple chef version easily with this tools.
It's also easier to use travis with Gemfile, force contributions on some cookbook to use rubocop, etc..
Developers must have the choice of their weapons!

Redacting #97 - we need a gemfile so we play nice with travis.


Duplicated comments for hog composition

The same comment gets duplicated 3 times after refreshing the page.

If one of them is removed, removing the rest will fail.

To solve the problem above is to refresh the page. After that, both the duplicates and the original comment will disappear. However, if you readd the comment and refresh the page, the same thing happens all over again.
This happened for more than one submission. Here's the link to one of them:
https://ok-server.appspot.com/manage#/submission/final/4701740951666688

Thanks. Will investigate in the morning.

@albert12132 I'm unable to view the buggy submission because of a permissions error. Could you add me?

I added you our class on okpy.org.
On Mon, Jul 13, 2015 at 10:37 AM, Alvin Wan<EMAIL_ADDRESS>wrote:

@albert12132 https://github.com/albert12132 I'm unable to view the
buggy submission because of a permissions error. Could you add me?
—
Reply to this email directly or view it on GitHub
https://github.com/Cal-CS-61A-Staff/ok/issues/542#issuecomment-121001599
.

I've seen this issue a few times myself when commenting - not sure why it happens but it is a little weird.
I suspect it might be a front end issue.

Mhm. Saw the error online and got a chance to play with it; going to try and reproduce locally.

v2 is no longer being maintained.


Hide circe behind typedefs

Hide circe behind typedefs so that it may be easier to replace.
Also: add some basic tests for the relevant en-/decoders.

For some (unknown) reason, the github check won't run, but I tested this locally so will merge it anway.


fix: change mapping of /health and /ready to /api/v2/health and /api/v2/ready

Closes #19357
The Cloud version has exposed health and ready endpoint on /api/v2 path:

https://us-west-2-1.aws.cloud2.influxdata.com/api/v2/health
https://us-west-2-1.aws.cloud2.influxdata.com/api/v2/ready

but OSS version on root path - /.
The swagger.yml definition is used for both so We have to unify this.
Influx CLI
influx CLI doesn't work against cloud instances:
influx ping --host https://us-west-2-1.aws.cloud2.influxdata.com/

Error: Invalid character '<' looking for beginning of value.
See 'influx ping -h' for help

influx ping --host https://us-west-2-1.aws.cloud2.influxdata.com/ --token luvwJXTn...

Error: unknown flag: --token
See 'influx ping -h' for help

[x] CHANGELOG.md updated with a link to the PR (not the Issue)
[x] Well-formatted commit messages
[x] Rebased/mergeable
[x] Tests pass
[x] http/swagger.yml updated (if modified Go structs or API)
[x] Documentation updated or issue created (provide link to issue/pr)
[x] Signed CLA (if not already signed)

Please do not merge this to cloud. We need to be sure we do not expose internal health information to end-users.

This would be a breaking change for the influx CLI, and from the linked issues / my attempt to follow the linked URLs it looks like the /api/v2/health and /api/v2/ready endpoints in Cloud don't have the same behavior as /health and /ready in OSS. Closing this.


surveysim TestWeather Y2015 failure

surveysim tests are availing with
======================================================================
FAIL: test_dome_open_prob (surveysim.test.test_weather.TestWeather)
Dome should be (partially) open 26 nights in Dec 2019 when replaying Y2015
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/sbailey/desi/git/surveysim/py/surveysim/test/test_weather.py", line 22, in test_dome_open_prob
    self.assertEqual(n_nights, 31)
AssertionError: 59 != 31

----------------------------------------------------------------------

@dkirkby or @schlafly could you check on this Y2015 accounting?  Thanks.

I'll take this.  I extended the time baseline for tests by one month in desisurvey, but didn't expect that to influence the surveysim tests.

Thanks @schlafly

This should be addressed in https://github.com/desihub/surveysim/commit/4d9ceb398c3231e94b48aa980514d1acbef7a9a7.  It looks like the travis tests are still failing now, though.  This works for me running pytest on master at NERSC, so I'm a bit confused.  The complaint is that it can't "import yaml".  Was that somehow automatically pulled in as a dependency before, but dropped?  I don't really get it.

Thanks for the fix.  Travis tests pull in the latest compatible version of some libraries, so if one of our dependencies removed their use of yaml, it is possible that previously we were getting pyyaml as a side effect and now we have to get it explicitly.  I'll start a branch and PR to test that and close this.


DDPG without HER in Fetch?

Have anyone know which branch can easier to running ddpg without her in robotic env?
Thanks!

@huangjiancong1  I recommend not running DDPG until this is resolved https://github.com/openai/baselines/issues/938

Is this issue resolved?


Rawhide container image is far too big, it seems to be building on top of itself every day

As I discovered while trying to use it in openQA, it seems like the Rawhide minimal image (at least, maybe all the others too, but I didn't check those) seems to be far too big:
adamw@xps13a relval (main %)]$ podman image ls | grep fontq
ghcr.io/fedora-i18n/fontquery/fedora/minimal  rawhide               0019402f7363  30 hours ago   5.03 GB

This seems to be because it has a ton of layers, many of which look like each day the image is being built on top of the previous day's image, though having had a quick look through the github workflow I can't quite see why:
[adamw@xps13a relval (main %)]$ podman image inspect 0019402f7363
...
          "RootFS": {
               "Type": "layers",
               "Layers": [
                    "sha256:b3e0b1e92f2d902127023634125cefe9cecbdd98d7eeca7406c2a2a7e064887a",
                    "sha256:f76173259466d145842c5b04a91cd051ed9a29c3a991f85d5436bc1759769753",
                    "sha256:d83e441c6f7d2e110f0248f6f667a77370cae7ca01463405cacf7f014fb7227c",
                    "sha256:0d50eceafab4ade08437156d9ed8b24af054d2198fc2bbd0d4f8e00fcbc71b56",
                    "sha256:68271f8f1a5341581910fdeb6015cd53e96e8cc4aba951d2caef45aa515739db",
                    "sha256:6505e28a3c51c0f21b93f0ea4f5357670c6fa1a69435c080524b5402f40c975d",
                    "sha256:c3fd14dcb3d5a2b6edce15da2d19b4ff4fb271d634ad337be876117c3d4fc33e",
                    "sha256:0420065d7b00288f3bb379d56ba2bc484c4ba2efaf98eeb87f75a4e0a7ded691",
                    "sha256:cecc856b0790dfa491d8c74025eb7a1199c0e10886c774bca95a36fb8700f3f4",
                    "sha256:ac642b23e1370eaec481a80cae4c0a572681e63e3efc9d4cedbca31746171082",
                    "sha256:d2f0bbe2c2084c7773704f0f2bf4d4c9f687081e00e583f86c5710ac9a26734a",
                    "sha256:86aaf9b727f3ada94d7ade0368832daecbb022435b92465c21a76973896f9585",
                    "sha256:5af55508c73f236650c74c2206577c79d92e7b5caba411ef86a5862bfe1b6646",
                    "sha256:81a170eb6308559590a9370f95f2d62ce8fda221cce7b367d6e1d690e3403d48",
                    "sha256:133f3999c7ef42f6a8afe3f8380c0b134ef98dca381079bfb1c830949b473d1e",
                    "sha256:89448d3a6229eeeecc8ef65b8aad0c9909adfc31e77271f9ae513d94d493b604",
                    "sha256:c667884e92a48ac44acb85facc8e5cf8c319477212074f605dbbc99304899c7c",
                    "sha256:a043d993362e5c737e139d29fa89c52ea7ff1b9a07fcba4242f01f45f84b7bc1",
                    "sha256:1e5bfb5a3af854514f9539e0cbc37a7252cd0a908713bcf403f2f90adb395e79",
                    "sha256:098e4fb9325fc28f159fb0cc2ae71332ff591612cbaea4b6d127f631961be7a6",
                    "sha256:8aeacb49de8eb9e21c48a467636f444037bcb126eada97f69bf80d97b18a4afa",
                    "sha256:29e3d7ae39d955d85081b9246805176ca74b58aafe3bb875be2eca6b1dca5827",
                    "sha256:f12452f5fb2376929d227b4211c220465b9d165d7e8682f48a567120c9bda18f",
                    "sha256:fcb57a99eedbecf9d94eed493a9364a8eb8527db87099396d9b57dc8b19e4ebe",
                    "sha256:359f86eb6ed404d71345d4519b7272643162fbbe1cbf91d309f8d8d8a130fdf6",
                    "sha256:b74cd8505edb15244b3a97af2c1cf22e55448cb5f77db404239f67ff95b9a098"
               ]
          },
...
          "History": [
               {
                    "created": "2024-06-23T07:37:35.093132426Z",
                    "created_by": "KIWI 10.0.21",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>               },
               {
                    "created": "2024-06-24T06:04:31.652639116Z",
                    "created_by": "/bin/sh -c #(nop) ARG release=rawhide",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652656008Z",
                    "created_by": "/bin/sh -c #(nop) ARG release=rawhide setup=fontquery-setup.sh",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652665015Z",
                    "created_by": "/bin/sh -c #(nop) ARG dist= release=rawhide setup=fontquery-setup.sh",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652683149Z",
                    "created_by": "/bin/sh -c #(nop) ENV NAME=fontquery/fedora/base",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652703106Z",
                    "created_by": "/bin/sh -c #(nop) ENV RELEASE=${release}",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652724406Z",
                    "created_by": "/bin/sh -c #(nop) ENV DIST=${dist}",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.652822709Z",
                    "created_by": "/bin/sh -c #(nop) LABEL org.opencontainers.image.ref.name=\"$NAME\"       org.opencontainers.image.version=\"$RELEASE\"       org.opencontainers.image.source=https://github.com/fedora-i18n/fontquery       org.opencontainers.image.description=\"Base image based on Fedora for fontquery\"       org.opencontainers.image.licenses=\"MIT\"",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.758384454Z",
                    "created_by": "/bin/sh -c #(nop) COPY file:4633a6f8167492834054e835ba7f703ef408625ba576076485c9a6486a94a385 in /usr/local/bin/fontquery-setup.sh ",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:31.889703824Z",
                    "created_by": "/bin/sh -c #(nop) COPY multi:7b8216ef7e3ff1fe5894761d2d66678fa53bc3a021ba7f1801a9ce1da2ea9a25 in /tmp ",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:04:59.972815891Z",
                    "created_by": "|3 dist= release=rawhide setup=fontquery-setup.sh /bin/sh -c echo \"* Setup base image\"; /usr/local/bin/fontquery-setup.sh -t base",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM quay.io/fedora/fedora:rawhide"
               },
               {
                    "created": "2024-06-24T06:05:08.26207215Z",
                    "created_by": "/bin/sh -c #(nop) ARG release=rawhide",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:05:08.262098599Z",
                    "created_by": "/bin/sh -c #(nop) ENV RELEASE ${release}",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:05:08.262120039Z",
                    "created_by": "/bin/sh -c #(nop) LABEL description=\"Working environment for fontquery - minimal\"",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:05:20.985387151Z",
                    "created_by": "|1 release=rawhide /bin/sh -c echo \"* Installing default fonts packages\"; fontquery-setup.sh -t minimal",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:05:20.985426765Z",
                    "created_by": "/bin/sh -c #(nop) CMD [\"/usr/local/bin/fontquery-client\", \"--pattern\", \"minimal\"]",
                    "empty_layer": true
               },
               {
                    "created": "2024-06-24T06:05:21.63825381Z",
                    "created_by": "/bin/sh -c #(nop) ENTRYPOINT [\"/usr/local/bin/fontquery-client\", \"--pattern\", \"minimal\"]",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>               },
               {
                    "created": "2024-06-25T00:52:24.96424751Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-06-26T00:51:57.640684027Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-06-27T00:52:43.0834061Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-06-30T00:56:50.535142188Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-03T00:53:04.408176937Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-05T00:52:34.047112169Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-06T00:51:38.091876925Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-08T00:54:27.428943572Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-09T00:53:09.178772562Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-10T00:54:10.520575405Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-12T00:53:44.706108375Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-13T00:54:09.566439518Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-14T00:58:18.626171793Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-17T00:54:41.599737685Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-21T00:58:06.902184395Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-22T00:57:41.847144132Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-25T00:56:08.187571209Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-26T00:54:33.854019066Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-27T00:53:59.229425912Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-28T00:58:54.414571661Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-07-31T00:44:40.206527279Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-08-01T00:59:46.364948624Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               },
               {
                    "created": "2024-08-02T00:55:05.60680604Z",
                    "created_by": "/bin/sh",
                    "author": "Fedora Project Contributors<EMAIL_ADDRESS>                    "comment": "FROM ghcr.io/fedora-i18n/fontquery/fedora/minimal:rawhide"
               }
          ],

Hmm. Now I kinda see why this is happening. It seems the container build script and the github stuff both have 'build' and 'update' actions. The update action, as far as I can tell, basically does a dnf -y update in an instance of the existing container image, then pushes the updated image to the registry. It never does any kind of squashing or flattening, so it's just adding a new layer to the container every time it does this.
The update action seems to be run daily - https://github.com/fedora-i18n/fontquery/blob/main/.github/workflows/update.yml#L5 . The build action is only run on pushes to main - https://github.com/fedora-i18n/fontquery/blob/main/.github/workflows/build.yml . So as long as fontquery doesn't get a commit, the images will just add a layer and get bigger every day.
I'm not really sure why you bothered with this update mechanism, AIUI it's more normal to just rebuild containers from scratch each time you want to update them. Why not throw out the update mechanism and just run the build workflow daily, if you want to publish updated containers daily?
But if you want to keep the update mechanism, I think you need to get a flatten / squash operation in there somewhere to avoid this problem.

Thank you for pointing it out. I see the problem. let me update the update mechanism.


Shared settings between environments

Is there a way to define shared settings that will be used by several environments ?
If the paths in the exclude list are the same for all my environments, and if this list is quite long, it may be useful to define it one time for all environments.
Is there currently a way of doing this ?

You can create an anchor like this:
exclude:
  path: &path [".DS_Store", "aaaa", "bbbb", "node_modules", "cccc", "dddd", "package.json"]

dev:
    scheme: ftp
    host: ftp.xxxx.com
    port: 21
    user: xxx
    pass: xxx
    slots: 6
    path:
        local: /
        remote: public_html/xxxx
    exclude: *path

Anchor names must not contain the [, ], {, } and , characters.


Updates Cloud-KMS sample code to use V1 libraries.

Updates Cloud-KMS sample code to use V1 libraries.

Thanks!  Veneer is planned for Q2.  Are you able to merge this?

@lesv ^

Yep - didn't realize it was you a DPE ping'd me.


I am interested in using your game on my website. Could you add a license file like the MIT one in this pull request so I know how you want your software used?

Sure, hack away.  I'm glad you found it useful.  I'd like to see what you end up with if you feel like sharing.

I'll send out a pull request to add a link to your repo when its up.


don't let -wi override -w

Passing -w -wi will only turn on informational warnings.
Mixing -w and -wi happens e.g. through DFLAGS in dmd.conf.

One day, I wanted to enable all the possible warnings that dmd can give me, so I ran dmd to find these two switches:
  -wi            enable informational warnings```
So I added -w -wi to the command line, to get both normal warnings and informational warnings. For this pull request to be complete, I think an update to the help text would be appropriate, so you know that -w overrides -wi. Doesn't it also turn some warnings into errors? And on a related note: The Linux man page for dmd is still lacking the -wi switch completely. It could describe 'informational warnings' with an example maybe.

P.S. The man page does have -wi (my installation seems to be outdated), just remember to keep it in sync with any changes to dmd's help output.

It's somewhat confusing.
-w behaves like "-Wall -Werror"
-wi behaves like "-Wall -Wno-error"
It depends on the order of the two if warnings are treated as errors.


Start screen

How do i hide indent in startup screen ? I'm using alpha-nvim

You have to add
filetype_exclude = {"alpha"}

thank you , it worked!


Every chapter only has first page

Hi,
I tried to download this (book)[https://www.oreilly.com/library/view/akka-in-action/9781617291012/] today. It seems the download finished successfully and I can see the epub file generated. But when I opened it I can only see the first page in each chapter. Even I tried to download it again, still the same. Can someone please take a look? Thanks.

Duplicate of #290


[StubGen] RegisterInterface also for returned const interfaces

@HaseenaSainul can you check if with this pull request, your pull request can be closed (interface can now be const)


During build, warn if unsupported JS/TS language constructs are used

During SnarkyJS’ build, we could help guide developers by checking for unsupported language constructs  (e.g.  throw, conditionals, native ternaries) and warning developers. Likely using an abstract syntax tree to do this reliably.
Related: we want to set up matching ES Lint custom rules in the Snapp CLI's projec-ts, if possible, to warn developers as they wrote their app.

*write

Done https://www.npmjs.com/package/eslint-plugin-snarkyjs


Typo in [Strings and the backslashes], missing right parenthesis

In section Strings and the backslashes, for the explanations, 2nd point with one of the examples as follows

print(repr(r'wt\"f')
'wt\\"f'

I think the right parenthesis is missing here.  It should be
print(repr(r'wt\"f') )
'wt\\"f'
p.s.  I am not sure if others had already bring up this issue, I tried search over existing issues, but I don't find anything related, so i bring it up here.

Correct, nice catch, will fix this in next update, thanks @LeonDong1993 !

Thank you for your reply, I think I will just close this issue then ?

Let's leave it open :)

Hey @satwikkansal , could you explain why this issue is still open? The problem has been fixed already source code

oh okay, nice catch, closing it 👍


failed - Snapshot does not match reference.

Snapshots pass on local machine but fails on CI. The device is same on local machine and CI.
platform=iOS Simulator,name=iPhone 12,OS=latest
Error: Newly-taken snapshot does not match reference.

@Shahzaib31 I experiences something similar. When running them locally - did you run them via Xcode or xcodebuild
When running the tests

locally via xcodebuild (failing) ❌
running inside Xcode Product -> Test  (green) ✅
on the CI (GitHub Actions) with xcodebuilt (failing) ❌

There weren't always the same tests failing and not all, but quite some tests...

I use fastlane and it works like a charm

OS=latest

Is the OS different on your machine vs. CI? Can you check the logs to see?

Is this issue still open?

@Shahzaib31 I'm going to close this issue since it appears like you resolved things. Let us know if you're still having issues, though!


Fix incorrect autocorrect behavior for Layout/BlockAlignment

Contrary to the documentation, the autocorrect for either was set to block_of_line:

either (which is the default) : the end is allowed to be in either
location. The autocorrect will default to start_of_line.

So this PR corrects it to start_of_line.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice catch!


Generate apply for FO letters for applicant 2 only when they are not represented and without email

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-3243

Ticket was withdrawn. N/A.


Compatibility with React Native 0.73?

There is a dependency on this library that is not allowing me to use it. Any chance you could increase this to allow React Native 0.73 users to install?
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>

Hey @airowe peerDeps have been bumped to the latest available! Hope that this works for you 🙇🏻
"peerDependencies": {
    "react": "^18.2.0",
    "react-native": "^0.73.4"
  }

Thank you for using react-native-loading-dots 💚

Thanks @alexvcasillas! Would it be possible to support typescript as well?

Thanks @alexvcasillas! Would it be possible to support typescript as well?

Sure, we can add a .d.ts file to have types :)

Thanks @alexvcasillas! Would it be possible to support typescript as well?

Sure, we can add a .d.ts file to have types :)

Thanks @alexvcasillas!

Hey @airowe 👋🏻 Just wanted to let you know that v1.3.4 now includes a .d.ts file with type definitions for this library :)


ssl3_get_record:wrong version number, when connecting to sentinel via tls

Hey,
I have a docker swarm, which sets up redis sentinel, with 3 sentinels, 1 master and one slave.
I have now added tls (config files included).
Now I want to connect to the sentinel clusters via ioredis, but I keep receiving the following error in the master's logs:
"Error accepting a client connection: error:1408F10B:SSL routines:ssl3_get_record:wrong version number".
So there is obviously an ssl error occuring, but I don't know why.
The master and slave connect correctly (via tls), and the sentinels correctly connect to the master and slave, there are no errors in the logs.
But I cannot connect to the sentinel instances via tls.
I should also note, that I had no problems connecting with ioredis, when I hadn't enabled tls.
I'm just really confused, it could be that I misconfigured redis or sentinel, but as there is no issue with them connecting to each other, I assume that I don't use ioredis properly.
Moreover I actually am able to connect briefly ('connect' event fires), but immediately after that the 'error' event fires, suggesting that there is a problem with the key exchange.
Your help is highly appreciated.
Here is the relevant code:
const client = new redis({
    sentinels: [
        {
            host: 'redis-sentinel1',
            port: 26380,
        },
        {
            host: 'redis-sentinel2',
            port: 26380,
        },
        {
            host: 'redis-sentinel3',
            port: 26380,
        }
    ],
    name: "mymaster",
    password: redisPassword,
    enableTLSForSentinelMode: true,
    sentinelTLS: {
        ca: [caCert],
        key: tlsKey,
        cert: tlsCert,
        secureProtocol: 'TLSv1_2_method'
    },
}
)

redis.conf
daemonize no
masterauth %%REDIS_PASSWORD%%
requirepass %%REDIS_PASSWORD%%
replica-announce-ip %%SLAVE_ANNOUNCE_IP%%
tls-port 6379
port 0
tls-auth-clients yes
tls-ca-cert-file %%TLS_CA_CERT_FILE%%
tls-key-file %%TLS_KEY_FILE%%
tls-cert-file %%TLS_CERT_FILE%%
tls-replication yes
tls-protocols "TLSv1.2 TLSv1.3"

sentinel.conf
dir /tmp
sentinel monitor mymaster %%SENTINEL_MASTER_IP%% 6379 %%SENTINEL_QUORUM%%
sentinel down-after-milliseconds mymaster %%SENTINEL_DOWN_AFTER%%
sentinel parallel-syncs mymaster 1
sentinel failover-timeout mymaster %%SENTINEL_FAILOVER%%
sentinel auth-pass mymaster %%REDIS_PASSWORD%%
port 0
tls-auth-clients yes
tls-replication yes
tls-ca-cert-file %%TLS_CA_CERT_FILE%%
tls-key-file %%TLS_KEY_FILE%%
tls-cert-file %%TLS_CERT_FILE%%
tls-port 26380
tls-protocols "TLSv1.2 TLSv1.3"

I also faced the same problem.
Иut it was solved with the addition of the tls field (duplicate of sentinelTLS):
const sentinels = [
  { host: '<IP_ADDRESS>', port: 26380 },
  { host: '<IP_ADDRESS>', port: 26379 },
];

const tlsSettings = {
  ca: [fs.readFileSync('../../tls/ca.crt')],
  cert: fs.readFileSync('../../tls/client.crt'),
  key: fs.readFileSync('../../tls/client.key'),
  rejectUnauthorized: false,
};

const redisClient = new Redis({
  sentinels,
  password: '123123',
  sentinelPassword: '123123',
  name: 'my-master',
  role: 'master',
  tls: tlsSettings,
  sentinelTLS: tlsSettings,
  enableTLSForSentinelMode: true,
});

I have same configuration of redis.conf and sentinel.conf. node 12, ioredis 4.19.4
I think it's because of this: https://github.com/luin/ioredis/blob/c2f634fcc1ed25a47d368e96e432012db99efa34/lib/connectors/SentinelConnector/index.ts#L132

Bumping this because I'm using Heroku to create a throng'd process worker.js that uses Bull to process background jobs.
I've noticed that upgrading the heroku redis instance causes this same error.
The only fix is to totally delete the instance and starting from scratch.
Still experimenting.

Ended up being Heroku using self signed certs with v6 Redis

@ctrlaltdylan I'm also using Heroku Redis and receiving this error.  What should be done, if anything, to resolve it?

My solution is to optionally add a flag that will disable security checks for redis:
let options = {
  port: REDIS_PORT,
  host: REDIS_HOST,
  password: REDIS_PASSWORD,
};

if (process.env.REDIS_INSECURE_TLS) {
  options.tls = {
    rejectUnauthorized: false,
  };
}

Step 2: stop using Heroku.


Cannot access docs

If you want to discuss a new feature, please ignore/clear this form.
ScalaMock Version 3.5.0
Scala Version All
Runtime (JVM or JS)
Please describe the expected behavior of the issue
I can read the scaladocs
Please provide a description of what actually happens
I get an AccessDenied message:
AccessDeniedAccess DeniedE68B270552422E0AyCvZ3E+OV89ihBK0JzWiC5AWLEjMwNf8hrUCxp6p38MSH0eyjEVkBwx5nTdDcSR5CAY725vlOlI=
Reproducible Test Case
Go to this link: https://www.javadoc.io/doc/org.scalamock/scalamock_2.11/3.5.0

thanks, you are right. older versions seem to work, or choosing scalamock-core. Looks like an empty jar was generated for the docs.

changed the links to refer to the correct artefact


123

do you know how to use in the plugin

Hi,
The repository description has been updated to include more detailed installation information.
For a list of the FCPP algorithms included in the repository, see the launch files included here:
https://github.com/jynxmagic/FCPP-Survey/tree/master/test%2Ffull_coverage_path_planner

你好啊
存储库描述已经更新，以包括更详细的安装信息。
有关存储库中包含的FCPP算法列表，请参阅此处包含的启动文件: https://github.com/jynxmagic/FCPP-Survey/tree/master/test%2Ffull_coverage_path_planne

Does this mean that I only need to modify the global planner and yaml file of the movebase, but the car seems to be stuck and unable to complete path exploration? Have you tried it

Hey. Yes, it works by changing the global planner in the movebase package.
If you are using the ACO planner, it takes a while before it finds the optimal path.
ACO finds optimal, but it takes some time.
Don't use ACO with big maps.
For the default map, it takes ACO 56 seconds to find the optimal path.
The path is more optimal but takes a long time to find.
For big maps, spiral or zig-zag is better.
roslaunch full_coverage_path_planner test_spiral_fcpp.launch
roslaunch full_coverage_path_planner test_zigzag_fcpp.launch
You can change the map in the launch files (line 4):
<arg name="map" default="$(find full_coverage_path_planner)/maps/grid.yaml"/>
For a list of available maps, see https://github.com/jynxmagic/FCPP-Survey/tree/master/maps.

Hey. Yes, it works by changing the global planner in the movebase package.
If you are using the ACO planner, it takes a while before it finds the optimal path. ACO finds optimal, but it takes some time. Don't use ACO with big maps. For the default map, it takes ACO 56 seconds to find the optimal path. The path is more optimal but takes a long time to find.
For big maps, spiral or zig-zag is better. roslaunch full_coverage_path_planner test_spiral_fcpp.launch roslaunch full_coverage_path_planner test_zigzag_fcpp.launch
You can change the map in the launch files (line 4): <arg name="map" default="$(find full_coverage_path_planner)/maps/grid.yaml"/>
For a list of available maps, see https://github.com/jynxmagic/FCPP-Survey/tree/master/maps.

thanks。But I want to know if it can be used as a movebase plugin. I think this one looks like a movebaseflex plugin

Hey. Yes, it works by changing the global planner in the movebase package.
If you are using the ACO planner, it takes a while before it finds the optimal path. ACO finds optimal, but it takes some time. Don't use ACO with big maps. For the default map, it takes ACO 56 seconds to find the optimal path. The path is more optimal but takes a long time to find.
For big maps, spiral or zig-zag is better. roslaunch full_coverage_path_planner test_spiral_fcpp.launch roslaunch full_coverage_path_planner test_zigzag_fcpp.launch
You can change the map in the launch files (line 4): <arg name="map" default="$(find full_coverage_path_planner)/maps/grid.yaml"/>
For a list of available maps, see https://github.com/jynxmagic/FCPP-Survey/tree/master/maps.

I used it as a Movebase plugin, but the car has two target points during driving, causing it to move back and forth. How can I solve this problem

Hey,
I'm not sure how to port over to the move_base package.
My guess would be to do with the nav_msgs::Path object.
https://github.com/jynxmagic/FCPP-Survey/blob/master/src/full_coverage_path_planner.cpp
void FullCoveragePathPlanner::publishPlan(const std::vector<geometry_msgs::PoseStamped>& path)
{
  if (!initialized_)
  {
    ROS_ERROR("This planner has not been initialized yet, but it is being used, please call initialize() before use");
    return;
  }

  // create a message for the plan
  nav_msgs::Path gui_path;
  gui_path.poses.resize(path.size());

  if (!path.empty())
  {
    gui_path.header.frame_id = path[0].header.frame_id;
    gui_path.header.stamp = path[0].header.stamp;
  }

  // Extract the plan in world co-ordinates, we assume the path is all in the same frame
  for (unsigned int i = 0; i < path.size(); i++)
  {
    gui_path.poses[i] = path[i];
  }

  plan_pub_.publish(gui_path);
}

Or altering the .yaml file
    <!--Move base flex, using the full_coverage_path_planner-->
    <node pkg="mbf_costmap_nav" type="mbf_costmap_nav" respawn="false" name="move_base_flex" output="screen" required="true">
        <param name="tf_timeout" value="1.5"/>
        <rosparam file="$(find full_coverage_path_planner)/test/full_coverage_path_planner/param/aco_planner.yaml" command="load" />
        <rosparam file="$(find full_coverage_path_planner)/test/full_coverage_path_planner/param/local_costmap_params.yaml" command="load" />
        <param name="AntColonyOptimization/robot_radius" value="$(arg robot_radius)"/>
        <param name="AntColonyOptimization/tool_radius" value="$(arg tool_radius)"/>
        <param name="global_costmap/robot_radius" value="$(arg robot_radius)"/>
        <remap from="odom" to="/odom"/>
        <remap from="scan" to="/scan"/>

        <remap from="/move_base_flex/AntColonyOptimization/plan" to="/move_base/AntColonyOptimization/plan"/>
        <remap from="/move_base_flex/tracking_pid/interpolator" to="/move_base/TrackingPidLocalPlanner/interpolator"/>
    </node>

    <!-- Move Base backwards compatibility -->
    <node pkg="mbf_costmap_nav" type="move_base_legacy_relay.py" name="move_base" >
        <param name="base_global_planner" value="AntColonyOptimization" />
    </node>

so what should i do
原始邮件
发件人："Chris Carr"< @.*** >;
发件时间：2023/11/24 20:16
收件人："jynxmagic/FCPP-Survey"< @.*** >;
抄送人："1234564lll"< @.*** >;"Author"< @.*** >;
主题：Re: [jynxmagic/FCPP-Survey] 123 (Issue #4)
Hey,
I'm not sure how to port over to the move_base package.
My guess would be to do with the nav_msgs::Path object.
https://github.com/jynxmagic/FCPP-Survey/blob/master/src/full_coverage_path_planner.cpp
void FullCoveragePathPlanner::publishPlan(const std::vector<geometry_msgs::PoseStamped>& path) {   if (!initialized_)   {     ROS_ERROR("This planner has not been initialized yet, but it is being used, please call initialize() before use");     return;   }   // create a message for the plan   nav_msgs::Path gui_path;   gui_path.poses.resize(path.size());   if (!path.empty())   {     gui_path.header.frame_id = path[0].header.frame_id;     gui_path.header.stamp = path[0].header.stamp;   }   // Extract the plan in world co-ordinates, we assume the path is all in the same frame   for (unsigned int i = 0; i < path.size(); i++)   {     gui_path.poses[i] = path[i];   }   plan_pub_.publish(gui_path); }
Or altering the .yaml file
<!--Move base flex, using the full_coverage_path_planner-->     <node pkg="mbf_costmap_nav" type="mbf_costmap_nav" respawn="false" name="move_base_flex" output="screen" required="true">         <param name="tf_timeout" value="1.5"/>         <rosparam file="$(find full_coverage_path_planner)/test/full_coverage_path_planner/param/aco_planner.yaml" command="load" />         <rosparam file="$(find full_coverage_path_planner)/test/full_coverage_path_planner/param/local_costmap_params.yaml" command="load" />         <param name="AntColonyOptimization/robot_radius" value="$(arg robot_radius)"/>         <param name="AntColonyOptimization/tool_radius" value="$(arg tool_radius)"/>         <param name="global_costmap/robot_radius" value="$(arg robot_radius)"/>         <remap from="odom" to="/odom"/>         <remap from="scan" to="/scan"/>         <remap from="/move_base_flex/AntColonyOptimization/plan" to="/move_base/AntColonyOptimization/plan"/>         <remap from="/move_base_flex/tracking_pid/interpolator" to="/move_base/TrackingPidLocalPlanner/interpolator"/>     </node>     <!-- Move Base backwards compatibility -->     <node pkg="mbf_costmap_nav" type="move_base_legacy_relay.py" name="move_base" >         <param name="base_global_planner" value="AntColonyOptimization" />     </node>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


IPAM Address Support for Bloxone Ansible v2

Missing change logs and deprecation notices for this object .
Earlier this module was termed as ipv4_reservation !


add pre-node-gyp precompiled binaries?

While .cpp files are super handy on unixy platforms, getting lwip compiled on windows every time npm install runs is extremely complicated. In order to solve that problem, node-gyp can work together with pre-node-gyp, https://www.npmjs.com/package/node-pre-gyp, so that rather than compiling from source, the prehook first checks if there is a compiled binary already available, and if so, just deploys that instead.
Adding this to lwip would make the lives of everyone who has to work cross-platform a lot easier.

Indeed, that would be very useful.
Duplicate of #83

on a small note: reason I opened this was because it looks like node-gyp fails now that we're on node 4.x -- there's a whole bunch of "wrong syntax/template/etc..." errors building against the more recent v8 (on windows, at least. not tried unix flavours yet)

Are you using LWIP 0.0.8?

Yeah, lwip 0.0.8 with node 4.1.1 and npm 2.14.4. When installing on Windows 7 with VS2012, the result is the following (rather huge) pastbin: https://pastebin.mozilla.org/8849263

let me open this as new issue, actually, so it doesn't pollute a closed one.


Fields default to Blank String

Summary
Closes issue #977
Widget values default to blank string when value is null.

Test plan
Values for title, image and body within redux store get set to '' when value is null (date currently being set to current date)

Description for the changelog
Default values directly provided by each widget.

Deploy preview for cms-demo ready!
Built with commit ba1a709b5b4a2708ab11465886e2f35c7158e5d6
https://deploy-preview-1126--cms-demo.netlify.com

Deploy preview for netlify-cms-www ready!
Built with commit ba1a709b5b4a2708ab11465886e2f35c7158e5d6
https://deploy-preview-1126--netlify-cms-www.netlify.com

This approach works, but I'd like to see a less involved method for handling defaults since every widget will need to tackle this concern.
Right now, we're intentionally setting empty fields to null: https://github.com/netlify/netlify-cms/blob/b4b584682473924556a41cae10f64f085b0f432b/src/actions/entries.js#L261-L263
A null value "represents the intentional absence of any object value", while undefined represents a value that simply hasn't been set. The latter is a more accurate description of fields that have no default value (spec), so I propose we remove the default setting of null, allowing empty fields to return undefined instead.
In doing so, we gain the ability to use React's defaultProps to set empty values in widgets (they only work with undefined values).
Thoughts?

Shawn, just to clarify, you'd like me to set a default for 'value' using defaultProps for each of the editor widgets that has 'value' within its propTypes object.  Is this correct?  Also, should I default each to an empty string including objects that might ultimately be set to a date / boolean?

Each value will either be a number, string, boolean, array, object, or an array/object containing these types. Dates, for example, are stringified by their widget on change. Most widgets will use an empty string, with the exception of the boolean, object, and list widget. Perhaps there are others, those are the only ones that come to mind at the moment.

Thanks, I will make the adjustments and submit early this week!
-Mike

I've updated the PR to include 'defaultProps' for values located within the editor widget files.  I did not set the default for the date/time as the current set up will only set the current date / time if value is not equal to an empty string.  I also updated the createEmptyDraft function to set all values as undefined in place of null.

@tech4him1  - I've made the adjustment, setting it equal to - field.get('default').

Looking good @MichaelRomani!
The ultimate test is creating a new Kitchen Sink entry in the demo - currently failing: https://deploy-preview-1126--cms-demo.netlify.com/#/collections/kitchenSink

@MichaelRomani Maybe I missed it, but is there a reason a default isn't set for the ListControl?

@erquhart Is changing the default from null to undefined going to be a breaking change?

oops 😁

It would only be breaking for an installation if someone were intentionally checking for that null value in an external custom widget, in which case, the null value isn't a part of our published API, so it's not technically a breaking change. I also think the likelihood of real world problems resulting is very low, but I'm quite open to being told I'm wrong 😄.

ListControl - A defaultProp for value was already set in this file as:
value: List()
MarkdownPreview - I removed the defaultProps that had been added to this file.  I mistakenly thought it was receiving 'undefined' and needed to be set to ''.
Kitchen Sink Error -The error seems to have been coming from ObjectControl.  I think the issue is that the defaultProp should have been set to a Map Object as:
Map().
Locally, Kitchen Sink is now working.
Let me know if this makes sense and I'll push these changes up to this PR for review.

Sounds good, push it up!

@MichaelRomani Great, thanks!

Any thoughts from anyone about the breaking change concern?
cc/ @tech4him1

@erquhart On netlify/netlify-cms#1126, does the CMS internally treat null differently than undefined? Maybe by writing a key as empty vs not writing at all, or anything like that?
If not, I don't see a big concern with backwards compatibility.

Not that I'm aware of.


Support the Robots meta tag

http://www.robotstxt.org/meta.html
Not sure if Common Crawl already filters those pages, but we should do it on our side too anyway.
Some pointers:

Add a is_indexable method to Document
HTMLDocument.is_indexable() should test for the presence of noindex in self.head_metas["robots"]
Documents should be skipped accordingly in indexer.py
To support nofollow we could simply test for its presence in close_tag

We should also support the x-robots-tag http header:
https://developers.google.com/webmasters/control-crawl-index/docs/robots_meta_tag#using-the-robots-meta-tag

@jhildreth started a branch with some good work that should be merged:
https://github.com/commonsearch/cosr-back/compare/master...jhildreth:feature/robots-tag


Unable to Launch Dashboard on Mac Ventura (M1 Max)

Summary
I am unable to launch the microk8s dashboard
What Should Happen Instead?
The error I am seeing
% microk8s dashboard-proxy
Checking if Dashboard is running.
Cannot find the dashboard secret.
An unexpected error occurred.
sequence item 10: expected str instance, NoneType found
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/microk8s/2.3.4/libexec/lib/python3.11/site-packages/cli/microk8s.py", line 58, in cli
    dashboard_proxy()
  File "/opt/homebrew/Cellar/microk8s/2.3.4/libexec/lib/python3.11/site-packages/cli/microk8s.py", line 322, in dashboard_proxy
    output = instance.run(command, hide_output=True)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/microk8s/2.3.4/libexec/lib/python3.11/site-packages/vm_providers/_multipass/_multipass.py", line 54, in run
    return self._multipass_cmd.execute(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/microk8s/2.3.4/libexec/lib/python3.11/site-packages/vm_providers/_multipass/_multipass_command.py", line 232, in execute
    output = _run_output(cmd)
             ^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/microk8s/2.3.4/libexec/lib/python3.11/site-packages/vm_providers/_multipass/_multipass_command.py", line 38, in _run_output
    logger.debug("Running {}".format(" ".join(command)))
                                     ^^^^^^^^^^^^^^^^^
TypeError: sequence item 10: expected str instance, NoneType found
None

Reproduction Steps
1 Install and start microk8s
2. Enable Dahboard
3. Run microk8s dashboard-proxy

Hi @radhikapc, unfortunately I'm not able to reproduce the issue.
Which MicroK8s version are you running? Can you share the output of the following commands?
microk8s kubectl get node -o wide
microk8s kubectl get pod,secret -A -o wide

In any case, I believe you should be able to get around the issue by creating this secret:
microk8s kubectl apply -f - <<EOF
apiVersion: v1
kind: Secret
metadata:
  name: microk8s-dashboard-token
  namespace: kube-system
  annotations:
    kubernetes.io/service-account.name: "default"
type: kubernetes.io/service-account-token

Then rerun the microk8s dashboard-proxy command.
Finally, I have opened https://github.com/canonical/microk8s/pull/4299 which should help resolve this issue by using a simpler way to retrieve the token


Modification of vac container status color and Deprecation Date canno…

Modification of vac container status color and Deprecation Date cannot be displayed normally

Codecov Report

Merging #237 (c59a3cf) into main (4c6f9cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   58.03%   58.03%
=======================================
  Files          17       17
  Lines        1239     1239
=======================================
  Hits          719      719
  Misses        474      474
  Partials       46       46

Flag
Coverage Δ

unittests
58.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add a Gitter chat badge to README.md

bndw/pick now has a Chat Room on Gitter
@bndw has just created a chat room. You can visit it here: https://gitter.im/pick-pass/Lobby.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

@bndw Why don't we use our IRC channel on Freenode? :)
I haven't used Gitter before, does it offer some benefits?

@leonklingele Mainly interested in trying it out. I've recently used it while contributing to a project recently and found the out of box experience better than IRC, namely the history and notifications.

OK, let's give it a try.

better than IRC, namely the history and notifications

Most IRC apps come with a history and message notifier as well. Textual (Mac GUI app, IRC client) in combination with ZNC (IRC bouncer) works pretty awesome if you haven't tried this setup yet.

Naaaaah


Automated Package Upgrade

:tada: This PR is included in version 2.2.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


docs(fury-on-vms): add sections for custom registry

Add documentation for custom registry configuration in Fury on VMs

The quick start guides are supposed to be well, a quick start, and not cover advanced or special use-cases like the custom registry or all the possible features.
But, being that we are lacking a more complete documentation (some progress is being done in sighupio/fury-distribution#268). I think we can add this to the guide.
Thoughts @Rick-1990 ?

I agree with both statements. We can put this in the quickstart guide for now and move it somewhere else when we refactor the docs structure, maybe in a new "Advanced Use Cases" section (where we could also put the air-gapped configuration for example)


Support multiple configuration files

For now, all the configurations are put into the same file.
We should split it into data and model config, and when launching experiments, we can pass multiple configs and merge them into one

Seperate train and predict as well?

@YipengHu prediction will use the same config as train so we are only talking about train config i think

There are clinical cases, the prediction should have a different loader.

Regarding prediction using the same config as train: it is related to #56

@mathpluscode is it still relevant for the r1? close otherwise.

close this as it's already merged.


Build fix

r? @jamesgk

Let's also delete glyphAreaPen from this repo. The import in nototools/shape_diff.py also needs to be updated.

Updated.

Updated.