[BUG] Azure.ResourceManager.ApiManagement, ApiManagementServiceResource.GetApis() throws exception

Library name and version
Azure.ResourceManager.ApiManagement 1.1.0
Describe the bug
An exception is thrown when listing the apis in apim using ApiManagementServiceResource.GetApis() if any of the apis has an invalid URI for the property "termsOfService".
Exception detail:
at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions)
at System.Uri..ctor(String uriString)
at Azure.ResourceManager.ApiManagement.ApiData.DeserializeApiData(JsonElement element)
at Azure.ResourceManager.ApiManagement.ApiCollection.<>c__DisplayClass9_0.b__2(JsonElement e)
at Azure.Core.PageableHelpers.PageableImplementation1.d__15.MoveNext() at Azure.Core.PageableHelpers.PageableImplementation1.d__15.System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult(Int16 token)
at ...d__14.MoveNext()
Expected behavior
All apis should be listed regardless of what value the property termsOfService has for each api.
Actual behavior
An exception is thrown if any of the apis has an invalid URI for the property termsOfService, so not all apis will be listed.
Reproduction Steps
In our case, one of the apis had the property "termsOfService": "n/a", which is not a valid URI, and an exception is thrown.
ResourceIdentifier id = ApiManagementServiceResource.CreateResourceIdentifier(_subscriptionId, _resourceGroupName, _serviceName);
ClientSecretCredential credentials = new(_tenantId, _clientId, _clientSecret);

ArmClient client = new(credentials);
ApiManagementServiceResource apimService = await client.GetApiManagementServiceResource(id).GetAsync();

ApiCollection apiList = apimService.GetApis();

try
{
    foreach (var api in apiList)
    {
        try
        {
            Console.WriteLine(api.Id);
        }
        catch (Exception ex)
        {
            // Not catched here
            Console.WriteLine(ex.Message);
        }
    }
}
catch (Exception ex)
{
    // Catched here
    Console.WriteLine(ex.Message);
}

The bug is in function Azure.ResourceManager.ApiManagement.ApiData.DeserializeApiData, where there is no check if property0.Value is a valid URI:
termsOfServiceUri = new Uri(property0.Value.GetString());
Environment
Azure AppService .NET 8
Visual Studio 17.9.4

Hi @cokosharp , this issue has been fixed.
Thank you for your feedback.

Hi @melina5656, are there any plans when this fix gets released?

Hi @melina5656, are there any plans when this fix gets released?

Hi @schmallaria , Do you urgently need a fixed version now? We have other bugs that have not been fixed yet. If your plan is not very urgent, we will release it after fixing all the bugs.

Hi @melina5656 would be nice to have an updated version asap. We use this package within an Azure Function. This function would not be running until it's fixed.

Hi @melina5656 would be nice to have an updated version asap. We use this package within an Azure Function. This function would not be running until it's fixed.

Hi @schmallaria , we will release it as soon as possible.

@melina5656, awesome. Thank you!

@melina5656, awesome. Thank you!

Hi @schmallaria, the new version has been released, you can try using it.


Add Node#isConnected and Node#getRootNode

Node#getRootNode
Node#isConnected

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: zaclummys sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Small grammar fix

Evaluate how FAIR is a resource
becomes
Evaluate how FAIR a resource is.
This can also be fixed in GitHub the repository description - this isn't editable via PR

Hi @cthoyt , thanks a lot for the pull request, I never noticed this grammar mistake
I'll merge it, but for your information this repository is not really used anymore, it was just a frontend to an evaluation service we don't host anymore
But the code of this repository has been reused to build the frontend for our FAIR evaluation service at https://fair-enough.semanticscience.org (https://github.com/MaastrichtU-IDS/fair-enough).
And the grammar error was also present there :) so I fixed it on the main branch and it will be fixed the next time I update the deployment


Desktop client: unread channels are bad highlighted

Please improve highlight of channels with unread messages. Bold font/color/number/...
#general has unread messages but looks almost the same as channels without unread messages.

Look at Slack client for comparison:

Thanks for the report @tuxmartin but you have to open this issue on the main project https://github.com/RocketChat/Rocket.Chat as this is an in-app design, and cannot be changed on the Electron wrapper app level.


CRASH

Steps to reproduce
App seems to crash when adding to library after extended period of time or crashes when restoring the library after an extended period of time.  Though I'm no doctor and thus have no idea why it actually occurs. So my steps to reproduce this might not actually work.

I open the app to browse
Save files for a period of time
Eventually one is met with a crash log
The same happens again if I go to restore the app via backup
The time of length it takes before this crash occurs is around 10-20m

Expected behavior
I cannot say for sure the things I am doing in the app are why this crash happens.
Actual behavior
This happens when I am doing basic things. But my library is quite enormous. This could be the reason why but I don't know.
Crash logs

2023-03-09-release.log
Tachiyomi version
1.9.0
Android version
Android 13
Device
Z Fold 4
Other details
My apologies if my steps are not reasonable. There just isn't much happening when this does occur. I hope the logs can provide some clarity.
Acknowledgements

[X] This is a TachiyomiSY specific issue that does not happen in Tachiyomi Preview.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.9.0.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

I forgot to add that this was running on a work profile made on android 13. So that might have a lot to do with why this occurred. Today I ran the app on the main profile for the device and it is seemingly running with no error; I will report back if this changes.

Duplicate of #812


Pool building freezes when connections drop during initial setup

Hi!
I am using r2d2 0.8.10 and noticed, that my service gets stuck on startup consistently under certain conditions: When the database becomes available, while r2d2 is already trying to connect.
The problem is, that in the initial startup phase, all connections are reset until postgresql is then fully start up.
During the build of the pool, the builder waits until the specified amount of connections is reached. However, it only starts connecting the specified amount of connections, so if one of those is dropped during the waiting time, the builder infinitely waits.
I hope this was understandable and thank you!
PS:
As a workaround, it seems to work to lower the connection_timeout, it somehow makes it way less likely to appear.

The pool will retry after failed connection attemps: https://github.com/sfackler/r2d2/blob/master/src/lib.rs#L272-L278.
Lowering the connection timeout will increase the rate at which those retries will be made.

Ah I see, then the freeze might stem from another reason, but it certainly freezes. It normally logs reconnection attempts, but there is no output for like 5 minutes, even though the connection timeout is 30 seconds.
With 5 seconds it somehow errors, maybe the condition is just more difficult to occur.

I don't think I can see how it's possible for initialization to take longer than the connection timeout. A self contained example of your issue would be helpful.

Hmm, I am not able to reproduce it in the setup I expected it to happen. It seems to maybe not be related to the pool start up even, so it might be a diesel or my own issue, so closing this for now! Thank you for the quick response and sorry for any inconvenience.


How many epochs to get EN-FR SOTA result in "Scaling NMT" paper?

#233 provided a training log of 38 epochs. How many epochs were actually trained to get the EN-FR result reported in Table 2 of "Scaling NMT" paper (43.2 BLEU in 512 min), and how many updates were performed? I have a rough estimate by myself of ~100 epochs ~100k updates. I think it is quite long. Am I correct?
p.s. It would be great of you could share the complete training log.

Da Xiao

The log in #233 is actually the full training log (for one seed): https://github.com/pytorch/fairseq/issues/233#issuecomment-408885881
If you look at the bottom of that log, you can see that we trained for 80k updates, which took 30878
seconds ~= 515 minutes.

I have a rough estimate by myself of ~100 epochs ~100k updates

This is using what batch size?

5120 * 8 * 16 = 655k
from last row in Table 1, if 402k batch size is used, updates in 512 min would be 9.7k * 512 / 32 = 155.2k
For 655k batch size, with the assumption that tkn/sec remains almost the same, I estimate updates to be 155.2k * 402k / 655k = 95k

Sorry, I'm not sure I understand your logic. If you look at the training log:

max-tokens is 5120 and the effective batch size (wpb) is 617k
the average words-per-second (wps) varies per epoch, with a high of around 1.7M and a low of around 1.6M
in 515 minutes we do 80000 updates (this includes validation and saving checkpoints, which is excluded from the timings in Table 1). This gives an average number of words per second of: (80000 updates * 617k words-per-update)/(515*60 seconds) = 1.6M words-per-second

I see. 512 minutes includes validation and saving checkpoints, that may be the reason why the wps is lower than reported in Table 1. Thanks!


table version.

Apologizes for the question, but why is table locked to a specific version while most of the other dependencies are not?  It is not a big deal, but it is preventing a clean dedupe with eslint.

Based on blame, this dependency seems to be super super old.
I don't think there's a good reason for this -- want to send a PR to update it?

I'd be honored.  Is #462 okay?


Add PostalCode scalar

Add PostalCode scalar type to Hotchocolate.Types.Scalars

https://github.com/ChilliCream/hotchocolate/pull/3046

Address #2927

Awesome!


ADLS Gen2 API Implementation (#8280)

ADLS Gen2 API Implementation
(the namespace will be changed to azure.storage.filedatalake later)

Can one of the admins verify this patch?


Persona Pawel: Add simulation for color profiles

Currently, the instructions for Pawel suggest activating the Midnight Lizard extension for adjusting colors.
Such functionality should be part of the extension so there is no need to install another one.

This is deprioritized and won't be in scope for now. Specialized extensions will handle this better.


confused about the inference process

I'm not quite understanding the inference process after the prefix, as the inference process is not clearly described in the paper.
If the prefix token found is not the beginning of the sentence (BOS) token, wouldn't placing it at the beginning affect the inference results? Also, after the prefix process, should the corresponding input tokens exclude the prefix token?
thanks.

The only difference between PrefixQuant and the original inference is that there are some prefixed kv cache, we do not need to exclude the prefix token from the input sequence.
Place [BOS] in the beginning do not affect the inference results, because all of the inference start with [BOS] originally.

of course prefix bos token will not affect the result, if you just inference with the second token as the first instead.
But as i said, what if the found outlier prefix token is not bos? In your paper, for llama2-7b, you prefixed ".\n[BOS]", how to inference with these 3 prefixed tokens and not affect the results? in this case, you can't simply begin inference with the second token.
And there maybe other "." or "\n" in the input sequence, this may also generate outliers in the activations, how to deal with this?

And there maybe other "." or "\n" in the input sequence, this may also generate outliers in the activations, how to deal with this?
The number of outlier tokens in each input sequence is fixed, for example, 2-3 for Llama-2-7B. Therefore, if we set prefixed outlier tokens in KV cache, there will be no new outlier tokens.

in this case, you can't simply begin inference with the second token.
As shown in Table 1 in paper, we just set [BOS] as the last prefixed tokens for each model. Additionally, the target of prefixed tokens is smoothing the intermediate distribution, and almost have no impact on the final outputs due to low semantic.


Fix minor typos

Thank you for this repository - it really made my day.
I found a few typos in the notebook and wanted to correct them.

Hi, I am glad that you like the repository, and thanks for the typos corrections:)


[feature] #3598: Permission token analysis (WASM side)

Description

Added new trait AssociatedConstant<T> into iroha_data_model. Useful for Token derive
Updated Token trait and derive
Updated iroha_validator::entrypoint attribute macro
Implemented new entrypoints in all validators (default and tests)
Remove tokens from Kagami
Uncomment code on Iroha side
Added test

Linked issue

Closes #3598

Benefits
No more duplication of PermissionTokenDefinitions which currently should be the same as the ones defined in the validator

Checklist

[x] I've read CONTRIBUTING.md
[x] I've used the standard signed-off commit format (or will squash just before merging)
[x] All applicable CI checks pass (or I promised to make them pass later)
[x] (optional) I've written unit (not unit but integration) tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

@Arjentix why do we need entrypoint function to access permission tokens? Can't we access const array defined inside wasm blob or something like this?

why do we need entrypoint function to access permission tokens? Can't we access const array defined inside wasm blob or something like this

@Erigara, cool idea, but you've seen validator_with_custom_token. Currently I have no idea how to modify default array and keep it constant in the same time


update bootstrap version links

https://github.com/kubeflow/website/issues/3060
/assign @Bobgy

/assign @zijianjoy

/assign @shannonbradshaw

Looks like we're using bootstrap 4.6.
/lgtm

/approve


Send metadata in messages encoded with capnproto

Changes the message format from raw data bytes to a higher-level Message struct serialized with capnproto. In addition to the raw data, which is sent as a byte array as before, the Message struct features metadata field. This metadata field can be used to pass open telemetry contexts, deadlines, etc.
Roughly based on #72.

Thanks Philipp for taking this PR that I did not find time to do.
Just for clarification, the middle layer abstraction(MLA) is going to be composed of A) The communication layer and B) The current message library that enables metadata. With those two libraries separate so that, the communication layer entirely focus on communication and the message library on de/serialization. Am I getting this right?

Yes. The communcation layer crate is independent of dora and just provides a way to send byte arrays to subscribers. The message library implements the dora-specific message format and provides functions for (de)serilization. The dora node plugs them together and adds some higher-level logic (e.g. input streams with stop message handling).


Search filters: tax, expense type and tag

Details

This PR adds Expense Type, tax and Tag filters to Search feature. I decided to put these three filters together because they share the same concept and use the same main component.
There are some files changed that don't belong to Search feature, but it's because I decided to make a small refactor of PolicyTagList, while implementing Tag filter(previous PolicyTagList really confused me).
I refactored Currency filter and Category filter to reuse common component.
I also refactored Search Pages to not use pointless <FullPageNotFoundView shouldShow={false}>
Fixed Issues

$ https://github.com/Expensify/App/issues/46041
$ https://github.com/Expensify/App/issues/46037
$ https://github.com/Expensify/App/issues/46040
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I'll record videos tomorrow, but the code is ready for C+ review

Reassigning C+ as per https://expensify.slack.com/archives/C02NK2DQWUX/p1723051651463889

fixed your comments @rayane-djouah, can you continue reviewing? We still have a problem that Carlos stated in this comment and I'll address it ASAP.
I also haven't solved Search header looking like this(id instead of name)

but I think this should be addressed in another PR because this is a bigger problem that's also touching Card filters, keyword filters and From - To filters and would need to be a major refactor. @Kicu suggested solution that here

@SzymczakJ is ooo today, so we'll have to wait until monday.

We still have comments to address and lint is failing

@rayane-djouah fixed comments and bugs that you mentioned. I'm recording videos at the moment.

Sorry for missing that, I've addressed that comment @rayane-djouah

Damn I fixed this but forgot to push it. Sorry for that blooper 😅

I think https://github.com/Expensify/App/pull/46736#issuecomment-2284504935 is something we can put on the back burner for now. It's a bit of an edge case. I agree we can tackle the ID shown in the header in a follow up.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@luacmartins Do we need to QA anything here?

@mvtglobally not at this time.

FYI I believe this was deployed to prod yesterday, from this checklist - #47356


load all many to many join columns

the $joinColumnElement variable is created inside the foreach loop, and used only after it finishes, causing only the last join column to be loaded.

@fabiocarneiro the issue fix seems valid, but we really do need a test for this sort of bug.

@Ocramius I'm not sure i have plans to work on that, this is legacy code and i'm not even using it (And i'm not sure that there is anybody using it, since IMHO this is a critical bug and i'm impressed nobody reported before). I just found this because i'm writing another driver and I got some code from YamlDriver.
I know the importance of the tests there, but this method violates SRP so much that i'm afraid it will be very hard to test. I'm not trying to rude, but i don't know how else i could write this. Feel free to write the test yourself, merge or even close the PR if you prefer to leave as is.

Nobody is expecting a unit test, but an integration at test is needed as a minimum, otherwise it's just going to stay in the limbo here.

@Ocramius i'll think about that, but i don't promise i'll do it.
If you can compare that with this same logic in XmlDriver, you'll see the code runs inside the foreach loop.
https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php#L517-L523

It seems that this issue is already fixed on master, via commit 96687e04a66b7812f99898425cb3c79266b2bd0c.

Closing as duplicate.

Linking #1540


refactor: encapsulate pooling helpers and state modification in tests

Description
What is changing?

Move the various variables that support the pooling to an object for code organization
Use before/after hooks to ensure state is reset even when tests fail
Move pool and offset to WeakMap style private variables

Is there new documentation needed for these changes?
No
What is the motivation for this change?
See https://github.com/mongodb/js-bson/pull/707
Double check the following

[ ] Ran npm run check:lint script
[ ] Self-review completed using the steps outlined here
[ ] PR title follows the correct format: type(NODE-xxxx)[!]: description

Example: feat(NODE-1234)!: rewriting everything in coffeescript

[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

@nbbeeken I've rebased SeanReece:buffer-pool against main. I think you may also have to rebase/merge main and we can merge this in 👍

test
measurement
main
ObjectId pool 1000
Percent Change

singleBench
megabytes_per_second
18.83159911
16.7602144
-11.640%

multiBench
megabytes_per_second
160.8840654
148.3919854
-8.078%

parallelBench
megabytes_per_second
331.1638301
275.2237984
-18.450%

readBench
megabytes_per_second
321.7084202
274.2944344
-15.911%

writeBench
megabytes_per_second
139.2066326
125.3788738
-10.452%

driverBench
megabytes_per_second
230.4575264
199.8366541
-14.233%

ldjsonMultiFileUpload
megabytes_per_second
43.81457333
39.25755288
-10.971%

ldjsonMultiFileExport
megabytes_per_second
29.0683101
24.99832947
-15.055%

gridfsMultiFileUpload
megabytes_per_second
426.6074013
372.1347064
-13.640%

gridfsMultiFileDownload
megabytes_per_second
825.1650355
664.504605
-21.570%

returnDocument
megabytes_per_second
8187.165751
7616.915429
-7.216%

ping
megabytes_per_second
0.1129724661
0.1117610689
-1.078%

runCommand
megabytes_per_second
0.0827125336
0.0822814054
-0.523%

findOne
megabytes_per_second
4.993603288
5.046535575
1.054%

smallDocInsertOne
megabytes_per_second
1.203603759
1.173723034
-2.514%

largeDocInsertOne
megabytes_per_second
50.29759027
44.0603846
-13.220%

findManyAndEmptyCursor
megabytes_per_second
46.10949174
51.28812546
10.634%

smallDocBulkInsert
megabytes_per_second
32.91579311
28.33842022
-14.945%

largeDocBulkInsert
megabytes_per_second
32.66216984
30.68003353
-6.259%

gridFsUpload
megabytes_per_second
386.9452967
362.0072963
-6.659%

gridFsDownload
megabytes_per_second
703.2056602
625.6345767
-11.675%

findManyAndToArray
megabytes_per_second
42.89678305
44.38073259
3.401%

aggregateAMillionDocumentsAndToArray
megabytes_per_second
9.389312926
9.353244208
-0.385%

aggregateAMillionTweetsAndToArray
megabytes_per_second
32.94801597
35.45345392
7.326%

Maybe the WeakMap cost is too high for something as "main path" as every OID (as opposed to just the hex cache case we recently merged)
I'm going to switch back to TS private with a default of 1 and we can measure the perf of that and changing it to 1000

I moved a bit quickly in the last post, "returnDocument" is a no-op test that we're supposed to normalize against to remove variation in the runtime's speed. In this screenshot, the percent differences are calculated by normalizing against the "returnDocument" result at the top of each column.
Pooling is certainly a win but I think we need to hold off on the WeakMap method of making it private and enabled by default in this major version. Our next major is not in a distant future so we may be able to apply this change with real private properties sooner than later.

@nbbeeken Sorry for the delay, things got busy around the holidays :)
I'm seeing similar performance regressions in my local benchmarks as well. I'm ok with us waiting for the next major version so we can use real private properties. Any idea when we can start working on v7? 😄


Disallow type import exceptions in .eslintrc

This PR cleans up our cross-package dependency graph even more by removing our exceptiosn for type imports
Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

Note that it might be easier to review these commits https://github.com/cursorless-dev/cursorless/pull/1280/files/789e19a25319015e164663de1a104cbdb7899f71..4385fdcbd481cd08f38f37b60c5e044f39cae28c, as the first two commits just touch a bunch of .eslintrc.json files


Survey Issue

Hello,
Thank you for this modification. There appears to be an issue with this mod, it doesn't exactly survey they area. It reveals the map, but the markers associated with revealing the map are not revealed in correlation to the survey range.
(i.e. I have my survey range set to 2.5 but it only draws the map at 2.5x the default, the icons associated with the range do not appear within the 2.5x range but the default range)
Thank you still,
I'm not sure if this is still being worked on, I thought I'd bring it up.

Hey
This mod was created on two old (1.56) mods and they where ported as-is - by looks orignal one did the same.
Will try to see if I can work around this in any way.

Hey
This mod was created on two old (1.56) mods and they where ported as-is - by looks orignal one did the same.
Will try to see if I can work around this in any way.


Missing LACNIC VRPs?

Hi there, we've set up a few Routinator instances on our VMs and they observed a drop of Lacnic VRPs (to zero) at around 17:00 UTC, Mar 24. Sample status and logs:
mar24-status.txt
mar-24.log
I couldn't find anything special from the logs except a huge diff (Diff with 9 announced and 12033 withdrawn).
This is not the first time we observed such drops. Is there any recommended approach to detect and handle such abnormal behaviors? Or some indicators that the current cache is not complete?
Thanks!

The interesting lines are:
Mar 24 17:40:52 routinator-west-01 routinator[918]: rsyncing from rsync://repository.lacnic.net/rpki/.
Mar 24 17:41:14 routinator-west-01 routinator[918]: rsync://repository.lacnic.net/rpki: successfully completed.
Mar 24 17:41:32 routinator-west-01 routinator[918]: RRDP hash mismatch in local file rsync://repository.lacnic.net/rpki/lacnic/f4bc5d7e-ea3a-4ab3-a8a5-5903eb4f1726/aa536e2112fb6fbd4fd90b644c6fd66acba797ea.crl.
Mar 24 17:52:19 routinator-west-01 routinator[918]: rsync://repository.lacnic.net/rpki/lacnic/48f083bb-f603-4893-9990-0284c04ceb85/fd25c9bb7e5cac7419fa9193770f64a6edf20c19.cer: file has wrong manifest hash.
Mar 24 17:52:19 routinator-west-01 routinator[918]: CA for rsync://repository.lacnic.net/rpki/lacnic/48f083bb-f603-4893-9990-0284c04ceb85/ rejected, resources marked as unsafe:
Mar 24 17:52:19 routinator-west-01 routinator[918]:    <IP_ADDRESS>/0
Mar 24 17:52:19 routinator-west-01 routinator[918]:    ::/0
Mar 24 17:52:19 routinator-west-01 routinator[918]:    AS0-AS4294967295

My interpretation is that the hash of one of the objects on the manifest was wrong and that leads to a manifest being rejected.
I did see the same dip for the RIPE validator which also uses RRDP. I did not see the same dip with rpki-client (which does not update as frequently due to it's usage of rsync).

Hmmm, but isn't RRDP hash mismatch in local file showing up in pretty much every round of validation? In other words, is there any way to know this hash mismatch is abnormal, while other hash mismatches are acceptable?

That’s not the line causing the issue – that just means Routinator will use a fresh snapshot instead. ‘File has wrong manifest hash’ means that the file published differs from the one referenced on the manifest which causes the entire CA to be rejected.
The upcoming 0.9 release of Routinator will fall back to using the last known good state of the CA if it is still valid and be more robust in this case (at the price of using significantly more disk space). It looks like it also fixes the ‘mismatch in local file’ issue.


⚠ API - Lens has degraded performance

In d06e403, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 729 ms

Resolved: API - Lens performance has improved in ce29af2 after 8 minutes.


Player Height Bugging

Hey guys!
I really like your player, though I'm having an issue on our platform with it:

The player height should be 100% height, the parent div is set to 100%.

Once I play a song which has been already played, the player behaves as it's supposed to do.

Do you have a live example of this somewhere? We're going to be reworking our player soon so I hope to add this to the to-do list.


CORTX-32355 Server Pod takes more than 10 minutes to start when started concurrently with data pod

Problem: rgw admin util fails with timeout when started before motr ios mkfs is done

When both data and server pods are started at once, mkfs of ioservice processes
done in init contianer of data pods is not yet complete, but in init container of
RGW server pods rgw admin util try to create index and user account in it.
This causes failures of the utility as mkfs and m0d shares the same endpoint.

Solution:
Make sure that mkfs done for all isoervice is checked in init phase of hare
in RGW server init containers as well. This is a one time activity per deployment.

@madhavemuri  Request you to link the PR with JIRA and add appropriate commit message. Also, please update your branch with latest main.

NAME                             READY   STATUS    RESTARTS       AGE
cortx-consul-client-dfxg4        1/1     Running   0              2m14s
cortx-consul-server-0            1/1     Running   0              2m14s
cortx-control-76d64b9ccc-lpg9n   1/1     Running   0              2m14s
cortx-data-g0-0                  3/3     Running   0              2m13s
cortx-data-g1-0                  3/3     Running   0              2m14s
cortx-ha-ccb69c8b7-6vx6k         3/3     Running   0              2m14s
cortx-kafka-0                    1/1     Running   1 (115s ago)   2m14s
cortx-server-0                   2/2     Running   0              2m14s
cortx-server-1                   2/2     Running   0              2m14s
cortx-zookeeper-0                1/1     Running   0              2m14s
[root@ssc-vm-g4-rhev4-1532 k8_cortx_cloud]#```

Tested locally deployment completed within 2 mins.

@madhavemuri Request you to link the PR with JIRA and add appropriate commit message. Also, please update your branch with latest main.

Done.

@madhavemuri I think Jira number is still not there in commit message.
Can you please check.

@SwapnilGaonkar7, please ignore. I deleted the comment.

retest this please

@madhavemuri  1N / 3N deployment seems to be failing for this. cc @mssawant

There are 2 commits, there needs to be only 1


chore: update golangci-lint

Is not being handle renovate?

Not currently, we would need to see if we can design a regex manager, easy if we breakout the version similar to dev-tools.


Write the "Match Basics" concept

Official docs:
https://book.cairo-lang.org/ch06-02-the-match-control-flow-construct.html

Exercism Concepts docs:
https://exercism.org/docs/building/tracks/concepts
Use Rust's "Match Basic" concept as inspiration for format:
https://github.com/exercism/rust/blob/main/concepts/match-basics/about.md

Let's me take this.


Get errot

<template>

Welcome to Accounting!

</template>

Get error
While building for web.browser:
   imports/modules/acc/client/pages/Home.vue:20: [vue-component] Error while compiling css modules in tag


BokehDeprecationWarnings with Bokeh v1.4.0

The latest release of the Bokeh package has deprecated the legend keyword, so the output of all plots now includes the following message:

BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead

Hi @lordsutch ,
thanks for the bug report. I fixed the bug for the piecharts, but I also have to fix it for some other plots.
Best Patrik

This example using lineplots also generates the BokehDeprecationWarning:
import bokeh
from bokeh.plotting import output_notebook
import pandas as pd

output_notebook()
pd.set_option('plotting.backend', 'pandas_bokeh')

ts = pd.Series(np.random.randn(1000), index=pd.date_range('1/1/2018', periods=1000))
df = pd.DataFrame(np.random.randn(1000, 4), index=ts.index, columns=["alpha", "bravo", "charlie", "delta"])
df = df.cumsum()

df.plot_bokeh(figsize=(1200, 450), rangetool=True)

which returns:
BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead
BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead
BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead
BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead

...plus a great looking chart!

Hello! I'm having this warning message too, it is necessary change legend to lengend_label in the source.

BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead

In other case, It is possible to override legend_label?

I've commented legend parameter
legend=" " + name
#legend=" " + name
and now I can add:
legend_label='My label =)'
I've tried to move if/else at the beggining of the code for fix the warnings but I didn't success.
if bokeh.__version__ < "1.4":             legend_parameter_name = "legend"         else:             legend_parameter_name = "legend_label"

Hi, I already tried a quickfix for this but also didn't suceed. In the moment, I really have barely any time for maintaining, I'm sorry for that. I'll try to fix this as soon as possible.

@PatrikHlobil Any good news?

Hi @cybertk @lordsutch @joshyro ,
Yesterday I finally found some time to work on these deprecation messages. I could fix all issues, however I lost backwards compatibility with Bokeh and have to enforce bokeh>=2.0 in the future releases. Hope to release the fix this week.
Best Patrik

Closed with version 0.5

from bokeh.plotting import figure, show, output_file
x = [1, 2, 4, 6, 7]
y = [3, 6, 9, 10, 15]
output_file("legend.html")
p = figure()
p.circle(x, y, legend_label="Quantity")
p.line(x, y, legend_label="Tax 5%")
p.line(x, y, legend_label="Quantity",
line_dash=[4, 4], line_color="orange", line_width=2)
p.square(x, y, legend_label="Quantity", fill_color=None, line_color="green")
p.line(x, y, legend_label="Tax 5%", line_color="green")
show(p)

Hi @Harikumar9412-R ,
could you please explain me why you added this comment in the issue?
Best Patrik

Hey @PatrikHlobil , I am also getting this warning BokehDeprecationWarning: 'legend' keyword is deprecated, use explicit 'legend_label', 'legend_field', or 'legend_group' keywords instead when using bokeh 2.3.0
Can you please tell the reason behind this?
Thanks

Hello @arjungoel ,
which version of Pandas-Bokeh are you using?
Best Patrik

Hey @PatrikHlobil, I am using version 2.3.0

@arjungoel,
this is a very outdated version. please try to upgrade to the most recent version 0.5.4 via:
 pip install -U pandas-bokeh

What version of Python are you using?
Best Patrik

Hey @PatrikHlobil , the Python version I have been working on is 3.9.0

Hi @arjungoel ,
did upgrading pandas-bokeh solve your Issue?
Best Patrik


(maint) Merge 5.5.x to 6.0.x

jenkins please test this on redhat7-64a,osx1013-64a,aix61-POWERa,solaris11-SPARCa,ubuntu-1604-64a,windows2012r2-64a, with servertests

jenkins please test this on redhat7-64,osx1013-64,aix61-POWER,solaris11-SPARC,ubuntu1604-64,windows2012r2-64 with servertests

CLA signed by all contributors.


HHH-12086 Batch order_inserts: flush during transaction causes incorrect insert ordering and subsequent constraint violation

Cherry-picked the test case, fixed it, and applied upstream.
Thanks for providing the new test case.


consider go-linter-runner project

I discovered this project yesterday
https://github.com/alingse/go-linter-runner (hi  @alingse  :wave: )
@alingse popped out an issue on a repository I'm watching
https://github.com/montanaflynn/stats/issues/84
@Antonboom I know you often look for regression/changes when working on testifylint
Examples:

https://github.com/Antonboom/testifylint/issues/93#issuecomment-2133226047
https://github.com/Antonboom/testifylint/pull/97#issuecomment-2133928388

is this something that could be useful for you ?
are you using such a tool by yourself? or are you launching your tests on local repository like I do.
cc @mmorel-35 who might be interested

thx for recommand. I write a testifylint.yaml job , and run the actions for top 1k github golang repo.
you can check the output  https://github.com/alingse/go-linter-runner/issues/2
if you only care about the panic, I can update the includes option, you can fork or modify the repo if you would like.

hi!
sorry, I did not catch how to use the project and what actions are expected from me as an author

hi!
sorry, I did not catch how to use the project and what actions are expected from me as an author

The tool made by @alingse can be used to launch testifylint on thousands of go projects.
So you would be able to see how things varies from one version to another, even let's say code that is currently is PR and development

But maybe https://github.com/alingse/go-linter-runner/issues/4 needs to be addressed before we could use it the way I think


Configure Service Accounts for Pods

Please add info on how to bind service accounts with Deployments and not just with Pods

Page mentioned in the issue (based on the issue title): https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account
/language en

/retitle Enhance "Configure Service Accounts for Pods" page to cover ServiceAccount binding guidance for Deployments
/kind feature


[ENH] data type conventions - should time index be unique?

Should all data type conventions adopt the strict requirement that time indices be unique?
For instance, should the pd.DataFrame format specification ensure that the DataFrame.index has no duplicates?
Currently, the checks allow it, but if there are duplicates, there are errors in various places, for instance in the conversions.
The "safe" fix seems to be to add checks to require the assumption for which our codebase is robust; the "soft" fix is to add tests which check correctness on fixtures where there are repeated indices for compliance.
An example "bug" (bug depending on this assumption) is in the AA_datatypes notebook as of current main. Since load_arrow_head has a (potential) bug that loads a data frame with repeated indices, the subsequent call to convert_to results in a data frame that is still nested and does not comply with the df-multiindex specification.

Looking back at this: we probably want instance indices to be unique, affecting specific mtypes such as nested_univ. One can have repeated observations attributed to a give time point, so we may not like to enforce uniquenss for the time stamp.
As in the "soft" fix, we may like to test for robustness of methods, by introducing fixtures with repeated time indices.

I would be strongly against enforcing uniqueness of index values. I do not know how common my use case is, but I have already spent quite a lot of effort on generalising sktime's splitter behaviour to deal with either repeated or missing observations, or both. For reference:

https://github.com/sktime/enhancement-proposals/blob/main/steps/18_cv_with_irregulrar_ts_data/step.md
https://github.com/alan-turing-institute/sktime/issues/1737

I would be strongly against enforcing uniqueness of index values

Is that only for time index, or also for instance index?
I would be weakly against doing this for time index, but I would be in favour to enforce unique instance index.
The problem at hand is mainly from the nested_univ type, where a non-unique instance index makes the representation ambiguous, even if the "abstract data type" still can have repeated index.
In the pandas multiindex or a simple series, I do not mind duplicate time index, and a duplicate instance index will not even be possible (since rows with the same instane index are automatically considered as part of the same instance by pandas).
I'd be happy taking the decision that we allow repeated time indices.
What we then should do:

we need to write tests to ensure the estimators work with repeated time indices. I suppose adding a fixture would do, or - to avoid additional runtime - changing one of the many fixtures to an example that has a repeated time index? Needs to be done in forecasting, transformers, classifiers.
think about simple transformers or tags, e.g., transformers that remove duplication etc.

From slack discussion with @khrapovs, agreement:

we should allow duplicate time indices. That can happen in a number of relevant use cases.
instance indices should not be duplicate, since it is the "name of" a series, and like in math this should not be overloaded.

There is no contradiction, since time index is, conceptually, not "name of" but "place of", and multiple things can be in the same place.
As a consequence, we need to test.
Closing this given decision, test issue is here: https://github.com/alan-turing-institute/sktime/issues/3032


state that it is an alpha version in next release within marketplace

@michael-spengler, yes, I have stated in the readme and released in the marketplace


Unconditionally remove libtool helper files.

I tried to be nice but if the files exist at all, they cause problems on Windows.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Fixes a couple queries from 'property.' to 'properties.'

@andrew-buckley,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@andrew-buckley : Thanks for your contribution to the Azure documentation! The author, @fsautomata, has been notified to review your proposed change.

#sign-off


Cannot setup Instagram4j object

Hey I'm new to using 3rd party API's and I'm getting an exception while setting up the Instagram4J object
The exception is: "Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/http/client/CookieStore"
What should I do ??? I cant find a solution

make sure you have dependencies needed. are you using maven?

No, I'm not using maven.But I have provided it HTTP-client, logger,comms-3 jars still it is giving me some exception.

I have this issue as well. Even when using Maven to build my project, there are missing dependencies.

UPDATE: I solved my issue by compiling instagram4j with all dependencies included, and I also switched from JDK 10 to JDK 8. @Gaurav-Punjabi, what java version are you using?

I'm using java version "1.8.0_151". Still getting the same problem.


Support container directories in MODS

In addition to the current support for URLs and paths to individual mod/plugin jars, the MODS variable could also support directory paths (local to the container) where the contents of that directory would get brought into the mod/plugins directory. It's the same behavior as /mods but without being hard-coded to a specific path and limited to a single path.

This support is now included in the latest image.


companion plugin for loupedeck v6?

i've used the loupedeck companion plugin for sending macros to my atem mini iso via companion to the atem software. this works fine until the recent update to loupedeck software <IP_ADDRESS>55.
after the update the companion plugin is gone from the plugin sidebar in the loupedeck software, from the add- manager and from the loupedeck market place.
trying to find the plugin page on the loupedeck website leads to https://marketplace.loupedeck.com/asset/Companion. hitting the install button there opens up loupedeck which throws an error reading: "installation of the add-on failed".
any idea what goes wrong?

0.2.6 is the 5.x version, I did submit a 0.2.7 version a little more than a month ago that should be compatible with the 6.x
You can try to install this one manually and se if it help. Just remember that it might turn off auto update from the store, so it could be wise to reinstall it from there when they approve it to get updates.
CompanionPlugin.zip

thank you very much! now it works as it did before with the 0.2.6 version :-)


README image link is broken

The first image on the readme is missing:

When I go to the link to the image in the README https://storage.googleapis.com/lucid-static/common/stickers/channels-visualizations.jpg
There is an error there as well : NoSuchBucket
Until we fix this, we should remove this image from the README

This is what the image should be

Verified against this old video of the repo
https://www.youtube.com/watch?v=--7GDGQXuw4


v0.1.5

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/74640
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.5 -m "<description of version>" 20ae60ebc9bf50890e0609fc62417c0ffa82debb
git push origin v0.1.5


New Contribution

Contributor: [contributor information - Optional]
SSH Public key: [contributor SSH public key (if you don't have one, submit the issue to receive instructions)"- Required]
Attestation: [any form of attestation for contribution (e.g., signature) - Optional]

Contributing to zircuit trusted ceremony


Latex Autocomplete stop working after a certain document length

by the way, i used completr for months now and really happy with the Latex Autocomplete.
i used it everyday, it boost my latex typing speed.
but today, the Latex autocomplete stop working,
when write latex, it didn't trigger any pop up.
i already tested it,
i checked if there was anything that stop the autocomplete from triggering,
or if there was any loose "block" that prevent it.
but i don't think that was the problem.
and i think the Autocomplete stop working after
either it hit a certain document length or if you use too many latex equation,
because, when i delete some equation, it start working again, but when it reach a
certain length, it stop working again.
i'm using obsidian v1.0, and i didn't auto update my obsidian and completr,
so, it's not something that was caused by update.
i didn't use any other autocomplete, only latex autocomplete
my workflow always required me to work in a long document, and use Header Outline to move around the document.
therefore, it'll be unecessary to cut the document everytime the autocomplete stop working.
so, i really wish the problem could be resolved
i include the gif in the attachment,
it compared when i type at the bottom of the document vs the upper part of the document.
completr bug.webm

This issue comes from arbitrary limit of 1000 lines that I added, to save performance when checking for LaTeX blocks. I guess this was a bit too low. I'll fix it.

Thanks for the response,
i didn't know about the limit, i thought my obsidian somehow acting up.
by the way, Thanks in Advance,
the plugins really great, i really like it

2994ffef293ea1aa3291b477bca3c15e1b579abd


Update ElasticSearch and Clickhouse versions to latest

ElasticSearch needs to be updated to v. 7.7
Clickhouse needs to be updated to v. 20.4
Note:
Need to update:

the GCP set-up scripts
Genetics-API
Play framework
Slick

Also upgrade Play framework to latest and update Slick to latest

Updated GCP infrastructure in this PR. There is now a running image clickhouse-es7-backend-test which was created with the new scripts.

@JarrodBaker I merged the API branch into master. We need to recheck all this in one or two weeks time. I leave this opened.

Sounds good: once we're rolled out the new ES and CH I'll fire up the revised API.

Also tagging this for @mbdebian so that it can be included in the overall deployment process

closing this as work is done


Maidfiddler crash on startup

Error message
Traceback (most recent call last):
  File "maidfiddler\ui\maids_list.py", line 120, in maid_selected
  File "maidfiddler\util\pipes.py", line 124, in <lambda>
  File "maidfiddler\util\pipes.py", line 60, in __call__
  File "maidfiddler\util\pipes.py", line 66, in try_invoke
  File "maidfiddler\util\pipes.py", line 118, in _try_invoke_internal
maidfiddler.util.pipes.RemoteError: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0
  at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0
  at COM3D2.MaidFiddler.Core.Service.Service.ReadMaidData (.Maid maid) [0x00000] in <filename unknown>:0
  at COM3D2.MaidFiddler.Core.Service.Service+<>c__DisplayClass66_0.<SelectActiveMaid>b__0 () [0x00000] in <filename unknown>:0
  at COM3D2.MaidFiddler.Core.Utils.ExecutorHelper+<>c__DisplayClass3_0.<RunSync>b__0 () [0x00000] in <filename unknown>:0

To Reproduce
start maidfiddler after launching com3d2
Version information:

Game version 1.55
Maid Fiddler version latest

请问您解决了吗？我也是这个问题


"editor.renderLineHighlight" should highlight the whole line when the line is wrapped

Right now, when "highlight current line" is turned on, the line where the cursor is at is highlighted. However, when a long line is displayed in multiple lines with word wrap turned on, only one line is highlighted.
As a comparison, In Sublime, all the lines will be highlighted in this situation, which I think makes more sense, because when you press ⌘C to copy when there's no selection made, the full line will be copied, including the non-highlighted parts.

Sorry, it's a duplicate


Interested in contributing to the open source project

Hi,
Can i work on some features on the Digital Wallet?
Thanks in advance

Hi, why not?
le't do it.

Hello nabi Can you teach me good example from api


Check m.from and m.to for nil

Found this bug by backing up some messages from a deleted account so the m.from is nil. (access field from nil)
And found that m.to can be nil at some messages the other day, but couldn't figure out what is the case yet!

Thanks for finding the bug!


Start planning next milestone

We're very close to milestone 0.1.0. This means that we need to list features for the next milestone.

Does this have a polling feature? like when I update the secret's value I hope the operator detects it.
And also it seems to be nice to have a feature like putting a hash of secret CRD into the related deployment.
so that when the secret has been inserted or updated it lets the related deployment also be restarted.
(just like configmap generator)

Hi @ckcks12 , thanks for your interest! I believe they're both excellent suggestions.
Having a polling feature is definitely on our radar and there's an issue for that: https://github.com/ContainerSolutions/externalsecret-operator/issues/42
The second one seems a bit more involved, would you mind opening an issue and describing your proposal?


Create a python class to represent a jsv record

A jsv record is a data structure that represents data that has been stripped of some or all of its keys. A class is needed in Python to represent this structure. It should be implemented as nested lists, with a distinction between lists of dictionary values and json lists.

Created the following classes:

JSVObjectValues
JSVArrayValues

These are both list-like objects which represent the values associated with Objects and Arrays, respectively.


Native GitHub Annotations support when run on CI

Clear and concise description of the problem
I'd like errors to automatically appear in the Files tab on on GitHub PRs, like when using Jest:

Suggested solution
Unlike Jest's setup, I think Vitest could just detect and automatically output comments to enable these annotations. It's relatively little code, see https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message
::error file={name},line={line},endLine={endLine},title={title}::{message}

But actually you should be able to add a single matcher instead, so that GHA automatically picks up your own reporter (however this would only work with the native reporter)
https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md
Alternative
This is already possible via 3rd party reporters
https://github.com/sapphi-red/vitest-github-actions-reporter
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Does jest actually have it out-of-the box? I'm sure bun has it.
I think it would be nice to support this if it comes without additional dependencies.

Does jest actually have it out-of-the box? I'm sure bun has it.

Yep, I just used it in https://github.com/pixiebrix/pixiebrix-extension/pull/7315, you can see them in https://github.com/pixiebrix/pixiebrix-extension/pull/7315/commits/89e05e1cd5ca6e7231d948af154c1109517653f1


🐛 Bug Report: Failed to connect to the database to make sure that 'backstage_plugin_catalog' exists

📜 Description
I am trying to deploy backstage in Kubernetes by follow the steps here: https://backstage.io/docs/deployment/k8s but I get the following issue:
{"level":"info","message":"Loaded config from app-config.yaml, app-config.production.yaml","service":"backstage"}
{"level":"info","message":"1 secret found in the config which will be redacted","service":"backstage"}
{"level":"info","message":"Created UrlReader predicateMux{readers=azure{host=dev.azure.com,authed=false},bitbucketCloud{host=bitbucket.org,authed=false},github{host=github.com,authed=true},gitlab{host=gitlab.com,authed=false},awsS3{host=amazonaws.com,authed=false},fetch{}","service":"backstage"}
Backend failed to start up Error: Failed to connect to the database to make sure that 'backstage_plugin_catalog' exists, RangeError [ERR_SOCKET_BAD_PORT]: Port should be >= 0 and < 65536. Received NaN.
    at /app/node_modules/@backstage/backend-common/dist/index.cjs.js:1017:17
    at async CatalogBuilder.build (/app/node_modules/@backstage/plugin-catalog-backend/dist/index.cjs.js:4084:22)
    at async createPlugin$4 (/app/packages/backend/dist/index.cjs.js:62:40)
    at async main (/app/packages/backend/dist/index.cjs.js:206:29)

the psql database are up and running.
I have 2 secrets created:
backstage secret with 1 secret called github_token
potgress secret with 2 secrets called postgres_password and postgres_user.
👍 Expected behavior
Be able to deploy backstage.
👎 Actual Behavior with Screenshots
N/A
👟 Reproduction steps
# kubernetes/backstage.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: backstage
  namespace: backstage
spec:
  replicas: 1
  selector:
    matchLabels:
      app: backstage
  template:
    metadata:
      labels:
        app: backstage
    spec:
      containers:
        - name: backstage
          image: registry.digitalocean.com/soaand01/backstagedev:latest
          imagePullPolicy: IfNotPresent
          ports:
            - name: http
              containerPort: 7007
          envFrom:
            - secretRef:
                name: postgres-secrets
            - secretRef:
                name: backstage-secrets
# Uncomment if health checks are enabled in your app:
# https://backstage.io/docs/plugins/observability#health-checks
#          readinessProbe:
#            httpGet:
#              port: 7007
#              path: /healthcheck
#          livenessProbe:
#            httpGet:
#              port: 7007
#              path: /healthcheck

kubectl apply -f kubernetes/backstage.yaml
📃 Provide the context for the Bug.
No response
🖥 Your Environment
yarn backstage-cli info
yarn run v1.22.19
$ /Users/anderson/labs/test/backstage-new/node_modules/.bin/backstage-cli info
OS:   Darwin 21.6.0 - darwin/x64
node: v18.12.1
yarn: 1.22.19
cli:  0.21.1 (installed)
backstage:  1.8.0

Dependencies:
  @backstage/app-defaults                          1.0.8
  @backstage/backend-common                        0.16.0
  @backstage/backend-plugin-api                    0.1.4
  @backstage/backend-tasks                         0.3.7
  @backstage/catalog-client                        1.1.2
  @backstage/catalog-model                         1.1.3
  @backstage/cli-common                            0.1.10
  @backstage/cli                                   0.21.1
  @backstage/config-loader                         1.1.6
  @backstage/config                                1.0.4
  @backstage/core-app-api                          1.2.0
  @backstage/core-components                       0.12.0
  @backstage/core-plugin-api                       1.1.0
  @backstage/errors                                1.1.3
  @backstage/integration-react                     1.1.6
  @backstage/integration                           1.4.0
  @backstage/plugin-api-docs                       0.8.11
  @backstage/plugin-app-backend                    0.3.38
  @backstage/plugin-auth-backend                   0.17.1
  @backstage/plugin-auth-node                      0.2.7
  @backstage/plugin-catalog-backend                1.5.1
  @backstage/plugin-catalog-common                 1.0.8
  @backstage/plugin-catalog-graph                  0.2.23
  @backstage/plugin-catalog-import                 0.9.1
  @backstage/plugin-catalog-node                   1.2.1
  @backstage/plugin-catalog-react                  1.2.1
  @backstage/plugin-catalog                        1.6.1
  @backstage/plugin-github-actions                 0.5.11
  @backstage/plugin-org                            0.6.1
  @backstage/plugin-permission-common              0.7.1
  @backstage/plugin-permission-node                0.7.1
  @backstage/plugin-permission-react               0.4.7
  @backstage/plugin-proxy-backend                  0.2.32
  @backstage/plugin-scaffolder-backend             1.8.0
  @backstage/plugin-scaffolder-common              1.2.2
  @backstage/plugin-scaffolder                     1.8.0
  @backstage/plugin-search-backend-module-pg       0.4.2
  @backstage/plugin-search-backend-node            1.0.4
  @backstage/plugin-search-backend                 1.1.1
  @backstage/plugin-search-common                  1.1.1
  @backstage/plugin-search-react                   1.2.1
  @backstage/plugin-search                         1.0.4
  @backstage/plugin-tech-radar                     0.5.18
  @backstage/plugin-techdocs-backend               1.4.1
  @backstage/plugin-techdocs-module-addons-contrib 1.0.6
  @backstage/plugin-techdocs-node                  1.4.2
  @backstage/plugin-techdocs-react                 1.0.6
  @backstage/plugin-techdocs                       1.4.0
  @backstage/plugin-user-settings                  0.5.1
  @backstage/release-manifests                     0.0.7
  @backstage/test-utils                            1.2.2
  @backstage/theme                                 0.2.16
  @backstage/types                                 1.0.1
  @backstage/version-bridge                        1.0.2
✨  Done in 3.77s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

I updated my issue with my correct container registry name

This sounds like your backend.database config section may be out of sorts, or containing references to env variables that aren't set for the deployment.

It's weird because still doesnt work even updating the backend.database properties.

This took me a while to work out, the Postgres variables defined in the production file, don't match the kubnetes injected variables, so double check you've got POSTGRES_SERVICE_HOST and POSTGRES_SERVICE_PORT set, not the defaults.

That it, the problem came to the app.config.production yaml. I replace the app.config.production.yaml with the app.config.yaml- just to run localy

same as previous one. this is close the other?

Closing this as it looks like a duplicate issue, want to keep the conversation in one place.

Hey @soaand01, what does you app-config.yaml look like?

We recently bumped our backstage instance to 1.10 version and also implemented permission policy(added backend_secret to Helm charts) and since then we facing below error in our environments:
stderr F Backend failed to start up Error: Failed to connect to the database to make sure that 'backstage_plugin_catalog' exists, Error: Connection terminated unexpectedly

@sharadpattanshetti what does the rendered app-config.yaml look like in the running pods?

You can close this issue.
.env :
POSTGRES_HOST=localhost #or export POSTGRES_HOST=localhost

readmore : https://github.com/sequelize/sequelize/issues/11014#issuecomment-1273603909

Ok!

@benjdlambert I will retry and  share with you.

developer-portal-backstage-1  | Backend failed to start up Error: Failed to connect to the database to make sure that 'backstage_plugin_catalog' exists, error: password authentication failed for user "postgres"
getting this error when running the backstage image through docker-compose. the steps followed are of https://github.com/Rugvip/backstage-prod-diff/blob/master/DIFF.md
the error is coming from backstage container. How do we resolve this?

Hmm. I'd recommend not following that repo as that could be pretty outdated by now. It looks like the password of the postgres user is not the same in the docker-compose.yaml as what it is in the app-config.yaml Try a hardcoded value instead. error: password authentication failed for user "postgres"

@Alok650 have you found a fix? i'm stuck with this problem.

I was facing error: password authentication failed for user " in local Kubernetes, if we follow the steps from https://backstage.io/docs/deployment/k8s, then this scenario could be reproduced by doing deployments more than one time and changing the POSTGRES_USER and POSTGRES_PASSWORD in the subsequent deployment without clearing /mnt/data manually from the node.
In the subsequent deployment if the POSTGRES_USER and POSTGRES_PASSWORD change, then we are able to connect to the Postgres pod using the new  POSTGRES_USER and POSTGRES_PASSWORD, however, the backstage pod throws an error: password authentication failed for user ". I was able to overcome this by clearing  /mnt/data manually from the node and so backstage ran init and migration scripts and backstage pod was able to use new credentials as well. As I was just playing around for learning purposes, it was fine to clear /mnt/data manually from the node
@benjdlambert any suggestion on what is the right way to change db credentials and provide the right privileges to a new user? Or do we have to do this manually to grant the new user the required permissions?


Block navigation shortcuts when plaid modal is loading/shown

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17598
PROPOSAL: https://github.com/Expensify/App/issues/17598#issuecomment-1514638320
Tests

Verify if Group creation shortcut is blocked when there is no plaid modal shown

Open the app -> settings -> payments -> add bank account
When the plaid modal is loading try to use to CTRL/CMD + SHIFT + K shortcut to create group chat, verify if this shortcut is blocked (it must be). The page url will be /settings/payments/add-bank-account
After successfully filling in the plaid account details on the plaid modal, and navigated back, try to use the CTRL/CMD + SHIFT + K shortcut again, verify if it works (it must work this time).

Verify if search shortcut is blocked when there is no plaid modal shown

Open the app -> settings -> payments -> add bank account
When the plaid modal is loading try to use to CTRL/CMD + K shortcut to open search, verify if this shortcut is blocked (it must be). The page url will be /settings/payments/add-bank-account
After successfully filling in the plaid account details on the plaid modal, and navigated back, try to use the CTRL/CMD + K shortcut again, verify if it works (it must work this time).

Verify if Group creation shortcut is blocked when plaid modal is loading in VBBA flow

Create Workspace
Go to Workspace's settings and click "Connect bank account"
Verify that the shortcut CTRL/CMD + K works
Go back to Workspace's settings and click "Connect bank account"
Click "Connect online with Plaid", and while the spinner is shown, try to press CTRL/CMD + K: it should do nothing
Follow the plaid modal flow to add a bank account from Wells Fargo, select the "saving" and "checking" bank accounts. After finishing with the plaid modal, you should land in this view:

Confirm that the shortcut CTRL/CMD + K works again

[ ] Verify that no errors appear in the JS console

Offline tests

Same as the "Tests" section above.
QA Steps

Same as the "Tests" section above.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Chrome
https://user-images.githubusercontent.com/68777211/236357256-e79965d5-ab7c-43a7-997c-e2f8c91320ba.mp4
Safari
https://user-images.githubusercontent.com/68777211/236357336-d5fc1cf2-0ad4-4da2-ad65-6c028e9f7563.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/68777211/236360507-3c30ef91-bdc2-42fe-9faf-aef2e2aff856.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/68777211/236358724-e223a36a-7870-4c1d-ab6b-88af7d69011f.mp4

Desktop
https://user-images.githubusercontent.com/68777211/236357142-cc36f688-8e95-4da9-aa3b-33c4ffda09cc.mp4

iOS

https://user-images.githubusercontent.com/68777211/236361575-25bc36ba-9c0e-4126-a174-1f6389ac4d19.mov

Android

https://user-images.githubusercontent.com/68777211/236361801-3d82410c-a4ea-4a3a-ab5c-e05ee9445d24.mp4

@huzaifa-99 I think you may need to pull main again. The unit tests are still failing.

Thanks @huzaifa-99 !

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Add a readme file.

Create a readme file with usage examples and important information for other developers in how to use this template engine.

Readme done


Cut from cursor to next occurrence

Cut from cursor to next occurrence of search string.

alt+xn cuts from cursor up to search string.
alt+dn deletes from cursor up to search string.
Note, the found search string is not cut/deleted. Just everything up to the search string is cut/deleted.


Native Infowindow VS HTMLInfoWindow

I'm submitting a ...  (check one with "x")
[ X] question
[ ] any problem or bug report
[X ] feature request
Currently for what i've seen the native infowindow offers very little ( althought i might have missed it) personalization.  In the meanwhile, the HTMLinfowindow seems to be built via html (is it a div?) and has some weird map pan issues ( doesn't follow the marker all the time).
could the infowindow via HTML render instead inside a HTML? or, could we provide in some way a layout XML + class definition (json? java? properties?) given a standard for the infowindow content?
if testing this stuff is too much burden,  and If i personally made some progress on making an infowindow render a Webview content on it, even if it had some size restrictions for content, could you consider a switch to it or adding it? for the ios side it seems it's easier, set up a transparent view and then adding a webview as subview (that's how most custom IOS infowindows are done), but i have no experience on that.

could the infowindow via HTML render instead inside a HTML

no

First of all, you need to recognize the native Google Maps APIs use OpenGL.
OpenGL can handle only graphics. That's why all views are convert to bitmap Google Maps API internal.
That's why you can not display any HTMLs in the infoWindow.
If you want to just display images and text, you can pass base64 encoded string for the title and the icon properties.
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v1.4.0/class/Marker/README.md#base64-encoded-icon


Add a way of updating owned lists when new free items are added

I've been away from iRacing for a while, and there's a lot of new free content. I've been through and marked these as owned, but it would be nice if there was a way of updating this automatically.

This was always the intended behaviour, and should update automatically the moment it loads up. You can see in the screenshit the free content is unclickably active. Is this affecting cars/tracks or both? Is it content that has been made free to you or made free to all subscribers?

I belive it affected both cars and tracks (it was a while ago now!). It was all content that had been made free in the last ~2 years - e.g. the Formula Vee, Rudskogen Motorsenter. Once I selected the items, they became unclickably active, but they did not appear as content I owned until I did so.

Finally figured out why it was happening - intended action on load from Local Storage but then wiping out when loading from Firebase! Should now be fixed


support python 3.10 with ray >= 2.0

Closes #104
Example

Ray supports Python 3.10 from version 2.0.0.
Screenshots

Checklist

[x] References any related issue by including "Closes #" or "Closes ".

If no issue exists and your change is not a small fix, please create an issue first.

[x] Includes tests or only affects documentation.
[x] Passes pre-commit checks.

Run pre-commit install && pre-commit run --all locally for formatting and linting.

[ ] Includes screenshots of documentation updates.

Run mkdocs serve view documentation locally.

[x] Summarizes PR's changes in CHANGELOG.md

@desertaxle please let me know if you think further changes are necessary in order to support Python 3.10.


Get User's coordinates in MS Team

I would like to show near customers list in MAP with their address. so how can i get user live lat and lon in bot composer while using MS Team as Channel.

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repos are the preferred platform for submitting bug fixes and feature requests.

There is no coordinate data that comes from ChannelData with the Teams channel. My assumption is that there is anything that the Teams client would have that convey that, but you might want to look into Teams GRAPH stuff to confirm.
Additionally, you could ask the customer for their location and store that in user state. Then you could have an API/call in the bot that would lookup long/lat. Then you could send an activity to the user (probably an adaptive card) that would have the map.


If a project B use project A as a junction, B should not try to use the bst remote cache of A (at least by default)

Opening a new issue, this has regressed https://github.com/apache/buildstream/issues/401
Same reason as before. If project A is popular, this will literally kill the cache server.

Though seems current behaviour is potentially worse than how it was back with original issue. Current behaviour is project B cache is never considered for project A artifacts meaning when the artifacts go out of cache for project A, they will never be considered cached.


Migration had wrong type of default value for boolean fields

shold be boolean
ERROR:  column "seen" is of type boolean but default expression is of type integer HINT:  You will need to rewrite or cast the expression.

fixed


Tabular: Switched KNN and RF to use refit_folds instead of use_child_oof

Issue #, if available:
Description of changes:

Switched KNN and RF to use refit_folds instead of use_child_oof during bagging
This results in the same model at test time for RF and KNN, but different out of fold predictions.
While being 10x slower to train, this will reduce stack information leakage significantly while keeping inference speed identical. I would guess that assuming enough time is given, this will improve stack quality.

TODO:

[ ] Benchmark

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1351-1 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1351/1/index.html

Job PR-1351-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1351/3/index.html

Job PR-1351-5 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1351/5/index.html

Job PR-1351-8 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1351/8/index.html

Job PR-1351-9 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1351/9/index.html

Closing due to being outdated and not showing superior performance to use_child_oof.


use textColor less var for 'learn more' link

re: https://github.com/microsoft/pxt-adafruit/issues/1098, will need to set the variable to white in adafruit
also make experiments header display properly like other text boxes, which I'm pretty sure I remember there being an issue for at some point but I don't see it

Do we have a secondary text color? I feel like it should be de-emphasized like in micro:bit:

Hm, closest seems to be @secondaryColor, but that's more of an accent / doesn't have high enough contrast to be used for accessible text (it's a similar color in microbit to the gray text from that screenshot, which had a contrast ratio under 3 and had to be darkened a bit). I'll just add a @secondaryTextColor with a gray that works


Add script to generate brotli compressed assets

Is something else needed to get this working? I got back that this PR's documentation link isn't sending it https://tools.keycdn.com/brotli-test

@snowystinger yes, we will also need to modify the CDN config to serve these assets.
But i think it is good to merge and then i can take that task ^ on.


Missing Manager resource, after discovering BMC.

After adding DeviceMgr as plugin, the discovered System has Manager resource, that does not exist in db.

What path are you using to GET the Manager resource?

Actually, I am no trying to GET the missing Manager, the Validator tries to do that. I updated the description.


CEMS FTP download gets trapped in a loop

Describe the bug
The CEMS FTP site doesn't have data for October, November, or December of 2017. When the datastore code tries to download the file, it should error out after the second attempt to download those missing files (see the logic here, which I wrote), but that doesn't happen.
To Reproduce
Run update_datastore.pywith a constants.data_years that includes 2017 for the EPA CEMS data.
Expected behavior
Expected an error downloading the missing files. One fix would be to remove 2017 from the CEMS data_years until those files are available. But it would be nice if the FTP downloader worked as designed.
Desktop (please complete the following information):

OS: Ubuntu 18.04
Postgresql version 10.5
Python version: 3.6

I was wrong. This isn't happening; I'm just impatient.


Issue with Submission, and Question about Ponderation of Scores & Timeline

I have submitted a second entry that was marked as accepted, but it does not appear on the leaderboard. I suspect this may be due to the second submission yielding lower scores than my initial one. How are instances like these typically addressed, particularly when the second submission performs worse than the first? Could this be the reason for its absence, or might there be another explanation?

How will the scores (BLEU4, ROUGE-L, Bertscore, F1-cheXbert, F1-RadGraph) be weighted to determine rankings?

Previously, the deadline for System submissions was May 10th, with papers due by May 17th. However, the submission deadline has been extended to May 15th. Will the deadline for System papers remain unchanged, or will it be postponed accordingly?

Thank you very much!

Thanks for your comment.
You are right for 1., only your best score, according to f1radgraph, will be shown. You can retrieve all your submissions using the "retrieve" section.
2. F1-radgraph will be used to determine ranking, but our overview paper will report all the metrics.
3. The deadline for system papers will remain unchanged, unless communicated otherwise by the workshop organizer. Will keep you updated.
thanks,


Native types could use helpful consts like maxValue, minPositive, maxFinite, etc.

I have a WIP here, though I've taken off the auto-suggested reviewers: https://dart-review.googlesource.com/c/sdk/+/338100
I've reposted the original proposal below.
I think this would help with bounds-checking (esp for Int), testing functions that should behave differently when given x = 0.0 vs x = 0.0 + Float.minPositive, etc.

native_type: add minValue, maxValue to native Int; add maxFinite, minPositive to native Float
This is useful for adding bounds-checks to int and double that get passed to native code. For int, I think this would be clearer in most cases than checking overflow from toSigned(), toUnsigned().
The maxFinite and minPositive values are placeholders taken from julia's floatmin() and floatmax() on Float32 and Float64. I am not sure these are correct for dart, as I am not familiar with the IEEE spec for floating point numbers or how dart specifically handles them.
Since new native number types are not going to be added regularly, I switched back to static const to match the constants in double. The other way I considered was an interface on int, double, _NativeInt, _NativeDouble. However, I'm unsure what real-world benefit that would offer at the cost of overcomplicating things.

I think this looks reasonable.
cc @lrhn for library API opinion
cc @dcharkes

It as also worth noting that dart's double static const minPositive = 5e-324 differs from Julia's floatmin(Float64) => 2.2250738585072014e-308. Both claim to be IEEE 754, so that could use some investigation.

Hi @crasm, thanks for your contribution!

This is useful for adding bounds-checks to int and double that get passed to native code. For int, I think this would be clearer in most cases than checking overflow from toSigned(), toUnsigned().

Nit: The operations on Pointer<Int8>.value and friends are currently defined in terms of toSigned and toUnsigned. The problem with defining them in terms of max/min value is that the behavior when the value falls outside of the range is unspecified. toSigned and toUnsigned precisely defines truncation on storing.
I agree that for checking, when one doesn't want truncation behavior, a min and max value would be clearer.

The other way I considered was an interface on int, double, _NativeInt, _NativeDouble. However, I'm unsure what real-world benefit that would offer at the cost of overcomplicating things.

We don't have virtual dispatch on types, so an interface for static fields/functions doesn't provide any benefit.
Cross linking a request for the Dart non FFI types:

https://github.com/dart-lang/sdk/issues/41717

I left some comments on the PR.
As a high level API idea: should we add static methods to int and double instead, and forward from the dart:ffi types to there? Along the lines of:
class int {
  static int minValueSigned(int width);
  static int maxValueSigned(int width);
  static int minValueUnsigned(int width);
  static int maxValueUnsigned(int width);
}

class double {
  static const int minValue;
  static const int maxValue;
}

There might be other places than dart:ffi where the min/max values might be useful.

I'd use the same names as on double for float types:

maxFinite (largest number with isFinite true),
minPositive (smallest number with > 0 true)
nan/infinity (for the value for that type, if that makes sense, but the constants are likely going to be double values anyway, so no need. And wouldn't bother with negativeInfinity, just use -.)

and use minValue (-2^(bits-1)) and maxValue (2^(bits-1)-1) for integers.
The Dart double.minPositive is the smallest Dart double which is > 0, which is a de-normal number.
The Julia floatmin(Float64) value is the smallest normal number. Maybe Julia doesn't support denormals.
Dart does not attempt to make any distinction between normal and denormal representations of floats, and should support denormals on all platforms. If we ever wanted to change that, we'd have to think hard about how to do that without breaking things. (Normal representation doubles are not closed under subtraction, adding denormals to doubles makes them be that.)
If we wanted people to know the limits of normal/denormal numbers, then I'd add:
  static const maxDenormal = 2.225073858507201e-308;
  static const minNormal = 2.2250738585072014e-308;

So:
abstract final class Float64 implements NativeType<double> {
  static const double maxFinite = double.maxFinite;
  static const double minPositive = double.minPositive;
  // ...
}
abstract final class Float32 implements NativeType<double> {
  static const double maxFinite = 3.4028234663852886e+38;
  static const double minPositive = 1.401298464324817e-45;
  // ...
}
abstract final class Int8 implements NativeType<int> {
  static const int maxValue = 0x7F;
  static const int minValue = -0x80;
  // ...
}
abstract final class Uint8 implements NativeType<int> {
  static const int maxValue = 0xFF;
  static const int minValue = 0x00;
  // ...
}
// ...
abstract final class Int32 implements NativeType<int> {
  static const int maxValue = 0x7FFFFFFF;
  static const int minValue = -0x80000000;
  // ...
}
abstract final class Uint32 implements NativeType<int> {
  static const int maxValue = 0xFFFFFFFF;
  static const int minValue = 0;
  // ...
}
abstract final class Int64 implements NativeType<int> {
  static const int maxValue = 0x7FFFFFFFFFFFFFFF;
  static const int minValue = -0x8000000000000000;
  // ...
}
// No Uint64, I presume.

I'm not sure I want_ to add functions to int to compute the maximum value of specific precisions of two's complement numbers. Although, they do match with toSigned(n), so there could be some argument for it.
For unsigned numbers, it's less useful. The min-value is always zero, having a function for that is overkill, and the max-value function could be called powOf2minus2, because it might be more generally useful than just predicting the maximal possible value of toUnsigned(n). But still possible.
So something like
abstract final class int {
  // ...
  static int maxUnsigned(int bitCount) {
    RangeError.checkValueInInterval(bitCount, 1, 64);
    return (1 << bitCount) - 1;
  }
  static int maxSigned(int bitCount) {
    RangeError.checkValueInInterval(bitCount, 1, 64);
    return (1 << (bitCount - 1)) - 1;
  }
  static int maxUnsigned(int bitCount) {
    RangeError.checkValueInInterval(bitCount, 1, 64);
    return (-1 << (bitCount - 1));
  }

to match the toSigned and toUnsigned methods could be reasonable.
On the web they'd only allow bit counts up to 32.
If the primary use-case for this is FFI, it might be better to avoid putting it into a platform library that must also be supported on the web.
(We could add maxValue/minValue getters to typed data integer lists too. That's where Dart actually has other precision integers, and if we ever added Uint8 as a built-in Dart type, that's where I'd put it.)

If the primary use-case for this is FFI, it might be better to avoid putting it into a platform library that must also be supported on the web.

Probably dart2wasm as well, but that might use dart:ffi for interop.
Maybe in the context of dart2wasm if one uses JS interop instead of wasm interop, one would like to check signed 2^53 as a bound?
cc @eyebrowsoffire

I'm not sure I want_ to add functions to int to compute the maximum value of specific precisions of two's complement numbers. Although, they do match with toSigned(n), so there could be some argument for it.
For unsigned numbers, it's less useful. The min-value is always zero, having a function for that is overkill, and the max-value function could be called powOf2minus2, because it might be more generally useful than just predicting the maximal possible value of toUnsigned(n). But still possible.

Your call 😄
We can always add it later, but then the static const ints in dart:ffi would become static int get which would be a breaking change, or we would only update the documentation to point to int. maxUnsigned and friends and not the implementation.

abstract final class Int8 implements NativeType<int> {

I don't think we want to start reshuffling the type hierarchy of NativeType. NativeType does not have a type argument (that would force all Structs to start implementing their own type for example). Moreover, it's a final && base extends hierarchy not an implements relation. And lastly, the classes are not abstract because we use the const constructor for field annotations in structs. So, lets just add static const fields, but not change the class modifiers and type arguments.

I don't think we want to start reshuffling the type hierarchy of NativeType.

I was just guessing at declarations, whatever it is today is fine.


checkin sdk for 0401 & 0501-preview

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

spring

Will update version in #4844