(vertical compaction) fix vertical compaction core

co-author:@zhannngchen
Proposed changes
Issue Number: close #22139

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.59 seconds
stream load tsv:          506 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>3 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.73 seconds
stream load tsv:          509 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.01 seconds
stream load tsv:          529 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>7 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.05 seconds
stream load tsv:          540 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         19 seconds loaded<PHONE_NUMBER> Bytes, about 118 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>7 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.49 seconds
stream load tsv:          507 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size:<PHONE_NUMBER>2 Bytes


Struggle to insert mv-extractor to IDE

thanks for your responses, I would like your help to use your module inside my project - I only need the videoCap API for python in Pycharm.
is there a guide for using the docker inside Pycharm? or the module itself without the docker?

Hey dananomer,
it is possible to integrate Docker with Pycharm. You can read on this in the pycharm docs. However, I haven't done ut myself before. I usually just use the terminal with a text editor.
And you will have to install everything. The Python part of the project is just a thin wrapper around the C++ code which does all the work (grab video frames, extract motion vectors, etc.).

Closing due to inactivity. Feel free to reopen for further discussion.


Fix SpringManager Crash on Missing Data Folder

Previously if the SpringManager was opened without a pre-existing data folder it would crash. Added an  os.makedirs(directory, exist_ok=True) within the set_library function.

Hi @hayes87
Thanks for the PR I will check it ASAP


NIFI-6468: Adding AWS S3 'requester pays' to Fetch and List processors.

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
NIFI-6468: Adds "requester pays" to FetchS3Object and ListS3.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

+1 from me as well, merging to master, thanks @gresockj


Embed file permissions for features

This PR fixes the following warnings on boot:
Feb 16 14:33:07 localhost systemd[1]: Configuration file /usr/lib/systemd/system/elemental-setup-initramfs.service is marked executable. Please remove executable permission bits. Proceeding anyway.
Feb 16 14:33:07 localhost systemd[1]: Configuration file /usr/lib/systemd/system/elemental-rootfs.service is marked executable. Please remove executable permission bits. Proceeding anyway.
Feb 16 14:33:07 localhost systemd[1]: Configuration file /usr/lib/systemd/system/elemental-setup-rootfs.service is marked executable. Please remove executable permission bits. Proceeding anyway.
....

It does this by collecting the features into tarballs before embedding them into the go binary.
Each feature gets it's own tarball and is generated in pkg/features/generated/<feature-name>.tar. The generation happens in the pkg/features/generate-tarballs.go generator which makes it necessary to run go generate ./... before building.
Fixes #1895

Codecov Report
Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (81015ee) 72.04% compared to head (d88f19e) 72.05%.

Files
Patch %
Lines

pkg/features/features.go
56.81%
15 Missing and 4 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
+ Coverage   72.04%   72.05%   +0.01%
==========================================
  Files          72       72
  Lines        8019     8035      +16
==========================================
+ Hits         5777     5790      +13
- Misses       1779     1782       +3
  Partials      463      463

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Linted using ESLint and other cleanups

I used Overcommit, ESLint and Babel to help find some interesting "errors" in your source code consistency, albeit mostly small stuff, like quote consistency and mixed white space (man, THAT one was "fun"; there were tabs in the source code!). I did, however, manage to find one actual error, in test/core/Bounds.js, in the process: it was potentially giving a false positive with a no-unused-vars error showing up during linting (c.f. that file).
Other than that, it was just cleanup and enforcing the linting rules. I know that there are a lot of files changed, but I would still ask that you go over all of them; sometimes I removed an unused variable, and other times, I told it to ignore it. Overcommit wouldn't let me just halfway do it, after all. I didn't include any files that weren't already in the system, but I will attach my extras with the PR if you want to add them in. The ESLint files were created with jshint2eslint, too, so they should be pretty consistent.
extras.zip
Signed-off-by: Jonathan Sifuentes<EMAIL_ADDRESS>

Thanks for this! Unfortunately, we are already in the process converting to ESLint in our dev-es6 branch (as well as converting to ES6) and have fixed many of these issues you pointed out. If you want to take a pass at that source to make sure we didn't miss anything, that'd be useful!


Update to latest seL4 kernel.

Minor changes to compile with seL4 kernel.

Hey, I don't know if anyone was in touch with you about this PR.   I'm closing it as libsel4vka was moved to here more than a few years ago, and that version has been kept up to date with the later versions of the seL4 kernel.  I'm marking these old repositories as DEPRECATED to try and prevent them being used by mistake.


Update helm chart README

Replace previous helm repo with the new one in helm docs and update usage
Add .pre-commit-config.yaml file to generate helm docs before commit

/lgtm


Add tackle-hub client and roles to realm and configure hub for auth

Added tackle-hub client to tackle realm.
Added scopes for each resource collection and method.
Added tackle-admin, tackle-architect, and tackle-migrator roles.
Set up Keycloak env variables in Hub deployment

@mansam LGTM


WIP: Test/refactor validations

Security Checklist

[ ] 1. Re-Entrancy
[ ] 2. Arithmetic Over/Under Flows
[ ] 3. Unexpected Ether
[ ] 4. Delegatecall
[ ] 5. Default Visibilities
[ ] 6. Entropy Illusion
[ ] 7. External Contract Referencing
[ ] 8. Short Address/Parameter Attack (off chain)
[ ] 9. Unchecked CALL Return Values
[ ] 10. Race Conditions / Front Running
[ ] 11. Denial Of Service (DOS)
[ ] 12. Block Timestamp Manipulation
[ ] 13. Constructors with Care
[ ] 14. Uninitialized Storage Pointers
[ ] 15. Floating Points and Precision
[ ] 16. Tx.Origin Authentication
[ ] 17. Address.isContract Re-Entrancy via Constructor

⚠ NOTES ⚠
Make sure to think about each of these exploits in this PR.

@ivansolomonoff might be cool to also clear our warnings

@ivansolomonoff might be cool to also clear our warnings

@ivansolomonoff might be cool to also clear our warnings

yup, it's done now.

https://github.com/para-space/paraspace-core/pull/113/commits/73a672d5fbb0ae3d2aeef5486b9dd2d956eb05ec
@ivansolomonoff  some minor polish here.  for non-borrowed case maybe we do not need it after double confirm with team so just remove it from the common validation logic here.


Missing tools in PATH error when building from latest mainstream OpenBMC repo

Got an error about missing tools ' lz4c pzstd zstd' when trying to build the latest mainstream OpenBMC repo with private-OSFCI (issue likely also exist in public-OSFCI)

-- url used --
https://github.com/openbmc/openbmc.git master

@vejmarie @susmithp @gregg-shick  any comments here ?

Container needs to be updated with those additonal packages it looks like.

based on discussion with @vejmarie , @susmithp and @gregg-shick .. will be doing some mods on https://github.com/opencomputeproject/OSF-OSFCI/blob/master/compile/Dockerfile.openbmc to fix this


Language Server - location tests base

preliminary additions to textui in order to start submitting the other patches

(note: This PR is very much ready and waiting for review.
It's just that I'm making further PRs on my side in the meantime,
and am sending content shared between many of them this way.

I tried to review.  I either need more context or we need someone else.  Two things that bothered me.  One is a comment that says TEMPORARY.  At the very least the comment should say why it is temporary and what event (in code development) will make it permanent or can be deleted.  Some systems support an annotation "at ToDo"  (don't know how to escape here) that at least will be flagged and can nag a dev about something they need to address.  The other is I'm not sure I agree with the name or location of test.../ScriptData but it does appear that someone else approved that so my agreement is not needed for a review.
For my information why did you choose to introduce yet another dependency for testing?

One is a comment that says TEMPORARY. At the very least the comment should say why it is temporary and what event (in code development) will make it permanent or can be deleted. Some systems support an annotation "at ToDo" (don't know how to escape here) that at least will be flagged and can nag a dev about something they need to address.

https://github.com/kolmafia/kolmafia/pull/49#pullrequestreview-787980812 should provide some context.
Basically, https://github.com/kolmafia/kolmafia/pull/49 is too big/touches too many classes for it to be reviewed all at once. So instead, I agreed to split it into multiple PRs, each of them addressing a specific parsetree class (or a closely related group), and coming with tests.
Once this PR is merged, I'll start submitting some of them (I can't submit them all at once, because some of them have conflicts in the tests, or are dependant on another).
The "TEMPORARY" are constructors that will be removed by then end of all this (since the goal is to give everything a Location). They are constructors that only exist because of how I can't submit the whole change at once.

For my information why did you choose to introduce yet another dependency for testing?

See https://github.com/kolmafia/kolmafia/pull/204/commits/76b91c53880e5ccac47152ef9348f79f40112fe5 's commit message.

You answered my questions so I will approve even if I am not completely certain what is going on :-) You will, however solemnly promise to remove the TEMPORARY code ASAP. I merge tomorrow if no one else beats me to it.

I solemnly swear it. The incoming patches all target the addition of locations, and the temporary constructors will be removed as soon as they no longer get called.


react-native link fails for iOS if there are other projects in the main app folder

Issue Description
react-native link fails for iOS if there are other xcode projects in the main app folder. This is because in findProject.js, the findProject(folder) method doesn't prioritise projects in the <root>/ios folder. This means that it picks the wrong project as the main project, and linking fails.
This is a problem when you have a git submodule that contains an xcode project.
Steps to Reproduce / Code Snippets
Put another xcode project in the root app folder and run react-native link.
Additional Information

React Native version: 0.35.0
Platform(s): iOS
Operating System: macOS

module.exports = function findProject(folder) {
  const projects = glob
    .sync(GLOB_PATTERN, {
      cwd: folder,
      ignore: GLOB_EXCLUDE_PATTERN,
    })
    .filter(project => {
      return path.dirname(project) === IOS_BASE || !TEST_PROJECTS.test(project);
    });

  if (projects.length === 0) {
    return null;
  }

  return projects[0];
};

This is the code that tries to find the main app xcode project. It will find projects in the root app folder before those in the /ios folder, thus picking the wrong project when doing projects[0].

PR is welcome.

Great, on the case

shipping https://github.com/facebook/react-native/pull/10495

Experiencing the same problem with RN 49 on iOS.
react-native link returns with success message but link actually fails and it requires a manual installation.


Upgrade to 2.2

@MaherJendoubi  very very thanks for this PR. I'm counting the seconds for see merge of this PR <3

@thiennn Thank you for the help.


vee-validate distribution for users who already have validator.js

It would be nice if there was a version of vee-validate available for download that used an external copy of validator.js, to provide the backend validation functions, rather than providing a copy of those functions itself.  This would eliminate code duplication for users who are already using validator.js for other purposes.

This has been addressed in the v3 branch, all external package rules have been altered to simpler implementation and the rest are deprecated.


625 macos modifiers

[x] Tested on all platforms changed
[x] Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
[x] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
[x] Created an example program if it would help users understand this functionality

fixes #625
fixes #623

just tested with this branch of alacritty and it appears to work great

Thanks! This looks great.

@francesca64 any chance of shipping another patch so we can get this downstream into https://github.com/jwilm/alacritty/pull/1403 😅

@francesca64 https://github.com/tomaka/winit/pull/630


Update shs.py

'sftp', '-b', '-', '-o', causes public key problems, remove the '-b, '-' options. Changes buffer and forces entering of SSH/SFTP password multiple times. But does solve the public key failure reported here: https://github.com/Gandi/letsencrypt-gandi/issues/6.

Hello ! I did update SHS.py file, but I get the same results  :
sftp ['sftp', '-o', 'UserKnownHostsFile=/Users/Stan/.ssh/known_hosts',
Connected to sftp.dc2.gpaas.net.

Permission denied (publickey,password).
Connection closed
Cleaning up challenges
Permission denied (publickey,password).
Connection closed
Permission denied (publickey,password).
Connection closed
Couldn't place file in domain: vhosts/wearefrauds.com/htdocs//.well-known/acme-challenge`

Anyone has an idea how to solve this ?
Thanks :)

With this shs.py file, I was able to use the plugin, but, I had to type the sftp password for all sftp command, even if I setup my ssh key, but in the end, the plugin has worked as expected

Same thing here !

Same problem, same resolution, thanks!


python3.6 Successful Attempt

thanks@andabi project

Because I want to use Python 3 to reproduce this project, I have encountered many problems, which have been successfully solved. I specially write about some problems encountered in the process of reproducing and how to solve them. I think that's all I can do to help the people behind me.

Installing CONDA virtual environment
$ conda create –n  voice python=3.6
$ source activate voice3

Installing cuda + cudnn
conda install cudatoolkit=8.0 -c https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free/linux-64/

At this point, he will automatically install the cudnn version, and tensorflow 1.4 will work well in the cuda8 + cudnn6 environment.

Installation of required bags
tensorflow==1.4
tensorflow-gpu==1.4
librosa==0.6.2
pyyaml
tensorflow-plot==0.3.0
tensorpack 0.9.0

I'm just a couple of trains that I've run successfully in the right environment.

GET RIGHT data_path
You can choose any of the following to do it
1）change data_load.py
wav_file.replace("WAV.wav", "PHN").replace("WAV", "PHN")

change timit dataset  .WAV file -->.wav file
For example：
wav_file = '/datasets/timit/TIMIT/TRAIN/DR3/MTJM0/SA1.WAV'
filename, extension = os.path.splitext(wav_file)
new_wav_file= filename+extension.lower()
you can get: '/datasets/timit/TIMIT/TRAIN/DR3/MTJM0/SA1wav'

Increase the number of threads or batch_size you can accelerate training
Of course, it depends on your hardware.

For later visitors guidence: detailed .yaml description in py36:
name: deepvoice
channels:
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/main
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/main/
  - https://mirrors.tuna.tsinghua.edu.cn/anaconda/pkgs/free/
  - defaults
dependencies:
  - _libgcc_mutex=0.1=main
  - backports=1.0=pyhd3eb1b0_2
  - backports.weakref=1.0rc1=py36_0
  - blas=1.0=mkl
  - bleach=1.5.0=py36_0
  - ca-certificates=2020.10.14=0
  - certifi=2020.12.5=py36h06a4308_0
  - cudatoolkit=8.0=3
  - cudnn=6.0.21=cuda8.0_0
  - html5lib=0.9999999=py36_0
  - importlib-metadata=2.0.0=py_1
  - intel-openmp=2020.2=254
  - ld_impl_linux-64=2.33.1=h53a641e_7
  - libedit=3.1.20191231=h14c3975_1
  - libffi=3.3=he6710b0_2
  - libgcc=7.2.0=h69d50b8_2
  - libgcc-ng=9.1.0=hdf63c60_0
  - libprotobuf=<IP_ADDRESS>=hd408876_0
  - libstdcxx-ng=9.1.0=hdf63c60_0
  - markdown=3.3.3=py36h06a4308_0
  - mkl=2020.2=256
  - mkl-service=2.3.0=py36he8ac12f_0
  - mkl_fft=1.2.0=py36h23d657b_0
  - mkl_random=1.1.1=py36h0573a6f_0
  - ncurses=6.2=he6710b0_1
  - numpy=1.19.2=py36h54aff64_0
  - numpy-base=1.19.2=py36hfa32c7d_0
  - openssl=1.1.1h=h7b6447c_0
  - pip=20.3.1=py36h06a4308_0
  - protobuf=<IP_ADDRESS>=py36he6710b0_1
  - python=3.6.12=hcff3b4d_2
  - readline=8.0=h7b6447c_0
  - setuptools=51.0.0=py36h06a4308_2
  - six=1.15.0=py36h06a4308_0
  - sqlite=3.33.0=h62c20be_0
  - tensorflow-gpu=1.3.0=0
  - tensorflow-gpu-base=1.3.0=py36cuda8.0cudnn6.0_1
  - tensorflow-tensorboard=1.5.1=py36hf484d3e_1
  - tk=8.6.10=hbc83047_0
  - werkzeug=1.0.1=py_0
  - wheel=0.36.1=pyhd3eb1b0_0
  - xz=5.2.5=h7b6447c_0
  - zipp=3.4.0=pyhd3eb1b0_0
  - zlib=1.2.11=h7b6447c_3
  - pip:
    - audioread==2.1.9
    - biwrap==0.1.6
    - cffi==1.14.4
    - cycler==0.10.0
    - decorator==4.4.2
    - joblib==0.17.0
    - kiwisolver==1.3.1
    - librosa==0.6.2
    - llvmlite==0.31.0
    - matplotlib==3.3.3
    - msgpack==1.0.0
    - msgpack-numpy==<IP_ADDRESS>
    - numba==0.48.0
    - pillow==8.0.1
    - pycparser==2.20
    - pydub==0.24.1
    - pyparsing==2.4.7
    - python-dateutil==2.8.1
    - pyyaml==5.3.1
    - pyzmq==20.0.0
    - resampy==0.2.2
    - scikit-learn==0.23.2
    - scipy==1.5.4
    - soundfile==0.10.3.post1
    - tabulate==0.8.7
    - tensorboard==1.7.0
    - tensorflow-plot==0.3.0
    - tensorpack==0.9.0
    - termcolor==1.1.0
    - threadpoolctl==2.1.0
    - tqdm==4.54.1
prefix: /home/hsj/miniconda3/envs/deepvoice

I still have wrong with the import of tensorpack and tensorflow


Only 2 tests result is displayed in the -html_logs

Hi, I have a 4 testrscript in my jobb file.
def main(runtime):

    runtime.job.name = 'ios-infrastructure-tests'
    # Find the location of the script in relation to the job file
    run(testscript='test_main.py', runtime=runtime)
    run(testscript='test_interface.py', runtime=runtime)
    run(testscript='test_spantree_bpdu_block.py', runtime=runtime)
    run(testscript='test_auto_qos.py', runtime=runtime)

after test is done, i can not see all the result in html_log file.
result from the first 2 testscript is there but not the rest.
need help to understand way?!

My problem is no related to pyATS, i had a error in my build chain of the the docker image i user.
My bad


version 20 not working

it's pulling the live iso and doesn't inject the auto install into txt.cfg i tried modifying the install script but couldn't get it to work correctly
the set command at 252:
sed -i "/label install/ilabel autoinstall\n\
is not running since there no install in the file:
default live
label live
menu label ^Install Ubuntu Server
kernel /casper/vmlinuz
append   initrd=/casper/initrd quiet  ---
label live-nomodeset
menu label ^Install Ubuntu Server (safe graphics)
kernel /casper/vmlinuz
append   initrd=/casper/initrd quiet  nomodeset ---
label memtest
menu label Test ^memory
kernel /install/mt86plus
label hd
menu label ^Boot from first hard disk
localboot 0x80

Sorry for the delay.   Will take a look at this.


pixi 4.8.1 bitmap font loading error. Cannot read property 'frame' of undefined

When loading bitmapfont I get a runtime error.
I bumped my pixi.js from v3.7.4 to v4.8.1 and then this error was introduced.
Expected Behavior
Bitmap font should just be loaded and registered without errors.
Current Behavior
I get this runtime error
Uncaught TypeError: Cannot read property 'frame' of undefined
    at Function.registerFont (BitmapText.js:581)
    at parse (bitmapFontParser.js:5)
    at completed (bitmapFontParser.js:72)
    at Loader.bitmapFontParser (bitmapFontParser.js:89)
    at Loader.js:614
    at async.js:35

Steps to Reproduce

It doesn't always fail, might be related to browser cache. Please test with empty cache.
It doesn't seem to matter if I first try to load the image then fnt file.

Open https://codepen.io/markknol/pen/WKweKd
Open devtools
Observe error
If there is no error, add a space in the js, to re-run the pen. This triggers the error.

In general this is enough to reproduce
let options = { crossOrigin: true };
let loader = new PIXI.loaders.Loader();
loader.add("fnt", "font.fnt", options);
loader.add("png", "font_0.png", options);
loader.load();

Environment

pixi.js version: 4.8.1
Browser: Chrome 67
Device: _e.g. Desktop

It works for me. Console is clear.
https://codepen.io/ivanpopelyshev/pen/LBNERQ

Ok, explanation: second add it a problem. Workaround: just remove it.
This code produces an error if a texture resource exists, but loading is not completed yet: https://github.com/pixijs/pixi.js/blob/dev/src/loaders/bitmapFontParser.js#L95

fixed in dev.


python3Packages.lox: init at 0.11.0

Description of changes
I would like to be able to use the lox python library for nicer syntactic sugar for multi-threading+processing from within nixpkgs!
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

2 packages built:

python310Packages.lox
python39Packages.lox

This has switched checkInputs to nativeCheckInputs to satisfy the recent tree-wide change (#206742)!

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

2 packages built:

python310Packages.lox
python311Packages.lox

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

6 packages failed to build:

python310Packages.lox
python310Packages.lox.dist
python310Packages.lox.doc
python311Packages.lox
python311Packages.lox.dist
python311Packages.lox.doc


Implement rendezvous protocol spec

Implementation of spec in https://github.com/libp2p/specs/pull/44
Provides Client, Service, and Database for attaching and using rendezvous points in libp2p hosts and the necessary hooks for implementing federated rendezvous daemons out of package.
TBD:

[ ] docstrings
[ ] vendor sqlite in gx
[ ] README
[ ] CI

Summoning @whyrusleeping @Stebalien
CC @magik6k @dryajov @diasdavid

Why do we need sqlite here and can't just use the datastore?

@magik6k it does queries that are much easier to express and manage in SQLite than the datastore.

On CI - assuming ci team on github has access to this repo, you can enable jenkins by just creating ci/Jenkinsfile with golang() as content - like https://github.com/ipfs/ipfs-ds-convert/blob/master/ci/Jenkinsfile

Sure, let's have both travis and jenkins.

@vyzo think you can skip Travis, it's not giving us a lot of value right now and mostly used as a check that existing repositories gives the same status on Travis as on Jenkins.

Sure, didn't know we were sunsetting travis; less work to do :)

Finetuned the behaviour of persistent client registrations on refresh errors; it now uses exponential backoff instead of blindly waiting for another ttl.

does the service do period sweeps to clean up expired entries? I couldnt find where that was happening if it is

I'd also love to get some metrics plugged in here so we can observe it more easily

Sure, that's a good suggestion. What should I utilize for this?

Pushed WIP stateful client so that I don't lose it or forget about it.
Planning to:

implement stateful client that consistently handles registrations and possibly caches discovery results for quick, randomized access to the peer set.
add rate limiter to the service, with an E_UNAVAILABLE status code prompting client backoff.
add metrics collection to the service

For metrics use https://github.com/ipfs/go-metrics-interface, go-ipfs by default installs https://github.com/ipfs/go-metrics-prometheus to expose it using Prometheus protocol.

Review would be nice, I plan to restart work on it soonish -- see the further work comment.

Hey @vyzo – wondering what you have in mind as a path forward here. Is this implementation already 100% compliant with our flashy new Rendezvous spec?

@raulk yes, it's 100% compatible with the spec. It needs rate limiting to emit the E_UNAVAILABLE response though and I need to figure out how to do federation (although the federated daemon will be a separate package).

@vyzo — cool. How about we figure out the error case and we merge this in marking it as EXPERIMENTAL? No point keeping it parked in a PR.

I also want to work a bit on the stateful client, but we should be able to merge soon.

The federation can wait for the out of package daemon implementation.

I'll work a bit more on it this week.

@vyzo when are you expecting this will be checked in?

soon [TM]

Is this in a place to be reviewed/merged @Stebalien @Kubuxu?

Is this in a place to be reviewed/merged @Stebalien @Kubuxu?

For anyone continuing this pull request, please note that the specification had multiple revisions in the meantime.


Make spell checker package optional

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
Latest
Steps to reproduce
The simple_spell_checker package should be optional, it has ballooned my app from sub 70mb to >150mb, adding around 80mb more.
From what I can tell this is because of all the language dictionaries:

My suggestion would be to just make platform specific api calls. Apple for example provides https://developer.apple.com/documentation/uikit/uitextchecker for iOS. Android and other platforms should have equivalent apis.
Expected results
Small app size
Actual results
Large app size
Code sample
No response
Additional Context
No response

The idea of this spell checker is to be a client-side service. But the size is a problem... For now I prefer to see what other developers suggest to avoid this.

The idea of this spell checker is to be a client-side service. I'm interested in knowing how we can make it optional, can you explain about it?

Both Apple and Google apis are client side. I would expect Microsoft to have an equivalent api for Windows. No idea about the web, but having the package as a hard dependency there wouldn't be a problem, as the code lives server side.
My problem, when it primarily comes to mobile devices, is that the package is trying to reinvent the wheel. That's why I would prefer direct api calls to the platform provided apis.

iOS: https://developer.apple.com/documentation/uikit/uitextchecker
Android: https://developer.android.com/develop/ui/views/touch-and-input/spell-checker-framework

My suggestion for a temporary solution would be to separate the package and make it standalone without it being a hard dependency of flutter_quill_extensions. And just point developers to the package if they need spell checking.

@EchoEllet @singerdmx what do you think? Should we move any implementation of simple_spell_checker to the example app to avoud this?

do you think? what do you think? Should we move any implementation of simple_spell_checker to the example app to avoud this?

Yes, we could separate this feature in its own package that depends on simple_spell_checker, which has Flutter Quill specific code, or you could make the package only for flutter_quill which will require more steps to use the package without flutter_quill as a dependency.
Or we could make it specific for the example app.
As for the bundle size, we have already discussed this. However, we should have mentioned this in the CHANGELOG regarding the bundle size, users already using the package and don't expect such change in a minor update, we can't make another major release either.
@CatHood0 I can handle this since it it doesn't require changing much or leaving it up to you to decide.
I prefer to keep the flutter_quill_spell_checker package (which haven't been created yet) in the same repository as simple_spell_checker so you can get more control and publish releases without submitting PRs to this repository. Creating a new package in this repository is an option as well.

@EchoEllet then I leave you in your command. Thank you!

I will start as soon as I can. It might be 1-2 days before I do.

I have tried SpellCheckerSession on Android (platform-specific API) and in my case, it didn't work quite well, on the emulator it takes longer than expected to return the result, on a real device (I have used only one that's Android 14) and it returns an empty list.

Flutter DefaultSpellCheckService didn't work at all for the emulator and real device.
I haven't looked into this issue much however we can probably implement it only on iOS and Android using system API.

the package is for those who want to manage the state of the language within the service without use the language that comes from the system

Can you clarify what you mean by this?

in Flutter's native SpellCheckerService it is not possible (not that I have seen)

Did you try it on Android or iOS?

I noticed that this could be useful. I was made a similar suggestion to have simple_spell_checker also have an instance that uses the native system services (in case of IOS or Android). I haven't taken the time to do this yet, but it's on my list of things I could do

Can you clarify what you mean by this?

This part refers to the fact that we can handle languages not only created by the users themselves (through the LanguageIdentifier class) but it also allows us to change at any time to a language that the operating system is not using. You can see it as if in Word, we changed the spell checker from English to Italian, even if the system is not using these languages. i clarify that i don't know if this same thing is already allowed with Flutter's native SpellCheckService service, although as far as I looked, there was nothing like that.

Did you try it on Android or iOS?

I tried it only on Android. Unfortunately I don't have the availability to use an iOS device, but still at no time was I able to get either a TextField/TextFormField or an EditableTextLine to work as I expected. I tried with or without an internet connection, and at no time did it give me results. But, as I said above, maybe it was some bad configuration on my part.

This part refers to the fact that we can handle languages not only created by the users themselves (through the LanguageIdentifier class) but it also allows us to change at any time to a language that the operating system is not using. You can see it as if in Word, we changed the spell checker from English to Italian, even if the system is not using these languages.

It's already possible to choose a different local than the system default, I haven't tried it out before though.

Flutter's native SpellCheckService service, although as far as I looked, there was nothing like that.

I tried DefaultSpellCheckService and wasn't able to get it working at all while it uses the same API that I used in native Android using MethodChannel.

It's already possible to choose a different local than the system default, I haven't tried it out before though.

Thanks for letting me know. I'll take a look at it as soon as i can, as i might be able to make some kind of weird monster between the native and the implementation i created to eliminate the problem i have with the package's heaviness.

I tried DefaultSpellCheckService and wasn't able to get it working at all while it uses the same API that I used in native Android using MethodChannel.

I really think it might be a Flutter issue that this aspect is not working properly. Could it be that internally the service is not being used even if we pass it in the parameters?

Could it be that internally the service is not being used even if we pass it in the parameters?

I forgot to mention that I used fetchSpellCheckSuggestions(locale, text) directly without TextField or EditableTextLine.

I think we need to refactor our SpellCheckService a bit. We probably want to extends it from Flutter SpellCheckService.
This will require breaking changes which is a bit unfortunate, we need to make it experimental first by marking it with @experimental, adding docs comment, and in README for a while as I expect more breaking changes.


Request for php binding

Can you bring it to php platform?<!--
Thanks for filing an issue! If this is a question or feature request, just delete
everything here and write out the request, providing as much context as you can.
-->
What OS are you using (uname -a, or Windows version)?

What programming language are you using (C/C++/Go/Rust)?

What did you expect to see and what you saw instead?

Please see https://github.com/siara-cc/php_webview.  It is based on this repo and exposes most functions.


2022091301

Closes #7392
Closes #7394
Closes #7387
Closes #7388
Closes #7389
Closes #7396
Closes #7397
Closes #7398
Closes #7400
Closes #7401
Closes #7402
Closes #7404
Closes #7406
Closes #7407
Closes #7408
Closes #7409
Closes #7425
Closes #7412
Closes #7414
Closes #7415
Closes #7416
Closes #7421
Closes #7425
Closes #7488
Closes #7489
Closes #7490
Closes #7427
Closes #7428
Closes #7429
Closes #7491
Closes #7492
Closes #7432
Closes #7439
Closes #7454

No respite

Pls check #7427 cluster4 again.There are many innocent devices in it. Which are wrongly listed in this cluster.@
6CornerDefender

would you please cross check #7427 cluster 4 again. I think most of device in this cluster wrongly added by mistake. @6CornerDefender  @berserkrrr

@6CornerDefender @berserkrrr good day! Actually we also reviewed #7427 before (in my previous pr submission, unfortunately not approved yet), I think there are some items we could review again, for cluster 4, what we could generate hs list is as below, seems less than it shown in #7427, maybe you could re-check cluster 4 list and confirm it. Thanks. there is also few other submission like this, will reply our review and report one by one for your reference.

112FAbXbphEnnRLm816281omPGjn6qnH4TJojdLdAptxcKKBityC
11D7ZuzwT5VxYCkPiqyujUM9K29ynb41u6HTGwHz1hmKabT6479
11LPd1seA7A9hqnb7cBCMMXhtWys1RwD4MedVeHfW8vTKiaZRMY
112hEDRE7at3hJKEun5Lh4gFHdagZ4nMCLxpkFaSuTk3Q9mR75hY
112UsPbWyhZvq5Rykdtdx1745hmU8dA18zZCq2qgamPRGgUMFD3q
112rL4TZyj3XofdSVzAN9bjhgZps4YqJsBm7t4DSQb9aXxb3qwYh
112JwL2tyZGnyNtk6AvnUi5PT9TJPcPz9BcW1MqtXAP81ksRgxdu
112MSCPkVwgf6J3AQ2Wc5b8a27cgoEQ24t1GKNcq6NEQGbR7M8gT
117Yf7hmKLDGLiqZh6KBnTyPAEHx8VKgzRpXytzaXVT1wiXHENS
11vMYzg4sAt4kQapr3nxAdCgoYZvhcZLnkRguwrcoUyompzddEy
112t1sMcZegmTRJrcfsrYmGdXJePwXi4wjmE2RLtWDVrgSRWLTuN
11JQTPhfMT2w34AuHDCviGG9CFKQdqHq4BgCKgRXQmvTcNSfCe7
11Db2ndVmGVqHBoWhtaPKEZa49dVwAUDaC5FPWe1MDcQvVBwLWR

@6CornerDefender Maybe you should see this！
https://github.com/helium/denylist/issues/7641

@6CornerDefender @KXI1 Just for your reference, there is a dispute in cluster 4 list of #7427 , after we review and check again, we think the correct list for cluster 4 should be the list (115 hs) which @KXI1 provided in last comment of #7427, appreciate your time of checking again and revise list if needed.

Why are #7327 - #7335  - #7340 - #7341 - #7342 not included in this pull request? Does not seem to be of much interest to get all cheaters.

Why are #7327 - #7335 - #7340 - #7341 - #7342 not included in this pull request? Does not seem to be of much interest to get all cheaters.

There is a limit proceeding the issues (30/35 max); they will be added in the next PR for sure

https://github.com/helium/denylist/issues/7687
Whalit cheats. I live here, and I've had my device deployed in my old home for half a month, and I haven't been able to interact with them.

Why are #7327 - #7335 - #7340 - #7341 - #7342 not included in this pull request? Does not seem to be of much interest to get all cheaters.

There is a limit proceeding the issues (30/35 max); they will be added in the next PR for sure

That is good.

@6CornerDefender Please take a look at #7427, have some update need to revise list. #7427

@6CornerDefender Please take a look at #7427, have some update need to revise list. #7427

Stop trying to save your cheating HS. If it was added, it was cheating. Afterwards you can try to undenylist it. But keep out trying to change peoples mind.

Why does it always take one week to pull the list? Thank you.


Getting an error message ( in console ) on submitting the correct solution

Describe the Issue
When the user submits the correct solution for the Register a Store Listener module, then they end up with the following error message within the console:

Build error, open your browser console to learn more.

Given that the user is submitting the correct solution ( since all the unit tests are getting passed and // tests completed is getting printed in the console ), then showing such an error message ( along with other messages ) to the user could make them feel a bit confused.
Affected Page
https://www.freecodecamp.org/learn/front-end-development-libraries/redux/register-a-store-listener
Your code
const ADD = 'ADD';

const reducer = (state = 0, action) => {
  switch(action.type) {
    case ADD:
      return state + 1;
    default:
      return state;
  }
};

const store = Redux.createStore(reducer);

// Global count variable:
let count = 0;

// Change code below this line
function incrementCount(){
  return count++;
}
store.subscribe(incrementCount());
// Change code above this line

store.dispatch({type: ADD});
console.log(count);
store.dispatch({type: ADD});
console.log(count);
store.dispatch({type: ADD});
console.log(count);

Expected behavior
In order to avoid any sort of ambiguity and to keep things as clear as possible, I believe when the user submits their solution and if their submitted solution is entirely correct, then they should be getting the following messages only ( within the console ):

// running tests
// tests completed

Screenshots

System

Device: Laptop
OS: macOS 13.0.1
Browser: Chrome
Version: 107.0.5304.110

Hi, @AnonSar, thanks for the report. The code you shared does have a small bug - it should be
store.subscribe(incrementCount); // not incrementCount()

since subscribe expects to be passed a function.
That said, there are a few things going wrong in the client:

The error should be reported, but it's not appearing in either the fcc or browser consoles
The 3rd test should fail because it's not receiving a function

hey!!! @AnonSar   Is the issue still open ????


fix(fetch): fix trace correlation for native fetch for Node.js >= 20.8.1

refs 146305

I deliberately temporarily removed the commit that moves Node 20 to other-nodejs-versions from this branch to have the test also run against Node 20 directly. Will update the CI Node.js version from 20.3 to 20.9 later, to have runs for a version <= 20.8.0 and >= 20.8.1.
Locally, I ran the fetch suite successfully with Node.js version 18, 20.3.0, 20.8.0, 20.8.1 and 20.9.0.

CI test run with Node.js 20.3 with successful native fetch tests: https://app.circleci.com/pipelines/github/instana/nodejs/7342/workflows/d4fe2fba-270a-474f-b655-d37aa5072cd5/jobs/24286 (there were unrelated failed tests for DB2).
CI test run with Node.js 20.9: https://app.circleci.com/pipelines/github/instana/nodejs/7350/workflows/a89069e9-1d01-4204-81ea-608dac40a761/jobs/24303


DPL-445  - To aid clarity could the  ‘Chromium single cell surface protein’ library type be amended to ‘Chromium single cell surface protein (CITE-seq)’

User story
To aid clarity could the  ‘Chromium single cell surface protein’ library type be amended to ‘Chromium single cell surface protein (CITE-seq)’
Who are the primary contacts for this story
Matt
Acceptance criteria
To be considered successful the solution must allow:

[ ] The library type Chromium single cell surface protein (CITE-seq)’ should be available
[ ] ...

Dependencies
This story is blocked by the following dependencies:

#<issue_no.>
sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

#<issue_no.>
sanger/#<issue_no.>

Additional context
Add any other context or screenshots about the feature request here.

On DPL-442 - https://github.com/sanger/limber/issues/1129 - it has the following:
Chromium single cell surface protein (CITE-seq) HT

should there be an 'HT' on the end or not?

Both
Chromium single cell surface protein (CITE-seq)
and
Chromium single cell surface protein (CITE-seq) HT
Brackets exist in other library types so that should be fine.
NPG need to know about change.

Updated to add the 'manual' prefix, as per email chain "RE: 10X Genomics LIMS changes for Bespoke"

Decided not to change to add Cite Seq as it might be confusing.


Allow iterators for PGN parsing

I'm using this library as a helper for feeding data to a machine learning model. To that end, I need to be able to iterate over games in a PGN (as opposed to parsing in bulk).
In my code, I do something like this:
class StepParser : pgn::StreamParser<> {
public:
    explicit StepParser(std::istream& stream) : StreamParser{ stream } {}

    bool initRead(pgn::Visitor& vis) {
        visitor = &vis;

        if (!stream_buffer.fill()) {
            return false;
        }
        return true;
    }

    void finishRead() {
        if (!pgn_end) {
            onEnd();
        }
    }

    bool readNextGame() {
        while (auto c = stream_buffer.some()) {
            if (in_header) {
                visitor->skipPgn(false);

                if (*c == '[') {
                    visitor->startPgn();
                    pgn_end = false;

                    processHeader();
                }

            }
            else if (in_body) {
                processBody();
            }

            if (!dont_advance_after_body) {
                stream_buffer.advance();
            }
            dont_advance_after_body = false;

            if (pgn_end) {
                pgn_end = false;
                return true;
            }
        }
        return false;
    }
};

On the library side, I had to switch several members of StreamParser from private to protected.
This is all quite a bit of a hack, so I'm wondering if there is potential for official support to be able to iterate over games.

Sorry I don't quite understand what your problem is. A *.pgn file can consist of multiple individual pgn's, and this parser is able to parse all games in the *.pgn file. The startPgn will be called at the start of a new pgn inside the pgn file and the onEnd when it ends. A sample implementation is here https://github.com/official-stockfish/WDL_model/blob/master/scoreWDLstat.cpp, where we are running the parser over multiple pgn files, which themself consist of additional pgns.

Ah, sorry if I wasn't clear. I want a function I can call (as opposed to a callback) that will parse a single game from a PGN. In pseudocode, it would look something like:
parser = SetUpParser( pgnpath )
game1 = parser.parseNextGame()
game2 = parser.parseNextGame()

I see, I might add this but I’m not sure about returning a game object.


Get withdrawal fee

I can't find an API to get withdrawal fees for a coin. Is it implemented?

No, officially it is not supported. You should fork the official implementation and extend Withdraw class with transactionFee attribute. Afterwards you can use it in your code.


Resolve "Add Mobile Device Control" - [merged]

Merges 17-mobile-control -> main
Closes #17

In GitLab by @schexi on May 7, 2024, 13:02
added 17 commits
1c520c7e...e6b9503e - 16 commits from branch main9e1cad04 - Resolve merge conflicts #17
Compare with previous version

requested review from @alexkhval

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/activities/remote/Remote.java line 64
Magic numbers should be fixed. Also the code seems repetitive, is there a way to make it more robust?

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/activities/remote/Remote.java line 42
Is this a temporary config implementation?

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on terminal/terminal.ino line 247
8192 is a magic number and should be defined as a macro

In GitLab by @alexkhval on May 7, 2024, 13:53
App connection to the WIO terminal tested, occasional bugs occur when the app does not send any MQTT messages on a button press. Additionally a bug on a terminal side occurs when it does not receive the messages and the terminal needs to be restarted.
Needs to be fixed on a separate branch.
Overall nice implementation of the mobile device control! :thumbsup:

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/activities/remote/RemoteRecyclerAdapter.java line 70
Magic number

Yes, will be replaced by the device selection feature that is not a part of this issue.

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/activities/Setup.java line 129
Nice code reusage

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/configurations/Configuration.java line 58
Don't forget to mention the format in the documentation

In GitLab by @alexkhval on May 7, 2024, 13:53
Commented on app/src/main/java/se/gu/wiomote/network/WioMQTTClient.java line 39
Nice use of constants!

In GitLab by @albu-razvan on May 7, 2024, 13:55
Commented on app/src/main/java/se/gu/wiomote/activities/remote/RemoteRecyclerAdapter.java line 70
This will be replaced by the size of the custom configuration button list.

In GitLab by @albu-razvan on May 7, 2024, 13:55
Commented on app/src/main/java/se/gu/wiomote/activities/remote/Remote.java line 64
You could make a list with every view, id and published message, but for this context it doesn't make sense since we'll already have a predefined button to command map later on.

In GitLab by @alexkhval on May 7, 2024, 14:19
mentioned in commit 890867a1e39ed81473efebd2c851a8baa7c860f0

In GitLab by @alexkhval on May 7, 2024, 14:19
approved this merge request

In GitLab by @albu-razvan on May 7, 2024, 14:19
Commented on terminal/terminal.ino line 247
We'll add a definition in the next commits.


Bump @vitejs/plugin-vue

Summary
Bumps @vitejs/plugin-vue to prevent the vite build failure experienced locally.
Test Plan
npm run serve should build successfully after npm install.

ran the test plan, works properly


Cannot downlaod the Shapenet dataset with norml.

The link provided in the DATASET.md seems only contain the ScanObjectNN_hardest_fewshot.tar. How can I get the shapenet with normal? Thanks.

The shapenet dataset is deleted due the limited store space. You can create the required dataset with the code: https://github.com/YBZh/MaskSurf/blob/main/point2normal_curve.py


Add error message for missing parameter-less constructor

Previously, weaving just failed with an InvalidOperationException that did not point to user code

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


trident-operator fails to patch trident-csi ClusterRole in 20.10.0 upgrade

Describe the bug
We recently upgraded from 20.07.1 to 20.10.0 and noticed all volume attachments stopped working. The operator failed to patch the trident-csi ClusterRole to include volumeattachments/status RBAC: https://github.com/NetApp/trident/commit/260c6ab457cca5149dd142f1d4d6ea23ed16e346
However the operator logs don't mention any errors:
time="2020-12-07T12:00:38Z" level=info msg="A Trident cluster role named 'trident-csi' was found by label."
time="2020-12-07T12:00:38Z" level=debug msg="Patching Trident Cluster role." clusterRole=trident-csi

I believe the current logic is flawed, as it doesn't check the patch status/error:
https://github.com/NetApp/trident/blob/master/operator/controllers/provisioner/installer/installer.go#L969
Environment

Trident version: 20.10.0
Trident installation flags used: --debug
Container runtime: cri-o://1.19.0-24
Kubernetes version: v1.19.0
Kubernetes orchestrator: OpenShift v4.6
OS: Red Hat Enterprise Linux CoreOS 46.82

To Reproduce
Install trident 20.07.1 and upgrade to 20.10.0. Check if trident-csi ClusterRole was patched with volumeattachments/status permission.
Expected behavior
Operator should patch the trident-csi ClusterRole, handle any errors and log accordingly to help the user debug and fix the issue.

Opened https://github.com/NetApp/trident/pull/492 for better debugging

Hello @adrianchifor
Thanks for bringing this to attention, certainly there is a need to add a log statement after the patch and return err instead of nil. Would appreciate if you share more details on how you ran into this issue.

Did you run into this issue during an upgrade or post-upgrade?
Do you have the error that was thrown during the patch operation?
Are you using tridentImage attribute in your CR to set a custom image?

The reason I am asking this is that, during upgrade from 20.07.* to 20.10.0, all the Trident objects (except for the CRDs) are deleted and re-created and not patched. However, if you have a tridentImage attribute in your CR the imagePrechecks run to verify that you have supplied a valid Trident image with the correct Trident version, and that is when cluster-role patch may have been called. imagePrechecks is a step just before the upgrade and only runs when you have supplied a custom image via tridentImage.

post-upgrade
no error as it's not handled
custom image yes (our docker.io mirror)

This is fixed with commit a0712e and is included in the Trident v21.01 release.

This is fixed with commit a0712e and is included in the Trident v21.01 release.


Fix for base_url bug

Refs:

#18

Thank you! will push a new release after merging

I just missed pushing my test for this - I'll push it straight to main instead.


Sometimes Error is "" instead of nil

Your Question
if res = db.Save(&msg); res.Error != nil {
    log.Error(err)
    return
}

I have simple code which is update row in database, but time-to-time it gives me \u003cnil\u003e (<nil>) instead of nil. Any reason or any experience who have ?
Database: CockroachDB
Connection: postgres connstring

The document you expected this should be explained

Expected answer
Return always nil instead of "<nil>"

Its because schema doesn't allow it.
SQL Error [23505]: ERROR: duplicate key value violates unique constraint "table_column_idx"
Detail: Key (column_name)=('XXXXXX') already exists.
It gives me "", not actual error.
Want to report it.

I got this answer from Dbeaver, but in gorm there is no such chance for catch it.


FG-5079: Update Stream Service Probes

Public-Facing Changes
Updates Stream Service probes to allow for a longer window before terminating the pod.
Description
The default failureThreshold for Kubernetes probes is 3, meaning the stream service would be terminated after ~12 seconds of not responding to requests. This change ups that threshold to 10 failures before the pod is removed from taking requests and 20 failures before it is terminated.

@foxglovenes we'll want to update the hash to<PHONE_NUMBER>a7f0227e7e764f4dd6c0698876e6ed now and wait for the next rollout


iOS App Features

[ ] Sort out scrolling (UIScrollview?)
[ ] Double tap, becomes tab
[ ] Map touches to mouse events
[ ] Terminal-bar (escape, control, alt, settings)
[ ] Swipe gestures to send up/down/left/right

I'm experimenting with putting in a layer between Terminal and TerminalView for producing NSAttributtedString in a way that can be used in UITextView which would support scrolling and text selection.
Not sure if this is a good idea but seems worth a try.

I’d like to port my app NewTerm over to SwiftTerm. It’s a jailbreak terminal app, originally based on MobileTerminal (which is almost as old as the iPhone itself!) and using a fork of iTerm (not iTerm2) as the emulator. I’ve planned to shift away from the ancient and broken emulator, and give it an SSH backend for release on the App Store. Porting xterm.js to Swift was a project I started working on, but you’ve definitely gotten way further than me on that 😁
Is there anything of interest that I could work on or provide here? I have some ideas on some UI aspects. I’ll be relicensing NewTerm under Apache License 2.0 once all GPL iTerm code has been removed. No original MobileTerminal code remains anywhere but in the Common/VT100/ directory.

I'm experimenting with putting in a layer between Terminal and TerminalView for producing NSAttributtedString in a way that can be used in UITextView which would support scrolling and text selection.

To make it 1:1 we'd need to move from CoreText to TextKit (TextKit API is pretty annoying in comparison). There's a couple of problems to solve on the way.

Apologies, I only saw this comment now.
On scrolling: I had some early bits in place, I committed them now, where I made the terminal view be a subclass to UIScrollView - I am not attached to this model, we can try other approaches.
I think this is a good match, but I need to think further.   The reason why I think this works is because the scroll buffer grows, and I would not want to render the entire back-scroll, I would like to render the back scroll on demand.
I do not know much about UITextView as a backing engine for this, will need to research what this means.
For Sixel graphics, I think that we could flag a cell as having an image, and then the rendering code that is in place today would paint the image instead of adding this to the CTRun.
@kirb: In terms of what you could work on, any of the above gestures would work.    I collected some of those from using terminals in the past and felt like these would be useful.
As an aside, I started putting my SwiftUI muscles to practice so we can remove that hardcoded "Miguel" login name, password and my localhost IP address to test.   Here are some screenshots, I can put them here, but did not want to land code in such unbaked state, but if you folks want to help, I don't mind putting it here.

(btw, apologies in advance - I am terrible at reading GitHub comments, because I am still trying to create filters to remove legacy notifications that keep spamming me).
Usually @krzyzanowskim has pinged me on twitter if there is something to look at.
I promise I will look into fixing my GitHub notifications soon.

I posted my work in progress here: GitHub.com/migueldeicaza/SwiftTermApp


Wrong path to the project cloning HTTPs, in the installation section.

Hi Oscar,
In the installation section, you give the command git clone https://github.com/OscarPellicer/Deep-Learning-in-Prostate-PhD.git to clone the project. This gives an error, the "in" is left out. The correct path is https://github.com/OscarPellicer/Deep-Learning-Prostate-PhD.git.
Best regards!

It was the name of the repo itself that was wrong 😅
It should now be fixed


Add support for -march in onnx-mlir

Currently onnx-mlir has -mtriple and -mcpu, however it lacks -march. For completeness and flexibility this PR adds -march as well.
This addresses issue https://github.com/onnx/onnx-mlir/issues/797

One thing to consider is that the triple is usually a combination of the arch and cpu, so if someone is passing triple + arch/cpu, it's probably a mistake. Are there cases today where they are both passed?

One thing to consider is that the triple is usually a combination of the arch and cpu, so if someone is passing triple + arch/cpu, it's probably a mistake. Are there cases today where they are both passed?

@sstamenova on our z machines, we need to pass -mtriple=s390x-ibm-loz -mcpu=z15 where the first one say the machine family/company/os and the second say the specific version of the machine. So for Z machines, both options are needed if we want to generate for an ISA of a particular type (say z15). The triple would be different if we were targeting another os on the same machine, say zOS.

Can you comment on the use of cpu vs arch, and how we should use it (eventually) in ONNX MLIR

This is how I understand it (from llc perspective):

the -march flag is used to specify the target architecture, it allows the compiler to generate instructions that are part of the ISA of the target architecture. For example -march=x86-64 would instruct the compiler to generate instruction that run correctly on any processor that implements the x86-64 microarchitecture.
the -mcpu flag  is used to specify a particular processor, for example --mcpu=pentiumpro and would allow the compiler to schedule instructions specifically for that processor.

Within onnx-mlir we can use -march and -mcpu to determine whether the target machine support SIMD instructions (for example).

I agree with that interpretation. Would you mind pasting it in the code so that we may use as a reference for the future, thanks

For that we need to first set the target triple in the MLIR module.  Fortunately MLIR allows annotation of a module operation with attributes (in fact that is how we already set the data layout).  The relevant info is here https://mlir.llvm.org/docs/Dialects/LLVM/#data-layout-and-triple
Once a module has the triple annotation we can then use it to retrieve the target architecture. This is how we can do it:
      auto targetTripleAttr =
          module->getAttr(LLVM::LLVMDialect::getTargetTripleAttrName());
      StringRef targetTriple = targetTripleAttr.cast<StringAttr>().strref();
      llvm::Triple triple(targetTriple);
      llvm::Triple::ArchType targetArch = triple.getArch();

The LLVM Triple object allows other queries (we can retrieve the target OS and/or the vendor name if necessary).
Having the target arch the lowering code of any operation can then determine whether it can generate certain instructions (e.g. SIMD instructions).

The LLVM Triple object allows other queries (we can retrieve the target OS and/or the vendor name if necessary).
Having the target arch the lowering code of any operation can then determine whether it can generate certain instructions (e.g. SIMD instructions).

As I said before, triple is not sufficient to identify an arch for some targets. E.g. Z's arch is loz, and we need the -mcpu on Z to identify the actual ISA (e.g. z13, vs a14,..)

I have opened PR

The LLVM Triple object allows other queries (we can retrieve the target OS and/or the vendor name if necessary).
Having the target arch the lowering code of any operation can then determine whether it can generate certain instructions (e.g. SIMD instructions).

As I said before, triple is not sufficient to identify an arch for some targets. E.g. Z's arch is loz, and we need the -mcpu on Z to identify the actual ISA (e.g. z13, vs a14,..)

That is unfortunate. At least in principle an architecture should match an ISA. Knowing the precise target ISA would be sufficient to determine whether SIMD instructions are part of the ISA.
AFAIK the MLIR module can accept only the triple (as an attribute) ... so we will have to find another mechanism to encode the setting of mcpu in the module or pass a flag to the lowering pass to communicate the mcpu value.

Jenkins Linux s390x Build #3402 [push] Add -march option to onn... started at 19:02

Jenkins Linux amd64 Build #3410 [push] Add -march option to onn... started at 18:02

Jenkins Linux ppc64le Build #2518 [push] Add -march option to onn... started at 19:09

Jenkins Linux amd64 Build #3410 [push] Add -march option to onn... aborted after 31 min

Jenkins Linux ppc64le Build #2518 [push] Add -march option to onn... aborted after 32 min

Jenkins Linux s390x Build #3402 [push] Add -march option to onn... passed after 51 min


NumPy 2.0 support

Problem description
NumPy 2.0 is coming out soon ( https://github.com/numpy/numpy/issues/24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( https://github.com/numpy/numpy/issues/24300#issuecomment-2030603395 )
Feature description
To prepare for NumPy 2.0, it might be worthwhile to start testing Dask against NumPy 2 in CI
Also as NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share Dask's current support status in issue (with any plans): https://github.com/numpy/numpy/issues/26191
NumPy has put out a migration guide. More details are in the release notes. As Dask doesn't have C/C++ usage of NumPy, only the Python changes would be relevant
Additional information
Maybe Distributed needs similar considerations

Looks like some work occurred in these PRs:

https://github.com/dask/dask/pull/10549
https://github.com/dask/dask/pull/10819
https://github.com/dask/dask/pull/10821
https://github.com/dask/dask/pull/10831
https://github.com/dask/dask/pull/10837
https://github.com/dask/dask/pull/10854

Running the dask.array test suite locally, am seeing a few test failures
FAILED dask/array/tests/test_array_core.py::test_broadcast_arrays - assert () == []
...
FAILED dask/array/tests/test_routines.py::test_atleast_nd_no_args[atleast_3d] - assert () == []
...
FAILED dask/array/tests/test_routines.py::test_atleast_nd_two_args[shape10-shape20-atleast_3d] - AssertionError: assert <class 'tuple'> is <class 'list'>

These happen with variations of parameters for each test. So are likely not specific to those parameters

Thanks @jakirkham. We have a nightly upstream CI job that tests against the nightly dev version of numpy (and other packages). Unfortunately it's failing right now (example job) due to an ImportError being raised during the test suite setup.

Likely need similar fixes as PR ( https://github.com/dask/dask/pull/10929 )

Thanks for tracking that down

@quasiben maybe this is something your team can help resolve?

There are a couple of things that break our upstream ci:

numexpr
numba
sparse

None of these work with NumPy 2 and makes the build fail at import time, uninstalling them gets at least the tests running, even though we have some failures
context https://github.com/dask/dask/pull/11086

Regarding NumPy 2 support for these packages

numexpr

Done in 2.10.0. Please PR: https://github.com/pydata/numexpr/pull/478

numba

Support to work with NumPy 2 is tentatively planned for Numba 0.60.0. Please see issue: https://github.com/numba/numba/issues/9544
Semantic support for NumPy 2 is tentatively planed for Numba 0.61.0. Please see issue: https://github.com/numba/numba/issues/9540

sparse

This depends on Numba. Looks like no major issues are expected here

We'd need numexpr 2.10 on conda forge (only 2.9 is available at the moment)

We'd need numexpr 2.10 on conda forge (only 2.9 is available at the moment)

Please see PR: https://github.com/conda-forge/numexpr-feedstock/pull/62
Looks like there are build issues that may need addressing

That said, conda-forge is still working on NumPy 2 bringup ( https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5790 ). So conda-forge packages built with NumPy 2 support are not yet available
Sounds like that is a requirement here as well?

No we are using nightlies for NumPy and a few other packages

How are those nightlies installed? Pip?
If so, may numexpr can be installed the same way?

I care mostly about getting the upstream build running again, we still need a volunteer to fix the tests. Feel free to push to my PR if interested or open a new one on top of it

I started poking at this and it's a little challenging to assemble an environment given many dask dependencies are still at the release candidate stage.  Below is how i got things going:
mamba env create -f ./continuous_integration/environment-3.11.yaml
mamba uninstall --force numpy pandas scipy numexpr numba sparse
python -m pip install pandas==2.2.2
pip install --extra-index-url https://pypi.fury.io/arrow-nightlies/ \
    --prefer-binary --pre 'pyarrow==17.*'
conda install -c conda-forge -c conda-forge/label/numpy_rc 'numpy==2.*' --force
python -c 'import numpy;print(numpy.__version__);import pandas;print(pandas.__version__);import pyarrow;print(pyarrow.__version__)'

2.0.0rc1
2.2.2
17.0.0.dev59

I started off small with a single test dask/array/tests/test_array_core.py -- only 9 failures!  These seem mostly to do with h5py .  Need to look into h5py numpy 2 support...
FAILED dask/array/tests/test_array_core.py::test_asarray_h5py[True-asarray] - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_asarray_h5py[True-asanyarray] - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_asarray_h5py[False-asarray] - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_asarray_h5py[False-asanyarray] - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_h5py_newaxis - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_h5py_tokenize - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
FAILED dask/array/tests/test_array_core.py::test_auto_chunks_h5py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Thanks Ben! 🙏
What happens if you pip install h5py?

h5py tess pass when installed from source

Looking at this recent upstream CI log am not seeing any NumPy 2 failures
Do see a couple upstream Pandas failures
Assuming I'm looking at the right log. Do we think this is now fixed?

I've not taken a detailed look at the NumPy 2.0 changelog, but all our tests are passing when run against the latest nightly build of numpy. Grepping through the codebase with git grep -5 NUMPY_GE_200 I also don't see us skipping / xfailing to temporarily get CI passing. Given that I'll close this issue -- folks should feel free to re-open if they're aware of something that's broken.


Can anyone tell me how to run this step by step because I don't have any knowledge of coding and what to use

Can you please help me to


Many pkgs are not used in requirements.txt

I found there are a lot of none-used pkgs in requirements.txt. This wastes a lot of time for installation. It would be better if it could be simplified

Slimmed requirements.txt in application  folder. Reduced docker container too a lot


Workaround to Issue Installing WebP Package

As pointed out by @RaphZufferey via email, installing Ptera Software's WebP dependency can be problematic on Windows. @RaphZufferey came up with the following useful workaround:

Download Visual Studio 2022 Community. Before installing, check the box to also install "Desktop development with C++" tools. The default installation options are okay.
Run pip install conan in the local Windows Terminal.
Run conan profile update "settings.compiler=Visual Studio" default in the local Windows Terminal.
Run conan profile update "settings.compiler.version=14" default in the local Windows Terminal.
If downloading the package via PyPI, run pip install pterasoftware in the local Windows Terminal. If you've forked or cloned the repository, instead run pip install -r requirments.txt.

This procedure worked for me while running PteraSoftware-2.0.0 on Windows 11.
I'll open a new issue on the WebP package's repository to see if this process can be automated during the package's installation.

Thank you to @anibali, who released a new version (v0.1.4) of pywebp that fixes this issue! I've updated the requirements.txt file to require using versions >= v0.1.4 in the new "trim" feature branch I'm working on. I will merge this feature into a new release of Ptera Software within a few days.


ToDo: standardize [Setting] information

"setting is under" - 9 instances + "settings are under" - 3 instances
eg: [SETTING] Options>Search>Provide search suggestions

yes, but only if the setting is really not 'under' somewhere/something but is the actual setting-name to enable/check/whatever. fe. I would leave These settings are under Options>Privacy>Location Bar as is.

too late .. i've gone ballistic

also, since they plan to re-do the whole Options layout/design maybe we better wait with changing this until then.

lol, okay, too late ;)

also, since they plan to re-do the whole Options layout/design maybe we better wait with changing this until then.

Yeah, and that may never happen. But in any case, it's easy now to search & replace

I also standardized [TEST] lines

@earthlng I know how valuable an html version is for links and color coding - its why I provided one at ghacks. The standard method of how I typed things up made it fairly easy to create with a handful of search & replace strings.
We currently have [SETTING] and [TEST], [NOTE] so just throwing this out there, should we also use one or more for references (I know its easy to linkify without it). Would it be beneficial to designate #Required reading and differentiate bugzilla links? Or just use a [REF], maybe use [BUG] to keep the length the same
eg
/* 0805: disable CSS querying page history - CSS history leak - PRIVACY
 * [NOTE] this has NEVER been fully "resolved": in Mozilla/docs it is stated it's
 * only in 'certain circumstances', also see latest comments in the bug link
 * [TEST] http://lcamtuf.coredump.cx/yahh/ (see github wiki APPENDIX C on how to use)
 * [REF] https://dbaron.org/mozilla/visited-privacy
 * [REF] https://developer.mozilla.org/en-US/docs/Web/CSS/Privacy_and_the_:visited_selector
 * [BUG] https://bugzilla.mozilla.org/show_bug.cgi?id=147777 ***/
user_pref("layout.css.visited_links_enabled", false);

It would only be useful if we generated an HTML version, where it would be easy to span/color-code the tags eg [WARNING] = pale red background, black text. [NOTE] could be pale orange since they're like minor warning, [TEST] could be pale blue. [REF] could be pale green and [BUG] a brighter green.
Just an idea, may be overkill. I mean links would be linkified anyway and stand out

Idk, I don't really like it. The bugzilla links are easy to spot and doesn't always mean it's a bug. They also use "bugs" or more appropriate "tickets" to implement new stuff.
We could use [1], [2], etc. Then we could use them to do this also see latest comments in [3]
And as you said links would be linkified anyway and stand out

totally get bugzilla is software tracking (new features etc), and yeah, [bug] is stupid, so is [ref]
So every ref has a [1] [2] .. etc, starting a new per pref number - so should we do this? Or drop it. Only really makes sense if we use it later on for a smooth html color scheme

so should we do this

sure, I like it :thumbsup:

alrighty .. coffee time and then I'm onto it


Export SimHWInterface for combined_robot_hw

It is surprisingly useful to have a purely kinematic simulation of a hardware interface in a combined_robot_hw. Using a custom adapter i already used it to allow for partially-simulated execution in a more complex combined_robot_hw setup, and it generally makes switching between real hardware and simulation in such projects much easier. I would however prefer this to be an upstream feature of ros_control_boilerplate (and am happy to provide a PR for it) for the following reasons:

It would demonstrate how to properly write and export a hw interface using pluginlib
Adding a launch file to rrbot_control could demonstrate how to use a combined_robot_hw
It can be quite handy to use this as a placeholder when developing bigger combined_robot_hw setups

Unfortunately i don't think simply changing SimHWInterface (or GenericHWInterface) would be possible without quite some restructuring, as pluginlib requires a parameterless constructor. Thus i would create an extra adapter class deriving from hardware_interface::RobotHW which would hold a SimHWInterface as a member and delay it's construction until init(), simply delegating all relevant calls from there on.
The way i see it the required steps for this are:

[ ] Create CombinedHWAdapter class
[ ] Export interface correctly as ros_control_boilerplate/SimHWInterface
[ ] Add node src to rrbot_control. Unfortunately running a combined_robot_hw from a GenericHWControlLoop doesn't seem too nice.
[ ] Add sample launch files to rrbot_control
[ ] Add short description to README.md

I'm happy to hear about opinions, otherwise i'd start implementing this in the next days.

I have just stumbled over this issue after opening PR #42 which is intended to bring support for combined_robot_hw.
Definitely agree that an adapter could be a good solution. More concerns and ideas can be found in the PR, I don't want to cross-post too much.


Performance/HashEachMethods matches non-hashes

The change in 0.50.0 for Performance/HashEachMethods causes it to match on non-hashes where the block takes 2 args.
Expected behavior
On the following, no cop failure should be reported:
❯ cat test.rb
foo = [
  [1, 2],
  [3, 4]
]

foo.each { |a, _| puts a }

Actual behavior
A failure is reported:
❯ rubocop test.rb
Inspecting 1 file
C

Offenses:

test.rb:6:5: C: Use each_key instead of each.
foo.each { |a, _| puts a }
    ^^^^

1 file inspected, 1 offense detected

Steps to reproduce the problem
The above code sample should be able to reproduce this
RuboCop version
❯ rubocop -V
0.50.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin16)

That's unavoidable and unfixable due to the nature of Ruby. We can't really tell apart a hash from something that looks like a hash. You should either disable the cop or simply using # rubocop:disable for such relatively rare situations.

It doesn't end up being very rare, given that a handful of common Hash methods themselves return an array of 2-length arrays:
❯ rubocop -V
0.50.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin16)

❯ cat test.rb
hash = { foo: 1, bar: 2, baz: 3 }

hash.select { |_, v| v.odd? }.each { |k, _| puts k }

❯ rubocop -D test.rb
Inspecting 1 file
C

Offenses:

test.rb:3:31: C: Performance/HashEachMethods: Use each_key instead of each.
hash.select { |_, v| v.odd? }.each { |k, _| puts k }
                              ^^^^

1 file inspected, 1 offense detected

hash = { foo: 1, bar: 2, baz: 3 }

hash.select { |_, v| v.odd? }.each { |k, _| puts k }

Not sure what you mean. Hash#select returns a hash. 🤔 The only method on Hash I know of which returns an array of two-element arrays is Hash#to_a. The good news is we can check for that! As long as it's chained.
In the end, because we don't know what something is at runtime, we need to work with trade-offs. I'm inclined to think hashes are more common than arrays of two-element arrays. If it's not the case for your project, then there are tools to disable selectively or altogether. 🙂

In 0.50.0 I'm seeing HashEachMethods ask me to call each_key on an ActionController::Parameters, but Parameters does not respond to each_key.
app/controllers/redacted/redacted_controller.rb:69:25: C: Performance/HashEachMethods: Use each_key instead of each.
      params[:redacted].each do |id, _attributes|
                        ^^^^

(snapshot.to_a - last_snapshot.to_a).each do |file, _mtime|
  @changes[file] = last_snapshot[file] ? :updated : :created
end

:confused:

In 0.50.0 I'm seeing HashEachMethods ask me to call each_key on an ActionController::Parameters, but Parameters does not respond to each_key.

I'm inclined to make a PR to Rails regarding this, actually. The Parameters object basically just delegates to an underlying hash, and already delegates #keys, #key? and #has_key?. Looks like an oversight that it doesn't also delegate #each_key.

(snapshot.to_a - last_snapshot.to_a).each do |file, _mtime|
  @changes[file] = last_snapshot[file] ? :updated : :created
end

@AlexWayfer I'd change the code to:
(snapshot.to_a - last_snapshot.to_a).each do |(file, _mtime)|
  @changes[file] = last_snapshot[file] ? :updated : :created
end

I know that's it's more or less the same thing, but I like denoting that I'm explicitly breaking one argument apart when dealing with arrays and this won't be flagged by RuboCop as a bonus.

Same goes for @akerl's example.

@bbatsov: Never thought of that. 🤔 I think it's good enough to go in the style guide!

@bbatsov OK, thank you.

In 0.50.0 I'm seeing HashEachMethods ask me to call each_key on an ActionController::Parameters, but  Parameters does not respond to each_key.

I'm still seeing this issue in rubocop 0.51.0 + rails 5.1.4. I have disabled this cop for now.

I'm inclined to make a PR to Rails regarding this, actually. The Parameters object basically just delegates to an underlying hash, and already delegates #keys, #key? and #has_key?. Looks like an oversight that it doesn't also delegate #each_key.

Works for me, Ted. Did this PR to rails ever happen? If not, I can probably do it.

FYI @jaredbeck, for the ActionController::Parameters you can use the each_pair method (each is just an alias to that anyway) and avoid catching up the HashEachMethods cop


Field parameter preview feature not included in any release schedule

Hi there, the company our team is working for is trying to use the field parameter preview feature, we have tested and we found it very useful, but my organization won't deploy anything that is marked as a preview feature.  We have also checked the future release calendars and this feature is not present in any of them. Could you please confirm that there are good possibilities to be released and also a timeframe where this to happen? Thanks

Thanks for your comment, @jlteranl. This issue has been assigned to the doc author for review.

Thanks for your comment, @jlteranl.
This looks like a product question rather than documentation feedback.
You might find an answer in the Power BI Community. If not, try our support page.


Introduce Versioning to the Watcher

Description
Now watcher should be ready to release on PROD, but we still lacking of the process to alignment watcher versioning on Lifecycle manager release.
The Release Process concludes with the following:

Only keep on branch main; no release branches
Release always from main
Introduce semantic versioning incl. Release notes
No regular releases

ACs

[ ] Introduce Prow release pipeline triggered using tags

[ ] You can use CLI prow pipeline as inspiration rel-kyma-cli
[ ] Align with team Neighbours how to tag image with semantic versioning (hint)
[ ] Stick with prow to build image, since this has signing mechanism

[ ] Release notes should be created automatically using goreleaser

[ ] hint using similar as make target and called in pipeline

I think the ACs for the goreleaser are not relevant anymore. We can't use the same process as the CLI, we have to use secured environment for building and publishing the artifacts.
Using goreleaser just to provide the changelog doesn't make much sense as there are many other ways to produce the changelog.


Enforce spaces around infix/unary words operators

Enable ESLint space-infix-ops and space-unary-ops (for words only) rules.
http://eslint.org/docs/rules/space-infix-ops
http://eslint.org/docs/rules/space-unary

+1


develop branch with more logging

JIRA link
n/a
Change description
Develop branch with more logging.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

PIPELINE: https://build.platform.hmcts.net/job/HMCTS_a_to_c/job/ccd-definition-store-api/view/change-requests/job/PR-1374/


Use unjs/unstorage ?

Nice work bro ! I have just one question if you have time ! Woudn't be nice to use unjs/unstorage method as the maker of unjs/Nitro & unjs/Unstorage seeks to make a connector for Surrealdb

Hi @Celibioux. Apologies for the delay with the response. Cool package, I never knew it existed. After looking through the docs, I did notice a few limitations with using their built-in storage.

With surrealdb, you can query relationships and nested data structures. The package limits a user in only performing CRUD operations on a Table and Items. This can result in what could have been one query call, with multiple CRUD calls.
With unstorage, you can only select entire tables and items. We can't specify specific fields. An "all or nothing" may be good in certain implementations but not in all use cases.

Using the native surrealdb driver provides greater support for SurrealDb specific features.

Thank you so much for talking the time for this great explaination :)


Fix List View To Contain All Features Of Card View

Right now card view has a lot of features which list view doesn't, all you need to do is copy those features to list view and make the UI look better than it is right now.

I would like to try to do this.

Please go ahead :)

I would like to work on this issue as well. please assign in case the issue is not resolved.

Hey @ampsteric this issue has been assigned currently, please look into #14 and let me know if you are interested.

@felizj17 are you stll on this?

yes, does clicking on hits still do nothing on list view?

yes does nothing @felizj17

alright ill see what i can do


Use juanluisbaptiste Postfix config

@BenjaminPelletier checking in on this

No worries about the delay!
I don't know that I have a strong opinion about same-container vs separate, although i tend to use one container per service. If you don't feel strongly either way I can define the second container for the web service as you mention above and push up the change to this PR?

The webserver container needs the capability to send mail, regardless of how that's implemented -- that's what we're trying to solve here ultimately.  It seems like if it's configured to send mail to a separate relay container which is configured to send mail to the Gmail SMTP server, it would probably be simpler just to configure the webserver container to talk directly to the SMTP server without the relay in the middle.  But, any solution that enables the webserver container to send mail (or, equivalently, a demonstration that sends mail starting from the ubuntu:14.04 image) would be great, even if it involves 2 containers.

Something along these lines is being done in https://github.com/RopeWiki/app/pull/26 - so doing some housekeeping and closing this PR.


Getting byte representation of operand in instruction

Currently cycling through operands in instructions using the following code:
                    prototype = unit.getPrototype()
                    context = unit.getInstructionContext()
                    numOperands = prototype.getNumOperands()
                    for i in range(0,numOperands):
                        operandInt = prototype.getOpType(i,context)
                        if (operandType.isAddress(operandInt)):
                            #TODO
                            print("[OPERAND BYTE CODE")

However, I can't anything in the docs on getting the byte value of an operand within an instruction. I've probed getting operand byte values using the operand's mask, but due to gaps in my own knowledge can't quite figure out how to use masks to get byte code for operands.
Thank you for the help!

look at ScalarOperandListingHover.getOperand() and how its used to get an idea of how to do this.
Basically, if the OpObject its a Scalar, you can get the numeric value from it.


Error with two SimpleLight entries in configure.json

Hello
I get an error when I declare in the config.json file two devices as SimpleLight.
The error is :
/usr/local/lib/node_modules/homebridge-tuya-lan/lib/SimpleLightAccessory.js:24
const characteristicOn = service.getCharacteristic(Characteristic.On)
^
TypeError: Cannot read property 'getCharacteristic' of undefined
at SimpleLightAccessory._registerCharacteristics (/usr/local/lib/node_modules/homebridge-tuya-lan/lib/SimpleLightAccessory.js:24:42)
at TuyaAccessory.BaseAccessory.device.once (/usr/local/lib/node_modules/homebridge-tuya-lan/lib/BaseAccessory.js:22:18)
at Object.onceWrapper (events.js:285:13)
at TuyaAccessory.emit (events.js:197:13)
at TuyaAccessory._change (/usr/local/lib/node_modules/homebridge-tuya-lan/lib/TuyaAccessory.js:240:18)
at TuyaAccessory._msgHandler (/usr/local/lib/node_modules/homebridge-tuya-lan/lib/TuyaAccessory.js:176:26)
at /usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:4096:9
at Object.process (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:2344:17)
at /usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:2252:19
at Immediate. (/usr/local/lib/node_modules/homebridge-tuya-lan/node_modules/async/dist/async.js:119:16)
If I change the type of either  of the device to Outlet, everything works well.
(I just have to change the in the Home app).
So it is not a big deal, but I wanted to let you know.
Thanks for your work !

Can you please paste the entire block from your config file that relates to this plugin? put xxxxx for your device id and key values.
There is a scenario where the details that Homebridge has cached about your device, cause conflicts. Solving it involves deleting the cachedAccessories file. However, in the latest and yet unreleased version of the plugin, I have tried to identify and handle these bad cached devices. I don't have enough information to say for sure this is your problem but it is, in my view, the most common problem using Homebridge and its plugins.
I would recommend you first try updating the plugin with npm i -g AMoo-Miki/homebridge-tuya-lan and restarting Homebridge.
If that doesn't solve the problem, clear the cache manually; delete the file named cachedAccessories which is in a folder named accessories beside your config.json file. Then restart Homebridge.

Thanks for your answer.
Updating he plugin was not enough, but deleting the cache file worked.
:)
If you still need my config file, just ask.
Best,
Alain

Le 13 mars 2019 à 23:09, Miki<EMAIL_ADDRESS>a écrit :
Can you please paste the entire block from your config file that relates to this plugin? put xxxxx for your device id and key values.
There is a scenario where the details that Homebridge has cached about your device, cause conflicts. Solving it involves deleting the cachedAccessories file. However, in the latest and yet unreleased version of the plugin, I have tried to identify and handle these bad cached devices. I don't have enough information to say for sure this is your problem but it is, in my view, the most common problem using Homebridge and its plugins.
I would recommend you first try updating the plugin with npm i -g AMoo-Miki/homebridge-tuya-lan and restarting Homebridge.
If that doesn't solve the problem, clear the cache manually; delete the file named cachedAccessories which is in a folder named accessories beside your config.json file. Then restart Homebridge.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/AMoo-Miki/homebridge-tuya-lan/issues/26#issuecomment-472625558, or mute the thread https://github.com/notifications/unsubscribe-auth/AuPv9fE8pI33N2DOJ--xuhWC242zh9Tyks5vWXcdgaJpZM4brow4.


Added clarification for reductions when vl=0

Describe use cases for reductions and effect of behavior when vl=0.

Sec. 14 already says that, when vl=0, no operation is performed and the destination register is not updated.

The added commentary provides more rationale for the choice.


Trying my hand to get Darktable running

I am using:
FROM jlesage/baseimage-gui:debian-11
trying to run darktable from this repo: https://software.opensuse.org/download.html?project=graphics:darktable&package=darktable
Building the image works fine but when running it I get this error and I can't seem to figure out what is wrong. It has most probably not related to this base image but I thought I'd ask while I keep searching the net.
(process:839): GLib-GObject-CRITICAL **: 07:10:36.869: g_object_set: assertion 'G_IS_OBJECT (object)' failed
path lookup '/run/s6/services/app/
' fails with: 'No such file or directory'
[services.d] stopping services
[services.d] stopping app...
[services.d] stopping logmonitor...
[services.d] stopping statusmonitor...
[services.d] stopping x11vnc...
caught signal: 15

Just in case, here is the Dockerfile:
# Pull base image.
FROM jlesage/baseimage-gui:debian-11

# Install desired stuff
RUN apt-get update && \
    apt-get install -y apt-utils gpg curl git procps && \
    echo 'deb http://download.opensuse.org/repositories/graphics:/darktable/Debian_11/ /' | tee /etc/apt/sources.list.d/graphics:darktable.list && \
    curl -fsSL https://download.opensuse.org/repositories/graphics:darktable/Debian_11/Release.key | gpg --dearmor | tee /etc/apt/trusted.gpg.d/graphics_darktable.gpg > /dev/null && \
    apt-get update && \
    apt-get dist-upgrade -y && \
    apt-get install -y darktable

# Copy the start script.
COPY startapp.sh /startapp.sh

# Set the name of the application.
ENV APP_NAME="DarkTable"

And my startapp.sh
#!/bin/sh
exec darktable --configdir /config/.config/darktable/ --disable-opencl

I added '--disable-opencl' as the error above seemed related to opencl, but it didn't help

docker-compose.yml
version: '2.2'

services:

# https://github.com/jlesage/docker-baseimage-gui
# https://www.darktable.org/
    darktable:
        build: .
        image: ovidarktable
        container_name: darktable
        hostname: darktable
        restart: "no"

        ports:
          - 5805:5800

        environment:
          - USER_ID=1000
          - GROUP_ID=1000
          - DISPLAY_WIDTH=2560
          - DISPLAY_HEIGHT=1440
          - KEEP_APP_RUNNING=1
          - HOME=/config

        volumes:
          - /etc/timezone:/etc/timezone:ro
          - ./config:/config
          - /sixer/Pictures:/mnt/Pictures
        cpu_count: 8
        mem_limit: 16G

        networks:
             - multimedia

networks:
    multimedia:
        external: true
        name: multimedia

(process:849): GLib-GObject-CRITICAL **: 07:26:03.453: g_object_set: assertion  'G_IS_OBJECT (object)' failed
ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory

I would not be too concerned if this doesn't prevent Darktable to run properly.

Although it keeps throwing this kind of errors constantly:
(darktable:849): dconf-WARNING **: 07:31:21.225: failed to commit changes to dconf: Failed to execute child process ? dbus-launch? (No such file or directory)

You could try to install the dbus-x11 package to see if it helps.

Also, Darktable seems to not save any settings I change once it's running.

Do you know where settings are saved in a "normal" environment ?  You don't see anything saved under /config?

Thanks for your input. but I'm closing this as I stopped trying to get it working.


Pypi, version and qt

Hello, Nice project!
Not an issue, but you should

Add a package version in the package; e.g. so you can do coinrun.__version__.
Upload to pypi to make sure you claim the package name.

Why did this depend on Qt? For such a simple game you could have gone for something more lightweight and with a better licence no?
From the readme saying "Status: archive", it almost seems like this project was DOA and dropped on Github? What's the story?

Like most of our code releases for papers, we do not currently have plans to make this a pypi package, though thank you for the suggestion!  The status is also the same as our other releases of code associated with papers.

Do you accept contributions? I can help upload it.

Do you accept contributions? I can help upload it.

Can you tell me how to use this repo without qt5 installed? Or can you share your repo?