[Task]:  Optimise the cypress test run time by cache node modules

SubTasks
Currently, each cypress run installs node modules and that takes around 4 mins, we have 20 such processes which means around 80 mins of runner time on a single CI run. This could be reduced if we start caching the node modules.

We already cache the yarn/cache and nodemodules it not ideal to cache hence closing this.


Some m4a files are not added to the library

Windows 8.1 64bit, Museeks 0.9.3
Some m4a files are not added into the library after folder scan. Example file:
4. New Track #2 (Live).zip
Included file plays perfectly in Clementine and Tomahawk.

Hello!
I just tried importing the file you just sent, there is a metadata problem obviously (I need to check that out), but the file is imported.

For the record:

I fixed the duration problem, and I opened an issue there: https://github.com/Borewit/music-metadata/issues/74, as it is a problem with the library we use to extract id3 tags.

@brachna can you confirm that the file is added to the library, but without correct id3 tags?

I checked and yes, it is added as unknown artist.
It can't be played though.

Oh really? Can you in settings > advanced > open dev tools, and tell me the error you get in “console”?
Much appreciated 🙏

Yep this is what I noticed too, I'll investigate on Ubuntu. Thank you for the report o/

Thank you for looking into it.

I still get some errors with some files https://github.com/Borewit/music-metadata/issues/77

Fixed in 0.9.4 :)


Penalty for unreasonable kings.

Score of 4ku vs master: 535 - 408 - 736  [0.538] 1679
...      4ku playing White: 297 - 182 - 361  [0.568] 840
...      4ku playing Black: 238 - 226 - 375  [0.507] 839
...      White vs Black: 523 - 420 - 736  [0.531] 1679
Elo difference: 26.3 +/- 12.4, LOS: 100.0 %, DrawRatio: 43.8 %
SPRT: llr 2.96 (100.6%), lbound -2.94, ubound 2.94 - H1 was accepted
ELO   | 9.60 +- 6.39 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=64MB
LLR   | 2.96 (-2.94, 2.94) [0.00, 5.00]
GAMES | N: 6808 W: 2140 L: 1952 D: 2716

Thanks.


Remove US and demo sites

Remove the US and Demo sites as they are not up-to-date anymore. The demo site might be moved to a separate repository in the future.
Discussed with both David and Maik.

Thanks for this.


Prometheus Operator Installation with Istio

Describe the feature request
Have the ability to install Prometheus Operator Helm Chart with Istio Helm installation.
Prometheus Operator has many features that are easier to work with than the vanilla Prometheus that gets installed with Istio and it would be nice to leverage these features. Service monitors for integrating custom works
Describe alternatives you've considered
Integrating Istio and Mixer metrics into Prometheus Operator. While this solution does work it would beneficial with having Istio and Prometheus Operator in one installation/helm chart.
Additional context
N/A

Absolutely agree. This is a huge problem for me too. Currently I have two kubernetes setup because merging istio provided prometheus and prometheus operator is really painful.

This is the very reason why I have a custom Helm setup for Istio so I can remove all the bloat like grafana and prometheus and instead manage all of that in the operator. Doing so comes with its own problems such as having to manage the config and versions but it seems to be working well for me so far.

@nixgadget can you share your approach?

@hd-deman

I simply stripped prometheus, grafana and zipkin charts and moved them to external charts.
Promtheus and grafana are all part of prometheus-operator.
And I've defined ServiceMonitor config like below,

apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  name: {{ template "exporter-istio.fullname" . }}-pilot
spec:
  jobLabel: component
  selector:
    matchLabels:
      istio: pilot
  namespaceSelector:
    matchNames:
      - istio-system
  endpoints:
  - port: http-monitoring
    interval: 5s

Unfortunately envoy prometheus could not converted to a ServiceMonitor as it doesnt have a concept of scraping metrics from every pod. So I used external scraping config in prometheus-operator instead.

This should be two flags: a flag that enables the installation of prometheus-operator, and a flag that enables the installation of the ServiceMonitor's that prometheus-operator uses so that this can also be used with an externally installed prometheus-operator.
@nixgadget's last comment about envoy prometheus not working as a ServiceMonitor is the hard part of this task, the rest is relatively straightforward.

Does anyone know how to add istio metrics to prometheus-operator?

@volatilemolotov I found that this blog post was pretty useful, although I think I had to tweak some of the Prometheus scrape configs.

Yes i have read the article but i was trying to make a ServiceMonitor CRD file without adding scrape configs manually. It works but only if i deploy the operator with HELM and not going by the docs in prometheus-opreator git.

AFAIK, it's not possible for prom operator to select endpoints by the service's name via ServiceMonitor, only service labels, so I think scrape configs are necessary :/.  Regardless, you should be able to specify scrape configs when deploying with the kube-prometheus stack, but you'll probably have to add the rules to some jsonnet somewhere...

Absolutely agree, looking forward to the combined chart

+1 👍

+1 :+1:

+1 :+1:

After some discussion, we decided that it did not make sense to add full Prometheus Operator install via the Istio installer.
However, we did want to provide a mechanism for generating the ServiceMonitor CRs, etc., that could be used by an existing Prometheus Operator install.  To that end, an initial PR with that functionality (alpha-level support at this time) has been added to the new installer for Istio (https://github.com/istio/installer/pull/71).
Please take a look and provide feedback on that installation capability.
I'm going to close this issue, given that reasoning. Please feel free to open new issues for any shortcomings, etc., that you find with the chosen approach.
Thanks for raising this issue.


AggTags now has filter() method + unit tests

Added filter() method to AggTags. Opted to leave out fuzzy matching for the time being due to ambiguities in possible implementations. Unit tests were added for both AggTags.fuzzy() (originally intended to include fuzzy matching in filter() and AggTags.filter()).

[Current coverage][cc-pull] is 66.21%

Merging [#78][cc-pull] into [develop][cc-base-branch] will increase coverage by 0.97%

@@            develop        #78   diff @@
==========================================
  Files            14         14
  Lines          1752       1755     +3
  Methods           0          0
  Messages          0          0
  Branches        393        393
==========================================
+ Hits           1143       1162    +19
+ Misses          511        496    -15
+ Partials         98         97     -1

Powered by Codecov. Last updated by [dfc1d45...fa1402e][cc-compare]
[cc-base-branch]: https://codecov.io/gh/datreant/datreant.core/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/datreant/datreant.core/compare/dfc1d45121c97fe14dc6f758174ecb742f90a822...fa1402e9c68b9857a96d3dcbb66e85bccafa48c6?src=pr
[cc-pull]: https://codecov.io/gh/datreant/datreant.core/pull/78?src=pr

Note: as seen in the commits, I've moved the tests in test_tags_fuzzy() to a separate branch for the finishing the rest of the AggTags unit tests. This is for the purpose of separating the work done on AggTags.filter() in the PR from the rest of the work on the AggTags tests.

Note: As I did above for test_tags_fuzzy() (and as seen in the above commit), I've moved the tests in test_tags_getitem() to a separate branch (aggtags_tests) for the finishing the rest of the AggTags unit tests.

Very nice! Just a few comments on docs, and then it looks good to merge.

Looks good. Merging!


_pywrap_tensorflow_internal.so: ELF file OS ABI invalid

improt tensorflow as tf
Errorinfo:
imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
ImportError: $PATH/tensorflow/python/_pywrap_tensorflow_internal.so: ELF file OS ABI invalid
there is _pywrap_tensorflow_internal.so in path. how can i solve this “ELF file OS ABI invalid”

Please provide all the information asked for in the "New Issue" template (which includes version, OS, architecture etc.).

I have add some infos about this Issue

Please do provide all the information asked for in the "New Issue" template, without which it is hard to diagnose.
From Googling the error message, it seems that this might have to do with the fact that your machine/Linux distribution might have a very old loader?

updated Issue
that‘s all INFO about this Issue
the  machine/Linux distribution is old loader as Environment info shown

As @asimshankar said, this is CentOS 4.4, which was released about 10 years ago apparently. Linux used to have SystemV formatted binaries, I think.
According to this, if you use od you should be able to see which format you have.
https://en.wikipedia.org/wiki/Executable_and_Linkable_Format
The only route is to build from source, but you need gcc-4.x with C++11 support for that. You might be able to cross-compile.

thx~


VimuxOpenRunner doesn't work any more

It seems that my nvim/vimux setup is broken with https://github.com/preservim/vimux/pull/217. If I run VimuxOpenRunner it silently fails, meaning that no terminal is opened.
Once I revert this change locally, my setup works again, meaning that terminal is opened as expected.
Tmux version 3.0a/ Ubuntu 20.04

Will provide more details upon request/once I have more time to check details.

Though -l size seems to be supported

Naive approach for fixing this issue is to check the exit code of this command and if it fails then issue the other command. I guess, it would be helpful in any case to check exit code and not only silently fail in this case. What do you think?

Ahh, thank you. I think I'll put a conditional in there based on the tmux version.

You know what... should we just say that it's up to the user to decide whether to include the percent sign? This will be a bit of a hiccup when the plugin is updated, since setting let g:VimuxHeight = "20" will have to change to let g:VimuxHeight = "20%".

hi! is this change going to be merged? I just found this same issue with tmux 3

is this change going to be merged?

Which change? This is not a PR and I don't see any PRs related to this issue. Contributions welcome. I am not actively developing this plugin but this @preservim org exists to facilitate contributions getting applied so plugins stay maintained as long as contributions flow in. Feel free to jump in.

I don't see any PR either. I was basically asking if anyone was working on this. I'm happy to do a PR. I'll send it this weekend

Yeah sorry, I got distracted by the CI issues on this repo and forgot about this. It would be great to see a PR! We do now check for errors in system calls as of #222 so that could be helpful here.

no worries! just sent a PR. English is not my first language so I'm not sure if the update to the docs sounds natural

Thank you! This does mildly break the config for users who have a custom value for the height option, but the fix is easy and this keeps things simpler going forward.


✨  Add KS multi-cluster monitoring with Prometheus & Thanos

Summary
This PR adds KS multi-cluster monitoring with Thanos, more precisely :

Add scripts to install Thanos with Minio storage for long term persistence of data in the core cluster
Configure Prometheus deployed in any cluster (i.e., core or wec) to remote write to Thanos
Update Grafana dashboard to visualize monitoring data for the KS components running in either core or WEC clusters (single pane of glass for monitoring kS components.)
Add scripts to install KS monitoring tools in the WEC
Update the diagram illustrating KS monitoring architecture.

Related issue(s)
Fixes #

The minio pods are in Pending STATUS.
mspreitz@mjs13 monitoring % kubectl --context kind-kubeflex describe pod -n ks-monitoring minio-0
Name:             minio-0
Namespace:        ks-monitoring
Priority:         0
Service Account:  minio-sa
Node:             <none>
Labels:           app=minio
                  apps.kubernetes.io/pod-index=0
                  controller-revision-hash=minio-768f575778
                  release=minio
                  statefulset.kubernetes.io/pod-name=minio-0
Annotations:      checksum/config: 54dcefc396ddf736bce30789a84739042217f69914f1bd4a0c9ae22e7283ddc1
                  checksum/secrets: 3606e402ecb75a6c11a8b1a81f5bb6b8f8ec1315ee49a48b21583b5a12edfd11
Status:           Pending
IP:
IPs:              <none>
Controlled By:    StatefulSet/minio
Containers:
  minio:
    Image:       quay.io/minio/minio:RELEASE.2024-04-18T19-09-19Z
    Ports:       9000/TCP, 9001/TCP
    Host Ports:  0/TCP, 0/TCP
    Command:
      /bin/sh
      -ce
      /usr/bin/docker-entrypoint.sh minio server http://minio-{0...1}.minio-svc.ks-monitoring.svc.cluster.local/export -S /etc/minio/certs/ --address :9000 --console-address :9001
    Requests:
      memory:  16Gi
    Environment:
      MINIO_ROOT_USER:             <set to the key 'rootUser' in secret 'minio'>      Optional: false
      MINIO_ROOT_PASSWORD:         <set to the key 'rootPassword' in secret 'minio'>  Optional: false
      MINIO_PROMETHEUS_AUTH_TYPE:  public
    Mounts:
      /export from export (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-hbtr9 (ro)
Conditions:
  Type           Status
  PodScheduled   False
Volumes:
  export:
    Type:       PersistentVolumeClaim (a reference to a PersistentVolumeClaim in the same namespace)
    ClaimName:  export-minio-0
    ReadOnly:   false
  minio-user:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  minio
    Optional:    false
  kube-api-access-hbtr9:
    Type:                    Projected (a volume that contains injected data from multiple sources)
    TokenExpirationSeconds:  3607
    ConfigMapName:           kube-root-ca.crt
    ConfigMapOptional:       <nil>
    DownwardAPI:             true
QoS Class:                   Burstable
Node-Selectors:              <none>
Tolerations:                 node.kubernetes.io/not-ready:NoExecute op=Exists for 300s
                             node.kubernetes.io/unreachable:NoExecute op=Exists for 300s
Events:
  Type     Reason            Age                  From               Message
  ----     ------            ----                 ----               -------
  Warning  FailedScheduling  3m55s (x3 over 11m)  default-scheduler  0/1 nodes are available: 1 Insufficient memory. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod.

kubectl --context kind-kubeflex get Node kubeflex-control-plane -o yaml shows that the one and only Node in my kind-based KubeFlex hosting cluster has 11 GB of memory.

kubectl --context kind-kubeflex get Node kubeflex-control-plane -o yaml shows that the one and only Node in my kind-based KubeFlex hosting cluster has 11 GB of memory.

@MikeSpreitzer, I figured the issue. I was creating very large pv for minio/thanos/prometheus - I am using a test VM with enough resource. Hence, I decreased significantly the resources requirements and you should now be able to run in your laptop.

I am testing commit 8126af48e6dc745bc3fd5cd1c3b9fd5494e2e61e --- the latest rev of this PR. Still the minio pods are requesting 16GiB of memory.

I am testing commit 8126af4 --- the latest rev of this PR. Still the minio pods are requesting 16GiB of memory. I mean memory, not a PV.
pr2458-try2.log

I just pushed a commit with changes to decreased the memory from 16G to 2G. Also, I run few tests and everything seems to be working as expected with that amount of memory.  The minio memory can now be configured in this file: monitoring/prometheus/minio-custom-values.yaml

I tested the latest version of this PR, commit e29e26a019491347b18426eaf07778f90ff9e729. I first used test/e2e/run-test.sh to create a working system. Then:
mspreitz@mjs13 kubestellar % cd monitoring
mspreitz@mjs13 monitoring %
mspreitz@mjs13 monitoring % ./install-ks-monitoring.sh --cluster-context kind-kubeflex --set core
+ set -e
+ ctx=kind-kubeflex
...
+ : Install Thanos
+ helm -n ks-monitoring upgrade --install thanos bitnami/thanos --values /Users/mspreitz/go/src/github.com/kubestellar/kubestellar/monitoring/prometheus/thanos-custom-values.yaml --version 15.7.25
Release "thanos" does not exist. Installing it now.
Error: repo bitnami not found

I tested the latest version of this PR, commit e29e26a. I first used test/e2e/run-test.sh to create a working system. Then:
mspreitz@mjs13 kubestellar % cd monitoring
mspreitz@mjs13 monitoring %
mspreitz@mjs13 monitoring % ./install-ks-monitoring.sh --cluster-context kind-kubeflex --set core
+ set -e
+ ctx=kind-kubeflex
...
+ : Install Thanos
+ helm -n ks-monitoring upgrade --install thanos bitnami/thanos --values /Users/mspreitz/go/src/github.com/kubestellar/kubestellar/monitoring/prometheus/thanos-custom-values.yaml --version 15.7.25
Release "thanos" does not exist. Installing it now.
Error: repo bitnami not found

@MikeSpreitzer, oh! Sorry I was missing to add the thanos helm chart repo. Just pushed a commit to fix it. It should work as expected now. Thanks!

I am testing the latest rev of this PR. I have gotten to the controllers dashboard, am trying to configure for WECs. But I am getting no data from my WECs.

I am testing the latest version of this PR. I have gotten to the last case: the controllers dashboard, the case of the status add-on agent in the WEC. Thanos has no data for the alleged namespace for that:

Looking directly at the Prometheus server in cluster1, I see that it does not hold workqueue_depth timeseries from anything but the apiserver.

The Prometheus server in cluster1 is not even trying to get metrics from anything but the apiserver.

That Service has zero Endpoints:
mspreitz@mjs13 ~ % kubectl --context cluster1 get Endpoints -n open-cluster-management-agent-addon status-agent-controller -o yaml
apiVersion: v1
kind: Endpoints
metadata:
  annotations:
    endpoints.kubernetes.io/last-change-trigger-time: "2024-09-24T05:34:19Z"
  creationTimestamp: "2024-09-24T05:34:19Z"
  labels:
    app: status-agent
  name: status-agent-controller
  namespace: open-cluster-management-agent-addon
  resourceVersion: "3088"
  uid: 27769a96-04b0-48cc-8f29-759397cafa7a

The agent Pod has no ports declared, I looked at the output of kubectl get pods -n open-cluster-management-agent-addon -l app=status-agent -o yaml (long, omitted here for brevity).
But:
mspreitz@mjs13 ~ % kubectl --context cluster1 get services -n open-cluster-management-agent-addon -l app=status-agent -o yaml
apiVersion: v1
items:
- apiVersion: v1
  kind: Service
  metadata:
    ...
    name: status-agent-controller
    namespace: open-cluster-management-agent-addon
    ...
  spec:
    ...
    ports:
    - name: metrics
      port: 8080
      protocol: TCP
      targetPort: metrics
...

@MikeSpreitzer (cc: @pdettori), here are the instructions on how to deploy the status-addon-controller and status-addon-agent. It will address most of your comments above:
PR: https://github.com/kubestellar/ocm-status-addon/pull/83
Steps on how to test the status-addon-controllers using the repo helm chart:
1 - Remove the status-addon-controller and status-addon-agent from your current environmet:
helm --kube-context its1 -n open-cluster-management delete status-addon
k --context its1 -n cluster1 delete manifestwork addon-addon-status-deploy-0

2 - Clone my fork:
 git clone -b metrics-scrapping https://github.com/dumb0002/ocm-status-addon.git

3  - Build the chart:
cd ocm-status-addon/
make build
make chart

4  - Build the images locally and push to kind image registry:
cd ocm-status-addon/
make ko-local-build
make kind-load-image CLUSTERS="kubeflex cluster1 cluster2"

5 - Deploy the status-on-controllers using the local chart:
make deploy DEFAULT_IMBS_CONTEXT="its1"

@MikeSpreitzer, this PR is merged https://github.com/kubestellar/ocm-status-addon/pull/83 and a new release is also available. Hence, you can now follow these two simple steps to re-deploy the status-addon-agent and status-addon-controller in your env:

Remove the status-addon-controller and status-addon-agent from your current environment:

helm --kube-context its1 -n open-cluster-management delete status-addon
k --context its1 -n cluster1 delete manifestwork addon-addon-status-deploy-0

Deploy the status-on-controllers:

helm --kube-context its1 upgrade --install ocm-status-addon -n open-cluster-management oci://ghcr.io/kubestellar/ocm-status-addon-chart --version v0.2.0-rc12

@dumb0002 I see many open comments and then later on answers claiming some are fixed and so on.  Some of the new instructions (status addon etc..) are spread across comment answers, this is hard to follow. Can you please point me to the updated instructions to test this so I can try it?
Let's try to test and if successful I suggest to close all comments related to issues in running and then you can focus on the other comments (functionality, doc phrasing, etc..)
I also recommend to move improvement suggestion to follow-up PRs otherwise it will be difficult to converge (especially on the test validation)

Thanks for your comments @ezrasilvera! You can find the updated instructions to test it here: https://github.com/dumb0002/kubestellar/tree/thanos-configuration/monitoring

As far as I can tell, nobody has followed the instructions in https://docs.kubestellar.io/release-0.24.0/direct/release/#reacting-to-a-new-ocm-status-addon-release . We should do that first, then no special hackery would be needed here.

I have finished another round of review.

@MikeSpreitzer, I addressed all your comments. I also successfully tested these instructions with some minor modifications in a OCP env. I will create a new PR to include the instructions on how to deploy into a OCP cluster (cc: @ezrasilvera )

/approve


App Service Pricing for US Gov Virginia Shows SKUs That Don't Exist

The App Services pricing page for US Gov Virginia region shows plans that do not exist. See https://azure.microsoft.com/en-us/pricing/details/app-service/windows/, these plans are listed as available to customers:
Isolated v2 Service Plan
I1v2
I1mv2
I2v2
I2mv2
I3v2
I3mv2
I4v2
I4mv2
I5v2
I5mv2
I6v2
The only plans available in the portal are I1v2, I2v2, and I3v2.
This a caused support case for our customer to determine why the additional plans were not showing in the portal.
The issue is that these additional plans are not available and will not be for a few months.
We should remove the additional plans from the article since they are not available.

@timomta
It would be great if you could add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!!

Hi @PesalaPavan the link is there in the second sentence of my description:
"See https://azure.microsoft.com/en-us/pricing/details/app-service/windows/ ..."
I'm specifically talking about the App Service Environment plans section.

@timomta
You can raise a support ticket in the portal only.

@timomta
Thanks for posting your question! Can you please confirm if your issue is related to a document that you are following and want to point out an issue in the document or share feedback to a document to avoid such failures you have reported?  In this case could you provide the URL of the specific documentation that your feedback is applicable to? That way, we can make sure your feedback is addressed by the right team and it can help others who are looking for help on similar topics.
I found as per your scenario below link
https://learn.microsoft.com/en-us/azure/app-service/overview-hosting-plans

Yes this is the URL to the document: https://azure.microsoft.com/en-us/pricing/details/app-service/windows/
I have posted it twice in this thread. Is it not a doc managed by this team?

@timomta
Can you please check and add your comments on this doc update request as applicable.

Internal item created: https://dev.azure.com/msft-skilling/Content/_workitems/edit/288940

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close


Powerdns-admin service path

Greetings,
I followed up the example you mentioned here "PowerDNS-Admin/wiki/Systemd-example" and i think  there is no need to write this line " Environment="PATH=/opt/web/powerdns-admin" in the script,  as its not  running with it because this path breaks the user path

The WIKI page have been edited some times ago, if this is OK can you close the issue ?

I agree. Environment isn't needed to be in systemd config.


Vibrant capacitor bank I/O UI not recognizing multiblock

Using build 377, I've noticed that the I/O UI only displays the adjacent blocks to the selected capacitor block instead of the full multiblock:

How many capacitor banks do you have in your multi block? The UI will show only the selected one when your multi block has 200 or more blocks.

Ah, that's it then -- I have 260 blocks in my bank at the moment.  Incidentally, is there an upper limit?

The multiblock will work just fine - the limit is only in the UI to prevent it from getting too slow.

Feel free to close as a nonissue then.  Thanks!


Using a link along with a sidekick results in indefinite "Networking" state

Whenever I use a sidekick along with a link, the PostgreSQL container will always be in an indefinite "Networking" state.
data:
    image: tsilenzio/base
    stdin_open: true
    tty: true
    command:
        - cat

postgresql:
    image: tsilenzio/postgresql

phpfpm:
    image: tsilenzio/phpfpm
    labels:
        io.rancher.sidekicks: data
    links:
        - postgresql

If I remove the postgresql link or the data sidekick label, then it will work as expected
Rancher Server: v0.37.0
Rancher Agent: v0.8.2
Rancher Agent Instance: v0.4.1
Rancher Compose: v0.2.6

If it helps any, I am testing this on a machine where the rancher server and rancher agent are on the same machine.
I am also using Docker v1.8.2

In the meantime I have set the net to bridge for all containers, and this has solved the problem, but I would prefer to user rancher's managed network

@tsilenzio ,this issue is fixed with rancher/server:v0.37.1
I tried to launch the service you have provided in the issue using rancher-compose and see both "phpfpm" and "postgresql" get to active state.

Perfect, thank you very much!


[Question] web-app module how to run UT

Question
when I execute npm run test command in web-app director(master branch) I met the error, how can I pass web-app module UT, is there some exist UT document

hi the webapp unit test is automatically generated. In fact, I have not successfully run it.


Orderbook: displaying small amounts

Checklist

[x] I have read the CONTRIBUTING guide
[x] Good naming (as clear and simple as possible)
[ ] Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
[x] I tested desktop/mobile resolution
[ ] I tested light/dark theme
[ ] I tested different languages
[ ] I checked the functionality once again (AFFECT MONEY)
[x] I checked the work on the Testnet
[ ] I checked the work on the Mainnet
[ ] I checked the work in the plugin
[ ] I checked the PR once again

Original issue
#4602
Video / screenshot proof
Before

After

вроде ок


Allow optionally setting MemoryMax in systemd for ipfs

Hi @madoke !
Thanks for your improvements to the upstream ansible-ipfs-cluster role. I have been using yours for some months without much issue.
The one issue I have had, is that I've noticed ipfs gradually uses more and more RAM. Probably a memory leak, or maybe just a 'cache' filling up. Depending on the size of the machine running the service, this can pose a problem.
To help control it, I've set MemoryMax in the systemd unit file. Thought I'd offer a PR for it as an optional parameter. Thanks!

hey @mig5 ! happy to know that its been useful to you :) feel free to reach out anytime !


Parse nil fields by default

Fixes #17 by using the new allowNil option.

Waiting for a new stable version of NeoJSON.


Enable onSwipe callback to update TabView dynamically when tab is changed by Swipe not by Button

Feature Request
Description
Need to set "onSwipe" callback in TabBarView paramaters like setting "onTap" to buttonsBar, so I can call an async function to update the view dynamically

Hi @MennaCC , I'm sorry for the delay on this.
You can already achieve this behavior by adding a listener to the TabController:
TabController tabController = TabController(
  length: 2,
  vsync: this,
  initialIndex: transactionTypeToIndex(
    transactionsScreenTypeProvider.type,
  ),
);
tabController.addListener(onTabChanged);

Where onTabChanged is something like:
onTabChanged() {
  if (tabController.indexIsChanging) return;
  switch (tabController.index) {
    case 0:
      // do something
      break;
    case 1:
      // do something
      break;
  }
}

Hi @MennaCC , I'm sorry for the delay on this. You can already achieve this behavior by adding a listener to the TabController:
TabController tabController = TabController(
  length: 2,
);
tabController.addListener(onTabChanged);

Where onTabChanged is something like:
onTabChanged() {
  if (tabController.indexIsChanging) return;
  switch (tabController.index) {
    case 0:
      // do something
      break;
    case 1:
      // do something
      break;
  }
}

I think that the expected default behavior for the already implemented onTap function is to change the view whether it is tapped or swiped since the swipe detection is already implemented (thank you for that btw) .
Instead of tampering with the already implemented onTap I just made the onSwipe and used it instead of the onTap.
I think it is always better to encapsulate all the controller and addListener stuff inside the package itself for its user (like what's done in the onTap), and much simpler to use especially if the views change dynamically due to the object I associate with the tab.

Thank you for the explanation @MennaCC . That's a fair point, let's merge the PR you worked on

Thank you for the explanation @MennaCC . That's a fair point, however, after inspecting Flutter's default TabBar implementation:
https://api.flutter.dev/flutter/material/TabBar/onTap.html
I noticed that only the onTap method is provided. Which I assume it is because it is difficult to distinguish between onTap and onSwipe gestures from the TabBar itself.
Therefore, I'll keep this package as it is. I'm sorry and I hope you understand.

can you at least add the modifocation to the onTap?
On Thu, 11 Apr 2024, 9:22 am Afonso Raposo, @.***>
wrote:

Thank you for the explanation @MennaCC https://github.com/MennaCC .
That's a fair point, however, after inspecting Flutter's default TabBar
implementation:
https://api.flutter.dev/flutter/material/TabBar/onTap.html
I noticed that only the onTap method is provided. Which I assume it is
because it is difficult to distinguish between onTap and onSwipe gestures
from the TabBar itself.
Therefore, I'll keep this package as it is. I'm sorry and I hope you
understand.
—
Reply to this email directly, view it on GitHub
https://github.com/afonsocraposo/buttons_tabbar/issues/46#issuecomment-2049073736,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWS6PXEUMOG5OTUO7KAQXTY4Y2Z3AVCNFSM6AAAAABFHVDXDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGA3TGNZTGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @MennaCC!
In Flutter's documentation, it says that the onTap method for TabBar is:

An optional callback that's called when the TabBar is tapped.
The callback is applied to the index of the tab where the tap occurred.

I believe the implementation in ButtonsTabBar the onTap callback does the same, no?
Can you elaborate what behavior you are expecting from the onTap callback?

im expecting that the behavior i set for the onTap happens on "index change" by either tap or swipe.

Hi @MennaCC! I think it's better to keep the onTap behavior similar to what Flutter provides on the native TabBar:
https://api.flutter.dev/flutter/material/TabBar/onTap.html

i also need onSwipe callback ;(

Hey @dipu0!
Please find the answer to your problem here:
https://stackoverflow.com/questions/55485466/how-to-detect-tabbar-change-in-flutter


Enable ARM_PROVIDER_STRICT to protect against dangerous behavior

Some of the Azure APIs allow for accidental "adoption" of existing resources, because the API operations behave as "create or update" operations. This is especially dangerous for creating Resource Groups as developers can "adopt" another resource group in their account by re-using the same group name. Then when making changes or doing a destroy can unintentionally and unknowingly delete resources that exist outside the current Pulumi app.
The upstream Azure provider allows for a change in behavior to protect against this via a ARM_PROVIDER_STRICT=true environment variable flag - per this comment.
This should be enabled by default in Pulumi.

The best way to make this happen is to disable the check for the environment variable in our fork of upstream, since otherwise we'll rely on package init ordering. pulumi/terraform-provider-azurerm#14 does this.


Update docstrings and examples (part 8)

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (6a4c1d2) 100.00% compared to head (b0c1f1e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #377   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          311       311
  Lines         9971      9980    +9
  Branches       975       975
=========================================
+ Hits          9971      9980    +9

Files Changed
Coverage Δ

src/gravitorch/runners/base.py
100.00% <ø> (ø)

src/gravitorch/runners/resource.py
100.00% <ø> (ø)

src/gravitorch/runners/utils.py
100.00% <ø> (ø)

src/gravitorch/testing/dummy.py
100.00% <ø> (ø)

src/gravitorch/__init__.py
100.00% <100.00%> (ø)

src/gravitorch/runners/__init__.py
100.00% <100.00%> (ø)

src/gravitorch/runners/evaluation.py
100.00% <100.00%> (ø)

src/gravitorch/runners/no_repeat.py
100.00% <100.00%> (ø)

src/gravitorch/runners/sequential.py
100.00% <100.00%> (ø)

src/gravitorch/runners/training.py
100.00% <100.00%> (ø)

... and 1 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Replace banner branding

The banner on the main readme and a few other places still says Heptio instead of VMware.

Thanks for the reminder @johnSchnake


drivers: bluetooth: rpmsg: validate heap size configuration

Added a build-time assert to check if heap memory configuration to
make sure that it can accomodate RPMsg queue allocations.
Ref: NCSDK-5479
Signed-off-by: Kamil Piszczek<EMAIL_ADDRESS>

Seems like "Ref: NCSDK-5479" should probably be removed from the commit message?

Seems like "Ref: NCSDK-5479" should probably be removed from the commit message?

From our side it is fine to have them here. Question is if it is fine zephyr projects side I guess.


Table Subheader implemented, testing added, documentation updated

Summary
This code allows for Subheaders to be placed within a Table. The Subheader pulls its length from the length of a Table Row, and styles itself accordingly. Testing has been done and an example is included for the site.
Additional Details
This is pretty bare. Actions on the Subheaders (as an example) are not implemented at this time.
This is a solutions for: https://github.com/cerner/terra-core/issues/298

It might be good to add a nightwatch example for subheader in a non-selectable table. Also table-spec.js should have a test for the examples to confirm the subheader is displayed.

Tested version: npm v0.2.1
Reviewed:

[x] Follows pattern considerations documented in the current Cerner Design Standard: Tables.
[x] Follows UX defined Terra design implementation for issue: adding functionality for subheaders.

Pass

UX Review for npm v0.2.2

Suggestion:

Move the "Table Subheader: Props" property section higher in order (between "Table Header Cell: Props" and "Table Rows: Props") on documentation page.

Fix with next GitHub Issue:

Update with new table colors (table border, table header, row zebra striping, selection colors)
Remove responsive behavior which gets triggered at 768px ($terra-small-breakpoint)

Functional verification completed. +1 with UX color change recommendations above.


About Zapier Connection

When I try to connect my Chatterbot Account with Zapier its showing error.
I have A Demo Account on Platform.chatterbotbuilder.com and a PAid account on Build.thechatterbots.com
I cannot connect my Paid Account to Zapier.
And for Documentation, it's saying to visit Platform.chatterbotbuilder.com But The Paid account is not connecting?

Hi @Pd08111997 I am not affiliated with either of those products. This is also the first time that I have heard about either of them. You will need to seek out help from whoever the owner of those websites is.


[Enhancement] Fix zero points exercises with and without bonus for all exercise types (manual assessment + complaints)

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x]  Server: I followed the coding and design guidelines.
[x]  Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[x]  Server: I implemented the changes with a good performance and prevented too many database calls
[x]  Server: I documented the Java code using JavaDoc style.
[x]  Client: I followed the coding and design guidelines.
[x]  Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[x]  Client: I documented the TypeScript code using JSDoc style.
[x]  Client: I added multiple screenshots/screencasts of my UI changes
[x]  Client: I translated all the newly inserted strings into German and English

Motivation and Context

Currently zero point exercises are not completely supported on all exercise types for manual assessment and complaints. This PR introduces the support for this.
Description

[x] Extract getMaxScoreRespectingZeroPointExercises so that it can be used from other components on server and client
[x] Implement correct use of maxPoints for assessment of Modeling, Text and FileUpload exercises + complaints
[x] Implement correct use of maxPoints for assessment of Programming exercises + complaints

Steps for Testing

Normal exercises:

Log in to Artemis
Navigate to Course Administration

Important: test the following 4 cases in 4 different exercises for Programming, Modeling, Text, Quiz and FileUpload:

[x] 10 points + 0 bonus points
[x] 10 points + 10 bonus points
[x] 0 points + 10 bonus points
[x] 0 points + 0 bonus points

Test the following scenario: if a student e.g. has collected 30 points in a course, but the sum of normal points is 20, then the score on the start page of Artemis should show 150%. The score calculation is really critical and has to be absolutely correct!
Also make sure that the instructor page course scores includes the correct calculation based on the sum of normal points and the exported csv file is correct.

Assess the exercises
See if everything works as expected
Complain and assess the complaint
See if everything works as expected

Test Coverage

Server:

Exercise.java: 92%
Result.java: 95%
AssessmentService.java: 88%
ProgrammingAssessmentService.java: 92%
ProgrammingExerciseGradingService.java: 95%

Client:

scoreChartPreset.ts: 92%
exercise-utils.ts: 91%
result-detail.component.ts: 95%
code-editor-tutor-assessment-container.component: 81%
text-feedback-conflicts.component.ts: 79%
modeling-assessment.component.ts: 78.95%
score-display.component: 76%
modeling-assessment-editor.component.ts: 72%
text-assessment-base.component.ts: 71%
text-submission-assessment.component: 70.11%
modeling-submission.component.ts:  72.5%
file-upload-assessment.component.ts: 73.44%

Screenshots

Tooltip when bonus points are available:

Statistics view of an exercise:

0 point and 10 bonus point exercise:

0 point and 0 bonus point exercise (showing only the percentage reached, base is 100 points):

What @JohannesWeiss said.
Scoreboard for Modeling exercise with 0 Points and 10 Bonus Points:

this is fixed with the latest changes

Tested in testing session with @airelawaleria @JohannesWeiss @LudwigWeide . Exercises with 0 normal Points and 0 Bonus Points don´t work for all exercise types as you can see in the picture

what is the issue? Do you mean that you have " x points of 100 points"?
This is intended, as 0 point/0 bonus point exercises have a default of 100 points. So a user can achieve up to 100% of a the score.

Tested in testing session with @airelawaleria @JohannesWeiss @LudwigWeide . Exercises with 0 normal Points and 0 Bonus Points don´t work for all exercise types as you can see in the picture

I am not sure what do you mean?

Tested again on ts1 in testing session and con confirm the issue mentioned by @simonzilker.
Additionally, we found a discrepancy in the percentage values in the course overview and the statistics tab of the course (116% and 133% in our case) that only gets updated, if one presses "Refresh".

I think I fixed this. Can you check again please :) ?

Tested again on ts1 in testing session and con confirm the issue mentioned by @simonzilker.
Additionally, we found a discrepancy in the percentage values in the course overview and the statistics tab of the course (116% and 133% in our case) that only gets updated, if one presses "Refresh".

I think I fixed this. Can you check again please :) ?

Reverted fix and will be dealt in a follow up.

I am also confused by the result string in case of 0 points exercises with 0 bonus points.

We should not show anything about points in the result string here.
For programming exercises, please only show the percentage based on the tests
For modeling|text|fileupload exercises, please show a different type of result string, I would suggest some kind of summary about the feedback elements, the minimal solution would be "X feedback"

We have addressed the issue and we are displaying now:
x%, 0 of 0 points.

Tested again on ts1 in testing session and con confirm the issue mentioned by @simonzilker.
Additionally, we found a discrepancy in the percentage values in the course overview and the statistics tab of the course (116% and 133% in our case) that only gets updated, if one presses "Refresh".

this will be addressed in a follow-up PR. Where we want to use websockets to update the view.

Tested on TS1, works apart from some small issues:

For exercises with 0 normal and 0 bonus points: When you assess this exercise with >0 points (for example 14), the score is set to 14%, 0 of 0 points. This may be intended but looks weird to me
For File Upload exercises: When assessing this exercise, you cannot give 0 points for "Add feedback" since Artemis gives the warning that "The score field must be a number and can not be empty".
For exercises with 0 points and (for example) 10 bonus points: When you give 9 points the result is 90%, 9 of 10 points. Shouldn't it be 9 of 0 points? When you have an exercise with 10 normal and 10 bonus points, it can show 15 of 10 points, too. I can see the problem of calculating a percentage for e.g. 9/0 though. I hope it's clear what I mean.

I see your concerns, but all of that is intended:

for 0 point / 0 bonus point exercises we still need a way to grad and give a score. So 100 is the base for those exercises. This means the shown points are actually percentage points.

You cannot give 0 points for a Feedback, this wouldn't make sense. I guess you are confused by the meaning of a zero point exercise. As mentioned in 1) this should be seen as a percentage score.

We always want to show the maximum points. So for a 10/10 exercise we are showing 20 of 10 points (Bonus: 10).
For a 0/10 exercise, it is 10 of 10 points (Bonus: 10)
For a 10/0 exercise, it is 10 of 10 points.
For a 0/0 exercise, it is 0 of 0 points.

Tested in TS1 with @JannisBittlmayer, i can confirm the points mentioned by Jannis.

see my explanation above :)

Added two small suggestions. Otherwise, the code looks good to me!

thanks, I have committed your changes 👍

Tested on TS1, works apart from some small issues:

For exercises with 0 normal and 0 bonus points: When you assess this exercise with >0 points (for example 14), the score is set to 14%, 0 of 0 points. This may be intended but looks weird to me
For File Upload exercises: When assessing this exercise, you cannot give 0 points for "Add feedback" since Artemis gives the warning that "The score field must be a number and can not be empty".
For exercises with 0 points and (for example) 10 bonus points: When you give 9 points the result is 90%, 9 of 10 points. Shouldn't it be 9 of 0 points? When you have an exercise with 10 normal and 10 bonus points, it can show 15 of 10 points, too. I can see the problem of calculating a percentage for e.g. 9/0 though. I hope it's clear what I mean.

I see your concerns, but all of that is intended:
1. for 0 point / 0 bonus point exercises we still need a way to grad and give a score. So 100 is the base for those exercises. This means the shown points are actually percentage points.

2. You cannot give 0 points for a Feedback, this wouldn't make sense. I guess you are confused by the meaning of a zero point exercise. As mentioned in 1) this should be seen as a percentage score.

3. We always want to show the maximum points. So for a 10/10 exercise we are showing 20 of 10 points (Bonus: 10).
   For a 0/10 exercise, it is 10 of 10 points (Bonus: 10)
   For a 10/0 exercise, it is 10 of 10 points.
   For a 0/0 exercise, it is 0 of 0 points.

Okay, thanks for the quick response :)

Tested on TS1, works apart from some small issues:

For exercises with 0 normal and 0 bonus points: When you assess this exercise with >0 points (for example 14), the score is set to 14%, 0 of 0 points. This may be intended but looks weird to me
For File Upload exercises: When assessing this exercise, you cannot give 0 points for "Add feedback" since Artemis gives the warning that "The score field must be a number and can not be empty".
For exercises with 0 points and (for example) 10 bonus points: When you give 9 points the result is 90%, 9 of 10 points. Shouldn't it be 9 of 0 points? When you have an exercise with 10 normal and 10 bonus points, it can show 15 of 10 points, too. I can see the problem of calculating a percentage for e.g. 9/0 though. I hope it's clear what I mean.

I see your concerns, but all of that is intended:
1. for 0 point / 0 bonus point exercises we still need a way to grad and give a score. So 100 is the base for those exercises. This means the shown points are actually percentage points.

2. You cannot give 0 points for a Feedback, this wouldn't make sense. I guess you are confused by the meaning of a zero point exercise. As mentioned in 1) this should be seen as a percentage score.

3. We always want to show the maximum points. So for a 10/10 exercise we are showing 20 of 10 points (Bonus: 10).
   For a 0/10 exercise, it is 10 of 10 points (Bonus: 10)
   For a 10/0 exercise, it is 10 of 10 points.
   For a 0/0 exercise, it is 0 of 0 points.

Okay, thanks for the quick response :)

btw. Do not hit "Close with comment", as this will close the whole PR :D

Tested on TS1, works apart from some small issues:

For exercises with 0 normal and 0 bonus points: When you assess this exercise with >0 points (for example 14), the score is set to 14%, 0 of 0 points. This may be intended but looks weird to me
For File Upload exercises: When assessing this exercise, you cannot give 0 points for "Add feedback" since Artemis gives the warning that "The score field must be a number and can not be empty".
For exercises with 0 points and (for example) 10 bonus points: When you give 9 points the result is 90%, 9 of 10 points. Shouldn't it be 9 of 0 points? When you have an exercise with 10 normal and 10 bonus points, it can show 15 of 10 points, too. I can see the problem of calculating a percentage for e.g. 9/0 though. I hope it's clear what I mean.

I see your concerns, but all of that is intended:
1. for 0 point / 0 bonus point exercises we still need a way to grad and give a score. So 100 is the base for those exercises. This means the shown points are actually percentage points.

2. You cannot give 0 points for a Feedback, this wouldn't make sense. I guess you are confused by the meaning of a zero point exercise. As mentioned in 1) this should be seen as a percentage score.

3. We always want to show the maximum points. So for a 10/10 exercise we are showing 20 of 10 points (Bonus: 10).
   For a 0/10 exercise, it is 10 of 10 points (Bonus: 10)
   For a 10/0 exercise, it is 10 of 10 points.
   For a 0/0 exercise, it is 0 of 0 points.

Okay, thanks for the quick response :)

btw. Do not hit "Close with comment", as this will close the whole PR :D

I realized this after posting, sorry! Won't happen again!

Tested on ts1 with @LudwigWeide. Basically, everything works as intended.
With a 0 0 programming exercise a percentage is shown depending on the given points, but we assume this is not a real issue, since for those exercises no points should be given. Since zero out of zero points are displayed correctly this can still be approved.

This is intended, and going to be addressed in a follow-up.

Tested on ts1 with @LudwigWeide. Basically, everything works as intended.
With a 0 0 programming exercise a percentage is shown depending on the given points, but we assume this is not a real issue, since for those exercises no points should be given. Since zero out of zero points are displayed correctly this can still be approved.

This is intended, and going to be addressed in a follow-up.

Programming Exercise Manual Assessment:

With points and bonus the result string only shows the points initially

Without points but with bonus the same max 10 points are shown

Given this I would expect, that the exercise with points and bonus shows the points + bonus as the max points a tutor can give.
Tutors should be able to see, how many points and bonus points they can give for each programming exercise. This could also be realized as a tooltip.
Students should also be able to examine, how many bonus points an exercise can give here:

Programming Exercise Complaints:
After the manual assessment, the dashboard shows a trigger build plan button for the exercise without points but with bonus. The automatic assessment of this submission was successful before.

Seems like complaints are deactivated for exercises without points and bonus. This makes sense but we should explain this in the tooltip:

Need to verify this findings as TS1 got redeployed at some point.

Programming Exercise Manual Assessment:

With points and bonus the result string only shows the points initially

Without points but with bonus the same max 10 points are shown

Given this I would expect, that the exercise with points and bonus shows the points + bonus as the max points a tutor can give.
Tutors should be able to see, how many points and bonus points they can give for each programming exercise. This could also be realized as a tooltip.
Students should also be able to examine, how many bonus points an exercise can give here:

Programming Exercise Complaints:
After the manual assessment, the dashboard shows a trigger build plan button for the exercise without points but with bonus. The automatic assessment of this submission was successful before.

Seems like complaints are deactivated for exercises without points and bonus. This makes sense but we should explain this in the tooltip:

Need to verify this findings as TS1 got redeployed at some point.

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

In this case it should always state 0%. You cannot achieve any points, so a score different from 0% would not make sense at the moment. (We can think about supporting this differently in the future, but such exercises do not occur often)

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

In this case it should always state 0%. You cannot achieve any points, so a score different from 0% would not make sense at the moment. (We can think about supporting this differently in the future, but such exercises do not occur often)

We can think about supporting this differently in the future, but such exercises do not occur often)

Seems like complaints are deactivated for exercises without points and bonus. This makes sense but we should explain this in the tooltip:

This is not related to the points it all. The code is in complaint-interactions.component.ts Please check again that this is really a problem only for  0 0 exercises..

We can think about supporting this differently in the future, but such exercises do not occur often)

Seems like complaints are deactivated for exercises without points and bonus. This makes sense but we should explain this in the tooltip:

This is not related to the points it all. The code is in complaint-interactions.component.ts Please check again that this is really a problem only for  0 0 exercises..

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

In this case it should always state 0%. You cannot achieve any points, so a score different from 0% would not make sense at the moment. (We can think about supporting this differently in the future, but such exercises do not occur often)

It is unclear to me how this is an error. As far as I understood the PR the whole point of 100 point workaround was that students still see a score even though they receive no points?

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

See if everything works as expected

What is the expected Score for 0 point exercises? I created a new text exercise with 0 points and 0 bonus points, then assessed a submission with 1 point which results in the following:

I assume that is correct because we use a fallback of 100 as base when there are no points. However, on the course statistics for the student I still have 0 points? (When in fact I should have 1 point?)

In this case it should always state 0%. You cannot achieve any points, so a score different from 0% would not make sense at the moment. (We can think about supporting this differently in the future, but such exercises do not occur often)

It is unclear to me how this is an error. As far as I understood the PR the whole point of 100 point workaround was that students still see a score even though they receive no points?

After communication issues and after finding out that the changes in this PR include some wrong implementation, we decided to close this PR and further work on an improved solution in a new PR https://github.com/ls1intum/Artemis/pull/2651

After communication issues and after finding out that the changes in this PR include some wrong implementation, we decided to close this PR and further work on an improved solution in a new PR https://github.com/ls1intum/Artemis/pull/2651


Don't work with me

Hi,
Can you please expand on your issue?
What errors are you getting? How are you implementing it into your form?
Additional context is needed to help diagnose your issue.

@0wain  I don't know, I do everything in the documentation, but when I open two browsers with different users and make modifications to a specific record, it doesn't work for me as shown in the demo

Please provide a code example of how you added it to your form.

@0wain
1-LabelResource.php

2-AdminPanelProvider.php

Please provide a code example of how you added it to your form.

Hi


Icon not rendered for git_ignored file

With filtered_items.visible=false and filtered_items.hide_gitignored=false, the git_status.symbols.ignored is not rendered for git ignored file.

This is fixed in main and will go out in the next release.

Umm... now with filtered_items.visible=false and filtered_items.hide_gitignored=false, git ignored files are not showing up at all 🤔

I think this is correct now.

Yep, not it's working correctly 🎉


chore(deps): replace "github.com/mitchellh/go-ps"

Closes #3612

/test tl=4

/test tl=4 ft=upgrade

I’m going to abandon this PR. https://github.com/shirou/gopsutil adds too many dependencies, and if we have to reimplement it, it would be better to fork the repository and maintain our copy. For now, we will remain with http://github.com/mitchellh/go-ps.


Add WASM binary

This PR adds a WASM binary for drafter.js, since we wrap the existing drafter.js files in UMD for browser compatibility that means we cannot use that in conjunction with WASM as that is unsupported by emscripten (not being too familiar with browser JS I am not sure what the standard should be, but we had requests in past by users to add UMD so likely need to keep that use-case for our users).
For now, I have named the files drafter-non-umd.js and drafter-non-umd.wasm but we need to figure out what to do before merging this pull request.
For testing purposes, the following links to the WASM files  can be used:

https://583-28275855-gh.circle-artifacts.com/0/root/project/lib/drafter-non-umd.js
https://583-28275855-gh.circle-artifacts.com/0/root/project/lib/drafter-non-umd.wasm

Tasks

[ ] Manual testing in browser
[ ] Automated testing in CI
[ ] Determine name for wasm/js files

I'm going to close this as the work here to get this feature finished is now being done elsewhere by @tjanc.


NPM version is not in sync with Github

Somehow your NPM package is not in sync with what the code shows here in Github, the version is the same v29.3.1 but the NPM package does not yet include the code merged in #11.
You can verify it here, seems it was not built before publishing, https://www.npmjs.com/package/jest-bench?activeTab=explore
Cheers!

Thanks for pointing that out. Perhaps I didn't run build before publish. I have just published v29.3.2 and looks like it does have the new code.

Thank you! Cheers!


Errors with basic requests

Jisho must have updated their website.
Word requests crash
$>  jisho search word nichi
Traceback (most recent call last):
  File "/home/fulguritude/.local/lib/python3.10/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/simplejson/__init__.py", line 525, in loads
    return _default_decoder.decode(s)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/simplejson/decoder.py", line 370, in decode
    obj, end = self.raw_decode(s)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/simplejson/decoder.py", line 400, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/fulguritude/.local/bin/jisho", line 8, in <module>
    sys.exit(make_cli())
  File "/home/fulguritude/.local/lib/python3.10/site-packages/jisho_api/cli.py", line 209, in make_cli
    main()
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/jisho_api/cli.py", line 147, in request_word
    w = Word.request(word, cache=flag)
  File "/home/fulguritude/.local/lib/python3.10/site-packages/jisho_api/word/request.py", line 74, in request
    r = requests.get(url).json()
  File "/home/fulguritude/.local/lib/python3.10/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Kanji requests fail.
$> jisho search kanji 数
[Error] No kanji found with name 数.

It seems as though Jisho may have implemented some kind of anti-bot measure. I was able to make requests work again by modifying the request with a user agent (this is just an example)
headers = {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'} ... r = requests.get(url, headers=headers).json()

Can confirm adding a user agent solves the issue. Might try to fork and PR later

King @Fulguritude  :crown:


Fatal error after clean install

Installed as described.
Selected Create New Payment and clicked Pay
Received a stack dump:
Fatal error: Uncaught TypeError: Argument 1 passed to Cardinity\Method\ResultObjectMapper::map() must be of the type array, null given, called in C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Http\Guzzle\ExceptionMapper.php on line 84 and defined in C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Method\ResultObjectMapper.php:38 Stack trace: #0 C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Http\Guzzle\ExceptionMapper.php(84): Cardinity\Method\ResultObjectMapper->map(NULL, Object(Cardinity\Method\Error)) #1 C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Http\Guzzle\ExceptionMapper.php(34): Cardinity\Http\Guzzle\ExceptionMapper->create('Cardinity\\Excep...', Object(GuzzleHttp\Exception\ClientException), Object(Cardinity\Method\Payment\Create)) #2 C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Http\Guzzle\ClientAdapter.php(53): Cardinity\Http\Guzzle\ExceptionMapper->get(Object(GuzzleHttp\Exceptio in C:\Apache24\htdocs\test\cardinity\vendor\cardinity\cardinity-sdk-php\src\Method\ResultObjectMapper.php on line 38

Can you share your php version, Was the .env file configured correctly?

You are probably using from a localhost. In case of a local development environment
use something like ngrok
or have a development url using etc/hosts.

after updating code and following the instructions, I get an error
Fatal error: Uncaught Error: Class 'Router' not found in C:\Apache24\htdocs\apps\spilnew\public_html\test\cardinity\cardinity-example-php-master\public\index.php:20 Stack trace: #0 {main} thrown in C:\Apache24\htdocs\apps\spilnew\public_html\test\cardinity\cardinity-example-php-master\public\index.php on line 20
(.env file has the correct values. php 7.4)


Remove array prototye remove function

replace remove function , better performance and solved my bug
https://github.com/LazarSoft/jsqrcode/pull/28
https://github.com/andrastoth/webcodecamjs/issues/17

Thanks for the comments.
i will accept your solution.

I apply this solution to webcodecamjs.js


Shutting down VM to be able update VirtualBox

I tried to update VirtualBox, but installer told me there is running VM. So I turned off Kitematic and ... it did not worked again. So I opened Kitematic and checked how to turn off the machine. Nothing found, but there is option to turn off machine while quiting Kitematic (by default unchecked, strange). Not exacly what I wanted, but it should work. So I turned off Kitematic again and immediately started VirtualBox installator. Again it told me there is running VM. Hmm, maybe it taked a while to turn off VM, but why Kitematic did not did not showed me some feedback to know when it will be turned off? After about one minute of waiting it was possible to run installation.
So to have Kitematic more user friendly I recommend:

Add option to turn on and off VM from GUI (to menu? some green/red icon with menu?)
Not block GUI while starting VM. Why I can not prepare config, browse directory etc. while the VM "lazy loads" at background (with some indicator in red/green icon)?
Have Shut down VM on closing Kitematic option turned on by default
Not close GUI immediately after user want, but give user feedback that VM is turning off and close window than. (Maybe with simillar progress bar what is currently on start.)

@iBobik If you look in the wiki, you'll see that a lot of this is document in the up-coming machine changes:
https://github.com/kitematic/kitematic/wiki/Machine-Management
If you use Kitematic a lot, it's actually nice to open it with the VM already running or close it and keep working with your containers without Kitematic open (aka VM still running)

I am talking about UI changes to improve usability, mainly for new users.
And this is not there.
Jan Pobořil
2015-08-11 0:26 GMT+02:00 FrenchBen<EMAIL_ADDRESS>
@iBobik https://github.com/iBobik If you look in the wiki, you'll see
that a lot of this is document in the up-coming machine changes:
https://github.com/kitematic/kitematic/wiki/Machine-Management
If you use Kitematic a lot, it's actually nice to open it with the VM
already running or close it and keep working with your containers without
Kitematic open (aka VM still running)
—
Reply to this email directly or view it on GitHub
https://github.com/kitematic/kitematic/issues/903#issuecomment-129633425
.

Although perhaps not clear, the wiki does in fact talk about UI changes as you mentioned, where the VM status would be shown and allow you to start/stop it.
Unfortunately until the VM is up and running there isn't much you can do, as it's the main repository for all of your containers.

Hi @iBobik  Thank you so much for this.

Add option to turn on and off VM from GUI (to menu? some green/red icon with menu?)
In Kitematic settings you will be able to do this from GUI for when closing Kitematic. We don't yet have a display on your VM status.

Not block GUI while starting VM. Why I can not prepare config, browse directory etc. while the VM "lazy loads" at background (with some indicator in red/green icon)?
The reason for blocking Kitematic while starting VM is because almost every action you will need to do requires the VM. (except browsing of course, but that's not most of our users' behavior). Kitematic at the start, checks and starts the VM.

Have Shut down VM on closing Kitematic option turned on by default
Thanks for this suggestion.

Not close GUI immediately after user want, but give user feedback that VM is turning off and close window than. (Maybe with simillar progress bar what is currently on start.)
The GUI can be closed immediately.


consider Dhall for manifests

consider Dhall for manifests for apps that work with scoop.
I read some of https://github.com/lukesampson/scoop/issues/2609, then stopped as it was pretty boring.
regarding, supporting yaml, I think it and python are weird choices as people don't expect whitespace to be significant. That particular feature adds cognitive load on users without any real benefits.
site for Dhall. https://dhall-lang.org/
features in Dhall that make it better than a general-purpose programming language.
see 'Turing-completeness is not a feature' on Dhall site for the most compelling feature if Turing complete language is undesired.
it looks better than reading python or yaml syntax as it doesn't have significant whitespace. also, I haven't heard of any hype about this unlike python, that's a nice sign.
also, official https://github.com/dhall-lang/dhall-lang/wiki/Cheatsheet, and the wiki looks better than a experimental project's wiki, in general. Its more fleshed out than the scoop wiki.
dhall tutorial https://learnxinyminutes.com/docs/dhall/ , not officially on dhall site.
regards ratatoeey

this is mainly heuristics stuff, so far. I don't know whether it makes sense for scoop to move from json manifests.
But I plan on getting fluent in using Dhall before I say anything more. Its also better than json. Its only better because it learns form mistakes of others, so I hope it will get better.

regards ratatoeey


separated gql fragments on different type in a union should generate union type instead intersection type

Sorry for the complicated title, I've no idea how to describe this issue shorter in one sentence. （´＿｀）
Describe the bug
When a named fragment is referenced outside a query, the generated type of the fragments is an intersection of fragments, which should be a union.
To Reproduce
Steps to reproduce the behavior:
schema:
# schema.graphql
#
# mostly copied from:
# https://facebook.github.io/graphql/June2018/#example-255de

union SearchResult = Photo | Person

type Person {
  name: String
  age: Int
}

type Photo {
  height: Int
  width: Int
}

type Query {
  firstSearchResult: SearchResult
}

document:
# document.graphql

fragment PersonFragment on Person {
  name
}

fragment PhotoFragment on Photo {
  height
}

query search {
  firstSearchResult {
    ...PersonFragment
    ...PhotoFragment
  }
}

Run command: gql-gen --template graphql-codegen-typescript-template --schema schema.graphql document.graphql --out schema.ts
Expected behavior
In generated schema.ts, the actual type of query search is:
export namespace Search {
  export type Variables = {};

  export type Query = {
    __typename?: "Query";
    firstSearchResult?: FirstSearchResult | null;
  };

  export type FirstSearchResult = PersonFragment.Fragment &
    PhotoFragment.Fragment;
}

Notice the FirstSearchResult type, it is an intersection type of PersonFragment.Fragment and PhotoFragment.Fragment.
Expected  FirstSearchResult type should be union of PersonFragment.Fragment and PhotoFragment.Fragment. i.e.
export type FirstSearchResult = PersonFragment.Fragment |
   PhotoFragment.Fragment;

Environment:

OS: Arch Linux (latest)
Codegen: 0.12.6
Node: 10.11.0
graphql: 14.0.2

Additional context
If we inline the fragments in document.graphql(just like the example in https://facebook.github.io/graphql/June2018/#example-f8163 ):
query search {
  firstSearchResult {
    ... on Person {
      name
    }
    ... on Photo {
      height
    }
  }
}

It will not run into this issue.
However, we use separated fragments mostly because:

The fragments are too much
The fragments are not as simple as the example shows
We want to reuse fragments and ensure maintainability

I think this is a reasonable use case.
About the reason of this issue, I think the parser is lacking the context of a fragment reference(do not know the referenced fragment is for a specific type or not, i.e. with or without on XXXType). Maybe the root cause is in upstream facebook/graphql (need to check the output of parse function).

That's definitely a bug. I'll look into it soon.

fixed in 0.13.0. @frantic1048


Error: EISDIR: illegal operation on a directory, read

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Error after adding aws-amplify to a new project and running react-native run-ios:
error: bundling failed: Error: EISDIR: illegal operation on a directory, read
    at Object.fs.readSync (fs.js:693:18)
    at Object.readSync (/opt/projects/awsAmplifyTest/node_modules/graceful-fs/polyfills.js:138:28)
    at tryReadSync (fs.js:557:20)
    at Object.fs.readFileSync (fs.js:600:19)
    at Module._readSourceCode (/opt/projects/awsAmplifyTest/node_modules/metro/src/node-haste/Module.js:194:29)
    at Module._getCacheProps (/opt/projects/awsAmplifyTest/node_modules/metro/src/node-haste/Module.js:386:29)
    at Module._readFromTransformCache (/opt/projects/awsAmplifyTest/node_modules/metro/src/node-haste/Module.js:347:29)
    at Module.readCached (/opt/projects/awsAmplifyTest/node_modules/metro/src/node-haste/Module.js:334:19)
    at /opt/projects/awsAmplifyTest/node_modules/metro/src/node-haste/Module.js:315:29
    at Generator.next (<anonymous>)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than AWS Amplify.
react-native init awsAmplifyTest
cd awsAmplifyTest
npm install --save aws-amplify
npm install --save aws-amplify-react-native

add import Amplify from "aws-amplify"; to index.js.
react-native run-ios
What is the expected behavior?
The project runs without error.
Which versions of Amplify, and which browser / OS are affected by this issue? Did this work in previous versions?
"aws-amplify": "^0.4.0",
"aws-amplify-react-native": "^0.2.11",
"react": "16.3.1",
"react-native": "0.55.4"
node 8.11.2

I will add that the newly created project runs without error. It is only once I add aws-amplify that this issue surfaces.

If I delete the import in index.js the app will build and run successfully.
Also tried:
watchman watch-del-all
rm -rf node_modules && npm install
rm -rf /tmp/metro-bundler-cache-*
rm -rf /tmp/haste-map-react-native-packager-*

and restarted the machine. Reproducible repo here.

@joebernard when using react-native and NOT Expo, you need to link the amazon-cognito-identity-js native module, see [here](react-native link amazon-cognito-identity-js) for details.
$ react-native init myReactNativeApp
$ cd myReactNativeApp
$ npm install --save aws-amplify
$ npm install --save aws-amplify-react-native
$ react-native link amazon-cognito-identity-js

Hi @mlabieniec . I forgot to add this step to my bug report. I did complete the link and still have the same issue.
react-native link amazon-cognito-identity-js
Scanning folders for symlinks in /opt/projects/awsAmplifyTest/node_modules (63ms)
rnpm-install info Platform 'ios' module amazon-cognito-identity-js is already linked
rnpm-install info Platform 'android' module amazon-cognito-identity-js is already linked

I attempted a brand new installation under my ~/ home directory using the same steps. Same issue.
Then I tried a create-react-native-app installation and installed the aws packages. This seems to get around the problem and it compiles correctly. The issue is within react-native init or I am calling it incorrectly somehow.

I'm not able to solve this. I created a new project and migrated my code to move on.


TypeError for specific data set created with graph_tool

Specific data set created with graph_tool (http://graph-tool.skewed.de/), attached to ticket (graph.xml.gz).
Supplying this file as input data to test.py immediately yields (even before version control check) a TypeError: expected string without null bytes.
Full trace stack:
{{{
Traceback (most recent call last):
File "/usr/local/bin/smt", line 5, in
pkg_resources.run_script('Sumatra==0.5.2', 'smt')
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 499, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/lib/python2.7/dist-packages/pkg_resources.py", line 1235, in run_script
execfile(script_filename, namespace, namespace)
File "/usr/local/lib/python2.7/dist-packages/Sumatra-0.5.2-py2.7.egg/EGG-INFO/scripts/smt", line 31, in
main(sys.argv[2:])
File "/usr/local/lib/python2.7/dist-packages/Sumatra-0.5.2-py2.7.egg/sumatra/commands.py", line 314, in run
parameters, input_data, script_args = parse_arguments(args, project.input_datastore)
File "/usr/local/lib/python2.7/dist-packages/Sumatra-0.5.2-py2.7.egg/sumatra/commands.py", line 93, in parse_arguments
parameter_sets.append(build_parameters(arg))
File "/usr/local/lib/python2.7/dist-packages/Sumatra-0.5.2-py2.7.egg/sumatra/parameters.py", line 445, in build_parameters
parameters = SimpleParameterSet(filename)
File "/usr/local/lib/python2.7/dist-packages/Sumatra-0.5.2-py2.7.egg/sumatra/parameters.py", line 158, in init
self.values[name] = eval(value)
TypeError: expected string without null bytes
}}}
To reproduce just pass graph.xml.gz as argument to empty test script test.py:
smt run --executable=python --main=test.py data/graph.xml.gz
Imported from Bitbucket issue 195,  created by Felix11H on 01-17-2014 at 08:54, last modified: 01-21-2014 at 15:10

should be fixed in 58e2c8181a1a23a37b69b0613c2492ff74fcfaf3
Trac comment by apdavison on 01-21-2014 at 15:10


chore: bump gravitee-bom to 8.1.19

Issue
https://gravitee.atlassian.net/browse/APIM-6684
Description
Bump gravtiee bom to latest
Additional context

Already applied on master


Question: exclude sub folders from project?

I wonder if i possible to exclude some folder from a project.
Consider the following structure:

proj root

a
b
c

whereas proj root is the main folder and contains also folders and files that I want to edit. b is a sub folder that I want to ignore (but it's name/path could change from project to project).
ATM I do atom path/to/root but this loads all items in the root and sub folders and looks like there's no way to exclude b or any other item on demand. In tree view I find "add folder to project" or "remove folder from project" but it works only at root level.

    settings:
      core:
        ignoredNames: [
          "some_folder"
          ....
        ]

@JustinAiken works! thanks :smile:


Add argument checking for api calls

Currently there is no argument checking for API calls.  I'd like to open this issue up for discussion.

Checking the arguments isn't necessarily required I think. At least on the entry points. The code we use to transform a 'template' request string into a real request string may be a good place to check. Possibly we can just use a 3rd party library for this.

We already use underscore, so we could probably do the uri replacement with template:
http://underscorejs.org/#template
This would throw an exception if a parameter wasn't defined


Fix boolean search scroll issue

It seems like boolean search was relying on chaise app.css. With the recent changes to the chaise app.css, the scrollbar of boolean search app is broken and we should fix it.

@jrchudy @RFSH can one of you fix this bug? I don't have anyone else to work on this.

I just realized that this is in-review.. @RFSH if this problem no longer exists on production, please close the issue.


Fixed Price

It is possible to modify it to put a fixed price.
Example 0.0005 BTC Sell and Buy
I really like your project
Thanks Friend

This is possible but the API limits the requests for certain currency pairs.


minor

Adding documentation as a way to test the process.

Coverage remained the same at 70.36% when pulling fe0d4863d51238fd83cc9fcfa15f95d2448d92b0 on firstCheckin into 082ca8319d7959227e7514f5ba1aea8380661d91 on master.

:+1: merge at will

Done, thank you!
On Fri, Apr 17, 2015 at 5:18 PM, Adam Kiezun<EMAIL_ADDRESS>wrote:

Assigned #386 https://github.com/broadinstitute/hellbender/pull/386 to
@jean-philippe-martin https://github.com/jean-philippe-martin.
—
Reply to this email directly or view it on GitHub
https://github.com/broadinstitute/hellbender/pull/386#event-284336758.

@jean-philippe-martin  after a merge, delete the branch

Welcome to Hellbender!

@jean-philippe-martin can you delete the branch?

sure thing, I deleted it now. Sorry for not doing it earlier!
On Fri, Apr 17, 2015 at 8:29 PM, Adam Kiezun<EMAIL_ADDRESS>wrote:

@jean-philippe-martin https://github.com/jean-philippe-martin can you
delete the branch?
—
Reply to this email directly or view it on GitHub
https://github.com/broadinstitute/hellbender/pull/386#issuecomment-94122144
.


build: add Kokoro configs for new instance cluster

@chingor13 I see this has "do not merge", but internal configs already merged in. Is this still intended to get in? Are there any blockers for this?

The experimentation is done. The job has been deleted.


Validators SNBAT use the attestation signer key or vote signer key for managing validators/groups

Expected Behavior
getAccounts().validatorSignerToAccount(msg.sender) for all Validators.sol account related actions
Current Behavior
What is the current behavior?
getAccounts().signerToAccount(msg.sender) is used for Validator registration, affiliation, and key rotation
This could lead to a scenario where the ephemeral attestation or vote signing key is compromised and someone's validator is manipulated as a result
Changed on #1643

In DowntimeSlasher.sol and DoubleSigningSlasher.sol we have to use signerToAccount because validatorSignerToAccount requires the current validator signer.

Looks like these have already been changed.


Fixing bug: Auto validate should not execute action

Coverage remained the same at 100.0% when pulling d3bb4c373ec4c95a59c8e8dc101ce0079f24fe62 on ktutnik:master into 90e54ebf123d6ea98e129c63e8a068202686a9b0 on kambojajs:master.


Running on WGS samples

Hi,
I am interested in running VarDict on WGS samples. I tried running it without a BED file for b37 but I get no variants called (I only see a VCF header). When I tried running VarDict on targeted panel sequencing with a BED file, it worked fine.
This was the command I used:
AF_THR="0.01"

tumor_sample_name=$1
tumor_bam=$2
normal_sample_name=$3
normal_bam=$4

vardict -G /path/to/b37/human_g1k_v37_decoy.fasta -f $AF_THR -N ${tumor_sample_name}\
 -b "${tumor_bam}|${normal_bam}" | testsomatic.R | var2vcf_paired.pl -N\
 "${tumor_sample_name}|${normal_sample_name}" -f $AF_THR

Is a BED file necessary? If so, how can we get one for b37?

Hi Viktor, I answered to issue in VarDictJava repository, so I'll close this one!


Leaky Bucket implementation

Implement Leaky Bucket Algorithm for Rate Limiter
Overview
Implement the Leaky Bucket algorithm as a concrete implementation of our rate limiting framework's RateLimitingAlgorithm base class. This will provide a queue-based rate limiting solution that processes requests at a consistent rate.
Algorithm Description
The Leaky Bucket algorithm works by:

Maintaining a fixed-size queue (bucket) of requests
Processing requests at a constant rate (like water leaking from a hole)
New requests are rejected when the bucket is full
Follows FIFO (First In, First Out) principle for request processing

Implementation Requirements
Class Structure
from rate_limiter.algorithms.base import RateLimitingAlgorithm
from rate_limiter.core.request import RateLimitRequest
from rate_limiter.core.response import RateLimitResponse

class LeakyBucketAlgorithm(RateLimitingAlgorithm):
    def __init__(self, bucket_size: int, leak_rate: float):
        """
        Initialize the leaky bucket algorithm

        Args:
            bucket_size: Maximum number of requests the bucket can hold
            leak_rate: Number of requests processed per second
        """
        pass

Required Method Implementations

allow_request method:

Check if bucket has capacity
Handle concurrency safely
Return appropriate RateLimitResponse

get_status method:

Report current bucket fill level
Report processing statistics
Return algorithm configuration

Technical Requirements

Performance

O(1) time complexity for allow/reject decisions
Efficient queue management

Metrics

Track request acceptance/rejection rates
Monitor bucket utilization
Record processing latency

HTTP Integration

Set appropriate rate limit headers
Include retry-after times when rejecting
Handle request metadata

Testing Scenarios

Basic Functionality

Bucket fills correctly
Requests are processed at the specified rate
FIFO order is maintained

Edge Cases

Empty bucket behavior
Full bucket behavior
Concurrent request handling
Rate limit boundary conditions

Integration Tests

FastAPI middleware integration
Header handling
Request identification

Acceptance Criteria

[ ] Implements RateLimitingAlgorithm interface correctly
[ ] Handles concurrent requests safely
[ ] Maintains constant processing rate
[ ] Sets appropriate HTTP headers
[ ] Includes comprehensive test suite
[ ] Documentation with usage examples
[ ] Performance benchmarks

Resources

Project's algorithm base class: src/rate_limiter/algorithms/base.py
Core request/response models: src/rate_limiter/core/
Leaky Bucket Algorithm Overview

#6

closed with #6


abolished H3-H4 loading

abolished H3-H4 dimer loading onto DNA
synonym: abolished H3-H4 dimer loading activity
PMID:31848341
for xp, use GO:new from https://github.com/geneontology/go-ontology/issues/21580

tangent: maybe also generic "abnormal nucleosome assembly" to group some existing terms

abnormal H3-H4 dimer loading onto DNA FYPO:0007804
abolished H3-H4 dimer loading onto DNA FYPO:0007805


More feature

Example:
https://github.com/putuwahyu29/feednews

Example:
https://github.com/putuwahyu29/feednews

Interesting

Other Example
https://github.com/shankrmahadevan/tamil-news-feed

Other Example
https://github.com/shankrmahadevan/tamil-news-feed

Demo?

No but Look like news Website.

No but Look like news Website.

This is a plugin multi sources scalable RSS feed component, not a news website, easily integrated into Vue projects. But I'll keep in mind doing a full news website with pictures.

Sorry what are you trying to imply here?

https://github.com/shankrmahadevan/tamil-news-feed
This website Use RSS  Feed But Look like News Website

Sorry what are you trying to imply here?

https://github.com/shankrmahadevan/tamil-news-feed
This website Use RSS  Feed But Look like News Website

I cant see the website, so hard to comment on it. About this repo is a multi sources scalable RSS feed plugin/component, not meant for making a news website, it is meant for easily integrated into Vue projects that requires custom RSS scalable feed. For a news website, I have plans too and I'll keep in mind doing a full news website. Don't mind suggesting what features needed based on your view for news website? Thanks

Okay Thanks

Sorry what are you trying to imply here?

https://github.com/shankrmahadevan/tamil-news-feed
Currently not available demo but i check this website source code .
This website Use RSS  Feed But Look like News Website

It would be nice if this author set up his GitHub Pages for this repo

Okay Thanks

Thank you for the suggestions

@BioBut Review the site now, features added as per your suggestion

@BioBut Review the site now, features added as per your suggestion

nice features but other example
https://www.zergnet.com/

@BioBut Review the site now, features added as per your suggestion

nice features but other example
https://www.zergnet.com/

Nice site. Will look it up a way

More Rss Feed Link available
https://github.com/simevidas/web-dev-feeds

Interesting repo. Nice place to hunt for more sources. Thanks again

More Rss Feed Link available
https://github.com/simevidas/web-dev-feeds

More sources of RSS links added as per request

Nice Project But Your project not support  1000 Rss Feed But possible
example:
https://github.com/MillanUka/RSS-Feed-Reader

I have reviewed her website, looks like she uses dynamic RSS feed url inputs from user itself and store them in to their local storage. Nice feature. But maybe I can do this for my own project in future in separate project, easy one. The issue is for this component, since my client only wants selected feeds into his components, bear in mind this is for Fintech website of his. So that's the limitation. Otherwise awesome suggestion. Technically, this component cam support unlimited amount of feeds and topics, but it's hard code and not user specific like u suggested. Thanks again for the input.


Option to hide/resize preview pane

It'd be great to be able to hide and/or resize the preview pane.

Note: preview can be hidden by pressing F12.


TypedMap: Fix typo in class phpdoc

Description
Removed the leading = sign at the end of line 23
Motivation and context

How has this been tested?
N/A
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have run composer br:test:all locally, and there were no failures or errors.

Thank you for contributing! 🎉

Thank you for contributing! :tada:

Glad to be of service :wink:


iam-mfa.py: how to correctly use?

Hello,
Is there a suggested deployment for iam-mfa.py?  I tried to deploy it as a triggered rule, but it never triggered on users adding an MFA token.  AWS Support says that MFA token changes don't count as config changes, so that makes some sense.  But then I'm not sure how the rule can work as described in RULES.md.
Support suggests deploying as a periodic rule, but not having per-user results undermines the usefulness of the rule.
Thanks for any suggestions,
Ross

Hi Ross,
As you pointed out, MFA token changes don't trigger change notifications to AWS Config at the moment, so this rule has to be run as a periodic rule. Periodic rules can only report compliance against the Account, instead of individual resources (or users, in this case).
We are considering some options to improve the experience in this area, particularly for periodic rules. Would love to hear feedback from users, of course.
Thanks,
Aaron


Strict author check would fail on non-ASCII names

In https://github.com/ianstormtaylor/metascraper/blob/master/lib/rules/author.js. Maybe a better check is /^\S+\s+\S+/?

Damn, yeah. Trouble for this specific one is that I was edging towards having fewer false positives, at the expense of throwing on some valid names. If we loosen it too much, it starts matching things with symbols in them, etc. Not sure if there's a good solution 😖

Open to ideas though, or even completely different rules that come before it that make the later ones irrelevant!

I don't mind on false positives as much. I'd prefer to get more rather than less data. That said, it could skip a few other characters. E.g. /^[^\s$#@!&*]+\s+[^...]/. The problem is, it's even perfectly legitimate to have some symbols such as "Dr. Who", "O'Farrell, James", etc. I think I'd err on the side of less strictness and use the non-whitespace, whitespace, non-whitespace until you have more data on this (unless you already do?)

Sounds good to me, added a ton of new test cases and it only affected one, in a positive way! Added in 0.2.4


How to use amd branch for Select2 4.x

Can somebody please explain how to use this plugin in a project using Select2 4.x?
I am trying to understand how to use the amd branch by reading the example code but I can't be sure about how to do it.
Is there any other file I need to use other than select2.multi-checkboxes.js? Where should I put dropdown.js, result.js and selection.js files and how should I import them in the project?
A short explanation can be a great help.
Thank you.

Actually,  I provided 2 examples. One for native AMD system (RequireJS) where sources are as they are and second simpler for Select2. Latter uses bundled sources to be easier to import to existing projects, but I forgot to try to create a third example where sources are not bundled and used by AMD loader from Select2. I'll check soon and create that example if it would work seamlessly. Probably the bundled one would be enough for you, so I will create a release with it.

It works when I use your attachment. Thank you!


Fantastic job!

Hello again!
First - well done, nice, clean, and quite clever.
Code works, download works, issue with:
legimi-go list -> on OSx: most of attempts gave "Error while executing command: decoding error: EOF"
For second account it will not load the list at all (but will download) as book id's seem to be the same (as I accidentally tested it).
All the best,

Thanks for your feedback.
Issue with EOF while listing books is actually on my TODO list. I just haven't got time to work on code after initial release.
If download works, you don't have to list books at all. You can always obtain book IDs from book URLs. For example: https://www.legimi.pl/ebook-problem-trzech-cial-liu-cixin,b173281.html would have id 173281. Listing and copying from terminal is just more convenient.
I don't know entirely why listing books didn't work for second account. Probably better error handling would reveal something. I want to deal with it when I have some time.

I took a look at EOF error and released new version that should fix it. Let me know if this works for you.
For issue of not loading the list for second account, you can double-check if you provided correct Kindle Serial Number. It happened to me that I entered partial serial number and it returned some value for the id, but listing books actually printed nothing (even no error).

I just tested it. Same issues as before.
The accound that didn't list any files in previous version - didn't list any files this time around in the new version (I re entered serial number), download worked on that account - tried 20-30 times.
("Error while executing command: decoding error: EOF")
Errors on the other account:
"Error while executing command: decoding error: EOF"
"Error while executing command: decoding error: book metadata type should be 7, found 0"
"Error while executing command: decoding error: book metadata type should be 7, found 24"
Last ones showed up before in previous version of legimi-go.
In general EOF shows up most of the time, other ones ocassionally.
Please keep it in mind I am testing on OSx.
Great work!

It shouldn't matter that you're on OSx, it looks rather like parts of protocol types that are not covered by the app. I'll try to find out what's wrong.
More important is that downloading works without issues.

I am unable to reproduce on my side. I suspect there are some different types of books on your shelf that script cannot parse correctly and either tries to read more bytes than available (EOF) or ends up reading in wrong place (metadata type mismatch).
I prepared special version of script that write book list response to file (booklist.dump in current working directory). Is it ok for you to download this version, try to list books and share the resulting file with me? It won't contain your credentials or session id, just list of books on your shelf.
You can download this debugging version with go install github.com/tp86/legimi-go@book-list-debug, but you need to have Go installed. I don't want to prepare release for debugging purposes, but if you have trouble installing and running or don't want to install Go, let me know, I'll prepare executable.

Hello hello,
My bad, for whatever reason the previous (correctly working version) didn't install.
I was running on the old version. I only realised that when I installed 0.2.1 and later reinstalled 0.2.0.
I don't know what happened and I am trully sorry for the trouble.
No EOF present, checked both accounts.
Golden! works like a charm.
If you want the debug file I can share it - but I believe there is no need.
Thanks a million for the work - amazing!!!!
If you need any other testing in the future, you can count me in.
I get notifications about any new updates - so I will keep an eye as well.

That's great news! I'm glad that it works. I was afraid that there are some uncovered types of books that you could download - this would be hard to fix without looking at raw data returned from server.
Now, as it works, there is indeed no need for you to share debug file.


Custom easing functions aren't used

The Readme says a custom easing function can be passed in the config object, but it doesn't seem to get used.
Checked the source and I don't see anything that could support a custom easing function.
Am I going mad?
Here is my example.
var svg = new Walkway({
    selector: '#my-svg',
    duration: 1000,
    easing: function(t) {
        console.log('never gets called');
        return t;
    }
});

@JasonStorey Thanks for bringing this bug to my attention. It's fixed now.


Add Preloader for Login and Signup

hey @Shubham29012001 can u remove set timeout and let it load till the response or error has not come
also remove the conflict plz

Hey @mohityadav0903, can you please review the changes.