Nav2 Goal Tool problem

Robot Model
Turtlebot4 Standard
ROS distro
Humble
Networking Configuration
Simple Discovery
OS
Ubuntu 22.04
Built from source or installed?
Installed
Package version

Type of issue
Navigation (SLAM, Nav2 etc.)
Expected behaviour
In Rviz, after defining the robot's initial 2D point, my customer uses the Nav2 Goal Tool and then the robot move to the goal pose.
Actual behaviour
When my customer tries to move the robot by clicking on the map in Rviz with the Nav2 Goal Tool, he gets the erro "Goal was rejected by server", and the robot doesn't move.
Error messages
No response
To Reproduce
" I added these lines to the .bashrc file, and I execute "source .bashrc" in all new terminals.
CYCLONEDDS_URI='true</></></></>'
export CYCLONEDDS_URI='true</></></></>'
source /etc/turtlebot4/setup.bash
source /etc/turtlebot4_discovery/setup.bash
I follow these steps:
$ ros2 launch turtlebot4_navigation localization.launch.py map:=map2.yaml
$ ros2 launch turtlebot4_navigation nav2.launch.py
$ ros2 launch turtlebot4_viz view_robot.launch.py
Then I define 2D Pose and click on the goal with Nav2 goal tool.
"
Other notes
No response

Hello,
Is it possible to have an answer for this ?
Best regards.

Hello,
I'm adding details about what my client did:
"
If I execute ros2 topic echo /clicked_point and then I click in the map with Publish point tool the result is:
lubuntu@lubuntu-virtualbox:~$ ros2 topic echo /clicked_point
header:
stamp:
sec:<PHONE_NUMBER>
nanosec: 560450592
frame_id: map
point:
x: -0.0640483945608139
y: 0.49885591864585876
z: -0.001434326171875
If I click on Nav2 Goal tool there isn't any result in ros2 topic echo /clicked_point.
If I define 2D Estimate Pose the message in "ros2 launch turtlebot4_navigation localization.launch.py map:=map_name.yaml" terminal is:
[amcl-2] [INFO] [1712171035.497726404] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1712171035.497853082] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.497794 but the latest data is at time<PHONE_NUMBER>.695519, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1712171035.497879207] [amcl]: Setting pose<PHONE_NUMBER>.497879): -0.371 0.112 -0.044
Then, I select Nav2 Goal and click over the map in rviz window, the message in rviz is:
[rviz2-1] [INFO] [1712171035.497385713] [rviz2]: Setting estimate pose: Frame:map, Position(-0.370674, 0.112453, 0), Orientation(0, 0, -0.0221002, 0.999756) = Angle: -0.0442039
[rviz2-1] Start navigation
[rviz2-1] [ERROR] [1712171060.108202585] [rviz_navigation_dialog_action_client]: navigate_to_pose action server is not available. Is the initial pose set?
"

He needs to set his initial pose in order to be able to use the navigate to commands. It seems that he is unable to because his computer / robot times are not synced, they are catually off by roughly 10 seconds.

[amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future. Requested time<PHONE_NUMBER>.497794 but the latest data is at time<PHONE_NUMBER>.695519, when looking up transform from frame [base_link] to frame [odom])

By default the robot will sync with the internet so the easiest thing it generally to ensure that your PC is also syncing time with the internet (default Ubuntu servers). @RustyCPR @smatarCPR I will leave it to you guys to guide the conversation from here as necessary.

Hello,
Thank you for your reply.
So concretely, my customer has to make sure that his PC and the robot are connected to the same internet network? Or does he have to do something else specific?
Best regards.

Hello @ValentinLeglise ,
Yes, please ensure that your customer has their PC and Turtlebot 4 connected to the same internet network.
A few items they can check after performing this is ensuring that the their computer is syncing it's time using the internet and that it is the same as the time seen on the Raspberry Pi and Create3. They can check this using timedatectl per the instructions found here: https://ubuntu.com/server/docs/use-timedatectl-and-timesyncd
Let me know how these recommendations work for them. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
Thank you for your response.
My customer has set the same time zone and configured an NTP server. You can see a video attached
Lubuntu ROS2-screen0.webm
But he still has problems. This is the rviz output:
[rviz2-1] [INFO] [1712860064.269354609] [rviz2]: Setting estimate pose: Frame:map, Position(-0.526121, -3.19067, 0), Orientation(0, 0, -0.111025, 0.993818) = Angle: -0.22251
[rviz2-1] Start navigation
[rviz2-1] [ERROR] [1712860096.166775746] [rviz_navigation_dialog_action_client]: navigate_to_pose action server is not available. Is the initial pose set?
and the other terminal:
[amcl-2] [INFO] [1712860064.269593607] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1712860064.270124668] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.270090 but the latest data is at time<PHONE_NUMBER>.134059, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1712860064.270412330] [amcl]: Setting pose<PHONE_NUMBER>.270412): -0.526 -3.191 -0.223
and other terminal
[controller_server-1] [INFO] [1712859031.377621964] [local_costmap.local_costmap]: StaticLayer: Resizing static layer to 153 X 304 at 0.050000 m/pix
What should he do ?
Best regards, Valentin.

Hello Valentin,
Apologies for the late reply on this. While the video does show that the times reported are synced to the second, it appears that based on the amcl-2 error output, there is about 0.15s of discrepancy between the devices:
[amcl-2] [WARN] [1712860064.270124668] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future. Requested time<PHONE_NUMBER>.270090 but the latest data is at time<PHONE_NUMBER>.134059, when looking up transform from frame [base_link] to frame [odom])
Based on the information provided, running a discovery server setup, what you will need to do is to make sure that your laptop is also syncing time with the internet and these should all match.
If you still seem to be seeing issues then it could be helpful to reboot the robot and your PC and potentially restart the ntpd from the create3 webserver. Similarly try forcing a time sync on your laptop. (More details on how to check last time sync etc on ubuntu here. Run the command: systemctl status systemd-timesyncd and see when the timesync last occurred. For the Raspberry Pi, you can use systemctl status chrony to see when the last sync was and you can force a sync by restarting the chrony service.
I also notice that it appears that the client is using a virtual machine, does a similar issue arise if they are running on a system that is running Ubuntu natively?
Let me know the results of these checks. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
Thank you for your response. I will share these information to my customer.
Yes he uses a VM because he doesn't have Ubuntu native machine.
I will let you know the results.
Best regards, Valentin.

Hello,
I've got some news. The customer thinks he has solved the synchronization problem. He had a first error (again) and then he had two successful attempts.
"[amcl-2] [INFO] [1713812213.103042274] [amcl]: initialPoseReceived
[amcl-2] [WARN] [1713812213.103188216] [amcl]: Failed to transform initial pose in time (Lookup would require extrapolation into the future.  Requested time<PHONE_NUMBER>.103157 but the latest data is at time<PHONE_NUMBER>.100003, when looking up transform from frame [base_link] to frame [odom])
[amcl-2] [INFO] [1713812213.103201048] [amcl]: Setting pose<PHONE_NUMBER>.103201): -2.218 1.344 -0.044
[amcl-2] [INFO] [1713812311.987260738] [amcl]: initialPoseReceived
[amcl-2] [INFO] [1713812311.987758227] [amcl]: Setting pose<PHONE_NUMBER>.987758): -2.178 1.494 -0.144
[amcl-2] [INFO] [1713812386.537784338] [amcl]: initialPoseReceived
[amcl-2] [INFO] [1713812386.537843305] [amcl]: Setting pose<PHONE_NUMBER>.537843): -2.177 1.510 0.104"
However, he still has problems navigating. According to the customer, the robot somble accepts the initial pose, but when he clicks on Rviz to make it move, he gets the following error:
"[rviz2-1] Start navigation
[rviz2-1] [ERROR] [1713812370.525654847] [rviz_navigation_dialog_action_client]: navigate_to_pose action server is not available. Is the initial pose set?
[rviz2-1] [INFO] [1713812386.537132885] [rviz2]: Setting estimate pose: Frame:map, Position(-2.17687, 1.51047, 0), Orientation(0, 0, 0.0517994, 0.998658) = Angle: 0.103645
[rviz2-1] Start navigation
[rviz2-1] [ERROR] [1713812403.632853279] [rviz_navigation_dialog_action_client]: navigate_to_pose action server is not available. Is the initial pose set?"
Do you know where it might come from?
Thanks for your help.

Hello @ValentinLeglise ,
It is good to hear that the time sync issue has been resolved. With regards to the current issue regarding the action server, would it be possible for the client to share the full commands they are running and the full terminal outputs from the three command terminals?
We'll take a look at the full details and let you know when we find the cause of this error. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
Sorry for this late reply.
There you can find the output of the 3 commands:
output.txt
Hope this will be useful.
Best regards, Valentin.

Hello,
would it be possible to have a quick answer please?
Thanks for your understanding.
Kind regards, Valentin.

Hello CP.
Sorry to bother you again, but this ticket has been running for over a month and we need to finish it as soon as possible. Would it be possible to get an answer soon? Best regards, Valentin.

Hello @ValentinLeglise ,
Apologies for the late reply on this. Reviewing the logs provided, there appears to be an underlying issue with Nav2:
[controller_server-1] [INFO] [1714753099.450773148] [local_costmap.local_costmap]: start
[controller_server-1] [INFO] [1714753099.654741214] [controller_server]: Creating bond (controller_server) to lifecycle manager.
[controller_server-1] [WARN] [1714753101.450932432] [local_costmap.local_costmap]: Can't update static costmap layer, no map received
[lifecycle_manager-8] [ERROR] [1714753101.686267488] [lifecycle_manager_navigation]: Server controller_server was unable to be reached after 4.00s by bond. This server may be misconfigured.
[lifecycle_manager-8] [ERROR] [1714753101.686784340] [lifecycle_manager_navigation]: Failed to bring up all requested nodes. Aborting bringup.
[controller_server-1] [WARN] [1714753103.450996255] [local_costmap.local_costmap]: Can't update static costmap layer, no map received
[lifecycle_manager-8] terminate called after throwing an instance of 'statemap::TransitionUndefinedException'
[lifecycle_manager-8]   what():  no such transition in current state
[ERROR] [lifecycle_manager-8]: process has died [pid 3696, exit code -6, cmd '/opt/ros/humble/lib/nav2_lifecycle_manager/lifecycle_manager --ros-args --log-level info --ros-args -r __node:=lifecycle_manager_navigation -r __ns:=/ --params-file /tmp/launch_params_cqyf1t1p --params-file /tmp/launch_params_rpjvliy7 --params-file /tmp/launch_params_eo7hts76 -r /global_costmap/scan:=/scan -r /local_costmap/scan:=/scan'].

The most likely cause for these errors could be due to a lack of resources available to the virtual machine running Ubuntu. If the client has the option available to them, swapping to a system running Ubuntu natively is highly recommended.
If they cannot switch to such a system, allocating more resources to the VM may be a workaround.
Let me know which option is taken and how this recommendation works for your client. Looking forward to hearing from you soon.
Best Regards,
Saif

Hello,
They are forced to use a virtual machine. What resources do they need and how they can get it ?
Best regards

Hello @ValentinLeglise ,
What are the current settings for the VM (i.e. what processor have they virtualized, how much RAM and storage has been allocated to the machine?)
What type of machine is hosting the VM? Is it a standard desktop/laptop or a server?
Does the VM have its network settings bridged/cloned from the host machine, or does it use a virtual network adapter?
Looking forward to hearing from you soon.
Best Regards,
Saif M.

Hello,
Is it possible to have a response for this ?
Best regards, Valentin.

Hello @ValentinLeglise ,
Apologies for the late reply on this. Looking at the resources listed, our first recommendation is to increase the RAM available to the VM. The client can start by setting the amount available to 4 GB or 8 GB and see how this affects performance. ANother item they can modify is the disk space available, increasing from 25 GB to 40 GB or more.
Ideally however, the client should run Linux natively as that is the supported platform for interfacing with a Turtlebot4.
Let me know if you have any questions or if I can help with anything else.
Best Regards,
Saif M.

Hello,
Sorry for the late reply. Here is my customer's response:
"I have increased the resources of the virtual machine, but it still doesn't work. The error I'm getting is as follows:
[rviz2-1] Start navigation
[rviz2-1] [INFO] [1719309944.970291794] [rviz_navigation_dialog_action_client]: NavigateToPose will be called using the BT Navigator default behaviour tree.
[rviz2-1] [ERROR] [1719309944.970918850] [rviz_navigation_dialog_action_client]: Goal has been rejected by the server.
"
Is this error always due to a lack of resources?
Best regards, Valentin.

Hello ClearPath,
Is it possible to have an answer for this please ?
Best regards, Valentin.

Hello,
It's been nearly two weeks since I've had a reply regarding this ticket. Would it be possible to get a reply?
Best regards

Hello @ValentinLeglise ,
Apologies for the late reply. Regarding this matter:
It is expected that the action server rejects the goal based on the initial error the client was observing:
[controller_server-1] [INFO] [1714753099.450773148] [local_costmap.local_costmap]: start
[controller_server-1] [INFO] [1714753099.654741214] [controller_server]: Creating bond (controller_server) to lifecycle manager.
[controller_server-1] [WARN] [1714753101.450932432] [local_costmap.local_costmap]: Can't update static costmap layer, no map received
[lifecycle_manager-8] [ERROR] [1714753101.686267488] [lifecycle_manager_navigation]: Server controller_server was unable to be reached after 4.00s by bond. This server may be misconfigured.
[lifecycle_manager-8] [ERROR] [1714753101.686784340] [lifecycle_manager_navigation]: Failed to bring up all requested nodes. Aborting bringup.
[controller_server-1] [WARN] [1714753103.450996255] [local_costmap.local_costmap]: Can't update static costmap layer, no map received
[lifecycle_manager-8] terminate called after throwing an instance of 'statemap::TransitionUndefinedException'
[lifecycle_manager-8]   what():  no such transition in current state
[ERROR] [lifecycle_manager-8]: process has died [pid 3696, exit code -6, cmd '/opt/ros/humble/lib/nav2_lifecycle_manager/lifecycle_manager --ros-args --log-level info --ros-args -r __node:=lifecycle_manager_navigation -r __ns:=/ --params-file /tmp/launch_params_cqyf1t1p --params-file /tmp/launch_params_rpjvliy7 --params-file /tmp/launch_params_eo7hts76 -r /global_costmap/scan:=/scan -r /local_costmap/scan:=/scan'].

The launch of the nav2 stack failed and thus there is no server to receive the goal and it will be rejected. Most likely the failure to launch is due to a lack of resources, you can have the client try increasing CPU resources available or lengthening the Nav2 Bond timeout to see if more time is sufficient to get all components running and communicating.
However, as stated before, virtual machines are not a supported platform and we strongly urge the client to transition to a machine running Linux natively.
If they want to modify the Nav2 bond timer they can make a copy of the nav2.yaml, modify it and then pass it in when they launch the turtlebot4 nav2 node. For documentation on bond_timeout and how that is set in a yaml file see https://docs.nav2.org/configuration/packages/configuring-lifecycle.html#parameters.
Let me know how these recommendations work for you. Looking forward to hearing from you soon.
Best Regards,
Saif

What does it mean for a VM not to be a supported platform? The guest OS has no idea if it is running in a VM or not, nor should it need to assume to run on real hardware or not. If ROS2 cannot deal with timing characteristics that is a flaw that will not only show up in a VM. Yes it happens more often there, but with multiple processes running there is no timing guarantee on a native OS either, timing variations shouldn't crash ROS.

@patham9 ROS 2 and Turtlebot4 should run perfectly well using VM's given that they are set up properly with the required resources and appropriate networking configuration. However, the level of user that is learning ROS 2 with Turtlebot4 tends not to be equipped to configure VM's properly, commonly facing resource starvation among other issues. These users need to be using native systems to reduce the troubleshooting scope of their system both for their sake and for ours. It is not a realistic goal for us to be supporting the various issues of setting up VMs. Therefore we officially do not provide support for VM setups for the Turtlebot 4 product although many advanced users may be using VM's or containers. We try to provide troubleshooting suggestions where we can, when users report using a VM, but we are not able to go to the extent of trying to replicate such issues or dig too much into how any one VM is configured. That is what it means for VM's to not be supported in this context. You are free to do it but we can't provide support for it.

@hilary-luo: I see, this makes sense. Thank you for clarifying!


Add awesome icon in  project cards

Issue

Fixes #910.
Description
Adds awesome icon when logo field is not an image.
We can change the icon color if needed.
Test Evidence

Toha card has logo: "fa-solid fa-hippo", while Jellyfin has: logo: /images/jellyfin.webp.

Hi @BernatBC,
Just test, it works fine ! Thank :)


Lazyload supported in Chrome 77

Announcement https://developers.google.com/web/updates/2019/09/nic77
Demo with images https://mathiasbynens.be/demo/img-loading-lazy

This file's data is for the lazyload attribute, only supported by IE & Edge. The support you're referring to is for the loading attribute, which is covered at https://caniuse.com/#feat=loading-lazy-attr (and already notes Chrome's support)


Noarch repodata.json is empty for proxy channels

In our quetz server, we proxy conda-forge into a channel of the same name:
  {
    "name": "conda-forge",
    "description": null,
    "private": true,
    "size_limit": null,
    "ttl": 36000,
    "mirror_channel_url": "https://conda.anaconda.org/conda-forge",
    "mirror_mode": "proxy",
    "members_count": 1,
    "packages_count": 0
  },

Installation often fails because certain packages cannot be found. We narrowed the issue down to the noarch repodata.json being empty. Navigating to /get/conda-forge/noarch/repodata.json yields:
{
  "info": {
    "subdir": "noarch"
  },
  "packages": {},
  "packages.conda": {},
  "repodata_version": 1
}

This problem only occurs for the noarch platform. Also, in our package backend (GCS) we have a cached version of the repodata.json, which is not empty (it's 55MB large).
Any idea what might be causing this?

hmmm, this is the code in question: https://github.com/mamba-org/quetz/blob/05dbfc65529c6a81acdab899ad509d85496802cd/quetz/main.py#L1645-L1654
I wonder if the gzip magic does something bad here: https://github.com/mamba-org/quetz/blob/05dbfc65529c6a81acdab899ad509d85496802cd/quetz/main.py#L1673-L1683
Since we might not have the proper repodata.json.gz file on the package store ...

hmmm, this is the code in question:
https://github.com/mamba-org/quetz/blob/05dbfc65529c6a81acdab899ad509d85496802cd/quetz/main.py#L1645-L1654
I wonder if the gzip magic does something bad here:
https://github.com/mamba-org/quetz/blob/05dbfc65529c6a81acdab899ad509d85496802cd/quetz/main.py#L1673-L1683
Since we might not have the proper repodata.json.gz file on the package store ...

I just checked the repodata.json.gz and it's empty (check file size):

Interestingly, the other platform don't contain the repodata.json.gz, only repodata.json.

https://conda.anaconda.org/conda-forge

One more thing: repodata.json.gz also doesn't seem to exist on the upstream channel, see: https://conda.anaconda.org/conda-forge/noarch/repodata.json.gz

Deleting repodata.json.bz2 and repodata.json.gz seems to solve the issue for me. The question remains where these files come from, though.

OK, so the bug goes as follows:

we added a repodata.json.gz file to support returning / streaming gzip compressed files from S3 buckets and similar
we do initialize every channel with an empty noarch repodata.json because the existence of teh noarch/repodata.json is what marks a channel as "existing"
apparently we do initialize even a proxy-mirror channel with the static noarch/repodata.json files (including the .gz / .bz2 ones). We should not do that.
the repodata.json.gz is a quetz-specific extension (and a bit of a workaround for OVH because they don't properly support setting the Content-Encoding header for a given file)

This is where we call update_indexes for all kinds of channels: https://github.com/mamba-org/quetz/blob/59adbfdda13f75218d89b1c8c20ac090408311d4/quetz/main.py#L725
That creates the empty noarch/repodata.json ...
Should we just not call that for a proxy-mirror channel?

This is where we call update_indexes for all kinds of channels:
https://github.com/mamba-org/quetz/blob/59adbfdda13f75218d89b1c8c20ac090408311d4/quetz/main.py#L725
That creates the empty noarch/repodata.json ...
Should we just not call that for a proxy-mirror channel?

Sounds reasonable to me. 👍

On the other hand, a better solutoin might be to create the .gz files so that we can serve gzipped repodata (which saves a lot, it's 20% or so of the full repodata). E.g. instead of downloading 120Mb, you only need 20 or so.
Did you experience long downloads or are you gzipping the responses through nginx?

On the other hand, a better solutoin might be to create the .gz files so that we can serve gzipped repodata (which saves a lot, it's 20% or so of the full repodata). E.g. instead of downloading 120Mb, you only need 20 or so. Did you experience long downloads or are you gzipping the responses through nginx?

So far I don't think long download times have been an issue for us. But if we could build it in a way such that we have to send a lot less data over the network, then i would be all in favour for that.

quetz is released, with this bug fixed.

thank you!


Holding shift to drop file in editor doesn't appear to always work

Testing #180741

Drag file
Hold shift
🐛 File opens in new tab as if shift wasn't held

Have you disabled the editor.dropIntoEditor.enabled setting? Or do you see the hold shift to drop into editor prompt but it still opens in a new tab?

Have you disabled the editor.dropIntoEditor.enabled setting? Or do you see the hold shift to drop into editor prompt but it still opens in a new tab?

I see the prompt and I either get a drop where nothing is inserted or it opens in a new tab. I cannot seem to get a drop that inserts a file path.

hm what OS are you on?

hm what OS are you on?

This is an Ubuntu parallels VM. My guess is that parallels is being weird, but I can use shift for other things like shift click without issue

On Ubuntu + Parallels, the dragOver event's shiftKey modifier is not set correctly. This cause the entire drop UX to not work reliably
Not sure if it's parallels specific or a generic ubuntu issue

@lramos15 Can you please try this parallels setting: https://kb.parallels.com/en/116994
After setting the keyboard to Optimize for games, drop seems to work much more reliably

This seems to improve it greatly @mjbvz. I do notice that just tapping shift is enough to remove the overlay and drop in the editor.

Drag
Tap shift
Drop

If I move the file between steps 2 and 3 then the overlay appears again (maybe a new drag event is fired). Is this a limitation of the OS?


CRV bars aren't transparent

With root 6.28 transparency is working (great).  However the hit CRV bars are shown as solid, not transparent.  They should have the same transparency as the geometry.

A few wild guesses.  I believe that the G4 model has the wrapping of the bars.  There are also spacers between bars.  I think, but am not sure, there are are per module mother volumes.  All need to have the right transparency settings.   Have you looked into that?
It's also possible that we need to do somethning different in the Offline/G4 interface code that creates the volumes.

... I should have said absorbers between bars, not spacers.  They are Al I believe.

I dont think so, the coloring is purely on REve as far as I recall so its an REve thing

I need to check with the developers on this, it seems something isnt propagating correctly and its not in our code (there was a previous issue which was solved elsewhere but not here)

Oh, actually I think it might just be that the lines are really thick

(let me t


[SPARK-50098][PYTHON][FOLLOWUP] Update _minimum_googleapis_common_protos_version in setup.py

What changes were proposed in this pull request?
This is a follow-up of

#48638

Why are the changes needed?
To be consistent.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this follow-up, @viirya ?

All tests passed.

Thanks @dongjoon-hyun

Thank you, @viirya !

This is only a follow-up to make it sure the enforcement logic. The dependency was updated and tested already in the previous PR. Let me merge this~


added sentence about linking of test suite and target

https://bugs.swift.org/browse/SR-1276

This was merged into the wrong branch.

I cherry-picked onto master.


Remove race condition when server closes connection

When server closes connection right after having sent some frames, those are ignored by the client. Frames are lost because they are processed in a nextTick/setImmediate callback, thus socket close event may arrive before they are actually processed.
Added a test that reproduces the error, on my computer it states that it received only 6 frames. I wonder if that could be computer-dependent so if that does not reproduce, try increasing to var count = 100; to something much larger.
The fix proposed here does not look right as it disables something done on purpose, as per the comment above (that's why I just commented out the line and not fixed the now useless bound method, I don't think this will be the real solution). Trying to delay socket end handling leads to socket errors, and I did not find anything better, so at least putting something that makes tests green. Welcome to any idea!

Yes, this is a potentially challenging/sticky situation. I went back and forth on this a few times in the initial design/implementation of the library. It'll take some careful changes to implement this correctly.

Is this still an issue?


Update timeout for .github/workflows/pr-closed.yaml

This is an automated pull request to update default timeouts for all jobs in .github/workflows/pr-closed.yaml that do not currently contain a default timeout property.
Please review these changes closely to ensure that all jobs have sufficient time to run. If a job needs more time, please add a timeout property to that job to override the organization default.
Additionally, please be attentive to unintended changes to the workflow YAML file, as the parser is not perfect.
Lastly, note that it is up to the reviewer to merge this pull request and delete the PR branch once they are satisfied with the changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


7 or More Images Breaks the Slider

Describe the bug
When having 7 or more images in the slider, the slider starts at a different position than 0, and sometimes it breaks the slide direction so it goes from right to left rather than from left to right,
To Reproduce
Steps to reproduce the behavior:

Add 7 images to the slider

Expected behavior
Starts at index 0 and remains sliding from left to right
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: Samsung S20 Ultra
OS: Android 10
Browser Chrome
Version [e.g. 22]

Additional context
Add any other context about the problem here.

To solve this issue,
I am using a workaround: getSliderPager().setCurrentItem(0,true)

Hey, I am still facing the same issue, I have 7 images in the slider view. it is working fine for less than 7 images.
  List<Image> shirtImageUrls = CommonVars.singleProductDetailViewer.getProductDetails().getLocal_images();
 adapter = new

                ProductPicturesAdapter(ProductDetails.this, shirtImageUrls, getSupportFragmentManager());
        // below method is used to set auto cycle direction in left to
        // right direction you can change according to requirement.
        productSliderView.setAutoCycleDirection(SliderView.LAYOUT_DIRECTION_LTR);

        // below method is used to
        // setadapter to sliderview.
        productSliderView.setSliderAdapter(adapter);

        // below method is use to set
        // scroll time in seconds.
        productSliderView.setScrollTimeInSec(3);

        // to set it scrollable automatically
        // we use below method.
        productSliderView.setAutoCycle(true);

        // to start autocycle below method is used.
        productSliderView.startAutoCycle();

        // i have tried the below approach but it is also not working out.
        productSliderView.getSliderPager().setCurrentItem(0,true);


hard to select text from your "quick start" guide

It's hard to copy commands using CTRL-C from the quick start guide into the clipboard. First I thought it wasn't possible to select the commands at all since no selection appeared. But there was no user-select CSS on it, and then I realized that the selection was there but it's black so it's barely possible to see it. Selecting other text (outside of the commands), for example "You can install it globally:", works just fine and I get orange selection color there (I'm using ubuntu 16.04). Strange thing is that in Firefox the selection is much easier to see because there it's just dark gray instead of nearly black.
For example, open:
http://codecept.io/quickstart/#quickstart
... and try to copy for example this command:
npm install codeceptjs-webdriverio --save-dev
The bad CSS seems to be this one:
.hljs::selection, .hljs span::selection {
background: #373b41;
}
And the reason why it "works" better in Firefox is because you didn't use ::moz-selection

Ok, thanks for the report. I will try to improve that

Replaced bg color with #2c3e50


feature 1506: Don't use cache for infographics data when testing locally

Closes #1506

The bypassing of cache access is well done.
Currently, whenever we are developing, cache will not work. We may want more granular setting (e.g. FLASK_ENV will be a list of values, that one of them will be 'bypass-cache').

The bypassing of cache access is well done.
Currently, whenever we are developing, cache will not work. We may want more granular setting (e.g. FLASK_ENV will be a list of values, that one of them will be 'bypass-cache').

Since FLASK_ENV is a FLASK variable and not our own environment variable, I suggest we either use FLASK_ENV as is, or create our own var/s.  I suggest I'll merge this one so we can develop properly, and if there is a need we'll create our own vars instead.


Revert "Begin process of removing singleton use by StringMatcher (#32…

…829)"
This reverts commit b7818b0df716af47ec22982c5a1cbbace5f2ae15.

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@ggreenway this seems to have created a permafailing TIMEOUT in the rbac tests (maybe others)

pushing this past windows lag to fix CI


Set-LabHostDefault throw error when pointing to directory that does not exist

Is this a bug, or is it intended behaviour?
I was under the impression that Start-LabHostConfiguration would create the directories if they do not exist, and thus I expected to be able to set defaults to directories that have not yet been created.
However when I try to, Set-LabHostDefault throw an error:
D:\TestLab\MasterVirtualHardDisks path 'D:\TestLab\MasterVirtualHardDisks' is invalid.
At C:\Program Files\WindowsPowerShell\Modules\VirtualEngineLab\Src\LabHostDefaults.ps1:60 char:6
+ ...             throw ($localized.InvalidPathError -f $resolvedPath, $PSB ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (D:\TestLab\Mast...ks' is invalid.:String) [], RuntimeExcept
   ion
    + FullyQualifiedErrorId : D:\TestLab\MasterVirtualHardDisks path 'D:\TestLab\MasterVirtualHardDisks' is
   invalid.

I think you could classify this as a bug as you're correct in that Start-LabHostConfiguration will create the target folders if they don't exist! I will review the pull request and merge it in. Thanks!


Added 'stop' command, '--config' option, and a few other options

What I changed:

Upgraded Yargs to 11.0.0
Renamed the init command to configure (but with an alias of init for backwards compatibility).
Added option force to the start command.
Added command stop.
Added the config option to all commands.
Added the dir option to all commands except configure.

Commands:

start

Description: Starts the server.
Options:

config: The config file to use.
dir: The working directory to use.
force: If a server is already running, stop it.
dev: Run in dev mode.

What happens:

Checks for a .lock file and if the PID in it is running, throw an error (unless run with --force)
Creates a .lock file and stores the PID in it.
Runs the server as usual

stop

Description: Stops the server.
Options:

config: The config file to use.
dir: The working directory to use.

What happens:

Checks for a .lock file and if the PID in it is not running, throw an error
Closes the PID

configure (aliases: init)

Description: Creates a custom config file.
Options:

config: The name of the config file to create. (Default: laravel-echo-server.json)

What happens:

Prompts for the settings for the config.
Prompts you what you want to save the config as. (default is the --config option)
Saves the config file.

client:add [id]

Description: Register a client that can make api requests.
Options:

config: The config file to use.
dir: The working directory to use.

What happens:

Adds a client to the config file.

client:remove [id]

Description: Remove a registered client.
Options:

config: The config file to use.
dir: The working directory to use.

What happens:

Removes client from config file.

Todo:

Update README.md
Maybe make an option to stop all running servers?

This is the current output --help: (Notice the server.js)
Usage: server.js <command> [options]

Commands:
  server.js start          Start up the server.
  server.js stop           Stops the server.
  server.js configure      Initialize server with a config file. [aliases: init]
  server.js client:add     Register a client that can make api requests.
  server.js client:remove  Remove a registered client.

Options:
  --version   Show version number                                      [boolean]
  --help, -h  Show help                                                [boolean]

Please provide a valid command.

There is no "official" way to change it, but I found a way by setting yargs.$0 to whatever you want. Which one do you prefer?

(A bit crowded in my opinion)

Usage: laravel-echo-server <command> [options]

Commands:
  laravel-echo-server start          Start up the server.
  laravel-echo-server stop           Stops the server.
  laravel-echo-server configure      Initialize server with a config file.
                                                                 [aliases: init]
  laravel-echo-server client:add     Register a client that can make api
                                     requests.
  laravel-echo-server client:remove  Remove a registered client.

Options:
  --version   Show version number                                      [boolean]
  --help, -h  Show help                                                [boolean]

Please provide a valid command.

Usage: laravel-echo-server <command> [options]

Commands:
  start          Start up the server.
  stop           Stops the server.
  configure      Initialize server with a config file.           [aliases: init]
  client:add     Register a client that can make api requests.
  client:remove  Remove a registered client.

Options:
  --version   Show version number                                      [boolean]
  --help, -h  Show help                                                [boolean]

Please provide a valid command.

Just want throw a huge +1 at this. I am missing the stop command a great deal. Even stopping the server with ctrl+c seems to leave the pid around. I've been having to kill the pid to restart every time which is a hassle.

@tlaverdure Could this be merged? Or are there things I need to do before that can happen?

@tlaverdure All of the things I added are backwards compatible... I really think this could be merged...

@AndrewMast sorry for the delay on this! Been busy with work stuff...
This seems like  a great idea. There were some changes made along the way to add config options from the .env file that I think are conflicting with your CLI changes. Can you take a look at those conflicts so we can get this merged?

@tlaverdure Sure, I haven't looked at the code in a while but I will try to do it within the next few days.


error about Key 'count_coll_pen' not in 'SocialNavReward'

Habitat-Lab and Habitat-Sim versions
Habitat-Lab: v0.3.0
Habitat-Sim: v0.3.0
tag：stable
🐛 Bug
When I run the code according to the readme, an error occurs：Key 'count_coll_pen' not in 'SocialNavReward'。
The following is the main error message：

Hi @Li-ChangHao! Could you please try to git pull origin main to make sure you are using the latest habitat-lab main? The stable version might not work. In addition, would you please also paste your latest commit hash for habitat-lab? Thank you!

latest commit hash：afe4058a7f8aa5ab71a133575cdaa79f0308af6a

it works, many thanks


Projector support

Make everything bigger so it renders will when casted or projected in a classroom.

Example: https://twitter.com/ms_gilbert213/status/1496153985232912384

We might just need to crank up the font size.


Api v2

added the updated pg and squlize. also added an empty directory.

added the updated pg and squlize. also added an empty directory.


No issue, but a question about nibegw virtual RMU

Everythings works fine but the sensor that gives the temp is 25.350000 and what its Publishing to rmu: 0x19 temp: 25.350000 -> 05.01, so with 0.05 more.
And what I get in my heat pump is 25.4
I there a way to get the same value?
I'ts not nessery but it looks nicer :-)

Please check on the pump menu. I think there is a .5 offset in what the rmu sends.

Please check on the pump menu. I think there is a .5 offset in what the rmu sends.

Hi,
No i have checked that, offset is 0.
If i change it nothing happens.

Not that offset. I mean what room temp is the pump showing when we send a virtual room temp.

This is the log:
[18:55:51][I][nibegw:155]: Publishing to rmu: 0x19 temp: 25.280001 -> 04.01
[18:55:52][I][log:144]: 25.280001
[18:55:54][D][climate:396]: 'verwarming woonkamer temperatuur RMU40 S1' - Sending state:
[18:55:54][D][climate:399]:   Mode: HEAT_COOL
[18:55:54][D][climate:419]:   Current Temperature: 25.30°C
[18:55:54][D][climate:425]:   Target Temperature: 19.00°C
And this is the temp the pump is showing: Current Temperature: 25.30°C

So that looks like it matches then.

The idea is that it should round to nearest tenth of a degree. 25.44 aught to be 25.4, while 24.45 would be 24.5.
But we might be rounding wrong somewhere.

Now it's rounding good from 25.04 to 25 so thats good.


[QENG-3063] Forget SSH connection IP address on reboot

Prior to this, as seen during acceptance test runs for BKR-358, on centos7 and debian7 (at least), if the DHCP lease time for the SUT was short, and a test run was sufficiently long, a late reboot would never come back as far as beaker was concerned.
The DHCP lease expiry would issue a new IP address for the SUT, but since the host object would often (but not always) have the IP address cached in self['ip'], when the SSH connection would be reinstantiated, it would go to @ip first, before going to @vmhostname or @hostname, meaning
that connections would never connect to the new IP address.
The tests for this will land with #930 (BKR-358), so not including them here.
I vetted this approach over a couple of days, tracing the runs, determining the root cause, and then applying this fix (with additional logging output to verify the change worked).
Test run output:
* #reboot: can reboot the host

kasibwkdzsf7utx.delivery.puppetlabs.net (centos7-64-1) 15:50:46$ /sbin/shutdown -r now
  Connecting... ip[<IP_ADDRESS>] vmhostname[kasibwkdzsf7utx.delivery.puppetlabs.net] hostname[centos7-64-1] self[Beaker::SshConnection]
  Connecting... by IP [<IP_ADDRESS>]
  Warning: ssh channel on centos7-64-1 received exception post command execution IOError - closed stream
  Warning: ssh.close: connection is already closed, no action needed
  Warning: ssh connection to centos7-64-1 has been terminated

kasibwkdzsf7utx.delivery.puppetlabs.net (centos7-64-1) executed in 0.21 seconds
Warning: ssh.close: connection is already closed, no action needed
Warning: ssh connection to centos7-64-1 has been terminated

kasibwkdzsf7utx.delivery.puppetlabs.net (centos7-64-1) 15:50:56$ echo kasibwkdzsf7utx.delivery.puppetlabs.net rebooted!
  Connecting... ip[] vmhostname[kasibwkdzsf7utx.delivery.puppetlabs.net] hostname[centos7-64-1] self[Beaker::SshConnection]
  Connecting... by vmhostname [kasibwkdzsf7utx.delivery.puppetlabs.net]
  Attempting ssh connection to kasibwkdzsf7utx.delivery.puppetlabs.net, user: root, opts: {:config=>false, :paranoid=>false, :auth_methods=>["publickey"], :port=>22, :forward_agent=>true, :keys=>["/Users/rick/.ssh/id_rsa-puppetlabs-vmpooler"], :user_known_hosts_file=>"/Users/rick/.ssh/known_hosts", :user=>"root"}
  Call-stack: /Users/rick/pl/beaker/lib/beaker/ssh_connection.rb:84:in `connect'
  /Users/rick/pl/beaker/lib/beaker/ssh_connection.rb:40:in `connect'
  /Users/rick/pl/beaker/lib/beaker/host.rb:229:in `connection'
  /Users/rick/pl/beaker/lib/beaker/host.rb:279:in `block in exec'
  /opt/boxen/rbenv/versions/2.1.5/lib/ruby/2.1.0/benchmark.rb:294:in `realtime'
  /Users/rick/pl/beaker/lib/beaker/host.rb:278:in `exec'
  /Users/rick/pl/beaker/lib/beaker/dsl/helpers/host_helpers.rb:73:in `block in on'
  /Users/rick/pl/beaker/lib/beaker/shared/host_manager.rb:115:in `run_block_on'
  /Users/rick/pl/beaker/lib/beaker/dsl/patterns.rb:35:in `block_on'
  /Users/rick/pl/beaker/lib/beaker/dsl/helpers/host_helpers.rb:63:in `on'
  acceptance/tests/base/host_test.rb:184:in `block (3 levels) in run_test'
  /Users/rick/pl/beaker/acceptance/lib/helpers/test_helper.rb:99:in `fails_intermittently'
  acceptance/tests/base/host_test.rb:181:in `block (2 levels) in run_test'
  acceptance/tests/base/host_test.rb:179:in `each'
  acceptance/tests/base/host_test.rb:179:in `block in run_test'
  /Users/rick/pl/beaker/lib/beaker/test_case.rb:128:in `eval'
  /Users/rick/pl/beaker/lib/beaker/test_case.rb:128:in `block in run_test'
  /opt/boxen/rbenv/versions/2.1.5/lib/ruby/2.1.0/benchmark.rb:294:in `realtime'
  /Users/rick/pl/beaker/lib/beaker/test_case.rb:125:in `run_test'
  /Users/rick/pl/beaker/lib/beaker/test_suite.rb:311:in `block in run'
  /Users/rick/pl/beaker/lib/beaker/test_suite.rb:308:in `each'
  /Users/rick/pl/beaker/lib/beaker/test_suite.rb:308:in `run'
  /Users/rick/pl/beaker/lib/beaker/test_suite.rb:357:in `run_and_raise_on_failure'
  /Users/rick/pl/beaker/lib/beaker/cli.rb:159:in `run_suite'
  /Users/rick/pl/beaker/lib/beaker/cli.rb:99:in `execute!'
  /Users/rick/pl/beaker/bin/beaker:6:in `<top (required)>'
  /Users/rick/pl/beaker/vendor/bundler/ruby/2.1.0/bin/beaker:23:in `load'
  /Users/rick/pl/beaker/vendor/bundler/ruby/2.1.0/bin/beaker:23:in `<main>'
  host: "kasibwkdzsf7utx.delivery.puppetlabs.net"
  Connecting... ip[] vmhostname[kasibwkdzsf7utx.delivery.puppetlabs.net] hostname[centos7-64-1] self[Beaker::SshConnection]
  kasibwkdzsf7utx.delivery.puppetlabs.net rebooted!

kasibwkdzsf7utx.delivery.puppetlabs.net (centos7-64-1) executed in 3.97 seconds

The tea leaves may not be :100:% readable, but on reboot the IP address changed, but the connection forgot the old IP and connected by the next level of information (vmhostname), which allowed the connection to succeed.
/cc @puppetlabs/beaker

My only quibble is for situations where we do NOT have DNS, like talking to hosts in ec2.

Yeah, let's ferret out the various issues.  Given that this is a way to make the host forget the IP on reboot, is there a way to make this smarter about when it needs to do it.
Fwiw, here is the code which picks how to re-connect:
https://github.com/puppetlabs/beaker/blob/qeng-3063/drop-old-IP-on-unix-host-reboot/lib/beaker/ssh_connection.rb#L66-L87
    # connect to the host
    def connect
      #try three ways to connect to host (ip, vmhostname, hostname)
      methods = []
      if @ip
        @ssh ||= connect_block(@ip, @user, @ssh_opts)
        methods << "ip (#{@ip})"
      end
      if @vmhostname && !@ssh
        @ssh ||= connect_block(@vmhostname, @user, @ssh_opts)
        methods << "vmhostname (#{@vmhostname})"
      end
      if @hostname && !@ssh
        @ssh ||= connect_block(@hostname, @user, @ssh_opts)
        methods << "hostname (#{@hostname})"
      end
      if not @ssh
        @logger.error "Failed to connect to #{@hostname}, attempted #{methods.join(', ')}"
        raise RuntimeError, "Cannot connect to #{@hostname}"
      end
      @ssh
    end

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1739/
Test FAILed.

Well, in the case of ec2 the hostname check will fail (no dns) and the IP check will fail due to your PR. Which leaves "vmhostname" which I'm unsure of what that does.

Yeah, this is not ready to ship unless we can find the algorithm that
enables it in the "right" situations.
A less-than-100%-ideal (because it is inefficient, time-wise) solution
would be to allow the SSH connection cycle to timeout-fail due to the IP
not existing, and then removing the IP and retrying. That's non-local to
this code path so might take a bit longer to figure out.
On Wed, Oct 28, 2015 at 10:45 AM, Doug Rosser<EMAIL_ADDRESS>wrote:

Well, in the case of ec2 the hostname check will fail (no dns) and the IP
check will fail due to your PR. Which leaves "vmhostname" which I'm unsure
of what that does.
—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/beaker/pull/1000#issuecomment-151887872.

@rick What if we modified the order of the connection code so that hostnames were always tried before IP addresses? This is the way things work in the Real World.

I'm digging in now to see why the existing code doesn't appear to be working. This stuff is hard to duplicate (I'm relying on hitting the dhcp timeout just right, really), but if I lower the number of tries (so it's not doing 11 tries between each method of connection) I see it go from trying to connect via IP to trying to connect via vmhostname, which is contrary to our larger experience.

These are not the droids we are looking for. Closing in favor of #1006 (see also: https://github.com/puppetlabs/pe_acceptance_tests/pull/745)


Memory Region Analysis

CFG intra/interproc
Memory Region Analysis

Fixed conflicts

I tried running the tests, and after fixing up some minor issues so it would compile, it crashes for all examples in the memory region tests at line 269 in Cfg.scala.
The issue seems to be that if the Cfg generation encounters a block with no statements (only jumps), such as block 000002e6 in the arrays example, then newBlocks(g.target.label) returns an empty ArrayBuffer, so .head fails on that empty ArrayBuffer.

Hi Liam,
I have investigated and the issue appears to be coming from changes in the underlying IR.
In the old version this is the procedures collected for basic_array_write example:

Currently, the number of procedures is as follows:

The procedures do not seem to be necessary, and they make the graph very complicated. Previously, for most examples, it would only have main, functions, malloc, free, etc.
Do you require all those procedures for your purposes?
I have fixed the issue and Memory Region Analysis works fine. However, I have had to comment out Constant Propagation Analysis as it causes it to break.
ps. my tests would not pass because the string comparison would fail dude to the many procedures added to the results. The analysis still works and you can check the output graph in test.dot and plot it in Edotor.net
Let me know how you wish to proceed, and I can adjust my analysis/CFG accordingly.

A few months ago things were moved around so that now the analysis takes place before all procedures not reachable from main are removed, which is why you're only encountering those now. This is an important change, as previously any procedures that are only accessed via indirect calls are completely removed before the analysis occurs, which means that we can't resolve the indirect calls in the analysis. Obviously we're not quite at the stage of making use of those yet though.
Eventually we'll want to do things in an order like this:
resolving indirect calls -> removing unreachable procedures -> memory region analysis
This might require a more nuanced approach than just running the analyses on every procedure. For example, we probably don't need to do constant propagation on the entire program, just where there are indirect calls that are reachable from main, so we might need to have the constant propagation analysis start with main and resolve its indirect calls before analysing procedures reachable from main. In most cases it's likely that the constant propagation could be further limited to just before the indirect call site if we wanted to optimise things.
For the time being, I can move removing the unreachable procedures back to happening before the analysis if that's what would be easiest for you? Either way, those extra procedures can all be ignored at the moment for your current purposes, as they're mostly initialisation/cleanup code that we're considering out of scope.
If the constant propagation is breaking on some of those procedures you still should investigate why - it could be edge cases you haven't handled that were always possible (like the blocks with only calls and no statements) in which case they should be fixed.
Aside from all that, this seems fine to merge in now.

Yes. Would it be possible to do remove those for now?
It will make visualising the result of the analysis a bit more easier.
I will merge the branch


[BUG] ESPhome 2024.6.1 Breaking Change: Update YAML File for OTA Fix

In ESPhome 2024.6.1, there is a breaking change that requires updating the YAML file. To fix this, you need to add platform: esphome under the OTA section. This adjustment should address the issue.
ota:
  password: !secret ota_password
  platform: esphome

Not sure 'bug' is the right tag for this.  Maybe a 'heads-up' since this is an ESPHome breaking change and not related to EspHoMaTriXv2
https://community.home-assistant.io/t/esphome-ota-configuration/730032
Sigh, ESPHome is great but looks like they introduced TWO breaking changes in 2024.6 including dallas sensors too (shouldn't affect this project but... good to be aware).

Fixed


Adding and removing data in v2

As per #1609, we now can replace the entire data object and call update().
However, I'm not able to replicate this behavior, which in v1 was possible by using addData and removeData.
Is there a way to have this behavior in v2?
https://www.dropbox.com/s/eovva6wfagq5vg8/moving-chart.mov?dl=0

@IonutLaceanu you could do something like
function moveChart(chart, newData) {
    chart.data.labels.push('new label'); // add new label at end
    chart.data.labels.splice(0, 1); // remove first label

    chart.data.datsets.forEach(function(dataset, index) {
        dataset.data.push(newData[index]); // add new data at end
        dataset.data.splice(0, 1); // remove first data point
    });

    chart.update();
}

@etimberg, but that won't have the same animation as the one in the video I posted.
That would just render the new data, animating each element from zero to the current state.
My question was how to have an animation like in the video. Sorry if I wasn't clear enough.

Ah, ok. I understand now.
I think if you do all the removes, then call update then do all the adds then call update again it might be closer.
function moveChart(chart, newData) {
    chart.data.labels.splice(0, 1); // remove first label
    chart.data.datsets.forEach(function(dataset) {
        dataset.data.splice(0, 1); // remove first data point
    });

    chart.update();

    // Add new data
    chart.data.labels.push('new label'); // add new label at end
    chart.data.datsets.forEach(function(dataset, index) {
        dataset.data.push(newData[index]); // add new data at end
    });

    chart.update();
}

Hi, I'm pretty new to chart.js and we're looking to use it in our product. This feature was very nice in 1.0 and I think it's a pretty big regression to not support it in 2.0.
I've tried putting in the moveChart() function, but it really isn't the same. It redraws the entire chart which makes it look like it's all new data instead of just new data coming in at the end.
I hope this can be looked into further for the 2.0 stream as it really is a great feature.

 I'm attempting to implement the same exact thing, where the chart flows continuously from right to left as new data points are added to the data set.

@jfurrow No, I didn't :disappointed:

I think @jtblin had a moving chart working with his angular-chart.js project using the v2.0. https://github.com/jtblin/angular-chart.js/tree/chartjs-2.0
I think the correct file to open is charts.html in the samples folder. I know this from some of the discussion on #2040

@IonutLaceanu I found an implementation that may work for you: http://jsbin.com/pohode/edit?js,output

@etimberg Thanks. This worked! This should really be reintegrated back into the core.

yes, @etimberg . Is there any plan to add this feature to main version?  Delete data from left does not rerender the hole chart... Thanks!

As it was mentioned before, this is huge regression. Realtime charts become more and more in demand.
Suggestions by other people don't quite work. The animation is weird. It'd be great if it was exactly like ot was before.
I would not mind having to use extra methods if it'll mean beautiful and meaningful animation.
Are there any plans to improve this?

Previous jsbin didn't work for me, but I changed it like this: http://jsbin.com/xumekecasa/1/edit?js,output
"Insert" animation is ok, but the "remove" animation is very different from a translation on XX axis.
Is this the best we can get with animation?
If that is true, removing the animation makes it work better in this case :)

+1, this is a major roadblock to using this library for live data

We aren't opposed to adding this back to the core. If someone wants to work on this I would suggest starting with a proposal of the methods that would be added and their behaviours. That would avoid any wasted work on a PR that might not get approved.
If there is someone willing to own this feature and drive it we could add it to the v2.4 milestone.

I'm experimenting some changes in the dataset controller to get notified when data array(s) change and so cleanup meta data and get better animations when values are inserted or removed without adding extra chart APIs. This allows many kind of animations, not only from right to left or left to right. I don't know if it's what you guys are looking for but I hope it should make real time charts experience better (see these examples: http://playground.abysscorp.org/chartjs/livecharts/).

@simonbrunel Wow man, this is fantastic!
There is only one usability issue with this. The chart shows about 20 seconds worth of data. Is it possible to change that? I saw if you change speed, it kind of does that, but does it allow you set a specific time frame? Also, once you go over that time frame, is it possible to see previous data? Nvd3 has this "View Finder" feature, which lets you do that.
Anyway, awesome job!

@DmitryEfimenko thanks :)
It's still the user responsibility to correctly update its data to get that kind of animation. For example, to translate the chart from right to left every second, you would have to write something like:
setInterval(function() {
    var data = chart.data.datasets[0].data;
    data.push(value);    // add the new value to the right
    data.shift();        // remove the first left value
    chart.update();
}, 1000);

The link I posted are just examples of what kind of animations you can now create. So you decide what data to add or remove, how many and where in the array, the refresh rate and thus the time range :)
It's not possible to see previous data (which ones are removed from the array to obtain that animation). The view finder is a totally different concept, I'm sure it's feasible but it would require a new Chart.js plugin.

oh man, of course, it'd be user's responsibility to push and shift data. I was assuming it.
How can I play around with your code? Is it possible to put it in plunker?

Here is the Plunker and you can also download and experiment with these dist files: Chart.js or Chart.bundle.js.

Thanks for making a PR!

Addressed in #3399

I am making exactly this, but is it posible to avoid the transition or at least reduce it?

@franciscop you could do chart.update(0) to force it render synchronously without an animation.

});
function addData(whatChart) {
whatChart.data.datasets[0].data[2] = 8;
whatChart.data.labels[2] = "Null";
whatChart.update();
}
function removData(whatChart){
whatChart.data.labels.pop();
whatChart.data.datasets.forEach((datasets) => {
    dataset.data.pop();
});
whatChart.update();

}

`   });
function addData(whatChart) {
whatChart.data.datasets[0].data[2] = 8;
whatChart.data.labels[2] = "Null";
whatChart.update();
}
function removData(whatChart){
whatChart.data.labels.pop();
whatChart.data.datasets.forEach((datasets) => {
    dataset.data.pop();
});
whatChart.update();

}`

`    function addData(whatChart) {
whatChart.data.datasets[0].data[2] = 8;
whatChart.data.labels[2] = "Null";
whatChart.update();
}
function removData(whatChart){
whatChart.data.labels.pop();
whatChart.data.datasets.forEach((datasets) => {
    dataset.data.pop();
});
whatChart.update();

}`

`   function addData(whatChart) {
whatChart.data.datasets[0].data[2] = 8;
whatChart.data.labels[2] = "Null";
whatChart.update();
}
function removData(whatChart){
whatChart.data.labels.pop();
whatChart.data.datasets.forEach((datasets) => {
    dataset.data.pop();
});
whatChart.update();

}`

Nice job
https://www.chartjs.org/docs/latest/developers/updates.html


Analyse findings from citizen and service team testing of Exit this Page button, component guidance and pattern

What
Analyse findings from round of testing with citizens and service teams, and agree iterations.
Why
To know if we need to iterate anything before shipping mvp, and what can be a later iteration of the component / pattern.
Who needs to work on this
Katrina, Ciandelle
Who needs to review this
Calvin, Imran, Steve, Kelly, beeps, Owen, David
Done when

[ ] Findings have been collated
[ ] Findings have been mapped with the team
[ ] Iterations have been agreed

As there is not available budget for user research we are unable to undertake this testing. Instead we are focusing our efforts analysing feedback from the community consultation, and planning iteration touch points with service teams who implement the component

There is no budget available at the moment for research, I am in the process of applying for it (will take 6 weeks). Although it's clear we won't be doing research before publication of EtP, we've not decided not to do research after publication or what we're doing with service teams. Please move this to backlog until we've had a discussion with Kelly when she's back.

Closing this issue now but keeping #2726 and #2731 open as we agreed to explore this later in the year when teams have started using Exit this Page in services.


During call when switch over Speaker to Wired Headset echo and noise happening

Hey @Prasannakumarkannan
Please follow the Troubleshooting Audio guide in our Video Android Quickstart. If you are still unable to resolve the echo issues, then please open an issue on the Video Android Quickstart project with the issue template filled out as best you can. Audioswitch does not manage or provide any echo cancellation facilities.
Thank you


Add support for ClExprOp

Description
Closes #250 .
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have performed a self-review of my code
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have updated the changelog with any user-facing changes

Thanks for the suggestions @qartik . Have applied your patch and implemented most suggestions. Leaving the assert as is, otherwise mypy complains (and I think assert is reasonable since it really must be this type by construction).


Attack boat rocket launcher doesn't work with RavenM

Yes it does.

I tested it with mod and without it.


Patches for issues 20 through 24

Voila, zie commit message 8b862537!

Hmm dat was master :/

WoW, that looks very nice :) (in dutch: Goed bezig Joris!!)  I will check tomorrow if I can merge the patch with the development branch because that branch contains more fixes and features.


tldr page for command docker---markdown not found

Describe the bug
> navi --tldr docker

Failed to call:
tldr docker --markdown

Output:
tldr page for command docker---markdown not found

Error:

Note:
Please make sure you're using a version that supports the --markdown flag.
If you are already using a supported version you can ignore this message.
The tldr client written in C (the default one in Homebrew) doesn't support markdown files, so navi can't use it.
The client written in Rust is recommended. The one available in npm works, too.

Failed to read /dev/tty

To Reproduce

Download the pre-compiled binaries
install denisidoro/cheats
run the command

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:

OS:  ubuntu 20.04
Shell Version zsh 5.8

Additional context
Thanks for your amazing tool and contribution.

Could you please try installing a C client for TLDR? Or the JS one.
This should do the trick:
npm install -g tldr

Thanks for your help. I installed the C client and did not work. JS one works.


fix(@embark/deployment): don't over estimate gas when running tests against non-simulator nodes

When running tests against non-simulated blockchain nodes, even for simplex
Smart Contracts, deployment transactions would exceed the block gas limit.
E.g. running embark blockchain in one process and embark test --node embark
in another, inside our demo application, will throw an error when Embark attempts
to deploy its SimpleStorage:
Compiling contracts
Compilation done

[SimpleStorage]: error deploying =SimpleStorage= due to error: Returned error: exceeds block gas limit
Error deploying contracts. Please fix errors to continue.
Error deploying contracts. Please fix errors to continue.
terminating due to error
Error deploying contracts. Please fix errors to continue.

The reason for that is because in https://github.com/embark-framework/embark/pull/1650, we've introduced a static
gas estimation for Smart Contract deployment that is just right below Ganache's
maximum gas limit of 6721975, since Ganache tends to underestimate gas for
complex Smart Contracts due to its low base fee.
The static gas estimation would apply any time we're in a test context, but we
didn't take into account the case where tests are executed against nodes
other than the simulated environment.
As mentioned in the comments in the linked PR:

If this is not spec'ed at all, I wonder what complications it could cause when
at some point we maybe switch to not using Ganache anymore for tests, or even
the user itself (which I think is a reasonable thing to do).

This causes the error described above because we easily reach the block gas limit
with just two Smart Contracts and Embark already deploys a few Smart Contracts for
ENS.
So basically what we want is to use the static gas estimation when we know
the node we're connecting to is Ganache. In all other cases we can rely on the
standardized gas estimation offered by the node.

Pinging @andremedeiros specifically to have a look at this.

CI build is failing because of the linter.

@michaelsbradleyjr updated!


RuntimeError: could not open display

After installed on the command line CentOS server, when I try to run any OCRopus command, I get the following error:
$ ./ocropus-nlbin -h
Traceback (most recent call last):
 File "./ocropus-nlbin", line 5, in <module>
   from pylab import *
 File "/usr/lib64/python2.7/site-packages/pylab.py", line 1, in <module>
   from matplotlib.pylab import *
 File "/usr/lib64/python2.7/site-packages/matplotlib/pylab.py", line 265, in <module>
   from matplotlib.pyplot import *
 File "/usr/lib64/python2.7/site-packages/matplotlib/pyplot.py", line 97, in <module>
   _backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup()
 File "/usr/lib64/python2.7/site-packages/matplotlib/backends/__init__.py", line 25, in pylab_setup
   globals(),locals(),[backend_name])
 File "/usr/lib64/python2.7/site-packages/matplotlib/backends/backend_gtkagg.py", line 10, in <module>
   from matplotlib.backends.backend_gtk import gtk, FigureManagerGTK, FigureCanvasGTK,\
 File "/usr/lib64/python2.7/site-packages/matplotlib/backends/backend_gtk.py", line 13, in <module>
   import gtk; gdk = gtk.gdk
 File "/usr/lib64/python2.7/site-packages/gtk-2.0/gtk/__init__.py", line 64, in <module>
   _init()
 File "/usr/lib64/python2.7/site-packages/gtk-2.0/gtk/__init__.py", line 52, in _init
   _gtk.init_check()
RuntimeError: could not open display

Expected Behavior

On my home Ubuntu within Gnome command line it works just fine.
Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Install on CentOS command-line only server (without display)
Run any command, like $ ./ocropus-nlbin -h
Get the error

Your Environment

Python version: 2.7.5

Git revision of ocropy:
commit 358df8d104cf78fb0104bd28f333f272d908d4c3
Merge: dacf0fc e016e74
Author: Philipp Zumstein<EMAIL_ADDRESS>Date:   Mon May 22 22:38:33 2017 +0200
Merge pull request #219 from tmbdev/del-bbox-func
Delete unused function bounding_box in ocropus-linegen

Operating System and version:
CentOS Linux release 7.3.1611 (Core)

The error looks like the display is not found for matplot, and indeed you write that you are using ocropy on the command line CentOS server. You can try to set export MPLBACKEND="agg" as it is also done in the CircleCI file.

I tried to do so. After this I launched:
./ocropus-nlbin -h
And it just hangs (I can type texts in the console and anything, but no answer from the program).
After I pressed CTRL+C I got this message:
Traceback (most recent call last):
File "./ocropus-nlbin", line 5, in
from pylab import *
File "/usr/lib64/python2.7/site-packages/pylab.py", line 1, in
from matplotlib.pylab import *
File "/usr/lib64/python2.7/site-packages/matplotlib/init.py", line 151, in
from matplotlib.rcsetup import (defaultParams,
File "/usr/lib64/python2.7/site-packages/matplotlib/rcsetup.py", line 20, in
from matplotlib.colors import is_color_like
File "/usr/lib64/python2.7/site-packages/matplotlib/colors.py", line 52, in
import numpy as np
File "/usr/lib64/python2.7/site-packages/numpy/init.py", line 153, in
import polynomial
File "/usr/lib64/python2.7/site-packages/numpy/polynomial/init.py", line 18, in
from polynomial import Polynomial
File "/usr/lib64/python2.7/site-packages/numpy/polynomial/polynomial.py", line 54, in
"""
KeyboardInterrupt

Hm... I have no experience with CentOS.

Hard to say w/o running a CentOS image. numpy/scipy/matplotlib can be tricky at times because of location of compiled libs etc.
Maybe run ocropus w/ docker?

Isn't it normal behaviour that no display is found if you run on a host which only has command line installed? If I have a program which requires a display I'd install display support (for example X Windows on Linux).

That was the initial issue, solved by setting Matplotlib's backend. The second issue is something different.

@kba
How can I run it with docker?

You can use this docker image: https://hub.docker.com/r/kbai/ocropy/

@vlad-wonderkidstudio Did you find a solution for your CentOS?


sussy baka

https://www.google.com/search?q=google&rlz=1CAJIKU_enUS1048&oq=google&aqs=chrome..69i57j46i131i199i433i465i512j0i131i433i512l3j69i60l2j69i65.838j0j7&sourceid=chrome&ie=UTF-8&safe=active&ssui=on

why tho

aint reading all of that, but I am happy for you. Or sorry that happend


TECS: fix calculation of _SKE_rate_setpoint

Fixes https://github.com/PX4/Firmware/issues/15722
Describe problem solved by this pull request
Fix calculation of _SKE_rate_setpoint in TECS.
Test data / coverage
Quickly SITL tested.

@priseborough any objections? I guess it was you who wrote it, did you do it in the way it is current on purpose or unintentionally?


Deploy 2015-05-07 #3

cope with Kitten Data serialisation error
render badge png instead of failing

Coverage increased (+0.16%) to 81.3% when pulling 0c8311c5bbe2318cf2d0af85b9b12431d0450359 on staging into d502e1c141caa66e3ba1b954c68d9754bfa19095 on master.


StructuredText + Nuxt - Hydration mismatch on new lines \n

Summary
While using StructuredText from vue-datocms (v4.0.3) in a Nuxt 3 app (v3.3.2), there can be hydration mismatch warnings. These occur when the following circumstances are met:

There is serverside rendering, followed by clientside hydration
The content being rendered by StructuredText contains newline tokens (\n), which are produced in the DatoCMS editor by holding shift and pressing enter. StructuredText attempts to replace these with
.

The reason for the content mismatch is because, on the server,

 is produced.
However, during clientside hydration,

 is produced instead.
Serverside render:

Clientside hydration:

Reproduction
https://stackblitz.com/edit/github-fjlqcy?file=app.vue
Observe in console:

Debugging
I followed the steps in this article to place a breakpoint in the code after the hydration mismatch is identified and inspect the variables: https://blog.lichter.io/posts/vue-hydration-error/
This allows us to see the output before and after hydration

Note that I can't reproduce this when using npm run build and node .output/server/index.mjs, so it may be a development-only problem.

Thank you for the report @Jamiewarb we are going to have a look as soon as possible

@Jamiewarb I just released version 4.0.4.


Implement Messaging using StreamChat in .net Project

Hi,
I want to implement messaging in my .net application. How can I use chat API for one to one messaging/chatting?

https://github.com/getstream/stream-chat-net provides support, see readme and if you have questions, please use its issues. Thanks!


disabled/hidden added to AWS Private

Signed-off-by: randybrunopiverger<EMAIL_ADDRESS>regarding: https://github.com/stolostron/backlog/issues/20856
Hiding subnet and endpoints when disabled.

/cc @jeswanke @KevinFCormier


Feature Request: Sort "My Repositories" on dashboard page by recently updated

Git version: n/a
Gitea version (or commit ref): master
Operating system: n/a
Database: n/a
Can you reproduce the bug at https://try.gitea.io:

[x] Yes (the dashboard page when signed in)
[ ] No
[ ] Not relevant

Log gist: n/a

I would like to be able to sort the "My Repositories" table on the Gitea home page by most recently updated (like Github does) rather than by alphabetically.  An alphabetic sort isn't particularly useful,  when a user has more than 15 repos it shows the same set all the time and newer active repos get buried.
The backend SearchRepositoryByName function supports several sort modes, but they're not exposed in the /repos/search API used by the JS for the widget. Hooking that up was straightfoward and I'll open a PR soon.
Passing the new parameters to the API call in the repo-search is trivial if we're willing to unconditionally change that behavior. Making it user-selectable (and persistent) would be trickier but still possible.

:+1: is the patch already in a stage where I can test it?

@hasufell The API enhancement in #3964 is ready, just waiting for the Gitea team to merge it when they're ready. You can grab that for testing right now.
Hooking the new API parameters to the GUI is easy, but there isn't a single commit you can cherry-pick right now. You can use https://github.com/aswild/gitea/commit/d0e1d205578ad01a09a955fcfb674a8b1175a91f and change order=1 to order=desc on index.js line 1842 to match the updates I made from review comments.
When #3964 is merged I'll open a new PR here to hook it up to the GUI

Closing as fixed


feat(pages): add scroll to the top on answer click

Added in https://github.com/SecondThundeR/otaquiz/commit/35d641575c37f2c4f7ee3d2797586b2f0ef5a84b


Latte contrast?

I don't know if something is wrong with my installation, but Latte is lacking a lot of contrast on iTerm2 beta.

 Disregard!


If merged, this commit introduced printing without using "echo"

Checks for discard string and prepend an echo to it

@AndreiRegiani could this be merged? It's a great feature!

@AndreiRegiani has kindly given me permission to review PRs.
@Tangdongle Thanks so much for this PR, it does indeed work once, but errors the second time, and HANGS the third time!
 λ ./inim
👑 INim 0.4.1
Nim Compiler Version 1.0.6 [Linux: amd64] at /home/oatman/.nimble/bin/nim
nim> 1
1
nim> 1
Error: expression '1' is of type 'int literal(1)' and has to be discarded; start of expression here: /tmp/inim_1586104151.nim(1, 1)
nim> 1
^C⏎     # froze here

 λ ./inim
👑 INim 0.4.1
Nim Compiler Version 1.0.6 [Linux: amd64] at /home/oatman/.nimble/bin/nim
nim> "test"
test
nim> "test"
Error: expression '"test"' is of type 'string' and has to be discarded; start of expression here: /tmp/inim_1586104158.nim(1, 1)
nim> "test"
^C⏎    #froze here again

But it seems to hang after a second invocation! Can you see what is wrong?

Oh man, what was I thinking? I'll see what's going on, I think I just need to remove the printed line from the history buffer

Hey, I've made changes to fix up the prior issues. Should work a lot better (ie, it should actually work) now

Thanks so much @Tangdongle! If you hit me with any other easily-testable stuff like this, I'll merge'em!

This is now in release 0.4.2 :ok_hand:

fixes #49

fixes #62


Label centroid

Addressed #1477
TODO:

[x] Implement centroid calculation relative to first coordinate in the polygon ring

Note: Not an API breaking change, but adds on to the current API for MapData interface for ios and android.

@hjanetzek I am done here. You can finally review this. 👍

Wait this needs API change for platforms!!

Ok Finally all good now.

@karimnaaji can you also look at the ios API additions here?
Thanks

@karimnaaji updated the platform interface here to reflect what we discussed in the meeting. Can you give this a look?


[PIE-2154] Rewrite sentences to remove semicolons

Signed-off-by: Steven Gregg<EMAIL_ADDRESS>

Pull Request Description
Remove semicolons to simplify sentences.
Fixed Issue(s)

PIE-2154

Will replace with a new PR


Distributing an app to the Play Store fails because of a commit longer than 500 characters

What App Center service does this affect?
Publishing my Android App to the Play Store.
Describe the bug
{
  "mandatory_update": false,
  "release_notes": "Profile edit page (#435)\n\n* Add react-native-image-pickers\r\n\r\n* Add react-native-background-upload\r\n\r\n* Add: :sparkles: ProfileEditionScreen component and tests\r\n\r\n* Fix settings routes\r\n\r\n* Fix SProgresBar coverage\r\n\r\n* Add tests\r\n\r\n* Remove useless files\r\n\r\n* Remove useless files\r\n\r\n* :memo: Add dependencies\r\n\r\n* Add Uploader HOC\r\n\r\n* Start to connect profile and edition\r\n\r\n* Add navigato to ProfileEdition\r\n\r\n* Mod: :fire: Avoid diff too big\r\n\r\n* Mod: :bug: Handle error when no initial profile picture\r\n\r\n* Fix: :bug: forgot text when no initial profile picture\r\n\r\n* Fix: :label: Proper flow typing\r\n\r\n* Fix: :recycle: Preserve order\r\n\r\n* Fix: :camera_flash: Update snapshots\r\n\r\n* Mod: :wrench: Fiddling with camera options\r\n\r\n* Cln: :fire: No need to prefetch image, will be loaded automatically\r\n\r\n* Upd: :sparkles: Allow photo upload on ProfileDashboard\r\n\r\n* Mod: :recycle: Re-order imports\r\n\r\n* Upd: :camera_flash: Snapshot\r\n\r\n* Mod: :lipstick: Hide loading once new URL has been loaded\r\n\r\n* Fix: :ok_hand: MOULTIFIX EVERYWHERE\r\n\r\n* Mod: :white_check_mark: Split tests\r\n\r\n* Upd: :white_check_mark: Check for upload complete callback\r\n\r\n* Upd: :camera_flash: Snapshot\r\n\r\n* Fix: :ok_hand: Review from @cadesalaberry\r\n\r\n* Fix: :ok_hand: Second review from @cadesalaberry",
  "destinations": [
    {
      "id": "56963aca-d269-47d4-bd1d-REDACTED",
      "name": "Alpha",
      "message": "Failed to publish to store. Error: Release Notes should contain min 0 to max 500 characters.",
      "code": "bad_request"
    }
  ],
  "code": "partially_succeeded",
  "message": "Failed to publish to store. Error: Release Notes should contain min 0 to max 500 characters."
}

To Reproduce
Steps to reproduce the behavior:

Go to an android application git repo
Setup building, signing, and distributing to Android Play Store on a branch
Create a comit message with more than 500 characters
Push
See error

Expected behavior
The release note placeholder specifically states:
Let your users know what's new! If you want to always use your latest commit message, simply leave this as it is.

I would expect two things:

The 500 char limitation should be mentionned in the placeholder (noting that it only affects Android Play Store)
The publication module should truncate the release message to 500 char to make sure it does not fail

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: All
Browser All
Version All

Smartphone (please complete the following information):

Device: All
OS: All
Browser All
Version All

Additional context
Add any other context about the problem here.

Hi, I am facing the same issue.

Hi, the issue has been fixed. And you can again and we are now truncating release notes if the field is left blank.


Update CHANGELOG

Motivation
Update changelog after v1.6.6 release
Description
Just update CHANGELOG.md
Test Plan

n/a

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge

bors merge


Penalty weights are counted towards total

The weights of penalty meta tests (and probably also code checks) are counted towards the total number of meta tests in the "meta tests" section (the "X/Y passed" label).

Confirmed that this also holds for the code checks.


decibels: init at 46.0

Description of changes
Decibels is a small Libadwaita application that plays audio files
A part of #195280
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@getchoo does not compile on Darwin because of a broken dependency:
Package ‘spidermonkey-115.9.1’ in /Users/admin/.cache/nixpkgs-review/pr-318708/nixpkgs/pkgs/development/interpreters/spidermonkey/common.nix:191 is marked as broken, refusing to evaluate.
It's probably best to mark it as broken for the platform, or just restrict platforms to unix - darwin.

after taking a look at both upstreams, it doesn't seem neither go out of their way to support platforms besides linux. i think it might be best to just limit support to there


Upgraded from RC10 to RC11

Closes #50
After upgrading to RC11, everything expect for historie is working fine. Whenever you run npm run dev or npm run story it throws the following errors:
✘ [ERROR] Could not resolve "virtual:$histoire-support-plugins-client"

    node_modules/@histoire/app/dist/bundled/components/panel/StorySourceCode.js:6:37:
      6 │ import { clientSupportPlugins } from "virtual:$histoire-support-plugins-client";
        ╵                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "virtual:$histoire-support-plugins-client" as external to exclude it from
  the bundle, which will remove this error.

This error repeats for several of the packages related to historie
 ERROR  2:27:37 PM [vite] error while updating dependencies:                                                                                14:27:37
Error: Build failed with 4 errors:
node_modules/@histoire/app/dist/bundled/components/panel/StoryDocs.js:4:30: ERROR: Could not resolve "virtual:$histoire-markdown-files"
node_modules/@histoire/app/dist/bundled/components/panel/StorySourceCode.js:6:37: ERROR: Could not resolve "virtual:$histoire-support-plugins-client"
node_modules/@histoire/app/dist/bundled/components/story/GenericRenderStory.js:2:37: ERROR: Could not resolve "virtual:$histoire-support-plugins-client"
node_modules/@histoire/app/dist/bundled/util/config.js:1:30: ERROR: Could not resolve "$histoire-config"
    at failureErrorWithLog (/sidebase/node_modules/esbuild/lib/main.js:1566:15)
    at /sidebase/node_modules/esbuild/lib/main.js:1024:28
    at runOnEndCallbacks (/sidebase/node_modules/esbuild/lib/main.js:1438:61)
    at buildResponseToResult (/sidebase/node_modules/esbuild/lib/main.js:1022:7)
    at /sidebase/node_modules/esbuild/lib/main.js:1134:14
    at responseCallbacks.<computed> (//sidebase/node_modules/esbuild/lib/main.js:671:9)
    at handleIncomingPacket (/sidebase/node_modules/esbuild/lib/main.js:726:9)
    at Socket.readFromStdout (/sidebase/node_modules/esbuild/lib/main.js:647:7)
    at Socket.emit (node:events:513:28)
    at Socket.emit (node:domain:489:12)

I was searching around and found an issue posted 2 days ago on the historie github about the same error. Sadly there are no solutions yet:
https://github.com/histoire-dev/histoire/issues/300
Checklist:

[X] issue number linked above after pound (#)

replace "Closes " with "Contributes to" or other if this PR does not close the issue

[X] issue checkboxes are all addressed
[X] manually checked my feature / not applicable
[X] wrote tests / not applicable
[X] attached screenshots / not applicable

@zoey-kaiser I think with https://github.com/histoire-dev/histoire/issues/300#issuecomment-1265852997 this was resolved - so let's see if it works after we upgrade histoire to 0.11.0!

I updated historie to 0.11.0 and I still get the same error 😞
✘ [ERROR] Could not resolve "virtual:$histoire-support-plugins-client"

    node_modules/@histoire/app/dist/bundled/components/panel/StorySourceCode.vue_vue_type_script_setup_true_lang.js:6:37:
      6 │ import { clientSupportPlugins } from "virtual:$histoire-support-plugins-client";
        ╵                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  You can mark the path "virtual:$histoire-support-plugins-client" as external to exclude it from
  the bundle, which will remove this error.


getString does not fallback to default Locale.

Love the framework, excellent job.
I have a question about the fallback locale.
I have an en-GB set of lang.json files which work just great.
I want begin to create an ar-AE locale, but so far I have just done one lang.json file.
However, what I would expect is that if the getString cannot find a bundle for this locale, it should use the fallback locale to try and find the token.
If not, it means that I must add tokens to each language when I add a new string, otherwise they will read %%KEY_NOT_FOUND%% rather than the fallback language, english.
Do you have a change in the works for this?

That's in the roadmap, but for now the solution is to use grunt-angular-localization which will generate a mirror of your default locale for the ar-AE locale except it won't mirror strings that you have already overridden. So there will be some more files that you will need to check in but the files will always remain up to date. I guess you can put the task in to run during the deployment or build stage of your app.
Please let me know if this helps, otherwise I will work on the proposed solution asap.

Hi Rahul,
Thanks, I haven't had the time to modify your base files and add tests, but I've implemented this sufficient for my requirements here: https://gist.github.com/jamescarter-le/5ee99719b8c2a8271920
It falls back to the default locale if there is not a token in the current locale.
Kind Regards,
James

Thanks @jamescarter-le I will take a look and formalize it into the codebase, with tests etc. Looks good :)

I haven't fully followed this through, but just a thought - does this account for the fallback locales (I don't think so)?
In my way of thinking, the fallback should be hierarchical - specified local first, then fallback local, then default local.
So, you might have - de-CH, de-DE, en-US (so Swiss German, then German, then English).
Looking at the code, I think the fallback locale is only processed when we set the locale on startup (or at least not on every conversion).

Hey guys, we're having the same issue for our project. Any update on when this fix is going to be in? At the very least, please support one fallback language for getString().

+1


Logging middleware before Transactional

Hi Matthias!
I've been playing this week with the shiny new version and everything works like a charm, thanks! However, I was wondering why the Transactional Doctrine middleware is registered before the Logging middleware, I would prefer the transaction to be "as close as possible" to the real work done inside the command. If somehow the logging failed that would mean rolling back the transaction too, which is not desirable IMHO

[2015-05-29 12:11:21] doctrine.DEBUG: "START TRANSACTION" [] []
[2015-05-29 12:11:21] command_bus.DEBUG: Started handling a message {"message":"[object] (Ulabox\Inventory\Application\Command\Sku\LinkWithProduct: {})"} []

array(5) {
  [0] =>
  string(71) "simple_bus.command_bus.finishes_command_before_handling_next_middleware"
  [1] =>
  string(56) "simple_bus.event_bus.handles_recorded_mesages_middleware"
  [2] =>
  string(64) "simple_bus.doctrine_orm_bridge.wraps_next_command_in_transaction"
  [3] =>
  string(41) "simple_bus.command_bus.logging_middleware"
  [4] =>
  string(62) "simple_bus.command_bus.delegates_to_message_handler_middleware"
}

Thanks!!

 Sounds like something I overlooked. Not sure if it's
safe to change the priorities though. That might require a new major
version.
In your case you can for now just disable logging and register the
middleware yourself of course.
Op 29 mei 2015 12:28 schreef "Albert Casademont"<EMAIL_ADDRESS>
Hi Matthias!
I've been playing these week with the shiny new version and everything
works like a charm, thanks! However, I was wondering why the Transactional
Doctrine middleware is registered before the Logging middleware, I would
prefer the transaction to be "as close as possible" to the real work done
inside the command. If somehow the logging failed that would mean rolling
back the transaction too, which is not desirable IMHO
[2015-05-29 12:11:21] doctrine.DEBUG: "START TRANSACTION" [] []
[2015-05-29 12:11:21] command_bus.DEBUG: Started handling a message
{"message":"object"} []
array(5) {
[0] =>
string(71) "simple_bus.command_bus.finishes_command_before_handling_next_middleware"
[1] =>
string(56) "simple_bus.event_bus.handles_recorded_mesages_middleware"
[2] =>
string(64) "simple_bus.doctrine_orm_bridge.wraps_next_command_in_transaction"
[3] =>
string(41) "simple_bus.command_bus.logging_middleware"
[4] =>
string(62) "simple_bus.command_bus.delegates_to_message_handler_middleware"
}
Thanks!!
—
Reply to this email directly or view it on GitHub
https://github.com/SimpleBus/SymfonyBridge/issues/18.

Yes I'll do that. Digging a bit further into the problem it seems that the logger middleware gets a -999 priority, just one above the handling middleware that gets a -1000. The Transactional gets a 100, so it's definitely above it!

I guess that what you really wanted is to set the priority of the logging middleware to 999, not -999 just after the FinishesHandlingMessageBeforeHandlingNext

@acasademont You are completely right.
At first I thought this would be a bad change since it might be considered a BC break. However, it's logging, and I think it's reasonable to assume that it no-one would rely on the logging middleware to have a specific priority. Anyway, now it's more like a bug :) So we should fix it.


Add show window option

Hi.
I added an option to show and set focus to the window whether there are new messages or mention.

[x] Complete Mattermost Contributor Agreement
[x] Execute npm run prettify to format codes
[x] Write about environment which you tested

Tested on OS X 10.11.4

Thanks @kyoshidajp for the contribution!!
Just to clarify: when the option is turned on and a user receives a new message or mention, the app will set focus to Mattermost Desktop regardless of which window is on focus at the moment?
Would this also happen if the application is only in the system tray?

@jasonblais Thank you for commenting.
I think so too. I changed not set focus when already set focus.

Thanks @kyoshidajp again!
Can you provide a little more information on the added option? Is it that Mattermost desktop would get focus whenever a new message or mention is received?

@jasonblais Yes. Mattermost desktop would get focus when a new message or mention is received and the window is not focused. The action would lead to get focus whenever a new message or mention is received.

Tested on Win10, works as written.
@kyoshidajp As a whole of your changes, showWindow seems ambiguous. For example, how about showWindowOnNewMessage?
Then, please check the agreement again. You have to be listed as an approved contributor.

@yuya-oc thank you for testing my branch.
I changed properties name from showWindow to showWindowOnNewMessage. And I was listed contributor's page.

Hi @kyoshidajp, and big thank you for the suggestion and submitting a pull request for it.
I'm not sure how many people would use the setting, and what the end vision for the feature would be.. Therefore, I'm proposing to have your help contributing your suggestion in the feature idea forum so it can be discussed, upvoted and considered for a ticket accepting pull requests?
Please include a link back to this GitHub Issue and feel free to have a link to the branch containing the code.
You get 10 votes in the feature idea forum, and each one influences the future of the project.

Thanks @kyoshidajp!!
Again, appreciate the pull request and suggestion, will be interesting to see how others might feel about it

Thanks @kyoshidajp again for this pull request,
For now, we'll close this pull request and continue to follow the response in the feature request that you submitted.
Setting focus to the app window when a new message or mention is received is different from the normal app behaviour. Hence, we'd first like to confirm that this will be a useful option to have for many people


SS58 prefix

requires https://github.com/paritytech/substrate/pull/8882

It's in Substrate. Do we close or wait for update to that version?

@jak-pan update basilisk chain spec as well

blocked by https://github.com/paritytech/substrate/pull/8955


[2.8] can't enable Azure AD because there is a timeout when our login code tries to do a simple GET on the user

backport #45004

validation template here: https://github.com/rancher/rancher/pull/45572#issue-2310584147

Validated on v2.8-head id d72c515.
Observed updated(actual) error message instead of internal error that would show before when enabling AzureAD with a custom endpoint that points to a site/port that will not connect.


chore: Update docker-compose

Closes #11
Includes:

Add worker micro-service
Add separated Postgres database for the metadata service (Thanks @Woynert)
Add missing environment variables in the Gateway service

Notes:

There is an error when the Gateway tries to connect to the Worker. I think the Gateway image needs to be updated in the Gateway repo since the Dockerfile in the main branch doesn't have some of the new environment variables.
I suggest keeping this PR open until the Gateway image is updated to ensure everything works well

I'll merge this so you can start using it. I have tested it locally with the Gateway CLI, all seems to be working, but please, open a new issue if you face any problem working with the docker-compose file.


Added a shell-script linter

Motivation and Context

Helps ensure that we aren't making any simple to avoid mistakes when writing bash scripts.

How Has This Been Tested

Ran shellcheck on the shell files in our repo.
Added shellcheck to our pre-commit hooks
Added some newer, but useful pre-commit hooks to the repo.

Checklist

[X] My code follows the code style of this project.
[] My change requires a change to the documentation.
[] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have completed my CLA (see CONTRIBUTING)
[] I have added tests to cover my changes.
[] All new and existing tests passed.

I could also look into adding sh-fmt, but I just wanted a simple program that caught many of the pitfalls people make when writing bash scripts.


Except Standard_HB120rs_v3, are other machines constraint vCPUs?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbcdc548-7d75-b2a1-6eb4-81809238678c
Version Independent ID: 680c0d06-0f53-0019-f790-fa9d278e9bb9
Content: HBv3-series - Azure Virtual Machines
Content Source: articles/virtual-machines/hbv3-series.md
Service: virtual-machines
Sub-service: vm-sizes-hpc
GitHub Login: @vermagit
Microsoft Alias: amverma

On H*-VM size families, not yet, but coming soon :)
Though the General Purpose VM sizes (D/E/F) have many constrained core sizes available today.
The H* docs will be updated when those are available.
Though interested in your feedback on how you're using the HBv3 constrained core sizes today and what are you looking for in backporting this capability to the other VM sizes. Is there any specific config or app you use?

As per the naming convention document, all the machines except Standard_HB120rs_v3 can be classified as constraint vCPU?
https://docs.microsoft.com/en-us/azure/virtual-machines/vm-naming-conventions

Yes, the same naming convention is followed.

Seems that constraint vCPUs are using Hyphen as a separator between [# of vCPUs] + [Constrained vCPUs]?
For E.g. All constraint machines are using the hyphen e.g. Standard_M8-2ms, Standard_M8-4ms, etc.
https://docs.microsoft.com/en-us/azure/virtual-machines/constrained-vcpu
But whereas if we follow the same naming convention with a hyphen as separator then Standard_HB120-64rs_v3 should be categorized as constraint vCPUs.
Can you please let us know what is the separator between [# of vCPUs] + [Constrained vCPUs] is?

Hello Aman and Karishma, Please let me know if you need any input from me.

Is there any update here?
As per the naming convention, https://docs.microsoft.com/en-us/azure/virtual-machines/vm-naming-conventions following machines needs classification of Constrained vCPU. But we are not seeing this in https://docs.microsoft.com/en-us/azure/virtual-machines/constrained-vcpu
Standard_HB120-96rs_v3, Standard_HB120-64rs_v3, Standard_HB120-32rs_v3, Standard_HB120-16rs_v3
Can you please confirm if Standard_HB120-96rs_v3, Standard_HB120-64rs_v3, Standard_HB120-32rs_v3, Standard_HB120-16rs_v3  are Constrained vCPU?

@NikhilD16 : Yes, the listed HBv3 VM sizes are indeed constrained core sizes as you correctly inferred from the naming convention. For details on the HBv3 VM sizes, please refer to their docs: https://docs.microsoft.com/en-us/azure/virtual-machines/hbv3-series and the associated topology in https://docs.microsoft.com/en-us/azure/virtual-machines/workloads/hpc/hbv3-series-overview.
@Karishma-Tiwari-MSFT : You may want to re-direct the request of "But we are not seeing this in https://docs.microsoft.com/en-us/azure/virtual-machines/constrained-vcpu" appropriately for that page owner to update their page with latest constrained core sizes.

I believe this has been addressed.
If issues are still present, just let me know.
#please-close