Need to augment wheel tag computation code to account for nogil builds

Starting with Python 3.13 there will be a nogil variant of the interpreter that will need to be get an interpreter tag in the wheel tag string. See https://discuss.python.org/t/python-abis-and-pep-703/34018

See also https://github.com/pypa/packaging/issues/727 https://github.com/pypa/packaging/pull/728 https://github.com/pypa/packaging/pull/747

gh-621 addresses part of this. As of today, it's not yet very easy to test with a free-threaded CPython build and make the test suite pass. The hiccups are:

pip does not yet have support. Two issues: it incorrectly installs incompatible abi3 wheels, and it refuses to install wheels with the cp313t/cp313td ABI tag. The former doesn't affect meson-python, the latter was a little painful to work around (see below for how).
cython does not yet have full support. The latest release (3.0.10) fails to build one of our test packages (the complex one), however the branch from https://github.com/cython/cython/pull/6137 does work.
CPython needs to be built from source (./configure --with-pydebug --disable-gil)

In order to make pip install wheels with the t tag, the _fail_if_link_is_unsupported_wheel function in pip/_internal/resolution/resolvelib/factory.py needs to be patched - simply replacing raise UnsupportedWheel(msg) with return is enough.
Then the venv fixture in our test suite needs patching, because it installs a fresh copy of pip in the venv's it creates. This hacky patch does that (replace path to site-packages as needed):
diff --git a/tests/conftest.py b/tests/conftest.py
index 80303a14f..68df9e2ef 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -101,7 +101,14 @@ class VEnv(EnvBuilder):
 @pytest.fixture()
 def venv(tmp_path_factory):
     path = pathlib.Path(tmp_path_factory.mktemp('mesonpy-test-venv'))
-    return VEnv(path)
+    fixture = VEnv(path)
+
+    # Apply fix to `pip` installed into venv to avoid unknown tag issue
+    sitepkg_dir = '/home/rgommers/mambaforge/envs/nogil/lib/python3.13/site-packages'
+    sitepkg_venv = str(path) + '/lib/python3.13/site-packages'
+    _file = '/pip/_internal/resolution/resolvelib/factory.py'
+    subprocess.run(['cp', sitepkg_dir + _file, sitepkg_venv + _file])
+    return fixture

 def generate_package_fixture(package):

gh-621 addresses part of this

@rgommers With #621 merged, what is left to do to support nogil Python?

Everything works, I only left this open to remind myself to add a CI job once the setup-python action starts offering a free-threaded CPython.
Happy to close this though and keep track of that task elsewhere - it's not urgent, and we're unlikely to regress on full support.

Do you have a sense for when we may see nogil builds available via actions/setup-python? The alpha releases of Python 3.13 are available, but no nogil builds.

Tracked in https://github.com/actions/setup-python/issues/771. No timeline, but I think the desire is to do that for the 3.13.0b1. So hopefully in May.

Oh, you mentioned the actions/setup-python bug in #621. I noticed it when I read the PR but then I completely forgot about it, sorry. Our test matrix is becoming very large. I'm wondering if there is something that would be reasonable to drop.

We should probably be able to drop some Meson versions? If we test oldest/newest releases plus master branch, that gets us pretty much what we need. Unless we have a specific reason to test every minor version. We can also combine Meson and Python versions, rather than having separate jobs for "check each Python version with latest meson" and then "check each meson version".

You can use python3.13t in manylinux2014+ starting today.

Awesome. I wasn't expecting that just yet, but it looks like it was enabled by including pip 24.1b1 in the image (see https://github.com/pypa/manylinux/pull/1564).

I'm giving it a try just now, see #627

Tests for free-threading Python 3.13 are up and running. Closing this issue.


Compiler Failing because of implicit declarations

Getting this as an output of make
src/gfx/png.c:166:2: error: implicit declaration of function 'png_set_quantize'
      is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        png_set_quantize(img->png, palette, colors, colors, NULL, 1);

This is with using Clang, I should probably add.

Tried with gcc, was able to build with the release 0.24 version however, not sure what the issue is then.

What version of libpng are you using?

I've tried with a few different versions, I've tried, libpng3, libpng12, libpng16, same error each time. But I was able to make and install This version without any issues. Has something major changed?

Well, the obvious change since 0.2.4 is that there’s now a program that actually uses libpng, rgbgfx.

What operating system are you using?
rgbgfx builds fine here with clang and libpng-1.6.25. You should definitely be using 1.6.something—rgbgfx uses libpng APIs from that version.

I'm on Ubuntu Linux 16.04.
Ill double check and get back to you with full versions and compiler output
On 13 Sep 2016 9:06 am, "Anthony J. Bentley"<EMAIL_ADDRESS>wrote:

What operating system are you using?
rgbgfx builds fine here with clang and libpng-1.6.25. You should
definitely be using 1.6.something—rgbgfx uses libpng APIs from that
version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bentley/rgbds/issues/92#issuecomment-246606671, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKaur-2hKXfuzEezZxJ_coZBxlKYPX8sks5qplmFgaJpZM4J6ttB
.

#94

I also just ran into this error and fixed it by installing the latest 1.6 version of libpng from sourceforge.
Xubuntu 16.04 (and consequently Ubuntu 16.04) uses libpng 1.2.54 so we must install libpng from source.
Even installing libpng-dev does not install a newer version (perhaps that's obvious to more experienced people unlike myself)

Right, this can be solved by installing a current libpng (too bad they keep “improving” the API all the time). Not related to #94 either.

I honestly wouldn't have thought to install the newer version of libpng if it weren't for this issue.
Is there anyway we can make checks during the make process?
pkg-config --modversion libpng
will return the version of libpng

I hope I'm not bothering anyone writing in a closed issue, but #104 addresses the issue stated by @SirSharpest, grating compatibility with older libpng versions.


Update the WOFS query function to query the AGDC database for WOFS datasets

Currently the WOFS datasets are being queried from the filesystem as they have not yet been ingested into the AGDC database.
Once they have been ingested the query method should be updated to use the database records.

I've updated the code to query the database for WOFS datasets but due to an issue in the WOFS ingest the WOFS datasets are not being associated with the correct acquisition record.
See issue #83.
Once re-ingested I'll re-run my tests.


How do I set up multi capabilities when run the configure file

gpu ： one gtx 1060
system: linux
source code: tensorflow/r1.15
expect capability: 5.2,6.0,6.1,7.0,7.5
I have only one gpu, but i want to set mutil capabilities  when build libtensorflow.

input   5.2,6.0,6.1,7.0,7.5 or [5.2,6.0,6.1,7.0,7.5] or others?

@Zhangts98
In order to expedite the trouble-shooting process here,Could you please fill the issue template,
Can you please share the output [please share text in place of screenshots which will help other users as well]
Thanks!


[Event Change Request] codeunit 1002  "Job Create-Invoice" - OnBeforeInsertSalesLine2

Hello, would it be possible to add OnBeforeInsertSalesLine2 event to codeunit 1002  "Job Create-Invoice", like this:
There is an existing event OnBeforeInsertSalesLine( that has been updated with additional parameters.
    local procedure CreateSalesLine(var JobPlanningLine: Record "Job Planning Line")
...
          SalesLine.Description := JobPlanningLine.Description;
         SalesLine."Description 2" := JobPlanningLine."Description 2";
         SalesLine."Line No." := GetNextLineNo(SalesLine);
         OnBeforeInsertSalesLine(SalesLine, SalesHeader, Job, JobPlanningLine);
//Existing->        OnBeforeInsertSalesLine(SalesLine, SalesHeader, Job, JobPlanningLine);
>         OnBeforeInsertSalesLine2(SalesLine, SalesHeader, Job, JobPlanningLine, JobInvCurrency, JobOrigin); //New Event
         SalesLine.Insert(true);

         if SalesLine.Type <> SalesLine.Type::" " then begin
             NoOfSalesLinesCreated += 1;

      [IntegrationEvent(false, false)]
//Existing->    local procedure OnBeforeInsertSalesLine(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; Job: Record Job; JobPlanningLine: Record "Job Planning Line")
     local procedure OnBeforeInsertSalesLine2(var SalesLine: Record "Sales Line"; var SalesHeader: Record "Sales Header"; Job: Record Job; JobPlanningLine: Record "Job Planning Line"; JobInvCurrency: Boolean; JobOrigin: Boolean)
     begin
     end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 53874.


refactor: add bitwise_memcpy

This pr not only extracts the shift and copy bits logic a new function(bitwise_mempcy), but also includes a slight update: now bitwise_memcpy leaves unchanged all the bits that are not part of the copy in the destination

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#567  👈 (View in Graphite)
#566
#565
#564
master

This stack of pull requests is managed by Graphite. Learn more about stacking.


error: Rate Limit Exceeded #2

After more testing with the fix in place for the previous issue (#1), I hit the rate limit exceeded error again. Debugged like before and found that filtron has a rss/csv/json limit. Since this app uses json, it got caught by the limit which in my case (default filtron settings) was a dismal 2 requests every 121 seconds. I just disabled the json part of that rule for now but if using other searx instances with that rule in place, this same problem will occur.
Fix would be to not use the format flag at all and render the html page instead of json

Seems like the solution is to rewrite this app using webviews

See new app (currently works fine but still WIP) here: https://github.com/Zackptg5/Searx-Android


Android implementation

Stumbled upon this implementation initially borrowed from Shopify.
https://github.com/jqn/AndroidAutoExample
If I were to port this over to our repository, would you like to rename this library to something more generic?
react-native-auto
react-native-car
react-native-vehicle
Or just stick to CarPlay

If this one repo was going to support both CarPlay and Android Auto, I'd vote for react-native-vehicle.

agree re. react-native-vehicle

There's active development for android auto in https://github.com/doublesymmetry/react-native-track-player/pull/2094
For anyone using react-native-track-player for audio playback this looks very promising.

Hi @birkir, are there any updated about the Android Auto implementation?

I do have a repo for Android Auto. I worked on it a while back and I have implemented a couple of features. I started from Shopify's Android Auto.
I'm planning on creating a new repo that integrates both Android Auto and CarPlay. I'm thinking of rewriting the CarPlay implementation from scratch as Android Auto uses a declarative approach. I would definitely take inspiration from this repository.
If anyone is interested feel free to contribute. This is the link to the repository, it is currently empty 😂, I will integrate Android Auto.

@susonthapa sorry for the basic question, but why not implement the Android part in this repository? Then you could change the name of the library and repository without starting another library from scratch

@susonthapa sorry for the basic question, but why not implement the Android part in this repository? Then you could change the name of the library and repository without starting another library from scratch

This is just my opinion so I don't expect everyone to agree with it. This library uses an imperative approach, and changing it to declarative would be a huge undertaking not to mention that it is written in Objective-C which I think is quite outdated.
After working on the Android Auto library and this library(more or less), I think the declarative approach is the way to go. Either way, I'm just sharing something I worked on.

Awesome stuff, @susonthapa ! Will definitely keep an eye on it, and maybe help out when we start CarPlay & Android Auto development :)
Especially if it has some Expo support

@susonthapa sorry for the basic question, but why not implement the Android part in this repository? Then you could change the name of the library and repository without starting another library from scratch

This is just my opinion so I don't expect everyone to agree with it. This library uses an imperative approach, and changing it to declarative would be a huge undertaking not to mention that it is written in Objective-C which I think is quite outdated.
After working on the Android Auto library and this library(more or less), I think the declarative approach is the way to go. Either way, I'm just sharing something I worked on.

I’m actively working on the platform integration for Android Auto. A significant part of this effort involves bridging the differences between CarPlay and Android Auto, creating common templates, configs, and types, which I’ll document in detail. Expect updates on this soon.
Regarding the debate on whether imperative API is a bad approach for template API proxy. It’s actually the primary reason I didn’t chose the reconciler route, I’ve done some fiber work in the past.
With AA it makes a little bit more sense, as the platform has few more cases like the map template. But I’d still stick with imperative and offer declarative react for free-form rendering. Heck, I think RN-carplay could easily be sugarcoated with a reconciler on top of the current API, if that's the verdict we want.
I don't think that Obective-C is necessary a bad thing, worse dx for the library mainteners but easier for users and I feel the same with Kotlin, is it a no brainer today or are there still compatability/conflict issues like it used to a year ago?
Great discussion 👍

Thanks for the info @birkir. I didn't know you were actively working on AA. Looking at the comments I thought AA won't be implemented anytime soon(my bad 😂) so I took matters into my own hands.
I think I might have created confusion around the declarative and imperative approaches. The native library will still expose the imperative API, but the reconciler will expose a declarative API.
I'm not familiar with Objective-C so I don't know what limitations were there a year before. I find it very difficult to work with Objective-C(and even Swift, I'm originally an Android developer so maybe that's why 🤷♂).
I don't want to create another implementation for the same thing, Do you have a branch or a repo where you are doing the work? I will be more than happy to contribute. I kinda have a deadline for adding AA support on one of the apps that I work on so I was just building what I can. In the meantime, I will still be messing around with my implementation.

After looking at your repo @susonthapa I am pretty sure I will start pointing the work towards your implementation, you seem have gotten the furthest in terms of building the parser. Just need to start using Kotlin, not a big deal.
I am currently jumping between these implementations - so my working branch is a hot mess atm 🔥

https://github.com/Shopify/react-native-android-auto
https://github.com/jqn/AndroidAutoExample
https://github.com/susonthapa/react-native-android-auto

But what I can do is start a PR with changes that makes sense as a starting point.

Make Android example app working.
Support Android Auto in example app manifest
Add my documentation updates, which so far only covers ListTemplate and a bunch of other things.
No implementation at this point, because what I am unsure about is how to manage the react context (another entry point, registerComponent or something else). I'll just put a random screen up there.

After looking at your repo @susonthapa I am pretty sure I will start pointing the work towards your implementation, you seem have gotten the furthest in terms of building the parser. Just need to start using Kotlin, not a big deal.
I am currently jumping between these implementations - so my working branch is a hot mess atm 🔥

https://github.com/Shopify/react-native-android-auto
https://github.com/jqn/AndroidAutoExample
https://github.com/susonthapa/react-native-android-auto

But what I can do is start a PR with changes that makes sense as a starting point.

Make Android example app working.
Support Android Auto in example app manifest
Add my documentation updates, which so far only covers ListTemplate and a bunch of other things.
No implementation at this point, because what I am unsure about is how to manage the react context (another entry point, registerComponent or something else). I'll just put a random screen up there.

#151

I started with https://github.com/Shopify/react-native-android-auto and fixed a lot of issues there. I have also implemented the MapTemplate which was quite hard. Unlike CarPlay where you can access the Window and tell ReactNative to render there, AndroidAuto only exposes a SurfaceContainer. I had to resort to Virtual rendering but I got it to work. This is how it looks right now.
https://github.com/birkir/react-native-carplay/assets/33973551/88cca453-5436-4b9a-8e32-ce18087f5d13
The Redbox is being rendered from React, we can render anything in there including a Map.
@birkir Let me know if you need any help with the implementation of Android Auto.

Awesome! Haven't tried to render a map or anything dynamic, but hope it will be smooth. I guess it is also how iOS CarPlay works behind the scenes.
Quick question,
https://github.com/susonthapa/react-native-android-auto/blob/main/android/src/main/java/com/reactnativeandroidauto/CarServiceSession.kt#L43-L65
Any concerns about doing it this way? Are we limited to any specific RN version or all good?

Awesome! Haven't tried to render a map or anything dynamic, but hope it will be smooth. I guess it is also how iOS CarPlay works behind the scenes.
Quick question, https://github.com/susonthapa/react-native-android-auto/blob/main/android/src/main/java/com/reactnativeandroidauto/CarServiceSession.kt#L43-L65
Any concerns about doing it this way? Are we limited to any specific RN version or all good?

Looks like the ReactInstanceEventListener is deprecated and the currentReactContext is only visible for testing. This is working for the time being but I think we should come up with an alternative.
It's been quite a while since I looked into this portion of the code, I will need to refresh my memory 🙂.

Makes sense, reason I am in that section of the implementation, is because of hot reload and dev menu refresh.
I can't seem to figure it out, the module appears to always be cached.
I have updated the PR if you want to take a look.

Makes sense, reason I am in that section of the implementation, is because of hot reload and dev menu refresh. I can't seem to figure it out, the module appears to always be cached.
I have updated the PR if you want to take a look.

Interesting, let me look into it. I didn't think about the HMR 😁. I will let you know if I find any way to make the HMR work.

@birkir I did some research but couldn't find a way to detect when the JS code changes. If we could detect that we can call the reload function to reload the app.
I was curious how the hot reload works on CarPlay. Did you have to do something to make the HMR work on CarPlay?

@birkir I did some research but couldn't find a way to detect when the JS code changes. If we could detect that we can call the reload function to reload the app.
I was curious how the hot reload works on CarPlay. Did you have to do something to make the HMR work on CarPlay?

The main difference is that the whole CarPlay experience is driven through the host (app) so we get hmr for free.
AA runs three processes if I understand it correctly. (Host, communications and screen). Spotify went the route of calling AppRegistry.registerRunnable which doesn't have any connection to the metro bundler.
I was able to communicate between the two using classic broadcasts but that's about it.

@birkir I did some research but couldn't find a way to detect when the JS code changes. If we could detect that we can call the reload function to reload the app.
I was curious how the hot reload works on CarPlay. Did you have to do something to make the HMR work on CarPlay?

The main difference is that the whole CarPlay experience is driven through the host (app) so we get hmr for free.
AA runs three processes if I understand it correctly. (Host, communications and screen). Spotify went the route of calling AppRegistry.registerRunnable which doesn't have any connection to the metro bundler.
I was able to communicate between the two using classic broadcasts but that's about it.

I didn't know about that, good info.
When doing my research I found the invalidate function which gets called whenever we reload the bundle(by pressing 'r' from the terminal). In my implementation, I get an error when manually reloading the bundle which I can fix by adding some cleanup code to the invalidate function.

I have release the draft version of AndroidAuto in version 2.4.0-beta.2 of react-native-carplay.
Would be great to get community help taking this forward, testing, docs, features etc.
Refer to the example app to see how this is setup.

@birkir  The documentation says that on three car app categories are supported:
androidx.car.app.category.NAVIGATION
androidx.car.app.category.POI
androidx.car.app.category.IOT
So audio/Media is not supported ? I am looking to add react-native-track-player to android auto, is it feasible or is it too unstable at the moment ? thanks

@birkir The documentation says that on three car app categories are supported: androidx.car.app.category.NAVIGATION androidx.car.app.category.POI androidx.car.app.category.IOT So audio/Media is not supported ? I am looking to add react-native-track-player to android auto, is it feasible or is it too unstable at the moment ? thanks

I am here to ask exactly this. I've tried it, but my headunit keeps crashing the app. Any advice would be great

@andreknieriem we are successfully using https://github.com/doublesymmetry/react-native-track-player/pull/2094 in production - works like a charm.

There's active development for android auto in doublesymmetry/react-native-track-player#2094 For anyone using react-native-track-player for audio playback this looks very promising.

@andreknieriem we are successfully using doublesymmetry/react-native-track-player#2094 in production - works like a charm.

There's active development for android auto in doublesymmetry/react-native-track-player#2094 For anyone using react-native-track-player for audio playback this looks very promising.

Hey this seems to look really nice. How can use this unmerged version?

This is the source branch: https://github.com/lovegaoshi/react-native-track-player/tree/dev-android-auto
Try forking it or use it directly in your package.json

This is the source branch: https://github.com/lovegaoshi/react-native-track-player/tree/dev-android-auto Try forking it or use it directly in your package.json

Sorry to bother you, but I've tried it and I am not able to get this to work via package.json. Do you have an example config? Thanks!

Add this to your dependencies:
"react-native-track-player": "git+https://github.com/lovegaoshi/react-native-track-player.git#a5451f75dec3d5863f480d559053848f6050a564",

This will install the latest commit on that branch.
Since the maintainer keeps rebasing/merging the changes from react-native-track-player, it will install version 4.1.1 of RNTP with the Android changes on top.

Hey @DanielKuhn. Thanks I got it working. So you using trackplayer standalone or with this package for the other views?

We're using RNTP for music playback on both platforms and the changes by @lovegaoshi in the branch for displaying the list views/media items on Android Auto.
On iOS we're using this package to display the CarPlay UI, triggering playback onItemSelect, displaying the currently playing track on the NowPlayingTemplate and displaying track progress on the list items.

Can someone please provide me with a starter code for Android? Thank you.

@7ur813z There is already working example in the repo's master branch

@7ur813z I meant this example https://github.com/birkir/react-native-carplay/tree/master/apps/example
Docs seems to be a bit out of date

@mefjuu Yes, I used that example. These are the exact steps that I did:
git clone https://github.com/birkir/react-native-carplay.git
cd react-native-carplay/apps/example
yarn install
yarn run android
But I get this error:
Error: Activity class {org.birkir.carplay/org.birkir.carplay.MainActivity} does not exist.


version numbers / image tags in kedge YAML

whats the current approach for replacing version numbers in a kedge YAML? Am thinking of CI / CD pipelines that tend to generate new unique release numbers for each new version and tend to put those versions in the YAML as a version label and then use the docker image tag of the same name as the version
should we use environment variable expressions or something? e.g.
name: foo
labels:
  version: "${VERSION}"
image: "foo/bar:${VERSION}"

then we can specify it via something like...
export VERSION="1.2.3"
kedge create -f foo.yaml (or whatever the command is ;)

whats the current approach for replacing version numbers in a kedge YAML?

None, as of now.
Supporting substitution of env var like that SCTM!

cool - we'd just need to be a little careful that whatever expressions we use for env var substitution we don't clash with possible OpenShift Template / Helm parameter expressions

it'd be nice to move this to 0.2.0 to raise its importance so we can try versioned YAML generation in Jenkins pipelines soon

0.2.0 will be released today.
We will work on this in coming sprint and it will be added in 0.3.0 release

Ingress bits can be parameterised  as well as per #41

I was thinking about best syntax that we can use for parameters so it doesn't conflict with Helm charts variables or OpenShift templates.
We probably shouldn't use the Bash way of specifying variables (${VARIABLE}" ). This might conflict with OpenShift templates. If we will add Helm support in the future we shouldn't use Go templates syntax for variables ({{ variable }}`), as this will conflict with Helm templating.
So I was thinking that we could use [[ variable ]] But it looks a bit strange but as far as I know it shouldn't conflict with anything in OpenShift templates, Helm, Kubernetes or Bash.

@kadel

[[ variable ]]

SGTM!


Unsure if bug but reporting multiple false positives

I ran a quick check against Slack and Google CloudStore, it found many (all?) issues, but confirming each one shows that a 404 was sent. Here's the output with a random company string:
$ ./misconfig-mapper -target "2948fy2we30d9jg" -service 4 -delay 1000
[+] Checking 49 possible target URLs...
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[+] 1 Google CloudStorage Bucket Misconfigured Read Permissions Instance found!
URL: https://2948fy2we30d9jg.storage.googleapis.com/
Service: Google CloudStorage Bucket Misconfigured Read Permissions
Description: GCP Storage Bucket can be left misconfigured and allow anyone to access files and objects potentially containing sensitive data if access permissions aren't properly enforced

References:
        - https://bugology.intigriti.io/misconfig-mapper-docs/services/google-cloud-storage-bucket/google-cloud-storage-bucket
        - https://cloud.google.com/storage/docs/access-control/making-data-public#buckets
        - https://cloud.google.com/storage/docs/public-access-prevention
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Connecting manually to that endpoint shows a 404:
$ curl -vvv -k https://2948fy2we30d9jg.storage.googleapis.com/
<snip>
< HTTP/2 404
< content-type: application/xml; charset=UTF-8
< content-length: 133
< date: Fri, 10 May 2024 11:37:54 GMT
< expires: Fri, 10 May 2024 11:37:54 GMT
< cache-control: private, max-age=0
< server: UploadServer
<
* Connection #0 to host 2948fy2we30d9jg.storage.googleapis.com left intact
<?xml version='1.0' encoding='UTF-8'?><Error>NoSuchBucket<Message>The specified bucket does not exist.</Message></Error>

Running the latest release on 64 bit Linux

Hi @nopcorn
Thank you for your feedback!
A more robust filter to check for misconfigured GCP read permissions will be included in the next release.
I will leave this issue open for now until a new release is available (probably before the end of this week).

Hey @nopcorn!
A fix is available now! You can update your templates using the -update-templates flag:
./misconfig-mapper -update-templates

Thank you for your contributions!


Debounce DAO field in wallet input

Describe the bug
The DAO wallet input is not debounced. This leads to a performance issue.
To Reproduce
Steps to reproduce the behavior:

Open Network tab in web console
Type in the DAO wallet input

Expected behavior
See a single RPC request once the user has not typed for something like 500ms.
Screenshots

Additional context
Reported here #66

@koussay-khelil field in question:


add HMP Empire plot

@Oddant1, could you review/merge this one when you get a chance?

The path in the index.json was wrong, but I cleaned that up. Otherwise looks good.

Thanks!


[Welcome to Foundation 6] No Share on Twitter button

How to reproduce this bug:

Go to http://foundation.zurb.com/sites/docs/
Locate Github Star button
According to Raffi in the Introduction to the docs video there should be a Share on Twitter button

What should happen:
See a Share on Twitter button
What happened instead:
No visible Share on Twitter button
Browser(s) and Device(s) tested on:
Google Chrome
Mozilla Firefox
Test case link:

CodePen with Foundation 6.3.0 and MotionUI

CodePen with Foundation 6.3.0, Flexbox grid and MotionUI

CodePen with Foundation 6.3.1 and MotionUI

CodePen with Foundation 6.3.1, Flexbox grid and MotionUI

This was removed in a later design iteration... @rafibomb can you take on updating that section of the video?

Bump. So we do not need a Twitter share button? Was it only a design decision or due to other problems with the integration?

Can we update video?

Closing as updating the video might not be possible anymore and we might leave it like it is.


Adds command context option set, Closes #4045

This command adds command context option set.
Closes #4045

Nicely done @nicodecleyre, we'll review it ASAP!

Hello @pnp/cli-for-microsoft-365-maintainers  - While reviewing this PR, I found a scenario that we have not identified m365 context option set as an item. But we do have m365 context option add.
That being the case, I am in an opinion to rename the m365 context option add as m365 context option ensure so that it covers the feature of add as well as set. Do you agree?
Adding to that, if we give this command as ensure, you may not need the command for m365 context init since this command does that operation of initializing the context automatically.
Appreciate your opinion on the same

Hi @nicodecleyre  - I have already added some comments. But you don't need to take action right away on that till we get a consensus on this discussion.
I will let you know once we are ready with our review.
Sorry for the confusion caused.

I am not fully aware of why we have an add and set command for this. But what I think is the most logical is that we just create a set command that is capable of adding/setting stuff, just like we do for cli config ... commands.

I am not fully aware of why we have an add and set command for this. But what I think is the most logical is that we just create a set command that is capable of adding/setting stuff, just like we do for cli config ... commands.

Thanks @milanholemans for your comments.
With respect to the cli config comments, we are setting the values for predefined set of keys (autoOpenLinksInBrowser,  copyDeviceCodeToClipboard etc. ) which we already have. In that scenario, in my opinion, it totally make sense to use set alone for setting values for existing keys.
But here, users do have the option to have new key add to the configuration (like listId, webUrl etc.). Confusion which I am having is, what will happen if the user tries to add a key which is already there having a value.

Will the new value replace the existing value
Or it will show an error that there is already a key in the context.

My suggestion is to go with option 1, but by replacing the current verb add with ensure so that we don't need to overkill the context operation by having another set command.  Hope it is clear now.

With respect to the cli config comments, we are setting the values for predefined set of keys (autoOpenLinksInBrowser,  copyDeviceCodeToClipboard etc. ) which we already have. In that scenario, in my opinion, it totally make sense to use set alone for setting values for existing keys.
But here, users do have the option to have new key add to the configuration (like listId, webUrl etc.). Confusion which I am having is, what will happen if the user tries to add a key which is already there having a value.

Hi Arjun
From my point of view there is not really a difference between this and cli config set. Ok for cli config set there's a predefined set of keys which we don't have here, but does that matter? It's not the case that these values are already present in the user's config file, we add/update them with the cli config set command, which we are doing for this context command as well.

Will the new value replace the existing value
Or it will show an error that there is already a key in the context.

My suggestion is to go with option 1, but by replacing the current verb add with ensure so that we don't need to overkill the context operation by having another set command.  Hope it is clear now.

I'd definitely go for the first option.

I'd definitely go for the first option.

Thanks Milan for your comments. Point taken for your opinion on using set for setting the values. So If I understand correctly, what you proposing is to have the command as context option set. Then if there is already a key, then it will get replaced with the new value, is my understanding right?
Let us also wait from others and take it from there.

I'd definitely go for the first option.

Thanks Milan for your comments. Point taken for your opinion on using set for setting the values. So If I understand correctly, what you proposing is to have the command as context option set. Then if there is already a key, then it will get replaced with the new value, is my understanding right?

Correct!

Let us also wait from others and take it from there.

Certainly, like mentioned before, I'm not 100% up-to-date on these commands so I'm certainly open for the input of others. But this is just my opinion on it :)

I'm with @arjunumenon on using ensure to more clearly communicate the command's intent. Here's the reasoning... if you look at any other set command in the CLI, if you try to use it on a non-existent object, the command will fail. set commands are meant for updating existing objects. Same goes for add: if you try to add a web with the same URL as another web, the command will fail, it won't allow you overwrite it. An ensure command is about expressing the final state: if the thing isn't there, add it, if it's there, update it. So if we want to have this behavior (which we currently have in the code), we should rename the command to ensure and deprecate and later remove init, because ensure covers it. If we want to keep it separate, then we should have a separate add and set and fail on conflicts. This would help us keep the CLI commands consistent across the board.

You're bringing up a good point. Thinking about config set I wonder if the thinking there wasn't that each config option has an implicit default value in code, and using the command you set it to something else. It doesn't take away the fact that we're dealing with the config code the same way ensure would (if the value isn't there, add it, if it's there, overwrite it). We could use the same thinking here, but then I suggest we rename the command to set instead of add to have at least some degree of consistency.

ok for everybody if i update the command to context option set?

I know your gonna hate me but TBH I would go for ensure instead of add/set. Deprecate and remove the init. And also modify the config set to config ensure to be consistent.
In all other places set is used to modify if something exists. Here it is not the case, at least that is how I see it 😉.

And also modify the config set to config ensure to be consistent.

Don't really agree here, from a user perspective config set sounds more logical than config ensure. Users don't really know what is happening under the hood anyway.

I think we now have a direction and then based on this discussion, let us change the spec to context option set. I will update it on the issue as well so that there would not be any confusion in future.
@nicodecleyre - This should have been identified during the spec process which we did not. So onus is totally on we maintainers. We are very sorry for the inconvenience caused due to this.
Do you mind making the change  and resubmit the PR please. I will mark the PR as Draft for now. and you can update it once you are ready with the PR.

I think we now have a direction and then based on this discussion, let us change the spec to context option set. I hope you are ok with that @Adam-it 😊

Sure. Thanks @arjunumenon for awesome review and coordinating this. 👍

I think we now have a direction and then based on this discussion, let us change the spec to context option set. I hope you are ok with that @Adam-it 😊
I will update it on the issue as well so that there would not be any confusion in future.
@nicodecleyre - This should have been identified during the spec process which we did not. So onus is totally on we maintainers. We are very sorry for the inconvenience caused due to this.
Do you mind making the change and resubmit the PR please. I will mark the PR as Draft for now. and you can update it once you are ready with the PR.

No need to apologize @arjunumenon , some things just come up during the process.
Will update the PR shortly!

Updated the PR with the feedback! Thank you for your review @arjunumenon 🤩 !

@nicodecleyre you rock 🤩🤩

@arjunumenon are you planning to continue on PR review of this one? If not I will be more than happy to help out 🙂

@arjunumenon are you planning to continue on PR review of this one? If not I will be more than happy to help out 🙂

Thanks @Adam-it for the check. I am planning to review both set and remove in a single review. I will take that up hopefully tomorrow. If I am unable to take for any reason, I will definitely flag you so that you can take it up.
Thanks again @nicodecleyre for the help.

Thank you for your detailed review @arjunumenon, precessed your feedback!
Can you take another look whenever you got time? 😄

Thanks for the quick process.
Totally!. Would love to have a look into that.

Reopening and closing to trigger Parker


fix(technical/#1749): ballooning window size

Issue: Every time Oni2 was opened in a previous workspace the window size would grow from what was persisted before is some form of scaling was used.
Defect: The window size was persisted using pixel size, but restored using screen coordinates, which would have it grow by the scaling factor each time.
Fix: Add a function upstream in Revery to get the window size in screen coordinates and persist that instead.

I'm still getting a growing window on Windows 10 with the current build from the portal (https://github.com/onivim/oni2/commit/fa0d3d691938bcc8c6dba79f44f5559634b7cd8c). Perhaps the fix was only Linux specific?

As far as I can see, the the "raw" size and the size used in this PR are the same?
The raw size uses w.metrics.size.width which is set in _getMetricsFromGlfwWindow, which in turn calls Sdl2.Window.getSize, which is what the new method uses.
The docs for that SDL2 call implies we need to use something else: https://wiki.libsdl.org/SDL_GetWindowSize, so do we need to hook up and use GetRendererOutputSize?

Thanks for looking into this, @CrossR !
I suspect there's a case with scaling not handled properly - either via GDK_SCALE or on a high-dpi windows display. Does your Windows 10 machine have display scaling?

Yeah, its a 4K monitor with 150% scaling, so could be scaling or high-DPI issues.

Cool, thanks @CrossR - I'm able to reproduce this on a Windows 10 device with scaling, and also on Linux with GDK_SCALE set

I don't have a high-DPI monitor, so I'm pretty much just stabbing in the dark.
I can't see how something like GetRendererOutputSize would work though, as that returns pixel size. Assuming this still follows the conventional definition of pixel, as a representation of physical coordinates, there should be more pixels per "screen coordinate" with a high-DPI and/or a scale factor above 1.0. And since the problem is that the window grows, not shrinks, the problem seems to be that we're getting pixels and/or unscaled coordinates.
Could you run some tests with the reason-sdl2 example @CrossR so we can really figure out the relation between these coordinates?

I can help with this @glennsl - I have setups to test on both Linux/Windows.
I think the main problem is inconsistency in the Revery Window API in talking about sizes - there are two window sizes that SDL gives us - the 'screen space' size, and the 'framebuffer' size. On top of that, we also account for display scaling (like frameworks like Electron handle). So that makes three 'spaces' for window sizes:

Framebuffer pixel size

Screen space size

Screen space size, with display scaling

The problem was, the API surface wasn't consistent in handling this - create, getSize, and setSize should all be consistent in the space they use - which they weren't. create would use coordinates in the 'display scaled' space (3), but getSize/getRawSize would get the dimensions in (2) - likewise with setSize.
I opened https://github.com/revery-ui/revery/pull/840 to try and clean up that API and clarify this... hopefully it helps.


ISPN-15123 Ability to see which entries are evicted by log messages (…

…trace)
https://issues.redhat.com/browse/ISPN-15123

Integrated, thanks @wburns


Add support to extract LE Ints in BinaryDecoder

Summary: This PR adds a function to the BinaryDecoder class to extract little endian encoded integers from the buffer and renames the existing ExtractInt function to ExtractBEInt to make naming reflect the type of integer. There are several protocol parsing implementations, MongoDB included, which are little endian encoded but have been directly using its relevant functions within utils namespace. Adding this to BinaryDecoder would make it consistent with the existing extract integer functions that deals with big endian encoded integers.
Ran git grep ExtractInt | cut -d : -f1 | uniq | xargs -I{} sed -i 's/ExtractInt(/ExtractBEInt(/g' {} and git grep ExtractInt | cut -d : -f1 | uniq | xargs -I{} sed -i 's/ExtractInt</ExtractBEInt</g' {} to make the naming changes and reran AMQP's code generation to verify changes were done right.
Related issues: #640
Type of change: /kind feature
Test Plan: bazel build //... and bazel test //...

@kpattaswamy can you update the PR title to reflect that this also renames the existing ExtractInt function? I know the name is already long, but I think it's best to include both if possible.


Run fix for GUIDs, IDIRs & schedules missing on submissions to BI API services and ODS

PDP Devs were able to recover both GUID, IDIR, and Schedule from KeyCloak and provided TES BI with a data file
TES BI successfully uploaded the data file to the data warehouse in production
The self-service report on HR Analytics that SHR uses now reflects the updated/corrected data
Records for forms that were created prior to the fixes being implemented will still come in with null values
We should expect to see entries with null values trickle in until all forms created prior to the fixes being implemented have either been submitted or deleted
This process will need to be repeated to iteratively correct these records after they trickle in
There are already a few records in the DWH with null values
To repeat this process, someone on the PDP team will need to generate updated data files and provide those to TES BI
This will need to be repeated until all draft forms created prior to the fixes are submitted or deleted - 60 days

To test after 60 days (since Nov 8 problem began) - We will fit in this work in January as we see fit. Not critical

@iman-jamali-fw
Do we want to re-run this again this week for the missing GUID/IDIR and schedule information?

@T854236
Sure, I can try later this week if that sounds good to you.

There are currently 1400 new Telework Agreements that have null values reporting to the data warehouse that need to be corrected. Please run fix again this week when time allows and does not conflict with prep work for 1.10 user testing that's planned.

@Abuchana @iman-jamali-fw
New file loaded here: https://bcgov.sharepoint.com/:x:/r/teams/03991/Shared Documents/Data Collection/Telework_submissions_with_missing_GUID_Jan6_2023.xlsx?d=wb72d91f563394fc7a3435f27fe52185e&csf=1&web=1&e=0ghtIp

@T854236, thank you!!!

@T854236
I send you an email containing the missing IDIR, GUID, and schedule data of the users you shared with me earlier. Hope this helps to fill the missing data :)

@T854236
I just learned (while wokring on #847) that some of the IDIRs I added to the that excel file (shared on sharepoint), don't have @idir at the end.
Context: Some of the users's idir attributes we get when a user login with IDIR do not have @idir postfix, which is why Simen added a function to Keycloak to add that in case a user's IDIR don't have @idir. Since I extracted the IDIRs from Keycloak database, some of them don't have @idir.
Is it going to be an issue on ODS side? I so, we need to add that postfix to the users without @idir.

@iman-jamali-fw
It's ok, I can run a script to add if missing.

@iman-jamali-fw
Yes thanks, I can make the change.  As an fyi, we also do URL encoding on the file.
Can you confirm what ID you are using to match lookup in the app?  The Excel spreadsheet has a column called application id that is higher than 25k, the file that you send with the schedule information is with appication_id >13k.  There is database table id that lines up to it and I wanted to confirm if the information you provided really is application_id or app_telework_info_id which is from ODS.
The reason I ask as when I merge data, it is joining value with some schedule that I don't expect to see.  For example, if the records had the NoFormalSchedule with a value of 1, I don't expect to see a schedule.

@T854236
Oh no! I was using app_telework_info_history_id as the applicationId 😢

@T854236
I resent the missing values with the correct applicationIds (in an email). Could you verify if those data are correct and can be saved to ODS? Thank you

@iman-jamali-fw
Data was loaded successfully into PROD on January 19th in the evening.  We don't see any other records with missing gui/idir by applicationid in ODS.

@iman-jamali-fw and @T854236, Sarah is reporting more null values for the Telework Agreement. Can you have a look and let us know how we can remedy this?
Thanks! Alison
I still see:
•	16 records with uncorrected NULL schedule when NoFormalSchedule is 0
•	One record with uncorrected null GUID/IDIR
For reference, the queries I use to test this are below:
--ApplicationID record with Max DWCreated has null schedule (where NoFormalSchedule is also 0)
SELECT [app_telework_info_history_id]
,[guid]
,[idir]
,[remote_date]
,[ThreeOrMoreDays]
,[admOrDelegateNameOpt]
,[fileNamesCSV]
,[NoFormalSchedule]
,[agreementBetweenMinistry]
,[manager_guid]
,[manager_idir]
,[managersSignatureTimestamp]
,[employeesCommentsOptional]
,[duties]
,[noteOptional]
,[action]
,[schedule]
,[signed_date]
,[applicationStatus]
,[address1]
,[city]
,[postal]
,[numberOfDaysTeleworkingInAWeek]
,[employeeSignatureTimestamp]
,[read]
,[acknowledged]
,[applicationId]
,[date_created]
,[DwEMPLID]
,[DwEMPL_RCD]
,[DwDEPTID]
,[DwManagerEmplID]
,[DwDaysInOffice]
,[DWCreated]
FROM [Datamart_TeleWork].[Telework].[app_telework_info_history] AS A
WHERE
DWCreated = (SELECT MAX (B.DWCreated) FROM [Datamart_TeleWork].[Telework].[app_telework_info_history] AS B
WHERE A.applicationId = B.applicationId)
AND [schedule] IS NULL
AND [NoFormalSchedule] = 0;
--ApplicationID record with Max DWCreated has NULL IDIR or GUID
SELECT [app_telework_info_history_id]
,[guid]
,[idir]
,[remote_date]
,[ThreeOrMoreDays]
,[admOrDelegateNameOpt]
,[fileNamesCSV]
,[NoFormalSchedule]
,[agreementBetweenMinistry]
,[manager_guid]
,[manager_idir]
,[managersSignatureTimestamp]
,[employeesCommentsOptional]
,[duties]
,[noteOptional]
,[action]
,[schedule]
,[signed_date]
,[applicationStatus]
,[address1]
,[city]
,[postal]
,[numberOfDaysTeleworkingInAWeek]
,[employeeSignatureTimestamp]
,[read]
,[acknowledged]
,[applicationId]
,[date_created]
,[DwEMPLID]
,[DwEMPL_RCD]
,[DwDEPTID]
,[DwManagerEmplID]
,[DwDaysInOffice]
,[DWCreated]
FROM [Datamart_TeleWork].[Telework].[app_telework_info_history] AS A
WHERE
DWCreated = (SELECT MAX (B.DWCreated) FROM [Datamart_TeleWork].[Telework].[app_telework_info_history] AS B
WHERE A.applicationId = B.applicationId)
AND ([IDIR] IS NULL OR [GUID] IS NULL);
Thanks,
Sarah
Sarah Miles, Workforce Intelligence Analyst

@T854236
Could you provide the list of these affected submissions? :)

@iman-jamali-fw
Loaded a new file, 17 records total.
https://bcgov.sharepoint.com/:x:/r/teams/03991/Shared Documents/Data Collection/[Telework_submissions_with_missing_schedule_or_guid_Feb8_2023.csv](https://bcgov.sharepoint.com/:x:/r/teams/03991/Shared Documents/Data Collection/Telework_submissions_with_missing_schedule_or_guid_Feb8_2023.csv?d=w021856bc0bb640fa94b7fc39edf01ed7&csf=1&web=1&e=kiaRNG)?d=w021856bc0bb640fa94b7fc39edf01ed7&csf=1&web=1&e=kiaRNG

@bhumin-fw  could you take a look at this and comment on the necessity of doing this work?


CreepCargo can now be inspected...

Hi Nicholas,
Since CreepCargo can be browsed as StrMap Int, I marked it as such. It is thus not entirely opaque type.

Given that you do not answer my queries, I went forward and created a new package: purescript-screeps-classy, that contains updated API. That includes many type classes, and PathFinder API.


Update exception ORM entity with fID constraint

During the update from 8.1.0 to 8.4.0 I get the following error:
An exception occurred while executing 'delete from Files where fID = ?' with params [1]:

SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`my_website`.`atZlPicture`, CONSTRAINT `FK_214D0A81E3111F45` FOREIGN KEY (`fID`) REFERENCES `Files` (`fID`))

The problem occurs because of an older Concrete bug (Files without FileVersions) mentioned in the migration: Version20170610000000.php and the migration not taking in account that 3parties can create a constraint.
In my case I have an ORM entity that creates a constraint.
/**
 * @ORM\Entity
 * @ORM\Table(name="atZlPicture")
 */
class ZlPictureValue extends AbstractValue implements FileProviderInterface
{
    /**
     * @ORM\ManyToOne(targetEntity="\Concrete\Core\Entity\File\File")
     * @ORM\JoinColumn(name="fID", referencedColumnName="fID")
     */
    protected $fID;

The same error occurs when I try to delete the specific file via the File Manager.
The Type is displayed as unknown and the other details are missing.

@rikzuiderlicht concrete5 can't understand every 3rd party package: it's your code that should take care of it.
You have 2 options:

subscribe to the on_file_delete event and delete your data when it occurs
let the database delete the records.

Point 2 can be implemented simply by changing your code to:
/**
 * @ORM\ManyToOne(targetEntity="\Concrete\Core\Entity\File\File")
 * @ORM\JoinColumn(name="fID", referencedColumnName="fID", onDelete="CASCADE")
 */
protected $fID;

@mlocati thank you for the response. We will implement this.
I believe the ticket can be closed


There is a bug due to It is not possible to move the figure from the bottom line

I have done a change that may solve the problem in the Telegram client on android, but i can't check the solution because i can't install the repository.
When I play chess, then I will record a video with this bug.

Will try =)


cross OS fails for trivial reason

Cache generated from windows:
Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           8/16/2023  7:26 PM            206 cache.tzst
-a---           8/16/2023  7:26 PM             15 manifest.txt

Cache generated from linux:
Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a---           8/16/2023  7:07 PM            229 cache.tgz
-a---           8/16/2023  7:07 PM             15 manifest.txt

The problem is that windows runner has zstd installed, and linux runner does not.
It should give a warning that the cache folder was found, but incompatible file was found.
Alternatively, add setting to force compression to gzip


Column Sorting

Add the ability to choose how tasks in columns are sorted.  Preferebly done via a dropdown menu, as per on the file explorer.  For now, the intent it to use only fields currently understood by CardBoard, so:

file name (and line number in the file)
task title
due date
completion timestamp (only make sense for completed column really)

Priority (as used in Tasks plugin) is an obvious addition to this, but I will need to add support for parsing/uderstanding these first - so will tackle this later (track in #153).  Ditto for other date types supported by Tasks (track in #94, #203).

see #15 -> if sorting by due date, then place dated tasks above undated ones.


Add aks cluster extension feature azurerm_kubernetes_cluster_extension

Description of your changes
Added the resource azurerm_kubernetes_cluster_extension which is already present in the underlying terraform release but was not made available through the provider.
Fixes #731
I have:

[X] Read and followed Crossplane's contribution process.
[X] Run make reviewable to ensure this PR is ready for review.
[X] Successful make e2e uptests. Multiple manual tests
[N/A] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make e2e uptest succeeded
Manual Test according to the process ran through.

/test-examples="examples/containerservice/v1beta1/kubernetesclusterextension.yaml"


Update gradle to a newer version (4.3) with kotlin DSL for gradle

Gradle has evolved quite a bit since this project got started. We now have kotlin as a first class language to write the configuration (yay strong types).
Also bump the version of kotlin, dokka and other dependencies.

@npryce-springer, any thoughts on merging this?


Users' scores get cleared and show up as NaN, no errors in console

The best course of action would be to detect if a score is "NaN" and report as much info in console as possible. This should be done ASAP as a patch.
After reviewing game data from a game where this bug occurred, I am unable to find any indicators of a cause. Will continue to check logs and document occurrences of this issue, however it appears to be extremely rare.

No reported cases in over a year. Closing unless any further reports arise. See also:
https://trello.com/c/wemma31b/85-game-handler-rewrite


[Improvement] Enable DPI access to memories (and more?) in emitted Verilog

One common usage case is that you may like to have an arbitrary memory or some signals capable of being loaded or dumped from a top-level testbench. While this can naturally be done directly by writing a Verilog testbench yourself (with possible modifications to emitted Verilog), this seems like a candidate for inclusion in Verilog generation.
I have not had a chance to examine how the annotations work, but it seems like they would be suitable here, e.g., "I label a memory as loadable or dumpable" and this will emit the necessary VPI/DPI boilerplate that makes this available at the top level via some simple loadmem_<name>(const char * file) or dumpmem_<name>(const char * file) functions.
Has this been brought up before?
Some related discussion on the Chisel mailing list: https://groups.google.com/forum/#!topic/chisel-users/ASj73vW5QZI

Fixed by the binding stuff


README.md: Add MacPorts to install section

Closing for now, feel free to open a new one with valid name (if exists).


how to use tfrecord data(dict format) (tf.data.dataset) in distribute training?

Click to expand!
Issue Type
Performance
Source
source
Tensorflow Version
tf2.2.0
Custom Code
Yes
OS Platform and Distribution
No response
Mobile device
No response
Python version
3.7
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
I tried to use both mirror and multimirror in distributed training, and i found the input data (from all doucements like tf official tutorial,github and so on )to the strategy.run() must be like ((None,256,256,64)(None)), while the batched data from the fnction below "def make_dataset_for_distribute_train(self, all_paths):" is a dict.  strategy.run() cannot accept dict data for distributed training , so i had to transform it(the output of "make_dataset_for_distribute_train" function) before the distributed training using the
function "def parse_dict2_turple(self,data_tensor" below.
It worked, but the cpu useage is above 300%(before is 200%）and gpu_utils_average is just 10%(before is 75% one gpu). As a result, the distributed training with 4 gpus even slower than normal training.
Can someone tell me why and how to fix it? really appreciate for your help!!!

Standalone code to reproduce the issue
def make_dataset_for_distribute_train(self, all_paths):
   dataset = tf.data.TFRecordDataset(all_paths)
   dataset = dataset.map(self.parser, num_parallel_calls=tf.data.experimental.AUTOTUNE)
   dataset = dataset.map(self.make_feed_dict,num_parallel_calls=tf.data.experimental.AUTOTUNE)
   padding_dict = {"a": [20], "b": [None], "c": [30],"d": [13]}

   dataset_for_train = dataset.padded_batch(self.batch_size, padded_shapes=padding_dict,
                                                 drop_remainder=True).prefetch(
            buffer_size=tf.data.experimental.AUTOTUNE)
   return dataset_for_train

def parse_dict2_turple(self,data_tensor):

        d0 = data_tensor['a']
        d1 = data_tensor['b']
        d2 = data_tensor['c']
        d3 = data_tensor['d']

        return tf.data.Dataset.from_tensor_slices((d0, d1, d2, d3))

        def distributed_train_step(inputs):

            @tf.function
            def distributed_train_step_wrapped(ds):
                loss=0.0
                for k in ds:
                    # tf.print(k)
                    per_replica_average_loss = strategy.run(train_step, args=(k,))
                    loss += strategy.reduce(tf.distribute.ReduceOp.SUM, per_replica_average_loss, axis=None)

                return loss
            return distributed_train_step_wrapped(inputs)
            for i in date:
                all_paths = self.parse_input_path(i, epoch)
                logger.info(all_paths)
                dataset = self.make_dataset_for_distribute_train(all_paths)

                total_loss = 0.0
                num_train_batches = 0
                for j in dataset:

                    dataset_parsed = self.parse_dict2_turple(j)
                    dataset_parsed = dataset_parsed.with_options(options)
                    train_dataset_distribute = strategy.experimental_distribute_dataset(dataset_parsed)
                    batch_loss = distributed_train_step(train_dataset_distribute)
                    num_train_batches += 1
                    total_loss += batch_loss

Relevant log output
No response

def make_dataset_for_distribute_train(self, all_paths):
dataset = tf.data.TFRecordDataset(all_paths)
dataset = dataset.map(self.parser, num_parallel_calls=tf.data.experimental.AUTOTUNE)
dataset = dataset.map(self.make_feed_dict,num_parallel_calls=tf.data.experimental.AUTOTUNE)
padding_dict = {"a": [20], "b": [None], "c": [30],"d": [13]}
dataset_for_train = dataset.padded_batch(self.batch_size, padded_shapes=padding_dict,
drop_remainder=True).prefetch(
buffer_size=tf.data.experimental.AUTOTUNE)
return dataset_for_train
def parse_dict2_turple(self,data_tensor):
    d0 = data_tensor['a']
    d1 = data_tensor['b']
    d2 = data_tensor['c']
    d3 = data_tensor['d']

    return tf.data.Dataset.from_tensor_slices((d0, d1, d2, d3))

def distributed_train_step(inputs):
@tf.function
def distributed_train_step_wrapped(ds):
    loss=0.0
    for k in ds:
        # tf.print(k)
        per_replica_average_loss = strategy.run(train_step, args=(k,))
        loss += strategy.reduce(tf.distribute.ReduceOp.SUM, per_replica_average_loss, axis=None)

    return loss
return distributed_train_step_wrapped(inputs)
for i in date:
    all_paths = self.parse_input_path(i, epoch)
    logger.info(all_paths)
    dataset = self.make_dataset_for_distribute_train(all_paths)

    total_loss = 0.0
    num_train_batches = 0
    for j in dataset:

        dataset_parsed = self.parse_dict2_turple(j)
        dataset_parsed = dataset_parsed.with_options(options)
        train_dataset_distribute = strategy.experimental_distribute_dataset(dataset_parsed)
        batch_loss = distributed_train_step(train_dataset_distribute)
        num_train_batches += 1
        total_loss += batch_loss

Aligned code is like this

@wannianlou,
To reproduce the issue reported here, could you please provide the complete code and the dataset you are using.
Also TensorFlow v2.2 is not actively supported. Could you please update TensorFlow to the latest stable version v2.9 and check if you are facing the same issue. Thank you!


Connection Refused: bad user name or password

Environment

OS: CentOS Linux release 7.3.1611 (Core)
Erlang/OTP: R20/9.0
EMQ: 2.3.9

Description

Using haproxy as load balancing
Use haproxy to offload tls's certificate
Client: ./mosquitto_pub -h 10.xx.xx.xx -p 8883 -t lw1 -m hello  -r --cafile /tmp/cacert.pem -d --insecure
Continue to subscribe several times, sometimes successful, sometimes failed: bad user name or password
Client mosqpub|30207-k5298v.ad sending CONNECT
Client mosqpub|30207-k5298v.ad received CONNACK (4)
Connection Refused: bad user name or password.
Error: The connection was refused.

Hi, would you set the log level to 'debug' and check the logs?


ci: fix gh-release

Currently CI for the gh-release has been erroring with:
Error: Error 422: Validation Failed: {"resource":"Release","code":"custom","field":"body","message":"body is too long (maximum is 125000 characters)"}

What we're doing now is using mikepenz/release-changelog-builder-action
to build the changelog.
Closes #2147.

I think that just disabling the release notes isn't in the spirit of the issue. Ideally we could actually produce release notes without needing to manually do it.

I'll dig into alternatives.

Ok I've found a workaround and updated the PR/Commit description.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.068%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19386

Relevant Lines:
23060

💛  - Coveralls

Correct me if I'm wrong but this is going to include every PR since the last release. As someone that does a lot of PRs that don't need mentioning, I think that is way too noisy. (FTR I didn't read the new action README because its massive)
This PR conflicts with the mkchlog work @Kixunil is doing in #2141 - what is the status on that?

This PR conflicts with the mkchlog work @Kixunil is doing in #2141 - what is the status on that?

I don't think so, it touches different files and #2141 only activates on pushes and pull requests, while here only activate on a new tag.

Correct me if I'm wrong but this is going to include every PR since the last release.

We can also add a filter that only captures features (and fixes, if necessary) to the release body message

@storopoli it conflicts conceptually, not as git conflict. mkchlog would just do the right thing.
@tcharding the status is that I wasn't able to review those things for a while.  But if we're lucky I can look into it in a week or so.


expanding and collapsing of folders in explorer is no longer available with the arrow icon

VSCode Version: 1.31.0
OS Version: Win 10 64-bit

Ever since my update of VSCode to version 1.31.0, expanding and collapsing of folders in the Explorer pane is no longer available by clicking the little arrow icon! Only by double clicking the folder itself, it can be expanded and collpased.
In all the previous versions of VSCode I've worked with, the expansion and collapse actions was done by simply clicking the arrow icon next to the folder, exactly like it works in all standard systems, where there is a tree of folders and files.
If this is a bug, it should be fixed ASAP of course, and this is a feature by design, then it's a very wrong and un-standard decision, in my opinion. Is such a case, the user should be able to control that via the Settings, at least...

This works for me:

@kobibentata Do you have workbench.list.openMode set to doubleClick, by any chance?

I was not aware that on doubleClick mode, the folder should still expand when clicking the twistie. cc @bpasero

I also have this problem on VSCode 1.31 on Windows 10 x64. I have always had "workbench.list.openMode": "doubleClick" and single-clicking those small arrow icons should expand/collapse on any previous version.

@joaomoreno - if I understand correctly, you submitted the code that fixes this issue and now you're just waiting for a pull request on it, in order to get it included in the next version release??...

@kobibentata Yes, we are considering including it in a recovery release coming soon.

Was just about to make my own issue for this, hope a new release is out soon.
In my case it's annoying me while debugging, because double click ALSO edits variables, so i have to deal with that every time i want to expand a value.

I have v1.31.0  and it's broken on my side as well.
According to this: https://github.com/Microsoft/vscode/issues/42621
I thought it's fixed, but no - it's not.
the "twistie" (or "arrow" next to the folder name) still requires doubleClick to expand / collapse in "double click mode", which is wrong and so "non user friendly".

No this is a new bug introduced in version 1.31.0, the fix maybe released in January Recovery 2019 (maybe version 1.31.1) or February 2019.
Track the progress of January Recovery 2019 here.


Remixicon in a real project

I've been looking for a free icon pack a very long time that matches my requirements and finally I've found it.
My requirements was

Free for commercial use
Common icons in the pack
"+file" and "+folder" icons. In other packages there was "+file" OR "+folder", never both.

As a little thank you, I'll give you a screenshot of my unfinished project, so you can see how the icons can be used. It's soon a markdown editor for PHP.

The icons looks great for most part. The filetree is using 18px icons so in that case it gets a bit blurry (especially the text file icon). That however is not your fault, because you are using a 24px grid which makes the topbar in my case look awesome.
At the moment I can't make a donation (hopefully in the future), but I will gladly put a link to your icons in my readme.
Thanks!

First of all, thank you very much (from my heart) for using our icons in your project and taking time to provide feedback.

As you know, Remix Icon is a side project of us. Wendy and I spare time to maintain it. We can't provide multi-size icons (such as 18px, 20px) for now which takes a lot of time.

Feel free to use it, a donation is not required, it's only a way to show your love. We are very grateful to your star in GitHub.

You are the first one who opens issues in Github. To express my gratitude, I have redesigned folder icon and file icon with an 18px grid for your usage, they may look better~

5.Little advice:
(1) It'll be more clear to show the state of folder by adding a "+ -" or a little arrow in front of your folder icon.
(2) Better not use #000000 color of icons and fonts, too much strong contrast.

I completely understand that. You can't do an icon pack for every pixel size. 24px is however a very good size to work with.

Fantastic! I'm very grateful! And yes, it looks awesome!

I will also need 18px of an image, refresh, plus, minus icons, but to not take your time, I can probably create them myself, I think,
I also took your advice of making the icons less black, just like yours with #333. Plus minus signs not yet implemented
I've recommended Remixicon to be included into Kirby CMS - Kosmos. Not sure how it goes, but it would be a nice addition. You deserve 2000 stars, not 63.

Thanks again~
Here's the image and refresh icon~

Plus and minus icon are easy to create with div+css,
and you can also build it with SVG XML, it will be an interesting experience by drawing an icon with code, I think.

 Thanks!
Yes, there are even pure css icon packs out there, like this one: https://saeedalipoor.github.io/icono/
If you want I can let you know when my project is released.

I'd like to know when your project is released.
Some icons in your free-icon-packs repo can give us inspirations to helps us improve our product, thanks~
By the way, the icon version on GitHub is newer than that on our website.
such as social and brands icons: https://github.com/Remix-Design/remixicon/tree/master/icons/Logos

My Markdown editor project has not yet been released, it needs more testing. However it's built apon my own filetree library, which is released and now also uses your 18px version of Remixcon.
https://github.com/jenstornell/staircase.js#libraries-used

Good work~ Keep！

One piece of the puzzle of my (still unreleased) Markdown editor, is a login screen. I created a new repo of that to keep it separated.
https://github.com/jenstornell/wall
Once again your icons really shines! 👍

Finally it has been released. I have used it a while myself to write content, but my guess is that I need more documentation.
https://github.com/jenstornell/cursor

Nice work man~
I think it will be better if there was a live preview demo website for visitors.


Proposal: builder: add include

I suggest adding include syntax (as Golang text/template function)
Example usecase
before (https://github.com/linuxkit/linuxkit/blob/master/examples/sshd.yml):
files:
  - path: root/.ssh/authorized_keys
    contents: '#your ssh key here'

after:
files:
  - path: root/.ssh/authorized_keys
    contents: {{include ~/.ssh/id_rsa.pub}}

Path resolution

Absolute path (including one starts with ~/): resolved to the file specified by the absolute path. Maybe woth adding moby build --disallow-include-absolute-path for security reason
Relative path starts with ./ (or .\ on Windows): resolved to the file specified by the relative path
Others (e.g. foo.yaml.snippet, foo/bar.yaml.snippet): resolved to one of the files under the following paths: ~/.moby/include, /usr/local/share/moby/include...

Not sure how useful this is yet; the ssh example is mainly as metadata providers not set up properly yet for passing ssh keys for all platforms, but this is in progress.
There definitely are use cases for templating but maybe it should be a standalone tool. We should defintiely accept yaml from stdin so you can pipe a templated version to build.

sure, opened https://github.com/moby/tool/pull/6 for supporting stdin


[V2] Color of menu arrow in dark mode

🐛 Bug Report
This is a TINY bug. The color of the menu link arrows in dark mode is black.
Have you read the Contributing Guidelines on issues?
Yes
Screenshot

Expected behavior
The colour should be the same as if it was in light mode.
Actual behavior
This is caused because of the black background and the transparency in the arrow svg fill (rgba(0,0,0,0.5))
.menu .menu__link.menu__link--sublist:after {
    background-image: url('data:image/svg+xml;utf8,<svg alt="Arrow" xmlns="http://www.w3.org/2000/svg" width="16px" height="16px" viewBox="0 0 24 24"><path fill="rgba(0,0,0,0.5)" d="M7.41 15.41L12 10.83l4.59 4.58L18 14l-6-6-6 6z"></path></svg>);
    background-size: 2rem 2rem;
    background-position: 50%;
    content: " ";
    display: inline-block;
    height: 1.25rem;
    width: 1.25rem;
}

Possible solution
Instead of using an rgba value use an explicit rgb value (e.g. #8a8a8a or rgb(138, 138, 138))

Its one of our dependency (currently still closed source) bug. But we will fix it there


system instability after updating systems

Describe the bug
I updated 6 system to the latest staging commit to get openssl 1.1.1i yesterday.
Shortly after that these systems started being reported as down by monitoring every few hours. I could ssh into them but the systemd process wouldn't respond ("reboot" or "systemctl" didn't work for example). See the logs below.
I then downgraded again to latest master today, but the same thing kept happening on all 6 servers.
This is the hardware. It's all rented from Hetzner Online.
2x Intel(R) Core(TM) i7-8700 CPU / MSI Z370 GAMING PLUS
4x Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz / Gigabyte B360 HD3P-LM
To Reproduce
Steps to reproduce the behavior:
I am not sure if this can be reproduced reliably. If you rent a server with i7-8700 or i9-9900K from Hetzner try upgrading your system to latest master and see what happens.
Expected behavior
The system should not crash.
Screenshots
[ 1991.670981] show_signal_msg: 39 callbacks suppressed
[ 1991.670983] type1[13843]: segfault at fffffffffffffffe ip<PHONE_NUMBER>401625 sp 00007fffffffa8f0 error 5 in type1[401000+2000]
[ 1991.670987] Code: fa ff ff 48 c7 05 2f 3a 00 00 00 00 00 00 eb dd 0f 1f 44 00 00 48 63 05 2d 3a 00 00 48 8b 15 2a 3a 00 00 41 54 55 48 89 fd 53 <80> 7c 02 fe 0d 49 89 c4 75 0e 41 83 ec 01 44 89 25 0a 3a 00 00 49
[ 1991.758554] type1[13854]: segfault at fffffffffffffffe ip<PHONE_NUMBER>401625 sp 00007fffffffa8f0 error 5 in type1[401000+2000]
[ 1991.758558] Code: fa ff ff 48 c7 05 2f 3a 00 00 00 00 00 00 eb dd 0f 1f 44 00 00 48 63 05 2d 3a 00 00 48 8b 15 2a 3a 00 00 41 54 55 48 89 fd 53 <80> 7c 02 fe 0d 49 89 c4 75 0e 41 83 ec 01 44 89 25 0a 3a 00 00 49

[  574.515888] show_signal: 37 callbacks suppressed
[  574.515891] traps: gjs-console[22290] trap int3 ip:7ffff7de3bf5 sp:7fffffff2730 error:0 in libglib-2.0.so.0.6600.3[7ffff7da9000+85000]
[  575.103587] traps: gjs-console[22936] trap int3 ip:7ffff7de3bf5 sp:7fffffff2980 error:0 in libglib-2.0.so.0.6600.3[7ffff7da9000+85000]
[  575.186718] traps: gjs-console[22966] trap int3 ip:7ffff7de3bf5 sp:7fffffff2710 error:0 in libglib-2.0.so.0.6600.3[7ffff7da9000+85000]
[ 2063.395936] traps: systemd[1] general protection fault ip:557329718d71 sp:7ffe90d66100 error:0 in systemd[557329694000+cf000]

[mil@build-worker-04:~]$ systemctl
Failed to list units: Failed to activate service 'org.freedesktop.systemd1': timed out (service_start_timeout=25000ms)

[mil@build-worker-04:~]$

Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.9.14, NixOS, 21.03pre-git (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.9`
 - nixpkgs: `/etc/src/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- systemd
- glib
# a list of nixos modules affected by the problem
module:

sounds like a broken user session.. did you try restarting (running reboot as root should work)?

sounds like a broken user session.. did you try restarting (running reboot as root should work)?

Yes. The Nix segfault was reproducable across session across systems. Running reboot as root user did not work because the system init process was not responding.

I'm seeing this as well.
[ 3715.876557] systemd[1]: segfault at 7f4ade96ff70 ip 00007f4ade96ff70 sp 00007ffd8063df58 error 15 in libc-2.32.so[7f4ade96f000+2000]
[ 3715.876712] Code: 00 00 30 ff 96 de 4a 7f 00 00 30 84 1d b2 53 56 00 00 70 95 1d b2 53 56 00 00 50 ff 96 de 4a 7f 00 00 50 ff 96 de 4a 7f 00 00 <80> b5 22 b2 53 56 00 00 80 b5 22 b2 53 56 00 00 70 ff 96 de 4a 7f

Reboot only works with systemctl reboot --force --force.

I have the coredump I can give to someone if that would help. (Not posting publicly since I have no idea what is in there.)

Could it be this issue: https://github.com/systemd/systemd/issues/17768? The backtraces in there seem similar to me.

Thanks a lot for discovering what is probably the cause and fixing it! I will close this issue for now unless this keeps happening with systemd 247.1.

Is there a workaround until this hits nixos-unstable? I'm running into this issue on multiple servers and it's causing quite some trouble.
Any estimates on when this will be out of staging?

It's simple: don't update to latest master. systemd 247 never reached the nixos-unstable channel so if you are using that channel you should not see these issues in the first place.

nixos-unstable-small has systemd 247 (which is how I first ran into this issue). I did switch to the nixos-unstable channel temporarily to rollback to systemd 246.6.


request - add examples for PythonParse in jiter

Hi,
I am the author of Robyn(https://github.com/sparckles/Robyn/) , and I have been following jiter for a while. I saw a tweet of Samuel recently saying that jiter has achieved performance equivalent to orjson.
I would love to use it in Robyn if that is the case. Would it be possible to have some documentation of the PythonParse struct?
Thanks in advance.

Thanks for the interest @sansyrox. There's a nice example in python package here:
https://github.com/pydantic/jiter/blob/366d16a24c113d01d96c6a6676cdfb7f00fcdcdc/crates/jiter-python/src/lib.rs#L29-L38


Fixed crash when reusing nodes referring to symbols inaccessible after emit

fixes https://github.com/microsoft/TypeScript/issues/59600
I bisected the regression to https://github.com/microsoft/TypeScript/pull/58066 , cc @weswigham

I agree with your point. With those constraints... it becomes much harder to track the correct nodes that can't be reused. Not impossible but much harder. context is manipulated in many places and I don't have enough context (😉) on this part of the codebase, it would be rather easy for me to miss some nuance when working on the more correct node tracking.
That makes me question the solution I chose here - could this solution be replaced with something else? My initial idea was to tweak existingTypeNodeIsNotReferenceOrIsReferenceWithCompatibleTypeArgumentCount but I couldn't figure out a proper change there.


Add setting to make "dirty" mean the same thing as what "git describe" means

jgitver's definition of "dirty" (when <useDirty> is enabled) is different from git describe's definition of "dirty". In particular, jgitver and git describe disagree in the situation where the code is clean, but an unknown file exists.
Example:
$ git status
On branch maven
Your branch is up to date with 'repo/maven'.

nothing to commit, working tree clean
$ git describe --dirty=XXX
1.2.0-20-g1d3a0d77
$ touch foo
$ git status
On branch maven
Your branch is up to date with 'repo/maven'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	foo

nothing added to commit but untracked files present (use "git add" to track)
$ git describe --dirty=XXX
1.2.0-20-g1d3a0d77
$ mvn clean
[INFO] Using jgitver configuration file: /home/archie/pcom/.mvn/jgitver.config.xml
[INFO] Using jgitver-maven-plugin [1.5.1] (sha1: e45d1669b39cedb98720dd33cc14d0185b455ca1)
[INFO]     version '1.2.0-20-1d3a0d77-dirty' computed in 1197 ms

Following the principle of least astonishment, the version string calculated by jgitver in this example should be 1.2.0-20-1d3a0d77, not 1.2.0-20-1d3a0d77-dirty.
IMHO this is a bug, but for backward compatibility we should leave the current behavior alone, and add a new configuration setting to make "dirty" mean git describe's "dirty". For example, the new configuration setting could be called <dirtyIgnoreUnknownFiles>.
Originally filed as https://github.com/jgitver/jgitver-maven-plugin/issues/125

As I originally said in jgitver/jgitver-maven-plugin#125 I still maintain that current computation of jgitver dirty state is better in regard of safely build artifacts.
If we were adding a new configuration flag to handle your need I'll call it something like <dirtyIgnoreUntrackedFiles>.


Further Shader HLSL Refactor

Continues on from #414 #434

Remove duplicate functions so both OceanLODData and OceanHelpersNew can be included together without conflicts.
Use the new PosToSliceIndices with fixes.
Brought over nearly all of the whitespace formatting changes from HDRP branch.
Using the CREST_ prefix for the internal shader keywords (I could use the _INTERNAL postfix?)

Thanks @daleeidd! Great that you went so deep on unifying things.
I think postfix might be a good shout, yes.
With that could you please give an overview of the approach with keywords - which ones we have (not every single keyword, maybe just the foam ones as an example) and which are switched on by code vs user on material. Would be good as a refresher and also for longer term documentation.

I had a look and there is only two keywords we enable using scripts which are the CREST_FLOW_ON_INTERNAL and the CREST_DYNAMIC_WAVE_SIM_ON_INTERNAL in the ShapeCombine.shader.
The other keywords are either enabled on the materials or are enabled by the kernel selection which is done in C# (the kernel selection that is).
I have redone the commit to only rename the ones in the ShapeCombine.shader.

Ok, just to confirm theres no collision between user-enabled and code-enabled keywords? Like the case where flow was being forced on by code, but didnt work in standalone builds?
I don't there is but just 100% confirming.
With that then thumbs up from me for merging!

I just double checked. No conflicts anymore.
I also changed _DIRECT_TOWARDS_POINT to CREST_DIRECT_TOWARDS_POINT_INTERNAL since it is enabled with scripting.

Thanks! Merged


feat(firestore-stripe-payments): Add setup_future_usage parameter for one-time payment flows

Conditionally add the setup_future_usage parameter to Checkout Session/Payment Intent creation for one-time payment flows. This will enable saving payment details for future on/off-session usage during an initial payment.
Fixes #340.

I'm having trouble with the restricted keys, issue #339 specifically related to setting up a payment for future usage. The current readme/docs don't have the RK configured correctly to create a payment intent
https://github.com/stripe/stripe-firebase-extensions/issues/339


Try to get VirtualBox info without dmidecode

I found that the virtual fact said "physical" on my virtualbox machine because I had a minimal install.
This fix reads from /sys/devices/virtual/dmi/id/product_name and gets the value VirtualBox.
I'm sure it works on several other hypervisors but virtualbox is all I have to test on so I'm leaving it at that.

Hi Mikael,
Thanks for the submission :-). However can I kindly ask you to also raise a ticket in redmine:
http://projects.puppetlabs.com/projects/facter
And ensure you have signed the CLA? We'll need this before we can accept any contribution. Thanks!
ken.

I should probably have read from /sys/class/dmi/id instead ... I don't know sysfs well enough to know where would be the safest place to get the information though.

Better to discuss it using puppet-dev mailing list as you may get more feedback :-). These pull requests are transitory and not everyone is reading it. Like I said - raise a ticket as a starter for the issue.

http://projects.puppetlabs.com/issues/10232

I think this still needs tests added, so that we can validate the change works correctly.  @frimik, do you think you can write them, or do you need us to add them?  The former will get this merged sooner, for sure.

I have merged this by hand.


Allow services to register with Ocelot Cluster

I'm putting this here because I had a thought on the train. This potentially removes the need for consul providing the service locations. However fully understand sticking with consul as it is probably way better than my raft implementation and does a lot of other stuff!
Happy path
When raft finished allow services to register with Ocelot.
The service can call Ocelot's administration API with IdentityServer client auth workflow?
This Administration controller would fire a command to the Cluster leader to add a new service to the registry.
The registry is persisted to the cluster.
Ocelot looks at the registry for services it can call.

Outdated! The author doesn't care!


Update index.ts

Enhancements:
Comments: Added comments to explain what each part of the code does, making it easier for others to understand.
Formatting: Improved formatting by adding spaces and line breaks for better readability.
Try-Catch Block: Used a try-catch block to handle errors more cleanly and ensure that process.exit(1) is only called if there's an error.

We don't need comments, the code is self-explanatory
The semi colons are deliberately removed, you can invoke biome script to lint the code accordingly
try/catch are unnecessary, there's already and error handler


Patch operation returns SuccessStale instead of Success

Describe the bug
The state of remote data returned by patch() method of REST data services is SuccessStale when Success is expected.
This happens e.g. in submit() method of dso-edit-metadata.component.ts. When I add or change a metadata the subscription returns a RD object with the updated item as payload, but SucessStale as state:
https://github.com/DSpace/dspace-angular/blob/a57bcf0dc72c29667dfabe5910676ae181eb41d0/src/app/dso-shared/dso-edit-metadata/dso-edit-metadata.component.ts#L182-L186
To Reproduce
Either add a breakpoint at this.saving$.next(false); inside the subscription to submit() method or log the value of rd, then:

Login as administrator
Open any item
Choose "Administer" from context menu
Open "Metadata" tab
Edit any existing metadata or add a new one
Save
The  payload of the response contains the updated metadata, but rd.state is SuccessStale

Expected behavior
rd.state should be Success

I'm having difficulty understanding the description here. Could you link to the code where the issue exists?
This sounds loosely similar to #2349 , at least in that it impacts a similar area of code.  But, I'm not sure it's the same problem... it just sounds similar to me.  So it's possible it was a similar bug accidentally caused by cache redesign work in #961
Overall, it sounds like a bug.  I just don't understand enough about how/where this exists.
@artlowel : Pinging you in case your team is interested in this, just because it sounds like it might be similar to past work your team has done.

@tdonohue sorry, some lines were missing from the bug description, I fixed it and added the code reference
@hutattedonmyarm yes, the issues are related, but we need to understand, case by case, whether:

it is correct to have the SuccessStale state (and we would need to use hasSucceeded() instead of isSuccess() in order to consider a stale operation as successful)
the state should be Success and it is correct to consider a SuccessStale response as non successful

@davide-negretti absolutely! I mentioned the issue, because the ORCID settings page does use a PATCH request and will always return SuccessStale regardless if it is correct or not. Our workaround to prevent errornous error messages is just that: A workaround. I didn't look further into the issue if it might be a general issue with PATCH requests


[FLINK-28993][table-planner] Fix adjusting join cost for dpp query pattern error

What is the purpose of the change
Now, adjusting join cost for dpp query pattern[FLINK-28821] have two errors:

For these table which without table stats, we haven't  multiply by  the dynamicPartitionPruningFactor.

For method #DynamicPartitionPruningUtils$visitFactSide, we have not judge whether candiateFields contain partition keys.

Brief change log

For these table which without table stats, we also multiply by the dynamicPartitionPruningFactor.
Adding judgment for candiateFields.

Verifying this change

Need to add.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature?  no
If yes, how is the feature documented?  no

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure


Remove metrics, since they are presently non-functional.

issue write up regarding this incoming shortly.

LGTM, but let's let the tests pass first.

Feel free to merge once tests pass

BTW, could you update https://github.com/wepay/kafka-connect-bigquery/wiki/Connector-Configuration with the latest config changes?


fix(sample): reflect XRB symbol change on example

CoinMarketCap API still calls it XRB but some exchange APIs (notably Binance) call it NANO after the rebrand, so this makes the example settings file a bit easier to use

Thanks!


fix: use jx boot image

apparently we stopped building the jx-changelog image for some reason -- but boot contains changelog and it will be cached, so let's use that

/approve

/approve


Fps issue

Describe your bug here.
Basically if you don't touch the notes for a couple of seconds,the fps will drop from 60 to like 40 fps, it could be an issue with my phone but if you also have that problem,let me know and fix the bug if possible
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Neko, HashLink, or other build system
Did you edit anything in this build? If so, mention or summarize your changes.
No I didn't edit anything from this build, I just downloaded it

maybe is your phone set if not press it will reduce fps，my phone is 120 reduce to 60，Enable Mobile Developer mode to turn off restrictions


✨ LibSort

Port LibSort from solady as part of #7.

@raxhvl can you explain which parts of LibSort are benefits from new opcodes (mcopy,tstore,tload,push0,etc)?

I'm leaving this one on hold first. LibSort has miniscule amounts of copying.
I think DynamicBufferLib will benefit most from mcopy, as it is literally copying.

Actually, I'd prefer if there is a library called MemCopyLib instead of LibSort.
It will have functions for copying memory arrays and bytes.

Should I close (PR + Issue) for now?

Yes you can close both.


Add os3 as education

Official URL: https://www.uva.nl/
Official URL about the course: http://gss.uva.nl/content/masters/security-and-network-engineering/security-and-network-engineering.html
On that page it also shows that os3 is its branding name. You can find more information on the https://www.os3.nl/ website.

@darckbit I am sorry for a delay with processing your request. Pull request merged. Thank you!


GH-2677: Fix EH AckAfterHandle With Async Acks

Resolves https://github.com/spring-projects/spring-kafka/issues/2677
When an error handler handles an error (and ackAfterHandle is true), the ack bypassed the out of order commit logic, causing the consumer to be paused indefinitely, due to the missing ack.
cherry-pick to 2.9.x

... and cherry-picked to 2.9.x as https://github.com/spring-projects/spring-kafka/commit/8725b654e43f79704def2d073f6385e89297075a after minor conflict fixing.


Discussion of "groupping suffixes"

Originates from https://github.com/bids-standard/bep001/issues/71 but taken into a separate issue since largely orthogonal.  I am quoting here https://github.com/bids-standard/bep001/issues/71#issuecomment-534105973 by @tiborauer :

Modality-specific suffixes answer why rather than what

examples?

2. Grouping suffix helps tools to identify images belonging to an/a compound acquisition

how often it would be necessary (i.e. % of the use-cases)? As I have argued in a comment I think grouping might be less frequently used, and custom suffixes would render those files not usable by standard analysis pipelines (e.g. fmriprep).

Thank you for creating the separate thread. It is a good idea.

examples

bold, T1w, T2w, PD images can be acquired with several sequences. bold, for example, can be acquired with SE or GE. Structural images are often 'mixed-weighted', which is often overlooked. That is why our BEP describes them as "images with predominant ... constrast". https://github.com/bids-standard/bep001/blob/d07489f3801a3dd39947be6d6dc9bc55200bdc7b/src/04-modality-specific-files/01-magnetic-resonance-imaging-data.md#L175-L177 The point is these suffixes describes for what purpose these images have been acquired and how they are interpreted.

how often it would be necessary (i.e. % of the use-cases)?

I cannot give you any valid statistics. In contrary to the structural/anatomical images already included in the BIDS specs, quantitative mapping introduced by this BEP (e.g. MPM, MP2RAGE, MTR, MTS) requires post-processing. It means, & of the use-cases is very high among people interested in this BEP, but may be low among those people interested in only e.g. fMRI.

my 2 cents:
Actually, I see it exactly the other way around: the current anatomical suffices of BIDS describe why rather than what. There is no such things as "a T1-weighted image". What the suffix 'T1w' currently communicates is, in my view, something like "Look fella, this is an image where Gray Matter is hypo- and white matter is hyper-intense. CSF is mostly black. FSL and fmriprep can deal with this...". The latter being the why.
This is different from a MP2RAGE and/or T1-map with very precisely defined MR parameters. There you really describe what the image contains from a physics point-of-view.


Classic and cata fixes

810cfb965d9196ac9194a5ed96b01d01e2fe0814 doesn't seem to be effective in fixing the cata errors. The cata color picker frame does not seem to have been changed to match retail as that commit would suggest.
For some reason, both OpacityFrameSlider and OpacitySliderFrame exist on classic and cata, but OpacityFrameSlider is the correct one to use, so the order of preference is reversed.
This also fixes an order of operations issue causing the text displaying the selected alpha value to be incorrect.

Thank you!


404 status page when no found space in space details

@rafieltq for the 404 status page when no found space in space details, you can use the explorer space empty status

Originally posted by @itsalb3rt in https://github.com/Cowofi/cowofi/issues/2#issuecomment-1216121092

So i have to do the 404 page with that illustration, right?


Process MARC as updates and deletes

Splits marc files into updates and deletes folders.
Display updates and deletes for Marc files in download view
updates tags to call correct function for removing subfields
adds dataTables JS to Marc downloads page
Fixes bug where upload form skips first row (inferred as header)
Patches transmission tasks and archiving functions to use updates and deletes paths

@shelleydoljack are we good to merge this?