Tag 0.2.0 release

I want to feature freeze for the alpha release, preferably this week.

[x] Fix or at least work around missing indexes in docs #75
[x] Remove linked list emulation macros #84
[x] Document main in reader.py (related to #24)
[x] Copy edit pass for docs #87

No more tutorials or macros before release.

Once that's done, do the release process.

[ ] Ensure package builder (setup.py) is up to date, including version number and classifiers
[ ] tag and manually test build on test PyPI
[ ] Install from PyPI in a fresh environment
[ ] tag and release on PyPI

Once that's done, do the release process.

[ ] Ensure package builder (setup.py) is up to date, including version number and classifiers
[ ] tag and manually test build on test PyPI
[ ] Install from PyPI in a fresh environment
[ ] tag and release on PyPI

OMG why is Python packaging this difficult? Can't find good documentation. Setuptools doesn't include your files, then pip put files in the wrong places. Pre-release versions apparently no longer work with pip. You have to get everything 100% right on your first try. No grace period, no takebacks, no pre-releases. I can at least use test-pypi, but still, no pre-releases. I can't use the real versions. They keep changing the rules. PyPI renders emdashes as mojibake, and apparently requires images to be hosted elsewhere. Ugh.

OMG why is Python packaging this difficult? Can't find good documentation. Setuptools doesn't include your files, then pip put files in the wrong places. Pre-release versions apparently no longer work with pip. You have to get everything 100% right on your first try. No grace period, no takebacks, no pre-releases. I can at least use test-pypi, but still, no pre-releases. I can't use the real versions. They keep changing the rules. PyPI renders emdashes as mojibake, and apparently requires images to be hosted elsewhere. Ugh.

It is done.

It is done.


DevCon 2009 DSL - links all redirect to SQL

I was looking for Intentional Programming and video recordings of the MS DevCon 2009 DSL, almost all links are similar to this:
http://msdn.microsoft.com/en-us/oslo/videos.aspx#dsl
However, I get redirected to:
https://docs.microsoft.com/en-us/sql/connect/sql-data-developer?redirectedfrom=MSDN&view=sql-server-ver15#dsl

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45598139-4ac9-1270-f454-5dafb5a1adc0
Version Independent ID: 345fc425-8a77-6ac9-793e-b5e81c2a5a82
Content: SQL Data Developer - SQL Server
Content Source: docs/connect/sql-data-developer.md
Product: sql
Technology: connectivity
GitHub Login: @David-Engel
Microsoft Alias: v-daenge

@nonsensation -- thank you for your feedback.  Please consider these resources:

SQL Server on Microsoft Q&A
DBA Stack Exchange
Stack Overflow

@David-Engel -- please look into this issue.

@nonsensation I don't see any links like that on the page you submitted feedback for (SQL Data Developer - SQL Server) or any other SQL documentation pages. Are you sure you submitted feedback for the correct documentation page?
This appears to be submitted in error. If I'm wrong, feel free to re-open the issue.
#please-close

@nonsensation I don't see any links like that on the page you submitted feedback for (SQL Data Developer - SQL Server) or any other SQL documentation pages. Are you sure you submitted feedback for the correct documentation page?
This appears to be submitted in error. If I'm wrong, feel free to re-open the issue.
#please-close

Thank you for your response.
I was looking for recordings of a 2009 Video and several (external) websites linked to it:

This website and this website with this link http://msdn.microsoft.com/en-us/oslo/dd727740.aspx gets redirected to https://docs.microsoft.com/en-us/sql/connect/sql-data-developer?redirectedfrom=MSDN&view=sql-server-ver15

Although I have found the video I was looking for: https://channel9.msdn.com/Series/DSL-DevCon-2009/Intentional-Software
However I found it odd to get redirected from a seeminly no-more-existing MSDN url to SQL Server Docs?
But it may be not this important after all, just let you know.

Thank you for your response.
I was looking for recordings of a 2009 Video and several (external) websites linked to it:

This website and this website with this link http://msdn.microsoft.com/en-us/oslo/dd727740.aspx gets redirected to https://docs.microsoft.com/en-us/sql/connect/sql-data-developer?redirectedfrom=MSDN&view=sql-server-ver15

Although I have found the video I was looking for: https://channel9.msdn.com/Series/DSL-DevCon-2009/Intentional-Software
However I found it odd to get redirected from a seeminly no-more-existing MSDN url to SQL Server Docs?
But it may be not this important after all, just let you know.


"mouseoout"

You misspell "mouseout" once in the code.
Very helpful library overall! Great work!

Thanks, Fixed it,


Default bls12_381 is incompatible with Ethereum beacon chain

import { bls12_381 } from '@noble/curves/bls12-381'
import { hexToBytes } from '@noble/curves/abstract/utils'
import bls from "@chainsafe/bls"

const pubkey = hexToBytes('93a2c542bd455386a15a0f1c39e0c49c35248938ab56a64f560c4233100e5ba821fef9fd43fcd0e2d591949ab7ff76fe')
const signature = hexToBytes('8ee17b62fb7a528774be685d9aa01e13167f14450fb5832a8003129291a739643c3362a033024a43c0ac6ef7476892a41438ac18ef2451ffa8679c0e7af6b88e64151b403149db0c9301648e0eb84a8b897b6659f0d8fb050ba8627c9c1c278a')
const message = hexToBytes('ae1738463cd0a4e2ce2289b338dd2c6f56bf7c576ae110b6f6315a297d4352cc')

console.log(`@noble says ${bls12_381.verify(signature, message, pubkey)}`)
console.log(`@chainsafe says ${bls.verify(pubkey, message, signature)}`)

outputs
@noble says true
@chainsafe says false

using
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>
Given that both are purporting to use BLS12-381, and the Chainsafe version is actually used on Ethereum, I suggest that the Noble version at least have a warning that the default configuration is not compatible with Ethereum (if indeed there is not a more nefarious bug).

fwiw the same result occurs if I use the hexToBytes function from the Chainsafe repository
function hexToBytes(hex) {
    if (hex.startsWith("0x")) {
        hex = hex.slice(2);
    }
    if (hex.length & 1) {
        throw Error("hexToBytes:length must be even " + hex.length);
    }
    const n = hex.length / 2;
    const a = new Uint8Array(n);
    for (let i = 0; i < n; i++) {
        a[i] = parseInt(hex.slice(i * 2, i * 2 + 2), 16);
    }
    return a;
}

Ethereum uses the following

The IETF BLS signature draft standard v4 with ciphersuite BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_

Maybe the hash to curve algorithm is different in noble?

I haven't had luck using BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_ as the DST option to noble's functions yet. But probably there's some other configuration needed?

They are compatible. Proof: https://github.com/paulmillr/bls12-381-keygen, readme example generates same keys.
For verification you need to specify DST correctly.

So my claim is simply that the default configuration does not verify Ethereum signatures. I see now that the reason is the DST for Ethereum beacon chain differs from the noble curves default DST. My suggestion is to add this to the README and possibly include an example of using the Ethereum DST correctly.
The link you provided is about key generation, which is not precisely relevant to signature generation and verification.

Thank you so much for your help. I created this https://github.com/paulmillr/noble-curves/pull/129.

1.4.0 is out


View Participating Threads

I noticed that getting the threads in which users are participating, ie the Participating tab on Github, is as easy as flipping this value  to true... feels like a low-cost feature, maybe under the "View All" tab in the more options alert controller?
I don't know if there is a way to get a count of those Participating threads beforehand. That would be really nice.
I also noticed the v3 api provides a reason for each notification and we're capturing capturing it here. Probably a stretch but an even softer touch could be to use that information to make an inference about whether a user is participating in a thread and convey it in the UI somehow.

What's the value here?

My thought was providing the Participating Tab functionality, a list of issues you're actively participating in:

I always shoot straight for that tab, but I could be missing something.

Interesting! I don't think I've ever used that tab before.
At the very least, we could add this into the ... menu bar item? Under "View All" .

Okay no probs, I'll close this issue. If there's ever a stampede of users demanding this feature, its a ~ 5 min job to build.


Use CI matrix to our purposes

Everything is much better 🤩

🤯 I'm a GitHub ACtions expert and cannot solve this matrix thing!


Optional low resolution source maps

In many situations most of the value in a source map is given by the set of all first-in-their-line mappings.
In large builds, the cost of generating source maps is considerable, and emitting only this "blurrier" source map seems to be a good trade-off.
@johnjbarton please confirm if https://github.com/crisptrutski/traceur-compiler/commit/68b58bdcc86dbc02dbd6b660cb85684e428aa60a was a bug or not

@johnjbarton please confirm if crisptrutski@68b58bd was a bug or not
Yes, a bug. I've been trying to kill off toSource(), I think it is only used in some tests now and those probably don't use sourcemaps.  Did you find this by a failure or by inspection?

Just through inspection, no pesky use case here

I think we should have a test for this option, verifying that it produces a valid map similar to our existing sourcemap tests.

@johnjbarton backed out the noise, let me know if you want the two tests DRYed up

Sorry: please add an entry to the src/Options.js descriptions and check how it reads when you run ./tracuer.  Then LGTM

@johnjbarton thanks for vetting this so quickly - CLI doc string added

LGTM
Squashing and committing

Actually, no need to squash.

Rebased and commited


default_consensus method appears to have bugs

Describe the issue
The default_consensus() method appears to be buggy. When there is no ConsensusDocEvent, it always returns None despite apparently intending to return True for the ietf stream and False for the irtf stream.
The intention needs to be confirmed and the code adjusted accordingly.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

The meaning changed and the concept should be refactored - I have a branch where I started, but it needs more work.
The concept should be named something like "Use Consensus Boilerplate" and there's not need for events.
(There were periods where the code started towards trying to capture the moment someone declared a document had consensus in the ietf, but it turned out that it's unneeded and more complex to model than it appears.


Can't get to run torchnlp.ner properly

This is the result I get when following installation and running instructions:
>>> train('ner-conll2003', TransformerTagger, conll2003)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "torchnlp/tasks/sequence_tagging/main.py", line 46, in train
    dataset = dataset_fn()
  File "torchnlp/data/conll.py", line 67, in conll2003_dataset
    fields=tuple(fields))
  File "/usr/local/lib/python2.7/dist-packages/torchtext/data/dataset.py", line 78, in splits
    os.path.join(path, train), **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/torchtext/datasets/sequence_tagging.py", line 33, in __init__
    examples.append(data.Example.fromlist(columns, fields))
  File "/usr/local/lib/python2.7/dist-packages/torchtext/data/example.py", line 50, in fromlist
    setattr(ex, n, f.preprocess(val))
  File "/usr/local/lib/python2.7/dist-packages/torchtext/data/field.py", line 181, in preprocess
    x = Pipeline(six.text_type.lower)(x)
  File "/usr/local/lib/python2.7/dist-packages/torchtext/data/pipeline.py", line 37, in __call__
    x = pipe.call(x, *args)
  File "/usr/local/lib/python2.7/dist-packages/torchtext/data/pipeline.py", line 52, in call
    return [self.convert_token(tok, *args) for tok in x]
TypeError: descriptor 'lower' requires a 'unicode' object but received a 'str'

Took conll2003 dataset files from THIS REPO
ENV:
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.4 LTS
Release:	16.04
Codename:	xenial
--------------------------------
torch.__version__: 0.4.1
torchtext.__version__: 0.3.1
--------------------------------
python: 2.7.12

Hey you should try running with PyTorch version 3.5 or greater, that might fix it

Sorry I meant Python 3.5! You are right.

@Alexmac22347 could you please provide a docker on which this package works?

@aleksas are you input files in UTF-8 format?

I'm running pytest on cleanly cloned repo according to the installation instructions,
On py2.7 pytest runs without a problem. But training raises exception as shown in initial post.
On py3.6.5 pytest fails on tests/tasks/test_sequence_tagging.py tests.
Took the CoNLL-2003 data from HERE as it's not clear how to get the dataset from provided link. Tried also nyt_ingredients_ner dataset for training with same exception.

@aleksas Ive ran into the same unicode error. Might be a bit of a hack, running  export LC_CTYPE=en_US.UTF-8 fixed it for me. https://stackoverflow.com/questions/18649512/unicodedecodeerror-ascii-codec-cant-decode-byte-0xe2-in-position-13-ordinal
Let me know if that works/doesnt work

@Alexmac22347 that did the trick.
Made a PR with docker with appropriate locale settings.

Thanks @aleksas! Merged your PR. Hope this solves your problem :)

It did solve the problem, thanks!


Add feature to format and prettify a code-block

Given a message link/ref the bot should be able to do the following:

Determine what language it is (among supported list, determined)

probably a library out there somewhere that can help with this. Obviously if a message has text and code, the bot probably wont be able to differentiate.

Format the code in backticks with the correct syntax highlighting using something like prettier to format the code sensibly
If at any point the bot can't format/understand the language, return a "sorry" like message.

This feature should only be called with the format similar to:
!format <message_link>

This shouldn't be ran all the time as this can be a CPU intensive task if ran all the time.
We also need to make sure we don't perform remote code execution, so we need libs well respected libs to handle the code formatting.
This command might also work just to format a given text block without a link to another message.
edit we might be able to use the reactions feature to label code to "format":
https://discordjs.guide/popular-topics/reactions.html#awaiting-reactions

probably a library out there somewhere that can help with this. Obviously if a message has text and code, the bot probably wont be able to differentiate.

GitHub itself is using Linguist for that.

we might be able to use the reactions feature to label code to "format"

One idea was to use :robot: emoji to trigger them.

GitHub itself is using Linguist for that.

Linguist looks pretty heavy duty, and would require a ruby runtime which would increase the pre-req for this project beyond just node. Optimally we'd find a respectable node lib that we can leverage as-is, or piggieback on whatever the formatters use (if they work that way hehe)

Let's narrow down our target for now. We can start by creating an MVP release, which will format all web related languages. (For example -> JavaScript,  TypeScript,  Flow, JSX, JSON, CSS, SCSS, Less, HTML, Vue, Angular, GraphQL, Markdown, YAML)
I am suggesting this because the majority of people in the FCC Discord are web devs and they share within these formats.
After we get the MVP release out, then we can focus on adding other languages too like-

Python
PHP
etc....


README

The readme results for a headless check are backwards
With stealth should show (as ive tested recently) that it passes the headless check
Without stealth should show (as ive tested) that it fails many of the tests

The readme results for a headless check are backwards
With stealth should show (as ive tested recently) that it passes the headless check
Without stealth should show (as ive tested) that it fails many of the tests

updated already.


Adds the ability to allow public signup without invite code

Introduces new ENV variable SKIP_INVITATION_CODE, intentionally
phrased in the negative so that the absence of the variable
will not change the behavior of existing deployments.
This change would be used for hosting a publicly accessible deployment of Huginn

Still didn't base this off my branch :\


[Microsoft.DigitalTwins] January release for azure-digitaltwins-core

Description
January release for azure-digitaltwins-core, updating dependencies to azure-core and azure-identity.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


[nnbd] Flow analysis does not track non-null assignment to globals locally

I would expect non-null assignment to nullable globals to refine the type locally to non-null.
I would expect this to work:
int myFunction(int a) => a + 1;

int Function(int)? f;

doCachedF(int a) {
  f ??= myFunction;
  return f(a);
}

Error:
Error: Can't use an expression of type 'int Function(int)?' as a function because it's potentially null.
Try calling using ?.call instead.
  return f(a);
          ^

The work around works:
int myFunction(int a) => a + 1;

int Function(int)? f;

doCachedF(int a) {
  f ??= myFunction;
  return f!.call(a);
}

@leafpetersen
source: https://dart-review.googlesource.com/c/sdk/+/158545/2/tests/ffi/regress_43016_test.dart

This is actually working as intended: There is no support for promotion of non-local variables of any kind (top-level, static, instance), only for local variables. It wouldn't be sound to rely on f having a non-null type if any unknown code is executed (for instance, if any instance method is invoked on any object), because that code could assign null to f.


Animation with rxjs-easing is not smooth

rxjs-easing uses hard-coded animation frame rate (30fps), which cases jerks on more powerful machines. Here is a jsfiddle where this effect can be seen (scrolling using both jquery and explicit RAF scheduler is smoother that rxjs-easing.

@roganov upgrading this lib to ReactiveX/RxJS will fix this.


Change translation behaviour

Hi @tblanke
Currently, due to the way the translation is implemented, it is not possible to have two options in the gui_structure that share the same translation class attribute. E.g. in GHEtool, the category for the language selection and the label of the listbox for the language selection are the same, but they need to be implemented in respectively 'category_language' and 'option_language'.
When options are translated, this is done by iterating over all the objects in the translation class, so no translation can be linked to two options. If we change this to iterate over all the options, this duplication of translation class atributes can be avoided.

Nevermind, apparently, this problem is not there in the newest version of ScenarioGUI.
Perfect!


[Bug]: jest does not log to stdout, so its output cannot be captured.

Version
27.2.2
Steps to reproduce
run npx jest > output.txt - you don't even need to run any tests to see this go wrong, even the standard jest output isn't going to stdout
Expected behavior
a file output.txt is created, containing the output of the jest run, with no output written to the console except for execution errors.
Actual behavior
output.txt is empty, and all of jest's output is in the console
Additional context
This is not how CLI tools should behave. Errors should go to stderr, output should go to stdout,
Environment
win10 pro x64, node 16.7.0, npm 7.20.3

Frustrating

If a bug is still on "needs triage", it should not be part of stale-bot weeding.

If a bug is still on "needs triage", it should not be part of stale-bot weeding.

hm no passing --verbose does not change anything for my trouble. But sorry it's not the same issue then.


[TE-249] Remove panic from encode record

Remove panic! with returning error result.

This PR is basing on #368.

This PR is basing on #368.

@akoptelov is this one ready for review? still marked as "draft"

@akoptelov is this one ready for review? still marked as "draft"

It is ready now.

It is ready now.


Added support for textColor in DatePickerIOS

This update allows the text/label color of the DatePickerIOS to be updated via an attribute called, "textColor". Will solve the problem found here:
https://github.com/facebook/react-native/issues/4473

@nitrogenlabs do you still plan on addressing the feedback here?

Closing due to use of private APIs.

What's a private API here?


(🎁) add Isort

Hi @KotlinIsland,
Until recently I was unconvinced about isort, but I get it not, and appreciate the nudge to apply it here.
Thanks again for the contributions, and also for your patience for them to be merged.


macOS main thread checker violations

Describe the bug
When trying to use Filament under the Xcode debugger, the method PlatformCocoaGL::makeCurrent produces a runtime error message
Main Thread Checker: UI API called on a background thread: -[NSView bounds]

and if I let it run further it also complains that -[NSView convertRectToBacking:] should only be used on the main thread.  This is happening in a thread called Engine::loop.
I was trying to get Filament to work on macOS without SDL by imitating the project at iOS/samples/hello-triangle.
Desktop:

OS: macOS Big Sur 11.1 Beta (20C5048k)
GPU: Radeon Pro 560X 4 GB
Backend: OpenGL

Additional context
Xcode 12.3 beta

This should have been fixed with https://github.com/google/filament/pull/3273. You may have to wait for the fix to make it into the next release or build Filament yourself.

@bejado No, I did build from source.  That revision made thread-safety changes in PlatformCocoaGLImpl::updateOpenGLContext, whereas I am talking about PlatformCocoaGL::makeCurrent.

makeCurrent calls updateOpenGLContext, which is why I suspect it's the same bug.

@bejado Looks like a similar bug, but not the same.  Comments in updateOpenGLContext say it's trying to make sure that the methods -[NSOpenGLContext setView:] and -[NSOpenGLContext update] are called only from the main thread, and that this is a "hard requirement" as of macOS 10.15.  Whereas my bug is about methods of NSView, and maybe it's not a hard requirement.

Modifying our calls to convertRectToBacking and bounds so that they happen synchronously on the main thread drastically hurts performance. Given that these don't seem to be hard requirements and that OpenGL is deprecated on macOS anyway, I don't think this will be a priority for us to fix.

@bejado Of course I wouldn't have expected you to just synchronously do it on the main thread.  A more reasonable approach would be to subscribe to notifications of frame geometry updates, and when such a notification is received (on the main thread), cache the bounds.  It looks like NSViewFocusDidChangeNotification would be the best notification, though for some reason it's deprecated.


Update readme.md "Cloud" to "On-Prem"

Just a small documentation change for something that was likely a copy/paste issue.

Hi @brianpmccullough, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks Brian for you "significant" contribution. This was absolutely right way to do this and good to see that you were able to get the Git setup to work.


Learning rate setting for fine-tuning

Hi,
I am fine-tuning YOLOX on COCO and some other datasets for a one-class detection task. I wonder if you could provide some suggestions on the setting of learning rate for fine-tuning? I have set warmup_epochs = 0. Shall I keep basic_lr_per_img = 0.01 / 64.0 or shall I reduce it to a smaller value? Thanks for your help.

I changed the 0.01/64 to 1e-5/64 with batchsize64， and it helped

I changed the 0.01/64 to 1e-5/64 with batchsize64， and it helped

wow, 1e-5/64, this is a very very very low learning rate!

cyh767, thanks for this insight.
I have noticed that IOU best on the first epoch and drops in further. Using low LR provided by you and looks better now


Add loopback optionality

Currently the code base assumes the user does not want loopback functionality. This is a reasonable default, but can be a blocker in cases where loopback is important. This PR maintains the default but adds additional *_with_loopback methods.

This functionality would be super useful; any update here @dylanmckay? 🧑🔧


Slope modification kernels have C bugs

Copied, some of the code from slope_modification.py:
        self.slope_modification_2d_kernel = """ double new_cell = 0, d = 1.0; const E=1e-6, UB=1e0; int j;
        for(int i=0;i<vert_cell.dofs;i++){
            new_cell+=vert_cell[i][0];
        }
        new_cell=new_cell/vert_cell.dofs;
        if (new_cell<=E){
            for(int i=0;i<new_vert_cell.dofs;i++){
                new_vert_cell[i][0]=0;
                new_vert_u_cell[i][0]=0;
                new_vert_v_cell[i][0]=0;
            }
        }
        if (new_cell>E){
            float c=0;
            for(int i=0;i<new_vert_cell.dofs;i++){
                if (vert_cell[i][0]>E){
                    new_vert_cell[i][0]=vert_cell[i][0];
                    new_vert_u_cell[i][0]=vert_u_cell[i][0];
                    new_vert_v_cell[i][0]=vert_v_cell[i][0];
                }
                if (vert_cell[i][0]<=E){
                    c=c+1;
                    j=i;
                }
            }
            if (c==0){
                for(int i=0;i<new_vert_cell.dofs;i++){

A few things:

double new_cell = 0, d = 1.0; const E=1e-6, UB=1e0; int j;
Does not do what you think it does.  You need to specify types for E and UB otherwise they default to int.  I think you want:

double new_cell = 0, d = 1.0;
const double E = 1e6;
const double UB = 1e0;
int j

The counter c you're using in:

        if (new_cell>E){
            float c=0;
            for(int i=0;i<new_vert_cell.dofs;i++){
                if (vert_cell[i][0]>E){
                    new_vert_cell[i][0]=vert_cell[i][0];
                    new_vert_u_cell[i][0]=vert_u_cell[i][0];
                    new_vert_v_cell[i][0]=vert_v_cell[i][0];
                }
                if (vert_cell[i][0]<=E){
                    c=c+1;
                    j=i;
                }
            }

Really ought to be declared int, rather than float.  Also, j appears to be unused here.

Also in the slope_limiter.py setup, you define your own MIN and MAX macros.
        #define MIN(X, Y) (((X) < (Y)) ? (X) : (Y))
        #define MAX(X, Y) (((X) > (Y)) ? (X) : (Y))
        for(int i=0;i<vert_cell_max.dofs;i++){
            vert_cell_max[i][0]=MAX(vert_cell_max[i][0],cell_av[0][0]);
            vert_cell_min[i][0]=MIN(vert_cell_min[i][0],cell_av[0][0]);
        }

Just use fmin and fmax directly.  Which don't evaluate their arguments more than once.

This was an error indeed and has now been changed as of the final update of the current pull request. Thanks.

In the new pull request update this issue is sorted.

@alsgregory: Normally one closes an issue when the fix is in master.

Cool. Noted thanks


Distance - Unable to remove stop from the route

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.79-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4596214
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Create a distance request with 3 waypoints
Navigate to the distance expense details conversation
Tap on three dots and select "delete waypoint
Tap on Delete/Cancel button

Expected Result:
Able to remove stop from the route.
Actual Result:
Unable to remove stop from the route, keyboard opens and covering button Delete/Cancel
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/6b8195e4-4e2e-4bef-b9e6-b64f9e66b72e

View all open jobs on GitHub

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Frontend only bug

verified this is fixed on staging

Payment summary as follows:

$250 to @ishpaul777 for the fix

Paid, closing!


[Bug]: cmdk version 1.0.0 broken in Astro app

Describe the bug
Using the latest cmdk component with cmdk version 1.0.0 is not working properly, the dialog opens as usual but you cannot select or hover an item.
Affected component/components
Command
How to reproduce
Setup new Astro project with shadcn ui and add the Command component.
Codesandbox/StackBlitz link
https://stackblitz.com/edit/withastro-astro-1dtsvr?file=src%2Fstyles%2Fglobals.css
Logs
No response
System Info
.

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Downgrading to "cmdk": "^0.2.1" works.

Same issue here!

Should be resolved by changing the disabled related classes within CommandItem
Before:
data-[disabled]:pointer-events-none data-[disabled]:opacity-50
After:
disabled:pointer-events-none disabled:opacity-50
Example.
const CommandItem = React.forwardRef<
  React.ElementRef<typeof CommandPrimitive.Item>,
  React.ComponentPropsWithoutRef<typeof CommandPrimitive.Item>
>(({ className, ...props }, ref) => (
  <CommandPrimitive.Item
    ref={ref}
    className={cn(
      "relative flex cursor-default select-none items-center rounded-sm px-2 py-1.5 text-sm outline-none aria-selected:bg-accent aria-selected:text-accent-foreground disabled:pointer-events-none disabled:opacity-50",
      className
    )}
    {...props}
  />
))

Should be resolved by changing the disabled related classes within CommandItem
Before: data-[disabled]:pointer-events-none data-[disabled]:opacity-50
After: disabled:pointer-events-none disabled:opacity-50
Example.
const CommandItem = React.forwardRef<
  React.ElementRef<typeof CommandPrimitive.Item>,
  React.ComponentPropsWithoutRef<typeof CommandPrimitive.Item>
>(({ className, ...props }, ref) => (
  <CommandPrimitive.Item
    ref={ref}
    className={cn(
      "relative flex cursor-default select-none items-center rounded-sm px-2 py-1.5 text-sm outline-none aria-selected:bg-accent aria-selected:text-accent-foreground disabled:pointer-events-none disabled:opacity-50",
      className
    )}
    {...props}
  />
))

It fixes my problem. Thanks a lot!

Also related #3024


did AndroidVideoCache support seek operation?

did AndroidVideoCache support seek operation? I use this cool library, but it always download orderly, when I seek  a new position it dont cached, it always download orderly

as I found that , when I seek the position beyond  the cachelength+ extralength
cacheAvailable + sourceLength * NO_CACHE_BARRIER;
the cachelistener do not work anymore， unless  seek the position less than it.

@dinglj7 Yes, the latest version 2.5.0 allows to seek to any position. But it caches always consequentially even if you seek to not downloaded area it will continue to cache consequentially.

as I found that , when I seek the position beyond the cachelength+ extralength
cacheAvailable + sourceLength * NO_CACHE_BARRIER;
the cachelistener do not work anymore， unless seek the position less than it.

Do you use 2.5.0 version? It should be fixed in 2.5.0.

yes.   as I found , when seek position exceed the cacheAvailable bound, responseWithoutCache work over the net, it nomore by the cachefile , so cachelistener do not work during this process. use a new cachefile could help this ?

This issue can interrupt caching process if you seek to uncached area with position > cached position + sourceLength * NO_CACHE_BARRIER. If caching process is interrupted listener will not notify you about caching progress. Please check version of library 2.5.0. It has fix for it. If you will have any problem with new version, please, let me know.


2015 09 02

Called 2015 09 02 because of taking advantage of mulligan

Another example of a PR that could use a checklist... Distilling that checklist from the assignment will also help you piece apart the assignment and not miss things... in theory.

This PR should be from 2015-09-02 (as you've done) into jcreasman:master (your forked master branch). You're requesting a pull into TIY-Durham:master, which is where you forked from.


Need help on AppBar -- problem using ThemeManager.setTheme

Hi,
I'm making a simple Navigation component w/ AppBar and have run into difficulty with setting the theme.
The error from the browser tool console is:
TypeError: newTheme.getPalette is not a function
I've looked at the API, examined the code for the library, and looked at the two examples for
consuming Material-UI, but can't figure out what I am doing wrong.
Can someone help me on this?
Here is the code from my navigation.jsx file:
var React = require('react');
var ThemeManager = require('material-ui/lib/styles/theme-manager')();
var DarkTheme = require('material-ui/lib/styles/themes/dark-theme');
var AppBar = require('material-ui/lib/app-bar');
var Navigation = React.createClass({
childContextTypes: {
muiTheme: React.PropTypes.object
},
getChildContext: function() {
return {
muiTheme: ThemeManager.getCurrentTheme()
};
},
componentWillMount: function() {
ThemeManager.setTheme({
DarkTheme
});
},
// Dev functions
render: function() {
return (

);
}
});
module.exports = Navigation;

somehow the render function did not show the code correctly, I'll try here:
render: function() {
return (

);
}

I don't know how to quote less-than-char AppBar title='MyTitle' / greater-than-char

I'll try to include the code with a screen-shot:

Checkout material-ui/src/styles/theme-manager.js
The setTheme method takes one argument that looks like -
{
  getPalette(){},
  getComponentThemes(palette){}
}

You're passing an object that looks like -
{
  DarkTheme: DarkTheme
}

Yes, that works.
Thank you for helping me out.


fix: auto login and error page

Issues Addressed
Closes #236
Additional Information
The error page that will be displayed in case of errors with the readme token

Use this as the login page for someone not logged in.


[v1.31.0] All flows fail with error: Unable to clear state for app

Describe the bug
Maestro flows which run successfully on few devices, fail on other devices with the error (Unable to clear state for app <package>)
To Reproduce
Steps to reproduce the behavior, e.g.:

Connect the device through adb
Run maestro test flow.yml where flow.yml is a flow with clearState=true
The flow fails at start within 1-2sec.

Expected behavior
The flow success should be consistent across devices
Environment information:

Maestro version: v1.31.0
Platform: Android 11.0
Framework: Native Android
Device model and OS version: Oppo CPH2349, Android 11
Physical device
Host: Mac M1

Additional context
Some interesting observations:
The device security app flags dev.mobile.maestro and dev.mobile.maestro.test packages as a security concern. This may be interfering with maestro functionality. Attaching the device logcat for dev.mobile.maestro filter: maestro-logcat.txt

I have this same issue, has any workaround been found? I wonder if it could be an xcode 15 or ios17 issue

@saihemanth121 @dannyhw Can you try updating to 1.31.1 to see if the issue is fixed there?

I'm having this same issue as well

This started working for me after an update, try updating maestro if you haven't already.

It's happening in 1.36.0
Sonoma 14.1.2
Any news?

For Oppo devices specifically, I got around this via a phone setting.
In Developer Options, disable Verify apps over USB

I encountered this just now on iOS 17.5 Simulator (iPhone 15 Pro). It happened while I was trying to reproduce this issue.


added logging and re-enabled hidden audits

I spent a day on this and could not figure out where the bug is.
It seems the auditHistory in patrick's log is in an inconsistent state (lastAudit.MaxHiddenSeqno is 7 but history.HiddenTails[7] does not exist). I added an assertion which ensures that history.HiddenTails[n] exists whenever we update lastAudit.MaxHiddenSeqno to n.
So if the client tries to write a bad auditHistory state again we should be able to find out and have more details on why this is happening.


mbed TLS crash (Floating point exception) on CentOS 3 x86_64

Hi, thank you for letting me use mbed TLS.
We found a bug on CentOS 3 x86_64.
I used mbed TLS version 1.3.16.
Following code affect floating point exception.
CentOS 4 to 7 and CentOS 3 ia32 can run correctly.
Do you still support CentOS 3?
#include "polarssl/bignum.h"

int main(int argc, char **argv){
    mpi a, q, b, r;
    mpi_init(&a);
    mpi_init(&q);
    mpi_init(&b);
    mpi_init(&r);
    mpi_lset(&a, argc>2 ? atoi(argv[1]) : 100);
    mpi_lset(&b, argc>2 ? atoi(argv[2]) : 7);
    if(mpi_div_mpi(&q, &r, &a, &b) != 0){
        return -1;
    }
    printf("%zu(a) = %zu(q) * %zu(b) + %zu(r)\n", a.p[0], q.p[0], b.p[0], r.p[0]);
    return 0;
}

$ cat /etc/redhat-release
CentOS release 3.9 (Final)

$ rpm -q gcc glibc | uniq
gcc-3.2.3-60
glibc-2.3.2-95.50

$ gcc test_mbedtls_div.c -I ../mbedtls-1.3.16/include/ ../mbedtls-1.3.16/library/libmbedtls.a

(Expect)
$ ./a.out
100(a) = 14(q) * 7(b) + 2(r)

(Actual)
$ ./a.out
Floating point exception

ARM Internal Ref: IOTSSL-777

Hi,
To answer your question, we support CentOS as much as we do any other contemporary Linux distribution. There should be no dependencies that prevent us from executing on Red Hat or CentOS.
However - you're running a pretty old version of CentOS, and equally old versions of gcc and glibc - none of which look like they continue to be supported, and none of which we have tested with.
I've tried reproducing your fault on my current personal Linux development platform - Ubuntu 16.04, gcc 5.3.1, and unsurprisingly I see no faults, and as you say, you don't see this fault on more recent versions of CentOS.
If you were reporting an issue in a recent version of CentOS, then we might consider installing that version of CentOS just to reproduce the fault, but my concern is you're using a version that doesn't seem to be supported any longer, and the issue is likely in the platform. CentOS 3 was released very early in AMD64 adoption, and I imagine there's a bug in the platform in that area.
If someone were to provide a pull request to fix the issue we would consider merging it, or a stack trace we would consider investigating it - but on the basis of this report there's not much for us to go on.
Is it possible for you to upgrade to a more recent version of CentOS?

Thank you for your reply.
I also think that it is a problem caused by system components.
If I found solution, I will report again.
Thank you.


[date-time-picker] Update Screen reader response not to read visually hidden text with name attribute.

Summary

What was changed:
Update Screen reader response not to read visually hidden text with name attribute.
Why it was changed:
When user first navigates to the date input field, then the visually hidden text with name attribute is exposed to user which is not contextual and can be confusing.
https://github.com/cerner/terra-framework/assets/132886427/42cc15c4-bea6-4a67-a66d-5e3f659ab4fd
Testing

This change was tested using:

[ ] WDIO
[x] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[x] Functional review

Additional Details

This PR resolves:
UXPLATFORM-10137

Thank you for contributing to Terra.
@cerner/terra

+1
Th visually hidden text is no longer exposed along with the "Month" edit field present for the "Enter Date/Time" field. Hence, the issue is fixed.


Added support for FastAPI

Tests and examples are to be added in a separate PR

@mrichar1 Please, review and if it's okay, proceed to merge and I'll commit in authomatic a commit that depends on this one.

Thanks for submitting this here - we need to do the same updates to get testing and deployment fixed on this repo - I'll review and accept after that point, or it won't build a new release on pypi.

@mrichar1 feel free to do whatever needed, I'll be waiting


Support swap/swap claim in TransactionPlannerRequest

Part 1 of #2597, missing integration tests

Merging this so that the breaking proto changes in #2940 can be rebased on top of it.


syscall/js: improve documentation of js.FuncOf

The existing documentation is improved to be more
explicit about the lifecycle and its consequences.
Fixes #34324

I haven't heard from you for while now. I updated everything to the reviewers favor. Is there something else I need to do?


users flipflop and must run multiple times

Because of the simple file_line based approach to this module, user machines can flip flop between identical service lines, needlessly restarting services.  Also puppet must run twice to update the targets for facter
Notice: /Stage[main]/R_profile::Monitor::Nagios_monitored/Source_ipaddress[<IP_ADDRESS>]/File[/etc/target_ip]/content: content changed '{md5}5c88abe22bfa30324be639eb8d5cdc48' to '{md5}77686c0a51f7576385509cceae024827'
Notice: /Stage[main]/R_profile::Web_service::Apache/Source_ipaddress[<IP_ADDRESS>]/File_line[<IP_ADDRESS>]/ensure: created

Pluginsync happens before Facter runs, so you could put the .txt file in /facts.d/foo.txt.
network_info = File.join(Puppet[:pluginfactdest], 'network_info.txt')

prior art: https://github.com/natemccurdy/puppetlabs-websphere_application_server/blob/improvements/lib/facter/websphere_facts.rb#L7


Fix LosssReduce serde for samediff

What changes were proposed in this pull request?
Samediff did not used to know how to serialize LossReduce fields in loss functions. This would prevent the save state of anything with a loss function to throw a null pointer.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Tested with new unit test
Quick checklist
The following checklist helps ensure your PR is complete:

[ X] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[ X] Reviewed the Contributing Guidelines and followed the steps within.
[ X] Created tests for any significant new code additions.
[X ] Relevant tests for your changes are passing.

@treo I'll highlight the main updates for you. There is a lot of code gen in here. I had to update the flatbuffers types.


chore(release): 0.12.0

Version bump in package.json and package-lock.json for release 0.12.0

:tada: This PR is included in version 0.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Check installation is not complete

Hi there,
in the Installation doc, it states that
python ipk.py --help

can be used to check the installation. My default python on Ubuntu 20.04.6 LTS is however Python 2.7.18, such that this fails. As ipk.py contains the python3, it might hence be better to use
./ipk.py --help

instead.
Then, the command succeeds. However, I did not make raxml-ng available to IPK yet, and hence when trying to run it, get the error
RuntimeError: RAxML-ng not found. Please check it exists in your PATH or provide a full filename

If the above command is meant to be a check for successful installation, I recommend checking there that raxml-ng is available to IPK  :-)
Cheers
Lucas

The same is true when the ipk binary is not there. Apparently, it did not compile correctly the first time (not sure why - can't reproduce now), and despite the check above working, I then got

./ipk.py build -w ../test/ -r ../test/dataset.fasta -t ../test/dataset.newick -m GTR -a 0.42
/path/to/ipk/bin/ipk/ipk-dna --ar-binary /home/lucas/Software/miniconda/bin/raxml-ng --refalign ../test/dataset.fasta -t ../test/dataset.newick -w ../test/ -k 8 --alpha 0.42 --categories 4 --reduction-ratio 0.99 -o 1.5 --no-filter -u 1.0 -j 4 --model GTR
/bin/sh: 1: /path/to/ipk/bin/ipk/ipk-dna: not found
Traceback (most recent call last):
File "./ipk.py", line 315, in
ipk()
File "/home/lucas/Software/miniconda/lib/python3.8/site-packages/click/core.py", line 1130, in call
return self.main(*args, **kwargs)
File "/home/lucas/Software/miniconda/lib/python3.8/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/lucas/Software/miniconda/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/lucas/Software/miniconda/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/lucas/Software/miniconda/lib/python3.8/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "./ipk.py", line 195, in build
build_database(ar,
File "./ipk.py", line 305, in build_database
p = subprocess.run(command_str, shell=True, check=True)
File "/home/lucas/Software/miniconda/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '/path/to/ipk/bin/ipk/ipk-dna --ar-binary /home/lucas/Software/miniconda/bin/raxml-ng --refalign ../test/dataset.fasta -t ../test/dataset.newick -w ../test/ -k 8 --alpha 0.42 --categories 4 --reduction-ratio 0.99 -o 1.5 --no-filter -u 1.0 -j 4 --model GTR' returned non-zero exit status 127.

This was fixed after repeating the download and compilation. But I think that a check of the installation should check that all binaries are there ;-)


[C++][CI] arrow-compute-plan-test timeouts on nightly job for ubuntu 18.04

Describe the bug, including details regarding any error messages, version, and platform.
Since https://github.com/apache/arrow/pull/15183 was merged the nightly job for:
test-ubuntu-18.04-cpp-static
has been failing with a timeout on:
 Errors while running CTest
88/88 Test #36: arrow-compute-plan-test ...................***Timeout 300.00 sec
Running arrow-compute-plan-test, redirecting output into /build/cpp/build/test-logs/arrow-compute-plan-test.txt (attempt 1/1)

99% tests passed, 1 tests failed out of 88

It does not seem to cause issues on the verification scripts so I don't think it is a release blocker but we should investigate to fix the test or increase the timeout?
Component(s)
C++, Continuous Integration

cc @vibhatha

Is this consistent?  It may be fixed by https://github.com/apache/arrow/pull/33700

It has been failing consistently since the first failure for the last 3 nightlies based on: http://crossbow.voltrondata.com/

it seems to be fixed by the PR mentioned above: https://github.com/apache/arrow/pull/33700
I've triggered the crossbow job manually from latest master (containing the fix) and has been successful: https://github.com/ursacomputing/crossbow/actions/runs/3931964628
I am closing the issue, will re-open if nightly jobs fail again but seems fixed.


Request for advice on optimizing results

Hi! Thanks for sharing. Not looking to ask you to debug or anything, just looking for insight as to what I can do to optimize my results. Here is what I'm getting:
This is a screenshot from the market:

These are two screenshots of the tool and it's results (2 so I can scroll over and show that the first entry is in fact the first entry on the screenshot from the game.

Here are my config.json settings:
{"WindowState":0,"WindowLocation":"242, 161","GameUILanguage":"English","Size":"594, 390","UploadToServer":false,"Region":"US West","Server":"Ashok Vatika"}
I've also tried modifying them to :
{"WindowState":0,"WindowLocation":"242, 161","GameUILanguage":"English","Size":"1920, 1080","UploadToServer":false,"Region":"US West","Server":"Lintukoto"}
(note: the only real difference is the value of the Size parameter)
My monitor resolution is 1920x1080 and I play the game at 1920x1080 (windowed mode).
Any advice to stop getting those weird results seen in picture 1?
Thank you for even considering responding to my question :)

Hello, it could be because the windowed mode, could you please try with full screen mode?

Hey, thanks so much for responding :)
I'll give it a shot tonight!


[bug] Make simple multi-device scenario work

Creating two peers with the same account ID should be possible, and they should be able to connect with one another.

@burdiyan have we recently tested the ability for two peers of the same account ID to connect?

Yes, it should work fine now.


docker: Error response from daemon: could not select device driver "" with capabilities: [[gpu]].

我是mac m2上运行也提示这个。。不知道咋解决了


raytracing sample hlsl compile fail

1>    Environment Variables passed to tool: 1>      TRACKER_CONSOLEPAGE=65001 1>    C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x86\dxc.exe /nologo /T lib_6_3 /Fh "obj\x64\Debug\\CompiledShaders\Raytracing.hlsl.h" /Fo "bin\x64\Debug\Raytracing.cso" /Vn "g_pRaytracing" /Od /Zi Raytracing.hlsl 1>    Tracking command: 1>    C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Current\Bin\Tracker.exe /d "C:\Program Files (x86)\MSBuild\15.0\FileTracker\FileTracker32.dll" /i D:\dev\github\DirectX-Graphics-Samples\Samples\Desktop\D3D12Raytracing\src\D3D12RaytracingHelloWorld\obj\x64\Debug\D3D12Ray.5018F6A3.tlog /r D:\DEV\GITHUB\DIRECTX-GRAPHICS-SAMPLES\SAMPLES\DESKTOP\D3D12RAYTRACING\SRC\D3D12RAYTRACINGHELLOWORLD\RAYTRACING.HLSL /b MSBuildConsole_CancelEvent4eeb68d187cd46a1b81015d545bb1371  /c "C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\x86\dxc.exe"  /nologo /T lib_6_3 /Fh "obj\x64\Debug\\CompiledShaders\Raytracing.hlsl.h" /Fo "bin\x64\Debug\Raytracing.cso" /Vn "g_pRaytracing" /Od /Zi Raytracing.hlsl 1>    C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(1532,5): error MSB6006: "dxc.exe" exited with code -1073741819.
can't get what does the error code means.
anyone can help?
thx

finally, i got this fixed;
seems visual studio have some problems on creating the ouput folder:
"CompiledShaders" in $(IntDir)\CompiledShaders%(Filename).hlsl.h
after creating one myself, everything goes well;

I have the same problem.
This happens in the latest version of Windows and VS.

Me too.  Visual studio 2019 + Win 10.
Microsoft Visual Studio Professional 2019
Version 16.7.6
VisualStudio.16.Release/16.7.6+30611.23
Microsoft .NET Framework
Version 4.8.03761
Installed Version: Professional
Visual C++ 2019   00435-60000-00000-AA133
Microsoft Visual C++ 2019
ASP.NET and Web Tools 2019   16.7.532.28833
ASP.NET and Web Tools 2019
Azure App Service Tools v3.0.0   16.7.532.28833
Azure App Service Tools v3.0.0
C# Tools   3.7.0-6.20459.4+7ee7c540e3bf19765695b1331c946ddf986d1516
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Cookiecutter   16.7.20248.6
Provides tools for finding, instantiating and customizing templates in cookiecutter format.
IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info
Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.30701.1
Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package
NuGet Package Manager   5.7.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/
ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
Python   16.7.20248.6
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.
Python - Conda support   16.7.20248.6
Conda support for Python projects.
Python - Django support   16.7.20248.6
Provides templates and integration for the Django web framework.
Python - IronPython support   16.7.20248.6
Provides templates and integration for IronPython-based projects.
Python - Profiling support   16.7.20248.6
Profiling support for Python projects.
Test Adapter for Boost.Test   1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test.  The use terms and Third Party Notices are available in the extension installation directory.
Test Adapter for Google Test   1.0
Enables Visual Studio's testing tools with unit tests written for Google Test.  The use terms and Third Party Notices are available in the extension installation directory.
TypeScript Tools   16.0.20702.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools   3.7.0-6.20459.4+7ee7c540e3bf19765695b1331c946ddf986d1516
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio Tools for CMake   1.0
Visual Studio Tools for CMake

@toughbro You save my life! Thanks bro!

This VS's bug.
https://developercommunity.visualstudio.com/content/problem/1145832/typo-in-fxc-target-in-vs-1671.html

This was fixed in VS 2019 (16.8)
https://developercommunity.visualstudio.com/t/hlsl-shader-compiler-fails-to-create-output-direct/1143412


Added greater agent capabilities, upload media (image/video) + quote tweets (with or without media) + following users, re-tweeting, & liking posts (for the algo !)

Enhanced Twitter Client Features
This PR adds several new features to the Twitter client to make capabilities more autonomous
New Features

Media uploads (photos/videos) support
Quote tweets functionality
Following users capability
Tweet liking functionality

Technical Details

Added multi-step video upload process with chunked uploading
Implemented media processing status checks
Added rate limit handling for follow operations

Testing
All new features have been tested, included a command.ts file (optional) which allows user's to test functionalities via a CLI. Added node-fetch as an NPM package to test uploading images/videos from a link.
 Since someone handled media upload in the latest pull, I built the new functions I added on top of that.
there should be no claude or missing code, now things are only added in their proper position (QT/Likes/RTs in tweet.ts, follows in relationships.ts)
Check it out now ! Optimized and cleaned up, I also added testing for the new functions that passed.

oops! yea those changes weren't supposed to go on this branch. thanks !


Unable to download entire diagram in single page as PDF in v24.3.1 online or local app | Working on version v24.2.5

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
*[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'File > Export as > Advanced'
Click on 'Format' set to PDF
Border 30
Export
See the downloaded file, instead of one page PDF, it downloads in multi pages.

Expected behavior
Entire drawing should be in single page PDF instead of multi page.
draw.io version (In the Help->About menu of the draw.io editor): v24.3.1

draw.io version v24.3.1

Desktop (please complete the following information): Same as I explained above.

Browser: Chrome
Browser Version: Version 124.0.6367.119 (Official Build) (arm64)

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

Yes

This is a known issue, we're removing the advance option in an upcoming release.

but then, when we do export as PDF then it should download in single page instead of multi pages. Multi page diagram is not properly readable.

Will the removal of the "advanced" option also remove the ability to export pdf. I can recreate the issue without going to advanced options using the "basic" pdf export option. I'd also like to work on a solution for this. Should I wait until the upcoming release to tackle it?


Fix a bug in a corner case. [phab:D1067]

Created by zarko at 2016-09-19 18:14:39:
We were generating bad VNames for ranges that were half-invalid. These ranges come up in implicit code.

salguarnieri accepted this revision at 2016-09-19 18:16:39

zarko closed via commit<PHONE_NUMBER>3351738e81944fdb48fbcfea2280ed at 2016-09-19 18:17:23


📝 Documentation: Incorrect example in 'order-properties' is correct

Bug Report Checklist

[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
In the rule details of order-properties it now says:

Examples of incorrect code for this rule:
{
	"name": "my-package",
	"version": "1.0.0"
}

But it should be:

Examples of incorrect code for this rule:
{
	"version": "1.0.0",
	"name": "my-package"
}

D'oh! Good catch - thanks for reporting. Would love a PR!

@all-contributors please add @kristjanesperanto for bug.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Aha I see what happened here: linting auto-fixed the invalid case! Amusing.

Many thanks for this and generally for your great work in the ESLint ecosystem! :+1:


[Bug]: BottomSheet Multiple Instance are created on multiple taps

Summary
When the more from Bottom Navigation is tapped the bottom sheet opens. But if we tap multiple times the instance of bottom sheet is created multiple times this could lead to

Performance issues as more memory is being consumed when multiple instance are created.
Users Needs to click on back multiple times
Memory Leak.

Device Info
API level: 34
Android version: 14
Device manufacturer: Google
Device model: sdk_gphone64_arm64
Device: emu64a
Network type: wifi
App version name: 4.2.1-debug-main~17855ca37
Steps to reproduce

Click multiple time on More from Bottom Navigation.
Multiple Bottom-sheet is created.

Expected behaviour
Only one instance of bottom sheet to be created even on multiple taps. This can be handled by creating flags when the bottomsheet is opened and if the flag is true no new bottomsheet will be created as already one instance is created.
Actual behaviour
Multiple instance are created.
Device name
No response
Android version
14
Commons app version
4.2.1
Device logs
No response
Screen-shots
https://github.com/commons-app/apps-android-commons/assets/60827173/89a0a93f-f679-4d80-b9e9-69e21dc84ff1
Would you like to work on the issue?
Yes

@neeldoshii
Isn't this rare to occur practically, I cannot reproduce this on one of my Physical Devices. (You have to click really fast on a very responsive device I suppose) , also the solution you suggest isn't common (or mostly required for creating bottom sheets) - this would add another layer of complexity to it. what do you think? also, I would suggest trying to test this behavior (bottom sheet) on other standard Android apps (Like Google Tasks for example) because this behavior can also be observed there (and many other apps as according to standard documentation you don't need to handle the case that you mentioned)

We can't reproduce this issue as I suspect it happens only on your device because of a recent change you made on a bottom sheet by this PR #5578
Please resolve this behavior in that PR :)
There is no need to create another issue for that.

We can't reproduce this issue as I suspect it happens only on your device because of a recent change you made on a bottom sheet by this PR #5578
Please resolve this behavior in that PR :)
There is no need to create another issue for that.

On, the contrary I was able to reproduce this behaviour on the main branch, though it was very difficult to reproduce and occurred once in 5 tries :(

Isn't this rare to occur practically, I cannot reproduce this on one of my Physical Devices. (You have to click really fast on a very responsive device I suppose)

@shashankiitbhu
No, this is common to occur on older device where the memory of the device is very low. When you click on the button and it didn't loaded the bottom-sheet faster than usual the user tends to perform multiple tap on it which leads to creating multiple instance. Considering your point if you consider newer device its rare to occur but thinking from x% of users who are still using >Android 10 version device with less than 2-3GB ram device. Its worth considering wide range of users.

This would add another layer of complexity to it. what do you think?

This won't be complex task and it won't be large refactoring. It would just require to pass bundle to the bottomsheet. if the bottomsheet claas bundle is null --> create instance else --> its instance is already created and won't create multiple sheet.
The refactor would be less than 30 lines of code.
I would still like to have feedback from other reviewers.
Thanks

This won't be complex task and it won't be large refactoring. It would just require to pass bundle to the bottomsheet.

I understand that it won't be a difficult task but my point is it's rather unnecessary and adding flags like this before opening the bottom sheet is not really a recommended method.
As I mentioned in a previous comment that you should check out some standard Android apps (built by Google itself following the Best Practices) , there too you can reproduce this issue mentioned. (Google tasks for example)
My suggestion wasn't related to the complexity of tasks but rather maintaining the best practices and code quality.
If we were to act on every possibility like this (let's take slow response time on older devices for example) that would require is to handle 100s of unnecessary cases , you can reproduce this kind of discrepancies on older devices for almost every app available on Play Store.

@neeldoshii
Apologies for the confusion! I misunderstood the problem; I initially thought it might be related to activity creation, possibly caused by certain conditional statements.
However, I haven't pulled from the main branch in a while, so I can't reproduce the issue on my device. Thus, I suspected it might be related to a recent pull request.


Text composables: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-classes-and-objects?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-classes-and-objects#6
In which task and step of the codelab can this issue be found?
"Override superclass methods from subclasses" - Step 2
Describe the problem
Nowhere up to this point are we told to create turnOn() and turnOff() methods in the SmartLightDevice or SmartTvDevice subclasses but this step asks us to put the override keyword in front of them

Hi @seyckra
Thank you for writing in and bringing this issue to our attention.
The lesson has been updated to address it and the revised lesson will be republished again in the near future.
Hope you are enjoying the course!
Regards.


The program crashed during training

Crash Description
The following exception is thrown in train.log. Seems that the training program crashed because the wav length of training data is too short. (I set remove_short_samples to false in parallel_wavegan.v1.yaml.)
But the same config and data doesn't crash if n_gpus is set to 1 in run.sh, so it may have something to do with distributed computing.
2023-03-15 12:19:52,873 (train:317) INFO: (Steps: 5542) Finished 326 epoch training (17 steps per epoch).
[train]:   3%|▎         | 5559/200000 [1:40:28<50:52:14,  1.06it/s]/home/sshu/pwg/parallel_wavegan/bin/train.py:600: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at  ../torch/csrc/utils/tensor_new.cpp:210.)
  y_batch = torch.tensor(y_batch, dtype=torch.float).unsqueeze(1)  # (B, 1, T)
/home/sshu/pwg/parallel_wavegan/bin/train.py:600: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at  ../torch/csrc/utils/tensor_new.cpp:210.)
  y_batch = torch.tensor(y_batch, dtype=torch.float).unsqueeze(1)  # (B, 1, T)
/home/sshu/pwg/parallel_wavegan/bin/train.py:600: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at  ../torch/csrc/utils/tensor_new.cpp:210.)
  y_batch = torch.tensor(y_batch, dtype=torch.float).unsqueeze(1)  # (B, 1, T)
/home/sshu/pwg/parallel_wavegan/bin/train.py:600: UserWarning: Creating a tensor from a list of numpy.ndarrays is extremely slow. Please consider converting the list to a single numpy.ndarray with numpy.array() before converting to a tensor. (Triggered internally at  ../torch/csrc/utils/tensor_new.cpp:210.)
  y_batch = torch.tensor(y_batch, dtype=torch.float).unsqueeze(1)  # (B, 1, T)
2023-03-15 12:20:11,153 (train:317) INFO: (Steps: 5559) Finished 327 epoch training (17 steps per epoch).
[train]:   3%|▎         | 5575/200000 [1:40:46<61:09:19,  1.13s/it]2023-03-15 12:20:29,317 (train:1087) INFO: Successfully saved checkpoint @ 5575steps.
Traceback (most recent call last):
  File "/home/sshu/pwg/tools/venv/bin/parallel-wavegan-train", line 11, in <module>
    load_entry_point('parallel-wavegan', 'console_scripts', 'parallel-wavegan-train')()
  File "/home/sshu/pwg/parallel_wavegan/bin/train.py", line 1082, in main
    trainer.run()
  File "/home/sshu/pwg/parallel_wavegan/bin/train.py", line 96, in run
    self._train_epoch()
  File "/home/sshu/pwg/parallel_wavegan/bin/train.py", line 300, in _train_epoch
    for train_steps_per_epoch, batch in enumerate(self.data_loader["train"], 1):
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 530, in __next__
    data = self._next_data()
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1224, in _next_data
    return self._process_data(data)
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1250, in _process_data
    data.reraise()
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/_utils.py", line 457, in reraise
    raise exception
IndexError: Caught IndexError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 287, in _worker_loop
    data = fetcher.fetch(index)
  File "/home/sshu/pwg/tools/venv/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 52, in fetch
    return self.collate_fn(data)
  File "/home/sshu/pwg/parallel_wavegan/bin/train.py", line 601, in __call__
    c_batch = torch.tensor(c_batch, dtype=torch.float).transpose(2, 1)  # (B, C, T')
IndexError: Dimension out of range (expected to be in range of [-1, 0], but got 2)

[train]:   3%|▎         | 5575/200000 [1:40:47<58:34:56,  1.08s/it]Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/sshu/pwg/parallel_wavegan/distributed/launch.py", line 177, in <module>
    main()
  File "/home/sshu/pwg/parallel_wavegan/distributed/launch.py", line 173, in main
    raise subprocess.CalledProcessError(returncode=process.returncode, cmd=cmd)
subprocess.CalledProcessError: Command '['parallel-wavegan-train', '--local_rank=1', '--config', 'conf/parallel_wavegan.v1.yaml', '--train-dumpdir', 'dump/train_nodev/norm', '--dev-dumpdir', 'dump/dev/norm', '--outdir', 'exp/train_nodev_parallel_wavegan.v1_train_nodev_jsut_parallel_wavegan.v1', '--resume', '', '--pretrain', '/home/sshu/pwg_out/train_nodev_jsut_parallel_wavegan.v1/checkpoint-400000steps.pkl', '--verbose', '1']' returned non-zero exit status 1.
# Accounting: time=6088 threads=1
# Ended (code 1) at Wed Mar 15 12:20:30 JST 2023, elapsed time 6088 seconds

Training Description
The data contains 200 wav files, with 198 files set as training set, and the remaining 2 files set as both dev and eval.
n_gpus is set to 2 since I've got 2 GPUs.
Here's the relating parameters in run.sh
n_gpus=2
n_jobs=2

# ...

# subset setting
shuffle=false # whether to shuffle the data to create subset
num_dev=2   # the number of development data
num_eval=0  # the number of evaluation data
              # (if set to 0, the same dev set is used as eval set)

I used the parallel_wavegan.v1.yaml which comes from the pretrained JSUT pwg model, with remove_short_samples set to false.
Environment
ParrallelWaveGAN: v0.5.5
Python: 3.8.10
The output of pip list:
Package            Version      Editable project location
------------------ ------------ -------------------------
apex               0.1
appdirs            1.4.4
argcomplete        2.0.0
attrs              21.4.0
audioread          2.1.9
beautifulsoup4     4.11.1
black              22.3.0
certifi            2021.10.8
cffi               1.15.0
charset-normalizer 2.0.12
click              8.1.2
cycler             0.11.0
decorator          5.1.1
filelock           3.6.0
flake8             3.8.4
flake8-docstrings  1.6.0
fonttools          4.33.1
gdown              4.4.0
h5py               3.6.0
hacking            4.1.0
idna               3.3
iniconfig          1.1.1
joblib             1.1.0
kaldiio            2.17.2
kiwisolver         1.4.2
librosa            0.9.1
llvmlite           0.38.0
matplotlib         3.5.1
mccabe             0.6.1
mypy-extensions    0.4.3
numba              0.55.1
numpy              1.21.6
packaging          21.3
parallel-wavegan   0.5.5        /home/sshu/pwg
pathspec           0.9.0
Pillow             9.1.0
pip                22.3.1
pkg_resources      0.0.0
platformdirs       2.5.2
pluggy             1.0.0
pooch              1.6.0
protobuf           3.20.1
py                 1.11.0
pycodestyle        2.6.0
pycparser          2.21
pydocstyle         6.1.1
pyflakes           2.2.0
pyparsing          3.0.8
PySocks            1.7.1
pytest             7.1.1
python-dateutil    2.8.2
PyYAML             6.0
requests           2.27.1
resampy            0.2.2
scikit-learn       1.0.2
scipy              1.8.0
setuptools         44.0.0
six                1.16.0
snowballstemmer    2.2.0
SoundFile          0.10.3.post1
soupsieve          2.3.2.post1
tensorboardX       2.5
threadpoolctl      3.1.0
toml               0.10.2
tomli              2.0.1
torch              1.11.0+cu113
tqdm               4.64.0
typing_extensions  4.2.0
urllib3            1.26.9
xmltodict          0.12.0
yq                 2.14.0

The output of nvidia-smi
$ nvidia-smi
Wed Mar 15 13:56:26 2023
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 525.85.12    Driver Version: 525.85.12    CUDA Version: 12.0     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  Tesla T4            On   | 00000000:00:04.0 Off |                    0 |
| N/A   47C    P8    10W /  70W |      2MiB / 15360MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+
|   1  Tesla T4            On   | 00000000:00:05.0 Off |                    0 |
| N/A   58C    P8    10W /  70W |      2MiB / 15360MiB |      0%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

The output of nvcc -V:
$ nvcc -V
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2022 NVIDIA Corporation
Built on Tue_Mar__8_18:18:20_PST_2022
Cuda compilation tools, release 11.6, V11.6.124
Build cuda_11.6.r11.6/compiler.31057947_0

Thank you for your detailed report.
This crash may be caused when all of samples in batch are shorter than batch_max_steps.
And when using multi-gpu, each gpu's batch size will be batch size / #gpus, i.e., the acutual batch size in each gpu will be decreased.
Therefore, the issue more likely to occur.
So in conclusion, this is expected behavior.
To solve this problem, please use remove_short_samples=true or reducing batch_max_steps.

Thanks for your quick reply!
I'll try reducing batch_max_steps since the data is already small and I want to keep all the data as possible.
But I am still a little curious about two more questions.

Does reducing batch_max_steps cause a bad effect on training accuracy?

The crash actually happened after 326 epoch training has finished. But if a gpu batch size being shorter than batch_max_steps will definitely cause a crash, why doesn't the crash happen at the first epoch?

Does reducing batch_max_steps cause a bad effect on training accuracy?

In my experiences, the effect is limited (I tried halved or double). But too short may not be suitable.

But if a gpu batch size being shorter than batch_max_steps will definitely cause a crash, why doesn't the crash happen at the first epoch?

This is because in each epoch the data is shuffled and create new batches.
The crash will be only happened when unfortunately a batch contains only short samples.

Thank you very much! Very easy to understand.


Create DB as normal user before operating on it as admin

Running non-elevated after running elevated on linux hits an exception
Unhandled Exception: Microsoft.Data.Sqlite.SqliteException: SQLite Error 8: 'attempt to write a readonly database'.
   at Microsoft.Data.Sqlite.SqliteException.ThrowExceptionForRC(Int32 rc, sqlite3 db)
   at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior behavior)
   at Microsoft.Data.Sqlite.SqliteCommand.ExecuteNonQuery()
   at Microsoft.Data.Sqlite.SqliteConnectionExtensions.ExecuteNonQuery(SqliteConnection connection, String commandText)
   at Microsoft.Data.Sqlite.SqliteTransaction..ctor(SqliteConnection connection, IsolationLevel isolationLevel)
   at Microsoft.Data.Sqlite.SqliteConnection.BeginTransaction(IsolationLevel isolationLevel)
   at AttackSurfaceAnalyzer.Utils.DatabaseManager.get_Transaction() in D:\a\1\s\Lib\Utils\DatabaseManager.cs:line 178
   at AttackSurfaceAnalyzer.Utils.DatabaseManager.Setup() in D:\a\1\s\Lib\Utils\DatabaseManager.cs:line 72
   at AttackSurfaceAnalyzer.Cli.AttackSurfaceAnalyzerCLI.Main(String[] args) in D:\a\1\s\Cli\Program.cs:line 212

It looks like we either need to create the database itself with non-admin permissions (preferred) or move the admin check earlier (easier).

I did some work to move the admin checks around and I think I covered the original proposal here to simply stop users from seeing this error.


Make the BBS advertise address configurable

Add a config value so the BBS advertise API can be configurable.

Thanks, @alexjh! Could you give some more context on why you'd like this URL in particular to be BOSH-configurable?
In any case, I think the property could benefit from a clearer name. Maybe diego.bbs.advertisement_base_hostname instead of diego.bbs.ad_address_suffix ?
Best,
Eric

Hi @ematpl, we'd like to make it configurable so a different service discovery mechanism can be used. See https://github.com/cloudfoundry-incubator/etcd-release/pull/9 for a similar change.
I've pushed a change with the new property name.

Thanks, @alexjh. Looks like that's the only cf.internal hostname that's still hard-coded in the diego-release job templates, so that makes sense. I'll prioritize this for the team to pull in soon.
Best,
Eric


Update instructions to use MyGet for dev build

Feature Request
And optionally, deprecate master dist-tag.
Package history
Package history at MyGet.
.npmrc
registry=https://botbuilder.myget.org/F/botframework-webchat/npm/

Rough draft
To use dev build,

Create/modify .npmrc locally and set registry
Run npm install botframework-webchat --save
Remove your changes in step 1 to reduce impact on your `package-lock.

@corinagum please verify these steps with a few things.

Look at package-lcok.json to make sure we have minimal impact
Remove node_modules, keep package-lock.json, then do npm install again

This mimic what the user would do on a fresh clone
Make sure npm install is grabbing the right version by drilling into node_modules folder seeing the package.json file inside

Same as step 2, but instead of npm install, run npm ci

Should be the same

Wirte up guides to reverse it back to production version

(I didn't try the following steps)
Run npm install botframework-webchat --save
Make sure everything in package-lock.json is pointing to npmjs.org, and not a single package is point to myget.org
Make sure it grab the 4.4.1 (production, not dev build)

Drill into node_modules folder to see
Don't forget to look at botframework-webchat-core and other packages

Find the string "myget.org" in package-lock.json, make sure no package is affected if the user reverted, super important

I want to confirm with the team whether or not we want to make Web Chat a scoped package. Doing this would allow our users to point to myget for the Web Chat project without having to change the entire project registry to myget. (For example, without scoped packages, changing the registry means that react-scripts, a non-dependency of Web Chat, would also be pointing to myget).
Taking a look at the other BotBuilder projects, it looks like they are not using scope, meaning that we would be the frontier runners in trying this out.
npm scope documentation
@compulim @cwhitten, thoughts?

I'm all for it - but we should connect with the larger framework team on what this scope would be. can we go ahead and cut documentation on how to do this today (no ideal) and start a discussion on creating a bot framework scopes organization?

If I understand correctly, an example flow to the user might look like this:
# Add scope and scope's registry
npm config set @botframework:registry https://botbuilder.myget.org/F/botbuilder-v4-js-daily/npm/

# Retrieve botbuilder from that scope
npm i @botframework/botbuilder

# Install packages from the npm registry
npm i botframework-webchat botbuilder-dialogs

Is this correct?
If we publish our packages with an actual scope (there have been discussions around this) then if someone wanted to scope to our daily feeds they might do the following?
# Add scope and scope's registry
npm config set @botframework-dailies:registry https://botbuilder.myget.org/F/botbuilder-v4-js-daily/npm/

# We've scoped all of our packages to @botframework
# Retrieve @botframework/webchat from regular registry
npm i @botframework/webchat

# Install packages from the dailies
npm i @botframework-dailies/@botframework/botbuilder @botframework-dailies/@botframework/botbuilder-dialogs

@cwhitten in our 1:1 yesterday you mentioned the concern of wanting to mix and match botframework distributions between MyGet and npmjs.
Originally my thought process was that we would have two different scopes, for example @botframework and @botframework-dailies, but after looking into it I believe this would add way too much complication, and therefore we should keep all our packages under the same scope.
If both packages are part of the same scope, it would still be possible with Steven's information above to specify different registries on a case-by-case basis:

We can change the registry for a specific scope; a scope can only have ONE active registry
If we want to install a scoped package from a different registry, we have to use npm i  --registry

This issue is supposed to be closed once my above PR is in, but I will reopen a new issue to continue this conversation.

That sounds good to me @corinagum


Proposal: Add an alternative highlighter

The current highlighter outputs HTML styled code, I am working on D support for an IDE that doesn't use an HTML based text editor and would love to have an alternative highlighter that outputs something simpler. This is just a proposal to start a dialog and I am willing to refactor or rename anything in here.
The format I propose is as following:
One token per line
TYPE, Chars from start of file, Type/Text length
This format is extremely simple and powerful enough for us to highlight on, here's a printscreen of an example file and it's output: http://i.imgur.com/2GY74vl.png
In the future I would love if libdparse could detect that the second "other,26,3" was referring to the name "Foo" that I gave to my class.

 That is never going to be fast.

@BBasile Absolutely.
@Hackerpilot Well the idea was to attempt to compile DScanner into a DLL, load it into the C# based editor as an unmanaged DLL and only run the highlighter on the actively edited parts. Do you have a better solution in mind?

Infact, I guess we could totally skip D-scanner and just link towards libdparser...

This is a much better idea.

Infact, I guess we could totally skip D-scanner and just link towards libdparser...

This is a much better idea.

@Hackerpilot  The lexer you've made in libdparse must allow to parse so there's a token for everything: tok!"++", tok!"--", tok!"abstract", etc. But the lexers used to highlight usually don't need as accurate informations. To highlight one just needs to know if it's an operator, a symbol, a keyword, etc but not which is the specific operator, keyword or symbol.
So if you ( @Pursche ) need a D lexer in C# to highlight I'd suggest you to write one from scratch. It's not so hard. The only things that are a bit annoying with D are

all the string literal kinds
Numbers literals are a bit too
attributes: precise highlighting needs a bit of parsing because for example the keyword const can have 3 semantics ( :scream:) (depending on if it's a type constructor, parameter storage class or function attribute).


Single ESP box appears to be getting duplicated

When flashing the WAS willow build onto the ESP box, I am seeing that it is getting duplicated in WAS:

Additionally seems to be issues in the log, and the unit is stuck in a loop. I'm attaching a log export for reference from the ESP box with full debug enabled. 😃
willow-was-log.txt
Note if this is due to things not yet being ready for WAS please let me know, wasn't sure if I was testing prematurely 😆

In the wasng branch WAS makes sure the client devices returned via API are unique by MAC.


Disable gh-page setup instruction if scripts.deploy has been added

resolve #1221
Disable github page setup instruction if scripts.deploy has been added to package.json
No deploy script
> yarn run build
The build folder is ready to be deployed.
To publish it at http://myname.github.io/myapp, run:

  yarn add --dev gh-pages

Add the following script in your package.json.

    // ...
    "scripts": {
      // ...
      "deploy": "npm run build&&gh-pages -d build"
    }

Then run:

  yarn run deploy

✨  Done in 7.45s.

after added deploy
The project was built assuming it is hosted at /myapp/.
You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
To publish it at http://myname.github.io/myapp, run:

  yarn run deploy

✨  Done in 7.08s.

LGTM!


Missing try{} block not reported as a problem

Steps to reproduce
Write-Output "Test"
catch {
    Continue
}

save it as a file, then run Invoke-ScriptAnalyzer against it.
Expected behavior
An error should be displayed, saying that there's no 'try' block, just 'catch'.
Actual behavior
No error is returned and the script throws an error when executed.
catch : The term 'catch' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a p
 again.
At C:\Users\mchojnac\Desktop\test.ps1:2 char:1
+ catch {
+ ~~~~~
    + CategoryInfo          : ObjectNotFound: (catch:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Environment data

> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1023
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1023
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.19.1

This is a fairly strange one — I'm not sure how many people are accidentally using just a catch block. And by itself, catch is a valid command name.
With that said, it might be useful to warn about commands that could also be keywords. That could also solve https://github.com/PowerShell/PSScriptAnalyzer/issues/1571.
However, given we don't know there's much demand for this and that we're not funded to pick up work like this currently, I'll mark this issue as up-for-grabs.


Swap isn't working

Expected Behavior
Showed swapping
Current Behavior
Access denied
Steps to Reproduce

{"timestamp":"2023-07-04T16:53:17.0536398Z","level":"INFO","fields":{"message":"Logging initialized to C:\Users\xxx\AppData\Roaming\xmr-btc-swap\cli\mainnet\logs"}}
{"timestamp":"2023-07-04T16:53:17.0537955Z","level":"DEBUG","fields":{"message":"Using existing sqlite database."}}
{"timestamp":"2023-07-04T16:53:17.0572665Z","level":"DEBUG","fields":{"message":"Reading in seed from C:\Users\xxx\AppData\Roaming\xmr-btc-swap\cli\mainnet\seed.pem"}}
{"timestamp":"2023-07-04T16:53:21.4548977Z","level":"DEBUG","fields":{"message":"RPC exec path: C:\Users\xxx\AppData\Roaming\xmr-btc-swap\cli\mainnet\monero\monero-wallet-rpc.exe"}}
Error: Access is denied. (os error 5)
Possible Solution (Not obligatory)

Your Environment

Node version : 18.16.1
Operating System and version : windows 10

Are you running the GUI with special privileges? (e.g Administrator)


Ensure secret_key_path files are closed after use

It seems that OpenSSL doesn't close the file handles it's passed, so here the block form of File.open is used instead to ensure the secret files don't remain open in the process.

Coverage increased (+6.9%) to 100.0% when pulling 6baac4624a723fedf9157dd88564b2c96410fc1a on samleb:bug/close-pem-files into bcc6539879a6e43e7ba7a310137b77d2f7a1337b on chriswarren:master.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.15 to before v5.15.25",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c2e5df616e1ae6c2a074cb241ebb65a318ebaf7c",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c377e2ba78d3fe9a1f0b4ec424e75f81da7e81e9"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "c2e5df616e1ae6c2a074cb241ebb65a318ebaf7c",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "c377e2ba78d3fe9a1f0b4ec424e75f81da7e81e9",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "Drivers: hv: vmbus: Fix memory leak in vmbus_add_channel_kobj\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15.25 by commit c377e2ba78d3fe9a1f0b4ec424e75f81da7e81e9, it was introduced in version v4.15 by commit c2e5df616e1ae6c2a074cb241ebb65a318ebaf7c. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000478


@classmethod decorators not being properly treated

Environment data
VS Code version:  1.19.0
Python Extension version:
Python Version:   3.6
OS and version:    osx 10.13
I have a class defined as below
class A(object):
  @classmethod
  def load(cls, pk):
    pass
a = A()

Actual behavior
When I type a.load, cls is still expected as the first argument.
Expected  behavior
I would expect that pk would be expected as the first argument.
Steps to reproduce:
Type the above
Logs
Not really applicable I wouldn't think.
I don't expect every decorator to be handled perfectly, but I would think that @classmethod is common enough that it should be handled properly.

This apparently is a known low priority issue https://github.com/davidhalter/jedi/issues/498 in jedi

Closing as this is an upstream issue which we don't have direct control or influence over.


Update Netflix and Geocaching to hard

Update the following sites to hard:

Netflix: The support page indicates that accounts are now automatically deleted 10 months after membership cancellation or upon request to support.
Geocaching: The support page seems to indicate that by contacting support, it is possible to request permanent account deletion.

The last section of this support talks about contacting them for deletion:
https://www.geocaching.com/help/index.php?pg=kb.chapter&id=27&pgid=102

Thanks for your contribution!


Excluded Routes should suppord Regex

It should be possible to mix regular expressions with fully qualified strings for route exclusion.

Hello @razorness. Thank you for your report, regex is now available on v1.6.1. Feel free to close this issue if it's working for you.