Eliminate relative package locations for nuget

For status checks on the develop branch, please use TransportPackage-Foundation
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=57248)
and run the build against your PR branch with the default parameters.
A new variable is defined in Directory.Build.props for NugetPackageDirectory that can be referenced in csproj and vcxproj files.  This eliminates the need for "[..]*" when defining packa directories.  This is much easier to maintain and eliminates the need to change project files if they are moved around the repo.
There were also instances where wil versions were not using the variables, so those were fixed as well.

/azp run TransportPackage-Foundation

/azp run

There is already a RepoRoot defined in
https://github.com/microsoft/WindowsAppSDK/blob/226235a1013bc917f22654ace73e4e289c92e6bf/build/EnsureOutputLayout.props
I suggest we consolidate it so we don't have two properties doing the same thing.

/azp run

/azp run

/azp run


Added HOMEBREW_ARTIFACT_DOMAIN

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This ENV (HOMEBREW_ARTIFACT_DOMAIN) will allow non-bottled formula to be downloaded from JFrog Artifactory.
Here is how it works:
set value of ENV by export HOMEBREW_ARTIFACT_BOTTLE=https://gcartifactory-us.jfrog.info/artifactory {your JFrog Artifactory URL}
for bottled formula:
brew install mysql
Downloading http://localhost:8080/artifactory/bottles/mysql-5.7.13.el_capitan.bottle.tar.gz
for non-bottle formula:
brew install riak
####Downloading http://localhost:8080/artifactory/bottles/s3.amazonaws.com/downloads.basho.com/riak/2.1/2.1.4/osx/10.8/riak-2.1.4-OSX-x86_64.tar.gz
For more information of JFrog Artifactory: https://www.jfrog.com/confluence/display/RTF/Welcome+to+Artifactory

To summarize, this is what I think a better solution for requested feature.
diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb
index d63b2e6..87fe3cb 100644
--- a/Library/Homebrew/download_strategy.rb
+++ b/Library/Homebrew/download_strategy.rb
@@ -324,6 +324,11 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy

   # Private method, can be overridden if needed.
   def _fetch
+    if ENV["HOMEBREW_ARTIFACT_DOMAIN"]
+      @url.sub!(/^((ht|f)tps?:\/\/)?/, ENV["HOMEBREW_ARTIFACT_DOMAIN"])
+      ohai "Downloading from #{@url}"
+    end
+
     urls = actual_urls
     unless urls.empty?
       ohai "Downloading from #{urls.last}"

@jainishshah17 Could you squash the commits and update manpage?
To update manpage, here is the step.

update Library/Homebrew/manpages/brew.1.md.erb to include this new env variable.
run brew man.

I'm 👍 on the code with a few manpage comments. @xu-cheng you 🆒 with the code?

Squash commits by running brew update; git checkout $YOUR_BRANCH; git rebase --interactive origin/master and then mark each commit other than the first as squash or fixup then git push -f. Thanks!

@jainishshah17 Looks like your squash didn't work properly, there's loads of unrelated changes here.

@MikeMcQuaid : my squash is not working. Can you suggest me any alternative or do I need to create new PR?

@jainishshah17 What happened when you ran those commands? Please elaborate on "not working". Thanks!

@MikeMcQuaid: It looks good now.

Added in e195f493b271efeb4c73af094c4c4daad931253c with the brew man changes and a better commit message. Thanks @jainishshah17!


Pre-trained Model

Hi @FuxiCV , Thanks for your work. Would you please share the pre-trained model and the testing code?
Thanks

I have the same request，Thank you.

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Hi,coulde you sucessfully test the model?

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

Hi,coulde you sucessfully test the model?

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

hi,can you sucecessfully test?

Same as above, would appreciate the pre-trained model and the testing code. Thanks in advance!

hi,can you sucecessfully test?

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

Hi,Do you successfully prepare the dataset for training or testing?

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

Hi,Do you successfully prepare the dataset for training or testing?

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

Hi,Do you successfully prepare the dataset for training or testing?
would you like share experiment with me?

@cyjouc I haven't successfully tested the code yet, as there's still no reponse about the pretrained model or else.

Hi,Do you successfully prepare the dataset for training or testing?
would you like share experiment with me?


JetBrains IntelliJ IDEA: Error running Prettier

I installed prettier globally and then followed the examples for setting up Prettier as an External Tool in JetBrains IntelliJ IDEA, but when I run it I get the following error:
Error running Prettier:
Cannot run program "prettier" (in directory "/Users/geraldfullam/projects/prettier-test"): error=2, No such file or directory

Any ideas?

Never mind. I had a failed global install. Retried and it is working.

I reinstalled global prettier, but still have the issue :(


Rendering each markdown cell causes incorrect section headers

I just discovered a bug (from a user's perspective) that is technically a feature in rST :-P
I just noticed that the top-level markdown header of each cell in the notebook is being treated as an H1 header for the whole document, even if the header text is technically ##.
e.g. see how Sphinx thinks there are multiple page titles for the single notebook document that is here: https://sphinx-jupyter-notebook.readthedocs.io/en/latest/
I think this is because of Sphinx deciding on page titles etc based on the order in which headers happen, so if we parse a cell with only a single ## header, Sphinx will treat that as a document-level header.
e.g., note how the Sphinx document output is the same whether the two headers have different numbers of # symbols.

So from a docutils perspective, we need to make sure that cells that are sub-sections are nested properly. Even though notebooks have a single top-level hierarchy, docutils doesn't.
@chrisjsewell does that sound correct to you? Any ideas on the right way to do this?

Two ideas for how we could handle it:

Keep track of the depth of docutils tree we should be in each time we parse a cell, and make sure that we insert the resulting docutils objects at the correct depth
Convert the ipynb file into a MyST markdown representation and parse that (though then we'd lose things like cell/line numbers?)

So here https://github.com/ExecutableBookProject/sphinx-notebook/blob/80569087613cc09e84e980012e9d4feb94aaf827/sphinx_notebook/parser.py#L50
You initialise a new renderer for every cell. This obviously wipes any internal state, including self._level_to_elem.
You should probably rework the code so that the render is instantiated once, and just change the current_node before parsing new text.

One thing that should be checked/documented at the myst_parser level, is that the docutils.RstParser specifically prohibits transitions from 'non-consecutive' header levels, e.g.
# Title h1

### Title h3

If think with myst, this will probably end up being the same as:
# Title h1

## Title h2

I should check this, and decide how to handle it, e.g. would sphinx be happy with 'virtual' sections being added that don't have a <title> child.

Two other things:

Because you are using myst_ast = Document(cell["source"]) to parse cells, for each cell a front_matter YAML block will be looked for. This probably doesn't make sense at a cell level, as you could end up with multiple front matter blocks that obviously doesn't make sense. You should think about parsing at a lower level (take a look what Document actually does), and having an (optional) key in the notebook level metadata that relates to this front matter, and parse it to render_front_matter().
As I've mentioned somewhere before, currently docutils will report any parsing errors by line number, but obviously won't tell you what cell that line was in. You should think about how to override docutils.utils.Reporter.system_message, to also report the cell number.

You should probably rework the code so that the render is instantiated once, and just change the current_node before parsing new text.

Is that as straightforward as updating the attribute directly by assigning a new node?

Yeh should be

hmmm, I just tried doing:
renderer = SphinxRenderer(document=document, current_node=None)

and in the cell loop:
# also tried assigning directly
renderer.set_current_node(cell_input)

And I got this error:
Exception occurred:
  File "/c/Users/chold/Dropbox/github/forks/python/ebp/myst_parser/myst_parser/docutils_renderer.py", line 142, in render_paragraph
    para.line = token.range[0]
AttributeError: 'Paragraph' object has no attribute 'range'

Oh no you don't have to use set_current_node, thats a context manager for transiently setting the current node whilst parsing children tokens. It should probably be rename with_current_node.
Just literally do renderer.current_node = cell_input

I did that, got the same error :-/
I'm doing:
            # If a markdown cell, simply call the Myst parser and append children
            if cell["cell_type"] == "markdown":
                # Initialize the render so that it'll append things to our current cell
                renderer.current_node = cell_input
                with renderer:
                    # TODO: This shouldn't be `Document` because it'll look for yaml frontmatter
                    #       Should be something else but need to see how myst parser does it.
                    myst_ast = Document(cell["source"])
                    renderer.render(myst_ast)

Ah yeh, you need to use the with renderer for the entire notebook parse, because on exit it resets the parsing tokens to the standard ones used by mistletoe (not the myst specific ones). This context manager behaviour is from the mistletoe BaseRenderer, but probably should be improved so that the myst tokens are reinstated on entrance.

ahhh that got it


addPage() orientation is inverted, and a question

https://github.com/MrRio/jsPDF/blob/63f89d47d1cd60091e62d6d51570f78f27d01a23/dist/jspdf.umd.js#L3704-L3715
the format is inverted, and why now i can't use addPage(param1, param2) like in the parallax site?

And why do i need to use this code to use jsPDF?
var jsPDF = jspdf.jsPDF

And why do i need to use this code to use jsPDF?
var jsPDF = jspdf.jsPDF

the format is inverted

Yes, I don't like this either. That's some legacy code we should probably change with the next major release.

why now i can't use addPage(param1, param2) like in the parallax site?

What do you mean by that? addPage accepts two parameters: format and orientation.

And why do i need to use this code to use jsPDF?
var jsPDF = jspdf.jsPDF

This is a change that was introduced with 2.0.0 to make the UMD variant of the library consistent with the es modules variant. It also allows to "export" other toplevel objects/types/functions than jsPDF. If you use es modules (strongly recommended, the UMD module format is outdated), you don't need this line. You can import jsPDF directly:
import { jsPDF } from 'jspdf'

the format is inverted

Yes, I don't like this either. That's some legacy code we should probably change with the next major release.

why now i can't use addPage(param1, param2) like in the parallax site?

What do you mean by that? addPage accepts two parameters: format and orientation.

And why do i need to use this code to use jsPDF?
var jsPDF = jspdf.jsPDF

This is a change that was introduced with 2.0.0 to make the UMD variant of the library consistent with the es modules variant. It also allows to "export" other toplevel objects/types/functions than jsPDF. If you use es modules (strongly recommended, the UMD module format is outdated), you don't need this line. You can import jsPDF directly:
import { jsPDF } from 'jspdf'

Thank you for answering. So what i meant by addPage(param1, param2) is was orientation param changed to an array? Because in parallax it wasn't an array

Thank you for answering. So what i meant by addPage(param1, param2) is was orientation param changed to an array? Because in parallax it wasn't an array

It IS an array, sorry i wasn't reading the module

It IS an array, sorry i wasn't reading the module


Fix Playwright test failures when Nuxt context is not available

Fixes

Fixes #4737 by @obulat
Description

The failures were caused by race conditions when setting up the feature flag store.
When setting up the state, we need the runtimeConfig's deploymentEnv to compute the feature flag statuses and states. Sometimes it was called when the Nuxt context necessary for useRuntimeConfig wasn't available, and this caused errors down the line. This only happened on the server.
This PR adds a check if the Nuxt app context is available to the feature flags store. If it's not available, it is possible to get the deploymentEnv from the runtime env variable (NUXT_PUBLIC_DEPLOYMENT_ENV). It also throws an error when the env variable is not available - but that should never happen.
Some code is also refactored to avoid calling feature flag store from deeply nested functions (e.g., function that is called by the function returned from createApiService, which is called by the media store) as that could cause loss of Nuxt context (more on this in the Nuxt docs)
Testing Instructions

See that the latest Playwright CI runs in this PR ran successfully. I will run the tests several times.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

It's a bit of a shame to have to repeat the fake_sensitivity logic in four different stores. I hate to block this but I think a light abstraction, like the following composable would help prevent us from missing one of those in the future, and also making it easier to pass future values to the api client.
import { useNuxtApp } from '#imports'
import { useFeatureFlagStore } from '~/stores/feature-flag'
import { createApiClient } from '~/data/api-service'

export function useApiClient() {
  const { $openverseApiToken: accessToken } = useNuxtApp()
  const featureFlagStore = useFeatureFlagStore()

  const fakeSensitive =
    featureFlagStore.isOn('fake_sensitive') &&
    featureFlagStore.isOn('fetch_sensitive')

  return createApiClient({ accessToken, fakeSensitive })
}

Awesome idea, added here. Thanks!


[WIP] Adds Prometheus metrics to ODIS combiner daemon (Odis Combiner to k8s)

Description

Adds a new endpoint /metrics to ODIS combiner to expose metrics.
Docker images:
Moves dockerfiles/phone-number-privacy/Dockerfile to dockerfiles/phone-number-privacy/Dockerfile-signer for the signer container.
Adds dockerfiles/phone-number-privacy/Dockerfile-combiner for the combiner container.
Modifies cloudbuild.yaml accordingly.

WIP (more commits to come):
Adds the following counters and histograms:

Counter combiner_requests_total
Counter combiner_responses_total
Counter combiner_blockchain_errors_total
Counter combiner_bls_compute_errors_total
Counter combiner_endpoint_handler_errors_total
Histogram combiner_endpoint_latency
Histogram combiner_full_node_latency

Current metrics can be seen here: https://clabs.grafana.net/goto/2qF4RaWSg?orgId=1
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues

Fixes #[issue number here]

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change

I'd be in favor of sunsetting cloud-build and replacing by GitHub Actions.
Happy to address that in a separate PR.


[TEST] Analyze failed e2e cases in master-head pipeline

What's the test to develop? Please describe
Recently master-head pipeline have some failed cases (build 227, 228, 229,  ~ 242)

test_ha.test_autosalvage_with_data_locality_enabled

https://github.com/longhorn/longhorn/issues/4489

test_basic.test_backup_labels and related failure

https://github.com/longhorn/longhorn/issues/4535
https://github.com/longhorn/longhorn-tests/pull/1098

test_cloning.test_cloning_with_detached_source_volume

20 time on local and can not reproduce

test_backing_image.test_exporting_backing_image_from_volume

20 time on local and can not reproduce

test_ha.test_rebuild_with_restoration

https://github.com/longhorn/longhorn/issues/4488, https://github.com/longhorn/longhorn-tests/pull/1085

test_cloning.test_cloning_interrupted

https://github.com/longhorn/longhorn-tests/pull/1083

Describe the items of the test development (DoD, definition of done) you'd like

[x] Create ticket if the failure is bug
[ ] Fix them if the failure were flaky

Additional context
N/A

This one is updated, I will create new one for tracking latest master-head pipeline test result


[FEATURE] wating some time before delete pod

What feature you'd like to add:
Wating some time before delete pod.
The delay time should be considered config in PV.
Why is this feature needed:
We has this business situation:
Mounting a pv and stop after run for a short time, and then remounting this pv again.
This cause a lot of Mounting Pod Start which has a very low efficiency.

Sounds good!

fix by https://github.com/juicedata/juicefs-csi-driver/pull/267


Should the filter :hover class when you mouse over a pulldown option be reversed out red?

Kind of like the buttons?

Yes. I'll give that a shot.


Paddlemate Sensor support

Varga Mate (UTE kayak club) drew my attention to the https://thepaddlemate.com/products/tracker-kayak/ sensor. It is sensor pair stuck on the paddle shafts (both left and right sides) which I assume measure shaft distortion and provide data somewhat similar to bike crank arm power meters (plus maybe also accelerometer data).
I need to look into how we can support it.

Note: once #505 is implemented, this could be a 3rd way of providing detailed data (drive, recovery, force curve) besides C2 RowErg and Abasz ESP RowErg.


Improve http connection to external API's

urllib package can be replaced with requests package - https://docs.python.org/3/library/urllib.request.html#module-urllib.request
Also, we were having a 403 response code while invoking https://emergencias.pt/data and https://api-dev.fogos.pt

Merged and Closed @cardosojc!


Future naming issue ?

Hi, i love kafka-ui i think it will be the best UI for Kafka when all features roadmap will be implemented.
Just a quick remark,
i think you will have an issue in the future with the "kafka" naming in your project (like Kafka manager (CMAK) and Kafka HQ (AKHQ) before you). CMAK issue
The apache kafka community will probably ask you to rebrand your project.
I think sooner is better, before it's becoming the most used open source UI for kafka 👍

Hey, thanks for your kind words. Glad you like it :)
Regarding the naming, we're well aware , and it seems to be okay for now. Thanks for letting us know, tho.

sorry for the duplicate.
continue the good work !


Wrong variable type

Hi,
In file SGFFDecoder.m:
@property (nonatomic, assign) bool selectAudioTrackIndex;
selectAudioTrackIndex are not a bool but an integer.
Correct declaration:
@property (nonatomic, assign) int selectAudioTrackIndex;

Thanks!
On Mon, 5 Jun 2017 at 20:34 eric@skrobs <EMAIL_ADDRESS>wrote:

Hi,
In file SGFFDecoder.m:
@property (nonatomic, assign) bool selectAudioTrackIndex;
selectAudioTrackIndex are not a bool but an integer.
Correct declaration:
@property (nonatomic, assign) int selectAudioTrackIndex;
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/libobjc/SGPlayer/issues/16, or mute the thread
https://github.com/notifications/unsubscribe-auth/ALfXuzTkFUEEIVpPEbCm05P0tnhtYjfcks5sA_W9gaJpZM4Nv-sG
.


[SNMP]Need to create Github documentation

Moving the issue from https://github.com/wso2-extensions/esb-connector-snmp/issues/12

We have docs in the doc space https://mi.docs.wso2.com/en/latest/reference/connectors/smpp-connector/smpp-connector-overview/


[stable/nginx-ingress] Update ports

What this PR does / why we need it:

Make port configurations consistent
Use named ports to refer to target ports from services

/assign @lachie83

/lgtm


[GUI] Remove templates filter on device creation screen

@betefaber could you test this issue again? I can not reproduce


Hooks for auto update?

First, thanks for creating AppUpdater!
I'm trying to use it in my app, and want to use periodic check + auto update as my app mostly runs in the background. I'm wondering if it's possible to add some hooks for auto update, similar to the hooks for manual check/update.
For example:

Finds a new release (with version and some key info, ditto for the following hooks)
Does not find a new release
Successfully installs a new release
Fails to install a new release

Thanks laike.
After considered it, I think these hooks are necessary and easy to implement.
I will schedule it after wrapping up these few days of work. And a PR is also welcome If you want.

Awesome, thanks!
I'm still quite new to Swift, but I can help take a look at the PR once you have it :)

That's good❤

Just check to see if there's any update, but no rush 😀

Just check to see if there's any update, but no rush 😀

Just updated, version 0.1.2, see:
https://github.com/s1ntoneli/AppUpdater/commit/11b83c2bb91078b2eba27fb0a12e7a075a64099e

Thanks! Will try to integrate it to my app


Add more unknown variants

Decided to not merge this one. Unknown variants are useful for enums that are likely to change between updates, but most of these already handle unknown variants. Other enums are just not likely to be updated without a major change like Odyssey. Also in general if a log entry is not parsed correctly it should be catched by the LogContent enum.


Skip yarn lockfiles in GAE deploys

A non-forked copy of #130

Did you consider deleting yarn.lock from the repo entirely? As noted in https://github.com/GoogleCloudPlatform/nodejs-getting-started/issues/129, it's not obvious to me why we should keep a lockfile around that will get ignored when building anyways..

Our instructions still mention yarn. That can be changed of course - but would require additional work + research.

Valid point.
Food for thought, if a dev uses yarn locally while following those instructions, might even install new dependencies, npm will be used when building in the cloud since yarns lockfile is ignored 🙁

I'm in favor of deleting the lock files from the repo entirely.

Agreed, that sounds like the way to go. If there's no lockfiles present when installing packages listed in package.json, both npm and yarn will create lockfiles after all dependencies has been installed. Therefore no need to ignore any lockfile in app.yaml since only one of them will be present, and that lockfile will also be used when building -- sounds like great success to me.

Cool. I'll close these PRs and make this change in #124 (since this is blocking that PR, and #124 is almost - but not quite - finished).


Alexa discovery updates

I@ve just synchronised my fork and noticed that the Alexa discovery was still not working in the main repository.  I've included the necessary changes to correct this, namely a new function that formats the returned json to alexa on discovery and corrected the case of one of the SSDP attributes, as observed on the network

Hi @Quanghoster . This pull request overrides mine https://github.com/probonopd/ESP8266HueEmulator/pull/85
If you revert your changes and merge from master, you will be able to see the hue by Alexa. I can say that since I had an Alexa meanwhile

Hmm, strange. I thought I have brought.my fork up to date with your repository before I tested it with alexa and it didn't work for me last night. Github is confusing On 20 Oct 2017 08:51, Daniel<EMAIL_ADDRESS>wrote:Hi @Quanghoster . This pull request overrides mine #85
If you revert your changes and merge from master, you will be able to see the hue by Alexa. I can say that since I had an Alexa meanwhile
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

You can see https://github.com/probonopd/ESP8266HueEmulator/pull/85/commits/6c63513c8bce384f40ca73789fb07dd681f49897#diff-e15aea686d057abe4787cdfd553060f8R1040 . Along with your suggestions, I added support for dimmable light.
Have a look at the link, and make a comparison please.

Ok, I must have completed the fork sync incorrectly.  I'm managed to get it in sync and it now works without modification.  Thanks 👍

So how should we proceed with this PR?

We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests,  which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd<EMAIL_ADDRESS>wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

If I find the issue I will post an updated PR with the change On 21 Oct 2017 10:58, Andy Dennis<EMAIL_ADDRESS>wrote:We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests,  which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd<EMAIL_ADDRESS>wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

Closing this PR as suggested by @Quanghoster. Please open a new one. Thanks.

Once I have figured this part out I'll put some time in to spiffs On 21 Oct 2017 11:16, Andy Dennis<EMAIL_ADDRESS>wrote:If I find the issue I will post an updated PR with the change On 21 Oct 2017 10:58, Andy Dennis<EMAIL_ADDRESS>wrote:We should cancel this one, however that is done. However, I don't think the code is quite right still. The master now does discover correctly but I don't think is correctly responding to the echo turn on and off requests,  which I had also fixed in my repository. I need to check the cause of that over the next couple of days, when I can fit it in. I think that may be the reason for the json format change I added in this PR On 21 Oct 2017 10:05, probonopd<EMAIL_ADDRESS>wrote:So how should we proceed with this PR?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.


Docker

Pull Request
What type of PR is this? (check all applicable)

[x] Refactor
[ ] Feature
[ ] Bug Fix
[x] Optimization
[x] Documentation Update

Description
Related Tickets & Documents
After much pain it works.

Related Issue #
Closes #

Add a table of contents to the readme


Handle error with pgbouncer=true, PgBouncer 1.21.0 and max_prepared_statements >0: prepared statement "PGBOUNCER_x" does not exist

As described in https://github.com/prisma/prisma/issues/21635, when using PgBouncer 1.21.0 with max_prepared_statements configured to a value >0 (so the new named prepared statements support being activated) and pgbouncer=true set in the connection string, you end up getting hard errors from your databases:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(PostgresError {
 code: “26000”, message: “prepared statement "PGBOUNCER_3" does not exist”,
 severity: “ERROR”, detail: None, column: None, hint: None }), transient: false }) {

The solution here is (probably, investigation ongoing in https://github.com/prisma/prisma/issues/21531) to drop pgbouncer=true from the connection string to not use our legacy PgBouncer mode any more.
As this is not obvious from the error message, we probably want to catch and match that error message and output a helpful message. Draft:

The database you are connecting to seems to use PgBouncer with version >=1.21.0 and name prepared statements support configured (max_prepared_statements > 0). You do not need to use PgBouncer mode with Prisma any more and can remove pgbouncer=true from your connection string. (Make sure to apply this change to all instances of Prisma Client that are talking to that database, or you will encounter further errors.)

contributes to https://github.com/prisma/prisma/issues/21635 and https://github.com/prisma/prisma/issues/21531

I am facing the same issue. What is the recommended fix to still be able to use pgbounce pool with prisma? (pgbounce set to transactional mode)

This is an improvement request, not a bug report. Please open a new bug issue and describe your problem.

Ugh, it doesn't work with the current version of PgBouncer. How is that not a bug?

Can you be more specific @wflanagan? Recent versions of PgBouncer, configured appropriately, should just work out of the box with Prisma with not legacy pgbouncer=true required.


[Release Radar Request] React95 🕹🌈

Open Source Project name
React95
What is your project?
Windows 95 style UI component library for React ❤

Version
4.0
Date
13 November
Description of breaking changes

Web version completely rewritten with TypeScript.
Released v1.0 of the React Native version

GitHub Repo
https://github.com/react95-io/React95
Website
https://react95.io/
Link to changelog
https://github.com/react95-io/React95/releases/tag/v4.0.0
Social media
https://twitter.com/react95_io/status/1591845891299999744?s=20&t=0JSaywgjjTOI87a_X5cYNg
Anything else to add?
No response

Congrats on being featured in the November 2022 Release Radar 🥳

Read the blog here
Check out our GitHub Tweet


Feature/change readme

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] Branch name follows type/descript (e.g. feature/add-llm-agents)
[ ] Ready for code review

ℹ Additional Information

still cannot solve conflict.


Avatarify desktop responding slow

Stable and updated avatarify for all computer .
You can also watch my installation video that shows you how to do it yourself here on my youtube channel https://youtube.com/shorts/keEIZVnbT48?si=ZRTpms5p6HaWU83N Or simply ask for help from my whatsapp contact
+2347081306010
If you also have any problem with avatarify .
Contact me for solutions 100% results on apple macbook and any windows.

The video is no longer available through the mentioned link. Is it possible to see the video elsewhere?
Thank you

i can help anyone facing this issue you dont need to pay for anything

Message me on WhatsApp to help you resolve your avatarify issue and make your avatars have a sharp response
WhatsApp +2347081306010


[Samples][Cleanup] Organize samples under Samples\Tests

There are now quite a few samples under Samples\Tests, and they are not particularly well organized. This issue tracks updating them to follow naming conventions and\or sort them appropriately by version. This will help us be able to use them more easily for bug bashes or other testing.

@RebeccaAnne should this be closed now?


Support for AppSync Lambda Resolver

I would like to add support for the AppSync Lambda Resolver.
Lambda is called with the following type in AppSync.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/aws-lambda/trigger/appsync-resolver.d.ts#L3-L6
It is possible to implement a resolver without using Appolo. However, I would appreciate it if it could be implemented using the same interface.
Thank you for considering this.

Will be supported with #67 which will allow for custom defined handlers

#67 is now ready for review if you want to take a look. Look at the README.md updates to see how this might be implemented.

Thanks for the quick reply.
I have looked at the README for #67.
It certainly looks like it could be handled by creating a custom request handler.
I will try it later.
And I close this issue.
Thank you very much in advance.


System unavailable: docker&&linux&&x86_64 not available docker-aws-ubuntu1604-x64-0/-2

Please put the system name in the title of this issue.
docker-aws-ubuntu1604-x64-0 docker-aws-ubuntu1604-x64-1 docker-aws-ubuntu1604-x64-2

Link to any log file showing the problem:

Please describe the issue:
when using label 'docker&&linux&&x86_64'  found no jenkins agent available.
by looking at all 3 nodes, one is offline intentionally , but other two seems have issue to start jenkins process

I am testing the installer job,
the debian build stage cannot find agent.

I am testing the installer job, the debian build stage cannot find agent.

Same question - which job is this affecting? The Linux installer generator job adoptium-packages-linux-pipeline is not being held up because of this issue as far as I can tell.

this is the test job  https://ci.adoptopenjdk.net/view/work-in-progress/job/Sophia-adoptium-packages-linux-pipeline/
not using the official "installer" job

this is the test job https://ci.adoptopenjdk.net/view/work-in-progress/job/Sophia-adoptium-packages-linux-pipeline/ not using the official "installer" job

I don't know why that's targetting different machines. I don't particularly want to recover machines running those out of support OSs. If they're not causing a problem with any critical jobs I'm just going to decomission those systems (as per the comment you've seen on one of them)

this is the test job https://ci.adoptopenjdk.net/view/work-in-progress/job/Sophia-adoptium-packages-linux-pipeline/ not using the official "installer" job

I don't know why that's targetting different machines. I don't particularly want to recover machines running those out of support OSs. If they're not causing a problem with any critical jobs I'm just going to decomission those systems (as per the comment you've seen on one of them)

sure. if agents are not needed/supposed to be there, we either remove them or put message as description  to not cause confusion.

Adding extras will be covered as part of https://github.com/adoptium/infrastructure/issues/3482


Added Wheel-Selector

Closes: #542

Title : Wheel-Selector
Name: : Heli Detroja
Idenitfy yourself: : GSSOC Contributor

Describe the add-ons or changes you've made 📃
This project aims to provide a fun and random way to select items from a user-defined list, demonstrating practical use of JavaScript for dynamic content interaction and CSS for modern design effects.
How Has This Been Tested? ⚙

I have tested it on my own.
Screenshots 📷

Type of change ☑

What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

Checklist: ☑

[X] My code follows the Contributing Guidelines & Code of Conduct of this project.
[X] This PR does not contain plagiarized content.
[X] I have performed a self-review of my code.
[X] I have commented on my code, particularly wherever it was hard to understand.
[X] My changes generate no new warnings.

Note to reviewers 📄

Why have you left out commented code?

I forgot to remove it, now it's all done


Convert to MIT

I agree with converting my current commits:

https://github.com/emortalmc/LazerTag/commit/f457641d387c84369f37a73983044fb967117e49
https://github.com/emortalmc/LazerTag/commit/788670b6568a0354c7f268713d651609159b0f92
https://github.com/emortalmc/LazerTag/commit/f81ecd41c5d5dd5c380c440b058c1e27b4869470

@LooFifteen, @emortaldev  do you agree with moving your code changes to MIT?

I agree to change to MIT, the superior license.

woo


Fix typo in README.md

Pressing 'q' will display the current URL as a QR code.

Thanks for spotting that!


setAppElement throws error in tests

Summary:
When running in test, the lib/helpers/ariaAppHider.js:24 throws:
Error: react-modal: No elements were found for selector #app.
Expected behavior:
Should not throw errors in test.

Have you tried to set Modal.setAppElement on you tests?

I had the same issue,
Work around of it like this
if (this.props.modalApp) {
            Modal.setAppElement(this.props.modalApp);  //'#app'
        }

@daru23 @nickaversano #668 should fix this on testing environments.
I'll close this for clean up. Reopen this issue if that didn't solve this case.
Thanks!

I just ended up dropping this on the modal:
ariaHideApp={ !process.env.NODE_ENV === 'test' }

@diasbruno I still have the issue, running on 3.6.1.
When you said that it should fix the issue, you meant with no aditional code, right?

I too am having the same issue, #668 didn't fix this for me.

You can get around this issue by stubbing document.querySelectorAll in your tests:
  beforeEach(() => {
    document.querySelectorAll = () => ["node"];
  });

I got rid of the error in a dumb way.
import * as Modal from 'react-modal';

it('renders without crashing', () => {
    Modal.setAppElement = () => null;
    ReactDOM.render(<Foo />, div);
});

I got similar error . i am using  jest so i decided to follow below solution
Solution:
setup global mock for React Modal and override setAppElement method
//__mocks__/react-modal.js
const Modal = require('react-modal')

const oldFn = Modal.setAppElement
Modal.setAppElement = element => {
  if (element !== '#___gatsby') oldFn(element)
}
module.exports = Modal

was able to work around the error by setting appElement directly on the modal.
    <Modal
      appElement={document.querySelector('#app)}
    >

Guys, you can just simply set a mock function for this and get out of this. taddaaaa
jest
  .spyOn(Modal, "setAppElement")
  .mockImplementation(url => console.log(`setAppElement:'${url}'`));

Happy coding!!

In order to fix this issue, I did the following in all my components that use react-modal:
if (process.env.NODE_ENV !== 'test') ReactModal.setAppElement('#app');

Where should I put this line of code

Will this problem ever be fully addressed?

@frankstepanski Do you have some spare time to investigate this?

We use a jest-flavoured version of @elle-the-dev's solution:
import ReactModal from 'react-modal';
jest.spyOn(ReactModal, 'setAppElement').mockImplementation(() => null);

This works for me 😳
jest.mock('react-modal', () => ({
...jest.requireActual('react-modal'),
setAppElement: () => {}
}))

Maybe for someone, it could be useful. I have a common library for all my projects and actually, there I keep my component which uses 'react-modal' inside, some kind of wrapper for my purposes.
So when I test it on the level of library
if (process.env.NODE_ENV !== 'test') ReactModal.setAppElement('#root');
usually enough, but when I test my client projects, where I use the final 'react-modal' wrapper, it doesn't work.
Considering, that modal can be imported dynamically I do this via lazy import.
const CodeBaseModal = React.lazy(() => import('@some-library/modal'));
or you can do that
const ReactModal= React.lazy(() => import('react-modal'));
Hope it helps.


python38Packages.flufl_i18n: 3.1.5 -> 3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.flufl_i18n is: ""
meta.homepage for python38Packages.flufl_i18n is: ""
meta.changelog for python38Packages.flufl_i18n is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.2 with grep in /nix/store/vzjjk6gp1dcc18m466rz8i6plnwqfaa7-python3.8-flufl.i18n-3.2

found 3.2 in filename of file in /nix/store/vzjjk6gp1dcc18m466rz8i6plnwqfaa7-python3.8-flufl.i18n-3.2

directory tree listing: https://gist.github.com/c44243226b7d56403580aebd0725c230

du listing: https://gist.github.com/479898ac7b0767f385c67fa31b8a81cb

Rebuild report (if merged into master) (click to expand)

28 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
7 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
mailman
python38Packages.flufl_i18n
python38Packages.mailman
python38Packages.mailman-hyperkitty
python39Packages.flufl_i18n
python39Packages.mailman
python39Packages.mailman-hyperkitty

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vzjjk6gp1dcc18m466rz8i6plnwqfaa7-python3.8-flufl.i18n-3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.flufl_i18n https://github.com/r-ryantm/nixpkgs/archive/40ef4b47aa4e67303fc7af2f2a7f4407e45e4d46.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vzjjk6gp1dcc18m466rz8i6plnwqfaa7-python3.8-flufl.i18n-3.2
ls -la /nix/store/vzjjk6gp1dcc18m466rz8i6plnwqfaa7-python3.8-flufl.i18n-3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages failed to build:

mailman
python38Packages.mailman
python38Packages.mailman-hyperkitty
python39Packages.mailman
python39Packages.mailman-hyperkitty

2 packages built:

python38Packages.flufl_i18n
python39Packages.flufl_i18n

Maintainer pings

Result of nixpkgs-review pr 137619 at 40ef4b47 run on aarch64-linux 1

5 packages failed to build:

mailman
python38Packages.mailman
python38Packages.mailman-hyperkitty
python39Packages.mailman
python39Packages.mailman-hyperkitty

2 packages built successfully:

python38Packages.flufl_i18n
python39Packages.flufl_i18n

2 suggestions:

warning: license-missing
Package is missing a license.
Near pkgs/development/python-modules/flufl/i18n.nix:9:3:
  |
9 |   doCheck = false;
  |   ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/flufl/i18n.nix:9:3:
  |
9 |   doCheck = false;
  |   ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Is it possible to block a user using the dA API?

I looked through the documentation and couldn't find any reference to this.  Is there a way to use the dA API to block a user?

not available in API


Calculate class hashes when building

fix #1163
I think there are two options here (at least):

return the class hash when the build command is called
create a new command that will calculate the contract's class hash

I think the former is simpler and would go that way, but I'm open to suggestions.
If we proceed with this, we may want to make outputting the class hash optional as it may not always be needed.
TODO:

[ ] consider printing the class hash optional (do it only when the user provides a flag like --print-class-hash)
[ ] docs
[x] think of integration/e2e tests

Good job! Can we write an integration or e2e test testing that?

Thanks! I added writing tests to the todo list in the description, I will take care of this along with the docs.

I'm not sure whether an integration test is necessary here. The change impacts only what users see I don't see a change in how the parts of the application work together. If you think otherwise, please, let me know.

I also took a look at the docs and it doesn't seem like they need to be updated, but I might've missed something. In the CLI reference, there are no mentions for other commands like declare or deploy of what they return. In other docs where the build command is mentioned, the output doesn't seem to be used and there are no cases for this.
I was also thinking about this:

consider printing the class hash optional

and I think we can leave this as is, which means the class hash will always be printed out. I think this works the same for declare and deploy.
I'm going to treat the current state of this PR as a final one. Again, if you disagree, feel free to share your opinion. Thanks.


component reference from library

zoom in to see ports and port descriptions, potentially even sending test data through to see output

Re: #34 needs work in noflo

Really liking this idea. Has come up several times as 'having a (visual) datasheet' for them.
Now that we have fbp-spec support with declarative and parse-able tests - we could integrate that somehow.

I'm imagining something like Jupyter/iPython-like notebooks as 'visual datasheets'. Someone can start creating a component as a notebook, specify its inports/outports at some point and use it as a real component, keeping the notes as documentation (after some possible clean up).

I think the key wrt to interactive creation of such visual datasheets, is to be able to select representative data from what has been executed before, and mark it as belonging to the datasheet. This could be a kind of 'add as fbp-spec testcase' action. Right now we don't have ability to select/act on data in the past in the UI.
As the component/graph may have changed since that input/output data was generated, I think it should re-execute, to (re)build the datasheet/docs. Built datasheet should probably be HTML (possibly incl PNG/SVG).


Create First_java_code.java

📑 Description
copilot:summary
🐞 Related Issue

Closes #
📋 Explanation of changes
copilot:walkthrough
copilot:poem

Hi @Sanober494 ,
Thank you for your contribution. However, it would be really helpful if you could mention the issue number that your pull request is addressing. This will make it easier for us to track the progress and context of the issue. You can do this by adding #issue_number in your pull request description.
For example:
Closes #issue_number

This will automatically link your pull request to the issue and help us maintain a clean and efficient project management workflow.
Thank you for your understanding and cooperation.


More Brain-Flak debug flags

I intend on expanding on the existing debug flags.  There are three flags I intend on adding.

[x] Full stack print.  I would like a flag that prints both stacks at once.
[x] Print cycles.  Prints the number of steps taken so far.
[x] Inject code.  This will be the most complicated of the three.  It will stop the program, accept user input and then execute the user input as code before resuming.

Finished with commit eb57a71426e7267f091c345fe79b1dfa3f40fbe5

Not yet finished.  Need to merge first.

Properly merged


Import categories - Column is out of page when importing txt file

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: https://github.com/Expensify/App/pull/47827
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to Control workspace settings > Categories.
Click 3-dot menu.
Click Import spreadsheet.
Import the following txt file.

Expected Result:
The column will be wrapped properly.
Actual Result:
The column is out of page.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/fe913f91-05fc-4cd7-97fc-73f47a4bc547
0409.txt
Add any screenshot/video evidence

View all open jobs on GitHub

cc @filip-solecki @rushatgabhane @rlinoz coming from the import spreadsheet PR

@filip-solecki can handle this one, I think we can treat this as a blocker

Thanks Vit

I'm still able to reproduce this issue when importing a .txt file

Demoting this as the files used to reproduce this are not really files that real user would use for this feature. So its edge case ad absurdum and we can discuss if we want to somehow validate the file contents and throw error in cases like this or do nothing

The text in this column is overflowing because it's too long or all on one line. You can fix it by adding this CSS property word-break: break-all; I've also attached a screen recording for you to check.
https://www.loom.com/share/e7a7d987384c46438cedc2fe7c8eb50d?sid=f1e9a455-9434-4a9a-9b5a-9ff0f5618c08

Hi! I am Filip from SWM and I'd like to work on this

I've tested word-break: break-all suggestion and it seems to be working, but I am not sure if this is what we want, because right now we can get something like this:

If we are ok with that I can prepare PR, otherwise I'll look for other possible solutions

I tried different solutions, but only this one was working, I've prepared a PR, but if you think we have to find some other solution than feel free to open the issue for externals, maybe someone will find something better. Additionally I've pushed here some translations fixes.
cc @mountiny

I think this one has gone to prod? Do we just need a payment summary for @rushatgabhane ?

Payment summary for @rushatgabhane:
@rushatgabhane is owed 250 for their work reviewing this PR

@mountiny I will unassign myself for my parental leave now, but if in the end we need another BZ team member on this for any reason, please assign. thank you!


Research table lag in multiplayer!

I've opened a server with my friend with thaumcraft 6, and when i'm opening a research table i have  lags for 8-10 seconds

I have the same problem. At first all work fine, but after using the research table a few times it starts to become laggy and a few uses later the game crashes and we have to restart

Removing tc6aspects4jei worked for me
https://board.aternos.org/thread/29702-1-12-2-thaumcraft-6-is-laggy/?postID=110894#post110894

Hi, is there any fix? If not, I'd like to join the development and fix this. Can not find any source code :). Affects server that I play (version BETA26hotfix)

I have the same issue as @vaderkos ,is there any fix?

Same problem, looked through whole internet and can't find a way to fix it.


Quick accent sometimes getting stuck

Microsoft PowerToys version
0.77.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Quick Accent
Steps to reproduce
Sometimes (apparently randomly).
✔ Expected Behavior
The quick accent panel disappears when I let go of the keys.
❌ Actual Behavior
The quick accent panel stays stuck on screen sometimes. I see it most often when playing games. It's normal it shows up in game since I didn't include them in the excluded apps setting. But the problem is that it sometimes doesn't leave the screen until I press Esc.
Other Software
No response

For Quick Accent we use a Low Level Keyboard Hook, it's possible that some games also use low level technologies that get the signal that the key was released and that signal never gets sent to Quick Accent.
On 0.78 there's a new Setting to try and not activate on some games. I advise to put the games in the Excluded Apps setting.
Hope this helps. /needinfo


(Mod Compatability Issue) FTB Utility Chunk Loading

Hello,
I hope its acceptable to post issues with other mods?  I'm using FTB Infinity and have noticed that chunk loading in RFTools dimensions doesn't seem to work right.
I have a void world (just a void terrain dimlet).  I have built a small platform and stuck my AE system on there, with an ender chest and an import bus.  I chunk loaded the base using FTB Utilities.
I have an enderman spawner, 500 blocks away, feeding to the ender chest linked to the one on my AE system.  Again, I have chunk loaded this area too.
The items are not transferring between the ender chests, even though the area is chunk loaded.  I will also report this on the FTB Utilities issues log, but wanted to make you aware in case it was something on your side?
Many thanks
Tirm

I don't think this is on my side as rftools dimensions don't do or prevent any chunkloading. But I'm interesting to hear what the other guys say about this

Cool, thanks McJty!

I also have the same problem.  I have my solar there to make RF, but they don't load it when my server restarts.  If I go there its fine.  I am using a Tesseract to transfer the energy.

Many chunkloaders are having issues with rftools dimensions on startup. I think chickenchunks in 1.7.10 worked fine but other then that not much does. I think the problem may actually be in forge itself as most of those chunkloaders use the forge chunkloading system


For Angular 15, babel needs updating to (at least) 17.18.10

Which @angular/* package(s) are the source of the bug?
Don't known / other
Is this a regression?
No
Description
Please inform me if this belongs in a different category, but honestly none of them looked right.
I reported a bug in babel a while back and resolved here: https://github.com/babel/babel/pull/14752. The latest version of Angular targets ES2022, which will break any applications impacted by the babel issue.
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
No response
Anything else?
No response

Babel packages are already updated to the latest versions https://github.com/angular/angular-cli/blob/979bce45e63eda9ac5402869ef3dc4c63aaca3f1/packages/angular_devkit/build_angular/package.json#L13-L21


Candidate Table: Display parameters and add sort functionality

Allow the user to select which parameters are displayed in the table (i.e. more than just coordinates) and also add a functionality to sort by each parameter.

Alternatively, could just add a display window at bottom showing all parameters in the final_csv file for this particular object. It doesn't have to be well-formatted (a native table show be fine) and can just display all/every parameters even we add new columns (less likely happen though)


[Feature Request]: Icon override with entity/block model

Icon override with entity/block model
Solution(s)
I believe it would be a very nice QoL feature if you could use the existing entity/block model renderer within Heracles to override the icons of quests and tasks. This way, you could have any quest or task display itself as a mob, or display a different mob on a kill task for whatever reason. Attached image is a mock-up I created to show what this might look like.

Mod Version
1.1.12
Mod Loader Version
1.20.1 47.2.21
Mod Loader
Forge
Additional context
No response

duplicate of #130


Move user-defined -idirafter to the end of args

Description of changes
As discussed in https://github.com/NixOS/nixpkgs/issues/190005 we have an issue with -idirafter arg in cc-wrapper. In this PR we add logic that moves all -idirafter to the end of arg list.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@Ericson2314 Do I need some fixes here before merge?

@veprbl Can you help me with this PR? How can I help with review?

I looked at the code, and it looks fine, although it may be combined with a loop above. I have some questions regarding the intention of this.
This is supposed to allow a user to break our "soft compiler sandbox" using -idirafter, right? In the original issue you've mentioned how libSystem libc is in your way and mentioned u-boot. It makes me wonder if the stdenv of your choice is the problem. Why are you not using, say, pkgsCross.gnu64.stdenv? If using darwin stdenv is a must, you can always mangle NIX_CFLGAGS_COMPILE in your shell.nix to exclude the paths you don't lile.

This is supposed to allow a user to break our "soft compiler sandbox" using -idirafter, right?

No, it just copy behaviour of default clang/gcc. Details here: https://github.com/NixOS/nixpkgs/issues/190005, TLDR: user-defined -idirafter should go after libc's include paths.

Can the same be achieved by reversing order of concatenated items in
https://github.com/NixOS/nixpkgs/blob/0446732359536566de33d8893bd4c682174e31e2/pkgs/build-support/cc-wrapper/add-flags.sh#L51
?

No, unfortunately not. We need to move all -idirafter flags from params to end of extraAfter. Changing order in NIX_CFLAGS_COMPILE_@suffixSalt@ will just move them inside extraAfter environment variable.
But I just realized that maybe it would be good idea to move -idirafter with libc include paths to separate variable and put it to extraBefore, that will make while (( $n < $N )); do unnecessary and source code will look better.

I've tried to implement solution I described above and now I cannot compile glibc. We cannot just pull libc-cflags (which contains -idirafter with libc include dirs) and put it into extraBefore: crt1-cflags, libc-cflags, cc-cflags must remain in specific order:
https://github.com/NixOS/nixpkgs/blob/0446732359536566de33d8893bd4c682174e31e2/pkgs/build-support/cc-wrapper/add-flags.sh#L36-L41
So the only solution is to collect all user-defined -idirafter and put them into end of extraAfter, which is already implemented in PR.

Yes, I agree that solution in pr is a bit ugly, will try to find another way to do it.

Ok, I give up - unfortunately I do not have enough knowledge (or time to get this knowledge) to fix both https://github.com/NixOS/nixpkgs/issues/190005 and https://github.com/NixOS/nixpkgs/issues/158042 in one solution. Closing PR.


Updates on MEP-11 regarding whitelist for auditing.

I would like to create another discussion on the whitelist as I find that the audit trails are extremely valuable to have.
The original MEP only audits very little things, which does not seem reasonable to me. It's really nice to also catch events like somebody creating VPN keys, retrieving the console-password of a machine and so on.
Therefore, I extended the whitelist a bit. The amount of data produced should still be fairly small with the given whitelist (in production setup of FITS < 1000 entries a day).

/cc @vknabel


Insert object with Many-to-many relatioship via sqlalchemy

Hi! I'm trying to understand if fastapi_crudrouter supports inserting object with nested fields that represent many-to-many relatioships, via the Sqlalchemy ORM.
This is the code I have:
from sqlalchemy import create_engine, Column, Integer, String, Table, ForeignKey
from sqlalchemy.orm import declarative_base, relationship, joinedload

# Make the engine
engine = create_engine("sqlite+pysqlite:///:memory:", future=True, echo=True,
                       connect_args={"check_same_thread": False})

# Make the DeclarativeMeta
Base = declarative_base()

# ------------------------------- SqlAlchemy classes with many to many relationship----------------------------

# Declare Classes / Tables
book_authors = Table('book_authors', Base.metadata,
    Column('book_id', ForeignKey('books.id'), primary_key=True),
    Column('author_id', ForeignKey('authors.id'), primary_key=True)
)

class Book(Base):
    __tablename__ = 'books'
    id = Column(Integer, primary_key=True)
    title = Column(String, nullable=False)
    authors = relationship("Author", secondary="book_authors", back_populates='books')

class Author(Base):
    __tablename__ = 'authors'
    id = Column(Integer, primary_key=True)
    name = Column(String, nullable=False)
    books = relationship("Book", secondary="book_authors", back_populates='authors')

# Create the tables in the database
Base.metadata.create_all(engine)

# ------------------------------- Pydantic classes ----------------------------

from typing import List
from pydantic import BaseModel

class AuthorBase(BaseModel):
    id: int
    name: str

    class Config:
        orm_mode = True

class BookBase(BaseModel):
    id: int
    title: str

    class Config:
        orm_mode = True

class BookSchema(BookBase):
    authors: List[AuthorBase]

class AuthorSchema(AuthorBase):
    books: List[BookBase]

from fastapi import FastAPI, Depends

# ------------------------------- Connect to DB ----------------------------

app = FastAPI(title="Bookipedia")

def get_db():
    db = Session(bind=engine)
    try:
        yield db
    finally:
        db.close()

# ------------------------------- Routers ----------------------------

from fastapi_crudrouter import SQLAlchemyCRUDRouter

routers = [SQLAlchemyCRUDRouter(schema=AuthorSchema, create_schema=AuthorSchema, db_model=Author, db=get_db),
          SQLAlchemyCRUDRouter(schema=BookSchema, create_schema=BookSchema, db_model=Book, db=get_db)]

app.include_router(routers[0])
app.include_router(routers[1])

import uvicorn
if __name__ == "__main__":
  uvicorn.run('app:app', port=8080, reload=True, debug=True)

# Go to: http://<IP_ADDRESS>:8000/docs

But if one goes to http://<IP_ADDRESS>:8000/docs and then to POST/  Books,  in the "Try it out" feature, and adds this set of data:
{
  "id": 0,
  "title": "moby_dick",
  "authors": [
    {
      "id": 0,
      "name": "MELLEVILLE"
    }
  ]
}

It doesn't work, it returns this error:
File "C:\Python310\lib\site-packages\sqlalchemy\orm\attributes.py", line 1765, in emit_backref_from_collection_append_event
    child_state, child_dict = instance_state(child), instance_dict(child)
AttributeError: 'dict' object has no attribute '_sa_instance_state'

I wanted to understand if I'm doing something wrong, or this use case is not supported by fastapi_crudrouter.
Thanks!

Adding another example with SQLModel (which subclasses Pydantic's BaseModel and SQLAlchemy's DeclarativeMeta avoiding the need to declare model and schema separately).
The above example would look something like this. The tables are set up properly, but the API doesn't show neither authors nor books fields.
from sqlmodel import SQLModel, Field, Relationship

# link table
class BookAuthor(SQLModel, table=True):
    book:   int = Field(primary_key=True, foreign_key='book.id')
    author: int = Field(primary_key=True, foreign_key='author.id')

class Book(SQLModel, table=True):
    id:      int = Field(primary_key=True)
    title:   str
    authors: list['Author'] = Relationship(
        back_populates='books',
        link_model=BookAuthor,
    )

class Author(SQLModel, table=True):
    id:    int = Field(primary_key=True)
    name:  str
    books: list[Book] = Relationship(
        back_populates='authors',
        link_model=BookAuthor,
    )

Hi, i have the same issue, did you find any solution?


Dungeon Gears does not use the loot table from the context when generating loot

Hello! I gotten a report on my mod Repurposed Structures about my mod no longer importing Dungeon Gear's modded loot from vanilla loot tables.
https://github.com/TelepathicGrunt/RepurposedStructures/issues/121
After looking closely and debugging, I found the reason why rolling vanilla's loot tables in my GLM does not spawn Dungeons Gear's loot is because Dungeon Gear is checking the loot table of the block directly.

You actually do not need to do that at all. The loot table to spawn is already in the LootContext context parameter and can be grabbed by doing context.getQueriedLootTableId(). If you switch to using that, it'll help simplify your code a bit and make my mod's modded loot importing work again with Dungeon Gears. It may also help with compat for other mods that tries to roll loot table loot outside of chests to try and analyze the loot outputs or something unique or wacky.

This is my code I do for rolling vanilla loot tables
https://github.com/TelepathicGrunt/RepurposedStructures/blob/f435358cda49a3f5743fab9769ed0dca5b1671db/src/main/java/com/telepathicgrunt/repurposedstructures/misc/StructureModdedLootImporter.java#L159-L160
This is the Dungeons Gear part that is grabbing my chest's loot table instead of using the passed in loot table in context.
https://github.com/Thelnfamous1/Dungeons-Gear/blob/117c4db96bacb42ae0a454b329287297f43c52c4/src/main/java/com/infamous/dungeons_gear/loot/GlobalLootModifier.java#L202-L222

This is because the loot table id in context wasn’t a thing in the version of forge this mod was compiled against. Will need to update my Forge version to latest to get this fixed.

Ah. That makes sense! Yeah the new context stuff is super useful

Fix available in 3.0.21


Update MD file on new branch 2017-27-11_03-12-59

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[FLINK-29932][table] Upgrade Calcite to 1.29.0

What is the purpose of the change
The PR is to upgrade Calcite dependency to 1.29.0
The main change impacting Flink is https://issues.apache.org/jira/browse/CALCITE-4839
About commits
I tried to organize commits making them atomic in the next way

https://github.com/apache/flink/pull/21519/commits/67798e4500f4c45270fbc5651c481b4cc9d4c2f9 replaces deprecated RelBuilder#groupKey since it was removed in Calcite 1.29.0 at https://issues.apache.org/jira/browse/CALCITE-4927
https://github.com/apache/flink/pull/21519/commits/8bedb0bb7a094ff82f3e61ec14700f8af5ab9375 is a result of https://issues.apache.org/jira/browse/CALCITE-4839. The process of writing rules in a new way (also could be followed while rewriting) is described at https://github.com/apache/calcite/blob/013f034dee3e24083760b4695e2eacfbf592c2cb/core/src/main/java/org/apache/calcite/plan/RelRule.java#L36-L114
https://github.com/apache/flink/pull/21519/commits/cca2910b6fd88baf8f085dca38a79e75110a8d77 Sync Calcite's classes with https://github.com/apache/calcite/releases/tag/calcite-1.29.0
https://github.com/apache/flink/pull/21519/commits/3ba7123ef9592df8ba6cb3dbacff1e88c0ff1a58 Update poms and NOTICE files
https://github.com/apache/flink/pull/21519/commits/435db81cb617ad200d69ad969466f963937982f8 (optional) This is a cherry pick from FLINK-29215 to replace deprecated constructors usage for ConverterRules. Changes are done based on https://github.com/apache/calcite/blob/013f034dee3e24083760b4695e2eacfbf592c2cb/core/src/main/java/org/apache/calcite/plan/RelRule.java#L36-L114

Similar change for non ConverterRules could be a tricky for scala rules since now Calcite uses java code generation and at the same time in Flink scala should be compiled first... May be a point to move scala rules to java however not for this PR. Luckily current deprecated API is not removed yet from Calcite main branch
Verifying this change
From one side it's partially covered by existing tests
From another side it would make sense to have multiple end-to-end user tests (probably still discussable )
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: ( no)
The runtime per-record code paths (performance sensitive): ( no )
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
The S3 file system connector: ( no )

Documentation

Does this pull request introduce a new feature? ( no)
If yes, how is the feature documented? (not applicable )

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

rebased to resolve conflicts

rebased to fix conflicts after merging of https://issues.apache.org/jira/browse/FLINK-30376

Thanks for the PR @snuyanzin. Great that the changes are rather minimal with this Calcite release. I added some minor comments. My biggest concern is that we are currently violating RelRule item 5:

nice catch. Do you think it makes sense to create a follow up issue for that?

A follow-up issue would not harm. At least to track that this could potentially cause problems, if it doesn't cause problems I don't see an immediate need to implement it right away.

a follow-up minor issue to track it https://issues.apache.org/jira/browse/FLINK-30847


Timesheet entries not listed in order during time entry session

In a time entry session established using timeld open <timesheet-name>, the entries are ordered by Entry #, but in alphabetical, rather than numeric order.
Whilst they are correctly grouped by Session, within that they need to be ordered numerically.

Interestingly, the entries are actually wholly unordered by the app – what you see is the raw ordering from quadstore:
https://github.com/m-ld/timeld/blob/35323b0f69ba2d658caac872e5fb73fb7dd8327f/packages/cli/lib/TimesheetSession.mjs#L153-L161
I agree that we ought to order nicely of course.
Ideally we would add an @order clause to the query, which would require support from m-ld.
In the meantime we can just order the results manually in the app.

From a developer's perspective, it would be a reasonable expectation that the underlying query mechanism return results in a specified order - particularly if there is a large number of them, and pagination is being used.  So I agree; this should be supported in m-ld.


Installation problem

Hello, why I use the PIP install deepdow appear error (Building wheel for SCS (setup. Py)...error), does version  not match?

Hey there,
Could you please share the full traceback of this error? It is hard to say what went wrong.

Closing due to inactivity. If you have any further comments I can always reopen.

I have the same problem. Unfortunately, I am not able to install deepdow.


Add css attribute multi-column

Merged via command line, guess I need to close the PR manually!
https://github.com/varabyte/kobweb/commit/30e3c34c06cfff789dc445811f90909320847350


Windows Update Crash

Hi, we are testing this ps1 script as is and its working well apart form breaking windows update.  After running the script, windows update screen stays stuck and all you see is blue dots trickling across the screen and no settings appear in the Windows Update.

Hello.  Disabling of Windows Update in this is intentional.  We suggest that you run Windows Update before the script is run, but it can be re-enabled if you choose to do so.

Hi Tim
Thanks for your reply, after running the script, we then tried to the
following to get windows working but its the same behavior, the windows
update screen rolls the blue dots and you dont see any information, just a
white screen.

Disabled Windows Automatic Updates
Stopped Windows Update service
Stopped BITS service
Emptied the C:\Windows\SoftwareDistribution folder
Started the Windows Update service
Started BITS service
Enabled Windows Automatic Updates
Launched a check for Windows Updates
white screen with blue dots trickling.

i suspect maybe one of the other services int he disable services text file
might be causing this issue but BITS ans WU service should be the only
dependencies for properly running windows update.
i'll do some more testing and thanks again for replying.
Dave
On Mon., May 11, 2020, 9:08 a.m. Tim<EMAIL_ADDRESS>wrote:

Closed #18
https://github.com/TheVDIGuys/Windows_10_VDI_Optimize/issues/18.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TheVDIGuys/Windows_10_VDI_Optimize/issues/18#event-3322885598,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APO5TX6IEUO7UPBS4H3KJXLRQ72FDANCNFSM4M464EFQ
.

@gotsquats - We have created a new folder that contains the necessary settings to enable Windows Update (1909_WindowsUpdateEnabled).  This should solve your immediate issues with regards to Windows Update no working.  Additionally, we have updated the ReadMe.

Thank you for the update
i've downloaded a fresh copy of all the files the 1909_WindowsUpdateEnabled
repository for testing and to review the files.  A few observations:
IMPORTANT ISSUE (01/27/2020)
A new issue was discovered recently regarding the 'CDPSvc' (CDPSvc is
still part of the Win10_1909_ServicesDisable.txt file). If that service is
disabled, and
a new user logs on to the computer then opens 'System Settings' to view
display settings,
'SystemSettings.exe' will crash and log an error to the event log with code
"fatal app exit".
We removed the entry 'CDPSvc' from 'Win10_1909_ServicesDisable.txt' as a
result.
We tested the 1909_WindowsUpdateEnabled script and its the same issue.
after running the script and rebooting no info displayed under windows
update and dots trickle ontop of the screen.
On Mon, May 11, 2020 at 1:30 PM Tim<EMAIL_ADDRESS>wrote:

@gotsquats https://github.com/gotsquats - We have created a new folder
that contains the necessary settings to enable Windows Update
(1909_WindowsUpdateEnabled). This should solve your immediate issues with
regards to Windows Update no working. Additionally, we have updated the
ReadMe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TheVDIGuys/Windows_10_VDI_Optimize/issues/18#issuecomment-626843242,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APO5TX3LF5FC6YHZIX4KRJTRRAY3PANCNFSM4M464EFQ
.


Busola doesn't connect to k3d clusters hosted on local port

Description
Busola should be able to connect to k3d clusters with apiserver listening on so-called local IP addresses.
Actual result
Request is blocked on a backend side (Filters rejected the request: Local IP addresses are not allowed.)
Steps to reproduce
k3d cluster create my-cluster --api-port <IP_ADDRESS>:8082

Try adding this cluster to Busola - it won't work, while accessing it with kubectl does work.

Happy path works using
'''
kyma provision k3d
kyma deploy
kyma dashboard


undefined method 'nav_link_to' when setting action_controller.include_all_helpers = false

Hi,
When I set the config
#config/application.rb
action_controller.include_all_helpers = false
I get
undefined method 'nav_link_to'
Then I put
#application_helper.rb
include ActionView::Helpers::NavLinkHelper
And it worked locally, but when I pushed to heroku I got
ERROR -- : uninitialized constant ActionView::Helpers::NavLinkHelper (NameError)

Solved with:
#config/initializers/init.rb
ActionView::Base.send :include, NavLinkHelper

Probably because you were using the wrong constant name on your first try. You used ActionView::Helpers::NavLinkHelper. Instead in your controller you should have done: helper NavLinkHelper Hope that helps.

Oh, right! Thanks :)


Please can we get support for pickpockets?

this plugin is epic and very helpful to me, but the thing lacking is webhooking loot gained from thieving/pickpockets

I guess we could add support for rare pickpockets. Eg blood shart and teleport crystal. @BossHuso thoughts?

Fixed in the next update thanks to @thefungus :)
I'll merge the PR today and publish a new update to RL this weekend.


Sporadic failures in E2E CI

CI is sporadically failing on E2E tests, across all of them: smoke tests, kind, and k3s tests
For an example, see this run:
https://github.com/containerd/runwasi/actions/runs/6391393082/job/17346723004

From the containerd logs from this CI run, which generated these logs artifact
[INFO] starting instance: 665173b26c87393303cfdd55a68427afc5025f083f2e6a56916d11005c02c5a1
[INFO] about to build container instance: 665173b26c87393303cfdd55a68427afc5025f083f2e6a56916d11005c02c5a1
[INFO] about to REALLY build the container instance: 665173b26c87393303cfdd55a68427afc5025f083f2e6a56916d11005c02c5a1
[INFO] cgroup manager V2 will be used
[WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[time="2023-10-03T21:33:53.554067718Z" level=info msg="StartContainer for \"33e8e760bae0ce1ed34b80d16e8e0cf187b51a641a82421fc1379a8a59526365\" returns successfully"
WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[INFO] starting instance: 25633cc2ec2915d7ab31407f5312d86a271498e784f25cd9268b8d300bf76f56
[INFO] about to build container instance: 25633cc2ec2915d7ab31407f5312d86a271498e784f25cd9268b8d300bf76f56
[INFO] about to REALLY build the container instance: 25633cc2ec2915d7ab31407f5312d86a271498e784f25cd9268b8d300bf76f56
[INFO] cgroup manager V2 will be used
[WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[INFO] starting instance: c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16
[INFO] about to build container instance: c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16
[INFO] about to REALLY build the container instance: c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16
[INFO] cgroup manager V2 will be used
[WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[WARN] Controller rdma is not yet implemented.
[WARN] Controller misc is not yet implemented.
[INFO] XXXXXXXX validating container
[INFO] XXXXXXXX container executor get_or_init
[INFO] XXXXXXXX a linux container!
[WARN] intermediate process already reaped
[INFO] successfully built container instance: c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16
[INFO] container instance: c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16 has pid 5773
[INFO] XXXXXXXX executing container
[INFO] executing linux container
time="2023-10-03T21:33:53.864393966Z" level=info msg="StartContainer for \"c2f10adebbddfc541ac0eefbeb7382b428f9bd8c87af4fd675cbf49e7cd3bc16\" returns successfully"
[INFO] XXXXXXXX validating container
[INFO] XXXXXXXX container executor get_or_init
[INFO] XXXXXXXX a linux container!
[WARN] intermediate process already reaped
[INFO] successfully built container instance: 25633cc2ec2915d7ab31407f5312d86a271498e784f25cd9268b8d300bf76f56
[INFO] container instance: 25633cc2ec2915d7ab31407f5312d86a271498e784f25cd9268b8d300bf76f56 has pid 5758
[INFO] XXXXXXXX executing container
[INFO] executing linux container

There are 3 starting instance: ... corresponding to the 3 nginx linux containers.
There are 3 [INFO] about to REALLY build the container instance: ..., which is printed here just before calling build() on the libcontianer's ContainerBuilder.
The call to build() should call the validate(...) method in the executor here, however, thre are only 2 lines with XXXXXXXX validating container.
This means that we are getting stuck somewhere inside of the build() call.
@utam0k @yihuaf , do you have any clue on where in libcontainer we could be getting stuck?
Thanks!

this might be the root cause of #322

Is there anything I can help you?

@utam0k , I am currently adding debugging print statements in a fork of youki, trying to find where we are stalling. If you have any pointer of good places to look at, that would be great.

It looks like we are getting stuck in here: https://github.com/jprendes/youki/blob/runwasi-ci/crates/libcontainer/src/process/container_main_process.rs#L174
    main_receiver.wait_for_init_ready().map_err(|err| {
        tracing::error!("failed to wait for init ready: {}", err);
        err
    })?;

Also, it looks like we never get to the executor's validate(...), which IIUC should happen in the same process where the init_ready should have been signaled. Will dig further.

I am seeing it get stuck on this line https://github.com/jprendes/youki/blob/runwasi-ci/crates/libcontainer/src/process/container_init_process.rs#L457
    set_supplementary_gids(proc.user(), &args.user_ns_config, syscall.as_ref()).map_err(|err| {
        tracing::error!(?err, "failed to set supplementary gids");
        err
    })?;

which seems really odd to me!

It never makes it past https://github.com/jprendes/youki/blob/runwasi-ci/crates/libcontainer/src/syscall/linux.rs#L494
if let Err(err) = setgroups(groups) {

where setgroups is nix::unistd::setgroups.
I wonder if this is related to libseccomp.

@jprendes FYI: https://containers.github.io/youki/developer/debugging.html

How can I reproduce this error?

Here you can see the locking in the musl implementation (although in CI it's the glibc the impl we are using):
https://github.com/bminor/musl/blob/79bdacff83a6bd5b70ff5ae5eb8b6de82c2f7c30/src/linux/setgroups.c#L29
https://github.com/bminor/musl/blob/79bdacff83a6bd5b70ff5ae5eb8b6de82c2f7c30/src/thread/synccall.c#L44

I am still trying to get some logs using bpftrace.
It seems that just by tracing it the failure rate gets reduced. Yay for Heisenbugs!

This is interesting.
When it fails in k3s, as far as I can see it's in the setgroups call.
When it fails in kind, as far as I can see it's in the setresuid call.
Both of these libc functions use the same thread synchronization strategy.

I switched my patched youki to use the raw syscall instead of the libc wrappers and I haven't seen it fail yet. I will try removing the bpftracing, as that did reduce the frequency of failures and see if that has any impact.
Using the raw syscalls is safe because the init process has only one thread when the calls are made.

I wonder if this could be related
https://sourceware.org/bugzilla/show_bug.cgi?id=26371

I think that's the root cause, as youki is using a raw syscall to perform clone3.
https://github.com/containers/youki/blob/fee46419300114bfe92aee71945929c6aaba0a53/crates/libcontainer/src/process/fork.rs#L117

See if the investigation in this issue helps: https://github.com/containers/youki/issues/2144

Thanks @yihuaf
Please note that this is happening with glibc in these tests.
There's a glibc feature request from systemd, related to clone3 with explicit mentions of setgroups and friends.
Also, runwasi spawns multiple threads by the time youki calls clone3.

The underlying issue is calling raw syscall and then calling libc syscall becomes undefined behavior. While authors of both glibc and musl maintains this stance, in the field, glibc works most of the time whereas musl is more pronounced. If youki using clone3 syscall directly is the issue, may be try with the fallback path of clone and see if the issue persists.

There's a glibc feature request from systemd, related to clone3 with explicit mentions of setgroups and friends.

I think the request has been there since 2020s. It will take some times :)

Yeah, sorry, I don't mean to wait for glibc to provide a wrapper, it was just as a reference to the behaviour we observe being reported on glibc (not just musl).
I will give the fallback path a go. If that works, could the clone3 path be gated by a feature flag?

@yihuaf @YJDoc2, even with the change from clone3 to clone I'm still seeing failures. I'll investigate further.

See logs here: https://github.com/containerd/runwasi/suites/17048867407/artifacts/973767783
In particular, see containerd.log
Debug printing corresponds to branch https://github.com/jprendes/youki/blob/runwasi-ci/crates/libcontainer/src/process/container_init_process.rs#L456
You can see [INFO] YYYYYY libcontainer::fork >> about to do normal clone, which means it is not using clone3, but libc::clone (debug printing from here: https://github.com/jprendes/youki/blob/runwasi-ci/crates/libcontainer/src/process/fork.rs#L60)
As before, it is getting stuck in setgroups.

@jprendes can you describe a way to run this locally, so we can iterate and figure out the issue more quickly? Also, when you say that it is getting stuck, is the CI getting canceled because of timeout? As far I can think, hanging in (essentially) a syscall is strange, as it should return error right away if there was any setup/  config issue when calling. Also, for this are we using the main branch or released v0.2.0 for crates? If we are using released version, and the errors have started only recently, it can be due to some underlying env config changes too.
In the containerd logs, is the context deadline exceeded error due to youki not starting the container/hanging?

@YJDoc2 I haven't been able to reproduce locally, although I will give that a more thorough try.
That job in CI has a 5 min tomeout, and it's getting killed after that timeout.
I believe it is not hanging on the syscall itself, but on the glibc implementation which does container a thread synchronization mechanism (aparently the setgroups kernel syscall only affects the calling thread, and glibc takes care off calling it from every thread using signaling).
Initially I thought that since youki was using a raw syscall for clone3, glibc didn't have a change to do house keeping and update the list of running threads in the new process, and that switching to libc::clone would do the trick. But after the switch it still hangs in the same place.
The logs are using a forked version adding debugging prints, based off my PR to disable clone3, which is based off youki's main branch. But it also happens with v0.2.0 (which is why I started investigating).
I am not sure where the context deadline exceeded message is coming from, but I strongly believe it's caused by the hang in setgroups.

I haven't been able to reproduce locally, although I will give that a more thorough try.

Hey, I saw the previous conversation regarding this, that the issue is only seen on CI ; I am just asking, can you share the instructions to run the particular test/CI  things locally, so we can also try to do this and see if we can reproduce.

That job in CI has a 5 min tomeout, and it's getting killed after that timeout.

:+1:

The logs are using a forked version adding debugging prints, based off my PR to disable clone3, which is based off youki's main branch. But it also happens with v0.2.0 (which is why I started investigating).

:+1:

I am not sure where the context deadline exceeded message is coming from, but I strongly believe it's caused by the hang in setgroups.

Yeah, I'd also think so. I have seen this error message (in proper crio/runc k8s) when something underlying k8s fails, such as image pulling and potentially runtime hanging up.

You can try running:
make test/k3s-wasmedge
make test/k3s/clean

in a loop until it happens, that's what I was going to try :-)

I made a simplified reproduction. Debugging with gdb on the halted process I get:

Well, it looks like clone also messes up with printing to the console.
Here's the backtrace without any printing, halted purely in setgroups

Sorry I haven't had much time lately 🙇 🙇
How about calling setgroups directly as in Go language?
It is strange that runc has not faced this problem.
https://cs.opensource.google/search?q=setgroups&sq=&ss=go%2Fx%2Fsys
Also, bpftrace or whatever, but I want to make sure first that the setgroups system call is actually called.

@utam0k calling setgroups / setresgid / setresuid directly would workaround the issue.
I am slightly concerned because in normal youki / runc, we soon call execve, which starts a clean process.
In the case of runwasi, we don't, we keep running on the same tainted process.
From nix::clone and nix::fork, even memory allocation might be unsafe after the clone call (I assume it's platform / variant dependent).


[docs] Craft CMS quickstart should  not have --no-install, fixes #4338

The Problem/Issue/Bug:
I must have made a mistake with a merge conflict, and --no-install remained in the Craft CMS quickstart
How this PR Solves The Problem:
Remove it.
Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Manually tested. For some users it will be better to continue to use the stable version of the quickstart until the next DDEV release, https://ddev.readthedocs.io/en/stable/users/quickstart/#craft-cms - that one does a --no-install followed by ddev composer update


Standarize testing patterns

As per comment in PR #1040, I would like us to discuss the established patterns for testing in this library, these will include:

What we test in unit and functional tests, mainly the scope of those tests.
The format of test fixtures, e.g out with teardown() in with yield
Factory classes to reduce the amount of repetitive code.
When not to test certain elements, e.g due to specifics of BIGIP operation, or limitations, whether its
feasible to work around those.
Adherence to code coverage, e.g. no 100% code coverage (whenever possible) means no PR approval

@caphrim007 @jasonrahm @zancas @pjbreaux

closing as there seems to be no interest in this

re-opening. this still needs to be fixed. there is no lack of interest

since we are on this topic, adding code coverage tests at some point should happen. We can push whatever we need now but to test coverage with PR and remain consistent, we would have to go through each lib and address this in separate PRs @caphrim007