Simplify groups transitions/states handling

This is a pre-step refactoring for the add-groups-users use-case.
While I started to work on this feature I realized that the current rendering was becoming too complicated, especially to handle the different pre-steps (creating, saving, deleting, prefetching etc.), so pushed that logic "up" (e.g. the group.fetch() call).
Both router and the main view should be both easier to understand and change now (e.g. can actually be unit-tested), as well as handling the preloading-state at the top-level instead of complicating individual child views (and get rid of that smelly switch-case in the main view).
Also:

[x] Header menu + back button to navigate between different views/"levels" in the view hierarchy
[x] Changed the URL path to the group to be more proper "REST" (i.e. /groups/:id/edit)
[x] Moved navigate-through-router up to main view
[x] Using new layout container for groups (+add tab)

@alonsogarciapablo Can you review please?
cc @juanignaciosl FYI

Taking a look!

Left some minor comments. Code looks great :clap: :clap: :clap:


Issue #829: Fixes Iterable::take(Infinity)

Before: Iterable::take(Infinity) returns empty iterable.
After: Iterable::take(Infinity) returns iterable of previous size.

[Fixes #829]
I couldn't make all tests pass on master, but here are the two relevant tests:
❯ node_modules/.bin/jest __tests__/slice.ts
Using Jest CLI v0.4.19
 FAIL  __tests__/slice.ts (1.232s)
● slice › take › it converts to array with correct length
  - Expected: 0 toEqual: 6
        at Spec.<anonymous> (/Users/nico/workspace/immutable-js/__tests__/slice.ts:141:41)
1 test failed, 0 tests passed (1 total)
Run time: 1.472s

and
❯ node_modules/.bin/jest __tests__/IterableSeq.ts
Using Jest CLI v0.4.19
 FAIL  __tests__/IterableSeq.ts (0.248s)
● IterableSequence › it is stable
  - Expected: {

    } toEqual: {
    | 0: 0,
    | 1: 1,
    | 2: 2,
    | 3: 3,
    | 4: 4
    }
        at Spec.<anonymous> (/Users/nico/workspace/immutable-js/__tests__/IterableSeq.ts:16:52)
1 test failed, 0 tests passed (1 total)
Run time: 0.487s

If anything is missing, maybe I forgot a test), I'm happy to update this PR!

Thank you!

Awesome, @nicolasbrugneaux & @leebyron, thanks for the fast turnaround! 😄


Initial pass at Rust codegen

This PR adds a code generator for Rust that:

Generates roles as traits
Generates unions as Enums
Generates aliases as type aliases
Generates enums as Enums
Generates type definitions as Structs
Accounts for recursive types
Adds Display and TryFrom implementations for Enums with indices or display values.

Note: Ignores interfaces as they may be removed soon.

Updated this branch with the latest rust codegen.
The new parser/visitor doesn't seem to be walking over top-level functions but I haven't had a chance to troubleshoot that yet.

This PR also removes the node_modules directory in src/ which appeared to be extraneous. I couldn't find how it was used.


Experimenting with Pytorch 2.0 compile() optimizations on wav2vec2 models

This pull request contains code that I added to the librispeech_ctc_decoder inference.py example to evaluate if pytorch 2.0 compile() optimizations can help this model. To summarize, my findings are:

torch.inference_mode() had to be replaced by torch.no_grad()
I couldn't use compile() with dynamic tensor sizes (yet).
Passing the 'lengths' parameter to the wav2vec2 model also breaks the compilation.
Overall, there's a ~10% performance improvement using CUDA, and up to 38% on CPU, but this is currently achievable only by padding all samples to make sure tensor sizes are equal, and this hurts performance.

Thanks @kalakris !


Remove findObject from the Public API

Implement the equivalent of the HashStore-java issue

While the intention of findObject was to help developers, it is leaking many implementation details that the client/caller should not be aware of. The removal of this method has been discussed with Jeanette (Metadig - does not use this method) and Jing (Metacat - only used in test classes), and we are to proceed.
We will work together to find alternate solutions should Metadig/Metacat need any of the current findObject return values.

This has been completed via Feature-123: Remove find_object from Public API


fix Error is reported when no discoverers are found.

@dacolgit, can you please post a screenshot of how it looks now ?

@dacolgit, can you please post a screenshot of how it looks now ?


missing dll when trying to install debian

Windows Version 10.0.16299.551
I'm unable to install debian gnu\linux from the microsoft store. Installation fails immediately and debian.exe throws a system error: code execution cannot proceed because api-ms-win-core-console-l2-2-0.dll was not found.

I have a similar issue but I had debian working fine previously.  I'm not certain it's related, but I did some driver updates through the Lenovo Vantage utility earlier today and now I get this exact same error when trying to start a bash window.

I tried uninstalling Debian, turning off Windows Subsystem for Linux and then turning it back on and reinstalling Debian.  I'm still getting the same error.

I just installed Ubuntu and it works fine.  Still no luck with Debian though...

debian.exe was updated few days ago. ubuntu.exe is not. Lenovo software does not matter.
https://www.virustotal.com/#/file/b11a6b5812df69e70dc04e7812a64a54d946e3680f4e051cd99566c93efd3eca/details
https://www.virustotal.com/#/file/a4309682690a8dc9b02b4df07654b7991c3d84e60a7ba6b01ae6d61f97dddcd6/details
The difference between them is the version of MSVC used.

Yes, there are some new commits in GitLab Debian-WSL project. @rhaist may help.
How about compiling the debian.exe with multi-threaded option (/MT) to remove VC runtime dependency? Though it will increase the file size.

I did update the Debian store app to use some of the new upstream features and bug fixes.
Can you post your current WIn10 build version?
(https://support.microsoft.com/en-gb/help/13443/windows-which-operating-system)
As I also had to bump the WindowsTargetPlatformMinVersion you might have to update your base system:
https://salsa.debian.org/rhaist-guest/WSL/blob/v2/DistroLauncher-Appx/DistroLauncher-Appx.vcxproj#L10

i'm running 16299, same problem - checked again few minutes ago

i tried to open debian today and i got the same error(api-ms-win-core-console-l2-2-0.dll not found. Its asking me to reinstall but as i see above reinstall wont help and if i reinstall i will loose all the packages i have installed . So should i wait for the solution or should i do something. I didnt update anything .
Currently running windows 10 1709

I've done a windows update yesterday and my Debian isn't working anymore. I have same issue than the one mentioned above.
It's a shame because the popup tells us to reinstall (lose all previous config) and it actually doesn't fix the issue....
Also running on W10 1709.

I am sorry you all have problems with the latest release. I have no clue why this happens for some people atm., as I don't know much of the inner workings of this pretty new WIN10 feature.
I will try to reproduce the problem, but this might take some time.

I'll look into this as well. Likely a compiler setting when the app was built.

@rhaist - If you bumped the WindowsTargetPlatformMinVersion in the visual studio solution, you will also need to change your TargetPlatformMinVersion in your appx manifest.  Why Visual Studio lets you do this is a very good question, but I think that's the issue you are running into.

Glad I'm not the only one seeing this error. I'm up to date, running Win10 Pro, on a Lenovo T530

It says I am missing "api-ms-win-core-console-l2-0-0.dll" when trying to start Debian. Uninstall and reinstall did not fix the problem.

I too am unfortunately having this problem. I have installed Ubuntu for now, but it has extra complications for what I'm doing that has some of my work impacted. My personal server is Debian as well so I am really looking forward to the fix.
I am also happy to help in anyway (testing perhaps).

Just use wsl.exe or bash.exe. Debian.exe (and others) eventually executes wsl.exe with standard I/O handles via WslLaunch() and WslLaunchInteractive() functions.

Thank you for the tip. That definitely brings up a window. Unfortunately it's to my Ubuntu installation. I would rather not uninstall that and lose what I have if I don't have to.

@Aheleos - You can use wslconfig.exe to change your default distribution.

I was really excited at the idea of that and looked up wslconfig to read through the options, but since I tried to uninstall and reinstall Debian before, it's now installed, but unregistered and not on the list.
Thank you guys for the quick response and help with this.

To be fair, this is NOT a fix for the issue, merely a workaround for those who havent already uninstalled Debian/installed Ubuntu

Thank you all for bearing with me.
I am just uploading an update to the Debian app recompiled for target version Build 16299 (Fall Creators Update, Version 1709).
I hope this will solve your problems.

Thank you. I really appreciate the effort.

Store submission went through really fast this time.
You should receive the updated app now if you search for updates in the Windows Store App.
Please tell me if it works.

I was having this problem, a few minutes ago my Debian app updated, and now
it works. Thanks for the quick fix!
On Wed, 15 Aug 2018 at 09:54, Robert Haist<EMAIL_ADDRESS>wrote:

Store submission went through really fast this time.
You should receive the updated app now if you search for updates in the
Windows Store App.
Please tell me if it works.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/WSL/issues/3456#issuecomment-413028736, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AD9tM5wYvp85m36wMFPmriJlFckxkNZwks5uQ0cTgaJpZM4V4go8
.

Confirmed working on build 16299. Thanks much!

Also works for me! Thanks @rhaist

Awesome. Thank you @rhaist, @Biswa96, @benhillis  and everyone else that contributed to the discussion.

Working for me too, thank you all.
The output of uname -a is quite different from the screenshot on the store though. It seems my kernel is much older. Any ideas on how to upgrade it? "apt-get dist-upgrade"  shows no upgrades available. Do I need to add another repository?
$ uname -a
Linux box1 4.4.0-43-Microsoft #1-Microsoft Wed Dec 31 14:42:53 PST 2014 x86_64 GNU/Linux
Windows 10 Enterprise, version 1709, OS Build 16299.492

@TWXjm - There is no Linux kernel in WSL, thus no way to upgrade it.  The driver that handles the syscall translation is tied to your Windows build number.

@rhaist Is there a way for you to add some logic (or did you already) so that the newer Store infrastructure functionalities you adopted can be used if you're using a newer version of Windows that supports it?

@DarthSpock He followed BenHillis's suggestion. There are some specific rules that should be maintained in project files so that Visual Studio can build the correct AppxManifest file *. See this commit, only the Windows Version was changed in project files.
* It can also be written just by typing

Yes I see. Thanks for the info.


Support generated presigned S3 URLs

See equivalent in:
boto3: http://boto3.readthedocs.io/en/latest/guide/s3.html#generating-presigned-urls
Java: http://docs.aws.amazon.com/AmazonS3/latest/dev/ShareObjectPreSignedURLJavaSDK.html
Go: http://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/s3-example-presigned-urls.html

Here is what I got from boto3 implementation.
They have a signing type standard, presign-url, presign-post
When singing a request you send the signing type e.g

Normal request => standard
Pre signed url => presign-url
Pre signed post => presign-post

The signing type is then converted into a signature version e.g.

presign-url => s3v4-query
presign-post => s3v4-presign-post

that signing version is then used to define which authentication will be used see https://github.com/boto/botocore/blob/55d64656e635ced908f7ba9f427a7c9f42ce8739/botocore/auth.py#L832
To implement only generate_presigned_url() we only need to add presign-url if we also want to do generate_presigned_post() we will also need presign-url
I am fairly new with rust and rusoto but if I read the code correctly the request are always signed the same way.
Before implementing generate_presigned_url() or generate_presigned_post() I would modify the signature flow to allow multiple auth mechanisms.

We needed this feature for a project so I made a working, very basic implementation that needs cleaning up. I'll try to submit a pull request soon.

There's a PR open, but it's proving hard to implement cleanly.

I believe this is done in https://github.com/rusoto/rusoto/pull/1018 and https://github.com/rusoto/rusoto/pull/1078 . 👍


consul 0.5.2 checksums, changed default version to install

I have added consul 0.5.2 checksums from official source at https://dl.bintray.com/mitchellh/consul/0.5.2_SHA256SUMS?direct
Changed default attribute node[:consul][:version] to 0.5.2 as well.
I double checked that web_ui sum did not change since 0.5.1

Coverage remained the same at 100.0% when pulling def37cba87c79a791640b88312ea3cfae46824be on ai-traders:consul-0.5.2 into b532f1c63de181c7bee36835fd977636d2d0246d on johnbellone:master.


[FEATURE] V2 Data Engine supports ARM platform

Is your feature request related to a problem? Please describe (👍 if you like this request)
Currently, V2 Data Engine only supports x86_64 platform, but my longhorn is running in ARM platform, I also want to use V2 Data Engine to improve performance, so I want to know when the ARM platform will be supported? Or is there a way to use V2 Data Engine on the ARM platform.
Describe the solution you'd like
V2 Data Engine supports ARM platform.

Duplicated to https://github.com/longhorn/longhorn/issues/6021


A big file complied on linux

I want to use xfreerdp in my app, but I wish to have a single file to execute . How can I update the CMakeList? and then I can invoke like this :
./freerdp /u:user xxxxxx

can you provide a demo?

Check the ci/ folder, there are CMake preload scripts for the pull request builder.
specifically the windows version builds a static wfreerdp.exe which is similar to what you want.

Check the ci/ folder, there are CMake preload scripts for the pull request builder. specifically the windows version builds a static wfreerdp.exe which is similar to what you want.

but  I want a single file on linux ，not windows


Fixed AmbiguousTimeError in the debug view during DST changes.

The error was caused if USE_TZ is False and an error was reported during DST changes.

Grml, freezing/mocking datetimes is hard, any idea on how to test this?

As discussed this morning, I'm increasingly convinced that this is a bug in the r date format (({{server_time|date:"r"}}). I'd rather fix it for all users that just for the debug view.


Add test for dropping index cursor issue

For #3005.
Description

Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[ ] I ensured that PR title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.

#4339


YouTube

Describe the bug
Whenever I turn on any YouTube video on duck duck go, the recommendation videos turns off.

Environment
- DDG App Version:
- Device:oppo a3s
- OS:android

App version missing, and we are not able to reproduce the bug.


Build error cross compiling from macOS to Windows

Hi there. I'm using Tiberius:
tiberius = { version = "0.12", default-features = false, features = ["chrono", "tokio", "rustls", "integrated-auth-gssapi"] }

to cross compile from macOS to Windows:
cargo build --target x86_64-pc-windows-gnu --release

and getting the following error:
error[E0599]: no variant or associated item named `Integrated` found for enum `AuthMethod` in the current scope
   --> /Users/coliny/.cargo/registry/src/github.com-1ecc6299db9ec823/tiberius-0.12.2/src/client/config.rs:303:32
    |
303 |                 Ok(AuthMethod::Integrated)
    |                                ^^^^^^^^^^ variant or associated item not found in `AuthMethod`
    |
   ::: /Users/coliny/.cargo/registry/src/github.com-1ecc6299db9ec823/tiberius-0.12.2/src/client/auth.rs:51:1
    |
51  | pub enum AuthMethod {
    | ------------------- variant or associated item `Integrated` not found for this enum

For more information about this error, try `rustc --explain E0599`.
error: could not compile `tiberius` due to previous error

I'm not really clear on why Integrated cannot be used on Windows (particularly as this is exactly the use case I'm trying to implement!), so I thought I'd stop and ask for help :-).

I ran into the same issue.
https://github.com/prisma/tiberius/blob/main/src/client/auth.rs#L61
https://github.com/prisma/tiberius/blob/main/Cargo.toml#L56
Looks like winauth feature is needed in windows.
Here's how I fixed it based on this:
[target.'cfg(not(windows))'.dependencies]
tiberius = { version = "0.12", default-features = false, features = ["tds73", "sql-browser-tokio", "integrated-auth-gssapi", "time"] }

[target.'cfg(windows)'.dependencies]
tiberius = { version = "0.12", default-features = false, features = ["tds73", "sql-browser-tokio", "winauth", "time"] }

(thanks @willbush)


fix max width for only text content

What type of PR is this?
/kind documentation
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:
the previous pr of doc landing site added a change that restricted max width for the entire landing page rows. Which does not look right for the social links section.

Special notes for your reviewer:

/lgtm
/approve

/ok-to-test


update image

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/images/outlook-mobile-design-cell-donts-android.png
:white_check_mark:Succeeded

docs/add-ins/outlook-mobile-addins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


blank page

I dunno what I'm doing wrong but all I get is a blank page.
rhel7

Which operating system, which webserver, can you state the steps you followed to install? which version of gitlist are you using? with that information, we might be able to check logfiles which might lead to more useful information

I solved this by changing permissions for my directory containing the repositories:
chmod 705 /myrepos

You might not simply have any repositories found in the path defined in your config.ini -- at the moment gitlist does not gracefully give an message, instead it throws an exception, which will likely not show if you have debugging turned off.

Make sure you follow the installation instructions correctly. Check your webserver and PHP error logs. Provide more information in the future so we can help you.


fix(linux) data_directory error for webkitgtk

when migrate from v1 to v2, linux version (using webkitgtk) can not get old data (like indexeddb)

Thanks for contributing! Apart frome the failing format check worklow, could you please also add a changefile like this? https://github.com/tauri-apps/wry/blob/5111eb013e1b049d12aad38b96b2017a4fc54c72/.changes/fix-clear-browsing-data-macos.md

The paths looks the same to me in v1 https://github.com/tauri-apps/wry/blob/e9050f7085f7b8338fd4fa5be2760f3264796820/src/webview/webkitgtk/web_context.rs#L46-L49 and v2 https://github.com/tauri-apps/wry/blob/e332eff6ac41ff0f4ed6cf5196c3a78c776912d3/src/webkitgtk/web_context.rs#L44-L48
Was this changed internally in webkit2gtk? do you have a link to that change?

i have using tauri build NextChat.
on linux, the data_directory is ~/.local/share/com.yida.chatgpt.next.web

so the indexeddb directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb

when i upgrade to tauri@v2 in this Pull Request, then the data_directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb

now the indexeddb directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb/databases/indexeddb

i have upload the screenshot on the head.

i just see the version for wry in src-tauri/Cargo.lock for this project is 0.24.7, this version, do not include webkitgtk...

the repo structure is a bit different, see https://github.com/tauri-apps/wry/tree/wry-v0.24.7/src/webview/webkitgtk

i have using tauri build NextChat.
on linux, the data_directory is ~/.local/share/com.yida.chatgpt.next.web

so the indexeddb directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb

when i upgrade to tauri@v2 in this Pull Request, then the data_directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb

now the indexeddb directory is ~/.local/share/com.yida.chatgpt.next.web/databases/indexeddb/databases/indexeddb

i have upload the screenshot on the head.

I understand that the directories has changed for your app indeed but this was not due to a change in our code and it looks like maybe a recent webkit2gtk version may have changed the default behavior. This will need to be properly investigated rather than simply working around it.

Oh nvm, I see the problem. In v1, we were setting indexeddb_directory but in v2, we are setting base_data_directory which ofc results in the extra path.


Add h100 support

Continuation of #111.
Pin urllib3 due to https://github.com/python-poetry/poetry-plugin-export/issues/183

[ ]


CAMEL-8351 - simple implementation for breadcrumbId to be set as camel exhange's header

simple implementation, if mimeheaders may have multiple values as string array for breadcrumbs header, breadcrumb generation strategy may need to be implemented and this may require a config uri param on the endpoint to inject such strategy

@onders86 let us know if you get time to fix the minor comments on this PR so we can get the code merged

@davsclaus, i can fix the reviews by monday. i am very away from any computer. but i ll do as soon as i can. i know release getting closer. i hope fix goes with it

Thanks for the PR it has been merged. Do you mind closing this?

no problem. thanks


New Tool creation added

Register-Tool calls new version of Get-OAIFunctionCallSpec

Cool - thought you'd chk alias info, guessed get-alias. Will look deeper.


Cordinates networks from dataset id 80

The geom is set to null for the networks whom id are 2470, 2471, 2472, 2473 and 2474.
The geoJSON attributes for all these networks are :
        "geom": {
            "type": "Polygon",
            "coordinates": [
                [
                    [
                        -126,
                        42
                    ],
                    [
                        -124,
                        42
                    ],
                    [
                        -124,
                        48.34
                    ],
                    [
                        -126,
                        48.34
                    ],
                    [
                        -126,
                        42
                    ],
                    [
                        -126,
                        42
                    ]
                ]
            ]
        },

Or in R format :
lat  <- c(42, 42, 48.34, 48.34, 42)
lon  <- c(-126, -124, -124, -126, -126)

Moreover the user_id is set to null too.

Fix via PUT


Refactor: move classic compiler code

Merge dev-vite and dev commands
Merge build-vite and build commands
Move classic compiler code to lib
Split init.test.ts in different files
Minor fixes to --quickstart
Cleanup code related to the --styling flag

🎩 : Nothing should change in behavior, except for the minor fixes.

I'm afraid this is related to the new global CLI 🤔


add collection terminal-first-applications

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Terminal first applications are gaining popularity example wttr.in,  and it might be useful if we create a collection of terminal-first-applications.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi,
Thanks for starting this pull request. In order to review it for acceptance, we need to make sure that all of the prerequisites are satisfied. I see that you checked this:

I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee)

This is a requirement so that we can maintain a high level of independence in this project. Please reopen this pull request without the projects that you own or are affiliated with and we can review accordingly.
Thanks!


32_scraping_govuk_twfy Hansard code

Added Hansard.py that retrieves data from hansard using:
rsync -az --exclude='s19'  --progress --exclude '.svn' --exclude 'tmp/' --relative data.theyworkforyou.com::parldata/scrapedxml/debates/  .

Hey this looks good, happy for you to merge!
FYI, this will also merge the notebooks (otherwise you'd have to remove them from the branch)
But I think that's OK, and you can always create a new PR that updates the notebooks and replaces them with cleaner versions later down the line.
Thank you!


Sizing of cards - Apex chart custom cards and LCARS

Since updating I've had issues with a number of my Apex charts cards - it is intermittent in that they don't always resize, but many times they resize to make data on the RHS of the card invisible. I thought I had fixed it previously by updating my markdown headers and footers to custom html, but this morning it is still behaving the same way.
Is this anything to do with the new helpers - I set them up, but it's not clear to me from the instructions what they are actually for!!?

I'll need to test the Apex cards as I've not done any development for them.
The new helpers let you set the width/height of the colored bars in headers, footers, and middles. I doubt that they are causing your problems, but you can delete them safely to test. Deleting them will just set revert them to the default sizes in the theme.


The List

This epic contains issues related to the actual list of movies and series.

The app will be completely rewritten as a web app, thus all opened issues are being closed.


Fix bug where the CLASS was not include in generated zones

Somehow make_zone_file has been creating RR's without a CLASS field. These zone files are invalid and would not work when I tried to deploy them.
I've included a fix and a tests for this bug. I also fixed another bug in the excepted result for a URI record test.

I think we can merge this :)  But just for my own edification, I was under the impression from RFC 1035 (section 5.1) that CLASS was an optional field that, if absent, defaulted to IN.  Would be happy to learn otherwise!  Related, do you foresee a need to use CH or any of the other classes defined in the RFC?

I wasn't aware that CLASS was an optional field. I made this change as my DNS provider could not parse zone fields without the CLASS field. I think it will be more reliable and to always include the field at the cost of a few bytes in the zone file.

I agree that all other things being equal, it would be best to be explicit on the CLASS field for the reason you stated.
There are a couple extra things we'll need to address before merging, though.  Blockstack maps names to the hashes of their zonefiles in the blockchain, but the hash of each zonefile is calculated from its textual representation (i.e. its RFC 1035 representation).  Because CLASS was ignored, the zonefile validation logic must grandfather in all the existing zonefiles that lack an explicit CLASS so when parsed and re-serialized, the resulting RFC 1035 representation will be the same.
I think the following might solve this:

If a CLASS field is not found in the RFC 1035 representation, the parse_zone_file method would include the CLASS value IN in the resulting RR, as well as a hint that the CLASS was implicit.
The make_zone_file method would check each RR for the "missing-CLASS" hint when serializing, and exclude the CLASS column if the hint is present regardless of whether or not a CLASS value is given (so as to recover the original RFC 1035 representation).
If the hint is not present, make_zone_file will require a CLASS field for each RR and raise an exception if not given.  This will ensure all new zonefiles have a CLASS for each RR.

@jcnelson I've implemented the approach you described. Zone files without a CLASS field should have the same RFC 1035 representation when parsed and regenerated.
I think forcing users to specify a CLASS for each record when calling make_zone_file leads to a lot of needless overhead. The vast majority of users will just want the "IN" class. Should we use "IN" as the default unless another class is specified?

Hi @jcnelson, Do you need anything more from me to merge this?

Hi @DonnchaC, apologies for not responding to your earlier comment (lost track of time getting ready for the next release).  Your PR looks good :)  We'll merge it for 0.14.  Our release process is BSD-like--we'll release the new server, new CLI, new core libraries (including this one), and new test framework all in one go.

Great @jcnelson. I'm just wondering in you have an opinion on not making class a required record parameter for make_zone_file:

I think forcing users to specify a CLASS for each record when calling make_zone_file leads to a lot of needless overhead. The vast majority of users will just want the "IN" class. Should we use "IN" as the default unless another class is specified?

The vast majority of users will just want the "IN" class. Should we use "IN" as the default unless another class is specified?

Yes, this sounds like the most sensible option :)

@jcnelson cool, I've pushed a commit to default to "IN"

Merged to rc-0.14.0.  Will be included in the next master.

@jcnelson  Great, thanks for merging this!

This has been merged and released. Closing.


Accept $quality param in AutoEncoder

Thanks for releasing v3!
I think it would be convenient to set $quality param for AutoEncoder.
If you don't like this change, it's fine, I can create this class in our project.
If you like this change, you can merge it :)

Also, is there a reason GifEncoder and PngEncoder don't support $quality param? It it a limitation of Imagick?

Also, is there a reason GifEncoder and PngEncoder don't support $quality param? Is it a limitation of Imagick?

Thanks for your PR. GIF format uses lossless compression so there is no control for quality. For the PNG format, I have decided to stick with the default value of -1 for the time being, which gives a good result for the file size. However, this could still change, but I want to investigate the results with different parameters first with both drivers. I have created  #1243  for this.
I have moved the method encoderByMediaType() to MediaTypeEncoder::class an hour ago. Please resolve this conflict and I will merge.

Thanks for your PR. GIF format uses lossless compression so there is no control for quality. For the PNG format, I have decided to stick with the default value of -1 (with GD) for the time being, which gives a good result for the file size. However, this could still change, but I want to investigate the results with different parameters first with both drivers. I have created #1243 for this.

Got it, thanks for explanation.

I have moved the method encoderByMediaType() to MediaTypeEncoder::class an hour ago. Please resolve this conflict and I will merge.

Fixed. Does it look good to you?

I think we need a constructor with quality paramter in AutoEncoder::class as well. Currently you have to pass two parameters. Although the type parameter is not necessary.
ImageManager::gd()
    ->read('example.jpg')
    ->encode(new AutoEncoder(null, 0));

And to make things complete, it would be great if you could also integrate the quality parameter in the following classes:

Intervention\Image\Encoders\FileExtensionEncoder::class
Intervention\Image\Encoders\FilePathEncoder::class
Intervention\Image\Encoders\MediaTypeEncoder

Your suggested changes are now already integrated. See: https://github.com/Intervention/image/commit/ea13f2e0bb7c30329712d2f90a6c4dcdd12d628d

Thank you @olivervogel, good changes, I appreciate it.


[Prototype] Task Generator for Shuffle

Warning, this is a prototype and very hacky!
This PR, together with https://github.com/dask/distributed/pull/3765, address the scheduler overhead #6163 by replacing rearrange_by_column_tasks() with a task generator.
Instead of creating n**2 tasks or n log n tasks when staging on the client upfront, this PR makes it possible to delay tasks creations until later.
To enable the task generator set USE_TASK_GENERATOR=1
Preliminary Results
Shuffle with 536554 tasks (no staging) now takes ~6 seconds instead of ~60 seconds on my machine.

from distributed import Client, LocalCluster
from dask.datasets import timeseries
from dask.dataframe.shuffle import shuffle
from dask.distributed import wait
import time

if __name__ == "__main__":
    cluster = LocalCluster(nthreads=1)
    client = Client(cluster)

    ddf_d = timeseries(start='2000-01-01', end='2002-01-01', partition_freq='1d')
    ddf_d_2 = shuffle(ddf_d, "id", shuffle="tasks", max_branch=10**8)  # disable staging

    t1 = time.time()
    ddf_d_2 = ddf_d_2.persist(optimize_graph=False)
    t2 = time.time()
    print("persist returned: ", t2-t1)
    wait(ddf_d_2)
    t3 = time.time()
    print("wait returned: ", t3-t2)
    client.close()

Would you be able to give a high-level summary of what this is doing? An element of your task graph is this All2All class, which when "materialized" represents the actual task graph to do the shuffle? Are you familiar with Blockwise (https://github.com/dask/dask/blob/666b53affac3ba475bd94c7ff4d29752bfa133de/dask/blockwise.py#L125-L133) and SubgraphCallable? On the surface, these sound somewhat similar, but I might misunderstand.
However I think one notable difference is that Blockwise graphs are materialized as plain dicts before being sent to the scheduler. Your changes in https://github.com/dask/distributed/pull/3765 would delay the materialization until the graph reaches the scheduler?

Thanks @TomAugspurger, I did look at Blockwise and SubgraphCallable but I will study them in more detail; you are right they look similar. I think we can generalize all of them into to a delayed task generation API.
I will collect my thoughts and write an issue.


Moredocs

-Dont merge yet.

lol whats up with that last commit? :P

Its such a boring task. I feel like I'm repeating my self over and over. :P

It's really appreciated. I'll have to buy you some beers for all the help! :beers:


GCD function for BinaryInteger

Added a gcd static method to BinaryInteger. The initial implementation uses the binary GCD algorithm.
I believe that gcd is a sufficiently widespread term of art to prefer it over a more verbose spelling. However if others disagree, we could use greatestCommonDivisor instead.

One higher-level question; should we expose a gcd operation on > 2 integers, or on collections? I'm not sure how valuable a variadic gcd would be (since there's not a great way to marshal multiple arguments like that), but is it worth having a more convenient spelling than reduce(into: 0) { $0 = gcd($0, $1) }?

One higher-level question; should we expose a gcd operation on > 2 integers, or on collections?

That’s a good question. We should probably hash out things like that over on issue #10.

Apropos of nothing, and not really relevant or important, but where the descriptive comment for the while loop states:

Each pass removes at least one low-order bit from the larger of the two, so the number of iterations is bounded by the sum of the bit-widths of the inputs.

If I’ve done my analysis correctly then, letting m and n be, respectively, the smaller and larger bit-widths of x and y (after eliminating the trailing zeros), a tighter bound for the number of iterations is given by:
n + (log(2)/log(𝜑) - 1)m
Where 𝜑 = (1+√5)/2 is the golden ratio. So the bound is approximately n + 0.44m, which occurs when the ratio between x and y is near 𝜑 as their roles swap. This is found by accounting for the high-order bits which are eliminated in the subtraction when x and y have the same width.
I do not intend to change the text of the comment.

We should probably hash out things like that over on issue #10.

I'm not sure #10 is the right place to discuss it, but I'm perfectly happy to punt it to another PR; it would clearly be built on top of this anyway.

I'm not sure #10 is the right place to discuss it, but I'm perfectly happy to punt it to another PR; it would clearly be built on top of this anyway.

I was thinking along the lines of discussing the scope of the integer utilities modules and general shape of its APIs.
One thing I’ve found with Github is that it doesn’t really provide an obvious location for discussion, planning, and questions about a project.

@swift-ci test

Thanks @NevinBR! Do you want to do anything further with this before I merge it?

@swift-ci test

Thanks for your patience, @NevinBR!


Preparation for Extension Public Release

[ ] Develop the definition of acceptable quality for a public release
[x] Create the quality management approach on different levels:

Name
Level
Metric
Objective

Telemetry
Product
Telemetry Data (e.g., crash reports, latency, settings configuration)
Stability, performance, real-world usage

Compilation
Formatter
Number of Compilation Errors After Formatting divided by the number of code files
Measure the correctness and reliability of the formatter

Whitespace
Formatter
Number of Non-Whitespace Changes in a given code base
Measure the correctness and reliability of the formatter

Idempotence
Formatter
Percentage of source files changed after 2nd formatting attempt
Formatter idempotence

Parser errors
Parser
Number of Parser Errors divided by the number of tree nodes
Measure the correctness of the parser

Functional
Function
Percentage of Passing Functional Test Cases
Ensure broad feature support and correct parsing behavior

moved to https://github.com/BalticAmadeus/AblFormatter/issues/279


Mouse over bubbles overlap in left navigation

See linear.app's Developer Docs team for more information.


[bug]: nodes required status incorrect post pydantic v2

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Linux
GPU
cuda
VRAM
No response
What version did you experience this issue on?
main
What happened?
After the pydantic v2 upgrade, the node schemas' required status no longer works correctly.
If you have a missing connection on a required field, the UI no longer prevents you from enqueuing the workflow.
Screenshots
No response
Additional context
No response
Contact Details
No response

Resolved in #5175


Support for Ecto 3.2

Hi, this PR aims to support Ecto 3.2.
Besides adding support for mix format, I've added embed_as/1 and equal?/2 to Ecto.Type implementations (Action, Patch, Schema) and prepare_query/3 to Repo Queryable.
All tests are passing with Elixir 1.9 and Erlang 22, and I've tested it too with my company's private repos that already use ex_audit 0.6.

Nice work

I just published v 0.7


fix styles not being added when using toHaveStyle()

Fixes: #3297
I checked out every commit to find what caused this, and it seems that this commit and this commit were the culprit. It seems like having window as either false or undefined makes jest-dom's toHaveStyle function fail by not rendering any styles at all. I imagine this has something to do with how jest interacts with the window object.
@probablyup I don't exactly know the reason behind these commits so I hope this doesn't break things elsewhere. I tested the build locally and I can confirm that this will fix toHaveStyle

Hi @probablyup @kitten sorry to bother you but this is preventing us and I believe quite a few people from upgrading to 5.2.0 since the tests cannot be run with it.

@Lazyuki you'll need to switch your base branch to legacy-v5

Done.

Looking at the code I don't think this will break anything, so long as people don't have a window object in their SSR environment that has an HTMLElement property. That's the heuristic we use for our IS_BROWSER check.

I just added a console log to my Jest config and it says it does exist:
console.log('HTMLElement in window: ', 'HTMLElement' in window);
=> HTMLElement in window:  true

Is this unwanted behaviour @probablyup?
Only reason I'm asking is because my tests are now failing as a result of this change (v5.2.1) using react testing library + jest


commiting agian

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Completed assignment.
What did you learn from the changes you have made?
Learned about GIT command and its uses
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
NO
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, DSI Team helped me as I made changes to main branch initially instead of assignment.
How were these changes tested?
ZSH
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[Yes ] I can confirm that my changes are working as intended

Assignment

You did a great job here!
Please go ahead and close this pull request now. Thanks!

Work completed and graded successfully


chore: release 2.6.2

:robot: I have created a release *beep* *boop*
2.6.2 (2024-06-25)
Bug Fixes

build: publish custom tags and final images in parallel (6180f23)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.6.2 :sunflower:


Chapter 18 (trend analysis), how to retrieve year?

In the chartevents.csv table we downloaded,
one CHARTTIME, is  5/12/34 12:00
Can someone help with what does 34 mean? How to translate to 34 to a correct calendar year.
Thanks
Jin

If you're extracting this from MIMIC II or III, the dates have been shifted, and the years should be nonsensical as the shifting is necessary to protect PHI.  It is possible to apply for access to get the actual years, and I would e-mail<EMAIL_ADDRESS>to ask how.
I am not certain, but the authors likely applied for this additional access themselves, and this was how they were able to write their chapter.
Since this isn't a question related to the code, I will close the issue, but if I have misunderstood, feel free to let me know.

@jinjinzhou as Jesse mentions, the dates are shifted by several hundred years for de-identification purposes. Are you looking at the raw text or using an application like Excel? Excel mashes up the shifted dates, which might explain why you are seeing a nonsensical value (34 Dec).

Thanks, Jesse and Tom. We are using MIMIC-III. I am ccing mimic-support<EMAIL_ADDRESS>to see if any algorithm we may have to translate year.
Thanks,
Jin
From: Jesse Raffa<EMAIL_ADDRESS>Reply-To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Date: Friday, November 30, 2018 at 12:14 PM
To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Cc: "Zhou, Jin - (jzhou)"<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MIT-LCP/critical-data-book] Chapter 18 (trend analysis), how to retrieve year? (#14)
If you're extracting this from MIMIC II or III, the dates have been shifted, and the years should be nonsensical as the shifting is necessary to protect PHI. It is possible to apply for access to get the actual years, and I would e-mail mimic-support<EMAIL_ADDRESS>to ask how.
I am not certain, but the authors likely applied for this additional access themselves, and this was how they were able to write their chapter.
Since this isn't a question related to the code, I will close the issue, but if I have misunderstood, feel free to let me know.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/MIT-LCP/critical-data-book/issues/14#issuecomment-443308772, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANJYTy0wusg_jDVbh_9Mecs0pelxGQG1ks5u0YODgaJpZM4Y8LTl.

@jinjinzhou There is no need to email us. We prefer to discuss these issues on the public repository (as noted at: https://mimic.physionet.org/help/).
You can typically treat the dates in MIMIC as standard dates. It should not be necessary to translate them. What software are you using the view the data?

Thanks, Tom. I followed instruction as noted in MIMIC-III to a postgres SQL database and vied them by R.
Jin
From: Tom Pollard<EMAIL_ADDRESS>Reply-To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Date: Friday, November 30, 2018 at 12:43 PM
To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Cc: "Zhou, Jin - (jzhou)"<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MIT-LCP/critical-data-book] Chapter 18 (trend analysis), how to retrieve year? (#14)
@jinjinzhouhttps://github.com/jinjinzhou There is no need to email us. We prefer to discuss these issues on the public repository (as noted at: https://mimic.physionet.org/help/).
You can typically treat the dates in MIMIC as standard dates. It should not be necessary to translate them. What software are you using the view the data?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MIT-LCP/critical-data-book/issues/14#issuecomment-443317498, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANJYT4KeRZL0WVArgHlkRCxIvaoxAyG4ks5u0Yp7gaJpZM4Y8LTl.

The date that you've listed above (CHARTTIME, is 5/12/34 12:00) does not occur in MIMIC-III as far as I am aware. If this date appears in your database, please provide us with a query to find this value (e.g. select charttime from chartevents where row_id = X). Please also read https://www.nature.com/articles/sdata201635 and https://mimic.physionet.org/mimicdata/time/ if you have not already done so).

How are you viewing it in R?  Are you using RPostgreSQL?

Yes,
From: Jesse Raffa<EMAIL_ADDRESS>Reply-To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Date: Friday, November 30, 2018 at 12:56 PM
To: MIT-LCP/critical-data-book<EMAIL_ADDRESS>Cc: "Zhou, Jin - (jzhou)"<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MIT-LCP/critical-data-book] Chapter 18 (trend analysis), how to retrieve year? (#14)
How are you viewing it in R? Are you using RPostgreSQL?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MIT-LCP/critical-data-book/issues/14#issuecomment-443320970, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANJYT8ZZXKnuqYDA0Ys4OSv-GJX_Y6FVks5u0Y1BgaJpZM4Y8LTl.

It is difficult to diagnosis this if we can't replicate it on our end.  Are you are able to find what @tompollard has asked for?  (row_id)

Jin, can you post the image on github.com, it's not showing up here.
https://github.com/MIT-LCP/critical-data-book/issues/14

@jinjinzhou this is an Excel screenshot. As mentioned, Excel messes with the values. Try looking at the raw data (e.g. in a plain text editor).

Jin, can you post the image on github.com, it's not showing up here.
#14

The data set description about chartevents.csv is available from the website https://mimic.physionet.org/mimictables/chartevents/
The dates are all shifted based on the website https://mimic.physionet.org/mimicdata/time/
It seems that only year had been shifted. Month and day are from original record.
I am just wondering is there anyway to find original year for each observation.

To echo above comment, we don't need to have exact year - just a number in the same order as the calendar year order. Thanks,

The year (or sequence of year) is not available in MIMIC-III unfortunately. We understand that this is a limitation and are considering alternative options for handling de-identification for the next release of MIMIC.


Update file utilities

This updates a couple of our file utilities to use Foundation, based on the work in #284.

@swift-ci please test

I tested Linux locally and tests pass, taking this despite @swift-ci unavailability to unblock other work.


Fix incorrect spacing when pretty-printing @_documentation

With attribute such as @_documentation(visibility: private), swift-format incorrectly prints no spacing between visibility and private.

Let me know when you've resolved the merge conflicts and I'll kick off CI.

@allevato I resolved the conflicts. 🙏


FetchError: invalid-json

I have a Discord Bot and on my Windows 10 64x PC it works fine, but on my VM Debian 10 Server i got the following error and I dont know why.
If i run on my computer(Windows 10 VSC Debugger) the

but on my VM (Debian 10)

tbh i dont know why it works on my pc fine and on my server i got the error with the same packages and versions
Error:
/home/lennart/Discordbots/v2/node_modules/node-fetch/lib/index.js:272
                                return Body.Promise.reject(new FetchError(`invalid json response body at ${_this2.url} reason: ${err.message}`, 'invalid-json'));
                                                           ^
FetchError: invalid json response body at https://karmatop.de/addon/pxl-api.php?name=L3nnart_ reason: Unexpected token < in JSON at position 0
    at /home/lennart/Discordbots/v2/node_modules/node-fetch/lib/index.js:272:32
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  type: 'invalid-json'
}

Example Code
const url = `https://karmatop.de/addon/pxl-api.php?name=` + spieler; //spieler is a variable/argument from the discord bot, for example  "L3nnart_"
            fetch(url, {
                method: "GET",
                headers: {
                    Accept: "application/json",
                },
            })

Your Environment

software
version

node-fetch
2.6.1

node
16.8

npm
7.21.0

Operating System
Deabian/Windows

cloudflare bot protection bruh moment

thinking if it might be a BOM token in the beginning...?
could you check what the text / Uint8array response is?

bump

Bumping the wrong issue... should maybe bump #541

Bumping the wrong issue... should maybe bump #541 with a potential fix: #1482

Thank you for that.


VM838 display.js:331 Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '[object HTMLBodyElement]' is not a valid selector.

when i try to use $.scrollTop().
$.scrollTop()

23:29:45.660 VM838 display.js:331 Uncaught DOMException: Failed to execute 'querySelectorAll' on 'Document': '[object HTMLBodyElement]' is not a valid selector.
    at DisplayJS.select (http://localhost:8000/node_modules/display.js/dist/display.js:331:52)
    at DisplayJS.s (http://localhost:8000/node_modules/display.js/dist/display.js:343:16)
    at DisplayJS.scrollTop (http://localhost:8000/node_modules/display.js/dist/display.js:393:14)
    at <anonymous>:1:3

I’ll try to fix that. Thanks for reporting the bug 🐜

It has been fixed in the latest commit, I'll release this version soon, I just need to see if there is some other bugs.


Add support to HLS Image Media Playlists

Close: https://github.com/google/shaka-player/issues/2429

Note: I have yet to add tests.

Ready for review!

Hi @avelad , is there a sample on how this is expected to be used? we recently added support for image adaptations for Dash and had to do it externally cause there is no model for image tracks, so wondering how this relates to dash, if at all.

@OrenMe
https://github.com/image-media-playlist/spec
https://developer.roku.com/en-gb/docs/developer-program/media-playback/trick-mode/hls-and-dash.md#hls-considerations

@OrenMe the DASH thumbanils support was added: https://github.com/google/shaka-player/commit/b9b3cc809828e569af4266ac42bb469abc33f26a (It will be released in 3.1.)

thanks @avelad !

@joeyparrish can you review this PR?

@avelad I need an example how to use thumbnail, can you please provide one?


Using custom ILoggerProvider and IServiceFactoryProvider breaks logging scopes of WebHost

Create a sample AspNetCore application. Add a custom logging Framework that implements ILoggerProvider. Observe the behaviour of logging scopes, for each request you get several scopes that contain details about the connection and the request.
Now add a custom DI container framework that implements IServiceFactoryProvider and a observe again. The logging scopes are lost.
You can see that your LoggerProvider implementation is initialized twice. One time immediately after the start of the application, when the WebHost is initialized. After that, the custom DI container is registered and the logger is initialized again. Also, a new IExternalScopeProvider is registered at the LoggerProvider.
The problem seems to be that the WebHost still uses the old, orphaned scope provider.

This might be related to these changes https://github.com/aspnet/Hosting/commit/6b095cf533950e7fc93ebc475093bafac70058cb
cc @pakrym

This issue was moved to aspnet/Hosting#1536


Add number of indirect samples to render settings

Instead of a number, I suggest a "factor". There should be one place to select sample count. The rest is factors IMHO.

In this case, it's actually the same thing: if for each of the N primary rays, there are K direct/indirect rays, then there will be N*K direct/indirect rays, so K is both a number and a factor.
Maybe in terms of UI we can use the word "factor" instead of "number", sure.

Clarisse seems to have intuitive shading rate controls, maybe a good source of inspiration:
https://www.clarissewiki.com/3.6/shading_oversampling.html


feat: add baseSort configuration option

What: Added a baseSort configuration option

Why: Ability to override the default stable sort for tie-breaker items

How: By adding a new configuration option and implementing some inversion of control and a new default

Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

[x] Added myself to contributors table (I'm assuming I can do this with the bot after this)

@all-contributors please add tannerlinsley for code

Looks like the test failed, but I can't really decipher why.

Thanks!

:tada: This PR is included in version 4.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Sync API for CosmosConflict

Current SDK doesn't have sync API support for CosmosConflict
This can be added on-demand, if a customer asks for it.

The issue can be created in case any customer asks for it. Right now it is not in our plan.


This page is not available

https://github.com/h5dotnet/Bridge/wiki/global-configuration
Referenced on https://github.com/theolivenbaum/h5/blob/master/Tests/Placeholder/h5.json

Try to use web archive. I think H5 does not have copied documentation.
https://web.archive.org/web/20200929021729/https://github.com/bridgedotnet/Bridge/wiki/global-configuration

Will it be fixed in the future?

Ask @theolivenbaum, maybe he can some glue regarding that. But web-archive is what I am personally using for moment.

Unfortunatelly the bridge team deleted their wiki content, but well found to check archive.org @hardhub!
I've updated it now to point to the right place.


3 to 6 20221013

➡ Forward port
Port ign-gazebo3 to ign-gazebo6
Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Out of scope for this PR, but we should probably backport our fixes on 7 to clean up test failures/warnings here where possible.


TimeStats to issue

@rekby there is a TimeStats struct containing these fields, so I guess we should just use that one here instead right? (https://github.com/xanzy/go-gitlab/blob/master/time_stats.go)

Yes, thanks.
First time I did same as near struct Author.

Thanks @rekby!


Adjust permission of /etc/ceph to allow Cinder to create Ceph Volumes

Cinder Volume needs access to /etc/ceph to create Ceph Volumes. This
change passes and conf_directory_mode as a role parameter to adjust
permissions accordingly.
Note: This depends on an upstream pull request for the ceph-common role
https://github.com/ceph/ceph-ansible/pull/485
Fixes: #747
(cherry picked from commit a314356c58b55c7ec472abc53bbefb0e88afef38)

:+1:

:+1:


optimize: replace Random by ThreadLocalRandom in RandomLoadBalance

ThreadLocalRandom will achieve less contention.
Replace Random by ThreadLocalRandom in RandomLoadBalance，refer to the implement of RandomLoadBalance in dubbo.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
test case LoadBalanceTest already exist.
Ⅳ. Describe how to verify it
test case LoadBalanceTest already exist.
Ⅴ. Special notes for reviews

Codecov Report

Merging #2573 into develop will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2573      +/-   ##
=============================================
- Coverage      51.18%   51.01%   -0.18%
+ Complexity      2805     2801       -4
=============================================
  Files            554      554
  Lines          17768    17747      -21
  Branches        2101     2062      -39
=============================================
- Hits            9095     9054      -41
+ Misses          7815     7810       -5
- Partials         858      883      +25

Impacted Files
Coverage Δ
Complexity Δ

...seata/discovery/loadbalance/RandomLoadBalance.java
100.00% <100.00%> (ø)
2.00 <0.00> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
3.00% <0.00%> (ø%)

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
3.00% <0.00%> (ø%)

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterTMRequestConvertor.java
94.73% <0.00%> (-5.27%)
3.00% <0.00%> (ø%)

...protobuf/convertor/RegisterRMRequestConvertor.java
90.47% <0.00%> (-4.77%)
3.00% <0.00%> (ø%)

... and 22 more

please help to see if other classes need to be processed

please help to see if other classes need to be processed

Already checked, no more classes need to be processed.

please try again for ci @slievrly


Bump to 0.52.0, update changelog

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors r+
Thank you! I always love reading theise!

@bors r+
Thank you! I always love reading theise!

:pushpin: Commit 5168b7e36b7905d5958fd376685554d397e6fc61 has been approved by Eh2406

:pushpin: Commit 5168b7e36b7905d5958fd376685554d397e6fc61 has been approved by Eh2406

:hourglass: Testing commit 5168b7e36b7905d5958fd376685554d397e6fc61 with merge 660ec3f50bc40928752a2e2dac50b1dcce8ca6e2...

:hourglass: Testing commit 5168b7e36b7905d5958fd376685554d397e6fc61 with merge 660ec3f50bc40928752a2e2dac50b1dcce8ca6e2...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing 660ec3f50bc40928752a2e2dac50b1dcce8ca6e2 to master...

:sunny: Test successful - checks-actions
Approved by: Eh2406
Pushing 660ec3f50bc40928752a2e2dac50b1dcce8ca6e2 to master...


add CUDA mining support

Tested on Linux Ubuntu 18.10. Haven't been able to test with multiple cards yet though. Successfully tested with 2 Tesla v100s.
The following instructions assume you've done this first.
sudo apt install -y build-essential
sudo apt install -y cmake
wget https://developer.nvidia.com/compute/cuda/10.1/Prod/local_installers/cuda_10.1.168_418.67_linux.run
sudo sh cuda_10.1.168_418.67_linux.run
mkdir -p go/src/github.com/asdvxgxasjab/
cd go/src/github.com/asdvxgxasjab/
git clone https://github.com/asdvxgxasjab/cruzbit.git
cd cruzbit
git checkout cuda
cd cuda
mkdir build
cd build
cmake ..
make
cd ../../client
go build -tags cuda
LD_LIBRARY_PATH=../cuda/build ./client -numminers <num GPUs> <whatever other arguments you run your client with>

Note there seems to be an issue when using with a host that has more than 1 GPU device. Investigating.

Nice update. Is there any plan to include the most recent architecture (Turing)? I believe it is SM 7.5

Nice update. Is there any plan to include the most recent architecture (Turing)? I believe it is SM 7.5

I think it should work. The function in there that translates SM version to cores isn't even used right now. I'll probably remove it.

RTX (Turing) hashes. Have a rig w 1070 tis and 2070s. Would be nice if logs could show hashrate per GPU to see Turing vs Pascal performance.

This might be useful for some people. From the #help channel on Discord:

a workaround for the cmake install is to just edit the CMakeLists.txt in cruzbit/cuda and change the first line that says VERSION 3.12 to VERSION 3.10
and then you can just use default ubuntu cmake version
you can also install the latest go with snap: sudo snap install go --classic

@asdvxgxasjab, since this #25 was merged into master, following the directions given for enabling cuda no longer work. cuda/BUILDING.md directions do not provide any different functionality over the existing cpu based code.

@asdvxgxasjab, since this #25 was merged into master, following the directions given for enabling cuda no longer work. cuda/BUILDING.md directions do not provide any different functionality over the existing cpu based code.

Hmm. Does your client start up and log "CUDA initialized" when you run it?

No, it behaves just like it would for standard cpu mining.


Listing all available targets?

Hello
I would like to list all targets that are available for debug.
I would suggest a list of the strings used:
const debugFactory = require('debug');
var a = debugFactory('worker:a');
console.log(debugFactory.getAllAvailableTargets());
// result:
// [ "worker:a" ]
// or
// [ "worker", "worker:a" ]

I have read the comments of the #255, that is suggesting that it would be a memory leak. Is that so? If we cache the "keys" and not the objects, I don't think that it would be a memory leak?
I could submit a PR if this idea is accepted.

If this is just for debugging purposes, require('debug').names will give you the list of regexes that match the enabled namespaces.
Otherwise, this would be storing strings indefinitely, which might leak given the current implementation. #678 has more information about that, and #425 currently discusses .enable() a bit more too.
I'll consider this but right now it's not something I want to support until v5.

Thanks Qix,
I will see if I can help on the memory leak, as a first step before discussing this one :-)
I hope your house move was fine, your new job is great and your family bring you hapiness !
Have a nice day

Sorry for the delayed response - thank you for the kind words @jehon ^^


SteamGC.on("message" == 4009

Hello, i found out that k_EMsgGCServerGoodbye = 4009, but how to react to that?
I mean, should i close the connection and try again or what do that mean?
Can you pls help me?

Are you using this module? If so, it's already being handled.

actually i just found out directly after posting this, that the Problem occurs with require("steamid"); and then with the SteamGC.on("message", listener out of that package. When i searched the Internet i found your Project at first with the code 4009 mentioned. I decided to let the Issue stay to maybe get a usefull idea how to solve it.
Acutally i think i already found a solution, with just resending my request. Time will tell if its a good solution. Or even if the message 4009 accoures in the normal system behavior, maybe it was just because of the test scenario, which got sometimes executed.
thx for the fast answer 👍


Fix #6: add option to wrap text on new lines, paragraphs and writes

Hi,
Regarding issue #6:
The calls to new_line(), new_paragraph(), and write() are able to wrap the text argument by using a maximum of 120 characters per line.

Other widths could be set by the user for every method call.
For long words (longer than 120 characters): they will not be broken. Otherwise, the word would be displayed on more than one line whereby the word's parts are separated by a whitespace if copied to the clipboard - which is not desirable since the word is initially not broken (and will stay not broken). This could be reversed by simply altering the source code.
Other limitations include: if there were other whitespaces at the end of any line (such as tabs, newlines, more than one whitespaces, etc...), then after wrapping they will collapse to one newline character only if they existed at the end of lines. This is still fine for md files since this is the default behavior for Markdown renderers anyway.

Best,
MK

Seems fine but you have one test which is failing test_references_placed_in_markdown_file. I suppose will pass if we pass wrap_width=0 the test will pass.
    def test_references_placed_in_markdown_file(self):
        md_file = MdUtils(file_name="Test_file", title="")

        text = "mdutils library"
        reference_tag = "mdutils library"
        link = "https://github.com/didix21/mdutils"

        expected_value = "\n\n\n[mdutils library0][mdutils library0]\n" \
                         "[mdutils library1][mdutils library1]\n" \
                         "[mdutils library2][mdutils library2]\n" \
                         "[mdutils library3][mdutils library3]\n" \
                         "\n\n\n" \
                         "[mdutils library0]: https://github.com/didix21/mdutils0\n" \
                         "[mdutils library1]: https://github.com/didix21/mdutils1\n" \
                         "[mdutils library2]: https://github.com/didix21/mdutils2\n" \
                         "[mdutils library3]: https://github.com/didix21/mdutils3\n"

        for i in range(4):
            md_file.write(text=md_file.new_reference_link(
                link=link + str(i),
                text=text + str(i),
                reference_tag=reference_tag + str(i)), wrap_width=0)
            md_file.write('\n')

        md_file.create_md_file()

        created_data = MarkDownFile.read_file('Test_file.md')

        self.assertEqual(expected_value, created_data)

Initially I had a default value of 0 passed but I unfortunately did not think that altering it would break the tests.
The problem lies in write('\n') whereby this gets wrapped into an empty string.
I'm gonna try to resolve this without having to change the original test.

@didix21 The issues had been resolved 👍


Use AOT mode in the Dart SDK binaries

Use AOT mode in the Dart SDK binaries (faster startup and more predictable performance)
List of items to account for before this task is complete

[ ] Switch frontend server invoked by dartdev to AOT mode
[ ] Switchg frontend server invoked by flutter tools to AOT mode
[ ] Switch DDS which is launched as a separate process to AOT mode
[ ] Switch dart2js/dartdevc which are launched as a separate process from dartdev to AOT mode
[ ] Switch dartdev which includes a number of smaller utilities to AOT mode
[ ] Remove the kernel isolate from the VM, rename the VM binary to dartvm and have the VM only support running from kernel files

CL to switch dds to run dds in AOT mode https://dart-review.googlesource.com/c/sdk/+/327140

CL to switch gen_kerenl to run in AOT mode when invoked from 'dart compile exe' command https://dart-review.googlesource.com/c/sdk/+/327520?tab=checks

PR to add --frontend-server-starter-path option to flutter run and flutter test: https://github.com/flutter/flutter/pull/135038
PR to modify flutter_tools to start frontend_server from an AOT snapshot: https://github.com/flutter/flutter/pull/136282

PR to make FrontendServerClient start the frontend server from the AOT snapshot in the Dart SDK: https://github.com/dart-lang/webdev/pull/2263

On the topic of AOT compiling our tools:
$ tools/test.py -c dart2analyzer --use-sdk co19/Language
...
[01:20 | 100% | +20451 | -   96]

=== 20451 tests passed, 96 failed ===

________________________________________________________
Executed in   81.51 secs    fish           external
   usr time  560.09 secs  134.00 micros  560.09 secs
   sys time   57.52 secs  769.00 micros   57.52 secs

The same but changing to run from AOT snapshot (which takes ~12s to produce):
$ tools/test.py -c dart2analyzer --use-sdk co19
[00:52 | 100% | +20451 | -   96]

=== 20451 tests passed, 96 failed ===

________________________________________________________
Executed in   54.07 secs    fish           external
   usr time  334.59 secs  124.00 micros  334.59 secs
   sys time   32.50 secs  799.00 micros   32.49 secs

/cc @scheglov @bwilkerson @srawlins

Very nice!

I think it's still in JIT mode because we don't support running plugins from AOT; we always run them from source (JIT); please forgive any misunderstandings I have here 😅 .
I did some prototyping with AOT-compiled plugins, for our plugins V2; so it's a thing we can do.

Note also that the current approach to run macros is to compile them into kernel files, and run in the same process.

@a-siva looking at pkg/dartdev/lib/src/sdk.dart and pkg/dartdev/lib/src/analysis_server.dart, it looks like the analysis server still hasn't been switched over to AoT. But the box "Switch frontend server invoked by Analysis server to AOT mode" is checked above. Am I misreading things, or is it possible that this box got checked by accident?
I'm wondering because discussion at #56454 makes it seem like the analysis server is still being invoked in Jit mode.

Yes, the analysis server has not yet been switched to AOT yet. Not sure why it had the checked flag above. Fixed it.

Note also that the current approach to run macros in analyzer and DAS is to compile them into kernel files, and run in the same process.

We have had this discussion with the CFE team too and they have an out of process mode for executing the kernel files generated from macros. maybe the Analyzer should also consider this.

I think it's still in JIT mode because we don't support running plugins from AOT; we always run them from source (JIT); please forgive any misunderstandings I have here 😅 .
I did some prototyping with AOT-compiled plugins, for our plugins V2; so it's a thing we can do.

Yes, it is still JIT mode, there was some discussion regarding plugins here https://docs.google.com/document/d/1W0JmNwlWD9W8Jf1vzC-W7MSOR-l1XOquVUCaf_7gs3A/edit?resourcekey=0-3fhJDVXmmWr4gLkBcRB9Sg&disco=AAAAwkyH-sY

cc @bwilkerson @mit-mit this is related to our discussions regarding prioritizing efforts which would allow us to switch analyzer to AOT mode targeting next stable.


[BUG]  413 HTTP response returned when uploading large files via LiveResponse

I am seeing this behaviour on:

OS: Linux
Carbon Black Cloud Products: Enterprise EDR, Audit & Remediation
Python Version: 3.11.2

Describe the bug
When uploading large files to endpoints via LiveResponse, a HTTP 413 response is returned from the backend:
\r\n<title>413 Request Entity Too Large</title>\r\n\r\n
413 Request Entity Too Large
\r\n
nginx\r\n\r\n

Steps to Reproduce
Upload a large file (e.g. 40MB) to an endpoint using the cbc sdk:
with endpoint.lr_session() as lr_session:
  lr_session.put_file(fp, dest_path)

Expected behavior
Until recently, it was possible to upload a 40MB file to clients using the cbc SDK.

I did some additional testing: if the file is smaller than 1MB, the upload still works, otherwise it fails returning the HTTP 413 header.
Uploading the large file (40MB) via browser seems to work though.
Can you please into this issue ? thx

What version of the SDK are you using as we attempted a fix for this in 1.5.6 with this PR https://github.com/carbonblack/carbon-black-cloud-sdk-python/pull/533

Sorry for the slow response. Your saying this was support previously but has stopped working? Do you know when that stopped working?

Yes this worked for a long time and stopped working maybe three or four weeks ago.

What version of the SDK are you using as we attempted a fix for this in 1.5.6 with this PR

I'm using version 1.5.6

@7a6570 Can you open a support case with us and drop the case number here. Nothing has changed in the SDK so this is likely the backend API somewhere

We made one minor change in 1.5.6 with this PR https://github.com/carbonblack/carbon-black-cloud-sdk-python/pull/533
Can you try using 1.5.5 and letting me know if that makes a difference

We have confirmed a backend issue and it is being worked on

We have confirmed a backend issue and it is being worked on

OK, thanks for the update. I already opened a case, the number is: 35912150


How to use widget instead of string for text variable?

The problem now is that the direction setting is used for the style, not the direction of the text itself, and to solve this problem, it would be better to receive a widget as a child instead of a string.

I solved this by adding textDirection: widget.textDirection
 Widget marquee = ListView.builder(
      controller: _controller,
      scrollDirection: widget.scrollAxis,
      reverse: widget.textDirection == TextDirection.rtl,
      physics: NeverScrollableScrollPhysics(),
      itemBuilder: (_, i) {
        final text = i.isEven
            ? Text(
                widget.text,
                style: widget.style,
                textScaleFactor: widget.textScaleFactor,
                textDirection: widget.textDirection,
              )
            : _buildBlankSpace();
        return alignment == null
            ? text
            : Align(alignment: alignment, child: text);
      },
    );


Transfer the native coin to smart contract

Hey... how can i transfer  my native coin of cosmos for example 2 atom or anything to my smartcontract through a function

If you just want to transfer it to the contract, use a simple bank MsgSend. Then the balance is owned by the contract and it can do anything it wants with it. However, this way the transfer is not processed by the contract, so you cannot track where the tokens came from.
If you want to execute the contract and send funds at the same time, use MsgExecuteContract. This has a funds field which are tokens you send along with the execute.

If you just want to transfer it to the contract, use a simple bank MsgSend. Then the balance is owned by the contract and it can do anything it wants with it. However, this way the transfer is not processed by the contract, so you cannot track where the tokens came from.
If you want to execute the contract and send funds at the same time, use MsgExecuteContract. This has a funds field which are tokens you send along with the execute.

Hi ,  basically i want to stake my fund on contract and do some stuff while i have staked my fund. Can you give me an example or any reference if possible on how to do it.
Thanks in advance : )

Please read https://book.cosmwasm.com that should clarify a lot.


Add Wagyu Import Workaround

I suggest to put this content in the developer docs https://docs.lukso.tech/ and not in the "end non technical user" support section

Closing this, reopened on our docs repository:

https://github.com/lukso-network/docs/pull/905


Fix refined queries which contain field expressions

@mtoy-googly-moogly fixed an issue where no fields would show up when a query was refined, e.g.
query: flights -> airport_dashboard {? origin.code: 'SJC' }

However, if the query contained any field definitions rather than field references, the resulting query would not correctly re-define those fields.
This PR should fix that.
Two sample models (iowa.malloy and flights_beta.malloy) are now compiling again with this change.

nice, thanks


Binding programs without drawing anything can result in inconsistent uniform state

Bind a program with a geometry shader.
Set the first uniform in the geometry shader to value A.
Without rendering anything, bind a different program without a geometry shader.
Set the first uniform in the vertex shader to value B.
Render something. The results will use value A.

Adding a C3D_UpdateUniforms(GPU_GEOMETRY_SHADER) between steps 2 and 3 fixes the problem.
If I understand the internals correctly, the problem is that the C3D_{FV,IV,Bool}UnifDirty flags don't get cleared when binding a new program.

Without rendering anything

That is the problem. Why are you binding a program, then afterwards binding another one without having rendered anything in the first place? Can't you avoid binding the first program since it's not used for rendering?

Context: I'm adding particle effects to a game I'm working on. The rendering code configures the shading, etc., binds the program, then loops through all particle sources, sets up buffers and calls DrawArrays. Regular objects get drawn afterwards. If there aren't any particle sources, the graphics get glitchy.
So yes, I can easily avoid binding the program at all. But this is really confusing behaviour. If this is intentional, IMO it should be documented somewhere.


Stack overflows in tests under package:flutter/

Steps to Reproduce
Add a stack overflow bug to  test/widgets/sliver_fill_viewport_test.dart
I would hope running the test with a stack overflow would return a stack trace providing some indication of where the stack overflow occurred but does not. Instead the vm appears to hard crash.
Output running test with -v:
  Shell subprocess terminated by ^C (SIGINT, -2) after tests finished.
  Test: /Users/jacobr/git/flutter/2/flutter/packages/flutter/test/widgets/sliver_fill_viewport_test.dart
  Shell: /Users/jacobr/git/flutter/2/flutter/bin/cache/artifacts/engine/darwin-x64/flutter_tester

  package:stream_channel                                    _GuaranteeSink.addError
  package:flutter_tools/src/test/flutter_platform.dart 216  _FlutterPlatform._startTest.<fn>
  ===== asynchronous gap ===========================
  dart:async                                                _asyncThenWrapperHelper
  package:flutter_tools/src/test/flutter_platform.dart 206  _FlutterPlatform._startTest.<fn>
  package:flutter_tools/src/test/flutter_platform.dart 371  _FlutterPlatform._startTest
  ===== asynchronous gap ===========================
  dart:async                                                _asyncThenWrapperHelper
  package:flutter_tools/src/test/flutter_platform.dart 143  _FlutterPlatform._startTest
  package:flutter_tools/src/test/flutter_platform.dart 136  _FlutterPlatform.loadChannel

Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.5 16F73, locale en-US, channel unknown)
    • Flutter at /Users/jacobr/git/flutter/2/flutter
    • Framework revision d522c8bdc7 (4 days ago), 2017-06-15 08:02:25 -0700
    • Engine revision 784e975672
    • Tools Dart version 1.24.0-dev.6.7

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.2)
    • Android SDK at /Users/jacobr/Library/Android/sdk
    • Platform android-25, build-tools 25.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 8.3.2, Build version 8E2002

Related https://github.com/flutter/flutter/issues/10835.

This works as expected on Linux, but the Mac OS build of flutter_tester crashes


Service unavailable triggering on new taxon ranges when kmls ~4MB

This happens when a KML ~>= 4km is uploaded via http://www.inaturalist.org/taxon_ranges/new
for example https://dl.dropboxusercontent.com/u/1288081/le_ol.kml

What's the taxon in question?

the above kml is of http://www.inaturalist.org/taxa/39670-Lepidochelys-olivacea - but it happens whenever the KML is large, irrelevant to the taxon_id associated with the new taxon_range

The symptom was a long-running Passenger process, running for 30+ minutes and spiking CPU. It is possible that was "normal", but the process should minimally be put into a delayed job so we don't get a Passenger queue backup and show the heavy load message

Ok. Just for peace of mind, can you post a KML of a taxon that doesn't have a massive, date-line spanning range?

sure, I can post a large shapefile with a more contained area, but I won't be able to guarantee that it causes the service_unavialable error in production since I don't think Patrick wants me trying that again in production

okay this one is only 3.4 MB, but its fairly complex short of spanning the date line https://dl.dropboxusercontent.com/u/1288081/coyote.kml - will that work?


Fix issue with name clash on auto implementation of AbiEncode and AbiDecode

Description
The callpaths generated for struct declarations are incorrect, and this causes the auto generated impls of AbiEncode and AbiDecode to refer to the wrong type.
The shadowed_glob_imports test case shows how this causes a compilation error when there is a name clash between a star imported struct and a locally declared struct, but it looks like problem exists in general, and that the generated impls will in general refer to a type that doesn't exist.
The immediate bug is that submodules of external modules are set to is_external = false, when they should inherit their is_external flag from the parent module.
There are other issues as well which cause tests in the references part of the test suite to fail. @ironcev has promised to look into this. This is currently blocking for the PR.
Checklist

[ ] I have linked to any relevant issues.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book).

[ ] If my change requires substantial documentation changes, I have requested support from the DevRel team

[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
[ ] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[ ] I have requested a review from the relevant team or maintainers.

@jjcnn Setting is_external = <current is external> is a valid change as long as I can see. But it looks like it triggered some other issues which apparently rely on the existing setting of is_external to false.
I've taken a look a look at the failing tests for references. The failures has nothing to do with references as such. They are caused by the facts that all of those tests have a separate file with traits defined in them (impls.sw), as well as trait implementations. Those traits now do not get properly resolved.
Also, there are other E2E tests failing like:
should_pass/language/use_absolute_path
should_pass/language/generic_impl_self_where

They also have traits defined in separate files and used in main.sw.
To the E2E tests, the go_to_definition_for_paths LSP tests is also failing perhaps for the same reason.
It looks to me that the simple one line change triggered some other issues related to trait import and resolution.
One thought crossing my mind. The opening sentence in the PR description:

The callpaths generated for struct declarations are incorrect
reminds me a lot of #5500. Perhaps it makes sense to take a closer look on that issue and fix it first.

@ironcev : Thanks - that helps quite a bit. I'll take a look at the issue you linked to, and keep digging.

@ironcev : Sadly, a fix of #5500 does not solve the problem, but I suspect it's just another one of many interlocking issues, so I've pushed a fix and continuing from here.

I tried it with this branch but I still get an error. Unfortunately, I do not get any specifics just: error: Could not generate the entry method. See errors above for more details. and there is nothing above :/. Steps to recreate:
* clone `fuels-rs` and checkout `hal3e/name-clash-abi-encode`

* cd into `fuels-rs/e2e/sway/bindings/type_paths`

* `forc build` or `forc build --json-abi-with-callpaths`

P.S. I installed forc with:  cargo install --locked forc --force --git https://github.com/FuelLabs/sway --branch "jjcnn/name_clash_struct_def_glob_import"

Doing the above does indeed still fail. I originally tried to recreate your test case within the sway repo where it seemed to compile, but it no longer does, so there's something else going on.
I'll remove the references to #5864 from this PR, and add your recreation steps to the issue.


Ravines

Is it possible to remove ravines from world generation without affecting any other structures?

Better yet, can we have a config for that? Or even better, enhanced ravines?


Can't upload files on try.gitea.io

Gitea Version: 1.11.0+dev-87-g3c63c3ace
When attempting to upload csv, txt, xls, pdf or gz files to a comment I get the error "You can not upload files of this type".
The only ones I've got it to work with so far are png, jpg and zip.

This is a configuration problem.

It's one program, isn't it ?

@warnat I do have local instances, but it's nice to be able to provide a publicly accessible example when reporting bugs.


ResourceQuota enforcement Questions

Hi @liyinan926 @khogeland
It is  really great to see that we now have ResourceQuota enforcement support.  A couple of quick questions:

I understand we currently only enforce quotas on requests and not limits.  At Lyft, we currently use limits quotas for cpu/memory as well and I was wondering we there is a plan to add quotas enforcement for limits as well or be able to configure this somehow.
Also it looks like we  don't look at spark-conf currently . Since users can set driver/executor resources via spark-conf directly, I believe its worth to fallback to the conf if they aren't set in PodSpec .
Also this is minor but any particular reason we use  cpu or memory resourceNames (https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/pkg/webhook/resourceusage/enforcer.go#L59) to enforce request quotas  and not request.cpu or request.memory  as per https://kubernetes.io/docs/concepts/policy/resource-quotas/#compute-resource-quota .

Let me know what you guys think about these and if these minor changes make sense.

This didn't seem necessary, as Kubernetes does not use limits for scheduling. The point of limits is to allow Pods to push over their allocated resources while there is no resource contention, so contraining limits may limit (heh) their usefulness. Is there a case I'm missing where this is required?
I think the enforcer should assume the user is doing the correct thing (i.e. going through the SparkApplication API). If they bypass the RQ enforcer by using Spark conf, they'll still be subject to the RQ at pod creation time.
Good catch, I think we're using deprecated resource names, let me try to find a relevant PR/discussion. Looks like we should be using requests.* in case the old names get removed.

This didn't seem necessary, as Kubernetes does not use limits for scheduling. [edit: I think this is an objective improvement in terms of feature support and I'll look into it :)]

Thanks @khogeland  for the reply. I do believe there there is a use to having resource-quotas on limits in some scenarios. There can be a case when the existing pods (for one namespace) on a kubelet which are now using resources more than what they requested for and the kubelet will now reject a new pod because it can no longer support the requested resources for the new pod. This can cause one user/namespace to take over larger set of resources than what was expected despite having resource-quotas enforced.

I think the enforcer should assume the user is doing the correct thing (i.e. going through the SparkApplication API). The rest of the operator works the same way, there's nothing preventing a user from shooting themselves in the foot by setting conflicting Spark configuration. If they bypass the RQ webhook, they'll still be subject to the RQ at pod creation time.

I think it's fine to say that the resources specified in the CRD spec will have a precedence over the spark_conf in-case of conflict etc. but I believe the operator still supports (?) specifying resources only via spark_conf and in that case, we should also provide that support in the RQ webhook in my opinion.
I don't think these are  major changes to the webhook but in my opinion would be good additions to help help us cover all the cases.


Feat ws

What does this PR do? Why shall we accept it?
This PR implements ws gateway module, which will support sharding without a lot of code changes
Status

[x] This is under development
[ ] Changes are well-tested
[ ] Changes doesn't include code changes

[ ] CI changes
[ ] Documentation changes
[ ] Repository organization changes

Core interfaces for GatewayModule and related stuff have been written. Default implementation should be done soon


Open next note in the note set after reviewing a note reverts to TRUE after restarting Obsidian

The setting Open next note in the note set after reviewing a note reverts to (the default?) TRUE after restarting Obsidian even though I set it to FALSE. Expected behavior: The user's setting is retained when restarting the app.
This happens in Obsidian 1.0.3 (but likely already in earlier version, but can't say fore sure).

should be fixed in 0.5.7.
(.net made me lazy - these kinds of errors just will not compile there :P )

Thanks! Can confirm that the setting is now preserved after restarting the app.


Publish latest version to a public maven repo

Please publish the latest version to a public maven repo, (on  jcenter I currently see v0.3)
This way we could avoid enging up with a jenkins job that builds it locally before launching gatling or putting in place a private maven repo just to publish it

:+1:
I would like to see this published too please.

:+1:

I hope don't cause problems but I forked this repo and I uploaded to bintray, if you're interested in use it, in your build.gradle file add the following lines:
buildscript {
dependencies {
classpath 'uk.gov:gradle-gatling-plugin:1.2.1'
}
repositories {
maven {
url "http://dl.bintray.com/enriquezrene/gradle-plugins"
}
}
}
On the other hand, I have opened a request in order to add it to jcenter, I have some news I will let you know

@davbo any idea if you lot are maintaining this?


lib: comply to coding guidelines MISRA C:2012 Rule 14.4

Fix coding guideline MISRA C:2012 Rule 14.4 in lib:

The controlling expression of an if statement
and the controlling expression of an iteration-statement shall have
essentially Boolean type.

This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
5d02614e34a86b549c7707d3d9f0984bc3a5f22a

The compliance check failure is caused by editing a macro which includes a 'return' statement, so it can probably be ignored.

The compliance check failure is caused by editing a macro which includes a 'return' statement, so it can probably be ignored.

Yes I looked also into this. Only the while ( 0 ) was changed to while ( true ) in this macro and nothing other was changed, it seems that this was ignored before or was implemented before the check was in the CI

@andyross can you please take a look? I feel like that the failing CI can be ignored. As Keith mentioned the compliance check failure is caused by editing a macro which includes a 'return' statement. I assume the check was introduced after the macro was implemented or was ignored before.


Credit Card Input: Cursor is set to end of input while editing something in the middle

Suppose you have the following input,
2423 2342 3234 2432
Now, if you try to delete 4, it will put the cursor to the end of the input. The same thing occurs when you try to add a number in the middle. One of the reasons credit card input is mimicked to show the spaces on physical card is to enable users to identify errors easily. But if users are not able to edit the number easily, then the feature is not that useful.

Yea, the cursor problem has been discussed a lot, but after all the evaluation and tests, we considered it as a feature missing by design from the beginning and decided not to apply any fix for it.
We also see this as a major flaw with cleave, will try to solve it when rewriting the lib.
Thanks

I had same issue on React with any type of text inputs, it related to React itself and it behavior


raft: fix malformed example name

It is reported by latest govet:
gopath/src/github.com/coreos/etcd/raft/example_test.go:26: Example_Node
has malformed example suffix: Node

LGTM


Fix unordered dict bug in to_dict()

Issues:
Fixes #687
Problem:
On python3 (and also I presume on python2) the test_two_refs test in
test_mixins.py will fail because the returned value is
{"x": [TraversalRecord, "z"], "z": [1, "a"]}

instead of the expected value
{"x": [1, "a"], "z": ["TraversalRecord", "x"]}

Analysis:
I tracked this down to the _traverse_dict() method where it iterates
over the values of the instance_dict variable. The problem is that
because dictionaries are unordered, the first value that is iterated
upon will sometimes return "z" first instead of "x".
This causes the result to become "turned around" and the test to fail.
I never saw this crop up on python 2, but it crops up regularly on
python 3. The fix I applied is to cast the unordered dict in _traverse_dict
into an OrderedDict. Doing this makes the values of that variable always
known, so-to-speak, because they have a defined order. Therefore the
tests will pass as expected.
Tests:

f5/bigip/test/test_mixins.py::test_to_refs

@zancas and @pjbreaux this requires some architectural discussion as it adds a new pip dependency in python 2.6.

Nice job @caphrim007 !!   Thanks.  I'm +1 to merge this...     I'm OK with a new pip dependency for <= 2.6.


Advice for users/offices with poor internet connection quality

[Enter feedback here]
We've had conversations with customers/users that do not have high-quality internet connections available to them. Are there best practices that can be applied in areas where something like Express Route is not available?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 524e47b0-1295-7d07-0cbc-86e6daaa1358
Version Independent ID: 1cb3a5d8-4f16-583c-ad85-325f7638a873
Content: Connect to Windows Virtual Desktop Windows 10 or 7 - Azure
Content Source: articles/virtual-desktop/connect-windows-7-10.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@DougPetrole ExpressRoute is a way for connecting your on-premise environment directly with Azure, similar to a Site-to-Site VPN. It does provide dedicated bandwidth and on-premise users could have a better connection than over the public internet, but remote workers could have a worse connection.
Users should be able to connect via the public internet (if your Virtual Desktop is public facing) without issue, depending upon their connection. As WVD is still using TCP / RDP protocol, they will still be reliant on the limits of those technologies.


Hitting ESC should close prompts and confirms

At least thats the behaviour I would expect. Just saying.

Not mentioned above but escapeButtonCloses: false can disable the default ESC key functionality per instance.


Improve Telemetry Command Build Process

Follow up from #76029 about ways to improve the build process for how we ship JSON with the telemetry command.

[ ] Git clone off a specific commit
[ ] Move telemetry*.json out of the src directory and into the root.

@lramos15 I'd feel much better if we either do this this iteration or revert the PR altogether.

I'll see if I can get it fixed in time. The feature itself seems to be working, just the build needs improvements which almost feels iteration independent. I'll see what I can do 👍


Option to load from json to let user persist data between runs

Adding data persistence from Json file.
Loads json file and copy data into counts just like firestone.load().
Added load_from_json argument in track() and start_tracking().
start_tracking() will load firebase AND/OR Json data. You can load, one, both or none.
Black the code to respect PEP 8 coding style.

This looks great, sorry for the late reply! Made a few minor changes:

Continue even if file doesn't exist, so that you can always use both commands without having to manually create the file first
Adapt logging a bit
Add to README

Merging!

Nice!
Now I can update my requirements.txt to point on your newest version!
Thanks a lot!