[liblzma] build failure

Host Environment
Windows 10 1803
VS 2017 community 15.9.4
Vcpkg package management program version 2019.07.18-nohash
To Reproduce
Create win32-static.cmake triplet file with the following content:
set(VCPKG_TARGET_ARCHITECTURE x86)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_BUILD_TYPE debug)

Then run ./vcpkg install liblzma:win32-static
Failure logs
-- Performing post-build validation
The folder /include is empty or not present. This indicates the library was not correctly installed.
Found 1 error(s). Please correct the portfile:
    C:\Z\vcpkg\ports\liblzma\portfile.cmake
-- Performing post-build validation done
Error: Building package liblzma:win32-static failed with: POST_BUILD_CHECKS_FAILED

Hi @const-me
Unfortunately while vcpkg almost work with release-only triplets, I have to say that debug-only triplets will give you many headaches.
In fact, there’s no clean solution in any port that installs both debug/include and include folders by default to not delete debug/include if the other one is not available... I think that we could ping @ras0219-msft to see if he has any clear path in mind for this situation

@cenit Thanks for the comment. That’s what I’ve figured out experimenting with these things. I knew vcpkg exists, but until couple days ago when I needed openvdb I had not any experience using it.
It’s not a huge deal, actually.
The unused release config doubles build time from 10 to 20 minutes, adds 500MB of build results, but I hope I won’t do it too often. Once I’ll build these packages with the settings that I need, I’m only planning to update them once in ~6 months or so. I’m almost there BTW, it already works fine, but ideally need a reply to #7442 for better debug symbols included.

Close this issue via #7481 merged.


Create a new pull request by comparing changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 97.434%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
1883

Relevant Lines:
1883

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.06%) to 97.434%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
1883

Relevant Lines:
1883

💛  - Coveralls


Entire document is fetched even when no hooks are registered

Short explanation: The line here https://github.com/matb33/meteor-collection-hooks/blob/master/update.js#L27 checks whether aspects.before or aspects.after exist. This check is incorrect though, because aspects.before and .after are arrays, which are always 'truey'.
What this means in practice is that every time any update occurs on any document in any collection (even without any hooks being registered), that entire document is fetched and then thrown away again by the collection-hooks package.
This came up in our Kadira performance monitoring, because some of our documents are over 1MB in size, meaning updates to that collection took up to 1s in production for just an indexed query + simple increment operation. We narrowed the issue down to this package, which we have subsequently removed (we didn't need its functionality). But I thought I'd post an issue here in case others are wondering, and to kindly suggest a fix for package users (I'd check the array lengths).
After removing the package our updates take <1 ms as they should.

Thanks for posting the issue here.
If you like you can write a pull request.
If not ill take a look as soon as i can.

I'm going to leave this one to you. Have a good weekend!

This should be solved in the next version.


Text Component fails to update in real-time and ellipsis/copy icon alignment issues

Describe the bug

The text component no longer auto-updates in real-time when certain properties are selected in designer mode. You have to preview  or  render first to verify if changes have been applied.
Additionally, when using the ellipsis property, if the content exceeds the container, the ellipsis should appear. Currently, the ellipsis is not visible, and the text is simply cut off. When the copy property is enabled, the copy icon does not align with the text.
Its also worth noting that every time you do the process above you loose your place on the property panel and then you need to scroll down again a few times to get back to where you were.

Steps to reproduce the first issue:

Go to 'https://functional-adminportal-test.azurewebsites.net/shesha/forms-designer?id=1d45e4ef-2097-43a1-a6d7-910abf161e93'
Drag and drop the Text component.
Navigate to 'Content' on the properties panel and type in any text.
Observe the error: Notice that if you check the following properties, you won't see real-time updates unless you first preview or render:

Code Style
Italic
Keyboard style
Delete
Strong
Underline

Expected behavior
The text component should update in real-time when selecting properties, even in designer mode
Second Issue
To Reproduce

Drag and drop the Text component.
Enter content long enough to trigger the ellipsis.
Set the Ellipsis property to true.
Save and render.
Observe the error: The ellipsis is not visible, and the text gets cut off.
Also set the copy property to true
Save and render
observe the error: The copy icon does not align with the text

Expected behavior
The copy icon should align with the text.

Related Item: #2230

@AlexanderSlavchovUX The card has been merged with #2318.

Part of release 40


[Question] Does Spotify Backup also backup liked songs?

Unfortunately no, but there is a work around. You can drag and drop your liked songs in a new playlist then backup spotify with the extension. After restoring you can drag and drop those songs in that playlist to liked songs.


updated changelog

Updated the version in package.json & Updated changelog to reflect the latest feature changes

Hello @jhoudan . Please review the changes made to changelog and package.json


use parallel-hashmap

This makes noop build time around 12% faster in chromium.
TODO: get benchmark resulsts from hyperfine

Interesting, can you make this a build configuration option instead?
Since this is a header-only library, just passing the path to its include directory should be sufficient. Either as a CMAKE custom variable (e.g. NINJA_PHASHMAP_INCLUDE_DIR) or a configure.py option such as --phashmap-include-dir. Both of which could set a macro used in src/hash_map.h to select the implementation.

How does this compare against std::flat_map?
I would like to avoid adding a Git submodule since it breaks tarball downloads and is annoying in general. I think a FetchContent download would be better.
I also wouldn't like a build configuration option, because it creates another code variant to test.

Point taken. I would still welcome a configuration option that allows us to pass the path of the phashmap include directory, and thus avoid a network download, as this will greatly simplify our CI builder configurations (just like with do for GoogleTest currently :-)). How do you plan to implement FetchContent in configure.py though?
Regarding std::flat_map, this is implemented as a linear vector of (key,value) pairs, and has O(N) insertion costs. Its typically good when the number of items is small (e.g. < 1000) or when all insertions are performed initially (e.g. pass an unordered vector to the constructor, which just performs an in-place sort).
For Ninja, we have build plans with 900,000+ nodes in them, and the map are mutated in several places that can be distant in time (e.g. when dynamic dependencies are injected in it), so I don't think this type is a good fit here. Plus we don't need the ordering guarantee and the associated cost.

Hmm, for source code tarball we may do something like this with another tarball containing submodule too.
We can still use FetchContent and have similar functionality in configure.py, but showing caution in release page might be simpler?

I suggest keeping things simple here:

If Git submodules are not appropriate, just copy the phashmap sources from a known revision under src/phashmap/ or third_party/phashmap (your choice) with the appropriate LICENSE file, and a README.md indicating the upstream URL and gut commit used to populate it. This is after all equivalent to a git checkout with one submodule (that doesn't have its own dependencies).

If you don't want to do that, add an option to pass the include dir of the library at configure time for both CMake and configure.py, because I guarantee you that FetchContent / whatever download-at-configure-time solution is going to break some workflows somewhere if you don't provide an escape hatch for it.


TensorRT for Jetson TX2-NX

Hi sir, Is the tensorrt demos work on Jetson TX2-NX module?

I don't have a Jetson TX2-NX for testing.  I think it would just work.


Seti File icons now showing

The icons for this filename (without extensions) are not working

TODO
LICENCE
Procfile

@winuxue When you say "without extensions" do you mean "without any vscode extensions" or "the files do not have extensions like .md, .txt" ?

I mean files with name but no extension.
I'm getting the same than you, the same icon than .txt file.
But it is supposed to show the custom icon for this kind of files, no the txt one.

Can you share a screenshot of the custom icon that you expect?

The ones of this picture:
https://github.com/jesseweed/seti-ui/raw/master/screenshot-icons.png

They seem to work for me:

Not for me.
Testing from Ubuntu.

Can you try the insiders build? (https://code.visualstudio.com/insiders)?


Add initial definition for the Switch Cluster and activate it for some configurations

Problem
This PR add the initial definition for the Switch Cluster, ignoring the events parts until it is supported by IM but instead rely on reporting in the meantime.
Summary of Changes

Add Initial definition into src/app/zap-templates/switch-cluster.xml
Activate it into a bunch of .zap files
Update gen/ folder

@saurabhst @mspang @andy31415 ?

@Damian-Nordic @jepenven-silabs

@hawk248 ?


Fix bug with disable presentation proof check

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (03fc2b8) 87.72% compared to head (a7b3ff6) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   87.72%   87.72%
=======================================
  Files          53       53
  Lines        7991     7992    +1
=======================================
+ Hits         7010     7011    +1
  Misses        714      714
  Partials      267      267

Files
Coverage Δ

verifiable/presentation_jws.go
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


#178: Resigning assemblies with an snk

@Master: This uses a .snk instead of a .pfx file.

Will this produce the same public key as the old versions?

Good point. No, this would change the public key.

So if someone knew the password for the pfx, then you could use sn -p strongname.pfx System.IO.Abstractions.snk to extract the snk file, and I think that would probably result in keeping the same public key.
@tathamoddie ?

I have the password for the PFX.
It used to be installed on the old TeamCity box, so the build process would pick it up.
When we moved to AppVeyor, I didn't have a solution for it.
I can easily unlock the pfx, or publish the password, but that feels wrong. I don't know why.
I'm not terribly familiar with AppVeyor yet, but I do know that they have a way of storing encrypted values. Can somebody help with a PR / pointers on how to securely use the current PFX?

Yes, you can define encrypted things with AppVeyor. Maybe it would need to be set as an environment variable that the csproj could pick up - but you'd want to do that in a way that didn't end up including the password in the build logs!

So looking at http://codecoding.com/using-appveyor-to-build-a-vsto-project/, the way they do it is:

add an encrypted environment variable
in a pre-build script, grab this value and use it to install the pfx in the user store

eg.
	$psw = ConvertTo-SecureString $env:certificatePass -AsPlainText -Force
	Import-PfxCertificate -FilePath .\{Path-to-your-pfx-in-your-github-project}\Certificate.pfx -CertStoreLocation cert:\CurrentUser\My -Password $psw

This PR is quite old and I have not been able to get in touch with the original author. Going to close to explore different avenues with AppVeyor


Witness examples

It would be super-nice to have some encoded witness examples together with some note on the expected validity and output tree structure.
These can be really simple as a starter - so both on the number of examples and scope of the tries - but this would already help a lot to have some reference to check against.

I think @poemm is currently working on it

@holgerd77 ,
Some witness test cases are here: https://github.com/poemm/eth_witness_experiments/tree/master/tests/filled .
For an early look at witness testing infrastructure, see the parent directory. All tests pass, but there are no merkleization tests yet. I will create an issue asking for feedback on this testing infrastructure soon.

Hi, we have implemented witness-from-trie and trie-from-witness here. It is part of Nimbus project and written in Nim.
The block-witness builder already capable of generate multiproof block witness.
We also have quite extensive tests such as:

json fixtures generated by json-witness builder.
parsing invalid input generated by libFuzzer.
roundtrip test using data from a random generator.
roundtrip test using json fixtures from ethereum/tests.

And the tree builder/witness parser really build the merkle trie so we can verify the correctness of the algorithm using simple root hash comparison generated by trie algorithm vs tree builder.
Both of the witness builder and tree builder using simple recursive algorithm. But we also have plan to implement it using software stack.

@poemm @jangko thanks guys for the references, that all already looks pretty substantial, very cool! 😄
Will circle in @s1na and @ryanio here just to take note.


[Windows] Getting a non-root user error

I'm getting the following error when I'm trying to run pvsadm in Windows Server 2016 with Administrator user:
E1224 18:23:12.767867    6536 root.go:68] check failed: non-root user is executing the qcow2ova sub-command
Hint: Expected root user to execute the qcow2ova subcommand
And the command I'm running is:
pvsadm image qcow2ova rhcos46 --image-url https://mirror.openshift.com/pub/openshift-v4/ppc64le/dependencies/rhcos/4.6/4.6.8/rhcos-4.6.8-ppc64le-openstack.ppc64le.qcow2.gz --image-dist coreos --image-name rhcos468

I'm running CMD as administrator

qcow2ova subcommand is supported only on linux/ppc64le - RHEL or CentOS vm. Will enhance the error message to instruct the user to choose the right platform to run the command.


Just added "onCheckedChild"  and "onCheckedParent" functions

I added this functionality because I needed it myself.
I am making the pull request because I think other users probably also would need this functionality.
So just merge it, please.

@davidCpp16 sorry for the delay. Thank You for the PR. Can you solve the merge conflicts and we are good to go?
Thanks!

@AbhishekDoshi26 I would like to solve the conflicts, but I do not have the access to the @davidCpp16 account anymore. Could you somehow solve it on your own?

@DavidWoli maybe create a new PR?

@AbhishekDoshi26 do you mean from @DavidWoli account?

@AbhishekDoshi26 do you mean from @DavidWoli account?

Yep yep yep yep

Closing because a new PR #7 is opened


Show the primary resources in the status board

Fuel, ammo, steel and bauxite with 24h trends. This complements the resources chart.

Basic stats shown in 2261c956afe3ac876e8971e7568f8a59eabc9c01.
24h trends can be added later.

So far I don't think 24h trends is needed. The journal is intuitive enough and not that heavyweight.


streams settings: Filter streams disappears in narrow windows.

I expect this was an intentional decision at some point, but filter streams is important functionality for people joining organizations with 100s of streams. I think for now we can just move it to the line below, and have a taller header.

This being hidden in narrow windows was an unhappy expedient for merging Brock's redesign of "stream settings", not something we wanted to do.

@rishig @timabbott I think adding magnifying glass like widget will look better.
Can I start working on this and if yes what fix should be implemented of the above two mentioned above?

@zulipbot claim

@zulipbot claim

@timabbott I need some help!
My previous commit just adds the html and css and enough javascript to keep the search functionality working. As I add the javascript for making the search box appear and disappear on clicking the icon, I am not sure as to should I create a module as is created for the user search widget (static/js/user_search.js) or should the code reside in static/js/click_handlers.js? I can write the click handlers, I just don't know where to put them.
Also, adding this second div element breaks the scrollbar (it is scrolled to the end in the screenshot but does not show the last stream). Where should I look to fix that?

@zulipbot claim

This is how I made it look by changing some Sass. Opening a new PR

Hi Nirav!
Most of the work on this issue is already done, and I'm just waiting for some confirmation and a final set of changes to make. You can look at the PR referenced above and consider building on top of it, instead of starting over from scratch.
Cheers

Sorry @jiviteshjain didn't see your PR, ill close mine

@zulipbot abandon

@zulipbot claim


remove requirement for java 8 environment in release script

The release script checks if the java environment is Java 8. This check is not necessary as the maven build itself ensures our code is compatible with Java 8, and none of the binaries produced on the local system make it into the final release deployment.
It also makes doing releases harder now that we've chosen to use Java 11 as our default environment for development.

It was introduced back when the build would fail when producing the javadocs on 9+. May still be a good idea to keep some sort of check, since I’ve especially found that maven plugins have a tendency to break for new java versions.

Maybe we can have a soft check. Like “You are on version 15, which has not been tested...are you sure you want to continue (y/n)?”


Automatic proxy configuration

Set:
adb shell settings put global http_proxy <ip>:<port>
adb shell settings put global global_http_proxy_exclusion_list  <-- Not working?
Unset:
adb shell settings put global http_proxy :0
Get default gateway:
ip route list match 0 table all scope global

Alternate method: use PAC, something like
function FindProxyForURL(url, host) {
	if (dnsDomainIs(host, "ffrk.denagames.com"))
		return "PROXY <IP_ADDRESS>:8082";
}

But instead of using http, embed it as base64: data:application/x-ns-proxy-autoconfig;base64,<base64data>
Set:
adb shell settings put global global_proxy_pac_url <data>

Added in b9762d03c641529d19020170701db6b0c28249be


Transformer gives invalid warnings about missing entry points

This is partly related to this bug https://github.com/dart-lang/pub/issues/1308, and partly the transformers fault. If the user does pub serve or pub build on a specific directory (usually web or test) then the transformer will only be supplied the files from that directory and the files from lib, not all files in the package. Therefore if you have entry points inside of web and test, then you will always get a warning about entry points not existing if you pub serve|build web|test. I don't know if there is a good solution to this, the warning may need to just be removed.

As a first step, I've changed the treatment of this situation a bit: The transformer will emit a logger.info message rather than a logger.warning message, and it is only emitted during transformation (it used to happen also during declareOutputs). This is in any case a better approach.
The reason why a missing entry point was considered to be a serious problem a while ago (justifying the warning) is that a spelling mistake in 'pubspec.yaml' (say, 'web/foot.dart' rather than 'web/foo.dart') causes the target program ('web/foo.dart') to remain untranslated. For the programmer who wants to try out the effect of transforming his/her programs, it looks as if everything is working, but in fact the source side ('web/foo.dart') and the target side ('build/web/foo.dart') are identical. So the speed-up will be moderate. ;)
With that in mind, I'll keep the info message around for now.

I definitely agree with the intent behind the message. However since this may not get fixed in pub, it is probably worth doing something like looking at all top level folders of the assets you are given, and only verifying the entry points that live in those folders. Otherwise you are guaranteed to get this message whenever running pub serve.

How do you know that this particular algorithm will correctly characterize the way in which pub has chosen the set of assets to offer to the transformer (or maybe this decision is made by barback alone)? Are they offered FileAssets always the complete set of files in some subdirectory hierarchy whose root is a direct subdirectory of the package root? (Seems that we would need to understand other elements in pubspec.yaml such as $include and $exclude in order to know whether a given missing file is expected to be offered as an asset by pub, or it should be missing because of the way pub was invoked).
@nex3, @munificent?

Imo if you had a combination of $include/$exclude which resulted in your entry point not being visible, it would be correct to log a message that the entry point was not found. That would be an invalid transformer configuration.

How do you know that this particular algorithm will correctly characterize the way in which pub has chosen the set of assets to offer to the transformer (or maybe this decision is made by barback alone)? Are they offered FileAssets always the complete set of files in some subdirectory hierarchy whose root is a direct subdirectory of the package root?

No, they aren't. Barback doesn't expect transformers to have side effects, so it doesn't provide strong guarantees about what sets of assets are available at what time. All I can guarantee is that an aggregate transformer will run on all matching assets pub knows about at the time that it's run, and that it will eventually be run on all assets the user specifies for the current barback run, either with $include/$exclude or by passing directories on the command line.
Also, there's no guarantee that the user will pass direct subdirectories of the package root to pub build or pub serve. They're allowed to pass arbitrarily nested subdirectories.

(Seems that we would need to understand other elements in pubspec.yaml such as $include and $exclude in order to know whether a given missing file is expected to be offered as an asset by pub, or it should be missing because of the way pub was invoked).

I agree with Jake that if the user passes {entrypoint: web/something.dart, $exclude: web/something.dart} they should expect strange behavior.

Having an explicit entry among the entry_points in pubspec.yaml as well as an $include/$exclude that causes it to be omitted is not so different from the situation on the command line where certain options may conflict. For instance, gcc has things like this
    -fmax-errors=n
           Limits the maximum number of error messages [..] If -Wfatal-errors is also specified,
           then -Wfatal-errors takes precedence over this option.

With a well-defined precedence hierarchy, it can be a reasonable approach to allow for conflict resolution like that (maybe you'd want to have a longish list of entry points to transform, and then temporarily filter that list using include/exclude).
Apart from the fact that a contradictory specification in pubspec.yaml may be OK, it seems non-trivial to detect contradictions. I don't think there is any Turing completeness lurking in the corners here, but we would certainly have to reason about set intersection/difference/union/subsetness in order to detect contradictions, especially if (as planned) the entry_points: list can contain patterns (aka wildcards, globbing).
So, I don't think we should jump to the conclusion that we must emit a warning for every situation where there is a contradiction in pubspec.yaml with respect to the selection of entry points.
With respect to the situation where the user specifies web/something.dart to be an entry point, and at the same time excludes web/something.dart, the interesting variant is actually when we instead exclude *eb*/*.dart and consider pub build test. In this case the transformer does not receive an asset for web/something.dart from barback, but it's because we are running pub build test rather than pub build web, not because of the conflict between the entry points and the exclusion.
One approach that we could use to let the user specify whether it is ok or not ok that there is a missing entry point is to connect the entry points with the pub argument list: "If the invocation of pub was on the form pub {build,serve} <options> test then the following list of entry points should be included", and then we could have different entry point sets for different invocations of pub. It's still a rather verbose action to take, simply in order to avoid some info messages.
But I don't know how the transformer could infer whatever is needed in order to detect that test was the target directory argument given to pub, or even that it was invoked from pub at all. Just finding the nearest common ancestor in the file system for all the given assets (e.g., for '/some/path/a/b/c.dart' and '/some/path/a/b2/c2/d.dart' it is '/some/path/a') seems to be an ugly hack. How do we know that the given set of paths to assets is always structured in such a way that this makes sense (certainly, specifying 'arbitrarily nested subdirectories' is a complication here)? We can do things like pub build test web such that the nearest common ancestor path will be empty (meaning $packageroot), which means that we won't know that tool/my_program.dart is omitted because of the command line arguments to pub, and hence we won't know that no warning should be emitted.
In summary, there is a somewhat ugly hack that eliminates many of the unwanted info messages (but ignores complications like include/exclude): We need a reliable way to extract the set of target directories specified to pub (say, test/whatever) from barback when a transformer is invoked from pub (e.g., using pub serve test/whatever). With that in place, we could omit the info message for entry points whose path does not have such a prefix (here, paths not on the form test/whatever/**).

Given that we don't have a way of getting this information from pub within barback, I think there are only really two viable options today that I see.

Remove the warning/info message. Fwiw this is what polymer, web_components, initialize, and angular all do. Instead they rely on runtime warnings if it is detected that you are running an incorrectly configured program.
Implement the hack, knowing that it will work in the default configurations but not all possible ones. I would be willing to bet this will cover over 90% of use cases, and its ok to have an erroneous info message in the other cases.

The CL https://codereview.chromium.org/1448333004/ includes code that eliminates a large portion of the unwanted 'Missing entry point' messages (namely all the ones where we can verify that the file exists and hence the entry point spec is not just a spelling error). With that, we have not been able to create the 'Missing entry point' message.
As an extra device for controlling this and similar messages, it is now possible to declare in pubspec.yaml that specific kinds of warnings must be suppressed. We could for instance have the following:
transformers:
- reflectable:
    entry_points:
      - web/index.dart
      - web/non_existing_file.dart
    suppressWarnings: missingEntryPoint

No warnings will be emitted to indicate that 'web/non_existing_file.dart' is missing. Another choice is suppressWarnings: true which suppresses all warnings. To see them all, use an unknown value, which makes the transformer print the existing choices.
The CL is expected to be landed today.

Random comment:
    entry_points:
      - web/index.dart
      - web/non_existing_file.dart
    suppressWarnings: missingEntryPoint

I really think reflectable should be more consistent with it's configuration names. "entrypoint" is a single word so doesn't need an underscore. "suppressWarnings" should be "suppress_warnings" to be consistent with other lower_camel_case keys that appear in pubspecs.

Oops, my mistake. "Entry point" is two words. :)

Ah yes, that sounds right.
Actually, I looked around to see typical naming choices, and both 'entry_points:' and 'suppressWarnings:' come from https://www.dartlang.org/tools/pub/assets-and-transformers.html.
But it looks like that usage of camelCase is unusual. https://www.dartlang.org/tools/pub/pubspec.html mentions one particular identifier, the package name: That one should be in lowercase-with-underscores format. The same page uses identifiers (excluding the ones whose spelling is fixed externally, because it is the name of a file) in lowercase-with-underscores style ('dev_dependencies') and others in lowercase-with-dashes style ('polymer-new-element'), but the former is the clear majority. A bit of grepping in the 169 files named 'pubspec.yaml' in the sdk confirms this.
So I'll use lowercase-with-underscores. Thanks for the input!


[usbdev_scoreboard] Predictor (reference model) of usbdev.

This request contains the usbdev_packet_classifier class. In this class we indentify the type of incoming packet and breaking it down in its respective fields

@jdonjdon can you please review.

you have trailing white space failure.
./util/fix_trailing_whitespace.py

@jdonjdon  I have removed all trailing whitespace .


[Bug] [Module Name] Bug in First Useing

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating system information
Linux
Python version information

=3.11

DB-GPT version
latest release
Related scenes

[ ] Chat Data
[ ] Chat Excel
[ ] Chat DB
[ ] Chat Knowledge
[ ] Model Management
[X] Dashboard
[ ] Plugins

Installation Information

[X] Installation From Source

[ ] Docker Installation

[ ] Docker Compose Installation

[ ] Cluster Installation

[ ] AutoDL Image

[ ] Other

Device information
CPU
Models information
LLM：chatgpt_proxyllm
text：proxy_openai/text2vec/mg3large
What happened
No sentence-transformers model ，but there are model in folder.

and If i use proxy_openai, I meet this bug:

What you expected to happen
I dont know
How to reproduce
I dont know
Additional context
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

sorry about that, latest main branch have not bundle newest web static files. you can try enter web directory and start web app
cd web
npm i
update next.config.js set API_BASE_URL
API_BASE_URL: "http://<IP_ADDRESS>:5000",
npm run dev
and we will fix that problem soon.

sorry about that, latest main branch have not bundle newest web static files. you can try enter web directory and start web app cd web npm i update next.config.js set API_BASE_URL API_BASE_URL: "http://<IP_ADDRESS>:5000", npm run dev
and we will fix that problem soon.

But why meet

this problem

sorry about that, latest main branch have not bundle newest web static files. you can try enter web directory and start web app cd web npm i update next.config.js set API_BASE_URL API_BASE_URL: "http://<IP_ADDRESS>:5000", npm run dev
and we will fix that problem soon.

Thanks！ but this problem still happen

it's warning log, means m3e-large model is not sentence transformer, it did not influence dbgpt_server start.

这是警告日志，意味着m3e-large模型不是句子转换器，它不影响dbgpt_server启动。

谢谢！

这样设置是对的吗？


Permissions Issue

Make sure you follow all of the setup directions before posting an issue: https://github.com/jamesmontemagno/MediaPlugin#important-permission-information
After following all the set-up directions and implementing the following code block to check camera permissions, I am still getting the DisplayAlert that permissions are denied for the camera.
// verifies that the user has permission to access the camera             var cameraStatus = await CrossPermissions.Current.CheckPermissionStatusAsync(Permission.Camera);             if (cameraStatus != PermissionStatus.Granted)             {                 var results = await CrossPermissions.Current.RequestPermissionsAsync(new[] { Permission.Camera });                 cameraStatus = results[Permission.Camera];                 if (cameraStatus != PermissionStatus.Granted)                 {                     await DisplayAlert("Permissions Denied", "Unable to take photos.", "OK");                     CameraButton.IsEnabled = false;                     return;                 }             }
I am developing a cross-platform application in Xamarin, using .NET 2.0 Standard. I have the permissions and media plugins installed, but cannot figure out where I am going wrong. I am testing on an "Android_Accelerated_x86_Oreo (Android 8.1 - API 27)" with the hardware for camera set to true in the ADM.
The repository I am working in is https://github.build.ge.com/212703631/CameraPOC and is a simple application that only needs to open the camera using the button created, take a picture, and display it.
Do you have any ideas of why I am unable to gain permission to the camera and how I could overwrite that?

you don't need the camera permission on android. I have samples in this repo that you can walk through. I don't add the camera permission to the android manifest. Also ensure that you setup the current activity plugin: https://github.com/jamesmontemagno/MediaPlugin#android-current-activity-setup


Update dependencies and workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:loudspeaker: Thoughts on this report? Let us know!.


Clarify that GitHub is not the sole Identity Provider

Since https://github.com/pypi/warehouse/commit/b00ec3eae7, the documentation for Trusted Publishers is slighty out-of-date.
Indeed, several Identity Providers are now supported ( Gitlab, Google Cloud...).
This PR reformulates the documentation to emphasize that the example in the doc is using GitHub only as a placeholder and not because it is the only identity provider.

Thanks @DarkaMaul!
CC @miketheman for a quick doc review, if you have the bandwidth 🙂


Type inference errors

Acton Version
<IP_ADDRESS>303<IP_ADDRESS>
Steps to Reproduce
For each of the following files f.act in the acton test suite, run
actonc f.act --types

and/or
actonc f.act --tempdir .

to save the interface file as out/types/f.ty
and then look at its contents:
actonc doc --signs out/types/f.ty

In each case the compiled file can be run with correct result and exits with exit code 0, but types displayed and saved in the interface files are wrong.

test/builtins_auto/builtin_functions.act

The file contains
def even(n):
    return n % 2 == 0

and the typing in the interface file is
even : [A(Eq, Integral)] => (None) -> bool

The type displayed by --types is
with:
    pure def even[T_4w] (W_43 : __builtin__.Eq[None], W_38 : __builtin__.Integral[None], n : None) -> __builtin__.bool:

Note the witnesses that None implements Eq and Integral.

test/regression_auto/103-dict-of-int

The file contains
def foo():
    a = {"a": 1, "b": 3}
    return a

and the typing in the interface file is
foo : [A(Mapping[str, None]), B(Number)] => () -> None

The typing displayed by --types is
with:
    pure def foo[T_12, T_5] (W_13 : __builtin__.Mapping[None, __builtin__.str, None], W_6 : __builtin__.Number[None]) -> None:

Again we see erroneous witnesses.

test/regression-auto/110-union-none-int.act

The file contains
def foo():
    if 1 == 3:
        return None
    return 3

and the typing in the interface file is
foo : [A(Number)] => () -> ?None

Typing displayed by --types is
with:
  pure def foo[T_11] (W_12 : __builtin__.Number[None]) -> ?None:
        if W_9.__eq__(W_7.__fromatom__(1), W_7.__fromatom__(3)):

Same thing again.
I have a couple of more examples, but I guess they all have the same origin. I stumbled on them while playing with CodeGen.hs to try to improve treatment of literals.
Expected Behavior
Correct types...
Actual Behavior

Fixed by my recent merge to main!


For e2e tests, build containers in Cloud Build

e2e tests will probably run faster if we build the [event-handler,data parsers] containers as Cloud Build steps in the e2e testing pipeline, rather than invoking separate Cloud Build executions from bash.

add parallelized steps to e2e_tests_terraform.cloudbuild.yaml that build the containers
add a flag to install.sh to skip container builds (this will also be useful for testing the terraform install from local)

My only comment here is that I want to ensure that we're testing the flow as close as possible to the real one.

My only comment here is that I want to ensure that we're testing the flow as close as possible to the real one.

That's a very good point. Let's not.


I'm sorry please delete

.

You can close the issue, otherwise I don't think it's possible to delete it

You can close the issue, otherwise I don't think it's possible to delete it


feat(aws): Adds support for Cloudwatch dashboards & metric alarms.

Objective:
Adds support for cloudwatch_dashboard & cloudwatch_metric_alarm.
** Closes ** #54
Example output:
NAME                                              MONTHLY QTY  UNIT     PRICE   HOURLY COST  MONTHLY COST

  aws_cloudwatch_dashboard.main
  └─ Dashboard                                                1  monthly  3.0000       0.0041        3.0000
  Total                                                                                0.0041        3.0000

  aws_cloudwatch_metric_alarm.expression
  └─ Standard resolution                                      1  alarm    0.1000       0.0001        0.1000
  Total                                                                                0.0001        0.1000

  aws_cloudwatch_metric_alarm.high
  └─ High resolution                                          1  alarm    0.3000       0.0004        0.3000
  Total                                                                                0.0004        0.3000

  aws_cloudwatch_metric_alarm.standard
  └─ Standard resolution                                      1  alarm    0.1000       0.0001        0.1000
  Total                                                                                0.0001        0.1000

  aws_cloudwatch_metric_alarm.xx_anomaly_detection
  └─ Standard resolution anomaly detection                    3  alarm    0.1000       0.0004        0.3000
  Total                                                                                0.0004        0.3000

  OVERALL TOTAL (USD)                                                                  0.0052        3.8000

Pricing details:
The Cloudwatch service provides a single pricing component for dashboards & 5 pricing components for alarms. Composite alarms are not currently supported by terraform. Pricing details describe here https://aws.amazon.com/cloudwatch/pricing/

Added cloudwatch_log_group
 aws_cloudwatch_log_group.logs
  ├─ Collect (Data Ingestion)                                 0  GB             0.5000       0.0000        0.0000
  └─ Store (Archival)                                         0  GB             0.0300       0.0000        0.0000
  Total                                                                                0.0000        0.0000

Thanks @aliscott I've updated & the output reads.
 aws_cloudwatch_log_group.logs
  ├─ Data ingestion                                           -  GB             0.5000            -             -
  ├─ Archival Storage                                         -  GB             0.0300            -             -
  └─ Insights queries data scanned                            -  GB             0.0050            -             -
  Total                                                                                -             -


Weakrefs

Made cuda_ptrs use WeakRefs as keys.  Confirmed that this solves the gc() problem, thanks for the suggestion!  Although once in a while there are WeakRef(nothing)=>0 pairs left in cuda_ptrs (this happens intermittently, I can't reliably replicate it).  Other than that it passes the repo tests.  I also fixed a few minor problems that made the code more compatible with v0.4.

Thanks! Looks very nice.


Skip inaccessible files/folders when generating

When we don't have permission to read a file/folder in the project tree skip it instead of failing.

Maybe this should go behind a flag?


fixed typo

Proposed changes:

fixed a typo

Status (please check what you already did):

[ ] added some tests for the functionality
[x] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chris Desmarais seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @akelad will take a look at it as soon as possible ✨

@desmarchris I think you need to set up your github user name/email address properly locally, and make sure your rasa email address is in your github profile. the commit is from an unidentified user atm

going to reopen now that I setup email/username locally


Expose Vertx core metrics in Prometheus format

This PR exposes Vertx core metrics in Prometheus format and add
notes on how to configure Prometheus to scrape data plane pods.
Spec metrics in a separate PR.
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>Part of #227
Proposed Changes

Expose Vertx core metrics in Prometheus format

Prometheus dashboard

Release Note
- 🎁 Add new feature
Data plane pods expose server and client metrics in Prometheus format.

Waiting for the release!
/hold

/cc slinkydeveloper

/lgtm

/unhold


MathJax Rendering issue

Issue Summary

The numeral font is different from the letter font.
There is a scrollbar below.
No block formulas were rendered.

Steps to Reproduce:

Integrate MathJax using a CDN and configure it.
Discover the problem.

I used cnblog to write my blog, utilizing cnblog's JavaScript features.
Technical details:

MathJax Version: 3.2.2
Client OS: Windows 10 19045.4651
Browser: Microsoft Edge 127.0.2651.98

I am using the following MathJax configuration:
MathJax = {
  tex: {
    inlineMath: [['$', '$'], ['\\(', '\\)']]
  }
};

and loading MathJax via
<script id="MathJax-script" async
<EMAIL_ADDRESS></script>

Supporting information:

i've been facing this kind of error in my pc and laptop after I reinstalled windows in both of them..

@amrit3874, your issue seems unrelated to the one in the original post.  You should open a new issue for that, with complete details.  There is not enough information here to diagnose your issue.

@songxingling1, I suspect that you are using the Unicode Full-Width characters for the numbers (the ones at U+FF10 to U+FF19) rather than the ASCII numerals.  That MathJax fonts don't include these characters, so you are seeing the ones taken from a font installed on your system, and they don't match the MathJax fonts very well.  Also, the characters are wider than usual (they are the "full width" characters after all).  Can you enter ASCII rather than full-width numbers?
If not, we could perhaps create a TeX input jax pre-filter that will convert the full-width versions to the ASCII equivalents.

Well, actually this issue is caused by CSS style sheets and Markdown escaping, and there is no problem with the Mathjax library.

I tried with other browsers and it only seems to be working with mozilla
firefox for some reason.. so I'm using that nowadays..pls let me know if u
find any solutions for my problem..
On Sun, 18 Aug, 2024, 10:20 am songxingling1, @.***>
wrote:

Well, actually this issue is caused by CSS style sheets and Markdown
escaping, and there is no problem with the Mathjax library.
—
Reply to this email directly, view it on GitHub
https://github.com/mathjax/MathJax/issues/3271#issuecomment-2295112863,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASLRC3AQZBX6CPWTTEHWYQLZSARZRAVCNFSM6AAAAABMLZGRSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGEYTEOBWGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Redirect of CID-in-subdomain and DNSLink websites

Parent issues: https://github.com/ipfs/ipfs/issues/337, https://github.com/ipfs/in-web-browsers/issues/89, https://github.com/ipfs-shipyard/ipfs-companion/issues/527

Problem
There is an open problem of handling CID in Subdomain. CID-in-subdomain gives a website Origin-based isolation if loaded from public gateway, but we continue to have a single Origin for all websites if it is redirected and  loaded from local gateway (/ipfs/<cid>).
Current status:

IPFS Companion extension DOES NOT redirect from cidv1b32.ipfs.foo.tld  to http://<IP_ADDRESS>:8080/ipfs/cidv1b32 because that would decrease security guarantees (example)

However, we DO redirect DNSLinked websites eg. https://docs.ipfs.io to http://<IP_ADDRESS>:8080/ipns/docs.ipfs.io/ because at the time nobody relied on Origin-based guarantees on IPFS websites.

I feel we should come up with a solution that is addressing both use cases, as having different behavior is confusing.
Short Term Fix
In the short term we have two options: either redirect or not.
( A ) :anger:  Redirect to http://<IP_ADDRESS>:8080/ip(f|n)s/.. even IF it would decrease Origin-based guarantees

This assumes that website owner set it up knowing about the lack of Origin-based isolation at the local gateway (detecting Origin change and disabling sensitive features). I am not convinced this is a realistic assumption, and would like to go away from it for DNSLink websites.
Potential mitigation would be to add redirect opt-out via additional DNS TXT record, but it overcomplicates DNSLink even further

( B ) :angel:    (@lidel's plan)  DO NOT redirect to http://<IP_ADDRESS>:8080/ip(f|n)s/.. by default, but give opt-in option to open at local gateway

display IPFS page actions and add an entry there to either:

Open from Local Gateway – displays a warning dialog informing about Origin limitation of  local gateway and if user accepts the risk opens the website from http://<IP_ADDRESS>:8080/ip(f|n)s/..     (easy to reason about, so far my favourite, UX can be improved by supporting  (F) in Firefox :green_apple: )
( B.1 ) For now, we can add option to Enable redirect to Local Gateway - a permanent opt-in to redirect  this specific website (may be hard to get the UX right, we may add this as a part of https://github.com/ipfs-shipyard/ipfs-companion/issues/633)
( B.2 ) In the future, when local gatewy supports *.ipfs.localhost and *.ipns.localhost we could restore the redirect by default (because it no longer breaks the origin) – see details in https://github.com/ipfs-shipyard/ipfs-companion/issues/667#issuecomment-475819455

I lean on the safe side (B). Below are other options.
Other Ideas
( C ) :anger:   "A mess": redirect to a custom hostname for localhost HTTP gateway

dependency on DNS: *.ipfs.foo.tld → <IP_ADDRESS> (https://github.com/ipfs/in-web-browsers/issues/109)
as this is not a raw IP, HTTP gateways does not fall under mixed-content whitelist nor is a Secure Context

localhost certs are problematic, but without HTTPS going with HTTP means..

..mixed-content errors (https://github.com/ipfs-shipyard/ipfs-companion/issues/645)
..websites can't run js-ipfs or use window.ipfs due to missing Web Crypto API

( D ) :angel:  "Ideal": redirect to native protocol handler

in the future we may have something like libdweb+experiment: protocol handler API, but even then, it won't be available in all browsers

( H ) :thinking:  Service Worker pulls data from <IP_ADDRESS> and serves it from the <CID>.ipfs.local.dweb.link Origin. It would be origin-white-washing everything on the fly. Should work the same as js.ipfs.io does today except the worker talks to loopback only.

Actively researched in https://github.com/ipfs/in-web-browsers/issues/137
Would have to be HTTP-pull, as WebSocket connections through a loopback HTTP address in Firefox are blocked due to bug-1376309
Unknown performance characteristics
Breaks websites that themselves require Service Worker
Companion should be able to remove the need for adding CORS to local node

( F ) (Firefox only) Open from Local Gateway in (B) could open in a new tab with  isolation provided by browser.contextualIdentities API (see #194)
( G ) Like (B) but we could allow redirects for some content types like  images or videos.  Rationale: subresources are easy to detect via ResourceType – we can detect image and video that way.  (Other ways to tell the content-type: look at extension [naive] or fetch a few bytes and do mime-sniff on them [expensive])

??? (ideas are welcome)

( J ) RFC 7838 may offer an alternative solution for DNS-to-IPFS that is currently handled by DNSLink.

anything.localhost is not treated as a secure origin.

anything.localhost is not treated as a secure origin.

Initial version at https://w3c.github.io/webappsec-secure-contexts/#is-origin-trustworthy read:

If origin’s host component is "localhost" or falls within ".localhost", and the user agent conforms to the name resolution rules in let-localhost-be-localhost, return "Potentially Trustworthy".

Which meant it would be treated the same as <IP_ADDRESS>.
Just as @da2x  noted, browser vendors follow more conservative approach from https://www.w3.org/TR/secure-contexts/#is-origin-trustworthy:

If origin’s host component matches one of the CIDR notations <IP_ADDRESS>/8 or ::1/128 [RFC4632], return "Potentially Trustworthy".

https://www.w3.org/TR/secure-contexts/#localhost:

Section 6.3 of [RFC6761] lays out the resolution of localhost. and names falling within .localhost. as special, and suggests that local resolvers SHOULD/MAY treat them specially. For better or worse, resolvers often ignore these suggestions, and will send localhost to the network for resolution in a number of circumstances.
Given that uncertainty, this document errs on the conservative side by special-casing <IP_ADDRESS>, but not localhost.

Safari does not even allow <IP_ADDRESS>: https://bugs.webkit.org/show_bug.cgi?id=171934

Some takeaways:

We could work with browser vendors on changing that, let-localhost-be-localhost at least for *.ip(f|n)s.localhost which come with content-addressing guarantees

In parallel, we could look into registering Special-Use *.dweb, similar to *.onion which created a good precedent for being marked as a secure context in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1382359

Something I'd like to avoid is playing with self-signed cartificates and injecting CA Root to users truststore.

Even without secure context, HTTP Proxy would be valuable for a lot of use cases, and there will be a way to disable redirect per website (#687)

I'm not sure what the coverage is in other OSes, but *.localhost subdomains don't work out of the box on all Linuxes. The dnsmasq local resolver and systemd-resolved do resolve them though, so that might be good enough.

@lgierth correct, we identified cross-platform issues in https://github.com/ipfs/in-web-browsers/issues/109 and decided to try something else.
The *.ipfs.localhost mentioned here should work cross-platform because it relies on domain support via go-ipfs as HTTP proxy (https://github.com/ipfs/go-ipfs/issues/5982)

*.localhost behaves according to the RFC for it’s special use domain. (Meaning it doesn’t do squat by default.) However, this isn’t a problem as the extension or a browser proxy configuration can be setup to handle *.,localhost which I assumed was the idea to begin with.

@lidel any progress on using ipns://example.com or ipfs://b32cidv1 directly in browsers? The Beaker Browser’s use of dat://hash have saved them a lot of trouble in this area.

@da2x we created a prototype using experimental WebExtension API libdweb/#protocol-api to deliver persistent ipfs://b32cidv1 in https://github.com/ipfs-shipyard/ipfs-companion/pull/533, and signaled similar need to Chrome team, but it is hard to tell when such API lands in mainstream browsers (right now it requires special setup and Firefox Nightly).
The HTTP Proxy workaround discussed here aims to improve things much sooner, as we can deliver it without making any changes to browsers.

Ok, I believe with latest Beta (v<IP_ADDRESS>2) we have almost all the pieces of the UX for ( B ):

It enables people to opt-out from redirects per hostname. (#687)
It shows IPFS actions on DNSLink websites even when redirect is disabled (#694)

What is missing: in case of DNSLink websites, we want to tweak this behaviour and disable redirect of DNSLink websites by default. People will still be able to opt-in via toggle introduced in (#687) and a global one in Preferences if they choose to do so, but the default should not change the Origin.
Tracked in: https://github.com/ipfs-shipyard/ipfs-companion/issues/701

I'm not arguing against the decision and preserving the origin boundaries is super important. However, this change also kills IPFS' browser intgration for any purpose other than direct file swapping. Without DNSLink there is no way to publish a website and simultaniously let IPFS Companion users automatically access it on IPFS without manual intervention and a willingness of users to sacrifice security.
Is there a detailed roadmap or plan for future browser integration? or a plan to produce a prototype browser like the Beaker Browser?

@da2x the plan for mainstream browsers is to disable redirect of DNSLink websites until support for localhost HTTP Proxy and <fqdn>.ipns.localhost  lands in go-ipfs (https://github.com/ipfs/go-ipfs/issues/5982). That is the best we can do for now.
Now that you mentioned it, I see how users may see this as a regression and start asking myself: is the cure is worse than the disease? Namely:

Does it makes sense to disable DNSLink redirect now, after it being the status quo for so long?
Perhaps we should just leave it as-is until we can switch local redirect to <fqdn>.ipns.localhost?

Is there a detailed roadmap or plan for future browser integration?  or a plan to produce a prototype browser like the Beaker Browser?

Ongoing: We are working with Brave (see notes on bringing IPFS to Brave), which is based on Chromium. Got some initial success there around embedded js-ipfs with self-hosted HTTP Gateway via chrome.sockets APIs (WIP). URLs ipfs:// and ipns:// are planned to be working "natively" there as well, but I can't share any dates yet.

Long term: ipfs/roadmap is WIP. IPFS Web Browsers WG is growing, and we are having short summit next week to revisit and discuss the WG roadmap for 2019 and beyond.

Now that you mentioned it, I see how users may see this as a regression and start asking myself: is the cure is worse than the disease? Namely:

Does it makes sense to disable DNSLink redirect now, after it being the status quo for so long?
Perhaps we should just leave it as-is until we can switch local redirect to .ipns.localhost?

I’ve used static.example.com and video.example.com to serve media assets on www.example.com over IPFS or fallback to HTTP for users without IPFS Companion. DNSLink with automated redirection to localhost in a secure context is the glue that holds that together.
How would you load this over IPFS?
<video><source src="https://video.example.com/video6.webm" type="video/webm"></video>
How about an opt-in signal by extending the existing DNS prefetch mechanism?
<link rel="dns-prefetch" href="//video.example.com" data-ipns-enabled>
IPFS Companion could resolve that domain as an DNSLink IPNS name and load it via the local gateway. Browsers will just resolve the normal DNS name for this origin and ignore the extra attribute. It significantly reduces unnecessary DNSLink lookup requests too.

URLs ipfs:// and ipns:// are planned to be working "natively" there as well, but I can't share any dates yet.

I though IPNS:// couldn’t work? The origin has to be lower-case, right? —and I’ve not even seen a proposal to transition to lowercased base32 encode IPNS names.

@lidel what about proposal J above? It’s what the Tor browser uses to upgrade a .com to a .onion (cutting the need to route traffic through an exit node after the first visit to the web server. It’s a mechanism where the origin is preserved (https://example.com/) while the browser has switched to an alternate service (another HTTPS server, such as an IPFS gateway).

I’ve used static.example.com and video.example.com to serve media assets on www.example.com over IPFS or fallback to HTTP for users without IPFS Companion. DNSLink with automated redirection to localhost in a secure context is the glue that holds that together.

This should continue to work. I clarified in https://github.com/ipfs-shipyard/ipfs-companion/issues/701 that the idea is to disable redirect of the root document (main_frame – a URL in the location bar) to keep Origin.
Assets loaded as subresources would continue to be redirected to IPFS.

I though IPNS:// couldn’t work? The origin has to be lower-case, right? —and I’ve not even seen a proposal to transition to lowercased base32 encode IPNS names.

Origin need to be case-insensitive. We had some discussions this week  to take https://github.com/ipfs/go-ipfs/issues/5287 over the finish line by wrapping PeerID in CID with a special codec. That way it could be represented in Base32 too.

what about proposal J above? It’s what the Tor browser uses to upgrade a .com to a .onion [..]

Alt-Srv provides seamless upgrade, but right now requires native support from browser vendor. I've created https://github.com/ipfs/in-web-browsers/issues/144 to track it.
WebExtension is unable to register handler for Alt-Srv, but we may look at adding support for the header in Brave.

As of 2019-10 localhost (hostname) is a secure context in both Firefox 69  and Chrome 78.
Firefox does not support *.localhost yet, but everything suggests it will at some point  – more details in https://github.com/ipfs/in-web-browsers/issues/109#issuecomment-537061478

We decided (https://github.com/ipfs-shipyard/ipfs-companion/issues/701#issuecomment-562304730) to implement temporary measures   until we have native support for subdomain gateway in go-ipfs (https://github.com/ipfs/go-ipfs/issues/6498) that works with *.ipfs.localhost and *.ipns.localhost
v<IP_ADDRESS>2 (Beta) no longer breaks Origin of DNSLink websites and provides the same UX as content loaded from public subdomain gateways.

PSA: :loudspeaker:  *.localhost subdomain gateway preview
I just shipped a preview of *.localhost subdomain gateway support (over http proxy to ensure it works on all platforms): v<IP_ADDRESS>3
It redirects both DNSLink and public subdomain gateways to the local one by default
If you find anything that looks or behaves odd, let us know.
It is pretty significant change security and UX-wise, and I am sure there will be kinks to iron out.

I believe this is closed by v<IP_ADDRESS>4, but let's keep this issue open until Stable v2.11.

v2.11.0 hit the Stable channel and is ready for go-ipfs 0.5, which will be released in a few weeks.
For now, one can give it a try with go-ipfs 0.5.0-rc1.
Download it from here or use Docker.
Testing ephemeral container:
$ docker run --rm -it --net=host ipfs/go-ipfs:v0.5.0-rc1

Keeping this open until go-ipfs 0.5.0 ships with ipfs-desktop (https://github.com/ipfs-shipyard/ipfs-desktop/pull/1392)

go-ipfs 0.5.0 shipped,  updated docs in https://github.com/ipfs/ipfs-docs-v2/pull/190


Agent status pending on openshift

What happened:
Self-Agent is in pending status.
k get pod returns only server, frontend and mongo
NAME                                    READY   STATUS    RESTARTS   AGE
litmuschaos-frontend-6859f7b84b-h8w5z   1/1     Running   0          137m
litmuschaos-mongo-0                     1/1     Running   0          137m
litmuschaos-server-64f6d9d784-njmcf     2/2     Running   0          137m

What you expected to happen:
i don't know where to check the logs. server logs indicate no error whatsoever.
How to reproduce it (as minimally and precisely as possible):
install litmuschaos with helm
Anything else we need to know?:
openshift version v1.20.0+87cc9a4
litmusctl create agent failed and new agent shown as pending
litmusctl create agent
Project list:
1.  admin's project

Select a project [Range: 1-1]: 1

Installation Modes:
1. Cluster
2. Namespace

Select Mode [Default: cluster] [Range: 1-2]: 1

🏃 Running prerequisites check....
🔑 clusterrole ✅
🔑 clusterrolebinding ✅
🌟 Sufficient permissions. Installing the Agent...

Enter the details of the agent

Agent Name: my-agent

Agent Description: test

Do you want NodeSelector to be added in the agent deployments (Y/N) (Default: N):

Do you want Tolerations to be added in the agent deployments? (Y/N) (Default: N):

Platform List:
1. AWS
2. GKE
3. Openshift
4. Rancher
5. Others

Select a platform [Default: Openshift] [Range: 1-5]: 3

Enter the namespace (new or existing namespace) [Default: litmus]:
👍 Continuing with litmus namespace

Enter service account [Default: litmus]:

📌 Summary
Agent Name: my-agent
Agent Description: test
Platform Name: Openshift
Namespace:  litmus
Service Account:  litmus (new)

Installation Mode: cluster

🤷 Do you want to continue with the above details? [Y/N]: Y
👍 Continuing agent connection!!
Applying YAML:
http://<ingress-url>//api/file/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiNDU2OTJlNTUtZTg2NC00MjllLTkwZTgtMTkzZWVjMWVjN2ZkIn0.u4cw1N8Ny4pgwy0r-hahQtn-0bHOM6WY5ZxBNnd7O3Axxx.yaml

❌ Failed in applying connection yaml:
error: unable to read URL "http://<ingress-url>//api/file/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJjbHVzdGVyX2lkIjoiNDU2OTJlNTUtZTg2NC00MjllLTkwZTgtMTkzZWVjMWVjN2ZkIn0.u4cw1N8Ny4pgwy0r-hahQtn-0bHOM6WY5ZxBNnd7O3Axxx.yaml", server reported 500 Internal Server Error, status code=500

logs from server at this point
2021/11/03 07:08:20 Server endpoint: http://<ingress-url>/backend/query
2021/11/03 07:08:20 error: open manifests/cluster: permission denied

Openshift 4.6.34
Hello we are encountering the exact same error
2021/11/04 15:31:26 Server endpoint: http://x.x.x.x:30968/query
2021/11/04 15:31:26 error: open manifests/cluster: permission denied

@BK-STAR77 your issue seems to be similar to this one that can be found in our slack channel. It seems to be an issue with permission settings in openshift setup. Ref: https://kubernetes.slack.com/archives/CNXNB0ZTN/p1635992895275800?thread_ts=1635924872.263900&cid=CNXNB0ZTN

The problem in my case is the security context constraint of openshift. You can verify it with exec into the pod and do a ls. it will fail.
To fix this, I need to add anyuid scc to the graphql server service account with the following command and restart the pod
oc adm policy add-scc-to-user anyuid -z <service-account-name> --as system:admin

@BK-STAR77 here's how i fixed it https://github.com/litmuschaos/litmus/issues/3325#issuecomment-961510463
hope it works for you

@BK-STAR77 here's how i fixed it #3325 (comment)
hope it works for you

Perfect. Thank you


Problem w/ Specific Folder Functionality

I'm having a problem (as it seems several others are) with the "Select Specific Folder" functionality. Are there any fixes for this issue?
Slack Username: @garthhill
Email Address<EMAIL_ADDRESS>Thanks!

same.
Slack username: @steampunkprogrammer
email adddress<EMAIL_ADDRESS>


definitions for gulp-load-plugins

Added type definitions for the gulp-load-plugins npm module, as per the documentation:
https://github.com/jackfranklin/gulp-load-plugins

gulp-load-plugins/gulp-load-plugins.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/gulp-load-plugins
http://bower.io/search/?q=gulp-load-plugins
others?

[X] has a test file? (gulp-load-plugins/gulp-load-plugins-tests.ts or others)
[ ] pass the Travic-CI test?

@joeskeen thanks mate!


Bump deps: heif, mozjpeg

FWIW, the libheif bump to v1.17.0 might be a bit too risky/early, see e.g.:
https://github.com/strukturag/libheif/compare/v1.17.0...master
Specifically the fix in commit https://github.com/strukturag/libheif/commit/18d4e550ad7ee114fb95ba2256ee3e756174e92d, which would otherwise prevent AVIF images with premultiplied alpha channels from being decoded.

Yeah, there were a lot of libheif changes just before the latest version was published that are unlikely to have seen enough fuzz testing yet. Those CMake failures should go away if we switch this PR to target the upgrade-linux-containers branch.

Re-targeted to the upgrade-linux-containers branch instead. Commit d51dd3b9f6c80ef5946af7aa1d4bbcfc0ae6a41b is still needed for Debian Buster (an alternative for this would be to upgrade the container to debian:buster-backports, which provides CMake 3.18.4).

Thanks Kleis. I suspect there'll be a patch version of libheif along very soon.


Corrects how localStorage could be used

You can not provide localStorage directly via useValue, you need to have a factory for that.

LGTM, I found exactly the same thing when using the library.
This might've come with the latest version of the library, as I have an app still on 4.x, which does provide it with useValue...


UI borders and outlines clipping fix

Objective
Clipped borders and outlines aren't drawn correctly.
Borders aren't clipped
Example, spawn two nodes with the same dimensions and border thickness, but clip the seconds so that only the top left quarter is visible:

Instead of clipping the border, it scales it down instead to fit inside the unclipped section of the node.
use bevy::color::palettes::css::BLUE;
use bevy::prelude::*;
use bevy::winit::WinitSettings;

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .insert_resource(WinitSettings::desktop_app())
        .add_systems(Startup, setup)
        .run();
}

fn setup(mut commands: Commands) {
    commands.spawn(Camera2d);
    commands
        .spawn(Node {
            width: Val::Percent(100.),
            height: Val::Percent(100.),
            justify_content: JustifyContent::Center,
            align_items: AlignItems::Center,
            ..Default::default()
        })
        .with_children(|commands| {
            commands
                .spawn(Node {
                    column_gap: Val::Px(10.),
                    ..Default::default()
                })
                .with_children(|commands| {
                    commands
                        .spawn(Node {
                            width: Val::Px(100.),
                            height: Val::Px(100.),
                            overflow: Overflow::clip(),
                            ..Default::default()
                        })
                        .with_child((
                            Node {
                                position_type: PositionType::Absolute,
                                width: Val::Px(100.),
                                height: Val::Px(100.),
                                border: UiRect::all(Val::Px(10.)),
                                ..Default::default()
                            },
                            BackgroundColor(Color::WHITE),
                            BorderColor(BLUE.into()),
                        ));

                    commands
                        .spawn(Node {
                            width: Val::Px(50.),
                            height: Val::Px(50.),
                            overflow: Overflow::clip(),
                            ..Default::default()
                        })
                        .with_child((
                            Node {
                                position_type: PositionType::Absolute,
                                width: Val::Px(100.),
                                height: Val::Px(100.),
                                border: UiRect::all(Val::Px(10.)),
                                ..Default::default()
                            },
                            BackgroundColor(Color::WHITE),
                            BorderColor(BLUE.into()),
                        ));
                });
        });
}

You can also see this problem in the outflow example. If you hover over any of the clipped nodes you'll see that the outline only wraps the clipped area and not the entire node.
fixes #15502
Outlines are clipped incorrectly
A node's Outline should be clipped using its parent's clipping rect, not its own.
Solution

Pass the point value into the vertex shader instead of calculating it in the shader.
In extract_uinode_borders use the parents clipping rect when clipping outlines.

The extra parameter isn't a great solution I think, but borders needed to be fixed for the 0.15 release and this is the most minimal approach I could think of without replacing the whole shader and prepare function.
Showcase

I'll update the docs for the new paramater in a few hours, got some errands I need to run.


Only create sessions for authenticated users

Don't track any data about users who are not authenticated.

Accomplished by getting rid of sessions.


fix: remove storage account key in az storage command

What type of PR is this?
/kind fix

What this PR does / why we need it:
remove storage account key in az storage command.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.869%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3034

Relevant Lines:
3947

💛  - Coveralls


feat(updater): add .csproj file support

Just a new internal updater implementation to support the .NET .csproj

This is awesome, thanks! Could you add this capability into the readme too?

I will try to check this tomorrow.
Do I just add a section about .NET and .csproj files like the gradle-support-javakotlin one ?

Sounds good!

That's it.
I also rebased on master.
Let me know if there is something else.

Released in 11.3.0. Thanks again!


Browse themes & runtimes

It should be possible to browse themes, runtimes and extensions present in flathub

I'm not sure this is something that should be exposed in the store, to be honest. Certainly runtimes and extensions are implementation details.

Themes should "just work" also. flatpak now auto-installs them on updates and while that still leaves some gaps in UX the user still shouldn't need to seek them out.

The most important use case here would be to see what SDKs/languages can be installed for developers.

Developers would probably be able to use flatpak to list sdks, I'm not sure what value the website would add.

Developers would probably be able to use flatpak to list sdks, I'm not sure what value the website would add.

Convenience? I personally tend to checkout what tools I get before I install a massive application


Can we play .ism/Manifest,or ism/manifest(format=m3u8-aapl) with ionic streaming media

i am using streaming media version 2.2.0
my cordova version is 5.2.3
i am using android and ios.
I am using the .ism/manifest and .ism/manifest(format = m3u8-aapl).when the application loads the video url page the whole application gonna crash.

Same error, but only in Android.
My cordova version is 9.0.0


net/http: HTTP2 pushing is suprisingly slow

What version of Go are you using (go version)?

$ go version
go version go1.17.7 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/mitar/.cache/go-build"
GOENV="/home/mitar/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/mitar/.go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/mitar/.go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.7"
GCCGO="/usr/bin/gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build680865618=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I am trying to push multiple requests using HTTP2.
What did you expect to see?
From reading pusher.Push documentation, my expectation was that pushing negligibly impacts time the main request is served, as all pushing happens in separate goroutines.
What did you see instead?
I am observing that this is not the case. I made a simple test and pushing 100 requests with 10 KB large responses takes 8 ms on my local machine, pushing 100 requests with 1 MB large responses takes 35 ms. So this is just additional time added to the main request handling to call pusher.Push in a loop. Not how long it takes for the pushed responses themselves to be delivered. This is a surprising amount to me.
From looking at the code, I think the issue is that pusher.Push waits until it can send a startPushRequest message to serveMsgCh and with many push requests this can block for non-trivial amount of time.
I made a small example here. See README for instructions how to run it.

cc @neild

It seems it might not be the serveMsgCh. I increased queue size to 800 to experiment and it was still slow. So being able to push into serveMsgCh quickly might not be the issue. So probably it is being blocked on processing the message and waiting on msg.done.

cc @dunglas, Not sure if you experienced this. I was trying to do something similar to Vulcain, and push embedded objects using HTTP push instead of embedding them into the main object, but observed increased latency of processing the main request is somewhat killing the point.


tests: add upstream address param to integration tests

Description: This PR adds the ability to specify an upstream address (both port & IP) to HttpIntegrationTest and BaseIntegrationTest and also changes {Autonomous/Fake}Upstream to specify an address instead of using the default (INADDR_ANY).
The purpose here is to enable future integration tests to provide an upstream address other than INADDR_ANY for use in testing IP address-specific behavior.
Risk Level: Low
Testing: Ran bazel test //test/integration/...
Docs Changes: N/A
Release Notes: N/A

this requires senior approver review after the last comment is addressed.

Looks like the ci test failed to pull google/benchmark:
ERROR: /source/bazel/repositories.bzl:411:5: no such package '@com_github_google_benchmark//': java.io.IOException: Error downloading [https://github.com/google/benchmark/archive/505be96ab23056580a3a2315abba048f4428b04e.tar.gz] to /build/tmp/_bazel_bazel/436badd4919a15958fa3800a4e21074a/external/com_github_google_benchmark/505be96ab23056580a3a2315abba048f4428b04e.tar.gz: GET returned 502 Bad Gateway and referenced by '//external:benchmark'
Analyzing: 121 targets (234 packages loaded, 7558 targets configured)

I think the http retriever used by our bazel builds won't retry on 502s: https://github.com/bazelbuild/bazel/blob/5e56770f5f78a3c9b0cc59f00a1c6f1cf062207a/src/main/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnector.java#L159

/retest


English translation for snowflake

Hi, I only added a english doc markup file, but the build is failing. Is there something I can do to fix this?

It looks like we can ignore this error, I have merged this PR, thank you @jeroenherczeg


queue: Update error callback signatures for Pika 1.1

The expected signatures for these callbacks seem to have changed somewhere in https://github.com/pika/pika/pull/1002.
Testing Plan: adventure

Merged, thanks @andersk!


[Editor|Proposal] Copy Entity Markers

Currently, you can select a tile region in a level and copy-paste it to another region. However, entity maker information is not copied over. Would it be beneficial to copy this information as well?

I think it would be useful.


[Core] [Math] Fix fposmod() function

The output of the fposmod function is wrong. According to the documentation, the value "wraps equally in positive and negative". The docs describe correct behavior in the wording, but we can see that this is not the actual behavior with the example output and test code. Code:
	var i = -10;
	while i < 11:
		prints(i, fposmod(i, 5))
		i += 1

Output:
-10 5  # Wrong
-9 1
-8 2
-7 3
-6 4
-5 5   # Wrong
-4 1
-3 2
-2 3
-1 4
0 0    # Correct
1 1
2 2
3 3
4 4
5 0    # Correct
6 1
7 2
8 3
9 4
10 0   # Correct

In the positives, the value wraps on a range of [0, b) (0 inclusive, b exclusive), while in the negatives, the value wraps around the range (0, b] (0 exclusive, b inclusive). This is incorrect behavior. The values should wrap around in the same way in both the positives and negatives. Furthermore, passing the output back into the function should return the same value again.
In fact, the whole implementation of the function is wrong. In theory returning [0, b) means negative values for b would give negative results, but very strange results happen when I pass -5.
-6 -6
-5 -5
-4 -9
-3 -8
-2 -7
-1 -6
0 0
1 1
2 2
3 3
4 4
5 0

This is the correct implementation of fposmod over fmod, always on the range [0, b):
float p_value = Math::fmod(p_x, p_y);
if ((p_value < 0 && p_y > 0) || (p_value > 0 && p_y < 0)) {
	p_value += p_y;
}
return p_value;

The only weird thing, is that the GDscript test code prints negative zero for some reason? I'm probably missing some minor tweak to make it appear as positive zero. EDIT: Adding 0.0 removes the negative sign.
-5 0
-4 1
-3 2
-2 3
-1 4
0 0
1 1
2 2
3 3
4 4
5 0

Can we get this PR merged this week? I believe the code is good as-is. Thanks.

Although the fix may be right, the change could still cause regressions since the engine uses this function in several places. We need to make sure none of these places was relying on the wrong outputs for correct behavior.


[REF] remove duplicated code

@ufaks simplify this too:
                        (self.new_client && self.new_client.id) || (curr_client && curr_client.id),

@ufaks you need to rebase your branch


Allow HTTP Basic Auth

This adds 2 options: http_basic_auth_username and
http_basic_auth_password which when passed adds HTTP Basic
Authentication to the web frontend.
For those who just want to deploy some quick basic auth rather than creating a proxy server
Websockets are tested & working. We are actively using this fork in our staging environment

Hello, just wondering if there's any feedback on this?

Thank you for the contribution, but I don't want to add basic auth support within mailcatcher at this time. It has been suggested before, and the reasons for avoiding it remain: https://github.com/sj26/mailcatcher/pull/35#issuecomment-3997955


Can floss be used for finding Chinese Chars?

I tested this interesting project on windows7 32bit .In IDA Pro,i can find some chinese chars, but this one cannot. I noticed the readme.md said default mode , so i wonder if there is an another option for chinese or utf-8 encoded strings?

Actually rather than "ASCII with interspersed NULL bytes" I would rather say "printable ASCII characters encoded as UTF-16-LE". And "UTF-16-LE" is the way Unicode strings are encoded in Windows PEs.
@bugmeout The difficulty is that detecting Unicode-encoded strings in some arbitrary binary stream is hard unless you have some pattern of sorts that you can identify. Even if you limit yourself to UTF-16-LE, where do you start? How can you find when something is some bona fide UTF string vs. some random garbage?
Even in the simpler case of just detecting if a whole file is text or binary this is not trivial. See for instance this https://github.com/audreyr/binaryornot/blob/9efb669f0c96172f8062388c1710f7be08071a92/binaryornot/helpers.py where I contributed the unicode detection (to avoid detecting unicode-encoded whole text files as binary). This entails using chardet which is a heuristic-based encoding detector and various cooking to make a reasonable guess.


Update any print statements to actual logging

Probably doesn't matter. Going to sunset the Go stuff as soon as possible.


[API-445] gcc 4.9 and 5 versions project compilation fixes

gcc 4.9 and 5 versions failed compilation during the conan update PR for 4.1.0 version . These fixes make the project compile for older gcc versions 4.9 and 5 properly.

Windows test PASSed.

Linux test PASSed.


Emit Sync Job Finished Status After Sync Completion

Description
@jingtang10 @aditya-07 I think we should emit the Success status as well. Currently once its done downloading we don't notify dependent apps.
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Good catch @aditya-07 ! Yes, this is correct

Noted

Closing this for now


Images not appearing

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
latest
Issue Description
i just installed the website on my cpanel host. i tried to update the logo and favicon. After i save configuration the logo does not appear but it shows a broken image icon. i also tried to add an item/product but the image does not appear also.
i ainstalled the website using the GUI intaller.
please assist
Preconditions
I am using an online host and used the GUI installer to install
Steps to reproduce

went to admin
tried to update logo, favicon and tried to add a product
saved the configuration
after saving the images do not appear but it shows a broken image icon

Expected Result
Images should show
Actual Result
images not showing but broken image icon appears
Screenshots

Additional context
No response

@Thapelo-Laroc ,
It might be possible that if you are facing a broken image issue, then maybe app_url is not set properly inside the [.env] file. Please check once and verify that App_URl contains your website URL properly (without the slash at the end of the URl).

This was the issue thank you.
On my localhost the Images were showing but not on the online host. So I
compared the App_URl of the localhosted website and the online one. Turns
out that the localhosted URl has double slashes before public like this "
http://localhost/websites//public"
Then the online URl was "https://domain/public"
I had to insert the second slash on public "https://domain//public".
That fixed the problem.
Thank very much 🙏.
On Thu, 14 Dec 2023, 06:39 Amit kumar, @.***> wrote:

@Thapelo-Laroc https://github.com/Thapelo-Laroc ,
It might be possible that if you are facing a broken image issue, then
maybe app_url is not set properly inside the [.env] file. Please
check once and verify that App_URl contains your website URL properly
(without the slash at the end of the URl).
—
Reply to this email directly, view it on GitHub
https://github.com/bagisto/bagisto/issues/9143#issuecomment-1855117712,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BABDZZ6MP4XJSSIQUHIR2WDYJJ7IRAVCNFSM6AAAAABAUCI6VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVGEYTONZRGI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Drop-down buttons in Gallery bug, shows red screen

On a Nexus 5, running a build from approximately 2pm on Monday (today).

We should fix these by writing (simple) drive tests to touch these parts of code.  flutter.io/testing shows how, or I'm happy to give in-person demos.

This isn't a bug (anymore).
I am writing some simple gallery smoke tests now.


JavaScript Intellisense doesn't autocomplete Element.value property

const paragraph = document.querySelector('p.description');
const input = document.querySelector('input.description');
const button = document.querySelector('button.description');

button.addEventListener('click', () =>
{
    paragraph.textContent = input.value; //This always wants to autocomplete to .nodeValue instead of .value
});

VSCode Version: 1.39.2
OS Version: macOS Mojave 10.14.6

When I need to get the .value of an element, VSCode is only autocompleting .nodeValue and .value doesn't even show up in the list of suggestions to autocomplete. I disabled all of my extensions and relaunched VSCode and the same problem occurs. This is causing me to have to press escape as soon as I finish typing .value because if I add a semicolon it autocomplete to .nodeValue.
Does this issue occur when all extensions are disabled?: Yes

I updated my OS to macOS Catalina, and the autocomplete works now. So strange...


Landscape preview distorted / zoomed

Tested on Samsung tab and phone and I have a problem with when rotating to landscape the camera image looks zoomed in. It is fine on portrait mode and the captured preview is displaying ok on both landscape and portrait. Is there a fix for this.

Galaxy Tab 2 10.1, the same story.

Anyone figured out how to fix this?

I've been able to resolve this. In Camera1.Java, line 14:
this.mDeviceOrientation = deviceOrientation
Is not always set correctly. The device arbitrarily sets it to 0, even if the device is rotated. I decided to create a new boolean to store whether or not the device is in landscape or not, and base this on displayOrientation, which seems to be set consistently:
   //Device orientation is not reliable. Create a separate boolean to keep track of real orientation
        if (mDisplayOrientation == 90 || mDisplayOrientation == 270) {
            isLandscape = true;
        }

Later in line 473, the previewSize is inverted based on the device orientation:
 boolean invertPreviewSizes = (mCameraInfo.orientation + mDeviceOrientation) % 180 == 90;
        if (mPreviewSize != null && invertPreviewSizes) {
            return new Size(mPreviewSize.getHeight(), mPreviewSize.getWidth());
        }

I switched this to my new boolean:
boolean invertPreviewSizes = !isLandscape;
        if (mPreviewSize != null && invertPreviewSizes) {
            return new Size(mPreviewSize.getHeight(), mPreviewSize.getWidth());
        }

Secondly, on line 616, the mPreview previewParameters are also set based on the deviceOrientation, but on top of that, invertPreviewSizes is used to flip height and width:
 if (mDeviceOrientation == 0 || mDeviceOrientation == 180) {
                mPreview.setPreviewParameters(
                        getPreviewResolution().getWidth(),
                        getPreviewResolution().getHeight(),
                        mCameraParameters.getPreviewFormat()
                );
            } else {
                mPreview.setPreviewParameters(
                        getPreviewResolution().getHeight(),
                        getPreviewResolution().getWidth(),
                        mCameraParameters.getPreviewFormat()
                );
            }

            mCameraParameters.setPreviewSize(
                    invertPreviewSizes ? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),
                    invertPreviewSizes ? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()
            );

Here I also switched to my new boolean instead of mDeviceOrientation to check what is required, but I only use this information to determine whether to invert height and weight. I don't think it makes sense to first set the preview on width/height or vice/versa, but then invert again. So the new code ended up being:
boolean invertPreviewSizes = !isLandscape;

if (getPreviewResolution() != null) {

            mPreview.setPreviewParameters(
                    getPreviewResolution().getWidth(),
                    getPreviewResolution().getHeight(),
                    mCameraParameters.getPreviewFormat()
            );

            mCameraParameters.setPreviewSize(
                    invertPreviewSizes ? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),
                    invertPreviewSizes ? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()
            );

Tested on Samsung S8 Android 7.0 and preview shows correctly in both Landscape and Portrait. Hope this helps to resolve this across the board for all devices.

@getupcast Would you be willing to submit a Pull Request for this?

I've been able to resolve this. In Camera1.Java, line 14:
this.mDeviceOrientation = deviceOrientation
Is not always set correctly. The device arbitrarily sets it to 0, even if the device is rotated. I decided to create a new boolean to store whether or not the device is in landscape or not, and base this on displayOrientation, which seems to be set consistently:
   //Device orientation is not reliable. Create a separate boolean to keep track of real orientation
        if (mDisplayOrientation == 90 || mDisplayOrientation == 270) {
            isLandscape = true;
        }

Later in line 473, the previewSize is inverted based on the device orientation:
 boolean invertPreviewSizes = (mCameraInfo.orientation + mDeviceOrientation) % 180 == 90;
        if (mPreviewSize != null && invertPreviewSizes) {
            return new Size(mPreviewSize.getHeight(), mPreviewSize.getWidth());
        }

I switched this to my new boolean:
boolean invertPreviewSizes = !isLandscape;
        if (mPreviewSize != null && invertPreviewSizes) {
            return new Size(mPreviewSize.getHeight(), mPreviewSize.getWidth());
        }

Secondly, on line 616, the mPreview previewParameters are also set based on the deviceOrientation, but on top of that, invertPreviewSizes is used to flip height and width:
 if (mDeviceOrientation == 0 || mDeviceOrientation == 180) {
                mPreview.setPreviewParameters(
                        getPreviewResolution().getWidth(),
                        getPreviewResolution().getHeight(),
                        mCameraParameters.getPreviewFormat()
                );
            } else {
                mPreview.setPreviewParameters(
                        getPreviewResolution().getHeight(),
                        getPreviewResolution().getWidth(),
                        mCameraParameters.getPreviewFormat()
                );
            }

            mCameraParameters.setPreviewSize(
                    invertPreviewSizes ? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),
                    invertPreviewSizes ? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()
            );

Here I also switched to my new boolean instead of mDeviceOrientation to check what is required, but I only use this information to determine whether to invert height and weight. I don't think it makes sense to first set the preview on width/height or vice/versa, but then invert again. So the new code ended up being:
boolean invertPreviewSizes = !isLandscape;

if (getPreviewResolution() != null) {

            mPreview.setPreviewParameters(
                    getPreviewResolution().getWidth(),
                    getPreviewResolution().getHeight(),
                    mCameraParameters.getPreviewFormat()
            );

            mCameraParameters.setPreviewSize(
                    invertPreviewSizes ? getPreviewResolution().getHeight() : getPreviewResolution().getWidth(),
                    invertPreviewSizes ? getPreviewResolution().getWidth() : getPreviewResolution().getHeight()
            );

Tested on Samsung S8 Android 7.0 and preview shows correctly in both Landscape and Portrait. Hope this helps to resolve this across the board for all devices.

@austinkettner sorry was logged in under corporate account. I can't really do a pull request because I made many other changes specific to my implementation that may muddy the waters....

Understood @rogerdcarvalho we will get this in soon =)

Is this in the code yet? I am getting the issue on Samsung

@harishvishwakarma Can you test this in the 1.0.0 PR? https://github.com/CameraKit/camerakit-android/pull/318 - should be resolved, but if not let me know!

@austinkettner : It is resolved in the mentioned PR. I am very much impressed at how much easy this makes Camera implementation. Thanks for the library.
When are you planning to put this to master branch? I am planning to use it for a production application.
Methods have changed in this one though and cannot really find documentation for that.

How to turn on autofocus?
How to turn on auto-crop to view bounds?
How to turn on pinch to zoom?

Glad it's working much better in the 1.0.0! Can you please comment in the PR with 1-3, we will add documentation for this shortly.
Documentation as a whole for 1.0.0 is still coming, so we plan on having a fully dedicated documentation site ahead of merging.


internal/operator tests: re-get Contour before updating

Re-gets Contour before attempting to update it, to avoid having a
stale in-memory version that can't be updated. Fixes a test flake.
Signed-off-by: Steve Kriss<EMAIL_ADDRESS>

See e.g. https://github.com/projectcontour/contour-operator/runs/2324525760?check_suite_focus=true#step:5:121 for an example of the failure.

Hmm, looks like this didn't actually work, I am just seeing another failure on main even with this change in place:
https://github.com/projectcontour/contour-operator/runs/2364617799


Loadbalancer service egress connection via DSR breaks when rollout restart of pods.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When targets of a LoadBalancer service with DSR enabled are rollout restarted, as soon as the pod is removed from the service endpoint list, egress connectivity of the Pod stops working.
Expectation:
The pod should have egress connectivity till the pod is completely terminated. This is the default behavior of pods behind a LoadBalancer service without DSR.
Cilium Version
v1.11.3-62aa82d
Kernel Version
5.4.0-90-generic
Kubernetes Version
v1.21.8
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Have you enabled https://docs.cilium.io/en/stable/gettingstarted/kubeproxy-free/#graceful-termination?

Hello, thanks for pointing to that documentation!
I have enabled feature gate: EndpointSliceTerminatingCondition in the cluster, restarted cilium, confirmed that Graceful Termination is enabled, but we still see the same behavior.The pod can not send the


Issue 223: Validate colon not present when saving provider_location.externalId

This PR addresses #223 by throwing an error if : is present in the system component of a provider_location.externalId. Note, this does not check if : is present in value.
If : is present on create, the provider location is created without any external ids. If present on update, the original external Ids are preserved.
Let me know if there are any thoughts or feedback here!
Fixes #223

As discussed on slack, I'll defer the updates to the hook in another PR. I previously tried truncating after each test but I ran into database integrity errors I believe because I did not truncate all application tables.


GUI: Add help/description to nodes

Describe the solution you'd like
Placing the mouse over the node will show a description of the nodes actions
Describe alternatives you've considered
We can use nodes help feature included in VPLControl

e575ce67


Multiple editors and accessing editors by id through context provider

We are building a webapp with multiple editors that can be updated through interactions with other parts of the UI. For example, we have a PDF viewer from which you can add the selection to the last active editor.
We are currently using slate, but testing out Lexical on recommendation of an expert. With slate we have a context provider which stores in state a map from editorId to Editor.  We can then dynamically add and remove editors by id, as well as get an editor by id from any child of that provider.
I'm wondering how to do this with Lexical? It seems that creation and initialization is now an implementation detail of <LexicalComposer />, so I'm wondering how to "get the editor out" of that subtree. Best I've though of so far (untested):
import { useEffect } from 'react'
import { LexicalComposer } from '@lexical/react/LexicalComposer'

function Editor(props) {
  // hook to access editor context
  const editors = useEditors()
  useEffect(() => () => editors.deleteEditor(props.editorId), [])
  return (
    <LexicalComposer
      initialConfig={{
        namespace: props.editorId,
        editorState(editor) {
          editors.createEditor(props.editorId, editor)
        },
        ...
      }}
    >
      ...
    </LexicalComposer>
  )
}

Closing as we chatted about this in the Discord. The agreed upon answer was to pass editor instances up to a parent context using a custom plugin via useEffect.