[Bug] BROADCASTING DefaultMQPushConsumer can't fix illegal pull offset

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
centos7
RocketMQ version
4.9.x | 5.1.x
JDK Version
JDK 1.8
Describe the Bug

We encountered a issue that the BROADCASTING DefaultMQPushConsumer was unable to consume: As shown in the log, the client received the OFFSET_ILLEGAL response returned by the broker and kept trying to fix nextOffset but failed, resulting in the inability to consume messages.
我们遇到了一个 Push 消费者广播模式无法消费的问题：如日志所显示，客户端收到了服务端返回的 OFFSET_ILLEGAL，一直在尝试纠正 nextOffset 但始终不能成功，导致无法消费。
Steps to Reproduce

Create a topic and produce certain messages.
Wait for message to expire (queue minOffset >0).
Create a subscription group and start a DefaultMQPushConsumer (MessageModel=BROADCASTING, ConsumeFromWhere=CONSUME_FROM_FIRST_OFFSET).
Produce more messages.

What Did You Expect to See?
Normal message consumption.
What Did You See Instead?
The consumer is unable to consume any messages.
Additional Context

Possible cause we located after reviewing code:
When the consumer handles OFFSET_ILLEGAL error, it will first set the correct nextOffset returned by the broker as the consumerOffset (in memory), and then delete the PQ corresponding to the MQ. When the next time the rebalance is triggered, it is expected to set the new consumerOffset as the nextOffset, reinitialize PQ and start pulling messages. But at this time the consumerOffset is read from the store (ReadOffsetType=READ_FROM_STORE), so it will always  get -1. As a result, the client will fall into an infinite loop of the above process.
消费端在处理 OFFSET_ILLEGAL 时，首先会将服务端返回的正确的 nextOffset 更新为消费位点（内存），接着删除 MQ 对应的 PQ。下次重平衡触发时，预期是将新的消费位点作为 nextOffset 重新初始化 PQ 并开始拉取消息。但此时是从持久化介质读取消费位点 (ReadOffsetType=READ_FROM_STORE)，因此永远只会读到 -1。于是，客户端会陷入上述过程的无限循环中。

之前我也遇到过这个问题，可以提个 patch 修复下

之前我也遇到过这个问题，可以提个 patch 修复下

提了一个 patch，有时间可以帮忙一起 review 下～


Win32 builds

Hi, I was trying to make a win32 build and I got an error message.  When I do "./build.sh win32 lgpl-shared 4.4", the error message is "docker: Error response from daemon: Head "https://ghcr.io/v2/btbn/ffmpeg-builds/win32-lgpl-shared-4.4/manifests/latest": denied."  I get a similar error message on other win32 variants.  Is the win32 build still supported?  I think I have my environment set up OK because I was able to do a win64 build just fine.  Thanks!

You have to make the image first, since there are no pre-builts for win32.

Doh!  Thanks for the prompt reply - that fixed it.  And thanks a lot for giving us this build process - it's very nice!


Bell broken in canary

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10
Hyper.app version: canary.14

Issue

When looking through the code trying to solve issue #1613, I found that the bell is broken on all platforms. After editing config, the file lib/components/term-group.js adds the bell property to props here:
https://github.com/zeit/hyper/blob/76beaa32f5f3285bc8f7083fff8cd722ba97f60a/lib/components/term-group.js#L82 But when it is passed to the file lib/components/term.js, where the new terminal is created, it is not actually used. For this reason, the terminal doesn't seem to be making any sound regardless of the setting on Mac and Linux. This may have happened during the switch from hterm to xterm.
On windows, the sound that plays depends on which terminal is being used. By default, hyper uses cmd, so the bell sound is the default bell sound for cmd. If the terminal is switched to bash (Linux subsystem), the bell sound is again the default sound for bash on Windows. PowerShell doesn't seem to have a bell by default, so if PowerShell is used, no bell sound is heard.
If the bell is not desired, a temporary solution to this may be to use PowerShell by default if the operating system is Windows 10, as this will disable the sound.

@aditya0099 Do you want to make a PR to fix this?

@Stanzilla @aditya0099 There is an open pull request that is addressing this issue currently #2938. Stay tuned ;D


Update Temurin Spec | Linux

Description
Update Temurin spec | Linux
This PR fixes https://github.com/adoptium/installer/issues/417
Signed-off-by: Shriti Chandra<EMAIL_ADDRESS>

@chandrashritii you'll need to sign the Eclipse Foundation CLA

Thanks for the review! @jiekang Added the necessary changelogs

@chandrashritii There are still two commits with an unknown author/email address. You will need to modify those for the ECA check to pass. I recommend using git rebase -i and making this a single commit with your changes on top of the latest adoptium:master commit.

Specifically:
https://github.com/adoptium/installer/pull/623/commits/eb2dac66d5b14531339d974fec6da75d0050ffea
https://github.com/adoptium/installer/pull/623/commits/3614035b76532236ec45bd2cb64101e8b8ad5e4e

https://stackoverflow.com/questions/34850831/change-git-email-for-previous-commits may help

This will also need updating to include the recently added JDK20 config files

@chandrashritii will need a rebase

@chandrashritii getting close, just some errors in the changelog format, see the failing GH Actions

Thanks! @karianna Fixed the changelog format

SUSE jobs still failing but no clear reason as to why

I think the jdk 19 jobs fail due to the ExclusiveArch check in build.sh not accounting for specs without that field. However we can drop the changes to the 19 specs as 20 is out and ignore them.

@jiekang Will need a rebase now sorry :-(

Still have failing SUSE jobs...

/thaw


What the password for django ?

I need this also, I didn't find it anywhere :(

Have you run the initial test data migrations? If so, the test accounts are in the README file. Otherwise the app will have no accounts. You need to generate a registration token using the create_invite command https://github.com/OkunaOrg/okuna-api#managepy-create_invite and register using the API or from the mobile app.


<player.item_in_hand.material.formatted> gives 'null'

this seems to have happened recently (sorry that's vague). using #1597

material.formatted is not a supported tag, you probably want <player.item_in_hand.formatted>

don't leave me in suspense..

<player.item_in_hand.formatted>

thx, working fine now.


Adaptation of SendTemplatedEmailProcess to also support principle nam…

Adaptation of SendTemplatedEmailProcess to also support principle names, not only paths. This makes life easier to use same workflow on multiple environments/stages

Pull Request Test Coverage Report for Build 5212

0 of 9 (0.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 55.228%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

bundle/src/main/java/com/adobe/acs/commons/email/process/impl/SendTemplatedEmailProcess.java
0
1
0.0%

bundle/src/main/java/com/adobe/acs/commons/email/process/impl/SendTemplatedEmailUtils.java
0
8
0.0%

Totals

Change from base Build 5197:
-0.01%

Covered Lines:
14874

Relevant Lines:
26932

💛  - Coveralls


Optimizes extract_output for 1 element accumulator case.

Simple optimization for {CallableWrapperCombineFn, NoSideInputsCallableWrapperCombineFn}.extract_output that takes advantage of the corresponding (optional) compact behavior.
(Prepared by @katsiapis).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @yifanmai
cc: @robertwb

We need to revert this change.
Beam Combiners are associative and commutative reduction operators. It is reasonable to assume that the input fn to CombineFn.from_callable() must be an associative and commutative reduction. Being idempotent on single-element inputs not a requirement. There can be  potentially useful combiners that are not idempotent, for example a combiner that checks whether a particular element is in a PCollection,  generated by CombineFn.from_callable(lambda input_list: 'some_element' in input_list).
Beam programming guide[1] also mentions this:

When you apply a Combine transform, you must provide the function that contains the logic for combining the elements or values. The combining function should be commutative and associative, as the function is not necessarily invoked exactly once on all values with a given key.

The implementation of CallableWrapperCombineFn/NoSideInputsCallableWrapperCombineFn should guarantee that if the input fn is an associative and commutative reduction, the resulting combiner produced by the result of wrapping the fn will also be an associative and commutative reduction, producing the same behavior.
With this change, we no longer have this guarantee. Calls to CallableWrapperCombineFn.add_input() append an element to an accumulator, but if there is only one accumulator with only one element, we assume it is already a combined value and don't call self._fn() (the intent of the optimization in this change). For non-idempotent reducers, this is not the case.

thanks, @y1chi who flagged it.

CombineFn.from_callable(lambda input_list: 'some_element' in input_list) would not work as a combiner since the fn is not associative/commutative. CombineFn.from_callable(lambda input_list: 2*sum(input_list)) is a better example.

f(a, b, ...) = 2 * sum(a, b, ...) is not associative:
f(f(a, b), c) = 4a + 4b + 2c
f(a, f(b, c)) = 2a + 4b + 4c
f(f(a, b), c) != f(a, f(b, c))

A better example would be sum modulo n i.e. f(a, b, ...) = sum(a, b, ...) % n

f(a, b, ...) = 2 * sum(a, b, ...) is not associative:
f(f(a, b), c) = 4a + 4b + 2c
f(a, f(b, c)) = 2a + 4b + 4c
f(f(a, b), c) != f(a, f(b, c))

A better example would be sum modulo n i.e. f(a, b, ...) = sum(a, b, ...) % n


Mysql Erro

Why do i always get this error?
?bitcoinMySQL Error: Table 'gourl.crypto_payments' doesn't exist; SQL: SELECT paymentID, amount, amountUSD, txConfirmed, txCheckDate, txDate, processed, boxType FROM crypto_payments WHERE boxID = 5424 && orderID = 'premium_membership' && userID = 'xzx' && txDate >= DATE_SUB('2017-06-06 10:14:57', INTERVAL 1 MONTH) ORDER BY txDate DESC LIMIT 1

You need to create mysql table crypto_payments
Instruction -
https://github.com/cryptoapi/Payment-Gateway#mysql-table


pylcaio.LCAIO.extract_*

Documentation:

[ ] add data input/output format documentation
[ ] add mathematical formulation of data manipulation

Refactoring:

[ ] implement function using native Pandas/NumPy objects and methods
[ ] document performance improvements
[ ] create MWE input/output data for unit test

extract_scaling_vector_technosphere
extract_scaling_vector_biosphere
extract_flow_amounts_technosphere


GEODE-2104: Fix parsing of options following --J

LGTM. build it and start up gfsh and play with it with different options and see if it's not having some side effects. After that I can pull this in.


Indent logs with a context manager

Introduces new context manager LogContext.intentation(). Usage:
from piptools.loggin import log

log.debug("Hello")

with log.indentation():
  log.debug("World!")

Output:
Hello
  World!

Addresses https://github.com/jazzband/pip-tools/pull/1109#discussion_r410993582.

Changelog-friendly one-liner: Indent logs with a context manager.
Contributor checklist

[X] Provided the tests for the changes.
[X] Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Since it's not user-facing I won't assign it to the milestone.

Thank you, @AndydeCleyre, for reviewing this! Much appreciated 🙏


⚠ ZV800.com has degraded performance

In 28bea37, ZV800.com (https://www.zv800.com//) experienced degraded performance:

HTTP code: 200
Response time: 2013 ms

Resolved: ZV800.com performance has improved in cc79427 after 22 minutes.


Pixel threshold for centroid refinement

Why this PR?
Sometimes on refinement you don't want to include interpolated points where the signal level is too low for reliable localization (eg, can be detrimental for MSD analysis). This PR adds an optional keyword argument to do this filtering.

The unexpected changes in results mentioned above result from tracks being too close together. Because these are not taken into account during this refinement, it leads to bias towards the middle of the two tracks. Closing this for now; it seems that gaussian refinement will be the only proper way to handle situations like this


Strange Bcc headers logic

I'm tring to add Bcc and Cc headers passed from my CMS, as in documentation i've got
$bcc = array(
array('abc@abc.com'=>'abc'),
array('cba@cba.com'=>'cba'),
);
$mail->setBcc($bcc)

causes ContextErrorException: Warning: Illegal offset type in /var/web/inventure/data/Skynar/swiftmailer/lib/classes/Swift/Mime/SimpleMessage.php line 405
$mail->setBcc([]);
foreach($bcc as $address)
	$mail->addBcc($address) -> Validation error

$mail->setBcc([]);
foreach($bcc as $addr){
	$name = current($bcc);
	$email = key($bcc);
	$mail->addBcc($email,$name); -> this way it works
}

what am i doing wrong?

I'm getting the same results as posted above "preg_match() expects parameter 2 to be string" for a valid cc array.


Exception on exit...

On exit, I'm usually (not always) seeing...
Exception in thread Thread-1 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
  File "/usr/local/lib/python2.7/dist-packages/pychromecast/socket_client.py", line 349, in run
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'SSLError'

Any ideas?  What is the approved method of disconnecting before exit?

Are you using 0.7.4 that got released 2 hours ago? It has a fix for errors on closing

Yes, I'm using 0.7.4.  (Searched the issues, saw that one and upgraded to check before posting.)
$ pip show -f pychromecast
---
Metadata-Version: 2.0
Name: PyChromecast
Version: 0.7.4
Summary: Python module to talk to Google Chromecast.
...

Curious...
I added some hackery to try to shut up the error messages:
if cast:
   try:
      sys.stderr = open("/dev/null", "w")
      cast.disconnect(None, False)
   except:
      print "(error on disconnect)"
      pass

This is right at the end of my script.
And I still see this message (on stderr!):
Exception in thread Thread-5 (most likely raised during interpreter shutdown):

So the problem is happening very late in the shutdown sequence.


Improve errors and add tests

Codecov Report

Merging #15 into master will increase coverage by 0.81%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #15      +/-   ##
=========================================
+ Coverage   61.68%   62.5%   +0.81%
=========================================
  Files          26      26
  Lines        2067    2064       -3
=========================================
+ Hits         1275    1290      +15
+ Misses        792     774      -18

Impacted Files
Coverage Δ

src/itensor.jl
76.69% <100%> (+7.57%)
:arrow_up:

src/storage/dense.jl
95.3% <0%> (+4.69%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5e5ab...efa2853. Read the comment docs.


Question about jsonify command

I downloaded my tweets.csv today and used ebooks jsonify to convert it to json for easier archive-ing in the future. I noticed that the resulting .json file has only the "text" and "id" fields for each tweet, whereas the tweets downloaded with ebooks archive contain signifiantly more metadata.
I take it from this that all archive really needs is the "id" field to keep from downloading duplicate tweets and adding them to the corpus file, is that correct?

Yes, archive uses the last appearing id in the json file for the query it makes to Twitter to fetch newer tweets.
https://github.com/mispy/twitter_ebooks/blob/0733453a6f1d2c3c32bdf9529c216ccdae5a71cf/lib/twitter_ebooks/archive.rb#L91
Also see since_id here https://dev.twitter.com/rest/reference/get/search/tweets


Add details on High Availability Recommendations for NPS extension.

It would be great to see additional details on High Availability for NPS extension. Since, it is getting popular , many customers has this question in mind before they take it to production. Options like using Load Balancer over NPS server or any other recommendations with traffic flow will be helpful.
As per the article :
The NPS extension automatically handles redundancy, so you don't need a special configuration. You can create as many Azure MFA-enabled NPS servers as you need. If you do install multiple servers, you should use a difference client certificate for each one of them. Creating a cert for each server means that you can update each cert individually, and not worry about downtime across all your servers. VPN servers route authentication requests, so they need to be aware of the new Azure MFA-enabled NPS server. '
However, in this case, We need to configure new RADIUS server address with VPN along with secret in order to keep it working when other NPS extension server is down ( Manual Process) . What is the recommendation for automatic fail-over ? Should we use  LB or other machinism like Traffic Manager etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a61a7e9a-44bf-7bdc-f810-87e2fd6792e1
Version Independent ID: 71d11105-b83e-952e-d107-1ff9a7c8d107
Content: Use existing NPS servers to provide Azure MFA capabilities
Content Source: articles/active-directory/authentication/howto-mfa-nps-extension.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@anujrana Please open a new MSDN thread with your specific scenerio and community will help address your query. Please refer to below link to MSDN forum to ask new question -
https://social.msdn.microsoft.com/Forums/azure/en-US/newthread?category=windowsazureplatform&forum=WindowsAzureAD&prof=required
Please post the MDSN thread URL here and I will make sure your that your query is addressed in forum.

@anujrana As suggested above please share the new MSDN thread created.

@anujrana We will move ahead and close this thread for now.

@MohitGargMSFT - I see that this was asked to https://social.msdn.microsoft.com/Forums/en-US/ea9a9924-3840-4627-98fb-665ef6903a97/high-availability-for-nps-extension-servers?forum=windowsazureactiveauthentication .  It was not yet sufficiently answered - though I just posted a clarifying response there as well.

@ziesemer Sure, I will check on it in forum and see if I could help on it. Thanks.


[BUG] Does not work when libvirt's split daemon mode is enabled

General information

OS: Linux
Hypervisor: KVM
Did you run crc setup before starting it? Yes

CRC version
$ crc version
crc version: 1.7.0+fa7e558
OpenShift version: 4.3.1 (embedded in binary)
$

CRC status
N/A
CRC config
$ crc config view
$

Host Operating System
$ cat /etc/os-release
NAME=Fedora
VERSION="31 (Workstation Edition)"
ID=fedora
VERSION_ID=31
VERSION_CODENAME=""
PLATFORM_ID="platform:f31"
PRETTY_NAME="Fedora 31 (Workstation Edition)"
ANSI_COLOR="0;34"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:31"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f31/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=31
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=31
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation
$

Steps to reproduce
When split daemon mode is enabled, crc start fails:
$ crc start --log-level debug
DEBU No new version available. The latest version is 1.7.0
INFO Checking if oc binary is cached
DEBU oc binary already cached
INFO Checking if podman remote binary is cached
DEBU podman remote binary already cached
INFO Checking if running as non-root
INFO Checking if Virtualization is enabled
DEBU Checking if the vmx/svm flags are present in /proc/cpuinfo
DEBU CPU virtualization flags are good
INFO Checking if KVM is enabled
DEBU Checking if /dev/kvm exists
DEBU /dev/kvm was found
INFO Checking if libvirt is installed
DEBU Checking if 'virsh' is available
DEBU 'virsh' was found in /usr/bin/virsh
INFO Checking if user is part of libvirt group
DEBU Checking if current user is part of the libvirt group
DEBU Running '/usr/bin/groups abologna'
DEBU Current user is already in the libvirt group
INFO Checking if libvirt is enabled
DEBU Checking if libvirtd.service is enabled
DEBU Running '/usr/bin/systemctl is-enabled libvirtd'
DEBU Command failed: exit status 1
DEBU stdout: disabled
DEBU stderr:
DEBU Error checking if libvirtd service is enabled
FATA Error checking if libvirtd service is enabled
$

On my system, while libvirtd is indeed disabled, virtqemud is enabled:
$ systemctl is-enabled libvirtd
disabled
$ systemctl is-enabled virtqemud
enabled
$

and all the usual libvirt operations work just fine:
$ virsh -c qemu:///system net-list
 Name      State    Autostart   Persistent
--------------------------------------------
 crc       active   yes         yes

$ virsh -c qemu:///system list --all
 Id   Name      State
--------------------------
 -    crc       shut off

$ virsh -c qemu:///system dumpxml crc | wc -l
75
$

Additional information on split daemon mode, including the steps necessary to enable it, can be found on the libvirt website.
Split daemon mode has been introduced in libvirt 5.7.0 and, while it's still considered experimental, it's solid enough for regular use and will eventually be the recommended way to deploy libvirt.
Expected
CRC works when split daemon mode is enabled.
Actual
CRC doesn't work when split daemon mode is enabled.
Logs
See above.

Currently not supported.
For some background: https://www.berrange.com/posts/2020/02/04/libvirt-split-of-the-monolithic-libvirtd-daemon/
@zeenix could you have a look at what might need changes on our end? Just collect info here as a spike. No need to implement yet.

@gbraad sure thing.

Some advice from IRC
17:51 < danpb> abologna: if  libvirtd.socket or virtqemud.socket units exist, then they can skip any logic for manually starting services
17:51 < danpb> abologna: if neither of those units exist, then it is safe to assume split daemons don't exist, and so starting libvirtd is safe

Right, I was just about to comment this additional information: if either libvirtd.socket or virtqemud.socket are present, they should be considered equivalent to the corresponding .service for the purpose of CRC's checks: it's a perfectly valid configuration, for example, to leave libvirtd.service as disabled and libvirtd.socket as enabled and rely on socket activation.

As suggested by @cfergeau elsewhere, running
$ crc config set skip-check-libvirt-enabled true
$ crc config set skip-check-libvirt-running true

is an effective workaround for the time being.

This is at the moment not generally available, but what is the expectance of rolling this out in for instance Fedora?

This is at the moment not generally available, but what is the expectance of rolling this out in for instance Fedora?

The libvirt packages in Fedora 32 will contain all the necessary bits for split daemon mode to work; it will, however, be an opt-in configuration rather than the default one.

@cfergeau As far as I can tell, CRC will still not work out of the box when split daemon mode is enabled, right? If so, the issue should remain open.

This was fixed by https://github.com/code-ready/crc/pull/1302 which should be in the latest release. I expected this to be closed automatically when PR #1302 got merged.

https://github.com/code-ready/crc/blob/master/pkg/crc/preflight/preflight_checks_linux.go#L187-L194 should do the trick for checking for split libvirtd setups

This was fixed by #1302 which should be in the latest release. I expected this to be closed automatically when PR #1302 got merged.

I just tried CRC 1.13.0 and indeed it worked with split daemon mode without further tweaking! Thanks a lot for taking care of this :)


validate.showErrors.errorList elements miss optional method property in documentation

Subject of the issue
https://jqueryvalidation.org/validate/ does not document method property for showErrors handler errorList parameter elements.
Your environment

version of jquery-validate : 1.15.1

Expected behaviour
method property documented with notes on when it exists and when not
or
property removed

@MaceWindu I am not sure what you mean. the docs [1] describe the showErrors  function with both, errorMap and errorList parameters below.
[1] https://jqueryvalidation.org/validate/#showerrors
I will close this for now, feel free to discuss further or clarify in case I missed something.

I'm talking about errorList parameter. It's documented as a list of  {message, element} objects, but in reality it contains {message, element, method} and {message, element } objects

Right.. There is one spot were we have one assitional property https://github.com/jzaefferer/jquery-validation/blob/master/src/core.js#L840


Grant the subscription-admin user admin access to the test namespace

The BVT tests started failing recently with the error
"error when retrieving current configuration of..." in the Policy
Generator test. This is due to the user not having read access in
the namespace that the subscription is getting created in.
It's unclear why this is failing now because the created
subscription-admin user has the
open-cluster-management:subscription-admin role, which grants this
access.
This test now no longer relies on the subscription-admin role providing
this access.
See the failing job:
https://app.travis-ci.com/github/stolostron/canary/builds/247478348
Resolves:
https://github.com/stolostron/backlog/issues/20350
Signed-off-by: mprahl<EMAIL_ADDRESS>

I'm working on releaing the Policy Generator to fix the unrelated CI failure:
https://github.com/stolostron/backlog/issues/20384

https://github.com/stolostron/governance-policy-framework/pull/278 needs to be merged first

I just rebased this PR based on #278. This should now pass.

/retest

/retest


All links are broken.

I can't find a commit ruining it. What did OP do?

Yes, please fix.

closed by f13ca3cdff2ae6f47a4a0f6d4749b2ca3597f0c8

Yes, please fix.
https://sites.google.com/site/jsonformatteronline/


Print the ENTIRE flow

I have looked at the previous solutions for saving the entire flow but i can't find a solution that will print every item, even if it is out of sight. The image itself looks like it might be the correct size, but it isn't complete. I have attached an image as an example. Any ideas would be much appreciated?

Try:
https://github.com/bubkoo/html-to-image
react flow uses this library to output the image.
On their demo page you can see how they have to calculate the position and zoom before downloading the image. You would have to replicate the example but in drawflow.
View example:
https://reactflow.dev/docs/examples/misc/download-image/

Thanks, i'll look in to it.


Print page dont print footers.

Summary of problem or feature request
The print button dont print the footers in the table.
Code snippet of problem

            @php ($flag = true)
            @foreach($data as $row)
                @if ($row == reset($data) && $flag)

                        @foreach($row as $key => $value)
                            {!! $key !!}
                        @endforeach
                        @php ($flag = false)

                @endif

                    @foreach($row as $key => $value)
                        @if(is_string($value) || is_numeric($value))
                            {!! $value !!}
                        @else

                        @endif
                    @endforeach

            @endforeach

Thats the generated table, without  tag and without footer data.
System details

Operating System Windows 10 64bits (xampp)
PHP Version 5.6
Laravel Version "5.3.*",
Laravel-Datatables Version  "~6.0"

@d-arken good catch. Tagging for enhancement. If you can, please do not hesitate to submit a PR. Thanks!


Issue in rgb_to_hex.cc

Line 12 should read 'std::stringstream ss;'.
Medium priority (simple fix that does not damage comprehension)

fixed


How to load OntoNotes?

Hi
I'm probably at the wrong place to ask this question because this is not about Presidio but how do I conveniently load OntoNotes?
In one of the notebook, there is a code block like this
## Download OntoNotes data
ontonotes = ""

I have downloaded OntoNotes and there are a lot of files. I haven't found an easy way to load OntoNotes in the format that can be used by the rest of the notebook yet so if anyone can shed some light, that would be awesome
Thanks in advance
Alex

;) Found a way to do it so closing.


Move no_trailing_whitespace_in_comment to @PSR-2

I would move this fixer to PSR-2 leve, due to PSR rule:

Remove trailing whitespace at the end of non-blank lines.

Comments are not-blank lines, so the fixer follows PSR2

Seems legit. :+1:

:+1:


C_0805.kicad_mod double courtyard

this leads to DRC errors

Not sure how that got in there, fixed by https://github.com/CDFER/JLCPCB-Kicad-Library/commit/285825b7fc855d3da76826b9ce4c2d848f2ad78c
Thx :)


Error in MarketAnalysis

Getting this error repeatedly, unsure how to fix?

Error in MarketAnalysis: list index out of range
WARN: Exception found when analysing markets, if this happens for more than a couple minutes please make a Github issue so we can fix it. Otherwise, you can s
afely ignore it. Error: list index out of range

The list index out of range error is usually due to your market data being malformed, recently this is probably due to Poloniex lagging. Please delete the data files in the market_data/ folder and they should be remade.

Closing issue because a solution has been found.
If your error persists or you have another error that is related to this one please reopen this issue so we can find another solution. If you have any other problems please open a new issue.
Thank you for using Poloniexlendingbot.


Use variadic argument in Group::middleware(), Group::prependMiddleware() and similar methods

Group::middleware()
Group::prependMiddleware()
Route::middleware()
Route::prependMiddleware()
RouteCollector::middleware()
RouteCollector::prependMiddleware()

Currently the syntax is:
Route::get('/api/bla-bla')
  ->middleware(Authenticate::class)
  ->middleware(FormatDataResponseAsHtml::class)

I'm not sure the following will be better:
Route::get('/api/bla-bla')
  ->middleware(
    Authenticate::class,
    FormatDataResponseAsHtml::class
  )

Current syntax will remain available. Variadic is optional.


Give memory descriptions indication of on-remember and on-forget effects

It can be confusing why some effect occur when changing memories.

Duplicate of #174

This is what happens when your brain is breaking while learning Javassist


simplify CI cache

This uses a new GitHub action https://github.com/marketplace/actions/cache-julia-artifacts-packages-and-registry made specifically for this purpose, see also https://discourse.julialang.org/t/recommendation-cache-julia-artifacts-in-ci-services/35484/8

Thanks for updating this! If it works, should we also use it in other repos in the Trixi Framework for simplicity/consistency?

Yes, I will do that. I just wanted to get your feedback first before.


Add workload tab to cluster namespace

#5115
Added tab to cluster namespace detail view (/c/local/explorer/namespace/<NAMESPACE>#Workloads)

QA

Create any Workload type (/c/local/explorer/workload/create)
Navigate back to the namespace detail view
Verify types of workloads to match namespace and other not mentioned requirements

Notes

Added WORKLOAD_SCHEMA to the related schema config file

Got this after rebase :grimacing:


Support installing additional runtimes

Closes #19
Closes #16
still WIP, but I'd like to get feedback as soon as possible before moving this forward

Just FYI, I'm still on holidays, I'll get back to this when I can

@Tyrrrz no worries :)
Happy holidays!

I gave it some more thought and I'm still against the idea of installing unrelated .NET runtimes in the bootstrapper.
The driving ideology for this project has pretty much been this:

Seamlessly replace the default application host
Require no additional setup or configuration from the dev (on top of default apphost configuration properties like icon and manifest file)
Install only the bare minimum necessities required to run the app

I think to handle the webview2 scenario, we can just scan the deps.json file to find a reference to the standard webview package along with its version. I know I previously said that it would be nice to have all those things in once place, i.e. runtimeconfig.json, but that doesn't seem all that beneficial given that the deps file is already there anyway. The best part about this approach is that the user doesn't need to configure anything as the bootstrapper will know about the additional dependencies automatically. This of course assumes we can infer the version of the runtime based on the version of the package.
Additionally, I really want to avoid turning the bootstrapper into an installer. Even with the bootstrapper, you would still often use an installer for your app to perform other system setup, like changing registry or installing 3rd party dependencies (e.g. ffmpeg in a video playing application). Bootstrapper is only meant to guarantee that the app will be capable to run, only as far as the runtime is concerned. If we start adding customization options like this, it may create a slippery slope that would make it hard to draw the line of what's the actual scope of the project.
In regards to @Misiu's case, I believe the issue can be fixed by simply providing a console bootstrapper for ASP.NET apps that can install the runtime seamlessly without user interaction. We should definitely pursue that as already discussed in #17.
On the WebView2 front, I think we should scan deps.json file and conditionally add it to the list of prerequisites. We can handle similar runtimes/dependencies in this fashion, so long as they're automatically detectable by the MSBuild task.

@Tyrrrz generally I also agree with your opinion, but my use case is specific I guess. I have a console app that is installed as a windows service by my second app (control panel).
Control Panel app is run with admin permission so it can set up the registry, install all required runtimes (via bootstrapper), but the windows service runs on network service account permissions, so I think it won't be able to install the dependencies.
For now, I'm using my fork and it works fine, but I thought more people would benefit from this feature.
#17 will solve that problem partially, but not in my case, but again, this might be only my case.
I can also reuse the download and install logic from your package in my Control Panel app, but it was easier for me to just add small changes to your package.
You can close this any time, thanks for your time and feedback :)

Yeah, that makes sense, I didn't think about admin permissions.
One thing I do think that can be changed though is that the bootstrapper should handle multiple frameworks in runtimeconfig.json correctly. Right now it assumes there's only going to be one or two (i.e. just base or base+desktop/aspnet), but the more flexible way to handle this would be to not assume anything and parse all of them. This would be useful to have primarily for the fact that the frameworks field in runtimeconfig.json is already an array (on net5+), so treating it without any assumptions would be generally safer.
Here's an example runtimeconfig.json:
{
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "6.0.0"
      },
      {
        "name": "Microsoft.WindowsDesktop.App",
        "version": "6.0.0"
      }
    ]
  }
}

Assuming this was properly supported (i.e. all items in frameworks were parsed, not just the first non-base framework), then if you could somehow get ASP.NET runtime in there (maybe through runtimeconfig.template.json file or even just a PowerShell script that updates that file), it would probably cover your case. I just don't want to add custom MSBuild properties/tasks for this on the bootstrapper side.

Yeah, that makes sense, I didn't think about admin permissions.
One thing I do think that can be changed though is that the bootstrapper should handle multiple frameworks in runtimeconfig.json correctly. Right now it assumes there's only going to be one or two (i.e. just base or base+desktop/aspnet), but the more flexible way to handle this would be to not assume anything and parse all of them. This would be useful to have primarily for the fact that the frameworks field in runtimeconfig.json is already an array (on net5+), so treating it without any assumptions would be generally safer.
Here's an example runtimeconfig.json:
{
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "6.0.0"
      },
      {
        "name": "Microsoft.WindowsDesktop.App",
        "version": "6.0.0"
      }
    ]
  }
}

Assuming this was properly supported (i.e. all items in frameworks were parsed, not just the first non-base framework), then if you could somehow get ASP.NET runtime in there (maybe through runtimeconfig.template.json file or even just a PowerShell script that updates that file), it would probably cover your case. I just don't want to add custom MSBuild properties/tasks for this on the bootstrapper side.

Also technically WindowsDesktop apps can reference the aspnetcore framework just for their usage of DependencyInjection (however currently there is a bug in their default apphost on that one, but idk if that bug can be reproduced on this one as well).
Also there is also the fact that there are other frameworks as well, say for instance one uses dotnet/arcade to make an installer to install stuff that then "acts" like an workload (so the .NET SDK imports it and everything), but instead it's more than just that.

@Misiu do you have any thoughts on my previous comment?

@Misiu do you have any thoughts on my previous comment?

I've added MSBuild tasks because it was the easiest for me. I can try to add support for reading all items in frameworks and remove the MSBuild tasks.
What about WebView2? It isn't added to deps.json only:
{
  "runtimeTarget": {
    "name": ".NETCoreApp,Version=v6.0",
    "signature": ""
  },
  "compilationOptions": {},
  "targets": {
    ".NETCoreApp,Version=v6.0": {
      "DotnetRuntimeBootstrapper.Demo/1.2.3": {
        "dependencies": {
          "DotnetRuntimeBootstrapper": "2.0.3",
          "Microsoft.Web.WebView2": "1.0.1072.54"
        },
        "runtime": {
          "DotnetRuntimeBootstrapper.Demo.dll": {}
        }
      },
      "Microsoft.Web.WebView2/1.0.1072.54": {
        "runtime": {
          "lib/netcoreapp3.0/Microsoft.Web.WebView2.Core.dll": {
            "assemblyVersion": "1.0.1072.54",
            "fileVersion": "1.0.1072.54"
          },
          "lib/netcoreapp3.0/Microsoft.Web.WebView2.WinForms.dll": {
            "assemblyVersion": "1.0.1072.54",
            "fileVersion": "1.0.1072.54"
          },
          "lib/netcoreapp3.0/Microsoft.Web.WebView2.Wpf.dll": {
            "assemblyVersion": "1.0.1072.54",
            "fileVersion": "1.0.1072.54"
          }
        },
        "runtimeTargets": {
          "runtimes/win-arm64/native/WebView2Loader.dll": {
            "rid": "win-arm64",
            "assetType": "native",
            "fileVersion": "1.0.1072.54"
          },
          "runtimes/win-x64/native/WebView2Loader.dll": {
            "rid": "win-x64",
            "assetType": "native",
            "fileVersion": "1.0.1072.54"
          },
          "runtimes/win-x86/native/WebView2Loader.dll": {
            "rid": "win-x86",
            "assetType": "native",
            "fileVersion": "1.0.1072.54"
          }
        }
      },
      "System.Runtime.CompilerServices.Unsafe/6.0.0": {},
      "System.Text.Encodings.Web/6.0.0": {
        "dependencies": {
          "System.Runtime.CompilerServices.Unsafe": "6.0.0"
        }
      },
      "System.Text.Json/6.0.1": {
        "dependencies": {
          "System.Runtime.CompilerServices.Unsafe": "6.0.0",
          "System.Text.Encodings.Web": "6.0.0"
        },
        "runtime": {
          "lib/net6.0/System.Text.Json.dll": {
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>705"
          }
        }
      },
      "DotnetRuntimeBootstrapper/2.0.3": {
        "dependencies": {
          "System.Text.Json": "6.0.1"
        },
        "runtime": {
          "DotnetRuntimeBootstrapper.dll": {}
        }
      },
      "Microsoft.Build.Utilities.Core/<IP_ADDRESS>": {
        "runtime": {
          "Microsoft.Build.Utilities.Core.dll": {
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>601"
          }
        }
      },
      "Microsoft.Build.Framework/<IP_ADDRESS>": {
        "runtime": {
          "Microsoft.Build.Framework.dll": {
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>601"
          }
        }
      },
      "Microsoft.NET.StringTools/<IP_ADDRESS>": {
        "runtime": {
          "Microsoft.NET.StringTools.dll": {
            "assemblyVersion": "<IP_ADDRESS>",
            "fileVersion": "<IP_ADDRESS>302"
          }
        }
      }
    }
  },
  "libraries": {
    "DotnetRuntimeBootstrapper.Demo/1.2.3": {
      "type": "project",
      "serviceable": false,
      "sha512": ""
    },
    "Microsoft.Web.WebView2/1.0.1072.54": {
      "type": "package",
      "serviceable": true,
      "sha512": "sha512-XCCFDnlW5EvqcwrYKd1ZzrBjkbPoljQPYzCLbpzo21cfVIOkPZ5FdkEfcgvXQXxgtyN1SOl3oqrYh9zJ4NgyOg==",
      "path": "microsoft.web.webview2/1.0.1072.54",
      "hashPath": "microsoft.web.webview<IP_ADDRESS>2.54.nupkg.sha512"
    },
    "System.Runtime.CompilerServices.Unsafe/6.0.0": {
      "type": "package",
      "serviceable": true,
      "sha512": "sha512-/iUeP3tq1S0XdNNoMz5C9twLSrM/TH+qElHkXWaPvuNOt+99G75NrV0OS2EqHx5wMN7popYjpc8oTjC1y16DLg==",
      "path": "system.runtime.compilerservices.unsafe/6.0.0",
      "hashPath": "system.runtime.compilerservices.unsafe.6.0.0.nupkg.sha512"
    },
    "System.Text.Encodings.Web/6.0.0": {
      "type": "package",
      "serviceable": true,
      "sha512": "sha512-Vg8eB5Tawm1IFqj4TVK1czJX89rhFxJo9ELqc/Eiq0eXy13RK00eubyU6TJE6y+GQXjyV5gSfiewDUZjQgSE0w==",
      "path": "system.text.encodings.web/6.0.0",
      "hashPath": "system.text.encodings.web.6.0.0.nupkg.sha512"
    },
    "System.Text.Json/6.0.1": {
      "type": "package",
      "serviceable": true,
      "sha512": "sha512-X3cTdM+jna1YyfTUzToW7aVgINFv7R1W4+1+3hua/YCyLjApPoR8fd+2Cep9DbfYjbv+rBx4K6dlmAWEJr9AHg==",
      "path": "system.text.json/6.0.1",
      "hashPath": "system.text.json.6.0.1.nupkg.sha512"
    },
    "DotnetRuntimeBootstrapper/2.0.3": {
      "type": "project",
      "serviceable": false,
      "sha512": ""
    },
    "Microsoft.Build.Utilities.Core/<IP_ADDRESS>": {
      "type": "reference",
      "serviceable": false,
      "sha512": ""
    },
    "Microsoft.Build.Framework/<IP_ADDRESS>": {
      "type": "reference",
      "serviceable": false,
      "sha512": ""
    },
    "Microsoft.NET.StringTools/<IP_ADDRESS>": {
      "type": "reference",
      "serviceable": false,
      "sha512": ""
    }
  }
}

@AraHaan what about other runtimes you mentioned? How does the deps.json file look like?

I've taken a quick look at runtimeconfig.template.json. Sadly the file isn't merged correctly.
original runtimeconfig.json:
{
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "6.0.0"
      },
      {
        "name": "Microsoft.WindowsDesktop.App",
        "version": "6.0.0"
      }
    ]
  }
}

template:
{
  "frameworks": [
    {
      "name": "Microsoft.NETCore.App",
      "version": "7.0.0"
    },
    {
      "name": "Microsoft.WindowsDesktop.App",
      "version": "8.0.0"
    }
  ]
}

output:
  "runtimeOptions": {
    "tfm": "net6.0",
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "6.0.0"
      },
      {
        "name": "Microsoft.WindowsDesktop.App",
        "version": "6.0.0"
      }
    ],
    "frameworks": [
      {
        "name": "Microsoft.NETCore.App",
        "version": "7.0.0"
      },
      {
        "name": "Microsoft.WindowsDesktop.App",
        "version": "8.0.0"
      }
    ]
  }
}

Not sure if this is a bug or this is by design.

@Tyrrrz actually in .net core 3.1 you can have runtimes (array) if you add extra framework reference.

@Tyrrrz actually in .net core 3.1 you can have runtimes (array) if you add extra framework reference.

Good to know! In any case, we handle both situations.

so a partial success 🙂

So that looks like it would handle your case if we were reading all framework entries, right?

What about WebView2?

WebView would be dealt with completely separately, by reading the deps.json file. We would need to figure out how the package versions match to WebView's runtime versions however. In any case, I think it should be considered separately.

Also on the default apphost I noticed a bug in .NET 6 where the program refuses to run as it would think the 6.0.1 desktop runtime is not installed, but when you unreference it, it will load up like normal.

Closing in favor of #22.

@Tyrrrz actually my code should be ok with #22.


Fixed integer division error for Python2 in Yahoo returns calculation.

Coverage remained the same at 63.95% when pulling 8ffc2f8a73eeb009e54a7612ba480345b31b1fc3 on price_handler_returns into e0a9234b87dde51e9405fd43345b4ae4dccf385c on master.


Beta builds on npm

Would it be possible for you to push the 9.3.beta.X builds to npm?  You've got some good changes in 9.3 and I'd like to have them through npm if possible.

Yeah I will try to do it in the next days

Hi
9.3 final is out and it on npm, regarding the beta on npm, I know that I can use npm publish --tag beta but how can I apply that to the js file that sits in src folder only?


Be able to use this project as an adapter/converter: openai api to claude api

Convert openai api requests to claude api request/response then return claude api's response as a openai api response.
Describe the solution you'd like
A converter between openai api (very popular) to claude api then back again ... an adapter or converter.
Additional context
To be used as a "middle-man" to injest open api calls, convert to claude api, then convert back to openai api response.
Thanks ... i can not find a open-source project that does the above (OpenRouter is similar).

Wrote my own code to do this, thanks.


Accept all formats for kiosk link

Full URL
Short link starting with _
Long link starting with S or 20digit credit card number.

Copy code from multiplayer.


fix dead link to the project's "homepage"

Getting to the notebook via the main page at https://nbviewer.jupyter.org/ shows the notebook with a 'homepage' link, clicking on it gives a 404 error.

Nice find, lgtm!


split readme

the main readme file should only give an overview of the features and link to files for

docker production setup (could be part of main readme if really short)
development setup
companion app
gpu acceleration

also address the problems when you create a keypair

the line that you can copy out of the documentation has no value, so maybe dont do that as a copyable line


(maint) Update changelog for 0.3.0 release

This assumes that #55 will be merged before the release date of next Tuesday the 21st of September.

I think there is definitely some extranious information in here that is not needed. If you need an example of how we usually do CHANGELOGs for the puppet modules, check out one of the other puppetlabs modules (like puppetlabs-apache for example): https://github.com/puppetlabs/puppetlabs-apache/blob/master/CHANGELOG.md

(also since these modules are owned by Puppet Labs I don't think we generally mention individual contributors in the CHANGELOGs)

@HAIL9000 I pared it down a bit. Let me know what you think.


Improve clarity of "no start command" error message

Currently, the error message can lead the user to believe that no
start command was specified at all (via -c or the command: key in
the manifest). This clarifies that the buildpack and Procfile did not
provide start commands.

https://www.pivotaltracker.com/story/show/128507135

Thanks, @RochesterinNYC ! Sounds like a reasonable clarification to me. Prioritizing for the Diego team to evaluate.
Best,
Eric

Looks good. Thanks @RochesterinNYC!


Party view, Assets field, "show all" intermittent error

https://explorer.vega.xyz/parties/e5ef473646b2ee6763bdaf36c6224ff3d248a4ce97f395f371568714fc759f9d

Press "Show all" and get

but only sometimes.

The "try refreshing" will give me the right view.


Fixed autoupdate error after deleting a slide (Fixed #3066).

@normanjaeckel still open reference_projector

Travis failed. Rest is ok.

Travis fixed.


Add utility method to return all data assets that match a query

User story
As a user, I want to call a single method to return all data assets matching a query, so I don't have to call a method multiple times.
Acceptance criteria

[ ] There should be a method that makes multiple requests (if necessary) to the code ocean backend to retrieve all data assets using the search data asset api.

Sprint Ready Checklist

[x] 1. Acceptance criteria defined
[x] 2. Team understands acceptance criteria
[x] 3. Team has defined solution / steps to satisfy acceptance criteria
[x] 4. Acceptance criteria is verifiable / testable
[x] 5. External / 3rd Party dependencies identified
[x] 6. Ticket is prioritized and sized

Notes
Should wait until #10 is finished first to make this easier

Add data into a temporary list and append the data to it
Return the list as a response


Update FZI maintainers

Right before releasing I'd like to update the list of maintainers to the people who will be maintaining this. @AndyZe @livanov93 @destogl I've kept you listed as maintainers, as I was not sure about your plan of future involvements into this package. I'm happy to leave it like this, though :-)

My plan is to be involved into future developments. The repository currently depends on ros-controls/ros2_control and ros-controls/ros2_controllers where I am also contributing, therefore I think it will be beneficial to leave @destogl and me listed.


Test built image at each push

this pr remain as register of our good will to make code work, it may now rest in peace. #34 will do its purpose


Update build.gradle

Signed-off-by: Kiran Prakash<EMAIL_ADDRESS>Is your feature request related to a problem? Please provide an existing Issue # , or describe.
netty had a CVE-2022-24823 that was patched in 4.1.77.Final
PA RCA uses netty via grpc which updated the netty to 4.1.77.Final in 1.49.0
Describe the solution you are proposing
Update grpc version from 1.44.0 to 1.49.0
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #226 (9f59d03) into main (60ee527) will increase coverage by 0.04%.
The diff coverage is n/a.

:exclamation: Current head 9f59d03 differs from pull request most recent head e35218e. Consider uploading reports for the commit e35218e to get more accurate results

@@             Coverage Diff              @@
##               main     #226      +/-   ##
============================================
+ Coverage     71.53%   71.58%   +0.04%
- Complexity     2987     2990       +3
============================================
  Files           380      380
  Lines         18952    18952
  Branches       1463     1463
============================================
+ Hits          13558    13567       +9
+ Misses         4798     4792       -6
+ Partials        596      593       -3

Impacted Files
Coverage Δ

...nsearch/performanceanalyzer/rca/RcaController.java
81.05% <0.00%> (+0.44%)
:arrow_up:

...ceanalyzer/rca/store/rca/hotshard/HotShardRca.java
87.12% <0.00%> (+0.99%)
:arrow_up:

...nalyzer/rca/net/handler/PublishRequestHandler.java
87.75% <0.00%> (+14.28%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


PoC with OCM using the hub and workagent and MGC to manage gateways

What
Based on the proposal in #158 we want to build out support for managing multi-cluster gateways

This issue is stale because it has been open for 30 days with no activity.


Update npm dependencies

Pull request #11 was failing the check-dist workflow.  Updated all of the npm packages to resolve the problem.

Superseded by #23


feat: add new responsive webdesign to certified user

Checklist:

[ ] I have read and followed the contribution guidelines.
[ ] I have read and followed the how to open a pull request guide.
[ ] My pull request targets the main branch of freeCodeCamp.
[ ] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

This just updates the seed file with responsive web design challenges.
@Sembauke is there a reason for the pnpm-lock.yaml update?

@ahmaxed I am not sure. @naomi-lgbt is there any issue merging the lock file with it?

Not sure. We could drop the lock here and move forward with the pr.

is there any issue merging the lock file with it?

It creates extra noise. What pnpm version are you using?

For more context, the lockfile version was bumped to 6.1 in pnpm 8.6.0, but was bumped back down to 6.0 in 8.6.2 due to older pnpm versions being unable to parse 6.1
As such, we should not merge this with the lock file for two reasons:

Our engines field specifies pnpm: 8, which means contributors could be using versions earlier than 8.6.X, and we would not want the lockfile version to be 6.1
Anyone using pnpm later than 8.6.2 would revert the lockfile to 6.0.

Hey @ahmaxed,
The lock file is no longer here.

Does it matter that all the challenges were completed within a millisecond of each other?  @ahmaxed, does this meet your requirements?

I see your point Oliver. We have a few features that depend on timestamps, streak, heat-map, etc.
There is not test coverage for some of these features yet, so merging this pr will not cause any issues.
I will double check with our most active user ever to see if we can reuse his user object. If that is confirmed, I will revert this in favor of an object with a natural progression.
Down the line, I will remove 1-2 challenges from a block so I could test the donation modal popping, etc.

@Sembauke 🫡 LGMT


I'm getting this error. I use Php 7.2

message": "count(): Parameter must be an array or an object that implements Countable",
"exception": "ErrorException",
"file": "/home/forge/pornhub.com/vendor/flugger/laravel-responder/src/Transformers/Concerns/MakesResources.php",

Hi! What data are you passing to the responder? At the moment you can only pass in arrays or objects (collections) as data. However, Fractal recently got support for primitive resources allowing all kinds of data. This should be supported by new year

@flugger I fixed it 👍  I returned an array in a transformer and include it to an another transformer(The error occurred here), than I just made an hasMany relationship. Since It worked in php 7.18 I was wondering why it didn't failed, than I saw that they changed the behavior of the count function in php 7.2. Thank you for the answer


No contributors listed on Contributors page

Describe the bug
No contributors are listed on the contributors page.
To Reproduce
Steps to reproduce the behavior:

Go to "Website".
Go to 'Contributors Page.'

Expected behavior
Contributors are supposed to show?
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome

Thanks for raising this issue!
@KendallDoesCoding, Do you want to work on this?

Thanks for raising this issue!
@KendallDoesCoding, Do you want to work on this?

I'm not too good at Typescript, so no sorry.

@KendallDoesCoding
No worries, I'll look forward to solving this issue


Enable super-admins to edit user profiles

Make the entry in the name column in the 'users' table a link to their profile page so super-admins can change org affiliation before granting admin permissions. Currently it is not possible to change their org affiliation to the correct one (e.g. to a new org that has been added to enable admin use). A separate ticket is addressing the ability to view the org #1248

Many DMPonline admins come from overseas unis that aren't currently listed in the tool so we need to add them as an org and affiliate the user to this before assigning admin permissions. The 'edit privileges' column now just pops up a modal with admin permission settings rather than opening their user profile where affiliation can also be set. Please make the name a link where we can access their full profile and change the org affiliation before granting permissions. Adding the 'org' column in the user table is also very helpful so we can ensure they have the correct affiliation before granting rights. This will be addressed under the related ticket.

Are there other pieces of information or tasks a super admin should be able to perform for users on this page?

[x] Change org affiliation
[x] Change privileges?
[ ] Change email address /name?
[ ] Unlink institutional credentials?
[ ] Change email notification prefs?
[ ] Change/Reset password?
[ ] Disable/Deactivate account (requires new field on table - Devise may offer something for this)

@briri - the only other thing i might want to be able to do is disable/deactivate an account. i'm mainly thinking about bouncing emails, but this isn't a high priority so not something we need to solve now. for dmptool users we want to place the onus of managing accounts on the users themselves so i prefer not to be able to do all the things. but i'll let @sjDCC confirm if there's anything else she needs to be able to do as super admin.

Tasks needed:

[x] Add active flag to users table
[x] Update scopes in Users model to look at new flag
[x] Override Devise authentication method in User model to prevent deactivated users from logging in
[x] Add checkbox column to Admin -> Users page to allow admins to activate/deactivate users
[x] Make user name column a clickable link for Super Admins so that they can edit the user's profile
[ ] Update profile page to allow super admins access to other users' profiles
[ ] Update mailer to skip users who are inactive
[ ] Add unit tests for new active flag, and functional tests for controller methods

super admins can now edit user profile info and activate/deactivate accounts. closing but leaving here for @sjDCC to confirm all looks good.

make sure you're testing as a super admin @sjDCC


Pagination is broken with "invalid memory or nil pointer dereference" in 0.123.0-DEV

I get error like this:
ERROR render of "page" failed: execute of template failed: template: _internal/pagination.html:21:17: executing "_internal/pagination.html" at <$page.Paginator.TotalPages>: error calling TotalPages: runtime error: invalid memory address or nil pointer dereference

And somewhat related issue is error like this:
executing "main" at <$paginate.Pages>: error calling Pages: runtime error: invalid memory address or nil pointer dereference

in code like this:
{{ $paginate := .Paginate $sliceOfPages 10 }}
{{ range $index, $page := $paginate.Pages }}
    {{ $page.Render "list_item" }}
{{ end }}

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.123.0-DEV+extended linux/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
No, the latest stable release works well

Thanks for this, much appreciated.
I don't think "pagination is broken" is a generally valid statement (we have lots of tests). Do you have an example site that shows this problem?

@TiGR In which template does your code appear?

In general, the idea is that we have structure like /content/places/*/events/*/ and we're building a list of all places, but sorted by most recent event, and having each place only once. In order to achieve this we go through all events pages, sort them by some field. Then, as a final step we create a slice and then append all places pages in the order we need:
{{ $places := slice }}
{{ range $events }}
  {{/* in this example .place is an item of (site.GetPage "places").Pages list, that is a Page */}}
  {{ $places = $places | append .place }}
{{ end }}

And then we do the code I've mentioned above:

  {{ $paginate := .Paginate $places 10 }}
  {{ range $index, $page := $paginate.Pages }}
    {{ $page.Render "list_item" }}
  {{ end }}

  {{- template "_internal/pagination.html" . -}}

With that code I get errors

Or, more specifically, is the pagination code called from a list page (home, section, taxonomy, or term), or from a single page?

It's a section page. But it's a tricky one, it's an empty sub-section with no pages inside (like content/news/events/_index.md), since we need to have it in a specific place of our website.

Please rebuild hugo from HEAD at 6c3b6ba and test again to see if the error message changes.

Well. That's weird. The message has indeed changed. Now I get:
ERROR Rebuild failed: render: failed to render pages: render of "page" failed: "...:25:33": execute of template failed at <.Paginate>: error calling Paginate: pagination not supported for pages of kind "page"

But the problem is, the page we're talking about is supposed to be a section according to the documentation, and everything worked fine on previous versions. I have the following structure:
content/
├── news/
│   ├── events/
│   │   └── _index.md
│   └── _index.md
└── _index.md

And the only place were I have this template rendered is in content/news/events/_index.md. Which is supposed to be a section, but the hugo complains it is not.
Also, moving events directory to content top level fixes the issue, but I need it where it is now and I can't get it why it is not considered a section.

Also, it might be important, we have a bunch of _index.xx.html translation files in content/news/events directory.

@TiGR the devil is in the detail here, I guess, which is not possible for me to determine without seeing the full source.
But one of the improvements in this next version is a simplified logic in this area, to prepare for other content sources than files. So, the logic around handling of duplicates may have changed.
So, if you have something ala:
content/
├── news/
│   ├── events/
│   │   └── _index.md
│   │   └── index.md
│   └── _index.md
└── _index.md

Then that may explain it, but again, it's hard for me to guess without seeing the source.
That said, I appreciate your bug reports about this. I'm confident that we needed to make these changes, but I also understood that it could create some breakage in the wild.

Can you try this with my latest commit in 1891d5e6b5575e3abb7e0f80c3fbce1670f9bd5e

Well, that seems to be definately related with #11958, as I get the following:
ERROR render of "page" failed: "…/layouts/news/events.html:25:33": execute of template failed: template: news/events.html:25:33: executing "main" at <.Paginate>: error calling Paginate: pagination not supported for this page: kind: "page", path: "/news/events/_index.fi", file: "…/content/news/events/_index.fi.html"
ERROR render of "page" failed: "…/layouts/news/events.html:25:33": execute of template failed: template: news/events.html:25:33: executing "main" at <.Paginate>: error calling Paginate: pagination not supported for this page: kind: "page", path: "/news/events/_index.de", file: "…/content/news/events/_index.de.html"
ERROR render of "page" failed: "…/layouts/news/events.html:25:33": execute of template failed: template: news/events.html:25:33: executing "main" at <.Paginate>: error calling Paginate: pagination not supported for this page: kind: "page", path: "/news/events/_index.es", file: "…/content/news/events/_index.es.html"
ERROR render of "page" failed: "…/layouts/news/events.html:25:33": execute of template failed: template: news/events.html:25:33: executing "main" at <.Paginate>: error calling Paginate: pagination not supported for this page: kind: "page", path: "/news/events/_index.it", file: "…/content/news/events/_index.it.html"
Built in 71556 ms
Error: error building site: render: failed to render pages: render of "page" failed: "…/layouts/news/events.html:25:33": execute of template failed: template: news/events.html:25:33: executing "main" at <.Paginate>: error calling Paginate: pagination not supported for this page: kind: "page", path: "/news/events/_index.fr", file: "…/content/news/events/_index.fr.html"

Let me try building the entire website (this might take some time)

Well, the entire website (without disabled languages builds well)

I'm closing this, as this certainly is "another issue".

I can reproduce the behavior if I erroneously add kind = "page" to the front matter of content/news/events/_index.md.


Update CustomForm viewset and permissions

Purpose
Some permissions have changes and the behavior of the view set.
Related issue: #884

Coverage increased (+0.06%) to 55.806% when pulling 72141a6b335a97d092d808036becce3148ebdaea on jefmoura:update-customform-permissions into 4fdd034f070634616912dae0d6e7746a52794800 on toladata:dev-v2.


iOS: Remove the white shadow from the top taskbar icons

I checked the image assets and the white shadow isn't there, so iOS must be helpfully adding them.

Actually, the white shadow under the activity, mark unread, settings, etc icons are in the image assets.
I could edit them out, but if you have source images, you could do it more easily and cleanly.
Here's an example, with a red background added to highlight it:

(Personally, I don't think the shadow is too glaring even on the Dark theme, though it does stand out a bit.)

I checked the interactions button, but I checked the one in the web repo and not iOS. Looks like iOS just needs a new set of icons made. I'll get that done.


For changing the style of Social Media Icons in Contact Us Section.

What's the style idea?
We need to change the color of the Social Media Icons present in the Contact Us section.
https://github.com/CSEdgeOfficial/learn.csedge.courses/assets/126074487/1787a0aa-c8a2-4097-8818-507e6df917a8
I think that, the color combination of these Social Media Icons is not aligned with the overall website.
The color of these icons should be in either Black color or Light Indigo color as they fits with the overall website's UI.

Please review my request and assign this issue to me.

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[x] I am a GSSoC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

@vishanurag What was the idea explain more and provide the screenshots of the ouput

@vishanurag What was the idea explain more and provide the screenshots of the output

We can change the color of these Social Media Icons on Contact Us Section.

We can color these icons in Black color, since the Social Media Icons of footer Section are already in white color with black background.
So, we can do these changes to make the look of the Contact Us section good.
Also, can you please add GSSOC lebels on this issue.

@Durgesh-Vaigandla Kindly assign me this issue under gssoc'24.


Better error message on import when missing common dependencies

Implementation draft for #3740. Entering
python -c "import dask.array"

gives
Traceback (most recent call last):
  File "/Users/horta/code/dask-horta/dask/array/core.py", line 21, in <module>
    from cytoolz import (partition, concat, join, first,
ModuleNotFoundError: No module named 'cytoolz'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/horta/code/dask-horta/dask/array/__init__.py", line 11, in <module>
    raise e
  File "/Users/horta/code/dask-horta/dask/array/__init__.py", line 4, in <module>
    from ._init_impl import *
  File "/Users/horta/code/dask-horta/dask/array/_init_impl.py", line 4, in <module>
    from .core import (Array, block, concatenate, stack, from_array, store,
  File "/Users/horta/code/dask-horta/dask/array/core.py", line 26, in <module>
    from toolz import (partition, concat, join, first,
ModuleNotFoundError: No module named 'toolz'

Dask array requirements are not installed.

Please either conda or pip install dask[array]:

  conda install dask[array]          # either conda install
  pip install dask[array] --upgrade  # or pip install

here when dask[array] dependencies are not installed. I thought a large try/catch around the imports in dask/array/__init__.py would make it harder to read and I wanted to keep import dask.array lazy.
Alternatively, the corresponding dependencies could be imported in advance, in the beginning of dask/array/__init__.py, but that would make it harder to add or remove common dependencies as it would require to keep dask/array/__init__.py in sync.
The _int_impl.py solution is quite ugly, though, but I could not come up with anything better. I wonder if there is a common practice for such a case.

Thanks for doing this @horta !  I like the error message that you created.
I have a slight preference to keep everything in the __init__.py file.  Perhaps we could keep the imports in this same file and include everything in one giant try-except block?  Thoughts?
Also, do you have any interest in doing the same for the other modules?

Thanks, @mrocklin . I have implemented that suggestion for array, bag, and dataframe. distribute requirements already have its own, so it remains the delayed requirements. If I understood correctly, the only visible difference for the user when delayed requirements is not installed, is the missingness of dask.delayed function:
https://github.com/dask/dask/blob/5a4064d6c95435d132c8b7f0f2ee9aef63f3a73f/dask/__init__.py#L7-L10
Should it somehow thrown an exception if the user tries to access it?

Should it somehow thrown an exception if the user tries to access it?

I recommend that we just pass on delayed for now

@jakirkham do you see anything that could go wrong here?

I have a slight preference to keep everything in the __init__.py file.  Perhaps we could keep the imports in this same file and include everything in one giant try-except block?  Thoughts?

Can I push back against this a bit? Am just a little worried that large blocks like this make it harder to follow what is going on (even for this simple change). That's just my experience reading this diff at least. :)
Maybe we can create things like dask.array.api, which include all public facing functionality and then __init__.py is just a clean try...except... around that. Thoughts? Or are there other concerns you have in mind?

I agree that the diff is a bit hard to read, but I think that the code is easy enough.  Adding a level of indentation seems less intrusive to me than adding a level of indirection by putting things into a separate file.

Any response here @jakirkham ?  I'm still in favor of merging.

No pressure on current release, but just generally.

It seems fine. Should we do something for dask.delayed as well? Given it needs toolz too.

There were some issues with delayed.  See https://github.com/dask/dask/pull/3771#issuecomment-405719298 above.  We import it automatically on import dask.
I plan to merge this later this afternoon if there are no further comments.

Would like us to make the release first (unless there are strong objections). Am working on the changelog currently.

Fine with me.  Thanks for doing the release @jakirkham
On Mon, Jul 23, 2018 at 10:12 AM, jakirkham<EMAIL_ADDRESS>wrote:

Would like us to make the release first (unless there are strong
objections). Am working on the changelog currently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3771#issuecomment-407071908, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszIisFaKr_j1HJS8gPH53sSTkZ5aqks5uJdm0gaJpZM4VR-uo
.

Merging this in.  Thanks @horta !


JUnit4 to 5 migration not showing up in composition of Spring JUnit4->5 for Spring

https://docs.openrewrite.org/reference/recipes/java/spring/boot2/springboot2junit4to5migration

I've validated that with this fixed that RecipeMarkdownGenerator produces the desired result in this case 👍


Add instructions on how to avoid system-wide global npm package installation

Commands like
sudo npm install -g @vue/cli webpack eslint

will install global dependencies system-wide, which will cause conflicts with files installed by a package manager (rpm, dpkg, ...).
There should be instructions in the README on how to avoid overriding system files.
For example, it's possible to set up a separate runtime directory for node/npm modules and simply run npm from there. This will pick up the local modules instead of those from the system.

@onitake thanks, we're all new to UI so best practices are likely not known or followed but PRs are welcome.

I'll try to write Dockerfile that illustrates how this should work.
So far, I've done my test deployments using Ansible, but having a Primate  container may be very useful for quick rollout.


Error calling onepasswordconnectsdk.load_dict()

Your environment

SDK Version: 1.1.0

Connect Server Version:1.5.0

OS: Ubuntu 20.04

Python Version: 3.8.2
What happened?

When following the instructions to create a dict to limit the fields returned, I receive the following error:
load_dict() missing 1 required positional argument: 'config'
If I copy and paste the text from the README, I get the same error.
What did you expect to happen?

The variable values_dict to be set with the the value returned from onepasswordconnectsdk.load_dict(CONFIG)
Steps to reproduce
import onepasswordconnectsdk

CONFIG = {
    "server": {
        "opitem": "My database item",
        "opfield": "specific_section.hostname",
        "opvault": "some_vault_id",
    },
    "database": {
        "opitem": "My database item",
        "opfield": ".database",
    },
    "username": {
        "opitem": "My database item",
        "opfield": ".username",
    },
    "password": {
        "opitem": "My database item",
        "opfield": ".password",
    },
}

values_dict = onepasswordconnectsdk.load_dict(CONFIG)

Thank you for reporting this issue!
It seems the docs are incorrect. The load_dict function requires two parameters, the first one being a onepasswordconnectsdk.Client and the second one being the config.
So you should call load_dict like this:
import onepasswordconnectsdk

CONFIG = {
    "server": {
        "opitem": "My database item",
        "opfield": "specific_section.hostname",
        "opvault": "some_vault_id",
    },
    "database": {
        "opitem": "My database item",
        "opfield": ".database",
    },
    "username": {
        "opitem": "My database item",
        "opfield": ".username",
    },
    "password": {
        "opitem": "My database item",
        "opfield": ".password",
    },
}

client = new_client_from_environment()
values_dict = onepasswordconnectsdk.load_dict(client, CONFIG)

I will open a PR and fix the docs soon!

Closed. Please reopen the issue if you run into any other problems related to this!


Resolve Dataset Profiling Glue Job

Feature or Bugfix

Bugfix

Detail

Specify SPARK_VERSION as an environment variable for pydeequ before import
Add IAM Permissions to Dataset IAM Role to Allow for Glue Job logging in CloudWatch
Add LF Permissions to resolve insufficient permissions error thrown when looking for default database

Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

To note for this PR - Glue Jobs require the permissions to be able to verify the existence of the default database or create the default database if it does not exist AWS Docs
This is needed for Glue Jobs that Use Data Catalog as the Hive metastore which is needed for our Glue Profiling Job
In order to accommodate this requirement, the PR adds code to grant DESCRIBE LF Permissions to the Dataset Principals (Dataset Role, EnvGroup Role, PivotRole) in the dataset Custom Resource Lambda
If the default database does not exist with the above changes in this PR the Glue Profiling Job will still fail as of now...

So now everytime we create a dataset, the dataset admin role will get permissions to the default database. Permissions to this database are needed to run the profiling job. Do you know why? is it generic for any Glue Job you need permissions to the default database?

We also need to fix it in modularization-main

@dlpzx, @noah-paige  I will gladly replicate these changes to mod-main :)

So now every time we create a dataset, the dataset admin role will get permissions to the default database. Permissions to this database are needed to run the profiling job. Do you know why? is it generic for any Glue Job you need permissions to the default database?

I know in documentation it calls out that Glue will also try to verify the default DB only if you enable Use Data Catalog as the Hive metastore
The permissions required are only DESCRIBE on the DB level since all Glue is doing is verifying the default DB exists by calling GetDatabase API


Remove unused test methods

v1
@yamgent submitted v1 for review.

[v1 1/2] GuiRobot: Remove push(KeyCodeCombination)
[v1 2/2] TestUtil: Remove scrub(KeyCodeCombination)

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/508/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you wish to fetch this PR to.

@limmlingg @Zhiyuan-Amos Oops ignore the request for review, sorry!


Introspection of View?

Is there any particular reason why it's not possible to iterate over the fields of a View, or at least access the underlying Layout of the view? I'm in the process of assessing the possibility of migration from records to data structures, and it's a bummer that in many places instead of one entity (the record), I need to pass around two (the signal/view and its layout).

You can. Layout.of(view)

I don't know why I couldn't discover this.

Layout.of(x) assumes x to be instantiated View, it doesn't work when passing type.
It leads to boilerplate in my use case, when using "Ergonomic layout definition":
let's consider such example:
class A(data.View):
   a : unsigned(123)
   b : unsigned(456)
   c : unsigned(789)

layout = Layout.of(A(Signal(123+456+789))

what is the "proper" way of accessing layout in such scenario?

@whitequark , I will leverage the fact that i have your attention and ask: I understand that lack of default target (that would allocate a Signal, not yet referenced by any other) argument of a View is intentional?
In the RFC0001, in the example below, it looked to me that data.Struct instantiation will allocate a Signal, as we can instantiate SomeVariant without any params passed to constructor.
class SomeVariant(data.Struct):
    class Value(data.Union):
        one_signed: signed(2)
        two_unsigned: data.ArrayLayout(unsigned(1), 2)

    kind: Kind
    value: Value

# this class can be used in the same way as a `data.View` without needing to specify the layout:
view2 = SomeVariant()
m.d.comb += [
    view2.kind.eq(Kind.ONE_SIGNED),
    view2.value.eq(view.value)
]

Layout.of(x) assumes x to be instantiated View, it doesn't work when passing type.

This is a bug, and it has the same underlying cause as https://github.com/amaranth-lang/amaranth/issues/794.

I understand that lack of default target (that would allocate a Signal, not yet referenced by any other) argument of a View is intentional?

It used to be that way, but it has been updated by RFC 15. See that RFC for details.

I encountered this before and came up with the following workaround:
Wrapping Layout.of with Layout.cast produces the expected behavior.
The following example demonstrates introspection of any data.View class by printing every field:
def print_view(view: data.View):
	layout = data.Layout.cast(data.Layout.of(view))

	for name, shape in layout:
		print(name, shape)
		field_value = view[name]
		if isinstance(field_value, data.View):
			s = yield field_value.as_value()
		else:
			s = yield field_value
		print(name, f'{s:X}')

Note that data.Layout.of(view) is going to be imminently removed and replaced with view.shape(). This also fixes Signal.like(view).


REQ: Inserting and managing repositories within YSFX

hi,
Thank you so much for this beautiful project! I don't use Reaper but a lot of JSFX are beautiful, and thanks to ysfx I can now use them inside Bitwig!
Is there a way to insert links to various jsfx directly into ysfx in future versions? This would help a lot those who do not use reaper to manage the various installed jsfx, updating them, removing them etc etc (for example: how can one download the various tukan jsfx without reaper and use them inside ysfx?)
thank you again!

I like the idea, but that's a really big feature.
Right now, I'm still prioritizing getting ysfx up to par with the current jsfx feature set and squashing bugs.
I think for the time being, the best way to go about it is to download the JSFX from those repositories manually, but I'll ask around, and if I find a good tool to automate this for other DAWs, I'll report back here.


Crash when customising the public feedback filtering by category:task and status:ideas

Description
When customising the public feedback filtering by category:task and status:ideas, the app crashes.
To Reproduce

Go to Settings > Advanced > Layout > Feedback > Explorer
Set default filtering: category:task and status:ideas
Save changes
Go to public view of feedback/feature requests

Expected behaviour
The public feedback list has default filters on.
Screenshots

In this particular case, you need to allow users to create those categories under Settings > Advanced > Content > Task&Idea > "User creatable" set as "Enabled".
Unfortunately the Advanced settings have many ways that can be misconfigured.


No graphics in the "R Graphics" window

I was running the following code:
library(ggplot2)

gg = ggplot(mpg, aes(displ, hwy, colour = class)) +
    geom_point()
(gg)

I got nothing besides a line saying Process finished with exit code 0.

How can I view the beautiful graphics in the top-right "R Graphics" window? Thank you!

It's disabled (see duplicate #134) since we don't really  know how to do so. The correct way would be to implement a custom graphics device, but thats a tricky one. PRs are welcome!


Tests on the test env

Workarround until s-streulicht is added to the sonar organisation ckormanyos

again wrong repositry should be the forked one.

still not working to execute a sonar check


Degraded Web Vitals (LCP, FCP) after switching a universal app to esbuild

Which @angular/* package(s) are the source of the bug?
compiler-cli
Is this a regression?
Yes
Description
We recently (Feb 14) switched to the esbuild build, and observed increased LCP and FCP - both lab and field data. We have HTTP2 enabled at our CDN (Cloudflare). We ended up rolling back to webpack (on Mar 13).
Some charts demonstrating the impact
Lab data: LCP (desktop)
Jumped from 1.7s to 1.9s

Field data: LCP (desktop)
Jumped from 2.9s to 3.2s

Note that we only updated the browser builder (from browser to browser-esbuild), and didn't migrate the SSR part from server to application (we deferred this due to some breaking changes with the existing code).
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 17.1.2
Node: 18.18.2
Package Manager: yarn 3.5.0
OS: darwin arm64

Angular: 17.1.2
... animations, cli, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic
... platform-server, router, ssr

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1701.2
@angular-devkit/build-angular   17.1.2
@angular-devkit/core            17.1.2
@angular-devkit/schematics      17.1.2
@angular/cdk                    16.1.7
@angular/material               16.1.7
@schematics/angular             17.1.2
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.4

Anything else?

It might be related to the large number of chunk files esbuild produces: 140 initial and 90 lazy-loaded. For comparison, with webpack it is 5 initial and 60 lazy-loaded.
Total size of initial chunks with esbuild is slightly higher than with webpack: 5.5MB vs 5.1MB uncompressed.
Compression also seems to favor fewer big chunks. Compressed (transferred) size is 1.8MB (esbuild) vs 1.5MB (webpack). It's 20% transfer size increase!

Previously, someone else also reported a drop in Lighthouse score, despite having HTTP 2: https://github.com/angular/angular-cli/issues/26307#issuecomment-1830438109

Hey @amakhrov, diagnosing the root cause of the LCP and FCP increase is challenging without a reproduction.
Esbuild's generation of numerous chunks is intrinsic to its design, driven by internal algorithms. Unlike webpack, chunk control isn't currently possible. Check out https://github.com/evanw/esbuild/issues/207 and https://github.com/evanw/esbuild/issues/1128 for more context.
Regarding the size increase, a 400kb uncompressed JS file is substantial, given JS's parsing complexity. Unfortunately, pinpointing the cause and suggesting improvements necessitates a minimal reproduction.

Closing as per above. If the problem persist please open a new issue and provide a minimal reproduction.


1.0.0 is using an old version of fff

The latest 1.0.0 rc (1.0.0-f899db8) is using an older version of fff. The fff version appears to be v0.1.1, where as the latest version is v0.2.0. Since fff is now directly part of the ceedling repo instead of a submodule, it is difficult to tell exactly what version of fff is being used.

Suggest to update fff to latest version.

Adding for clarity - There are two related issues being reported here:
Issue 1: Version 1.0.0 (f899db8) is using an older version of fake_function_framework.
Issue 2: Previous versions of Ceedling (eg 0.31.1) imported the fake_function_framework as a submodule so determining the version/commit being used by Ceedling was straightforward. Version 1.0.0 is directly adding the fake function framework which makes it difficult to determine the version/commit being used. When the fake_function_framework is updated, I recommend adding a method for determining the fake_function_framework version being used in Ceedling.

Issue 1 has been resolved. Issue 2 is something we should definitely discuss further going forward. This is a general problem with tool versioning that should get some thought.


evil-execute-macro: Wrong type argument: number-or-marker-p, nil

After 0 kbd macro iterations: evil-execute-macro: Wrong type argument: number-or-marker-p, nil
Occurs when executing a macro that uses snipe. I'm not yet familiar enough with evil-mode's macro implementation to know whats causing this or how to fix it.

Apparently the error is triggered by evil-half-cursor. Here is a temporary workaround for the issue:
(setq evil-snipe-enable-half-cursor nil)

I've removed half-cursor from later versions of evil-snipe.


Token generation encodings

Addressing issue #7

Coverage remained the same at 100.0% when pulling 216f5acf7a8bf7122c73d50680af3295fe22145b on hotfix/code-gen into f6afbe24c11afeab313659fc7e4e2be656fbd97a on master.

Coverage remained the same at 100.0% when pulling 4e27f79622a40ab49e03faa1d1181833b60154b3 on hotfix/code-gen into f6afbe24c11afeab313659fc7e4e2be656fbd97a on master.

Coverage remained the same at 100.0% when pulling 6e9b428adb648c84c10977e9d2807e28b9466f7f on hotfix/code-gen into f6afbe24c11afeab313659fc7e4e2be656fbd97a on master.

Coverage remained the same at 100.0% when pulling ad0891a585978fcb841fa8f584a404b62a118af7 on hotfix/code-gen into f6afbe24c11afeab313659fc7e4e2be656fbd97a on master.


Fix cycle detection within fibers

We keep a separate depth count per fiber.
Fixes #1752.

@Seldaek Anything left to do before this can be merged?

Nope, looks good, thanks!


[V1.5][Documentation] UG/DG + Collate + PPP

Update UG/DG (tag and favourite related portion)
Update PPP
Update collate file

Coverage remained the same at 80.845% when pulling a76e9e2ae87028d68a9f2ec7f58ace119dda6768 on wangyiming1019:master into e93b75e0aa4b240714f044a3916f5fa78b6316aa on CS2103AUG2017-W09-B2:master.


feat(addon-table): reset column direction on third click

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Build or CI related changes
[ ] Tests related changes
[ ] Documentation content changes

What is the current behaviour?
Closes #5064
click table headers currently toggles through asc and desc states (2 states)
What is the new behaviour?
adding a 3rd state to column sort behaviour when clicking table headers - rotate through:

asc
desc
off

Hi @JoelLau. Thank you for this PR. However there's already a fix for it which is simpler:
https://github.com/taiga-family/taiga-ui/pull/5631
I'm not sure adding 0 mode to the direction makes sense as it basically means not to sort and instead of introducing a "not sort" mode for sorter, removing sorter altogether (setting it to null) seems cleaner to me.


Move configSecretName key

If my interpretation of the rationale behind the Habitat type is correct, the spec.service field should only be used for flags passed to the supervisor binary.
It follows then that the configSecretName key shouldn't be there.
Is it worth it to move it elsewhere (e.g. one level up)? Or am I being pedantic? :joy:

I'm trying to think with my "spanning ring" hat on here. At some point I will want to add something to the manifest. Basically a bunch of ports that would be opened on the cluster:

one for SWIM/gossip communication between supervisors inside and outside the cluster
zero or more ports for service specific needs

This normally would be solved with the k8s Service resource, like we currently do in some examples. But I wanted to add separate fields for the ports in the manifest, because this information needs to be passed to the supervisor too. It would have a double purpose and that would make the ports to fit neither category of fields, I think.
In general, I think that categorization of the fields based on whether this stuff is passed to habitat via flags or not is rather arbitrary. I mean - what do we do with those fields is an implementation detail, no? If we want to categorize the fields, I suppose it should be based on functionality. Something like:

setup:

image
count

runtime

env
ring key
group
topology
config secret name
bind
persistent storage
name
channel

So, I dunno. Maybe just flattening all this would be best… OTOH, setup could serve as a dumping ground for some k8s specific stuff if we ever will need to add something (like image pull policy, which we didn't add in the end), and runtime - for habitat specific stuff. But not sure where the port fields for spanning ring would fit into this picture.
So, you wanted my opinion so there you have it. :)


TTNN demo for UNet

Is your feature request related to a problem? Please describe.
have a demo for UNet running on device via TTNN
Describe the solution you'd like
Have a demo of UNet carvana and/or UNet Brain-segmentation running on device via TTNN.
carvana and Brain MRI segmentation via UNet

currently blocked by: 5857 & 6326

a quick summary for the brain-mri variant here:

we have unit tests for all required convs: conv2d brain UNet unit tests  issue 5857

we have unit test for all required maxpool_2d: maxpool2d brain UNet unit tests (all pass :rocket:)

I can't write unit tests for the concat ops yet as I'm blocked by convTraspose2D (the op before concats)  to know the sharding shapes needed for the concats.

I have filed an issue for convTranspose2d  bringup: convTrasnpose2D issue

I also added a unit test for log sigmoid in TTNN: log sigmoid Brain UNet unit test

currently blocked by: https://github.com/tenstorrent-metal/tt-metal/issues/5857 & https://github.com/tenstorrent-metal/tt-metal/issues/6326
once these 2 issues are resolved, I can test concats and then the model end to end.


Support connection via a proxy

We currently do not support running the Device Agent behind a proxy. We have a customer request to do so.
There are two parts to consider:

any HTTP request the agent makes
any MQTT over WebSockets request the agent makes

The mqtt library allows us to pass in a wsOptions object which in turn can have an agent property which will allows us to add an agent with a proxy configuration.
The got library will have similar support for the same.
We need to then decide how a user should provide their proxy configuration. One option would be to have it in the device.yml to keep things contained. But we have the boot-strap issue of the quick connect mode that generates the device.yml needs to be able to contact the platform first. So we should support the standard HTTP(S)_PROXY env vars - no need to do all combinations of upper/lower case, lets just be opinionated and support one common flavour.
### Tasks
- [ ] https://github.com/FlowFuse/device-agent/issues/270
- [ ] https://github.com/FlowFuse/nr-project-nodes/issues/80
- [ ] https://github.com/FlowFuse/nr-file-nodes/issues/55

As per discussion and backed up by this article, I have went with lower case variant.
Working branch proxy-support -  I will raise a draft PR on very shortly.
An additional task this development work threw up is the need for the project nodes to also have proxy support.

[ ] Update project nodes to to support running behind a proxy.

Increased to size-5 due to the additional places needing work (project link, file nodes) and the testing env setup needed to properly test all of this.


QuestGUI bug

What is your Quests version / build number (do not say "latest")?
My current Quests version is 3.8.8, my QuestsGUI version is 0.11.
Our server is running Mohist-2e1b046
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
So, i bought QuestsGUI on spigot and uploaded it to our test server. Trying to use the GUI-Editor is really buggy, opening it lags a bit and after setting up one of the features (name for example, doesnt matter which one), you cant move your mouse cursor anymore. Its literally frozen in the middle of the screen. The only way to leave the server is to close minecraft.
There are no errors in console and/or logs aswell.
If applicable, can you provide an example quest from quests.yml using Pastebin.com?
Guess thats not needed because its a GUI bug. I am not even able to set up an example quest xD

This issue tracker is for Quests; not QuestsGUI. Please use the discussion thread at https://www.spigotmc.org/threads/questsgui-paid.399346/


removed python 3.7, added 3.10 to github workflow

Sorry for randomly trying this! You mentioned it in #58 and I wanted to understand github workflows a bit better.
Basically just followed the example in the readme here and committed every time I changed something until the tests started passing again.
Added quotations in the yml as otherwise 3.10 gets recognised as 3.1

Codecov Report

Merging #62 (d5ac53b) into main (53aac54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   82.97%   82.97%
=======================================
  Files           4        4
  Lines         141      141
=======================================
  Hits          117      117
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53aac54...d5ac53b. Read the comment docs.

Haha "I apologise for helping your project along!" 😂 Thank you very much @thanushipeiris! 👏


Fixes for controllers

Fix various (possible) bugs in Controllers:

Add null checks
Remove non-existing variables
Fix typo in classname
Make null return explicit
Fix bug caused by incorrect needle/haystack in AppController.
Fix bug caused by non-existing variable being used in AppController.

I want this merged post-haste, so we can deploy a release to the NC app store, in order to prevent further issues being opened for the same bug... but currently the build is failing on the composer install. The same fix as done for the standalone PHP also needs to be applied here first (see https://github.com/pdsinterop/php-solid-server/commit/6a485773cfc5c51f77ff18d93a72ff99c0c79a45).

I've been able to fix the issue with the composer file in f1db07d319fbcb7a4b5dbff8f2430310a36d3447 whilst working an QA. I'll move that commit over to this branch (or get it merged to main), to get the build passing so we can commence review, merge, and release of this fix.

MR #68 has been merged. I've rebased these changes and will merge them now.


Claw update

WIP
values require testing

ignore that last typo oops

Merged this branch into teleop; closing this PR and deleting the branch from remote.