Source code of compliance control

Hi, everyone,  great work. I wonder if your compliance control algrithom code is open source, because I can't find them on github, but the lead through and compliance effect if impressive on berkeleyopenarms.github.io.

Hi!
You can find the lead-through code we used for the video here. There's no specialized control algorithm for it: during the "record" stage, we just disable all our controllers and send feedforward gravity compensation torques.

Hi!
You can find the lead-through code we used for the video here. There's no specialized control algorithm for it: during the "record" stage, we just disable all our controllers and send feedforward gravity compensation torques.

Thanks for your replay. I also noticed that the arm's compliance respond to human disturbance. Which controller are you using to accomplish that? The soft position controller here?

Yep, that's the controller we were running in the video. :)

Yep, that's the controller we were running in the video. :)

I mean, this seams to be a regular computed torque controller with position feedback, right? Why are the joints so soft to the disturbance, just because of the low gain? Did you try anything like impedance control or some other force control method?

Yeah, it's pretty much just the transparent transmissions + lower controller gains.
The position controller you linked above implements joint-space impedance control, but there's a separate computed torque controller in the same directory (which linearizes the control space using our robot dynamics model). Both are pretty standard/simple.

Thanks!


⚠ Fortnite has degraded performance

In 76506f6, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1556 ms

Resolved: Fortnite performance has improved in 2e8a95a.


Funding Plan

At time of writing, we are raising around 650 USD per month.
This is already amazing, but considering the scope of the ORM, the ideal situation would be to have one of us work on the ORM as close to full time as possible. This would require a budget of 5000 USD to 15,000 USD per month.
Current State
We already use the following platforms to raise funds:

OpenCollective
thanks.dev
GitHub Sponsors

We also receive funds from ads on the website
Recently, we've also had workday offer to sponsor the development of specific features
What can be improved

We should incentivize companies to donate

We could add the list of sponsors on our home page, with a call to action to OpenCollective.
We should rework our Open Collective page to be more professional / cleaner than what we currently have. We should also remove the bugfix/feature tiers as they are highly undervalued compared to the cost of actually implementing a feature.

Companies sponsoring specific features is amazing. We should add calls to action to contact us for estimates for feature requests.
We could consider partnerships with companies that do work closely related to ours. For instance:

Maybe we could propose a partnership with https://neon.tech to display ads for them in our new "How to use Sequelize with Postgres" guide
There are many companies offering solutions for migrations. We could see if one of them wants to do a partnership and display ads for them on our pages about migrations.
Some companies extend the features of databases, such as https://timescale.com. We could contact them about adding support for them in our ORM (and possibly ads) in exchange for sponsoring
My research focuses on postgres because that's my database of choice but if you know of other potential partners for other databases, that's worth looking into

We can reach out to companies that we know use Sequelize, and ask them if they are willing to sponsor the ORM

@WikiRik: we can add a readme for the whole organization that promotes donating as well + update our GitHub sponsors to match OpenCollective
@WikiRik Regarding partners: We could also offer blog posts (neon.tech)
@WikiRik For things like timescale: it's important that they give us a way to run our tests against their solution. We would require a longer-term contract with them for this to be interesting
@sdepold We could ask for testimonies from companies (workday, etc), especially if they use v7

@WikiRik Maybe a private feedback form? (positive and negative)


Release Google.Cloud.Dataproc.V1 version 2.1.0

Changes in this release:

Commit cdd7342: docs: change relative URLs to absolute URLs to fix broken links.
Commit e644610:

Adds Dataproc Jobs.SubmitJobAsOperation RPC
Adds SparkR and Presto job types to WorkflowTemplates
Adds new Optional Components
Clarifies usage of some APIs

Commit edebc2b: fix Dataproc: add missing REQUIRED annotation.
Commit bd045c2: Adds resource name overloads for autoscaling policy operations

Created release for Google.Cloud.Dataproc.V1-2.1.0


how to let it cycle

hi, if i'd like let it cycle, how to fix it

@commutescript  Is this problem solved?


Dynamic map service sub-layer cannot be added to the map viewer

The search widget does not recognize a sub-layer of a dynamic map service as a layer that can be added to the map viewer.
In addition to /MapServer also see if there is /MapServer/ in the link since sub-layers show up as /MapServer/0, /MapServer/1, ...

resolved in 2.7.1


Update add-question-metadata-portal.md

I

@DishaAgarwal : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Feature request to support Discourse as SSO provider

Description
Discourse has SSO feature and can work as SSO provider https://meta.discourse.org/t/using-discourse-as-a-sso-provider/32974.
As most of self hosted platform like gitea are accompanied by discourse as discussion platform, it will be good if users has to sign up in one platform only and then use 1st as external login provider for other.

Hi There, Is this feature considered to be implemented?

It seems you could use a proxy https://github.com/discourse/discourse-auth-proxy work with gitea since gitea support proxy auth.

I'm also quite interested in a Discoure sso providing feature.
I had tried the proxy that you mentioned, but never managed to make things work in the environment in which my Discourse and Gitea are deployed...

I 'd like it too!
Discourse is so popular to build own dev community.


getting inputs

I wanted to use this to run a ssh -t with a top command. The problem is I need to line up further interactive inputs - like 'm', 'h' for help, 'q' for quit etc. that top command needs for example. Here is my code -
c := exec.Command("ssh", "-t", "some_ssh_link", "'top'")
f, err := pty.Start(c)
if err != nil {
	panic(err)
}
io.Copy(os.Stdout, f)

Any suggestions? It can build up terminal as expected and refreshes as you'd expect but I need to line up os.Stdin with top's input.

You don't need a pty if you want to use stdin.
This should do the trick:
cmd := exec.Command("ssh", "-t", "some_ssh_link", "'top'")
cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
return cmd.Run()

The issue you are having is that your terminal (stdin) is not in raw mode while the pty is.
You can use github.com/creack/termios to do so.
This snippet works fine on macOS 10.12.3 and linux debian 8 (jessie):
package main

import (
        "io"
        "log"
        "os"
        "os/exec"

        "github.com/creack/termios/raw"
        "github.com/creack/termios/win"
        "github.com/kr/pty"
)

func test() error {
        // Create arbitrary command.
        c := exec.Command("ssh", "-t", "some_ssh_link", "top")

        // Start the command with a pty.
        ptmx, err := pty.Start(c)
        if err != nil {
                return err
        }
        // Make sure to close the pty at the end.
        defer func() { _ = ptmx.Close() }()

        // Set stdin in raw mode.
        origTermios, err := raw.MakeRaw(os.Stdin.Fd())
        if err != nil {
                return err
        }
        // Defer revert the raw mode to avoid breaking the terminal.
        defer func() { _ = raw.TcSetAttr(os.Stdin.Fd(), origTermios) }() // Best effort.

        // Optional: Resize the pty to match stdin size.
        ws, err := win.GetWinsize(os.Stdin.Fd())
        if err != nil {
                return err
        }
        // As we don't resize stdin, no need to revert.
        if err := win.SetWinsize(ptmx.Fd(), ws); err != nil {
                return err
        }

        // Copy stdin to the pty and the pty to stdout.
        go func() { _, _ = io.Copy(ptmx, os.Stdin) }()
        _, _ = io.Copy(os.Stdout, ptmx)

        return nil
}

func main() {
        if err := test(); err != nil {
                log.Fatal(err)
        }
}

Let me take a look thanks - I worked around using something like this -
func Execute(c *exec.Cmd) { 	f, err := pty.Start(c) 	if err != nil { 		panic(err) 	} 	go func() { 		scammer := bufio.NewScanner(os.Stdin) 		for scammer.Scan() { 			f.Write([]byte(fmt.Sprintf("%v\n", scammer.Text()))) 		} 		f.Write([]byte{4}) // EOT 	}() 	io.Copy(os.Stdout, f) }
Seems to work as expected - only difference is I have to newline everytime I send something to terminal - a little price to pay I guess...

Have to see if
c := exec.Command("ssh", "-t", "some_ssh_link", "'top'")
c.Stdin = os.Stdin
c.Stdout = os.Stdout
c.Stderr = os.Stderr
return c.Run()

If this would work with a terminal type application, since our specific usecase warrants telnetting to an app that performs these commands remotely...

Just for others reference this works, although I am not able to figure out how to close out or exit out once the pty session is over.
func main() {
	// spin off sample server to test ...
	l, _ := net.Listen("tcp", "<IP_ADDRESS>:12345")
	for {
		c, _ := l.Accept()
		go func() {
			handle(&c)
		}()
	}
}
// simple handler that runs top command
func handle(c *net.Conn) {
	cmd := exec.Command("ssh", "-t", "some_remote_host", "top")
	f, _ := pty.Start(cmd)
	go io.Copy(bufio.NewWriter(*c), f)
	go io.Copy(f, bufio.NewReader(*c))
	go io.Copy(bufio.NewWriter(*c), os.Stdin)
	cmd.Run()
}

@AnirudhVyas if that can help. I've been playing with this package recently.
That's like a non authenticated telnet session:
https://gist.github.com/tehmoon/7c72db32ed59f52cea3964d353f99e50
Can be tested against:
socat file:`tty`,raw,echo=0 tcp:x.x.x.x:1234


The 'TraceRoute' test take 44 minutes to fail in macOS CI

The test TraceRoute works in the context TraceRoute in the file Test-Connection.Tests.ps1 is causing timeout in macOS CI builds.

We will make the test pending for further investigation.

I had no idea that the Net team could add code that is so unreliable. Maybe the PowerShell team can internally escalate this so that this network-based API is finally fixed?

I tried that in the last case though, and they insisted the issue is with the native API they call. Looking into it, I think they're right.


chore(TFD-1448): replace 'data store' with 'connection' in few data s…

…tores displayName
What is the current behavior? (You can also link to an open issue here)
You can refer to https://jira.talendforge.org/browse/TFD-1099.
The aim of this PR is to replace all "data store" occurences within the forms labels of the available data stores from the Data Streams application. Those occurences have to be replaced with "connection".
What is the new behavior?
The renaming mentioned above has been done on those data stores :

Pub/Sub
Elasticsearch
Big Query
Kafka
Salesforce
JMS
JDBC
S3 (SimpleFileIo)
HDFS (SimpleFileIo)

Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

I could not run the whole unit tests campaign from my environment because of this : Error resolving artifact org.talend.components:components-api-service-osgi:jar:0.20.0-SNAPSHOT.
I will see from the CI whether those tests pass.

Pull request test result: success :star:


terragrunt validate - issues with root terragrunt.hcl

Failures in root terragrunt.hcl terragrunt validate.
Consider the following dir structure
├── dev
│   └── eu-west-1
│       └── project
│           └── terragrunt.hcl
└── terragrunt.hcl
└── common.hcl

Where the child includes the parent via find_in_parent_folders().
If the parent has many read_terraform_config(find_in_parent_folders("common.hcl")) type includes it will fail when terragrunt validate runs against it in singular. As the dir traversal fails to find the file.
Anything that can be done about this?

Just to confirm, is this an issue with a pre-commit hook you are using, or are you manually running terragrunt validate?

pre-commit. although it could be replicated using terragrunt validate

Can you point to which pre-commit hook runs terragrunt validate? I don't see one in our list that runs terragrunt validate (only terraform validate).
In any case, I think this is a terragrunt issue so I will most likely migrate this over to that repo.

Also, this is sort of expected behavior since terragrunt validate actually means to run terraform validate for the given terragrunt configuration, and the root terragrunt config doesn't point to a terraform module (by definition), so even if we get past the syntax error, it will fail later in the pipeline when terragrunt checks for the existence of terraform code.
The pre-commit hook for a terragrunt validate call needs to be sure to ignore the root terragrunt config for this reason.

@yorinasub17 I got around this in the end by adding rules to the pre-commit cmd for terragrunt/terraform validate so that the root .hcl is ignored and that only files named terragrunt.hcl elsewhere where tested. example below
- id: terragrunt_validate
   files: terragrunt.hcl
   exclude: '^terraform/aws/terragrunt.hcl'

happy for this to be closed off


Added ApiGatewayProxyHandlerV1 for ApiGateWay V1

The ApiGatewayProxyHandlerV1 object is designed for handling requests from AWS API Gateway (v1) and transforming them into HTTP4s requests for further processing in Scala applications

@armanbilge is this something that you can review, please?


New package: LGElectronics.webOSEmulator.2 version 2.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111891&drop=dogfoodAlpha

@wingetbot run

https://github.com/microsoft/winget-pkgs/issues/111634

/AzurePipelines run

/AzurePipelines run

Close with reason: Package URL used is temporary;


load_indices should include index config

Ideally the output from load_indices would allow to both know

Whether the index is an IvfPq index or a Btree index
What parameters were used to train the index

Today I can kind of guess the first one based on the type of column but once we add more vector index types this will no longer be possible.
I have no way today of getting the parameters.  This can be very useful because users may forget these things and want to examine them (e.g. because they've learned more about vector indices and now they want to know if they need to rebuild their index or not).

I thought the parameters were in dataset.stats.index?
(Pdb) from pprint import pprint
(Pdb) pprint(dataset.stats.index_stats(index_name))

{'index_type': 'IVF',
 'indices': [{'centroids': [[0.5594622492790222,
                             ...,
                             0.5300236940383911,
                             0.5513307452201843]],
              'index_type': 'IVF',
              'metric_type': 'l2',
              'num_partitions': 2,
              'partitions': [{'size': 238}, {'size': 274}],
              'sub_index': {'dimension': 32,
                            'index_type': 'PQ',
                            'metric_type': 'l2',
                            'nbits': 8,
                            'num_sub_vectors': 1},
              'uri': '/private/var/folders/09/h28jzzv164n6bn4ldrhhm73m0000gn/T/pytest-of-willjones/pytest-27/test_count_index_rows0/test/_indices/ef525f0b-4c87-42d9-9ace-3e2437b10c71/index.idx',
              'uuid': 'ef525f0b-4c87-42d9-9ace-3e2437b10c71'}],
 'name': 'a_idx',
 'num_indexed_fragments': 1,
 'num_indexed_rows': 512,
 'num_indices': 1,
 'num_unindexed_fragments': 0,
 'num_unindexed_rows': 0}

I thought the parameters were in dataset.stats.index_stats?

@wjones127
They are but the statistics are experimental / unstable.  Since index parameters are stable, we should have a stable way of retrieving them.
I'm mainly filing this because I want to be able to load the index config in LanceDb and I'm not sure we want to expose raw stats in LanceDb.

I hope we can make them more stable soon. IIRC the main impetus for exposing them is making it so users can retrieve and re-use the IVF centroids.

We also have some use cases where we need to check the metric_type. Agreed, would be nice to have a stable way of getting it.


Can you provide the trained model?

Hi,
Thanks for providing the source code. I want to test your model with my own data. I would be very grateful if you can provide a well-trained model.

Thanks for your advice! I will try it soon.


I tried to add the file extension in the config like so:
'url' => '/uploads/:attachment/:id_partition/:style/:filename.jpg'
Using this line png files remain png files (but have a .jpg file extension).

Sadly, I don't think there is (currently) a clean way to do something like this.  I would strongly recommend that you use Laravel's build in validation to ensure that the uploaded image is always a jpeg (if that's a requirement of your application).  That's about the best I can do right now, however I'm certainly not opposed to having such functionality in the future (currently I have no idea how the configuration for that would work, etc).  We'd have to get it some thought.


refactor(permission-controller): Clean up use of any

Explanation
Either replaces any type casts with @ts-expect-error directives or leaves them in place without a TODO to replace them. All remaining instances of any are defensible. No behavioral changes.
Changelog
None.
Checklist

[x] I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

@hmalik88 reposting for visibility:

This is just replacing the previous any types with a @ts-expect-error directive. Either way, we are "abusing" our types by intentionally violating them. The reason for this "abuse" is that we are testing runtime errors that can only be produced through invalid TypeScript.

I appreciate @MajorLift's way of expressing this practice:

intentional destructive testing

(Although he rightly accuses these tests of being sloppily typed as opposed to necessarily using any, much of the time.)

I did a final pass and left a few more comments, but aside from those everything lgtm!


Project Submission - Complete Front-End Setup

Milestone #2 - Project Completion & Documentation
In this PR, the development branch does contain every change and everything related to fribntend development and details are as follows:

Followed the GitHub workflows.
Created the react setup.
Used the styled-components.
Created the Redux store for Greetings.
Created the Greeting component.
Used the React-Router as per requirement.
Used fetch-API for making the request to API either local or Deployed API Server
Resolved the eslint linter errors.
Updated the README.md.

React Project Live Link
Click Here
Backend Repository
Click Here
Backend PR Link
Click Here

@alexander16108 Thank you very much. I will remove the links.
Happy Coding 🥂


Multi-error parsing for Amount

It's nicer to show all the errors in an input in various applications. Amount has quite complicated parsing, so it's better if our library provides this rather than requiring users to implement it themselves.

Definitely agreed. I'd like to spend time trying to do this in something like rust-miniscript before attempting it here, at least.


Device dropdown missing accessible name

Area or Component
Facility form
Quick Summary
The device dropdown selector is missing an accessible name.
Accessibility Violation
Select element must have an accessible name: https://dequeuniversity.com/rules/axe/4.4/select-name?application=AxeChrome
Action Requested
Give each device selector element an accessible name (an aria-label). If there are multiple selectors, each likely needs a unique aria name.
Original Deque Issue
https://docs.google.com/spreadsheets/d/1b6xjubAN5Uw11DV4_B5zvSu7HeDI6Z-DpV4DMcToqAY/edit#gid=1346058064&range=4:5

Note: this could be because the whole device component in the facility form is mis-coded.  As it stands the fields are "labelled" by the table headers, but this is not best practice and should be changed.


Array Merge error (and Ambiguous class detection)

Hi,
First of all: Nice work on the package!
Now I have installed the L5.1 version and want to use it, but I get an error after I add the serviceprovider and clean up my installation (dump-autoload, clear-compiled, config:cache, route:cache, optimize --force).
I get an error about the array merge in vendor\laravel\framework\src\illuminte\support\serviceprovider (in function mergeConfigFrom). I see that the $config var is Null all of a sudden. Initializing it with an empty error fixes the problem, but then when I want to use the authenticator I'll get an invalid Hasher.
"ErrorException in ServiceProvider.php line 68: array_merge(): Argument #2 is not an array"
Any ideas what could be causing this (and how to resolve this)?
Ps: I also get a lot of Ambiguous class resolutions, could that have anything to do with it?

Warning: Ambiguous class resolution, "MigrationCartalystSentryInstallUsers" was
found in both "vendor/jacopo/laravel-authentication-acl/database/migrations/2012_12_06_225921_migration_cartalyst_sentry_install_users.php" and "vendor\jacopo\authentication-sentry\src\migrations\2012_12_06_225921_migration_cartalyst_sentry_install_users.php", the first will be used.

Warning: Ambiguous class resolution, "MigrationCartalystSentryInstallGroups" was
found in both "vendor/jacopo/laravel-authentication-acl/database/migrations/2012_12_06_225929_migration_cartalyst_sentry_install_groups.php" and "vendor\jacopo\authentication-sentry\src\migrations\2012_12_06_225929_migration_cartalyst_sentry_install_groups.php", the first will be used.

Warning: Ambiguous class resolution, "MigrationCartalystSentryInstallUsersGroups
Pivot" was found in both "vendor/jacopo/laravel-authentication-acl/database/migrations/2012_12_06_225945_migration_cartalyst_sentry_install_users_groups_pivot.php" and "vendor\jacopo\authentication-sentry\src\migrations\2012_12_06_225945_migration_cartalyst_sentry_install_users_groups_pivot.php", the first will be used.

Warning: Ambiguous class resolution, "MigrationCartalystSentryInstallThrottle" w
as found in both "vendor/jacopo/laravel-authentication-acl/database/migrations/2012_12_06_225988_migration_cartalyst_sentry_install_throttle.php" and "vendor\jacopo\authentication-sentry\src\migrations\2012_12_06_225988_migration_cartalyst_sentry_install_throttle.php", the first will be used.

Update: I am trying to see what happens if I build a new Laravel app and ad everything back in there. Will come back with the results once it is done.

Update:
Oke I have completely rebuild my application several times. I can install everything and then when I want to use the authenticator I get the error that the class authenticator is not found. So I stop everything and start 'optimizing':
dump-autoload works
clear-compiler works
config:cache works
route:cache -> here the error comes:
array_merge(): Argument #2 is not an array.
And then I can do nothing with the app anymore. Even uncommenting the ServiceProvider in the app.php and commenting the authenticator line and optimizing won't fix the problem.
Any ideas?

Can you write your service_provivers.php line that includes the authentication service provider?

I have rebuild my application like 6 times now and eventually it works now. I have no idea why it didn't work the first couple of time, but no need to put more effort in it. So let's just close this issue. Apologies for the inconvience and thanks for your time.

Regarding the ambiguous classes, @skeser noted on 6 Apr 2016 and @ashish64 noted on 6 Nov 2016 that a workaround is to delete Laravel's create_password_resets_table and create_users_table migrations from the database/migrations folder.


Fix serialization of x-www-forms-urlencoded values with System.Text.Json or request and response serialization settings

The issue addressed in this PR affects me as well. I've tested the code change in a project of my own and concur.
@Chryssie Good job!

Fix for this was merged in #4402 so I guess this one can be deleted?

Fixed by #4402


Debug Console is very noisy in Extension Development Mode

When developing vscode extensions that depend on this extension (or using this extension in development mode) the output of every kubectl command is printed to debug console. This makes console.log not very useful. Debugging test failures becomes very tedious because of mass of kubectl output. There should be a way to disable this.

Came here for the same issue. It appears there are quite a few console.log statements in the source code here, and it might be more beneficial to add a build step to remove them in production only, so as to not disrupt the dev workflow.
You could consider terser-webpack-plugin. Which is already a dependency of webpack@5. So whenever you do upgrade, it would not be an additional dependency.
It should be as straight-forward as adding:
optimization: {
        minimize: true,
        minimizer: [
            new TerserPlugin({
                terserOptions: {
                    compress: {
                        drop_console: env === prod,
                    },
                },
            }),
        ],
    },

just a suggestion. happy to add a PR if its wanted.

@seethroughdev would you mind creating a fork or a PR for my own fork? https://github.com/juozasg/vscode-kubernetes-tools

Sorry for the delay @juozasg ! I actually switched over to using the NodeJS instead.
But if I can get some free time next week I'll give it a shot just to help. Keep you updated.

I forked this and disabled the logs with shelljs silent option
https://github.com/juozasg/vscode-kubernetes-tools


Allow renderding arbitrary Ember components, fixes #19

For details, please see the updated README: rendered.

This is awesome! Thanks!

Tell me when this is released. ^_^

Sure thing : ). Should be released momentarily. Just doing some digging to see why the test is failing for ember-beta.

Got it fixed by tweaking the {{link-to}} call. Published to npm as<EMAIL_ADDRESS>Let me know if you encounter any issues, and thank you again! :beers: :beers: :beers: :beers:

:beers:


Switch from ScmDataFrame to ScmRun

Pull request
Please confirm that this pull request has done the following:

[x] Tests added
[ ] Documentation added (where applicable)
[x] Example added (either to an existing notebook or as a new notebook, where applicable)
[x] Description in CHANGELOG.rst added

Fixes #295

Only remaining issue is appending monthly and annual data


Consider ability to re-order head elements

Might require splitting react-helmet

No longer concern of uni.


GitHub Actions: Link build artifacts in pull request descriptions

Based on https://github.com/HarbourMasters/Shipwright/blob/develop/.github/workflows/pr-artifacts.yml. The effects of this pull request won't be seen on this pull request itself, but it should be able to apply to old pull requests once they receive a new commit or force-push. nightly.link is used so that links work for non logged-in users too.
The section added at the bottom of OP in a pull request is correctly updated when commits are pushed, including force-pushes and squashes.
Note: Before this is merged, permissions must be changed in the Settings > Actions tab of the GitHub repository:

The actions are configured to use a restricted set of permissions using YAML, so other workflows will remain read-only.
Preview
The following block is added at the bottom of each pull request:

Thanks to @garrettjoecox for helping me troubleshoot the action :slightly_smiling_face:

Niceee, that is really going to help developers and especially non-developers test PRs quickly! Perhaps we should put them in a section though, so they are folded by default and don't take a lot of space?

Niceee, that is really going to help developers and especially non-developers test PRs quickly! Perhaps we should put them in a section though, so they are folded by default and don't take a lot of space?

Maybe, but I fear this will make them hard to notice, especially for people on mobile (if we add an Android editor link).

Looks good.

Is there a chance for this getting merged soon with the permissions changed ?

Is there a chance for this getting merged soon with the permissions changed ?

4.1 is currently in feature freeze, so the priority is to finalize it right now. This means other contributors won't have much time to review this PR until 4.1 is released.

Any updates here?

I want to make sure we're not introducing a security risk to this repo by setting the default GH_TOKEN to Write permission. IINM, it means that anyone able to trigger a workflow on this repo (so anyone with at least one commit merged) would be able to use GH_TOKEN to write commits, edit issues, PRs, or even tamper with releases. Is that correct?
If so, I think that's too broad a permission to give to 2000 people.

I want to make sure we're not introducing a security risk to this repo by setting the default GITHUB_TOKEN to Write permission. IINM, it means that anyone able to trigger a workflow on this repo (so anyone with at least one commit merged) would be able to use GITHUB_TOKEN to write commits, edit issues, PRs, or even tamper with releases. Is that correct?
If so, I think that's too broad a permission to give to 2000 people.

Even if you grant write permission on GITHUB_TOKEN, GitHub will force it to read-only for any workflows triggered from PRs from forked repositories (unless other Actions settings are changed), so this approach won't work. GITHUB_TOKEN doesn't have a lot of granularity in its permissions, so it's best to keep it on the least permissive settings to avoid security issues as much as possible. A GITHUB_TOKEN is just an  auto-installed GitHub App in the background, only you don't have any control over its permissions or installation.
The best way to allow this type of action without opening up permissions entirely, is to create a GitHub app in the organization and set its permissions to only do the thing you want to do - Apps have the full range of granularity for permissions, so it can be very specific. This has several advantages: you can set just the permissions you want; updating permissions leaves an audit trail and requires reinstalling the app, so it's transparent and easy to audit; you can revoke the secrets at any time if something goes wrong.
The steps to do this are:

Create a GitHub App (as an admin, in the org via Settings / Developer Settings / GitHub Apps)

You don't need to expire user tokens or webhooks, so uncheck those boxes that are set by default

Set the desired permissions
Create a secret, and download the secret key file
Install the GitHub App in the organization
Set two secrets in the organization for use in actions: one for the App ID, another for the secret key (copy paste the contents of the secret key file into it). Something like  GITHUBAPPNAME_APP_ID and GITHUBAPPNAME_APP_SECRET`
Use the following to generate a token when running an action:

- id: get-token
  uses: getsentry/action-github-app-token@v2
  with:
    app_id: ${{ secrets.GITHUBAPPNAME_APP_ID }}
    private_key: ${{ secrets.GITHUBAPPNAME_APP_SECRET }}

You can then use ${{ steps.get-token.outputs.token }} to pass the token into where you need to authenticate.

Would it be possible to have less strict permission requirements by having CI post a new comment (and edit that comment if it already exists), instead of editing OP's comment? This is something a regular user can do, while editing someone else's comment requires maintainer permissions.

People already have problems following templates, accidentally missing sections ARE an issue, so a comment is a better idea imho

It will look a bit more bloated, but it also prevents OP from accidentally or intentionally removing the artifacts section from their initial comment.

People already have problems following templates, accidentally missing sections ARE an issue, so a comment is a better idea imho

Just FYI, if the section is not found within the main description, it will automatically append it to the end, it's not required to add the section to the template


OPCT-253: Rename OPCT binary to the new name

Rename the tool binary name from openshift-provider-cert* to opct, removing any reference of OS and ARCH, improving the instructions to use that 'generic name' in the install section.
https://issues.redhat.com/browse/OPCT-253

/lgtm
/approve


Get the Menu to appear in the address bar again

The chrome extension doesn't seem to be displaying the F in the header to turn FancyMerge on and off:

New css selector. Thanks github!


Changes for Beat Saber 1.36.2

PlayerDataModel was moved to DataModels.dll so add reference
SongCore.Collections.DeregisterizeCapability was renamed

still works on Beat Saber v1.37.0


You must brew unpin<EMAIL_ADDRESS>as installing<EMAIL_ADDRESS>requires the latest version of pinned dependencies

currently latest php on brew is @7.2
there is a reason why my php version is pinned as the server i am deploying to is using 7.1
this error is blocking my progress

Pinning is not a feature I'm supporting.


Refer to trello-smooth-dnd as the drag-n-drop core library

@dapi I have published smooth-dnd as a package to npm for each distribution. pls review and merge if you don't see any issues

@dapi hi, can you merge the commit anytime soon pls? Thanks!

Hi everybody! Give one day to check

👍

Thanks @dapi! @rcdexta are you going to swap smooth-dnd dependency for this new trello-smooth-dnd in react-trello package? I see it's not updated yet.. let me know pls


adjoint_options files

Currently we have 4 slightly different files with AD options for TAF/TAMC and one for TAMC only (adjoint_tamc_compatibility) in tools/adjoint_options and two more local copies in local code_ad directories:

"adjoint_default" and adjoint_f95 differ only in the flag "-f95" instead of "-f77" or "-f90"
"adjoint_state_file" is not tested (used for "SVD"), but is contains only two relevant differences to the default file..
"adjoint_diva" sets an extra flag (DIVA='true', not sure where that is used), an extra "-pure" option and includes mpi-header files in the list of files shown to TAF (something that TAF has difficulties with since version 4.9.10)
I have no idea, when "adjoint_tamc_compatibility" was used the last time, and if it will ever be used again, but the main difference I see there is are "-v1 -nonew_arg" flags.

I found 4 "genmake_local" files that contain flags relevant for the AD, pointing to two local ad_optfile.local (in bottom_ctrl_5x5, tutorial_dic_adjoffline); the genmake_local files in verification_other have no relevance for AD:

bottom_ctrl_5x5/build/genmake_local (points to ../code_ad/ad_optfile.local mainly for the taf option "-e", and USE_EXTENDED_SRC='t')
halfpipe_streamice/build/genmake_local (ALWAYS_USE_F90=1, and AD_OPTFILE='../../../tools/adjoint_options/adjoint_f95', which is a contradiction)
lab_sea/build/genmake_local (points to ../../../tools/adjoint_options/adjoint_diva and commented #TAF_EXTRA='-version 2.9.3')
tutorial_dic_adjoffline/build/genmake_local (points to ../code_ad/ad_optfile.local, because of a xx_dic ctrl variable that no longer is used and will be removed together with ECCO_CTRL_DEPRECTATED)

All six different build options files can be easily combined into one, and the different options can be controlled via flags in genmake_local, e.g. TAF_EXTRA or new flags like ALWAYS_USE_F90, USE_DIVA (I tried this successfully here: https://github.com/mjlosch/MITgcm/tree/preproc_adjoint). This would be much simpler to maintain, especially in the light of the ECCO_CTRL_DEPRECTATED flag, the removal of which will make the list of control variables considerably shorter. I assume that we want to have an example of specifying a specific AD_OPTFILE, but that could still be done, by having one experiment point at the default explicitly.
I suggest two options and would be happy for your opinion:

do nothing, never change a running system
merge options files into one and adjust genmake_local files (this would be done after getting rid of ECCO_CTRL_DEPRECTATED code), with details to be discussed.

I think it makes sense to merge the files and just adjust the genmake_local files. I remember being confused early on about why there are all those different adjoint option files. Merging means less to maintain, and less for other people to get confused about

I agree that it would be good to have fewer AD optfiles (not sure about removing the SVD one). But in term of timing, I think it would be better to merge this future PR after we do the last checkpoint that support the ECCO_CTRL_DEPRECTATED. But it does not prevent us to make these changes sooner, in a new PR (just that it will not be merged right away).

Since the SVD file is never tested, it's hard to know if my attempt (with a "USE_SVD") would work, but the differences to the default file are minimal (see https://github.com/mjlosch/MITgcm/blob/preproc_adjoint/tools/adjoint_options/adjoint_default, l67-l72)
Clearly, merging the files does not make any sense before the ECCO_CTRL_DEPRECTATED is removed.

An other thing we could remove (or better: comment out) from the ad-optfile is the "-server" setting:

it's better and cleaner to rely on what "staf" does.
if someone want to use "fastopt.net" as a default, it just involves changing 1 line in "staf" script (i.e., the default server).
It's confusing when trying to use some ot "staf" options to set the server while it's also set in the ad-optfile, because it's not obvious which setting will be used at the end (+ some info reported to screen/log-file might be misleading).

merged PR #649 addresses this issue, so we can close it.


does it work with custom templates?

it works turning on the responsive template but not with our custom template? where does it append to?

Hey,
the toolbar will be appended to the body before shopware sends the response to the client.
Is your  tag correct see https://github.com/shyim/shopware-profiler/blob/master/Subscriber/Collector.php#L180

we're having a JS issue:
http://look.neta.io/jSTt
you can see it here:
https://pw.koffein.io/checkout/confirm

Have you removed the shopware default csrf js classes?

if you check window.CSRF they are there, i am thinking right now it has to do with loading order?

Are you initializing csrf later like document ready?

would it change the profilers behaviour wrapping the "var window.CSRF._ajaxBeforeSend;" part into document.ready?

I tested it with DOMContentLoaded event, and it was too late, the emotion request was already send.
I would like surround it with a if to catch the error, but subrequests wouldn't be profiled on your page.
I will embed the profiler bar css

The JS issues is now fixed in the latest version. I also added the css file instead of compiling theme.
If you have still problems, please reopen the issues :)


map freeze

on 0.11 update my map freezes when choosing state view mode

Hi @LeXus21251, can you please check whether it's the same issue as #81?

Yes it's the same issue, I'll try fix it on my own. Thanks for quick answer
Btw when 11.1 will be on VSC because its only 11.0 for me

I forgot to publish it. It's done now.aa


Move TODO to GitHub issues

Back then patches were circulating in email attachments and issues were running on mailing lists.

@szepeviktor thank you

You're welcome.


As a user, I need high level protocol documentation

Problem
There should be a place to understand the protocol flow at a high level, this should include:

Breakdown of transfer lifecycle
How messages are passed + message lifecycle
System architecture
How rollup timeouts are bypassed

Ideas to solve this
Write the documentation, make sure to check whimsical for any helpful diagrams.
Acceptance Criteria

[ ] Docs are live on the website

Impact

What OKR goal does this align to?
shipping amarok
Provide Impact estimate = ideally quantitative forecast, if not then qualitative description of impact
10
Other Notes
A clear and concise description of what the problem is

@alexwhte not sure if we should breakout into sep. issue but would be great to include updating / polishing the READMEs for this.

For the initial audit-readiness milestone, I think we can keep everything in the Notion doc since it's pretty well fleshed out. We can have a task for Beta/Teen Wolf which requires this to be ported onto the docs site.

@alexwhte not sure if we should breakout into sep. issue but would be great to include updating / polishing the READMEs for this.

Definitely a task but not for audit-readiness/alpha.


[Backport release-24.05]  telegram-desktop: 5.1.7 -> 5.5.5

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested on x86_64-linux with wayland and it segfaults with

Is this on a 24.05 or unstable machine?

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 342783

x86_64-linux

:x: 1 package failed to build:

_64gram

:white_check_mark: 2 packages built:

ada
telegram-desktop

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 342783

x86_64-linux

:white_check_mark: 3 packages built:

_64gram
ada
telegram-desktop


[Feature] Add pvt and pvtv2

This commit implements PVT and PVTv2.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: whai362:x: czczupwhai362 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please @Junjun2016  take a look at this pr

Need fix confilct

Hi, we fixed our CI recently. Please merge the latest master and make sure the unit tests can pass.

update readme
add metafile
merge master

Overall, this PR LGTM, several small comments can be resolved before merge.


Should the package host other .gitignore related functionality?

Like:

Adding or removing entries.
check if a file is ignored or not.
expose a python gitignore representation
...

Maybe we'd have to rename the package to gitignore (which already exists on pypy but seems not active) or similar, e.g. dotgitignore.

My two cents: KISS
I was actually going to suggest support for .dockerignore files, however this might no be trivial, since the order of includes and excludes matters a lot.


Documentation

Resolved issue #15
I have written documetation for how to create bot and how to invite the bot to join a server

@HarshCasper I have done the documentation part.


⚠ Bofrost.de has degraded performance

In 6aabf84, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1357 ms

Resolved: Bofrost.de performance has improved in 80af311.


No ListItem.Season infolabel at Seasons level of TvShow.

Bug report
Your Environment

Netflix add-on version: 0.16.1
Operating system version/name: Win 10

Used Operating system:

[ ] Android
[ ] iOS
[ ] Linux
[ ] OSX
[ ] Raspberry-Pi
[x] Windows

Describe the bug
$INFO[ListItem.Season] infolabel is not filled at season level of a tvshow.
ListItem.Season will ensure better integration with TMDbHelper's player function. Currently I am forced to select the season item at the position matching the season number - which is error prone if a season is missing from Netflix or there are special seasons.
See comment here for example:
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/24#issuecomment-569165434
Expected behavior
ListItem.Season should return the season number of the season at both the Season level and the Episode level of a TvShow
Actual behavior
ListItem.Season is empty at the Season level and is only filled at Episode level.
Steps to reproduce the behavior

Open Plugin and Search for a Tvshow (e.g. Stranger Things)
Click Tvshow to open Seasons view of TvShow.
ListItem.Season is empty.

I'll check the return data
I'll let you know

The only way i know is to filter the shortName field,
in principle it should be fine, unfortunately netflix also assigns particular names so i don't know if the value will be obtained 100% of the cases..
Please test the PR

Remember to do Purge cache on memory and disk in expert settings before test

Seems to be working well. Thanks! 😁

well well


Links don't load - they try to open an internal address instead

The image says it all I think.
Both bbcode and html links yield the same result.

Seems like we need link validation before actually accepting it. So https://www.google.com would work but www.google.com won't. Will that solve the issue?

Fixed in 355dff986bc1ef974293644ab9d260b9359e6510.


"Generate Lorum Ipsum" requests are blocked

VS Code Version:
OS Version:

Version: 1.85.0-insider (Universal)
Commit: 7771124ebd6b7f6e60da14d744961b717b73282f
Date: 2023-11-08T05:36:07.740Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0

Logs:

Click me
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:51.697Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:51.817Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:51.817Z] Successfully established tunneling connection to proxy
[INFO] [default] [2023-11-21T08:35:52.215Z] [fetchCompletions] engine https://copilot-proxy.githubusercontent.com/v1/engines/copilot-codex
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.215Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.217Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.356Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.357Z] Successfully established tunneling connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.357Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:35:52.357Z] Successfully established tunneling connection to proxy
[INFO] [default] [2023-11-21T08:35:55.445Z] request.response: [https://copilot-proxy.githubusercontent.com/v1/engines/copilot-codex/completions] took 3230 ms
[INFO] [streamChoices] [2023-11-21T08:36:00.675Z] request done: headerRequestId: [808b4ea2-7448-4fd7-b8aa-b0e02943f393] model deployment ID: [xca6373c2f5d7]
[INFO] [default] [2023-11-21T08:36:00.830Z] [fetchCompletions] engine https://copilot-proxy.githubusercontent.com/v1/engines/copilot-codex
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:00.831Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:00.884Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:00.884Z] Successfully established tunneling connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:07.183Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:07.232Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:07.232Z] Successfully established tunneling connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:10.453Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:10.494Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:36:10.494Z] Successfully established tunneling connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:39:45.347Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:39:45.405Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:39:45.405Z] Successfully established tunneling connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:40:00.352Z] Attempting to establish connection to proxy
[DEBUG] [proxy-socket-factory] [2023-11-21T08:40:00.440Z] Socket Connect returned status code,200
[DEBUG] [proxy-socket-factory] [2023-11-21T08:40:00.440Z] Successfully established tunneling connection to proxy

Steps to Reproduce:

Ask Copilot Chat to generate some "Lorum Ipsum" text
This happens:

Lorum ipsum is a type of fake text commonly used in UI design, is there a specific reason why such is not allowed from Copilot Chat?

Hi! I'm receiving for 1 hour an error 400

There was a service incident yesterday causing 400s. Many filtered response cases are tracked in #532


Country Request: Haiti

We are working to improve access to nighttime healthcare in rural Haiti. Our project is MotoMeds, and would benefit from better maps of buildings and roads in the Gressier, and Leogane communes. https://www.trekmedics.org/programs/haiti/motomeds-healthline-for-sick-children-haiti/
Gressier_Leogane_ADM4.geojson.zip

Thanks for the request @mapninja
I've added Haiti to the list

@mapninja Haiti is now available!


Blog post refers to ember-usable

The intro blog post is showing things imported from ember-usable, but I think that was just a working name for what is now ember-could-get-used-to-this.

(Also the package.json repository field here.)

There is also a typo - (concat "www.example.com/users" @userId) should be (concat "www.example.com/users/" @userId).

Thanks! Have updated the blog post, will submit a fix for the package repository


Update Ubuntu version to 22

What is the context of this PR?
Updates and pins Ubuntu to version 22 for git actions
Updates the PR template to standardise across repos
How to review
Checks pass
Checklist
*[ ] Tests updated

 Upgrade from Ubuntu version 18.04 in GitHub Actions workflows


release-2.0: Introduction

assign to translate

@125801169 这篇文章是我翻译的，有没有兴趣帮我review？我看了你近期的翻译，整体还不错，但是语言组织需要加强。

好啊，我试一下
---Original---
From: "Yang<EMAIL_ADDRESS>Date: Sat, Feb 22, 2020 00:45 AM
To<EMAIL_ADDRESS>Cc: "Mention"<mention<EMAIL_ADDRESS>Subject: Re: [hyperledger-labs/fabric-docs-cn] release-2.0: Introduction (#570)
@125801169 这篇文章是我翻译的，有没有兴趣帮我review？我看了你近期的翻译，整体还不错，但是语言组织需要加强。
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

好啊，我试一下
…
---Original--- From: "Yang<EMAIL_ADDRESS>Date: Sat, Feb 22, 2020 00:45 AM To<EMAIL_ADDRESS>Cc: "Mention"<mention<EMAIL_ADDRESS>Subject: Re: [hyperledger-labs/fabric-docs-cn] release-2.0: Introduction (#570) @125801169 这篇文章是我翻译的，有没有兴趣帮我review？我看了你近期的翻译，整体还不错，但是语言组织需要加强。 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

好的，分配给你review了

好！
---Original---
From: "Yang<EMAIL_ADDRESS>Date: Sat, Feb 22, 2020 15:44 PM
To<EMAIL_ADDRESS>Cc: "Mention"<mention<EMAIL_ADDRESS>Subject: Re: [hyperledger-labs/fabric-docs-cn] release-2.0: Introduction (#570)
好啊，我试一下
…
---Original--- From: "Yang<EMAIL_ADDRESS>Date: Sat, Feb 22, 2020 00:45 AM To<EMAIL_ADDRESS>Cc: "Mention"<mention<EMAIL_ADDRESS>Subject: Re: [hyperledger-labs/fabric-docs-cn] release-2.0: Introduction (#570) @125801169 这篇文章是我翻译的，有没有兴趣帮我review？我看了你近期的翻译，整体还不错，但是语言组织需要加强。 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
好的，分配给你review了
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

已校对翻译


added new demo

This PR adds (and updates) the tailwind demo that was in the graphql gateway back into the mono repo.

This PR adds (and updates) the tailwind demo that was in the graphql gateway back into the mono repo.

Given the size and scope of this PR, could you take a few minutes to highlight the "updates" you made outside of just moving the code over?  I'm assuming the demo worked before, so whatever you had to do to get it working in the repo should be sufficient.
Would make reviewing this much less daunting :)

This PR adds (and updates) the tailwind demo that was in the graphql gateway back into the mono repo.

Given the size and scope of this PR, could you take a few minutes to highlight the "updates" you made outside of just moving the code over? I'm assuming the demo worked before, so whatever you had to do to get it working in the repo should be sufficient.
Would make reviewing this much less daunting :)

@Enigmatical yes absolutely!
The main part of the work was removing unused files such as

the util folder
the tina-wrapper

I also had to re-write all of the graphql queries, updated the _app.js (used the one from the starter with a few modifications).
Other then that I just had copied the code from the old repo. (https://github.com/tinacms/tina-graphql-gateway/tree/main/examples/tina-tailwind-sidebar-demo)


Why is enzyme-to-json a peer dependency in fela-enzyme?

Type: Question

Packages
Version

fela-enzyme
10.5.0

Description
I just added fela-enzyme. When I tried using it got an message that enzyme-to-json wasn't available. The package.json has it listed as a peer dependency, so I'll have to install/manage that separately. Any specific reason it is set up that way? Wouldn't it be better to have enzyme-to-json as a regular dependency?
BTW, fela on Gitter appears dead

First of all, we should make it a dependency - thanks for reporting! (wanna send a PR?)
I do not personally use fela-enzyme and thus never really used/checked it - it was PRed as well.
Any improvements to the package are very welcome!
Also, we moved to Spectrum recently (see README). Where did you find the reference to Gitter?

Thanks for the response. I'll try to find some time for a PR. Also, Gitter is mentioned in the Github Issues template:

Before choosing question, please consider asking on Gitter as we might close question issues

Ohh, we'll need to update all occurrences of Gitter mentions! Also according to the package. I'm not even sure if you really need it at all. We only use snapshot tests (with jest-react-fela) and it works just fine enough. I'm happy with any contribution of course, just wanting to hint that!

We're going to deprecate fela-enzyme as it's not maintained and the original author did not respond at all. I'd recommend using jest-react-fela for simple testing.


Nag patch author for bugs flagged in-testsuite? to finally land it, once a bug is derestricted

I think it's overdue. The background is that whenever we ship high-severity security vulnerabilities, we are asking people to hold off landing a test, as it would make it easier for attackers to reproduce the issue and build security exploits based off of those.
We're generally good at not giving away too much stuff, but we sometimes forget landing the test at all. Over time, we've build quite a backlog of security issues that have unlanded tests (sometimes with and sometimes without the in-testsuite? flag. So the whole issue is a bit bigger than this, but definitely worth getting to, even if in slow iterations.
P.S: The bug was filed in response to a thread on dev-platform "Land your tests for now-public security bugs" back then.

There is a discussion in #1464, we are re-evaluating what to do here.


Modality not working for classes derived from nana::form

Having a class that is derived from nana::form, that is used as a modal window, it does not show the modal window and instantly closes it.
#include <nana\gui.hpp>
#include <iostream>

using namespace std;
using namespace nana;

class fm1 : public form
{
public:
	fm1() : form()
	{
		this->caption("form 1");
	}
};

class fm2 : public form
{
public:
	fm2(form parent) : form(parent)
	{
		this->caption("form 2");
	}
};

int main()
{
	fm1 fm;
	fm.events().click([&fm]
	{
		fm2 fm_modal(fm);	// does not work
		//form fm_modal(fm);	// does work

		fm_modal.modality();
		std::cout << "modal form was closed" << std::endl;
	});
	fm.show();

	exec();
}

Nevermind, i should have passed the parent as a form&, the above made a copy which broke it.


fix: LSDV-4774: Drawing on the hidden image in MIG scenario

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
LSDV-4774
What does this fix?
Fixes an issue when it's possible to start a Brush/Polygon region on one image and continue drawing on a different image.
What is the new behavior?
Regions created with Brush or Polygon will stay on the image they were initially created on. The user can continue drawing a region if they return to the image where they started. Otherwise, any drawings are ignored.
What is the current behavior?
If a user creates an unfinished Polygon and switches to the next image, the Polygon will travel to the next image as well. Whenever the Polygon is finished, it will stay on the last selected image.
If a user creates a Bush region, switches to the next image, and starts drawing, they won't see anything. As soon as they switch back to the previous image, they will see everything they drew on the second image. Effectively, they were drawing on an invisible image.
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
None
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
Labeling UI, Image Segmentation, MIG

For Brush it may be that problem is here https://github.com/heartexlabs/label-studio-frontend/blob/68aeda880c17508f538252c705367d54e92850f6/src/tools/Brush.js#L105-L117
I think that item_index is missed there

And for Polygon it maybe should be there https://github.com/heartexlabs/label-studio-frontend/blob/68aeda880c17508f538252c705367d54e92850f6/src/tools/Polygon.js#L115-L124


read view does not correspond to edit view

Minimal Theme

Describe the bug
Everything works fine and editing is the same as vew mode exept padding of paragraphs.
To reproduce
See enclosure
Expected behavior
see enclosure
Screenshots
If applicable, add screenshots to help explain your problem
Debug info (required):

SYSTEM INFO:
Obsidian version: v1.5.3
Installer version: v1.4.16
Operating system: Windows 10 Pro 10.0.22631
Login status: not logged in
Insider build toggle: off
Live preview: on
Base theme: dark
Community theme: Minimal v7.4.7
Snippets enabled: 0
Restricted mode: off
Plugins installed: 9
Plugins enabled: 8
1: Dataview v0.5.64
2: Number Headings v1.16.0
3: Regex Find/Replace v1.2.0
4: Text Format v2.5.0
5: Advanced Paste v2.7.0
6: Excel to Markdown Table v0.4.0
7: Auto Link Title v1.5.3
8: Minimal Theme Settings v7.3.1
RECOMMENDATIONS:
Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

You can adjust this in Style Settings → Text

Sorry to be a bit slow here.
Settings = Minimal Theme Settings?
Under Typography I find Line hight but I want to adjust the padding (which works in view but not in Edit Mode).
Beat Moser
Bergstrasse 9
8322 Madetswil
FON +41 79 257 96 00
Von: Steph Ango @.>
Gesendet: Dienstag, 30. Januar 2024 15:59
An: kepano/obsidian-minimal-settings @.>
Cc: Beat Moser @.>; Author @.>
Betreff: Re: [kepano/obsidian-minimal-settings] read view does not correspond to edit view (Issue #78)
You can adjust this in Style Settings → Text
—
Reply to this email directly, view it on GitHubhttps://github.com/kepano/obsidian-minimal-settings/issues/78#issuecomment-1917077247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4323VKA5CDU2VCR6WK4BHDYREDBPAVCNFSM6AAAAABCQZPDUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGA3TOMRUG4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

No it's a separate plugin called Style Settings.
Please check out the documentation here:
https://minimal.guide/plugins/style-settings


Wrap naming policy

The wrap tool and the WrapDB system are very powerful features in Meson build system. They make developers life a lot easier by providing an easy and convenient way of using other libs as dependencies in your project.
When using the wrap tool and the WrapDB system to find a particular library I would expect a person to search by the exact name as upstream uses/promotes. E.g.:
$ meson wrap search catch2

There are already two cases on the WrapDB with misleading names right now:

https://wrapdb.mesonbuild.com/json
https://wrapdb.mesonbuild.com/catch

json
Upstream: https://github.com/nlohmann/json
This one has nlohmann_json as the official name of the lib (though the repository is simply called "json").
catch
Upstream: https://github.com/catchorg/Catch2
This one has changed its name to catch2 (more about its name change is here).
What should be done in case if upstream changes name?
I would expect for the older version to remain under the old name on the WrapDB. And the new version to have the new corresponding name. This way it is logical and easy to find the exact lib you are looking for. It simply saves you time.
What is the policy for naming a lib on the WrapDB system?
This is already described here. I would just add that in case of the above two projects they don't have a pkg-config file, so I think that the name they use/promote should be used, lowercase only (Catch2 -> catch2).
Name convention for a variable which keeps a value returned by declare_dependency() function
https://mesonbuild.com/Subprojects.html
It may be already in use, but I just don't remember seeing it written anywhere.
For ease of use as a subproject, I would suggest that each project has this convention for declaring dependencies - <proj_name>_dep, e.g. for catch2 it would be catch2_dep. Then one can just use it without even looking inside build definitions of that subproject.
PS:
I think that simple but defined rules make our life easier and more predictable, so we can count on them, like in this case with naming.
Please correct me if I am missing anything.

The json one was probably named by me. In hindsight it was perhaps not the best of decisions because "json" is a word used by so many different projects. In the future we should keep a better eye out on the naming.
For this particular case we could do something like the following if the need to rename comes up:

create a new repo with the new name
update existing wraps to use the new name
add a new commit to the json repo telling people that they should start using the new name
freeze the json repo and never add anything to it again, but keep the old ones working

Pull requests are welcome. Since it's your proposal I will leave it to you to make the change,

Sure. I am happy to help.

You should take a look on a more interesting example though, gtest

Agree, this one is a good example indeed. Even in this case there is naming logic gtest_dep and gmock_dep are pretty obvious names here. But there are also gtest_main_dep and gmock_main_dep for a special case, so yes not much to standardize here ... .

create a new repo with the new name

We actually need two here: nlohmann_json and catch2. Could any of you guys create them as I don't have rights? Though I will be happy to help with content for them.

update existing wraps to use the new name

I can help with that.

add a new commit to the json repo telling people that they should start using the new name

I am not sure I understand how this works? How it will tell people that info?

I am not sure I understand how this works? How it will tell people that info?

We need a separate feature in mesonwrap/core meson to support deprecation. The way I see it now is to mark a repository deprecated in master branch and export it somehow through mesonwrap API. Then show a warning in WebUI/core meson wrap code itself. It is a separate thing to do though.
We will probably have to reserve names forever though to keep old wraps alive. Until (if) we develop a retention policy. Let's track deprecation separately.

I am not sure I understand how this works? How it will tell people that info?

Simply having message('WARNING: this wrap is deprecated, you might want to use nlohmann_json instead.') in the build file should fix most issues.

It will not surface though until the user will try to configure the project, after downloading the wrap. I think we should aim for notification in the list, e.g.
$ meson wrap list
...
catch [deprecated, use catch2]
catch2
cereal
...

We can do both.

A new name of a lib doesn't necessarily mean depreciation of the old one. Somebody may decide to continue to support it.
Taking that into account I wouldn't mark a lib as "depricated" in Meson. Instead I would suggest to leave it to the upstream and developers who use this lib to check the current developmen state of the lib.
Looks like handling a wrongly named wrap case is tricky.

add a new commit to the json repo telling people that they should start using the new name but keep all other functionality intact
freeze the json repo and never add anything to it again, but keep the old ones working

The downside of this approach is that this particular name cannot be used anymore by any other wrap. Are we ok with this?
Maybe there should be a policy to release this names after some time?

For now I just marked both deprecated in github repo description, I will think about functionality how to handle it better.

A new name of a lib doesn't necessarily mean depreciation of the old one. Somebody may decide to continue to support it.

Do you mean cases like Gnome_2 and Gnome_3 (not literally): 2 major versions competing? Otherwise it sounds confusing.

Retention policy.

I have a different idea. Let's think about retention policy outside of renaming scope. When does it make sense to drop the name? My idea is when it has no valid versions. When is it fine to drop a version? When there is no upstream release source code hosted by author. We will definitely not commit to hosting source code, only wraps. So if they drop let's say catch-2.2.1 we can safely remove the version, that's my take on this.

Do you mean cases like Gnome_2 and Gnome_3 (not literally): 2 major versions competing? Otherwise it sounds confusing.

Yes. That's a good example.
I also want to let you know that I mentioned naming convention for dependency variables on Subprojects page and updated Adding new projects to WrapDB page.

I have a different idea. Let's think about retention policy outside of renaming scope.

Should we create another issue for that discussion and close this one?

Do you mean cases like Gnome_2 and Gnome_3 (not literally): 2 major versions competing? Otherwise it sounds confusing.

Yes, that is a good example.

I have a different idea. Let's think about retention policy outside of renaming scope.

Should we create another issue for that discussion and close this one?

I would like to let you know that I updated Subprojects page with naming convention and Adding new projects to WrapDB page with more detailed steps on how one can contribute a wrap file.

Do you mean cases like Gnome_2 and Gnome_3 (not literally): 2 major versions competing? Otherwise it sounds confusing.

Yes, that is a good example.

I have a different idea. Let's think about retention policy outside of renaming scope.

Should we create another issue to discuss it there and close this one?

I would like to let you know that I updated Subprojects page with naming convention and Adding new projects to WrapDB page with more detailed steps on how one can contribute a wrap file.

Do you mean cases like Gnome_2 and Gnome_3 (not literally): 2 major versions competing? Otherwise it sounds confusing.

Yes, that is a good example.

I have a different idea. Let's think about retention policy outside of renaming scope.

Should we create another issue to discuss it there and close this one?


Update GitPython dependency

Resolves #225
Signed-off-by: Mike Fiedler<EMAIL_ADDRESS>

@weakish when might this be released?

@miketheman I just updated the HISTORY.rst file and the version number in code.
ping @kennethreitz for a new release on pypi


az datafactory repository configuration resolves to git path when executed from bash

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
datafactory
Description of issue (in as much detail as possible)
az datafactory factory create -n $factory -g $rg --factory-vsts-configuration account-name="" collaboration-branch="master" last-commit-id="???" project-name="" repository-name="" root-folder="/" tenant-id=""
{
  "additionalProperties": null,
  "createTime": "2021-01-29T13:34:03.837108+00:00",
  "eTag": "\"00009795-0000-0d00-0000-60265cd90000\"",
  "globalParameters": null,
  "id": "/subscriptions/***/resourceGroups/lb-dev-logistiekinfo/providers/Microsoft.DataFactory/factories/***",
  "identity": {
    "principalId": "***",
    "tenantId": "***"
  },
  "location": "westeurope",
  "name": "***",
  "provisioningState": "Succeeded",
  "repoConfiguration": {
    "accountName": "###",
    "collaborationBranch": "master",
    "lastCommitId": "refs/heads/adf_publish",
    "projectName": "###",
    "repositoryName": "###,
    "rootFolder": "C:/Program Files/Git/",
    "tenantId": "***",
    "type": "FactoryVSTSConfiguration"
  },
  "resourceGroup": "###",
  "tags": {},
  "type": "Microsoft.DataFactory/factories",
  "version": "2018-06-01"
}

See the rootFolder property.
We worked around this by using this: root-folder=''

datafactory

hi @qwordy could you pls have a look? thanks

@yungezz @riezebosch Will do, thanks


[fix] static-property-placement: fix bug with static property refs inside methods

Fixes #2283

Buddy test pass on my local code :)


WIP: Prototype to provide user-defined upsteam-to-downstream identity transformations/filters via Starlark functions

Problem Statement
During login, when an identity is established from an upstream OIDC or LDAP provider, then a Pinniped admin might like to perform arbitrary transformations like adding a prefix to usernames or group names, removing unwanted groups, down-casing usernames or group names, rejecting authentication based on group memberships, etc. This is logged as issue #558.
Hopefully this feature can pave the way towards supporting multiple simultaneous upstream identity providers for a single FederationDomain in the Supervisor. Once you are able to do things like prefix usernames and group names, then you can ensure that downstream usernames and group names from different simultaneous IDPs are unique and won't clash.
To support this feature, we need a way for users to craft their own arbitrary transformations in some kind of language.
Using Starlark as Part of the Solution
Why consider using Starlark for custom user-defined upsteam-to-downstream identity transformations/filters?

Starlark is implemented in Go by Google and they use it internally extensively for their build system, so we can expect it to be well supported. Google is also very conservative about allowing any language definition changes, so the language is stable.
The language is very well documented. See https://github.com/google/starlark-go/blob/master/doc/spec.md
Python-like syntax is understandable to any programmer, even to someone who has never used Python
Scripts can define functions, use “if” statements and “for” loops, use built-in types like string, tuple, dict, list, set, etc.
Starlark is simple and runs deterministically: no classes, no threads, no random numbers, no clock (can optionally expose the time lib), stable iteration order, etc.
Designed to be hard to write scripts which do not terminate (e.g. no while loops)
Effectively sandboxed, even though it runs in the same address space:

Scripts cannot do any IO
Can limit the number of abstract computation “steps” that are allowed (limiting CPU usage, roughly limiting time)
Can also cancel using a context (e.g. apply a timeout)
Cannot limit memory usage, unfortunately, but that seems okay for our use case where only administrators would write scripts

Starts interpreter and runs functions in several microseconds, so performance would be excellent
Safe to run many interpreters at the same time on the same loaded module/function (thread-safety is guaranteed)
Functions can be called from golang and passed arguments, including passing complex types (with attributes defined in Go) as arguments, and can get back return values
Libraries can be pre-defined and offered for use in the user-defined Starlark source, for example we could define common helper functions if we wanted
Can run scripts using a golang program, e.g. a CLI, so we could easily provide a simple test framework for script authors to be able to TDD their scripts if we wanted
Supports UTF-8 strings
The Starlark Print() method can be attached to our logging system to allow scripts to debug log

Examples
Here is an example Starlark script to add a prefix to every upstream username and group name, and also downcase every upstream username and group name:
# During a login, given the upstream username and list of group names, return the downstream names.
def transform(username, groups):
    prefixedGroups = []
    for g in groups:
        prefixedGroups.append("group_prefix:" + g.lower())
    return "username_prefix:" + username.lower(), prefixedGroups

Here is an example Starlark script to reject logins from any user who does not belong to the upstream group "admins".
def transform(username, groups):
    if "admins" in set(groups):
        return username, groups
    else:
        fail("user", username, "does not belong to group admins")

Some possible example use cases for upstream-to-downstream identity transformations include:

Disallow authn for any user who does not belong in a list of usernames (e.g. when the upstream IDP is GitHub)
Disallow authn for any user who does not (or does) belong to a certain group or one of a list of groups
Prefix or otherwise make unique the username or group names
Downcase or otherwise normalize usernames and group names
Even though a user belongs to lots of upstream groups, remove all expect for the interesting ones for downstream membership (also helps avoid client certs getting too large from having too many groups)

Some more “creative” (maybe less likely to be needed) use cases include:

Change upstream group names into downstream names (e.g. change “my-admins” to “system:masters”)
Change certain upstream usernames into downstream usernames (e.g. change “ryan” into “admin”)
Look at other upstream ID token claims or LDAP record attributes as part of the business logic of doing these transformations (e.g. if the user is located in a California branch office of our company then add an artificial downstream group “ca-office”)
Matt suggested that we might want to deprecate or make optional our existing settings for mapping upstream fields into downstream fields and just ask users to use the generic transformation capability instead

The Rest of the Solution
It would be easy to allow users to define such scripts as a string on a CRD, in a Secret, or wherever we like. For example, the LDAPIdentityProvider CRD could have a field to define a custom transformation Starlark script which would be applied to each login via that IDP. These details are not yet designed.
If desired, we could allow a user-defined list of transform functions to be applied in order, since the input and output types are the similar enough that they are easy to chain together. This might be fancier than needed.
Broadly speaking, our Kube controllers would parse/load the user-defined Starlark scripts into memory using starformer.New(). Then our authentication code would execute the user-defined Starlark hooks during each login, which are thread-safe and performant, using starformer.Transform(). The starformer.Transformer instances, which are returned by starformer.New(), would probably live in our existing in-memory caches that are loaded by our controllers and used by our authentication code.
Limitations
Note that Starlark does not allow scripts to perform IO by default. This is a helpful feature. However, it also means that base Starlark will not allow configurations where an administrator wants to make HTTP calls to an external authorization engine to perform authentication policy checks. However, the Golang implementation of Starlark does allow language extensions to be authored in Golang, so it would be theoretically possible for us to create such an extension if desired.
Alternatives Considered

Rego, which is based on Prolog. Unfortunately, the code is unreadable for an average end-user. See this example of Rego code from the OPA documentation: https://www.openpolicyagent.org/docs/latest/#putting-it-together

Release Notes
Release note:
TBD

@neolit123 mentioned that folks upstream had a hard time reading starlark when used with bazel.
CEL might be something to look into.

Closing because this implementation of CEL identity policies and transformations is included in PR #1419.

Closing because this implementation of CEL identity policies and transformations is included in PR https://github.com/vmware-tanzu/pinniped/pull/1419.


Update lib target soversion

Summary of proposed changes:

Update lib target so version format to recommended format - (ex: libmigraphx.so.2.7.0 updated to libmigraphx.so.2.7)

Why are we dropping the patch version?

Why are we dropping the patch version?
Looking latest versions majority of modules are having soversion with major,minor based link names. there are 3 other modules including migraphx were only showing difference by having patch version also. these 4 modules are requested to update using these changes proposed to the recommended soversion format.

The major, minor and patch should be part of the SO major version:
math(EXPR MIGRAPHX_SO_MAJOR_VERSION "(${PROJECT_VERSION_MAJOR} * 1000 * 1000) + (${PROJECT_VERSION_MINOR} * 1000) + ${PROJECT_VERSION_PATCH}")
set(MIGRAPHX_SO_VERSION ${MIGRAPHX_SO_MAJOR_VERSION}.0)

The major, minor and patch should be part of the SO major version:
math(EXPR MIGRAPHX_SO_MAJOR_VERSION "(${PROJECT_VERSION_MAJOR} * 1000 * 1000) + (${PROJECT_VERSION_MINOR} * 1000) + ${PROJECT_VERSION_PATCH}")
set(MIGRAPHX_SO_VERSION ${MIGRAPHX_SO_MAJOR_VERSION}.0)

Or we if we can drop the minor version it could just be:
math(EXPR MIGRAPHX_SO_VERSION "(${PROJECT_VERSION_MAJOR} * 1000 * 1000) + (${PROJECT_VERSION_MINOR} * 1000) + ${PROJECT_VERSION_PATCH}")

I don't see any difference in the EXPRs that you mentioned.

I don't see any difference between the two EXPRs that you mentioned.

One has the version as ${VERSION}.0 and the other is just ${VERSION}.

Are we good to approve this change? Or need further changes here?

Merge conflict and you have not addressed Pauls comments

I don't see any difference between the two EXPRs that you mentioned.

One has the version as ${VERSION}.0 and the other is just ${VERSION}.

The convention for actual library files that we have in ROCm across all the component is to have major.minor.{encoded ROCm version}.
rocm_set_soversion need to pass only major.minor. {encoded ROCm version} is handled by the function and attached as the patch number and ROCm version is passed by the build CI. Hope this clarify why we do not need the patch number passed here.


Regression: v3.2.0 generates warnings in rollup

https://github.com/github/fetch/releases/tag/v3.2.0
https://github.com/github/fetch/pull/794
https://github.com/github/fetch/pull/794/files#diff-37e6c8c3d38d10cb0fc896766eb1b692R4
https://rollupjs.org/guide/en/#error-this-is-undefined

Version 3.2.0 includes a fix for "global" in node environments. Recent versions of rollup enforce a "no top-level this" rule and forces this to be undefined.
I see a message like this:
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
node_modules/whatwg-fetch/fetch.js
2:   return self
3:   // eslint-disable-next-line no-invalid-this
4: })(typeof self !== 'undefined' ? self : this)
                                           ^
5: var support = {
6:   searchParams: 'URLSearchParams' in global,

I'm using Rollup to bundle a polyfill for older browsers.
FWIW, this is the globalThis fallback chain that babel adds to my code any time I use global.
var commonjsGlobal = typeof globalThis !== 'undefined' ? globalThis : typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};

I believe that babel just uses whatever cores-js does for globalThis

The warning is nothing to worry about, all browsers have a global variable named self, which is what is used first, the fallback to this is only for non-browser environments such as NodeJS, where likely a bundler is not being used.


Improve topic "ECMAScript"

Fix short_description
Add information to description
Add related
Add released

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I am not the sole author or employee of a company who created the topic or collection I'm changing.

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[x] Content (and my changes are in index.md)

ECMAScript has different implementations and such

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Or is "ecma-262" more of an alias?

One does what one can


VSCode should detect characters like new line and tab ( \n , \t) in find and replace.

VSCode should detect characters like new line and tab ( \n , \t) in find and replace.
Suppose I want to replace all tabs with new lines then how could I replace it.

Use regex.

Thanks, there is a hidden option in the plain sight in find and replace box to search for Regular Expressions

You're welcome :)


Update cloud-config structs

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
none

/hold
Until we know if this includes all required changes

/lgtm
/approve

/hold cancel


dumps_task in SimpleShuffleLayer and BroadcastJoinLayer unpack

Just a TODO that SimpleShuffleLayer and BroadcastJoinLayer both use dumps_task in their __dask_distributed_unpack__ methods, which leads to pickling on the scheduler, which we want to avoid.
Additionally, could this manual use of pickle.dumps in BroadcastJoinLayer.__dask_distributed_pack__ lead to a double-pickle scenario, where when the task actually gets executed, the kwarg values are bytestrings, not the actual unpickled values: https://github.com/dask/dask/blob/b3a86469cb339767617c03c05e60db101ceb177a/dask/layers.py#L663-L671
Related to https://github.com/dask/distributed/pull/4699.
cc @rjzamora @madsbk

I totally agree that we should try to move away from dumps_task in cases where it requires the task callable  to handle serialization at run time. Just some notes...

which leads to pickling on the scheduler, which we want to avoid.

Right - we would like to avoid any use of pickle on the scheduler (in case pickle is disabled entirely), however the main concern is that we cannot call pickle.loads on the scheduler.  The cases you have highlighted above do not require pickle.loads.

Additionally, could this manual use of pickle.dumps in BroadcastJoinLayer.dask_distributed_pack lead to a double-pickle scenario, where when the task actually gets executed, the kwarg values are bytestrings, not the actual unpickled values

Yes - This is exactly what is expected to happen now.  This is why the functions used within the broadcast-join tasks currently check if anything needs to be unpickled on the worker.  We avoided this issue in Blockwise by relying on to_serialize.


allowing mentor more access to mentee exercise even if they are not done

i have realised you have to finish an exercise before requesting a mentor. this should be changed and mentors should have more access to see the code and alter the code of their mentee.

@Danbaba1 Thanks for leaving a note. The issue you mention was already raised here https://github.com/exercism/exercism/issues/6187 so I will close this one as duplicate. If you have more thoughts on this, feel free to post them in the existing issue.


Question of motion representation

Sorry, I still have a doubt, why not learn the Euler angles of the local rotation in the motion representation, is it because this representation is difficult to learn?

Another problem is that I noticed that when you save bvh, in the code of converting quaternion to Euler angle, the prompt can only be converted to Euler angle in zyx and xzy order, whether it can not be converted to Euler in xyz order horn? I tried to write a conversion process myself (convert the Euler angles in the xyz order to quaternions and then back to the Euler angles in the same order), but it seems that the angle value of the Euler angles has changed? Thank you very much for your patient reply!

Hey cyk,
I think the representations of motion are all right!
For examples, End2End used rotation matrix and Audio2Repr2Gesture used position or exponential maps, QuaterNet used quaternions...
Although these can switch to each other, however, rotation is easy to calculate rotational velocity and acceleration.
Although position, positional velocity, and positional acceleration or rotation and rotational velocity and acceleration are contained to each other, more modalities are better, see https://github.com/sebastianstarke/AI4Animation/issues/47#issuecomment-945189038
That is why Zeroeggs used complex motion representation.
All in all, I think motion representation is not key in gesture generation. You may take some experiments on them.
Wish it will help you : )

The bvh processing pipeline and writing pipeline are the same as Zeroeggs, which is not familiar to me. You may check the source code in Zeroeggs.

Ok, I see, thank you very much for your reply, it helped me a lot.


Using ngx-tour in Angular 6 projects

Could someone guide me on using this library via npm? I find that there are multiple npm packages available.
Do I need to install ngx-tour or ngx-tour-core ?
I see that ngx-tour hasn't been updated since long whereas ngx-tour-core has been recently updated.

There are 4 different ui options for ngx-tour.  This page has a demo for each and the different install instructions for each one.

Each of the ui plugins has a dependency on ngx-tour-core (so you don't have to explicitly install it).  ngx-tour doesn't actually do anything.  It's just a placeholder to stop typo squatting.

Thanks for the clarification.


Implements randomization of cards shown in meetups summary, resources summary and events summary

Completes Issue#299: Randomize getLimitedMeetups.

This is so fun to refresh and see them all change hahaha though I am noticing two things

In the start up edmonton description it says "check the next card" (to see the edmonton unlimited info) so that might have to be re-written to "check the edmonton unlimited card"
I am seeing the first 5 become randomized but I never see any after the first 5 be randomized. Like I never see yegwit show up... Do you? I refreshed quite a few times

@MandyMeindersma: I think I know what the issue is. I'll have to move the logic that limits the events/resources/meet ups to the Summary components for each rather than doing it in the store. I'll resolve the comments either tomorrow or Tuesday evening.

@MandyMeindersma : Regarding the first comment, do we need to keep the Start up Edmonton card if all it says is to check the Edmonton Unlimited card?

We still get a couple questions about what happened to start up edmonton so I like to leave it up there but I feel like I am also a digital hoarder so you can do whatever you feel :)

@MandyMeindersma : I'll leave it for now then. We can remove it later on a separate PR when it's time 🙂.

I'm glad to see that @deejayjay is making headway. I cannot wait to see the final commit.

In the start up edmonton description it says "check the next card" (to see the edmonton unlimited info) so that might have to be re-written to "check the edmonton unlimited card"

My take on this is that removing "See the next card" from "FYI Startup Edmonton has become Edmonton Unlimited and has a new space! See the next card." would be a good way to go since it would not matter which of the two cards (Startup Edmonton + Edmonton Unlimited) comes first in the list since both cards are linked to the same url.

I am seeing the first 5 become randomized but I never see any after the first 5 be randomized. Like I never see yegwit show up... Do you? I refreshed quite a few times

Is it possible to retain the card limit while still allowing all 5+ cards to be randomized into those 5 slots? How are we randomizing them? For meetups, for example, are we randomizing them on the homepage or we are randomizing them at https://devedmonton.com/meetups? I am not yet at that point in my JS journey where I can understand the JS logic in the code 😂 (getting there though🧑💻).

I'm glad to see that @deejayjay is making headway. I cannot wait to see the final commit.

In the start up edmonton description it says "check the next card" (to see the edmonton unlimited info) so that might have to be re-written to "check the edmonton unlimited card"

My take on this is that removing "See the next card" from "FYI Startup Edmonton has become Edmonton Unlimited and has a new space! See the next card." would be a good way to go since it would not matter which of the two cards (Startup Edmonton + Edmonton Unlimited) comes first in the list since both cards are linked to the same url.

I am seeing the first 5 become randomized but I never see any after the first 5 be randomized. Like I never see yegwit show up... Do you? I refreshed quite a few times

Is it possible to retain the card limit while still allowing all 5+ cards to be randomized into those 5 slots? How are we randomizing them? For meetups, for example, are we randomizing them on the homepage or we are randomizing them at https://devedmonton.com/meetups? I am not yet at that point in my JS journey where I can understand the JS logic in the code 😂 (getting there though🧑💻).

@leslietech: The answer your question  Is it possible to retain the card limit while still allowing all 5+ cards to be randomized into those 5 slots? is yes. I am quoting my current team lead here when I say there is always a solution to these problems 😀.
Currently, the logic to limit the number of cards reside in the Pinia store (we use Pinia for state management in Vue/Nuxt applications). I decided to shuffle the cards outside the Pinia store, just in the summary component (this was due to some other technical issue I encountered when I tried to add it in Pinia store). I think I have found a way to get around that technical issue, and can move the shuffling logic to Pinia store as well.
For shuffling, I just used fisher-yates algorithm and used array restructuring in JavaScript to help me with the swapping of array elements.

1. In the start up edmonton description it says "check the next card" (to see the edmonton unlimited info) so that might have to be re-written to "check the edmonton unlimited card"

@MandyMeindersma: I modified the text to this so that users will still know where to go if Edmonton Unlimited card does not show up in the home page when we shuffle the cards:


Email Validation Script #297

Description
A script which checks for Email Address Validity in three simple checks
Fixes #297
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

I made the changes @kaustubhgupta , please review the PR now

@santushtisharma10 @antrikshmisri

@all-contributors please add @saaalik  for code and documentation