Need help with config after 4.0.0 update

Checklist:

[x] I updated to the latest version available
[x] I cleared the cache of my browser

Release with the issue:
4.0.0
Last working release (if known):
3.9.4
Browser and Operating System:
Chrome + Win11

Description of problem:
I have built a card which uses combination of android tv and kodi functions which was a bit tricky but eventually I succeeded and everything works and covers my needs.
Hovever after 4.0.0 several buttons like youtube, spotify, fast_forward, rewind etc.. are not working correctly after update when platform is Kodi and now I am stuck in fixing this.
Below is my original and converted config and also screenshot of card before and after update.
Can anyone help me with that please?

Your Full Remote Config
Working config in 3.9.4
type: custom:android-tv-card
remote_id: remote.chromecast_google_tv
media_player_id: media_player.chromecast_google_tv_kodi
keyboard_id: media_player.chromecast_google_tv_kodi
platform: KODI
autofill_entity_id: true
touchpad_style:
  height: 350px
rows:
  - - search
    - power
  - - vol_buttons
  - - tv
    - youtube
    - spotify
    - kodi
  - - touchpad
  - - rewind
    - play_pause
    - stop
    - fast_forward
  - - back
    - home
    - keyboard
custom_sources:
  kodi:
    icon: mdi:kodi
    source: org.xbmc.kodi
custom_actions:
  power:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Application.Quit
  tv:
    tap_action:
      action: perform-action
      perform_action: media_player.select_source
      target:
        entity_id: media_player.chromecast_google_tv_adb
      data:
        source: cz.sledovanitv.android
  center:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Select
    hold_action:
      perform_action: kodi.call_method
      data:
        method: Input.ContextMenu
    double_tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.ShowOSD
  up:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Up
  down:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Down
  left:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Left
  right:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Right
  back:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Back
  home:
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Home
  textbox:
    icon: mdi:keyboard

Converted config in 4.0.0
type: custom:android-tv-card
remote_id: remote.chromecast_google_tv
media_player_id: media_player.chromecast_google_tv_kodi
keyboard_id: media_player.chromecast_google_tv_kodi
platform: Kodi
autofill_entity_id: true
rows:
  - - search
    - power
  - - volume_buttons
  - - tv
    - youtube
    - spotify
    - kodi
  - - touchpad
  - - rewind
    - play_pause
    - stop
    - fast_forward
  - - back
    - home
    - keyboard
custom_actions:
  - type: button
    name: power
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Application.Quit
      action: perform-action
    icon: mdi:power
  - type: button
    name: tv
    tap_action:
      action: perform-action
      perform_action: media_player.select_source
      target:
        entity_id: media_player.chromecast_google_tv_adb
      data:
        source: cz.sledovanitv.android
    icon: mdi:television-box
  - type: button
    name: center
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Select
      action: perform-action
    icon: mdi:checkbox-blank-circle
    hold_action:
      perform_action: kodi.call_method
      data:
        method: Input.ContextMenu
      action: perform-action
    double_tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.ShowOSD
      action: perform-action
  - type: button
    name: up
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Up
      action: perform-action
    hold_action:
      action: repeat
    icon: mdi:chevron-up
  - type: button
    name: down
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Down
      action: perform-action
    hold_action:
      action: repeat
    icon: mdi:chevron-down
  - type: button
    name: left
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Left
      action: perform-action
    hold_action:
      action: repeat
    icon: mdi:chevron-left
  - type: button
    name: right
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Right
      action: perform-action
    hold_action:
      action: repeat
    icon: mdi:chevron-right
  - type: button
    name: back
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Back
      action: perform-action
    icon: mdi:keyboard-backspace
  - type: button
    name: home
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Home
      action: perform-action
    icon: mdi:home
  - type: button
    name: textbox
    tap_action:
      action: textbox
    icon: mdi:keyboard
  - icon: mdi:kodi
    name: kodi
    tap_action:
      source: org.xbmc.kodi
      action: source
    type: button
  - type: touchpad
    name: touchpad
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Select
      action: perform-action
    up:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Up
        action: perform-action
      hold_action:
        action: repeat
      name: up
      type: button
    down:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Down
        action: perform-action
      hold_action:
        action: repeat
      name: down
      type: button
    left:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Left
        action: perform-action
      hold_action:
        action: repeat
      name: left
      type: button
    right:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Right
        action: perform-action
      hold_action:
        action: repeat
      name: right
      type: button
    styles: |-
      toucharea {
        height: 350px;
      }
    hold_action:
      perform_action: kodi.call_method
      data:
        method: Input.ContextMenu
      action: perform-action
    double_tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.ShowOSD
      action: perform-action

Additional information:
3.9.4

4.0.0

It looks like you're using the Android TV platform sources and media controls, but the Kodi platform keyboard. I'd say you should create custom actions for the sources and media controls and remap them to the default Android TV keys.
The easiest way to go about that is to create a separate remote, set it's platform to Android TV, create custom actions for the keys and sources you want to copy as if you were overwriting default ones, and copy the autofilled default key and source information from those custom actions to this remote.
Try this, I think I got everything:
type: custom:android-tv-card
remote_id: remote.chromecast_google_tv
media_player_id: media_player.chromecast_google_tv_kodi
keyboard_id: media_player.chromecast_google_tv_kodi
platform: Kodi
autofill_entity_id: true
rows:
  - - search
    - power
  - - volume_buttons
  - - tv
    - youtube
    - spotify
    - kodi
  - - touchpad
  - - rewind
    - play_pause
    - stop
    - fast_forward
  - - back
    - home
    - keyboard
custom_actions:
  - type: button
    name: power
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Application.Quit
      action: perform-action
    icon: mdi:power
    entity_id: media_player.chromecast_google_tv_kodi
  - type: button
    name: tv
    tap_action:
      action: perform-action
      perform_action: media_player.select_source
      target:
        entity_id: media_player.chromecast_google_tv_adb
      data:
        source: cz.sledovanitv.android
    icon: mdi:television-box
  - type: button
    name: textbox
    tap_action:
      action: textbox
    icon: mdi:keyboard
    entity_id: media_player.chromecast_google_tv_kodi
  - icon: mdi:kodi
    name: kodi
    tap_action:
      source: org.xbmc.kodi
      action: source
    type: button
  - type: touchpad
    name: touchpad
    tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.Select
      action: perform-action
    up:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Up
        action: perform-action
      hold_action:
        action: repeat
      name: up
      type: button
    down:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Down
        action: perform-action
      hold_action:
        action: repeat
      name: down
      type: button
    left:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Left
        action: perform-action
      hold_action:
        action: repeat
      name: left
      type: button
    right:
      tap_action:
        perform_action: kodi.call_method
        data:
          method: Input.Right
        action: perform-action
      hold_action:
        action: repeat
      name: right
      type: button
    styles: |-
      toucharea {
        height: 350px;
      }
    hold_action:
      perform_action: kodi.call_method
      data:
        method: Input.ContextMenu
      action: perform-action
    double_tap_action:
      perform_action: kodi.call_method
      data:
        method: Input.ShowOSD
      action: perform-action
  - type: button
    name: volume_up
    tap_action:
      action: key
      key: VOLUME_UP
    icon: mdi:volume-high
    hold_action:
      action: repeat
  - type: button
    name: volume_down
    tap_action:
      action: key
      key: VOLUME_DOWN
    icon: mdi:volume-medium
    hold_action:
      action: repeat
  - type: button
    name: volume_mute
    tap_action:
      action: key
      key: VOLUME_MUTE
    icon: mdi:volume-low
    hold_action:
      action: repeat
  - type: button
    name: youtube
    tap_action:
      action: source
      source: vnd.youtube://
    icon: mdi:youtube
  - type: button
    name: spotify
    tap_action:
      action: source
      source: spotify://
    icon: mdi:spotify
  - type: button
    name: rewind
    tap_action:
      action: key
      key: MEDIA_REWIND
    icon: mdi:rewind
  - type: button
    name: play_pause
    tap_action:
      action: key
      key: MEDIA_PLAY_PAUSE
    icon: mdi:play-pause
  - type: button
    name: stop
    tap_action:
      action: key
      key: MEDIA_STOP
    icon: mdi:stop
  - type: button
    name: fast_forward
    tap_action:
      action: key
      key: MEDIA_FAST_FORWARD
    icon: mdi:fast-forward

Thanks I will try this today.
Yes you are correct I am actually using 2 cards (clean Android platform and Kodi platform with mapped Kodi functions) with visibility condition if Kodi is running or not and only problem after conversion I have with the Kodi one.
As mentioned this config I posted was the simplest way I could find to combine Android and Kodi functions as most of the Android functions worked also in Kodi in 3.9.x and basically yes this card main purpose is to have keyboard platform Kodi for seamles keyboard input.

Ok your proviided cofig worked fine, I just did some minor changes and now I am happy again.
I have to say I would probably figured this out myself but to be honest I have completely forgot there are the key actions in android tv remote.
The final result now looks like this:

Android card:
´´´yaml
type: custom:android-tv-card
remote_id: remote.chromecast_google_tv
media_player_id: media_player.chromecast_google_tv
keyboard_id: remote.chromecast_google_tv_adb
rows:

search
power

volume_buttons

tv
youtube
spotify
kodi

touchpad

rewind
channel_up
play_pause
channel_down
fast_forward

back
home
keyboard
custom_actions:

type: button
name: search
tap_action:
action: key
key: SEARCH
icon: mdi:google-assistant
type: button
name: tv
tap_action:
action: perform-action
perform_action: media_player.select_source
target:
entity_id: media_player.chromecast_google_tv_adb
data:
source: cz.sledovanitv.android
icon: mdi:television-box
icon: mdi:kodi
name: kodi
tap_action:
source: org.xbmc.kodi
action: source
type: button
type: touchpad
name: touchpad
tap_action:
action: key
key: DPAD_CENTER
up:
tap_action:
action: key
key: DPAD_UP
hold_action:
action: repeat
type: button
down:
tap_action:
action: key
key: DPAD_DOWN
hold_action:
action: repeat
type: button
left:
tap_action:
action: key
key: DPAD_LEFT
hold_action:
action: repeat
type: button
right:
tap_action:
action: key
key: DPAD_RIGHT
hold_action:
action: repeat
type: button
styles: |-
toucharea {
height: 350px;
}
´´´

Kodi "on" card:
´´´yaml
type: custom:android-tv-card
remote_id: remote.chromecast_google_tv
media_player_id: media_player.chromecast_google_tv_kodi
keyboard_id: media_player.chromecast_google_tv_kodi
platform: Kodi
autofill_entity_id: true
rows:

search
power

volume_buttons

tv
youtube
spotify
kodi

touchpad

rewind
play_pause
stop
fast_forward

back
home
keyboard
custom_actions:

type: button
name: search
tap_action:
action: key
key: SEARCH
icon: mdi:google-assistant
type: button
name: power
tap_action:
perform_action: kodi.call_method
data:
method: Application.Quit
action: perform-action
icon: mdi:power
entity_id: media_player.chromecast_google_tv_kodi
type: button
name: tv
tap_action:
action: perform-action
perform_action: media_player.select_source
target:
entity_id: media_player.chromecast_google_tv_adb
data:
source: cz.sledovanitv.android
icon: mdi:television-box
icon: mdi:kodi
name: kodi
tap_action:
source: org.xbmc.kodi
action: source
type: button
type: touchpad
name: touchpad
tap_action:
perform_action: kodi.call_method
data:
method: Input.Select
action: perform-action
up:
tap_action:
perform_action: kodi.call_method
data:
method: Input.Up
action: perform-action
hold_action:
action: repeat
name: up
type: button
down:
tap_action:
perform_action: kodi.call_method
data:
method: Input.Down
action: perform-action
hold_action:
action: repeat
name: down
type: button
left:
tap_action:
perform_action: kodi.call_method
data:
method: Input.Left
action: perform-action
hold_action:
action: repeat
name: left
type: button
right:
tap_action:
perform_action: kodi.call_method
data:
method: Input.Right
action: perform-action
hold_action:
action: repeat
name: right
type: button
styles: |-
toucharea {
height: 350px;
}
hold_action:
perform_action: kodi.call_method
data:
method: Input.ContextMenu
action: perform-action
double_tap_action:
perform_action: kodi.call_method
data:
method: Input.ShowOSD
action: perform-action
type: button
name: volume_up
tap_action:
action: key
key: VOLUME_UP
hold_action:
action: repeat
icon: mdi:volume-high
type: button
name: volume_down
tap_action:
action: key
key: VOLUME_DOWN
hold_action:
action: repeat
icon: mdi:volume-medium
type: button
name: volume_mute
tap_action:
action: key
key: VOLUME_MUTE
icon: mdi:volume-low
hold_action:
action: repeat
type: button
name: youtube
tap_action:
action: source
source: vnd.youtube://
icon: mdi:youtube
type: button
name: spotify
tap_action:
action: source
source: spotify://
icon: mdi:spotify
type: button
name: rewind
tap_action:
action: key
key: MEDIA_REWIND
icon: mdi:rewind
type: button
name: play_pause
tap_action:
action: key
key: MEDIA_PLAY_PAUSE
icon: mdi:play-pause
type: button
name: stop
tap_action:
action: key
key: MEDIA_STOP
icon: mdi:stop
type: button
name: fast_forward
tap_action:
action: key
key: MEDIA_FAST_FORWARD
icon: mdi:fast-forward
´´´


[FLINK-12720][python] Add the Python Table API Sphinx docs

What is the purpose of the change
As the Python Table API is added, we should add the Python Table API Sphinx docs. This includes the following work:
Add scripts to build the Sphinx docs
Brief change log

Support Sphinx to create Flink Python Docs
Correct doc code style of Python code

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)

I check it again, I found that Java and Scala Doc are built by BuilderBot(https://ci.apache.org/projects/flink/), The BuilderBot need a config flink.conf, and this config pleased svn repo. So we can do the copy logic change in a new PR. :) @HuangXingBo

Thanks a lot for @dianfu @sunjincheng121.

I add logic about sphinx installed and check in lint-python.sh.
I add a generate-docs.sh responsible for call the script lint-python.sh to generate python api docs and copy the api docs to the specified target path.

@dianfu Thanks for helping improve the PR! @HuangXingBo told me he is on the vacation cannot update the PR those days, he also agrees that if you want to help him, you can open a new PR with @HuangXingBo 's commit as a basic commit.  What do you think?

@sunjincheng121 Thanks a lot for the suggestion. Makes sense to me and I have created PR #8774 based on @HuangXingBo 's great work.

Thanks for your effort @HuangXingBo! and Thanks for open the new PR @dianfu!
I close this PR and review the new one. :)


Fix fundamental type misuse in math arguments

A handful of the core math classes were using their fundamental type arguments inappropriately, generally through unnecessary const and/or passing by reference. This PR sweeps through all those files, ensuring fundamental type arguments aren't const & get passed by value (unless deliberately functioning as an "out" reference). Besides that, the only other change made is to Vector3's snap and snapped functions to fix the opposite issue, where Vector3 wasn't passed by reference previously.

Duplicate of:

https://github.com/godotengine/godot/pull/88467

One of these days I'll remember to actually check other PRs


fix appendScalacOptions, unfork scala-js

green run at
https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/161/consoleFull
well, it's still running, but scala-js is green, and I see the right
commands in the dump at the top of the run. works for me

(approach here is the same as used in RP)


WinHttpTransport GetRawResponse should be ExtractRawResponse

The private member is taking the raw response so it should be Extract since it takes over ownership of the memory.
std::unique_ptr<RawResponse> GetRawResponse(
    std::unique_ptr<Details::HandleManager> handleManager,
    HttpMethod requestMethod);

I don't understand what you mean here about taking ownership.
The GetRawResponse method in the transport talks to the azure service and creates a RawResponse object to give to the caller. I don't think extract makes sense in this case.
Since the transport adapter's Send method is creating the object from scratch and giving it as unique ptr to the caller, the current name seems fine to me (especially since its private).

Based on what you mentioned @ahsonkhan , it would be better to name it Send()  or OnSend().
Even though it is private, it end up being misleading because we use Get....() for method on containers or wrappers like Response, Operation, Request, etc.  Containers which would return a copy or reference to its encapsulated state or Extract...() to give up state.
Would you agree on updating the name to OnSend() or something else?
I agree with you about Extract does not make sense for Transport since it's not a container, but Get... is also not a good name


bump golang.org/x/text dependency to fix CVE-2021-38561

Fixes CVE-2021-38561 by bumping golang.org/x/text dependency to most recent
Fixes https://cve.report/CVE-2021-38561 / https://deps.dev/advisory/OSV/GO-2021-0113. Seems to build and test fine.
Finding came up in automated source code checks.
Make sure that you've checked the boxes below before you submit PR:

[n/a] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Coverage remained the same at 75.136% when pulling 250222097c76e8ab84d8bc0700026cb4500e5204 on CrawX:CVE-2021-38561 into 88976f39f600bb3979de1ae5efdfd9cff2cf10f1 on go-playground:master.

Any update on when this will be going in?

@deankarn can you merge this? We have our microservices relying on this api but cannot go into prod with having this vulnerability in here

I’ll try to take a look at this tomorrow, however, FWIW I’m almost 100% sure this is not exploitable through this package.

@BenHall-1 why don't you override the dependency in your project, eg go get<EMAIL_ADDRESS>I'm not saying this shouldn't be merged but this should not block you :)


Toyota: Only use gas interceptor under 19 mph

Above 19 mph, the min ACC speed for most older Corollas, we switch from sending a gas command (which isn't what the longcontrol loop is set up to do) to sending acceleration, just like if we didn't have a comma pedal installed.
This fixes:

oscillations that occurred above 19 mph due to the longcontrol loop being set up to control acceleration, but was actually being sent as a gas percentage
late braking when lead slows down quickly, or with large speed differences (sometimes causing fcw). previously different pedal tuning was used which affected braking when it shouldn't have.

Also declared stop_and_go to start as true which removes some duplicate lines in interface
What still needs to be done:

[ ] when engaging at a stop with no lead (or even with a lead), gas is jerky and uncomfortable.

I used to think that it was hitting the planner acceleration limit, but now I think it's caused by the controller being set up to output acceleration instead of gas. For example, we start by commanding some small amount of acceleration from a stop, which a sng car would reach quite quickly and smoothly, but since it's actually a gas value, the output isn't enough to reach the speed/accel quick enough. Then either integral or the MPC commands a burst of "acceleration" to get us up to speed causing overshoot and then braking. I still need to download the logs and look at the data to know for sure, since you can't see any of that in Cabana

This is what accelerating from a stop with no lead looks like: https://i.imgur.com/LAxVm5h.png

Yep, I was wrong initially when I thought it was hitting the planner acceleration limit! It's commanding a constant speed and acceleration with no oscillation: https://imgur.com/a/4zdmih4
Meanwhile here's proportional and integral over the same period, prop seems to be causing most of the jerking: https://i.imgur.com/j4O2n6h.png

Yep, I was wrong initially when I thought it was hitting the planner acceleration limit! It's commanding a constant speed and acceleration with no oscillation: https://imgur.com/a/4zdmih4
Meanwhile here's proportional and integral over the same period, prop seems to be causing most of the jerking: https://i.imgur.com/j4O2n6h.png

I think it would be great if you can fix pedal jerk universally for both Honda and Toyota in general instead of having it switch to accel above 19mph on Toyotas.
On Nidec Hondas, it's preferable to use the pedal for accel at all speeds due to it being direct control versus sending the PCM a set speed and desired accel (causes lots of jerk/inaccuracies!) I see how for Toyota the easier thing would be to stop using pedal above a certain speed since the Toyota accel command is nice when it can be used, but if we want one universal pedal fix; getting rid of the oscillation in the controller seems like a better thing to fix to me.

I think it would be great if you can fix pedal jerk universally for both Honda and Toyota in general instead of having it switch to accel above 19mph on Toyotas.
On Nidec Hondas, it's preferable to use the pedal for accel at all speeds due to it being direct control versus sending the PCM a set speed and desired accel (causes lots of jerk/inaccuracies!) I see how for Toyota the easier thing would be to stop using pedal above a certain speed since the Toyota accel command is nice when it can be used, but if we want one universal pedal fix; getting rid of the oscillation in the controller seems like a better thing to fix to me.

With the Honda Nidec, I see in carcontroller it says it's sending a brake command, is that actually the brake in terms of 0 to 1 being 0 to 100% brake, or is that desired deceleration? Also without a pedal, Honda Nidec can brake but not accelerate? I don't know too much about how the Honda systems work or their intricacies yet.
In order to have openpilot produce a gas value instead of an acceleration, I think it would require mimicking how the Toyota's ACC system works where you give it a desired acceleration (negative or positive) and there's another control mechanism that keeps the car at or matches that acceleration. But since the longcontrol pif loop is set up to output acceleration instead of gas and brake it inherently introduces oscillation as there's no feedforward component to constantly apply gas or brake to keep us at the desired speed.
Immediately I'm thinking we'd need a second controller that takes the acceleration from longcontrol and converts it into gas and brakes, with some sort of function that can produce a gas value given acceleration, speed, and maybe incline of the road. So for ex. if des. acceleration is 0, speed is 20 mph, inclination is 0, the output would need to be some constant gas value instead of 0.
But then since Toyota can't send brake directly (as far as I can see from toyota/carcontroller) and only deceleration, it would need to be able to switch seamlessly from using the secondary gas loop to the original longcontrol loop.
This is all just brainstorming, I first just want to understand how the Toyota system works with acceleration, hills, wind drag, etc. so I'll go and try to test some things when I get some time here

With the Honda Nidec, I see in carcontroller it says it's sending a brake command, is that actually the brake in terms of 0 to 1 being 0 to 100% brake, or is that desired deceleration? Also without a pedal, Honda Nidec can brake but not accelerate? I don't know too much about how the Honda systems work or their intricacies yet.
In order to have openpilot produce a gas value instead of an acceleration, I think it would require mimicking how the Toyota's ACC system works where you give it a desired acceleration (negative or positive) and there's another control mechanism that keeps the car at or matches that acceleration. But since the longcontrol pif loop is set up to output acceleration instead of gas and brake it inherently introduces oscillation as there's no feedforward component to constantly apply gas or brake to keep us at the desired speed.
Immediately I'm thinking we'd need a second controller that takes the acceleration from longcontrol and converts it into gas and brakes, with some sort of function that can produce a gas value given acceleration, speed, and maybe incline of the road. So for ex. if des. acceleration is 0, speed is 20 mph, inclination is 0, the output would need to be some constant gas value instead of 0.
But then since Toyota can't send brake directly (as far as I can see from toyota/carcontroller) and only deceleration, it would need to be able to switch seamlessly from using the secondary gas loop to the original longcontrol loop.
This is all just brainstorming, I first just want to understand how the Toyota system works with acceleration, hills, wind drag, etc. so I'll go and try to test some things when I get some time here

Yes, we have control of braking as deceleration on Nidec, but not positive accel. pedal works well at highway speeds but has crazy oscillation at low speeds probably the same as Toyota due to the reasons you mentioned above.

Yes, we have control of braking as deceleration on Nidec, but not positive accel. pedal works well at highway speeds but has crazy oscillation at low speeds probably the same as Toyota due to the reasons you mentioned above.

I imagine you have the slow oscillation at high speeds as well due to no feedforward adding constant gas to keep those speeds. So it's the same as Toyota? Acceleration is gas commands but brake is (de)acceleration commands? That at least unifies the problem a bit.
The tricky part is switching between those two inherently different types of control. For example, acceleration output from longcontrol could be positive, but we might want to brake in certain situations, and vice versa.

I imagine you have the slow oscillation at high speeds as well due to no feedforward adding constant gas to keep those speeds. So it's the same as Toyota? Acceleration is gas commands but brake is (de)acceleration commands? That at least unifies the problem a bit.
The tricky part is switching between those two inherently different types of control. For example, acceleration output from longcontrol could be positive, but we might want to brake in certain situations, and vice versa.

Can we merge this PR to get rid of the slow oscillation at high speeds for pedal users in the next release? Then I can take a look at outputting gas values later in another PR. I almost think it would need to be either model-specific, or make-specific in the least, since we're converting from acceleration to a raw gas percentage applied to the pedal. Previously we relied on the car to come up with this, so I feel like each car or make would need slightly different tuning

Can we merge this PR to get rid of the slow oscillation at high speeds for pedal users in the next release? Then I can take a look at outputting gas values later in another PR. I almost think it would need to be either model-specific, or make-specific in the least, since we're converting from acceleration to a raw gas percentage applied to the pedal. Previously we relied on the car to come up with this, so I feel like each car or make would need slightly different tuning

I fit a simple function based on me manually driving around disengaged, I made sure the user's gas is the same value as what it shows when openpilot is in control. Anyway, I need to correct for the delay from pressing gas to reaching the correct acceleration, like an actuator delay, but this is some comparison data: https://imgur.com/a/CFqRlI0
It didn't make sense to just transform feedforward, as I realized kp and ki are tuned for acceleration in mind as well, so once I put the entirety of the PIF loop into the accel to gas function, sng is much better than before.

I fit a simple function based on me manually driving around disengaged, I made sure the user's gas is the same value as what it shows when openpilot is in control. Anyway, I need to correct for the delay from pressing gas to reaching the correct acceleration, like an actuator delay, but this is some comparison data: https://imgur.com/a/CFqRlI0
It didn't make sense to just transform feedforward, as I realized kp and ki are tuned for acceleration in mind as well, so once I put the entirety of the PIF loop into the accel to gas function, sng is much better than before.

Some of the stuff I'm doing here is wrong (like converting accel to gas percentage before it gets clipped in longcontrol assuming it's accel rather than gas), I just took a break from working on this. I'll fix and clean it up soon once I get a clean way of converting accel to gas that works for most cars with pedal.


feat/make the >> and << in their bar but not in the main part

and it should in the correct direction.


The extension doesn't connects to Svelte (3.12.1)

Steps to reproduce:

install the extension (from v2 release)
clone and install Sapper Template

npx degit "sveltejs/sapper-template#rollup" my-app
npm i

run the app

npm run dev

navigate to localhost:3000
goto Svelte panel
reload the page
constat that the panel still says "Refresh the page to connect to svelte."

I tested on Chrome and FIrefox, the result is the same

In Firefox, there's an error message in console: "=TypeError: blockId is undefined (privilegedContent.js:291:23)

Did I missed something ?
Any help would be really welcome ! Thanks

I believe this is caused by attempting to use an old version of svelte-devtools with the newer svelte. Try the latest release.

Thanks for your answer.
As I said in the first step I installed svelte-devtools from https://github.com/RedHatter/svelte-devtools/releases/tag/v0.2.0. Is this the last version ? I'll try with the version from git repo

I tried to build the extension from master and appart from a SyntaxError: The requested module 'fs' does not provide an export named 'promises' that I solved following this, I succeded using it.

in Firefox installing it as a temporary module, this works :+1:
in Chome it complained about not found icons, but this works after removing icons from manifest

So you were right, the issue were a the "v2" release doesn't seems to work well with Svelte 3.12.1.
Maybe you should publish a new release to match what it's said in README ?
Thanks

@brunetton I solved the error with promises by using node 12 (nvm use 12)

@brunetton I did publish a new release. version 1.0.0

@RedHatter thanks ! It works great with Chrome and Firefox 👍


Support for .NET 6?

Hi, is there any plan for official support of .NET 6.0?
In README of your project you mentioned only these versions of .net ( .NET 5.0, .NET Core 3.1, .NET Framework 4.5, and .NET Standard 2.1.).
Is there any problem with retargeting to .NET 6?

Hi @dalibor-florian,
ClearScript does support .NET 6.0. It doesn't target .NET 6.0 because it doesn't use any 6.0-specific platform features.
Thanks!

Thanks for response.  Would it be possible to change it in readme?
Currently there is info 'Support for .NET 5.0', i found it a bit confusing if you are saying that ClearScript supports also .NET 6.0.

Hi @dalibor-florian,
We've changed the text to: Support for .NET 5.0+, .NET Framework 4.5+, .NET Core 3.1, and .NET Standard 2.1.
Thank you!


Implementation specs

Migrated from GitLab: https://gitlab.com/meltano/handbook/-/issues/57
Originally created by @therebbie on 2022-02-02 15:32:02

We need a process on when to write specs, consolidate them, etc. This would be a paragraph or bullet point or two on how engineering plans to tackle it.
It should happen at the same time as we assign a weight.
/cc: @aaronsteers

View 7 previous comments from the original issue on GitLab


Split reducers.js into, well, reducers

As the name suggests, we should have >1 reducers, but now we have one huge switch statement and it bothers me.

I agree with this. Just let me know what will be the different reducers names first :)

I think conceptually reducers should map to different views of the app, so I guess we might have LibraryReducer, SettingsReducer, and so on.

Before working on it, please list them exactly ^^

@KeitIG how about this:
- IndexReducer | RootReducer
  - PlayerReducer
    - APP_REFRESH_LIBRARY
    - APP_REFRESH_CONFIG
    - APP_SELECT_AND_PLAY
    - APP_FILTER_SEARCH
    - APP_PLAYER_TOGGLE
    - APP_PLAYER_PLAY
    - APP_PLAYER_PAUSE
    - APP_PLAYER_STOP
    - APP_PLAYER_NEXT
    - APP_PLAYER_PREVIOUS
    - APP_PLAYER_JUMP_TO
    - APP_PLAYER_SHUFFLE
    - APP_PLAYER_REPEAT
  - QueueReducer
    - APP_QUEUE_PLAY
    - APP_QUEUE_CLEAR
    - APP_QUEUE_REMOVE
    - APP_QUEUE_ADD
    - APP_QUEUE_ADD_NEXT
    - APP_QUEUE_SET_QUEUE
  - LibraryReducer
    - APP_LIBRARY_ADD_FOLDERS
    - APP_LIBRARY_REMOVE_FOLDER
    - APP_LIBRARY_RESET
    - APP_LIBRARY_REFRESH_START
    - APP_LIBRARY_REFRESH_END
    - APP_LIBRARY_REFRESH_PROGRESS
    - APP_LIBRARY_SET_TRACKSCURSOR
  - NotificationsReducer
    - APP_PLAYLISTS_REFRESH
    - APP_PLAYLISTS_LOAD_ONE
  - PlaylistsReducer
    - APP_NOTIFICATION_ADD
    - APP_NOTIFICATION_REMOVE

Not sure where to put
- APP_REFRESH_LIBRARY
- APP_REFRESH_CONFIG
- APP_SELECT_AND_PLAY
- APP_FILTER_SEARCH

maybe AppReducer?

I'm finally here !
APP_REFRESH_LIBRARY -> AppReducer
APP_REFRESH_CONFIG  -> AppReducer
APP_SELECT_AND_PLAY -> LibraryReducer
APP_FILTER_SEARCH   -> LibraryReducer

I think it would be good with that ftm :)
and you switched NotificationsReducer and PlaylistsReducer ;)

For the record:
- RootReducer
  - AppReducer
    - APP_REFRESH_LIBRARY
    - APP_REFRESH_CONFIG
  - PlayerReducer
    - APP_PLAYER_TOGGLE
    - APP_PLAYER_PLAY
    - APP_PLAYER_PAUSE
    - APP_PLAYER_STOP
    - APP_PLAYER_NEXT
    - APP_PLAYER_PREVIOUS
    - APP_PLAYER_JUMP_TO
    - APP_PLAYER_SHUFFLE
    - APP_PLAYER_REPEAT
  - QueueReducer
    - APP_QUEUE_PLAY
    - APP_QUEUE_CLEAR
    - APP_QUEUE_REMOVE
    - APP_QUEUE_ADD
    - APP_QUEUE_ADD_NEXT
    - APP_QUEUE_SET_QUEUE
  - LibraryReducer
    - APP_SELECT_AND_PLAY
    - APP_FILTER_SEARCH
    - APP_LIBRARY_ADD_FOLDERS
    - APP_LIBRARY_REMOVE_FOLDER
    - APP_LIBRARY_RESET
    - APP_LIBRARY_REFRESH_START
    - APP_LIBRARY_REFRESH_END
    - APP_LIBRARY_REFRESH_PROGRESS
    - APP_LIBRARY_SET_TRACKSCURSOR
  - PlaylistsReducer
    - APP_PLAYLISTS_REFRESH
    - APP_PLAYLISTS_LOAD_ONE
  - NotificationsReducer
    - APP_NOTIFICATION_ADD
    - APP_NOTIFICATION_REMOVE


Typescript allows assigning anything to Record<number, ...>

🔎 Search Terms
assigning to record number
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.0-beta#code/MYewdgzgLgBCBGArGBeGBvGEQFsCmUAFgJZgDmAXDAETQBO1MAvgLABQoksdewVASrxB0AJgB4wAVxzw8dADRYodUmQB8qOEiA
💻 Code
const obj = { something: "str" }
const rec: Record<number, string> = obj

🙁 Actual behavior
No error
🙂 Expected behavior
It should error as "something" is not of type number

This is working as intended. The type Record<number, string> means that all number keys are string, not that only number keys exists. You can't limit the existence of additional properties.

Duplicate of #45727.


ET_Builder_Element::get_media_query() for tablet and phone

Problem Description
In the react component, we can declare CSS for certain devices:
additionalCss.push([{
    selector: '%%order_class%% .my_element',
    declaration: `margin-top: ${my_margin_tablet[0]}; margin-right: ${my_margin_tablet[1]}; margin-bottom: ${my_margin_tablet[2]}; margin-left: ${my_margin_tablet[3]};`,
    **device: 'tablet',**
}]);

But in php we use media queries:
ET_Builder_Element::set_style($render_slug, array(
    'selector' => $class,
    'declaration' => et_builder_get_element_style_css($my_margin_tablet, $type, $important),
    'media_query' => ET_Builder_Element::get_media_query('max_width_980'),
));

I believe in both worlds we should get both tools. So in ET_Builder_Element::get_media_queries() we simply could add tablet and phone like so:
$media_queries = array(
    'min_width_1405' => '@media only screen and ( min-width: 1405px )',
    '1100_1405'      => '@media only screen and ( min-width: 1100px ) and ( max-width: 1405px)',
    '981_1405'       => '@media only screen and ( min-width: 981px ) and ( max-width: 1405px)',
    '981_1100'       => '@media only screen and ( min-width: 981px ) and ( max-width: 1100px )',
    'min_width_981'  => '@media only screen and ( min-width: 981px )',
    'max_width_980'  => '@media only screen and ( max-width: 980px )',
    'tablet'  => '@media only screen and ( max-width: 980px )',
    '768_980'        => '@media only screen and ( min-width: 768px ) and ( max-width: 980px )',
    'max_width_767'  => '@media only screen and ( max-width: 767px )',
    'phone'  => '@media only screen and ( max-width: 767px )',
    'max_width_479'  => '@media only screen and ( max-width: 479px )',
);

Or by simply adding the 'device' => 'phone' (or 'tablet') option to the option array of set_style().
In react there should be the option 'media_query' or the option to use the media query names in the 'device' option.
Personally I'd love to see 'media_query' option in react and 'device' option in php.

QA Checklist
Reporter

[x] Helpful title used
[ ] Detailed description

Description should usually be 150+ characters.

[ ] Steps to reproduce included
[ ] Support Ticket URL included
[ ] Image and/or gif

Developer

[ ] Steps to reproduce proven solved
[ ] Test included and coverage acceptable and all Tests passing?
[ ] PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Estimated points on issue
[ ] Proper code documentation and conventions?
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Peer Review

[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Steps to reproduce proven solved
[ ] Affected areas are tested and ok
[ ] Proper code documentation and conventions
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Quality Assurance

[ ] All tests passed on CircleCI.
[ ] Steps to reproduce passed, the fix works.
[ ] No errors in console or output
[ ] Affected areas are tested and ok
[ ] The fix does not change a customer's website in any surprising or unintended way

[ ] If Divi's design is adjusted, settings are migrated gracefully and invisibly

Design Review

[ ] UI is to spec
[ ] UX is to spec
[ ] Design is to spec
[ ] No surprising visual changes to a customer's website will be experienced after updating

[ ] Any/all visual changes are migrated gracefully

Dev Review

[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?
[ ] i18n used if applicable
[ ] Implementation acceptable, DRY, Scaleable, future safe
[ ] Best practices used, cleverness and grokage, ES6 use, etc.


make stderr red

Hey @nov, thanks for the contribution. This isn't the defined behavior of terminals and would interfere with people's custom coloring of output (with terminal codes for example), so I can't merge this. Truly sorry.


[Issue] Azd provision fails saying still provisioning from last provision which failed on postprovision script

I'm trying to provision this branch. Since the infra has a postprovision script which uses az cli, I have the following steps:

azd provision -> fails on postprovision saying az cli auth error
azd config set auth.useAzCliAuth true -> success
az login -> success
azd provision -> fails with

ERROR: deployment failed: failing invoking action 'provision', error deploying infrastructure: deploying to subscription:

Deployment Error Details:
DeploymentActive: Unable to edit or replace deployment 'postgresql': previous deployment from '11/15/2023 12:46:43 AM' is still active (expiration time is '11/22/2023 12:45:37 AM'). Please see https://aka.ms/arm-deploy-resources for usage details.

TraceID: 403e06871d2d09afa9854bc70537cbd5

Entire script is:
@dfberry ➜ /workspaces/contoso-real-estate (dfberry/1112-01) $ azd provision

Provisioning Azure resources (azd provision)
Provisioning Azure resources can take some time.

Subscription: Visual Studio Enterprise Subscription (b57b253a-e19e-4a9c-a0c0-a5062910a749)
Location: West Europe

  You can view detailed progress in the Azure Portal:
  https://portal.azure.com/#view/HubsExtension/DeploymentDetailsBlade/~/overview/id/%2Fsubscriptions%2Fb57b253a-e19e-4a9c-a0c0-a5062910a749%2Fproviders%2FMicrosoft.Resources%2Fdeployments%2Fdfberry-1114-515893df-1700009174

  (✓) Done: Resource group: rg-dfberry-1114-515893df
  (✓) Done: Log Analytics workspace: log-dd57syhnhunji
  (✓) Done: Key Vault: kv-dd57syhnhunji
  (✓) Done: Storage account: stdd57syhnhunji
  (✓) Done: App Service plan: plan-dd57syhnhunji
  (✓) Done: Static Web App: stapp-web-dd57syhnhunji
  (✓) Done: Azure Database for PostgreSQL flexible server: psql-db-dd57syhnhunji
  (✓) Done: Application Insights: appi-dd57syhnhunji
  (✓) Done: Portal dashboard: dash-dd57syhnhunji
  (✓) Done: Azure Cosmos DB: cosmos-dd57syhnhunji
  (✓) Done: Container Apps Environment: cae-dd57syhnhunji
  (✓) Done: Container Registry: crdd57syhnhunji

ERROR: deployment failed: failing invoking action 'provision', error deploying infrastructure: deploying to subscription:

Deployment Error Details:
DeploymentActive: Unable to edit or replace deployment 'postgresql': previous deployment from '11/15/2023 12:46:43 AM' is still active (expiration time is '11/22/2023 12:45:37 AM'). Please see https://aka.ms/arm-deploy-resources for usage details.

TraceID: 403e06871d2d09afa9854bc70537cbd5
@dfberry ➜ /workspaces/contoso-real-estate (dfberry/1112-01) $

Please review the deployment progress link in the Azure Portal to check to see if the postgresql resource is still actively running.  azd will throw an error if any of the deployments are still active.

@dfberry, it might be too late now, but you can use azd hooks run postprovision to just run the postprovision hook without running provision all over again.  The azd hooks run <hookName> can help on this cases (if provision had no issues) to just resume the operation.

@dfberry, it might be too late now, but you can use azd hooks run postprovision to just run the postprovision hook without running provision all over again. The azd hooks run <hookName> can help on this cases (if provision had no issues) to just resume the operation.

@dfberry did you try the suggestion above?


Setting tab titles from the command line

Page 89:
From the command line:
wt.exe -p "PowerShell" --title "This one is PowerShell";new-tab -p "Ubuntu-20.04" --title "WSL here!"
From Powershell:
wt.exe -p "PowerShell" --title "This one is PowerShell"`;new-tab -p "Ubuntu-20.04" --title "WSL here!"
Do not appear to change the title of the Ubuntu tab.
Per Rename tab title not working for WSL and Bash #5333 Closed  "Turn on the suppressApplicationTitle option. The "tab title" is a recommendation, and the application can delete it if it wants to. Bash usually does. supressApplicationTitle overrides bash."
The following change in settings.json worked for me:
{
  "guid": "{07b52e3e-de2c-5db4-bd2d-ba144ed6c273}",
  "hidden": false,
  "name": "Ubuntu-20.04",
  "source": "Windows.Terminal.Wsl",
  "suppressApplicationTitle": true
},

Thanks, @Carl-Ty! It looks like this behaviour has changed since I tested the scripts in the book and will be one to revisit if there's another edition 😄

So what command executed in Ubuntu will change Ubuntu terminal title ? I am asking because i have like 10 tabs open and all of them starts like<EMAIL_ADDRESS>and rest is hidden. Renaming tabs manually works but i would rather automate that
I tried following options, none of them worked:
echo -ne "\033]0;foo\007"
bash -c 'echo -ne "\033]0;foo\007"'

Thx

I'd suggest testing the command here: https://docs.microsoft.com/en-us/windows/terminal/tutorials/tab-title#set-the-shells-title
Also, if you're using Windows Terminal, check that you haven't got suppressApplicationTitle set.

I just set "suppressApplicationTitle": false,
And used https://github.com/trystan2k/zsh-tab-title
With windows terminal and OhMyZSH this works flawlessly


[ARM BugBash] Include instructions/links for configuring defaults for Azure CLI

az login, az configure defaults, etc.
[bug]

Resovled.


Not working inside the modal on android

Hi, I am using the range slider inside the modal and its not drag able on android but on ios it works fine tell me what to do.

Hi,
I had the same problem. I didn't manage to solve it.
You can do one of the following:
1- change the modal to be a screen (what I eventually did)
2- change the modal to be View with Stylesheet.absoluteFill
3- use other range slider that does work inside a modal


Use must_use on struct impl 'new' functions

I suspect we should just stick to clippy-inspired changes as you say. Dropping.


Update Swift4.0 from master

👋
We still got the crash #14 (fixed by #15). It's due to the fact that we are on Swift 4.0. So, I merged master back to swift4.0

Hmm… I can’t reproduce the error. 🤔 how do i reproduce the error?

@koogawa see #14
You already fixed this, but is wasn't ported to the swift4.0 branch, so I just merged master into swift4.0

@Francescu  I get it. thanks 😄


tcpassembly questions

Hi,
Have several questions related to tcpassembly, could you please help out here ?

What is the difference between assembly/tcpassembly.go and tcpassembly/assembly.go ? It appears they are doing the same thing ?
May i ask what is the benefit to make StreamPool multiple threads safe as the Assembler itself is not ?  It appears to me if we make StreamPool NOT multiple threads safe, and allocate one StreamPool for each Assembler, we can save quite a few lock/unlock cpu cycles ? i don't see the benefits of sharing a StreamPool with multiple Assembler in different go routines as it has lock/unlock etc contention ? Same questions for the lock in IPv4Defragmenter

Thanks so much !

Hi,

Answer is here #554 and #486 . Basically, reassembly is the newer version of tcpassembly.
The older version is uni-directional, whereas the new one has bi-directional streams.

In my opinion, having StreamPool as thread safe, is helpful when we have packets belonging to one stream, somehow, go into different Assemblers. Because, if each Assembler had its own StreamPool, then they would each create a separate Stream instance, for actually the same stream, and they would never be able to reassemble the data then. This can be the case, when there is no traffic balancing between those Assemblers. Typically, you would have those Assemblers run on different goroutines which accept packets.

P.S.
i am not a maintainer, just sharing my view.


Enhance button-variant mixin to accept disable styles

Our styles require us that all buttons end up with the same disable style:

The current implementation of the disable state is based on the button background. Each button has its own disable state that is a lighter version of the regular button background color:

Would you consider accepting a PR that enhances the button-variant mixin in a backward compatible way to allow for such extensibility?
This is what I have in mind:
Current:
@mixin button-variant(
    $background, $border,
    $hover-background: darken($background, 7.5%), $hover-border: darken($border, 10%),
    $active-background: darken($background, 10%), $active-border: darken($border, 12.5%)) {

    ...
    &.disabled,
    &:disabled {
      color: color-yiq($background);
      background-color: $background;
      border-color: $border;
    }
    ...
}

Proposed:
@mixin button-variant(
    $background, $border,
    $hover-background: darken($background, 7.5%), $hover-border: darken($border, 10%),
    $active-background: darken($background, 10%), $active-border: darken($border, 12.5%),
    $disabled-background: $background,
    $disabled-border: $border,
    $disabled-color: color-yiq($background)) {

    ...
    &.disabled,
    &:disabled {
      color: $disabled-color;
      background-color: $disabled-background;
      border-color: $disabled-border;
    }
    ...

}

No plans to change our mixins at this point. We use a slightly different approach that conflicts with this and would create a decent amount of new code.


Refactor commission model class hierarchies

This PR adds a feature for subclassing EquityCommissionModel and FutureCommissionModel together and getting the expected behavior that it supports both equities and futures. See https://github.com/quantopian/zipline/pull/1767 for reference on how this was done for slippage.
This PR also makes PerTrade support futures.

Coverage increased (+0.0008%) to 87.738% when pulling 43d1af02408be3f58960a91ee9915dd3b46700a3 on more-commission-cleanup into c20807a0c76af162de2ee9715230c3d934259be2 on master.


Some refactoring

Clean up and minimize imports
Introduce FreeS.pure (as alternative for Applicative[FreeS[F, ?].pure)
Fixed Capture instance for monix' Task
Renamed / created / removed some folders to match the respective package names.

Codecov Report

Merging #108 into master will increase coverage by 2.7%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #108     +/-   ##
=========================================
+ Coverage   72.75%   75.46%   +2.7%
=========================================
  Files          29       29
  Lines         279      269     -10
  Branches        2        2
=========================================
  Hits          203      203
+ Misses         76       66     -10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88403bc...dade94c. Read the comment docs.


Why i can't disable 'formatOnSave'!!!!!!!

Why i can't disable 'formatOnSave'!!!!!!! Untill i uninstall it!!

I disabled it by pressing F1 > Formatter Config:
Then edit formatter.json: modify the line "onSave" to false.

Hi there! same issue here!
The onSave: false do nothing... every edition on file format it and place the cursor at the end of file....
Very useless thing....


chore(package): update npm-template-sync to version 7.13.1

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: reset password token

Description
Create a backend endpoint that allows users to reset their password using a secure token received via email. The endpoint should validate the token, accept the new password, and update the user’s credentials in the database.
Changes made

Created POST request endpoint to reset the password with a new password
Created resetPassword method in the user service implementation class for the business logic

How to test
Endpoint
/api/v1/auth/reset-password/{token}
Request Body
{
    "new_password":"Password321"
}

Response
"Password Reset Successful"
Linked issue
The feature is linke to the issue

@Am0du @Adewale66 @Fifetoyi please review

@lurldgbodex @gurumarv @Fifetoyi please review and merge

you have conflict

Conflict resolved @Am0du

@lurldgbodex resolved


Azure Synapse - Configure Azure ML and Azure Synapse Analytics  does not exist in the notebooks blade

In Microsoft Sentinel, select Notebooks.
Select the Templates tab.
Enter Synapse in the search bar to find the notebook.
Select the Azure Synapse - Configure Azure ML and Azure Synapse Analytics notebook.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 91b5b90f-1e6b-5d17-c7d0-06e173a4591d
Version Independent ID: 626aa6cd-7cb0-405a-876c-8cd2c181aa9a
Content: Configure big data analytics settings for Azure Synapse Analytics
Content Source: articles/sentinel/notebooks-with-synapse.md
Service: microsoft-sentinel
GitHub Login: @cwatson-cat
Microsoft Alias: cwatson

@applefacts
Thanks for your feedback! We will investigate and update as appropriate.

@cwatson-cat
Can you please check and add your comments on this doc update request as applicable.

@applefacts
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.

#label:"backlog-item-created"

@applefacts Thanks for reporting this issue. We've retired this article as that notebook is no longer available. #please-close


Fix failing tests

https://github.com/terkelg/tiny-glob/pull/44 added a new directory as part of a test added in that PR. That caused some existing tests to start failing when they found that directory. I've updated the tests to account for its presence
Closes https://github.com/terkelg/tiny-glob/pull/49 which would have fixed only one of the tests
Note that there are two other test failures. I sent https://github.com/terkelg/tiny-glob/pull/56 to fix those

Thank you so much!


Improve the docs arch diagram to explain the ports and servers

Is your request for enhancement related to a problem? Please describe.
The docs include an architecture diagram.  This doesn't have any information to describe the numbers beside each box (the ports) and it also doesn't have any detail on what each server does.
Describe the solution you'd like
Tie up the architecture diagram to some of the detail in the install guide for the servers and what they are tasked with
Explain the port numbers
Have more detail of each server including the default URL for each one to browse their capabilities and log onto them
Related doc pages
https://docs.zowe.org/stable/getting-started/zowe-architecture.html

I would like to add for the section "Describe the solution you'd like" :
Somehow also provide details on -
How File API( Port 8547) are different from FILE API of z/OSMF ( Port 7443),
and JES API( Port 8545) are different from JES API of z/OSMF ( Port7443)?

Hi Joe, this is a bit different from the architecture diagram, but do you think something like this would also be valuable on the same doc page for a different look at the solution?

@BrandonJenkins14 This diagram is beautifully drawn. I think we could have a brief(high-level) architecture introduction first like the one that showed above. This would targets at new users who's learning about Zowe to get familiar. Then we could have a detailed architecture with port numbers and back-end details as displayed on the doc site now. This would target at people who might plan to start installation or try to debug something. Just my 2 cents.

@BrandonJenkins14 - yes that's a great diagram and I know it gets used a fair bit at conferences.  Do you know if there is a .ppt of that as I'd like to make a few changes to it if possible to show the ways Zowe can be extended (that it doesn't cover), and also show more of the GUI for the mediation layer


Long running loop fix

This is a speed enhancement to the word wrapping algorithm.  In the case of massive words, such as in the case of a huge number of spaces, this reduces the time from effectively infinite to near-instant.  In short, we make an educated guess as to how much space we have so that we start very close to the correct slice of the word, then we tweak as necessary by shrinking or growing our slice range.
Thanks to @mgetz for getting the core changes in place!

Thanks for this smart improvement


Is it possible to set the inner circle to transparent?

Seems like there is no way to adjust the color of the inner circle.

You can now change the color of the inner circle. Released on 0.6.2

@LucasMonteiro1  How to do the same with a needle and different colors in inner circle

I want to match the inner circle to a background of the view...which is a gradient ...how is it possible?


Add google analytics tag

Add the google analytics tag into the head

https://dev.to/markosaric/how-to-make-google-analytics-gdpr-compliant-so-you-don-t-need-to-ask-for-user-consent-42mh


Pmag GUI tutorial site --> location relationship missing

Why isn't location column initially filled in for sites table??

It looks like orientation_magic is somehow overwriting sites.location


"Șinca Nouă" commune is listed in the drop-down menu

Description:
The commune is listed in the drop-down menu according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Șinca Nouă" in the search bar.

Expected results
The location is listed in the drop-down menu as "Șinca Nouă, Brașov"


failure in state transition

error in bddtest did exchange basic flow
[aries-framework/transport] 2019/10/03 14:51:16 UTC - http.processPOSTRequest -> ERROR incoming msg processing failed: invalid state transition: requested -> completed
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).handle -> INFO send pre event for state completed
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).Handle -> INFO entered into Handle exchange message : {"@type":"did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/didexchange/1.0/ack","@id":"e189cf47-64f7-45d5-90b1-948ea4c2ba98","status":"ok","~thread":{"thid":"22a77cd6-3131-4fd8-a2e8-b3a3a99b283b"}}
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).Handle -> INFO thread id value for the did exchange msg : 22a77cd6-3131-4fd8-a2e8-b3a3a99b283b
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).Handle -> INFO current state : requested
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).Handle -> INFO state will transition to -> completed if the msgType is processed
 [aries-framework/transport] 2019/10/03 14:51:16 UTC - http.processPOSTRequest -> ERROR incoming msg processing failed: invalid state transition: requested -> completed
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).handle -> INFO next state that need to be executed immediately: noop
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).handle -> INFO persisted the connection using 22a77cd6-3131-4fd8-a2e8-b3a3a99b283b and updating the state to responded
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).handle -> INFO send post event for state responded
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).handle -> INFO --exited internal handle function--
 [aries-framework/did-exchange/service] 2019/10/03 14:51:16 UTC - didexchange.(*Service).startInternalListener.func1 -> ERROR processing of the message failed: failed to execute state completed handle inbound failed: failed to send msg using http outbound transport: received unsuccessful POST HTTP status from agent [http://localhost:36303, 500 Internal Server Error]```

After debugging  I discovered that we have race condition it's possible that you receive response before update the state @sandrask @bstasyszyn @troyronda @rolsonquadras @talwinder50


Improvements for do and related statements

Leading/trailing spaces are updated to make statements well formatted
CatchClause convenience initializer that calculates spacing around the catch keyword
Test coverage for above changes

https://github.com/apple/swift/pull/60204

@ahoppen any comments for the updated implementation?

@swift-ci Please test

https://github.com/apple/swift/pull/60204
@swift-ci Please test

https://github.com/apple/swift/pull/60204
@swift-ci Please test

https://github.com/apple/swift/pull/60204
@swift-ci Please test


NCDA - Change ANC Date Dialog [6h]

Issue
In the case that the CHW needs to be asked to correct the ANC encounter record, we will show a dialogue consisting of a timeline of the pregnancy, divided by trimester, and the opportunity to indicate in which month of pregnancy visits have occurred.

Multiple selections should be possible, and previously indicated months should be "pre-checked" in the input.
Tasks

Create the dialog and input
Wire in logic for pre-filled selected months
Reconfigure mapping to the child scorecard based on ANC encounters and additional dates provided by CHW

NCDA is on live for few months. Closing.


QR Code Can't Be Read

Hi,
I loaded your project to my Unity and many scripts from the HoloToolKit are missing that's why I updated it to the new one.
The app can be deployed but It can't read the QR Code now. Please help

After checking the folder once again, the scripts are indeed there but somehow the prefabs won't load it, so I dragged and dropped the script manually to each prefab. Now the necessary prefabs are there (I really need the input manager and cursor prefab), the QR code can also now be read again.


Change CODEOWNERS to core-api team

Update CODEOWNERS to core-api team

Close in favor of https://github.com/safe-global/safe-transaction-service/pull/1886


create list files

When I use 'convert_images_to_list.sh' to create list files, it says 'jot : not found command' .
How to solve it ?

sudo apt-get install athena-jot


CUJ Testing for Beta v2 - Creator Can Search Templates

Feature Description
n preparation for the Beta 2 release we would like to have validation and confirmation of the CUJ functionality detailed in
https://github.com/google/web-stories-wp/issues/1683

[ ] Enter keyword to search template
[ ]  Select from suggested search terms in search box
[ ]  Sort search results

This section is out of scope for Beta 2 release


runtime: aix/ppc64 builders failing with new on-demand gcmask

Go version
tip
Output of go env in your module/workspace:
AR='ar'
CC='clang'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='clang++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/khr/Library/Caches/go-build'
GODEBUG=''
GOENV='/Users/khr/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/z9/dty110711l9cr9w3ktv1_2380000gn/T/go-build1049870315=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/Users/khr/sandbox/tmp4/src/go.mod'
GOMODCACHE='/Users/khr/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/khr/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/khr/sandbox/tmp4'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/khr/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/khr/sandbox/tmp4/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='devel go1.24-a9dac07ffc Fri Nov 22 09:07:21 2024 -0800'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?
Look at build.golang.org, the aix/ppc64 column. It's all red, as of https://go-review.googlesource.com/c/go/+/616255.
For instance, https://build.golang.org/log/f520a7726768292ddd7a1157b1f2f91a269f7a97
It is failing when trying to do an atomic operation. The address looks strange, probably it isn't mapped.
I suspect what is happening is that aix/ppc64 doesn't do relocations from the rodata section to the data section correctly. (I think I remember something like that from long ago in my brain, not sure.)
If an aix and/or ppc64 person can confirm, I can think about how we might fix it. It may be tricky.
@golang/aix @golang/ppc64
What did you see happen?
segfault
What did you expect to see?
no segfault

Related Issues

runtime: AIX build broken with SIGSEGV #70483
cmd/dist: SIGSEGV during bootstrap on aix-ppc64 #58857 (closed)
gccgo: runtime address space conflict on AIX #24994 (closed)
cmd/link: function "decodetypeGcmask" read gcdata from shared object file may not correct when use `lld` link in linux/arm64 #69466
runtime: ppc64x binaries randomly segfault on linux 5.13rc6 #46803 (closed)
runtime: dependency on AVX instruction set added in Go 1.14 on macOS #37477 (closed)
runtime: "fatal: morestack on g0" with PGO enabled on arm64 #62120 (closed)
cmd/compile: compiler built with PGO crashes occasionally on ppc64{le} #60368 (closed)
runtime: add race detector for ios/arm64 #39521
go build use -asan it panic. #69225 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

Whoops, dup of #70483.


chore: create CONTRIBUTING.md for the community

This link is an example of how to build a guideline for contributing to open-source projects.
This is an example of Angular and their standard.
Proposal:

Write a simple contributing guideline for newcomers to learn how to contribute.
Submit this file for all web3task repositories as a PR, referring to this issue.

I believe I can help with this need.

I've created the first version for the front repository, after it's approved I'll use this as the basis for the other repositories
w3b3d3v/web3task-front/pull/170

@viniblack Your PR for the frontend has been approved.
We are waiting for the PR of the contract repository and landing page.
thanks.

New update, @viniblack is making the latest adjustments.

PR front: https://github.com/w3b3d3v/web3task-front/pull/171
PR contracts: https://github.com/w3b3d3v/web3task-contracts/pull/55

@viniblack  review prs please

Done, thanks @viniblack


Import Wikipedia abstracts

We will end up importing the whole Wikipedia dumps soon enough, however a simple first step would be to import the abstracts, after #10 is finished.
That could allow us to add good descriptions, possibly of better quality than DMOZ. That would be helpful for commonsearch/cosr-results#1 for instance.
We could also possibly start including all wikipedia urls in the results, even if we didn't index their whole content yet.
https://meta.wikimedia.org/wiki/Data_dumps
There seems to be a combined abstract.xml file ("Recombine extracted page abstracts for Yahoo"), is this the one we should use?
https://dumps.wikimedia.org/enwiki/20160204/

The "Recombine extracted page abstracts for Yahoo" quality seems very low (a lot of summary are actually infobox invocations) and is polluted with redirection. And I don't manage to find an other dump with article abstracts.
The relevant REST API call to get summary and image for an article is the /page/summary operation of the REST API: https://rest.wikimedia.org/fr.wikipedia.org/v1/?doc#/

Thanks for looking into it! Too bad for the abstracts dump.
We can't really use the REST API because we want all articles at once.
I guess we'll have to use the larger dumps. The solutions I can think of:

Use the zim HTML dumps http://www.kiwix.org/wiki/Content_in_all_languages
Use the wikipedia XML dumps and transform them into HTML with Parsoid. It seems that Parsoid relies on a Wikimedia webservice for template expansion though?
Wait for the official Wikipedia HTML dumps to come through: https://phabricator.wikimedia.org/T93396

Any other ideas?

I've downloaded the SQL dumps and used them directly, it's quick to download and not so hard to parse, although you do need to get smart about the HTML which is in the "text". (I can contribute perl code that does it...) blekko got pretty good "abstracts" by just extracting the first couple of sentences.

There has been some recent activity on Wikimedia's side on the HTML dumps: https://phabricator.wikimedia.org/T133547
I hope they can go through so that we can index not only the abstracts but the whole articles as well.
In the meantime, either the SQL or the ZIM dumps seem like the best bets. @wumpus feel free to share your perl code, I'd be curious to see the hacks you did :)

Hack alert!
extract-raw-wikipedia-articles.pl.txt

Hack alert indeed!! It's almost as scary as I imagined ;-)
I just merged support for pluggable document sources so it should be very easy to write one that reads the .zim files and see how it behaves.


Updating to ASN1ObjectIdentifier from deprecated DERObjectIdentifier.

Replaced deprecated usage of DERObjectIdentifier.

@seize-the-dave - Do you have anytime to review and merge this? Was wondering the process for requesting a release as well?

Hi @eagletalon139 thanks for the commit!  Is the use of the deprecated class causing you any problems?

@eagletalon139 release should now be on Maven Central (2.5.3) 👍


Using Compile-AppInNavContainer causes error since version 3.1.4

When compiling, I receive following error:
"Parameter set cannot be resolved using the specified named parameters."
This is caused by following code
$publishedApps = Invoke-Command -Session $session -ScriptBlock { Param($tenant)
    Get-NavAppInfo -ServerInstance NAV -tenant $tenant
    Get-NavAppInfo -ServerInstance NAV -tenant $tenant -symbolsOnly
} -ArgumentList $tenant

It seems not possible to use -tenant and -symbolsOnly in the same parameter set.

Sorry about this double issue, Chrome seems to have some issues with refreshing pages....


Magnitude queries extremely slow for some queries with medium model.

Also, I also don't seem to be getting the following advantage described in the documentation: "Moreover, memory maps are cached between runs so even after closing a process, speed improvements are reaped."
See the following log.
$ python
Python 3.4.6 (default, Mar 22 2017, 12:26:13) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pymagnitude import Magnitude
>>> vectors = Magnitude('/nlp/data/embeddings_magnitude/eng/GoogleNews-vectors-negative300.magnitude.medium')
>>> from timeit import timeit
>>> timeit('vectors.query(\'cat\')', 'from __main__ import vectors', number=1)
0.0585936838760972
>>> timeit('vectors.query(\'food\')', 'from __main__ import vectors', number=1)
0.03608247195370495
>>> timeit('vectors.query(\'believe\')', 'from __main__ import vectors', number=1)
0.02389267599210143
>>> timeit('vectors.query(\'denormalization\')', 'from __main__ import vectors', number=1)
27.955912864999846
>>> timeit('vectors.query(\'tariffication\')', 'from __main__ import vectors', number=1)
36.63970931386575
>>> timeit('vectors.query(\'tariffication\')', 'from __main__ import vectors', number=1)
7.962598465383053e-05
>>> exit()
$ python
Python 3.4.6 (default, Mar 22 2017, 12:26:13) [GCC] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from pymagnitude import Magnitude
>>> vectors = Magnitude('/nlp/data/embeddings_magnitude/eng/GoogleNews-vectors-negative300.magnitude.medium')
>>> from timeit import timeit
>>> timeit('vectors.query(\'tariffication\')', 'from __main__ import vectors', number=1)
34.75812460412271
>>>

I understand that some queries (especially OOV ones) should be slower than others, but 36 seconds seems excessive. This issue doesn't affect all out-of-vocabulary words. For example:
>>> timeit('vectors.query(\'catdogcow\')', 'from __main__ import vectors', number=1)
1.1214001160115004
>>> 'catdogcow' in vectors
False

Is there anything I can do to get all queries run within some reasonable threshold, say 2 seconds, or to get caching to work? Maybe there should be some feature where if OOV querying is taking too long, a random vector, like for the light model, is returned?

Thanks for reporting this, I've actually noticed this too for some queries. I'll see if there's anything I can do to speed up these queries and if not I'll add a 2 second timeout like you suggested.

Sorry it took so long, I did add something in Release 0.1.56 to control the time it takes by limiting the search. The timeout is not as easy to implement as I thought as SQLite has no in-built timeout for queries.
I also saw you mentioned memory-map caches weren't working for you in-between runs. They likely are. Memory maps are used for kNN-search and those are cached in between runs so you don't have to build them each time. (Takes > 1 min each run otherwise). What you are experiencing likely is some "queries" being a little slower on a new run, that is normal however. If you are experiencing extremely slow kNN-search on the first kNN-search of every run, then your memory map caches aren't working. These are cached to a $TMPDIR on Linux/Mac. If you are using a Docker container or a VM solution, you might be losing this temporary directory every time. You can volume out that temp directory to a folder on your host directory if that is the case.


Persist tokens and other outputs securely for test execution

Output tokens from test-sources.json need to be stored securely so we can remember them across sessions. We're opting to use this instead of environment variables, since changing environment variables requires restarting IDEs like VS (which spawns many child processes, most of which don't respond to broadcast messages asking them to update their environment variables).

On Windows, we'll use DPAPI to encrypt files under %AppData%\azuresdk.
On linux and MacOS, we'll chmod 700 ~/.local/azuresdk.

On both systems, the subdirectory will be a hash of the repo root (case-sensitive on linux/MacOS; tolower'd in Windows).

@pakrym did this for Windows, but we don't yet do this for linux and should consider it.

@pakrym did this for Windows, but we don't yet do this for linux and should consider it.

@schaabs given your work on Identity, will chmod'ing a file on linux be sufficient for storing secrets? We use DPAPI on Windows. It would be nice to be able to do this on *nix. If not, I'll close this.
/cc @pallavit @jsquire @JoshLove-msft

Talking offline, chmod'ing might be okay for test resource secrets, but if anyone uses persistent SP credentials that could be disastrous. No one has really asked for this on non-Windows, and given the effort required for a DPAPI-like implementation - the likes that az uses - I'm just going to close this. We can revisit later if needed.

In Identity persisted token caches are protected on Mac and Linux as well using Keyring and Keychain. This does have some drawbacks. Keyring isn't installed by default on Linux distros, and Keychain isn't accessible on Mac in SSH sessions. In the cases where it's not available we have an option to allow storing the file unencrypted with only chmod protection, but this will error by default.
I would say the need to encrypt the file would depend on the information being stored in it. If it only contains details of test resources which are short lived it's chmod is probably sufficient. If on the other hand it contains account credentials or longer lived azure resources we should consider adding more protection.


fix(map navigation): 18438 Speed up navigation to a point on the map

Removing extra layer of abstraction when navigation to a point on the map.
https://kontur.fibery.io/Tasks/Task/Speed-up-zoom-when-using-Locate-me-(Breadcrumbs,-search)-feature-18438
https://kontur.fibery.io/Tasks/Task/FE-Test1-Locate-me-feature-does-not-zoom-to-location-for-new-OAM-18508

Summary by CodeRabbit

New Features

Introduced a new action handler updateCurrentMapPosition for enhanced map position updates.
Added a custom hook useMapPositionSync for real-time synchronization of the map's position with shared state.

Improvements

Simplified synchronization logic for map position and bounding box actions.
Renamed hook from useMapPositionSmoothSync to useMapPositionSync for clarity and improved functionality.

Bug Fixes

Resolved potential issues with cyclic updates by refining the map position synchronization process.

@coderabbitai pause

PR not yet ready for review, WIP


Python client: Plumb ca_bundle to requests

In order to verify the SSL certificate received for https requests, the
ca_bundle has to be passed into the requests module. Needed when the
ca_bundle is not in the standard place.

Hmm ... given the weirdness (boolean vs. string):
a) Documentation?
b) Should we decline a false setting? We should not encourage disabling cert checking!


8 by 8 grid to match more with chess board

Currently it has 7 by 7 grid.
Aim: blend in, & camouflage.
If interested, give it a thumbs up 👍 and write a comment if you want

While developing this app I did some experimenting trying to figure out the best pattern size.
I've come up with the current implementation, therefore I would like to stick with the current dimensions for the default pattern.
But extending the size could be made possible through custom patterns in #24 .


fix: worker node CRI registry init

/kind bug
What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

Codecov Report

Merging #325 (48a7a43) into master (5c65656) will increase coverage by 0.02%.
The diff coverage is 38.88%.


Date selector finicky in explorer

Setting the start date to 2017-1-1 gives me big stack traces at the top that boil down to "use YYYY-MM-DD format".  Seems like validation that could be done on the input?

we are doing validation but something is awry!


x/pkgsite/internal/fetch/dochtml, x/tools/cmd/godoc: BUG, TODO etc. should be re-thought

Godoc needs updated rules and a nice UI for interpreting and presenting BUG(foo),
TODO(bar) etc. The current setup is odd: it treats things internal to functions
specially, while things at top level are too loosely bound. For instance,

// Foo bars blatz.
// BUG(gopher): Foo should bing bang bam.
func Foo() { }

will fold the TODO onto the previous line, while

// BUG(gopher): Foo should bing bang bam.

// Foo bars blatz.
func Foo() { }

will print the BUG for every query of the package. This is far from intuitive or helpful.

And godoc.org completely ignores them

This might've been true at the time that comment was made (in 2013), but by now, they are displayed on godoc.org as well as on pkg.go.dev.

a nice UI for [...] presenting BUG(foo), TODO(bar) etc.

Various websites that display Go package documentation so far have used slightly different URL schemes for linking to these sections. Compare:

https://golang.org/cmd/gofmt/#pkg-note-BUG
https://godoc.org/rsc.io/pdf#pkg-note-bug
https://pkg.go.dev/rsc.io/pdf#pkg-note-BUG

Pkg.go.dev has so far followed suit from x/tools/cmd/godoc, but perhaps it would be better to make the fragment in the URL lower case. These URLs are used relatively infrequently, so if there can be a usability improvement made, it might not be too late. As more time passes, it becomes more expensive to make any change, and the current scheme is more likely to stay.
/cc @julieqiu


STORM-1772 Adding Perf module with topologies for measuring performance

Contributing some topologies for measuring Storm performance.
I have used these topos to identify and resolve perf issued with Storm in the past.  Also some of these have been used to publish these benchmarks : https://hortonworks.com/blog/microbenchmarking-storm-1-0-performance/
Some topos measure purely the internal functioning of Storm, while others measure I/O with external systems like Kafka and Hdfs. Topologies of the former type can be used for both:

Profiling speed within the IDE using profilers like JProfiler.
Benchmarking on a cluster

The topos which measure how fast you can do I/O with Kafka/Hdfs ... are intended for running on cluster and not designed for profiling within IDE.

Wanted to give credit the authors of Intel benchmark :
https://github.com/intel-hadoop/storm-benchmark
from where I borrowed (with modification) the code to collect and compute metrics.

@roshannaik looks good to me. Can you add a doc on how to run these.

@harshach  I have added the doc.

+1

@harshach   FYI: I have squashed the commits. Also addressed rat issues.

Merged into master and 1.x-branch


Switching to a powershell file freezes VS Code

We have written
Issue Type: Bug
After the latest update VS code is frozen for about 5-10 seconds when i switch from a txt file to a PS1 file
VS Code version: Code 1.30.0 (c6e592b2b5770e40a98cb9c2715a8ef89aec3d74, 2018-12-11T22:29:11.253Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.81GB (6.10GB free)

Process Argv
C:\Users\dxd86\Desktop\Script Sync\20181213\UPSManageHR

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.7.2

tslint
eg2
1.0.41

angular-bootstrap
her
4.0.9

beautify
Hoo
1.4.7

Angular1
joh
0.2.0

vscode-format-context-menu
lac
1.0.4

mssql
ms-
1.4.0

csharp
ms-
1.17.1

notepadplusplus-keybindings
ms-
1.0.2

PowerShell
ms-
1.10.1

typescript-javascript-grammar
ms-
0.0.47

wordcount
ms-
0.1.0

debugger-for-chrome
msj
4.11.1

qub-xml-vscode
qub
1.2.8

vscode-icons
rob
7.28.0

Angular2
UVB
0.4.1

(3 theme extensions excluded)

the needed data into your clipboard because it was too large to send. Please paste.

Sounds like this could be caused by the powershell extension. Does this reproduce in the latest VS Code insiders build with all extensions disabled?


Docs: Add a searchbar

First of all, thank you for your work! State management always seemed clunky and a burden to setup, with a lot of boilerplate.
With StateAdapt, everything is just straightforward and meaningful at every step, I hope it will still gain traction from the community, and I'm looking forward to the v2 💪
StateAdapt features a lot of API and I often find myself looking for the documentation page for a specific method.
Unfortunately, I feel like having to dig into multiple pages to find where it is defined.
I would have like to be able to use a search bar, the same way other libraries such as NgRx or NGXS do.
This could show results based on the scope (core, angular, react, ...) and the relevant documentation sections, improving both the discoverability of StateAdapt's API and the onboarding of newcommers.
For illustration purposes, here is what NgRx's serachbar looks like when searching for compo:

Is this something that you might want to consider?

Yeah, I'll have to look into this. Thanks for bringing it up. I want to focus on the developer experience of using StateAdapt.
Have you hovered over a method before and looked at the JSDoc tooltip? It has the exact same content as what's on the docs site.


ZeebeClient in the example application can send the command successfully for only once

Describe the bug
The command NewCreateProcessInstanceCommand() only gets sent to the local Zeebe docker via ZeebeClient successfully for once after the example web application is up and running and then it goes down for the subsequent requests without any errors.
To Reproduce
Steps to reproduce the behavior:

Spin up the example web application
Go to the Swagger UI provided by the example
Submit an application
Check the process instance in Operator. A new instance is created.
Go to Swagger UI and submit another application
Check the process instance in Operator. The number of the instance remains the same.

Expected behavior
A new process instance should be created whenever a new application is submitted via ZeebeClient.
Enviroment (please complete the following information):

OS: Windows
Version: 11
Zeebe: 8.2.11 (running in Docker Desktop)

@send2vinnie:
Thank you for pointing this out. This is an error caused by the underlying zb-client and their migration to the Grpc.net.GrpcChannel away from Grpc.core.
As a workaround I would suggest to go back to version 1.1.0 of this library which has zb-client 1.3.0 as transitive dependency.

This missing async has been added to the Controller and documentation been updated. Thanks for your hint!


make fee a iao:condition specification

The fee of an academic event can be understood as a iao:'condition specification' that specifies how much money has to be paid in order to be allowed to attend the event or how much money has to be paid to be an official sponsor of the event. It is a condition which is part of the academic event type specification that gets realized by the event.
The event fee specification must be represented by a literal value of the amount of money that has to be paid and a symbol that indicates the currency that has to be used for the payment.

There are different kind of fees involved in the organization of academic events, such as member fee, reduced fee, early bird fee, box office fee, or gold, silver and bronze sponsor fees. As of now the destinction of what is really common practice is not so clear. Thus it seems best to only have the two classes 'attendance fee specification' & 'sponsor fee specification' for now. To indicate the more fine grained kind of attendance fee specification a user can use the rdfs:label on an instance of this class.
We might add more subclasses, once we have a large enough data set from which these can be derived.


Proper way to set phpcs to WordPress standard?

Is there a better way to tell phpcs to use the WordPress standard? I ended up disabling the built-in phpcs checker and setting the option g:syntastic_wordpress_phpcs_args
This is in my ftplugin/wordpress.vim:
let g:syntastic_php_checkers = ["php", "wordpress/phpcs", "phpmd"]
let g:syntastic_wordpress_phpcs_args="--report=csv --standard=WordPress"

Going further, is there any good way to specify a project-specific ruleset file, or have Vim find it automatically?

The latest change to the syntax checker allows you to do it.
let g:syntastic_wordpress_checkers = ['phpcs']
let g:syntastic_wordpress_phpcs_standard = "WordPress-Core" "Default standard
"Standard file name. This should be at the root of the project.
"If not found then the default standard is used
let g:syntastic_wordpress_phpcs_standard_file = "phpcs.xml"

Great, thanks! Worked perfectly once I remembered to make sure php/phpcs wasn't enabled. My ftplugin/wordpress.vim ended up like so:
let g:syntastic_php_checkers = ["php", "phpmd"]
let g:syntastic_wordpress_phpcs_standard_file = "phpcs.xml"


disable sliding when there is only one card

In GitLab by @lakhoune on Apr 11, 2020, 15:51

In GitLab by @lakhoune on May 7, 2020, 11:28
closed

In GitLab by @VerwaltungHilton on May 15, 2020, 22:57
Do not forget to mark the social service as verified                  here


dra-evolution: "vendor" vs. "driver developer"

https://github.com/kubernetes-sigs/wg-device-management/pull/14 and also KEPs sometimes talk about a "driver vendor". Sometimes "driver developer" is used instead. We should pick one and use it consistently.
Advantage of "vendor": familiar term, matches well with "hardware vendor".
Disadvantage: some drivers maintainer by an open source developer or community don't have a vendor.
Disadvantage of "driver developer": that sounds like the person doing the work, which is not appropriate in some places ("Driver name must be a DNS subdomain and should end with a DNS domain owned by the vendor of the driver.").

I think "vendor" has won in terms of popularity.
/close


Not able to parse date 2020-07-20+00:00

I am using code below
	d, err := dateparse.ParseAny("2020-07-20+00:00")
	if err != nil {
		t.Fatal(err)
	}

Error reports as
parsing time "2020-07-20+00:00" as "2006-01-20+00:00": cannot parse "+00:00" as "0+00:00"

you can try go-carbon，carbon.ParseByFormat("2020-07-20+00:00", "Y-m-d+H:i").ToDateTimeString()

you can try go-carbon，carbon.ParseByFormat("2020-07-20+00:00", "Y-m-d+H:i").ToDateTimeString()

Thank you for the report!  I pushed a fix to add this:
$ ./dateparse 2020-07-20+00:00

Your Current time.Local zone is PST

Layout String: dateparse.ParseFormat() => 2006-01-02-07:00

+-------------+-----------------------+-------------------------------+-------------------------------------+
| method      | Zone Source           | Parsed                        | Parsed: t.In(time.UTC)              |
+-------------+-----------------------+-------------------------------+-------------------------------------+
| ParseStrict | time.Local = nil      | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
| ParseStrict | time.Local = time.UTC | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
| ParseAny    | time.Local = nil      | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC day=1 |
| ParseAny    | time.Local = time.UTC | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC day=1 |
| ParseIn     | time.Local = nil      | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
| ParseIn     | time.Local = time.UTC | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
| ParseLocal  | time.Local = nil      | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
| ParseLocal  | time.Local = time.UTC | 2020-07-20 00:00:00 +0000 UTC | 2020-07-20 00:00:00 +0000 UTC       |
+-------------+-----------------------+-------------------------------+-------------------------------------+


robust=True estimation doesn't work on Ubuntu?

Hi!
I've been using the LogLogisticAFTFitter with robust=True estimation on my Mac and I could see during during the procedure the following message coming from the logger that is attributes to this settings (at least I presume so, as I haven't seen it before without it):
2021-04-12 09:13:35,766 | INFO | utils.py | _init_num_threads | NumExpr defaulting to 8 threads.

also, the result of print_summary() clearly indicates that the SE show now different values as expected.
However, after packaging this code into a Docker image (Ubuntu), and running the container, I couldn't see the same logger output, and the SE were as if robust estimation did not take place.
Question: could it be that this setting silently fails on a different OS? Could you provide a bit more insights into this?

Hi @konradsemsch - hm, I don't know what's going on here. I'm guess the difference between the Ubuntu and Mac is if numexpr is installed (lots of libs, like pandas, have an optional dependency on numexpr, and will use it if available in the OS). Can you try pip intstalling numexpr in the Docker image and rerunning? That would give me some hint as to what might be going on.

Hi @CamDavidsonPilon! Ok, so I can come back with some further info. Adding numexpr to requirements indeed resolved the issue, but only partially.

Now, during training in the container I see the following lines:

When I run the model.print_summary() function locally on my mac, I also get a similar note and the SE seem reasonable:

On the other hand, the same print_summary() function executed in the container in order to render online documentation doesn't provide the same results. As if the numexpr package wasn't used even though the same container with the same dependencies is applied.

Please note, that all comparisons were done on exactly the same trained model object, just the OS was different.

Are you able to share the two print_summary results here?

Hi @CamDavidsonPilon! Yes, let me report back on this:
So from the logs I can confirm that numexpr is activated in the backend when the model is trained in the container. When I download it and inspect the results with print_summary() locally I see the following:

So from here you can already see that numexpr kicked in when the function was called.
And here's part of the summary which is executed on the container by sphinx, on the very same model object. Please notice that robust variance doesn't even show up in the top level summary. Please note that it's exactly the same object in the same jupyter notebook.

I would also expect to see the same numexpr message when calling this function, but it doesn't show up. However, what's surprising is that it I can see it being used when invoking some other function using the model object:

Any clue what could be causing this? Would there be any way to enforce a consistent behaviour?


have approved AE/WTT,when add Liquidity WTT/AE need to approve again

What happened?

How can we reproduce it?
add Liquidity
mobile
Desktop
What browsers are you seeing the problem on?
Chrome
Anything else you want us to know?
No response

We have a different model to how we do approvals compared to uniswap. By default we only approve the amount of tokens that you need to perform the current transaction. Meaning when you do a swap with WTT and then provide liquidity for AE / WTT you would need to give allowance for both. At the moment we can do this because our gas is much cheaper compared to ETH and its the more secure route. Does this answer your questions?


Fixed memory leaks in textures.c and added jetbrains/clion project-files to gitignore.

Pretty simple changes, usually involved just adding a call to RL_FREE.
For ImageToPOT I put the allocation of the pixels buffer in the body of the if-statement because if the condition was false the array was allocated for nothing and it would also leak.

@SasLuca thanks for the review!


ntpSource is garbled text

ntpSource is garbled text.
As such, the system cannot perform a valid NTP request.
Additionally, /api/system will also return garbled text.

Fixed in commit 4675953.


training dataset and super resolution capability

Hi, thank you for your great work! I have a couple of questions:

Are the experimental results' pretrained weights trained on the REDS train set (excluding Clips 000, 011, 015, and 020) or on the REDS train, validation, and test sets (excluding Clips 000, 011, 015, and 020)?

Can FMA-Net handle custom time super resolution, such as factors other than 4x?

Thank you in advance for your response.

Hi, thanks for your interest in FMA-Net!

The provided pretrained weights are trained on the REDS train (excluding 000, 011, 015, 020) and validation sets following previous works. The test set is excluded since ground truth is not provided. Please refer to this code.

FMA-Net can handle scale factors other than 4x. However, we don't provide pretrained models for this, so users need to train the model themselves. Specify the desired scale factor, modify the Pixel_Shuffle_Block accordingly (this is implemented only for 4x upsampling), and proceed with training.

Hi, thank you for your prompt and detailed response! I understand now!


Form Validation for Password & Password Confirm fields

I've used the Bootstrap 4 form validation in some projects and find it great, however, the form validation doesn't contain anyway of comparing the values of two password fields.
For Example:
Assume I want a signup page with the following fields:

Email
Password
Password Confirm

I don't want the user to be able to proceed with signing up if the 'password confirm' field doesn't match the value of the 'password' field.
I know there isn't really a HTML5 solution to this, so in projects where I'm using the Bootstrap 4 form validation I'm having to create my own jQuery, it would be nice to see this feature implemented into Bootstrap 4.2 along with the additional form tweaks?
Reference: https://getbootstrap.com/docs/4.0/components/forms/#validation

There are no plans to implement actual validation scripts in Bootstrap beyond what browsers do natively with HTML5 validity, I'm afraid.