[Bug] Pooling: Trailing slash in the user's pool URL is not removed before adding /pool_info

What happened?
When creating a new PlotNFT, the GUI client does not trim the slash in the end of the user-provided pool URL, resulting in double slash at the final URL that is being fetched.

Version
1.5.1
What platform are you using?
Windows
What ui mode are you using?
GUI
Relevant log output or stacktrace
No response

@jack60612 would you mind taking a look at this one?

@lipalong can you take a look at this since you're looking at this area in the UI?


avx blake

This change is

#518  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.62%. Comparing base (3bc4c79) to head (42d6243).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #518      +/-   ##
==========================================
+ Coverage   93.98%   94.62%   +0.64%
==========================================
  Files          60       62       +2
  Lines        9041     9827     +786
  Branches     9041     9827     +786
==========================================
+ Hits         8497     9299     +802
+ Misses        490      473      -17
- Partials       54       55       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src/core/backend/avx512/blake2s_avx.rs line 190 at r6 (raw file):

    //   abcd:0123 => 3abc:d012
    // where abcd:0123 denotes that 0b 0123 word in the 0b abcd chunk.
    // In other words, rotate the index to the right by 1.

Each _m512i chunk contains 16 u32 words.
Index abcd:xyzw, refers to a specific word in data as follows:
abcd - chunk index (in base 2)
xyzw - word offset (in base 2)
Code quote:
    // Transpose by applying 4 times the index permutation:
    //   abcd:0123 => 3abc:d012
    // where abcd:0123 denotes that 0b 0123 word in the 0b abcd chunk.
    // In other words, rotate the index to the right by 1.


Mapping output data

Hello Roland,
First of all it's amazing job you've done here ;)
I'm trying to find out best way to map output query data to structure. I'd like to avoid  assigning each of the column to particular variable every time. That's fine when I query it once but handling every column for each select query isn't the best thing to do. In other words I'm looking for something like:
for (const auto &row : db(select(all_of(foo)).from(foo).where(foo.age > age)))
{
Foo abc = row;
}
I was thinking of  handling const sqlpp:result_row_t<> type returned from query but it seems to be complex type. I'm wondering if there is way to translate/populate sqlpp data into defined structure or at least ease the job.
Regards,
Kamil

Hi Kamil,
Thanks for the flowers :-)
When I need to map query data to some struct, I normally write a helper function, like
template<typename Row>
auto getX(const Row& row) -> X
{
   // Do the assignments here
}

You do not want to write the type yourself, that's why I use a template.
It would be possible to offer tuple-like access to the row as well. Special attention would be required for multi-columns like in
for (const auto row : db(select(all_of(foo).as(foo), all_of(bar).as(bar))....)
{
   x = row.foo.id;
}

You would probably need tuple access for the row and then for foo.
If your structs do not need any special treatment for any column and all members have names corresponding to column names, then it would certainly be possible to write something like
auto x = row.getAs<X>(); // creates X and sets members to values from row

Personally, I like the mapping function best, followed by the tuple access (TBD) and the getAs function (TBD). I haven't had any case that would meet the getAs requirements, though.
Best,
Roland

That's what I was looking for. I believe helper function will be sufficient in all my scenarios.
Many thanks ;)


Investigate how to implement custom assertions

As an engineer I would like to investigate how BenchPress could leverage Pester's custom assertions.
Pester allows developers to define their own custom assertions. Could we use this in some way so that we can create an assertion that a user of BenchPress could use? (i.e. Should-BeAvailable when checking if a resource exists) How would we bootstrap this custom assertion into the BenchPress module?

[x] Document investigation and come to agreement with team
[x] Create subsequent issues for follow up implementation
[x] Bring to design session for discussion around implementation details
[x] Update #147 with correct acceptance criteria

Leaving design in Milestone 2.  Implementation can move to Milestone 3.

Wiki is updated here to close out this task with investigation findings.


Add sample coding

Add a C++ sample code with applications of the UVC device

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b13c7cbe-1d48-bd93-74c3-ccdac6e5ca6a
Version Independent ID: ce835058-cbd3-6850-6995-eb645a4659ef
Content: USB Video Class Driver Overview
Content Source: windows-driver-docs-pr/stream/usb-video-class-driver-overview.md
Product: windows-hardware
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

Thanks for reaching out to the Windows Driver Developer Documentation team.
I would recommend that you open an issue in the Windows-driver-samples requesting a USB Video Class (UVC) driver sample.
You may also have success posting your UVC driver questions in the following forums, where other driver developers and Microsoft engineers can be found. The community there is quite responsive.
MSDN Windows Hardware WDK and Driver Development forum
NTDEV forum at OSR Online


In order to better detect the external IP

In order to better detect the external IP
replace
SERVER_PUB_IP=$(ip -4 addr | sed -ne 's|^.* inet ([^/])/. scope global.*$|\1|p' | awk '{print $1}' | head -1)
with
SERVER_PUB_IP=$(curl -s http://whatismijnip.nl |cut -d " " -f 5)
or
SERVER_PUB_IP=$(curl -s icanhazip.com)
or or
curl -s ipv4.icanhazip.com
curl -s ipv6.icanhazip.com
👍

I don't want to add a dependency to external web site.


Investigate test failures on SLANG-WIN-4 and SLANG-WIN-5.

@csyonghe  can you please add a few details on how to get started on this bug so that when someone gets assigned to this they'll know what to do?

They need to talk to me first to gain access to the CI machines. Then they will build and run the tests manually on that machine and see what error comes out and we can take actions with further knowledge.

The root cause seems to be that we are forcing windows SDK 19041, which caused device removal when running on Win 11 and build using VS2022. Removing that argument to MSBuild seem to fix the issue.


Setting variables in another scope causes an infinite loop

I can't tell how much code this effects, but the following code will result in an infinite loop.
(defvar ast "")
(each ARGS (=> (a) (set ast (string ast a)))))

The problem seems to stem from set, the following code example will also produce the infinite loop.
(defvar test)
({ (set test 5))


koji_import: don't overwrite 'id' with None

When pulp_pull sees a v2 digest from Crane it returns None. In this case, don't overwrite the reported image ID.
Signed-off-by: Tim Waugh<EMAIL_ADDRESS>

Fix for unreleased bug so no release note needed.


Filtering dialogue: Changes applied without tapping 'Apply'

Changes executed on the dialogue for filtering and sorting are applied even when I close the dialogue by pushing the Android back button and avoid using the Apply button.
Noto v2.3.0-beta2
Fairphone 3
Android 10 with GMS updated to v23.13.12

Gone, thanks!


Simulate declare deploy

TITLE
Description
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #703 (9dd58cd) into main (9c84afb) will decrease coverage by 1.18%.
The diff coverage is 50.46%.

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   92.11%   90.93%   -1.18%
==========================================
  Files          52       52
  Lines       11339    11586     +247
==========================================
+ Hits        10445    10536      +91
- Misses        894     1050     +156

Impacted Files
Coverage Δ

src/transaction/error.rs
100.00% <ø> (ø)

src/transaction/deploy.rs
91.15% <10.34%> (-7.51%)
:arrow_down:

src/transaction/l1_handler.rs
87.19% <27.77%> (-10.02%)
:arrow_down:

src/transaction/declare.rs
95.17% <31.70%> (-3.56%)
:arrow_down:

src/transaction/mod.rs
53.96% <50.00%> (-6.91%)
:arrow_down:

src/transaction/declare_v2.rs
77.27% <50.84%> (-7.69%)
:arrow_down:

src/transaction/deploy_account.rs
90.75% <53.33%> (-7.04%)
:arrow_down:

src/lib.rs
97.53% <96.15%> (-0.13%)
:arrow_down:

src/transaction/invoke_function.rs
99.22% <96.66%> (-0.10%)
:arrow_down:


wstunnel[4113]: Rejecting connection

(ノಠ益ಠ)ノ彡┻━┻
Describe the goal
Establish a wireguard connection with wstunnel 5.0
Describe what does not work
wstunnel[4113]: Rejecting connection
wstunnel[4113]: Rejecting connection
Describe your wstunnel setup
Server:
ubuntu server 22.04.4
client: Linux mint 20.3, Linux mint 22
Followed this guide:
https://nerdonthestreet.com/wiki?find=Set+Up+a+WireGuard+VPN+Server+with+WebSocket+Tunneling
I am using wstunnel 5.0 because that is what is used in the guide linked above. When i tried to use the latest wstunnel version 10, the service does not start on the server. I have actually setup wstunnel using version 5 (on the same client i am currently using to connect and same server)  in the past without issues, so i have been pulling my hairs for the past few days and i can not pinpoint where the issue is.
I am testing from the same system (Mint 21.3 client) i was able to connect before and and 2 fresh VMs (another mint 20.3 and a new 22).
When i start the connection on the client i get (all sensitive IPs are masked with xx below):
[#] source /etc/wireguard/wstunnel.sh && pre_up wg0
[#] Can't resolve 3.xx.xx.3
[#] ip link add wg0 type wireguard
[#] wg setconf wg0 /dev/fd/63
[#] ip -4 address add <IP_ADDRESS>/24 dev wg0
[#] ip link set mtu 65456 up dev wg0
[#] resolvconf -a wg0 -m 0 -x
[#] source /etc/wireguard/wstunnel.sh && post_up wg0

but running wg shows no traffic (transfer: 0 B received, 148 B sent)
If i run the wireguard connection to the server without the wstunnel, the connection works. And the server seems to be receiving the requests on port 443 based on what i posted in the title. When i start the connection, the same error loops indefinitely
wstunnel[4113]: Rejecting connection
The wstunnel service on the server shows:
wstunnel.service - Tunnel WireGuard UDP over websocket
     Loaded: loaded (/etc/systemd/system/wstunnel.service; enabled; vendor preset: enabled)
     Active: active (running) since Fri 2024-08-23 16:58:42 UTC; 27min ago
   Main PID: 4113 (wstunnel)
      Tasks: 6 (limit: 1120)
     Memory: 5.3M
        CPU: 781ms
     CGroup: /system.slice/wstunnel.service
             └─4113 /usr/local/bin/wstunnel -v --server wss://<IP_ADDRESS>:443 --restrictTo=<IP_ADDRESS>:51820

Aug 23 17:21:55 aws-ohio wstunnel[4113]: Rejecting connection
Aug 23 17:21:55 aws-ohio wstunnel[4113]: NEW incoming connection from xx.0.0.xx:1307 []
Aug 23 17:21:55 aws-ohio wstunnel[4113]: Rejecting connection
Aug 23 17:21:56 aws-ohio wstunnel[4113]: NEW incoming connection from xx.0.0.xx:1308 []
Aug 23 17:21:56 aws-ohio wstunnel[4113]: Rejecting connection
Aug 23 17:21:56 aws-ohio wstunnel[4113]: NEW incoming connection from xx.0.0.xx:1309 []
Aug 23 17:21:56 aws-ohio wstunnel[4113]: Rejecting connection
Aug 23 17:23:23 aws-ohio wstunnel[4113]: wstunnel: ConnectionClosed
Aug 23 17:23:48 aws-ohio wstunnel[4113]: NEW incoming connection from xx.0.0.xx:57588 []
Aug 23 17:23:48 aws-ohio wstunnel[4113]: Rejecting connection

Here is the modified script i am using on the client to bypass hostname resolution as i do not use a domain (pre_up section where remote_ip=${remote} is added):
#!/usr/bin/env bash

#
# Original script downloaded from: https://github.com/Kirill888/notes/blob/wg-tunnel-update/wireguard/scripts/wstunnel.sh
# Modified by jnsgruk to use `ip route` for modern Linux distros
#
DEFAULT_HOSTS_FILE='/etc/hosts'

read_host_entry () {
    local host=$1
    local hfile=${2:-${DEFAULT_HOSTS_FILE}}
    awk -v host="$host" '{
     if( !($0~"^[ ]*#") && $2==host )
       print $1, ($0~"## wstunnel end-point")?"auto":"manual"
     }' "${hfile}"
}

add_host_entry () {
    local host=$1
    local ip=$2
    local hfile=${3:-${DEFAULT_HOSTS_FILE}}
    echo -e "${ip}\t${host}\t## wstunnel end-point" >> "${hfile}"
}

update_host_entry () {
    local host=$1
    local ip=$2
    local hfile=${3:-${DEFAULT_HOSTS_FILE}}
    local edited
    edited=$(awk -v host="$host" -v ip="$ip" '{
      if( !($0~"^[ ]*#") && $2==host && ($0~"## wstunnel end-point") )
        print ip "\t" host "\t" "## wstunnel end-point"
      else
        print $0
      }' "${hfile}")

    echo "${edited}" > "${hfile}"
}

delete_host_entry () {
    local host=$1
    local hfile=${2:-${DEFAULT_HOSTS_FILE}}
    local edited
    edited=$(awk -v host="$host" '{
      if( !($0~"^[ ]*#") && $2==host && ($0~"## wstunnel end-point") )
        ;
      else
        print $0
      }' "${hfile}")

    echo "${edited}" > "${hfile}"
}

maybe_update_host () {
    local host="$1"
    local current_ip="$2"
    local hfile=${3:-${DEFAULT_HOSTS_FILE}}
    local recorded_ip h_mode

    read -r recorded_ip h_mode < <(read_host_entry "${host}" "${hfile}") || true

    if [[ -z "${recorded_ip}" ]]; then
        echo "[#] Add new entry ${host} => <${current_ip}>"
        add_host_entry "${host}" "${current_ip}" "${hfile}"
    else
        if [[ "${recorded_ip}" == "${current_ip}" ]]; then
            echo "[#] Recorded address is already correct"
        else
            if [[ "${h_mode}" == "auto" ]]; then
                echo "[#] Updating ${recorded_ip} -> ${current_ip}"
                update_host_entry "${host}" "${current_ip}" "${hfile}"
            else
                echo "[#] Manual entry doesn't match current ip: ${recorded_ip} -> ${current_ip}"
                exit 2
            fi
        fi
    fi
}

launch_wstunnel () {
    local host=${REMOTE_HOST}
    local rport=${REMOTE_PORT:-51820}
    local wssport=${WSS_PORT:-443}
    local lport=${LOCAL_PORT:-${rport}}
    local prefix=${WS_PREFIX:-"wstunnel"}
    local user=${1:-"nobody"}
    local cmd

    cmd=$(command -v wstunnel)
    cmd="sudo -n -u ${user} -- $cmd"

    export NO_COLOR=true
    nohup $cmd &>/dev/null \
      client \
      --http-upgrade-path-prefix "${prefix}" \
      -L "udp://<IP_ADDRESS>:${lport}:<IP_ADDRESS>:${rport}" \
      "wss://${host}:${wssport}" &
    echo "$!"
}

pre_up () {
    local wg=$1
    local cfg="/etc/wireguard/${wg}.wstunnel"
    local remote remote_ip gw wstunnel_pid hosts_file _dnsmasq

    if [[ -f "${cfg}" ]]; then
        # shellcheck disable=SC1090
        source "${cfg}"
        remote=${REMOTE_HOST}
        #remote_ip=${REMOTE_IP:-$(dig +short "${remote}" | head -n 1)}
        hosts_file=${UPDATE_HOSTS}
        _dnsmasq=${USING_DNSMASQ:-0}
    else
        echo "[#] Missing config file: ${cfg}"
        exit 1
    fi

    if [[ -z "${remote_ip}" ]]; then
        echo "[#] Can't resolve ${remote}"
        #remote_ip=${remote}
        remote_ip=${remote}
    fi

    if [[ -f "${hosts_file}" ]]; then
        # Cache DNS in
        maybe_update_host "${remote}" "${remote_ip}" "${hosts_file}"

        [[ $_dnsmasq -eq 0 ]] || killall -HUP dnsmasq || true
    fi

    # Find out current route to ${remote_ip} and make it explicit
    gw=$(ip route get "${remote_ip}" | cut -d" " -f3)
    ip route add "${remote_ip}" via "${gw}" > /dev/null 2>&1 || true
    # Start wstunnel in the background
    wstunnel_pid=$(launch_wstunnel nobody)

    # save state
    mkdir -p /var/run/wireguard
    echo "${wstunnel_pid} ${remote} ${remote_ip} \"${hosts_file}\" ${_dnsmasq}" > "/var/run/wireguard/${wg}.wstunnel"
}

post_up () {
    local tun=$1
    ip route add <IP_ADDRESS>/1 dev "${tun}" > /dev/null 2>&1
    ip route add ::0/1 dev "${tun}" > /dev/null 2>&1
    ip route add <IP_ADDRESS>/1 dev "${tun}" > /dev/null 2>&1
    ip route add 8000::/1 dev "${tun}" > /dev/null 2>&1
}

post_down () {
    local tun=$1
    local state_file="/var/run/wireguard/${tun}.wstunnel"
    local wstunnel_pid remote remote_ip hosts_file _dnsmasq

    if [[ -f "${state_file}" ]]; then
        read -r wstunnel_pid remote remote_ip hosts_file _dnsmasq < "${state_file}"
        # unquote
        hosts_file=${hosts_file%\"}
        hosts_file=${hosts_file#\"}

        rm "${state_file}"
    else
        echo "[#] Missing state file: ${state_file}"
        exit 1
    fi

    kill -TERM "${wstunnel_pid}" > /dev/null 2>&1 || true

    if [[ -n "${remote_ip}" ]]; then
	    ip route delete "${remote_ip}" > /dev/null 2>&1 || true
    fi

    if [[ -f "${hosts_file}" ]]; then
        delete_host_entry "${remote}" "${hosts_file}"
        [[ $_dnsmasq -eq 0 ]] || killall -HUP dnsmasq || true
    fi
}

My ISP started blocking wireguard, the wireguard connections i mentioned working are the same i was using a week ago (same keys as before) so i need wstunnel to work.
Thank you for any tips.

Please upgrade to the latest version of wstunnel.
See the FAQ section for using wireguard with wstunnel
https://github.com/erebe/wstunnel?tab=readme-ov-file#wireguard

Ok i downloaded version 10 and trying the basics as per the instructions on that link.
Here i start wstunnel on the server:
root@aws-ohio:~# wstunnel server --restrict-to localhost:51001 wss://[::]:4433
2024-08-28T15:02:28.262471Z  INFO wstunnel::embedded_certificate: Generating self-signed tls certificate
2024-08-28T15:02:28.263152Z  INFO wstunnel: Starting wstunnel server v10.1.0 with config WsServerConfig { socket_so_mark: None, bind: [::]:4433, websocket_ping_frequency: Some(30s), timeout_connect: 10s, websocket_mask_frame: false, restriction_config: None, tls: true, mTLS: false }
2024-08-28T15:02:28.263284Z  INFO wstunnel::tunnel::server::server: Starting wstunnel server listening on [::]:4433

Port 4433 is open on the server. I also added the route using the local WAN ip of the server and the router gateway.
Note i use port 51001 for the wireguard connections.
This is the client trying to connect:
root@mint22VM:/etc/wstunnel# wstunnel client -L 'udp://51001:localhost:51001?timeout_sec=0' wss://3.xx.xx.3:4433
024-08-28T15:08:39.506147Z  INFO wstunnel::protocols::udp::server: New UDP connection from <IP_ADDRESS>:34041
2024-08-28T15:08:39.506772Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:4433
2024-08-28T15:08:43.933434Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:4433 due to timeout of 10s elapsed
2024-08-28T15:08:49.509066Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:4433 due to timeout of 10s elapsed
2024-08-28T15:08:49.910477Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:4433
2024-08-28T15:08:59.912138Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:4433 due to timeout of 10s elapsed
2024-08-28T15:09:00.713694Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:4433

Times out.
I do not see any instructions on how to actually install wstunnel.. i just extracted it from the wstunnel_10.1.0_linux_amd64.tar.gz file and gave it +x permissions.

The ports are not filtered/blocked on the server. I have control of the firewall.
To make it clear i ran another test on port 443 that i am currently using for v2ray and it is working.
While v2ray is active on the server on port 443, from the connecting client i run:
nc -zv 3.xx.xx.3 443
Connection to 3.xx.xx.3 443 port [tcp/https] succeeded!

Now confirmed there is no issues with port 443, I stop the v2ray service on the server to make the port available for wstunnel.
So if i try again:
nc -zv 3.xx.xx.3 443
nc: connect to 3.xx.xx.3 port 443 (tcp) failed: Connection refused

This confirms port 443 is free and no services are using it now.
Then i run wstunnel on the server using port 443:
root@aws-ohio:~# wstunnel server --restrict-to localhost:51001 wss://<IP_ADDRESS>:443
2024-08-29T09:21:33.761772Z  INFO wstunnel::embedded_certificate: Generating self-signed tls certificate
2024-08-29T09:21:33.762411Z  INFO wstunnel: Starting wstunnel server v10.1.0 with config WsServerConfig { socket_so_mark: None, bind: <IP_ADDRESS>:443, websocket_ping_frequency: Some(30s), timeout_connect: 10s, websocket_mask_frame: false, restriction_config: None, tls: true, mTLS: false }
2024-08-29T09:21:33.762556Z  INFO wstunnel::tunnel::server::server: Starting wstunnel server listening on <IP_ADDRESS>:443

and run nc again from the client:
nc -zv 3.xx.xx.3 443
nc: connect to 3.xx.xx.3 port 443 (tcp) failed: Connection refused

Same timeout in the client if i try to connect:
root@mint22VM:/etc/wstunnel# wstunnel client -L 'udp://51001:localhost:51001?timeout_sec=0' wss://3.xx.xx.3:443
024-08-29T09:32:56.155218Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:443 due to timeout of 10s elapsed
2024-08-29T09:33:47.355691Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:443
2024-08-29T09:33:57.357163Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:443 due to timeout of 10s elapsed
2024-08-29T09:35:39.758288Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:443
2024-08-29T09:35:45.325769Z ERROR tunnel{id="01919d79-1acd-7313-8305-afe60be5cb3b" remote="localhost:51001"}: wstunnel::tunnel::client::client: failed to get a connection to the server from the pool: TimedOut

although if i run netstat on the server while wstunnel is running it shows the port is in use:
root@aws-ohio:~# netstat -tuln | grep 443
tcp        0      0 <IP_ADDRESS>:443         <IP_ADDRESS>:*               LISTEN

Server system information"
System:
  Kernel: 6.5.0-1023-aws x86_64 bits: 64 Console: pty pts/0
    Distro: Ubuntu 22.04.4 LTS (Jammy Jellyfish)

wstunnel v10.1.0

As mentioned, i have control of the firewall and using any other port (4433, 44333) does not make a difference. I do have multiple other ports open on it and they all work. The server itself has the firewall disabled, the ports are opened from the inbound rules in the AWS security panel.
Thank you!!

in your last example, the server is listening only on the loopback interface (<IP_ADDRESS>)
root@aws-ohio:~# wstunnel server --restrict-to localhost:51001 wss://<IP_ADDRESS>:443

try with wss://[::]:443 or wss://<IP_ADDRESS>:443

Ok it looks like there is a connection now running:
root@aws-ohio:~# wstunnel server --restrict-to localhost:51001 wss://[::]:443
In the client i see the ping pong loop:
wstunnel client -L 'udp://51001:localhost:51001?timeout_sec=0' wss://3.xx.xx.3:443
2024-08-29T13:18:13.992370Z  INFO tunnel{id="01919e42-7b2b-7ff3-b0fe-af5e07f5d913" remote="localhost:51001"}: wstunnel::tunnel::transport::websocket: received frame Ping
2024-08-29T13:18:14.134617Z  INFO tunnel{id="01919e42-7b2b-7ff3-b0fe-af5e07f5d913" remote="localhost:51001"}: wstunnel::tunnel::transport::websocket: received frame Pong
2024-08-29T13:18:43.993501Z  INFO tunnel{id="01919e42-7b2b-7ff3-b0fe-af5e07f5d913" remote="localhost:51001"}: wstunnel::tunnel::transport::websocket: received frame Ping
2024-08-29T13:18:44.134992Z  INFO tunnel{id="01919e42-7b2b-7ff3-b0fe-af5e07f5d913" remote="localhost:51001"}: wstunnel::tunnel::transport::websocket: received frame Pong

But then i start the wireguard connection and i lose internet connection. There is no reply from the server and the client shows:
2024-08-29T13:10:42.731137Z  INFO wstunnel::protocols::udp::server: New UDP connection from <IP_ADDRESS>:34479
2024-08-29T13:10:42.731287Z  INFO wstunnel::protocols::tcp::server: Opening TCP connection to 3.xx.xx.3:443
2024-08-29T13:10:52.499749Z  INFO tunnel{id="01919e3b-be69-7713-8ab2-c41e1fefdcf1" remote="localhost:51001"}: wstunnel::tunnel::transport::websocket: received frame Ping
2024-08-29T13:10:52.733195Z  WARN wstunnel::protocols::tcp::server: Cannot connect to tcp endpoint 3.xx.xx.3:443 due to timeout of 10s elapsed

I am using the same wireguard configuration that was working before the ISP started blocking the protocol.
It looks like this:
[Interface]
PrivateKey = eDxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx2o=
Address = <IP_ADDRESS>/24
#MTU = 1400
DNS = <IP_ADDRESS>

[Peer]
PublicKey = osxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxn0=
Endpoint = localhost:51001
AllowedIPs = <IP_ADDRESS>/0

So i only changed the endpoint to localhost.
runing wg on the server shows the wireguard server is active listening.

you need to set a static route now to your server to avoid the loop
https://github.com/erebe/wstunnel?tab=readme-ov-file#wireguard-and-wstunnel-
or in your client allowed ip exclude your server from it, instead of <IP_ADDRESS>/0 check #252

Thank you erebe for your patience and kindness. I got it going now, problem was i added the route to the server instead of the client.
Good luck and thank you for your time.


Error handling for request not found

Description
Handles the case where a Rest Request with unhandled path makes it to an extension.
Normally, this should never actually happen™.
In reality, there's an edge case where if multiple rest handlers specify a different named wildcard, this would fail.  In Java SDK the implementation uses the identical code as the RestController to fail fast.  The effort-to-benefit ratio to port that implementation to python is high, so this check is essentially for the case where someone registers GET /foo/{bar} and GET /foo/{baz}.   In Java SDK this is prevented from happening.  It's not here, and I haven't researched enough to see exactly where the error occurs.
Issues Resolved
Fixes a TODO in the code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Opening for review 'cause the code is good, but I haven't written tests for it yet, so feel free to hold off on merging while still giving any substantive comments.

I'm not even sure how to test this, so your choice to merge, or offer specific feedback on how to test.

This is a good time to do two things:

Add a test for RequestErrorHandler, even just basics.
Use mocks to make sure its handle does what you expect it to do. Look for patch and stuff like that, https://docs.python.org/3/library/unittest.mock.html.
We can add a test that uses the real event loop when we move it from hello.py.

Learning mocks looks like a good weekend project. :)

The diff coverage is 100.00%.
🚀


Invalid icloud email or password for ...

There seems to be a problem with the login through pyicloud. I reeeeeealy checked everything and also installed pyicloud itself to recognize that it's not possible to log into the icloud services through pyicloud at the moment. So if anyone tries to install now: I think it can't work at the moment. Or does anyone know how to make the login work again?
Here is the issue report in pyicloud: https://github.com/picklepete/pyicloud/issues/206

I'm aware of the login issue and you are correct that it's because of pyicloud. I've been subscribed to the issue and will bump my dependency if/when they release an update. I haven't had a chance to look into it myself to see if I can help.

I'm closing this issue because pyicloud is working again


Local path & source URL installation support

Local path & Source URL installation support:

Changes to pass local keycloak zip file.
Changes to pass local RHSSO zip file.
Changes to pass source url to download RHSSO zip file from.

Now all following scenarios are available:

RHSSO from CSP
RHSSO from remote source
RHSSO from localpath
Keycloak from remote source
Keycloak from local path

Addressed all comments


Instructions for running built docker container.

Hey, thanks for the action!
I'm trying to figure out how to use the build docker container version to save build times, but it doesnt seem to be a drop in replacement:
- name: Coverage Report
      if: inputs.skip-coverage == 'false'
      id: coverage_comment
      uses: docker://docker.io/ewjoachim/python-coverage-comment-action:v2
      with:
          GITHUB_TOKEN: ${{ inputs.gh-token }}
          COVERAGE_PATH: ${{ inputs.project-root }}

Results in:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/coverage_comment/settings.py", line 167, in from_environ
    config_obj = cls(**config)
                 ^^^^^^^^^^^^^
TypeError: Config.__init__() missing 2 required keyword-only arguments: 'GITHUB_TOKEN' and 'GITHUB_PR_RUN_ID'
During handling of the above exception, another exception occurred:

So maybe I need to provide different config parameters for the built docker image version..

Aha! seems that inputs kinda don't work with a docker image that isnt built from scratch, so env variables need to be used, supplying these env variables worked:
      env:
          GITHUB_TOKEN: ${{ inputs.gh-token }}
          COVERAGE_PATH: ${{ inputs.project-root }}
          GITHUB_PR_RUN_ID: ${{ github.event.workflow_run.id }}

(coverage path optional)

That's an interesting use case, but I can't promise we won't accidentally break it in the future, as we're not testing for that use case in particular.
For curiosity, how much is it saving on your build ? Given that you're doing the same thing as GHA does, I'd have expected for it to take roughly as long ?

(also, you're using the :v2 image. You may have noticed that there are newer versions)

Oh, I just realized: we're only pushing https://hub.docker.com/repository/docker/ewjoachim/python-coverage-comment-action-base/general and not https://hub.docker.com/repository/docker/ewjoachim/python-coverage-comment-action/general which is a leftover of our previous deployment process. You'll be on your own with this image :/
That said, if you want to submit a PR for pushing this image as well as the base image, you're welcome

I have a counter-proposal:
Here's the dockerfile we build for every action: https://github.com/py-cov-action/python-coverage-comment-action/blob/main/Dockerfile#L5
We could skip the whole pip install in many cases (e.g. if the base image is recent enough (/ hasn't changed)) That's probably trivial to implement in the Dockerfile, and it could make the build faster than the 12s it is today.


"スピーカーを指名する" sounds different meaning from "nominate a speaker"

Describe the bug
"スピーカーを指名する" sounds like appointing someone as a speaker. However, the button is for registration as a speaker.
Expected behavior
I think the text should be "スピーカーになる", "スピーカーを推薦する", "スピーカーに立候補する" or "スピーカーにノミネートする".

Thanks for filing. @Ania-chan Would you be able to take a look, at your convenience?

@ann-kilzer sure! I'm planning to look at the remaining translations today after work 👍


EKF: Add IMU vibration calculation and reporting

Add calculation and reporting of IMU delta angle and velocity coning and high frequency vibration.
These will need to be published on the estimator_status uORB message which is currently un-used.
This has been flight tested and the messages checked using this branch: https://github.com/PX4/Firmware/pull/5682

Roman, can you take a quick look at this? It's only for data logging, but I need this data to complete the estimator health assessment tool. Thanks.

@priseborough Sure!

@priseborough The implementation looks good! Do you have some literature about those metrics?

@priseborough Is the high frequency delta angle vibration measure supposed to capture aliasing effects?
In the upper plot you have shown the value (middle plot) stays more or less constant which I guess is good.
I assume if you had aliasing you would see it growing, right?

It's very hard to detect aliasing, however large levels of higher frequency vibration that degrade accuracy of the numerical integration will show up. Normal The limits for these can be set for each platform which means that abnormal vibration levels can be caught during factory acceptance testing.

@tumbili and @bkueng Is there a wiki with information on interpreting logs that i could add explanations to for the various estimator status messages?

Not that I know of. You can add it to the msg topic, and from there we could generate a wiki page eventually.


Keep incoming Transfer-Encoding: chunked request header

This simple PR ensures that we keep the incoming Transfer-Encoding: chunked header as-is. This is in line with how we handle other request headers (#262) and also how other servers seem to handle this header. The original behavior (#137) made sense back when the server would theoretically accept alternative transfer encodings, but this option has explicitly been removed a while ago anyway (#140).
Refs #262
Refs #137
Refs #140

Rebased on master to resolve merge conflict now that #315 is in :shipit:

👍


Unknown class in Interface Builder with Carthage

I'm trying to use the RingProgressView by integrating it with Carthage, but I haven't been able to make it work by having an IBOutlet to the view.
These are the steps I took:

I added a UIView to the Interface Builder and changed the Custom Class there to RingProgressView
In my code, I imported MKRingProgressView, added the RingProgressView IBOutlet and didn't have problems connecting the reference outlet.
When I run my application, it crashed and I get the following error:

Unknown class RingProgressView in Interface Builder file.

And this is what I've tried:

Adding RingProgressView and later MKRingProgressView to Module in Custom Class in IB, as suggested by this Stack Overflow answer. This only changed the error to:

Unknown class _TtC18MKRingProgressView16RingProgressView in Interface Builder file.

Enabling Inherit Module From Target in those same settings.

None of them worked.
I'm aware that IBDesignables and IBInspectables don't work when using Carthage, but do you know how can I stop the crashes and help InterfaceBuilder "see" that the class exists?
Thank you!

Thank you very much @maxkonovalov, that worked!
I did see that workaround as well, and if I see any way it can be enabled with Carthage I'll certainly do :)


OwningRows / OwningStatement examples

From https://github.com/rusqlite/rusqlite/issues/1337#issuecomment-1858900665
And https://github.com/rusqlite/rusqlite/discussions/1198#discussioncomment-2989869

Maybe for Statement we can let user have their own implementation of the cache.
(with a nice side effect: hashlink dependency becomes optional)
And if we let user retrieve the cache key (possibly a simple index), a cached statement can be retrieved with O(1) versus the current O(nlog(n)).


charts: Add template testing

We now have streamlined way of testing Helm charts template. Refer to the documentation in charts/headlamp/tests/readme.md.
Fixes: #1954

Awesome! Thanks @knrt10 !


I would like to know actual error cause in Python

Is your feature request related to a problem? Please describe.
I set up an experiment when a client tries to connect to the server with a rotten cert and gets rejected.
grpc.RpcError that I get looks like this:
<_InactiveRpcError of RPC that terminated with: 	status = StatusCode.UNAVAILABLE 	details = "failed to connect to all addresses" 	debug_error_string = "{"created":"@1611061781.203478497","description":"Failed to pick subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":4142,"referenced_errors":[{"created":"@1611061781.203471320","description":"failed to connect to all addresses","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":397,"grpc_status":14}]}"
But I see logs (set to debug mode), that show the actual reason for the connection failure:
E0119 16:09:46.215369411   10574 ssl_transport_security.cc:1446] Handshake failed with fatal error SSL_ERROR_SSL: error:0400006b:RSA routines:OPENSSL_internal:BLOCK_TYPE_IS_NOT_01. D0119 16:09:46.215463429   10574 security_handshaker.cc:184] Security handshake failed: {"created":"@1611061786.215437927","description":"Handshake failed","file":"src/core/lib/security/transport/security_handshaker.cc","file_line":307,"tsi_code":10,"tsi_error":"TSI_PROTOCOL_FAILURE"} I0119 16:09:46.215605747   10574 subchannel.cc:1076]         Connect failed: {"created":"@1611061786.215437927","description":"Handshake failed","file":"src/core/lib/security/transport/security_handshaker.cc","file_line":307,"tsi_code":10,"tsi_error":"TSI_PROTOCOL_FAILURE"}
Describe the solution you'd like
I would like to have more information in the exception.

Duplicate of #22883.

Duplicate of #22883.


Keybase is slowing down df and possible other FS operations

Keybase GUI Version: 1.0.26-20170724171020+b095a794e
Whenever I open a system file dialog (e.g. in Sublime Text) I get a beach ball for upwards of 10s.
I also noticed df was slow and then prints an i/o error for /keybase.
This all is fixed upon closing keybase from my menubar.
df: /keybase: Input/output error
Filesystem                         Size  Used Avail Use% Mounted on
/dev/disk1                         465G  369G   96G  80% /
localhost:/M9ATJ-xxxxxxxxxxxxxx    465G  465G     0 100% /Volumes/MobileBackups
Sookasa@osxfuse0                   465G  369G   96G  80% /Users/jason/Dropbox (Periscope Data)/Sookasa
/dev/disk3                         1.9T  1.8T   38G  98% /Volumes/Seagate Backup Plus Drive
/dev/disk5s2                       5.2G  4.7G  490M  91% /Volumes/OS X Install ESD
df -h  0.00s user 0.00s system 0% cpu 10.075 total```

Hi @scopej, would you be willing to do a keybase log send and tell us the resulting ID, so we can debug why your filesystem doesn't seem to be working?

I quit the daemon to make sure it was really keybase so I'm not sure what was captured  -- First time got 2ce97284e7589c5c80edc61c (When service was stopped)
Started it back up and got ID a3801a35a7dd6518e36ea91c.
For better or worse, things look okay now.

Logs are a3801a35a7dd6518e36ea91c.

It looks like you got stuck in a known deadlock state that we've fixed in master (keybase/kbfs#1095), but which hasn't made it into a release yet.  I'm sorry about that!  Restarting Keybase should fix it temporarily until we get the next release out, as you noticed.


notify extrinsic result

currently, the app only confirms Broadcast but we get no feedback on DispatchResult. We should get that!
We may want to do #58 first as it might be done upstream?

This has indeed tackled upstream:

For well known errors we get the full error as a popup message (e.g. Insufficient Balance)
Success is only shown after the extrinsic was successful.

However, DispatchErrors from encointer palletes are currently shown as error: module. To fix that, we probably need to change something here:
https://github.com/encointer/encointer-wallet-flutter/blob/c79c8bbfc7f851b0d9aaf6c07331b25c9962441d/lib/js_service_encointer/src/service/account.js#L280

The issue here can be divided in two cases:

The error extracted in JS from:

ensure!(<encointer_scheduler::Module<T>>::current_phase() == CeremonyPhaseType::REGISTERING,
     participants can only be done during REGISTERING phase");

is {"Other":null}. This needs a fix on the pallet side to display details in the app.

The error extracted from:

if <ParticipantIndex<T>>::contains_key((cid, cindex), &sender) {
   return Err(<Error<T>>::ParticipantAlreadyRegistered.into());
}

is Data[{"Module":{"index":9,"error":0}}. Then the JS api tries to extract the error metadata, which currently fails for some reason: findMetaError: Unable to find Error with index 0x0900/[9,0]. This is the reason behind the inconcrete error: module in the popup.

I think this has been fixed in encointer/pallets#22 right? How to proceed with this issue?

Yes, the second case should be fixed.
But I did not remove all the generic Error<static &str>. Hence, some errors might still be displayed as {"Other":null}`. I suggest we improve the error handling on the pallet side, such that all errors we care about in particular, i.e. the ones that get displayed in the app, are given a specific error enum.

Closing this one favoring the more specific: https://github.com/encointer/encointer-wallet-flutter/issues/131


Eliminated the use of pbr

See commit message.

Coverage increased (+0.1%) to 40.58% when pulling 59c68aed455ac9ccf01963dfff134163071d5fb8 on andy/remove-pbr into a955cbc7cf339b9ca351c4b62e68ca5a6e4ff287 on master.


Result from log-analytics query have new data fields...but no data

Since last May, 26th 2020 I noticed 85 new data fields when I execute a log-analytics  query from AzureDiagnostics ( AZURE WAF component ) but neither one have a data.
The original data group have 61 data fields. Now we have a total of 146 data fields.
My questions:

Where we can find any documentation about these NEW data fields ?
And why they were created ? What is the goal of these new set of data fields ?

These are the new data fields:
CallerIPAddress
Caller_s
CorrelationId
DatabaseName_s
DurationMs
ElasticPoolName_s
EventName_s
JobId_g
Level
LogicalServerName_s
OperationVersion
ResultDescription
ResultSignature
ResultType
RunOn_s
RunbookName_s
StreamType_s
Tenant_g
_schema_s
clientInfo_s
code_s
conditions_None_s
conditions_destinationIP_s
conditions_destinationPortRange_s
conditions_protocols_s
conditions_sourceIP_s
conditions_sourcePortRange_s
correlation_actionTrackingId_g
correlation_clientTrackingId_s
direction_s
endTime_t
httpStatusCode_d
id_s
identity_claim_appid_g
identity_claim_http_schemas_microsoft_com_claims_authnmethodsreferences_s
identity_claim_http_schemas_microsoft_com_identity_claims_objectidentifier_g
identity_claim_http_schemas_microsoft_com_identity_claims_scope_s
identity_claim_http_schemas_xmlsoap_org_ws_2005_05_identity_claims_upn_s
identity_claim_ipaddr_s
isAccessPolicyMatch_b
macAddress_s
matchedConnections_d
primaryIPv4Address_s
priority_d
properties_enabledForDeployment_b
properties_enabledForDiskEncryption_b
properties_enabledForTemplateDeployment_b
properties_sku_Family_s
properties_sku_Name_s
properties_tenantId_g
query_hash_s
resource_actionName_s
resource_location_s
resource_originRunId_s
resource_resourceGroupName_s
resource_runId_s
resource_subscriptionId_g
resource_triggerName_s
resource_workflowId_g
resource_workflowName_s
resultDescription_ChildJobs_s
resultDescription_ErrorJobs_s
resultDescription_Summary_DurationInMinutes_d
resultDescription_Summary_DurationInMinutes_s
resultDescription_Summary_EndDateTimeUtc_s
resultDescription_Summary_EndDateTimeUtc_t
resultDescription_Summary_InitialRequiredUpdatesCount_d
resultDescription_Summary_InstallPercentage_d
resultDescription_Summary_MachineId_s
resultDescription_Summary_MachineName_s
resultDescription_Summary_RebootRequired_b
resultDescription_Summary_ScheduleName_s
resultDescription_Summary_StartDateTimeUtc_t
resultDescription_Summary_StatusDescription_s
resultDescription_Summary_Status_s
resultDescription_Summary_TotalUpdatesFailed_d
resultDescription_Summary_TotalUpdatesInstalled_d
startTime_t
status_s
subnetId_s
subnetPrefix_s
systemId_g
type_s
vnetResourceGuid_g
workflowId_s

add to S172

@cladic I cannot find doc too. Let me invite service team.

@cladic Apologies for the late reply. Could you please let me know the command that you have executed ? Are you still facing the same issue ? Awaiting your reply.

The command I use  is : az monitor log-analytics query -w (my ID workspace)  --analytics-query "AzureDiagnostics | where TimeGenerated > ago(168h) | order by TimeGenerated asc | limit 1000" > resultfile.txt
Attached is the example file ....
resultfile-example.zip


Not creating folders

Hello,
I am wondering if anyone else is having issues with installing piVPN. My SD card crapped out on my yesterday & I've been trying to get it to install and it's simply not working. There are some instances where the certificate isn't generated (simply skips over it) or when I come to add a client, it is not creating the folder ovpns to be able to write the client profile to. I've completed a fresh install of Raspian Lite - dated April 2019.
Please let me know what else I can try to help resolve this.
Thanks!

please do a fresh install and post the output of your installation log

where do I find the installation log? Just to make sure that I'm sending you the right information?

just capture the output during installation like this one: https://github.com/pivpn/pivpn/issues/97

OK, this time, it worked as expected! I'm closing this ticket.


Rough fix proposal as foundation for discussion

As I wrote:
// revert provider internal state (NOTE!!! This is fragile)
snapshot.provider._maxInternalBlockNumber = 0;
I believe that's not an option from the good quality standpoint.
I also see that the base provider resets its internal cache/state on network
changes. But do you know if/how I can use it straightforward in the mock provider? Even if yes, doesn't it contradict the fundamental design of Waffle (to have fixtures reset quickly and have good perf.; if such networks resets slow even in mocked env, so the perf deteriorates right)?

Closes #382

Got stale, closing


please there is no docs for this how can people use your package without docs

I have spend a lot of hours trying to understand what your wrote there . please add a docs to this project so people can uderstand what you had written

Hello, I added some comments, hope to help you. You are also welcome to submit pr.thx.

Hello, I added some comments, hope to help you. You are also welcome to submit pr.thx.

Okay i will check them, Thanks a lot for the effort given to this project
Le lun. 18 janv. 2021 à 03:36, 逻辑<EMAIL_ADDRESS>a écrit :

Hello, I added some comments, hope to help you. You are also welcome to
submit pr.thx.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wuweijian1997/FlutterCountdownTimer/issues/21#issuecomment-761941223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO6FACHCKNLEMRHJRYRTDHDS2ONETANCNFSM4WF573UQ
.

Okay i will check them, Thanks a lot for the effort given to this project
Le lun. 18 janv. 2021 à 03:36, 逻辑<EMAIL_ADDRESS>a écrit :

Hello, I added some comments, hope to help you. You are also welcome to
submit pr.thx.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wuweijian1997/FlutterCountdownTimer/issues/21#issuecomment-761941223,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO6FACHCKNLEMRHJRYRTDHDS2ONETANCNFSM4WF573UQ
.


Update to latest STLLoader

The current Node module complains about XHRLoader !== FileLoader.  The original source has been updated accordingly:
https://github.com/mrdoob/three.js/blob/master/examples/js/loaders/STLLoader.js
Can you roll a new Node module?

hi @ammulder,
just pushed a fix. lmk if that works for you.

v1.0.5 works fine, thanks!


LL40LS & terrain estimation: Implement proper driver-specific filtering

Issue
See https://github.com/PX4/Firmware/issues/9843
Solution
Changes:

A driver-specific filtering that is based on datasheets and experiments with this sensor (based on the concept: "If you know the specific weaknesses of your device, why not filter it directly inside the device driver). What is implemented is described here, but essentially we are now looking at a) absolute peak strength b) relative peak strength (basically signal-to-noise) and c) the absolute measurement to detect bull**** data.

All distance sensors now have a signal_strength field. I know there is also a covariance field, but it seems like basically no other sensor is using this. Signal strength is also a different concept/metric than covariance (in my opinion it is a bit easier to determine signal strength than true covariance of the measurement), so i think it is good to have both.

@priseborough @dagar I changed this line, because before I put the "if" statement the distance data was just always forwarded to the EKF even if the device limits (i.e. min/max range) were exceeded. That did not seem right to me. Can you check this please?

Testing
The filtering was tested on the bench extensively. In contrast to before, I am now getting very clean distance data from the sensor up to 27m distance, i.e. every time that LL40LS messes up the driver detects that and sets signal strength to zero. The EKF then just does not use that data because of this line . I will flight test the whole PR today and give you further feedback.
@ryanjAA or anyone else using the LidarLite: It would be good if you could test this with your sensors (which are slightly different versions) too.
Note: I am not really a low-level driver guy, so any feedback on what I might have messed up in the driver is greatly appreciated.

Can you please attach a link to a test log for this PR. I will review tomorrow.

I am resisting putting in sensor type specific threshold checks into the estimator because this will end up with multiple checks to handle the failure mechanisms for different sensor types. My preference is that the validity of sensor specific metrics such as noise variance, S/N ratio, etc is not done by the EKF. The sensor driver has access to full rate data and where estimator agnostic validity checking using pre-filtered and down-sampled data is achievable, it should be done in the sensor driver.
I would prefer a validity flag and a sensor noise variance metric to assist with estimator tuning.

I am resisting putting in sensor type specific threshold checks into the estimator because this will end up with multiple checks to handle the failure mechanisms for different sensor types. My preference is that the validity of sensor specific metrics such as noise variance, S/N ratio, etc is not done by the EKF. The sensor driver has access to full rate data and where estimator agnostic validity checking using pre-filtered and down-sampled data is achievable, it should be done in the sensor driver.

I think we totally agree with this. My approach in this PR is that each distance sensor driver calculates a signal_strength (as you say, leveraging knowledge about the specific failure mechanisms that are know for this sensor), and the ekf2 then simply has to check whether signal_strength==0.

So why 0 and not some other threshold? Isn't that sensor specific? If not, then that means we are using the signal strength also as a a de-facto validity indicator and the uORB description should be updated to state that a value of zero indicates an invalid reading.

@priseborough Log file is here: https://review.px4.io/plot_app?log=2ffbb1b4-f70f-421c-bb2c-892ecb51d623
Quick description of what is going on there (fixed-wing plane, always hand-launched):

Fixed-wing plane, hand-launched, location has a relatively constant terrain altitude at ~538m +/-3m with only a single tree which could disturb the measurement, otherwise the terrain is very clean.
t=935...1954s: Four autolaunches+autolandings
t=1985...2384: Stabilized flight, always climbing to an altitude where the distance sensor does not deliver valid readings, and then quickly descending to an altitude where it does. This was done to see how fast the terrain estimate becomes valid.
t=2384... 2670: Some higher-altitude flight in a region where the LL40LS does not deliver valid data. In contrast, it delivers a lot of outliers there. I did this to test the outlier rejection inside the driver that i added. Seems to work really nicely.
Afterwards: Manual flight, landing.

Findings/Questions from my side:

Overall seems to work really nice. Terrain estimate seems mostly correct (some slight drift observed during launches). If you compare that to the problems i had with the "old" approach here, there is a huge difference:  The terrain estimate becomes valid quickly after the distance sensor shows less than 25m, which was not the case before (where the HAGL test ratio first had to slowly converged to <1). Also, when we are actually at >25m AGL (i.e. the max_distance limit of the range sensor), then the terrain altitude is not estimated at all, whereas without this approach (see the issue again) the terrain was still always estimated and actually set to ~aircraft_altitude.
One small potential issue: At t=1777s, the terrain estimation stops briefly before a takeoff. Do you know why?
Other small potential issue: I feel like htere is a slight delay (ca 1.5 seconds) between the distance sensor delivering its first measurement of <max_distance and the terrain estimate becoming valid. It's not a big deal, but i was wondering whether this is a general delay that could later on also influence when we flare (where a 1.5s delay would make a huge difference!). The range sensor time delay parameter is only set to 5ms, so that cannot be it. Do you have any clue?

So why 0 and not some other threshold? Isn't that sensor specific? If not, then that means we are using the signal strength also as a a de-facto validity indicator and the uORB description should be updated to state that a value of zero indicates an invalid reading.

I think it is clear that for any sensor, if signal_strength=0, then the signal is invalid. This is thus not sensor-specific. Also note that what is then actually considered invalid (i.e. signal strength = 0) is decided by the driver, i.e. ekf2 again does not have to deal with this. But sure, if you want i can add a brief comment that signal_strength=0 means invalid signal.

@philipoe Yes please do.  I would prefer the term 'quality' instead of 'signal strength' because there are some optical based techniques (eg stereo camera) where the concept of a return signal strength is not applicable.

@philipoe  Please pull in  this commit https://github.com/priseborough/Firmware/commit/3e0d1dfd7751b68f56527c2cb7384f7541429162 and we can close https://github.com/PX4/Firmware/pull/9886

@priseborough I merged the commit you mentioned. But this actually requires changes to a lot of distance sensor drivers because they all now have to set signal_quality=0 when range>range_max or range<range_min. Wouldn't it be easier to keep the range_max and range_min checks there in ekf2_main?

@philipoe The quality ==0 check this adds to ekf2_main prior to pushing data into the EKF is additional to the range checking that the ekf does internally, so we are not giving up anything we had before with those sensors.

Ok, great, hadn't seen that...

https://github.com/PX4/ecl/blob/master/EKF/control.cpp#L1152

I will give this a test on SITL at commit https://github.com/PX4/Firmware/pull/9865/commits/3e0d1dfd7751b68f56527c2cb7384f7541429162 but it would be good if someone with a LidarLite can also run a test.

The sonar data when running 'make posix gazebo_iris_opt_flow' is clipped such that it never exceeds max_distance and min_distance and therefore always passes checks. I will fix this in a separate PR. With the limits adjusted so that distance_sensor.distance can exceed the  distance_sensor.max_distance and distance_sensor.min_distance, the test works as expected.

https://logs.px4.io/plot_app?log=ff9d9030-9dd5-4f3d-88a7-eed28bb577e3

@philipoe, did you have a chance to test your changes and @priseborough's changes during a test-flight?
I just installed the Lidar-Lite v3 in our Wing Z-84 plane and I was going to test it tomorrow.  However, I currently have the v1.8.0 release installed in the PixRacer. Should I rebuild the firmware from master instead and test it?

@philipoe, did you have a chance to test your changes and @priseborough's changes during a test-flight?

Not yet, no. I did test this PR up to f94b976 however.

@philipoe Your issue #9843 seems to be more concerning about the autoland.  If that is the case, then the current LL40LS driver in the v.1.8.0 release should work fine as long as the plane is landed manually.  Is that correct?
BTW, do you also get a max_distance of 25m when you run the "ll40ls test" command from the shell?
According to the spec, the max should be up to 40m.

@philipoe Your issue #9843 seems to be more concerning about the autoland. If that is the case, then the current LL40LS driver in the v.1.8.0 release should work fine as long as the plane is landed manually. Is that correct?
It works fine in the sense that it delivers values. It however cannot determine what the quality of these values is. Of course, if you land the plane manually, then this does not influence anything and thus does not matter.

BTW, do you also get a max_distance of 25m when you run the "ll40ls test" command from the shell?

The 25m max distance value was set some time ago and makes sense, because the sensor actually gets quite unreliable above 25m (although it can of course measure higher distances).


Issue with onError handling on newer version of Dio

Apparently there is an issue related to this https://github.com/cfug/dio/issues/2167

Could you provide more details? The interceptor that this library wrote does not implies async with void.

Seems like the issue is with dio itself and it's already fixed in the latest 2.4.5+1 version. I will close this issue. Thanks for your response.


Asset only deferred components cause startup crash

Steps to Reproduce

Create an application with deferred components containing ONLY assets. (Aka: no loadingUnitMapping is generated/required). Using the recommended FlutterPlayStoreSplitApplication
See that the prebuild validator notifies that <meta-data android:name="io.flutter.embedding.engine.deferredcomponents.DeferredComponentManager.loadingUnitMapping" android:value=""/> is required in the base module manifest
Ensure proguard does not obfuscate the DeferredComponentManager (or it won't resolve the correct key to load from the manifest)
Run the app

Expected results: App runs normally
Actual results: Crash during startup because the empty manifest value is being split and parsed as an integer in PlayStoreDeferredComponentManager which does not work. (String split returns for the empty string an array containing the empty string, not an empty array)

Logs
java.lang.RuntimeException: Unable to create application io.flutter.app.FlutterPlayStoreSplitApplication: java.lang.NumberFormatException: For input string: ""
                         E      at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6465)
                         E      at android.app.ActivityThread.access$1300(ActivityThread.java:219)
                         E      at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1859)
                         E      at android.os.Handler.dispatchMessage(Handler.java:107)
                         E      at android.os.Looper.loop(Looper.java:214)
                         E      at android.app.ActivityThread.main(ActivityThread.java:7356)
                         E      at java.lang.reflect.Method.invoke(Native Method)
                         E      at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
                         E      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
                         E  Caused by: java.lang.NumberFormatException: For input string: ""
                         E      at java.lang.Integer.parseInt(Integer.java:627)
                         E      at java.lang.Integer.parseInt(Integer.java:650)
                         E      at io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.<init>(PlayStoreDeferredComponentManager.java:25)
                         E      at io.flutter.app.FlutterPlayStoreSplitApplication.onCreate(FlutterPlayStoreSplitApplication.java:2)
                         E      at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1182)
                         E      at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6460)

Flutter doctor (relevant part)
[✓] Flutter (Channel unknown, 2.2.0, on macOS 11.3 20E232 darwin-x64, locale en-BE)
    • Flutter version 2.2.0 at /Users/<redactd>/fvm/versions/2.2.0
    • Framework revision b22742018b (4 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

Hi @NicolaVerbeeck
Thanks for filing the issue and the PR.
I'm following doc to reproduce and your steps are a bit specific.
Do you mind creating a sample repo to reproduce this?
Thank you

@TahaTesser here you go: https://github.com/NicolaVerbeeck/deferred_crash_example

Hi @NicolaVerbeeck
Thanks so much for the sample, I can reproduce the crash
Reproduced on the following channels

stable
master

✅
✅

Check flutter doctor -v outputs for each channel below

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.0, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.2.0 at C:\Users\Taha\Code\flutter_stable
    • Framework revision b22742018b (6 days ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (4 available)
    • IN2011 (mobile)   • c9d8ee0c • android-arm64  • Android 11 (API 30)
    • Windows (desktop) • windows  • windows-x64    • Microsoft Windows [Version 10.0.19042.985]
    • Chrome (web)      • chrome   • web-javascript • Google Chrome 90.0.4430.212
    • Edge (web)        • edge     • web-javascript • Microsoft Edge 90.0.818.56

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.3.0-13.0.pre.87, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 2.3.0-13.0.pre.87 at C:\Users\Taha\Code\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4d6a925326 (3 hours ago), 2021-05-21 01:09:02 -0400
    • Engine revision 20260fb95f
    • Dart version 2.14.0 (build 2.14.0-134.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.6)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31313.79
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

[✓] VS Code (version 1.56.2)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.22.0

[✓] Connected device (5 available)
    • IN2011 (mobile)         • c9d8ee0c • android-arm64   • Android 11 (API 30)
    • Windows (desktop)       • windows  • windows-x64     • Microsoft Windows [Version 10.0.19042.985]
    • Windows (UWP) (desktop) • winuwp   • windows-uwp-x64 •
    • Chrome (web)            • chrome   • web-javascript  • Google Chrome 90.0.4430.212
    • Edge (web)              • edge     • web-javascript  • Microsoft Edge 90.0.818.56

• No issues found!

✅ : Reproducible ❌: Not Reproducible

@TahaTesser thanks for taking the time to triage!

https://github.com/flutter/engine/pull/26333 Should fix this.


Extend SimpleModelVerifier with basic functionality

The SimpleModelVerifier must return false in its verify method, if the passed type hase global duplications.
same AttributeRule names in different ModelElements
same AssociationRule relationNames in different ModelElements

related to #29


Support flexible LCOW layer parsing and partitioned layers

This is commit 6/6 in a chain. Recommended to review in order. If reviewing a later PR in the chain, you can view individual commits to see just what that PR changes.

#1740
#1741
#1742
#1743
#1744
#1745

This PR increases the flexibility of how we handle LCOW layers. This gives us greater ability to represent layers differently. For example, this PR also adds a new lcow-partitioned-layer type which consists of a VHD path and a partition index on that VHD for each read-only layer.
Please see individual commits for details.

I bypassed branch protection on the merge since the latest push was just a simple rebase on top of main after the previous stacked PR was merged.


Publishing of recent versions to npm Registry

The most recent version of this package tagged here is v1.9.3, but I don't see anything on npmjs.com since 1.9.0 a year ago:
https://www.npmjs.com/package/acorn-import-assertions
There's a security fix in 1.9.2 (fully qualifying the test262 dependency) that it would be good to get into the published release.

Now https://github.com/xtuc/acorn-import-attributes/pull/32 is merged this may be as simple as cutting a new tag?


On demand menu not working on iOS

I am developing a website with this library and I have to build context menu on demand with left trigger.
Some customers complaint about it doesn't work on iOS.
I checked demo website, it doesn't work:
http://medialize.github.io/jQuery-contextMenu/demo/dynamic-create.html
Also I have done a simple modification of demo code to trigger from left click and it doesn't work.
I have seen this bug:
https://github.com/medialize/jQuery-contextMenu/issues/83
Could it be related to the same issue, and maybe it has not been fixed in on demand feature?
Thank you

I have solved it adding:
$('.context-menu').on('click', function() {});
on line 1327, after $document.on({});
In my case, all context menu triggers have "context-menu" class.

Yeah, its the issue that iOS needs an onclick handler.
onclick="void('iOS needs this');"
You can see that on the left click demo.

@bbrala
I have create a new issue https://github.com/swisnl/jQuery-contextMenu/issues/628


Update artemis-jms-client-all to 2.21.0

Updates org.apache.activemq:artemis-jms-client-all from 2.19.1 to 2.21.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

To merge this PR we need to drop java8 support, this ActiveMQ release requires Java 11 or above:
https://activemq.apache.org/components/artemis/download/release-notes-2.21.0

Superseded by #300.


Create test.md

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

enterprise-graph/test.md
100
100
0
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 8e1f7c4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

enterprise-graph/test.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove StaticArrays dependency

Change Coord from being a SVector{4, Float64} alias to a struct implemented here. This struct is now mostly internal, since tuples are always returned from transformations. Length of the output tuple still depends on the input length. SVectors still work as input coordinates, just like tuples, vectors, and multiple arguments f(x, y).
I included a benchmark here that shows that performance is good:
https://github.com/JuliaGeo/Proj4.jl/blob/a2e71c159a5892b0986e1b933fe0ff405ce940a2/test/benchmark.jl
This is the same benchmark as used here: https://github.com/JuliaGeo/Proj4.jl/pull/51#issuecomment-864467491. For types like SVector or tuples the return type (tuple length) can be inferred precisely, for Vector it infers Union{NTuple{2,Float64},NTuple{3,Float64},NTuple{4,Float64}} which is as good as we can expect.
This is on top of #57, but since it changes the return type of transformations I wanted to put it up separately for review. I think after this #57 would be ready for release, I was thinking to make it Proj.jl v1, such that we can actually start using the minor version number for features.

Thanks for having a look, and good point about the return type. Returning the same type was originally a design goal, see also old discussion here. It looks like on top of this refactor it's really as easy as #65.


Spout Sender & Receiver

What problem does this solve or what need does it fill?
Ability to send Bevy's video frames in real time to another software for further processing.
Ability to receive video frames in real time from another software and include it in Bevy's renderings.
What solution would you like?
Spout (https://spout.zeal.co/) is the non-network solution implemented in Openframeworks, Processing, TouchDesigner, OBS and others, see https://leadedge.github.io/spout-projects.html
What alternative(s) have you considered?
On windows it seems there are no other alternatives to Spout.
NDI (or any other network based solution) forces codec settings and is less efficient.
Additional context
I would like to migrate a real-time off-screen 3D project developed in Scala and use Bevy/Rust instead.
I searched for the keyword "spout" in the Bevy project and did not find any results.

Is there a reason why this cannot be done as an ecosystem crate? It seems the plugin level support on all of these other engines seem to operate just fine.


Critical error with add text data with ENTER

WINDOWS 10
DBeaver 7.2.3
Postgresql 9.6, Postgresql 12
#1 Case:
1.CREATE TABLE gty_test.newtable_11 (
id int4 NOT NULL,
id_group text NOT NULL,
CONSTRAINT newtable_11_pk PRIMARY KEY (id, id_group)
);

add new row "sssssss"

Ok. Row saved
add new row with ENTER after s symbol
"sssssss
dddd"

try to copy(Ctrl+c) this string to newtable_11.id_group column
past(Ctrl+v)

Where is part dddd before ENTER?? Symbol after ENTER is not pasted.
#2 Case2:
1.CREATE TABLE gty_test.newtable_11 (
id int4 NOT NULL,
id_group text NOT NULL,
CONSTRAINT newtable_11_pk PRIMARY KEY (id, id_group)
);
2. added new row with ENTER from pgAdmin4 interface without problem
"sssssss
dddd"

Go to Debeaver
And try to update newtable_11.id_group to string "v"

After that DBeaver is crashed
1.CREATE TABLE gty_test.newtable_33 (
id int4 NOT NULL,
id_group text NOT NULL,
CONSTRAINT newtable_33_pk PRIMARY KEY (id, id_group)
);

Try to add any data to new table with error

Object parameter [ttt] binding not supported
Object parameter [3333] binding not supported
Object parameter [ggggg] binding not supported

version 7.1.4 without problem CASE2

@detkliff could you check if issue is reproducible for you against EA version? https://dbeaver.io/files/ea/
Thanks in advance

@detkliff could you check if issue is reproducible for you against EA version? https://dbeaver.io/files/ea/
Thanks in advance

I can't check this file version because the download speed is 14kb\s from this repository

I'm having same behaviour in Versión <IP_ADDRESS>010191702

I'm having same behaviour in Versión <IP_ADDRESS>010191702

I had not this error in 7.2.4 version. Updated today

version 7.2.4 had #1 error. DBeaver cat my copyed  string.

Thank you for the report. Case 1 is actual for different databases.
It can be reproduced in postgres.Xeniia.newtable_11 (try to enter  a value
"sssssss
dddd"
(with Enter symbol between sssssss and dddd))

I confirm that v7.3.4 is working for my use case.

Can't reproduce on DBeaver 7.2.3 and 7.2.4, Windows 7 and 10, PostgreSQL 10 and 12.

@detkliff any error logs, perhaps?

Can't reproduce on DBeaver 7.2.3 and 7.2.4, Windows 7 and 10, PostgreSQL 10 and 12.

@detkliff any error logs, perhaps?

no Error in this case.
Version 7.2.5

In Dbeaver SQL Editor
CREATE TABLE test.nt (
key int4,
val text,
is_active bool
)
Open data tab of table test.nt

a) I try to enter string
"sssssss
dddd"
from interface  sssssss

end press ENTER.  Dbeaver saved "sssssss" only.
b) I try to copy\paste
string
"sssssss
dddd" from Dbeaver SQL Editor or any text editor

press CTRL+C or press right button and press Copy
Open data tab of table test.nt
Press right button on a cell and press Paste

Dbeaver cut off string after "sssssss".
Example from pgAdmin4

press CTRL+C

press CTRL+V and Save
Open data tab of table test.nt in DBeaver

Duble click on cell, copy text from cell and past before string

Dbeaver cut off string after "sssssss" again.

Can't reproduce on DBeaver 7.2.3 and 7.2.4, Windows 7 and 10, PostgreSQL 10 and 12.

@detkliff any error logs, perhaps?

can you record a video of how could you enter your line into a cell with ENTER symbol?

I don't use any special steps, unfortunately.
How about "Advanced paste" (ctrl + shift + v).  Doesn't work either?
I can also suggest "Reset workspace", very, very rare, but it can helps

I don't use any special steps, unfortunately.

fantastic

I don't use any special steps, unfortunately.
How about "Advanced paste" (ctrl + shift + v). Doesn't work either?
I can also suggest "Reset workspace", very, very rare, but it can helps

@detkliff i see, but so far I can not help in any way.
As a workaround paste data through value tab (в поле "Значение").

@detkliff i see, but so far I can not help in any way.
As a workaround paste data through value tab (в поле "Значение").

Reset workspace - no effect =(

@detkliff i see, but so far I can not help in any way.
As a workaround paste data through value tab (в поле "Значение").

what is your version of DBeaver?

@detkliff 7.2.3, 7.2.4, 7.25 and 7.3 Enterprise edition. And two more testers looked without results.

@detkliff 7.2.3, 7.2.4, 7.25 and 7.3 Enterprise edition. And two more testers looked without results.

thank you very much, I understand what the problem is i am try to duble clicked on cell and past string. But if i click once on cell, this string pasted without problem

@detkliff I'm glad the problem was solved, hurray)


Use modern META filename

The META.info is a legacy, pre-Christmas name. While it's still currently supported, META6.json is the new name. And since a lot of people simply copy some module's  structure, the old name still proliferates, so we're trying to get rid of it for good  by sending PRs to any modules that use the old name, to switch to the modern name.

Updated separately, due to conflicts.


[hotfix][runtime] Fix a comment typo in CheckpointBarrierAligner

What is the purpose of the change
Fix a comment typo in CheckpointBarrierAligner
Brief change log

Fix a comment typo in CheckpointBarrierAligner

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

LGTM


Where to pass bearer token?

Wanted to see if I could replace my internally built UC API wrapper but using this package I cannot figure out how to pass a bearer token?
Tried passing the below to extra_headers, but no luck unfortunately.
headers = {
  "Authorization": f"Bearer {my_token}",
  "Content-Type": "application/json",
}

This is how we did it in daft using this package.
unitycatalog.Unitycatalog(
            base_url=endpoint.rstrip("/") + "/api/2.1/unity-catalog/",
            default_headers={"Authorization": f"Bearer {token}"},
        )

What sort of error are you getting?

Ah didn't realize that you have to explicitly add /api/2.1/unity-catalog, in my own wrapper this was automatically appended to the uri

@ion-elgreco Yeah currently this project is just generated from the openapi stubs. I think it would be a good idea to build a higher level api that we can also expose.
We could move over the Daft code to here:
https://github.com/Eventual-Inc/Daft/blob/d2107b75966eed116403123e97ef29abdd0db8ec/daft/unity_catalog/unity_catalog.py#L12


Formatting of heading text wrapped in backticks

The display of inline code snippets wrapped in backticks seems a little funky. For example the heading ## Why Run Pytest Using `python -m` and Not `pytest` ? is displayed as shown in the image below. This is within a callout block, which may also be related.

Another example here, also in a callout block

I cant recreate this at all either on the live site or locally, all headings render correctly for me across all the browsers so I am closing this for now.


Can't delete related entries in stack

Bug Description
We have Orphans  that HasMany Updates. We've displayed them in a section tab.
Can't delete them. When I click the Delete, nothing happens.

Steps to reproduce

have a resource w/ a HasMany relationship
display them in the CP via the HasMany field.
Attempt to delete them.

Environment
Statamic 3.2.35 Pro
Laravel 8.83.3
PHP 8.1.3
aryehraber/statamic-captcha 1.7.0
aryehraber/statamic-uuid 2.0.3
doublethreedigital/duplicator 2.1.1
doublethreedigital/runway 2.3.0
edalzell/forma 1.0
edalzell/private-eye dev-main
jonassiewertsen/statamic-livewire 2.7.1
statamic/seo-pro 2.3.2
transformstudios/events 3.3.3
transformstudios/front 1.9.2
transformstudios/gated dev-main
transformstudios/magic-link dev-main
transformstudios/memorial dev-main
transformstudios/review 3.2.1
transformstudios/simple dev-main
transformstudios/takeover-redirects dev-main

Does this happen outside of stacks as well?

Bad description, not in a stack, standard view.

Gotcha! Any console errors? I'll take a look tomorrow (probably!)


Fix NULL dereference in EVP_PKEY_get_raw_private_key

When EVP_PKEY_get_raw_private_key or EVP_PKEY_get_raw_public_key is called with a provider side key, there is a NULL dereference.
Fixes https://github.com/openssl/openssl/issues/11627

This fixes the NULL deref, but still means that EVP_PKEY_get_raw_private_key/EVP_PKEY_get_raw_public_key return an error for provider side keys.
Probably we should just call evp_keymgmt_export for provider keys and make these APIs function correctly.

This fixes the NULL deref, but still means that EVP_PKEY_get_raw_private_key/EVP_PKEY_get_raw_public_key return an error for provider side keys.
Probably we should just call evp_keymgmt_export for provider keys and make these APIs function correctly.

EVP_PKEY_new_raw_private_key and EVP_PKEY_new_raw_public_key must be considered too in that case.  Please don't make just half a fix.

Thanks for your PR. This prompted me to dive into this deeper and I found numerous other issues. Alternative fix in #11635.


Add utm_source parameter to notification emails

It might have been possible to do this in the content template, but this feels more reliable. This will help judge traffic from assignment, test, and group join notification emails

LGTM! 👍


Change enabled configuration text in README

The way I read this, 'disables' should be 'enables'. Is this correct?

Already merged


Exec tachikoma update<PHONE_NUMBER>2819

:hamster::hamster::hamster:   Strategy bundler
Powered by Bundle Update as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Changes Unknown when pulling 27080591cd8b2c76b897412ef90a60a8f8928a30 on pazjacket:tachikoma/update-20160330072819 into ** on shirasagi:master**.


Support in Bitbucket

Hi, all.
We are using bitbucket in our company, so I would like to ask if you will consider supporting bitbucket.
Thanks.

Hey, sorry, for now, I don't have capacity to support other platform such as bitbucket, you could try to clone this repo and integrate the API of bitbucket yourself.


[BUG] soul vial unable to capture a mob

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
soul vial unable to capture a mob
it does  a right click "animation" but the item never changes and the mob never gets captured
Expected Behavior
the mob goes into the soul vial
Steps To Reproduce
right click a mob with a soul vial
Environment
- OS:                windows
- Java version:      17.0.3
- Minecraft version: 1.20.1
- Version:           1.20.1-6.0.14-alpha

Anything else?
No response

it's been reported already


limit max character on web deploy

Hi @killerangels , Please try to shorten the Path, for example C:\Projects\SimplCommerce\ or D:\Projects\SimplCommerce

solved


Show legends on charts #1651

It will be handy to have legends on the charts so that is easy for the reader to read the chart. #1651
Here is a desktop view

Downloaded image:

Closing it, It seems like someone already did that.
Thank you!