[$500] Create a useResponsiveLayout hook

Slack context: https://expensify.slack.com/archives/C01GTK53T8Q/p1698364514493649
Problem
There are some times when we want to use the same layout on mobile devices or in the RHP on wide screens. In these cases, we can't rely on isSmallScreenWidth from useWindowDimensions to determine which layout to use, so we have hard-coded and/or different solutions we use to address the same problem.
Solution

In the navigation stack, add an isInRHP route prop to all screens in the RHP.

Write a custom hook called useResponsiveLayout that does something like this:
function useResponsiveLayout() {
    const {isSmallScreenWidth} = useWindowDimensions();
    const {params} = useRoute();
    return {
        shouldUseNarrowLayout = isSmallScreenWidth || params.isInRHP,
    };
}

Replace most layout-motivated uses of useWindowDimensions with useResponsiveLayout like so:
- const {isSmallScreenWidth} = useWindowDimensions();
+ const {shouldUseNarrowLayout} = useResponsiveLayout();

Introduce a new lint rule that prohibits using isSmallScreenWidth from useWindowDimensions, advising developers to use shouldUseNarrowLayout instead.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f36dcb081cdf74b2
Upwork Job ID:<PHONE_NUMBER>365408768
Last Price Increase: 2023-10-27

I can work on this if no one is assigned yet, or should I write proposal

Problem:
In the current application, there is a challenge when needing to use the same layout for both mobile devices and the right-hand panel (RHP) on wide screens. This problem arises because it's not always feasible to rely on the isSmallScreenWidth variable from useWindowDimensions to determine which layout to use. As a result, developers often resort to hard-coded and inconsistent solutions to address this issue.
Solution:
To address this problem, the following changes are proposed:
Route Prop for RHP Detection: In the navigation stack, it is suggested to add an isInRHP route prop to all screens within the RHP. This addition allows for easy identification of screens within the RHP.
Custom Hook - useResponsiveLayout: Create a custom hook called useResponsiveLayout to determine the appropriate layout based on the screen width and the isInRHP route prop.
function useResponsiveLayout() {
    const { isSmallScreenWidth } = useWindowDimensions();
    const { params } = useRoute();
    return {
        shouldUseNarrowLayout: isSmallScreenWidth || params.isInRHP,
    };
}

Replace useWindowDimensions with useResponsiveLayout: To ensure a consistent approach to layout handling, replace most of the current uses of useWindowDimensions with useResponsiveLayout as shown below:
// Before
const { isSmallScreenWidth } = useWindowDimensions();

// After
const { shouldUseNarrowLayout } = useResponsiveLayout();
Introduce a Lint Rule: To maintain code quality and consistency, introduce a new lint rule that discourages the use of isSmallScreenWidth from useWindowDimensions. Developers are advised to use shouldUseNarrowLayout instead.
This proposed solution aims to provide a more unified and maintainable approach to handling responsive layouts in the application. These changes simplify the management of layouts across various screen sizes and ensure a more consistent user experience.

Thanks for all the proposals everyone. At this time I've decided to move forward with the one that feels the clearest and most high-quality, which in my opinion is from @rayane-djouah here.

@rayane-djouah any updates?

can someone provide an update on the status of this issue? thanks!

Since we're splitting this up into a few PRs, @rayane-djouah, can you lay out the related PRs in sequence please?

Doubling the bounty here due to large scope

moving to daily since payment is coming up soon

@maddylewis since we are splitting the PR into multiple small PRs we should only process payment once the last PR gets merged. this is only the first one.

Agreed. Left some comments on the 2nd PR.

@rayane-djouah we're awaiting changes in the 2nd PR

Based on this comment here, this one is not ready for payment and there is an upcoming PR that needs to go to production before I can move forward with the payment process.
For now, I updated the Upwork job link:
https://www.upwork.com/jobs/~0123a7c663aaab8163
@getusha and @rayane-djouah -- please apply and we can be ready for the payment date.
Heads up, I will be offline until Tuesday, but will catch up then to identify the status of the last PR. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the Open Source Slack Room-- thanks!

@getusha two requests:

Please apply to the Upwork job: https://www.upwork.com/jobs/~0123a7c663aaab8163

Can we get feedback if this Deploy Blocker notice is accurate to the first PR or unrelated to this GH? Thanks!

@getusha and @roryabraham - to confirm, this one is pending one last PR, so the January 24 payment date is inaccurate - right? Thanks!

Yes, there's more than 1 outstanding PR. This should not be awaiting payment yet.
@getusha any update on when you'll be able to review this? It's not particularly high-priority, but better to not have it drag on longer than necessary. If you're currently prioritizing something else, that might be ok – just try to communicate a bit more actively. Thanks!

Thank you for confirming!

@alexpensify here is a list of PRs we should complete before payment https://github.com/Expensify/App/issues/30528#issuecomment-1868485991
@rayane-djouah @roryabraham i think we should avoid putting the issue link on upcoming PRs to make the automation stop triggering.

Thank you for this update and noted!

@rayane-djouah when do you think you'll be able to raise the next PR?

Thanks, will try to complete the review tomorrow.

@rayane-djouah @getusha just checking in here – how are we doing and what are our next steps?

needs to update https://github.com/Expensify/App/pull/34837 to resolve some merge conflicts. Anything else?

Yes, @rayane-djouah will complete the checklist & resolve conflicts.

Looks like we are making progress here!

Weekly Update: Making progress

Weekly Update: @rayane-djouah some of the PRs are still in draft mode
Can we get an update in the PR list you put together here - https://github.com/Expensify/App/issues/30528#issuecomment-1868485991

The PR listed above is still in review

Weekly Update: the PR is moving forward.

Weekly Update: The PR is going through reviews but moving along.

Weekly Update: The PR is in review to make sure testing passes.

Weekly Update: The PR went through another review process and more testing.

Weekly Update: More discussion in the PR due to recent findings

@roryabraham can I get feedback regarding which Wave or VIP to associate this one with? -- thanks!

Weekly Update: We are in a focus period, I'll check in next week.

This is a pretty old issue, and I'm not sure which wave or VIP I'd associate it with. It's basically a low-level code improvement to help avoid a semi-common mistake and make the code more consistent. Some recent discussion about it in slack here.

Thanks for the context @roryabraham!
Weekly Update: The PR is moving in review again: https://github.com/Expensify/App/pull/36292

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.
If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

Catching up from being OOO, it looks like this one was on hold due to the freeze but we can carry on now.

PR merged today

Weekly Update: It looks like there was regression, but that has been addressed. I'll check again next week to confirm if we can move forward with the payment process.

Automation failed here, I need to start the payment process tomorrow since today marks 7 days in production.

@alexpensify there are still other PRs we need to get merged https://github.com/Expensify/App/issues/30528#issuecomment-1868485991

@getusha, thanks for flagging; I appreciate it. With that said, are we still striking the completed ones? If not, we should to keep a better record of what's left. For now, I'll hold on the payment process.

@rayane-djouah i think we can put the remaining changes in a single PR except the eslint-config-expensify changes

sounds good 👍🏼

@getusha and @rayane-djouah - can either of you confirm if this notice is accurate or not? Thanks!

Ok, waiting on https://github.com/Expensify/eslint-config-expensify/pull/116 to go into production

pulling in @mountiny to take over while I'm on parental leave

ESLint rule merged @rayane-djouah can you raise App PR now please?

Heads up, I will be offline until Tuesday, October 22, 2024, and will not actively watch over this GitHub during that period.
If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

No regression tests required this is a tool for developers
The payment summary is $1000 to @rayane-djouah and to @getusha

Payouts due: 2024-10-30

[ ] Contributor: $250 @rayane-djouah
[ ] Reviewer: $250 @getusha

Upwork job is here. I had to create a new job in Upwork. Please accept and I can complete the payment process. Thanks!

🤦🏼 good catch - Upwork was right. I've updated the summary here and paid @rayane-djouah via Upwork. I'm waiting for @getusha to accept.

Status: Waiting for @getusha to accept in Upwork

Thanks for flagging! This GH is from 2023. I think it needs to be paid via Chat, but let me double-check.

I confirmed that this one is from 2023. It will need to be paid via Upwork. I will move this to weekly since I'm OOO until Tuesday. @getusha, keep me posted when you accept it in Upwork. I'll complete the process when I'm back online.

All set, everyone has been paid via Upwork: https://github.com/Expensify/App/issues/30528#issuecomment-2448951102


Bug: Setting password from a JSON request return a type error when using strong_password validation rule

PHP Version
8.3.6
CodeIgniter4 Version
4.5.3
Shield Version
1.1.0
Which operating systems have you tested for this bug?
macOS
Which server did you use?
cli-server (PHP built-in webserver)
Database
MySQL
Did you customize Shield?
No
What happened?
When i get a request via a standard POST like $request = $this->request->getPost(); this strong_password validation work fine.
But on another case am am build a web app with svelte and and sending a fetch to my CI4 backend with json data like $request = (array) $this->request->getJSON();. This method then return an error message titled: TypeError: CodeIgniter\Shield\Entities\User::setEmail(): Argument #1 ($email) must be of type string, null given, called in
It works when using getPost but fail to work when using getJSON. I can only bypass this error is i remove strong_password validation rule.
Steps to Reproduce
Retrive a json data in array form
$request = (array) $this->request->getJSON();
Try to validation this incoming request
$rules = $this->getValidationRules();
if (! $this->validateData($request, $rules, [], config('Auth')->DBGroup)) {
            $errors = $this->validator->getErrors();
            return $this->failValidationErrors(array_shift($errors));
        }

Try to save validation data to you db (Remember to enable strong_password validation rule)
new User($request);
Expected Output
This should create a new user account on my database.
Anything else?
No response

Please show all error message, backtrace, not only one line when you show errors.
CodeIgniter\Shield\Entities\User::setEmail(): Argument https://github.com/codeigniter4/shield/pull/1 ($email) must be of type string, null given, called in

Please show a sample data to reproduce the error.
Otherwise we cannot reproduce.
$request = (array) $this->request->getJSON();

I am sending a JOSN data form my frontend to the backend to create new user account. Here is my Controller that extends ShieldRegister
`public function register(): ResponseInterface
{
$request = (array) $this->request->getJSON();
$rules   = $this->getValidationRules();
    if (! $this->validateData($request, $rules, [], config('Auth')->DBGroup)) {
        $errors = $this->validator->getErrors();

        return $this->failValidationErrors(array_shift($errors));
    }

    $this->accountModel->save(new User([
        'username' => $request['username'],
        'email'    => $request['email'],
        'password' => $request['password'],
        'active'   => false,
        'status'   => 0,
        'uuid'     => service('uuid')
            ->uuid4()
            ->toString(),
    ]));

    // Send verification key
    $code = generate_rand_keys(10);

    $this->emailVerifyKeyModel->save(new EmailVerifyKey([
        'email' => xss_clean($request['email']),
        'code'  => $code,
    ]));

    // Send email to Mentor
    $email = xss_clean($request['email']);
    $data  = [
        'code'     => $code,
        'username' => xss_clean($request['username']),
        'link'     => "https://witvafrica.com/verify-email?email={$email}&code={$code}",
    ];

    $mailData = [
        'subject' => 'Verify Your Email',
        'to'      => xss_clean($request['email']),
    ];
    Utility::sendEmail($data, $mailData, 'verify-email');

    return $this->respond([
        'message' => 'Registration successful please check your email',
    ]);
}

`
Thie work when i remove strong_password validation rule but fail when added.
Error Output:
INFO - 2024-07-10 06:46:29 --> Session: Class initialized using 'CodeIgniter\Session\Handlers\FileHandler' driver.
CRITICAL - 2024-07-10 06:46:29 --> TypeError: CodeIgniter\Shield\Entities\User::setEmail(): Argument #1 ($email) must be of type string, null given, called in /Users/zubdev/Workspace/clients/wiafrica/witv_backend/vendor/codeigniter4/framework/system/Entity/Entity.php on line 450
[Method: POST, Route: app/register]
in VENDORPATH/codeigniter4/shield/src/Entities/User.php on line 242.
1 SYSTEMPATH/Entity/Entity.php(450): CodeIgniter\Shield\Entities\User->setEmail(null)
2 SYSTEMPATH/Entity/Entity.php(165): CodeIgniter\Entity\Entity->__set('email', null)
3 SYSTEMPATH/Entity/Entity.php(146): CodeIgniter\Entity\Entity->fill([...])
4 VENDORPATH/codeigniter4/shield/src/Authentication/Passwords/ValidationRules.php(92): CodeIgniter\Entity\Entity->__construct([...])
5 VENDORPATH/codeigniter4/shield/src/Authentication/Passwords/ValidationRules.php(52): CodeIgniter\Shield\Authentication\Passwords\ValidationRules->buildUserFromRequest()
6 SYSTEMPATH/Validation/Validation.php(335): CodeIgniter\Shield\Authentication\Passwords\ValidationRules->strong_password('Pa$$w0rd!', null)
7 SYSTEMPATH/Validation/Validation.php(201): CodeIgniter\Validation\Validation->processRules('password', 'Password', 'Pa$$w0rd!', [...], [...], 'password')
8 SYSTEMPATH/Controller.php(152): CodeIgniter\Validation\Validation->run([...], null, null)
9 APPPATH/Controllers/App/Auth/RegisterController.php(58): CodeIgniter\Controller->validateData([...], [...], [], null)
10 SYSTEMPATH/CodeIgniter.php(933): App\Controllers\App\Auth\RegisterController->register()
11 SYSTEMPATH/CodeIgniter.php(509): CodeIgniter\CodeIgniter->runController(Object(App\Controllers\App\Auth\RegisterController))
12 SYSTEMPATH/CodeIgniter.php(355): CodeIgniter\CodeIgniter->handleRequest(null, Object(Config\Cache), false)
13 SYSTEMPATH/Boot.php(325): CodeIgniter\CodeIgniter->run()
14 SYSTEMPATH/Boot.php(67): CodeIgniter\Boot::runCodeIgniter(Object(CodeIgniter\CodeIgniter))
15 FCPATH/index.php(56): CodeIgniter\Boot::bootWeb(Object(Config\Paths))
16 SYSTEMPATH/rewrite.php(44): require_once('/Users/zubdev/Workspace/clients/wiafrica/witv_backend/public/index.php')

Please note if request is send as a standard post data it will work with strong_password validation rule added or note.

We use GitHub issues to track BUGS and to track approved DEVELOPMENT work packages. We use our forum to provide SUPPORT and to discuss FEATURE REQUESTS.

The data was logged in a log file to debug and bothe data (Post and Json) are the same.
$postData = $this->request->getPost();
$jsonData = $this-request->getJSON();

I have to remove strong_password validation rule for this to work.
Thanks.

Try to set strong_password[].

@kenjis wow thank you! it works. I will now remove this issue.


Add option to specify a root certificate

When the packet forwarder connects to the discovery server, the discovery server declares his identity using a certificate, that can be self-generated in the case of a private network. But if it's self-generated, the packet forwarder cannot verify it, and the connection fails:
pi@raspberrypi:~ $ ./packet-forwarder start
  INFO Packet Forwarder for LoRa Gateway        HALVersionInfo=Version: 4.0.0; Options: native;
  INFO Found gateway parameters, getting frequency plans AuthServer=http://account.test.thethings.network GatewayID=raspi URL=http://account.test.thethings.network/api/v2/frequency-plans/EU_863_870
  INFO Refreshed account server information     TokenExpiry=2017-09-10 11:41:59.262825864 +0000 UTC
  INFO Connecting to TTN discovery server       Address=test.thethings.network:1900
 ERROR The program ended following a failure    error=Network configuration failure: x509: certificate signed by unknown authority source=Run: /builds/thethingsnetwork/packet_forwarder/gopath/src/github.com/TheThingsNetwork/packet_forwarder/pktfwd/run.go:15

There are two options to fix this problem:

Have the user add the discovery server's certificate to the system's root CA, which is very impractical (large scale deployments, is different on every Linux distribution...)
Add a flag to specify a certificate to admit as root CA for grpc connections. This is what we want to do.

For that, we can draw inspiration from the ttn repo, that uses a flag to indicate a directory where to find the trusted certificates, to use in gRPC.

Good approach, follow ttn convention

you can self-trust the discovery certificate by copying discovery/server.cert to /usr/share/ca-certificates (make sure it ends with .crt) and then doing the following:

multitech conduits

edit /etc/ca-certificates.conf and add the filename of your cert to the end of the list
run update-ca-certificates

debian-based devices (rPi, etc)

run sudo dpkg-reconfigure ca-certificates - scroll to the end of the list and select your certificate

The discovery server certificate should now be trusted by the OS, and the X.509 warning should disappear.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM-Cloud/power-go-client
require
minor
v1.2.4 -> v1.3.0

github.com/IBM/platform-services-go-sdk
require
minor
v0.42.0 -> v0.43.0

github.com/gruntwork-io/terratest
require
patch
v0.43.11 -> v0.43.12

Release Notes

IBM-Cloud/power-go-client (github.com/IBM-Cloud/power-go-client)
v1.3.0
Compare Source
What's Changed

Add Gosec To The Build (#202) by @michaelkad in https://github.com/IBM-Cloud/power-go-client/pull/202
Generated Swagger client from service-broker commit fe82d2c @powervs-ibm (Merge PowerVS and Stratos swagger)
Update swagger client and models to service-broker v1.124.0 (#210) by @powervs-ibm in https://github.com/IBM-Cloud/power-go-client/pull/210
Add mtu and accessConfig flags to subnet create commands (#203) by @ismirlia in https://github.com/IBM-Cloud/power-go-client/pull/203

New Contributors

@ismirlia made their first contribution in https://github.com/IBM-Cloud/power-go-client/pull/203

Full Changelog: https://github.com/IBM-Cloud/power-go-client/compare/v1.2.4...v1.3.0

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.43.0
Compare Source
Features

IAM Policy Management: re-gen service after recent API changes,… (#259) (2837a98)

v0.42.1
Compare Source
Bug Fixes

IAM Identity: enhance trusted profile response with template id and assignment id (#268) (321fecf)

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.43.12
Compare Source
Modules affected

k8s

Description

Fixed panic in WaitUntilDeploymentAvailable in the k8s module

Special thanks

Special thanks to the following users for their contribution!

@antoninbas

Related links

https://github.com/gruntwork-io/terratest/pull/1330

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.10.16 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix: RegisterLegacyAminoCodec should error if Msg name is >39 chars

Description
Closes: https://github.com/osmosis-labs/osmosis/issues/1106, backport https://github.com/cosmos/cosmos-sdk/pull/11349
What is the purpose of the change
Fixes so that RegisterLegacyAminoCodec errors if Msg name is >39 chars, this has been a long bug that has not been addressed for a long time.

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] run make lint and make test
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

@mattverse can this be revived against the osmo/v0.47.5 branch?

Based on ledger updates per matt, seems like we can actually close!


Add existing project code to a repository

Addition of already existing code for future updates and consistency.

Had a little trouble with approvals as GitHub does not allow for self approval.  Left permission such that code owners are required to perform a review instead.  This should be complete but will need to comment and complete the works.

verified that all work is complete.  closing this story as done and closed.


Fix fetching max-msg-size for embedded-journal transport

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9238/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9240/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.2 please


Adds JwtFlow to support JWT authentication

This adds a new authentication type, JwtFlow. I did not create tests for this because I don't really know how give the infrastructure requirements. Also, I thought the check for sandbox might be better added to the Client, but I but it on the new class instead because I think that should be your design decision.

Codecov Report
Attention: Patch coverage is 26.08696% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 88.54%. Comparing base (cb5cdb3) to head (53c1d1f).

Files
Patch %
Lines

src/aiosalesforce/auth/jwt_flow.py
24.44%
34 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   92.13%   88.54%   -3.59%
==========================================
  Files          20       21       +1
  Lines         801      847      +46
==========================================
+ Hits          738      750      +12
- Misses         63       97      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I recommend running pre-commit to avoid lint errors

To move things forward, are you OK with merging it as is and me taking it over the finish line? I would like to experiment with it myself a bit before committing to a specific interface. You will still be getting credit for contribution.
If yes, please revert changes to pyproject.toml (this will be optional dependency).

Sure, I've checked in a version that undoes the change. If that's not what's needed, then I'm not sure how to pull out just that change from the original PR


use useRouter() outside setup()

What problem does this feature solve?
use useRouter() outside setup()
What does the proposed API look like?
import { ref } from "vue"
import { useRouter } from 'vue-router'

const num = ref(0)
const router = useRouter();
export const Test = (props, ctx) => {
  return (
    <div onClick={() => router.push('/login') }>
      test {num.value}
    </div>
  )
}

i konw now called useRouter() msut be inside of setup().
when i try use vue function component with JSX, is every flexable, but this code pattern can't use useRouter(), a little regret 😶.
hope next version can consider function component pattern 😁
thanks all, thanks vue-router team.

It can only be used where inject() can be called, this is by design. You can still directly import the router instance when not doing SSR


Fix memory leak

b2ba3f5
There was a memory leak which would cause a extra ClaimTrie node to be allocated but never deleted.
This would happen when a new node would be created in the ClaimTrie and CClaimTrieCache.addNodeToCache() was called.
The only reason the extra ClaimTrie node was created was to serve as a empty node template which would be copied by value over to the actual Node (I guess it looks like a DRY shortcut that was not implemented correctly). This is not necessary, and the fix just creates an empty node when necessary.
a2fa2c0
the was a missing clear() on a cache object in CClaimTrieCache. This should not cause any problem since we don't need to call clear() on map objects that are going to get destroyed anyways but nonetheless should be consistent.
Was able to reindex with this patch, and passes tests. Uses half the memory it used to according to my tests.

Steve has told me that he has reviewed the fix and tested it. So will be merging this.


dev: update to pandas >=2.0 for zero cost copy to polars

Automatically created PR from invoke

@HLasse Let's get that performance! 🚀🚀🚀

Woop! Seems like installation of timeseriesflattener fails though - lets have a look

Yeah; there's also quite a bit of changes to the API with pandas 2.0, so we might want to hold off on this.


[Repo/GCC] Add .vscode for quick edit/build

[Repo/GCC] Add .vscode for quick edit/build

[ ] Should work for most/any Linux using GCC/G++

(as currently, this is the compiler that provides the most C++20 features)

[x] Should use default /usr/bin/g++ path
[ ] Should allow the user to build a single file, using preprocessor define DCPP_SHELVE_STANDALONE_EDIT__
[x] Must work on WSL

Push with [11e55ce4cf8a6eb039425782cc63a5332d38655a]


Is any way to extend or generate configuration for Angular CLI?

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions
Angular CLI: 6.2.5
Node: 8.9.4
OS: darwin x64
Angular: 6.1.10
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.8.5
@angular-devkit/build-angular     0.8.5
@angular-devkit/build-optimizer   0.8.5
@angular-devkit/build-webpack     0.8.5
@angular-devkit/core              0.8.5
@angular-devkit/schematics        0.8.5
@angular/cdk                      6.4.7
@angular/cli                      6.2.5
@angular/material                 6.4.7
@ngtools/webpack                  6.2.5
@schematics/angular               0.8.5
@schematics/update                0.8.5
rxjs                              6.3.3
typescript                        2.9.2
webpack                           4.20.2

Desired functionality
Let's assume I have 5 language versions. According Angular way I have to create 5 configs for every build. It's a lot of repetition and manual work. Is any way that we can extend configuration or maybe some external tool that can generate it. Will it be possible to do this with schematics?
Yes, it's possible to workaround it somehow with individual parameters for the builder, but this eliminates usefulness angular.json and it would be might clear to provide only configuration parameters. The only way to specify it for serve is via config, so it's very problematic to develop

Duplicate of https://github.com/angular/angular-cli/issues/11233

https://github.com/angular/angular-cli/issues/10612


Bump OSM and Machine Controller

Signed-off-by: Waleed Malik<EMAIL_ADDRESS>
What type of PR is this?

/kind feature
What this PR does / why we need it:
Update OSM to v0.6.0 and update Machine Controller to v1.53.0.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

* Update operating-system-manager to v0.6.0
* Update machine-controller to v1.53.0

/approve
/lgtm


Otterscan RPC API: return whether internal calls succeeded in trace

In the trace tab, we try to decode revert messages using the expected type even if the internal call reverts. See /tx/0x578235d94f187fac181d929a1d43b7e094834d30c422b64d608871dea60d68dc/trace - the decoded return value is true but actually, if you look at the raw output data of that call, it's a revert message.
So ots_traceTransaction should include in its response whether each internal call succeeded or not. Even transactions which succeed may have an internal call which reverts.
We should show all internal reverts with the same red X we use for reverted transactions.
This change is necessary for an efficient implementation of #2500, namely to find where the revert reason actually originated if it bubbles up to the outer call. It is also necessary for analyzing such cases in the trace if the revert reason changes on its way up.

to fix your trouble check this solution click
maybe this will solve your problem.


oe-core: Update to toradex 6.0.0 and OE kirkstone

Summary
This PR updates our openembedded stack to version 6.0.0 of the Toradex yocto BSP (was 5.x). Fixed issues in the BSP can be found here.
Major Updated Dependencies and Dependencies

Yocto 4.0 Kirkstone (was 3.1 Dunfell) (LTS)

4.0 Kirkstone release notes
3.4 Honister release notes
3.3 Hardknott release notes

There are too many changes to fully list here; you can click the links and see all of them if you want to. Some major ones are noted here:
General Stuff

Kernel is following upstream better now
Rust support in the toolchain (!)
openssl 3.0.2 from the 1.1.l legacy release (finally)

JS/ODD stuff

Built in recipe for node 16 instead of backporting one
Mesa 22
I'm sure many more weird graphical things

Python stuff

Python 3.10 (!)
Poetry is built in now (!)
General build system improvements, including setuptools 59.5 and setuptools-rust-native; this should have better support for PEP-518 packages
More built-in recipes for dependencies; we're not using these yet, but some stuff like jsonschema, etc is here now.
python-can 4.1.0 (quite a lot in it - resumption of releases after a couple years of contributions but no publishing: https://github.com/hardbyte/python-can/releases )

Changes besides bumping all the submodules

Bumping from yocto 3.1 to yocto 4.0 is a lot of versions, and one of those version is 3.4 honister, in which the syntax of variable overrides in recipes (blessedly) changed. There are therefore a lot of small touches to recipes to adapt the syntax. Most were executed with the script <oe-core>/scripts/contrib/convert-overrides.py.
There are also the usual number of renamed, deprecated, and added variables that tended to get custom touches.
Some machine configurations changed, and so did the style of toradex machine configurations. We had an overridden machine.conf, which was now just completely mismatched; I looked at the new one, removed everything that was exactly the same, and then dropped the remaining configuration that had actually changed into our distro conf. Those probably want to be machine-specific overrides somehow.
for some reason we stopped being able to mkfs in the userfs backing file because it was too small; reading the mkfs manual it sure seemed like this would have always been a problem, and at the very least the userfs wouldn't have a journal, so I bumped it to a minimum size of 2MB which should be enough to always generate a journal (the journal is supposed to vary between 1MB and half the size of the filesystem, so I don't know if it'll be big enough, but whatever)

Testing and reviews
This builds but I haven't yet even boot tested it yet. I guarantee that various things will not work. We need to try and run it and see what happens.

[ ] aiohttp needs to be at least version 3.8 to work under python 3.10

[ ] pythoncan needs to be >4.0.0 for 3.10 compat

[ ] weston doesn't seem to start because it's missing /usr/lib/libweston-10/wayland-backend.so

CLosing in favor of #110


Add time-mates extension

Description
Time Mates helps you track the local time of your friends, teammates, or family from different cities, right inside Raycast. Stay connected across time zones effortlessly.

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi 👋
It looks pretty similar to this one: https://www.raycast.com/andrebreia/timezone-buddy - did you find that one?

Some countries have multiple time zones, making it impossible to set just one. That might be why the other one uses time zones?

@pernielsentikaer Understood. Thank you for your feedback.


we got a high exposure unexpected picture iin face swap demo

we got a high exposure unexpected picture
https://ibb.co/7KBc4mz
please help to review this!!
thank you!!!

with this parameter
        num_inference_steps=20,
        guidance_scale=2,
        height=height,
        width=width,
        ip_adapter_scale=0.1,

we got this pic,
https://ibb.co/hLDP4Nh
still a little weird


Add systemd-config tag

Related to #120.

This change is

@jdeanwallace - This is ready to merge in, right?


curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
$ brew upgrade pyenv
==> Downloading https://ghcr.io/v2/homebrew/portable-ruby/portable-ruby/blobs/sha256:61029cec31c68a1fae1fa90fa876adf43d0becff777da793f9b5c5577f00567a
########################                                                              29.1%
curl: (92) HTTP/2 stream 0 was not closed cleanly: PROTOCOL_ERROR (err 1)
Error: Checksum mismatch.
Expected: 61029cec31c68a1fae1fa90fa876adf43d0becff777da793f9b5c5577f00567a
Actual: 60077a905384605451fad43eb0109deec9882e5e8c7f9fdec046befa47494354
Archive: /Users/Yvette/Library/Caches/Homebrew/portable-ruby-2.6.10_1.el_capitan.bottle.tar.gz
To retry an incomplete download, remove the file above.
Error: Failed to upgrade Homebrew Portable Ruby!
What is the motivation for the feature?
I wanna upgrade pyenv and I get an error about curl which may be due to the compactivity of HTTP version. But what should I do to specify the HTTP version so I can connect to the API? Or Does brew still support upgrading pyenv?
How will the feature be relevant to at least 90% of Homebrew users?
Lots of users of MacOS and Python need to use this command.
What alternatives to the feature have been considered?
Sorry, I have no idea about this.

This is an issue with your connection to GitHub. We cannot fix it.


Eliminate error log noise around declined advertises

Towards deploy confidence, uses the new tchannel/errors.isFatal(err) predicate from https://github.com/uber/tchannel-node/pull/34.
@kriskowal @Raynos

:ok:


Mqtt2Mqtt client can't publish new topic to Mosquitto Broker

Hi Daniel,
I have a sensor that can publish data to a MQTT broker with topic "deviceId/events/rpc" and a nested JSON object payload. I need to change the topic to "json/apikey/deviceId/attrs" and the payload to a single-level JSON object.  I believe Mqtt2Mqtt can help me achieve this perfectly.
Now I setup Mqtt2Mqtt and Mosquitto on a CentOS server, but on Mosquitto:1883 I can't receive anything. My configuration:

In Mqtt2Mqtt->Broker, listening on 1884, when I use mosquito_sub, I can get the data from the sensor.
I created a Maps 'gettest' and just enabled the "Custom Topic" and "use Function", keep "Wildecard From" empty and function with "return {topic: topic, payload: payload}". I think this will forward the original topic and payload to the third-party Broker.
In Mqtt2Mqtt->Clients, set "Host URL:localhost, Port:1883, Reconnected period:3000" and "Maps Get: gettest".
After appling the configuration, I can see "client Connectted" in Mqtt2Mqtt->Broker. Also in MosquittoBroker log, I can see this Mqtt2Mqtt->Client is connected with MosquittoBroker.
But when I subscribe to the original topic on MosquittoBroker:1883, there is nothing received. but on Mqtt2Mqtt :1884, the sensor data still can be got.

Why the data can't be received on MosquittoBroker:1883? Could you help give me some guidance and comments?
In addition, next step I will create a function as below  in Maps to do the topic and payload transformation, I hope it can work as I expected :).
          //topic transform;
          var parts = topic.split('/');
          var newTopic = 'json/iothouseapikey/' + parts.reverse().pop() + '/attrs';

          //payload transform
          var newPayload = {"src":"defaultSrc", "method":"NotifyStatus", "ts":1659606613.35, "switchId":0, "apower":0};
          const objPayload = JSON.parse(payload);

          newPayload.src = objPayload.src;
          newPayload.method = objPayload.method;
          newPayload.ts = objPayload.params.ts;
          newPayload.switchId = objPayload.params['switch:0'].id;
          newPayload.apower = objPayload.params['switch:0'].apower;

          return {topic: newTopic , payload: JSON.stringify(newPayload)}

Thank you very much.

Hello again,
It works after I change "Wildecard From" from empty to "+/events/rpc". I thought every incoming data package will trigger the Mqtt2Mqtt.client publishing the new topic and payload to the third-party broker(it's Mosquitto here) when keeping "Wildecard From" as empty , it's a misunderstanding.
It's solved.
Thank you very much.


Authentication with access token

Is it possible to use this sdk with only a service instance ID and an access token? (no api key)

That's a good question. It is possible with the Java SDK, which makes me think it should be possible. I'll take a look and provide an update.

Yeah, looks like it's as easy as just providing a token instead of an apiKey during client creation.  Here's the relevant code: https://github.com/IBM/ibm-cos-sdk-js/blob/5d776bcb86f5b715cf0422107fdfc467eb0eb39e/lib/iam/token_manager.js#L76

Thanks, I wasn't able to get token working, but I was able to pass a tokenManager:
new COS.S3({
  endpoint: "https://s3.us.cloud-object-storage.appdomain.cloud",
  serviceInstanceId: "...",
  // @ts-ignore
  tokenManager: {
    getToken: () => ({
      accessToken: token,
    }),
  },
});

Neither token or tokenManager are part of the typedefs

Has your issue been resolved?

Not exactly, I was able to do a work around, but there doesn’t seem to be an official way to do this?

@bourdakos1 Your resolution would be the "official" one I would suggest. There currently is no support for supplying a pre-fetched IAM token. For cases like this, we suggest extending the token manager with the behavior you are looking for.  Also, re: typedefs, I've opened an internal ticket.
If this cover everything, please close this as resolved.

okay great, yea the typedef fix would cover everything thanks :)


Starting a search with uppercase letter lets page load infinitely

When you go to https://discordbots.co.uk/bots and start the search with an uppercase letter, then the page won't load any profiles and shows the loading animation for an infinite time.
But when you start the search with a lowercase text, it works properly.
Here's a gif for illustration:

Ah
When there are no results, that appears.
I can replace it with "No results", or just can delete the loading icon.

It also happens when there should be some results (like S for example)

Ah
When there are no results, that appears.
I can replace it with "No results", or just can delete the loading icon.

I mean it also happens, when it should have results.
In the gif I searched for Git and then for git but only the second one showed GitTags which clearly has Git in the name.

Here's the direct link to the gif, since it looks like that GitHub fucks it up.
https://thumbs.gfycat.com/UnderstatedGrotesqueIndianrockpython-size_restricted.gif

I think I fixed it
Just need a toLowerCase()


fix: allow currentRow for onClick in menuButton item in Table widget

Fixes #26052

Summary by CodeRabbit

New Features

Introduced a new property, customJSControl, for enhanced configuration in the Table Widget, allowing for dynamic table data handling.
Added a new test case to ensure the menu button's onClick property correctly accesses the currentRow context, improving the robustness of the component.

Bug Fixes

Enhanced testing coverage for the table menu button component to ensure correct behavior of dynamic properties.

@SaiCharanChetpelly31 Can you please explain me for the cypress test case requirement here? Can we test with Unit test ?

@SaiCharanChetpelly31 Can you please explain me for the cypress test case requirement here? Can we test with Unit test ?

@sagar-qa007 For other fields like visible and disabled, they are checking if currentRow is accessible in the Cypress tests itself. I didn't find any unit tests related to this in the Table widget code, which is why I have only written Cypress tests.
You can check the already existing cypress tests for visible and disable fields here
https://github.com/appsmithorg/appsmith/blob/486662a2ed37a9e616d478c5ce296426d522c9c8/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/menubutton_spec.js#L100C1-L165C8

@sagar-qa007 @ApekshaBhosale I hope you're well. I’m curious and excited to hear your thoughts on my pull request raised a while ago. Looking forward to your review!
Thank you.
cc: @ramsaptami

@sagar-qa007 @ApekshaBhosale I hope you're well. I’m curious and excited to hear your thoughts on my pull request raised a while ago. Looking forward to your review!
Thank you.
cc: @ramsaptami

@ApekshaBhosale Could you please review this PR?

@SaiCharanChetpelly31 Please fix merge conflicts.

@SaiCharanChetpelly31 Please fix merge conflicts.

sure, working on it

@rahulbarwal I resolved merge conflicts. can you please check?
Thanks in advance.

@jsartisan could you please review this PR?

@rahulbarwal can you check this PR?


Update stable version in repo from 0.1.0 to 0.1.1

Think about update stable version to 0.1.1
Version: stable=0.1.0 (82 days old) => latest=0.1.1 (15 days old)
Installs: stable=879 (61.77%), latest=84 (5.9%), total=1423
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 0.1.1 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 0.1.1 but the current stable version is already 0.1.1.
So this issue should be closed.
@mcm1957 for evidence


Fix Task Copy certificates]

Showing Warning: [WARNING]: Unable to find '/var/snap/microk8s/current/certs'

 MicroK8s


Source Code for Cycle Detection in C++

Related Issue
Closes: #886
Describe the changes you've made
Adding Source Code for Cycle Detection in C++
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Language used for coding
C++
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have documented the code.
[x] New and existing unit tests pass locally with my changes.

Please review the code ;-)


bronchiolitis

Add new term:
bronchiolitis (a child of lung inflammation MP:0001861)
DEF: local accumulation of fluid, plasma proteins, and leukocytes in the noncartilaginous conducting airways of the lungs found terminal to the bronchi
SYN: bronchiolar inflammation
Annotations in J:286302

Added new term:
bronchiolitis MP:0031054


Priority issue in version 6.8.8 and 6.9.6

Hi all,
I am using Testng and nearly everything is working really well. There is one serious issue with priority. No matter what I do priority is ignored.
When I say
@Test( groups ="testA", priority=123 )
public void testMethodA() {
// Do nothing
}
I see this in the output:
my.package.CalendarPage
@BeforeMethod AbstractPageTest.beforeMethod()[pri:0, instance:my.package.CalendarPage@183b7230]
@Test CalendarPage.testCalendarItems()[pri:0, instance:my.package.CalendarPage@183b7230]
priority isn't being read.
So I tried a IMethodInterceptor and a IAnnotationTransformer and in each listener I execute
annotation.setPriority ( 999 );
and still it says
my.package.CalendarPage
@BeforeMethod AbstractPageTest.beforeMethod()[pri:0, instance:my.package.CalendarPage@183b7230]
@Test CalendarPage.testCalendarItems()[pri:0, instance:my.package.CalendarPage@183b7230]
My xml contains this:

<listeners>
        <listener class-name="my.package.TestAnnotationTransformerListener" />
</listeners>

<test name="WebsiteTests" verbose="3">
	<parameter name="browser" value="firefox" />

	<groups>
		<run>
			<include name="testA" />
		</run>
	</groups>

	<packages>
		<package name="my.package.*" />
	</packages>
</test>

Either there is a bug in testng with priorities or there is a configuration conflict or something.
Yours sincerly,
Martijn Hiemstra

In fact, it's just a visual issue because priority value is set after the creation of the displayed line.

I believe this issue should be opened. The issue isn't that the priority is displayed as 0. The issue is that the priority doesn't work when you use the packages tag.
When I indicate

then the priority is ignored and everything is executed in random order.
However if I indicate

 // Priority 1
 // Priority 3
 // Priority 2

then first ClassA tests are executed then ClassC and then ClassB.
It seams if you set the packages tag priority is ignored. And that's where priority is the most important otherwise I have to put 50 classes in my xml and everytime priority changes or I add a class I need to update the xml which isn't what I want.


broken.yaml: removed llvm-tf

Description of changes
removed llvm-tf from broken.yaml
Things done
I have successfully build the package on nixpkgs-unstable.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Done in f55d58cfa1c8


amp.csv.gz has datasetId "amp" but expected "https://opentraits.org/datasets/amp"

hey @bmaitner
for some reason the amp.csv.gz has "amp" as datasetId:
$ zcat amp.csv.gz | head -n2
"scientificNameVerbatim","family","phylum","traitNameVerbatim","numberOfRecords","datasetId","curator","accessDate"
"Abatus_cordatus","Schizasteridae","Echinodermata","[E_G], spec cost for structure",1,"amp","https://opentraits.org/members/brian-s-maitner",2022-08-14

any chance you can reformat to make "amp" turn into "https://opentraits.org/datasets/amp" just like the others?

Apologies for this issue, I've corrected the R script and the output and pushed both.

@bmaitner No worries. Thanks for fixing it!
$ zcat amp.csv.gz | head -n2
"scientificNameVerbatim","family","phylum","traitNameVerbatim","numberOfRecords","datasetId","curator","accessDate"
"Abatus_cordatus","Schizasteridae","Echinodermata","[E_G], spec cost for structure",1,"https://opentraits.org/datasets/amp","https://opentraits.org/members/brian-s-maitner",2022-08-18


Ghidra can't open large files?

I tried to disassemble a 100M+ mips file with ghidra, but it has been executed for 4 days and its analysis progress bar is still 0%. Does ghidra limit the size of the disassembled file?

Shown under the "Decompiler" progress bar is: "NoReturn - find functions that cannot be returned"
I am using ghidra 19.04, Java11, Windows10

4 days...you are patient..  There is no size limit. I just did a 1Gig binary.  It had the same issues, although it completed in 17 hours on a slow machine.
The NoReturn algorithm can get stuck as it is checking and fixing a large graph.  We're looking at an alternative.  You can turn off the analyzer, then let analysis complete without it.  Then run the FixupNoReturn script after the fact, and choose the routines to make non-returning, or note the locations.  That may take a long time too.  If there are key non-returning functions, it can help to find the most called ones then disassemble, and create a function there marked non-returning before running full analysis.
If the MIPS has a stack_chk_fail call right before each function that can cause slow down in main analysis.  One function then flows into another until the stack_chk_fail is turned into a non-returning function.  This would be a candidate to mark non-returning before full analysis.

Ok, thank you for your reply.

have a similare issue with CreateFunctionCmd.
i have 1955 no-return functions 'nullsub in ida' mostly. i have file with offsets.
however i don't know either how to manually mark them nor witch api i could use.


Allow to pass in option --open to automatically open the resulting

.svg file in the default program. Its similar operation to the cargo doc --open

Hello,
Sorry, it got a little messy with the rebasing. Hope all is fine now.

Great, thanks!


Update private-dns-getstarted-portal.md

This pull request includes several changes to the articles/dns/private-dns-getstarted-portal.md file to correct typos and improve clarity. The most important changes include fixing grammatical errors and correcting a misspelled word.
Typo mentioned in Microsoft Q&A.
Improvements to grammar and clarity:

Corrected the grammatical error by changing "a virtual machines is used" to "a virtual machine is used" and clarified the sentence structure.
Fixed the misspelled word "autoregistgration" to "auto registration".
Improved the clarity of the sentence by changing "add records to the private DNS zone manually" to "manually add records to the private DNS zone".

@greg-lindsay
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Support Kitty Protocol

Currently, images are supported using Uberzug. It would be great if the images could also be viewed using the Kitty Protocol
Some References:
https://sw.kovidgoyal.net/kitty/graphics-protocol.html
This is the PR that added kitty image previews for Ranger: https://github.com/ranger/ranger/pull/1077

https://github.com/neovim/neovim/issues/12991
telescope use the :terminal inside vim and that terminal don't support kitty image protocol. I already  check and run ranger inside :terminal and  image preview is not work with kitty method so we can't do anything here.
Uberzug is render on top of terminal and it is not belong to the terminal.

FYI: I tried today and ranger running inside nvim terminal can show images correctly.

kitty have REMOTE, that allow you to get access to kitty from other terminals
https://sw.kovidgoyal.net/kitty/remote-control/

might be a way to do this: https://github.com/edluffy/hologram.nvim

The author of Überzug removed 7 days ago. The project now says they were harassed by people seeking free support in the issue tracker.

As Überzug is no longer a option, is there any update to supporting Kitty? Hologram, as mentioned by jigfox, has an API for displaying images. I have no clue about nvim and am a bloody beginner, but Hologram seems to be a promising alternative to Überzug for/with Kitty.

hologram is superseded these days by: https://github.com/3rd/image.nvim

hologram is superseded these days by: https://github.com/3rd/image.nvim

Thanks for the pointer. I currently use this solution: https://github.com/3rd/image.nvim/issues/183#issuecomment-2284979815 to integrate telescope with kitty. A dedicated telescope plugin would be great though


[Internal QA]: Refactor ChooseTransferAccountPage to use Selection List

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/48974
PROPOSAL: https://expensify.slack.com/archives/C036QM0SLJK/p1726572419734889?thread_ts=1726504612.935849&cid=C036QM0SLJK
Tests

Precondition:

Comment this line of code to shouldShow={false}.
Have 2 bank accounts set up on wallet page

Go to settings/wallet/choose-transfer-account

Verify that we have  everything works fine and we now have the SelectionList instead of the Radio button

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

N/A This is Internal QA

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/672e8021-4335-4bfa-a7fb-d5acc1037df9

Android: mWeb Chrome
https://github.com/user-attachments/assets/4f4d7c9d-5d82-4318-95bf-4a6c4bbb8194

iOS: Native
https://github.com/user-attachments/assets/cbd271d6-2e39-49a9-a88c-554be0855421

iOS: mWeb Safari
https://github.com/user-attachments/assets/14e3cb66-af22-4ec7-8b33-f3db21bcce25

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ce759762-323f-4d6e-bd98-a01e23042712

MacOS: Desktop
https://github.com/user-attachments/assets/40b06be6-5a87-45c9-8090-57327e1811b3

Running a build so we can test this one internally

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@allgandalf Warning on IOS and Android
https://github.com/user-attachments/assets/b3d3c28e-c401-486e-8768-f1d449dfdeba

@DylanDylann, we can ignore that warning, we get the same in settlement account for expensify cards

Hmm, @mountiny Did we accept this warning or should we fix this warning?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.38-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/grgia in version: 9.0.38-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


is remove_stack_memory still required?

https://github.com/fireeye/flare-floss/blob/50ab345b12181eb31a6608296661ae325118a78f/floss/utils.py#L26

it appears so and I don't want to investigate this deeply right now


Component status

@ajavadia and @nonhermitian and @diego-plan9 can you look at this and see if the table is correct.
@chriseclectic can you add a table for the aer provider.

@jaygambetta when you call for additional work from others on pull requests you open, would you like the PR to be merged as a minimum viable product and for me to spin up issues, or keep the PR open until the others have added their contributions to it?

I am happy to have the minimum viable product and for you to spin up issues. Smaller pr's are always better (fewer conflicts) easier to review.

I am also happy for you to edit directy. The goal of this is to have something somewhere which says the status of things as people always ask what is stable in qiskit and what is not.

The table looks reasonable to me :+1:

Table looks good.
I think we can have the compiler interface stable in 0.9 (along with transpiler API).

I think this is good.  I thought the visualizations were stable as of last release, but 0.8 is fine as well.

ok cool. I'm good to merge this and make aer a follow up. As we need to also make a follow up for aqua (@pistoia )
@derivation when you are good with the structure and such just approve and merge

@nonhermitian it is more where it should be located. I think it should be in visualizations not tools/visualizations


Mockery::spy(function) should be callable

https://phpstan.org/r/4d0416f7-0b46-471e-b961-a685a5fab277
Current versions report an error
Parameter #1 $callback of static method Closure::fromCallable() expects callable(): mixed, Mockery\MockInterface given.

Can be solved with a dynamic return type extension: https://phpstan.org/developing-extensions/dynamic-return-type-extensions
Feel free to contribute it :)


Pipeline Generation for alternative pipelines

The pipeline generator needs to be updated to support generation of pipelines for alternative files, for example ci.data.yml and ci.mgmt.yml. We'll basically need to have some kind of mapping from data/mgmt to convention so that if we need to mutate the convention used based on the alternative pipeline we can.

Fixed in #389


iOS integration tests

Think about temporary solution for iOS testing as long as the test target (klib) is not able to execute ktor on main thread: you are either stuck in mutation exception due to frozen thread or endless blocking.

Meanwhile it's possible. The URLSession SSL trust verification doesn't work, though.

I'm not sure if this needs to get tested under iOS. The integration tests are only there to test if the requests succeed, if this works in Android it should also work in iOS. One case would be to catch mutation exceptions (happened twice), this can be avoided with manually building before push though. What do you think @benjohnde?

If this already happened twice, some automated tests are definitely in order, if possible :)


Can't we update an existing service principal based AKS cluster to managed identities?

I read this sentence.

You can now update an AKS cluster with managed identities by using the following CLI commands.
First, update the System Assigned Identity:

It conflicts this limitation.

AKS clusters with managed identities can be enabled only during creation of the cluster.

I cannot find out --enable-managed-identity options in az aks update command.
https://docs.microsoft.com/en-us/cli/azure/aks?view=azure-cli-latest#az_aks_update

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a9c74a8-9f1a-3d3d-3aed-f8ec45f92e05
Version Independent ID: 01e98043-dc80-490e-a761-8d558ff4e6df
Content: Use managed identities in Azure Kubernetes Service - Azure Kubernetes Service
Content Source: articles/aks/use-managed-identity.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: thomasge

@kheiakiyama -
Thanks for brining this to our attention. We will investigate it further and update you shortly.

@kheiakiyama Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@mlearned Can you please check and add your comments on this doc update request as applicable

@psmanhas @mlearned Any update do you have?

Thank you @kheiakiyama for the feedback!
The article and CLI reference have been updated to reflect your feedback.
#please-close


Reshape inputs size should be compatible

Hi , I have facing one problem , I'm running the "Compile Tensorflow Models" tutorial demo code, it's okay with the given model which is InceptionV1 from "https://github.com/dmlc/web-data/tree/master/tensorflow/models/InceptionV1" , But when I test my model which is InceptionV4, it  brings Error as follow:
nnvm._base.NNVMError: Error in operator prefix/InceptionV4/Logits/PreLogitsFlatten/flatten/Reshape: [09:00:52] /tvm/nnvm/src/top/tensor/transform.cc:649: Check failed: in_attrs->at(0).Size() == in_attrs->at(1).Size() (1536 vs. 2) Reshape inputs size should be compatible
The inputs of reshape op with shapes (1,1,1,1536) and 2
output shape is (?,?)
Could you please tell why did the error happened?

Thanks for bringing up this problem, please open a thread at the community disucss forum https://discuss.tvm.ai

@wincle https://github.com/dmlc/tvm/pull/1923 should fix this issue.

@wincle you may follow the below discussion
https://discuss.tvm.ai/t/tvm-tf-converter-bug-with-inception-v4-network/894/2

@tqchen Thx! I have post my question up there, it seems need time to show up for me.

Hi, @srkreddy1238 , Thanks for your reply , I have checked the links which you posted, your work is indeed valuable, but it still confused me because I didn't find the same problems as I met which happened in nnvm.frontend.from_tensorflow at the Reshape Op.
Could you please explain clearly why did this error happened? Thx!


Want to open the Terminal in current folder from right click menu.

Description of the new feature/enhancement
There should be an option for Open Terminal Here in the right click menu a.k.a Context Menu. Same as when I right click in a folder, and if Visual Studio is installed it shows option Open in Visual Studio, also if we install the Git Bash also it allows us to open that specific folder in the Bash Terminal right from the Context Menu or right click menu.

This seems a duplicate of https://github.com/microsoft/terminal/issues/6414, which was already fixed. The fix is in v1.6.10272.0 but the binaries have not been released yet.

This seems a duplicate of https://github.com/microsoft/terminal/issues/6414, which was already fixed. The fix is in v1.6.10272.0 but the binaries have not been released yet.

Sure is, thanks!
/dup #6414
/dup #1060

Sure is, thanks!
/dup #6414
/dup #1060

I found this guide for that:
https://dev.to/priyaranjankumar/how-to-add-open-windows-terminal-in-context-menu-36ni
I hope that version v1.6.10272.0 will solve this alot nicer with a supported settings and not one of all this web regex hacks. 😀
(or atleast a supported regex hack in the program😉 )

I found this guide for that:
https://dev.to/priyaranjankumar/how-to-add-open-windows-terminal-in-context-menu-36ni
I hope that version v1.6.10272.0 will solve this alot nicer with a supported settings and not one of all this web regex hacks. 😀
(or atleast a supported regex hack in the program😉 )

@pownas Thanks for the help, really it means a lot to me as it was something I really want to be in the menu!

@pownas Thanks for the help, really it means a lot to me as it was something I really want to be in the menu!


Looking for maintainers

As I'm too busy with growing our startup atm, and soon becoming a father, I must concede that I cannot provide the all attention this repo deserves, right now at least.
Thus I'm announcing that this repository is looking for more maintainers to step in.
Not sure how to market this properly, if anyone is willing to champion this, or has some suggestions, please comment here. All help is much appreciated and very welcome!

hey @msand id love to help out. I help maintain voice & cookies. This is an important repo to the RN community so always happy to ramp up efforts!

Hey @msand I would like to help maintain this repo. I have very little experience in maintaining a lib, but I want to get into OSS and contribute to the tools which help me day to day.

@msand I'd like to help out as well!

I can help too!

I can help too

@msand I'd like to help

@msand I'd love to help

I can help

Hi @msand
Following this it would be nice if you could open a collective for this repo. Only the owner of the repo can do it so it would be nice of you to open the collective.
The idea -if you agree- would be for you to handover this project progressively to the collective, so members of this community can carry the project.
We need to organize ourself, raise funds and define objectives.

Hi, I'd also be more than willing to help with this project.

Hi, i'd love to squash some bugs in my free time. Hit me up for anything js/IOS related.

Hi,
We're looking to get https://github.com/react-native-svg/react-native-svg/pull/1431 merged over at our org and happy to get maintainership to do it, and help where we can. Also curious what @brentvatne has to say, given Expo recommend this project and probably want web support over here.

Hello @msand - I am happy to contribute to the repo. Let me if I can start by looking at the issues.

Just to add here on the back of a tweet with @likern  https://twitter.com/HenryMoulton/status/1388273572523692034
If there's anyone who's seriously up for contributing to this library I'm looking to get some Company Sponsors that use React Native SVG!

I would like to contribute

I can help with this repo as well.

@magicismight does it possible to get access to the repo? I want to help with the review of some small PRs/issues.

I can help as well. Simply because we are using this in our production application and would like this to continue.

I would like to contribute. And i asked my company for help

I'm currently available and open to maintain this for free

Something new here?

check again please

Hello @msand if you are still taking maintainers, I would be glad to offer my services as well. I'm not so experienced with this but what I may lack in years of experience, I can make up for in sheer willingness to assist.

I would like to help, @msand

Happy to help if it makes progress on outstanding issues.

glad to help

got this when running npx react-native run-android. I have already tried gradlew clean.
\node_modules\react-native-svg\android\src\main\java\com\horcrux\svg\RenderableView.java:30: error: cannot find symbol
import com.facebook.react.bridge.ColorPropConverter;
^
symbol:   class ColorPropConverter
location: package com.facebook.react.bridge

When I open it with an Android phone, the app will flash back. Is there a solution？

hi, just found this repo and would be happy to help contribute & learn from the open source community. I have some experience using D3 to manage SVG charts and UIs -- I think this would be a great project to apply that bg

Hey, new maintainer of the repo here 👋  I think we can close this issue since the maintenance is restored. Of course we are open to contributions to the repo and will gladly collaborate on PRs etc. 🚀  Currently I am focusing on Fabric implementation so I may be a bit slower to respond. Feel free to comment here if something is wrong and we can always reopen the issue.

I would be happy to help! Have someone reach out to me and point me in a direction to code!

Hey @SebTheRed ! Thanks for your will to contribute :tada: As for the biggest challenges, there is a PR with filter support: https://github.com/software-mansion/react-native-svg/pull/896 which would need to be refreshed and brought to an end. And if you'd like some easier tasks, there are more than 300 issues right now so there is plenty problems and feature requests to choose from 🚀


Add publish-and-tag job to CI

As part of integrating the cli into the bosh, we need to build the binaries and publish them via the CI.
Note: I am not sure the part where it is building a custom docker image is needed.
@jpalermo thanks, I appreciate your help on creating the buckets and setting up the required credentials for the pipeline to run.

Looks like it's cutting releases now.
I vendored the dependencies and added our standard weekly bump-deps job that should keep them all up to date. The dependency bump is currently red though because it looks like maybe updating one of the dependencies breaks a usage of it.
I'll take a look at that soon.
VERY strangely, the build script refused to run initially on Concourse. Turned out to be because it was UTF-16 encoded. Granted I don't create many UTF-16 files, but it IS a valid encoded, for some reason it causes Concourse, or rather runc, to totally fail.

VERY strangely, the build script refused to run initially on Concourse. Turned out to be because it was UTF-16 encoded. Granted I don't create many UTF-16 files, but it IS a valid encoded, for some reason it causes Concourse, or rather runc, to totally fail.

@jpalermo I was scratching my head why git ls-files reports build.sh as binary. That explains it now. I confess that I edited some of the files on windows.


Increment performance of the BuildExpression() function

At this moment, the buildExpression() function is very large (potential code smell/bloat) and also it does not allocates the strings.Builder buffer capacity of the internal slice.
This affects testing (code smell) and also affects performance (unbuffered string.Builder).
How to
Separate in different small functions each case for LogicalOperators.
Calculate an approximate capacity for the strings.Builder internal buffer.

Done through this commit.


add storage

What is the purpose of the change
update deploy
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #963 (b942f18) into develop (83e293b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #963   +/-   ##
==========================================
  Coverage      21.33%   21.33%
  Complexity       436      436
==========================================
  Files            149      149
  Lines           4799     4799
  Branches         726      726
==========================================
  Hits            1024     1024
  Misses          3690     3690
  Partials          85       85

Flag
Coverage Δ

unit
21.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e293b...b942f18. Read the comment docs.


Unicode characters aren’t displayed in title

My PS1 shows directories in terminal title and some have accents and others non-ASCII characters but dvtm doesn’t display it.
For example:
Without dvtm: ~/LycéeXP/math
With dvtm: ~/LyceXP/math

Thanks for the report, after a quick glance at the code it seems to be severely broken with regard to Unicode handling. This is another reason to consider switching to another terminal emulation component.

Any chance the UTF-8 issue be resolved? It pops up in other places as well.


Service to Task Config Mapper

GearPump Service to Task Config Mapper
Goals
GearPump Tasks often require input parameters described by a UserConfig object that is provided to the Processor[Task]. The Processor API typically takes:

a parallelism parameter

a description
a UserConfig object

The UserConfig object is passed to the specific Task when it is constructed on the server.
Any GearPump application that submits a DAG may require a way to convert a JSON string that describes services to a specific UserConfig that is Task specific. For example, particular service bindings available on a particular target platform that describes HBASE or HDFS related information may need to be converted to a UserConfig format  appropriate for a specific type of Task.

There should be a way to convert an arbitrary JSON object that holds Task specific information to a UserConfig object appropriate to that Task.

The JSON object that holds Task specific information may not be known or may describe configuration information for a new type of Task that is being defined in the GearPump application.
These JSON objects will have a type and optionally a name that will uniquely that JSON type.
The Service to Task Config Mapper is a utility that takes a type or (type, name) pair and a String holding the JSON data and returns a UserConfig object that can be passed to the Processor[Task].
There should be a way to provide or register individual type mappers that knows how to deserialize the JSON data into a UserConfig object.
Within the GearPump UI that submits an application there should also be a way to convert JSON data  to a UserConfig object for a given Task that can be added to the GearPump manifest that describes the services the application requires. See #1455.
Within the GearPump UI we will need a javascript or scala.js object that implements the conversion described in 6.

Approve (quorum 2+)

[ ] @clockfly
[ ] @kkasravi
[ ] @TomaszT
[ ] @karol-brejna-i

This has been moved to gearpump_tap_integration


Can not install any distribution by wsl2

I update to BUILD 18970 a few days before. I choose to keep my programs and data.
Then I follow the offcial guide to turn on WSL2, when installing any distribution(ubuntu 18.04,16.04 and centos), when start Ubuntu(Centos) a few mins later, it shows this problem.
I cannot get any infomation about this problem. Please help me. THX

Interesting, is the Virtual Machine Platform feature available?  Are there any interesting events in any of the Hyper-V eventvwr log?


Restarting a node quickly and connecting will not emit onConnectevents in registrar

Version:
1.1.0

Subsystem:
Registrar, connection manager?

Severity:
High
Description:
I am trying to track down issues I have with connections and realised that I get unexpected behaviours when restarting nodes
Steps to reproduce the error:
Create a protocol handler with
this.components.registrar.register(multicodec, {
	onConnect: this.onPeerConnected.bind(this),
	onDisconnect: this.onPeerDisconnected.bind(this),
	notifyOnTransient: false
})

Start 2 libp2p nodes with tcp transport
Connect the nodes
Now stop one one, and then start it again immediately.
Connect nodes agains immediately

Expected behaviour onPeerConnected is emitted 2 times for both nodes.
Actual behaviour. onPeerConnected is never emitted on the last connect for any node. And the onPeerDisconnected is emitted late, after the new connection has been  established again (looks like that the connection take a while to close (?))
Putting a delay between stopping and starting the node will solve this issue, but in a real world usecase where I refresh a tab in browser I suspect that this issue is causing the issues I am having.

This is what I get when I am starting up the node after closing
2024-01-25T23:54:38.968Z libp2p:transports creating listener for @libp2p/tcp on /ip4/<IP_ADDRESS>/tcp/0
2024-01-25T23:54:38.968Z libp2p:tcp:listener Listening on { address: '<IP_ADDRESS>', family: 4, port: 60420 }
2024-01-25T23:54:38.969Z libp2p:connection-manager dial 12D3KooWPQUiiod5RRfnRf2reXAP1mw5vM86m32atbXZuN3T49Yd
2024-01-25T23:54:38.969Z libp2p:connection-manager had an existing non-transient connection to 12D3KooWPQUiiod5RRfnRf2reXAP1mw5vM86m32atbXZuN3T49Yd
2024-01-25T23:54:38.969Z libp2p:tcp:socket <IP_ADDRESS>:60410 socket end
2024-01-25T23:54:38.969Z libp2p:mplex initiator stream with id 1 and protocol /test/0.0.0 ended
2024-01-25T23:54:38.969Z libp2p:mplex receiver stream with id 1 and protocol /test/0.0.0 ended
2024-01-25T23:54:38.969Z libp2p:tcp:socket <IP_ADDRESS>:60410 socket close
2024-01-25T23:54:38.969Z libp2p:connection:outbound:aynwkw1706226876843 closing connection to /ip4/<IP_ADDRESS>/tcp/60410/p2p/12D3KooWPQUiiod5RRfnRf2reXAP1mw5vM86m32atbXZuN3T49Yd
2024-01-25T23:54:38.970Z libp2p:tcp:socket <IP_ADDRESS>:60410 socket was already destroyed when trying to close
It seems libp2p:connection-manager had an existing non-transient connection to 12D3KooWPQUiiod5RRfnRf2reXAP1mw5vM86m32atbXZuN3T49Yd
is skipping doing some things because of this. I assume this creates consequences down the line (?)
I dont get it by putting a delay before start and connect. Then it will look like this
2024-01-26T00:01:02.345Z libp2p:transports creating listener for @libp2p/tcp on /ip4/<IP_ADDRESS>/tcp/0
2024-01-26T00:01:02.345Z libp2p:tcp:listener Listening on { address: '<IP_ADDRESS>', family: 4, port: 61966 }
2024-01-26T00:01:05.346Z libp2p:connection-manager dial 12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF
2024-01-26T00:01:05.347Z libp2p:connection-manager:dial-queue creating dial target for 12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF [
'/ip4/<IP_ADDRESS>/tcp/61966/p2p/12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF'
]
2024-01-26T00:01:05.348Z libp2p:tcp dialing /ip4/<IP_ADDRESS>/tcp/61966/p2p/12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF
2024-01-26T00:01:05.348Z libp2p:tcp connection opened /ip4/<IP_ADDRESS>/tcp/61966/p2p/12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF
2024-01-26T00:01:05.348Z libp2p:tcp new outbound connection /ip4/<IP_ADDRESS>/tcp/61966/p2p/12D3KooWLNL49UuYwaSRh1fbE7Qj2CJwYj9KftHX2iBBR2m6eZJF
2024-01-26T00:01:05.348Z libp2p:tcp:socket starting the outbound connection upgrade
2024-01-26T00:01:05.348Z libp2p:tcp:socket selecting outbound crypto protocol [ '/noise' ]
2024-01-26T00:01:05.348Z libp2p:tcp:listener new inbound connection /ip4/<IP_ADDRESS>/tcp/61980
2024-01-26T00:01:05.348Z libp2p:tcp:socket starting the inbound connection upgrade

It seems to matter which node is dialling whom.. If the node that is not closing is dialing the the other node. Then it will fail, but the other way around it works. I assume that the node that is not stopping have a connection lingering that ought to close, which makes dialling again not possible. Given this, this might not be a problematic issue after all because it is usually the node that is starting that is starting to dial


Security 29

This is my attempt to fix dependabot's security alert #29.
I changed every instance of ip 2.0.1 to ip.2.0.2 (and got the sha512 by downloading the package), but it throws error on install:
> [homepage 5/5] RUN cd /app/reloader && npm install:
6.223 npm error code ETARGET
6.223 npm error notarget No matching version found for<EMAIL_ADDRESS>6.223 npm error notarget In most cases you or one of your dependencies are requesting
6.223 npm error notarget a package version that doesn't exist.

Weird 2.0.1 is the latest version
https://www.npmjs.com/package/ip

The CVE lists a different set of affected versions than the security alert:
https://github.com/advisories/GHSA-78xj-cgh5-2h22
<=2.0.0 vs <=2.0.1


Application name looks too much like the last name of a certain US president

Hi @Alex-D ,
Someone brought to my attention that the name of the application is very close to Donald's last name. Would you consider using a simpler name that won't scare our users?
Thanks a lot!

Insteed of changing my plugin name, can we change the US president last name?
My SEO is so good, I can't rename now, sorry :/

Thanks @Alex-D . I do like your suggestion :satisfied:


support decoding booleans in a string context

Addresses cases such as the following:
v := struct{
Selector map[string]string json:"selector"
}{}
dataToDecode := {     "selector": {         "field": false     } }
dataToDecodeAsYAML := selector:   field: no
where the output struct expects a map of string keys and values, and the input contains non-quoted boolean values.
Particularly in cases where the input is yaml and is later converted into json before being decoded, this patch prevents a potentially confusing error where a user might use a yaml-specific boolean keyword (such as yes or no), and then is presented with a decoder error similar to [pos 36]: json: expect char '"' but got char 'f'
Related downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1458204#c1
cc @fabianofranz

Reproducer for the issue this patch aims to solve:
package main

import (
	"fmt"

	jsoniter "github.com/json-iterator/go"
)

var jsonData = `{
    "selector":  {
        "key1": true
    }
}`

type SampleSchema struct {
	Selector map[string]string `json:"selector"`
}

func main() {
	obj := &SampleSchema{
		Selector: make(map[string]string),
	}

	err := jsoniter.ConfigFastest.Unmarshal([]byte(jsonData), obj)
	if err != nil {
		// unmarshalling into the SampleSchema object will cause the error:
		// error: main.SampleSchema: Selector: ReadString: expects " or n, parsing 38 ... "key1": f... at {
		//     "selector":  {
		//         "key1": false
		//      }
		// }
		fmt.Printf("error: %v\n", err)
		return
	}

        // with this patch, this will print:
        // success: map[key1:true]
	fmt.Printf("success: %v\n", obj.Selector)
}

if use standard library, the output is
json: cannot unmarshal bool into Go struct field SampleSchema.selector of type string

we should keep the behavior same as the standard library


Fix fastboot support in one-way-input-mask#didReceiveAttrs

This is just a minor change to ensure that fastboot apps can render pages with one-way-input-masks on them.
Here is the error I was getting when trying to use something very simple like {{one-way-input-mask val mask='a-9-a-9'}}
There was an error running your app in fastboot. More info about the error:
  Error: Accessing `this.element` is not allowed in non-interactive environments (such as FastBoot).

I think the right approach might be to schedule the _changeMask hook to run afterRender or something like that. I'm only submitting what I've got working for now in case anyone else is running into this issue.
It might be good to make sure all the things that touch this.element are protected behind something like this so that this issue wouldn't reappear if any of these private methods end up being called in the fastboot lifecycle hooks. What do you think?
P.S. Thanks for writing this great wrapper library and documenting it so well in the code :)

@scudco Thanks for bringing this up. We should definitely make sure this works with fastboot. I'm going to look into writing some tests to make sure it does

0.6.8 has the fix


feat: :sparkles: add ability to buy tokens on demo

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


tar: prefix hard link destination with extraction target

If the extraction is not running in a chroot, the file to hard link
against must be prefaced by the target for the extraction, otherwise the
file that's being linked to will not exist and the link will fail.
Fixes appc/acbuild#139.
Replaces https://github.com/coreos/rkt/pull/1827.

lgtm