"The Tab is inactive" message appears when the browser is minimized, the selected tab is changed, or VS Code is full screen

IDK whether I am using this tool correctly or not. I am seeing the below

This is a limitation of the screencasting API that we are using. Right now you need to have the Edge tab that you are connected to, selected as the current tab in the browser. You also need to have the browser itself not minimized.
I'll update the title to reflect this, but keep it open in case we can find a better solution at some point.

@jalissia Thanks for the explanation. This happens for me when I use VSCode in Zen Mode. It works like a charm in Normal mode.

Interesting, I don't think I've ever tried Zen Mode. Are you on Windows or Mac?
If I enter zen mode after attaching the elements tool (without moving the browser/tab at all) it seems to stay active for me (on Windows 10).
Certainly something for us to look into though as I know the API has limitations.

I am on Mac.

I can repro @thevarunraja findings. Zen mode (simplified explanation) puts vscode in fullscreen mode. In the latest mac osx versions full screen creates a "new desktop" which remove focus from the other window(s). To test this I moved vs code to "virtual dekstop 1"  (without zen mode) and Edge browser to a "virtual desktop 2" and could observe the same behavior. In short:
Repro steps (1):

Open VScode with vscode-edge-devtools extension (on mac)
Open a new window and attach to it using vscode-edge-devtools extension
Tun Zen mode on (Ctrl-K + Z)

Repro Steps (2):

Open VScode with vscode-edge-devtools extension (on mac)
Open a new window and attach to it using vscode-edge-devtools extension
Move vscode to a different virtual desktop

Expected:
Screencast should work
Observed:
tab is inactive appears on screen cast
Note: On Windows 10 Repro steps 2 work as expected.

MAC user here.
"The Tab is inactive" message appears when VSCode completely covers the Edge window or when they are on different screens.
The message disappear when :

VSCode and Edge are not in full screen mode
VSCode and Edge are on the same virtual screen
VSCode's window is smaller than the Edge's one

I encountered this while using a Windows computer with the Edge window minified. Maximizing it made it work normally.

Verified on Mac. It is enough to have the browser window one pixel bigger than the vs code one, but this is annoying. This could be a battery saving thing on Mac.

having the same issue, found out that the only way to change the screen is to use alt+tab or other method rather than minimize.

This could be fixed by using the headless version, let's verify that.

Verified that this issue does not repro in the headless version.

This is fixed.

This still happens for me on Windows. Latest Windows Update, latest VS Code, latest Edge.
Strangely, it happens even if I just ALT+Tab away from the window into VS Code.

This is still observed with the latest version of chrome on Windows & Mac OS.
Can anyone share the resolution for mitigating this?
Thanks in advance.
Note: Usecase at my end is launch the browser in debug mode and interacting with it using the dev tools capability [Selenium WebDriver + debuggerAddress].

Locate Chrome on your computer
Windows Button =>Chrome
Right Click and Open in Windows Explorer
Right clock on the file
Properties
Compatibility
Settings
Run this program as an administrator
Now, in Visual Studio (probably similar in VS Code), add another browser to the VS Browser list (via Browse with)
The full path

Program: C:\Program Files\Google\Chrome\Application\chrome.exe
Arguments: --remote-debugging-port=9222 --user-data-dir="%LOCALAPPDATA%\Temp\blazor-chrome-debug"
Any name will do
Friendly Name: Chrome debugging

Set this as default
Run the application
In both the browser window and the developer window, it will appear as if the application is inactive (the tab is inactive)
But. In the browser window, try to click on the menu items ! (set some breakpoints in the developer windows under Sources=>File... first). And voila !

A small update from my side is that when I opened this page without https (just simple HTTP), then I started getting the debugger options and the file started to be available how it should be
Anyway, from VSCode or VS2022 it's still don't working (I'm running VSCode and VS2022 as an administrator), additionally I changed the browser properties inside VS2022 during the start to meet the same criteria that I'm using by clicking WIN + R

When chrome launched new headless mode (with --headless=new), this problem appears. This problem solved by launch chrome with --headless=old. For example in puppeteer.js, launch with option headless: true. Hope this help.

Confirmed we do not see this on --headless (legacy) but only on --headless=new. I'm going to look for some browser flags to fix this, or a way to use DevTools protocol.
For a live demo of this happening on a real headless (new) browser, check out:
https://puter.com/app/cloudtabs-browserbox

I'm having this issue too, pretty much everytime I try and use this with a nextjs project.  It's super annoying!  All i have to do is open up the connected devtools, open the browser view from that, and then after a little messing around I get the "tab is inactive" overlay and there doesn't seem to be anyway to make it active ever again.  Super annoying.  On Mac with latest vs code & extension version.


Chapter 9 project (typo in file "Project_1.html")

In file "Project_1.html", line 4:

output has slanted quotes "".
What is it, another font?
Anyway, when you copy the HTML to complete the task, the text editor puts another set of "" around it, resulting:

So that the code doesn't work and it's not even about JS.

The slanted quotes should be removed, they were likely an editing error
On Tue, Dec 5, 2023 at 5:37 AM kkvero @.***> wrote:

In file "Project_1.html", line 4:

output has slanted quotes "".
What is it, another font?
Anyway, when you copy the HTML to complete the task, the text editor puts
another set of "" around it, resulting:

So that the code doesn't work and it's not even about JS.
—
Reply to this email directly, view it on GitHub
https://github.com/PacktPublishing/JavaScript-from-Beginner-to-Professional/issues/6,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMBFIRJL422B4IWOPKW77LYH32PLAVCNFSM6AAAAABAHONRDOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDKOBXGQ4DMOA
.
You are receiving this because you are subscribed to this thread.Message
ID: <PacktPublishing/JavaScript-from-Beginner-to-Professional/issues/6@
github.com>


Update index.markdown

Replace  tags with  tags to force list of repositories into a list format, instead of a text blob.

So sorry! I wasn't watching notifications on this repo. I ended up using GitHub's theme functionality. Check out this PR to see how much config has been simplified! https://github.com/Haacked/gh-pages-demo/pull/5


Java 1.5 compatibility

Hello,
I suggest making your lib compatible with java 1.5. It's just a matter of syntax and it would make it compatible with older projects (like the one I'm working on).
Best regards,
Guillaume Petit

While I feel your pain as I also have to work with Java 5 on occasion, I am not going to drop the project from Java 7.
If you fork the project, I will link to yours for folks that require Java 5 support.


Update security_handshaker to use new TSI

Update security_handshaker to use new non-blocking TSI.
Update security_connector and httpcli_security_connector to use transport security adapter.
Tested:
./tools/run_tests/run_tests.py -l c

No significant performance differences

I thought we decided that we weren't going to do this until we had rewritten the TSI implementation to natively use the new API, so that the gRPC code would not have to use the adaptor?
I am not necessarily opposed to having the gRPC code use the adaptor if there's some benefit to doing so.  But if there isn't, it seems like it would be better to wait on this.

Mark, See the design doc for the migration plan. It is hard to avoid using adaptor (in particular the internal TSI implementation). We could write SSL tsi handshaker using new interface natively now. But we cannot write internal TSI implementation natively until the other internal callers of TSI has been migrated.
As tested, there is minimum performance overhead using the adapter. If you prefer, I can write SSL handshaker using new TSI soon. Anna Sapek has signed up re-write fake tsi handshaker.

No significant performance differences

Please merge from master, which should address the generate_projects test failure.
You need to run ./tools/distrib/clang_format_code.sh.
You need to resolve the core_banned_functions failure.

Thanks all for reviews. All comments addressed.
It seems that grpc clang-format tool gets different result from internal vim-based clang-format :)

No significant performance differences

No significant performance differences

No significant performance differences

No significant performance differences

No significant performance differences

No significant performance differences

Code revised. Thanks Mark for suggestion. I revised code such that I only do grpc read inside on_handshake_next_done instead of from on_handshake_data_sent_to_peer. The code seems more clear.

No significant performance differences

Performance differences noted:
Benchmark                  cpu_time    real_time
-------------------------  ----------  -----------
BM_MetadataRefUnrefStatic  -7%         -7%

Code revised again. Thanks Mark for review.

No significant performance differences

Known failures: #11223 #9542 #10686 #10390


PHOENIX-6286 Extend syscat RegionSplitPolicies from the default Polic…

…y for the HBase branch

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
15m 30s
4.x passed

+1 :green_heart:
compile
1m 11s
4.x passed

+1 :green_heart:
checkstyle
0m 31s
4.x passed

+1 :green_heart:
javadoc
0m 54s
4.x passed

+0 :ok:
spotbugs
3m 50s
phoenix-core in 4.x has 962 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 12s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

-1 :x:
checkstyle
0m 36s
phoenix-core: The patch generated 2 new + 11 unchanged - 2 fixed = 13 total (was 13)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 56s
the patch passed

+1 :green_heart:
spotbugs
4m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
136m 48s
phoenix-core in the patch passed.

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

176m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1042/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1042

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 27974610f940 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 6e8d38e

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1042/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1042/1/testReport/

Max. process+thread count
6227 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1042/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


uname command not found

Updated to use game-ci/unity-test-runner@v2 instead of<EMAIL_ADDRESS>and saw that it was unable to find any of the tests. Further it shows the test passing with 0/0 even though there is a compiler error provided down below
-----CompilerOutput:-stdout--exitcode: 136--compilationhadfailure: True--outfile: Temp/Assembly-CSharp-Editor.dll
-----CompilerOutput:-stderr----------
/opt/unity/Editor/Data/Tools/RoslynScripts/unity_csc.sh: line 23: uname: command not found
Failed to load H(~, error: libunwind.so.8: cannot open shared object file: No such file or directory
Failed to bind to CoreCLR at '/opt/unity/Editor/Data/Tools/Roslyn/libcoreclr.so'
-----EndCompilerOutput---------------

I am using Unity 2019.4.22f1 along with this yaml file for my github action
name: Unity Test Runner

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}

on: [push, pull_request]

jobs:
  testAllModes:
    name: Test in ${{ matrix.testMode }} on version ${{ matrix.unityVersion }}
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      matrix:
        projectPath:
          - ./
        unityVersion:
          - 2019.4.22f1
        testMode:
          - playmode
          - editmode
    steps:
      - name: Checkout
        uses: actions/checkout@v2
        with:
          lfs: false # will be true eventually
      - name: Cache
        uses: actions/cache@v2
        with:
          path: ${{ matrix.projectPath }}/Library
          key: Library-${{ matrix.projectPath }}
          restore-keys: |
            Library-
      - name: Tests
        uses: game-ci/unity-test-runner@v2
        with:
          projectPath: ${{ matrix.projectPath }}
          githubToken: ${{ secrets.GITHUB_TOKEN }}
          artifactsPath: ${{ matrix.testMode }}-artifacts
          unityVersion: ${{ matrix.unityVersion }}
          testMode: ${{ matrix.testMode }}
          checkName: ${{ matrix.testMode }} Test Results
          customParameters: '-nographics'

I expected to see the step to fail along and also not a uname not found error :x

Also see this in log. Don't know if this is useful
debugger-agent: Unable to listen on 33
...
Unexpected exit code 1

Closing since this is probably the correct repo: https://github.com/game-ci/unity-test-runner/issues/105


[Bug] Terraform panics when fetching lists of team IDs using data.github_team

Terraform Version
0.9.8
Affected Resource(s)
-data.github_team
Terraform Configuration Files
https://gist.github.com/DWSR/fa65d22519dfc001ef842ad0a4b7ac75#file-main-tf
https://gist.github.com/DWSR/fa65d22519dfc001ef842ad0a4b7ac75#file-variables-tf
https://gist.github.com/DWSR/fa65d22519dfc001ef842ad0a4b7ac75#file-variables-tf
Debug Output
https://gist.github.com/DWSR/fa65d22519dfc001ef842ad0a4b7ac75#file-terraform-log
Panic Output
https://gist.github.com/DWSR/fa65d22519dfc001ef842ad0a4b7ac75#file-crash-log
Expected Behavior
Terraform should return a list of IDs from teams specified in the list members
Actual Behavior
Terraform derped.

This issue seems to be fixed with the latest version of the provider.

Thanks for closing this out @DWSR :)


Pipes doesn't appear to build with GHC-9.0

I tried building pipes-4.3.14 with ghc-9.0-rc1 and got the following error:
Building library for pipes-4.3.14..
[3 of 6] Compiling Pipes            ( src/Pipes.hs, dist/build/Pipes.o, dist/build/Pipes.dyn_o )

src/Pipes.hs:141:9: error:
    • Couldn't match type: Proxy x'0 x0 a'0 a m0 a'0
                     with: forall x' x. Proxy x' x () a m ()
      Expected: a -> Producer' a m ()
        Actual: a -> Proxy x'0 x0 a'0 a m0 a'0
    • In the expression: respond
      In an equation for ‘yield’: yield = respond
    • Relevant bindings include
        yield :: a -> Producer' a m () (bound at src/Pipes.hs:141:1)
    |
141 | yield = respond
    |         ^^^^^^^

src/Pipes.hs:186:36: error:
    • Couldn't match type: forall x'2 x2. Proxy x'2 x2 () c m2 ()
                     with: Proxy x' x c' c m c'
      Expected: c -> Proxy x' x c' c m c'
        Actual: c -> Producer' c m2 ()
    • In the second argument of ‘for’, namely ‘yield’
      In the expression: for p yield
      When checking the rewrite rule "for p yield"
    • Relevant bindings include
        p :: Proxy x' x c' c m a' (bound at src/Pipes.hs:186:26)
    |
186 |   ; "for p yield" forall p . for p yield = p
    |                                    ^^^^^

src/Pipes.hs:640:8: error:
    • Couldn't match type: Proxy x'1 x1 () a m1 ()
                     with: forall x' x. Proxy x' x () a m ()
      Expected: f a -> Producer' a m ()
        Actual: f a -> Proxy x'1 x1 () a m1 ()
    • In the expression: foldr (\ a p -> yield a >> p) (return ())
      In an equation for ‘each’:
          each = foldr (\ a p -> yield a >> p) (return ())
    • Relevant bindings include
        each :: f a -> Producer' a m () (bound at src/Pipes.hs:640:1)
    |
640 | each = F.foldr (\a p -> yield a >> p) (return ())
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cabal: Failed to build pipes-4.3.14

I believe that there has been a subtle change to quantified types that is affecting the use of Proxy throughout the code base.

@recursion-ninja: This looks like a consequence of: https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#deep-instantiation
… and based on that description it seems like the fix is to eta-expand any affected definitions.  For example, instead of:
yield = respond

… we instead define:
yield x = respond x

Could you test to see if that change fixes some of the errors?

I can confirm that the following change does remove the errors.
 yield :: Functor m => a -> Producer' a m ()
-yield = respond
+yield x = respond x
 {-# INLINABLE [1] yield #-}

It appears that @Gabriel439 was correct in diagnosing the cause of these compilation errors.

@recursion-ninja: Is that the only error?  If you can post the full list of errors I can try to fix all of them

@Gabriel439  Those 3 were the only errors I encounter. I could easily resolve the first and third with an obvious eta-expansion. The second error is coming from a rewrite rule, which I was having trouble understanding due to the lack of type signatures and lack of familiarity with the internals of the pipes library.
Since I couldn't resolve the second error, I don't know if there will be other compilation errors after the Pipes module builds. There's a chance the Pipes.Prelude and Pipes.Tutorial modules which depend on the Pipes module could have compilation issues. I wouldn't anticipate that to be the case, but I cannot rule it out either.
If you make a pull request fixing the three compilation errors in the Pipes module, I'm more than happy to rebuild the pull request locally with ghc-9.0-rc1 to confirm that pipes now builds successfully.

@recursion-ninja: Alright, see if this change works better: https://github.com/Gabriel439/Haskell-Pipes-Library/pull/225

@Gabriel439 Unfortunately, after correcting the three compilation errors above, a new error crops up in the Pipes module, now that yield compiles:
src/Pipes.hs:641:8: error:
    • Couldn't match type: Proxy x'0 x0 () a m0 ()
                     with: forall x' x. Proxy x' x () a m ()
      Expected: f a -> Producer' a m ()
        Actual: f a -> Proxy x'0 x0 () a m0 ()
    • In the expression: foldr (\ a p -> yield a >> p) (return ())
      In an equation for ‘each’:
          each = foldr (\ a p -> yield a >> p) (return ())
    • Relevant bindings include
        each :: f a -> Producer' a m () (bound at src/Pipes.hs:641:1)
    |
641 | each = F.foldr (\a p -> yield a >> p) (return ())
    |

This can easily be fixed by eta expansion as well. Once this compilation error is corrected, the Pipes module will successfully compile!
However, the Pipes.Prelude module which imports Pipes no longer compiles:
src/Pipes/Prelude.hs:558:18: error:
    • Couldn't match type: forall x' x. Proxy x' x () a m0 ()
                     with: Proxy () (f a) () a m ()
      Expected: f a -> Proxy () (f a) () a m ()
        Actual: f a -> Producer' a m0 ()
    • In the second argument of ‘for’, namely ‘each’
      In the expression: for cat each
      In an equation for ‘concat’: concat = for cat each
    • Relevant bindings include
        concat :: Pipe (f a) a m r (bound at src/Pipes/Prelude.hs:558:1)
    |
558 | concat = for cat each
    |                  ^^^^

src/Pipes/Prelude.hs:562:52: error:
    • Couldn't match type: forall x'1 x1. Proxy x'1 x1 () c m1 ()
                     with: Proxy x' x () c m ()
      Expected: f c -> Proxy x' x () c m ()
        Actual: f c -> Producer' c m1 ()
    • In the second argument of ‘for’, namely ‘each’
      In the expression: for p each
      When checking the rewrite rule "p >-> concat"
    • Relevant bindings include
        p :: Proxy x' x () (f c) m a'
          (bound at src/Pipes/Prelude.hs:562:27)
    |
562 |     "p >-> concat" forall p . p >-> concat = for p each
    |                                                    ^^^^

src/Pipes/Prelude.hs:666:19: error:
    • Couldn't match type: Producer' b m ()
                     with: Proxy () a () b m ()
      Expected: ListT m b -> Proxy () a () b m ()
        Actual: ListT m b -> Producer' b m ()
    • In the first argument of ‘(.)’, namely ‘every’
      In the second argument of ‘for’, namely ‘(every . k)’
      In the expression: for cat (every . k)
    • Relevant bindings include
        k :: a -> ListT m b (bound at src/Pipes/Prelude.hs:666:6)
        loop :: (a -> ListT m b) -> Pipe a b m r
          (bound at src/Pipes/Prelude.hs:666:1)
    |
666 | loop k = for cat (every . k)
    |                   ^^^^^

src/Pipes/Prelude.hs:929:13: error:
    • Couldn't match type: Proxy x'0 x0 () c m r
                     with: forall x' x.
    • Relevant bindings include
        go :: forall {m :: * -> *} {b1} {x'} {x}.
              Monad m =>
              Producer a m b1 -> Producer b m b1 -> Proxy x' x () c m b1
          (bound at src/Pipes/Prelude.hs:931:5)
        f :: a -> b -> c (bound at src/Pipes/Prelude.hs:929:9)
        zipWith :: (a -> b -> c)
                   -> Producer a m r -> Producer b m r -> Producer' c m r
          (bound at src/Pipes/Prelude.hs:929:1)
    |
929 | zipWith f = go
    |

This is unfortunate, since the changed definitions seem to "bleed outside" of the Pipes module an importing module. It makes me wonder if ghc-9.0 presents a breaking change to the pipes library that might require more thought than some mechanical eta expansions in the library. Will user code importing Pipes encounter similar errors to Pipes.Prelude when using ghc-9.0 if the library were to be fixed with simple eta-expansions?

@recursion-ninja: I think the reliable fix isn't to eta-expand at all, but rather to not use the Producer' type synonyms and instead use an explicit universal quantification for all affected type signatures.

@recursion-ninja: I pushed a few more fixes.  Let me know if I missed anything

The pipes library successfully builds now!
The benchmark and test suite build targets do not build due to transitive dependency compilation errors.
cabal: Failed to build QuickCheck-2.7.6 (which is required by test:tests from
pipes-4.3.14). See the build log above for details.
Failed to build optparse-applicative-<IP_ADDRESS> (which is required by
bench:prelude-benchmarks from pipes-4.3.14 and bench:lift-benchmarks from
pipes-4.3.14). See the build log above for details.
Failed to build regex-base-<IP_ADDRESS> (which is required by test:tests from
pipes-4.3.14). See the build log above for details.

Upgrading to use optparse-applicative-0.16 will likely fix the benchmark suite's compilation error, though it might require minor code changes as part of the interface has changed. If you want backwards compatibility with older versions of optparse-applicativebefore version 16, you might have to use CPP.
I don't know why QuickCheck is failing to build, given that pipes.cabal has permissive upper bounds.
The regex-base compilation error is already a known issue https://github.com/haskell-hvr/regex-base/issues/7. Probably will have to wait for the upstream fix.
I think we should merge changes that fix the library compilation and worry about the benchmark and test suite later. This would allow (most) users pipes to build with ghc-9.0, whether `pipes`` is a direct or transient dependency.

Yeah, the broken benchmark suite is a known issue which I still need to fix, but it's orthogonal to this

@recursion-ninja: https://github.com/Gabriel439/Haskell-Pipes-Library/pull/226 should fix the other build failures you noted


Can flickering be improved when sticky scroll is scrolling across commands?

Repro:

Run echo abc multiple times
Scroll up and down, 🐛 sticky scroll will hide for a frame while scrolling due to sticky scroll hiding when it's command is visible

This is most visible when terminal smooth scrolling is enabled

This probably isn't worth it and will just cause problems.


RTC with 32.768 kHz crystal

Is there any way to configure RTC to run with 32.768 crystal?
This can be very important, ast the current implementation of RTC in deep sleep with internal 150 kHz clock is very inaccurate ( as mentioned in issue #268 ).

Got information it will be solved soon.

Still no solution for this issue ?


Particle out of bound in LLC4320 notebook

This is mirroring https://github.com/MaceKuailv/seaduck_sciserver_notebook/issues/2.
Simply put, the lagrangian trajectories are sometimes wrong. I should prioritize testing.

resolved with PR #62


minor typos

I tried rebasing (squashing) the commits but I seem to made a mess of it... I can close this and do a new pull request if this isn't acceptable for the repo?

Looks fine, thanks!


added filter to add request information in MDC for logging

Signed-off-by: marius-patrascu<EMAIL_ADDRESS>

According to our ICO (uk) - https://ico.org.uk/for-organisations/guide-to-data-protection/guide-to-the-general-data-protection-regulation-gdpr/key-definitions/what-is-personal-data/ ip address is regarded as personal data, also session identifier - I don't think we explicitly log all of this elsewhere so probably need to figure out what we can log or how we mitigate in terms of defaults or documentation? Hopefully I'm being extra careful.

Here's one commentary article.. but we probably need to look for a little more authoritative advice (has some references to the legislation) - https://www.ctrl.blog/entry/gdpr-web-server-logs.html
Wtat drove the need for the logging? Do we have an issue collating relevant points?
Might be worth a discussion on our next call ?

Hmmm...
Good to know that IP is a personal information. :)
As I can see there is a debate if dynamically IP it is or not.
However, the current PR doesn't change the logging default behavior.
The need is that this kind of systems most probably require audit.  This audit is not active by default.
It is pretty much equivalent with enable tomcat access logs.If you do it, you get same information logged for sever chassis, especially as the username is part of the request. Most probably who is do it, needs to ask for consent, but this is another story.

This change is driven form IT risk and operation compliancy requirements and ability to configure the system to produce audit log messages for the authentication process of the UI. For some organisation this is in the minimum standards.
About privacy and sensitivity, it really depends on the context. I agree ip address can be considered as private/personal identification data especially is in case the software is publicly available and accessed form addresses that are private. It depends on the environment and the purpose of the system. Each organisation will have its own policies and procedures how personal data is treated of course copying with regulations such as GRDP for example.
I do not think what we are doing is the code wrong from privacy perspective, the fact that we are associating user access info with the auth event occurred which is quite common practice. How these events will be treated for is subject of operational compliancy and it is responsibility of the organisation operating the software.
I think we should have it as an option (can be off by default) and if needed operator can switch it on.
Let's discuss this next week on the functionality call.

@lpalashevski @bogdan-sava I agree. the two main points are a) that it is off by default, so someone has to be explicit to capture this information and b) that it is the organization that deploys the stack that has to make decisions about how to use it. That does give on onus on us (the developers) to ensure we provide suitable information and defaults.
In summary I now agree with the proposal. We don't have to document as it's non-default behaviour, but if we do, let's just be clear and transparent on what is logged (we don't have to get into gdpr just be clear on the info IMO)


v5 Electron Support (5-8)

Adding support for electron v5-8. PR'ing to v5 due to node-gyp bump

Thank you @glenn2223 for your patience! I'll check if my build machinery can build node-sass for electron as well.

Ref: Commit Fix: Extensions don't honour argument arch
Test 1: Set5: Line 4 setting arch as ia32
Test 2: Success

Thanks @saper

This seems to have a lot more random formatting churn and changes to the overall build setup than the last PR. What has changed that required this?

Formatting:
Sorry I was working on another project at the same time so I just automatically hit my format shortcut. I can revert this if you wish?
Fix: (Fix: Extensions don't honour argument target-arch)
Did you want this on another PR for this?
Electron targeting:
I wasn't able to find a way to run electron commands (for each version) from the CI so I added a --electron-version argument. This added a function and expanded a couple of lines that I've added. This also has the added benefit of targeting an electron build without electron


About  viedo mpd

Can this code get the MPD file of the specified video link？

If you mean can python-mpegdash retrieve a manifest from a specified URL and parse it the yes - see the example in https://github.com/sangwonl/python-mpegdash/blob/master/README.md#usage.
If you mean can python-mpegdash retrieve the manifest associated with some other type of URL eg https://www.youtube.com/watch?v=dQw4w9WgXcQ then no - you'd need to use some other library to get the manifest URL then pass it to python-mpegdash.

Thanks,I'll try to do it.
------------------ 原始邮件 ------------------
发件人: "David @.>;
发送时间: 2021年3月16日(星期二) 晚上7:34
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [sangwonl/python-mpegdash] About  viedo mpd (#39)
If you mean can python-mpegdash retrieve a manifest from a specified URL and parse it the yes - see the example in https://github.com/sangwonl/python-mpegdash/blob/master/README.md#usage.
If you mean can python-mpegdash retrieve the manifest associated with some other type of URL eg https://www.youtube.com/watch?v=dQw4w9WgXcQ then no - you'd need to use some other library to get the manifest URL then pass it to python-mpegdash.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Believe the question was answered, so closing the issue. Thanks.


additional configurations

i want to use this 2 configurations in your image
remote_write:
- url: "http://prometheus_postgresql_adapter:9201/write"
remote_read:
- url: "http://prometheus_postgresql_adapter:9201/read"
how can i do it by environment flags in a compose file

Can you please let me know which exporter you're using? Is it https://github.com/wrouesnel/postgres_exporter?

It's available from the release 17.10.03-18.


Provider is panicking when listing databases

Hi,
Terraform Version
Run terraform -v to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed.
Terraform v1.6.3-dev
on linux_amd64
...
+ provider registry.terraform.io/redislabs/rediscloud v1.5.0
...

Affected Resource(s)
Please list the resources as a list, for example:

rediscloud_database

If this issue appears to affect multiple resources, it may be an issue with Terraform's core, so please mention this.
Terraform Configuration Files
resource "rediscloud_subscription_database" "database" {
  for_each = local.shards

  subscription_id = rediscloud_subscription.$NAME.id
  name = "$NAME-${each.key}"
  memory_limit_in_gb = 10
  data_persistence = "aof-every-1-second"
  throughput_measurement_by = "operations-per-second"
  throughput_measurement_value = 1000
  protocol = "redis"
  password = $PW

  periodic_backup_path = "$PATH"

  alert {
    name = "dataset-size"
    value = 90
  }
  depends_on = [rediscloud_subscription.$NAME]

  lifecycle {
    prevent_destroy = true
  }
}

Debug Output
https://gist.github.com/ksh-chy/eff401edc109c89d49a76e50d5009960
Panic Output
https://gist.github.com/ksh-chy/bd38aff1e0fae1b19ceba51cff9e926d
Expected Behavior
Should tf plan successfully
Actual Behavior
Panic :(
Steps to Reproduce

Setup a "rediscloud_database" datasource.
terraform plan

Important Factoids
Nothing too weird, running on GCP.
References

I believe the issue is in the pagination logic in rediscloud-go-api. When we try to access the second page (offset=100, pagesize=100) the API returns 200, with no databases.

Hi @ksh-chy, This issue should be resolved now.

Thanks @tomerzvirsh - looks good on my end now :)


Added isIncludeEmoji() to StringExtensions

Add Emoji include check method to StringExtensions

Thanks :+1:

My pleasure :+1:


Smart Rollups: where to add them?

I was going to add Etherlink when I realized I don't know where to add it. Shall we create a new category or does it fit in any existing one, in your opinion?

Perhaps a 'Layer 2' category would be prudent? I'm not sure if that is technically correct.

I think it sounds good. And we can change it later if we find a better idea!


Ability to import external modules

Wouldn't it be nice to have the ability to import external modules?
Possible solution:
<script mode='hoisted'>
import * as R from 'ramda'
import anotherTemplate from './anotherTemplate.js'
</script>

Sorry for the late reply.
Yes I've had the same thought, I like your idea of using a mode attribute on the script tag.
My reservation has been that it doesn't encourage keeping code separate in respective .js and .html files.
The same result can be achieved using this approach and passing in the imported dependencies as arguments or as part of a model.

<require from="./another"></require>
<require from="./resource.css"></require>

<require from="./another"></require>  //import first the ".html" (template incremental converted to js by superviewsjs) and the .js with the same name by convention like Aurelia.
<require from="./resource.css"></require> //import styles direct from template


*_mock.go in event-manager

there's some *_mock in event-manager, suggest to move them into a /mock folder, which is did by other managers.

I've removed the "good first issue" label, the reason why _mock files were in the package root directory was circular dependencies that happened when mock subdirectory was used. To fix it, a larger refactor is needed to ensure that the interface consumers and implementations don't live in the same package. The refactor done in #244 will fix this issue.

Fixed via #244


Can't select a date via the month view time picker with keyboard

After hitting "t" to schedule a task, there is no way to move around in and select a date within the calendar picker via the keyboard. Currently, you can only use the keyboard to schedule the task for today, tomorrow, next week, next month, or remove the due date.

Gotchya - thanks for the quick reply and for keeping all of this organized
👍
I want to contribute my feedback for this project because I recognize its
importance, but am not familiar with how github is structured, so thank you
for your patience.
On Mon, Aug 20, 2018 at 1:22 PM Michael Sloan<EMAIL_ADDRESS>wrote:

Yep, this overall issue is tracked by #24
https://github.com/mgsloan/todoist-shortcuts/issues/24 . I want this
too, but it sounds like Todoist's scheduling is going to change a lot
soonish, and so it seems more efficient to wait for that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mgsloan/todoist-shortcuts/issues/37#issuecomment-414396016,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnU0NLx9vZzwnRT7NYAorHRWM98CSOu5ks5uSvBcgaJpZM4WEI4q
.

No problem!  Glad you are enjoying using todoist-shortcuts.  Feel free to open questions / suggestions / bugs etc.


Compile error on Arch Linux

What version of gRPC and what language are you using?
v1.12, Node
What operating system (Linux, Windows, …) and version?
Arch Linux (testing enabled)
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc (GCC) 8.1.0
What did you do?
Compiling the Node package. (I'm on Node 10 and prebuilt binaries are not available.)
What did you see instead?
../deps/grpc/src/core/ext/transport/chttp2/transport/flow_control.cc: In member function ‘virtual uint32_t grpc_core::chttp2::TransportFlowControl::MaybeSendUpdate(bool)’:
../deps/grpc/src/core/ext/transport/chttp2/transport/flow_control.cc:188:50: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
       static_cast<const uint32_t>(target_window());
                                                  ^
cc1plus: all warnings being treated as errors

+1 same here

@vaurelios, your workdaround is working!
Thanks you!

Those precompiled binaries were inaccessible because gRPC 1.10 did not have precompiled binaries for Node 10. We have also published gRPC 1.11, which does have precompiled binaries for Node 10.

Please reopen and fix the unsound cast as well.

@murgatroid99
Please note that both commands below result in same error:
npm install --save<EMAIL_ADDRESS>npm install --save<EMAIL_ADDRESS>
node-pre-gyp ERR! Tried to download(403): https://storage.googleapis.com/grpc-precompiled-binaries/node/grpc/v1.10.1/node-v64-linux-x64-glibc.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, glibc) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Hit error Connection closed while downloading tarball file

Yeah, it still tries do download the 1.10 version.

I have same issue. Can anyone help.
Please if u can.
Contact me with telegram @jsmart4young

I think the problem still persists, please re-open and fix this issue.
Hos-MacBook-Pro:WebApp howawong$ npm install --save<EMAIL_ADDRESS>npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!

><EMAIL_ADDRESS>install /Users/howawong/workspace/WebApp/node_modules/@firebase/firestore/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp ERR! Tried to download(403): https://storage.googleapis.com/grpc-precompiled-binaries/node/grpc/v1.10.1/node-v64-darwin-x64-unknown.tar.gz
node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Pre-built binaries not installable for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v64 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp ERR! Hit error Connection closed while downloading tarball file
  CXX(target) Release/obj.target/grpc/deps/grpc/src/core/lib/surface/init.o
  CXX(target) Release/obj.target/grpc/deps/grpc/src/core/lib/surface/init.o
  CXX(target) Release/obj.target/grpc/deps/grpc/src/core/lib/avl/avl.o
sed: ./Release/.deps/Release/obj.target/grpc/deps/grpc/src/core/lib/surface/init.o.d.raw: No such file or directory
rm: ./Release/.deps/Release/obj.target/grpc/deps/grpc/src/core/lib/surface/init.o.d.raw: No such file or directory
make: *** [Release/obj.target/grpc/deps/grpc/src/core/lib/surface/init.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
gyp ERR!  System Darwin 17.6.0
node-pre-gyp ERR! command "/usr/local/bin/node"<EMAIL_ADDRESS>"install" "--fallback-to-build" "--library=static_library"
node-pre-gyp ERR! cwd /Users/howawong/workspace/WebApp/node_modules/@firebase/firestore/node_modules/grpc
node-pre-gyp ERR! node -v v10.2.1
node-pre-gyp ERR! node-pre-gyp -v v0.7.0
node-pre-gyp ERR! not ok
Failed to execute '/usr/local/bin/node /usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js build --fallback-to-build --library=static_library<EMAIL_ADDRESS>--module_name=grpc_node --module_path=/Users/howawong/workspace/WebApp/node_modules/@firebase/firestore/node_modules/grpc/src/node/extension_binary/node-v64-darwin-x64-unknown' (1)
  CXX(target) Release/obj.target/grpc/deps/grpc/src/core/lib/backoff/backoff.oexec install script
../deps/grpc/src/core/lib/backoff/backoff.cc:23:10: fatal error: 'src/core/lib/gpr/useful.h' file not found
#include "src/core/lib/gpr/useful.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [Release/obj.target/grpc/deps/grpc/src/core/lib/backoff/backoff.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at ChildProcess.emit (events.js:182:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
gyp ERR! System Darwin 17.6.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "build" "--fallback-to-build" "--library=static_library"<EMAIL_ADDRESS>"--module_name=grpc_node" "--module_path=/Users/howawong/workspace/WebApp/node_modules/@firebase/firestore/node_modules/grpc/src/node/extension_binary/node-v64-darwin-x64-unknown"
gyp ERR! cwd /Users/howawong/workspace/WebApp/node_modules/@firebase/firestore/node_modules/grpc
gyp ERR! node -v v10.2.1
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>< 16.4.0 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>< 16.4.0 but none is installed. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build --library=static_library`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Still having this issue on Arch + node 11.0.0 + grpc ^1.11.3.
Work around allow to compile further, but stops to another error:
CXX(target) Release/obj.target/grpc/deps/grpc/src/core/ext/filters/client_channel/subchannel_index.o
  COPY Release/grpc_node.node
  COPY /home/vloz/projets/bbprototype/functions/node_modules/grpc/src/node/extension_binary/node-v67-linux-x64-glibc/grpc_node.node
  TOUCH Release/obj.target/action_after_build.stamp
make: Leaving directory '/home/vloz/projets/bbprototype/functions/node_modules/grpc/build'

../deps/grpc/src/core/ext/filters/client_channel/subchannel_index.cc:255:1: fatal error: opening dependency file ./Release/.deps/Release/obj.target/grpc/deps/grpc/src/core/ext/filters/client_channel/subchannel_index.o.d.raw: No such file or directory
 }
 ^

Why is this closed? I experience same issue like OP

First, this is a fairly old issue. Second, the node repository moved over to https://github.com/grpc/grpc-node. Third, the original issue was fixed. Any other problem you can see will be a different one, unrelated to the original issue. If you have problems installing grpc-node, please open new github issues in the correct repository using the issue template so we can help you with your specific problem.


channelId should be a required property of an Objective

Why: Problem description :confused:
Currently, every objective has a well defined channelId. Yet, there is no channel_id foreign key to the Channels table, necessitating code like this.
What: Describe the solution you'd like :sparkles:
Add a channel_id foreign key column to the objectives table.

There can be multiple objectives for one channel.
An objective may involve multiple channels, but there is one primary channel. EG. the FundGuarantor objective belongs to the guarantorId channel. It also stores references to the jointChannelId & ledgerId. (Arguably, the ledgerId may be the "owner" of the objective. I'm not sure.)

Describe alternatives you've considered :thinking:
I've audited all objectives, and they all have a unique target_channel_id. I believe that it is over-engineering to consider the possibility that future objectives may belong to multiple channels.
Additional context
When calling syncChannel(channelId), the wallet must also sync objectives. (See https://github.com/statechannels/statechannels/issues/3224.)
Having a channel_id field facilitates this.

I think Objectives already make use of join table objectives_channels that has a foreign key reference to the channels table that enforces this?

I think Objectives already make use of join table objectives_channels that has a foreign key reference to the channels table that enforces this?

Have you considered that there are objectives that we know about which involve multiple channels? Two examples:

PartialWithdrawal (will need to have an old_ledger_id and new_ledger_id)
OpenChannels (needs to contain ids of all the opening channels)

I know neither of these are implemented yet, but they seem close enough in the future that it's probably worth considering them here.
It seems that the relationship is "at most one objective per channel", not "at most one channel per objective".

Have you considered that there are objectives that we know about which involve multiple channels? Two examples:
1. PartialWithdrawal (will need to have an `old_ledger_id` and `new_ledger_id`)

IMO, new_ledger_id is the target channel here.

OpenChannels (needs to contain ids of all the opening channels)

I have two different thoughts here
First
Are they funded, "indirectly" or virtually, by a common ledger channel?

Yes: the ledger is the target channel.
No, they're each funded on chain: OpenChannels doesn't make sense

Second
This line of thinking is ingrained in my head from the xstate wallet:

The wallet has "tasks" that should be done for each channel
The wallet also manages complex operations, such as "Close this ledger channel. But first, make sure its child channels are closed & defunded."

Currently, the wallet uses a single data structure for both types of sequences. This limits re-usability somewhat: if two different objectives want to share some common functionality, they need to share some structure, which is a bit limiting. It reminds me of inheritance vs composition.
Direction of relationship

It seems that the relationship is "at most one objective per channel", not "at most one channel per objective".

"at most one objective per channel" is not true:

Each channel gets a OpenChannel and a CloseChannel objective within its lifecycle.

You might say "but both objectives shouldn't be running at the same time". I agree, and therefore I think that a channel should have an active_objective_id. This
A. implies that each channel has at most one active objective.
B. gives the wallet an easy way to know if the channel is running: active_objective_id == null
C. gives the wallet an easy way to tell what objective to crank: active_objective_id
But, there are two other edge cases:
2. CloseChannel is active, and the app called challenge
3. Challenge is active, and the app called closeChannel

I think you're right to clarify that it's one active objective. Proposed objectives should also not count here, so looks like we'll definitely need a way of recording the channel-objective relationship beyond the use of the active_objective_id on the channel. It isn't clear whether this actually needs to be a db relationship though, or whether it could just be channelIds stored in parameters. I think that should be enough for performance, because all the cranks will only involve channels where the active_objective_id is set to that objective, which will make them easy to select.
I'm not sure about whether assigning a target channel in those cases makes sense, or whether it's beneficial to do so. Let me have a think and write down some stuff.

I strongly prefer DB relationships.
It is a very bad thing that we do not know which migrations will run in production, or what effects they will have on wallet behaviour, without having access to production data. A relational schema allows you to do exactly that.
As an example, this migration will probably run in production without errors. It took a significant amount of time, across multiple people, to determine that it will probably run in production. But we can't guarantee it without testing it on production data, which is obviously fragile.
(Side note: It would also break wallet behaviour for existing virtual channel objectives. It is hard to know that, because the "schema" stored in the application code is very far away from the DB. In fact, it's in a completely separate package from the ObjectiveModel code.)

On hold pending further discussion.

Some notes on objectives: https://www.notion.so/Objectives-559365fbd8db4aedb97388e463abe5c1

#3325 should probably be done as part of this refactor.

Let's define the relationship between channels and objectives in the database first


add information in the backlog file

General Checks

[ ] the branch is up to date with main/master
[ ] the code works when pulled and run locally
[ ] All CI checks pass
[ ] all conflicts are resolved (if any)
[ ] PR has a descriptive title
[ ] PR has appropriate labels and milestones for easy identification
[ ] PR it is assigned to the owner
[ ] reviewers are assigned
[ ] the PR contributes only one focused change
[ ] It is in the appropriate column in the project board (if necessary)
[ ] has short and clear description
[ ] is linked to an issue (if it is related)
[ ] feedback is addressed (if any and if it is appropriate feedback.)

Markdown

[ ] the markdown source is formatted
[ ] spelling and grammar is correct in all text
[ ] The markdown looks correct when you preview the file
[ ] all links and images work

HTML

[ ] pages besides /index.html are stored in /pages
[ ] the code is well-formatted
[ ] the HTML is valid
[ ] there are no inline styles (example: style='color: red;')
[ ] there are no <style> tags with CSS, all styles are hrefs
[ ] there is no inline JavaScript (example: onclick='doSomething()')
[ ] there are no <script> tags with JS, all JS is in an separate file
[ ] ids are used for JavaScript only, not for CSS
[ ] semantic tags are used
[ ] spelling and grammar is correct in all site content

CSS

[ ] the code is well-formatted
[ ] passes all the linting checks

Hi @MichaelMugaiga  I see there is a must have section missing in your file and also could have section has content repeated from should have.
Please add a section must have .


Error when trying to add a secret using wrangler

wrangler secret put PRIVATE_KEY
Yields;
 ⛅ wrangler 2.0.3
-------------------

✘ [ERROR] Missing script name

secrets have to be associated with a Worker. This is usually read from a wrangler.toml file in a project (which wrangler will look for either in the directory you call it, or any parent directory). Like @ecchochan pointed out, you can also pass a path to a custom config file), or can be explicitly passed with --name <worker name>.

Closing this, but happy to discuss if there's a problem.

@allsey87 - created an issue to track that https://github.com/cloudflare/cloudflare-docs/issues/4892. I am sure that a PR would be welcome.


added command line flask command to import data from csv. added a dir…

Created a directory for csv files to be imported
changed schema to include name a major columns
created an import-csv function and flask command

looks good


Fixed labels_from_csv

Fixed Thomas's override of labels_from_csv

Hello @aribornstein! Thanks for opening this PR.

In the file flash/data/data_utils.py:

Line 7:1: E303 too many blank lines (3)

Do see the Hitchhiker's guide to code style


When launching the Environment Variables windows, it launches behind the main PowerToys window

Microsoft PowerToys version
0.76.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Environment Variables
Steps to reproduce

Load PowerToys screen
Click on the button to "Launch Environment Variables"
See that is loads behind the main window.

✔ Expected Behavior
Expecting it to load in front of the main PowerToys window.
❌ Actual Behavior
Window launches behind the main PowerToys window.
Other Software
No response

This has been worked on during the 0.77 Release sprint. Please update PowerToys to the latest release: https://github.com/microsoft/PowerToys/releases


custom header for day view

I'm looking to make a custom header for a day view.
for example to count how many events per day and to make header like that:
01-03-2019 (8 events)
how I can make it?

This isn't working for me.

Example
components={{
										week: {
											header: ({ date, localizer }) =>
												localizer.format(date, 'dddd')
										}
									}}

If someone stumbled upon this problem:
components={{
  resourceHeader:  ({label, resoure, index}) => {}
}}

Example
components={{
		week: {
			header: ({ date, localizer }) => localizer.format(date, 'dddd')
		}
}}

Thanks! work perfect, in my case use work_week for remove days of the day.

I am still facing this issue. Is there a fix for this?


Differentiated between oAuthInfo the var and OAuthInfo the constructor

Lowercase constructor was throwing not-a-constructor errors

:+1: Thanks


Explore the methodology and intricacies of Twitter's algorithm

We should try to replicate the algorithm in base R code to understand how it works, and how to select parameters.
The output should be a R notebook.

Does the window size matter in detecting the anomalies?
How do we select the optimal values of alpha and max_anoms ?
What does the parameter longterm mean?


Jblakeman solution

Felt pretty comfortable with this exercise.
Some moderate googling was required for stuff that I couldn't find in the lesson repositories (don't recall if they'd been briefly mentioned in class or not):
e.g. event.target needing to be used in callback functions; how to access the current property value of an element's CSS style using something like: window.getComputedStyle(element).getPropertyValue(property).
All requirements were met, although I didn't have time for the bonus.  I think I improved on some of the functionality of commit 5, as instructions don't specify that the square colors should only change to color of the color-field value when enter was pressed or change color button clicked.  Also, I made it so the initial default background color of the brush box (#1B4370) was immediately used in the square's mousover event listener before a new color-field value had ever been entered.

:+1:  Awesome work here, John! really clean stuff. If you have time, think about taking a stab at the bonus! OR, refactor to jQuery :) not a necessity in any way whatsoever, just some more practice if you want!


Persist the state of service instance operations

Codecov Report

Merging #63 into master will decrease coverage by 2.04%.
The diff coverage is 67.85%.

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     78.89%   76.85%   -2.05%
- Complexity      123      133      +10
============================================
  Files            15       18       +3
  Lines           436      471      +35
  Branches         22       22
============================================
+ Hits            344      362      +18
- Misses           76       93      +17
  Partials         16       16

Impacted Files
Coverage Δ
Complexity Δ

...ppbroker/event/ServiceInstanceStateRepository.java
0% <0%> (ø)
0 <0> (?)

...rkflow/instance/CreateServiceInstanceWorkflow.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

...oker/autoconfigure/AppBrokerAutoConfiguration.java
100% <100%> (ø)
8 <2> (+1)
:arrow_up:

...rk/cloud/appbroker/event/ServiceInstanceState.java
100% <100%> (ø)
3 <3> (?)

...ework/cloud/appbroker/deployer/DeployerClient.java
100% <100%> (ø)
10 <2> (ø)
:arrow_down:

...ppbroker/deployer/BackingAppDeploymentService.java
100% <100%> (ø)
3 <2> (-2)
:arrow_down:

...rkflow/instance/DeleteServiceInstanceWorkflow.java
100% <100%> (ø)
2 <1> (ø)
:arrow_down:

...broker/service/WorkflowServiceInstanceService.java
52.77% <50%> (-24.15%)
7 <6> (+4)

...oker/event/LiteServiceInstanceStateRepository.java
83.33% <83.33%> (ø)
4 <4> (?)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b904b0...3cec415. Read the comment docs.

Please do not merge yet. Work is still in progress!

Already rebased and merged branch


Fix web-sys public agents and improve multithread web-sys

Problem

Web workers were not working in the web-sys multithread example project
No working example for web-sys web workers
wasm-bindgen tries to build ..._bg.wasm url but references document and therefore fails

Changes

Fix web-sys worker initialization by sending _bg.wasm url explicitly
Update gloo to github revision so that IntervalService works on workers for web_sys feature
Improve web-sys multithread example readme

@daxpedda @theneikos could you two please look over the changes in src/agent.rs? I noticed that wasm-bindgen tries to build the _bg.wasm link using document and so it needs to be worked around for workers

I noticed that wasm-bindgen tries to build the _bg.wasm link using document and so it needs to be worked around for workers

I fixed it here: rustwasm/wasm-bindgen#2038.
But it is unrelated to us, because we are making a Blob, wasm-bindgen can't actually build the correct path anyway.
So the workaround is fine in my opinion.

I fixed it here: rustwasm/wasm-bindgen#2038.

Nice!

But it is unrelated to us, because we are making a Blob, wasm-bindgen can't actually build the correct path anyway.

Yes, exactly. I like the blob approach you added because it removes the need to have a simple js file which does that initialization

So the workaround is fine in my opinion.

Sweet, thanks for taking a look!


Introduce more threshold detection for format v2

The feature in cso format v2 is very practical,(when the length of a compressed block is >= block_size, the block must not be compressed.), which directly avoids It saves some unnecessary overhead of system resources on some data that is difficult to compress. Can introduce more parameters to set a threshold for this function, such as 95%? That is, the size of the compressed data block is greater than 95%, which will not compress the data block, but only store it. This can greatly speed up the decompression, as well as the cpu overhead.

There is such an optional already:
   --orig-cost=N    Allow uncompressed to increase block size by N% at most

For example, if you used --block=2048 --orig-cost=1 then any compression that resulted in 2028 or more bytes would be considered "worse" than the original uncompressed data, and would not be compressed.
Note that CSOv2 was designed just as an experiment, but this option also works for ZSO and CSOv1.  With that said, if you are using CSOv2, you may also consider this setting:
   --lz4-cost=N     Allow lz4 to increase block size by N% at most (cso2 only)

Which is essentially the same rules, but for picking lz4 over zlib.  For example, using --block=2048 --lz4-cost=1 would pick an lz4 block at 1001 bytes even if zlib produced one that was 982 bytes.  It's basically how much compression you're willing to sacrifice for lz4.
-[Unknown]

Thank you for your answer, I am not a native English speaker, so I am still a little unclear in some logical terms.
If I want to use libdeflate to compress, use 2048 for the data block, when the compressed data block is larger than 1952, it will not be compressed, only stored, should such parameters be used?
--use-libdeflate --block=2048 --orig-cost=96
And these parameters also apply to CSOv1 ?

The --orig-cost option is a percentage, not bytes.  If you want 1952, that is about 95% of 2048, so you would use --orig-cost=4.69.  This is because 4.69 / 100 * 2048 = ~96.05, therefore 96 bytes at most will be wasted.
If you only want to use libdeflate, you would have to specify --only-libdeflate --block=2048 --orig-cost=4.69.  If you want to allow it alongside the defaults, --use-libdeflate is correct.
Yes, all of these parameters work for CSOv1 as well.
-[Unknown]

Thank you for your answer, I have fully understood the meaning of the --orig-cost parameter
but, what is the difference between the meaning of the --use-libdeflate and --only-libdeflate parameters?
Could it be that by default, in one cso, the program will try all METHODS of compression encodings?

Correct:
--format=cso2 --use-libdeflate --use-lz4brute --block=2048 --orig-cost=5 --lz4-cost=2
If you don't care about compression time, you can also add --use-zopfli.  It will be very slow but zlib may get a bit smaller.  Decompression time will not change, only compression time.
-[Unknown]

Encounter an issue, when using this parameter to compress the cso, the newest ppsspp cannot recognize the image
maxcso --format=cso2 --use-libdeflate --use-lz4brute --block=2048 --orig-cost=5 --lz4-cost=2

PPSSPP doesn't support CSOv2 or ZSO.  As I mentioned - they're experimental.  Also, any device powerful enough to run PPSSPP is not going to benefit much from lz4 or leaving blocks uncompressed - CSO is very fast, and PPSSPP (and its CSO support) is well optimized.
Some PSP CFW had performance issues with CSO files, but it was a bug in older CFW versions and has been fixed.  PPSSPP doesn't have that bug.
Generally, if you're on a device with 1000 Mhz or higher, your best bet is to use cso1 and maximize compression.  If you're using a device slower than 1000 Mhz, it may be better to leave some blocks uncompressed... but PPSSPP won't run very well anyway, so it won't matter.
-[Unknown]

Another question:
If  set a large  block size , will it increase the latency of reading? For example, when the block size is set to 16M, if the requested data is at the end of the block, will it wait to decompress the entire block to read this data?

Yes, the entire block must be decompressed to read from the end of the block.  I don't really recommend block sizes larger than 32K or 64K at the most, as usually the compression benefits are small and it indeed affects the latency.
-[Unknown]

Thanks for the recommend value, I just gave an extreme example for convenience. Through repeated testing, the high affordable value of most images are between 4k-16k. After more than that, the benefits is not great.

Right, well, DEFLATE doesn't really allow large backreferences so the benefits tend to drop off after that, unless you get some good Huffman symbols.
-[Unknown]


refactor: Move background extraction into separate method.

While working on the rotation feature I came across a 25-line segment that was duplicated and that I probably will need to duplicate again, so I thought I might as well move it into a reusable function.
It's neither a bugfix nor a new feature, so tests stay the same.
If you prefer me including this in the rotation PR, let me know, but I thought it was more proper to do it separately.

Coverage remained the same at 98.903% when pulling 6d0d4b339c036b1f8f31f61da5a779cec9466dcf on freezy:apply-alpha into db2af42ee7b68a44dcb55027a07a1e18797c8d3d on lovell:teeth.

Brilliant, thank you!


Refactor land-use-chart component

This is becoming a candidate for refactoring. Some thoughts:

It's probably an anti-pattern (data down, actions up) that the component makes an network request for data, then passes it down. This should be reconsidered: the route should be responsible for pulling data. Exceptions to this rule make sense, for example, when we're loading a component that grabs data for 3rd party services like a twitter feed. At the very least, a promise of some form should be handed down to the component.

This branches off the above thought, but should we keep the network request in the component, we probably need a more sophisticated way of getting the component to know promise state. The ES6 'fetch' function doesn't have a way of conveying synchronously the status of the promise. Consider ember-deferrable-content or Ember concurrency. The latter will terminate an in-progress network transition during multiple network requests, which eliminates awkwardness.

consider c3, or extending c3, which is unit tested and has large community support, to handle the chart. Bespoke solution is more customizable (maybe - depends on where needs are finalized), but maybe presents unintended consequences and other gotchas in later weeks.

Some discussion about this: https://www.youtube.com/watch?v=y7aHMj6VVJY&feature=youtu.be&t=1129.

@allthesignals ???

@jorgeh01 hmmm not sure what you mean?

@allthesignals not sure what i mean either :/ LU chart looks fine to me

This will be eliminated by #601


Support generic s3

This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

Hi and thanks for your contribution! :)
I know this is still a draft PR but what would really help with reviewing this PR is if you could add some explanation about what it does and why. The same goes for the actual commits (https://www.osbuild.org/guides/developer-guide/workflow.html).
And finally, starting today we will use the PR titles directly for our release notes so ideally the title conveys a clear summary of the changes.

@ochosi Sorry for that, all the details are in the first commit. I'll paste them here as well and fix the PR's title

New Feature
Before this change the worker supported uploading to AWS S3 but only via the REST API. This change enhances this capability in two ways:

Support uploading the AWS S3 also via the WELDR API
Support non-AWS S3 services (e.g. MinIO)

Code Changes
jobimpl-osbuild
Add GenericS3Creds to struct
Add method to create AWS with Endpoint for Generic S3 (with its own credentials file)
Move uploading to S3 and result handling to a separate method
adjust the AWS S3 case to the new method
Implement a new case for uploading to a generic S3 service
awscloud
Add wrapper methods for endpoint support
Set the endpoint to the AWS session
Set s3ForcePathStyle to true if endpoint was set
Target
Define a new target type for the GenericS3Target and Options
Handle unmarshaling of the target options and result for the Generic S3
Weldr
Add support for only uploading to AWS S3
Define new structures for AWS S3 and Generic S3 (based on AWS S3)
Handle unmarshaling of the providers settings' upload settings
main
Add a section in the main config for the Generic S3 service for credentials
If provided pass the credentials file name to the osbuild job implementation
Upload Utility
Add upload-generic-s3 utility
Makefile
Do not fail if the bin directory already exists

@ochosi Please note that I've set it as a Draft PR in order to be able to run the CI before actually setting it as Ready. But, from any other aspect, it is ready for review.

I would also like to mention, that this PR will have to reflect #2474 if it is merged after it. Or the other way around... 🙂

* You forgot to extend `targetsToUploadResponses()` in `internal/weldr/upload.go` for the newly added targets (AWS S3 and generic S3).

Done

Since you technically enabled also AWS S3 for Weldr API, it would be great if you could add an integration test which would test it. Basically a very similar one to the Generic S3 test case, which you added in this PR, but for AWS S3...

I've implemented the test for AWS. The first run failed and I think I fixed it now. Once the tests pass, I'll move the PR to Ready

The Generic S3 test failed - https://gitlab.com/osbuild/ci/osbuild-composer/-/pipelines/500259589

The new integration tests passed successfully. I've removed the commit that disables all other tests and moved the PR to Ready

@ygalblum Thanks a lot!
Unfortunately, with the addition of the aws and generic S2 integration test, we are running into a GitLab CI limitation jobs:integration:parallel:matrix config generates too many jobs (maximum is 50). We'll have to split the integration tests into more groups. We'll discuss this within our team later today...

although you'll still have to adjust and rebase after https://github.com/osbuild/osbuild-composer/pull/2488 gets merged
@thozza Done

/packit rebuild-failed

Rebased using GitHub button, so that the CI infra fixed are picked up...

It seems like I'm getting some intermittent failures along with a consistent failure in RHEL and CentosStream 9. For some reason, the test fails to connect to the VM and the logs cannot explain why. I'll try to run it locally

@thozza I finally got my tests to pass. I found that the libvirt tests are defined in a different section of the CI file and since my tests are basically libvirt tests (just with a different storage option), I moved them there. So, all the checks are green and I'm only missing an approval

@ygalblum would you mind submitting a short documentation update about uploading to S3 in https://github.com/osbuild/guides ?


localization

What is the way to localize fexo and display the site in other languages?

You can modify language settings in _config.yaml in the root of Hexo blog (not /theme/fexo/_config.yaml)
For example. if you want to show the website in English just specify
language: en

The availbale options are en, no, zh-CN and zh-TW


NIFI-7015 - ConsumeJMS supports additional message types

https://issues.apache.org/jira/browse/NIFI-7015
ConsumeJMS now supports ObjectMessage, MapMessage and StreamMessage types as well. Added optional ERROR_QUEUE property. Result flowfiles get a 'jms.messagetype' attribute that contains the incoming message type (TextMessage, BytesMessage, ObjectMessage, MapMessage or StreamMessage).
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Thanks @tpalfy, this is really nicely done! Was able to test it locally. I tried with TextMessage and BytesMessage, which we originally supported and all worked well. Tried with the new ObjectMessage and StreamMessage and these worked exactly as expected. MapMessage wrote out the JSON as intended. Also tried with an ActiveMQBlobMessage, since I was testing against ActiveMQ. As expected, it did receive the message but failed to process it, so it pushed it back to the error queue. All works exactly as expected. +1 will merge to master. Thanks again!

And what about BlobMessage support?


[$500] Public room - Sign in button remains when login new user via public room

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Sign out from New dot if you are logged in
Open public room link
Go to Sign in> Finish the sign in process with NEW account

Expected Result:
User should be signed in and there should be no Sign in button since the user is already signed in
Actual Result:
Sign in button remains on the left top on the screen, when click Sign in user land on login page
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/204a48d5-011f-498f-8018-8b20fc928baf
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0f529690a8d5a49
Upwork Job ID:<PHONE_NUMBER>450307072
Last Price Increase: 2024-03-29

@sonialiap  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
When the anonymous user successfully signed-in, the sign in button on the top left still shown.
What is the root cause of that problem?
To show the sign in button, we check whether the user is an anonymous user or not imperatively.
https://github.com/Expensify/App/blob/9dde2d57b3fd9bbadf20d23fd8dea9efb30a81a1/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx#L60-L63
However, the component won't re-render when the user type is changed from anon --> non-anon because we are not subscribing to the session data.
What changes do you think we should make in order to solve the problem?

Subscribe to the session data and check whether it's an anon user or not based on the session data
const isAnonymousUser = session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS;

{isAnonymousUser ? (
    <SignInButton />
) : (

Proposal

State Management Review: Conduct a thorough review of the state management logic surrounding the sign-in process. This includes verifying if the state correctly updates and propagates through the application upon user authentication.
Event Handling Optimization: Ensure that event listeners related to the authentication process are optimally implemented, particularly those triggering UI updates post-sign-in.
Context API/Redux Investigation: For applications using Context API or Redux, inspect the global state management to ensure it accurately reflects the user's sign-in status across all components.
Component Lifecycles: Review the lifecycle methods or React hooks (e.g., useEffect) responsible for triggering UI updates based on authentication status changes. Ensure they are correctly implemented and invoked.

This proposal is designed to rectify the identified bug not only in the specific occurrence but also in all related instances throughout the application.
Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/pierreadel2

It could be a problem since the initial implementation or maybe the parent component triggers the re-render of it, it's hard to point out the exact one.
If you look at the rest of Session.isAnonymousUser usages, none of them affects the rendering of a component. But, there are 2 useEffect that use Session.isAnonymousUser.
First, the effect depends on isLoadingApp, when we switch from anon -> non-anon user, isLoadingApp is also updated (triggered by OpenApp), so there will be no problem.
https://github.com/Expensify/App/blob/5a8cb7fb94eeb16cfad5407dd9495be1f0a921b9/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx#L42-L52
Second, the below effect is to trigger the open app in the desktop dialog. Not sure if we want to re-trigger it when the user is changed from anon -> non-anon.
https://github.com/Expensify/App/blob/5a8cb7fb94eeb16cfad5407dd9495be1f0a921b9/src/components/DeeplinkWrapper/index.website.tsx#L60-L96

I will review the proposal shortly.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Public room - Sign in button remains when login new user via public room
What is the root cause of that problem?
Session.isAnonymousUser changes but the page is not re-rendered, here:
https://github.com/Expensify/App/blob/99cc0b6f34c477dee40934b0ffb294e5dde1f58a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/TopBar.tsx#L60
What changes do you think we should make in order to solve the problem?
Connect to Onyx session in TopBar, as suggested by another contributor, but     then pass session to a new function in libs/SessionUtils called isAnonymousUser to better organize code. Import from libs/SessionUtils instead of libs/actions/Session to follow existing convention of using ..Utils files to contain functions which take objects as arguments and answer questions about those objects, as is done in libs/ReportUtils and many other ..Utils files.

export default withOnyx<TopBarProps, TopBarOnyxProps>({
    policy: {
        key: ({activeWorkspaceID}) => `${ONYXKEYS.COLLECTION.POLICY}${activeWorkspaceID}`,
    },
    session: {
        key: ONYXKEYS.SESSION,
        initialValue: {},
    },
})(TopBar);

We define the session so that it can update with updated user information and trigger a re-render of the TopBar component when necessary.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link:  https://www.upwork.com/freelancers/~01a52c53655bca1425?referrer_url_path=%2Fnx%2Fsearch%2Ftalent%2F

Thanks for the proposal everyone.
As mentioned by @GandalfGwaihir, the issue only occurs if the user is a new to Expensify. I have gone through the proposals but haven't found why does this happen.

I have added an explanation of why the component re-renders when we login with an existing account.

Thanks for the update @bernhardoj
Your proposal and RCA looks good to me. We are using session in ReportFooter as well. So, I believe your proposal will do the job.
🎀 👀 🎀 C+ reviewed

PR is ready
cc: @sobitneupane

@sonialiap This is ready for payment.

Thanks for the bump, looks like Melvin slept through this one -__-
Payment summary:

Contributor @bernhardoj $500 - paid ✔
Reviewer @sobitneupane $500 please request in ND

$500 approved for @sobitneupane


Sentry dart plugin does not detect and send .dart files to Sentry.

Environment
Sentry dart plugin  v.2.2.0
Steps to Reproduce
The problem I have is that it doesn't send .dart files to Sentry, it only sends one package with .js files (10 pieces). There should be a second portion, much larger with .dart files. The logs say that it found 10 files first, then 0. In the previous version of the package, all files were sent, and in the latest one only one part.

Expected Result

Actual Result

thx for the info, with 2.1.0 it worked before?

We bumped our CLI from v2.27.0 to v2.38.1 in 2.2.0, could you try setting sentry_cli_version to 2.27.0 in your plugin config and see if that makes a difference?

Still doesn't work.

Still doesn't work.
I have a Flutter app that is embedded in a React app when built.
I use fvm flutter build web --base-href "/simulator/" --source-maps --output "../shopify/web/frontend/simulator" --dart-define=SENTRY_RELEASE="${RELEASE_NAME}" --dart-define=SENTRY_DIST="${DIST_ID}".
Maybe this information will be useful.

UPDATE: I changed the build_path to a few folders up and now the .dart files are uploaded and working 😉

@lukaszmielczarekdev could you post your updated config? I'd like to understand what's going on (I've made the PR to change what we upload)

In 2.1.0 the web_build_path was a full path build/web and now in 2.2.0 is relatively just web making existing configurations. We have changed to use the defaults and still, sentry reports that there is nothing to upload for web builds

@lukaszmielczarekdev @ciprig this issue should be fixed by #285
You can verify or use the fix in the meantime by adding a dependency override:
  sentry_dart_plugin:
    git:
      url: https://github.com/getsentry/sentry-dart-plugin.git
      ref: efa59dda844c34c6399bc09ae9fa27f0fd9daa27

official fix is released in 2.2.1


What branch of Dash Core to use

README.md tells us

Install core. You can use the docker image (dashcore:evo) or clone code from the repository, switch to the evo branch, and build it by yourself. Note: you need to build image with ZMQ and wallet support. You can follow the build instructions located here

Is this still the case? I thought we are using the release version of Dash Core.

You right. README is outdated.


Can't get TLF private key for key generation 1

Hi!
I'm getting "error code 218 - Can't get TLF private key for key generation 1" when trying to create a new repo.
And "an unexplained error has occured" when trying to open my private folder (amongst others).
I saw earlier posts referring to this being caused by deleting my early keybase devices & I definitely had the misfortune of having to do that.
Can you help me out?
Thanks!

If you do a keybase log send, and post the resulting ID here, I can take a look.

Thanks for the very fast reaction!

gert@Benedikt:~$ keybase log send
This command will send recent keybase log entries to keybase.io
for debugging purposes only.
These logs don’t include your private keys or encrypted data,
but they will include filenames and other metadata keybase normally
can’t read, for debugging purposes.
Continue sending logs to keybase.io? (type 'YES' to confirm): yes
Enter feedback (or  to send): regarding https://github.com/keybase/client
/issues/16398
More feedback (or press  when done):
Hint: You are currently not seeing messages from other users and the system.
Users in the 'systemd-journal' group can see all messages. Pass -q to
turn off this notice.
No journal files were opened due to insufficient permissions.
▶ ERROR Error reading logs: Journalctl exited with an error: exit status 1

Success! Your log ID is:
05b6788b95becdbfeb1dce1c
Here's a URL to submit new bug reports containing this ID:
https://github.com/keybase/client/issues/new?body=[write something useful and descriptive here]

my log id: 05b6788b95becdbfeb1dce1c
Thanks!

Yes, it seems like you've revoked all the devices that have had access to that folder.
If you want us to reset your folder, please run this command on a currently-valid keybase device, and substitute the current date and time where indicated:
keybase sign -m "<DATE_AND_TIME>: Please reset folder /keybase/private/gertschepens because all the devices that have access have been revoked."

and post the results here.

Again, thanks for the swift support!
C:\Users\gert>keybase sign -m "05/03/2019 - 18:52: Please reset folder /keybase/private/gertschepens because all the devices that have access have been revoked."
BEGIN KEYBASE SALTPACK SIGNED MESSAGE. kXR7VktZdyH7rvq v5weRa0zkLl2OX6 2HWHVoRNNhFKcSb 6phCb16gwoGEc42 JVTjd1QuDxTR3SW 4sQBu5PWK3nj5xQ zyTOOZk6aMSPpDd hepF2hFGUmhjd9f QAxPQEP3l9IQzrd TvEIicIzkyakoVB 1HgI6AV65z8QzlD ImBYR3xkvgdETsk skb8rfVtH9inGhE l5N2yYRy1g8anxJ 696UOO2VbByGCPC MOpuQKDVGkyShnj CHkYvgAVbq49opC RftRbFrFA9SaJNr kd0RgYehA6SkvTz sWNU90lZCulTrNd ANo2Lvhn5JaNDLB wX7MWE0Po1DGxzH i6aSrK3SAItsrF9 t1GFjoZG7lhFRm. END KEYBASE SALTPACK SIGNED MESSAGE.

I reset the folder.  Please check it out and close this if everything seems ok.  (Might require a Keybase restart.)

It's all working now! Thanks for the awesome support!
Making a point of not having simultaneous device crashes anymore 🙈


on Windows sometimes shows cmd window

Ugdown Version: v0.2.0-beta
OS: Windows 10
After clicking the detect or start button, the cmd window shows.

It should be fixed in v0.2.1-beta


Ready for review

Hey @skeydan @jonathanbratt @jonthegeek @dcdorukcengiz
I mostly finished porting the Deep Learning chapter from Keras to luz/torch.
I wonder if you could review the text in this repository.
Currently it requires dev version of all packages: torch, luz, torchvision, torchdatasets. but we will publish them to CRAN once the review is finished.
There's a rendered version available at: https://rpubs.com/dfalbel/815416
Best,

FYI my book club isn't to this chapter yet. I think it looks great but I might have more thoughts in a few weeks.

Cool! Thanks @jonthegeek !
I'm closing this because I just sent this to ISLR authors and it's about to go to their website.


emoji: Enable Japanese characters in the symbol section.

Matrix.org and Slack have those characters in their symbol section.
:congratulations: now refers to the Japanese character version, as is
observed in Matrix and Slack.

[x] Tested!

Testing plan:
GIFs or screenshots:

Thanks for debugging this @rht!
Can you fix the test failures? It'd also be useful to provide a bit more detail in the commit message.

Test failures fixed. Added more explanation.

This PR is obsoleted by #19637, which auto-generate emoji_names.py, which correctly maps congratulations to :congratulations: .

I'm going to merge this since #19637 isn't finished and this will likely shrink the complexity of the changes there.


Can't download the evaluation data?

Hi, I can't download the evaluation data from this link:
https://raw.githubusercontent.com/monaen/LightFieldReconstruction/storage/data/evaluation/buddha.mat.
Any suggestion about this?
Thanks.

Sorry for the late reply.
Do you still have a problem when downloading the data? I can download it as usual.
Thanks

Sorry for the late reply.
Do you still have a problem when downloading the data? I can download it as usual.
Thanks

Hi, I can't download the evaluation data from this link:
https://raw.githubusercontent.com/monaen/LightFieldReconstruction/storage/data/evaluation/buddha.mat.
Any suggestion about this?
Thanks.

Hi，Try this link https://github.com/monaen/LightFieldReconstruction/tree/storage/data/evaluation/buddha.mat. It should work. Cuz I encountered the same problem when downloading training samples. And I clicked into the storage branch and found the link is different from the link in the shell.

Hi, I can't download the evaluation data from this link:
https://raw.githubusercontent.com/monaen/LightFieldReconstruction/storage/data/evaluation/buddha.mat.
Any suggestion about this?
Thanks.

Hi，Try this link https://github.com/monaen/LightFieldReconstruction/tree/storage/data/evaluation/buddha.mat. It should work. Cuz I encountered the same problem when downloading training samples. And I clicked into the storage branch and found the link is different from the link in the shell.


service/config update style is garish

the dark blue that is on the config page mixed with black text is incredibly hard to read. resolve that coloring

Style fixed in earlier version


As a user I want to create a Kubernetes cluster using the demo instructions on MacOS

Description
Currently when you run the terraform/cluster template in the cloud-api-adapter demo on MacOS you receive an error after the containerd dependency in the Ansible playbook times out.
@mattarnoatibm kindly informed me they had the same issue running from their system when running the demo steps. Matt has identified a mitigation for this which is to include the -f parameter in terraform/cluster/scripts/keygen.sh line 71, which would look like this:
ssh-copy-id -f "${opts[@]}"  ...

this fixes the error encountered when running the Terraform template from a MacOS system.
However, including the above mitigation could have knock-on effects for other systems. So the change we actually want here is to have the keygen.sh script check the operating system of the user, and choose the best option for them. This could be done using an if-else.
By identifying the operating system of the user running the script, we fix this issue for MacOS systems, and prevent side effects by forcing the ssh-copy-id to copy the key if there is something wrong.
Task List

[ ] Make changes to cluster/scripts/keygen.sh near line 71 to include an if-else that compares operating systems so the ssh-copy-id command is executed either with the -f parameter for MacOS or, as it is now, without.
[ ] Test fix on MacOS and show results.
[ ] Test fix on Ubuntu 18.04 - 20.04
[ ] Make a PR for this change. This story is not done until the PR is approved & merged.

Performance Considerations
Nothing comes to mind.
Security Considerations
Nothing comes to mind.
Acceptance Criteria
Given I want to create a new Kubernetes cluster
When I run the demo steps to create one using a system on MacOS
Then I have a new, working Kubernetes cluster as expected

@Jonah-F is this issue still relevant or can be closed?
If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?

Hi Ariel.
This issue is still relevant for users running the terraform/cluster configuration for setting up the peer pods / cloud api adaptor demo for IBM Cloud on MacOS.
I think it could be completed for mid-November as long as we don't change how the keygen.sh works for people running demo for IBM Cloud setup on non-MacOS workstations.

@mattarnoatibm just wanted to check you still think this can converge for release V0.3.0 (January 15th freeze0

Hi @ariel-adam , yes, this work should be complete following merging commit f489244 into the staging branch.


question about the bootstraping

$ docker stack deploy -c docker-compose.yml galera
$ docker service ls
(wait for `galera_seed` to be healthy)
$ docker service scale galera_node=2
(wait for both `galera_node` instances to be healthy)
$ docker service scale galera_seed=0

Why set the galera_seed to 0 in the end ?

Because the seed is for starting a new cluster and if it gets rebooted somehow you don't want it starting a new cluster, you want the cluster to be recovered which is done only for the "node" instances.


Request executor schema disposal changes and test

See #4863

/AzurePipelines run

I changed the target to main ... we first get it into main and then do a cherry-pick to v12

Although in this case we do it the other way around since we would have to many merge issues.

@michaelstaib Any suggestions on removing the 5 minute delay? It makes the integration test problematic. https://github.com/ChilliCream/hotchocolate/blob/437e97a5764092c6a75b50b93876e010196e91db/src/HotChocolate/Core/src/Execution/RequestExecutorResolver.cs#L161
I was thinking about trying to use the diagnostics events to track in flight requests - thoughts?

Yes ... we could track if there are still requests in the executor ... on the executor, we could keep a number ActiveRequests with Interlocked.Increment. This would allow us to remove the fixed time and rather check against this count ... once the count has reached 0 or a grace period is over we will evict.

Yes ... we could track if there are still requests in the executor ... on the executor, we could keep a number ActiveRequests with Interlocked.Increment. This would allow us to remove the fixed time and rather check against this count ... once the count has reached 0 or a grace period is over we will evict.

I've had a go at this, not sure if I've accounted for Deferred and Batch queries correctly but I think so?

#4874

#4874

Hi Michael what was the context for that link sorry. Was that for the active request tracking?

@matt-psaltis the active count would not work like done. I have reworked the result objects to be simpler and allow release tracking. We now have two result objects, QueryResult and ResponseStream. A ResponseStream represents a stream of QueryResult, we use this one now for subscriptions, defer, stream and batch. With each result you can register a cleanup task which will be triggered when the result is disposed. Also I am introducing a completed event on the ResponseStream. This completed event is what we can subscribe to in this PR.
In any case, we need to lift this PR on main since the new APIs will only be available in V13.


Updated outro 2 copy

Changed abandoned warehouse -> address. At this point the player has no idea it's an abandoned warehouse.
Pull Request checklist
Please review the below PR requirements:

Build was run locally and any changes were pushed
Ensure that the title clearly describes the changes
Issue to be referenced in the PR description rather than in the commits or PR title
Clean commit history

Merged because they were simple copy updates.


Refactor settings table in readme

I'd like to be able to clear up the settings table and make it a bit more readable. We could move the links to the environment variables themselves -- for those that link to another section in the readme, they should link there instead of to the remote documentation.
The goal here is to make the table a bit more readable and less cluttered. Currently, some of the longer defaults (like channelname, username, ice) are wrapped -- this is harder to read (especially with a regular expression), and the issue is more convoluted on smaller screens, especially if the particular interface doesn't adjust the table using media queries (e.g. docker hub).

I'm on it!


Enable RS256/ES256 and other algorithms for JWT strategy

To do

[x] Implement ability to choose a JWT algorithm and supply a separate public key
[x] Add unit tests for RS256
[x] Add unit tests for ES256
[x] Update docs

Rationale
This PR extends the JWTStrategy class to enable a choice of JWT algorithms and to make it possible to provide separate keys for encoding and decoding the JWT. In particular, this allows the usage of the RS256 and ES256 algorithms.
From RFC 7519, section 8:

It is RECOMMENDED that implementations also support RSASSA-PKCS1-v1_5 with the SHA-256 hash algorithm ("RS256") and ECDSA using the P-256 curve and the SHA-256 hash algorithm ("ES256").  Support for other algorithms and key sizes is OPTIONAL.

Comparison of RS256/ES256 and HS256
Benefits of RS256/ES256
A recipient of the JWT can verify whether the JWT was signed by the genuine issuer without needing access to that issuer's private key. Providing the private key would also provide the ability to sign (and therefore forge) JWTs.
Being able to independently verify the authenticity of a JWT is important for microservices architectures where an authentication microservice may issue JWTs and expect those to be accepted and trusted by other microservices.
Benefits of HS256
HS256 is simpler to set up than RS256/ES256, needing only a simple secret instead of a cryptographic key pair.
Summary of changes
JWTStrategy class
There are no compatibility-breaking changes.
Constructor
Two additional parameters have been added:
        algorithm: str = "HS256",

Optional - allows an alternative JWT algoritm to be selected.
        public_key: Optional[SecretType] = None

If set, JWTs will be continue to be encoded with the secret parameter but decoded with the public_key parameter.
Additional properties
The properties encode_key and decode_key have been created to provide the desired behavior, and to provide future extensibility by decoupling the methods read_token and write_token from the private attributes secret and public_key.
Unit tests
Unit tests for RS256 and ES256 have been added using indirect parametrization of the jwt_strategy fixture.
Dependencies
Production dependencies
pyjwt is now pyjwt[crypto] to support cryptographic verification of RS256/ES256 tokens. (This could also be made an optional extra.)
Development dependencies
pycryptodome has been added to generate an RSA and ECC key pair for testing.

Thank you @jtv8! That's definitely interesting. I'll make some comments but we should be able to merge this rather quickly.

Should hopefully be good to go now @frankie567. Would it be OK to get approval to run workflows so I can check that the CI tests are green for this and any future PRs?

Is this ready to merge @frankie567?

@all-contributors add @jtv8 for code


Generate code for Struct/Data hash/==

Since updating literal I think Im seeing a problem with equality of Structs

class Person < Literal::Struct
	prop :name, String
end

class Student < Person
	prop :final_grade, Integer
end

test do
	a = Person.new(name: "Joel")
	b = Student.new(name: "Joel", final_grade: 90)

	expect(a) != b
end

gives
 expected #<#<Class:0x000000011f1bed90>::Person:0x000000011f0d6860 @name="Joel"> to != #<#<Class:0x000000011f1bed90>::Student:0x000000011f0d67e8 @name="Joel", @final_grade=90>
It seems the new implementation assumes equality if the other struct has the same attributes + values but doesnt account for if the other struct has other attributes that are not on the current

Pushed a failing test to main so we can then resolve


Unify error panel + linter UI (same icons)

What should we do?
Use same icon for errors / warnings in problems panel and error overlays.
Why should we do it?
Ensure users can connect the dots easily.

Removing M65 milestone as this dropped in priority.