Add label to autocomplete input

Description
Input fields require labels to be accessible.

closing in favor of https://github.com/NuCivic/react-dash/pull/53


Replay parsing failures

Trying to load replays at load_level=2 and sc2reader errors out with the following stack trace:

Traceback (most recent call last):
File "main.py", line 443, in
main(sys.argv[1:])
File "main.py", line 185, in main
replay_list = list(replays)
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/factories/sc2factory.py", line 146, in load_all
yield self._load(cls, resource, filename=filename, options=options)
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/factories/sc2factory.py", line 151, in _load
obj = cls(resource, filename=filename, factory=self, **options)
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/resources.py", line 301, in init
self._read_data(data_file, self._get_reader(data_file))
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/resources.py", line 893, in _read_data
self.raw_data[data_file] = reader(data, self)
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/readers.py", line 274, in call
for i in range(data.read_bits(5))
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/readers.py", line 274, in
for i in range(data.read_bits(5))
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/readers.py", line 197, in
for i in range(
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/decoders.py", line 210, in read_uint32
data = self._buffer.read_uint32()
File "/home/steve/workspace/trueskill/venv/lib/python3.7/site-packages/sc2reader/decoders.py", line 91, in read_uint32
return self._unpack_int(self.read(4))[0]
struct.error: unpack requires a buffer of 4 bytes

Script runs successfully when load_level=0
Here's the relevant output of sc2parse (only the errors):
pastebin
Here are archives of the offending replays:
sc2reader_replays_1.zip
sc2reader_replays_2.zip
sc2reader_replays_3.zip
sc2reader_replays_4.zip
sc2reader_replays_5.zip

@eudaimonstro Sorry for the slow reply. I forgot to deploy v1.6.0 that fixed parsing for StarCraft 2 5.0 replays. v1.5.0, which is what I suspect you had, did not work for these new replays. Can you see if it's working for you now?


RecursionError: maximum recursion depth exceeded

System Operating System (OS)
Linux
Python Version
3.9 (CPython)
Install Source
pip / PyPi
Install version / commit hash
v3.9.2
Expected Behavior vs Actual Behavior
Expected Behavior:
Song is download with a filename following the path-template specified.
Actual Behavior:
When downloading certain songs, spotDL errors out if a path-template is specified; stating a RecursionError. I have observed this on "Lump" by "The Presidents of the United States of America" and "Peaches" by the same band. Perhaps it it something with the long length of the artist name? The path template used is '{playlist}/{artists}/{album}/{title} - {artists} - {album}.{ext}'.
When downloading without a path-template, those two songs downloads fine. Almost every other song that I tried downloaded fine with and without the same path-tempate.
Steps to reproduce
spotdl https://open.spotify.com/track/2JdzB67NvIa90K4gEZPLeX?si=bf3d9b2d177b4754 --path-template '{playlist}/{artists}/{album}/{title} - {artists} - {album}.{ext}'
and also
spotdl https://open.spotify.com/track/3VEFybccRTeWSZRkJxDuNR?si=db31064fe5124112 --path-template '{playlist}/{artists}/{album}/{title} - {artists} - {album}.{ext}'
Traceback
Error: maximum recursion depth exceeded While Error : The Presidents Of The United States Of America - Peaches
 Traceback (most recent call last):
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/download/downloader.py", line 156, in download_song
    converted_file_path = _parse_path_template(
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/providers/provider_utils.py", line 145, in
_parse_path_template
    return _parse_path_template(
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/providers/provider_utils.py", line 145, in
_parse_path_template
    return _parse_path_template(
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/providers/provider_utils.py", line 145, in
_parse_path_template
    return _parse_path_template(
  [Previous line repeated 981 more times]
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/providers/provider_utils.py", line 130, in
_parse_path_template
    artist=_sanitize_filename(song_object.contributing_artists[0]),
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/providers/provider_utils.py", line 69, in
_sanitize_filename
    return format_name(input_str)
  File "/home/jasper1378/.local/lib/python3.9/site-packages/spotdl/utils/song_name_utils.py", line 5, in format_name
    output = "".join(char for char in output if char not in "/?\\*|<>#")
RecursionError: maximum recursion depth exceeded

Other details
No response

The path will be too long, so it tries again but with only one artist. But it fails because there is only one artist so it tries again and again.
I won't fix this in v3 because it's really rare, but I will fix it in the v4.
For now try downloading this song normally and just try moving out manually.

Ok, thanks for letting me know.


Image in blog is 404, resolving against extension vs. original domain

I'm not sure if this is the right repo for bugs in Mercury Reader, so let me know if there is a better repo for it.

Platform: macOS 10.14.6
Mercury Parser Version: <IP_ADDRESS>
Node Version (if a Node bug):
Browser Version (if a browser bug): Chrome Version 79.0.3945.79 (Official Build) (64-bit)

Expected Behavior
Images using paths /from/the/root should work when shown using the Mercury Reader.  For example, on https://blog.humphd.org/open-source-fall-2019/, there is  an <img src="/content/images/2019/12/telescope-gource.png"> element, which displays correctly in normal view.
Current Behavior
Using Mercury Reader, the same image is a 404.  The path has been resolved relative to the extension, and becomes chrome-extension://oknpjjbmpnndlpmnhmekjpocelpnlfdi/content/images/2019/12/telescope-gource.png, which can't be found.
Steps to Reproduce

Go to https://blog.humphd.org/open-source-fall-2019/
Scroll down to notice that there is an image in the post
Enable Mercury Reader on the page
Notice that the image has been broken, and a 404 appears in the console.
In the dev tools, inspect the broken <img> and hover the src value, which is now shown as chrome-extension://oknpjjbmpnndlpmnhmekjpocelpnlfdi/content/images/2019/12/telescope-gource.png

Here is a screenshot, with the page loaded normally on the left, in Mercury Reader o the right:

Possible Solution
I don't know how the Reader code works, but it appears that the relative URL is being made absolute, and resolved relative to the extension's domain vs. the blog's.

Can confirm, also having this issue.
@humphd's proposed solution seems to work.
I started to write a TamperMonkey script to work around this, but cross-site scripting protections make it rather annoying. If someone puts in the time to do it, I'd love to know about it.
What are the chances we'll get a real fix, after 2 years of this issue being open with no reply? Is this extension just dead?


[WIP] [POC] Config based aliases

TODO;

rethink suppressing inside Context -> move and unify with rules report?
MultiRule does actually double suppresion check
remove aliases from issues
refactor SuppressionSpec
include into docs (generator)

Perhaps we should make this also visible in detekt's documentation.

Wow, yeah maybe. Could be hard.
Well if the standard procedere is to override the alias defaults, it would just be a property we can identify by the generator. Will add this to the todo list.

The question is: ship this with RC10 to have it battle tested :D ?


Buildtools signing

@dmex
Wondering when this PR could be merged.
It contains fix for SourceLink (among other things), that would be nice to have working.
Maybe you can merge at least that fix? So that future PDBs will contain proper SourceLink information.

@dmex Wondering when this PR could be merged.
It contains fix for SourceLink (among other things), that would be nice to have working. Maybe you can merge at least that fix? So that future PDBs will contain proper SourceLink information.

In this this branch needs more testing? If we want the SourceLink works we should just pull that forward on its own.

If we want the SourceLink work we should just pull that forward on its own.

That would be really cool.
I have created fix some time ago (#2203), but it was closed because this PR contains the fix as well.


Fix hashcode for ParameterDB

This fixes #3340 : many parameters have the same hashcode, meaning scripts that rely on hashCode e.g. HashSet<Parameter> params will not work as intended.

To the best of my knowledge, neither a List or HashSet of Variable is used in a way that would change as a result of this e.g. using .contains

I don't think this PR change can be accepted since your use case is not supported (i.e., mixing params from multiple functions into a set) and changes would break other uses of isEquivalent needed for Version Tracking, Merge, etc...

Would it work if we moved the code into .equals instead? It feels unintuitive that Parameters are not distinguished by their function, but if it is too deeply entrenched to change, I am fine with closing this P/R (working around it by wrapping the parameter in some other class)

I don't think this PR change can be accepted since your use case is not supported (i.e., mixing params from multiple functions into a set) and changes would break other uses of isEquivalent needed for Version Tracking, Merge, etc...

Would it work if we moved the code into .equals instead? It feels unintuitive that Parameters are not distinguished by their function, but if it is too deeply entrenched to change, I am fine with closing this P/R (working around it by wrapping the parameter in some other class)

No, since this would potentially interefere with its use during merge where elements pulled from two functions (different programs) are known to be the same but are not the same instance - they only have the same language.  Function equality is based upon object instance identity (only one instance of a function).  Parameter and Variable objects from different functions were never intended to be mixed with others in a single collection.  If you could explain your reason for doing this it may help justify more consideration.  You may want to consider using the corresponding Symbol instead of these variable objects which does support your use case.


Allow users to use Active Support 7.0 (4.x)

cf. #2462

Why code change is needed
require active_support/allshould be used instead ofrequire 'active_support/notifications'` to avoid errors in case of use of activesupport 7.0.
Signed-off-by: Takuya Noguchi<EMAIL_ADDRESS>

Failure on ruby-3 is not relevant to the changes but to coverall's legacy HTTPS client configurations. cc @tdreyno
We should backport 5f32d3a901684528a30ed23554cacfe1803eefdb to this branch 4.x.

CI / ubuntu-ruby-3 (pull_request) job fails only due to #2557. Once it is merged, I will update this change.

CI / ubuntu-ruby-3 (pull_request) job fails only due to #2557. Once it is merged, I will update this change.


KeyError: "No object named 'JitterCrop' found in 'transforms' registry!"

Env:

OS version：CentOS 7
Environment version:   Python 3.6.13 / PyTorch 1.8.0 / CUDA 11.0 / cuDNN version
cvpods version：commit id : 82374a1fe5c83e16bdd4d07adae2545d51138ef8_

I ran the following command：

cd playground/detection/coco/yolof/yolof.cspdarknet53.DC5.3x
pods_train --num-gpus 8

Actual results：

Traceback (most recent call last):
  File "/ssd/serser/cvpods/tools/train_net.py", line 109, in <module>
    args=(args,),
  File "/ssd/serser/cvpods/cvpods/engine/launch.py", line 53, in launch
    daemon=False,
  File "/ssd/serser/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 230, in spawn
    return start_processes(fn, args, nprocs, join, daemon, start_method='spawn')
  File "/ssd/serser/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 188, in start_processes
    while not context.join():
  File "/ssd/serser/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 150, in join
    raise ProcessRaisedException(msg, error_index, failed_process.pid)
torch.multiprocessing.spawn.ProcessRaisedException:

-- Process 0 terminated with the following error:
Traceback (most recent call last):
  File "/ssd/serser/venv/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 59, in _wrap
    fn(i, *args)
  File "/ssd/serser/cvpods/cvpods/engine/launch.py", line 88, in _distributed_worker
    main_func(*args)
  File "/ssd/serser/cvpods/tools/train_net.py", line 74, in main
    runner = runner_decrator(RUNNERS.get(cfg.TRAINER.NAME))(cfg, build_model)
  File "/ssd/serser/cvpods/cvpods/engine/runner.py", line 86, in __init__
    self.data_loader = self.build_train_loader(cfg)
  File "/ssd/serser/cvpods/cvpods/engine/runner.py", line 307, in build_train_loader
    return build_train_loader(cfg)
  File "/ssd/serser/cvpods/cvpods/data/build.py", line 130, in build_train_loader
    transform_gens = build_transform_gens(cfg.INPUT.AUG.TRAIN_PIPELINES)
  File "/ssd/serser/cvpods/cvpods/data/build.py", line 69, in build_transform_gens
    return build(pipelines)
  File "/ssd/serser/cvpods/cvpods/data/build.py", line 58, in build
    tfm = TRANSFORMS.get(aug)(**args)
  File "/ssd/serser/cvpods/cvpods/utils/registry.py", line 66, in get
    "No object named '{}' found in '{}' registry!".format(name, self._name)
KeyError: "No object named 'JitterCrop' found in 'transforms' registry!"

Turns out I am using official cvpods instead of yolof/cvpods.


update deprecated apis and dependencies

uses browser.connect(wsendpoint, {}) instead of the old deprecated API
Updated dependencies to the latest version to prepare the update for PW sooner.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-02-23T19:56:58.802+0000

Duration: 8 min 45 sec

Test stats :test_tube:

Test
Results

Failed
1

Passed
142

Skipped
3

Total
146

Test errors
Expand to view the tests failures
Test / json reporter formats network fields in ECS format – json reporter formats network fields in ECS format

Expand to view the error details
 null

Expand to view the stacktrace
 Error: expect(received).toMatchSnapshot()

Snapshot name: `json reporter formats network fields in ECS format 1`

- Snapshot  - 1
+ Received  + 1

@@ -31,11 +31,11 @@
          "from_prefetch_cache": false,
          "from_service_worker": false,
          "headers": Object {},
          "mime_type": "text/html",
          "protocol": "h2",
-         "remote_i_p_address": "[2606:4700:3035::ac43:83e0]",
+         "remote_ip_address": "[2606:4700:3035::ac43:83e0]",
          "remote_port": 443,
          "response_time":<PHONE_NUMBER>476.922,
          "security_details": Object {
            "certificate_id": 0,
            "certificate_transparency_compliance": "unknown",
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/__tests__/reporters/json.test.ts:201:36)
    at Promise.then.completed (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/utils.js:391:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/utils.js:316:10)
    at _callCircusTest (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/run.js:218:40)
    at _runTest (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/run.js:155:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/run.js:66:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/run.js:60:9)
    at run (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-463/src/github.com/elastic/synthetics/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:170:21)

Steps errors
Expand to view the steps failures

Runs the tests

Took 1 min 9 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Unable to submit API on IOS mobile

Hi,
Love the plugin, thank you!
I am having trouble loading API on mobile IOS after reinstall.. have been using successfully prior to this issue for a couple of weeks, also works on mac no problem.
Setup Todoist API Token just keeps popping up. Entered there, tried settings... no luck.
Can you help please?
Thanks again!

Forget this thank you!
I reinstalled everything a few times and it is all good now...

Glad it all worked out for you!


Add ErrorResponseMessage helper

Right now it's a little cumbersome to create error messages as you need know the rpc version, error code, etc.
Having a helper method to create these would be good.

This is taken care of by allowing ResponseMessage to be the return time for methods


Emergency publishing docs improvements

Part of improvements during a emergency publishing drill: https://trello.com/c/ktLcZLIN

Updated the PR to remove changes relating to the cache clearing attempted in https://github.com/alphagov/govuk-puppet/pull/7328.


Question about metro and monorepo

Describe the bug
I feel this is not related to the library but I am having a problem using it in my repository as well, I want metro to work with pnpm but when I import react-native-monorepo-tools all the time I get a package.json not found in path error.
I am currently using rush as my monorepo manager and these are my files:
metro.config.json:
const exclusionList = require('metro-config/src/defaults/exclusionList');
const {
  getMetroTools,
  getMetroAndroidAssetsResolutionFix,
} = require('react-native-monorepo-tools');

const monorepoMetroTools = getMetroTools();

const androidAssetsResolutionFix = getMetroAndroidAssetsResolutionFix();

module.exports = {
  transformer: {
    // Apply the Android assets resolution fix to the public path...
    publicPath: androidAssetsResolutionFix.publicPath,
    getTransformOptions: async () => ({
    transform: {
    experimentalImportSupport: false,
    inlineRequires: false,
  },
  }),
  },
  server: {
    // ...and to the server middleware.
    enhanceMiddleware: (middleware) => {
    return androidAssetsResolutionFix.applyMiddleware(middleware);
    },
  },
  // Add additional Yarn workspace package roots to the module map.
 // This allows importing importing from all the project's packages.  watchFolders: monorepoMetroTools.watchFolders,
  resolver: {
    // Ensure we resolve nohoist libraries from this directory.
    blockList: exclusionList(monorepoMetroTools.blockList),
    extraNodeModules: monorepoMetroTools.extraNodeModules,
  },
};

package.json:
{
  "name": "@mlopez/mobile",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "android": "react-native run-android",
    "ios": "react-native run-ios",
    "lint": "eslint .",
    "start": "react-native start",
    "test": "jest"
  },
  "dependencies": {
    "@mlopez/ui": "workspace:*",
    "react": "18.2.0",
    "react-native": "0.71.7",
    "styled-components": "5.3.10",
    "find-root": "1.1.0"
  },
  "devDependencies": {
    "@babel/core": "^7.20.0",
    "@babel/preset-env": "^7.20.0",
    "@babel/runtime": "^7.20.0",
    "@react-native-community/eslint-config": "^3.2.0",
    "@react-native-community/cli-platform-ios": "11.2.0",
    "@rnx-kit/metro-config": "1.3.6",
    "@tsconfig/react-native": "^2.0.2",
    "@types/jest": "^29.2.1",
    "@types/react": "^18.0.24",
    "@types/react-test-renderer": "^18.0.0",
    "@types/styled-components-react-native": "5.2.1",
    "@rnx-kit/metro-resolver-symlinks": "0.1.28",
    "babel-jest": "^29.2.1",
    "eslint": "^8.19.0",
    "jest": "^29.2.1",
    "metro-react-native-babel-preset": "0.73.9",
    "prettier": "^2.4.1",
    "react-test-renderer": "18.2.0",
    "@rnx-kit/babel-preset-metro-react-native": "1.1.4",
    "typescript": "4.8.4",
    "react-native-monorepo-tools": "1.2.1"
  },
  "jest": {
    "preset": "react-native"
  }
}

error:
yarn run v1.22.19
$ react-native start --reset-cache
error package.json not found in path.
Error: package.json not found in path
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:19:11)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at findRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/find-root@1.1.0/node_modules/find-root/index.js:28:10)
    at getMonorepoRoot (/Users/mlopezr-local/Codes/scrm-mono-test/common/temp/node_modules/.pnpm/react-native-monorepo-tools@1.2.1/node_modules/react-native-monorepo-tools/src/get-monorepo-root.js:13:16)
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this  #command.

have you ever had the same error?
if thereis some problem with this issue please delete, 0 problems

the problem its because rush does not have package json, i will change to turborepo.


Add PositionalIndex and EmptyIndex types and align indexes API

Motivation: removing types.None as representation of default pd.RangeIndex
created when index=None is used in DF and Series ctors, that requires
most of Series and DF implementations to branch basing on index types.
Instead all Series and DF functions should use common indexes API
aligned to pandas one.
Changed in this PR:

types.None index is removed;
Added EmptyIndexType (instead types.None index) to represent empty
pandas index with dtype='Object' i.e. pd.Index([]);
Added PositionalIndexType as a replacement for types.None index for
non-empty DFs and Series;
Changed unboxing of RangeIndex objects to either RangeIndexType of
PositionalIndexType depending on whether it's default range or not;
Changed fix_df_index and dataframe_constructor.py to create
EmptyIndexType or other index depending on whether tuple of columns is empty;
Moved implementations for index types from common and
numpy_like functions to specific index files;
Updated operators and other Series methods implementations to avoid
branching on index types and used index objects API instead;
Reorganized index tests and added tests verifying specific function
(e.g. series reindexing) for all types of indexes.

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sdc/datatypes/common_functions.py:

Line 91:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

In the file sdc/datatypes/hpat_pandas_dataframe_functions.py:

Line 2164:121: E501 line too long (134 > 120 characters)

In the file sdc/datatypes/hpat_pandas_series_functions.py:

Line 427:33: E127 continuation line over-indented for visual indent
Line 619:32: E128 continuation line under-indented for visual indent
Line 1907:17: E722 do not use bare 'except'
Line 1908:25: E261 at least two spaces before inline comment
Line 1910:121: E501 line too long (122 > 120 characters)
Line 2165:73: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 2172:73: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 2232:5: E306 expected 1 blank line before a nested definition, found 0
Line 4554:38: E128 continuation line under-indented for visual indent
Line 4558:40: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 4672:38: E128 continuation line under-indented for visual indent
Line 4676:40: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/datatypes/indexes/positional_index_type.py:

Line 37:1: E302 expected 2 blank lines, found 1

In the file sdc/extensions/indexes/empty_index_ext.py:

Line 62:17: E117 over-indented

In the file sdc/extensions/indexes/indexes_generic.py:

Line 122:5: E306 expected 1 blank line before a nested definition, found 0
Line 171:11: E127 continuation line over-indented for visual indent
Line 190:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/extensions/indexes/int64_index_ext.py:

Line 460:5: E303 too many blank lines (2)
Line 488:5: E306 expected 1 blank line before a nested definition, found 0
Line 489:53: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 514:5: E306 expected 1 blank line before a nested definition, found 0
Line 519:34: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 553:5: E306 expected 1 blank line before a nested definition, found 0
Line 555:29: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/extensions/indexes/positional_index_ext.py:

Line 61:5: E306 expected 1 blank line before a nested definition, found 0
Line 143:5: E306 expected 1 blank line before a nested definition, found 0
Line 163:1: E302 expected 2 blank lines, found 1
Line 174:1: E302 expected 2 blank lines, found 1
Line 216:5: E306 expected 1 blank line before a nested definition, found 0
Line 317:1: E303 too many blank lines (5)
Line 369:5: E303 too many blank lines (2)
Line 469:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/extensions/indexes/range_index_ext.py:

Line 542:5: E303 too many blank lines (2)
Line 615:5: E306 expected 1 blank line before a nested definition, found 0
Line 616:29: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/functions/numpy_like.py:

Line 1280:1: E303 too many blank lines (3)
Line 1307:25: E741 ambiguous variable name 'l'
Line 1326:25: E741 ambiguous variable name 'l'
Line 1337:25: E741 ambiguous variable name 'l'

In the file sdc/rewrites/dataframe_constructor.py:

Line 259:121: E501 line too long (132 > 120 characters)

In the file sdc/sdc_autogenerated.py:

Line 83:9: E306 expected 1 blank line before a nested definition, found 0
Line 86:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 222:9: E306 expected 1 blank line before a nested definition, found 0
Line 225:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 361:9: E306 expected 1 blank line before a nested definition, found 0
Line 364:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 500:9: E306 expected 1 blank line before a nested definition, found 0
Line 503:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 639:9: E306 expected 1 blank line before a nested definition, found 0
Line 642:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 778:9: E306 expected 1 blank line before a nested definition, found 0
Line 781:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 917:9: E306 expected 1 blank line before a nested definition, found 0
Line 920:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1056:9: E306 expected 1 blank line before a nested definition, found 0
Line 1059:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1185:34: E128 continuation line under-indented for visual indent
Line 1186:9: E306 expected 1 blank line before a nested definition, found 0
Line 1313:34: E128 continuation line under-indented for visual indent
Line 1314:9: E306 expected 1 blank line before a nested definition, found 0
Line 1441:34: E128 continuation line under-indented for visual indent
Line 1442:9: E306 expected 1 blank line before a nested definition, found 0
Line 1569:34: E128 continuation line under-indented for visual indent
Line 1570:9: E306 expected 1 blank line before a nested definition, found 0
Line 1697:34: E128 continuation line under-indented for visual indent
Line 1698:9: E306 expected 1 blank line before a nested definition, found 0
Line 1825:34: E128 continuation line under-indented for visual indent
Line 1826:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/sdc_function_templates.py:

Line 83:9: E306 expected 1 blank line before a nested definition, found 0
Line 86:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 210:34: E128 continuation line under-indented for visual indent
Line 211:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/tests/indexes/index_datagens.py:

Line 55:30: E231 missing whitespace after ','
Line 55:43: E231 missing whitespace after ','
Line 55:49: E231 missing whitespace after ','

In the file sdc/tests/indexes/test_indexes.py:

Line 277:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/tests/indexes/test_int64_index.py:

Line 459:19: E221 multiple spaces before operator
Line 483:27: E221 multiple spaces before operator
Line 550:13: E125 continuation line with same indent as next logical line
Line 570:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/indexes/test_positional_index.py:

Line 483:19: E221 multiple spaces before operator
Line 506:27: E221 multiple spaces before operator
Line 544:13: E125 continuation line with same indent as next logical line
Line 564:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/indexes/test_range_index.py:

Line 593:19: E221 multiple spaces before operator
Line 615:27: E221 multiple spaces before operator
Line 653:13: E125 continuation line with same indent as next logical line
Line 673:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/test_series.py:

Line 4838:5: E125 continuation line with same indent as next logical line

Hello @kozlov-alexey! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sdc/datatypes/common_functions.py:

Line 91:37: E712 comparison to False should be 'if cond is False:' or 'if not cond:'

In the file sdc/datatypes/hpat_pandas_dataframe_functions.py:

Line 2164:121: E501 line too long (134 > 120 characters)

In the file sdc/datatypes/hpat_pandas_series_functions.py:

Line 427:33: E127 continuation line over-indented for visual indent
Line 619:32: E128 continuation line under-indented for visual indent
Line 1907:17: E722 do not use bare 'except'
Line 1908:25: E261 at least two spaces before inline comment
Line 1910:121: E501 line too long (122 > 120 characters)
Line 2165:73: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 2172:73: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 2232:5: E306 expected 1 blank line before a nested definition, found 0
Line 4554:38: E128 continuation line under-indented for visual indent
Line 4558:40: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 4672:38: E128 continuation line under-indented for visual indent
Line 4676:40: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/datatypes/indexes/positional_index_type.py:

Line 37:1: E302 expected 2 blank lines, found 1

In the file sdc/extensions/indexes/empty_index_ext.py:

Line 62:17: E117 over-indented

In the file sdc/extensions/indexes/indexes_generic.py:

Line 122:5: E306 expected 1 blank line before a nested definition, found 0
Line 171:11: E127 continuation line over-indented for visual indent
Line 190:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/extensions/indexes/int64_index_ext.py:

Line 460:5: E303 too many blank lines (2)
Line 488:5: E306 expected 1 blank line before a nested definition, found 0
Line 489:53: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 514:5: E306 expected 1 blank line before a nested definition, found 0
Line 519:34: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 553:5: E306 expected 1 blank line before a nested definition, found 0
Line 555:29: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/extensions/indexes/positional_index_ext.py:

Line 61:5: E306 expected 1 blank line before a nested definition, found 0
Line 143:5: E306 expected 1 blank line before a nested definition, found 0
Line 163:1: E302 expected 2 blank lines, found 1
Line 174:1: E302 expected 2 blank lines, found 1
Line 216:5: E306 expected 1 blank line before a nested definition, found 0
Line 317:1: E303 too many blank lines (5)
Line 369:5: E303 too many blank lines (2)
Line 469:33: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/extensions/indexes/range_index_ext.py:

Line 542:5: E303 too many blank lines (2)
Line 615:5: E306 expected 1 blank line before a nested definition, found 0
Line 616:29: E712 comparison to True should be 'if cond is True:' or 'if cond:'

In the file sdc/functions/numpy_like.py:

Line 1280:1: E303 too many blank lines (3)
Line 1307:25: E741 ambiguous variable name 'l'
Line 1326:25: E741 ambiguous variable name 'l'
Line 1337:25: E741 ambiguous variable name 'l'

In the file sdc/rewrites/dataframe_constructor.py:

Line 259:121: E501 line too long (132 > 120 characters)

In the file sdc/sdc_autogenerated.py:

Line 83:9: E306 expected 1 blank line before a nested definition, found 0
Line 86:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 222:9: E306 expected 1 blank line before a nested definition, found 0
Line 225:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 361:9: E306 expected 1 blank line before a nested definition, found 0
Line 364:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 500:9: E306 expected 1 blank line before a nested definition, found 0
Line 503:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 639:9: E306 expected 1 blank line before a nested definition, found 0
Line 642:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 778:9: E306 expected 1 blank line before a nested definition, found 0
Line 781:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 917:9: E306 expected 1 blank line before a nested definition, found 0
Line 920:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1056:9: E306 expected 1 blank line before a nested definition, found 0
Line 1059:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 1185:34: E128 continuation line under-indented for visual indent
Line 1186:9: E306 expected 1 blank line before a nested definition, found 0
Line 1313:34: E128 continuation line under-indented for visual indent
Line 1314:9: E306 expected 1 blank line before a nested definition, found 0
Line 1441:34: E128 continuation line under-indented for visual indent
Line 1442:9: E306 expected 1 blank line before a nested definition, found 0
Line 1569:34: E128 continuation line under-indented for visual indent
Line 1570:9: E306 expected 1 blank line before a nested definition, found 0
Line 1697:34: E128 continuation line under-indented for visual indent
Line 1698:9: E306 expected 1 blank line before a nested definition, found 0
Line 1825:34: E128 continuation line under-indented for visual indent
Line 1826:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/sdc_function_templates.py:

Line 83:9: E306 expected 1 blank line before a nested definition, found 0
Line 86:34: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 210:34: E128 continuation line under-indented for visual indent
Line 211:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/tests/indexes/index_datagens.py:

Line 55:30: E231 missing whitespace after ','
Line 55:43: E231 missing whitespace after ','
Line 55:49: E231 missing whitespace after ','

In the file sdc/tests/indexes/test_indexes.py:

Line 277:9: E306 expected 1 blank line before a nested definition, found 0

In the file sdc/tests/indexes/test_int64_index.py:

Line 459:19: E221 multiple spaces before operator
Line 483:27: E221 multiple spaces before operator
Line 550:13: E125 continuation line with same indent as next logical line
Line 570:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/indexes/test_positional_index.py:

Line 483:19: E221 multiple spaces before operator
Line 506:27: E221 multiple spaces before operator
Line 544:13: E125 continuation line with same indent as next logical line
Line 564:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/indexes/test_range_index.py:

Line 593:19: E221 multiple spaces before operator
Line 615:27: E221 multiple spaces before operator
Line 653:13: E125 continuation line with same indent as next logical line
Line 673:13: E125 continuation line with same indent as next logical line

In the file sdc/tests/test_series.py:

Line 4838:5: E125 continuation line with same indent as next logical line

@AlexanderKalistratov Can you please approve so we can finally merge this?


Drain timeout

Attempt at https://github.com/weaveworks/kured/issues/78

@sylr Thanks for your patch. From a first glance, it looks very reasonable.
It's going to be a while before I can actually test this.
Would you be able to post some manifests that produce Pods with a PDB that reproduces the case this behavior addresses?
k8s-conformance has an Ubuntu based Vagrantfile for creating k8s clusters that we may use as a repro environent: https://github.com/stealthybox/k8s-conformance/blob/c6fa9ca602bdd7b3a26b3568e9e7471d46146016/v1.16/kubeadm/README.md
If some other users are willing to vouch for this change or post a demo with a asciinema, I'm happy to merge this.

I have a little bit different take on a drain timeout -- I actually have a use-case where I want to force a reboot to occur if a drain does not succeed within a certain amount of time. Might be something where --drain-timeout combines with something like --force to abort drain and continue with reboot after a certain duration?

kubectl drain has two options, grace-period and timeout.  See:
https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#drain
According to this:
https://github.com/weaveworks/kured/blob/master/cmd/kured/main.go#L235
kured is not passing those arguments, so the defaults are to use the pod grace periods (which might be unreasonably high) and 0 timeout, which is an infinite wait.
I think it'd be less confusing to have --drain-timeout and --drain-grace-period flags refer to their equivalent kubectl drain arguments and passed into newCommand().  A new flag such as --drain-hanging-timeout could be used by this code to address any edge cases where kubectl's own internal timeout logic goes wrong.

Just a quick PSA from me:

we're hanging out in #kured on Slack
we're planning a contributors meeting soon: here's the link to the doodle to find a good time - be sure to pick your timezone before submitting (preliminary agenda)

We'd love to see you there.

This change could cause data loss in the environment I work in - we have some pods that can take 40 minutes to shut down. Please make it so the behaviour is the same as before, unless you specify the option.

My change wouldn't cause data loss. If the timeout is hit, kured would just stop waiting, uncordon the node and move to another one.

@sylr apologies, the conversation thread did cover forcing a reboot but your PR does not as you say.
Why does it call os.Exit()?  I don't get what that is supposed to achieve since Kubernetes will just restart it.

We recently put in https://github.com/weaveworks/kured/commit/1ba3acab98fa217ea65405640706c55c89be956d so it should be easier to implement now?

Hi,
any news about this PR? I would really like to have this parameter! :)
thanks

@flbla If you're interested by this PR, can you update it? That would be lovely, as @sylr didn't update it recently.
Thank you in advance.

@evrardjp : I did it some months ago : https://github.com/weaveworks/kured/pull/283#issuecomment-798820238

Ok let's close this one here then, my bad!


Wiki has a minor typo

I tried to create a PR, but I don't have access permissions to the wiki repo

Hello @jsantos42 thanks a lot fixing this typo. I do have the write access to the Wiki reserved for only collaborators of the project.
I've invited you to be a collaborator so you can finally contribute to this OpenSource Project!
Cheers

Hey @pulgamecanica! Thank you!
I just pushed it to the jsantos-fix-wiki-typo branch, though it does not appear in the select-branch dropdown (PR section)
It seems adding a PR for wiki is not possible

You can edit the Wiki directly I believe

Dude....🙈 I'll go back to my cave now and ease my shame!
done, thanks!


merge changes from dev (ulmfit variable name-related)

Hello @bact! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file pythainlp/tokenize/__init__.py:

Line 97:80: E501 line too long (99 > 79 characters)

In the file pythainlp/tokenize/newmm.py:

Line 96:80: E501 line too long (107 > 79 characters)

In the file pythainlp/ulmfit/__init__.py:

Line 8:24: E231 missing whitespace after ','
Line 93:1: E302 expected 2 blank lines, found 1
Line 93:27: E231 missing whitespace after ':'
Line 94:50: W291 trailing whitespace
Line 100:24: E225 missing whitespace around operator
Line 100:40: W291 trailing whitespace
Line 101:22: E225 missing whitespace around operator
Line 102:27: E225 missing whitespace around operator
Line 102:56: E225 missing whitespace around operator
Line 103:28: E231 missing whitespace after ','
Line 103:43: E231 missing whitespace after ','
Line 104:22: E225 missing whitespace around operator
Line 107:22: E225 missing whitespace around operator
Line 126:23: E231 missing whitespace after ':'
Line 140:23: E231 missing whitespace after ':'
Line 161:80: E501 line too long (83 > 79 characters)

In the file tests/__init__.py:

Line 370:80: E501 line too long (83 > 79 characters)

Coverage decreased (-0.7%) to 86.632% when pulling 86f07ea83c14ad3b6c640655dd7964bed1de30fb on dev into 8dbd79a21b4aded01d9e7d629ad32d84ebfe338f on master.

This merge request should be closed as it went too huge. Will merge with other PRs.


ImGui mouse and keyboard capture support

I've made a small modification to Canvas::Impl and the associated CMakeLists to support ImGui mouse and keyboard capture. This allows the GUI to keep these events from propagating down to other mouse and keyboard listeners.
In effect, whenever the user selects and drags elements in an ImGui window, other controls that have registered listeners with Canvas will no longer be called. I found this to be an intuitive behavior and thought it might be a quick and useful change.
Alternatively, this behavior can be toggled with some other Canvas setting if that's preferred pretty easily.
Support for this is conditionally compiled into Canvas depending on the presence of ImGui (to be consistent with the previous optional nature of ImGui support in threepp).

I've found that linking optional libraries based on availbility leads to issues downstream, so dev branch have been updated to not link with json and curl if found. This PR would go back on that effort, unfortunantly.
The issue lies in the fact that on linux e.g., where the optional libraries might have been installed with a system manager earlier, threepp will link to it. The user then builds the library and CMake will fail not finding the an optional library becouse a find_package is missing (that is now required).

That's fair. There's often some inconsistent behavior depending on build pipeline and platform. If find_package fails to find imgui, the behavior wouldn't be present, but it might be counter-intuitive if imgui is indeed present just not discovered via that call.
An alternative I tinkered with in order to get mouse/keyboard capture was overriding the glfw mouse callback that Canvas::Impl registers. However the most straightforward approach would seem to require exposing the collection of registered listeners so that the application using threepp can inject the capture without losing those convenient implementations. That would also break the pimpl idiom which is so painstakingly maintained in the codebase which I felt I should avoid doing at all costs.
A third and even less desirable alternative is for me in my code to create my own derived OrbitControls that allows me to write a custom glfw mouse callback without going through Canvas.
Do you have any suggestions for a another approach I can pursue to get this functionality? My application uses a number of ImGui windows with threepp and having the events propagate to the Canvas listeners makes for a somewhat confusing control experience.

Do you have any suggestions for another approach I can pursue to get this functionality?

What I've done some far with some of the examples is:
// in imgui context
mouseHover = ImGui::IsWindowHovered();
// in render loop
controls.enabled = !ui.mouseHover;

If find_package fails to find imgui, the behavior wouldn't be present, but it might be counter-intuitive if imgui is indeed present just not discovered via that call.

I think my explanation was off. The current issue (present on main) is that `target_link_libraries( PUBLIC threepp::threepp) will fail if the system has nlohmann_json or curl installed on a system level, becouse threepp would have linked with it during build, but the current project would likely not have.
I do, however, agree that the beviour you are presenting is a wanted one. I.e. the example I made will fail if with a drop down menu, as it goes out of the "window" boundary.

Something, something:
struct IOContext {
  bool& preventMouseEvent;
  bool& preventScrollEvent;
  bool& preventKeboardEvent;
}

//

```cpp
 static void mouse_callback(GLFWwindow* w, int button, int action, int mods) {

    if (io && io->preventMouseEvent) {

        return;
    }

  auto p = static_cast<Canvas::Impl*>(glfwGetWindowUserPointer(w));

  auto listeners = p->mouseListeners;

  // ...
    }

I think I see where you're going with this. What would you think about replacing those bool& in your snippet with callbacks that the user can supply? It would still allow ImGuiIO::WantCaptureMouse and ImGui::WantCaptureKeyboard to be checked directly each time an event is processed, but would remove the requirement that Canvas.hpp include imgui.h or any associated signatures? It would also generalize the capture for other future libraries that also want to adjust how input events are handled.

I pushed a change that I think is more agreeable. It removes imgui from Canvas entirely (and from the CMakeLists) and allows for user-supplied callback functions to determine when to block listeners in Canvas from receiving events.
In my projects code, I just have something like this to make all imgui windows and elements capture keyboard, mouse, and scroll events (I treat mouse and scroll events as the same category in my code but left them distinct in threepp):
std::function<bool(void)> mouse_capture_callback = []() -> bool {
  ImGuiIO& io = ImGui::GetIO();
  return io.WantCaptureMouse;
};

std::function<bool(void)> keyboard_capture_callback = []() -> bool {
  ImGuiIO& io = ImGui::GetIO();
  return io.WantCaptureKeyboard;
};

// ...

canvas.registerMouseCapture(&mouse_capture_callback);
canvas.registerScrollCapture(&mouse_capture_callback);
canvas.registerKeyboardCapture(&keyboard_capture_callback);

This does exactly what I want in terms of event behavior. What do you think?

I think I prefer the following:
IOCapture capture {};
capture.preventMouseEvent = [] {
    return ImGui::GetIO().WantCaptureMouse;
};
canvas.registerIOCapture(&capture);

How do you think?
I'll push a commit to this PR if you agree.

Have you gotten a chance to test out the event behavior?

Seems to work as expected.


DOC: note of how chunks can be defined

Some tiny overlap with https://github.com/pydata/xarray/pull/6542.
I feel this minor changes helps it easy to navigate to other parts of the docs.
Some motivation behind the PR here: https://github.com/pydata/xarray/discussions/6697
Note: i've forgotten the syntax for how to create a link to https://xarray.pydata.org/en/stable/generated/xarray.Dataset.chunk.html

Thanks @raybellwaves ! Even without the link, this is good!


fix: use proper path with go get

Hi! cool project thanks for providing us with this code.
I was trying to go get https://github.com/lostdusty/gobalt
but I got this error:

Apparently golang can just skip the url scheme and go get github.com/lostdusty/gobalt works just fine so please consider changing it!
This PR fixes that.

Thank you!


0.0 and -0.0 identical in dart2js and not identical in cfe

The following code works in CFE but fails in dart2js and dartdevk
import "../../../Utils/expect.dart";

double pnil = 0.0;
double nnil = -0.0;

main() {
  Expect.isFalse(identical(pnil, nnil));
}

I'm not sure which behavior is correct but in any way all of the tools must behave in a same way
SDK version 2.9.0-13.0.dev

Many of these number inconsistencies is by design, so other than tests trying to cover the number behavior explicitly, we should not rely on it for any tests that is expected to behave the same on all tools.
For context, Dart on the web and elsewhere purposely have different number semantics. This is a result of a tradeoff we made between consistency and performance: to perform reasonably well, we must use the underlying JavaScript numbers when compiling to JavaScript. To make this work well, the CFE is configurable to track two kinds of number semantics. When used out of the box or within the VM it uses the Dart number semantics. On an compiler that targets JavaScript (ddc and dart2js) it uses JS number semantics when evaluating constants as well. You also get static errors if you write number literals that cannot be represented with the JavaScript semantics (for instance, a 64-bit number that is not possible to encode with JS's 53-bit representation).
Some common differences are identical(0.0, 0.0), also identical(1.0, 1), (3.0).runtimeType == "int".

Closing as intended, here is a longer article with more details: https://dart.dev/guides/language/numbers


Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': The RTCPeerConnection's signalingState is 'closed'.

Describe the bug
I have this issue that I cannot reproduce at all, but get a lot of errors in sentry for. Could you please take a look and point in a direction to how to fix it. Here's the log I can extract from sentry.
Reproduction
N/A
Logs
[
  {
    "level": "warning",
    "data": {
      "arguments": [
        "websocket closed",
        {
          "code": 1006,
          "identity": "<user_id>",
          "reason": "",
          "room": "room_b",
          "roomSid": "room_sid_b",
          "state": 1,
          "wasClean": false
        }
      ]
    }
  },
  {
    "level": "warning",
    "data": {
      "arguments": [
        "signal disconnected",
        {
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  },
  {
    "level": "info",
    "data": {
      "arguments": [
        "resuming signal connection, attempt 0",
        {
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  },
  {
    "level": "info",
    "data": {
      "arguments": [
        "Resuming signal connection",
        {
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  },
  {
    "level": "error",
    "data": {
      "arguments": [
        "Failed to execute 'setConfiguration' on 'RTCPeerConnection': The RTCPeerConnection's signalingState is 'closed'.",
        {
          "error": "[DOMException]",
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  },
  {
    "level": "warning",
    "data": {
      "arguments": [
        "reconnect disconnected",
        {
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  },
  {
    "level": "error",
    "data": {
      "arguments": [
        "unable to set offer",
        {
          "fields": "[Object]",
          "identity": "<user_id>",
          "room": "room_b",
          "roomSid": "room_sid_b"
        }
      ]
    }
  }
]

### System Info

```shell
Browser: any, but mostly Chrome
OS: Windows / MacOS

Severity
annoyance
Additional Information
No response

thanks for the report!
which SDK version is this? Did it start popping up after a specific upgrade?
It looks like the PeerConnection went into a closed state without that triggering a reconnect (which it should).
On a signal resume the SDK then tries to update the PeerConnection's config, but that fails as it is already closed.
Any logs that happen before the one's you shared might be helpful here as well

Thanks for the insight, that means that the clients to perform a reconnect then after hitting that error?

Yeah, you're totally right. This code path failing should not be treated as a SignalReconnectError and instead force a full reconnect. Thanks for digging into this!

were you able to test the changes in the latest release?

could you provide the exact error and stack trace of an error that was present in the version released yesterday (v2.0.5) ?

Thanks! How do the client logs continue after the setRemoteDescriptionError? Just trying to make sure that the reconnect logic behaves as expected now.

@HermanBilous I'll close this issue for now. We haven't heard any similar reports. If you're still seeing this issue with the latest client+server versions feel free to let me know and I'll reopen it.


live.nicovideo.jp does not work

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
United States
Description
Supposedly the program works on nicovideo.jp, but apparently not on live.nicovideo.jp. While the livestream is a member's only thing, the first few minutes are viewable without an account. I do have an account if that's needed for testing though. I want to be able to download the live stream, so I'm open to workarounds as well.
Verbose log
[debug] Command-line config: ['-vU', 'https://live.nicovideo.jp/watch/lv335845784']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.02.04 [c1653e9ef]
[debug] Python version 3.10.2 (CPython 64bit) - Linux-5.16.8-zen1-1-zen-x86_64-with-glibc2.33
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1, rtmpdump 2.4
[debug] Optional libraries: Cryptodome, secretstorage, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2022.02.04, Current version: 2022.02.04
yt-dlp is up to date (2022.02.04)
[debug] [generic] Extracting URL: https://live.nicovideo.jp/watch/lv335845784
[generic] lv335845784: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] lv335845784: Downloading webpage
[generic] lv335845784: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://live.nicovideo.jp/watch/lv335845784
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1381, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1451, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 612, in extract
    ie_result = self._real_extract(url)
  File "/usr/lib/python3.10/site-packages/yt_dlp/extractor/generic.py", line 3986, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://live.nicovideo.jp/watch/lv335845784

Related: #367

#367 was completed and it seems to work now


Config the Pipeline using a config file

Currently the pipeline is configured through the command line. Woth an increasing number of steps and settings, this has become quite complex. A better alternative would be a configuration file containing the Steps to execute and their respective settings. This file would then be read and the pipeline would be co structed accordingly. This way we would also have a "single source of truth" config that is guaranteed to work, during demos.

This would also enable us to check if a config is valid before executing the pipeline, by checking the required and added columns of each step.


Add model_selection to sklearnex module content

Description
model_selection was missing in sklearnex module content list (while available for import anyway). It resulted in invisibility of sklearnex.model_selection.train_test_split from inspect tool travelling through sklearnex module content.

/intelci: run

Llinux Python 3.9/3.10 failures are related to dpctl update (0.15.0 -> 0.15.1)


OpenAPI Spec - Representing Minute values as integers instead of floating point numbers.

Hello,
In the Amber Spec document, you have two types that appear to represent Minutes:

duration
resolution

Both are defined as closed enums with values such as 5, 15, 30 etc.
Minor side-note, 'duration' explicitly states in the description fields that it is minutes, but 'resolution' does not.
All duration and resolution fields are defined as 'number' (floating point) enums. Would it make more sense to change these to 'integer' enums?
Per https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.0.md, OpenAPI 3.0.0 supports the 'integer' type.
In the Amber Spec, the existing specified values for these types are already integers, so it shouldn't break them.
Most statically typed languages provide much better support for integer enums than floating point enums, if they support floating point enums at all.
Opinion?
Thanks,
Carl.

Sounds reasonable. I'll have a look

I've made the requested changes and added a copy of the swagger.json file to this repo, so you can test before I publish to the main repo. This will also allow PRs.
https://github.com/amberelectric/public-api/blob/main/swagger.json

In line with this issue.

Should TariffInformation.block (min 1, max 2) be an integer? (currently a number)
Same question for Interval.renewables which appears to be a percentage. More than reasonable to keep it this way, if you ever return a floating point number here.
Same with Renewable.renewables.

Interval.renewables and Renewable.renewables could also be combined into a Type, say RenewablesPercentage.


release for position change

Hey-- you merged my PR a little while ago but i think it needs a github release before it'll show up in APM. Would you mind, when you have a sec?

Oh, sorry about that, it slipped my mind. Patch has just been published!

Thanks!


Add a logo!

Because how can we have survived for that long without one?! Oh, right, we're a system daemon. Anyway, who cares. Looks is all that matters these days.

OK, but I wonder if we can not use SVG effects to make it color-breath like most gaming mice should do?

Where'd we use the logo? In the README and the Wiki? I'm missing those bits from this PR. I do like the logo, don't get me wrong :)

OK, but I wonder if we can not use SVG effects to make it color-breath like most gaming mice should do?

Or we can color breathe the rats in different colors for extra discobombulation (pun intended).

Where'd we use the logo? In the README and the Wiki?

wait, we're not getting tshirts made?

While trying to add the color effects (because we can), I realized that the rats are not properly sent to their layer. Fix coming in.

wait, we're not getting tshirts made?

Do maintainers get one for free? :D

OK, done with the animation: https://github.com/bentiss/libratbag/tree/wip/logo
and the result: https://github.com/bentiss/libratbag/blob/wip/logo/data/logo.svg

too bad, I can't make github markdown show the animations when embedding the logo on the README.
But it seems that we can do it when the image is on github.io. So I added a new commit that adds this logo on the dbus api doc, and then we can pick this one from there :)
I'll open a new PR, might be just easier.


Issue with Query Strings and BackLink()

When adding documents, if using translatable or another module with a query string, the "Done!" button appends the rest of the URL after the query string, breaking the link.
The problem looks to be in the BackLink() function at line 164 of DMSDocumentAddController.php
Modifying it to something like the following, fixes the issue.
public function Backlink(){
$pageID = $this->currentPageID();
$link = singleton('CMSPagesController')->Link();
$link_array = explode('?',$link);
if ( sizeof($link_array) > 1 ) {
$link = $link_array[0].'edit/show/'.$pageID.'?'.$link_array[1];
}else{
$link = $link.'edit/show/'.$pageID;
}
return $link;
}

also see https://github.com/silverstripe-labs/silverstripe-dms/issues/19

can be closed.


clodius aggregate: NameError: global name '_bigwig' is not defined

On ubuntu xenial with a fresh python 2.7.12 install, I get the following:
root@609c5b8e4115:/$ clodius aggregate bigwig HistonH3_cre_trt_rep1.bw
/usr/local/lib/python2.7/dist-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
Traceback (most recent call last):
  File "/usr/local/bin/clodius", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/clodius/cli/aggregate.py", line 1347, in bigwig
    _bigwig(
NameError: global name '_bigwig' is not defined

I have the same issue. I even tried to use the docker in case it was some OS- or python-related issue, but I get the same error. Any ideas?

It worked for me when running it in the higlass container (which has it installed).

Thanks for the suggestion, but I got the same error. Perhaps we are using different versions of higlass.

That worked, thanks! Still, I hope they address this issue, as it seems it's being carried over to recent versions of Higlass as well...

Btw, there's no need to aggregate bigwigs anymore. HiGlass can ingest them natively now (--filetype bigwig --datatype vector).

That's great news! Very nice feature, thanks!

Hi,
I had the same problem and I tried to upload directly bigwig files, however the coordinates were all shifted from chromosome two on (I am using mm9 mouse build).
The way I generate the bigwig file is the following:
I have a Grange object containing coordinates and score. I sort the grange object based on seqlevel so that chr2 is immediately after chr1. I export the grange to bigwig using export from rtracklayer
Do you have any idea on how I can solve the shift problem?
Thanks
Zhan

There's a chromosome ordering bug at the moment related to non-primary scaffolds (random and Un contigs). If that's the problem, a workaround for now is to omit the non-primary scaffolds from your bigwig. The second option is to export bedGraph and use clodius.
@pkerpedjiev Looks like clodius's bigwig option was removed in a655ff6 but the command wasn't deprecated.


Feature idea(s): Sorting project lists and/or starring projects

Hi!
A way of sorting projects (to starred) one might be good. Anyway I gitlist, I have to scroll down, to the project I like to work with.
Best regards
Gino

Maybe you can add this to #673? ;)

In general, GitList ist just a repository viewer and doesn't change information (which would be required, if users could star the repositories). However I think this may be related to #380 or a plugin as described in #739?

@alehaa I see an option where the starred data is stored as separate meta data in the plugin. As long as that can be achieved no change in the repo is needed.


virtual hard discs

[Enter feedback here]
On this page is the mention of "virtual hard discs" but it should actually be "virtual hard disks"

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 54f35593-3d7b-a56d-0fba-593eb9b3032d
Version Independent ID: b1e5fe22-ef19-b992-0fea-7e6848c37845
Content: Azure VM Image Builder overview - Azure Virtual Machines
Content Source: articles/virtual-machines/image-builder-overview.md
Service: virtual-machines
Sub-service: image-builder
GitHub Login: @sumit-kalra
Microsoft Alias: sukalra

@IanMoroney
Thanks for your feedback! We will investigate and update as appropriate.

@IanMoroney
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


Colab errors when running EasyEdit_Example_ROME_llama.ipynb

The notebook settings for EasyEdit_Example_ROME_llama.ipynb cause Colab to report that Unrecognized runtime "easyedit"; defaulting to "python3".
This appears to cause a number of errors (that mostly seem to stem from the wrong Python version getting selected as the default), such as ModuleNotFoundError: No module named 'distutils.cmd' (presumably because it tries to run the default system install of Python 3.9).

Thank you for your attention.

Colab has poor compatibility with the latest versions of torch, python, transformer, so the tutorial may not work properly on colab.
My recommendation is that you run this tutorial using a jupyter notebook locally. Sry for the inconvenience


Monokai: should use same semantic theme style for library symbols

Refs: https://github.com/microsoft/vscode/issues/93802
Open a typescript file, select the monokai theme, have the following code snippet
const t = Math.random();
const p = Number.MAX_SAFE_INTEGER;
setTimeout(() => console.log('hello'));
setInterval(() => console.log('llalal'));
this._actionBar.push(new Action('diffreview.close', nls.localize('label.close', "Close"), 'close-diff-review codicon-close', true, () => {
			this.hide();
			return Promise.resolve(null);
		}), { label: false, icon: true });

Notice how Math Number and Promise are not colored the same. At least Math and Number should be exactly the same imho.
I see how one got the textmate support.class and another support.const. But from a user standpoint I find this weird.

This has to do with that Math is just a variable while Number and Promise are classes.

Then I guess this is expected behavior. I just found it surprising.

Now we could define that support.variable gets the same color as as support.class, but there might be other variables in the default library where this might not be what users expect.
Alyternativky I can make a special rule for Math

I would wait if more users find this a problem, if that's ok for you.

Of course, let's wait for feedback. Thanks


cmd/cue: recursive import incorrectly imports strings with colons

What version of CUE are you using (cue version)?

$ cue version
0.4.3-1

Does this issue reproduce with the latest stable release?
Yes.
What did you do?

Given the yaml:
abc: "please see more info at: https://example.com/"

❯ cue import -R test.yaml

What did you expect to see?
abc: "please see more info at: https://example.com/"

What did you see instead?
import yaml656e63 "encoding/yaml"

abc: yaml656e63.Marshal(_cue_abc)
let _cue_abc = {
	"please see more info at": "https://example.com/"
}

This seems expected, based on reading the help string
-R, --recursive                recursively parse string values

I see this a lot when importing Kubernetes manifests. CRDs usually have something like:
description: "NodeSelector is a selector which must be true for the pod to fit on a node. Selector which must match a node's labels for the pod to be scheduled on that node. More info: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/"

Admittedly, it clearly is valid given yq seems happy enough to parse it and even convert to json.
❯ cat a.yaml | yq
? NodeSelector is a selector which must be true for the pod to fit on a node. Selector which must match a node's labels for the pod to be scheduled on that node. More info
: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
❯ cat a.yaml | yq -j
Flag --tojson has been deprecated, please use -o=json instead
{
  "NodeSelector is a selector which must be true for the pod to fit on a node. Selector which must match a node's labels for the pod to be scheduled on that node. More info": "https://kubernetes.io/docs/concepts/configuration/assign-pod-node/"
}

That said, it is pretty weird. I find the recursive flag useful for importing config maps and the like. Not sure what the right thing to do here is.

Yeah, the real world is messy, and it's hard to build a one-size fits all solution. My hunch is that allowing users to provide configuration to provide more granular control would be the most scalable option.
#ImportConfig: { ... } // match cli flags, and more

config: [pattern=string]: #ImportConfig

Users could then apply import configuration to a specific file, glob, or regex. It would also be helpful to support pattern matching at the value level, so we can say "apply this rule if the value matches this pattern". You'd also have to account for rule precedence and ordering...

Wow, that is unlucky. Thank you for sharing the fix! Is there a release for cue planned soon?

v0.5.0 will be released today, along with v0.6.0-alpha.1


networking.wireless nixos module name leads to confusion

Describe the bug
networking.wireless makes it sound like you need it enabled for wifi, this is not the case and most wifi users probably want networking.networkmanager instead.
I propose we rename this option set to networking.wpa_supplicant (while providing an alias for backwards) compat, and change all the documentation to reflect the new naming.
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: networking.wireless networking.networkmanager

cc @jtojnar @flokli @symphorien @worldofpeace @peterhoeg @dtzWill

I think I can speak for the maybe 15 people I've encountered that had no idea what software networking.wireless was. If it were a custom nixos interface working with everything wireless in existence, maybe it could be so abstract. But you can clearly identify here it's just wpa_supplicant, and I've also thought it should just be named as such.  Especially if you're switching to NixOS.

I propose we rename this option set to networking.wpa_supplicant

The problem is we already have networking.supplicant, to complicate things further. See https://github.com/NixOS/nixpkgs/issues/22401
In my opinion we should really rewrite the whole module to be backend independent, though it's a lot of work.

We spoke about that during the NixOS networkd meetup aswell (notes still pending to be uploaded to discourse), but yes, this is really unintuitive, and should be moved to services.(wpa_)supplicant .

I think a good first start would be to rename this to services.wpa_supplicant (and not yet be backend independent). Any takers?


dapr-cli: 1.13.0 -> 1.14.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/dapr/cli/releases.
meta.description for dapr-cli is: CLI for managing Dapr, the distributed application runtime
meta.homepage for dapr-cli is: https://dapr.io
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.14.0 with grep in /nix/store/lj5xb6i6m0nk9xisvcf5jmnf4fxf67nm-dapr-cli-1.14.0
found 1.14.0 in filename of file in /nix/store/lj5xb6i6m0nk9xisvcf5jmnf4fxf67nm-dapr-cli-1.14.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

dapr-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lj5xb6i6m0nk9xisvcf5jmnf4fxf67nm-dapr-cli-1.14.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dapr-cli https://github.com/r-ryantm/nixpkgs/archive/33251dcf5b17a25317c291a751f10161461a88bc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/33251dcf5b17a25317c291a751f10161461a88bc#dapr-cli

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lj5xb6i6m0nk9xisvcf5jmnf4fxf67nm-dapr-cli-1.14.0
ls -la /nix/store/lj5xb6i6m0nk9xisvcf5jmnf4fxf67nm-dapr-cli-1.14.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dapr-cli

Maintainer pings
cc @JoshVanL @lucperkins for testing.

Add a :+1: reaction to pull requests you find important.

LGTM, please merge :face_holding_back_tears:


Add EcoAssistant to the research page

Why are these changes needed?
Add EcoAssistant to the research page
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report

Merging #612 (b1725e2) into main (5dfbbbd) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   34.04%   33.81%   -0.24%
==========================================
  Files          25       25
  Lines        3005     3005
  Branches      668      668
==========================================
- Hits         1023     1016       -7
- Misses       1906     1912       +6
- Partials       76       77       +1

Flag
Coverage Δ

unittests
33.81% <ø> (-0.17%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


How to Build templates for Django Applications with HTMX

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.
Pre-submission checks
Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes
This closes #6936

Plagiarism check complete. Please remember to check your article for typos and formatting issues.

@mohamedgh16 I'm done with the corrections

@mohamedgh16 I have made the changes

Noted: just going through the queue in order - we will get to this one asap.!

Jumping on this one


fix: speed up listDocuments pagination

A page size of 2**32 - 1 is rejected by the backend, making it to use the default page size of 20, which increases the latency of the listDocuments call.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #1342 🦕

No idea what to do about code coverage, as nothing really changed there, only an extra comment line was added.

No idea what to do about code coverage, as nothing really changed there, only an extra comment line was added.

Don't worry about the coverage check. I will take a look at the PR today.

Hi!
Now I'm writing scripts for delete Firestore data.
and I had stack for memory leak.
Because listDocuments() makes 100000 of array data.
I found this issues.
Is it possible to pagination listDocuments()?

@wimpykid719 Are you able to use "Firestore.recursiveDelete()", which deletes documents in smaller batches? If that is not possible, you can use the Query API and combine it with limits or startAt().

Yeah, I want to do that but It's so deep path and I'm stacking the middle of path.
/collection/document/collection/document/collection/document/collection/documents(The id is like this<PHONE_NUMBER>4547 this is almost random)/collection/documents(random ID)/field
I'm trying to get documents id using listDocuments() for making delete path, but this documents return to so many array that makes memory leak.
and I think can't use Query API and limits(), startAt() because that documents doesn't have field.
Do you have any ideas? Please🙇🏻♂

You can also use https://github.com/googleapis/nodejs-firestore/blob/main/dev/src/v1/firestore_client.ts#L1343 directly, which lets you control the output size.


SetImmediate/Swipe async nav broken in Chrome 47.0.2526.76, Android 5.0.0

Severe (> 2 sec) delays executing postMessage handler from setImmediate for handleSwipe/navigationAction after the Chrome 47 update on Mobile.
Strangeness: It only shows up when swiping, never with click.
When this "seems" to happen onclick, it is because it is not click, but gestureshowpress.
Notes:
Swipe uses setTimeout 0 to defer an end task.
That end task executes the navigation, which calls setImmediate (which calls postMessage).
So postMessage is being called from a setTimeout (macroTask) callback.
Clicks run setImmediate (which call postMessage) from the click handler, which should also be a macroTask callback.
Update: substituting raf for setTimeout in swipe has no effect.
Update: substituting browserify-timers poly for YuzuJS setImmediate has no effect.
In this case, the delay is between process.nextTick install timer and timer being fired (so no postMessage).
So the latest Updates show that this has nothing to do with the methodology of getting to the task queue, or micro/macro tasking. The bottom line is that swipe's touchevent handlers run (touchstart, touchmove, touchend), and then (sometimes) there is a huge delay.
Important to note, during the delay, the browser is doing absolutely nothing on any thread, according to the devtools timeline.
Investigate/Choose/Decide.

This seems unrelated, but it fixed this issue, so hear it out:

Noticed the es6-promise polyfill still polyfills over native promises if you do this:
require('es6-promise').polyfill();

That wasn't the intention of this code so added a quick check around this.
Correcting this actually eliminated this problem (by NOT running the es6-promise polyfill).
Still early testing, but that looks to have done it.
Still not sure the exact mechanics of the failure - However, the symptom is clear: Really Long Delays With No Processing.

Originally it looked like the es6 promise poly was the cause. The problem returned.
Anytime the JS updates, there is a small reprieve in the symptom, but it eventually returns.
Typical cumulative memory problems occur after a while. The long delay can occur as soon as the second swipe.

The root cause for this issue was lack of event cancellation (preventDefault) in touchstart in the swipe component.
Google recommends canceling all touch events that you handle, so this has been updated and fixed. swipe-js-iso was forked to a version that cancels events, which precipitated some additional updates.

Canceling touchstart is bad news. Not a good road.
A reasonable swipe implementation relies on waiting until touchmove to make guesture determinations, allowing the browser to handle those that aren't of swipe interest.
CrBug 570430 opened to address this.

Update: Merge Approved for Chrome 48

Chrome 48 reached standard (old) mobile stable today. Updated deps, redeployed, and tested OK.


fiona/ end trading platform and trade-type pages url with a slash

Changes:

end trade card pages with a slash

...

Type of change

[ ] Bug fix
[ ] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

Nice work fiona!...just to add on there are a lot of other pages that also has links to these paths. We should change all of them too to end with a slash. You can easily do global search for "/margin" or "/dbot" to know all the places that needs to be changed ya 👌


pull request for e2e test at 02/06/2017 18:15:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

I added the MIT License.


Bolt Action | FE | Refactor Bolt Action components

Jira

http://vjira2:8080/browse/BDS-1869
http://vjira2:8080/browse/BDS-799

Summary
Refactor Bolt Action components to better leverage what's available in the base class and clean up some component code.
Details

Move bolt-button-reset() mixin out of the Button component into tools where it can be used by other components like Link and Trigger.
In BoltAction, remove unused html import and unnecessary this.useShadow assignment, check for super.rendered before calling it.
Set delegateFocus to true by default in BoltAction and remove delegateFocus from components.
Reference props directly on BoltAction class rather than duplicating them.
Simplify innerSlots code in Link, Chip, and Button components. We want to move away from the switch statement pattern for slots which is less readable than simply returning the template in one chunk.
Rework Button slotted content so that empty spans with is-empty class are not output.

How to test

Review the code changes.
Review the Link, Button, Chip, and Trigger components in Chrome, IE, and Edge for regressions.

This has introduced double focus outlines for buttons, we need to remove the browser default outline.

Good catch @mikemai2awesome. Now fixed. Ready for re-review.

@danielamorse could you take a peek at the failing Travis tests with this when you have a sec?

@danielamorse could you take a peek at the failing Travis tests with this when you have a sec?

Fixed 👍

PR was released with v2.11.0


Side-by-side Events not drawing as intended

Julien:
really nice library. I am having an issue where events that are side-by-side do an odd overlap.

Image 1 - the event on the left overlaps with the one on the right. If I scroll from right-to-left, I can see that the appointment on the right creeps over to the next column (Image 2)

Image 3 - If I rotate the device, it redraws, but there seems to be a space between the 2 events

Image 4 - If I rotate back to portrait, the cells align properly

If I scroll the events vertically out of view, and then scroll them back in, they end up drawing like in 'Image 1' again.

Any ideas why this would be happening? Nothing in your code is immediately obvious. Also, I have an iPhone demo running. I could give it to you and you can tweak it to your liking.
Many thanks

Ezat

@ezathashim did you find a solution or was it an error in your code?

It appears to be something in my code, specifically my EventView subclass. My subclass uses autolayout of subviews which seems to be doing something bad.


Swift 3 Migration from Darwin: Coder+Archival

Brings NSCoder and NSKeyed{A,Una}rchiver API to match with Swift 3 darwin.

Actually, let me rebase this branch one more time.  I don't want this based off my very messy master.


Code metadata - vcs

I've seen VCS as one of the fields we want to collect. Is this still the case? I've noticed it's not in our schema file.

Yes we want it.
I see it here - https://canada-ca.github.io/ore-ero/en/open-source-code-schema.html


Question: Will WinUI Desktop fully support UWP's Badge Notifications API?

UWP has a nice Badge Notifications API which adds a badge to an app's tile in the Start Menu and to the app's taskbar button:

(Example UWP app showing taskbar app button badge.)
Using the same API in a MSIX packaged desktop app adds the badge to the app's tile in the Start Menu, but there is no additional badge in the app's taskbar button. Will WinUI Desktop apps using UWPs Badge API be able to show a badge in the taskbar just like UWP apps?

@marb2000 as FYI

Hey Felix, thanks for asking this. We're investigating and will get back to you!

Hey Felix,
For Win32 apps using MSIX, we disabled the UWP badges from appearing on taskbar, since Win32 apps can use ITaskbarList to create custom taskbar "badges".
I'm aware this is definitely confusing though, and might not be what you'd expect!
Have you tried the ITaskbarList API? Are you still interested in instead using the UWP badges? We appreciate your feedback and it helps us prioritize what to work on next!

Hi @andrewleader
thanks for getting back to me this quickly :)
Yes, I'm aware of ITaskbarList API and WPF also makes creating an own taskbar badge quite easy with the TaskbarItemInfo API. Two points why I would still welcome the team to add full UWP Badge support to non-UWP projects:

With UWP, I just have to call the API and it works. I don't have think about creating an own icon overlay (the badge), draw a number aligned with the overlay (the badge content) and then how to apply it to the base icon in the taskbar. In UWP, all I have to do is specify I want to draw a number and then pass the number to the API. The system will take care of the rest for me. (For Win32, instead of drawning a number onto my custom badge, I could alternatively provide a set of images and then specify which one to use as the overlay.)
Windows UI needs to be aligned as best as best as possible across the different native app frameworks. Adding UWP Badge support to Win32/WPF apps enables these apps to provide a native Windows 10 UI and goes one step further into unifying the app experience. We've seen work done for this in the Windows Shell by adding native Windows 10 toast notification support to Win32 apps. It would be great if this would be extended to the Badge API of the Shell as well!

WinUI Desktop is about enabling Win32 apps to ship with the modern Windows 10 UI/UX. Thus, Win32 apps should have full access to the new Windows 10 Shell elements introduced by UWP to help in unifiying the app experience across the different Windows App models (Win32 and UWP).
The icing on the cake would be if you guys would also enable current Desktop Bridge apps (MSIX packaged apps) to provide a native Windows 10 Shell experience to their users. I'd be fine with this support only arriving for WinUI Desktop apps though as I can imagine your team being quite busy with the upcoming launch of Windows 10X.
If enabled for current MSIX packaged desktop apps, developers should be able to either use the existing ITaskbarList API (or equivalent in WPF) to create custom badges if needed, or use the UWP Badge API to create a familiar Badge experience for Windows 10 users.

Thanks Felix, that's excellent feedback! Really well articulated. We'll let you know if/when we have any updates.

@andrewleader
I tested out an MSIX packaged desktop app on the new Windows 10X emulator to see how badge suport is currently looking like and I'm happy to report that badges show up in both the taskbar and and the new Start menu!

and a closer look:

(TestAppWpf.... is the name of my Win32 app packaged as an MSIX)
I will use full badge support in the 10X shell as another argument why it would be nice to have the same level of support for our MSIX desktop apps/WinUI Desktop apps on Windows 10 😁

@marb2000 @andrewleader This seems like a fitting issue for Project Reunion (extended to all Windows apps - UWP and Win32).


upper: log 'detected a container change' message to ms.CombinedLog

Problem
When one:

deploys a change to a tilt resource via live_update
triggers a crash in that resource

One observes:

"Detected a container change for docs-site. We could be running stale code. Rebuilding and deploying a new image." is logged in the "all resources" log
The same message is not logged in the resource-specific (e.g., fortune) log, so that log just shows builds happening without reason

Solution
Also log the "detected a container change" message to the resource-specific log.
(There's probably some logging api cleanup we should do here, like having a clear hierarchy of logs (all -> resource-specific -> resource+build-specific), and writing to a lower log also writes to its ancestors, or something)

agreed that eventually we need some better log primitives


Pipeline Test to ensure Library/Tool nupkg are consumable

We hit an issue where we could pass all our tests and successfully build a nupkg that no one could use.  We should add a test to each of our projects in the build that checks that the result objects are consumable as nupkgs.
Tools you can test with dotnet tool install https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-tool-install
Libraries you can test with dotnet add https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-add-package

@daalcant create separate issues in each product repo if you want to track separately.


Add BatchExportCommand

HR managers can export the database into a csv file, update BatchExportCommandParser and Parser class accordingly, fixes #129

LGTM


Integrate relayer spike into relayer crate

Description
This PR is based on #210 (and supersedes it) and integrate the relayer spike into the relayer crate.
For now, only minimal changes have been made to the original code, just what was needed to depend on the actual tendermint and ibc types + clippy lints.
Additionally, a new v0 command has been added, which contains the code of the spike's main function.
Also, the relayer-spike README has been moved to the docs/architecture folder.

For contributor use:

[ ] Unit tests written
[ ] Added test to CI if applicable
[ ] Updated CHANGELOG_PENDING.md
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #335 into master will increase coverage by 22.8%.
The diff coverage is 64.8%.

@@            Coverage Diff            @@
##           master    #335      +/-   ##
=========================================
+ Coverage    13.6%   36.5%   +22.8%
=========================================
  Files          69     127      +58
  Lines        3752    8168    +4416
  Branches     1374    2827    +1453
=========================================
+ Hits          513    2986    +2473
- Misses       2618    5009    +2391
+ Partials      621     173     -448

Impacted Files
Coverage Δ

modules/src/events.rs
0.0% <0.0%> (ø)

modules/src/ics02_client/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/raw.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/error.rs
15.0% <0.0%> (-18.4%)
:arrow_down:

modules/src/ics04_channel/error.rs
75.0% <ø> (+50.0%)
:arrow_up:

modules/src/ics04_channel/packet.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/client_def.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/error.rs
75.0% <ø> (+75.0%)
:arrow_up:

modules/src/ics18_relayer/error.rs
0.0% <0.0%> (ø)

modules/src/ics26_routing/error.rs
75.0% <0.0%> (ø)

... and 233 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2495af7...9f3ce6b. Read the comment docs.


Assign contents write permission for workflow

This permission is required for keepalive-workflow to create a commit but it is not assigned by default.

Details

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#configuring-the-default-github_token-permissions
https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-contents
https://docs.github.com/en/rest/git/commits?apiVersion=2022-11-28#create-a-commit

Thank you for the fix!


Config cleanup

Remove more stuff from config that is no longer used.
Causes the following changes:

Decimal defaults in JSON Schema are not strings
named tuples in JSON schema are now lists, ref #2711

selected reviewer: @dmontagu

please review.


Update issue templates

👷 Deploy Preview for glittery-malasada-cf6fe1 processing.

Name
Link

🔨 Latest commit
ae81a3a035a383d00be7eb5ce1a21a2f227519f1

🔍 Latest deploy log
https://app.netlify.com/sites/glittery-malasada-cf6fe1/deploys/635caf4d5bc1cf00088e076b