python36Packages.foolscap: 0.12.6 -> 0.13.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-foolscap/versions.
meta.description for python36Packages.foolscap is: '"Foolscap, an RPC protocol for Python that follows the distributed object-capability model"'.

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/.flappclient-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flappclient had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/.flappserver-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flappserver had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/.flogtool-wrapped had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flogtool had a zero exit code or showed the expected version
0 of 6 passed binary check by having a zero exit code.
0 of 6 passed binary check by having the new version present in output.
found 0.13.1 with grep in /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1
directory tree listing: https://gist.github.com/9b832f08cf0bee66af0c4457fd3b7fa1
du listing: https://gist.github.com/cae7837bc98f6a7e0c53b1993e26abb5

Outpath report (click to expand)

Outpath difference report
11 total rebuild paths
3 package rebuilds
3 x86_64-linux rebuilds
3 i686-linux rebuilds
2 x86_64-darwin rebuilds
3 aarch64-linux rebuilds
First ten rebuilds by attrpath
python27Packages.foolscap
python36Packages.foolscap
tahoe-lafs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python36Packages.foolscap https://github.com/r-ryantm/nixpkgs/archive/fbc43fa719dd374887e0c263e4ce111347ff9c4e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1
ls -la /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin

Success on x86_64-linux (full log)
Attempted: python36Packages.foolscap
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/lib  /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1
checking for references to /build in /nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1...
wrapping `/nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flappclient'...
wrapping `/nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flogtool'...
wrapping `/nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1/bin/flappserver'...
running install tests
/nix/store/l61sxld598fsqc2mr9caj8y1zdplpgin-python3.6-foolscap-0.13.1

Success on aarch64-linux (full log)
Attempted: python36Packages.foolscap
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1/lib  /nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1
checking for references to /build in /nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1...
wrapping `/nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1/bin/flogtool'...
wrapping `/nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1/bin/flappserver'...
wrapping `/nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1/bin/flappclient'...
running install tests
/nix/store/qd99jpfqh88y1950cliw3y31hg5iq9hz-python3.6-foolscap-0.13.1

Success on x86_64-darwin (full log)
Attempted: python36Packages.foolscap
Partial log (click to expand)
Successfully installed foolscap-0.13.1
/private/tmp/nix-build-python3.6-foolscap-0.13.1.drv-0/foolscap-0.13.1
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1/lib  /nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1
wrapping `/nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1/bin/flappclient'...
wrapping `/nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1/bin/flappserver'...
wrapping `/nix/store/klpj2dghljxi0qfq285v33rss2nzy59r-python3.6-foolscap-0.13.1/bin/flogtool'...
running install tests

@GrahamcOfBorg build python27Packages.foolscap

Success on aarch64-linux (full log)
Attempted: python27Packages.foolscap
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1/lib  /nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1
checking for references to /build in /nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1...
wrapping `/nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1/bin/flogtool'...
wrapping `/nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1/bin/flappclient'...
wrapping `/nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1/bin/flappserver'...
running install tests
/nix/store/hpl6k7q59m79qqys3wa1x4d08rrqb353-python2.7-foolscap-0.13.1

Success on x86_64-darwin (full log)
Attempted: python27Packages.foolscap
Partial log (click to expand)
/private/tmp/nix-build-python2.7-foolscap-0.13.1.drv-0/foolscap-0.13.1
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1/lib  /nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1
wrapping `/nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1/bin/flappclient'...
wrapping `/nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1/bin/flappserver'...
wrapping `/nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1/bin/flogtool'...
running install tests
/nix/store/xjchg8xfyyrjgiaydjdlp8dp17j8w6aa-python2.7-foolscap-0.13.1

Success on x86_64-linux (full log)
Attempted: python27Packages.foolscap
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1/lib  /nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1/bin
patching script interpreter paths in /nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1
checking for references to /build in /nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1...
wrapping `/nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1/bin/flappserver'...
wrapping `/nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1/bin/flogtool'...
wrapping `/nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1/bin/flappclient'...
running install tests
/nix/store/mwp97l9d1xvm2b583hm4yxa430kzhs3b-python2.7-foolscap-0.13.1

@GrahamcOfBorg build tahoe-lafs

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: tahoe-lafs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: tahoe-lafs
Partial log (click to expand)
===============================================================================
[SUCCESS!?!]
Reason: 'fails on certain linux flavors: see ticket #2834'

allmydata.test.test_magic_folder.MockTest.test_move_tree
-------------------------------------------------------------------------------
Ran 1241 tests in 276.315s

PASSED (skips=10, expectedFailures=4, unexpectedSuccesses=1, successes=1226)
/nix/store/ydq31b2wfjdf3dr3mx7n4raf7h6y0zy3-tahoe-lafs-1.12.1

Success on aarch64-linux (full log)
Attempted: tahoe-lafs
Partial log (click to expand)
===============================================================================
[SUCCESS!?!]
Reason: 'fails on certain linux flavors: see ticket #2834'

allmydata.test.test_magic_folder.MockTest.test_move_tree
-------------------------------------------------------------------------------
Ran 1241 tests in 530.262s

PASSED (skips=10, expectedFailures=4, unexpectedSuccesses=1, successes=1226)
/nix/store/1rzg0c6bkknvyglsg2v92pc6k5n958ic-tahoe-lafs-1.12.1


Evaluation of a multi-user approach

Maybe I'm alone with this point of view, but a multi-user system (with native authentication) would provide a huge benefit and a great advantage in relation to other, similar projects (like devfake/flox).
What do you think about it?

Not in scope at the moment, as it also depends on how the future backend will be implemented.
Ideally I'd like to have a GraphQL API and use apollo-client on the FE. This way we could also drop redux to make it easier for developers to pick up.


Seq2Seq can't save states

I have a seq2seq model built with keras. It seems to be fine when training, however, it can't save the states properly when doing model.save(filepath)
Here's how my model looks like:
enc_in = Input(shape=(None, self.total_characters), name='enc_in')
enc_lstm_1 = Bidirectional(CuDNNLSTM(units=128, return_sequences=True, return_state=True, name='enc_lstm_1'))
enc_lstm_2 = Bidirectional(CuDNNLSTM(units=64, return_sequences=False, return_state=True, name='enc_lstm_2'))
enc_out_1, forward_eh_1, forward_ec_1, back_eh_1, back_ec_1 = enc_lstm_1(enc_in)
enc_out_2, forward_eh_2, forward_ec_2, back_eh_2, back_ec_2 = enc_lstm_2(enc_out_1)

enc_states = [Concatenate()([forward_eh_1, back_eh_1]), Concatenate()([forward_ec_1, back_ec_1]),
              Concatenate()([forward_eh_2, back_eh_2]), Concatenate()([forward_ec_2, back_ec_2])]

dec_in = Input(shape=(None, self.total_characters), name='dec_in')

dec_lstm_1 = CuDNNLSTM(units=256, return_sequences=True, return_state=True, name='dec_lstm_1')
dec_lstm_2 = CuDNNLSTM(units=128, return_sequences=True, return_state=True, name='dec_lstm_2')

dec_out_1, _, _ = dec_lstm_1(dec_in, initial_state=enc_states[:2])
dec_out_2, _, _ = dec_lstm_2(dec_out_1, initial_state=enc_states[2:4])
dec_dense = Dense(units=self.total_characters, activation='softmax', name='dec_dense')
dec_out_f = dec_dense(dec_out_2)

model = Model([enc_in, dec_in], dec_out_f)
model.compile(loss='categorical_crossentropy', optimizer='rmsprop')
model.summary()

We can only help if you could give more details.

I get a warning saying can't save serialize states... But i guess that it is not an error. Is it common to see sth like that?

I am sorry about this. the model did work good. it is just a warning. Thanks anyways!


Unable to accept an invitation

I'm having trouble accepting invitations for a user. I'm seeing a number of these types of issues, so this may be a bigger problem -- or maybe just a configuration problem after upgrading? This is what I've found:
devise (4.3.0)
devise_invitable (1.7.2)

User.last.invite!. This creates a new user and sends the invitation email.
Invitation email generates a URL such as this http://localhost:3000/users/invitation/accept?invitation_token=4wUJqa-F_srkgSc_JwFc
a. At this point, the user record in the database has a hashed invitation_token like 6835debac082a389136449b5ddddd9ef166df06ab7c10a6d4940bf1515fc3e47
Visiting the accept_invitation_url prompts to set a password 🎉
Clicking submit renders the error Invitation token is invalid 😢
a. At this point, the user record in the database has an updated invitation_token field which matches the raw token of 4wUJqa-F_srkgSc_JwFc. WHAT!?!?!?

What's going on here?

Can you send a pull request with failing test?

I think I've sorted out what cause of the problem is here.
Within my application controller, I have a before_action which only fires for devise controllers. This method updates the timezone for the current resource. Why the invitation_token gets overwritten is because of an update call made within this action where the invitation_token has been set to the raw_invitation_token.
This boils down to setting the invitation_token as the raw value in a #edit and being accepted as an permitted attribute in the #update action's parameters.
The fault of this on me for updating a record on a GET when it has unpersisted changes, however, I wouldn't expect these values to be set by a GET either.
Closing.


[BugFix] Fix parquet array convert bug

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@mergify backport branch-2.2 branch-2.3


Log writter

Problem
The program might not be working well and it's really needed to be sure what's wrong. That's where the log files come in. So we have to implement a log file maker.
Solution
Obviosly, is to make the file writter, that will write down all the actions that were happening during the application work.
Alternative solution
I actually know none.
Additional context
Well, I guess it has to be implemented in a LogHandler class, so everything stick in the same place. (May need some more thinking)

#26 Feature made.


Docker Swarm, Upgrade from 18.03.1 to 18.06.1 - Ghost networks when removing stacks

Opened initially as https://github.com/docker/for-linux/issues/424 but think it's more approriate here
Expected behavior
Hello, I have a weird behaviour since upgrading from docker 18.3.1 to 18.6.1 and traefik 1.6.4 to 1.6.6 :
• I deploy docker stacks via a docker-compose.yml file which leads to creating a given network per stack and connecting traefik to this stacks (via docker service update --network-add <network> <traefik>) - so far it worked well
• when I deploy a new version of the stack, I remove traefik from the network (docker service update --network-rm <network> <traefik>) and destroy the stack (docker stack rm ...). It removed stack and network. I had to wait a little bit before network is really deleted but it work. Then, I could deploy a create a new version of the stack and add traefik back to the network
I do not update services as there are some dbs in the stack for which I may need to run migrations. The need to be run one only.
Actual behavior
When I redeploy the stack, I do:
if [ $($DOCKER_BIN stack ls --format "{{.Name}}" |grep ^${COMPOSE_PROJECT_NAME}$ |wc -l) -ne "0" ]; then
    $DOCKER_BIN service update --network-rm ${COMPOSE_PROJECT_NAME}_network traefik_traefik
    $DOCKER_BIN stack rm ${COMPOSE_PROJECT_NAME}
    sleep 20
    $DOCKER_BIN network prune --force
fi

$DOCKER_BIN stack deploy --compose-file docker-compose.yml --with-registry-auth ${COMPOSE_PROJECT_NAME}

if [[ ${TRAEFIK} == "docker" ]]; then
    $DOCKER_BIN service update --network-add ${COMPOSE_PROJECT_NAME}_network traefik_traefik
fi

but output is now:
...
Creating service <stack>_backoffice
failed to create service <stack>_backoffice: Error response from daemon: network <stack>_network not found

• But since the upgrade, the network is not well destroyed as traefik seems still in the network (via docker inspect network <network>)
I need to do docker stack rm traefik so that the ghost network vanish as expected and then redeploy traefik from scracth and reconnect it to other instances. Any idea on this ?
I’m trying to downgrade back to 1.6.4 to see if it’s more from docker side or traefik side... => results are the same with 1.6.4
I also noticed that for the stacks I deploy so far I did not set the overlay network as attachable - did not require it for the last 6 months - shoud I add it ? =>result is the same with attachable network.
Steps to reproduce the behavior

Having a swarm cluster
Having a docker-compose file with a given network
Deploy stack
Connect traefik to it
Remove traefik to it
Destroy stack
Network is still present

sudo docker network inspect <instance_network>
[
    {
        "Name": "<instance_network>",
        "Id": "11xjt1yz38o5vtw40qbzldorx",
        "Created": "2018-08-29T16:58:57.674468644+02:00",
        "Scope": "swarm",
        "Driver": "overlay",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": null,
            "Config": [
                {
                    "Subnet": "<IP_ADDRESS>/24",
                    "Gateway": "<IP_ADDRESS>"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
            "lb-<instance_network>": {
                "Name": "<instance_network>-endpoint",
                "EndpointID": "eda2b043adb5e211003258e553a0368d5a2f306245c7609793164a8bb3e5ebe7",
                "MacAddress": "02:42:0a:00:31:04",
                "IPv4Address": "<IP_ADDRESS>/24",
                "IPv6Address": ""
            }
        },
        "Options": {
            "com.docker.network.driver.overlay.vxlanid_list": "4123"
        },
        "Labels": {
            "com.docker.stack.namespace": "<instance>"
        },
        "Peers": [
            {
                "Name": "517efbb11671",
                "IP": "<IP_ADDRESS>"
            }
        ]
    }
]

Output of docker version:
Client:
 Version:           18.06.1-ce
 API version:       1.38
 Go version:        go1.10.3
 Git commit:        e68fc7a
 Built:             Tue Aug 21 17:24:56 2018
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.1-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       e68fc7a
  Built:            Tue Aug 21 17:23:21 2018
  OS/Arch:          linux/amd64
  Experimental:     false

Output of docker info:
Containers: 129
 Running: 123
 Paused: 0
 Stopped: 6
Images: 129
Server Version: 18.06.1-ce
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: active
 NodeID: xqm2e3fld2vem3xali1795ug1
 Is Manager: true
 ClusterID: 7pf90t57w3oog500hniyt9rgr
 Managers: 1
 Nodes: 4
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
  Force Rotate: 0
 Autolock Managers: false
 Root Rotation In Progress: false
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 468a545b9edcd5932818eb9de8e72413e616e86e
runc version: 69663f0bd4b60df09991c08812a60108003fa340
init version: fec3683
Security Options:
 apparmor
 seccomp
  Profile: default
Kernel Version: 4.4.0-134-generic
Operating System: Ubuntu 16.04.5 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 62.82GiB
Name: swarm1.*******.net
ID: SAAO:VFA7:YFS4:23ZK:TETY:LINA:ZOFO:URPG:5JYE:3SMU:YP4A:DZZV
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

WARNING: No swap limit support

4 VMswith each 8vCPU / 64 Go RAM

By externalising the network creation on cli side and having only an external network referenced in the docker-compose file, it works again as expected. I create the network only once, attach traefik to it and period.
Modified my deployment script as follow:
CHANGED - If stack exists - remove it
if [ $($DOCKER_BIN stack ls --format "{{.Name}}" |grep ^${COMPOSE_PROJECT_NAME}$ |wc -l) -ne "0" ]; then
# $DOCKER_BIN service update --network-rm ${COMPOSE_PROJECT_NAME}_network traefik_traefik
$DOCKER_BIN stack rm ${COMPOSE_PROJECT_NAME}
sleep 20
$DOCKER_BIN network prune --force
fi
ADDED - Create network
if [ $($DOCKER_BIN network ls --format "{{.Name}}" |grep ^${COMPOSE_PROJECT_NAME}_network$ |wc -l) -eq "0" ]; then
$DOCKER_BIN network create -d overlay --attachable ${COMPOSE_PROJECT_NAME}_network
fi
Run stack
$DOCKER_BIN stack deploy --compose-file docker-compose.yml --with-registry-auth ${COMPOSE_PROJECT_NAME}
if [[ ${TRAEFIK} == "docker" ]]; then
# ADDED Check if Traefik is already in the network or not
network=$DOCKER_BIN network ls --no-trunc |grep ${COMPOSE_PROJECT_NAME} |awk '{print $1}' |wc -l
if [[ $network -ne "0" ]]; then
# Network exists, if Traefik is not already added in the network, add it - do nothing otherwise
if [ $($DOCKER_BIN service inspect traefik_traefik --format="{{json .Spec.TaskTemplate.Networks}}" | grep $DOCKER_BIN network ls --no-trunc |grep ${COMPOSE_PROJECT_NAME}_network |awk '{print $1}' |wc -l) -eq "0" ]; then
$DOCKER_BIN service update --network-add ${COMPOSE_PROJECT_NAME}_network traefik_traefik
fi
fi
fi

Seems close to https://github.com/docker/swarmkit/issues/2637 but I do not create two ingress networks. I only have one and create only overlay networks.

But the issue remains as I can't remove the network at the end : it only fix the ability to redeploy my stack on a given network by making it permanent. If I try to delete it after removing traefik, it remains in this ghost status till I remove the traefik stack.

And for a docker-compose file:
version: '3.6'
services:
  nginx:
    image: docker-hub.admin.bigcorp.net/nginx-nginx:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-nginx
    depends_on:
      - wordpress
      - b2c
      - backoffice
      - batches
      - nginx-static
      - nginx-backoffice
      - nginx-batches
      - nginx-reports
      - nginx-data
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.auth.basic: "${FRONT_HTPASSWD}"
        traefik.frontend.passHostHeader: "true"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
  nginx-static:
    image: docker-hub.admin.bigcorp.net/nginx-static:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-static
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker-static.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}-static.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.passHostHeader: "true"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
  b2c:
    image: docker-hub.admin.bigcorp.net/b2c:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-b2c
    depends_on:
      - db-all
      - cassandra
      - vault
    volumes:
      - type: bind
        source: /home/beastie/logs/${COMPOSE_PROJECT_NAME}/b2c
        target: /var/log/tomcat
      - type: bind
        source: /home/beastie/flux/${COMPOSE_PROJECT_NAME}
        target: /srv/tomcat/common_b2c/temp
    environment:
      assuremieux_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}.recette.bigcorp.com
      assuremieux_static: https://${COMPOSE_PROJECT_NAME}-static.recette.bigcorp.com
      cms_url: https://${COMPOSE_PROJECT_NAME}.recette.bigcorp.com/internal
      backoffice_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}-backoffice.recette.bigcorp.com
      graylog_host: graylog.lan.bigcorp.net
      statsd_prefix: com.bigcorp.${COMPOSE_PROJECT_NAME}
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
      placement:
        constraints:
          - node.role == worker
  wordpress:
    image: docker-hub.admin.bigcorp.net/lf-wordpress:2018.1
    hostname: docker-${COMPOSE_PROJECT_NAME}-wordpress
    depends_on:
      - db-all
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
  nginx-backoffice:
    image: docker-hub.admin.bigcorp.net/nginx-backoffice:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-nginx-backoffice
    depends_on:
      - backoffice
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker-backoffice.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}-backoffice.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.auth.basic: "${BACKOFFICE_HTPASSWD}"
        traefik.frontend.passHostHeader: "true"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
  backoffice:
    image: docker-hub.admin.bigcorp.net/backoffice:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-backoffice
    depends_on:
      - db-all
      - cassandra
      - vault
    volumes:
      - type: bind
        source: /home/beastie/logs/${COMPOSE_PROJECT_NAME}/backoffice
        target: /var/log/tomcat
      - type: bind
        source: /home/beastie/data/${COMPOSE_PROJECT_NAME}
        target: /srv/tomcat/data
    environment:
      backoffice_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}-backoffice.recette.bigcorp.com
      backoffice_static_baseurl: https://${COMPOSE_PROJECT_NAME}-backoffice.recette.bigcorp.com/public
      assuremieux_static: https://${COMPOSE_PROJECT_NAME}-static.bigcorp.com
      graylog_host: graylog.lan.bigcorp.net
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
      placement:
        constraints:
          - node.role == worker
  nginx-batches:
    image: docker-hub.admin.bigcorp.net/nginx-batches:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-nginx-batches
    depends_on:
      - batches
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker-batches.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}-batches.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.auth.basic: "${BATCHES_HTPASSWD}"
        traefik.frontend.passHostHeader: "true"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
  batches:
    image: docker-hub.admin.bigcorp.net/batches:${COMPOSE_PROJECT_NAME}
    hostname: docker-${COMPOSE_PROJECT_NAME}-batches
    depends_on:
      - db-all
      - cassandra
      - vault
    environment:
      assuremieux_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}.recette.bigcorp.com
      assuremieux_static: https://${COMPOSE_PROJECT_NAME}-static.recette.bigcorp.com
      backoffice_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}-backoffice.recette.bigcorp.com
      batches_deployment_baseurl: https://${COMPOSE_PROJECT_NAME}-batches.recette.bigcorp.com
      cms_url: https://${COMPOSE_PROJECT_NAME}.recette.bigcorp.com/internal
      graylog_host: graylog.lan.bigcorp.net
    volumes:
      - type: bind
        source: /home/beastie/logs/${COMPOSE_PROJECT_NAME}/batches
        target: /var/log/tomcat
      - type: bind
        source: /home/beastie/data/${COMPOSE_PROJECT_NAME}
        target: /srv/tomcat/data
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
      placement:
        constraints:
          - node.role == worker
  vault:
    image: docker-hub.admin.bigcorp.net/vault:${COMPOSE_PROJECT_NAME}
    hostname: docker-vault
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
  db-all:
    image: docker-hub.admin.bigcorp.net/db-all:${COMPOSE_PROJECT_NAME}
    user: "999"
    hostname: docker-${COMPOSE_PROJECT_NAME}-db
    volumes:
      - type: bind
        source: /home/beastie/mysql/${COMPOSE_PROJECT_NAME}
        target: /var/lib/mysql
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
          - db-benefit
          - db-wordpress
          - dbdev.lan.bigcorp.net
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
  nginx-reports:
    image: docker-hub.admin.bigcorp.net/nginx-reports:${COMPOSE_PROJECT_NAME}
    hostname: nginx-reports
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker-reports.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}-reports.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.auth.basic: "${BATCHES_HTPASSWD}"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
    volumes:
      - type: bind
        source: /home/beastie/data/${COMPOSE_PROJECT_NAME}/reports
        target: /home/wwwbigcorp/www
  nginx-data:
    image: docker-hub.admin.bigcorp.net/nginx-data:${COMPOSE_PROJECT_NAME}
    hostname: nginx-data
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - docker-data.bigcorp.com
    deploy:
      labels:
        traefik.docker.network: "${COMPOSE_PROJECT_NAME}_bigcorp"
        traefik.frontend.rule: "Host:${COMPOSE_PROJECT_NAME}-data.recette.bigcorp.com"
        traefik.frontend.entryPoints: "http,https"
        traefik.frontend.redirect.entryPoint: "https"
        traefik.port: "443"
        traefik.protocol: "https"
        traefik.frontend.auth.basic: "${BATCHES_HTPASSWD}"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
    volumes:
      - type: bind
        source: /home/beastie/data/${COMPOSE_PROJECT_NAME}
        target: /home/wwwbigcorp/www
  cassandra:
    image: docker-hub.admin.bigcorp.net/cassandra:${COMPOSE_PROJECT_NAME}
    hostname: cassandra
    user: "999"
    networks:
      ${COMPOSE_PROJECT_NAME}_bigcorp:
        aliases:
         - cassandra.bigcorp.com
    deploy:
      labels:
        traefik.enable: "false"
        com.bigcorp.scmfullrevision: "${SCM_FULLREVISION}"
        com.bigcorp.scmbranch: "${SCM_BRANCH}"
      placement:
        constraints:
          - node.role == worker
    volumes:
      - type: bind
        source: /home/beastie/cassandra/${COMPOSE_PROJECT_NAME}
        target: /var/lib/cassandra
      - type: bind
        source: /home/beastie/logs/${COMPOSE_PROJECT_NAME}/cassandra
        target: /var/log/cassandra
networks:
  ${COMPOSE_PROJECT_NAME}_bigcorp:
    external: true

and initialy the network was just:
networks:
  bigcorp:
    driver: overlay

Rollbacked to dopcker 18.03.1 and it works as expected - hope this will be fixed with docker 18.09 or later.


Updated Zendesk theme for OCW

Checklist

[x] Match the designs to the InVision mock up
[x] Submit a request Contact Us link (upper right) will open a page to submit a new support request (xPRO example)
[x] The number of buttons (that currently read: Label of button) and their text are not yet determined. Ensure the color and font are correct.
[x] Use fonts (and colors, if necessary) that match the OCW site.
[x] The title of page should be Support Center Help Center rather than Help & FAQs
[x] Add a Can't find what you're looking for? section, similar to xPRO. Just above the footer.

[x] The horizontal rule should use the red color from the search button
[x] The contact use button should use the red color form the search button and have white text
[x] The section background-color should be white
[x] Clicking Contact Us will open a page to submit a new support request (xPRO example)

[ ] The footer should match the OCW site footer

Live Preview
Live preview for the design can be viewed on

~~https://test4772.zendesk.com/hc/en-us~~ https://test1437.zendesk.com/hc/en-us

Blockers:
I am currently blocked by the following issues

Need a design for the footer (Screenshot will do to)
Need hero image

Screenshots

Updated footer

Updated hero image

@Wassaf-Shahzad
This is looking good so far. I put some notes on the footer in the issue and we're waiting on access to the hero image.

@Wassaf-Shahzad This is looking good so far. I put some notes on the footer in the issue and we're waiting on access to the hero image.

@briangrossman
As requested I have updated the footer and links.
You can view a deployed instance here

https://test4772.zendesk.com/hc/en-us

We still have MITxOnline references in the code, even the logo image in the header points to MITxOnline website's link. ref - (I believe this is not the intended behavior @briangrossman ?)

Correct. There shouldn't be any references to MITx Online in this repo.

Although there is no copyright section in invision i think there should be one? (@briangrossman What do you think?)

Yes. I think that is probably a good idea. It should say:
© [Current Year] Massachusetts Institute of Technology
Please make the layout similar to MITx Online with the MIT logo and address in one row, and the copyright (left-aligned) and links (right-aligned) in a row beneath it (keep existing fonts and colors). Note that there's a chance this will need to be updated when we finalize the footer for the site itself.

FYI: @Wassaf-Shahzad provided this Zendesk site for testing

I reviewed the design of https://test1437.zendesk.com/hc/en-us and it looks good.
One issue: the Contact Us link in the upper right still points to the old preview site. The Contact Us button on near the bottom of the page works fine though.

@pdpinch @arslanashraf7
So i tried making the contact us page configurable however was unsuccessful as by making in configurable we lose the ability to verify whether the user has the privileges to even access that page. Zendesk verifies that itself and sets the 'new_request' identifier based on that.
Zendesks provides no helper to to check these identifiers

This is looking good, @Wassaf-Shahzad. Can you remove the horizontal repeat from the hero image and use something like background-size:cover so the image fills the space w/o repeating?![Screenshot 2022-01-14 at 4 19 38 PM]

Done


Bump dependencies

Remove @types/autoprefixer, because this package has been deprecated.
Update @pmmmwh/react-refresh-webpack-plugin from ^0.4.3 to ^0.5.0-beta.0.
Reference
https://www.npmjs.com/package/@types/autoprefixer
https://github.com/JeffreyWay/laravel-mix/pull/2809/files

Thanks!


Fix JSON-schema-validators suite failing tests

JSON-schema-validators test suite report

test failed
reason

a schema given for items, JavaScript pseudo-array is valid
Expected result: true but validator returned: false

an array of schemas for items, incomplete array of items
Expected result: true but validator returned: false

an array of schemas for items, empty array
Expected result: true but validator returned: false

an array of schemas for items, JavaScript pseudo-array is valid
Expected result: true but validator returned: false

ECMA 262 regex non-compliance, ECMA 262 has no support for \Z anchor from .NET
Expected result: false but validator returned: true

validation of URIs, an invalid protocol-relative URI Reference
Expected result: false but validator returned: true

some languages do not distinguish between different types of numeric value, a float is not an integer even without fractional part
Expected result: false but validator returned: true

ref overrides any sibling keywords, ref valid, maxItems ignored
Expected result: true but validator returned: false

Recursive references between schemas, valid tree
The schema failed to load(Cannot read property 'schema' of undefined)

Recursive references between schemas, invalid tree
The schema failed to load(Cannot read property 'schema' of undefined)

base URI change - change folder, number is valid
The schema failed to load(Cannot read property 'schema' of undefined)

base URI change - change folder, string is invalid
The schema failed to load(Cannot read property 'schema' of undefined)

base URI change - change folder in subschema, number is valid
The schema failed to load(Cannot read property 'schema' of undefined)

base URI change - change folder in subschema, string is invalid
The schema failed to load(Cannot read property 'schema' of undefined)

root ref in remote ref, string is valid
The schema failed to load(Cannot read property 'schema' of undefined)

root ref in remote ref, null is valid
The schema failed to load(Cannot read property 'schema' of undefined)

root ref in remote ref, object is invalid
The schema failed to load(Cannot read property 'schema' of undefined)

required validation, ignores non-objects
Expected result: true but validator returned: false

Current list of failing tests looks like

test failed
reason

ECMA 262 regex non-compliance, ECMA 262 has no support for \Z anchor from .NET
Expected result: false but validator returned: true

validation of URIs, an invalid protocol-relative URI Reference
Expected result: false but validator returned: true

some languages do not distinguish between different types of numeric value, a float is not an integer even without fractional part
Expected result: false but validator returned: true

ref overrides any sibling keywords, ref valid, maxItems ignored
Expected result: true but validator returned: false

base URI change - change folder in subschema, number is valid
Expected result: true but validator returned: false

root ref in remote ref, string is valid
Expected result: true but validator returned: "Maximum call stack size exceeded"

root ref in remote ref, object is invalid
Expected result: false but validator returned: "Maximum call stack size exceeded"

Other errors decided to skip for now -
First one is really strange, as it is not a json-schema specification related
Others are really important, but requires a scope resolution refactoring (which was done not completely).  Will be fixed in future versions


Fix var-parameter detection for inferred params

No longer crashes when diagnosing var or

Resolves SR-NNNN.

This...did not work well. Trying again.


Fix style errors

Summary
Fix most of the remaining style errors (from 451 down to 64)
Also removed the unused firebase files and packages and update dependency
package version numbers in package.json to the latest minor/patch versions
I did test locally, looking at the console to see if the prop types I added needed to
be adjusted since I was using my best guess.
I also fixed a console log error about the autoFocus attribute being a string and not a boolean.
Ticket Link
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[ ] Ran make test to ensure unit and component tests passed
[ ] Added or updated unit tests (required for all new features)
[ ] Needs to be implemented in mobile (link to PR or User Story)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[ ] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

As these changes are basically fixing style errors, I'm going to merge them now. The review requests are in case you feel like it, and to let you know about these changes.

Release 1.0.0-dev.33


Listing modules of library brings up a bizarre number of them

Search for library

Press enter, wait

No profit:

This must've happened within the last 1-2 weeks, potentially because of a change in Scaladex.

Bug raised upstream : https://github.com/scalacenter/scaladex/issues/788
In the meantime could add a call to .distinct  here : https://github.com/Baccata/vscode-scaladex-search/blob/master/src/main/scala/extension.scala#L71

This was fixed upstream


[Feature]: solve yargs issue where it drops leading and trailing double quotes in a string

Describe the feature you would like
Have yargs preserve leading and trailing double quotes inside a string. Look at issue https://github.com/yargs/yargs-parser/issues/201 and solve it by forking the repository and make a pull request for it. https://github.com/yargs/yargs/blob/main/docs/tricks.md#quotes might be a good read before attempting to solve it.
e.g. '"hello"' should be '"hello"' after processing it with yargs. But currently, it yields 'hello' (double quotes gone).
Is this feature solving a problem?
It prevents yargs from throwing away leading and trailing double quotes so that we don't have to hack around the library.
Please share any additional details you have?
Currently the hack is in 2 places.
inputArgs = inputArgs.map(arg => arg.match(/^"(.|\n)*"$/) ? "___" + arg + "___" : arg) from cli.ts
and
if (typeof val === 'string' && val.match(/^___(.|\n)*___$/)) val = val.slice(3, -3) from plugins.ts
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing: fixed


Expansion depth and recursive expansion

Hi!
This may fix https://github.com/rsinger86/drf-flex-fields/issues/112 issue.
Changes
Contributed two new settings to FLEX_FIELDS_OPTIONS dict.

MAXIMUM_EXPANSION_DEPTH, which is Optional[int]

RECURSIVE_EXPANSION_PERMITTED, which is bool

New for loop has been added in _get_permitted_expands_from_query_param, iterating through expansion fields looking for recursive expansions and expansion depth.

A ValidationError is raised when conditions are met in both cases. This exception can be overridden through _recursive_expansion_found and _expansion_depth_exceeded methods.
Expansion depth and recursion settings can be overridden as well through maximum_expansion_depth and recursive_expansion_permitted properties.

Some tests have been added covering different scenarios

Updated README

added venv and .idea folders in gitignore.

This looks great, thank you. I just wanted to raise a few ideas for your consideration. If you want to keep it as is, I'm totally fine with that.

Should we drop the _ prefix on _expansion_depth_exceeded and _recursive_expansion_found since it appears the developer should be aware of them in case they want to customize?
Is _recursive_expansion_not_permitted a better name for the _recursive_expansion_found method given that it's possible to allow recursive expansions?
The recursive validation happens when the query param values are accessed, but it's possible to pass a list of expands directly to a serializer's  __init__, see here. Should we change it so the validation happens in both the query param and constructor scenarios?

Than you for your comments @rsinger86. I've moved the validation to _get_query_param_value method, which applies in all three approaches. You can see the commit. I've los dropped the _ prefix and renamed the protected class attributes.

thanks!


Quantization support

We should investigate how difficult it is to add quantization support.
It would be great if we could run the Llama2 7B model on a machine with 8GB RAM.

I'd say the first goal should be to even load Llama2 7B, but once that works, the Q4_0 quantization as they have it in ggml should be pretty straightforward.

I have it loading already -- working on the quantization vecdot routines right now.

That’s awesome! I was looking to power that with Metal.jl - are you on a M1/M2 as well?

Jup, on an M1 Air.


ARROW-13495: [C++][Compute] Fixing unaligned memory access in GrouperFastImpl

Temp vectors used in grouper implementation were allocated using stack implementation.
The buffer addresses returned by the stack were not aligned to the size of requested vector element.
Changing this to have returned buffers aligned to 8 byte boundaries.

@nealrichardson are you able to help verify the fix (re-running unaligned access tests that failed before)?

@nealrichardson are you able to help verify the fix (re-running unaligned access tests that failed before)?

I can try tomorrow, we run some sanitizer checks in CI but apparently not this code. I made a separate jira for that.

Trying in https://github.com/apache/arrow/pull/10840

@michalursa I've reproduced the ubsan failure, if you rebase on master you can run the r-sanitizer job, and hopefully with your changes here, it will pass

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer


RSpec/NamedSubject should be ignored in shared examples/contexts

I think NamedSubject should ignore shard examples

Duplicate of #453

@Darhazer oh, indeed. Sorry. Forgot to search first.


Fix SemVer cyclic dependency issues with some hacks

Fix issues affecting our usage of semver by pre-bundling it and manually fixing the cyclic references.

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:

:rocket: PR was released in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>:rocket:


immer wallets 2

[x] makeReducer / immer of root

cc: @keybase/picnicsquad

Will the ts-ignores go away once the later branches are merged down? Maybe I should wait to approve this PR until then..


Memory Leak when using Pinia

Environment

Operating System: Darwin
Node Version:     v22.7.0
Nuxt Version:     3.13.0
CLI Version:      3.13.1
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      compatibilityDate, devtools, modules
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://github.com/dissy123/nuxt-pinia-memory-leak
Describe the bug
The Repository i posted is just a blank Nuxt3 Project, i have added a Pinia Store like in the Documentation here:
https://nuxt.com/docs/getting-started/state-management
Have i done something wrong? Or is this a memory leak?
The Strings from the json objects are stored each request in the HEAP but not deleted again.
I tried it without the Code of the Store and no memory leak happens.
pnpm i

pnpm build

node --inspect .output/server/index.mjs

ab -n 50 -c 10 "http://localhost:3000/"

Sorry i am a little bit confused already hunting this for a few weeks now.
When you comment out the line in app.vue
await useAsyncData("todos", () => store.fetchIconsData());
no memory leak is happening!
i also tried it with callOnce the leak is also there!
I also tried it with https://vueuse.org/shared/createGlobalState/ and it also didn't change.
I also tried useFetch when fetching and $fetch
Additional context
https://github.com/vuejs/pinia/issues/2762
Logs
No response

can you reproduce without pinia? see my comment here: https://github.com/vuejs/pinia/issues/2762#issuecomment-2325901215

This is reproducible without Nuxt: see https://github.com/vuejs/pinia/issues/2762#issuecomment-2326174565.


SIGSEGV(SEGV_MAPERR)

It is an intermittent issue.
1.device
android 8.1
sdk 1.11.0
2. use PushAudioInputStream  to write audio data.
May be cause it.
Java_com_microsoft_cognitiveservices_speech_internal_carbon_1javaJNI_PushAudioInputStream_1Write+108)
3.I had check the SpeechRecognizer and inpustream state before wirte.

@wall3001 Could you please test and report on the latest 1.12.0 release also ?

OK.I’ll test it.

Closing the issue as not repro, let us know if you still see problems.


Tizen tabBar '../components/menu'

Hi,
I've just discovered your library. Great Job thanks for that.
Is it possible to hide the menu on the Tizen App. Or auto-hide it? Because when I delete/comment it
    <TabStack.Navigator
        // tabBar={ props => <Menu { ...props } /> }
        removeClippedSubviews
        swipeEnabled={ false }
        timingConfig={ { duration: 0.001 } }
    >
        <TabStack.Screen name="home" component={ ScreenHome } />
        <TabStack.Screen name="my-page" component={ ScreenMyPage } />
    </TabStack.Navigator>

it's still here

The Tab bar is inside index.tv.native.js file , which has nothing to do with Tizen. any edits there will only affect Android and tvOS. Edit index.web.js  instead

Closing as has been answered, feel free to reopen if needed


Regenerate bindings as of 07/04/2023

WHY IS THIS STILL HAPPENING

Closing, next one should be fine


Expose access to gradle properties in dependencyResolutionManagement DSL

Context
Gradle properties are a core part of statically configuring a build, but are currently not accessible in the new dependencyResolutionManagement DSL in Gradle 6.8. This prevents us from properly using it as we gate access to certain repositories on the presence of gradle properties. Is there any reason this is not possible since we are able to access properties elsewhere in settings files?

Scratch this, looks like it still (coincidentally) works as long as access is done on a withGroovyBuilder on the settings object within the block
settings.withGroovyBuilder {
  // do the dark magic here
}

Would love this to be reopened.
It's completely unclear from documentation how can values from gradle.properties be used in settings.gradle when defining dependencyResoltuionManagement

it's not clear to me either. why is properties.wyz working in pluginManagement and not in dependencyResolutionManagement?


Save function defect 0.4.9

🐛 Bug
In 0.4.9 the save selected layers and save all layers functions do no longer work. If selected they throw a list index out of range error. Tested it in a clean environment with a new installation via: pip install napari[all]
To Reproduce
Steps to reproduce the behavior:

Open napari
Load or create a layer
Try to save it via selected or all layers function

IndexError                                Traceback (most recent call last)
~/anaconda3/envs/napari4.9test/lib/python3.8/site-packages/napari/qt/qt_main_window.py in ()
485         save_selected_layers.setStatusTip(trans.('Save selected layers'))
486         save_selected_layers.triggered.connect(
--> 487             lambda: self.qt_viewer._save_layers_dialog(selected=True)
global self.qt_viewer._save_layers_dialog = undefined
global selected = undefined
488         )
489
~/anaconda3/envs/napari4.9test/lib/python3.8/site-packages/napari/_qt/qt_viewer.py in save_layers_dialog(self=, selected=True)
531             parent=self,
532             caption=trans.('Save {msg} layers', msg=msg),
--> 533             directory=hist[0],  # home dir by default,
global directory = undefined
hist = []
534             filter=ext_str,
535         )
IndexError: list index out of range
Environment
napari: 0.4.9
Platform: Linux-3.10.0-1160.25.1.el7.x86_64-x86_64-with-glibc2.10
Python: 3.8.10 | packaged by conda-forge | (default, May 11 2021, 07:01:05) [GCC 9.3.0]
Qt: 5.15.2
PyQt5: 5.15.4
NumPy: 1.20.3
SciPy: 1.6.3
Dask: 2021.06.0
VisPy: 0.6.6
OpenGL:

GL version: 2.1 Mesa 18.3.4
MAX_TEXTURE_SIZE: 8192

Screens:

screen 1: resolution 1440x960, scale 1.0

Plugins:

console: 0.0.3
scikit-image: 0.4.9
svg: 0.1.5

Hi @ch-n
Thanks for the report. This has been fixed in master and will be available in the following release.

Sadly 4.9 is not usable for many tasks with this bug then.
When will be the following release approximatly?

In the meantime you could patch the file yourself (is a one line fix)
you can execute this code to get the file you need to update
python -c "from napari.utils import history;print(history.__file__)"

A and then update the file from:
def get_save_history():
    """A helper for history handling."""
    folders = SETTINGS.application.save_history
    folders = [f for f in folders if os.path.isdir(f)]
    return folders

To:
def get_save_history():
    """A helper for history handling."""
    folders = SETTINGS.application.save_history
    folders = [f for f in folders if os.path.isdir(f)]
    return folders or [str(Path.home())]

@sofroniewn maybe we could do a mini-patch (<IP_ADDRESS>) release to include this, while 0.4.10 is out?

Thanks for the self patch suggestion. :)
Will fix it on our machines.

Sadly 4.9 is not usable for many tasks with this bug then.

We could start the 0.4.10 release process today / make the release tomorrow. I think it might be worth it - cc @jni @tlambert03

while trying something with magicgui yesterday, I realized I may have also introduced a regression in the napari.types.* registration during the __init__ reorg.  so that should also get fixed ASAP and should go in a quick patch release

0.4.10 has now been released with fix


Set up ci with azure-pipelines

Upload azure-pipelines.yml file to set up CI with Azure Pipelines.

Azure Pipelines can't use scoop command, although it run installing scripts.
iwr -useb get.scoop.sh | iex

And the output log display error.

The pwsh start with some args

So, it is recommended to use GitHub Actions instead of Azure Pipelines.

Indeed, screenshots display azure-pipelines can't run it normally.
You can new branch to use Github Action.
Close the pr, if you have no objection.

You can solve it by using ##vso[task.prependpath]$PATH.
More information to azure-pipelines-tasks#Logging Commands, or stackoverflow#How to set path in azure-pipeline using prependpath.
Please new a PR to try it if you more spare time.

👌


[BUG]: bumb-pydantic doesnt change files

OS: Wndows 11
IDE: Cursor
I am in a fresh fork  of patito in local dev, using a conda env.
THHs depends on pydantic v1 and I am looking to change to support v2, thus using bump-pydantic
(venv_patito)PS C:\Users\<user>\<wd>\patito> bump-pydantic src/patito
[10:38:16] Start bump-pydantic.                                                                                main.py:61
           Found 10 files to process                                                                                main.py:76
[10:38:32] Run successfully!                                                                                main.py:149
(venv_patito)PS C:\Users\<user>\<wd>\patito>

However, git doesn't track any changes and only generates an empty log.txt file. I've also been in src directory with the same outcome.
Shouldn't I get an error somewhere?

https://github.com/pydantic/bump-pydantic/assets/63276164/5a88e99f-f719-483e-aeae-2f8556a91eb8
https://github.com/pydantic/bump-pydantic/assets/63276164/7c07244e-2367-4489-9fa0-b7de10f89aff

I think the problem here is that you didn't receive a message saying "No files were modified."


feat(aot) Add intersection observer

@horymury, to get a release out successfully incl npm, please see https://github.com/jitsi/jitsi-meet-electron-sdk#publishing

@horymury, to get a release out successfully incl npm, please see https://github.com/jitsi/jitsi-meet-electron-sdk#publishing

Thank you, will do!


factory constructor isn't compliant with linters

Describe the bug
Following multiple linter's rules (ex: standardJS, ESLint, ...) the factory constructor isn't compliant with good practices.
To Reproduce

You only have to instantiate the WYSIWYG factory contructor and use a linter as cited as above.

Expected behavior
Reffering to ESLint documentation, the factory constructor must use a capital letter.
A little background :

Native JavaScript functions begin with an uppercase letter to distinguish those functions that are to be used as constructors from functions that are not. Many style guides recommend following this pattern to more easily determine which functions are to be used as constructors.

@pierredarrieutort
It's not the bug.
You should use as below. The factory method cannot be used as constructor
this.viewer = Editor.factory({
  ...
});


Make it possible to run Zookeeper in HA

Currently we run always only single instance of Zookeeper service. This is valid for both in-memory as well as for statefulset Kafka setups. We should add support for running Zookeeper ensembles with 3 and more nodes using stateful sets.

This is now fixed (in a fairly primitive way), but it works :-). Please do not scale the ZK cluster once it is deployed :-o.


Add Delete Key Binding For Shot Deletion

Looks good, one small whitespace comment. And also please add a description to pull requests in the future

Looks good, I'll merge.
We'll try to come up with a small list of the more useful bindings, btw.


Missing DSC Module xOU

Hi all,
hope that's the right way for contributing my question.
Just wondering why the Module xOu from [PowershellGallery.com] (https://www.powershellgallery.com/packages/xOU/) is missing here?
Is there any reason for, which I haven't found yet?
I'm trying to configure my OUs and I thought I could do that with the xADOrganizationalUnit Resource.
Or is there an other way to configure Active Directory OUs?

without verifying it, but it seems like that issue has been solved. DSC Resource xActiveDirectory
contains now  MSFT_xADOrganizationalUnit.


Add pr-size-labeler for Github Action

[!IMPORTANT]
Read issue #2 first

I've seen how this Github Action works and would like to add it to my repository. If anyone wants to try to add it, go ahead.
This is the repository with the documentation: https://github.com/CodelyTV/pr-size-labeler
Thank you very much.

Hi @nmarulo. Can I please take a shot at this?
I understand if I'm not allowed to work on two issues in a row (so that others can work on this).

@smzoha It's all yours 👍

Hi @nmarulo. Can I please take a shot at this? I understand if I'm not allowed to work on two issues in a row (so that others can work on this).

This condition only applies within the same repository.

Thank you once again! I'll give this a shot tomorrow.


Support for instructor's first initial and last name

Hey,
I'd like to see how this integrates with UofTCourseInfo Chrome Extension. I should be able to link to your website from the instructor names in the tooltip. The only issue is my extension relies on course data provided by Cobalt API which does not provide the instructor's full name, just the first initial and last name.
Do you think you can make this work?
Thanks!

It’s possible but it will be a lot of work — since there must be repeated instructor abbreviation name.
imo, it’s better to use a hash table, which accepts (department, instructor abbreviation) and returns instructor full name. Then you can use that full name to link to my service.
And that “department” can be retrieved by using the first three letters of the course id that one teaches.
So my question is, is it possible to have (department, abbreviation) with your app?

Yeah I have access to department and the abbreviation but I don't have a dataset to generate that hashmap. So I can't obtain the full instructor name at the moment. Do you by any chance have parsesble list of all instructors and their departments? Then we could probably generate a hashmap like you suggested either on your end or my end

I do have a table which comprises instructor abbreviation name and full name and their department in my MySQL server. Shall we talk about this on messenger? It’s not that convenient to chat on github. I will add you on fb later :)


Update CLI to use Cobra

This will make it importable as a subcommand into stolostron/policy-cli.
Also renames it to templateresolver (without a dash), but I can revert that if we think it's been around long enough that it would confuse users.
I thought about initializing a separate go.mod so that cobra wouldn't have to be pulled into all the places we use templates, but it didn't seem like adding cobra to the go.mod added all that much overhead compared with the headache of having separate go.mod files.

Neglected to update the name of the CLI internally. Opened a followup PR:

https://github.com/stolostron/go-template-utils/pull/143


[5.6] Modify factory helper conditions

this PR use Guard Clauses instead of elseif statement

Doesn't describe what is being improved or fixed.

@taylorotwell this PR doesn't change any behavior , it only removes the elseif statement to improve the function readability flow


[BUG] Backend fails to build - Conflicting method/path combination "DELETE api/Chore/{id}"

Describe the bug
Cannot run back end, error caused by conflicting Endpoint method/path combo at the delete chore endpoint
Severity
Breaks Everything
To Reproduce
Steps to reproduce the behavior:

Run Backend

Expected behaviour
Backend runs successfully
Actual behaviour
Backend fails to run - error in output: Conflicting method/path combination "DELETE api/Chore/{id}"
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:
Windows 10 - Chrome
Possible solution:
Additional context

Need this to be quickly merged done so we could continue doing work but the issue was verified with @misl000, @icam308 ,@pabloSushibar and @vee-christella while coding together :)


Socket.IO Crash on server leaving pool

Hey there,
We are currently facing an issue with fetchSockets() in a Nest.js backend using @socket.io/postgres-adapter.
When one server connected to the database disconnects it throws an error and crashes the server.
Error: timeout reached: only 0 responses received out of 1
We are running on AWS rds-postgres. When two se
We are pretty lost currently when it comes to ideas where to debug and how to fix this issue, therefore we're asking here. We believe this is either a problem with the postgres adapter or with socket.io itself (thus my next question: does this issue belong in this repository or should we open another issue in the socket.io repo?).
Thanks a lot for your help!
Relevant versions in use
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hi! The error is thrown there: https://github.com/socketio/socket.io-postgres-adapter/blob/4190f4b571cfe29c3db70c68a8250817251effd0/lib/index.ts#L711-L715
You should be able to catch it though:
try {
  const sockets = await io.fetchSockets();
} catch (e) {
  // something went wrong
}

Isn't that the case?

`const sockets = await this.server.fetchSockets();
sockets.forEach(socket => {
  if (
    socket?.data?.registrations &&
    _.find(
      socket.data.registrations,
      (registration: string) => registration === generateIndicatorId(indicatorId, relevanceTime, organizationId)
    )
  ) {
    socket.emit("update", indicator);
  }
});`

Thanks for the fast response!
I've added a try-catch and it still crashes the server

Hmm, I'm not able to reproduce: https://github.com/socketio/socket.io-fiddle/tree/postgres-adapter
https://github.com/socketio/socket.io-fiddle/blob/de5c4ef4a89fe80d8505fe8c2a3414d47ae9737e/server.js#L44-L51
The exception is properly caught and printed to the console:
  try {
    const sockets = await io.fetchSockets();

    socket.emit("count", sockets.length);
  } catch (e) {
    console.log(e); // prints "Error: timeout reached: only 0 responses received out of 1 [...]"
  }
});

Could you please check?

Closed due to inactivity, please reopen if needed.


docs: mention package.json can be read from parent directories

@dsherret Are these descriptions accurate?


Update entities.md

Hi.
This modification proposal adds a comment to the Unique bulletpoint suggesting the addition of examples to differentiate between Primary and Unique. Regards.
IL.
What are you changing in this pull request and why?

Checklist

[ ] Review the Content style guide so my content adheres to these guidelines.
[ ] For docs versioning, review how to version a whole page and version a block of content.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):

[ ] Add/remove page in website/sidebars.js
[ ] Provide a unique filename for new pages
[ ] Add an entry for deleted pages in website/vercel.json
[ ] Run link testing locally with npm run build to update the links that point to deleted pages

Asked Pm for review


Infer installs infer.exe binary

[Background: I'm trying to make Infer compile under Windows. I will be submitting issues and PR to this effect.]
The infer Makefiles build and install a infer.exe binary, next to the 'naked' infer one [1]. This is somewhat weird, as Infer cannot be built on Windows currently. This would be of little consequence, except for this:
http://cygwin.1069669.n5.nabble.com/cp-utility-bug-when-dest-name-exe-file-exist-tp57955p58001.html
Basically, Cygwin won't install an executable binary if there is already an existing file with a .exe extension. So the above-mentioned part of the Makefile is not portable.
If, as I suspect, the .exe binary is not useful under Linux/MacOSX, I can propose a patch that prevents it from being installed. This will simplify the Windows build.
[1] https://github.com/facebook/infer/blob/4d46f8631e5d7fbbc51bc36c8e52429aee310a06/infer/src/Makefile#L132

Interesting... The .exe file comes from dune, so I don't know how to do it differently. Or is the issue in the line after the one you pasted?
https://github.com/facebook/infer/blob/4d46f8631e5d7fbbc51bc36c8e52429aee310a06/infer/src/Makefile#L133
Basically that line exists so that it's easy to make sure to use the optimised binary (.exe) and not the bytecode version (.bc) of infer, in the context of building infer successively in one mode and the other. However it's a minor convenience so it could go away (I think, unless other tests in the repo depend on that), or at least give the .exe a different extension.

The faulty (if faulty can be used here, the culprit is mostly Cygwin) line is indeed the second one, but it is not possible to make a permalink over two lines.

Basically that line exists so that it's easy to make sure to use the optimised binary (.exe) and not the bytecode version (.bc) of infer, in the context of building infer successively in one mode and the other.

I see, I did not realize that. There are indeed two "competing" lines for $(INFER_BIN).exe and $(INFER_BIN).bc.
I will try to find an installation scheme that makes Cygwin happy, maybe by removing first the existing binaries. I will keep you posted.

I pushed a fix for this issue in #1060. I had to go for a windows-only snippet of code, because all other solutions had drawbacks. (I particular, if we do not want to remove infer.exe when compiling infer.bc).

Closed by https://github.com/facebook/infer/commit/31a6b92902f6166d8c7f4ccac21a1de1bb9c0c4f


Add build progress to console plain mode

This pull request adds occasional progress indicators to the plain console mode.
Context
Right now, it’s impossible to get the build progress when using the plain console mode. This is useful to have when tail -f’ing build logs from a CI pipeline, where you need to use plain mode but want the human friendly progress indications.
Implementation info/decisions are included in the commit messages. Unopinionated on the actual format of the progress updates.
Thanks!
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thank you for giving this a try. Since is such a visual change, would it be possible for you to provide a screen-cast illustrating the before-after state of your changes?

Maybe use https://asciinema.org/ to do it?

Rebased and pushed up a fix to make it less noisy (as originally intended).

would it be possible for you to provide a screen-cast illustrating the before-after state of your changes?

Sure, here’s a screencast of running classes testClasses (realistic workload) on this repo.

We could make it a little less chatty by adding a minimum monotonic time between progress updates. But for any reasonably sized build the progress updates even in the worst case will be a small fraction of the total log lines.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

Hey @jbartok, let me know if there’s anything else you need from me on this one. Thanks!

Seems like the change is messing with a bunch of tests that rely on plain console output... I'll get back to you on how we should approach this.

Thanks @jbartok. Happy to update the tests. I haven't done so yet to ensure we were comfortable with the feature and approach before moving on to fixing all of the tests.

Thanks @jbartok. Happy to update the tests. I haven't done so yet to ensure we were comfortable with the feature and approach before moving on to fixing all of the tests.

Ok, please go ahead then and update the tests.

@jbartok On it. Do you have any opinions on if this feature should be default off or default on? That has some implications for how I’ll go about fixing up the tests, beyond just the user facing changes.

Do you have any opinions on if this feature should be default off or default on?

I would say default OFF.

Added this feature as an opt-in behavior via --console=plainProgress. Still need to add integration tests but is otherwise usable.

Tests are added. :sanityCheck and :logging:quickTest are passing. Ready for another look whenever you get the chance @jbartok.

Rebased on latest master and applied requested edits.

Hey @kmark.
Sorry for the delayed response. We had some internal discussion on this again; there were some concerns. Ultimately, we agreed to make this functionality part of the plain console and NOT add an extra console mode.
I know you already put a lot of effort into it, but would you be willing to push further along that line?

Hey @jbartok,
No worries. I appreciate the team's time.
I had this originally tied into the plain console mode so rolling the recent changes back shouldn't be much trouble.
Do we still want to provide a command line option to toggle this behavior within the plain console mode or are we okay with this becoming a permanent always on feature?

Hey @jbartok,
No worries. I appreciate the team's time.
I had this originally tied into the plain console mode so rolling the recent changes back shouldn't be much trouble.
Do we still want to provide a command line option to toggle this behavior within the plain console mode or are we okay with this becoming a permanent always on feature?

Please make it a permanent, always-on feature.

Hey @jbartok,
Rebased against current master and re-integrated the feature back into the normal progress console mode. Let me know what you all think.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle cancel

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Hi @kmark. Would you mind looking into the failures above? You should be able to access our Team City instance as a guest, let me know if not.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Hey @jbartok, fixed up output scraping and the Windows-specific test.

Thanks @kmark. Let me try to push this through CI today.

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Looks like 2 more to go. I can take a look at these later today.

@kmark I don't understand that weird, intermittent failure in AutoConsoleBasicGroupedTaskLoggingFunctionalTest.long running task output correctly interleave with other tasks in parallel console attached to stderr only, will need to investigate further, when I get to it.

@jbartok It looks like the transient failures were due to an incomplete regex that didn’t handle the (FAILING) case of the progress reports.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Fixed the ToolingApiLoggingCrossVersionSpec issue by just filtering out the progress logs. Not certain if that’s what we want to do, but confirmed it works.

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Instead of playing this perpetual game of whack-a-mole with these integration tests, I added progress normalization directly to the AbstractIntegrationSpec. That feels like a better approach.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed.

Appreciate the heads up @blindpirate. Based on the thread dump it looks like this is happening when we hit:
https://github.com/gradle/gradle/blob/bf2aa0b44037ddaea1e66c216d44566924745ca0/platforms/core-runtime/logging/src/main/java/org/gradle/internal/logging/console/PlainBuildStatusRenderer.java#L89-L91
and it’s deadlocking because the Logger is attempting to contribute to the build output pipeline.
Sounds like we need to apply the fix in #24593 here.

Sounds like we need to apply the fix in #24593 here.

Hmm... shouldn't this branch already include the code from #24593?

Yes it is included.

Sorry, I should’ve been more clear. I need to apply the fix from that PR to the code I wrote here: https://github.com/gradle/gradle/blob/bf2aa0b44037ddaea1e66c216d44566924745ca0/platforms/core-runtime/logging/src/main/java/org/gradle/internal/logging/console/PlainBuildStatusRenderer.java#L89-L91

Added the, admittedly strange, fix for the deadlock. Overflowed progress will now show as 99% instead of 101%, 102%, etc. My deadlock fix differs slightly from the one in #24593 in that I’m taking a copy of the progress state before launching the new thread, which avoids a race condition where we might log different values than the ones we tested against.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test RFN

I've triggered the following builds for you. Click here to see all build failures.

ReadyForNightly build

I've triggered a build for you. Click here to see all failures if there's any.

Hey @jbartok, thank you for merge, guidance, and support for this change over the past year! If you hit issues with this down the line, feel free to ping/mention me here on GitHub.


ROX-13798: Add resource limits for the node-inventory container

Description
The newly created collector container node-inventory has now resource limits. They are set to the default values of the compliance container, as it hasn't observed any issues during load testing. The limits are set with a large error margin to avoid OOM kills. Should a OOM happen, the blast radius will be limited to a single container (and the RHCOS node scanning feature), so that ACS with all other features can continue running.
Checklist

[ ] Investigated and inspected CI test results

N/A

[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed

[x] Running roxctl helm output secured-cluster-services followed by helm template and analyzing the collector.yaml manifest manually
[ ] Running roxctl sensor generate openshift and analyzing the collector.yaml manifest manually
[ ] CI

/test ocp-4-8-qa-e2e-tests ocp-4-10-operator-e2e-tests


Headlamp Icons does not load in isolated environment.

I am trying to host headlamp in cluster on an isolated environment without internet access. However the frontend dashboard is trying to load the following icons from the internet (links below) which will not work at all if I am accessing the dashboard from an isolated environment without internet access.
Can somebody look into it and make the icons load as assets locally instead of trying to fetch a public icon?  Not just icons, any other public CDN will not work in isolated environment. Thanks!
https://api.iconify.design/mdi.json
https://api.simplesvg.com/mdi.json
https://api.unisvg.com/mdi.json

Hello.There are a number of fixes for this merged into main. We are going to do another release this week (hopefully).best regards,On 25. Apr 2023, at 10:33, jgyy @.***> wrote:
I am trying to host headlamp in cluster on an isolated environment without internet access. However the frontend dashboard is trying to load the following icons from the internet (links below) which will not work at all if I am accessing the dashboard from an isolated environment without internet access.
Can somebody look into it and make the icons load as assets locally instead of trying to fetch a public icon?  Not just icons, any other public CDN will not work in isolated environment. Thanks!
https://api.iconify.design/mdi.json
https://api.simplesvg.com/mdi.json
https://api.unisvg.com/mdi.json
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

I hope the list of fixes also includes having local icon assets though. thanks anyway

@jgyy , thanks. Closing this as it should be now available as mentioned.
If you spot any missing icon, please let us know. We will also work on a way to detect any missing icons from the cache in #1109 .


Stacked Area Charts Don't Stack

Description
Prior to 3.44.1, stacked area charts would stack, even with a combo chart. I have a combo chart that has used stacked bars, stacked areas and a single line for over a year. But as of 3.44.1, the bars stack, but the areas do not stack. Even after removing all other series except for the areas and they still won't stack. Even Apexchart's website's demo for stacked areas doesn't stack now.
Steps to Reproduce

Create a simple stacked area chart
Observe that chart does not stack (areas overlap instead of stacking)
Or review the apexcharts stacked area page (https://apexcharts.com/javascript-chart-demos/area-charts/stacked/) and observe that the areas are not stacked

Expected Behavior
In the codepen/reproduction link, I would expect the values to stack and plot on the Y value at the sum of all values. For example, the last values in 1999 are 125 and 100, which, stacked, should plot at 225.
In the screenshot of the apex charts website, the values are 20, 11, 10, which stacked would plot at 41.
Actual Behavior
"Stacked" areas (in codepen and apex charts website screenshot) are overlapping, not stacking.
Screenshots
This is from the apex charts website to show even the demo is not functioning properly

Reproduction Link
https://codepen.io/krcoats/pen/OJdrLKW
Thank you for the help.

The issue is being addressed. Meanwhile, you can fix this by setting
options = {
  chart: {
    stacked: true,
    stackOnlyBar: false
  }
}

If the type is removed from both series they will stack, even though stackOnlyBar is true (by default). This shouldn't happen.

I'm facing the same problem, using vue3-chartjs.
Tried the stackOnlyBar but it's not working either


MM-36573 Fix console error when viewing channel on an unsupported CRT client while webapp is open with CRT on

Summary
Fix console error when viewing channel on an unsupported CRT client while webapp is open with CRT on.
Ticket Link
https://mattermost.atlassian.net/browse/MM-36573
Release Note

NONE

/cherry-pick cloud

Cherry pick is scheduled.


HTML

#HTML
##User Story
As a bootcamp student
I want the paperwork notes to be structured on a webpage
so that I can easily find and read information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

#CSS
##User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
##Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I see a dark blue header and footer, and four boxes with a shadow


ref(deis-dev): rename workflow to controller

Workflow is the platform product; controller is the API server.
refs https://github.com/deis/deis/issues/4952
to be merged after https://github.com/deis/workflow/pull/494 goes green and has pushed the images to dockerhub/quay

@bacongobbler looks like https://github.com/deis/workflow/pull/494 has gone green but needs merge before it'll push to the docker repos. LGTMing now, pending that of course.


EHN: signal.window: add array API support

Towards gh-20678.
This PR adds Array API standard support to window function definitions within scipy.signal.
This is a bit different than other Array API changes, becuase these functions construct arrays from scratch. So rather than pulling the array API namespace from the inputs, this adds a new optional array_namespace keyword argument to each function that lets the user specify an array API; this defaults to scipy._lib.array_api_compat.numpy, so there shouldn't be any user-visible change in the default case.
This should be considered a draft – I'm curious if maintainers have thoughts about whether this keyword argument is the best way to support the Array API for cases like this. Thanks!

Thanks for this @jakevdp!

whether to name the parameter array_namespace or xp, and whether we would like a device parameter as well.

We should do this consistently for all functions that create new arrays without receiving an array input. For fftfreq & co, we went with two keyword-only keywords: xp=None, device=None. Which still seems fine to me, so I suggest to go with that. xp is indeed very slightly non-descriptive, but I think if we use it consistently it will become quite recognizable to users soon enough.

I hadn't considered that argument for not considering the tests yet - you make a good point. So far I don't think we've accidentally introduced any regressions because of test changes. A separate PR seems like a potentially useful strategy, as long as it's available together with the code changes. Otherwise we have no way of testing the new functionality.
How about opening a second PR on top of this one including test changes? Then we can choose to either:

merge this PR, then rebase and merge the second PR, or
simply consider this one as thorough regression testing, and only merge the second PR when both are green (closing this PR)

How about opening a second PR on top of this one including test changes? Then we can choose to either:
merge this PR, then rebase and merge the second PR, or
simply consider this one as thorough regression testing, and only merge the second PR when both are green (closing this PR)

That sounds like the right idea to me.

I updated _windows.py with the xp and device arguments, and squashed the commit. I'll plan to work on test changes in a second commit on top of that, probably some time next week.

I tried converting the test but it's failing, I think because the xp fixture tries to pass in numpy, which is not (currently) compatible with the Array API (e.g. np.concat doesn't exist). What's the best approach here?

Right, this is why I didn't do this in fftfreq. It shouldn't be too complicated though, I think xp_res = array_namespace(xp) in the test functions, then passing xp=xp_res in to the functions being tested, should work.

Should we worry about no longer having test coverage for the default call pattern, i.e. not passing xp at all?

Should we worry about no longer having test coverage for the default call pattern, i.e. not passing xp at all?

I would add a separate test for just that.

(marked as draft until we have the PR with the test changes)


feat: chart legend support px rem em % unit type

Overview
This PR is for the ticket #2277
Added support for the different CSS unit like px, rem, em, % and also it works px if we receive only a number without having any unit.
Note: While testing please use the legend height and width in plugin.tsx should be less than the widget height and width.
Verifying Changes
https://github.com/awslabs/iot-app-kit/assets/139960352/78350025-07b8-41bc-afd3-a0634df11c16
Legal
This project is available under the Apache 2.0 License.

@gmuralidharreddy Thank you! I will review this today.


[improve][build] Use slf4j-bom to align slf4j versions

Motivation
slf4j 2.0.x comes with slf4j-bom which can be used to align slf4j library versions.
Modifications
use slf4j-bom to align slf4j versions
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.70%. Comparing base (bbc6224) to head (75b66e1).
Report is 218 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22646      +/-   ##
============================================
- Coverage     73.57%   72.70%   -0.88%
+ Complexity    32624    32554      -70
============================================
  Files          1877     1887      +10
  Lines        139502   141006    +1504
  Branches      15299    15478     +179
============================================
- Hits         102638   102516     -122
- Misses        28908    30618    +1710
+ Partials       7956     7872      -84

Flag
Coverage Δ

inttests
27.39% <ø> (+2.80%)
:arrow_up:

systests
24.58% <ø> (+0.26%)
:arrow_up:

unittests
71.47% <ø> (-1.38%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 344 files with indirect coverage changes


ConstPlugin should remove dead branches in LogicalExpressions

Feature request

What is the expected behavior?
For example, given the following code:
var foo = false && thing1() && thing2();

ConstPlugin should produce the following:
var foo = false;

What is motivation or use case for adding/changing the behavior?
This will result in more optimal import pruning. Let's look at a concrete example:
Suppose "some-pkg" has been declared as side effect free. In the code below, the "some-pkg" import declaration will be correctly pruned.
import {foo} from "some-pkg";

if (false) {
  foo();
}

However, in the code below, "some-pkg" will not be pruned, which is a suboptimal result. Instead, foo should be considered unused.
import {foo} from "some-pkg";

var bar = false && foo();

How should this be implemented in your opinion?
I'm not totally sure, but probably something along the lines of:

Add a logicalExpression hook to Parser
Use the logicalExpression hook in ConstPlugin to remove dead branches

Are you willing to work on this yourself?
Yes

If you need help, feel free to ask  👋

Search the code base for expressionConditionalOperator to see how it's done for the ?: operator. Do it similar.

OK to close this now, #8233 has already fixed it.

Marking as closed (https://github.com/webpack/webpack/pull/8233)

There are still cases where this is broken (webpack v5.30.0)
false && unreachable() // <-- works, unreachable is pruned
something && false && unreachable() // <-- not working, unreachable is bundled

(Full repo: https://github.com/rtsao/webpack-repro-7519):
Inline reproduction:
// index.js
import unreachable from "./unreachable.js";

function something() {
  return Math.random();
}

function app() {
  something() && false && unreachable();
}

app();

// unreachable.js
module.exports = function unreachable() {
  console.log("Unreachable function should not be bundled!");
};

Expected
unreachable should not be bundled
Actual
unreachable is bundled

Mark as enhancement should be easy to fix, if you want to help I can provide place where you can improve it

bump


Bulk edit, batch 4 of today's validation fixes for column headers.

Docs Build status updates of commit 45556aa:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/web-service-reference/copyfolderresponsemessage.md
:white_check_mark:Succeeded
View

docs/web-service-reference/createdevent.md
:white_check_mark:Succeeded
View

docs/web-service-reference/folderclass.md
:white_check_mark:Succeeded
View

docs/web-service-reference/getclientaccesstoken.md
:white_check_mark:Succeeded
View

docs/web-service-reference/isdelegated.md
:white_check_mark:Succeeded
View

docs/web-service-reference/name-emailaddresstype.md
:white_check_mark:Succeeded
View

docs/web-service-reference/numberofmembersavailable.md
:white_check_mark:Succeeded
View

docs/web-service-reference/oldfolderid.md
:white_check_mark:Succeeded
View

docs/web-service-reference/playonphonegreetingresponse-um-web-service.md
:white_check_mark:Succeeded
View

docs/web-service-reference/primarysmtpaddress.md
:white_check_mark:Succeeded
View

docs/web-service-reference/processrightaway.md
:white_check_mark:Succeeded
View

docs/web-service-reference/readflag.md
:white_check_mark:Succeeded
View

docs/web-service-reference/reminderminutesbeforestart.md
:white_check_mark:Succeeded
View

docs/web-service-reference/replyalltoitem.md
:white_check_mark:Succeeded
View

docs/web-service-reference/request-getdomainsettingssoap.md
:white_check_mark:Succeeded
View

docs/web-service-reference/requestedview.md
:white_check_mark:Succeeded
View

docs/web-service-reference/requiredattendees.md
:white_check_mark:Succeeded
View

docs/web-service-reference/resolvenamesresponse.md
:white_check_mark:Succeeded
View

docs/web-service-reference/responsemessages.md
:white_check_mark:Succeeded
View

docs/web-service-reference/retentionpolicytag.md
:white_check_mark:Succeeded
View

docs/web-service-reference/retentionpolicytags.md
:white_check_mark:Succeeded
View

docs/web-service-reference/returnqueueevents.md
:white_check_mark:Succeeded
View

docs/web-service-reference/saveditemfolderid.md
:white_check_mark:Succeeded
View

docs/web-service-reference/searchfolder.md
:white_check_mark:Succeeded
View

docs/web-service-reference/senditem.md
:white_check_mark:Succeeded
View

docs/web-service-reference/senttime.md
:white_check_mark:Succeeded
View

docs/web-service-reference/startdate-recurrence.md
:white_check_mark:Succeeded
View

docs/web-service-reference/subject.md
:white_check_mark:Succeeded
View

docs/web-service-reference/tokenvalue.md
:white_check_mark:Succeeded
View

docs/web-service-reference/totalcount.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Updated and created a new settings page with IOS like dropdown menus

Hi. I just tested this on my phone. It isn't really working well with Voiceover unfortunately. I mean it does work but is a bit confusing. VO reports General as a heading and you have to tap on it to expand it.
I'm not really sure what the original issue was about exactly, but this doesn't feel like the iOS settings app, at least with Voiceover.
I also got the following from the debugger when collapsing the general section:
Thread 1: "Invalid batch updates detected: the number of sections and/or rows returned by the data source before and after performing the batch updates are inconsistent with the updates.\nData source before updates = { 7 sections with row counts: [6, 0, 0, 1, 0, 0, 0] }\nData source after updates = { 7 sections with row counts: [6, 0, 0, 0, 0, 0, 0] }\nUpdates = [\n\tDelete section 0,\n\tInsert section 0\n]\nTable view: <UITableView: 0x10af19c00; frame = (0 91; 390 753); clipsToBounds = YES; autoresize = W+H; tintColor = <UIDynamicCatalogColor: 0x3037a0aa0; name = Foreground 1>; gestureRecognizers = <NSArray: 0x301bcc630>; backgroundColor = <UIDynamicCatalogColor: 0x30372afd0; name = Background Base>; layer = <CALayer: 0x30122c4c0>; contentOffset: {0, 0}; contentSize: {390,<PHONE_NUMBER>3333326}; adjustedContentInset: {0, 0, 34, 0}; dataSource: <Soundscape.SettingsViewController: 0x114ab4a00>>"

Hi, I made some changes to the settings page, I included the audio beacon section that ryan worked on before. Additionally it seems that if we want to have each section open up to a new page, it would require making separate controllers for each expanded section underneath the general one. I did manage to get callouts to open to a new page but I would like someone to look into if it works completely. As for the thread error, I have been looking diligently into it but am not quite sure how to fix it as it only happens every now and then and when it does pop up it is inconsistent with what action causes it, such expanding a section or closing a section or opening too many sections or navigating too fast.