Explore the option of using the "strict" version

It seems the "strict" version of the schema might yield better results with respect to a Regex error in earlier versions of the JSON schema.

Looks like I don't have the strict version is currently not linked on the OASIS repo:
{
  "$defs": {
    "acknowledgments_t": {
      "description": "Contains a list of acknowledgment elements.",
      "items": {
        "additionalProperties": false,
        "description": "Acknowledges contributions by describing those that contributed.",
        "minProperties": 1,
        "properties": {
          "names": {
            "description": "Contains the names of contributors being recognized.",
            "items": {
              "description": "Contains the name of a single contributor being recognized.",
              "examples": [
                "Albert Einstein",
                "Johann Sebastian Bach"
              ],
              "minLength": 1,
              "title": "Name of the contributor",
              "type": "string"
            },
            "minItems": 1,
            "title": "List of acknowledged names",
            "type": "array"
          },
          "organization": {
            "description": "Contains the name of a contributing organization being recognized.",
            "examples": [
              "CISA",
              "Google Project Zero",
              "Talos"
            ],
            "minLength": 1,
            "title": "Contributing organization",
            "type": "string"
          },
          "summary": {
            "description": "SHOULD represent any contextual details the document producers wish to make known about the acknowledgment or acknowledged parties.",
            "examples": [
              "First analysis of Coordinated Multi-Stream Attack (CMSA)"
            ],
            "minLength": 1,
            "title": "Summary of the acknowledgment",
            "type": "string"
          },
          "urls": {
            "description": "Specifies a list of URLs or location of the reference to be acknowledged.",
            "items": {
              "description": "Contains the URL or location of the reference to be acknowledged.",
              "format": "uri",
              "title": "URL of acknowledgment",
              "type": "string"
            },
            "minItems": 1,
            "title": "List of URLs",
            "type": "array"
          }
        },
        "title": "Acknowledgment",
        "type": "object"
      },
      "minItems": 1,
      "title": "List of acknowledgments",
      "type": "array"
    },
    "branches_t": {
      "description": "Contains branch elements as children of the current element.",
      "items": {
        "additionalProperties": false,
        "description": "Is a part of the hierarchical structure of the product tree.",
        "maxProperties": 3,
        "minProperties": 3,
        "properties": {
          "branches": {
            "$ref": "#/$defs/branches_t"
          },
          "category": {
            "description": "Describes the characteristics of the labeled branch.",
            "enum": [
              "architecture",
              "host_name",
              "language",
              "legacy",
              "patch_level",
              "product_family",
              "product_name",
              "product_version",
              "product_version_range",
              "service_pack",
              "specification",
              "vendor"
            ],
            "title": "Category of the branch",
            "type": "string"
          },
          "name": {
            "description": "Contains the canonical descriptor or 'friendly name' of the branch.",
            "examples": [
              "10",
              "365",
              "Microsoft",
              "Office",
              "PCS 7",
              "SIMATIC",
              "Siemens",
              "Windows"
            ],
            "minLength": 1,
            "title": "Name of the branch",
            "type": "string"
          },
          "product": {
            "$ref": "#/$defs/full_product_name_t"
          }
        },
        "required": [
          "category",
          "name"
        ],
        "title": "Branch",
        "type": "object"
      },
      "minItems": 1,
      "title": "List of branches",
      "type": "array"
    },
    "full_product_name_t": {
      "additionalProperties": false,
      "description": "Specifies information about the product and assigns the product_id.",
      "properties": {
        "name": {
          "description": "The value should be the product\u2019s full canonical name, including version number and other attributes, as it would be used in a human-friendly document.",
          "examples": [
            "Cisco AnyConnect Secure Mobility Client 2.3.185",
            "Microsoft Host Integration Server 2006 Service Pack 1"
          ],
          "minLength": 1,
          "title": "Textual description of the product",
          "type": "string"
        },
        "product_id": {
          "$ref": "#/$defs/product_id_t"
        },
        "product_identification_helper": {
          "additionalProperties": false,
          "description": "Provides at least one method which aids in identifying the product in an asset database.",
          "minProperties": 1,
          "properties": {
            "cpe": {
              "description": "The Common Platform Enumeration (CPE) attribute refers to a method for naming platforms external to this specification.",
              "minLength": 5,
              "pattern": "^((cpe:2\\.3:[aho\\*\\-](:(((\\?*|\\*?)([a-zA-Z0-9\\-\\._]|(\\\\[\\\\\\*\\?!\"#\\$%&'\\(\\)\\+,\\/:;<=>@\\[\\]\\^`\\{\\|\\}~]))+(\\?*|\\*?))|[\\*\\-])){5}(:(([a-zA-Z]{2,3}(-([a-zA-Z]{2}|[0-9]{3}))?)|[\\*\\-]))(:(((\\?*|\\*?)([a-zA-Z0-9\\-\\._]|(\\\\[\\\\\\*\\?!\"#\\$%&'\\(\\)\\+,\\/:;<=>@\\[\\]\\^`\\{\\|\\}~]))+(\\?*|\\*?))|[\\*\\-])){4})|([c][pP][eE]:\\/[AHOaho]?(:[A-Za-z0-9\\._\\-~%]*){0,6}))$",
              "title": "Common Platform Enumeration representation",
              "type": "string"
            },
            "hashes": {
              "description": "Contains a list of cryptographic hashes usable to identify files.",
              "items": {
                "additionalProperties": false,
                "description": "Contains all information to identify a file based on its cryptographic hash values.",
                "properties": {
                  "file_hashes": {
                    "description": "Contains a list of cryptographic hashes for this file.",
                    "items": {
                      "additionalProperties": false,
                      "description": "Contains one hash value and algorithm of the file to be identified.",
                      "properties": {
                        "algorithm": {
                          "default": "sha256",
                          "description": "Contains the name of the cryptographic hash algorithm used to calculate the value.",
                          "examples": [
                            "blake2b512",
                            "sha256",
                            "sha3-512",
                            "sha384",
                            "sha512"
                          ],
                          "minLength": 1,
                          "title": "Algorithm of the cryptographic hash",
                          "type": "string"
                        },
                        "value": {
                          "description": "Contains the cryptographic hash value in hexadecimal representation.",
                          "examples": [
                            "37df33cb7464da5c7f077f4d56a32bc84987ec1d85b234537c1c1a4d4fc8d09dc29e2e762cb5203677bf849a2855a0283710f1f5fe1d6ce8d5ac85c645d0fcb3",
                            "4775203615d9534a8bfca96a93dc8b461a489f69124a130d786b42204f3341cc",
                            "9ea4c8200113d49d26505da0e02e2f49055dc078d1ad7a419b32e291c7afebbb84badfbd46dec42883bea0b2a1fa697c"
                          ],
                          "minLength": 32,
                          "pattern": "^[0-9a-fA-F]{32,}$",
                          "title": "Value of the cryptographic hash",
                          "type": "string"
                        }
                      },
                      "required": [
                        "algorithm",
                        "value"
                      ],
                      "title": "File hash",
                      "type": "object"
                    },
                    "minItems": 1,
                    "title": "List of file hashes",
                    "type": "array"
                  },
                  "filename": {
                    "description": "Contains the name of the file which is identified by the hash values.",
                    "examples": [
                      "WINWORD.EXE",
                      "msotadddin.dll",
                      "sudoers.so"
                    ],
                    "minLength": 1,
                    "title": "Filename",
                    "type": "string"
                  }
                },
                "required": [
                  "file_hashes",
                  "filename"
                ],
                "title": "Cryptographic hashes",
                "type": "object"
              },
              "minItems": 1,
              "title": "List of hashes",
              "type": "array"
            },
            "model_numbers": {
              "description": "Contains a list of full or abbreviated (partial) model numbers.",
              "items": {
                "description": "Contains a full or abbreviated (partial) model number of the component to identify.",
                "minLength": 1,
                "title": "Model number",
                "type": "string"
              },
              "minItems": 1,
              "title": "List of models",
              "type": "array",
              "uniqueItems": true
            },
            "purl": {
              "description": "The package URL (purl) attribute refers to a method for reliably identifying and locating software packages external to this specification.",
              "format": "uri",
              "minLength": 7,
              "pattern": "^pkg:[A-Za-z\\.\\-\\+][A-Za-z0-9\\.\\-\\+]*\\/.+",
              "title": "package URL representation",
              "type": "string"
            },
            "sbom_urls": {
              "description": "Contains a list of URLs where SBOMs for this product can be retrieved.",
              "items": {
                "description": "Contains a URL of one SBOM for this product.",
                "format": "uri",
                "title": "SBOM URL",
                "type": "string"
              },
              "minItems": 1,
              "title": "List of SBOM URLs",
              "type": "array"
            },
            "serial_numbers": {
              "description": "Contains a list of full or abbreviated (partial) serial numbers.",
              "items": {
                "description": "Contains a full or abbreviated (partial) serial number of the component to identify.",
                "minLength": 1,
                "title": "Serial number",
                "type": "string"
              },
              "minItems": 1,
              "title": "List of serial numbers",
              "type": "array",
              "uniqueItems": true
            },
            "skus": {
              "description": "Contains a list of full or abbreviated (partial) stock keeping units.",
              "items": {
                "description": "Contains a full or abbreviated (partial) stock keeping unit (SKU) which is used in the ordering process to identify the component.",
                "minLength": 1,
                "title": "Stock keeping unit",
                "type": "string"
              },
              "minItems": 1,
              "title": "List of stock keeping units",
              "type": "array"
            },
            "x_generic_uris": {
              "description": "Contains a list of identifiers which are either vendor-specific or derived from a standard not yet supported.",
              "items": {
                "additionalProperties": false,
                "description": "Provides a generic extension point for any identifier which is either vendor-specific or derived from a standard not yet supported.",
                "properties": {
                  "namespace": {
                    "description": "Refers to a URL which provides the name and knowledge about the specification used or is the namespace in which these values are valid.",
                    "format": "uri",
                    "title": "Namespace of the generic URI",
                    "type": "string"
                  },
                  "uri": {
                    "description": "Contains the identifier itself.",
                    "format": "uri",
                    "title": "URI",
                    "type": "string"
                  }
                },
                "required": [
                  "namespace",
                  "uri"
                ],
                "title": "Generic URI",
                "type": "object"
              },
              "minItems": 1,
              "title": "List of generic URIs",
              "type": "array"
            }
          },
          "title": "Helper to identify the product",
          "type": "object"
        }
      },
      "required": [
        "name",
        "product_id"
      ],
      "title": "Full product name",
      "type": "object"
    },
    "lang_t": {
      "description": "Identifies a language, corresponding to IETF BCP 47 / RFC 5646. See IETF language registry: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry",
      "examples": [
        "de",
        "en",
        "fr",
        "frc",
        "jp"
      ],
      "pattern": "^(([A-Za-z]{2,3}(-[A-Za-z]{3}(-[A-Za-z]{3}){0,2})?|[A-Za-z]{4,8})(-[A-Za-z]{4})?(-([A-Za-z]{2}|[0-9]{3}))?(-([A-Za-z0-9]{5,8}|[0-9][A-Za-z0-9]{3}))*(-[A-WY-Za-wy-z0-9](-[A-Za-z0-9]{2,8})+)*(-[Xx](-[A-Za-z0-9]{1,8})+)?|[Xx](-[A-Za-z0-9]{1,8})+|[Ii]-[Dd][Ee][Ff][Aa][Uu][Ll][Tt]|[Ii]-[Mm][Ii][Nn][Gg][Oo])$",
      "title": "Language type",
      "type": "string"
    },
    "notes_t": {
      "description": "Contains notes which are specific to the current context.",
      "items": {
        "additionalProperties": false,
        "description": "Is a place to put all manner of text blobs related to the current context.",
        "properties": {
          "audience": {
            "description": "Indicates who is intended to read it.",
            "examples": [
              "all",
              "executives",
              "operational management and system administrators",
              "safety engineers"
            ],
            "minLength": 1,
            "title": "Audience of note",
            "type": "string"
          },
          "category": {
            "description": "Contains the information of what kind of note this is.",
            "enum": [
              "description",
              "details",
              "faq",
              "general",
              "legal_disclaimer",
              "other",
              "summary"
            ],
            "title": "Note category",
            "type": "string"
          },
          "text": {
            "description": "Holds the content of the note. Content varies depending on type.",
            "minLength": 1,
            "title": "Note content",
            "type": "string"
          },
          "title": {
            "description": "Provides a concise description of what is contained in the text of the note.",
            "examples": [
              "Details",
              "Executive summary",
              "Technical summary",
              "Impact on safety systems"
            ],
            "minLength": 1,
            "title": "Title of note",
            "type": "string"
          }
        },
        "required": [
          "category",
          "text"
        ],
        "title": "Note",
        "type": "object"
      },
      "minItems": 1,
      "title": "List of notes",
      "type": "array"
    },
    "product_group_id_t": {
      "description": "Token required to identify a group of products so that it can be referred to from other parts in the document. There is no predefined or required format for the product_group_id as long as it uniquely identifies a group in the context of the current document.",
      "examples": [
        "CSAFGID-0001",
        "CSAFGID-0002",
        "CSAFGID-0020"
      ],
      "minLength": 1,
      "title": "Reference token for product group instance",
      "type": "string"
    },
    "product_groups_t": {
      "description": "Specifies a list of product_group_ids to give context to the parent item.",
      "items": {
        "$ref": "#/$defs/product_group_id_t"
      },
      "minItems": 1,
      "title": "List of product_group_ids",
      "type": "array",
      "uniqueItems": true
    },
    "product_id_t": {
      "description": "Token required to identify a full_product_name so that it can be referred to from other parts in the document. There is no predefined or required format for the product_id as long as it uniquely identifies a product in the context of the current document.",
      "examples": [
        "CSAFPID-0004",
        "CSAFPID-0008"
      ],
      "minLength": 1,
      "title": "Reference token for product instance",
      "type": "string"
    },
    "products_t": {
      "description": "Specifies a list of product_ids to give context to the parent item.",
      "items": {
        "$ref": "#/$defs/product_id_t"
      },
      "minItems": 1,
      "title": "List of product_ids",
      "type": "array",
      "uniqueItems": true
    },
    "references_t": {
      "description": "Holds a list of references.",
      "items": {
        "additionalProperties": false,
        "description": "Holds any reference to conferences, papers, advisories, and other resources that are related and considered related to either a surrounding part of or the entire document and to be of value to the document consumer.",
        "properties": {
          "category": {
            "default": "external",
            "description": "Indicates whether the reference points to the same document or vulnerability in focus (depending on scope) or to an external resource.",
            "enum": [
              "external",
              "self"
            ],
            "title": "Category of reference",
            "type": "string"
          },
          "summary": {
            "description": "Indicates what this reference refers to.",
            "minLength": 1,
            "title": "Summary of the reference",
            "type": "string"
          },
          "url": {
            "description": "Provides the URL for the reference.",
            "format": "uri",
            "title": "URL of reference",
            "type": "string"
          }
        },
        "required": [
          "summary",
          "url"
        ],
        "title": "Reference",
        "type": "object"
      },
      "minItems": 1,
      "title": "List of references",
      "type": "array"
    },
    "version_t": {
      "description": "Specifies a version string to denote clearly the evolution of the content of the document. Format must be either integer or semantic versioning.",
      "examples": [
        "1",
        "4",
        "0.9.0",
        "1.4.3",
        "2.40.0+21AF26D3"
      ],
      "pattern": "^(0|[1-9][0-9]*)$|^((0|[1-9]\\d*)\\.(0|[1-9]\\d*)\\.(0|[1-9]\\d*)(?:-((?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\\.(?:0|[1-9]\\d*|\\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\\+([0-9a-zA-Z-]+(?:\\.[0-9a-zA-Z-]+)*))?)$",
      "title": "Version",
      "type": "string"
    }
  },
  "$id": "https://docs.oasis-open.org/csaf/csaf/v2.0/csaf_json_schema.json",
  "$schema": "https://json-schema.org/draft/2020-12/schema",
  "additionalProperties": false,
  "description": "Representation of security advisory information as a JSON document.",
  "properties": {
    "document": {
      "additionalProperties": false,
      "description": "Captures the meta-data about this document describing a particular set of security advisories.",
      "properties": {
        "acknowledgments": {
          "$ref": "#/$defs/acknowledgments_t",
          "description": "Contains a list of acknowledgment elements associated with the whole document.",
          "title": "Document acknowledgments"
        },
        "aggregate_severity": {
          "additionalProperties": false,
          "description": "Is a vehicle that is provided by the document producer to convey the urgency and criticality with which the one or more vulnerabilities reported should be addressed. It is a document-level metric and applied to the document as a whole \u2014 not any specific vulnerability. The range of values in this field is defined according to the document producer's policies and procedures.",
          "properties": {
            "namespace": {
              "description": "Points to the namespace so referenced.",
              "format": "uri",
              "title": "Namespace of aggregate severity",
              "type": "string"
            },
            "text": {
              "description": "Provides a severity which is independent of - and in addition to - any other standard metric for determining the impact or severity of a given vulnerability (such as CVSS).",
              "examples": [
                "Critical",
                "Important",
                "Moderate"
              ],
              "minLength": 1,
              "title": "Text of aggregate severity",
              "type": "string"
            }
          },
          "required": [
            "text"
          ],
          "title": "Aggregate severity",
          "type": "object"
        },
        "category": {
          "description": "Defines a short canonical name, chosen by the document producer, which will inform the end user as to the category of document.",
          "examples": [
            "csaf_base",
            "csaf_security_advisory",
            "csaf_vex",
            "Example Company Security Notice"
          ],
          "minLength": 1,
          "pattern": "^[^\\s\\-_\\.](.*[^\\s\\-_\\.])?$",
          "title": "Document category",
          "type": "string"
        },
        "csaf_version": {
          "description": "Gives the version of the CSAF specification which the document was generated for.",
          "enum": [
            "2.0"
          ],
          "title": "CSAF version",
          "type": "string"
        },
        "distribution": {
          "additionalProperties": false,
          "description": "Describe any constraints on how this document might be shared.",
          "minProperties": 1,
          "properties": {
            "text": {
              "description": "Provides a textual description of additional constraints.",
              "examples": [
                "Copyright 2021, Example Company, All Rights Reserved.",
                "Distribute freely.",
                "Share only on a need-to-know-basis only."
              ],
              "minLength": 1,
              "title": "Textual description",
              "type": "string"
            },
            "tlp": {
              "additionalProperties": false,
              "description": "Provides details about the TLP classification of the document.",
              "properties": {
                "label": {
                  "description": "Provides the TLP label of the document.",
                  "enum": [
                    "AMBER",
                    "GREEN",
                    "RED",
                    "WHITE"
                  ],
                  "title": "Label of TLP",
                  "type": "string"
                },
                "url": {
                  "default": "https://www.first.org/tlp/",
                  "description": "Provides a URL where to find the textual description of the TLP version which is used in this document. Default is the URL to the definition by FIRST.",
                  "examples": [
                    "https://www.us-cert.gov/tlp",
                    "https://www.bsi.bund.de/SharedDocs/Downloads/DE/BSI/Kritis/Merkblatt_TLP.pdf"
                  ],
                  "format": "uri",
                  "title": "URL of TLP version",
                  "type": "string"
                }
              },
              "required": [
                "label"
              ],
              "title": "Traffic Light Protocol (TLP)",
              "type": "object"
            }
          },
          "title": "Rules for sharing document",
          "type": "object"
        },
        "lang": {
          "$ref": "#/$defs/lang_t",
          "description": "Identifies the language used by this document, corresponding to IETF BCP 47 / RFC 5646.",
          "title": "Document language"
        },
        "notes": {
          "$ref": "#/$defs/notes_t",
          "description": "Holds notes associated with the whole document.",
          "title": "Document notes"
        },
        "publisher": {
          "additionalProperties": false,
          "description": "Provides information about the publisher of the document.",
          "properties": {
            "category": {
              "description": "Provides information about the category of publisher releasing the document.",
              "enum": [
                "coordinator",
                "discoverer",
                "other",
                "translator",
                "user",
                "vendor"
              ],
              "title": "Category of publisher",
              "type": "string"
            },
            "contact_details": {
              "description": "Information on how to contact the publisher, possibly including details such as web sites, email addresses, phone numbers, and postal mail addresses.",
              "examples": [
                "Example Company can be reached at<EMAIL_ADDRESS>or via our website at https://www.example.com/contact."
              ],
              "minLength": 1,
              "title": "Contact details",
              "type": "string"
            },
            "issuing_authority": {
              "description": "Provides information about the authority of the issuing party to release the document, in particular, the party's constituency and responsibilities or other obligations.",
              "minLength": 1,
              "title": "Issuing authority",
              "type": "string"
            },
            "name": {
              "description": "Contains the name of the issuing party.",
              "examples": [
                "BSI",
                "Cisco PSIRT",
                "Siemens ProductCERT"
              ],
              "minLength": 1,
              "title": "Name of publisher",
              "type": "string"
            },
            "namespace": {
              "description": "Contains a URL which is under control of the issuing party and can be used as a globally unique identifier for that issuing party.",
              "examples": [
                "https://csaf.io",
                "https://www.example.com"
              ],
              "format": "uri",
              "title": "Namespace of publisher",
              "type": "string"
            }
          },
          "required": [
            "category",
            "name",
            "namespace"
          ],
          "title": "Publisher",
          "type": "object"
        },
        "references": {
          "$ref": "#/$defs/references_t",
          "description": "Holds a list of references associated with the whole document.",
          "title": "Document references"
        },
        "source_lang": {
          "$ref": "#/$defs/lang_t",
          "description": "If this copy of the document is a translation then the value of this property describes from which language this document was translated.",
          "title": "Source language"
        },
        "title": {
          "description": "This SHOULD be a canonical name for the document, and sufficiently unique to distinguish it from similar documents.",
          "examples": [
            "Cisco IPv6 Crafted Packet Denial of Service Vulnerability",
            "Example Company Cross-Site-Scripting Vulnerability in Example Generator"
          ],
          "minLength": 1,
          "title": "Title of this document",
          "type": "string"
        },
        "tracking": {
          "additionalProperties": false,
          "description": "Is a container designated to hold all management attributes necessary to track a CSAF document as a whole.",
          "properties": {
            "aliases": {
              "description": "Contains a list of alternate names for the same document.",
              "items": {
                "description": "Specifies a non-empty string that represents a distinct optional alternative ID used to refer to the document.",
                "examples": [
                  "CVE-2019-12345"
                ],
                "minLength": 1,
                "title": "Alternate name",
                "type": "string"
              },
              "minItems": 1,
              "title": "Aliases",
              "type": "array",
              "uniqueItems": true
            },
            "current_release_date": {
              "description": "The date when the current revision of this document was released",
              "format": "date-time",
              "title": "Current release date",
              "type": "string"
            },
            "generator": {
              "additionalProperties": false,
              "description": "Is a container to hold all elements related to the generation of the document. These items will reference when the document was actually created, including the date it was generated and the entity that generated it.",
              "properties": {
                "date": {
                  "description": "This SHOULD be the current date that the document was generated. Because documents are often generated internally by a document producer and exist for a nonzero amount of time before being released, this field MAY be different from the Initial Release Date and Current Release Date.",
                  "format": "date-time",
                  "title": "Date of document generation",
                  "type": "string"
                },
                "engine": {
                  "additionalProperties": false,
                  "description": "Contains information about the engine that generated the CSAF document.",
                  "properties": {
                    "name": {
                      "description": "Represents the name of the engine that generated the CSAF document.",
                      "examples": [
                        "Red Hat rhsa-to-cvrf",
                        "Secvisogram",
                        "TVCE"
                      ],
                      "minLength": 1,
                      "title": "Engine name",
                      "type": "string"
                    },
                    "version": {
                      "description": "Contains the version of the engine that generated the CSAF document.",
                      "examples": [
                        "0.6.0",
                        "1.0.0-beta+exp.sha.a1c44f85",
                        "2"
                      ],
                      "minLength": 1,
                      "title": "Engine version",
                      "type": "string"
                    }
                  },
                  "required": [
                    "name"
                  ],
                  "title": "Engine of document generation",
                  "type": "object"
                }
              },
              "required": [
                "engine"
              ],
              "title": "Document generator",
              "type": "object"
            },
            "id": {
              "description": "The ID is a simple label that provides for a wide range of numbering values, types, and schemes. Its value SHOULD be assigned and maintained by the original document issuing authority.",
              "examples": [
                "Example Company - 2019-YH3234",
                "RHBA-2019:0024",
                "cisco-sa-20190513-secureboot"
              ],
              "minLength": 1,
              "pattern": "^[\\S](.*[\\S])?$",
              "title": "Unique identifier for the document",
              "type": "string"
            },
            "initial_release_date": {
              "description": "The date when this document was first published.",
              "format": "date-time",
              "title": "Initial release date",
              "type": "string"
            },
            "revision_history": {
              "description": "Holds one revision item for each version of the CSAF document, including the initial one.",
              "items": {
                "additionalProperties": false,
                "description": "Contains all the information elements required to track the evolution of a CSAF document.",
                "properties": {
                  "date": {
                    "description": "The date of the revision entry",
                    "format": "date-time",
                    "title": "Date of the revision",
                    "type": "string"
                  },
                  "legacy_version": {
                    "description": "Contains the version string used in an existing document with the same content.",
                    "minLength": 1,
                    "title": "Legacy version of the revision",
                    "type": "string"
                  },
                  "number": {
                    "$ref": "#/$defs/version_t"
                  },
                  "summary": {
                    "description": "Holds a single non-empty string representing a short description of the changes.",
                    "examples": [
                      "Initial version."
                    ],
                    "minLength": 1,
                    "title": "Summary of the revision",
                    "type": "string"
                  }
                },
                "required": [
                  "date",
                  "number",
                  "summary"
                ],
                "title": "Revision",
                "type": "object"
              },
              "minItems": 1,
              "title": "Revision history",
              "type": "array"
            },
            "status": {
              "description": "Defines the draft status of the document.",
              "enum": [
                "draft",
                "final",
                "interim"
              ],
              "title": "Document status",
              "type": "string"
            },
            "version": {
              "$ref": "#/$defs/version_t"
            }
          },
          "required": [
            "current_release_date",
            "id",
            "initial_release_date",
            "revision_history",
            "status",
            "version"
          ],
          "title": "Tracking",
          "type": "object"
        }
      },
      "required": [
        "category",
        "csaf_version",
        "publisher",
        "title",
        "tracking"
      ],
      "title": "Document level meta-data",
      "type": "object"
    },
    "product_tree": {
      "additionalProperties": false,
      "description": "Is a container for all fully qualified product names that can be referenced elsewhere in the document.",
      "minProperties": 1,
      "properties": {
        "branches": {
          "$ref": "#/$defs/branches_t"
        },
        "full_product_names": {
          "description": "Contains a list of full product names.",
          "items": {
            "$ref": "#/$defs/full_product_name_t"
          },
          "minItems": 1,
          "title": "List of full product names",
          "type": "array"
        },
        "product_groups": {
          "description": "Contains a list of product groups.",
          "items": {
            "additionalProperties": false,
            "description": "Defines a new logical group of products that can then be referred to in other parts of the document to address a group of products with a single identifier.",
            "properties": {
              "group_id": {
                "$ref": "#/$defs/product_group_id_t"
              },
              "product_ids": {
                "description": "Lists the product_ids of those products which known as one group in the document.",
                "items": {
                  "$ref": "#/$defs/product_id_t"
                },
                "minItems": 2,
                "title": "List of Product IDs",
                "type": "array",
                "uniqueItems": true
              },
              "summary": {
                "description": "Gives a short, optional description of the group.",
                "examples": [
                  "Products supporting Modbus.",
                  "The x64 versions of the operating system."
                ],
                "minLength": 1,
                "title": "Summary of the product group",
                "type": "string"
              }
            },
            "required": [
              "group_id",
              "product_ids"
            ],
            "title": "Product group",
            "type": "object"
          },
          "minItems": 1,
          "title": "List of product groups",
          "type": "array"
        },
        "relationships": {
          "description": "Contains a list of relationships.",
          "items": {
            "additionalProperties": false,
            "description": "Establishes a link between two existing full_product_name_t elements, allowing the document producer to define a combination of two products that form a new full_product_name entry.",
            "properties": {
              "category": {
                "description": "Defines the category of relationship for the referenced component.",
                "enum": [
                  "default_component_of",
                  "external_component_of",
                  "installed_on",
                  "installed_with",
                  "optional_component_of"
                ],
                "title": "Relationship category",
                "type": "string"
              },
              "full_product_name": {
                "$ref": "#/$defs/full_product_name_t"
              },
              "product_reference": {
                "$ref": "#/$defs/product_id_t",
                "description": "Holds a Product ID that refers to the Full Product Name element, which is referenced as the first element of the relationship.",
                "title": "Product reference"
              },
              "relates_to_product_reference": {
                "$ref": "#/$defs/product_id_t",
                "description": "Holds a Product ID that refers to the Full Product Name element, which is referenced as the second element of the relationship.",
                "title": "Relates to product reference"
              }
            },
            "required": [
              "category",
              "full_product_name",
              "product_reference",
              "relates_to_product_reference"
            ],
            "title": "Relationship",
            "type": "object"
          },
          "minItems": 1,
          "title": "List of relationships",
          "type": "array"
        }
      },
      "title": "Product tree",
      "type": "object"
    },
    "vulnerabilities": {
      "description": "Represents a list of all relevant vulnerability information items.",
      "items": {
        "additionalProperties": false,
        "description": "Is a container for the aggregation of all fields that are related to a single vulnerability in the document.",
        "minProperties": 1,
        "properties": {
          "acknowledgments": {
            "$ref": "#/$defs/acknowledgments_t",
            "description": "Contains a list of acknowledgment elements associated with this vulnerability item.",
            "title": "Vulnerability acknowledgments"
          },
          "cve": {
            "description": "Holds the MITRE standard Common Vulnerabilities and Exposures (CVE) tracking number for the vulnerability.",
            "pattern": "^CVE-[0-9]{4}-[0-9]{4,}$",
            "title": "CVE",
            "type": "string"
          },
          "cwe": {
            "additionalProperties": false,
            "description": "Holds the MITRE standard Common Weakness Enumeration (CWE) for the weakness associated.",
            "properties": {
              "id": {
                "description": "Holds the ID for the weakness associated.",
                "examples": [
                  "CWE-22",
                  "CWE-352",
                  "CWE-79"
                ],
                "pattern": "^CWE-[1-9]\\d{0,5}$",
                "title": "Weakness ID",
                "type": "string"
              },
              "name": {
                "description": "Holds the full name of the weakness as given in the CWE specification.",
                "examples": [
                  "Cross-Site Request Forgery (CSRF)",
                  "Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')",
                  "Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')"
                ],
                "minLength": 1,
                "title": "Weakness name",
                "type": "string"
              }
            },
            "required": [
              "id",
              "name"
            ],
            "title": "CWE",
            "type": "object"
          },
          "discovery_date": {
            "description": "Holds the date and time the vulnerability was originally discovered.",
            "format": "date-time",
            "title": "Discovery date",
            "type": "string"
          },
          "flags": {
            "description": "Contains a list of machine readable flags.",
            "items": {
              "additionalProperties": false,
              "description": "Contains product specific information in regard to this vulnerability as a single machine readable flag.",
              "properties": {
                "date": {
                  "description": "Contains the date when assessment was done or the flag was assigned.",
                  "format": "date-time",
                  "title": "Date of the flag",
                  "type": "string"
                },
                "group_ids": {
                  "$ref": "#/$defs/product_groups_t"
                },
                "label": {
                  "description": "Specifies the machine readable label.",
                  "enum": [
                    "component_not_present",
                    "inline_mitigations_already_exist",
                    "vulnerable_code_cannot_be_controlled_by_adversary",
                    "vulnerable_code_not_in_execute_path",
                    "vulnerable_code_not_present"
                  ],
                  "title": "Label of the flag",
                  "type": "string"
                },
                "product_ids": {
                  "$ref": "#/$defs/products_t"
                }
              },
              "required": [
                "label"
              ],
              "title": "Flag",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of flags",
            "type": "array",
            "uniqueItems": true
          },
          "ids": {
            "description": "Represents a list of unique labels or tracking IDs for the vulnerability (if such information exists).",
            "items": {
              "additionalProperties": false,
              "description": "Contains a single unique label or tracking ID for the vulnerability.",
              "properties": {
                "system_name": {
                  "description": "Indicates the name of the vulnerability tracking or numbering system.",
                  "examples": [
                    "Cisco Bug ID",
                    "GitHub Issue"
                  ],
                  "minLength": 1,
                  "title": "System name",
                  "type": "string"
                },
                "text": {
                  "description": "Is unique label or tracking ID for the vulnerability (if such information exists).",
                  "examples": [
                    "CSCso66472",
                    "oasis-tcs/csaf#210"
                  ],
                  "minLength": 1,
                  "title": "Text",
                  "type": "string"
                }
              },
              "required": [
                "system_name",
                "text"
              ],
              "title": "ID",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of IDs",
            "type": "array",
            "uniqueItems": true
          },
          "involvements": {
            "description": "Contains a list of involvements.",
            "items": {
              "additionalProperties": false,
              "description": "Is a container, that allows the document producers to comment on the level of involvement (or engagement) of themselves or third parties in the vulnerability identification, scoping, and remediation process.",
              "properties": {
                "date": {
                  "description": "Holds the date and time of the involvement entry.",
                  "format": "date-time",
                  "title": "Date of involvement",
                  "type": "string"
                },
                "party": {
                  "description": "Defines the category of the involved party.",
                  "enum": [
                    "coordinator",
                    "discoverer",
                    "other",
                    "user",
                    "vendor"
                  ],
                  "title": "Party category",
                  "type": "string"
                },
                "status": {
                  "description": "Defines contact status of the involved party.",
                  "enum": [
                    "completed",
                    "contact_attempted",
                    "disputed",
                    "in_progress",
                    "not_contacted",
                    "open"
                  ],
                  "title": "Party status",
                  "type": "string"
                },
                "summary": {
                  "description": "Contains additional context regarding what is going on.",
                  "minLength": 1,
                  "title": "Summary of the involvement",
                  "type": "string"
                }
              },
              "required": [
                "party",
                "status"
              ],
              "title": "Involvement",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of involvements",
            "type": "array",
            "uniqueItems": true
          },
          "notes": {
            "$ref": "#/$defs/notes_t",
            "description": "Holds notes associated with this vulnerability item.",
            "title": "Vulnerability notes"
          },
          "product_status": {
            "additionalProperties": false,
            "description": "Contains different lists of product_ids which provide details on the status of the referenced product related to the current vulnerability. ",
            "minProperties": 1,
            "properties": {
              "first_affected": {
                "$ref": "#/$defs/products_t",
                "description": "These are the first versions of the releases known to be affected by the vulnerability.",
                "title": "First affected"
              },
              "first_fixed": {
                "$ref": "#/$defs/products_t",
                "description": "These versions contain the first fix for the vulnerability but may not be the recommended fixed versions.",
                "title": "First fixed"
              },
              "fixed": {
                "$ref": "#/$defs/products_t",
                "description": "These versions contain a fix for the vulnerability but may not be the recommended fixed versions.",
                "title": "Fixed"
              },
              "known_affected": {
                "$ref": "#/$defs/products_t",
                "description": "These versions are known to be affected by the vulnerability.",
                "title": "Known affected"
              },
              "known_not_affected": {
                "$ref": "#/$defs/products_t",
                "description": "These versions are known not to be affected by the vulnerability.",
                "title": "Known not affected"
              },
              "last_affected": {
                "$ref": "#/$defs/products_t",
                "description": "These are the last versions in a release train known to be affected by the vulnerability. Subsequently released versions would contain a fix for the vulnerability.",
                "title": "Last affected"
              },
              "recommended": {
                "$ref": "#/$defs/products_t",
                "description": "These versions have a fix for the vulnerability and are the vendor-recommended versions for fixing the vulnerability.",
                "title": "Recommended"
              },
              "under_investigation": {
                "$ref": "#/$defs/products_t",
                "description": "It is not known yet whether these versions are or are not affected by the vulnerability. However, it is still under investigation - the result will be provided in a later release of the document.",
                "title": "Under investigation"
              }
            },
            "title": "Product status",
            "type": "object"
          },
          "references": {
            "$ref": "#/$defs/references_t",
            "description": "Holds a list of references associated with this vulnerability item.",
            "title": "Vulnerability references"
          },
          "release_date": {
            "description": "Holds the date and time the vulnerability was originally released into the wild.",
            "format": "date-time",
            "title": "Release date",
            "type": "string"
          },
          "remediations": {
            "description": "Contains a list of remediations.",
            "items": {
              "additionalProperties": false,
              "description": "Specifies details on how to handle (and presumably, fix) a vulnerability.",
              "properties": {
                "category": {
                  "description": "Specifies the category which this remediation belongs to.",
                  "enum": [
                    "mitigation",
                    "no_fix_planned",
                    "none_available",
                    "vendor_fix",
                    "workaround"
                  ],
                  "title": "Category of the remediation",
                  "type": "string"
                },
                "date": {
                  "description": "Contains the date from which the remediation is available.",
                  "format": "date-time",
                  "title": "Date of the remediation",
                  "type": "string"
                },
                "details": {
                  "description": "Contains a thorough human-readable discussion of the remediation.",
                  "minLength": 1,
                  "title": "Details of the remediation",
                  "type": "string"
                },
                "entitlements": {
                  "description": "Contains a list of entitlements.",
                  "items": {
                    "description": "Contains any possible vendor-defined constraints for obtaining fixed software or hardware that fully resolves the vulnerability.",
                    "minLength": 1,
                    "title": "Entitlement of the remediation",
                    "type": "string"
                  },
                  "minItems": 1,
                  "title": "List of entitlements",
                  "type": "array"
                },
                "group_ids": {
                  "$ref": "#/$defs/product_groups_t"
                },
                "product_ids": {
                  "$ref": "#/$defs/products_t"
                },
                "restart_required": {
                  "additionalProperties": false,
                  "description": "Provides information on category of restart is required by this remediation to become effective.",
                  "properties": {
                    "category": {
                      "description": "Specifies what category of restart is required by this remediation to become effective.",
                      "enum": [
                        "connected",
                        "dependencies",
                        "machine",
                        "none",
                        "parent",
                        "service",
                        "system",
                        "vulnerable_component",
                        "zone"
                      ],
                      "title": "Category of restart",
                      "type": "string"
                    },
                    "details": {
                      "description": "Provides additional information for the restart. This can include details on procedures, scope or impact.",
                      "minLength": 1,
                      "title": "Additional restart information",
                      "type": "string"
                    }
                  },
                  "required": [
                    "category"
                  ],
                  "title": "Restart required by remediation",
                  "type": "object"
                },
                "url": {
                  "description": "Contains the URL where to obtain the remediation.",
                  "format": "uri",
                  "title": "URL to the remediation",
                  "type": "string"
                }
              },
              "required": [
                "category",
                "details"
              ],
              "title": "Remediation",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of remediations",
            "type": "array"
          },
          "scores": {
            "description": "Contains score objects for the current vulnerability.",
            "items": {
              "additionalProperties": false,
              "description": "Specifies information about (at least one) score of the vulnerability and for which products the given value applies.",
              "minProperties": 2,
              "properties": {
                "cvss_v2": {
                  "$ref": "https://www.first.org/cvss/cvss-v2.0.json"
                },
                "cvss_v3": {
                  "oneOf": [
                    {
                      "$ref": "https://www.first.org/cvss/cvss-v3.0.json"
                    },
                    {
                      "$ref": "https://www.first.org/cvss/cvss-v3.1.json"
                    }
                  ]
                },
                "products": {
                  "$ref": "#/$defs/products_t"
                }
              },
              "required": [
                "products"
              ],
              "title": "Score",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of scores",
            "type": "array"
          },
          "threats": {
            "description": "Contains information about a vulnerability that can change with time.",
            "items": {
              "additionalProperties": false,
              "description": "Contains the vulnerability kinetic information. This information can change as the vulnerability ages and new information becomes available.",
              "properties": {
                "category": {
                  "description": "Categorizes the threat according to the rules of the specification.",
                  "enum": [
                    "exploit_status",
                    "impact",
                    "target_set"
                  ],
                  "title": "Category of the threat",
                  "type": "string"
                },
                "date": {
                  "description": "Contains the date when the assessment was done or the threat appeared.",
                  "format": "date-time",
                  "title": "Date of the threat",
                  "type": "string"
                },
                "details": {
                  "description": "Represents a thorough human-readable discussion of the threat.",
                  "minLength": 1,
                  "title": "Details of the threat",
                  "type": "string"
                },
                "group_ids": {
                  "$ref": "#/$defs/product_groups_t"
                },
                "product_ids": {
                  "$ref": "#/$defs/products_t"
                }
              },
              "required": [
                "category",
                "details"
              ],
              "title": "Threat",
              "type": "object"
            },
            "minItems": 1,
            "title": "List of threats",
            "type": "array"
          },
          "title": {
            "description": "Gives the document producer the ability to apply a canonical name or title to the vulnerability.",
            "minLength": 1,
            "title": "Title",
            "type": "string"
          }
        },
        "title": "Vulnerability",
        "type": "object"
      },
      "minItems": 1,
      "title": "Vulnerabilities",
      "type": "array"
    }
  },
  "required": [
    "document"
  ],
  "title": "Common Security Advisory Framework",
  "type": "object"
}

It turned out that the data classes derived from the JSON schema are actually per default somewhat "strict", no matter whether the schema is.
This is due to the fact that, although generating classes allowing for additional properties (non-strict) is possible with the used plugin, the resulting code is by no means human-friendly and will probably cause virtually any normal JSON (de)serializer library for Java to fail.
For that reason, I suggest we do the sane approach of ignoring additional (useless) properties in input JSON when parsing.
I will close this issue for now.

@milux Can we get an info about which properties are ignored with kotlinx.serialization?

The default setting causes kotlinx.json to throw a JsonConvertException like so:
Caused by: io.ktor.serialization.JsonConvertException: Illegal input: Unexpected JSON token at offset 23: Encountered an unknown key 'foo' at path: $.document
Use 'ignoreUnknownKeys = true' in 'Json {}' builder to ignore unknown keys.
JSON input: {
  "document": {
    "foo": "bar",
    "aggregate_se.....
	at _COROUTINE._BOUNDARY._(CoroutineDebugging.kt:42)
	at io.ktor.client.HttpClient$4.invokeSuspend(HttpClient.kt:177)
	at io.ktor.client.plugins.HttpCallValidator$Companion$install$2.invokeSuspend(HttpCallValidator.kt:142)
	at io.ktor.client.call.HttpClientCall.bodyNullable(HttpClientCall.kt:89)
	at io.github.csaf.sbom.retrieval.CsafLoader$fetchDocument$2.invokeSuspend(CsafLoader.kt:170)

Thus, we already have the default-fail behavior as intended.
If additional properties are to be allowed, this can be accomplished by setting ignoreUnknownKeys = true in JsonBuilder.

We leave it in its default behavior - doing strict only. Please add a test to make sure that the error gets thrown (as this will help us to remember the decision and not accidentally merge a PR that changes that decision. Also it will help detect if the dependency changes its behavior).


Feature/testing mail services

Hi Esteve, I added a few tests for your API.
Also i have fixed in your createMail() exception that condition if the username is already repeated as it will never happen because the message("hydra:description") you expected "The username is already in use" its not what our provider give us, here you have a proof:

The other part of the PR is the tests i added. I do know that when im testing i should not touch anything from the code nor change it but it was something that had to be fixed

I have pushed new changes


style(mesos): check for static go binaries

The mesos binaries are built as static, so this adds the silent double-check that is done in all other cases.

Code LGTM.

code LGTM


fix: simple state mapping routeToState function throw an error when state is null

Summary
Context
This PR fixes an issue related to the routing when using React InstantSearch Hooks with React Router.
FX-1925
Error reproduction
Using the default state mapping function, an error is thrown only on back navigation from a refined state, when reaching the initial / unrefined state:
defaultStateMapping.ts:10 Uncaught TypeError: Cannot destructure property 'configure' of 'uiState' as it is null.
    at getIndexStateWithoutConfigure (defaultStateMapping.ts:10:11)
    at defaultStateMapping.ts:36:24
    at Array.reduce (<anonymous>)
    at Object.routeToState (defaultStateMapping.ts:32:38)
    at createRouterMiddleware.js:45:57
    at _onPopState (history.js:140:11)

CodeSandbox error reproduction: https://codesandbox.io/s/rish-with-react-router-simple-state-mapping-error-k6xqkn
Video reproduction of the error:
https://user-images.githubusercontent.com/662153/206485747-ef4b2045-c5ac-470b-9799-45063a3d7216.mov
Cause of the issue
When you navigate to the /search route, React Router push some history state data along with the new URL:
{ usr: null, key: '4ykrr3bq' }

In the simple state mapping function, in the routeToState function, we reduce the history state assuming the key is the indexId and the value is the state. But using React Router, the first key is usr, so the corresponding value null is passed to the getIndexStateWithoutConfigure function.
https://github.com/algolia/instantsearch.js/blob/8c68f37364f4199b9be76fa7ddd3fc1aea596d6a/packages/instantsearch.js/src/lib/stateMappings/simple.ts#L27-L35
This function then tries to deconstruct the configure object from the uiState but since it's null, it throws an error.
https://github.com/algolia/instantsearch.js/blob/8c68f37364f4199b9be76fa7ddd3fc1aea596d6a/packages/instantsearch.js/src/lib/stateMappings/simple.ts#L3-L8
Result
We always read the state from the URL because the state of the history can be incorect in some cases (e.g. using React Router) so no more error is thrown.

It’s an interesting solution, and we probably should do this, but it makes me think again that the branch we have in onPopState of history router should probably ignore the history.state but always .read instead. It’s not so expensive and always going to be right (unlike history state that can be messed with)

this could be useful, but I think we should fix the read function instead. Are you taking that up @FabienMotte ?

I updated the fix, test and the PR description (results section). WDYT?


AttributeError: 'Tensor' object has no attribute 'assign'

I installed all the packages as mentioned in your requirements.txt. I am having error in model.fit_generator
 line 687, in train_model     workers=6,epochs=1)   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper     return func(*args, **kwargs)   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/engine/training.py", line 2080, in fit_generator     self._make_train_function()   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/engine/training.py", line 990, in _make_train_function     loss=self.total_loss)   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper     return func(*args, **kwargs)   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/optimizers.py", line 257, in get_updates     self.updates.append(K.update(a, new_a))   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/keras/backend/tensorflow_backend.py", line 963, in update     return tf.assign(x, new_x)   File "/home/rohit/home/Development/Test/03042019/project1_env/lib/python3.6/site-packages/tensorflow/python/ops/state_ops.py", line 284, in assign     return ref.assign(value, name=name)

Same here. Were you able to overcome the error?

It's likely an issue with the compiled embeddings. If you

remove the embeddings db by the command:

rm -rf data/db/EMBEDDINGS_NAME

double check the path to the embeddings path you are using in embedding-registry.json

and restart

does it work after compiling the embeddings?
I will implement some further consistency check on the embeddings DB, embeddings path, and some automated internet download of the embeddings, which should prevent these kind of issues.

I got that error when list_classes was empty

I think this issue is obsolete and can be closed

I don't remember when, but I added a check on the validity of a compiled embeddings db, so that problem should be solved.
But I don't know if the error is really related to this.
Nothing was done about testing empty list_classes I think.


Readme: Add info about creating the PAT

Hey, thanks for this action!
I'm currently trying to use it and I noticed that in the README there's no mention of how to create the REPOSITORY_PAT secret.
By looking at your code and the GitHub documentation I figured out that the required permission for the PAT is probably Administration, but that'd be cool if it was mentioned directly in the README.
Thanks!

Done


Thanos Compact gets internal server error, when is facing context canceled from Storage Provider

Thanos, Prometheus and Golang version used:
Thanos Version 0.22
Prometheus: 2.27

Object Storage Provider: Microsoft Azure
What happened: Thanos Compact gets internal server error, when is facing context canceled from Storage Provider
What you expected to happen: Retry an keep health
How to reproduce it (as minimally and precisely as possible): There is no a specific scenario, I just start to face this error after update to version 0.22
Full logs to relevant components:
level=info ts=2021-09-21T13:37:30.172907505Z caller=factory.go:46 msg="loading bucket configuration"
level=info ts=2021-09-21T13:37:30.679158689Z caller=compact.go:556 msg="starting compact node"
level=info ts=2021-09-21T13:37:30.679202292Z caller=intrumentation.go:48 msg="changing probe status" status=ready
level=info ts=2021-09-21T13:37:30.679450812Z caller=intrumentation.go:60 msg="changing probe status" status=healthy
level=info ts=2021-09-21T13:37:30.679477414Z caller=http.go:63 service=http/server component=compact msg="listening for requests and metrics" address=<IP_ADDRESS>:10902
level=info ts=2021-09-21T13:37:30.679994754Z caller=tls_config.go:191 service=http/server component=compact msg="TLS is disabled." http2=false
level=info ts=2021-09-21T13:37:30.680282777Z caller=compact.go:948 msg="start sync of metas"
level=info ts=2021-09-21T13:40:49.566485486Z caller=main.go:167 msg="caught signal. Exiting." signal=terminated
level=warn ts=2021-09-21T13:40:49.56655559Z caller=intrumentation.go:54 msg="changing probe status" status=not-ready reason=null
level=info ts=2021-09-21T13:40:49.566569191Z caller=http.go:74 service=http/server component=compact msg="internal server is shutting down" err=null
level=info ts=2021-09-21T13:40:50.065939201Z caller=http.go:93 service=http/server component=compact msg="internal server is shutdown gracefully" err=null
level=info ts=2021-09-21T13:40:50.065987104Z caller=intrumentation.go:66 msg="changing probe status" status=not-healthy reason=null
level=error ts=2021-09-21T13:40:50.27341152Z caller=compact.go:488 msg="retriable error" err="compaction: sync: BaseFetcher: iter bucket: context canceled"
level=error ts=2021-09-21T13:40:50.273894348Z caller=runutil.go:101 msg="function failed. Retrying in next tick" err="BaseFetcher: iter bucket: cannot list hierarchy blobs with prefix  (iteration #1): Get \"https://storage.blob.core.windows.net/container?comp=list&delimiter=%2F&restype=container&timeout=61\": context canceled"
level=info ts=2021-09-21T13:40:50.273937051Z caller=main.go:159 msg=exiting

Anything else we need to know:

This component is running on Azure Kubernetes Service
CNCF Thanos Slack Channel Thread

I'm seeing something similar to this on 0.22 as well
level=info ts=2021-09-14T00:42:00.064565662Z caller=fetcher.go:476 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=805.474531ms cached=1284 returned=1284 partial=0
level=warn ts=2021-09-14T00:42:03.017083892Z caller=intrumentation.go:54 msg="changing probe status" status=not-ready reason=null
level=info ts=2021-09-14T00:42:03.017118393Z caller=http.go:74 service=http/server component=compact msg="internal server is shutting down" err=null
level=error ts=2021-09-14T00:42:03.017273796Z caller=compact.go:488 msg="retriable error" err="syncing metas: filter metas: filter blocks marked for deletion: get file: 01FFC1B5V5CMHQN05DMBC9105N/deletion-mark.json: cannot get blob reader: 01FFC1B5V5CMHQN05DMBC9105N/deletion-mark.json: cannot get properties for Azure blob, address: 01FFC1B5V5CMHQN05DMBC9105N/deletion-mark.json: Head \"https://<redacted>.blob.core.windows.net/thanos/01FFC1B5V5CMHQN05DMBC9105N/deletion-mark.json?timeout=61\": dial tcp <IP_ADDRESS>:443: connect: cannot assign requested address"
level=info ts=2021-09-14T00:42:03.019124632Z caller=http.go:93 service=http/server component=compact msg="internal server is shutdown gracefully" err=null
level=info ts=2021-09-14T00:42:03.019148232Z caller=intrumentation.go:66 msg="changing probe status" status=not-healthy reason=null
level=info ts=2021-09-14T00:42:03.019185833Z caller=main.go:159 msg=exiting

This doesn't happen on 0.21, very odd.

By default thanos compact will run to completion which makes it possible to execute in a cronjob. Using the arguments --wait and --wait-interval=5m it’s possible to keep it running.

https://thanos.io/tip/components/compact.md/#compactor

By default thanos compact will run to completion which makes it possible to execute in a cronjob. Using the arguments --wait and --wait-interval=5m it’s possible to keep it running.

https://thanos.io/tip/components/compact.md/#compactor

I'm already running the --wait flag and have for quite awhile, not sure if that changed in 0.22?
  - args:
    - compact
    - --log.level=info
    - --log.format=logfmt
    - --http-address=<IP_ADDRESS>:10902
    - --objstore.config-file=/etc/config/object-store.yaml
    - --data-dir=/var/thanos/compact
    - --consistency-delay=30m
    - --retention.resolution-raw=30d
    - --retention.resolution-5m=120d
    - --retention.resolution-1h=1y
    - --block-sync-concurrency=20
    - --compact.concurrency=1
    - --wait

I'm using the same strategy that @Aaron-ML is using and even on version 0.20.1, I'm facing errors that could be handled by retrying the operation.
level=info ts=2021-09-30T07:02:29.072136538Z caller=factory.go:46 msg="loading bucket configuration"
level=info ts=2021-09-30T07:02:29.56787006Z caller=compact.go:539 msg="starting compact node"
level=info ts=2021-09-30T07:02:29.567916963Z caller=intrumentation.go:48 msg="changing probe status" status=ready
level=info ts=2021-09-30T07:02:29.568176778Z caller=intrumentation.go:60 msg="changing probe status" status=healthy
level=info ts=2021-09-30T07:02:29.568213681Z caller=http.go:62 service=http/server component=compact msg="listening for requests and metrics" address=<IP_ADDRESS>:10902
level=info ts=2021-09-30T07:02:29.568552701Z caller=compact.go:942 msg="start sync of metas"
level=info ts=2021-09-30T07:02:39.183579477Z caller=fetcher.go:476 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=9.614692056s cached=348 returned=348 partial=0
level=info ts=2021-09-30T07:02:57.97161771Z caller=fetcher.go:476 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=18.698576374s cached=348 returned=348 partial=0
level=info ts=2021-09-30T07:03:11.869691052Z caller=main.go:167 msg="caught signal. Exiting." signal=terminated
level=warn ts=2021-09-30T07:03:11.869753456Z caller=intrumentation.go:54 msg="changing probe status" status=not-ready reason=null
level=info ts=2021-09-30T07:03:11.869770557Z caller=http.go:69 service=http/server component=compact msg="internal server is shutting down" err=null
level=info ts=2021-09-30T07:03:11.874936563Z caller=http.go:88 service=http/server component=compact msg="internal server is shutdown gracefully" err=null
level=info ts=2021-09-30T07:03:11.874965165Z caller=intrumentation.go:66 msg="changing probe status" status=not-healthy reason=null
level=error ts=2021-09-30T07:03:12.368622077Z caller=compact.go:468 msg="retriable error" err="compaction: sync: filter metas: filter blocks marked for no compaction: get file: 01G4E4NFP77YFEJES4E63TB07S/no-compact-mark.json: cannot get blob reader: 01F4E3NCP77YFEJES3E63TF07S/no-compact-mark.json: cannot get properties for Azure blob, address: 01F4E3NCP77YFEJES4E63TB07S/no-compact-mark.json: -> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/circleci/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.2/pipeline/error.go:154\nHTTP request failed\n\nHead \"https://<storage>.blob.core.windows.net/container/01F4E3NCP77YFEJES4E63TB07S/no-compact-mark.json?timeout=61\": context canceled\n"
level=info ts=2021-09-30T07:03:12.369028801Z caller=main.go:159 msg=exiting

Is it good to close the issue now? @nicolastakashi

Hi @yeya24 from my side it looks Ok!


feat: Add support for blockchainAccountId

Closes: https://github.com/hypersign-protocol/hid-node/issues/57
This PR aims to introduce support for blockchainAccountId, where users can pass blockchain addresses instead of a public key, to validate a recoverable signature. This PR aims to support only EVM based address at the moment.
The e2e test report for x/ssi module is attached. Test Cases TC-10 and TC-11 has been written for the feature of this PR
e2e_ssi_module_test_report.txt

@Vishwas1 There is one change that is needed to be pushed, based on an observation from running a Client Side Application for signing the DID Document using Metamask
The personal_sign method only accepts the message as a string input, which is why we JSON.stringify() the DID Doc before passing it to the method. However, on the blockchain end, in its current implementation, the serialisation of DID Doc happens based binary encoding, because of which the message is interprated differently here.
In order to solve it, the didDoc object on hid-node has to serialised using JSON Marshaller, instead of Proto Marshaller. This will be only specific for Ethereum based addresses only.

personal_sign (https://docs.metamask.io/guide/signing-data.html#personal-sign) support has been added as a clientSpec for SSI Docs.


Fix a bug in updateBackReferenceVersions that could skip updating a back-reference branch.

@trxcllnt nice!

@trxcllnt Arrg!!! I hit the wrong button before being done here.  You forgot to add a unit test to confirm this behavior / shed light onto what you fixed.


Update values schema

App CR fails on CR because:
status:
  appVersion: ""
  release:
    lastDeployed: null
    reason: 'invalid manifest error: (unable to build kubernetes objects from release
      manifest: unable to recognize "": no matches for kind "PolicyException" in version
      "kyverno.io/v2alpha1")'
    status: invalid-manifest
  version: ""


Not compatible with Alamofire 5

as this seems no longer to be maintained, I updated my fork to work with alamofire 5 and swift 5.2: https://github.com/robertjanetzko/PMKAlamofire

as this seems no longer to be maintained, I updated my fork to work with alamofire 5 and swift 5.2: https://github.com/robertjanetzko/PMKAlamofire

Hello Robert, I'm having issues with 'PromiseKit/Alamofire', I'm new to cocoa pods, can you explain to me how to use your fork?, I'm following the steps in your documentation but I'm still getting the error (Alamofire 4 required)
this is how my Podfile looks like:
pod 'Alamofire', '~> 5.1'
  pod 'AlamofireImage', '~> 4.1'
  pod 'Moya', '~> 14'
  pod 'PromiseKit', '~> 6'
  pod 'PromiseKit/Alamofire', '~> 6.0'
  pod 'RxSwift', '~> 5.1'
  pod 'RxCocoa', '~> 5.1'
  pod 'Moya/RxSwift', '~> 14'

Thanks.

according to https://guides.cocoapods.org/using/the-podfile.html (section "From a podspec in the root of a library repo") I think you should use:
pod 'PromiseKit/Alamofire', :git => 'https://github.com/robertjanetzko/PMKAlamofire.git'
but I only use carthage, so I didn't test it with cocoapods

Thanks for doing this!
Any way around the cocoapods error, other than downloading?
[!] There are multiple dependencies with different sources for `PromiseKit` in `Podfile`:

- PromiseKit/CorePromise
- PromiseKit/Alamofire (from `https://github.com/robertjanetzko/PMKAlamofire.git`)

Switching to Swift Package Manager for this still presents a conflict:
because PMKAlamofire >=3.2.2 depends on Alamofire 4.0.0..<5.0.0 and root depends on Alamofire 5.2.1..<6.0.0, PMKAlamofire >=3.2.2 is forbidden.
And because root depends on PMKAlamofire 3.2.4..<4.0.0, version solving failed.

@robertjanetzko your Package.swift looks correct. Any suggestions for me?

Hi everyone!
Any news on conversion to Swift 5.3 with library update?

We could add a new subspec for Alamofire 5.
This is a trivial task that anyone could have done by now. This is pretty low on my task list.

Latest version is depending on Alamofire 4.9.1, instead of more current 5.x.

lol I suck.
PR welcome. Again.

Will you update the latest version? @mxcl

I haven't worked with Swift in 3 years so I'm honestly not convinced I am qualified at this point.


doc: Examples for REST API usage of argo-server

Checklist:

[ c] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[ b] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[ not applicable] I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
[ ] Optional. I've added My organization is added to the USERS.md.
[not applicable ] I've signed the CLA and required builds are green.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign CLA.


Make DNS proxying more resilient to DNS errors/latency

Describe the feature request
Use a smarter selection algorithm when proxying DNS requests upstream serially. Examples include using the original destination IP or randomly iterating through the list of servers.
Describe alternatives you've considered

Enable DNS_FORWARD_PARALLEL=true, which could multiply load on DNS servers
Don't use iptables but directly add dns proxy ip to the list of resolvers in the application task

Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[x] Virtual Machine
[ ] Multi Control Plane
Additional context
The current algorithm with DNS_FORWARD_PARALLEL=false (the default) iterates through the nameservers listed in /etc/resolv.conf in the order that they appear. This can result in the application being more sensitive to DNS errors.
High Latency Scenario

Application queries the first nameserver
DNS proxy captures request and forwards request to the first nameserver
First name server times out (e.g. due to a DDoS) and proxy tries the second server, but the application already timed out
Application queries the second nameserver
DNS proxy captures request and forwards request to the first nameserver again
First name server times out again

Example of above. The p99 resolution time jumps to >5s (the hardcoded dns client timeout) when the server is not stable.
Theoretical Erroneous DNS response Scenario

[!WARNING]
Not actually observed yet

Application queries the first nameserver
DNS proxy captures request and forwards request to the first nameserver
First name server replies with NXDOMAIN
Application queries the second nameserver
DNS proxy captures request and forwards request to the first nameserver again
First name server replies with NXDOMAIN as well while second name server would have responded with A/AAAA/etc...

Potential pitfall of using SO_ORIGINAL_DST is a race condition in UDP. TPROXY could guarantee the correct behavior. Probably best for now to simply randomize the dns querying.


GH-35331: [Python] Expose Parquet sorting metadata

Rationale for this change
Picking up where #35453 left off.
Closes https://github.com/apache/arrow/issues/35331
This PR builds on top of #37469

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Closes: #35331

@mapleFU Could you also take a look at this PR when you get a chance?

Ooops seems CI failed.
I'm a little busy this week, but I'll take a glance later this week :-) Maybe you can call other for review if it's hurry

Ooops seems CI failed.
I'm a little busy this week, but I'll take a glance later this week :-) Maybe you can call other for review if it's hurry

Sorry! Will do.

A rebase seems to have fixed the failing tests and now it is just AppVeyor failing (which I think is unrelated to these changes). Could someone please review this when they get the chance?

cc @AlenkaF @jorisvandenbossche

Any more work on this? would be a great addition

Any more work on this? would be a great addition

Think this is just waiting for review

@judahrand Would you mind rebase this? I forgot to move this patch forward, I'll move it forward after rebase

Ping @jorisvandenbossche

Gentle ping @jorisvandenbossche

@AlenkaF would you like to move it forward? Or lets wait after January

Will wait till tomorrow for any comments otherwise I think this could get merged 👍

Just one small comment before we merge: https://github.com/apache/arrow/pull/37665#discussion_r1431296481

Good


Ibex does not reflect instruction memory changes to ICache

If ICache is enabled and a write to a cached instruction memory (which we are allowed to do) occurred, Ibex does not let ICache know such a store happened. As a result, cached instruction will not change inside ICache (but it will change in the memory component) and when PC will point to that address, Ibex will use the cached instruction. That causes mismatches between ISS and RTL.
It is probably not the most important corner case but I thought it might be good to document it as an issue for future.

This sounds like one of the 2 hard problems in computer science.

It's acceptable for our icache to not be coherent so I'd wouldn't class this as an RTL bug, more a documentation issue.
Though we probably shouldn't be overwriting code in RISCV-DV generated programs.


feat: support worker in worker

todo

[x] dev
[x] build

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#119  👈
#118
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite

Merge activity

Sep 29, 5:02 AM EDT: @hi-ogawa started a stack merge that includes this pull request via Graphite.


Fixed delete project member functionality

Description
The delete project member functionality was not working. Fixed it with the following measures -

Corrected the route name and data sent in the request to work with Flask API.
If some other project member had the same name as you, the delete option wouldn't show up at all. Fixed it by using email instead of name for comparison, as email will always be unique.

Fixes #552
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go to Projects section
Open a project
Try to delete a member other than yourself

Test Configuration:

Realme 3 Pro
Android 10

https://user-images.githubusercontent.com/45410599/107111878-7c428d80-6879-11eb-8b89-752a5d46fe31.mp4
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

nice work 👍🏻 we'll merge this for now since it fixes an obvious bug. but we need to restrict who can delete or not project members in the future.

Yeah I think the API route checks if the one deleting is an admin or not. But we can add a check in the app so that the delete option in a project is visible only if you're an admin. I'll try to submit a PR for it soon. 👍🏻


log_view: 0.1.2-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository log_view to 0.1.2-1:

upstream repository: https://github.com/hatchbed/log_view.git
release repository: https://github.com/hatchbed/log_view-release.git
distro file: noetic/distribution.yaml
bloom version: 0.10.0
previous version for package: null

log_view
* Install binary log_viewer to package destination instead of global destination.
* Contributors: Marc Alban

holding for the upcoming Noetic sync


[Feature Request]: Adding Cursor Animation

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I would like to add cursor animation to make website more attractive and professional.
Use Case
To make website more attractive and professional.
Benefits
Enhance the user experience .
Add ScreenShots

https://github.com/Trisha-tech/OnlineBookSales/assets/169483518/cad3bec8-4d63-4f25-8aa3-1d3b8e6edd0d
Priority
Medium
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

SagarRathore1

Hello @SagarRathore1 , Go for it
All the Best


[#1149] enable ncdump command

@mjstealey would you please code review it and +1 if it is OK for merge? Thanks

Can one of the admins verify this patch?

+1


Add spf13/cobra instructions in README

This PR adds a little notice to explain how to use Cobra in the README and in the godoc of pflag.WithFlagSet.
At first I thought it was not supported, I tried to use the pflag loader without the WithFlagSet option and got errors (undefined flag xxx), so I think it might be helpful to add this info.
Let me know if the format doesn't suits you or if you have any other suggestion.
Thanks!

Thanks for the PR. I am thinking if we should mention cobra in both readme and go doc? Or only in readme since it’s just a use case for WithFlagSet? What’s your thought?

Thanks for your quick feedback!
I originally added it only in the README and then made a new commit for the godoc, but yeah it might be enough in the README. I will revert the commit.

Thanks for your quick feedback! I originally added it only in the README and then made a new commit for the godoc, but yeah it might be enough in the README, and keep the go doc "pure". I will revert the commit.

Cool. Thanks


instagram call checkpoint required

what is an " instagram call checkpoint " ?????????

Its for me too, just said "Instagram call checkpoint for this action!" :sob: :sob:

temparaily disable your account, wait 2-3 hours then try again.
DONT sign in before doing that.
On Sat, Aug 11, 2018 at 3:10 AM, Abadin420<EMAIL_ADDRESS>wrote:

Its for me too, just said "Instagram call checkpoint for this action!" 😭
😭
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ifedapoolarewaju/igdm/issues/483#issuecomment-412259606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoTQE7Hv_UVWyoI1Q2qYELms24PnJ0cQks5uPpFmgaJpZM4V3f8D
.

And how you temporarily disable your account? i don't know how to do that

go on your profile. Click “edit profile”. Scroll down and click “temporarily disable account”.select “just need a break”.
Sent from Mail for Windows 10
From: barb.183
Sent: August 18, 2018 7:30 PM
To: ifedapoolarewaju/igdm
Cc: Brookelynn Barry; Author
Subject: Re: [ifedapoolarewaju/igdm] instagram call checkpoint required (#483)
And how you temporarily disable your account? i don't know how to do that
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Request for Deletion of Jenkins Jobs

The following Jenkins Jobs were created by accident when a script failed to strip out the spaces before concatenating strings.
A PR to fix the "trimming" issue is currently awaiting review, but for now can the jobs with the spaces in their names be deleted, please?

Test_openjdk15_j9_special.functional_ s390x_linux_xl
Test_openjdk15_j9_special.functional_ ppc64le_linux_xl
Test_openjdk15_j9_sanity.openjdk_ s390x_linux_xl
Test_openjdk15_j9_sanity.system_ ppc64le_linux_xl
Test_openjdk15_j9_extended.system_ ppc64le_linux_xl
Test_openjdk15_j9_sanity.openjdk_ ppc64le_linux_xl
Test_openjdk15_j9_sanity.perf_ ppc64le_linux_xl
Test_openjdk15_j9_sanity.system_ s390x_linux_xl
Test_openjdk15_j9_extended.system_ s390x_linux_xl
Test_openjdk15_j9_extended.perf_ ppc64le_linux_xl
Test_openjdk15_j9_extended.perf_ s390x_linux_xl
Test_openjdk15_j9_extended.openjdk_ ppc64le_linux_xl
Test_openjdk15_j9_sanity.perf_ s390x_linux_xl
Test_openjdk15_j9_extended.openjdk_ s390x_linux_xl

P.S. I've already created the jobs with the correct names (no spaces).
P.P.S. Please do not accidentally delete the jobs that have no spaces in their names.

I've gone through and disabled all the jobs with spaces in them. I don't have permissions to delete them unfortunately.

Thanks @Willsparker
Will leave this open until someone with the right access can delete them.

Done (removed the directories from the jenkins server filesystem as that was easier than trying to find them all!)


Wrong version number in setup.py?

I am confused because I installed azint according to the manual. Pip list shows me version 0.8.4 and conda list shows 0.8.5.
I looked at https://github.com/maxiv-science/azint/blob/master/setup.py on the master branch.
There is version 0.8.4 given, but the master branch tag is 0.8.5. Is this why I see different versions?
Related to this question, how can I check for azint the version number in Jupyter, please? To the best of my knowledge there is no azint.__version__
Thank you.

thanks that is fixed with the move to setuptools_scm and there is now also azint.version


typo: permision -> permission

@nschonni : Thanks for your contribution! The author, @jpconnock, has been notified to review your proposed change.

@nschonni : Thanks for your contribution! The author, @jpconnock, has been notified to review your proposed change.

@tfosmark Why did you merge this? The typo he corrected will break a URL.

It was an internal markdown link placeholder reference not anything public facing


[SPARK-14669] [SQL] Fix some SQL metrics in codegen and added more

What changes were proposed in this pull request?

Fix the "spill size" of TungstenAggregate and Sort
Rename "data size" to "peak memory" to match the actual meaning (also consistent with task metrics)
Added "data size" for ShuffleExchange and BroadcastExchange
Added some timing for Sort, Aggregate and BroadcastExchange (this requires another patch to work)

How was this patch tested?
Existing tests.

cc @zsxwing

Test build #55954 has started for PR 12425 at commit a9b29e2.

Test build #55954 has finished for PR 12425 at commit a9b29e2.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55954/
Test FAILed.

Test build #55957 has started for PR 12425 at commit 1378dd2.

Test build #55957 has finished for PR 12425 at commit 1378dd2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55957/
Test FAILed.

Test build #55970 has started for PR 12425 at commit 696aafe.

Should we also add a metric for dataSize, since peak memory usage might not be quite the same? Though maybe adding up peak memory and spill size is a good approximation.

Test build #55970 has finished for PR 12425 at commit 696aafe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55970/
Test PASSed.

@ericl Exchange has dataSize, should that be enough?

I slightly prefer to have dataSize in the following stage so all the relevant metrics are together, but having it in Exchange seems ok too.

cc @sameeragarwal Could you also take a look?

Test build #56654 has started for PR 12425 at commit cc65830.

@zsxwing Addressed you comments.

Test build #56654 has finished for PR 12425 at commit cc65830.

This patch fails build dependency tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56654/
Test FAILed.

Test build #56656 has started for PR 12425 at commit 1076c75.

Test build #56656 has finished for PR 12425 at commit 1076c75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56656/
Test PASSed.

Test build #56712 has started for PR 12425 at commit faeb593.

LGTM. +1 on having tests arounds metrics.

Test build #56712 has finished for PR 12425 at commit faeb593.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56712/
Test PASSed.

Merged build finished. Test PASSed.

Merging this into master, thanks!


fix: Devtools breaks unimport-vue-i18n when using HTML in string translations

🐛 The bug
Vue-i18n allows HTML in string translations by setting strictMessage: false in the config. This allows users to easily embed HTML in their translations.
In SFC's you can add a <i18n> block with translations, but if those string contain HTML, Devtool attaches a data-v-inspector attribute and that breaks unimport-vue-i18n in the process.
I think the underlying issue is that the double quotes from the data attribute terminate the string?
🛠 To reproduce
https://stackblitz.com/edit/nuxt3-issue-unplugin-vue-i18n-4dw9xe?file=nuxt.config.ts
🌈 Expected behavior
Devtools to not process HTML from string translations (or at least not to break them 😄  )
ℹ Additional context
Toggle the devtools on/off to see it works with the devtool disabled, but breaks with it enabled.

You can fix it by:
devtools: {
    enabled: true,
    componentInspector: false,
  },

@arashsheyda thanks, will this break/limit any of the devtools functionality?
If so, then that wouldn't be great, of course.

@TheDutchCoder unfortunately yes, you can't use the component inspector, as DevTools is using vite-plugin-vue-inspector for component inspection. but everything else would work just fine!

@arashsheyda Ok, then let's leave this open as a bug, because we really would like to be able to use both 😉

Any chance this could be picked up?
Can we also remove the "has workaround" label? Disabling devtools is not really a "workaround" imo 😉


added hidden nonexaustive variant

fixes #182
i first tried to add the variant inside error_chain_processed!, but that failed with a weird macro error:
error: attempted to repeat an expression containing no syntax variables matched as repeating at this depth
  --> src\quick_error.rs:98:20
   |
98 |             enum [$( $(#[$emeta])* => $eitem $(( $($etyp),* ))* )*
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

so i had to drop down to quick_error and impl'd it there. seems to work ok.

Could you update the changelog?

Also, add "Fixes #182" in the commit body.

Bump. Feedback has been fixed already :)

@tinaun Rebase it on latest master maybe?

Yes

Sorry for the delay: could you rebase again?

Manually merged, thanks!


Fix to remove old items

The item was being removed from the DOM meaning ptr.nextSibling returned null rather than the intended next sibling. Therefore we need to capture ptr.nextSibling before ptr is removed then apply it to ptr after.
There might well be a better way to organise the while loop but this fixes the issue at hand.

Thanks Adam. The PR is definitely on the right track, but misses the case where there is one node in the template.
I'll write some tests, so we capture the issue you highlighted and the issues I've just mentioned.
Cheers

Ah I see, that's what I get for only looking at one bit of code! At least this should clear things up for you to fix, cheers.