Make our UUID package internal

Nowadays there are much, much better UUID implementations to choose from, such as github.com/google/uuid. Prevent external users from importing our bespoke implementation so that we can change or migrate away from it internally without introducing breaking changes.

Replacing it seems sensible to be. Also happy with making it internal and replacing it later.


Make react-native ENV variables available

BUNDLE_CONFIG
BUNDLE_COMMAND
EXTRA_PACKAGER_ARGS

@blargity, would you mind merging this one? LGTM. :blush:

Sorry for the delay. Done! I'll release to NPM shortly.

Just wanted to let anyone watching this know that this has been released in v1.0.5.


V2.19.0

Issues
Assortment of improvements for nightshade core that affects the storefront-static repo

Remove utility classes on macros to make them more flexible.
Update footer to work for all countries.
Some IE fixes

I have additional PRs for strorefront static to bring it up to date with production.
Todos

[ ] Write up testing steps for storefront static
[ ] Testing

Impacted Areas

All headings except Upgrade section heading
Value props
Footer

Known Issues
Until updates are made to storefront static the following modules are not in parity with the live site. Most have issues at certain breakpoints.
All browsers

Upgrade callout missing heading
Footer links and text are missing

IE only

Awards
Value props at table-ish sizes

Steps to Reproduce
On Storefront Static
These are screenshots of master branch without and with the changes in this branch changes. Areas that appear to be regressions from current live site will be addressed in separate commits to storefront-static.
Chrome
Before/without patch (current state of master)

After/with patch

IE
IE Before

IE After

To test this patch on Storefront static, create a link as outlined in directions below 👇
Ensure no regressions on Casper.com Rails repo

Change to this directory and branch.

Run nvm current.
If version is not 5.10.1, nvm use 5.10.1.

Create a link npm link
Link repo to Casper Rails site npm link @casper/nightshade-core
Click through PDPs, there should be any regressions

@josephco @robwierzbowski 👋 😀
I'm working on getting storefront static master updated to it deployable state. It relies on updates to nightshade core. Can I get core review on this PR?
Thanks so much!
cs

Of course! Hi Claudina 😭😭😭🙂🙂🙂

@robwierzbowski Made those changes. Rebased into https://github.com/CasperSleep/nightshade-core/pull/188/commits/2447de9748f15637060aefa8284802972b6977ad.
All that's left is to merge and bump version number. Thank you for the review!


revert(weave): dictify unknown class instances

Reverts wandb/weave#2680
See internal Slack: https://weightsandbiases.slack.com/archives/C03BSTEBD7F/p1729185249582949

Because this didn't revert cleanly we decided to fix forward in https://github.com/wandb/weave/pull/2733


Adjust shadow offset based on menu location

This PR is related to this issue [comment] (https://github.com/jdehlin/Xamarin-Sidebar/issues/27#issuecomment-128358063)

Thanks for the pull request!

I just realized, rather than setting the offset to 0 for left menus, it should have been -5, so the shadow looks consistent with the right menu's shadow. I can do another PR if you want.

Go for it.


Update README.md

@rybalov please take a look and approve the changes if they are OK. The text is approved by @akhtyam


add Latin to lang

also added name to license

Travis failed on this - something about minitest. Can you investigate?

Travis was reporting an error related to minitest, which is in Gemfile.lock. This was a bug in Bundler 3.5.0 and earlier. Forcing travis to use Bundler 3.5.1 solves it: https://github.com/travis-ci/travis-ci/issues/1806


Rolling bitwise methods (&, |, XOR)

I have no idea if this would be practically useful, but it might be interesting.

Thinking about it some more, this probably won't be particularly useful.


Clarify which seats receive email notifications

Contributions

[X] I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates
per slack thread and user question, we should clarify that IT and Read-only seats can receive email notifications. This isn't mentioned or clear on the docs
What part(s) of the page would you like to see updated?
https://docs.getdbt.com/docs/cloud/manage-access/seats-and-users
Additional information
No response

the page now clarifies this, clsoing issue


Add docker support

Adds the option to run the web UI using docker. Currently only works for nvidia gpus.

Looks good. Just a couple of comments:

I'm not very familiar with docker, but is there a place to add additional command line arguments? There are some that would be needed for compatibility and for multi-GPU support.
I'm thinking maybe it's better if it pulls a specific version of PyTorch that works well (like the current one) instead of the latest nightly?

Yes, it's possible to add new command line arguments in the command field of docker-compose.yml (or docker-compose.override.yml)! For example:

services:
  web:
    command: |
      --host <IP_ADDRESS>:5000
      --gpu_split 20,7,7
      --no_half2

If you run the container manually, you can simply append the command line arguments to the docker run command, like:
docker run --gpus all -p 5000:5000 -v <path_to_model_files>:/app/model/ --rm -it exllama-web \
  --host <IP_ADDRESS>:5000
  --gpu_split 20,7,7
  --no_half2

The arguments are passed via entrypoint.sh to webui/app.py.

I agree that it makes more sense to specify a specific version of pytorch. Are you using any features from 2.1.0 that are not available in 2.0.1? If not, then I would use 2.0.1, otherwise I would specify the latest nightly version (2.1.0.dev20230610+cu118).

Btw, are you using/planning to use torchvision and/or torchaudio? I don't think they're referenced in the code. If not, then I would remove them.

I just left torchvision and torchaudio in the readme because that's the command line the PyTorch website spits out to install the latest nightly build. I'm definitely not using them and I don't think they're referenced anywhere in the code, so you should just leave them out. I've also had no problems so far running 2.0.1 on RunPod, so yeah, that's probably a good default for the docker setup.

ok, will do!


"Container not in READY state" message not clear

I'm trying to write a simple chaincode, which can make a call to the outside world through grpc. I attach the chaincode itself.
tx.go.zip
I started with understanding the examples provided in openchain/example/chaincode.
I started up obc-peer with
 $ ./obc-peer peer --peer-chaincodedev
then after compiling my chaincode, I started it with
 $ OPENCHAIN_CHAINCODE_ID_NAME=mycc OPENCHAIN_PEER_ADDRESS=<IP_ADDRESS>:30303 ./tx_example
In the obc-peer log, it seems that it connects successfully, as far as I can tell
15:27:07.331 [chaincode] HandleChaincodeStream -> DEBU 07a Current context deadline = 0001-01-01 00:00:00 +0000 UTC, ok = false
15:27:07.341 [chaincode] processStream -> DEBU 07b []Received message REGISTER from shim
15:27:07.341 [chaincode] HandleMessage -> DEBU 07c []Handling ChaincodeMessage of type: REGISTER in state created
15:27:07.341 [chaincode] beforeRegisterEvent -> DEBU 07d Received REGISTER in state created
15:27:07.341 [chaincode] registerHandler -> DEBU 07e registered handler complete for chaincode mycc
15:27:07.341 [chaincode] beforeRegisterEvent -> DEBU 07f Got REGISTER for chaincodeID = name:"mycc" , sending back REGISTERED
15:27:07.342 [chaincode] notifyDuringStartup -> DEBU 080 nothing to notify (dev mode ?)

Also my chaincode log seems fine
2016/03/08 15:27:07 Peer address: <IP_ADDRESS>:30303
2016/03/08 15:27:07 os.Args returns: [./tx_example]
2016/03/08 15:27:07 Registering.. sending REGISTER
2016/03/08 15:27:07 []Received message REGISTERED from shim
2016/03/08 15:27:07 []Handling ChaincodeMessage of type: REGISTERED(state:created)
2016/03/08 15:27:07 Received REGISTERED, ready for invocations

I tried to run it
 $ ./obc-peer chaincode invoke -l golang -n mycc -c '{"Function": "init", "Args": []}'
15:27:30.718 [crypto] main -> INFO 001 Log level recognized 'debug', set to DEBUG
15:27:30.719 [crypto] main -> DEBU 002 Working at security level [256]
3acbd532-61ef-49e9-9da3-1ceb26f19234

And in obc-peer log, it seems that my chaincode has run:
15:27:30.729 [devops] createExecTx -> DEBU 081 Creating invocation transaction (3acbd532-61ef-49e9-9da3-1ceb26f19234)
15:27:30.729 [devops] invokeOrQuery -> DEBU 082 Sending invocation transaction (3acbd532-61ef-49e9-9da3-1ceb26f19234) to validator
15:27:30.731 [peer] sendTransactionsToThisPeer -> DEBU 083 Marshalling transaction CHAINCODE_EXECUTE to send to self
15:27:30.731 [peer] sendTransactionsToThisPeer -> DEBU 084 Sending message CHAIN_TRANSACTION with timestamp seconds:1457450850 nanos:731187042  to self
15:27:30.731 [peer] handleChat -> DEBU 085 Current context deadline = 0001-01-01 00:00:00 +0000 UTC, ok = false
15:27:30.731 [consensus/handler] SendMessage -> DEBU 086 Sending to stream a message of type: RESPONSE
15:27:30.731 [peer] SendMessage -> DEBU 087 Sending message to stream of type: RESPONSE
15:27:30.732 [consensus/noops] RecvMsg -> DEBU 088 Handling OpenchainMessage of type: CHAIN_TRANSACTION
15:27:30.732 [consensus/noops] broadcastConsensusMsg -> DEBU 089 Broadcasting CONSENSUS
15:27:30.732 [consensus/noops] RecvMsg -> DEBU 08a Sending to channel tx uuid: %!(EXTRA string=3acbd532-61ef-49e9-9da3-1ceb26f19234)
15:27:30.732 [peer] handleChat -> DEBU 08b Received EOF, ending Chat
15:27:30.732 [peer] func1 -> DEBU 08c Received RESPONSE message as expected, will wait for EOF
15:27:30.732 [peer] func1 -> DEBU 08d Received EOF
15:27:31.732 [consensus/noops] handleChannels -> DEBU 08e Process block due to time
15:27:31.732 [consensus/noops] processTransactions -> DEBU 08f Starting TX batch with timestamp: seconds:1457450851 nanos:732762966
15:27:31.732 [consensus/noops] processTransactions -> DEBU 090 Executing batch of 1 transactions with timestamp seconds:1457450851 nanos:732762966
15:27:31.732 [chaincode] LaunchChaincode -> DEBU 091 Container not in READY state(established)...send init/ready
15:27:31.732 [state] GetHash -> DEBU 092 Enter - GetHash()
15:27:31.732 [buckettree] ComputeCryptoHash -> DEBU 093 Enter - ComputeCryptoHash()
15:27:31.732 [buckettree] ComputeCryptoHash -> DEBU 094 Returing existing crypto-hash as recomputation not required
15:27:31.732 [state] GetHash -> DEBU 095 Exit - GetHash()
15:27:31.732 [consensus/noops] processTransactions -> DEBU 096 Committing TX batch with timestamp: seconds:1457450851 nanos:732762966
15:27:31.732 [state] GetHash -> DEBU 097 Enter - GetHash()
15:27:31.733 [buckettree] ComputeCryptoHash -> DEBU 098 Enter - ComputeCryptoHash()
15:27:31.733 [buckettree] ComputeCryptoHash -> DEBU 099 Returing existing crypto-hash as recomputation not required
15:27:31.733 [state] GetHash -> DEBU 09a Exit - GetHash()
15:27:31.733 [indexes] addIndexDataForPersistence -> DEBU 09b Indexing block number [3] by hash = [17a4659a1097a595d5ded0cd315b34b88293075d70ad101f4bfe52eba342bba142a27514f27f46afb359e9bf135e3dabce4f9c56549a019bfafdae0efe027c8a]
15:27:31.733 [state] AddChangesForPersistence -> DEBU 09c state.addChangesForPersistence()...start
15:27:31.733 [state] AddChangesForPersistence -> DEBU 09d Adding state-delta corresponding to block number[3]
15:27:31.733 [state] AddChangesForPersistence -> DEBU 09e Not deleting previous state-delta. Block number [3] is smaller than historyStateDeltaSize [500]
15:27:31.733 [state] AddChangesForPersistence -> DEBU 09f state.addChangesForPersistence()...finished
15:27:31.733 [ledger] resetForNextTxGroup -> DEBU 0a0 resetting ledger state for next transaction batch
15:27:31.733 [buckettree] ClearWorkingSet -> DEBU 0a1 Enter - ClearWorkingSet()
15:27:31.733 [consensus/noops] getBlockData -> DEBU 0a2 Preparing to broadcast with block number 4
15:27:31.733 [consensus/noops] getBlockData -> DEBU 0a3 Got the delta state of block number 4
15:27:31.733 [consensus/noops] notifyBlockAdded -> DEBU 0a4 Broadcasting OpenchainMessage_SYNC_BLOCK_ADDED to non-validators

My chaincode has two side effects, which I should see when it's run:

it prints with regular Printf (like the examples)
it calls on the grpc interface

However, I can't see either of them happening. What could be the situation here?

Try ./obc-peer chaincode deploy -n mycc -c '{"Function":"init", "Args": []}' and see if that gives different results. I just tried this with your chaincode and it printed hash: 1

The key is this message in peer :
[chaincode] LaunchChaincode -> DEBU 091 Container not in READY state(established)...send init/ready
"deploy" has to be called in order to initialize the chainode. So @srderson suggestion is necessary

Thanks for your help, it works now.

Great.
@muralisrini Should that message be an ERROR or WARNING so it's more clear that there's a problem?

@srderson : I was thinking the exact same thing :+1:  I think there are many other places where this needs to be done in the code path such as the one reported in #653. I have fixed a few of those but worth taking another look. Will link this to that issue.

@esgott : mind if we change the title to indicate log fix ? Let me know if you'd like me to do that. Thanks!

You can rename it to whatever is convenient for you.

@esgott Communicating with the outside world is forbidden in a chaincode.  Just because your chaincode was invoked does not guarantee that the changes will actually wind up in a block.

for closure :
At the point where we output
[chaincode] LaunchChaincode -> DEBU 091 Container not in READY state(established)...send init/ready
if in dev mode we'd also output a WARNING or ERROR message suggesting user may have forgotten to do "deploy".

I am happy to take a look at this.


fetching ff values with SDK failed

Hello, I use FeatureHub for several services. I've built a microservice acting as a Python WSGI-based proxy. The feature values are mostly consts. I do not need an open stream to receive and update information because in my larger services, I use a caching mechanism for the feature values.
I'm encountering a lot of ongoing crash logs
`Traceback (most recent call last):
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 1110, in emit
msg = self.format(record)
^^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 953, in format
return fmt.format(record)
^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/pythonjsonlogger/jsonlogger.py", line 226, in format
record.message = record.getMessage()
^^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 377, in getMessage
msg = msg % self.args
^~~~~~~
TypeError: not all arguments converted during string formatting
Call stack:
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/threading.py", line 995, in _bootstrap
self._bootstrap_inner()
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/featurehub_sdk/streaming_edge_service.py", line 61, in run
log.error("failed to communicate with featurehub", err)
Message: 'failed to communicate with featurehub'
Arguments: (ProtocolError("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read)),)
--- Logging error ---
Traceback (most recent call last):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 761, in _update_chunk_length
self.chunk_left = int(line, 16)
^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 16: b''
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 444, in _error_catcher
yield
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 828, in read_chunked
self._update_chunk_length()
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 765, in _update_chunk_length
raise InvalidChunkLength(self, line)
urllib3.exceptions.InvalidChunkLength: InvalidChunkLength(got length b'', 0 bytes read)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/featurehub_sdk/streaming_edge_service.py", line 46, in run
for event in self._client.events():
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/sseclient/init.py", line 58, in events
for chunk in self._read():
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/sseclient/init.py", line 48, in _read
for chunk in self._event_source:
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 872, in iter
for chunk in self.stream(decode_content=True):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 624, in stream
for line in self.read_chunked(amt, decode_content=decode_content):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 816, in read_chunked
with self._error_catcher():
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/contextlib.py", line 155, in exit
self.gen.throw(typ, value, traceback)
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/urllib3/response.py", line 461, in _error_catcher
raise ProtocolError("Connection broken: %r" % e, e)
urllib3.exceptions.ProtocolError: ("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/concurrent_log_handler/init.py", line 380, in emit
msg = self.format(record)
^^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 953, in format
return fmt.format(record)
^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 687, in format
record.message = record.getMessage()
^^^^^^^^^^^^^^^^^^^
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 377, in getMessage
msg = msg % self.args
^~~~~~~
TypeError: not all arguments converted during string formatting
Call stack:
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/threading.py", line 995, in _bootstrap
self._bootstrap_inner()
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/featurehub_sdk/streaming_edge_service.py", line 61, in run
log.error("failed to communicate with featurehub", err)
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 1518, in error
self._log(ERROR, msg, args, **kwargs)
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 1634, in _log
self.handle(record)
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 1644, in handle
self.callHandlers(record)
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 1706, in callHandlers
hdlr.handle(record)
File "/home/hodam/.pyenv/versions/3.11.0/lib/python3.11/logging/init.py", line 978, in handle
self.emit(record)
File "/home/hodam/.pyenv/versions/ff_proxy/lib/python3.11/site-packages/concurrent_log_handler/init.py", line 400, in emit
self.handleError(record)
Message: 'failed to communicate with featurehub'
Arguments: (ProtocolError("Connection broken: InvalidChunkLength(got length b'', 0 bytes read)", InvalidChunkLength(got length b'', 0 bytes read)),)
`
Additionally, I have a task that updates the cache. When the task runs on a pod with numerous clients, I'm unable to get the value of the feature flags.
I used your examples to create the proxy. If more information is needed, please let me know
Thanks!

Hi there, do you mean an external cache from the running SDK? When the SDK runs, it connects to the Feature Hub server (either by SSE, which I think you are using here?) or by a simple GET request and then caches it inside the SDK. When apps ask for feature values, it always comes from the cache. So in a standard Web application, all of the running threads would be able to use the same cache.
The purpose of using Streaming on your servers is to ensure they get the updates into the SDK's cache close to immediately.  You can instead use the Polling mechanism which will cause the local cache to use the simple GET and be updated once every period of time (say 30 seconds).
The logs you post seem to indicate some transient issues with the FH Server, like your app is losing connection to it? This should just be telling you that its having trouble connecting, but it shouldn't stop the connection. Do you find you lose connection and then it never restarts? I'm not sure if it is simply that it is logging the error or its actually not doing the right thing that is causing the problem?

Hi - thank you for the quick response. Where can I find a reference for a simple API request instead of using SSE? Thank you


[ui] Karate UI re-write

cc @RavinderSinghMaan @vmchukky
Decided to re-write the Karate UI - but we can quickly re-use all the stuff we have learnt building the old one. The main motivation is because the model objects are now clean and cucumber-free and especially since we a great abstraction of ScenarioExecutionUnit and ScenarioResult + StepResult
also see the design below - the big change is a greatly simplified user-experience where you can very easily select a single scenario to run. or flip between scenarios to look at data. the vars table is per scenario - which is the right association. some niceties like the icon, which even shows in the dock for mac
I can use some help to add in all the old stuff and re-build. I can take care of the experience when a feature is call-ed this will be tricky - but I think I have an approach in mind
I think it is time we got the UI out of beta - and I am anticipating this will be a huge benefit for UI automation - and will allow teams to FIX the flaky tests fast enough.

@ptrthomas
just curious.
So through interface, how do you deal with karate.config?  Those right side of Variable type map view will load and persist karate.config values? is karate.config per feature or something shared between features? or karate ui have different notion for variable and map?

@jlee70 try the existing version and see. karate-config.js will be loaded from the usual locations (classpath: by default) - first version will not support being able to edit - karate-config is re-loaded per-scenario

@jlee70 only load for now. maybe edit later - karate-config.js is re-processed before the start of any Scenario. if it returns a map, every key-value will become a variable.

I tried out latest branch. UI needs some love (noticed some repaint issues..) but basic functionality works.

cc @babusekaran @vmchukky

finally did it ! when a feature call happens, you can opt to open a new instance of the UI and it seems to work well. when you hit the close [X] button, the call result is returned to the caller as well - and it all seems to work fine.
introduced a split button (see image) which seems to be a cleaner way to stuff more step-actions and can hold possibly add / remove step above / below etc. and the "run upto" action - which you can see above is TODO

Opened the call-nested.feature in karate-demo and wow it is more interactive now. and the same goes with calling feature with an array of JSON 👏 👏 👏.

@babusekaran I actually didn't even try an array loop - but it should work - thanks for confirming, and also all the PR-s !


update CSS preprocessor instructions

Windows shell users should note that running two programs simultaneously is not supported.

I just finished signing the Contributor License Agreement. Be gentle, this is my first pull request here :)

Oh, that is sad. I assumed it worked on Windows from some answer on the internet.
Maybe there's some cross-platform helper to help this? Like people use cross-env for setting env variables.

We could recommend to use concurrently.

Here's a working solution with npm-run-all, tested right now on my windows:
"scripts": {     "build-css": "node-sass src/ -o src/",     "watch-css": "npm run build-css && node-sass src/ -o src/ --watch",     "start-rs": "react-scripts start",     "start": "npm-run-all -p watch-css start-rs",     "build": "npm run build-css && react-scripts build",

Plus, the order you suggest for the build step seems to be wrong. The SASS preprocessor should run first, or the CSS in the build directory will be outdated. Shall I submit another PR for that?

Having both changes in this PR is fine. 😄

OK. the problem is that my commit doesn't have the build order fix :D I guess you guys can sort it out. Sorry, I'm still getting used to this whole Github thing (have mercy, I'm an ex-very-very-closed source C# developer ;) )

Included tweaks from the discussion. Thanks!


[Python] How to append rows of a table to a memory mapped file?

Hello,
as you can see in the code below, I'm having troubles adding new rows to a Table saved in a memory mapped file.
I just want to write the file again with the new rows.
    source = pa.memory_map(path, 'r')
    table = pa.ipc.RecordBatchFileReader(source).read_all()
    schema = pa.ipc.RecordBatchFileReader(source).schema
    new_table = create_arrow_table(schema.names) #new table from pydict with same schema and random new values
    updated_table = pa.concat_tables([table, new_table], promote=True)
    source.close()
    with pa.MemoryMappedFile(path, 'w') as sink:
        with pa.RecordBatchFileWriter(sink, updated_table.schema) as writer:
           writer.write_table(table)

I get an Exception stating that the memory mapped file is not closed.
ValueError: I/O operation on closed file
Any suggestion?

Do you mind closing this now that you've accepted the SO answer?  If you want to discuss resizing strategies for memory maps and maybe what you are planning at a higher level in hopes of getting suggestions I would recommend sending a message to the user mailing list


Reuse the same RPC client for all endpoint requests

Explain the changes

creating a new RPC client for each endpoint request induces a measurable memory pressure when doing a lot of small requests in a row by shorting the time between GC cycles.
Reusing the same RPC client prevents that

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

@guy Any kind of object creation in a tight loop that is long-living creates memory pressure, the bigger (or deeper) the object the more pressure it creates. Also a long-lived object whole cycle through the 2 pages of the new generation and then the old generation and it's memory can be recollected only with a Mark an Sweep GC (which is not lightweight).
We should adore to object re-usage (recycling) or to lightweight objects that are created used and then thrown away, like many of the intermediate objects onside functions.
I understand the problem you presented in your comment but I would like to offer a third option:
let's create an RPC client pool to be used by the Endpoint, we can use the ObjectPool implementation I added in my other PR (#6016). Each request will "rent" an object from the pool and return it to the pool in the end.
This way each request will get its own RPC client and all RPC clients will live in the old generation forever (or until the process ends).
What do you think?

Not sure I'm following your logic - why shouldn't we make rpc_client a lightweight object that only has the state of auth_token? Clearly every http request allocates data that will live through the entire lifetime of that http request so that's just part of the same memory which might be scavengered or if the request lives too long in memory it will have to be Marked and sweeped anyhow.
About ObjectPool - sure you can do that, but I still want to separate rpc_client from the all the generic APIClient that is today in the same object.

This memory will not be scavenged for sure. On my tests, each individual request has lived much more than 2 GC cycles (and this is one of the things I think we should improve upon).
Of course, if the memory allocation for such objects is small it will fill the old generation very slowly (if we compare to the way it is now) and defer Mark and Sweeps.

There aren't many objects that live per request for the whole duration of a request (buffers are the exception). Many "heavy" objects are created used then thrown away. The RPC client is one of these objects that do live the entire request.

I believe you have desire is to keep API interface as is (so we will not have to touch any call sites) and with this assumption, I must say that the separation you propose is doable but very tricky with to the way the code is currently written (ECMA proxy objects might help):
Each API call is an arrow function closure that preserves context state that is part of the actual RPC client.

Memory wise it will be preferable to just pass the auth_token throughout the endpoint lifecycle and create a new RPC on every call site that wants to call, then throw that client away (an API object will be part in a single scavenge at most).
I don't think this is the way to go because I believe that all the gain will be negated by the CPU time taken to create the "heavy" client for each call site.

This is how I came to the conclusion the pooling the clients will be memory efficient and easy to implement and will get us the desired result without changing any call sites.
Of course, lowering the memory footprint of the client by extracting all the interfaces implementation out into an object that will be everliving should be done, if possible, anyway

Maybe I am missing something but the defer is on the RPC and not the API which means that even if you create a new client each time you will get the same problem (if it is really a problem).
I tried to rewrite the client the way you suggested but didn't manage without call site changes, even tried to use ECMA proxy objects.

The defer is on the object_io with that object_sdk + rpc_client.

But the RPC client is allocated until the end of the request. Which means all object_io using this rpc_client id done.

OK so as we discussed, we are closing this PR in favor of #6022, right?

Closed in favor of #6022


Dockerfile

Creates a Docker image using a Dockerfile. It specifies the base image, copies files into the image, exposes a port, and sets the entrypoint for the image. The entrypoint runs a Java program with classpath set to the "/app" directory in the image.

Code is good. I think you should verify your commits in order to merge the branch.


do not imply pre-release when != operator is used

Summary
closes #6640
Test Plan
Could you suggest how I should test it?
(already tested locally)

This looks right to me! It will need to be part of 0.5.0 so I'll add it to that milestone.

I think you could write a test like prerelease_upper_bound_exclude... flask<2.0.1, !=2.0.0rc1 and ensure that 2.0.0rc2 is not selected.

@Czaki it looks like this has some unrelated changes in it now.

I backed them out. @zanieb, want to merge into 0.5 branch?


New plugin breaks due to callback URL mismatch?

Not sure if this is a Pantheon API change or something in the new plugin, if it's not ours marked this "resolved". :)

mm this is weird, seems you are using two sets of urls. one is pantheonsite.io and the other pantheon.io.
How did you set this app? Was it using the on-boarding wizard or manually on the auth0 dashboard? (if it is the first option, check under settings->general if the WordPress Address and Site Address are using the correct url).


Deploy custom policy as part of cluster deployment

PR contains:

Motivation to deploy a custom policy (Ingress hosts must have a well-defined domain suffix.)
Code to deploy the custom policy using Azure Policy.
Validation procedure, illustrating how creation of a violating resource will be rejected.

I decided for a Base64-coded specification of the Gatekeeper policy. The advantage is that the bicep is self-containing and we do not have a dependency of an external file we'd need to download from a GitHub repository. The disadvantage is that users cannot really read it.
We could (a) leave it like that, (b) commit the policy into the repository (for reference only) and link in the explanation, (c) replace the encoding with the URL to the (readable) spec.
Any thoughts on this?

I decided for a Base64-coded specification of the Gatekeeper policy. The advantage is that the bicep is self-containing and we do not have a dependency of an external file we'd need to download from a GitHub repository. The disadvantage is that users cannot really read it.
We could (a) leave it like that, (b) commit the policy into the repository (for reference only) and link in the explanation, (c) replace the encoding with the URL to the (readable) spec.
Any thoughts on this?

Any thoughts on this? ☝

Any thoughts on this? ☝

I have no problem with it base64 encoded like you have it, without having to maintain a shadow copy.  I was going to link to a base64 decoder in a comment, but didn't see any that MSFT owned publicly so I passed on that.  If you wanted to give the user a hint, you can add a comment that says the body is base64 encoded, and if they wish to view it, to open it in a decoder.  But I wouldn't worry about it.

Looks like there are some merge conflicts @ulkeba -- if you can address those, and if you wanted to do any suggestions for the user to check out a decoder for the contents, then we'd be good to go with this.


[Icon Menu] adding closeOnItemTouchTap

Sorry, I messed up something in previous one, so here is new shiny PR.

Thanks @mkucharz :+1:


postgresql: 12.17 -> 12.18, 13.13 -> 13.14, 14.10 -> 14.11, 15.5 -> 15.6, 16.1 -> 16.2

Description of changes

Security Issues

CVE-2024-0985: PostgreSQL non-owner REFRESH MATERIALIZED VIEW CONCURRENTLY executes arbitrary SQL

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

aarch64 error is a ghc timeout: successfully built all tests from nixos/tests/postgresql.nix on the community builder.

Ah now, that revert was the culprit probably.  Anyway, picked everything by ff1b47eefd42


md-select random issue with selection.

I am seeing some random issue with md-select. I have a list of Products({id:2,productName:"Product1"}). When i try to edit my record (which has productId as a property i class) and in my edit view, i have a md-select which display these products, randomly, md-select does not generate any list. It happen when you edit/cancel multiple time.
Code:

                        <option repeat.for="mt of products" model.bind="mt.id">${mt.productName}</option>
                    </select>
                    Products

Logs for working condition:
2aurelia-logging-console.js:38 DEBUG [md-select] handleChangeFromViewModel
aurelia-logging-console.js:38 DEBUG [md-select] handleChangeFromViewModel 1 AGGRASTAT
No logs when its not working. No exception either in console. Please let me know if anything wrong with my code snippet.
I am loading lookup data (Products) in constructor async(using promise) and loading the record which i am trying to edit inside my vm's activate() function which is screen activation lifecycle of aurelia.

We need some kind of live playground for things like this. Could you try and format the code, please? Also I think it would help if you provide the view model. :smile:
OR even better: can you create a repo with the relevant code?
It's much easier to help with such things if you have the whole context.

Not to step on your toes but this seems a little more complicated.. :smile:

which part? :)

private products: Array<Product>;
constructor(private ea: EventAggregator, private cache: GlobalCacheService,
        private svc: LookupDataService,
        private meetingSvc: MeetingsDataService,
        private router: Router,
        private diag: DialogService,
        private validationContext: Validation) {
        super();
        this.CurrentMeeting = new Meeting();
        this.CurrentMeeting.id = 0;
        this.CurrentMeeting.productId=24;
        this.svc.getAllProducts().then((prod: Product[]) => {this.products = prod}); }

 activate(params: any) {

        return new Promise((resolve, reject) => {
            //From Meetings List -> Editing : isAddTo=false
            //Get new item from server.
            if (params.id > 0 && params.isAddTo && params.isAddTo === "false") {
                //Editing existing Record.
                this.inEditMode = true;

                this.meetingSvc.getMeetingById(params.id).then(meet => {
                    this.CurrentMeeting = <Meeting>meet;
                    resolve();
                });
            }
}

```html
 <select md-select id="prods" value.bind="CurrentMeeting.productId">
           <option repeat.for="mt of products" model.bind="mt.id">${mt.productName}</option>
 </select>
 Products

let me know if you need more details :)

When you say

md-select does not generate any list

does that mean the select is empty all of a sudden?
If so, that is strange. Your activate() doesn't change products in any way. What's the state of products after activation? And does the above work with a native select?

i think whats happening here is select has values, but dropdown click is somehow disabled. When i use dev tools -> element to debug the html, i see  .... and all items are there. But i cannot click the dropdown.

I guess I'll have to try this.
Unfortunately this can take some time but if I'm lucky I can spare some time tomorrow.
Let's see if  got this right..

I'll fill an array of products from a service in constructor
set a product id before (!) the actual products are read
in activate I'll overwrite the bound product id

Then I should not be able to use the select.
I'm wondering what happens when meet (from activate) doesn't have a productId.
Did you try this with a native select?

have not tried with native select but will give it a shot. i modified my code a bit to use TaskQueue. So one of the scenario (while adding new record) looks fine now. Yes you got it right. :)
this.svc.getAllProducts().then((prod: Product[]) => { this.products = prod;
            if (this.inEditMode === false) {
                this.taskQueue.queueMicroTask(() => {
                    this.Logger.info(`${this.products.length} ADD loaded`);
                    this.CurrentMeeting.productId = 24;
                });
            }
             });

Hmm.. What would happen if activate is executed before the service call in the constructor returns?
There'd be no products at the time when attached is called. That may be the reason.
In that case, the Materialize select is initialized without any items and it's displayed as such. But the native select will be populated.
Materialize select would need a refresh which it doesn't have unfortunately..
We could fake one in the bridge, I think destroy is implemented. So that would be destroy and recreate.
Nasty but that may work.

Btw. that idea came to me when you mentiones taskQueue.
It's basically waiting. And if waiting solves something, there are issues with asynchronous tasks. :smile:

i agree. Async functions are not that fun.

Refresh doesn't work as expected. Currently, it only refreshed when called twice and throws exceptions.

How do we set colors in Md-card?
Thanks,
Vikas Dangwal
On Sun, Apr 3, 2016 at 11:03 PM -0700, "Daniel Bendel"<EMAIL_ADDRESS>wrote:
Refresh doesn't work as expected. Currently, it only refreshed when called twice and throws exceptions.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/156#issuecomment-205149030

By using the built in Materialize colors or one of:

accent (background)
primary (background)
accent-text (text of course)
primary-text

See also: http://aurelia-ui-toolkits.github.io/demo-materialize/#/samples/color

added a refresh function to md-select


pubsub: subscriber: keep getting "Stream removed" errors

every few days, sometimes a week, one of our subscribers in a while True loop waiting on future.result(timeout=1) is getting excepted, exception string is None Stream removed.  this might happen maybe every thousand received messages (I can count better if it's needed).
originally we were on grpcio-1.8.1, and after searching, we seemed to find some indication that this error might be solved by an RPC library upgrade.  the reference is a totally different language/application but using the same google RPC library, they say upgrade to grpcio-1.8.4 fixed their issue.  recent comment seems to indicate that the nodejs library would normally retry this RPC but wasn't getting the right return value, which grpcio-1.8.4 fixed for them.
moving to later grpcio-1.8.4 for us however did not help with the Python library, we still see this error.
we don't think our application should see this, the library should be retrying it based on the RPC result, just like they do in the referenced cloud client library.
environment is ubuntu16 on a gce node, relevant libs:

grpcio: 1.8.4
google-api-core: 0.1.4
google-cloud-core: 0.28.0
google-cloud-pubsub: 0.30.1

@lukesneeringer @dhermes can one of you take a look?
@scottingly can you possibly give us a full stack trace?

these are in a multiprocessing pool, and we're on python2, so we aren't getting the indirect traces, just the summary.  It just hit again today right on cue, after about 5-6 days, seems to be the usual interval.  I will try to rework the code to get a full trace next time and update the ticket.

we're using multiprocessing.pool.ThreadPool, so these are threads, not separate procs.  we break up a work list via ThreadPool.map(), each one makes a pubsub subscription, then forks a subprocess which spawns a GCE node, which does its assigned work and sends back messages via the topic.  after spawning the worker nodes, the pool threads each sit in a loop checking if their worker finished (set using threading.Event() in the callback) and then waiting on future.result(timeout=1) and looping on TimeoutError.  If the "done" Event is set, we kill the worker and cleanup, otherwise try again.
normally this works fine, but every few days one of the threads waiting in future.result() as above is excepting with this "Stream removed" error and we have no way to handle that without making a new subscription completely, the original "future" is invalid at that point.
it turns out we were catching Exception so we could keep going with the other workers that were running and do clean shutdown, that's why we didn't get the full trace.  The Stream removed happened again just now and I have managed to print more by utilizing traceback.format_exc() (sorry no newlines):

Traceback (most recent call last):   [our code...] in receive_messages [...] self.future.result(timeout=1)   File "/usr/local/lib/python2.7/dist-packages/google/cloud/pubsub_v1/futures.py", line 103, in result     raise err Unknown: None Stream removed

this seems to give the location of the library-internal exception, but I don't know how to get any more information from it.  the referenced file in the google-cloud-python library looks like this:
   def result(self, timeout=None):
        # [...]
        # Attempt to get the exception if there is one.
        # If there is not one, then we know everything worked, and we can
        # return an appropriate value.
        err = self.exception(timeout=timeout)
        if err is None:
            return self._result
        raise err

so it seems to be the library raising the error, I'm not sure how to get any more out of it at this point.

Thanks for the details, @scottingly. It would be super awesome if you're able to give us an example program that can reproduce this, but it's not required.
For transparency, we're working on burning down critical issues before GA. Since this has some workaround or recovery path we're going to prioritize it below others, but we do plan to get to this soon.

ok sure, but are you still "awaiting information?" I may be able to make a test case, but that's a lot of code to strip down, probably be a while.
our "workaround" is to just repeat it again with a different node which completes processing, which isn't really a workaround per se, we just have to start the whole thing over.  you're right that it's not a showstopper for us at this time because we can do node-level retries.
there does seem to be a bunch of people getting this "Stream Removed" as it relates to pubsub and grpcio, in different languages; see links upticket, also these folks seem to have fixed it with grpcio downgrade, but some people said upgrade in above tickets, which didn't work for us.  again we had tried 1.8.1 and 1.8.4, maybe we should try grpcio-1.7.x, hm.

I may be able to make a test case, but that's a lot of code to strip down, probably be a while.

If you do have the time, it'll be immensely helpful for us. It might also be useful to try to reproduce this on grpc 1.9.1.

one more piece of information to add which may or may not be relevant: we just got the following traceback in exact same location in pubsub library:

self.future.result(timeout=1)   File "/usr/local/lib/python2.7/dist-packages/google/cloud/pubsub_v1/futures.py", line 103, in result     raise err InternalServerError: 500 Received RST_STREAM with error code 2

this is a different error, but seems like retrying at this point should not be done in the user code but the library should handle it (but, I don't know).  however if it's really us that should be doing all this retry handling on endpoint codes that break the socket, and cause us to have to redo entire subscription setup every time, I suppose we will have to do that.
this seems to link to similar issue for RST_STREAM + pubsub

we updated to grpcio 1.9.1 almost 9 days ago and have not seen this happen since.  this is an unusually long period, it normally happens by a week.  not definitive yet, but this may have solved our issue.  will follow up after another week or so, by then I'll be convinced because this occurrence was quite regular.

@scottingly great to hear! Also, upgrading to 1.10.0rc2 should help with any memory issues per https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4978#issuecomment-369937321. I'm closing this for now but feel free to comment if this persists/re-appears in 1.10.0rc2.

this has reappeared, this time we can reproduce it more quickly.  while we haven't seen it on the nodes that run for each hour anymore (48 per day, two for each hour, workers use pubsub to communicate status back to a controller), we have just reprocessed a full day, and 5 out of the 48 workers failed with "Stream removed."   I run the same backfill several times with the same input data and 48 workers, they each have somewhere from 1-5 occurrences of "Stream removed."
we tested on grpcio 1.10.0 and 1.9.1 and also on 1.8.4.  at least for the last (1.8.4) we know backfill was working completely and reliable before, but now we have tried 1.8.4 again and alas we're getting "Stream removed" a few times with every run of 48.  so this has regressed, even for the working version.
1.9.1 had seemed initially to solve problem but maybe this really just coinciding with a server-side change? it may be that grpcio-1.9.1 works better on less frequent / occasional use of pubsub rather than 48x all at once, but our message rate is very low, this is only one every few seconds from each worker to the controller.
is it correct assumption that we should only need to get the subscription once for the lifetime of our daemon process? or should we keep looping getting messages until the stream gets removed, then resubscribe and do it again until the next stream removed, etc?

Thanks, @scottingly. Instead of re-opening this, I'm going to track this over at #4989.
/cc @kir-titievsky

ok, the important thing to note is regression with same version, implying an external factor.  also note, we aren't using windows like in the referenced ticket, just ubuntu 16.
we just did another backfill test with grpcio-1.10.0 and this time 11 out of 48 workers got "stream removed" disconnects.  so it's increasing frequency, last few days when I was testing there were only max of 5/48.

Our current theory is that this is the serving frontend closing the stream on the server side. We're doing some investigation to make sure we can safely retry this before committing and fix.

so far, can confim that 1367d7b seems to fix our issue.  no longer getting "Stream removed" errors on backfill and have restored our ingest process to normal operation.  thanks, looking forward to release.

Great news. :)


Support DatabaseSchema Support

extend DatabaseProperty to provide SchemaName by properties
extend DataBasePrefix to EnterLicenseKeyConfiguration
add Tests for EnterLicenseKeyConfiguration with Schema

Thanks for the PR, I tested it and it works fine. I will add the additional property to the docs and adopt cases (so fare its database, you use dataBase).
I also would like to keep the static character of the support methods by adding the tablePrefix as an parameter.


Should locally defined actions be moved from .github/workflows/ to .github/actions/?

Hi there! 👋
I'm the maintainer of check-jsonschema, and a user recently reported the hooks failing on a project generated from this template: https://github.com/python-jsonschema/check-jsonschema/issues/113
I see that there are actions defined in this repo in the workflows dir, which is what was confusing the pre-commit hook.
The hook behavior is to check any YAML files in .github/workflows/ against the workflow schema from schemastore. I'm not confident that the logic is correct, but it is consistent with the match rule in schemastore today.
By my reading of GitHub Workflows docs -- and the observed behavior of the service -- workflows are defined as .github/workflows/*.ya?ml, not .github/workflows/**/*.ya?ml. So I think there's a case to be made that check-jsonschema is not accurately describing github's behavior, but I'm continuing to study the situation a bit before making changes.
Schemastore defines a schema for github-actions, and check-jsonschema provides a hook. In the former case, it matches action.ya?ml in the repo root dir, and in the latter it matches action.ya?ml in the repo root or .github/actions/**/*.ya?ml. The rationale here is that GitHub's docs show use of that directory for local actions, so it seems somewhat common. Supporting validation of more local actions is therefore reasonable down this path.
It would therefore be nice, from my perspective, to move action definitions from subdirs of ./github/workflows to subdirs of ./github/actions/. The hooks would then run correctly without adjustments to check-jsonschema. Even if I make the workflow matching more strict (I probably will, but am taking time to think about it), actions won't be checked outside of the .github/actions/ dir.

Hi @sirosen, thanks for opening this issue. I think the proposed change makes sense. Since I am currently on holiday, I will investigate the issue further (and probably implement your proposed change) in a week or two from now. Sorry for the small delay.


[AdaptiveCards- Designer - Card Element]: Screen Reader does not convey the descriptive information to the user to use 'Drag & Drop' elements.

Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive Cards
Problem Description
Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)
Screen Reader: Narrator
Repro Steps:

Open above URL with valid credential.
Navigate to 'Designer' link and press enter key to activate it.
Navigate to 'Card Element' button and press enter key.
Navigate to elements under Card Elements and select any one and observe the issue.

Actual Result:
While navigating to the options under 'Card Element' screen reader does not convey the descriptive information to the user to how to drag and drop the element. As elements are draggable.
Expected Result:
Screen Reader should convey the descriptive information to the user for draggable controls and also it should announce the shortcut keys to the user.
Note:

The same issue is observed with NVDA as well.
The same issue is observed under target version 1.5.

User Experience:
It will impact the screen reader user as they will not be aware about the draggable element feature.
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc={9C514377-76E5-4CFE-8300-DA3079D3CDC3}&file=MAS 1.3.1 – Info and Relationships.docx&action=default&mobileredirect=true&share=IQF3Q1Gc5Xb-TIMA2jB5083DAcWOZyaXcx7TtNeRlXM4uHk
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “.
Screenshots
https://user-images.githubusercontent.com/95913748/208664156-82ca4c3f-1c49-4f0a-b60c-2b96bec80735.mp4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

Hi @anna-dingler,
As this issue is still repro, so could you please let us know is there any future plan to fix this issue?


Navigation MPC

Main Changes
The first GNSS location is set as the initial state. The target location is user input. The MPC is run using an OSQP solver. It regularly checks whether the trajectory is correct with the latest GNSS location.
Tests
Yet to be implemented and tested

Closing due to inactivity


Use LocalRSocketServerPort annotation

If you want, you can reopen here https://github.com/spring-cloud-incubator/spring-cloud-rsocket


Dockerd(Swarm): panic serving  After create user defined network

Output of docker version:
Client:
 Version:      1.12.0-dev
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   74873f1-unsupported
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-dev
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   74873f1-unsupported
 Built:
 OS/Arch:      linux/amd64

Steps to reproduce the issue:
1.I make the node as manager role in Docker Swarm(docker swarm init )
2.Start Calico Network Plugin  ("/run/docker/plugins/calico.sock")
3.Docker network create -d calico --subnet=<IP_ADDRESS>/24 calico1
4.the Output of "Docker network ls" is “An error occurred trying to connect: Get http://%2Fvar%2Frun%2Fdocker.sock/v1.24/networks: EOF ”
Output of Dockerd:
ERRO[0006] failed allocating network 6hr82hpafwlyl2jv2b9yx8fzj during init: failed during network allocation for network 6hr82hpafwlyl2jv2b9yx8fzj: failed while allocating driver state for network 6hr82hpafwlyl2jv2b9yx8fzj: could not resolve network driver calico
INFO[0006] Daemon has completed initialization
INFO[0006] Docker daemon                                 commit=74873f1-unsupported graphdriver=devicemapper version=1.12.0-dev
INFO[0006] Initial encryption keys: [(key: 2d022, tag: 0x1) (key: 86db0, tag: 0x2)]
INFO[0006] API listen on /var/run/docker.sock
WARN[0006] task updates not yet supported                module=taskmanager task.id=97lzimxjitx4l1ggh1f5wmta6
ERRO[0007] Failed joining ingress sandbox to ingress endpoint: subnet sandbox join failed for "<IP_ADDRESS>/16": vxlan interface creation failed for subnet "<IP_ADDRESS>/16": failed to set link up: transport endpoint is not connected
WARN[0011] task updates not yet supported                module=taskmanager task.id=0sf4qoxznn0ndq2fqjorc8hnb
2016-06-16 23:53:45.711924 I | http: panic serving @: runtime error: invalid memory address or nil pointer dereference
goroutine 389 [running]:
net/http.(*conn).serve.func1(0xc8214e0b00)
	/usr/local/go/src/net/http/server.go:1389 +0xc1
panic(0x19d15e0, 0xc82000a0e0)
	/usr/local/go/src/runtime/panic.go:443 +0x4e9
github.com/docker/docker/daemon/cluster/convert.BasicNetworkFromGRPC(0xc821009fa0, 0x19, 0x63, 0xc820b5b8b0, 0xc820b5b8c0, 0xc820b5b898, 0x7, 0x0, 0xc821009fc0, 0x0, ...)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/daemon/cluster/convert/network.go:155 +0x35b
github.com/docker/docker/daemon/cluster.(*Cluster).GetNetworks(0xc820a23bc0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/daemon/cluster/cluster.go:874 +0x292
github.com/docker/docker/api/server/router/network.(*networkRouter).getNetworksList(0xc820ac6330, 0x7f3535aa24f8, 0xc820c19140, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0, 0xc820c18ff0, 0x0, 0x0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/router/network/network_routes.go:29 +0x190
github.com/docker/docker/api/server/router/network.(*networkRouter).(github.com/docker/docker/api/server/router/network.getNetworksList)-fm(0x7f3535aa24f8, 0xc820c19140, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0, 0xc820c18ff0, 0x0, 0x0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/router/network/network.go:33 +0x74
github.com/docker/docker/api/server/middleware.VersionMiddleware.WrapHandler.func1(0x7f3535aa24f8, 0xc820c19140, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0, 0xc820c18ff0, 0x0, 0x0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/middleware/version.go:56 +0x9aa
github.com/docker/docker/api/server/middleware.UserAgentMiddleware.WrapHandler.func1(0x7f3535aa24f8, 0xc820c19050, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0, 0xc820c18ff0, 0x0, 0x0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/middleware/user_agent.go:45 +0x68e
github.com/docker/docker/api/server.(*Server).makeHTTPHandler.func1(0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/server.go:139 +0x138
net/http.HandlerFunc.ServeHTTP(0xc820a62900, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0)
	/usr/local/go/src/net/http/server.go:1618 +0x3a
github.com/gorilla/mux.(*Router).ServeHTTP(0xc8209b8190, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0)
	/root/rpmbuild/BUILD/docker-engine/vendor/src/github.com/gorilla/mux/mux.go:98 +0x29e
github.com/docker/docker/api/server.(*routerSwapper).ServeHTTP(0xc8207640e0, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0)
	/root/rpmbuild/BUILD/docker-engine/.gopath/src/github.com/docker/docker/api/server/router_swapper.go:29 +0x72
net/http.serverHandler.ServeHTTP(0xc8203ea080, 0x7f3535a89760, 0xc8202d6dd0, 0xc82116f0a0)
	/usr/local/go/src/net/http/server.go:2081 +0x19e
net/http.(*conn).serve(0xc8214e0b00)
	/usr/local/go/src/net/http/server.go:1472 +0xf2e
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:2137 +0x44e

Describe the results you expected:
I see that dockerd should not happen  "panic serving" anyway
I have some Questions:
1.In docker Swarm cluster ,Can I use "docker run " command to create container with user defined network  ?
2.Will docker service support VIP  in version 1.12?

Cc @aboch @mrjana @mavenugo!

Cc @vieux @dnephin!

@sqleejan there are couple of issues here -

Network plugins are not currently supported in swarmkit and hence docker network create -d {plugin} will not work if the plugin is a GLOBAL_SCOPED driver in swarm-mode.
Networks created in swarm-mode will work only with docker service and cannot be used with docker run.

We have to fix the panic certainly ( I will push a PR shortly ). But the functionality that you are trying to achieve won't work till the above 2 issues are resolved.


Update stats role

Update stats role so that it can be included in playbooks. Also fix db connection string in another role that was requesting data from aarnet-db's public IP.

The stats role has been there for a long time but was never finished. All of the stats collection scripts on aarnet and pulsars have been copied from other VMs.  These changes update the templates from values in the in-use scripts.


[docs] Improve documentation about adding custom colors

[X] I have followed (at least) the PR section of the contributing guide.

Closes: #29595
Summary
Improve documentation regarding adding new colors using a color object:

Clearly indicate that for custom colors the light, dark, and contrastText tokens are required and not calculated automatically, which differs from default colors.
Add an example of how to use the augmentColor function to augment custom colors.
Fix examples so custom colors have all the required tokens

Note
I also wanted to improve the warning/error that users would get when using a component that requires light, dark, or contrastText (see the Chip's contrastText issue: #37676). But after a second thought, it seemed very cumbersome and overhead to do given the small use case for which the warning would be helpful.
If you disagree and think it would be worth it, I would love to discuss approaches to adding the warning 😊 cc: @mui/core

After @samuelsycamore's feedback, I started reworking some examples and concluded that the palette docs needed a reorganization. Related information was scattered and the structure wasn't easy-to-follow. Here are the changes I introduced:

Add color tokens section
Separate default colors and custom colors sections, turn examples into live demos rather than static code and have one atomic example for each piece of information rather than big examples
Add explanation and examples for contrast threshold, tonal offset, and adding new color tokens
Link non-palette colors to custom variables docs, as the information was duplicated

I was very cautious of not removing anything, but rather reorganizing. Everything that was there is still there, except for the non-palette colors explanation as that was redirected to custom variables.
Notes

I recommend checking the deploy preview first when reviewing and comparing it to the actual palette docs
The buttons and mui-core-v5 blog changes were due to the removal of the #adding-new-colors section, and were redirected to the #custom-colors section
I Disabled formatedTSDemos for the palette page. I did it because it was forcing the preview of the examples to be the examples returned JSX, but for these examples, the theme creation section of the code is the important information.

@DiegoAndai The demos look great!

I noticed that the text lists the colors in the order main, light, dark, but the actual demo code the order is light, main, dark – maybe it would be clearest to label the little color chips as well ~

Hey @samuelsycamore and @mj12albert! thanks for the feedback, I implemented it and it's ready for your re-review
@samuelsycamore regarding this comment, maybe we could just list the colors and then link to Material's Color System for the explanations?

@samuelsycamore regarding this comment, maybe we could just list the colors and then link to Material's Color System for the explanations?

That sounds good to me. Go for it! 🤝

@samuelsycamore I reworded the color's descriptions to be shorter and added a link to Material's Color System, let me know what you think 😊


Add size limit for content of comment on action ui

As tile, If the content of comment is to large, just show 200 words on action ui.
fix #12870

Codecov Report

Merging #12881 into master will increase coverage by 0.16%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master   #12881      +/-   ##
==========================================
+ Coverage   42.93%   43.10%   +0.16%
==========================================
  Files         655      655
  Lines       72329    72352      +23
==========================================
+ Hits        31054    31185     +131
+ Misses      36253    36112     -141
- Partials     5022     5055      +33

Impacted Files
Coverage Δ

modules/templates/helper.go
47.26% <ø> (ø)

modules/notification/action/action.go
58.26% <50.00%> (-0.41%)
:arrow_down:

modules/base/tool.go
64.63% <100.00%> (+2.79%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/log/event.go
58.49% <0.00%> (-0.95%)
:arrow_down:

services/pull/pull.go
40.78% <0.00%> (ø)

models/pull.go
55.17% <0.00%> (+0.62%)
:arrow_up:

services/mailer/mail.go
55.91% <0.00%> (+1.07%)
:arrow_up:

modules/queue/workerpool.go
60.00% <0.00%> (+1.22%)
:arrow_up:

modules/notification/notification.go
81.25% <0.00%> (+2.67%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9decf0...39107e9. Read the comment docs.

@a1012112796 Please send backport to v1.12

This code and backport causes panic for large comments -- will send PR to fix


[Question]: how to add memory to existing RAG

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Im trying to add a memory component to my already existing RAG , how can i do this? Here is my existing code
`
vector_retriever_metadata = index.as_retriever(similarity_top_k=2)
retriever_metadata = RecursiveRetriever(
"vector",
retriever_dict={"vector": vector_retriever_metadata},
node_dict=all_nodes_dict,
verbose=True,
)
response_synthesizer = get_response_synthesizer(response_mode="compact", service_context = service_context, streaming=True)
query_engine = RetrieverQueryEngine.from_args(
retriever_metadata, response_synthesizer=response_synthesizer
)
nodes = retriever_metadata.retrieve(prompt)
response = query_engine.query(prompt)
for text in response.response_gen:
full_response += text + ""
`

No this, i want to add memory to remember my previous context

@dosu @logan-markewich is this possible to convert a parent child retriever to have memory?

@dosu can you take my code snippet and convert it?


288 Enable COBOL Check to issue warnings/errors when a call statement is not mocked.

Fixes: #288

@Rune-Christensen
In the testconfig.properties file, what value should I set for cobolcheck.unmock.call.alerttype.error ?

@Rune-Christensen
which logging library do you propose for getting warning log messages?

Hi @AkashKumar7902
We discussed this issue. And have decided that this is the wrong approach. Sorry for not figuring this out sooner.
The work you have done is great, and the tests are spot on, thank you.
COBOL Check should not be issueing warnings or errors for unmocked call statements, while it is processing the unit test and COBOL source. This could result in confusing the end user, because of a requirement to mock every call, even though the call is not used in the unit test.
Instead COBOL Check should add code to the resulting COBOL code that will cause the unit tests to fail, when the user is trying to run a mocked call statement.
It should be possible to enable and disable this, using a configuration variable, that is set to default true. (true means create the error)
Examples:
A call that is not mocked:
100-Demo section.
Call 'dummy'
.

Results in:
100-Demo section.
* Call 'dummy'
Add 1 to number-of-errors
display "Call not mocked in testcase "testcasename" in testsuite "testsuitename"
display "All used calls should be mocked, to ensure the unit test has control over input data"

The same call that is mocked results in:
100-Demo section.
* Call 'dummy'
Evaluate testsuite and testcase
When "some-testsuite" and "some-testcase"
     continue
When other
    perform when-other-section
end-evaluate
.
when-other-section section.

* Call 'dummy'
Add 1 to number-of-errors
display "Call not mocked in testcase "testcasename" in testsuite "testsuitename"
display "All used calls should be mocked, to ensure the unit test has control over input data"
.

Again, sorry for not figuring this out sooner.
I hope you are not discouraged from trying to solve the issue this way.
Thank you

@Rune-Christensen
In the example you provided, what role will number-of-errors play ?

@AkashKumar7902

@Rune-Christensen In the example you provided, what role will number-of-errors play ?

It is the variable that has the number of failed tests when the generated COBOL code is running, i believe the actual variable is called ==UT==NUMBER-FAILED


How to send data image base64 in socket in http?

Hi,
Thanks for repo,
I have a question, How to you convert a image (.png) that is a large character to base64 from clinet side and send data in the socket to server and convert base64 image (.png) of server side  in C in facil ? how to handle to buffer large character?
Thanks,

Hi @ahmedjavad ,
Thank you for your interest in facil.io.
I'm not sure I understand where you might be stuck.
Client side conversions (I'm assuming a browser) would be performed using JavaScript Base64 encoding/decoding.
Server side decoding can use facil.io's Base64 encoding/decoding functions.
Could you provide the code you attempted to use, so I can see where you're experiencing an issue?
Kindly,
Bo.
P.S.
StackOverflow is often a better place to ask questions, as you will receive attention from more developers and your questions might be answered sooner.

@boazsegev Thanks for reply,
I write web socket with HttpPost in the socket,
I know but i don't know how to read image file to base64 in C without use libpng
(https://github.com/glennrp/libpng),
# client.c
int client() {
    // read image path
     char * img = "path/1.png";

   // now how to read image file and convert to base64 ???

   // init socket
   while (){
         // sening data until buffer  = '\0'
  }

  // close socket

  return 0;
}

It looks like your code is in a very early draft.
Are you using facil.io? If so, how? (I don't see it in your question).
Is the client in C as well?
Are you trying to use WebSockets or are you trying to use HTTP POST (these are two different things and it's usually one or the other for the client)?
Please notice that sockets and WebSockets are two different things. Sockets are the lower level TCP/IP sockets and WebSockets is a name of a specific protocol (it starts out as HTTP and uses a specific message framing requirement to allow browsers and servers to send messages to each other without the restrictions of HTTP).
If you're using HTTP POST you don't need to convert the file data to Base64.
Using facil.io, you can do both (this is just a draft, not tested code, it sends the file using HTTP POST):
/* client.c */
#include "facil.h"

#include "fio_base64.h"
#include "http.h"
#include <signal.h>

static void post_file(http_s *h) {
  if (h->status == 0) {
    /* a connection was established, but nothing has happened so far. */

    h->method = fiobj_str_new("POST", 4);      // Set method
    h->path = fiobj_str_new("/", 1);           // Set path
    h->method = fiobj_str_new("image/png", 9); // Set content type

    if (1) {
      /* without converting to Base64 */
      if (http_sendfile2(h, "path/file.png", 13, NULL, 0)) {
        // the file wasn't found or couldn't be sent
      }

    } else {
      /* Base64 requires us to load the image to memory */
      // read the file
      FIOBJ body = fiobj_str_readfile("path/file.png", 0, 0);
      if (!body) {
        /* failed to open file */
        return;
      }
      // require memory - this will update the internal string object
      fiobj_str_capa_assert(body, ((fiobj_obj2cstr(body).len / 3) * 4) + 4);
      // convert to Base64 in place
      fio_cstr_s buff = fiobj_obj2cstr(body);
      int new_len = fio_base64_encode(buff.data, buff.data, buff.len);
      fiobj_str_resize(body, (size_t)new_len);
      buff = fiobj_obj2cstr(body); // the internal string may have moved.
      http_send_body(h, buff.data, buff.len);
      fiobj_free(buff);
    }
    return;
  }
  FIOBJ str = http_req2str(h);
  fprintf(stderr, "Got the following response:\n%s\n",
          fiobj_obj2cstr(str).data);
  fiobj_free(str);
}

static void stop_facil(http_settings_s *settings) {
  kill(0, SIGINT);
  (void)settings;
}

int main(int argc, char const *argv[]) {
  /* code */
  http_connect("http://www.example.com/", .on_response = post_file,
               .on_finish = stop_facil);
  facil_run(.threads = 1);
  return 0;
  (void)argc;
  (void)argv;
}

How to handle and read image file fiobj_str_readfile ? i have problem with read image file format to base64 in the memory client side and write base64 string to image file in server side!?

The file format doesn't matter. Your application doesn't care about the content of the image, only it's binary data.
You should open the file (using the windows equivalent of open or fopen) and read it's raw content into a buffer.
Afterwards you should Base64 encode the buffer.

Are you using facil.io?

No, because this is for windows,

This repo is for facil.io.
If you have questions that aren't about facil.io, please ask them in StackOverflow.com.


Fixed wrong variable name in embedded doc

Current coverage is 88.72% (diff: 100%)

Merging #4704 into master will decrease coverage by <.01%

@@             master      #4704   diff @@
==========================================
  Files           121        121
  Lines         73945      73945
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          65612      65611     -1
- Misses         8333       8334     +1
  Partials          0          0

Powered by Codecov. Last update ef82829...31d8b47

Thanks - LGTM :)

Auto-merge toggled on

@wilzbach what's up with the report that this will decrease coverage? Makes no sense.

@wilzbach what's up with the report that this will decrease coverage? Makes no sense.

It comes from std.concurrency and std.parallelism. Due to undeterministic behavior with multithreading some lines get covered in a specific build and sometimes not.  You can browse these lines on the codecov file output.
Btw Codecov provides two measures (1) patch (only counts modified coverage in the diff - as expected this  didn't change here), and (2) project (overall coverage).


Improve "Porting" guidance for tap developers

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/169
Originally created by @aaronsteers on 2021-07-12 16:17:15

The porting guide is not very good. Specifically, it does not describe the exact contract that the SDK expects, which methods or overrides must be overriden, how to migrate State-management code, etc.
For reference, here is the current doc: https://sdk.meltano.com/en/latest/porting.html
We should expand the available docs and collect feedback from one or more developers who have been through the process.

View 2 previous comments from the original issue on GitLab


Add cluster name option to kind and minikubec commands

Changes

🎁 Added --name, -n flag to be used on the kind and minikube commands

/kind enhancement

Fixes #166

Release Note

Now you can set the cluster name when using the kind or minikube command

Docs

Thanks @gabo1208 👍


Add ipyleaflet representation

A first pass at adding an _ipython_display_ repr to visualize a tile source in Jupyter dynamically
resolves #1059
I'm having a bit of trouble getting this to work consistently for non-geospatial tile sources
This adds a new rest.py module which is leveraged to launch a minimal tile server for a TileSource using a tornado web server (the same web server Jupyter uses, thus requiring no extra dependencies).
The TileLayer creation is abstracted in getIpyleafletTileLayer() so that users can build the tile layer more easily and/or create custom maps.

import large_image

path = 'oahu-dense.tiff'

source = large_image.open(
    path,
    encoding="PNG",
    projection="EPSG:3857",
)
source

from ipyleaflet import Map

t = source.getIpyleafletTileLayer(attribution="My tile source!!")

m = Map(center=source.getCenter(srs="EPSG:4326"))
m.add_layer(t)
m

Potential remaining tasks

[ ] Add testing
[ ] Figure out why the tornado enpoints only work in JupyterLab and break classic notebook. Perhaps switch to using a background thread
[ ] Verify orientation of medical/non-geo images

@zachmullen and I are experiencing issues where the tornado endpoints here are breaking Classic Notebook, but this works fin in JupyterLab

@manthey, this is ready for review. There are some quirks and known issues, but I think this is at a point where it is highly valuable/useful.

This does not work in Classic Notebook, only JupyterLab. We may have to switch to using FastAPI over Tornado for Classic Notebook, but I don't think as many people still use Classic Notebook
See the inline comment above about potential improvements to the map/projection
Testing is just a smoke test to ensure these functions run and don't error (requests are not made)

Let's merge this and refine it in future PRs.


Stack Upgrade Duplication Bug

Issue description:
When using a Stack Upgrade in an interface, then pumping in single items, stacks are inserted into the network.
What happens:
Same as above.
What you expected to happen:
When one item is inserted into an interface with a Stack Upgrade, I expect one item in my storage network.
Steps to reproduce:

Build and power refined storage system.
Add interface with stack upgrade
Add Hopper / Item Conduits / etc.
Use Hopper / Item Conduits / whatever to insert a stack with a size less than 64
Observe as a whole stack enters your network.

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>
Refined Storage: 1.2- beta 2

Does this issue occur on a server? yes
If a (crash)log is relevant for this issue, link it here:
Irrelevant. No console output.

You are not on the newest version at all. Please test if this will work on beta 5

This was fixed in beta-3 I think.  The current version is beta-5.

New version does fix it, apologies.


[BUG] _pickle.UnpicklingError: global 'copy_reg._reconstructor' is forbidden

When using NLTK version 3.8.2, the following line results in an error:
$ python
Python 3.8.8 (default, Mar 31 2021, 12:29:49)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import nltk
>>> sentence_tokenizer = nltk.data.load("tokenizers/punkt/english.pickle")
/usr/local/lib/python3.8/site-packages/nltk/app/__init__.py:45: UserWarning: nltk.app.wordfreq not loaded (requires the matplotlib library).
  warnings.warn("nltk.app.wordfreq not loaded (requires the matplotlib library).")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/nltk/data.py", line 763, in load
    resource_val = restricted_pickle_load(opened_resource.read())
  File "/usr/local/lib/python3.8/site-packages/nltk/data.py", line 667, in restricted_pickle_load
    return RestrictedUnpickler(BytesIO(string)).load()
  File "/usr/local/lib/python3.8/site-packages/nltk/app/wordnet_app.py", line 664, in find_class
    raise pickle.UnpicklingError(f"global '{module}.{name}' is forbidden")
_pickle.UnpicklingError: global 'copy_reg._reconstructor' is forbidden

pickle version is 4.0.0
Fix: Downgrading NLTK from 3.8.2 to 3.8.1 fixes the above issue.

@shrey-gupta-2809, this is now the expected behaviour when you try to load a compex pickle. It solves a highly critical vulnerability: please see #3266.
Because of the severity of the potential attacks, downgrading to 3.8.1 is not advisable.


Updates from App Config Spring Patch

Description
Updating from patch release

API change check
API changes are not detected in this pull request.


Dynamically add methods, events

In<EMAIL_ADDRESS>there were API for adding dynamically events and methods.
That feature is really useful for me.
I have created platform which contains several meteor apps and for each app there is AppName-core package which contains models, validators, consts, etc.
Models stored in AppName-core packages are very minimal, usually fields and validators and common for all apps methods
In every app I extend models of AppName-core packages by adding some methods, which are specific for app.
I would love to see back API which help me doing that.

Class.addMethods
Class.addMethod
Class.addEvents
Class.addEvent

Please... :)

Workaround for methods is:
SSS.Product.prototype.someMethod =  function(){}

Workaround for adding events:
SSS.Product.schema.eventManager.on( 'beforeInit', callback )

Now I clearly see that API I need could be implemented by creating new behaviour. On the way to create my first behaviour ;-)

Hi @parhelium, you can extend the class to achieve what you where doing with addMethod, addEvent...
See http://astronomy.meteor.com/#extending-class

@banglashi well, you are absolutely right !
it looks like I should more focus on reading documentation rather than getting into the source code so quickly ;]

:-) yes I've changed that to more flexible extend() method. Instead of learning each method name you can pass schema extension. From 1.0.0 behaviors work the same way. I think it's a lot easier to work with :-)

Great job @jagi !

My workarounds work fine ( on the left ), but extending class doesn't work ;] ( on the right ) :

It looks it is bug connected with adding methods dynamically, because events works fine:
SSS.ProductGroup.extend({
    events:{
        beforeInit:function(){
            console.log('SSS.ProductGroup.events.beforeInit ')
        }
    }
})

Ok I will take a look at it

Yes it a bug. Hmm and it appears to be something that I've omitted and can be a little bit hard to fix. However it has to be done. I'm getting to work. Thanks for noticing it. Will let you know when I'm done.

Thanks ! Good luck !

Ok I've fixed it. I will have to make some more tests and I will release it. While making this fix I had to make many changes however it won't influence any regular user. However it may have some effect on modules developers. The fix made a code even more readable and faster in some cases :)

Let me know how i can test ( maybe 1.0.1-rc-1  or 1.0.0-rc-7 ) ?

I will just publish 1.0.1 version today

Fixed in 1.0.2

Great, thanks ! Will test it soon :)


Can it be mixed with postprocessing.js for use together? Is there an example?

After use processing, the widget disappears

If I set autoClear to true, it will display, but it will affect the appearance of terrible jagged objects in the scene

https://github.com/pmndrs/postprocessing

That was an issue  with the early versions.
Now fixed, you may need to reinstall it with the updated version 0.1.5.

Strange rotation, I didn't do any additional rotation operations. I only clicked on the x, y, and z of the viewportGizmo to rotate each time. After multiple clicks, the rotation was incorrect. I understood that every click on x, z, and z should be in the positive direction, but in reality, there was a significant deviation or tilt

That's another issues! But now that you're mentioning it, I can clearly see it.
There is a problem with the animation when the target is not centered (0,0,0).
I'll fix it sometimes this weekend. I'll notify you when it's done.

@Fennec-hub ok?

Fix #13


[1254] (Bug) Undeferring trainees when trn is received after deferral

Context

Trello link
If a trainee is submitted for TRN, a job is opened requesting a TRN for said trainee
The trainee may be deferred when waiting for their TRN
The TRN is returned, and the bug is that the trainee is undeferred and put into trn_received state.
We want to keep the deferred state, but still register the TRN
There is a similar problem with withdrawn, but instead of a state change, we get a state transition error (which is fine, but we also want to record the TRN)

Changes proposed in this pull request

Conditional statement before the receive_trn! state change is checking that the trainee is not in a deferred or withdrawn state, insuring that the state change or raised transition error is skipped, and that the TRN is still recorded
Also changed a state_transition spec to test receive_trn event (as this event is what triggers state change) and not the trn_received! method

Guidance to review

Navigate to trainee.rb and state_transitions_spec.rb, specifically the trn_received! method.

 Bug re un-deferring trainees when TRN is received after deferral


feat: Refactor invite modal for handling RBAC updates

Description

Refactoring invite modal-related code for handling RBAC updates

Fixes #15335
Type of change

New feature (non-breaking change which adds functionality)
Refactor

How Has This Been Tested?

Tested if the invite modal works same as before

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=49627c1

/ok-to-test sha=b7b1ca5

/ok-to-test sha=2e7d340

/ok-to-test sha=3f51033

/ok-to-test sha=dd43f33

/ok-to-test sha=2046a8f

/ok-to-test sha=d945ae2

/ok-to-test sha=b8d784e


Provide guidance for publishing .NET Core Web App to an Azure App Service from Visual Studio code

Visual Studio code is one of the favorite IDE recently. ASP.Net Core as a framework as well.
It would be nice to have guidance on how to do that to reach those people who has this preference combination.
I'll working on creating something.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71a44c72-d256-fbee-ea70-2eb7472f8182
Version Independent ID: 157027ff-0bad-828d-a442-a98acd219fba
Content: Publish an ASP.NET Core app to Azure with Visual Studio
Content Source: aspnetcore/tutorials/publish-to-azure-webapp-using-vs.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@ricardoserradas  I agree. I'll try to get this fixed this month.

@vijayrkn please comment

The commandline documentations listed here should work for VS code - https://github.com/aspnet/websdk#folder-publish
We dont have any specific publish support for App Services from VS code.
@Andrew-MSFT & @AngelosP to comment on plans for VS code publish support.

I cannot comment on plans related to Visual Studio Code, my area of responsibility if Visual Studio on Windows.

Hello.
I've created some guidance and added it to a Pull Request, which is related to this issue.
Thanks.
Ricardo Serradas

The commandline documentations listed here should work for VS code - https://github.com/aspnet/websdk#folder-publish
We dont have any specific publish support for App Services from VS code.
@Andrew-MSFT & @AngelosP to comment on plans for VS code publish support.

Oh I understand. What I meant is that we could have a richer guidance, leveraging on either command line and the Azure App Service Extension for Visual Studio Code.
And that's what I've produced and is already available as a PR for you.

Adding @metoly who is looking at our VS Code experience

Thanks @ricardoserradas !
It looks great. I added a few comments to a PR review to eliminate ambiguity regarding downloading the SDK and making sure that the user is aware of having to install the C# extension.

Thanks @ricardoserradas !
It looks great. I added a few comments to a PR review to eliminate ambiguity regarding downloading the SDK and making sure that the user is aware of having to install the C# extension.

Thanks, @metoly. Happy to help!
The comments make total sense, thanks for the review.
I changed according to your observations already.

Thanks, @metoly. Happy to help!
The comments make total sense, thanks for the review.
I changed according to your observations already.

Thanks a lot @ricardoserradas .
I just approved the PR.


Update the project to current numpy and librosa

Hi Jordi,
We are trying to run musicnn but are having issues with both libraries numpy and librosa versions. The problem is numpy==1.14.5 which is quite deprecated, and it is needed to run librosa==0.7.0.
Any suggestion on how to fix it?

Ok, I managed to run the musicnn by moving all the docker image back to 2020
Dockerfile
# Use an official Miniconda3 image as a parent image
FROM continuumio/miniconda3:4.10.3

# Set the working directory to /app
WORKDIR /app

# Create a conda environment with Python 3.6 and activate it
RUN conda create --name myenv python=3.6
SHELL ["conda", "run", "-n", "myenv", "/bin/bash", "-c"]

# Install any needed packages specified in requirements.txt
RUN conda install -y numpy==1.14.5

# Make port 80 available to the world outside this container
EXPOSE 80

# Define environment variable
ENV NAME World

# Copy the current directory contents into the container at /app
COPY . /app


Missing CORS in api

Simply add Access-Control-Allow-Origin: * in any response http header. This will allow us to use axios.js or fetch with your api endpoint.
Access-Control-Allow-Origin
CORS
Thank you!

A wildcard here is a dangerous header to add.  You should whitelist sites that will be using with a reverse proxy or AMP's built in ngimx support.

This is a security hazard. You should invoke the API from a server side application rather than in a browser directly, or use a reverse proxy so you can specify a safe value.


Aggregate weights in duplicated elements for GPU GK.

See comments in the patch.
I tried to accumulate all the weights from duplicated entries and it became quite messy with multiple batches.  To achieve that, we first need to refactor hist_util.cuh and make ExtractCuts part of QuantileContainer, then add the scanned weights from all previous batches to rmin and rmax of new entries.

On a second thought, let me do some refactoring first.


Support Labeled Metrics in Sinks

cc: @piosz

Log, Influxdb, Riemann and Kafka are done.
Hawkular, GCM are pending.


For formatting of Advanced logging example

Summary
Before

After

Ticket Link
None

@cwarnermm I wish the docs were a bit more clear that the Advanced logging section applies to the general logging section  and the audit logging section.  The only difference is the log levels.

Agreed, @wiggin77. I'll work a clarification update into the v9.8 docs.