Pass additional parameters to property mapper methods

Is your feature request related to a problem? Please describe.
I'm trying to migrate this AutoMapper code to Mapperly:
.ForMember(
     blog => blog.IsLiked,
     cfg => cfg.MapFrom(record => record.BlogLikeRecord.Any(bl => bl.UserId == currentUserId)));

This currently does not work.
[Mapper(AutoUserMappings = false)]
public static partial class BlogsMapper
{
    [MapPropertyFromSource(nameof(BlogEntry.IsLiked), Use = nameof(GetIsLiked))]
    public static partial BlogEntry MapToBlogEntry(BlogEntryRecord record, int currentUserId);

    public static partial IQueryable<BlogEntry> ProjectToBlogEntry(this IQueryable<BlogEntryRecord> query, int currentUserId);

    private static bool GetIsLiked(BlogEntryRecord record, int currentUserId) => record.BlogLikeRecord.Any(bl => bl.UserId == currentUserId);
}

Describe the solution you'd like
When name and type match, pass additional parameters from Map/Project method to property mapping methods.
// <auto-generated />
#nullable enable
namespace Blogs
{
    public static partial class BlogsMapper
    {
        [global::System.CodeDom.Compiler.GeneratedCode("Riok.Mapperly", "<IP_ADDRESS>")]
        public static partial global::Blogs.BlogEntry MapToBlogEntry(global::Blogs.BlogEntryRecord record, int currentUserId)
        {
            var target = new global::Blogs.BlogEntry();
            target.IsLiked = GetIsLiked(record, currentUserId);
            return target;
        }

        [global::System.CodeDom.Compiler.GeneratedCode("Riok.Mapperly", "<IP_ADDRESS>")]
        public static partial global::System.Linq.IQueryable<global::Blogs.BlogEntry> ProjectToBlogEntry(this global::System.Linq.IQueryable<global::Blogs.BlogEntryRecord> query, int currentUserId)
        {
#nullable disable
            return System.Linq.Queryable.Select(
                query,
                x => new global::Blogs.BlogEntry()
                {
                    IsLiked = x.BlogLikeRecord.Any(bl => bl.UserId == currentUserId)
                }
            );
#nullable enable
        }
    }
}

Describe alternatives you've considered
Move this logic outside of mapper could be one solution. But, I think, Mapperly should be able to support this.

And there seems to be a bug that IQueryable projections do not work with additional parameters.


could not invoke TfliteReactNative.loadModel is null models/mobilenet_v1_1.0_224.tflite

I am facing this problem.

i am too. :((

Hi guy. i already sovle this problem( see https://github.com/reneweb/react-native-tensorflow/issues/34).

Run yarn add --dev metro metro-core
Run yarn install
Replace file metro.config.js
module.exports = {
resolver: {
assetExts: ['pb', 'txt', 'jpg']
}
}

really? TFLite ending is .tflite not .pb so how could this one help?

I have also the probably same issue:
[15:20:16] E | ReactNativeJS ▶ 'Got error on init(): ', { [TypeError: null is not an object (evaluating 'TfliteReactNative.loadModel')]
                             │ line: 115254,
                             │ column: 26,
                             └ sourceURL: 'http://localhost:8081/index.bundle?platform=android&dev=true&minify=false' }

This is how I initialize the model:
    async init(protobuf, labels) {
        try {
            console.log( "started initialization of TENSOR FLOW LITE" );
            let tfLite = new Tflite();
            await tfLite.loadModel( {
                model: this.props.protobuf, // required
                labels: this.props.labels,  // required
                numThreads: 1,              // defaults to 1
            } );
            this.setState( {tfLite: tfLite} );
        } catch ( err ) {
            if ( err.description === "cancelled" ) {
                console.log( "cancelled by user" );
            }
            console.error( "Got error on init(): ", err );
        }
    }

I'm passing the path to model file and labels as props. This approach is working exactly the same way for react-native-tensorflow but with a .pb file of caurse instead of an .tflite file as in this case.
I tried with putting file:// before the actual file, but didn't help.

Any updates on how to fix this? I am also getting this same error. I used the example code provided in the repo and have placed the models and labels in the android/app/src/main/assets directory as well, and in a models directory in my react-native code src.

nope and the project seams not to be updated as frequently as it should to become reliable.
I suggest you check out the real deal: https://github.com/tensorflow/tfjs/tree/master/tfjs-react-native
just compare the stars

Hey @Macilias, thanks for the suggestion will look into it as well!
I finally got it to work by the following steps:

Create the assets directory in the app folder via Android Studio.

Open the android project in Android Studio, then click on the app folder
The go to File > New > Assets Folder
Select main as the target source set.

Create a models folder in the assets directory and placed all models and labels and labels which are available in the example code.
Now, when I used the example code it worked correctly.

@marikani @ShaharyarMaroof
I couldn't solve it by following what you did.
Help me =/

Hey @robsonpsdesv I was able to get the model up by following these steps which are similar to the ones @ShaharyarMaroof did

Make a new folder called  assets in app/src/main/
Place the model file (tflite and txt) on to the folder
Add to android/app/build.gradle the lines from the README (I normally put it towards the end of the file)

aaptOptions {
        noCompress 'tflite'
    }

And then call the loadModel function

Do let us know what your error might have been

Yes @ShaharyarMaroof succecfuly, tks;)

I'm also getting same error. I'm sure I followed the instructions correctly.
I also tried to load model with react-native-fs but it's also same.

I have also the same issue:
Could not invoke TfliteREactNative.loadModels
null
/path/to/my/model.tflite

This is how I initialize the model:
    async init() {
        try {
            console.log( "started initialization of TENSOR FLOW LITE" );
            let tfLite = new Tflite();
            await tfLite.loadModel( {
                model: this.props.protobuf, // required
                labels: this.props.labels,  // required
                numThreads: 1,              // defaults to 1
            } );
            this.setState( {tfLite: tfLite} );
        } catch ( err ) {
            if ( err.description === "cancelled" ) {
                console.log( "cancelled by user" );
            }
            console.error( "Got error on init(): ", err );
        }
    }

I'm passing the path to model file and labels as props. This approach is working exactly the same way for react-native-tensorflow but with a .pb file of caurse instead of an .tflite file as in this case.
I tried with putting file:// before the actual file, but didn't help.
By the way:
First I had this one:
[15:20:16] E | ReactNativeJS ▶ 'Got error on init(): ', { [TypeError: null is not an object (evaluating 'TfliteReactNative.loadModel')]
                             │ line: 115254,
                             │ column: 26,
                             └ sourceURL: 'http://localhost:8081/index.bundle?platform=android&dev=true&minify=false' }

but it was due of missing steps from Android part, so I'm adding it here, just in case someone else ends up in the same situation and needs quick help.

Hello, if possible, can you please share your working code?
I'm getting same error and none of those methods are working.

My solution is related with emulator. If you are using real device it works.

Since the official docs do not tell us to create a 'models' directory inside the 'assets' directory, removing 'models' from the path should work.
tflite.loadModel({
  model: 'mobilenet_v1_1.0_224.tflite',// required
  labels: 'mobilenet_v1_1.0_224.txt',  // required
  numThreads: 1,                              // defaults to 1
},


Plan to support wintun for backend?

On windows, wintun (WireGuard/wintun) needn't install. Only work with a dll file.

v3 has changed tun from water to wireguard.


Prefix both transition & transform for iOS Safari 8 and older

I'm using stylis via styled-components and I noticed a bug in iOS 8 and older.
When using a style like this transition: transform 600ms ease;, iOS Safari 8 and older requires both properties to be -webkit- prefixed.
Current stylis output:
-webkit-transition: transform 600ms ease;
transition: transform 600ms ease;

Needs to also include a double prefixed rule like this:
-webkit-transition: transform 600ms ease;
-webkit-transition: -webkit-transform 600ms ease;
transition: transform 600ms ease;

More info on this behavior: http://stackoverflow.com/questions/20669190/browser-specific-prefixes-with-a-css-transition-on-transform
Thanks!

Thanks @ryanheathers will push a patch for this.

This should be patched in v2.0.12

Awesome, thanks for the fast fix!


removed http://parrotgeek.net/repo/ as requested

https://twitter.com/parrotgeek1/status/881013946337157120

I'm parrotgeek1, and I approve this message.

It was already commented out so I’m not going to submit a deb update, as it won’t change anything on people’s devices.
It’ll be rolled through the next substantial change.
Thanks!


[Feature]: add github action workflow for greeting contributors

Description
The current project lacks an automated action to greet contributors. GitHub Actions can significantly enhance project automation. I propose adding a GitHub Action workflow to greet new pull request (PR) and issue creators, fostering a welcoming environment.
Proposed Changes:
Implement a GitHub Action workflow that triggers on new PRs and issues. The workflow should include a greeting message to acknowledge and appreciate the contributors for their efforts.
Expected Behavior:
When contributors create new PRs or issues, the GitHub Action should automatically trigger and post a welcoming message, acknowledging their contributions.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[X] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Issue is already open for this @harmeetsingh11


DEP: adjust deprecation of positional arguments

Reference issue

https://github.com/scipy/scipy/issues/18578#issuecomment-1569500078
What does this implement/fix?

In the past, when deprecating an argument to a function that we want to remove, we have used the argument being different from the default value of None to trigger the deprecation warning. However, as pointed out by @rgommers, the current method we are using to deprecate arguments we want to remove was not entirely watertight if the user uses all positional arguments.
As an example, kendalltau(x, y, None, 'omit', 'exact') would not raise the deprecation warning so we are in danger of breaking the user's code without warning if this was removed directly. Side note, this is yet another reason why making new code use keyword-only arguments when applicable is desirable.
As per @rgommers suggestion, I have added a private _NoValue object which is used to trigger the deprecation warning. This means now:
In [2]: kendalltau([1,4], [1,2], None, 'omit', 'exact')
<ipython-input-2-e55511017c59>:1: DeprecationWarning: 'kendalltau' keyword argument 'initial_lexsort' is deprecated as it is unused and will be removed in SciPy 1.12.0.
  kendalltau([1,4], [1,2], None, 'omit', 'exact')

as required to remove the argument.
Additional information

cc @h-vetinari

If we're extending the deprecation by two releases, I'd like to fully deprecate positional use of all kwargs along the lines of #14714. Example below.

It seems to me like this is trying to reopen the gh-14714 discussion, and it's not really related to the topic of this PR - which is only about ensuring warnings for already deprecated keywords are always emitted. I'd suggest not mixing new deprecations into this PR.

If we're extending the deprecation by two releases, I'd like to fully deprecate positional use of all kwargs along the lines of #14714. Example below.

I'm not sure I follow, this would increase the number of people affected by the deprecation massively regardless of their use of the deprecated behaviour.

I'm not talking about all functions, I'm talking about all positional arguments in the function being changed here. As soon as we start touching the (positional) signature, we should switch the respective options to keyword-only.

I'd still say that that is orthogonal to this PR, and can/should be done separately. It can be done for the next release for some or all functions in this PR if you really want, but I'm ambivalent about it at best.

I'd still say that that is orthogonal to this PR, and can/should be done separately

This PR already makes positional usage of all arguments following the ones defaulting to _NoValue effectively impossible (unless users hack around and provide _NoValue positionally, which is an effort I doubt anyone would do). For example:
def kendalltau(x, y, initial_lexsort=_NoValue, nan_policy='propagate',
               method='auto', variant='b', alternative='two-sided'):

will always raise for positional usage of any argument past y, and therefore already implicitly does what I propose to do explicitly (and I'd say, in a more self-explanatory way).

but I'm ambivalent about it at best.

The discussion in #14714 basically boils down to (please correct me if you have a different impression): it's an improvement, but not worth it for a wholesale change, however it is beneficial to adopt when we're already changing the signature of a function (as we'll be doing here once we remove the _NoValue arguments).

The discussion in #14714 basically boils down to (please correct me if you have a different impression): it's an improvement, but not worth it for a wholesale change, however it is beneficial to adopt when we're already changing the signature of a function (as we'll be doing here once we remove the _NoValue arguments).

Yeah that's about right I think. That said, I think this PR does not make such changes, it only makes pre-existing deprecations more correct. Hence I'm saying it's an orthogonal change and should not block merging this PR.

I'm on holiday so I won't be making any changes for at least a week but it seems the way forward is to implement @rgommers suggestions and then look at @h-vetinari's in a follow-up pr.

That said, I think this PR does not make such changes

If you look at the kendalltau example I gave, replacing the default with one that's (intentionally) not user-accessible is exactly equivalent to deprecating positional arguments (i.e. there no way[^1] to keep x, y, None, ... positional), only that the warning here hides that fact rather than highlight it. So I don't think it's orthogonal.
[^1]: up to importing the private _NoValue and using that, but that's hardly API usage we want to encourage

It's true for kendalltau only because it's the first keyword that was deprecated

I understand that; positional use becomes impossible exactly for kwargs following those now defaulting to _NoValue. However, my main point here is that the message "kwarg X is deprecated" does not communicate, much less explain, that all following positional arguments need to be changed (how? why?). I think this has the potential for substantial frustration, hence why I'd like to be clear about that upfront.
While we're still touching the signature of simpson (the bar that was set for #14714), I'm fine if we exclude functions where the _NoValue default is for the last argument. In that case we can do the change to kwarg-only separately, but all the functions where we're already breaking positional use (of any non-deprecated argument) should just be deprecated and changed once.

However, my main point here is that the message "kwarg X is deprecated" does not communicate, much less explain, that all following positional arguments need to be changed

It's the only way to get rid of the deprecation warning, this PR in its current state is perfectly fine. There is no room for confusion here.

There is no room for confusion here.

That's a stretch, given how there's a very plausible scenario for confusion (positional use that now becomes impossible), especially given that the warning does not guide people to the right solution (i.e. "please use keyword arguments").
But before we continue going in circles, I'll drop my concerns for this particular PR, and I can open another issue for 1.12 that targets this topic.

I couldn't follow the discussion here but could someone let me know what the implication would be for #18488 ?

I couldn't follow the discussion here but could someone let me know what the implication would be for #18488 ?

You're deprecating the tol keyword there, right? You want to be using the same _NoValue pattern as in this PR. Right now, I believe in your branch, something like bicg(A, b, x0, None, 100) won't raise a deprecation warning (because it's gated by tol is not None), and then once tol gets removed that code breaks. The purpose of the _NoValue pattern is to distinguish between "user doesn't use keyword" and "user uses keyword explicitly with its default value"

OK, that means, I'll wait for a deprecation cycle starting from 1.12 to 1.14 if anybody sets tol with positional arg which is your example. Then 1.14 rips tol out. But in the meantime am I also putting * for strict kwarging? Because I want to :) since there are like 4 different deprecations going on simultaneously in the iterative solvers. I got a bit tired of them just by looking.
That was the part I didn't parse in this discussion.

But in the meantime am I also putting * for strict kwarging?

That's gonna need an additional deprecation for those people feeding the current kwargs positionally. This is what the above-promised issue will be about, because doing that deprecation is more involved (if starting from scratch, which is why we should build on the work from scikit-learn on this).
So no * just yet, but also for 1.14 once the depreciation expires.

So no * just yet, but also for 1.14 once the depreciation expires.

This is right.

That's gonna need an additional deprecation for those people feeding the current kwargs positionally.

It may not, depending on the details - in @ilayn's case I think this does not require an additional deprecation since tol is already the first keyword of the ones of interest (I suspect leaving x0 as positional is fine/desired, because it's not a meaningful name). Current signature:
bicg(A, b, x0=None, tol=None, maxiter=None, M=None, callback=None, atol=0., rtol=1e-5)

New signature for 1.14.0 with only the deprecation that's already there plus the _NoValue pattern:
# You may also reorder the keywords at that point if you desire to do so for clarity
bicg(A, b, x0=None, *, maxiter=None, M=None, callback=None, atol=0., rtol=1e-5)

There's of course more issues (e.g. M is a very bad name); if you'd have the freedom to start from scratch it'd be more like:
# Order these keywords from most to least used
bicg(A, b, /, *, guess=None, atol=0., rtol=1e-5, maxiter=None, preconditioner=None, callback=None)

...  (i.e. "please use keyword arguments").

@h-vetinari perhaps you can follow up with a minor concrete tweak to @ilayn's deprecation message? I suspect it may be annoying to get that right (because you don't know when it applies without more introspection) and it may not be worth it, but please do try to make it concrete, because it'll be obvious once you actually try.

Ah OK it's much clearer for me now too. This PR looks indeed then ready to go, and we can do some follow ups right after this. 1.12 looks like the big clean-up with all the fortran, signatures, and deprecations and so on :) Let me take the discussion to #18488 then and what it would take to mark it as down.

Sounds good to me!

@j-bowhay Oops, I created a conflict, sorry about that. In the meantime, I'm preparing another PR for iterative kwargs having _NoObject. Should I wait for you or get the declaration in the new PR?

@ilayn I have hopefully addressed all @rgommers comments so this should be good to go if it comes back green. I ended up removing any of the changes to the iterative solver as I thought it would be easier to add it to your pr and do them all at once rather than hunt through the merge conflicts for my changes

This is what the above-promised issue will be about

https://github.com/scipy/scipy/issues/18703

Just to confirm, is everyone happy to click the button about this?

All thumbs up from the participants and thanks all for the discussions. It is quite informative for me too.


Installed JDK in Mac, But can show it with system command /usr/libexec/java_home

We require a conversation to take place in the appropriate Gitter Room before raising a new Github Issue. Please note that issues will be closed immediately if prior discussion did not take place. We need to do this to help manage the quality and validity of Issues raised on this project.
Please tick one:

[ ] this is a new Feature Request, a conversation was started in the Gitter CLI Development Room.
[x] this is a new Bug Report or Issue, a conversation was started in Gitter User Issues Room.

Please explain the Issue / Feature Request here:
Hi
I was installed JDK on MacOs, But can show it with command /usr/libexec/java_home -X.
And Eclipse can not run with this JDK. It is need install another one.
It is anyway to fix this?  Thanks.

Please follow the contributor guidelines before opening an issue. That means that you do what the tick box above says: start a discussion on our gitter user issues chat where we will answer your questions.
This is not a bug but a problem with your local environment so closing the issue now.


Improve description of secstorage.encrypt.copy

Description
The description of the configuration secstorage.encrypt.copy fails to mention that it is also used to make sure the certificate assigned to the zone is used when creating links for external access (download/upload of disks,templates and ISOs). This PR improves this description.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

How Has This Been Tested?
I built the code and applied it in a local lab. After the patch the description was successfully updated.

@GaOrtiga can you fix the conflicts, thanks.


End of Operations Year initial pick for the same year of Start of Operations shows wrong error message.

Describe the Bug
There is a bug on showing validation error message on "End of Operations" year .
When adding a new FOM, picking a year from "End of Operations" field with the same year as "Start of Operations" field should not show message: "Must be equal to or later than the Start of Operations".

However, if user starts using date-Picker on "Start of Operations", the error message shows correctly:

Switching "Start of Operations" back to 2024 and "End of Operations" back to 2024, it behaviors correctly.

Expected Behaviour
The error message should only be shown when "End of Operations" year < "Start of Operations" year.
** Steps To Reproduce**

Add new FOM.
Pick first available Year from date-picker (the same as "Start of Operations" year).
Error message shows.

Additional context

Backend does have same validation in place.

@ianliuwk1019 - this seems OK, except that the first time I select an end date equal to the start date, the error message briefly flashes then disappears.

Hi @gormless87 - thank you for verifying. Since main function is good, I will create a ticket for the minor initial date-pick slashing seen issue for this separately.


Feature request: change the audio Device used

Some versions of moonlight have a "--audio" flag on execution that allow the user to specify which hardware device to output sound from. The snap version does not appear to have an easy way for users to change where the audio comes from on the client side (3.5mm jack, HDMI, bluetooth device, or all of the above).
Is this expected behavior for the snap version?

Hi! This is just the moonlight-qt software packaged as a snap. As such, this snap neither adds or removes any options available in moonlight-qt. That said, moonlight stream --help shows an option to switch between stereo and 5.1 sound, and another for playing audio on the host or the client.
I think the client's sound configuration needs to be tuned at a lower level, e.g. pulseaudio in Linux.


Set theme settings in hot reload

Noticed this bug in my personal app where on hot reload the theme settings wasn't getting properly set

Gonna cut a new release, so gonna just merge this for you.


Cass

Description: Github Workflow
❗❗❗❗❗❗❗❗❗❗❗❗❗❗
Fixes key error in back end tests
Adds more back end tests
Updates documentation
❗❗❗❗❗❗❗❗❗❗❗❗❗❗
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Automatic tests
[ ] Manual tests. Please outline

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

README looks great! Nicely done.
I'd probably put the 'Usage' section near the top though. Adding something in the 'Motivation' section that mentions the project uses DS techniques to evaluate clickbait would be a good idea as well.


error: package u-boot is not available, refusing to evaluate

I'm on a MacBook Pro 14 with an M1 Pro.
I've followed the installation instructions using the latest iso from the releases page. At the point where I am running nixos-install, I get the following error:
error: Package uboot-apple_m1_defconfig-2023.04.asahi2-1 in /nix/store/hmm1q79xgziadmx7hymqcvv3ingn3b8z-nixos-23.11.20230605.7409488/nixos/pkgs/misc/uboot/default.nix:124 is not available on the requested hostPlatform:
        hostPlatform.config = "x86_64-unknown-linux-gnu"
        package.meta.platforms = [
          "aarch64-linux"
        ]
        package.meta.badPlatforms = [ ]
        , refusing to evaluate.

It further suggests that I enable nixpkgs.config.allowUnsupportedSystem, but doing so leaves me with another error: an x86_64-linux with features {} is required to build <networkmanager>, but I am a aarch64-linux with features {benchmark, big-parallel, gccarch-armv8-a, kvm, nixos-test}
I can't seem to find anything online about this particular problem, and I am not experienced enough with nixpkgs to understand if there's something I'm doing that's causing this or not.

I apologize, this was a bug introduced by upstream Nixpkgs in nixos-generate-config that I forgot to address.
Open up /mnt/etc/nixos/hardware-configuration.nix, delete the line which references x86_64-linux, and you should be good to run the install command again. If you ever need to run nixos-generate-config again, you will need to redo this step.
I will work on getting this fixed.

(The support you've been providing for free is considerably better and more timely than some that I've paid for. Thank you!)

https://github.com/NixOS/nixpkgs/pull/237218
Hopefully this will make its way to the release channel in a few days and I will do a new release.

This is fixed in the latest release.


Joining together MonoidAggregators should produce a MonoidAggregator

Right now if you do any kind of join on multiple instances of MonoidAggregator you get an Aggregator back. It would be nice if, in the case that everything being joined is itself a MonoidAggregator, you got something that was still a MonoidAggregator.

this would be good.


Dockerfile doesn't build correctly

There are several issues when trying to build the included Dockerfile the output below is taken from a single docker build but has been truncated to only show the errors happy to include the full output if it will help.

Ubuntu 20.04.2 LTS
Linux ip-172-31-9-167 5.4.0-1038-aws #40-Ubuntu SMP Fri Feb 5 23:50:40 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Docker version 19.03.8, build afacb8b7f0

ubuntu@ip-172-31-9-167:~/CyberBattleSim$ sudo docker build -t cyberbattlesim .
Sending build context to Docker daemon  22.37MB
Step 1/9 : FROM mcr.microsoft.com/azureml/onnxruntime:latest-cuda
latest-cuda: Pulling from azureml/onnxruntime
92dc2a97ff99: Pull complete
be13a9d27eb8: Pull complete

...
Reading state information...
11 packages can be upgraded. Run 'apt list --upgradable' to see them.
./init.sh: line 70: curl: command not found
Reading package lists...
Building dependency tree...

...
Setting up libxml-parser-perl (2.44-2build3) ...
Setting up intltool (0.51.0-5ubuntu1) ...
Setting up python-distutils-extra (2.41ubuntu1) ...
Processing triggers for mime-support (3.60ubuntu1) ...
Processing triggers for libc-bin (2.27-3ubuntu1.4) ...
./init.sh: line 81: npm: command not found
update-alternatives: using /usr/bin/python3.8 to provide /usr/bin/python (python) in auto mode
update-alternatives: using /usr/bin/python3.8 to provide /usr/bin/python3 (python3) in auto mode
Checking node version...
Node version 8.10.0 too old, min expected is 10.15.2, run:
 npm -g upgrade node
Installing the Plotly orca dependency for plotly figure export
Reading package lists...
Building dependency tree...

...
  xfonts-encodings xfonts-utils xkb-data xserver-common xvfb
0 upgraded, 196 newly installed, 0 to remove and 11 not upgraded.
Need to get 109 MB of archives.
After this operation, 394 MB of additional disk space will be used.
Do you want to continue? [Y/n] Abort.
./install-orca.sh: line 16: npm: command not found
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1882k  100 1882k    0     0  25.8M      0 --:--:-- --:--:-- --:--:-- 25.8M
Python 3.8.9
Collecting pip

...
Collecting numpy_stubs@ git+https://github.com/numpy/numpy-stubs/@master#egg=numpy_stubs
  Cloning https://github.com/numpy/numpy-stubs/ (to revision master) to /tmp/pip-install-9fc0qms6/numpy-stubs_634e348c036d4d6daa4c3dbd265e72ce
  Running command git clone -q https://github.com/numpy/numpy-stubs/ /tmp/pip-install-9fc0qms6/numpy-stubs_634e348c036d4d6daa4c3dbd265e72ce
  ERROR: Error [Errno 2] No such file or directory: 'git' while executing command git clone -q https://github.com/numpy/numpy-stubs/ /tmp/pip-install-9fc0qms6/numpy-stubs_634e348c036d4d6daa4c3dbd265e72ce
ERROR: Cannot find command 'git' - do you have 'git' installed and in your PATH?
./init.sh: line 125: pre-commit: command not found
Compatible version 3.8.9 of Python detected at /usr/bin/python3.8
Creating type stubs
./createstubs.sh: line 14: pyright: command not found
~
Removing intermediate container 27bc944a639d
 ---> 8f1bc73cb557

@kevthehermit Should be fixed by #11


adding kics remediation support

Description

Adding KICS remediation command.

References

https://checkmarx.atlassian.net/browse/AST-14773

Testing

Tests

Checklist

[] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used

Checkmarx AST – Scan Summary & Details – 2d6b2ab0-fc65-4930-ad3a-5cf3039abc23
New Issues

Severity
Issue
File / Package
Scan Engine

HIGH
ALB Listening on HTTP
/src/test/resources/positive1.tf: 9
CxKICS

MEDIUM
ALB Not Dropping Invalid Headers
/src/test/resources/positive1.tf: 15
CxKICS

LOW
ALB Deletion Protection Disabled
/src/test/resources/positive1.tf: 15
CxKICS

LOW
IAM Access Analyzer Not Enabled
/src/test/resources/positive1.tf: 1
CxKICS

LOW
Shield Advanced Not In Use
/src/test/resources/positive1.tf: 15
CxKICS


Error when running weight averaging.

python run_weight_averaging.py
selecting checkpoints...
selecting checkpoints...
loading model Models/FastSpeech2_Cherokee_West/checkpoint_200000.pt
loading model Models/FastSpeech2_Cherokee_West/checkpoint_199000.pt
loading model Models/FastSpeech2_Cherokee_West/checkpoint_198000.pt
loading model Models/FastSpeech2_Cherokee_West/checkpoint_197000.pt
loading model Models/FastSpeech2_Cherokee_West/checkpoint_196000.pt
averaging...
saving model...
...done!
selecting checkpoints...
Traceback (most recent call last):
  File "run_weight_averaging.py", line 120, in <module>
    make_best_in_all(n=5)
  File "run_weight_averaging.py", line 105, in make_best_in_all
    averaged_model, default_embed = average_checkpoints(checkpoint_paths, load_func=load_net_fast)
TypeError: cannot unpack non-iterable NoneType object

It looks like you have a directory in your Models directory that's empty, so the script looks for models to average in there, but doesn't find any. I'm going to hotfix it later.

Actually, such a check was already in place. I tried to make it capture some more, but I don't think there's much of a difference. I don't see a reason why this would fail, you probably have a file somewhere in the Models directory or in one of its subdirectories which the function parsing for checkpoints doesn't expect.

Thanks. Yes, that is very likely...


HDDS-1225. Provide docker-compose for OM HA.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
60
Docker mode activated.

_ Prechecks _

0
yamllint
0
yamllint was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1143
trunk passed

+1
compile
66
trunk passed

+1
mvnsite
28
trunk passed

+1
shadedclient
720
branch has no errors when building and testing our client artifacts.

+1
javadoc
22
trunk passed

_ Patch Compile Tests _

-1
mvninstall
20
dist in the patch failed.

+1
compile
18
the patch passed

+1
javac
18
the patch passed

+1
mvnsite
21
the patch passed

+1
shellcheck
0
There were no new shellcheck issues.

+1
shelldocs
17
The patch generated 0 new + 104 unchanged - 136 fixed = 104 total (was 240)

-1
whitespace
4
The patch has 75 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1
whitespace
5
The patch 19849  line(s) with tabs.

+1
shadedclient
1070
patch has no errors when building and testing our client artifacts.

+1
javadoc
18
the patch passed

_ Other Tests _

+1
unit
23
dist in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3425

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/562

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  yamllint  shellcheck  shelldocs

uname
Linux 0b5bb784f557 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 62e89dc

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/artifact/out/whitespace-eol.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/artifact/out/whitespace-tabs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/testReport/

Max. process+thread count
304 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thanks the patch @hanishakoneru . It looks good to me.
One comment: please note that @ajayydv proposed to rename ozoneManager everywhere to om in HDDS-1216
It's not yet committed but it could be useful to switch to that convention (but it also can be done later...)

Thanks for the review @elek . I renamed ozoneManager to om.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
20
Docker mode activated.

_ Prechecks _

0
yamllint
0
yamllint was not available.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1243
trunk passed

+1
compile
66
trunk passed

+1
mvnsite
28
trunk passed

+1
shadedclient
692
branch has no errors when building and testing our client artifacts.

+1
javadoc
28
trunk passed

_ Patch Compile Tests _

-1
mvninstall
19
dist in the patch failed.

+1
compile
19
the patch passed

+1
javac
19
the patch passed

+1
mvnsite
24
the patch passed

+1
shellcheck
0
There were no new shellcheck issues.

+1
shelldocs
14
The patch generated 0 new + 104 unchanged - 136 fixed = 104 total (was 240)

-1
whitespace
4
The patch has 75 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1
whitespace
5
The patch 19849  line(s) with tabs.

+1
shadedclient
1016
patch has no errors when building and testing our client artifacts.

+1
javadoc
17
the patch passed

_ Other Tests _

+1
unit
24
dist in the patch passed.

+1
asflicense
27
The patch does not generate ASF License warnings.

3398

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/562

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  yamllint  shellcheck  shelldocs

uname
Linux db61dcbb1e8a 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 2c3ec37

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

shellcheck
v0.4.6

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/artifact/out/whitespace-eol.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/artifact/out/whitespace-tabs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/testReport/

Max. process+thread count
309 (vs. ulimit of 5500)

modules
C: hadoop-ozone/dist U: hadoop-ozone/dist

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-562/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

The unit test failure is unrelated and fails on trunk too.


Support Flatpak/snap/Appimage

Hi
Nowadays flatpak/appimage/snap can cover multiple distributions without bound by packaging. Is it possible to support Flatpak/Appimage/Snap?

Adding this to backlog.

In case anyone has an experience in packaging desktop Linux applications and wants to give a hand - you'll be more than welcome.

In case anyone has an experience in packaging Linux applications and wants to give a hand - you'll be more than welcome.

I could help with Flatpak, but before I contribute an appstream metadata file. Are you @anfragment willing to update the release information, for every release? It's only a couple of lines of xml code not more.

@Ferenc- thanks for your suggestion, but I believe that making the app work in Flatpak would require a more involved setup. The app relies on having access to the root filesystem and some CLI tools, which makes me think that I'll need to fiddle with the app manifest myself to ensure everything works as it should.


ActiveForm: validation error not showing with Bootstrap 4 when using custom input template

The issue is related to the extension yiisoft/yii2-bootstrap4 but I think it is due to a compatibility issue of yiisoft/yii2
What steps will reproduce the problem?
Model
class TestForm extends \yii\base\Model
{
    public $demo;
    public function rules()
    {
        return [
            // define validation rules here
            [['demo'], 'required'],
            [['demo'], 'string', 'length' => [2, 4]],
        ];
    }
}

View
The input error is manually separated from the input field (for example, the error is needed at the top of the form during ajax validation)
<?php $form = ActiveForm::begin(['id' => 'test-form',
'options' => [
	'class' => 'form-horizontal'],
	'enableAjaxValidation' => true,
	'enableClientValidation' => false,
])
?>

<?= $form->errorSummary($model) ?>

	<?php echo $form->field($model, 'demo', ['template' => "{error}"]); ?>

	<?= $form->field($model, 'demo', ['errorOptions' => ['tag' => false]])->textInput()->label("Demo") ?>

Controller
    public function actionTesterror()
    {
        $model = new TestForm();

        // Ajax validation
        if (Yii::$app->request->isAjax){
            $model->load(Yii::$app->request->post());
            Yii::$app->response->format = Response::FORMAT_JSON;
            $ret = ActiveForm::validate($model);
            Yii::info("Test Error Visualization: " . json_encode($ret));
            return $ret;
        }
        return $this->render('testerror', ['model' => $model]);
    }

What is the expected result?
The error message Demo cannot be blank is visible.
What do you get instead?
The error message Demo cannot be blank is not visible.
Additional info
The issue is related to how the visualization of the error messages are handled in Bootstrap 4.
The {error} of the input demo should be displayed in a
 which does not contain the actual input tag.
In Bootstrap 4 this creates a visualization issue due to the fact that the validation errors are set with display:block or display:none depending on the class of a sibling tag (i.e. the input tag). The css code contains in fact the “sibling combinator” ~.
.was-validated :invalid ~ .invalid-feedback,
.was-validated :invalid ~ .invalid-tooltip,
.is-invalid ~ .invalid-feedback,
.is-invalid ~ .invalid-tooltip {
  display: block;
}

Working solution
Two additional lines can be added to the function updateInput in yii.activeForm.js, in order to force the setting of "display": "block":
// Patch: show errors when input {error} is not in the default position
$(attribute.container).children(attribute.error).css({"display": "block"});
// ...
// Patch: hide errors when input {error} is not in the default position
$(attribute.container).children(attribute.error).css({"display": "none"});

I have the modified version of yii.activeForm.js in the branch "custom" of my fork david-it/yii2-framework

Q
A

Yii version
2.0.32

yii2-bootstrap4
<IP_ADDRESS>

PHP version
7.3.14

Operating system
Raspbian Buster

Have you setup up properly ActiveForm with BS4 horizontal layout with proper namespace?
use yii\bootstrap4\ActiveForm;

$form = ActiveForm::begin([
    'layout' => 'horizontal',
    'fieldConfig' => [
        'template' => "{label}\n{beginWrapper}\n{input}\n{hint}\n{error}\n{endWrapper}",
        'horizontalCssClasses' => [
            'label' => 'col-sm-4 text-right',
            'offset' => 'col-sm-offset-4',
            'wrapper' => 'col-sm-7',
            'error' => '',
            'hint' => '',
        ],
    ],
]);
...
<?= $form->field($model, 'myAttribute')->textInput() ?> // works OK with BS3 & BS4
...
<?php ActiveForm::end() ?>

See documentation.
BS4 has changed some of DOM structures in standard elements. However, changing existing jquery selector could break sites build with BS3. It's sometime necessary to adjust option template for particular element and define own layout. In my experience this is only case with e.g. prepend/append input groups or complex lists (radiolist, checkboxlist). Otherwise Yii2 ActiveForm  works out of the box also with BS4.

I'm afraid that your example is quite different from what I'm trying to point out.
I've shown above a specific example of the issue.
To make it more clear, this works perfect with bootstrap 4:
use yii\bootstrap4\ActiveForm;
...
<?php
  $form = ActiveForm::begin(['id' => 'test-form',
    'options' => [
    'class' => 'form-horizontal'],
    'enableAjaxValidation' => true,
    'enableClientValidation' => false,
  ])
?>
<?= $form->field($model, 'demo')->textInput()->label("Demo") ?>
<?php ActiveForm::end() ?>

This does not work with Bootstrap 4:
use yii\bootstrap4\ActiveForm;
...
<?php
  $form = ActiveForm::begin(['id' => 'test-form',
    'options' => [
    'class' => 'form-horizontal'],
    'enableAjaxValidation' => true,
    'enableClientValidation' => false,
  ])
?>
<?= $form->field($model, 'demo', ['template' => "{error}"]); ?>
<?= $form->field($model, 'demo', ['errorOptions' => ['tag' => false]])->textInput()->label("Demo") ?>
<?php ActiveForm::end() ?>

As a use case, you may want to show the error somewhere far away from the input. For example at the top of the form.

I think to show the error(s) on top of the form, you should use ErrorSummary.

During ajax validation the ErrorSummary is not shown.
The function updateSummary (in yii.activeForm.js) is only called if the form is submitted.
In any case, this does not explain why the code above is not supposed to work. Since there is the possibility to separate the {error} from the input there should be also the possibility to display it.
I know many things are different but in Yii1 there is a very similar way to separate the error messages and it works right away.

Well, if you isolate the error (by changing template content) then you actually break expected DOM elements structure - so it won't work. Though valid, your use case is not standard implementation, unfortunatelly. I see 3 possible solutions:

either to modify JS handler for yii.activeForm
or dynamically (on page ready) rename original ID and inject DOM element wherever you need to (or if possible move whole field container while keeping DOM structure)
add you custom CSS to highlight error

Hello. I don't know if my issue is directly related with this, but I think it can be.
I'm submitting a form with ajax. When the form comes with validation errors, I got this:
form.yiiActiveForm("updateMessages", data.validation, true); in the javascript part.
The issue is, if I use yii\widgets\ActiveForm works ok, but If I use yii\bootstrap4\ActiveForm, the errors not showing up.
<?php $form = ActiveForm::begin([
           'id' => 'orden-items-create-form-id',
           'enableClientValidation' => true,
           'enableAjaxValidation' => true,
           ],
 ]); ?>

Also, I tried with 'enableClientValidation' => false ... the form is submitted but when it comes back with errors, these not showing up either.
Any ideas?
Thanks

No. I guess further debugging is needed in order to come up with the reason for it.

How I can help?

Check console. Are there any errors?
Inspect HTML. Are there error classes added? If so, are there styles for these?

Hello. After a debug session, I think "form.yiiActiveForm" is not the problem ... really, it nevers called, because "beforeSubmit" is not called eather.
I'm doing a Ajax validation and this is the context:
Form:
$form = ActiveForm::begin([             'id' => 'orden-items-create-form-id',             'enableClientValidation' => false,             'enableAjaxValidation' => true,             'validationUrl' => ['/orden-items/validate-create-from-orden', 'orden_id' => $orden_id],             'action' => ['/orden-items/create-from-orden', 'orden_id' => $orden_id],         ]);
The controller:
`public function actionValidateCreateFromOrden($orden_id)
{
$model = new OrdenItems(['scenario' => 'insert']);
$model->estado_c = 'A';
$model->orden_id = $orden_id;
    if (Yii::$app->request->isAjax && $model->load(Yii::$app->request->post())) {
        Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
        return \yii\bootstrap4\ActiveForm::validate($model);
        // return \yii\widgets\ActiveForm::validate($model);
    }
}`

(here I tested with boostrap4 and widgets validate, but the result its the same).
In the form when I use yii\widgets\ActiveForm works ok, but when I use yii\bootstrap4\ActiveForm, nothing happens (no error is shown).
Any ideas?
Thanks

It is in HTML in both cases, right? If so, that's CSS issue. There's basically no class for it.

I don't understand ... The css is the same ... why is working ok with yii\widgets\ActiveForm but not with yii\bootstrap4\ActiveForm?
Can you explain a little more?
Thanks


BOT_OWNER Perm rejects the bot owner

Maybe use ID comparison instead of User Object

Solved with ee9116
This commit has been tested and the bug is resolved.


Servers list does not stick when using opcode caching extensions

The configuration of phpmemcacheadmin is stored in *.php file. Thus, when you
use opcode cache (APC, ZendOptimizer+, etc.) with 'timestamp revalidation'
setting turned off, you will see that the configuration is not updated and the
phpmemcacheadmin does not work at all.

Possible solution: change extension of config file from *.php to, for instance,
*.json, or read the config directly from a file instead of including/requiring
it via PHP.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 25 Mar 2014 at 10:42

This is still an issue. Anyway, pointing out that there might be an issue with opcache would be helpful. Luckily I found that issue.


chore(package.json): bump esdoc version to latest (0.4.3)

Currently documentation generation appears to be broken because of esdoc/esdoc#73, which was fixed in the 0.2.6 release.
I have verified that it works correctly using 0.4.3.

Merged with e44b2d2. Thanks @Widdershin


Improves KeyBindings

Fixes

This PR was extracted from #3531 - I made a bunch of improvements to KeyBindings there and don't want to wait to get them merged.

Does not fix (for another PR)

#3120

Proposed Changes/Todos

[x] Break Application.cs up
[x] KeyBinding -> record struct
[x] Move KeyBindingScope.Application logic into Application
[x] More/better unit tests
[x] Add context to Command invocations so handlers can see what key was pressed and scope if needed.

[x] Add CommandContext with Command, Key, and KeyBinding and extend (optionally) the Command fn to take a context param.
[x] Add KeyBinding.Context  to hold arbitrary context.

[x] Update Menu and MenuBar to use KeyBinding.Context instead of overriding OnInvokingKeyBindings
[x] Add KeyBindings scenario
[x] Finish KeyBindings Scenario
[x] Git rid of OnInvokingKeyBindings overrloads in RadioGroup and StausBar now that we have context.

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

Changing back to Draft as I want to fix a few more things and also fix

#3120

Very well organized and well planned.

Thanks.
Did you look at what I did with the Find/Replace window in Editor?

Thanks.
Did you look at what I did with the Find/Replace window in Editor?

I really like the look of the border.
I just don't know why now the buttons don't have the same width as the larger size and with the text centered, as I initially designed. I liked the buttons better when they were all the same width instead of the current right alignment.

Thanks.
Did you look at what I did with the Find/Replace window in Editor?

I really like the look of the border. I just don't know why now the buttons don't have the same width as the larger size and with the text centered, as I initially designed. I liked the buttons better when they were all the same width instead of the current right alignment.

Better?

Got rid of the cancel button as we'll soon have the ability to have a close button in the title.
This uses Pos.Align to align the buttons.

Yes it looks better, but do you know why now we can't set a wider width for a button without using Dim.Auto?

Yes it looks better, but do you know why now we can't set a wider width for a button without using Dim.Auto?

I'm not sure what you mean.
Are you saying btn.Width = 30 gets ignored?

Yes.

Yes.

Yes.

Oh, do you mean you want the brackets to be pushed out to the sides?
Is that how it used to work?

Yes.

Oh, do you mean you want the brackets to be pushed out to the sides?
Is that how it used to work?

V1 worked as v2 does now:

That's exactly what I was referring to, sorry for not making me understand right away. It's not enough to just increase the width of the button, it's also necessary to push the brackets to both sides to get a more realistic view of its size, as just the color isn't enough.
Now in both v1 and v2 it may be working like this but I remember the brackets adjusting to the width of the buttons, in the past.

That's exactly what I was referring to, sorry for not making me understand right away. It's not enough to just increase the width of the button, it's also necessary to push the brackets to both sides to get a more realistic view of its size, as just the color isn't enough. Now in both v1 and v2 it may be working like this but I remember the brackets adjusting to the width of the buttons, in the past.

Anyway, this code (similar to what's in v2) is the crux:
/// <inheritdoc/>
protected override void UpdateTextFormatterText ()
{
	if (IsDefault)
		TextFormatter.Text = ustring.Make (_leftBracket) + ustring.Make (_leftDefault) + " " + Text + " " + ustring.Make (_rightDefault) + ustring.Make (_rightBracket);
	else
		TextFormatter.Text = ustring.Make (_leftBracket) + " " + Text + " " + ustring.Make (_rightBracket);
}

I can see why someone would want what you are describing. Seems pretty low priority though. A workaround is to just make Text bigger using spaces.

@tig I think Alignment.Fill does what it's expected more or less.


Fix #3164 Onedrive skips files; add FsRootCollapse test

What is the purpose of this change?
This PR fixes #3164, and also adds a unit test to prevent similar failures in the future.
Was the change discussed in an issue or in the forum before?
The changes have been discussed and explained in https://github.com/ncw/rclone/issues/3164.
Checklist

[x] I have read the contribution guidelines.
[x] I have added tests for all changes in this PR if appropriate.
[x] I have added documentation for the changes if appropriate.

[x] I'm done, this Pull Request is ready for review :-)

Thanks for that and apologies for the delay!
I'll merge that now - check the integration tests tomorrow morning...
https://pub.rclone.org/integration-tests/current/


Update containers.md

there is an obvious typo, however ot sure that is right, as such permissions dont exist at all accodring to:
Get-AzProviderOperation -OperationSearchString 'Microsoft.ContainerService/managedClusters/*' | ? { $_.Operation -match 'snapshot' } | ft

oh wait, it actually exists. but why is this operation name wrong than? shouldn't it be managedClusterSnapshots? why is managedcluster single and not plural? confusing stuff.

@rolyon
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@rolyon

The article has been substantially updated or deleted, and this change no longer applies. If you'd still like to update the article, please open a new PR. Or if you believe this PR was closed by mistake, email the PublicPRs alias.
#please-close
@MicrosoftDocs/public-repo-pr-review-team


Expecting this URL to be successfully parsed

Hi,
I have found that the URL validation of http://verveacu--fiserv.sandbox.lightning.force.com/auraCmpDef returns False. I understand that the URL format is validated so I have tested other URL having the same format like:
http://xn--fiserv.sandbox.lightning.force.com/auraCmpDef and the URL validator gives back True. So I have just made a little change again and tested this https://xm--fiserv.sandbox.lightning.force.com/auraCmpDef, which returns False again.
I have been using the validators for quite a long time, but I cannot find explanation for this behavior. I think that the validation of http://verveacu--fiserv.sandbox.lightning.force.com/auraCmpDef should return True.
BR: Zsolt

Fixed in #264.
Python 3.8.0 (default, Apr 24 2023, 15:11:36)
[GCC 12.2.1 20230201] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import validators
>>> validators.__version__
'0.21.1'
>>> validators.url("http://verveacu--fiserv.sandbox.lightning.force.com/auraCmpDef")
True

ref: https://github.com/python-validators/validators/issues/267 & https://github.com/python-validators/validators/issues/268

Thank you very much @joe733


Converting old API to new API for WorkItem Operations [13]

Description
As a developer, I want to use the new jsonapi based API for implementing features for WorkItems.
Functional Acceptance Criteria

WorkItem operations between UI and Core on WorkItems are using the new jsonapi based API.

Non-Functional Acceptance Criteria
None.

Do we have JSON API available for all the endpoints?

Not yet, but we will.

Completed in Sprint#124.


Suggest translation

Variables should not be translated when you press Suggest.

Does that mean it already works even if it is translated? Or does it still need to be implemented?


Force Tracing : get a trace ID we can search for when this is forced.

Is your proposal related to a problem?
As we got the Force Tracing feature enabled we should also have a feature such that we can get the traceID when we search for when  this is forced
Describe the solution you'd like

we can use the TraceId header and upgrade the force Tracing checkbox such that if it is enabled then on hovering on it we can get the traceID else a message that enable checkbox to get the TraceID

Hello @yeya24 can I get some suggestions on this issue?

	// traceIdResponseHeader is a response header name that stores trace ID.
	traceIDResponseHeader = "X-Thanos-Trace-Id"

We set X-Thanos-Trace-Id header in the query response. You can get the header value and display it in the UI.

	// traceIdResponseHeader is a response header name that stores trace ID.
	traceIDResponseHeader = "X-Thanos-Trace-Id"

We set X-Thanos-Trace-Id header in the query response. You can get the header value and display it in the UI.

want do you think how should it be displayed in the UI should i do it in the way i provided the solution or you have any other suggestions ?

@Vanshikav123 I don't have much to share. You can think about it and open a pr for feedback


Donate Page

Issue Type:

[ ] Bug Report
[x]  Feature Request
[ ] Documentaion

Describe the bug

Create a donate page

Possible solution

I would like to create a donate page for the foundation if you provide me the relevant details.

Screenshots

@himanshu007-creator can I work on this?

@nidhivanjare go ahead with the work and send a PR. I will add a label to this issue

I have some questions.
For the donation page, I have to add a payment method, and for that, I would have to add PHP on the side.
Is that okay?
And are there any other requirements for the page?

I have some questions.
For the donation page, I have to add a payment method, and for that, I would have to add PHP on the side.
Is that okay?
And are there any other requirements for the page?
@divyashukla23

@himanshu007-creator  Please have a look here! We need to talk with Backend person for this because he is handling the whole backend so this will be helpful

@nidhivanjare Design the front end of the donate page and send PR , do not integrate the payment gateway that will be handles by the person working on backend.

@nidhivanjare  we won't be using PHP in backend, we will be using django only. It will be for updating/adding/subtracting new blogs and articles.
My suggestion to you will be making a separate page having good pictures + persive text . We would really appreciate your contributions and looking forward to it real soon.
Best of luck🎉

okay understood !!
Thank You !!

okay understood !!
Thank You !!

If need help in frontend please let me know will be happy to help !

I have created the PR. Let me know if there are any changes.
@rohank2502. @himanshu007-creator


Add r.session.data.pageSize

What problem did you solve?
Closes #1067
(If you do not have screenshot) How can I check this pull request?
Adjust r.session.data.pageSize to 100, 500 and 0 and View(data.frame(id = 1:1000)) and see if the setting applies properly.

Just a question: what good does it do to reduce the page size? (display performance?)
My understanding is that all data is read regardless of page size, so the initial value for page size seems like it should be larger.

I think it only affects the rendering performance, as larger page size means more objects in the web page. Also, if the page size is too large, the scrolling will be harder to locate certain rows.
Here, the default value 100 comes from ag-grid. Maybe we could use 500.


Viewability-Insights didn´t measure 100% despite the ad is full in viewport

We are using a creative template for the understitial-ad, but we can´t reach 100% viewability, it is almost about +/- 75% when we scroll over the ad. But if the ad is 100% in viewport and we refresh the page then we get about 95 - 100% viewability. Usually the user isn`t refreshing the page so this is a problem for us and our viewability benchmarks.
With the url-parameter we call our test lineitem.

Go to: https://www.harpersbazaar.de/fashion/dieses-vintage-kleid-ist-zurueck-lieben?atf_url_targeting&atf=understitial_test
Click on '....'
Scroll down to ad-slot 'content_1'
See error

Expected behavior
We are awaiting 100% viewability as shown on the screen.
Screenshots
Scrolling over the ad:

Reload the page when the ad is 100% in viewport:

Desktop (please complete the following information):

OS: [Windows 11]
Browser [Chrome]
Version [Version 126.0.6478.115 (Offizieller Build) (64-Bit)]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Don´t worry about the size displayed in the ad (640x920). This is for double density/high resolution displays.
It doesn`t matter if we measure it on desktop or mobile.

Thank you for your feedback and report.
In this case, the extension is functioning as intended, correctly displaying a visibility of 95%. The issue lies with the visual representation (green rectangle) of the visible area, which is not accurate for this highly dynamic construct.
If you inspect the "GoogleActiveViewInnerContainer" within the Iframe using Developer Tools, you’ll see that it is larger or shifted compared to the Iframe container, as illustrated below:

Due to this discrepancy, the viewability will almost never reach 100% because the Viewability Container is shifted or larger than the Iframe container.
Please understand that I cannot provide individual support for custom solutions and related issues.
However, I will investigate potential improvements for the visual representation (green rectangle) for such dynamic constructs.
It would be very helpful if you could keep this test page live for the next two weeks. Thanks.

Hi Markus,
many thanks for the quick reply. Yes, you can use the url for the next weeks. The test-lineitem is unlimited in time. We use it regularly.
I will send your answer to our developer so he can also think about what he can do maybe.
Best
Christian

Hi Markus,
sorry for not replying to your comment from the 3rd of September. I have been on vacation and your message must have been lost in the mass. Thank you very much for your work! We will have an eye on it if we see an improvement on our KPIs.
Were the already installed browser add-ons updated automatically?
Best
Christian

Hi Christian,
the latest version, 1.0.0, is currently under review in the Chrome Store. Once approved, it will automatically be available to all users.
You can also force the update by clicking the "Update" button in the Extensions screen as soon as it’s approved. The review process typically takes 1–2 days.
This version introduces a new "orange" indicator for cases where the view is around 100% but lacks a viewability ping, making it easier to identify partial viewability issues.

Hi Markus,
sounds really great. I´m looking forward for the updated version.
Thank you for your effort!
Best
Christian


[Hotfix] Add back favicon for preprint discover page

Ticket: []
Feature flag: n/a

Purpose

Bring back favicon for branded preprint discover page

Summary of Changes

Add back afterModel hook to preprint discover page that sets favicon

Screenshot(s)
Side Effects

QA Notes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 69.25%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/preprints/discover/route.ts
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
6065

Relevant Lines:
8506

💛  - Coveralls

Cherry-picked onto hofix branch. Closed.


Mishmash of logging/printing

Hello,
aiorun currently makes use of python's logging module, yet one call to print remains, would it be possible to have it removed or logged in the next version?
https://github.com/cjrh/aiorun/blob/master/aiorun.py#L200
Thanks very much.

Oops yeah that's an error on my part. Will fix it up tomorrow morning. Thanks for taking the time to report it!


Scientific Calculator

Calculator Functions
This scientific calculator performs functions beyond addition, subtraction, multiplication and division. AA scientific calculator usually has special buttons for parentheses, trigonometric functions, exponents, inverses and pi -- among other things. All the mathematical operation you can run on this online calculator.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

I can see there is already one scientific calculator in the repo !
If you can implement extra features in your calculator than only work on this issue !
Thank you !

@anu-oss
Only work on one issue at a time !!!!!!!!!!!!
And each calculator must be unique !!

@vasu-1 what is the deadline for each issue?

ig, till contribution period ends !
Instructions will be provided soon !!
Work on the issue after tomorrow !!

great. also, given that scientific calculator has been taken up, can I close this issue and open a different one?

yes !!

thanks.


Select server topology ancestors from the same CDN as the base server

What does this PR (Pull Request) do?

[x] This PR fixes #5505 by making parentRevalPending be CDN-specific

Which Traffic Control components are affected by this PR?

Traffic Ops

What is the best way to verify this PR?

Start CDN in a Box
Create an invalidation request for the demo1 Delivery Service
Notice that https://trafficportal.infra.ciab.test/api/4.0/servers/mid-01/update_status says parent_pending = true
Set the CDN ID of mid-01 in the database:<<'SQL' docker-compose exec -T trafficops bash -c 'PGUSER=$DB_USER PGPASSWORD=$DB_USER_PASS PGHOST=$DB_SERVER PGDATABASE=$DB_NAME psql'
UPDATE "server" set cdn_id = 1 WHERE host_name = 'mid-02'
SQL

Notice that https://trafficportal.infra.ciab.test/api/4.0/servers/mid-01/update_status says parent_pending = false

If this is a bug fix, what versions of Traffic Control are affected?

master (1cd5046467)
5.0.0
5.0.x branch

The following criteria are ALL met by this PR

[ ] This PR includes tests OR I have explained why tests are unnecessary
[x] Bugfix, no documentation is necessary
[x] This PR includes an update to CHANGELOG.md
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

I still can't reproduce this. At step 3 of the verification, I see "parent_pending": false.

I still can't reproduce this. At step 3 of the verification, I see "parent_pending": false.

You could just set update_pending to true for mid-02 in the servers table

That did it. Probably explains why I couldn't reproduce the issue in the first place; I didn't know you needed to queue updates after creating the invalidation job.


Setup terminates immediately

OS
Windows Server 2016 Datacenter
VERSION
1.5.0
ISSUE DESCRIPTION
When starting the setup the following message box appears:

In the Windows Event Log the following is logged:

Faulting application name: Another-Redis-Desktop-Manager.1.5.0.exe, version: <IP_ADDRESS>, time stamp: 0x5c157f86
Faulting module name: System.dll, version: <IP_ADDRESS>, time stamp: 0x5c157efa
Exception code: 0xc0000005
Fault offset: 0x00001581
Faulting process id: 0x2fe4
Faulting application start time: 0x01d7f425e2f4c3bd
Faulting application path: C:\Users\Administrator\Downloads\Another-Redis-Desktop-Manager.1.5.0.exe
Faulting module path: C:\Users\ADMINI~1\AppData\Local\Temp\2\nsqD907.tmp\System.dll
Report Id: 3399de29-0bc3-497f-8a81-98aefbb00e81
Faulting package full name:
Faulting package-relative application ID:

I've looked at #364 and ensured that .NET 4.8 is installed.
running this:
reg query "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\full" /v version

resulted in:

version    REG_SZ    4.8.03761

So I'm pretty sure, .NET is not an issue here.

After installing the .NET Framework 4.8 German language pack and rebooting my server, the setup ran successfully.

usually after you installing the latest .NET Framework, your applications will run normally.
as to the Language packs, I am not pretty sure if it is necessary but I think it's optional, the key you can run successfully is your "restart of your computer"
you can download latest .NET Framework from Microsoft:


[FEATURE REQUEST] Ability to block domains from using extension

I use Clockify to keep track of my timesheets.
The interface has many text fields for logging tasks, which save automatically upon input with no undo feature.
If I accidentality hit the FakeFiller button when I'm on the Clockify page it wipes all of my data.  It fills all of the inputs on the page with dummy data, which is then saved automatically, overwriting all of my records.  This can be quite an issue as I can lose all of my timekeeping records for the month.
I appreciate that the extension is working as intended, and it is my mistake for hitting the button.  It would be very useful to have a config setting where I can input a list of 'blacklisted' domains.  This would mean that I could block app.clockify.me, and clicking the button on that domain would have no effect, or maybe put up a confirmation popup, preventing the loss of data.
Thank you!  It is a very useful extension.

Available in the latest version of the extension.

Nice one, thank you Hussain!


emqttd_broker stats cannot work

[root@i-m7nrq9fa emqttd-0.6.0]# ./bin/emqttd_ctl stats
subscribers/max: 0
topics/count: 31
clients/count: 0
sessions/count: 0
sessions/max: 0
clients/max: 0
subscribers/count: 0

fixed.


Question: UnicodeDecodeError

Hey,
I'm trying to install on an m1 mac but I'm getting a lot of errors. Initially, I followed the tutorial, but there was an error in the JAX library. I solved it by updating the library using Anaconda.
Now I'm having this coding error that I can't find the source. Has anyone ever experienced this?
diego@hipogrifo colabfold-conda % bin/colabfold_batch teste output
2023-12-10 22:19:58,632 Running colabfold 1.5.3 (ca6b297021bb876157b75d84d591ed350cbece85)
Traceback (most recent call last):
File "/Volumes/Hermes/alphafold/localcolabfold/colabfold-conda/bin/colabfold_batch", line 8, in
sys.exit(main())
File "/Volumes/Hermes/alphafold/localcolabfold/colabfold-conda/lib/python3.10/site-packages/colabfold/batch.py", line 1998, in main
queries, is_complex = get_queries(args.input, args.sort_queries_by)
File "/Volumes/Hermes/alphafold/localcolabfold/colabfold-conda/lib/python3.10/site-packages/colabfold/batch.py", line 623, in get_queries
(seqs, header) = parse_fasta(file.read_text())
File "/Volumes/Hermes/alphafold/localcolabfold/colabfold-conda/lib/python3.10/pathlib.py", line 1135, in read_text
return f.read()
File "/Volumes/Hermes/alphafold/localcolabfold/colabfold-conda/lib/python3.10/codecs.py", line 322, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb0 in position 37: invalid start byte

For some reason, it does not work when a pass a directory as input, but works when I pass a fasta file directly.


New Flake8 exception?

Hello!
I've attempted to install on my ubuntu box. I've had two issues doing so:

My global python was 2.7, but the pip was still pointing to 3.5, so I had to switch the command in the makefile from pip install -r requirements.txt to python -m pip install -r requirements.txt

On fixing this, I had another issue during the Flake8 run -
app/api/user.py:57:5: E722 do not use bare except'
app/api/user.py:98:5: E722 do not use bare except'
app/api/user.py:115:5: E722 do not use bare except'
app/api/user.py:131:5: E722 do not use bare except'
app/api/user.py:147:5: E722 do not use bare except'
app/api/user.py:163:5: E722 do not use bare except'
app/util/cryptography.py:40:5: E722 do not use bare except'
app/util/cryptography.py:68:5: E722 do not use bare except'
app/util/cryptography.py:76:5: E722 do not use bare except'
app/views/paste.py:105:5: E722 do not use bare except'
app/api/paste.py:90:5: E722 do not use bare except'
app/api/paste.py:123:5: E722 do not use bare except'
app/api/paste.py:152:5: E722 do not use bare except'
app/api/paste.py:190:5: E722 do not use bare except'
app/api/paste.py:209:5: E722 do not use bare except'
app/api/paste.py:228:5: E722 do not use bare except'
app/api/paste.py:247:5: E722 do not use bare except'

I've added E722 as an exception to the setup.cfg, but I'm not sure why this occurred. Is it only me, or anyone else facing the same issue?

Same issue here

They are just lint/style warnings; it will not affect program behavior and you can safely ignore them.

Yes, I've added those to the exceptions and got it working. I was wondering if they were supposed to be working before, and recently started breaking the build process.
Thanks for the great work though!

I didn't pin a version of flake8 in the dependencies declaration so it's most likely the case that there was a breaking change released some time in the last couple of years that caused new errors to arise. I haven't put any effort toward fixing them since I'm focusing work on Modern Paste v2  (not yet open source).

Here is a quick summary of what it took me to get running on a fresh Debian VM
http://confluence.polymicro.net/confluence/display/POLY/2018/04/06/Modern+Paste

On Apr 6, 2018, at 2:36 PM, Kevin Lin<EMAIL_ADDRESS>wrote:
I didn't pin a version of flake8 in the dependencies declaration so it's most likely the case that there was a breaking change released some time in the last couple of years that caused new errors to arise. I haven't put any effort toward fixing them since I'm focusing work on Modern Paste v2 (not yet open source).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/LINKIWI/modern-paste/issues/58#issuecomment-379419018, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEIjI7oYMmkU_hs2ASK2S90JaJsFREyks5tmAn0gaJpZM4Q_8GW.


Provide apk in releases.

Please provide apk file in releases as some people don't use google play (degoogled phones or alternative ROMs).

we introduced it in https://github.com/KomodoPlatform/komodo-wallet-mobile/releases/tag/v0.6.3-beta.2 and will continue to provide them with upcoming releases


First draft on lab requirements from<EMAIL_ADDRESS>

Signed-off-by: Boris Glimcher<EMAIL_ADDRESS>

please review @kkongusa

Raritan refers to remote access KVM.  It's got hdmi/vga + keyboard usb + mouse usb connections just like a traditional KVM but you can access everything remotely through a web interface.  Regarding console server, I have in mind a serial console server.  So instead of kvm, you have a serial connection.  Kernel guys generally want this so they can log what comes out of server UARTs.
Yeah, I would say UPS can be a requirement.  Please add it.  Then go into specifics on how long the UPS should provide backup service and for what type of equipment.
@pdp2shirts Regarding switching cabling between racks, can you elaborate?  I believe I added a requirement for a lab tech to be on call 24/7 to physically move cables around.  Alternatively, if budgets allow, folks can opt for layer 1 switches.  Basically devices with remotely controllable micro-mirrors to literally reroute optical paths without needing a lab tech to move cables physically.

@pdp2shirts  Oh, I misunderstood what you said.  The specification of how connections are done is dependent on the topology.  This is a question for the use case group.  Once this is known, the documentation for it can be done using an app like opendcim.org.


add subscriber handler and status displays

Remove mpu9250?
On Oct 23, 2017 07:41, "Beat Küng"<EMAIL_ADDRESS>wrote:

@bkueng commented on this pull request.
To provide some context: the goal is to move tunes & led handling from
commander to events, this PR provides the necessary structure, and
simplifies customizations for downstream users.
fyi @dagar https://github.com/dagar
fmu-v2 is out of flash again. Is there some driver(s) we can remove?
frsky_telemetry?
In src/modules/events/status_display.h
https://github.com/PX4/Firmware/pull/8172#discussion_r146237707:

*/

+#pragma once
+
+#include "subscriber_handler.h"
+
+#include <drivers/drv_hrt.h>
+
+#include <uORB/uORB.h>
+#include <uORB/topics/battery_status.h>
+#include <uORB/topics/cpuload.h>
+#include <uORB/topics/led_control.h>
+#include <uORB/topics/vehicle_status.h>
+#include <uORB/topics/vehicle_status_flags.h>
+
+#define CPU_OVERLOAD_VALUE 0.80f
These defines are unused, can you remove them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/PX4/Firmware/pull/8172#pullrequestreview-71149196,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFK6KlB5kJfGzAl6dfsVEExhvUAEvQuks5svHt6gaJpZM4QCeYg
.

The semaphoreci failure is real (out of flash on px4fmu-v2), the circleci failure is intermittent and incredibly annoying. Let me know if you have any ideas for why it sporadically gets stuck in a reconfigure loop.

Ok I disabled mpu9250.
@dagar there's some build dependency missing for incremental builds: disabling the driver and building the target gave me:
NuttX/apps/libapps.a(builtin_list.o):(.rodata.g_builtins+0x20c): undefined reference to `mpu9250_main'

A clean build fixed it. The other direction is even more problematic: enabling something gets silently ignored.

Yes I was aware of the nuttx builtins dependency issue, and working on a fix in this large PR. https://github.com/PX4/Firmware/pull/8043
I should get a minimal fix for that particular issue into v1.7.0.

Looks good, one idea I've had for other areas is to update Subscription (https://github.com/PX4/Firmware/blob/master/src/modules/uORB/Subscription.hpp#L131) for use in the work queues. Either lazy subscribe or change the structure to allocate the entire class in the first cycle.
Another idea that could be useful in a few places is a variation that returned a copy of the latest data, but didn't hold an internal copy.
Feel free to ignore for this PR, just something to think about for later.

change the structure to allocate the entire class in the first cycle.

This is already the case for the events module. In general, the new ModuleBase accounts for that and handles it better.

Another idea that could be useful in a few places is a variation that returned a copy of the latest data, but didn't hold an internal copy.

Isn't SubscriptionBase pretty much that? I like the interface of Subscription, but it has IMO too much overhead: it inherits from a linked list, stores the metadata & instance (https://github.com/PX4/Firmware/blob/master/src/modules/uORB/Subscription.hpp#L87), and in addition a copy of the data.

This is already the case for the events module. In general, the new ModuleBase accounts for that and handles it better.
Great! I was thinking of what the land_detector does and not completely aware of how ModuleBase is implemented.

It would be great to direct more effort into improving core building blocks like Subscription, Publication, BlockParam, etc rather than having the many different flavours of boilerplate that keep evolving.

What's the overall plan here? As commander will still need to subscribe and act on most (all?) of these topics would it make sense to publish something like an overall commander status or higher level LED commands (battery low, battery critical, etc)?

As commander will still need to subscribe and act on most (all?) of these topics would it make sense to publish something like an overall commander status or higher level LED commands (battery low, battery critical, etc)?

Yes that makes sense. We just need to be careful to avoid exposing commander internals.

@bkueng Good to go from my side

CI failure is unrelated

Yes that makes sense. We just need to be careful to avoid exposing commander internals.

That's really the point I was trying to make. For example vehicle_status_flags are basically commander internals, but published for logging.
I also want to be careful with things like the battery thresholds. It's a trivial example, but in my opinion it would be better to have only a single module interpreting them and deciding if the battery is low. What if the battery percentage dips below the threshold, then goes above again? We can now have multiple power bricks with a battery status coming from each. How the low battery params are interpreted in that situation hasn't really been discussed in detail.


Various updates

Hello. I started using stew recently and wanted to update some things.
switched from AlecAivazis/survey to charmbracelet/huh
updated urfave/cli to v3 and added completion scripts
removed vendors directory and updated dependencies
removed deprecated things(ioutils)
uses archiver.fromextension instead of a hardcoded list of extensions to check if a file is an archive
I can split this up into a few PRs if it would be easier to manage. Let me know if there is anything in this PR you don't want merged and I can remove it as well.
I'd like to add custom repo support in the near future as well, mostly gitea and gitlab instances.
Thank you!

Hey thank you so much for all of this! Yes, I would want all of these split into separate PRs before I can review.

switched from AlecAivazis/survey to charmbracelet/huh

This is awesome! Could you include before and after screenshots in your PR for this.

updated urfave/cli to v3 and added completion scripts

Not super familiar with completions, so when you open this PR could you describe what you did with some more detail and can you include some usage examples?

removed vendors directory and updated dependencies

Dependencies should be updated, but what's your reason for removing the vendor directory?

uses archiver.fromextension instead of a hardcoded list of extensions to check if a file is an archive

This is already covered by #28, so don't worry about opening another PR for this

I'd like to add custom repo support in the near future as well, mostly gitea and gitlab instances.

Whenever you're ready, you should open an issue for this. I'd be interested to read your proposal.

I will split it up into a few PRs tonight.

Dependencies should be updated, but what's your reason for removing the vendor directory?

with modules existing im not sure the purpose of maintaining a vendors directory for a project like this. i can not delete them if you are against removing them.

Not super familiar with completions, so when you open this PR could you describe what you did with some more detail and can you include some usage examples?

will do. its just the tab completions scripts from https://github.com/urfave/cli/tree/main/autocomplete with minor modifications


bluealsa-aplay An underrun has occurred

Hello, I was following the guide here: https://volumio.org/forum/volumio-bluez-alsa-a2dp-bluetooth-support-t6130.html and I got this error in the output of bluealsa-aplay:
$ sudo systemctl status bluealsa-aplay@94\:65\:2D\:7A\:28\:55.service -n 100
● bluealsa-aplay@94:65:2D:7A:28:55.service - BlueAlsa-Aplay 94:65:2D:7A:28:55 -dhw:1,0
   Loaded: loaded<EMAIL_ADDRESS>enabled; vendor preset: enabled)
   Active: active (running) since Thu 2018-03-29 12:49:28 EEST; 3min 24s ago
 Main PID: 15223 (bluealsa-aplay)
    Tasks: 4 (limit: 4915)
   CGroup: /system.slice/system-bluealsa\x2daplay.slice/bluealsa-aplay@94:65:2D:7A:28:55.service
           └─15223 /usr/bin/bluealsa-aplay 94:65:2D:7A:28:55 -dhw:1,0

systemd[1]: Started BlueAlsa-Aplay 94:65:2D:7A:28:55 -dhw:1,0.
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/../src/shared/ctl-client.c:102: Connecting to socket: /var/run/bluealsa/hci0
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/../src/shared/ctl-client.c:126: Subscribing for events: 101
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:575: Starting main loop
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:597: Fetching available transports
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:661: Creating PCM worker 94:65:2D:7A:28:55
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/../src/shared/ctl-client.c:102: Connecting to socket: /var/run/bluealsa/hci0
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/../src/shared/ctl-client.c:341: Requesting PCM open for 94:65:2D:7A:28:55
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:328: Starting PCM loop
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:344: Device marked as inactive: 94:65:2D:7A:28:55
bluealsa-aplay[15223]: /usr/bin/bluealsa-aplay: ../../utils/aplay.c:391: An underrun has occurred

Output from bluealsa.service
$ sudo systemctl restart bluealsa.service
$ sudo systemctl status bluealsa.service
● bluealsa.service - BluezAlsa proxy
   Loaded: loaded (/lib/systemd/system/bluealsa.service; enabled; vendor preset: enabled)
   Active: active (running) since Thu 2018-03-29 12:47:45 EEST; 1s ago
 Main PID: 15136 (bluealsa)
    Tasks: 4 (limit: 4915)
   Memory: 1.1M
      CPU: 8ms
   CGroup: /system.slice/bluealsa.service
           └─15136 /usr/bin/bluealsa

systemd[1]: Started BluezAlsa proxy.
../../src/ctl.c:504: Starting controller loop
../../src/bluez.c:680: Registering endpoint: /A2DP/MPEG24/Source/1
../../src/bluez.c:680: Registering endpoint: /A2DP/MPEG24/Sink/1
../../src/bluez.c:680: Registering endpoint: /A2DP/SBC/Source/1
../../src/bluez.c:680: Registering endpoint: /A2DP/SBC/Sink/1
../../src/bluez.c:910: Registering profile: /HSP/Headset
../../src/bluez.c:910: Registering profile: /HSP/AudioGateway
../../src/bluez.c:910: Registering profile: /HFP/HandsFree
../../src/bluez.c:910: Registering profile: /HFP/AudioGateway
../../src/main.c:249: Starting main dispatching loop
../../src/bluez.c:857: Profile method call: org.bluez.Profile1.NewConnection()
../../src/transport.c:675: State transition: 0 -> 2
../../src/transport.c:104: Created new IO thread: HFP Hands-Free
../../src/bluez.c:797: HFP Hands-Free configured for device 94:65:2D:7A:28:55
../../src/transport.c:675: State transition: 0 -> 2
../../src/ctl.c:586: +-+-
../../src/io.c:1151: Starting IO loop: HFP Hands-Free
../../src/transport.c:104: Created new IO thread: HFP Hands-Free
../../src/rfcomm.c:568: Starting RFCOMM loop: HFP Hands-Free
../../src/rfcomm.c:96: Sending AT message: SET: command:+BRSF, value:244
../../src/at.c:156: AT message: RESP: command:+BRSF, value: 2919
../../src/rfcomm.c:114: HFP state transition: 0 -> 1
../../src/at.c:156: AT message: RESP: command:, value:OK
../../src/rfcomm.c:114: HFP state transition: 1 -> 2
../../src/rfcomm.c:96: Sending AT message: SET: command:+BAC, value:1
../../src/at.c:156: AT message: RESP: command:, value:OK
../../src/rfcomm.c:114: HFP state transition: 2 -> 3
../../src/rfcomm.c:96: Sending AT message: TEST: command:+CIND, value:(null)
../../src/at.c:156: AT message: RESP: command:+CIND, value: ("call",(0,1)),("callsetup",(0-3)),("service",(0-1)),("signal",(0-5)),("roam",(0,1)),("battchg",
../../src/rfcomm.c:114: HFP state transition: 3 -> 4
../../src/at.c:156: AT message: RESP: command:, value:OK
../../src/rfcomm.c:114: HFP state transition: 4 -> 5
../../src/rfcomm.c:96: Sending AT message: GET: command:+CIND, value:(null)
../../src/at.c:156: AT message: RESP: command:+CIND, value: 0,0,1,3,0,1,0
../../src/rfcomm.c:114: HFP state transition: 5 -> 6
../../src/ctl.c:586: +-+-
../../src/at.c:156: AT message: RESP: command:, value:OK
../../src/rfcomm.c:114: HFP state transition: 6 -> 7
../../src/rfcomm.c:96: Sending AT message: SET: command:+CMER, value:3,0,0,1,0
../../src/at.c:156: AT message: RESP: command:, value:OK
../../src/rfcomm.c:114: HFP state transition: 7 -> 8
../../src/rfcomm.c:114: HFP state transition: 8 -> 9
../../src/bluez.c:609: Endpoint method call: org.bluez.MediaEndpoint1.SetConfiguration()
../../src/bluez.c:541: A2DP Sink (AAC) configured for device 94:65:2D:7A:28:55
../../src/bluez.c:543: Configuration: channels: 2, sampling: 44100
../../src/transport.c:675: State transition: 0 -> 0
../../src/ctl.c:586: +-+-
../../src/bluez.c:663: Endpoint already registered: /A2DP/MPEG24/Source/1
../../src/bluez.c:680: Registering endpoint: /A2DP/MPEG24/Sink/2
../../src/bluez.c:663: Endpoint already registered: /A2DP/SBC/Source/1
../../src/bluez.c:663: Endpoint already registered: /A2DP/SBC/Sink/1
../../src/ctl.c:565: New client accepted: 14
../../src/ctl.c:586: +-+-
../../src/ctl.c:565: New client accepted: 15
../../src/ctl.c:586: +-+-
../../src/ctl.c:318: PCM requested for 94:65:2D:7A:28:55 type 1 stream 1
../../src/ctl.c:586: +-+-
../../src/bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
../../src/bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
../../src/transport.c:675: State transition: 0 -> 1
../../src/transport.c:821: New transport: 16 (MTU: R:672 W:1008)
../../src/bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
../../src/transport.c:675: State transition: 1 -> 2
../../src/transport.c:104: Created new IO thread: A2DP Sink (AAC)
../../src/io.c:565: Starting IO loop: A2DP Sink (AAC)
../../src/bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
../../src/transport.c:675: State transition: 2 -> 0
../../src/transport.c:847: Releasing transport: A2DP Sink (AAC)
../../src/transport.c:875: Closing BT: 16
../../src/transport.c:999: Exiting IO thread

[Unit]
Description=BlueAlsa-Aplay %I -dhw:1,0
Requires=bluetooth.service bluealsa.service
[Service]
Type=simple
User=root
Group=audio
Environment=LIBASOUND_THREAD_SAFE=0
ExecStart=/usr/bin/bluealsa-aplay %I -dhw:1,0
[Install]
WantedBy=multi-user.target

My hunch is that the issue is related to permissions / ownership of files or the owner of the alsa process.
The issue is that there's no audio piping through.

I've compiled this package from source with AAC enabled. I plan to recompile with aptX.
Some env data:
$ uname --kernel-release
4.13.0-37-generic

$ lsb_release -id
Distributor ID:	Ubuntu
Description:	Ubuntu 17.10

It looks like termination requested by connected device (the bluez.c:1028:  Signal: line):
../../src/io.c:565: Starting IO loop: A2DP Sink (AAC)
../../src/bluez.c:1028: Signal: PropertiesChanged: org.bluez.MediaTransport1
../../src/transport.c:675: State transition: 2 -> 0

You can debug it further using dbus-monitor. Just connect your device and before starting playback run dbus-monitor --system as root (running it earlier will gather too much unrelated messages).

Found the problem, forgot to RTFM properly and end to end. Everything works fine. You can close this.

OK, great that it's working fine for you. Closing, then.


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2024-03-17)
Code Refactoring

improvement to multiparadigm + correction eslint (5ef2ff9)

Build System

: Update dependencies and build configuration (6bb4cd3)

Tests

test correction (497da0f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-auth/releases/tag/v1.1.1 :sunflower:


remake: 4.3+dbg-1.5 -> 4.3+dbg-1.6

Among other things this upstream fixes build on fno-common toolchains.

@trofi - good to hear. But just so folks know in the future... this kind of information is useful to know in the future when it has impact.
Making a release can be time intensive. As I get older and accumulate so have so many other projects, I may delay releases until there is good reason.
I realize "downstream" folks may be modest (although some aren't), knowing the impact of a release helps me decide whether I want to go through the effort of a release.


How to resolve sing in pop up issue

Question
I am getting follow screen while UI test is running for MDA.  Here is the piece of code I use to sign in into dataverse environment and then launch MDA. Initial sing in session work fine but while test case is clicking through MDA suddenly another sign in pop up comes.
Here it is https://ibb.co/dBw7pbn
It looks like initial session is not maintained. Can you confirm is if I need to update any driver or use different method to sign in.
       ```
         var client = DataverseTestUtilities.GetWebClient();
        using (var xrmApp = new XrmApp(client))
        {
            DataverseTestUtilities.LoginToDynamicsPowerAppsAsAdmin(xrmApp);

            DataverseTestUtilities.WaitForXSeconds(xrmApp, 10000);

            xrmApp.Navigation.OpenApp("Remote Assist"); // Open MDA App
            DataverseTestUtilities.WaitForXSeconds(xrmApp, 10000);

            xrmApp.Navigation.OpenSubArea("Content", "One-time Call"); // navigation in MDA

           // at this point, above sing in pop up shows up. https://ibb.co/dBw7pbn

Here is the pop up https://ibb.co/dBw7pbn

@rohitjadhavmsft Did you try https://github.com/microsoft/EasyRepro/issues/1320#issuecomment-1248775349 ?

Yes, that is helping but I have to manually enable the third-party cookie on the chrome instance created by Ui test. I am looking for ways to set it programmatically. I came across var CookieСontrolsMode

rohitjadhavmsft Did I correctly understand the set CookieСontrolsMode = 0 is not enableв third-party cookie?
This is mean that google changes this option in the latest version and needs to investigate what new option should be changed, then update the EasyRepro code or use your options to create a chrome driver instance.
Steps described here https://stackoverflow.com/a/65007362/8951897


Add IBC support to multi-test

We now have support for Custom Msg and Queries, and an easy way to plug in Staking and Distribution support. (#266)
One missing feature is being able to simulate IBC calls between 2 apps. This will require significant changes to the App structure and some coordinator that controls 2 apps. Rather than hide this as a checkbox, it makes sense to pull it into a full-blown issue to discuss.

I am closing this issue, as IBC support will be implemented as in #184.


Notebooks / SQL2019 creating too many output channels, and creating before needed

Issue Type: Bug
Open a Notebook in Azure Data Studio, go to Output and look at all the output channels:

We have

dataManagement (this shouldn't be needed, it's the old name so should be removed)
Jupyter Notebooks (again, old name, we should just use "Notebooks"?)
Somehow, a 2nd dataManagement
SQL Server 2019 Preview (even though I didn't do a Data Virtualization scenario)
scaleoutdataservice (at this point the wrong name as it's probably "DataVirtualizationService")
MSSQL

The 2 things are:

Reduce the number of these dramatically. We can remove at least 2, possibly 3 of these
Stop creating these until we need them. Until we need to send 1st message why are these available? I can understand the channels to tools service but others really can wait until later.

Azure Data Studio version: Azure Data Studio 1.5.1-insider (31614247cf341abc9194080d0ab7eb720257fb06, 2019-03-13T21:13:30.723Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 3

Memory (System)
16.00GB (0.21GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

vscode-sanddance
dan
0.1.3

newdatabase
kev
0.0.3

agent
Mic
0.36.1

dacpac
Mic
0.1.0

server-report
Mic
0.1.5

sql-vnext
Mic
0.10.3

This is how it looks finally: