Workflows to produce binaries

As discussed in this issue #7 there was a need for binaries to more easily install SimpleCRF on different platforms.
This was especially relevant for Windows which required VS and Visual C++ build tools to be able to install SimpleCRF as it needs to be built from scratch when installing.
I mostly focused on adding and improving the workflows, but I found it relevant to make some minor adjustments as well.
Lots of time (and commits) was spent in trying to get the demos to run on the cloud. However, the demos include plt.show() and when these are run on a headless machine it resulted in hangs (or so it seemed). Therefore, these unit tests I added were removed for now, to be added in the future I suppose (if of interest).
Changes:

Added workflows for Windows, Ubuntu Linux, and macOS for the Python versions 3.6-3.10
Updated the demos to use arguments instead of input(), which does not require user input (args necessary to run demos on the cloud with GitHub Action)
Modified setup.py file to include information on supported python versions
Minor refactoring

EDIT:

Removed Python 3.10 build for now, only supports 3.6-3.9 (as SimpleITK does not support 3.10 yet)
Also merged all workflows into a single workflow (ran as a nested matrix). Only one zip is produced with all wheels
Also added unit tests for all wheel builds, running all three demos
For the demos to work I had to swap the plt.show() with plt.savefig(), as these are run on a headless server

Any updates on this?

Any updates on this?

Not really up to me. But if we hear nothing from the dev team, I could make a temporary PyPI project called SimpleCRF-binaries, which has this fix. However, the easiest solution is just to accept this PR and add the binaries.

i think lets go with plan-b.. it's been a while.. we don't see any chances to see this PR getting merged... may be once it's merged, we can start using regular simplecrf package from PIP...
@andreped thanks for helping on this.. we can create SimpleCRF-bin (or any other name that makes sense) as alternative package and MONAILabel will start using them for now..

@SachidanandAlle I can make the PyPI repo, as I was the one making these edits. I can give you admin rights to the repo, if you'd like. I will use my fork as base.

@SachidanandAlle I have created the temporary PyPI project:
https://pypi.org/project/SimpleCRF-binaries/
To install simple run the command:
pip install SimpleCRF-binaries
Let me know if there are any issues. As this is a temporary solution, I only made the minimal necessary edits to make this work.

@andreped Is there a reason why the macOS whl for Python 3.9 is the only one that has minimum requirement of macOS 10.15 (SimpleCRF_binaries-<IP_ADDRESS>-cp39-cp39-macosx_10_15_x86_64.whl) compared to macOS 10.14 for the other whl files?
Also in 3D Slicer as of right now soon to be released Slicer 5.0 has minimum support for macOS 10.13. We are actually not using the latest numpy version because it bumped its minimum macOS whl version to macOS 10.14. See https://github.com/Slicer/Slicer/commit/81517ef9a6a4a4d69efce347adc3fce9d03b785e.

@jamesobutler I believe this happened automatically.
AFAIK, if you build wheels using GitHub Actions, only macOS >= 10.15 is supported.  But there is little I can do about it.
There is something called CMAKE_OSX_DEPLOYMENT_TARGET which you can set, at least for CMake, that solves this issue. However, I have tried to have a similar fix for Python projects, and I have not gotten it to work. There is also this answer from the GitHub team: this...
But maybe you have solved this somehow for MONAI Label, @SachidanandAlle, @masadcv? I could incorporate your fix to support more macOS versions. But yeah, I could do some tests at my side. However, it is a bit challenging, as I would have to build on the cloud and run tests on a local macOS 10.13 machine...
To produce the binaries for the new PyPI project, I am working on a separate branch: https://github.com/andreped/SimpleCRF/tree/binaries
If you find a fix, you can let me know where to add it.

@jamesobutler I have tried to fix this in the latest release candidate now:
pip install SimpleCRF-binaries==<IP_ADDRESS>rc1
At least I was able to install it and import "denseCRF" and "maxflow". You still need to upgrade numpy. But since MONAI Label has chosen to not use SimpleCRF in the future, due to licensing issue, I guess these fixes will only be relevant for the SimpleCRF community. These edits are in the binaries branch of my fork.

@taigw Hello! Is it possible to merge this and make a new patch release such that when installing from PyPI you install through the binary wheels?


How can I make Check -in Check-out

Hello, thanks to you for this plugin.
I want to make a check-in check-out date system with this plugin.
I put datepicker to in a div
I want to make when I select first date, a span will dynamicly get to date, and then I will select second date, another span will dynamicly get to date and datepicker will close.
But I can't do anything when datepicker selected. Can you help me ?
Sory for my english :)
my codes:

var BuGun   = new Date;
BuGun.addDays(2);

var DefCheckOut = new Date;
DefCheckOut.addDays(4);

$('.1-calendars').pickmeup({
format  : 'd-m-Y',
min         : BuGun,
flat        : true,
date        : [
   BuGun,
   DefCheckOut
],
mode        : 'range',
calendars   : 2
});

You just need to handle change event and update your span's accordingly.
Please refer to readme for details: https://github.com/nazar-pc/PickMeUp#events-callbacks

I tried to use to "change" event. But I think used wrong. Can you show to me an example for that how to use.

$(..).pickmeup({
...
    change : function (formatted_date) {}
...
});

Nazar you are great. Thanks. I have just final question... I get dates when select datepicker. But I get two dates. For example ; At first selection, I get  '13-08-2015, 13-08-2015' and then at second selection, I get '13-08-2015, 21-08-2015'
That is become because of the mode is "range". I tried to use "separator" event. But I didn't do it. Can you show to me that how can I get first and second dates separately.
Thanks again for your help.

separator is not an event. you should be getting array of two dates, but if you print it - it shows like coma-separated, try to print formatted_date[0] and formatted_date[1] separately.

Yes I will print first date to a  and print second date to another .
But when I try to do this that like you said, it give me this:
CODES:
change : function (formatted_date) {
var GirisTrh = ($('#dp1').pickmeup('get_date',formatted_date[0]));
$('#IndexV3AramaGirisTrh').html(GirisTrh);
}
PRINT:
first select        - 14-08-201514-08-2015
second select  - 14-08-201514-08-2015
So it is same data.
You already have first date in formatted_date[0], just use it directly.

I mean this:
(https://cloud.githubusercontent.com/assets/10242641/9115038/b14a75a6-3c65-11e5-8a75-bb6c2f4a878f.jpg)
I can get first and second dates when I selected. But it is printing dates twice like img

Printing is something specific your code, if you can get two dates separately - everything further is not PickMeUp's responsibility.
Read the docs and you'll find your answer.


Add activity feed API

#349  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Update Username to User for consistency with other schemas

@limwainstein

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks @vakohl and @Jak-MS!

#sign-off


Windows Server 2012 support for .NET Core 3 / 3.1

The supported OS page for .NET Core 3.0 (https://github.com/dotnet/core/blob/master/release-notes/3.0/3.0-supported-os.md) shows Server 2012 R2 SP1+ as minimal version for Windows Server. However, as far as we know 2012 R2 doesn't even have a Service Pack 1. Also Windows Server 2012 is still supported for years.
We are currently debating moving from .NET Framework to .NET Core for an on-premise application, and we would expect .NET Core 3 to also support Server 2012, since that still has extended support for several years (possibly longer even than .NET Core 2.1 LTS). So the difference in support between 2012 and 2012 R2 is crucial in deciding whether to go for .NET Core or stay with the .NET Framework.
Can you confirm whether .NET Core 3 (or possible 3.1 LTS) is actually supported on Server 2012?

@terrajobst

@leecow @richlander

I am also concerned about this issue.
And I have  a question,
I did not found ‘Server 2012 R2 SP1’ service pack.
How can i check my os ‘2018 R2’    Support  .NET Core 3.0  ？

I know it's near the end of life, but if not supported then Windows Server 2008 R2 SP1+ is not listed under the "Out of support OS versions" for Core 3 compared to 2.2

@bartonjs That was our reasoning as well. It doesn't make much sense for 2012 not to be supported when 8.1 is still supported. You're probably correct on the change from 2008 R2 SP1. However, since this document seems to be the official OS support statement for .NET Core it'd still be good to get some confirmation.

I've updated the document to say "2012 R2+". Thanks.

Jeremy's explanations are correct. Sorry for the confusion!

If Win2008R2 SP1 is no longer supported, what about the status of Win7 SP1(client). I think they are almost the same(NT6.1), but the latter one is still in the list.
By the way, 3.1-supported-os.md should also be updated.

@scalablecory
"I've updated the document to say "2012 R2+"." : I'm maybe wrong but this does not totally answer to the original request. What about Windows Server 2012 (not R2)? It's supported until October 2023, isn't it?

@scalablecory We have the same issue and the documentation update wasn't clear concerning the original question. We have servers running 2012 (not R2) which is supposed for 3.5 more years, has .NET Core 3.0/3.1 officially dropped support for 2012?

@scalablecory I'd also like to know this. Arguably, the question hasn't even been answered - not clearly at any rate. If Windows 7 SP1 is supported by 3.0 and 3.1, even after all Windows 7 support is gone, shouldn't Server 2012-not-R2 be supported as a going concern?


radar width config not working

Version
5.3.3
Link to Minimal Reproduction
https://echarts.apache.org/examples/zh/editor.html?c=radar&version=5.3.3
Steps to Reproduce

set option
js radar:{  axisName:{      width:100,      backgroundColor:'pink',  } }
as you can see, there is no width change at all

Current Behavior
width does not  change as expected
Expected Behavior
width should change
Environment
- OS:macOS Monterey
- Browser: Chrome 103.0.5060.134
- Framework:

Any additional comments?
No response

hi, I'm interested in fixing this issue.

mark


⚠ Bofrost.at has degraded performance

In 727f2ab, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1217 ms

Resolved: Bofrost.at performance has improved in 23dd0eb.


[Code health] Cleanup MainViewModel to return SignInState flow directly

This change removes the need for launching a coroutine in view model scope for getting auth status. This also ensures that the auth status is always re-created if the view gets destroyed.

@sufyanAbbasi  PTAL?

Closing this for now.


Disable selection in comment/edit

This addresses https://github.com/unfoldingWord-dev/translationCore/issues/1336
How to test this:

Load a project and tool
Make a selection on any check
Click on "edit" or "comment"
Try and modify the selection while editing or commenting on the verse
You should no longer be able to.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

components/SelectArea.js, line 107 at r1 (raw file):

    let {verseText, projectDetailsReducer} = this.props
    this.props.actions.validateSelections(verseText)
    const { manifest, bookName } = projectDetailsReducer

These get used later

Comments from Reviewable


s3 connector (for data detection & discovery) POC - fides

Closes PROD-2151
‼ includes a DB migration, bump downrev as needed!
Needed for https://github.com/ethyca/fidesplus/pull/1456
Description Of Changes
OSS-side changes to support s3 as (initially) a d&d data source. Eventually we'll want to support S3 as a DSR data source, but that's not supported for now.
This PR creates an "S3" connection type that provides a space for AWS authentication credentials to be stored. We implement a new (and improved!) AWS auth paradigm that can leverage an optional "assume role ARN" to assume a specific role for S3 communications. This paradigm is not yet leveraged for our other AWS connections (e.g. DynamoDB), but the underlying utility can easily be leveraged, and we should look to support this paradigm for those connection types soon.
The S3 connection type implements a basic connection test to list buckets (as that's a key operation for our d&d monitor), but no support for the methods that need to be implemented for DSR processing.
Code Changes

[x] add S3Connector, ConnectionType.s3 enum, and S3Schema for secrets/credentials. add logo for the FE
[x] refactor, rename and improve an aws_util..py that can be used generically to get an AWS session with provided credentials that optionally assumes a provided role ARN

Steps to Confirm

[ ] connection type can be selected in the UI and tested successfully - with and without a provided assume role ARN
[ ] further manual testing done while integrating with the associated fidesplus PR

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
Documentation:

[ ] documentation complete, PR opened in fidesdocs
[ ] documentation issue created in fidesdocs
[ ] if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry

[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md
[ ] For API changes, the Postman collection has been updated
If there are any database migrations:

[ ] Ensure that your downrev is up to date with the latest revision on main
[ ] Ensure that your downgrade() migration is correct and works

[ ] If a downgrade migration is not possible for this change, please call this out in the PR description!

@pattisdr i wanted to get this OSS-side PR on your queue for review, no big rush though. i'm still working through the final touches on the plus-side to get it ready for review, but i think this can be reviewed in isolation.

Starting review - apologies for the merge conflicts 😓

test is failing in main and is unrelated - will go ahead and merge 👍


Unhelpful detail

The Description for Subkey "DisabledByDefault" is "Flag to disable <protocol> by default."  We can pretty much work that out ourselves.  What you should describe is how this setting differs from Enabled=0.
Describing a term with the term itself is shoddy work.  Maybe "Client" could refer to controlling outbound requests and "Server" could refer to controlling inbound requests?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38fcd9dd-91c8-e79b-5f4d-28a435a8ada8
Version Independent ID: 0d79a0c8-0b73-c783-4d5c-b107d24acf55
Content: Transport Layer Security (TLS) registry settings
Content Source: WindowsServerDocs/security/tls/tls-registry-settings.md
Product: windows-server-threshold
GitHub Login: @Justinha
Microsoft Alias: justinha

I would add further, there is no description that discusses the implications of setting this DisabledByDefault property. We get that changes the default, but the doc should detail if that's ALL that this property does.

@pbyhistorian @Szeraax for each setting, I added that DisabledByDefault means that if an app requests to use that protocol, it will be negotiated.

@Szeraax Thanks for the suggestion. It does mean disabled by default. I revised it again to clarify this and the difference between DisabledByDefault = 1 and Enabled = 0.

Well, you do whatever you want, but here's the use scenario that a lot of us fit into:
a vulnerability scanner will explicitly try to use each vulnerable cipher on a host port. If that scanner can connect with 3des or sha1 or whatever, it counts as enabled and we fail the scan. This "DisabledByDefault" does not disable the cipher. Just doesn't list it initially. I know I'm going in circles here, so I'll just know to never use that key because it serves no functional purpose.


fixed scm connection

Pull Request Test Coverage Report for Build 12
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.455%

Totals

Change from base Build 11:
0.0%

Covered Lines:
126

Relevant Lines:
133

💛  - Coveralls


Missing command "watch"

Hello the command watch is missing.
In docker:
bash: watch: command not found
In container:
Error opening terminal: unknown.

Which commands are available depends on the image you're running; if you're running a container that doesn't have watch in it, you'll get such errors.
Please keep in mind that the GitHub issue tracker is not intended as a general support forum,
but for reporting bugs and feature requests. For other type of questions, consider using one of;

https://forums.docker.com
the Docker community Slack channel
StackOverflow

If you still suspect there's a bug, please provide the information that was requested in the issue template when you opened this issue. Be sure to at least provide;

docker info
docker version
the exact steps to reproduce

Otherwise we won't be able to look into your issue.
I'm closing this issue, because I don't think there's a bug at hand here, but let us know if you think it's a bug, and have more information available


Set a default position and rotation for the hands in the editor view

Allows combined hand models to be lined up easier (at position 0,0,0 and no rotation) when added to a hand controller. Position is a compromise between the desktop and VR-style scenes -- must work for both.

Closing until Adrian's Quaternion changes are merged.


Pass in single value to set a maintenance window for all service ids

Being able to pass a string of service Ids is still a need.  I am looking into auto populating our service Id secrets when our Terraform creates our pagerduty technical services.  I don't want to have to manually add a separate Pagerduty maintenance window to my workflow every time I add a new pagerduty service.
https://github.com/im-open/open-pagerduty-maintenance-window/blob/main/main.js#L23

I will find some time to get this working with your current implementation as of today.

We were able to get the pagerduty service IDs to pass into the maintenance window successfully with the current action implementation.
You just have to remove the double quotes in the workflow and the secrets value work just fine with the format: "first","second","third".  But that could be problematic if you want to just have a single value with no quotes.


What's the type of a StoryboardScene enum ?

First of all, thanks a lot for this tool, I was  waiting for this for 4 years :-)
I have a question, which is not an issue.
I have a classical storyboard scene which is generated by swiftgen:
struct StoryboardScene {
  enum Dashboard : StoryboardSceneType {
    static let storyboardName = "Dashboard"
  }
...

So to separate the configuration of my tab bar from the rest, I have
  private struct Tab {
    let storyBoardName: StoryboardSceneType
    let logo: UIImage.Asset
    let logoSelected: UIImage.Asset
  }

  private let content = [
     Tab(storyBoardName: StoryboardScene.Dashboard, logo: .Home_32px, logoSelected: .Home_32px_Selected),
...

This does not work because StoryboardScene.Dashboard is of type StoryboardScene.Dashboard.Type which does not conform to StoryboardSceneType while I have the impression it does. I don't really understand why. And how am I supposed to do such a thing ?

Your initializer of private struct Tab expect its first parameter to be an instance of type StoryboardSceneType. StoryboardScene.Dashboard is a type, not an instance of this type.
Depending on what you want to achieve, you might want to:

Pass the storyboard name (and not the enum type), as your struct property name actually suggests:

Tab(storyboardName: StoryboardScene.Dashboard.storyboardName, …)

Or store the type (instead of an instance) in your struct Tab:

private struct Tab {
  let storyboardType: StoryboardSceneType.Type
  …
}

Then you can call Tab(storyboardType: StoryboardScene.Dashboard, …) and use it as such a generic StoryboardSceneType metatype next.

Thanks for the quick answer. You're right, it is the type of the type, and not the instance. Of course, I do not want to put the name string as the goal of using your tool is to have something failing at compile time.
So following your advise, I have
  private struct Tab {
    let storyBoardType: StoryboardSceneType.Type
    ...
  }
  ...
   Tab(storyBoardType: StoryboardScene.Settings, logo: .Sliders_32px, logoSelected: .Sliders_32px_Selected)

But this does not work because I cannot just pass a type, I get "Expected member name or constructor call after type name".
So I have to do:
Tab(storyBoardType: StoryboardScene.Settings.self, logo: .Sliders_32px, logoSelected: .Sliders_32px_Selected)

and then use later with:
s.storyBoardType.initialViewController()

Would you have an idea of cleanest (less verbose) way ?

No, I think that's the shortest way you can get with Swift for your use case, so your solution is the right one I think.

Ok thanks!


(Fix) Display warning at invest page if user is not whitelisted

Display warning at invest page if user is not whitelisted or he is whitelisted but he have bought all permitted amount of tokens

This issue in branch 2.0 . https://github.com/poanetwork/token-wizard/issues/917
PR is ok

Pull Request Test Coverage Report for Build 2238

1 of 11 (9.09%)  changed or added relevant lines in 2 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.05%) to 21.746%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/invest/index.js
0
1
0.0%

src/components/crowdsale/utils.js
1
10
10.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/crowdsale/utils.js
1
3.97%

src/components/invest/index.js
2
0.0%

Totals

Change from base Build 2234:
-0.05%

Covered Lines:
744

Relevant Lines:
3259

💛  - Coveralls


Fill only takes Color, but should be able to take references to gradients and patterns.

The functions fill and stroke can only take Color (and FillNone in the case of fill) as an argument, but should be able to take references to gradients and patterns.
I found this out when I tried to replicate this svg snippet:
<defs>
  <pattern id="pattern1"
           x="10" y="10" width="20" height="20"
           patternUnits="userSpaceOnUse" >

      <circle cx="10" cy="10" r="10" style="stroke: none; fill: #0000ff" />

  </pattern>
</defs>

<rect x="10" y="10" width="100" height="100"
    style="stroke: #000000; fill: url(#pattern1);" />

(http://tutorials.jenkov.com/svg/fill-patterns.html)
(of course you could do the svg reference with TypedSvg.Attributes.style, but I view that function more like a helper and escape-hatch than something to use on a regular basis in the actual API.)

Should we have a Fill type along the lines of FillNone | Fill Color | Reference String.
String is "pattern1" from the above example and we add the "url(#...)" in the typeToString-function?
Should we call it Reference or is something else more suitable?

These are all the possible values that fill can take:
https://www.w3.org/TR/SVG/painting.html#SpecifyingPaint
Also, according to the MDN, those apply both for fill and stroke:
https://developer.mozilla.org/ca/docs/Web/SVG/Content_type#Paint
This means that stroke and fill should accept exactly the same arguments, and that there are 5 types of values.


Add config entry to specify cookie path

browser_cookie3 fails to retrieve cookie of default profile for Chrome if there are multiple user profiles(on Darwin for me). however, browser_cookie3 does support specifying cookie path explicitly.
may be something like this:
let g:leetcode_browser='chrome'
let g:leetcode_cookie_path='path/to/profile/cookie.db'

or we can infer browser from cookie path, keeping one config entry
let g:leetcode_cookie_path='path/to/profile/cookie.db'

Sure. I'll add this option soon.


[Q] "filter" plugin negate --after-packets

Hi @lelegard ,
Simple question: How to obtain the effect of negate --after-packets count in the filter plugin?
What I need to do is: filter out all packets (of a tsp processing) until one specific packet (that I know only the number) and after pass all others. My initial idea is to do a -P filter --until-packets 9999 ..., but this option is not available. And in the documentation:
--after-packets count
Let the specified number of packets pass transparently without filtering. Start to apply the
filtering criteria after that number of packets.

So it's not possible to negate it with -P filter -n --after-packets 9999 .... Any idea?

Why not simply -P skip 12345?

Why not simply -P skip 9999?

Why not simply -P skip 9999?

OMG! One specific plugin for this task. So thank you.
Regards.


Arial Support

Is ther e a plan to add Arial Font support for Katex -?

@fsonmezay I do not expect that KaTeX will support Arial font.
One of the reasons that KaTeX is fast is that it does not have to query the browser for dimensions of font glyphs and then wait for the browser to reply. KaTeX has detailed metrics for the glyphs in the KaTeX font, so it can work with those metrics. In order to use another font, one would have to first extract the metrics for each glyph in the font and make that data available to KaTeX.
That might happen some day for one of the mathematical fonts, but I don't think it is likely to happen any time soon for Arial.

@fsonmezay If you're looking for a sans-serif font, you can use \mathsf{example} or \textsf{example}. This uses the sans-serif font in the Computer Modern typeface.

@ronkok , @edemaine Thank you both for your time and detailed explanations.
@edemaine we already use \sf for the formulas, but in some cases we thought we can use Arial font.


Fix a few doc issues

Fix some of the doc issues mentioned in https://github.com/asyml/texar-pytorch/issues/259

expose DecoderBase in doc
delete unnecessary code in examples/gpt-2
update doc of TransformerDecoder and RNNDecoderBase

Could you fix the CI error?

Merged these changes in #290


Lost "reset view location" context menu item

Dragging and reording things, and I don't see that item on the terminal now, but I think it should be there right?

I think that's only when it's inside another container?

yea, since you can move view containers now, this isn't considered moved. there is a separate issue for allowing to reset view containers to their default locations.


Unable to retrieve contribution hash from transcript

ℹ Joining the Circuit 2 waiting queue for contribution (this may take a while)

Circuit # 1 (Contribution Steps)
✔ Contribution #00011 correctly downloaded

🕛  Writing contribution metadata...✖ Unable to retrieve contribution hash from transcript. Possible causes may involve an error while using the logger or unexpected file descriptor termination. Please, terminate the current session and repeat the process.

I had the same error, repeatedly, in a Windows CLI session. Switched to Linux (WSL) and it worked OK.

Closing since we encountered this issue in a previous contribution and we have already added to the documentation and guides that we only and exclusively support WSL on Windows.


Remove version: Datronicsoft.SpacedeskDriver.Server version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

Automatic Validation ended with:

2024-02-08T17:39:35.3894117Z Processing manifest: manifests\d\Datronicsoft\SpacedeskDriver\Server\<IP_ADDRESS>
2024-02-08T17:39:35.3901520Z -----------------------------------------------------
2024-02-08T17:39:35.3910154Z Status: Started
2024-02-08T17:39:35.3918954Z Manifest file is Deleted
2024-02-08T17:39:35.6812430Z Status: Completed
2024-02-08T17:39:35.6856676Z ##[error] Result: Failed
2024-02-08T17:39:35.7025989Z ##[error] Sequence contains no elements
2024-02-08T17:39:35.7606728Z ##[error]Manifest Validation Failed

(Automated response - build 716.)

Sequence contains no elements

https://github.com/microsoft/winget-pkgs/issues/133371

(Automated response - build 716.)

URL: https://spacedesk.net/downloads/spacedesk_driver_Win_10_64_v2105.msi
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 716)

Hi @Exorcism0666,
This manifest has the highest version number for this package. Is it available from another location?
(Automated response - build 719.)

Hi @Exorcism0666,
This manifest has the highest version number for this package. Is it available from another location?
(Automated response - build 719.)

This appears to have been in error. Sorry.


Inconsistent results between RMatrix and XMatrix values on Windows and Mac

If I run the following OpenDSS circuit,
Clear

New Circuit.test_circuit

New Wiredata.wire1 GMR=0.0255000 DIAM=0.7410000 RAC=0.3060000 NormAmps=530.0000 Runits=mi radunits=in gmrunits=ft
New Wiredata.wire2 GMR=0.0044600 DIAM=0.3980000 RAC=1.120000 NormAmps=230.0000 Runits=mi radunits=in gmrunits=ft

New Linegeometry.geometry_1 nconds=4 nphases=3
~ cond=1 Wire=wire1 x=-1.2909 h=13.716 units=m
~ cond=2 Wire=wire1 x=-0.1530096 h=4.1806368 units=m
~ cond=3 Wire=wire1 x=0.5737 h=13.716 units=m
~ cond=4 Wire=wire2 x=0 h=14.648  units=m ! neutral

New Line.Line1 Bus1=bus<IP_ADDRESS> Bus2=bus<IP_ADDRESS>
~ Geometry= geometry_1
~ Length=1 units=m

Set Voltagebases=[4.8,34.5,115.0]
Calcvoltagebases
Solve

On Windows I get:
julia> Lines.ZMatrix()
4×4 Array{Complex{Float64},2}:
 0.000244709+0.000882268im   5.81934e-5+0.000344936im    5.7659e-5+0.000469068im   5.76072e-5+0.000481031im
  5.81934e-5+0.000344936im  0.000245786+0.000881161im   5.81934e-5+0.00034525im    5.81408e-5+0.000338483im
   5.7659e-5+0.000469068im   5.81934e-5+0.00034525im   0.000244709+0.000882268im   5.76073e-5+0.000509296im
  5.76072e-5+0.000481031im   5.81408e-5+0.000338483im   5.76073e-5+0.000509296im  0.000740038+0.00101383im

On Mac I get:
julia> Lines.ZMatrix()
4×4 Array{Complex{Float64},2}:
 0.000254461+0.000882268im   5.81934e-5+0.000344936im    5.7659e-5+0.000469068im  5.76072e-5+0.000481031im
  5.81934e-5+0.000344936im  0.000255537+0.000881161im   5.81934e-5+0.00034525im   5.81408e-5+0.000338483im
   5.7659e-5+0.000469068im   5.81934e-5+0.00034525im   0.000254461+0.000882268im  5.76073e-5+0.000509296im
  5.76072e-5+0.000481031im   5.81408e-5+0.000338483im   5.76073e-5+0.000509296im  0.00074955+0.00101383im

There appears to be some inconsistency.

If I make the earth model SIMPLECARSON or FULLCARSON, I get the same result. However, if I make the earth model DERI it returns different results on Windows and Mac/Linux.
New Line.Line1 Bus1=bus<IP_ADDRESS> Bus2=bus<IP_ADDRESS>
~ Geometry= geometry_1
~ Length=1 units=m EarthModel=DERI

So far, I noted the Bessel I0 and I1 results are slightly off while everything else is identical. Code here.
The Windows values between C-API and COM match and seem correct (compared to scipy's results, which use ZBESJ from netlib.org). Disabling optimization on Linux didn't change any of the values.
A couple of years ago I compared the line model from OpenDSS (COM) with my own C++ implementation and there was indeed a small difference due to those values (Bessel I0 and I1), but nothing this pronounced.  Looking now, there seems to be an unused (maybe partial?) port of ZBESJ from Slatec in MathutilInterface.pas.
I'm going to compare the local variables in the functions to see if there's any clue in them.

Thanks for taking a look! Yes, I didn't mention it here but I checked using the official OpenDSS GUI on Windows and got the same values as the Windows version using the CAPI. It's odd that it only occurs when using EarthModel=DERI. I did a few grep searches to check if there was any Windows specific code in the files related to Lines, LineCodes and LineGeometry but didn't find anything that could be the cause of this.

Found it:
function CMUL(const a, b: complex): complex; inline;
begin
    Result.RE := A.RE * B.RE - A.IM * B.IM;
    Result.IM := A.RE * B.IM + A.IM * B.RE
end;

It looks like when the following idiom is used FPC doesn't check for aliasing and overwrites term.re  after the first line.
term := CMul(zSQR25, term);

At first I thought inlining was the issue, but actually the const qualifier is the root cause. Since complex a record, it's passed by reference when using const (it's equivalent to var + some checks). From this old thread, it seems the issue also could happen with Delphi.
I didn't find a switch to disable the potential const optimization. Tomorrow I think I'll just remove any const that potentially could cause aliasing. In terms of optimization, since there values are pairs of doubles, I don't think it will impact anything noticeably.

Wow, great job sleuthing! That is a nasty bug, I'm both amazed and terrified.
Isn't the Windows build compiled using FPC as well? Why didn't the Windows version have the same issue? Surely the Windows FPC compiler is performing the same optimizations as the Mac/Unix FPC compilers.

That is a nasty bug, I'm both amazed and terrified.

Yep, what I don't like (and more people seem to agree even on that long 2011 thread) is that there's no warning from the compiler. It seems like if you want performance with Pascal you need to use C constructs, but that lead to potential bugs and that's when I wonder if there's a reason to keep using it.

Isn't the Windows build compiled using FPC as well?

It is, but the calling conventions are not the same and that might be what's preventing the issue from manifesting on Windows. I did also try to tweak the compiler flags to see if we could either get it bug out on Windows or remove the bug on Linux.
Good news is that const is not used that much in functions that could cause the issue. Besides Source/Shared/Ucomplex.pas, there are candidates in Source/Common/Utilities.pas and some other sparse files. I'm reviewing the related code and should fix this soon -- after testing, it's a good time to release 0.10.3 before it accumulates too many changes.

The tagged 0.10.3a5 (also pre-released) includes the changes related to this (and a few more changes). @kdheepak Can you check it on your side? I'll try to finish the full cross-platform COM comparison before the next release.
The following were changed:

Source/Common/Utilities.pas: RestoreCRLF(const S: String): String;: This was unused, code has been removed (since it was partially broken anyway).
Source/Common/MeTIS_Exec.pas: Max(const A, B: Integer): Integer;: code removed in favor of the Math unit.
Source/Common/Utilities.pas: ReplaceCRLF(const S: String): String;: rewritten with StringReplace, it was probably broken on Linux/MacOS before.
Source/TCP_IP/TCP_IP.pas: StrippedOfNonAscii(const s: String): String;: const removed. It was probably broken before but we don't use this on DSS C-API (yet?)
Source/Shared/Ucomplex.pas: cmul(const a, b: complex): complex;: const removed
Source/Shared/Ucomplex.pas: cdiv(const a, b: complex): complex;: const removed

Some functions (e.g. Bessel_I0 and Bessel_I1) could also present issues if the input parameter is the same as the result. For those, I checked it the current usage does it or if it would ever make sense to use it like that.
I also changed TDSSClass.ClassEdit and all of its overrides from function to procedure since the result was always zero and not used anywhere.
Just to confirm, the issue might happen in Delphi too.  for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.1.0 (2019-01-21)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using OpenDSSDirect

julia> dss("""
       Clear

       New Circuit.test_circuit

       New Wiredata.wire1 GMR=0.0255000 DIAM=0.7410000 RAC=0.3060000 NormAmps=530.0000 Runits=mi radunits=in gmrunits=ft
       New Wiredata.wire2 GMR=0.0044600 DIAM=0.3980000 RAC=1.120000 NormAmps=230.0000 Runits=mi radunits=in gmrunits=ft

       New Linegeometry.geometry_1 nconds=4 nphases=3
       ~ cond=1 Wire=wire1 x=-1.2909 h=13.716 units=m
       ~ cond=2 Wire=wire1 x=-0.1530096 h=4.1806368 units=m
       ~ cond=3 Wire=wire1 x=0.5737 h=13.716 units=m
       ~ cond=4 Wire=wire2 x=0 h=14.648  units=m ! neutral

       New Line.Line1 Bus1=bus<IP_ADDRESS> Bus2=bus<IP_ADDRESS>
       ~ Geometry= geometry_1
       ~ Length=1 units=m

       Set Voltagebases=[4.8,34.5,115.0]
       Calcvoltagebases
       Solve

       """)
""

julia> Lines.ZMatrix()

signal (11): Segmentation fault: 11
in expression starting at no file:0
Capacitors_Set_idx at /Users/$USER/GitRepos/OpenDSSDirect.jl/deps/apple/libdss_capi_v7.dylib (unknown line)
Allocations: 9730695 (Pool: 9728350; Big: 2345); GC: 21
[1]    87804 segmentation fault  /Users/$USER/Applications/Julia-1.1.app/Contents/Resources/julia/bin/julia

The above was with v0.10.3a5. I've tried compiling locally as well and still get the same segfault.

On Windows oddly, I get the following error when trying to execute the Calcvoltagebases line:
julia> dss("""Calcvoltagebases""")
ERROR: ReadOnlyMemoryError()
Stacktrace:
 [1] Text_Set_Command(::String) at Z:\GitRepos\OpenDSSDirect.jl\src\lib.jl:4374
 [2] Command(::String) at Z:\GitRepos\OpenDSSDirect.jl\src\text.jl:25
 [3] top-level scope at none:0

I really got to automate testing with all interfaces to avoid this kind of issue. The crash itself was another (simple) memory corruption I accidentally introduced in 0.10.3 while refactoring.
Testing that, I found another issue: in COM, AllNames for some classes change the active element, others don't. When I started changing these functions a while ago, some classes ended up inconsistent with COM -- that is, AllNames left a different element active than the one from COM (when it does change the active element, it's left as the last one of the list). I changed this to be consistent and added a test case. One test needed to be updated in OpenDSSDirect.jl to address that.
I tagged another pre-release and created a branch in OpenDSSDirect.jl to run the test suite (I didn't new tests though). This time it seems to be fine: https://travis-ci.com/dss-extensions/OpenDSSDirect.jl/builds/107382777
I'll merge the upstream changes from SVN and tag another pre-release right after.

Thanks for looking into this! Let me know if I can do anything.

With the latest tag, when I compile locally, I don't get the segfault anymore on my Mac, but I am still getting the old ZMatrix values.
julia> Lines.ZMatrix()
4×4 Array{Complex{Float64},2}:
 0.000254461+0.000882268im   5.81934e-5+0.000344936im    5.7659e-5+0.000469068im  5.76072e-5+0.000481031im
  5.81934e-5+0.000344936im  0.000255537+0.000881161im   5.81934e-5+0.00034525im   5.81408e-5+0.000338483im
   5.7659e-5+0.000469068im   5.81934e-5+0.00034525im   0.000254461+0.000882268im  5.76073e-5+0.000509296im
  5.76072e-5+0.000481031im   5.81408e-5+0.000338483im   5.76073e-5+0.000509296im  0.00074955+0.00101383im

julia>

This is still inconsistent between Windows and Mac.

I tested it yesterday on Mac and got the expected result. Can you try the pre-built binaries? If those don't work, I think we'll need to test the related code in isolation to understand what's happening.
Yesterday I also merged the upstream changes but had to fix a small issue. I reported it here:
https://sourceforge.net/p/electricdss/discussion/experts/thread/8f91b8dc29/
The merge from upstream might also have introduced a GUI dependency that's breaking console interaction (Windows only). I'll look into it later, unfortunately there's no easy way to automate a test for this.

Interesting. The pre-built binaries give me the expected result, i.e. same result as Windows.
Lines.ZMatrix()
4×4 Array{Complex{Float64},2}:
 0.000244709+0.000882268im  …   5.76072e-5+0.000481031im
  5.81934e-5+0.000344936im      5.81408e-5+0.000338483im
   5.7659e-5+0.000469068im      5.76073e-5+0.000509296im
  5.76072e-5+0.000481031im     0.000740038+0.00101383im

Any chance FPC is reusing old object files on Mac?

I did a git clean -fxd but I think I copied over the incorrect file to the OpenDSSDirect.jl/deps/apple folder. This newest tag resolved the issue for me, if I compile locally and if I download the pre-built binaries!

That's great! I was starting to worry. I started using symlinks to avoid copying the test binaries on Windows/Linux (that bit me in the past too).
I'll try to finish the cross-platform validation to see it there are other inconsistencies like that before the proper release.

I'll try to finish the cross-platform validation to see it there are other inconsistencies like that before the proper release.

Finally did that and, fortunately, no surprises, the errors are now in the same order as the Windows build! Basically I ran python validate.py save on Windows to pickle the COM output, then used the pickled results on Linux and macOS. I had to rename files to fix the casing for Linux (updated in electricdss-tst).
The saved results compress nicely to around 50 MB -- if it doesn't take too long to run on Travis, we can upload that somewhere and run it when building dss_python; if it does take long, a subset without the large circuits should be fine to get good coverage. I'll follow up on https://github.com/dss-extensions/dss_python/issues/9
Although the process didn't find new bugs, #15 still needs some treatment as the current solution failed to error on a missing file.
I also ran the validation without the fix for this issue and, yes, it caught on the first test circuit. I looked into our files at Unicamp to check why we didn't get the error before and, besides other potential changes in the build, the files we use/generate generally include the LineCodes directly -- the LineGeometries are post-processed during generation and fed back as LineCodes, which are also exported to a DB for other studies without OpenDSS. So far this was done using Windows, we got lucky...

Nice! Travis-CI lets you run cron jobs, long running tests can be run every night or every week.
When you compare COM results on Windows is it using dss_capi? Can we run it against the official library as well?

Nice! Travis-CI lets you run cron jobs, long running tests can be run every night or every week.

OK, running nightly and skipping the tests if there are no changes in any of the related repositories looks like a good idea.
I'll try to rewrite the validation script to use nose, pytest or hypothesis. I started something about it but never finished it.

When you compare COM results on Windows is it using dss_capi? Can we run it against the official library as well?

The script saves the official COM results (the errors I mentioned were in relation to them) and compares those with dss_python's -- we don't have an actual COM implementation yet (DSS# can expose one with some extra steps).

I'm not sure I exactly follow. I also get a "page not found" when I try to visit the link you posted when I visit from my mobile, I'll try again later and post my question more clearly.

Fixed, there was a typo there.


[roosterteeth] Download ad-free streams

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

This PR makes the Rooster Teeth extractor grab ad-free streams instead of streams with embedded ads.
Based on the videos I've looked at, by default video_data['attributes']['url'] contains ads and video_data['links']['download'] does not. Preferring the latter over the former is enough to download ad-free streams.
Additionally, passing in a Client-Type: web header forces both URLs to be the same ad-free stream. This PR includes that header as well for some slight future-proofing.
The RoosterTeeth tests were failing due to incomplete attribute data in test cases so this PR fixes that too.
Fixes #7647
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Thank you so much for this, I'm trying to back up the entirety of RoosterTeeth in wake of yesterday's news and your branch has solved some significant issues I was having with 403/404 errors.

Hey, if you can do any extra work on this, I'm getting lots of 403 errors trying to download the https://roosterteeth.com/series/achievement-hunter playlist

I don't want to clog up this PR with this (it may be an unrelated issue), but I do just want to say you can get an m3u8 link from the Rooster Teeth API that you can pass to yt-dlp.  This gets you the video file but not subtitles or any metadata.
e.g., if you're trying to download https://roosterteeth.com/watch/red-vs-blue-season-3-thanksgiving-day-psa, you'd go to https://svod-be.roosterteeth.com/api/v1/episodes/red-vs-blue-season-3-thanksgiving-day-psa/videos then grab the m3u8 link from ["data"][0]["attributes"]["url"].
That should allow you to download videos while a "proper" solution is implemented and merged, so long as you're okay with not having metadata or subs.

The lack of subtitles going about it that way is a dealbreaker, I'm trying to back up the entire site in preparation for the eventual delisting of content as rights are sold off, if not the total shutdown of the site as things wind down over the next six months. Please keep me updated as to a proper solution.

@memmam subtitles and playlist 403 errors are out-of-scope for this PR. Please refrain from off-topic comments

Actually, my bad, the playlist 403 errors are caused by the video_data['links']['download'] m3u8 URLs.  If passing the client header yields ad-free streams for the original m3u8 URLs we should only use those

@bashonly Yeah, I downloaded and built the fork with your changes, this PR fixes some of the 403 errors but seemingly not all of them, I'll take the hit as to that being not entirely related. My concern is that in the time since this PR was made, WB announced they're shutting Rooster Teeth down, so any development getting the extractor fully working should be a high priority so the site can be archived. I'll open an issue once this PR is merged.

@bashonly Yeah, I downloaded and built the fork with your first change, this PR fixes some of the 403 errors but seemingly not all of them, I'll take the hit as to that being not entirely related.
My concern is that in the time since this PR was made, WB announced they're shutting Rooster Teeth down, so any development getting the extractor fully working should be a high priority so the site can be archived. I'll try your new change, and if it's still a problem, open an issue once this PR is merged.

Wait, either I misunderstood or, the line was updated but you also wanted it moved, which it wasn't?

@memmam the line hasn't been changed. I retracted my original suggestion after your discovery that the new URLs were bad

Some examples:
ad-free m3u8 url fetched by client-type header alone (video_data['links']['download'] is not needed):
https://roosterteeth.com/watch/death-battle-season-10-antman
403 error if we use video_data['links']['download']:
https://www.roosterteeth.com/watch/achievement-hunter-achievement-hunter-fatality-walkthrough-deathstroke-lex-luthor-captain-marvel-green-lantern-and-wonder-woman

Thank you for putting this PR together. I don't know if this would warrant an addition here or a separate PR, but I've added this line to the extractor to grab the upload date so videos could be sorted by time:
--- a/yt_dlp/extractor/roosterteeth.py
+++ b/yt_dlp/extractor/roosterteeth.py
@@ -70,6 +70,7 @@ def _extract_video_info(self, data):
             'episode_id': str_or_none(data.get('uuid')),
             'channel_id': attributes.get('channel_id'),
             'duration': int_or_none(attributes.get('length')),
+            'upload_date': attributes.get('original_air_date').split("T")[0].replace("-",""),
             'thumbnails': thumbnails,

It's also trivial to add bonus feature extraction to the series extractor. Does that need a separate issue or can it go straight to another PR?

@jkmartindale could you open a separate PR please?
@vidyava separate PR, I'll open it

Just to expand on the 403 errors since this seems to be where they're being discussed: even with the updated header and urls some links still fail. An example:
https://roosterteeth.com/watch/lets-play-2013-126
returns a 403 error from yt-dlp despite the video playing in a browser, and going to either m3u8 url returned by the API directly gets:
[
  {
    "error_code": "VIDEO_NOT_PLAYABLE",
    "message": "The policy key provided does not permit this account or video, or the requested resource is inactive."
  }
]

Attempting the same process with https://roosterteeth.com/watch/lets-play-2013-127 successfully downloads the m3u8 file and the video.
Loading both with the network debugger open shows the former loads the stream from https://rtv2-video.roosterteeth.com/uploads/videos/4e599900-19cd-4cf0-87fd-af80f6bbcf02/index.m3u8 and similar internal CDNs rather than brightcove or boltdns. I'm over my head on how to fall back when the API links to a non-existent playlist file, but providing info in case it's clear to anyone else.

@vidyava I think this needs to be opened as a separate issue. Could you do that, since you seem to have figured the problem out?

@vidyava to add to this, by using the brightcove fallback bash provided in https://github.com/yt-dlp/yt-dlp/pull/9355#issuecomment-1984841014, you can see that the actual m3u8 is the same as the one loaded via the website:
https://players.brightcove.net/6203312018001/default_default/index.html?videoId=6311613926112
loads https://rtv2-video.roosterteeth.com/uploads/videos/4e599900-19cd-4cf0-87fd-af80f6bbcf02/index.m3u8
the brightcove video id is available in the /videos response under attributes['uid']
idk if these urls are known to be ad free in this case though. the empty ad_breaks array in the /videos could maybe hint at that

The thing is that this thread is already completed, might be worth opening a new one, so it won't get lost in the shuffle.

@vidyava @NBruderman @Bl4Cc4t #9403

It's also trivial to add bonus feature extraction to the series extractor. Does that need a separate issue or can it go straight to another PR?

Can you open a PR for that?

@NBruderman opened a PR above for bonus feature support


Fix queue for dm/vimeo

Queue only supports yt.

Somewhat resolved. Should be functional, but visual queue does not work.
e534eeb4165dabd08ca246fa8b8d471fd073066a


Revert "Change Certain numpyros To npro"

Reverts CDCgov/multisignal-epi-inference#316

I have examined the diffs for the landed commit, and I don't think it actually undid any of #317. I think it simply revealed that #317 didn't catch all cases. I think we can close this but should open a new issue/PR to fix the remaining cases of numpyro.handlers.seed


Fix namespace resolution issue in LOG_EVERY_T

int64 is a typedef defined within @ac_google_namespace@, while LOG_EVERY_T is defined within ::google:: namespace.
but @ac_google_namespace@ is configurable and might not always be "google".
It can result in a compilation error, int64 being undefined. using absolute namespace resolution with @ac_google_namespace@:: fixes it.
Also replaced 2 other hardcoded google:: usage.

Codecov Report

Merging #801 (f877f25) into master (a8e0007) will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   73.20%   71.83%   -1.38%
==========================================
  Files          17       16       -1
  Lines        3281     2915     -366
==========================================
- Hits         2402     2094     -308
+ Misses        879      821      -58

Impacted Files
Coverage Δ

src/glog/logging.h.in
76.92% <ø> (-3.08%)
:arrow_down:

src/symbolize.cc
0.00% <0.00%> (-64.12%)
:arrow_down:

src/utilities.cc
53.73% <0.00%> (-13.92%)
:arrow_down:

src/logging.cc
73.28% <0.00%> (-1.41%)
:arrow_down:

src/demangle.cc
97.00% <0.00%> (-0.48%)
:arrow_down:

src/stacktrace_libunwind-inl.h

src/signalhandler.cc
6.57% <0.00%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e0007...f877f25. Read the comment docs.

I stuggle to see the link between my change and the failing tests on MacOS.

Thanks for the PR. The macOS runner seems to be volatile or our tests flaky.
Can you provide a reproducer for the failures you are describing? I'm just wondering why our CI did not catch these problems,

I honestly don't understand either, I checked and this part of the code seem covered by the tests.
I'll try to create a sample project that reproduce it. Meanwhile I can at least describe our setup.
We are integrating glog in our bazel based project, and we build on windows 11 using clang-cl.

Thanks for the details.
@drigz It seems we need a Bazel runner that uses clang-cl in addition to MSVC. Is there a chance you can look into it?

@skeptic-monkey Could you please rebase?

@skeptic-monkey Could you please rebase?

Done.


Fan states

This is associated with my light/fan wall controller.
WARNING (MainThread) [homeassistant.components.fan] Entity None (<class 'custom_components.zimi.fan.ZimiFan'>) does not set FanEntityFeature.TURN_OFF but implements the turn_off method. Please report it to the author of the 'zimi' custom integration
WARNING (MainThread) [homeassistant.components.fan] Entity None (<class 'custom_components.zimi.fan.ZimiFan'>) does not set FanEntityFeature.TURN_ON but implements the turn_on method. Please report it to the author of the 'zimi' custom integration

FIxed in version 1.4.3-dev2


chore: remove build step for adapter node

todos:

[x] check paths work on windows

maybe this addresses #10040, not sure
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

It doesn't work on windows, what a surprise. But only the sverdle page, whyyyyyyyyyy

#10040 could be solved by either reading the files directly from outDir/output/server
Are there any downsides to that?
Alternatively copying them to a folder adjacent to outDir/output/server so that the relative paths stay in the correct location.
But both of those require the adpater to know that the files are in outDir/output/server

Ah, I see you've removed undici in your latest commit. I was going to ask 'Why does the adapter need that directly? Doesn't it get it via @sveltejs/kit/node/polyfills?'
I think this is an exciting change. When we were running into the memory leak issue in undici, I remember there was confusion arising from how only bumping the version in Kit wasn't enough to get the fix out to people, because adapter-node was bundling it. That's reason enough alone to stop bundling this, I think.
I see that adapter-cloudflare and adapter-netlify also have build steps. I'm not entirely sure that adapter-cloudflare's is doing, but it looks like adapter-netlify's build step is also bundling @sveltejs/kit/node/polyfills, so it would be great to also stop bundling that (in another PR).

Also updated it to copy files to an adjacent directory, relative paths in sourcemaps should resolve correctly that way. Which should perhaps fix #10040 , @danieldiekmeier can you link to this PR and check?

@gtm-nayan I linked the latest commit of this PR locally and I can confirm that it no longer creates the .svelte-kit/adapter-node folder, where the source maps get messed up.
The final source maps in build seem to be correctly pointing directly to the original source files. (This is probably great news for @Lms24, because then Sentry can remove their code that follows the source maps with sorcery.)

The final source maps in build seem to be correctly pointing directly to the original source files. (This is probably great news for @Lms24, because then Sentry can remove their code that follows the source maps with sorcery.)

Do you have some additional setup for it? For me the sourcemaps in build still point to the generated files in .svelte-kit, I guess we could use rollup-plugin-sourcemaps to merge them, esbuild does it by default in other adapters.

When is this getting merged? Undici's memory leak is annoying to me

Any chance this could get fixed and remerged? It got reverted and still having problems with source maps not working.

Any chance this could get fixed and remerged? It got reverted and still having problems with source maps not working.

Adding to the noise here since I haven't seen any movement! Source maps are still wonky for sveltekit with adapter-node + sentry and it's making them very hard to use.


Fix Hibernate 6.2

Hibernate moved an interface in their recent CR builds. That leads to a failure with the final 6.2 version. Recompilation with the final version fixes this problem.
@arey Do you mind a release?

Hi Markus. I've done a 6.2.1 release.
We have know to wait it availability into Maven Central: https://search.maven.org/artifact/com.javaetmoi.core/javaetmoi-hibernate6-hydrate

Hi Markus. I've done a 6.2.1 release.
We have know to wait it availability into Maven Central: https://search.maven.org/artifact/com.javaetmoi.core/javaetmoi-hibernate6-hydrate


Project revival

Closes #20.
NOTE: Please don't look at Travis build status now, I haven't finished its integration yet. Appveyor is finished and should show the build as passed.

@gsomix, please take a look.

According to that PR, naggum is written in XML. I knew it! :goat:

@gsomix approved that.


modulenotfounderror: no module named 'pennylane_lightning_gpu.lightning_gpu_qubit_ops'

after installation of the Pennylane lightning GPU from source I got an Error:
modulenotfounderror: no module named 'pennylane_lightning_gpu.lightning_gpu_qubit_ops'
may i know how to solve this issue?

Hi @edwinjosechittilappilly , could you please provide more details by filling the issue template? This could happen, for example, if you performed an editable install with certain versions of pip, but there is no way to know whether that is the issue now.


[SPARK-28983][SQL]Support Or prunning hive partitions

What changes were proposed in this pull request?
Extract more Or predicate to HiveTableScanExec.
Why are the changes needed?
This PR can speed up compute when the predicate can prunning a lot of partitions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add some UT.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Is it a duplicate fo https://github.com/apache/spark/pull/24973?

Hmm...that's duplicate

they don't want to add band-fix type bug fix.


Is it dead?

This project is dead?

It works for me. It did not get any traction, so in marketing driven world it is effectively dead, yes.
It can work for you too, though.


docs: additional steps for getting started without a dev container

This pull request updates the documentation for running the Azure OpenAI API Simulator by adding a new section for non-Dev Container setup and updating instructions to reference this new section.
Documentation updates:

docs/running-deploying.md: Added a new section titled "Non-Dev Container Setup" to provide instructions for setting up the simulator outside of a Dev Container.
docs/running-deploying.md: Replaced inline instructions for non-Dev Container setup with a reference to the new section.

While I acknowledge this adds an additional set of instructions to maintain, I do think it's important to outline these steps for a large group of developers who do not use Dev Containers.

@stuartleeks and team, I am seeing the ci-test workflow is failing. I suspect this is because it's running against a fork and may not have access to necessary secrets. Unfortunately, I have limited visibility to confirm.
Can you take a look?

@liammoat - thanks for the updates!
I'm not sure why those tests are failing - I don't believe any of the tests should require secrets. It's strange not to see more details about the failure in the output 🤔


Fine tune request is being deprecated

Confirm this is a Node library issue and not an underlying OpenAI API issue

[X] This is an issue with the Node library

Describe the bug
Hi, I have been trying to create the fine tune request for the GPT-3.5-turbo. I managed to successfully sent my file and received the id of my file from OpenAI. But when I used that file id to start the fine tune request, it returned an error that stated
"gpt-3.5-turbo can only be fine-tuned on the new fine-tuning API. This API is being deprecated. Please refer to our documentation: https://platform.openai.com/docs/api-reference/fine-tuning"
To Reproduce
Just use the fine tune request that is available on the newest version of the API
Code snippets
public async sendFineTuneRequest(file: Express.Multer.File) {
try {
console.log(file)
let tmpFilePath = path.join(os.tmpdir(), file.originalname)
await fsPromises.writeFile(tmpFilePath, file.buffer)
  let stream = fs.createReadStream(tmpFilePath)
  const sendFile = await this.openAI.files.create({
    file: stream,
    purpose: 'fine-tune',
  })
  await fsPromises.unlink(tmpFilePath)
  console.log(JSON.stringify(sendFile))
  const fineTune = await this.openAI.fineTunes.create({
    training_file: sendFile.id,
    model: 'gpt-3.5-turbo',
  })
  console.log(fineTune, 'fineTune')
  return '123'
} catch (error) {
  Logger.error('fine tune request failed')
  throw error
}

No response
OS
Windows 11
Node version
Node v16.13.1
Library version
openai 4.6.0

As it demonstrates in the linked documentation – https://platform.openai.com/docs/api-reference/fine-tuning/create?lang=node.js – you want to use openai.fineTuning.jobs.create instead of fineTunes.create.
import OpenAI from "openai";

const openai = new OpenAI();

async function main() {
  const fineTune = await openai.fineTuning.jobs.create({
    training_file: "file-abc123"
  });

  console.log(fineTune);
}

main();

But how can I use fineTuning.jobs.create if in the package only offer fineTunes.create?


Ignore invalid certificate common name when checkSsl disabled

Coverage remained the same at 100.0% when pulling e88832ed102af06a9b2444ead2def0c0b6706fe6 on richardjennings:feature/disable-ssl-checks into 20b6bc8b9bb0295f072fe1e11550b0c0ea581c6e on Brunty:feature/disable-ssl-checks.

Coverage remained the same at 100.0% when pulling e88832ed102af06a9b2444ead2def0c0b6706fe6 on richardjennings:feature/disable-ssl-checks into 20b6bc8b9bb0295f072fe1e11550b0c0ea581c6e on Brunty:feature/disable-ssl-checks.

@richardjennings you're ace, thanks for this! 👍


add installs for libtester

Needed to add some libs for libtester to compile correctly with eosio.contracts.

Instead of the changes to wabt submodule, how about disabling the tools like is done here for tests
https://github.com/EOSIO/eos/blob/45e609fe73050d9c648ff44962c3178458e817f0/libraries/CMakeLists.txt#L13-L15


Swedish localization

Contains the same i18n keys as the Slovak localization pull request plus an additional key for the text on the "View SigmaUSD V1" button.

You should add "viewSigmaUSDV1Text" tag also to stablecoin & reserve coin tsx files.
See:

You should add "viewSigmaUSDV1Text" tag also to stablecoin & reserve coin tsx files.
See: 0a718a7

Done :)

fixes https://github.com/anon-real/sigma-usd/issues/26


Remove leading 'x' from repository name

The leading 'x' is kind of arbitrary. Especially now that we can set
topics on the repositories, we don't need a pattern to distinguish what
is a track or not.
The repository itself has already been renamed. GitHub redirects from
the old name to the new name, so we do not have to rush to fix links to
the old repository name, though we should update them for the sake of
clarity.
See exercism/meta#1

Again, travis hasn't even started to check after nearly 5 hours now, since the massive back-log created by doing all those PRs all together and exercism as an organisation isn't allowed to run more than about 5 concurrently.
Can we agree upon tagging such trivial and automated changes as no-ci? Or at least ask travis to add a per organisation status page which shows how many jobs are currently running, and how many are waiting. Bonus-Kudos when they make the actual queue and expected order of runs visible...

@NobbZ I didn't know it was possible to skip a build, but found the documentation for it: https://docs.travis-ci.com/user/customizing-the-build#Skipping-a-build
In the future I will skip the build for trivial changes.

Hmpf. Bad news... [skip ci] doesn't play well with required status checks.
After having that set for about the last three months, I think it doesn't add any value. There is currently not enough contribution or traffic to exercism/erlang. Can you unrequire travis?

@NobbZ I've turned off the status check requirement in the repo settings.

Thank you!


parsing error for string expression on RHS of ensemble aggregation

Reported by andrew wittenberg on 7 Mar 2016 21:11 UTC
There's a parsing bug when defining aggregations:
 	NOAA/PMEL TMAP
 	FERRET v6.97 (beta/opt)
 	Linux 2.6.32-573.18.1.el6.x86_64 64-bit - 03/04/16
 	 7-Mar-16 16:03

yes? use coads_climatology
yes? save/file=ens1.nc sst
yes? save/file=ens2.nc sst
yes? let members = {"1","2"}
yes? ensemble "ens"+members
 **TMAP ERR: non-existent or not on line
             Searched $FER_DESCR and $FER_DATA for "ens"+members(.nc ,.cdf,.des)

Ferret doesn't recognize that the right-hand side is a string expression.  But note that the following works:
yes? ensemble "ens"+{"1","2"}

Alternatively we can define an intermediate string variable to hold the results of the string concatenation, and then use that in the ENSEMBLE command.
Still, it'd be nice to have ENSEMBLE recognize arbitrary string expressions on the right-hand side.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/2378

Comment by steven.c.hankin on 7 Mar 2016 23:08 UTC
A quick experiment revealed that another work-around is to present the quoted string as a string array of length one:
yes? ensemble {"ens"}+members

This is for sure a misbehavior, but in view of the competing priorities I am downgrading the priority of this ticket.  Ansley, lets both try to remember this ticket next time we are in that section of code.

Comment by andrew.wittenberg on 8 Mar 2016 17:36 UTC
Excellent workaround!  Downgrading the priority...


Theme mode switching is infinite when four tabs of mui opened

Steps to reproduce
Steps:

There is no link because it is exist on mui.com documentation pages. But I will provide simple steps to reproduce.
PLEASE, BE CAREFUL. This behavior could negatively impact individuals who are sensitive to rapid changes in screen brightness, such as those with photosensitivity or other visual sensitivities. So don't try to reproduce it if you have high sensitivity for that.
At first open Dark mode documentation page https://mui.com/material-ui/customization/dark-mode/#toggling-color-mode
Then open these 4 tabs in the same browser.

https://mui.com/material-ui/customization/css-theme-variables/configuration/
https://mui.com/material-ui/react-drawer/
https://mui.com/material-ui/react-app-bar/#app-bar-with-responsive-menu
https://mui.com/material-ui/customization/breakpoints/

On Dark mode page start quickly change light mode to dark and vise versa
https://mui.com/material-ui/customization/dark-mode/#toggling-color-mode
Then stop clicking and see how modes switches by their own without any additional interaction.
To stop those infinite mode changing, just close all tabs and leave one of them.

Current behavior
When more than 4 tabs opened, frequent theme mode changing starts infinite mode changing between all tabs.
Expected behavior
When user change theme modes, mode is changes only once user clicked.
Context
This is crucial to take a look, because such behavior may impact on people feeling which have problems while look at frequently changing screens from dark to light.
I think this is because the tabs synchronize data about the active mode of the theme. Because after closing the tabs, the problem disappears. Apparently, the tabs react to changes from other tabs asynchronously and at the same time send these changes to other tabs. And because of this event, the changes run back and forth
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: theme, mode, flickering, infinite

Thanks for the recording and nice to meet you as well @frontend-sensei 😊
I'll mark this as an enhancement for the website.
If you (or anyone else stumbling here) are having similar issues with this in their apps, I would recommend throttling the theme switching to alleviate the issue.


Remove Supercharged Rewards

Added in  a new file one.mhl which defines the supercharged_coinbase_factor constant as 1. All other configurations files that referenced the old constant of 2 (in two.mhl) were updated to reference the new one.

Closes #12578

!ci-build-me

!ci-build-me

delete src/config/supercharged_coinbase_factor/two.mlh if it is not used anywhere?

!ci-build-me


Add describe control to all k8s resources

This PR will add a new control i.e. Describe
which will describe a k8s resource similar to kubectl describe.
fixes: #1143
Signed-off-by: Akash Srivastava<EMAIL_ADDRESS>

@qiell Did you encounter any blockers trying to address review comments? I think the PR is very close to being ready to merge, I'd be happy to help wrap things up if needed :)

Hi, @fbarl Thanks for your concern. I had one issue but @bboreham helped me to tackle that. I couldn't find time to catch up on this. Will try to put that change ASAP. If I face any blockers or issue, I'll let you know.
Thank you :)


SPARKC-231: Create C* Schema from DataFrame

+1

Build against Scala 2.11 finished with success

Build against Scala 2.10 finished with success

Do you have a timeframe as to when this will make it into one of the Maven version releases?


There are defined data structures for annotation parsing in M1

For the M1 push to file feature the Secrets provider will use Kubernetes annotations to
list the secrets that will be retrieved from Conjur.
When configured for push to file, the annotations will need to be parsed and the results
saved to a a data structure.
Requirements
When the Secrets Provider container starts up, it will need to parse the annotations file.
The Secrets Provider will need to parse all Pod annotations, and compile an array of per-group secrets mapping information.
Each annotation key will be parsed and split into three fields:

Annotation type (e.g. conjur-secrets, conjur-secrets-policy-path, etc)
Secrets group
Annotation value. The annotation value is a string that can be any of the following formats:

Plain string
YAML list of secrets
Secrets file Golang template

The parsed annotations need to be saved in a data structure as outlined below from the spec.
// SecretsPaths comprises Conjur variable paths for all secrets in a secrets group, indexed by secret name.
type SecretsPaths map[string]string

// GroupSecretsInfo comprises secrets mapping information for a given secrets group.
type GroupSecretsInfo struct {
    Secrets SecretsPaths
    SecretsPathPrefix string
    FilePath string
    FileFormat int
    Template string
}

// GroupSecrets comprises secrets mapping info for all secrets groups
var GroupSecrets map[string]GroupSecretsInfo{}

Acceptance Criteria

[ ] The data structures exist for parsing the annotations.

This is a design / spike story to come up with a starting point for a data structure to work with when parsing annotations.


Compatibility with vue-loader 13.x

I'm importing vue-quill-editor like this:
import Quill from 'quill'
import quillEditor from 'vue-quill-editor'
import ImageResize from 'quill-image-resize-module'

Quill.register('modules/imageResize', ImageResize)

export default {
  components: {
    QuillEditor: quillEditor
  }
}

But this results in the following error when using vue-loader 13.x:
[Vue warn]: Failed to mount component: template or render function not defined.

See https://github.com/vuejs/vue-loader/releases/tag/v13.0.0 for the breaking change
Is there a correct import syntax for this? I can't figure it out

v2.2.4 fix it.


Quarto + Julia

Love your book!
Without wanting to commit to anything yet, would you entertain a PR which used quarto to add Julia snippets as tabs for those who don’t use R? Maybe someone would come along and throw in Python as well.
https://quarto.org/docs/interactive/layout.html#tabset-panel

I understand the idea, but it's difficult, because I could not evaluate whether the code works. I've seen people create resources 'translating' a text to different languages, but not having all languages in one online book. There might be good solutions, but, I Am not sure what they would look like, and having multiple blocks of code in different languages is a lot of scrolling.


For loading Saved Network Games, should default to Sort by Date

For loading Saved Network Games, should default to Sort by Date.
They are presented in a random order.
When the Game Scenarios are introduced, the game will be given a Name, and then be able to Sort by Name, or by Date.

Extracted out Network Saved Games Panel to a new class.
Added Sort Routing to sort by the Game ID, with most Recent Game at the top.
Consider adding Sort of Game Name, provided Game Name, sorting in Reverse Order. Have a Header Row to be able to click on columns for sorting choice.


Location block not rewriting - Custom config

Having trouble executing a rewrite from the location block in my custom config. When I try to hit the route, I receive a blank page and a 304.
I've checked /etc/nginx/conf.d to confirm that the copy of the custom config file to the container was successful. Would greatly appreciate any guidance! Thanks in advance!
Custom image
FROM jwilder/nginx-proxy

COPY ./my-proxy.conf /etc/nginx/conf.d/my-proxy.conf

docker-compose.yml
version: '2'

services:
  service:
    build: app-service
    environment:
      - VIRTUAL_HOST=my-domain.com
  nginx-proxy:
    build: custom-nginx-proxy
    container_name: nginx-proxy
    ports:
      - 80:80
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro

my-proxy.conf
server {
  location /test {
    proxy_pass http://<IP_ADDRESS>4/;
  }
}

Don't know how I missed this! Works now.
https://github.com/jwilder/nginx-proxy#per-virtual_host-location-configuration


Unrestricted Workspace - Fix missing WORKDIR prior to mirroring.

What is being addressed
Fixes issue with build of unrestricted workspace, as working directory is incorrect.

needs placeholder providers.tf  in terraform folder @marrobi

terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "=3.19.1"
    }
    azuread = {
      source  = "hashicorp/azuread"
      version = "=2.20.0"
    }
    null = {
      source  = "hashicorp/null"
      version = "~>3.1.0"
    }
  }

  backend "azurerm" {}
}

provider "azurerm" {
  features {
    key_vault {
      # Don't purge on destroy (this would fail due to purge protection being enabled on keyvault)
      purge_soft_delete_on_destroy               = false
      purge_soft_deleted_secrets_on_destroy      = false
      purge_soft_deleted_certificates_on_destroy = false
      purge_soft_deleted_keys_on_destroy         = false
      # When recreating an environment, recover any previously soft deleted secrets - set to true by default
      recover_soft_deleted_key_vaults   = true
      recover_soft_deleted_secrets      = true
      recover_soft_deleted_certificates = true
      recover_soft_deleted_keys         = true
    }
  }
}

/test-force-approve


Add examples for custom format and logger impls

I think it would be good for use to build up a set of complete cargo examples. Here I've added two:

Creating a custom logger (maybe we should make this one write to an in-memory Vec<String> or something?)
Setting a custom format

These seem like good ones to start with because they use some new APIs we've introduced. We can use them to drive any changes we want to make to those APIs to make them a bit more ergonomic.

r? @jimmycaudra

r? @jimmycuadra

Nice additions!


Correct git URL

Fixes a warning with URL parsing on Node 20:
(node:43920) [DEP0170] DeprecationWarning: The URL https://github.com:crypto-browserify/browserify-rsa.git is invalid. Future versions of Node.js will throw an error.

@ljharb is this something you could perhaps help with reviewing/merging/releasing? :-)

Many thanks @ljharb ! 🙏

np, thanks for the ping.


Save and New

Describe the feature you'd like
After completing a page, add an option to save and create a new page.
Describe the benefits this would bring to existing BookStack users
Would streamline my workflow (often converting PDFs to Bookstack Books)
Can the goal of this request already be achieved via other means?
Yes. I can click save, navigate  back to the chapter I'm working on pages for, and click New Page.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
3 months to 1 year
Additional context
No response

Thanks for the request @roleforgaming, but I'm going to close this off as I feel it's already covered by existing issue #3382


Rich editor alpine component not recognising uploaded attachments

Package
filament/filament
Package Version
v2.17
Laravel Version
v10.10
Livewire Version
v2.12
PHP Version
PHP 8.2
Problem description
After uploading an image with RichEditor, the alpine component doesn't register the html tag.
The image successfully uploads to S3 (albeit in a livewire-tmp/ directory), but the image is immediately lost upon saving because there is no html markup for it.
HTML is returned as null on the upload response, is this the issue?

Expected behavior
The image should generate some html inside the content of the RichEditor and publish along with the post.
Steps to reproduce

Set Laravel filesystem to S3, make sure buckets are all configured correctly with proper permissions and cors settings.
Create a filament resource with RichEditor component.
Attach / upload an image
Double check the image uploaded successfully in the AWS console
Save resource and refresh page - image doesn't exist

Reproduction repository
https://github.com/P-James/filament-reproduction
Relevant log output
No response

Can you please check if this is an issue in v3 or not?

I can shed some more light here.
This is still an issue in V3, but only when fileAttachmentsVisibility is set to public.
If the visibility is set to private as in the Doc, it works fine. However the image link is invalid after 5 min, due to the signed URL only has 5 min lifetime.

Downloaded the reproduction repo, updated to v3 and set up S3:
https://github.com/filamentphp/filament/assets/41773797/7b231012-34ad-42b1-8ae3-080f49eb799b


Remote App Source

Is the Android remote app open source? That would be awesome for community contributions and what not.

Yep you can find it over at https://github.com/GPMDP/google-play-music-desktop-remote


affected/package: go build gives an irrelevant error message during type conversion

What version of Go are you using (go version)?

$ go version
go version go1.18 darwin/arm64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
> go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/nevzatseferoglu/Library/Caches/go-build"
GOENV="/Users/nevzatseferoglu/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/nevzatseferoglu/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/nevzatseferoglu/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go/1.18/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go/1.18/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/nevzatseferoglu/go/src/github.com/nevzatseferoglu/awesome-go/serialization/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/h2/gfghbx6s2491g70qcjq4z80h0000gn/T/go-build2098482607=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I was trying to get the maximum value of  uint based on the discussion in one of the official blog post. The post says that trying to get the maximum value of uint with exploiting variable should work fine at run time. Because, it also says that converting negative variable to an uint should not be an erroneous case.
https://go.dev/play/p/QEGIuUWM5X2
package main

func main() {
	var u uint
	var v = -1
	u = uint(v)
}

What did you expect to see?
I expected to see the result as described in blog post. If I try to use a negative variable to reach uint max value, it should not give me an error(based on blog post). But it produce an irrelevant error message at compile time 👇🏼
What did you see instead?
./prog.go:4:6: u declared but not used

Go build failed.

The error message is correct.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

The error message is correct.
Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

Where can I open an issue about blog post ?
If receiving error is the correct behaviour, that means blog post is not updated and misleading.

the blog post is also correct, it only shows the relevant snippet, not a full example

How can other part of the example affect the result of;
var u uint
var v = -1
u = uint(v)

It seems that the given code snipped is clear enough to estimate the result without where it is located. In addition, I could not find the full source code of the blog posts. I guess there is no certain repository that keeps the codes of the published blog posts.

The error you are seeing is "u declared but not used".  To avoid that error add a use of u, perhaps something like
    fmt.Println(u)

The error you are seeing is "u declared but not used". To avoid that error add a use of u, perhaps something like
    fmt.Println(u)

I just pressed the run button on related part of the post and could not see the error. It seems it misled me in somehow. I should have guess there should be remaining part in some way. Sorry for this shame! 😿


Fix issue when trying to delete actor from scene

When trying to call the remove_actor function on a created actor, I obtained the following error :
TypeError: remove_entity(): incompatible function arguments. The following argument types are supported:
    1. (self: sapien.pysapien.Scene, entity: sapien.pysapien.Entity) -> None

Invoked with: <sapien.wrapper.scene.Scene object at 0x777ea016f4d0>, <distractor_0: struct of type <class 'mani_skill.utils.structs.actor.Actor'>; managing 1 <class 'sapien.pysapien.Entity'> objects>

I adapted the code in order to get all entities related to the actor in order to delete them, as it was already done for the articulations.

Thank you for your contribution. Just want to point out that you cannot actually delete an actor from the scene in the GPU sim so be careful about using this function. Curious, what is the intended goal of removing an actor in your use case?

Thank you for your contribution. Just want to point out that you cannot actually delete an actor from the scene in the GPU sim so be careful about using this function. Curious, what is the intended goal of removing an actor in your use case?

Hello, the use case is in fact related to the following issue : https://github.com/haosulab/ManiSkill/issues/419#issuecomment-2226677176 ; I wanted to find a way to randomize the color of objects at the reset of an episode but could'nt found a way to do it properly. I then found a way to remove the objects and just create them as new random shapes.

@StoneT2000
Excuse me for my bad formatting, this is my first contribution on an open-source project, I will try to be more vigilent next time.
I've indeed forgot a point in the code, it should be fixed now with the new commit (for the formatting and the wrong var name)


Docs are not generated for exported assignments/vars

A cell like:
#| export
x = 1

or
#| export
x = 1
x

Does not result in a doc entry. Is this expected?
Example: https://github.com/dleen/notebook-examples/blob/main/01_var.ipynb

Removing #| export allows it to appear in the docs.
I tried adding #| echo: true and other quarto directives but it doesn't seem to work with export.

Does #| exports work for this? (s for "source")

Ah that worked nicely! Hmm is there somewhere that I can find all of the directives? I searched here and found nothing: https://nbdev.fast.ai/export.html

I don't think there's a complete reference yet @dleen. Off the top of my head (@hamelsmu @jph00 please double-check):

default_exp mod – export to mod by default
export – show in docs using show_doc; include in module; add to __all__; executes in tests
exports (for source) – like export but shows source code in docs instead of show_doc
exporti (for internal) – like export, but doesn't show at all in docs and excludes from __all__
no directive – shows in docs as is; executes in tests, or in docs only if it contains import or from * import (this is also why it's not a good idea to mix imports with code in non-exported cells)
hide – doesn't show at all; executes same as no directive.

I think these are the main nbdev ones. Quarto has its own set too.
@hamelsmu, you were planning on working on some explanatory docs right? I think some variation of above could go a long way.

Oh there are lots more directives than that!  I have to collect a list of all of these , it is definitely on the todo list :) Give me a couple of weeks!

@dleen I'll go ahead and open an issue and assign it to you.  Let me know if you need any help, happy to review it!


Removed ReachabilityStatus from sync, network and fixed test cases.

Description
removed ReachabilityStatus.
Related issue(s)
If this Pull Request is related to an issue, mention it here.

removed ReachabilityStatus from sync, network and test cases.

@nagarajmanjunath please fix the linting issues. Read here: https://github.com/pactus-project/pactus/blob/main/CONTRIBUTING.md


ci: Skip tests at deploy step

:tada: This PR is included in version 1.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for PKCS#12 data

When we have an interop target (browser that supports necessary bits of WebCrypto) we should also add support for creating and importing PKCS #12 files.

Added, unfortunatley:

PKCS12 uses PBES1 which is not supported in WebCrypto
Windows uses 3DES and RC2 which are not supported in WebCrypto

With that said you can verify the files produced with PKIjs (which use AES-CBC and PBES2) with OpenSSL using this command:


A tool to create previews/Thumbnails for other file types

Description of the new feature / enhancement
A tool to create previews/Thumbnails for other file types.
To this day and to the best of my knowledge there is still e.g. no preview/thumbnail for Microsoft Publisher.
This is also true for many other file formats.
Scenario when this would be used?
To see a "preview" of the contents of files in file explorer instead of having to open them until the right one is found!
Supporting information
No response

This is up to the application at end of day.  Some file formats we can do like Markdown or SVG but this is too large / vague of an ask.  Markdown / SVG / PDF are also non-'owned' file formats typically.
MSFT Publisher, i doubt PowerToys would do that file type.  Publisher would own their own previewer / thumbnail


Error Management

When the Cisco Spark API returns an error such as a 409, I am having difficulties handling it from my client application code.
Sparky returns an err containing only a message, which gives no other option but to do string comparison, or creating a regexp to matching a 409 status error.

Here is an example of strategy to handle the error with current version of sparky:
sparky.membershipAdd(roomId, personEmail, false)
.then(function (membership) {
   ...
})
.catch(function (err) {
   var hasHttpStatusCode = err.message.match(/recieved error (\d{3}) for a POST request/);
   if (hasHttpStatusCode && (hasHttpStatusCode[1] == "409")) {
      // user is already in space
   }
}

It seems that sparky may encounter 3 main types of issues while requesting Cisco Spark APIs:

HTTP request establishment: timeout, ...
HTTP response format issues: unexpected payload
HTTP responses with a non 2xx status code: something went wrong 4xx or 5xx series

A possible design could be to add extra info to the Error object:

err.type = ERR_REQUEST, ERR_RESPONSE or ERR_STATUS
and in case of ERR_STATUS, we would also add a err.statusCode with the value returned by CiscoSpark.

This should be the function that is needed to modify the scope of the returned error object as per your suggestions above.
Something like:
const processError = (_res, _opts) => {
  const err = new Error(`recieved error ${_res.statusCode} for a ${_opts.method.toUpperCase()} request to ${_opts.url}`);
  // attach statusCode to error
  err.code = _res.statusCode;
  if (parseInt(_res.statusCode, 10) === 409) {
    err.type = 'ERR_REQUEST';
  } else if (parseInt(_res.statusCode, 10) === 123)
   err.type = 'ERR_BLAH';
  // other conditions...
  } else {
   err.type = 'ERR_STATUS';
  }
  console.error(err);
  return when.reject(err);
};

Feel free to do a PR or let me know know thoughts on above and which statusCodes you think should map to what types and I can make this change this weekend.

Addressed in v.4.2.0


Run Jupyter failed with Error: Command failed:

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

when run a juypter notebook in vs code, there occures command failed error.
When I run a general python file in vs code, everything goes well, but when I create a .ipynb file and try to run print('hello world')  I got the error below.  I have tried several conda enviroments, the result is the same.  I am not sure wheather this is caused by the chinese character in the  extentsions path.
And there are garbled characters in the error message, I don’t know what happened.

The error message is below:
Error: Activating Python 3.7.5 64-bit ('torch': conda) to run Jupyter failed with Error: Command failed: D:/software/anaconda/Scripts/activate && conda activate torch && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python c:/Users/木子-勇士心/.vscode/extensions/ms-python.python-2019.11.50794/pythonFiles/printEnvVariables.py
ϵͳ�Ҳ���ָ����·����
ϵͳ�Ҳ���ָ����·����
ϵͳ�Ҳ���ָ����·����
ϵͳ�Ҳ���ָ����·����
Expected behavior
hello world

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running:                       Local
Extension version:                               2019.11.50794
VS Code version:                                1.40.2
Setting python.jediEnabled:               true
Python and/or Anaconda version:     3.7
OS:                                                     Windows
Virtual environment:                          conda

Developer Tools Console Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

I believe this should be fixed once we ship the fix for this issue:
https://github.com/microsoft/vscode-python/issues/7696

Actually I think this is related to the unicode issue here, not to the general conda issues.
https://github.com/microsoft/vscode-python/issues/8150

Will be resolved by #8928.