BUG: Compatibility with Expo 50

Expected behavior
We're currently using Daily with Expo SDK 49 in a React Native app. When upgrading to Expo SDK 50, I am seeing a red screen / error which appears to be due to an outdated react-native-webrtc dependency.
The goal of this issue is to track any blockers preventing React Native apps that use Daily from upgrading their Expo dependency to version 50.

[ ] Upgrade<EMAIL_ADDRESS>to use version 118.0.1 of react-native-webrtc.

Describe the bug (unexpected behavior)
When a <DailyMediaView /> is rendered, the React Native app throws up a red screen / error:

...with the following logged to the console:
TypeError: undefined is not a function, js engine: hermes

This seems to point to an issue with WebRTC. After some digging, I found a potential dependency mismatch with the @config-plugins/react-native-webrtc config plugin which is used to configure react-native-webrtc in Expo projects.
According to https://www.npmjs.com/package/@config-plugins/react-native-webrtc, Expo SDK 50 requires<EMAIL_ADDRESS>which itself requires<EMAIL_ADDRESS>In the case of @daily-co/react-native-daily-js, it has a dependency on<EMAIL_ADDRESS>which is a fork of<EMAIL_ADDRESS>In short, it looks like the fork needs to be updated to be based off a newer version of the react-native-webrtc package.

Steps to reproduce

Create an Expo app using v50 of the SDK: npx create-expo-app SampleApp
Install Daily for React Native
Try to use <DailyMediaView />

Screenshots

See above.
System information

Device: iPhone Simulator
OS, version: iOS SDK 17.2

Additional context

Thank you for reporting this @hramos.
We have a task in our backlog to integrate the latest changes from react-native-webrtc into our fork. This may require some modifications to our configuration plugin as well.
I will let you know as soon as we introduce these updates.

Thank you @filipi87 - I've built a project on Expo 50 and just ran into this today, patiently waiting on a fix :) . In the meantime is the recommended solution to revert back to Expo version 49?

Any clear timeline on this?

Hi, @nsjames; this is still something we're working on. The recommendation is not to upgrade Expo in the meantime.

Our team has built our app using Expo 50 and Expo Router v3 features, so downgrading to Expo 49 is not a viable option for us and is likely not an option for others, either. This does currently block us from progressing. In the meantime we are sending mobile users to the hosted Daily room, but we really need native functionality since our service centers around video calls

Hi, @nsjames; this is still something we're working on. The recommendation is not to upgrade Expo in the meantime.

In my case, I didn't upgrade. Expo projects start at 50 from quickstart now.
I downgraded to 49, but it took a lot of massaging as I was also using the v3 router heavily.

Hi, I have already an open PR to integrate the latest changes from react-native-webrtc into our fork.
Once that is merged, we should be able to add support for Expo 50 in our next react-native-daily-js release.

The PR with the webrtc changes has already been merged, and we already have PRs up for both:

Change our config plugin to support Expo 50: https://github.com/daily-co/rn-daily-js-expo-config-plugin/pull/8
Bumping the versions from our demo to use Expo 50: https://github.com/daily-demos/daily-expo-demo/pull/6

They are just waiting for react-native-daily-js, 0.59.0, which we should publish probably later this week or early next week.

We are now supporting Expo 50.
You will need to use the latest version of our @daily-co/config-plugin-rn-daily-js 0.0.4, and the required dependencies. More details here.
You can also check this https://github.com/daily-demos/daily-expo-demo/pull/6, where we changed our demo app to use Expo 50.


Bad payload received by generic incoming webhook

Hi, about a week ago I discovered that my previously working teams notifications are not being received anymore, and upon investigation I found that version 2.0.1 seems to be affected by the following error:
      aborted: false,
      timeoutCb: null,
      upgradeOrConnect: false,
      parser: null,
      maxHeadersCount: null,
      reusedSocket: false,
      host: 'aib5.webhook.office.com',
      protocol: 'https:',
      [Symbol(kCapture)]: false,
      [Symbol(kBytesWritten)]: 0,
      [Symbol(kEndCalled)]: true,
      [Symbol(kNeedDrain)]: false,
      [Symbol(corked)]: 0,
      [Symbol(kOutHeaders)]: [Object: null prototype] {
        accept: [ 'Accept', 'application/json, text/plain, */*' ],
        'content-type': [ 'Content-Type', 'application/x-www-form-urlencoded' ],
        'user-agent': [ 'User-Agent', 'axios/0.21.4' ],
        'content-length': [ 'Content-Length', 608 ],
        host: [ 'Host', 'aib5.webhook.office.com' ]
      },
      [Symbol(kUniqueHeaders)]: null
    },
    data: 'Bad payload received by generic incoming webhook.'
  },
  isAxiosError: true,
  toJSON: [Function: toJSON]

when using the simple example as below:
async function sendTeamsNotification(payload) {
    const url = process.env.MS_TEAMS_WEBHOOK_URL
    const webhook = new IncomingWebhook(url)

    await webhook.send(JSON.stringify(payload))
}

The payload is a simple MS Teams Card which was validated via https://messagecardplayground.azurewebsites.net/
The same request works via cURL:
curl -H 'Content-Type: application/json' -d 'PAYLOAD' WEBHOOK
From the error above, notice the following:
'content-type': [ 'Content-Type', 'application/x-www-form-urlencoded' ],
I was able to replicate the error via curl by changing the content-type from json to urlencoded.
Judging by this, we need to be able to specify content-type or to figure out why it is sent as urlencoded

Hi Matt,
you are right, if you stringify the JSON object you will get the wrong content type error. But adding a content header doesn't fix the problem. Is there any particular reason why you need to stringify the JSON object? In version 2.0.x, you can use the JSON object directly.
This example for me:
const { IncomingWebhook } = require("ms-teams-webhook");

async function sendTeamsNotification(payload) {
  const url = process.env.MS_TEAMS_WEBHOOK_URL;
  const webhook = new IncomingWebhook(url);
  await webhook.send(payload);
}

sendTeamsNotification({
  "@type": "MessageCard",
  "@context": "https://schema.org/extensions",
  summary: "Issue 176715375",
  themeColor: "0078D7",
  title: 'Issue opened: "Push notifications not working"',
  sections: [
    {
      activityTitle: "Miguel Garcie",
      activitySubtitle: "9/13/2016, 11:46am",
      activityImage:
        "https://connectorsdemo.azurewebsites.net/images/MSC12_Oscar_002.jpg",
      text: "There is a problem with Push notifications, they don't seem to be picked up by the connector.",
    },
  ],
});

In typescript we have also prohibited the string input. Does that help you?

I have released version 2.0.3 which validates the input and throws an error if it is a string.

Wow, that was quick! Thank you @waigel! I remember I added the stringify as it was required in previous versions, but I hereby confirm that the payload can be used directly with version 2.0.1


fix handling of cell IDs with backslashes in sby junit interaction

Backslashes are not allowed in smt2 format, so the smt2 backend translates them to forward slashes. This prevents sby from finding the corresponding cell in the json export.
Since sby interprets a hot comment in the smt2 file, where backslashes aren't actually an issue, print the unmodified cell name in the comment.

Handling this in sby instead so that the smt2 file stays internally consistent. https://github.com/YosysHQ/sby/pull/142


Blaze symbol fetching the wrong fields

Suppose I have this
from blaze import Data, compute, symbol
from odo import odo
import pandas

df = Data('postgresql://jeffrey04:abc123@localhost:5432/meow::woof',
          dshape="""
                 var * {a: int64,
                        b: string,
                        c: string,
                        d: string,
                        e: string,
                        f: string,
                        g: string,
                        h: string,
                        i: string,
                        j: string,
                        k: string,
                        l: string,
                        m: string,
                        n: string,
                        o: string,
                        p: string}
                 """,
          name=meow)

So I was trying to get all the k where none of them contain an empty string
want_this = odo(df[df.k != ''].k, pandas.Series)

but then when I inspect the data, I don't get k, but j instead, so I checked the sql issued by blaze by doing this
print(compute(want_this))

yields
SELECT meow.j
FROM meow
WHERE meow.state != %(k_1)s

which clearly not what I was expecting.
I also did this
res = resource('postgresql://jeffrey04:abc123@localhost:5432/meow::woof')
sym = symbol('s',
             """
             var * {a: int64,
                    b: string,
                    c: string,
                    d: string,
                    e: string,
                    f: string,
                    g: string,
                    h: string,
                    i: string,
                    j: string,
                    k: string,
                    l: string,
                    m: string,
                    n: string,
                    o: string,
                    p: string}
                    """)
odo(compute(sym[sym.k != ''].k, res), pandas.Series)

also returned the same output (getting j instead of k)

Finally managed to reproduce this with this script
from blaze import Data, compute, resource, symbol
from odo import odo
import pandas
from random import randint, choice
import string
import sys

def random_word_list():
    return [''.join([choice(string.ascii_lowercase) for _ in range(randint(0, 5))]) for _ in range(100)]

def random_int_list():
    return [randint(0, 1000) for _ in range(100)]

def foo(data):
    print(compute(data[data.k != ''].k))

dsn_a = 'postgresql://jeffrey04:abc123@localhost:5432/wrong-field::foo'
dsn_b = 'postgresql://jeffrey04:abc123@localhost:5432/wrong-field::bar'

dshape = """
         var * {a: int64,
                b: string,
                c: string,
                d: string,
                e: string,
                f: string,
                g: string,
                h: string,
                i: string,
                j: string,
                l: string,
                m: string,
                n: string,
                o: string,
                p: string,
                k: string}
         """
fields = ('a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'l', 'm', 'n', 'p', 'k', 'o')

df = pandas.DataFrame(list(zip(random_int_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list(),
                               random_word_list())),
                      columns=fields)

print('This is wrong')
odo(df, dsn_a)

_foo = lambda : foo(Data(dsn_a, fields=fields, dshape=dshape, name="meow"))
_foo()

print('This is right')
_data = Data(df, dshape=dshape, fields=fields, name="meow")
odo(_data, dsn_b)

_bar = lambda : foo(Data(dsn_b, fields=fields, dshape=dshape, name="meow"))
_bar()

steps to reproduce
jeffrey04@gideon:~/machine-learning⟫ python3 wrong-field.py
This is wrong
SELECT foo.o
FROM foo
WHERE foo.k != %(k_1)s
This is right
SELECT bar.k
FROM bar
WHERE bar.k != %(k_1)s

It's important to note that the order of fields is different
In the datashape the last three fields are o, p, k and in the dataframe they are specified as p, k, o

@Jeffrey04 Since you're providing both fields and dshape how would you expect this to behave if the fields don't match the dshape? I would want this to raise an error.

so fields and dshape should follow the same order?
what about the order of columns in the dataframe? Do I need to ensure they follow the same order as well? (that's something I don't really have control though)

The columns in the dataframe above are in the ordered like fields which is passed in. You have DataFrame(... columns=fields)

@cowlicks i meant if my set up is unlike the fictional test script above, where the columns of a data frame do not necessarily come in the same order as fields and dshape passed to Data(), would it break also?


Use chrono

Use chrono to deserialise everything related to date and timestamp

How is it not maintained? I can’t find anything about it?
And since MeiliSearch already use it, if there is any problem with chrono it’s going to crash MeiliSearch before it crashes the sdk no?

Look at their inactive github repo. Nobody answers issues and nobody fixes them. Dependencies are critically outdated. A vulnerability was found in chrono a few months ago and extreme fear began to spread in the rust community. I'm not even sure it's fixed now. I really hope this problem is solved soon but as of today, I don't think one should use chrono.

Hey @Mubelotix, I was scrolling on the chrono issues, and I’ve seen most people are moving to time; what do you think of this one?
From what I see, it should be enough for us, and chrono was actually depending on it.

Hey @Mubelotix, I was scrolling on the chrono issues, and I’ve seen most people are moving to time; what do you think of this one? From what I see, it should be enough for us, and chrono was actually depending on it.

Hi @irevoire, sorry for the late reply; notification got lost. That's exactly what I was going to suggest after reading this thread

Well now it’s done 👍


Doesn't open file when started trough "open with"

When started from the terminal like this: "/path/LightTable " it works fine.
But when it is registered as an launcher with this: "Exec=/path/LightTable %f" and a file is opened trough the right-click context menu it just loads up LightTable. It doesn't load the file.

All this functionality has been reworked with the move to electron. Closing but feel free to ping us if this is still an issue with the latest


Audit existing error handling + add more

This is a catchall issue to track places that we need additional error handling. There are several places in our app where errors are swallowed and we receive the generic "Oops, an error occurred page":

As you come across these, feel free to add them here (with a link to the relevant code if you have it). If you work on an area listed here, please cross it off or remove it from the list.
Error handling needed:

[ ] Email send errors (eg. rate limiting): https://github.com/civiform/civiform/blob/main/server/app/services/applicant/ApplicantService.java#L589

we're not using this issue so i'm going to close it to make room for new issues to be created.


DateTime.Kind no longer honored in SignalR RPC

I upgraded to v1.0.0-rc1-final and I am seeing new behavior.
From the server, I call a method on the client. The parameter object is of type DateTime. The DateTime object has the Kind property set to Utc. When it gets to the client method, the DateTime object has a Kind property of Local.
In previous versions of SignalR it would keep the Kind as Utc across RPCs.
Is this expected now? Do i really have to do a UTC conversion in all SignalR RPCs even if it was originally sent at UTC?
I believe this is an issue that should be changed back to how it previously worked.

I upgraded to v1.0.0-rc1-final and I am seeing new behavior.

I'm trying to unpack this statement. Maybe the next step is to send us a repro project showing exactly how you configured the application.

Take a test SignalR server/client. Add this to the client:
            _hub.On("testDateTimeUTC", new Type[] { typeof(DateTime) }, (o) =>
            {
                System.Diagnostics.Debug.Assert(((DateTime)o[0]).Kind == DateTimeKind.Utc);
                return Task.CompletedTask;
            });

Then in the server, call this:
await proxy.SendAsync("testDateTimeUTC", DateTime.UtcNow);
The assertion will be hit.

            _hub = new HubConnectionBuilder()
                .WithUrl(_envSettings.CreatePlayerServiceHubPath(), (x) =>
                {
                    x.Headers.Add("RegistrationKey", regCode);
                    x.Headers.Add("DeviceName", deviceName);
                    x.Headers.Add("TimeZoneOffset", Services.TimeService.TimeZoneOffset.ToString());
                })
                .Build();

There are some properties I am adding in that are pertinent to the client connection as header objects. Just string objects. For example regCode is a typical registration code "12345-12345-12345", deviceName is a simple name like "ABCDEFG-12345", and timezone offset looks like "-5:00"

@JamesNK any ideas?

Hmmm, I think parameters are still going through the serializer. I'm not sure what else could have changed to cause this off the top of my head.

Are you guys seeing this? Did you try it? Or is it just me?

I can reproduce it.

@JamesNK has a bad memory 😉. We made this change intentionally to solve this problem https://github.com/aspnet/SignalR/issues/1346. Seems like you can't even work around it by setting the right appropriate json options. We're going to make it so you can at least set the option to control the handling here.
@JamesNK is there any reason you didn't set the default option instead of changing it on the reader? https://github.com/aspnet/SignalR/blob/bff2060454fc15d8633839714c14388757908833/src/Microsoft.AspNetCore.SignalR.Protocols.Json/Protocol/JsonHubProtocol.cs#L135

Fixed. You could use DateTimeOffset instead until the next release. When the time zone is zero then it is UTC.

Re-closing, we're going to open new issues for patch work.

Not to beat a dead horse here, but I am assuming this fix didn't make it in to v1.0.0?
I just updated via nuget and this issue still persists and want to know if it's me that's screwing something up.
thanks

No, this will be in the patch 1.0.1

Thanks, Brennan


UIExplorer component navigation support for an embedded simulator in the documentation site

@facebook-github-bot shipit

I'm sorry but I'm on pto for two weeks, won't be able to review this :(
@brentvatne can you help?

@vjeux - ok on it

Looks like there are still some outstanding changes as per @tadeuzagallo's comments, @dsibiski @jsierles - ping me on Discord if you disagree with them and we can discuss

Yeah, we'll go over these soon, just haven't had time to review yet.

Any updates on this?

@christopherdro has been working on upgrading the website code to help finish this off here: #4570
We'll take a look this week to get this finished up and on all the documentation pages.

@jsierles Looking forward to this. This'll be so helpful.

@jsierles do you have any updates for this pull request? It's been a while so we wanted to check in and see if you've looked at the requested changes.

@jsierles Is this superseded by Christine's PR to add the simulator to all docs pages? Please reopen if that's not the case and you plan to continue working on this PR.


Run flake8 on CI

Update Python requirements
Add flake8 to Python requirements
Remove test to see if Java is installed
Add docstrings to tests
Run flake8 on CI

@ablbot autosquash


Return empty hash when a metric returns empty array

Sometimes I experience edge cases, once I found we received an empty array for page_fans_gender_age metric when fetch it from a small and new Facebook page. And current code returns nil in that case, that's probably not what we want.

Coverage decreased (-26.4%) to 71.652% when pulling e6971c2480ece42401e87f319b22c5cb9cf99c87 on kangkyu:empty_array_empty_hash into ef8d34d7454c4c775b618e10cd15cbed954597a5 on Fullscreen:master.

https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings you need set encrypted env variables in travis.yml file to use them in pull requests from fork


[getopt_win32] supports mingw only

By inspection one can see that the above port, is 'ported' from posix to mingw (I wonder why you need a port, but ok).
There is a Apache-licensed implementation here as a work-around (just drop it in): https://github.com/iotivity/iotivity/tree/master/resource/c_common/windows .

I'm also not clear the background, the author @qmfrederik might know more about getopt-win32 port.

I'm also not clear the background, the author @qmfrederik might know more about getopt-win32 port.

It's weird coz they only things that do not need porting are the common posix elements, while that's exactly what we seem to be doing here.

Well, the goal of this port was/is to support compiling code which uses getopt on Windows, without needing msys2 (i.e. a native Visual C++ toolchain).
The codebase I maintain originally used a CoApp package to get bring in getopt, and at one point it was migrated to vcpkg and that's where this port comes from.
If there's an easier way to do that, happy to be educated.

Thanks for posting this issue. This issue hasn’t been updated for a long time. Please reopen this issue if this is still a problem for you.


Remapping Quick Open Not Working

I'm trying to set up the following remap in my init.vim:
nnoremap <Space>pf :<C-u>call VSCodeCall('workbench.action.quickOpen')<CR>

When I hit <Space> p f in VSCode, the Quick Open panel quickly appears and disappears. I tried removing the <CR> at the end to just make sure the command was being passed in correctly, and it was:  screenshot. Hitting "Enter" after that would correctly bring up the Quick Open sheet and leave it open, as expected. Not entirely sure why the remap is closing the sheet prematurely.

Try VSCodeNotify instead of VSCodeCall

Ah-ha, that works; didn't realize the bit saying to use Notify always unless you really need Call. Perhaps that should be placed a little earlier in the doc?
Regardless, I'll close this out. Thanks!


add import for mbi files via msconvert

for testing only

need to add version check for msconvert if mbi file is imported
show dialog if non supported version is installed

Waiting for msconvert version


change fontys email export

fontys email
firstname
insertion
lastname
birthdate

Invalidated for now, may reopen is requirement changes again


Revert "Revert "refactor: added drizzle ORM (#4142)" (#4195)"

Reverts https://github.com/UNDP-Data/geohub/pull/4195
try to apply drizzle ORM PR (https://github.com/UNDP-Data/geohub/pull/4142) again
The following docker image tag is pushed by this PR for testing.
docker pull undpgeohub.azurecr.io/undp-data/geohub:feat-revert-4195-revert-4142-fix-drizzle-orm

there was a problem of upsertUser function, and this function was only executed in remote.


Application Insights daily data cap cannot be set to fractional number via CLI

Describe the bug
The daily data cap in Application Insights can be set to a non-integer number (eg. 0.1).   The az monitor app-insights component billing update command only allows integer numbers.
When using az monitor app-insights component billing show, the data volume cap is returned as a non-integer number.
The billing update command should be updated to accept fractional numbers to match the behavior of the portal.
Command Name
az monitor app-insights component billing update
Extension Name: application-insights. Version: 0.1.8.
Errors:
> az monitor app-insights component billing update --app $appName --resource-group $resourceGroup --cap 0.1
az monitor app-insights component billing update: error: argument --cap: invalid int value: '0.1'

To Reproduce:

az monitor app-insights component create --app $appName --resource-group $resourceGroup
az monitor app-insights component billing update --app $appName --resource-group $resourceGroup --cap 0.1

Expected Behavior
The --cap value should accept non-integer numbers.
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6

azure-cli 2.2.0 *

Extensions:
application-insights 0.1.8

add to S172

@ComradeCow Thanks for raising this issue. Let me reproduce and fix it.


refactor(client-redirects): migrate validation to validateOptions lifecycle

Motivation
Complete a TODO. We no longer rely on the default plugin ID.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tests

Thanks 👍 LGTM


Cache user roles

Description

Cache user roles so we don't send unnecessary requests to Keycloak every time.
Move Rspec tests to main app since we are not sharing the code anymore.

This will significantly reduce the number of requests made to Keycloak.
I'm not happy with the way the test suite changes work. The way the test suite stubs user roles, in combination with the use of ActiveHash which is read-only, makes it very difficult to alter the existing tests without resorting to stubbing of the Keycloak library.
I decided to move the Rspec suite to the main app because I needed to use various Rails libraries which we don't have available within the gem, and we are going to move shared-web into the main app anyway as we did on cosmetics. It means we can start writing Rspec tests instead.
Checklist:

[ ] Automated checks are passing locally.
[ ] CHANGELOG updated if change is worth telling users about.

General testing

[ ] Test without javascript
[ ] Test on small screen

Accessibility testing

[ ] Works keyboard only
[ ] Tested with one screen reader
[ ] Zoom page to 400% - content still visible
[ ] Disable css - does content make sense and appear in a logical order?
[ ] Passes automated checker (automated in build or manual)

@slorek could you please spin up review app if we need regression testing?

Looks good overall :+1:

Review app: https://psd-cache-roles-web.london.cloudapps.digital


Supporting alternate Host header for XMLHttpRequest requests

XMLHttpRequest doesn't allow to explicitly set a Host header, so we would need to support an alternate header like X-Host.
http://www.w3.org/TR/XMLHttpRequest/#the-setrequestheader()-method

1

+1

+1

@rsdevigo Kong should handle the OPTIONS request and automatically add X-Host to the Access-Control-Allow-Headers header.

side note: this is not a request because it is something we need to do, we are not just considering it.

So @thefosk, I think if the kong handle the OPTIONS request, it´s dangerous, cause sometimes the request may come with custom header besides X-Host, and sometimes I want that my API handle this request. Or I mistaken somewhere ?

If we decide to implement the X-Host solution, Kong will append the header to the list of headers that the API might return, so any scenario will be handled. So that everything can happen in one request.

So, the idea is:

Client -> do a GET|POST|PUT|DELETE request with X-Host, the browser do a preflight request with Method: OPTIONS and just a custom header list without their values is sent.
Kong -> Receive this OPTIONS request and answer  Access-Control-Allow-Headers : "X-Host".
Client Browser -> Do the GET request with the X-Host value.
Kong -> Receive the GET|POST|PUT|DELETE and get the X-Host value and proxy to the API target_url the request ?

Is it ?

The client makes an HTTP request to the API setting an additional X-Host header. The browser will execute an OPTIONS requests before executing the real request.
Kong will proxy the OPTIONS request to the final API, and before returning the response to the browser it will append X-Host to whatever Access-Control-Allow-Headers the API returned.
The browser now knows that the request conditions are valid (including the X-Host header), and executes the HTTP request.

I got it, but how the kong know the api public_dns if the x-host value it does not go with the OPTIONS request ? Or go ?

Not able to use Postman to test Kong calls. Though it allows "Host" header it actually doesn't get parsed since Chrome strips restricted headers including "Host".

@saaslink tomorrow we are releasing version 0.2.1 which will have a fix for Postman

@rsdevigo I will post more info on this issue once I think about the implementation

Could Kong just look for both Host and X-Host-Override headers and replace / add the Host header going upstream with the value from X-Host-Override if it exists?

#246 supports Host or X-Host-Override. Sounds good?

Yes, sounds good, but u test with XMLHttpRequest and angularJS preflight requests ?
When the angularJS application send a OPTIONS request the value of X-Host-Override does not exist, just the name of custom header.
How the Kong get this value to proxy the OPTIONS request ?

I'm not really sure if this issue is about allowing a system header for restricted headers on browsers or about the OPTIONS request. What is really needed, here?

I agree that now there is a way to make a XMLHttpRequest without using the browser for it, with this branch the kong can redirect the request to the API. But when the matter came up in the chat was to use the kong with a client written in angularjs.
I do not know if the issue was made thinking about it. But without a solution to this kind of request the kong can not work with libraries as angularjs and browsers.
I see that there should be another issue to deal with CORS and then XMLHttpRequests requests.

From what I've read we want several things here:

@thefosk Be able to set a non-restricted header from the browser that can allow Kong to know what API we are proxying (X-Host or X-Host-Override).
@thefosk + @rsdevigo Proxy preflight request to upstream. This means finding a way for Kong to know what API is being used in an OPTIONS request.
@montanaflynn When a preflight request is happening, allow to replace the upstream request's Host with a custom value.

As of today:

This is implemented in #246.
I don't see a way to do that, except with the path resolver coming in 0.3, see #192.
It requires 2, and I'm not sure why we would want to do that? Currently the requests going to upstream have Host set to the upstream's domain name, as expected. The issue is more in 2.

On a side note, keep in mind that if you want to use Kong from your browser you can use the CORS plugin. It will not proxy preflight requests to the end API by default (see kong/plugins/cors/access.lua#L63, but this issue raises concerns about it since like @rsdevigo said, if one uses the CORS plugin with preflight_continue=true from the browser, I don't see how Kong gets the public_dns of the API, I need to test this.
To conclude: we support a custom header, I do not see a way to proxy preflight requests with this resolver, but one can use the CORS plugin to perform browser calls (needs to be tested but probably still no preflight requests).
Please feel free to give me more infos on this if I'm missing anything.

@thibaultCha I think you misunderstood me.

Could Kong just look for both Host and X-Host-Override headers and replace the Host header going upstream with the value from X-Host-Override if it exists?

Meaning if I curl <IP_ADDRESS>:8000 -H "x-host-override: publicapis.com" and I have an API with the public_dns of publicapis.com it would still work. This is what I believe #246 did.

Oh ok, then yes it is what @thefosk originally described in the first comment of this issue, and it is #246.

I now fully understand what @rsdevigo was trying to say, I completely misunderstood his point. As he was trying to explain, the problem here is that the preflight OPTIONS request that the browser sends to Kong doesn't support any additional header, not even X-Host-Override.
Because of this, Kong will never know what is the API consumed, unless the API has a path resolver configured. The options we have here are:

The Kong resolver itself handles CORS, and it will just accept any API regardless of the CORS plugin configuration (but what if I don't want CORS on that API? Why do we need a CORS plugin if this is handled on the Kong level?)

CORS is only supported when:

A path resolver is being used
A fully configured public_dns is being used (which will make it work in production, but not when developing).

I have reopened the issue because clearly the previous solution is not satisfactory anymore.

The problem was understood and discussed here:

I don't see a way to do that, except with the path resolver coming in 0.3,

The path resolver (now available) is still the only way. I don't like the dirty hack though.
However supporting X-Host-Override does cover one use case:

Browser makes a request to Kong
Kong has no idea which API is requested at this point, correct, this has been discussed here
But this Kong instance was configured to allow CORS for all its APIs (not currently possible)
Kong replies 204 to the preflight request and specifies X-Host-Override as an allowed header
Browser makes the request with X-Host-Override
Kong knows which API the browser is requesting and proxies the request

If we only keep Host, then one can only query Kong with the DNS resolver (the public_dns value) when the domain name has an A record pointing to the Kong instance. Which is not an ideal development setup.

Should this not be and issue any longer? I'm attempting to send form data from a React application via Kong and I'm getting OPTIONS 405 when I do a POST request. The Host value isn't what I'm sending in the original request either.

Anyone?

@EwanValentine if you are using the path resolver this issue doesn't apply to your use-case.

@thefosk I'm not using the path resolver. My API endpoints follow the following scheme:
/api/v1/login (api.auth.v1)
/api/v1/signup (api.auth.v1)
/api/v1/artists (api.artists.v1)
/api/v1/orders (api.store.v1)
/api/v1/products (api.store.v1)

etc...

So I'm not sure how the path resolver would fit into that?

No worries, I've sorted it! I had no idea you could just call auth.myapi.dev/api/v1/login. My bad!


update repository configuration so version update is not required in toml

align with kiota repositories to reduce the maintenance burden. https://github.com/microsoft/kiota-abstractions-python/pull/278#issuecomment-2124645609

@fey101 FYI this one was not automatically added to the python language (but similar issues in core and v1 were)


Bump source-map to 0.3.x.

@jakubpawlowicz: don't merge this yet, I'll see if I can solve the failures.

Sure, let me know how it goes, otherwise I'll do.
For dep version you can use 0.3.x - the only reason I used >=0.1.43 is that source-map changed their internal API in that version.

Something is fishy with the paths... I get 21 test failures on Windows with node.js 0.12 while Travis gets 26 :/

><EMAIL_ADDRESS>test C:\Users\xmr\Desktop\clean-css
> vows

·······················  ··················································································································································· ·························································································································································································································································································································································································································································································································································································································································································································································································································································································································· ················ ············································································· ······································· ····························································································· ·········································· ································· ······························✗··✗··✗··✗·✗···✗··✗·✗··✗···✗✗✗·✗✗✗✗···✗··········✗✗·✗··✗ ·················································· ········ ························ ···················· ·································· ········ ········· ······ ········

    input map as string
      ✗ should have selector mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 4,
      source: 'styles.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:321

    input map from source
      ✗ should have selector mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 4,
      source: 'styles.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:349

    input map from source with root
      ✗ should have selector mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 4,
      source: 'styles.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:377

    complex input map
      ✗ should have first selector mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'some.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: '\\some.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:405

      ✗ should have second selector mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 14,
      originalLine: 1,
      originalColumn: 4,
      source: 'styles.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 14,
      originalLine: 1,
      originalColumn: 0,
      source: '\\styles.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:427

    complex but partial input map referenced by path
      ✗ should have 2 mappings to .less file
        » expected [
      {
          generatedLine: 1,
          generatedColumn: 6,
          originalLine: 2,
          originalColumn: 2,
          source: 'test\\fixtures\\source-maps\\styles.less',
          name: null
      }
  ] to have 2 element(s) // assert.js:54

    complex input map with an existing file as target
      ✗ should have 2 mappings to styles.less file
        » expected [
      {
          generatedLine: 1,
          generatedColumn: 6,
          originalLine: 2,
          originalColumn: 2,
          source: 'styles.less',
          name: null
      }
  ] to have 2 element(s) // assert.js:54

    nested once
      ✗ should have "section > div a" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 2,
      originalColumn: 8,
      source: 'once.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'C:\\Users\\xmr\\Desktop\\clean-css\\test\\fixtures\\source-maps\\nested\\once.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:491

    nested twice
      ✗ should have "body > nav a" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 3,
      originalColumn: 4,
      source: 'twice.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'C:\\Users\\xmr\\Desktop\\clean-css\\test\\fixtures\\source-maps\\nested\\twice.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:519

    input source map with missing mutliselector input
      ✗ should have "a:hover" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 2,
      originalLine: 1,
      originalColumn: 0,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 2,
      originalLine: 2,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:558

      ✗ should have "a:visited" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 10,
      originalLine: 1,
      originalColumn: 0,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 10,
      originalLine: 3,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:569

      ✗ should have "color:red" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 20,
      originalLine: 5,
      originalColumn: 4,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 20,
      originalLine: 5,
      originalColumn: 15,
      source: 'source.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:580

    input source map with missing mutliselector sortable input
      ✗ should have "a.button:hover" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 3,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:597

      ✗ should have "a.button:link" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 15,
      originalLine: 1,
      originalColumn: 0,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 15,
      originalLine: 1,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:608

      ✗ should have "a.button:visited" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 29,
      originalLine: 1,
      originalColumn: 0,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 29,
      originalLine: 2,
      originalColumn: 0,
      source: '__stdin__.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:619

      ✗ should have "color:red" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 46,
      originalLine: 5,
      originalColumn: 4,
      source: 'source.css',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 46,
      originalLine: 5,
      originalColumn: 15,
      source: 'source.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:630

    absolute source map from external host via http
      ✗ maps to external source file
        »
        actual expected

        http://<IP_ADDRESS>/remotestyles.cssless
         // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:703

    multiple source maps relative to local
      ✗ should have "div" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'some.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 0,
      originalLine: 1,
      originalColumn: 0,
      source: 'C:\\Users\\xmr\\Desktop\\clean-css\\test\\fixtures\\source-maps\\some.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:818

      ✗ should have "section > div a" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 4,
      originalLine: 2,
      originalColumn: 8,
      source: 'once.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 4,
      originalLine: 1,
      originalColumn: 0,
      source: 'C:\\Users\\xmr\\Desktop\\clean-css\\test\\fixtures\\source-maps\\nested\\once.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:829

      ✗ should have "div > a" mapping
        » expected {
      generatedLine: 1,
      generatedColumn: 28,
      originalLine: 1,
      originalColumn: 4,
      source: 'styles.less',
      name: null
  },
  	got	 {
      generatedLine: 1,
      generatedColumn: 28,
      originalLine: 1,
      originalColumn: 0,
      source: 'C:\\Users\\xmr\\Desktop\\clean-css\\test\\fixtures\\source-maps\\styles.css',
      name: null
  } (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:851

    relative to path complex but partial input map referenced by path
      ✗ should have right sources
        » expected [ 'test/fixtures/source-maps/some.less', 'test/fixtures/source-maps/nested/once.less', 'test/fixtures/source-maps/styles.less' ],
  	got	 [
      'test\\fixtures\\source-maps\\some.css',
      'test\\fixtures\\source-maps\\nested\\once.css',
      'test\\fixtures\\source-maps\\some.less',
      'test\\fixtures\\source-maps\\styles.css',
      'test\\fixtures\\source-maps\\styles.less'
  ] (deepEqual) // C:\Users\xmr\Desktop\clean-css\test\source-map-test.js:892
  ✗ Broken » 1592 honored ∙ 21 broken (1.375s)
  ·✗

We need to merge #458, which is basically ready, I only wait from you to add AppVeyor for this repo.

Something is indeed, I'll take a look later today.

I'll close this and let you make the update yourself @jakubpawlowicz. Something has changed upstream.


added bkbocholt-west.eu

the EU domain just contains the webpanel/mailserver for students
This is the official school page: https://www.bkbocholt-west.de

@MoweME Pull request merged. Thank you!


Legend does not show in sunburst chart

Version
latest
Link to Minimal Reproduction
https://github.com/apache/echarts
Steps to Reproduce

Set chart type to sunburst
Set legend show = true
Legend does not show

Current Behavior
Does not show legend
Expected Behavior
Show legend
Environment
- OS: All
- Browser: All
- Framework: All

Any additional comments?
I just saw another related issue which is 4 yrs old. I am not 100% sure it is the same issue since it is in Chinese and the translation is not clear, so I am creating a new issue, bcoz it is a showstopper for us. I believe it is a serious bug since it is a basic required function for a chart that is missing. Plz address ASAP.
Thanks!

I'm having the same issue here

Does anyone solve this issue? I have the same issue.

This is still happening...

This is still happening...

Yes

It seems that the data option must be specified in legend with some kinds of charts, and the name option in series too.
Example:

  legend: {
    data: ['relative']
  },
  series: {
    name: 'relative',
    type: 'sunburst',
    data: data,
    radius: [0, '90%'],
    label: {
      rotate: 'radial'
    }
  }

https://echarts.apache.org/examples/zh/editor.html?c=sunburst-visualMap


Fix entity removal script link

Fix entity removal script link

The link to the entity removal script is missing a ".py" at the end, hence resulting in a 404 error.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @retrogeek46
Thanks so much for fixing that - did you manage to test it out with .py ?

Hey @retrogeek46
Thanks so much for fixing that - did you manage to test it out with .py ?

Yes.

Thank you @retrogeek46,  great to know it's working! :)


[CARBONDATA-1910]do not allow tupleid, referenceid and positionReference as columns names

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[X] Any interfaces changed?
NA

[X] Any backward compatibility impacted?
NA

[X] Document update required?
NA

[X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
UTs are added to test the scenarios

[X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2133/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2422/

retest this please

retest sdv please

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/929/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2158/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2443/

LGTM

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2318/

retest this please

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1102/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/2550/

Build Success with Spark 2.2.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/1106/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/2323/

LGTM


STM32: Transition to device tree based pinctrl configuration

Following merge of https://github.com/zephyrproject-rtos/zephyr/pull/25996, STM32 boards should now be converted to the use of device tree pinctrl definitions.
This ticket aims at tracking the task completion:

Drivers (PR)
Status
Boards
Status
Macros deprecation
Status

Serial (#25996)
Merged
#28954, #28940

PWM (#28858)
Merged
#28858

I2C (on-going @erwango)

SPI ()

I2S ()

ADC ()

DAC ()

Ethernet ()

CAN ()

USB ()

SDMMC ()

I2S ()

For all people that would like to help on this task:
Thanks! But also:
Zephyr github CI could easily be swamped by changes impacting several boards.
Since this task might create numerous PRs impacting lot of boards, please tests changes locally before submission:
./scripts/sanitycheck -T samples/hello_world/ --cmake-only -l -a arm

I'm also doing a test to see if we maybe split board changes into 3 groups (nucleo, stm32, other) w/regards to PRs.

@erwango / @lochej / @gmarull  I've worked up a python script to convert pinmux.c into .dts.  Seems to work for a good number of cases (I2C, SPI, ADC, DAC, I2S).  There are some corner cases that need some discussion / understanding.

It would be great if you can share the script @galak . Once all boards get the right pinctrl included (I guess it will be the case after uart PR) it will help a lot. I can take a couple more drivers, it’s rather quick to add support for pinctrl, so together with the script we can finally get rid of pinmux in a few days :-)

It would be great if you can share the script @galak . Once all boards get the right pinctrl included (I guess it will be the case after uart PR) it will help a lot. I can take a couple more drivers, it’s rather quick to add support for pinctrl, so together with the script we can finally get rid of pinmux in a few days :-)

Happy to share, just need to figure out best way to do that:
Here are some areas that we need to look into:
I2C: [I2C2 missing]
nucleo_f030r8
stm32vl_disco
olimexino_stm32
stm32_min_dev_black
stm32_min_dev_blue
olimex_stm32_h103
waveshare_open103z
CAN:
waveshare_open103z [can missing]
olimexino_stm32 [can missing]
stm32f3_disco [can missing]
stm32f072b_disco [can missing]
nucleo_l452re [can/can1]
nucleo_l452re_p [can/can1]
USB:
disco_l475_iot1 - missing usb_otg_fs_id_pa10
b_l4s5i_iot01a - missing usb_otg_fs_id_pa10
nucleo_l4r5zi - missing usb_otg_fs_id_pa10
waveshare_open103z - usb_dm_pa11 missing
nucleo_wb55rg - usb_dm_pa11 missing

Here the current script:
https://github.com/galak/zephyr/tree/st-pin-convert
https://raw.githubusercontent.com/galak/zephyr/695016205558bd3b1c2711b46bf5af842ccb5a2b/boards/arm/st-pin-convert.py
Its kinda in a hackish state and currently line 29 can be hacked to enable different driver classes (mac/sdmmc1 don't have any pins define in the dtsi files right now so they don't do anything).

Just implemented the DAC part and updated the table. I think we can summarize all board updates into a single commit, as it's only a few lines of code changed in most cases.
I can look into the CAN driver later (or tomorrow) as I'm working on that anyway at the moment.

Just implemented the DAC part and updated the table. I think we can summarize all board updates into a single commit, as it's only a few lines of code changed in most cases.
I can look into the CAN driver later (or tomorrow) as I'm working on that anyway at the moment.

@martinjaeger for CAN be aware of https://github.com/zephyrproject-rtos/hal_stm32/pull/70

@galak, @gmarull, @lochej, @martinjaeger
Please note important change done in API in #29057

@gmarull
Just tested ETH pinctrl for STM32 as follows (add modules/hal/stm32/scripts/genpinctrl/stm32-pinctrl-config.yaml):
- name: ETH
  match: "^ETH_*"
  mode: alternate
  bias: disable

Could we give it a try?
Just for info: For h7series all the pins have very high speed, no push-pull and AF11 (see zephyr/drivers/pinmux/stm32/pinmux_stm32h7.h)


Create ADO pipeline to scan and generate English jsons containing localization data

We have a localization pipeline that generates the artifacts for localization when triggered.
However, this pipeline would be triggered weekly and needs the updated English JSON file if there is any new content.
Creating this issue to track the final pieces of work that maybe needed as part of onboarding go-sqlcmd with localization team.
### Tasks
- [x] Add  Localization.md that contains instruction on generating JSON files after a new content has been added for localization
- [ ] Automate above via a weekly pipeline job

We will be using build.cmd to update the JSON files received from localization pipeline from locale directory.


AsYouTypeFormatter outputs trailing space for "001" in France

The following test should be passing, but it fails, because there is a trailing whitespace "00 1 ", which shouldn't be there.. This is the only case that I found, where AsYouTypeFormatter outputs a trailing non-digit character, and it would effectively prevent Backspace from deleting "1" because the whitespace would immediately reappear after it's removed.
@Test public void testFrance001() {
    PhoneNumberUtil util = PhoneNumberUtil.getInstance();
    AsYouTypeFormatter formatter = util.getAsYouTypeFormatter("FR");
    formatter.inputDigit('0');
    formatter.inputDigit('0');
    assertEquals("00 1", formatter.inputDigit('1'));
}

This is the intended behavior, and we have no plans to change it.
AsYouTypeFormatter outputs a space after the calling code for all regions.
For example, try inputting +41, and there will be a space after the last
character.
If you would like to understand the library's behavior better, please take a
look at AsYouTypeFormatter.java, and if you still have questions, consider
joining our discussion group.
I'll close this as it's not an issue with the library.

@penmetsaa, thanks for the reply.
However, +1 doesn't format with a trailing whitespace. Isn't that special?
Also, in +41212345678 (which is formatted as +41 21 234 56 78) only the first space is output as trailing character:
+41 -> +41  (with trailing space)
+4121 -> +41 21 (no trailing space)
+4121234 -> +41 21 234 (no trailing space)
+412123456 -> +41 21 234 56 (no trailing space)
Anyway, since the workaround for this strange behavior is straightforward (i.e. strip the trailing whitespace) - I'm just going to stop right here.


Improve home page frontend

Is your feature request related to a problem? Please describe.
I want to add frontend for large screen devices.
Describe the solution you'd like
I have some improvements for the home page frontend part of the website.
Describe alternatives you've considered
No response
Additional context
No response

I AM A UI/UX DESIGNER
so for a responsive Homepage-
i will-
Plan my layout
Use a responsive framework
Design for mobile-first
Use media queries
Test across devices
Provide touch-friendly interactions
I can make this more responsive.
assign this to me under gssoc'23.

Is your feature request related to a problem? Please describe.
I want to add frontend for large screen devices.
Describe the solution you'd like
I have some improvements for the home page frontend part of the website.
Describe alternatives you've considered
No response
Additional context
No response

Can you elaborate what improvements you want to do?

Can you elaborate what improvements you want to do?  @ojasaklechayt

Okay, so as we open the home page. All we were seeing was a small photo and a button to connect the wallet.
I have added a heading saying welcome to the expense tracker and increased the size of image.

Can you elaborate what improvements you want to do?  @ojasaklechayt

Actually I have already made a Pr @gurjeetsinghvirdee

Can you attach a SS?
@J0SAL will check if we had to add this thing or not

Can you elaborate what improvements you want to do?  @ojasaklechayt

Actually I have already made a Pr @gurjeetsinghvirdee

Please close that PR it would be invalid if you make it without assigning

Can you elaborate what improvements you want to do?  @ojasaklechayt

Actually I have already made a Pr @gurjeetsinghvirdee

Please close that PR it would be invalid if you make it without assigning

I see okay 👍

Can you elaborate what improvements you want to do?  @ojasaklechayt

Actually I have already made a Pr @gurjeetsinghvirdee

Please close that PR it would be invalid if you make it without assigning

Can you please assign this to me?

@J0SAL will do if he likes the idea

go ahead, @ojasaklechayt! 🚀
you can try creating a title as "Welcome to Jarvis"
Also please make sure the UI stays responsive.

will be worked on under #139


Optimise plane::as_region

This is part of a series of commits authored by @maj160 to improve performance of rav1e.
This commit results in an overall performance improvement of about 2% at speed 2 10-bit:
Benchmark 1: ~/Downloads/rav1e_master -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     43.646 s ±  0.088 s    [User: 43.656 s, System: 0.170 s]
  Range (min … max):   43.471 s … 43.787 s    10 runs

Benchmark 2: ~/Downloads/rav1e_mod -s 2 --quantizer 64 ~/xiph-media-files/objective-1-fast-10bit/speed_bag_640x360_60f.y4m -y -o /dev/null
  Time (mean ± σ):     42.919 s ±  0.082 s    [User: 42.934 s, System: 0.169 s]
  Range (min … max):   42.813 s … 43.039 s    10 runs

Codecov Report
Base: 86.87% // Head: 86.92% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (4e63d0e) compared to base (0ce6ff5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3091      +/-   ##
==========================================
+ Coverage   86.87%   86.92%   +0.05%
==========================================
  Files          83       83
  Lines       33094    33109      +15
==========================================
+ Hits        28749    28780      +31
+ Misses       4345     4329      -16

Impacted Files
Coverage Δ

src/frame/plane.rs
100.00% <100.00%> (ø)

src/tiling/plane_region.rs
88.05% <100.00%> (+0.41%)
:arrow_up:

src/cpu_features/x86.rs
39.58% <0.00%> (-2.09%)
:arrow_down:

src/rdo.rs
85.62% <0.00%> (-0.05%)
:arrow_down:

src/encoder.rs
87.15% <0.00%> (+0.03%)
:arrow_up:

src/deblock.rs
96.52% <0.00%> (+0.15%)
:arrow_up:

src/asm/x86/lrf.rs
90.96% <0.00%> (+3.15%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Cards are generated with "No content" for some leetcode problems

For a small subset of questions, the generated cards don't capture the question content but instead, have the Content field being No content.
For instance, problem 2340 has such an issue deterministically, while problem 2341 always shows up fine.
Some Leetcode questions with Content field being no content:

2339
2340
2345
2346
2355
2356
2361
2362
...

I see. Didn't realize the ones that failed were all premium questions. Thanks for clarifying!


Mutation to add username to user

With new auth strategy first you will create your account/login with your google account.  Then you will be prompted with a text field to choose your username (Only if you do not have one).  Modal will need to say something along the lines of you will not be changing the username.
Requires frontend/backend change.
First mutation for adding just username
Then frontend design to hit that mutation

https://github.com/MyiWorlds/myiworlds.backend/commit/e37d09a5160afba6f472c732a45749a2f90bf3f2


[BEAM-7608] Honor DATASTORE_EMULATOR_HOST env var

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

 Thanks.
Please self-merge after tests pass.


Issue with webview

Look the white background at the top of webview.. It is covering the backgorund set to viewpager.. Is this a bug?

Same thing happens when another link is opened in webview... It covers entire height and hence covers up the viewpager background

No it's not a bug. I have to get a full height scroller, so my only
solution is to make the background clear color and add a margin into the
top.
I really hate webviews, so I don't think i'm gonna modify this. But if you
have another solution you can create a pull request, I will merge it ;)
2015-05-27 9:08 GMT+02:00 sach200<EMAIL_ADDRESS>
Same thing happens when another link is opened in webview... It covers
entire height and hence covers up the viewpager background
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/MaterialViewPager/issues/44#issuecomment-105788153
.

I added transparent background color and added margin at the top.. Got this!!!! The white rectangle doesnt scroll... Webview scrolls in half portion only

and add
webSettings.setRenderPriority(WebSettings.RenderPriority.HIGH); webSettings.
setCacheMode(WebSettings.LOAD_NO_CACHE); webSettings.setJavaScriptEnabled(
true); webSettings.setDomStorageEnabled(true); //transparent background
webView.setLayerType(WebView.LAYER_TYPE_SOFTWARE, null);
2015-05-27 10:18 GMT+02:00 sach200<EMAIL_ADDRESS>
I added transparent background color and added margin at the top.. Got
this!!!! The white rectangle doesnt scroll... Webview scrolls in half
portion only
[image: screenshot_2015-05-27-13-46-18 1]
https://cloud.githubusercontent.com/assets/12546237/7831699/d35d8a24-0476-11e5-8bb6-2b2c53840f13.png
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/MaterialViewPager/issues/44#issuecomment-105815894
.

https://github.com/florent37/MaterialViewPager/blob/master/materialviewpager/src/main/java/com/github/florent37/materialviewpager/MaterialViewPagerHelper.java
2015-05-27 10:20 GMT+02:00 Florent Champigny<EMAIL_ADDRESS>
and add
webSettings.setRenderPriority(WebSettings.RenderPriority.HIGH);
webSettings.setCacheMode(WebSettings.LOAD_NO_CACHE); webSettings.
setJavaScriptEnabled(true); webSettings.setDomStorageEnabled(true); //transparent
background webView.setLayerType(WebView.LAYER_TYPE_SOFTWARE, null);
2015-05-27 10:18 GMT+02:00 sach200<EMAIL_ADDRESS>
I added transparent background color and added margin at the top.. Got
this!!!! The white rectangle doesnt scroll... Webview scrolls in half
portion only
[image: screenshot_2015-05-27-13-46-18 1]
https://cloud.githubusercontent.com/assets/12546237/7831699/d35d8a24-0476-11e5-8bb6-2b2c53840f13.png
—
Reply to this email directly or view it on GitHub
https://github.com/florent37/MaterialViewPager/issues/44#issuecomment-105815894
.


⚠ Bofrost.be has degraded performance

In b6316e1, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1133 ms

Resolved: Bofrost.be performance has improved in 9c12a78 after 27 minutes.


Redirect from GET request - res.redirect(response.location) - doesn't open correct URL when headless but works fine headful

I have this Cucumber step where a link is clicked that makes a GET request to my Express route which responds with a redirect to a PDF page res.redirect(response.location). It works fine in headful but fails in headless with AssertionError: expected ':' to include 'correctPdfUrl'. Did anyone encounter this kind of behavior?
Unfortunately, I can't post an example that can be downloaded and ran locally because it's work code, I have to be very mindful about what i show.
Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.6.0
Platform / OS version: macOS Sierra
URLs (if applicable): Unable to provide.
Node.js version: 8.11.3

What steps will reproduce the problem?

Browser setup

Before(async function before() {
  this.browser = await puppeteer.launch({
    executablePath: process.env.NODE_ENV && '/usr/bin/chromium-browser',
    headless: false,
    args: ['--no-sandbox', '--disable-setuid-sandbox', '--allow-insecure-localhost', '--disable-popup-blocking', '--disable-gpu'],
    ignoreHTTPSErrors: true,
  });

  this.page = await this.browser.newPage();
  await this.page.setViewport({
    height: 800,
    width: 1280,
  });
});

After(async function after(scenario) {
  if (scenario.result.status === Status.FAILED) {
    const screenshot = await this.page.screenshot({
      fullPage: true,
    });
    await this.attach(screenshot, 'image/png');

    const dir = `${__dirname}/../../../build/test/screenshots`;
    const filename = scenario.pickle.name
      .toLowerCase()
      .replace(/ /g, '-');

    fs.writeFileSync(`${dir}/${filename}.png`, screenshot);
  }

  return this.browser.close();
});

Cucumber steps that are displaying inconsistent behavior.

Then('the user opts to view the PDF', async function step() {
  await this.page.click('[data-name="view-pdf"]');
  await this.page.waitFor(3000);
});

Then('a new window with a PDF is opened', async function step() {
  const [tabOne, tabTwo, tabThree] = await this.browser.pages();
  expect(tabThree.url()).to.include('https://myRedactedUrl');
});

What is the expected result?
Everything works as expected when I run headful. I can see the GET request to my server and straight away the redirect to the PDF URL.
Then('a new window with a PDF is opened', async function step() {
  const [tabOne, tabTwo, tabThree] = await this.browser.pages();

  console.log(tabOne.url(), 'tabOne.url()');       // about:blank tabOne.url()
  console.log(tabTwo.url(), 'tabTwo.url()');        // http://localhost:3000/myRedactedUrl
  console.log(tabThree.url(), 'tabThree.url()');  // https://correctPdfURL

  console.log('pages', (await this.browser.pages()).length);      // 3
  expect(tabThree.url()).to.include('https://correctPdfURL')  ;  // passes
});

What happens instead?
This time running headless.
Before(async function before() {
  this.browser = await puppeteer.launch({
    executablePath: process.env.NODE_ENV && '/usr/bin/chromium-browser',
    headless: true,
    args: ['--no-sandbox', '--disable-setuid-sandbox', '--allow-insecure-localhost', '--disable-popup-blocking', '--disable-gpu'],
    ignoreHTTPSErrors: true,
  });

  this.page = await this.browser.newPage();
  await this.page.setViewport({
    height: 800,
    width: 1280,
  });
});

After(async function after(scenario) {
  if (scenario.result.status === Status.FAILED) {
    const screenshot = await this.page.screenshot({
      fullPage: true,
    });
    await this.attach(screenshot, 'image/png');

    const dir = `${__dirname}/../../../build/test/screenshots`;
    const filename = scenario.pickle.name
      .toLowerCase()
      .replace(/ /g, '-');

    fs.writeFileSync(`${dir}/${filename}.png`, screenshot);
  }

  return this.browser.close();
});

Then('a new window with a PDF is opened', async function step() {
  const [tabOne, tabTwo, tabThree] = await this.browser.pages();

  console.log(tabOne.url(), 'tabOne.url()');            // about:blank tabOne.url()
  console.log(tabTwo.url(), 'tabTwo.url()');             // http://localhost:3000/myRedactedUrl
  console.log(tabThree.url(), 'tabThree.url()');       // :

  console.log('pages', (await this.browser.pages()).length);            // 3
  expect(tabThree.url()).to.include('https://correctPdfURL');          // fails
});

Link Click -> GET /pdf Express -> res.redirect(response.location) -> Browser opens a new tab with the http://correctPdfUrl -> Works headful vs Doesn't work headless
Thank a lot, you're doing a great job.

It looks like the issue is with PDF viewing in headless mode. The thing is, Chrome Headless doesn't know how to show PDFs (PDF viewer is not a part of headless chrome), so it initiates a download instead. And downloads are not properly supported yet, see #299
Speculatively closing; hope this helps, let me know if it doesn't.

It makes sense.
Thanks for the reply.


copy right footer

Is your feature request related to a problem? Please describe.
no copy right footer
Describe the solution you'd like
it will protect the website for copy right
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context

We don't need a copyright text. It's an open-source project for kids. Also, there is not footer in the design of the app.
Happy Contributing!


injectSheet generates invalid class names

The standard display name for components wrapped in a higher order component contains brackets, for example connect(MyComponent).
If you apply injectSheet on such a component the class names in dev mode will contain those beackets.
import React from 'react'
import injectSheet from 'react-jss/lib/injectSheet'

/**
 * Empty higher order component with display name according to
 * https://github.com/airbnb/javascript/tree/master/react
 */
function withFoo(WrappedComponent) {
  function WithFoo(props) {
    return <WrappedComponent {...props} foo />
  }

  const wrappedComponentName = WrappedComponent.displayName
    || WrappedComponent.name
    || 'Component'

  WithFoo.displayName = `withFoo(${wrappedComponentName})`
  return WithFoo
}

/**
 * Dummy component to illustrate the problem
 */
const styles = () => ({
  container: {
    border: 'solid 2px red',
  },
})

function ComponentWithStyles({ classes }) {
  document.querySelector(`.${classes.container}`)
  // Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '.withFoo(ComponentWithStyles)-container-0-3' is not a valid selector.
  return (
    <div className={classes.container}>
      Bar
    </div>
  )
}

export default injectSheet(styles)(withFoo(ComponentWithStyles))
// the work-around would be to apply the styles first:
// export default withFoo(injectSheet(styles)(ComponentWithStyles))

this has been fixed lately, please update
On Nov 23, 2017 15:47, "Tobias Zucali"<EMAIL_ADDRESS>wrote:

The standard display name for components wrapped in a higher order
component contains brackets, for example connect(MyComponent).
If you apply injectSheet on such a component the class names in dev mode
will contain those beackets.
import React from 'react'import injectSheet from 'react-jss/lib/injectSheet'
/** * Empty higher order component with display name according to * https://github.com/airbnb/javascript/tree/master/react */function withFoo(WrappedComponent) {
function WithFoo(props) {
return <WrappedComponent {...props} foo />
}
const wrappedComponentName = WrappedComponent.displayName
|| WrappedComponent.name
|| 'Component'
WithFoo.displayName = withFoo(${wrappedComponentName})
return WithFoo
}
/** * Dummy component to illustrate the problem */const styles = () => ({
container: {
border: 'solid 2px red',
},
})
function ComponentWithStyles({ classes }) {
document.querySelector(.${classes.container})
// Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '.withFoo(ComponentWithStyles)-container-0-3' is not a valid selector.
return (

Bar

)
}
export default injectSheet(styles)(withFoo(ComponentWithStyles))
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cssinjs/react-jss/issues/182, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADOWHIc1x9s1cusrFK6g3aQMnt3mO36ks5s5XdXgaJpZM4Qoxxu
.

The bug is reproduceabe in v8.1.0. In which branch was it fixed?

v8.1.0 depends on jss 9.3.2, please check your jss version, evtl you are not installing the latest jss version

Also please let me know if jss was old if this is the fault of react-jss.

Please reopen if the issue is still there.


[Bug] Bundle size is too big

Describe the bug
The bundle size of @milkdown/core is too big.

We can reduce a huge bundle size by lib import with lodash-es.
To Reproduce
https://bundlephobia.com/package/<EMAIL_ADDRESS>Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
N/A
Smartphone (please complete the following information):
N/A
Additional context
N/A

@Saul-Mirone I can create a PR to address it.

The lodash-es modules is a pure es module so it can be tree shaked. The package is not bundled for now, users should bundle it themsevles.

But I think we can remove lodash-es for now because we only use one method in it, we can write one instead of import the whole lib

Lodash has been remove from the project, bundle size will drop for next release.

@Saul-Mirone Wow, that is mind blowing and insane. Thanks you so much.

https://bundlephobia.com/package/<EMAIL_ADDRESS>I think this's the best we can do, the prosemirror-view package holds most spaces of it now.
<EMAIL_ADDRESS>


Add --no-wait parameter to operations related to Azure Relay Hybrid Connections and Azure Container Instances

Related command

az container stop
az relay hyco create
az relay hyco delete
az relay hyco update
az relay hyco authorization-rule create
az relay hyco authorization-rule delete
az relay hyco authorization-rule update

Is your feature request related to a problem? Please describe.
When using the Azure CLI commands to create, delete, and update Azure Relay hybrid connections along with stopping the created Azure Container Instances, the operations did not provide an option to add a --no-wait in order to not wait for the long running operations to finish which resulted in waiting for long periods of time for the commands to finish.

route to CXP team

PramodValavala-MSFT

Thank you for sharing but if you could clarify a little more that would be helpful.
az container stop does not have the --no-wait capability but az container start, az container create, az container restart does. I would like to get a better understanding on why some of the commands support the no wait capability. It seemed natural that if az container start supports it, then az container stop would also support it.

@tasdevani21 Apologies for the delay here! The commands here are essentially wrappers around the REST API and the --no-wait flag is applicable to endpoints that tend to return a 202 Accepted response - which means that the actual work has been accepted and will be done asynchronously.
The --no-wait flag is simply a way to "fire and forget" these endpoints without any output (which is similar to what happens when running the command as I've shared in my last comment). The main request is still sent even with the flag (which is probably taking time depending on other circumstances) but the final response is not polled for.
The az container stop command returns once the request is successful but doesn't really wait for the container itself to stop, which is why the --no-wait parameter would not make a difference here in terms of execution time.


How can i disable camera preview?

Hi, there is a way to disable the camera preview with some properties?

Try:
mBeyondarFragment.getView().setVisibility(View.INVISIBLE);


Fix CollectionRuleMetadataNames source file name

Fix the source file name for CollectionRuleMetadataNames to not have a space in it. This extra space is causing SourceLink information to not be generated correctly.

/backport to release/7.x

/backport to release/6.x


the version info of superset1.5 does not update

I download the tar package from https://downloads.apache.org/superset/1.5.0/ and install superset1.5,the version info dose not update.

@miracletiger how did you install this version? When running pip install -e . or pip install . in the root of the source, the superset/static/version_info.json file is created which is referenced by the About menu item. It's not included in the source files as it gets created during build/installation, but maybe we could consider adding it to the source distribution.

I have the same problem when using superset helm.

Hi, any luck with that?

Since we're now on 3.1, on the verge of 4.0, we're not supporting 2.x  or prior versions actively. If anyone is experiencing this issue in current versions, please file a new issue with updated context and repro steps. Thank you for understanding :)


Release Google.Cloud.TextToSpeech.V1Beta1 version 2.0.0-beta04

Changes in this release:
Bug fixes

BREAKING CHANGE Correct long audio synthesis HTTP binding (commit 8e47bc8)

Documentation improvements

Deprecate the custom voice usage field (commit 8e47bc8)
Update documentation to require certain fields (commit d79e879)

Created release for Google.Cloud.TextToSpeech.V1Beta1-2.0.0-beta04


Create Invitation API request

Service Package Request

Very interested in support for the MS Graph API invitations endpoint.  My apologies if I'm missing an existing implementation, but I'm unable to see any reference to this API within the source of this repo.
I would like to be able to use this invitation endpoint (along with the already implemented GetUser and DeleteUser endpoints) to enhance the terraform AzureAD provider as per this Pull Request
Any assistance would be greatly appreciated.  If need be I'm happy to have a hand in implementing, but I'm still quite new to Go and wasn't able to figure out the codegen process.
Thank you!

@joshgav I don't see a swagger for this API, can you please contact the endpoint owner to see if they have a plan for creating one?

Did you ever get a reply from the endpoint owner @daniel-simpson ?

@dansanabria unfortunately not, and as I was only doing investigation at that point we ended up having to park this piece of work :(

Hello,
Same need, I've try to find out where adding config file to let autorest mais the job of the services folder like said in https://github.com/Azure/azure-sdk-for-go/blob/master/CONTRIBUTING.md
I tried to start implementation on : https://github.com/Maarc-D/azure-sdk-for-go/tree/feat/graph-api-1.0 Because it's really needed on our side
But I can't find out where a stored the configfiles for autorest
Someone can tell me what I missed plz ?
like @daniel-simpson the aim is to create the autorest config matchin microsoft api graph : https://docs.microsoft.com/en-us/graph/api/overview?view=graph-rest-1.0
Regards Marc.

Hello,
Does someone know if I need to staticly put the go code generated by the swagger I created : https://github.com/Azure/azure-rest-api-specs/pull/10275
or does it will be automatic once merged ?
because I've test all the stack using the generated go files to code the missing feature on terraform provider : https://github.com/terraform-providers/terraform-provider-azuread/pull/297
it's working fine
Regards Marc.

Hi @Maarc-D once this swagger PR is merged, you could just open a new issue using the feature-request template, and then I will handle the release process.
But I am curious that would they approve a new swagger authored by outside of the service team?

We don't have microsoft.graph in https://github.com/Azure/azure-rest-api-specs/.    The openAPI specs are maintained by MicrosoftGraph team in a separate repo https://github.com/microsoftgraph/msgraph-metadata.  The GO SDK would not use the openapi specs in that repo. So if you still have this request, please contact msgraph team directly. Thanks


Use of the view macro in a lib file cause leeking of private structs

Following the book at the section explaining the view! macro, I tried to extract only the view code into a lib.rs next to a main.rs that only starts the app.
// lib.rs
use gtk::prelude::*;
use relm4::prelude::*;

struct AppModel {
    counter: u8,
}

#[derive(Debug)]
enum AppMsg {
    Increment,
    Decrement,
}

#[relm4::component]
impl SimpleComponent for AppModel {
...

// main.rs
use xxxx::AppModel;

fn main() {
    let app = RelmApp::new("wirth.simulator.gui");
    app.run::<AppModel>(0);
}

The compiler complains that AppModel would leak a private struct. I tried adding pub or pub(crate) to the struct, but it won't work.
Is this feasible ? Is there another way to avoid having all the view code in the main crate ?

Have you tried #[relm4::component(pub)]?


crashing when going to C:

ok so, when i go to the main drive, it just crashes. i can't convert the beatmaps.

Please provide specific informations(spec, video, etc).


[adguard-home] fix  volumes subpath

Description of the change
the goal of the change is to :

reflect subpath config in the values.yaml to show in the deployment

Benefits

actually use subpath in volume mounts in the deployment when a user sets this parameter and expects it to work

Possible drawbacks
should be a seamless change for existing users, so can't think of any
Applicable issues
None
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Title of the PR starts with chart name (e.g. [home-assistant])
[ ] (optional) Chart is using our common library as a dependency.
[ ] (optional) Variables are documented in the README.md

thank you @bjw-s , i have very limited experience with helm templating, so this a good opportunity to learn :D

Looks like the CI is failing because subPath is optional. I added some suggestions that should fix it.

it seems weird, because i even tried setting supath parameter to default value:"", and not use conditional in the template, and still it gives the same linting error


Use @mentions

This replaces any manual links and full names with @mentions, and enables the jekyll-mentions plugin.
/cc @nayafia

This replaces any manual links and full names with @mentions, and enables the jekyll-mentions plugin.
/cc @nayafia

YouTubebacc666666.com麻将胡了爆分

snapchar


Fix for #1775 and #1760

Q
A

Bug fix?
[ x]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #1775 #1760

What's in this Pull Request?
This pull request is to fix two issues on required field validation issues in Dynamic Form control
Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail
The root cause of issue #1760 is due to the initial value of newValue  has been changed from "null" to "undefined". So I modified  the related code to "undefined" as well.
Regarding #1775 , now changedValue won't use loaded item's value as initial value.  So I added another check to compare with value when there is no new value on this field.

@wuxiaojun514
Thanks for taking care of this issue!!!

When will be this fix available? When we will have a new release?

Waiting for #1726

@joelfmrodrigues any news about this issue? We hope to have a resolution

Waiting for #1726

Hi @joelfmrodrigues, why is this PR dependant on the #1726? It seems to be unrelated: editing filenames versus required fields showing a message.
It would be nice if we could ditch the dependency and get this fixed soon. (I've got customers running into this as well...) If I can help with any of this, do let me know!

Hey @martinlingstuyl I will have a look and likely merge this one as the other PR has unresolved conflicts for a long time. I haven't been active for a while for personal reasons (new kid and too much work 😅) but trying to get my head back into this and will try to look into this later today or over the weekend

Great to hear @joelfmrodrigues! Yeah, personal reasons enough that can lower your available time in open source. also on my end recently. I know how it goes 😀
Do let me know if I can be of help...

@wuxiaojun514 This is now merged. I'm really sorry for the time it took to merge
Thanks for the great work and clean code change

@6gal6ler6 @devspfx @martinlingstuyl  this is now merged, apologies for the delay

That's great to hear @joelfmrodrigues! My customer is going to be super excited 😀
What's the release date for 3.20?

@martinlingstuyl no date scheduled yet, but I will start the discussion on this as I can see there are several fixes/improvements already in this beta

Maybe I can fix the PR assigned to me first.😊 I'll see if I can make haste there

Hi @joelfmrodrigues,
I now see why you related this pr to #1726:
The testform now only works if I include FileLeafRef in the hiddenFields array. If I do not do that, submitting the form fails without an error. (due to the fact that the dynamic form currently cannot render File type Fields.
What I'm now using in TestForm.tsx:
<DynamicForm
          context={this.props.context}
          contentTypeId='0x0120D52000796BC7FCC8B819488729FB2B77B0E799002B2379630DCCB04D883603B763E843D7'
          listId={this.props.context.list.guid.toString()}
          listItemId={this.props.context.itemId}
          hiddenFields={['FileLeafRef']}
          onListItemLoaded={async (listItemData: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any
            console.log(listItemData);
          }} />

FYI

Will the branch conflicts of #1726 be resolved?
I see that @gruizdev is not responsive on that PR

Hi @joelfmrodrigues,
I now see why you related this pr to #1726:
The testform now only works if I include FileLeafRef in the hiddenFields array. If I do not do that, submitting the form fails without an error. (due to the fact that the dynamic form currently cannot render File type Fields.
What I'm now using in TestForm.tsx:
<DynamicForm
          context={this.props.context}
          contentTypeId='0x0120D52000796BC7FCC8B819488729FB2B77B0E799002B2379630DCCB04D883603B763E843D7'
          listId={this.props.context.list.guid.toString()}
          listItemId={this.props.context.itemId}
          hiddenFields={['FileLeafRef']}
          onListItemLoaded={async (listItemData: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any
            console.log(listItemData);
          }} />

FYI

Ouch, I missed this, thanks for reporting back


Setting noTLS should set http: true

https://github.com/aserto-dev/helm/blob/1dc5e92f5a31341770bf4c845c9d6c789963c654/charts/topaz/templates/_helpers.tpl#L278

Fixed in v0.1.3


ConfigMapper plugin not getting executed inside the MMM

Description:
$subject. ConfigMapper plugin does not execute when user run mvn clean install command inside the MMM project. It says, either deployment.toml path or template path is invalid.
Suggested Labels:
Type/Bug

Fixed with https://github.com/wso2/maven-tools/pull/68 and https://github.com/wso2/devstudio-tooling-platform/pull/267.


sError in .dsy2dpo(.M2sym(from)) :

It is very helpful to have a detailed study like yours that addresses a number of critical questions about differential expression for scRNA-Seq experiments.
I am running MAST with RE for a categorical response variable where I have 12 donors from condition_1 and 11 donors from condition_2.
When I run MAST for 20 different cell types separately, some of them fail giving the below error,
I wonder if you have encountered such situation and would be glad if you could share any suggestions. Thank you
sError in .dsy2dpo(.M2sym(from)) :
  not a positive definite matrix (and positive semidefiniteness is not checked)
In addition: Warning messages:
1: In vcov.merMod(object@fitD) :
  variance-covariance matrix computed from finite-difference Hessian is
not positive definite or contains NA values: falling back to var-cov estimated from RX
2: In vcov.merMod(object@fitD) :
  variance-covariance matrix computed from finite-difference Hessian is
not positive definite or contains NA values: falling back to var-cov estimated from RX
3: In vcov.merMod(object@fitD) :
  variance-covariance matrix computed from finite-difference Hessian is
not positive definite or contains NA values: falling back to var-cov estimated from RX
4: In vcov.merMod(object@fitD) :
  variance-covariance matrix computed from finite-difference Hessian is
not positive definite or contains NA values: falling back to var-cov estimated from RX
5: In vcov.merMod(object@fitD) :
  variance-covariance matrix computed from finite-difference Hessian is
not positive definite or contains NA values: falling back to var-cov estimated from RX
6: In checkConv(attr(opt, "derivs"), opt$par, ctrl = control$checkConv,  :
  Model failed to converge with max|grad| = 0.00204015 (tol = 0.002, component 1)
7: In checkConv(attr(opt, "derivs"), opt$par, ctrl = control$checkConv,  :
  unable to evaluate scaled gradient
8: In checkConv(attr(opt, "derivs"), opt$par, ctrl = control$checkConv,  :
  Problem with Hessian check (infinite or missing values?)
9: In vcov.merMod(object@fitC) :
  Computed variance-covariance matrix problem: not a positive definite matrix (and positive semidefiniteness is not checked);
returning NA matrix

@Ashduc - it is possible that you have either complete separation (all zero in one group, all expressed in the other) or you have genes included that are all zero. Are you filtering out lowly expressed genes? When you get this error does it time out or does it just print the warning and still provides an output?

Another thing to check is balance across donors for each cell type (it may be the case that you have some donors with a very low number of cells)

@kdzimm Thank you for the quick response. I am filtering 10% low expression genes. However, when I increase the cutoff to 20% it works. But I think 20% is too stringent. Also to notice, it works fine when Fixed-effect is used for donor_ID. Once I get the error it does not provide any output.

Stick with a fixed-effect then.  In my experience, within a particular cell type, there are only several hundred genes worth computing tests with.

@kdzimm
Thanks
When I use fixed effects, I see some genes that are specific to donor-donor variation become top hits. Which is not our primary focus. (We visually inspected the expressions for individual donors)
Which basically replicates the output from Seurat's FindAllMarkers() with the wilcox test.
Also, to note I am inputting log2(raw_counts+1) as the input.

Using DonorID as a fixed effect should not be replicating the results of FindAllMarkers() with the wilcox test. Your p-values will be many order or magnitudes smaller with FindAllMarkers(), but I guess the rank could be somewhat stable. The donor-to-donor variation may possibly still be there, but those top hits should be there because they are expressed more frequently/abundantly in one condition vs the other, so they may still be worth looking at.

Yes, the top hits are there. I will look into it more. Thanks for your input.


One of the tests is more of a benchmark.


Issues with files generated by newer version of protoc

I've attempted to compile the examples in this repository after installing eigen and protobuf locally using your scripts. While making the example, I get many errors like this:
In file included from /usr/local/include/google/tensorflow/tensorflow/core/public/session.h:22:0,
                 from /home/sebastien/tensorflow-cmake/examples/install-project/main.cc:1:
/usr/local/include/google/tensorflow/tensorflow/core/framework/device_attributes.pb.h:12:2: error: #error This file was generated by a newer version of protoc which is
 #error This file was generated by a newer version of protoc which is
  ^
/usr/local/include/google/tensorflow/tensorflow/core/framework/device_attributes.pb.h:13:2: error: #error incompatible with your Protocol Buffer headers. Please update
 #error incompatible with your Protocol Buffer headers.  Please update
  ^
/usr/local/include/google/tensorflow/tensorflow/core/framework/device_attributes.pb.h:14:2: error: #error your headers.
 #error your headers.
  ^

What is the issue here? Is my version of TensorFlow too new? Thanks for the help.

Same error here. You found some solution @sjdrc ?

Hey @jorgealemangonzalez, I ended up using https://github.com/FloopCZ/tensorflow_cc, it was much easier to get working. Check the open issues in the tracker over there, I managed to resolve them fairly painlessly.

I had the same issue:
My local system had protoc 3.6 installed, while the generated protobuf files in tensorflow (1.9.0) needed the exact version 3.5.
You can look the required version up in the "bazel-genfiles/tensorflow/core/protobuf" folder and cat any of the .h files in the directory. E.g cluster.pb.h specifies in the header:
#if GOOGLE_PROTOBUF_VERSION < 3005000
#error This file was generated by a newer version of protoc which is
#error incompatible with your Protocol Buffer headers.  Please update
#error your headers.
#endif
#if 3005000 < GOOGLE_PROTOBUF_MIN_PROTOC_VERSION
#error This file was generated by an older version of protoc which is
#error incompatible with your Protocol Buffer headers.  Please
#error regenerate this file with a newer version of protoc.
#endif

Installing the required version resolved the issue.

I was able to build tensorflow using local dependencies via https://github.com/bazelbuild/bazel/issues/3737#issuecomment-428988517


Automate Repo Updates

Currently, CNI and Envoy must both have their SHAs updated manually. This will likely soon include go-control-plane as well. These updates are easy to lose track of and it could be a significant amount of time between when an update is merged in a repo and when Istio actually picks it up. This is even more painful in Envoy where tests must be completed each step of the way and these tests can take over an hour to run.
This issue will cover the process of automatically updating the SHAs for:

Envoy

istio/proxy when istio/envoy changes
istio/istio when istio/proxy changes

CNI

istio/istio when istio/cni changes

JFYI, CNI is now part of istio/istio. It's still standalone for branches <= 1.6, though.

Envoy moves to istio/envoy when branches are cut(?) so can add that as a post cut item.
Proxy is done.

Should we do istio/envoy to istio/proxy for 1.7?

Addressed for Envoy and API, CNI no longer needed.

Summary:
master:
envoy has periodic task (168h) looking for envoy updates causing proxy to use a new sha
proxy update causes update of proxy sha in istio/istio
cni not needed
release-1.8
envoy updates causes update of envoy sha in istio/proxy
proxy update causes update of proxy sha in istio/istio
cni not needed
release-1.7
envoy updates are not automatically made in istio/proxy
proxy update causes update of proxy sha in istio/istio
cni not needed
release-1.6
envoy updates are not automatically made in istio/proxy
proxy updates are not automatically made in istio/istio
cni updates are not automatically made in istio/istio
We can verify the automation job for the proxy update works correctly in release 1.8 and copy to 1.7 so 1.7 automation is complete. release-1.6 is near EOL so maybe no additional changes are needed there.
Note: We need to make it part of the release branching to add the envoy update since it's periodic in master and not copied to the new branches.

I think this is done?

With the exception of https://github.com/istio/istio/issues/28403, I think this is done. Will take a look at the issue to verify.

https://github.com/istio/proxy/pull/3194 should contain a fix to the periodic envoy updates to istio/proxy in the main/master branch. That should be that last item to close this issue.


Cookies and ODIC_CLient

HI,
We have 2 angular application pointing to same Identity Server,
When user logged in with one application in the browser it stores cookies in the local storage -one with the local storage and second with the authority name,
now as both the application points to same authority the cookies saved with authority is shared and in second application the token of previous application is accessible.
and it does not trigger the login page

I don't understand. What is the question?

my question is - Some cookies are written back to the client by identityserver with default name of identityserver URL.
as same identityserver is shared between my 2 application, user is not asked for login in the second application if he is logged in in to one application..
is it the expected behaviour??
where as there is nothing common in these 2 applications apart from they shares the same identity server

as same identityserver is shared between my 2 application, user is not asked for login in the second application if he is logged in in to one application..
is it the expected behaviour??

That's the point of SSO.


PMID:29043956

loss of viability following cellular response to 4-NQO

loss of viability following cellular response to 4-nitroquinoline N-oxide FYPO:0006902
(Note: this and similar terms such as FYPO:0005704 & FYPO:0006863 will probably change from "cellular response to" to "exposure to" at some point, as GO tightens up its "cellular response to chemical" terms.)
edit file: 7dd3287daf21635ace9335cf56048f08b094ff54
release: bc071a6f56d7ae11464a58e942131f7ca5dcce87