Send files/attachments

For a few days I've been prototyping a hedwig-based bot connected to our internal data mart. I've begun to get requests from folks for more complicated responses, and in some cases requests for file attachments.
Example of current situation
Jeff Weiss: @hedwig who's running what version?
Hedwig: /code
Customer         | Version
ACME Tech        | 3.7.1
Alpha, AB        | 3.8.0
...
Zeta Industries  | 3.8.3

This might work fine for a small-ish responses, but pretty quickly becomes unwieldy. And if the folks using hedwig responses are plugging into to something else, we have to compromise between readability and integration.
I'd like your thoughts on adding the ability for file transfer/attachments for responders. Maybe something like reply_with_file(msg, text, file) or send_with_file(msg, text, file)
Example ideal interaction
Jeff Weiss: @hedwig who's running what version?
Hedwig: @jeffweiss who's running which version is a fair bit of data, so here it is as csv
<customer_versions.csv>

Necessary Adapter Changes
Based on some preliminary research, I believe that each of the existing adapters (Slack, HipChat, and IRC) could implement this new functionality.

Slack files.upload
HipChat share file with user
IRC CTCP DCC

Non-Hedwig Options
I can use technologies outside of Hedwig to accomplish this, but it requires the user to incur a switching cost as there's now an additional layer between them and what they'd asked for.

Send email with attachment (assuming email of asker is known/discoverable)
Dropbox/Box
Pastebin/Gist

Thoughts?

@jeffweiss I love this idea! I'll start thinking about an API for this.

@scrogson I'm wondering if it would be possible to delegate somehow the message to the adapter. As each service has its own types of messages. For example in telegram, to mention one, you can send keyboards.
I'm really asking, as a clarification for a doubt I have, I don't know if it's already in Hedwig. But I'd be a really nice API if not.
Currently at work we've developed something with AWS, kinda like a message gateway, a main entry point for receiving and sending messages (for messenger, kik, line, twilio & telegram), but this delegates to the services or adapters of this services, thus we can send special keyboards, special images, or custom responses without having any kind of limitation.
We've been wanting to change it, completely rewrite it in Elixir, so we can take advantage of what it gives us, like amazing fault tolerance software it's built upon. We were looking around, investigating when we came upon Hedwig, and we really think it could be the answer we've been looking.
Thanks for your attention.
Hope I've explained myself.

I'm wondering if it would be possible to delegate somehow the message to the adapter.

@behind-design what exactly do you have in mind?
The response messages do make their way back to the adapter which is responsible for transforming the %Hedwig.Message{} into whatever is required for the underlying service.

I was wondering if type field on %Hedwig.Message{} would be enough to distinguish if responder wants to send normal message or message with attachment (e.g. Slack 'message.attachment' type) or file. Adapters can use pattern matching to compose message needed for their specific messaging protocol.
Is this good idea? I am Elixir/Erlang beginner, so I am not sure if there is better/more idiomatic way how to solve this in Elixir.


Implement language-typescript.

TypeScript is a typed superset of JavaScript, with a well defined specification.
In relation to Fay, there are several applications:

Use TypeScript definition files to generate Fay bindings to existing JavaScript libraries. DefinitelyTyped is an active community of people creating type definitions, it would be useful to automatically generate Fay bindings from those.
Generate TypeScript definition files for Fay programs, so TypeScript users can access Fay libraries in a typed way.

These are interesting applications, and there might even be more, but they rely on being able to read and/or write TypeScript from Haskell.
A language-typescript library could be build as a full implementation of the TypeScript AST. However a language-typescript-defintions library, just for handling the "types" part of TypeScript, would also be useful.

Spring cleaning. Lack of activity, it's unlikely that this will happen. language-typescript exists now for the record.


[feature require] auto create point prompt for subcellular structure insider cell, such as Dense liposomes

A fine-tuned parameter bar in UI to tune opencv's algorithm to find the region of the image with the densest pixels, which is then used as the point prompt.

That sounds like an interesting idea. Would you be interested in contributing this? I am thinking about extensions for the automatic segmentation functionality, and this would be a good candidate.
If you're interested, then the next step would be a simple prototype script for the proposed functionality.

Sorry, I can't help to so this issue. I am a  student in biology with a few python coding skills,  I did know how to do deep learn coding  work.

Ok, I will see when we will come around to work on this, but it will probably be a while.


function _escape_identifiers in OCI8 Driver maybe not true

I've try edit code in line 1363 of DB_driver.php
if ($protect_identifiers === TRUE)
			{
				echo $item.$alias;
				$item = $this->_escape_identifiers($item);
				echo $item.$alias;
			}

And result show on screen maybe not expected
MYSCHEMA.TABLE.*
"MYSCHEMA".TABLE".*

Because this, my query is false : Message: oci_parse(): ORA-01740: missing double quote in identifier
I think maybe something in _escape_identifiers function wrong and need fix

You're talking about CI2, which is no longer supported.


delay in receiveLoop to let lower priority processes run

The core likes to block other processes from running. A delay of 10 milliseconds allows for lower priority processes to run in that time. Only really a problem when many low-prio processes are spawned while a core is running its receive loop.

Did you consider #313? Communication with the tdlib interface is something that sounds not be run at the priority of the UI process but Processor systemBackgroundPriority instead. :)

Did you consider #313? Communication with the tdlib interface is something that sounds not be run at the priority of the UI process but Processor systemBackgroundPriority instead. :)

We did try lowering the priority before, however that only crashed the app because we were writing to the transcript at the same time. This Transcript showln: was not present in the repository and only in our working copy. Without it, a lower priority works beautifully.
Lesson learned: Beware of the Transcript in multi-threaded code 😅

Did you consider #313? Communication with the tdlib interface is something that sounds not be run at the priority of the UI process but Processor systemBackgroundPriority instead. :)

We did try lowering the priority before, however that only crashed the app because we were writing to the transcript at the same time. This Transcript showln: was not present in the repository and only in our working copy. Without it, a lower priority works beautifully.
Lesson learned: Beware of the Transcript in multi-threaded code 😅

Thank you! Actually, Transcript is designed to be thread-safe. There was bug with it up to Squeak 5.3, though, but this should be fixed in the latest Trunk version. 🙂
Btw, I still would consider the short delay as an inter-cycle pause a good idea for two reasons: First, Squeak has a global interpreter lock when invoking FFI functions so despite your background process, for the duration of every call to tdlib, all other processes including the UI will hang. Second, you are wasting CPU time for no reason, see also "sustainability by design". 😉


Signing up without login

Design and implement a way for users to signup for a queue without signing in. HTAs should be able to choose this option as a setting.

Also enable this on a per-queue level through local settings.

Note that this is different from restricted mode (and is perhaps an umbrella feature.) A queue may allow remote signups, but also want to allow non-login signups on a specific computer. For example, a TA might volunteer their laptop for students without computers to sign up.


Remove: chrisant996.Clink version <IP_ADDRESS>b11f

## .\Tools\YamlCreate.ps1 -SkipPRCheck -Mode 5 -PackageIdentifier chrisant996.Clink -PackageVersion <IP_ADDRESS>b11f

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


add Instance/ServiceInstance cache& correct metadata access process

Describe what this PR does / why we need it
I add instance/SerivceInstance cache in ChangdServiceInstancesEvent, so there will be no extra and useless fetch behaviors.
I correct the metadata access process so SCA runs it more precisely.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
I ran samples on my laptop.
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.派哒 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Milestone 8 : Integration specs for views and fix n+1 problems (Pair-programming)

What we did ♻
In this project's milestone, we create integration tests for all of the views used in this project.
Project requirements 📗
n+1

Made sure that the N+1 problem is solved when fetching all posts and their comments for a user.

Integration specs

Use Capybara to write integration tests for each view in your project.

User index page:

I can see the username of all other users.
I can see the profile picture for each user.
I can see the number of posts each user has written.
When I click on a user, I am redirected to that user's show page.

user show page:

I can see the user's profile picture.
I can see the user's username.
I can see the number of posts the user has written.
I can see the user's bio.
I can see the user's first 3 posts.
I can see a button that lets me view all of a user's posts.
When I click a user's post, it redirects me to that post's show page.
When I click to see all posts, it redirects me to the user's post's index page.

User post index page:

I can see the user's profile picture.
I can see the user's username.
I can see the number of posts the user has written.
I can see a post's title.
I can see some of the post's body.
I can see the first comments on a post.
I can see how many comments a post has.
I can see how many likes a post has.
I can see a section for pagination if there are more posts than fit on the view.
When I click on a post, it redirects me to that post's show page.

Post show page:

I can see the post's title.
I can see who wrote the post.
I can see how many comments it has.
I can see how many likes it has.
I can see the post body.
I can see the username of each commentor.
I can see the comment each commentor left.

Be sure to include integration specs for any other features you may have implemented!

@SajjadAhmad14 Moreover this project is related to feature section only. So i will appreciate if you run the following command only rspec spec/features

@zainsadaqat With respect thank you so much for approving my project.


Passing GetRandom through builder functions?

I've always found the GetRandom to be hidden away and not really felt like part of the API that makes NBuilder so special. What about an override of our builder functions where we can pass in an instance of a generator, e.g
Builder<Person>().CreateListOfSize(10)
.With(x => x.Name, (g) => g.FirstName())
.With(x => x.LastName, (g) => g.LastName())
.With(x => x.Age, (g) => g.Birthday())
.With(x => x.PostCode, (g) => g.PostCode())

Nice idea!  Totally agree re: GetRandom which was why I created #46


w: Implement --no-header

Implement --no-header for w
This fixes #23.

could you please add a test for this? thanks

could you please add a test for this? thanks

Sure thing.


fix broken link to test schema file

looks like a link on README is broken. see https://github.com/gojek/beast#bq-setup
table name on your sample is test_messages so you should rename your file.
# query total records
bq query --nouse_legacy_sql 'SELECT count(*) FROM `<project_name>:dataset_name.test_messages LIMIT 10'

#  update bq schema from local schema json file
bq update --format=prettyjson <project_name>:dataset_name.test_messages  booking.schema

@yohei1126 Thanks for the PR. You can check good first issues and contribute.

OK will take a look


Adding missing bits for dynamic tabs (task #5963)

Few lines of associated tabs JS logic was missing from
recent cakephp-csv-migrations change on how we initiate
DataTables within related tabs.

Codecov Report

Merging #541 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
- Coverage     27.43%   27.35%   -0.09%
  Complexity      972      972
============================================
  Files            88       88
  Lines          3335     3345      +10
============================================
  Hits            915      915
- Misses         2420     2430      +10

Impacted Files
Coverage Δ
Complexity Δ

...ent/Plugin/Search/Model/ChildListItemsListener.php
0% <0%> (ø)
21% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad2905...74c4f65. Read the comment docs.


Code Snippet Rendering Issue: HTML Entity Conversion for Less-Than Symbol

Describe the bug
We have encountered a recurring issue within our web application where code snippets are not being displayed correctly. Specifically, the less-than symbol ('<') is being converted to its corresponding HTML entity ('<') when rendered on web pages, which is causing confusion and misinterpretation of the code presented to our users.
Examples of the Issue:
When displaying a C# for loop, the less-than symbol in the loop condition is being converted, resulting in incorrect display:
Expected:  (int i = 0; i < 5; i++)
Actual:  (int i = 0; i < 5; i++)

To Reproduce
Steps to reproduce the behavior:
The issue does not occur in OAI Playground.

Configuration: Please provide the following

Issue is encountered regardless of version gpt-4 1106-Preview and 0125-Preview.
Is chat history enabled? Yes
Are you using data? If so, what data source? (e.g. Azure AI Search, Azure CosmosDB Mongo vCore, etc) No

@iseabock this still doesn't work as intended. The code should be formatted using react-syntax-highlighter when there is a block of code, not when single symbols are mentioned, e.g. if the chatbot answers something inside `` as the example also shows in the PR. also my < sign is still renedered as raw hml inside the code blocks.


about the train log?

hi, can you provide the model or log file of your model? thank you very much!

I will provide the Transformer Model of PredCls task.
---Original---
From: @.>
Date: Fri, Aug 5, 2022 17:58 PM
To: @.>;
Cc: @.***>;
Subject: [aa200647963/SGG-DHL] about the train log? (Issue #1)
hi, can you provide the model or log file of your model? thank you very muck!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

ok! thanks.

I have provided the model and log files, read the README.md.

I have provided the model and log files, read the README.md.

hi，i see it, thanks for your share.


user_topics: Add a new endpoint to update visibility_policy.

This commit adds a new endpoint, POST /user_topics which is used to update the visibility_policy of a user topic row.
CZO discussion
Remaining decisions:

[x]  Allow you to remove a topic visibility policy even if you're no longer subscribed to the stream containing the topic? -- CZO discussion -- I would need to do some tweaking to the PR after a decision is made. (Decision)
[x] Should update_muted_topic internally call the new view? -- (Possibly NO, because request variables will be verified twice and we're not getting any real advantage.)
[x] Should we repeat test_add_muted_topic with the new URL? -- or we handle such cases differently when deprecating some URLs. -- (I have already added tests for the UNMUTED case.)
[x] What types of error responses do we document? -- Currently, /api/mute-topic doesn't document error responses, but it is raised when we provide an invalid stream_name or stream_id.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

FYI: @timabbott @abhijeetbodas2001
Questions in the PR description needs attention.

Should update_muted_topic internally call the new view? -- (Possibly NO, because request variables will be verified twice and we're not getting any real advantage.)

I don't think so. The do_set_user_topic_visibility_policy function we extracted out seems DRY enough to me :)

Should we repeat test_add_muted_topic with the new URL? -- or we handle such cases differently when deprecating some URLs. -- (I have already added tests for the UNMUTED case.)

The new endpoint should definitely be tested. It would be best to test do_set_user_topic_visibility_policy separately for all the error handling, and test the views only a few times to verify whatever logic is not present in do_set_user_topic_visibility_policy.

What types of error responses do we document?

I'm not sure. Maybe raise this question in #api design.
CC @gnprice

The new endpoint should definitely be tested. It would be best to test do_set_user_topic_visibility_policy separately for all the error handling, and test the views only a few times to verify whatever logic is not present in do_set_user_topic_visibility_policy.

I'd actually prefer all the new tests use the views. See https://zulip.readthedocs.io/en/latest/testing/philosophy.html#integration-testing-or-unit-testing for some of the reasoning, but basically it's almost always better to end-to-end verify behavior than just verifying behavior of internal functions, because it's easy for the internal function to be correct but still have incorrect overall output.
For documenting error responses, generally our policy is to only document those error responses that we expect a client to want to do something special other than "display the error message" in response to.

I'd actually prefer all the new tests use the views. See https://zulip.readthedocs.io/en/latest/testing/philosophy.html#integration-testing-or-unit-testing for some of the reasoning, but basically it's almost always better to end-to-end verify behavior than just verifying behavior of internal functions, because it's easy for the internal function to be correct but still have incorrect overall output.

Thanks for the link! This makes sense.
Above, I was mostly thinking about avoiding test duplication. The do_ function raises all of our errors, and the views are thin wrappers around that, with little validation of their own (apart from REQ). I guess we should avoid verifying all the errors for the two views independently (given the place of raising the errors is the same for both)?
The argument for writting out the set of tests for the new endpoint from scratch could be that it would be easy to just delete the test for the old endpoint once we get rid of the old endpoint?

@abhijeetbodas2001
Just to be precise, the do_ function doesn't raise any error (It just logging.info in couple of cases). :)
All the errors raised are due to check_for_exactly_one_stream_arg,  access_stream_by_id and access_stream_by_name.
The new view won't contain stream_name. So, check_for_exactly_one_stream_arg and access_stream_by_name will be removed.
Also, in the new test our payload data will change. i.e. we no longer have stream_name and op = add/remove replaced with visibility_policy.
So, i think creating the 'set of tests for the new endpoint from scratch' would be a cleaner approach (including the fact it would be easy to just delete the test for the old endpoint once we get rid of the old endpoint)
We should maybe rename the existing test class as MutedTopicsTestsDeprecated with an added comment about deprecation?
and the new test class named as MutedTopicsTests.

Just to be precise, the do_ function doesn't raise any error (It just logging.info in couple of cases). :)
All the errors raised are due to check_for_exactly_one_stream_arg, access_stream_by_id and access_stream_by_name.

Yeah, I meant stuff internal to that call stack (I also had the DB integrity errors in mind, but it seems I had forgotten that we had decided on returning success for duplicate requests :))

We should maybe rename the existing test class as MutedTopicsTestsDeprecated with an added comment about deprecation?

That makes sense to me 👍

This is ready for another look.
Updates in the recent push:

Addressed the review comments (I have replied to the respective review comments)
Added commits to enforce end-to-end test instead of calling internal functions. (check the first and last commit)

Needs attention: Question (not a blocker)
FYI: @abhijeetbodas2001 @timabbott

This is ready for another look.
Updates in the recent push:

Addressed the review comments (I have replied to the respective review comments)
Added commits to enforce end-to-end test instead of calling internal functions. (check the first and last commit)

Needs attention: Question (not a blocker)
FYI: @abhijeetbodas2001 @timabbott

I posted a handful of small comments, but otherwise this lgtm, please PM me when you have this updated so I can try to integrate it before we need to renumber the feature level.

Updates in the recent push:

Addressed the review comments.

Merged, thanks for all the work on this getting this nice and clean @prakhar1144!


Unable to display parent/child frames of joint

Steps to reproduce

open a model
expand the Joints group in the Navigator panel
right-click a joint

Expected behavior
"Toggle Parent Frame" and "Toggle Child Frame" are enabled and can be toggled. State is indicated by presence (true) or absence (false) of checkmark. If true, frame is shown in visualizer; if false, frame is not shown.
Actual behavior
"Toggle Parent Frame" and "Toggle Child Frame" are disabled and checked (see screencap). User is unable to toggle. Despite being checked, the frames are not shown in the visualizer.

Test conditions
opensim_embeddedBrowser062717Win64.zip on Windows 7.

Joint frame now appear, but they are indistinguishable from one another and other frames.

Original issue corrected (verified in OpenSim-2416f17a-2018-02-25.zip: "OpenSim 4.0 User Experience and Feedback Session" version). @aseth1: Please close and, if desired, create a new Issue about distinguishing among parent, child, and other frames.

Closing issue since it is technically fixed and issue #550 was opened to to capture fact the frames are now indistinguishable.


Reduce tallest proportion of tall images in matrix box

To 150%, from 200%.
Extra tall (eg, 9x16 == 177.6%) images will crop from center in the thumbnail view.
Full image will show in theater mode.

Coverage: 93.601%. Remained the same when pulling 432927274b3534c06c29873dd5253ba68c73560a on nimmo-add-fastimage into c26c6a0a70682af547b201faa627876b511955b1 on main.


Improve resilience of the project

Ensure the project can run independent from a single maintainer (me). This includes:

[x] Document main architecture
[x] Ensure multiple people have direct release access (wait for #11 to finish)
[x] Automate processes as much as possible (#13)

Currently waiting till the account setup is done by other maintainers.


Mermaid Insert option not present using Minimal theme

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
The Minimal theme does not show the option to insert a Mermaid graph as is done in all the other Themes.
To Reproduce
Steps to reproduce the behavior:

Switch to Minimal Theme
Reload
Go to Insert > Advanced
No Mermaid option

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version 13.1.7

Desktop (please complete the following information):

Browser Linux x86_64 Chrome/83.0.4103.61

Thanks for the report. This will be fixed in the next release.


Typo in 3rd paragraph

There is what appears to be a typo in the 3rd paragraph of the Standard Replication section.
the sentence read:
“The design of th high availability….”
I believe it should read:
“The design of the high availability….”

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 593037b3-bb00-5c4f-f87e-5e12afa593de
Version Independent ID: 1fd4360e-4196-e9d9-60e0-425813747f31
Content: High availability for Azure Cache for Redis
Content Source: articles/azure-cache-for-redis/cache-high-availability.md
Service: cache
GitHub Login: @yegu-ms
Microsoft Alias: yegu

@neodagen Thanks for your feedback! We will investigate and update as appropriate.

@neodagen The PR for the fix has been created and it will be merged soon. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


Get this building using AppVeyor

Hi @nblumhardt
I've managed to get a successful build :)

Any ideas on how to publish this to NuGet from AppVeyor? Is that how your doing it?

#2 Closes this

Still needs some attention, moved to the Serilog tracker here: https://github.com/serilog/serilog/issues/435
We turn off the trackers on each sink repository to keep things manageable in a central way, will turn this one off now too. Cheers!


ui of please fix me slightly unintuitive

reverse progressbar? to make it clearer that less is better
more prominent task description
A -> TS in preparation for other languages
self-host assets (monaco is huge)

self-host: add gzip

test if it actually works in production


Add dot to object definitions separating  and

Currently, the various type references are generated with <namespace><entry> e.g. com.google.protobufTimestamp. Code in the wild seems to suggest that using "." is correct. Asuming the original twirp swagger gen had implemented this incorrectly, we can fix this.

Implemented package and RPC separation, need to actually verify that packages like apm.v1 somehow make sense for twirp. Any feedback is welcome, but I'm gonna close this for now. The examples/ folder has illustrative output.


Render a linea gauge with the circle in the opposite side

Seems its dup for PR #187
Merged and availabe in 2.1.6


Adding mypy support

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

31 of 31 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+7.1%) to 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
7.1%

Covered Lines:
78

Relevant Lines:
78

💛  - Coveralls


Added -i flag  on two occasions to sed command while deleting lines.

This will delete the lines "in-place" of the existing file which is the
expected behavior.
Signed-off-by: Shantanu Deshpande<EMAIL_ADDRESS>Summary of changes:
Fixes: #2973

test-me-please

Thanks!


Don't pass MessageInfo to migrate

Follow up from https://github.com/CosmWasm/cosmwasm/issues/674#issuecomment-754607797
We currently do not allow sending funds in the migrate command in wasmd, and the sender is meaningless, as this is a permissioned call, so we never need to check it anyway.
I propose to simplify this and use the same function signature as query. In fact, other "priviledged" calls, like handling ibc messages, also likely do not need this field.

Interesting. This means it is completly up to the chain to decide who has permission to migrate. And there can be permissioning schemes that work different than the admin field we came up with.

Interesting. This means it is completly up to the chain to decide who has permission to migrate. And there can be permissioning schemes that work different than the admin field we came up with.

For everything the MessageInfo::sender was used for, we can also use the migrate message, like here:
pub struct MigrateMsg {
    pub payout: HumanAddr,
}

For everything the MessageInfo::sender was used for, we can also use the migrate message, like here:
pub struct MigrateMsg {
    pub payout: HumanAddr,
}

@venkattejaRaavi it seems like I cannot assign you here. But feel free to give this ticket a try. Let me know when something is unclear.

@venkattejaRaavi it seems like I cannot assign you here. But feel free to give this ticket a try. Let me know when something is unclear.

Re-opening since this really needs a proper CHANGELOG and MIGRATING entry

Re-opening since this really needs a proper CHANGELOG and MIGRATING entry


create_code uses gpt-4 even if set to gpt-3.5

This leads to this error every time if you don't have access to gpt-4:
Error calling API with status code 404 and message "{
"error": {
"message": "The model: gpt-4 does not exist",
"type": "invalid_request_error",
"param": null,
"code": "model_not_found"
}
}
"

Thanks for reporting that bug, I’ll look into it.

@PhillipRt issues should be fixed. I've made the model being used consistent across all plugins based on selection.


New version apis documentation

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[V] new API version

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
during June 2021
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
During June 2021
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[V ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[x] PowerShell ??
[V] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[V] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[V] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run

Changes looks ok from ARM perspective. Marking it ARMSignedoff please resolve other warning/errors and follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review

/azp run

/azp run

This RP only enables the generation for dot net SDK and ARM template.
@allenjzhang for dot net
@leni-msft for ARM template generation

@ArcturusZhang I added new APIs in the last commit.
The Breaking Changes fails now for the API that was removed in the previous PR that you already signed off (we were wondering why the breaking changes did not fail before, and I clarified that this API was never in use, so it was just a cleanup).
Please review again. Thanks!

Hey @MiriBerezin now that the breaking change CI is failing, it is mandatory that we have to get sign off from the breaking change review board, otherwise we cannot merge this PR.
Could you please follow the guidance here to initiate a breaking change review?


README

What to document
What this repo is for, what it contains and/or will contain.
In the README.

/assign @leogr


Adding a key prop to the component returned by renderCard improves performance, fixes a bug

I think this should be included in the documentation.

Adding a key prop to the component returned by renderCard is not necessary for current lib, that you can see in source code. If you have another point of view, please provide reproducible example and reopen this issue.


Document where Kingfisher views status can be found

It would be helpful for analysts to know where the hosted Kingfisher views logs are.

 Document where we can determine the status of Kingfisher Views

 Improve docs of kingfisher-views and kingfisher-process database

I believe this is just refresh-view.log and fields-counts.log in the ocdskfp user's home directory.
However, since users are presently expected to create their own views, log files will only be written if the user specifies the --logfile option.
I suppose this will become relevant again once #31 is closed.


k8s: CEP controller detects and handles health ep

The health endpoint has a corresponding CEP but isn't part of the
orchestration system (in this case, k8s). It isn't initialized to work
with the default CEP naming scheme, and requires special casing.
How to test (optional):
Don't see "Cannot get pod name for endpoint" messages from the CEP controller.

test-me-please

test-me-please

test-me-please

test-me-please


Is get_returns correct for getting portfolio return?

Describe the bug
In https://github.com/ssantoshp/Empyrial/blob/main/src/empyrial/main.py#L122-L127, we compute the return of a portfolio as below.
if len(stocks) > 1:
ret_data = assets.pct_change()[1:]
returns = (ret_data * wts).sum(axis=1)
Is this correct?
Expected behavior
As the time changes, the weights of stocks in the portfolio are changing. Should wts be updated when computing the return?

Hey, what are you trying to achieve? You can use rebalancing to keep the same weights over time.  Are you referring to something similar to #77? I just noticed it and will work on that!

@ssantoshp , yes, I'm referring to the same issue to #77.
I have a fix in this diff: https://github.com/pzzhang/Empyrial/commit/1ac72904c4111ae3724427eca7f2b20047db8489

Oh my god, you're fantastic! It would have taken me some time to get back and look and remember how we designed this (I am not the one who implemented rebalancing). Would you like to make a pull request? I don't mind copying the file either, up to you.

Fixed


Updating "Magma Partners" url

Directing to https://magmacore.com/find-implementation-partners/ instead of https://magmacore.com
Signed-off-by: Wes Wilson<EMAIL_ADDRESS>

Approved


BUG: discontinuity in ellipeinc

Describe your issue.
For specific combinations of phi and m, small perturbations to the input on the order of 1e-14 cause the output of ellipeinc to jump by almost 0.1
Reproducing Code Example
from scipy.special import ellipeinc

phi = 0.9002019046776508
m = 0.12706025328636256
ellipeinc(phi,m)-ellipeinc(phi+1e-14,m)

phi = 0.5549990348297817
m = 0.12706025328636256
ellipeinc(phi,m)-ellipeinc(phi+1e-14,m)

Error message
N/A

SciPy/NumPy/Python version and system information
1.10.1 1.24.3 sys.version_info(major=3, minor=10, micro=12, releaselevel='final', serial=0)
lapack_mkl_info:
  NOT AVAILABLE
openblas_lapack_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/Users/spark59/anaconda3/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
lapack_opt_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/Users/spark59/anaconda3/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
blas_mkl_info:
  NOT AVAILABLE
blis_info:
  NOT AVAILABLE
openblas_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/Users/spark59/anaconda3/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
blas_opt_info:
    libraries = ['openblas', 'openblas']
    library_dirs = ['/Users/spark59/anaconda3/lib']
    language = c
    define_macros = [('HAVE_CBLAS', None)]
Supported SIMD extensions in this NumPy install:
    baseline = NEON,NEON_FP16,NEON_VFPV4,ASIMD
    found = ASIMDHP,ASIMDDP
    not found = ASIMDFHM

Issue Summary:
#Issue Raised:
The issue involves small perturbations in the input to ellipeinc, causing a noticeable change in the output.
Reproduction Code:
python Copy code
from scipy.special import ellipeinc
phi = 0.9002019046776508
m = 0.12706025328636256
result1 = ellipeinc(phi, m)
result2 = ellipeinc(phi + 1e-14, m)
phi = 0.5549990348297817
m = 0.12706025328636256
result3 = ellipeinc(phi, m)
result4 = ellipeinc(phi + 1e-14, m)
Observed Differences:
The differences between result1 and result2 are approximately -9.44e-15.
The differences between result3 and result4 are approximately -9.88e-15.
Interpretation:
These differences are within the typical range of numerical precision for floating-point arithmetic and are commonly considered negligible.
Conclusion:
If these differences do not lead to practical issues in the usage of ellipeinc and align with the expected behavior, they may be deemed acceptable and might not require immediate intervention.

@sarvadutt your numbers disagree with @syp2001's reported "almost 0.1" jump - which SciPy/NumPy/Python versions did you use?

Cannot reproduce on main
In [1]: from scipy.special import ellipeinc
   ...:
   ...: phi = 0.9002019046776508
   ...: m = 0.12706025328636256
   ...: ellipeinc(phi,m)-ellipeinc(phi+1e-14,m)
Out[1]: -9.43689570931383e-15

In [2]: phi = 0.5549990348297817
   ...: m = 0.12706025328636256
   ...: ellipeinc(phi,m)-ellipeinc(phi+1e-14,m)
Out[2]: -9.880984919163893e-15

with numpy 1.24.3

I can have a go with @syp2001's versions at some point

I am on linux so my compilers are different
In [2]: scipy.show_config()
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: /home/jakeb/miniconda3/envs/scipy-dev/include
    lib directory: /home/jakeb/miniconda3/envs/scipy-dev/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP=0 PRESCOTT MAX_THREADS=2
    pc file directory: /home/jakeb/miniconda3/envs/scipy-dev/lib/pkgconfig
    version: 0.3.21
  lapack:
    detection method: pkgconfig
    found: true
    include directory: /home/jakeb/miniconda3/envs/scipy-dev/include
    lib directory: /home/jakeb/miniconda3/envs/scipy-dev/lib
    name: openblas
    openblas configuration: USE_64BITINT= DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP=0 PRESCOTT MAX_THREADS=2
    pc file directory: /home/jakeb/miniconda3/envs/scipy-dev/lib/pkgconfig
    version: 0.3.21
  pybind11:
    detection method: pkgconfig
    include directory: /home/jakeb/miniconda3/envs/scipy-dev/include
    name: pybind11
    version: 2.10.4
Compilers:
  c:
    args: -march=nocona, -mtune=haswell, -ftree-vectorize, -fPIC, -fstack-protector-strong,
      -fno-plt, -O2, -ffunction-sections, -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include,
      -DNDEBUG, -D_FORTIFY_SOURCE=2, -O2, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    commands: /home/jakeb/miniconda3/envs/scipy-dev/bin/x86_64-conda-linux-gnu-cc
    linker: ld.bfd
    linker args: -Wl,-O2, -Wl,--sort-common, -Wl,--as-needed, -Wl,-z,relro, -Wl,-z,now,
      -Wl,--disable-new-dtags, -Wl,--gc-sections, -Wl,--allow-shlib-undefined, -Wl,-rpath,/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -Wl,-rpath-link,/home/jakeb/miniconda3/envs/scipy-dev/lib, -L/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -march=nocona, -mtune=haswell, -ftree-vectorize, -fPIC, -fstack-protector-strong,
      -fno-plt, -O2, -ffunction-sections, -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include,
      -DNDEBUG, -D_FORTIFY_SOURCE=2, -O2, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    name: gcc
    version: 11.3.0
  c++:
    args: -fvisibility-inlines-hidden, -fmessage-length=0, -march=nocona, -mtune=haswell,
      -ftree-vectorize, -fPIC, -fstack-protector-strong, -fno-plt, -O2, -ffunction-sections,
      -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include, -DNDEBUG, -D_FORTIFY_SOURCE=2,
      -O2, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    commands: /home/jakeb/miniconda3/envs/scipy-dev/bin/x86_64-conda-linux-gnu-c++
    linker: ld.bfd
    linker args: -Wl,-O2, -Wl,--sort-common, -Wl,--as-needed, -Wl,-z,relro, -Wl,-z,now,
      -Wl,--disable-new-dtags, -Wl,--gc-sections, -Wl,--allow-shlib-undefined, -Wl,-rpath,/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -Wl,-rpath-link,/home/jakeb/miniconda3/envs/scipy-dev/lib, -L/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -fvisibility-inlines-hidden, -fmessage-length=0, -march=nocona, -mtune=haswell,
      -ftree-vectorize, -fPIC, -fstack-protector-strong, -fno-plt, -O2, -ffunction-sections,
      -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include, -DNDEBUG, -D_FORTIFY_SOURCE=2,
      -O2, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    name: gcc
    version: 11.3.0
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 0.29.35
  fortran:
    args: -march=nocona, -mtune=haswell, -ftree-vectorize, -fPIC, -fstack-protector-strong,
      -fno-plt, -O2, -ffunction-sections, -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    commands: /home/jakeb/miniconda3/envs/scipy-dev/bin/x86_64-conda-linux-gnu-gfortran
    linker: ld.bfd
    linker args: -Wl,-O2, -Wl,--sort-common, -Wl,--as-needed, -Wl,-z,relro, -Wl,-z,now,
      -Wl,--disable-new-dtags, -Wl,--gc-sections, -Wl,--allow-shlib-undefined, -Wl,-rpath,/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -Wl,-rpath-link,/home/jakeb/miniconda3/envs/scipy-dev/lib, -L/home/jakeb/miniconda3/envs/scipy-dev/lib,
      -march=nocona, -mtune=haswell, -ftree-vectorize, -fPIC, -fstack-protector-strong,
      -fno-plt, -O2, -ffunction-sections, -pipe, -isystem, /home/jakeb/miniconda3/envs/scipy-dev/include
    name: gcc
    version: 11.3.0
  pythran:
    include directory: ../../../miniconda3/envs/scipy-dev/lib/python3.10/site-packages/pythran
    version: 0.12.1
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
  cross-compiled: false
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
Python Information:
  path: /home/jakeb/miniconda3/envs/scipy-dev/bin/python3.10
  version: '3.10'

cc @steppi as you're working on Cephes

If it helps, this is the context in which the bug occurred:
from scipy.special import ellipeinc, ellipk, ellipj

x = 9/16
m = 0.12706025328636256
u = ellipk(m) * x
sn, cn, dn, ph = ellipj(u, m)

ellipeinc(ph, m) - ellipeinc(ph+1e-14, m)

It seems to only happen when x is a fraction where the denominator is a power of 2. The examples that I gave were for x = 9/16 and x = 11/32. It also happens at 11/16, 15/32, 18/32, 21/32, 22/32, and 23/32.

cc @steppi as you're working on Cephes

This is on my radar and I hope to take a look sometime the next couple of months.

@sarvadutt your numbers disagree with @syp2001's reported "almost 0.1" jump - which SciPy/NumPy/Python versions did you use?

Version: 1.11.3


Some actions becomes unavailable for some items in case Simple mode view is on

System information:

Operating system (distribution) and version win 10 x64
DBeaver version 7.0.2

Describe the problem you're observing:
In case of switching connection view to Simple some button disappear.
MySQL (Paste, Delete, Rename actions):

PostgreSQL:

In the time in the same bug maybe, I can't access on the schema with the simple view. No problem with advanced view.

Metadata modifications (like table/constraints create) are disabled for simple view mode.
Because most of metadata objects (constraints, indexes) are not visible and we want to have consistent UI.
Updated in #8381.

verified


log to standard logger, modalbox close fix and disable execute scheduler button

If a schedule is running or it is marked as inactive the Execute scheduler button will be disabled. This closes #8

When context.log is used it will also output to the default logger in addition to the database. This closes #7

You can now close the modal box by clicking outside the modalbox in addition to the x icon.


Support Go-JSON

This PR provides a mechanism to select the JSON library at start-up, on configuration and at compile time.
Go-JSON support is also added.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Well that's very interesting - the whole thing breaks!
@silverwind you might wanna take a look

I think this is refactor rather than feature

Hmm, I hope we did not hit a bug in that module. I'm certainly worried it might now be as stable as the other alternatives.

Probably need to wait on next version of go-json which may have some of these crashes fixed (https://github.com/goccy/go-json/commit/4167aefe08213818e5de6914dd6a9d9bea626bf6).

0.4.8 is out, please try an update.

Still a crash in there along with some odd test failures.

Can you try adding this debug option to the code here? I guess that would be easier than me trying to reproduce what the test suite does locally.

while running #15250 with master and this head branch ... I did not really notice any difference

Yeah it's likely that those performance claims are exaggerated, or that we just don't do enough JSON encoding that it makes a significant difference.

0.4.10 is out with a fix for our crash, please update once more.

@silverwind I've given you collaborator access to my fork - so feel free to update

Still another bug present, this time in the decoder it seems. Will check out later.

Bumped to 0.5.1

Not sure if I screwed up or this is a module bug:
could not import github.com/goccy/go-json (/drone/src/vendor/github.com/goccy/go-json/encode.go:262:21: DebugRun not declared by package vm_escaped

OK so looking a bit more closely at the first unit-test error
{
  "push_only":true,
  // ... nil values ...
  {
    "push":true,
    // ... more nil values ...
  }
}
``` doesn't seem to get unmarshalled properly in to  ```go
models.HookEvent{PushOnly:true, ..., HookEvents:models.HookEvents{Push:true, ...}}
``` instead becomes: ```go
models.HookEvent{PushOnly:true, ..., HookEvents:models.HookEvents{Push:false, ...}}

As someone who followed the development of goccy/go-json for a few months, I can not recommend to put it in any sort of production setup as of now. While it is very fast compared to alternatives, it is very much alpha quality in my eyes. I would not want to see it already used in Gitea as Gitea user.
Especially if JSON encoding/decoding is not part of "the critical code path" that somehow limits performance of the whole server, I would not risk it. Maybe give it some time and keep an eye on it, check back when it hits 1.0.0.

@DasSkelett I am in agreement with you on this. Whilst Goccy appears interesting there still appear to be several very important bugs.
https://github.com/goccy/go-json/issues/270

Maybe close this PR and revisit once it's 1.0.

I'm happy to keep updating this tbh. It's a good way to keep an eye on whether this is ready or not.

--- FAIL: TestHTTPClientDownload (0.00s)
    http_client_test.go:255:
        	Error Trace:	http_client_test.go:255
        	Error:      	Should be true
        	Test:       	TestHTTPClientDownload
        	Messages:   	case 1: 'not at beginning of value' should contain 'invalid json'
2021/08/12 11:25:11 ...ules/lfs/endpoint.go:73:endpointFromURL() [E] lfs.endpointFromUrl: unknown url
2021/08/12 11:25:11 ...s/lfs/http_client.go:106:batch() [E] Error decoding json: not at beginning of value
2021/08/12 11:25:11 ...s/lfs/http_client.go:106:batch() [E] Error decoding json: not at beginning of value
--- FAIL: TestHTTPClientUpload (0.00s)
    http_client_test.go:356:
        	Error Trace:	http_client_test.go:356
        	Error:      	Should be true
        	Test:       	TestHTTPClientUpload
        	Messages:   	case 1: 'not at beginning of value' should contain 'invalid json'
FAIL

This one appears to be a difference in the way invalid json is reported.

Yeah, some error messages like that do not seem to match encodings/json, I guess we should report as go-json aims to be a drop-in replacement.

OK it finally looks like we're passing tests!
I think https://github.com/goccy/go-json/issues/275 needs to be fixed and we need to test actually running gitea with this backend but it might actually be getting close.

OK GoCcy now works.
My suspicion is that we shouldn't run with goccy by default but question is whether we can make the JSON variant selectable.
The problem is that as it currently stands modules/json.DefaultJSONHandler is not concurrent safe so we should set choose the JSON variant right at the start of gitea before any other goroutines start that might use it. This likely precludes its use in setting.NewContext.
Currently I've provided a way for the choice to be compiled in at link time by overwriting a variable at link time. e.g. LDFLAGS="-X code.gitea.io/gitea/modules/json.DefaultJSONHandlerType=std".

I also have the question why do we need to make JSON library configurable.
Does it bring more benefits than the complexity?

Sorry I will against make it configurable for end users. It should be a build tag.

I would not even introduce a build tag. If I find something is good enough, just I will use it.
If there is no real benefit, we do not need to introduce too many options/tags.

Just checking the issue tracker of go-json, it still has crash bugs. Maybe revisit again in a few years if it ever becomes crash-free.
I suggest sticking to encoding/json, as it will receive the more developer attention than those unstable/abandoned hobby projects.

Just checking the issue tracker of go-json, it still has crash bugs.
I suggest sticking to encoding/json, as it will receive much more developer attention than those unstable/abandoned hobby projects and is bound to only get faster over time.

I suggest we can close this one and open a new when something is ready.  @zeripath

When I last updated and fixed this PR go-json was working completely fine for Gitea - but the potential issue of there being bugs was a reason why I provided the configuration variable which some reviewers did not like.
@silverwind we're already using json-iterator over encoding/json and I would note that encoding/json has not increased in speed significantly for the entire period time I have been involved in gitea.
However, it's clear that this PR is not going to be merged so I will close it.

I recommend dropping json-iterator as well. It has a number of mind-bogging bugs. Gitea might not hit them currently, but it can in the future.

There is a considerable time penalty to using encoding/json over jsoniterator. You are more than welcome to write the PR and fix the multiple issues were we have relied on jsoniterator error interpretation (this PR has the fixes for those) and then do the performance tests to prove this.

I guess we shouldn't try to fix what aint broken then.
On topic of benchmarks, I do find https://medium.com/geekculture/my-golang-json-evaluation-20a9ca6ef79c from 2021, so I guess you are right, encodings/json is worst:


increase rows in multiline text

is it possible to increase the text area rows for .multilineText?

I came here to ask the same question.

@donaldhughes that's right.
To use your custom class:
let descriptor = ...
descriptor.configuration.cell.cellClass = TallFormTextViewCell.self

Thanks!  It was the .self that I wasn't doing.


Fix #169: stepSize not updated when holding button

There's no way to preempt stepSize in the onValueChanged function, so we have to adjust the set value as the value is changing. This fixes #169 as cleanly as I can manage.

@danshick any chance you'll get back to this? I'd like to include it in 2.2 if possible.

Probably not on any short timetable, sorry.


The nginx-gateway's pod is not ready

Describe the bug
After I deploy nginx gateway fabric by the helm, the nginx-gateway-fabric pod's container - nginx-gateway can't be ready.
To Reproduce
Steps to reproduce the behavior:

Deploy nginx gateway fabric by helm :   helm install ngf oci://ghcr.io/nginxinc/charts/nginx-gateway-fabric --create-namespace -n nginx-gateway
then the pod's status is

$ kubectl get pod -n nginx-gateway
NAME                                        READY   STATUS    RESTARTS   AGE
ngf-nginx-gateway-fabric-5985484bb8-fh8dw   1/2     Running   0          21s

View logs on ngf-nginx-gateway-fabric-5985484bb8-fh8dw

$  kubectl logs ngf-nginx-gateway-fabric-5985484bb8-fh8dw -c nginx-gateway -n nginx-gateway
{"level":"info","ts":"2024-03-12T02:21:40Z","logger":"controller-runtime.healthz","msg":"healthz check failed","statuses":[{}]}
{"level":"info","ts":"2024-03-12T02:21:41Z","logger":"controller-runtime.healthz","msg":"healthz check failed","statuses":[{}]}
{"level":"info","ts":"2024-03-12T02:21:42Z","logger":"controller-runtime.healthz","msg":"healthz check failed","statuses":[{}]}
{"level":"info","ts":"2024-03-12T02:21:43Z","logger":"controller-runtime.healthz","msg":"healthz check failed","statuses":[{}]}

See error
All logs of nginx gateway are in the attachment.
nginx-gateway.log

Expected behavior
My nginx-gateway pod can be ready
Your environment

Version of the NGINX Gateway Fabric - 1.1.0
Version of Kubernetes - 1.24.2
Kubernetes platform - 3 nodes k8s cluster
Details on how you expose the NGINX Gateway Fabric Pod:  Both Nodeport and LoadBalancer can't work well.
Logs of NGINX container:

$ kubectl -n nginx-gateway logs ngf-nginx-gateway-fabric-5985484bb8-fh8dw -c nginx --limit-bytes=1024
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf is not a file or does not exist
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2024/03/12 02:21:19 [notice] 20#20: using the "epoll" event method
2024/03/12 02:21:19 [notice] 20#20: nginx/1.25.3
2024/03/12 02:21:19 [notice] 20#20: built by gcc 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10)
2024/03/12 02:21:19 [notice] 20#20: OS: Linux 3.10.0-1160.81.1.el7.x86_64
2024/03/12 02:21:19 [notice] 20#20: getrlimit(RLIMIT_NOFILE): 65536:6[root@k8s nginx-gateway-fabric-1.1.0]#
[root@k8s nginx-gateway-fabric-1.1.0]#
[root@k8s nginx-gateway-fabric-1.1.0]# kubectl -n nginx-gateway logs ngf-nginx-gateway-fabric-5985484bb8-fh8dw -c nginx
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh
10-listen-on-ipv6-by-default.sh: info: /etc/nginx/conf.d/default.conf is not a file or does not exist
/docker-entrypoint.sh: Sourcing /docker-entrypoint.d/15-local-resolvers.envsh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/20-envsubst-on-templates.sh
/docker-entrypoint.sh: Launching /docker-entrypoint.d/30-tune-worker-processes.sh
/docker-entrypoint.sh: Configuration complete; ready for start up
2024/03/12 02:21:19 [notice] 20#20: using the "epoll" event method
2024/03/12 02:21:19 [notice] 20#20: nginx/1.25.3
2024/03/12 02:21:19 [notice] 20#20: built by gcc 12.2.1 20220924 (Alpine 12.2.1_git20220924-r10)
2024/03/12 02:21:19 [notice] 20#20: OS: Linux 3.10.0-1160.81.1.el7.x86_64
2024/03/12 02:21:19 [notice] 20#20: getrlimit(RLIMIT_NOFILE): 65536:65536
2024/03/12 02:21:19 [notice] 20#20: start worker processes
2024/03/12 02:21:19 [notice] 20#20: start worker process 40
2024/03/12 02:21:19 [notice] 20#20: start worker process 41
2024/03/12 02:21:19 [notice] 20#20: start worker process 42

NGINX Configuration: kubectl -n nginx-gateway exec <gateway-pod> -c nginx -- nginx -T

$ kubectl exec -it ngf-nginx-gateway-fabric-5985484bb8-fh8dw -n nginx-gateway -c nginx --  nginx -T
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful
# configuration file /etc/nginx/nginx.conf:
load_module /usr/lib/nginx/modules/ngx_http_js_module.so;

worker_processes auto;

pid /var/run/nginx/nginx.pid;
error_log stderr info;

events {
  worker_connections 1024;
}

http {
  include /etc/nginx/conf.d/*.conf;
  include /etc/nginx/mime.types;
  js_import /usr/lib/nginx/modules/njs/httpmatches.js;

  default_type application/octet-stream;

  proxy_headers_hash_bucket_size 512;
  proxy_headers_hash_max_size 1024;
  server_names_hash_bucket_size 256;
  server_names_hash_max_size 1024;
  variables_hash_bucket_size 512;
  variables_hash_max_size 1024;

  sendfile on;
  tcp_nopush on;

  server {
    listen unix:/var/run/nginx/nginx-status.sock;
    access_log off;

    location /stub_status {
        stub_status;
    }
  }
}

# configuration file /etc/nginx/conf.d/config-version.conf:

server {
    listen unix:/var/run/nginx/nginx-config-version.sock;
    access_log off;

    location /version {
        return 200 1;
    }
}

# configuration file /etc/nginx/conf.d/http.conf:

upstream invalid-backend-ref {
    random two least_conn;
    zone invalid-backend-ref 512k;

    server unix:/var/lib/nginx/nginx-500-server.sock;
}

server {
    listen unix:/var/lib/nginx/nginx-502-server.sock;
    access_log off;

    return 502;
}

server {
    listen unix:/var/lib/nginx/nginx-500-server.sock;
    access_log off;

    return 500;
}

# Set $gw_api_compliant_host variable to the value of $http_host unless $http_host is empty, then set it to the value
# of $host. We prefer $http_host because it contains the original value of the host header, which is required by the
# Gateway API. However, in an HTTP/1.0 request, it's possible that $http_host can be empty. In this case, we will use
# the value of $host. See http://nginx.org/en/docs/http/ngx_http_core_module.html#var_host.
map $http_host $gw_api_compliant_host {
    '' $host;
    default $http_host;
}

# Set $connection_header variable to upgrade when the $http_upgrade header is set, otherwise, set it to close. This
# allows support for websocket connections. See https://nginx.org/en/docs/http/websocket.html.
map $http_upgrade $connection_upgrade {
    default upgrade;
    '' close;
}

# configuration file /etc/nginx/mime.types:

types {
    text/html                                        html htm shtml;
    text/css                                         css;
    text/xml                                         xml;
    image/gif                                        gif;
    image/jpeg                                       jpeg jpg;
    application/javascript                           js;
    application/atom+xml                             atom;
    application/rss+xml                              rss;

    text/mathml                                      mml;
    text/plain                                       txt;
    text/vnd.sun.j2me.app-descriptor                 jad;
    text/vnd.wap.wml                                 wml;
    text/x-component                                 htc;

    image/avif                                       avif;
    image/png                                        png;
    image/svg+xml                                    svg svgz;
    image/tiff                                       tif tiff;
    image/vnd.wap.wbmp                               wbmp;
    image/webp                                       webp;
    image/x-icon                                     ico;
    image/x-jng                                      jng;
    image/x-ms-bmp                                   bmp;

    font/woff                                        woff;
    font/woff2                                       woff2;

    application/java-archive                         jar war ear;
    application/json                                 json;
    application/mac-binhex40                         hqx;
    application/msword                               doc;
    application/pdf                                  pdf;
    application/postscript                           ps eps ai;
    application/rtf                                  rtf;
    application/vnd.apple.mpegurl                    m3u8;
    application/vnd.google-earth.kml+xml             kml;
    application/vnd.google-earth.kmz                 kmz;
    application/vnd.ms-excel                         xls;
    application/vnd.ms-fontobject                    eot;
    application/vnd.ms-powerpoint                    ppt;
    application/vnd.oasis.opendocument.graphics      odg;
    application/vnd.oasis.opendocument.presentation  odp;
    application/vnd.oasis.opendocument.spreadsheet   ods;
    application/vnd.oasis.opendocument.text          odt;
    application/vnd.openxmlformats-officedocument.presentationml.presentation
                                                     pptx;
    application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
                                                     xlsx;
    application/vnd.openxmlformats-officedocument.wordprocessingml.document
                                                     docx;
    application/vnd.wap.wmlc                         wmlc;
    application/wasm                                 wasm;
    application/x-7z-compressed                      7z;
    application/x-cocoa                              cco;
    application/x-java-archive-diff                  jardiff;
    application/x-java-jnlp-file                     jnlp;
    application/x-makeself                           run;
    application/x-perl                               pl pm;
    application/x-pilot                              prc pdb;
    application/x-rar-compressed                     rar;
    application/x-redhat-package-manager             rpm;
    application/x-sea                                sea;
    application/x-shockwave-flash                    swf;
    application/x-stuffit                            sit;
    application/x-tcl                                tcl tk;
    application/x-x509-ca-cert                       der pem crt;
    application/x-xpinstall                          xpi;
    application/xhtml+xml                            xhtml;
    application/xspf+xml                             xspf;
    application/zip                                  zip;

    application/octet-stream                         bin exe dll;
    application/octet-stream                         deb;
    application/octet-stream                         dmg;
    application/octet-stream                         iso img;
    application/octet-stream                         msi msp msm;

    audio/midi                                       mid midi kar;
    audio/mpeg                                       mp3;
    audio/ogg                                        ogg;
    audio/x-m4a                                      m4a;
    audio/x-realaudio                                ra;

    video/3gpp                                       3gpp 3gp;
    video/mp2t                                       ts;
    video/mp4                                        mp4;
    video/mpeg                                       mpeg mpg;
    video/quicktime                                  mov;
    video/webm                                       webm;
    video/x-flv                                      flv;
    video/x-m4v                                      m4v;
    video/x-mng                                      mng;
    video/x-ms-asf                                   asx asf;
    video/x-ms-wmv                                   wmv;
    video/x-msvideo                                  avi;
}

Additional context
Add any other context about the problem here. Any log files you want to share.

Hi @Yelijah I see the following error in the nginx gateway logs:

{"level":"error","ts":"2024-03-12T02:21:19Z","logger":"eventLoop.eventHandler","msg":"Failed to update NGINX configuration","batchID":1,"error":"failed to reload NGINX: failed to send the HUP signal to NGINX main: operation not permitted"

This error would cause the problem you are seeing where the nginx-gateway Pod isn't reporting as ready.
To resolve you will need to tweak the security context of the nginx-gateway Pod. See this troubleshooting guide for details: https://docs.nginx.com/nginx-gateway-fabric/how-to/monitoring/troubleshooting/.

Hi @Yelijah I see the following error in the nginx gateway logs:

{"level":"error","ts":"2024-03-12T02:21:19Z","logger":"eventLoop.eventHandler","msg":"Failed to update NGINX configuration","batchID":1,"error":"failed to reload NGINX: failed to send the HUP signal to NGINX main: operation not permitted"

This error would cause the problem you are seeing where the nginx-gateway Pod isn't reporting as ready.
To resolve you will need to tweak the security context of the nginx-gateway Pod. See this troubleshooting guide for details: https://docs.nginx.com/nginx-gateway-fabric/how-to/monitoring/troubleshooting/.

Thank you for your help


Update dependency: deps/kevm_release

Looks like it requires updating expected output — will push it in a bit.


Add SOLASTAR to token list

[x] I will not ping the Discord about this pull request.

Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR
At minimum each entry should have

Token Address:  2eZ45YBgQEftoxEVyCTWEULLNkDxSVSMrwv7LXiZn4sk
Token Name: SOLASTAR
Token Symbol: STAR
Logo: https://user-images.githubusercontent.com/85065112/120107921-11e98c00-c18d-11eb-9fa4-82c7903962bb.png
Link to the official homepage of token: https://twitter.com/starsolana
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

@bartosz-lipinski i have fixed the error

website doesnt exsists.


Add darryk10 as rules OWNERS as reviewer

Signed-off-by: darryk10<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
I would like propose myself as a reviewer of rules in falcosecurity/falco.
After actively working and contributing to this repository over the past year and a half with new falco rules and proactively reviewing new PRs related to rules, I want to propose myself as a reviewer of rules and spend more time working on falco rules, helping the project grows.
Does this PR introduce a user-facing change?:

docs: add darryk10 to rules OWNERS as reviewer

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: darryk10
To complete the pull request process, please assign mstemm after the PR has been reviewed.
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the falcosecurity org. You can then trigger verification by writing /verify-owners in a comment.

darryk10

User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

LGTM label has been added.  Git tree hash: 12fed952876933a34ef94a09bb6c08491d51b27b

@darryk10 has been actively helping the community (reviewing PRs and asking questions in the slack channel), I would love to see him step up as a Falco rule reviewer. With his expertise and dedication, we will all be beneficials.

As a contributor of Falco and some of its rules, I think @darryk10 really deserves this, +1 from my side!

As said in the community call, I'm a strong supporter of this. +1 for me 👍🏼

+1 for me too!
Since we reached a consensus, I'll invite @darryk10 to the org, then we can merge this :)

+1 for me too!
Since we reached a consensus, I'll invite @darryk10 to the org, then we can merge this :)

Thanks @leogr and Thanks all for the support. I accepted the invite :)

/verify-owners

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: darryk10, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Closing and reopening to trigger the CI
/close

@leogr: Closed this PR.

In response to this:

Closing and reopening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/hold
Waiting for the CI

/hold cancel


Update docs.md

fixed typo
External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

[x] Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description
Please describe your pull request.
Thank you!

Hi @siredmar and thanks for your contribution.
These kind of PRs need to go first to master branch, and then we will propagate it. Can you please submit it to master? You can do this by 1) rebasing your patch-1 branch on latest master and then edit this PR to target master or 2) close this PR and open a new one for master.

Fixed recently at https://github.com/mendersoftware/mender-docs/pull/1217


Test new patch

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Same compiler error:
2021-02-09T00:20:28.8914708Z -- The Fortran compiler identification is unknown
2021-02-09T00:20:28.8945467Z CMake Error at model-drivers/DUNN__MD_292677547454_000/CMakeLists.txt:40 (project):
2021-02-09T00:20:28.8946125Z   The CMAKE_CXX_COMPILER:
2021-02-09T00:20:28.8946342Z
2021-02-09T00:20:28.8946981Z     /home/conda/feedstock_root/build_artifacts/kim-api_1607958627046/_build_env/bin/x86_64-conda-linux-gnu-c++
2021-02-09T00:20:28.8947498Z
2021-02-09T00:20:28.8947812Z   is not a full path to an existing compiler tool.
2021-02-09T00:20:28.8948042Z
2021-02-09T00:20:28.8948378Z   Tell CMake where to find the compiler by setting either the environment
2021-02-09T00:20:28.8948835Z   variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
2021-02-09T00:20:28.8949272Z   to the compiler, or to the compiler name if it is in the PATH.
2021-02-09T00:20:28.8949511Z
2021-02-09T00:20:28.8949655Z
2021-02-09T00:20:28.8964834Z CMake Error at model-drivers/DUNN__MD_292677547454_000/CMakeLists.txt:40 (project):
2021-02-09T00:20:28.8965343Z   The CMAKE_C_COMPILER:
2021-02-09T00:20:28.8965557Z
2021-02-09T00:20:28.8966163Z     /home/conda/feedstock_root/build_artifacts/kim-api_1607958627046/_build_env/bin/x86_64-conda-linux-gnu-cc
2021-02-09T00:20:28.8966490Z
2021-02-09T00:20:28.8966795Z   is not a full path to an existing compiler tool.
2021-02-09T00:20:28.8967010Z
2021-02-09T00:20:28.8967356Z   Tell CMake where to find the compiler by setting either the environment
2021-02-09T00:20:28.8967791Z   variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
2021-02-09T00:20:28.8968229Z   the compiler, or to the compiler name if it is in the PATH.
2021-02-09T00:20:28.8968454Z
2021-02-09T00:20:28.8968581Z
2021-02-09T00:20:28.8988539Z CMake Error at model-drivers/DUNN__MD_292677547454_000/CMakeLists.txt:40 (project):
2021-02-09T00:20:28.8989410Z   The CMAKE_Fortran_COMPILER:
2021-02-09T00:20:28.8989683Z
2021-02-09T00:20:28.8990499Z     /home/conda/feedstock_root/build_artifacts/kim-api_1607958627046/_build_env/bin/x86_64-conda-linux-gnu-gfortran
2021-02-09T00:20:28.8990894Z
2021-02-09T00:20:28.8991287Z   is not a full path to an existing compiler tool.
2021-02-09T00:20:28.8991551Z
2021-02-09T00:20:28.8991963Z   Tell CMake where to find the compiler by setting either the environment
2021-02-09T00:20:28.8992525Z   variable "FC" or the CMake cache entry CMAKE_Fortran_COMPILER to the full
2021-02-09T00:20:28.8993067Z   path to the compiler, or to the compiler name if it is in the PATH.
2021-02-09T00:20:28.8993358Z
2021-02-09T00:20:28.8993531Z
2021-02-09T00:20:28.9014600Z -- Configuring incomplete, errors occurred!


policy: Add Logic to Prevent Improper Allows

The reserved:world entity (which represents <IP_ADDRESS>/0
and ::/0) does not currently work in Deny policies
to prohibit any Allow policy that specifies fromCIDR
for ingress policies or toCIDR for egress policies.
This is because no logic prevents CIDR Allow policies
from being inserted into the policy tables when
reserved:world is specified as a denied entity and the
datapath logic is written with the assumption that
contradictory CIDR policies will not be inserted into
the policy tables. Consequently, the datapath will
pass packets that should otherwise be dropped.
The logic in this PR prevents allow rules from
being selected by the policy map constructor if
they are CIDR policies when a "deny-world"
policy exists within the same rule selection logic.
Fixes: #15198
policy: Fixed bug where any CIDR based "Allow" policy took precedence over any "Deny" policy that used the "World" entity.

Unfortunately I don't think it's going to work to just special-case world identity and handle it specially. Wider CIDRs that are narrower than world can also reproduce this problem, for instance if you install a deny for <IP_ADDRESS>/24 and then allow for <IP_ADDRESS>/32. Here's a test that demonstrates the issue. This diff applies on top of the current version of the PR, and causes a policy test failure:
$ git di
diff --git a/pkg/policy/distillery_test.go b/pkg/policy/distillery_test.go
index c2d997c4dbf7..670b6f96b677 100644
--- a/pkg/policy/distillery_test.go
+++ b/pkg/policy/distillery_test.go
@@ -8,6 +8,7 @@ import (
        "fmt"
        "io"
        stdlog "log"
+       "net/netip"
        "strings"
        "testing"

@@ -17,6 +18,7 @@ import (
        "github.com/cilium/cilium/pkg/identity"
        "github.com/cilium/cilium/pkg/identity/cache"
        "github.com/cilium/cilium/pkg/labels"
+       "github.com/cilium/cilium/pkg/labels/cidr"
        "github.com/cilium/cilium/pkg/policy/api"
        "github.com/cilium/cilium/pkg/policy/trafficdirection"
        "github.com/cilium/cilium/pkg/testutils"
@@ -1179,6 +1181,33 @@ var (
                owners:           map[MapStateOwner]struct{}{},
        }

+       worldSubnetIdentity = identity.NumericIdentity(16325)
+       worldSubnet         = api.CIDR("<IP_ADDRESS>/24")
+       worldSubnetRule     = api.CIDRRule{
+               Cidr: worldSubnet,
+       }
+       lblWorldSubnet       = cidr.GetCIDRLabels(netip.MustParsePrefix(string(worldSubnet)))
+       ruleL3L4__DenySubnet = api.NewRule().
+                               WithIngressDenyRules([]api.IngressDenyRule{{
+                       IngressCommonRule: api.IngressCommonRule{
+                               FromCIDRSet: api.CIDRRuleSlice{worldSubnetRule},
+                       },
+               }}).
+               WithEgressDenyRules([]api.EgressDenyRule{{
+                       EgressCommonRule: api.EgressCommonRule{
+                               ToCIDRSet: api.CIDRRuleSlice{worldSubnetRule},
+                       },
+               }}).
+               WithEndpointSelector(api.WildcardEndpointSelector)
+       mapKeyL3L4__DenySubnetIngress = Key{worldSubnetIdentity.Uint32(), 0, 0, trafficdirection.Ingress.Uint8()}
+       mapKeyL3L4__DenySubnetEgress  = Key{worldSubnetIdentity.Uint32(), 0, 0, trafficdirection.Egress.Uint8()}
+       mapEntryL3L4__DenySubnet      = MapStateEntry{
+               ProxyPort:        0,
+               DerivedFromRules: labels.LabelArrayList{nil},
+               IsDeny:           true,
+               owners:           map[MapStateOwner]struct{}{},
+       }
+
        worldIPIdentity = identity.NumericIdentity(16324)
        worldCIDR       = api.CIDR("<IP_ADDRESS>/32")
        worldCIDRRule   = api.CIDRRule{
@@ -1213,6 +1242,7 @@ func Test_EnsureDeniesPrecedeAllowsForDenyWorld(t *testing.T) {
                identity.NumericIdentity(identityFoo): labelsFoo,
                identity.ReservedIdentityWorld:        labels.LabelWorld.LabelArray(),
                worldIPIdentity:                       lblWorldIP,
+               worldSubnetIdentity:                   lblWorldSubnet.LabelArray(),
        }
        selectorCache := testNewSelectorCache(identityCache)

@@ -1226,6 +1256,10 @@ func Test_EnsureDeniesPrecedeAllowsForDenyWorld(t *testing.T) {
                        mapKeyL3L4__DenyWorldIngress: mapEntryL3L4__DenyWorld,
                        mapKeyL3L4__DenyWorldEgress:  mapEntryL3L4__DenyWorld,
                }},
+               {0, api.Rules{ruleL3L4__DenySubnet, ruleL3L4__AllowWorldIP}, MapState{
+                       mapKeyL3L4__DenySubnetIngress: mapEntryL3L4__DenyWorld,
+                       mapKeyL3L4__DenySubnetEgress:  mapEntryL3L4__DenyWorld,
+               }},
        }
        for _, tt := range tests {
                repo := newPolicyDistillery(selectorCache)


editor.showUnused: Access modifiers declared in the class still highlighted as unused

I have enabled editor.showUnused with following codes in the usersettings
{     "editor.showUnused": true,     "workbench.colorCustomizations": {         "editorUnnecessaryCode.border": "#a10906",         "editorUnnecessaryCode.foreground": "#a10906",     } }

I have declared a access modifier (private,protected or public) as private $db and assigned some value in the constructor.
But in the visual studio code IDE, i can still view the error border line which indicating the variable as unused variable.

Please file this against your PHP extension


Compiler crash on a certain use (possibly incorrect) of ? syntax sugar

As the compiler says it’s definitely a compiler bug… here’s a report:
An internal compiler expectation was broken.
This is definitely a compiler bug.
Please file an issue here: <https://github.com/roc-lang/roc/issues/new/choose>
a Expr::TrySuffix expression was not completely removed in desugar_value_def_suffixed
Location: crates/compiler/can/src/expr.rs:1122:40

This is the code that triggered this:
latestCommitTimestampFromLog : Str -> Result I128 [InvalidNumStr, NotFound]
latestCommitTimestampFromLog = \logOutput ->
    logOutput
        |> Str.splitFirst? "\n"
        |> \{ before: entry } -> Str.splitFirst? entry " "
        |> \{ after: isoTimestamp } -> Str.toI128 isoTimestamp
        |> Result.map \timestampSeconds -> 1000 * timestampSeconds

In my editor the first three lines of the body are highlighted with a curvy underline in red, but I’m not sure if that’s significant.

I should also mention that I was in the process of converting my function from Result.try to ?, so below is the last working version before I attempt to migrate the second Str.splitFirst call to ?. (you might tell me if I’m doing something wrong there)
latestCommitTimestampFromLog : Str -> Result I128 [InvalidNumStr, NotFound]
latestCommitTimestampFromLog = \logOutput ->
    logOutput
        |> Str.splitFirst? "\n"
        |> \{ before: entry } -> Str.splitFirst entry " "
        |> Result.try \{ after: isoTimestamp } -> Str.toI128 isoTimestamp
        |> Result.map \timestampSeconds -> 1000 * timestampSeconds


out_crea_options has no effect

arosics version: 1.8.0
Python version: 3.8
Operating System: Win11/WSL1

Description
Global image co-registration works as expected. However ,out_crea_options has no effect on the output image.
What I Did
im_reference = 'image_reference.tif'
im_target = 'image_target.tif'

CR = COREG(
    im_reference,
    im_target,
    fmt_out='GTiff',
    path_out=f"{im_target.split('.tif')[0]}_coreg.tif",
    ws=(256, 256),
    max_shift=10,
    max_iter=5,
    nodata=(None, None),
    out_crea_options=["COMPRESS=DEFLATE", "BIGTIFF=YES", "ZLEVEL=9", "BLOCKXSIZE=512", "BLOCKYSIZE=512"]
)

CR.correct_shifts()

The above code executes without any errors, but the output image is uncompressed. Does anybody know what might be the problem?

Thanks for reporting. It seems like the parameter out_crea_options was not passed through correctly in AROSICS when using the global co-registration and if no resampling of the co-registered output is needed.
This should now be fixed in version 1.8.1 which will be soon become available on PyPI and conda-forge.


Support stepSize? couldn't figure out how to add steps on the radar type of chart.

Result from ChartJs

Result using chartjs-to-image with same config

expected result:
step size should be 1,2,3,4,5. not 2.xx, 2.xx, 2.xx, 3.xx, 3.xx .....

Hi @rupertbulquerin, can you provide a full chart config?  Step size is supported, so it means there's something wrong with the config, or you are not setting the correct Chart.js version.

Hi @typpo, thanks for your reply. I'm using this config for both examples above with minimal changes to the background colors.
const data = {
    labels: userdataset.labels,
    datasets: [{
      label: chartname,
      data: userdataset.scores,
      fill: true,
      backgroundColor: '#407CCE54',
    }]
  };

  const elementsFormat = {
    line: {
      borderWidth: 3
    },
    point: {
      radius: 5,
      hoverRadius: 10,
      backgroundColor: 'white',
      borderColor: 'rgb(64, 124, 206)',
      borderWidth: 2
    },
  };

  const pluginsFormat = {
    legend: {
      display: false
    },
    title: {
      display: false,
      text: chartname,
      color: '#111',
      font: {
        size: 16,
        family: 'nuninto'
      }
    },
  };

  const scalesFormat = {
    r: {
      suggestedMin: 0,
      suggestedMax: 5,
      angleLines: {
        color: '#fff'
      },
      grid: {
        color: '#fff'
      },
      pointLabels: {
        color: 'black',
        font: {
          size: '13'
        }
      },
      ticks: {
        backdropColor: '#231F29',
        color: 'white'
      }
    }
  };

  const config = {
    type: 'radar',
    data: data,
    options: {
      responsive: true,
      maintainAspectRatio: false,
      borderColor: 'rgba(200, 200, 200, 0.05)',
      labels: {
        font: {
          size: 14,
          family: 'nunito'
        },
      },
      elements: elementsFormat,
      scales: scalesFormat,
      plugins: pluginsFormat
    },
  };

It looks like this chart requires Chart.js version >= 3.  I've release 1.1.0 of this library, which adds chart.setChartJsVersion.  You can use to set the appropriate Chart.js version:
chart.setChartJsVersion('3')

Please update and give it a try!

Hi @typpo, it works now. Thank you for this update!


Current order of traversal through minigraph is incorrect

Use breadth first traversal instead of depth first. The nodes order of execution is wrong now

Apparently traversal depends on executor. No need for changes unless we want to enforce breadth first. Depth first is still fine if we want to do immediate execution.


Bug with the Activity Rings component

The Activity Rings tends to crash from time to time, I would assume this is a bug with the React Native Skia library.
What's the cause?

Passing a path value inside a useDerivedValue hook seems to be causing the problem. The problem is that the overclamp of the spring value goes above one. This is a problem with the Skia library that will be fixed in later installments. However, we may have to wait for Expo to support the latest version.

There may be nothing to do than just wait!

Will look into refactoring the code using useComputedValue.

As I suspected, the problem was with the libraries. I used the dev build with the newest versions of the libraries, and it's completely stable.
Might be something worth considering when deploying so we can have a crash-free app to demo.

Reopened this to explain the crash problem a little better
So why does the component crash, and what are the solutions to avoid this?
Reasons:

Using the useDerivedValue hook from the Reanimated library in tandem with the Skia library causes a crash.
We're not using the latest iterations of Reanimated and Skia because Expo isn't compatible with them. Do npx expo install and see for yourself. Expo 49 can only reach Reanimated 3.3.0 and Skia 0.1.196. We need both to be at their latest versions, which the Expo does not allow in its current iteration. See this issue for more details.

Solutions:

Remove the animation for now, which would remove the useDerivedValue hook that is rendering the path with the trim value to create an animation.
Switch to the development build through npx expo prebuild, and then use npx expo run:android to run the build. This way we can use the latest versions of the libraries. Makes deployment a little harder but not impossible. We can use EAS build.
Wait for Expo 50, which may provide compatibility with the latest versions. The problem is we don't really have time for that right now. Expo 50 probably takes 2-3 months earliest to be released.


candle-transformers-0.8.1 seems to have an error

The output log is as follows:
 Compiling candle-transformers v0.8.1
error[E0716]: temporary value dropped while borrowed
   --> /home/neptune/.cargo/registry/src/github.com-1ecc6299db9ec823/candle-transformers-0.8.1/src/models/chinese_clip/text_model.rs:157:22
    |
155 |         let token_type_ids = match token_type_ids {
    |             -------------- borrow later stored here
156 |             Some(token_type_ids) => token_type_ids,
157 |             None => &self.token_type_ids.i((.., 0..seq_length))?,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
    |                      |                                         |
    |                      |                                         temporary value is freed at the end of this statement
    |                      creates a temporary value which is freed while still in use
    |
help: consider using a `let` binding to create a longer lived value
    |
155 ~         let binding = self.token_type_ids.i((.., 0..seq_length))?;
156 ~         let token_type_ids = match token_type_ids {
157 |             Some(token_type_ids) => token_type_ids,
158 ~             None => &binding,
    |

error[E0716]: temporary value dropped while borrowed
   --> /home/neptune/.cargo/registry/src/github.com-1ecc6299db9ec823/candle-transformers-0.8.1/src/models/stable_diffusion/vae.rs:399:39
    |
397 |         let xs = match &self.post_quant_conv {
    |             -- borrow later stored here
398 |             None => xs,
399 |             Some(post_quant_conv) => &post_quant_conv.forward(xs)?,
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^-
    |                                       |                          |
    |                                       |                          temporary value is freed at the end of this statement
    |                                       creates a temporary value which is freed while still in use
    |
help: consider using a `let` binding to create a longer lived value
    |
397 ~         let binding = post_quant_conv.forward(xs)?;
398 ~         let xs = match &self.post_quant_conv {
399 |             None => xs,
400 ~             Some(post_quant_conv) => &binding,
    |

Most likely you need to update your rust toolchain, see #2621 which looks very similar.

The problem has been solved after updating the rust toolchain, thank you！


filters: prevent spurious cancellation callbacks from the gRPC error path

Description: Platform filters could fail to correctly transition to a completed state due to the lack of a response body on gRPC error responses. This resulted in spurious cancellation callbacks when the filter was scheduled for destruction due to the invalid "incomplete" status of the stream.
Risk Level: Low
Testing: Integration, Local & CI
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

Hilariously, it looks like the Kotlin error integration tests have been relying on this behavior to pass. Fix incoming.

Thanks @mattklein123!