Adding mongoproto.OpDelete and mongoproto.OpUpdate to cmd/pcap_converter

Adding mongoproto.OpDelete and mongoproto.OpUpdate to 'pcap_converter' now that they're supported in tmc/mongoproto after this PR was merged: https://github.com/tmc/mongoproto/pull/2.
This resolves 2 of 3 missing ops in #40, so I will close #40 if this is merged and open a getmore-specific issue for the final missing op.
Example update op:
$ bsondump flashback.bson 2>/dev/null | grep \"op\":\"update\" | head -1
{"ns":"test.lag_check","ts":{"$date":"2016-10-14T19:02:19.400Z"},"op":"update","query":{"_id":1},"updateobj":{"_id":1,"x":1}}

Example delete (remove) op:
$ bsondump flashback.bson 2>/dev/null | grep \"op\":\"remove\" | head -1
{"ns":"test.items","ts":{"$date":"2016-10-14T19:03:38.380Z"},"op":"remove","query":{"_id":{"$oid":"58012bb839f7e32dab46b8ae"}}}

Any thoughts/suggestions appreciated!

Thanks!


fix(angular): remove back-button when swipe back to last view

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (npm run build) was run locally and any changes were pushed
[x] Lint (npm run lint) has passed locally and any fixes were made for failures

If you want tests for this I'll need some guidance.
Pull request type

Please check the type of change your PR introduces:

[x] Bugfix

What is the current behavior?

Issue Number: #18074
The issue is pretty well described in the issue report. When you swipe to go back to the root page of the stack, the css class can-go-back is set regardless.
What is the new behavior?

The stack will now check that there are at least one more view in the stack before applying the can-go-back css class.

Does this introduce a breaking change?

[x] No

Other information

Fixed by Manu in #18977


Opt-in mechanism for behavior of build analysis check

As part of the work in https://github.com/dotnet/arcade/issues/13309, the runtime team wants the build analysis check to report success if all the errors found by the analysis have a known issue associated with it. Instead of making all repos participating in build analysis to adapt to this change, we should think of a way to make this feature opt-in. Either via some configuration on the service side, or on the repository.

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description

I think we should do this in two phases:

While we enable the functionality and need to iterate quickly we can use a table in Azure. This allows us to turn the feature on or off quickly, as well as easily modifying the entity's schema as needed. The disadvantage here is that configuration is not discoverable by the repo owners, but this can be mitigated by providing docs.

Once we are through phase 3 and have worked out any kinks with the feature, we transition to a checked in file in the repository. By this point we will know what, if any other levers we want to include in the feature, as well as give better control to repo owners.

Right now we probably only care about configuring the check by repo and branch, but some possible additional configuration points that might be interesting to include at some point based on repo feedback:

behavior for specific repo paths, build legs or tests
threshold of occurrences of the known issues that are allowed to merge the PR
age of the known issues
different behaviors for repository or infra known issues

Note: I did not consider adding full fledged feature flags to the project using an azure app configuration store as:

It seemed overkill for this purpose
Adds a new Azure resource instead of reusing the project's storage account
dnceng does not yet have an established process for the management of feature flags.

I think is a great idea :) a table give us the ability to move things around easily! :) and in this project tables are our friends!
let's start with that and as you said when this is more stable, we can transition to a checked in file!


fix: .d.ts exports

I had always fought with importing alasql in typescript...
The solution I used -
declare module "alasql";
in my own typings.d.ts files, and losing all of the types for it.
Because -
previous exports didn't reflect what was actually exported from the library.
previously:
import alasql from "alasq";
gave typings, but alasql was undefined.
import * as alasql gave the correct imported value, but typscript threw error "import("[..]/node_modules/alasql/types/alasql")' has no call signatures"\
Now you can
import * as alasql from "alasq";
or
import alasql = require("alasql")
and both give valid types AND is callable at runtime
This could be fixed - ir the actual js exports, which would be more dangerous, or just in typings. So I chose this route.

Thank you!

Released as part of v4.0.4


Display Team Lead first in the Itinerary Details List (#1834)

This is my first PR. Be gentle 😄.
Esthetically – I think we should display ”LastName, FirstName” instead of ”FirstName LastName”.

I would like to gently welcome you to the repository with your first PR @c0g1t8 😺
Thanks!

@stevejgordon @c0g1t8 yes lets open up an issue to get that done.  But merging this PR for now, thanks @c0g1t8


retry failed requests

Sometimes with multiple spreadsheets the request might time-out, or the proxy might fail.
Is there any way to force a retry on the failed request / handle the error?

Used this for a client and I'd love this as well. He was using a wordpress plugin to do the same thing and it was failing at a very high rate. Tabletop is working much better but it still gets the odd failure. His budget is out so I can't help ( :-1: ) but if this was added I'd definitely update.

There's some error handling now that can help folks DIY this.


CNV-30572: Checkbox in SSH modal is not behaving correctly

📝 Description
Fixing wrong behavior for checkbox at Customize VM flow
🎥 Demo
Before:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/cbb69bfb-e455-4d41-8bfb-aab7ae889373
After:
https://github.com/kubevirt-ui/kubevirt-plugin/assets/67270715/a9f8688b-a9eb-4715-82c2-1d02be30018f

/retest


CLI Demo for testing GUI.

Query the jackpot result:

default (unlocked) >>> game_list_result_transactions 300298
[{
    "game_id": 0,
    "data": null
  },{
    "game_id": 1,
    "data": {
      "play_owner": "XTSGh3Tcd3tMcDi1Rvoc8BuBP9UGwgxzFg4F",
      "jackpot_owner": "XTSGh3Tcd3tMcDi1Rvoc8BuBP9UGwgxzFg4F",
      "play_amount": 1000,
      "jackpot_received": 0,
      "odds": 2,
      "lucky_number": 2
    }
  }
]

some other api demos:
https://github.com/bitsuperlab/cpp-play/blob/game/tests/bdd_tests/features/step_definitions/game_steps.rb


Pasting in OneNote will not preserve the line break

Copy the code block from highlight.js demo and paste it in OneNote. The code block will be changed into single line.

I don't have OneNote, but I've heard no other issues similar to this and cutting and pasting just now from a block into VS Code has no issues at all.
Perhaps this is a bug with OneNote?
What if you paste it into a text editor or Notepad or such on your computer, are the line breaks preserved then?

Weekend ping.

Hi,
Time flies (2 years ago :))!
If I select the code block like this:

The result is:

OneNote: No
Word: Yes
Notepad++: Yes

If I select one more line like this:

Then OneNote works, too.

I think it is caused by some CSS stylesheet difference between OneNote and web. That is fine.

Weird.  I dunno if it has anything to do with CSS.  Sounds like a bug in OneNote though if it works in Word and Notepad++ - and sadly we can't fix OneNote bugs.  Closing this.
Out of curiosity, which web browser are you using?  Have you tried a different browser to see if it makes a difference?
If you keep poking around and find some sort of CSS fix that is within our power, please let us know.

I use QtWebEngine, which is based on Chromium, and Chrome itself.
Change to inline-block will solve this in OneNote, though I am not sure if it is proper.

Well traditionally code snippets are a block, not an inline-block - so I don't think that's something we can just change.  That's very strange that that would fix it though.

I'd suggest filing a support issue with OneNote.


Managing Product, it is reference data or instance data?

It is unclear if Product is intended to be reference data or instance data about the product.
Is it product.description that is displayed in the tractor MICS?  Asking for a friend.
Similar with with Packaged Product:
https://adaptstandard.org/docs/packaged-product/
Here I see:
https://adaptstandard.org/docs/packaged-product-instance/
With the increased awareness and need for Traceability, key data element identifiers would be valuable to capture specific instances of a product.  Or we burying them into Context Items?
What about seed size instance related information?  Can there be a general Measument component that the various product attributes are mapped into instead of specific qualified types?

@dubnemo The documentation out on the site is out-of-date.  We will be publishing an update shortly.
Short answer: Product is reference information.  The PackagedProduct/Instance components are not included in the 1.0 scope.  See https://github.com/ADAPT/Standard/issues/117
The intent is not to bury traceability/supply chain things in context items or to omit them permanently.  Traceability and observations are two big topics we will be pivoting to following work to wrap up 1.0.


Encoding issues

Python version: 3.1.5
Bandcamp-dl version: 0.0.7-04
url: https://blankbanshee.bandcamp.com/album/blank-banshee-1
Describe the issue: Encoding issue with tracks, ('charmap' codec can't encode characters in positions 90-94) Seems to be with non-english characters.

Bandcamp-dl supports Python version 3.5 and up. Possibly try downgrading to a version prior to the move away from older versions (Or updating Python itself)

Issue persists even after updating to newest version of Python and verifying that said version of Python is installed.

I believe I've found the error in both this and #99 however it was something that was a bug/quirk in the standard library (Not one of the modules we use or our code) that was fixed in 3.6.0 (UTF-8 headers) I have an inkling that while you upgraded the new version isn't being used (as I can reproduce this bug in 3.5.2 but not 3.6.0)
I know how to fix, just might take a bit.

Issue persists even on update.

opical-hysteria'charmap' codec can't encode characters in position 97-105: chara
cter maps to
Downloading failed..

Using Python 3.6.0 and bandcamp-dl version 0.0.7-06

I can't seem to duplicate this, does it only happen on this new url you are using? (I don't recognize the trackname in your latest error)

It's not limited to that single track, seems to happen with tracks with non-Latin characters in them. For example:
`Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.
C:\Users[REDACTED]>bandcamp-dl https://roex1.bandcamp.com/album/geofront
'charmap' codec can't encode characters in position 78-83: character maps to
Downloading failed..
C:\Users[REDACTED]>`

Python 3.6.0:
C:\Users\Anthony\AppData\Local\Programs\Python\Python36-32\python.exe C:/GitHub/bandcamp-dl/bandcamp_dl/bandcamp_dl.py https://roex1.bandcamp.com/album/geofront
(9/9) [==================================================] :: Finished: 09 - outro

Python 3.5.2:
C:\Users\Anthony\AppData\Local\Programs\Python\Python35-32\python.exe C:/GitHub/bandcamp-dl/bandcamp_dl/bandcamp_dl.py https://roex1.bandcamp.com/album/geofront
(9/9) [==================================================] :: Finished: 09 - outro

Python 3.4.4:
C:\Python34\python.exe C:/GitHub/bandcamp-dl/bandcamp_dl/bandcamp_dl.py https://roex1.bandcamp.com/album/geofront
(9/9) [==================================================] :: Finished: 09 - outro

I've had no luck reproducing this at all:

Issue resolved after repairing Python and removing older installations.


Disable dnssec

Disabled DNSSEC validation with an option to reenable it
This is a rework of PR #50 to change from an optional disable to a mandatory disable with an option enable

This is technically a "breaking" change from our current implementation (dnssec is now off when it was previously on), but one we've discussed and one I doubt will adversely affect anyone

Particular thanks for @janfux for doing the leg work <3


Fix ORC related failed UT

@rui-mo could you have a look for this PR

Thanks. Can we open this change to Velox upstream? We can pick them back to this branch.

Thanks. Can we open this change to Velox upstream? We can pick them back to this branch.

There are already some PR's Including this part of logic, such as 6156 and 6240, Do you think there is a need to submit a new PR？cc @Yuhta

@chenxu14 Thanks, I see. Maybe we can keep this PR in our local repo to get ORC work with minimal change.

@chenxu14 Thanks, I see. Maybe we can keep this PR in our local repo to get ORC work with minimal change.

@rui-mo any update here?

@chenxu14 We are frequently rebasing the base branch. Could you rebase this PR?

It looks like the diff is wrong as we force-push to update branch, the workable commit is this one:
https://github.com/oap-project/velox/pull/417/commits/47ed8247753c10d4f191ae336c234d19c3af592d

It looks like the diff is wrong as we force-push to update branch, the workable commit is this one:
47ed824

@chenxu14

have rebased my own branch, can you help to review this @zhouyuan

@chenxu14 We are frequently rebasing the base branch. Could you rebase this PR?

Done.

@chenxu14 thanks, can you please also update the gluten one?
https://github.com/oap-project/gluten/pull/3437

@chenxu14 thanks, can you please also update the gluten one? oap-project/gluten#3437

OK, will do it after #417 merge, than we can change #3437 to target on the main branch


[Suggestion] Add variable to retrieve UUID of victim in victim-related events

Add variable %victim_uuid% in victim-related events like %entity_uuid% in entity-related events.

Closing an issue without any explanation is pretty rude. A quick comment would be appreciated next time.

This was added a long time ago https://ajneb97.gitbook.io/conditionalevents/global-variables#entity-variables

This was added a long time ago https://ajneb97.gitbook.io/conditionalevents/global-variables#entity-variables

It's not the same things actually. There is no variable to retrieve UUID of attacked entity for player_attack event type for example.  %entity_uuid% never seems to get parsed here and for any "victim-related" events too I guess.
  realms_poster_button_lmb:
    type: player_attack
    conditions:
    - '%victim% == INTERACTION'
    - '%entity_uuid% == 198bff12-cbc5-41c3-afe1-a5b25d25c324' # doesn't work
    # ...

Oh ok, since the issue was a missing %entity_uuid% variable I thought you meant entity events, but player_attack has victim variables, so I should add a %victim_uuid% as well.


VideoJS 5.0 Updates (WIP)

This PR is to update the plugin for video.js 5.0

+1

Beyond fixing the jshint, expect(8), and the two tests. What is left outstanding?
Only some of the tests pass, but works for me without any errors in Chrome 45.0.2454 on OS X 10.10.5.

We'll see if we can make a release this week since the MSE HLS work in videojs-contrib-hls is winding down.

Just seen this. If you could make it compatible with requirejs like videojs itself is that would be great :)
Currently this won't work out of the box if requirejs is used where previously it could do.
Posted a comment here with more info: https://github.com/videojs/videojs-contrib-dash/issues/23
Can open a seperate issue if you like?

Hi Joe, any update on the possible release please.

2.0.0 is now available.

@tjenkinson could you open requirejs compatibility in another issue?

:tada:

Hi Joe
Sorry, just seen you've closed the original issue, so I've re-posted this as a new issue.
Thanks very much for v2.0.0.
We have just tested it with DASH as first src, then MP4 as 2nd src (fallback).
Works fine in Win 8.1, on IE (Dash), Chrome (Dash), Firefox (MP4 fallback).
But on Win 7, IE fails (should fallback to MP4). It should fallback to MP4 (2nd src), but it fails with the error:
--- The Media Could Not Be Loaded... ---
Chrome (Dash) and Firefox (MP4 fallback) are fine, just fails on IE?
Any ideas on a fix?
Richard

Well done Joe, v2.0.0 working fine across the all browsers we've tested.

Great work! I'm assuming this can be merged?

Does not work with requirejs yet though

Merging this in as there hasn't been any activity with version 1.x.


post and session

i want my skill to repeat the previous outputspeech, if the user asks for it.
so i decided to use post() to store whatever is contained in the response in the session attributes.
while implementing, i found that prepare() is called before calling post(), so all those session attributes are not stored in the response. therefore, i just call prepare() once again in my post() handler.
wouldn't it make sense to call prepare() after calling post() in the alexa-app?
cheers

I am not sure whether that's something we want to do all the time, but maybe you can convince us with a test that demonstrates this?

I have to admit, I don't understand what kampfgnu is asking here.

Hi guys!
I just faced with a problem that I can't update session from post().
Example:
app.pre = function (request, response, type) {
        var session = request.getSession();
        user = session.get('user');
        console.log('pre. session user: ', user);
});
...
app.post = function (request, response, type, exception) {
        var user = 11111;
        var session = request.getSession();
        session.set('user', user);
});

On every request I have user = undefined in pre().

Calling response.prepare(); at the end of app.post fixes the issue. But it's not clear for developers without looking at the alexa-app sources :D

Lets fix the code, PR please?

It's funny, but I faced with the bug again and it took me some time before I recall the issue.
@matt-kruse

The simple fix is moving response.prepare(); down after the post() call in response.send().

Actually not. post() is supposed to operate with prepared response, modify it.
We need to add response.prepare(); after post() instead of moving it, IMHO.


Got dynamic padding actually working for sequence tagger

The main issue was with the CNN encoder used to get word encodings.  I needed to make it agnostic to the input length, which it now is.
This led to a ~4x speedup in runtime, going from over 4000s per epoch to ~1000s.  And that's an automatic gain, with a couple of flags, for any model that's compatible.  I'm pretty happy about this.  @matt-peters, thanks for the idea!  The only issue is that some of our more complex models will be hard to make compatible with dynamic padding...

@DeNeutoy, to address a comment that (I think) you deleted, you're right.  This is similar to the sorting_keys stuff I added a little while ago - I originally had that as a field on TextTrainer that subclasses would override, but decided it was easier to document and resulted in a cleaner API to make it a method instead.  I think that's appropriate to do here, as well, just so we're consistent about what kinds of things you have to override in subclasses.  It is indeed really complicated if you have to be careful to pop a parameter before calling the superclass, then set a field after calling the superclass.  Too much magic.  I'll switch it to a method, so parameter passing will be more sane, and so that it shows up in the docs.

@DeNeutoy, here's another try.  Does this look better?

Much better ☺


underrun execution issue

Hi Mate.. I just compiled and attempted to load the underrun example.. It compiled fine but when I hit the webpack-dev instance I got the following on the console:

I'm not sure where this is coming from.  Can you re-produce this or is it a dev-env issue on my side?
Thanks
/W

I have had this error before, it is a missing import. Essentially the implementation for _d_array_cast_len is missing, and it is not supplied by the js glue code.
I need to look into the code. Will do later today.

Cool..  I just wondered if it was a known issue or just my dev-env.  Thatnks...

I fixed the underrun example and released v0.1.7
Will look into the other examples later this weekend to check if they work.
The reason were some breaking changes and me not updating the examples.

Excellent and I completely understand... I really appreciate your help as I learn your bindings.

Ok so I've tested this with your latest and I am still seeing the same error as above.  I went ahead and added the missing function signature with a console.log implementation to the jsExports object to see what happens after it gets called and this is the result:
let jsExports = {
    _d_arraycast_len: ()=> { console.log("_d_arraycast_len called")},
    onOutOfMemoryError: () => abort("Out of memory exception"),

It's not a concern for me right now, I have lots of other stuff to test, but I thought you would want to know about this.


Is this supported for agent V7

I am currently working on integrating GA to Datadog and am not experiencing any errors however, I am not seeing a metric in our Datadog account. Is this confirmed to be working with Datadog Agent Version 7?

I tried to run ga.py manually and am getting an import error
from datadog_checks.checks import AgentCheck, CheckException
ImportError: No module named 'datadog_checks'
I have installed the datadog python library through pip via pip install datadog

Hi there!
We have not tried this with version 7 yet. It would be very nice to get some help in that direction thou. :)


Update samples for preview.3

WIP branch for updating samples to preview.3. Make changes and/or additions here as necessary.
Fixes #90

This won't pass the checks until preview.3 is released in its current state as it's not using the release feeds or a preview 8.0.200 SDK release. @balachir do you want to try updating the nuget.config to use the release feed and the global.json to point at the latest 8.0.200-preview SDK (8.0.200-preview.23624.5) for now to ensure this builds?

This won't pass the checks until preview.3 is released in its current state as it's not using the release feeds or a preview 8.0.200 SDK release. @balachir do you want to try updating the nuget.config to use the release feed and the global.json to point at the latest 8.0.200-preview SDK (8.0.200-preview.23624.5) for now to ensure this builds?

OK I ended up doing the above myself and now we can see what actually needs to be updated in this PR due to changes in preview.3

I believe this just needs the NuGet.config change reverted before merging

I believe this just needs the NuGet.config change reverted before merging
I've reverted the NuGet.config changes now.

/azp run

Do we need to add dotnet workload update && dotnet workload install aspire to the workflow yaml?

Do we need to add dotnet workload update && dotnet workload install aspire to the workflow yaml?

It's already in the build.sh

The failure repros locally, seems there's an issue generating the manifest for the Dapr sample.

Ah, the issue is that the Dapr CLI is missing on the CI machine:

I added a Dapr CLI installation step to the pipeline

@ReubenBond still failing

Yeah, I wonder if the dapr integration isn't working on Windows (which is running first and cancelling the linux build) - I'll see if it works on Linux and we can hold off on merging for now

Ok, that wasn't it. We get a different error on Linux. I tried updating to the latest DAPR CLI (the default from the action is very old). I assume it's still not finding the binary. I am trying to enable MS Build Structured Logs to the CI to see what the exact issue is now. We might end up needing to set the dapr/path env var manually

Looking at our code now... did this ever work? The dapr hosting package in Aspire only looks in C:\dapr\dapr.exe on Windows. For Linux, it checks ~/dapr/dapr and /usr/local/bin/dapr. The setup-dapr task doesn't support selecting the installation directory (it outputs a dapr-path var).
I think we need to change the Aspire.Hosting.Dapr package to either check the PATH or allow specifying the Dapr installation directory via an env var

I think ServiceDefaults package needs a change to make the package ref to Http.Options instead of Resliency.

I'm tempted to say that we should either merge without CI or disable the Dapr sample from building in CI until https://github.com/dotnet/aspire/issues/2219 is resolved and we have updated to a version with that (i.e, Aspire preview 4).
cc @philliphoff - perhaps you know how we might resolve this

Skip the tests for the dapr sample

Looks like this is not updating all of the packages that were shipped yesterday, instead it is only updating the aspire ones. I can push another commit to make sure everything is up-to-date

perhaps you know how we might resolve this

@ReubenBond An ugly way would be to set the DaprOptions.DaprPath value to the CLI path found in PATH in the application host when adding Dapr support in the sample.  I've never looked at the GH Action before; I didn't realize it dumped it in a random directory.  Agree that it could be useful to use what's found in PATH, if anything, before looking at other specific locations.


test more puppet versions

test for strict-variables and future parser compatibility

3.5 was only released for like 2 weeks ( and was terrible) also while you're here why not remove the 2.7

okay

@nibalizer looks gooder now, but travis isn't picking this repository up, actually :(

squash/force push to make travis pick it up

i'm counting a 1.8.7 failure to due puppet-rspec fuckup as a success.

hits merge button


Increase/Decrease everyone's volume in the room at once

A single slider to increment/decrement everyone's volume in DogeHouse.
You can change speakers' volume to 200% in DogeHouse, even if your speakers are at max, so this pretty helpful if you have low volume speakers.

@nadirabbas  https://next.dogehouse.tv/voice-settings ?

oh that's a thing?


Use TLS Encryption to Protect RESTful API communications

needed to encrypt the communication as manifests  may contain sensitive data like secrets encoded in base64, and manifests will be sent in request payload to replica installer(especially important in case SaaSI engine and replica installer are not installed in the same cluster/same host).

In addition, passing sensitive parameters and their values  by users from client to service , should be also secured , by encapsulating them in HTTPS  TLS encrypted requests, otherwise payload data might be exposed to eavesdropping and interception.

I think we can integrate the install-builder as one component of the saasi-service, so it can just store the manifests in the management cluster, no need to have dedicated API to put these configurations in the engine.
And yes, the deployment configurations can be stored in a dedicated DB that can define the history of the custom replicas.

Right, but let's clarify few points tomorrow on our meeting, to get a clearer picture.

@dmartinol
So for what concern sending the manifests with sensitive data, we'll do it  against api-server(port 6443) and this communication is already TLS encrypted by default.
But , We'll still need to protect The parameters submitting from SaaSI console to Exporter or one of its backend services endpoints (that will encrypt them and will create secrets from them eventually), the parameters will be sent over HTTP , and to protect them from interceptions and MITM Attacks, we need to encrypt that channel and send them over HTTPS using TLS.


Translation to different languages

It will be great to be translated into different languages to prevent forks just for languages.
A tool like Transifex, Localise or POEditor could be used. I will help to translate into Spanish.
Also, depending on the browser configuration, the web page could be shown in the user's language, or one of the list.

It seems this option is already used under the locales directory. However, it is not synchronized for all languages.
Also, there should be a way to change the current language, to one of the available ones.

Can you give an example of when you'd want to pick a different language than the one specified by your browser?

Sometimes, the os or the browser is installed in English where is not the primary spoken  language, like in public places. Also, for a country with several official languages,  like Switzerland which has 4, then it will be better to change the current one.


feat: get lyrics endpoint and examples

Implements the integration with lavalink lyrics endpoint along with examples of how to use it

@guilhermehccruz hi, I wanted to see if you'd be available to discuss a few adjustments on our Discord server. It would be easier to communicate there. If that doesn't work for you, I can update your PR myself. Thanks!

@guilhermehccruz hi, I wanted to see if you'd be available to discuss a few adjustments on our Discord server. It would be easier to communicate there. If that doesn't work for you, I can update your PR myself. Thanks!

No problem, I'm jack3580 in discord

Your PR is now ready. However, there are a few concerns we need to address before merging:

I set up the plugins and enabled YouTube lyrics, but it consistently says "no response" even when lyrics are typically available on the video. I might not have configured it correctly, so it needs to be tested before merging.

By default, I designed the plugin-lava-player to work with the YouTube plugin, as it's the most common use case. However, we can't add these features without providing a configuration option to disable them (lyrics slash command at least). This needs to be addressed before moving to production.

Lavalink supports numerous other plugins, and we can't integrate them all without first addressing point 2. Users who utilize plugins beyond YouTube should implement their own solutions on top of the queue for these features, as the plugin-lava-player currently only supports the YouTube plugin.

Please review these concerns when you have time. Once resolved, we can proceed with the merge. Thank you.


Nested structure: Local variable name does not match pattern

I have a nested structure and get 'Local variable name does not match pattern' error.
https://github.com/christianguenter2/abapGit/blob/cade5e1bf2db380f0f9dc762406ad623df112378/src/objects/zcl_abapgit_object_srvd.clas.abap#L251-L268
https://github.com/christianguenter2/abapGit/runs/632446750

But I don't get the error in the abaplint playground.
DATA:
  BEGIN OF ls_fields_to_clear,
    BEGIN OF content,
      source TYPE c,
    END OF content,
    BEGIN OF metadata,
      created_at      TYPE c,
      created_by      TYPE c,
      changed_at      TYPE c,
      changed_by      TYPE c,
      master_language TYPE c,
      BEGIN OF package_ref,
        name TYPE c,
      END OF package_ref,
      responsible     TYPE c,
      dt_uuid         TYPE c,
    END OF metadata,
  END OF ls_fields_to_clear.

What am I missing?

probably a bug in abaplint

did you change something? I cannot find the error in the branch, https://github.com/christianguenter2/abapGit/commits/SRVD

yeah, changed it.

suggest closing the issue, unable to reproduce

I can reproduce it
https://github.com/christianguenter2/abapGit/tree/868
https://github.com/christianguenter2/abapGit/runs/637218759

looks like this happens when its inside a method,

2.32.10 published


Autorest Regen Preview to 3.0.0-alpha.20230506.3 by Dapeng Zhang from refs/pull/3237/merge

Triggered from https://github.com/Azure/autorest.csharp/pull/3237

API change check
API changes are not detected in this pull request.


User Agent includes uv's version

Currently when uv makes requests the User Agent is set to just uv.
It would be nice that it includes the version (e.g. uv/{version}) for improved visibility and statistics for the registry provider on the client being used.
For example, pip usually has pip/{version} {other metadata}, curl has curl/{version}, httpx has httpx/{version}, requests has python-requests/{version}, and so forth. Hence uv/{version} seems like the correct way to go.

Upon looking at uv-client, I see that's where the User Agent seems to be set for all request across all packages, so there's likely a couple solutions to this depending on the approach since that's where the user agent is being set.

Option 1: Expose a module in uv-client that allows to globally/static set the UA version (e.g. via OnceCell with getter/setter) and set the version once at the beginning in UV's main entrypoint function.

Option 2: Create a new crate (e.g. uv-version or uv-codex) that has becomes the single source of truth for this type of data given cargo dependencies are unidirectional.

Option 3: Change RegistryClientBuilder to take a UA version and modify all related interfaces (among all dependencies) to pass down uv's version across the codebase to RegistryClientBuilder.

Option 4: Maybe we could use cargo feature flags to hack around it, but that'd seems burdensome to maintain.

Option 1 seems the most straightforward, but if we are thinking of adding more global data to be shared by other modules maybe Option 2 is best.
Thoughts here?

I think if we just wanted to include the version, something like (1) would be fine. Although, it's possible we can just use env!("CARGO_PKG_VERSION") to inline the version in uv-client, and not make any other code changes?
If we want to support https://github.com/astral-sh/uv/issues/1958 though, we'll need a way to set the user agent based on the Python interpreter. We have that information in-memory already, but threading it through to the client will require some work.

Although, it's possible we can just use env!("CARGO_PKG_VERSION") to inline the version in uv-client, and not make any other code changes?

I was intitially thinking it would be ideal to be uv's version and not uv-client's version otherwise I think the header would be uv/0.0.1 versus uv/0.1.10 unless you're thinking of aligning the uv-* package versions the same as uv, which would also be a valid option here.

Oh yes, sorry, it should definitely be the uv version. (I was confused because we use env!("CARGO_PKG_VERSION") for the virtualenv, but that code is actually in the uv crate, not a layer below.)


can't open new editor if current directory at startup was deleted

VSCode Version: 1.8.1
OS Version: MacOS 10.12.2

Steps to Reproduce:
# shut down VS Code
mkdir foo
cd foo
code .
# close editor window
cd ..
rmdir foo
code .
# editor window is blank

The second time it starts, there is a blank (all black) window. Using 'Toggle Developer Tools' there is an error on the console:
Uncaught Error: ENOENT: no such file or directory, uv_cwd path.js:1144
The code looks like this:
if (cwd === undefined)
          cwd = process.cwd();

Apparently, this dies if the process's current directory at startup no longer exists.
To recover, quit out of VS Code (instead of just closing the editor window).

https://github.com/Microsoft/vscode/issues/2259


Add new LXC: Kimai

Description
Add new LXC Kimai.
Kimai is an open-source time-tracking software designed for freelancers, small teams, and businesses to efficiently track, manage, and analyze work hours. This web-based tool enables users to log their work time with ease, associating entries with specific clients, projects, and tasks.
Request
Fixes https://github.com/community-scripts/ProxmoxVE/issues/387
Type of change
Please check the relevant option(s):

[ ] Bug fix (non-breaking change that resolves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[x] New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[x] Testing performed (I have tested my changes, ensuring everything works as expected)
[x] Documentation updated (I have updated any relevant documentation)

Additional Information (optional)
Some Improvements. (Ignore the systemd error, its my dev branch with some changes)

Tested and work fine @havardthom Ready for Approve


Nice library but seems PWM is behaving a bit strangely

Perhaps it's just me but whenever I try to use PWM the BCM pin 2 changes from ALT0 to ALT2 and suddenly it's no longer possible to use ADC chips to for example read the value of a Rotary Potentiometer and then controlling a DC motor using PWM. Doesn't seem to matter if I use PWM on BCM pin 12 or BCM 13.
Using Raspberry PI 4.

Same problem

That's interesting behavior. Did you guys find out which function call was causing it?
Also, it might be fixed by #50, which was in master for a long time, but unfortunately, it wasn't tagged so it was not used if you were using go modules. I created the new tag now, so you might try to update it (go get -u github.com/stianeikeland/go-rpio/v4) and check whether it solves your issue.


Unnest ops API code

Code Changes

[x] move the fides.api.ops dir up one into fides.api

Steps to Confirm

[x] tests pass

Pre-Merge Checklist

[x] All CI Pipelines Succeeded (failures are all expected failures)
[x] Relevant Follow-Up Issues Created (follow-up plus issue]
[x] Update CHANGELOG.md

Description Of Changes
In preparation for fully integrating ops/ctl code, this small (but with a large diff 😬 ) iteration unnests the ops code into fides.api

this looks good, did some smoke testing on my local server too and things generally looked fine.
only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?
looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.
To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

this looks good, did some smoke testing on my local server too and things generally looked fine.
only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?
looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.
To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

that's good with me! sorry, looks like you've already got some conflicts :/

this looks good, did some smoke testing on my local server too and things generally looked fine.
only question is around the failures with external saas tests - i'm almost positive those are unrelated to the changes, just the fact that there are so many (and with some rather unusual suspects from my experience) gives me pause. there also aren't any logs showing the failures/errors - maybe this is normal in CI?
looping in @galvana who's got some more recent experience with the saas tests to make sure things look OK from his POV!

That is correct, we don't show those test logs in CI for security reasons. To put it simply, I did a mass search find for any mention of fides.api.ops, fides/api/ops, and other combinations so I truly don't think this PR would break it but also can't verify due to the logs being obscured.
To avoid continually spending time on merge conflicts, I'd rather ship now and follow up with a smaller PR that might fix any particular bug that slipped through

that's good with me! sorry, looks like you've already got some conflicts :/

haha no worries! I knew I wouldn't get away clean this time 😂 after going through the Fides 2.0 merge I think I can handle just about anything in terms of conflicts


[husky_description/CMakeLists.txt] fix position to exec roslaunch_add_file_check

Currently if ur_description which is run_depend of husky_description is installed from source, roslaunch_add_file_check fails because ur_description may be built after this package, and its path is not yet in ROS_PACKAGE_PATH when roslaunch_add_file_check.

Note that I think you can also do:
roslaunch_add_file_check(launch DEPENDENCIES ${catkin_EXPORTED_TARGETS})

@dirk-thomas can confirm that I have this correct.

@mikepurvis catkin_EXPORTED_TARGETS commonly only contains the message generation targets. But I assume the launch file needs a script or executable from ur_description. So the DEPENDENCIES should affect this as far as I can see.
I think the run dependency should be sufficient. If not, please let me know with a reproducible example where it doesn't work.

@mikepurvis @dirk-thomas Thank you for reviewing! Now I updated the PR.

@mikepurvis @dirk-thomas I tried to test these package in travis-CI, but variable catkin_EXPORTED_TARGETS is only _catkin_empty_exported_target in the build process.
The command I executed is catkin run_tests husky_description

Without knowing what packages are in the workspace I don't know how to help. The exported targets are only meaningful when built without isolation and if the packages which are found are also in the workspace. Otherwise their is no need for target dependencies. Also I guess you mean catkin_make run_tests husky_description?

catkin build always builds each package in isolation (separate CMake invocation per package). So cross package target dependencies are irrelevant.

@dirk-thomas So anyway, we have to revert to original PR, right?

I'm not certain about how roslaunch_add_file_check DEPENDENCIES work, but I imagine the answer here is to add any packages needed for tests as a <test_depends> to package.xml. This means that when running roslaunch_... tests, any <run_depends> must also be a <test_depends>.

closed because this issue is now inactive.
I solved by avoiding building and testing this package by specifying all our packages instead of executing just catkin build.


Missing files index / upload tool

Hello,
Not sure if I've done anything wrong but the link "Manage files" (Manage files that available to be downloaded by users) leads to an empty page. I was under the impression that there will be a file index and an upload tool?
Please advise, thanks
Adam

Thank your for the question, and you're right the link should be goes to /blog/file/admin

Link confirmed working, thanks
Adam


Github Actions removed during setup

When starting a new project, running npm run setup will remore the .github folder which includes the actions workflows
To Reproduce
git clone https://github.com/kefranabg/bento-starter.git my-bento-project
cd my-bento-project

# Install dependencies and clean git repository
npm run setup

Expected behavior
Should remove .github/ISSUE_TEMPLATE and .github/FUNDING.yml
Should keep .github/workflows

Fixed and merged at https://github.com/kefranabg/bento-starter/pull/248


Implement workspace/willRenameFiles for single-level file moves

Automatically rename modules during file rename if they're in the same directory.
Fixes #6780

bors r+


fix: gui-libs/wlroots only if USE=system-wlroots

Hyprland packages it's own version of wlroots.
we only need to pull from other repo's if we're using the system-wlroots
relates to Issue: #53

Even if we don't use the system-wlroots option, we still need wlroots to pull in the dependencies of the embedded copy of wlroots.

Even if we don't use the system-wlroots option, we still need wlroots to pull in the dependencies of the embedded copy of wlroots.

this seems like a bit of a sledgehammer solution to the problem?
can we not explicitly depend on those packages without pulling in wlroots?

Somebody would need to track wlroots dependencies as well as hyprland dependencies. I didn't have enough time to do that.

Somebody would need to track wlroots dependencies as well as hyprland dependencies. I didn't have enough time to do that.

I believe i've now done that work, however i'm not too sure how to test.
do you have a CI set up for this?


[ENT-979] Add Enterprise Data API client.

This adds the Enterprise Data API client that will allow easy access to the Enterprise Enrollments endpoint in the Analytics Data API server.
I'm not sure how to explicitly test this, but you can ensure that the URL we call here is the same as the one defined here.
Note: Currently this assumes the Enterprise API will take in a plain token. But the view associated with /enterprise/{}/enrollments/ expects JWT. I may have to update this to allow using JWT, or update the view to use token authentication as fallback.

Thanks for the pull request, @UmanShahzad! I've created OSPR-2402 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.
Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.
If you like, you can add yourself to the AUTHORS      file for this repo, though that isn't required.     Please see the CONTRIBUTING     file for more information.

Coverage remained the same at 100.0% when pulling e39b1a09611057a14c915ecbc93ec905d79e677a on uman/enterprise into 9afe03a6ff278ce79438779d79f53fb462301114 on master.

@georgebabey Do see my 'note' above about JWT vs. Token. I don't know if there are business reasons behind using JWT, but all clients in this repo use token authentication, so maybe we can allow the Enterprise Enrollments endpoint in the data API to fallback to token auth?

Nevermind, we won't be using this.

Although this pull request is already closed, I've created OSPR-5498 so that we can track it in Jira.
There is nothing you have to do. No action is needed from your side.  Thanks.

Although this pull request is already closed, I've created OSPR-5498 so that we can track it in Jira.
There is nothing you have to do. No action is needed from your side.  Thanks.


keyTap doesn't work with capital letters.

This code doesn't work:
var robot = require("robotjs");
robot.keyTap("H");

but this does:
var robot = require("robotjs");
robot.keyTap("h");

This also works:
var robot = require("robotjs");
robot.typeString("H");

This is because keyTap is build for holding keys down with modifiers (like shift or ctrl). To do a capital letter you'd press h with shift.


Unknown values

Description:
it looks like my charger only returns total energy values when charging. The device is connected and heartbeat is passed consistently, but total energy values are not refreshed so HA starts to report ‘unknown’ after a while (despite showing the correct graph when checking the entity). Values start refreshing when charging.
No logs retrieved yet, if needed I can provide them.
Config:
HA running on rpi, Alfen pro-line charger in same subnet. Again: connecting like a charm and all functionality is working consistently and continuously

I had the same problem with my charger. I then realized that the integration currently only configure measurement to be done while charging (the ocpp parameters MeterValueSampleInterval and MeterValuesSampledData), and my charger by default did not report anything while not chariging.
Reporting while not charging is configured with ClockAlignedDataInterval (seconds between reports, a 0 value means no reporting) and MeterValuesAlignedData (defines what to report).
In the HA->Development Tools->Services, try
service: ocpp.get_configuration
data:
  ocpp_key: ClockAlignedDataInterval

service: ocpp.get_configuration
data:
  ocpp_key: MeterValuesAlignedData

and check the response in the logs or in the Config.Response entity.

They can also be set:
service: ocpp.configure
data:
  ocpp_key: ClockAlignedDataInterval
  value: 900

which will report every 15min when not charging for example.


InitializeStaticGlobals: don't merge stores for structs with unreferencable storage

like C bitfields.
Fixes a compiler crash
rdar://122360051

@swift-ci test


Creation of Kuksa.val simulators?

We have (test) clients for both kuksa-val-server and kuksa-databroker, where you can read/write data. But for testing or demo of an App it could be interesting to add simple simulation capabilities, e.g. by extending the clients so that they can take a config file as parameter and feed the server/broker according to the config file. Or possibly document how you can modify the clients to run a predefined sequence.
I am thinking of config files (or behavior) similar to below, i.e. where you can specify which signals that shall be set, but also a mechanism to add pauses where needed.
set(Vehicle.Speed,121)
set(Vehicle.Trunk.IsOpen,false)
sleep(2000ms)
set(Vehicle.Trunk.IsOpen,true)

This might go nicely with some record & replay capability in a human readable format (e.g. not rosbag files).

Uh, interesting to see this resurrected. Just had a discussion about something like this earlier today.
I think that might be a useful debugging tool. Wouldn't call it simulator, maybe rather a mock.
I think kuksa.val with our python lib it is almost "trivial" (well still someone needs  to do it :)) to write a program that can interpret a script like above.
Might get really interesting with some Velocitas integration, i.e. maybe some VSCode GUI or at lest some autocompletion magic writing such test sequences and executing them. Pinging @gkreyssing

Testing wise, for internal use,  might also be nice  to have an "expected" file, e.g. a sequence of things you expect to get from certain subscriptions

We are about to archive this repo soon. If you consider this issue as important please file a new issue at one of the new Kuksa repos at https://github.com/eclipse-kuksa


X.U.WindowProperties: Added the ability to test if a window has a tag…

Description
New data constructor Tagged that uses hasTag from
X.A.TagWindows.  This is great for building layouts based off of
window tags.
Checklist

[X] I've read CONTRIBUTING.md

[X] I tested my changes with xmonad-testing

[X] I updated the CHANGES.md file

Looks good to me.


[Bug] Background script- Failure to run in Chrome

Summary: The extension installation completes without errors, but every definition returned defaults to "not-found."

Steps-to-reproduce:

Install on Chrome
Define a real word
Expected result: TapeWord will not return a definition

Resolved with commit #21


Fix radio button required

Hey!
I just merged this one and we'll commit and additional fix for the selects. :+1:
Should be ready in 5-10 minutes


Re-implement the 'Add mapillary features' branch in pixi/ v2.

The MLH crew implemented this functionality as part of our first-ever Major League Hacking initiative, but that was done as a branch cut from v1. We need to re-implement this functionality after v2 lands.

This has been re-implemented in the v2_mly_objects_staging branch. Will close this and track under #1127


Error types are incompatible

Consider the following example. On error, both function foo and function bar return an Err object that holds an Error. So I would consider the Err objects returned by the two functions to be interchangeable: When bar calls foo and receives an error, I'd expect bar to be able to just forward that error.
function foo(): Result<number, Error> {
  return err(new Error('test'));
}

function bar(): Result<string, Error> {
  const result = foo();

  // Doesn't work:
  // Type 'Err<number, Error>' is not assignable to type 'Err<string, Error>'.
  if (result.isErr()) return result;

  return ok('test');
}

In practice, however, TypeScript complains that "'Err<number, Error>' is not assignable to type 'Err<string, Error>'".
What's the best practice for forwarding errors that already wrap a value of the correct type?

Hello @DanielSWolf !
Indeed, the result returned by foo() does not have the same type as the return type of bar() so you cannot forward it as is.
However, since you know it’s an error, you can unwrap the error and re-wrap it into a Result<string, Error>.
if(result.isErr()) return err(result.error);

Thanks for the explanation! The first option solves my immediate problem, but I'll certainly experiment with chaining.


Fix exception when loading certain GIFs

WebM and MP4 isn't always available, so first check if they are.

Shouldn't they default to null otherwise?

In the API of Derpibooru or DerPyBooru? It seems they might have even been removed completely, I can't find any posts which contain them.

If the tag isn't present on derpibooru, it should still be in DerPyBooru.
So you can just check if it is None.
(if they do still exist... that is)

Well, they don't exist on the derpibooru API it seems, even on uploads tagged as 'webm', and it seems it was never even supported, so I don't actually know where it came from.

@ChlorideCull Currently you need to have WebM serving enabled in your API user's settings. (Display->Serve webm)

that should be enable-ble with a param on searches, lists, images
Actually I don't see a reason why to disable it on the api, if all available types are included, the client still can choose.

Seems to be the case with #15.

I've removed support for webm/mp4 representations for GIFs as the API no longer exposes them. They were never a documented feature, so adding them to the library was never a good idea.

0bc66e695d83074dec3597e16605764d9abad5c3

yes I can see


Move NodeController constants to flags

I think that those constants will be tweaked by people trying to optimize their clusters, so should be exposed as flags.
I'm not sure that all of them should be exposed, maybe we should create relations between them, like saying that grace period for starting nodes is X time longer than normally. But as a first approximation I just moved all of them.

Assigning to @davidopp, feel free to reassign.

At least you must clearly specify the relations between nodeMonitorGracePeriod and nodeStatusUpdatePeriod.  You can't assume people understand the internals.  We made the decision not to use flags due to these inter-relations.  You can also have a basic check in controller manager binary.

@gmarek I assume this will need some rebasing after the other changes are submitted, but I think this is basically a good idea, and that @ddysher 's concerns can be addressed by setting reasonable defaults, and failing at startup if the values are not set in a way that conforms to the required constraints between them.
You should probably also make Kubelet's nodeStatusUpdateFrequency (see kubelet.go) be a flag.

Should we also make podEvictionTimeout be a flag? Might be a little tricky since it is currently a constructor argument. I'm fine either way for now.

Rebased.
Isn't podEvictionTimeout already a flag? https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cmd/kube-controller-manager/app/controllermanager.go#L108

Please also make Kubelet's nodeStatusUpdateFrequency (see kubelet.go) be a flag.

Rebase and added Kubelet flag.

Failure looks like #6495


Incorrectly reporting: Called 'env' outside of the config directory which returns null when the config is cached, use 'config'.

Larastan Version: 2.9.8
Laravel Version: 11.23.4

Description
phpstan is reporting phpstan: Called 'env' outside of the config directory which returns null when the config is cached, use 'config'.
When the call is inside a file in the config directory
config_path(); = "C:\www\<project>\config"
file = C:\www\<project>\config\filesystems.php

Could be a Windows-related issue.
Try dumping values here:
https://github.com/larastan/larastan/blob/e1b64a0f3120cf40fca9703a718e29b0cef89f9f/src/Rules/NoEnvCallsOutsideOfConfigRule.php#L61

Seems to be something to do with how PHPStorm is running phpstan ? but then as you can see in the Ray output below it is returning true for str_starts_with, thus it shouldn't trigger the rule... 😕

PHPStorm can indeed act weird. Maybe it doesn't pickup the correct PHPStan config. Please re-open the issue only if it also happens when running PHPStan from cli.

@canvural it happened to me during execution from CLI: https://github.com/ttbooking/support-chat/runs/34828663022
But, my project is Laravel package. Can I somehow let Larastan know what my config directory is, or maybe Larastan need config dir auto-detection algorithm for packages?

@daniser, don't scan your package config directory--- just the source code


Could not find a version that satisfies the requirement autogluon

My PC has python version 3.7.5
But when I running the command for installing AutoGluon by AWS, the terminal says
'Could not find a version that satisfies the requirement autogluon (from versions: )
No matching distribution found for autogluon'

Can you elaborate?
What is the exact command you entered, and can you provide a 'pip freeze' terminal output?
Also, what is your system information: OS, etc.
Can you try:
pip install mxnet
pip install autogluon

It's now solved
I got an error while updating my python version and OS bit crashed
So I reinstalled OS and updated python
Now I can use autogluon easily


Add borderWidth prop to the View Style documentation

Look OK but how do you test this doesn't break anything?

Note it's not just documentation, it's used for validation in a few places.

Oh. I thought it was just about documentation.
I just ran 2018 and Sample App with this modification and they are still working, at least on iOS.

A good example to check is the UIExplorer which has a demo for borders.

Seems to work like a charm.
Note that in the exemple, available in the current documentation, use this property but it's not listed in the style section (https://facebook.github.io/react-native/docs/view.html#content).

@Crash-- thanks for verifying!
@mkonicek shipit?

See #3133


Shutting down the docker keeps the packs locked

Bug description
Hi,
Thanks for the amazing work on creating these dockers.
I am using that to run some module development and I am seeing that even if you shutdown the docker, it keeps the module packes locked.
Steps to reproduce

Start the docker
Create a module
Create a pack for the module
Edit the pack
Close the world
Shutdown the docker/foundry

Expected behavior

Packs are unlocked when finished to work on the server

Container metadata
com.foundryvtt.version = "11.315"
org.opencontainers.image.authors =<EMAIL_ADDRESS>org.opencontainers.image.created = "2024-01-05T17:39:23.478Z"
org.opencontainers.image.description = "An easy-to-deploy Dockerized Foundry Virtual Tabletop server."
org.opencontainers.image.licenses = "MIT"
org.opencontainers.image.revision = "18981628b89a04fa780f9faa1657be17aeaeb9b1"
org.opencontainers.image.source = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.title = "foundryvtt-docker"
org.opencontainers.image.url = "https://github.com/felddy/foundryvtt-docker"
org.opencontainers.image.vendor = "Geekpad"
org.opencontainers.image.version = "11.315.1"

Relevant log output
2024-03-05 19:19:43 FoundryVTT | 2024-03-05 19:19:43 | [info] Server started and listening on port 30000
2024-03-05 19:19:44 FoundryVTT | 2024-03-05 19:19:44 | [info] Created client session c16c96fe2c9ee94cff268823
2024-03-05 19:19:47 FoundryVTT | 2024-03-05 19:19:47 | [info] License signature successfully created. Thank you and please enjoy Foundry Virtual Tabletop.
2024-03-05 19:19:47 FoundryVTT | 2024-03-05 19:19:47 | [info] Software license verification succeeded
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "actors"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "cards"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "messages"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "combats"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "drawings"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "fog"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "folders"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "items"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "journal"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "macros"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "playlists"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "tables"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "scenes"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "settings"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "users"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "world.kogarashi-items"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Connected to database "kogarashi.kogarashi"
2024-03-05 19:19:51 FoundryVTT | 2024-03-05 19:19:51 | [info] FoundryVTT | Created 0 Folder documents with ids: []
2024-03-05 19:19:51 Watching for changes to trued6 in /data/Data/systems/trued6/lang, /data/Data/systems/trued6/css, /data/Data/systems/trued6/templates
2024-03-05 19:20:09 FoundryVTT | 2024-03-05 19:20:09 | [info] User authentication successful for user Gamemaster
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] Created client session c3941c43adeaf3edd3c47cb0
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [warn] No system manifest found at https://github.com/cussa/fvtt-true-d6/releases/download/latest/module.json
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] No system update for TRUE-d6 is currently available.
2024-03-05 19:20:10 FoundryVTT | 2024-03-05 19:20:10 | [info] Vended World data to User [BYWnNCAU5OooUKKE] in 308ms
2024-03-05 19:21:00 Entrypoint | 2024-03-05 19:21:00 | [warn] TERM signal received.  Shutting down server.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Whenever you are editing a pack, Foundry creates some lock files. From what I saw, it "commits" the changes to the database file when you shutdown it.
If you follow the steps, you will see that it will keep some lock files in the pack folder.

Thanks for explanation.  This type of issue is probably not specific to the containers implementation, but it could be related to how you are stopping the container and the signals that are getting sent to Foundry.
How are you starting up the container?  Are you using the Docker init option?   This sounds similar to issue #813.
See:

https://github.com/felddy/foundryvtt-docker/issues/813

@felddy Sorry for the confusion. It seems that it is not a bug, as going for other ways of operating that is causing the same behaviour. I am closing the ticket.


Removing contrib code base and targets

1st commit: Cherry pick the upstream commit
2nd commit: Remove our contrib targets in CI
Note: This should be part of the task in develop-upstream-sync-190923 but git did not apply all the deletes when merging (Since the merge-base have all those files). Besides, this is a relatively big PR that deserves to be regressed individually.

retest rocm-xla please

Re-resolved the conflict and the only change left after weekly merge is to remove contrib target from csb script. This change won't even trigger our CI run. Merging it now.


Add RedirectToPostLogoutRedirectUri to OpenIdConnect auth

Proposed in PR: https://github.com/aspnet/Security/pull/925
Requires change to the IOpenIdConnectEvent: https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.OpenIdConnect/Events/IOpenIdConnectEvents.cs.

Note this is a breaking change to add interface members and cannot be done until 2.0. Consider removing the interface pattern entirely to avoid this limitation in the future.


fix: 🐛 global process should be replaced when build with rollup

replace 'process.env.NODE_ENV'
fix #324

Description

Motivation and Context

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build 380225496

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 380161434:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Modifier -> SwiftUI -> Input events: digitalCrownRotation(_:onChange:onIdle:)

Doc: https://developer.apple.com/documentation/swiftui/view/digitalcrownrotation(_:onchange:onidle:)

[ ] Swift implementation
[ ] Elixir implementation

We won't support this for now


⚠ Bofrost.nl has degraded performance

In 896c748, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1022 ms

Resolved: Bofrost.nl performance has improved in 18e132b.


Refactoring duplicate slice and pad2d, const pad support to pad2d

This PR, refactors pad2d and slice, eventually slice and pad2d does the same thing both can shrink and pad with zeros but they do it with different formatted input. So I have merged them into one in pad2d and used it in slice.
As a result of this PR, pad2d now supports const padding
To sum up, slice and pad2d does the same thing eventually

Changes made in tinygrad/:
------------------------------------------------------------
files                             insertions       deletions
------------------------------------------------------------
tinygrad/tensor.py                         6               8
------------------------------------------------------------
lines added in the tinygrad folder: -2

Where is Tensor.slice actually used? Is it possible just to get rid of it entirely if pad2d essentially does what it does?

Currently it is being used in _pool and in onnx I believe, but remember that it does the same thing with different input so it may require some input formatting to replace slice with pad2d entirely.
For example, Tensor.ones(5).slice(((0,6),)) == Tensor.ones(5).pad2d((0,1))

Want me to migrate all slice to pad2d in this PR or in a seperate PR? Maybe if this gets accepted I can do it in sep PR

Thanks!


[ACS][Common] OPS - Added Routing Logic Based on Scopes

Contributing to the Azure SDK

Modified the EntraTokenCredential class to route requests to the appropriate endpoint based on the provided scopes
Added unit tests to verify the new routing logic and ensure its correctness.
Updated the md files to reflect the changes

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.Common


Consolidate calls to /metrics to use the new resource type all

Now that #928 has merged, we can use resource_type=all to request metrics for all resource types available. This PR modifies the Namespace page in the web UI to replace the 3 existing api calls with a single call.
There are no user visible changes.
Fixes #941

Instead of making three sequential calls to /api/v1/stat on the frontend, we instead make one call, and have the StatSummary method in public-api handle making parallel request to Prometheus.
(Each resource type then makes 4 async queries for metrics to prometheus. So for 3 resource types, there are 12 prometheus queries). So this isn't altering the total number of prometheus queries, though it does mean all those queries will occur closer in time to each other. Thoughts? (@siggy?)

Yep, 16 is correct!
Yeah the 404s appearing are a known issue, see https://github.com/runconduit/conduit/pull/959 for more discussion on this.


Custom Debug Hook in Go via "State.SetHook"

With this commit it's now possible to define a custom debug Hook in Go
via the new Function "State.SetHook". Currently there is only one Hook
per State which means that a call to "State.SetHook" will always
override the previously set hook.
This hook is always of type "LUA_MASKCOUNT"
#98

@aarzilli should all be resolved now


Allow removing some of the default tags from zipkin traces

The zipkin traces generated by envoy by default have a lot of tags and tags like response_size, request_size which can really bloat and load the trace backend. Some of these tags should really be logs.
Is there any way to configure envoy to not add some of these tags by default on the spans? i.e. some way to define a minimal set of tags which envoy should be attaching to each span. I couldn't find anything in here: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing

sounds reasonable to me.


Wish - Schedule, legend align and duplicate

Request to add functionality similar to this tool to the HOK Addins: https://apps.autodesk.com/RVT/en/Detail/Index?id=3172433025981040712

@WendyMok @dbaldacchino  I know this is old, but at this point I think between:

pyRevit's Copy/Update Selected Viewports to Selected Sheets (for duplicated Schedules/Legends onto other sheets)
and
Ideate's Align tool (for aligning Schedules/Legends across multiple sheets)

I believe we have access to all the functionality out of the box for all our users. If I am mistaken, let me know and I can re-open this issue. Thanks.


make build status badge point to new repo travis

per #2650
this probably won't pass until #2652 is merged

going to make this part of the other PR


tests export --create --nitrate removed 'require+' attribute, moved 'tier' down

Repo root contains main.fmf with require: py3c-devel
Test contains main.fmf with attribute
require+:
- gcc
- python3-devel
- rpm-build

When I did tmt tests export --nitrate --create I saw: Metadata successfully stored into ....
But git diff shows more changes than expected:
-require+:
-- gcc
-- python3-devel
-- rpm-build
-tier: 1
 duration: 5m
+tier: 1
+extra-nitrate: TC#XXXXXX

I'd say that even moving tier: 1 attribute is surprising, but at least it stays there.

For me it removed adjust: with all of its children (and also moved tier: down).

This seems to be quite an unpleasant issue. I think we should fix this as soon as possible. @hegerj, will you have time to look into this in the coming days/weeks?

This seems to be quite an unpleasant issue. I think we should fix this as soon as possible. @hegerj, will you have time to look into this in the coming days/weeks?

Yes I will.

Yes I will.

There will be probably also a bigger issue with this updating yaml files.
I'm using virtual hierarchy structure inside FMF files like:
components: [cockpit, cockpit-doc, cockpit-system, cockpit-bridge, cockpit-ws]
version_from_comps: [cockpit-bridge]

tags+: [Tier1]
relevancy: |
   distro != rhel-7: False
   distro = rhel-7 && arch=ppc64: False
beaker-task: /CoreOS/cockpit/Sanity/selenium-generic
test: selenium-base.py:BasicTestSuite
plans: [19006]
dependencies: []

/login:
   summary: "Check cockpit basic if is able to"
   /add_ssh_key:
      relevancy: |
         distro <= rhel-7: False
         distro = rhel-7 && arch=ppc64: False
      test+:  .test15BaseSSHKeyAdded
      summary+: "add ssh key for login user"
   /login:
      /sanity:
         test+: .test20Login
         summary+: "login with various scenarios: nonexisting user, bad password, proper user"
      /special_cases:
         test: selenium-login-special.py
         summary: "Check regressions in login cases, (text in bashrc, special login shell)"
         relevancy+: |
            distro <= rhel-8: False

tool $ tmt test export --nitrate --create . then generates tcms testcases:
Test case 'TC#0609282' created.
summary: Check cockpit basic if is able toadd ssh key for login user
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check cockpit basic if is able toadd ssh key for login user
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/add_ssh_key
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609282' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.
Test case 'TC#0609283' created.
summary: Check cockpit basic if is able tologin with various scenarios: nonexisting user, bad password, proper user
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check cockpit basic if is able tologin with various scenarios: nonexisting user, bad password, proper user
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/login/sanity
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609283' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.
Test case 'TC#0609284' created.
summary: Check regressions in login cases, (text in bashrc, special login shell)
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check regressions in login cases, (text in bashrc, special login shell)
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/login/special_cases
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609284' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.

after this comman main.fmf contains just:
test: selenium-base.py:BasicTestSuite
extra-nitrate: TC#0609284

So It totally breaks original files.

There will be probably also a bigger issue with this updating yaml files.
I'm using virtual hierarchy structure inside FMF files like:
components: [cockpit, cockpit-doc, cockpit-system, cockpit-bridge, cockpit-ws]
version_from_comps: [cockpit-bridge]

tags+: [Tier1]
relevancy: |
   distro != rhel-7: False
   distro = rhel-7 && arch=ppc64: False
beaker-task: /CoreOS/cockpit/Sanity/selenium-generic
test: selenium-base.py:BasicTestSuite
plans: [19006]
dependencies: []

/login:
   summary: "Check cockpit basic if is able to"
   /add_ssh_key:
      relevancy: |
         distro <= rhel-7: False
         distro = rhel-7 && arch=ppc64: False
      test+:  .test15BaseSSHKeyAdded
      summary+: "add ssh key for login user"
   /login:
      /sanity:
         test+: .test20Login
         summary+: "login with various scenarios: nonexisting user, bad password, proper user"
      /special_cases:
         test: selenium-login-special.py
         summary: "Check regressions in login cases, (text in bashrc, special login shell)"
         relevancy+: |
            distro <= rhel-8: False

tool $ tmt test export --nitrate --create . then generates tcms testcases:
Test case 'TC#0609282' created.
summary: Check cockpit basic if is able toadd ssh key for login user
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check cockpit basic if is able toadd ssh key for login user
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/add_ssh_key
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609282' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.
Test case 'TC#0609283' created.
summary: Check cockpit basic if is able tologin with various scenarios: nonexisting user, bad password, proper user
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check cockpit basic if is able tologin with various scenarios: nonexisting user, bad password, proper user
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/login/sanity
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609283' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.
Test case 'TC#0609284' created.
summary: Check regressions in login cases, (text in bashrc, special login shell)
components: cockpit
tags: fmf-export
default tester<EMAIL_ADDRESS>estimated time: 10m
automated: auto
status: CONFIRMED
arguments: SUBJECT=selenium-rhel8.4.py DEPENDENCIES=None PACKAGES='cockpit cockpit-doc cockpit-system cockpit-bridge cockpit-ws' VERSION_PACKAGES=cockpit-bridge
Structured Field:
description: Check regressions in login cases, (text in bashrc, special login shell)
purpose-file: Cockpit testsuite
fmf id:
name: /Sanity/selenium-generic/login/login/special_cases
url: https://git.src.osci.redhat.com:32101/tests//cockpit
Added warning about porting to case notes.
Test case 'TC#0609284' successfully exported to nitrate.
Metadata successfully stored into '/home/jscotka/git/cockpit-project/tests/cockpit/Sanity/selenium-generic/main.fmf'.

after this comman main.fmf contains just:
test: selenium-base.py:BasicTestSuite
extra-nitrate: TC#0609284

So It totally breaks original files.

BTW my feeling with yaml parsing and updating is, that after yaml file is stored it is converted to dict (maybe OrderedDict could help but not sure if possible improve yaml parser to use this in easy way) and then storing file stores stored it based on hash order in dict.

BTW my feeling with yaml parsing and updating is, that after yaml file is stored it is converted to dict (maybe OrderedDict could help but not sure if possible improve yaml parser to use this in easy way) and then storing file stores stored it based on hash order in dict.

It reminds me, that similar issue could be with yaml loader inside FMF, and my perspective on this issue is that most of work would be done on FMF side and TMT should be able to use FMF "saving" abilities then instead of own way.
FMF has data which node is stored in which files and probably for this case you want to update as latst file as possible. little trouble is that FMF does not remember raw data, just merged data +- and directory structure

so probably it need to add to FMF some attributes, which exact part of dict inside file is used for this node (now there are just list of files)
then just updating this node inside linked file, by new attribute (have to load this pure file again, to not dump merged + - items)
then just dump the updated data to files if there are changes (maybe some attribute for changes?)

This way could be harder to implement (but not so much, just extending fmf node attributes and then just use it and dump), but cleaner for future usage and implementing more complicate updating/optimizing of fmf files.

It reminds me, that similar issue could be with yaml loader inside FMF, and my perspective on this issue is that most of work would be done on FMF side and TMT should be able to use FMF "saving" abilities then instead of own way.
FMF has data which node is stored in which files and probably for this case you want to update as latst file as possible. little trouble is that FMF does not remember raw data, just merged data +- and directory structure

so probably it need to add to FMF some attributes, which exact part of dict inside file is used for this node (now there are just list of files)
then just updating this node inside linked file, by new attribute (have to load this pure file again, to not dump merged + - items)
then just dump the updated data to files if there are changes (maybe some attribute for changes?)

This way could be harder to implement (but not so much, just extending fmf node attributes and then just use it and dump), but cleaner for future usage and implementing more complicate updating/optimizing of fmf files.

Yeah, I agree with @jscotka that the best long-term way forward here is to implement metadata update functionality directly in fmf which would then take care of all the complex hierarchy and elasticity issues. Let's track that feature in psss/fmf/issues/101 and for now resolve this issue by a simple workaround proposed in #515.

Yeah, I agree with @jscotka that the best long-term way forward here is to implement metadata update functionality directly in fmf which would then take care of all the complex hierarchy and elasticity issues. Let's track that feature in psss/fmf/issues/101 and for now resolve this issue by a simple workaround proposed in #515.


Can you make the CLion logo transparent? And can you use this logo for C++? Thanks :D

Click here to see the C++ logo and click here to see the transparent CLion logo

There are multiple icon themes, only the Material theme as a background for IDE icons. You should probably take a look at the Classic theme.

Ok, thanks 👍 Will do. To be honest, I kind of forgot what the issue was, either that or what I was bothered by has been updated :D I will close this issue. Thanks and have a great day!


Styles for the background color of the screenshot in the readme.

Greetings,
I would like to use the background color styles you used for the screenshot, and not the default styles that are set when installing the package.
Could you provide the code you used when you took that screenshot ?

Hi @rwatts3. I used no custom styles for the screenshots. They're probably outdated though.


Use ruff-format

ruff-format is more thorough in the formatting. This would change 109 files, so I am not committing them yet, want to ask about autopep8 first.
Configuration settings: https://docs.astral.sh/ruff/settings/#format

Pretty sure @happz would very much not like this as ruff formatter is made to be drop-in replacement for black, not autopep8.

Ok, I've reverted the pep8 part

Pretty sure @happz would very much not like this as ruff formatter is made to be drop-in replacement for black, not autopep8.

Indeed, I for one was never fond of Black and opinions forming its formatting style. Mostly because of the decisions that led to allow very to little customization, leaving no space for project-specific formatting choices. I find that impractical, and one bad way of doing things is forcing everyone to do it in the same way.
ruff-format seems to offer some controls, and I briefly scanned the pre-commit report - it does not look as bad as I expected and remembered from my last experience with Black. I would like to read it properly to find out something I could complain about with having some hard examples :)
Two things I can share already:

I would advocate using the # fmt: off pragma, as there are pieces of code - like step data fields or test parameters - where the formatter undoes careful manual formatting that aimed at improving the readability of less than trivial structures.
I for one would 100 % recommend not reformatting the whole code base at once, in a single patch. It's extremely tedious to review it, and it's easy to get lost among literally thousands of lines. At least for me, that is. Should powers that be decide "yep, we want this", I'm sure we could come up with some per-package or per-module approach that would be easier to digest, and attract attention to - not a single aspiring "junior" developer would dive into reviewing a patch of thousands of lines, but they would be happily learning about tmt code reviewing changes to a plugin or two.

Just my two cents..

not reformatting the whole code base at once

format.quote-style = "preserve" would drastically lower the number of lines and files to review.
Putting aside the codestyle/formatting preferences, using ruff formatter would have some benefits, like speed, integration with linter rules, incl. config and ... speed.
I mean, not just considerably faster to check/format, but also by "reusing" the same ruff pre-commit virtualenv as the lint step.

Added to our meeting agenda, let's get some input.

Could we tweak the option to remove space around the docstring?
-        """ Add a string to the paragraph being rendered """
+        """Add a string to the paragraph being rendered"""

Would be nice to keep this formatting as it is now.

hmm, I scoured the internet, but haven't found the surrounding spaces in any standard or convention.
We have https://docs.astral.sh/ruff/rules/surrounding-whitespace/ disabled - not sure if the formatter would ever respect that, aiming to be compatible with black.
I've rebased and updated the config a little bit, for people to see what changes there would be. It's mostly the surrounding spaces and trailing braces :)
https://github.com/teemtee/tmt/compare/main...martinhoyer:tmt:ruff-format

It kinda sounds like a bug in ruff upstream, does still occur with your updated version? Also feel free to force push the update, or I could rebase and cherry-pick?

Briefly went through the changes. While there are a lot of theme, I think they all make sense...
Bumped into this though, looking at PEP8, it doesn't seem to be correct?
-            unique_suffix = name[len(INJECT_CREDENTIALS_URL_PREFIX):]
+            unique_suffix = name[len(INJECT_CREDENTIALS_URL_PREFIX) :]

We got a reply from upstream: https://github.com/astral-sh/ruff/issues/13760#issuecomment-2413874694
@psss what do you think about this limitation? I.e.

there's no option to change that behavior because we intentionally limit the formatter options and only support formatting styles with widespread adoption.

@psss what do you think about this limitation? I.e.

there's no option to change that behavior because we intentionally limit the formatter options and only support formatting styles with widespread adoption.

I see. Hm, pity. I find the formatting with spaces a bit more readable. Feels like giving some freedom to the message helps to more quickly catch the words rather then when the first/last word is squeezed into the triple quotes. But I'm not going to fight for this. Others have any thoughts? Maybe I'm just the only one, so no need to block on this. Does ruff-format support one line docstrings like this?
def wake(self) -> None:
    """
    Wake up the guest
    """
    self.debug(f"Waking up container '{self.container}'.", level=2, shift=0)

We could have a single rule: Both starting and ending triple-quotes are on a separate line. That's it. I see this approach is used quite widely in the artemis code. Perhaps @happz will have some input on this?

It's mostly the surrounding spaces and trailing braces :)

The trailing braces part will be hard. Does ruff-format support hang-closing feature of autopep8? I really cannot understand at all how closing brackets and parenthesis can be placed out of the indented block???!!! :grin: That seems to be going against the main Python principle: Anything which belongs "under" the current line is indented. Want to find where the block ends? Look at the first line with the same or lower indent. That's it. So simple! :nerd_face: If this rule is broken I'm very much afraid the end of the world is near! 😵

One more thing: Among the changes I see also these:
                     dynamic_ref = resolve_dynamic_ref(
-                        workdir=destination,
-                        ref=plan_id.ref,
-                        plan=self,
-                        logger=self._logger
-                        )
+                        workdir=destination, ref=plan_id.ref, plan=self, logger=self._logger
+                    )

I would say, in case cases, it's really more suitable to write each parameter on a single line. Does ruff-format always enforce single line when it's short enough or is this somehow configurable?

One more thing: Among the changes I see also these:
 dynamic_ref = resolve_dynamic_ref(
-    workdir=destination,
-    ref=plan_id.ref,
-    plan=self,
-    logger=self._logger
-    )
+    workdir=destination, ref=plan_id.ref, plan=self, logger=self._logger
+)

I would say, in case cases, it's really more suitable to write each parameter on a single line. Does ruff-format always enforce single line when it's short enough or is this somehow configurable?

Agreed, at some point of N arguments, it's easier for me to follow them if they are each on its own line, even when they would fit on one line nicely. Maybe there is a control for this, like 4 or more arguments? Put them on new lines!

@psss what do you think about this limitation? I.e.

there's no option to change that behavior because we intentionally limit the formatter options and only support formatting styles with widespread adoption.

I see. Hm, pity. I find the formatting with spaces a bit more readable. Feels like giving some freedom to the message helps to more quickly catch the words rather then when the first/last word is squeezed into the triple quotes. But I'm not going to fight for this. Others have any thoughts? Maybe I'm just the only one, so no need to block on this. Does ruff-format support one line docstrings like this?
def wake(self) -> None:
    """
    Wake up the guest
    """
    self.debug(f"Waking up container '{self.container}'.", level=2, shift=0)

We could have a single rule: Both starting and ending triple-quotes are on a separate line. That's it. I see this approach is used quite widely in the artemis code. Perhaps @happz will have some input on this?

Yep, we're using these rules: 1. no docstring on the same line as """, i.e. every docstring has at least three lines; 2. there's a blank line after a docstring, it makes the code airier. No special handling for docstrings that fit on a single line, that's one exception gone.

It's mostly the surrounding spaces and trailing braces :)

The trailing braces part will be hard. Does ruff-format support hang-closing feature of autopep8? I really cannot understand at all how closing brackets and parenthesis can be placed out of the indented block???!!! 😁 That seems to be going against the main Python principle: Anything which belongs "under" the current line is indented. Want to find where the block ends? Look at the first line with the same or lower indent. That's it. So simple! 🤓 If this rule is broken I'm very much afraid the end of the world is near! 😵

First time hearing about this principle :)
Anyway, I'm not going to try to convince you it's better with the closing brackets aligned with the beginning of the statement - it is, but who am I to argue that :) I just wanted to share how I see it, why I feel it's a sane approach, internally consistent, and why I feel like I'm not breaking this main Python principle.

Want to find where the block ends? Look at the first line with the same or lower indent.

True, but a block like while, for, or if are not the same as a dictionary/list creation or a function call. The first ones are blocks, the latter are expressions. {...} can be given a name, while cannot. Blocks also don't have closing brackets or parenthesis, so, there is nothing to argue there, no closing bracket to indent.

Anything which belongs "under" the current line is indented

foo = [
  {
    'bar': 'baz'
  }
]

Neither ] or } belong "under" the then-current line: ] is not part of the list opened by foo = [, just as } is not part of the dictionary opened by {. They are not the content, just like [ and {. The content alone is indented, and since [ and ] are not list items, { and } are not key/value pairs, they share the indentation level, and only the content is marked by the indentation as something "belonging" to an expression.
So, to paraphrase your question, want to find where the expression ends? On the same column where it started. Simple as that. It cannot end with white space because, unlike blocks, it must have a closing character.
As I see it, it doesn't conflict with blocks, it nicely delimits the content of an expression which is the important part, and with a trailing comma & closing bracket not being part of the final "item" it also leads to simpler patches: foo,\n) => foo,\nbar\n) is just one line added, foo) -> foo,\nbar) changes two lines). Yes, it needs one extra line, but that's fine to me because I use space in code; the dense, compact line is harder to follow, and when adding new items to lists and dictionaries, I do not need to worry about the trailing bracket, it's not affected.

If this rule is broken I'm very much afraid the end of the world is near! 😵

What I always like is this paragraph from PEP8: https://peps.python.org/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds

The guidelines provided here are intended to improve the readability of code and make it consistent across the wide spectrum of Python code. As PEP 20 says, “Readability counts”.

The use of white space, blank lines, and indentation of closing brackets fits, in my books, into this category. They improve the readability. For me. Not following PEP8 or even the "main Python principle" when it makes code easier to read is not the end of the world ;)

Finally in Berlin, I'll start addressing the open issues

Wohoo!

@martinhoyer did I accidentally uncommit your changes?

Maybe, fwiw, I haven't touched my fork branch https://github.com/martinhoyer/tmt/commits/ruff-format/

I don't see that option, and I think it's because of their choice to be an opinionated formatting tool. My thoughts on this is that it is more compatible with the default (non-ruff-format) PyCharm auto-formatting.

+1


Pattern validation in nz-select for tags mode

What problem does this feature solve?
I am trying to create an input where the user can either select from pre-defined options or create their own entry as long as the new entry matches a certain pattern (i.e, the entry only contains alpha-numeric characters)
nz-select with nzMode="tags" seemed like a good solution for my use-case but we can not limit the user provided entries in it based on a pattern (i.e alpha-numeric inputs in my case)
What does the proposed API look like?
<nz-select [(ngModel)]="selectedValue" nzMode="tags" nzPlaceHolder="Select a Value"
  [nzNotFoundContent]="'Type to add a new Value'" [pattern]="'^([0-9a-zA-Z] )$'">
  <nz-option *ngFor="let option of availableValues" [nzValue]="option.value" [nzLabel]="option.label">
  </nz-option>
</nz-select>

pattern input or a new input can be used to get the regEx and match the user input with provided regex before adding the user provided tag. The user provided tag will only be added if it passes the pattern validation.

you can use ngModelChange to validate the input value, we have no plans to support this feature for now, unless antd-design supports it :)