Number Parsing PVSyst Diagrams

Incorrect Parsing of Loss Values
This link shows a file with a PVSyst Loss Parameters diagram on page 13.

Lllamaparse is consistently returning  Global incident in collection plane as -4.39% (should be -4.3)
Lllamaparse is also consistently returning Near Shadings: irradiance loss as   22.19% (should be -2.1%)
Overall, it appears the % symbols can cause an extra 9 to appear at the end of parsed values. Also a leading negative sign seems to result in duplicating the first number (at least when it starts with a 2).
Parsing Instructions (sent just page 13)
This is a PVSyst file. It contains information about energy losses during solar PV generation. It is a graphic that has a table structure.

There are 3 types of terms on the page:
 Group A - on the far left there are numbers with units (# kWh, # kWh/sqw meter) or conversion equations ( term = #% )
 Group B  - To the middle and middle left are "loss terms". Losses are in the format: (+ #.# %) or (+ #.# %)
 Group C - Labels on the right sight of the page for Group A and B values.

Match Group C labels with Group A and B values

Group B OVERRIDES
    - a loss term will always start with a "+" or "-", a "-" may appear to be "~" so correct this mistake
    - the last character in a "loss term" may appear to be a "9", if the term has two decimal places, replace the last "9" with a "%"

Do not include any values in the response that are not in the source.

You're correct. Our OCR is not perfect and we're looking to improve it. In the meantime, you could try with the multimodal approach, which seems to give better results:

| Parameter                  | Value  | Description                                     |
| -------------------------- | ------ | ----------------------------------------------- |
| 880 kWh/m²                 |        | Global horizontal irradiation                   |
|                            | +20.0% | Global incident in coll. plane                  |
|                            | -4.3%  | Near Shadings: irradiance loss                  |
|                            | -2.1%  | IAM factor on global                            |
|                            | -2.0%  | Soiling loss factor                             |
| 970 kWh/m² \* 810 m² coll. |        | Effective irradiation on collectors             |
| efficiency at STC = 19.79% |        | PV conversion                                   |
| 155464 kWh                 |        | Array nominal energy (at STC effic.)            |
|                            | -0.2%  | Module Degradation Loss ( for year #1)          |
|                            | -0.9%  | PV loss due to irradiance level                 |
|                            | -1.8%  | PV loss due to temperature                      |
|                            | -1.3%  | Shadings: Electrical Loss detailed module calc. |
|                            | -0.9%  | Optimizer efficiency loss                       |
|                            | +0.4%  | Module quality loss                             |
|                            | -2.0%  | LID - Light induced degradation                 |
|                            | 0.0%   | Module array mismatch loss                      |
|                            | -0.7%  | Ohmic wiring loss                               |
| 144149 kWh                 |        | Array virtual energy at MPP                     |
|                            | -1.7%  | Inverter Loss during operation (efficiency)     |
|                            | -0.4%  | Inverter Loss over nominal inv. power           |
|                            | 0.0%   | Inverter Loss due to max. input current         |
|                            | 0.0%   | Inverter Loss over nominal inv. voltage         |
|                            | 0.0%   | Inverter Loss due to power threshold            |
|                            | 0.0%   | Inverter Loss due to voltage threshold          |
| 141160 kWh                 |        | Available Energy at Inverter Output             |
|                            | -0.4%  | AC ohmic loss                                   |
|                            | -1.4%  | Medium voltage transfo loss                     |
|                            | 0.0%   | MV line ohmic loss                              |
| 138604 kWh                 |        | Energy injected into grid                       |

pvsyst-13.md
I'm closing this bug as it's a duplicate of other OCR-related issues and it's in our backlog.


error initializing database

(env)[user@server mygengine]$ initialize_gengine_db production.ini alembic.ini reset_db=True populate_demo=True
Traceback (most recent call last):
File "/home/user/www/env/bin/initialize_gengine_db", line 9, in
load_entry_point('gamification-engine==0.1.36', 'console_scripts', 'initialize_gengine_db')()
File "/home/user/www/env/lib/python2.6/site-packages/gengine/scripts/initializedb.py", line 58, in main
from ..models import (
File "/home/user/www/env/lib/python2.6/site-packages/gengine/models.py", line 294
existing_users_set = {x["id"] for x in DBSession.execute(select([t_users.c.id]).where(t_users.c.id.in_([user_id,]+friends))).fetchall()}
^
SyntaxError: invalid syntax

Because of several language structures which are used in the engine, you need Python in version 2.7. So please upgrade your current version. I've added this information to the implementation part of the documentation (see 3354563b3ce6f90bb7a1b2886da3df7ea75ce6c3)

Thanks that worked!
I also had to install funcsigs
and update setuptools


72 remove phase1 code

Binned a lot of old code, updated GH action to use poetry to install dependencies
#72

Should address #66 and https://github.com/CDU-data-science-team/pxtextmining/security/dependabot/14


feat(ai): add AI Apps, AI Jobs and AI Notebooks support

Hi, this PR adds basic support for the current 3 machine learning products from OVHcloud. See https://www.ovhcloud.com/en/public-cloud/ai-machine-learning/
Cheers

All done and ready for review, thank you

Thanks you! Merged.


traceback error on export model

i get a traceback error whil trying to export my model i am using cats 0.18 and bvlander 2.90.1

i have found the error apperently cats does REALLY not like it when you donèt have one of youèr mesches caled body


 It will periodically
list NodeMaintenance objects and attempt to garbage collect them (delete) if they were in ready state for more than MaxMaintenanceTime.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

74 of 96 (77.08%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 66.144%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/maintenance-manager/main.go
0
11
0.0%

internal/controller/garbage_collector_controller.go
72
83
86.75%

Totals

Change from base Build<PHONE_NUMBER>8:
0.3%

Covered Lines:
1055

Relevant Lines:
1595

💛  - Coveralls


Dagora Integration

Awesome repo, @sha237gh!
I am trying to follow this tutorial https://medium.com/@webump_/how-to-make-nft-collection-on-sei-from-stratch-e8344a743401
How does one integrates with Dagora or any other NFT marketplace?

@jvel07 you have to contact with them to list you


Fix: Header team section not working #97

The team div was lacking an ID named team, which is necessary to in order to navigate to the "team" div from the navbar's Team link.
Also, the "Team" link in the navbar has it's href attribute set to https://eduhubcommunity.tech/eduhub-website/1.0/TeamPage.html instead of #team.
I have applied the necessary fix and now the Team link works :)

Here is a POC for the fix:
https://user-images.githubusercontent.com/46086050/136005373-a0f5e445-44f8-45dc-8c0b-146a7fed7ff5.mp4


Add error handling logic to relayer spec

Fixes https://github.com/informalsystems/ibc-rs/issues/234.

Codecov Report

Merging #236 into master will increase coverage by 23.9%.
The diff coverage is 54.5%.

@@            Coverage Diff            @@
##           master    #236      +/-   ##
=========================================
+ Coverage    13.6%   37.6%   +23.9%
=========================================
  Files          69      79      +10
  Lines        3752    5652    +1900
  Branches     1374    1870     +496
=========================================
+ Hits          513    2127    +1614
- Misses       2618    3318     +700
+ Partials      621     207     -414

Impacted Files
Coverage Δ

modules/src/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/events.rs
0.0% <ø> (ø)

modules/src/ics02_client/raw.rs
0.0% <0.0%> (ø)

modules/src/ics03_connection/error.rs
9.6% <0.0%> (-23.7%)
:arrow_down:

modules/src/ics04_channel/error.rs
23.0% <0.0%> (-2.0%)
:arrow_down:

modules/src/ics04_channel/packet.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/client_def.rs
0.0% <0.0%> (ø)

modules/src/ics07_tendermint/error.rs
30.0% <0.0%> (+30.0%)
:arrow_up:

modules/src/ics07_tendermint/msgs/update_client.rs
0.0% <0.0%> (ø)

modules/src/mock_client/header.rs
0.0% <0.0%> (ø)

... and 134 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4877ee9...441e3bb. Read the comment docs.


edit the name of functions

we need to add the option to edit the name of functions

you can rename the functions, the issue is now that when you rename a function you need to rename all of the blocks that are renamed, and if you delete a function to delete all of the blocks that call that function

If you delete a function in functions menu then try to run a program that still has the function, the app crashes. Also, if you change the name of a function then go to main menu and come back, the name reverts to the old name.


⚠ Bofrost.nl has degraded performance

In 3a07cfd, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 3079 ms

Resolved: Bofrost.nl performance has improved in 949bcb8 after 6 minutes.


x/pkgsite: module root page not rendered

What is the URL of the page with the issue?
https://pkg.go.dev/github.com/u-root/mkuimage
What is your user agent?
Mozilla/5.0 (X11; CrOS x86_64 14541.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot

What did you do?
I'm honestly not sure how to reproduce the issue.
What did you see happen?
Screenshot shows that "this package is not in the latest version of its module". There is however, a package there: https://github.com/u-root/mkuimage/tree/c899e87a677c2f40f7f8b248f73e3a1b17bae719
It also shows that requesting that version fails.
The sub-packages in the module shown are that of the last version that was able to be indexed, which is not what the packages are called now.
Using one of the sub-packages that still exist, fileflag, the last screenshot shows that the version was parsed by pkgsite and updated.
What did you expect to see?
Documentation for the package & module.

maybe something to do with this file?
https://github.com/u-root/mkuimage/blob/c899e87a677c2f40f7f8b248f73e3a1b17bae719/dependencies.go

CC @jba
The duplicate escaping is #63968.

The service was updated Thursday last week. @hugelgupf Can you please check if problems still exist?

@hyangah looks to be working now.


Auth log for each command in shell

Hello,
With oh-m-zsh actived in my .zshrc file, each time I press the enter key, there is a line in /var/log/auth.log:
localhost.localdomain : Aug 25 19:40:50 : shini : a password is required ; TTY=pts/1 ; PWD=/home/shini ; USER=root ; COMMAND=/bin/true
If i disable oh-my-zsh or if i change to bash, there no more line in /var/log/auth.log
Any ideas?
Regards.

With more investigations, i think it's related to powerlevel9k theme.
I close the ticket and I'll open one there.


fix(mysql): fix open area file processing

关联研发信息
dev_branch: fix/open_area_file_processing/#5808
target_branch: v1.5.0


Syntax Error on ZorinOS Lite

Hi, so I just installed ZorinOS lite on a Chromebook, moving from ZorinOS Core because I found Gnome sucked up resources a lot. This is a Babymega C223N Chromebook from Asus.
I had used the audio script to fix this before when I had installed ZorinOS Core initially, but now I get a syntax error when attempting to run it here:
File "./setup-audio", line 100
match boards[device_board]:
^
SyntaxError: invalid syntax
I understand ZorinOS technically uses the LTS version of Ubuntu, but as I said, this did not happen with ZorinOS core.
I have run apt update and upgrade as usual. I verified I am running Python 3.8.2.
Please let me know if there's something I'm missing. Thank you.

Not my problem if the base distro is too out of date.

Damn, sure enough, the lite version is based on Ubuntu 20, not 22. Welp, guess I'll find some other way then.


replyQueue false cause publish error

when replyQueue is set to false,
_.has( options, 'replyQueue' ) => true
but
var userReplyTo = _.isObject( options.replyQueue ) ? options.replyQueue : { name: options.replyQueue, autoDelete: true, subscribe: true };

userReplyTo => { name: false, autoDelete: true, subscribe: true }
crashes because name is expected to be a string

doesn't really fix the problem, because a default replyQueue will still be created, so false is not really considered

@juliendangers - I have a fix for this issue in 0.2.4. I had to take a different approach but thanks for bringing the defect to my attention. Let me know if you continue to run into problems.


Add macros to unblock Dialyzer

Currently one of the reasons dialyzer won't run on our codebase is because this library doesn't have a ?CRITICAL macro in logger.hrl. This just adds that macro using the definition from the ejabberd logger file.

When you merge this be sure to version it and update our rebar.config


When edit a circle my layers group gets cleared

So I create a layers = new leaflet.FeatureGroup() to store any new shapes I draw like this.layers.addLayer(e.layer);. The thing is that when I draw a circle and then toggle global edit mode my layers disappear from my array (but not from the map). I guess it has something to do with this line of code:
https://github.com/codeofsumit/leaflet.pm/blob/700699ca1663514aee0e394350fb827c5330293e/src/js/Edit/L.PM.Edit.Circle.js#L51
Why is the circle _initMarkers() different and is clearing layers instead of markers and how my layers are connected to the circle layer group? Very strange behavior.
Any ideas?

@henev hmm good point, sounds like a bug. Will investigate 👍  - thanks for reporting!

it seems like this is the same problem as #290 🤔
And it is VERY weird. Still investigating...

I was able to fix it 👍, will be in the next release!


[Feature Request] Use schema file

To keep clutter down and editing the schema, or trying different schema's even easier, would be nice to be able to use a file instead of passing the schema through as an argument.
If it isn't possible, thats alright.
Interesting work so far, can't wait to see use cases for this outside of scraping amazon ;)

I think this is an interesting idea and it shouldn't be hard to implement. 👍

Thank you! :)


2.11.0 APKs can't be downloaded

https://github.com/mattermost/mattermost-mobile/releases/tag/v2.11.0
<Error>
AccessDenied
<Message>Access Denied</Message>
<RequestId>...</RequestId>
<HostId>
...
</HostId>
</Error>

I also have this issue.

Opened a ticket for our DevOps team to take a look.

This issue has now been fixed.
Note that there’s one URL which does still not work, the "Mattermost Universal" build, but it was also not working for the previous release, so it seems to be a separate issue. We have opened a separate ticket to fix that.


ValidationFilter stage breaks with unexpected error for invalid URL

I have this link in a DITA topic:
<xref href="http://www,oxygenxml.com" format="html" scope="external"/>

notice there is a comma in the href attribute value instead of a dot.
I publish to HTML5, the publishing breaks with:
   D:\projects\DITA-OT3.x\plugins\org.dita.base\build_preprocess.xml:96: java.lang.RuntimeException: Expected scheme-specific part at index 5: http:
at org.dita.dost.util.URLUtils.setFragment(URLUtils.java:559)
at org.dita.dost.util.URLUtils.stripFragment(URLUtils.java:541)
at org.dita.dost.writer.ValidationFilter.validateReference(ValidationFilter.java:199)
at org.dita.dost.writer.ValidationFilter.startElement(ValidationFilter.java:96)
at org.dita.dost.writer.ProfilingFilter.startElement(ProfilingFilter.java:121)
at org.xml.sax.helpers.XMLFilterImpl.startElement(Unknown Source)
at org.dita.dost.writer.DebugFilter.startElement(DebugFilter.java:78)
at org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
at org.apache.xerces.parsers.AbstractXMLDocumentParser.emptyElement(Unknown Source)

The URL is not really invalid according to the URI standard, so you can create an URI over it:
 new URI("http://www,oxygenxml.com")

So there are two problems, that there is a runtime exception thrown and that the exception details do not indicate in which file the problem occurred.

We are hitting this issue as well. It makes debugging difficult.

+1 another one of our users encountered the same problem.
For Oxygen 24 we decided to patch the DITA OT code and skip validation of all links which have scope=external.

👍 one more problem which may appear quite often, the same error is triggered for mailto: links like this:
  <xref<EMAIL_ADDRESS>format="html" scope="external">

@jelovirt maybe either the validation could be skipped altogether for scope=external links or have some special cases for URL protocols which are not implemented in Java but exist in the wild, schemes like:
"aaa://",
"aaas://",
"acap://",
"cap://",
"cid:",
"crid://",
"data:",
"dav:",
"dict://",
"dns://",
"fax:",
"ftp://",
"go://",
"gopher://",
"h323:",
"icap://",
"im:",
"imap://",
"info:",
"ipp://",
"iris:",
"iris.beep:",
"iris.xpc:",
"iris.xpcs:",
"iris.lwz:",
"javascript:",
"ldap://",
"mailto:",
"mid:",
"modem:",
"msrp://",
"msrps://",
"mtqp://"

@raducoravu, how about tel:?

@xephon2 interesting, I never knew about this one.


[FLINK-7269] Refactor passing of dynamic properties

What is the purpose of the change
This pull request adds  the dynamic properties to the loaded Configuration instead of set a static field in GlobalConfiguration which is read whenever we load the Configuration.
Brief change log

remove public static void setDynamicProperties(Configuration dynamicProperties) method in GlobalConfiguration
add public void setDynamicProperties(Configuration dynamicProperties) method in Configuration

Verifying this change
This change added tests and can be verified as follows:

Add test case testDynamicProperties in ConfigurationTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no

Documentation

Does this pull request introduce a new feature? no

@tillrohrmann @aljoscha I create this PR and try to fix https://issues.apache.org/jira/browse/FLINK-7269, could you please have look when you're free, thanks :)

Thanks for your contribution @zjureel. Could you please fill out the PR template? This will speed up review work significantly.

@tillrohrmann Thank you for your suggestion, I have update the PR template and add test case， thanks

@tillrohrmann Great, use loadConfigurationWithDynamicProperties instead of loadConfiguration and setDynamicProperties will be more concise, it sounds good to me, thanks

Thanks for your work @zjureel and sorry that it took me so long to get back to you. Will be merging your PR now.

@tillrohrmann @zentol the whole reason for the static field is to allow the various sites that call GlobalConfiguration.loadConfiguration to obtain the dynamic properties.    Any property could be overridden.  Since there are many, many such sites, this patch causes a potential regression.
Is there a driving rationale for this aside from a general dislike for statics?

There is only one true fix, that is to propagate the configuration instance everywhere so that only the entrypoint calls loadConfiguration.

@EronWright the driving rationale is that the static variable is an anti pattern which can cause problems which are hard to track and understand. E.g. it is really hard to find out where the values are actually set which you retrieve at another position via the static variable. Instead, we should always pass the respective configuration objects to the respective components.


Use Phi-Accrual Detection for failure detection

https://www.researchgate.net/publication/29682135_The_ph_accrual_failure_detector

With my attempted implementation, I am currently proposing the failure detector to be member of ScuttleButt.
ScuttleButt {
...
failure_detector: FailureDetector,
}

impl ScuttleBut {
  fn live_nodes(); // access list of live nodes
  fn dead_nodes(); // access list of dead nodes
}

FailureDetector is currently a direct implementation, but we can make it into a trait  if we want to provide option for other failure detector algorithm/heuristic.
trait FailureDetector {
  fn report_heartbeat(node_id: &str); // register node heartbeat
  fn update_node_liveliness(); // computes living/dead nodes
  fn live_nodes(); // access list of live nodes
  fn dead_nodes(); // access list of dead nodes
}

Discuss what's the best PHI_TRESHOLD and document.
Do we want to distinguish between node restarts ? I think right now we only care about a node being up/fine to work with.

The failure detector needs these adjustable options

window_size: usize, // heartbeat sampling window size
max_interval: Duration, // maximum heartbeat interval for heartbeat to be taken into account
initial_interval: Duration, // initial interval used when the was no previous sample value (at node startup)
PHI_TRESHOLD // phi threshold above which a node is considered down.

Currently, we can accepted a config struct that contains these options when constructing ScuttleButt instance. This has the advantage of not exposing the failure detector. But if choose to go with a trait we might have to expose PhiFailureDetector with it's option.
@guilload

Summary of our last chat on Discord:

reuse Cassandra default values for now
tracking node restarts is outside the scope of this PR
design configuration objects and constructors that make testing easier
switch to a FailureDectector trait only if necessary (mocking?)
switch from Mutex to RwLock (nice to have)

TODOs:

unit tests
gossip with dead nodes


Fixed entanglement test

Summary
Updated the test to the most recent interface change and functionality, and fixed the typo in test name. Fixes #386
Details and comments

Got some import errors only on macOS with Python 3.5. Anything I can do at my end on this?

Move the import of matplotlib inside the plot function


Fixed cargo's gas canister purchase prices

About the PR

Gas canister prices were all wonky due to an artifact from a time where the gasses they contained were actually worth something. Before every can was a different price, and they were all like 2k or 3k spesos. Now they are just the price of the can (1000) + 90 spesos for the gas + 10 spesos as a markup. co2 cans are 2200 instead of 1100 since co2 is poisonous. Remember that the sell prices of all these gasses is 0.
Also added an empty storage canister to cargo's catalog, so cargo can save a quick buck if they don't need the rest of the gasses. The empty storage canister is 90 spesos cheaper.
Economically speaking, since the station has a source of infinite gas the effective value of all minable gasses is 0 + shipping (unless atmos withholds supply), so being able to buy gasses for a price of 1 speso per 20 mols (cans contain 1800 mols) shouldn't break anything.
Having a stable source of empty gas canisters also shouldn't hurt since there's never really a deficit of them anyway.
The thing I'm least sure about here is making co2 cans pricier (or even sellable at all) so feel free to convince me that it's a bad idea.
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Centcom will now sell Cargo gas canisters at a vastly reduced (and consistent!) price after realizing the station has infinite gasses anyway.

CO2 is useless for anything besides poisoning people so the increased price should be fine


Add PassThroughTrait for middleware.

Let all the middleware supports exclude some URI.

:+1: @overtrue
Would love to see this merged !
ATM I have to extend \Illuminate\Session\Middleware\StartSession in my app as I don't want session to be created for my api/* routes.
This trait would really ease up things

@lucasmichot Yes, almost all my middleware need the trait.

@lucasmichot :disappointed:

Indeed @overtrue
Is there something we can do for that - maybe do it a different way - let us know @taylorotwell ?
This PR would really have lots of value


[$1000] dev: ESC keyboard shortcut shows up in modal on second render on login page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

signout if you are logged in
refresh the page
press cmd+j to open shortcut modal
now close the modal and observe content while it closes
now open it again

Expected Result:
ESC shortcut should always be shown in the modal
Actual Result:
ESC shortcut is visible for a brief moment while shortcut modal closes, later it is shown consistently
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.55-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/4e93ed9a-bead-467a-8b89-85a616e2a08d
Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691493991739999
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a6b0de738da985ac
Upwork Job ID:<PHONE_NUMBER>555742720
Last Price Increase: 2023-08-21

Proposal by @chiragxarora
Please re-state the problem that we are trying to solve in this issue.
ESC keyboard shortcut shows up in modal on second render on login page
What is the root cause of that problem?
Root cause of this issue is as follows:
We add shortcuts to the modal via documentedShortcuts object and a shortcut gets added to it only when that shortcut is subscribed here in subscribe function
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/libs/KeyboardShortcut/index.js#L135-L142
Now coming to the modal, we are subscribing to the ESC shortcut inside subscribeOpenModalShortcuts function here
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L49-L56
And from when the page loads till the point we open the modal once using CMD+J, this piece of code never executes because isShortcutsModalOpen remains false till that point
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L128-L131
same case with second useEffect, where it always lands in the else object
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L143-L152
Thus the ESC shortcut is never subscribed until we open the modal once on login screen, unlike other places
Now once you open the modal, it gets subscribed, and now when you close it, you get to see the ESC shortcut for a brief moment and after that, we see it whenever we open the modal
What changes do you think we should make in order to solve the problem?
We need to subscribe to openmodal shortcuts without any condition on modal mounting which essentially means the following changes:
replacing this
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L128-L131
with this
subscribeOpenModalShortcuts();

Results

What alternative solutions did you explore? (Optional)
None

While reproducing this issue, I found another related bug.
BUG
When logging out or signing out, the system will redirect to the login page. Now press CMD+j, we can see All shortcuts. Note that the list will disappear after reloading.
https://github.com/Expensify/App/assets/62904657/613dd205-b452-4a56-90e7-6a15f038c30e
should I report this in #expensify-bugs ?

Proposal
Please re-state the problem that we are trying to solve in this issue.
ESC keyboard shortcut shows up in modal on second render on login page
What is the root cause of that problem?
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L44
When the components load (initial), we call the function KeyboardShortcut.getDocumentedShortcuts() and store the result in the constant variable shortcuts. In useEffect we are callingsubscribeOpenModalShortcuts() subscribe function but fail to handle any changes in the shortcuts variable. Based on changes we are not rendering it.
For this https://github.com/Expensify/App/issues/25448#issuecomment-1683834874 cause is
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/libs/KeyboardShortcut/index.js#L83-L87
When unsubscribing, we remove event listeners but not shortcuts from the variable documentedShortcuts.
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L44
we can handle shortcuts variable  with UseState function so it will take care the onChanges render issue.
    const [shortcuts,setShortcurts] = useState([])

In these two places call SetState Function along with subscribeOpenModalShortcuts()
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L143-L146
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/components/KeyboardShortcutsModal.js#L127-L131
if (isShortcutsModalOpen) {
            subscribeOpenModalShortcuts();
            setShortcurts(KeyboardShortcut.getDocumentedShortcuts())

        }

We are setting the state when the modal is opened, Once the component unmounts reset the state.
https://github.com/Expensify/App/assets/62904657/8c9144e7-dcab-43d2-b3b6-1fca0a2ef9c3

Yes, I kept this in notes too, felt unrelated to this so didn't add it here

I apologize, but I could not locate any information pertaining to the subject you mentioned.

for this https://github.com/Expensify/App/issues/25448#issuecomment-1683834874
here
https://github.com/Expensify/App/blob/fdcae9ff99696a1ac6068efbfe8927e1bcf108b7/src/libs/KeyboardShortcut/index.js#L83-L87
we can remove the shortcuts based on the display name when unsubscribing
    documentedShortcuts = _.omit(documentedShortcuts,displayName);

@Charan-hs, yes please report to #expensify-bugs! I'll hide the comments here for that separate bug, to keep this one focused on the bug in the OP

I'll review the proposals in the morning; I ran out of time and got cold (again) 🙏

@tienifr
When KeyboardShortcutsModal is mounted, it calls KeyboardShortcut.getDocumentedShortcuts to update the state and render changes. Event handlers are handled in here.  we are only setting the state for viewing purposes, which also saves storage.

@chiragxarora I think there will be a drawback: https://github.com/Expensify/App/pull/18425. Even thought we don't have it now, I'd like to keep the logic as it is.
@tienifr I don't think we need new Onyx keys for this where it can be avoided
I think using the local state seems to be working. It makes sense to me we get the current shortcuts list, and we only care to show the list when the shortcuts modal opens.
The proposal from @Charan-hs looks good to me!
🎀 👀 🎀 C+ reviewed!

@conorpendergrast Weird. Melvin didn't pull anyone from the internal engineer 🥲

@Charan-hs Isn't it make sense to subscribe to the shortcut keys when the modal start open?

And from when the page loads till the point we open the modal once using CMD+J, this piece of code never executes because isShortcutsModalOpen remains false till that point

On the sign-in account, isShortcutsModalOpen is also false, but the ESC is present in the shortcuts list.

We don't have to use Onyx, other ways like creating a hook/adding a listener like KeyboardShortcut.onShortcutsUpdate( will also work.

@tienifr I don't know how the hook or listener you mention will be. Also, the issue you mention using the useState is that the CMD + C is not yet added to documentedShortcuts while the modal is open. In the @Charan-hs proposal, at least we got the current shortcuts documented before.
I'm trying to think the solution doesn't need to be over-engineered, but if @conorpendergrast or @arosiclair thinks the shortcuts listed in the modal should be dynamic, I agree the useState solution is not enough.

@tienifr Let's see what you propose in detail so I can get the idea.

Sorry @Charan-hs, I meant to give feedback to @chiragxarora 😅

@tienifr I think there are better choices than the hook solution. It's anti-pattern https://legacy.reactjs.org/docs/hooks-rules.html#only-call-hooks-from-react-functions
@Charan-hs I see that put KeyboardShortcut.getDocumentedShortcuts() into the dependencies, which led to the unexpected re-render.

@conorpendergrast Does this shortcuts list need to be dynamic? It means that when the modal opens, there's some key shortcut documented, and the key will be added to the list of the modal. Currently, there is only one edge case when the user immediately opens the keyboard shortcuts modal right after the sign-in.

It sounds like this new problem is that the shortcuts modal does not update if you open it while making some kind of page transition (signing in). IMO this isn't an edge case we need to worry about too much. @conorpendergrast thoughts?

Bump @conorpendergrast to help clarify the expected result.

If the sign-in flow is the only place that we'll encounter this bug, it does seem like it has limited scope to fix it. To confirm: there are no other places that we'll see this bug at the moment? If not, then I think we can close this out with payment to the bug reporter

there are no other places that we'll see this bug at the moment

I believe so. IMO, we should fix this 🤔

Yeah we can fix the bug in the OP pretty easily with @Charan-hs's proposal. The question is whether to "fix" the bug in other places (none of which have been found yet).
I think it's pretty clear to just fix the bug in the OP and if any other bugs are found, we can address them then. Does that sound good @mollfpr @conorpendergrast?

Yeah, I agree with that. Let's fix the bug we've found here, and not go beyond that

@arosiclair Sounds good to me 🚀

IMO, the case here is a different issue, and I'd prefer to investigate why the shortcuts CMD+C is not documented at the same time as the other shortcut. The shortcuts should be documented when the app is ready to use, and the shortcuts modal can't be displayed before all the shortcuts are documented.

@conorpendergrast, I mentioned the bug and solution , i.e while unsubscribing  keyboard shorcuts.
With this approch found some issues.

In this approach, calling the setState function inside the keyboard subscribe function will result in the keyboardModal component rendering repeatedly. This means that every time we subscribe to a new keyboard shortcut, the keyboardModal component will render again unnecessarily, even if it is not currently mounted to the DOM. This causes unnecessary re-rendering, which can be avoided.
Getting Current values from documentedShortcuts and Sorting it before setting it and on every subscribed keyboardShortcut when setting a new state is a performance issue that needs to be addressed.

shortcutsUpdateCallback(_.sortBy(_.values(documentedShortcuts), 'displayName'));

As I mentioned here. This will also require a workaround to resolve this side effect.
I think it may be over-engineering this issue because it is mainly related to the browser platform, but we need to consider the performance issues it may cause in other platforms, which adds more complexity.
For this it is working fine as I mentioned here

cc: @arosiclair @mollfpr

Sorry been busy never got back to this. Let's stick to the original proposal we agreed on. @tienifr's solution is cool but adds complexity for not much benefit (opening the shortcuts list while signing in is an edge case to say the least).

@Christinadobrzyn I'm on parental leave; re-assigning! A proposal has been accepted and is getting worked on at the moment

preping for payment..

@mollfpr do you think we need a regression test for this?
@mollfpr you're paid through Upwork correct?
@Charan-hs @chiragxarora are you paid through Upwork? if yes, can you please apply for the job here https://www.upwork.com/ab/applicants/1693559881555742720/job-details

Just bringing up this comment
The speed bonus timeline might need to be reevaluated.

Looks like the PR was created on Sept 5th
Final C+ review before merge was Sept 8th
Then there was a delay with the merge until Sept 11th because of a 'freeze'

So I think the bonus would actually apply here? @arosiclair @mollfpr?

So I think the bonus would actually apply here? @arosiclair @mollfpr?

Yeah that makes sense to me. There's no hard rule but here's a thread where we talked about it.

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I couldn't make sure if there's a PR causing the regression. The implementation was already there years ago, and a lot of changes on our keyboard shortcut handle.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Sign out from the app
Refresh the page (for iOS and Android you need to close and reopen the app)
Press cmd+j to open the shortcut modal (testing on iOS and Android required to use physical keyboard)
Verify escape key has been added
👍 or 👎

@chiragxarora I sent an Upwork invitation to you - here's the job posting - https://www.upwork.com/jobs/~01a6b0de738da985ac

Friendly bump @Christinadobrzyn

Regression test: https://github.com/Expensify/Expensify/issues/319173
This issue was created before Aug 30th so we'll adhere to the old payment scale
Payouts due:
Issue Reporter: $250 @chiragxarora
Contributor: $1000 + 500 speed bonus @Charan-hs
Contributor+: $1000 + 500 speed bonus @mollfpr
Eligible for 50% #urgency bonus? Y - https://github.com/Expensify/App/issues/25448#issuecomment-1721826915
Upwork job is here.
Paid! Thanks for all your help!


[common]: Remove logPersistence as it can be achieved with existing values

What this PR does:
Removes logPersistence functionality as it can be achieved with volumeMounts & extraVolumeClaimTemplates and is buggy anyway.
Checklist:

[x] Pull Request title in format [chart]: Changed Something
[x] Updated documentation in the  README.md.gotmpl file and executed helm-docs
[x] Chart Version bumped
[x] All commits are signed-off

According to the contributing guidelines, we should have a changelog in the README.
Can you add this?

According to the contributing guidelines, we should have a changelog in the README. Can you add this?

README.md.gotmpl was missing completly, fixed it.

update artifacthub annotations

done, hope it's correct like this.


Docs: Edit protocol trace ops procedures

Type of change

Documentation

Description

Checklist

[ ] Update documentation

Can one of the admins verify this patch?


Make dicts clone on write.

Depends on #963.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 92.32344% with 75 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (906719e) to head (625d7a2).
Report is 3 commits behind head on main.

Files with missing lines
Patch %
Lines

runtime/src/lib.rs
75.65%
37 Missing :warning:

src/executor/aot.rs
58.62%
12 Missing :warning:

src/values.rs
94.73%
11 Missing :warning:

src/bin/cairo-native-stress/main.rs
0.00%
6 Missing :warning:

src/executor/contract.rs
62.50%
6 Missing :warning:

src/libfuncs/felt252_dict.rs
96.55%
2 Missing :warning:

src/executor.rs
93.75%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   80.67%   80.86%   +0.19%
==========================================
  Files         107      108       +1
  Lines       29235    29763     +528
==========================================
+ Hits        23585    24069     +484
- Misses       5650     5694      +44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hide links on archived pages in broken link checker

Motivation

When broken links are on archived pages, they are less meaningful and can be ignored.
Proposed Solution

Remove links on archived pages from the broken link checker. We have to evaluate which of the following is more reasonable and efficient:

Leave the link objects in the database but filter them in the database query and do not show them in the list
Whenever a page is archived, delete all corresponding link objects. On restoring, we have to call save() on the page translations as well to make sure the links are being created again.

Alternatives

Additional Context

If the effort is low, then I would consider this high priority bcs we have explicitly told the Kommunen that they should have very few broken links. As long as broken links on archived pages are shown, they have no overview of how many links really are in need of fixing!

Not sure, but I think we need to open this up again. In Dachau for example I found some links on archived pages that show up: https://admin.integreat-app.de/stadtdachau/analytics/linkcheck/invalid/
See Quelle interpreter/translator

That's unfortunate :cry:
We have to do further research to tell whether this is actually a problem of the code or some kind of follow-up problem caused by our inconsistent production database.

I could verify that this is directly happening when scanning the links.
I ran the link scanning on the production system again and afterwards, many links were found in archived pages:
In [1]: from linkcheck.models import *

In [2]: Link.objects.filter(page_translation__page__explicitly_archived=True).count()
Out[3]: 25554

So something with this filter seems to be wrong:
https://github.com/digitalfabrik/integreat-cms/blob/a0b389f3d28f8c66ba152ec52246cd244bf93433/integreat_cms/cms/linklists.py#L50-L53

Ok, I found out the problem during the findlinks command on the prod system: We use a wrapper around the cli which did not pass the environment variable LINKCHECK_EXCLUDE_ARCHIVED_PAGES to the actual management command.
So the rest of this task remains an infrastructure ticket.

@timoludwig somehow broken links in archived pages and past events are showing up again: https://admin.integreat-app.de/kreishoexter/analytics/linkcheck/ignored/
We put them on ignore, but can you have a look nonetheless?

@osmers I think I found the potential problem: #2303
I'm going to close this issue for now and hope there is really nothing else going on.


Products gone after update?

Is it intended that after an update all products are deleted?

Frankly - no. To what version did you upgrade? From which? Add more products, run the upgrade script again by going to example.com/index.php/dashboard/extend/update/do_update/vivid_store - do they go away again?

can't test it. need to wait for your code cleanup to be finished.

I can confirm this is still happening, just hit this myself with up-to-date code

that's scary.

I can't quite put my finger on it why it's happening.
I had to do an update yesterday because I found some database table was missing a field.
I just incremented the package version in it's controller and triggered the update via the dashboard.
(just tried it again)
All tables controlled by the db.xml file are then emptied. It's only tables that are created via Doctrine that remain populated.

This happened also to me. All products and groups were disappeared after v. 3.0.1 update.

This has been fixed in the latest version of C5 (in git). Either I need to migrate many functions into the installer, or I've found another reason to move everything to ORM. Good lord.

but why are other settings still there like the currency-stuff but the products, discounts, orders, ..  are gone?

Same happened to me: settings were left but products were gone. Is there an significance, if you are moving store pages to another place in your C5 page hierachy?

@krebbi @julehti - it's a known issue I raised to C5. C5 keeps all the Config settings as well as all the database items managed by ORM entities. As of 3.0.1, only Shipping and Tax are managed by ORM. So any other custom database tables get wiped. C5 incorrectly assumes if you're using an ORM, then you're using it for everything and it will wipe all other custom tables.

hmm.. and could be the easier solution to move verything into ORM in the vividstore instead of waiting for portland to publish a new update?
regardless of this, wouldn't it a better style to have all DB-stuff in one place? ;)

@krebbi that is actually what is happening now. If you look at the Product stuff in /src/ its wildly cleaned up, broken into more appropriate classes, and all done in ORM.
Also, obviously, the Product interface is likely broken until that's complete.

may I ask why you guys commit code which is broken? Like right now trying to add a product results in:
Whoops\Exception\ErrorException thrown with message "Cannot redeclare Concrete\Package\VividStore\Src\VividStore\Product\Product::save()"
Stacktrace:
#0  in /public/packages/vivid_store/src/VividStore/Product/Product.php:335
and with such errors I'm asking myself if I need to open an issue or not, because they are so obvious?
I don't want to sound rude and this is a serious question.

That's probably a good question. The work I'm currently doing in the product class is pretty extensive, and following the rule to commit often, commit often is still hundreds of lines of changes. For such a long project, I should probably make a new branch, and I likely will next major class I work on after Product.

I believe this was an error more relating to concrete5 than vivid_store, quite a few c5 versions ago. So I'm closing this for now.


More encoding

New property "ResponseTextEncoding"  was added to  Web component.If the encoding of web page we request by web component is not UTF8,we cant get the right response content,ResponseTextEncoding property can be set and solve the issue.

Sorry for my text editer!

@wanddy Sorry this one has lingered. I expect it to be in the next component release.

@nicholec You may want to take a look at this as well.

@jisqyv Are we still committing to have this in the release on Dec 20? Other than a few minor whitespace issues and resolving of two minor conflicts this looks good to me.

This has been merged as 8c3afbcd1c426fff7fb0d393ee5c665516a3a528


Improve import tooling

With this merged, imports are sorted automatically as part of the eslint autofix step. For me this saves a lot of time that is usually needed to manually sort imports.

How come we can switch away from import x = require('x')? Was there a change in TS?

If I understand correctly, this is what the TS compiler setting esModuleInterop: true allows us to do

Updated


Added support for GITHUB_TOKEN in release.sh

We have started to run into needing higher API thresholds for our releases. This PR adds support for passing a GitHub token to release.sh in order to faciliate higher limits. In this PR:

Updated release.sh to support GITHUB_TOKEN

/cc @wlaurance

I am going to cowboy land this as another PR is waiting to be published due to a bad push =/


Corrections

Going through this and noticing a few things:

On page "Get Started", there's no mention of placing the homebrew_launcher.elf in the wiiu/apps/homebrew_launcher directory.  This is kind of important, as it makes loading the homebrew launcher from loadiine.ovh impossible.

On the "Homebrew Launcher" page:
Ensure that the drop down box shows “Homebrew Launcher…”, then press “Submit”
This should note that it needs to match the version of Homebrew Launcher.elf you have on the SD card, else it fails.

On both of the "Mocha CFW" pages, the following options aren't in the Mocha menu in v0.2 (latest):
SEEPROM redirection: on
OTP redirection: on
Use syshax.xml (coldboothax): off

Regarding the Mocha options, they appear when you select redNAND to be on.
The rest should be fixed in the latest upstream (if my changes appear
there, cause my Github is somehow glitching right now)
Jacob Peck<EMAIL_ADDRESS>schrieb am Fr., 10. März 2017, 15:14:

Going through this and noticing a few things:

On page "Get Started", there's no mention of placing the
homebrew_launcher.elf in the wiiu/apps/homebrew_launcher directory. This is
kind of important, as it makes loading the homebrew launcher from
loadiine.ovh impossible.
On the "Homebrew Launcher" page:
Ensure that the drop down box shows “Homebrew Launcher…”, then press
“Submit”
This should note that it needs to match the version of Homebrew
Launcher.elf you have on the SD card, else it fails.
On both of the "Mocha CFW" pages, the following options aren't in the
Mocha menu in v0.2 (latest):
SEEPROM redirection: on
OTP redirection: on
Use syshax.xml (coldboothax): off
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Plailect/Guide_WiiU/issues/4, or mute the thread
https://github.com/notifications/unsubscribe-auth/AWiZGLzgxFc71mWeA21PFS4axWaMAsvlks5rkVrCgaJpZM4MZbe_
.

Well.  That's weird.  Because I certainly set up RedNAND with Mocha v0.2 last night, and those options definitely did not appear.
I'll give it another go, I suppose...

I'll see if I can get the options again when I get home. Might be that it's not as easy as I described it, but it certainly was with the Fat32 Mocha build and the codebase didn't change.
Thanks for the suggestions though!

The option is definitely available. Weird...


chore(main): release 0.5.0

:robot: I have created a release beep boop
0.5.0 (2024-06-06)
Features

added SesProxyMailer (f21343d)

Bug Fixes

Vpc public subnet cidr collision (b83a790)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/smartstream-tv/pulumi-aws-toolbox/releases/tag/v0.5.0 :sunflower:


Item duplication while dragging multiple items into crafting grid.

The issue can be seen here: https://my.mixtape.moe/hoaegw.mp4
In the above link we start with 66 silver, I then drag a stack of silver to evenly distribute them across the crafting grid to make a block. However when I remove the block from the crafting grid no items get consumed and I get +9 silver leaving me at 75.
Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: <IP_ADDRESS>9
Refined Storage: 1.2.21 (this isn't the latest version but the patch notes don't mention this anywhere, I'll do an update later tonight/tomorrow to see if this is resolved in 22 or 23)

Does this issue occur on a server? [yes]

Is this a public mod pack? Or any other mods that can interfere with it, in other words does this happen in like a tinkers table or so?

I'm 99% sure this is an issue with the recipe / other mods interfering. From which mod is this silver?

I'm 99% sure this is an issue with the recipe / other mods interfering. From which mod is this silver?
There's a number of mods that add silver, the ingot is from Thermal Foundation. However it appears the block is from ProjectRed Exploration.
Is this a public mod pack? Or any other mods that can interfere with it, in other words does this happen in like a tinkers table or so?
This is a private pack for >10 people. I tried this in a Tinker's Construct table and it crashed the client. That crash log can be found here however I don't believe this to be a mantle issue as the stack trace implies. I don't believe this is a refined storage issue either.

This appears to be a problem with project red. It seems the mod registers a number of block forms of the ores it adds. JEI lists no recipe for these blocks however trying to craft them the usual way appears to work. All crafting tables actually crash the recipe however Refined Storage seems to make the resulting item without using resources instead.


Grid issues

Hi Astrit,
I found some issues in you fabulous grid.

There are no gap space in the horizontal (row) line. (see picture)
Specifying different values for the gap (Example: gap="l:xl m:l s:xs") doesn't have any effect. Alvays 32px for all view ports.

Bonus feedback. https://sebgroup.github.io/green/latest/core/?path=/docs/components-grid--page
The values on columns should have the size/media value besides the amount of columns.

<gds-grid columns="8 4 2" auto-columns="l:200 m:100 s:80">

(columns="l:8 m:4 s:2").

@astrit

Hi @daggelito02
Super nice that you already started to use Grid, and happy to know you like it.
Now to answer your questions:

There isn't at the moment a functionality to add row gap, we might introduce that feature in the future this could be a good test, how ever it is meant to do that by adding margin-block-end to the child it self at least for now.
That is a bit odd on my setup it works and I did test it out again to make sure but we can take a closer look at your setup and try to debug.

Here is an example on the core-lib-dev

Good catch on the last one as that is a typo actually only on the documentation as in fact still needs the device prefix.
Let me know when we can check on this!
🤘

@daggelito02 these issues were addressed on PR: #1302 , which has been published. Please upgrade core to 1.12.0
The release:
https://github.com/sebgroup/green/releases/tag/%40sebgroup%2Fgreen-core%401.12.0


Connection TimeOut

How i can increment the timeout from the laravelfacebooksdk, i get the error:
[Facebook\Exceptions\FacebookSDKException]
Operation timed out after 0 milliseconds with 0 out of 0 bytes received

Hi, i modified this files to allow a new http_client_handler
I create a new instance and in this i update the htt_client_handler, i update the composer.json for read the Facebooksdk classes.
composer.json
//
"autoload": {
"classmap": ["database","/var/www/laravel/vendor/facebook/graph-sdk/src/Facebook"]
//
/*/
class LongerTimeoutHttpClient extends Facebook\HttpClients\FacebookStreamHttpClient
{public function send($url, $method, $body, array $headers, $timeOut){
$timeOut = 4;
return parent::send($url, $method, $body, $headers, $timeOut);}}
//
xxxx.php
/**********************************************/
$fbStream = new Facebook\HttpClients\FacebookStream;
$fb2 = $fb->newInstance([
'app_id' => env('FACEBOOK_APP_ID'),
'app_secret' => env('FACEBOOK_APP_SECRET'),
'default_graph_version' => 'v2.9',
'http_client_handler' => new LongerTimeoutHttpClient($fbStream),]);
Is this the right way?, there's another, pls, allow me to know.


Add File Upload To Event Creation

We need a place for CELTS admins to be able to drag and drop and upload files when creating/editing an event.  The file(s) uploaded should be viewable on volunteer view after upload.

 CELTS #40: Add File Upload To Event Creation

This issue should be addressed once issue #383 is completed and merged into development.


Upgrading unit tests with Karma, Mocha, Webpack

It turns out that unit testing Chrome plugins is somewhat complex.
This is in-progress but demonstrates a functional framework for accomplishing unit tests. Features include: Karma runner (headless Chrome), Mocha/Chai framework, Sinon mocks (incl. sinon-chrome extension API).
The download() helper method is problematic. I haven't found a good way to mock this behaviour OR get it to not error in several iterations of unit tests. Currently the method has been adjusted to use window.location.assign() inside an isolated method in hopes of being able to mock assignLocation(url) in its entirety, but this still results in navigation events. This also doesn't allow for file download naming as was previously implemented. If you want to keep this functionality, perhaps we can revert it.
I tested https://www.npmjs.com/package/fake-indexeddb but found many issues in tandem with https://www.npmjs.com/package/jsdom-global. This setup now uses a live IndexedDB instance instead of mocks, and it seems to work. The background.js test is currently failing but I think it's possible to fix it and continue testing the other functions.
One notable change in background.js and download_helper.js is the introduction of window.onload = init;. This is done so that the file can be loaded as a module (a la import * as helper from '../src/download_helper';) and it doesn't evaluate its contents immediately, creating errors. Instead by binding the "init" to a window.onload event it runs properly once mounted in browser, and stays nicely contained in a module for unit tests.
Give it a shot:
git fetch
git checkout feat/mocha-webpack
npm install
npm run test:watch

By all means feel free to pick this up if you'd like to write some tests!

@emcniece
Just keep in mind with the download_helper.js that it has changed significantly. The download_helper.js  currently on develop is just a sketch and so I would not recommend touching it at all.
I have it basically finished on a branch BUT I can't merge without blowing away all this stuff. Which likely means I need to implement tests on my branch first.
Again, I appologize that this code was in the repo (I just needed a place for it to live until I could do something with it).

No worries! Thanks for the clarification.
The latest commits implement tests for background.js. I've tried to keep the code changes to a minimum, but there are some considerations we'll have to talk about for implementing modular unit tests with dependency injection. For example, turning this file into an ES6 class might simplify some of the calls to local functions, and might remove the need for referencing storeName constantly while still preventing it from being a global. A class would also let us mock and inject chrome.runtime* so that we could test the internals of the init() method.
Exploring classes would also have a significant impact on label_view.js and might actually be necessary to test this file effectively. I started on it tonight but am having trouble mocking and setting the global variables.
I had a question for setVal(): what is the benefit for the current implementation over something simpler like db.put()?


Generalize to handle generic SSL-encrypted TCP traffic

mitmproxy is fantastic for intercepting and modifying HTTP/HTTPS traffic.  However, not all network traffic of interest fits into this category.  For example, XMPP is a protocol which is XML based and does not rely on HTTP.   In order to be able to handle traffic for these cases, we want to be able to support the capture of generalized TCP traffic which is SSL'ed.

[x] Test and merge SOCKS support
[ ] Add --tcp switch and add checks for such around check_ignore_address/establish_ssl

The following are some slightly cleaned up comments from @mhils on IRC:
TL;DR: --ignore is checked before any call to establish_ssl() (which does the MITM stuff). If you want to intercept non-HTTP TLS connections, you probably want to  do something similar, but after establish_ssl() has been called.
generalized tcp proxy: if your traffic isn't encrypted using SSL, just use mitmdump -v --ignore regex-for-your-host (0.11 only) ignore patterns are documented here
We currently have a couple of places where we call check_ignore_address() and may go over to TCP mode then. usually, check_ignore_address is closely followed by establish_ssl().  We'd need to add a --tcp switch which uses the same hostname pattern, but just gets executed after establish_ssl(), not before.
well, we have a "generalized tcp proxy". which is  "-v --ignore hostname", but if your traffic is protected using SSL, you probably want to strip that off before. By default, mitmproxy opens a SSL connection to the client and a separate SSL connection to the server. pretending to the client to actually be the server... Using --ignore, we don't event do anything SSL related, we take the raw TCP stream and forward it which means the client negotiates SSL with the real server.
In other words, --ignore can be used to see what passes through, but if that communication is protected using SSL, you'll just see garbage.  Now, you may ask: Why don't we do the SSL-MITM stuff and then pass through the cleartext, now readable for us?
Answer: --ignore serves a different purpose. Some apps, most notably the apple store on iOS, cannot be intercepted, because they hardcoded a target cert we don't have a key for. --ignore makes it possible to debug an app while just letting this stuff pass through.
e.g. you want to test an app which at some point makes an cert-pinned in-app purchase.
So, that's the primary use case for --ignore.
If you want to peek into non-HTTP SSL connections, you'd do our SSL MITM stuff first and then delegate it to the passthrough thingy.

first, thank you, contributors of mitmproxy. I have a bit of problem, I would like to take this feature a step further; but first let me establish to you my background in using this feature. Please bear in mind that I am new to mitmproxy.
I am currently successfully performing a TCP SSL mitm session with a client cert. I want to record the decrypted stream as direct binary. handshaking info is good auxiliary debug info, but ultimately I want a sole dump of only the decrypted ssl conversation. Not knowing how to do this directly in mitmproxy, I instead had mitmproxy output a pre master secret file which I configured Wireshark to use. this method was successful until I realized that I am suffering from packet loss due to the high volume high frequency of packets... I did try playing around with Wireshark settings, but it is too clear to me that if I only knew how to get mitmproxy to simply share the decrypted information with me in the style I prefer,I would be golden. This is because mitmproxy is in the direct path of the packets, unlike Wireshark, which is only an observer.
So, I ask one of you to please educate me on two points. Can mitmproxy already do what I seek? If so, please provide some detail in enabling the functionality. If it is not yet available, but you know what file(s) or function(s) are the key locations to modify with additional logging functionality, please let me know. Thank you.

Hi, I come with an update to my previous question (see above). I have discovered several things, some spawning further questions.

I am using --raw-tcp instead of --tcp -- and I've become curious whether one is preferred over the other? --raw-tcp works for me, but given the description of --tcp here, it sounds like it would also perform the exact same duties (SSL Mitm w/ decryption). Please correct me if I'm wrong.
I discovered how to have mitmproxy dump the decrypted SSL conversation to file (in the context of --raw-tcp).. Since my experience is with --raw-tcp and not --tcp, I filed a new issue on this (https://github.com/mitmproxy/mitmproxy/issues/866).

I look forward to your correspondence.
Sincerely,
bazz


vegacapsule does not find vega binary unless vega is in the PATH

unless I do: export PATH=$PATH:/Users/claudiumilea/vega/repos/networkdata
vegacapsule does not find the vega binary
claudiumilea@Claudius-MacBook-Pro networkdata % ./vegacapsule network bootstrap --config-path /Users/claudiumilea/vega/repos/system-tests/vegacapsule/capsule_config.hcl --home-path /Users/claudiumilea/vega/repos/networkdata
Error: failed to parse config file: failed to validate config: failed to set absolute paths: failed to get absolute path for "vega": failed to look up path for "vega": exec: "vega": executable file not found in $PATH
Usage:
./vegacapsule network bootstrap [flags]
Flags:
--config-path string           Path to the config file to generate network from
--do-not-stop-on-failure       Do not stop partially running network when failed to start
--force                        Force creating even if folders exists
-h, --help                         help for bootstrap
--install                      Automatically installs latest version of vega, data-node and wallet binaries.
--install-release-tag string   Installs specific release tag version of vega, data-node and wallet binaries.
Global Flags:
--home-path string   Specify the location of network home directory (default "/Users/claudiumilea/.vegacapsule/testnet")

This is not a bug but rather expected behaviour. You have to change the binary path in the capsule_config.hcl if you want to behave differently.


Deleting model objects from Admin not triggering BEFORE_DELETE and AFTER_DELETE hooks

Calling model_object.delete() successfully calls both BEFORE_DELETE and AFTER_DELETE hooks but if the same object is deleted from Django admin the hooks are not being called.

I met the same issue but found out it had been explained and addressed by official Django doc: https://docs.djangoproject.com/en/dev/ref/contrib/admin/actions/#admin-actions

As @eplutus said, this is a limitation of Django itself. It's explained in the docs, and it says some possible workarounds.
I'm closing this as there's nothing more we can do.


Youtube download stops short then fails to get any data blocks

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.08.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.08.04

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

This error is related to settings in my config file which I have not changed for months, this one video fails, all other vids have had no issue. Moving the config allows this video to download with default settings.
My format list ends with best so I expect it to accept whatever format is available if my desired formats are not there.
Error log is two attempts, one start and one to continue after fail
% youtube-dl -v "https://www.youtube.com/watch?v=7aeQ8TT859Q"
[debug] System config: []
[debug] User config: [u'-o', u'%(autonumber)03d_%(playlist_index)s_%(title)s_%(extractor)s_%(id)s.%(ext)s', u'--ignore-errors', u'--restrict-filenames', u'--continue', u'--sub-lang', u'en', u'--embed-subs', u'--ffmpeg-location', u'/usr/local/bin/ffmpeg', u'--format', u'22/136+140/137+140/136+bestaudio[ext=m4a]/137+bestaudio[ext=m4a]/bestvideo[height<=?720][ext=mp4]+bestaudio[ext=m4a]/bestvideo[height<=?1080][ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best', u'--merge-output-format', u'mp4']
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=7aeQ8TT859Q']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.15 (CPython) - FreeBSD-11.2-PRERELEASE-amd64-64bit-ELF
[debug] exe versions: ffmpeg 4.0, ffprobe 4.0, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 7aeQ8TT859Q: Downloading webpage
[youtube] 7aeQ8TT859Q: Downloading video info webpage
[debug] Invoking downloader on u'https://r4---sn-ppoxu-5qaz.googlevideo.com/videoplayback?mv=m&fvip=2&mt=1533347913&ratebypass=yes&ms=au%2Crdu&signature=6FA5B44D1BC94104C2A70A25F20ADCBF64F56C30.D51258D6B32F551CE8F2AABF0453BEC6360D2C0B&source=youtube&c=WEB&initcwndbps=775000&mn=sn-ppoxu-5qaz%2Csn-ntq7yn7l&mm=31%2C29&requiressl=yes&id=o-ANegjijBqaJ_SmMwmy2CtW5IIj0wZs0oBGbQKga6Wkxt&expire=1533369645&ipbits=0&key=yt6&mime=video%2Fmp4&sparams=dur%2Cei%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cexpire&dur=492.332&itag=22&ei=zQhlW4fcHYXq4gLZ3oi4Aw&pl=34&lmt=1533338502510130&ip=2001%3A44b8%3A2ae%3A7800%3A92%3A4c4c%3Ae0d5%3Ae9d9'
[download] Destination: 001_NA_DARK_TOWER_Un-Used_Concept_Designs_ADI_youtube_7aeQ8TT859Q.mp4
[download]   0.4% of 53.30MiB at 793.71KiB/s ETA 01:08[download] Got server HTTP error: Downloaded 242145 bytes, expected 55887033 bytes. Retrying (attempt 1 of 10)...

ERROR: Did not get any data blocks
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 342, in real_download
    return download()
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 320, in download
    retry(err)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 225, in retry
    raise RetryDownload(e)
RetryDownload

% youtube-dl -v "https://www.youtube.com/watch?v=7aeQ8TT859Q"
[debug] System config: []
[debug] User config: [u'-o', u'%(autonumber)03d_%(playlist_index)s_%(title)s_%(extractor)s_%(id)s.%(ext)s', u'--ignore-errors', u'--restrict-filenames', u'--continue', u'--sub-lang', u'en', u'--embed-subs', u'--ffmpeg-location', u'/usr/local/bin/ffmpeg', u'--format', u'22/136+140/137+140/136+bestaudio[ext=m4a]/137+bestaudio[ext=m4a]/bestvideo[height<=?720][ext=mp4]+bestaudio[ext=m4a]/bestvideo[height<=?1080][ext=mp4]+bestaudio[ext=m4a]/best[ext=mp4]/best', u'--merge-output-format', u'mp4']
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.youtube.com/watch?v=7aeQ8TT859Q']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.08.04
[debug] Python version 2.7.15 (CPython) - FreeBSD-11.2-PRERELEASE-amd64-64bit-ELF
[debug] exe versions: ffmpeg 4.0, ffprobe 4.0, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 7aeQ8TT859Q: Downloading webpage
[youtube] 7aeQ8TT859Q: Downloading video info webpage
[debug] Invoking downloader on u'https://r4---sn-ppoxu-5qaz.googlevideo.com/videoplayback?sparams=dur%2Cei%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cexpire&ip=2001%3A44b8%3A2ae%3A7800%3A92%3A4c4c%3Ae0d5%3Ae9d9&itag=22&ei=1QhlW8uFBJzk4ALClJa4BA&requiressl=yes&lmt=1533338502510130&mt=1533347978&expire=1533369653&ratebypass=yes&fvip=2&source=youtube&initcwndbps=775000&ipbits=0&pl=34&mv=m&c=WEB&ms=au%2Crdu&mm=31%2C29&key=yt6&signature=18219264F372B4759F2825CD569A83DDF110F7DF.FD9C989D3FD02E87199F939D261D07FADEAEEC&id=o-AC9hRwiRl5YopesqCWlAly3R3DnhxS2zJX1-NYFgiZn9&dur=492.332&mime=video%2Fmp4&mn=sn-ppoxu-5qaz%2Csn-ntqe7n76'
[download] Resuming download at byte 242145

ERROR: Did not get any data blocks
  File "/usr/local/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/local/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/local/bin/youtube-dl/__main__.py", line 19, in <module>
    youtube_dl.main()
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 467, in main
    _real_main(argv)
  File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 457, in _real_main
    retcode = ydl.download(all_urls)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2001, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 803, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 857, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1635, in process_video_result
    self.process_info(new_info)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1908, in process_info
    success = dl(filename, info_dict)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1847, in dl
    return fd.download(name, info)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 364, in download
    return self.real_download(filename, info_dict)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 342, in real_download
    return download()
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 312, in download
    self.report_error('Did not get any data blocks')
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 165, in report_error
    self.ydl.report_error(*args, **kargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 620, in report_error
    self.trouble(error_message, tb)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 582, in trouble
    tb_data = traceback.format_list(traceback.extract_stack())

same issue in Linux (Ubuntu) , under latest version.

@sambler Can you reproduce the error because this seems to work for me.

@mzfr yes it still happens, just checked with a62460aa213c
It is using the option --format best or ending format options with best, that causes the fail. I have it in my rcfile.

Youtube server side fault for format 22. Nothing to do with youtube-dl.

@dstftw how is youtube-dl requesting a non-existent format not a youtube-dl issue?
best should be the default format but specifying best causes the download to fail, while not specifying a format works.

Just noting that this is likely Youtube's fault - their CDN doesn't have the entire video of the default choice (likely in mp4). Videos loaded on modern browsers are webm by default.
I've tested this against the url in @VitaliyLazebny 's post above and the one URL from the first post.
Just switch to -f webm
./youtube-dl -f webm Vg45zf2b_YI

An alternative is to add some code to retry on missing content, but I think it's more trouble than it's worth, given that we can't easily anticipate whether Youtube's CDN lost their data or not.

Just noting that this is likely Youtube's fault - their CDN doesn't have the entire video of the default choice (likely in mp4). Videos loaded on modern browsers are webm by default.

@Ngo-The-Trung Your missing the point. If I just say get this video, it works. But if I give the option of wanting 720-mp4 or best available if no 720-mp4 is found - it fails. When the user specifies best available format as an option is when it fails to find the available format, but as a default option it is able to find the best available.
I have a list of formats in my rcfile, with best at the end. If I remove the rcfile I can get these videos.

@VitaliyLazebny "best" means "best advertised". If the page advertises that it has a format, the CDN can still have a broken download. i.e. the page "lies" about the format. Which is why the download starts (you can see the download progress bar) but it fails halfway through.
The only way to know is to start downloading the file, but as I said in theory the download could take you an hour only to fail at the last second. Retrying with another format isn't the most elegant solution.

I would like to suggest instead of
"ERROR: Did not get any data blocks"
the message should be
"ERROR: Did not get any data blocks (Server side youtube failure. Select another format.)"
This is a known issue and youtube-dl should mention it (otherwise people like me will keep opening Issues for it)

This does not necessarily mean that. As for opening new issues you must use search before posting duplicates.


BANDSB rework

This updates the existing BANDSB implementation to parse representative sample data. It extracts data from the same sample used for MATESA, and builds on #497 infrastructure.
The key changes are to the TRE parsing, because BANDSB uses a four-byte float representation (i.e. IEEE-754 binary) as well as the more typical ASCII encoded floating point values (and hyphen-minus fill versions of that). I've added 'f' for the ASCII floating point representation, and 'F754' for the IEEE-754 binary representation. A better name would be appreciated.

Thanks for this PR @bradh; especially for including the test data and test. We had a few concerns (and found another underlying SarPy bug) for which we've submitted a slightly different approach in #502. Does the modified behavior in that PR still address your use case?

Haven't tried it, but I don't see any problems. Will close this in favour of #502.


Update links to example configs in documentation

Links to the example config files point in the documentation to the now deleted dummy-main branch.
data_config.yaml
training_config.yaml
metrics_config.yaml
plotting_config.yaml
Update the links to point to correct config file in the main branch (see here).

I forgot this link is also broken: https://github.com/CosmoStat/wf-psf/blob/146725f2c2209bf3174c88c07a116e9ce28fff9a/docs/source/configuration.md?plain=1#L286
It should be replaced with this one: https://github.com/CosmoStat/wf-psf/blob/146725f2c2209bf3174c88c07a116e9ce28fff9a/config/configs.yaml

In certain sections, there are missing links as illustrated below. These links need to be added ?
https://github.com/CosmoStat/wf-psf/blob/146725f2c2209bf3174c88c07a116e9ce28fff9a/docs/source/configuration.md?plain=1#L341
https://github.com/CosmoStat/wf-psf/blob/146725f2c2209bf3174c88c07a116e9ce28fff9a/docs/source/configuration.md?plain=1#L207
https://github.com/CosmoStat/wf-psf/blob/146725f2c2209bf3174c88c07a116e9ce28fff9a/docs/source/configuration.md?plain=1#L209

No. not from a commit state. You should add the links to the files in the main branch.


[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.16.3

:rocket: This is an automated Pull Request.
This PR updates the Pipfile to sync with latest Codeflare-SDK release.

/retest

/retest

/retest

/test ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror

/override ci/prow/notebooks-e2e-tests


Add code documentation to engine template

The engine template should have code documentation indicating what should be coded in each phase of the project. i.e.: In the execute method of the acquisitor.py base file, a comment saying that the user should implement the logic for data acqusition and cleaning should be inputed.

hi @lucasbm88 , i found the acquisitor_and_cleaner.py file in every engine template already has your execute method commented like:
def execute(self, **kwargs):
"""
Setup the initial_dataset with all cleaned data necessary to build your dataset in the next action.
    Eg.

        self.initial_dataset = {...}
    """
    self.initial_dataset = {}

Is this issue already done by somebody, or you mean more detailed documentation?


Hint on table and column names

Will probably require #11 and table name caching to be performant enough for real-time suggestions.


Exception in Flutter Gallery / Dialogs Demo

Steps to Reproduce

Run the gallery app, go in the Dialogs Demo.
Click on Confirmation
Click on Cancel
Click on Confirmation

Expected: Dialog opens again.
Error: No dialog opens.
Logs
E/flutter (25891): [ERROR:../../lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
E/flutter (25891): 'package:flutter/src/material/time_picker.dart': Failed assertion: line 775 pos 10: 'initialTime != null' is not true.
E/flutter (25891): #0      _AssertionError._throwNew (dart:core-patch/errors_patch.dart:24)
E/flutter (25891): #1      _AssertionError._checkAssertion (dart:core-patch/errors_patch.dart:31)
E/flutter (25891): #2      showTimePicker.<showTimePicker_async_body> (package:flutter/src/material/time_picker.dart:775:10)
E/flutter (25891): #3      Future.Future.microtask.<anonymous closure> (dart:async/future.dart:144)
E/flutter (25891): #4      _microtaskLoop (dart:async/schedule_microtask.dart:41)
E/flutter (25891): #5      _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)

Flutter Doctor
 ❯ flutter doctor                                                                                [19:11:03]
[✓] Flutter (on Linux, channel master)
    • Flutter at /home/joel/code/flutter
    • Framework revision d0ff41ec35 (25 hours ago), 2016-11-10 15:33:02
    • Engine revision 84a060820a
    • Tools Dart version 1.21.0-dev.3.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.0)
    • Android SDK at /opt/android-sdk
    • Platform android-25, build-tools 25.0.0
    • ANDROID_HOME = /opt/android-sdk
    • Java(TM) SE Runtime Environment (build 1.8.0_112-b15)

[✓] IntelliJ IDEA Ultimate Edition (version 2016.3)
    • Dart plugin installed
    • Flutter plugin installed

[✓] Connected devices
    • Nexus 6P • 84B7N15A10004400 • android-arm • Android 7.1.1 (API 25)

The problem is in this line:
https://github.com/flutter/flutter/blob/master/examples/flutter_gallery/lib/demo/dialog_demo.dart#L186
                if (value != _selectedTime) {

Should be:
                if (value != null && value != _selectedTime) {

Created a pull request https://github.com/flutter/flutter/pull/6833

Closing this PR landed.


add / remove moderators

Sort if works. On desktop I can Add John Lazurus as a mod, but can't change user to anyone else. On Mobile, I can add Jacque but no one else. the moderator box doesn't respond to input or offer an option to type anything in.  I can remove mods.

@fixedelineation you can only add moderators here from people you're following, otherwise you can do it from their profile. It's not good UX to take user input here since the information we need to add someone as a moderator is their display name and public key. You likely don't know a user's public key and typing it is a disaster.


Upgrade to Fabric 2.1

Is your feature request related to a problem? Please describe.
Assess whether changes from Fabric 2.0.1 to 2.1 affect any FPC code/protocol/design aspects and upgrade build, config files and scripts to rely on fabric 2.1
Additional context
Release Notes Fabric v2.1

Only change which somewhat affects us is that fabric requires now go version 1.14.1 ...


ZMQ stuck on exception, finally section is not executed

Hi! Thanks you for cool library :-)
I faced with problem on handling application exception.
If I init ZMQ Context and Socket and then my application failed due to some exception (or Ctrl+C doesn't matter), all python code stops, but process still run (see main1 in examples below).
Can you please explain such behavior?
This is very unuseful if you run program with docker-compose restart=always,
failed program will just run forever!
As far as I understand I have to destroy Context manually (but it is not clear why)
If I wrap execution in try/except (see main2), but on exception program does not go to finally section at all! (in normal execution it does, see main0).
Why finally section is not executed when I use zmq?
So the solution I use is atexit.register, then destroy-code is executed and program exit. But it's weird.
import asyncio
import atexit

import zmq.asyncio

async def foo_print():
    while True:
        print('foo_print')
        await asyncio.sleep(1)

async def foo_zmq():
    context = zmq.asyncio.Context.instance()
    socket = context.socket(zmq.PUB)
    bind_to = 'tcp://*:20000'
    socket.bind(bind_to)
    while True:
        print('foo_zmq')
        await asyncio.sleep(1)

async def main0():
    """ Nothing: try-except (works as expected) """
    try:
        await foo_print()  # press Ctrl+C here
    except:
        pass
    finally:
        print('finally')  # this will be called

async def main1():
    """ ZMQ: just run (stuck on exception) """
    await foo_zmq()  # press Ctrl+C here

async def main2():
    """ ZMQ: try-except destroy (doesn't work) """
    try:
        await foo_zmq()  # press Ctrl+C here
    except:
        pass
    finally:
        print('finally')  # it will be never called!
        zmq.asyncio.Context.instance().destroy(linger=0)  # this is too
        # so program will stuck until you press Ctrl+C twice!

async def main3():
    """ ZMQ: atexit destroy (works) """
    def final():
        print('finally')  # it will be called!
        zmq.asyncio.Context.instance().destroy(linger=0)  # this is too
    atexit.register(final)
    await foo_zmq()  # press Ctrl+C here

if __name__ == '__main__':
    # asyncio.get_event_loop().run_until_complete(main0())  # check nothing (works as expected)
    asyncio.get_event_loop().run_until_complete(main1())  # ZMQ: just run (stuck on exception)
    # asyncio.get_event_loop().run_until_complete(main2())  # ZMQ: try-except destroy (doesn't work)
    # asyncio.get_event_loop().run_until_complete(main3())  # ZMQ: atexit destroy (works)

Environment:
(.venv) vsmelov@blocktech-008:~/PycharmProjects/base_price_publisher$ python -V
Python 3.6.6
(.venv) vsmelov@blocktech-008:~/PycharmProjects/base_price_publisher$ pip freeze | grep zmq
You are using pip version 10.0.1, however version 18.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
pyzmq==17.0.0
(.venv) vsmelov@blocktech-008:~/PycharmProjects/base_price_publisher$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic

>>> print("libzmq-%s" % zmq.zmq_version())
libzmq-4.1.6
>>> print("pyzmq-%s" % zmq.pyzmq_version())
pyzmq-17.0.0
>>> print("Python-%s" % sys.version)
Python-3.6.6 (default, Sep 12 2018, 18:26:19)
[GCC 8.0.1 20180414 (experimental) [trunk revision 259383]]

This is an asyncio issue with KeyboardInterrupt, not a pyzmq issue. It can be reproduced with:
import asyncio

async def main():
    try:
        print("interrupt me!")
        await asyncio.sleep(10) # Ctrl-C here
    finally:
        print("finally!") # will not occur on KeyboardInterrupt

if __name__ == '__main__':
    asyncio.get_event_loop().run_until_complete(main())

Sending SIGINT raises KeyboardInterrupt in the eventloop, not in the waiting coroutines. So the coroutine runner stops, not the apparently blocking functions. This is one of the weird things about async programming. While you are blocking, the foo_zmq function is not running, so signals received are not handled by the zmq functions (or any other async-blocking function). If you do want a try/finally on keyboardInterrupt, it needs to be around run_until_complete, not inside coroutines:
try:
    asyncio.get_event_loop().run_until_complete(main())
finally:
    cleanup()

The finally block in your code will run if the zmq calls actually raises exceptions, such as timeouts, etc.

Thank you for response :-)
Actually, my problem was with stuck program on exiting.
When we faced with exception program did not exit. It just stops run any python code but did not actually exit. I tried to solve the problem with destroying zmq Context (then it exits).
But when I switched to the new version.
pyzmq==17.1.2

The problem was gone. I now do not need to call destroy explicitly.

good to know!


WindowsContainerNetworking-LoggingAndCleanupAide.ps1 Script Failed:The target of the specified cmdlet cannot be a Windows client-based operating system.

** Description**
Running with either -Cleanup or -Cleanup -ForceDeleteAllSwitches I  get
the error
PS C:\Windows\system32> C:\Users\miken\WindowsContainerNetworking-LoggingAndCleanupAide.ps1 -Cleanup -ForceDeleteAllSwitches

Status   Name               DisplayName
------   ----               -----------
Running  docker             Docker Engine
Script Failed:The target of the specified cmdlet cannot be a Windows client-based operating system.

Link to doc: https://github.com/MicrosoftDocs/Virtualization-Documentation/tree/live/windows-server-container-tools/CleanupContainerHostNetworking

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:28: python_build_tool_in_run: The python build tool setuptools is in run depends
ERROR: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:34: missing_pip_check: For pypi packages, pip check should be present in the test commands
ERROR: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_616tvaehad/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
Errors were found


Bump IntelliJ version

Bumped the IntelliJ version, built and tested it, installed it in IntelliJ 2018.1 and opened a project in which it is used. Seems to work.

Codecov Report

Merging #466 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #466   +/-   ##
=========================================
  Coverage     62.72%   62.72%
  Complexity     1408     1408
=========================================
  Files           174      174
  Lines          5245     5245
  Branches       1194     1194
=========================================
  Hits           3290     3290
  Misses         1442     1442
  Partials        513      513

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19913c...d90759f. Read the comment docs.


Adding the r5.16xlarge to the ebs optimized list

PR o'clock
Description
The r5.16xlarge is missing from the list
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/ebs_optimized_test_fixture directories (look in CI for an example)
[ ] Tests for the changes have been added and passing (for bug fixes/features)
[ ] Test results are pasted in this PR (in lieu of CI)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Any breaking changes are noted in the description above

This issue has been resolved in version 0.2.1 :tada:


Expose a constructor for Map Input Source

This makes it so people can more easily write their own sources
on top of altsrc. In addition, it changes the struct from map[interface{}]
to map[string] as all keys must be strings.

Given that this PR is from last year, I think I'm comfortable closing it 🙂 feel free to re-open / open a new PR if there's still interest here!


Fix typo

Thanks to useful mock server :)

Thank you for noticing the mistake :)
Merged in manually (please use develop for pull requests in the future :) ).


Better type support

Improve type support.

[x] string
[x] number
[x] integer
[x] boolean
[x] object
[x] array
[x] datetime
[x] date
[x] time
[x] duration (moved https://github.com/frictionlessdata/jsontableschema-sql-py/issues/23)
[x] geopoint (moved https://github.com/frictionlessdata/jsontableschema-sql-py/issues/26)
[x] geojson
[x] any (moved https://github.com/frictionlessdata/jsontableschema-sql-py/issues/24)

FIXED
https://github.com/frictionlessdata/jsontableschema-sql-py/pull/25

FIXED


Board Review: Form Recognizer V2.1 Service Introduction Meeting

The Basics

Service team responsible for the client library: Form Recognizer
Link to documentation describing the service: https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/overview
Contact email (if service team, provide PM and Dev Lead): Sandeep Parab (@ramparab), Neta Haiby (don't know her @, sorry), Xin Zou (@xinase)

About this client library

Name of the client library: Form Recognizer
Languages for this review: All languages (this is an introductory session)
Link to the service REST APIs: This is a link to the 2.1-preview.1 swagger

FR is a library that "... is a cognitive service that lets you build automated data processing software using machine learning technology". We have already GA'd a client SDK with the service's 2.0 API endpoint. In this meeting, the service team will introduce us to the new features they hope to introduce in 2.1. The main additions are listed below:

Prebuilt model to analyze business cards
Compose multiple custom models into one model
Ability to analyze receipts from multiple locales (previously it just analyzed receipts from the US)

Champion Scenarios
TODO: (@ramparab @xinase can your team fill this section out, for an ex, see this issue's Champion Scenarios section)
A champion scenario is a use case that the consumer of the client library is commonly expected to perform.  Champion scenarios are used to ensure the developer experience is exemplary for the common cases.  You need to show the entire code sample (including error handling, as an example) for the champion scenarios.

Champion Scenario 1:

Describe the champion scenario
Estimate the percentage of developers using the service who would use the champion scenario
Link to the code sample

_ Repeat for each champion scenario _
Examples of good scenarios are technology agnostic (i.e. the customer can do the same thing in multiple ways), and are expected to be used by > 20% of users:

Upload a file
Update firmware on the device
Recognize faces in an uploaded image

Examples of bad scenarios:

Create a client (it's part of a scenario, and we'll see it often enough in true champion scenarios)
Send a batch of events (again, part of the scenario)
Create a page blob (it's not used by enough of the user base)

Agenda for the review
A board review is generally split into two parts, with additional meetings as required
Part 1 - Introducing the board to the service:

Review of the service (no more than 10 minutes).
Review of the champion scenarios.
Get feedback on the API patterns used in the champion scenarios.

After part 1, you may schedule additional meetings with architects to refine the API and work on implementation.
Part 2 - the "GA" meeting

Scheduled at least one week after the APIs have been uploaded for review.
Will go over controversial feedback from the line-by-line API review.
Exit meeting with concrete changes necessary to meet quality bar.

Thank you for your submission

scheduled for 10/8

Champion Scenario 1: Model Compose
Describe the champion scenario
A user had created 100 models for 100 different types of documents.  Now for each incoming document, which model should the user route the document to extract key/value?  Currently, a user has to classify the documents using self-built methods which are costly and inaccurate.   with Model Compose  feature,  they could let Form Recognition Services do the classification and expect a high quality result with similar analyze() call to the composed model.
Expect: Form Services should support such scenario in our API:

User could create a collection of models by calling  Compose()
This model collection would react to the Analyze() call with the best result returned, the same ways as we call a single model.

Estimate the percentage of developers using the service who would use the champion scenario

about 30% of customers would run into "how to classify different models" problem,  Model Compose could be their solution.
Link to the code sample
tbd

Champion Scenario 2: Analyze Business Card (it also applies to Analyze Id Document, Receipts, and Invoice)
Describe the champion scenarios
A customer has collected many business cards during a work event and would like to extract all the relevant information to potentially feed it to a contact list, or an automated distribution list to thank the hosts and organize follow-ups. With the Analyze Business Card operation , extracting the key information from business cards in the form of key/value pairs
Estimate the percentage of developers using the service who would use the champion scenario
This Operation is quite specialized and doesn't offer many more scenarios
Link to the code sample
We don't have sample code just yet.

Video [MS internal only]