UsePerTenant and Authentication

Hi Ben -
Saaskit is amazing!  Following your examples, I've been able to make almost everything work, with the exception of multi-tenant authentication using the "UsePerTenant" extension with OIDC.
When I start the app, it lands on the home page fine (auth not required) but when I hit a controller method decorated with [Authorize], I get the following error:

System.InvalidOperationException: No authentication handler is configured to handle the scheme: Automatic

Here is the "configure" method from my startup:
 public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
 {
        loggerFactory.AddConsole(Configuration.GetSection("Logging"));
        loggerFactory.AddDebug();

        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
            app.UseBrowserLink();
        }
        else
        {
            app.UseExceptionHandler("/Home/Error");
        }

        app.UseStaticFiles();

        app.UseMultitenancy<AppTenant>();
        app.UsePerTenant<AppTenant>((ctx, builder) =>
        {
            app.UseCookieAuthentication(new CookieAuthenticationOptions
            {
                AuthenticationScheme = $"{ctx.Tenant.Id}.Cookies",
                AutomaticAuthenticate = true,
                AutomaticChallenge = true,
                SlidingExpiration = true,
                CookieName = $"{ctx.Tenant.Id}.AspNet.Cookies"
            });

            JwtSecurityTokenHandler.DefaultInboundClaimTypeMap.Clear();
            app.UseOpenIdConnectAuthentication(new OpenIdConnectOptions
            {
                AuthenticationScheme = "oidc",
                SignInScheme = $"{ctx.Tenant.Id}.Cookies",
                Authority = "http://localhost:5555",
                RequireHttpsMetadata = false,
                ClientId = ctx.Tenant.Hostname,
                ClientSecret = "secret",
                ResponseType = "code id_token",
                Scope = { "openid", "profile", "roles", "mtt_webapi", "offline_access" },
                GetClaimsFromUserInfoEndpoint = true,
                SaveTokens = true,
                TokenValidationParameters = new Microsoft.IdentityModel.Tokens.TokenValidationParameters
                {
                    NameClaimType = "name",
                    RoleClaimType = "role"
                }
            });
        });

        app.UseMvc(routes =>
        {
            routes.MapRoute(
                name: "default",
                template: "{controller=Home}/{action=Index}/{id?}");
        });
  }

Any advice you could give would be largely appreciated.  I'm at a loss.
Thanks!

It doesn't look like you've defined a scheme called Automatic. Your schemes
are oidc and [TenantId].Cookies.
Can you post your controller code?
On 20 January 2017 at 04:50, dguinn-oncore<EMAIL_ADDRESS>wrote:

Hi Ben -
Saaskit is amazing! Following your examples, I've been able to make almost
everything work, with the exception of multi-tenant authentication using
the "UsePerTenant" extension with OIDC.
When I start the app, it lands on the home page fine (auth not required)
but when I hit a controller method decorated with [Authorize], I get the
following error:
System.InvalidOperationException: No authentication handler is configured
to handle the scheme: Automatic
Here is the "configure" method from my startup:
public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
{
loggerFactory.AddConsole(Configuration.GetSection("Logging"));
loggerFactory.AddDebug();
    if (env.IsDevelopment())
    {
        app.UseDeveloperExceptionPage();
        app.UseBrowserLink();
    }
    else
    {
        app.UseExceptionHandler("/Home/Error");
    }

    app.UseStaticFiles();

    app.UseMultitenancy<AppTenant>();
    app.UsePerTenant<AppTenant>((ctx, builder) =>
    {
        app.UseCookieAuthentication(new CookieAuthenticationOptions
        {
            AuthenticationScheme = $"{ctx.Tenant.Id}.Cookies",
            AutomaticAuthenticate = true,
            AutomaticChallenge = true,
            SlidingExpiration = true,
            CookieName = $"{ctx.Tenant.Id}.AspNet.Cookies"
        });

        JwtSecurityTokenHandler.DefaultInboundClaimTypeMap.Clear();
        app.UseOpenIdConnectAuthentication(new OpenIdConnectOptions
        {
            AuthenticationScheme = "oidc",
            SignInScheme = $"{ctx.Tenant.Id}.Cookies",
            Authority = "http://localhost:5555",
            RequireHttpsMetadata = false,
            ClientId = ctx.Tenant.Hostname,
            ClientSecret = "secret",
            ResponseType = "code id_token",
            Scope = { "openid", "profile", "roles", "mtt_webapi", "offline_access" },
            GetClaimsFromUserInfoEndpoint = true,
            SaveTokens = true,
            TokenValidationParameters = new Microsoft.IdentityModel.Tokens.TokenValidationParameters
            {
                NameClaimType = "name",
                RoleClaimType = "role"
            }
        });
    });

    app.UseMvc(routes =>
    {
        routes.MapRoute(
            name: "default",
            template: "{controller=Home}/{action=Index}/{id?}");
    });

}
Any advice you could give would be largely appreciated. I'm at a loss.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/saaskit/saaskit/issues/63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyfqWbKfBlGrp66OmvE5kcO-ddlwDYoks5rUD0fgaJpZM4Lo7MZ
.

Hi Ben,
Thanks for the response.  Sure, here you go.  Nothing really to it, just the default HomeController with the "Contact" view set up to demonstrate switching tenant connectionstrings and the "About" view set up to show the user claims.
public class HomeController : Controller
{
    TestAppContext _dbContext;
    public HomeController(TestAppContext dbContext)
    {
        _dbContext = dbContext;
    }

    public IActionResult Index()
    {
        return View();
    }

    [Authorize]
    public IActionResult About()
    {
        ViewData["Message"] = "Your security claims.";
        return View(new ViewAboutModel
        {
             Claims = User.Claims.ToList()
        });
    }

    public async Task<IActionResult> Contact()
    {
        ViewData["Message"] = "Your favorite foods.";
        var foods = await _dbContext.Foods.ToListAsync();
        return View(new ViewContactModel
        {
            FavoriteFoods = foods
        });
    }

    public IActionResult Error()
    {
        return View();
    }
}

public class ViewContactModel
{
    public List<Food> FavoriteFoods { get; set; }
}

public class ViewAboutModel
{
    public List<Claim> Claims { get; set; }
}

Thanks again!

For anyone who runs into this same problem, I figured out it was because I used "app." in the UsePerTenant block instead of "builder.", so it was as if no authentication was being defined at all!


Server crash

https://github.com/MinerArcana/Floralchemy/blob/be2d92d656a4861bf93c1ae8d72ff4c46b27fa64/src/main/java/com/minerarcana/floralchemy/Floralchemy.java#L32
Imagine it's supposed to be "com.minerarcana.floralchemy.proxy.ServerProxy"

Yep I just fixed it in dev a few minutes ago. But don't have builds setup. Will have it on Curse after lunch.

Thank you!


Unit Converter

Describe the project
As a part of SSOC'23, I would like to add a unit conversion calculator in the list of projects. It is made by using HTML, CSS and Javascript.
Issue Type:

[ ] Bug Report
[ ] Feature Request
[ ] Documentation
[✅ ] New Project

Screenshots

@TusharKesarwani please assign this to me. Thank you

Please assign it to me. I have already done this project and idea about it.

@starkver23 The project already exists.


AVRO-3680: [Python] allow to disable name validation

Contribution Checklist
What is the purpose of the change
https://issues.apache.org/jira/browse/AVRO-3680
For interoperability the Python parsing API allows disabling the name validation. It is possible to create schema with names having e.g. dashes from Java SDK. The Python name validation is stricter and follows the Avro specification.
Verifying this change
This change added tests and can be verified as follows:

Moved existing tests for Name and Names to /lang/py/avro/test/test_name.py.
Added tests for invalid names when parsing with new validate_names flag set to false.

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? not documented

N.B. One of the build failures is due to https://issues.apache.org/jira/browse/AVRO-3681

If the python validation is stricter, is the bug not with Java SDK? (which should be more strict to prevent creating such names)
It seems the lang/js and a few others also restrict from using hyphens and the like. They too would need updating to allow hyphens, no?

@NotoriousPyro I do also feel that Java is too lenient and should follow the spec. The actual issue is that there are existing schemas in the wild with names that are not compliant. So the workaround to disable name validation is needed. For new data I think the validation should be enabled, also on Java SDK.

@NotoriousPyro There is a current discussion on the mailing list noted in the JIRA -- the issue is that some systems rely on the "tolerance" that has existed for non-compliant names in the Java SDK.
To guarantee interoperability today, the validate_names option should definitely be set to True (at time of writing).


Add another method for the overloaded findAll method into AI-Agent.xml

This PR is for fixing the issue defined in the chat below:

So in AI-Agent.xml we have some classes/methods defined.  But none of them are appearing in the logs.
https://portal.azure.com/#blade/AppInsightsExtension/DetailsV2Blade/ComponentId/{"Name"%3A"ccd-prod"%2C"SubscriptionId"%3A"8999dec3-0104-4a27-94ee-6588559729d1"%2C"ResourceGroup"%3A"ccd-shared-prod"}/DataModel/H4sIAAAAAAAAA42Ty27bMBBFf0XlKgXMmBIfIo2kiwJNkE0LpEYXqYOAJie1UFlSKMpFYPjfM3Rsw3CTojvxMefeuRytiWubGKyLPyD0VduQCcnJiMAKmnjj0wrkI2dMUKE4o3kOhmrvNS2lLwrOlIfCY0HbQbARAdsio1whTW75XDFhy8KUyqtCay6YFxwYFsRqCX20yw6vFyw3lHGaiynTE6YmXJ7nUt7hNdcuu7bZmVmTr3YJWOCcp11ok%252FD3Yd67UHUHbW2M8eA4ZXlybYuSGgFAldRaSoNmfOrwFvp2CA6uQzt0O2S%252FsAF25M2I9GCDW1xVdcRskvrTAOH5qsFvkjqw8zqZCYD7fexTCisIofIwxeZubfMLj2MYYEQet5CbCEss%252Frkmv59qrDxkkH3KvI2Q1mcnYcgJY%252BeMsbuPyK%252FtHOrkpHnN4QiApytbD2k3F2PGx4kzyvYIstmM%252Fpa9eFdW%252F5%252FsxT9k9Yns2WFGHtIzZpeX2Yxcf5lmYzRhx1WDCTW2HmP8GBfMyFvS3%252FaMrHllHBl4n3Vsw9UVjtPD9LmD7EOy8Dm0f3oIM0I29%252FjqzroFbCdJWMMcswUtGLNUgCqpFiqnUoHkwF0JWuz%252FlenpMGxeAOFbnyRbAwAA
the 103ms entry starting with OTHER
That is AI-Agent.xml in data-store.
It calls user-profile but we can't see any methods called within user profile, so we're not sure where we spent that 7.6s
Clearly data-store calls it, but we don't know what methods where used in it
But we have setup AI-Agent.xml for def-store

Added method signature for the overloaded repository method to make sure it is captured but he application insights agent. Based on the AI-Agent.xml documentation provided in this sample https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-agent
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Hmm let's do something else instead give me 5 minutes and I'll have an agent that will auto profile this for you

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #169   +/-   ##
=========================================
  Coverage     95.51%   95.51%
  Complexity      155      155
=========================================
  Files            28       28
  Lines           401      401
  Branches         27       27
=========================================
  Hits            383      383
  Misses           14       14
  Partials          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbcec3f...e81ac0e. Read the comment docs.


B-Tax visual output

This issue is to discuss visual output from the B-Tax calculator.  It relates to Issue #289, which discusses tabular output.
As an alternative (or addition) to the tabular output, we might present users with a graphical representation of the B-Tax calculations.
An example of this would be a cross-filter plot such as this (note: output plotted here is not current and does not display correct calculations):

The data that underlies this figure is the same that that proposed in the tabular output in Issue #289.  Therefore, the outputs from the calculator that are used in the UI remain largely the similar and the tabular and visual output are close substitutes for users.
My inclination is to first get a B-Tax web app working with tabular output and resolve any issues with that.  Once that's up, we can transition to output that presents the visualization by default with options to view the tabular data and output csv files.
cc @bfgard, @PeterDSteinberg, @MattHJensen

this is now handled via the "plots" repo, with the user-contributed code here:
https://github.com/open-source-economics/plots/tree/master/contrib/corp_metr


[HUDI-3043] Adding some test fixes to continuous mode multi writer tests

What is the purpose of the pull request
Making some test fixes to make it more consistent. Still I do see failures intermittently. but atleast this patch should reduce the frequency.
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Will be fixing the log statements once CI succeeds.


Support 'target_names' in Classification Metrics

If target_names is specified in the column_mapping it needs to be used in the following metrics:

ClassificationQualityByClass()
ClassificationClassSeparationPlot()
ClassificationProbDistribution()
ClassificationQualityByFeatureTable()

Screenshots below illustrate where target_names are supposed to appear on plots:

ClassificationQualityByClass()

ClassificationClassSeparationPlot()

ClassificationProbDistribution()

ClassificationQualityByFeatureTable()

Hello @emeli-dral , @elenasamuylova , I'm interested in working on this one.
Is there a minimal example to reproduce the screenshots above, available as a starting point? Also, I have a second question, was this bug always present?

Hi @aanghelidi, thanks for your interest in contributing!
You can reproduce the bug by taking this example notebook: https://github.com/evidentlyai/evidently/blob/main/examples/how_to_questions/how_to_use_column_mapping.ipynb
It shows how to pass target_names in column mapping for classification tasks (see 5.4 and below) and generate a Report. It does not include all metrics where the bug is present, but you can easily modify it by passing all the Metrics listed in this issue to the Report.
This bug is present since the initial implementation.

Hi @elenasamuylova, thank you for your detailed answer. As I progress through the PR, I may have other questions, but I'm now ready to work on it.


Governance article update

see if defi scams image is okay

@yurikoinaba still a problem with the images on defi scam article. Can you have a look?


Realm fetch gets stuck sometimes, and even hang the UI

One of the frustrated issue since beginning. No steps and not enough information or logs. Just sometime on device my app is getting hanged. Then I have to go in background and foreground to make it work. After that UI got completely hanged and started behaving weirdly. This situation is only occurring on UI where I have integrated realm and other tabbar views are working great.
Here is the code snippet:
On UITableViewCell tap I am calling this:
[self.interactor eventDisplayDataForEventID:eventID completionBlock:^(IVFormattedDisplayData *displayData) {
        IVEventDetailViewController *viewController = [[IVEventDetailViewController alloc] init];
        viewController.displayData = displayData;
        [self.navigationController pushViewController:viewController animated:YES];
    }];

- (void)eventDisplayDataForEventID:(NSString *)eventID completionBlock:(void(^)(IVFormattedDisplayData *displayData))block {
    NSAssert(eventID, @"eventID is nil");

    dispatch_async(self.realmQueryQueue, ^{
        RLMRealm *realm = [RLMRealm defaultRealm];
        IVEvent *event = [IVEvent objectInRealm:realm forPrimaryKey:eventID];

        IVFormattedDisplayData *displayData = [[IVFormattedDisplayData alloc] init];
        [displayData updateForEventData:event];

        dispatch_async(dispatch_get_main_queue(), ^{
            block(displayData);
        });
    });
}

Looks like realmdb sometime not performing operation and because of that pushNavigation is not getting called but as soon as I go in background and comes in foreground then push automatically get called with proper event object. But then hanging situation is all started and then UI never work properly.
Let me know if I can get some help on this. Sorry I don't have logs or complete details for you.

@tariq235 so sorry to hear you're running into issues, but I don't see anything wrong with the code snippet you shared. If you'd like to share a project that reproduces the issue with us, either here or privately at<EMAIL_ADDRESS>we'd be happy to take a look!

hey @segiddins  Bad news for me that nothing wrong with the code :D Because now I have to go back n forth with other code pieces.
Code is linked to our major product release so probably I'll create a sample and try to reproduce the issue and then will handover the sample privately.

@tariq235: Did you were able to figure out the issue in the product or reproduce this issue in a sample app?

hey @mrackwitz  @jpsim  @segiddins  Closing this issue because it wasn't related to Realm. It was really hard for me to troubleshoot the problem and at the end root cause was custom navigation.


Roll Packages from 295610b174b3 to a24cc2e69247 (2 revisions)

https://github.com/flutter/packages/compare/295610b174b3...a24cc2e69247
2023-03-28<EMAIL_ADDRESS>[pigeon] Fix C++ Flutter API class args (flutter/packages#3573)
2023-03-28<EMAIL_ADDRESS>Roll Flutter from 4a1002e2e255 to 12b36de8f7ac (33 revisions) (flutter/packages#3570)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Skip tests/dockerfiles per branch

We have a case where we don't want to run perf tests for the release-next branch but we want to have the targets and the dockerfiles available so when a new release branch is cut to use them (they are under ./openshift dir by convention and they affect release-next).
Tested in unit test. Also tested with setting:

   "release-v1.11":
     openShiftVersions:
       - version: 4.14
       - version: 4.11
     skipE2EMatches:
       - "perf-tests$"
     skipDockerFilesMatches:
       - "openshift/ci-operator/knative-perf-images.*"
     openShiftVersions:
       - version: 4.14
       - version: 4.11

The above setting generates the following git diff:
	modified:   ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.11__411.yaml
	modified:   ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.11__414.yaml
	deleted:    ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__410.yaml
	deleted:    ci-operator/config/openshift-knative/serving/openshift-knative-serving-release-v1.8__413.yaml
	modified:   ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.11-periodics.yaml
	modified:   ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.11-presubmits.yaml
	deleted:    ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-periodics.yaml
	deleted:    ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-postsubmits.yaml
	deleted:    ci-operator/jobs/openshift-knative/serving/openshift-knative-serving-release-v1.8-presubmits.yaml
	modified:   core-services/image-mirroring/knative/mapping_knative_knative-v1.11_serving_quay
	deleted:    core-services/image-mirroring/knative/mapping_knative_knative-v1.8_serving_quay

Actual diff contents here.

/assign @ReToCode


[BUG] advanced_dhcp_server role fails on OpenSUSE

The advanced_dhcp_server role is missing SUSE vars files.
Context
Example output:
TASK [advanced_dhcp_server : Package] ******************************************************************************************
Friday 15 April 2022  21:01:42 +0100 (0:00:00.164)       0:01:30.355 **********
fatal: [wolf0]: FAILED! =>
  msg: '''advanced_dhcp_server_packages_to_install'' is undefined'

Process
Run the advanced_dhcp_server role on a SLES based OS (e.g. OpenSUSE 15.3)
Expected result
The role executes without error.
Current result
See output above.
Possible Fix
Will create a pull request with a fix shortly.

Closing since PR was merged. Thanks for the devs 😊


Consider switching tests to Intern

Web site:
http://theintern.io/
Comparison with some other options:
https://github.com/theintern/intern#comparison
Blog post:
http://www.sitepen.com/blog/2013/05/01/intern-javascript-testing/

Closing until future conversation around CI's arise.


chore: migrate image registry to registry.k8s.io

Kubernetes has switched to registry.k8s.io as their default image registry.
This PR is updating instances of old registry k8s.gcr.io in our codebase.

💚 All backports created successfully

Status
Branch
Result

✅
1.x

Questions ?
Please refer to the Backport tool documentation


Update jenkins build

Coverage remained the same at 48.775% when pulling ab6baf9cf68c1f3dce8a51abcc4a230e3e66e668 on yiming187:jenkins_update into bf6ff487e0a9dc98477fb48e46eea6ef37947bc2 on ctripcorp:master.


Add prefix to tag to avoid error due to invalid CSS class names

I have noticed that if my read-only API key starts with digits or - or _, the class name is not valid and it breaks the rendering/removal of elements. See https://stackoverflow.com/questions/448981/which-characters-are-valid-in-css-class-names-selectors
This is just a simple fix to make sure we always get valid css class names in the tag variable

Oh, didn't think of that! Thanks for the fix!


Question abuout evaluation

Before evaluation FPR95 and AUROC, the predictions are filtered by "a threshold", why after this filter, the left predictions can be seen as "in-distribution object?", and what's meaning about this optimal_score_threshold. thank you~
    # Compute optimal micro F1 score threshold. We compute the f1 score for
    # every class and score threshold. We then compute the score threshold that
    # maximizes the F-1 score of every class. The final score threshold is the average
    # over all classes.
    precisions = results_api.eval['precision'].mean(0)[:, :, 0, 2]
    recalls = np.expand_dims(results_api.params.recThrs, 1)
    f1_scores = 2 * (precisions * recalls) / (precisions + recalls)
    optimal_f1_score = f1_scores.argmax(0)
    scores = results_api.eval['scores'].mean(0)[:, :, 0, 2]
    optimal_score_threshold = [scores[optimal_f1_score_i, i]
                               for i, optimal_f1_score_i in enumerate(optimal_f1_score)]
    optimal_score_threshold = np.array(optimal_score_threshold)
    optimal_score_threshold = optimal_score_threshold[optimal_score_threshold != 0]
    optimal_score_threshold = optimal_score_threshold.mean()

the predictions with confidence larger than optimal_score_threshold can not be guaranteed to be TP?
why use the mean of optimal-score-threshold rather than a list of threshold?

hi, @AceCoooool , i think the threshold is for filtering the predictions with low confidence. not on the energy score. we follow the paper https://openreview.net/pdf?id=YLewtnvKgR7.
why after this filter, the left predictions can be seen as "in-distribution object?",
--we did not regard the remaining objects after filtering as the in-distribution object. The filtering threshold is the same for both the id and ood data.

the predictions with confidence larger than optimal_score_threshold can not be guaranteed to be TP?
--this is definitely true, otherwise, the mAP will be very large (100%) for the object detection models, right?

--this is definitely true, otherwise, the mAP will be very large (100%) for the object detection models, right? because precision = tp/(tp+fp)

Thank you for you help !
Using the pretrained model in VOC, we can get the following results.
VOS: optimal_score_threshold=0.5831 => after filter: TP=11682, FP=4635, there are nearly 30% FP in id data
Vanilla: optimal_score_threshold=0.5686 => after filter: TP=11684, FP=4460, there are nearly 30% FP in id data

Does optimal_score_threshold can guarantee the similar number of predictions in both VOS and Vanilla ?
Direct set the predictions after filter as in-distribution object may not reasonable? (there are nearly 30% FP), I will read the paper https://openreview.net/pdf?id=YLewtnvKgR7 soon.

Thank you !

@AceCoooool ,
Does optimal_score_threshold can guarantee a similar number of predictions in both VOS and Vanilla ?
---as you showed, the number of objects should be similar for both models. You can always verify that whether using the same number of ID and OOD objects (by subsampling) will create different performance. I think VOS will also be better in such cases.
Direct set the predictions after filter as in-distribution object may not reasonable? (there are nearly 30% FP),
---well, I want to emphasize that we did not regard the remaining objects after filtering as the in-distribution object. The filtering threshold is the same for both the id and ood data. You can also verify the performance of vos by removing the threshold and using different thresholds. Under the same thresholding mechanism, the vos should be the better model.


Split README into multiple documents

See https://github.com/raxod502/straight.el/issues/95#issuecomment-315637510.

In progress on https://github.com/raxod502/straight.el/tree/feat/sphinx.

I decided to use Mkdocs instead of Sphinx. Progress continues, albeit slowly.

To be honest, I think the current format is fine.


I'm gonna have a crack at this

Sure thing, go right ahead!

Is this project going to target v3 or v4? I'm assuming it's v3 now, which according to Gitlab has just been deprecated (9.0 is released today). Do you plan on making a branch for v4 support and have some clean cutoff?

Having looked a bit more at v3 -> v4 details it'll be quite an undertaking to update all the things changed. Here's the document with the changes https://docs.gitlab.com/ce/api/v3_to_v4.html. Also I suppose the README.md could make it more explicit that this library targets v3?

Yeah, I guess it's about time to think about this one a little... I think I would like to work up to a final release that supports the V3 API, and then start with making the package support the V4 API.
I don't think having separated branches would work nicely in the longer run. Of course during development that's just fine, but once all is good I think master should be the latest and greatest.
And of course the V3 API will become obsolete in the longer run. But I'll make a V3 branch for hotfix releases in the case those will ever come...


[MM-57250] Calls: Provide feedback after user clicks Start call

Summary

Add a spinner to the Start call / Join call button.

Make the join call action async, make the leave current call alert async.
Do not close the bottom sheet until the join call / leave call alert returns.
Close the channel info / bottom sheet after the connection process completes (successful or unsuccessful).

Designs: https://www.figma.com/design/UUuEi45kKku8hq5JQA7tDC/MM-57250-Provide-feedback-after-user-clicks-start-call?node-id=1-7&m=dev

Ticket Link

https://mattermost.atlassian.net/browse/MM-57250

Checklist

[ ] Added or updated unit tests (required for all new features)
[x] Has UI changes
[x] Includes text changes and localization file updates
[x] Have tested against the 5 core themes to ensure consistency between them.

Device Information

Android: 13, Pixel 6
Android: 13, Galaxy Tab s7+
iOS: 16.5.1, iPhone 14

Release Note
Calls: Provide feedback after user clicks Start call

Any idea why the app builds are not getting triggered properly?

@cpoile @abhijit-singh I don't think we had this in the designs, but should we add a spinner to the join call banner and the call post when joining?

Is it possible to swap the icon more immediately with the spinner at the same time we update the text label to 'Starting'?
https://github.com/mattermost/mattermost-mobile/assets/2040554/1fa59140-b8e7-49cf-a338-946888bf6d76

should we add a spinner to the join call banner and the call post when joining?

I'd be in favour of that if that's possible, both on webapp and mobile.

@matthewbirtch I'm not sure why you're seeing such a delay, I can't reproduce that on my phones (iOS or Android) or on the iOS simulator. I had to record my screen to see a brief flicker, which I didn't notice just from regular use, so I'm using a different method for replacing the text (which was the problem -- the text was getting replaced on the active state of the regular button before the loading button could replace the regular button). Here's the comparison of before and after:

before
after

https://github.com/mattermost/mattermost-mobile/assets/1490756/34fa9623-48bc-459d-99bf-2c5a3e75668c
https://github.com/mattermost/mattermost-mobile/assets/1490756/a0b3da58-7e57-424a-a4cd-b1270df76821

https://github.com/mattermost/mattermost-mobile/assets/1490756/dee6fbf9-ef77-410d-b484-ff318ade6cac
https://github.com/mattermost/mattermost-mobile/assets/1490756/83385a7a-9fc3-411c-b5bd-5b1a6d407962

@matthewbirtch @abhijit-singh About the spinner on the join banner and the custom post -- I'm not sure what it would look like for the banner. The banner disappears right away when you click it. And I don't think adding additional complications to have it stay around while connecting would be worth it. But it might work on the post button (since the spinner would replace the microphone, and the button doesn't disappear). It's up to you I guess.

Here's what it could look like for both those places. Open to leaving the banner out if that's too complex and high effort.
Prototype link
Figma file
https://github.com/mattermost/mattermost-mobile/assets/14369607/63199969-6d7f-4bca-9c0c-434a4255e32a

@matthewbirtch @abhijit-singh Because of how we architected the banner system (which was done before we had an intermediate 'Joining...' state in the UX), we switch from the join call banner to the current call banner as soon as we start the join process. So adding a spinner to the join call banner won't be noticeable (I experimented with it, and you can see it flicker briefly, but it's barely noticeable so not worth it, imo, so I reverted). But I added a joining state, and clicking on the banner or the post message will set that state and the post's button will change for the duration of the join/negotiation process. Because the negotiation process length can vary, and the current call state is entered immediately, we'll see an overlap between the current call banner and the post button's 'Joining...' state. I'm not sure I like that, but it's what we've got for now. We could rearchitect how we transition to the current call state, but that will take more work, and I think we're entering the realm of diminishing returns for the user, in my opinion.
Here's what it looks like now:
https://github.com/mattermost/mattermost-mobile/assets/1490756/11472c6c-a753-4159-adb0-87cf4310b446

@abhijit-singh you good with the video above of the interaction?

Yep, looks good to me. Thank you @cpoile for the effort and the detailed explantation!

@DHaussermann Ready for testing, thank you!

@DHaussermann gentle ping on this, thank you

Thanks @DHaussermann!


Syeda's Papers

Added some papers mostly covering modeling techniques covering pretraining/continuous pretraining/finetuning/external knowledge integration.

Thank you! Would you mind merging main?

@snat1505027
Thanks for the contribution!
Any chance you can double-check if you are putting things in the correct subsection?
i.e., Why
Difference-Masking: Choosing What to Mask in Continued Pretraining belongs to the safety subsection?
Also why we would like to include this paper in the repo?
Feel free to add one subsection about pretraining in the subsection


Support for running tests without a browser (OSOE-365)

In certain cases, we need a running app but not a browser (or at least not a full one), like for testing web APIs. For such cases, we could start tests without a browser and then use something like RestEase for APIs or ScrapySharp as a barebone browser. The browser is launched when AtataFactory.CreateDriver() runs, this is the only thing necessary to switch off. However, a browser would still sometimes be needed for the initial setup (though we could add a feature to only open a browser when the setup is run but not for the test itself, or utilize Auto Setup).
Jira issue

ScrapySharp is built on HTML Agility Pack (see dependencies tab here), which is excellent. I have used HAP for years so you will hear no complaints about it from me. But OC already references AngleSharp which is its competitor, so aren't we supposed to use that?

However, a browser would still sometimes be needed for the initial setup

We could make CLI based setup an option?

Afair, we used ScrapySharp for scraping back in discoverize. Really liked it.

CLI-based setup can work too. We allow something like that with Setup Extensions since you only have to access a RESTful API there (i.e. no browser needed). Or, we could do some magic in ConfigureUITesting() and run the setup, much like Auto Setup, from IConfiguration data (and that way, we can supply setup parameters in the CLI, meaning we can also open them up in OrchardCoreUITestExecutorConfiguration).
This might actually be preferable for setting up the site in every case, unless we specifically want to test the setup screen.

With BrowserUITestContextExtensions added by Dávid here we now have the basic facilities for this, except for not starting a browser. And CreateAndSwitchToTenantAsync() can be used to set up a tenant without a browser.

With BrowserUITestContextExtensions added by Dávid here we now have the basic facilities for this, except for not starting a browser. And CreateAndSwitchToTenantAsync() can be used to set up a tenant without a browser.

The security scanning that was implemented in #322 would greatly benefit from this. It's already using its own internal crawler for the scan so the browser just takes up RAM and does nothing after setup. So now even a very stripped-down version of this feature would be beneficial.
As for the setup, consider adding a configuration to make it automatic/browserless even if the rest of the test uses a browser. I mean if the site uses auto-setup or stock unaltered OC setup, then we are UI testing the same stock features again and again. (the same situation as login was before the SignInDirectlyAsync extensions)
We could enable browser setup just in one test (e.g. BasicOrchardFeaturesShouldWork). The rest should be set up in programmatically to save time and power.

Sure.

Yevgeniy told that in AtataFactory we could use UseDriverInitializationStage(AtataContextDriverInitializationStage.None) to not start a WebDriver but still have an Atata context.

@wAsnk @sarahelsaig if you need this, it should be really easy now, with just a config bool and see my previous comment.

That sounds exciting! It will be sufficient for testing a REST API and for reducing overhead during security scanning.
Although for anything more complicated I'd still like a custom IWebDriver implementation that uses AngleSharp and HttpClient, so we can keep using all the Atata features and the accumulated extensions in UITT. (This could be a huge performance boost for testing features that don't require JS.)

Yep! If you'd utilize this in the project whose PR this was linked from above, then please take on it.

ScrapySharp, with no release since 2018 and no code changes since 2020 seems to be dead, unfortunately.
I didn't find an IWebDriver implementation that uses HtmlAgilityPack, but there's one for AngleSharp: https://github.com/TheJayMann/Selenium.AngleSharp.WebDriver It seems to be more of an abandoned experiment, though. It does provide a glimpse into the LOE to build such a driver.
JavasScript can supposedly be disabled in all the browsers we use by changing their configs, what's possible from consumer code today via BrowserOptionsConfigurator. This would only be a niche speed-up for certain tests, since the browser is still there, but may be useful. I was curious if this makes a differnece, and tried to disable JS like this in CreateDriverInnerAsync:
var prefs = new Dictionary<string, object>
{
    { "webkit.webprefs.javascript_enabled", false },
    { "profile.content_settings.exceptions.javascript.*.setting", 2 },
    { "profile.default_content_setting_values.javascript", 2 },
    { "profile.managed_default_content_settings.javascript", 2 },
};

chromeConfig.Options.AddUserProfilePreference("prefs", prefs);

// Add the disable-javascript argument
chromeConfig.Options.AddArgument("--disable-javascript");

if (configuration.Headless) chromeConfig.Options.AddArgument("headless=new");

But this didn't disable JS, window.alert("hello"); in the page still worked. (I only added headless from the linked SO answer but didn't use headless mode.)
But more to the point of running tests without a browser:
It turns out that what's even better than AtataContextDriverInitializationStage.None is AtataContextDriverInitializationStage.OnDemand, what only builds the driver if AtataContext.Driver is accessed. This sounds great, though we have a couple of places where the driver is accessed without any explicit consumer request (like to assert the browser logs), so for that we need a config. And even before those, strangely, Chrome is opening for me on ln 39, so even before the context is built...

I guess we'd need to use the UseDriver(Func<IWebDriver> driverFactory) overload, but we need async. So, we need a custom config.
BTW a browser-less setup can be simply utilizing Auto Setup too.

After some refactoring, we can have on-demand driver creation and thus browser launch. However, these are still using it even for security scans: https://github.com/Lombiq/UI-Testing-Toolbox/pull/396/commits/3da1e43e315ce5f97ddec94518de1eee59d733e9 I'll need to think about this.
BTW on my machine, not opening a browser brings about a two-second gain for a test, which is actually significant (and even more if it's done a lot more, on a slower machine).

Well, this was a bit more than a bool config but I think it's now done properly.

there's one for AngleSharp: https://github.com/TheJayMann/Selenium.AngleSharp.WebDriver It seems to be more of an abandoned experiment, though. It does provide a glimpse into the LOE to build such a driver.

This doesn't look so bad.

BTW on my machine, not opening a browser brings about a two-second gain for a test, which is actually significant (and even more if it's done a lot more, on a slower machine).

The difference is also impactful in terms of RAM use, which can become a bottleneck for parallel testing. In a previous gig where we tested remote servers (on not very powerful machines), this was a major problem. We always groaned when a site couldn't run without JS, because it meant interacting with it would need a real browser and it would max out the machine while running.

Yeah, memory is perhaps a bigger concern for the runtime of a workflow overall.
I've opened https://github.com/Lombiq/UI-Testing-Toolbox/issues/399 about this.


vShared plugin: improve volume state handling during Remove()

Fixes: https://github.com/vmware/docker-volume-vsphere/issues/1722
When Remove() function failed to update state of shared volume from
Ready to Deleting:

Volume is in Mounted state -> get clients and return error
Volume is already in Deleting state and timeout -> continue deleting
Volume is in other states -> return error

When the deletion of internal volume failed, depending on the state of
the internal volume, Remove() function should return error, or continue
deleting the metadata.

@shivanshu21
I decided to leave it in Deleting state for the following two reasons:

If we allow Deleting->Ready, there is one more state to wait for Ready->Mounting change then.
It will change our state machine of volumes to be more complex.

When a "docker volume rm" command is executed, even when the internal volume is still in use (SMB server not stopping yet), the SMB server may not in a working state anymore. It maybe in the progress of stopping, or it could hang. So internal volume still in use doesn't mean the shared volume can be set back to Ready state. So a better way is, if "docker volume rm" is already executed for a volume, this volume should be marked with Deleting state, until it's successfully deleted.


CVE-2020-7774 Security finding

A security find was found in the y18n library. Fixed in version 5.0.5. Can you update the library?
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-7774

Just checked this, it appears to be coming via cacache, which is required by webpack.


Demultiplexing using lima

Hi team I have:  Kinnex run bam, these are the segmented reads in bam file.
For demultiplexing, the barcoded cDNA amplification primers we used are:
SAMP102-001:

IsoSeqX_bc01_5p
CTACACGACGCTCTTCCGATCTACTACACGCAATGAAGTCGCAGGGTTGGG
IsoSeqX_3p
AAGCAGTGGTATCAACGCAGAGTAC

SAMP102-002:

IsoSeqX_bc02_5p
CTACACGACGCTCTTCCGATCTACTAGTAGCAATGAAGTCGCAGGGTTGGG
IsoSeqX_3p
AAGCAGTGGTATCAACGCAGAGTAC

For demultiplexing can I use:
lima --isoseq --dump-clips --peek-guess -j 24 FILE-segmentedreads.bam SAMP102-001.cDNA_amplification_primers.fasta SAMP102-001.demult.bam
lima --isoseq --dump-clips --peek-guess -j 24 FILE-segmentedreads.bam SAMP102-002.cDNA_amplification_primers.fasta SAMP102-002.demult.bam
OR I need to create one _primers.fasta where I can give info as:

SAMP102-001_5p
CTACACGACGCTCTTCCGATCTACTACACGCAATGAAGTCGCAGGGTTGGG
SAMP102-002_5p
CTACACGACGCTCTTCCGATCTACTAGTAGCAATGAAGTCGCAGGGTTGGG
primer_3p
AAGCAGTGGTATCAACGCAGAGTAC

and then run:
lima --isoseq --dump-clips --peek-guess -j 24 FILE-segmentedreads.bam primers.demux.fasta
Please suggest.

You combine them and run demux once

When I combine them and run I can see reads are distributed for both of them, but when I am doing it one at at time looks like almost all the reads are going in both the samples.
Thanks.


fix Orthographic Picking

There is an issue with the 3d picking with an orthographic 3d camera.
It was working in top view, which is why it was working in the case of a 2d camera.
This change seems to be fixing the picking for any 3d orthographic camera.
This is using : https://stackoverflow.com/questions/7692988/opengl-math-projecting-screen-space-to-world-space-coords
I'm not sure how this can be factorized with the Perspective screen2ray.

Thanks for the contribution 🙏 I've changed it so it's not calculating screen2ray two times which might affect performance. What do you think? And is it still working in your case?

I knew there was something to be done to avoid that, but didn't take the time to figure it out.
The changes look great and simpler.
It's still working in my case.
Thanks.

Perfect, thanks for testing 👍


User defined in base container image overriden for root

I have a dotnet 6 project published from a base image configured to create and use a non-root user (while waiting for dotnet 8).
It looks like the layer created by the sdk publish command also reset the USER back to root instead of whatever is defined in base image.
My understanding from current doc is that it should not do so (as my project targets dotnet 6).

Hi @ggirard07 - do you have a sample https://aka.ms/binlog that I could take a look at to see what's going on? Or a sample repro I could build myself?

@baronfel sample repo is available at https://github.com/ggirard07/dotnet_sdk-container-builds_496

Thanks, I'll take a look now!

Ok, good news! I think in 8.0.100 RC1 this is fixed. I'm running an RC1 nightly and when I run your instructions from that repo I get non-root user ids (note that the tag used is latest in RC1, not 1.0.0):
>dotnet publish .\ImageKeepRoot\ImageKeepRoot.csproj --configuration Release --os linux --arch x64 --property:PublishProfile=DefaultContainer -bl
MSBuild version 17.7.0+5785ed5c2 for .NET
  Determining projects to restore...
  Restored D:\Code\Scratch\dotnet_sdk-container-builds_496\ImageKeepRoot\ImageKeepRoot.csproj (in 3.57 sec).
C:\Program Files\dotnet\sdk\8.0.100-rc.1.23417.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInferenc
e.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-polic
y [D:\Code\Scratch\dotnet_sdk-container-builds_496\ImageKeepRoot\ImageKeepRoot.csproj]
  ImageKeepRoot -> D:\Code\Scratch\dotnet_sdk-container-builds_496\ImageKeepRoot\bin\Release\net6.0\linux-x64\ImageKeep
  Root.dll
  ImageKeepRoot -> D:\Code\Scratch\dotnet_sdk-container-builds_496\ImageKeepRoot\bin\Release\net6.0\linux-x64\publish\
  Building image 'imageshouldnotberoot-latest' with tags latest on top of base image localhost:5000/mybaseimage:latest
  Pushed image 'imageshouldnotberoot-latest:latest' to local registry
> docker run --rm -it --entrypoint /bin/bash imageshouldnotberoot-latest:latest
app@ab41fbb7d034:/app$ id
uid=1654(app) gid=1654(app) groups=1654(app)

This was fixed by https://github.com/dotnet/sdk/pull/32594.

Closing as we fixed this for RC2.


Move navigator update logic from core to React.

@philolo1 This makes the update function that is passed to _pushPage and _popPage simpler so I can simplify the core.

@argelius looks good, do we still you the update function, if not you probably should remove it? We might also consider having internal functions instead of const update = () =>  or calling them a little bit more specific.

I will merge this for now.


Where does Clipy store data?

Sorry if this is coming off as naive, but I am not terribly familiar with desktop application development.
My goal here is to be able to synchronize data between two computers, this would include clipboard history, snippets, and preferences.
The way I understand it the simplest way to accomplish this would be to sync the files or locations in which this data is stored using iCloud drive, NextCloud, Dropbox or whatever other file sync service. However, I have no idea where the data for the application is stored, or if this is even possible.
I have no problem "getting my hands dirty" and trying to implement this feature, but I am just looking for some direction on where to start. Any help would be greatly appreciated.
Thanks for an awesome App!!!

~/Library/Application\ Support/

~/Library/Application\ Support/

I'd also be happy to sync my settings & snippets on multiple devices. Wouldn't there have to be a .prefs file at that location for syncing? I have 31 0F85F31E-3FC6-4AD8-B9C4-541A0AFXXXXX.data-type files at that location probably resembling my 30 clipy clipboard entries.

Hey! find / -name '*clipy*' -print 2>/dev/null should give you all possible locations. I used these to reset Clipy's settings by removing some of these folders.

~/Library/Application\ Support/
Hi. I am in the middle of a ssd failure drama. Is there a way I can recover my snippets and clipboard if I have only the xxxxx.data files stored in /Users/K/Library/Application Support/Clipy/ ?  I was not able to save nothing else cause didn t saw the other folders when recovering...  I tried to copy the xxx.data files on place in new installation and nothing is showing... Thank you all for this amazing app. Simply the best.

It's $USER/Library/Application Support/com.clipy-app.Clipy - love the app - thanks devs!


FALCON-2101 Disable IT tests that depend on instance state

Unblocking release by disabling indeterministic tests. Create FALCON-2102 for a more thorough investigation and fix.

+1.

+1


Introspection adds @relation attribute when it's not needed (alpha)

I have this Postgres schema:
CREATE TABLE "public"."User" (
  id SERIAL PRIMARY KEY NOT NULL,
  name VARCHAR(255),
  email VARCHAR(255) UNIQUE NOT NULL
);

CREATE TABLE "public"."Post" (
  id SERIAL PRIMARY KEY NOT NULL,
  title VARCHAR(255) NOT NULL,
  "createdAt" TIMESTAMP NOT NULL DEFAULT now(),
  content TEXT,
  published BOOLEAN DEFAULT false,
  author INTEGER NOT NULL,
  FOREIGN KEY (author) REFERENCES "public"."User"(id)
);

CREATE TABLE "public"."Profile" (
  id SERIAL PRIMARY KEY NOT NULL,
  bio TEXT,
  "user" INTEGER NOT NULL,
  FOREIGN KEY ("user") REFERENCES "public"."User"(id)
);

Then from introspection (using prisma2@alpha) I get this Prisma schema:
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgresql"
  url      = env("DATABASE_URL")
}

model Post {
  content   String?
  createdAt DateTime @default(now())
  id        Int      @default(autoincrement()) @id
  published Boolean? @default(false)
  title     String
  author    User     @relation(references: [id])
}

model Profile {
  bio  String?
  id   Int     @default(autoincrement()) @id
  user User    @relation(references: [id])
}

model User {
  email   String    @unique
  id      Int       @default(autoincrement()) @id
  name    String?
  post    Post[]
  profile Profile[]
}

I noticed that the relation fields author and user both have a @relation(references: [id]) attribute. Is that intentional? Is This shouldn't be required here, right?

I won't call it a bug as it doesn't break functionality but we can remove that field from the result.

The presence of this argument is intentional. The presence of that argument makes it very obvious where foreign key is stored in the underlying database. The goal of this change was it to make it easier to translate a Prisma schema into a db schema in your head.
You can find the original discussion here: https://github.com/prisma/specs/issues/348


Hostname as argument instead of environment variable

Is there a specific reason for server.py to get HOSTNAME from env instead of an argument like port, env_path, logging_level, etc. ?
When running visdom in a docker container you currently have to set your HOSTNAME variable, but I had to go through the source code to figure that out. Instead I'd like to pass it as an argument python -m visdom.server -hostname <IP_ADDRESS>

Right now it's only like that because of our initial use case (where hostnames were already configured in the environment) and there weren't any requests to provide other support. I'd be happy to support both however - if you want to open a PR that uses the hostname provided on the command line as an override to whatever comes out after the env check I'll pull it in.


move old content from PCF docs

As discussed with @jim80net - moved outdated content from PCF docs to this repo, for PCF docs Tracker story https://www.pivotaltracker.com/story/show/116730999

this info is a bit out of date, but any guide would be better than the total lack of guide we have now. merge'd


Desktop: Touch slop support for touch devices on desktop platforms

Android uses specific distance to differentiate between touch drag and touch click (ViewConfiguration.touchSlop).
On desktop we significally decrease the touch slop in https://android-review.googlesource.com/c/platform/frameworks/support/+/1698450.
Unwanted drags on desktop are usually prevented by the friction between mouse and surface.
The open question - should we use a different touch slop when we use a touch screen on desktop?
(for example on Microsoft Surface)
We should investigate on the real touch devices:

to know if touch slop is implemented on the driver level, or not
if not - should we use a bigger slop in Compose
to know how macOs/Windows/Linux handle this

See also:
https://github.com/JetBrains/compose-jb/issues/343
https://github.com/JetBrains/compose-jb/issues/325

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


updated metadata

Docs Build status updates of commit 3cd7c0f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/legacy/data-appconfiguration-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/digitaltwins-core-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/datalake.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/dns.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/data-appconfiguration-readme.md

Line 24, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration' will be broken in isolated environments. Replace with a relative link.
Line 31, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 31, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 33, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-dotnet-core-app#create-an-app-configuration-store' will be broken in isolated environments. Replace with a relative link.
Line 49, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 73, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 110, Column 6: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 139, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/rest-api-authorization-azure-ad#roles' will be broken in isolated environments. Replace with a relative link.
Line 410, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-java-spring-app' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/legacy/digitaltwins-core-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/azure/' will be broken in isolated environments. Replace with a relative link.
Line 47, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 49, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure/ext/azure-iot/dt?view=azure-cli-latest' will be broken in isolated environments. Replace with a relative link.
Line 49, Column 18: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/cli/azure/ext/azure-iot/dt?view=azure-cli-latest. Otherwise, remove the view parameter.
Line 53, Column 101: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/api/com.azure.core.credential.tokencredential?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 53, Column 101: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/api/com.azure.core.credential.tokencredential?view=azure-java-stable. Otherwise, remove the view parameter.
Line 60, Column 58: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/digital-twins/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@sima-zhu
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Reverted all content changes and left metadata changes in place until further notice.

Docs Build status updates of commit 786ecb7:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/legacy/data-appconfiguration-readme.md
:warning:Warning
View (azure-java-legacy)
Details

docs-ref-services/legacy/digitaltwins-core-readme.md
:bulb:Suggestion
View (azure-java-legacy)
Details

docs-ref-services/legacy/datalake.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/dns.md
:white_check_mark:Succeeded
View (azure-java-legacy)

docs-ref-services/legacy/data-appconfiguration-readme.md

Line 21, Column 1: [Warning: table-syntax-invalid - See documentation] Table syntax is invalid. Ensure your table includes a header and is surrounded by empty lines.
Line 22, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration' will be broken in isolated environments. Replace with a relative link.
Line 28, Column 5: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 28, Column 5: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/azure/jdk/?view=azure-java-stable. Otherwise, remove the view parameter.
Line 30, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-dotnet-core-app#create-an-app-configuration-store' will be broken in isolated environments. Replace with a relative link.
Line 46, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 70, Column 9: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 107, Column 6: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 136, Column 30: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/rest-api-authorization-azure-ad#roles' will be broken in isolated environments. Replace with a relative link.
Line 407, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-app-configuration/quickstart-java-spring-app' will be broken in isolated environments. Replace with a relative link.

docs-ref-services/legacy/digitaltwins-core-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.
Line 46, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/rest/api/azure/' will be broken in isolated environments. Replace with a relative link.
Line 47, Column 13: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure' will be broken in isolated environments. Replace with a relative link.
Line 49, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/cli/azure/ext/azure-iot/dt?view=azure-cli-latest' will be broken in isolated environments. Replace with a relative link.
Line 49, Column 18: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/cli/azure/ext/azure-iot/dt?view=azure-cli-latest. Otherwise, remove the view parameter.
Line 53, Column 101: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/java/api/com.azure.core.credential.tokencredential?view=azure-java-stable' will be broken in isolated environments. Replace with a relative link.
Line 53, Column 101: [Suggestion: preserve-view-not-set - See documentation] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: https://docs.microsoft.com/java/api/com.azure.core.credential.tokencredential?view=azure-java-stable. Otherwise, remove the view parameter.
Line 60, Column 58: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/digital-twins/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@sima-zhu
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!


Autocut when on-merge gradle check fails.

Is your feature request related to a problem? Please describe.
Many of the on-merge gradle checks shown here are failing.  A green check is incorrectly appearing now even on runs where gradle check fails.
I suggest we autocut an issue on these failures so they can be looked at to determine if they should be treated as a flaky failure or if a larger issue was introduced.

@mch2 interesting error observer with the GA [1]:
Run dblock/create-a-github-issue@v3
⬤  debug     Reading from file .github/ISSUE_TEMPLATE/failed_check.md
ℹ  info      Front matter for .github/ISSUE_TEMPLATE/failed_check.md is {
  title: '[AUTOCUT] Gradle Check Failure on push to {{ env.branch_name }}',
  labels: '>test-failure, bug'
}
⬤  debug     Templates compiled {
  body: 'Gradle check has failed on push of your commit 83dccad312faa7d9350ffa6672e51d02d36ad06f.\n' +
    'Please examine the workflow log [https://build.ci.opensearch.org/job/gradle-check/10777/.\n](https://build.ci.opensearch.org/job/gradle-check/10777/n)' +
    'Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?\n',
  title: '[AUTOCUT] Gradle Check Failure on push to ',
  labels: [ '>test-failure', 'bug' ]
}
ℹ  info      Creating new issue [AUTOCUT] Gradle Check Failure on push to
✖  error     An error occurred while creating the issue. This might be caused by a malformed issue title, or a typo in the labels or assignees. Check .github/ISSUE_TEMPLATE/failed_check.md!
✖  error     HttpError: Validation Failed: {"value":"SonalMahambrey1","resource":"Issue","field":"assignees","code":"invalid"}
    at /home/runner/work/_actions/dblock/create-a-github-issue/v3/dist/index.js:6038:21
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async createAnIssue (/home/runner/work/_actions/dblock/create-a-github-issue/v3/dist/index.js:37971:23)
Error: An error occurred while creating the issue. This might be caused by a malformed issue title, or a typo in the labels or assignees. Check .github/ISSUE_TEMPLATE/failed_check.md!

Validation Failed: {"value":"SonalMahambrey1","resource":"Issue","field":"assignees","code":"invalid"}

[1] https://github.com/opensearch-project/OpenSearch/actions/runs/4114574598/jobs/7102120698


transcoding: Teach transcoding filter to be aware of per vhost / per route settings

Commit Message:
Adding support for per-route grpc json transcoding filter.
Additional Description:
Risk Level: low (adds a new usage for the transcoding filter, doesn't change the current behavior / use cases)
Testing:
Docs Changes:
Release Notes:
Fixes #11038

@htuch Can you advice please, what's a recommended way to make this filter opt-in? For instance, we want to disable it by default but then enable (with different configs) for subset of virtual hosts.
It is acceptable to lift requirement for minimum one field in list of services? Or what are other options?

We could remove the two validation rules for descriptor and services to allow empty config at filter config,  allow per_route_config to specify a valid one.  An empty "descriptor' and services config will be treated as "disabled"  since the method will not be matched in the path_matcher.

Yeah, per-route filter config override seems a good way to provide per-vhost opt-in.

We could remove the two validation rules for descriptor and services to allow empty config at filter config, allow per_route_config to specify a valid one. An empty "descriptor' and services config will be treated as "disabled" since the method will not be matched in the path_matcher.

so I left required validation for descriptor, thinking that it's just going to be more explicit in the configuration... do we prefer to simply not have it specified at all?

Hey! Can we reopen this PR and pull my recent changes (it's a merge with current master + update on the test coverage)? Thanks!

@lizan do you mind taking another look?

@htuch @lizan @qiwzhang Can you check the pull request, please? It's in a limbo mode for a long time now.

What is the status of this PR? Is it ready to review? Can someone merge main into it?
/wait

@mattklein123 i adjusted the release notes, do you think it's ok?

@mattklein123 i adjusted the release notes, do you think it's ok?


[SPARK-35320][SQL] Fix from_json maps parser: Only StringType is supported for keys.

What changes were proposed in this pull request?

Currently, when a map is parsed in a from_json function, only StringType key is supported. If you try to parse other type, it results on a cast exception.
For example:
Seq((s"""{"2021-05-05T20:05:08": "sampleValue"}"""))
  .toDF("value")
  .withColumn("value1", from_json(col("value"),  MapType(TimestampType, StringType)))
  .show

This PR proposes to support for the key, the same types thar are supported for the value in the map.
Only BinaryType is excluded because it depends on the encoding and it needs a more complex solution
Why are the changes needed?

We allow to cast different types for the key of the map, so it's interesting to suppot them
Does this PR introduce any user-facing change?

Fix the explained case
How was this patch tested?

Unit testing and manual testing

Can one of the admins verify this patch?

cc @HyukjinKwon

ok to test

Test build #138839 has started for PR 32599 at commit 10bd965.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43361/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43361/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43361/

Test build #138839 has finished for PR 32599 at commit 10bd965.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class DeferFetchRequestResult(fetchRequest: FetchRequest) extends FetchResult
class CachedAccessor(Generic[T]):
case class ReferenceEqualPlanWrapper(plan: LogicalPlan)
 class ExpressionContainmentOrdering extends Ordering[Expression]
    new RuntimeException(s\"class $clsName has unexpected serializer: $objSerializer\")

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138839/

Thanks for the advice, I have created a new test for this part. I have skipped IntervalType because it’s not allowed to write this type by the datasource and UDTs because it’s not exposed to final users I think.
Also, I found a similar problem that I’m solving in this PR in JacksonGenerator. I’m planning to open a new PR to keep this PR simple. What do you think? To work around this problem in the test, all keys are write as StringType

Test build #138852 has started for PR 32599 at commit 1565185.

Test build #138852 has finished for PR 32599 at commit 1565185.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138852/

Let's exclude UDT support in this PR for now then.

I am okay with this change but WDYT @cloud-fan @MaxGekk @viirya? Just to clarify, it works iff users specify the explicit
map type. Schema inference won't infer such schema.

BTW, as I commented on the JIRA, I think from_json documents for MapType, StringType is the key type. So it looks not a bug. Can you update the title? E.g. Support other data types as key types when parsing map in from_json?

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43375/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43375/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43375/

Test build #138884 has started for PR 32599 at commit 08df360.

Test build #138884 has finished for PR 32599 at commit 08df360.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138884/

Just to clarify, it works iff users specify the explicit map type. Schema inference won't infer such schema.

Yes, Schema inference won't infer such schema
We have clear then that it is not a Bug, as @cloud-fan and @viirya say, the keys of a Json are always of type String, so this would be an improvement.
I think that since we allow write operations of type
df.withColumn(colName, from_json(col(colName), MapType(DoubleType, StringType))).write.json(jsonDir)
it is more consistent to support the reverse operation
spark.read.schema(StructType(Seq(StructField(DoubleType, dataType)))).json(jsonDir)
Anyway, if we decide to not support this, I think we need to improve the error message

Test build #138886 has started for PR 32599 at commit b8a2bfe.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43406/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43406/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43408/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43408/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43406/

Test build #138886 has finished for PR 32599 at commit b8a2bfe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138886/

Closing this PR to improve the error message in https://github.com/apache/spark/pull/33525


PR into node

Are you going to send patch into node/io.js?

@nkt eventemitter3 isn't going to replace EventEmitter within node/io.js.eventemitter3 is meant to be optimized for browsers.

Ah. I understood. thanks.

@Dashed @nkt The performance fixes aren't browser only, as we actually benchmark against the Node.js implementation. And getting the performance patches up stream has proven to be really painful for node as they don't like it when people touch the EventEmitter. They are also fundamentally against API changes to major performance benefits such as our EE.on(event, fn, context) are not accepted even if they proof a major performance win.


bug fixes and cbor addition

Hello,
There were a couple of bug fixes that are present in this diff.
1)On load of the copper plugin there was a stack trace.
ERROR: document.getElementById(...) is null
Stacktrace:
Copper.updateBehavior@chrome://copper/content/Helpers.js:73:2
Copper.loadBehavior@chrome://copper/content/Helpers.js:60:2
Copper.main@chrome://copper/content/Main.js:118:3
onload@coap://vs0.inf.ethz.ch/:1:1
This was because prefs.js had the "cancel" as a value for observe-cancellation
pref("extensions.copper.behavior.observe-cancellation", "cancel");
which didnt exist in copper.xul..Possible options are lazy,get,rst . So changed the above line to pick up lazy so that it wont return NULL on load.
2)The second fix was where Accept and Content-Format(on the right tab -debug control) showed a lot of unknown/unknown . This is because DebugOptions.js was expecting "unknown" for unknown options (to ignore)
if ( (name = Copper.getContentFormatName(i))!='unknown') {
but CoapRFC7252 was sending out 'unknown/unknown'
default: return 'unknown/unknown';
hence there was no string matching. SO changed the DebugOptions.js file to match 'unknown/unknown' instead of just 'unknown'
3)Added application/cbor support as i required it for copper client to send out and accept cbor data.

Looks good, thanks a lot for the help!


Record the current directory into COMMAND-history (not directory history)

https://twitter.com/bori_so1/status/700513652315525121

History data had better to have

Commandline
Timestamp
Current-directory

We found a user who refer %APPDATA%\nyagos\nyagos.history. ( https://github.com/zetamatta/nyagos/issues/117 )
His script is too nice to change history-file's format...


Open Telemetry integration

This for the open telemetry integration
It's a WIP, missing:

[x] W3C tracer
[x] ~Add Baggage (actually removed, probably not necessary)~
[x] Integration with service
[x] Integration with db
[x] Integration with client [OpenAPI]
[x] Integration with client [GraphQL]
[x] Integration with composer
[x] Integration with runtime
[ ] Docs

code LGTM but there is a conflict and docs are missing.


error

hello!
Uncaught TypeError: Cannot read property 'appendChild' of undefined

this.instance.rootElement[0].appendChild(this.TEXTAREA_PARENT);

error

What version on handsontable and Select2 are you using with this?

Handsontable 0.12.2

Same here.
Handsontable 0.12.4
Select2 3.5.2

Any fix for this? I have the same issue.

Check the referenced commit above for a fix

OK, thanks, made that change. Now I get "undefined is not a function".

Yeah, for full support for Handsontable 0.12, see this PR: https://github.com/trebuchetty/Handsontable-select2-editor/pull/4

Is anyone successfully using this with Handsontable 0.12? I got the updated file from #4 above, but I'm still getting the same error at line 145. "Uncaught TypeError: undefined is not a function".
Thanks

We use we it.
Using the following in bower:
"Handsontable-select2-editor": "https://github.com/motin/Handsontable-select2-editor.git#4ec18ace630816f00e7275ea04a2019f23ccf432",
"select2": "~3.5.2"

Including select2.js and select2.css from select2 first and then select2-editor.js from this repo.

Thanks for your help. That has fixed all my issues.

I haven't had the chance to test these changes as I'm not able to update my project's version of Handsontable (no time or buy in from stakeholders), so I've been holding back on integrating the merges to fix these issues. I will get to this soon though.

I picked up the patch and tried but it is not working. When selecting an entry, the id is getting displayed and dropdown is not aligned properly. Can you let me know if i am missing anything?
Here is the sample: http://jsfiddle.net/mpusarla/uh9jxo8v/5/

I'm getting exactly the same result. I added a new issue about it, but have received no help with it. I ended up not using this in my project.

We are able to get the select2-editor working with Handsontable 0.12.4. To fix the alignment issue, had to comment the following:
this.$textarea.offset($(this.TD).offset());
Added custom renderer for displaying the text instead of the id. Here is the jsfiddle: http://jsfiddle.net/mpusarla/4mpyhbjw/35/

I've merged in the original change to fix this issue and merged in the changes by @motin that seems to have fixed the rest of the issues. I also created a jsFiddle (link on readme) that shows how to use this editor. Showing something in the grid (ie. after selection) other than the id selected is out of the scope of this editor (requires a custom renderer). Closing.


Upgraded to the latest version now I get no results

Describe the bug
Upgraded to the latest version now I get no results.  No code changes were made.
To Reproduce
var resolver = ResolverBuilder.Begin()
.AddDnsServer(host.Name)
.SetTimeout(1000)
.EnableCache()
.SetRetries(3)
.UseRecursion()
.Build();
    var response = resolver.Query(model.TestHost, (Ubiety.Dns.Core.Common.QuestionType)model.QuestionType, (Ubiety.Dns.Core.Common.QuestionClass)model.QuestionClass);
    if (response == null)
        throw new Exception(Resources.TEMPLATE_DNS_NO_RESPONSE);

Expected behavior
I should be getting back an answer.
Desktop (please complete the following information):

OS: Windows 10
Nuget Version 4.2.2

Rolling back to version 4.2.0 resolves the issue.

Same/similar issue here.
With 4.2.2, I do get a FormErr only:
[Ubiety.Dns.Core.Resolver::Debug] Received CNAME query for github.com
[Ubiety.Dns.Core.Resolver::Debug] Searching cache for question...
[Ubiety.Dns.Core.Resolver::Debug] Sending request to server...
[Ubiety.Dns.Core.Resolver::Debug] Starting TCP request...
[Ubiety.Dns.Core.Resolver::Debug] Attempt 1 of 3...
[Ubiety.Dns.Core.Resolver::Debug] Connecting to <IP_ADDRESS>...
[Ubiety.Dns.Core.Resolver::Debug] Sending request to server...
[Ubiety.Dns.Core.Resolver::Debug] Building response...
[Ubiety.Dns.Core.Response::Debug] Received information from server
[Ubiety.Dns.Core.Resolver::Debug] Error from server - FormErr
Same everything, but with 4.2.1:
[Ubiety.Dns.Core.Resolver::Debug] Received CNAME query for github.com
[Ubiety.Dns.Core.Resolver::Debug] Searching cache for question...
[Ubiety.Dns.Core.Resolver::Debug] Sending request to server...
[Ubiety.Dns.Core.Resolver::Debug] Starting TCP request...
[Ubiety.Dns.Core.Resolver::Debug] Attempt 1 of 3...
[Ubiety.Dns.Core.Resolver::Debug] Connecting to <IP_ADDRESS>...
[Ubiety.Dns.Core.Resolver::Debug] Sending request to server...
[Ubiety.Dns.Core.Resolver::Debug] Building response...
[Ubiety.Dns.Core.Response::Debug] Received information from server
[Ubiety.Dns.Core.Response::Debug] Adding questions...

No updates.  It seems this repository is dead :(.  I guess we all need to branch our own from 4.2.0 and maintain the library in our own repositories.  Bummer.  @realslacker do you have a reproduceable scenario with TXT records?

I think this PR should fix it, @coder2000 could you look into that?
https://github.com/ubiety/Ubiety.Dns.Core/pull/47

Created a new PR for this.
https://github.com/ubiety/Ubiety.Dns.Core/pull/51

Created a new PR for this.
#51

So sad it looks like this repo is stale.

Merged


Add dotnet lib with client extensions

Reading response
Sending any method with Json

Microsoft has implemented PatchAsJsonAsync so "Sending any method with Json" is not necessary any more


The Distance Method HGT detection algorithm implemented in python

Implementation of the Distance Method for HGT detection based on algorithm described in:
Wei. X et al., "A Distance-Based Method for Detecting HGT in Whole
Genomes", International Symposium on Bioinformatics Research and
Applications (ISBRA), 2008, pages 26-37
The workflow follows the algorithm:
1. For each gene in target genome,
    i.    BLAST sequence against all other genes in the reference genomes;
    ii.   Go to step 3 if gene has more than threshold number of homologs
          (min-num-homologs), otherwise go to next gene in target genome;
    iii.  Compute multiple sequence alignment on homolog genes using
          CLUSTAL;
    iv.   Compute pairwise distance matrix using PHYLIP's protdist
          function and Z-score normalize the set of pairwise distances
          for each gene family and species;
    v.    Add distance matrix for all pairwise distances into global
          distance matrix storing results for all genes

2. Cluster gene families by species,
    vi.   Compute all species sets (sets of genes whose orthologs are
          detectable in exactly the same subset of the considered
          species);
    vii.  Cluster genes to each core species set cluster using the Hamming
          distance clustering algorithm;
    viii. Run outlier detection algorithm on each cluster (paragraph 2
          of section 'Detecting Outlier Genes' in original paper)

In general, I think some of the blocks can be improved to avoid so many loops, which should make the code run faster. Suggest making those changes on the main code without changing the tests so you make sure the results are not changing.

@antgonza thanks for the review! I've made most of the modifications and will leave some of the suggested optimizations for later (see issue #3).

Two more minor comments and I think this is ready to go, except for https://github.com/biocore/WGS-HGT/issues/3


(Bugfixes) 1.18.0 Fixes

Description
We are seeing a few failures on prod after 1.18.0 that seem to stem from unexpected prod data and needed nil checks.

For some reason, the fetch for phone number when getting an opt-in/opt-out message appears to be failing/have unexpected data on prod. This requires further investigation, but for now, it needs to be caught to avoid causing an error in ConsumeAssessments.

Nil check needed on export when extracting assessment details. Looks like something related to a nil condition (still investigating).

Testing
Please test these changes locally and on demo and verify that exporting assessments still works as expected, and that the consume assessments job runs and can handle an error in the Twilio Sender helper method as expected.

Leaving as draft while we test on demo, but please do start reviewing.


Bonnie 335

Test baseline functionality for simple measure (proportion with a single population set).
Created a test for measure history related measures where the tests themselves are defined as methods and then those methods are "applied" to the measure.

The CI tests for this pull request should pass once https://github.com/projecttacoma/bonnie/pull/671 is merged into master and this branch is rebased onto master. OR you could rebase onto  BONNIE-440-Remove-Console-Errors

#671 has been merged into master.
@mulcahyk can you do the rebase so these pass?

Please see PR #683 for the final version.

This pull request was maintained for comments in support of https://github.com/projecttacoma/bonnie/pull/683. https://github.com/projecttacoma/bonnie/pull/683 has been accepted and will be merged so this pull request is no longer necessary.


5.01 AST #4 - Overheal and CI

Adapted from whm overheal and benison

:+1:

@suShirow conflicts :eyes:


HIVE-24324: Remove deprecated API usage from Avro

What changes were proposed in this pull request?

This backports #1621 to branch-2.3.
This mainly replace JsonProperties.getJsonProp with JsonProperties.getObjectProp.
Note that there's one place in SchemaToTypeInfo where we explicitly call getIntValue to forbid string as precision/scale values (see HIVE-7174). To retain the old behavior, we check if the returned object is integer type, and if not, return a default 0 following JsonNode implementation.
Why are the changes needed?

JsonProperties#getJsonProp has been marked as deprecated in Avro 1.8 and removed since Avro 1.9. This replaces the API usage for this with getObjectProp which doesn't leak Json node from jackson. This will help downstream apps to depend on Hive while using higher version of Avro, and also help Hive to upgrade Avro version itself.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests.

cc @szehon-ho @aihuaxu could you review this? thanks.

Thanks @aihuaxu ! Test failures unrelated. Merging to branch-2.3 now.


Noworkergrouplink

I think this branch works for Luke because he runs NIC things in the main process and the worker, therefore the main process has already created the group folder when it forks.  I think for us, that is not the case and so somehow the "alias" detects that "group" is already there but it isn't.  This change results in the group dir being created in the worker instead.  That is fine for our use case because we don't actually need to share DMA resources between the main process and the worker, as we're only going to have one worker for the moment and it's the only one that will be doing DMA.  Therefore I think a change like this looks to me to be as correct as anything.

I've manually confirmed with snabb top that the worker process is breathing correctly.
Command line tested against:
./snabb lwaftr run -D 2000  --conf ~/snabb-lwaftr-v3.1.0/src/program/lwaftr/tests/data/icmp_on_fail.conf --reconfigurable --on-a-stick 82:00.1


Can't rescue 415 Unsupported Media type error

Hi.
I have an issue with the grape that I cannot rescue 415 Unsupported Media type error. It does not appear in any rescue_from handlers, the reason for this is that this error is handled by grape with throw/ catch statements and logic for those different from raise/rescue.
I made a patch which catch thrown errors and than raises those thought grape base exception, like this:
module GrapeErrorPatch
  def call!(env)
    @env = env

    begin
      thrown_error = catch(:error) { return @app.call(@env) }

      raise Grape::Exceptions::Base.new(status: thrown_error[:status],
                                        message: thrown_error[:message])
    rescue Exception => error # rubocop:disable Lint/RescueException
      handler = select_error_handler(error)

      run_rescue_handler(handler, error)
    end
  end

  def select_error_handler(error)
    rescue_handler_for_base_only_class(error.class) ||
      rescue_handler_for_class_or_its_ancestor(error.class) ||
      rescue_handler_for_grape_exception(error.class) ||
      rescue_handler_for_any_class(error.class) ||
      raise
  end
end

::Grape::Middleware::Error.class_eval { prepend(GrapeErrorPatch) }

Could you please advice a better way to handle that? What is the grape way to handle thrown errors?

Care to try and write a spec that demonstrates what you're trying to do? I think everything should be rescuable but maybe at different levels.


Dependency management

Package management is a tough thing to tackle.. since practically everything about C is against it (no module system, only absolute #include), leading to the current situation of having hundreds of build tools..
I have a few ideas on how to go about this, but I don't think it's worth going for until I legitimately have to create a C-project to experiment with the best way to do this.
I think the simplest method would be having separate types of "packages", most simple type being essentially just cloning a project's source code to /target/, symlinking to vendor, then user refers to the package from there. Dealing with other cpkg projects should also just be symlinking. Shared library dependencies should also be a thing, shouldn't be too hard, just passing an extra argument to the compiler.

Basic implementation has come with v0.8.0


Merges Master to Live. See commits for details.

Docs Build status updates of commit 332af13:
:clock10: Full build: the average full build time is 12 min(s) 30 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 332af13:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Set-CalendarProcessing.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/New-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Remove-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-dlp/Remove-DlpSensitiveInformationType.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/New-CsOnlineSession.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-Team.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 32cae3a:
:clock10: Full build: the average full build time is 12 min(s) 30 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 32cae3a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/Remove-CalendarEvents.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Set-CalendarProcessing.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/New-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Remove-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-dlp/Remove-DlpSensitiveInformationType.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/New-CsOnlineSession.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-Team.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ccc4e97:
:clock10: Full build: the average full build time is 12 min(s) 31 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit ccc4e97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/advanced-threat-protection/New-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/advanced-threat-protection/Set-AntiPhishPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/antispam-antimalware/New-HostedContentFilterPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mail-flow/Start-HistoricalSearch.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Remove-CalendarEvents.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/mailboxes/Set-CalendarProcessing.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/move-and-migration/New-MoveRequest.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Enable-OrganizationCustomization.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/New-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Remove-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/organization/Set-ApplicationAccessPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/policy-and-compliance-dlp/Remove-DlpSensitiveInformationType.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/New-CsOnlineSession.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-Team.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

  Invalid base branch - PR blocked
The target (base) branch - live - you're trying to merge this pull request into only accepts pull requests from the main branch.
If you're trying to publish changes you've made to the live site, you must first merge this pull request into the main branch. After this pull request is merged into the main branch, your changes will be published live at the next scheduled publish time. For information about the Marvel publishing process, see Marvel PubOps publishing process.
To change the target branch from live to main, use the following steps:

Select the Edit button next to the pull request title.

Select base:live.

In the list that appears, select main.

Select Change base.

NOTE Clicking Change base is safe. The message is specific to more complex branching methods that aren't typically used in Marvel repos. Even with those methods, this message only applies to how commits are tracked in the repo's history. There is no risk of data loss.