Pull request to run tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4cd2c0b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   90.16%
=======================================
  Files           ?        8
  Lines           ?       61
  Branches        ?        0
=======================================
  Hits            ?       55
  Misses          ?        6
  Partials        ?        0

Flag
Coverage Δ

#unittests
90.16% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd2c0b...467e5b7. Read the comment docs.


Issue when refreshing the container list page

When refreshing the container list view using F5, the view keeps loading and an error is raised in the console.
app.45b9f3c4.js:118 TypeError: Cannot read property 'provider' of undefined
    at app.45b9f3c4.js:5439
    at app.45b9f3c4.js:131
    at m.$eval (app.45b9f3c4.js:145)
    at m.$digest (app.45b9f3c4.js:142)
    at m.$apply (app.45b9f3c4.js:146)
    at l (app.45b9f3c4.js:97)
    at J (app.45b9f3c4.js:102)
    at XMLHttpRequest.t.onload (app.45b9f3c4.js:103)

Steps to reproduce the issue:

Go to the container list view
Hit F5
Boom

Technical details:

Portainer version: 1.11.1
Portainer Docker image tag (latest/arm/windows...): latest
Target Docker version (the host/cluster you manage): 1.13.0

This is due to the fact that the endpointMode is not defined yet.


[Help] - Floating point operations with Integer columns

Posted from stackoverflow: Original post
I am calculating fraction of orders that were not filled from a large list of order lines. I am using datafusion crate to perform analysis. I want to build a table that looks as shown below:
+--------+--------------+---------------+--------------+
| Month  | Total Orders | Missed Orders | Missed Ratio |
+--------+--------------+---------------+--------------+
| 201803 | 10           | 3             | 0.3          |
+--------+--------------+---------------+--------------+

To achieve this I have return following code:
    let result = record_count
        .select(vec![col("Month"),
            col("Total Orders"),
            col("Missed Orders"),
            (col("Missed Orders").cast_to(&DataType::Float64, &m_order_schema).unwrap() / col("Total Orders").cast_to(&DataType::Float64, &t_order_schema).unwrap()).alias("Missed Ratio")])?;

The total orders and missed orders column as integers so, I am casting them to float to get fraction. But, Missed Ratio column comes out as integer with all zeros. Result looks as shown below:
+--------+--------------+---------------+--------------+
| Month  | Total Orders | Missed Orders | Missed Ratio |
+--------+--------------+---------------+--------------+
| 201803 | 10           | 3             | 0            |
+--------+--------------+---------------+--------------+

Question: How to perform floating point operations with integer columns?

Sorry for the late response

Service Level column comes out as integer with all zeros.

I am not sure I understand the question -- there is no Service Level column in the output
If you could provide a self contained reproducer we might be able to help more

@alamb My bad. Service level = 1/Missed Ratio. I have edited the question to replace Service Level with Missed Ratio.

@praveentiru I don't normally use the dataframe API (and for your case, the SQL interface might work better).
But in any event, I tried to reproduce the problem you are having, and I was not able to. Here is the program I used:
async fn test_cast() {
    let mut ctx = ExecutionContext::new();

    let month: Date32Array = vec![Some(1000)].into_iter().collect();
    let total_orders: Int64Array = vec![Some(10)].into_iter().collect();
    let missed_orders: Int64Array = vec![Some(3)].into_iter().collect();

    let batch = RecordBatch::try_from_iter(vec![
        ("Month", Arc::new(month) as ArrayRef),
        ("Total Orders", Arc::new(total_orders) as ArrayRef),
        ("Missed Orders", Arc::new(missed_orders) as ArrayRef),
    ]).unwrap();

    let m_order_schema = DFSchema::try_from_qualified_schema(
        "m_orders",
        batch.schema().as_ref()
    ).unwrap();

    let t_order_schema = DFSchema::try_from_qualified_schema(
        "t_orders",
        batch.schema().as_ref()
    ).unwrap();

    let table = MemTable::try_new(batch.schema(), vec![vec![batch]]).unwrap();

    let record_count = ctx.read_table(Arc::new(table)).unwrap();

    let result = record_count
        .select(vec![col("Month"),
            col("Total Orders"),
            col("Missed Orders"),
                     (col("Missed Orders").cast_to(&DataType::Float64, &m_order_schema).unwrap() / col("Total Orders").cast_to(&DataType::Float64, &t_order_schema).unwrap()).alias("Service Level")]).unwrap();

    result.show().await.unwrap();

}

And when I ran that code, it appears to produce the output you expected:
Starting tests
+------------+--------------+---------------+---------------+
| Month      | Total Orders | Missed Orders | Service Level |
+------------+--------------+---------------+---------------+
| 1972-09-27 | 10           | 3             | 0.3           |
+------------+--------------+---------------+---------------+

@praveentiru did you install your python binding from source? if not, it might be really out of date.

@houqp I am working in Rust directly. I will try the code from @alamb and get back. I could not investigate over weekend.


Node: Error when saving nodes without names

Server logs:
An error occurred while getting nodes associated path ids: Cannot get nodes associated path ids from tables tr_transit_nodes and tr_transit_paths (error: The number of nodes received do not match the number of nodes sent in the query (DBQNGAP0003)) (DBQNGAP0004)
Now it is impossible to save a new node, even after running refresh transferable nodes. In fact, if you create a new node with a name, it works, but any new node without name, it will just silently ignore the save

The error you mentioned is not related, I'll open an issue for it. But saving a node without a node should not be allowed. Or should it? Now, it is possible to save a node without name or code

We need to think about this, should we allow nodes with no name? It could be useful in auto-generated nodes or just for testing purposes...

Turns out about the name, there is a preference transit.nodes.nameIsRequired to force require... anyhow, we still have to decide if we want the code to be mandatory.
As for the current issue, the problem of not saving is because the node has not changed since its creation and cannot be saved! If the object is new, it should be possible to consider it as changed, even if there is no history on the object. The validate method of objects will ensure that the object's initial default values are ok to be saved. In the case of a node, it is created with its precise geography, so a new node is valid.

Nice catch!


make sure PCMD params are ints (floats fail silently)

Note: only tested on wifi bebop2.

Looks good, thanks.


[SQLite Adapter] Triggers are dropped on table/column modification

When modifying tables or columns in SQLite, a lot of operations require a new temporary table to be made. The structure and the data is then moved from one table to another. Currently this does not bring the table triggers along with it.
There is a closed PR that demonstrates one way of fixing the issue: https://github.com/cakephp/phinx/pull/1284
However it was deemed that an alteration of the SQLite adapter is the right way to go about fixing it so it was closed. Creating an issue to highlight the problem and maybe somebody will want to re-write the adapter.

I ran into this with one migration that creates a table including a unique index, then another migration altering the table, and finally some UPSERT that complains:
PDOException: SQLSTATE[HY000]: General error: 1 ON CONFLICT clause does not match any PRIMARY KEY or UNIQUE constraint

Took me a while to understand that the actual issue was that the second migration resulted in the unique index being dropped. The error only occurred when I switched from Phinx 0.11 to 0.12.
Please adjust the issue summary to include "index" (and possibly also "view") so people can find it more easily.
Also please note that the documentation referred to above refers to "sqlite_schema" which does not exist in my version of SQLite (3.31.3) - it is called "sqlite_master" there.

Could you include the migrations that is causing the error for you?

Sure. Simple example:
First
$this->table('foo')
            ->addColumn('indexcol', 'integer')
            ->addIndex(
                'indexcol',
                ['unique' => true]
            )
            ->create();

Second
 $this->table('foo')
            ->changeColumn('indexcol', 'integer', ['null' => false])
            ->update();

Index is present after first, dropped by second migration.

Thanks for including the migration. Should be fixed for the next release. 😃


ServiceBus Track 2 [ServiceBusReactorReceiver]  Disposing Client cleanly for Delivery involved in transaction rollback

This is related clean up of PendingDeliveries at the time of Client disposing or shutdown. When client is shutting down or dispose() is called, ServiceBusReactorReceiver does clean up of pending work item.
When we try to resubmit pending work to service bus, we see error . Service bus complain that the transaction id on this Delivery is already complete or invalid.
This is because this transaction was rolled back. This is very specific case and happens for rolledback transaction only.
ServiceBusReactorReceiver.java : dispose()
UpdateDispositionWorkItem
Action : Follow up with Service bus on what is best strategy to deal with this.
Initial discussion with them suggest that we can release or abandon such Delivery.
Track 1 : Track 1 simply throw away deliveries at time of shutdown, because there is no harm and user can not do anything.
Options

Throw away Delivery which were involved in transaction
Release them by calling server ,  needs more investigation.

This work was complete in another PR earlier. If the delivery State is  of  type "TransactionalState" we will try to complete it in dispose() by calling "updateDispositionInternal()"
This will cleanly dispose this delivery.
This was suggested by service team as well.


Updating Text GDI - "your request type is not valid"

I am attempting to utilize this to make a batch update of text sources and am trying to make a proper change to a single TextGDI and when attempting to do so I am running into this errror.
not sure what I am doing wwrong, I've tried multiple ways and other 'things' and i keep getting "your request type is not valid"
I've tried other requests which are not in the samples and they wont work either?
like GetSourcesList for example
eq = simpleobsws.Request('SetTextGDIPlusProperties', {'source': "Test Text GDI", 'text': "Test Text GDI"})
    ret = await ws.call(req)

requests.append(simpleobsws.Request('GetVersion')) # Build a Request object, then append it to the batch
requests.append(simpleobsws.Request('GetStats')) # Build another request object, and append it
requests.append(simpleobsws.Request('SetTextGDIPlusProperties', {'source': "TEST TEXT GDI", 'text': "Miracle?"}))
ret = await ws.call_batch(requests, halt_on_failure = False) # Perform the request batch
print(ret)

    text = "Testtting"
    data = {"sourceName": "Test Text GDI", "text": text}

    result = await ws.call('SetTextGDIPlusProperties', data) # Make a request with the given data
    print(result)

Trying other things today like GetSceneitemProperties and it doesnt seem to be giving me the right response either, but get sceneitemID does... and sceneitemtransform
I really feel as if I'm missing something obvious but I'm using the examples given along with the websocket documentation and seems like ive got everything right

Make sure you are using 4.9.1 with simpleobsws<1.0.0 or 5.0.0* with simpleobsws>=1.0.0, as there was an api break at that version.


scroll.scrollTo position defined by variable

Is there any way to define the scrollTo position with a variable?
The use case is storing and retrieving arbitrary scroll positions.
something like:
let num = 500

scroll.scrollTo(num)

or
let num = this.state.prevScroll

scroll.scrollTo(num)

Currently not stored in a variable, but you could use somthing like this.
Events.scrollEvent.register('begin', function(to, element) {
      console.log("begin", arguments);
});

Events.scrollEvent.register('end', function(to, element) {
      console.log("end", arguments);
});


Memory usage problem on Windows with MinGW 64

On Windows with MinGW 64bit memory usage problem.
This will be ok...
    //memory ok
    //5MB
    aVector yy=x*2;
    for(int q=0;q<30000000;q++)
    {
        stack.new_recording();
        yy=x*2;
    }

But this memory usage will go through the roof. Even after Stack goes out of scope the memory is not freed up...
    //crazy memory usage and super slow
    //475MB and doesn't free even once
    //stack is out of scope
    for(int q=0;q<30000000;q++)
    {
        stack.new_recording();
        aVector yy=x*2;
    }

On Linux I had no such issue. I've tried various setting. I thought it might be something in the Packet.h file with freeing of memory but I don't understand what's going on in that file. Trying various compiler flags made no difference. Not building the library and instead using the method for non unix systems made no difference either. I use msys2 so my Windows system behalves more like that of Linux than Windows.
Below are what Stack said before and after the previous code. On Linux The result from Stack was about the same and nothing looks odd...
When stack is created

Automatic Differentiation Stack (address 0x22fa90):
   Currently attached - thread safe
   Recording status:
      Recording is ON
      0 statements (1048576 allocated) and 0 operations (1048576 allocated)
      0 gradients currently registered and a total of 1 needed (current index 0)
      Gradient list has no gaps
   Computation status:
      0 gradients assigned (0 allocated)
      Jacobian size: 0x0
      Independent indices:
      Dependent indices:
      Parallel Jacobian calculation can use up to 2 threads
      Each thread treats 4 (in)dependent variables

After the 475MB memory thing has happened

Automatic Differentiation Stack (address 0x22fa90):
   Currently attached - thread safe
   Recording status:
      Recording is ON
      1 statements (1048576 allocated) and 1 operations (1048576 allocated)
      42 gradients currently registered and a total of 70 needed (current index 69)
      Gradient list has 1 gaps (12-38 )
   Computation status:
      0 gradients assigned (0 allocated)
      Jacobian size: 0x0
      Independent indices:
      Dependent indices:
      Parallel Jacobian calculation can use up to 2 threads
      Each thread treats 4 (in)dependent variables

Below are all the outputs of the settings from settings.h for one of my tests...
version 2.0.5
compiler_version g++ [7.2.0]
compiler_flags
-g1 -O3 -D__unix__ -march=native
configuration
Adept version 2.0.5:
  Compiled with g++ [7.2.0]
  Compiler flags "-g1 -O3 -D__unix__ -march=native"
  BLAS support from blas library
  Jacobians processed in blocks of size 4

have_matrix_multiplication 1

Using make check one test always fail on Windows for me and that's ...
test_thread_safe_arrays... ./run_tests.sh: line 18:  4944 Segmentation fault      ./$TEST >> $LOG 2> $STDERR

In the test_results.txt file there is nothing under the test_thread_safe_arrays section...
########################################################
### test_thread_safe_arrays
########################################################

test_results.txt
All other tests passed.
Cheers,
Jonti

Hi Jonti,
Looking at Packet.h, which includes the alloc_alligned and free_aligned functions, I can see that there is a bug in the case that neither _POSIX_VERSION nor _MSC_VER are defined: in this case alloc_aligned uses the "new" function to allocate the memory, but it is not freed!  Could you please edit the free_aligned function with the changes in bold below and let me know if this helps?
Thanks,
Robin.
template <typename Type>
inline
void free_aligned(Type* data) {
  // Note that we need to use the same condition as used in
  // alloc_aligned() in order that new[] is followed by delete[]
  // and posix_memalign is followed by free
  if (Packet<Type>::alignment_bytes < sizeof(void*)) {
delete[] data;
  }
  else {

#ifdef _POSIX_VERSION
#if _POSIX_VERSION >= 200112L
free(data);
#else
delete[] data;
#endif
#elif defined(_MSC_VER)
_aligned_free(data);
#else
delete[] data;

#endif
}
}
On 28/10/18 23:44, Jonti Olds wrote:
On Windows with MinGW 64bit memory usage problem.
This will be ok...
//memory ok
//5MB
aVector yy=x*2;
for(int q=0;q<30000000;q++)
{
    stack.new_recording();
    yy=x*2;
}

But this memory usage will go through the roof. Even after Stack goes out of scope the memory is not freed up...
//crazy memory usage and super slow
//475MB and doesn't free even once
//stack is out of scope
for(int q=0;q<30000000;q++)
{
    stack.new_recording();
    aVector yy=x*2;
}

On Linux I had no such issue. I've tried various setting. I thought it might be something in the Packet.h file with freeing of memory but I don't understand what's going on in that file. Trying various compiler flags made no difference. Not building the library and instead using the method for non unix systems made no difference either. I use msys2 so my Windows system behalves more like that of Linux than Windows.
Below are what Stack said before and after the previous code. On Linux The result from Stack was about the same and nothing looks odd...
When stack is created
Automatic Differentiation Stack (address 0x22fa90):
Currently attached - thread safe
Recording status:
Recording is ON
0 statements (1048576 allocated) and 0 operations (1048576 allocated)
0 gradients currently registered and a total of 1 needed (current index 0)
Gradient list has no gaps
Computation status:
0 gradients assigned (0 allocated)
Jacobian size: 0x0
Independent indices:
Dependent indices:
Parallel Jacobian calculation can use up to 2 threads
Each thread treats 4 (in)dependent variables
After the 475MB memory thing has happened
Automatic Differentiation Stack (address 0x22fa90):
Currently attached - thread safe
Recording status:
Recording is ON
1 statements (1048576 allocated) and 1 operations (1048576 allocated)
42 gradients currently registered and a total of 70 needed (current index 69)
Gradient list has 1 gaps (12-38 )
Computation status:
0 gradients assigned (0 allocated)
Jacobian size: 0x0
Independent indices:
Dependent indices:
Parallel Jacobian calculation can use up to 2 threads
Each thread treats 4 (in)dependent variables
Below are all the outputs of the settings from settings.h for one of my tests...
version 2.0.5
compiler_version g++ [7.2.0]
compiler_flags
-g1 -O3 -D__unix__ -march=native
configuration
Adept version 2.0.5:
Compiled with g++ [7.2.0]
Compiler flags "-g1 -O3 -D__unix__ -march=native"
BLAS support from blas library
Jacobians processed in blocks of size 4
have_matrix_multiplication 1
Using make check one test always fail on Windows for me and that's ...
test_thread_safe_arrays... ./run_tests.sh: line 18:  4944 Segmentation fault      ./$TEST >> $LOG 2> $STDERR
In the test_results.txt file there is nothing under the test_thread_safe_arrays section...
########################################################
test_thread_safe_arrays
########################################################
test_results.txthttps://github.com/rjhogan/Adept-2/files/2523335/test_results.txt
All other tests passed.
Cheers,
Jonti
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/rjhogan/Adept-2/issues/9, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMWiWRDY6PGwF0Z3pBHDP35xU_3PF47kks5upkFzgaJpZM4X-QaK.
--
Professor Robin J. Hogan
Department of Meteorology
University of Reading
PO Box 243
READING RG6 6BB, UK
http:://www.met.rdg.ac.uk/~swrhgnrj/

Hi Robin,
I replaced the free_aligned function with the one you gave and I can confirm that fixes the memory usage problem. Thanks.
The test_thread_safe_arrays still fails on my Windows system so that looks like a different issue and was a bit of a red herring.
(gdb) run
Starting program: E:\git\Adept-2\test\test_thread_safe_arrays.exe
[New Thread 4996.0x1120]
[New Thread 4996.0xb54]

Thread 2 received signal SIGSEGV, Segmentation fault.
[Switching to Thread 4996.0xb54]
0x0000000000405ea4 in ?? ()
(gdb)

Cheers,
Jonti

Hi,
Glad it worked - I've pushed to github.
Could you check that when you run test/test_thread_safe_arrays on its
own you get no output?  I get the following:
Storage is not thread safe: using soft_link()
8 processors available running maximum of 8 threads
Parallel subsetting of array zillions of times was successful
If I uncomment the "#define ADEPT_STORAGE_THREAD_SAFE 1" line near the
top of test_thread_safe_arrays.cpp, and recompile, I get
Storage should be thread safe
8 processors available running maximum of 8 threads
Parallel subsetting of array zillions of times was successful
Could you let me know what happens in this second case?
Thanks,
Robin.

Hi Robin,
I had to add <<std::flush to the std::cout lines in  test_thread_safe_arrays.cpp to see any output before the segmentation fault. I think this is due to buffering of iostreams with MinGW. If a program crashes you don't get to see the the output without std::flush. After adding that I get the following with ADEPT_STORAGE_THREAD_SAFE not defined...
Storage is not thread safe: using soft_link()
2 processors available running maximum of 2 threads
Segmentation fault

and then with ADEPT_STORAGE_THREAD_SAFE defined...
Storage should be thread safe
2 processors available running maximum of 2 threads
Segmentation fault

Looking where the segmentation fault happens it's in...
// The following almost always causes a crash if the code is not
// properly thread safe
#pragma omp parallel for
for (int i = 0; i < N*1000; ++i)
{
    for (int j = 0; j < N*1000; ++j)
    {
        B[j % N] = noalias(B(__,j)) + T.diag_vector();
    }
}

The following one also causes the fault...
#pragma omp parallel for
for (int i = 0; i < N*1000; ++i)
{
    for (int j = 0; j < N*1000; ++j)
    {
        B[j % N] = noalias(B(__,j)) ;
    }
}

But this following one is ok...
#pragma omp parallel for
for (int i = 0; i < N*1000; ++i)
{
    for (int j = 0; j < N*1000; ++j)
    {
        B[j % N] =  T.diag_vector();
    }
}

So I'm not sure why the Array class is having multiple thread issues.
Although I don't think it is probably relevant, for some reason I can't create the shared library of Adept-2 only static libraries on MinGW. When it tries to build a shared library libtool says ...
libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only

I have built both shared and static version of BLAS and LAPACK and can use the shared BLAS and LAPACK libraries to build a shared Armadillo library with them. I think that it's something to do with libtool. I just mention this in case the segmentation fault only happens with static builds.
Cheers,
Jonti

Hi,
The issue is described (a bit) in section 3.15 of the Adept-2 documentation, and arises from the standard computer science problem of using objects that control their own destruction via reference counting, but must work in a multi-threaded program.  The two things you tested were two possible solutions to the problem: (1) disabling reference counting for an object that needs to be accessed by multiple threads and (2) using a reference counter that can only be modified atomically.  The fact that neither works implies there is something weird with OpenMP in your environment... so I'm not sure what to suggest.
Regards,
Robin.
On 30/10/2018 20:58, Jonti Olds wrote:
Hi Robin,
I had to add <<std::flush to the std::cout lines in test_thread_safe_arrays.cpp to see any output before the segmentation fault. I think this is due to buffering of iostreams with MinGW. If a program crashes you don't get to see the the output without std::flush. After adding that I get the following with ADEPT_STORAGE_THREAD_SAFE not defined...
Storage is not thread safe: using soft_link()
2 processors available running maximum of 2 threads
Segmentation fault
and then with ADEPT_STORAGE_THREAD_SAFE defined...
Storage should be thread safe
2 processors available running maximum of 2 threads
Segmentation fault
Looking where the segmentation fault happens it's in...
// The following almost always causes a crash if the code is not
// properly thread safe
#pragma omp parallel for
for (int i = 0; i < N1000; ++i)
{
for (int j = 0; j < N1000; ++j)
{
B[j % N] = noalias(B(__,j)) + T.diag_vector();
}
}
The following one also causes the fault...
#pragma omp parallel for
for (int i = 0; i < N1000; ++i)
{
for (int j = 0; j < N1000; ++j)
{
B[j % N] = noalias(B(__,j)) ;
}
}
But this following one is ok...
#pragma omp parallel for
for (int i = 0; i < N1000; ++i)
{
for (int j = 0; j < N1000; ++j)
{
B[j % N] =  T.diag_vector();
}
}
So I'm not sure why the Array class is having multiple thread issues.
Although I don't think it is probably relevant, for some reason I can't create the shared library of Adept-2 only static libraries on MinGW. When it tries to build a shared library libtool says ...
libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only
I have built both shared and static version of BLAS and LAPACK and can use the shared BLAS and LAPACK libraries to build a shared Armadillo library with them. I think that it's something to do with libtool. I just mention this in case the segmentation fault only happens with static builds.
Cheers,
Jonti
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/rjhogan/Adept-2/issues/9#issuecomment-434465474, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMWiWQ7Ac8pHHmEiIogk7KL7bWPLMavGks5uqL1mgaJpZM4X-QaK.
--
Professor Robin J. Hogan
Department of Meteorology
University of Reading
PO Box 243
READING RG6 6BB, UK
http:://www.met.rdg.ac.uk/~swrhgnrj/

Hi Robin,
Ah Ok. I tried updating my system with pacman -Su but that ended up braking something in BLAS/LAPACK/Armadillo so I had to compile them from source. After that nothing changed and I still got the multi thread problem. Something to remember but fortunately it's not important like the memory issue.
The memory problem would have been a show stopper as my interest in reverse auto differentiation is due to wanting to explore neural networks a little, so I needed to do lots of auto differentiations. Simple networks are relatively easy to figure out how the cost varies wrt the variables but I realized anything I wanted was crazy difficult, also it seemed somewhat silly spending so much time figuring out a derivative. I think I'm slowly understanding how reverse auto differentiation works but I'm not there yet. Certainly understanding how you do it efficiently for matrices I don't understand. I'm at the super simple level at the moment.
It doesn't stop me experimenting with it though. I've taught a vanilla recurrent neural network (RNN) to remember the last 2 inputs, xor them and return the result. I've used both the simplistic approach of using the derivatives I figured out by hand and also your library to do the differentiation for me. Both methods worked fine. Doing 100,000 trials took the pen and paper method 25s on my computer and your library method took 35s on my computer. The following figure shows the expected result of unheard random data entering the network for both of the training methods and the results coming out of the networks. As you can see both have been trained very well...

I went for RNN as you have to look back over time. That's simple to do for the by hand method but the auto differentiation method I was uncertain about, as the only way I could figure out how to do that was to clear the stack and refill it from scratch every time I took a time step. That seemed a waste of cpu and I would have rather trimmed a little of the bottom off the stack and added a little to top of the stack every time step. However, I'm not sure if that's possible or whether that would increase speed by much if any. Still the auto differentiation was a lot faster than I was anticipating and I am very happy with it. Next I'm going to experiment with multiple layers of GRUs as I can do that with auto differentiation but by hand that really would be horrid.
Attached is the source code for the RNN I talked about if you are interested...
qttest2.zip
Cheers,
Jonti

HI Robin,
I am very much a newcomer to neural networks and I am making many mistakes on the way so I could still have things wrong.
I'm not quite sure your pseudocode means what I'm thinking when I talk about looking back in time.
I tried writing the equations down but I think the more confusing than beneficial. So instead I put together this image that hopefully explains the issue and what I implemented in code...

Everything in one of the rectangle and the calculation of J belong to one calculation that needs to go through Adept. The final equation is for updating U and doesn't go through Adept. J is the cost. Alpha is the step size and y hat is the vector you would like y to be. Everything is a vector or a matrix apart from J and alpha. The circles can be called nodes and just perform some calculations of the inputs. The two rectangles are the first step and the second step respectively. This is currently what I have implemented in code.
You can see from going from the first step to the second step I have removed the first node and added a new node to the end. The h input to the second rectangle comes from the h output of the first node from the first step. After writing down these pictures I realize U and the hs still changes from one step to the other so that would mean updating all sorts of parts in the stack and now doesn't look as simple as I thought removing one node and added another.
However all may not be lost as the following should also be fine...

This is what I meant by remove the bottom node and add a new node to the top. In this case nothing much changes apart from the top and the bottom.
Trying this out in code just now using the same setting as the previous tests results in a average cost of 0.00014 after 100,000 steps and took 48 seconds. So that looks good assuming I implemented it correctly.
It's like calculating a derivative over a sliding window.
I hope that makes sense.
Cheers,
Jonti

Hi Robin,
It's been a while since I've been working on this problem so I'm a little more rusty. Yes I agree, looking back over what I wrote in the second case I can't see any reason why treating h3 as constant and using adept to find a good value for U4 would work. So I'm not sure what I was thinking there. Maybe it is just that simple, I'll have to have a look again and try it out to see if works if I can just autodifferentiate each node one at a time.
Interesting what you said about running multiple times before moving onto the next step I don't know if I thought about that, I will try that too and see what happens.
I hadn't heard of LBFGS  before, very interesting. As far as I know usually for neural networks steepest descent is used. The number of independent variables in U can be huge and can be in the millions so it's a horrible problem. My understanding of LBFGS is zero at the moment but I had a look and found https://www.reddit.com/r/MachineLearning/comments/4bys6n/lbfgs_and_neural_nets/ where someone asked why it isn't used for neural networks very often. So people do occasionally use it but as far as I know all modern programs like tensorflow use auto differentiation and steepest descent at their core. Still I'll definitely look into LBFGS if for no other reason than I know nothing about it at the moment. Thanks.
Cheers,
Jonti

Hi Jonti,
Conjugate gradient is another minimization strategy similar to L-BFGS, and is an option in GSL as well.
Anyway since I've fixed the original bug I'll close this thread now but feel free to email be directly with anything further on this topics.
Regards,
Robin.


Added severity to CLI output

I also added severity in https://github.com/invertase/dart_custom_lint/pull/86 which additionally adds JSON output.

@praxder Do you mind fixing the conflicts?
This otherwise looks good to me. I'm happy with giving it a quick merge once that's fixed

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: praxder:x: Adam SmithAdam Smith seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@rrousselGit Updated. I had some trouble testing these changes locally, so I'm not confident that they work. Let me know if I need to change anything else. 😬 Long-term, it would be great to have a Contributors guide in this repo.

LGTM! Assuming the tests pass, will merge :)

If you're looking at running custom_lint locally, one step is to change the packages/custom_lint/tools/analyzer_plugin/pubspec.yaml . See the TODO in there

@rrousselGit Updated. I think the one failing test was pre-existing, and introduced as part of this: https://github.com/invertase/dart_custom_lint/actions/runs/5277956808/jobs/9546659176


Get a cookie from a defined path

Hi guys!
Great module! It's very useful!
I have a question for you. I'm going to receive a cookie in my application from an external CRM. It could be stored with path and domain. Using your library, I've tried to retrieve it using the "get" method with cookies's name, but I can't get it if it was created with specified path.
Can I retrieve a cookie specifying the path that was used to create the cookie?
Thanks you in advance!
Jose

Hello,
I am very sorry for the late answer. I am quite busy at the moment and guess that this won't change until the end of the year 😀
Have you managed to solve your issue yet?
I will try to answer your question to the best of my knowledge. It is possible to get cookies from different paths, if you're doing this on the server side. It is more hacky and not recommended, if you're using JavaScript. Sources:

https://stackoverflow.com/questions/945862/retrieve-a-cookie-from-a-different-path
https://www.sitepoint.com/community/t/access-cookie-of-different-more-specific-path-but-same-domain/6475/4

I hope this helps.
Cheers
PS: Again, if you solved your issue I would appreciate if you could share your solution here, so that others can use your experience for future reference 👍


Implement Slack reminders (wip)

Description
Totally open to changes like naming nitpicks, code organization, logic, etc.
WIP:

[x] Adds query for forgotten conversations
[x] Finds slackable users from forgotten conversations
[x] Formats users, conversations, etc into a slack message
[ ] Sends slackable users said slack message
[ ] does this every day

Issue
https://github.com/papercups-io/papercups/issues/536
Checklist

[ ] Everything passes when running mix test
[ ] Ran mix format
[ ] No frontend compilation warnings

not sure why ChiragRamachandra approved this but please ignore that...
in the meantime @a8t let me know if you need any help testing this out on slack!

LOL, appreciate the approval. I won't have a chance to test this for a few days. Feel free to close the WIP if it's clutter!


Set a point's defaut time as system time.

Defaut time as 0 is a bug.

Can you please first create an issue which describes the problem and the reference the pull request to the ticket you address with it.


LIBFCREPO-1037. Updated Docker config to support SFTP

Addd "archelon-sftp" container to "docker-compose.yml". Added
"archelon-import-export-data" volume, used by both the "archelon" and
"archelon-sftp" containers to manage SFTP imports.
Updated the import/export environment variables to reflect their
actual location in the Docker environment.
https://issues.umd.edu/browse/LIBFCREPO-1037

@dsteelma-umd Looks good to me.


OptionalParameter.razor - misleading example for setting default parameter value (OnInitialized vs. OnParametersSet)

Description
Although it is not explicitly stated in referring article Components - Overview: Route parameters, the only possible interpretation of the code snippet is that it is trying to set a fallback (default) value for Text route parameter in OnInitialized.
https://github.com/dotnet/blazor-samples/blob/5ff0fac37cd80233f43ffc8cfb2174cff7ea77bd/8.0/BlazorSample_BlazorWebApp/Components/Pages/OptionalParameter.razor#L1-L13
@page "/optional-parameter/{text?}"

Blazor is @Text!

@code {
    [Parameter]
    public string? Text { get; set; }

    protected override void OnInitialized()
    {
        Text = Text ?? "fantastic";
    }
}

I think the usage of OnInitialized here is inappropriate and misleading.
Consider this simple repro:
@page "/optional-parameter/{text?}"

Blazor is @Text!

Great

Default

@code {
    [Parameter]
    public string? Text { get; set; }

    protected override void OnInitialized()
    {
        Text = Text ?? "fantastic";
    }
}

When you click Great, the result is Blazor is great! However, navigating to Default yields Blazor is ! since theOnInitialized method is not called when the component instance is reused with new parameter values.

To provide a good-practice example, we should change the code to use OnParametersSet method instead.

Oh, I found another clone of this example in Fundamentals - Routing and navigation: Route parameters section, the RouteParameter2.razor sample.
There, the suboptimal use of OnInitialized is addressed with a written explanation on why and when OnParametersSet should be used instead. This explanation mirrors the issue I've highlighted. It's unnecessary to provide an example that requires subsequent correction. Instead, we should directly use OnParametersSet, possibly with a note clarifying why OnInitialized should be avoided.

My proposal (I will submit a PR if we agree on the solution):

Change the OptionalParameter.razor and RouteParameter2.razor to use OnParametersSet instead of OnInitialized.
Change components/index.md to refer to OnParametersSet in text instead of OnInitialized.
Change fundamentals/routing.md and remove the explanation on how to fix the issue OnParametersSet.
[OPTIONAL] Add an explanation to fundamentals/routing.md on why OnInitialized should not be used.

IMHO, the use of OnInitialized should be considered narrowly, reserved exclusively for scenarios unaffected by parameter value changes and valid for the entire lifetime of the component INSTANCE. This might include loading static options for dropdowns and other "initializations" not dependent on parameter values (or their changes, respectively).
It seems this nuance is not emphasized enough in the documentation, as I frequently encounter this issue during code reviews. This recurring misunderstanding among developers highlights a gap in the educational materials provided.
Furthermore, the behavior of OnParametersSet regarding the detection of parameter changes is another area where developers often lack awareness. It's important to understand that OnParametersSet can be invoked, even if the parameter values have not changed. This behavior underscores the need for developers to implement additional logic within OnParametersSet to check whether parameter values have indeed changed before re-initializing data or state dependent on those parameters.
(But this relates to another section; here, it's just a lament.)
Page URL
https://learn.microsoft.com/en-us/aspnet/core/blazor/components/?view=aspnetcore-8.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/components/index.md
Document ID
31ad18df-1904-bbdd-cfed-8d0d0267c10e
Article author
@guardrex

I agree that this is a problem and agree with most of your proposal. I think your language describing the severity of the problem is too strong. To me, this is the critical point ...

reserved exclusively for scenarios unaffected by parameter value changes and valid for the entire lifetime of the component INSTANCE

If that's the spec, then that's what the dev should code for. The text fails to explain the approaches and behavioral differences clearly, and that's the main problem in my mind.
First off ... I'm going to perform a quick patch PR update to the Components node overview article section on Route parameters. There's a couple of aspects that I don't like about that section that I'd like to fix up. I'll ping back here shortly.
On the rest ...
Let's include (4) of your proposal 👍, but let's phrase it more along the lines of 'this is what will happen if OnInitialized{Async} is used'.
🤔 WRT addressing the subject in the Lifecycle article as part of this effort, it could go either way. It could be worked on the PR that fixes this issue, or it could be addressed by a separate issue/PR later. If you would like to work that on this issue, let's discuss that here before action is taken on the articles.
Two notes on the sample apps:

The locations of components changed when the samples went from only supplying snippets to acting as demonstration apps. Fortunately, a search in the repo's folder will turn up the components across the apps (Blazor Server, Blazor WASM, BWA). Optional params came in at 5.0, so hopefully you won't find a (broken) example in the 3.1 sample apps! 😄
Update the sample apps first. The docs build engine draws the code when the article is updated on a PR.

Stand-by for sec ...................... brb ...........................................

I will try to create PRs for these:

Start with the sample apps because the build system draws the code into the docs from that repo ... and please kill 🔪💀 the OptionalParameter component in the process.
Include (4) of your proposal 👍, but let's phrase it more along the lines of 'this is what the behavior is if OnInitialized{Async} is used.'

Please create a separate issue for the last one if you agree we should try to address this.

Let me know if you want to work on the Lifecycle article with this or if you would like me to open a new issue to address it later. We'd need to discuss changes for that article a bit more, and we can do that here or on a new issue.

Very good ... I'll open an issue for the Lifecycle article.


[REQUEST] - WHY GraphRAG retriever only supports one file_id at a time

Reference Issues
No response
Summary
can more graph rag file_ids be supported in future versions?  I want to leverage the advantages of GraphRAG in the multi-document Query-Focused Summarization (QFS) problem.
Basic Example
Cross-document indexing search
Drawbacks
no
Additional information
No response

marked it for the answer

HI, actually it is just how the current indexing process work for GraphRAG. You can upload multiple files at the same times (make sure that you press Upload and Index once).
Later just select any one of those uploaded files and retrieval process will consider all files uploaded together in that session.
But, if you want to gradually upload files one-by-one, then perform query on the whole collection it is not supported at the moment. Still some small changes in the code can support this quite easily.


ssh proxy

include ansible_ssh_private_key_file in ssh-bastion.conf for ProxyCommand

can you do one PR with both commit ?

could you update the PR with latest version of the bastion role ?

should add a when: key_file is defined'  and add a {stat: {path: {{key_file}}} to verify if the file exists


Migrate doc to readthedocs.io

Move away from github wiki and go to https://readthedocs.io/

Sooo done


[Feature Request] Audio files as media attachments

Mastodon v2.9.2 supports audio upload and federation (mp3/mpga). It would be great if rss-to-activitypub adds audio files to media attachments.

Great idea. I will add this.

Okay, now any RSS feed that supports the standard iTunes podcast enclosure format will have the mp3 as an attachment on Mastodon 2.9.2+.

Bravo!


Error: ggplot2 doesn't know how to deal with data of class matrix

I'm currently testing my installation of DangerTrack. I ran sh prepare.sh successfully, but when I run Rscript summarize.R, I get the following messages in stderr:
Attaching package: 'cowplot'

The following object is masked from 'package:ggplot2':

    ggsave

Attaching package: 'BiocGenerics'

The following objects are masked from 'package:parallel':

    clusterApply, clusterApplyLB, clusterCall, clusterEvalQ,
    clusterExport, clusterMap, parApply, parCapply, parLapply,
    parLapplyLB, parRapply, parSapply, parSapplyLB

The following objects are masked from 'package:stats':

    IQR, mad, xtabs

The following objects are masked from 'package:base':

    Filter, Find, Map, Position, Reduce, anyDuplicated, append,
    as.data.frame, cbind, colnames, do.call, duplicated, eval, evalq,
    get, grep, grepl, intersect, is.unsorted, lapply, lengths, mapply,
    match, mget, order, paste, pmax, pmax.int, pmin, pmin.int, rank,
    rbind, rownames, sapply, setdiff, sort, table, tapply, union,
    unique, unsplit

Attaching package: 'S4Vectors'

The following objects are masked from 'package:base':

    colMeans, colSums, expand.grid, rowMeans, rowSums

[1] "summary.1KG.5000.txt"
[2] "summary.ENCODE_DAC_blacklisted.5000.txt"
[3] "summary.GIAB.5000.txt"
[4] "summary.GRC_issues.5000.txt"
[5] "summary.map100mer.5000.txt"
[6] "summary.map50mer.5000.txt"
[1] 619150      7
                       #BIN events_1KG ENCODE_DAC_blacklisted events_GIAB
1              chr10:0-5000          0                      0           0
2         chr10:10000-15000          0                      0           0
3       chr10:100000-105000          1                      0           0
4     chr10:1000000-1005000          1                      0           0
5   chr10:10000000-10005000          0                      0           0
6 chr10:100000000-100005000          0                      0           0
  GRC_issues Mapability100mer Mapability50mer
1          1         0.000000       0.0000000
2          1         0.000000       0.0000000
3          1         0.570697       0.3202720
4          1         0.923622       0.8365010
5          0         0.195906       0.0307765
6          0         1.000000       0.9676170
Warning message:
Removed 1 rows containing non-finite values (stat_bin).
[1] 10000     4
       events_1KG events_GIAB Mapability100mer Mapability50mer
440289          2           0         0.978955        0.933754
251460          1           0         1.000000        0.974464
535266          0           0         0.999700        0.846184
262436          0           2         0.996842        0.837239
220858          0           0         0.998138        0.888584
276971          1           0         0.999367        0.906750
Error: ggplot2 doesn't know how to deal with data of class matrix
Execution halted

Thanks!

For what it's worth, I also get the following output in stdout:

[1] "summary.1KG.5000.txt"
[2] "summary.ENCODE_DAC_blacklisted.5000.txt"
[3] "summary.GIAB.5000.txt"
[4] "summary.GRC_issues.5000.txt"
[5] "summary.map100mer.5000.txt"
[6] "summary.map50mer.5000.txt"
[1] 619150      7
                       #BIN events_1KG ENCODE_DAC_blacklisted events_GIAB
1              chr10:0-5000          0                      0           0
2         chr10:10000-15000          0                      0           0
3       chr10:100000-105000          1                      0           0
4     chr10:1000000-1005000          1                      0           0
5   chr10:10000000-10005000          0                      0           0
6 chr10:100000000-100005000          0                      0           0
  GRC_issues Mapability100mer Mapability50mer
1          1         0.000000       0.0000000
2          1         0.000000       0.0000000
3          1         0.570697       0.3202720
4          1         0.923622       0.8365010
5          0         0.195906       0.0307765
6          0         1.000000       0.9676170
[1] 10000     4
       events_1KG events_GIAB Mapability100mer Mapability50mer
320193          0           0         0.991796        0.947221
119418          0           0         1.000000        0.968683
329841          0           0         1.000000        0.957862
201044          0           0         0.961997        0.568092
272139          0           0         1.000000        0.980700
191279          0           0         1.000000        0.905309

what R version are you using?

And also what version of ggplot2?

R version: 3.3.1
ggplot2: 2.2.1

Looks like that was from the correlations plot that we ended up not using in the end, so that error is real and evaded detection.
Anyway, it should be fixed now. Try the latest version.

It works now, thanks!


Go Language family CNB releases should contain a buildpackage artifact

Context
As buildpackages start to become the standard of shipping our CNBs, we should build a buildpackage of our Paketo language family Go CNB. This will make it way easier for users to consume specific language family buildpacks.
Proposal
start publishing a Paketo Go buildpackage whenever we ship a new release artifact.
Notes/Helpful Links

The pack command that we will have to run to do this is pack package-buildpack <NAME-OF-ARTIFACT> --package-config <Path/To/Package.toml>.

Acceptance/Deliverables

Go Language Family CNB github releases should contain an online buildpackage artifact in the release assets.
Go Buildpackage can be downloaded from Github and used to pack build apps

The latest releases include a buildpackage: https://github.com/paketo-buildpacks/go/releases/tag/v0.0.3.

Looks great! Downloaded the latest buildpackage and I was able to pack build a Go app using it. Closing this.


Empty table on input causes error

Viz. job 331525087:  Cannot upload file 'linked_orders.csv' to table 'out.c-app-snowflake.order_tree' in Storage API: Some columns are missing in the csv file. Missing columns: levels,root. Expected columns: parent,child,levels,root. Please check if the expected delimiter "," is used in the csv file.
ExceptionId docker-7c03753be01959c5b0d8aa4d67a5d8f6

fixed in 4a6c7c642998439507636a8b2466b23910c00c5a


fix build on cpu container

Checklist before submitting

[ ] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Build on CPU container, failed with the following error:
from torch._C import *
ImportError: libcupti.so.10.2: cannot open shared object file: No such file or directory
-----
-----
[OPEN-CE-ERROR]-11 Unable to build recipe: torchtext-feedstock

because it is using CUDA pytorch base.  And import torch for cuda pytorch-base fails on CPU container due to unavailability of CUDA libs.
Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

No it works with CUDA version too, because we are not adding a run time dependency on pytorch-select package hence it works with both CUDA/CPU pytorch-base.
Similar implementation is seen in https://github.com/pytorch/text/commit/f1c7f7d8ab1b6b0643fccce3da58c41db37664de

Closing the PR as this change is not needed.


only do layout when not in cmdwin

Hacky fix #78 , I'm sure there is a better way. But hopefully this illustrate
the problem even better. It works for in my setup though.

Fixed by another PR. thanks!


Requirements before Pip Install

Please add this line in your readme before PIP Install
sudo apt-get install build-essential libi2c-dev i2c-tools python-dev libffi-dev
This is required for smbus-cffi pip package

Thx for the contribution.


fix typo in rectangle_cpdef.pyx example

Thanks. We really should set up testing for these examples.


Tune optimization options for UglifyJS in webpack.conf

since we are not producing an 'un'-minified .js file anymore
if people want to debug our code, they should instead use the Typescript-Version directly in their projects

CLOSED -> Minify options seem to be already at maximum (safe) setting, the only way to improve on this would be to use the Google closure compiler with highest settings
-> this however compresses all method names, even the ones we use in interfaces (most of them), so for the moment that's pretty unusable...


feat: DIA-1415: Add LabelConfig->ResponseModel generator

Hi @robot-ci-heartex!
This PR was automaticaly generated via Follow Merge.
Please ensure that all linked upstream Pull Requests are merged before proceeding with this one.

https://github.com/HumanSignal/label-studio-sdk/pull/329 linked by Workflow Run

Follow Merge downstream workflow has been failed.

Workflow run


TypeError: Cannot read property 'getPath' of undefined

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When renaming an opened file in a git repository with the tree view, it shows the line Cannot read property 'getPath' of undefined under the dialog (but the file is renamed). The exception is thrown inside the git-diff package and its stack trace is:

Stack trace

TypeError: Cannot read property 'getPath' of undefined
    at /usr/lib/atom/node_modules/git-diff/lib/git-diff-view.js:131:45
    at Function.simpleDispatch (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:64:14)
    at Emitter.emit (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:257:28)
    at /usr/lib/atom/src/text-editor.js:820:22
    at Function.simpleDispatch (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:64:14)
    at Emitter.emit (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:257:28)
    at TextBuffer.setFile (/usr/lib/atom/node_modules/text-buffer/lib/text-buffer.js:587:18)
    at TextBuffer.setPath (/usr/lib/atom/node_modules/text-buffer/lib/text-buffer.js:554:17)
    at /usr/lib/atom/node_modules/tree-view/lib/tree-view.js:149:34
    at Function.simpleDispatch (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:64:14)
    at Emitter.emit (/usr/lib/atom/node_modules/event-kit/dist/emitter.js:257:28)
    at MoveDialog.onMove (/usr/lib/atom/node_modules/tree-view/lib/tree-view.js:1055:36)
    at MoveDialog.module.exports.MoveDialog.onConfirm (/usr/lib/atom/node_modules/tree-view/lib/move-dialog.js:65:16)
    at HTMLDivElement.Dialog.atom.commands.add.core:confirm (/usr/lib/atom/node_modules/tree-view/lib/dialog.js:53:26)
    at CommandRegistry.handleCommandEvent (/usr/lib/atom/src/command-registry.js:405:43)
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/lib/atom/node_modules/atom-keymap/lib/keymap-manager.js:617:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/lib/atom/node_modules/atom-keymap/lib/keymap-manager.js:408:22)
    at WindowEventHandler.handleDocumentKeyEvent (/usr/lib/atom/src/window-event-handler.js:153:34)

Steps to Reproduce

Add any git repository to the project.
Open a file inside the repository.
Rename the opened file by right-clicking it in the tree view -> rename.

Versions
OS: Arch Linux
Atom:
Atom    : 1.57.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

I can reproduce
Atom    : 1.57.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1
apm  2.6.2
npm  6.14.13
node 12.14.1 x64
atom 1.57.0
python 3.7.9
git 2.30.1

MacOS 11.2.1 (Intel chip)

Also reproduced
Atom    : 1.58.0-beta0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1
apm  2.6.2
npm  6.14.13
node 12.14.1 x64
atom 1.58.0-beta0
python 3.9.5
git 2.31.1.windows.1
visual studio 2015

Oops, after reproducing I realized I've already approved the pr.


[FLINK-28494] Add new job status states to CRD

What is the purpose of the change
This pull request adds 3 new fields to the JobStatus:

endTime (The endTime of a job, defaults to -1 for streaming job)
duration (Duration of a job, from start to now/end)
jobPlan (Contains info of job graph such as parallelism of job subtask)

Brief change log

The 3 new fields are added to FlinkDeployment and SessionJob CRD.
Observer logic is updated where it now listJobs() only if jobID is not available, else it will use query jobStatus based on available jobID

Verifying this change

This change is already covered by existing unit tests, such as ApplicationObserverTest, SessionObserverTest. However, unit tests are updated to reflect the new jobStatusObserver.observe() logic. No change to E2E tests required.
This change is tested against both Unit Test and E2E tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changes to the CustomResourceDescriptors: (yes)
Core observer or reconciler logic that is regularly executed: (yes)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Based on some offline discussion, this PR should only be merged for 1.2.0 (next week after the release-1.1 cut)

@darenwkt I think we can close this PR for now based on the offline discussions

Closing this based on the discussions


fix(docs): move images from external source to local

Should fix this

Thanks @SebCodesTheWeb ! Hope you are doing good! :)


Quantum states filtering

This PR addresses #330 , we can use optional data fields of ExoMol,  such as rotational quantum state,as a mask of lines.
An example is here.
Prior to this PR, we merged the I/O of optional fileds in radis. See the PR 541 in radis.
Important: meanwhile, use the develop branch of radis for this functionality.
document/analysis/select_quantum_states.py will make the following figure:

if you are interested in the Fortrat diagram, see here.


Bluetooth: controller: add missing ADI support in per adv chains

Recenlty there was added ADI support to periodic advertising.
There was missing implementation of ADI for periodic advertising
chained PDUs and direction finding. Also unit tests for periodic
advertising chains required update to handle ADI field.
The commit provides missing implementation.
Signed-off-by: Piotr Pryga<EMAIL_ADDRESS>

This PR blocks: https://github.com/zephyrproject-rtos/zephyr/pull/40073.
If fixes CI issue that occurred while build the #40073

@Thalley all comments were addressed


pretrain model with mIou 79.15

great job with new update. could you share the new pretrain model with 79.1 miou?

Thank you for your interest in my work! I'm currently preparing the release of the new models and the updated codebase. It will be released in the next few days.


fix(lazyfile): exclude editorconfig from skips

Also change the order of triggering events, so that FileType happens before BufReadPost, BufNewFile etc.
Fixes #3153

Thank you @dpetka2001 for fixing this!

I just removed all the code related to lazy_file and changed it in way where a file opened from the cmdline will be shown  quicker than before and without all the hacks related to lazy_file.
Related commits:

https://github.com/LazyVim/LazyVim/commit/b29d169afb7560ed4a9276e4379e28ffaed1a171
https://github.com/LazyVim/LazyVim/commit/965a469ca8cb1d58b49c4e5d8b85430e8c6c0a25
https://github.com/LazyVim/LazyVim/commit/8301096c31f9855c74d5b732367b679bc8721b5e

While time to first render is quicker than before, the startup time will be way slower. But that of course is to be expected, since file based plugins will now no longer load lazily, but they will load after first render.

@folke If that's the case maybe you would also like to exclude my previous PR #3004 from the latest release, since it doesn't apply to the current logic anymore.

I'll just leave it in there, since I have no idea how to change release-please release notes :)
And thanks again for looking into this!

No problem. I really enjoyed trying to learn a bit more about how it worked under the hood :)


[JS] Implement Node.js client for Plasma store

Reporter: Robert Nishihara / @robertnishihara
Note: This issue was originally created as ARROW-1700. Please see the migration documentation for further details.

Plasma has been deprecated (https://github.com/apache/arrow/issues/33077) in Arrow 10.0 and subsequently removed in Arrow 12.0 (https://github.com/apache/arrow/issues/33243). Given Plasma is no longer an existing component, closing this issue.
For reference, see this mailing list discussion around possible alternatives: https://lists.apache.org/thread/lk277x3b9gjol42sjg27bst2ggm5s0j2


Ecto.Schema.validate_default!/2 happens at compile time

Environment

Elixir version (elixir -v): 1.12.3
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): 13.4
Ecto version (mix deps): 3.7.0
Database adapter and version (mix deps): Postgrex 0.15.10
Operating system: OSX 11.6

Current behavior
Include code samples, errors and stacktraces if appropriate.
This issue was brought up in #3483 and the code was merged in #3487 but there is a corner case which I'm running into that causes my application to fail to compile when getting ready for production. We use a library that encrypts values before they are dumped to the DB. This library relies on a secret being available at runtime in order to process the custom type's dump function. Since the application does not have this value available at compile time, the code fails to compile and we cannot release new versions.
Expected behavior
I'm not 100% sure that this validation is necessary, but I'm sure @v0idpwn can give a legitimate reason as to why this fence should not be removed. When thinking about workarounds, I think the easiest option would be to create an escape valve within the validation if you have a legitimate reason to not check the default type. Something like skip_default_validation: true option should suffice. This way the previous behavior can be emulated and it is on the developer if they make a mistake. Let me know if you think of an alternative method to handle this issue or whether the added option field works. If that is good I can put together a PR and do some testing on my end to make sure everything is in working order.

Hi @tomciopp! Quick question: what is the default value in your case? Is it nil by any chance?
If not, maybe one option is to rescue if we can't validate the type and then warn instead of failing to compile. Would you be happy with this approach?

@josevalim It's usually an integer, sometimes it's a string. I could live in that world, although I'm not particularly in love with the idea of warnings that I know I will never be able to address. When I see a warning, my general response is to fix the code that has been deprecated. Ideally I want to live warning free, since a warning is a hint that I'm doing something wrong. In this case I want to tell ecto, "nah man it's cool don't worry about it, I got this"

So I think skip_default_validation sounds good. Can you please submit a PR?

@josevalim Yeah sure you should expect something in the next 24 hrs.

Hello! I'll be the devils advocate here (just because you asked in advance :))
Defaults are defined at compile time, and the fact that they're dumped in runtime only is an implementation detail. A workaround for this is setting autogenerate, which runs in runtime instead of compile time.
I don't see a problem in being able to skip the validation, though.

Fixed by #3749


tslint emit failures as errors

Introduces option tslintEmitErrors to override the defined severity for each rule and emit failures always as error.
resolves #27

Codecov Report

Merging #32 into master will increase coverage by 0.29%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   33.43%   33.73%   +0.29%
==========================================
  Files           8        8
  Lines         329      335       +6
  Branches       39       44       +5
==========================================
+ Hits          110      113       +3
- Misses        219      222       +3

Impacted Files
Coverage Δ

src/worker/TsCheckerRuntime.ts
0% <0%> (ø)
:arrow_up:

src/checker/resultSerializer.ts
50% <0%> (-6.25%)
:arrow_down:

src/TsCheckerWebpackPlugin.ts
96.55% <100%> (+0.12%)
:arrow_up:

src/worker/TsCheckerWorker.ts
91.48% <100%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9947f8...0c164b0. Read the comment docs.


Rewrite ~ from scratch for the conffile handling v2

The old config file handling made a few assumptions that I overloocked
regarding to how it managed the configuration files. This new version
has the following adjustments:

Only register the clear_data function to be called atexit once
Do not free / reload the entry vector for each different node
Shorter function names for internal functions
More carefull memory handling
Keep a cache of different files that where loaded
Do not use intermediary vector step to fill the entry_vector
Sub-includes and fallbacks working.

the "need to fo a thing" typo sneaked into this commit but it's already fixed here locally, don't need to coment on that.

+1 please fix those two things I mentioned and push this so we can move forward.
Note: I'm assuming code changes asked in the other revision were done.

Commited.
Closing.


Add side by side split view

What this does
This PR adds a new side by side view for the rooms and students, and allows the user to toggle between the existing tabbed view and new side by side view using the toggleview command. The default view is still the tabbed view.
Side by side view:

Closes #95
To do in another PR:

Update user guide.
Add/update use cases.

How to test

Start the app. It should be in the tabbed view.
To verify view toggling works:
Enter the command toggleview. The app should show the students and rooms side by side.
Enter toggleview again. The tabbed view should be shown again.
To verify the tabs still work:
Enter the rooms command. The app should switch to the rooms tab.
Enter the students command. The app should switch back to the students tab.
To verify that the view does not get toggled by other commands when in the side by side view:
Enter the command toggleview to switch to the side by side view.
Enter the rooms command. The app should remain in the side by side view.
Enter the students command. The app should remain in the side by side view.

Notes

Oh that's a good suggestion, let me add that in!


Bump Dependencies #1607425082

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/1607425082

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


PERMISSION: File browser for granting permissions

UP for Discussion - We might need to generalise the granting permission function a bit more to be used in any scenario. Right now we only have a UI where the user needs to give the exact URI of a resource to grant permission. I think we need to have some kind of a file browser so that user can select the files and grant permissions

Duplicate. Closing now


[OpaqueValues] Fixed index of self argument.

Previously, SILFunction_getSelfArgumentIndex was directly using the function type rather than interacting with the function convention. Here, it is made to interact with the convention.

@swift-ci please test


New movement mode, speed modifier and item behaviour (soon to be split)

I have created a new movement mode ("Unhinged") that you can modify the "running" speed for with "setSpeedModifier" changes the speed of either current mode, or a specified one.
Items will now be picked up with a set amount of delay.

Can one of the admins please verify this patch?

@GooeyHub: ok to test
Thanks @portokaliu ! Would you mind giving a bit more of an overall explanation of what was changed, how to test, and your goal with the changes? :-)

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/585/
Hooray Jenkins reported success with all tests good!

About the new movement mode:
I wanted to add a way to change the movement speed of the character without changing the overall "running speed". As I looked through the code it seemed necessary that a component that affected the movement speed would be necessary. That being said, I haven't separated the 2 axes yet, but it's a start for future improvements.
To test, just go type the "unhinged" command in console. It should be like the "ghost" one, without the fov change
About the debug command:
I found it necessary for movement modes to have easy to access speed modifiers, thus a debug command was needed.
You have the option of setting the speed of the current mode if you don't specify one. Of course, this just changes a speed parameter in the speed component so that logic elements may use it for further processing. In this case, the "unhinged" parameter is used in the KinematicCharacterMover by setting the maximum speed of the player 'x' times over the normal one while running. Otherwise, it keeps the "not running" speed, which is 1/1.45 * normal running speed.
For every mode that someone would want enhanced by this component, they would have to add a default value in the player prefab, a value in the component, and add the case scenarios in the ServerCharacterPredictionSystem and the SetSpeedModifierEvent.
A way to test it is to go in unhinged mode with the "unhinged" command,  then the "setSpeedModifier" command with any amount you wish to multiply the speed by. I don't think this speed is bound by server rules, but it is a player specific speed modifier, so I don't think it matters. I'll take any criticism tho :)
About the items change.
Items will now be dropped from the player with a 2 second pickup delay, and from items with the default value that exists in the ItemComponent, which I currently left 0. The condition for picking them up is the "pickableUp" bool to be true.
The current way I'm going about this is setting a delayed event as the item is dropped. This event will start after a time specified by the ItemComponent, called  "pickUpTime". This is the time in miliseconds after which any player can pick up the dropped items.
I plan on using this change in the future to make it so that "the owner will take longer to pick up the items than other players, but if the owner sticks around his dropped items, no other player can pick them up before him".
Way to test : throw items on the ground at your feet. They'll pop into your inventory as soon as their timer runs out. Blocks dropper from... blocks will still be 0 time pickup, unless you change the default value in the component.
Hope this was a bit more detailed @Cervator :)

As I explained on IRC, the movement speed modification possiblity seems redundant to GetMaxSpeedEvent. e.g.
https://github.com/Terasology/AlterationEffects/blob/master/src/main/java/org/terasology/alterationEffects/speed/SpeedAlterationSystem.java

I would also suggest sticking with the GetMaxSpeedEvent for adjusting movement speed.  It is presently complicated enough with the moving parts we have on character movement, I could see this muddying it up more so and making too many special conditions in the engine.
The speed modification component looked like an ok idea until I started thinking about what would happen long term.  Eventually would would need a field in the component for every movement mode.  And then additionally, you would also need a field for every type of modification that is possible with the GetMaxSpeedEvent where you can multiply before or after adding a static value.  It would start to get cumbersome quickly.
That said,  having the new Unhinged movement mode is a fine idea.  Basically mix and matching the movement settings together in a unique way.

Can you please update the title of this PR so it relates to the content?

Sorry, didn't realize that was the name of the PR  ^^'

@Josharias About the speed modification, I talked to @flo on IRC about this, and my interpretation of what he said was that he doesn't completely agree with the current movement system, and that separating the movement modes into different classes would be a good idea; From an outsider perspective I found this a good idea, and having them separated would lean more towards the modular system that the project is trying to achieve.
I was thinking that we could separate the speed types as well (walking speed - shift pressed, and running speed - no shift) so that we can accurately modify the speed depending on the movement mode and movement speed modifiers ( for this I was thinking of having a component that keeps every type of speed modifier in one place, with a bool for the "active" status and a value for the speed impact. (and there should be some time element there as well, I'm not completely certain how to go about this) )
What is your take on this?

What I meant is that MovementMode should be replaced in the long run with a something entity system based where new modes can be added easily. e.g. one approach could be to have one component class per movement mode. The movementMode field could then be a reference to a class. To get the current speed you would then do:
CharacterMovementComponent movementComponent = entiy.getComponent(CharacterMovementComponent.class)
Class<?> currentMovementModeClass = movementComponent.movementMode;
MovementModeComponent movementMode = entiy.getComponent(currentMovementModeClass);
float currentMaxSpeed = movementMode.maxSpeed;

MovementModeComponent would have the same field like MovementMode had and the concrete movement modes would inherit from it. Then you could specify the different movement modes like this in the prefab:
"WalkMovementMode": {
    "scaleGravity": 1.0,
     "scaleInertia": 1,
     "useCollision": true,
     "canBeGrounded": true,
     " respondToEnvironment": true,
     "maxSpeed": 3.0,
     "applyInertiaToVertical": false
},
"FlyMovementMode": {
    "scaleGravity": 0.0,
     "scaleInertia": 4,
     "useCollision": true,
     "canBeGrounded": false,
     " respondToEnvironment": false,
     "maxSpeed": 3.0,
     "applyInertiaToVertical": true
},

Another approach would be to have an entity per movement mode. That would be even more flexible, but I think we currently can't define sub entities in prefabs which would mean that code needs to add movement modes from prefabs.

Something like what @flo suggested sounds promising.  I would imagine only one of WalkMovementMode or FlyMovementMode being added to an entity at one time,  and then the engine would collect these variables like:
@ReceiveEvent
public void setMovementDetails(SomeSpecialEvent event, EntityRef entity, WalkMovementMode walkComponent, CharacterMovementComponent characterMovementComponent) {
    event.setAllTheStuffHere(...);
    event.setTheMaxSpeedHere(...);

    // ensure only one system can set the movement details
    event.consume();
}

This way you would not have to store what mode you are in on the CharacterMovementComponent. And it would be easy to plug in to for external modules.

@flo I'm trying to do that, but also want to add a "use collision damage" parameter, because sometimes you want to be stopped by the terrain but health not be an issue. Otherwise and "invulnerable" parameter would be ok, preventing any type of damage event to go through to the player (like it was described in the event system in general - by consuming the event if the param is true)
On the movement mode component idea, why can't we just get the component from the prefab and associate it to our current entity? Unless you meant that we could keep all movement modes under a single prefab with multiple defined entities, I'm not sure what you're saying.
@Josharias I stumbled upon AbstarctConsumableEvents while coding. Was wondering if I couldn't just use those for the same purpose?

Yes, the AbstractConsumableEvent is the one to use.  It has special logic in the engine to skip calling the rest of the event handlers if it is consumed.  By using an event to collect the movement variables,  then you do not have to limit movement modes to subclassing from a base component.
In regards to the damage bit, I would keep health and movement concepts isolated from each other so that we avoid flags and settings scattered around,  making it difficult to control.  That said,  there is already a few settings in the HealthComponent that relate to collision with the world: fallingDamageSpeedThreshold, horizontalDamageSpeedThreshold, excessSpeedDamageMultiplier.

@portokaliu  My first idea was just to have a single prefab for the character that has 1 component for each movement type. Thus character entities will also have 1 component for each movement type and it is possible to just  for example modfiy the walking speed while letting the flying speed in tact.
My second idea was to have 1 prefab per movement mode. The prefabs will be used to create 1 entity per movement mode and per character. Each character will have its own set of movement mode entities that represent possible movement modes. One of the movement mode entities of the character gets referenced by the movementMode field (the active one).
The prefab for the different movement modes will have the same components types, but different values. e.g. the walk prefab could look like this:
"CoreMovementModeProperties": {
     "scaleGravity": 1.0,
     "scaleInertia": 1,
     "useCollision": true,
     "canBeGrounded": true,
     "respondToEnvironment": true,
     "maxSpeed": 3.0,
     "applyInertiaToVertical": false
},
"MyComponent": {
   "useCollisionDamage": true
},
"ModeBasedAnimation": {
  "animationPool": ["humanWalk"]
}

The fly movement module would then look like this:
"FlyMovementMode": {
"scaleGravity": 0.0,
"scaleInertia": 4,
"useCollision": true,
"canBeGrounded": false,
"respondToEnvironment": false,
"maxSpeed": 3.0,
"applyInertiaToVertical": true
},
"MyComponent": {
"useCollisionDamage": false
},
"ModeBasedAnimation": {
"animationPool": ["humanFly"]
}
@portokaliu  We could of course also only have those components at the character entity and copy then from prefabs. Then the question is however: When do we copy? When we copy the speed values from preabs it is course not possible to change the values of a movement mode at runtime.

 @Josharias I think the idea with the events sounds also very promising. e.g. there could be a MovementModeUpdated event (not consumeable). It could trigger a RecalculateMaxSpeedEvent. The RecalculateMaxSpeedEvent handler  could then send a GetMaxSpeedEvent and uses the result to update the speed value.A GetMaxSpeedEvent event handler with the condition WalkingComponent exists would then set the speed to a default value. A low priority GetMaxSpeedEvent event handler sets a default value but it will only be called if the event does not get consumed first. The WalkingComponent would just be a marker component without content. (The marker component concept could also be used later to have animals flee from the player when it is in running towards them (character has RunningComponent))

Thus GetMaxSpeedEvent would no longer have to be spamed and we could introduce events for other fields too.

Hey guys
I read this whole thing over and I haven't really understood the need for separate entities for movement modes; I mean, I also don't see anything wrong with the current way of doing stuff. If you say it's "monolithic" to have all the movement modes in a single area, then I'd question the way KinematicCharacterMover is implemented;

It does seem like the discussion in this PR has gotten away from the original purpose into being more about redesigning the movement system to have better overall architecture :-)
Probably the current movement system is worth questioning, but maybe we should do that separately and just finish this up so it can be merged.
@portokaliu I noticed a couple odd Javadoc blocks and a star import, unsure if there might be a comment or two unaddressed. Maybe add another quick bit of tweaking and perhaps we can merge and worry more later :-)

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!


bst source-bundle fail's for the examples.

See original issue on GitLab
In GitLab by [Gitlab user @willsalmon] on Sep 13, 2018, 10:26
Summary
Buildstream source-bundle fail's for the examples.
Steps to reproduce
steps:

cd buildstream/doc/examples/flatpak-autotools
bst build hello.bst
bst source-bundle hello.bst

What is the current bug behaviour?
bst reports a bug and:
FileNotFoundError: [Errno 2] No such file or directory: '/home/will/.cache/buildstream/build/hello-y64su587/source/base-sdk'
What is the expected correct behavior?
Creates a folder/zip of the sources so you can build the element yourself. (I have not got this to work but I believe it should be a bit like a workspace but without the option to build in it.)
Relevant logs and/or screenshots

 will  CT-will-S-Deb  ~  projects  …  doc  examples  flatpak-autotools $ bst source-bundle hello.bst
[--:--:--][][] START   Loading elements
[00:00:00][][] SUCCESS Loading elements
[--:--:--][][] START   Resolving elements
[00:00:00][][] SUCCESS Resolving elements
[--:--:--][][] START   Resolving cached state
[00:00:00][][] SUCCESS Resolving cached state
[--:--:--][][] INFO    Bundling sources for target hello.bst
[--:--:--][][] START   Checking sources
[00:00:00][][] SUCCESS Checking sources
[--:--:--][d34ccf53][ main:base/sdk.bst                  ] START   Writing build script
[00:00:00][d34ccf53][ main:base/sdk.bst                  ] SUCCESS Writing build script
[--:--:--][94d6556f][ main:base/usrmerge.bst             ] START   Writing build script
[00:00:00][94d6556f][ main:base/usrmerge.bst             ] SUCCESS Writing build script
[--:--:--][cf34223f][ main:hello.bst                     ] START   Writing build script
[00:00:00][cf34223f][ main:hello.bst                     ] SUCCESS Writing build script
[--:--:--][d34ccf53][ main:base/sdk.bst                  ] START   Staging sources
[--:--:--][][] BUG     [Errno 2] No such file or directory: '/home/will/.cache/buildstream/build/hello-y64su587/source/base-sdk'

    Traceback (most recent call last):
      File "/home/will/.local/bin/bst", line 8, in <module>
        sys.exit(cli())
      File "/home/will/.local/lib/python3.5/site-packages/click/core.py", line 722, in __call__
        return self.main(*args, **kwargs)
      File "/home/will/projects/buildstream/buildstream/buildstream/_frontend/cli.py", line 162, in override_main
        standalone_mode=standalone_mode, **extra)
      File "/home/will/.local/lib/python3.5/site-packages/click/core.py", line 697, in main
        rv = self.invoke(ctx)
      File "/home/will/.local/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
        return _process_result(sub_ctx.command.invoke(sub_ctx))
      File "/home/will/.local/lib/python3.5/site-packages/click/core.py", line 895, in invoke
        return ctx.invoke(self.callback, **ctx.params)
      File "/home/will/.local/lib/python3.5/site-packages/click/core.py", line 535, in invoke
        return callback(*args, **kwargs)
      File "/home/will/.local/lib/python3.5/site-packages/click/decorators.py", line 27, in new_func
        return f(get_current_context().obj, *args, **kwargs)
      File "/home/will/projects/buildstream/buildstream/buildstream/_frontend/cli.py", line 831, in source_bundle
        except_targets=except_)
      File "/home/will/projects/buildstream/buildstream/buildstream/_stream.py", line 723, in source_bundle
        self._write_element_sources(tempdir, elements)
      File "/home/will/projects/buildstream/buildstream/buildstream/_stream.py", line 1092, in _write_element_sources
        element._stage_sources_at(element_source_dir)
      File "/home/will/projects/buildstream/buildstream/buildstream/element.py", line 1374, in _stage_sources_at
        if not vdirectory.is_empty():
      File "/home/will/projects/buildstream/buildstream/buildstream/storage/_filebaseddirectory.py", line 179, in is_empty
        self._populate_index()
      File "/home/will/projects/buildstream/buildstream/buildstream/storage/_filebaseddirectory.py", line 61, in _populate_index
        for entry in os.listdir(self.external_directory):
    FileNotFoundError: [Errno 2] No such file or directory: '/home/will/.cache/buildstream/build/hello-y64su587/source/base-sdk'

Possible fixes
...
Other relevant information
This was discovered while working on #512 but fixing this is not required to close it.

BuildStream version affected: master (c6155f8d40b5fc4564ed66b4f9d2cc0ad7144b8f) /milestone %BuildStream_v1.x

In GitLab by [Gitlab user @willsalmon] on Sep 13, 2018, 10:27
changed the description

In GitLab by [Gitlab user @willsalmon] on Sep 13, 2018, 13:50
changed the description

In GitLab by [Gitlab user @willsalmon] on Sep 13, 2018, 14:18
changed the description

In GitLab by [Gitlab user @willsalmon] on Sep 18, 2018, 15:10
removed milestone

In GitLab by [Gitlab user @cs-shadow] on Sep 18, 2018, 18:15
mentioned in commit fe69f3d1f83a0d13f0d51f1f3e6dc2a3fbb3b686

In GitLab by [Gitlab user @cs-shadow] on Sep 18, 2018, 18:17
mentioned in merge request !807

In GitLab by [Gitlab user @cs-shadow] on Sep 18, 2018, 18:58
mentioned in commit 2a3359d31a69a54841d237a14bcaed4aa6ad40e1

In GitLab by [Gitlab user @cs-shadow] on Sep 21, 2018, 14:10
mentioned in commit e209beb0ce71eb2214cd5ac663a577dbf423ecc2

In GitLab by [Gitlab user @cs-shadow] on Sep 21, 2018, 14:56
closed via merge request !807

In GitLab by [Gitlab user @cs-shadow] on Sep 21, 2018, 14:56
mentioned in commit 0b0005181676b9f60768495c91aa65818b6d318b


Links not clickable

Hi, while using nvALT I noted that links in the note are not clickable anymore. I'm using High Sierra, and in nvALT preferences the feature "turn link clickable" is activated. Can anyone help me?


CentOS 6 Python Installation Error

Hi,
I am trying to install Python But it can never find the version.
I have tried version = 3/34/34u/3.4.5, is there any way to use https://github.com/iuscommunity-pkg rpm ? They seem to maintain all required packages with the latest version
OS Version - CentOS release 6.8 (Final)
Config -
  class { 'python' :
    version    => '34',
    pip        => 'present',
    dev        => 'absent',
    virtualenv => 'present',
  }

Error Log :
Error: Execution of '/usr/bin/yum -d 0 -e 0 -y list 34' returned 1: Error: No matching Packages to list
Error: /Stage[main]/Python::Install/Package[python]/ensure: change from absent to present failed: Execution of '/usr/bin/yum -d 0 -e 0 -y list 34' returned 1: Error: No matching Packages to list
Notice: /Stage[main]/Python::Install/Package[pip]: Dependency Package[python] has failures: true
Warning: /Stage[main]/Python::Install/Package[pip]: Skipping because of failed dependencies
Notice: /Stage[main]/Python::Install/Package[virtualenv]: Dependency Package[python] has failures: true
Warning: /Stage[main]/Python::Install/Package[virtualenv]: Skipping because of failed dependencies
Notice: /Stage[main]/Python/Anchor[python::end]: Dependency Package[python] has failures: true
Warning: /Stage[main]/Python/Anchor[python::end]: Skipping because of failed dependencies
Notice: Finished catalog run in 9.19 seconds

The documentation is unfortunately out of date. To get the ius packages, specify the full package name as the version. for example, to install 3.4 from ius, use version => 'python34u'. Of course, make sure you have the ius repo installed.

@gotyaoi
Yup it worked after installing IUS repository.
I guess puppet-python currently finds by default only from EPEL repository, may be we can IUS support to it ?


[VS Code] Starting collaboration session: RPC connection closed.

<!--
For Visual Studio problems/feedback, please use the Report

It seems like you had a connectivity issue, do you remember the exact scenario? Can you please attach your logs here or email them to<EMAIL_ADDRESS>so that we can investigate this issue? You can get your logs by running "Live Share: Export Logs" in the command palette in VS Code.

Thanks for reporting this! We're already tracking this issue via #1353, so I'm going to close this as a duplicate.


Additional Description:
Risk Level: Low (test only)
Testing: Added unit test.
Docs Changes: NA
Release Notes: NA
Platform Specific Features: NA

/retest

/assign @antoniovicente


Rename the 'Rocket' weapon identifier to 'Missile'.

It is colliding with 'Rocket Launcher' weapon identifier.

It still fails to work properly.
print(GetWeaponID("ro"));
print(GetWeaponID("roc"));
print(GetWeaponID("rock"));
print(GetWeaponID("rocketla"));

Output:
-1
-1
-1
30

Try rol for rocket launcher.


AttributeError: module 'torch._C' has no attribute 'ScriptFunction'

🐛 Bug
I'm getting the following error when I try to run examples.roberta.multiprocessing_bpe_encoder:
AttributeError: module 'torch._C' has no attribute 'ScriptFunction'

The command is part of the instructions here: https://github.com/pytorch/fairseq/blob/master/examples/bart/README.summarization.md
To Reproduce
Steps to reproduce the behavior (always include the command you ran):

Install python 3.6 and torch 1.4 and the latest fairseq
Run: python -m examples.roberta.multiprocessing_bpe_encoder
See the error below.

Error:
 $ python -m examples.roberta.multiprocessing_bpe_encoder
Traceback (most recent call last):
  File "/user/conda/envs/p36/lib/python3.6/runpy.py", line 183, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/user/conda/envs/p36/lib/python3.6/runpy.py", line 109, in _get_module_details
    __import__(pkg_name)
  File "/home/ec2-user/fairseq/examples/__init__.py", line 8, in <module>
    import examples.noisychannel  # noqa
  File "/home/ec2-user/fairseq/examples/noisychannel/__init__.py", line 6, in <module>
    from .rerank_options import *  # noqa
  File "/home/ec2-user/fairseq/examples/noisychannel/rerank_options.py", line 6, in <module>
    from fairseq import options
  File "/home/ec2-user/fairseq/fairseq/__init__.py", line 12, in <module>
    from fairseq.logging import meters, metrics, progress_bar  # noqa
  File "/home/ec2-user/fairseq/fairseq/logging/progress_bar.py", line 20, in <module>
    import torch
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/__init__.py", line 280, in <module>
    from .functional import *
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/functional.py", line 2, in <module>
    import torch.nn.functional as F
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/nn/modules/__init__.py", line 23, in <module>
    from .rnn import RNNBase, RNN, LSTM, GRU, \
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 399, in <module>
    class LSTM(RNNBase):
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 523, in LSTM
    def forward(self, input, hx=None):  # noqa: F811
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/_jit_internal.py", line 489, in _overload_method
    qual_name = _qualified_name(func)
  File "/user/conda/envs/p36/lib/python3.6/site-packages/torch/_jit_internal.py", line 679, in _qualified_name
    if isinstance(obj, torch._C.ScriptFunction):
AttributeError: module 'torch._C' has no attribute 'ScriptFunction'

When I downgrade to torch==1.3 it gives a different error ("GELU" not found)
Code sample

Expected behavior

Environment

fairseq Version (e.g., 1.0 or master): master
PyTorch Version (e.g., 1.0) 1.4
OS (e.g., Linux): Linux
How you installed fairseq (pip, source): pip install --editable . from source
Build command you used (if compiling from source):
Python version: Tested in 3.6 and 3.7
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context
The command I'm trying to run is part of the instructions here: https://github.com/pytorch/fairseq/blob/master/examples/bart/README.summarization.md

fairseq requires torch 1.4, but I'm not able reproduce this. Can you try reinstall torch?
Then try:
python -m examples.roberta.multiprocessing_bpe_encoder --help

Thanks for looking into this.
Here are the complete steps to reproduce from scratch:
$ conda create --name xyz python=3.6
$ source activate  xyz
$ pip install torch
Collecting torch
  Using cached torch-1.4.0-cp36-cp36m-manylinux1_x86_64.whl (753.4 MB)
Successfully installed torch-1.4.0
$ git clone https://github.com/pytorch/fairseq.git fsq
$ cd fsq/
$ pip install --editable .
Successfully installed cffi-1.14.0 cython-0.29.15 fairseq numpy-1.18.1 portalocker-1.5.2 pycparser-2.20 regex-2020.2.20 sacrebleu-1.4.3 tqdm-4.43.0 typing-<IP_ADDRESS>
$ python -m examples.roberta.multiprocessing_bpe_encoder --help
Traceback (most recent call last):
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/runpy.py", line 183, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/runpy.py", line 109, in _get_module_details
    __import__(pkg_name)
  File "/home/ec2-user/fsq/examples/__init__.py", line 8, in <module>
    import examples.noisychannel  # noqa
  File "/home/ec2-user/fsq/examples/noisychannel/__init__.py", line 6, in <module>
    from .rerank_options import *  # noqa
  File "/home/ec2-user/fsq/examples/noisychannel/rerank_options.py", line 6, in <module>
    from fairseq import options
  File "/home/ec2-user/fsq/fairseq/__init__.py", line 12, in <module>
    from fairseq.logging import meters, metrics, progress_bar  # noqa
  File "/home/ec2-user/fsq/fairseq/logging/progress_bar.py", line 20, in <module>
    import torch
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/__init__.py", line 280, in <module>
    from .functional import *
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/functional.py", line 2, in <module>
    import torch.nn.functional as F
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/nn/__init__.py", line 1, in <module>
    from .modules import *
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/nn/modules/__init__.py", line 23, in <module>
    from .rnn import RNNBase, RNN, LSTM, GRU, \
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 399, in <module>
    class LSTM(RNNBase):
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 523, in LSTM
    def forward(self, input, hx=None):  # noqa: F811
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/_jit_internal.py", line 489, in _overload_method
    qual_name = _qualified_name(func)
  File "/home/ec2-user/anaconda3/envs/xyz/lib/python3.6/site-packages/torch/_jit_internal.py", line 679, in _qualified_name
    if isinstance(obj, torch._C.ScriptFunction):
AttributeError: module 'torch._C' has no attribute 'ScriptFunction'

Turns out that pip install torch results in a bad or incomplete pytorch installation.
Installing pytorch using conda instead solves the issue:
conda install pytorch torchvision -c pytorch