folded code stuck the scroll

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
I have an HTML document with many characters. when folding different parts of the document, the document loses its fluidity.
You can see a video that I recorded of the behavior. in a certain part of the video, you can notice the speed of the scroll between the zone with folded code, and the zone without folded code.
Steps to Reproduce
Edit step 2 by @rsese to mention specific lines to fold

save this gist: https://gist.github.com/unluisco/cb6d39da5f33117618dd0ab728219dce
open it with atom
fold the svg code (lines 18, 29, and 31)
scroll it

Expected behavior: [What you expect to happen]
I think the scrolling should be fluid
Actual behavior: [What actually happens]
the scrolling is stuck.
Reproduces how often: [What percentage of the time does it reproduce?]
whenever I fold a lot of code
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Atom    : 1.31.2
Electron: 2.0.7
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.1
npm  6.2.0
node 8.9.3 x64
atom 1.31.2
python 2.7.10
git 2.19.1
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.
this is the video: https://www.dropbox.com/s/b23i0cmzf2hdzem/atom.mp4?dl=0

Thanks for the report!  I see Atom isn't in safe mode in the video - can you confirm the behavior is the same in safe mode?  Also, what operating system are you running?

Thanks Robert, I opened atom in safe mode today and there is not the problem again.
I am using macOS Mojave 10.14 (18A391)
so this problem is from an extension, right?

I opened atom in safe mode today and there is not the problem again.

Ahh great, thanks for confirming :+1:
Since this doesn't reproduce in safe mode, you're correct, it's likely that a community package is causing the issue.  It may be that there is still a bug in Atom but if so, we'll need the maintainer of the package that is causing the problem to help track that down.  You should file this issue on their repository so they can either fix the problem or tell us where the problem is coming from.
To figure out which package is causing the issue, you can disable all community packages and enable them one-by-one until you see the behavior again or you could try package-cop which some people have found helpful. Once you've determined what package is causing the problem, The Atom FAQ has information on how to contact the maintainers of any Atom community package or theme so you can file this issue there.

I tried the installed packages one by one and is pigments the culprit.
@rsese how can I move this issue to the pigments repo?
cc @abe33.


chore(main): release 1.2.2

:robot: I have created a release beep boop
1.2.2 (2024-08-27)
Bug Fixes

fixed remux and shang-chi title returning as chinese (6088ce3)

This PR was generated with Release Please. See documentation.

Summary by CodeRabbit

New Features

Updated the project version from 1.2.1 to 1.2.2, indicating new improvements.

Bug Fixes

Documented a bug fix related to remux and title handling for "Shang-Chi" in the CHANGELOG, enhancing traceability for users.

:robot: Created releases:

v1.2.2
:sunflower:


Add README.cn.md

Purpose
To add chinese readme file.
Changes

Modified some sections of README.md
Add README.cn.md
Add .DS_Store into .gitignore
No code was changed.

Effect
Users from china will be easier to get started.
Tests
Nothing.
Usage
Nothing.

Coverage decreased (-0.2%) to 52.14% when pulling 3f18f5279661ce24a2e32a67316e28377be8da71 on wi1dcard:master into 581eb9ce6434b870ef004a9d70c2ccc14f9d5ab7 on phpbrew:master.

Coverage decreased (-0.2%) to 52.14% when pulling 3f18f5279661ce24a2e32a67316e28377be8da71 on wi1dcard:master into 581eb9ce6434b870ef004a9d70c2ccc14f9d5ab7 on phpbrew:master.


Optimize Makefile

This has been a bit of a pet of mine to get the compile time.
By default we run go fmt which can be awfully slow and then change
the timestamp so make(1) cannot detect if there is a change or not and
alway recompile[1]
It does run by default the unittests on every make command which is
something that takes quite some time as well.
Let's move those in the standard test target making sure this is
available in make release which arguably is the best place to have
those.
[1] which break my editor on the fly compilation for me.

LGTM


Main structure and tracking

This PR contains the necessary classes that build the SDK as well as everything necessary to make track requests (model classes and functions).
I've made some of the tests in Swift not only to make them nicer and easier to read but also because it makes it easier to verify if the SDK is nice and usable in Swift (due to how Objective-C is interpreted by Swift). This has caused some problems with travis and forced us to drop some of the jobs that were testing our SDK against multiple versions of the iOS SDK. This happens because in order to have the tests in Swift and the SDK in Objective-C this is dependant on a more recent version of Xcode (10.0) which sets the project as a Legacy Project. We can still test locally against older versions of the iOS SDK, but not with travis because travis bundles each version of the SDK with a version of Xcode.
Not in this PR (we should open issues with these topics):

Test against redirects. When looking for this, I saw that AFNetwork follows redirects because it is built on top of Foundation URL Loading system which already follows redirects, but testing it would still be a nice to have (https://github.com/AFNetworking/AFNetworking/issues/2387)
Module and Submodule organization. Currently, we are exposing all classes. It would be nice to research about Submodules and Modules in Objective-C to see if we can set some of the classes (like VSDKUtil) as Internal classes and only expose the classes that we want. Even if we end up exposing everything, it would still be cool to have a proper Module and Submodule organization for better Swift interoperability.
Divide the Refund model class into TotalRefund and PartialRefund
Test against multiple SDKs (as mentioned previously)

I know it might be difficult to hop into this PR, because you are not used to working with Objc, so when I was learning I've kept track of the most important things you need to know to understand it.
Coursera course in Objective-C:

Module 6:

Objects

Module 7:

Message Passing
Properties

Module 10:

Callbacks and Blocks

Quick useful links:

https://stackoverflow.com/questions/2238584/difference-between-and-methods-in-objective-c
https://stackoverflow.com/questions/12898820/why-do-we-need-protocol-in-objective-c

More in depth links:

https://useyourloaf.com/blog/objective-c-class-properties/
https://medium.com/@MarkEdwardMurray/objective-c-class-initializers-a-k-a-constructors-94dcd6d2ffd7
https://www.luby.info/2017/09/14/objc-class-property-constants.html
https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/Introduction/Introduction.html#//apple_ref/doc/uid/TP40011210-CH1-SW1

Thank you for pointing out the learning material to review the PR. It definitely helps to get on board 👍

Regarding the issue with the code coverage dropping to 18%, this is already fixed in another branch. This is caused because Codecov is also taking into account the imported frameworks (which are not being tested).

I'm a bit uncertain about the spread usage of NS_ASSUME_NONNULL_BEGIN. Some comments reflect that. I noticed some other places, but for the sake of avoiding repeating myself, I stopped adding comments for this case and see where the discussion ends. In case we decide to change it, I don't mind adding comments in the rest of the places where I detected it.

Yes, I agree we can remove the NS_NON_NULL_BEGIN/END in all tracking model classes

There is one other thing I almost forgot, every time the user declares an event, he has to set the siteId and clientId, right? Given that they will be most likely constant, can we make the API possible to set them only once and propagate them to every event generated? For instance, these variables by default could be read from the environment variables or even be passed as command line arguments.

Yes, I agree we can remove the NS_ASSUME_NONNULL_BEGIN/END in all tracking model classes

Xcode shows a bunch of warnings. Can you fix them? I presume it was caused by the removal of this macro.

Yes, I agree we can remove the NS_ASSUME_NONNULL_BEGIN/END in all tracking model classes

Xcode shows a bunch of warnings. Can you fix them? I presume it was caused by the removal of this macro.

 Can you fix them? I presume it was caused by the removal of this macro.

Can you post some screenshots or logs of the errors? Could not replicate this.

There is one other thing I almost forgot, every time the user declares an event, he has to set the siteId and clientId, right? Given that they will be most likely constant, can we make the API possible to set them only once and propagate them to every event generated? For instance, these variables by default could be read from the environment variables or even be passed as command line arguments.

Do you have any suggestion about how we would implement this? This would be nice, but if we were to do this I would like it to be agnostic of any logic (making it for any values, not only for the siteId or clientId), something like an auto-filler that would populate instances of VSDKTrackingEvent with a set of predefined values selected by the developer. Something like this:
NSDictionary * predefinedValues =  @{@"siteId" : @"1", @"clientId" : @"2", @"pageType" : @"fooPage" };

VSDKTrackingEvent * event = [[VSDKPageView alloc] init];
event.title = @"fooTitle";

[VSDKTrackingEventFiller config: predefinedValues event: event]; //Merge the event with the predefinedValues

But I think doing something like this would be quite complex and don't know if we should bundle it in this PR.

 Can you fix them? I presume it was caused by the removal of this macro.

Can you post some screenshots or logs of the errors? Could not replicate this.

Here is one:
velocidi-ios-objc-sdk/VelocidiSDK/VelocidiSDK/Tracking/Model/VSDKTransaction.h:19:20: Pointer is missing a nullability type specifier (_Nonnull, _Nullable, or _Null_unspecified)

There is one other thing I almost forgot, every time the user declares an event, he has to set the siteId and clientId, right? Given that they will be most likely constant, can we make the API possible to set them only once and propagate them to every event generated? For instance, these variables by default could be read from the environment variables or even be passed as command line arguments.

Implemented in e4a3f01


[WIP] Social without Identity - Updates

@Rick-Anderson
Still a work-in-progress for now, but I thought it might be useful to create a draft PR to show where I'm at. The main thing that's outstanding is the explanation of the DefaultScheme, DefaultChallengeScheme, etc (I know, I know, that's the main part :stuck_out_tongue_closed_eyes:). I'll address that in the next commit, which I'm hoping to get to in the next day or two.
Feedback on what I have so far is, of course, very much appreciated. I've borrowed content from other topics and tried to follow conventions I've found there as best as I can.

Sorry, I didn't mean to break a build :disappointed:. What did I do wrong?

@scottaddie  how do we fix This branch is out-of-date with the base branch

@scottaddie how do we fix This branch is out-of-date with the base branch
cc @tdykstra @guardrex

If it were me, I'd rebase on current master and force push.

I branched from rick-anderson/social/without/identity, so I don't think I can rebase on master as the changes I've made here sit on top of @Rick-Anderson's branch and not master. I could be wrong...
I guess that trying to PR into a non-master branch is rare, but I wasn't sure if there was another way to go about it.

I don't know see how you could have gotten out of sync with Rick's branch as it appears to have been inactive for more than a month, but can you rebase on it instead of on master?

It all looks like it's in-sync. I'm trying to rebase onto the latest from Rick's branch and I get:

Current branch serpent5-12091 is up to date.

I'll see if I can dig a little deeper and find out more about what's going on...

It might be worth making a new branch and a new PR -- if the same thing happens we can assume it's a  problem in our build system and we can submit a request to investigate.

Ok, I'll do that. Thanks for your help and suggestions.


[editorial] markdownlint in less then 1.5 sec

Adds a Gulp task named lint-md to run markdownlint

The task runs in less than 1.5 seconds over the same files as the markdownlint make target, which takes much longer, when run from the command line

Fixes the errors reported by markdownlint Gulp task. I'm unsure why, with the same config, the CLI misses those errors
Replaces the call to the markdownlint CLI with the Gulp task in the markdownlint job

As you can see from the GH actions above, the new Gulp task takes 17s to do markdownlint checks (that includes running npm install).

... also make it use the same in the make task markdown-link-check?

@joaopgrassi - done


Create SECURITY.md

Pull Request Test Coverage Report for Build 190

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 188:
0.0%

Covered Lines:
77

Relevant Lines:
77

💛  - Coveralls


[Feature Request] Support for nested resources

As best I can tell, there's currently no support for nested resources.  Nested resources are relatively common in the REST APIs I've used. For example, I might have an API that provides banking account information by exposing the resource endpoints shown below.
https://myservice.com/accounts
https://myservice.com/accounts/1/transactions

The first is a top-level resource that retrieves basic information for all accounts.  The second is a nested resource that retrieves transaction details for a specific account.  I don't believe there's a way to support this second, nested resource using the in-memory-web-api.
I would be glad to work up a Pull Request if you're interested in adding this feature.  I've overridden parseUrl in my app to identify fully qualified collection names for nested resources.  For example, parsing a request to the transactions endpoint shown above would result in a collection name of 'accounts/1/transactions'.  The hash I return from `createDb' then must contain a collection key of the same name.

There is not support for nested resources. We regret that we won't be adding such support, even if someone (like you) is kind enough to supply an implementation.
There are too many possible implementations. Are transactions a nested object within accounts or are they in a different collection related by a foreign key. What's the property name for that FK? What about delete, insert, update? Does order matter. It never stops.  And someone is bound to be disappointed, leading to more options and more complexity.
This project exists primarily to support the Angular documentation samples. It is wonderful that so many people also find it useful for their development. But we can only go so far in catering to everyone's needs given our available resources and the purpose of this project.
Fortunately, you can override both the parseUrl method and the implementations of any of the HTTP methods. The ReadMe describes how.
Thanks for giving this project a try.


OOM when using quantize.py to quantize llama-like model

System Info

GPU: 2xA100-40G
TensorRT-LLM v0.8.0

Who can help?
@Tracin
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction
When I want to quantize the model, AquilaChat2-34B, which architecture is Llama-like. I want to quantize the model using the commands like Llama, https://github.com/NVIDIA/TensorRT-LLM/tree/main/examples/llama. I want to do the int8_kvcache+awq quantization.
#!/bin/bash
python ../quantization/quantize.py --model_dir /tmp/AquilaChat2-34B/ \
                                   --output_dir ./tllm_aquila_checkpoint_1gpu_awq_int8_kv_cache \
                                   --dtype float16 \
                                   --qformat int4_awq \
                                   --awq_block_size 128 \
                                   --kv_cache_dtype int8 \
                                   --calib_size 1 \

Expected behavior
Quantize the model using int8_kvcache+awq method.
actual behavior
I try running the commands both out of and in the container, but both run into "CUDA OOM", the full log is:
[NeMo W 2024-03-12 13:29:16 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/pydub/utils.py:170: RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work
      warn("Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning)

Initializing model from /tmp/AquilaChat2-34B/
Loading checkpoint shards:   0%|  | 0/7 [00:00<?, ?it/s][NeMo W 2024-03-12 13:29:19 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/torch/_utils.py:836: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()
      return self.fget.__get__(instance, owner)()

Loading checkpoint shards: 100%|█| 7/7 [00:14<00:00,  2.
Initializing tokenizer from /tmp/AquilaChat2-34B/

AWQ calibration could take longer than other calibration methods. Please increase the batch size to speed up the calibration process. Batch size can be set by adding the argument --batch_size <batch_size> to the command line.

Loading calibration dataset
{'quant_cfg': {'*weight_quantizer': {'num_bits': 4, 'block_sizes': {-1: 128}, 'enable': True}, '*input_quantizer': {'enable': False}, '*lm_head*': {'enable': False}, '*output_layer*': {'enable': False}, 'default': {'enable': False}, '*.query_key_value.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}, '*.Wqkv.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}, '*.W_pack.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}, '*.c_attn.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}, '*.k_proj.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}, '*.v_proj.output_quantizer': {'num_bits': 8, 'axis': None, 'enable': True}}, 'algorithm': {'method': 'awq_lite', 'alpha_step': 0.1}}
Starting quantization...
Replaced 1263 modules to quantized modules
Caching activation statistics for awq_lite...
Calibrating batch 0
Loading extension ammo_cuda_ext...
Loading extension ammo_cuda_ext_fp8...
Searching awq_lite parameters...
Calibrating batch 0
[NeMo W 2024-03-12 13:29:40 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/ammo/torch/quantization/nn/modules/tensor_quantizer.py:153: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
      self.register_buffer("_pre_quant_scale", torch.tensor(value))

[NeMo W 2024-03-12 13:29:40 nemo_logging:349] /usr/local/lib/python3.10/dist-packages/ammo/torch/quantization/nn/modules/tensor_quantizer.py:155: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
      value = torch.tensor(value, device=self._pre_quant_scale.device)

Calibrating batch 0
Quantization done. Total time used: 16.35 s.
Unknown model type AquilaForCausalLM. Continue exporting...
Warning: export_npz is going to be deprecated soon and replaced by safetensors.
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
Padding vocab_embedding and lm_head for AWQ weights export
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
current rank: 0, tp rank: 0, pp rank: 0
torch.distributed not initialized, assuming single world_size.
torch.distributed not initialized, assuming single world_size.
Cannot export model to the model_config. The AMMO optimized model state_dict (including the quantization factors) is saved to tllm_aquila_checkpoint_1gpu_awq_int8_kv_cache/ammo_model.0.pth using torch.save for further inspection.
Detailed export error: CUDA out of memory. Tried to allocate 288.00 MiB. GPU 0 has a total capacity of 39.39 GiB of which 98.81 MiB is free. Process 1762589 has 39.28 GiB memory in use. Of the allocated memory 38.72 GiB is allocated by PyTorch, and 69.27 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/ammo/torch/export/model_config_export.py", line 316, in export_model_config
    model_config_dict = model_config_to_dict(model_config)
  File "/usr/local/lib/python3.10/dist-packages/ammo/torch/export/model_config_utils.py", line 49, in model_config_to_dict
    return dataclasses.asdict(model_config)
  File "/usr/lib/python3.10/dataclasses.py", line 1238, in asdict
    return _asdict_inner(obj, dict_factory)
  File "/usr/lib/python3.10/dataclasses.py", line 1245, in _asdict_inner
    value = _asdict_inner(getattr(obj, f.name), dict_factory)
  File "/usr/lib/python3.10/dataclasses.py", line 1273, in _asdict_inner
    return type(obj)(_asdict_inner(v, dict_factory) for v in obj)
  File "/usr/lib/python3.10/dataclasses.py", line 1273, in <genexpr>
    return type(obj)(_asdict_inner(v, dict_factory) for v in obj)
  File "/usr/lib/python3.10/dataclasses.py", line 1245, in _asdict_inner
    value = _asdict_inner(getattr(obj, f.name), dict_factory)
  File "/usr/lib/python3.10/dataclasses.py", line 1245, in _asdict_inner
    value = _asdict_inner(getattr(obj, f.name), dict_factory)
  File "/usr/lib/python3.10/dataclasses.py", line 1245, in _asdict_inner
    value = _asdict_inner(getattr(obj, f.name), dict_factory)
  File "/usr/lib/python3.10/dataclasses.py", line 1279, in _asdict_inner
    return copy.deepcopy(obj)
  File "/usr/lib/python3.10/copy.py", line 153, in deepcopy
    y = copier(memo)
  File "/usr/local/lib/python3.10/dist-packages/torch/_tensor.py", line 122, in __deepcopy__
    new_storage = self._typed_storage()._deepcopy(memo)
  File "/usr/local/lib/python3.10/dist-packages/torch/storage.py", line 839, in _deepcopy
    return self._new_wrapped_storage(copy.deepcopy(self._untyped_storage, memo))
  File "/usr/lib/python3.10/copy.py", line 153, in deepcopy
    y = copier(memo)
  File "/usr/local/lib/python3.10/dist-packages/torch/storage.py", line 112, in __deepcopy__
    new_storage = self.clone()
  File "/usr/local/lib/python3.10/dist-packages/torch/storage.py", line 126, in clone
    return type(self)(self.nbytes(), device=self.device).copy_(self)
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 288.00 MiB. GPU 0 has a total capacity of 39.39 GiB of which 98.81 MiB is free. Process 1762589 has 39.28 GiB memory in use. Of the allocated memory 38.72 GiB is allocated by PyTorch, and 69.27 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF
Quantized model exported to ./tllm_aquila_checkpoint_1gpu_awq_int8_kv_cache
Total time used 419.97 s

additional notes
I also tried it on 4xA100-40G, still cuda oom.

I build a new image with the latest version updated in https://github.com/NVIDIA/TensorRT-LLM/pull/1274, followed the doc https://github.com/NVIDIA/TensorRT-LLM/blob/main/docs/source/build_from_source.md#option-1-build-tensorrt-llm-in-one-step. I find that the quantize.py has changed. However, when I run the quantization code on 2xA100-40G to quantize the model Aquilachat2-34B, an OOM still occurs.
python ../quantization/quantize.py --model_dir /tmp/AquilaChat2-34B \
                                   --dtype float16 \
                                   --qformat int4_awq \
                                   --awq_block_size 128 \
                                   --output_dir ./quantized_int4-awq \
                                   --calib_size 1 \

Does the 34B model indeed needs such a huge memory?

Hi @andakai do u still have further issue or question now? If not, we'll close it soon.


Turn on warning mode for specs

What was the end-user problem that led to this PR?
The problem was that we're missing verbose warnings like the one fixed by #7417.
What was your diagnosis of the problem?
My diagnosis was that our specs should let us know about this.
What is your fix for the problem, implemented in this PR?
My fix is to enable warnings from our helpers that shell out, and fix the warnings they print. There's also some unrelated changes here that I'll try to split out once I get this green.
Why did you choose this fix out of the possible options?
I chose this fix because it makes it so that our specs help us catching these warnings earlier.

The only failing specs are now hitting the problem being fixed by https://github.com/bundler/bundler/pull/7417, so they should get green after that PR is merged and prevent future warnings from creeping in.

@bundlerbot merge


🐛 BUG:Wrangler SDK can't deploy workers

Which Cloudflare product(s) does this pertain to?
Wrangler core
What version(s) of the tool(s) are you using?
3.4.0
What version of Node are you using?
v16.17.0
What operating system are you using?
MacOS Ventura
Describe the Bug
Getting this error
Banyatis-MacBook-Pro:find-stream-chat-user banyati$ wrangler deploy
 ⛅ wrangler 3.4.0
------------------
✘ [ERROR] ParseError: A request to the Cloudflare API (/accounts/96f8637892042b2b1c3cd1569ba7f2d9/workers/services/find-stream-chat-user) failed.

      at throwFetchError (/usr/local/lib/node_modules/wrangler/wrangler-dist/cli.js:121134:17)
      at fetchResult (/usr/local/lib/node_modules/wrangler/wrangler-dist/cli.js:121087:5)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at async deploy (/usr/local/lib/node_modules/wrangler/wrangler-dist/cli.js:147720:31)
      at async Object.deployHandler [as handler]
  (/usr/local/lib/node_modules/wrangler/wrangler-dist/cli.js:138267:3) {
    text: 'A request to the Cloudflare API
  (/accounts/96f8637892042b2b1c3cd1569ba7f2d9/workers/services/find-stream-chat-user) failed.',
    notes: [ { text: 'Authentication error [code: 10000]' } ],
    location: undefined,
    kind: 'error',
    code: 10000
  }

Total Upload: 1.41 KiB / gzip: 0.62 KiB

✘ [ERROR] A request to the Cloudflare API (/accounts/96f8637892042b2b1c3cd1569ba7f2d9/workers/scripts/find-stream-chat-user) failed.

  Authentication error [code: 10000]

  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose`
```
whenever I deploy, tried setting up the CLOUDFLARE_API_TOKEN, CLOUDFLARE _API_KEY AND CLOUDFLARE API image. but still the above error

### Please provide a link to a minimal reproduction

_No response_

### Please provide any relevant error logs

_No response_

Try using the wrangler login command if you're using wrangler on your local machine. The environment variable auth method is more useful when running wrangler in CI/CD. Feel free to reopen if this doesn't solve your issue.


Hide engagement modal for anonymous user

Details

Hide engagement modal for anonymous user
Fixed Issues

$ https://github.com/Expensify/App/issues/35131
PROPOSAL: https://github.com/Expensify/App/issues/35131#issuecomment-1913104970
Tests

Create a public room
Copy the URL of this room
Sign out
Open this public room above
Verify that the engagement modal doesn't show

[x] Verify that no errors appear in the JS console

Offline tests

None
QA Steps

Create a public room
Copy the URL of this room
Sign out
Open this public room above
Verify that the engagement modal doesn't show

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/129500732/97ef7672-9aa4-4444-8fd1-4134ed2989d2

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/e9f5103c-7a8c-438d-aa1d-e4e4f6bfc8fd

iOS: Native
https://github.com/Expensify/App/assets/129500732/8ea0c61c-f8a2-488f-adce-770245d7ee63

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/7ce5c192-d7ca-45e2-9abf-afef7e1bf4f7

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/3d48b277-a10d-40e2-a149-8a11374be1cb

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/97dd9fb1-5e1a-4f30-8900-51b9a10e8ab3

I think the label was incorrectly applied? All the tests passed AFAICT.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Detector：retinanet

BCNet-main/configs/Base-FCOS.yaml  作者您好，在该文件中第5行，NAME: "build_retinanet_resnet_fpn_backbone"，如果我想将Detector改成faster-rcnn，请问需要修改哪些内容呢

想麻烦您能否提供一份faster-rcnn的config

hi, you could find the config for faster rcnn at detectron2 repo. My suggestion is that, you replace the maskhead of detectron2 implementation with ours. Faster-rcnn is their default detector usage.

thanks

#43 “It is contained in the code here. You just need to modify the config to use faster rcnn instead of fcos as object dectecter.” 您好，在这个Issues的最后您回复说只需要modify the config即可，我使用了detectron2的官方faster-rcnn config，但运行时出现了error。config设置如下：
MODEL:
META_ARCHITECTURE: "GeneralizedRCNN"
BACKBONE:
NAME: "build_resnet_fpn_backbone"
RESNETS:
OUT_FEATURES: ["res2", "res3", "res4", "res5"]
FPN:
IN_FEATURES: ["res2", "res3", "res4", "res5"]
ANCHOR_GENERATOR:
SIZES: [[32], [64], [128], [256], [512]]  # One size for each in feature map
ASPECT_RATIOS: [[0.5, 1.0, 2.0]]  # Three aspect ratios (same for all in feature maps)
RPN:
IN_FEATURES: ["p2", "p3", "p4", "p5", "p6"]
PRE_NMS_TOPK_TRAIN: 2000  # Per FPN level
PRE_NMS_TOPK_TEST: 1000  # Per FPN level
# Detectron1 uses 2000 proposals per-batch,
# (See "modeling/rpn/rpn_outputs.py" for details of this legacy issue)
# which is approximately 1000 proposals per-image since the default batch size for FPN is 2.
POST_NMS_TOPK_TRAIN: 1000
POST_NMS_TOPK_TEST: 1000
ROI_HEADS:
NAME: "StandardROIHeads"
IN_FEATURES: ["p2", "p3", "p4", "p5"]
ROI_BOX_HEAD:
NAME: "FastRCNNConvFCHead"
NUM_FC: 2
POOLER_RESOLUTION: 7
ROI_MASK_HEAD:
NAME: "MaskRCNNConvUpsampleHead"
NUM_CONV: 4
POOLER_RESOLUTION: 14
DATASETS:
TRAIN: ("coco_2017_train",)
TEST: ("coco_2017_val",)
SOLVER:
IMS_PER_BATCH: 16
BASE_LR: 0.02
STEPS: (60000, 80000)
MAX_ITER: 90000
INPUT:
MIN_SIZE_TRAIN: (640, 672, 704, 736, 768, 800)
VERSION: 2
FCOS with improvements
BASE: "/home/prj/BCNet-main/configs/base.yaml"
MODEL:
WEIGHTS: "/home/github/R-101.pkl"
RESNETS:
DEPTH: 101
MASK_ON: True
ROI_HEADS:
NUM_CLASSES: 21
DATASETS:
TRAIN: ('bop_train',)
TEST: ('bop_val',)
SOLVER:
IMS_PER_BATCH: 16
BASE_LR: 0.02
STEPS: (1300,1500)
MAX_ITER: 2000  # 17.4 epochs
WARMUP_ITERS: 100
error：
Traceback (most recent call last):
File "/home/prj/BCNet-main/detectron2/engine/train_loop.py", line 131, in train
self.run_step()
File "/home/prj/BCNet-main/detectron2/engine/train_loop.py", line 213, in run_step
loss_dict = self.model(data, self.iter, self.max_iter)
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 705, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
TypeError: forward() takes 2 positional arguments but 4 were given
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 59, in _wrap
fn(i, *args)
File "/home/prj/BCNet-main/detectron2/engine/launch.py", line 83, in _distributed_worker
main_func(*args)
File "/home/prj/BCNet-main/train.py", line 470, in main
return trainer.train()
File "/home/prj/BCNet-main/detectron2/engine/defaults.py", line 373, in train
super().train(self.start_iter, self.max_iter)
File "/home/prj/BCNet-main/detectron2/engine/train_loop.py", line 134, in train
self.after_train()
File "/home/prj/BCNet-main/detectron2/engine/train_loop.py", line 142, in after_train
h.after_train()
File "/home/prj/BCNet-main/detectron2/engine/hooks.py", line 353, in after_train
self._do_eval()
File "/home/prj/BCNet-main/detectron2/engine/hooks.py", line 321, in _do_eval
results = self._func()
File "/home/prj/BCNet-main/detectron2/engine/defaults.py", line 324, in test_and_save_results
self._last_eval_results = self.test(self.cfg, self.model)
File "/home/prj/BCNet-main/detectron2/engine/defaults.py", line 484, in test
results_i = inference_on_dataset(model, data_loader, evaluator)
File "/home/prj/BCNet-main/detectron2/evaluation/evaluator.py", line 122, in inference_on_dataset
outputs = model(inputs, idx, len(data_loader))
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 705, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/home/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
TypeError: forward() takes 2 positional arguments but 4 were given
Thank you very much for your work and admire your detailed answers in each issue，your spirit of scientific research is admirable


need example  for Flutter iOS with Filament

Sorry we don't know Flutter and we can't take on more languages/frameworks at this time

Sorry we don't know Flutter and we can't take on more languages/frameworks at this time


testpr1 - 92

[Auto generated]
Number: [#92]

github-gitlab-webhook-server: Closing issue for PR: testpr1.
PR was closed.


Missed error Stack Trace and Custom Attributes

Description
There's Rails project with microservices, so if I want to track errors occur in microservice I use perform_action_with_newrelic_trace method from NewRelic::Agent::Instrumentation::ControllerInstrumentation.
Errors are reported to New Relic, but with weird behavior.
If error raises more than once in one place during less than 10 seconds, they come to New Relic first all with Custom Attributes, but then first one receives Stack Trace and loses Custom Attributes, but rest of them don't receive Stack Trace and keep Custom Attributes.
According to logs, all errors are reported with the same data: same amount of attributes and stack trace.
Expected Behavior
All errors have both Custom Attributes and Stack Trace.
Steps to Reproduce
require 'newrelic_rpm'

class RandomClass
  include ::NewRelic::Agent::Instrumentation::ControllerInstrumentation

  def random_method
    perform_action_with_newrelic_trace(name: 'random_method', class_name: 'RandomClass', category: 'OtherTransaction/RandomService') do
      random_error  # raises NameError, for example
    end
  end
end

Then to call RandomClass.new.random_method more than 1 time.
Your Environment
ruby - 3.1.2
rails - 6.1.3
newrelic_rpm - 8.7.0

Hi @ErmolkinVlad! Thanks for reaching out. I'm working on reproducing the issue you're describing.
When you say, "According to logs, all errors are reported with the same data: same amount of attributes and stack trace.", are you looking at the newrelic_agent.log file or the newrelic_audit.log file?

Also, could you let me know where you're looking in the UI for the stack trace and attributes data?

Hello @kaylareopelle.
Actually, I used my own logs here: https://github.com/newrelic/newrelic-ruby-agent/blob/da892884c9b9311d1179f09a33208c060083e73c/lib/new_relic/agent/new_relic_service.rb#L419
Checked data sending to New Relic via send_request method.

Thanks, @ErmolkinVlad! I was able to reproduce the behavior you described. We're looking into this and will get back to you when we know more! 😄

Hi, @ErmolkinVlad! So far, we've been able to determine the stack trace erasing behavior isn't caused by the Ruby agent and it isn't caused by some sort of UI filter. The stack traces are vanishing in one of New Relic's systems between the agent and the UI. I've been chatting with different teams who deal with data ingest and processing and we're still looking for the place where the stack traces are sampled.
As far as the custom attributes go, there was a recent bug resolved that sounds very similar to the behavior you described. Can you see if your attributes now appear as expected?
Thanks for your patience! 🌻

@angelatan2 - Do we have the new public portal ticket for this one?

Hello, @ErmolkinVlad! Thanks for your patience. We were able to track down where this data is processed and got the following response from the team:

Error details published by the agent are not guaranteed to result in exactly one TransactionError event and exactly one ErrorTrace event. The ErrorTrace event, which has the stack trace, falls under the "trace details" category of events and is expected to have fewer events that TransactionErrors in addition to being subject to a more strict rate limit.

I hope this helps! If you think this behavior should not be the case, and you'd like to submit a feature request, you can do so by posting in the New Relic Support Community or by opening a support ticket, depending on your support level.  Please provide a link to this GitHub issue when submitting your community post or support ticket.


Not able to disable the scrolling when the mouse is hovering the list item

The scrolling of the dropdown can be down by moving the mouse down in the autocomplete list. There is no way to disable that.
In the auto-complete.js file, the select function is called when the mouse hovers a list item that triggers the event 'suggestion-selected':
self.select = index => {
      if (index < 0) {
        index = self.items.length - 1;
      }
      else if (index >= self.items.length) {
        index = 0;
      }
      self.index = index;
      self.selected = self.items[index];
      events.trigger('suggestion-selected', index);
    };

And then it calls the function scrollToElement:
events.on('suggestion-selected', index => {
        scrollToElement(element, index);
      });

Is there any way to disable this feature for mouse hovering?

@felipebetteloni
Why do you want to disable scrolling in the suggestions-list ?
How will you access all the elements if there are too many items in the list ?
From your description it seems like your issue is something else, because suggestion-selected shouldn't be fired only by hovering over the suggestion-list.
May be your mouse is faulty and clicking itself.


Add support for the socklist template

Add support for the socklist template. See https://en.wikipedia.org/wiki/Template_talk:SPI_report#Proposed_change_to_sock_list

Not that I can see this mattering, but if I'm following the logic correctly here, I believe it would take an empty parameter name as equivalent to a numbered one due to the \d* in L764. E.g. in {{sock list|=foo}}, it would take foo as a sock, while the template would throw that out.

Good point. I will update that regex.

If possible, this would be good for this patch to be pushed to main soon as this template is likely to be added to twinkle + the SPI preload form, and without this patch (or another similar one) the tool won't be able to read the users / IPs from the template.

@Dreamy-Jazz I just realized this also needs to be used on renames. I've modified the module so that it will have the same behavior to add the master as the 1st param to {{sock list}} and set note1 to ({{clerknote}} original case name). As a bonus, if you pass the remove_master param, you can avoid all that regex to actually remove the master from the wikitext. {{sock list|Foo|Bar|remove_master=yes}} on SPI/Foo will have the same effect as {{sock list|Bar}}.


Wns report description

@maliberty @jeffng-or @xtofalex Flattend synthesis reduces number of instances by 50%
variant 2, flattened synthesis:

variant base, hierarchical synthesis:

This is why we have the two pass synthesis in ORFS to selectively flatten.  Most likely you can keep the upper levels of hierarchy without much QOR difference.

This is why we have the two pass synthesis in ORFS to selectively flatten. Most likely you can keep the upper levels of hierarchy without much QOR difference.

I could run lots of synthesis runs to try to figure out what effect flattening which modules has on the QoR, though I'm unsure what I would do with this information. At this point, I'd just flatten everything anyway.
hierarchical synthesis is valuable to help the macro placer, but once I have the macro placement, flattening everything is the best policy I'm aware of.

That's a viable strategy for a completely frozen design.  Not as good if you are making rtl changes where new logic could influence macro placement.

That's a viable strategy for a completely frozen design. Not as good if you are making rtl changes where new logic could influence macro placement.

Changing RTL is not a problem for the megaboom flow:

run hierarchical, generate macro placement file
run flattened, use macro placement file

so I get flattened synthesis and automatic macro placement based upon hierachical synthesis.
Running time increases by 50% for synthesis since it is 3x instead of 2x.

This line of thinking assumes that standard cells don't affect macro placement but that isn't true. If you have 50% less std cell area then you could, for example, move the macros closer together. mpl2 does consider both macros and std cells.

Well.... I was told to use SYNTH_HIERARCHICAL=1 with automatic macro placement, but that doubles the number of instances, so perhaps in this case, SYNTH_HIERARCHICAL=0 & macro place yields better results?
A think to try....

Some more reporting. Not pretty, but good 'nuf for use around the house.
Stage: cts

Variant
base
2

Description

Same as base, but with flattend synthesis

Buffer
264492
119157

Clock buffer
23052
12067

Clock inverter
6997
3634

Inverter
141051
62571

Macro
72
72

Multi-Input combinational cell
1365515
745216

Sequential cell
239698
118443

Tie cell
2578
60

Timing Repair Buffer
88407
43364

Total
2131862
1104584

slack
-5494.812988
-3262.439697

MACRO_PLACEMENT_TCL

0

SYNTH_HIERARCHICAL
1146
$(location write_macro_placement)

dissolve
37

2_1_floorplan.log
1519
566

2_2_floorplan_io.log
35
20

2_3_floorplan_macro.log
895
22

2_4_floorplan_tapcell.log
1596
18

2_5_floorplan_pdn.log
49
874

3_1_place_gp_skip_io.log
6140
1954

3_2_place_iop.log
610
28

3_3_place_gp.log
1474
3907

3_4_place_resized.log
543
328

Base configuration variables

Variable
Value

CORE_AREA
2 2 1998 1998

DIE_AREA
0 0 2000 2000

FILL_CELLS

GPL_ROUTABILITY_DRIVEN
1

GPL_TIMING_DRIVEN
0

HOLD_SLACK_MARGIN
-200

IO_CONSTRAINTS
$(location :io-boomtile)

MACRO_PLACE_HALO
19 19

MAX_ROUTING_LAYER
M7

MIN_ROUTING_LAYER
M2

PDN_TCL
$(PLATFORM_DIR)/openRoad/pdn/BLOCKS_grid_strategy.tcl

PLACE_DENSITY
0.24

PLACE_PINS_ARGS
-annealing

ROUTING_LAYER_ADJUSTMENT
0.45

SDC_FILE
$(location :constraints-boomtile)

SETUP_SLACK_MARGIN
-1300

SKIP_CTS_REPAIR_TIMING
1

SKIP_INCREMENTAL_REPAIR
1

SKIP_LAST_GASP
1

SKIP_REPORT_METRICS
1

SYNTH_HIERARCHICAL
1

TAPCELL_TCL

TNS_END_PERCENT
0

SYNTH_HIERARCHICAL is not the only control.  With some care you use MAX_UNGROUP_SIZE to get minimal QOR loss and keep much of the hierarchy.

SYNTH_HIERARCHICAL is not the only control. With some care you use MAX_UNGROUP_SIZE to get minimal QOR loss and keep much of the hierarchy.

I see. I figure that turning the knob all the way to one side, I can see if it does anything at all... Tinkering with the knob comes later.


[2pt] Update main.rb: Author and Game classes - Team Member #3

The following options should be available:

List of games
List all authors (e.g. 'Stephen King')
Add a game

Pull request for this task


WIP - Mermaid experiments

This adds a mermaid based state diagram to the Health Service docs to potentially replace an existing image.

vs.

the health service is actually not calling the Liveness Probes of the other Pods. But maybe it should (could?)?! :) thoughts @msimecek ?

the health service is actually not calling the Liveness Probes of the other Pods. But maybe it should (could?)?! :) thoughts @msimecek Martin Simecek FTE ?

VSCode doesn't support mermaid, yet. That's why I've ended with the draft PR..
The diagram was supposed to visualize that Application and Backend Process representing deployments/pods use HealthService for their liveness probe.

@sebader this is what i was trying to visualize:
/src/app/charts/catalogservice/templates/deployment.yaml
        livenessProbe:
          httpGet:
            path: /health/liveness
            port: {{ .Values.workload.port | default 8080 }}
          initialDelaySeconds: 10
          periodSeconds: 30
          timeoutSeconds: 3
        startupProbe:
          httpGet:
            path: /health/liveness
            port: {{ .Values.workload.port | default 8080 }}

But you're right, they're pointing to themselfs.

Its then probably more like this:

And to respond to the initial question - means that the healthservice would currently not recognize that the application deployment (or the background processor) does not work? @msimecek / @sebader

I'm afraid to say that you made a very valid observation ;) We only check the dependencies (i.e. the Azure services) as of today

But you're right, they're pointing to themselfs.

well, technically it is k8s checking the pods

Drawing diagrams helps!

But you're right, they're pointing to themselfs.

well, technically it is k8s checking the pods

true, the kubelet on each node but not sure if that detail adds any value here

But you're right, they're pointing to themselfs.

well, technically it is k8s checking the pods

true, the kubelet on each node but not sure if that detail adds any value here

probably not. I'd leave it out

stateDiagram
    direction LR
    [*] --> FrontDoor: HTTPS
    FrontDoor --> IngressController: HTTPS

    state GlobalServices {
        FrontDoor
        FrontDoor --> Storage: Read Product Images
        CosmosDB
        Storage
    }
    state RegionalStamp {
        AzureKubernetesService
        EventHub
    }
    state AzureKubernetesService {
        direction RL
        IngressController
        IngressController --> CatalogService: HTTP
        CatalogService --> CoreDNS: DNS lookups
    }
    CatalogService --> CosmosDB: Query
    CatalogService --> EventHub: Write
    CatalogService --> Storage: Store Product Images

Closed - will be superseeded in a bit.


bug: protocol.set_rail_lights() is not working from OT2 Jupyter notebook

Overview

protocol.set_rail_lights() is not working from OT2 Jupyter notebook
Steps to reproduce

Create Jupyter network at <ROBOT_IP>:48888
Add the following code:

import opentrons.execute
from time import sleep
protocol = opentrons.execute.get_protocol_api('2.8')

def run(protocol):
    protocol.set_rail_lights(True)
    print(protocol.rail_lights_on)
    sleep(5)
    protocol.set_rail_lights(False)
    print(protocol.rail_lights_on)

run(protocol)

Current behavior
Produced output:
True

after 5 sec:
True

Lights are not turning on and then off.

Expected behavior
Expect lights to turn on and then turn off after 5 sec.

@kasuskasus1  instead of using pause(5), you can use protocol.delay(seconds=5) - this should give you the expected behavior in the meantime

@kasuskasus1  instead of using pause(5), you can use protocol.delay(seconds=5) - this should give you the expected behavior in the meantime

Hi there!
Thank you for your patience on this one.
In appreciation of your patience, I have made a sample protocol that should help you with this task:
Note the OT-2's circuitboard that controls the lights, rail lights, etc. can only take one connection and has to chose between the App and Jupyter Notebook.
That is why we need to run:
import os
os.system("systemctl stop opentrons-robot-server")
in the protocol to make sure that the OT-2 only recognizes the Jupyter Notebook Connection (Theo makes a good point of this here https://github.com/Opentrons/opentrons/issues/6164#issuecomment-666506963 )
My recommendation is to divide the protocol into three cells:

Stoping the robot server so Jupyter Notebook can control lights
controlling lights for a protocol
restarting the server so that you can use the app

Cell One, before you manipulate lights
import opentrons.execute
import os
os.system("systemctl stop opentrons-robot-server")
`
Cell Two Manipulating Lights
import opentrons.execute
import os
protocol = opentrons.execute.get_protocol_api('2.8')
protocol.home()
protocol.set_rail_lights(False)
protocol.set_rail_lights(True)
protocol.comment('light is on')
protocol.delay(seconds = 20)
protocol.set_rail_lights(False)
protocol.comment('light is off')
#resetting the server
for line in protocol.commands():
print(line)
'
##Cell Three Restarting the Server so that the App can connect
os.system("systemctl start opentrons-robot-server")
'
For Reference

Here are some resources to make your own code based on the example above.

Our Jupyter Notebook code is a bit differently organized than our normal def run() protocols so you would have to adjust it.
We also have a resource for how to make Jupyter Notebook work with the rail lights

##Important Note
Unless there is a really compelling reason, I wouldn't normally recommend Jupyter notebook to run protocols. You still have to calibrate through the app before running anything and you see "Out of Bounds Errors" that don't really mean it is out of bounds, it is just closer to a boundary condition (example attached below). If you go to **Advanced Settings > Download Logs ** and it shows up in the API.log and Serial.log than it could point to a bigger problem and you can contact us at<EMAIL_ADDRESS>

Hi there!
Thank you for your patience on this one.
In appreciation of your patience, I have made a sample protocol that should help you with this task:
Note the OT-2's circuitboard that controls the lights, rail lights, etc. can only take one connection and has to chose between the App and Jupyter Notebook.
That is why we need to run:
import os
os.system("systemctl stop opentrons-robot-server")
in the protocol to make sure that the OT-2 only recognizes the Jupyter Notebook Connection (Theo makes a good point of this here https://github.com/Opentrons/opentrons/issues/6164#issuecomment-666506963 )
My recommendation is to divide the protocol into three cells:

Stoping the robot server so Jupyter Notebook can control lights
controlling lights for a protocol
restarting the server so that you can use the app

Cell One, before you manipulate lights
import opentrons.execute
import os
os.system("systemctl stop opentrons-robot-server")
`
Cell Two Manipulating Lights
import opentrons.execute
import os
protocol = opentrons.execute.get_protocol_api('2.8')
protocol.home()
protocol.set_rail_lights(False)
protocol.set_rail_lights(True)
protocol.comment('light is on')
protocol.delay(seconds = 20)
protocol.set_rail_lights(False)
protocol.comment('light is off')
#resetting the server
for line in protocol.commands():
print(line)
'
##Cell Three Restarting the Server so that the App can connect
os.system("systemctl start opentrons-robot-server")
'
For Reference

Here are some resources to make your own code based on the example above.

Our Jupyter Notebook code is a bit differently organized than our normal def run() protocols so you would have to adjust it.
We also have a resource for how to make Jupyter Notebook work with the rail lights

##Important Note
Unless there is a really compelling reason, I wouldn't normally recommend Jupyter notebook to run protocols. You still have to calibrate through the app before running anything and you see "Out of Bounds Errors" that don't really mean it is out of bounds, it is just closer to a boundary condition (example attached below). If you go to **Advanced Settings > Download Logs ** and it shows up in the API.log and Serial.log than it could point to a bigger problem and you can contact us at<EMAIL_ADDRESS>

This is expected behavior if you do not, stop the opentrons-robot-server first. @alexjoel42's solution should work.
Since this is expected behavior and the system prints a warning to stop opentrons-robot-server before trying to interact with the rail lights in Jupyter, I'm going to close this issue. Please feel free to continue posting in this thread with questions!

This is expected behavior if you do not, stop the opentrons-robot-server first. @alexjoel42's solution should work.
Since this is expected behavior and the system prints a warning to stop opentrons-robot-server before trying to interact with the rail lights in Jupyter, I'm going to close this issue. Please feel free to continue posting in this thread with questions!


Collapsing parent comment takes you to top of thread

Any steps for reproduction? Not seeing that on my 6s

No specific steps, but in the picture I circled a comment that is doing this for me.
http://imgur.com/KBM44bh

https://vid.me/gM9Jm
Not sure if it's normal behavior, but here is a screen recording

Should be fixed in Alpha 4


Rename README to README.md

@richsalz Well, no one wants to look at monospace code, do they?

Our README isn't strictly markdown, only heavily inspired.  You might notice these lines:
The OpenSSL toolkit includes:

 libssl (with platform specific naming):
     Provides the client and server-side implementations for SSLv3 and TLS.

 libcrypto (with platform specific naming):
     Provides general cryptographic and X.509 support needed by SSL/TLS but
     not logically part of it.

 openssl:
     A command line tool that can be used for:
        Creation of key parameters
        Creation of X.509 certificates, CSRs and CRLs
        Calculation of message digests
        Encryption and decryption
        SSL/TLS client and server tests
        Handling of S/MIME signed or encrypted mail
        And more...

This is how they render on github:

The OpenSSL toolkit includes:
libssl (with platform specific naming):
Provides the client and server-side implementations for SSLv3 and TLS.
libcrypto (with platform specific naming):
Provides general cryptographic and X.509 support needed by SSL/TLS but
not logically part of it.
openssl:
A command line tool that can be used for:
Creation of key parameters
Creation of X.509 certificates, CSRs and CRLs
Calculation of message digests
Encryption and decryption
SSL/TLS client and server tests
Handling of S/MIME signed or encrypted mail
And more...

With other markdown implementations, line breaks aren't necessarely respected either.
In other words, pure horror.

Would it be acceptable to send a PR that converts it to Markdown as well as preserving the original formatting? (ex. converting the indentations to bullet points)

No.  I agree with @richsalz on this one.


TouchEffect doesnt work in UWP? How to use LongPressCommandParameter?

Discussed in https://github.com/xamarin/XamarinCommunityToolkit/discussions/1454

Originally posted by TuxCZ July  1, 2021
Hello,
I have problem with a touch effect. It works perfectly in the Android APP, but in UWP doesnt.
My UWP target version is Windows 10, 2004 (Build 19041) and Min version 1803, build 17134...
I tried this fix:
 var assembliesToInclude = new List<Assembly>()
                {
                    typeof(Xamarin.CommunityToolkit.Effects.TouchEffect).GetTypeInfo().Assembly
                };
                Xamarin.Forms.Forms.Init(e, assembliesToInclude);

but it doesnt helped me. I changed ,,Compile with .NET Native tool chain" but it doesnt helped too.. I tried to compile UWP with different target and min versions, but it doesnt work...
My second question is how to use LongPressCommandParameter? I have entry defined like this:
 <Entry x:Name="txtProjectName" Text="{Binding Project.Name}" Style="{StaticResource EntrySecondaryStyle}"                                xct:TouchEffect.LongPressCommand="{Binding LongPressCommand}"                                xct:TouchEffect.LongPressCommandParameter="{Binding .}"                                xct:TouchEffect.LongPressDuration="1500"/>
And I need to get LongPressCommandParameter (sender) in the code... How can I do that?

@pictos @jfversluis hey friends, could you please check this issue with UWP versions?
How should users work around it?
Does TouchEffect still work on UWP in main? (I think it should)

@TuxCZ you can try to install the nightly version of XCT (it contains all the latest changes)
https://github.com/xamarin/XamarinCommunityToolkit/blob/main/README.md#installation

@TuxCZ you can try to install the nightly version of XCT (it contains all the latest changes)
https://github.com/xamarin/XamarinCommunityToolkit/blob/main/README.md#installation

Ok, I will try it... But i must figure out how to install nightly version...

source: https://pkgs.dev.azure.com/xamarin/public/_packaging/XamarinCommunityToolkitNightly/nuget/v3/index.json
https://docs.microsoft.com/en-us/azure/devops/artifacts/nuget/consume?view=azure-devops&tabs=windows#2-set-up-visual-studio

source: https://pkgs.dev.azure.com/xamarin/public/_packaging/XamarinCommunityToolkitNightly/nuget/v3/index.json
https://docs.microsoft.com/en-us/azure/devops/artifacts/nuget/consume?view=azure-devops&tabs=windows#2-set-up-visual-studio

Thx for the link... I tried it, I installed preview 1072, but it doesn´t helped...

@pictos could you please check it?

@AndreiMisiukevich just saw it right now, sure I'll test by tomorrow and let you know

@AndreiMisiukevich LongPress is working on our sample in main branch

@TuxCZ can you please provide a sample?

@TuxCZ can you please provide a sample?

I created sample APP...
https://file.io/ii79QBsL34sz

@TuxCZ

Can you upload a zip archive here?

UWPSample.zip

@pictos could you please check provided sample on UWP?
Thanks

@AndreiMisiukevich @TuxCZ I was able to make the sample work

The issue is related to the UWP target version. You need to have your version configuration like this to make it work

@TuxCZ we're working harder to put this fix on the next stable release (1.3)

Thx, it works for me now on boxview too, but if u change boxview to entry or different component it stopped working...

@TuxCZ so it doesn't work if you use ContentView or StackLayout?

@TuxCZ so it doesn't work if you use ContentView or StackLayout?

This works if I set target and max version how u said:
<BoxView WidthRequest="100" HeightRequest="100" Text="Test"
                 xct:TouchEffect.LongPressCommand="{Binding LongPressCommand}"
                 xct:TouchEffect.LongPressCommandParameter="{Binding .}"
                 xct:TouchEffect.LongPressDuration="1500"/>

but this doesnt work in UWP, only in android project:
<Entry WidthRequest="100" HeightRequest="100" Text="Test"
                 xct:TouchEffect.LongPressCommand="{Binding LongPressCommand}"
                 xct:TouchEffect.LongPressCommandParameter="{Binding .}"
                 xct:TouchEffect.LongPressDuration="1500"/>

@TuxCZ yeah, it can be an issue that Long Press is not working with entry on UWP, but you mentioned that  if u change boxview to entry or different component it stopped working
So, doesn't it work only with Entry or with all other views except BoxView? Does it work well with ContentView, StackLayout, Label etc.

@TuxCZ yeah, it can be an issue that Long Press is not working with entry on UWP, but you mentioned that  if u change boxview to entry or different component it stopped working
So, doesn't it work only with Entry or with all other views except BoxView? Does it work well with ContentView, StackLayout, Label etc.

I tested other controls and all works except entry and the editor...

@TuxCZ feel free to open a different issue (but I am not sure we will be able to fix it soon)


code coverage with expand_assets=false

Hi,
we're trying to get code coverage via istanbul working with expand_assets=false. We're getting the following error message (coverage object is null, when using expand_assets=true, coverage object is defined):
$ bundle exec rake teaspoon

** Invoke teaspoon (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute teaspoon
Starting the Teaspoon server...
Teaspoon running default suite at http://<IP_ADDRESS>:63634/teaspoon/default
..

Finished in 2.28000 seconds
2 examples, 0 failures

Unable to generate text-summary coverage report:
/usr/local/lib/node_modules/istanbul/lib/collector.js:69
        Object.keys(coverage).forEach(function (key) {
               ^

TypeError: Cannot convert undefined or null to object
    at Function.keys (native)
    at Object.Collector.add (/usr/local/lib/node_modules/istanbul/lib/collector.js:69:16)
    at /usr/local/lib/node_modules/istanbul/lib/command/report.js:111:27
    at Array.forEach (native)
    at /usr/local/lib/node_modules/istanbul/lib/command/report.js:109:19
    at /usr/local/lib/node_modules/istanbul/lib/util/file-matcher.js:39:20
    at Object.next (/usr/local/lib/node_modules/istanbul/node_modules/fileset/lib/fileset.js:43:14)
    at emitOne (events.js:77:13)
    at Fileset.emit (events.js:169:7)
    at Fileset.Glob._finish (/usr/local/lib/node_modules/istanbul/node_modules/fileset/node_modules/glob/glob.js:172:8)

versions:
$ teaspoon --version
1.1.1

$ ruby -v
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]

teaspoon_env:
Teaspoon.configure do |config|
  config.mount_at = "/teaspoon"
  config.root = nil
  config.asset_paths = ["spec/javascripts", "spec/javascripts/stylesheets"]
  config.fixture_paths = ["spec/javascripts/fixtures"]

  config.suite do |suite|
    suite.use_framework :jasmine, "2.3.4"
    suite.matcher = "{spec/javascripts/desktop}/**/*_spec.{js,js.coffee,coffee,js.erb}"
    suite.helper = "spec_helper_desktop"
    suite.boot_partial = "boot"
    suite.body_partial = "body"
    suite.expand_assets = false
  end

  config.suite :mobile do |suite|
    suite.matcher = "{spec/javascripts/mobile}/**/*_spec.{js,js.coffee,coffee,js.erb}"
    suite.helper = "spec_helper_mobile"
  end

  config.use_coverage = true

  config.coverage do |coverage|
    coverage.reports = ["text-summary", 'html']
    coverage.ignore = [%r{.rvm}, %r{/lib/ruby/gems/}, %r{/vendor/assets/}, %r{/support/}, %r{/(.+)_helper.}, %r{/app/assets/javascripts/(.+)/vendor}, %r{/app/assets/javascripts/(.+)/vendor}, %r{/vendor/bundle}, %r{/spec/javascripts}]
    coverage.ignore = coverage.ignore.reject { |matcher| matcher.match('/spec_helper*.') }
  end
end

spec/javascripts/spec_helper_desktop.js
// Teaspoon includes some support files, but you can use anything from your own support path too.
// require support/jasmine-jquery-1.7.0
// require support/jasmine-jquery-2.0.0
// require support/jasmine-jquery-2.1.0
// require support/sinon
//
// PhantomJS (Teaspoons default driver) doesn't have support for Function.prototype.bind, which has caused confusion.
// Use this polyfill to avoid the confusion.
//= require support/phantomjs-shims
//= require support/factories
//= require support/promise
//= require desktop/application
//

spec/javascripts/spec_helper_mobile.js
// Teaspoon includes some support files, but you can use anything from your own support path too.
// require support/jasmine-jquery-1.7.0
// require support/jasmine-jquery-2.0.0
// require support/jasmine-jquery-2.1.0
// require support/sinon
//
// PhantomJS (Teaspoons default driver) doesn't have support for Function.prototype.bind, which has caused confusion.
// Use this polyfill to avoid the confusion.
//= require support/phantomjs-shims
//= require support/factories
//= require support/promise
//= require mobile/application
//

example spec: spec/javascripts/desktop/link_spec.js
describe('Link', function() {
    'use strict';
    it('should be available in global namespace', function() {
        expect(Link).toBeDefined();
    });
});

Is there an error within our config or is this an issue?

Thank you for the excellent bug report. If you point your Gemfile at master, you should see a more friendly error message. The error you're seeing indicates the results could not be found because no files had been covered. In your case, they couldn't be found because you have /spec/javascripts in your ignore list and your helper is at .../spec/javascripts/spec_helper_desktop.js.


Change Title

Can we change the title? I want to remove the Error, Success Title message and put a custom title over there.

Closing this as no response from @iasonasiasonos


Duplicated chat messages in discord when players chat in game

Hello, great bot! Loving it so far. Only issue I am receiving is that when players chat in game it is duplicating their messages in the discord. Is it possible it could have something to do with their prefixes? Because we have colors and prefixes setup for when players hit certain milestones or are part of the admin team. So anybody with a prefix or color in their name the chat gets handled by the ServerTools mod. I know you said support for mods that do anything with chat is not supported. Just curious if there is something I could do on my end here. When a player runs a command that begins with a "/" it is not duplicating the message in discord even if that player has a color and prefix.

Hello! Sorry to hear you're having issues. Most likely yes, the mods are the cause here and a code modification would be needed to fully fix it.
For the prefixes, the bot detects and automatically filters out messages that it detects starting with a "/". It sounds like what's happening here is the bot filters out the message as it normally would - but then the duplicate still comes through, looking like a normal message.
One thing you can try is playing with the following config options: disable-chatmsgs, disable-join-leave-gmsgs, disable-misc-gmsgs, disable-non-player-gmsgs, and show-private-chat. I can't say for sure what combination will work (if any) as that depends on how the mod is doing things.
If the mod is re-sending chat as a different type of message, maybe something like turning on disable-chatmsgs will do it. Alternatively, setting disable-misc-gmsgs, disable-non-player-chatmsgs to true, and setting disable-chatmsgs to false. Beware these are only wild guesses, but it might be worth a shot.
If you try the above and it works, please let me know so we can help anyone else that has the same problem!
One other thing you can try is making sure you don't have duplicates of the bot running. The bot has auto-detection and if you enable allow-multiple-instances, or something else goes wrong, you can have the same bot sending multiple messages. A telltale sign of this is if even the "help" command shows up twice. If this is the case, the quickest fix is to restart the system the bot is running on - then, start the bot once and try again.
From a technical side, fixing mod conflicts would look something like this:

Enable log-telnet in Dishorde's config, either on your copy or a secondary copy made specifically for testing.
a. Alternatively, connect to your 7 Days to Die server with a telnet client. You'd need to research this a bit, as there are a number of ways to do this. Windows 10 has one built-in that can be enabled by typing "Turn Windows features on or off" in the Windows search bar, and then accessed via command prompt.
Examine the logs and see how chat messages are being logged. My guess is that the mod is adding additional logs of a message to the game's console, causing them to show up multiple times. This is only a guess and it could be something completely different.
a. Beware that mods have also been found to introduce other trickery, like different line endings or other encoding quirks that can confuse the bot. This can show up in ways like the bot thinking one line of data from the console is actually two, or cramming two lines into one.
Compare these logs to the way the bot interprets them, and optionally the way a default 7 Days to Die outputs them (e.g. repeat steps 1-3 with a vanilla 7 Days to Die server). You can see parts of the code used for interpreting messages at index.js/handleMsgFromGame. A lot of this handling uses Regular Expressions. Sites like Regexr are handy in testing these out.
Program a fix! This depends on whatever is found in the above steps. In the case of color coding, if my suspicion of the duplicated messages is correct, this is probably something an extra filter can be created for. However, it gets complicated fast when you consider multiple mods, different mods doing different things, vanilla doing its own thing, etc etc. Depending on the situation, some mods might have to be either manually detected (e.g. you have to set a config option saying "we have mod X installed") or manually toggled (e.g. the bot looks for a telltale sign of a particular mod being added and, when it does, apply a special regex filter based on this).

Dishorde is a bit of a 'mod-less' solution as-is, being a tool that works with the game without touching the files. At this time, all of this would be a bit too much of a time sink for me. So, for the foreseeable future, I still advise that mods will not be supported.
If you or anyone else opens a pull request with a solution, I'll be happy to look it over. Feel free to reach out if you have any other questions!


FileSystemWatcher does not detect changes

FileSystemWatcher in ASP.NET Core 2.1 does not detect changes in files in a folder created as a junction from another folder.

Hey @AlexBAV ,
FileSystemWatcher was implemented using ReadDirectoryChangesW and apparently it does not manage junctions/reparse points.
Junction and reparse are handled by the change journals on Volume management.
For more clarification on how to do it, check this: Obtaining a Volume Handle for Change Journal Operations


Expose Command Error Metrics via the CommandLatencyMetrics

Feature Request

Is your feature request related to a problem? Please describe
N/A
Describe the solution you'd like
Would it be possible to expose the error count metrics in the Command Latency Metrics.
Describe alternatives you've considered
Alternative would be for the caller of the client to collect the error count while handling the exceptions thrown by the client.
Teachability, Documentation, Adoption, Migration Strategy
N/A

Stats about failed commands aren't collected. When it gets into errors, then, what exactly qualifies as error? There are various categories such as I/O (transmission failure), enqueueing failures (command queue is full), and Redis responses indicating an error.
We collect right now latencies after the command response got decoded.

Well granted those categories are broad, how would you recommend for a centralized configuration of Lettuce garnering them.

By which I mean, we'd love to make automatic metrics for our Lettuce users. latency, connection events are easy. command errors is currently left to the service owner, with predictable results. There are of course things like proxies (java, extrinsic) we could do, but it would be nice to have these simply emitted in some form. What is your recommendation for this @mp911de ?

Right now, the Tracing API receives callbacks regarding successful/failed commands propagating Redis error responses.
Have you tried forking the lib and playing around with real use-cases to get hold of these metrics? Probably, if we reduce the problem statement to just Redis error responses, we might come up with a simplified variant.

Thanks, I will play around with the library.
How about grouping errors by categories:

Number of IO/connection errors
Number of errors from Redis (i.e. ERR xxxx responses from Redis)
Number of errors in client processing
... etc

Connection errors can happen without having an active command. Upon a disconnect, we auto-reconnect: Does this count as error for a command that was sent to Redis or not?
Errors in client processing are not propagated to the command as downstream errors are invisible to commands.

I think we should close this unless we have a better idea of the problem we would like to solve.
Please reopen if you think we should reconsider and provide a good example of how this feature would be used.


Tests for db and strategy workers

These tests will fail for PY3 right now since the workers haven't been yet ported.

Overall, looks good!

Current coverage is 64.88% (diff: 100%)

Merging #182 into master will increase coverage by 10.32%

@@             master       #182   diff @@
==========================================
  Files            70         70
  Lines          4425       4425
  Methods           0          0
  Messages          0          0
  Branches        522        522
==========================================
+ Hits           2414       2871   +457
+ Misses         1907       1426   -481
- Partials        104        128    +24

Powered by Codecov. Last update 3637a27...d90af7e


Use the generic GetPointer instead of a typed GetPointer*

After generics were added to go, we added generic GetPointer https://github.com/nginxinc/nginx-kubernetes-gateway/blob/7662c2118927b12c7eacf60ca720fce087ac9e55/internal/helpers/helpers.go#L65 and started using it instead of typed GetPointer* functions. However, we didn't update the existing code.
Acceptance criteria:

Use the generic GetPointer instead of a concrete GetPointer*

Should we remove the now unused typed GetPointer* functions from the codebase?

Should we remove the now unused typed GetPointer* functions from the codebase?

Yep!


Make it easier to create cli arguments

Currently, we need to know the syntax of ffmpeg cli arguments. For example, if we want to trim the start of an input, we need to create an argument with the following code:
CliArg(name: 'ss', value: myValueInSeconds);

Ideally, users of this package shouldn't need to know the exact syntax of a cli argument. We should abstract the underlying syntax by providing objects for the arguments. For example, for trimming the start of an input the user should be able to write a code like the following:
TrimStart(const Duration(seconds: 5));

If we want to improve the discoverability of the arguments we could use factory methods like the following:
CliArgs.trimStart(const Duration(seconds: 5));

Using factory methods the users would be able to discover the arguments by using the IDE code completion.

cc @matthew-carroll


PathMarkupParser crashes with InvalidDataException: 'Invalid bool rule.'

Describe the bug
PathMarkupParser crashing
To Reproduce
Steps to reproduce the behavior:
In a new project, use the following XAML:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
        mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
        x:Class="AvaloniaApplication1.MainWindow"
        Title="AvaloniaApplication1">
  <Button>
    <PathIcon Data="M17.432 11.619c.<IP_ADDRESS>.04.247V26.54c0 .37-.271.552-.605.409l-5.339-2.282c-.336-.144-.604-.558-.604-.926V9.066c0-.368.27-.551.604-.409l5.339 2.283a.898.898 0 01.27.188c.<IP_ADDRESS>3.295.49M9.615 9.07v14.675c0 .368-.27.782-.605.925l-5.339 2.282c-.334.143-.604-.04-.604-.408V11.868c0-.368.269-.782.604-.926l5.34-2.282c.333-.143.604.04.604.41m15.713 4.173V23.74c0 .368-.27.782-.605.926l-5.338 2.282c-.334.143-.604-.04-.604-.41V13.216c1.015 1.231 2.702 3.615 3.136 6.3h.312c.43-2.665 2.087-5.033 3.099-6.272m-3.217-2.39c-2.065 0-3.738-1.705-3.738-3.808 0-2.102 1.673-3.807 3.738-3.807 2.064 0 3.738 1.705 3.738 3.807 0 2.103-1.674 3.808-3.738 3.808M22.054 2c-2.768 0-5.012 2.286-5.012 5.105 0 1.378.531 2.693 1.401 3.611 0 0 2.928 2.912 3.488 6.389h.279c.56-3.477 3.471-6.389 3.471-6.389.873-.918 1.386-2.232 1.386-3.61 0-2.82-2.245-5.106-5.013-5.106"
      VerticalAlignment="Center" />
  </Button>
</Window>

Expected behavior
Icon similar to:

Desktop (please complete the following information):

OS: [e.g. Windows, Mac, Linux (State distribution)]
Version [e.g. 0.10.0-rc1 or 0.9.12]

Additional context
Frameworks like UWP and WPF handles this correctly.

There is no F fill-rule command in the path data so the exception is a bit weird. Will have a look shortly.

So the a (elliptical arc) command has a missing boolean flag. Not entirely sure whether this is allowed or not

@Gillibald It works on HTML, WPF, and UWP. So I assume it should be allowed?

The failing part is this sequence: a.898.898 0 01.27.188 my guess is that 01 isn't parsed as 0. So the resulting sequence should be a .898 .898 0 0 1.27 .188

@Gillibald So I guess the fix is to modify ReadBool implementation to the following?
		private bool ReadBool(ref ReadOnlySpan<char> span)
		{
			span = SkipWhitespace(span);
			if (span.IsEmpty)
			{
				throw new InvalidDataException("Cannot read bool from empty span.");
			}

			var c = span[0];
			span = span.Slice(1);

			switch (c)
			{
				case '0':
					return false;
				case '1':
					return true;
				default:
					throw new InvalidDataException("Invalid bool rule");
			}
		}

Y if my theory is correct that is the right fix. Read just one character. If the character is not a number throw. For a 0 the result is false for non zero the result is true. Negative signs are ignored. I think the that is how the spec defines the flag parsing.

for non zero the result is true

Isn't it supposed to be "just" "1"?

"M 10 10 a 1 1 0 01 .27 .188z"

The above works in WPF, but the following doesn't:

"M 10 10 a 1 1 0 02 .27 .188z"

So 2 wasn't considered true.
Same for negative signs, they doesn't seem to be ignored.

Y it looks like flags are more strict flag::=("0"|"1")


IndexError: list index out of range

Exception in Tkinter callback
Traceback (most recent call last):
File "/Users/haochile/opt/miniconda3/envs/invoicenet/lib/python3.8/tkinter/init.py", line 1892, in call
return self.func(*args)
File "/Users/haochile/Documents/pythonProject1/InvoiceNet/invoicenet/gui/trainer.py", line 393, in _prepare_data
ngrams = util.create_ngrams(page, height=height, width=width)
File "/Users/haochile/Documents/pythonProject1/InvoiceNet/invoicenet/common/util.py", line 195, in create_ngrams
lines = divide_into_lines(words, height=img.size[1], width=img.size[0])
File "/Users/haochile/Documents/pythonProject1/InvoiceNet/invoicenet/common/util.py", line 172, in divide_into_lines
cur = words[1]
IndexError: list index out of range
I am so grateful that you @naiveHobo created this project. I'm really excited and interested in it. If successful (I mean I can run it) it will help my work so much.
I'm getting this error now, can anyone help me fix it? Thank you

I'm still fixing it, but it's nohope

Related to #15


Question: Consul on clustered docker environment

Hello,
I'm fairly new to Consul (2nd day of POC) and hoping someone could shed light on how Consul would look like in a clustered docker environment. Would Consul need to be installed on every node in the cluster? Would there be a Consul leader that services would look to for connection settings? With the use of a service discovery registering tool like Registrator, could we instead distribute Registrator to the nodes to then point to Consul?
Thank you in advance.

In the production environment you must have 3 consul server to form a cluster.  These consul server containers can be schedule on any node.
In the cluster running Swarm there is no mechanism to know how containers will be schedule on the different node. How ever docker swarm internally uses LibKV  for service discovery to store these information but these information are not available to user. So we must use external Service discovery tool like consul,etcd,zookeeper ect. These tool are used as  service registry by the service registrator. when ever new container is created Registrator inspect that container using linux socket (docker.sock) and register the information like ip address , port etc in the service registry and these information are replicated on each consul server by the leader.
We have cluster  of node forming swarm cluster and inside swarm cluster  we choose three or five node forming another cluster for the consul server.
The outer Swarm cluster and inner consul cluster both uses the RAFT consensus algorithm to select the leader. According to RAFT consensus  algorithm there must be odd number of nodes >=3 to form a cluster.
You can setup your Registrator in two ways

If Registrator needs to run on a separate machine rather than where the Consul container is running then we need to do the following
//IP of node where consul server is running
export CONSUL_IP=// ip of any node where consul server is running
export HOSTNAME= //name of host name where registrator  is running

docker run -d -v /var/run/docker.sock:/tmp/docker.sock --name registrator -h $HOSTNAME  gliderlabs/registrator:latest consul://$CONSUL_IP:8500
2)If Registrator is on the same machine as where the Consul container is, then we need to do the following:
docker run -d -v /var/run/docker.sock:/tmp/docker.sock --name registrator -h $HOSTNAME  gliderlabs/registrator:latest consul://$HOST_IP:8500
in the both method we are mounting the docker.sock to the registrator container. It is basically a linux socker which is used by docker daemon for listening the eventd fired from the docker client (CLI) eg docker run, start ,stop etc.


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2021-11-15T19:56:54+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster-tests_istio_release-1.12
e621765d4d2e803ab33235f925540813271c07e9
link
true
/test integ-security-multicluster-tests_istio_release-1.12

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio_release-1.12


Declare character set of UTF-8

I think it belongs here @neauoire, because the browser looks for this value at parse time (which makes injection via JavaScript, as utilized for stylesheets in Rotonde/client, unfeasible).
See Rotonde/beaker#69

It does :)

Thanks again, @neauoire!


First pass at ASP.NET Core Logging

This change also has a few changes to Google.Cloud.Diagnostics.Common which are in review in PR #638

@jskeet  PTAL.  It looks like I needed to update the global.json file (1b249ed1da44fe9de8ca2c5cbacf9c525c0b6fd8).  While I think this is the right solution given (https://docs.microsoft.com/hu-hu/dotnet/articles/core/tools/global-json) a double check would be appreciated.

global.json change looks fine - I haven't looked at the rest yet.


Hide one of many

Hi, I have a problem hidding a selectpicker of many.
Example:
I have 3 selects with class="selectpicker", and differents ids (1, 2 and 3).
I initialized like the following way:
$('.selectpicker').selectpicker();
And I'm trying to hide the selectpicker with id=2, like this:
$('.selectpicker#2').selectpicker('hide');
But, doesn't work.
Is there any way to do?
Thanks!

See guidelines for contributing.

Bug reports
A bug is a demonstrable problem that is caused by the code in the repository.
Good bug reports are extremely helpful - thank you!
Guidelines for bug reports:

Use the GitHub issue search. Check if the issue has already been reported.

Check if the issue has been fixed. Try to reproduce it using the latest master or development branch in the repository.

Provide environment details. Provide your operating system, browser(s), jQuery version, Bootstrap version, and bootstrap-select version.

Create an isolated and reproducible test case. Create a reduced test case.

Include a live example. Make use of jsFiddle or jsBin to share your isolated test cases.

Closing due to inactivity.


avoid regex 'parsing' format strings every time

bpftrace::format spends about 60% of its time in the regex_iterator we
use to split the string.
The FormatString type avoids this by splitting the string on first use
and storing the result for re-use.
I've kept the code mostly as is, just moving and minor modifications.
The whole output code can do with a refactoring but this should be a
nice performance gain.
Test case is running opensnoop.bt while running find / in another
terminal:
original: bpftrace::perf_event_printer spent 75% of the time in format
new: bpftrace::perf_event_printer spent 15% of the time in format
Checklist

[ ] Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
[ ] User-visible and non-trivial changes updated in CHANGELOG.md
[ ] The new behaviour is covered by tests

before:

after:


Dropdown selectors for template variables

It should be possible (e.g. in JSON) to specify expressions that would populate a drop-down selector for a given variable. For example:
I have a dashboard that is parametrised by var.job=web-prod, var.job=web-alpha etc. I have no way for users to discover this,and when they go to a dashboard, they see empty graphs.
Nor is there an easy way to switch between all job names. The job names are already in prometheus data (just list job labels of up{}).
It would be great if JSON allowed me to specify a drop down for this. This would make template variables easily discoverable and give users the ability to see what they can filter by.

We're in dire need of this, and consider implementing hacks to have it.
@juliusv Are you guys thinking about adding selectors for template variables anytime soon?

Do you currently have anything in place? You can open a pull request and we will take a look at it

No, we're considering investing time in this, but given that we have little experience with Ruby, it'll probably take a while ;)

it would probably be almost entirely javascript, but i'll talk with @juliusv to see what he thinks about it

Any ideas? If you guys don't have the time to implement this, some code pointers as to where to start would be much appreciated :)

variables are added here:
https://github.com/prometheus/promdash/blob/c6523a0a446bcfdf770a0d59f8d8125b0f6b123e/app/assets/javascripts/angular/resources/shared_graph_behavior.js#L145-L147
and that code is executed by clicking here:
https://github.com/prometheus/promdash/blob/c6523a0a446bcfdf770a0d59f8d8125b0f6b123e/app/views/dashboards/show.html.erb#L232
your template variables are stored on the globalConfig object. When the dashboard loads, url variables are appended to this object, and then these are copied to the vars object array.
https://github.com/prometheus/promdash/blob/c6523a0a446bcfdf770a0d59f8d8125b0f6b123e/app/assets/javascripts/angular/resources/shared_graph_behavior.js#L22-L33
that array is what gets rendered on the page:
https://github.com/prometheus/promdash/blob/c6523a0a446bcfdf770a0d59f8d8125b0f6b123e/app/views/dashboards/show.html.erb#L218-L236

Hey, I'd just caution against adding fields to the JSON which are not reflected in the GUI. So far the JSON has simply been an internal representation of the settings that you can edit via the GUI. But the JSON is more of an implementation detail. It'd also be great in general to have a UI for this, but that always requires careful thought to not clutter the UI completely for users who don't use that feature. Would love to see some UI sketches for this...

Will come with #378, but first we need to finish #180.


chore(main): release faro-shop 0.38.0

:robot: I have created a release beep boop
0.38.0 (2024-08-14)
Features

Bump app to 0.37.7 (#692) (7ab7f61)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

faro-shop-0.38.0
:sunflower:


fix: Python dependencies in #11499

SUMMARY
This PR fixes https://github.com/apache/incubator-superset/pull/11499 which requires Redis to be a core Python dependency for the AsyncQueryManager Flask extension.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN
CI. Note the dependencies were updated via pip-compile-multi --no-upgrade.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

pip-compile-multi --no-upgrade -- oh, so that's how you add a dependency without upgrading every other one!

Codecov Report

Merging #12079 (02647df) into master (148a001) will decrease coverage by 2.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12079      +/-   ##
==========================================
- Coverage   65.96%   63.65%   -2.32%
==========================================
  Files         959      476     -483
  Lines       47160    29371   -17789
  Branches     4613        0    -4613
==========================================
- Hits        31111    18697   -12414
+ Misses      15898    10674    -5224
+ Partials      151        0     -151

Flag
Coverage Δ

cypress
?

javascript
?

python
63.65% <ø> (-0.66%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.56% <0.00%> (-2.44%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

... and 495 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148a001...02647df. Read the comment docs.


Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
Windows 10 64 bit
What version of the game are you using? Look in the bottom left corner of the main menu.
0.1.0B
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.

Please describe your issue. Provide extensive detail and images if possible.
If you check the compilation errors on my fork of this repo is shows that flixel crap is broken

Meanwhile I was fully able to compile it myself, so I updated each one of these and now I can no longer compile the repo. This might cause a big issue until it's resolved

@EyeDaleHim Yo everything was updated, it seems everything is working now. (on Haxe 4.3.2)

Just make sure to update flixel animate to git


Internal Server Error

On this URL http://linter.structured-data.org/?url=https:%2F%2Fscholarsphere.psu.edu%2Ffiles%2F6395w812z

Warning message could be better; uncheck the “Verify SSL” box.
Gregg Kellogg
<EMAIL_ADDRESS>
On Sep 21, 2015, at 3:09 PM, Justin Coyne<EMAIL_ADDRESS>wrote:
On this URL http://linter.structured-data.org/?url=https:%2F%2Fscholarsphere.psu.edu%2Ffiles%2F6395w812z http://linter.structured-data.org/?url=https:%2F%2Fscholarsphere.psu.edu%2Ffiles%2F6395w812z
—
Reply to this email directly or view it on GitHub https://github.com/structured-data/linter/issues/30.