No connection to local databases

I have PostgreSQL and Clickhouse databases running on a server.  Both are accessible via DBeaver or via http
But when I try to make a connection in Datalens, connection attempt fails, with the error like this(for clickhouse):
Data source refused connection. ERR.DS_API.DB.SOURCE_CONNECT_ERROR {     "data": {         "details": {             "db_message": "HTTPSConnectionPool(host='<IP_ADDRESS>', port=8123): Max retries exceeded with url: /?query_id=e7c0bdde-b9f7-11ee-bdd0-0242ac120006&database=system&join_use_nulls=1&distributed_ddl_task_timeout=280&send_progress_in_http_headers=0&output_format_json_quote_denormals=1 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f43f6287130>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=1.0)'))"         },         "message": "Data source refused connection.",         "debug": {             "db_message": "HTTPSConnectionPool(host='<IP_ADDRESS>', port=8123): Max retries exceeded with url: /?query_id=e7c0bdde-b9f7-11ee-bdd0-0242ac120006&database=system&join_use_nulls=1&distributed_ddl_task_timeout=280&send_progress_in_http_headers=0&output_format_json_quote_denormals=1 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x7f43f6287130>, 'Connection to <IP_ADDRESS> timed out. (connect timeout=1.0)'))",             "query": "select 1"         },         "code": "ERR.DS_API.DB.SOURCE_CONNECT_ERROR"     } }
The same problem appears while running Datalens container on the server or on the other machine in network.
Could you please tell me, what may be the issue?

Hi! connect timeout=1.0 means DataLens cannot connect to your PostgreSQL/ClickHouse. This can be caused by a multitude of reasons, for example, if your DB is not reachable from your docker container.
You can check it by connecting to the data-api container using docker exec -it <container id> bash and querying the DB from it (for example, with ClickHouse's http interface ).
If that is not the case, please let us know where your DBs are deployed (e.g. locally on the same host as DataLens or on another remote one) and how do you connect to them via dbeaver/http

Feel free to reopen the issue with additional information if this problem is still relevant.


GeometryReader messes up the position of elements

There is an issue in the library which messes up the position of used views.
Here is a simple example:
import SwiftUI
struct ContentView: View {

    @State private var makeCircleBigger = false

    var body: some View {
        ZStack {
            Color.white.edgesIgnoringSafeArea(.all)

            ACircle(makeCircleBigger: $makeCircleBigger)
        }.onTapGesture {
            makeCircleBigger.toggle()
        }
    }
}

fileprivate struct ACircle: View {
    @Binding var makeCircleBigger : Bool

    var body: some View {
        let circleSize = makeCircleBigger ? 800 : 200

        Circle()
            .foregroundColor(.pink)
            .frame(width: CGFloat(circleSize), height: CGFloat(circleSize))
    }
}

#Preview{
    ContentView()
        //.implementPopupView()
}

Steps to reproduce:

Click on the circle

In the preview the last line is commented out to show
the expected behavior:

The circle gets bigger AND
is CENTERED

The actual behavior is:
The last line in preview has to be enabled (commented in)

The circle get bigger BUT
is off-center

fixed in the branch patch-2.5.1


Issue with docs.zowe.org/stable/getting-started/release-notes/release-notes-overview

Description

Pages to Update

Screenshots

Expected behavior

Additional context

Hi @SUNDONEcindy, can you please provide some additional information regarding the issue you're seeing in this page?


TravisBuddy Integration

test

Travis tests have failed
Hey Travis Buddy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
npm test
><EMAIL_ADDRESS>test /home/travis/build/bluzi/travis-buddy
> mocha

  GET /status
    ✓ should be running and return HTTP status 200

  GET /test
18:26:46.644Z  INFO unknown : Testing job '295503460' (node_js)
18:26:47.003Z  INFO unknown : Done found after 0/10 attempts.
    ✓ should return HTTP status 200 (372ms)

  POST /
18:26:47.025Z  INFO unknown : Handling request for 'create sdfdsfsd' by 'Eliran Pe'er'
18:26:47.252Z  INFO unknown : Done found after 0/10 attempts.
18:26:47.255Z ERROR unknown :
    Error in handler { params: {},
      owner: 'bluzi',
      repo: 'name-db',
      pullRequest: 32,
      pullRequestTitle: 'create sdfdsfsd',
      buildNumber: 295066345,
      jobs: [ 295066347 ],
      author: 'Eliran Pe\'er',
      state: 'failed',
      branch: 'bluzi-patch-3',
      travisType: 'push',
      language: 'node_js',
      scripts: undefined }
18:26:47.255Z ERROR unknown :
    Error: Invalid GitHub access token null { params: {},
      owner: 'bluzi',
      repo: 'name-db',
      pullRequest: 32,
      pullRequestTitle: 'create sdfdsfsd',
      buildNumber: 295066345,
      jobs: [ 295066347 ],
      author: 'Eliran Pe\'er',
      state: 'failed',
      branch: 'bluzi-patch-3',
      travisType: 'push',
      language: 'node_js',
      scripts: undefined }
    1) should return HTTP status 200 and ok message

  GET /
    ✓ should return HTML and status 200

  GET /getting-started
    ✓ should return HTML and status 200

  GET /contact-us
    ✓ should return HTML and status 200

  GET /dashboard
    ✓ should return HTML and status 200

  6 passing (689ms)
  1 failing

  1) POST /
       should return HTTP status 200 and ok message:
     Error: expected 200 "OK", got 500 "Internal Server Error"
      at Test._assertStatus (node_modules/supertest/lib/test.js:266:12)
      at Test._assertFunction (node_modules/supertest/lib/test.js:281:11)
      at Test.assert (node_modules/supertest/lib/test.js:171:18)
      at Server.assert (node_modules/supertest/lib/test.js:131:12)
      at emitCloseNT (net.js:1655:8)
      at _combinedTickCallback (internal/process/next_tick.js:135:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

npm ERR! Test failed.  See above for more details.

npm run lint
><EMAIL_ADDRESS>lint /home/travis/build/bluzi/travis-buddy
> eslint .

Travis tests have failed
Hey Travis Buddy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
npm test
><EMAIL_ADDRESS>test /home/travis/build/bluzi/travis-buddy
> mocha

  GET /status
    ✓ should be running and return HTTP status 200 (40ms)

  GET /test
18:31:11.859Z  INFO unknown : Testing job '295503460' (node_js)
18:31:12.130Z  INFO unknown : Done found after 0/10 attempts.
    ✓ should return HTTP status 200 (282ms)

  POST /
18:31:12.149Z  INFO unknown : Handling request for 'create sdfdsfsd' by 'Eliran Pe'er'
18:31:13.069Z  INFO unknown : Done found after 0/10 attempts.
18:31:13.072Z ERROR unknown :
    Error in handler { params: {},
      owner: 'bluzi',
      repo: 'name-db',
      pullRequest: 32,
      pullRequestTitle: 'create sdfdsfsd',
      buildNumber: 295066345,
      jobs: [ 295066347 ],
      author: 'Eliran Pe\'er',
      state: 'failed',
      branch: 'bluzi-patch-3',
      travisType: 'push',
      language: 'node_js',
      scripts: undefined }
18:31:13.073Z ERROR unknown :
    Error: Invalid GitHub access token null { params: {},
      owner: 'bluzi',
      repo: 'name-db',
      pullRequest: 32,
      pullRequestTitle: 'create sdfdsfsd',
      buildNumber: 295066345,
      jobs: [ 295066347 ],
      author: 'Eliran Pe\'er',
      state: 'failed',
      branch: 'bluzi-patch-3',
      travisType: 'push',
      language: 'node_js',
      scripts: undefined }
    1) should return HTTP status 200 and ok message

  GET /
    ✓ should return HTML and status 200

  GET /getting-started
    ✓ should return HTML and status 200

  GET /contact-us
    ✓ should return HTML and status 200

  GET /dashboard
    ✓ should return HTML and status 200

  6 passing (1s)
  1 failing

  1) POST /
       should return HTTP status 200 and ok message:
     Error: expected 200 "OK", got 500 "Internal Server Error"
      at Test._assertStatus (node_modules/supertest/lib/test.js:266:12)
      at Test._assertFunction (node_modules/supertest/lib/test.js:281:11)
      at Test.assert (node_modules/supertest/lib/test.js:171:18)
      at Server.assert (node_modules/supertest/lib/test.js:131:12)
      at emitCloseNT (net.js:1655:8)
      at _combinedTickCallback (internal/process/next_tick.js:135:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

npm ERR! Test failed.  See above for more details.

npm run lint
><EMAIL_ADDRESS>lint /home/travis/build/bluzi/travis-buddy
> eslint .


about best model: best.tar

Hi,Cheng
Thanks for your excellent work! When I loaded the model and unzip it ,an error : the file(best.tar) corrupted.
Could you please uploade the model again?
Thanks!
Reese

don't need unzip


wait for service and config cache sync before serving http and grpc

hope fix: #12264
This pr does:

wait for cache sync before running server

wait for cache sync before running queue

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
51ebbc9f7fc92a4f567c2c60afea397ef92dc612
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

TODO: remove the controller.notify method once this is verified.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Can you add some tests here, that will show that any non ready will cause pilot to not start?
Thanks.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-local-tests

prow/istio-unit-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTestsMinProfile

prow/e2e-simpleTests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests

prow/e2e-dashboard.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-dashboard

prow/e2e-simpleTests-cni.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-simpleTests-cni

prow/e2e-bookInfoTests-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9cf5f3186e7972ac3d5a7311be29febce3041f96
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
8e0cb5264d19c7bcf05f32ee66c3588cc791d1ac
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8e0cb5264d19c7bcf05f32ee66c3588cc791d1ac
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
8e0cb5264d19c7bcf05f32ee66c3588cc791d1ac
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

So at least add a way to control this ( pilot features env variables for example) - so if we find any
problem we can disable the new behavior. This is pretty standard for any risky change.

I donot agree with this. It is a bug fix, not a feature, once we find it is not effective, we should simply revert.

@hzxuzhonghu thank you for yet another impactful contribution.
If you can find a way to guard this with a feature flag / env variable we can merge easily tomorrow morning.  Otherwise we'll have a chat and try to balance risk and reward.  We may merge anyways, or we may defer to a 1.1.x.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [hzxuzhonghu]
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
8e0cb5264d19c7bcf05f32ee66c3588cc791d1ac
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
add01236c88354c60cf62da2ec6e0de4bc149770
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is a variant of my old PR https://github.com/istio/istio/pull/12194 without the race condition where queue events could be ignored..
it seems futile to guard this with a feature flag given that this 100% reproducible even on smaller systems due to pilot restart.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
add01236c88354c60cf62da2ec6e0de4bc149770
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
add01236c88354c60cf62da2ec6e0de4bc149770
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

OK, everyone distract yourself with something else and don't look at what I'm about to do.  Thanks


url_normalization_settings: Add APIs to get and update URL normalizat…

Description
We want to start versioning URL normalization settings in HTTP Applications, so I'm adding these APIs.
The public API implements operations for getting and updating URL normalization settings.
Public API: https://api.cloudflare.com/#url-normalization-properties
Has your change been tested?
I created unit tests and I tested the APIs locally with my account.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

Codecov Report

Merging #1071 (4b8298b) into master (e39278e) will increase coverage by 0.09%.
The diff coverage is 67.70%.

@@            Coverage Diff             @@
##           master    #1071      +/-   ##
==========================================
+ Coverage   49.94%   50.04%   +0.09%
==========================================
  Files         115      117       +2
  Lines       10991    11073      +82
==========================================
+ Hits         5490     5542      +52
- Misses       4338     4358      +20
- Partials     1163     1173      +10

Impacted Files
Coverage Δ

pages_project.go
50.81% <ø> (ø)

stream.go
64.91% <ø> (ø)

teams_accounts.go
53.84% <ø> (ø)

api_shield.go
53.84% <53.84%> (ø)

url_normalization_settings.go
53.84% <53.84%> (ø)

workers.go
69.38% <72.72%> (-0.04%)
:arrow_down:

cloudflare.go
68.42% <93.75%> (+1.21%)
:arrow_up:

email_routing_settings.go
60.00% <100.00%> (ø)

images.go
50.34% <100.00%> (-0.35%)
:arrow_down:

r2_bucket.go
100.00% <100.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Easier development start

Edit Makefile and README.md to make development even easier to start.
I'm just experimenting with Makefile here. Feel free to merge this!
Also fixes #422 - Ignore sw.js and include sw.sample.js in version control.

Hey @p4nu  ! I tried to contribute to this repo as well but I haven't seen any activity in the last few months. I decided to fork it to keep it alive. Please see https://github.com/lucavallin/gfi and feel free to open a pull request there. At this time I am setting up the hosting and cleaning up the code. If you're up for it, I could use some help to convert the app from Nuxt.js & Python to Next.js & Typescript.


Valgrind failures in test4 with wchar_t support enabled

I'm not sure if this is a false positive or not.
Environment: Using docker build environment from https://github.com/boostorg/boost/pull/184
If I build with valgrind I end up with some errors in test 4, for example:
boost@2525d5b3fe47:/boost/libs/dynamic_bitset/test$ VALGRIND_OPTS=--error-exitcode=1 ../../../b2 toolset=gcc variant=debug testing.launcher=valgrind
==298== Conditional jump or move depends on uninitialised value(s)
==298==    at 0x590F3FA: __wmemchr_avx2 (memchr-avx2.S:66)
==298==    by 0x4EEC94C: std::codecvt<wchar_t, char, __mbstate_t>::do_out(__mbstate_t&, wchar_t const*, wchar_t const*, wchar_t const*&, char*, char*, char*&) const (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x4F308A5: std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::_M_convert_to_external(wchar_t*, long) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x4F30D21: std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::overflow(unsigned int) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x4F30A44: std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::_M_terminate_output() (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x4F34A60: std::basic_filebuf<wchar_t, std::char_traits<wchar_t> >::close() (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x4F36940: std::basic_ofstream<wchar_t, std::char_traits<wchar_t> >::close() (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x11F8C9: void bitset_test<boost::dynamic_bitset<unsigned char, std::allocator<unsigned char> > >::stream_inserter<std::basic_ofstream<wchar_t, std::char_traits<wchar_t> > >(boost::dynamic_bitset<unsigned char, std::allocator<unsigned char> > const&, std::basic_ofstream<wchar_t, std::char_traits<wchar_t> >&, char const*) (bitset_test.hpp:1217)
==298==    by 0x115DC6: void run_test_cases<unsigned char>() (dyn_bitset_unit_tests4.cpp:147)
==298==    by 0x112936: test_main(int, char**) (dyn_bitset_unit_tests4.cpp:326)
==298==    by 0x113BD1: boost::minimal_test::caller::operator()() (minimal.hpp:111)
==298==    by 0x14102E: boost::detail::function::function_obj_invoker0<boost::minimal_test::caller, int>::invoke(boost::detail::function::function_buffer&) (function_template.hpp:138)

and
==298== Conditional jump or move depends on uninitialised value(s)
==298==    at 0x590F617: __wmemchr_avx2 (memchr-avx2.S:282)
==298==    by 0x4EE8B54: std::basic_istream<wchar_t, std::char_traits<wchar_t> >& std::getline<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >(std::basic_istream<wchar_t, std::char_traits<wchar_t> >&, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >&, wchar_t) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25)
==298==    by 0x12D6AE: void bitset_test<boost::dynamic_bitset<unsigned int, std::allocator<unsigned int> > >::stream_extractor<std::__cxx11::basic_istringstream<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > >(boost::dynamic_bitset<unsigned int, std::allocator<unsigned int> >&, std::__cxx11::basic_istringstream<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >&, std::__cxx11::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> >&) (bitset_test.hpp:1374)
==298==    by 0x119CAD: void run_test_cases<unsigned int>() (dyn_bitset_unit_tests4.cpp:305)
==298==    by 0x112940: test_main(int, char**) (dyn_bitset_unit_tests4.cpp:328)
==298==    by 0x113BD1: boost::minimal_test::caller::operator()() (minimal.hpp:111)
==298==    by 0x14102E: boost::detail::function::function_obj_invoker0<boost::minimal_test::caller, int>::invoke(boost::detail::function::function_buffer&) (function_template.hpp:138)
==298==    by 0x11D7E6: boost::function0<int>::operator()() const (function_template.hpp:769)
==298==    by 0x114216: int boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) (execution_monitor.ipp:285)
==298==    by 0x10F60B: boost::execution_monitor::catch_signals(boost::function<int ()> const&) (execution_monitor.ipp:874)
==298==    by 0x10F78F: boost::execution_monitor::execute(boost::function<int ()> const&) (execution_monitor.ipp:1213)
==298==    by 0x11245D: main (minimal.hpp:130)

If I add define=BOOST_DYNAMIC_BITSET_NO_WCHAR_T_TESTS then the problems go away.  This looks like it might be an issue in libstdc++ with wchar_t support but I'm not sure.  For now the valgrind tests are going to run without wide character tests.  It's better than having none at all.

It's more likely that your valgrind doesn't know about the optimized AVX implementation of wmemchr in your libc, and they are false positives.

Related:
https://www.e-learn.cn/content/wangluowenzhang/415811

Given that the builds also fail on Windows with iostream related issues I am going to suggest the issue is in dynamic_bitset or the unit test until proven otherwise.  If we can pass all our CI tests clean and we still see this in the docker environment with libstdc++ 7.3 (gcc-7.3) then we'll report it to valgrind.
Curiously they don't seem to fail with valgrind 3.10 and an older compiler combination on travis builds.

Issue is resolved with a newer valgrind.


Add the missing ChannelMap to the example code

Description
The ChannelMap was missing in the SoundStream example code.
I also checked other places and could find anything else. OuputSoundFile has the example correctly updated.
This PR fixes #3226
How to test this PR?
Generate the docs, check if it's displayed correctly and optionally compile the code to verify.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 56.634%

Totals

Change from base Build<PHONE_NUMBER>1:
0.01%

Covered Lines:
11899

Relevant Lines:
19920

💛  - Coveralls


rewrite to add various features

proper rebase of https://github.com/oliviertassinari/react-event-listener/pull/4

I noticed you have the tests split between two files right now; I kept my tests in the old file.  Is that what you want?

I noticed you have the tests split between two files right now; I kept my tests in the old file. Is that what you want?

@jedwards1211 Yeah, I'm migrating to use enzyme as a test utils. That's fine like this.
Thanks!

Give me some time, I need to do a release now!

Cool, thanks!


ITW and C2

Add labels to hash section letting you know if samples has ITW or Network Comms
print "<a href='https://www.virustotal.com/intelligence/search/?query=".$array['sha256']."' target='_blank'>".$array['md5']."  ";
if(!empty($array['url'])){print "ITW";}
if(!empty($array['behaviour_dns'])){print "C2";}
print "";

this is done


Deno Support

Doest this plugin transformation work on Deno?

Not possible: https://github.com/denoland/deno/issues/3354

OK thanks for the link

This should be possible if and when https://github.com/microsoft/TypeScript/issues/54276 is possible.


Different Caikit server instances returns different protos

Describe the bug
As part of my automated testing, I observed that some requests were returning very quickly.
Investigations highlighted that min_new_tokens: 0 was the reason for the quick return:

max_new_tokens: 25, min_new_tokens: 0
Request generated 5 tokens before EosToken

while the query is set with max_new_tokens == min_new_tokens.
Further investigations let to this reproducer:
HOST_1=flan-t5-small-cpu-1-predictor-watsonx-e2e-0.apps.20231017-06h53-watsonx-ci-kpouget.psap.aws.rhperfscale.org:443;
HOST_2=flan-t5-small-cpu-2-predictor-watsonx-e2e-1.apps.20231017-06h53-watsonx-ci-kpouget.psap.aws.rhperfscale.org:443;

get_proto() {
    grpcurl -insecure $1 describe caikit.runtime.Nlp.TextGenerationTaskRequest
}

get_proto $HOST_1 > 1
get_proto $HOST_2 > 2

echo diff
diff --side <(get_proto $HOST_1) <(get_proto $HOST_2)

1.log | 2.log

which highlights that the protos returned by two endpoints running the same image are different.
Image is quay.io/opendatahub/caikit-tgis-serving@sha256:794adc22d52cb3ac4b5aadfb286e8431cca829acdc4909719329cf8c4fabb4ec
Platform
Caikit packages in this image have this version:
caikit                  0.19.3
caikit-nlp              0.0.1                   /caikit/src/caikit-nlp
caikit-tgis-backend     0.1.18

Python 3.9
Sample Code
See above.
The invalid launch happens ~50% of the time, from what I observed.
Expected behavior
The prototypes are always the same.
Observed behavior
The prototypes do not have the same ordering.
No error printed anywhere.
Additional info
The location of this block (+ the field numbering) is the key difference between the "different versions" of the protos:
  oneof _preserve_input_text {
    bool preserve_input_text = 15;
  }

I have a simpler reproducer !
#! /bin/bash

TARGET_PROTO=serverstreamingtextgenerationtaskrequest.proto
TRIES=10

echo "Generating the reference protos ..."
RUNTIME_LIBRARY=caikit_nlp python -m caikit.runtime.dump_services /tmp/proto.ref 2>/dev/null

target_proto_sum=$(cat /tmp/proto.ref/$TARGET_PROTO | sha256sum)

for i in $(seq $TRIES); do
    echo "Generating some new protos (try #${i}) ..."
    RUNTIME_LIBRARY=caikit_nlp python -m caikit.runtime.dump_services /tmp/proto.cmp 2>/dev/null
    echo "Comparing ..."
    current_proto_sum=$(cat /tmp/proto.cmp/$TARGET_PROTO | sha256sum)
    if [[ "$current_proto_sum" == "$target_proto_sum" ]]; then
        echo "Identical ..."
    fi
    cat <<EOF
Found different $TARGET_PROTO protos at try #${i}:
/tmp/proto.ref/$TARGET_PROTO --> $target_proto_sum
/tmp/proto.cmp/$TARGET_PROTO --> $current_proto_sum
EOF
    if which diff 2>/dev/null; then # diff isn't available in the container image ...
        diff "/tmp/proto.ref/$TARGET_PROTO" "/tmp/proto.cmp/$TARGET_PROTO"
    fi
    break
done

if [[ "$i" == "$TRIES" ]]; then
    echo "Didn't find any different proto :/"
    exit 1
fi

sh-5.1$ bash try.sh
Generating the reference protos ...
Generating some new protos (try #{i}) ...
Comparing ...
Generating some new protos (try #{i}) ...
Comparing ...
Generating some new protos (try #{i}) ...
Comparing ...
Generating some new protos (try #{i}) ...
Comparing ...
Generating some new protos (try #{i}) ...
Comparing ...
Found different serverstreamingtextgenerationtaskrequest.proto protos at try 5:
/tmp/proto.ref/serverstreamingtextgenerationtaskrequest.proto --> 55befeea6899aefdc0af416eab2fc8e4a522917540827a2648ae5a83d00fbe11  -
/tmp/proto.cmp/serverstreamingtextgenerationtaskrequest.proto --> 0a843c0e74fb8a91fb432b060a726ca6afa464b9dcb4b460c65c4fe545aa4a35  -

sh-5.1$ bash try.sh
Generating the reference protos ...
Generating some new protos (try #1) ...
Comparing ...
Found different serverstreamingtextgenerationtaskrequest.proto protos at try #1:
/tmp/proto.ref/serverstreamingtextgenerationtaskrequest.proto --> 0a843c0e74fb8a91fb432b060a726ca6afa464b9dcb4b460c65c4fe545aa4a35  -
/tmp/proto.cmp/serverstreamingtextgenerationtaskrequest.proto --> 55befeea6899aefdc0af416eab2fc8e4a522917540827a2648ae5a83d00fbe11  -

again, the location of this field is the issue:
  optional bool preserve_input_text = 2; # or 15

Ok, looks like the version of caikit-nlp is set here as 6f099312d65a15dc20952abfe77d3990a83669a3 which is 0.2.1. This is the release directly before the fix was merged, so to fix the current problem, we should simply update the version in the RH build to a newer release.

thanks for the updates,  I can't find any problematic difference now :)
only thing I noticed is that the Services still have a random order. Two examples:

I think this last bit will be solved by https://github.com/caikit/caikit/pull/535, @evaline-ju could you confirm?

@aluu317 worked on https://github.com/caikit/caikit/pull/535 - could you provide any insight on the above? I think I was tagged by mistake

@aluu317 worked on caikit/caikit#535 - could you provide any insight on the above? I think I was tagged by mistake

oups, I got it wrong with the auto-completion, sorry Evaline!


Ignore QueryInsights schema for extraction from Fabric DW

SqlPackage or DacFx Version:
.NET Framework (Windows-only) or .NET Core:
Environment (local platform and source/target platforms):

Steps to Reproduce:

Extract from a fabric DW
You get a 'queryinsights' schema extracted which is a system generated schema. It should be ignored from extraction

Here is the error message upon trying to build from the extracted project:
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\exec_requests_history.sql(1,277,1,277): Build error SQL71501: SqlComputedColumn: [queryinsights].[exec_requests_history].[status] contains an unresolved reference to an object. Either the object does not exist or the reference is ambiguous because it could refer to any of the following objects: [queryinsights].[fabric_query_completed].[query_status], [queryinsights].[fabric_query_completed].[t2]::[query_status] or [queryinsights].[fabric_query_starting].[t2]::[query_status].
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\exec_requests_history.sql(1,319,1,319): Build error SQL71501: SqlComputedColumn: [queryinsights].[exec_requests_history].[connection_id] contains an unresolved reference to an object. Either the object does not exist or the reference is ambiguous because it could refer to any of the following objects: [queryinsights].[fabric_query_completed].[t1]::[connection_id], [queryinsights].[fabric_query_starting].[connection_id] or [queryinsights].[fabric_query_starting].[t1]::[connection_id]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\long_running_queries.sql(1,1409,1,1409): Build error SQL71501: SqlView: [queryinsights].[long_running_queries] has an unresolved reference to object [queryinsights].[fabric_query_starting].[statement]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\long_running_queries.sql(1,1348,1,1348): Build error SQL71501: SqlView: [queryinsights].[long_running_queries] has an unresolved reference to object [queryinsights].[fabric_query_starting].[query_text_hash]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\long_running_queries.sql(1,1386,1,1386): Build error SQL71501: SqlView: [queryinsights].[long_running_queries] has an unresolved reference to object [queryinsights].[fabric_query_starting].[session_id]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\long_running_queries.sql(1,1461,1,1461): Build error SQL71501: SqlView: [queryinsights].[long_running_queries] has an unresolved reference to object [queryinsights].[fabric_query_starting].[batch_id]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]
stdout: c:\sqlprojectfabric\DatabaseProjectsqldw01\queryinsights\Views\long_running_queries.sql(1,1605,1,1605): Build error SQL71501: SqlView: [queryinsights].[long_running_queries] has an unresolved reference to object [queryinsights].[fabric_query_completed]. [c:\sqlprojectfabric\DatabaseProjectsqldw01\DatabaseProjectsqldw01.sqlproj]

I don't think this is a DacFx issue. Those views aren't correctly marked as is_ms_shipped in sys.all_views. @salilkanade can you update/close this issue once you verify with the engine team?


install cask zulu@17 is error, no exists

When I start the project fllowing the document, run "brew install --cask zulu@17" is error:Running brew update --auto-update...
Warning: Cask 'zulu@17' is unavailable: No Cask with this name exists.
==> Searching for similarly named casks...
Error: Cask 'zulu@11' is unavailable: No Cask with this name exists.
zsh: command not found: #
Error: Cask 'zulu@17' is unavailable: No Cask with this name exists.

You should run brew update before if you're hitting this error


allowed memory

when enable this extension the cpu gets 100% and PHP Fatal error:  Allowed memory size...

@carlituxman Is it also happening on the latest version 0.1.3?

yes, 0.1.3

Can I get a screenshot of your CPU or the script where the exception is happening?


feat(Drawer): add Component attribute just like dialog does.

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.
as title described, I think a consistent api design can reduce mental burden.
now the ChildContent is really hard to use.
Describe the solution you'd like
as title described.
Additional context
noop

@ice6 working on it

@ice6
add Component parameter on DrawerOption
/// <summary>
/// 获得/设置 自定义组件
/// </summary>
public BootstrapDynamicComponent? Component { get; set; }


build gohook  error

Robotgo version (or commit ref): github.com/go-vgo/robotgo v0.0.0-20190312143323-fb86491ad97a
Go version: 1.12
Gcc version: gcc version 8.1.0 (x86_64-win32-seh-rev0, Built by MinGW-W64 project)
Operating system and bit: win10 64

import "github.com/go-vgo/robotgo"

func main()  {
	robotgo.ScrollMouse(10, "up")
	robotgo.MouseClick("right", true)
	robotgo.MoveMouseSmooth(100, 200, 1.0, 100.0)
}

build cmd:

set GOOS=windows
set GOARCH=amd64
set CGO_ENABLED=1
set CC=E:\MinGW64\mingw64\bin\gcc.exe
set CXX=E:\MinGW64\mingw64\bin\g++.exe
go build -x ./main/main.go

Log gist:

github.com/robotn/gohook
C:\Users\Yale\AppData\Local\Temp\go-build403541470\b036\_x003.o: In function `eb_port_create':
C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:382: undefined reference to `sched_yield'
C:\Users\Yale\AppData\Local\Temp\go-build403541470\b036\_x003.o: In function `eb_port_free':
C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:350: undefined reference to `sched_yield'
C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:341: undefined reference to `sched_yield'
C:\Users\Yale\AppData\Local\Temp\go-build403541470\b036\_x003.o: In function `cleanup_ops':
C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:858: undefined reference to `sched_yield'
C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:858: undefined reference to `sched_yield'
C:\Users\Yale\AppData\Local\Temp\go-build403541470\b036\_x003.o:C:/YaleSoftFiles/WorkSpace/Go/pkg/mod/github.com/robotn/gohook@v0.0.0-20190305192954-bbbbefb5ff85/chan/eb_chan.h:643: more undefined references to `sched_yield'
follow
collect2.exe: error: ld returned 1 exit status

Can't be reproduce on Windows7, pending further testing.

thanks, waiting for next release

@yale8848  use https://github.com/go-vgo/Mingw

@yale8848 I tested a lot of gcc versions, please check your environment configuration.

test ok, thanks


🐛 [PLUGIN_NAME_HERE] Your issue title here

Bug report
Describe the bug
A clear and concise description of what the bug is.
Steps to reproduce
Steps to reproduce the behavior:

Go to '...'
'...'
See error or incorrect behavior

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
PASTE OUTPUT INSIDE HERE

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
PASTE OUTPUT INSIDE HERE

Hi @yuuki3125y
When opening an issue, please try to provide all of the information indicated in the template.
Closing this issue, since no information has been provided.
Thank you.


Update Imports

Update import statements to point to Companies House forks.
Merge base repository into this fork.
Remove redundant badges and add Go Report Card badge to Readme.

@ChrisJBurns I was tempted to tidy up things like these, but decided to leave them in to keep consistency with the master repo. They highlight areas of the code which might need future improvement.


Support Jupyter notebooks for results printing

Motivation and Context

This builds on #6635 to support Jupyter notebooks being converted to PDFs.
Your Changes

Description:
We use nbconvert to turn Jupyter notebooks into PDFs to be merged into the printed PDF sing the webpdf option. This required pandoc and playwright to be installed, which in turn required other system dependencies to be installed (see changes to markus.control).
Also, we need to run playwright install chromium, which installs the web browser Chromium. The installation location is controlled by the environment variable PLAYWRIGHT_BROWSERS_PATH.
Type of change (select all that apply):

[x] New feature (non-breaking change which adds functionality)

Testing

Tested manually in the UI and added additional test case.
Questions and Comments (if applicable)

Checklist

[ ] I have performed a self-review of my own code.
[ ] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[x] I have added tests for my changes.
[x] I have updated the Changelog.md file.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

19 of 20 (95.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 91.773%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/models/result.rb
11
12
91.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
39155

Relevant Lines:
42043

💛  - Coveralls


No response when dialing to Mailbox via gPRC

There is no error or cancellation at calling grpc.DialContext below, it is just put on hold.
The mailbox is mailbox.terminal.lightning.today:443
https://github.com/lightninglabs/aperture/blob/master/lnc/lnc.go#L284-L286
By the way, this issue may be due to be re-use passphrase from multiple containers under development, because it worked generating new phrase per container. However, I don't know because I haven't received a response and seen any documentation prohibiting passphrase reuse.

Hi @studioTeaTwo I think you are right that it holds forever and the reason is that after a connection has been stablished using a passphrase a "secret" key is created and the communication with the mailbox-node uses that key. Which means that passphrase cannot be reused. Let's fix this in two different PRs:

#127 adding a timeout so we fail if we are not able to connect to the mailbox instead of hanging (even if it does not tell you the reason)
#108 explaining that you cannot reuse passphrase in the config.


Why not revoce erridx whe panic occured?

L.Remove(err_idx) not executed when panic occurred, it will stay in the stack, make stack grow

This is an example, make stack top bigger

It doesn't matter, anything that was pushed on the stack between pcall and the point where the exception happens will be leaked forever. Duplicate of #24


As a data user I want a clear and accessible link to the source data that sits behind the data product so that the raw data can be accessed/requested

Obsolete


Reaper 7 - reaper.BR_TrackAtMouseCursor() doesn't take care of spacer

Hello folks,
As reported here : https://github.com/me2beats/reapack/issues/2
I suspect the function reaper.BR_TrackAtMouseCursor() to not consider track spacer when returning the track under mouse.
To reproduce using me2beat script :

Open a project with several tracks (16 in my case)
put the mouse cursor on an item
enable the script (F1 in my case)
it doesn't select the right track

If I put the mouse on the TCP track, in this case it works. So it seems to be the way the function returns the track under arrange view/item.
If I remove every spacer, the function and the script perfectly work.
here is a gif : https://imgur.com/IrQubkH

https://github.com/reaper-oss/sws/pull/1787#issuecomment-1813008811

Closing as duplicate of #1761.

Also, REAPER now has its own GetTrackFromPoint function which is a lot faster than the SWS one and does not have this compatibility issue.


MIMIR-114: Get owner for tbml tables

Get sourcelist when registering a new tbml
Merge sourcelist with tbml data
Use sourcelist to show owner in update modal
Group sourcelist on owner id
Enable username and password fields
Send in user, password and owner id to backend
MIMIR-114

This code only support one owner. Support for multiple owners will come in the following PR's.


where should the discussion for the SIP take place ?

where should the discussion for the SIP take place ?
I believe, it could be either the dev list or the SIP issue itself.

doing@fggfcff on the dev list would make be easier for people not following the SIP issue itself to follow the discussion.

Originally posted by @nishantmonu51 in https://github.com/apache/incubator-superset/issues/5602#issuecomment-433194906

On GitHub, and notification about it should be sent to the dev@ mailing list as a [DISCUSS] thread, as touched in SIP-0

Notify the dev@ mailing list that the SIP has been created, use the subject line [DISCUSS] SIP-0 Superset Improvement Proposals, the body of the email should look something like Please discuss & subscribe here: https://github.com/apache/incubator-superset/issues/5602


Collect xen

https://xenbits.xen.org/xsa/

What should be the format for data collection?

I was writing a script to collect xen. Had a few questions in mind. What data needs to be specifically collected from https://xenbits.xen.org/xsa/ ?

Do we just collect the CVE column and advisory, or anything else too?

@sbs2001 ping

The work was partial, this needs to be refactored and migrated to importer improver structure


metafinder command failed

Scanning metadata in public files
metafinder command failed
how to solve it?

the lines out in reconftw.sh

Sorry it chopped part of my response, search for the metafinder lines in reconftw.sh and # them out as showed.

Installing metafinder, Manually solved it for me. Install below package.
https://github.com/Josue87/MetaFinder

Fixed metafinder requirements to not get issues on it's installation

This is still a problem, tried 3 times and it's always metafinder which fails. Running metafinder manually works fine tho :/


"Recommended for you" on the CORE page not working

[x] Add to an appropriate Epic.

Tester (if different from issue creator):
Site: hcommons-dev.org
URL: https://hcommons-dev.org/core/
Test Account: Bonnie
Area (CORE, sites, profiles, groups, general): CORE
If issue discovered on dev, does it also exist on prod? Works on prod
Describe the issue
This may be related to the CORE testing and migration, but the "recommended for you" section is showing "no results."
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Optional details, if they seem relevant
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Should test post update to see if this was a sync issue.

This was caused primarily by changes to how indexing works in ElasticSearch and the architecture of the ElasticPress plugin.
See:

https://github.com/MESH-Research/elasticpress-buddypress/pull/10
https://github.com/MESH-Research/hc-suggestions/pull/4
https://github.com/MESH-Research/commons/commit/d1ecbb483307effd2efac67a5c5e76287b47c656


[Feature][Helm] Support multiple Ray worker types in the KubeRay Helm chart

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
KubeRay's RayCluster CRD supports multiple worker groups. However, the Helm chart supports only one worker group. It would be good to expose multiple groups.
Implementation ideas:

One way to achieve this is to add a workerGroups field to the KubeRay CR, which would be a mapping from user-specified string names to configuration that is currently in the worker field.

Another way is to have an array workerGroups.

The Helm docs suggest a map might be preferred over an array if the user uses --set to override values in the chart.
However, in my experience, a map can be confusing, because the user may interpret the keys as part of the schema, rather than as arbitrary names.
workerGroups would either override the current worker field OR the worker config would be internally appending to workerGroups.
Use case
Easy configurability for mixed workloads (e.g. workloads the require GPUs and CPUs).
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Just to back up this feature on @DmitriGekhtman  has already said, I have found it advantageous to be able to specify pod types, like you can with the Kubernetes helm chart deployment, and then match these up with underlying node pools. It means then you can give the cluster the option of determining the most efficient worker node instance types to use given the resource demands.
For example, giving the cluster building blocks of agent pools of 8, 16, 32 and 64 cpus instances, then the cluster can see what combination of these instance types closely matches the required cpu resource requirement. It avoids the spinning up of say a 32 cpu node when only 8 cpu units are needed.

A Kubernetes based helm chart (i.e. non kuberay) would look like the following:
podTypes:
    # The key for each podType is a user-defined string.
    # Since we set headPodType: rayHeadType, the Ray head pod will use the configuration
    # defined in this entry of podTypes:
    rayHeadType:
        # CPU is the number of CPUs used by this pod type.
        # (Used for both requests and limits. Must be an integer, as Ray does not support fractional CPUs.)
        CPU: 3
        # memory is the memory used by this Pod type.
        # (Used for both requests and limits.)
        memory: 3064Mi
        # GPU is the number of NVIDIA GPUs used by this pod type.
        # (Optional, requires GPU nodes with appropriate setup. See https://docs.ray.io/en/master/cluster/kubernetes-gpu.html)
        GPU: 0
        # rayResources is an optional string-int mapping signalling additional resources to Ray.
        # "CPU", "GPU", and "memory" are filled automatically based on the above settings, but can be overriden;
        # For example, rayResources: {"CPU": 0} can be used in the head podType to prevent Ray from scheduling tasks on the head.
        # See https://docs.ray.io/en/master/advanced.html#dynamic-remote-parameters for an example of usage of custom resources in a Ray task.
        rayResources: {"CPU": 0}
        # Optionally, set a node selector for this podType: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
        nodeSelector: {"agentpool": "agentpool"}

        # tolerations for Ray pods of this podType (the head's podType in this case)
        #   ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
        #   Note that it is often not necessary to manually specify tolerations for GPU
        #   usage on managed platforms such as AKS, EKS, and GKE.
        #   ref: https://docs.ray.io/en/master/cluster/kubernetes-gpu.html
        tolerations: []
        # - key: "nvidia.com/gpu"
        #   operator: Exists
        #   effect: NoSchedule

    rayWorkerType_default:
        # minWorkers is the minimum number of Ray workers of this pod type to keep running.
        minWorkers: 0
        # maxWorkers is the maximum number of Ray workers of this pod type to which Ray will scale.
        maxWorkers: 4
        # memory is the memory used by this Pod type.
        # (Used for both requests and limits.)
        memory: 56000Mi
        # CPU is the number of CPUs used by this pod type.
        # (Used for both requests and limits. Must be an integer, as Ray does not support fractional CPUs.)
        CPU: 15
        # GPU is the number of NVIDIA GPUs used by this pod type.
        # (Optional, requires GPU nodes with appropriate setup. See https://docs.ray.io/en/master/cluster/kubernetes-gpu.html)
        GPU: 0
        # rayResources is an optional string-int mapping signalling additional resources to Ray.
        # "CPU", "GPU", and "memory" are filled automatically based on the above settings, but can be overriden;
        # For example, rayResources: {"CPU": 0} can be used in the head podType to prevent Ray from scheduling tasks on the head.
        # See https://docs.ray.io/en/master/advanced.html#dynamic-remote-parameters for an example of usage of custom resources in a Ray task.
        rayResources: [] #{"PODTYPE_VLARGE": 15}
        # Optionally, set a node selector for this Pod type. See https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
        nodeSelector: {"agentpool": "raypool"}

        # tolerations for Ray pods of this podType
        #   ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
        #   Note that it is often not necessary to manually specify tolerations for GPU
        #   usage on managed platforms such as AKS, EKS, and GKE.
        #   ref: https://docs.ray.io/en/master/cluster/kubernetes-gpu.html
        tolerations:
        - key: kubernetes.azure.com/scalesetpriority
          operator: "Equal"
          value: "spot"
          effect: "NoSchedule"
        # - key: nvidia.com/gpu
        #   operator: Exists
        #   effect: NoSchedule

    rayWorkerType_large:
        # minWorkers is the minimum number of Ray workers of this pod type to keep running.
        minWorkers: 0
        # maxWorkers is the maximum number of Ray workers of this pod type to which Ray will scale.
        maxWorkers: 4
        # memory is the memory used by this Pod type.
        # (Used for both requests and limits.)
        memory: 110000Mi
        # CPU is the number of CPUs used by this pod type.
        # (Used for both requests and limits. Must be an integer, as Ray does not support fractional CPUs.)
        CPU: 31
        # GPU is the number of NVIDIA GPUs used by this pod type.
        # (Optional, requires GPU nodes with appropriate setup. See https://docs.ray.io/en/master/cluster/kubernetes-gpu.html)
        GPU: 0
        # rayResources is an optional string-int mapping signalling additional resources to Ray.
        # "CPU", "GPU", and "memory" are filled automatically based on the above settings, but can be overriden;
        # For example, rayResources: {"CPU": 0} can be used in the head podType to prevent Ray from scheduling tasks on the head.
        # See https://docs.ray.io/en/master/advanced.html#dynamic-remote-parameters for an example of usage of custom resources in a Ray task.
        rayResources: [] # {"PODTYPE_VLARGE": 15}
        # Optionally, set a node selector for this Pod type. See https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
        nodeSelector: {"agentpool": "raypoollarge"}

        # tolerations for Ray pods of this podType
        #   ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
        #   Note that it is often not necessary to manually specify tolerations for GPU
        #   usage on managed platforms such as AKS, EKS, and GKE.
        #   ref: https://docs.ray.io/en/master/cluster/kubernetes-gpu.html
        tolerations:
        - key: kubernetes.azure.com/scalesetpriority
          operator: "Equal"
          value: "spot"
          effect: "NoSchedule"
        # - key: nvidia.com/gpu
        #   operator: Exists
        #   effect: NoSchedule

    rayWorkerType_small:
        # minWorkers is the minimum number of Ray workers of this pod type to keep running.
        minWorkers: 0
        # maxWorkers is the maximum number of Ray workers of this pod type to which Ray will scale.
        maxWorkers: 8
        # memory is the memory used by this Pod type.
        # (Used for both requests and limits.)
        memory: 28000Mi
        # CPU is the number of CPUs used by this pod type.
        # (Used for both requests and limits. Must be an integer, as Ray does not support fractional CPUs.)
        CPU: 7
        # GPU is the number of NVIDIA GPUs used by this pod type.
        # (Optional, requires GPU nodes with appropriate setup. See https://docs.ray.io/en/master/cluster/kubernetes-gpu.html)
        GPU: 0
        # rayResources is an optional string-int mapping signalling additional resources to Ray.
        # "CPU", "GPU", and "memory" are filled automatically based on the above settings, but can be overriden;
        # For example, rayResources: {"CPU": 0} can be used in the head podType to prevent Ray from scheduling tasks on the head.
        # See https://docs.ray.io/en/master/advanced.html#dynamic-remote-parameters for an example of usage of custom resources in a Ray task.
        rayResources: [] #{"PODTYPE_VLARGE": 15}
        # Optionally, set a node selector for this Pod type. See https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
        nodeSelector: {"agentpool": "raypoolsmall"}

        # tolerations for Ray pods of this podType
        #   ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
        #   Note that it is often not necessary to manually specify tolerations for GPU
        #   usage on managed platforms such as AKS, EKS, and GKE.
        #   ref: https://docs.ray.io/en/master/cluster/kubernetes-gpu.html
        tolerations:
        - key: kubernetes.azure.com/scalesetpriority
          operator: "Equal"
          value: "spot"
          effect: "NoSchedule"
        # - key: nvidia.com/gpu
        #   operator: Exists
        #   effect: NoSchedule

A Kubernetes based helm chart (i.e. non kuberay)

KubeRay is also Kubernetes-based :) Just a different implementation targeting similar problems.

agent pools of 8, 16, 32 and 64 cpus instances

That makes from a cost perspective! On the other hand, you may get better performance running a few big Ray nodes vs. many small ones -- with a few big nodes, there's less network overhead and fewer local Ray control structures running.
The goal is to find the right balance :)

KubeRay is also Kubernetes-based :) Just a different implementation targeting similar problems.

@DmitriGekhtman you are indeed most correct sir, it was a poor description by myself. I was attempting to differentiate from the kuberay implementation. :-)
You make some good points on the size of nodes!

I also forgot to mention, in the above example, I added tolerations as I tend to use spot instances on Azure to save cost.
These weren't needed for demonstration.

This has been solved.


Tweak consistency

👀 Purpose

Few tweaks for consistency

♻ What's changed

♻ Verify page wording to refer solely to Office 365 (rather than justice.gov.uk)
♻ Use Jinja button component to be consistent with elsewhere in code
🔡 Tried to simplify the language a bit

📝 Notes

Ignore Megalinter punycode complaint.


Cors

Security :
Because every one can access the db with the AuthToken
The better solution is to add CORS

How -> Add a CORS object in the config file and use it with express

#6


SearchException: No alive nodes found in your cluster

@kiwiz
I'm using elasticsearch on port 9200 with the below IP address. In the 411 console, it says no live hosts and I'm unable to create a query.
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:53            <IP_ADDRESS>:*               LISTEN      1160/dnsmasq
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN      2777/sshd
tcp        0      0 <IP_ADDRESS>:27017         <IP_ADDRESS>:*               LISTEN      1501/mongod
tcp6       0      0 :::8080                 :::*                    LISTEN      97083/docker-proxy
tcp6       0      0 <IP_ADDRESS>:9200     :::*                    LISTEN      7346/java
tcp6       0      0 <IP_ADDRESS>:9300     :::*                    LISTEN      7346/java
tcp6       0      0 :::22                   :::*                    LISTEN      2777/sshd
tcp6       0      0 <IP_ADDRESS>:8855     :::*                    LISTEN      7578/java
tcp6       0      0 <IP_ADDRESS>:5566     :::*                    LISTEN      7578/java
tcp6       0      0 <IP_ADDRESS>:12900    :::*                    LISTEN      7578/java
tcp6       0      0 <IP_ADDRESS>:9350          :::*                    LISTEN      7578/java
tcp6       0      0 <IP_ADDRESS>:9000     :::*                    LISTEN      7578/java

root@ubuntu:/opt/411-docker# curl -XGET 'http://<IP_ADDRESS>:9200'
{
  "name" : "Blink",
  "cluster_name" : "graylog",
  "cluster_uuid" : "KSma-dJxTVW97Jwm0ttlRA",
  "version" : {
    "number" : "2.4.5",
    "build_hash" : "c849dd13904f53e63e88efc33b2ceeda0b6a1276",
    "build_timestamp" : "2017-04-24T16:18:17Z",
    "build_snapshot" : false,
    "lucene_version" : "5.5.4"
  },
  "tagline" : "You Know, for Search"
}

  # Configuration for the 411 Alerts index.
    'alerts' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [''],
        'ssl_cert' => null,
        'index' => null,
        'date_based' => false,
        'date_interval' => null,
        'date_field' => 'alert_date',
        'date_type' => null,
        'src_url' => null,
    ],
    # Configuration for the logstash index that 411 queries.
    'logstash' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [''],
        'ssl_cert' => null,
        'index' => '[logstash-]Y.m.d',
        'date_based' => true,
        'date_interval' => 'd',
        'date_field' => '@timestamp',
        'date_type' => null,
        'src_url' => null,
    ],

    'graylog_0' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [''],
        'ssl_cert' => null,
        'index' => '[logstash-]Y.m.d',
        'date_based' => true,
        'date_interval' => 'd',
        'date_field' => '@timestamp',
        'date_type' => null,
        'src_url' => null,
    ],

Hi @sathishdsgithub, is there any index called "[logstash-]Y.m.d" in your elasticsearch? As I can see in your image you should replace by elastalert_status or graylog_0 that is the existent indexes.

@quintanilhar
As recommended I modified the index name as graylog_0 but still my es health status is bad (red).
my config.php as shown below
<?php

/**
 * 411 configuration file
 *
 * Rename this to 'config.php' and modify.
 */
$config = [];

/**
 * Authentication configuration
 */
$config['auth'] = [
    'proxy' => [
        /**
         * Whether to enable proxy auth.
         * IT IS VERY INSECURE TO ENABLE THIS IF 411 is not run behind an auth proxy.
         */
        'enabled' => false,
        /**
         * The name of the header the proxy is setting.
         */
        'header' => null,
        /**
         * Whether to automatically create users who are authenticated.
         */
        'auto_create' => false,
        /**
         * Email domain for automatically created users.
         */
        'domain' => null,
    ],
    'api' => [
        /**
         * Whether to enable api access to 411.
         */
        'enabled' => true
    ]
];

/**
 * Database configuration
 */
$config['db'] = [
    /**
     * A PDO compatible DSN. See https://secure.php.net/manual/en/pdo.drivers.php for details.
     * SQLite is the default configuration but MySQL is also supported. To configure the latter,
     * you'll need a dsn like the following: 'mysql:host=localhost;dbname=fouroneone'.
     */
    'dsn' => 'sqlite:' . realpath(__DIR__ . '/data.db'),
    /**
     * The user name for connecting to the database.
     */
    'user' => 'root',
    /**
     * The password for connecting to the database. Optional if the PDO driver doesn't
     * require a password.
     */
    'pass' => null,
];

/****
 *
 * Search type configuration
 * Note: All hostnames should specify protocol!
 *
 ***/

/**
 * Elasticsearch search type
 */
$config['elasticsearch'] = [
    /**
     * Each entry in this array represents an Elasticsearch source that 411 can query.
     *
     * 'hosts': An array of hosts powering your ES cluster.
     * 'index_hosts': An array of hosts to use for indexing (if different from 'hosts').
     * 'ssl_cert': Path to an ssl certificate if your cluster uses HTTPS.
     * 'index': The index to query. Leave as null to query all indices.
     *          If the index is date_based, accepts index patterns. (Otherwise, it's taken literally)
     *          Any characters wrapped by [] will be taken literally.
     *          All other characters are interpretted via PHP's date formatting syntax.
     *          See https://secure.php.net/manual/en/function.date.php for details.
     * 'date_based': Whether to generate an index name according to a date-based index pattern.
     * 'date_interval': If the index is date_based, this defines the indexing pattern interval.
     *                  'h' - Hourly.
     *                  'd' - Daily.
     *                  'w' - Weekly.
     *                  'm' - Monthly.
     *                  'y' - Yearly.
     * 'date_field': The field to use for doing date-based queries.
     * 'date_type': The format of the date field.
     *              null - Automatically detect and parse. Should work most of the time!
     *              '@' - Parse as a UNIX timestamp.
     *              '#' - Parse as a UNIX timestamps (in milliseconds).
     *              All other strings are interpretted via PHP's date formatting syntax.
     * 'src_url': A format string for generating default source links.
     *            Requires the following format specifiers: 's', 'd', 'd'.
     *            Ex: 'https://localhost/?query=%s&from=%d&to=%d'
     */

    # Configuration for the 411 Alerts index.
    'alerts' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => '411_alerts_1',
        'date_based' => false,
        'date_interval' => null,
        'date_field' => 'alert_date',
        'date_type' => null,
        'src_url' => null,
    ],
    # Configuration for the logstash index that 411 queries.
    'logstash' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => 'graylog_0',
        'date_based' => true,
        'date_interval' => 'd',
        'date_field' => '@timestamp',
        'date_type' => null,
        'src_url' => null,
    ],
];

/**
 * Graphite
 *
 * Configure to allow querying Graphite.
 */
$config['graphite'] = [
    /**
     * Each entry in this array represents a Graphite source that 411 can query.
     *
     * 'host': The hostname for your Graphite instance.
     */
    'graphite' => [
        'host' => null,
    ],
];

/**
 * ThreatExchange
 * See https://developers.facebook.com/products/threat-exchange for details.
 *
 * Configure to allow querying ThreatExchange.
 */
$config['threatexchange'] = [
    /**
     * The api token for connecting to ThreatExchange.
     */
    'api_token' => null,
    /**
     * The api secret for connecting to ThreatExchange.
     */
    'api_secret' => null,
];

/****
 *
 * Target configuration
 *
 ***/

/**
 * Jira
 *
 * Fill in to enable Jira integration.
 */
$config['jira'] = [
    /**
     * The hostname for your Jira instance.
     */
    'host' => null,
    /**
     * The username for connecting to Jira.
     */
    'user' => null,
    /**
     * The password for connecting to Jira.
     */
    'pass' => null,
];

/**
 * Slack
 *
 * Fill in to enable Slack integration.
 */
$config['slack'] = [
    /**
     * A webhook url to push Alerts to.
     * See https://api.slack.com/incoming-webhooks for details.
     */
    'webhook_url' => null
];

root@ubuntu:/opt/411-docker# docker run -p 8080:80 407b8c3affd6
2017-09-13 10:41:58,727 CRIT Supervisor running as root (no user in config file)
2017-09-13 10:41:58,736 INFO supervisord started with pid 1
2017-09-13 10:41:59,745 INFO spawned: 'cron' with pid 10
2017-09-13 10:41:59,759 INFO spawned: 'apache2' with pid 11
2017-09-13 10:42:01,323 INFO success: cron entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2017-09-13 10:42:01,323 INFO success: apache2 entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2017-09-13 10:42:58,365 CRIT reaped unknown pid 27)
2017-09-13 10:42:58,487 CRIT reaped unknown pid 35)
2017-09-13 10:42:58,535 CRIT reaped unknown pid 33)
2017-09-13 10:42:58,708 CRIT reaped unknown pid 43)
^C2017-09-13 10:45:45,101 WARN received SIGINT indicating exit request
2017-09-13 10:45:45,102 INFO waiting for cron, apache2 to die
2017-09-13 10:45:45,197 INFO stopped: apache2 (exit status 0)
2017-09-13 10:45:45,198 INFO stopped: cron (terminated by SIGTERM)
root@ubuntu:/opt/411-docker# docker run -p 8080:80 407b8c3affd6
2017-09-13 10:45:47,433 CRIT Supervisor running as root (no user in config file)
2017-09-13 10:45:47,438 INFO supervisord started with pid 1
2017-09-13 10:45:48,441 INFO spawned: 'cron' with pid 10
2017-09-13 10:45:48,443 INFO spawned: 'apache2' with pid 11
2017-09-13 10:45:49,520 INFO success: cron entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2017-09-13 10:45:49,521 INFO success: apache2 entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2017-09-13 10:48:43,855 CRIT reaped unknown pid 32)
2017-09-13 10:49:23,962 CRIT reaped unknown pid 45)
2017-09-13 10:49:24,002 CRIT reaped unknown pid 53)
2017-09-13 10:50:03,982 CRIT reaped unknown pid 62)

Good, it is almost done, can you show the schema of this index please? You need to configure the date field:
'date_based' => true, // usually is false
'date_interval' => 'd', // try as null
'date_field' => '@timestamp', // the date field in your index
'date_type' => null, // usually is null

@quintanilhar
Is this something your asking about?

{
"_index": "graylog_0",
"_type": "message",
"_id": "f60ac1d0-92dc-11e7-b254-000c2982a0e2",
"_version": 1,
"_score": 1,
"_source": {
"gl2_remote_ip": "<IP_ADDRESS>",
"srx-destination-address": "<IP_ADDRESS>",
"gl2_remote_port": 39458,
"source": "<IP_ADDRESS>",
"gl2_source_input": "59afa9218ec8161d9aad6e9b",
"srx-ip-address": "<IP_ADDRESS>",
"service-name": "None",
"srx-destination-port": "17075",
"srx-source-zone-name": "corporate",
"gl2_source_node": "6e3e4964-4439-4cbb-8e49-0baf1a006532",
"srx-protocol-id": "17",
"timestamp": "2017-09-06 08:25:37.339",
"level": -1,
"streams": [
"000000000000000000000001"
],
"message": "Apr 3 20:34:18 <IP_ADDRESS> 1 2017-04-03T20:34:17.602Z compt RT_FLOW - RT_FLOW_SESSION_DENY [junos@ source-address="<IP_ADDRESS>" source-port="56453" destination-address="<IP_ADDRESS>" destination-port="17075" service-name="None" protocol-id="17" icmp-type="0" policy-name="default-deny" source-zone-name="corporate" destination-zone-name="highwinds-inet" application="UNKNOWN" nested-application="UNKNOWN" username="N/A" roles="N/A" packet-incoming-interface="xe-4/0/1.10" encrypted="UNKNOWN" reason="policy deny"]",
"src-icmp-type": "0",
"srx-source-port": "56453",
"srx-policy-name": "default-deny",
"srx-rt-flow": "RT_FLOW_SESSION_DENY",
"srx-destination-zone-name": "highwinds-inet",
"facility": "Unknown",
"srx-source-address": "<IP_ADDRESS>"
}
}

@quintanilhar
I modified the config.php as per the schema still no luck .
 # Configuration for the logstash index that 411 queries.
    'logstash' => [
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => 'graylog_0',
        'date_based' => false,
        'date_interval' => 'null',
        'date_field' => 'timestamp',
        'date_type' => null,
        'src_url' => null,
    ],

Try null without quotes for date_interval like this:
'graylog' => [ // You can rename this by something that make more sense to you
        'hosts' => ['http://<IP_ADDRESS>:9200'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => 'graylog_0',
        'date_based' => false,
        'date_interval' => null,
        'date_field' => 'timestamp',
        'date_type' => null,
        'src_url' => null,
    ],

It may works now. :)

I've tried this approach and it works for me:

:)

@quintanilhar
I'm tired of trying everything. Nothing working out. I'm using a docker to launch the 411 console.  Still the health status is red .

Make sure you've mounted the data volume appropriately. From your screenshots, 411 is using a default config file and not your modified one.

i am getting below error:
Error: Uncaught TypeError: Cannot use 'in' operator to search for 'success' in
Fatal error:  Uncaught Elasticsearch\Common\Exceptions\BadRequest400Exception in /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php:681
Stack trace:
#0 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(640): Elasticsearch\Connections\Connection->tryDeserializeError(Array, 'Elasticsearch\C...')
#1 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(561): Elasticsearch\Connections\Connection->tryDeserialize400Error(Array)
#2 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(262): Elasticsearch\Connections\Connection->process4xxError(Array, Array, Array)
#3 /var/www/411/vendor/react/promise/src/FulfilledPromise.php(25): Elasticsearch\Connections\Connection->Elasticsearch\Connections{closure}(Array)
#4 /var/www/411/vendor/guzzlehttp/ringphp/src/Future/CompletedFutureValue.php(55): React\Promise\FulfilledPromise->then(Object(Closure), NULL, NULL)
#5 /var/www/4 in /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php on line 681
Here is my config.php file :
 [
        /**
         * Whether to enable proxy auth.
         * IT IS VERY INSECURE TO ENABLE THIS IF 411 is not run behind an auth proxy.
         */
        'enabled' => false,
        /**
         * The name of the header the proxy is setting.
         */
        'header' => null,
        /**
         * Whether to automatically create users who are authenticated.
         */
        'auto_create' => false,
        /**
         * Email domain for automatically created users.
         */
        'domain' => null,
    ],
    'api' => [
        /**
         * Whether to enable api access to 411.
         */
        'enabled' => true
    ]
];
/**
 * Database configuration
 */
$config['db'] = [
    /**
     * A PDO compatible DSN. See https://secure.php.net/manual/en/pdo.drivers.php for details.
     * SQLite is the default configuration but MySQL is also supported. To configure the latter,
     * you'll need a dsn like the following: 'mysql:host=localhost;dbname=fouroneone'.
     */
    'dsn' => 'sqlite:' . realpath(__DIR__ . '/data.db'),
    /**
     * The user name for connecting to the database.
     */
    'user' => 'root',
    /**
     * The password for connecting to the database. Optional if the PDO driver doesn't
     * require a password.
     */
    'pass' => null,
];

/****
 *
 * Search type configuration
 * Note: All hostnames should specify protocol!
 *
 ***/
/**
 * Elasticsearch search type
 */
$config['elasticsearch'] = [
    /**
     * Each entry in this array represents an Elasticsearch source that 411 can query.
     *
     * 'hosts': An array of hosts powering your ES cluster.
     * 'index_hosts': An array of hosts to use for indexing (if different from 'hosts').
     * 'ssl_cert': Path to an ssl certificate if your cluster uses HTTPS.
     * 'index': The index to query. Leave as null to query all indices.
     *          If the index is date_based, accepts index patterns. (Otherwise, it's taken literally)
     *          Any characters wrapped by [] will be taken literally.
     *          All other characters are interpretted via PHP's date formatting syntax.
     *          See https://secure.php.net/manual/en/function.date.php for details.
     * 'date_based': Whether to generate an index name according to a date-based index pattern.
     * 'date_interval': If the index is date_based, this defines the indexing pattern interval.
     *                  'h' - Hourly.
     *                  'd' - Daily.
     *                  'w' - Weekly.
     *                  'm' - Monthly.
     *                  'y' - Yearly.
     * 'date_field': The field to use for doing date-based queries.
     * 'date_type': The format of the date field.
     *              null - Automatically detect and parse. Should work most of the time!
     *              '@' - Parse as a UNIX timestamp.
     *              '#' - Parse as a UNIX timestamps (in milliseconds).
     *              All other strings are interpretted via PHP's date formatting syntax.
     * 'src_url': A format string for generating default source links.
     *            Requires the following format specifiers: 's', 'd', 'd'.
     *            Ex: 'https://localhost/?query=%s&from=%d&to=%d'
     */
    # Configuration for the 411 Alerts index.
    'alerts' => [
        'hosts' => ['https://de6e6e67a5feaafbb98e8e2b610c8954.us-east-1.aws.found.io:9243'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => null,
        'date_based' => false,
        'date_interval' => null,
        'date_field' => 'alert_date',
        'date_type' => null,
        'src_url' => null,
    ],
    # Configuration for the logstash index that 411 queries.
    'logstash' => [
        'hosts' => ['https://de6e6e67a5feaafbb98e8e2b610c8954.us-east-1.aws.found.io:9243'],
        'index_hosts' => [],
        'ssl_cert' => null,
        'index' => '[cidbpurchases]Y.m.d',
        'date_based' => true,
        'date_interval' => 'd',
        'date_field' => '@timestamp',
        'date_type' => null,
        'src_url' => null,
    ],
];

/**
 * Graphite
 *
 * Configure to allow querying Graphite.
 */
$config['graphite'] = [
    /**
     * Each entry in this array represents a Graphite source that 411 can query.
     *
     * 'host': The hostname for your Graphite instance.
     */
    'graphite' => [
        'host' => null,
    ],
];
/**
 * ThreatExchange
 * See https://developers.facebook.com/products/threat-exchange for details.
 *
 * Configure to allow querying ThreatExchange.
 */
$config['threatexchange'] = [
    /**
     * The api token for connecting to ThreatExchange.
     */
    'api_token' => null,
    /**
     * The api secret for connecting to ThreatExchange.
     */
    'api_secret' => null,
];

/****
 *
 * Target configuration
 *
 ***/

/**
 * Jira
 *
 * Fill in to enable Jira integration.
 */
$config['jira'] = [
    /**
     * The hostname for your Jira instance.
     */
    'host' => null,
    /**
     * The username for connecting to Jira.
     */
    'user' => null,
    /**
     * The password for connecting to Jira.
     */
    'pass' => null,
];
/**
 * Slack
 *
 * Fill in to enable Slack integration.
 */
$config['slack'] = [
    /**
     * A webhook url to push Alerts to.
     * See https://api.slack.com/incoming-webhooks for details.
     */
    'webhook_url' => null
];

Hello,
I am using docker image 411-latest, i change config.php file under /data dir,
`<?php
/**

411 configuration file

Rename this to 'config.php' and modify.
*/
$config = [];

/**

Authentication configuration
/
$config['auth'] = [
'proxy' => [
/*
* Whether to enable proxy auth.
* IT IS VERY INSECURE TO ENABLE THIS IF 411 is not run behind an auth proxy.
/
'enabled' => false,
/*
* The name of the header the proxy is setting.
/
'header' => null,
/*
* Whether to automatically create users who are authenticated.
/
'auto_create' => false,
/*
* Email domain for automatically created users.
/
'domain' => null,
],
'api' => [
/*
* Whether to enable api access to 411.
/
'enabled' => true
]
];
/*
Database configuration
/
$config['db'] = [
/*

A PDO compatible DSN. See https://secure.php.net/manual/en/pdo.drivers.php for details.
SQLite is the default configuration but MySQL is also supported. To configure the latter,
you'll need a dsn like the following: 'mysql:host=localhost;dbname=fouroneone'.
/
'dsn' => 'sqlite:' . realpath(DIR . '/data.db'),
/*
The user name for connecting to the database.
/
'user' => 'root',
/*
The password for connecting to the database. Optional if the PDO driver doesn't
require a password.
*/
'pass' => null,
];

/****
*

Search type configuration
Note: All hostnames should specify protocol!

*/
/

Elasticsearch search type
/
$config['elasticsearch'] = [
/*

Each entry in this array represents an Elasticsearch source that 411 can query.

'hosts': An array of hosts powering your ES cluster.
'index_hosts': An array of hosts to use for indexing (if different from 'hosts').
'ssl_cert': Path to an ssl certificate if your cluster uses HTTPS.
'index': The index to query. Leave as null to query all indices.

     If the index is date_based, accepts index patterns. (Otherwise, it's taken literally)

     Any characters wrapped by [] will be taken literally.

     All other characters are interpretted via PHP's date formatting syntax.

     See https://secure.php.net/manual/en/function.date.php for details.

'date_based': Whether to generate an index name according to a date-based index pattern.
'date_interval': If the index is date_based, this defines the indexing pattern interval.

             'h' - Hourly.

             'd' - Daily.

             'w' - Weekly.

             'm' - Monthly.

             'y' - Yearly.

'date_field': The field to use for doing date-based queries.
'date_type': The format of the date field.

         null - Automatically detect and parse. Should work most of the time!

         '@' - Parse as a UNIX timestamp.

         '#' - Parse as a UNIX timestamps (in milliseconds).

         All other strings are interpretted via PHP's date formatting syntax.

'src_url': A format string for generating default source links.

       Requires the following format specifiers: 's', 'd', 'd'.

       Ex: 'https://localhost/?query=%s&from=%d&to=%d'

*/
Configuration for the 411 Alerts index.
'alerts' => [
'hosts' => ['https://de6e6e67a5feaafbb98e8e2b610c8954.us-east-1.aws.found.io:9243'],
'index_hosts' => [],
'ssl_cert' => null,
'index' => null,
'date_based' => false,
'date_interval' => null,
'date_field' => 'alert_date',
'date_type' => null,
'src_url' => null,
],
Configuration for the logstash index that 411 queries.
'logstash' => [
'hosts' => ['https://de6e6e67a5feaafbb98e8e2b610c8954.us-east-1.aws.found.io:9243'],
'index_hosts' => [],
'ssl_cert' => null,
'index' => '[cidbpurchases]Y.m.d',
'date_based' => true,
'date_interval' => 'd',
'date_field' => '@timestamp',
'date_type' => null,
'src_url' => null,
],
];

/**

Graphite

Configure to allow querying Graphite.
/
$config['graphite'] = [
/*

Each entry in this array represents a Graphite source that 411 can query.

'host': The hostname for your Graphite instance.
/
'graphite' => [
'host' => null,
],
];
/*

ThreatExchange
See https://developers.facebook.com/products/threat-exchange for details.

Configure to allow querying ThreatExchange.
/
$config['threatexchange'] = [
/*

The api token for connecting to ThreatExchange.
/
'api_token' => null,
/*
The api secret for connecting to ThreatExchange.
*/
'api_secret' => null,
];

/****
*

Target configuration

***/
/**

Jira

Fill in to enable Jira integration.
/
$config['jira'] = [
/*

The hostname for your Jira instance.
/
'host' => null,
/*
The username for connecting to Jira.
/
'user' => null,
/*
The password for connecting to Jira.
/
'pass' => null,
];
/*

Slack

Fill in to enable Slack integration.
/
$config['slack'] = [
/*

A webhook url to push Alerts to.
See https://api.slack.com/incoming-webhooks for details.
*/
'webhook_url' => null
];
`
i am getting below error :

Error: Uncaught TypeError: Cannot use 'in' operator to search for 'success' in <br /> <b>Fatal error</b>:  Uncaught Elasticsearch\Common\Exceptions\BadRequest400Exception in /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php:681 Stack trace: #0 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(640): Elasticsearch\Connections\Connection->tryDeserializeError(Array, 'Elasticsearch\\C...') #1 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(561): Elasticsearch\Connections\Connection->tryDeserialize400Error(Array) #2 /var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php(262): Elasticsearch\Connections\Connection->process4xxError(Array, Array, Array) #3 /var/www/411/vendor/react/promise/src/FulfilledPromise.php(25): Elasticsearch\Connections\Connection->Elasticsearch\Connections\{closure}(Array) #4 /var/www/411/vendor/guzzlehttp/ringphp/src/Future/CompletedFutureValue.php(55): React\Promise\FulfilledPromise->then(Object(Closure), NULL, NULL) #5 /var/www/4 in <b>/var/www/411/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Connections/Connection.php</b> on line <b>681</b><br />
Can you please help me?


New option: --external-css-file

Fixes #34.
This is a prototype that I expect to need to fix before it gets merged.
Missing bits:

[ ] diff-quality should probably also support --external-css-file
[x] tests

I'm also not very fond of duplicating some CSS rules between external-style.css and snippet_style.html.
Test plan:

ran tox (tried detox, but your test suite doesn't support parallel execution due to writing to the same hardcoded filenames!)
installed it locally (virtualenv .venv && .venv/bin/pip install -e .)
ran .venv/bin/diff-cover coverage.xml --html /tmp/diff-cover.html --external-css /tmp/diff-cover.css
inspected /tmp/diff-cover.* with a text editor and tried it out in a browser

A hint about the best way to test this would be nice.  test_integration.py perhaps, with a new call to self._check_html_report() and a new expected .html file in the fixtures directory/, while reusing an existing git diff fixture?

Testing in test integration is fine. The whole project is a pretty small flow. So I don't mind most of the tests being higher level.
One thing to keep in mind is that I recently changed it so the tests dont look at CSS. This is because pygments changes its CSS from time to time and I got tired of fixing the tests for that. So will need to think of some way of checking the correct css was applied. Simply checking one of your classes is there would likely be enough.

Pushed a test.
I don't know how I feel about adding this feature to diff-quality too.  On the one hand, it feels lopsided to have two similar tools one of which can be used in Jenkins, and one can't.  On the other hand, I've never actually used diff-quality, so my motivation is low, and I've no test plan.
Some gentle encouragement could help.  ;)

@mgedmin Id certainly appreciate it. I mean you basically laid out the reasons.
The test plan and quite frankly the implementation would be fairly similar. In fact you are part of the way there best I could tell :-P

Test plan for diff-quality:

installed it locally (virtualenv .venv && .venv/bin/pip install -e . && .venv/bin/pip install flake8)
ran .venv/bin/diff-quality --violations flake8 --html /tmp/diff-cover.html --external-css /tmp/diff-cover.css
inspected /tmp/diff-cover.* with a text editor and tried it out in a browser
wrote integration test based on the one I made for diff-cover
ran tox

Ill review and likely merge this weekend. Release should be sometime in the next week or two as I am still hoping to get some feedback from people at edx about some major refactoring that happened

:+1:

Ill release this in the next week or two. Feel free to harass me if I forget.

This is released! https://pypi.python.org/pypi/diff_cover/0.9.0

Thanks @mgedmin for the PR and the detailed info on the test plan :-)


Question mark added after the first letter of some menu items

I noticed a question mark is added after the first letter of some menu items:

Note this was tested with MonoDevelop + Linux + Civ v 475.01. (Will test again with 475.05 if can find it.)

Also experienced by Lord_Hill:
https://forums.civfanatics.com/threads/rewrite-of-civilization-1-source-code-open-civilization-1-project.682623/page-5#post-16512034

Fixed as of last commit