Update README with how to use chrome black boxing feature to show original log line

Hi,
I think it is worth mentioning in the README about chrome's black boxing feature that allows seeing the original code line of the debug log.

Can you elaborate on this?  Lets assume that folks looking at this issue aren't familiar with the "Chrome black boxing feature" ... where should we go to read more about this?  Do you have a suggestion for the content that should be added to the README.md file?

I also didn't know about black boxing. I encountered it on this link:
https://gist.github.com/paulirish/c307a5a585ddbcc17242
Here is the official chrome documentation for this feature:
https://developer.chrome.com/devtools/docs/blackboxing
Basically, to make it work for the debug package, you need to:

go into setting of your chrome dev tools (available in the chrome dev tools menu, not chrome's menu)
click on the Blackboxing tab
Add 2 patterns:

/debug/browser.js
/debug/debug.js

That's it, from now on you can see the original line numbers (and file) of your debug logs.
I just added patterns of file names that I saw next to logs that I have made with debug. I guess the pattern path, might be depending on the way you pack your code, I was using web pack in dev mode.
I guess you should test it, and review before you paste this to the README.
Cheers
Erez

@hepiyellow Thank you very much, that's exactly what I was looking for. I was kinda annoyed to see the browser.js on every log line. Really recommend to everyone.


add iceberg check namespace exists api

PR Checklist

[X] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[X] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes

adds support for the HEAD /v1/namespaces/{namespace} endpoint
modifies the HEAD /v1/namespaces/{namespace}/tables/{table} endpoint to respond with an http response code of 204 as per spec
modifies the GET /v1/namespaces and GET /v1/namespaces/{namespace} endpoints to respond with an http response code of 400 if the namespace is invalid; contains more than two parts
fixes the ordering of the "actual" and "expected" arguments for asserting http response codes in IcebergRestCatalogTest.java

hey, I'd like to work on adding support for the iceberg api endpoints that are listed here if that's okay. I've started with one of the more simpler endpoints just to get a feel of the codebase.


Not possible to map enum to enum, or data class containing aggregated enums

Im trying to create mapping for class containing enums.
Direct mapping enum to enum doesnt work because : Could not find a no-arg constructor or object supplier for class
I tried with supplier, but supplier takes no arguments - it doesn't make sense because we can't have empty enum , it should be constructed from string parameter
// source enum
@DefaultMappingTarget (Operation.class)
enum class OperationDto {
   AND, OR, XOR ;

    companion object {
        fun from(value: String) = values().find { it.name.equals(value, ignoreCase = true) }
    }
}

// target enum
enum class Operation {
    AND, OR, XOR ;

    constructor()

    companion object {
        fun from(value: String) = values().find { it.name.equals(value, ignoreCase = true) }
    }

}

I tried different way - in the outer class which aggregated enum, added custom transformer :
data class OuterClass (
    @MappedField(transformer = OperationTransformer::class)
    val operation: OperationDto
)

class OperationTransformer : MappingTransformer<OperationDto, Operation> {
    override fun transform(context: MappingTransformerContext<out OperationDto>): Operation? {
       return Operation.from(context.originalValue?.toString() ?: "") // maps one enum value to other via string
    }
}

Now I have different error, Could not find transformer by type [class OperationTransformer]

I don't know how you instantiated ShapeShift so it's possible you also did not declare the transformer for ShapeShift, but I see one apparent issue from your code;
You put @DefaultMappingTarget on your enum. It doesn't belong there, instead you should put it on the class where you are declaring the mappings. OuterClass in your case. (Relevant documentation)
In any case, here is a working example with enum mapping, let me know if you have any questions. (Gist)
import dev.krud.shapeshift.ShapeShiftBuilder
import dev.krud.shapeshift.resolver.annotation.DefaultMappingTarget
import dev.krud.shapeshift.resolver.annotation.MappedField
import dev.krud.shapeshift.transformer.base.MappingTransformer
import dev.krud.shapeshift.transformer.base.MappingTransformerContext

enum class OuterOperation { AND, OR, XOR }

enum class InnerOperation { AND, OR, XOR }

@DefaultMappingTarget(InnerClass::class)
data class OuterClass (
    @MappedField(transformer = OperationTransformer::class)
    val operation: OuterOperation
)

data class InnerClass(
    val operation: InnerOperation
)

class OperationTransformer : MappingTransformer<OuterOperation, InnerOperation> {
    override fun transform(context: MappingTransformerContext<out OuterOperation>): InnerOperation? {
        return InnerOperation.valueOf(context.originalValue?.toString() ?: "")
    }
}

fun main() {
    val shapeShift = ShapeShiftBuilder()
        .withTransformer(OperationTransformer())
        .withObjectSupplier { OuterClass(OuterOperation.AND) }
        .withObjectSupplier { InnerClass(InnerOperation.AND) }
        .build()
    val innerClass = shapeShift.map<OuterClass, InnerClass>(OuterClass(OuterOperation.OR))
    println("Operation: ${innerClass.operation}")
}

thanks for quick response.
yes it works if I add every transformer into the BuilderList
I supposed that if transformer is mentioned in the annotation : @MappedField(transformer = OperationTransformer::class), it is enough.

Hi, can you please give me a clue, why collection transformation of aggregated type doesn't work?
The mapping goes like this:  FilterRequestDto -> FilterRequest, FilterDto - > Filter
@DefaultMappingTarget(FilterRequest::class)
data class FilterRequestDto(
    @MappedField
    val layers: List<String> = emptyList(),

    @MappedField(transformer = ImplicitCollectionMappingTransformer::class)
    val filters: List<FilterDto> = emptyList(), // corresponds to List<Filter> in other class
)

the aggregated type in the collection also has it's own mapping
@DefaultMappingTarget(Filter::class)
data class FilterDto(
    @MappedField
    val layerId: String? = null
   /// .......
)

when I do the converstion:
        val shapeShift = ShapeShiftBuilder()
            .withTransformer(ImplicitMappingTransformer())
            .withTransformer(ImplicitCollectionMappingTransformer())
            .build()
        val obj: FilterRequest = shapeShift.map(requestDto)

the collection in the target object has elements of type "sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl", instead of Filter.
Should be mapped from List to List
without list, if I use it as scalar type, the transformation works.
Am I missing something?

@victormikhailov77
Seems to have been a bug with the transformer, please try with 0.8.0.
Also, shouldn't need to declare it anymore as it's a default transformer (another bug)

Yes, the bug fixed, confirmed.
Thanks a lot! Your level of support is the best.
Im migrating project from mapstruct-kotlin to ShapeShift, because mapstruct-kotlin is abandoned, and not supported in future Kotlin versions.

Good luck! We hope ShapeShift will serve you well. If you find any bugs or think of additional features you would like let us know.


BS4 test separation

This is the result of a quick spike on how to do the separate tests story. The idea here is:

you can override the bootstrap version setting (usually specified in ember-cli-build.js) via the environment variable BOOTSTRAPVERSION.
This is not to be used by normal users, but allows us to have a build with a specific version: BOOTSTRAPVERSION=4 ember test. This could be added to an ember-try scenario
there is a test helper in tests/helpers/bootstrap-test.js that accepts an optional version number as first argument. If not specified runs test with any version (for tests that are the same regardless of BS version), if specified runs test if the version matches, skips otherwise
See the slightly modified test file for bs-button

@srvance what do you think?

This is a very clever approach. It can cover all of our cases and is simple to use. I like it.
In some of the tests where only the class changes, like with the transition from in to show, should we also have a helper that gives you finer control, e.g., versionDependent(bs3Value, bs4Value) or versionDependent({3: bs3Value, 4: bs4Value})? It probably needs a better name than my examples and wouldn't be as well tagged in the output.

Regarding the versionDependent thing: would be pretty easy to make that happen. But I am not so sure we really should. The next thing would maybe the desire to have the bootstrap version available as a var, to make conditionals etc. But that's putting too much into the tests I think. For the tests I think we can be a bit loose about things like DRY, and just duplicate. I case we drop BS3 some time, the tests can stay the same, no cleanup needed.
Just my first thought though, I am certainly not dogmatic about that...

Let's keep it simple for now. If we have too much duplication or boilerplate around the differences, we can address it then. As you pointed out above with the environment, this is really internal to the project.

Just updated the test functions to use the more verbose testBS3/testBS4...

Looks good to me.

Thanks for reviewing, merged.


jenkins-autojobs creates additional description elements for non-Freestyle projects

We have a template based on a Maven project that has a description filled in. The fix in 0619831 for Issue #54 causes an additional <description> element to be inserted prior to the one that exists for the Maven project template.
<?xml version="1.0" encoding="UTF-8"?><maven2-moduleset<EMAIL_ADDRESS>  <actions/>
  <description>
(created by jenkins-autojobs)
(jenkins-autojobs-tag: amplisequi-ci-autojobs)</description><description>
ACME UI CI Build
</description>
  <keepDependencies>false</keepDependencies>
  <properties>
    <jenkins.model.BuildDiscarderProperty>
…

The expected behavior is that
(created by jenkins-autojobs)
(jenkins-autojobs-tag: amplisequi-ci-autojobs)

would be appended to the existing <description> element's contents.
This is also causing jenkins-autojobs to fail to delete jobs when branches get deleted from the remote repository.
Would it be reasonable to search for the first <description> element in the XML document, both during the creation and deletion stages?

We have the same problem in our installation.
I had a closer look at the change in https://github.com/gvalkov/jenkins-autojobs/commit/0619831e4809ba7807b6fea575febdcefacc8b95. I think it solved issue #54  not because of the changed xpath but because of the desc_el null handling.
But this null handling is the reason that an additional <description> is created.
In maven based projects, there is no /project element at the document root. They start with /maven2-moduleset. The description is unter /maven2-moduleset/description. The xpath expression will never find the description. And jenkins removes the doubled description whenever a job is modified (same problem as with the custom tag).
I attached a patch for jenkins_autojobs/job.py with a changed xpath expression. At least in our installation that solves this issue, but we only manage maven based jobs with autojobs. Someone has to verify that this is also working with other job types.
patch.zip

Hello @gotgenes and @lxndrhnz and thank you both for the good write up. I've made a fix, that should at least make it work reliably with freestyle and maven projects: 4adcccf8a68823116cc96216ef76f10347adf4a5
I'll roll out a new release as soon as I get some more testing done. Any help with testing would be greatly appreciated. Fiy, the development tip can be installed with:
pip install -U git+git://github.com/gvalkov/jenkins-autojobs.git@4adcccf8a68823116cc96216ef76f10347adf4a5

Hi @gvalkov. Thanks for your response. I have concern that this change
for parent_xpath in '//maven2-moduleset', '//project':

will become brittle. It is hard to say there are not other styles of projects that have other root elements.
I go back to my question above:

Would it be reasonable to search for the first <description> element in the XML document, both during the creation and deletion stages?

It would be brittle indeed - I implemented your proposal in 06f91960a3c486b14e5fbbcc9ccafc4d69481b71 alongside the previous workaround.

I'm starting to think that #54 was also about a maven job. It would be nice to assume that a job's config.xml always has a description element, in which simply searching for the first 'description' element should be the only necessary solution.

I just wanted to clarify, that it's not the fault of jenkins-autojobs this is brittle. There are a couple of reasons this is a tough problem to tackle:

jenkins-autojobs started with a sensible idea of adding its own element (tag) to the jenkins' jobs. Unfortunately, it seems this violates some sort of XML schema for the jobs, and causes Jenkins to complain loudly that one or more jobs are in an unexpected format (screenshot below)

My guess is this motivated co-opting some existing element, and I believe @gvalkov's choice of co-opting the <description> element is the best.
Unfortunately, the Maven plugin authors have taken liberty with the schema of the Jenkins jobs, and do not follow the same schema as the "Freestyle Job" for Jenkins. There isn't much the jenkins-autojobs authors can do about this. "The cat is out of the bag," as they say.

So the question now is, what's the least fragile thing jenkins-autojobs can do to support these variances from the expected XML schema.
Here's the list of project types we have available in our current Jenkins configuration right now:

Freestyle project
Maven project
External Job
Multi-configuration project

The only two I've matched up with jenkins-autojobs to date are Freestyle and Maven. I'm not sure what the schemas for the other two look like; that is, I don't know if Maven is a rogue, or if each of them have their own schemas. I'll have to check that out.
If you want to try a more structured approach, we could define a Job class for each different project type (like FreestyleJob, MavenJob, etc.), and use polymorphism to just call the respective instance's job.set_description(), job.get_description() (or make it a property). I don't know how much architecture you want to put into this project, though.

@gvalkov 06f9196 appears to have resolved the issue for our Maven project jobs. The existing description element is now being modified instead of a new one being created. Thanks!

Hi @gotgenes. Thank you for taking the time to test the change and for doing such a great write up on the core issue. I've pushed the fix to PyPi with jenkins-autojobs 0.17.4.

I must admit that the project is starting to suffer a bit from the lack of architecture. I wish I could sit down and redesign parts of it, but lately I've only had time for bug fixing.

@gvalkov You do not have to apologize. You have contributed this project. The changes here fixed the issue, and jenkins-autojobs already provides value to its users.

Hi,
the fix solved this issue for us. Thank you very much.
Nevertheless let me share my thoughts about the curent solution with you.
It's not autojobs fault that plugin authors introduced own schemas and you have to know all of their specials.
The current solution solves this with iterating trough all "currently known" config root elements and looking for a description on the next level.
Good thing: It's easy to extend the list of known roots.
Bad thing: You have to extend the list of known roots for evert project type.
Educated guess: No plugin author will create a config that doesn't support a description on this level because displaying the projects (whatever type) description is an essental part of jenkins view on a project. On the other hand multiple description elements on this level are unlikely and not supported by jenkins (see my comment above, jenkins removes duplicate descriptions).
Based on this you can simplify and generalize your solution by using the following xpath expression for selecting the description element on the first level of the config.xml instead of iteration through all "known roots".
/*/description
You don't have to change the way you solved this. I just wanted to throw this idea in for discussion.
Thanks again for this cool project and fixing the bugs that fast.


FEATURE - Add deployment writer module to support adding ABAP deployment configuration

As a developer using SAP Fiori tools, I want to add ABAP deployment configurations to my app, so that I am able to deploy my app to an ABAP target system.
Technical Design
New module :

@sap-ux/deployment-writer

Acceptance Criteria
Given I have a Fiori project with no ABAP deployment configuration
when I invoke this writer with the correct data
then the ABAP deployment configuration will be added to my Fiori project
Notes
Tasks

[ ] Unit Tests added
[ ] Test Cases defined

Closing as writer is published


Realtime Database Sample

Do you have any plans about Realtime Database sample?

I do! Database and Storage will have sample projects made available shortly.
In the mean time you can also look at the Firebase C++ QuickStart Samples to get an idea of how to use the library.

ok, thanks!

Just checked in a Firebase Realtime Database sample app. A Firebase Storage sample is on the way too.


Some changes

1 - I added .venv to the .gitignore file. When I use virtualenv I do virtualenv .venv so I had to add this to the .gitignore
2 - Changed databases to use sqlite3. It will not affect if you try to use with postgresql.
3 - If the user wants to run with Debug=False it will have to run first the collectstatic command.

1 - I added .venv to the .gitignore file. When I use virtualenv I do virtualenv .venv so I had to add this to the .gitignore

That's great to have a virtualenv default in our .gitignore, thanks! (I forgot because I'm used to virtualenvwrapper…)

2 - Changed databases to use sqlite3. It will not affect if you try to use with postgresql.

Great. Personally I avoid as when importing. I think it makes the code less explicit. It's just a personal opinion, feel free to disagree. Would you mind if in further refactors we remove the alias?

3 - If the user wants to run with Debug=False it will have to run first the collectstatic command.

That's a valuable reminder. Many thanks!
I'd just move it to the another section (collectstatic does not belong to Migrations). Maybe running it too late (at Accessing Valentina) would break the check, have you tested? If so, I suggest moving it to the Settings part. Or alternatively crate anther section just for the collect static thing.
What do you think about this third topic? Once we decide it, I can merge and (if that's the case), relocate the instructions you added.

Great. Personally I avoid as when importing. I think it makes the code less explicit. It's just a personal opinion, feel free to disagree. Would you mind if in further refactors we remove the alias?

We can refactor and remove the alias further without any problem

I'd just move it to the another section (collectstatic does not belong to Migrations). Maybe running it too late (at Accessing Valentina) would break the check, have you tested?

Yes..it did break the test when I tested. Please feel free to relocate the instructions.


Fix-issue44735-pagesize parameter

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


Add the docker-distribution snap

[x]   File: docker-distribution/snapcraft.yaml:L1-25
 Please enclose this with "" to force a string (to follow our conventions)
[x]   File: docker-distribution/snapcraft.yaml:L1-25
 We tend to set them in that order:

source:
source-options:
plugins:
plugins-options:

Mind reordering this to follow those?

[x]   File: docker-distribution/snapcraft.yaml:L1-25
 Please add .git to source and remove source-type then.
[ ]   General Comment
 Great work! This looks good to me :)
Are you going to continue on this to try removing devmode before we merge? I know @LyzardKing worked on some docker snap as well, maybe you can both work together to get that working?

This pull request is now managed with CodeReviewHub. Refresh.

Great work! This looks good to me :)
Are you going to continue on this to try removing devmode before we merge? I know @LyzardKing worked on some docker snap as well, maybe you can both work together to get that working?

I pushed all your suggested changes @didrocks. Thanks for the review.
The direction I got was to write as many snaps as possible in devmode, and then try to get them to strict, so I wasn't planning to spend much more time on this one on the short term. I will revisit it when I have some free time. So I would say that's better to get it merged, but I'm also ok with leaving it in a PR.


Machined parts

The show-stopper for me is the requirement for machined parts. Not everyone has access to the necessary equipment to make these (or the skills to use it).
Can anyone suggest how to source these parts (preferably in Europe)?

You'll want to search for machine shops in your region and ask for quotes.
The machining of the pulleys becomes easier if you provide a custom form cutter for the tooth geometry. For that you'll first have to find a tool manufacturer that can produce the custom form cutter: https://github.com/open-dynamic-robot-initiative/open_robot_actuator_hardware/blob/master/mechanics/actuator_module_v1/details/details_machined_parts.md#option-a---form-cutter
Alternatively you could request a quote from an online manufacturing service.
We haven't tried this yet so we have no experience regarding the quality and cost - but we'll be looking into this topic soon.
Here are some companies that we found:
https://www.rapiddirect.com/
https://www.facturee.de/en/about-us/

Thanks for the advice and links.


Open internal browser method

Hi,
please add a method to open internal browser.
async def open_internal_browser(self, url, cookies=None, js=None)

For humblebundle plugin this would be useful to open keys page for logged-in user where you can redeem your games for other platforms like Steam. hb issue
Furthermore, this will allow to avoid plugin authors to code its owned GUI's (hb issue), and even run webrowser games (?)

If a plugin needs a browser functionality, the best would be to redirect the user to the system browser. This would be both safer, more transparent and convenient for the user, as he might already have his accounts logged there, passwords saved, extensions installed etc.
The idea behind internal browser was to keep it isolated, small and lean, and server a single purpose: open a page and give back all its content. While with what you suggest we'll end up re-implementing a whole browser inside the GLX.

Thanks, I understand the security reasons. I'll open default browser instead.


[training] katacoda repo at falcosecurity

Describe the bug
(Not a bug, but there's not a better category for this issues). We detected that O'Reilly closed down last month the free service that we used to host the labs here: https://github.com/falcosecurity/katacoda-scenarios
Hence, none of this content is available any more. I suggest to archive this repository for now.
How to reproduce it
Just visit katacoda.com or any of the labs.
Expected behaviour
Additional context

/kind documentation

/kind cleanup

If the content is no more available, I see no point in leaving the repo open! +1 for archiving it, thanks @pabloopez!

As discussed during yesterday's community call, there's no way this repository can continue to work since https://www.katacoda.com/ is now closed. Thus, I'm going to archive the repo soon.
Anyway, I want to say thank you to @pabloopez , for the great job he did with Katacoda :clap:


No suitable servers found (serverSelectionTryOnce set): [TLS handshake failed (Certificate trust failure: CSSMERR_TP_CERT_SUSPENDED) calling hello on 'xxx.mongo.ondigitalocean.com:27017']

Laravel-mongodb Version: 3.9.2
PHP Version: 8.1.12
Database Driver & Version: mongodb 1.15.0 stable

Description:
Trying to connect to MongoDB on DigitalOcean and it fails every time with this error.
Steps to reproduce

Set up config.

DB_DSN=mongodb+srv://user:pass@xxx.mongo.ondigitalocean.com/db_name?tls=true&allowConnectionsWithoutCertificates=true&authSource=admin&tlsCAFile=

        'mongodb' => [
            'driver' => 'mongodb',
            'dsn' => env('DB_DSN').storage_path('ca-certificate.crt'),
            'database' => env('DB_DATABASE', 'homestead'),
        ],

Set up 1 model with connection property.
Run insert method or get method.

Expected behaviour
Should connect to MongoDB and read/write documents to the database.
Actual behaviour
Throws an exception "No suitable servers found (serverSelectionTryOnce set): [TLS handshake failed (Certificate trust failure: CSSMERR_TP_CERT_SUSPENDED) calling hello on 'xxx.mongo.ondigitalocean.com:27017']"

This error is not related to the Laravel integration, but rather with the system you're running on. A quick search for the error led me to SERVER-45015, which details the same error as you are receiving. In that ticket, OP was connecting from a MacOS machine which ultimately was the culprit. Can you confirm whether you are running on MacOS? If so, the following requirement seems to have cause the issue (copied from here):

TLS server certificates must have a validity period of 825 days or fewer (as expressed in the NotBefore and NotAfter fields of the certificate).

If you are indeed connecting from MacOS, could you please try to connect from a different OS to see if you can establish a connection from there? Note that you should not have to connect from Laravel to test for this error, but establishing a connection from the MongoDB Shell would also expose the problem.

Thank you so much. I searched for a couple days for this error and couldn't find anything. Not sure how because I'm pretty sure this is exactly the issue. I ran the following command on the certificate that DigitalOcean provides.
[ ~ ]$ openssl x509 -enddate -noout -in ca-certificate.crt
notAfter=Aug 18 16:37:00 2041 GMT

Which is WELL over the 825 days. I have opened a ticket up with DigitalOcean to see what they might be able to do to help since it's a certificate that they provide.
Thanks!!


Is the usage of DistributedSampler correct?

https://github.com/microsoft/DeepSpeedExamples/blob/cd19b3bf1e5b60dd73b09c7463da4eedada1eed7/applications/DeepSpeed-Chat/training/step1_supervised_finetuning/main.py#L234
there are two parameters in DistributedSampler
        num_replicas (int, optional): Number of processes participating in
            distributed training. By default, :attr:`world_size` is retrieved from the
            current distributed group.
        rank (int, optional): Rank of the current process within :attr:`num_replicas`.
            By default, :attr:`rank` is retrieved from the current distributed
            group.

is the code correct when do not use these two paramters? will deepspeed handle this automatically for us?

When num_replicas and rank are not provided, DistributedSampler will by default retrieve them from torch.distributed.get_world_size() and torch.distributed.get_rank(), which are properly initialized by DeepSpeed. You can confirm it by printing the get_world_size() and get_rank() values.

thanks


Improvement for k8s.io/docs/tutorials/kubernetes-basics/

Would be handy to include "Remove Your App" instructions on this page.

/kind feature
/language en
/priority important-longterm
Nice idea!

/remove-lifecycle stale


OLS-155: Set project line length

Description
Implements project line length for 100.
See various threads about this topic

https://github.com/openshift/lightspeed-service/pull/96
https://redhat-internal.slack.com/archives/C068JAU4Y0P/p1704277149765139
https://redhat-internal.slack.com/archives/C068JAU4Y0P/p1705091283613439

Type of change

[X] Refactor

TODO
This is on hold until all PRs from today are merged. Once they are, I'll fix the rest of the errors.

[ ] Merge all PRs
[ ] Fix the rest of linting errors

This is on hold until all PRs from today are merged. Once they are, I'll fix the rest of the errors.

Mostly it looks ok, but IIRC @bparees insists on not to use noqa tricks

/lgtm
(but pls see my previous comment)

/approve
unfortunately needs a rebase

/lgtm


Warning at each start of the program on the presence of the tessdata subfolder

I place the traineddata file in a training folder.
At each start, the notice appears that the tessdata subfolder is present inside selected tesseract folder.

The warning is useful when selecting the Tesseract executables folder.
Is it possible to remove the check at startup?

Fixed in the new version. Thanks for the report.


Remove Earthquake from DSheetPiling code

Remove Earthquake from DSheetPiling python code and documentation because Earthquake was not used in calculation (for evaluation only) and it is now completely removed from DSheetPiling code itself.
Note that there is also an Earthquake in DStability (that must stay).

Related to MSH-4520 and MSH-4531


How to calculate the success rate and the problem of parameters.

Hi! After reading your paper and your code,I have some questions:
1.In the code about reinforcement learning,the success rate can be calculated when the statebatchsize =1 , because the the number of state to be predicted is 1, however in the imitation learning, because the statebatchsize is not 1, then a graph contains multiple states that need to be predicted synchronously.May I ask,how to calculate the success rate in the case where the number of states to be predicted is not 1?
2.According to your paper, some of the parameters are inconsistent with the code, such as RMSProp decay factor (0.999), initial value of exploration rate (0.3). Do these differences cause my results to fail to reach your experimental results? Are these parameters set according to the paper or the code?
Looking forward to your reply! Thank you!

Hi albzni,
Thank you for the feedback

you can change the statebatchsize more than 1 for testing, the success rate is defined as given a starting state, whether the agent could reach the goal state. We haven't try statebatchsize > 1 for testing cases, our experiment use one trial for each map. If you want to more statebatchsize for each testing map, what pops out my mind is you may need to tweak the code that using an external for loop to iterate different starting point instead using batch, since the trajectory length might be different.

The code shown RMSProp decay factor (0.999), initial value of exploration rate (0.3) is not the one we used in the paper. We haven't got time to clean the code, so that the code is very messy (Sorry about that), and some parameters are not correctly set. what we observe is that the exploration rate plays important roles, the exploration rate starting from 1 decaying to 0. Can you elaborate more on your failed experiments?

Hi,sufengniu.Thank you for your reply!
I ran irregular/IL/train.py and /irregular/RL/rl_nstep.py, and the results were Testing Accuracy: 89.29% and Current_Succ_Rate: 99.55%, Avg Difference: 0.071, Avg Reward: 0.969. These experimental results are quite different from the results shown in your paper, so I would like to ask: 1) How do you calculate the success rate, path difference and expected reward under the IL training algorithm shown in your paper? 2) If the training is performed with data of 100 nodes, is the parameter in the network changed? For example, "ch_q".
Looking forward to your reply!

Hello Albzni,
Sorry for very late reply, since I was extremely busy recently. I think the result you got is very similar to the original paper Table 2 embedding based kernel. Can you point out which part you think is quite anomaly?
Also, we found that this code is too mess, and part of code is re-usable and not reproduce-able. We are planning to re-write the code an integrate with some our current on-going work together. Please stay tuned.
Sufeng

Hi,sufengniu. Thank you for your reply!
I am very glad to hear that you are planning to re-write the code! Looking forward to your on-going work!
Is it convenient for you to provide the code of generating the graph? Because I want to do some tests on different graphs, such as 5 nodes, 20 nodes, etc. If you can provide it, this will help me a lot !
Thank your so much!

Thank you for providing GVIN code to make it easy to reproduce.

I take the success rate code in rl_nstep.py and port it to /irregular/IL folder, and most of experiments achieve similar results as the paper, but when we trained on 10 nodes and tested on 100 nodes, the success rate was 64.64%, much higher than the results in the paper (6.73%).
At the same time, I want to verify a problem: in IL, when the training set changes from 10 nodes to 100 nodes, the accuracy of the test set of 100 nodes has not been significantly improved (56.14%->58.90 %). If we provide more nodes during training or reduce the number of nodes during testing, can GVIN improve the prediction accuracy in the test set?
If it is convenient, could you provide a mat file that generates the data and the file to calculate the successful rate? So that I can verify the above problem by myself.

Hello @eccentricpzy  sorry for the late reply, recently, I was pretty busy.

ok, that is interesting, I need to check it whether where the mistake is. I did remembered that when using imitation learning, we encounter heavily overfitting. I need to double check on it

yes, we also observe this issue as well (the prediction accuracy is not improved when your training image is large). Here is the intuition: whether you train on the small graph or large graph, the graph embedding are all normalized between 0 to 1, and thereby the performance is actually not depends on the graph scale. To improve the prediction accuracy, I think two things might worth to look at: 1) GVIN is special case of graph neural network, which edge updates in GNN is kernel function in GVIN, we found that in many scenarios the P matrix sometime is not meaningful. you might want to see if using recurrent network to learn the P. 2) is the policy, unlike VIN, use max Q as policy, our last step use max V since the number of action keeps changing on different position, we haven't dig deeper into it, but I think this might be a problem in the irregular graph

the data generation is from another author, who is graduated, I can try to pin him see if he could share the code.

Hi @albzni
Sorry for the very late reply. the generation code actually is from my colleague mates, let me ask if he would share it, I will let you know and update it to the github, I think he used Matlab to generate it
Thank you

hi! thank you for upload your code. it's very useful for my research.
and i want to know can you upload the real world data(just like the New York datafile which in the paper)
it will help a lot, thank you.
best wish

Hi,sufengniu. Thank you for your reply! I'm very sorry for the late reply.
Thank you very much for helping me to ask your colleague mates! Hoping that he can share the generation code because it can help me a lot.  Looking forward to your reply!
Best wishes.

Hello @eccentricpzy sorry for the late reply,

this is a problem we also try to solve

i) you are right, it is normalized based on the node degree.

I have asked my collaborator, we missed that code. The code is based on random geometric graph using matlab, nothing fancy. Sorry about that.


feat(TFD-331): Add FixedFlowInput components under the family LocalIO.

Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Add a FixedFlowInput component.
This components take a JSON and its associated schema, then will create the associated IndexedRecord.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

Pull request test result: failure :x:

The build got some trouble, but at the end, it worked: https://ci-common.datapwn.com/job/components_pull-request_master/282/console

Pull request test result: success :star:

Pull request test result: failure :x:

I rebased master to integrate beam 0.4 modification available on master.
Sadly, this affect the history of the previous commit. At least, the comments are still present.

I don't know why there is no repport on that, but the build https://ci-common.datapwn.com/job/components_pull-request_master/365/console went successfully to the end.


Customize camera image cell with xib

I want to customize the camera image cell with xib.
I want you to add a setting that allows you to paste xib that you made in the camera cell part
I'd like to customize it like LINE app
https://video.twimg.com/ext_tw_video/920328582341079040/pu/vid/720x1280/95BpKP3xqc2YNvsT.mp4

@testfooyy
used custom camera cell
see the example
https://github.com/tilltue/TLPhotoPicker/blob/master/Example/TLPhotoPicker/CustomCameraCell.swift


feat/ improve NarrativeText detection for docx

Currently, the STYLE_TO_ELEMENT_MAPPING in partition/docx detects most elements as Text when plenty could be classified as NarrativeText.
There appears to be a check for NarrativeText in the _text_to_element function, but this check only occurs in the case of lists or when no element class is detected, which is not the case for documents identifiable with styled elements.
This enhancement is to further categorize Text elements classified via the STYLE_TO_ELEMENT_MAPPING into the more specific NarrativeText category, based on rules that would qualify it for that element type.

CC @scanny

@shreyanid After a close look I'm not seeing any "smoking gun" as to how potential NarrativeText would be slipping through en-masse. I wonder if you can provide an example document or two where something you thought should be NarrativeText was classified otherwise, that would help a lot to clarify what you're seeing and put our finger on a cause.
The current element-type assignment logic for a paragraph in a .docx file is this sequence:

Paragraph is a list-item. If the paragraph can be identified as a list-item, it gets type ListItem.

Paragraph has a differentiated paragraph-style. If the paragraph has been assigned a differentiated style from the Word document stylesheet/gallery, the type mapped in STYLE_TO_ELEMENT_MAPPING is used. A differentiated style is any style other than the default "Normal". The resulting type is currently one of Title, ListItem, or Text depending on the style.

All other paragraphs go to _text_to_element(), which handles these cases:

Paragraph is an entity. If the paragraph can be identified as a U.S. city+state+zip it is assigned Address. If it can be identified as an email address it is assigned EmailAddress.

Paragraph is considered for NarrativeText. The paragraph is assigned NarrativeText unless disqualified by unstructured.partition.is_possible_narrative_text(). There are a variety of resons, but they all look reasonable to me, like all numeric, text is empty string, most of the text is in all-caps, etc.

Paragraph is considered for Title. The paragraph is assigned Title unless disqualified by unstructured.partition.is_possible_title(). That would be reasons like all-numeric, empty, multiple sentences, etc.

Paragraph is assigned Text. If the paragraph doesn't meet any of the prior criteria it gets Text.

@shreyanid closing this as not actionable. Feel free to reopen if we identify specific cases.


Update module classes with page name for dynamic css

It would be nice to have a feature where the class names of the modules currently shown were updated to have the current page in their class list so that pages can have their own specified CSS.

A preliminary solution to this has been introduced with commit 389fb31.
Further improvements will probably be made before merging with master.


GitHub OAuth authentication with next.js

Hey Mario, thanks again for this great video, I think I understand the problem now:

Problem statement

The octokit instance is created as part of the App component, which is static, without any backend calls or server-side renderings
The request to exchange the OAuth code for an OAuth access token happens in the app/callback page component. I'm not exactly sure how that works technically, do you have a branch with the WIP code so I can inspect the requests happening to the server in my browser dev tools? I assume that when you open the /auth/callback path in your browser, the static parts of the App component render, but before the /auth/callback component renders, a request is sent to the backend, where the server code is run, which then responds with a data json which is passed to render the page component?
The problem is that at the point in time when the page component is rendered, the octokit instance already exists and there is currently no simple way to set a token for an existing instance.

Possible solutions

You make the octokit instance replaceable, and when you receive a token from getServerSideProps you replace the unauthenticated instance with a new one

We create a new authentication strategy which similar to @octokit/auth-token strategy but instead of passing a token string, it would accept a callback function, letting you basically define a token getter method.
const octokit = new Octokit({ authStrategy: createCallbackAuth, auth: () => myToken }

I think it would be fairly simple to do and others might have use for it, too. I do not want to build that feature into @octokit/auth-token because it's the default authentication strategy, every user of @octokit/core or any library built on it (such as @octokit/rest) will get the code, whether they use it or not. And bundle size is a critical factor for the JS Octokit SDK. So I would prefer to create a separate authentication strategy

We build the @octokit/auth-oauth-client SDK as documented at https://github.com/octokit/octokit.js/#oauth-browser-example.

If 1. is possible, then I'd suggest to do then so you are no longer blocked by it. But I understand (and agree) that it's not an elegant solution.
I'd suggest we collaborate on 2., that shouldn't take too long.
Once we have 2. working, I'd love your input on 3.. I cannot focus on it because it's not a priority for GitHub, but if there is an Octokit user like yourself you needs it for their work and who is willing to collaborate on it, I'd be happy to find the time on my side.
On thing to take into account for 3. is that it would take some control over redirects, at least the way it is currently designed. octokit.auth({ signIn: true }) will redirect to the OAuth Login URL on GitHub. Calling await { token, isSignedIn, createdAt, scopes } = await auth(); will remove the ?code=...&state=... from your URL, if present. Do you see any problem with that?
I also haven't considered the case that someone would want to send unauthenticated requests, but I think that would be within the scope of the project. It would simply send unauthenticated requests if the user is not signed in. But it wouldn't handle the use case when you want to redirect the user to the sign in page once they hit the rate limit. I think that is something you will have to handle as part of your app, I'm not sure if it's such a common pattern, we will find out.
I'll looks some more into your app, there are a few apps I want to build myself, but I'm not as experienced with React / next.js. But it is exactly the stack that I'd like to use for my own little side projects, such as https://github.com/gr2m/octokit.rest, https://github.com/octonews/octonews, or the mentioned OAuth App service.

Hey @gr2m! Thank you very much for your help.
I have deployed an update to https://octoclairvoyant.now.sh/ so you can see the GitHub login button within root page in the initial state of the page if you didn't authorize it yet. After authorize it, if you want to get the button back you can just delete the cookie from your browser storage. You'll see something like this:

Just bear in mind: the POST request to exchange the code by the access token happens in the SSR so you won't see anything related to that in the network tab of your browser.
Problem statement

The octokit instance is created as part of the App component, which is static, without any backend calls or server-side renderings

That's right, but a clarification about it: since I'm using Next.js hybrid mode with SSR, my whole App is instantiated twice: one on SSR and one on CS. I can elaborate more about this if you want me to, but the point about this is that octokit is instantiated twice too. That's why I'm saving the access token in a cookie so when the user access the page, the cookie is sent to my SSR and I can obtain the access token from it to perform any octokit request with it if necessary. I'm not using this yet, but I'm planning to do so in the future by sharing links with prefilled filters (so I'd receive the url with some querystrings and then I can get repo and release versions in the SSR, so the user sees already the changelog preloaded when opening the shared url)

The request to exchange the OAuth code for an OAuth access token happens in the app/callback page component. I'm not exactly sure how that works technically, do you have a branch with the WIP code so I can inspect the requests happening to the server in my browser dev tools? I assume that when you open the /auth/callback path in your browser, the static parts of the App component render, but before the /auth/callback component renders, a request is sent to the backend, where the server code is run, which then responds with a data json which is passed to render the page component?

That's it, you got the behavior: when GitHub come backs to /auth/callback in my app, the request arrives to my Serverless funnction which exchanges the code, then gets the token and build the page itself. This is sent to the Client-Side where at this point you'll see the spinner: that means the access code was obtained successfully so the app is 1) saving it in a cookie and 2) redirecting to root page to start using the app. This last point is the reason why I want to set dynamically auth in octokit, or be able to get authdynamically. Anyway as mentioned before, you have octoclairvoyant available to check this workflow.

The problem is that at the point in time when the page component is rendered, the octokit instance already exists and there is currently no simple way to set a token for an existing instance.

Indeed. This situation won't happen that often because this just occurs when the user is anonymous, auth the app and keep using the SPA dynamically. After the app is auth, every time the user reopen the app, octokit will have corresponding auth value since it gets it from cookie, where will be set already for the user.
Possible solutions

The update I deployed already include this, so you can check that as anonymous user the requests don't include the auth header, but then if you auth it on GitHub and search again after the process is completed, the requests include the auth header.
This would be fantastic. As I explained in my video, this is how I usually get the token in other apps where I use apollo so I don't set the token but get it dynamically on every request through that callback.
It would be amazing to have this solution, but I'm not sure about how the SSR --> CS + hydration process would happen, so there are few things to check first.

As you mentioned, I'm not blocked anymore since I'm using solution 1). If solution 2) it's easy to implement, would be nice to have. But I don't want to push anything to have 3) implemented to be honest. I'm happy to help as much as I can with it tho, but I don't want to take your time for it!

On thing to take into account for 3. is that it would take some control over redirects, at least the way it is currently designed. octokit.auth({ signIn: true }) will redirect to the OAuth Login URL on GitHub. Calling await { token, isSignedIn, createdAt, scopes } = await auth(); will remove the ?code=...&state=... from your URL, if present. Do you see any problem with that?

I don't see any problem with that. Since I would get the token after awaiting for the sign in (which I can do on the Client-Side), I wouldn't need either /auth/callback page or Serverless function for doing the exchange anymore.

I also haven't considered the case that someone would want to send unauthenticated requests, but I think that would be within the scope of the project. It would simply send unauthenticated requests if the user is not signed in. But it wouldn't handle the use case when you want to redirect the user to the sign in page once they hit the rate limit. I think that is something you will have to handle as part of your app, I'm not sure if it's such a common pattern, we will find out.

That fits 100% in my app. First version was done using GraphQL GitHub API but people started asking why they had to auth if repo info requested as open. So I switched to REST GitHub API to allow users to use the app anonymously. Handling the rate limit is not an issue: my app handles that already (although I need to improve the mechanism since I have octokit now). You'll see something like this when the limit is reached:

Let me know if want to know more about this Next.js stack! I love it, and it's the one I'm using for both personal and professional projects lately.

Thanks for sharing all the insights. Let me get 2. going. I think 3. is not ideal for next.js, so let's gain some more experience first and maybe we come up with something better down the road.

There you go: https://github.com/octokit/auth-callback.js
To use with Octokit
import { createCallbackAuth } = import("@octokit/auth-callback")
const new Octokit({
  authStrategy: createCallbackAuth,
  auth () {
    // return token here
  }
})

I haven't tested it myself yet but it's well covered by tests.

ah wait I didn't account for the unauthenticated state, let me add that quickly

there you go: https://github.com/octokit/auth-callback.js/releases/tag/v1.1.0
to check whether the instance is currently authenticated, use
const authentication = await octokit.auth()

authentication.type will be either "unauthenticated" or "token"

Awesome! I'm gonna try it into my app and give you some feedback. Thanks!

Sorry, but I think there is something wrong or I can't set it up properly.

import { createCallbackAuth } = import("@octokit/auth-callback")
const new Octokit({
  authStrategy: createCallbackAuth,
  auth () {
    // return token here
  }
})

This is not how is supposed to be configured, is it? I get Error: [@octokit/auth-callback] Callback passed to createCallbackAuth is not a function at build time.
Checking the package doc, I should do instead:
import { createCallbackAuth } = import("@octokit/auth-callback")

const new Octokit({
  authStrategy: createCallbackAuth(() => /* return token here*/)
})

But this way doesn't seem to work fine either. When I perform a request through octokit instance, I get TypeError: registered.hook is undefined at run time for both unauthenticated and token types.
I have pushed the latter (which seems the correct one), so you can check both code and platform in #23

@gr2m any update about this? Thanks!

Very sorry Mario, I missed your last comment! Let me what's up

I was able to reproduce the error:
https://runkit.com/gr2m/belco90-octoclairvoyant-22
I'm looking into it

The problem was a change that I made in @octokit/core at the same time as I did the new auth strategy and I didn't test the two together. The problem should be resolved with v2.0.0, see https://github.com/octokit/auth-callback.js/pull/3
You have to set auth to { callback () {} } now
    import { createCallbackAuth } = import("@octokit/auth-callback")
    const new Octokit({
      authStrategy: createCallbackAuth,
      auth { callback: () => "token123'"}
    })

Awesome! This is working perfectly now! Thank you very much for your collaboration here 🚀


Overflow with multiple categories

Environment
Docker
Version
0.13.2
Describe the problem
Hello everyone, thanks for this awesome project!
I have two categories and there is an overflowing issue on expansion.
To reproduce:

Add two categories, add at least one app in it
Open any of the two categories (overflow should appear here)
Open the other category (overflow should go away here)

Full disclosure: I did not try to debug it, I am not really a front-end dev.
Logs
Not really relevant I think
Context
Initial state:

Opening first category (overflow):

Opening second category (no overflow):

Closing second category (no overflow):

The issue appears only when there is one of the categories open, not just with the first.
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

I could not reproduce it unfortunately. Would you mind trying it on the dev branch and also more detailed reproduction steps if it still happens?

Hi @Tagaishi, do you have a docker image for the dev branch?
I am using the ghcr.io/ajnart/homarr:latest image

You just replace "latest" with "dev"
https://github.com/ajnart/homarr/pkgs/container/homarr

Could be browser related. Maybe Mantine is somehow desynced to the collapsed state?

Have you tried with other browsers? It will take me some time to reproduce the environment

Have you tried with other browsers?

Yep, same behavior on Chrome 116

I tried VM's and direct install on a laptop of arch linux, used the same firefox, can't reproduce.
Do other browser have the same problem? And other PC/platforms? if it persists on all those then the problem is somewhere else.

Other PC/platforms? if it persists on all those then the problem is somewhere else.

I tried with a Windows machine with Edge and an Endeavour OS machine on Firefox, the issue is not there...
Not really sure what is happening, but clearly it is some kind of configuration issue on my end.
I will close this issue and update it if I find the root cause.
Thanks for the help!

I finally figured out what it is.
If animation speed is set to "Instant" in KDE Plasma, the error appears.
Setting the animation speed to something other than instant will change the behavior.
CC @SeDemal


(firefox) Updating from v59.x to v60.x changed the UI language

Expected Behavior
This morning, I've updated Firefox to v60 through Chocolatey. Until yesterday, my browser was configured to use a german UI, which hasn't changed for months through numerous updates. After the update, the UI is english.
Steps to Reproduce (for bugs)

Install old version of Firefox
Check the UI language - I don't know where exactly it is picked up, but ensure to see it in a non-english language
Update Firefox to the most recent version

Your Environment

Package Version used: Firefox 60.0
Operating System and version: Windows 10, most recent update version
Chocolatey version: 0.10.11

@NicoHaase Would you be able to provide the installation log from when you performed the update?

Of course, see the attached file
firefox.log

hmm, there hasn't actually been any changes to the package in the last few runs that should cause this issue.
I don't suppose you've needed to use the l= in the past.
BTW, you can check which UI language the package will be installing by default by running Get-Culture in the powershell prompt (future versions will use Get-UICulture)

it's also possible that the uninstall path have changed (We use the uninstall path to detect what the the previous version was installed as)

Perhaps it has something to do with remembered arguments feature ? Did you actually installed previously with --params ?

I don't think I've used any arguments for installing, that was some years ago ;) But on a second computer, the update worked properly (keeping the german localization)

Can confirm the bug. Provisioned all company PCs with choco install firefox. Today I updated with choco update all and all FF installations changed from german to english.

In log there is no mention of verbose string 'Using locale' or anything from Get-Locale function.
I am not sure how this can happen, but since it looks it didn't, it used default en locale. Either that, or locale can't be parsed any more from uninstaller name:
https://github.com/chocolatey/chocolatey-coreteampackages/blob/5b41c7da5750bdcd54efcfd0ed462cb3cec9616d/automatic/firefox/tools/helpers.ps1#L39-L40

@majkinetor that's because that version of the helper isn't in the firefox package, it was added after this issue was opened and no new version of firefox have been published since (well, except for the firefox-esr package that is).
BTW, I see you removed the triaging label, have you found the cause of this? If not, that label should still be present.

<rant>

Yet another locale problem which  I have every single day on some project.
It just strengthens the point of never using non English locale for anything
NEVER 🗡
Just trust me on this. You can tank me later.

</rant>

BTW, I see you removed the triaging label, have you found the cause of this? If not, that label should still be present.

Yeah, my bad.

I added the bug label again, as I believe it to be one. Just not been able to figure out where yet.

it was added after this issue was opened and no new version of firefox have been published since

We should probably publish this ASAP, maybe we can get log of another unfortunate person before whole planet updates.

Pattern still works:
master~> 'Mozilla Firefox 60.0 (x64 en-US)' -replace ".+\s([a-zA-Z\-]+)\)",'$1'
en-US

@majkinetor That's what I found out as well, which is pretty much why I can't figure out why the language suddenly changed.

If it helps here is my FF Install log
install.log
and here the part of the choco log.
choco.log

Any news on this topic? As far as I see, reinstalling does not help either:
C:\WINDOWS\system32>cinst --force firefox --params "l=de-DE"
Chocolatey v0.10.11
Installing the following packages:
firefox
By installing you accept licenses for the packages.
Firefox v60.0.1 already installed. Forcing reinstall of version '60.0.1'.
Please use upgrade if you meant to upgrade to a new version.
Progress: Downloading Firefox 60.0.1... 100%
Firefox v60.0.1 (forced) [Approved]
firefox package files install completed. Performing other installation steps.
Downloading Firefox 64 bit
from 'https://download-installer.cdn.mozilla.net/pub/firefox/releases/60.0.1/win64/en-US/Firefox Setup 60.0.1.exe'
...shouldn't the locale parameter documented at the Firefox page force the download of that specific locale version?

If locale package parameter is not present, this package installs Firefox in the first language which matches this list:

If Firefox is already installed it uses the same language as the already installed one.
The Windows system language.
If Firefox does not support the system language, it will fall back to en-US.

So nah. that wont help. You need to clean registry first I think from quick glance.
I think this locale thing needs redesign. Since this is a monster package which reduces the probability it will be taken by core maintainers, I suggest PR. I personally have almost ZERO motiviation to use (and hence fix) non english stuff.

@majkinetor you can already change the locale by using parameters:
l=nb-NO for instance, this should override the registry checks.
If that doesn't work, that would be a bug though, unless firefox doesn't provide the language specified.

@NicoHaase in your case, you actually specified a language that firefox doesn't support (well, they support it but not as de-DE, but as de).
Always check the following list of supported locales: https://releases.mozilla.org/pub/firefox/releases/latest/README.txt

Thanks, using the proper locale, I was able to reinstall Firefox with the proper language settings

@NicoHaase just curious.
If you run Get-Culture in the powershell windows, what is the output?
I'm guessing it's de-DE, and that could be what previous versions of firefox used.
If so, this wouldn't be a bug as I initially though. but rather suggest that we should also test for the 2-letter part of the culture code instead of the full culture.

Yep, it returns de-DE

@AdmiringWorm , then this is documentation bug.

If Firefox is already installed it uses the same language as the already installed one.

Since @NicoHaase forced it, it was already installed. Hence the en-US is correct.

@majkinetor the documentation also mentioned:

If locale package parameter is not present, this package installs Firefox in the first language which matches this list:

So the docs is still correct.
Anyways, closing this one and opened #1041 to track the enhancement for checking 2-part culture codes as well.


feat-request: Add grouping option

It would be great if you could group snackbars of the same type/message/etc, instead of having them show one by one.
Here is an example:
https://user-images.githubusercontent.com/26358211/128323758-9e085ec1-19cf-42df-bd0d-40a9cf07bde0.mov
This was taken from: https://quasar.dev/quasar-plugins/notify#grouping
You could send a new prop group that is boolean, to make the snackbars stack(default: false).

Sorry but I won't implement it.
You could update the message by checking if a message is already available, and then increase the number. A very basic example: https://codesandbox.io/s/v-snackbars-with-increase-badge-s8uzn?file=/src/App.vue
You could make it prettier by using some badges in place of the "close" button, or whatever will look better.

Thanks to your example and with slight modification to your code, I was able to implement it with badges.
https://user-images.githubusercontent.com/26358211/128855624-c83666b5-b19f-4497-aece-599c5da7e653.mov
I will leave the modified code below for others to see.
<template>
  <v-app>
    <v-main class="text-center">
      <v-btn dark color="red" class="mt-6" @click="showMessage('red')">Click Me</v-btn>
      <v-btn dark color="blue" class="mt-6" @click="showMessage('blue')">Click Me</v-btn>

      <v-snackbars :objects.sync="objects" bottom left></v-snackbars>
    </v-main>
  </v-app>
</template>

<script>
import VSnackbars from "v-snackbars";

export default {
  name: "App",
  components: {
    "v-snackbars": VSnackbars,
  },
  data: () => ({
    objects: [],
  }),
  methods: {
    showMessage(toast) {
      const payload = {
        id: toast,
        timeout: 5000,
        color: toast,
      };
      let idx = this.objects.findIndex((obj) => obj.id === payload.id);
      if (idx > -1) {
        payload.count = this.objects[idx].count + 1;
        payload.message = `This snackbar has ${payload.count} message${
          payload.count > 1 ? "s" : ""
        }.`;
        this.objects.splice(idx, 1, payload);
      } else {
        payload.count = 1;
        payload.message = "This snackbar has 1 message.";
        this.objects.push(payload);
      }
    },
  },
};
</script>

To add the badge you just have to wrap <slot name="action" /> with badge component, found inside v-snackbars.
<v-badge
  v-if="snackbar.group"
  :content="snackbar.count > 99 ? '99+' : snackbar.count"
  :value="snackbar.count"
  color="green"
  overlap
  :offset-x="snackbar.count > 9 ? snackbar.count > 99 ? '20px' : '10px' : '5px'"
  offset-y="5px">
  <slot
    name="action"
    :close="() => removeMessage(snackbar.key, true)"
    :id="snackbar.key"
    :index="idx"
    :message="snackbar.message">
    <v-btn text @click="removeMessage(snackbar.key, true)">close</v-btn>
  </slot>
</v-badge>


feat(keycloak-auth-plugin): plugin skeleton setup

Create a maven project for the plugin and include the required basic dependencies.
Create the plugin code skeleton too based on the keycloak documentation.

Complete


Allow bench_refs() and bench_local_refs() to capture input lifetimes

This allows benchmarks using bench_refs() and bench_local_refs() to capture the input lifetimes, as was already suggested by TODO comments in the code.
By naming the input lifetime, the output type O is allowed to capture this lifetime. The I: 'i condition for &'i mut I must be made explicit now with named 'i, or the code won't compile.

Any suggestions for a good example? In my project I'm using it for benchmarking a parser that creates a token stream/tree which references the input, but that seems too complex for an example (and it uses a separate parser crate). I guess I could do something simple like collecting the result of str::matches() in a Vec that gets returned?

Any further comments?

@nvzqz Is there anything else you'd like me to change in this PR?

Hey @neocturne, sorry for the late response, and thanks again for the contribution. Since I'm not sure whether adding a lifetime here is a breaking change, and I already have some breaking changes planned, this will land in 0.2 soon.


Update sheet.json

Put 'legacy':false

Submission Checklist
Required

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.

Sure thing!

Hi @WebDevCampos This PR does not include the name of the affected sheet in the PR title as requested in the first item in the checklist, can you please amend this and then I will merge it.

Sure thing my friend! Check if it is ok, please!


Add course integration tests, and refactor object and field zod definitions

Slightly unrelated to the PR, but mentioning this since a similar issue was fixed in one of the commits here: the /timetable/getPublic endpoint doesn't work, as the /timetable/:id endpoint is placed before it in the router, so requests to this assume that "getPublic" is supposed to be a timetable ID.

Create an issue for this @Anurav-Garg


docs: Fix simple typo, persion -> persian

There is a small typo in locales/jquery.timeago.fa-short.js.
Should read persian rather than persion.

Thanks!


ujson.Readable.from{Path,File}: close input stream

Attempt at fixing #303
What's confusing about the code (both before and after) is that it creates an InputStream once, and then returns an object that can attempt to consume the InputStream many times. For this reason closing it feels wrong but in any case the InputStream will presumably be useless the next time.
(Unless it's meant to be usable with an ndjson file. In which case #303 has no solution.)
I would think a better approach would be that every time Readable#transform is called it would create the InputStream from the file, read it, and close the InputStream. But that doesn't seem to fit the whole InputStreamParser + Transformer shape of things.

Thanks for the PR, it's a bit late here now but I'll take a look at it soon

I just wanted to let you know that this PR seem to fix the issue in mill (https://github.com/lihaoyi/mill/issues/754). At least, my test script does not complain.

Looks good to me, thanks @nafg!

@lefou I've published this as uPickle 1.0.0


testground/app: create a seed node

a seed node that connect the peers to each other, so the peers don't need to add one another as persistent peers as mandatory anymore
This can help us in the future minimize the amount of inbound/outbound peers per 1 validator for testing bandwidth vs big blocks

Reference issue:
https://github.com/tendermint/tendermint/issues/9289


CORS support (or lack thereof)

I feel like neo has a potential of being a really nice Go library for building API's, but while trying to do so, I ran into another issue. CORS.
Currently, neo can only properly handle GET and simple POST requests from same origin.
Handling cors requires a bit of middleware code
	// CORS Middleware
	app.Use(func(ctx *neo.Ctx, next neo.Next) {
		if origin := ctx.Req.Header.Get("Origin"); origin != "" {
			ctx.Res.Header.Set("Access-Control-Allow-Origin", origin)
			ctx.Res.Header.Set("Access-Control-Allow-Credentials", "true")
			ctx.Res.Header.Set("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE")
			ctx.Res.Header.Set("Access-Control-Allow-Headers",
				"Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization")
		}

		// back to neo
		next()
	})

, but the real pain is enabling POST, PUT, PATCH, DELETE... requests, since Neo doesn't expose router internals, one has to manually define OPTIONS region for every single endpoint.
	app.Options("/channels/:name", func(ctx *neo.Ctx) {
		ctx.Res.Raw([]byte(""), http.StatusOK)
	})
	app.Options("/channels", func(ctx *neo.Ctx) {
		ctx.Res.Raw([]byte(""), http.StatusOK)
	})

This is a lot of repetitive boilerplate, and is something the framework should be able to take care of in a more succint manner.
Note: My cors setup here isn't 100% correct and shound't be used as a reference.

I found a way how to avoid having to set options:
		// Stop here if its Preflighted OPTIONS request
		if ctx.Req.Method == "OPTIONS" {
			return
		}

Still, some built in support would be nice.

You are totally right. Thank you for pointing out.
I just added support for wildcards, you can check it here (Wildcards section) http://ivpusic.github.io/neo/tutorials/2015/01/22/routing.html
I hope so this will help you.

I also created neo-cors package.
https://github.com/ivpusic/neo-cors

Wow, you are awesome!


[My Courses] White background while dragging

When you drag a course to some other position in the same list, the white background behind the other courses stays there. It shouldn't.
No white background on original position:

White background stuck on other course's previous location:

Fixed, thanks!


External wrapping

@thewtex I could not find time to try this with RTK but it looks safe to me. +1


Release of binary artifacts

It would be great if the release contained binary artifacts that can be just installed in a target machine. as of now the process involves cloning this repo and running go build.
I highly recommend https://goreleaser.com/ to achieve the same
For an example you can see releases in one of my repository https://github.com/kishaningithub/rdapp/releases
Happy to contribute a PR if you agree with this idea :-)

Duplicates of #3.
In addition to #3, the tflock heavily depends on the hashicorp/terraform internals, and the Terraform v0.15.4 moved all Go packages to internal (hashicorp/terraform#28723). This means that we can no longer directly import hashicorp/terraform as a Go library and cannot support 1.x. So far, it seems to be working for me, but there may be cases where it does not work under some conditions, as you reported in #9. So, this project should be considered a temporary workaround, and I am hesitant to release a binary as it is.


it seems that the sigmoid function used twice

https://github.com/Turoad/lanedet/blob/210709066886e4906c8d3ab4d9173785ef07c65d/lanedet/models/heads/exist_head.py#L32
Dear author, thanks for your code. I find in exist_head.py, the output of fc10 was then put into an sigmoid function, but in lane_seg.py, you used BCEWithLogitsLoss() to calculate BCE loss, it seems that the sigmoid function was used twice.

You can refer this issue: https://github.com/ZJULearning/resa/issues/29


Wire through CRI checkpoint RPC

This connects the new CRI ContainerCheckpoint RPC to the existing internal checkpoint functions. With this commit it is possible
to checkpoint a container in Kubernetes using the Forensic Container Checkpointing KEP (https://github.com/kubernetes/enhancements/issues/2008):
# curl -X POST "https://localhost:10250/checkpoint/namespace/podId/container"

Which will result in containerd creating a checkpoint in the location specified by Kubernetes (usually /var/lib/kubelet/checkpoints).
The latest version of crictl already supports creating checkpoints via crictl checkpoint.

/cc

Switching to ready for review after the corresponding CRI API changes have been merged and crictl is also ready for the new CheckpointContainer() RPC.

Not sure why the one CI run failed.

Can you change the reference in your commit to the kubernetes/enhancements#2008?
Right now it's referencing an unrelated containerd PR.

Can you change the reference in your commit to the kubernetes/enhancements#2008? Right now it's referencing an unrelated containerd PR.

Done.

The windows CI linter is timeouting and probably unrelated to my changes. Everything else seems happy.

The windows CI linter is timeouting and probably unrelated to my changes. Everything else seems happy.

I've noticed that on some recent PRs; just opened #7356 to hopefully solve that.

/ok-to-test

@adrianreber needs rebase

@adrianreber needs rebase

done

@adrianreber Do you mind rebasing this again?

@adrianreber Do you mind rebasing this again?

Rebased.

If I incorporate this commit into my local contanierd development code, can I use crictl to do the checkpoint/restore container?

If I incorporate this commit into my local contanierd development code, can I use crictl to do the checkpoint/restore container?

This currently only supports the checkpoint path.

If I incorporate this commit into my local contanierd development code, can I use crictl to do the checkpoint/restore container?

This currently only supports the checkpoint path.

Does it support restore containers?

If I incorporate this commit into my local contanierd development code, can I use crictl to do the checkpoint/restore container?

This currently only supports the checkpoint path.

Does it support restore containers?

No, as mentioned it only supports the checkpoint code path.

If I incorporate this commit into my local contanierd development code, can I use crictl to do the checkpoint/restore container?

This currently only supports the checkpoint path.

Does it support restore containers?

No, as mentioned it only supports the checkpoint code path.

Uh... . Why? can it restore the container with create + start? Like cri-o.

Uh... . Why? can it restore the container with create + start? Like cri-o.

Because it is not implemented. This PR tries to add support for the KEP 2008 (Forensic Container Checkpointing) and it can be used in a way like described here: https://kubernetes.io/blog/2023/03/10/forensic-container-analysis/
Maybe it would be good if you took over moving this change forward? Are you interested?

Is this PR planned to get merged?

Uh... . Why? can it restore the container with create + start? Like cri-o.

Because it is not implemented. This PR tries to add support for the KEP 2008 (Forensic Container Checkpointing) and it can be used in a way like described here: https://kubernetes.io/blog/2023/03/10/forensic-container-analysis/
Maybe it would be good if you took over moving this change forward? Are you interested?

I'm very interested, but I don't know what I can do.

I currently need this feature, and it seems like it hasn't been merged yet. Is there anything I can do to help?

why such a nice feature get ignored for so Long time? what is blocking it from merged?

why such a nice feature get ignored for so Long time? what is blocking it from merged?

This is not ignored.
There is a concern about export_to_archive (See discussion above).
This also needs rebasing at least

why such a nice feature get ignored for so Long time? what is blocking it from merged?

This is not ignored. There is a concern about export_to_archive (See discussion above).
This also needs rebasing at least

Thanks for clarification @AkihiroSuda !  And thanks @adrianreber for the great work! Do you consider taking the suggestion at https://github.com/containerd/containerd/pull/6965/files#r1103347312, or you prefer to keep it consistent with CRI-O implementation?

why such a nice feature get ignored for so Long time? what is blocking it from merged?

This is not ignored. There is a concern about export_to_archive (See discussion above).
This also needs rebasing at least

Thanks for clarification @AkihiroSuda ! And thanks @adrianreber for the great work! Do you consider taking the suggestion at https://github.com/containerd/containerd/pull/6965/files#r1103347312, or you prefer to keep it consistent with CRI-O implementation?

Unfortunately I do not understand the code base well enough. Somebody needs to tell me how to do it differently. The comment just says that I should do it differently but not how.

If we do add the format, I think it would be best to pass the desired format down but not the other options (export_to_archive and location).

From my point of view I need the options. If it needs to be done differently I need guidance how to do it. The tasks API needs to change from my point of view because that is the place the checkpoint is created by containerd and I need to tell the task API where to create it. It is not clear how to do it differently without those changes, sorry.

Thanks to the help of @estesp this has been now rewritten without changes to the task API.

So the test pull-containerd-node-e2e fails because CRIU is not installed on that test system. Any hints on how I can change that test to install CRIU?

/test pull-containerd-k8s-e2e-ec2

So the test pull-containerd-node-e2e fails because CRIU is not installed on that test system. Any hints on how I can change that test to install CRIU?

@dims any ideas?

So the test pull-containerd-node-e2e fails because CRIU is not installed on that test system. Any hints on how I can change that test to install CRIU?

@dims any ideas?

@adrianreber where should criu binary needs to be downloaded from? (anything else other than the presence of the binary? any configuration update to config.toml? anything in kubelet?)

So the test pull-containerd-node-e2e fails because CRIU is not installed on that test system. Any hints on how I can change that test to install CRIU?

@dims any ideas?

@adrianreber where should criu binary needs to be downloaded from? (anything else other than the presence of the binary? any configuration update to config.toml? anything in kubelet?)

I saw the test image is Debian based. apt install criu should be good enough. Debian 12 comes with CRIU 3.17. 3.16 is the minimum for correct namespace handling in combination with pods.
Is the Debian package a good source or is there another way you would like to take the package from?

Is the Debian package a good source or is there another way you would like to take the package from?

This is a GCP COS image, you can see the top of the kern.log to confirm.
Here's where we can make changes to add more things to the node:
https://github.com/containerd/containerd/blob/main/contrib/gce/configure.sh
looks like criu.org / github repo both have sources only :( do ping me back if you are still stuck.

@cpuguy83 I didn't want to dismiss your stale review without your input; that file is no longer part of the commit, so I assume your concerns are handled, but if you have any other concerns let me know

Is the Debian package a good source or is there another way you would like to take the package from?

This is a GCP COS image, you can see the top of the kern.log to confirm.
Here's where we can make changes to add more things to the node: https://github.com/containerd/containerd/blob/main/contrib/gce/configure.sh
looks like criu.org / github repo both have sources only :( do ping me back if you are still stuck.

@dims I must say I have no idea how solve this. It seems really difficult to install anything on COS which is not statically linked. Which is easy for Go application, but CRIU is not easily statically linked. So I cannot really build CRIU on the host where containerd is built and then transfer it to GCE host, because all libraries would be missing. I suppose I cannot build it on COS because that seems not doable based on the existing setup which builds containerd on another host.
Not sure how to get a CRIU binary into a COS image.

Is the Debian package a good source or is there another way you would like to take the package from?

This is a GCP COS image, you can see the top of the kern.log to confirm.
Here's where we can make changes to add more things to the node: https://github.com/containerd/containerd/blob/main/contrib/gce/configure.sh
looks like criu.org / github repo both have sources only :( do ping me back if you are still stuck.

@dims I must say I have no idea how solve this. It seems really difficult to install anything on COS which is not statically linked. Which is easy for Go application, but CRIU is not easily statically linked. So I cannot really build CRIU on the host where containerd is built and then transfer it to GCE host, because all libraries would be missing. I suppose I cannot build it on COS because that seems not doable based on the existing setup which builds containerd on another host.
Not sure how to get a CRIU binary into a COS image.

@dims Would it be possible to install CRIU in Dockerfile.test?

I added code to containerd to check if there is a version of CRIU installed at all and if it has the minimum version needed for Kubernetes (3.16). If no CRIU version is found I am returning the same error message to the kubelet as if containerd would not implement this interface. This is not perfect as the error message is wrong, but this will make the test work on the Kubernetes side and once that is done I can change Kubernetes to handle an error message like "CRIU is not installed or too old correctly".
I just saw I broke the windows build. Will fix it.

The remaining CI errors seem unrelated as far as I can tell.

@dims This new pull-containerd-k8s-e2e-ec2 is an optional test, correct?

@dims This new pull-containerd-k8s-e2e-ec2 is an optional test, correct?

Yep!


Ensure KinematicBodies only interact with other Bodies with matching mask.

Currently, when a KinematicBody collides with another CollisionObject the collision_layer->collision_mask combination is checked both ways. This results in unintended and unwanted collisions. For example, you may want a bullet to be stopped by a shield, but not a shield to be stopped by a bullet.
This PR ensures that KinematicBodies only collide with CollisionObjects that have one of the KinematicBody's collision_layer bits in the other CollisionObject's collision_mask. It fixes both 2D and 3D (Godot and Bullet) physics.
This PR is the KinematicBody sister to #42268, which fixes collision_layer->collision_mask checks for Areas.
Fixes #15243.

Rebased following merge of #43952.

Rebased following merge of #46917 and #46937.

Now we have an approved proposal:
https://github.com/godotengine/godot-proposals/issues/2775
So this change is welcome for 4.0, the PR just needs a rebase.

Thanks!


kicad-unstable-small: init to build kicad-unstable's base on hydra

Motivation for this change
kicad-unstable does not get built by hydra
Things done

add kicad-unstable-small so the components of kicad-unstable that hydra can build, get build
make the CLI utilities available by linking to them them in the wrapper
move libraries and base out of the let block so they can be addressed directly
bump kicad-unstable to latest versions

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build kicad-unstable

mkLib needs to be updated to use recursiveUpdate[1] so that meta.license doesn't get overwritten.
[1] https://github.com/NixOS/nixpkgs/blob/fbafe7ca64e9ce5dae908c6520035a0355043648/lib/attrsets.nix#L405-L427

@veprbl i've changed it to use recursiveUpdate, it didn't affect the build output, i assume the metadata is stored separately, the libraries aren't directly addressable so i couldn't use nix repl to check if this worked...

cc @nek0 for testing.

Will try as soon as I can.

Result of nixpkgs-review pr 82634 1

2 packages built:
- kicad-small
- kicad-unstable-small

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/kicad-suddenly-getting-rebuilt-from-source/16315/8


Reference for "network_routing.cc" solution

Hi,
network_routing.cc Solves a multicommodity mono-routing problem, I would like to know the reference behind the solution, like a publication.
thanks,
Amir

something close to http://cse.unl.edu/~choueiry/Documents/Regin/rococoCP02.pdf


Add support for missing transformations

We are not considering the following transformations:

Union and its variants like unionAll, subtract (which is except in Spark`), etc
Limit, which Spark parses to GlobalLimit and LocalLimit (which I believe are just implementations, so we can just consider a single Limit transformation).
A bun of other transformations have TODOs that we should finish too.

Also, add a Unknown transformation type and a WARN when we don't recognize a transformation in the job


Atom not opening

I'm running Ubuntu 12.04 in Virtualbox. I've downloaded and installed the latest .deb file from the Atom repo. The install went fine. I launch Atom and the processes starts, but Atom does not open.
Any ideas?

Here's an error I got from trying to just download the code and run atom...

Okay, tested it out on another computer. I got the same error trying to download the code and run atom, but when I installed the deb, it worked fine...weird.

I'm seeing this too on Ubuntu 15.04  Started following the upgrade to 0.208

Maybe this is relevant: http://stackoverflow.com/questions/24464690/bash-scripting-unexpected-operator
if [ "a" == "a" ] should be if [ "a" = "a" ].
bash accepts == instead of =, but your /bin/sh probably isn't bash.
So either change the == to =, or your shebang to #!/bin/bash


AsynccoreDispatcher catches SystemExit

I have an application using pysnmp with a daemon that exits in response to SIGTERM by calling sys.exit from a signal handler.  I have seen unclean or failed exits from it due to pysnmp.carrier.asyncore.AsyncoreDispatcher.runDispatcher catching SystemExit.  The function includes specific handling for KeyboardInterrupt, but not for SystemExit,
I would suggest changing the bare except: to except Exception: and removing the special case for KeyboardInterrupt.

Actually, it appears this change is already fixed in commit 588b9b902d19 ("Uppercase global constants (#238)").  I do have a minor cleanup in that the except KeyboardInterrupt is now redundant, for which I've submitted a separate PR.

Yes, I concur and this has been improved in master.


Fixes teardown of program while GPU is running

Guards the Data deleter and the notify_task_completion with try ... catch blocks because they are called from the command buffer completion handlers which may be called after the destruction of the main thread (now that we have async_eval).

Closing because of fix in the synchronize PR.


Defenders spawn when only tamed creatures are nearby

Describe the bug
The guardian wraith, bats and ghosts from the relevant pylons continue to spawn when only tamed creatures are nearby.
To Reproduce (if applicable)

Go somewhere where there are no bad guys.
Spawn in a boar, and tame it (I did both of these via console but it happens even when the tamed creature is tamed naturally)
Equip the Spectral Shroud, or place one of the defender pylons.
Watch the defenders spawn and find life incredibly boaring because there is nothing but a friendly boar in the vicinity.

Expected behavior (if applicable)
I asked in Discord if it was intended behaviour, and it was suggested that it was not. The "Spirits" are only meant to spawn when untamed baddies or those not part of the player faction are nearby. Or, so I've been told.
Screenshots (if applicable)

Notice there are no enemies nearby (they've all been killed by the defenders), yet they still hang around and continue to spawn. The only other entity, other than my character, in the area is a tamed boar.
Desktop
If you can, please complete the following information:

OS: Garuda Linux Gnome Edition
Mod version: 2.5.11
Game version: 214.3
BepInEx 5.4.21
Jotunn 2.11.2

Notes:
I have tested with only ChebsNecromancy (plus dependencies) installed on both an existing server/character, and have tested it with a fresh character and world, both on a local save and a dedicated server. The "bug" is consistent in all cases.

Watch the defenders spawn and find life incredibly boaring because there is nothing but a friendly boar in the vicinity.

Haha! I see what you did there!
Thanks for the detailed bug report. It's kinda related to a much older issue here.

You're most welcome. I just couldn't resist a boaring pun. I had a look at the older issue, and yes there seems to be some overlap there. It's nothing critical, as you have said, so no need to address it unless you feel the need to. I do look forward to an update, however. It can get annoying working around the pig pen, but i'm working around that by unequipping the Shroud.

Please check here if you want to test the fix https://github.com/jpw1991/chebs-necromancy/pull/175


Initialize $DCFilesExists in 2_CreateParentDisks.ps1

I ran the script a few times in the same PS Session and got into an error because $DCFilesExists was still $true from the previous run

I'll fix this in next commit.


Is network addons needed ?

Hi !
I'm new in the kubernetes world.
So, maybe my question will be useless !
And I don't know where to ask this question..., if my question shouldn't be there, free to close it !
When I setup the HA system, like kube-vip, do I need to use a network addons like calico or weavenet ?
And why ?
Thanks a lot for your attention !

So the answer is that it depends, For HA then no as the Kubernetes pods will be deployed as static pods and those exist largely outside of the cluster itself.. for service type loadbalancer then yes a CNI plugin will probably be needed.

So the answer is that it depends, For HA then no as the Kubernetes pods will be deployed as static pods and those exist largely outside of the cluster itself.. for service type loadbalancer then yes a CNI plugin will probably be needed.

Okay thanks !
If I want to have 3 masters servers and 3 workers servers to work together (loadbalancer), I need a CNI plugin ?
To init this,
I need to first create the manifest of kubevip.
make kubeadm init.
And which one in first :

join other nodes
or setup the cni plugin ?

Do you have a suggestion about cni plugin ? I think I'll go on calico.

Okay thanks !
If I want to have 3 masters servers and 3 workers servers to work together (loadbalancer), I need a CNI plugin ?
To init this,
I need to first create the manifest of kubevip.
make kubeadm init.
And which one in first :

join other nodes
or setup the cni plugin ?

Do you have a suggestion about cni plugin ? I think I'll go on calico.

I normally opt for Calico, with regards to your question.. the choice is entirely yours :-) the CNI plugin runs as a daemonset so once deployed you don't need to think about it.

I normally opt for Calico, with regards to your question.. the choice is entirely yours :-) the CNI plugin runs as a daemonset so once deployed you don't need to think about it.

Thanks you very much for your help !
It will help me a lot !

Thanks you very much for your help !
It will help me a lot !


[fix][broker] Catch exception for entry payload interceptor processor

Motivation
Currently, the entry payload interceptor processor doesn't catch exceptions, the exception will be swallowed by the executor task.
Modifications
Catch exception for entry payload interceptor processor.
Verifying this change
Add a test for catching exceptions from the payload input interceptor processor.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.38%. Comparing base (bbc6224) to head (4bda805).
Report is 776 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23683      +/-   ##
============================================
+ Coverage     73.57%   74.38%   +0.80%
- Complexity    32624    35072    +2448
============================================
  Files          1877     1945      +68
  Lines        139502   147453    +7951
  Branches      15299    16270     +971
============================================
+ Hits         102638   109676    +7038
- Misses        28908    29305     +397
- Partials       7956     8472     +516

Flag
Coverage Δ

inttests
27.32% <42.85%> (+2.73%)
:arrow_up:

systests
24.36% <0.00%> (+0.04%)
:arrow_up:

unittests
73.76% <100.00%> (+0.91%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

...org/apache/bookkeeper/mledger/impl/OpAddEntry.java
74.62% <100.00%> (+1.80%)
:arrow_up:

... and 667 files with indirect coverage changes


Most of your releases aren't tagged in git, and don't appear as releases in github

Given that this isn't widely available currently, this would make it easier for me to package for internal use at work.

Starting from 0.1.14 it has tag now.
have also plans to automate builds of package (now doing all manually).


[BUG] cellpose.org website not responding

whenever i tried to upload images, it will show an "X" mark and restarts to the starting page

fixed now


enforcing a scene heading reset when the user faces true north

(according to mapkit)

Looks good, thank you.


max connections reached: 4000

I'm getting a "max connections reached: 4000" when trying to use the site.  I'd like to give more information, but that's really all there is to it.  I try to navigate the site and when doing so I just get a message saying "max connections reached: 4000" with nothing else displaying.

I have the same issue but for me it says "max connections reached: 5000", also no Dalamud price check plugins work anymore they all return 429 too many requests.

This is due to server load issues, I've been trying to resolve it over the past few days — there's currently no ETA on a fix because there haven't yet been clear signs as to what the underlying problem is, but I'm trying to fix it as quickly as possible.

Resolved since the start of the month; closing


Implement Canary Analysis of newly-deployed ML models to run along side existing models - allow rollback if possible

provide metrics on both system and prediction performance to allow multiple levels of canary analysis

http://cloud.spring.io/spring-cloud-static/spring-cloud.html#netflix-metrics

related to https://github.com/fluxcapacitor/pipeline/issues/61 for alerts/notifications of bad canaries

Notes:
online evaluation is pinning 1 model (or multi-armed bandit) against another vs offline
online is best, offline is preliminary smoke test. requires online system which is not common. we hope to make it common.
form of canary analysis of new model against existing cluster.
some traffic goes to new model canary.
make sure new model is performing within acceptable tolerance of existing model, otherwise remove it and try again.
simple monitoring: golden set of data scored live against newly-deployed model
complex: deploy canary of new model alongside cluster of old model.
compare as part of canary analysis. keep an eye out for Netflix ACA (automated Canary Analysis)

zuul screenshots:

Moving to Advanced Edition http://pipeline.ai/products


Adds unit tests to external repo

Preparing for IETF, it will help build an open source community around this library if contributors were able to test their contributions.
This PR adds the existing UTs to the external library.

There are some .pyc files that should be removed.

Ahh good catch


Quantization preference hierarchy?

Hi - wanted to ask a question. I think most folks are familiar with GPTQ & AWQ and relative speeds & quality losses, but int8 weight only (and variants of int8/int4 including with/without smoothquant) as well as fp8 I understand less about and see less in practice.
Would like to verify what I think is true which is fp8 is the best when supported and is the closest to fp16, doubles throughput and halves memory, while other options like int8 with smoothquant/weight only are lesser preferred and only good if fp8 is not available, and even less so is GPTQ/AWQ which introduce much more significant artifacts and quality loss for reduced memory. Is this true always/most of the time? The benchmarks for Llama especially are for fp8 which suggests to me it's the recommended/standard way to serve them with no real loss of quality from fp16 to fp8?

For different quantization methods, they have different cons and pros, so users should consider which one is better for their use case.
For fp8 example, that's only because it is an example, so we only provide the simplest script to run fp8 example successfully.