When the name of file is not a english it makes error.

When title is not english, I'm using the Korean, It occurs error can't render. It can't handle such as "쿠버네티스를 공부하는 법.mdx".
Like when it's not english then encoding happens and the automatic mdx engine can't read and create article.
http://localhost:3000/SLAM/블로그

Nice to meet you, Nextra user from Korea!
I built Nextra pages with files in languages other than English using the following method:
•	First, before the Nextra build, I use a Node script during the prebuild phase to encode the file names in the path using JavaScript’s encodeURIComponent.
•	Then, I build Nextra.

I confirmed through testing that this method successfully loads pages in Nextra. 😃

@ATeals pr welcome for v3


[Tasks] Translate task type from server to TSC enum

We have enums in task_item.py to represent the 2 task types supported by the REST API - these are used in the URLs.
However, the server response returns different values, so we need to translate them into TSC enums.
Not quite sure why the test xml responses had different values - checked old versions of tableau server but didn't see them used anywhere.

So the server is sending 'MaterializeViews'? It was called that for a period during development but renamed before release, might be why?

Ah that's right, used to be materialized views before data acceleration


ensure Dependency::source::source_url can be populated from .nuspec uRL

PR #10025 moved the NuGet package source repository URL finder to native code, but since that feature is behind an experimental flag, the old version of metadata_finder.rb and the corresponding tests had to be temporarily restored.  Otherwise no change has been made.
Manually verified with the customer-reported repo.
Fixes #10178.

Please can we have a unit test added to ensure we can catch regressions faster?

Please can we have a unit test added to ensure we can catch regressions faster?

The tests were restored with the functionality.  In the big PR that caused the regression, a feature flag was added for the new functionality, but this file was missed and by restoring the old tests we're also ensuring the old behavior is present.  I was premature in removing these tests.
Only when the feature flag/experiment is considered complete and all old code is removed can these tests be safely deleted.


Test merge 6.3.x

[facebones ignore]

Merge conflicts in the following files
src/puppetlabs/puppetdb/http/query.clj
src/puppetlabs/puppetdb/query_eng.clj

They could probably use a review before merging.

CLA signed by all contributors.


With using the fp8, after the interruption of training, and then continue , there may be a little difference in loss. Is this caused by the fp8 mechanism?

When I used BF16+Megatron-LM, I interrupted it once and continued training. In this case, the Loss in the first round was exactly the same.  But the use of FP8 is a bit different with the loss.  I want to know is this caused by the fp8 mechanism?
For example, at 3,000 rounds, saved weight and optimizer status, then continue training. I'm sure the weight is right loaded, because I set the strict=True when torch.load the 3000 iteration weight. I also load rng and optim, with no setting no-load-rng and no-load-optim in args. The difference is as follows:
1\ training no interrupted:
<IP_ADDRESS>:  iteration     3001/   10000 | consumed samples:      3073024 | elapsed time per iteration (ms): 1947420.8 | learning rate: 1.361E-04 | global batch size:  1024 | lm loss: 4.484718E-01 | loss scale: 1.0 | grad norm: 0.076 | number of skipped iterations:   0 | number of nan iterations:   0 |
<IP_ADDRESS>:  iteration     3002/   10000 | consumed samples:      3074048 | elapsed time per iteration (ms): 97447.9 | learning rate: 1.361E-04 | global batch size:  1024 | lm loss: 4.572957E-01 | loss scale: 1.0 | grad norm: 0.073 | number of skipped iterations:   0 | number of nan iterations:   0 |
2\ interrupted and continue training:
<IP_ADDRESS>:  iteration     3001/   10000 | consumed samples:      3073024 | elapsed time per iteration (ms): 173138.9 | learning rate: 1.361E-04 | global batch size:  1024 | lm loss: 4.484071E-01 | loss scale: 1.0 | grad norm: 0.087 | number of skipped iterations:   0 | number of nan iterations:   0 |
<IP_ADDRESS>:  iteration     3002/   10000 | consumed samples:      3074048 | elapsed time per iteration (ms): 97481.4 | learning rate: 1.361E-04 | global batch size:  1024 | lm loss: 4.572799E-01 | loss scale: 1.0 | grad norm: 0.075 | number of skipped iterations:   0 | number of nan iterations:   0 |
TransformerEngine: 1.4.0

Could you give more details on the cases you are comparing?
Generally speaking there is nothing in the FP8 recipe that would make the result nondeterministic. The typical reason for nondeterminism is FlashAttention, but the fact that you are getting the same results in resuming from BF16 suggests that this is not the problem for you.
Could you do an additional experiment of restarting from the same checkpoint the second time and see if the loss is the same as in point 2 (so the result is different compared to uninterrupted training but deterministic) or a different value?


Leetcode Question Number 1108

Leetcode Question Number 1108 solution needs to be added in the repo .
The link for the question is this.
Accepted Languages C++ / JAVA .
You Only need to add the  class Solution in the file.
Make Sure you have read the contributions guidelines before creating an PR.

assign


test: reorg test suites

move tls_test to parallel e2e
move backup_test.go to e2eslow/backup_restore_test.go

LGTM


Need titles for views

We need titles for table views - use view's title. At the moment we don't have any titles there. This issue will be fixed in dpr-js and datapackage-render-js libraries.
Acceptance Criteria

[ ] when I arrive at the showcase page I am clear about each view

Tasks

[x] https://github.com/frictionlessdata/dpr-js/issues/162
[x] https://github.com/frictionlessdata/datapackage-render-js/issues/38

FIXED


v-slots in Vue 3

Hi!
I'm having trouble using this in Vue 3 has the linter complains about the slot attribute being deprecated and by trying to use the new v-slot attribute the HTML does not get attached to the slot. I've tried the following:
<rapi-doc
  :spec-url="specUrl"
  render-style="focused"
  style="height: 100vh; width: 100%"
  use-path-in-nav-bar="false"
  primary-color="#42a1ff"
  show-header="false"
  allow-server-selection="false"
  sort-tags="true"
  info-description-headings-in-navbar='true'
>
  <template v-slot:nav-logo>
    <img src="https://placeholder.com/wp-content/uploads/2018/10/placeholder.com-logo1.png" />
  </div>
</rapi-doc>

PS: with the slot="nav-logo" attribute it works, it's just the linter that annoys me
Thanks in advance

slot has never been deprecated in HTML spec https://developer.mozilla.org/en-US/docs/Web/HTML/Element/slot
and v-slot has no relation with solt.  v-solt is somthing unique to vue whereas slot is a part of HTML spec
the linter complaining about solt is actually referring to vue slot not HTML slot
if you are using vuter for your linter then
go to .vscode/settings.json and add the following:
"vetur.validation.template": false,

what it will do is make vuter depend on eslint for template validation
next fix your eslint.js to ignore deprecated solt of vue
rules: {
    'vue/no-deprecated-slot-attribute': 'off',
  }

This bug do not belong here,  This should be filed with the linter which is complaining slot is deprecated

Hello! I'd like to re-open this ticket as the Author of the original post, I believe is correct.
The "slot="example" style of applying elements to named slots was deprecated in Vue 2.6+
See: https://vuejs.org/v2/guide/components-slots.html#Deprecated-Syntax
As you are using Vue 3, afaik, then the linting error is accurate. We should be using the newer syntax.


Can you provide the splits?

Hi, thank you for the great work.
Can you provide the train/dev/test splits for the different datasets so we can compare our own model to the models reported in the paper?

We're working on it and we should have everything ready in about a week.


Refactoring python client.

@dumbunny @aaijazi similar to internal fixes.

This change is

@dumbunny PTAL this is ready to go I think. Upon import I'll have to fix stubbyp3 accordingly.

Coverage decreased (-0.01%) to 57.459% when pulling ee73b3a056f52900bbb89749fe5810cb201a1b8b on alainjobart:pythonfixes into 53b3de1d3c7022c6a2caa0a017a8c56608a76e44 on youtube:master.

LGTM

Coverage decreased (-0.03%) to 57.446% when pulling ee73b3a056f52900bbb89749fe5810cb201a1b8b on alainjobart:pythonfixes into 53b3de1d3c7022c6a2caa0a017a8c56608a76e44 on youtube:master.


AddOrUpdate leads to incorrect foreign key update

I am having the same error as the one reported at Stack Overflow: http://stackoverflow.com/questions/20300035/entityframeworks-addorupdate-leads-to-incorrect-foreign-key-update/32281544#32281544
Example:
var state = new State { Name = "NY" }
Context.States.AddOrUpdate(p => p.Name, state);
Context.SaveChanges();
var city = new City { Name = "NYC", Location = "1", State = state }
Context.Cities.AddOrUpdate(p => p.Name, city);
Context.SaveChanges();
var city = new City { Name = "NYC", Location = "2", State = state }
Context.Cities.AddOrUpdate(p => p.Name, city);
Context.SaveChanges();
Exception is thrown, saying Foreign Key StateId = 0
Thanks

@hermesramos This is because of the behavior described in this bug: http://entityframework.codeplex.com/workitem/2128 The workarounds described there should also work here for ensuring that the correct entity instance is used. FYI, we track EF6 issues on the CodePlex site, so that would be the best place to file EF6 issues in the future.


Make 'repl' a rad command.

Symlinks the binary into the old location so find-module-file still
finds it.

Is there not some way to reduce the code duplication with rad/repl.rad?

Hm, I thought I'd symlinked them. Might have been a hardlink that git dereferenced. Let me try again.

@jameshaydon suggested having rad/repl.rad be a module, and bin/rad-repl import that and run the repl function, so that we can have easy REPLs for specific machines (e.g. rad issue repl). Going to do that.

@jameshaydon @MeBrei wanna review again?


Adds frame.children array

This PR is in response to some undesired behaviour that I wasn't able to overcome with the current API.
Consider a situation where I want to allow anchors, but only when they either contain text nodes, or other nodes. Checking for frame.text in the exclusiveFilter() is generally sufficient - but will fail where all inner nodes are self closing tags (and hence don't contain text nodes).
So, for example:
sanitizeHtml('', {
    allowedTags: sanitizeHtml.defaults.allowedTags.concat([ 'img' ]),
    exclusiveFilter: function(frame) {
      return frame.tag === 'a' && !frame.text.trim();
    }
  }
); // => ''

This PR just adds an extra property (children) to the frame passed to exclusiveFilter(). frame.children is an array containing the tag names of any child nodes, it can be used to assert that a frame with empty .text contains self closing nodes.
It could also be used to further tune the behaviour of 'exclusiveFilter()', for example, to allow only anchors that contain a single image tag as per this this test cases.

When is this going to be merged? This is THE missing feature!

@axdg This works but only for single nested children. So the following doesn't work and results in children: [] You might want to check

@satyavh, I'm not entirely sure what you mean... The PR creates an array of the children's tags names, so it does keep track of multiple children. If these children themselves have children, then they can be checked in their own filter callback.

What I mean is, this doesn't work:

when you log this out:
exclusiveFilter: (frame) ->
   console.log frame

then children:[] never contains the img tag.
I'm not sure what goes wrong, can't really put my finger on it.

In the above case (where we are in the
's callback), the children array will not contain the image tag, as it is not a child of the paragraph. The second spans callback can be used to check that the image tag is present though...

Sorry for the delay, everyone.  This would help resolve #313 as well.

I'm closing this since the merge conflicts are too severe. The index.js file was moved to another directory. Please follow #313 for progress.


Tectonic support

Does this template work with tectonic? Is so, what is the recommended workflow?

I don't think it currently does. It's been a while since I tried tectonic (tried to make it work with VS Code), and I won't have the time for a while. If you have the time and can create a neat source structure that works, I'd be happy to add it to the wiki. 😊


stop vm before generalize

After the command completes, enter exit to close the SSH client. The VM will still be running at this point.
*** tell the user to stop the VM ****
Then the VM needs to be marked as generalized on the platform.
az vm generalize
--resource-group myResourceGroup
--name myVM

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83917921-2dc0-42a9-1b99-cce2fca9961a
Version Independent ID: 3812c21e-a5f6-af8d-17b5-05a2635d8b1d
Content: Generalize a VM before creating an image - Azure Virtual Machines
Content Source: articles/virtual-machines/generalize.md
Service: virtual-machines
Sub-service: imaging
GitHub Login: @cynthn
Microsoft Alias: cynthn

@mfthomps Thanks for the feedback! We are currently investigating and will update you shortly.

@mfthomps Thank you for bringing this to our attention!  I'm seeing the error I believe you are referring to.  I'll get a PR out to update the steps.
"Operation 'generalize' is now allowed on VM 'myVM' since the VM is running.  Please power off explicity in case you shut down the VM from inside the guest operating system."

@cynthn I'll include you on the PR.  Everything looks in order with a stop added to the steps:


fix(HoverCard): avoid opening for quick hovers

Hello!
This pr fix the bug of issue https://github.com/radix-vue/radix-vue/issues/994
A hovering ref was added to check after the open delay time if the mouse is still waiting for the content
New behavior:
https://github.com/radix-vue/radix-vue/assets/10001036/b1c84286-05b6-422b-ab27-439518f76e22

Thanks again for the changes ya @ianfireman .. after digging deeper I realized it could've been more direct to use isPointerInTransit ref directly instead of adding another 2 refs and condition.
Do you mind if I push some of the changes to this PR? 😁

Not at all! Please do it

gj chefs! 🫡


RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation

I am using Python 3.5, Pytorch 0.3.1
I get the following error when using any of the InPlaceABN variants:
RuntimeError: one of the variables needed for gradient computation has been modified by an inplace operation
I looked through the code of in-place abn and found the following lines in functions.py
# Update running stats
running_mean.mul_((1 - ctx.momentum)).add_(ctx.momentum * mean)
running_var.mul_((1 - ctx.momentum)).add_(ctx.momentum * var * n / (n - 1))
Could these lines be triggering this error? Changing these to non-inplace operations resulted in another error related to storage of variables.
Kindly help.

@mathmanu maybe having a look to https://github.com/mapillary/inplace_abn/issues/6 helps you in fixing the issue.

Thanks. There was an inplace residual connection that caused the problem. Since there cannot be two back to back in-place operations, that caused an error.


bug: Ionic v4.9.0 hamburger menu icon not displayed with prerendering (regression)

Bug Report
Ionic version:
[x] 4.x
Current behavior:
When I upgrade to @ionic/core v4.9.0 the hamburger menu icon isn't displayed anymore if I prerender my application. This doesn't happens with v4.8.1.
Expected behavior:
Same behavior if prerendered or not.
Related code:
Nothing particular but here's my implementation: https://github.com/deckgo/deckdeckgo/blob/9e3faf6ec71c18e4fccd7e6d49eabcf172460b8d/studio/src/app/app-root.tsx#L131
Screenshots:
v4.9.0

v4.8.1

I did some more testing today, as I'm still unable to upgrade, and figured out the following:

The following is ok with v4.8.1 but breaks with any newer version of Ionic

<ion-menu content-id="menu-content">
</ion-menu>

<ion-nav id="menu-content"/>

=> Error Menu: must have a "content" element to listen for drag events on.

Modifying contentId to content-id do solve the error in the console but it render a button which has no effect. I could click on it multiple times, the menu is not bind and will not be opened

Finally, styles are not applied

Just upgraded again to the very last version (ionic/core v4.11.1 and stencil/core v1.7.2) and after having modified contentId into content-id it worked out, I didn't face error anymore.
Therefore I close my request.


[WIP] libnd4j: Provide a C API

What changes were proposed in this pull request?
libnd4j already exposes an interface that is mostly C in NativeOps.h, but it is still C++, making it less portable than it could be. Here we adjust the function declarations to export them as actual C functions. Tasks to be done:

[x] Refactor NativeOps.h to export C functions
[x] Adapt the Java wrappers in ND4J generated with JavaCPP
[ ] Create C wrappers for some of the C++ classes currently used by ND4J

How was this patch tested?
All builds pass and existing unit tests are not broken.

Looks great, but one question: why to eclipse directly and not to fork first?

Merged to https://github.com/SkymindIO/deeplearning4j/tree/master


Support full-speed and disengaged levels

It would be great if the fan could go up to full-speed and for limited time even disengaged.

We already go to disengaged when below low_temp, and to max speed at max_temp. Could you please explain further if you meant something else?

From kernel.org:

Where  is an integer from 0 to 7, or one of the words "auto" or
"full-speed" (without the quotes).  Not all ThinkPads support the "auto"
and "full-speed" levels.  The driver accepts "disengaged" as an alias for
"full-speed", and reports it as "disengaged" for backwards
compatibility.

Disengaged/full-speed will run at a faster speed then Level 7. I thought there was a difference between disengaged and full-speed, but that appears to have been just for backwards compatibility. Disengaged doesn't mean "no fan" but "no rpm control".
Level 7 are just ~5250 rpm on the Thinkpad X1C, Disengaged are almost 7000rpm.

So it looks like there needs to be a test for full-speed support prior to setting it. I'm not against it, but I need to check how this failure looks like (since full-speed works on my T14s).

Seems it reports whether full-speed is supported: https://github.com/torvalds/linux/blob/ab0a97cffa0bb3b529ca08b0caea772ddb3e0b5c/drivers/platform/x86/thinkpad_acpi.c#L9047-L9059
The error if full-speed isn't supported should be the same as if you pass any other invalid value if I'm not mistaken.
https://github.com/torvalds/linux/blob/ab0a97cffa0bb3b529ca08b0caea772ddb3e0b5c/drivers/platform/x86/thinkpad_acpi.c#L8262-L8265

Well, annoyingly it doesn't propagate it to userspace and just logs:
static int fan_write_cmd_level(const char *cmd, int *rc)
{
	int level;

	if (strstarts(cmd, "level auto"))
		level = TP_EC_FAN_AUTO;
	else if (strstarts(cmd, "level disengaged") || strstarts(cmd, "level full-speed"))
		level = TP_EC_FAN_FULLSPEED;
	else if (sscanf(cmd, "level %d", &level) != 1)
		return 0;

	*rc = fan_set_level_safe(level);
	if (*rc == -ENXIO)
		pr_err("level command accepted for unsupported access mode %d\n",
		       fan_control_access_mode);
	else if (!*rc)
		tpacpi_disclose_usertask("procfs fan",
			"set level to %d\n", level);

	return 1;
}

It seems we can look at commands, though.

Hm, looking at strace when I'm running echo 'level 10' | sudo strace -f -s 1024 tee /proc/acpi/ibm/fan shows to me that the error propagates, at least for my example when setting a value that isn't supported. But the code I linked before is also doing EINVAL for when full-speed isn't supported.
This is how it looks in strace
write(3, "level 10\n", 9)               = -1 EINVAL (Invalid argument)

Thank you for the fast implementation, just build and verified it's using the highest level now.
Have a good weekend.

you too!


[ Document Issue ] - Getting Started - Creating an Application

http://t3js.org/docs/getting-started/application
Box.Application.init({
    debug: true;
});

Should it be debug: true instead of debug: true; ?

You are correct, I'll fix it with some other documentation changes

Thank you, t3js is great!


Improper k8s permission configuration

Summary
The ack-kruise-game in ACK gave excessive authority when defining Service Account named "kruise-game-controller-manager". Besides, this Service Account is mounted in a pod named "kruise-game-controller-manager-675bb6974d-4m6d7", witch makes it possible for attackers to raise rights to administrators.
Detailed Analysis

The clusterrole named "kruise-game-manager-role" defines the "create" verb of "pods, statefulsets, mutatingwebhookconfiguration". And this clusterrole is bound to the Service Account named "kruise-game-controller-manager".

# Attacking Strategy
  If a malicious user controls a specific worker node which has the Pod mentioned above , or steals the Service Account token mentioned above. He/She can raise permissions to administrator level and control the whole cluster.
For example,

With the "create" verb of "pods, statefulsets", attacker can elevate privileges by creating a pod to mount and steal any Service Account he/she want.
With the "update" verb of "mutatingconfiguration, validatingconfiguration", attacker can elevate privileges by updating MutatingWebhookConfigurations to listen and modify any resource and event in the cluster.

Mitigation Discussion

Developer could use the rolebinding instead of the clusterrolebinding to restrict permissions to namespace.
Developer could delete the "create" verb of "pods, statefulsets, mutatingwebhookconfiguration" in clusterrole mentioned above.

# A few questions

Is it a real issue in ack-kruise-game?
If it's a real issue, can ack-kruise-game mitigate the risks following my suggestions discussed in the "mitigation discussion"?
If it's a real issue, does ack-kruise-game plan to fix this issue?

Actually, kruise-game & kruise controller manager indeed need create verb, whose permissions are already restrict. If you use multi-tenant Kubernetes clusters, it is necessary to consider cluster security. I recommend avoiding user YAML being deployed directly in the cluster. It is a better way that checking if those YAMLs use service accounts with high permissions before deployment.

By the way, you can join the DingDing Group 44862615, to communicate with ours (including OKG maintainers, and Game Developers)

Hi @chrisliu1995 ,
Thank you for your reply!
Did Kruise need to create pods in another namespace? If not, maybe we could use rolebinding to further restrict this permission.
Thanks again.

You know, kruise can not decide which namespace the user deploy applications in. If user deploy GameServerSet in x-namespace, kruise & kruise game controller manager have to create asts & pods in x-namespace. In fact, it is cluster-scope action.

Well, Thank you for your patient explanation!

I apologize for bothering you again, but I just wanted to confirm once more if kruise-game necessarily requires the update permission for the mutatingwebhookconfiguration resource. It seems that once the mutatingwebhookconfiguration resource is set up during the application installation, it typically does not need to be updated.
:)


Use BCI image and bump to 15.4

Align to standardized bci-base
Bump to 15.4 as 15.3 is EOL

@alexander-demicev can we have this PR merged and a new RC cut, please? This will help address some low-hanging CVEs in OS level packages.


Allow moving the home point for the bed.

Oshik Nissim "What I meant was if one wants a specific point on their cutter bed to be in coincidence with meerk40t 0.0 points - is there a way to move your canvas to accomplish this?"
There should be some method for doing this. And maybe have the home command return to to the new location within the bed position. So if you set a home point that is not the origin point the 0-0 for the guides is set to position from that point and homing the machine will cause it to send a HOME command, but also then move back to the home point. Usually this would be something like the upper right of the piece you'd be working on.

There's some cursory work with this generally the request is that the system should return to a given position. Currently the keymapping though it doesn't save it, allows you to hit the Q key and "set_postion Q" which then remaps Q to mean return to whatever position you were at when you hit Q the first time. It needs some work still but this can be set by allowing hotkeyed favorite locations.

I added the stub-options for this in the last GUI update. In 0.2.2 still needs to be hooked up and implemented though. There's some elements of this request that cannot be solved with a mere keymap.

This was added in 0.5.1.


Check for buffer overflow in prerendered variant

In the prerendered variant one can pass a iterator with more elements than LEDs, which leads to a buffer overflow.
This PR fixes this by adding a new error type for the prerendered variant.
pub enum Error<E> {
    OutOfBounds,
    Spi(E),
}

Now the current index will be checked in write_byte()  and return an OutOfBounds error if it will exceed the data buffer size.

Thank you, this looks good!


chore: Allow codecov job to filter unnecessary files - Triage finschia-sdk#197

couldn't find anything to keep


Update to 2.8.1 and change url to maven central

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@BorisOsipov thanks!


Provide utility environment variables to meta-exec

🚀 Feature Proposal
Have things like current folder name (just the name, not the full path) as an environment variable you can use in commands
Motivation
Take this for example. I have three repos (two python repos & one node)

And I run the following command:
$ meta exec "[ -f requirements.txt ] && echo dir:`pwd`" --include-only=python-project-1,python-project-2,node-project-2

The context or current working directory is still where I ran the command from. It would be good to have access to such things when running meta-exec. But I don't know if this should be in loop or meta-exec. An environment variable like META_CWD. See example below.
Example
Say I want to create virtual environments for all my python projects with just the folder name as the venv name.
$ meta exec "[ -f requirements.txt ] && python3 -m venv --prompt $META_CWD   .venv"

Currently there is no easy way to do this so I just manually create my virtual environments. Hope I am making sense.

Makes sense
try xargs though
meta exec "pwd | xargs basename | xargs echo"

for venv
meta exec "pwd | xargs basename | xargs python3 -m venv .venv --prompt"

For example:
meta exec "pwd | xargs basename | xargs python3 -m venv .venv --prompt" --include-only=plugins/meta-loop

What manner of sorcery is this? And why does this work lol?!

You were having trouble with environment variables - the command pwd always worked directly.
Seems that when you use in as env var it gets evaluated before being executed in each repo.
so pwd returns the directory name.. then it is piped to xargs which, as a simple explanation, basically puts it as an argument to the command..
basename gets the directory name, and the result of that is piped to the next xargs command.

I didn't try this before, but escaping the `'s also works:
➜  meta exec "echo `pwd`" --include-only=plugins/meta-loop

plugins/meta-loop:
/Users/patrickleet/dev/mateodelnorte/meta
plugins/meta-loop ✓

➜  meta git:(patrickleet-patch-1) meta exec "echo \`pwd\`" --include-only=plugins/meta-loop

plugins/meta-loop:
/Users/patrickleet/dev/mateodelnorte/meta/plugins/meta-loop
plugins/meta-loop ✓

I added a note to the README: https://github.com/mateodelnorte/meta#how-to-escape-expressions

Legend, thanks.


feat: 🎸 Add interpolation to configuration

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
You cannot specify your own regular expression for matching parameters.
Issue Number: #323
What is the new behavior?
A new transpiler has been added that adds the possibility to specify your own regular expression for matching parameters.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@Waterstraal Thanks for the PR!
I don't think this should be an actual transpiler, I believe that a property in the config is more fitting here.
Can you replace the transpiler with the interpolation config property and consume it in the defaultTranspiler?
It should support the following values:

A Regex
An array that indicates the start and end markings ([start, end]: [string, string]).

A couple of things to keep in mind:

Validate that the input.
If a regex is provided we need to make sure the global flag is present.

@Waterstraal Thanks for the PR!
I don't think this should be an actual transpiler, I believe that a property in the config is more fitting here.
Can you replace the transpiler with the interpolation config property and consume it in the defaultTranspiler?
It should support the following values:

A Regex
An array that indicates the start and end markings ([start, end]: [string, string]).

A couple of things to keep in mind:

Validate that the input.
If a Regex is provided we need to make sure the global flag is present.

Good suggestion. I pushed a new commit that adds interpolation to Transloco config

@shaharkazaz I was wondering whether we should make TranslocoConfig a required field in DefaultTranspiler's constructor that all derived transpilers have to pass it in. This prevents a potential issue with a user configuration that specifies a custom interpolation in combination with a custom transpiler that doesn't pass the TranslocoConfig in. Your thoughts?

@Waterstraal that would make it a breaking change and we don't want that 🙂  maybe in v3 😉
Regarding the MessageFormatTranspiler, we need to pass the config there.

@Waterstraal that would make it a breaking change and we don't want that 🙂 maybe in v3 😉
Regarding the MessageFormatTranspiler, we need to pass the config there, nice catch.

Shall I update MessageFormatTranspiler?

@Waterstraal Yes, please test it in the playground and make sure everything is working as expected.

@shaharkazaz I updated the transpiler and added some specs and udpated cypress to verify it's working. I tested it manually on the playground by adding interpolation settings and updating message bundles. It's difficult in the current setup to have multiple instances of TranslocoConfig provided in the playground I think? Thant would be ideal to test multiple scenario's.


🐞 Version check issues

Summary
Currently the version check(s) have various small errors/bugs.

Invalid parameters are passed when called via nox
On some platforms (e.g. windows color needs to be turned of explicitly)

Details
Parameter Issue
version-check fails
$ version-check -f github_issue_adapter/version.py
Error while executing program, details: Couldn't find version within module

File exasol/toolbox/nox/tasks.py
Remove --fix
command = ["poetry", "run", "version-check"]

Color Escape Sequences Issue
File exasol/toolbox/pre_commit_hooks/package_version.py
Add option --no-ansi
result = subprocess.run([poetry, "version", '--no-ansi'], capture_output=True)

Hello @MarleneKress79789 I tested both changes successfully.
Test strategy change I (remove option --fix):

I checked out the branch of the PTB corresponding to the current ticket
in the working copy of my repo I called poetry add ..\python-toolbox
I called poetry run version-check github_issue_adapter/version.py without -f and did not observe an error
I called poetry run version-check -f github_issue_adapter/version.py and did not observe an error, either

Test strategy change II (add optino --no-ansi):

I called poetry run python -m exasol.toolbox.pre_commit_hooks.package_version github_issue_adapter\version.py  and did not observe any error, anymore.

Strangely removing the option --no-ansi in my virtual poetry env did not show any error, either. But the change probably still improves the stability and does not cause additional problems on windows, either.
So from my perspective I can safely approve the changes based on my review results.


Remove references to the develop branch

This change is related to amethyst/amethyst#924.
This is related to #101

I really would have preferred you did not merge that so quickly, as there’s a bunch of issues I now want to fix.
Why is master the recommended source? It feels like anything but good for a default. The color theming is inappropriate now too, as red is supposed to identify the bleeding edge.
We also absolutely need examples for current releases. Not having it is a no-go for me, as I stated it in other places.
I think the documentation page deserves a complete redesign, because the 2 things architecture no longer is appropriate.

@Moxinilian Sorry, I mentioned why I did it quickly on discord. Anyways, we should be recommending either a released version on crates.io or the master branch. The colors we can change, but I don't think its a blocker as of right now. Feel free to fix it or make an issue for it. The examples can be found via this link, https://github.com/amethyst/amethyst/tree/2deccbb8042c1eccdaacc9091ffbf234976f1473 which is the commit for v0.8.0. What we need to do is find a way to insert the latest version into gutenberg and use that to build the url to the examples. This is the final link we should use for examples on the website, and we want this to change automatically as we release new tags. https://github.com/amethyst/amethyst/tree/2deccbb8042c1eccdaacc9091ffbf234976f1473/examples
I agree it could use a redesign but right now it does the job, even if it doesn't do it optimally. 😄

I got no response when I suggested keeping a “latest-release” branch to make everything simpler regarding both links and release deployment, yet it solves all of the issues at once.

@Moxinilian I'm pretty sure, we had agreed in the original issue that we did not need that, and again, a tag is a branch, so there is no need to have a latest that just becomes stale, imo. You should be able to just append a config variable to the gutenberg config with the commit hash and achieve the same result, without needing a latest branch.

And as a side effect require either manual maintenance or a hacky generate.sh cluttering the website.

@Moxinilian Nope, actually, it is one git command to fetch the latest tag, from that you can get the commit hash. Appened a variable for both the tag and the commit hash. And you can use those to build the URL. It's not hacky and it is actually a lot cleaner and clearer. If you want to hop on discord and continue lets do that. 😄


Multiprocessing of regression test

I am wondering if there is a good way to run these regression tests in parallel using simple joblib applications.
Running the code below:
def main_test_runner_per_market(dataframe_regression, num_regression, data_regression):
      pass

markets = ["Market_1", "Market_2"]
sub_regression_tests = [
    delayed(main_test_runner_per_market)(dataframe_regression, num_regression, data_regression, market)
    for market in markets
]
Parallel(backend="multiprocessing", n_jobs=-1)(sub_regression_tests)

Returns :

" Can't pickle local object 'ArgumentParser.init..identity " error when running the following:

@pedro-alves-dv this is out of scope for pytest-regressions, which just provides fixtures to generate/check regressions. Running tests in parallel is better left to dedicated plugins, like pytest-xdist or pytest-mp.


Spec: Add PCR values to TPM Configuration

📄 Description
Coming soon!
⚡ API Changes
Coming soon!

👥 Usage scenarios
Coming soon!
🔙 Backward Compatibility
Coming soon!
🤔 Difficulty
Medium

Hi

Api i being rewriten will release tonight

bug is fixed with latest api changes pcr now shows value
TpmManagerFinal.zip
use the tpmmanager.cs in rebound tpm

🥳


Using cl-lib over cl

Hello, thanks for the awesome tutorial!
When editing and running this, my Emacs keeps warning about the deprecation of cl library, instead suggesting to use cl-lib. GNU's Emacs Common Lisp Emulation documentation also seems to suggest likewise.
Should we follow this convention? There is an annoying side effect of prefixing every macro usage with cl-

Yup, resolved by #16 though the change hasn't been packaged up in its own release.
Closing this issue.


Possibly add simplified contracts

So a full contract system like contracts.coffee due to its dependence on Proxies and a runtime library can't be added CoffeeScript proper. However, I think there's a way to add simplified contracts that doesn't require proxies or a library by adding straightforward pre and post assertions.
For example
square :: (Num) -> Pos
square = (x) -> x * x

Becomes something like
var square;
square = function(x) {
	var res;
	if (typeof(x) !== 'number') { throw "failed contract"; }
	res = x * x;
	if (res < 0) { throw "failed contract"; }
	return res;
}

Probably could even do higher-order stuff by wrapping function arguments
sort :: (Array, (Num) -> Bool) -> Array
sort = (arr, cmp) -> ... cmp y ...

Becomes
var sort;
sort = function(arr, cmp) {
	var checked_cmp;
	checked_cmp = function(x) {
		var res;
		if (typeof(x) !== 'number') { throw "violation"; }
		res = cmp(x);
		if(typeof(res) !== 'boolean') { throw "violation"; }
		return res;
	}
	... checked_cmp(y) ...
}

Without a runtime it probably won't be able to transparently do full object contracts (guarding property write), object invariants, or correct blame (requires modules, even if pseudo-faked as in contracts.coffee).
But I think it would still be a useful/clean/expressive way of putting pre/postconditions in your code.
Do people think this is something useful and a good fit for CoffeeScript? If it has a chance of getting in I can work on a patch.

:+1:, good idea for coffee. I wonder how this would affect performance. contracts.coffee slowed down JS 50x-100x times. This seems to be a simple checking that could be JITed by browsers, so the actual slowdown would be only 1.5x-4x.
Just in case someone don't know: Clojure is dynamic language too and it has contracts. And they fit greatly there.

I wonder how this would affect performance. contracts.coffee slowed down JS by 98%. This seems to be a simple checking that could be JITed by browsers, so the actual slowdown would be only 1.5x-2x to code without any checkings.

Yep, since we wouldn't be doing anything fancy with Proxies and a runtime I'm pretty sure the performance impact would be minimal. Especially when you consider that you often already have ad-hoc assertions which could simply be replaced with the contract assertions.

The impact on runtime performance would be minimal, but the impact on byte size would be large. You might suggest having a flag to add these type checks for debugging, but then the question is: Why should this be part of CoffeeScript, rather than a JavaScript postprocessor?

The impact on runtime performance would be minimal, but the impact on byte size would be large.

I'm not sure that's true. You would be adding a couple of lines per
function definition. A bit more in the higher-order case but not
anything drastic I think.
And these would just be replacing hand written assertions anyway.

You might suggest having a flag to add these type checks for debugging, but then the question is: Why should this be part of CoffeeScript, rather than a JavaScript postprocessor?

I would actually rather there not be a flag to turn them off. It would
lead to different behavior between testing and production for no real
gain IMO. contracts.coffee needs a flag for performance and
compatibility reasons but I don't think it would be necessary for
simplified contracts.
The reason I think it would be nice in CS vs. just a postprocessor is
for the cleaner/clearer/DRY syntax.
Also, it's much more than just type checks. If contracts were just
typeof tests then yeah, just use the closure compiler and call it
good. But contracts can be arbitrary predicates. So stuff like x > 0 and x < 42 or x?.name isnt 'Evil Attacker' etc.

@TrevorBurnham contracts are NOT type checking, it's a well-known software design technique that has absolutely no connection to static type checking. Otherwise, creators of such dynamic language like Racket wouldn't put something like that there.

@disnet I would be happy to use this optimized contracts even if it's not part of coffee, though.


image map require error

Please, help to solve the current problem.
Node version:
6.2.2
npm version:
3.9.0
Operating system:
win10
Steps to reproduce:
map list with images. problem with image src={require(image)}
const images = props.postcardImages.map((image, i) => { return (
 {props.setPostcardActiveImage(image);}} key={image + i}> <link to="/postcard-edit">  </link>
 ); });
image - string with image path. if i put just string(not variable) it works fine, but i need to map it. when i try to do this staff i get the error:
Uncaught Error: Cannot find module '../images/postcard.jpg'.(anonymous function) @ Uncaught TypeError: Cannot read property '__reactInternalInstance$f26nyhc5w3kdfida23zph9f6r' of null
so i cant to pass into require variable, just a direct string path. but how i can map a many images with different pathes.
Config:
output: {
path: ${__dirname}/src,
publicPath: '/',
filename: 'bundle.js'
},
resolve: {
root: path.resolve('./src')
},
{test: /.(jpe?g|png|gif)$/i, loaders: ['file']},

If you search on "webpack require dynamic", you'll get many helpful articles. Also see https://github.com/webpack/webpack/issues/118.
Closing this issue since it is not a problem in file-loader.


update create.blade.php

removed space

The issue is that composer require does not update the files. In the future if users want to update they need to execute composer update herpaderpaldent/seat-groups


[Bug]: Issues on the Steam name of the leaderboard

What happened?
(1) For users with multiple Steam accounts, the name on the leaderboard always corresponds to the earliest logged-in local Steam account, regardless of whether that account has Fall Guys or not, rather than the latest one.
(2) If you delete the relevant account, the leaderboard name will change to the second earliest account. Your previous records uploaded to the leaderboard will be retained, which means that if you break your records again, the new records might appear duplicated.、
Can we choose the steam profile we want to display, or we can choose to set up a unique name inside the stats? Thanks!
Platform
Steam

Can you send me the loginusers.vdf file in the config folder of the Steam installation folder by email<EMAIL_ADDRESS>

Can you send me the loginusers.vdf file in the config folder of the Steam installation folder by email<EMAIL_ADDRESS>
Sure

Try it in v1.305.

After the update I cannot have my records uploaded any more.
For example I got new PBs in Treetop Tumble and a UGC level in the show tab, but there isn't any records on the leaderboard.

I checked my settings and it's fine.
Also I noticed that the stats won't recognize me as tianbaba and RainbowStays RU any longer, which were mine previously. It's kind of strange.

Please email me your data.db file<EMAIL_ADDRESS>

I have sent the email earlier, and today I backuped and deleted my old db file and try to start a new profile, but I'm still not be able to submit to the leaderboard even if I broke records many times for many levels. One of my friends has the same issue. Maybe the problem it's not related to the data.db file.

I haven't received any emails.

I sent another email attached with the old and new data.db file. Let me know if you don't receive any email.

I'm still not receiving any emails. Please check again.

Try it in v1.309.
For records already registered, manual deletion is required.

Fixed. Thanks!


Revert "Fix incorrect client ID restriction behavior."

Motivation
If the ClientId represents a Client already connected to the Server then the Server MUST disconnect the existing Client

Codecov Report

Merging #559 (4f8a04c) into master (51046ed) will decrease coverage by 0.42%.
The diff coverage is 71.87%.

@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
- Coverage     75.13%   74.70%   -0.43%
+ Complexity      631      621      -10
============================================
  Files            86       85       -1
  Lines          2883     2858      -25
  Branches        204      199       -5
============================================
- Hits           2166     2135      -31
- Misses          592      596       +4
- Partials        125      127       +2

Impacted Files
Coverage Δ

...dlers/mqtt/support/handler/AbstractAckHandler.java
58.46% <38.46%> (-3.52%)
:arrow_down:

...ve/pulsar/handlers/mqtt/MQTTConnectionManager.java
85.18% <87.50%> (-3.28%)
:arrow_down:

.../streamnative/pulsar/handlers/mqtt/Connection.java
85.27% <100.00%> (+0.11%)
:arrow_up:

...rs/mqtt/messages/factory/MqttConnectAckHelper.java
70.21% <100.00%> (-5.79%)
:arrow_down:

...s/mqtt/proxy/MQTTProxyProtocolMethodProcessor.java
59.65% <100.00%> (-1.55%)
:arrow_down:

...tt/support/DefaultProtocolMethodProcessorImpl.java
78.43% <100.00%> (-0.49%)
:arrow_down:

...e/pulsar/handlers/mqtt/utils/PulsarTopicUtils.java
75.80% <0.00%> (-1.62%)
:arrow_down:

...ar/handlers/mqtt/support/MQTTMetricsCollector.java
99.01% <0.00%> (-0.99%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51046ed...4f8a04c. Read the comment docs.


Thank You For Making This Repository Public

Just decluttered some of the unecessary code, and made my private repo public here. Still need to clean it up to be ready to be a package, but it has all the functionality.

Thank you very much for taking this action, and of course also for the work you've put in to the forecasting tools! This issue exist just to say Thank You and can be closed once read.
Thus far, I've played with your site to compete with the AI in Fermi estimation. Something I would like to see (my apologies if this already exists) is some way to make the underlying AI operate at different levels of ignorance. In asking it how many pianos Chicago has in 2024, some of the information it retrieved was quite specific. While I am not sure how this could be done, it would be nice if there was a feature to limit the information available to it about the world.
I might make a PR adding pre-commit (see here), environment control with poetry (see here), and an updated .gitignore. Let me know if you are completely against these measures; in this case I will not add any of the aforementioned elements.

Hey @AFg6K7h4fhy2! Thank you for the kind words!  Feel free to add those changes. Poetry was on my list of things to do, and I'm interested to experiment with pre-commit as I have not used it before (right now there are just settings in .vscode that apply the black formatter on file save).


feat(UI): take back to learn map after finishing a block

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #49170

Now, campers are taken back to the map after finishing a block instead of directly starting the next block step-1 in Responsive Web Design Certification.

Hey @moT01, Can you please review this and let me know if any changes are to be done?

Please rebase and make sure the tests are passing. Thanks.

Please rebase and make sure the tests are passing. Thanks.

Done sir. Now all tests are passing and also I've done the rebase.

Please rebase and make sure the tests are passing. Thanks.
I have successfully done the rebase as you mentioned and also all tests are passing except Firefox.

You would need to update the test for the changed functionality. We have outlined working with tests in our guide. Please reach out to the Discord chat for more help :)

This PR now has irrelevant changes.
I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request

This PR now has irrelevant changes.
I am unsure if you are trying some different method, but this project has specific guidelines about rebasing. There are detailed in the guidelines we linked earlier: https://contribute.freecodecamp.org/#/how-to-open-a-pull-request?id=conflicts-on-a-pull-request

I tried running all the commands following the document that you sent. But still, the tests are failing because of the files that were edited after syncing fork. Please help me out.

I have solved the issue and also all the tests are passing. Kindly review and please let me know any suggestions/changes required. And sorry for the errors that I had made. This being my first contribution, I faced some errors. I'll be more careful from next time onwards.

Thank You so much. I'll do this.

So @DEVelooper29 do you need any help with the PR still ?

I made a few updates to this - it should be good to go.

Do we want to take the camper back to the project they just completed, or to the next project?

Either way works. I like both for their own reasons. Back to the project they just completed means they can see their checkmarks (also, that's how this PR is atm). To the next project is where the next challenge is, so maybe that's better - don't know.

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 🎉


NERDTree is affecting the jumplist

When editing a file I frequently use CTRL-o and CTRL-i to navigate through previous cursor positions. But NERDTree is adding entries to the jumplist so CTRL-o does weird things like opening another instance of NERDTree in the main buffer.
Is there a workaround for this, to prevent any NERDTree entries from going into the jumplist?

@ajwrigley I've been trying to fix this for a while, Sadly there is no real way of getting rid of it. You can mark the buffer as hidden to prevent it from coming up in the jumplist but it does break other functionalities.
Even Vim's built-in file explorer netrw has this gimmick, I'm going to mark it as not planned since even if it is possible to fix it needs a huge time investment and doesn't really provide enough value to anyone's workflow.
Don't let my reasoning discourage you from fixing it and creating a PR addressing this issue, I would welcome such change and I'll even help you in the process if you get stuck anywhere.


Definitely not an issue

I was looking for the exact same stack for the last 5 months and found it today in your repo. I find it really helpful. Will you please be able to help me more or tutoring me? Thanks in advance. Please consider

Hi there, I unfortunately don't have much time available for personal tutoring. I am passionate about education but given my constraints it makes more sense for me to put my efforts into resources that many can learn from (like this template!)
If you want to send over questions, perhaps I can use them to start building out documentation and an FAQ on this repo.


feat: use the actions library for linkedin posting

Tested using managed browser.
https://www.browserbase.com/sessions/8eda1e06-bf1a-40b6-9d38-df7bc0df30b3

Remove the linkedin, instagram and amazon libraries in favor for the actions library.

The other actions aren't supported by the actions library yet


genMockFromModule has no cleanup mechanism

🐛 Bug Report
For some projects, it can be necessary to configure heavy-weight mocks like database instances (e.g. mongodb-memory-server). To facilitate easier test development, we configure such mocks in common files like mockDb.js, which uses jest.mock to mock out the db.js file. This works well until someone calls jest.mock('/path/to/module'); to use genMockFromModule, which indirectly re-invokes the mockDb.js module and creates a new instance of mongodb. The cleanup is supposed to happen in afterAll, but since the module registry is fresh the cleanup hooks don't get tracked and the eventual afterAll can't clean up the extra database instances. It's also problematic because there are additional database instances, and that's rather expensive.
To Reproduce
Steps to reproduce the behavior:

Mock out some file with a resource that needs cleanup
(Auto-)mock a file that imports the mocked resource file
Run jest, observe no exit

Expected behavior

Using genMockFromModule with a jest configuration that mocks persistent handles should not retain those handles.
This may require additional API surface to solve, such as some mechanism separate from setupFilesAfterEnv to load side-effectful mocks, or some accessor to detect when in a temporary/isolated generation environment.
Link to repl or repo (highly encouraged)
https://repl.it/repls/WorthwhileImpeccableClients

envinfo
  System:
    OS: Linux 5.4 Debian GNU/Linux 9 (stretch) 9 (stretch)
    CPU: (4) x64 Intel(R) Xeon(R) CPU @ 2.30GHz
  Binaries:
    Node: 12.18.3 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.6 - /usr/local/bin/npm
  npmPackages:
    jest: ^24.9.0 => 24.9.0

After writing this up, I suppose this might instead be a feature request; feel free to reclassify!

Another possible solution would be to add a configuration option to disable this line:
https://github.com/facebook/jest/blob/7723ae221a220f385ef4711589648611b7015045/packages/jest-runtime/src/index.ts#L1235
This small change would fix this use-case without significantly decreasing the value of createMockFromModule.


[Calendar] Fix vertical alignments

What does the pull request do?

Fixes the vertical alignment of various items in the Calendar in the Fluent theme. Changed the VerticalContentAlignment of the header to Center (fixes #7333), and also removed the bottom padding from CalendarButton and CalendarDayButton to better vertically align the day/year numbers.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Thanks for taking the time to fix this as it relates to #7333!


noise in rendered image when optimization

When I optimize the BSDF and the environment map, there are noises in the rendered image. The noises are similar to this
.
How can I avoid these noises and get clear image? I use the direct integrator with 1 bsdf sample. And the spp is 8, texture resolution is 1024 and the rendered image resolution is 512.

When spp is low (like 8spp), the rendered image definitly will have variance... If you are limited by the gpu memory, you can decrease the image resolution and increase the spp. In addition, I suggest you enable MIS by setting bsdf sampling to 1 and emitter sampling to 1.
Also for the forward pass, you can also use loop to average mutiple noisy image to generate a clean image.
For the backward pass, you can accumulate mutiple gradient value to get a better gradient estimation.

Thanks for your advice. I will try as you suggested.


Memory leak on abnormal Joulescope disconnect

Joulescope UI 0.6.8
Win10x64
Under normal conditions, the Joulescope UI memory usage is good.  However, under some abnormal disconnection situations, the Joulescope UI does not free the device (or at least the stream buffer instance).  Joulescope UI normally takes about 900 MB RAM usage with a 30 second buffer.  I was able to forcefully disconnect and reconnect (by quickly unplugging the USB connector).  By repeating this twice, I now observe 2427 MB RAM usage.
References:

https://forum.joulescope.com/t/gui-lock-up-lots-going-on-in-log-file/171
Direct email with subject "Great product, memory leak?" from 10/23/2019.

I have an easier way to duplicate this issue.  Select Device → disable, then Device → Joulescope:xxxxx.
Likely a circular reference:
Device → View as _process_objs callback
Device → StreamBuffer as attribute
View → StreamBuffer as attribute
StreamBuffer.callback → MainWindow
MainWindow → Device
Need to find the right place to break up the chain with weakref.

Manually adding gc.collect() at end of MainWindow._device_close() seems to fix the issue.  So, looks like the garbage collector is able to identify the circular reference, and active objects no longer have any direct or indirect reference to the StreamBuffer.

Fixed in 0.7.0


Please help me remove my hotspotes from deny list please

Joyful rose dog
Gentle bone goose
Abundant sapphire swift
<EMAIL_ADDRESS>

Hi @Gagi1984  this request isn't a HIP and should follow the instructions to remove a hotspot from the Denylist. This can be found in a couple of places:
https://github.com/helium/denylist#removal-from-this-list
https://docs.helium.com/mine-hnt/crowdspot/#submit-a-removal-request
See those resources for support and I'm going to close this ticket.


Add entire file to context when no text is selected in submodule

Original PR by @amovfx
Handles empty selection case
Calls addEntireFileToContext function
Improves user experience
Maintains existing functionality
*Edit by Pan:
Behaviour wanted

Clicking on a file should add the file tag to the chat. E.g., if I click on file pricing.tsx, then @pricing.tsx should appear in the chat prepended. Like below. And the context of that entire file would be prepended to the chat backend.
This, way it is non obstructive, and user also knows it is there directly.
When switching opened files, this current file tag would also change.

Description ✏
Added addEntireFileToContext to addHighlightedCodeToContext when nothing is selected.

@nang-dev - This issue can be closed as we have implemented this.

Also, I have a fix for some of the issues with ActiveFileIndicator: https://github.com/trypear/pearai-submodule/pull/159


Phone support

Hello! I just installed this game on my linux phone, its so cool! Unfortunately, I can't control it without the keyboard. It would be amazing if the menu could be interacted with through touch, and if there could be an overlay for controls. Thanks!

@Henry-Hiles considering there's an Android build, I wonder if the Linux export isn't setting touch up correctly. 🤔 Alternately, the fact that it's running under X11 (or XWayland) could affect touch controls? Not sure. I can poke at it on my touch laptop to see if I can reproduce this there compared to the Android build.

Oh! Can I get to that though?

I'll check later but I think I couldn't hit any buttons in the ui.

Yeah, but i was able to turn on touchscreen using the onscreen keyboard and that works. Maybe it can be turned on by default in certain cases or something?

i made an update that will save your last Touch Screen option between game sessions!
so if you played with touch screen ON before, the game will start with it ON

@HarmonyHoney I think the specific issue here is that @Henry-Hiles is using a device that doesn't have a physical keyboard, just a touch screen (e.g. a Linux phone). I wonder if Godot has some sort of device detection and could turn on the touch controls by default for devices that don't have a physical keyboard/mouse, or if that information is even being communicated correctly from the OS to the Godot Engine in this case. 🤔

Thats correct, I'm on a linux phone, so it was a struggle getting to settings in the first place. Either a toggle like Cassidy said, or a dialogue popup on first launch would work IMO.

Hello Henry !
I've released a new version that will bring up the touch controls after tapping the screen automatically.
let me know how this works for you.
https://github.com/HarmonyHoney/ROTA/releases/tag/something
thanks !

Great, thanks! I'll try it tonight.

Do you have a flatpak build anywhere?

Maybe a github action that provides a .flatpak file would be good.

sweet i believe cassidy wants to implement that

:+1:, i cant really test until a flatpak with the touchscreen change is available

@Henry-Hiles I went ahead and pushed the latest tag to Flathub; can you update from there and report back?

I've tested on my touchscreen Linux laptop and the controls show up as expected when I touch the screen. Smart!

Works perfectly, thank you!


Merge substituted holidays with special holidays

Proposed change

Merge substituted holidays with special holidays (into single special_holidays).
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

26 of 26 (100.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10287

Relevant Lines:
10287

💛  - Coveralls


Pass serializers to addon-storyshots

I'm not sure whether to call this a bug or feature request.
My Problem
I am snapshotting a component that includes a javascript date in its props. When a date object is serialized, it applies the timezone to the printed string, which means a serialized date will be different depending on the machines timezone.
The solution to this problem is to apply a custom serializer that strips the timezone from dates ( https://www.npmjs.com/package/jest-date-serializer ). However, my specified serializers aren't applied by addon-storyshots.
Analysis
Currently, snapshotSerializers specified in the jest configuration get ignored by addon-storyshots if the multiSnapshot option is used. This is because the subdependency (jest-specific-snapshot) uses its own serializers.
We currently already have an option to pass a single serializer, which is just a function that gets applied to the rendered tree before it is passed to jest for snapshot comparison.
Solution
it would be cool if instead of a single serializer we could pass an array of serializers that gets applied to the jest configuration, just like the default snapshotSerializers option.

The v4 change is merged.

I am going to close this since it's merged into the v4.


config.metricsAdapters should not default to empty hash

config.metricsAdapters defaults to an empty hash which causes the getWithDefault to an empty array never to be satisfied which causes filter since it's an Object and not an Array.

I'm going to resubmit with a simpler change..


parameters

I wasn't completely clear about all the parameters in the readme:
--sv-caller and --dry-run were not accepted
also, --dry-run (-n) and --name (-n) have the same input which wouldn't work?

Dear @eesiribloom,
--sv-caller is currently deactivate and unvailable for this version.  By default Decoil uses internally sniffles to call variants. The method will be fully functional after the paper is published.

Hi @eesiribloom,
I will close the issue due to inactivity. Please feel free to reopen if you have further questions.
Best,
Madalina


unique() throws depending on generator

This works as expected:
$faker->unique()->words($nb = 3, $asText = true)

This does not:
$faker->unique()->words($nb = 3, $asText = false)

Stacktrace from the latter:
  [ErrorException]
  array_key_exists(): The first argument should be either a string or an integer

Exception trace:
 () at /data/vendor/fzaninotto/faker/src/Faker/UniqueGenerator.php:44
 Illuminate\Foundation\Bootstrap\HandleExceptions->handleError() at n/a:n/a
 array_key_exists() at /data/vendor/fzaninotto/faker/src/Faker/UniqueGenerator.php:44

It may be that I just don't understand how unique works, but I was surprised that I got this error.

This was already fixed in #749, please test the master branch.

Sorry, I should've done that. Thanks.


artifact_type <-> filepath_type relationship

Modifies the DB so each artifact_type is linked with the filepath_type that can be added to the given artifact_type. Also adds a util function to retrieve such information.
This is needed by the GUI in order to reduce the options provided to the user when uploading data. By storing them in the DB we avoid the necessity to hardcode them in the GUI, as it was before.
@squirrelo @ElDeveloper @mortonjt available to review?

The code seems fine but my concern is what happens when we allow a new file type. For example, what are the steps to allow fna/qual as FASTA and tsv as mapping files in the system

Note that this is not looking at the file themselves, so the extensions do not apply.
This only affects artifacts, so adding tsv as mapping file is not affected here (i.e. it still needs to be done through the config file).
Now, the important part :smile:
There is currently no "easy" way of changing those relationships. But as an extension I would also note that there is no easy way of adding new filepath_types or artifact_types. So far we have been adding them in patches when the processing pipeline supported those new types.
Working with the target_gene_plugin was easy because the system already "depends" on it. However, this also has some drawbacks. For example, there is no way of "installing" a plugin in the system ATM. All this information (new filepath_types, artifact_types, and filepath_types <-> artifact_types relationships) should be instantiated at plugin installation time. So I would add the mechanisms to add these relationships at that point, but that is not critical right now, IMO.

Makes sense, do we have issues open for these missing functionalities?

Now we do :smile: https://github.com/biocore/qiita/issues/1625

@squirrelo could you review?

:+1:


Implement windetection in gamelib connect4 + rewrite checkers in gamelib and implement win detection.

gamelib connect4 d775d4fab13e0944bcbbca4d6f29e14b2c8c3a50

connect4 will not be available in the first ipv3 release


CORS issue

I have the following code:
    // middlewares
    if *ProductionFlag {
        api.Use(rest.DefaultProdStack...)
    } else {
        api.Use(rest.DefaultDevStack...)
    }

    // CORS
    api.Use(&rest.CorsMiddleware{
        RejectNonCorsRequests: false,
        OriginValidator: func(origin string, request *rest.Request) bool {
            // allow every origin (for now)
            return true
        },
        AllowedMethods: []string{"GET", "POST", "PUT", "DELETE", "OPTIONS"},
        AllowedHeaders: []string{
            "Accept", "Content-Type", "X-Custom-Header", "Origin"},
        AccessControlAllowCredentials: true,
        AccessControlMaxAge:           3600,
    })

However, when I make a request in browser, I get this error:
XMLHttpRequest cannot load https://view.ly/api/partner. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access. The response had HTTP status code 415.

It works fine with the following middleware:
// ServeHTTP is CORS middleware enablement.
func (_self *SocketIOCors) ServeHTTP(w http.ResponseWriter, req *http.Request) {
    if origin := req.Header.Get("Origin"); origin != "" {
        w.Header().Set("Access-Control-Allow-Origin", origin)
        w.Header().Set("Access-Control-Allow-Credentials", "true")
        w.Header().Set("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE")
        w.Header().Set("Access-Control-Allow-Headers",
            "Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization")
    }
    // Stop here if its Preflighted OPTIONS request
    if req.Method == "OPTIONS" {
        return
    }
    // Let socketio work
    _self.IO.ServeHTTP(w, req)
}

Any ideas on how to fix it?

Hi,
In my experience, the best way to debug this is to look on the wire what are the exact HTTP requests an responses (tcpdump, tcpflow, ...).
But my first suspect would be Origin 'null' in your error message, I don't think the Origin should be null.
Let me know if you find the error, especially if there is a bug in the Cors Middleware.
Antoine

Doesn't seem to be go-json-rest issue then. Sorry, my bad.

sorry, but how to apply middleware


feat:Checkbox component created

Added layout (Checkbox with content);
Added functionality:

Possibility of marking;
Disable;

Good job.


Upgrade yarn version

What will this achieve?
This will enable us to more easily upgrade @carbon/ibm-products to Carbon 11 while keeping Security and CDAI on C10.
How will success be measured?
No broken builds or scripts
Additional information

Designs
Existing code
etc

This has been complete and merged earlier today


pkg: export Makedev helpers

Move them from tarheader to device package and export go functions. This
allows the use of these functions by other packages.
Add makedev function.
This will be used by the CopyTree function I talk about in coreos/rkt#693 (comment).

If I copy my_{major,minor} functions to rkt I get a compile error because I'm redefining functions:
/var/tmp/go-link-5wNQlM/000003.o: In function `gnu_dev_minor':
/usr/include/sys/sysmacros.h:47: multiple definition of `my_minor'
/var/tmp/go-link-5wNQlM/000000.o:/usr/include/sys/sysmacros.h:47: first defined here
/var/tmp/go-link-5wNQlM/000003.o: In function `gnu_dev_major':
/usr/include/sys/sysmacros.h:41: multiple definition of `my_major'
/var/tmp/go-link-5wNQlM/000000.o:/usr/include/sys/sysmacros.h:41: first defined here
collect2: error: ld returned 1 exit status
/usr/lib/go/pkg/tool/linux_amd64/6l: running gcc failed: unsuccessful exit status 0x100

This is the only way I found so I can use them both in spec and in rkt :confused:

Silly me (thanks @alban), I didn't think about simply renaming the C functions to my_rkt_minor or something like that, that could be a solution.
Still, I'd like to share the code but I don't know if it belongs here.

I added build tags, PTAL

lgtm


Bug | Hide the scrollbar but keep the functionality

Either hide the scroll or make it looker.
Screenshot:

Hey @aadeshkulkarni, I have raised a PR for the same: https://github.com/aadeshkulkarni/first-issues/pull/17
please feel free to check this out. Thanks!


Test on more versions of Python

We should be testing against:

2.7
3.4
3.5-dev
3.6-dev
3.7-dev
master

Done, coverage is supplied in Windows only for now due to shortcomings with the macOS and Linux hosted agents in VSTS. We can test the versions given in Travis for Linux. macOS will be forthcoming with new versions of the 'Use Python' task that will support mac (no ETA).

See the VSCode-Rolling-CI build for details


No EXE file created when targeting .Net Core

When I try the steps in GetStarted, no exe file is generated if I target .Net Core 2.1 (just a dll). It works however if I target the full framework. Is it something I need to do to get that working?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0bd8cb8-7e28-8c4d-a550-3aea8f3ab4dd
Version Independent ID: 4b60d24e-ef05-15e5-10b4-483094081bf3
Content: Host ASP.NET Core in a Windows Service
Content Source: aspnetcore/host-and-deploy/windows-service.md
Product: aspnet-core
GitHub Login: @guardrex
Microsoft Alias: tdykstra

@mk0sojo ... hum 🤔 ... When we took the sample to netcoreapp2.1, I was able to run a successful test. Let me double-check and get back to you in a few minutes.

I'm getting the EXE here ... both with a build and with a publish ...

If you were converting a project, try with the sample that's associated with the topic and see if that works. I'm just building with dotnet build --configuration Debug and publishing with dotnet publish --configuration Release.

... then if you have luck with that, then SxS compare ... maybe the RID is missing from the project file.

Yes that is what it was win7-x64 was missing. Thanks. Maybe worth adding to the guide?

Absolutely yes! Thanks for the catch here. I'll take care of it.

Great. Thanks for the quick reply.

I am still only getting the dll (I also have a weird artifact of an old exe in obj/netcoreapp2.1/win-x64/host)
Tried with win7-x64, win81-x64, etc

@jeubank12 As far as we know, the guidance in the topic is correct. There are only a handful of doc authors here, and we aren't able to handle general support requests. Of course, we would like to know about gaps in coverage and inaccurate docs. Please open a new issue if the problem turns out to be something we can address in the topic.
If you can't work out the problem, you probably should post a repro of your project to GH and open an issue/question at a support forum (e.g., Stack Overflow), support chat (e.g., Gitter or Slack), or on the aspnet/Home issues.

Can you clarify if it is RuntimeIdentifier or RuntimeIdentifiers?
I made the following changes and it worked: RuntimeIdentifiers instead of RuntimeIdentifier and dotnet publish -c Release -r win-x64.  The weird part is that the produced exe has a file date of 8/13/2018 and not today's date.

RuntimeIdentifier for a single RID
RuntimeIdentifiers for a semi-colon-delimited list of multiple RIDs
https://docs.microsoft.com/dotnet/core/rid-catalog
:point_up: Now, that might be actionable for the doc. I'll take a look shortly and see if we need to address/link that.

Hi
i downloaded the SampleApp and i change the TargetFramework from 2.2 to 2.1
when i run the following no SampleApp.exe file is created
dotnet publish -c Release -r win7-x64 -o ./bin/Release/publish

Framework-dependent executable

i get the solution reading this post #9214
the solution is adding the property true for netcoreapp2.1

@DavoBR Are you referring to <UseAppHost>?


ERROR ImportDescriptors - Failed to import descriptor - new range must include current range

After completing rescanning the accounts lss failes with following error:

some lines were redacted

[2022/09/12 - 14:38:26]  INFO worker: Initial Block Download complete               blockHash=00000000000000000008120a2bb8275370b71382e202da863b649eba80aa43b3 blockHeight=753788
[2022/09/12 - 14:38:26]  INFO worker: Computing circulating supply...
[2022/09/12 - 14:42:54]  INFO worker: #RunTheNumbers successful                     actualSupply=19148473.42092331 BTC expectedSupply=19148681.25 BTC height=753789
[2022/09/12 - 14:42:58] ERROR ImportDescriptors - Failed to import descriptor || new range must include current range = [0,1002]-8: new range must include current range = [0,1002] descriptor=wpkh([7*******/84'/0'/0']xpub6**************/0/*)#asd***
[2022/09/12 - 14:42:58] ERROR worker: Failed while importing descriptors            error=ImportDescriptors - importdescriptor RPC failed
[2022/09/12 - 14:42:58]  INFO Shutdown server: in progress
[2022/09/12 - 14:42:58]  INFO Unloaded wallet successfully                  wallet=satstack
[2022/09/12 - 14:42:58]  INFO Shutdown server: done

Running latest satstack on MacOS

An hints on this issue?

no sorry, did you use a range?

Thanks for your reply.
Well, everything was kept as defaults in Ledger (10 accounts to scan). When I looked into lss.jsonthe above account in the error message is right on top

I managed to get it working. At least lss is starting properly.
Here is what I've done. Despite following the recommended installation method described here  I went with the manual approach
I noticed that Ledger Live adds way more accounts into lss.json as the manual way, hence it takes almost two days to import the descriptors.
Unfortunately, when terminating lss and re-starting it, the whole Importing descriptors process starts all over....very frustrating

yes, we definitely need to fix this, bc normally ledger knows about all the transactions/addresses after the first sync, which somehow should differentiate between an initial setup and a normal start of the bridge so that we only scan the blocks since we last left which is pretty fast also for more then >10 accounts

Is Ledger fixing this? Same issue here on Windows
[2022/12/05 - 15:00:33]  INFO worker: Computing circulating supply...
[2022/12/05 - 15:03:07]  INFO worker: #RunTheNumbers successful                     actualSupply=19224454.66594582 BTC expectedSupply=19224662.5 BTC height=765946
[2022/12/05 - 15:04:28] ERROR ImportDescriptors - Failed to import descriptor || new range must include current range = [0,1013]-8: new range must include current range = [0,1013] descriptor=wpkh([***/**'/0'/0']xpub6***/0/*)#***
[2022/12/05 - 15:04:28] ERROR worker: Failed while importing descriptors            error=ImportDescriptors - importdescriptor RPC failed
[2022/12/05 - 15:04:28] FATAL worker: Failed to send INTERRUPT signal               error=not supported by windows pid=18116
[process exited with code 1 (0x00000001)]

which version of bitcoin-core are you running ?

# bitcoind --version
Bitcoin Core version v24.0.0

ok interesting, need to check with bitcoin-core 24, seems like the rpc command changed, I will give you feedback

+1 - also having this issue. Also running current GA bitcoind (Bitcoin Core 24.0).

thank you, I haven't tried with 24.0.0 yet

Hey @adrienlacombe-ledger, any luck getting it to work with 24.0.0? Is downgrading the Core the only way to get it working again?

I forgot to mention that the issue description applies to 23.0.0
Didn't managed to try it on 24.0.0 yet

@d-rez tested it with 24.0.1 today, it works for me

So I could construct your problem, it seems to be that you customized the depth variable for the accounts, which means as the error states be >1000, or you delete the wallet from your core node and rerun lss and it sshould also be fixed

Hey @ziggie1984 thanks for your comment,
This is a brand new wallet file that was created with newest satstack release and Core v24. I deleted the old wallet file already because it didn't support descriptors so lss wasn't launching at all (as described in https://github.com/LedgerHQ/satstack/issues/87#issuecomment-1333557020)
The default value for depth variable is 1000 as per the main repo README. I'm a bit confused on what to increase it to. I haven't customized any variables tbh.

Can you check in your lss.json which depth is show there, or whether there is any depth variable ?

I had to retry the Node config and there's no depth entry / definition in the  lss.json generated by Ledger whatsoever. So it must be using whatever defaults there are.
After deleting the wallet file and going through the Node setup in Ledger, leaving values at default (10 accounts to scan), it just errors out again within a few minutes.
[2022/12/19 - 00:57:04] ERROR ImportDescriptors - Failed to import descriptor || new range must include current range = [0,1013]-8: new range must include current range = [0,1013] descriptor=<first account from lss.json>
[2022/12/19 - 00:57:04] ERROR worker: Failed while importing descriptors            error=ImportDescriptors - importdescriptor RPC failed

Ok understood, so it seems like that the previous ledger live version (not satstack) imported descriptors with a range 0..1013, and the new version does us default values.
Two countermeasure you could take to solve your problem:
1: go to your running bitcoin-core implementation and in the .bitcoin folder if you are running on linux and remove the type rm -r satstack (this delete the saved wallet of prior satstack usage. Then start lss or ledger live again and it should work

The  other solution is to go to your lss.json file and add the depth of 1013 or greater to every account. then there is no need to delete the wallet dir in bitcoin-core.

Both solutions should work, because satstack always rescans the wallet from the birthday datum so it makes no difference deleting the wallet dir either.

As mentioned, I've already removed the satstack wallet directory multiple times. I also made sure to delete it before trying this again today. Deleting the wallet directory does not solve the issue.
I'll try changing the depth in all those places tomorrow but this does not sound like a real solution either. I assume this number can change per account? Why 1013? I haven't done that many transactions for sure.
Or is that because my node is a full node and not a pruned node?

no, I don't think one can import descriptors with a pruned node, bc you cannot retrieve sufficient history. You restarted bitcoind after deleting the wallet dir ? Seems weird that the wallet still seems to be there because somehow it complains about the old range which imo means there might still be a wallet dir handing around there.
Will try with ledger live today and their created lss.json, maybe I can run into your issue

I restarted my node ~2 weeks ago last time when I commented in this repo's Issues, but not again. Just did now.
After restarting the node and going through the process again from scratch, I waited until it finished #RunTheNumbers. Then clicked Next in the dialog so that Ledger Live would try connecting to the Node/LSS, then LSS choked after a few seconds and I got an error in CLI:
[2022/12/19 - 16:11:47] ERROR Failed to query status                        err=bitcoind unreachable: status code: 503, response: "Work queue depth exceeded"

I waited patiently and eventually it resumed and is now importing descriptors again.
[2022/12/19 - 16:15:11]  INFO worker: Importing descriptors                         duration=2m22s progress=0.64%

Last time it went there it crashed with the error from this Issue's title after around 4 hours, so I guess we'll see where it gets to. I've closed Live and will let LSS do its importing again so that Live doesn't spam the node with /blockchain/v3/explorer/status pings every 1s

Haha totaly understand I am about to integrate this to the raspiblitz but need to add a few changes before I can release it. I release a patched version hopefully making the process a bit more smooth

Wouldn't  it make more sense to support Electrum/Fulcrum instead of this hacky solution?

@chuegel yes, we are exploring this option.

Ok was able to improve the loading times by 10x (when using 10 descriptors) going to release the PR today, now the amount of descriptors does not matter.

@d-rez you could try my patch it improves startup speed enormous because it only rescan the blockchain once

Other improvements will following which will fix the issue rescanning the wallet from the beginning all the time, maybe tomorrow

Wait so after I've waited almost 24h for descriptors to import (still progressing, hasn't crashed at least yet, so there's that) it will do this all over again the next time I start LSS or reboot my PC?

yess for now it will, but release the second PR today which will fix this, though you have to update so it makes no sense to sync now, but wait for the PR and then use the new version