Mapping response selection output

Hi Jason,
The response selection output gives an array of 100 elements, that I believe are ranked from top 1 to top 100 (where one of them is a true response and the other 99 are the responses in the same batch for other inputs - treated as negative samples).
I was wondering how do I map these indices to the actual responses? As in what part of the code is mapping the responses to these indices? I see there is code in the dataloader_nlg.py file, however I also noticed that the code below never gets executed as the nb_neg_sample_rs is 0. Could you please guide how do I interpret the test output?
Thanks in advance!
   if self.args["nb_neg_sample_rs"] != 0 and self.mode == "train":
        if self.args["sample_negative_by_kmeans"]:
            try:
                cur_cluster = self.others["ToD_BERT_SYS_UTTR_KMEANS"][self.data["turn_sys"][index]]
                candidates = self.others["KMEANS_to_SENTS"][cur_cluster]
                nb_selected = min(self.args["nb_neg_sample_rs"], len(candidates))
                try:
                    start_pos = random.randint(0, len(candidates)-nb_selected-1)
                except:
                    start_pos = 0
                sampled_neg_resps = candidates[start_pos:start_pos+nb_selected]

            except:
                start_pos = random.randint(0, len(self.resp_cand_trn)-self.args["nb_neg_sample_rs"]-1)
                sampled_neg_resps = self.resp_cand_trn[start_pos:start_pos+self.args["nb_neg_sample_rs"]]
        else:
            start_pos = random.randint(0, len(self.resp_cand_trn)-self.args["nb_neg_sample_rs"]-1)
            sampled_neg_resps = self.resp_cand_trn[start_pos:start_pos+self.args["nb_neg_sample_rs"]]

        neg_resp_arr, neg_resp_idx_arr = [], []
        for neg_resp in sampled_neg_resps:
            neg_resp_plain = "{} ".format(self.sys_token) + neg_resp
            neg_resp_idx = self.preprocess(neg_resp_plain)[:self.max_sys_resp_len]
            neg_resp_idx_arr.append(neg_resp_idx)
            neg_resp_arr.append(neg_resp_plain)

        item_info["neg_resp_idx_arr"] = neg_resp_idx_arr
        item_info["neg_resp_arr"] = neg_resp_arr

Hi @ItikaGupta
Negative responses are other responses in the same batch, so you can just check data["response_plain"][bsz_index] to get those plain text.
For the code you are showing, yes it is not used in the current setting. What I found in the experiments is, how to select negative responses is important, and in that part I tried to first conduct clustering before sampling. Similar observation is also found in this paper published in ACL this year. You can check their Table 4.
Let me know if you have any further questions or ideas.


Vim clone left "dirty" after make. src/po/ru.cp1251.po is modified.

Steps to reproduce
I occasionally see this, and I think I've seen mention of this on the dev list; it might always be the same file; this morning I happened to catch it just after it happened. I also built yesterday morning. It doesn't happen too often (the revert file I see is from January), I haven't looked at makefiles, I don't know what dependency is triggering.
If anyone knows something specific to check...
After pull, make reconfig, the console shows the make ending as:
...
OLD_PO_FILE_INPUT=yes msgfmt -v -o vi.mo vi.po
1410 translated messages.
OLD_PO_FILE_INPUT=yes msgfmt -v -o zh_CN.UTF-8.mo zh_CN.UTF-8.po
2800 translated messages.
OLD_PO_FILE_INPUT=yes msgfmt -v -o zh_TW.UTF-8.mo zh_TW.UTF-8.po
1410 translated messages.
make[2]: Leaving directory '/ref/vim/src/po'
make[2]: Entering directory '/ref/vim/src/po'
OLD_PO_FILE_INPUT=yes msgfmt -v -o cs.cp1250.mo cs.cp1250.po
1272 translated messages.
...
OLD_PO_FILE_INPUT=yes msgfmt -v -o pl.cp1250.mo pl.cp1250.po
1858 translated messages.
rm -f ru.cp1251.po
iconv -f UTF-8 -t CP1251 ru.po | \
	LANG=C sed -e 's/charset=[uU][tT][fF]-8/charset=CP1251/' \
		-e 's/# Original translations/# Generated from ru.po, DO NOT EDIT/' \
		> ru.cp1251.po
OLD_PO_FILE_INPUT=yes msgfmt -v -o ru.cp1251.mo ru.cp1251.po
2979 translated messages.
...
make[2]: Leaving directory '/ref/vim/src/po'
make[1]: Leaving directory '/ref/vim/src'
err@harmony:/ref/vim/src
$ hg st
M src/po/ru.cp1251.po

The diff seems to be a lot of formatting. Here's an excerpt, as seen in vim.
-"W17: Äëÿ ðàáîòû ñ àðàáñêîé ïèñüìåííîñòüþ ââåäèòå êîìàíäó `:set "
-"encoding=utf-8`"
+"W17: Äëÿ ðàáîòû ñ àðàáñêîé ïèñüìåííîñòüþ ââåäèòå êîìàíäó `:set encoding=utf-8`"

It interesting that the wrap, as shown in vim above, is happening right around column 80. With all these formatting changes it's hard to see if there are any real changes.
Using gvim -d to look at the checked in file and the it looks like the only changes are around the linebreak and that the translation itself has no changes.

Expected behaviour
No modified checked-in file.
Version of Vim
9.1.0299
Environment
ubuntu/gtk
Logs and stack traces
No response

Hmm, interesting! Do you have this happen sometimes, and always on this file?
I'm going to try building in MS Windows now - it's fine.
I'll check what's wrong with this file. If there is something wrong with it.

Hmm, interesting! Do you have this happen sometimes,

I see it every month or two

and always on this file?

Not sure, maybe.
For reference, take a look at https://groups.google.com/g/vim_dev/c/Gyqie6FQM4s/m/W2yZLzsuAwAJ from December, other people see this once and a while.

I'm going to try building in MS Windows now - it's fine. I'll check what's wrong with this file. If there is something wrong with it.
Can you please tell me what your gettext is? Version and so on...

I built with current source this morning.

Okay, thank you!
I have a rough idea of what it could be related to.
From the dates you gave, it seems to happen when translations are updated periodically.
Okay, let's try to figure it out.

Based on this line OLD_PO_FILE_INPUT=yes msgfmt -v -o vi.mo vi.po, you are using the "gettext" version before 0.22.

I have also been bothered by this and i ended up just compiling with --disable-nls.
But here is what is happening and how to trigger this bug reliably.
I will take as an example commit 8fcc12977 because it is the more recent one, but it could be any commit that updates the translation files.
To reproduce:

run this one-liner until you see that src/po/ru.po is newer than src/po/ru.cp1251.po
$ git checkout 8fcc12977~ && ls -la --time-style=full-iso src/po/ru*po && git checkout master && ls -la --time-style=full-iso src/po/ru*po
Example output on my fourth run:

HEAD is now at c9ec20d94 runtime(doc): Update documentation
-rw-r--r-- 1 ju ju 410K 2024-04-10 22:43:04.013415053 +0300 src/po/ru.cp1251.po
-rw-r--r-- 1 ju ju 539K 2024-04-10 22:43:04.016748378 +0300 src/po/ru.po
Previous HEAD position was c9ec20d94 runtime(doc): Update documentation
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
-rw-r--r-- 1 ju ju 413K 2024-04-10 22:43:04.050081632 +0300 src/po/ru.cp1251.po
-rw-r--r-- 1 ju ju 543K 2024-04-10 22:43:04.053414958 +0300 src/po/ru.po

notice how ru.po timestamp is newer by a few MS

run $ make

Explanation:

You pull a commit that updates some translation files e.g src/po/ru.po and src/po/ru.cp1251.po
when this commit is applied, the timestamp of ru.po could end up by a few milliseconds newer than ru.cp1251.po. This can happen randomly and it's unpredictable. It's more noticeable when the cpu is under heavy load.
now make detects that ru.cp1251.po file is older and triggers the iconv rule here
iconv is not really consistent between systems, so the results you get may be different. I think it's behavior depends on LC_ environmental variables  and there are different implementations for windows.

This possible for any translation file that uses iconv, listed in here.

Based on this line OLD_PO_FILE_INPUT=yes msgfmt -v -o vi.mo vi.po, you are using the "gettext" version before 0.22.

I didn't know what you meant by gettext, now I see. And you are correct; I guess a lot of people are still using that version.
$ gettext --version
gettext (GNU gettext-runtime) 0.21

BTW, I use popOS, I update regularly. So I guess their distribution hasn't incorporated the 0.22 version.

I switched to version 0.22 and use it when preparing translations. Anyway, I'll try to figure out what's going on.

run this one-liner until you see that src/po/ru.po is newer than src/po/ru.cp1251.po
$ git checkout 8fcc12977~ && ls -la --time-style=full-iso src/po/ru*po && git checkout master && ls -la --time-style=full-iso src/po/ru*po

Probably it would have been simpler to
git checkout <REF>
touch src/po/ru.po

to force the “newer” timestamp (for reproduction; your method is nice to explain how Git might leave the timestamps in an unexpected state).

Probably it would have been simpler to
git checkout <REF>
touch src/po/ru.po

to force the “newer” timestamp (for reproduction; your method is nice to explain how Git might leave the timestamps in an unexpected state).

Right, I wanted to show how this could be triggered just by using a simple git pull, without any special modification on the .po file itself. But for a fast reproduction a simple touch ru.po is all you need!
I debugged this a bit more and now i think know for sure what is happening:

At some point, one of those faulty .po files was generated with msgconv (instead of iconv)
msgconv, by default, will hard wrap lines at column 80
So now every time that the iconv rule above is triggered (because of the different timestamp that i explained) the output is not wrapped at column 80

You can verify that by using $ msgconv -t CP1251 -o /tmp/ru.c1251.po ru.po and compare it with the current version of this file $ diff /tmp/ru.c1251.po src/po/ru.c1251.po. Almost identical, minus a single line that is changed by a simple sed script.
Right now msgconv is used only on windows, eg. by src/po/Make_mvc.mak.
Thus there are three fixes required:

Make the output of iconv and msconv equal. Probably by using msgconv --no-wrap
Fix the files that were generated with msgconv
And finally find a way for make to not trigger the iconv rule randomly. For gnu version of make this is done with .LOW_RESOLUTION_TIME, but i don't know if it is portable for other versions.

(3) is technically not required if (1,2) are fixed because the output will always be the same, but still worth fixing it so we don't waste time regenerating those files.
I hope this helps!

If make ru is executed in src/po/ and cleanup.vim is applied, ru.po will be wrapped in 80 columns.
Then, make ru.cp1251.po is executed, ru.cp1251.po will be also wrapped in 80 columns.
All of (or most of) the other po files are wrapped in 80 columns. So, I think ru*.po should be also wrapped in 80 columns.

I have also been bothered by this and i ended up just compiling with --disable-nls.

By default, when Vim is built, PO files in the "src/po" directory are processed.
https://github.com/vim/vim/blob/133ed2a592e4d7998a8f6afa3de9f057feb23f0a/src/configure.ac#L4497C4-L4500C23
https://github.com/vim/vim/blob/1433ac93eb3acf28c55f0c4d775716ebee543160/src/Makefile#L2068C1-L2078C4
If you don't need this, you can use this command:
[./configure [switch] &&] make "MAKEMO="

This will cut through the PO file processing and does not require you to change
the "./configure" preset.

now make detects that ru.cp1251.po file is older and triggers the iconv rule here
So now every time that the iconv rule above is triggered (because of the different timestamp that i explained)

When checking on the host and stand systems, no big differences in time stamps
exceeding 2-second intervals were noticed. However, when the time difference was
close to 1-second in tenths of seconds, some files were converted on the stand
system. The situation was similar on the host system when the "/B" switch for
"nmake.exe" was used. Unfortunately, the exact relationship could not be
established. We can conclude that "make" uses a 1-second time interval to check
timestamps and when transferring from one system (host) to another (stand),
there is a rounding error.
To minimize these differences, the $(PS) $(PSFLAGS) Set-ItemProperty -Path '.\$@' -Name LastWriteTime -Value (Get-Date)
command was added to the "Make_mvc.mak" file, which is executed after the
PO-files conversion is completed.

If make ru is executed in src/po/ and cleanup.vim is applied, ru.po will be wrapped in 80 columns.

Unfortunately, that doesn't always happen.
The illustration below shows the file created by msgmerge --no-wrap before
cleanup.vim (bottom) and after (top).

The diff seems to be a lot of formatting.

The difference in formatting between "ru.po" and "ru.cp1251.po" is probably
because I used "Make_mvc.mak" to prepare "ru.po" and my own makefile for
"ru.cp1251.po", where "msgconv" and "msgmerge" are set to text width.

All of (or most of) the other po files are wrapped in 80 columns.

Also, the check revealed that almost all PO files have different text
formatting. This also applies to the files "ru.po" and "ru.cp1251.po".
The illustrations below show the difference in formatting between the original
file (bottom) and the file (top) produced by "msgmerge" with --width=79,
--width=80 and without text width.
msgmerge --width=79

msgmerge --witdth=80

msgmerge

The following was done to utilize uniform text formatting:

All existing PO files were reformatted to text width 79.
The modeline vim:tw=79:ts=8:ft=po: was added to the PO files
In Makefile and Make_mvc.mak, the switch --width=79 is set for "msgmerge"
and "xgettex". And the same switch is set for "msgconv" in Make_mvc.mak.

iconv is not really consistent between systems, so the results you get may be different. I think it's behavior depends on LC_ environmental variables and there are different implementations for windows.

No influence on text formatting from the "iconv" program and its analog from
"powershell" commands was detected. The output text is in the same format as the
input.
Hopefully, these steps will help eliminate unplanned processing of PO files.

Right now msgconv is used only on windows

It might be worth using the "msgconv" tool in the Makefile too.
Pros:

"Native" tool for the gettext package;
Automatic setting of the correct encoding name in the "charset" field and
avoiding additional processing with the "sed" tool;
Additional check of the correctness of the processed PO file;
Unified tool for all systems.

Cons:

Everyone is used to "iconv";
???.

What do you think about it, @k-takata , @chrisbra ?

iconv is not really consistent between systems, so the results you get may be different. I think it's behavior depends on LC_ environmental variables and there are different implementations for windows.

No influence on text formatting from the "iconv" program and its analog from "powershell" commands was detected. The output text is in the same format as the input.

Yeah sorry, i was wrong here. This was simply a wild guess I made because had no idea that windows makefiles may use msgconv.

We can conclude that "make" uses a 1-second time interval to check timestamps

This 1-second timestamp interval must specific to your system and not how make implementations work generally. Maybe either nmake.exe or windows is doing something weird? I don't know. Usually make uses high precession timestamps to determine if a target is up to date and every millisecond matters.

@julio-b

This was simply a wild guess I made because had no idea that windows makefiles may use msgconv.

It needed to be verified one way or another and it's good that you brought it to
your attention.

This excellent explanation by the maintainer of GNU make may clear up some confusion: https://lists.gnu.org/archive/html/help-make/2001-04/msg00047.html
Also this manual from autoconf might be useful: https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Timestamps-and-Make.html

Thanks for the links to useful descriptions of how the make program works.

@RestorerZ
The issue happens only in ru.cp1251.po.
Adding the --width=79 option to msgmerge only in Make_mvc.mak looks good to minimize the effect only in the ru files.
Each translation file should be maintained by each maintainer. I don't want to apply --with=79 without the agreements from the maintainers.
BTW, which version of gettext tools are you using?
I always use gettext from Cygwin or MSYS2, but they don't work with Make_mvc.mak.

Ahh, no, I misunderstood the cause of the ru.cp1251.po issue.
Makefile uses icov to convert ru.po to ru.cp1251.po. So, it will not change the width of the file.
However, Make_mvc.mak uses msgconv to convert it and msgconv changes the width. The file that was converted by msgconv is committed to the repository. So, it is different from the result of iconv.
So, the solution might be:

Don't use msgconv in Make_mvc.mak. Or,
Add --width=79 option to msgconv when converting to ru.cp1251.po.

msgconv may also remove unused messages and it causes additional differences even if --width=79 is specified.
Stop using msgconv seems the best way to solve this: #15469
BTW, I found that changing copy /a to copy /b makes Make_mvc.mak work with Cygwin/MSYS2's gettext. (copy /a appends ^Z at the end of the file and it cannot be handled by Cygwin/MSYS2's gettext.)
--- a/src/po/Make_mvc.mak
+++ b/src/po/Make_mvc.mak
@@ -500,7 +500,7 @@ files: $(PO_INPUTLIST)
 first_time: files
 	"$(VIMPROG)" -u NONE --not-a-term -S tojavascript.vim $(LANGUAGE).po \
 		$(PO_VIM_INPUTLIST)
-	@ copy /a .\files+.\vim_to_js .\allfiles
+	@ copy /b .\files+.\vim_to_js .\allfiles
 	set OLD_PO_FILE_INPUT=yes
 	set OLD_PO_FILE_OUTPUT=yes
 	$(XGETTEXT) --default-domain=$(LANGUAGE) --add-comments $(XGETTEXT_KEYWORDS) \
@@ -512,7 +512,7 @@ first_time: files
 $(PACKAGE).pot: files
 	"$(VIMPROG)" -u NONE --not-a-term -S tojavascript.vim $(PACKAGE).pot \
 		$(PO_VIM_INPUTLIST)
-	@ copy /a .\files+.\vim_to_js .\allfiles
+	@ copy /b .\files+.\vim_to_js .\allfiles
 	set OLD_PO_FILE_INPUT=yes
 	set OLD_PO_FILE_OUTPUT=yes
 	$(XGETTEXT) --default-domain=$(PACKAGE) --output=$(PACKAGE).pot \

@k-takata , the reasons for this behavior and not only for "ru-cp1251.po" but
for all other PO files were pointed out by @julio-b  in this comment.
I, for my part, can confirm this for Windows on versions 0.21 from here and
0.22.3 from here, and for Ubuntu 22 and FreeBSD 14.
Using the --width=79 switch does not solve the problem. This is evident from
this pull request.
To solve this problem, I planned the following:

Create a Vim script and implement in it the string wrapping algorithm from
this gettext function.
In make-files, when creating PO files, use the --no-wrap key and then apply
the string wrap script to the created files.
When converting PO files, avoid using "msgconv" and use "iconv" or, in
Windows, the powershell command.

Only in this case you can guarantee a uniform content of PO files, independent
of the version of "gettext" used.
Unfortunately, I don't have much free time right now to write such a Vim script.
Also, I don't know VimL well enough to do it quickly.
If you, Takata-san, or anyone else has the ability to write such a script, it
would solve our problem.

BTW, I found that changing copy /a to copy /b makes Make_mvc.mak work with Cygwin/MSYS2's gettext. (copy /a appends ^Z at the end of the file and it cannot be handled by Cygwin/MSYS2's gettext.)

Yeah, thanks! Didn't know about such a feature (bug?) Cygwin. I will fix it now.

I, for my part, can confirm this for Windows on versions 0.21 from here and
0.22.3 from here, and for Ubuntu 22 and FreeBSD 14.

Thanks. I've just confirmed #15469 with https://github.com/vslavik/gettext-tools-windows/releases .
It also works with copy /b, so I merged the above patch into #15469.
Conclusions:
ru.po is updated manually (mainly by you) and it is not so important if the width is 79 or not.
ru.cp1251.po is automatically updated within the build process on Unix-like systems by using iconv.
However, the file in the repository was converted by using msgconv. msgconv can generate the different file from iconv.
So, stop using msgconv completely solves the issue. (and #14601 is not needed anymore.)

Yes, "msgconv" contributes to string wrapping, I agree with you.
But otherwise, unfortunately, the problem remains.
If the versions of "gettext" (or rather the library) are different on different machines, the problem will persist.

How does it happen?
Original translation files (e.g. ru.po) are updated manually. So, if the maintainer updated the original file and the converted one in the same commit, the mismatch between them won't happen.
The problem is that the converted files are different depending on the environment.

Yes, Takata-san, I agree with you. I have now checked on Windows gettext versions 21 and 22, Ubuntu gettext ver. 21 and FreeBSD gettext 22. The "msgconv" formatting of the text is different from the original file generated by "xgettext". And there is a difference between the versions of "msgconv". And there are differences in formatting of "xgettext" text in version 21 and in version 22.
(By the way, file conversion does not work on FreeBSD. Need to change the $< variable to $?).


Why Only Triangles?

why not as well rectangles, or pentangles, or n-tangles?

Quadragonal is definitely a thing and you can find some examples of it being done out there. I see most quad positions can be capitalized on using a triangle approach with less fees so it wasn't worth exploring and tracking longer positions


perf(Modal): reduce unnecessary layout invalidations

Improve performance especially in IE11 when a modal is used

Codecov Report

Merging #3609 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%
==========================================
  Files         174      174
  Lines        2744     2745       +1
==========================================
+ Hits         2739     2740       +1
  Misses          5        5

Impacted Files
Coverage Δ

src/modules/Modal/Modal.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951d7ce...bd46983. Read the comment docs.


Data displaying in alternating rows

I am converting a .las file to binary. The .las file is around 9 million points. I have tried many different configurations, but every time I view the file in Potree viewer there are bands of missing points in horizontal lines.It looks like 3 or 4 rows of points are not displaying. I've tried changing various settings in the viewer, and it appears that is has something to do with the conversion. What can I try?
Thanks,
Derrick

Hello Derrick,
Can you show me a screenshot of your problem?
If you're seeing rows/lines of points with space in between, this is usually due to precision problems in the converted data. This shouldn't be happening with the newest version of the converter ( http://potree.org/downloads/PotreeConverter/PotreeConverter_2014.12.30.zip ) but who knows.
If you can, please send me a sample of your converted and original data to<EMAIL_ADDRESS>so I can take a closer look at it.
I'm traveling right now so replies may take a while.

I am using the latest version of the converter.
Here's a screen shot of what I'm seeing.

Thanks for your help!

Ah, that might be another issue. Try to set the scale parameter for conversion:
./PotreeConverter,exe data.las --scale 0.001
Default for scale is 0.01 which gives a centimeter precision, assuming the coordinates are in meters. with 0.001 you'll get milimeter precision.
I'll have to modify the PotreeConverter to take over the spacing of the las file or calculate a meaningfull spacing according to the point clouds bounding box.

You're the man!
Changing the scale worked like a charm.

Thanks!


FAT file system driver

Once CappuccinOS is installed, the goal is to move away from ISO 9660, since it's a format designed for CDs and not home computing. We will use FAT 32 as our root operating system in a non-live USB environment. This driver needs to be capable of creating FAT partitions, reading and writing files, and more in order to meet the needs of personal computing.
Examples and resources:

https://wiki.osdev.org/FAT32

A basic read-only FAT32-specific (mostly) driver was implemented in 749e9b8b1472b2eb3b2c66c08df3691e1c1c1a5c although, writes and a VFS is needed to finish this


1.42.4 fix pg vulnerability

Adding a new cartodb-psql fixing a pg vulnerability
This will be the tag 1.42.4-3

More info about pg vulnerability
https://node-postgres.com/announcements#2017-08-12-code-execution-vulnerability

🚀 :shipit:

The tag 1.42.4-3 was created


feat(batch): expression's error handling

Some users complains that they do not want some rows' expression error prevent the whole query's processing and result.
TRY() function
presto and trino do this
https://trino.io/docs/current/functions/conditional.html#try
https://prestodb.io/docs/current/functions/conditional.html#try
NOTE: after https://github.com/risingwavelabs/risingwave/pull/12461, the rw's implementation of eval_infallible is not equal to the try() function in these systems
implement your own try version of each function, such as TRY_TO_DATE(), TRY_CAST().
duckdb, snowflake and databricks do this
https://duckdb.org/docs/sql/expressions/cast.html#try_cast (though it does not have other functions)
https://docs.snowflake.com/en/sql-reference/functions/try_to_date
https://docs.databricks.com/en/sql/language-manual/functions/try_cast.html
Personally, prefer the first one.

I guess they chose the second one because their expression framework cannot be easily adapted for the first one 🤔
The first one is composable, I believe strictly better than the second one.

Previous issue: #4458

Previous issue: #4458

Thanks! I remember we did some discussion somewhere but I did not find it. So the issue is closed because we solved the streaming part but currently we can think about if we need to do something for the batch query.

Some users complains that they do not want some

...? 👀

Some users complains that they do not want some

...? 👀

added.. Sorry, I lost this part

As a streaming database, I hope to keep the SQL features consistent among streaming (i.e. create materialized view as select) and batch (i.e. select). For this case, I think you don't plan to add TRY() to streaming, right? If so, it breaks the aforementioned consistency.
Alternatively, shall we introduce a session variable to expose the expression's strict_mode to user? This was designed in https://github.com/risingwavelabs/risingwave/issues/4625 (See "Make it configurable") but not implemented yet.

Alternatively, shall we introduce a session variable to expose the expression's strict_mode to user? This was designed in https://github.com/risingwavelabs/risingwave/issues/4625 (See "Make it configurable") but not implemented yet.

IIUC, currently

batch: only strict mode
streaming: only non-strict mode

Do you mean to support non-strict mode for batch via a session var? We can't support strict mode for streaming easily. (Perhaps better to call it batch_strict_mode)

Do you mean to support non-strict mode for batch via a session var? We can't support strict mode for streaming easily.

Exactly


DBZ-2388 Expand use of Apicurio Converters in Debezium Server

https://issues.redhat.com/browse/DBZ-2388

Some testing would be nice here.

Some testing would be nice here.

Hey @ani-sha, where are we with this one?

Hey @ani-sha, where are we with this one?

Hey @gunnarmorling, I am still working on this, quite delayed on this one!
Turns out there are other blockers in this one. As you suggested on creating ApicurioTestResourceLifecycleManager and proceeding which starts apicurio well, but I figured out as debezium.format.key/value is not set anywhere in TestConfigSource ie DebeziumServer by default uses JsonConverter here.
If I specify the format as Avro in TestConfigSource and adding required props (apicurio.registry.url, apicurio.registry.global-id) in DebeziumServer it uses io.apicurio.registry.utils.converter.AvroConverter for DebeziumServerWithApicurioRegistryIT but there remains connection failure. Also this causes failure for other ITs because of the same config properties.
integrationTest.put("debezium.format.key", Avro.class.getSimpleName().toLowerCase());

If this is too complicated for you to understand I can push the changes in a test branch and reference it. If you think of any other way to approach this do let me know. Thanks.

Hey @gunnarmorling, I am still working on this, quite delayed on this one!
Turns out there are other blockers in this one. As you suggested on creating ApicurioTestResourceLifecycleManager and proceeding which starts apicurio well, but I figured out as debezium.format.key/value is not set anywhere in TestConfigSource ie DebeziumServer by default uses JsonConverter here.
If I specify the format as Avro in TestConfigSource and adding required props (apicurio.registry.url, apicurio.registry.global-id) in DebeziumServer it uses io.apicurio.registry.utils.converter.AvroConverter for DebeziumServerWithApicurioRegistryIT but there remains connection failure. Also this causes failure for other ITs because of the same config properties.
integrationTest.put("debezium.format.key", Avro.class.getSimpleName().toLowerCase());

If this is too complicated for you to understand I can push the changes in a test branch and reference it. If you think of any other way to approach this do let me know. Thanks.

@gunnarmorling as per the discussion pushed the work in progress, take a look whenever you are free, thanks.

@gunnarmorling as per the discussion pushed the work in progress, take a look whenever you are free, thanks.

@ani-sha, so where are we with this one (sorry, I forgot about the details since we last spoke about it)?

hey @gunnarmorling, as per our discussion we intented to use debezium.format.key/value as avro but we struggled to start the apicurio connection, hence you asked to push  the changes to have a look. I didn't seem to figure out the reason for failed connection even using the mapped port. also, there were concerns regarding how/where to pass the the key/value into DebeziumServer without making it apicurio dependent.

@ani-sha, so re this one, seems you'd need some help to get unstuck?

@gunnarmorling Some help would be great especially for establishing a connection to start Apicurio using the Lifecycle Manager.

@jpechane, ah yes, that's a good point. Perhaps two Maven profiles with different configurations would do the trick, and CI would run both of them, one after the other?

@gunnarmorling Good idea. Then we will even not need a separate test. The only difference would be assertion rules for the content. In this regarde we can take inspiration from openshit-tests that runs once and there is assertion strtaegy different for each converter.

Thanks for the suggestions, working on it in a new branch, closing this PR.


Encryption of configuration file or its parameters like DB user password is possible?

Is there any way to encrypt the config file, its parameters or giving the parameters as encrypted environmental variables?

Hello, @slidestar
Have you ever tried Liquid?
You don't need to write password parameters directly in a configuration file.


Error thrown when hiding Voyager-Explorer in a React component

Hello,
When using voyager-explorer inside a React component that is conditional (i.e. is added/removed from the DOM based on a flag/property) an error is thrown when the component is removed (see below). I suspect this coming from the fact that React removes elements from the DOM when not using them. So, React removes Explorer and the Voyager JS is still running responding to an update, tries to pull the element, but it's already gone.
 TypeError: Cannot read properties of null (reading 'style')
    at Mp.tick (voyager-story.min.js:32:37431)
    at Ft.tick (voyager-story.min.js:8:1747202)
    at kf.tick (voyager-story.min.js:8:1751092)
    at Ft.tick (voyager-story.min.js:8:1747202)
    at Fe.pulse (voyager-story.min.js:8:1698268)
    at Fe.onAnimationFrame (voyager-story.min.js:8:1698394)

This traces back to Voyager 'client/components/CVOrbitNavigation.ts', line 295. Above that it's grabbing an element 'prompt' from the arManager.shadowRoot DOM. Checking for if 'prompt' exists before using it (e.g. a conditional on line 277) should avoid the error.
Note: there are a few instances where getElement(Id) is used and the return is not checked for 'null' before using it so those would likely need the same treatment.

Fixed in v0.42.0


Need for further explanations

Sorry! But I don't understand how this plugin works.
Would you mind explaining how to use it in a short video?

Oh, good idea. Will do!


Establish connection with app

Create a bridge between app and the code in the backend

As a user I want the android app to actually connect to the simulated car
Acceptance Criteria:

[ ] Create broker
[ ] Connect broker to android
[ ] Connect broker to backend
[ ] Create forward button functionality to backend through broker
[ ] Create left button functionality to backend through broker
[ ] Create right button functionality to backend through broker
[ ] Create back button functionality to backend through broker
[ ] Create stop button functionality to backend through broker
[ ] Create connection to android app so indicator shows when the car is connected to the backend through the broker


Rule idea: pass regex flags by keyword

In my experiece this is a relatively common issue for re.sub / re.subn: they take both a count and a flags parameter, and count is first. So
re.sub(pattern, repl, text, re.MULTILINE)

will not apply re.MULTILINE but will limit the number of matches to 8. This typechecks because both parameters are typed as int and re.RegexFlag is an IntFlag. It can also happen with re.split (where the first parameter after the text is maxsplit) though I've less experience with that one.
Strictly speaking it's not needed for the rest (compile, search, match, iterfind, ...) as flags is their only integer parameter. I don't think it would hurt too keep things uniform but it can go either way.
Alternatively: more specifically flag passing an re flag as count or maxsplit, but I'm not sure that's possible, easier, or more useful.

Already implemented by FURB167)

Hi, thanks for the issue! Does https://docs.astral.sh/ruff/rules/re-sub-positional-args/ already catch this error?

No worries! Glad we could help :-)


Tailwind CSS → Style Dictionary → Figma Tokens

Thank you for this, @divriots. Seeing that green ✔ in the terminal feels good (as a designer) 🙇♂
Intention
So my setup was I wanted to pull tailwindcss default --full config into Design Tokens so for anything that is vanilla/default tailwind, I can apply them in my design. For example, I want to apply an equivalent of space-x-4 or gap-4 via Figma Tokens (which is 1rem) on my Figma, so it's consistent with tailwindcss when developers use that specific class.
However, after transforming from SD to JSON I noticed some tokens were not “categorized” in the format that Figma Tokens utilize. I am sure this isn‘t a bug of style-dictionary-to-figma but more a specific transformer code I need to figure out to fix this:

I would appreciate any pointers that can help me find progress in the right direction. I understand if this is out of scope, but I want to thank you again for making a designer like myself feel this is solvable. Here‘s what I got so far: https://github.com/ajmalafif/tailwind-to-style-dictionary/blob/sd-to-figma/style-dictionary.config.js

Hey! If the tokens end up uncategorized in figma tokens plugin, it means those tokens don't have a type attribute that matches any of the plugins category names. You can adjust or add the types in the tokens source of truth (I am assuming style dictionary) to match the figma plugin categories accordingly, then they'll show up correctly.

I see! thank you, @jorenbroekema, and also all the videos you made. I went over almost all your videos for Backlight!
Yes, I‘m using style dictionary. Okay, I think this definitely validates where I am going in the right path/direction, so I‘ll figure it out how do I adjust or add the types?

Glad they were helpful!
{
  "color": {
    "primary": {
      "type": "color",
      "value": "ff0000"
    }
  }
}

So either adjust the type property or add one if it's not there yet. Figma tokens plugin should have some docs on the types they use for their categories.


Run tests on correct django version

Aaaah, I didn't see #326. Ok, now it makes sense. I would simply add a trailing minor version 0. e.g. ~=3.0 -> ~=3.0.0. This will update to the proper minor version in PEP440 syntax.

/ping @Mogost

In fact, I don't agree with your suggestion. Because your version does not include alpha versions, while mine does.
i.e. the result will not be the same.

@Mogost you make a valid point. Merged 👍


Update Protobuf declarations to latest core version [ECR-4204]

This PR updates Protobuf declarations according to the changes in the core.

See: https://jira.bf.local/browse/ECR-4204

Coverage remained the same at 93.21% when pulling 515c97103406b51b2aac70a7b12c1e908140ff27 on slowli:update-protos into 572b5dfcec71c306a3a11cff9fa6cc73a51ef358 on exonum:master.

@aleksuss CI should now push the latest version of the client to the npm branch on merging PRs. Right now, you can try using
"exonum-client": "exonum/exonum-client#6d76441c",

in the package.json of the cryptocurrency-advanced tutorial (6d76441c is the latest npm commit).

I've checked it out with cryptocurrency-advanced frontend. Everything works good. 👍🏻


Representation of frames with unknown column types in DaphneIR

Currently, DaphneIR's Frame data type requires the specification of its columns' value types. This means, we cannot represent the case of a value which is known to be a frame, while we do not know the column types (yet). This can be a problem to type inference at some points.
One idea is to make the specification of the column types of a DaphneIR frame optional.
It is noteworthy that even without knowing the column types, we could already lower operations to the right frame kernels.

There are numerous places in the code where this needs to be taken into account. Search for #421 in the codebase.


NgRx on SSR throws error when strictStateSerializability is set to true

I think it's because the rehydration logic uses Set instead of plain old Array.
Error when running on SSR:

Potential source of issue:
https://github.com/trellisorg/platform/blob/b260e855ac9573fcd8de28e0ff9585065c0b9911/packages/ngrx-universal-rehydrate/src/lib/store.ts#L19
https://github.com/trellisorg/platform/blob/b260e855ac9573fcd8de28e0ff9585065c0b9911/packages/ngrx-universal-rehydrate/src/lib/store.ts#L33
The issue is gone when I set strictStateSerializability to false

Sorry I just saw this! I will fix it and release an update.

Thanks!


Amon: Change hide box size

With Texlive 2021 the size of the hide box is to big.
Change line 987 to:
field.rect = [298, 145, 596, 0];

Remove: ACTION_P_CHANGE and ACTION_P_CHANGE = 2

Done with commit: 4055912c8a988748f2eaab5fa67b94470f27e526 and aec8cd7f7276d119b59ad637933b1c3dfb3e5d50


Fix null reason phrase resulting from Response constructor

This addresses the issue noticed in the discussion around #117. This is purely to fix that one bug, I have not tested other usage of $reasonPhrase, not do I make any steps on resolving the core discussion of #117 and #118.
We may need to revise our thinking around $reasonPhrase for a 2.0 release (if we want to strictly adhere to semver).

I ran into the exception as well -- to me it's a bug in the library (bad return value), so the only 2 ways to fix it is either:

throw an exception instead of returning null
make the reason phrase empty

The second one is tricky, though, because it's not really valid response either. On the other hand, doing something like converting the response into 500 isn't optimal either, mostly because of it is not what I would expect to get.
To fix the issue and keep the compatibility, I would just throw an error until a decision can be made.

The second one is tricky, though, because it's not really valid response either.

What makes you say that? RFC 7220 specifically allows zero length reason phrases, and empty string is completely fine to have.
In addition, we replace null with the default reason phrase for the status code. It seems acceptable to me that the default reason phrase for something like error code 567 would be blank, as there is no registered default. Even if we do not want to presume that empty strings are a good default, PSR-7 defines that we “must return an empty string if [no reason phrase is] present”.

[…] I would just throw an error until a decision can be made.

Throwing exceptions from getReasonPhrase() is unacceptable. PSR-7 does not document a @throws for the method. It simply MUST return a string to be valid within the context of the interface.
This is indeed a bug in the library code. And the way to handle it is to issue a bugfix. The library should not be causing exceptions there, so this PR makes it so there are no more exceptions (at least on that one specific point). Not sure what needs to be decided on that front?

@Zegnat You are right, I somehow missed the return doc comment when reading the RFC:
@return string Reason phrase; must return an empty string if none present.

Above commit is the only valid way to fix the bug. I am sorry about causing the fix to be delayed; I mainly commented it because of I hit the same bug yesterday and it was long and busy day for me.

@mahagr no problem at all! This is still pending review anyway. And getting more eyes on a PR is just good for the overall health of the product 😄


No error on line overflow with a string literal

This doesn't produce an error even though it doesn't fit within max_width:
fn main() {
    "This is a really really really really really really really really really really really really really long message";
}

Default settings, 0.4.0-nightly (bdf56292 2018-02-17)

Isn't this an expected behavior? rustfmt should not warn on comments of string literals by default.

Closed via #2483.


remove / reduce the data/ folder while maintaining functionality of tests and example_end_to_end_run.py

Currently some of our testing env as well as the example_end_to_end_run.py relies on data within the data/ folder, which we want to eventually remove tracking.
Discuss how exactly do we thread the needle by tracking only the data we need / pull raw data with helper functions.

closing this guy because I realized it is part of #207 and this is a duplicate


In the definition mode with 4 points of XY axis, when the tilt is set to ON, the values are incorrect when X1 and Y1 are different coordinates.

Issue: Incorrect Extracted Value
Description
The extracted value in the degitizer確認２.pptx file is incorrect.
Steps to Reproduce

Check the Consider graph tilt option.
Set the x1 and y1 coordinates with different positions.

Expected Behavior
The extracted value should be accurate based on the correct calculation formula.
Actual Behavior
The value extracted is incorrect due to a typo in the code.

解消済みのためcloseします


Exception in thread "main" java.lang.NoSuchMethodError

Running a test via the sidebar icon results in the following error:
Exception in thread "main" java.lang.NoSuchMethodError: io.kotlintest.Description$Companion.spec(Lkotlin/reflect/KClass;)Lio/kotlintest/Description;
	at io.kotlintest.runner.console.SpecAwareTestFilter.<init>(SpecAwareTestFilter.kt:32)
	at io.kotlintest.runner.console.KotlinTestConsoleRunner.execute(KotlinTestConsoleRunner.kt:12)
	at io.kotlintest.runner.console.LauncherKt.main(launcher.kt:17)

KotlinTest plugin version: <IP_ADDRESS>
IntelliJ IDEA version:
IntelliJ IDEA 2019.1 EAP (Ultimate Edition)
Build #IU-191.5849.21, built on February 27, 2019
IntelliJ IDEA EAP User
Expiration date: March 29, 2019
JRE: 1.8.0_202-release-1483-b31 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-45-generic

What version of KotlinTest ?
On Thu, 28 Feb 2019 at 17:17, breandan<EMAIL_ADDRESS>wrote:

Running a test via the sidebar icon results in the following error:
Exception in thread "main" java.lang.NoSuchMethodError: io.kotlintest.Description$Companion.spec(Lkotlin/reflect/KClass;)Lio/kotlintest/Description;
at io.kotlintest.runner.console.SpecAwareTestFilter.(SpecAwareTestFilter.kt:32)
at io.kotlintest.runner.console.KotlinTestConsoleRunner.execute(KotlinTestConsoleRunner.kt:12)
at io.kotlintest.runner.console.LauncherKt.main(launcher.kt:17)
KotlinTest plugin version: <IP_ADDRESS>
IntelliJ IDEA version:
IntelliJ IDEA 2019.1 EAP (Ultimate Edition)
Build #IU-191.5849.21, built on February 27, 2019
IntelliJ IDEA EAP User
Expiration date: March 29, 2019
JRE: 1.8.0_202-release-1483-b31 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.15.0-45-generic
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest-intellij-plugin/issues/9, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAtZGrkE-syxP4jLL2c5ghjdwJNQP7fpks5vSA85gaJpZM4bXUmq
.

3.2.1

You need the latest 3.3.0 for the intellij plugin to work.
https://oss.sonatype.org/content/repositories/snapshots/io/kotlintest/kotlintest-runner-jvm/
You'll need that repo adding to your build as well.
This is just while the plugin is in beta.
On Thu, 28 Feb 2019 at 17:41, breandan<EMAIL_ADDRESS>wrote:

3.2.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kotlintest/kotlintest-intellij-plugin/issues/9#issuecomment-468366819,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtZGkxPpLm6uZn9_5ZqB2gKVzyvSRE5ks5vSBS6gaJpZM4bXUmq
.

<IP_ADDRESS> is now released compiled against KotlinTest 3.3.0
This is the first "release" version of both.
Please make sure you have upgraded both and you should be good to go!
(It might take a day before Jetbrains approve the plugin release)


Added support for uploading stemcells directly from bosh.io

My usecase is similar to https://github.com/cloudfoundry/bosh-deployment-resource/issues/62.
Wanting to upload the stemcell for kubo or cf directly from bosh.io.
I have added an bosh_io_stemcell_type param which supports light and regular.
I'm open to suggestions on better naming for the feature (maybe auto_stemcell_upload?)

Have added tests, PR is ready for review

@drich10 would you be able to review this PR?

Thanks for the PR! Yes I should be able to review this sometime in the next few days.
Would you mind explaining the value of this to you over using the concourse stemcell resource in a previous step? Just looking for some additional context 😄

Since cf-deployment uses a hard coded stemcell version there can be situations where this stemcell is not yet uploaded to the bosh director.
You could work around this by using the version_family in the bosh-io-stemcell-resource, however you would need to update your pipeline manually for that, each time a stemcell bump happens.
This is due to the limitation in concourse, a script can not ask for a specific version of a resource. You will always get the latest version. Or the last version which has passed some other task.
Also because the stemcell version could be overwritten with an opsfile ideally the logic on making sure the stemcell exists on the director should happen on the interpolated_manifest. One could theoretically implement a task which would act as a gate and only succeed if the version of the stemcell matches the stemcell specified in the manifest. But you would need to keep the lists of opsfiles in sync with the ones used by the bosh-deployment-resource.
So all the above is why I came to the conclusion that it would be best to add bosh io related logic in the bosh-deployment-resource. Since we already have the credentials for talking to bosh + the information needed to render an interpolated_manifest. To make sure this would not slow down deployments where the stemcell already exists I have used a feature of the bosh cli, which can skip upload when the stemcell already exists when the --name and --version flags are passed.

ping @drich10

Look for a new released version with this in it in the next few days!

@drich10 Thanks!


shared_activity_watchdog

Have some VVC I created in the spring that calls the variable shared_activity_watchdog from the file ti_vvc_framework_support_pkg. In the newest releases this variable is gone. What should I do to modify my old VVCs to incorporate them in the new version?

Hi,
The VVCs now calls a update_vvc_activity_register() method in the vvc_methods_pkg from its cmd_executor process:
`      -- update vvc activity
update_vvc_activity_register(global_trigger_vvc_activity_register, vvc_status, INACTIVE, entry_num_in_vvc_activity_register, last_cmd_idx_executed, command_queue.is_empty(VOID), C_SCOPE);
  -- 1. Set defaults, fetch command and log
  -------------------------------------------------------------------------
  work.td_vvc_entity_support_pkg.fetch_command_and_prepare_executor(v_cmd, command_queue, vvc_config, vvc_status, queue_is_increasing, executor_is_busy, C_VVC_LABELS);

  -- update vvc activity
  update_vvc_activity_register(global_trigger_vvc_activity_register, vvc_status, ACTIVE, entry_num_in_vvc_activity_register, last_cmd_idx_executed, command_queue.is_empty(VOID), C_SCOPE);

`


Update README.md

Add badges to readme.

@fmauch Actually, the build jobs are semi-binary and not binary if we compile the whole stack from source?


Internally upgrade Figure to address slot rendering issues + reduce complexity

Jira
N/A
Summary
Upgrades our Figure component to internally use BoltElement (LitElement) instead of SkateJS + lit-html.
Not only does this help with rendering performance and reduce the total number of lines in this component by 1/3, it also addresses the figcaption rendering issue mentioned here .
Details
Obviously these sorts of changes can potentially open a can of worms if we aren't super careful so I also added Jest snapshot, VRT, and spot check for this to A. confirm everything still renders correctly and B. make sure the rendering issue that originally popped up doesn't happen again.
How to test

Review updates
Confirm tests passing as expected

PR was released with v2.20.0


[Event Request] Table 27 Item - OnBeforeItemUnitOfMeasureInsert

Hi, would it be possible to get an event OnBeforeItemUnitOfMeasureInsert in table 27. That would be useful  in the OnValidate() trigger at "Base Unit of Measure" field.
Base Unit of Measure - OnValidate()

IF "Base Unit of Measure" <> xRec."Base Unit of Measure" THEN BEGIN
  TestNoOpenEntriesExist(FIELDCAPTION("Base Unit of Measure"));

  "Sales Unit of Measure" := "Base Unit of Measure";
  "Purch. Unit of Measure" := "Base Unit of Measure";
  IF "Base Unit of Measure" <> '' THEN BEGIN
    UnitOfMeasure.GET("Base Unit of Measure");

    IF NOT ItemUnitOfMeasure.GET("No.","Base Unit of Measure") THEN BEGIN
      ItemUnitOfMeasure.INIT;
      ItemUnitOfMeasure.VALIDATE("Item No.","No.");
      ItemUnitOfMeasure.VALIDATE(Code,"Base Unit of Measure");
      ItemUnitOfMeasure."Qty. per Unit of Measure" := 1;

      OnBeforeItemUnitOfMeasureInsert(Rec,ItemUnitOfMeasure,IsHandled);

      ItemUnitOfMeasure.INSERT;
    END ELSE BEGIN
      IF ItemUnitOfMeasure."Qty. per Unit of Measure" <> 1 THEN
        ERROR(STRSUBSTNO(BaseUnitOfMeasureQtyMustBeOneErr,"Base Unit of Measure",ItemUnitOfMeasure."Qty. per Unit of Measure"));
    END;
  END;
END;

[IntegrationEvent(false, false)]
local procedure OnBeforeItemUnitOfMeasureInsert(var Item: Record Item; var ItemUnitOfMeasure: "Record Item Unit of Measure" ; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


"Rasova", "Cochirleni" are listed in the drop-down menu

Description:
When user writes "Rasova", "Cochirleni" the location appears in the drop-down menu next to the comune and the county which is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Rasova"

Expected results
The location appears in the drop-down menu as "Sat Rasova, CONSTANȚA, (Rasova)"

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Cochirleni"

Expected results
The location appears in the drop-down menu as "Sat Cochirleni, CONSTANȚA, (Rasova)"


Fixes #23 - Transfer should not require a tag

Please PR to the dev branch.

There's no need to close the PR... I can just rebase the commit and change the PR to point to dev instead of master... Please, reopen this.

It's not possible to reopen the PR.


Assignment 2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

A2: Incomplete
Please complete the assignment that was posted in the latest update on Git. You have completed an old version


Windows Load time

When running on windows the initial load time of the app is 12 seconds. I double click the .exe and nothing happens for 12 seconds, then app loads.  On osx its instant. Any thoughts on what might be the cause?
Thanks!

It's because of zip compression in windows. The builder does not propose a non compressed version of windows builds yet

any way to solve this? users wouldnt use it if it takes that long..

Hmmm, definitely seems like an issue to me... I'm experiencing the same thing on my end. I don't even get any indication that load is happening, which causes repeated clicks of the app, and surely this will happen for end users too...

Turns out it is the size of the application and the # of files it compresses. 2 options are to use "zip: false"
or minify all js files and use npm install --production

I'm going to close this. If you're still fighting this, please see the zipOptions option which allows you to tweak the compression level, etc.


[VS Code] Starting collaboration session: Cannot start 'ShareWorkspaceAsync' while 'ShareWorkspaceAsync' is running.

<!--
For Visual Studio problems/feedback, please use the Report

Closing as a duplicate of #1601.


SPARK-LLAP-251, update compatibility notes

What changes were proposed in this pull request?
update compatibility notes

self-merging
Please still provide feedback


Fix form test

Summary
This code made it into master without causing CI to fail, however it has now been merged into the other open PRs and looks to be causing CI failures.
@cerner/terra

After this is merged into master, I plan to merge this into all the open PRs.


NotImplementedError: The list_user_policies action has not been implemented

I was trying to test iam get_all_user_policies(), but got this error.
  File "/home/z/pproj/ecs-refarch-cloudformation/services/ken/src/libs/aws.py", line 2974, in get_iam_summary
    result = conn.get_all_user_policies(user['user_name'], marker=marker)['list_user_policies_response']
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/boto/iam/connection.py", line 435, in get_all_user_policies
    list_marker='PolicyNames')
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/boto/iam/connection.py", line 85, in get_response
    response = self.make_request(action, params, path, verb)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/boto/connection.py", line 1116, in make_request
    return self._mexe(http_request)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/boto/connection.py", line 944, in _mexe
    response = connection.getresponse()
  File "/usr/lib64/python2.7/httplib.py", line 1133, in getresponse
    response = self.response_class(*args, **kwds)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/boto/connection.py", line 390, in __init__
    http_client.HTTPResponse.__init__(self, *args, **kwargs)
  File "/usr/lib64/python2.7/httplib.py", line 390, in __init__
    self.fp = sock.makefile('rb', 0)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/httpretty/core.py", line 332, in makefile
    self._entry.fill_filekind(self.fd)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/httpretty/core.py", line 591, in fill_filekind
    status, headers, self.body = self.callable_body(self.request, self.info.full_url(), headers)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/moto/core/responses.py", line 107, in dispatch
    return cls()._dispatch(*args, **kwargs)
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/moto/core/responses.py", line 167, in _dispatch
    return self.call_action()
  File "/home/u1/.virtualenvs/ken/lib/python2.7/site-packages/moto/core/responses.py", line 193, in call_action
    raise NotImplementedError("The {0} action has not been implemented".format(action))
NotImplementedError: The list_user_policies action has not been implemented

Thanks for opening. I will add it to the feature list.


feat: add native mode

This PR adds a new mode called "native". Its main responsibility is to retrieve the host and port information for a tenant from the connection string, establish a direct connection to the tenant's database, and then transfer the data without any modifications.

@josevalim, thanks! Having reviews by Dashbit significantly raises the skills :relieved:


Fix activeGate replica conversion

Description
Currently the conversion of the replicas field of the activeGate is broken -> it is always converted to 1 (default value)
How can this be tested?
Apply a Dynakube in v1beta1 and replicas of activeGate set to > 1 -> check if the replicas are kept after conversion to v1beta2 happened

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.30%. Comparing base (eb44a7b) to head (ab0650c).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3374   +/-   ##
=======================================
  Coverage   58.29%   58.30%
=======================================
  Files         334      334
  Lines       18683    18686    +3
=======================================
+ Hits        10892    10895    +3
  Misses       6567     6567
  Partials     1224     1224

Flag
Coverage Δ

unittests
58.30% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Link to Zavolaj?

Should there be a link to Zavolaj on the Compilers page, Supplementals section?

Sure!  Added!
Thanks for reporting!

Hold on, we need to discuss this a bit more, because zavolaj has been pulled into the rakudo repository itself and the zavolaj repository will not be developed further

Sure. If you need to make me any changes for this, let me know.


Getting Undefined symbol: _daemon$1050

I am getting Undefined symbol: _daemon$1050 while setup the library
has anyone has faced this issue?
pease share the solutions for this error

Thanks in advance

Hello. I am getting this error too.

Any suggestion for alternative of this library?

@mobile-simformsolutions
Steps to resolve this error:

Go to the nix repository and download the 0.9.0 source code
Remove the method daemon from nix sources.
Replace the nix dependency in cargo with your source path.

@DenisDemyanko
Where Can I get nix repo?

@DenisDemyanko
I downloaded the nix repo of 0.9.0 source code
Now, from where, I mean which files, I need to remove daemon?
can you please give more details about 3rd step?

@DenisDemyanko
I downloaded the nix repo of 0.9.0 source code
Now, from where, I mean from which files, I need to remove daemon?
can you please give more details about 3rd step?

You need remove in source files. Find this function and remove it.
3 - https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

Here is deep information of @DenisDemyanko
After cargo build command you will get the nix library in your root path. Look at the below image

you need to remove daemon method from unistd.rs file.
Copay the whole folder of nix-0.9.0
past over the turn2tor folder, open cargo.toml file, give local path for nix, you can see the below image

Now your tun2tor lib is ready to use


[Bug Report] StepAPICompatibility wrapper incompatible with Vector Environments

Describe the bug
The gymnasium.wrappers.StepAPICompatibility to convert from v26 API to v21 API is non-functional with vector environments. A quick fix is to accept is_vector_env boolean flag in the wrapper arguments or determine using isinstance and pass it to the corresponding functions in gymnasium.utils.step_api_compatibility package.
Code example
import gymnasium

vec_env = gymnasium.vector.make("CartPole-v1", num_envs=3)
vec_env_compat = gymnasium.wrappers.StepAPICompatibility(vec_env, False)
env = gymnasium.make("CartPole-v1")
env_compat = gymnasium.wrappers.StepAPICompatibility(env, False)

_ = env.reset()
step_returns = env.step(env.action_space.sample())
print("Without compatibility - Env:", len(step_returns))
# Without compatibility - Env: 5

_ = env_compat.reset()
step_returns = env_compat.step(env_compat.action_space.sample())
print("With compatibility - Env:", len(step_returns))
# With compatibility - Env: 4

_ = vec_env.reset()
step_returns = vec_env.step(vec_env.action_space.sample())
print("Without compatibility - VecEnv:", len(step_returns))
# Without compatibility - VecEnv: 5

_ = vec_env_compat.reset()
step_returns = vec_env_compat.step(vec_env_compat.action_space.sample())
print("With compatibility - VecEnv:", len(step_returns))_ = env.reset()
# Expected: Without compatibility - VecEnv: 4
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-8e284eb0ee61> in <module>
     12
     13 _ = vec_env_compat.reset()
---> 14 step_returns = vec_env_compat.step(vec_env_compat.action_space.sample())
     15 print("With compatibility - VecEnv:", len(step_returns))

/usr/local/lib/python3.8/dist-packages/gymnasium/wrappers/step_api_compatibility.py in step(self, action)
     56             return convert_to_terminated_truncated_step_api(step_returns)
     57         else:
---> 58             return convert_to_done_step_api(step_returns)

/usr/local/lib/python3.8/dist-packages/gymnasium/utils/step_api_compatibility.py in convert_to_done_step_api(step_returns, is_vector_env)
     93         # Cases to handle - info single env /  info vector env (list) / info vector env (dict)
     94         if is_vector_env is False:
---> 95             if truncated or terminated:
     96                 infos["TimeLimit.truncated"] = truncated and not terminated
     97             return (

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

System info
Tested on Google Colab:
gymnasium.__version__ = '0.27.0'
sys.version = 3.8.16
Additional context
No response
Checklist

[X] I have checked that there is no similar issue in the repo

Would be happy to open a PR with a fix.

Yes, that would be great. Looking at the utility functions, vector environments are already supported, it just looks like you forgot to implement a parameter for the wrapper.
Could you additionally, add test for check this still works

I would simply add an argument to the wrapper, this should avoid the self.is_vector_env part which confusingly can be fail in cases where users use a wrapper over a vector env then this would be false.
You could add a warning
if is_vector_env is True:
    if not isinstance(env.unwrapped, gym.vector.VectorEnv):
        warn("...")
else:
    if isinstance(env.unwrapped, gym.vector.VectorEnv):
        warn("...")

For the testing, I would just create a new test and numpy is already a dependency so I wouldn't worry about that

I might be understanding you wrong, but what would be the benefit of adding an argument to the wrapper when it can be handled internally? Wouldn't something like self.is_vector_env = isinstance(env.unwrapped, gym.Vector.VectorEnv) be sufficient? Moreover, I think only a warning would not be sufficient since passing is_vector_env = False for a vector environment will cause a runtime error in the step_api_compatibility function.

The reason will be solve in a couple of versions time but VectorEnv are subclasses of Env however all wrappers are only subclasses of Env. Therefore, currently, this is normal code in gym / gymnasium (will be changed in the next release, v0.28 as an experimental feature and roll out in v0.30)
import gymnasium as gym
from gymnasium.wrappers import RecordEpisodeStatistics, StepAPICompatibility

vector_env = gym.vector.make("CartPole-v1", num_envs=3)
wrapped_env = RecordEpisodestatistics(vector_env)

old_env = StepAPICompatibility(wrapped_env)

As wrapped_env is not an instance of VectorEnv then the check you propose will fail.
We could solve this through doing isinstance(env.unwrapped, VectorEnv) to avoid the wrapper issue.


Vagrant: Build and Tests are broken

working up a PR, but had to fix the docker install location to get docker installed, needed to add the vagrant user to the docker group
Had to add the "latest" tag to the base proxy image container for the proxy containers to build properly
Tests are currently failing on "npm install"
vagrant@nginx-jwt:/vagrant/test$ npm install
npm ERR! Linux 3.13.0-49-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! path ../supports-color/cli.js
npm ERR! code EPROTO
npm ERR! errno -71

npm ERR! EPROTO, symlink '../supports-color/cli.js'
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /vagrant/test/npm-debug.log

NPM issue seems to have been caused by: https://github.com/npm/npm/issues/7308 and http://stackoverflow.com/questions/24200333/symbolic-links-and-synced-folders-in-vagrant


Use latest byebug, bundled.

Hey @etagwerker,
This PR upgrades the version of byebug in Gemfile.lock to 9.0.3, the latest release. Using byebug 8.2.2 and Ruby 2.3.0, I'm getting a segmentation fault every time I come across an exception:
/Users/maurootonelli/.rvm/gems/ruby-2.3.0@global/gems/did_you_mean-1.0.0/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb:10: [BUG] Segmentation fault at 0x000000000000e5
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin14]```

Please check it out, thanks!

@mauro-oto Great, thanks!


Error when indexing dask array of unknown size

Hi,
I'm trying to index a dask array of unknown size, like this:
import dask.array as da
import numpy as np

arr = da.from_array(np.arange(10), chunks=[4])
valid_input_index = (arr > 5)
indices = np.array([1, 2, 3])
print(arr[valid_input_index].compute()[indices])
print(arr[valid_input_index][indices])

I get then an error as follows:
/home/a001673/usr/src/dask/dask/array/slicing.py:816: RuntimeWarning: invalid value encountered in greater_equal
  if (x >= dimension).any() or (x < -dimension).any():
/home/a001673/usr/src/dask/dask/array/slicing.py:816: RuntimeWarning: invalid value encountered in less
  if (x >= dimension).any() or (x < -dimension).any():
Traceback (most recent call last):
  File "test_dask.py", line 9, in <module>
    print(arr[valid_input_index][indices])
  File "/home/a001673/usr/src/dask/dask/array/core.py", line 1235, in __getitem__
    return Array(dsk2, out, chunks, dtype=self.dtype)
  File "/home/a001673/usr/src/dask/dask/array/core.py", line 993, in __new__
    self._chunks = normalize_chunks(chunks, shape)
  File "/home/a001673/usr/src/dask/dask/array/core.py", line 1854, in normalize_chunks
    raise ValueError("Empty tuples are not allowed in chunks. Express "
ValueError: Empty tuples are not allowed in chunks. Express zero length dimensions with 0(s) in chunks

Am I doing something wrong ? The computed version works as expected though.
Best regards,
Martin

Hi @mraspaud ,
Unfortunately this behavior isn't supported in dask.array.  In order to slice like this we need to know to which chunk every index belongs.  If you have done value-based slicing (like with arr > 5) then we can't know this without looking at all of the values.

@mrocklin thanks, good to know. I will be careful in these cases then.


Update action.yml

Hello! 👋🏻
This looks like it may have been submitted by mistake. Either way, the proposed change is invalid. 😅


Tileset new editor -> Collision polygon becomes un-editable if you edit a region that is not created with the editor.

Godot version:

Godot 3.1 apha compiled after bump
0565adb20ff01a758c5ae8e4534a2cb7f07952df
OS/device including version:

win
Issue description:

Editing single tile:
You can´t edit the collision polygon of the tile once the option was changed, editor closed, etc....
Multiples polygons are drawn instead.

I have to note that entire code of tileset take for garanted that multiple collision polygons are allowed, and specify an "shape_id"... so, probably is necessary a method to select what polygon you want to edit.

CC @MarianoGnu

I did more test. It´s seem that if you start the process of draw the collision shape after push +New Single Tile, the behavior is correct and you can edit that after draw the region in the new editor, but if the region is preexisting, every collision that you draw is locked and stay yellow and fixed.

a tile can have many collision shapes, you have to click on them to edit them

If a shape becomes yellow i cant select that by any click, nor ctrl+click alt+click RMB... i try all of them

@Ranoller @akien-mga there has been some recent changes to collision shape selections. Can you confirm if this issue is still valid?

Assuming fixed as there were no new reports about this since August. Please comment if you can still reproduce it and we'll reopen it.


Added support for stoken

This adds support for stoken as described on this page:
https://developers.google.com/recaptcha/docs/secure_token
I did not include anything in the noCaptchaProvider section for setting default options. This token includes a timestamp, so it seems more appropriate to set it when creating the recaptcha instance as opposed to in a global configuration.

Thanks @gbarrett!
Could you add documentation to readme, please?

Certainly, I've added a line in the parameters section. I think that it, combined with the link, provides enough information. Let me know if you think anything else needs to be added.


fix the encode bug

when the url contains chinese language, it shows wrong code.fix it to UTF-8,it can support chinese language;

There are test failures to take a look at, @microhuang.

Which encode bug are you talking about @microhuang? I can't see any testcase, and URLs should be urlencoded anyway (so they don't actually contain chinese characters in raw form)

Closing due to inactivity, please ping if you have news @microhuang.


Windows: Extra files left in local root directory if targetWidth or targetHeight is specified to getPicture()

Bug Report
Problem
Extra files are left in the local root directory if targetWidth or targetHeight is specified to getPicture() on the Windows platform.
What is expected to happen?
Temporary or intermediate file should be deleted when no longer required. Or at a minimum, they should be created in a temporary folder.
What does actually happen?
A file remains in the local root directory. The name of the file is not available to the application so it has no ability to delete it without inspecting the local root directory.
Information

cordova-plugin-camera v5.0.0
Call getPicture() with targetWidth and/or targetHeight set to a non-zero value.
Command or Code

navigator.camera.getPicture( successFunc, failFunc,
{
sourceType: navigator.camera.PictureSourceType.CAMERA,
destinationType: navigator.camera.DestinationType.FILE_URI,
encodingType: navigator.camera.EncodingType.JPEG,
quality: 75,
targetWidth: 2048,
targetHeight: 2048
});
The above call will leave a file named similar to CCapture.jpg in the local root directory. The application will receive a URI for a file named similar to camera_cordova_temp_return.jpg located in the local root directory.
If sourceType is set to navigator.camera.PictureSourceType.PHOTOLIBRARY, a file named to match the original source file will be left in the local root directory. The application will receive a URI for a file named similar to camera_cordova_temp_return.jpg located in the local root directory.
Environment, Platform, Device

Windows 10
Version information

"cordova-plugin-camera": "^5.0.0"
"cordova-windows": "^7.0.1"

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Cordova Windows has been deprecated and is no longer supported making this issue obsolete.


chore: handle apispec merge conflicts

This adds a test that will fail if any conflicts are found in the apispec.yaml files in the paths and schemas. The tests will fail if there is a conflict and the two conflicting schemas for example that share the same name have different definitions. If the two definitions are exactly the same then the tests will ignore this.
Also I adapted the merger used for real to use the existing values in case of conflicts rather than merge stuff in and overwrite with every new file that is merged.
But how conflicts are resolved is now not that relevant because the tests will fail if there are any. Currently the way we were merging the specs we were allowing merging conflicting paths by overwriting with whatever file comes last. This was a bit scare and we were overwriting some endpoints about users from the CRC with the /users endpoints we added later from syncing keycloak with our db.
I still want to test a few things out in a deployment to make sure everything is ok. Also I need to confirm if we are breaking the API in a meaningful way with this because I removed the leftover endpoints from the CRC with the newer ones from the keycloak sync db.
/deploy

You can access the deployment of this PR at https://renku-ci-ds-166.dev.renku.ch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

27 of 30 (90.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 88.985%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/crc/blueprints.py
1
2
50.0%

components/renku_data_services/utils/core.py
6
8
75.0%

Files with Coverage Reduction
New Missed Lines
%

components/renku_data_services/crc/models.py
1
85.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
5655

Relevant Lines:
6355

💛  - Coveralls

Tearing down the temporary RenkuLab deplyoment for this PR.


Add "using" keyword to C#

@mikesamuel, may you merge this one as well?

Please make the changes to js-modules/prettify.js instead and then run
$ npm install && npm run grunt


Gift Entry: Set Batch Defaults on BGE Form

Critical Changes
Changes

Batch Defaults are now set on the Batch Gift Entry Form taking precedence over the Template level defaults that have been set. The values set on the Batch will always override the corresponding template field default value.

Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch: attach W-038958

Tracking W-038958


Fix binding negative ints

Fixes #31.
There is also a PR #48 which narrows down the integer to 32 bits instead, which is worse IMO because it will break working with BIGINT fields.

i actually think that #48 behaviour makes sense, see the reasoning in https://github.com/andrenth/ocaml-mariadb/pull/48/commits/81e2a49121b92c1c3620627ae6817bd419d2cd5d
and bigint should be bound by the separate function (probably #43, didn't review), this PR cannot correctly handle all bigints anyway

I argue it should be long long for backwards compatibility. The change in #48 fixes negative values but breaks positive values >=2³²

My assessment is that #48 is fine, because long is the word length, and an OCaml integer is slightly narrower than the word length, so it would not overflow the long.
On the other hand we have no way to access the full range of the bigint SQL type, as far as I can tell, even on a 64 bit platform, so I think a int64 type would be a good addition.

I made the call and merged #48 instead, but thanks for the PR.

I'm re-opening this, due to #61.  The problem with #48 is that MYSQL_TYPE_LONG maps to the C int type rather than the long type which corresponds to the OCaml int type according to the documentation (and my own tests).  Since there is no MySQL type corresponding to the C long type, using MYSQL_TYPE_LONGLONG as proposed in this PR seems to be the right choice.  Sorry for missing this point earlier.
Therefore I suggest we merge this.

Thanks for considering it. Also please let me know if you need help to rebase the branch on top of maser

I have rebased this PR on top of master (+ fixed conflicts) as agreed with @cyberhuman in an offline discussion


Description text is wrong in steps

It seems that the description text for every step is shifted one step. The Mission description text is displayed in the Runtime page and the Runtime description text is displayed in the Project Info step.

off by one fixed in 2b1d53c


Migrate to MUI 5

Changelog & Migration Guide added in #575.
Dependencies

Replace @material-ui (v4) dependencies with @mui (v5)
Update dependency-versions from react and react-dom to ^17.0
Update versions of eslint and accompanying dependencies
Remove the styled-components dependency and add emotion, as this is now the default styles-engine in MUI

Theming & Styling

Replace and adapt usage of styled-components styled() with styled() from MUI
Adapt structure of component’s default-props and style-overrides in theme (https://github.com/vivid-planet/comet-admin/pull/568/commits/31dae63696450c828ff9e025b66c9c6e0386372d)
Adapt components theme-type-definition (https://github.com/vivid-planet/comet-admin/pull/568/commits/1bf2d47f51feed6915453f1eb2a319888ff3f30c)
Convert select components to function-components to allow using zIndex values from theme (https://github.com/vivid-planet/comet-admin/pull/568/commits/ff390efc25232cf95e9d5bcd8f4018d953a00446)
Style the "info" variant of Button and IconButton to replace the no longer existent "default" variant
Replace $-selectors with class-selectors, imported from each components classes-variable (https://mui.com/guides/migration-v4/#migrate-themes-styleoverrides-to-emotion)

Other Changes & Fixes

Run MUI migration code-mods to adapt imports and the usage of components and their props
Adapt some types that were now causing typescript-errors
Workaround for storybook's incompatibility with emotion >= 11 (https://github.com/vivid-planet/comet-admin/pull/568/commits/dd5a79e5cbad52a1eef42985421ac873dd3d26c2)
Fix decorator function-types and pass context into story-functions (https://github.com/vivid-planet/comet-admin/pull/568/commits/744fd320a80d9d8fe1d37001be71ee54d9f16f09)

@kaufmo @nsams please review

Changelog & Migration Guide added in https://github.com/vivid-planet/comet-admin/pull/575.
🙂


feat(runtime): add arch validator

Description

add environment.arch field in runtime.yaml
add arch validator
related: https://github.com/star-whale/starwhale/issues/749

Modules

[x] Client

Checklist

[x] run code format and lint check
[x] add unit test
[ ] add necessary doc

LGTM


Add mcrypt and bcmath

@markcial asks...

what about missing modules like bcmath? why gd is in the container but there is no mcrypt for example?

Those would be great modules to add.

Having this issue currently as well, all common libraries should be included, getting fails due to bcmath missing as well

This is stopping me from running php-amqplib in docker.

https://paragonie.com/blog/2015/05/if-you-re-typing-word-mcrypt-into-your-code-you-re-doing-it-wrong


"str object cannot be interpreted as int" in LINSPACE node

Getting this error on a fresh install from main
The @flojoy decorator really needs to typecheck params and make sure that they match what the node is expecting.

[2023-06-06 22:30:50.100-RQ-flojoy]   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/flojoy/flojoy_python.py", line 458, in wrapper
[2023-06-06 22:30:50.100-RQ-flojoy]     dt_obj = func(node_inputs, func_params)  # DataContainer object from node
[2023-06-06 22:30:50.100-RQ-flojoy]   File "/Users/jackparmer/Desktop/flojoy-screencast/studio/PYTHON/./nodes/GENERATORS/SIMULATIONS/LINSPACE/LINSPACE.py", line 10, in LINSPACE
[2023-06-06 22:30:50.100-RQ-flojoy]     y = np.linspace(params["start"], params["end"], params["step"])
[2023-06-06 22:30:50.100-RQ-flojoy]   File "<__array_function__ internals>", line 180, in linspace
[2023-06-06 22:30:50.100-RQ-flojoy]   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/numpy/core/function_base.py", line 120, in linspace
[2023-06-06 22:30:50.100-RQ-flojoy]     num = operator.index(num)
[2023-06-06 22:30:50.100-RQ-flojoy] TypeError: 'str' object cannot be interpreted as an integer

@jackparmer This happens when you have flojoy <=0.1.4. We have implemented that in latest flojoy python package. Can you confirm if you're still having this with v >= 0.1.4 ?


Docs: impossible to discover  what $factory is

I am reporting this here as the documentation repo doesn't have "Issues".
URL: http://laravel.com/docs/5.1/testing#model-factories
The documentation doesn't say anywhere what the type of the $factory object is. It is not discoverable from that place. I can learn from the docs about the additional defineAs() method, but the rest of the factory API remains a mystery and I don't know where to look.
The ModelFactory.php file in its initial form doesn't contain any hints either. There is only one direct occurence of 'ModelFactory.php' as a string in all Laravel's php files, and it is not an include statement, so I can't even examine the context here. I could set a breakpoint in the file but I really, really, really, really shouldn't have to.
Please document what things are.

If you update it should be in the latest release, I done a pull req that got merged already see #10463.


Update allow-members-to-send-as-or-send-on-behalf-of-group.md

Fixed typo as per https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/286

@MikePlumleyMSFT - can you please assist to check, approve and merge the content for this PR based on issue https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/issues/286?
Thank you.


🚩: Milestone 3: bookstore | feature/useReduxInComponents

🚩: Milestone 3: bookstore | feature/useReduxInComponents - >>branch<< -
Here is a summary of what has been done:

The  component was already wrapped with the  component from react-redux and receives as prop the Redux store.
Create a new initial state for the booksSlice.
Display the books received from the Slice.
Dispatch actions using useDispatch hook.
Add event handlers to dispatch actions.

addBook action creator (with attributes id, title and author).
removeBook action creator (with attribute id).

In this Branch, I have MODIFIED the succeeding 📂* folders and 📄** files

📂* src/components/

**📄 AddForm.js

Created the onSubmit event handler to dispatch the addBook action creator.

**📄 Item.js

Changed the onClick event handler to dispatch the removeBook action creator.
Modified the Item component to receive the id attribute.

**📄 DisplayBooks.js

Modified the map function to iterate over the books array.
Display the books received from the Slice.

📂* src/redux/

📂* books/

**📄 booksSlice.js

Created a new initial state for the booksSlice.
Updated the addBook and removeBook reducers.

Thank you for taking the time to review this PR ⭐!

Thank you very much for your review @frank1738 ! ✨✨


Exiting insert mode with ctrl-c doesn't dismiss documentation

This documentation window will go away if I exit insert mode with Esc or ctrl-[, but not if I exit with ctrl-c:

At the moment I'm using the default config suggested in the readme. I've installed this plugin from commit 73529ce61611c9ee3821e18ecc929c422416c462.

You should not use C-c to exit insert mode.
This is emergency key input to interrupt and it aborts plugins task.
So it breaks the plugin state.

I hope it should be fixed. But I has no idea for it. Sorry.


Modified cutoff for interaction analysis to 0.5 and changed the list …

…of detected residues

Mikael, please also update the figure showing the detected residues on the structures


.github/workflows: add workflow to build Docker image

This integrates a Docker image building into the GitHub actions, so the generated image can be used in our CI workflow for testing.
The workflow definition is based on:
https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-github-packages
Note that this workflow uses manual trigger (workflow_dispatch), which only works in the default branch on GitHub, so this PR is really intended for main.
Signed-off-by: Daiki Ueno<EMAIL_ADDRESS>

Hey @ueno if this workflow is intended for main I don't think we'll get much out of it. The main branch really only contains a README and license file.
Is it possible to update the workflow to specify a branch to build from?

I guess an alternative approach would be to host the workflow in a separate repository, say golang-fips/ci-images.

We usually require 2 approvals before merge but since this isn't specific to the actual code I'm going to go ahead and merge with only a single +1.

@ueno looks like it still needs some work, when trying to run the workflow on the go1.18-openssl-fips branch I get:
Workflow does not exist or does not have a workflow_dispatch trigger in this branch.

@ueno looks like it still needs some work, when trying to run the workflow on the go1.18-openssl-fips branch I get:

The idea was to use the same image for all branches. After running workflow_dispatch on main, the image will be available as ghcr.io/golang-fips/go:main. Then the actual testing workflow hosted in each branch could fetch and use it (it seems to be working though the image is currently missing :-)

@ueno looks like it still needs some work, when trying to run the workflow on the go1.18-openssl-fips branch I get:

The idea was to use the same image for all branches. After running workflow_dispatch on main, the image will be available as ghcr.io/golang-fips/go:main. Then the actual testing workflow hosted in each branch could fetch and use it (it seems to be working though the image is currently missing :-)

Ah, ok I understand now, sorry for the confusion!


Can use keyboard arrow when chat switcher is open to get to the chat composer

Posted to Upwork: https://www.upwork.com/jobs/~017933fc9690ffbd93
Title:
mWEB- Chat.Exp- 1.0.1-333 - Chat - Able to type messages in the list of contacts after hit on arrow
Action Performed

Go to URL https://chat.expensify.com
Log in with any account
On Search box Add one of your contact
Hit on arrow down
Start typing something

Expected Result:
Unable to type messages in the list of contacts
Actual Result:
Able to type messages in the list of contacts
Tester login credentials - Password	: Feya86Katya
Tester login credentials - Email/Phone<EMAIL_ADDRESS>OS and browser used: Safari
Build: 1.0.1-333
Attachment
Video

In the current codebase, I can't reproduce this issue.

In the current codebase, I can't reproduce this issue.

Hi @roryabraham, I can reproduce the issue on latest master branch and have a solution ready. Please check my proposal on upwork. Thanks!

Hi @roryabraham, I can reproduce the issue on latest master branch and have a solution ready. Please check my proposal on upwork. Thanks!

Hi @UpworkBartkoski are you still having issues reproducing?

Hi @UpworkBartkoski are you still having issues reproducing?

Hi @UpworkBartkoski are you still having issues reproducing?

I was able to reproducing the issue and fixed it

Hi @UpworkBartkoski are you still having issues reproducing?

I was able to reproducing the issue and fixed it

I am working on this.

I am working on this.

I saw there was no one hired yet the last time I opened this issue. That's why I checked on it. Sorry @UpworkBartkoski @laurenreidexpensify!
Anyway, PR #1268 depends on isSidebarShown. Whenever the condition for isSidebarShown changes, we need to test again & probably make some more changes (e.g., here). There is a better way that doesn't depend on isSidebarShown.

I saw there was no one hired yet the last time I opened this issue. That's why I checked on it. Sorry @UpworkBartkoski @laurenreidexpensify!
Anyway, PR #1268 depends on isSidebarShown. Whenever the condition for isSidebarShown changes, we need to test again & probably make some more changes (e.g., here). There is a better way that doesn't depend on isSidebarShown.

Whenever the condition for isSidebarShown changes, we need to test again & probably make some more changes (e.g., here).

I don't think this is true - check out the react-native-onyx repo. Since ReportActionCompose is wrapped in withOnyx, and the isSidebarShown prop is bound to Onyx, whenever that data changes in the underlying store, the component will be re-rendered, and the updated prop will be provided in the render function.

Whenever the condition for isSidebarShown changes, we need to test again & probably make some more changes (e.g., here).

I don't think this is true - check out the react-native-onyx repo. Since ReportActionCompose is wrapped in withOnyx, and the isSidebarShown prop is bound to Onyx, whenever that data changes in the underlying store, the component will be re-rendered, and the updated prop will be provided in the render function.

Hi @roryabraham, you may take a look at this alternative to see if it's better. If you think it's good, feel free to use it. It's not going to be of any use sitting in my local repo here anyway.
https://github.com/Expensify/Expensify.cash/compare/master...arisferyanto:1228

Hi @roryabraham, you may take a look at this alternative to see if it's better. If you think it's good, feel free to use it. It's not going to be of any use sitting in my local repo here anyway.
https://github.com/Expensify/Expensify.cash/compare/master...arisferyanto:1228

I am a but confused by the premise of this issue. What are we fixing here exactly?

I am a but confused by the premise of this issue. What are we fixing here exactly?

Able to type messages in the list of contacts

I am interpreting this as... we should be able to type the message, but the sidebar is in the way? That might be a more accessible way to handle this situation.

Able to type messages in the list of contacts

I am interpreting this as... we should be able to type the message, but the sidebar is in the way? That might be a more accessible way to handle this situation.

What happens is:

You open the chat switcher to search for chats
When the chat switcher text input is focused, you can use the down arrow on the iOS key, and it will move to the next text input in the DOM. In this case, that's the ReportActionCompose
When you switch to the ReportActionCompose, you're able to type the message, but the sidebar is in the way.

You're correct that an alternate (maybe better) solution to this would be to hide the sidebar when they hit the arrow down key. I hadn't thought of that.

What happens is:

You open the chat switcher to search for chats
When the chat switcher text input is focused, you can use the down arrow on the iOS key, and it will move to the next text input in the DOM. In this case, that's the ReportActionCompose
When you switch to the ReportActionCompose, you're able to type the message, but the sidebar is in the way.

You're correct that an alternate (maybe better) solution to this would be to hide the sidebar when they hit the arrow down key. I hadn't thought of that.

Yeah I'd think we'd just cycle back and forth. e.g. if you focus on one or the other input then the sidebar should open/close?

Yeah I'd think we'd just cycle back and forth. e.g. if you focus on one or the other input then the sidebar should open/close?

From user's perspective, I don't think pressing the arrow button when we are at the search box should close the sidebar and focus the cursor on the chat input box, especially on a tiny mobile screen. It's okay for a single page where multiple input elements are visible to the user, but not in this case. Just my 2 cents.

From user's perspective, I don't think pressing the arrow button when we are at the search box should close the sidebar and focus the cursor on the chat input box, especially on a tiny mobile screen. It's okay for a single page where multiple input elements are visible to the user, but not in this case. Just my 2 cents.

the chat input box is not visible when sidebar is open

I can see that argument and wouldn't mind that approach. Perhaps we should not render the text input at all while the sidebar is open? The user only has the option to tab over because it's rendered behind the sidebar after all.

the chat input box is not visible when sidebar is open

I can see that argument and wouldn't mind that approach. Perhaps we should not render the text input at all while the sidebar is open? The user only has the option to tab over because it's rendered behind the sidebar after all.

We can use the tabIndex prop to manage the focus while the sidebar is open thus browser will not tab away.

We can use the tabIndex prop to manage the focus while the sidebar is open thus browser will not tab away.

It doesn't look like any technical proposal was made here, but it sounds like the latest agreement is that the up/down arrows shown in the description of the issue should not be tappable when the side menu is open.
In the future, please be sure to submit a technical proposal before opening a PR to fix an issue. For the PRs currently open, please ensure they are updated to account for this.

It doesn't look like any technical proposal was made here, but it sounds like the latest agreement is that the up/down arrows shown in the description of the issue should not be tappable when the side menu is open.
In the future, please be sure to submit a technical proposal before opening a PR to fix an issue. For the PRs currently open, please ensure they are updated to account for this.

@Jag96
So should I go back to the first solution I did?
https://github.com/Expensify/Expensify.cash/pull/1268/commits/3cf5b69093a15a6f84a6f29a4328c67b33754f6a

@Jag96
So should I go back to the first solution I did?
https://github.com/Expensify/Expensify.cash/pull/1268/commits/3cf5b69093a15a6f84a6f29a4328c67b33754f6a

@UpworkBartkoski commented on the PR

@UpworkBartkoski commented on the PR


Update quality-updates.md

Updated the part about proactive quality updates on Cloud hosted environments for more clarity.

:x: Organization membership check failed
Members of the MicrosoftDocs organization should use the private repo. Please move your changes to https://github.com/MicrosoftDocs/Dynamics-365-Operations, and close this pull request.

Moved to private repo


[styletron-preact] Bump preact version.

I'll land this then also backport a special release for this prior to the breaking changes on master

Released in<EMAIL_ADDRESS>


jigglebones dissapear randomly in the middle of the game? O_o

hello! the crash have been fixed but this weird thing where jigglebones disapear during the game still happend ,i gonna share the scene with the community soon if u want to take a closer look to the problem once u got some spare time from the uni.
thanks.

@aztecsensei I also have this issue but I can't manage to consistently reproduce it. On my end they either disappear right after the scene is loaded, or never. Did you found a way to fix it?


Changed the port , added prefix and the namespace into the istio yml

Signed-off-by: Samir Parhi<EMAIL_ADDRESS>Description
Changed the port , added prefix and the namespace into the istio yml
This PR fixes #3223
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@kumarabd @leecalcote  : I have corrected according to your Comments. Kindly review it.

Codecov Report

Merging #3232 (1dea6e4) into master (5212387) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3232   +/-   ##
=======================================
  Coverage   13.22%   13.22%
=======================================
  Files          35       35
  Lines        2782     2782
=======================================
  Hits          368      368
  Misses       2322     2322
  Partials       92       92

Flag
Coverage Δ

gointegrationtests
2.87% <ø> (ø)

unittests
11.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5212387...1dea6e4. Read the comment docs.