Simpler, more consistent docstrings

I'd like to converge to simpler, more consistent docstrings, similar to the purely-markdown ones in Tensorflow.

rendering type annotations in the same way as literals in the remaining docs: https://github.com/theislab/anndata/commit/bef1c35ae4adf9e5a342cdba3ec370cd14321a9c
simplifying Union[A, B] to A, B by copying @flying-sheep's commit for resolving   https://github.com/theislab/scanpy/issues/379: https://github.com/theislab/anndata/commit/bef1c35ae4adf9e5a342cdba3ec370cd14321a9c
enclosing single backticks are interpreted as literal text as in markdown and no longer as the rarely-useful title-literal: https://github.com/theislab/anndata/commit/f2c65e0afc529bc284bff6bcc20b75bf95700898
format literals consistently across interpreted roles such as :class: and "ordinary" literals: https://github.com/theislab/anndata/commit/8f6bd391b68be264eb094ccd12a3becc221058d0
consistent font size across type annotations and other literals: https://github.com/theislab/anndata/commit/b66566aba225b10576db638916112c668a174516
do not show Mapping arguments in docstring, always hide Optional keyword, not only when preceding Union: https://github.com/theislab/anndata/commit/555cd5b2686b336ebd6df03399514e7215c177f8

This is the result for AnnData. Hope it's evident that it's much more simple and pleasing to look at...
If I did anything stupid, I'm happy to read about that: @flying-sheep @ivirshup

Some issues:

It’s impossible to see which types are links now:

here, Mapping is clickable, but the others aren’t, which leads to the next point:

555cd5b2686b336ebd6df03399514e7215c177f8 is a very misguided change, as hiding the key and value types of Mappings actively makes the docs less informative and therefore worse. I reverted it in bbe1b5739b0bbd8fc4ee34ff3ffb8284d153fdc0.

I hope you mean that Optional[T]s are replaced with T, None and not that the fact that you can specify None is hidden. However I see that in the current master there is still code to render Optional…

We also should add ndarray and DataFrame to the qualname_overrides

Quite a bit of effort is being put into making this nice and informative, which is great... but the informative descriptions are inevitably fairly technical as well. I don't want to side track this discussion, but just a quick note: it would really help if there was a beginner's guide documentation to using AnnData objects (slicing, etc.). I have found that new students often struggle learning scanpy from the documentation alone.

That’s definitely a very good idea! We should do this!
However, you seem to imply that these changes add more technical detail to the docs while in reality, the docs tried to convey the same amount of technical details in a looser language. They are supposed to be there.

@flying-sheep: I don't agree with your four arguments above. And I'd be happy if you reverted your reversion of the commit. I'm back in Germany on Thursday and at the institute on Tuesday. We can also talk this through on a video call.
The fact that we just had a very long discussion concluding (regarding the subtopic "docstrings") with @ivirshup stating that he "completely agreed on what makes a good docstring" triggered that I moved forward to make the changes I described above without getting in another long discussion. It was clear that you would want to see the arguments of Mapping in the docs and that I wouldn't want them.
I'm stressing it again: I'm OK with type annotations in the code. But I really want simple docstrings that stick to the conventions of all the major packages. In addition to these considerations, the commit you reverted reintroduces inconsistencies: the Optional keyword sometimes got hidden and sometimes didn't... also, it is incompatible with the font styling of the literals as it introduces brackets, as we discussed several weeks ago.
@LuckyMD: I completely agree! There should be a tutorial! I'm just lacking the bandwidth to go into it.

@falexwolf Haha... I believe you mentioned it before when I brought it up... I'm just going to keep bringing it up so it doesn't slip entirely off the agenda.
Also, while I understand the type annotations give more information... interactive help documentation in ipython (pressing shift + tab twice) becomes quite hard to read if you just quickly want to find the name of an argument in the function.

I'm just going to keep bringing it up so it doesn't slip entirely off the agenda.

There will be a very basic tutorial at some point, guaranteed! And one that's not as awful as this. Just right now, it's really difficult... Maybe this is something that could move up the list of priorities for @Koncopd, if he'd like to do something like this.

Also, while I understand the type annotations give more information... interactive help documentation in ipython (pressing shift + tab twice) becomes quite hard to read if you just quickly want to find the name of an argument in the function.

So, I understand that you agree that hitting shift + tab twice becomes awfully hard to read when type annotations in the function headers are used and the docstrings themselves miss types and default values? That's what I've kept arguing for since @flying-sheep brought up type annotations for the first time in Scanpy/AnnData (6 months ago?). In essence, 99% of us are hackers who just use jupyter and shift + tab and learn everything by that. And even a hacker who really knows how to code and is making a great developer, like @ivirshup, agrees on that. @flying-sheep keeps arguing from a developer perspective who has a fully configured PyCharm and aims to build complex software from simpler blocks... I get what he says, but as I'm definitely on the hacker's side of things, learning everything using shift + tab, my top priority is simple, human-readable docstrings and an API that enables writing scripts that are as simple as possible and clearly don't fall in the category "software".

Generally, it’s error prone to copy all the docs code between scanpy and anndata. we should create a little sphinx plugin that does all this for us and can be used in both projects.

Completely agree on this! :)

Please don’t hide valuable information.

Agree on this. But I'd prefer to hide information of low relevance. In the example you copied above, it's completely irrelevant as it's redundant. The docstring says:

Key-indexed one-dimensional observations annotation of length #observations.

And, hence, this bloated beast of a parameter definition

is unacceptable. I've struggled with the look of it, for months, now (leave alone that font sizes and styles were inhomogeneous and it was much worse before Saturday...).
Acknowledging that there has already been an insanely long thread on type annotations, we might consider opening up a new repository "scanpy-playground" or something, where we can have all these sandpit fights (if this is a notion) 🙂 At this stage, I personally would have stopped watching the Scanpy repo, I guess.

PS: This is the inconsistent use of the Optional keyword:

All parameters here are optional, not only uns. But, yeah, I'd like to get rid of it completely, anyways... as in the changes above, where the same thing looked this way

The only thing that misses, here, in order to hold up to the convention of the major numerical python packages, is the default value...

It was clear that you would want to see the arguments of Mapping in the docs and that I wouldn't want them.

No, it was not clear that you’d want this, and I still can’t believe you’d actually want this.
There’s easily information about how things work that get passed automatically to the reader. You added a commit that artificially withholds that information, forcing readers to look into the code if the want it? I think I must misunderstand something here, that can’t be your intention.
I’m of course OK with presenting the information in another way, and leaving it out in cases of Any (e.g. Mapping[Any, Any] → Mapping), but not to withhold it.

the Optional keyword sometimes got hidden and sometimes didn't...

As said: I also want consistency. I slightly prefer wrapping things into Optional instead of adding a , None, since None is not a type. NoneType is, but adding that to a list would be confusing.

also, it is incompatible with the font styling of the literals as it introduces brackets, as we discussed several weeks ago.

Exactly, this is why we changed the font, which you since reverted. I think having a high density of types in a line means that the boxes around them look confusing. Other docs consistently don’t put their types into boxes, which is a route that I’d prefer to having boxes everywhere.

interactive help documentation in ipython (pressing shift + tab twice) becomes quite hard to read if you just quickly want to find the name of an argument in the function.

You seem to have missed that I fixed this in ipython/ipython#11505:

One per line, and you know what you can pass in there as well! Combined with ipython/ipython#11506, autocompletion will work better since Jedi can suggest you the right objects based on their types thanks to type annotations!

So, I understand that you agree that hitting shift + tab twice becomes awfully hard to read when type annotations in the function headers are used and the docstrings themselves miss types and default values? That's what I've kept arguing for since @flying-sheep brought up type annotations for the first time in Scanpy/AnnData (6 months ago?)

…but you know that I fixed this in IPython. Instead of saying “You can’t make this better because $tool can’t handle what you do”, why don’t we improve “$tool”? If they have a release every month, there’s enough time to do that and get in the improvements that $tool couldn’t handle within 2 months.

If you display the documentation as you do above, it is displayed nicely, but if you do it with shift + tab, then it's all in one line and in your example above the default for metric would be quite far away and make it difficult to read.

You got that wrong, both work the same. But the fix is in IPython 7.3, see below:

But yes... I will update again in the new year and take a look at your pretty documentation ;).

I fixed it in IPython 7.3, not in scanpy. The problem was that IPython relied on inspect.Signature.__str__ which isn’t designed for long signatures. So it had to be fixed in IPython or Python itself (which provides the inspect module).
I generally distinguish between introducing a problem and exposing one. When using a feature exposes a problem, too many people avoid using it, optnig for a different, subpar solution. If it’s not too impractical, I instead often use the badly-supported feature and file an issue in the project that really has the problem.

I think we all have different approaches and views, and if we get together and discuss our wants and perspectives, we’ll end up with a better solution that any of us would individually.
I’m less practical than necessary, but I have the better vision of what’s feasible to implement technically. When we communicate, we can make something great, even if we don’t have all the time in the world. But we have to try. Let’s talk in person when you’re here @falexwolf :smiley:

Thanks also for your version of it in brief, which was more informative for me actually ;)

It’s all in the table here: https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes

A lot of people using scanpy are biologists who may not understand the concept of an iterator or a container. And they may move from scanpy if they feel they are required to understand the basic workings of python to use scanpy.

Good point! A balance has to be struck, and I have one requirement:
Diving into the code to find out what exactly I can pass to a function is bullshit and should never happen. The information in the official docs needs to be complete and unambiguous. The way it will look is up for debate. We can implement everything, including pop-ups and other interactive bling. But I veto that we completely get rid of information.
I went for type annotations, because they’re a standard, unambiguous, and complete way to represent everything. I’m open for suggestions.

Hey! Thank you for both your contributions @LuckyMD and @flying-sheep! @LuckyMD makes exactly the points that worry me.
Let's continue the discussion in person.
I just want to apologize that I didn't mention the IPython fix above, @flying-sheep. I myself had forgotten to update my IPython and hence was still staring at the old help outputs and arguing from the look of it...  I don't know why I didn't make the connection with our previous discussion when writing the stuff above.  🙈

No worries, you have a lot on your mind! I’m sorry if I sounded too rude in my last messages here, I wasn’t in a good place last week. All better now!

@flying-sheep Sorry... I somehow missed your last post. I actually agree with pretty much everything you wrote before. And I am in the easier position that I'm just pointing out difficulties rather than suggesting improvements. To try and contribute a bit more constructively: Maybe it's possible to separate the complete and unambiguous info from the general documentation? Like having an easy to read documentation and a detailed, technical documentation? That could be quite a bit of work though... Can you put two function headers in readthedocs?
Either way.. I'm sure you guys will come to a good solution offline tbh. The way scanpy is shaping up so far definitely warrants that trust!

Go for it! it’s a quick change now.

This is fixed! yay!


[WIP] BUFG support

Work on variant of #960
Current state of VTR hack:
hack.patch.zip

@litghost I have tried to go further from here, but I couldn't get some progress.
I have tried to analyze what is happening, and I see you have added more fixed routing lookaheads in connection_box_map.cpp in the hack.patch.
What caused issues by adding these fixed lookaheads is that the one at location (79, 133) which is the CLK_HROW_BOT tile does not have the canonical location specified.
I have been trying to understand why the canonical locations weren't added for some of the tracks and in particular, the new dump of the segment report has some unknown segments for the CLK_HROW_BOT:
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_L0|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_L1|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_L2|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_L3|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_R0|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_R1|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_R2|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_BUFRCLK_R3|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_INT_0_0|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_INT_0_1|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_INT_1_0|unknown
CLK_HROW_BOT_R|CLK_HROW_CK_INT_1_1|unknown

I am not sure whether this can be an issue while calculating the canonical locations.
Moreover, I think the issue is in the HCLK ROW.
Instead, 1478154 is the node that, in my case, did not have the canonical location set, generating the VPR error at https://github.com/SymbiFlow/vtr-verilog-to-routing/blob/bff35f4cf2a93b1cd7a3a204f7f22df1259d4ac2/vpr/src/route/connection_box_lookahead_map.cpp#L410.
segment_id 6 is relative to an OUTPINFEED segment.
I have tried to do the following:

remove the fixed routing locations: this produced the unroutability from the BUFGCTRL to the BUFHCE nodes.
increase the graph limit
adding new segment definitions without success

which is the CLK_HROW_BOT tile does not have the canonical location specified.

The reason for this is because those nodes are actually unused and/or all of the connected pips are bidirection outbound.  The canonical location logic may need to account for bidirectional pips as sources, which it currently does not.

which is the CLK_HROW_BOT tile does not have the canonical location specified.

I take it back, this is a bug we were ignoring during the initial ROI breakout work, see here: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/xc7/utils/prjxray_edge_library.py#L1450
I'm removing that wire from the check and seeing why it was failing.  In addition, there needs to be a  change in behavior on the tagging of those segments, as the HROW CLK segment should not be renamed to OUTPINFEED.

As of 064d436, the target simple_ff_x1y0_bin works when VtR is compiled with
hack.patch.zip
I've started to break out some fixes:

https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/998
https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1062

As of 4d17592556b56223f58e62a378cfc41d33abc7ed I believe that the FASM output for the clock network should match Vivado when running with VtR that is compiled with:

https://github.com/litghost/vtr-verilog-to-routing/tree/master+wip-next
The following patch:

diff --git a/vpr/src/route/connection_box_lookahead_map.cpp b/vpr/src/route/connection_box_lookahead_map.cpp
index d7cd1b02c..310c09f75 100644
--- a/vpr/src/route/connection_box_lookahead_map.cpp
+++ b/vpr/src/route/connection_box_lookahead_map.cpp
@@ -30,9 +30,6 @@
  * See e_representative_entry_method */
 #define REPRESENTATIVE_ENTRY_METHOD SMALLEST

-#define REF_X 25
-#define REF_Y 23
-
 static int signum(int x) {
     if (x > 0) return 1;
     if (x < 0)
@@ -282,11 +279,20 @@ static constexpr int kMinProfile = 1;
 static constexpr int kMaxProfile = 7;

 static int search_at(int iseg, int start_x, int start_y, t_routing_cost_map* cost_map) {
+    const auto& device_ctx = g_vpr_ctx.device();
+
     int count = 0;
     int dx = 0;
     int dy = 0;

     while ((count == 0 && dx < kMaxProfile) || dy <= kMinProfile) {
+        if(start_x + dx >= device_ctx.grid.width()) {
+            break;
+        }
+        if(start_y + dy >= device_ctx.grid.height()) {
+            break;
+        }
+
         for (e_rr_type chan_type : {CHANX, CHANY}) {
             StartNode start_node(start_x + dx, start_y + dy, chan_type, iseg);
             VTR_LOG("Searching for %d at (%d, %d)\n", iseg, start_x + dx, start_y + dy);
@@ -329,13 +335,15 @@ static void compute_connection_box_lookahead(
         t_routing_cost_map cost_map;

         int count = 0;
-        count += search_at(iseg, REF_X, REF_Y, &cost_map);
-        count += search_at(iseg, REF_Y, REF_X, &cost_map);
-        count += search_at(iseg, 1, 1, &cost_map);
-        count += search_at(iseg, 76, 1, &cost_map);
-        count += search_at(iseg, 25, 25, &cost_map);
-        count += search_at(iseg, 25, 27, &cost_map);
-        count += search_at(iseg, 75, 26, &cost_map);
+        count += search_at(iseg, 109, 125, &cost_map);
+        count += search_at(iseg, 83, 108, &cost_map);
+        count += search_at(iseg, 100, 138, &cost_map);
+        count += search_at(iseg, 61, 130, &cost_map);
+        count += search_at(iseg, 109, 133, &cost_map);
+        count += search_at(iseg, 79, 133, &cost_map);
+        count += search_at(iseg, 79, 121, &cost_map);
+        count += search_at(iseg, 77, 108, &cost_map);
+        count += search_at(iseg, 145, 133, &cost_map);

         if (count == 0) {
             VTR_LOG_WARN("Segment %s(%d) found no start_node_ind\n",

FYI @acomodi @HackerFoo https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1060#issuecomment-540258481
@HackerFoo Once I've confirmed that this works in diff with Vivado and in hardware, the last bit is the generalized sampling.  In theory Symbiflow @ https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1060/commits/4d17592556b56223f58e62a378cfc41d33abc7ed + VtR @ https://github.com/litghost/vtr-verilog-to-routing/tree/master+wip-next + generalized sampling should work with ROI and ROI-less

I've confirmed that this works in diff with Vivado and in hardware

I've confirmed that https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1060/commits/4d17592556b56223f58e62a378cfc41d33abc7ed has no diffs against Vivado for clock network stuff.

\o/

@litghost Great! One thing, what do you mean with generalized sampling?

@litghost Great! One thing, what do you mean with generalized sampling? Moreover, what is now the right way to avoid using the patch in #1060 (comment)?

Same thing.  @HackerFoo is working on a different sampling algorithm (rather than a fix set of coordinates) in https://github.com/SymbiFlow/vtr-verilog-to-routing/pull/289

Merge in #1075


Release Download is not complete.

According to the documentation, I should be able to the release version, without composer, however this does NOT appear to be the case.
"Download the Release
If you abhor using composer, you can download the package in its entirety. The Releases page lists all stable versions. Download any file with the name google-api-php-client-[RELEASE_NAME].zip for a package including this library and its dependencies.
Uncompress the zip file you download, and include the autoloader in your project:
require_once '/path/to/google-api-php-client/vendor/autoload.php';"
However this download, google-api-php-client-2.2.2.zip, does NOT contain a vendor directory.
I have read another ticket, where v1-master was recommended ...
Does this mean v2 is not supported without composer?
Are you recommending to simply use the v1-master, or use v1-master, and than overwrite with version 2.2?

I noticed that there was only a "source code" option. My mistake.
Downloaded 2.2.1 for now.

@michaeldprice Thanks for the heads up. I just added those assets to v2.2.2.


Style the extension popup interface

The design of the extension interface including the table can be styled. If you can, go ahead and do this!

Hi, I am looking to contribute to my first open source project and wanted to know if I could please work on this issue?

@TumiMoshou Go Ahead! All contributions are welcome

Hi @imkrishnasarathi, I am trying to push my changes but I get the following message: 'Permission to imkrishnasarathi/PleasantWeb.git denied to TumiMoshou.'

Hey there. I am sorry for the issue. Can you please inform if it is okay now?

Hey, yes it is fine now and seems to be working. Thank you


config: prefix generic objects (validatingwebhook and issuer)

Changes proposed by this PR

config: prefix issuer w/ cartographer-
despite the object being namespace-scoped, it's such a generic name that
it makes sense to have it prefixed with cartographer- so that we're
able to carry the component nomenclature.

config: prefix cluster-scoped validatingwhook
given that the ValidatingWebhookConfiguration we have (previously named
validating-webhook-configuration) has a high risk of colliding with
another package, prefix it with cartographer- to lower those chances.

closes #992
Release Note

prefix cluster-scoped validatingwebhook with cartographer to avoid conflicts with other validating webhook configurations
prefix issues with cartographer- to avoid potential collisions in the cartographer-system namespace

PR Checklist
Note: Please do not remove items. Mark items as done [x] or use ~strikethrough~ if you believe they are not relevant

[ ] Linked to a relevant issue. Eg: Fixes #123 or Updates #123
[ ] Removed non-atomic or wip commits
[ ] Filled in the Release Note section above
[ ] Modified the docs to match changes

a-ha, it's generated (makes sense) - will patch


Trigger onRoundEnd when startNewRound is called in the middle of a round

In https://github.com/HarvardEconCS/turkserver-meteor/blob/master/lib/timers_server.jsx the code to update a round end time is in two places (startNewRound and endCurrentRound) but onRoundEnd is only called in one of them.
This should be fixed after @ldworkin's current project reaches a good break point.

@ldworkin: the onRoundEnd handler is now called with a constant indicating why a round ended, so you can use it like the following:
TurkServer.onRoundEnd( function (reason) {
  if (reason === TurkServer.Timers.ROUND_END_TIMEOUT) {
    // ...
  }
});

See also

https://github.com/HarvardEconCS/turkserver-meteor/blob/master/lib/timers_server.jsx#L7


Reenable most tests

Changes:

Reenabled all permissions-related tests that aren't still broken
Rewrote a number of tests to fix problems with their semantics
Removed RLMSyncPermissionSortPropertyUserID, since all permissions reported to a user have the same user ID
Upgraded to ROS alpha-44
Pulled in object store changes
Tests should fail in a slightly more graceful manner now

Note that a handful of tests (prefixed with disabled_) are still disabled. All disabled tests have a FIXME comment explaining what's wrong.

Most of the CI failures we're seeing are due to https://github.com/realm/ci/issues/211. The object server tests appears to be passing though, which is the main thing.

Yeah, I'm going to remove that code (which doesn't seem like it works at all, upon further investigation).

All failures are CI related.


upgrade prettier

:clipboard: Description

review open PRs: anything big we want to try and get over the line first? (also a good time to do a  bit of a clean out)
can we adopt some settings that mean we don't have to change every single file in the codebase to upgrade it?

Posting past discussion on the prettier upgrade here for reference
https://github.com/badges/shields/pull/4836#issuecomment-605339072


Sort list of devices

Sort by most recently connected, lowest battery, lowest time remaining, etc.

This may not be that useful. Closing for now.


Add package for sh installer

Add package for sh installer

thanks @scopatz for the feedback. I will work on that.


Calorie tracking resets after using barcode  scanner

Pretty much the title, after using the barcode scanner my calorie count reset and only subtracted the amounts added by the scan.
As a note my calorie goal is set to 1950, as you can see the numbers on screen don't add up.
Other than that really loving the app!

Huh, weird!

So let me get this straight - you add like 500 calories worth of food or something and then use the barcode scanner and then it kinda resets everything else?

Ok, fixed it - that was a easy bug to squash. Let me know if that works for you. And thanks for reporting it!

Thanks! I'll check it out again and see if it acts up again!
Cheers,
Simon McGraw
On Thu, Mar 16, 2023, 6:12 PM Paul Zakin @.***> wrote:

Ok, fixed it - that was an easy bug to squash. Let me know if that works
for you. And thanks for reporting it!
—
Reply to this email directly, view it on GitHub
https://github.com/successible/cleanslate/issues/62#issuecomment-1472966197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJLNS7H6HLTDQNAOX5U5XZTW4O3BPANCNFSM6AAAAAAV4N4IOM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Register official port

within the Prometheus Wiki article.

Fixed in https://github.com/mweinelt/sml-exporter/commit/855c4c48457facab1d93f73dae4d4515c5ed1248


Links to society

Spread the word and build communities!
The svelte society site should list links to societies wordwide so we can encourage community building. Adding new entries should be easy, so perhaps it can be build from a json file ?
[{
  "name": "Svelte Society Antartica",
  "twitter": "@pngwn",
  "url": "svelte-society.ant"
}]

Questions:
Where to feature ?
Can we make this prominent on the frontpage ? "Looking for a Svelte Community near you ?"
Add some text on how to get your community listed.
Required:
some copy (I am horrible at writing short stuff)
links/handles

I will try to find a solution for it 😃

I will try to find a solution for it 😃

Here you get a preview of my solution. What dow you think about it?
The data Model for the societys actual looks like:
[{
    "name": "London Svelte Meetup",
    "country": "🇬🇧 Great Britain",
    "url": "https://www.meetup.com/svelte/"
  },
  {
    "name": "Svelte Dublin",
    "country": "🇮🇪 Ireland",
    "url": "https://www.downtomeet.com/Svelte-Dublin"
  },
  {
    "name": "Svelte Society Stockholm",
    "country": "🇸🇪 Sweden",
    "url": "https://www.downtomeet.com/Svelte-Society-Stockholm"
  }
]

but i think its expandable with thinks like organisators of the communities f.e.

Here you get a preview of my solution. What dow you think about it?
The data Model for the societys actual looks like:
[{
    "name": "London Svelte Meetup",
    "country": "🇬🇧 Great Britain",
    "url": "https://www.meetup.com/svelte/"
  },
  {
    "name": "Svelte Dublin",
    "country": "🇮🇪 Ireland",
    "url": "https://www.downtomeet.com/Svelte-Dublin"
  },
  {
    "name": "Svelte Society Stockholm",
    "country": "🇸🇪 Sweden",
    "url": "https://www.downtomeet.com/Svelte-Society-Stockholm"
  }
]

but i think its expandable with thinks like organisators of the communities f.e.

this looks really good!

this looks really good!

yes this could be a nice feture @sw-yx

yes this could be a nice feture @sw-yx

I'll close this, thanks for the PR!

I'll close this, thanks for the PR!


fix obkv document

When serializing a document, the serializer resolved the field_id of the current field and immediately added it to the obkv document under construction. The issue with that is that obkv expects the fields to be inserted in order, and when a document with out of order fields was added, obkv failed to insert the field.
The current fix first resolves each field_id, and adds all the fields to a temporary BTreeMap, until end is called on the map serializer, where all the fields are added to the obkv at once, and in order.

bors merge


Proposed issue template forms for bugs and feature requests

New GitHub template forms for bug reports and new feature requests.
For live example, check out: https://github.com/nasa/opera-sds-sys/issues/new/choose.
Both templates automatically tag issue with a new label "needs triage". This label needs to be manually created once for the repository for this automatic tagging to work".

Suggested label name: "needs triage"
Suggested description: "Issue requires triage to proceed"
Suggested color: "#C24247"

@yunjunz @hfattahi FYI one more step may be needed:

Both templates automatically tag issue with a new label "needs triage". This label needs to be manually created once for the repository for this automatic tagging to work".

Suggested label name: "needs triage"
Suggested description: "Issue requires triage to proceed"
Suggested color: "#C24247"


fix: pod restart on config change

Pods are now properly restarted when there are changes on the configuration. The configuration changes now also include environment variables, secrets and alerting configuration.
fixes #347

Codecov Report

Merging #358 (43f39a2) into develop (165f518) will increase coverage by 3.50%.
The diff coverage is 97.38%.

@@             Coverage Diff             @@
##           develop     #358      +/-   ##
===========================================
+ Coverage    93.52%   97.02%   +3.50%
===========================================
  Files           15       21       +6
  Lines          633     1042     +409
===========================================
+ Hits           592     1011     +419
+ Misses          41       31      -10

Impacted Files
Coverage Δ

connaisseur/__main__.py
0.00% <ø> (ø)

connaisseur/kube_api.py
87.50% <66.66%> (ø)

...naisseur/validators/notaryv2/notaryv2_validator.py
80.00% <80.00%> (ø)

connaisseur/flask_server.py
93.15% <91.07%> (+21.72%)
:arrow_up:

connaisseur/validators/static/static_validator.py
93.75% <93.75%> (ø)

connaisseur/util.py
95.34% <95.34%> (-4.66%)
:arrow_down:

...naisseur/validators/notaryv1/notaryv1_validator.py
95.83% <95.83%> (ø)

connaisseur/config.py
97.29% <97.29%> (ø)

connaisseur/alert.py
97.80% <97.80%> (ø)

connaisseur/validators/notaryv1/notary.py
98.30% <98.30%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76eb202...43f39a2. Read the comment docs.


Some presets are understood by users incorrectly

It is not clear for editors to what kind of object some presets must be applied.
For example:
amenity=school
amenity=kindergarten
‐ people keep applying these presets on buildings instead of, for example, school grounds like the wiki says.
Please fix your UI to make it clear that these presets are not meant to be applied on buildings.

It could be a rule for the validator, that the user has to decide between one of the two.

We've been through this many times
https://github.com/openstreetmap/iD/issues/5883#issuecomment-462830659
Please stop trolling our project.


Startup "pop"

Today I tried to understand the startup pop. For this I added delays in the initialization of the synth and you can see, that is pops at the moment, the ALSA driver is started. One solution could be (maybe) to use pulseaudio with the option module-suspend-on-idle so that the ALSA driver is always active. But I would expect at least one pop during booting.
So an other idea was to enable the headphone amplifier after haxo has started. The amplifier has a non-pop feature.
I've disconnected the SD_MODE Pin (4) of the amp from +5V and connected it to GPIO4. An additional 3k3 resistor as pulldown to GND. I wanted to modify the software so that GPIO4 goes HIGH after the haxo startet. But before I could made any modifications I saw ... that it worked as it should.
I don't no why. But there are no pops anymore.
:thinking:

Here is how I disconnected the SD pin (pin 4 of U4). My PCB: v1.0.1

First I measured if there is connection between U4 pin 4 and + of capacitor C2 using a thin needle to contact pin 4.
Then I used a sharp knife and cut the copper of the PCB at the marked position.
I checked if the the connection between pin4 and + is lost as it should. Then I removed ab bit of the solder mask by scratching it with the knife and soldered a thin wire.
On the other side of the PCB a soldered a 3k3 resistor between pin 7 and 9 of the rpi connector ( GPIO 4 and GND) and the wire to pin 4.

Hi @gerdb,
I checked the Linux driver for the MAX98357A:  apparently they do eliminate the pop by delaying the assertion of SD_MODE until after the I2C clock is started.
https://github.com/torvalds/linux/commit/cec5b01f8f1c6064037f3181e7690e3765ed995b
I think I will make the change to the schematic to connect that pin to an unused GPIO.
Cheers,

"delaying the assertion of SD_MODE until after the I2C clock is started."
I can confirm this.
I've connected it to GPIO4 and do not set it. But I can see that some other service sets it to HIGH, about 5sec before haxo is started. The GPIO is configured as input during startup. I have an 3k3 pulldown and can see a voltage of some 100mV. This means that there is also some kind of pullup. So I would recommend to also use a pulldown.
so ... it's now more a hardware than a software issue ...

Tested it without pulldown resistor:
There is no audible pop. The resistor is therefore not necessary.
For the first 15sec of boot the voltage at GPIO4 is 2.2V, then for 10s 0V and then for 5s 3.3V until haxo started. (RPI 3B+)

Thanks for testing this @gerdb!
Apparently changing /boot/config.txt as below should configure the max98357a driver to use GPIO4 to control SD_MODE
 - dtoverlay=max98357a
 + dtoverlay=max98357a,sdmode-pin=4

I've made the change to the schematic to connect SD_MODE to GPIO4, no pull-ups.  I'm very reassured by reviewing the documentation and your testing that it will work.  Thanks!
Links:
https://github.com/raspberrypi/linux/blob/rpi-6.1.y/arch/arm/boot/dts/overlays/max98357a-overlay.dts
https://forums.raspberrypi.com/viewtopic.php?t=340771

BTW @gerdb, your contributions have been mentioned in the last crowdfunding project update post: https://www.crowdsupply.com/cardona-bits/haxophone/updates/last-days-of-the-campaign
Thanks for the good work!

I've manufactured a board that includes this change: https://github.com/cardonabits/haxo-hw/commit/a28321d64bd03642627a374bd779182410e1912a and have confirm that indeed it solves the startup pop.
Thanks for your help in this, @gerdb!


Improve DOM compatibility for Cordova plugins

We should support document.addEventListener for cordova plugins that use that mechanism to attach custom events. The ``èvent.target```should be available when the event is fired.
Plugin that needs the above mentioned API:
https://github.com/fastrde/phonegap-downloader/

Maybe it would also be usefull to add the following as well:
window.postMessage()
document.createEvent()

A few Cordova plugins use these in the Javscript part.

Good proposal. Thanks.

Just an example plugin for document.createEvent():
https://github.com/blocshop/sockets-for-cordova/blob/master/socket.js
"This Cordova plugin provides JavaScript API, that allows you to communicate with server through TCP protocol. Currently we support these platforms: iOS, Android, WP8."
It also requires document.removeEventListener().

In general it seems that Cordova plugins that try to implement a new feature (Web-API) which is not yet supported on all platforms, seem to do some checks to get the version information on the underlying platform:
Examples:
 ver = /Chrome\/(\d+)/.exec(navigator.userAgent);

or
function hasWebSocket() {
  var m = /Android ([0-9]+)\.([0-9]+)/i.exec(navigator.userAgent);
  var hasConstructor = typeof WebSocket === "function";

  if (!m) { return hasConstructor; }

  var x = parseInt(m[1], 10);
  var y = parseInt(m[2], 10);

  return hasConstructor && (x > 4 || (x === 4 && y >= 4));
}

Maybe it would be a good idea to be able to specify what fake-responses should be sent to such plugins.

document.createEvent is already implemented. Is there any indication that it does not work already?

Concerning window.postMessage:
https://github.com/knowledgecode/WebSocket-for-Android/blob/master/www/websocket.js#L37
I have tried this Cordova plugin to get websocket support on Android.
I do not know other plugins so far.
Concerning the userAgent string:
At least the above plugin seems to use this information to switch between built-in functionality of the webview or the external version provided by the Cordova plugin. This depends on the userAgent string for example for the javascript part of the plugin.
Ok, maybe it is not the best way to derive details about the underlying platform.
Maybe this would be the better appoach: https://cordova.apache.org/docs/en/3.0.0/cordova_device_device.md.html
So it would be the plugin's authors responsibility to change that.
But let us keep in mind that Cordova plugins were developed for a webview based approach.
So it might be a natural assumption that at least the javascript part of a plugin might depend on a userAgent string to find out on what platform it is running to change behaviour accordingly.

Today I tested the cordova-plugin-fastrde-downloader plugin. It uses document.addEventListener for different events. Didn't check all events, but those I tested are working without problem.


Fix typos

Please check if the PR fulfills these requirements

[x] Followed the Contributing guidelines.
[ ] Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
[x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Found few misspellings.
https://github.com/crate-ci/typos

@szepeviktor - thanks for all the typo fixes. We should have this deployed in the next 2-3 weeks. 🎉

I have an insane amount of those in my bag.
.. including Integrity which prevents earthquakes.
https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows


Fix for build and run executable for Etlas >= <IP_ADDRESS>

It is the same pull request as #19 There was something wrong and I have closed the previous one.

This looks good - anymore changes you want to include or should I merge?

Yes. I have one more change. This one about external dependencies resolving.
I've tried to run project eta-servant-example and got an error:

Exception in thread "main" java.lang.ClassNotFoundException: org.eclipse.jetty.server.Connector

It happened because sbt plugin process as external dependencies only libs which are in section maven-depends of .cabal file. There is no maven-depends section in this project. But some eta libs has such dependencies, for example:

dependency,wai-servlet-handler-jetty,javax.servlet:javax.servlet-api:3.1.0:org.eclipse.jetty:jetty-server:9.4.5.v20170502,/home/romastyi/.etlas/store/eta-<IP_ADDRESS>/wai-servlet-handler-jetty-<IP_ADDRESS>-f27d7066c58a43f516709ef5c34971e8ba9172cb5951959ffb34769e1db03a22/lib/wai-servlet-handler-jetty-<IP_ADDRESS>-f27d7066c58a43f516709ef5c34971e8ba9172cb5951959ffb34769e1db03a22.jar,base:wai:wai-servlet

i.e. library wai-servlet-handler-jetty depends of javax.servlet:javax.servlet-api:3.1.0 nad org.eclipse.jetty:jetty-server:9.4.5.v20170502.
This change solve this problem and add such external dependencies to sbt libraryDependencies variable.

Wonderful, thanks for doing extensive testing! When you have committed all the necessary fixes, let me know and I'll do a review & merge.

I added another fix which allows plugin to work with projects with several artifacts. For example, this one: crud-ex-backend-servant

I think this is the last fix in this pull request.


Add jcl extension for auto syntax highlighting

Related to #18

@binary-sequence PR is out of date with base branch, could you please update?

Branch updated :)


delete unnecessary files

some of the files checked in are not necessary:

README.pdf -- minimal gain and would need to be regenerated for every change
README_20180403.md -- this looks like a back up
VirtualHelpDesk.mp4 -- put it up on youtube?
manifest_bak.yml -- use manifest.yml
minimal .travis.yml -- use travis.yml
start_fail.log -- no need for a log

@stevemart sorry, I did not see the comments until now. Files were removed


Memory Usage During Trace Expansion

There appears to be an issue where trace expansion can lead to very high memory usage on very large traces.  This is likely to be partly caused by concurrency generating high memory pressure.  Therefore, batching go-routines could reduce this pressure.

Hey @DavePearce
I would like to work on this issue.
Adding a worker-queue here for limiting number of go-routines should help with memory.

Well, at this stage, its not a particularly big problem for us.  I have used batch processing for the various parts which have helped.

Well, at this stage, its not a particularly big problem for us.  I have used batch processing for the various parts which have helped.

Ah cool.
Well I did implement a generic worker queue and incorporated it with this function. If you want, I can raise a PR.


Downloading Leaderboards

Hello, I used the example code from the issues #90 and #121 to use the leaderboard.
I can find the leaderboard, but after I download it, nothing happens. It's not entering the _leaderboard_downloaded() function.
Here's the code:
func _ready():
	get_node("Block").rect_position.y = Global.screen.y
	get_node("Back").rect_position.y = Global.screen.y

	tween_enterScene(true)
	Global.tween.start()
	yield(Global.tween, "tween_completed")

	Steam.connect("leaderboard_find_result", self, "_leaderboard_found")
	Steam.connect("leaderboard_scores_downloaded", self, "_leaderboard_downloaded")

	Steam.findLeaderboard("highscores")

func _leaderboard_found(leaderboard_handle, found):
	Global.HANDLE = leaderboard_handle

	if found == 1:
		print("print works")
		Steam.downloadLeaderboardEntries(0, 15)
		print("print works")

func _leaderboard_downloaded():
	print("doesnt print")
	var scores = Steam.getLeaderboardEntries()
	print(scores)

func _process(delta):
	Steam.run_callbacks()

Hmm, the ol' leaderboard issue.  Let's see if we can get it figured out!  I'll ask some stock questions to get them out of the way.  Did you fresh compile or are you using a pre-compile?  Did you set up the "highscores" leaderboard in the Steamworks back-end?  Are you using your game's app ID in the steam_appid.txt file?
If you apply the Steam.findLeaderboard command to a button instead of auto-running at _ready, does that make any different?  It shouldn't but just curious.
I noticed you Steam.downloadLeaderboardEntries function is missing one argument. There should be three: start, end, type.  Right now you are only passing start and end but not type.  This might be why it fails silently.
Let me know the answers to these questions and if my suggestions make any difference and we'll go from there!

I'm using a fresh compile version. Everything should be alright in the Steamworks, because I can upload my highscore in the leaderboard without any problem. And I'm using the correct app ID.
The findLeaderboard works in a button too.
I saw in the documentation that the third argument of that function is optional, if I don't use it, it goes as type = 0. But I already tried to specify the argument and the same happens.

Hmm, that it does.
Other callbacks are working fine though?  It just doesn't send back any leaderboard data?

Yeah, the others are working just fine.
The only problem is that after I download the leaderboard, nothing happens.
I also tried the function downloadLeaderboardEntriesForUsers with the Steam ID, but nothing happens either.

I was reading the code to see how the callback was made.
The signal is emitted with a message and the array.
So I tried that:
func _leaderboard_downloaded(message, array_result)

And now it works!
Thanks for the help, Gramps.

Ah, gotcha.  Yeah, in my latest project I started using static typing more and it helped solves some issues before they became problems.
Sorry I didn't think to ask what responses you were expecting from the callback or not noticing it faster in your example code.  But glad it got sorted out!


Install at cmd in startup script and support configuring SSD disk type

Flag for choosing boot disk type for creating the VM with SSD storage, defaults to SSD
Installs the at command in startup script as it is a key dependency

It would be great to have this completed and merged as Ubuntu 22.04 doesn't currently include at and it needs to be installed as a separate dependency.
Happy to open a fresher PR (if this one got abandoned) to get it merged.

@andodet please go ahead, PR are welcome.

Give #30 this is now obsolete. Closing.


Jwt Access Credentials should cache JWTs

The JWT Access Credentials should temporarily cache JWTs. Suggested algorithm:

Hash JWTs using Audience as key.
Also store the timestamp of last use with each JWT.
On access clear any JWT unused for more than 1 hour.

@anthmgoogle Hey Anthony, we're working on clearing the issue backlog. Is this still relevant?

No concern with closing this issue.
On Tue, Jun 5, 2018 at 5:19 PM, Daniel Azuma<EMAIL_ADDRESS>wrote:

@anthmgoogle https://github.com/anthmgoogle Hey Anthony, we're working
on clearing the issue backlog. Is this still relevant?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/google-auth-library-ruby/issues/46#issuecomment-394900820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGWHELP3YMQBGG8Ku8-5VXR0ggi5JpJYks5t5yAsgaJpZM4FpH1y
.


3D printable case for Build A

A 3D printable case is needed for Build A.
The Raspberry Pi should be isolated from the sensors, to avoid the Pi's high temperatures from affecting sensor accuracy.
The case should have good but not turbulent ventilation over sensors, and protect them from direct light. Ideally, it would follow any airflow directions outlined in the sensor data sheets (Sensirion has very specific details here).

Dims for the standard Qwiic 1" breakout. The mounting holes are compatible with 4-40 screws e.g. https://www.sparkfun.com/products/10453 and https://www.sparkfun.com/products/10463.
This is for the SCD40 and SGP40.
Note, the MS5637, BME680, and some others that I've seen are the same but only have two mounting holes. For future compat it may be good to ensure any 2-hole sensors can mounted.

Dims for SPS30:

Avoid obstructing the intake/outtake and wires:

I have found this ambient light sensor from Adafruit that is QWIIC compatible: https://www.adafruit.com/product/4681


Sample of formatting and writing NDEF to a Mifare Classic 1k chip

I was wondering if someone has a sample of formatting/writing NDEF to a Mifare Classic 1k using this library? I've tried several approaches but with no luck so far!

@Thevertex sorry for the late response.
Great advice, I hope that as well. Since Mifare Classic uses proprietary mechanism, and I'm not an expert for this tag, I will label this issue as help-wanted to see if someone can help us.
Thanks!

No problems @whitedogg13 , I'm still working on the problem, if I do come up with a solution ill report it here


coreaudio: update to coreaudio-rs 0.5.0

[x] typechecks
[x] builds
[x] beep example makes a sound
[ ] I know what I'm doing

From what I could gather from coreaudio-rs docs with my limited Rust knowledge this seems okay but please do review...

While the patch seems to work fine, I get massive stuttering in example code. Since I don't know if cpal ever actually worked on OSX I decided to poke around a bit. After some more testing with rodio it seems the stuttering is caused by samples_receiver.try_recv() on src/coreaudio/lib.rs:122 taking an undeterministic time to complete, which is a no-go in the audio unit render callback. (can that even happen?)


Lack of web compatibility blocks ObjectScript 2.12+ extension from being usable in the browser version of VS Code

See https://community.intersystems.com/post/vscode-objectscript-github#comment-266991

The browser version of vscode-objectscript does almost nothing:
https://github.com/intersystems-community/vscode-objectscript/blob/ef66f3abac696dde8fd04c5b947dbabc41bbb7dc/src/web-extension.ts#L14-L31

This should work in VSCodium and other "browser based" vscodes.

@isc-bsaviano Just edited, code-server is where I am running with success. I guess the original issue is vscode.dev?

Yes, vscode.dev is a browser-only environment where this extension isn't supported.


Try to create tables in parallel

Feature Request
Is your feature request related to a problem? Please describe:
Currently we perform CREATE TABLE (tidbMgr.InitSchema) in sequence. But experiences in BR shows that running them in parallel is faster pingcap/br#377
Describe the feature you'd like:
Execute the CREATE TABLE in restoreSchema in parallel over 16 connections.
Benchmark that by importing 300 small tables.
Describe alternatives you've considered:
Don't do it.
Teachability, Documentation, Adoption, Optimization:
N/A
Score
600
SIG slack channel
sig-migrate
Mentor
@kennytm

/ping

/ping

/pick-up

@kennytm shall we label it sig-migrate?

@kennytm shall we label it sig-migrate?

we're setting sig label for this whole repo in https://github.com/pingcap/tidb-lightning/pull/498 😄

@kennytm shall we label it sig-migrate?

Could you please try pick up again?

/pick-up

/cc @hi-rustin maybe later?

/cc @hi-rustin maybe later?

Try it when #498  megred.

@hidehalo Please try again~

BTW, there's a similar issue in DM https://github.com/pingcap/dm/issues/717 . We'll be happy if you could take a look after this one (will add learning material and score later)

/pick-up

BTW, there's a similar issue in DM pingcap/dm#717 . We'll be happy if you could take a look after this one (will add learning material and score later)

Thx!

/pick-up

/pick-up

/pick-up


Fix headers for TizenRT

This system doesn't provide utime.h and pwd.h headers.
Signed-off-by: Jaroslaw Pelczar<EMAIL_ADDRESS>

I removed line break and comment from line 52 with include/uv-unix.h.
It is clear that this header uses very symilar syntax just 10 lines above:
https://github.com/pmarcinkiew/libtuv/blob/da195f5a31e5e90f9c20ac9589efa5608d912269/include/uv-unix.h#L47
The comments about missing pwd.h are helpful.
@yichoi, would you be so kind to explain, why line break and comment should be removed from line 52?

That's make sense.

LGTM

BTW, It does not works with IoT.js
https://travis-ci.org/Samsung/iotjs/jobs/271532766


chore(deps): update dependency org.hibernate:hibernate to 3.6.0.beta2

This PR contains the following updates:

Package
Change

org.hibernate:hibernate
3.2.7.ga -> 3.6.0.Beta2

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Renovate Bot.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (3.6.0.Beta2). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Saving, load and testing for cyclegan_keras

How do I save the model of cyclegan_keras?
Also how do i test the trained model?
Thanks!

The keras version uses a unet as generator while the lasagne one uses resnet.

I was also trying to save the model, but I don't seem to find a model object in there to do model.save().
Can you please point which line in CGAN-keras
must be tweaked to save the model, and where is the model object to save iteratively.

The generating models are defined in these lines.
netGB = UNET_G(imageSize, nc_in, nc_out, ngf)
netGA = UNET_G(imageSize, nc_out, nc_in, ngf)

You can save them after they are trained.

Just add this snippet at the end of the code:
def save_model(model, filepath):
    # serialize model to JSON
    model_json = model.to_json()
    with open("{}.json".format(filepath), "w") as json_file:
        json_file.write(model_json)
    # serialize weights to HDF5
    model.save_weights("{}.h5".format(filepath))

save_model(netDA, 'your/output/path/' + 'netDA')
save_model(netDB, 'your/output/path/' + 'netDB')
save_model(netGA, 'your/output/path/' + 'netGA')
save_model(netGB, 'your/output/path/' + 'netGB')

And you can load the model and than generate fake images with the trained model with this code I've made.


[6/x] placeholder components

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1714

PR #1715

PR #1716

PR #1717

PR #1718

PR #1719   👈

This comment was auto-generated by Graphite.


Solution Import Error: Solution Files does not exist & --path is invalid

Hello,
I am receiving two similar errors while trying to import.
The first error when packing the solution then importing is: "Error: Solution file "D:\a**\out\solutions******.zip" does not exist".
Second error when packing the solution, uploading to GH artifact store, downloading from GH artifact store, then importing is: "Error: failed: Error: Microsoft PowerPlatform CLI,,Version: 1.7.5+g64e6bc4,,,,Error: Argument '--path' is invalid. The file 'D:\a*******.zip' could not be found.
I have logs available.
Thank you

These errors are pretty self explanatory. Please check files actually exist before calling an action


index in spanish page had some words still in englosh

Signed-off-by: JOSE ALONSO LOPEZ ROMO<EMAIL_ADDRESS>Description
Some words in the index docs page, in the spanish section, were still in english.
This PR fixes #
Notes for Reviewers
Validate this pr please @jesuslerma, @ramrodo
Signed commits

[X] Yes, I signed my commits.

🚀 Preview for commit b875d6439ffbce2edf41effc254ba930354478c6 at: https://615b98441f5f4a37e73d57ed--meshery-docs-preview.netlify.app

Excellent.. thanks.. I think the people in the workshop really liked it, and hopefully they start contributing this week 🙌🏼

Very cool. 😎


User stories

We can write user stories here
@Cubelrti @SamLangTen

Client (general mode):

redirect to the login page from third party website
enter user name and password
review the information the third party service want to access
agree or change permissions
redirect back to the third party website

Register (Client)
1.

User Management (Administrator)

Edit a user (Administrator)

go to management portal
select a user and click on edit
update information in a editing aera
click on save

User stories above has been moved to wiki Design Meeting Notes, July 2 at OP


I want to have 'sticky fields' where the last option selected remains within the field the next time the form is opened

So that users don't need to input the same data over and over again each time they open the form, where this info has not changed

See spreadsheet in #11


Make standalone builds (automated)

Make and distribute for each release a binary that bundles the Python interpreter, for each supported platform.
Not yet sure what will be needed precisely to achieve that, but here are some rough pointers:

[ ] make a GitHub Actions workflow to auto push to PyPi on GitHub new release.
[ ] use pyInstaller to make frozen builds?
[ ] to make multi-platforms builds, maybe combine with cibuildwheel?
[ ] automate the building and distribution process (attaching standalone binaries on GitHub Releases) by using a GitHub Actions Workflow?

See:

https://data-dive.com/multi-os-deployment-in-cloud-using-pyinstaller-and-github-actions/
https://github.com/pyinstaller/pyinstaller/issues/6296
https://github.com/marketplace/actions/pyinstaller-action and https://github.com/Martin005/pyinstaller-action


Remove authorization immutable flag from clear options

Under no circumstance would/can you ever clear an Authorization Immutable flag.
However, this is not quite as aesthetic looking:

Closes #320

Closes #320

FYI, Close/Closed/Fix etc auto-close tags doesn't work in comments. Updated the main PR description to automatically close #320.


⚠ Bofrost.at has degraded performance

In 975b5b6, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3442 ms

Resolved: Bofrost.at performance has improved in b30359f after 9 minutes.


POC: Auto upgrades with release channels

If we started using release channels based off of github tags such as "stable", and tagged our docker image accordingly, we could provide an opt in mechanism to customers to allow them to run a static image tag, but remove some of the downsides by having our application check once a day if an upgrade is available (current "stable" tag sha doesn't match the sha from buildinfo), and if so, triggers a signal that is user configurable for the calling application to handle and gracefully shutdown.  By restarting the pod, and having k8s set to have imagePullPolicy: Always, an application should be able to check for updates at least once a day.
This does require us to be more disciplined around gracefully rolling out breaking changes.

this is an interesting idea, but what guarantee do we have imagePullPolicy: Always is being set by the user/maintainer? could we add a check to say if this is not set or gets changed some kind of alert bubbles up that this feature is disabled.
@chainlink and I had discussed something a long the lines of using latest as a tag and coming to same predicament.

this is an interesting idea, but what guarantee do we have imagePullPolicy: Always is being set by the user/maintainer? could we add a check to say if this is not set or gets changed some kind of alert bubbles up that this feature is disabled.
@chainlink and I had discussed something a long the lines of using latest as a tag and coming to same predicament.

I mean we can control that through the helmchart - could definitely make a flag - AutoUpgrade = True or something, it automatically set's ImagePullPolicy to Always (Could also just make that the default) and probably an env var to control this behavior for pachd.  Worst case if a user misconfigures it- this just causes a restart a day and they don't automatically upgrade.

I don't think running off a static tag is a good idea as it makes it more difficult to figure out exactly what version in running. Further, I think this is premature, as we don't (yet) have the rigor around testing to ensure an automated release won't break a client install / create a support headache.

I don't think running off a static tag is a good idea as it makes it more difficult to figure out exactly what version in running. Further, I think this is premature, as we don't (yet) have the rigor around testing to ensure an automated release won't break a client install / create a support headache.

I have a complementary PR https://github.com/pachyderm/pachyderm/pull/7941  that addresses the versioning issue, but basically can leverage go's built in buildinfo to get the commit sha and plumb that through versioning / have that log line emitted on startup (which I need to add to that PR yet). Going forwards, it should be trivial to determine a version, and not rely on mutable tags for that information. Secondly, I 100% agree that this shouldn't be released or shown to customers yet. However, if this proposal seems useful, we could leverage it in a bunch of internal environments like  helium or pachyderm.pachops.com to start practicing / testing our release processes (ie if we had a nightly release channel) and upgrades to ensure that in a quarter or so, we could potentially start rolling this out to customers.  This also does not replace any of our existing release processes, and would only ever be opt-in when and if we are comfortable enough exposing this to customers.

I still think the issue here is pach automatically updating itself vs having an external process do it (helm upgrade, etc) How would this handle something getting added/removed from the helm chart?

I still think the issue here is pach automatically updating itself vs having an external process do it (helm upgrade, etc) How would this handle something getting added/removed from the helm chart?

I think configuration changes are an outside concern, this should actually just slot in nicely to existing gitops tools.  We'll have to increase our maturity to not have breaking configuration changes without a deprecation cycle, i.e. deprecate certain fields / support old and new field for at least a release, then eventually remove that old field in a followup release. We could possibly even upgrade this tooling to check for certain values that need to be switched and warn/fix/not update too if we wanted. This does not alleviate the need for helm/gitops, but it enables customers to not have to think about upgrades in certain scenarios and be able to be upgraded faster.

Closing this PR as obsolete


Ledger + Firefox support

A user is reporting that Ledger isn't able to connect to our dapp using Firefox on a Mac. I've confirmed that Firefox works okay with WalletConnect but I'm unable to test directly connecting with Ledger.

This turns out to be non-specific to OETH but rather a known issue with other dapps.


Is there a way to disable entity linker and its dependencies?

In my production environment I can't install or run hnswlib. Is there a way I can install scispacy without the entity linker and its dependencies? I am happy to work on a way to decouple scispacy like this if this would be an acceptable contribution. I think it would be good to split the entity linking for other users as well.

Hi @swartchris8, you can install scispacy with pip install scispacy --no-deps. This will not install any of the requirements for the package, and then you can install all of the requirements except for nmslib. You could also clone the repo, edit the requirements file and setup.py to remove nmslib, and then install from source. Does one of these solutions work for you? Or did you have another solution in mind?

Thanks for the great package, I realise I might not need the scispacy package installed if I just start working from the model directly and then I don't have to worry about disabling the linker until I can see if I can run this on Dataflow.


DomainEntitiesResolver class does not support values FacetFilterInput parameter

Describe the bug
Schema of GMS GraphQL indicates that domains object returned by listDomains query has a function entities which takes DomainEntitiesInput as input, which in turn contains variable filters which, according to the schema, allows for fields:
condition: FilterOperator
field: String!
negated: Boolean
value: String
values: [String!]

With an indication that value field is deprecated and values should be used instead. Unfortunately handling of values is not properly implemented - trying to issue query having input containing values instead of value field ends up with a server side exception.
To Reproduce
Issue GraphQL query:
query listDomains {
  listDomains(input: {start: 0, count: 1000}) {
    start
    count
    total
    domains {
      urn
      properties {
        name
      }
    dataProducts: entities(
      input: {start: 0, count: 0, filters: [{field: "_entityType", values: ["DATA_PRODUCT"]}]}
    ) {
      total
      __typename
    }
      __typename
    }
    __typename
  }
}

Instead of expected output, a list of server-side exceptions (code 500) is returned. Closer look at GMS logs indicates that (log comes from datahub version 0.12.0 so line numbers do not match but problem persists in current master):
Caused by: java.lang.NullPointerException: Cannot set field value of com.linkedin.metadata.query.filter.Criterion to null
	at com.linkedin.metadata.query.filter.Criterion.setValue(Criterion.java:304)
	at com.linkedin.datahub.graphql.resolvers.domain.DomainEntitiesResolver.lambda$get$0(DomainEntitiesResolver.java:77)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
	at com.linkedin.datahub.graphql.resolvers.domain.DomainEntitiesResolver.lambda$get$1(DomainEntitiesResolver.java:76)

Expected behavior
values field is used in the filter criterion. Additionally value field should be supported too as schema indicates it is supported but deprecated. As to what should happen if both of them are provided I am not sure.
Additional context
There is clear indication what stands behind this bug, the class implementation uses filter.getValue() and not getValues() at all:
https://github.com/datahub-project/datahub/blob/master/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/domain/DomainEntitiesResolver.java#L83

@jjoyce0510 Is this a known issue? any plan to fix soon?
While we could overcome this by using the deprecated value fiend until fixed, we access GMS GraphQL through a GraphQL Mesh component which has an issue preventing us using deprecated fields 😅 So the request on fixing in GMS


Update SEO description

Update it to:

Delta (Δ) is a high-performance machine learning framework written in Rust, tailored for compute-intensive tasks. Designed with both beginners and experts in mind, it offers intuitive APIs that simplify workflows while remaining flexible for advanced customizations.

If you feel the issue is not resolved, please reopen it.


Refactor required for update of redux-form

redux-form v6.2.1 promises performance boost's amongst other things.
See #11876 for details
We need to refactor every instance of redux-form in our app. Handily, there is a migration guide here.
Many thanks and Happy Coding!

We will be moving away from redux-form in the future as the current version breaks with hot reloader.

There is a note on the redux-form site about hot reload, they have an issue
with v1.x but it is resolved with hot loader v3, we would need to wait for
v3 to come out of beta though.
On Sunday, December 4, 2016, Berkeley Martinez<EMAIL_ADDRESS>wrote:

We will be moving away from redux-form in the future as the current
version breaks with hot reloader.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11919#issuecomment-264727981,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARtk5reRaAC4rQEl4hKzcPT76E_s-aqNks5rEyBagaJpZM4LDrZ7
.

Yes, that is what I remember as well. For now redux-form gets the job done in its current state. It's upsetting that they haven't fixed the issue with hot-reload v1 since this is the version that is still widely used. I'm not happy about that or the api of the new version so we will peg it on v5 for now.


[BUG] command中注解加载service，服务重启失败的问题

Execute the command and paste the result below.
Command: uname -a && php -v && composer info | grep hyperf && php --ri swoole
Linux a54509b2ea42 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020 x86_64 Linux
PHP 7.2.27 (cli) (built: Jan 27 2020 22:54:17) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
hyperf/async-queue                   v2.0.9   A async queue component for hyperf.
hyperf/cache                         v2.0.9   A cache component for hyperf.
hyperf/command                       v2.0.10  Command for hyperf
hyperf/config                        v2.0.9   An independent component that provides configuration container.
hyperf/config-apollo                 v2.0.10  An apollo adapter for Hyperf config component.
hyperf/constants                     v2.0.9   A constants component for hyperf.
hyperf/consul                        v2.0.9   A Consul Client for Hyperf.
hyperf/contract                      v2.0.9   The contracts of Hyperf.
hyperf/database                      v2.0.10  A flexible database library.
hyperf/db                            v2.0.10
hyperf/db-connection                 v2.0.10  A hyperf db connection handler for hyperf/database.
hyperf/devtool                       v2.0.10  A Devtool for Hyperf.
hyperf/di                            v2.0.10  A DI for Hyperf.
hyperf/dispatcher                    v2.0.10  A HTTP Server for Hyperf.
hyperf/event                         v2.0.10  an event manager that implements PSR-14.
hyperf/exception-handler             v2.0.10  Exception handler for hyperf
hyperf/filesystem                    v2.0.11  flysystem integration for hyperf
hyperf/framework                     v2.0.3   A coroutine framework that focuses on hyperspeed and flexible, specifically use for build microservices and middlewares.
hyperf/guzzle                        v2.0.3   Swoole coroutine handler for guzzle
hyperf/http-message                  v2.0.3   microservice framework base on swoole
hyperf/http-server                   v2.0.9   A HTTP Server for Hyperf.
hyperf/json-rpc                      v2.0.7   A JSON RPC component for Hyperf RPC Server or Client.
hyperf/load-balancer                 v2.0.3   A load balancer library for Hyperf.
hyperf/logger                        v2.0.3   A logger component for hyperf.
hyperf/memory                        v2.0.3   An independent component that use to operate and manage memory.
hyperf/model-cache                   v2.0.10  A model cache component for hyperf.
hyperf/model-listener                v2.0.3   A model listener for Hyperf.
hyperf/paginator                     v2.0.3   A paginator component for hyperf.
hyperf/pool                          v2.0.3   An independent universal connection pool component.
hyperf/process                       v2.0.9   A process component for hyperf.
hyperf/redis                         v2.0.3   A redis component for hyperf.
hyperf/rpc                           v2.0.3   A rpc basic library for Hyperf.
hyperf/rpc-client                    v2.0.7   An abstract rpc server component for Hyperf.
hyperf/rpc-server                    v2.0.9   An abstract rpc server component for Hyperf.
hyperf/server                        v2.0.9   A base server library for Hyperf.
hyperf/service-governance            v2.0.3   A service governance component for Hyperf.
hyperf/snowflake                     v2.0.4   A snowflake library
hyperf/testing                       v2.0.3   Testing for hyperf
hyperf/utils                         v2.0.9   A tools package that could help developer solved the problem quickly.
swoole
Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 4.5.2
Built => May 29 2020 04:24:53
coroutine => enabled
epoll => enabled
eventfd => enabled
signalfd => enabled
spinlock => enabled
rwlock => enabled
openssl => OpenSSL 1.1.1g  21 Apr 2020
http2 => enabled
pcre => enabled
zlib => 1.2.11
mutex_timedlock => enabled
pthread_barrier => enabled
mysqlnd => enabled
async_redis => enabled
Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 8388608 => 8388608
# Paste the result here.

Description:
当在command中使用注解引入service A 之后，如果在A中引入一个外部 service   B时 重启报错

Steps To Reproduce:

贴代码啊

CartServiceInterface 绑定了没呢？

贴代码啊

conmand里面的注解注释掉之后，重启就可以了

CartServiceInterface 绑定了没呢？

在services中绑定了

代码复现不了，你再自己看看吧
你可以试试我这个 demo
https://github.com/limingxinleo/hyperf2.0-demo
php bin/hyperf.php test:test 123


Stackstorm rate-limiting feature for workflow and host level

(Copied manually from https://github.com/StackStorm/st2contrib/issues/647, original reporter https://github.com/sibirajal)
We have configured multiple rules/workflows/actions for our infrastructure monitoring alerts to perform the auto remediation with ST2.
The workflows are created for different alerts and we would like to have some rate limiting at workflow level and individual host level to avoid the continues remediation. If we have this feature in Stackstorm will help us to avoid masking of the real issues.
For example:
Scenario 1: host level
The disk alert appeared in the monitoring for serverX and St2 performed the remediation at 10 am. Same disk alert appeared in the monitoring for serverX at 10:08 am and St2 shouldn't perform the remediation. It should have some rate limiting feature to avoid the continues remediation.
Scenario 2: workflow level
The disk alert appeared in the monitoring for serverX and st2 performed the remediation at 10 am using the disk_remediation_workflow.
The disk alert appeared in the monitoring for serverY and st2 performed the remediation at 10:15 am. Again the disk alert appeared in the monitoring for serverZ and st2 performed the remediation at 10:20 am. In this case we would like to have some rate limiting at workflow level to avoid the infinite time execution.

/cc @sibirajal


Support parsing window function in MySQL.

Feature Request
Is your feature request related to a problem? Please describe:
The window function is common used in MySQL. It would be very useful that TiDB parser can support the statement of the following type.
SELECT LAG(high, 1) OVER (ORDER BY date) AS high_lag_1 FROM stocks.apple_daily;

Describe the feature you'd like:
Support the window function like SELECT LAG(high, 1) OVER (ORDER BY date) AS high_lag_1 FROM stocks.apple_daily;
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:

Hello. What is the parser version you are using? TiDB already supports window function since #37.

Hello. What is the parser version you are using? TiDB already supports window function since #37.

I just copy the code from the tutorial to main.go and replace the sample SQL:
package main

import (
	"fmt"

	"github.com/pingcap/parser"
	"github.com/pingcap/parser/ast"
	_ "github.com/pingcap/parser/test_driver"
)

func parse(sql string) (*ast.StmtNode, error) {
	p := parser.New()

	stmtNodes, _, err := p.Parse(sql, "", "")
	if err != nil {
		return nil, err
	}

	return &stmtNodes[0], nil
}

func main() {
	astNode, err := parse("SELECT LAG(high, 1) OVER (ORDER BY date) AS high_lag_1 FROM stocks.apple_daily;")
	if err != nil {
		fmt.Printf("parse error: %v\n", err.Error())
		return
	}
	fmt.Printf("%v\n", *astNode)
}

After execute the command go run main.go, we will get the parsing error.
parse error: line 1 column 26 near "(ORDER BY date) AS high_lag_1 FROM stocks.apple_daily;"

oh, you need to set EnableWindowFunc to true to allow parsing them.
func parse(sql string) (*ast.StmtNode, error) {
	p := parser.New()
	p.EnableWindowFunc(true)

@tangenta does it make sense to set EnableWindowFunc true by default nowadays? It has been set to true in TiDB since pingcap/tidb#10607 over a year ago.

@tangenta does it make sense to set EnableWindowFunc true by default nowadays?

https://github.com/pingcap/parser/blob/7de049213f00b8b550c2b19c41b40bee820e1388/lexer.go#L51-L54
If we set it true by default, there should be a TiDB config option to control this behavior.

@tangenta
MySQL [(none)]> select @@tidb_enable_window_function;
+-------------------------------+
| @@tidb_enable_window_function |
+-------------------------------+
| 1                             |
+-------------------------------+
1 row in set (0.001 sec)

MySQL [(none)]> select 1 row_number;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 19 near "row_number"

MySQL [(none)]> set @@tidb_enable_window_function = 0;
Query OK, 0 rows affected (0.001 sec)

MySQL [(none)]> select 1 row_number;
+------------+
| row_number |
+------------+
|          1 |
+------------+
1 row in set (0.001 sec)


[outdated doc] plz remove namedModules from 5.x doc

Feature to document
namedModules for optimization config
Author(s)
I do not know
Additional information
It was traced to a doc update because a prop was not found when I was configuring webpack5
https://github.com/webpack/webpack-cli/issues/1809
[ x ] I am willing to work on this issue and submit a pull request. (but I am not sure if its just removing it? if so I can take on)

It's removed in this commit https://github.com/webpack/webpack/commit/5e72a6505a0a91024d82fa2e9e1a7d14c61c022d. I think removing it should be enough.

PR welcomed, let us know if you need any help.

namedChunks must also be removed.
@achenwei-chwy Do you still want to do a PR? As there are only 3 days left, could you do that until tomorrow? Otherwise I will take it.


SDDM Theme does not seem to work

Describe the bug
After enabling sddm, I've tried to change its theme with where-is-my-sddm-theme, but to no avail. It still boots up with the default sddm theme. The thing is that there are no errors.
Steps To Reproduce
Steps to reproduce the behavior:

Enable SDDM
Add theme = "where-is-my-sddm-theme";
Reboot

Expected behavior
The theme should change without any issues.
Additional context
    services.xserver = {
        enable = true;
        videoDrivers = [ "amdgpu" ];
        displayManager.sddm = {
            enable = true;
            wayland.enable = true;
            #theme = "${pkgs.where-is-my-sddm-theme}";
            theme = "where-is-my-sddm-theme";
        };
    };

    environment.systemPackages = with pkgs; [
        where-is-my-sddm-theme
    ];

Also, typing sddm in the terminal returns:
[15:09:49.047] (II) DAEMON: Initializing...
[15:09:49.052] (II) DAEMON: Starting...
[15:09:49.053] (II) DAEMON: Logind interface found
[15:09:49.054] (II) DAEMON: Adding new display...
[15:09:49.055] (II) DAEMON: Loaded empty theme configuration
[15:09:49.056] (II) DAEMON: Using VT 7
[15:09:49.056] (II) DAEMON: Display server started.
[15:09:49.056] (II) DAEMON: Socket server starting...
[15:09:49.057] (II) DAEMON: Socket server started.
[15:09:49.057] (WW) DAEMON: Failed to change owner of the socket

Maintainers
@name-snrl
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.4-zen1, NixOS, 24.05 (Uakari), 24.05.20231209.666fc80`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

It's theme = "where_is_my_sddm_theme";, my bad!


scikit-learn 1.5.0 breaks glum

Python 3.12.3 | packaged by conda-forge | (main, Apr 15 2024, 18:35:20) [Clang 16.0.6 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import glum
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/private/tmp/glum/lib/python3.12/site-packages/glum/__init__.py", line 14, in <module>
    from ._glm import GeneralizedLinearRegressor, get_family, get_link
  File "/private/tmp/glum/lib/python3.12/site-packages/glum/_glm.py", line 58, in <module>
    from ._solvers import (
  File "/private/tmp/glum/lib/python3.12/site-packages/glum/_solvers.py", line 13, in <module>
    from ._cd_fast import (
  File "src/glum/_cd_fast.pyx", line 1, in init glum._cd_fast
TypeError: C variable sklearn.utils._random.DEFAULT_SEED has wrong signature (expected __pyx_t_7sklearn_5utils_7_random_UINT32_t, got __pyx_t_7sklearn_5utils_9_typedefs_uint32_t)
>>>

This happens with
glum                      3.0.0           py312hed2d4af_0    conda-forge
scikit-learn              1.5.0           py312h1b546db_0    conda-forge

The relevant change happened in https://github.com/scikit-learn/scikit-learn/pull/28656.
https://github.com/scikit-learn/scikit-learn/pull/28656/files#diff-5829233c37ebf7320b24dd970725c53fbbb1cd789e2ad5157093280f7f2a388cR8
I guess our CI system didn't catch this, because there we're always testing against the version that we're building with.

Should be fixed by this change.

To fix this without requiring sklearn >= 1.5, we will need to implement the random integer generation. Meanwhile, sklearn<1.5 has been pinned repodata for past versions here and here.


fixing typo in  running-system-checks-using-mesheryctl page

Notes for Reviewers

This PR fixes #12985

Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit cb2511940ee87edac353ade6910d711ba6c6aa81 at: https://676a9c86c6eae6b051ec7296--meshery-docs-preview.netlify.app

Happy to help and contribute to this wonderful project !


Suffix .sc is not supported

If I name a scala source code with suffix .sc, then vim-scala won't highlight it, how to fix that, thanks.

I just found a solution by viewing the source code in my machine,
just need to add a line in vim-scala/ftdetect/scala.vim
au BufRead,BufNewFile *.sc set filetype=scala
Maybe, it's better to merge that into the source code :)

I've not seen this to be a common convention so I don't know if we'd add it to the plugin proper, but if you'd like to support it in your personal configuration you should be able to add something like this to your vimrc:
autocmd BufRead,BufNewFile *.sc set filetype=scala

@ches I am very new to scala, but on wikipedia scala page, it says file name is .scala or .sc. So, I guess the plugin should support that by default, because 1) it's much shorter, 2) no body else use .sc.


[Unhandled promise rejection: TypeError: undefined is not a constructor (evaluating 'new pose.Pose')]

I am implementing Pose solution on React Native following the installation and usage from this doc. When I specified { runtime: 'tfjs' } in detectorConfig variable, everything works fine. But I want to change runtime to 'mediapipe' since the performance table in the doc shows that the mediapipe runtime gives higher FPS, and when I change it this error raises [Unhandled promise rejection: TypeError: undefined is not a constructor (evaluating 'new pose.Pose')]
System information:

Windows 10
Testing on Android devices with expo
@mediapipe/pose version 0.4.1624666670
Programming Language: JavaScript

This is my code App.js:
import * as tf from "@tensorflow/tfjs-core";
import "@tensorflow/tfjs-react-native";
import * as React from "react";
import { View, Text, Image, StyleSheet, Platform } from "react-native";
import { Camera } from "expo-camera";
import { cameraWithTensors } from "@tensorflow/tfjs-react-native";
import * as poseDetection from "@tensorflow-models/pose-detection";
import '@mediapipe/pose'
import "@tensorflow/tfjs-backend-webgl";

const TensorCamera = cameraWithTensors(Camera);

const estimationConfig = { flipHorizontal: true };
var rafID;

export default class App extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      loading: true,
      isTfReady: false,
      permission: false,
      detector: null,
    };
  }

  async loadBlazePoseModel() {
    const model = poseDetection.SupportedModels.BlazePose;
    const detectorConfig = {
      runtime: 'mediapipe',
      modelType: 'lite',
      solutionPath: './node_modules/@mediapipe/pose'
    };
    const blazeposeDetector = await poseDetection.createDetector(
      model,
      detectorConfig
    );

    return blazeposeDetector;
  }

  handleCameraStream(images, updatePreview, gl) {
    const {detector} = this.state;
    const loop = async () => {
      const nextImageTensor = images.next().value;

      const poses = await detector.estimatePoses(
        nextImageTensor,
        estimationConfig,
      );
      console.log('Poses results:', poses)
      tf.dispose(nextImageTensor)
      rafID = requestAnimationFrame(loop);
    };
    loop();
  }

  async componentDidMount() {
    // Wait for tf to be ready.
    await tf.ready();
    // Signal to the app that tensorflow.js can now be used.
    this.setState({
      isTfReady: true,
    });

    // ask camera permission
    const { status } = await Camera.requestPermissionsAsync();
    this.setState({
      permission: status === "granted",
    });

    const loadedDetector = await this.loadBlazePoseModel();
    this.setState({
      detector: loadedDetector,
      loading: false
    })

  }

  componentWillUnmount() {
    if (rafID) {
      cancelAnimationFrame(rafID);
    }
  }

  render() {
    const { loading, permission } = this.state;

    if (permission === null) {
      return <View />;
    }
    if (permission === false) {
      return <Text>No access to camera</Text>;
    }

    let textureDims;
    if (Platform.OS === "ios") {
      textureDims = {
        height: 1920,
        width: 1080,
      };
    } else {
      textureDims = {
        height: 1200,
        width: 1600,
      };
    }

    return (
      <View>
        {loading ? (
          <View>
            <Text
              style={{
                fontSize: 60,
                alignItems: "center",
                flex: 1,
                justifyContent: "center",
              }}
            >
              Loading
            </Text>
          </View>
        ) : (
          <View>
            <Text>Pose Estimation</Text>
            <TensorCamera
              // Standard Camera props
              style={styles.camera}
              type={Camera.Constants.Type.front}
              // Tensor related props
              cameraTextureHeight={textureDims.height}
              cameraTextureWidth={textureDims.width}
              resizeHeight={200}
              resizeWidth={152}
              resizeDepth={3}
              onReady={this.handleCameraStream.bind(this)}
              autorender={true}
            />
          </View>
        )}
      </View>
    );
  }
}

const styles = StyleSheet.create({
  camera: {
    position: "absolute",
    left: 50,
    top: 100,
    width: 600 / 2,
    height: 800 / 2,
    zIndex: 1,
    borderWidth: 1,
    borderColor: "black",
    borderRadius: 0,
  },
});

package.json:
{
  "main": "node_modules/expo/AppEntry.js",
  "scripts": {
    "start": "expo start",
    "android": "expo start --android",
    "ios": "expo start --ios",
    "web": "expo start --web",
    "eject": "expo eject"
  },
  "dependencies": {
    "@mediapipe/pose": "^0.4.1624666670",
    "@react-native-async-storage/async-storage": "~1.15.0",
    "@tensorflow-models/pose-detection": "^0.0.3",
    "@tensorflow/tfjs": "^3.8.0",
    "@tensorflow/tfjs-backend-wasm": "^3.8.0",
    "@tensorflow/tfjs-backend-webgl": "^3.8.0",
    "@tensorflow/tfjs-converter": "^3.8.0",
    "@tensorflow/tfjs-react-native": "^0.6.0",
    "expo": "~42.0.1",
    "expo-camera": "~11.2.1",
    "expo-gl": "~10.4.1",
    "expo-gl-cpp": "~10.4.0",
    "expo-status-bar": "~1.0.4",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "react-native": "https://github.com/expo/react-native/archive/sdk-42.0.0.tar.gz",
    "react-native-fs": "^2.18.0",
    "react-native-unimodules": "~0.14.5",
    "react-native-web": "~0.13.12"
  },
  "devDependencies": {
    "@babel/core": "^7.9.0"
  },
  "private": true
}

Complete Error Logs :
[Unhandled promise rejection: TypeError: undefined is not a constructor (evaluating 'new pose.Pose')]
at node_modules\@tensorflow-models\pose-detection\dist\blazepose_mediapipe\detector.js:69:28 in BlazePoseMediaPipeDetector
at node_modules\@tensorflow-models\pose-detection\dist\blazepose_mediapipe\detector.js:188:29 in __generator$argument_1
at node_modules\@tensorflow-models\pose-detection\dist\blazepose_mediapipe\detector.js:32:17 in step
at node_modules\@tensorflow-models\pose-detection\dist\blazepose_mediapipe\detector.js:7:13 in <anonymous>
at node_modules\react-native\node_modules\promise\setimmediate\core.js:45:6 in tryCallTwo
at node_modules\react-native\node_modules\promise\setimmediate\core.js:200:22 in doResolve
at node_modules\react-native\node_modules\promise\setimmediate\core.js:66:11 in Promise
at node_modules\@tensorflow-models\pose-detection\dist\blazepose_mediapipe\detector.js:3:11 in <anonymous>
at node_modules\@tensorflow-models\pose-detection\dist\create_detector.js:79:50 in __generator$argument_1
at node_modules\@tensorflow-models\pose-detection\dist\create_detector.js:48:17 in step
at node_modules\@tensorflow-models\pose-detection\dist\create_detector.js:23:13 in <anonymous>
at node_modules\react-native\node_modules\promise\setimmediate\core.js:45:6 in tryCallTwo
at node_modules\react-native\node_modules\promise\setimmediate\core.js:200:22 in doResolve
at node_modules\react-native\node_modules\promise\setimmediate\core.js:66:11 in Promise
at node_modules\@tensorflow-models\pose-detection\dist\create_detector.js:19:11 in <anonymous>
at App.js:36:36 in loadBlazePoseModel
at node_modules\regenerator-runtime\runtime.js:63:36 in tryCatch
at node_modules\regenerator-runtime\runtime.js:293:29 in invoke
at node_modules\regenerator-runtime\runtime.js:63:36 in tryCatch
at node_modules\regenerator-runtime\runtime.js:154:27 in invoke
at node_modules\regenerator-runtime\runtime.js:189:16 in PromiseImpl$argument_0
at node_modules\react-native\node_modules\promise\setimmediate\core.js:45:6 in tryCallTwo
at node_modules\react-native\node_modules\promise\setimmediate\core.js:200:22 in doResolve
at node_modules\react-native\node_modules\promise\setimmediate\core.js:66:11 in Promise
at node_modules\regenerator-runtime\runtime.js:188:15 in callInvokeWithMethodAndArg
at node_modules\regenerator-runtime\runtime.js:211:38 in enqueue
at node_modules\regenerator-runtime\runtime.js:238:8 in exports.async
at App.js:27:2 in loadBlazePoseModel
at App.js:98:33 in componentDidMount
at node_modules\regenerator-runtime\runtime.js:63:36 in tryCatch
at node_modules\regenerator-runtime\runtime.js:293:29 in invoke
at node_modules\regenerator-runtime\runtime.js:63:36 in tryCatch
at node_modules\regenerator-runtime\runtime.js:154:27 in invoke
at node_modules\regenerator-runtime\runtime.js:164:18 in PromiseImpl.resolve.then$argument_0
at node_modules\react-native\node_modules\promise\setimmediate\core.js:37:13 in tryCallOne
at node_modules\react-native\node_modules\promise\setimmediate\core.js:123:24 in setImmediate$argument_0
at node_modules\react-native\Libraries\Core\Timers\JSTimers.js:130:14 in _callTimer
at node_modules\react-native\Libraries\Core\Timers\JSTimers.js:181:14 in _callImmediatesPass
at node_modules\react-native\Libraries\Core\Timers\JSTimers.js:441:30 in callImmediates
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:387:6 in __callImmediates
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:135:6 in __guard$argument_0
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:364:10 in __guard
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:134:4 in flushedQueue
at [native code]:null in flushedQueue
at [native code]:null in invokeCallbackAndReturnFlushedQueue

I think this issue may have been assigned to the wrong repo-- this appears to be an issue in the setup for a tf.js project, which happens to use one of our MediaPipe backends for the machine learning.  For tf.js API questions, I think the repo to post to is here: https://github.com/tensorflow/tfjs


adds command line argument setting support

resolves https://github.com/kahkhang/kube-linode/issues/55

Thanks @daniellacosse! This looks awesome :)


Outdated endpoints?

I'm getting alot of unauthorized/not found errors with requests to backend from my frontend, is this something already addressed or is the issue on my side only?

It seems like you are accessing users controller without any login/register, all other controllers are protected so you cannot access them directly without login. also put request in groups controller expects some group id. hope it helps

⚠ This issue has not seen any activity in the past 2 months so I'm marking it as stale. I'll close it if it doesn't see any activity in the coming week.


Debian packaging for master branch

Added debian packaging stuff for the new master branch.

Thanks @khosrow!

@tomkralidis I forgot to bump version in debian changelog. Please see #95


add more geometry generation?

I was looking for something like this originally https://graphics.rwth-aachen.de:9000/Glow/glow-extras/-/tree/develop/geometry/glow-extras/geometry
Do you think it would make sense to port these files and incorporate them here?

I'm not sure I understand. What kind of geometry do you think about adding? And why?

Method where you say I need a cube/ quad/ sphere/ mesh with some dimensions and it generates the triangles. But these would not require the conversion from implicit geometry and could thus be faster.

I see this library more as a tool to generate meshes from implicit geometries.
Generating regular meshes seems to be an orthogonal task (although super relevant and interesting to implement - thinking about all those platonic and archimedian and catalan solids...).
Once we have that explicit geometry library, one could build a wrapper around the two that integrates both.

yeah only cause the name is tessellation I thought it might as well go here but see your point :D

I'm also a bit too lazy to publish on crates.io so there is that part of the motivation as well :D

I'm also a bit too lazy to publish on crates.io so there is that part of the motivation as well :D

You should give it a try. It's not too hard afterall.

true but its also more about having people rely on me maintaining it while I'm not yet sure I want to make that commitment/ can provide that :) I'll ping if I have some work to share though 👍


Bug in common.log

https://github.com/flatiron/winston/blob/master/lib/winston/common.js#L117
The options.meta !== undefined || options.meta !== null condition is always true.

Seems like this has been fixed, in 0.9.0 the || is an &&.

Thanks @tobli


Test that DB schema matches the Alembic migrations

If the DB schema as defined in metadata.classes.Package.from_resource_ids() doesn't match the schema you get from running alembic upgrade head, AND PudlPaths().pudl_db is a pre-existing file, the pudl_sqlite_io_manager throws an error at startup.
HOWEVER!

in integration tests, when pudl_sqlite_io_manager is initialized, PudlPaths().pudl_db does not actually point to an existing file, so we use metadata.create_all() - which masks any differences between the migrations and the Package
in nightly builds, the pudl_sqlite_io_manager isn't initialized until we actually want to write to the DB, which is pretty late in the DAG execution. This is a super avoidable nightly build failure.

So, to catch any divergence between the alembic migrations and the package metadata, I added a unit test that runs the migrations on a test db and tries to initialize the io manager.

I added comments etc. to hopefully address your questions in a more durable way - lmk what you think!


Feature request: Named inventories show their names

First character over the chest icon, and the whole name when hovering over it.
This may not be feasible to implement on the client, I'm unsure.

It is possible to implement on the client, LiamMCW's fork for version 1.17.1 of this mod actually had that feature. (I'd just temporarily removed it to make porting to 1.18.x easier)

I believe the relevant code for this is under SimpleBlockTab.java, but it has been a bit since I've worked on this project. I know for certain that my accesswidener is not proper code, haha

Interesting. I'm pretty sure I was noticing this not happening on the server I play on, but I did see some code relating to it. I'll look at it further later. Right now I'm working on #3


add zju.txt

the official website is zju.edu.cn, while you can view an English version on zju.edu.cn/english/ .

@zju-edu-zj Please provide us with a proof, which shows that the school recognizes the domain zju.cn you are submitting as an official email domain for the students.
You can provide us with any of the following:

A copy of instruction (a hard-copy or electronic one) given to you by the school that tells you to use an email address in this email domain
An URL of a page at the official school website that says that students use this email domain
A reference to a recognized journal where an article was published by someone from the school, with explicit affiliation to the school, and e-mail address from the email domain
A WHOIS data that link the email domain to the school somehow
A copy of official letter from the school representative saying that the school provides e-mail addresses in this domain to the students
Anything else that can prove this fact in similar way, i.e. can be verified independently.

@zju-edu-zj You might miss my previous comment. Please react.


Fix assets

nav-bg.gif was removed a long time ago (more than two years ago)
https://github.com/django/django/commit/86cd89095a9e92074d7eb93f2786e765ccb843e4
and all the other icons have been replaced by svg
https://github.com/django/django/commit/c32b61c6fd6ddf39fd49585954d422ef8d7304f6#diff-7864aeccdcfe4457988818b3b275e6ac

Can we please merge this and create a new version? This is needed urgently.