A Particular Param Syntax Makes Git Resolver Stop Working

Expected Behavior
Tekton controller can successfully schedule the TaskRun when using the following Param syntax for Git Resolver
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  generateName: "tr-git-resolver-"
spec:
  workspaces:
    - name: output
      emptyDir: {}
  params:
    - name: url
      value: https://github.com/tektoncd/catalog.git
    - name: revision
      value: main
  taskRef:
    resolver: git
    params:
      - name: url
        value:
          type: string
          stringVal: https://github.com/tektoncd/catalog.git
      - name: revision
        value:
          type: string
          stringVal: main
      - name: pathInRepo
        value:
          type: string
          stringVal: task/git-clone/0.8/git-clone.yaml

Actual Behavior
It fails to schedule the TaskRun, error message:
message: 'failed to get task: error requesting remote resource: error getting
      "Git" "default/git-22641305a9f3dd8efe7d2f99769499f0": error opening file "":
      cannot open directory: /'

Steps to Reproduce the Problem

Submit the YAML file
Describe the created TaskRun.

Additional Info
Environment
enable-api-fields=alpha

Kubernetes version:
Output of kubectl version:

This version information is deprecated and will be replaced with the output from kubectl version --short.  Use --output=yaml|json to get the full version.
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.2", GitCommit:"f66044f4361b9f1f96f0053dd46cb7dce5e990a8", GitTreeState:"clean", BuildDate:"2022-06-15T14:22:29Z", GoVersion:"go1.18.3", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.9-gke.3200", GitCommit:"92ea556d4e7418d0e7b5db1ee576a73f8fc47e91", GitTreeState:"clean", BuildDate:"2023-01-20T09:29:29Z", GoVersion:"go1.18.9b7", Compiler:"gc", Platform:"linux/amd64"}

Tekton Pipeline version:
Output of tkn version

Client version: dev
Pipeline version: v0.45.0

Error Logs in Tekton Controller Pod
{"severity":"error","timestamp":"2023-03-16T15:27:53.401Z","logger":"tekton-pipelines-controller","caller":"taskrun/taskrun.go:361","message":"Failed to determine Task spec to use for taskrun tr-git-resolver-1cfq2b: failed to get task: error requesting remote resource: error getting \"Git\" \"default/git-5f3b816bda119ef32529173400b6f525\": error opening file \"\": cannot open directory: /","commit":"d1b63d4","knative.dev/controller":"github.com.tektoncd.pipeline.pkg.reconciler.taskrun.Reconciler","knative.dev/kind":"tekton.dev.TaskRun","knative.dev/traceid":"e1f2c547-30e2-4b27-8fa2-3214ad8a11c4","knative.dev/key":"default/tr-git-resolver-1cfq2b","stacktrace":"github.com/tektoncd/pipeline/pkg/reconciler/taskrun.(*Reconciler).prepare\n\tgithub.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun.go:361\ngithub.com/tektoncd/pipeline/pkg/reconciler/taskrun.(*Reconciler).ReconcileKind\n\tgithub.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun.go:181\ngithub.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1beta1/taskrun.(*reconcilerImpl).Reconcile\n\tgithub.com/tektoncd/pipeline/pkg/client/injection/reconciler/pipeline/v1beta1/taskrun/reconciler.go:235\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\tknative.dev/pkg@v0.0.0-20221123011842-b78020c16606/controller/controller.go:542\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\tknative.dev/pkg@v0.0.0-20221123011842-b78020c16606/controller/controller.go:491"}

Valid Syntax
The following syntax works:
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  generateName: "tr-git-resolver-valid"
spec:
  workspaces:
    - name: output
      emptyDir: {}
  params:
    - name: url
      value: https://github.com/tektoncd/catalog.git
    - name: revision
      value: main
  taskRef:
    resolver: git
    params:
      - name: url
        value: https://github.com/tektoncd/catalog.git
      - name: revision
        value: main
      - name: pathInRepo
        value: task/git-clone/0.8/git-clone.yaml

We have discussed offline that this is not a supported syntax, shall we close this issue?

SGTM
/close

If this syntax isn't supported, we should deny pipelineruns and taskruns that use it. This error message is confusing-- it doesn't tell users what they can do to fix the problem. (I just ran into the same issue using this syntax in pipeline tasks.)

I think we already have docs&examples about how to use params correctly.
 Did you refer to any docs/examples? If so maybe we should fix them first.
The logic is in this function:
https://github.com/tektoncd/pipeline/blob/8541ed1d1173424e9b03684223b553da16be938f/pkg/apis/pipeline/v1beta1/param_types.go#L385
We overwrite the unmarshaljson to support string, array and object types for the same value.  What you're writing here:
      - name: url
        value:
          type: string
          stringVal: https://github.com/tektoncd/catalog.git

is the object syntax. The object has 2 keys "type" and "stringVal".

I think we already have docs&examples about how to use params correctly.  Did you refer to any docs/examples? If so maybe we should fix them first.

I was trying to reproduce an error encountered by an internal user. However, it looks like our API spec lists this syntax as "required" which seems inconsistent with saying this syntax is unsupported? (I found this via rg stringVal -g '*.md'.)

What you're writing here:
      - name: url
        value:
          type: string
          stringVal: https://github.com/tektoncd/catalog.git

is the object syntax. The object has 2 keys "type" and "stringVal". I think it may be hard to "tell users what to do" from code

🤯
I thought object syntax looked like this? https://tekton.dev/docs/pipelines/tasks/#object-type
 - name: url
    type: object
    properties:
        type: string
        stringVal: https://github.com/tektoncd/catalog.git

Are there multiple supported syntaxes for object params?
The specific error I got was param types don't match the user-specified type: [url revision] (from here), which was confusing because I thought I had specified string params and the task required string params. At the very least, we should add more detail to this error message.
Re: the git resolver, I'm not sure where this went wrong, but it seems like if it receives an object param called "pathInRepo" instead of a string param called "pathInRepo" it treats the "pathInRepo" as "/" which seems very user unfriendly

But I agree we could improve the error messages

Oh I see. But why referring to the api-spec doc rather than https://github.com/tektoncd/pipeline/blob/main/docs/tasks.md#specifying-parameters?

I didn't refer to these docs to generate this example, but it's super important that our API spec reflects the syntax we want vendors to be required to support.

But I agree we could improve the error messages

I think there are four AIs:

Fix/clarify API spec docs
Clarify regular docs: it might be worth it to create a "parameters" doc that explains the different syntax for defining params, including defaults, and providing values for the params, so you can see all the syntax in one place, and link to this doc from pipeline(run)s.md and task(run)s.md
Fix the git resolver (not sure exactly what happened here)
Improve the error messages in validate_taskrun.go

/remove-lifecycle stale this issue has not been solved as far as I know.
https://github.com/tektoncd/pipeline/pull/6445 helped a lot with docs, but the OpenAPI bit is still broken.


NFC detection fails sometimes

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

My Android device/devices supports BLE and has Android OS version >= 4.4
My Android device/devices have Bluetooth enabled
My app has Location Permissions granted

Basic information
I have few NFC beacons. When i tap the beacon on to the backside of the phone, some times beacon gets detected and sometimes not. I tried the same in Estimote app also.  Even in Estimote app, the Quick connect menu is not working sometimes.
**Expected behavior:**When i tap the NFC beacon i have to read the the Beacon identifier and mac address everytime,
Actual behavior: When i tap the beacon some times i am not able to read it via NFC (i.e Not detected).
Here my code
   private NfcAdapter mNfcAdapter;
    protected void onCreate(Bundle savedInstanceState) {
 mNfcAdapter = NfcAdapter.getDefaultAdapter(this);
}

    @Override
    public void onResume() {
        super.onResume();
        try {
            SystemRequirementsChecker.checkWithDefaultDialogs(this);
            IntentFilter tagDetected = new IntentFilter(NfcAdapter.ACTION_TAG_DISCOVERED);
            IntentFilter ndefDetected = new IntentFilter(NfcAdapter.ACTION_NDEF_DISCOVERED);
            IntentFilter[] nfcIntentFilter = new IntentFilter[]{tagDetected, ndefDetected};
            PendingIntent pendingIntent = PendingIntent.getActivity(
                    this, 0, new Intent(this, getClass()).addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP), 0);
            if (mNfcAdapter != null)
                mNfcAdapter.enableForegroundDispatch(this, pendingIntent, nfcIntentFilter, null);
        } catch (Exception e) {
            Log.e(TAG, "Nfc adapter failed");
        }
    }

 @Override
    protected void onNewIntent(Intent intent) {
        try {
            if (intent.getAction() != null &&
                   intent.getAction().equals(NfcAdapter.ACTION_TAG_DISCOVERED)) {
                Parcelable[] rawMsgs = intent.getParcelableArrayExtra(
                        NfcAdapter.EXTRA_NDEF_MESSAGES);
                if (rawMsgs != null) {
                    for (Parcelable rawMsg : rawMsgs) {
                        NdefMessage msg = (NdefMessage) rawMsg;
                        NdefRecord[] records = msg.getRecords();
                        for (NdefRecord record : records) {
                            if (record.getTnf() == NdefRecord.TNF_EXTERNAL_TYPE) {
                                String type = new String(record.getType(), Charset.forName("ascii"));
                                if ("estimote.com:id".equals(type)) {
                                    deviceId = DeviceId.fromBytes(record.getPayload());
                                } else if ("estimote.com:mac".equals(type)) {
                                    byte[] revMac = new byte[record.getPayload().length];
                                    for (int j = 0; j < revMac.length; j++) {
                                        revMac[j] = record.getPayload()[revMac.length - j - 1];
                                    }
                                    macAddress = MacAddress.fromBytes(revMac);
                                }
                            }
                        }
                    }
        } catch (Exception e) {
            Log.e(TAG, "New intend failed");
        }
    }

 @Override
    public void onDestroy() {
        super.onDestroy();
     mNfcAdapter=null;
    }

When beacons are not detected, i get rawMsgs as null in the following lines of code
Parcelable[] rawMsgs = intent.getParcelableArrayExtra(
NfcAdapter.EXTRA_NDEF_MESSAGES);

The NFC antenna in Estimote Beacons isn't particularly strong, so it sometimes requires a few tries to align the antenna in the beacon with the antenna in the smartphone properly. Not much to do here on the software/SDK side, so I've closed this issue.
You can start a discussion on our forums, tell us how you want to use NFC (configuration/deployment? or in your app?), and we can try to help, maybe suggest some alternative solution, etc.


Update Pusher-v5 model to one that is compatible with mujoco>=3

Description
increased the weight of the object to 7.85398163e-06 kg from 1.30899694e-08 kg (500x increase)
Fixes https://github.com/Farama-Foundation/Gymnasium/issues/950
testing & validation was done using: https://github.com/Kallinteris-Andreas/Gymnasium-Pusher-v5-model-validation
credits
@Kallinteris-Andreas
and thanks to @HernandezEduin, for initial testing
Type of change

[ ] Documentation only change (no code changed)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

There is now a warning for v4 and mujoco>=3 in the documentation for users using gymnasium<=1.0.0a1, for future users are not about to instantiate the environment with an incompatible versions for mujoco


[WIP][Metrics] add more metrics

metrics

time_queue_requests
time_inference_requests
time_prefill_requests
time_decode_requests
max_num_generation_tokens_requests

max_num_generation_tokens_requests.append(
    max(seq.get_output_len() for seq in seq_group.get_seqs())
)

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@robertgshaw2-neuralmagic I just replicating the new metrics that were added here. should I add some automated tests, or just visually look at the metrics？Thanks!

@robertgshaw2-neuralmagic I just replicating the new metrics that were added here. should I add some automated tests, or just visually look at the metrics？Thanks!

This one will be tricky to test given its a timing flow

Also, looks like you are missing the number of tokens in the batch for each iteration of the LLMEngine

Also, see https://github.com/vllm-project/vllm/issues/3616 for some more ideas

Also, looks like you are missing the number of tokens in the batch for each iteration of the LLMEngine

you mean num_generation_tokens_iter? It already exists.

https://github.com/vllm-project/vllm/issues/3616#issuecomment-2030858781
@robertgshaw2-neuralmagic BTW, Should some metrics be recorded with a periodic bypass process/thread, such as every 1 second.

#3616 (comment)
@robertgshaw2-neuralmagic BTW, Should some metrics be recorded with a periodic bypass process/thread, such as every 1 second.

We have this functionality already in the StatLogger, but I don't think any of these metrics should go through that pathway

Also, looks like you are missing the number of tokens in the batch for each iteration of the LLMEngine

you mean num_generation_tokens_iter? It already exists.

For chunked prefill, we can have prefill and generation tokens in the same batch
So I was looking for num_tokens_iter which would be the sum of num_generation_tokens_iter + num_prompt_tokens_iter

@HarryWu99 can you update the grafana dashboard and turn this into a real PR and not draft? would like to merge before friday (so it can be the release)
To run grafana, checkout examples/production_monitoring - I set up a docker compose to spin it up easily

@robertgshaw2-neuralmagic Thanks for attention!
I made some changes to the dashboard. Categorize the charts. But I'm not sure I'm showing some metrics the right way, such as:

request_params_n
request_best_of
request_max_num_generation_tokens

ok will try it out today

@robertgshaw2-neuralmagic Hi, will it still be merged before friday?

@robertgshaw2-neuralmagic Hi, will it still be merged before friday?

Working on merging this week

@robertgshaw2-neuralmagic ping~

sorry - traveling this week. back to PR review.
Ill fix conflict + merge tom

@robertgshaw2-neuralmagic Hello~ I see it's been approved for a while, but it is not merged yet. Anything wrong?

@HarryWu99 thanks for putting this PR together, Im interested in some of the metrics here too, it looks like it was approved with auto-merge enabled which means it will merge once the CI test go green, it appears however there are some bugs the CI is catching:
https://buildkite.com/vllm/ci/builds/8274#018fbcae-fbed-4edb-aad3-86d0aae11fad/51-695

I have made some changes, but the CI still fails. I get a bit confused, the problem reported by the CI seems to have nothing to do with this PR. @LucasWilkinson

@HarryWu99 thanks for updating the PR, a lot the tests can be flaky, I re-ran some of them to see if its just flakiness, although Im not familiar with the tool use test @robertgshaw2-neuralmagic may know more
you are rebased off latest main correct?

@LucasWilkinson  Yes, I rebased my branch onto the main branch.

@DarkLight1337  @HarryWu99 Just curious what exactly is the difference between time_queue_requests and the already existing vllm:time_in_queue_requests?


#23140: Update hanna twig templates to use hanna namespace

In this PR

replace storybook by hanna
describe how use hanna-twig folder in Drupal as part of README.md file.

Hi @maranomynet - This PR contains all hanna-twig template changes that will be needed in Drupal.
I think we need to decide how deploy this feature to live
Option 1: We merge this branch into main and also Drupal branch at the same time
Option 2: We merge this branch into a feature branch in hanna (I cannot do that, I think I don;'t have permisssion) and we use it in  the current feature branch we have in reykjavik repo whre we are using new hanna namespace. This way we will be able to test it properly and we could also deploy it into live and then merge hanna feature branch into main and finally swith Drupal to use the main branch.
Sorry if option 2 is not correcly explained , we can join if you need it but I think is the safer way to have this on live and having tests in the process.

@franseva1x I created feature/rename-twig-library-paths (see #41) and if you want you can run test against it.
Once tests pass, ping me over on #41 and then I'll merge that PR into main.
If you need to push some additional tweaks/changes to that branch, just update/edit this very PR (#39) to a stacked PR on top of feature/rename-twig-library-paths instead of main.


extract stage name of image in Dockerfile

docker FROM can have an optional image name, which can be specified using AS
eg: FROM ubuntu:latest AS builder

this can be added later if required.


Scope of generated code

The following options are laid out in regards to what can be pre-generated:

full contract, for example Uniswap
partial, for example a sequence of opcodes that does some math without state that can be replaced

The decision should be provided which of these do we target.

the first approach seems promising for now with the current iteration of the EVM (since code sections and function as native constructs dont exist it's super hard to gather metadata data about what's a hot path [maybe branches can be used as an alternative but I think it's not as straight forward]).
the second approach is ideal imo if EOF makes it to the EVM (which is either months from now or perhaps years)

or come to think of it we can analyze smart contracts to extract if there are long "pure" sequences of code that can be swapped with IL their IL counterpart or JITed

I think I'd go with a partial as it can be progressively extended into more complex scenarios. We could start with something as "no jumps, memory or storage" as a requirement and later build more and more. Effectively, partial could evolve into full contract later on. The next advantage of partial is making the #5 much easier. We can generate to do not step over the interaction with another one.

Partial
We're going initially with partial so that it's extended later on.


Fixes ENYO-1652

Adopt ilib components as submodules
Enyo-DCO-1.1-Signed-off-by: Ryan Duffy<EMAIL_ADDRESS>

Closed in favor of the rebased equivalent https://github.com/enyojs/onyx/pull/226


Add sanitizer to UT compilation

Originating Project/Creator

Affected Component

Affected Architectures(s)
fprime-util generate

Related Issue(s)
https://github.com/nasa/fprime/pull/1772

Has Unit Tests (y/n)

Builds Without Errors (y/n)

Unit Tests Pass (y/n)

Documentation Included (y/n)

Change Description
Following https://github.com/nasa/fprime/pull/1772, this adds the compiler sanitizers by default on --ut targets. An option is added (fprime-util generate --ut --disable-sanitizers) in order to disable the sanitizers if needed.
This enables the leak, memory and undefined behavior sanitizers at compilation by passing the associated flags down to CMake. Note that leak is not available on macOS, but this is handled by CMake down at the fprime level (cmake will refuse to activate LSAN on macOS).

Looks correct to me.  Do you have any test data?  Since it is CLI, I don't expect a UT. If not, I can try it myself.

I don't have test cases but I can add that in if necessary. Could be good since it depends on the underlying F' cmake flags not to change. I have tested manually and it's working as expected, I don't think there's any edge case.


⚠ Activitar Portal has degraded performance

In d062673, Activitar Portal (https://activitar.com) experienced degraded performance:

HTTP code: 200
Response time: 8299 ms

Resolved: Activitar Portal performance has improved in 7d5b1d8 after 5 minutes.


ARROW-7307: [CI][GLib] Ensure generating documentation

https://github.com/kou/arrow/runs/332621170
Green.
I'll merge this.


python3Packages.tuya-device-sharing-sdk: 0.2.0 -> 0.1.9

Description of changes
As discussed in https://github.com/NixOS/nixpkgs/issues/319067
TL;DR
Downgrade version from 0.2.0, which got released from a dev branch, to 0.1.9, that is actually required by it's only nixpkgs dependent; the Home Assistant "Tuya" component.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Since @aciceri mentioned that he is out-of-office, I would assign the PR to @mweinelt
I've run nix-shell -p nixpkgs-review --run "nixpkgs-review pr 319093" successfully, but it doesn't look like it's able to recognise that this library is used as a dependency in an official Home Assistant component. To me it seems that official Home Assistant components actually lack proper dependency handling compared to the custom Home Assistant components!?
I've also integrated my branch as nixpkgs-unstable into my flake. I'm not using the Tuya component, but everything builds as expected, there are no errors in Home Assistant and the integration also starts up without errors.

@mweinelt Can we merge this? I'd like to proceed with the other Tuya packages

Sorry, I merge the change in #319096, so I could test the impact while updating home-assistant.


IdeasNprojects

Hi wondered if you might think this would be a worthy project.
https://invensense.tdk.com/wp-content/uploads/2015/02/Microphone-Array-Beamforming.pdf
https://www.analog.com/media/en/technical-documentation/application-notes/AN-1328.pdf
The above are analogue application but was thinking digitally if we could split a stereo I2S stream take one channel delay invert and then down mix the x2 channel streams then if we get the delay equal to mic distance we have a digital equivalent?
Being a C noob I am still looking blankly at the ESP ADF wondering how to split steams, but thought I would mention it to someone who is vastly more knowledgeable like yourself :)

@StuartIanNaylor I don't really understand this either. Haha. I'm sorry I couldn't help you. I always answer the comments in my project video. If it's not a code problem, please ask your question below the related video. Thank you.


Don't log queries for exceptions

Remove the query from error logging when an exception occurs, as this could cause security issues.

Shouldn't this be configurable?

We want to make this the default. I agree it makes sense to have it be
configurable so it can be optionally turned on. We'll address that
separately.
On Fri, Aug 25, 2023 at 1:47 AM Paul Bakker @.***>
wrote:

Shouldn't this be configurable?
—
Reply to this email directly, view it on GitHub
https://github.com/Netflix/dgs-framework/pull/1610#issuecomment-1693004161,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ5JPXKZ73ZFS2753PLFKV3XXBRA3ANCNFSM6AAAAAA3574MYU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Closing because we have decided to keep the logging as is.


Added a German JavaScript course

Updated free-courses-de.md and added a German Javascript course.
What does this PR do?
Add resource
For resources
Description
JavaScript Course for Beginners in German
Why is this valuable (or not)?
It provides a good insight on JavaScript for beginners.
How do we know it's really free?
It says so on the website.
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


Revert mrpt msgs

…3409)"
This reverts commit 10fdb1688002d081266ccbd51ea6efde1eab7938.
For reasons I don't completely understand (and probably don't have time to debug), the mrpt_msgs package later that 0.2.0 seems to install a file in /opt/ros/melodic/.catkin, which conflicts with other packages.  This causes all downstream packages that depend on mrpt_msgs to break (you can see the error in https://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__mrpt_bridge__ubuntu_bionic_amd64__binary/71/console , for example).  Revert to the last known working version of mrpt_msgs.  @jlblancoc FYI.

Verified to be fixed by https://github.com/mrpt-ros-pkg/mrpt_msgs/commit/9457b9d3d0ae9f0860c42b0853a4cf2bc702888a


UI Issue: Move the Delete Icon and confirmation icon/undo elsewhere

Hi, I accidentally deleted a whole group because I accidentally pressed the delete icon.
Then, a "undo" icon appeared in the very same spot.
I clicked it, but it suddenly became another recycle bin. So I totally lost the group.
Closed and reopened Firefox, hoping it wouldn't autosave, but probably I messed it up even more.
I could barely see the rollback icon.

I second this, this button design is just plain evil. Relevant screenshots:

I never paid attention to it as I am too close to my extension. But yes it is very dangerous. Will be fixed asap.


GUI: Connection Probability

Working on the Network configuration export I noticed that the GUI is not using the connection probability in any way.

The connectivity only have a weight widget parameter.

The connectivity widget constructor is shown below. Notice the docstring mentions probability, but it is not in the box construct. It's a bit hard to read but the connectivity box is a vertical box (Vbox) composed of 3 elements:

HTML - Receptor label
w_text_input - Weight widget
HTML - Black horizontal bar
https://github.com/jonescompneurolab/hnn-core/blob/a1c94ee2f83e3b7a432fb03daa659f25a05da98a/hnn_core/gui/gui.py#L935-L951

The Problem
A problem arises when initializing the new network from widget values. It tries to assign a probability from a widget that does not exist (see below). The vbox_key.children[2].value, is not a probability widget but the html widget that styles the black horizontal bar. So the network actually gets assigned a probability value of "<hr style='margin-bottom:5px'/>"!
https://github.com/jonescompneurolab/hnn-core/blob/a1c94ee2f83e3b7a432fb03daa659f25a05da98a/hnn_core/gui/gui.py#L1650-L1653

Solution
I suppose the easiest solution is to just add the probability as a widget for all the connections. Does this make sense for all types of connections?

Is it an easy addition? The probability should default to 1.0 for all connections.
If it's straight forward to implement then I would say yes, it's a line of investigation that people haven't gone down because it wasn't possible in the old GUI

Whenever you call net.add_connection to add a drive or connect cell types, there's a probability argument that let's you randomly select some subset of all possible cell-cell connections. In that sense any entry in the net.connectivity list could have probability < 1.0, but by default it's always set to 1.0.
Where we need to be careful is that net.connectivity[conn_idx]['gid_pairs'] will change depending on the value of probability and conn_seed. Since the GUI builds each connection separately from the widget I don't think this will be a problem, since net.add_connection is still being used when you hit the run button and compile the Network object

https://github.com/jonescompneurolab/hnn-core/pull/843#issuecomment-2263262202


Transform some implicit any types into explicity

This allow projects that uses the noImplicitAny compiler option.
From the documentation:

noImplicitAny (boolean, default = false): Raise error on expressions and declarations with an implied any type.

@IniZio apparently the build error is about some missing coverage token, the tests are passing anyways, you can check the logs.
I also want to send another PR changing most of the types to generics, so each store can be related to the data it holds.


Tag not working when run maven command

When i run below maven command :
mvn test -Dcucumber.filter.tag="@Login"
Then it should only run Login Feature but currently its running all feature.
Test Runner
@RunWith(Cucumber.class)
@CucumberOptions(
features = {"src/test/resources/parallel"},
glue = {"StepDefinationFiles", "AppHooks"},
plugin = {"pretty",
"com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:",
"timeline:test-output-thread/"}
//tags = "@LinkTest"
)
Feature file :
Feature: Login Page
Background:
Given user open browser and navigate site

@LinkTest
Scenario: Login Page all link check
Given user on login page
Then user validate privacy policy link
Then user validate is forgot password present
And close browser
Feature file :
Feature: MyLogin
@Login
Scenario: MyLogin
Given user launch browser
When user open mysite
Then user send id and pass
Then user click on login button
Then close browser
I'm running from cmd maven command
Its working fine when i'm run from test runner

You might need to add the following in your surefire config;

As described here
https://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html
As cucumber will only see system properties that surefire/failsafe expose
to them or forward to them.
If you think about it like this;
Maven -> Surefire -> JUnit -> Cucumber
Maven is not directly talking with Cucumber, but via two frameworks used
for testing. Check your using the latest versions of everything as well to
rule out old properties with new framework, or old framework with new
properties.
John
On Mon, 8 Mar 2021 at 08:45, pradipyogipacific<EMAIL_ADDRESS>wrote:

When i run below maven command :
mvn test -Dcucumber.filter.tag="@Login"
Then it should only run Login Feature but currently its running all
feature.
Test Runner
@RunWith https://github.com/RunWith(Cucumber.class)
@CucumberOptions(
features = {"src/test/resources/parallel"},
glue = {"StepDefinationFiles", "AppHooks"},
plugin = {"pretty",
"com.aventstack.extentreports.cucumber.adapter.ExtentCucumberAdapter:",
"timeline:test-output-thread/"}
//tags = "@linktest https://github.com/linktest"
)
Feature file :
Feature: Login Page
Background:
Given user open browser and navigate site
@linktest https://github.com/linktest
Scenario: Login Page all link check
Given user on login page
Then user validate privacy policy link
Then user validate is forgot password present
And close browser
Feature file :
Feature: MyLogin
@Login
Scenario: MyLogin
Given user launch browser
When user open mysite
Then user send id and pass
Then user click on login button
Then close browser
I'm running from cmd maven command
Its working fine when i'm run from test runner
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cucumber/cucumber/issues/1410, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABCXYG6BQCSGCDB5RNDMT3TCSFDZANCNFSM4YY7H2PA
.

The property is named cucumber.filter.tags. Note the additional s.

Can you help ho to do in pom.xml

org.apache.maven.plugins
maven-surefire-plugin
${maven.surefire.version}

**/MyTestRunner.java-->

methods
4
false

Is it right way :

org.apache.maven.plugins
maven-surefire-plugin
${maven.surefire.version}

propertyValue
${project.build.directory}

**/MyTestRunner.java-->

methods
4
false

@pradipyogipacific I’m facing similar issue could you please let me know how you fixed it ?


When I click on one button and then click on another button the second button won't do anything

To Reproduce
Steps to reproduce the behavior:

When I click for example on the audio module and then click on the wifi module next, the audio module will close but the wifi module won't open, no matter how many times I will click on it. After I click somewhere on the screen, this behavior "resets" and I clicking on any module will open it again
Expected behavior
When I click on one module, it should open that module.
When I click on another module next, the previously opened module should close and the new module should open
Desktop (please complete the following information):
This behavior was observed on NixOS with hyprland

Can replicate this. However, I believe it's caused by #91, which is unfortunately an AGS/Astal + Hyprland bug.
Nothing to do with Hyprpanel specifically, as this is also a problem with any AGS implementation on Hyprland specifically (NOT all wayland compositors). I really think this needs to be fixed though as it's quite annoying.
@Jas-SinghFSU Is this something we cry to Aylur about or Vaxry about? I'm honestly not sure where to start with making a bug report there, or gathering relevant error logs etc.


Debug mode jumplist has to account for dynamic showifs

Currently, a dynamic showif method on a page may cause a crash of the debug mode, because all showifs get evaluated for the creation of the jumplist.

 The error will appear every time that a JumpList is used together with pages with a dynamic showif (i.e. the showif method tries to access a value that is not present at the time of the JumpList being activated on a page). Should be actually easy to solve with the dict.get method and, if necessary, try-except blocks.
But we may also want to put some more thought into how dynamic showifs should be handled by a JumpList.


Add/selenium support

FIX ISSUE - #171
The new function introduced in this update dynamically selects and executes the appropriate function depending on the backend used. This functionality allows the application to be more flexible and easily extensible, making it capable of adapting to different backends without requiring significant changes to the codebase.
How It Works:
The function checks the specified backend type (e.g., selenium, other_backend).
If the backend is identified as Selenium, the function triggers the Selenium-specific function to execute the necessary tasks associated with the Selenium backend.
If the backend is not Selenium (i.e., it’s another type of backend), the function defaults to executing an alternative backend-specific function.
Benefits:
Flexibility: Easily extendable to support more backends in the future without changing the core logic.
Scalability: Supports multiple backend integrations, making the application more adaptable.
Decoupling: The backend logic is isolated, which simplifies testing and debugging by ensuring that backend-specific code only runs when needed

Hi @SwapnilSonker could you please add on example in the folder examples/extras?


ES6 target / ESM distribution

Hi, would it be possible to release a version of the library compiled to ES6, so using and exporting native modules?
Recent versions of Angular complain about non-ESM dependencies (i.e. AMD or CommonJS).

Yeah I know I can use the library in an Angular project and safely ignore that warning, but since our customer will also see the warning, they may, in turn, complain ;)
What people usually do in such cases in the Java world is to generate multiple artifacts from the same project, such as, foo-with-bar-v1.0.0.jar, foo-no-bar-v1.0.0.jar. I don't know the convention in JS/TS and I have no idea how hard npmjs makes this (i.e. to publish multiple variants of the same package).

I recall actually trying to add that ESM compliance, for another project, got stuck, even asked on StackOverflow about it (will link the question, if I find it), and there was something about Angular not a real ESM-compliance or something, I do not quite remember right now.
I will have another look at it later on. But if you want to try it yourself in the meantime, you're most welcome!

@alessiostalla I wrote wrong before, the library's distribution comes with ES2015, which is equivalent for ES6.

Oh, nice. I'll do more tests on my part, maybe I've misreported this.

@alessiostalla I wrote wrong before, the library's distribution comes with ES2015, which is ES6 equivalent.

This project is really cool but the lack of esm module version makes it hard to consider as a valid alternative to rxjs in a client-side project because it is not tree-shakable.
Tree-shaking, aka the removal of unused code, is not possible for the following reasons:

This project does not expose an esm module version
This project that does not have side-effects: false in package.json

Please refer to the webpack docs for more details: https://webpack.js.org/guides/tree-shaking/#conclusion
I could submit a PR, If you want help with this issue.

I could submit a PR, If you want help with this issue.

Would love one, thank you!!!

Thanks to @RebeccaStevens, this issue has been pretty much resolved, pending some extra documentation + tests on my end.

The sideEffects field in package json hasn't been set to false yet.

sideEffects added
circular dependencies resolved

Looks almost ready :)

sideEffects added

circular dependencies resolved

Looks almost ready :)

Adding the "exports" in package.json is a breaking change!
You should bump version to 2.x.x before releasing a new version.
Node std warning
Warning: Introducing the "exports" field prevents consumers of a package from using any entry points that are not defined, including the package.json (e.g. require('your-package/package.json'). This will likely be a breaking change.

source: https://nodejs.org/api/packages.html#package-entry-points
See also

https://nodejs.org/api/packages.html#determining-module-system
https://github.com/then/is-promise/issues/19

@FaberVitale Fair enough, this is something to consider before going with the official release :)
In the meantime, I've just wrapped this all up and published a 1.5.0-beta.0
npm i<EMAIL_ADDRESS>
or perhaps just:
npm i iter-ops@beta

Please give it a test, and let me know ;) My own tests with Angular were all pass ;)

bundlephobia

link<EMAIL_ADDRESS>

Looks like we did do something awesome 😸

And if we go for broke, and include absolutely everything, it is still a very manageable 4kb 😄

Warning: Introducing the "exports" field prevents consumers of a package from using any entry points that are not defined, including the package.json (e.g. require('your-package/package.json'). This will likely be a breaking change.

I wouldn't be paying much attention to this. After all, this whole package is still very new anyhow. I think we will be fine going with 1.5.0 when it is finalized.

Version 1.5.0 has been released. This issue is no more.

Just so, 1.5.0 missed some declarations .d.ts that were patched in v1.5.1
@FaberVitale Were you ok using it?


UnicodeEncodeError: 'charmap' codec can't encode characters in position 110-115: character maps to

Hello, I'm getting this error.
PS C:\Users\win>  signal2html -i C:\Users\win\Desktop\Backups\Signal\RAWBAK -o C:\Users\win\Desktop\Backups\Signal\signal_html
c:\users\win\appdata\local\programs\python\python38-32\lib\site-packages\signal2html\core.py:42: UserWarning: Warning: Found untested Signal database version: 20.
  warnings.warn(
Traceback (most recent call last):
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\win\AppData\Local\Programs\Python\Python38-32\Scripts\signal2html.exe\__main__.py", line 7, in <module>
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\site-packages\signal2html\__main__.py", line 8, in main
    sys.exit(realmain())
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\site-packages\signal2html\ui.py", line 33, in main
    process_backup(args.input_dir, args.output_dir)
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\site-packages\signal2html\core.py", line 213, in process_backup
    dump_thread(t, output_dir)
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\site-packages\signal2html\html.py", line 186, in dump_thread
    fp.write(html)
  File "c:\users\win\appdata\local\programs\python\python38-32\lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 110-115: character maps to <undefined>

Running on Windows 10. Thank you for taking the time here, looks quite nice.

Hi @deadcombo, thanks for letting me know about this. I've never tested the program on a Windows machine so it's quite possible that's a factor. I've just pushed a potential fix to the bugfix/encoding branch. If you know how to install a package from GitHub it would be great if you can try it out to see if that solves the problem.

Thanks for letting me know that the first problem was solved, I'll update the package when we have this one sorted out too. Just to clarify what's going on here, could it be the case that this message quotes someone who is not in your contacts or in your signal threads?
I've created a new branch bugfix/quote_author with an attempt to solve this problem. I can't easily test it here, so hopefully you can check if this works.

 Just to clarify what's going on here, could it be the case that this message quotes someone who is not in your contacts or in your signal threads?
Well, that was a text from myself, so it's probably something like that. I can't check because signal2html hasn't gotten to it yet, have a new bug:
signal2html.exe -i "C:\Users\win\Desktop\Backups\Signal\RAWBAK" -o "C:\Users\win\Desktop\Backups\Signal\signal_html"
C:\Users\win\AppData\Local\Programs\Python\Python38-32\lib\site-packages\signal2html-0.1.0-py3.8.egg\signal2html\core.py:42: UserWarning: Warning: Found untested Signal database version: 20.
Traceback (most recent call last):
  File "C:\Users\win\AppData\Local\Programs\Python\Python38-32\Scripts\signal2html-script.py", line 11, in <module>
    load_entry_point('signal2html==0.1.0', 'console_scripts', 'signal2html')()
  File "C:\Users\win\AppData\Local\Programs\Python\Python38-32\lib\site-packages\signal2html-0.1.0-py3.8.egg\signal2html\__main__.py", line 8, in main
  File "C:\Users\win\AppData\Local\Programs\Python\Python38-32\lib\site-packages\signal2html-0.1.0-py3.8.egg\signal2html\ui.py", line 33, in main
  File "C:\Users\win\AppData\Local\Programs\Python\Python38-32\lib\site-packages\signal2html-0.1.0-py3.8.egg\signal2html\core.py", line 204, in process_backup
sqlite3.OperationalError: no such table: thread

I'm able to replicate it in WSL.
Thanks for the support.

Huh, that's strange, that line (204) is called before the previous error with the quoted message. So it worked before but now doesn't anymore. Is the database file corrupt perhaps? You can try opening the .sqlite file in a program such as sqlitebrowser or dbeaver to check if it has a thread table.

Hmm, I just extracted the backup again and it works again. I think it got to all my messages, at least the ones I cared.
However, I've no attachments in the threads:
 C:\Users\win\AppData\Local\Programs\Python\Python38-32\lib\site-packages\signal2html-0.1.0-py3.8.egg\signal2html\core.py:107: UserWarning: Warning: couldn't find attachment C:\Users\win\Desktop\Backups\Signal\RAWBAK\Attachment_239_1548886157063.bin!
Sure enough, attachment 239 is missing. (Maybe it's something I deleted?)
Anyway, no attachments load at all.

Glad it works again. Yes, with missing attachments a warning will be generated and this generally corresponds to deleted attachments.
I'm not quite sure why the attachments don't load though. It might have to do with the way local files are loaded. Currently the path to the attachments is simply embedded in the HTML. What you could try is to edit the generated HTML file and add the text file:// before the attachment path (so it would read file://C:/Users/win/Desktop/Backups/Signal/RAWBAK/Attachment_.... (note the change from \ to / as well). If that solves it I could implement that change in the package.

Closing due to inactivity, please reopen the issue if the problem persists.

Closing due to inactivity, please reopen the issue if the problem persists.


Minion-ChloeC

Minion-Chloe Chen. My artwork attempted to replicate a minion from Despicable Me. It required lots of experimentation with the placement of each of the hands/glasses/clothes. I used a for loop to play around with extra add ons such as a hat and a flower. I have little experience with javascript and I had lots of fun playing around with it.

This is a very intricate piece! Could you parameterize it in some ways? Make it so you can adjust the minion using variables.

I uploaded an updated version of my index.js with adjustable variables. Thank you for your time!

Thanks for updating your piece. Try to use the setDocDimensions and center your drawing in there. Right now I can't find it.
 Make sure you don't use spaces in the names and delete the old submission folder.
Keep at it!

Hey @celloii, any updates on mixing up the art a little bit more?

Seeing as this hasn't been updated in ~3 weeks, I will be closing this PR for now. Feel free to make a new PR with an updated submission in the future!


how can use the gv for training and synthesizing

Hey,Guys:
how can use the gv model for training ang synthesizing speech

GV scripts are not yet complete.
GV stats are calculated using a matlab script and stored in data folder (data/GV)-- which has to be re-written in python (will be uploaded some time soon).
GV testing -- can be applied by setting variable 'apply_GV' to True.


Hitting return to enter answers

Especially on the book pages with lots of answers it would be nice to be able to hit enter to check an answer and move to the next answer box in that accordion section

I like this idea, but I don't know how we deal with the units box?

Tab is a reasonable option to get to the units box.

I think if we built such functionality, it should do the following:

If there is a units box, pressing enter in the number box should open the units dropdown and highlight the top unit. Pressing enter on that unit should select it, and move the focus to the "Check Answer" button, so that a final enter checks the answer. This may be too hard.
If there are no units required, then enter should just submit the answer; this should be easy and make life slightly quicker on some questions.


Fix to support having an unselected value in a SelectList dropdown

Right now, when you provide a list of options to a SelectList (or any parent like TapToEdit), it defaults to the first option versus allowing it to not be a selected value.
If you don't want to support having an unselected value, you should provide an initial value so it doesn't use the placeholder.

It shouldn't! I did some testing and defaults all work since we now handle value/onChange outside the scope of the ferns component.
https://user-images.githubusercontent.com/6036168/218879361-4fb94e91-241c-40a5-846b-47a251f63f65.mov

It shouldn't! I did some testing and defaults all work since we now handle value/onChange outside the scope of the ferns component.
https://user-images.githubusercontent.com/6036168/218879584-3bf6a2ea-c682-4c9a-805c-633ee46c5625.mov


Adding info #5247

Adding information for issue #5247
Copy review @nenonix @JohanFreelancer9 is required on this one guys. Thank you in advance!

@Dansimp - PR has been copy edited and is ready for final review based on issue #5247.
Thank you.

#sign-off

@j0rt3g4 -  - please merge the commit on the copy/edit review done by JohanFreelancer9 or make the necessary changes on the PR following the suggestions made. Thank you.

@mypil Done

#sign-off


Request: Additional Expansion Style

I would love for there to be another expansion style. Similar to the Destructive style where the entire cell expands, but without the destructive properties. It would be useful for single, left side actions to transition to a new view controller or detail view.
Please let me know if this is possible with the existing expansion styles and I am missing something.
Thanks
Andrew

Hey @Awalz - This could probably be handled by a new flag inSwipeAction that disables SwipeCellKit from performing the table view row delete. Though, I'm not sure what would happen in the space where the cell used to be if its no longer gets deleted. For example, if this new VC/detail view doesn't cover the whole screen, etc.
Can you point me to any apps with a similar UX pattern so I can see an example?

Hi @jerkoch, I have a client that wants to be able to swipe from the left and instead of tapping on the action, keep swiping and have the action triggered; this isn't a cell delete, just perform the action like your read/unread, but allow swiping all the way. MGSwipeTableCell has some called MGSwipeExpansionSettings which lets you specify that if the swipe has reached a certain amount of the way, expand all the way and take that action.
While this may not be a standard UX pattern, I have a client that wants it.
If you could consider it, I'd appreciate it.

Would definitely be interested by this feature. A nice example for this would be in a task app, to complete a item just swipe left to right, for customisation swift right to left.

@sgruby @Alex293 I hear you  👍
I've been thinking about how to best make this happen. I've got an idea that I'll play around with tomorrow. Stay tuned!

Can you point me to any apps with a similar UX pattern so I can see an example?

Tweetbot is a good example.

@Awalz @sgruby @Alex293
I added a .fill style expansion to the API.  Please see the discussion in #20 for more details.  If you choose to use the .fill style, it uses manual fulfillment, which means you need to call action.fulfill(style:) from inside your action handler. You can specify the fulfillment style as etiher .delete or .reset depending on the result of your modal user interaction.
Please take a look at the expansion branch and let me know what you think!


Fix pudl ids

I fixed the following plants with strange or miss-matched pudl ids:

Nine Mile Point row from Entergy LA (pudl id 456) confused with Nine Mile Point Nuclear Station from Niagra Mohawk Power Corp. (pudl id 2133).
Beebee Station row from RG&E NY (pudl id 41) confused with Beebee Island Hydro Plant from Niagra Mohawk Power Corp. (pudl id 11960).
Spokane NE row from Avista (pudl id 12240) confused with Spokane Waste To Energy from the city of Spokane (pudl id 554).
Putnam row from FPL (plant id 1220) confused with Putnam from DTE (plant id 476).
Okeechobee Clean Energy Center row from FPL (pudl id 10649) -- actually a gas plant -- confused with the Okeechobe Solar also from FPL (pudl id 13441). Might be co-located.
River Valley row from Oklahoma G&E (pudl id 14386) confused with River Valley Solar from Neighborhood Power Corp. (pudl id 15143).
Hamilton Moses row from Entergy Arkensaws, Inc. (pudl id 246) had two rows.

Hey @aesharpe were the tests passing on your machine locally? It looks like something weird happened with the output column names or something maybe based on the errors? Not sure.

Hey! I noticed that too but I couldn't figure out what was wrong from the
error message. Said the ci tests weren't passing, but when you scroll up
they look like they are fine. Gonna poke at it this am, but if you have any
suggestions lmk!
On Tue, May 18, 2021 at 7:50 AM Zane Selvans @.***>
wrote:

Hey @aesharpe https://github.com/aesharpe were the tests passing on
your machine locally? It looks like something weird happened with the
output column names or something maybe based on the errors? Not sure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/catalyst-cooperative/pudl/pull/1003#issuecomment-843188987,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL4RJM2DBPCYGWMWPC4D2D3TOJWAVANCNFSM45BHKEWA
.

--
Austen Sharpe
B.A. Environmental Studies from Brown University
e: @.*** | @.***
c:<PHONE_NUMBER>
p: she/her/hers

It looks like it gets through the unit tests okay, but then fails pretty quickly when it gets to the integration tests (where it's trying to actually run the ETL).  I don't think I'm familiar enough with the mapping spreadsheet to help debug this.  Probably a @cmgosnell question.  One thing I see though is that in some cases both of the IDs involved in the confusion are big numbers (like > 10,000) which I think means they were both being automatically assigned, and I'm not sure that trying to consolidate two automatically assigned IDs into a single ID which was previously automatically assigned is something that the system can handle.

I was asking about the changes to the larger IDs because I was afraid that it might mess up future automatic ID generation (where it takes the max of all IDs above and increments). But again, I don't really know how this works well. If @cmgosnell says it's fine, then it's fine.


[QUESTION] Release Synchronization with AspNetCore ?

Hello @vicancy ,
I know this kind of question is usually hard to answer.
We plan to move from aspnetcore2.2 to aspnetcore3.0 + azure signalr at the same time.
We are currently wondering if the release of the azure-signalr v1.1.x (or maybe v3.x) will be aligned with the release date for both netcoreapp3.0 / aspnetcore3.0, for september 2019

Yes we are. cc @JialinXin

oupsi, i forgot to close that one i guess


[1.0.2][backport] Fix --strict-warnings for arm

Backport of #6026 and #6028 to 1.0.2.
I am testing the 1.0.2 branch on aarch64 and noticed that I cannot turn on --strict-warnings without these 2 patches.
Cherry-picking #6028 required manual intervention, while #6026 was trivial.
Ping @bernd-edlinger as he is the original author.

I don't see this qualifying...

The changes look okay but we'd need to vote on an exception.
I don't like the chances.

Personally, the reason why I would like this accepted is that our team uses automated testing  for both code quality and security issues, for all active branches.
Given that different architectures and different compilation options result in different code paths, we have "runners" on different platforms, including arm7 and arm64/aarch64.
By default we compile with --strict-warnings for each selected set of compilation options to ensure that novel contributions met the code quality standard, before opening PRs, across all the platforms we test.
Of course we could disable --strict-warnings on the platforms that the project is currently not covering with the automated testing that is setup here in Github, but that would not make much sense if we also aim to complement the platforms on which the CI tests are run.

If this helps us test security and hardening fixes on the 1.0.2 branch then I'm ok with it.

If this helps us test security and hardening fixes on the 1.0.2 branch then I'm ok with it.

I would say that ultimately that's what most of our research is about :)

The changes look okay but we'd need to vote on an exception.

Do we actually need a vote on this? What exactly is counted as a "security fix" has been open to interpretation and individual OMC members discretion previously. I guess if there is disagreement then a vote would be required, but if we have consensus then I don't see a need.

Do we actually need a vote on this? What exactly is counted as a "security fix" has been open to interpretation and individual OMC members discretion previously. I guess if there is disagreement then a vote would be required, but if we have consensus then I don't see a need.

I guess @levitte was not in favor of making an exception, @paulidale seemed neutral and @mattcaswell in favor.
Unless they change their mind (or I am misinterpreting) probably a vote will be needed. How should we proceed about it?

@levitte - what is your opinion? Will you -1 this? I think a vote is only needed if an OMC member -1's this - so I suggest leaving it for another day or so. If no -1's materialise then I will approve and push this through.

ping

I just want to make sure this is indeed ready: @levitte did you want to -1 this or should I proceed merging?

Ping @levitte

I'm standing down on this one.
The reason for my earlier comment is that it seems like we were going for a fairly strict definition of what constitutes an acceptable change of the 1.0.2 branch at the time...  collectively, it seems like our minds are swaying on this subject.

Ok, thanks @levitte for explaining.
I will consider this ready and proceed to merge!

(it will take some time as I am going to retest this after rebase on arm and arm64 as well)

(looks like I will have to wait until next week, as I am out of office and the flash memory of my arm64 testbench died on me while testing!)

It took way longer than expected, but I can finally confirm this effectively fixes the --strict-warning issues both on 32-bit and 64-bit ARM.
I will now proceed to merge, as this is ready.
On a side note, on a separate branch I rebased this PR on the latests 102-stable and also applied a commit to add armhf and aarch64 cross-compilation to Travis-CI for further validation (I went through this exercise as I noticed we currently have introduced issues with --strict-warnings and ARM even on other branches).
Here are the results of the pipeline including this PR: https://travis-ci.org/romen/openssl/builds/544205329
In comparison running the same pipeline on latest 102-master: https://travis-ci.org/romen/openssl/builds/544204047
Is adding these 2 targets to the Travis matrix something we wish to do across the active branches?

Merged with

3750879c117fddf583ef5d46069bac2b4d6523b8
7a7afc559ebc0ad88390cc62bfc34c221d595831


fixed readme

readme contained incorrect namespace/package name/target folder for python sdk

/azp run automation - sdk

Can one of the admins verify this patch?


Flash calculations: Differences in entropy

In the following example I'm using two different flash calculation to get the entropy.
The first one is a T,P-flash:
S1 = flasher.flash(T=T, P=P).S()

The second one is a T,V-flash:
S2 = flash.flash(T=T, V=V).S()

I do not understand why S1 and S2 are not always equal.
There are always differences in the liquid phase right below  the saturation temperature.
This is the output of the example code below showing the differences in entropy dS = S1 - S1 at certain temperatures T.
Just as the differences in enthaply dH.
Tc:    305.3 K
Tsat:  220.4 K
Tm:     90.3 K
--------------------------------------
     T       dS       dH
--------------------------------------
   100      0.0      0.0   L  L
   110      0.0      0.0   L  L
   120      0.0      0.0   L  L
   130      0.0      0.0   L  L
   140      0.0     -0.0   L  L
   150    -29.3  -6760.7   L  L
   160    -27.3  -6444.0   L  L
   170    -25.4  -6127.9   L  L
   180    -23.5  -5809.9   L  L
   190    -21.8  -5487.5   L  L
   200    -20.1  -5158.0   L  L
   210    -18.4  -4819.5   L  L
   220    -16.8  -4471.0   L  L
   230      0.0     -0.0   V  V
   240      0.0      0.0   V  V
   250      0.0      0.0   V  V
   260      0.0      0.0   V  V
   270      0.0      0.0   V  V
   280      0.0     -0.0   V  V
   290      0.0      0.0   V  V

This is the example code:
import thermo

constants, properties = thermo.ChemicalConstantsPackage.from_IDs(['ethane'])
CAS = constants.CASs[0]

eos_kwargs = dict(
    Tcs = constants.Tcs,
    Pcs = constants.Pcs,
    omegas = constants.omegas)

liquid = thermo.CEOSLiquid(
    thermo.PRMIX,
    eos_kwargs=eos_kwargs,
    HeatCapacityGases = [thermo.HeatCapacityLiquid(CAS)])

gas = thermo.CEOSGas(
    thermo.PRMIX,
    eos_kwargs=eos_kwargs,
    HeatCapacityGases = [thermo.HeatCapacityGas(CAS)])

flasher = thermo.FlashPureVLS(
    constants, properties,
    gas=gas, liquids=[liquid], solids=[])

P = 5e5
Tc = constants.Tcs[0]
Tsat = flasher.flash(P=P, VF=0).T
Tm = constants.Tms[0]

print(f'Tc:   {Tc:6.1f} K')
print(f'Tsat: {Tsat:6.1f} K')
print(f'Tm:   {Tm:6.1f} K')

print('--------------------------------------')
print('     T       dS       dH')
print('--------------------------------------')
for T in range(100, 300, 10):
    res1 = flasher.flash(T=T, P=P)
    S1 = res1.S()
    H1 = res1.H()
    V = res1.V()

    res2 = flasher.flash(T=T, V=V)
    S2 = res2.S()
    H2 = res2.H()

    dS = S1 - S2
    dH = H1 - H2

    print(f'{T:6.0f} {dS:8.1f} {dH:8.1f}   {res1.phase}  {res2.phase}')

Hi Andreas,
The error in your code is to provide the CEOSLiquid a HeatCapacityLiquid object instead of the HeatCapacityGas object. The EOS already predicts the difference between the idea-gas and liquid state. Providing the HeatCapacityLiquid object results in a thermodynamic inconsistency.
Sincerely,
Caleb

Thanks Caleb! I see it's working now. But I'm afraid I do not understand why.
Could you please provide some more insight into the difference between HeatCapacityLiquid and HeatCapacityGas?
I chose HeatCapacityLiquid on purpose, because I thought it should match to the liquid state.

No, it shouldn't take the HeatCapacityLiquid; that's why the argument name is HeatCapacityGases. Cubic EOSs are real fluid models. They are implemented starting with an idea-gas reference state; and then to obtain the properties of the liquid phase, those are calculated using the ideal-gas heat capacity and the departure functions of the cubic EOS. The Peng-robinson equation of state predicts things like the heat of vaporization and vapor pressure directly, mathematically, as the result of the solution of a set of equations. A real fluid's heat capacity comes in two parts - the ideal-gas part, and the departure from ideal gas part. The fact the Peng-Robinson equation of state can have a liquid root doesn't change the fact the heat capacity comes from those two parts. The equation for departure from ideal gas part is the same whether a liquid or gas is present.

Thank you for the clarification. Much appreciated.


What can we use in replacement of amr claim ?

V1.0 tokens have the 'amr' claim which one can use to authorize requests based on the strength of the authentication; this claim has been removed in V2.0; Anyone here came across similar issue ? How would you perform this using V2.0 tokens ?
Cheers,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0cace34-34bf-32f7-c857-e4d71d535a77
Version Independent ID: cdbbc4ae-5894-da21-42d7-928b3674bbd1
Content: Microsoft identity platform ID token reference
Content Source: articles/active-directory/develop/id-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @rwike77
Microsoft Alias: ryanwi

Closing this issue for now

Any updates on this?


Start triggered webjob from the webjobs dashboard

The webjobs dashboard (/azurejobs/#/jobs) gives an overview of all webjobs.
However, to start a particular job, you need to go to the Azure portal.
It would be useful to have a start button there - and perhaps a stop button too.

Hi
If the problem persists and is related to running it on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


Nagios: Enhancement: Document Process For Adding Windows Hosts To A Nagios Server

Part Of Epic #2445
Please investigate the process, tasks and steps involved in adding Nagios monitoring checks to a windows host.
Please create a new document in the /ansible/playbooks/nagios folder called something like How_To_Add_Nagios_To_Windows.MD , with detailed steps about the tasks etc on both the Nagios Server & the Windows Host, so that we can try this in production at a later date. I'd recommend using nagios etc to create a nagios server, and a windows VM, so that you have an isolated development environment.

hi @steelhead31 i would want to take this up


Disable at_hash verification

This should resolve #53. We should think about actually verifying
the access token itself though.

@tokusumi any chance of getting this reviewed and published?

@tokusumi we're currently bundling a locally-built version of fastapi-cloudauth with our application because we need this. We would prefer if we could depend on a released version. LMK if you'd like any improvements/changes.

Appreciate @sindrig !
(Sorry for late response)
I confirmed it raise error (due to having at_hash) for AWS cognito ID token acquired from hosted UI, and your proposals resolve them.
Thanks 👍


no readme's

(AUTH-4111)
Samples contains no readme's

+1
Some instructions would be nice.  There are some tasks that you are supposed to just know to do:

set the client_id
set the domain
correctly setting up the callback url in the management console (it has a very specific format)

@dagostinelli This sample code is supplementary to the Xamarin Quickstart. Please refer to that for a step-by-step guide on how to implement:
https://auth0.com/docs/quickstart/native/xamarin


nimble/ble_store: Fix assert when BLE_HS_DEBUG is enabled

This patch fixes folliwing assert:
BLE_HS_DBG_ASSERT(!ble_hs_locked_by_cur_task())
0  ble_hs_lock () at repos/apache-mynewt-nimble/nimble/host/src/ble_hs.c:193
1  0x00035724 in ble_store_write (obj_type=obj_type@entry=3, val=val@entry=0x20003950 <g_os_main_stack+1768>) at repos/apache-mynewt-nimble/nimble/host/src/ble_store.c:54
2  0x000358a8 in ble_store_write_cccd (value=value@entry=0x20003950 <g_os_main_stack+1768>) at repos/apache-mynewt-nimble/nimble/host/src/ble_store.c:273
3  0x0002cee2 in ble_gatts_bonding_established (conn_handle=conn_handle@entry=1) at repos/apache-mynewt-nimble/nimble/host/src/ble_gatts.c:1692
4  0x00028e66 in ble_gap_enc_event (conn_handle=conn_handle@entry=1, status=0, security_restored=0) at repos/apache-mynewt-nimble/nimble/host/src/ble_gap.c:5299
5  0x00034036 in ble_sm_process_result (conn_handle=conn_handle@entry=1, res=res@entry=0x200039e0 <g_os_main_stack+1912>) at repos/apache-mynewt-nimble/nimble/host/src/ble_sm.c:925
6  0x000341d0 in ble_sm_rx (chan=0x20005e14 <ble_l2cap_chan_mem+56>) at repos/apache-mynewt-nimble/nimble/host/src/ble_sm.c:2610
7  0x00030a90 in ble_hs_hci_evt_acl_process (om=0x0, om@entry=0x20003dec <os_msys_1_data+876>) at repos/apache-mynewt-nimble/nimble/host/src/ble_hs_hci_evt.c:1040
8  0x0002d76e in ble_hs_process_rx_data_queue () at repos/apache-mynewt-nimble/nimble/host/src/ble_hs.c:228
9  0x0002d786 in ble_hs_event_rx_data (ev=) at repos/apache-mynewt-nimble/nimble/host/src/ble_hs.c:547
10 0x00012326 in os_eventq_run (evq=) at repos/apache-mynewt-core/kernel/os/src/os_eventq.c:196
11 0x0000da82 in main (argc=, argv=) at repos/apache-mynewt-nimble/apps/leaudio/src/main.c:2464
It happens when bonding is happening after peer registered for
notifications

This looks safe to me (i.e., I think this function can only get called from the host task, so there is no chance for the connection to be deleted while the mutex is unlocked).
But I wonder why ble_store_write() needs to lock the mutex.  I don't see any obvious reason.  Do you?  Maybe there was some fear that reads and writes would be happening simultaneously?  If so, it seems like a separate mutex should be used.

@ccollins476ad Thanks for looking into this.
I was also wondering why ble_store_write() needs to be locked and I see that it was added when store overflow was added. Frankly speaking I was hoping you know :)
btw - this is one issue, second one would be in case of overflow as then status callback assumes to be called outside the ble_hs_lock().

ah wait, you where asking about ble_store_write and not ble_hs_cfg.store_write_cb. So lock for callback has been added on store overflow work.
Reason why ble_store_write is in the ble_hs_lock is probably because it is in the loop when we iterate gatt_srv = &conn->bhc_gatt_svr;

any update on this? thanks!

@rymanluk @sjanc I have a question here: Why is ble_hs_lock_nested() not used in ble_store_write_cccd instead? Are nested locks not supported for all the ports? Or is there any other reason to it?


GitHub Actions

Add GitHub Actions workflows

build ... Execute unit test and e2e test.
release ... Build a container image and upload asset to GitHub Release.

Refactor Makefile

Add some make targets.
Separate a makefile for csi-sidecars.
Get version variable value when building.

When would you delete .circleci/config.yaml?
I worry about the release conflicting.

Looks good to me other than ikezoe-san's comments above.

When would you delete .circleci/config.yaml?
I worry about the release conflicting.

I can remove circleci config in this PR, but the change will be huge.
So, after this PR is merged, I am going to make new PR just for removing the circleci config.

Currently we are deciding whether or not to run a test depending on CIRCLECI environment variables.
https://github.com/cybozu-go/topolvm/blob/9d5902a2d133b6775bde8db3ed1130c178a31f39/lvmd/lvservice_test.go#L20
https://github.com/cybozu-go/topolvm/blob/c0c629cf4faf854bdceeef6371854c2b8346b0ba/filesystem/interface_test.go#L46
Do you need to change this for GitHub Actions?

All the workflows run on a virtual machine, so I think the current code runs tests as we intended.
circleci := os.Getenv("CIRCLECI") == "true"  will be deleted at the same time I purge the circleci config.


[ENHANCEMENT] Sub Category Translation Warning Message

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
In version 4.0, when working with Translations for Playlists, there is a warning that indicates the Custom Sub-Category doesn't have a translation. The wording could suggest that the functionality is not available rather than that the Admin/Translators need to take action.

This is visible when selecting a Playlist and then Edit Detail.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I am proposing the phrasing be changed to make it more apparent that action is required.
"You must create a Some Language Translation for the selected Sub-Category."
Possibly including a link to the documentation steps: https://docs.microsoft.com/en-us/office365/customlearning/custom_translate_pl_ml
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@newgardj we changed this message in the V5 release.

This has been resolved in the V5 release


v2.3.0-beta.8

sync master & dev branch on test for browsers

cool thanks let's test it also in riot

congrats @aMarCruz all the tests were passed!


Scaling

this is a rough draft of the splitting mps into two components.. One that handles web requests and one that handles cira connections. The main changes are there is a proxy connection in between the two mps halves now, consul is being used to record which mps server has the cira connection, and redis is being used as a web session cache. We are still working through some issues but please take a look if you have time.. thanks!

@brianosburn-intel is this PR ready for review yet?


Link C++ project against curl and a JSON library

The CMake system should be set up to use automatically installed versions of curl and a JSON interpreter.

The JSON portion of this ticket has been moved to #6