Fix the multiple tooltips display in EmojiReactionBubble for context menu emojis

Details
Tooltip of reactions moved to the EmojiReactionBubble which avoids two tooltips displayed in the context menu emoji option
Fixed Issues

$ https://github.com/Expensify/App/issues/16050
PROPOSAL: https://github.com/Expensify/App/issues/16050#issuecomment-1472660977
Tests

On web or desktop, right click on any message to open the context menu
Hover on any emoji reaction
Verify single tooltip of emoji name is being displayed

[X] Verify that no errors appear in the JS console

Offline tests

On web or desktop, right click on any message to open the context menu
Hover on any emoji reaction
Verify single tooltip of emoji name is being displayed

QA Steps

On web or desktop, right click on any message to open the context menu
Hover on any emoji reaction
Verify single tooltip of emoji name is being displayed

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/14358475/226590848-b54c8c7e-078b-4b07-93a3-1ad18b874b7c.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop
https://user-images.githubusercontent.com/14358475/226591627-3008a9fb-f520-434f-8963-a8aeafc425ef.mov

iOS

Android

@neil-marcellini @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Pujan92 Reactions Tooltip moved from EmojiReactionBubble
PR title could be improved Handle Incorrect Reaction Tooltip for context menu emoji's

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

 Desktop & Web
https://user-images.githubusercontent.com/85645967/226658637-d2c39157-49ea-4ff5-82a6-6bfc943b8502.mov

Mobile Web - Chrome & Mobile Web - Safari
https://user-images.githubusercontent.com/85645967/226659678-33f69c86-c5ec-4ce6-9d4e-acea2c46b5ec.mov

iOS & Android
https://user-images.githubusercontent.com/85645967/226659616-91974360-a157-457f-9f9e-63891562f152.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Santhosh-Sellavel @neil-marcellini I am seeing a regression with this PR which causes console warning as key is missing for the Tooltip wrapper. Need to move below key from EmojiReactionBubble to Tooltip.
https://github.com/Expensify/App/blob/95d79900c5dc0441b8b933ca1fbe5d7bdaec9679/src/components/Reactions/ReportActionItemReactions.js#L82-L83
Shall I proceed and raise new PR for this fix?

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Ignored an update to unaccepted module

Operating System: Darwin 17.4.0
Node Version: 9.5.0
NPM Version 5.6.0
webpack Version 4.0.1
webpack-server Version 0.1.5

This issue is for a:

[x] bug
[ ] feature request
[ ] modification request

Code
CLI Command
  $ webpack-serve ./webpack.config.js

webpack.config.js
const HtmlWebPackPlugin = require("html-webpack-plugin");

module.exports = {
  module: {
    rules: [
      {
        test: /\.js$/,
        exclude: /node_modules/,
        use: {
          loader: "babel-loader"
        }
      },
      {
        test: /\.html$/,
        use: [
          {
            loader: "html-loader",
            options: { minimize: true }
          }
        ]
      }
    ]
  },
  plugins: [
    new HtmlWebPackPlugin({
    })
  ]
};

Expected Behavior
Making a change should reload.
Actual Behavior
Fails to reload

How Do We Reproduce?

Is this already a known issue or do you need more information from me?  If so what?  Thanks.

Thanks for the issue 🍺  webpack-serve doesn't handle this aspect, rather that functionality is in webpack-hot-client. Please see this issue, which tracks the same problem: https://github.com/webpack-contrib/webpack-hot-client/issues/26


Choose screenshot format

I don't have macOS Big Sur to try it.
Tell me if everything is okay!

I am going to fix it!

Sorry, yes, you're right!

Fix #34
Thanks Valentin!


don‘t work GetAvailableRooms in example scene？

i have try add GetAvailableRooms to example scene, but i get this error ,can someone help me ?

this is my code

i perhaps understand this bug reson, this is because RoomAvailable's maxClients type is unit , but this default value is Infinity.
i dont think this reasonable

I've added a workaroud for this (https://github.com/colyseus/colyseus-unity3d/commit/2bfc3f61a894bb79580bccb22df528441ef88499). Thanks for reporting!


Error: creating ECR Public repository: RequestError: send request failed

Description
Creating resources against us-east-2 fails with the following log.
│ Error: creating ECR Public repository: RequestError: send request failed
│ caused by: Post "https://api.ecr-public.us-east-2.amazonaws.com/": dial tcp: lookup api.ecr-public.us-east-2.amazonaws.com on <IP_ADDRESS>:53: no such host

[X] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:

1.6.0

Terraform version:
v1.2.9
Provider version(s):
registry.terraform.io/hashicorp/aws v5.17.0

Reproduction Code [Required]
provider "aws" {
  region = "us-east-2"
}

module "public_ecr" {
  source = "terraform-aws-modules/ecr/aws"

  repository_name = "public-image"
  repository_type = "public"

  public_repository_catalog_data = {
    description       = "public docker image"
    operating_systems = ["Linux"]
    architectures     = ["x86"]
  }
}

Ran into this too. Public ECR is only in us-east-1 and us-west-2.
https://docs.aws.amazon.com/general/latest/gr/ecr-public.html


Exception when searching for stations

I'm getting the following exception when searching for stations, using the example from the screenshot on the README page. It's having problems doing some casting. I'm running this on the Windows Subsystem for Linux, so I know my setup is not typical, not sure if that would have anything to do with it.
Appreciate any help. Would be awesome to get this working, thanks!
230-****** WARNING ** WARNING ** WARNING ** WARNING ** WARNING ******
 ** This is a United States Department of Commerce computer     **
 ** system, which may be accessed and used only for             **
 ** official Government business by authorized personnel.       **
 ** Unauthorized access or use of this computer system may      **
 ** subject violators to criminal, civil, and/or administrative **
 ** action.  All information on this computer system may be     **
 ** intercepted, recorded, read, copied, and disclosed by and   **
 ** to authorized personnel for official purposes, including    **
 ** criminal investigations.  Access or use of this computer    **
 ** system by any person, whether authorized or unauthorized,   **
 ** constitutes consent to these terms.                         **
 ****** WARNING ** WARNING ** WARNING ** WARNING ** WARNING ******
230 Anonymous access granted, restrictions apply

Enter station name, full or partial. (ex. Washington, san fran, USC): chico

Traceback (most recent call last):
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 1655, in _cast_types
    values = astype_nansafe(values, cast_type, copy=True)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/core/dtypes/cast.py", line 703, in astype_nansafe
    return arr.astype(dtype)
ValueError: could not convert string to float: 'GSN'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "get_noaa_ghcn_data.py", line 17, in <module>
    station_id = get_station_id.get_station_id(ftp)
  File "/mnt/c/Users/mpaulus/get_noaa_ghcn_data-master/get_station_id.py", line 88, in get_station_id
    df = pd.read_fwf(local_full_path, widths=widths, names=names, dtype=dtype, header=None)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 741, in read_fwf
    return _read(filepath_or_buffer, kwds)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 455, in _read
    data = parser.read(nrows)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 1069, in read
    ret = self._engine.read(nrows)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 2269, in read
    data = self._convert_data(data)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 2338, in _convert_data
    clean_conv, clean_dtypes)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 1562, in _convert_to_ndarrays
    cvals = self._cast_types(cvals, cast_type, c)
  File "/home/mpaulus/.local/lib/python3.5/site-packages/pandas/io/parsers.py", line 1658, in _cast_types
    "type %s" % (column, cast_type))
ValueError: Unable to convert column LATITUDE to type <class 'float'>

Thanks for pointing this out. I confirmed that this issue does not occur with my setup, so I'm not sure if my fix will solve your problem. I changed all of the dtypes to str before reading the .dly file with pd.read_fwf since the floats are not needed. Give it a shot and let me know what happens.

Your fix resolved the issue. I ran into another issue when searching for the stations, the order of the column names was getting messed up. I've made a PR (#2) to fix it, feel free to pull it in or just fix it yourself. You can close this issue. Thanks!

Sounds good, closing this issue. Hope the tool works well for you.


Required application roles on install with Normal security settings

App: /terminalsocket in USER namespace requires %DB_CACHESYS and %DB_USER so UnknownUser can access it.
Here's an audit message without %DB_CACHESYS so we can maybe remove the dependency. Namespace routines db needs to have public RW (maybe R is enough?) resource, or if not, role given to web app.
Audit Details:
Description 	Attempt to access a protected resource
Timestamp 	2016-02-12 16:05:09.226
UTCTimestamp 	2016-02-12 21:05:09.226
Event Source 	%System
Event Type 	%Security
Event 	Protect
Username 	UnknownUser
Pid 	23104
JobId 	2424862
JobNumber 	30
IP Address
Executable 	CSPap.so
System ID
Index 	16384
Roles 	%DB_%DEFAULT,%DB_CACHE,%DB_USER
Authentication 	Unauthenticated
Namespace 	USER
Routine 	zRequireAuthorization+19^WebTerminal.Engine.1 |"^^/InterSystems/Cache/mgr/user/"|
User Info
O/S Username 	CSP Gateway
Status
Event Data 	zRequireAuthorization+19^WebTerminal.Engine.1 */InterSystems/Cache/mgr/

Oh, of course  zRequireAuthorization+19^WebTerminal.Engine.1:
zn "%SYS"
do ##class(Security.Users).Get(username, .userProps)

So, no way without %DB_CACHESYS I guess

Please, build the latest terminal from master and verify if it works for 2016.1 with normal security option.
If it is, let's make this issue resolved!
Thank you!

Tested


refactor(jdbc-sink): execute statements in batch and set isolation level to RC

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Explicitly set transaction isolation level to READ COMMITTED (same as before).
Fix #12061, group SQL statements to a stagingStatements map, and execute them after processing a chunk. And we execute DELETE first to prevent accidentally deletions.
Performance numbers (sink a tpch orders table to postgres):
6k rows/s for each parallelism (4 parallelisms in total)
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Add the performance of main branch. Test setup: c5.4xlarge, release build, S3  cc @hzxa21

LGTM. So it is about 2x throughput improvement achieved by batching, right?

The main branch is about 4k rows/s, improvement is about 1.5x.


WebAPI

WebAPI has available now the option to download the records.

The following page lists the webservices available at the moment:
https://esas.ices.dk/webservices
For the campaign records we allow the users to download all them, all the other records not authenticated users will only have access to public records.

Asked via email, but documenting here as well:

Is it possible for the endpoints (campaigns, samples, ...) to have
the same fields as those in the CSV download? E.g. excluding
tblUploadID, ..., adding species information?
Is there a specific R package to query these endpoints?

Yes, this is possible, it will be implemented.
Carlos

The fields are the same, the download and the WebAPI use the same classes, but API have the database ID's. These are striped out in the files but we prefer to keep them in the WebAPI.

Todo. Note that the descriptions below also fix a number of typos.

[ ] Add HTML title Web services
[ ] Remove blue alert box
[ ] Are only the provided parameters available, or are all fields parameters? It is currently odd that e.g. WindForce is included.
[ ] Replace entire intro text with:

This page lists all web services of European Seabirds At Sea (ESAS). For each API endpoint the description and input parameters are provided, as well as some examples. For less technical access to the data, see the download page.

getListSubmissions

[ ] Why is this not called getFileSubmissions?
[ ] Fix field name typo submiterEmail to submitterEmail
[ ] Description:

Returns file submissions (i.e. how data were submitted to ESAS for each campaign).

[ ] Example:

Get all file submissions

getCampaignRecords

[ ] Description:

Returns campaign information.
Parameters:

CampaignID
Country
DataRightsHolder

[ ] Examples:

Get all campaigns
Get campaigns from Denmark

getSampleRecords

[ ] Description:

Returns sample information. Users authenticated with a JWT token will also have access to restricted data associated with their organization.
Parameters:

CampaignID
Country
Year
PlatformCode
TargetTaxa

[ ] Example:

Get all public samples
Get public samples from Denmark
Get public samples from the year 2014

getPositionRecords

[ ] Description

Returns position information. Users authenticated with a JWT token will also have access to restricted data associated with their organization.
Parameters:

CampaignID
Country
Year
WindForce
Visibility

[ ] Example:

Get all public positions
Get public positions from Denmark
Get public positions from the year 2014

getObservationRecords

[ ] Description

Returns observation information. Users authenticated with a JWT token will also have access to restricted data associated with their organization.
Parameters:

CampaignID
Country
Year
WindForce
Visibility

[ ] Example:

Get all public observations
Get public observations from Denmark
Get public observations from the year 2014

Token, ScreenESASFile, getScreeningDetails, ...

[ ] Simplify descriptions
[ ] Correct typos like succeds, successfuly

@neil-ices-dk or @Osanna123  can you check the description of the last 5 services?

Edited text:
Returns a list of messages from a file screening session, no authentication is needed.

![image](https://user-images.githubusercontent.com/23527005/169276370-448b9f09-5454-41
Edited text:
Returns meta information of a screening session, no authentication is needed.

Edited text:
An authenticated user can push a file (identified by Screening Session ID) to the European Seabirds at Sea database. Requires that the user is the same as the user that generated the Screening Session ID.
The service can be called using post

(why not just ScreenFile?)
Edited text:
An authenticated user can upload a file to be screened and validated.
The service can be called using post and the file will have to be part of the body of the call.
This service is a pre-requisite to be able to upload data to the database via PushFileToDatabase Service
This file can be later pushed to the database by the same user.

@cmspinto there is no mention that the file needs to have passed the screening in order to be uploaded via PushtoDatabase; there should be something right?

Yes, sorry might have missed the obvious!

thanks, could you follow the edited text version in the post further up

@cmspinto several things are still missing or wrong:

[ ] Intro, change to (no space before period):

see the download page.

[ ] Token, change to:

Returns a JSON Web Token (JWT) that enables the user to make API requests that require authentication.
A JWT token.

[ ] getScreeningSessionMessages, change to:

Returns a list of messages from a file screening session, no authentication is needed.

[ ] ScreenESASFile, change to:

Validates a file that is according to the European Seabirds At Sea format.

[ ] PushFileToDatabase, change to as suggested by @neil-ices-dk:

An authenticated user can push a file (identified by Screening Session ID) to the European Seabirds At Sea database.
Requires that the user is the same as the user that generated the Screening Session ID.
The service can be called using post.

[ ] ScreenESASFile: as asked by @neil-ices-dk, why not ScreenFile
[ ] ScreenESASFile, change to as suggested by @neil-ices-dk (currently this text is used for the wrong service):

An authenticated user can upload a file to be screened and validated.
The service can be called using post and the file will have to be part of the body of the call.
This service is a pre-requisite to be able to upload data to the database via PushFileToDatabase Service.

Done, have I missed something here?


【Hackathon 4th No.20】Added paddle.i0 / paddle.i0e API rfc doc

added i0 / i0e api rfc doc, and updated the incorrect date of filename for my previous contribution.

请 @zhengqiwen1997 帮忙 review 下


return znc.HALTCORE ignored in OnJoinMessage

I'm trying to stop join messages: ZNC -> CLI.
The znc -D shows the block of code running but the message still being sent to CLI.
Am I doing something wrong or is this a bug?
import znc

class testblockjoinmsg(znc.Module):
    """
    test blocking messages.
    """
    description = "another test appl"
    has_args = False

    def OnJoinMessage(self, msg):
        print(f'JOIN message to block: {msg}')
        return znc.HALTCORE

"""
OUTPUT from znc -D
[2024-05-25 11:40:09.268554] (x/libera) IRC -> ZNC [@time=2024-05-25T18:40:09.194Z;account=Throgkt :Throgkt!~Throgkt@user/throgkt JOIN #linux Throgkt :Throgkt]
JOIN message to block: @account=Throgkt;time=2024-05-25T18:40:09.194Z :Throgkt!~Throgkt@user/throgkt JOIN #linux Throgkt :Throgkt
[2024-05-25 11:40:09.269775] (x/libera) ZNC -> CLI [@time=2024-05-25T18:40:09.194Z :Throgkt!~Throgkt@user/throgkt JOIN #linux]
"""

That's because of NOTHING in https://github.com/znc/znc/blob/82e82f0bf6f643839612968db668e135757129b4/src/IRCSock.cpp#L551
No idea why it's like this...

Oh, so it is just ignoring the return‽
I updated it to look like  OnTextMessage:
IRCSOCKMODULECALL(OnJoinMessage(Message), &bResult);
if (bResult) return true;
and am building.
We will see what happens.


Feature/fe 579 location details

Location Field (that's not being used anywhere because adding locations on resources not ready).

Location Form, which is being used by Create and Edit location.  Create location tied to Location Field.

Funding Account Field tied to a create funding account form.

Location Detail View that ties to edit location.

Location and funding Account Cards

Not on this PR: funding account detail scene or updating a specific funding account (different from updating the funding account on a location)

~Let's make the type default to country.~ Nvm I'd rather change this on the API so we don't have to "hardcode" an enum value here.
Can we change "ISO Alpha-3 Code" to "ISO Alpha-3 Country Code"?

~Let's make the type default to country.~ Nvm I'd rather change this on the API so we don't have to "hardcode" an enum value here.

Are you talking about on FundingAccountField.tsx?

Can we change "ISO Alpha-3 Code" to "ISO Alpha-3 Country Code"?

Done

This looks good, but I'm unable to check it in UI because I'm having some weird issue where, even if I create things as root, I don't have read permissions. So I can run the createLocation mutation in devtools, but I can't then view the Location Detail scene in the UI for it. @CarsonF, can you take another look?


[Page UsageCategory Request] page 5406 "Prod. Order Line List"

Describe the request
Could you maken page 5406 "Prod. Order Line List" searchable in the role center? Like has been done with
page 5407 "Prod. Order Comp. Line List" or page 516 "Sales Lines". Users want to be able to saves views etc.
Old:
page 5406 "Prod. Order Line List"
{
Caption = 'Prod. Order Line List';
Editable = false;
PageType = List;
SourceTable = "Prod. Order Line";
layout

New:
page 5406 "Prod. Order Line List"
{
ApplicationArea = Manufacturing;
Caption = 'Prod. Order Line List';
Editable = false;
PageType = List;
SourceTable = "Prod. Order Line";
UsageCategory = Lists;
layout

Additional context
Not all tables have been done in the base as previous stated in release notes of older major releases.
Internal work item: AB#538692

ANybody working on this? Not possible in 24.5?


Index documents only on postFlush event

Since doctrine uses transactions to roll back all queries in case of error, indexing operations should be run only on postFlush event.

Thank you @pierre-H for your contribution.
I've added some functionnal tests to your code : https://github.com/acseo/TypesenseBundle/pull/42


Demo JavaScript coverage for this repo

Following the method in 1.

Based on the method documented here, this repo has ~61% JavaScript code coverage.


Remove unused url_launcher library in geolocator

Fixes #38

@mvanbeusekom the failure in geolocator platform interface is because of an unrelated deprecation. What do you normally do in this instance?

@mvanbeusekom the failure in geolocator platform interface is because of an unrelated deprecation. What do you normally do in this instance?

No worries I will quickly fix it in a separate PR now, maybe you can then merge it in.

@grahamsmith I have just fixed the deprecation warnings, if you could rebase on the develop branch the problems should go away.

Done :+1: and thanks for fixing those warning 👍  - was in the middle of it in case but was finding the migration non obvious.

@mvanbeusekom new failures are from cocoapods. Unsure how to fix unfortunately.

@grahamsmith could you rebase once more with the develop branch, this should fix the iOS build step.

Spotted the merge just pushing now

Thanks @grahamsmith


Added additional database close calls.

What
More places where close() was not being called by tests.
How

Fixed ordering to call close before deleting temporary directory in teard down of BasicDBCoreObservableTest.
Added close call in teardown in SQLDatabaseFactoryTest.
Added a close before delete in TestUtils.deleteDatabaseQuietly if database was still open.
Added close and fixed deletion ordering in tear down of SQLiteWrapperTest.

Tests
No new tests, this PR is for test fixes. Green CI. Connected check passes locally.
Fixes #323

LGTM +1


refactor: find: rm useless condition

Both parts of expression:
const nodeTypes = Array.isArray(matcher.nodeType)
    ? matcher.nodeType
    : matcher.nodeType

Returns same result, and can be simplified to:
matcher.nodeType

Just landed this case to @putout/plugin-simplify-ternary 🎉
With commit https://github.com/coderaiser/putout/commit/c08ec496d62fe1786d2f9031d4957789c3e28cb9

Actually this was a bug and the else condition should be [matcher.nodeType].  Weird that I missed this...

There is more such cases, you can find them with putout :). Static analysis can’t be to much.


[AutoDiff upstream] Update @differentiable syntax.

Clean up unused syntax components and fix description strings.
Friend PR: https://github.com/apple/swift-syntax/pull/179
Resolves comments: https://github.com/apple/swift/pull/27506#pullrequestreview-315663528

Must be tested with https://github.com/apple/swift-syntax/pull/179 so that --swiftsyntax-verify-generated-files passes.

https://github.com/apple/swift-syntax/pull/179
@swift-ci smoke test

@akyrtzi: could you please help merge this PR and https://github.com/apple/swift-syntax/pull/179?


NO NEED TO REVIEW! JUST TRIAL!

WILL CLOSE THIS! JUST FOR EXPERIMENTATION!
/hold

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: icygalz
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@icygalz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test integ-framework-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-simpleTests-minProfile.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTestsMinProfile-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-simpleTests-minProfile.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-simpleTests-minProfile.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@icygalz: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-simpleTests-minProfile.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTestsMinProfile-master

prow/e2e-simpleTests-cni.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTests-cni-master

prow/e2e-simpleTests.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test e2e-simpleTests-master

prow/e2e_pilotv2_auth_sds.sh
cf196b842aefc8c6c427cd8e5bb0757664626a2d
link
/test istio_auth_sds_e2e-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


stat.CovarianceMatrix(nil, X_yk, nil) used as value？

https://github.com/sjwhitworth/golearn/blob/82e59c89f5020c45292c68472908f2150a87422e/clustering/em.go#L150

func CovarianceMatrix(dst *mat.SymDense, x mat.Matrix, weights []float64) {

I am also facing this issue and am quite confused!


Draw ellipses

We must take care that depending on the zoom, the angle changes.
https://www.visiondummy.com/2014/04/draw-error-ellipse-representing-covariance-matrix/

There is now Annotation.Ellipse. The missing part is the ability to rotate it.


It takes an excessively long period of time to send the first message

Please describe the issue you observed:
DefaultMQProucers takes an excessively long period( > 5 seconds) to send the very first message if not timeout.

What did you do (The steps to reproduce)?
Time the elapsed time when sending messages.
What did you expect to see?
Sending a single message should be completed within a few milliseconds.
What did you see instead?
A long period of time working, more than 5 seconds are required for the first one.

Please tell us about your environment:
N/A

Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
A pull request has been prepared.

I will close the issue for duplication with #3288


Create a better Responsive UI for Mobile and tablets

I assume the main issue is related to the UI responsiveness of the dashboard page, with some minor concerns on other pages. Would you mind assigning this task to me, @vishalverma9572?

@Unnati260, assigned!

Hi, I have almost done it. Do you mind attaching the hacktoberfest tags?


FLAKE: in windows/quickstart-cmake-dll-presubmit

The first CI run of https://github.com/googleapis/google-cloud-cpp/pull/3802, I saw an unrelated breakage from the windows/quickstart-cmake-dll-presubmit build. I triggered a re-run and it passed:
https://source.cloud.google.com/results/invocations/cb79e1c3-57cd-4420-94bd-467a3971c1e1/targets/cloud-devrel%2Fclient-libraries%2Fcpp%2Fgoogle-cloud-cpp%2Fwindows%2Fquickstart-cmake-dll-presubmit/log
A snippet of the error:
20-04-16T14:25:13.9485942+00:00 Compiling with CMake Debug
[1/2] Building CXX object CMakeFiles\quickstart.dir\quickstart.cc.obj
T:\src\github\google-cloud-cpp\cmake-out\vcpkg-quickstart\installed\x64-windows\include\google/protobuf/stubs/platform_macros.h(134): warning C4005: 'PROTOBUF_USE_DLLS': macro redefinition
T:\src\github\google-cloud-cpp\google\cloud\bigtable\quickstart\quickstart.cc: note: see previous definition of 'PROTOBUF_USE_DLLS'
T:\src\github\google-cloud-cpp\cmake-out\vcpkg-quickstart\installed\x64-windows\include\google/protobuf/stubs/logging.h(102): warning C4251: 'google::protobuf::internal::LogMessage::message_': class 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' needs to have dll-interface to be used by clients of class 'google::protobuf::internal::LogMessage'
c:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.21.27702\include\xstring(4231): note: see declaration of 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>'
T:\src\github\google-cloud-cpp\cmake-out\vcpkg-quickstart\installed\x64-windows\include\google/protobuf/io/coded_stream.h(1250): warning C4251: 'google::protobuf::io::CodedOutputStream::default_serialization_deterministic_': struct 'std::atomic<bool>' needs to have dll-interface to be used by clients of class 'google::protobuf::io::CodedOutputStream'
c:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.21.27702\include\atomic(1817): note: see declaration of 'std::atomic<bool>'
T:\src\github\google-cloud-cpp\cmake-out\vcpkg-quickstart\installed\x64-windows\include\google/protobuf/arena_impl.h(287): warning C4251: 'google::protobuf::internal::ArenaImpl::lifecycle_id_generator_': struct 'std::atomic<__int64>' needs to have dll-interface to be used by clients of class 'google::protobuf::internal::ArenaImpl'

I think those are just the usual warnings in protobuf, the error is here:
2020-04-16T14:26:00.7338546+00:00 DONE
Get-ChildItem : Access is denied
At T:\src\github\google-cloud-cpp\ci\kokoro\windows\build.ps1:106 char:5
+     Get-ChildItem -Recurse -File `
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Get-ChildItem], UnauthorizedAccessException
    + FullyQualifiedErrorId : System.UnauthorizedAccessException,Microsoft.PowerShell.Commands.GetChildItemCommand```

A successful build says:

2020-04-16T14:51:39.9357138+00:00 DONE
DONE "============================================="
Thu 04/16/2020 14:51:57.86
[ID: 9162416] Build finished after 366 secs, exit value: 0

This seems like a bug in the CI script, it should ignore errors when trying to cleanup %KOKORO_ARTIFACTS_DIR%


GH-137 consider Refine nodes in the qualified name calculation

Fixes theia-ide/yang-lsp#137

Refine nodes where not taken into account in the qualified name calculation of the scope. Based on the resulting gap in the qualified name the XpathResolver filtered the inlined children out.


Launch jupyter-notebook instead of jupyterhub-singleuser

One of the tensions with adopting jupyterhub for binder is that the authentication mechanism used for jupyterhub requires jupyterhub to be installed in the container and to be a compatible version. This is a bit frustrating because the authentication is mostly irrelevant to binder.
jupyterhub-singleuser does two things right now, on top of jupyter notebook:

authenticate with the Hub
provide links back to the hub

The links back to the hub are actively unhelpful in Binder because they won't work. Authenticating with the Hub is also unnecessary for Binder containers.
If, instead, we launched jupyter notebook, we would get rid of all of the problems dealing with matching hub and container versions. This matches the behavior of old binder and makes it much more resilient to version changes (jupyterhub doesn't need to be installed at all).
We could even keep authentication if we require notebook>=4.3 and launch with --NotebookApp.token=..., letting the notebook server authenticate with a token instead of deferring to jupyterhub.

re: authentication, can't we imagine use-cases where somebody would want authentication with binder? e.g., internal institutional (or company) binder deployments w/ fancier hardware behind them etc?

Yes, though that may not end up being related to the authentication of the running notebook container, rather the binderhub service itself.

This would definitely solve a lot of problems! But does that mean we get
rid of Jupyterhub completely? Or somehow hack it to make this possible?
On Sep 8, 2017 4:41 PM, "Min RK"<EMAIL_ADDRESS>wrote:

Yes, though that may not end up being related to the authentication of the
running notebook container, rather the binderhub service itself.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/103#issuecomment-328237821,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23kBeX_8aSuhVlzBUZ5Zhp2jdaBQ-ks5sgdC6gaJpZM4PQ3R-
.

But does that mean we get rid of Jupyterhub completely?

With the current design, no. JupyterHub makes no hard assumptions about the servers it starts (Spawners may). We would have to make sure that no jupyterhub-specific CLI args get passed to the subprocess, but that's about it (env can be safely ignored).
As it is now, we have the following assumptions that it is jupyterhub:

we check for x-jupyterhub-version header on start, and warn if it doesn't match. This has no behavioral consequences, though, so is fine.
The default get_args() behavior assumes jupyterhub-singleuser. We'd need to be careful here, when building the CMD to start.

JupyterHub would still launch and manage the container, but KubeSpawner would tell it to run jupyter notebook instead of jupyterhub-singleuser. All the rest of the info would be the same.
Doing this as an official deployment is baking in some assumptions, both to Binder and JupyterHub:

Binder won't ever require software that we install in the image (we can never do this as long as we support user Dockerfiles). That means that Binder can never rely on notebook extensions, etc.
JupyterHub can never make assumptions about what it spawns (e.g. require webhooks for spawn callbacks, etc.)


Fix AttributeError in create_queue Function

Fixed an issue in the create_queue function where calling strftime on a string caused an AttributeError.
Changes

Removed strftime calls on open_time and close_time.
Used the raw values directly from the request data.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag
Coverage Δ

unittests
73.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

manager/views.py
39.20% <ø> (ø)

GOOD JOB FIXBUG, "FIX" BUG

good job Goowanit


Invokable API for external usage

Move current functionality to a cli.js and add in API functionality?

Figure out what to do about 'path'


fix(TDI-40149) : Ne need to refresh form

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-40149
There were an issue on the new property 'Jobtimeout' that refreshed the advanced form; It should not.
What is the new behavior?
The advanced form is no more refreshed.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[ ] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: failure :x:


unit test for headers.contains CharSequence

Motivation:
increase test coverage for DefaultHttpHeaders and DefaultHttp2Headers
Modification:
add unit tests for the contains(CharSequence) method
Result:
All unit tests pass.

Thanks


Mention Conda.jl in readme

@Luthaf made a great package enabling installation of Python + IPython + IJulia by a few lines of Julia code without any need for further setup to get running with IJulia.

Conda.jl should be usable on Linux too, if you want to provide an unified interface. But it does not set environment values anymore, which can be an issue if you try to call directly the binaries. This can be reverted if needed by IJulia!

This should probably be tested and automated everywhere (unless a new enough system ipython/jupyter is found) as a replacement for #211.

This sounds like a nice option!  I'm giving a Julia tutorial on Monday, so I will try this out on a few machines this weekend.

I have used it with success on different windows computers last weekend. I have not tested it on osx as I have no such device.

We might consider having IJulia:

REQUIRE the Conda package
Tell Conda to install ipython-notebook at Pkg.build time
Install the kernelspec for both the Conda jupyter and any system-wide jupyter command that is found in the PATH.  (Or maybe they both use the same config directory so that this is redundant.)
Use the Conda jupyter for the IJulia.notebook() function.

Although I would only want to do this if it seems to be working on Mac, Windows, and Linux.

@stevengj sounds like a good plan. @Luthaf do you see any obstructions in realizing this?

@stevengj by requiring Conda all IJulia users will get an miniconda installed even though they specify JUPYTER environment variable. Is this ok or could we work around it?

The Conda package should maybe export something like Conda.binpath("jupyter") to return the absolute path of a conda-installed executable.

This one can be difficult on Windows, because the binary will be in $PREFIX/pkg/$pkg_name-$pkg_version/bin. So would have to track the package name and version associated with the executable.
Maybe using an environment would do the trick.

even though they specify JUPYTER environment variable. Is this ok or could we work around it?

Maybe the build.jl can detect if the JUPYTER variable is set before declaring dependencies.

@Luthaf, can't the conda command tell you the package name and version?

By utilizing the second part of the regex in: https://github.com/Luthaf/Conda.jl/blob/4e39b971300c0519524a600c106000d06aa39c2f/src/Conda.jl#L104-L117 it should be able to tell the version.

@Luthaf, can't the conda command tell you the package name and version?

Only if the executable name matches the package name. This could be doable with meta-data search too.

In our case, however, we will know the package name, so it is fine to ask us to supply that, maybe in a Conda.pkgpath(package::String) function?

In our case, however, we will know the package name, so it is fine to ask us to supply that, maybe in a Conda.pkgpath(package::String) function?

Yes, this is doable. See https://github.com/Luthaf/Conda.jl/pull/8 for a first attempt doing this.


feat: update to new Dynamo transaction limit

Issue #, if available:
https://github.com/aws/aws-dax-go/issues/40
Description of changes:
I updated the maxWriteBatchSize to 100, to align with new DynamoDB limits https://aws.amazon.com/about-aws/whats-new/2022/09/amazon-dynamodb-supports-100-actions-per-transaction/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sumitsa-amazon can you take a look at this? Thanks :)

Hi,
Thank you for contributing to DAX Go SDK.
I see that the PR increases the limit of batch size from 25 to 100 for the BatchWriteItem API. For BatchWriteItem the limit of number of operations is still set to 25 operations per request - ref. The relaxation in limit from 25 operations to 100 operations is only applicable for transact APIs.

Ohh that's a good point. Are you saying that if we attempt a TransactWrite call with 100 items, it should work? I need to try that out...

Ohh that's a good point. Are you saying that if we attempt a TransactWrite call with 100 items, it should work? I need to try that out...

It does work!

Thank you for confirmation. I'll close this PR.


CLI documentation "az iot dps enrollment-group" is not up to date

[Enter feedback here]
Link: https://docs.microsoft.com/en-us/cli/azure/ext/azure-cli-iot-ext/iot/dps/enrollment-group?view=azure-cli-latest#ext_azure_cli_iot_ext_az_iot_dps_enrollment_group_create
For example:
For az iot dps enrollment-group create,
parameter allocation-policy is missing "custom" option. ,
parameter webhook-url is missing

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44a3283c-e190-c2a7-fc50-41d9ba6a8d2e
Version Independent ID: 473e67d0-b090-c5c2-285c-7c194b3af844
Content: az iot dps enrollment-group
Content Source: latest/docs-ref-autogen/ext/azure-cli-iot-ext/iot/dps/enrollment-group.yml
Service: iot-hub
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Never mind. The latest document is in https://docs.microsoft.com/en-us/cli/azure/ext/azure-iot/iot/dps/enrollment-group?view=azure-cli-latest#ext_azure_iot_az_iot_dps_enrollment_group_create


check texture sizes should be optional (on by default)

Blending two datasets of different number of slices throws an error due to texture sizes restrictions.
This should be optional in the library  in case we find this cases.  related to  #113

I'm not sure what you want me to implement. Right now they always have to be the same size. We would have to calculate the start and end position for each individual model again in order for this to work, which is fine if that's what you're looking for

It should be possible to blend multiple datasets with different sizes. Right now, it throws an error when the volumes have a different width and height. Could you remove this check and/or make it optional?


feat(vue-quill): add focus method

Trying to solve adding focus capability for https://github.com/vueup/vue-quill/issues/351

Was able to confirm this works testing locally. Please consider adding this, it would be extremely useful to me and I have seen others request this in the past - here for example.

Was able to confirm this works testing locally. @luthfimasruri please consider adding this, it would be extremely useful to me and I have seen others request this in the past - here for example.


Add ability to localize figure caption

Sphinx localization needs node source and line and if it is not present, localization step is skipped.
If the source looks like (MyST markdown)
::::{subfigure} A

:::{image} img1.png
:alt: Subfigure caption
:width: 100px
:::

Figure caption
::::

Then after running make gettext, this .pot file is generated
#: ../../index.md:1
msgid "Subfigure caption"
msgstr ""

After applying the PR, this .pot file is generated
#: ../../index.md:1
msgid "Subfigure caption"
msgstr ""

#: ../../index.md:8
msgid "Figure caption"
msgstr ""

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a26b09a) 80.65% compared to head (23e494d) 79.78%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/sphinx_subfigure/main.py
0.00%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   80.65%   79.78%   -0.88%
==========================================
  Files           5        5
  Lines         274      277       +3
==========================================
  Hits          221      221
- Misses         53       56       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Missing device configuration: <ZW3 module for YRD256 (Yale Lock)>

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

Which device is missing?
YRD256 ZW3 is in database, but this particular device ID is missing from existing range
Manufacturer ID
0x0129
Product Type
0x4dd5
Product ID
0x8109
Firmware Version
2.17.0
Is the device listed on the Z-Wave Alliance website?
No response
Do you have a manual?
This is a YRD256 device for which a config file already exists; this device ID (new Yale ZW3 module) is just not recognized within that range.

Updated: Contributed the change to config file and created pull: https://github.com/zwave-js/node-zwave-js/pull/5604


ERROR: could not watch for Kubernetes service changes

Hi Team,
We noticed that Ambassador manytime complains about could not watch for Kubernetes service changes
We are runnign Ambassador as daemonset and i have attached logs of two ambassador isntances.
I would need your assistance in finding out if everything is ok? We also noticed that Ambassador has restarted few times.
ambassador2.log
ambassador.log

I tracked it down to the version of the K8s python library that you are using in Ambassador.
Version in Ambassador: https://github.com/kubernetes-client/python-base/blob/789de6a60dea9442ee47601a788d92c653ea69e9/watch/watch.py
Commit that I think fixes this issue: https://github.com/kubernetes-client/python-base/commit/38cc2658bce19d45cd44024efb1768da206d0dda
I believe the fix is to bump the version of kubernetes from 6.0.0 to 8.0.0 here: https://github.com/datawire/ambassador/blob/master/ambassador/requirements.txt
Just to add to the above this is the Ambassador log:
Traceback (most recent call last):
  File "/ambassador/kubewatch.py", line 447, in main
    watch_loop(restarter)
  File "/ambassador/kubewatch.py", line 345, in watch_loop
    for evt in watched:
  File "/usr/lib/python3.6/site-packages/kubernetes/watch/watch.py", line 122, in stream
    resp = func(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py", line 14358, in list_service_for_all_namespaces
    (data) = self.list_service_for_all_namespaces_with_http_info(**kwargs)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/apis/core_v1_api.py", line 14455, in list_service_for_all_namespaces_with_http_info
    collection_formats=collection_formats)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 321, in call_api
    _return_http_data_only, collection_formats, _preload_content, _request_timeout)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 155, in __call_api
    _request_timeout=_request_timeout)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 342, in request
    headers=headers)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/rest.py", line 231, in GET
    query_params=query_params)
  File "/usr/lib/python3.6/site-packages/kubernetes/client/rest.py", line 222, in request
    raise ApiException(http_resp=r)
kubernetes.client.rest.ApiException: (500)
Reason: Internal Server Error
HTTP response headers: HTTPHeaderDict({'Content-Type': 'application/json', 'Date': 'Tue, 13 Nov 2018 17:36:38 GMT', 'Content-Length': '186'})
HTTP response body: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"resourceVersion: Invalid value: \\"None\\": strconv.ParseUint: parsing \\"None\\": invalid syntax","code":500}\n'```

I've switched Ambassador to kube-client 8.0.0 in commit e5dcd66d59aaff09db8a27cbde7932a66dd7eb26, which will be included in 0.50.0-ea7. Leaving this open for verification that that helps.

Closing this issue; ongoing Azure work is tracked in #1039.


flake: drop flake-utils

Help avoid polluting the lockfile of downstream consumers and their own users
Depends on https://github.com/NuschtOS/ixx/pull/45

In downstream flakes you can just override the flake input using an empty string and the whole search is removed.

Flake utils is such a wildly used flake that I would argue that this is not polluting because you could just override the input that every input uses the same flake utils.

This becomes a lot harder with development-related flakes like this, though -- unless the flake being pulled in directly by the end user also has a flake-utils input. In my case this is actually the only introduction of flake-utils, so it's a little annoying

In downstream flakes you can just override the flake input using an empty string and the whole search is removed.

But yeah, this is still a solution and should probably be done anyways by users. I just figured it could make things a little more convenient for users at the cost of a few lines of boilerplate here


provide jar packaged with sources

Added maven source and javadoc plugins.
Just run "mvn clean install"


feat: support selection of encryption and decryption methods, add gm sm4 crypto type

ref: https://github.com/CECTC/dbpack/issues/297 https://github.com/CECTC/dbpack/issues/298
Ⅰ. Describe what this PR did
support selection of encryption and decryption methods
add gm sm4 encryption and decryption methods

pls update the documents, both chinese and english.
https://github.com/CECTC/dbpack-doc/blob/master/crypto.md
https://github.com/CECTC/dbpack-doc/blob/master/en-us/crypto.md

pls update the documents, both chinese and english. https://github.com/CECTC/dbpack-doc/blob/master/crypto.md https://github.com/CECTC/dbpack-doc/blob/master/en-us/crypto.md

updated the documents with pr https://github.com/CECTC/dbpack-doc/pull/36


Preload script

Yes, please! In the mean time even a little module I could import that accomplished this somehow would be great, maybe it could show all layers onscreen for a second or two before setting their properties back to where they started.

Hi @uxdiogenes, this is an old ticket, there’s a preloader now. See Framer.Extras.Preloader.enable() (will be enabled by default when sharing). I think you might be talking about a different feature though, I don’t understand the remark about setting the properties back? Can you explain more?


Слава Україні

I think you should change "Slava Ukraini" to the Ukrainian sentence (sorry for bad english)

But the message is written in English


[Feature Request] Way to have "recommended options" in the dropdown before searching

In the application I am coding for by the time a user gets to the select2 dropdown, we have a fairly good idea which options they may be interested in.  It would be nice to be able to click the drop down, and be presented with say "10 recommended options" and then if you start typing, it goes right into a search (in my case ajax). Is this already possible, or something that could be added?

We don't have immediate plans to provide this. We are focused to fix some major UI bugs (that are majority of issues and PR's). But if you open a PR with unit tests, I will be glad to review and approve if everything is ok :+1:


Baresip Windows httpd interface

I have successfully compiled baresip in VS 2015, as per instructions and it runs perfectly (after adjusting the FD_SETSIZE to 2048.
However all attempts to http to port 8000 fail.
I enabled module hddp in config but on startup baresip reports "httpd.dll not found"

can you please try to upgrade to GIT HEAD and try again ?
(commit d499fa005973d453b5138ac04f71c009e4d8e273)
after git update you need to rebuild from scratch.

PERFECT!
Worked like a charm first time.. Thank you v much!

thanks for reporting and testing.
Please close the issue if it has been resolved.

Ofc!
Last question .. how far did you get with we interface, or else any other
way to connect except for “hit-and-run” http?
Francesco Facco de Lagarda
On 14 Jun 2019, at 13:58, Alfred E. Heggestad<EMAIL_ADDRESS>wrote:
thanks for reporting and testing.
Please close the issue if it has been resolved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alfredh/baresip/issues/732?email_source=notifications&email_token=AJOCQXRT2KZIOZ3BSZ5UWKDP2OBYBA5CNFSM4HYFK5G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXWSPEQ#issuecomment-502081426,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJOCQXXSAWKKULKDJUVBBLDP2OBYBANCNFSM4HYFK5GQ
.

Please note that this Issue tracker is mainly for reporting defects and bugs.
if you want to ask questions, please use the mailing list:
http://lists.creytiv.com/mailman/listinfo/re-devel
you can also try the other management modules like mqtt.so or ctrl_tcp.so

@fdl33333 Do you have binaries working properly in Windows 10 (both 32bit and 64bit if you have)? I met the same issues. The solutions that you applied do not work for me.
I would highly appreciate any assistance with that. I would be glad to provide any kind of donation for such contribution.


feat: Defer the unpacking of guild channel and members

What type of pull request is this?

[x] Non-breaking code change
[ ] Breaking code change
[ ] Documentation change/addition

Description
Makes Guild instantiation much lighter by throwing Channels and Members into the cache as deferred dicts (that get inflated when first pulled from the cache)
This is non-breaking, with the exception of people bypassing GlobalCache's methods to access the underlying dicts directly
Things I thought about doing, but have not done:

Background task that slowly inflates deferred stuff while it's idle in the cache.  Discarded because it didn't feel needed.
Deferring Roles.  The speedup from Members and Channels alone was good enough in my benchmarks.

Changes

Members and Channels can be optionally cached as Deferred dicts, rather than being constructed upon storage.
The Guild constructor uses this to speed up initial load times
The cache objects for member_cache and channel_cache are now private.
Synchronous functions to access these caches have been added (Though I'm not 100% happy with the names)

Checklist

[x] I've formatted my code with Black
[x] I've ensured my code works on Python 3.10.x
[x] I've tested my code

Benchmarks tell me this approach is a waste of time, restarting from a different idea


glamorous-native version ?

jest-glamor-react version: v3.3.0
node version: v8.9.4
yarn version: v1.3.2

Hi,
I just want to ask you if a version for glamorous-native (https://github.com/robinpowered/glamorous-native) is in your plans ?
Thank you

Not in the plans but probably possible. Would you like to research it and see what it would take to add support?

Closing for inactivity.


https://strapdownjs.com has a wrong certificate

Browsing to https://strapdownjs.com give the folowing error in Firefox:
strapdownjs.com uses an invalid security certificate. The certificate is only valid for the following names: *.github.com, github.com, *.github.io, github.io Error code: SSL_ERROR_BAD_CERT_DOMAIN
Could you check your github pages configuration?

@arturadib recently Github guys made it way easier to fix: https://blog.github.com/2018-05-01-github-pages-custom-domains-https/
Can you please go and update A record? Unfortunately, it's ain't something we can contribute ourselves.
At current state broken certificate prevents some of the sites from using strapdown.js properly. Because javascript is served from strapdownjs.com, when browser loads https page that uses strapdown, script is blocked as the mixed content.

i've made the A record changes, it needs to propagate though.. fingers
crossed.
-Artur
On Fri, Oct 19, 2018 at 4:47 AM Kostya Golikov<EMAIL_ADDRESS>wrote:

@arturadib https://github.com/arturadib recently Github guys made it
way easier to fix:
https://blog.github.com/2018-05-01-github-pages-custom-domains-https/
Can you please go and update A record? Unfortunately, it's ain't
something we can contribute ourselves.
At current state broken certificate prevents some of the sites from using
strapdown.js properly. Because javascript is served from strapdownjs.com,
when browser loads https page that uses strapdown, script is blocked as the
mixed content.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arturadib/strapdown/issues/92#issuecomment-431291591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtQmPumbwIhxGGPfS31xpzs_a9IVz9Fks5umZGGgaJpZM4Wb3Rd
.

I looked yesterday to see if Strapdown was at CDNJS, and there was an issue (closed) saying that they had asked, but nobody replied. While it's great that you are willing to host it yourself, and to keep the DNS set correctly, maybe letting meadows bloom (by letting it be on all the public CDNs) would lighten the load.
Just a thought,
Walter

On Oct 19, 2018, at 10:56 AM, Artur Adib<EMAIL_ADDRESS>wrote:
i've made the A record changes, it needs to propagate though.. fingers
crossed.
-Artur
On Fri, Oct 19, 2018 at 4:47 AM Kostya Golikov<EMAIL_ADDRESS>wrote:

@arturadib https://github.com/arturadib recently Github guys made it
way easier to fix:
https://blog.github.com/2018-05-01-github-pages-custom-domains-https/
Can you please go and update A record? Unfortunately, it's ain't
something we can contribute ourselves.
At current state broken certificate prevents some of the sites from using
strapdown.js properly. Because javascript is served from strapdownjs.com,
when browser loads https page that uses strapdown, script is blocked as the
mixed content.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arturadib/strapdown/issues/92#issuecomment-431291591,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtQmPumbwIhxGGPfS31xpzs_a9IVz9Fks5umZGGgaJpZM4Wb3Rd
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@walterdavis as far as I understand, github has it's own CDN for github pages and this is what Arthur is using to host strapdown. How is that compares to CDNJS (I am not a frontend dev per se)?

wrote to github support, they've expedited certificate creation and now https mode is on!

Horaaay! Thanks @arturadib and Thomas Baillie from github support

CDNJS is a semi-complete collection of front-end software, all of it available elsewhere, which provides diversity and redundancy, at the cost of maybe needing to update your libraries in more than one place. I have put a few libraries there that were abandoned by their creators. I don't know what their policy is about posting maintained software -- who does the updating when a new version comes out? The physical way that it works is you clone the CDNJS repo, make an addition, and send the maintainers a pull request. It usually goes through quickly and automatically if you are already validated. It was years ago that I was validated, though, so who knows what the process is like now.
Walter

On Oct 22, 2018, at 4:25 AM, Kostya Golikov<EMAIL_ADDRESS>wrote:
@walterdavis as far as I understand, github has it's own CDN for github pages and this is what Arthur is using to host strapdown. How is that compares to CDNJS (I am not a frontend dev per se)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Add CONTRIBUTING

Should link to lifetime repository article and explain that bug reports and feature suggestions, paper links are welcome, but pull requests will likely be ignored.

See https://github.com/atom/atom/blob/master/CONTRIBUTING.md for example

See https://github.com/atom/atom/blob/master/CONTRIBUTING.md for example


Settings - Time zone options doesn't change to Spanish

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in with a applause.expensifail account
Navigate to Settings > Preferences
Set the language to Spanish
Verify the app language changed to Spanish by navigating to several areas in the app

Expected Result:
All areas in the app are translated into Spanish
Actual Result:
Time zone options are still in English after changing app to Spanish
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.24-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I think this si actually not a bug. The timezones need to be in this English format so they can be converted to actual timezone offset. These names are IANA standardized. I have asked in the Slack here to discuss this.

@kavimuru or @mvtglobally Would you please be able to update your QA steps to make sure that this timezone picker is in English? It would be lots of effort to change this so we can leave it in English for all languages for now. Thank you very much!

Thank you Maria, I am closing this issue now.


Allow plugin option to configure base path to types index json file

Locally, getting types index for remotes works like a charm! However, if you've configured fetching remotes from a cdn - for example unpkg, axios attempts to fetch url: 'https://unpkg.com//__types_index.json'. This throws a 403 forbidden.
Full error log with infra logging
[1] INFO: Accepting connections at http://localhost:3000
[0]     [webpack-cli] Compiler starting...

Repro steps
Link to repo.
Or
git clone https://github.com/ahoward2/zod-modfed.git

cd host-app

yarn

yarn dev

In host-app/webpack.config.js you can switch disableDownloadingRemoteTypes: true to see the application fetching remotes from unpkg successfully.
Idea
Allow another plugin option to provide a custom basePathToTypesIndexFile origin/{base_path} to the __types_index.json file.
Maybe it's not desirable to take this as an input and instead enhance the importRemoteTypes method.
I can attempt a PR on this? Would just need some time to get spun up on this, otherwise any other helpful information / research I'd be happy to provide.
For example, I would want this to fetch the file from https://unpkg.com/<EMAIL_ADDRESS>

After doing some debugging I think I found why this happens in my case.
I added some logs inside the importRemoteTypes method.
[0]     [webpack-cli] Compiler starting...
[0]     [webpack-cli] Compiler is using config: '/Users/austinhoward/code/zod-modfed/host-app/webpack.config.js'
[0]     [FederatedTypesPlugin] Preparing to download types from remotes
[0]     [FederatedTypesPlugin] Normalizing remote URLs
[0]     [FederatedTypesPlugin] Remote URL for '@ahowardtech/checkout' is 'ahowardtechCheckout@https://unpkg.com/<EMAIL_ADDRESS>[0]     [FederatedTypesPlugin] Entry for '@ahowardtech/checkout' is 'ahowardtechCheckout@https://unpkg.com/<EMAIL_ADDRESS>[0]     [FederatedTypesPlugin] Url for '@ahowardtech/checkout' is 'https://unpkg.com/'
[0]     [FederatedTypesPlugin] Getting types index for remote '@ahowardtech/checkout'

The split in const [, url] = remoteUrl.split('@') is splitting at my package's scope.
const remoteUrls = Object.entries(remoteComponents).map(
      ([remote, entry]) => {
        const remoteUrl = entry.substring(0, entry.lastIndexOf('/'));
        this.logger.log(`Remote URL for '${remote}' is '${remoteUrl}'`);
        this.logger.log(`Entry for '${remote}' is '${entry}'`);
        const [, url] = remoteUrl.split('@');
        this.logger.log(`Url for '${remote}' is '${url}'`);

        return {
          origin: url ?? remoteUrl,
          remote,
        };
      }
    );

remoteUrl is actually close but is fallback in this case to url. Gonna tinker with remoteUrl , or passing an array of origins to try in the fetching of the index types file.

I think instead of
const [, url] = remoteUrl. split('@')

you can do this
const splitIndex = remoteUrl.indexOf('@')
const url = remoteUrl.substring(splitIndex + 1) // +1 to remove the '@'

This will solve the issue.


fixed doc versions

Current coverage is 100% (diff: 100%)

Merging #2084 into master will not change coverage

@@           master   #2084   diff @@
=====================================
  Files          58      58
  Lines        1134    1134
  Methods         0       0
  Messages        0       0
  Branches        0       0
=====================================
  Hits         1134    1134
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update d6bec04...7c25cbd


Human issue

When human is selected, you cant turn bot on or off even though it says that is it being turned on and off in the top left, same with lines

So?

Shouldn't that text be removed so it doesn't confuse people?

Not that important really.

Then whats the point of having the human option if you could just turn it off yourself?

If you only have the launcher and no bots, you then have human as fallback.

Ahh I understand now, so its a modular system, thats cool!


Skip Overcommit builds for JRuby

Our Travis builds fail for JRuby with a mysterious:
  Check Travis CI configuration......................[TravisLint] FAILED
  Hook raised unexpected error
  Cannot run program "travis" (in directory "/home/travis/build/brigade/overcommit"):
  error=2, No such file or directory

...and similarly for other executables, e.g. rubocop.
This appears to be specific to the JRuby runtime. Since we don't care if
Overcommit runs work on JRuby, skip Overcommit for JRuby builds.

If we don't care whether Overcommit works with JRuby, why not remove the JRuby job entirely?

I still want to run the RSpec tests, I don't care about the result of overcommit --run in JRuby.
Probably could have worded the commit message differently.


Train all steps in eval_sine_test

Ensure all steps are actually trained in eval_sine_test, even when the step isn't logged.

Hey @roschly,
Indeed! Thanks for the fix!


Fix python image name/tag for helloworld.

Needed to change the '/' to a ':' to use the tag properly.
Also switched to just :3 so we automatically get the latest 3.x.y
@jsancio PTAL

@adam-mesos, do we need this in EA2?

@jsancio Do we tell people to run helloworld? If not, then we can leave it out.
Regardless, it's a trivial fix, so might as well merge it. Doubt that it should cause a new DCOS build/version itself.

I don't think so. I will merge to master branch. EA2 is on the ea2 branch.


🐛  Bugfix cursor sometimes not shown initially.

There seems to be a bug in tip-tap that the cursor doesn't come up initially and waits for a blur event meaning a user won't have a cursor unless some other screen gets focus. this forces the blur on initialization causing the no curser issue to go away

fixes https://github.com/continuedev/continue/issues/879

@rootedbox I trust this works so going to just merge and then test myself. Thanks for tracking this down, we've been seeing it for quite a while in JetBrains, will make many users happy


Subscription triggers wrong query

Not sure if i'm missing something but here goes.
Im using Next js and when im using next/link the log says its creating a new subscription but it never listens to it.
The scenario is this:
Frontpage has a subscription, this works, from frontpage i click on a "next/link" and it shows thats its unsubscribing and creating a new subsription with the correct settings. But when the subscription should trigger it triggers the old one.
It works when not using next/link and only regular <a href

Could you create a reproduction repository please


Interested in the details of each step

:> Would like to do the same.

Hi,
I have not noticed the title of this issue before and couldn't figure out what you want. I see now.
I will try to compose some details and release them soon. Stay tuned.

please explain the steps as details as you can.
I love what you did for this project. Thank you so so much for your sharing and time.
I appreciate your work!
Keep up with your nice code!

Ok,
Here it is: https://v-iashin.github.io/how_did_you_build_my_detector


Documentation of "Specifying Dependencies" could be better

The section of the documentation of "Specifying Dependencies" is full of jargon which doesn't help explain simple concepts in dependency specification. For example, consider the first sentence of the definition of nativeBuildInputs.

A list of dependencies whose host platform is the new derivation's build platform, and target platform is the new derivation's host platform. This means a -1 host offset and 0 target offset from the new derivation's platforms.

The key detail only then follows in the next paragraph

These are programs and libraries used at build-time that

In general this whole section of the manual is filled with too much detail for the user who is not familiar with cross-compilation. I am not sure what the ASCII typing rules are also supposed to show me, from a packaging point of view I want an english description firstly about what the different fields are, which is already buried under this section.
What is important from a packaging perspective is that

nativeBuildInputs is for dependencies which are only needed at build-time
buildInputs is needed for dependencies which are needed at run-time.

Concrete suggestions for improvement

Move everything in the introduction after "It is important to note" into the section to do with cross-compilation.
Delete the jargon at the start of all the definitions of nativeBuildInputs and so on. Move it into another section if it is really important to understand.
Add some examples of typical nativeBuildInputs and buildInputs. For example, a typical nativeBuildInput is pkgconfig.

Still important to me. I recently did a PR (#108022) to address cmake being in buildInputs, however there are a lot more packages with dependencies in the wrong places.
When figuring out cross-compilation terminology, the Specifying Dependencies section in the manual wasn't enlightening either.


throttle info missing in response

I can get the data correctly, but throttle info is missing.
the following is the throttling info part in the response:
"Headers": {
"x-mws-quota-max": "unknown",
"x-mws-quota-remaining": "unknown",
"x-mws-quota-resetson": "unknown",
"x-mws-timestamp": "2020-01-06T21:23:49.390Z",
"content-type": "text/xml",
"content-charset": "unknown",
"content-length": "106281",
"content-md5": "unknown",
"date": "Mon, 06 Jan 2020 21:23:50 GMT"
}

@brandon-zeng
Yeah, for some APIs MWS is not sending throttling details.


Remove old codebase and update dependencies

Description
Remove old codebase, update all dependencies except TypeScript, migrate to Create React App/react-scripts (from the deprecated react-scripts-ts), and fix the resulting fallout.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[x] Code quality improvements

How to Test
Look at the CI test.
Checklist
Please delete options that are not relevant.

[x] I have tested this code
[x] I have updated the documentation... probably

Strange, the Travis build hanged. Happened twice already. Hmm.

I got Yarn to rewrite yarn.lock, which removed about 200 duplicate dependencies.


Focus area proposal: Reputation

The importance of focus areas came up in today's meeting, which centered on #76 & #77. We got close to defining Goal -> Metric -> Questions approach around understanding external voice.
The term Reputation comes to mind as a commonly understood category that covers the goals of these metric.

The question for others here: does it make sense under our current charter?
If yes, what questions follow?

The desired outcome for this issue is to do the following:

[ ] Discuss whether Reputation is a worthwhile area of focus for Value
[ ] If yes, resolve this issue by opening a PR similar structure to D&I's with:

[ ] A table of focus areas
[ ] Goals for Reputation
[ ] Subdirectory with a table of questions to be answered by metrics

Thanks for this @mbbroberg
Yes, I believe Reputation is a great name for a focus area. Short and simple.

Agreed.
Samantha Venia Logan
Co-Founder of SociallyConstructed.Online
307-274-5516  |<EMAIL_ADDRESS>6715 Autumn Ridge Dr. Unit 2, Fort Collins CO., 80525
Call me for a free marketing consultation!<PHONE_NUMBER>
On Thu, May 7, 2020 at 10:43 AM Matt Germonprez<EMAIL_ADDRESS>wrote:

Thanks for this @mbbroberg https://github.com/mbbroberg
Yes, I believe Reputation is a great name for a focus area. Short and
simple.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chaoss/wg-value/issues/84#issuecomment-625368136, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANBRVR5JKE6MYX7623YSLCDRQLQMVANCNFSM4M3OX3VA
.

Closing this in favor of #93


Adjust testing environment

Dist is also broken on main and dev

Given our talks about Mocks I expected to see some mocking of the PandA-client calls and validating that they have received the messages that we previously saw in the dummy server.

I've now passed a multiprocessing.Queue to the MockedAsyncioClient so any command it receives from the softioc is put there and can be retrieved in tests.


Changes to support ixctl member ports

physical_ports join on Port service bridge
allow assigning multiple devices to logical ports
add port to virtual port serializer

needed for https://github.com/fullctl/ixctl/pull/97

Codecov Report

Merging #45 (969edb1) into prep-release (4622337) will decrease coverage by 0.31%.
The diff coverage is 16.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@               Coverage Diff                @@
##           prep-release      #45      +/-   ##
================================================
- Coverage         28.10%   27.80%   -0.31%
================================================
  Files                47       47
  Lines              1715     1748      +33
================================================
+ Hits                482      486       +4
- Misses             1233     1262      +29

Impacted Files
Coverage Δ

src/django_devicectl/rest/serializers/devicectl.py
0.00% <0.00%> (ø)

...jango_devicectl/rest/serializers/service_bridge.py
0.00% <0.00%> (ø)

src/django_devicectl/rest/views/devicectl.py
0.00% <0.00%> (ø)

src/django_devicectl/rest/views/service_bridge.py
0.00% <ø> (ø)

src/django_devicectl/signals.py
40.00% <40.00%> (-10.00%)
:arrow_down:

src/django_devicectl/models/devicectl.py
55.52% <50.00%> (-0.06%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Labels should not be on a separate tab

Simply list them under the title for a particular tool

https://github.com/ga4gh/dockstore-ui/pull/39


Popup added status?

@kodeeey Do you wtill want to show info for how many players are added in the popup?
btw did some code cleanup yesterday, it looks pretty neat too

Some more detailed info e.g. captain, player and class status would be good.


gql.tada not working in Nitro server routes but works perfectly fine in Vue part

Environment
Stackblitz
------------------------------
- Operating System: Linux
- Node Version:     v18.18.0
- Nuxt Version:     3.11.1
- CLI Version:      3.11.0
- Nitro Version:    -
- Package Manager<EMAIL_ADDRESS>- Builder:          -
- User Config:      devtools, typescript
- Runtime Modules:  -
- Build Modules:    -
------------------------------

Reproduction
https://stackblitz.com/github/martinszeltins/nuxt-gql-tada-test?file=app.vue
Describe the bug
The gql.tada library seems to be working fine in the Vue part of the app but does not work in server API routes. This might have something to do with how Nitro handles typescript or something with tsconfig.json, I am not sure exactly.
The gql.tada library provides autocompletion and other goodies when working with TypeScript and GraphQL.
Note: You might need to run the reproduction locally to see gql.tada in action.
Here is a screenshot from app.vue and we can see that gql.tada is doing it's magic and it is working:

And here is a screenshot from server/api/users.get.ts Nitro route and it does not work there:

Additional context
No response
Logs
No response

Oh, my fault. I also needed to add the plugins to nitro tsconfig:
export default defineNuxtConfig({
    devtools: { enabled: true },

    typescript: {
        tsConfig: {
            compilerOptions: {
                plugins: [{
                    "name": "@0no-co/graphqlsp",
                    "schema": "https://graphqlzero.almansi.me/api",
                    "tadaOutputLocation": "../graphql-env.d.ts"
                }]
            }
        }
    },

+    nitro: {
+        typescript: {
+            tsConfig: {
+                compilerOptions: {
+                    plugins: [{
+                        "name": "@0no-co/graphqlsp",
+                        "schema": "https://graphqlzero.almansi.me/api",
+                        "tadaOutputLocation": "./graphql-env.d.ts"
+                   }]
+                }
+            }
+        },
+    }
+})


Add All TB Clients Table in the Tuberculosis Treatment dashboard

Requirements

[ ] This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
[ ] My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

This is what is displaying so far. We need to fetch the patients enrolled to the TB Program only.


Fixing the link in the button

Redirecting to Github page on Contributor button click.
Closes: #75
Proposed changes
Added the link tag in contributor.html file.
Types of changes
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] My changes does not break the current system and it passes all the current test cases.

Screenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request

@umar07 Code changes looks fine to me. Need to test once before merge.

Looks good to me :+1:
Thank you @umar07 for contributing to this project.

@all-contributors please add @umar07 for code


Fix bug where MSVC linker flags were not handled properly

Clang and GCC's -Wl argument can be used to pass arguments to the linker.
MSVC, however, does not recognize this option and instead uses a
/link flag at the end of all other arguments for this purpose. This commit
makes use of "/link" with MSVC when LDFLAGS are used.
A test was added that verifies this functionality by setting the
executable's stack size and verifying the change from the generated
executable.
Fixes #8

Fixed in #26


Court name errors

I was using Eyecite this evening and came across some very odd behavior. I tried to parse the citation Commonwealth v. Muniz, 164 A.3d 1189 (Pa. 2017). For whatever reason, Eyecite determined that the court was "paarbpnlhc" which is the courts_db id for the Pa. Arbitration Panels for Health Care. In courts_db, the citation_string "Pa." is correctly listed under the Supreme Court. I then poked around and determined that it is doing something similar with other courts of last resort. For example, Eyecite treats citations to the Virginia Supreme Court ("Va.") as if they were to the Virginia Court of Appeals ("Va. Ct. App."). It also treats cites to the Texas Supreme Court, "Tex.", as cites to the Texas Special Court of Review ("Tex. Rev.").
I think the problem is that the get_court_by_paren function in helpers.py looks for a citation_string from courts_db which merely starts with the court abbreviation from the citation parenthetical (line 52). Can we require that the whole citation_string matches the whole of court_str? If not, is there a reasonable way to get the shortest citation_string from courts_db which starts with court_str without it taking forever? Perhaps we can put all of the courts_db citation_strings into a set, test whether court_str is present in the set and then, if not, extract all set items which include court_str, test their length, and return the shortest?
I should have time to take a crack at this later in the week unless somebody else either wants to do it or can get to it first.

This looks like a nasty one. @bbernicker please let us know if you don't have time to get to this so we can get @flooie cracking on it.

@mlissner it turned out not to be too hard to fix and I think I have it sorted out. I also added an extra test to make sure that eyecite is detecting the correct court.


designspaceLib remove checkDefault, checkAxes

remove checkDefault, checkAxes and any kind of guessing about the axes. The default is the master located at the default value of all axes.
add findDefault returns the sourceDescriptor for the default.
stray conditions are wrapped in a conditionset when reading.
add some tests.

Sorry, some tests are failing.

Please remember that varLib is not the only consumer of designspaces. There are still a lot of files out there that rely copyInfo flags. I will make changes to Superpolator and ufoProcessor but those effects won't be immediate.

Yes, I understand that. But I thought we said we would use copyInfo only when axes wheren't defined.
How will other designspace consumers deal with a master that says "I'm the default" but the axes elements say "no, she is lying"?

Ok, what if findDefault only returns the proper default-on-axes. ?

what if findDefault only returns the proper default-on-axes?

yes, or None if none could be found.


Adaptive batch size updates from research codebase

Codecov Report

Merging #79 (e225218) into master (1b7f502) will increase coverage by 0.04%.
The diff coverage is 89.94%.

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   61.25%   61.29%   +0.04%
==========================================
  Files          30       30
  Lines        2243     2266      +23
  Branches      338      342       +4
==========================================
+ Hits         1374     1389      +15
- Misses        805      809       +4
- Partials       64       68       +4

Impacted Files
Coverage Δ

adaptdl/adaptdl/torch/adascale.py
88.12% <86.04%> (-6.04%)
:arrow_down:

adaptdl/adaptdl/torch/parallel.py
68.18% <90.00%> (+4.74%)
:arrow_up:

adaptdl/adaptdl/goodput.py
97.52% <90.90%> (+0.06%)
:arrow_up:

adaptdl/adaptdl/torch/data.py
77.32% <90.90%> (+0.80%)
:arrow_up:

adaptdl/adaptdl/torch/_metrics.py
80.80% <100.00%> (+0.31%)
:arrow_up:

adaptdl/adaptdl/torch/iterator.py
83.87% <100.00%> (ø)

adaptdl/adaptdl/reducer.py
88.00% <0.00%> (-2.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7f502...e225218. Read the comment docs.