Added new Vyper Highlighter and Desktop Version Using Electron

Added a Load file button, and drag and drop capability to load a file.
Replaced the Python Highlighter with a custom Vyper Highlighter.
Added Node.js and Electron.js to create a desktop version.
Added download link for Desktop versions for all platforms.
UI improvements and a new favicon.

Hi Ben, you have to be a bit more careful on what you are committing and pre-check your commit with git status, you have added all the node_modules within this commit.

Sorry for that, I removed the node modules directory.
I still don't know why GitHub gives me conflicts as I did pulled the newest version before (might didn't pulled correctly?)

Yes, actually I have to stop you a bit.
Something like this (adding all the node_modules) can't be reverted by another commit. This will still be in the commit history and gives to much bloat to the repository.
Generally: Please separate all functionality which is distinct/not overlapping into separate pull requests. This will otherwise get far too difficult to review and also mixes up discussion on features.
The Favicon is the only thing I would accept here as an addition to an existing PR, cause it's such a tiny change.
All other things should be handled separately:

Load Button + File load
Vyper Highlighter
Electron support

This will also make things like resolving conflicts GitHub is showing far easier.

You can actually see this when you go to the GitHub page of your fork and switch to your beta branch that the fork branch is behind the latest commits from the original repository:
https://github.com/BenKaufman10/editor/tree/beta

Alright, sorry, I am still not used to GitHub. I'll try my best with it and still want to contribute to the project but I will probably still have mistakes using Git.
So for now you want me to separate each feature to its own branch, push 3 new PRs (one for each feature/ branch) and remove the last 2 commits with the nodes_module folder.
I let me check how I do it, if you have any resource explaining that it can be good.
For now should I close this PR?

I know this is a bit annoying and one is probably saying "URgh" on such a comment on first sight.
But I would advise you for this time to start a bit from scratch.  Then clone the repository again, do a new feature branch, e.g. vyper-highlighter and manually re-add the changes there. Then push your branch and submit a PR. I will try to review quickly.
After that make sure that you update your master branch with the changes merged and start a new branch with the next feature.

Will do so, thanks.


Dataimporter

Fix a bug on csv/tsv importer.

@Wentao-Xu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@Wentao-Xu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


nbdev_clean: Add trailing newlines to mask diff between Jupyter and VSCode

Jupyter adds a trailing \n to images in cell outputs. Vscode-jupyter does not.
Notebooks should be brought to a common style by nbdev_clean to avoid unnecessary diffs.

Looks good - thanks!


SlideをEditで動かすとエラーになる

foreach中に要素消したようなエラーだけど、果たして？
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
   at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
   at System.Linq.Enumerable.OfTypeIterator[TResult](IEnumerable source)+MoveNext()
   at osu.Game.Rulesets.Sentakki.Edit.SentakkiSelectionHandler.HandleMovement(MoveSelectionEvent moveEvent)
   at osu.Game.Screens.Edit.Compose.Components.BlueprintContainer.moveCurrentSelection(DragEvent e) in C:\Users\*\Downloads\osu-master\osu-master\osu.Game\Screens\Edit\Compose\Components\BlueprintContainer.cs:line 490
   at osu.Game.Screens.Edit.Compose.Components.BlueprintContainer.OnDrag(DragEvent e) in C:\Users\*\Downloads\osu-master\osu-master\osu.Game\Screens\Edit\Compose\Components\BlueprintContainer.cs:line 214
   at osu.Framework.Graphics.Drawable.TriggerEvent(UIEvent e)
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)

そもそもslideの実装がよくわからんしプレイ画面に出てこない、自分で作ってみたほうが良いかも

そもそもslideの実装がよくわからんしプレイ画面に出てこない、自分で作ってみたほうが良いかも

If possible, could you mention such issues on the main PR for the editor, it'll be more visible for me and will allow me to perform fixes on my end.
可能であれば、エディターのメインPRでそのような問題について言及していただければ、それは私にとってより目立つようになり、私の側で修正を実行できるようになります。 - thx Google translate

If possible, could you mention such issues on the main PR for the editor, it'll be more visible for me and will allow me to perform fixes on my end.
可能であれば、エディターのメインPRでそのような問題について言及していただければ、それは私にとってより目立つようになり、私の側で修正を実行できるようになります。 - thx Google translate

This also happen on all note types.

This also happen on all note types.

If possible, could you mention such issues on the main PR for the editor, it'll be more visible for me and will allow me to perform fixes on my end.
可能であれば、エディターのメインPRでそのような問題について言及していただければ、それは私にとってより目立つようになり、私の側で修正を実行できるようになります。 - thx Google translate

Sure! (but im new to github. sorry if could not PR)
and, I had to modify some files of osu!lazer to access the Editor. You do that, too?

If possible, could you mention such issues on the main PR for the editor, it'll be more visible for me and will allow me to perform fixes on my end.
可能であれば、エディターのメインPRでそのような問題について言及していただければ、それは私にとってより目立つようになり、私の側で修正を実行できるようになります。 - thx Google translate

Sure! (but im new to github. sorry if could not PR)
and, I had to modify some files of osu!lazer to access the Editor. You do that, too?

The editor is currently unusable outside of the test interface. The test interface is easily accessible by starting the test project and should look like this.
エディターは現在、テストインターフェイスの外部では使用できません。 テストインターフェイスは、テストプロジェクトを開始することで簡単にアクセスでき、次のようになります。

(I'm not good at japanese, so the translation may be wrong :P)

The editor is currently unusable outside of the test interface. The test interface is easily accessible by starting the test project and should look like this.
エディターは現在、テストインターフェイスの外部では使用できません。 テストインターフェイスは、テストプロジェクトを開始することで簡単にアクセスでき、次のようになります。

(I'm not good at japanese, so the translation may be wrong :P)

I got this screen first, but I didn't know how to use it and ignored it. XD
(im new to osu!lazer too)
Thank you for helping me :)
教えてくれてありがとうございます。

I got this screen first, but I didn't know how to use it and ignored it. XD
(im new to osu!lazer too)
Thank you for helping me :)
教えてくれてありがとうございます。

Come join us in the discord channel, it's easier to discuss stuff there. :)

Come join us in the discord channel, it's easier to discuss stuff there. :)

Come join us in the discord channel, it's easier to discuss stuff there. :)
ah I already joined that :) but did not speak. (cuz english is not first lang :X)

Can I post this Issue to your Repo Issue? Sure! I said, but there is no guarantee that it can be fixed.

Come join us in the discord channel, it's easier to discuss stuff there. :)
ah I already joined that :) but did not speak. (cuz english is not first lang :X)

Can I post this Issue to your Repo Issue? Sure! I said, but there is no guarantee that it can be fixed.

ah I already joined that :) but did not speak. (cuz english is not first lang :X)
No worries, we don't really mind

Can I post this Issue to your Repo Issue? Sure! I said, but there is no guarantee that it can be fixed.
Don't worry, I'm currently looking into it as well :)

ah I already joined that :) but did not speak. (cuz english is not first lang :X)
No worries, we don't really mind

Can I post this Issue to your Repo Issue? Sure! I said, but there is no guarantee that it can be fixed.
Don't worry, I'm currently looking into it as well :)


Add ecode and some modification in log message for alert generation

New Log format with key-value pairs
Add ecode, reason, and msg for alert generation.

Sample Log:
ERRO[0047] msg="AddReplica in createReplica failed" reason="can't add tcp://<IP_ADDRESS>:9502, error: REPLICATION_FACTOR not set"  ecode=jiva.create.replica.failed

Signed-off-by: Sumit Lalwani<EMAIL_ADDRESS>

@slalwani97 kindly close this PR as it will be address in #243


Add Doomfist to Team Composition and Hero Pool

Adding this here for when Doomfist goes live. This wasn't in our original scope, so it's a nice to have.
P.S. Thanks for adding Orisa! I don't know when that happened, but thanks!

We'll need Doomfist's portrait and he'll need to be added to seeds.rb.


Fix INC/DEC (HL), RETI and LDH A, (C)

With this, almost all tests pass now! The only one missing is 02-interrupt, but that needs at least the timer peripheral. I will take a look at that later, and if possible, I will implement a hacky timer in the Bogus_HW. Otherwise, I will just see if I can run a couple more tests from mooneye-gb and then proceed to integrate dmgcpu into @msinger's dmg-sim.
In this PR, I fixed three instructions:

INC/DEC (HL): The only problem was a priority issue in the code I had implemented for the DataMux.v. I just reordered the ternary operators to make Res_to_DL have priority over the WR branch.
RETI/EI: The interrupt handling had an issue where it was triggering immediately after enabling interrupts, even though there weren't any. The problem was a missing not in the ack signal. Now the Verilog code is aligned with the circuit drawing in the wiki.
LDH A, (C): There was a conflict in the dbus, where two inputs to the bus were enabled, 0 and the B register. Looking at those traces, I could tell that the 0 overwrites any other signal, so I implemented that in the Verilog and left a comment. Let me know if you prefer another way to solve it.

I implemented the timer today, and now the 02-interrupts.mem test passes!
However, I had to fix one more issue with the interrupt handling. Specifically, I replaced ienq with ieq in the input of the IF register. I couldn't read the circuit traces well enough to determine if this fix makes sense, so I'll have to rely on you again.
-module8 IF [7:0] ( .clk({8{CLK3}}), .cclk({8{CLK4}}), .d(~(ienq&CPU_IRQ_TRIG)), .q(ifq), .nq(ifnq) );
+module8 IF [7:0] ( .clk({8{CLK3}}), .cclk({8{CLK4}}), .d(~(ieq&CPU_IRQ_TRIG)), .q(ifq), .nq(ifnq) );

Next, I'll run the entire cpu_instrs.mem test, and then some tests from mooneye-gb.


modifyScrollWheel behavior

Hi, I dont want to use default fractional zooming so I am using modifyScrollWheel set to false. The thing is when its set to false, when I zoom the tangram layer content is like quickly jumping between zoom levels, which is little bit undesirable.

In version 0.11.6 its working fine, without content jumping:

Is it possible to somehow get it working like in 0.11.6?

Hi @michaelhornak! For clarification, the lines and points are the Tangram layer, and there's a raster layer behind it (looks like Positron), right? Are you layering the raster layer behind the vector data as a separate Leaflet layer, or as a raster layer in Tangram?
In the top gif it looks like Tangram is jumping between whole integer zoom levels, but the raster layer is still using fractional zooms, or possibly animating between zooms. Is your goal to have the raster layer jump like the vector layer, or for the vector layer to animate like the raster layer?
And lastly: do you happen to have an example scene we can check out? If not we can likely set one up here.

Hi, yes, lines and points are Tangram layer. The positron raster is a separate Leaflet layer. In both examples I have set in map modifyScrollWheel to false. My goal is to have raster jump like the vector like in the second example.
There is example site to a first gif http://flww_tangram2.ai-maps.com/
There is example site to a second gif http://flww_tangram.ai-maps.com/

Hi @michaelhornak, thanks for the examples.
I believe what's happening here is that Leaflet is applying CSS transitions (for the zoom animation) to your raster layer. Tangram can't use CSS transitions (since it's a WebGL canvas) and I haven't yet found a good way to link the Tangram view to a Leaflet CSS animation (but it warrants further research).
In the meantime, I think you can achieve your desired results by setting zoomAnimation: false option on your Leaflet map instance (not a Tangram layer setting):
http://leafletjs.com/reference-1.0.3.html#map-zoomanimation
The reason you see a difference with the older Tangram version is that we used to force-disable Leaflet animations on the whole map (for this and other issues), but concluded it is better to not force the modification of map-wide parameters where possible. Incidentally, you also likely do not need to have the Tangram option modifyScrollWheel: false, I believe it should be a separate issue from what you are experiencing with Leaflet zoom animations. It shouldn't hurt anything either though.

thanks very much, this is all I 've needed!


Support TLS on SBI

For wireshark, it provide an option to decode TLS on HTTP2 if we provide the key file.
https://github.com/free5gc/free5gc/wiki/Trouble_Shooting#6-decode-http2-packet-in-wireshark
I'm wondering if 5g-trace-visualizer is consider to support decoding encrypting SBI maybe using this feature in wireshark.

If it can be done via tshark, then it would be easy to implement. The applicaiton does not parse the packets, rather generates a call to tshark, which dissects the packets and generates an XML file (PDML file) that is used for creating the diagram.
If you can send me an example including traces and the tshark command you use, it can be added. We did not have the issue (yet), so we did not need that yet.

Here is the TLS version pcap file and keylog
free5gc_tls.zip
keylog.zip
I think tshark also support decrypt TLS as following link.
https://minnmyatsoe.com/2016/01/26/using-tshark-to-decrypt-ssl-tls-packets/
But I didn't test it, so I'm not for sure.

From what I can see, the application would not have enough information to do anything with those logs (to what connection should that apply to?). The website you pointed to also uses the certificates additionally to the logged secrets.
For me, it would be quite difficult to implement a solution given that I cannot test it and I have no idea how to do this for a trace containing multiple TLS connections.
What I can offer you is that if you can provide me a working decoding using tshark, I can add those steps to the application. The application is in the end little more than an automated call to tshark and then to PlantUML, so that should work.


Upgrade to FFTM v1.2.2

Signed-off-by: Nicko Guyer<EMAIL_ADDRESS>

Codecov Report

Merging #49 (80338a2) into main (d1cfccb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   97.62%   97.62%
=======================================
  Files          23       23
  Lines        1391     1391
=======================================
  Hits         1358     1358
  Misses         25       25
  Partials        8        8

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add thumbSize as a prop (or even thumbStyle)

Only thumbTintColor offers too little flexibility - thumbSize is needed
The size of the thumb can NOT be controlled without affecting the whole slider. On iOS the thumb is significantly bigger than on Android. Even by adding a thumb image scales different from one platform to another. At this point there is no way to apply a fixed thumb size for consistency over the two platforms.

this PR takes care of this for the web implementation if it gets merged. There would be only the native implementation to be done.

By the way, there could be a quick fix for this: the web implementation should be working perfectly fine for native too, so we could just use the web implementation as the universal implementation. What do you think @michalchudziak ? Of course we would need to ensure that no feature provided by the current native implementation is missing. But is this a path that would be acceptable?

@michalchudziak? Your opinion about it?

+1

Curious where this stands for mobile - would be a helpful feature. Thanks for your contributions toward it!

Actually I'm working on a fully compatible RN + RNWeb version with all the pending feature request I found here. I'm just having some trouble finding some time these 2 weeks to conclude it but you can give it a try. It is npm i -S @sharcoux/slider
If you encounter any trouble you can tell me. It will make me save time when I'm finishing it.

+1

The lack of traction on this issue is surprising to me; This seems critical for anyone who intends to use this slider across multiple platforms and cares for consistency...

+1

Please we need a fix thumb value for android and ios

+1

+1

@raphaelrupprecht @arthur-vargas @ShivamJoker if you need something for now, just try @sharcoux/slider from npm. It is open source and used and maintained by my company. You can ask if you have issues.

In addition to thumbsize support another deal breaker is the ghastly box shadow thats on the thumb handle by default. There should be a way to remove that or just support style prop and call it a day!

+1

+1

+1

+1

+1

+1

+1

1

+1

Hello,
I've also this issue. Something is already in progress to allow this ? Thanks

I would like to keep it as one feature request opened in #40.
I will close this one, but please keep the track in the mentioned issue.

+1

Quick Wanna-Be-Fix
Anyone who want to stick to the native sliders and only needs to adjust their thumb size by 10-20% at max, can have a look this short workaround. It provides the following:

rescales the entire slider based on the thumbSize prop, meaning the thumb AND the track will be resized
thumbSize tries to approximate the wanted pixel size for iOS and Android, but obviously it's just a hack
rescaling leads to unwanted padding effects which can be compensated for on the "critical side" with alignScaledSlider
I experienced some buggy thumb jumping effects after fast sliding gestures. I don't know if that was due to my own code, but ScaledSlider also fixes that - in case you also encountered those issues...
all SliderProps are fully functional, just be careful with the style prop

Hopefully that's helpful for some of you, it's doing the job for me... enjoy!
import Slider, { SliderProps } from "@react-native-community/slider";
import React, { useCallback, useMemo, useState } from "react";
import { LayoutChangeEvent, Platform, StyleProp, StyleSheet, View, ViewStyle } from "react-native";

type ScaledSliderAlignment = "left" | "center" | "right"

export interface ScaledSliderProps extends SliderProps {
  /**
   * The scaled slider shows a unwanted padding effect when scaled.
   * Choose the alignment to compensate for this effect on the chossen side,
   * e.g. when alignScaledSlider="right", the slider will show no unwanted padding
   *  to the right.
   * @default "center"
   */
  alignScaledSlider?: ScaledSliderAlignment
  /**
   * Approximated size of the thumb in pixels.
   * HACKTTENTION: The thumb size also affects the the slider length & height!!!
   * These effects will have to be accounted for during styling... it's just a hack.
   */
  thumbSize?: number
}

// This defines how well the `thumbSize` prop approximates the actual pixel value.
// In case you realize e.g. that the thumb appears smaller than `thumbSize` decrease
// `defaultThumbSize...` slightly.
const defaultThumbSize = Platform.OS === "android" ? 15 : 20;

export const ScaledSlider: React.FC<ScaledSliderProps> = (props) => {
  const {
    alignScaledSlider = "center",
    onSlidingComplete,
    style,
    thumbSize,
    value,
    ...restProps
  } = props

  const [sliderValue, setSliderValue] = useState<number | undefined>(value)
  const [sliderWidth, setSliderWidth] = useState<number | undefined>(undefined)

  // Scale with which the slider will be transformed
  const scale: number = useMemo(() => thumbSize
    ? thumbSize / defaultThumbSize
    : 1,
    [thumbSize])

  const $flattenedStyle = useMemo(() => StyleSheet.flatten(style), [style])

  const _onLayout = useCallback((event: LayoutChangeEvent) => {
    setSliderWidth(event.nativeEvent.layout.width)
  }, [])

  // BUGFIX: On fast sliding, the slider does not jump around anymore after sliding is completed
  const _onSlidingComplete = useCallback((val: number) => {
    setSliderValue(val)
    onSlidingComplete?.(val)
  }, [value])

  // After scaling, the slider shows unwanted padding effects which can be compensated at
  // least on one side that can be chosen by `alignScaledSlider`.
  const $paddingCompensation: ViewStyle = useMemo(() => (alignScaledSlider !== "center"
    ? {
      [alignScaledSlider]: (sliderWidth !== undefined
        ? - sliderWidth * (1 - scale) / 2 // compensation for unwanted "padding-effect" from scaling
        : 0) + (typeof $flattenedStyle.right === 'number' ? $flattenedStyle.right : 0),
    }
    : {}
  ), [sliderWidth, scale, style])

  const $style: StyleProp<ViewStyle> = useMemo(() => ([{
    ...$paddingCompensation,
    transform: [{ scale }],
    width: "40%"
  }, style, { width: "100%" }]
  ), [sliderWidth, style])

  return (
    <View style={{ width: $flattenedStyle.width }} onLayout={_onLayout}>
      <Slider
        style={$style}
        onSlidingComplete={_onSlidingComplete}
        value={sliderValue}
        {...restProps}
      />
    </View>
  )
}


Add ability to identify min_python version

@RonnyPfannschmidt Please review. After implementing this, I will add one method for generating the JSON for GHA test matrix.

Any suggestions? I would prefer to keep usage as simple as possible. Initially i was considering avoiding a class but sooner or later we will want to read other info about the project.

Use named constructors and/or a global construction function


Create and get schema by http proxy

https://github.com/futurewei-cloud/chogori-platform/issues/273

@jfunston @iafuture The PR is ready for review.

Also added create collection api


pull request for e2e test at 01/28/2017 09:45:16

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Does this work with the ionic-cards directive?

want to lazy load the images in the card stack.
thanks

I also tried to do that...when I tested on browser locally on my PC works fine but when I tried on the phone (android device) I'm not able to see the picture because it's display an infinite load spinner. Did you manage to find a solution?


consider genshi.builder-like element nesting syntax

JustPy is currently using a bit cumbersome wp=jp.WebPage(); jp.Label(a=wp,...), jp.XYZ(a=wp...) syntax. genshi.builder expresses nesting conveniently as *args which can be passed to every element and defines its children. The way, one could write
wp=WebPage(
   jp.Label(...),
   jp.XYZ(...),
   jp.P('some text',jp.B('this is bold'),'continues here),
)

which is both simpler to write (no repeated a=wp) and makes the structure immediately visible, especially when nesting.

The format JustPy currently supports for this: https://justpy.io/reference/htmlcomponent/#children
Does this help?

Thank you, it helps. I only saw the a=wp in the tutorial and thought that we as good as it get; named argument is not as elegant as having *children arg in each ctor, but definitely better than a=wp everwhere.
WebPage could also take children (or *children) for inuitivness, though one extra Div is doable :).
Feel free to close the issue if adding *children is deemed a wontfix.


Update msc-pygeoapi-config.yml

Change AHCCD, DCS and CMIP5

Thanks a lot for the changes @cpomer10 . Since You also updated some of the features description, I am assigning the pull request to @tomkralidis


Update bar_chart_sample1.dart

The parameter duration for BarChart isn't defined, so  duration has been changed to swapAnimationDuration.

swapAnimationDuration is deprecated (since 0.69.2). So you should use duration from now on.


Update 0019-third-party-manufacturers.md

Afaik this is actually true now, so I'm going to fix the 2-4 to say 2-5 and go ahead and merge


its not convert @depend

first of all i want say thanks to your great project i've used it in one of my old project and it just worked great the only problem that i had was converting phpunit @depends.
it's a little bit tricky since u can't get them directly in pestphp and u need collect them as array of args using get_function_args or ...$args in the function definition

Hey, thanks for the report.
I will check it out as soon as I have some free time.


gobby5: unstable-2018-04-03 -> unstable-2020-12-29

Motivation for this change
The gobby project recently addressed a denial of service vector in their application.
I've kindly asked them to do another release tag: https://github.com/gobby/gobby/issues/188
The issue was reported here: https://github.com/gobby/gobby/issues/183
The issue was fixed here: https://github.com/gobby/gobby/pull/184
Fixes: CVE-2020-35450
@jtojnar Any idea why you named this package gobby5 and not just gobby?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

It was already named like that when I fixed it in https://github.com/NixOS/nixpkgs/pull/44651. The renaming seems to come from https://github.com/NixOS/nixpkgs/commit/ef403beb481ef81512cc9b25ac692625ce3b4105.

It was already named like that when I fixed it in https://github.com/NixOS/nixpkgs/pull/44651. The renaming seems to come from https://github.com/NixOS/nixpkgs/commit/ef403beb481ef81512cc9b25ac692625ce3b4105.


Add random vector generator

Features

sampling 1D vector with given single domain
Sampling 1D vector with individual domains

Add feature : Sampling a vector from a list of sampler (containing domains)
https://github.com/stevengogogo/FindSteadyStates.jl/commit/2c3b2f8fbe313f3b31afbd023727bf53e3e54ea9

Random sampler should be in the form of the generator like grid search


Fix space leaks in scan/scanM

This is my proposed solution for #137. It doesn't break backwards compatibility and instead just uses lazy StateT under the hood, which unfortunately makes the implementation look a little weird. But it would be simple to follow up with the (breaking) interface change that resolves this.

Hmmm, it looks like there is a Travis bug causing it to not report the status of the PR, but it passed (https://travis-ci.org/github/Gabriel439/Haskell-Foldl-Library/builds/733566401), so I'll go ahead and merge this for now.


Parsing issue with segment split

The segments parsing logic failed at a client site because the segment string had a leading segment delimiter. In this case, "~ST*835*12345", which broke the split into array.
The source files were wrapped (no cr/lf) with segment delimiter of ~

Issue addressed in re-write


Deployment of test artifacts instead of build artifacts

Hi
I am getting an error while deploying a gatsby site through amplify console. Instead of pushing the build artifacts to the amplify site, the workflow is pushing the test artifacts.
I am using a monorepo structure, and doing a gatsby build for frontend. Post build I need to run Lighthouse analysis and Structured data tests and access their results from console and then proceed with the deployment of website. Below is my amplify.yml. Could you please take and look. Am I doing anything wrong here ?
`version: 1
applications:

appRoot: packages/web
frontend:
phases:
preBuild:
commands:
- npm ci
build:
commands:
- npm run build
artifacts:
baseDirectory: public
files:
- "/*"
cache:
paths:
- node_modules//*
test:
phases:
preTest:
commands:
- mkdir -p ci-test/lhci
- mkdir -p ci-test/sdtt
test:
commands:
- npm install -g @lhci/cli
- lhci autorun --config=./lighthouserc.json
- npm install -g structured-data-testing-tool
- find ./public -name .html -exec bash -c 'sdtt --file "${0}" -p Twitter,Facebook,SocialMedia -o ci-test/sdtt/"${0//[./]/-}".txt' {} ;
artifacts:
baseDirectory: ci-test
files:
- "**/"`

Hi @abhishek-sapient -- can you please share your appId and region?

Hi @gwryssekk  -
region - eu-west-1
app id - d36e86hd4onh9w

Hi @gwryssekk
With some help from AWS support team, I was able to get the application deployed. Adding a dummy configFilePath entry in test artifacts section solved the deployment issue, although its not useful for my project since I am not running cypress test cases.
This is how my amplify.yml looks now
test:
phases:
preTest:
commands:
- mkdir -p ci-test/lhci
- mkdir -p ci-test/sdtt
test:
commands:
- echo -------------- Run Sonar  -------------
- npm install -g sonarqube-scanner
- sonar-scanner -Dsonar.login=XXX-Dsonar.host.url=https://xxxx/ -Dsonar.projectKey=xxx -Dsonar.projectName=xxx -Dsonar.sources=./public -D:sonar.scm.disabled=true && pwd
- echo ------------- Run Lighthouse -------------
- npm install -g @lhci/cli
- lhci autorun --config=./lighthouserc.json
- echo ------------- Run SDTT -------------
- npm install -g structured-data-testing-tool
- find ./public -type f -name .html -exec bash -c 'sdtt --file "${0}" -p Twitter,Facebook,SocialMedia -o ci-test/sdtt/"${0//[./]/-}".txt' {} ;
artifacts:
baseDirectory: public
configFilePath: assertion-results.json
files:
- "**/"
Amplify E2E Documentation says "You can use the test step to run any test commands at build time" however it seems its amplify yml is currently tied to cypress and mocha reports only. In my app I don't have any cypress test cases to run and I just want to just validate few basic CI tests for performance and accessibility etc using lighthouse in the test phase before deployment.
Could you please also help me out with few queries -

I am able to generate some custom reports in a ci-test folder, how I can make this folder available in the artifacts without deploying it on the actual website. Is there any storage for these artifacts available which is tied with the build or I will have to write own script to upload and push at some other location like s3?

How can I make the test phase fail without using cypress ?

Does Amplify provides abiliy to customize the Verify stage if I want to run certain actions post deployment ?

Thanks
Abhishek

Hi @gwryssekk -
I have hit a blocker again on this, where the deployment phase is getting stuck. Could you please update us on the queries and help me resolve this issue. Below are the details you may need
region - eu-west-1
app id - d36e86hd4onh9w
`version: 1
applications:

appRoot: packages/web
frontend:
phases:
preBuild:
commands:
- npm ci
build:
commands:
- echo ------------- Build Web App -------------
- npm run build
artifacts:
baseDirectory: public
files:
- "/*"
cache:
paths:
- node_modules//*
test:
phases:
preTest:
commands:
- mkdir -p ci-test/lhci
- mkdir -p ci-test/sdtt
test:
commands:
- echo -------------- Run Sonar  -------------
- npm install -g sonarqube-scanner
- sonar-scanner -Dsonar.login=XXXXXXXXX -Dsonar.host.url=https://XXXXXXX/ -Dsonar.projectKey=bcp_canada -Dsonar.projectName=bcp_canada -Dsonar.sources=./public -D:sonar.scm.disabled=true && pwd
- echo ------------- Run Lighthouse -------------
- npm install -g @lhci/cli
- lhci autorun --config=./lighthouserc.json
- echo ------------- Run SDTT -------------
- npm install -g structured-data-testing-tool
- find ./public -type f -name .html -exec bash -c 'sdtt --file "${0}" -p Twitter,Facebook,SocialMedia -o ci-test/sdtt/"${0//[./]/-}".txt' {} ;
artifacts:
baseDirectory: public
configFilePath: ci-test
files:
- "**/"
`

@abhishek-sapient the logs will show test artifacts being deployed, but your deployment should work fine now.


Update GitHub template for issues. Do not ask for az version

Since az is no longer required, we should not ask for it at the top

/check-enforcer override


Relative links to pdfs not working with hosted pdf.js and demo viewer

Links to PDF files:
Annotation Links:

From #6616

Document Outline Item Links:

Relative pdf link bookmark.pdf

Configuration:

Web browser and its version: Chrome 60.0.3112.90 / Firefox 54.0.1 / Edge 40.15063.0.0
Operating system and its version: Windows 10 version 1703 (10.0.15063)
PDF.js version: v1.8.188 (Issue also occurs with earlier versions)

Relative links to other pdfs (both document outline items and link annotations in the document) do not work when the pdf.js project (with the demo viewer) is hosted on a local or non-local server. The href attribute of the anchor tags for the relative links are empty when inspect element is used on them.
Using console.log, the value of docBaseUrl just before an absolute URL is created for links (obj.js line 760) can be found to be null and params.docBaseUrl which it is assigned from is undefined. I believe this is the issue as the value for url here also contains the relative part of the link and createValidAbsoluteUrl requires docBaseUrl for relative links.
I set up a local server both per https://github.com/mozilla/pdf.js#getting-the-code and using the online demo files with a different command line http server but both had the same issue.
https://github.com/mozilla/pdf.js/blob/21cc2c020026341586024fb6a9d41602bddc3ed5/src/core/obj.js#L760

First of all, please keep in mind that using relative links in PDF files are a really bad idea, since that means that the files are not as portable as they ought to be.
In an attempt to try and work-around the problems with relative links, PR #7689 gave API consumers the ability to provide a base URL against which relative links are resolved.
In order for this to work in custom deployments[1], the PDFJS.getDocument call must include the docBaseUrl parameter specifying a valid absolute URL; please refer to the documentation in: https://github.com/mozilla/pdf.js/blob/21cc2c020026341586024fb6a9d41602bddc3ed5/src/display/api.js#L119-L121
Closing as answered.

[1] Since no absolute URL is available when using the default viewer locally (with gulp server), that explains why it's not available there either.

Thank you for the caution but that be a problem for my use.
Ah thank you very much for explaining that, sounds perfect.


improve(*): support audit log

Close #16
Log all executed commands to audit log file per day.

LGTM!


Feature/rel field sync

Synchronization of custom fields across reciprocal relationship pairs
Handled in REL_Relationships_TDTM. The synchronization of the packaged Description and Status fields is done with the same mechanism as for custom fields (made for much easier test coverage, among other things.)  The list of fields to sync is built from an AllFieldsDescribe, from which are removed:

Standard fields
Packaged relationship fields which should not be synced (stored in a final at the top of the class)
fields that can't be written (formula, autonumber)
if the custom field sync feature is turned on by checkbox custom setting, any non-npsp custom fields excluded via custom list setting
if the custom field sync feature is off, all non-npsp custom fields are removed from the sync list

An upgrading organization that does not enable the custom field sync would still see the Description and Status fields synced (via the new field sync code).
The list of custom fields to exclude from sync is in a new List Custom Setting, with just the API name of the field stored in the Name field of the record. The alternative approaches I considered and discussed some on the Hub, a hierarchical custom setting textarea field for either inclusion or exclusion, were likely to prove inadequate with very many fields.
That said, I preferred a multi-select picklist for the settings UI rather than the one-at-a-time creation of records as is done for most other List settings (which have more than one meaningful field). So I based it off of the STG_DataBoundMultiSelect.component, and made adjustments in the panel controller to work with a list setting rather than a Textarea field.  I'm creating and deleting setting records in the setter for the panel's List<String> property that's bound to the multi-select. It feels a bit odd, but works. But I'm definitely especially open to feedback on that point.
Critical Changes
Changes
Synchronization of custom Relationship fields across reciprocal pairs

New checkbox in NPSP Settings > Relationships, "Enable Custom Field Sync." When checked, writable custom fields on the Relationship object will be synchronized across reciprocal Relationship pairs.
To exclude fields from this sync, select them in the "Relationship Sync Excluded Fields" list.

Issues Closed

Thanks @tet3 - this likely won't be able to be reviewed in the sprint that starts tomorrow, but I'll work with @mpusto and @davidhabib to see if we can get it in to the next one. Really appreciate the time you put in on this and can't wait to see how it works!

Thanks @tet3 and @judisohn  This would be a very useful feature to have.

Hey @tet3 We just had our Sprint Planning meeting - unfortunately, this didn't make it in. The entire engineering team will be at an offsite next week, so work days are super short on this one. We hope to have it in at some point after they return, but we're likely looking into April at this point. Thanks for your patience and looking forward to seeing you soon!

Thanks for the update Judi
On Tue, Feb 28, 2017 at 4:27 PM, Judi Sohn<EMAIL_ADDRESS>wrote:

Hey @tet3 https://github.com/tet3 We just had our Sprint Planning
meeting - unfortunately, this didn't make it in. The entire engineering
team will be at an offsite next week, so work days are super short on this
one. We hope to have it in at some point after they return, but we're
likely looking into April at this point. Thanks for your patience and
looking forward to seeing you soon!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SalesforceFoundation/Cumulus/pull/2491#issuecomment-283165234,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABoylzKaHq8x_BUGZHWI7MF45srZmqdRks5rhJEmgaJpZM4MAV_2
.

Thanks again @tet3 for the contribution, everything looks great and we're about ready to merge it in. I've moved it over to #2528 and will be merging it after it goes through documentation review.

Thanks @tet3 for your contribution!


add: Region, new catalog variable

Introducing new connector parameter - Region.
Additionaly this happens to be a catalog variable. This value in turn will be used during automatic substitution of vars found in catalog provider.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#713  👈
#712
#711
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite

@RajatPawar you have asked to add Display Names. I would like some clarification.
Should workspace and region have those properties?
How those properties are to be set? I assume there should be no changes to arguments of WithWorkspace(string) or
WithRegion(string) methods. A new method for each struct? (ex: WithDisplayName(string))
How would DisplayName be consumed by a frontend? This data comes to the connector's constructor, which is a final destination.


Areas and Lines deviate in area mode

I'm trying to plot network data statistics and noticed horrible deviations in area and line plot of data plotted as area.

My dataset looks like this:

x
in
out

0
0
1

1
2
1

2
6
1

3
2
1

The rest of my code is pretty much your example code: http://codepen.io/anon/pen/meKVQL

Hi and thanks for the interest. Is there any particular reason you're using strings to plot your data ?


Install doesn't work when version => 'x.x.x' param is set on Ubuntu 14.04

When using the following to install docker:
  class { 'docker':     version => '1.13.0'   }
The install command fail on Ubuntu 14.04:
Error: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install docker-engine=1.13.0' returned 100: Reading package lists...
There is an error in the command and the proper command should be:
/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install docker-engine 1.13.0
The equal "=" sign should not be present at the end of the command
I did not test with other Ubuntu version. I tried to investigate but the problem doesn't seem to be in garethr-docker but might be in stdlib and I gave up debugging this.

Using the full version name does seem to work but isn't really OS independent:
class { 'docker': version => '1.13.0-0~ubuntu-trusty' }

same here.  RHEL and Centos:
Using the following:
class {'docker':
  use_upstream_source => true,
  version => '1.12.3'
}

Gets you this error on run:
Failed to update to version 1.12.3, got version 1.12.3-1.el7.centos instead

A workaround on CentOS 7.x is to hardcode the entire version string:
class { 'docker':
version    => '1.13.1-1.el7.centos'
{


Ability to change a resource UID from API

Works for text, binary and imported resources
Allows better clean up of duplicate files.

TODO (future PRs):

Use this API for assigning new UIDs to copied files in FS dock instead of current (kind of hackish) code.
Use this API for UID conflict on FS scanning (if more than one file has the same UID, the newer one(s) should get assigned a different UID).

This API can be used together with:
ResourceUID::get_singleton()->create_id()
// To assign new UID to a file:
ResourceSaver::set_uid( "<filepath>", ResourceUID::get_singleton()->create_id() );

to assign new Unique IDs to files.

I don't like how set_uid() duplicates lots of code. Can't it just re-use the saving code?

@KoBeWi I generally prefer that this code is duplicated rather than reused and make a complex function even more complex. Its still a very simple change so it should be fine I think.

Duplicating big complex functions makes them more difficult to keep in sync in case a modification is needed.

@KoBeWi The problem is that they do different things and, honestly, its quite sensible code that will corrupt stuff if there is a bug so I prefer to not touch it and keep it simple/separate to ensure this PR can be merged at no risk.
Feel free to clean it up and merge code if you feel like it after this PR is merged, as long as you want to assume the risk, but I don't think its necessary.

Sooo I tried to test if it works and used this hack (editor node)
case EDIT_REDO: {
	ResourceSaver::set_uid("res://icon.svg", ResourceUID::get_singleton()->text_to_id("test1"));
	ResourceSaver::set_uid("res://new_theme.tres", ResourceUID::get_singleton()->text_to_id("test2"));
	ResourceSaver::set_uid("res://new_theme.res", ResourceUID::get_singleton()->text_to_id("test3"));

The method has no effect (no UID is changed in any of the files) and icon.svg import becomes corrupted (to the point that I had to delete the source file and copy a new one).
How is this new function supposed to be used?

@KoBeWi Tested more thoroughly this time and it seems to be working fine now. If you want to check whether its working, you can use this code instead of the one you wrote:
case EDIT_REDO: {
	ResourceSaver::set_uid("res://icon.svg", 123);
	ResourceSaver::set_uid("res://new_theme.tres",456);
	ResourceSaver::set_uid("res://new_theme.res", 789);

Then exit the editor, open it again and open .godot/editor/filesystem_cache7, you should see those numbers as the cached UIDs.

Why won't text_to_id() work though? The UID is stored as <invalid>.
But the number UIDs work. Except for new_theme.tres, which for whatever reason gets saved as new_theme.tres.uidren (with correct UID) and the original file isn't modified.

@KoBeWi text_to_id expects a valid uid text format (beginning with uid://, followed by hexadecimal, as a example: uid://123abc ), since UIDs are 64 bits integers, not text.
I used numbers entered manually to test more easily whether the ID was correctly set.

And what about the uidren thing? It was created by set_uid() so it's probably related. (I tested with newly created, empty Theme)

@KoBeWi I fixed that, do you still see it?

It's still there, here's MRP:
Uidren.zip
Note that I'm testing on newest master, so you might need to rebase to get the same result.

@KoBeWi I really can't reproduce it, even rebasing on master and testing your sample project it seems to work fine for me.
I pushed the repo again just in case I forgot to commit something, so please make sure to test it again.

Maybe it's system-specific? I'm on Windows.

I even checked out to your branch to make sure and it's still the same.

@KoBeWi Nevermind, I think I found the problem. Let me amend. The strange thing is that this should also fail in many other places.

Alright, I think it should work now.

It doesn't 🙃
And the UID is wrong now 🙃🙃
[gd_resource type="Theme" load_steps=0 format=3 uid="uid://no"]

This is because of the removal of the close() function, in cases like this its difficult to keep track of where there are still references to the file.
@KoBeWi I think it should be working fine now.

:tada:

Thanks!


Add support for executing commands when playback begins or ends

Add an option to set commands, e.g. some shell script, which are executed if playback is about to begin or has stopped. This is quite handy to wakeup some amplifier from sleep or to stop any other service possibly blocking the audio interface.

Perhaps it would be possible to implement the MPRIS dbus interface? I think it would be neat as many other clients use it and by subscribing to "org.freedesktop.DBus.Properties.PropertiesChanged" you can be notified whenever playback status is changed:
https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

@Fulkerson The MPRIS dbus intercase looks promising.However, I guess it takes more effort than adding the Rust feature std::process::Command in the start() and stop() functions of the audio backend.
@plietar What do you think?

I'd like scripts at the point a device connects or disconnects; it would allow projects like Volumio or squeezeplay to shut down and allow the soundcard to be shared between apps.  Does librespot free the soundcard when it disconnects from a player?

Does librespot free the soundcard when it disconnects from a player?
Yes, it does, if on pause/stop.

Fixed by #117


"lm_head.weight" not in the parameters of Starcoder2-3B and Starcoder2-7B (Huggingface version)

There is no lm_head.weight in the parameters of Starcoder2-3B and Starcoder2-7B. Is it because of tied embedding?

Yes!

ok, thanks for your response!


ElasticSinkConnector: Task 0 is FAILED (NoNodeAvailableException)

Please see https://github.com/datamountaineer/stream-reactor/issues/177#issuecomment-312865600 for details, I don't seem to be able to use the connector with ES5 still (the Confluent's connector works well, this connector works well with ES2).

@costa I'n #177 the stack trace indicates you are still using the elastic connector rather than elastic5, it's a different class so the class name in the connector properties should reflect this.

@costa,
We provide two ES sink, one for 2.x and one for 5.x.  we differentiate it will allow sink for 2.0 run sife by side of a sink for 5.0.
Now, back to the error. You seem to have a connection issue there. A quick google search got me here: https://stackoverflow.com/questions/33691858/elasticsearch-nonodeavailableexception . Please check your cluster is accessible given your infrastructure.

@stheppi Re: namespacing/versioning: I understand the intention, but not the purpose, I just fail to see an architecture where two ES clusters of different versions need to be accessible from the same JVM.
Nevermind that.
Your quick google search got you a vaguely relevant ES2 Q&A. My multiple and extensive google searches didn't help me to solve this problem. As mentioned above, I do test my ES5 to open 9300 long before I try to create the sink. Also mentioned above, the Confluent's sink drop-in replacement works (with 9200). Can you kindly share your ES5 testing setup please?

@costa There are two namespaces because 1) version dependencies issues 2) clients do write to more than one elastic cluster on different versions in the same connector cluster. For example to migrating from 2x to 5x.
Here's our integration test http://coyote.landoop.com/connect/kafka-connect-elastic5/
Are you running in a docker? What's you connector configuration? Have you set the elastic clustername?
In our experince and that of the author of the underlying elastic4s library we use, is that the clustername is not set or different from the default or that the cluster is not accessible.
https://stackoverflow.com/questions/45577077/elastic4s-nonodeavailableexception-when-connecting-through-tcpclient-transport

@andrewstevenson @stheppi I'm currently trying to solve this problem, please note, the other connector works in the very same environment — I literally have a case to switch the sink classes+configs.
Meanwhile, a less related question: how did you manage to have environment variables in your docker-compose.yml (to configure elasticsearch) with dots in them? It doesn't work with my docker-compose and I have to resort to the command-line options.
Will post any progress here, appreciate if you re-open the issue.

Which docker compose? we haven't published any docker compose files.

https://github.com/Landoop/kafka-connectors-tests/blob/master/kafka-connect-elastic5/docker-compose.yml
I thought you were testing with this.

Please share your docker-compose version
`$docker-compose -version`

Also please share the configuration you are posting to the Connector
Also try the same config using landoop/fast-data-dev:cp3.3.0 docker image and let us know if it works there

@Antwnis Thanks for the docker-compose tip, 1.7 works.
Used the image you mentioned, same result:
[2017-11-07 14:09:33,651] INFO ElasticConfig values:
	connect.elastic.batch.size = 4000
	connect.elastic.cluster.name = elasticsearch
	connect.elastic.error.policy = THROW
	connect.elastic.kcql = INSERT INTO vital SELECT * FROM Vital
	connect.elastic.max.retries = 20
	connect.elastic.url = elasticsearch:9300
	connect.elastic.url.prefix = elasticsearch
	connect.elastic.use.http = tcp
	connect.elastic.write.timeout = 300000
	connect.elastic.xpack.plugins = null
	connect.elastic.xpack.settings = null
	connect.progress.enabled = false
 (com.datamountaineer.streamreactor.connect.elastic5.config.ElasticConfig:223)
[2017-11-07 14:09:33,653] INFO Kafka version : <IP_ADDRESS>-cp1 (org.apache.kafka.common.utils.AppInfoParser:83)
[2017-11-07 14:09:33,654] INFO Kafka commitId : 5cadaa94d0a69e0d (org.apache.kafka.common.utils.AppInfoParser:84)
[2017-11-07 14:09:33,655] INFO Finished starting connectors and tasks (org.apache.kafka.connect.runtime.distributed.DistributedHerder:825)
[2017-11-07 14:09:33,656] INFO Source task WorkerSourceTask{id=logs-broker-0} finished initialization and start (org.apache.kafka.connect.runtime.WorkerSourceTask:143)
[2017-11-07 14:09:33,687] INFO Initialising Elastic Json writer (com.datamountaineer.streamreactor.connect.elastic5.ElasticJsonWriter:45)
[2017-11-07 14:09:33,687] INFO Sink task WorkerSinkTask{id=Vital-ElasticSinkConnector-0} finished initialization and start (org.apache.kafka.connect.runtime.WorkerSinkTask:233)
[2017-11-07 14:09:33,690] INFO Discovered coordinator 1fe90d48e1db:9092 (id:<PHONE_NUMBER> rack: null) for group connect-Vital-ElasticSinkConnector. (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:597)
[2017-11-07 14:09:33,691] INFO Revoking previously assigned partitions [] for group connect-Vital-ElasticSinkConnector (org.apache.kafka.clients.consumer.internals.ConsumerCoordinator:419)
[2017-11-07 14:09:33,691] INFO (Re-)joining group connect-Vital-ElasticSinkConnector (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:432)
[2017-11-07 14:09:33,694] INFO Successfully joined group connect-Vital-ElasticSinkConnector with generation 3 (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:399)
[2017-11-07 14:09:33,694] INFO Setting newly assigned partitions [Vital-0] for group connect-Vital-ElasticSinkConnector (org.apache.kafka.clients.consumer.internals.ConsumerCoordinator:262)
[2017-11-07 14:09:33,713] ERROR Encountered error None of the configured nodes are available: [{#transport#-1}{Ww1x0MHNSoeiEHBUV7tynw}{elasticsearch}{<IP_ADDRESS>:9300}] (com.datamountaineer.streamreactor.connect.elastic5.ElasticJsonWriter:62)
NoNodeAvailableException[None of the configured nodes are available: [{#transport#-1}{Ww1x0MHNSoeiEHBUV7tynw}{elasticsearch}{<IP_ADDRESS>:9300}]]
	at org.elasticsearch.client.transport.TransportClientNodesService.ensureNodesAreAvailable(TransportClientNodesService.java:348)
	at org.elasticsearch.client.transport.TransportClientNodesService.execute(TransportClientNodesService.java:246)
	at org.elasticsearch.client.transport.TransportProxyClient.execute(TransportProxyClient.java:59)
	at org.elasticsearch.client.transport.TransportClient.doExecute(TransportClient.java:366)
	at org.elasticsearch.client.support.AbstractClient.execute(AbstractClient.java:408)
	at org.elasticsearch.action.ActionRequestBuilder.execute(ActionRequestBuilder.java:80)
	at com.sksamuel.elastic4s.bulk.BulkExecutables$BulkDefinitionExecutable$$anonfun$apply$4.apply(BulkExecutables.scala:28)
	at com.sksamuel.elastic4s.bulk.BulkExecutables$BulkDefinitionExecutable$$anonfun$apply$4.apply(BulkExecutables.scala:28)
	at com.sksamuel.elastic4s.Executable$class.injectFutureAndMap(Executable.scala:21)
	at com.sksamuel.elastic4s.bulk.BulkExecutables$BulkDefinitionExecutable$.injectFutureAndMap(BulkExecutables.scala:17)
	at com.sksamuel.elastic4s.bulk.BulkExecutables$BulkDefinitionExecutable$.apply(BulkExecutables.scala:28)
	at com.sksamuel.elastic4s.bulk.BulkExecutables$BulkDefinitionExecutable$.apply(BulkExecutables.scala:17)
	at com.sksamuel.elastic4s.TcpClient$class.execute(TcpClient.scala:28)
	at com.sksamuel.elastic4s.TcpClientConstructors$$anon$1.execute(TcpClient.scala:46)
	at com.datamountaineer.streamreactor.connect.elastic5.TcpKElasticClient.execute(KElasticClient.scala:69)
	at com.datamountaineer.streamreactor.connect.elastic5.ElasticJsonWriter$$anonfun$10$$anonfun$apply$4$$anonfun$apply$5.apply(ElasticJsonWriter.scala:146)
	at com.datamountaineer.streamreactor.connect.elastic5.ElasticJsonWriter$$anonfun$10$$anonfun$apply$4$$anonfun$apply$5.apply(ElasticJsonWriter.scala:116)
	at scala.collection.Iterator$$anon$11.next(Iterator.scala:410)
...

@costa
can you please change the code in  ElasticWriter.scala line 39:
val uri: ElasticsearchClientUri = ElasticsearchClientUri(s"$esPrefix://$hostNames?cluster.name=$esClusterName")
Then build and deploy the jar and let us know the outcome.

@costa Also I've just spun a 5x cluster up on elastic cloud, I have no problems connecting
by Andrew Stevenson v  (com.datamountaineer.streamreactor.connect.elastic5.ElasticSinkTask:39)
[2017-11-07 17:02:00,683] INFO ElasticConfig values:
connect.elastic.batch.size = 4000
connect.elastic.cluster.name = elasticsearch
connect.elastic.error.policy = THROW
connect.elastic.kcql = INSERT INTO index_1 SELECT * FROM orders-topic
connect.elastic.max.retries = 20
connect.elastic.url = 177eb7db0aeafc9229b5ee4ec9458be1.eu-west-1.aws.found.io:9343
connect.elastic.url.prefix = elasticsearch
connect.elastic.use.http = tcp
connect.elastic.write.timeout = 300000
connect.elastic.xpack.plugins = null
connect.elastic.xpack.settings = [hidden]
connect.progress.enabled = true
(com.datamountaineer.streamreactor.connect.elastic5.config.ElasticConfig:223)
[2017-11-07 17:02:02,555] INFO Initialising Elastic Json writer (com.datamountaineer.streamreactor.connect.elastic5.ElasticJsonWriter:45)
[2017-11-07 17:02:02,561] INFO Sink task WorkerSinkTask{id=es4-0} finished initialization and start (org.apache.kafka.connect.runtime.WorkerSinkTask:233)
[2017-11-07 17:02:02,666] WARN Error while fetching metadata with correlation id 2 : {orders-topic=LEADER_NOT_AVAILABLE} (org.apache.kafka.clients.NetworkClient:846)
[2017-11-07 17:02:02,667] INFO Discovered coordinator <IP_ADDRESS>:9092 (id:<PHONE_NUMBER> rack: null) for group connect-es4. (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:597)
[2017-11-07 17:02:02,668] INFO Revoking previously assigned partitions [] for group connect-es4 (org.apache.kafka.clients.consumer.internals.ConsumerCoordinator:419)
[2017-11-07 17:02:02,668] INFO (Re-)joining group connect-es4 (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:432)
[2017-11-07 17:02:02,777] INFO Successfully joined group connect-es4 with generation 1 (org.apache.kafka.clients.consumer.internals.AbstractCoordinator:399)
[2017-11-07 17:02:02,778] INFO Setting newly assigned partitions [orders-topic-0] for group connect-es4 (org.apache.kafka.clients.consumer.internals.ConsumerCoordinator:262)

@stheppi Hi, sorry for the delay, I don't actually have this project's development environment. I've just been using the docker image, I'm sorry. So either you direct me to a simple and concise dev env init procedure (so I can build such a docker image myself), or you will be so kind as to prepare the docker image yourself. Thanks!
@andrewstevenson Ye, good ol' "works for me", thanks a lot ;)  Now really, the whole idea of containerisation is to eliminate this gap. So kindly provide a docker-compose.yml or tell me how you test your fast-data-dev docker image please.
Again, I was under impression that was it: https://github.com/Landoop/kafka-connectors-tests/blob/master/kafka-connect-elastic5/docker-compose.yml

@costa That's a test docker compose we use for testing.
If you are unable to get your docker working, try without first. Our fast data dev has no issues as do other clients.
Feel submit any PRs, contributions are more than welcome

Hi @costa we discussed to blog about coyote a little bit
It's such a brilliant tool and can help you try out setups + connectors internally
So we'll generate an easy to follow tutorial in the near future under https://landoop.com/blog/

additionally in the open source community: things like help me if you have time work better to direct me to a simple and concise answer ;-) Tickets are expecting someone in the community to address them via a PR and contributions are always welcome

@costa Any issue here is with your docker or elastic setup. Not the connector. Docker experts are free to provide PRs. Hence closed. I'd love to be proved wrong and see a PR raised.

To me it seems that the connector cannot connect to ElasticSearch.
The first steps to debug would be to connect to the machine/VM/container that runs the connector and check ElasticSearch connectivity.
So if for example you run the connector inside a container named costa, I would do:
docker exec -it costa bash

Once inside, I would check if ElasticSearch is available and configured as expected. For example by curl'ing the ES HTTP port, I can check that both cluster.name and elastic version are correct. Also I check that the IP or domain I use for ES is correct and accessible as well:
$ curl elasticsearch:9200
{
  "name" : "LwX60Ec",
  "cluster_name" : "landoop",
  "cluster_uuid" : "-tD8fLlrQRGJLgRpVMPINw",
  "version" : {
    "number" : "5.4.0",
    "build_hash" : "780f8c4",
    "build_date" : "2017-04-28T17:43:27.229Z",
    "build_snapshot" : false,
    "lucene_version" : "6.5.0"
  },
  "tagline" : "You Know, for Search"
}

Then I would check if the native port of ElasticSearch is available to the container running the connector:
$ curl elasticsearch:9300
This is not a HTTP port

I hope this helps a bit.

Ok, thanks all for your help, the @andmarios' hint directed me to find the culprit: the official ES docker image has its cluster.name different from the default for some reason, and the http-port connector doesn't have that option to screw things up. Thank you again and the issue is now truly closed.

We chose to go native for better performance. Alas it is a bit more difficult to configure and we need to have two different connectors as they need to load different versions of elastic's classes.
Glad we reached to the bottom of this!


Update to Readme.md file

readme.md file updated to include two 'hello world' statements.
Overall, update was to test and practice GitHub commands.

Initial submission of ldquantsRADAR.py


Tracking bug for Base5459

This is a tracking bug for implementing a "super-base class" for both autonomous and teleop modes. It was first implemented in 6058a7e.
The new base class extends OpMode instead of LinearOpMode to make teleop work correctly.
Things to do immediately:

[ ] refactor initialization code out of teleop
[x] change all autonomous programs to override start() instead of runOpMode()
rationale: runOpMode() only exists in LinearOpMode

Things to test:

[ ] our custom initialization() method changed to an override of OpMode's init() method; does this change anything?
[x] where should waitForStart() go? should it move outside the init() method?

autonomous programs override loop() instead of start()

waitForStart() doesn't exist in OpMode` so this method call was removed

[ ] we need to override the stop() method and stop all drive motors


[Core] Optimize String::insert

See also:

https://github.com/godotengine/godot/pull/92550
https://github.com/godotengine/godot/pull/92546

Thanks!

Thank you!


additional Diagnostics for the FDD reporting/analytics

NOTES:

verify with G36 fault equation author if OS 1 for heating mode and OS 2 for clg mode should include unoccupied building cycling for the AHU where AHU runs in a recirc mode until zones get caught up to unoc setpoints

I think FC6 (OS1 & OS4 for AHU htg/clg only) should be modified to accommodate AHUs without heating or cooling coils. So the flag could be true if the OA < 10  for heating mode or OA temp > 80 for clg mode.

See section 2.4 System Data Analytics through 2.4.6 for System-level diagnostic supports
EMIS Specification_LBNL_Dec2020.pdf

For ongoing improved reporting in system level FDD & HVAC analytic features see Link for the LBNL PDF download above make sure we are providing ROOT CAUSE ANALYSIS. Currently there isnt anything about prioritization of faults or any monitory engineering type of calculations building into this.

For AHU Systems make scatter plots of leaving temperatures Vs outside air temperature

Look into making heat maps of fault conditions if fault rules are ran across large datasets that incorporate many different seasons with the idea of the heat map to show seasonal components to faults IF the time-of-day histogram is not useful


Porting to C++, Python and Elixir

Hi,
I want to port abstract Replicated Growable Array for Godot Engine c++, python for blender and for elixir for my game back-end for merging game scene trees that have been "serialized" and aren't live objects.
You said:

Each JsonNode represents a structural unit of a JSON document. It is like an AST node, where each node has one of the following types: "object", "array", "string", "number", "boolean", and "null".

Do you think it's feasible to merge two structs given we have a unique names in a document and we can get accurate monotonic time.
Python has dictionaries (https://docs.python.org/3/tutorial/datastructures.html#dictionaries).
Godot Engine has dictionaries (https://docs.godotengine.org/en/stable/classes/class_dictionary.html)
and elixir has structs https://elixir-lang.org/getting-started/structs.html.
Looking for a map of the project, and some guidance.

Hey @fire, I don't think I will be able to help you with the details of your implementation. But in general, we have published JSON CRDT specifications, which anyone can use to port it to other languages:

JSON CRDT
JSON CRDT Patch

Thanks


Generated JS files not included when publishing to Azure web site

I'm running Visual Studio 2015 update 1 and TypeScript 1.7.6.   When attempting to publish to an Azure web site, the TypeScript generated javascript files are not included in the preview.  That being the case I'm assuming they wouldn't be published to the remote site.
The generation of the .js and .map files works perfectly and I am able to run locally via IIS Express.
Is there a setting or something that needs to be tweaked or does 1.7.6 have a bug that is causing this?  The only work around I can come up with is including the js files in the project, which I don't really want to do.

@dsmeltz can you share your build log, with /verbosity:diagnostic.

Here's the build log.  I currently have the generated *.js files included in the project.
TSBuildLog.txt

Sorry, accidentally hit the Close button.

is there a chance we can get a sample project demonstrating the issue?

I whipped up a stub project and the issue does not happen with that one.  I'm guessing there's something missing in the project file that I'm using.

I think I found the magic.  This line:

in the project file was near the bottom with the nuget stuff.  I moved it up, to a similar spot like my test project, and now things work.  Note, this new spot is above the TypeScript configuration nodes in the project file.  (So that line was below those nodes before I moved it.)
I've included the before and afters of my project file so you can see the differences.
ProjBefore-NotWorking.csproj.txt
ProjAfter-Working.csproj.txt

the import needs to be below the configurations for the configurations to take effect. MSBuild is sequential when evaluating these targets and properties.

looks like the issue is expected, and moving the targets import to the correct location should solve the issue.

I ran into this same problem but I was able to fix it by installing the latest Typescript plug-in for Visual Studio.


Discrepancy in Model Performance When Reproducing Experiment

Hi,
I've been attempting to reproduce an experiment involving the finetuning of the Llama-2-7b-hf model, specifically using a random 5% of training data, using open-instruct finetune_with_accelerate.sh. I adhered to the hyperparameters outlined in your paper:

learning_rate = 2e-5
total_batch_size = 128
warmup_ratio = 0.03
lr_scheduler_type = linear
weight_decay = 0.0
num_train_epochs = 4

Despite following these settings, the performance of my model on the MMLU benchmark is significantly worse than yours as shown in the screenshot. Is this discrepancy in results anticipated? The gap in performance seems larger than what one might reasonably expect.
Could you please confirm if my hyperparameters are fully aligned with those used in your setup? Additionally, any details about your SFT hyperparameters would be greatly appreciated.
Thank you for your assistance.

Hi! Apologies for the delayed response. I believe this is the setup we used in our work, but it's a bit tricky to pinpoint the exact issue here. It could be due to a couple of reasons:

You might have used a different prompt for MMLU?
It could simply be due to the variance resulted from selecting data randomly.

Hi,
I've been attempting to reproduce an experiment involving the finetuning of the Llama-2-7b-hf model, specifically using a random 5% of training data, using open-instruct finetune_with_accelerate.sh. I adhered to the hyperparameters outlined in your paper:

learning_rate = 2e-5
total_batch_size = 128
warmup_ratio = 0.03
lr_scheduler_type = linear
weight_decay = 0.0
num_train_epochs = 4

Despite following these settings, the performance of my model on the MMLU benchmark is significantly worse than yours as shown in the screenshot. Is this discrepancy in results anticipated? The gap in performance seems larger than what one might reasonably expect.
Could you please confirm if my hyperparameters are fully aligned with those used in your setup? Additionally, any details about your SFT hyperparameters would be greatly appreciated.
Thank you for your assistance.

Hello, how do you evaluate a trained model?

Hi,
I've been attempting to reproduce an experiment involving the finetuning of the Llama-2-7b-hf model, specifically using a random 5% of training data, using open-instruct finetune_with_accelerate.sh. I adhered to the hyperparameters outlined in your paper:

learning_rate = 2e-5
total_batch_size = 128
warmup_ratio = 0.03
lr_scheduler_type = linear
weight_decay = 0.0
num_train_epochs = 4

Despite following these settings, the performance of my model on the MMLU benchmark is significantly worse than yours as shown in the screenshot. Is this discrepancy in results anticipated? The gap in performance seems larger than what one might reasonably expect.
Could you please confirm if my hyperparameters are fully aligned with those used in your setup? Additionally, any details about your SFT hyperparameters would be greatly appreciated.
Thank you for your assistance.

Hello, could you please tell me how to evaluate this trained model?


NIFI-9875 Fix: StandardProcessGroupSynchronizer mishandles output ports

https://issues.apache.org/jira/browse/NIFI-9875
In StandardProcessGroupSynchronizer.updateConnectionDestinations handle special case when output port is moved to a child process group while kept connected.
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

OK I was able to run through the tests and verify that the integration tests that were modified to use name instead of ID still work and make sense. The change to the synchronizer looks good. I'm a +1 will merge.


Update and relax versions in Cargo.toml

Using strict locked versions like '1.0.12' leads to block updating dependencies and may cause compiler errors due to using different serde crate versions.

Good call, thank you!


Refactoring of Accera.md from reference docs

Describe the pull request
Ensured that all links are working fine and there is consistency in the writing style.

What does your PR fix?

minor tweaks

Is this a documentation-only fix?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

This link is not working in accera.md from reference docs
accera.get_parameters_from_grid (parameter_grid)


feat(React Incubation): React Playground PoC! (WIP)

This PR includes a React proof-of-concept under a new 'datahub-web-react' module. I chose to locate it there instead of /contrib because I've been testing serving this from datahub-frontend and gradle modules are required for that!
Take a look around, explore! To run the mock server, run yarn run start from inside the datahub-web-react module. As of now, we are simply mocking GraphQL response data using Apollo MockProvider. You can find the request-response mocks under Mocks.tsx in /src directory. This can be changed using a variable in App.tsx if you want to hit a local datahub-frontend (but must have /graphql endpoint changes from my prev PRs).
You'll notice that the reason we can work with type-safe GQL bindings is because I've provided a temporary GQL schema file directly within the react app directory (datahub-frontend.graphql). Once the other pending GQL PRs are in, this will be replaced by the .graphql file inside /datahub-frontend.
Currently, most requests simply won't return any mocked data, try navigating to the following paths to see some content:
localhost:3000/logIn
localhost:3000/datasets/urn:li:dataset:1
localhost:3000/search?type=dataset&query=test
Notice that this is a major work-in-progress, many components need to be cleaned up & iterated on. Specifically we'll need to address styling convention (currently inlining styles, ew), testing convention, design, how we permit configurability / extensibility & more.
Some fun screenshots!

Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

The architecture / layout of the components shown as of today are not the final proposal. One interesting thing to consider further is how 'entity-oriented' we should go. The existing Ember app provides Entity classes where details, search, & browse information is all located. Following a similar pattern here should be considered!

The architecture / layout of the components shown as of today are not the final proposal. One interesting thing to consider further is how 'entity-oriented' we should go. The existing Ember app provides Entity classes where details, search, & browse information is all located. Following a similar pattern here should be considered!


How to label new ocr dataset with square metres

Hello,
I have a new dataset which similar to your training data, but a little bit different. I need to recognize the numbers from the images.
My question is how to label data, for the following images, should I name them as 10240㎡.png or 10240m2.png, 9272㎡.png or 9272m2.png? Thanks at advance.

When I label with ㎡, I get:

Hi, You can label either 10240m2.png or using caret symbol ^ as 10240m^2.png


Update decision, authorship ignored

The authorship does seem to be ignored when posting decisions.
We also need to avoid the defaults for rank and candidate name

Testing a sync on dev results in an elastic search forbidden exception, probably again because of disk space?. We still need to make sure the decision really gets picked up as expected!

The updated species is also not included in the sync results! Maybe the name type (placeholder) is unchanged even though the name now is different?


Improve the Tailwind compiler

Instead of requiring the config file to have a EEx placeholder, we can use elixir_bun to resolve the config at runtime.
https://tailwindcss.com/docs/configuration#referencing-in-java-script

Already solved by bundling the config as explained in the guides.


[Feature] CDC 2.0 supports Flink 1.12 version

Now，Hudi0.9 use Flink-1.12，but cdc2.0 use Flink.1.13，Flink version is not compatible.
Please，CDC2.0 Support flink multiple version, thanks.

The feedback from the DingTalk.

Same request from the dingtalk.


LLM Integration

add ollama to docker-compose
add ollama client as new dependency for backend / celery worker (we need to rebuild containers)
adds new redis channel for llm tasks
adds endpoints for llm tasks
new feature: llm assistant for doc tagging

Todos:

[ ] LLM Annotation in LLM Assistant
[ ] LLM Metadata Extraction in LLM Assistant
[ ] LLM Paraphrasing / Summarization as new option when annotating
[ ] LLM Jobs Manager (Similar to the Pre-pro jobs / Background Jobs UI
[ ] Delete finished LLM Jobs
[ ] (maybe?) Introduce device id env variable


Shoulder offset OR Motion Sickness

Please make it a choice. Either by disabling the motion sickness when ever the shoulder offset is set to something that is not 0, or by having an option.
I have never felt more disoriented and nauseous then the first second after flying after this update. I only have one rarely used situation that uses a shoulder offset, and I'd rather give that up than having to feel sick whenever I fly.

I hear you. What's really strange since 11.0.2 is that the internal cvar "CameraReduceUnexpectedMovement" (which is enabled by checking the "Motion Sickness" box) also prevents the shoulder offset from taking effect. Before, it was only the internal variable "CameraKeepCharacterCentered", which is now strangely enabled by unchecking the "Motion Sickness" box... So I had to also disable CameraReduceUnexpectedMovement, but I will make it such with the next release that this will only happen when the shoulder offset is different from 0.

Thank you. And I can understand having to do things to work around weird Blizzard bugs.

With DynamicCam 2.8.6 we are only disabling the Motion Sickness setting while horizontal or vertical camera offset is used. At least these are the only camera settings I found to be affected (justified or not) by the Motion Sickness setting so far.


Adding TARGET Data

Looks good to me, except that shouldn't the download-target and process-target notebooks be number-prefixed?

Yes, good point. Will update before merge!


ci: wait load images inside subject before screenshot

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[x] Build or CI related changes
[ ] Documentation content changes

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@vladimirpotekhin @nsbarsukov updated


updating icons recommendation

Fixes #1755

Docs Build status updates of commit 48b129a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9b6ee0f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit daa2d5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 22da196:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:warning:Warning
View
Details

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/msbuild-targets.md

Line 116: [Warning] Invalid link: 'PackageIcon'. The file reference/msbuild-targets.md doesn't contain a bookmark named 'PackageIcon'.
Line 118: [Warning] Invalid file link:(~/reference/errors-and-warnings/nu5048).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit ee24d80:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:warning:Warning
View
Details

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

docs/reference/msbuild-targets.md

Line 118: [Warning] Invalid file link:(~/reference/errors-and-warnings/nu5048).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add Mac M1 GPU Support

Mac M1 GPUs appear to work with Torch:

https://towardsdatascience.com/installing-pytorch-on-apple-m1-chip-with-gpu-acceleration-3351dc44d67c
https://github.com/autogluon/autogluon/issues/1242#issuecomment-1502273143

Users are saying that AutoGluon is not detecting M1 GPUs. We should see if we can enable M1 GPU usage in the case the user has set things up correctly.

Currently blocked by https://github.com/pytorch/pytorch/issues/87839. This needs to wait till Torch 2.0 upgrade.

Does 1.0 now support Mac M1 (M2, M3) GPU support? This would be super handy.

Any news on this issue?

Hi, is there any update on this issue @gradientsky?

Any news on this issue?

autogluon multimodal uses mps. This should be doable for autogluon tabular maybe? @gradientsky

multimodal running fine on M3 GPU as well 👍

Bumping this - does it work on an M4?

Does it fail silently or will I see what models fail in the logs?

what do you mean by 'fail'? some models will run via mps, some will run on cpu


fix: apply backoff when external objects not found

Summary
Applies backoff when external objects are not found for a given phase reconciliation loop.
This is needed to prevent "hot" loops from occurring due to external issues.

/ok-to-test

thanks for the pr @Ajpantuso :)


Unexpected token 'export'

Hi, I'm using Remix 1.16.1 with the latest packages from @remix-pwa (sw and push) and followed the guids on the docs. But when I do that, I get this unexpected token error when I add the subscribeToPush route.
In remix-config.js I have set this option:
serverModuleFormat: 'cjs',

And in my package.json I added this
"dev:worker": "esbuild ./app/entry.worker.ts --outfile=./public/entry.worker.js --bundle --format=cjs --define:process.env.NODE_ENV='\"development\"' --watch",

I need the cjs format due to other dependencies. But I've tried with esm as format as well.
I get the error on this line:
export { subscribeToPush, unsubscribeFromPush } from './client/subscription';

Any idea how to fix?

I get the error on this line:
export { subscribeToPush, unsubscribeFromPush } from './client/subscription';

Any idea how to fix?

What error do you get?

Thanks for the swift response. The error is in the title :)
Unexpected token 'export'

Tried replicating but couldn't get the bug to appear. Even with cjs format both in my worker script and remix config file

Mmm, ok. I will let you know if I can fix it.

@rphlmr Thanks! That helped so I don't have an error anymore. Now trying to solve the next set or errors.


Adding a footer

Hey there,
I feel like i'm missing something easy here. But how do you go about adding a footer with tabular?
I've looked at many datatables examples. However they all show the footer added in the html, and then using different functions like the footerCallback, and columns().footer(), to update it; however as tabular generates the html automatically, I haven't been able to create a footer with tabular. I'm sure this is something easy i'm missing so any help, or a simple example would be much appreciated!
thanks so much (and thanks for this great package)!

Not really sure. Maybe will have to add the ability to provide a footer template name.

Maybe there's a better way to do this then. What i'm really looking to do is add a row which tallies the totals from the columns. So it doesn't necessarily need to be a footer.
Is there a way to add rows instead of columns, or is there a good way to achieve this that you can think of?

The footer is a key feature for me too. I'm building a reporting system for a client and I'd like to have a totals row at the bottom,  I'll probably just show the totals outside of the table for now.

+1

+1

+1

+1

+1

+1

+1

Pretty sure this will work in 2.0


Ford_AV dataset: other_data_downloader.sh

Hello, thank you for your great work.
I'm planning to reproduce your work on the Ford-AV dataset.
But I realized that "ford_data_process/other_data_downloader.sh" only downloads the empty files.
When I enter the file link "https://anu365-my.sharepoint.com/:u:/g/personal/u7094434_anu_edu_au/EVk_8Ah6q_hClNyEaQ7vSmYBYBysVyGZzGJmiSHMte78qg?e=qUalA1&download=1", the link has expired.
Below are the error logs:
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Downloading: 2017-08-04-V2-Log5-pcd
--2024-04-29 07:47:32--  https://anu365-my.sharepoint.com/:u:/g/personal/u7094434_anu_edu_au/EVk_8Ah6q_hClNyEaQ7vSmYBYBysVyGZzGJmiSHMte78qg?e=qUalA1&download=1
Resolving anu365-my.sharepoint.com (anu365-my.sharepoint.com)... <IP_ADDRESS>, <IP_ADDRESS>, 2620:1ec:8f8::10, ...
Connecting to anu365-my.sharepoint.com (anu365-my.sharepoint.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 203118 (198K) [text/html]
Saving to: 'EVk_8Ah6q_hClNyEaQ7vSmYBYBysVyGZzGJmiSHMte78qg?e=qUalA1&download=1'
Thank you.

Thank you for your interest. I have updated the link and extended the expiration time. Could you please try downloading it again? The expiration limit is set to one month by my university server. If you encounter any issues again, please do not hesitate to contact me.

Thank you for your quick reply. I was able to download the files successfully, including the satellite maps. Could I ask another question? The SIBCL code provides download links only for 2017-08-04 and 2017-10-26. Is the 2017-07-24 not included in the experiments?

For the SIBCL method, we exclusively utilize log4 in our experiments. In contrast, the PureACL method employs Log1, 3, 4 and 5. The "ALL" category in the supplementary material includes only Logs 1, 3, 4, and 5; hence, Log2 information is not provided. I have added a download link for Log1 information in 'other_data_downloader.sh'. Please pull the latest file and remove the "#" before links you want to use. Apologies, I accidentally deleted files dated 2017-07-24 and will need some time to recover this information. I have also provided the data processing source code available at "https://anu365-my.sharepoint.com/:u:/g/personal/u7094434_anu_edu_au/EfiIp8Bo5Z1MpdgV5ud0MQQBaCgv-FAxi0fSGcODUeDiUg". Please feel free to use this code to generate information, using 'info_files' as the keyword to locate related process files.
I believe this issue arises because you have not pulled the latest 'other_data_downloader.sh'. I have updated the link with information files for log3 dated 2017-08-04.

Thank you for your kind answer. I have made gps.csv, info_files, and satellite images with your help.
But, I don't have the following LiDAR files:
log_list = [
'2017-07-24-V2-Log1',
'2017-07-24-V2-Log3',
'2017-07-24-V2-Log4',
'2017-07-24-V2-Log5',
'2017-08-04-V2-Log1',
'2017-10-26-V2-Log1',
]
I have another question. FordAV provides the LiDAR pcd files in the bag file. But SIBCL used the 3D map of the FordAV dataset. How can I generate the 3D map pcd files? The additional source you provided doesn't seem to have the processing code for the 3D LiDAR map.

Unfortunately, we do not provide the LiDAR data directly. You can download the LiDAR data from the Ford AV dataset website. The projection from their 3D point cloud to our format is provided in the following source file:
https://github.com/ShanWang-Shan/SIBCL/blob/main/ford_data_process/project_pointcloud_to_camera.py

Thank you for your reply. I just wondered whether SIBCL used raw LiDAR from Ford AV dataset. Now it's clear. Thank you!


[WIP] Refactoring vuex cart module

Related issues
closes #3249
Short description and why it's useful
Refactoring the cart module.
Checklist:

[x] move network calls to the data resolvers
[x] action: syncPaymentMethods refactored
[x] action: syncShippingMethods  refactored
[x] action: sync  refactored
[x] action: load  refactored
[x] action: addItems  refactored
[x] action: removeItem  refactored
[x] action: updateQuantity  refactored
[ ] action: configureItem  refactored
[ ] action: syncTotals  refactored
[x] action: removeCoupon  refactored
[x] action: applyCoupon  refactored
[x] action: authorize  refactored
[x] action: connect  refactored
[ ] action: merge  refactored
[ ] difflog / notifications
[ ] add typescript typings as much as possible
[ ] unit tests for helpers

Which environment this relates to

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[x] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

Adding https://github.com/DivanteLtd/vue-storefront/issues/3103 as related here ;)

@andrzejewsky good job! @lukeromanowicz was to rewrite cart unit tests and release them in even 1.10.1 release - @lukeromanowicz these changes probably doesn’t change much in the unit tests (data resolver is something new to be tested, helpers makes the tests even easier)
The current cart tests (that we have in 1.10) are in greeen but this means nothing :-)
I think still it would be good to fix the tests as for 1.10.1 - but if it would be more optimal and you guys agree on that we can fix them just once in this release where this refactor will be applied - 1.11

Please review the backward compatibility and if some minor upgrade notes are required please add them to the docs. Good job overall 👌

@pkarw unfortunately, it does change a lot. Please keep in mind that we're talking about unit tests, not integration tests. When you move something from one file to another it always is reflected in unit tests. I'm postponing fixing tests till this gets merged.

@lukeromanowicz fair enough, let's do it

Ready 🎉

Plase add hooks as we discussed ;) before/after cartSync and before/after addToCart

@filrak roger that. 🔫

Aaand before/after removeFromCart

@andrzejewsky is it done already?

@pkarw yeah it's done, I'm only waiting for QA / review / appr.

@alinadivante can you take this one as a first task to test after we finish checklist for 1.10?

@alinadivante

change API from test.storefrontcloud.io to next.storefrontcloud.io - I've noticed that on the next.storefrontcloud.io there is a special case (special discount) when you have more than 4-5 products which doesn't occur in test.storefrontcloud.io - am I right @pkarw? I have always the same prices as on the live demos (*.storefrontcloud.io) and also comparing the prices make sense only when you have the same API address as the demo you compare to.
Fixed
bug in registering modules - isModuleRegistered pointed to the always empty array - Fixed
Seems like your browser has blocked the request - tomorrow we'll chat about it

thanks for the fixes 👌

@andrzejewsky i know you’re checking the multiplies shipping-information requests. Is this the last one so we’d be ready to merge it in?

@pkarw yeah, this is the last thing. Today I'll check these requests and fix if it's necessary.

@pkarw @alinadivante seems like these multiple request are caused by https://github.com/DivanteLtd/vue-storefront/blob/develop/core/pages/Checkout.js#L134-L141 and basically by these events inside of it (event bus). It's a bit hard to get which one and when should be called.
It's totally related to the checkout module while this module will be refactored soon, so the question is - should I try to avoid these additional requests here in this PR? because it means this PR would be even bigger than it is now and this bug had existed before that refactor. Although, if it's mandatory to fix, maybe we can create other task for that, just for fixing that specific problem?

I think we can skip this for a while - and fix in 2.0; this additional request is kind of for safety to always refresh totals on methods change.
Can I merge this PR then?

@pkarw yeah, you can merge it

Cool, thanks!


All univariate distributions in Shogun should come from boost

(apart from maybe Gaussian, and univariate)
This

reduces the possibility of bugs as we use mature, well-tested code
we can get rid of the alglib code that we took under the GPL
in particular, start in CStatistics, and replace all ALGLIB based methods by boost ones (at least gamma cdf, etc)
we need a cmake check for boost, and an include guard, and maybe even the option to download and locally compile boost in the same fashion as eigen3

But what should we do about the gpl issue with alglib? We must solve it if we are aiming at being completely bsd.

Boost is the best choice I know and boost-math is really light-weight.

@thirdwing, it is header-only, right? Does it have any dependencies?

Yes, it is header-only. On ubuntu, all you need is libboost-math-dev. In https://github.com/shogun-toolbox/shogun/pull/2662 all ALGLIB code has been replaced with boost-math. However, it seems you really don't like boost.

We are not only supporting Ubuntu (not even only just Linux).
Regarding the dependencies, if you try to do apt-get install libboost-math-dev, you will see that the whole libboost package will be installed as well (in case you don't have it already installed). So it seems that boost math depends on the whole boost library.

I am sorry that my word caused some misunderstanding. liboost-math-dev is just an example. You can install it easily. You can also checkout any module manually.
https://gist.github.com/thirdwing/4ec69f6a4d938863b37d

That would be having the whole boost as dependency (not only boost math),
which is not so light-weight.
On 21 January 2015 at 18:44, Qiang Kou (KK<EMAIL_ADDRESS>wrote:

I am sorry that my word caused some misunderstanding. liboost-math-dev is
just an example. You can install it easily. You can also checkout any
module manually.
https://gist.github.com/thirdwing/4ec69f6a4d938863b37d
—
Reply to this email directly or view it on GitHub
https://github.com/shogun-toolbox/shogun/issues/1912#issuecomment-70884960
.


Add com.apple/notification_event/jsonschema/1-0-1 (close #1173)

This schema is exactly like the 1-0-0 except for the "additionalProperties": true for the aps property as it can change indipendently by us (it's decided by Apple). As reported in the issue #1173 it can cause events to end up in the bad rows.
Changing additionalProperties the events should go in good rows even if there are new properties in "aps".

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

Cherry picked in R128


Add documentation for Flash usage

I think i can help with this one @bscott i'll keep you posted :)

@apaganobeleno Hey, I was going to start on this, let me know what you plan on?
:)

i think it was already done, no ? sorry for delaying you.

Yep, this is all done. Closing this issue.


Fix type-o in adhybridhealthservice model

Move Go SDK config to its own config file
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

Automation for azure-sdk-for-go


Does gorm support pgxpool?

The default driver used by gorm for Postgres is pgx as per this doc: https://gorm.io/docs/connecting_to_the_database.html
Is it possible to use pgxpool instead of this?

No such plan, gorm conn pool is based on sql.DB