[boost-modular-build-helper] Ensure CMAKE_STATIC_LINKER_FLAGS makes it to the link.exe command line when building Boost as a static lib with MSVC.

I have a custom triplet that builds static libs for ARM64EC (https://blogs.windows.com/windowsdeveloper/2021/06/28/announcing-arm64ec-building-native-and-interoperable-apps-for-windows-11-on-arm/). When building as ARM64EC, CMAKE_STATIC_LINKER_FLAGS is correctly populated to "/machine:ARM64X /nologo". However, this is passed to b2 via "linkflags". When b2 builds a static lib with MSVC, it uses "archiveflags" instead of "linkflags" for the command line settings for link.exe. This PR makes it so the CMAKE_STATIC_LINKER_FLAGS value is passed to b2 as "archiveflags" when building Boost as a static lib with MSVC. This enables me to build boost as ARM64EC.

What does your PR fix?

Fixes the build for boost when using a custom triplet for building a static lib targeting ARM64EC.

Which triplets are supported/not supported? Have you updated the CI baseline?

This is for a custom triplet of my own which isn't currently checked into the vcpkg repo.

Does your PR follow the maintainer guide?

Yes. (I reviewed it and nothing seemed to apply in this case.)

Yes

I just rebased this to be on the latest commit. I also fixed up the issues with the version files. If the PR build goes well, I plan to make this no longer be a draft.
(In my project that uses vcpkg, I've been overwriting this file with a patched copy as part of a script whenever I install vcpkg dependencies; so I had a workaround, but now I want to upstream this so I can remove my hack.)

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated

The version issue is addressed now. I can't find any way to resolve the comment from the bot.

Thank you.

Sorry, I clicked "Close with comment" thinking that would merge the PR, but it just closed it without merging; so I reopened it.

I believe we should do https://github.com/microsoft/vcpkg/pull/23001 instead which solves the problem more generally for all build flags rather than only STATIC_LINKER_FLAGS. We'll see where that goes.

I tried out Robert's fix that you referred to. It doesn't seem to address my issue. The compile command lines are correct:
compile-c-c++ D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj

    call "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\standalone\msvc\b8cab6c23bafdda38fa0399294b4cb12\msvc-setup.bat" x86_arm64 >nul
cl "..\src\alloc_lib.c" -c -Fo"D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj"     -TC -nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1 /Z7 /Od /Ob0 /W3 /MTd /Zc:forScope /Zc:wchar_t /Zc:inline -DBOOST_ALL_NO_LIB=1 -DBOOST_CONTAINER_STATIC_LINK=1 "-I..\include" "-ID:\git\validation.taef3\vcpkg\submodule\installed\arm64ec-windows-custom\include"

alloc_lib.c

This correctly includes "-arm64EC" on the command line. However, the linker flags are not passed to link.exe:
msvc.archive D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib

        if exist "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib" DEL "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib"
        call "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\standalone\msvc\b8cab6c23bafdda38fa0399294b4cb12\msvc-setup.bat" x86_arm64 >nul
link /lib /NOLOGO  /out:"D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\dlmalloc.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\global_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\monotonic_buffer_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\pool_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\synchronized_pool_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\unsynchronized_pool_resource.obj"

D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj : fatal error LNK1392: Incompatible object type found. Did you mean /machine:arm64x or /machine:arm64ec?

There is no "/machine:arm64x" or "/machine:arm64ec" switch on the "link /lib" command line. My understand is this is because b2 is using "msvc.archive", which looks at archive_flags instead of link_flags.
The generated user-config.jam file passes the value via link_flags:
using msvc : 143 : "D:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.31.31103/bin/Hostx64/arm64/cl.exe"
    :
    <setup>"D:/git/validation.taef3/vcpkg/submodule/installed/x64-windows/share/boost-build/nothing.bat"
    <cxxflags>"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -GR -EHsc -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -EHsc -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
    <cflags>"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
    <asmflags>"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
    <linkflags>"-machine:ARM64X -nologo"

    ;

That is the issue my PR is designed to address. It makes sure the link flags are passed as "archive_flags" when building a static lib.

I spoke with Phil over the phone, resulting in these changes:

Tool fixes: https://github.com/microsoft/vcpkg-tool/pull/360
Toolchain fixes: https://github.com/microsoft/vcpkg/pull/23139

Hopefully this will unblock folks 🙂

From: Phil Deets @.>
Sent: Wednesday, February 16, 2022 02:43 PM
To: microsoft/vcpkg @.>
Cc: Billy O'Neal (VC AIR) @.>; Comment @.>
Subject: Re: [microsoft/vcpkg] [boost-modular-build-helper] Ensure CMAKE_STATIC_LINKER_FLAGS makes it to the link.exe command line when building Boost as a static lib with MSVC. (#20697)
I tried out Robert's fix that you referred to. It doesn't seem to address my issue. The compile command lines are correct:
compile-c-c++ D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj
call "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\standalone\msvc\b8cab6c23bafdda38fa0399294b4cb12\msvc-setup.bat" x86_arm64 >nul

cl "..\src\alloc_lib.c" -c -Fo"D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj"     -TC -nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1 /Z7 /Od /Ob0 /W3 /MTd /Zc:forScope /Zc:wchar_t /Zc:inline -DBOOST_ALL_NO_LIB=1 -DBOOST_CONTAINER_STATIC_LINK=1 "-I..\include" "-ID:\git\validation.taef3\vcpkg\submodule\installed\arm64ec-windows-custom\include"
alloc_lib.c
This correctly includes "-arm64EC" on the command line. However, the linker flags are not passed to link.exe:
msvc.archive D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib
    if exist "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib" DEL "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib"
    call "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\standalone\msvc\b8cab6c23bafdda38fa0399294b4cb12\msvc-setup.bat" x86_arm64 >nul

link /lib /NOLOGO  /out:"D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\libboost_container-vc143-mt-sgd-a64-1_78.lib" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\dlmalloc.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\global_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\monotonic_buffer_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\pool_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\synchronized_pool_resource.obj" "D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\unsynchronized_pool_resource.obj"
D:\git\validation.taef3\vcpkg\submodule\buildtrees\boost-container\arm64ec-windows-custom-dbg\boost\build\21132b4af385ed13a7e7d6293d937cec\alloc_lib.obj : fatal error LNK1392: Incompatible object type found. Did you mean /machine:arm64x or /machine:arm64ec?
There is no "/machine:arm64x" or "/machine:arm64ec" switch on the "link /lib" command line. My understand is this is because b2 is using "msvc.archive", which looks at archive_flags instead of link_flags.
The generated user-config.jam file passes the value via link_flags:
using msvc : 143 : "D:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.31.31103/bin/Hostx64/arm64/cl.exe"
:
"D:/git/validation.taef3/vcpkg/submodule/installed/x64-windows/share/boost-build/nothing.bat"
"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -GR -EHsc -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -EHsc -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
"-nologo -DWIN32 -D_WINDOWS -W3 -utf-8 -MP -arm64EC -DWIN32 -D_AMD64_ -DAMD64 -D_ARM64EC_ -DARM64EC -D_ARM64EC_WORKAROUND_ -D_WINDOWS -D_DEBUG -MTd -Z7 -Ob0 -Od -RTC1 -D_ITERATOR_DEBUG_LEVEL=1"
"-machine:ARM64X -nologo"
;

That is the issue my PR is designed to address. It makes sure the link flags are passed as "archive_flags" when building a static lib.
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvcpkg%2Fpull%2F20697%23issuecomment-1042381086&data=04|01|bion%40microsoft.com|76780c6e851047dac04b08d9f19db322|72f988bf86f141af91ab2d7cd011db47|1|0|637806481895247424|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=COaAR6BRptIBWvmZD5SxoEuxfeiruMHVijSYViVpuWQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAALZF3ZZ5MQRD42H7XHVEBDU3QR7VANCNFSM5F4CJZ6A&data=04|01|bion%40microsoft.com|76780c6e851047dac04b08d9f19db322|72f988bf86f141af91ab2d7cd011db47|1|0|637806481895247424|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=DKOCZYPz6k3TGhQpcYTlhvPhKAWoZ8thnRIFV58tbF0%3D&reserved=0.
You are receiving this because you commented.Message ID: @.***>

There is no "/machine:arm64x" or "/machine:arm64ec" switch on the "link /lib" command line. My understand is this is because b2 is using "msvc.archive", which looks at archive_flags instead of link_flags.

shouldn't vcvars magically define the machine type so it isn't needed on the link line?

There is no "/machine:arm64x" or "/machine:arm64ec" switch on the "link /lib" command line. My understand is this is because b2 is using "msvc.archive", which looks at archive_flags instead of link_flags.

shouldn't vcvars magically define the machine type so it isn't needed on the link line?

ARM64EC is built with the same vcvars configuration as plain ARM64. You opt into ARM64EC using the -arm64EC command line switch to cl.exe, not by starting vcvars with a different parameter. If it was automatic based on vcvars, then it would pick /machine:arm64, which is not what is needed for ARM64EC. When using "link /lib", you need to use /machine:arm64ec or /machine:arm64x when building ARM64EC code.

Robert updated his change to address this. I tested the latest update and it does fix the issue; so I'm closing this merge request now since Robert's change will address it.


Add test cases for service.manager.impl

Make sure that:

[√ ] You have read the contribution guidelines.
[√ ] You submit test cases (unit or integration tests) that back your changes.
[ √] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

hi， pls checked checkstyle and  build in you local env.

so much checkstyle error

hi， pls checked checkstyle and build in you local env.

so much checkstyle error

thx，After this inspection, I learned a lot and found my own shortcomings. At present, I have made a modification

Codecov Report

Merging #4610 (e6a4129) into master (d6067f4) will increase coverage by 0.56%.
The diff coverage is 62.75%.

@@             Coverage Diff              @@
##             master    #4610      +/-   ##
============================================
+ Coverage     67.62%   68.18%   +0.56%
- Complexity     7845     7919      +74
============================================
  Files          1070     1078       +8
  Lines         30650    30775     +125
  Branches       2790     2807      +17
============================================
+ Hits          20726    20983     +257
+ Misses         8303     8139     -164
- Partials       1621     1653      +32

Impacted Files
Coverage Δ

...e/shenyu/plugin/base/fallback/FallbackHandler.java
36.84% <0.00%> (-17.01%)
:arrow_down:

.../apache/shenyu/plugin/hystrix/command/Command.java
7.69% <0.00%> (+2.69%)
:arrow_up:

.../shenyu/plugin/hystrix/command/HystrixCommand.java
55.55% <0.00%> (ø)

...plugin/hystrix/command/HystrixCommandOnThread.java
61.11% <0.00%> (ø)

.../springmvc/ShenyuSpringMvcClientConfiguration.java
100.00% <ø> (ø)

...henyuSpringMvcClientInfoRegisterConfiguration.java
0.00% <0.00%> (ø)

...pringboot/starter/gateway/ShenyuConfiguration.java
88.00% <0.00%> (-3.67%)
:arrow_down:

...shenyu/web/fallback/DefaultFallbackController.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...pache/shenyu/web/filter/CollapseSlashesFilter.java
0.00% <0.00%> (ø)

...ava/org/apache/shenyu/web/filter/HealthFilter.java
62.50% <60.00%> (-37.50%)
:arrow_down:

... and 6 more

... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lijay7674  hi， can you updata  master  to you dev，then summit pull request ？

not merged

sorry,Can I initiate a new pull request

@lijay7674  you can add my wechat: xixy199195, i wiil invite you join contributor group


Invalid response when setting ngx.arg[1]

Consider the following function in my plugin
function RestfulSOAP:body_filter(config)
    RestfulSOAP.super.body_filter(self)

    local chunk, eof = ngx.arg[1], ngx.arg[2]
    local ctx = ngx.ctx

    ctx.rt_body_chunks = ctx.rt_body_chunks or {}
    ctx.rt_body_chunk_number = ctx.rt_body_chunk_number or 1

    if eof then
      local body = concat(ctx.rt_body_chunks)
      ngx.arg[1] = cjson.encode({
        foo = "bar",
        some_object = {},
        some_array = cjson.empty_array
        })
    else
      ctx.rt_body_chunks[ctx.rt_body_chunk_number] = chunk
      ctx.rt_body_chunk_number = ctx.rt_body_chunk_number + 1
      ngx.arg[1] = nil
    end
end

From within Postman I get the following error :
Parse Error: The server returned a malformed response
This happens if I set ngx.arg[1] to anything. A string a number, whatever.
My understanding from looking at various plugins was this was how to edit the content of the response body to the client. Or is there another way I should be looking at?

What is your body? Perhaps it is gzipped/deflated?

I found that adding
ngx.header.content_length = nil
to the header_filter fixed it. Makes sense as the contents of the body are changing but the length is unchanged.
I'm guessing the header_filter fires first, so there is no opportunity to set it later in the body_filter, unless we can use ctx as a variable pointer?

Additionally I am reading from here https://github.com/openresty/lua-nginx-module#body_filter_by_lua
Is this the right document to be looking at for this function/hook?

@suityou01 yes that is right. Or you can use our buffered request. In 2.2.0 you can just implement response handler in your plugin and call kong.service.response.get_raw_body()  for example. You are still in access phase so all the stuff like cosockets are available. It does buffer the full response, so be aware of that. But that seems to be more or less of what you are doing already.


User/zakhele/landingpage

Merging to main for deployment

This was a mistake. Pushed to the incorrect branch. Please delete


How to get camera state?

How could I get camera state (if recording or stopped) through CLI?

The state of the camera is maintained in the file status_mjpeg.txt. This is maintained in /dev/shm/mjpeg/status_mjpeg.txt but is linked to in the web installation folder (e.g. /var/www/html)
The web client gets this every few seconds to maintain the web status.
You can either read it yourself or fetch it via the web interface.

Thank you!


Alignment icons (naming) inverted

Some of the alignment icons are the inverse of expected. The line indicating the axis should be horizontal for "vertical" alignment and vertical for "horizontal" alignment.
This is the case for Adobe suite, Figma, Sketch etc.
Resources
Distribute and flip appear to be correct, only the following are affected:

align-center-horizontal
align-center-vertical
align-end-horizontal
align-end-vertical
align-start-horizontal
align-start-vertical

Annotated screenshot of Illustrator's "Align" panel.

Note that for vertical alignment and distribution the terms should be top, middle, and bottom.

Note that for vertical alignment and distribution the terms should be top, middle, and bottom.

They really shouldn't, these are for flex layouts, where the preferred terms are start, end and center no matter the alignment. (Top, bottom and middle could sure be added as tags though, in case they aren't yet).

these are for flex layouts

That would make sense, but I'd assume the philosophy is that icons should be applicable to more than one use case. Even the first comment on this issue refers to alignment and distribution in Illustrator which is a use case far removed from flexbox.
For flex layouts on the web, 'start', 'end', and 'center' are used because the axes for flexbox are the main axis and cross axis: they don't refer to horizontal or vertical axes, so using 'top', 'middle', and 'bottom' (or 'left' or 'right') would be incorrect.
These icons, however, are graphical representations and explicitly refer to horizontal and vertical axes, where 'top', 'middle', 'bottom', 'left', 'right' and 'center' are the correct terms to use.


Vulnerability jobs are failing

Describe the bug
The vulnerability github actions have never worked.

/assign
https://github.com/knative-sandbox/.github/pull/132


Apply gossip attestations to forkchoice

Motivation
Apply gossip attestations to forkchoice
Description
Closes #1949

Have you benchmarked the cost of doing this? I would love to see the CPU charts of a node subscribed to all subnets with this enabled and this disabled.

Update

only pass unaggregated gossip attestations to forkchoice if shouldProcess (i.e. there's an aggregator connecting to this node)
pass all aggregated gossip attestations to forkchoice
add network.passGossipAttestationsToForkchoice hidden cli flag, default as true
add benchmark: 700 aggregated attestations (as seen in prater/master) + 400 unaggregated attestations (assuming there are 3 aggregators connected to node), the result shows cpu time as ~30ms/slot

Update
Given the fact that for each slot, there are only limited set of AttestationData, we don't have to validate all attestation data of all attestations. In a good net work condition, there should be only 64 attestation data max (same slot, different committee index)

For AggregateAndProof messages, since they are tree backed, we already cache the attestation data root there. After a successful validation, add them to a Set() that's renew per slot. Bypass validation if we already validated that same AttestationData root.
For unaggregated attestations, they are just struct so using hashTreeRoot() there is not a good idea

with this improvement, total time to process gossip attestations in forkchoice is reduced from 30ms to more than 16ms (almost double the speed)


fix bug: torchrun: error: argument --master-addr/--master_addr: expec…

fix bug: torchrun: error: argument --master-addr/--master_addr: expec...

Thank you for your contribution! However, I think it had been fixed in this PR

https://github.com/QwenLM/Qwen/pull/922


Add backtracking for public

When SynBioHub parts are made public, a wasDerivedFrom should be added to the part with its private URI. Later, if a private URI is not found, search the public store for items which have that private URI as their wasDerivedFrom.

should already work for current sbh


ci(github): Run Docker as the GitHub user to simplify code

Did you already verify on a fork that the Gradle caching works? In this functional test job it doesn't (it starts with downloading Gradle) but that's expected as the GitHub actions cache is only populated from the main branch and I guess the changes invalidate the old cache.

Did you already verify on a fork that the Gradle caching works?

No, I didn't explicitly test that. How would I do that, create a PR to my branch from a fork? Or can we merge first to main to ease testing, and revert the last commit of this PR if it unexpectedly doesn't work?

Did you already verify on a fork that the Gradle caching works?

No, I didn't explicitly test that. How would I do that, create a PR to my branch from a fork? Or can we merge first to main to ease testing, and revert the last commit of this PR if it unexpectedly doesn't work?

I tested everything within my fork, e.g. making a PR to the main branch within the fork. This was especially useful to test that the published Docker images were correct without messing with those in the main repository.
However, we can also merge as is and if caching doesn't work either fix or revert it.


Internal Audit of Groups UI

Summary
We are currently working towards an MVP for the groups UI (https://github.com/regen-network/groups-ui/issues/29).
We should perform an internal audit of the codebase to identify issues that should be completed as part of the MVP (and is not already being tracked) as well as issues that we can resolve as part of future iterations.
Note: At least two engineers should perform the audit.
Checklist

[ ] Test application meets acceptance criteria defined within #29
[ ] Review code architecture and identify any improvements that could be made
[ ] Review designs and identify any interfaces that need to be implemented or updated
[ ] Review dependencies and dependency versions and identify any updates that should be made
[ ] Review the codebase and identify any todos that are not yet being tracked in issues
[ ] ...

@ryanchristo probably best to make sure we have every MVP issues closed before looking it this?

My notes from audit and testing:

[ ] Test application meets acceptance criteria defined within #29

[x] Anyone can create a group with the group UI

as long as they have a keplr wallet, with or without a ledger device

[x]  Every group (whether created through UI or CLI) can be viewed by a member

all groups are visible to everyone, only groups that the user is a member of are displayed on the home page

[x]  If user is admin, they can manage group & group policies

the admin of a group can update the group metadata, create a group policy if no policy exists (a group was created using the CLI), and add and update members of a group
one thing that is not possible is updating the admin of a group, and therefore switching from a group admin to a policy admin, but this is now being tracked in #115

[x]  Text, Staking, Send, Group admin msgs, proposals can be made through the UI

group proposals with no messages, send messages, staking messages, and group admin messages can be submitted using the UI (not including the update admin message #115)

[x]  Every proposal type (made via UI or CLI) can be viewed, voted on, & executed

proposals submitted within and without the UI are viewable with messages being displayed as JSON in the event the UI does not support it, not a high-priority but noting we do have some unfinished work for displaying the new group update messages #111
proposals can be voted upon although a user should probably be able to update their vote as is possible with the group module event though prevented in the UI #120
proposals can be successfully executed although it would be nice to have some better error handling and prevention in the case the message will fail, which is something that has been discussed in #56

[ ] Review code architecture and identify any improvements that could be made

...

[ ] Review designs and identify any interfaces that need to be implemented or updated

...

[ ] Review dependencies and dependency versions and identify any updates that should be made

...

[ ] Review the codebase and identify any todos that are not yet being tracked in issues

...

Items required (from my perspective) before launching:

[ ] finish wiring up historical proposals

Items that would be nice to have before or soon after launching:

[ ] the ability to update group admin as a user admin
[ ] the ability to update group admin via group proposal if policy admin
[ ] historical proposals includes historical votes

My Audit (still WIP): https://hackmd.io/@3CueavWvQ0WoQqDc-lJ3gg/BJOIAtkj3

As part of adding a graphql client, we have a small dependency which for some reason required being pinned 1 major version behind the latest. I don't think this is a major issue but a good thing to track for the future health of the groups-ui repo.
See this comment: https://github.com/regen-network/groups-ui/pull/112#discussion_r1276408464
Basically, with the combination of react-query + graphql-request, react-query asks us to use graphql-request v5x rather than v6x.
I think a good task for that at this stage could be simply to open an issue with react-query to specify what the plans are for supporting graphql-request v6x (investigate upgrade process for graphql-request).

Opened #123 for tracking the graphql request version issue.

Should we close this now or is there something remaining?

Completed. Thanks!


HZN-1073: Implement grafana datasource for the fault-management console

This is the 2nd part of the issue.
It now uses the opennms.js client.
The general structure was also re-defined and some tests are provided.
I think this can be the first version and the branch can be deleted afterwards.

JIRA: https://issues.opennms.org/browse/HZN-1073

Can we use a released version of the opennms.js artifact from NPM instead of including it in the vendor directory?


@types imports as devDependencies

Can you edit your package Json and import @types as dev dependencies? I have encountered conflicts with react typings.

Done.
Please report errors if any.

Great, thank


How disable purge protection?

I can't find how to disable purge protection. I created a keyvault through arm and now I can't purge it.   I keep looking but I can't find documentation about how to disable it and in portal I don't seem to be able to modify it.
I ran the command:
Remove-AzureRmKeyVault -VaultName acrbld-usnat  -l usnatwest -InRemovedState
and got the response:
Confirm
Are you sure you want to remove vault 'acrbld-usnat' forever.
[Y] Yes  [N] No  [S] Suspend  [?] Help (default is "Y"): Y
Remove-AzureRmKeyVault : Operation 'DeletedVaultPurge' is not allowed.
At line:1 char:1

Remove-AzureRmKeyVault -VaultName acrbld-usnat  -InRemovedState

  + CategoryInfo          : CloseError: (:) [Remove-AzureRmKeyVault], CloudException
  + FullyQualifiedErrorId : Microsoft.Azure.Commands.KeyVault.RemoveAzureKeyVault

@rosanch Can you please provide us with the URL of the Azure Doc you are having issues with? We look forward to your reply.

Here I don't see info on how to disable purge protection from a keyvault
https://docs.microsoft.com/en-us/azure/key-vault/general/soft-delete-powershell#enabling-purge-protection

@rosanch, Thank you for sharing the details. Let me share the answers to the questions shared by you:

To purge a deleted key vault, the user needs RBAC permission to the Microsoft.KeyVault/locations/deletedVaults/purge/action operation.
To list a deleted key vault, the user needs RBAC permission to the Microsoft.KeyVault/deletedVaults/read operation.
By default only a subscription administrator has these permissions.

Also, you cannot disable purge protection once its enabled. So how this works is, once you would enable soft-delete, the default retention period is set for 90 days. These values can only be enabled during the time of creating the KeyVault. After a Vault is deleted, it remains in the transient state until the retention period. After the retention period, the Vault gets automatically purged.
Hope this helps. We are closing this thread for now. Do let us know if there are any more queries around this, so that we can re-open this thread and help you further.


Best way to update the direction vector of a camera

Hi @oakes,
As previously meantioned I am working on a First Person Controller example. I am mostly done but there is one part that I wanted some input form you on. In order to look around correctly I need to modify the direction vector of the camera.  The direction! calls the lookAt function which does not seem to work for me. Currently in my project I just directly modify the camera vector and have a custom function camera-update! in the play-clj fork. I was wondering if there was some other way to update the camera and if it might be better to have a direction-vector! function added.
Thanks!

How about we add a new arity to direction!? We could allow passing a single argument, which is interpreted as a vector-3.

That could work to but I can forsee someone posting a bug about how there is a different in functionality between the arities.

Does the lookAt function that takes a vector not work for you?

I was having some issues with it. It seemed to be causing a jittering and would constatly look near the center 0, 0, 0. I assume it is because of the extra calculations it performs. Once I got around it looking worked fine. I can make a simple test case if you want to try it out yourself.

I'm not sure why I chose to use lookAt there. I think we could just change it to modify the direction vector directly.

That works! I was worried it might change some functionality of existing projects but code search is down so I can't check. We could also change the current direction! to lookAt! since I think that might be valuable. I can do that tomorrow if you like.

Ah, I just tried it on my 3d examples and it does seem to break them, so I'd rather avoid that. Have you tried calling (.normalizeUp (:camera screen)) before calling direction!? The docs seem to indicate you may need to.

I added a new arity to direction!, but in a different way. It takes an optional fourth arg, a boolean value that I called look-at? for lack of a better term. If you set it to false, it will just set the direction vector as you were looking for. Hopefully that works for you. I pushed 0.4.5-SNAPSHOT so you can try it.

Thanks for responding so quickly. I have used the new arity direction! and it works! I have not pushed it because now that everything is working I am trying to figure out how to reorganize and clean up the code.


Edit this block icon '< >' is partly hoovering over first link in tasks query

When I use the minimal theme with tasks for every query I make an group by pagename the "Edit this block" icon showing '< >' is in part hoovering over a small part of the first pagename shown in the query.
Like so ...

It should not. My personal preference would be to show left of the text or to the far right. But at least it should not partly cover the page link in the query.
Thanks for this great theme. Using MacOS and 14.15 obsidian.

If you turn on readable line length this should work.


8tv issue

8tv will stop streaming after few minutes in aptv software,other channel are fine

Sory..i dnow to solve this prob..

Its ok, but can add some chinese astro channel?
On Thu, 15 Aug 2024 at 22:15, Kaitou E @.***> wrote:

Sory..i dnow to solve this prob..
—
Reply to this email directly, view it on GitHub
https://github.com/MIFNtechnology/siaranMy/issues/131#issuecomment-2291348758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BFZUXWUSIZYTAFJXCFUI2ATZRSZZVAVCNFSM6AAAAABMRLTFMCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGM2DQNZVHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Maaf..tak boleh


Added feature to display basic definitions of items in chainstats output

Simply specify kwarg display_details=True when calling chainstats.

Pull Request Test Coverage Report for Build 363

4 of 12 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 97.642%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pymcmcstat/chain/ChainStatistics.py
4
12
33.33%

Totals

Change from base Build 361:
-0.3%

Covered Lines:
2236

Relevant Lines:
2290

💛  - Coveralls


added ability to override vagrantfile

This pull requests adds the ability to override the Vagrantfile either with a totally custom value, or then just modify the patch that is added to the Vagrantfile.
It does not modify default behavior, so backwards compatibility should be ok.

Closed #36


Update Redis Enterprise Cache SDK with 2021-03-01 API spec

All SDK Contribution checklist:
New Swagger spec: https://github.com/Azure/azure-rest-api-specs/pull/12829
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[x] Include updated management metadata.
[x] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

I'm not sure how to suppress this error: Discrepancy detected between generated code in PR and reference generation

/azp run

/azp run list

/azp run net - mgmt - ci

/azp run net - mgmt - ci


Flash message on file upload failure

Motivation and Context

Resolves #6233.
Your Changes

Description:
Added a general flash message for when a file upload fails.
Type of change (select all that apply):

[x] New feature (non-breaking change which adds functionality)

Testing

Tested on the web app.
Questions and Comments (if applicable)

Checklist

[x] I have performed a self-review of my own code.
[x] I have verified that the pre-commit.ci checks have passed.
[x] I have verified that the CI tests have passed.
[x] I have reviewed the test coverage changes reported on Coveralls.
[x] I have updated the Changelog.md file.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
19 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 91.814%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/assets/javascripts/Components/submission_file_manager.jsx
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

app/assets/javascripts/Components/submission_file_manager.jsx
19
36.91%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
38062

Relevant Lines:
40899

💛  - Coveralls


Error when running on ios (ionic)

I am seeing this error using ionic (works fine on the browser but not in iOS)
TypeError: undefined is not a function (evaluating 'window.requestFileSystem(Helpers.getCordovaStorageType(ImgCache.options.usePersistentCache), 0, _gotFS, _fail)')
I have followed the all the steps in the docs but still getting the error.

I tracked the error to this line (called from the init function):
if (Helpers.isCordova()) {
// PHONEGAP
window.requestFileSystem(Helpers.getCordovaStorageType(ImgCache.options.usePersistentCache), 0, _gotFS, _fail);
in imgCache.js line 545. Anyone else had this problem?

You haven't put your init inside an ionic ready

Yes I did

I just got the same issue. I doublechecked, my ImgCache.$init(); is inside $ionicPlatform.ready().
Any ideas? I'm developing for iOS9. Did anybody successfully test imgcache with iOS9?
Cordova CLI: 5.1.1
Ionic Version: 1.0.1
Ionic CLI Version: 1.6.1
Ionic App Lib Version: 0.3.3
ios-deploy version: Not installed
ios-sim version: 4.1.1
OS: Mac OS X Yosemite
Node Version: v0.12.7
Xcode version: Xcode 6.4 Build version 6E35b


Parking AI seems unreliable

My city is filled with parking spaces, many of which are empty, yet I see vehicles travelling to many destinations roaming around looking for parking.
Context:

Left side driving
Lots of cul-de-sacs around areas where cims are trying to get to

If you need a save or any other infos, let me know.

#184 would greatly alleviate this issue.

moved


[Feature Request] Elements Metadata

I'd like to see the meta-data of an element :

creation date
last modification date
created by (author)
modified by (author) - if eventually we can collaborate on models

Thank you

Hi, there is no such metadata in Archi so this is not possible.

BTW it may be useful to have a way to predefine attributes for each concept typy and relation type, for example by defining model template.


Helm test failure not reported to gubernator

See #351; helm test is failing but this is not properly reported to gubernator.
Here are the logs from Airflow from the run_tests step.
[2018-01-30 13:21:58,659] {base_task_runner.py:98} INFO - Subtask: INFO:root:Creating gs://kubernetes-jenkins/pr-logs/pull/tensorflow_k8s/354/tf-k8s-presubmit/442/artifacts/junit_e2e.xml
[2018-01-30 13:21:58,660] {base_task_runner.py:98} INFO - Subtask: Traceback (most recent call last):
[2018-01-30 13:21:58,660] {base_task_runner.py:98} INFO - Subtask:   File "/usr/local/lib/python2.7/runpy.py", line 174, in _run_module_as_main
[2018-01-30 13:21:58,661] {base_task_runner.py:98} INFO - Subtask:     "__main__", fname, loader, pkg_name)
[2018-01-30 13:21:58,661] {base_task_runner.py:98} INFO - Subtask:   File "/usr/local/lib/python2.7/runpy.py", line 72, in _run_code
[2018-01-30 13:21:58,661] {base_task_runner.py:98} INFO - Subtask:     exec code in run_globals
[2018-01-30 13:21:58,662] {base_task_runner.py:98} INFO - Subtask:   File "/var/lib/data/runs/tf_k8s_tests/2018-01-30T13_12_48/tensorflow_k8s/py/deploy.py", line 220, in <module>
[2018-01-30 13:21:58,662] {base_task_runner.py:98} INFO - Subtask:     main()
[2018-01-30 13:21:58,662] {base_task_runner.py:98} INFO - Subtask:   File "/var/lib/data/runs/tf_k8s_tests/2018-01-30T13_12_48/tensorflow_k8s/py/deploy.py", line 217, in main
[2018-01-30 13:21:58,663] {base_task_runner.py:98} INFO - Subtask:     args.func(args)
[2018-01-30 13:21:58,663] {base_task_runner.py:98} INFO - Subtask:   File "/var/lib/data/runs/tf_k8s_tests/2018-01-30T13_12_48/tensorflow_k8s/py/deploy.py", line 117, in test
[2018-01-30 13:21:58,664] {base_task_runner.py:98} INFO - Subtask:     t.failure = "helm test failed;\n" + e.output
[2018-01-30 13:21:58,664] {base_task_runner.py:98} INFO - Subtask: TypeError: cannot concatenate 'str' and 'NoneType' objects

So because an exception is occurring we never set t.failure and the test isn't reported as failed.
@jose5918 can you fix this is in the same PR as #351? We can't fix this issue without the fix to #351 because without that fix the tests won't pass.

It seems that problem has been solved, could we close it?


Update Composer dependencies (2024-08-10-00-18)

Visual regression test passed!
View the visual regression test report


Rating precision doesn't work on android chrome

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://mui.com/material-ui/react-rating/
Steps:

Open example at android cellphone using chrome or if you are using PC, open chrome and change device mode using dev tool.
Try to select 0.5, 1.5, 2.5 and so on at Rating precision section.

Current behavior 😯
I set precision 0.5 at Rating component and expected to select 0.5, 1.5, 2.5 and so on, but when I touch, 1 selected instead of 0.5, 2 instead of 1.5, 3 instead of 2.5 and so on only in android chrome. It works well on iphone chrome and safari.
Expected behavior 🤔
If I set precision 0.5 at Rating component, 0.5, 1.5, 2.5 and so on should be selected on android chrome as well.
Context 🔦
I made rating component for user review using custom icon with precision 0.5, but it doesn't work on only android chrome. I tried issue #32557 solution which change pointer-events as auto on MuiSvgIcon-root, but it still doesn't work on only android chrome.

  Output from `npx @mui/envinfo` goes here.

Google Chrome: 110.0.5481.177(Official Build) (x86_64)

@gzrae I would like to pick this up

@gitstart Please go ahead! Once you create a PR, please request a review from mui/core!


If I have 100 routes the macro would be long af...
Maybe something like actix has with configure that can be used to add routes.
I've devided my routes into controllers and each of my controller has a configure method that I use to register all routes maybe you could implement something like this in utoipa.

Found a solution: https://crates.io/crates/utoipauto


[VZ] Scoped npm packages

It might make sense to scope all CF components to @cf or @capital-framework in npm. See https://docs.npmjs.com/misc/scope
I'm not convinced it's necessary or useful but it's something to look into.

Backlogging this. Scoping CF makes sense but is not too important.

This is done, yeah @contolini

Agreed in 7/15 meeting that there's no value to be gained here.


Cookie based authentication

Thank you so much for your contribution in this project, it's help a lot, we can't stay connect all day, we need to work anytime in the courses, it's possible to download the courses with cookie based authentication. All the best.

Your requested feature has been added,
Here is a short tutorial
Cookie-based authentication

Click on the options in google chrome (top right with 3 vertical dots).

After this, click on more tools followed by Developer Tools (you can also reach here by using the keyboard combination — ctrl+shift+I).

Now once you’ve gained access to the developer tools, navigate to the Application tab, and copy the value of two cookies from there named li_at and JSESSIONID respectively.

create a cookies.txt file to a place you want to download your courses then paste in the values of li_at and JSESSIONID as shown below.

Example (cookies.txt)
li_at=xxxxx
JSESSIONID="ajax:xxxxxx"

    $ llvd --help
    $ llvd -c "Course Title" -r 720 --cookies


add retries to see if helps

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

fixed in another branch


[WIP] social login

I've used Python Social Auth for django.
The idea is that the frontend will open a popup to /login/twitter or any other social link, then the application will redirect to a post login view that will send a message (just a function call atm) that will let the frontend know that the user has been authenticated successfully or not.
TODO:

[ ] pass user information to frontend
[ ] let the frontend know that the login has been unsuccessful ?

LGTM

@simobasso can you review this :)


Use arc_swap to implement AtomicStr

The previous implementation allowed use-after-free in a multi-threaded context. This PR fixes the problem by using ArcSwap, which is implements thread-safe swapping of Arcs, and is widely used.
Resolves https://github.com/longbridgeapp/rust-i18n/pull/72.

t                  [+31.689% +32.305% +32.878%]
t_with_locale      [+4.2409% +5.2036% +5.9512%]
t_with_threads     [+4.1089% +4.5351% +4.9449%]
t_lorem_ipsum      [+35.164% +35.690% +36.188%]
t_with_args        [+5.4206% +5.8389% +6.2721%]
t_with_args (str)  [+4.6291% +5.1848% +5.7272%]
t_with_args (many) [+3.0211% +3.3934% +3.7793%]


Added two new examples to related to Teams

Added examples that highlight and use two new site properties related to Teams and Channels.

Docs Build status updates of commit f06fbbf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@yogkumgit @get-itips @tseward for FYI about new functionality here

@Kateyanne Please merge this PR. Thanks

Docs Build status updates of commit e710dd8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e710dd8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

merg1

Docs Build status updates of commit 76d1425:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix cut & paste error in gdip_process_bitmap_attributes

/cc @akoeplinger

Cherry-picked to release/6.0 branch.


nftables: fix Python module

nftables 1.0.9+ no longer builds its Python module as part of the autoconf build. Instead, we need to build it separately with a normal Python toolchain.
Description of changes
Without this PR, python3Packages.nftables doesn't actually contain any Python modules. In nftables 1.0.9 the configure script no longer builds a Python module: https://git.netfilter.org/nftables/commit/?id=b3def33efecb2f7be39fc9aefc9546907202056c
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/NixOS/nixpkgs/pull/276123 - duplicate?

#276123 - duplicate?

Yeah, looks like it. I left a couple comments on that PR - can we get it merged?

Need to ask those who can merge.

Closing this in favor of the PR that's been open longer. :/


I color sequence flows and lose the arrowheads

Describe the Bug

Expected Behavior
I expect the arrowhead to stay and take the color.
Environment
Please complete the following information:
Camunda Modeler 3.1.0

Hi,
this is a known issue, see #1342.
Cheers,
Tassilo

Will be fixed with next Camunda Modeler release.

Problem is still here.
Reproduced in Camunda 3.1.2


assertj-core 3.19.0

Codecov Report

Merging #2630 (460de5d) into master (ef1d30d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2630   +/-   ##
=========================================
  Coverage     92.87%   92.87%
  Complexity     5368     5368
=========================================
  Files            89       89
  Lines         12785    12785
  Branches       1619     1619
=========================================
  Hits          11874    11874
  Misses          722      722
  Partials        189      189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef1d30d...460de5d. Read the comment docs.


Unknown (random) error when zooming on clusters

I'm using this helpful plugin in my web application. Sometimes when I click on a cluster or zooming in map, the following error occurs and I can not pan the map and also the clustering doesn't work anymore!
TypeError: this._map is undefined
	this._map._panes.markerPane.removeChild(this._icon);

leaflet-src.js (line 3623, col3)
Any Idea?

This is not enough information to know what's going on. Please provide a stack trace (using leaflet-src.js instead of leaflet.js) and/or a test case that demonstrates the bug (e.g. using JSFiddle or JS Bin).

^^ Reopen or create a new issue when these details are provided. Thanks.


Meeting02 - Make implementation of register, some interfaces and define JSON message file

Task for both in pair programming

Database of users:
Add last known ID at the begin of file on first line.


Centered Layout Cuts off the first letter on each wrapped line after first line

Does this issue occur when all extensions are disabled?: Yes/No

Version Info:

Steps to Reproduce:

Unmaximize the window
Toggle the centered layout for a markdown document
Resize the layout. Sometimes, the letter will be cut off when the line wraps.

Any update on this bug?

@sahil48 Can you still reproduce this? I have tried for quite a while but couldn't trigger this issue:
https://user-images.githubusercontent.com/5047891/205254166-8bfc841e-072b-4cb3-9408-cc49f966868e.mp4

@alexdima Thank you for looking into this. I cannot reproduce at my end either. Let's close this issue.


Add option to convert arrays to objects

Arrays are skipped in JSON formatting in LogQL as documented here
Converting arrays allows them to be displayed in logQL after JSON parsing

@Julien-R44 is it possible to get this merged pls?

can you add tests please?
i will take a closer look at it by tomorrow
Thanks

Closing since no answer


Taking screenshot failed due to TypeError: Cannot read property 'apply' of undefined after previously failed run

When running a test with this plugin, after a failed run (any error, such as: assertion failure), the next run will always throw error when taking screenshot. Here is the detail error:
Command:     screenshot cypress_runner.js:199793 Error:       TypeError: Cannot read property 'apply' of undefined     at https://www.marbodal.se/:3655:16 From previous event:     at takeScreenshot (https://www.marbodal.se/__cypress/runner/cypress_runner.js:159366:13)     at Context.screenshot (https://www.marbodal.se/__cypress/runner/cypress_runner.js:159458:14)     at Context.<anonymous> (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169999:21)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:169423:15 From previous event:     at runCommand (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169402:8)     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169548:14)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:169576:16 From previous event:     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169548:34) From previous event:     at Promise.catch.err.name (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169589:37) From previous event:     at run (https://www.marbodal.se/__cypress/runner/cypress_runner.js:169582:21)     at $Cy.cy.<computed> [as visit] (https://www.marbodal.se/__cypress/runner/cypress_runner.js:170039:11)     at Context.runnable.fn (https://www.marbodal.se/__cypress/runner/cypress_runner.js:170263:21)     at callFn (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104396:21)     at Test.../driver/node_modules/mocha/lib/runnable.js.Runnable.run (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104383:7)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:175798:28 From previous event:     at Object.onRunnableRun (https://www.marbodal.se/__cypress/runner/cypress_runner.js:175786:17)     at $Cypress.action (https://www.marbodal.se/__cypress/runner/cypress_runner.js:166429:28)     at Test.Runnable.run (https://www.marbodal.se/__cypress/runner/cypress_runner.js:174172:13)     at Runner.../driver/node_modules/mocha/lib/runner.js.Runner.runTest (https://www.marbodal.se/__cypress/runner/cypress_runner.js:105055:10)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:105181:12     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104964:14)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:104974:7     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104876:14)     at Hook.<anonymous> (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104937:7)     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:175719:22)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:175741:11 From previous event:     at onNext (https://www.marbodal.se/__cypress/runner/cypress_runner.js:175738:57)     at done (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104336:5)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:104401:11 From previous event:     at callFn (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104399:14)     at Hook.../driver/node_modules/mocha/lib/runnable.js.Runnable.run (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104383:7)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:175798:28 From previous event:     at Object.onRunnableRun (https://www.marbodal.se/__cypress/runner/cypress_runner.js:175786:17)     at $Cypress.action (https://www.marbodal.se/__cypress/runner/cypress_runner.js:166429:28)     at Hook.Runnable.run (https://www.marbodal.se/__cypress/runner/cypress_runner.js:174172:13)     at next (https://www.marbodal.se/__cypress/runner/cypress_runner.js:104898:10)     at https://www.marbodal.se/__cypress/runner/cypress_runner.js:104942:5     at timeslice (https://www.marbodal.se/__cypress/runner/cypress_runner.js:98868:27)
Restart Cypress temporarily fix the issue until the next failed run.

I need to be able to recreate this. Is the project that you're seeing this error on open source? If not, please provide the Cypress config along a sample of the tests.

I need to be able to recreate this. Is the project that you're seeing this error on open source? If not, please provide the Cypress config along a sample of the tests.

I can add you to my project/repo. Does that sound OK for you ?

yes

I got the same error!

I got the same error!

I have not been able to recreate this. Can you share a repo or something with me so I can at least reproduce the error?

I have not been able to recreate this. Can you share a repo or something with me so I can at least reproduce the error?

@mjhea0 In that moment I remove the plugin to be able to run, but you can found my code at: open-nps/open-nps

@mjhea0 In that moment I remove the plugin to be able to run, but you can found my code at: open-nps/open-nps

@guidiego can you configure the plugin so I can see it breaking on GitHub Actions? Maybe do that on a new branch and then I'll fork it to see if I can recreate and fix locally.

@guidiego can you configure the plugin so I can see it breaking on GitHub Actions? Maybe do that on a new branch and then I'll fork it to see if I can recreate and fix locally.

Closing due to lack of activity.... feel free to reopen


Rewrite benchmark_BGL and benchmark_HDFS to be configurable from the command line; better code reuse

This was done in #1.


pkg/analytics: Remove Google Analytics tracking

We never even look at these analytics and its unclear what value they provide. No need to tradeoff being creepy if it isn't providing clear value.

Added change to show a warning if -analytics flag is used (regardless of value). Rebased.


Setting and clearing data for DragDrop operations

Can we get methods to SetData, ClearData on DataTransfer object for DragDrop?
https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdata
https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/dropEffect
take a look at the example (scroll down)

Please check this links to see how drag and drop works in blazor, including firefox.
https://github.com/Lupusa87/BlazorDragAndDrop
https://lupblazordraganddrop.z20.web.core.windows.net/

Is this a bug on Firefox or Blazor/Razor-Components side?
Do we have to use the JSInterop workaround or is it planned to be fixed?

We don't have any plans to provide anything specific here. You should be able to enable drag & drop scenarios via jsinterop. Closing.


Shift-Enter doesn't trigger Button Press in Command Palette (e.g. for git-plus)

Reproduction Steps:

Install git-plus
Stage some files with git-plus in the command palette
Press shift-enter

Expected behavior:
Pressing shift-enter should cause the flagged files to be staged, or rather trigger a press on the "Apply" button.
Observed behavior:
shift-enter doesn't work in atom-material-ui, but it works in Themes like OneDark.
Screenshots and GIFs

(I'm pressing shift-enter at the end, but I'm too lazy to use a keycaster. 😄)
Atom version: 1.14.4
OS and version: macOS 10.12.3
Installed packages:
Community Packages (30)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Bonus Points:

The Buttons in the command palette could look a bit better (position/margin, shadow, ...)
The labels of the items (like ? and M in the GIF) could have more padding

I take a look at this later to open maybe a PR, but I can't promise anything, also because I don't know if I know where to start. 😄

I agree about the looks, I'm actually working on a new codebase to mitigate these kind of issues.
About the Shift+↩… it's weird because I did not set nor overrode any event listeners. Are you sure it's caused by this theme?

Oh my god that's so embarrassing... I've recently overridden shift-enter, at the same time as I switched to atom-material-ui. I totally forgot about that. 😥
Yeah. shift-enter works. I'm sorry for that. Totally my fault.
As you said, an improvement of the looks would be great. But the keystroke works, so I'm closing this.

@timomeh nothing to be embarrassed of! You wouldn't believe the times where I found myself blocked because of a small, almost obvious, little issue. It happens more often than I'd like to admit. 😁


3D Steady-state Lotus Molten Chloride Reactor Model.

Model Description
This model is a multiphysics 3D model of the Lotus Molten Chloride Reactor (LMCR) using only Griffin and Pronghorn. Must be run on HPC.
Project description
This model was developed by Mauricio Tano & Rodrigo de Oliveira. Funded by the NEAMS  MSR App Driver program.
Impact
This is a valuable contribution to modeling the Lotus MCR with 3D resolution which will be used by the NEAMS program for further modeling development and transient analyses in FY24.

Closing as completed by #331


[BUG] crc.exe process spawned by Daemon Scheduled Task is not killed within crc cleanup on Windows 11

When trying to run crc on a Windows 11 Pro edition it ends up failing due to wrong state for the crc daemon.
Steps:

run crc setup (50% of times it will end up failing when checking the state for the crc daemon)
if crc setup finish ok run crc start it fails b/c crc daemon is not running

Checking the task scheduler we can see the task is Ready. It says it will be triggered on log on ... (so in case we reboot the VM) then the task appears as Running.
Also this exact flow has been tested on a Windows 11 Enterprise edition and on Windows 10 Pro and it is working so far, after running the crc setup we can see the crc daemon Running (as expected).
As a possible solution we can try to add a 2nd trigger on the task spec, the 2nd trigger would be type: At task creation/modification

The previous issue is directly related with having a crc.exe process for the daemon running. Under that condition the Task status stay as Ready.
One possible reason for the situation is having crc running previously and the trying to cleanup everything (crc cleanup).
On windows 11 when running crc cleanup the crc.exe for the daemon is not killed.

o/p from when crc cleanup hangs on windows 11:
PS C:\Users\rhqp> crc cleanup --log-level debug
DEBU CRC version: 2.20.0+f3a947
DEBU OpenShift version: 4.13.0
DEBU Podman version: 4.4.4
DEBU Running 'crc cleanup'
INFO Removing the daemon task
DEBU Running 'Get-ScheduledTask -TaskName crcDaemon'
DEBU Command failed: exit status 1
DEBU stdout:
DEBU stderr: Get-ScheduledTask : No MSFT_ScheduledTask objects found with property 'TaskName' equal to 'crcDaemon'.  Verify the
value of the property and retry.
At line:1 char:43
+ ... reference = 'SilentlyContinue'; Get-ScheduledTask -TaskName crcDaemon
+                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (crcDaemon:String) [Get-ScheduledTask], CimJobException
    + FullyQualifiedErrorId : CmdletizationQuery_NotFound_TaskName,Get-ScheduledTask

DEBU crcDaemon task is not installed: exit status 1 : Get-ScheduledTask : No MSFT_ScheduledTask objects found with property 'TaskName' equal to 'crcDaemon'.  Verify the
value of the property and retry.
At line:1 char:43
+ ... reference = 'SilentlyContinue'; Get-ScheduledTask -TaskName crcDaemon
+                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (crcDaemon:String) [Get-ScheduledTask], CimJobException
    + FullyQualifiedErrorId : CmdletizationQuery_NotFound_TaskName,Get-ScheduledTask

INFO Removing CRC Specific entries from user's known_hosts file
INFO Removing hosts file records added by CRC
INFO Removing pull secret from the keyring
INFO Removing older logs
INFO Removing CRC Machine Instance directory
DEBU Deleting machines directory
DEBU Failed to delete crc machines directory: remove C:\Users\rhqp\.crc\machines\crc\crc\Virtual Machines\9CD71052-C950-4AFB-9F51-3B6B5840F004.vmcx: The process cannot access the file because it is being used by another process.
INFO Removing crc's virtual machine
DEBU Running 'Get-VM -Name crc'
DEBU Running 'Stop-VM -Name "crc" -Force'
DEBU Command failed: exit status 1
DEBU stdout:
DEBU stderr: Stop-VM : 'crc' failed to change state.
The operation cannot be performed while the object is in its current state.
At line:1 char:43
+ $ProgressPreference = 'SilentlyContinue'; Stop-VM -Name "crc" -Force
+                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Stop-VM], VirtualizationException
    + FullyQualifiedErrorId : InvalidState,Microsoft.HyperV.PowerShell.Commands.StopVM

DEBU exit status 1
Failed to delete crc machines directory: remove C:\Users\rhqp\.crc\machines\crc\crc\Virtual Machines\9CD71052-C950-4AFB-9F51-3B6B5840F004.vmcx: The process cannot access the file because it is being used by another process.
exit status 1

related to #3726 as this is the situation where crc.exe process is not killed by crc clenaup (the daemon is started on a visible window)

In Windows 11 the daemon preventing the cleanup will be tracked in #3726
the crc cleanup command deleting the disk before the VM definition was fixed in #3728


Add formatting and linting checks to CI

added lint:ci script in package.json to run in CI
created CI workflow for github actions. It will now run for all PRs to develop and master branches
fixed 3 files that had lint warnings

@filipepacheco resolvi os conflitos, tá pronto pra subir


Cannot build using Gradle 7.4.2

I've pulled the latest Ghidra code and try to follow the steps specified in readme.md.
Init works if I disable the hash-checks.
gradle prepdev and gradle buildGhidra fail, no matter what I try. I get the following error:
Execution failed for task ':Utility:compileJava'.
> error: invalid source release: 17

I have Temurin JDK 17.0.5+8 installed.
Following information from Gradle:
Gradle: 7.4.2
OS: Windows 10
Arch: amd64 (gradle: x86-64)
Using platform: win_x86_64
Searching for latest Visual Studio and required components...
-> Visual Studio not found!
The last warning is incorrect: I have Visual Studio 2022 installed.
I tried a suggested ugrade command (gradle wrapper --gradle-version 8.7) from the gradle site, because I read that I would at least need gradle 8 to run JDK 17, which says "BUILD SUCCESSFUL in 5s", but my version is not upgraded. Any help would be very welcome!

@ryanmkurtz , this is the output.
Gradle 7.4.2
Build time:   2022-03-31 15:25:29 UTC
Revision:     540473b8118064efcc264694cbcaa4b677f61041
Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          11.0.12 (Microsoft 11.0.12+7)
OS:           Windows 10 10.0 amd64

You an see from that output that gradle is using Java 11.0.12.  It needs to be using 17+.

I'm going to assume this will work fine once you have gradle using the correct java version, so I'm closing.  Feel free to comment with additional questions if you are still having issues.

Thanks! I will give it a try tonight and let you know!
Op wo 1 mei 2024 om 17:36 schreef Ryan Kurtz @.***>:

I'm going to assume this will work fine once you have gradle using the
correct java version, so I'm closing. Feel free to comment with additional
questions if you are still having issues.
—
Reply to this email directly, view it on GitHub
https://github.com/NationalSecurityAgency/ghidra/issues/6472#issuecomment-2088645390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB3CKGF2EG45HWNIVMAFZLZAEDXLAVCNFSM6AAAAABHBXRT5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGY2DKMZZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@ryanmkurtz , thanks again! That was (obviously) the problem. I thought I needed to upgrade Gradle to use 17, sorry for the noobish question


instancetype: Do not overwrite EFI or BIOS with PreferredEfi

What this PR does
3a31137abe464d1560e9b693e91d311273ec69cd did not duplicate the original logic of PreferredUseEfi to ensure that we only apply PreferredEfi when a user has not provided their own EFI configuration and BIOS is additionally not enabled.

Fixes #12985
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

The `PreferredEfi` preference is now only applied when a user has not already enabled either `EFI` or `BIOS` within the underlying `VirtualMachine`.

/cherry-pick release-1.3

/retest-required


createCompilerHost cannot resolve 'lib' field from compiler options.

TypeScript Version:  4.0.3

Search Terms:

Could not resolve the path
lib
dom
esnext

Code
import fs from 'fs-extra';
import {
  CompilerOptions,
  createCompilerHost,
  createProgram,
  Diagnostic,
  getPreEmitDiagnostics,
} from 'typescript';
import readTSConfig from './read-tsconfig';
import readConfigWithCWD from './read-config-with-cwd';

interface OutputFile {
  name: string;
  data: string;
}

export default async function compileTypes(noEmit = true): Promise<Diagnostic[]> {
  const tsconfig = await readTSConfig();
  const config = readConfigWithCWD();
  const baseConfig: CompilerOptions = {
    ...tsconfig.compilerOptions,
    outDir: config.outDir,
    emitDeclarationOnly: true,
    moduleResolution: 2,
    noEmit,
  };
  // Create a Program with an in-memory emit
  const host = createCompilerHost(baseConfig);

  const files: OutputFile[] = [];

  host.writeFile = (name, data) => {
    files.push({
      name,
      data,
    });
  };

  // Prepare and emit the d.ts files
  const program = createProgram(
    [readConfigWithCWD().srcFile],
    baseConfig,
    host,
  );

  const result = program.emit();

  await Promise.all(
    files.map((file) => fs.outputFile(file.name, file.data))
  );

  return getPreEmitDiagnostics(program)
    .concat(result.diagnostics);
}

Example TSConfig:
{
  "exclude": ["node_modules"],
  "include": ["src", "types"],
  "compilerOptions": {
    "module": "ESNext",
    "lib": ["ESNext"],
    "importHelpers": true,
    "declaration": true,
    "sourceMap": true,
    "rootDir": "./src",
    "strict": true,
    "noUnusedLocals": true,
    "noUnusedParameters": true,
    "noImplicitReturns": true,
    "noFallthroughCasesInSwitch": true,
    "moduleResolution": "node",
    "jsx": "react",
    "esModuleInterop": true,
    "target": "ES2017"
  }
}

Expected behavior:
If the source file/directory does not have any compile-time errors, as well as has the valid tsconfig format, the diagnostics emitted by the program will be empty.
Actual behavior:

Interestingly, if the whole lib filename is provided (e.g. lib.esnext.d.ts), the path is resolved correctly. I assume that the lib values are not formatted before being read
Playground Link:
Related Issues:

This is the same API tsc uses, so I can assure you it's not fundamentally broken as is being described here.
I'm guessing your implementation of ./read-tsconfig is wrong - you need to go through the compiler API to turn the config file into a working CompilerOptions object. We may be able to assist with a more complete code sample but ultimately this is a bug in the sample, not a TS bug.

Here's read-tsconfig
import path from 'path';
import fs from 'fs-extra';
import { CompilerOptions, TypeAcquisition } from 'typescript';
import readConfig from './read-config';

export interface TsConfig {
  compilerOptions: CompilerOptions;
  exclude: string[];
  compileOnSave: boolean;
  extends: string;
  files: string[];
  include: string[];
  typeAcquisition: TypeAcquisition;
}

let TSCONFIG: Partial<TsConfig>;

export function getTSConfigPath(): string {
  return path.resolve(path.join(process.cwd(), readConfig().tsconfig));
}

export default async function readTSConfig(): Promise<Partial<TsConfig>> {
  if (TSCONFIG) {
    return TSCONFIG;
  }

  // Read config
  TSCONFIG = await fs.readJSON(getTSConfigPath()) as Partial<TsConfig>;

  return TSCONFIG;
}

and I also tried logging the json file:

you need to go through the compiler API to turn the config file into a working CompilerOptions object (i.e. not just JSON.parse)

Is the shape of CompilerOptions different than the compilerOptions field from tsconfig.json?

Well that was very hard to find.
Reference: https://github.com/microsoft/TypeScript/issues/5276
import { CompilerOptions, convertCompilerOptionsFromJson } from 'typescript';
import readConfig from './read-config';
import readTSConfig from './read-tsconfig';

export default async function readValidCompilerOptions(): Promise<CompilerOptions> {
  return convertCompilerOptionsFromJson(
    (await readTSConfig()).compilerOptions,
    process.cwd(),
    readConfig().tsconfig,
  ).options;
}


[REL] - 2024.9.1

Release details
Scheduled release date - 2024-09-17
Release captain responsible - @peytondmurray

1. Pre-flight checks

[x] Ensure there are no open issues with a block-release ⛔ label

2. Prepare the codebase for a new release

[ ] Create a new git branch for the release git checkout -b release-2023.9.1

[ ] Prepare the branch just in case git clean -fxdq

[ ] Bump conda-store version in conda-store/conda-store/__init__.py

[ ] Bump conda-store-server version in conda-store-server/conda-store-server/__init__.py

[ ] Update the conda-store-ui version used in conda-store-server conda-store-server/hatch_build.py

[ ] Update the CHANGELOG.md file with the new version, release date, and relevant changes[^github-activity].

[ ] Check the version locally with hatch version

[ ] Build and test locally

[ ] For conda-store and conda-store-server:
# Note you will need to run this twice, once for each package
cd conda-store # or cd conda-store-server
hatch build
twine check dist/*
hatch clean

[ ] Make a release commit: git commit -m 'REL - 2023.9.1'

[ ] Push the release (REL) commit git push upstream main

[ ] If a release candidate is needed, tick this box when we're ready for a full release.

3. Make the release

[ ] Start a new GitHub release

Call the release the current version, e.g. 2023.9.1
In the Choose a Tag: dropdown, type in the release name (e.g., 2023.9.1) and click "Create new tag"
In the Target: dropdown, pin it to the release commit you've recently pushed.
Add release notes in the field below[^github-activity]; you can copy/paste the Changelog from the CHANGELOG.md file.

[ ] Confirm that the release completed

The release GitHub action job has completed successfully in the actions tab.
The conda-store PyPI version is updated
The conda-store-server PyPI version is updated
The Docker images have been published

[ ] Update the conda-forge feedstock version through a PR or review and merge the regro-bot PR. (This should be picked automatically by the regro bot, but it can take a few hours)

[ ] If needed - update meta.yaml or recipe.yaml and re-render the feedstock.

[ ] Open a follow-up PR to bump conda-store and conda-store-server versions to the next dev-release number (for example 2024.10.1).
[ ] Celebrate, you're done! 🎉

[^github-activity]: If you wish, use github-activity to generate a Changelog, e.g. github-activity conda-incubator/conda-store --since 2023.9.1 --until 2023.10.1.

Will close and open a respective issue for an OCT release


Test hooks for MiniTest based suites?

Hey Toptal, Nice gem you've got here. I was pleasantly surprised several times while evaluating adding it to our stack, particularly when I saw the decidedly short list of runtime dependencies. Nice job!
As I add it to our stack, I notice that you've provided a nice set of test hooks for rspec, but I don't see anything for MiniTest. Is there anything out there?
If not, is there interest in providing a minitest helper similar to the rspec helper?

Hey, Robert! Thanks for your comment. Sure we are interested, why not? Just submit a PR.

@pyromaniac I took a rough pass at it yesterday and came up with this before running into a snag that looks sort of like #325, but I'll sort that out elsewhere. I'll submit a pull later but I wanted to run this pattern past your radar early on. I tried to pull out some of the functionality which can be shared between the spec helper and a minitest helper into a storage class that can sit on the side.
Thoughts / comments welcome.
# example test
class UserIndexTest < MiniTest::TestCase
  include SearchTestHelper

  test 'creating a user causes the index to update' do
    user_id = nil
    updates = assert_reindexes UsersIndex::User do
      user = create(:registered_user)
      user_id = user.id
    end

    # more to be done here, but something like:
    assert_includes updates.indexes_for(UsersIndex::User), user_id
  end

end

class SearchIndexCatcher
  def initialize
    @mutations = {}
  end

  def index(type:, update:)
    if body = update[:delete]
      mutation_for(type).deletes << body[:_id]
    elsif body = update[:index]
      mutation_for(type).indexes << body
    end
  end

  def indexes_for index
    mutation_for(index).indexes
  end

  def deletes_for index
    mutation_for(index).deletes
  end

  private
  def mutation_for type
    @mutations[type] ||= OpenStruct.new(indexes: [], deletes: [])
  end
end

module SearchTestHelper
  def assert_reindexes index, &test_actions
    type = Chewy.derive_type index
    catcher = SearchIndexCatcher.new

    bulk_mock = -> (*stuff) do
      Array.wrap(stuff).map {|y| y[:body] }.flatten.each do |update|
        catcher.index type: self, update: update
      end

      {}
    end

    type.stub :bulk, bulk_mock do
      Chewy.strategy(:atomic) do
        test_actions.call
      end
    end

    catcher
  end
end


wedev serve on a newly created project fails

webdev: 2.7.12
dart: Dart SDK version: 2.19.0-edge.6cc1c3c23c7b8ee0ca8291fc9d090cae9166d6f2 (be) (Fri Nov 4 13:24:57 2022 +0000) on "macos_x64"
ngdart: 1.2.0
steps followed:

dart pub global activate webdev
dart pub global activate ngdart_cli
ngdart create app
webdev serve in the app directory

Result:
[SEVERE] Failed to precompile build script .dart_tool/build/entrypoint/build.dart.
[SEVERE] This is likely caused by a misconfigured builder definition.
[SEVERE]
Unhandled exception:
Bad state: Unable to start build daemon.
#0      _handleDaemonStartup.<anonymous closure> (package:build_daemon/client.dart:79:21)
#1      _runUserCode (dart:async/stream_pipe.dart:11:23)
#2      Stream.firstWhere.<anonymous closure> (dart:async/stream.dart:1704:9)
#3      _RootZone.runGuarded (dart:async/zone.dart:1581:10)
#4      _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:392:13)
#5      _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:402:7)
#6      _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
#7      _SyncBroadcastStreamController._sendDone.<anonymous closure> (dart:async/broadcast_stream_controller.dart:399:22)
#8      _BroadcastStreamController._forEachListener (dart:async/broadcast_stream_controller.dart:322:15)
#9      _SyncBroadcastStreamController._sendDone (dart:async/broadcast_stream_controller.dart:398:7)
#10     _BroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:268:5)
#11     _AsBroadcastStreamController.close (dart:async/broadcast_stream_controller.dart:505:27)
#12     _RootZone.runGuarded (dart:async/zone.dart:1581:10)
#13     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:392:13)
#14     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:402:7)
#15     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
#16     _SinkTransformerStreamSubscription._close (dart:async/stream_transformers.dart:87:11)
#17     _EventSinkWrapper.close (dart:async/stream_transformers.dart:21:11)
#18     _StringAdapterSink.close (dart:convert/string_conversion.dart:251:11)
#19     _LineSplitterSink.close (dart:convert/line_splitter.dart:154:11)
#20     _SinkTransformerStreamSubscription._handleDone (dart:async/stream_transformers.dart:132:24)
#21     _RootZone.runGuarded (dart:async/zone.dart:1581:10)
#22     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:392:13)
#23     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:402:7)
#24     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
#25     _SinkTransformerStreamSubscription._close (dart:async/stream_transformers.dart:87:11)
#26     _EventSinkWrapper.close (dart:async/stream_transformers.dart:21:11)
#27     _StringAdapterSink.close (dart:convert/string_conversion.dart:251:11)
#28     _Utf8ConversionSink.close (dart:convert/string_conversion.dart:305:20)
#29     _ConverterStreamEventSink.close (dart:convert/chunked_conversion.dart:81:18)
#30     _SinkTransformerStreamSubscription._handleDone (dart:async/stream_transformers.dart:132:24)
#31     _RootZone.runGuarded (dart:async/zone.dart:1581:10)
#32     _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:392:13)
#33     _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:402:7)
#34     _BufferingStreamSubscription._close (dart:async/stream_impl.dart:291:7)
#35     _SyncStreamControllerDispatch._sendDone (dart:async/stream_controller.dart:782:19)
#36     _StreamController._closeUnchecked (dart:async/stream_controller.dart:637:7)
#37     _StreamController.close (dart:async/stream_controller.dart:630:5)
#38     _Socket._onData (dart:io-patch/socket_patch.dart:2362:21)
#39     _RootZone.runUnaryGuarded (dart:async/zone.dart:1593:10)
#40     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#41     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#42     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
#43     _StreamController._add (dart:async/stream_controller.dart:648:7)
#44     _StreamController.add (dart:async/stream_controller.dart:596:5)
#45     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1884:35)
#46     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1327:18)
#47     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#48     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
#49     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:123:13)
#50     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:194:5)

Dart 2.18 (2.18.4 (stable) on "linux_x64") works for me, so this is likely because of your edge SDK (2.19.0-edge.6cc1c3c23c7b8ee0ca8291fc9d090cae9166d6f2). Thanks for reporting this, though, because this allows us to avoid potential future problems. I'll look into this.
Are other build related tools working for you? Like do you get the same failure when running dart run build_runner build on code that uses packages that also rely on build like json_serializable, freezed, or built_value?

I ran dart run build_runner build in the same app directory and got
➜ dart run build_runner build
[INFO] Generating build script completed, took 358ms
[WARNING] ../../.pub-cache/hosted/pub.dev/build_modules-4.0.6/lib/src/module_cache.dart:21:70: Error: The method 'toJson' isn't defined for the class 'Object?'.
 - 'Object' is from 'dart:core'.
Try correcting the name to the name of an existing method, or defining a method named 'toJson'.
    (m) => MetaModule.fromJson(_deserialize(m)), (m) => _serialize(m.toJson()));
                                                                     ^^^^^^
../../.pub-cache/hosted/pub.dev/build_modules-4.0.6/lib/src/module_cache.dart:24:66: Error: The method 'toJson' isn't defined for the class 'Object?'.
 - 'Object' is from 'dart:core'.
Try correcting the name to the name of an existing method, or defining a method named 'toJson'.
    (m) => Module.fromJson(_deserialize(m)), (m) => _serialize(m.toJson()));
                                                                 ^^^^^^
[INFO] Precompiling build script... completed, took 1.5s
[SEVERE] Failed to precompile build script .dart_tool/build/entrypoint/build.dart.
This is likely caused by a misconfigured builder definition.

Switching to a stable dart version (2.18.4) works for me

Yeah, so from the stack trace it seems to be a problem with the official build_modules package.

Thanks, I'll close this

Thanks, I'll close this


Fix link to Custom Serializer section

Looks like the heading changed at some point, not allowing one to easily click down to that section

Thanks Brandon!
In the future, when your change is documentation-only, you can add [ci skip] to your commit message to avoid running the test suite.


About Obtaining All Request Headers in an HTTP Request

I want to obtain all the request headers when making an HTTP request. I've tried using

request.AllHeaders(), request.HeadersArray(), and request.HeaderValue()

methods within

page.OnRequest or page.OnRequestFinished

but I can only retrieve a few headers such as

Referer and User-Agent

headers. I am unable to get other headers, such as

Cookie

I also attempted using

page.Context().Cookies()

but with the same result. So, how can I retrieve all the request headers during an HTTP request? Thank you.

If you just need cookies, page.Context().Cookies() should work. If you need request headers, request.AllHeaders() should work.
Note, do not block request:
	chanReq := make(chan playwright.Request, 1)
	page.OnRequest(func(r playwright.Request) {
		// do not block request
		go func() {
			chanReq <- r
		}()
	})

	// handle request in another goroutine
	go func() {
		req := <-chanReq
		headers, err := req.AllHeaders()
		if err != nil {
			log.Print(err)
		} else {
			log.Print(headers)
		}
	}()

OK,I get it.The way I used is problematic.

request.AllHeaders() will block

page.OnRequest(func(r playwright.Request) {
// r.AllHeaders() is blocking
headers, _ := r.AllHeaders()
})

Am I right? Thank you.

如果您只需要 cookie，应该可以工作。如果您需要请求标头，应该可以工作。page.Context().Cookies()``request.AllHeaders()
请注意，不要阻止请求：
	chanReq := make(chan playwright.Request, 1)
	page.OnRequest(func(r playwright.Request) {
		// do not block request
		go func() {
			chanReq <- r
		}()
	})

	// handle request in another goroutine
	go func() {
		req := <-chanReq
		headers, err := req.AllHeaders()
		if err != nil {
			log.Print(err)
		} else {
			log.Print(headers)
		}
	}()

If you just need cookies, page.Context().Cookies() should work. If you need request headers, request.AllHeaders() should work.
Note, do not block request:
	chanReq := make(chan playwright.Request, 1)
	page.OnRequest(func(r playwright.Request) {
		// do not block request
		go func() {
			chanReq <- r
		}()
	})

	// handle request in another goroutine
	go func() {
		req := <-chanReq
		headers, err := req.AllHeaders()
		if err != nil {
			log.Print(err)
		} else {
			log.Print(headers)
		}
	}()

OK,I get it.The way I used is problematic.

request.AllHeaders() will block

page.OnRequest(func(r playwright.Request) {
// r.AllHeaders() is blocking
headers, _ := r.AllHeaders()
})

Am I right? Thank you.

right, currently all OnSomeEvent may have the same issue (playwrigh-go only). Hope it can be solved later.

right, currently all OnSomeEvent may have the same issue (playwrigh-go only). Hope it can be solved later.

I tried, but unfortunately, req.AllHeaders() blocked.
	chanReq := make(chan playwright.Request, 1)
	page.OnRequest(func(r playwright.Request) {
		// do not block request
		go func() {
			chanReq <- r
		}()
	})

	// handle request in another goroutine
	go func() {
		req := <-chanReq
		headers, err := req.AllHeaders() // Here is blocked.
		if err != nil {
			log.Print(err)
		} else {
			log.Print(headers)
		}
	}()

use page.Context().Cookies(url) to fix it. thanks.

use page.Context().Cookies(url) to fix it. thanks.


Birth date reset

The birth date in the profile always resets when editing the profile. Cause is the "startDate" value in state that has a value of "moment()"

Solved in PR #49


DatePicker handles firstDate incorrectly, does not let respective day be selected

Steps to Reproduce

Set myInitialDate to a Date representing 2019-11-03 15:00:00.000
Set `earliestDateToBePicked to a Date representing 2019-11-02 14:41:20.807952
Set latestDateToBePicked to a Date representing 2019-11-03 23:59:59.000
Use a DatePicker that is set up with the following code

    final DateTime picked = await showDatePicker(
      context: context,
      initialDate: _myInitialDate,
      firstDate: earliestDateToBePicked,
      lastDate: latestDateToBePicked,
    );

Execute the code, opens the DatePicker
In the DatePicker (both on iOS and Android), todays day (Saturday, 2019-11-02) cannot be selected even though it is set as firstDate:

Additional information I noticed when playing around with other dates for the three input values:
If you set initialDate to the same value as firstDate (2019-11-02 14:41:20.807952), the DatePicker opens with todays date selected. But if you then select tomorrows day, todays day gets disabled immediately.
Target Platform: Android and iOS (Built on Windows / mac)
Target OS version/browser: It seems like all, definitely tested and reproduced on Android: 7, 9, iOS: 13
Devices: Many different, does occurr on simulator as well as on physical devices
Logs
I did not want to attach all my logs (since there is a lot of custom loggin inside) but nothing is logged at this specific location when executing showDatePicker, therefore I did not attach logs.

Analyzing App...
No issues found! (ran in 51.8s)

[√] Flutter (Channel stable, v1.9.1+hotfix.5, on Microsoft Windows [Version 10.0.18362.418], locale de-DE)
    • Flutter version 1.9.1+hotfix.5 at O:\Tools\flutter
    • Framework revision 1aedbb1835 (2 weeks ago), 2019-10-17 08:37:27 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at O:\Libraries\androidsdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = O:\Libraries\androidsdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 38.2.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.39.2)
    • VS Code at C:\Users\.....\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.6.0

[√] Connected device (1 available)
    • STH100 2 •<PHONE_NUMBER> • android-arm64 • Android 6.0.1 (API 23)

• No issues found!

Hi @sceee
I believe it's possible you are referring to a 3rd party plugin,
if so please open an issue on the related github page.
If you are not referring to a 3rd party plugin,
could you please post a self contained app on github
or provide the steps to reproduce it.
Thank you

Hi @iapicca ,
I am referring to this Material library function: https://api.flutter.dev/flutter/material/showDatePicker.html
I just use it as explained above in the steps to reproduce (just set the dates accordingly).
Do you still need a self contained example app?

Hi again @sceee
I believe this code represent the situation you described.
thank you for the clarification

CC @darrenaustin

This looks like a problem with the firstDate having a time associated with it. The previous Date Picker would just compare these parameters with the grid values which don't have a time of 0:00:00. When that is compared to firstDate with a non-zero time it will be before the first date and wont' let you select it.
There was a recent redesign of the Material Date Picker. It ignores the times when comparing the dates, so it should fix this problem. See #50546 for more details.