Fix Text is clipped throughout the app when device font size is increased

Details

Fix what happens when the user increases the device font size in Android or IOS.
Fixed Issues

$ https://github.com/Expensify/App/issues/7541
Tests

Increase the device font size.
Open the App.
Verify there is no Text clipping throughout the app.

[X] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] iOS / native
[x] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[X] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[X] I verified any copy / text shown in the product was added in all src/languages/* files
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] Any functional components have the displayName property
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose and it is

[X] If a new CSS style is added I verified that:

[X] A similar style doesn’t already exist
[X] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

Increase the device font size.
Open the App.
Verify there is no Text clipping throughout the app.

[X] Verify that no errors appear in the JS console

Screenshots

Web

https://user-images.githubusercontent.com/51829206/166167473-9f6ef91c-119f-4f24-81ea-ba676591115f.mp4
Mobile Web

Desktop
https://user-images.githubusercontent.com/51829206/166167488-4dde32f7-4e54-4081-b279-705d1518da58.mp4

iOS

https://user-images.githubusercontent.com/51829206/163575882-d2d3b349-c9c5-4bcc-9cbb-6df8308573c3.mp4
Android

https://user-images.githubusercontent.com/51829206/163575925-b090f079-721b-4853-88d3-8a5f8f1dccb3.mp4

I've unassigned from the issue because I'll be OOO.
I'm sure a different C+ will review this soon

@osama256 is this ready for review! There is also a conflict that needs to be fixed first.

@osama256 is this ready for review! There is also a conflict that needs to be fixed first.

the conflict should be fixed now, is there any issue rather than this conflict?

@pecanoro Can you initiate the workflow to run checks!

@osama256 Can you add screenshots/videos for all platforms? I know this problem was only for mobile platforms, but we need to make sure it didn't create any regressions in any other one.

@pecanoro I added Desktop and web videos.

There is a conflict!

the conflict has been resolved.

When systemFontSize is increased doesn’t matter about the magnitude of the change, we would simply change the font size to max. We don’t have any range between default to max.

But if systemFontSize is decreased we would do absolutely nothing, just maintain the default fontSize.

So before these changing, decreasing the fontSize would actually decrease it in the app? If so, I assume that would be a regression, unless we don't want to do anything about it. Regardless, I think we might want to handle the range between default and max, not sure why we would skip those. @shawnborton what are you thoughts?

I'd be curious to see what the current app looks like when the font size is minimized.
As for this change, I think what we were running into was that any increase in font size caused the app to break in all kinds of places. I kind of like just having one zoom level where were can control the sizes of everything, but that being said, perhaps that's not good enough for accessibility purposes.

Also from your screenshots, it looks like the lowercase g is getting clipped:

Things may look a bit broken on the small screen. We need to consider the large screen devices, where one level font increase doesn’t look good at all, since we would have enough space for at least one are two levels.

I agree with you and I'm not happy with this result compared to what YouTube does (see the attached).
I gonna try to fix it in the next 3 days and if I failed this contract should be canceled and you should go with another contributor.
youtube  fontsizes.zip

I have finished, now we have multiple zoom levels between min and max like what YouTube does, you can see how it  look like in the attached screen shots.
all zoom levels.zip

@osama256
I see your recent commits are unsigned/unverified commits.
Also share the current behavior videos here, if the size is an issue then create a thread in channel #expensify-open-source, and post it there.
It would be easier to follow everyone.

@osama256
Also can you update the PR Description with little explanation what changes you did, why? Also update recent screenshot/videos across all platforms.
So that we can proceed with review.

@Santhosh-Sellavel I have updated all videos for all platforms and the PR Description, here is the current behavior video.
multiple-zoom-levels.mp4

Do we need to quit the app every time to get styles reflected?
Can you perform the following steps and send the video?

Open Larger Text Settings
Open our new Expensify app
Without clearing the app from recent perform step 1
Now change the text to a different size
Open our app from the background
Repeat steps 3, 4 & 5 with different size each time

@osama256

@Santhosh-Sellavel

Do we need to quit the app every time to get styles reflected?

Yes, it is normal and YouTube already doing the same thing.
https://user-images.githubusercontent.com/51829206/169803487-48e2d79a-1906-4ac6-981d-093da183d5de.mp4

Can you perform the following steps and send the video?

Sure.
https://user-images.githubusercontent.com/51829206/169803781-547ad618-eca4-4b05-82c9-7e64cb987649.mov

But in our existing app, font changes reflect without closing the app.

But I have explained this before here and you approved.

But I have explained this before here and you approved.

@osama256 In the same comment you mentioned that,

we can solve it by using Appstate listener if the App was in the background and opened this listener calculate the PixelRatio and save this value in a state or context then RenderHTMLConfigProvider takes its style depending on this value

So Background to Foreground changes should be reflected, I believe that's what is agreed upon here.
@rushatgabhane Can you confirm this one, thanks!
cc: @pecanoro

@Santhosh-Sellavel https://github.com/Expensify/App/issues/7541#issuecomment-1074294911 yes, I took it like a problem solution when @osama256 was explaining https://github.com/Expensify/App/issues/7541#issuecomment-1072867402

So Background to Foreground changes should be reflected

@Santhosh-Sellavel  No, we used the Appstate listener to stop this reflection, here is my comment explain why  Use Context or State to save TRenderEngineProvider and RenderHTMLConfigProvider components fontSize since it cause some troubles when trying to change the font size while the app is opening on iOS.

@rushatgabhane When we open the App in default device font size we see a normal font and when we open the App in a larger device font size we see a larger font, but when we try to change the device font size while the App is opening it shouldn't affect the App until the user close the App and open it again, the issue is we can't control HTML font size inside RenderHTMLConfigProvider like italic, bold, code from increasing or decreasing while the App is opening.
take a look at this issue: https://stackoverflow.com/questions/41807843/how-to-disable-font-scaling-in-react-native-for-ios-app
in levi Answer
Also note that some components wont obey font scaling settings, for example: Alert, PickerIOS, DatePickerIOS, TabBarIOS, SegmentedControlIOS as these are all natively drawn and don't rely on the Text component.

we can solve it by using Appstate listener if the App was in the background and opened this listener calculate the PixelRatio and save this value in a state or context then RenderHTMLConfigProvider takes it's style depending on this value

first we explained the App behavior it is the same as YouTube App behavior and if you read the previous comments you will find that we are trying to solve it inspired by YouTube fix, There is no contradiction here.
the issue was we need to Control/Stop italic, bold or code font size increasing/decreasing while the App is opening (which means stopping the font size change Reflection).
we solved it using the Appstate listener, when the device font size is increased while the App is opening (in the background) the pixelRatio value will increase and the italic or bold font size will try to increase, but the Appstate listener will get the new PixelRatio value and depending on this equation fontSize: pixelRatio * 16 > 21 ? 21 / pixelRatio : 16  the italic or bold font size will decrease and the final result will be the same as before the device font size increasing.

I agree as well that not needing to reopen the app after changing the font size is a nice touch.

Yes, it is but we need to ask some questions.
1. what are the Apps that enable this (Background to Foreground font change reflection) ? are they handled it well?
if we see how WhatsApp handling it we will find that when you open WhatsApp using the default device font size send the App to the BG(background) select the max device font size and resume the App you will find this.

but if you select the max device font size and open WhatsApp (not from BG) you will find this.

as you can see not handled well, two different results for the same font size level (max)
2.  Is it applicable in new Expensify App? Is it easy?
I tried to do this in new Expensify App the results I got are :

if you open the App using the default font size you will see default font without clipped texts.
if you open the App using the max font size you will see large font without clipped texts.
if you open the App using the default font size send the App to the BG select the max font size and resume the App you will see clipped texts.
if you open the App using the max font size send the App to the BG select the default font size and resume the App you will see too small font size.

which means we get different results for the same font size level (same as whatsapp).
Finally we will not say it is impossible or it is hard, but at least we can avoid dealing with this issue by following the YouTube approuch good engineers already doing this.

@osama256

@Santhosh-Sellavel No, we used the Appstate listener to stop this reflection, here is my comment explain why Use Context or State to save TRenderEngineProvider and RenderHTMLConfigProvider components fontSize since it cause some troubles when trying to change the font size while the app is opening on iOS.

Then there's might have been some misunderstanding/miscommunication.

So Background to Foreground changes should be reflected

Yes, I/We would still expect the same.

Yes, it is but we need to ask some questions.

1. what are the Apps that enable this (Background to Foreground font change reflection) ? are they handled it well?
if we see how WhatsApp handling it we will find that when you open WhatsApp using the default device font size send the App to the BG(background) select the max device font size and resume the App you will find this.
as you can see not handled well, two different results for the same font size level (max)

I'm not able to get that screen you referred to, but the font changes are reflected in background to foreground after changing font sizes.
There are some components for which font size is fixed. There might be more components, as of now, I found the following.

Tab Bar buttons with Image. (You can check youtube too, they too have similar components)

Native Keyboard All layouts Number/Qwerty. Font Sizes are always the same.

Few Apps try to keep Navbar text to of fixed font size. Ex: Youtube

The rest of the App content is dynamically adjusting to the changes in the text size.
Apps: I referred to WhatsApp, Facebook, Messages, Phone, and Apple music.
TLDR
Background to Foreground changes should be reflected without text getting clipped, thanks!
cc: @pecanoro

@Santhosh-Sellavel

I'm not able to get that screen you referred to

It is the second screen when you are logging in for the first time. (iPhone 6 Device).
Let's agree that YouTube doesn't have the background to foreground changes reflection in any of its components.
Let's agree that all Facebook apps(WhatsApp, Facebook, Messenger, Instagram) have bugs related to changing the device font size.
Facebook bug :

Messenger bug :

Instagram bug :

Also, the Apple music App has the same bug WhatsApp has (different results for the same font size level), here is what you get when you open the App using the default device font size :

and here is what you get when you open the App using Max font size, send it to BG, switch to the default, and resume the App :

you can check this video :
https://user-images.githubusercontent.com/51829206/171215944-87b9f7d3-aea0-4919-8977-e8e58011b57f.mp4
this confirms that it isn't a react native bug and will not be easy to solve.
the good news is we can skip it by restarting the App when the device font size is changed, Instagram already doing this although it has bugs.
https://user-images.githubusercontent.com/51829206/171228308-512966f9-e8ef-45f0-b584-a0bfa734e75e.mp4
we can implement this using react-native-restart and Async storage as the following :

when starting the App we will save the current Pixelratio in the Async storage.
when the user sends the App to the BG and changes the device font size then resumes the App, we gonna check in the Appstate listener if the current Pixelratio is different than the value in the Async storage this means the user has changed the device font size so we gonna save the new Pixelratio in the Async storage value and restart the App, otherwise don't do anything.

I think this is the only way we can enable the background to foreground changes reflection.

Honestly, since no app seems to be able to handle this properly without reopening the app, I don't mind simply doing so here as well. Also, because solving it seems way too complex for the initial scope of the issue. However, that is only my opinion and I might be totally wrong, so I will defer to @marcaaron to tell us what he thinks since he is also assigned to the review and he is a react jedi 😄

I'm not too sure tbh. The changes look OK to me. The only thing I'm unsure about is how this issue even got created. Besides that, the PR has some issues that need to be addressed - but it seems like a good change towards making things more accessible.

@osama256 Left a few more replies to your comments. Various things are still unaddressed.

Updated

@osama256 Few comments are not answered can you check and answer them.

@pecanoro Or @marcaaron Can you start the workflow here

I gonna create a new PR because there are a lot of unsigned commits in this PR.


feat: avatar rendering

Codecov Report
Patch and project coverage have no change.

Comparison is base (9c193f8) 24.38% compared to head (3e27bb8) 24.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   24.38%   24.38%
=======================================
  Files          47       47
  Lines        5479     5479
=======================================
  Hits         1336     1336
  Misses       4143     4143

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Doesnt show any data

Hello!
All the cards are empty data. Just checked the values with "show status" and i can see all of then avaible.
Can you give me a hand? Thanks

What did you do to fix this? I'm getting blank cards and have verified my options with show status.
Laravel 11
MySQL 8
Herd

Got it! In case anyone else comes looking, on the dashboard.blade.php file, be sure there are no line breaks on the 3 cards if you copy/paste from the readme.

@pelmered - Hmmm. Just to be sure, are you running php artisan pulse:check to run the pulse worker locally? I'm also including part of my pulse.config file for you as well.
Recorders\UserRequests::class => [
            'enabled' => env('PULSE_USER_REQUESTS_ENABLED', true),
            'sample_rate' => env('PULSE_USER_REQUESTS_SAMPLE_RATE', 1),
            'ignore' => [
                '#^/'.env('PULSE_PATH', 'pulse').'$#', // Pulse dashboard...
                '#^/telescope#', // Telescope dashboard...
            ],
        ],

\Maantje\Pulse\Database\Recorders\DatabaseRecorder::class => [
            'connections' => [
                'mysql' => [
                    'values' => [
                        'Connections',
                        'Threads_connected',
                        'Threads_running',
                        'Innodb_buffer_pool_reads',
                        'Innodb_buffer_pool_read_requests',
                        'Innodb_buffer_pool_pages_total',
                        'Max_used_connections'
                    ],
                    'aggregates' => [
                        'avg' => [
                            'Threads_connected',
                            'Threads_running',
                            'Innodb_buffer_pool_reads',
                            'Innodb_buffer_pool_read_requests',
                            'Innodb_buffer_pool_pages_total',
                        ],
                        'max' => [
                            //
                        ],
                        'count' => [
                            //
                        ],
                    ],
                ]
            ]
        ],

I got it working now. I think I solved it yesterday, but it took a while for any data to be recorded. And then I switched to another branch.


docs(proposal): monitoring of custom resources

This proposal is related to https://github.com/strimzi/strimzi-kafka-operator/issues/10276.
As this is my first proposal, so please let me know if any changes (also to the format) are needed.
@im-konge @scholzj can you please help me filling the TODO parts.
Thank you for your help and your work on this project.

@ppatierno yes I'm still interested, sorry for the delay. I hope to find the time this week.

@scholzj thank you for your suggestions and comments. I've tried to address them. Please let me know if something is missing or needs more clarification.

This proposal now has 6 (binding) votes +1. I will wait until tomorrow (Wednesday) EOB before I merge it - in case of some other comments.


When I use docker to start portia, how can I use portia to store data into multiple formats, such as json file or mysql?

Hello dear author, I need to learn portia when the need to crawl the data stored on the website to json file or mysql, but after reading your document I found that only mentioned mysql storage, can you please tell me about the storage of other Database or stored in json / excel file method?
my computer environment like this：
start portia with docker
Ubuntu 16.04
thank you very much!

I have found the solution as follows:

Close the open portia configuration page (use the process to kill)
2.Run the following order
docker run -i -t --rm -v ~ /portia_projects:/app/data/projects: rw -v /Your_output_floder:/mnt: rw -p 9001:9001 scrapinghub/portia portiacrawl /app/data/projects/Project_name Spider_name -o /mnt/Result_file


[XWAYLAND] XWayland context menus don't show after the first one

When using Java Swing programs such as GeoGebra 5 Classic (geogebra-5 in the AUR), context menus only open the first time any menu is opened. After that, none shows until I restart the program. This occurs regardless of fullscreen, tiled, or floating status.
I have attached a video demonstrating the issue:
https://user-images.githubusercontent.com/44881120/210221162-fa18546b-4f85-4d45-9211-d130831e2b3e.mp4
Note that I am using the hidpi patches, though I don't think it should affect this.

Observing the output of hyprctl clients, a window is created for the first context menu, but then no new windows are created after that for other context menus (hence they don't appear).

This also occurs with Krita (which hard-disables Wayland support for some reason), so I'm changing the issue title to reflect that.

I have confirmed this occurs only with the hidpi patches.

then it's not a hl issue?

Well, it does not occur on Sway with the same patches, so I think it would be a Hyprland issue.

I have collected logs for opening and closing the first context menu in Geogebra with both the hidpi patches and without.
hpyrlog_working.txt
hpyrlog_borked.txt
I noticed the borked log has an extra line:
[LOG] Cleanup: destroyed a window

cleanup will only destroy a window if the destroy event had been emitted.
In that case, it's purely an xwayland or wlroots issue.

I don't understand how you can be certain this is not a Hyprland issue since this doesn't happen in Sway with the same xwayland library. This is reproducible with any Qt or Swing app running in Xwayland (QT_QPA_PLATFORM=xcb kvantummanager, for example).
After opening and closing the menu once, then trying to open it again, the app behaves as if the context menu was opened, and sometimes you can even click the first element if you get lucky, or navigate with arrow keys. It just isn't rendered (and absolutely nothing is logged by Hyprlannd).
This is reproducible with the following patches to wlroots and xwayland respectively:
wlroots
hidpi.patch
crash_revert.patch (revert this one)
xwayland
733.patch

are you testing sway or sway-git?
sway uses a much older wlroots rev.

Hmm, I am indeed using sway. So this must be a wlroots issue then, as Sway can use the xwayland hidpi package fine. I'd test with swat-git, alas I appear unable to install it:
$ paru -S sway-git
resolving dependencies...
looking for conflicting packages...
:: sway-git and sway are in conflict. Remove sway? [y/N] y
:: wlroots-git and wlroots are in conflict. Remove wlroots? [y/N] y
error: failed to prepare transaction (could not satisfy dependencies)
:: removing wlroots breaks dependency 'libwlroots.so=10-64' required by cage
:: removing wlroots breaks dependency 'libwlroots.so=10-64' required by gamescope
:: removing wlroots breaks dependency 'wlroots<0.16' required by wayfire

If sway-git exhibits this issue, then indeed it is not a Hyprland issue.

idk if it does. I can test it tomorrow. Ping me on discord plox

confirmed same happens on sway
xwayland / wlroots issue (most likely xwayland, as @fufexan said he doesnt have the issue and I assume he's on latest git of hl (so wlroots is the same as us)


Cloudflare HTTP Proxy causes palette loading to fail

When enabling the HTTP proxy on cloudflare, node-red fails to load the palette, claiming "Imported unrecognized types". Works fine when cloudflare proxy disabled.
HTTP_PROXY Environmental variable set outside of settings.js:
HTTP_PROXY=http://cloudflare.com:443
SSL successfully terminates on HAProxy load balancer in front of node-red, but the same problem exists when node-red itself is setup for HTTPS.
Node-RED version: v0.16.1
Node.js  version: v6.9.4
The following messages are displayed in the console:
red.min.js:16 WebSocket connection to 'wss://test.mydomain.io/comms' failed: Error during WebSocket handshake: Unexpected response code: 503
Uncaught TypeError: d._ is not a function
at Array.eval (main.min.js:16)
at WebSocket.d.onmessage (red.min.js:16)

Disable the RocketLoader in CloudFlare, it's still in beta and doesn't work well with any javascript heavy website.

@Belphemur ......I would just like you to know that my gratitude right now is astronomical. I've been trying to fix this for weeks. I can't believe it was all because of that, wow. Thanks!


Change the base test class to fix the handling of the Mockery expectations

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 78.267%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
4354

Relevant Lines:
5563

💛  - Coveralls


chamfers in cyl() are baffling when r1 != r2

Nothing seems to work as expected/documented.  What is chamfang?  Angle with the top?  It's wrong.  Need to swap 90-vang and vang in definition of chang1 and chang2.  You can get an error that your chamfer is too big when really the problem is your angle is too small.  You can get a bogus error from giving chamfer=75 and then hiding it with chamf1=1, chamf2=2.  Suggest:
                assert(chamf1 <= r1, str("chamfer",is_def(chamf1)?"1":""," is larger than the r1 radius of the cylinder."))

There is code duplication between the module and function version that means this all needs to be fixed twice, unless it's consolidated.  It should really be consolidated, since both codes construct a VNF using rotate_sweep().  Module should just invoke the function.  The default chamfer angle isn't documented and is very baffling at the moment, though with the above angle swap it would make sense and would be the half-angle at each corner.  I guess it's 90 - half_angle right now.  chamf1 and chamf2 are they supposed to be length along the top/bot?  It looks like it because they are compared to the radius.  But dy1 and dy2 are computed under the assumption they are measured along vertical axis.  And in fact they seem to be scaled by chang1 and chang2.
How is it supposed to work?  Angle measured relative to where?  Chamfer length measured how?  Along the top/bottom circle by default?  Along angled cone size if from_end==true?  Or along the vertical axis in that case?

It's worse than I thought:  if you ask for a texture the chamfer shape changes:
cyl(r1=10, r2=3, h=8,chamfer1=1,chamfer2=1);
right(18)
  cyl(r1=10, r2=3, h=8,chamfer1=1,chamfer2=1,texture=texture("bricks",n=10,roughness=0),tex_scale=.01);

Same chamfer args, different result.  I think there should be a single function, _cyl_profile() that computes the profile from all the chamfer and rounding args rather than what I see now, where it is recomputed in different places.  I'm not sure if the module and function versions of cyl() have some good reason to redo the work instead of module just calling function, but having a single profile computation would clean things up.


Embed help information in artifact

Maybe check for a --help literal on command line?

Closed by #29


[ModuleCatalog] Adapt Watch Mechanism to Monitor ModuleReleaseMeta CR Changes

Description:
The current watch mechanism for ModuleTemplate in the Kyma lifecycle manager needs to be adapted to track changes in the ModuleReleaseMeta Custom Resource (CR). This will enable the detection of new versions, channel switches, and other updates related to modules. The existing ModuleTemplate watch mechanism can be found here.
Detailed decision ticket: https://github.com/kyma-project/lifecycle-manager/issues/1815
Requirements:

The new watch mechanism must observe the ModuleReleaseMeta CR for changes, including:

Addition of new module versions.
Channel changes.
Any other relevant updates to the module-to-channel mappings.

Kyma Requeue Logic:

Requeue all Kymas that have a module enabled with the specific channel defined in the ModuleReleaseMeta.
Kymas with modules enabled by a specific version should not be requeued if the version remains unchanged.

Change in Implementation:

The current implementation uses EnqueueRequestsFromMapFunc in setup.go to watch changes, which does not allow for the comparison of old and new states of the ModuleReleaseMeta CR.
Switch to handler.Funcs{...}. This will allow access to both the old and new states in the Update function for proper reconciliation.

Example Code to get the diff in the Watch mechanism:
// ModuleReleaseMetaEventHandler implements handler.EventHandler
type ModuleReleaseMetaEventHandler struct{}

// Create handles Create events
func (c *ModuleReleaseMetaEventHandler) Create(e event.CreateEvent, q workqueue.RateLimitingInterface) {
	// Handle create logic if needed
}

// Update handles Update events and gets old and new state
func (c *ModuleReleaseMetaEventHandler) Update(e event.UpdateEvent, q workqueue.RateLimitingInterface) {
	log.Info("Resource updated", "Old Object", e.ObjectOld, "New Object", e.ObjectNew)
	kymaList := GetAllKymas()

	// Access both old and new objects
	// e.ObjectOld is the old state of the object
	// e.ObjectNew is the new state of the object
	affectedKymas := getAffectedKymas(kymaList, e.ObjectOld, e.ObjectNew)

	// With q.Add, we can add objects to the Reconcile Queue
	for _, kyma := range affectedKymas {
		q.Add(reconcile.Request{
			NamespacedName: types.NamespacedName{
				Name:      kyma.GetName(),
				Namespace: kyma.GetNamespace(),
			},
		})
	}
}

// getAffectedKymas determines which Kymas are affected by the update
func getAffectedKymas(kymas []v1beta2.Kyma, oldModuleReleaseMeta, newModuleReleaseMeta TypedUpdateEvent) []v1beta2.Kyma {
	var affectedKymas []v1beta2.Kyma
	for _, kyma := range kymas {
		for _, statusModule := range kyma.Status.Modules {
			if statusModule.Channel == newModuleReleaseMeta.Channel {
				affectedKymas = append(affectedKymas, kyma)
			}
		}
	}
	return affectedKymas
}

// Delete handles Delete events
func (c *ModuleReleaseMetaEventHandler) Delete(e event.DeleteEvent, q workqueue.RateLimitingInterface) {
	// Handle delete logic if needed
}

// Generic handles generic events
func (c *ModuleReleaseMetaEventHandler) Generic(e event.GenericEvent, q workqueue.RateLimitingInterface) {
	// Handle generic events if needed
}

func (r *Reconciler) SetupWithManager(mgr ctrl.Manager, opts ctrlruntime.Options, settings SetupOptions) error {
	...
	if err := ctrl.NewControllerManagedBy(mgr).For(&v1beta2.Kyma{}).
		Named(controllerName).
		WithOptions(opts).
		Watches(&v1beta2.ModuleTemplate{},
			&handler.Funcs{
				UpdateFunc: func(e event.UpdateEvent, rli workqueue.RateLimitingInterface) {
					// Call the custom update handler
					customHandler := &ModuleReleaseMetaEventHandler{}
					customHandler.Update(e, rli)
				},
			},
			builder.WithPredicates(predicates)).
		Watches(&apicorev1.Secret{}, handler.Funcs{}, builder.WithPredicates(predicates)).
		Watches(&v1beta2.Manifest{},
			handler.EnqueueRequestForOwner(mgr.GetScheme(), mgr.GetRESTMapper(), &v1beta2.Kyma{},
				handler.OnlyControllerOwner()), builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).
		WatchesRawSource(source.Channel(runnableListener.ReceivedEvents, r.skrEventHandler())).
		Complete(r); err != nil {
		return fmt.Errorf("failed to setup manager for kyma controller: %w", err)
	}
	return nil
}

Acceptance Criteria:

[ ] Implement the new watch mechanism for ModuleReleaseMeta CRs.
[ ] Create a follow up to remove the ModuleTemplate watch mechanism and replace it completely with a new one.
[ ] Current watch mechanism should stay but it should be reduced to scope in only the ModuleTemplates that have a channel assigned
[ ] Reconcile corresponding Kyma CRs:

Reconcile all Kymas that have modules enabled via the specified channel when a ModuleReleaseMeta CR is created, updated, or deleted.
Ensure Kymas with a specific version assigned (not tied to a channel) are not requeued.

[ ] Cover the functionality with tests to ensure that the watch mechanism and requeue logic work correctly.
[ ] Update affected documentation

Follow-Up:

https://github.com/kyma-project/lifecycle-manager/issues/1955


Google updates

Update Google-related depedencies
Do not retry on FileNotFound error

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.86%. Comparing base (c97ff93) to head (67ee126).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   63.86%   63.86%
=======================================
  Files          40       40
  Lines        2142     2142
=======================================
  Hits         1368     1368
  Misses        774      774

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


No warning message for typescript for using different ToolsVersions property

Open a project in VS2015 with TypeScriptToolsVersion set to 1.4.  Expected an warring message that version of the project is out-dated. actual not error.
Also building should show and error for missing tools version. actual no.
This breaks backward compatability for VS projects.

This will be in the next release for VS 2015.

@paulvanbrenk  what is the behavior on build? do we get a warning as well if the toolset (older) is not installed on the machine?

@mhegazy No, we removed that a while ago. It was considered annoying, since they already got the warning on project open.


Metadata Issue

I'm trying to enable skin layers, but it doesn't work.
I don't understand why, there is no console error.
I'm using 1.12.2.
This is my code for creating an NPC:
        NPC npc = NPC.builder()
                .profile(this.createProfile(name, skin))
                .location(location)
                .imitatePlayer(false)
                .lookAtPlayer(false)
                .build(this.npcPool);

        npc.metadata().queue(MetadataModifier.EntityMetadata.SKIN_LAYERS, true).send();

Is there something I'm doing wrong? Or is this just supposed to work.
Version: 2.6-RELEASE

That helped and now it works.
Thanks for the help and for this lib.

Good to hear!


The number of entities in the provided knowledge_embedding does not match with Wikidata5m

Hi, thanks for the excellent work and paper.
The paper mentions that you used the Wikidata5m as the knowledge graph and excluded some triples in downstream tasks.
After downloading the knowledge_embedding from https://thunlp.oss-cn-qingdao.aliyuncs.com/zzy/knowledge_embedding.tar and loading it by KE_Embedding in all_embedding.py, I observed that there are 5,040,986 entities in total, which doesn't match the number of entities in Wikidata5m (4,594,485).
I am confused about this. Did I miss or misunderstand something?

Thank you for your interest in our work and for highlighting the discrepancy in entity counts. You are correct; there is a mismatch. We used entity descriptions from Wikidata5m for RA and entity embeddings from ERNIE for E-BERT and Map-tuning. Both of these sources contain approximately 5 million entities, leading to the mismatch you've noticed. We will update the paper on arXiv to correct this error. Thank you once again for pointing out this inconsistency.

Thanks for your explanation.


FEATURE: add job_name and queue_name labels to delayed job metrics

New labels are added to the delayed job metrics.

A queue_name was added for all metrics
The existing job_name metrics was added for all metrics
The enqueued_total and pending_total gauges metrics now use per queue totals

This closes https://github.com/discourse/prometheus_exporter/issues/147
Thanks @mauricepoirrier for all the help

I just realized that there were tests for the delayed job collector, I will fix them

I just realized that there were tests for the delayed job collector, I will fix them

Hey @SamSaffron have you had the chance to take a look at this? Sorry for the poke.

Hey @SamSaffron have you had the chance to take a look at this? Sorry for the poke.

On holidays, will look at this in a week and a half
On Sun, 17 Jan 2021 at 2:48 am, Juan Ignacio Donoso <
<EMAIL_ADDRESS>wrote:

Hey @SamSaffron https://github.com/SamSaffron have you had the chance
to take a look at this? Sorry for the poke.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/prometheus_exporter/pull/151#issuecomment-761585119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABIXLIYF33J6NC5K6BLB3S2GYNJANCNFSM4V26PVQA
.

On holidays, will look at this in a week and a half
On Sun, 17 Jan 2021 at 2:48 am, Juan Ignacio Donoso <
<EMAIL_ADDRESS>wrote:

Hey @SamSaffron https://github.com/SamSaffron have you had the chance
to take a look at this? Sorry for the poke.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/discourse/prometheus_exporter/pull/151#issuecomment-761585119,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABIXLIYF33J6NC5K6BLB3S2GYNJANCNFSM4V26PVQA
.

No problem!, enjoy!

No problem!, enjoy!

Looks like all tests are passing, seems good to me! thanks!
Do we need any readme updates?

Looks like all tests are passing, seems good to me! thanks!
Do we need any readme updates?


Remove the updater in favor of dependabot.

Looks good to me. Could you update the changelog as well?


Possibility to set webDriver's capabilities through the Configuration

It would be convenient if setting webDriver's capabilities(or some capabilities)  was available through the Configuration. And webDriver (created automatically by Selenide) could use this information about capabilities from Configuration.
Could you add this feature, please?
For example
In Selenide 4.x (and in Selenium 3.x)
It can be possible to use old versions Firefox (v<48) with Firefox webDriver
For this purpose, capability "marionette" should be set as false, and these capabilities should be used in webDriver creation.
According to Wiki page "How Selenide creates WebDriver"
two described options work correctly.
Option 1 - custom creation Firefox webDriver
DesiredCapabilities capabilities = new DesiredCapabilities();
capabilities.setCapability("marionette", false);
setWebDriver(new FirefoxDriver(capabilities));
However, custom webDriver creation requires custom webDriver closing.
Option 2 - usage factory that implements interface WebDriverProvider
Both these methods are not easy to understanding for beginners and a bit bulky.

Hi @juliaviluhina !
Thank you for the ticket, but isn't it a duplicate of #397 ?

Hello @asolntsev  )
Yes, you are right, it is a duplicate of #397
I close my ticket

@juliaviluhina 4.2 has solution for both using firefox without marionette and adding any arbitary capability via command line (SystemProperties)


Equal houses

I have installed pyswisseph 2.05.01 (latest).
Using flatlib input:
date = Datetime('2018/08/14', '12:00', '+01:00')
pos = GeoPos('46n30', '16e14')  # Globoka, Slovenia, EU
chart = Chart(date, pos, hsys='Equal')
I get output:
<House1 Scorpio +10:12:25 30.0>
<House2 Sagittarius +10:12:25 30.00000000000003>
<House3 Capricorn +10:12:25 30.0>
<House4 Aquarius +10:12:25 30.0>
<House5 Pisces +10:12:25 30.0>
<House6 Aries +10:12:25 30.0>
<House7 Taurus +10:12:25 30.0>
<House8 Gemini +10:12:25 30.0>
<House9 Cancer +10:12:25 30.0>
<House10 Leo +10:12:25 30.0>
<House11 Virgo +10:12:25 30.0>
<House12 Libra +10:12:25 29.99999999999997>
While error is nano size, it is still an erroneous output. Houses 2 & 12 are wrong size.
Simon
S love nia

Could you please check with the following change while building the chart?
chart = Chart(date, pos, hsys=const.HOUSES_EQUAL)
You need to refer to the house system using the constants defined in const.py..

Tried, as per Joao's instructions, ... hsys=const.HOUSES_EQUAL. Same result.
Simon
S love nia

Clicking 'Charts Web application' on flatangle.com gives attached
notification.
Lol, I see we have a same goal:
"his main interests is the use of computational tools for statistical
research in astrology"
Me too have idea to put astro calculations online. Also a research
database, etc. Perhaps you care for some coding help? But be warned, I am
programming beginner, and slow learner. Currently familiar with python,
django 2, html, bootstrap 4, and some c#, but it gave me trouble learning,
and I switched to python. Ufff, what a difference. :o
Unemployed for years, dedicated to astrology. First choice was indian
astrology, but open for western and other astrology branches as well. After
all, the planets are all the same.
Have fun,
Simon
S love nia
On Mon, Aug 20, 2018 at 7:57 PM João Ventura<EMAIL_ADDRESS>wrote:

Could you please check with the following change while building the chart?
chart = Chart(date, pos, hsys=const.HOUSES_EQUAL)
You need to refer to the house system using the constants defined in
const.py..
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flatangle/flatlib/issues/16#issuecomment-414407215,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJKo8WMOnncTQwRGK2I9g01NV7hg0PIZks5uSvibgaJpZM4WChzi
.


Found no unsent transaction

doesn't see transaction. When there were 3 confirmations the application saw pledge of 1000 coins. When there were 15 confirmations and time to start a masternoda has come it reports that there is no pledge. But masternode was all the same started despite preventions.

Do you have these options in your zcoin.conf?
addressindex=1
spentindex=1
timestampindex=1
txindex=1

You need to start zcoin-qt/zcoind with -reindex option after adding them.
And yes, znode will start successfully if you entered all data correctly. Collateral TX check is for convenience only.

@yura-pakhuchiy реиндекс помог, спасибо.

Made -reindex but still dont see the input.Spending the reward from Trezor without the coin control is the problem


test_trit_array_5 test failed on bootlin x86_64 toolchain.

CI should test toolchain using "bazel test" instead of "bazel build" in .buildkite/pipeline.yml.
I got a test failed in //common/trinary/tests:test_trit_array_5
//common/curl-p/tests:test_cpu_hamming                                   PASSED in 0.1s
//common/curl-p/tests:test_cpu_hashcash                                  PASSED in 154.9s
//common/curl-p/tests:test_curlp                                         PASSED in 0.2s
//common/curl-p/tests:test_curlp_bct                                     PASSED in 0.3s
//common/curl-p/tests:test_curlp_ptrit                                   PASSED in 0.2s
//common/helpers:tests                                                   PASSED in 0.7s
//common/kerl/tests:test_converter                                       PASSED in 0.4s
//common/kerl/tests:test_kerl                                            PASSED in 0.3s
//common/model/tests:test_transaction                                    PASSED in 0.1s
//common/network/queues/test:test_concurrent_queue                       PASSED in 0.3s
//common/sign/v1/tests:test_iss_curl                                     PASSED in 1.0s
//common/sign/v1/tests:test_iss_kerl                                     PASSED in 0.5s
//common/sign/v2/tests:test_iss_curl                                     PASSED in 1.8s
//common/trinary/tests:test_add                                          PASSED in 0.2s
//common/trinary/tests:test_byte                                         PASSED in 0.1s
//common/trinary/tests:test_long                                         PASSED in 0.4s
//common/trinary/tests:test_ptrit                                        PASSED in 0.2s
//common/trinary/tests:test_trit_array_1                                 PASSED in 0.2s
//common/trinary/tests:test_trit_array_4                                 PASSED in 0.1s
//common/trinary/tests:test_tryte                                        PASSED in 0.2s
//common/trinary/tests:test_tryte_long                                   PASSED in 0.3s
//cppclient:tests                                                        PASSED in 0.5s
//mam/v1/tests:test_mam                                                  PASSED in 4.5s
//mam/v1/tests:test_mask                                                 PASSED in 0.2s
//mam/v1/tests:test_merkle                                               PASSED in 7.7s
//tanglescope/common:common_test                                         PASSED in 0.2s
//tanglescope/runner:tests                                               PASSED in 0.1s
//tanglescope/statscollector:tests                                       PASSED in 0.2s
//common/trinary/tests:test_trit_array_5                                 FAILED in 0.4s
Executed 29 out of 29 tests: 28 tests pass and 1 fails locally.
INFO: Build completed, 1 test FAILED, 1029 total actions

Here is the failed log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //common/trinary/tests:test_trit_array_5
-----------------------------------------------------------------------------
common/trinary/tests/test_trit_array.c:61:test_trit_array_static:PASS
common/trinary/tests/test_trit_array.c:32:test_trit_array_static_set:FAIL: Expected 0 Was -1
common/trinary/tests/test_trit_array.c:63:test_trit_array_static_slice:PASS
common/trinary/tests/test_trit_array.c:64:test_trit_array_static_to_int8:PASS

-----------------------
4 Tests 1 Failures 0 Ignored
FAIL

Fixed in https://github.com/iotaledger/entangled/pull/109


Scrollable Scene.

Hi there! I am new in ios development and i have a question: is there any method or implementation of making macaw scene scrollable. Example: periodic table example is not fits in my iphone 6, so i want big scene to be scrollable +zoom functionality.  Is something exist that can do it in Macaw?

Hi @Fames42,
We're planning to include built-in zooming for MacawView in the next release.

MacawView.zoom is available.


when growing the selection the whole document is too easily selected

This causes problems when sending the selection to the console without enough care
Selection growing should not expand to the whole docuement

won't fix


Interchange Slick Slider Compatibility Issues

Zurb has recommended using the Slick carousal instead of Orbit. When using an Interchange image as the last image with Slick, the last image will not show. Slick clones the first & last carousal sliding containers. The first container is cloned and placed at the end of all the other containers. The last container is cloned and placed at the beginning of all other containers.
The Interchange script fails here due to it looking for the first instance to change the source
      directives : {
        replace: function (el, path, trigger) {
          if (/IMG/.test(el[0].nodeName)) {
            var orig_path = el[0].src;
            if (new RegExp(path, 'i').test(orig_path)) return;
            el[0].src = path; //Fails here, src is applied to cloned img since it is first

By applying the path to all items as shown below, it seems to work. I'm not sure if this creates any new issues though.
      directives : {
        replace: function (el, path, trigger) {
          if (/IMG/.test(el[0].nodeName)) {
            var orig_path = el[0].src;
            if (new RegExp(path, 'i').test(orig_path)) return;
            $.each(el, function(){this.src = path;});

I don't understand why this issue is closed both here and on Slick. It seems far from solved.
Is there now a consensus that Interchange cannot be used with Slick?
What's the alternative?

Use an alternative like Mobile Detect?

@senlin If you're looking for a quick fix, apply the one I suggested up above. It should work fine with the latest version of Slick.

@mattferderer that's unfortunately hardly sustainable as that would mean I cannot update Foundation anymore...

@senlin Why would this stop you from updating Foundation? You would just have to make a note to make this minor change when you update it. The last time I updated Foundation I found several files that I needed to modify due to new bugs introduced. For example I had to revert the Reveal component files because of this issue https://github.com/zurb/foundation/issues/6154
I would say whenever updating Foundation or most other open source packages, testing & debugging comes with the territory.

@mattferderer it might be sth easy and quick if you run one site, but when building sites for different clients I find this to be unsustainable.

just call with slick init the  $(document).foundation('interchange', 'reflow'); function! Than it works pretty well.
Example:
$( ".slideshow" ).each(function() {
$( this ).slick({
centerMode: true,
autoplay: false,
infinite: true,
centerPadding: '10rem',
slidesToShow: 1,
dots: true,
})
$(document).foundation('interchange', 'reflow');
});


Mochawesome updated to 5.0.0 introduces a breaking change.

** Please describe which feature you have a question about? **
Cypress tests using mochawesome.
** Provide additional details**
Just a heads up, if you set up your cypress tests per the tutorial you may have added this command to your build:
npm install wait-on<EMAIL_ADDRESS>mochawesome mochawesome-merge mochawesome-report-generator

Mochawesome just dropped v5.0.0 today which introduces a breaking change. If you have<EMAIL_ADDRESS>installed you will get an error:
Error: Cannot find module 'mocha/lib/stats-collector'

Mochawesome 5.0.0 breaks when it doesn't find this module.
The fix is to install a version of mocha 6.0.0 or higher which includes stats-collector. For our purposes we just omitted the 5.2.0 and it worked fine.
npm install wait-on mocha mochawesome mochawesome-merge mochawesome-report-generator

An alternative would also be to pin<EMAIL_ADDRESS>

We made the code change of our cypress preTest phase. If you have any questions about this, please feel free to reopen the issue! Thank you!


Fix invalid JSON in bower file

great, thanks. would be cool if you could release a new version on all platforms asap 👍

done


Missing resource-group argument in az cli commands

The two commands under 1 and 2 of:
https://docs.microsoft.com/en-us/azure/iot-edge/quickstart-linux?view=iotedge-2020-11#register-an-iot-edge-device
az iot hub device-identity create --device-id myEdgeDevice --edge-enabled --hub-name {hub_name}
and
az iot hub device-identity connection-string show --device-id myEdgeDevice --hub-name {hub_name}

... are both missing this argument:
--resource-group {hub_resource_group_name}
When this argument is ommitted I get the error message:
"Unable to find IoT Hub: xxxx in resource group: learn-ae983xxxxxxxxxxxxxxxxxxxxxxxxx"

I don't know why 'learn-ae983xxxxxxxxxxxxxxxxxxxxxxxxx' is mentioned or what it is, btw.

Best, Robert

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e2289383-6ce2-a036-c710-7d1fad6e1700
Version Independent ID: 3b902941-0876-17c3-3f0b-a4b7f7770531
Content: Quickstart create an Azure IoT Edge device on Linux
Content Source: articles/iot-edge/quickstart-linux.md
Service: iot-edge
GitHub Login: @PatAltimore
Microsoft Alias: patricka

@robert4os Thanks for the feedback! We are currently investigating and will update you shortly.

@robert4os I am able to run both 1&2 commands without any issues. There is no need to mention the resource-group name if you are using the same subscription.

If you are still getting the same error I suggest you select the correct subscription.
Select-AzureSubscription  -SubscriptionName <String>

@PatAltimore Can you review this feedback and add a note if there is any recent changes with Powershell, azcli and aziot versions?
@robert4os Since you are unblocked and able to run the commands in cloud shell, Do let us know if you have any further queries or we are good to close this issue.

@AshokPeddakotla-MSFT - I was never really blocked, because I already knew the workaround. My intention was to help improve the docs for others. When you see no further room for improvement, you can close the issue on my account :)

@robert4os Thanks for the confirmation. I have notified to the author and SME @PatAltimore to review and update the doc if necessary.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Update index.md

Doc didn't create cluster because cluster and create commands were in wrong order.  This pr fixes that.

Hi @bobhenkel , thanks for creating this PR :)
However, the Docs are already made for v3.0.0-rc.7 which will be released GA today :+1:


How to modify user roles

Hi Pony,
I want to modify an existing user's roles (role and visibleApps),  not invite new user.  I look from appstore api document, it contain "Modify a User Account" api, but I don't find the related code from your api.py file. would please have a check, thanks very much.

@yangcaixing Thanks for reporting this. You're right modifying and removing a user account are missing from the library, I am working on it to add them.

Thanks pony, I'm looking forward to your update.

@yangcaixing I have just made a new commit that allows to modify a user's role. You can try with:
from appstoreconnect import Api, UserRole

user = list(api.list_users())[0]
api.modify_user_account(user, roles=[UserRole.FINANCE, UserRole.APP_MANAGER, UserRole.ACCESS_TO_REPORTS])

I still have to add support for updating the visibleApps

Well, I've also handled visibleApps :
	apps = api.list_apps(filters={ 'name': 'My great app'})
	app = list(apps)[0]
        user = list(api.list_users())[0]
	user = api.modify_user_account(user, visibleApps=[app])

Let me know if everything works as expected before I close this issue.

Hi pony,
I have update appstoreconnect to v0.8.4, run the code have bellow errors. and I also check from the library api.py file, there no modify_user_account function existed, could you please check again, thanks.
Traceback (most recent call last):
File "appstore.py", line 4, in
from appstoreconnect import Api, UserRole
ImportError: cannot import name 'UserRole'
Traceback (most recent call last):
File "appstore.py", line 40, in
api.modify_user_account(user, roles=[UserRole.FINANCE, UserRole.APP_MANAGER, UserRole.ACCESS_TO_REPORTS])
AttributeError: 'Api' object has no attribute 'modify_user_account'

I have update appstoreconnect to v0.8.4

The modify_user_account endpoint is not yet included in a release published on PyPI. You have to checkout this repository to test it.

Hi pony, I have checkout the repo and test,  it works now, thanks very much.

I have checkout the repo and test, it works now,

Great! I am closing the issue then. I'll publish a new version including it soon.

Hi Pony,
BTW, I want to list a use's visibleApps, to check if user have some specific app's roles, but I don't find the visibleApps attribute under apple User.Attributes, could you help check it , thanks.

Hi @yangcaixing,
BTW, my name is not Pony 😄 I am Patrice.
You should be able to get a user's visible apps with: user.visibleApps() but it currently doesn't work. I have to implement the VisibleApps resource (https://developer.apple.com/documentation/appstoreconnectapi/user/relationships/visibleapps)
You can open a separate issue for this.

Hi Patrice,
I'm sorry for call your name wrong, and I will open a new issue for this, thanks.


Bump zsearch definitions to at least 0.1.13

FWIW, I'd have been fine doing this in the other SMB PR.


Fix initial security.json rbap rules

Fixes #274 and #289
Very minor change to remove the users role from the all permission, move the all permission to the last index in the json file, and add a new rule for the /admin/zookeeper/status path needed for updates to the exporter in 8.9 (see #289 )
Manual integration-style testing required:
Create a SolrCloud running Apache Solr 8.9.0, created a collection, and then tried to index some docs as the solr user, which now fails with a 403 ~ Unauthorized. Indexing as the admin user works. The solr user can log in to the Admin UI but can only query collections.
Also verified the Prometheus exporter (also running 8.9) can now retrieve metrics when basic auth is enabled.

+1 to the change, but we need to update the documentation to use the new rules and also explain that the default solr user will not be able to add/update/delete docs.

Also an addition in the changelog of the Solr Operator helm chart would be nice! You can follow the templates of the other entries. Possible change kind values are found here, fixed or security probably work best. Also if you think it's a serious security concern being addressed, you could always change artifacthub.io/containsSecurityUpdates to true.

Also an addition in the changelog of the Solr Operator helm chart would be nice! You can follow the templates of the other entries. Possible change kind values are found here, fixed or security probably work best. Also if you think it's a serious security concern being addressed, you could always change artifacthub.io/containsSecurityUpdates to true.

I don't think it's a serious security issue (willing to be convinced though) ... mainly the solr user ended up getting more access than I intended but users still have to give out the solr user's credentials, which presumes they've reviewed that account's access privileges before handing it out willy-nilly ;-)


Downloading large files through SFTP

Is there a way to download large files through SFTP using relative paths or other method that does not store the whole file data in the memory?
Since I am downloading the files through SFTP I use
- (NSData *)contentsAtPath:(NSString *)path progress:(BOOL (^)(NSUInteger got, NSUInteger totalBytes))progress from NMSFTP
The issue is that the files are around 450 MB and therefore a lot of memory is used to store the data while reading the file.
I have checked
- (BOOL)downloadFile:(NSString *)remotePath to:(NSString *)localPath progress:(BOOL (^)(NSUInteger, NSUInteger))progress from NMSSHChannel,
but it hangs on
LIBSSH2_CHANNEL *channel = libssh2_scp_recv(self.session.rawSession, [remotePath UTF8String], &fileinfo); and never proceeds.

@Frugghi, do you have any suggestions?

I've added a new version of contentsAtPath: that writes the data to a stream, you can use it to download the file directly to disk!


Update LOCALIZATION_CONTRIBUTORS

I have joined gitlocalise
Changes

Implementation details

How to read this PR

Screenshots

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


reomve --preview-feature tag

since 0.8.0 no need more --preview-featuere tag for push db

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[UNDERTOW-1852] Add OSGi manifest headers to 3 Undertow modules

There's also "karaf" Maven module, enabled only with osgi Maven
profile. This is not to provide any additional artifact, but only to
verify the Manifest headers.
I also removed io.undertow.servlet.core.ServletExtensionHolder which was
supposed to provide a static way to add ServletExtensions in OSGi
environment. It's no longer needed and even in OSGi ServletExtensions
are now added normally to DeploymentInfo.

Hmm, some tests are failing, but work locally...

@grgrzybek  we do have failures that we are working on fixing. Those failures are not caused by your PR.


Gallery mixin with hidden elements

Hello!
Here's a codepen for review: http://codepen.io/nickbullets/pen/zxyKwy
Essentially, the problem is even though the .column_full has display: none, the layout breaks. When the .column_full is commented out, the layout works as expected -- to me, anyway.
Presumably, this is because of the gallery mixin's usage of nth-child / type-of but I'm lost as to how to avoid this and also make use of the gallery mixin. I'm not familiar at all with the isolate technique, so maybe this is a side effect as well?

Side note: as you can see I need to implement (append) the aforementioned full-width column via JS, so if you're feeling like a superhero, I'm all eyes for any suggestions there Susy-wise and would GREATLY appreciate it. Currently, I'm taking the span() approach with clearing both, but the nth-child count is off so the 5th regular-sized column starts too far to the right.

Thank you for your time!
Nik

Yeah, this is just a limitation of CSS. You won't be able to do it with gallery or anything else counting on :nth-child. The best solution is if you can use a simple span on all the elements, with gutters split or inside so that they flow to the next line without needing any modifications on the last element.


Albert zorro ui

Replaces multiple ui-libraries with ng-zorro-antd.
Still requires angular6-json-schema-form + @angular/material.
However, this may soon be solved by
Bihaox json generator
*this is going to break most tests

bootstrap (Stale)
ngx-bootstrap (Stale)
font-awesome (Stale)
@ng-bootstrap/ng-bootstrap

Material - 23 files / 4 deps

@angular/material
ngx-tour-core
@angular/cdk

Misc/Uknown affiliation - 17 files / 6 deps

ngx-tour-ng-bootstrap
ngx-popper (Stale)
popper.js (Stale)
ngx-json-viewer
@angular/flex-layout
jointjs

Unfortunately not fixed fast enough. Too far behind master to rebase


CLI always discards the stack on compilation errors

As ts-framework-cli wraps module resolution in a try/catch with a throw new BaseError, the error stack is discarded in favor of a useless stack that always points to the CLI internals on compilation errors. Errors should always be rethrown, throw new Error inside a catch is an anti-pattern.
https://github.com/nxtep-io/ts-framework-cli/blob/731ef164a2661e717f2d328ca91853648065b63d/lib/BaseCommand.ts#L109-L112
Error example:
error: Could not load Server instance: "⨯ Unable to compile TypeScript:
api/services/CDTProviderService.ts(43,24): error TS2345: Argument of type 'CDTPhoneCreditFeature' is not assignable to parameter of type 'BaseCustodyFeature'.
  Property 'type' is missing in type 'CDTPhoneCreditFeature' but required in type 'BaseCustodyFeature'.
" (stackId: 8f953bb1-a3db-4ce7-b9f4-9c707cec500c) {
  "stack": "BaseError: Could not load Server instance: \"⨯ Unable to compile TypeScript:\napi/services/CDTProviderService.ts(43,24): error TS2345: Argument of type 'CDTPhoneCreditFeature' is not assignable to parameter of type 'BaseCustodyFeature'.\n  Property 'type' is missing in type 'CDTPhoneCreditFeature' but required in type 'BaseCustodyFeature'.\n\" (stackId: 8f953bb1-a3db-4ce7-b9f4-9c707cec500c)\n    at ListenCommand.<anonymous> (/home/rangel/Workspace/nxtep/bitcapital/bitcapital-cards/node_modules/ts-framework-cli/lib/BaseCommand.ts:111:13)\n    at Generator.next (<anonymous>)\n    at fulfilled (/home/rangel/Workspace/nxtep/bitcapital/bitcapital-cards/node_modules/ts-framework-cli/dist/BaseCommand.js:4:58)\n    at process._tickCallback (internal/process/next_tick.js:68:7)\n    at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)\n    at startup (internal/bootstrap/node.js:266:19)\n    at bootstrapNodeJSCore (internal/bootstrap/node.js:596:3)",
  "stackId": "8f953bb1-a3db-4ce7-b9f4-9c707cec500c",
  "originalMessage": "Could not load Server instance: \"⨯ Unable to compile TypeScript:\napi/services/CDTProviderService.ts(43,24): error TS2345: Argument of type 'CDTPhoneCreditFeature' is not assignable to parameter of type 'BaseCustodyFeature'.\n  Property 'type' is missing in type 'CDTPhoneCreditFeature' but required in type 'BaseCustodyFeature'.\n\"",
  "name": "BaseError",
  "details": {}
}

This is not well implemented, BaseError has a way to inherit the other exception stack frames and still provide valuable features such as a unique stack ID and more meaningful toJSON pojo object.
This will probably require a patch fix.


crash when showing repository path tooltip in source control

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.1
OS Version: Ubuntu 24.04 and 20.04

Steps to Reproduce:

go to Source Control view
make sure multiple repositories are listed
hover over the repository name to get a tooltip with the repo path

Vscode crashes 1-2 seconds after the tooltip is shown. I have the same behavior on 2 different laptops. The issue still exists when I remove all workspace settings.

@deepak1556, are you aware of any issues related to native hover?

Not aware, @TimSlechten are you using snap installation of VS Code ? Does the crash repro with 1.90.2 release ?

If the crash persists with latest stable, can you share the crash dump following the steps at https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-a-crash-report

I'm not able to reproduce it with 1.90.2.

Seems like addressed with fix for https://github.com/microsoft/vscode/issues/212494, closing.


Code Notes

File: devtools-inspector-category

renderItem() > renderProperty() : Expected 2 arguments, but got 1.
updateTimeout : Type 'null' is not assignable to type 'number'.

TypeScript
declare type CustomEvent MESSAGE_TYPE
checkIfMutationIsRelevantReSelectEvent not used.
plus more
I already updated the project to TypeScript, and many errors are popping up

There is some work in typing + docs i'm working on.
A full transition to TS will never happen though. It's purely a JS+ JSDoc project

file: element-parsers > determineAttributes()
    let attribute = { **name**: attrName };
    attribute.**type** = determineAttributeType(attribute, element);

The attribute name & type should be the same.

I think that is it for errors.
But 2 patterns also show errors

CustomEvents have an object for first argument, I guess this works, but doesn't help declaring custom events.
const x = function(). This might be bad practice.


MINOR: Adds entity-specific flags to ConfigCommand per KIP-543.

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks, @bdbyrne.  Looks good.

LGTM


fix early onFinished

See https://github.com/vesoft-inc/nebula-storage/runs/2036566131?check_suite_focus=true.

fix mem leak
replace Optional with ErrorOr<ResultCode, string>, otherwise write interface can't report leader change

We need to unify kvstore and thrift ErrorCode later, it is really a disaster.
Please review carefully, or tell me if there are any better ideas.

I'm in favor of this change, generally good to me of current changes. maybe we can talk about a better solution later.


New custom alert: Spike rule with defined timeframes

Hi,
Looking at the rules that are created right now, I see that the spike rule will match when events from the "current" period are larger or smaller than the "previous" period.
The problem is that those time windows are together. If you set the timeframe to 1 hour, it will compare "from now to one hour" events with "from one hour to two hours" events.
But what I really want is to compare "from current to this hour" events with the same period of the last day/week, because events will be very different in adjacent hours of the same day.
So I tried to create a new custom rule in order, and here start the problems.
The only way I thought is to create a new rule that performs the same query with a custom timeframe get by configuration. I don't like this because I can't use the same procedure to search that the other rules use (all the searches are done outside of the rules, they only receive the data already processed) and there is a lot of complexity that can not guarantee that I don't miss something.
What would be the best way to create a custom alert like this?
Maybe it will be easier to change the Spike rule in order to get parameterized reference windows?
Any help would be appreciated.
Thanks in advance

So I understand that the rule will call ElasticSearch again to perform the second query.
Seeing the code to perform the ES queries and return the data to the rules you made some transformation on the hits. Can I reuse those methods to make my query or should do it without this methods?

I would very much encourage you to re-use those methods. There are some in util.py for creating an Elasticsearch client, as well as a couple of static ElastAlerter methods that would be helpful (get_query, process_hits, get_index).
The bad part is that some methods could be static methods but I just forgot to add that, so you'd need to either copy the code or modify it to be a static method (like get_terms_query)

Possible duplicate of #584

@JuananOc : Are you able to solve this?


docs: add Contributors on README

Codecov Report

Merging #23 (4bf583d) into main (e99af64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   85.62%   85.62%
=======================================
  Files           1        1
  Lines         153      153
  Branches       33       33
=======================================
  Hits          131      131
  Misses         22       22

Flag
Coverage Δ

core
85.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@all-contributors please add @aiji42 for code and translation


<EMAIL_ADDRESS>throws ENOENT on alpine linux

Describe the bug
Using version<EMAIL_ADDRESS>generates the ENOENT error for the dev and build commands on alpine linux.
This does not happen with version ^3.0.0 on alpine linux, or version ^4.0.0 on other operating systems, or with @sveltejs/adapter-auto@latest on alpine linux.
Reproduction
Repository: https://git.sr.ht/~liliace/bugged-example
This is basically the skeleton project from running pnpm create svelte@latest, then pnpm add -D @sveltejs/adapter-cloudflare and pnpm remove -D @sveltejs/adapter-auto, then replacing the import in svelte.config.js.
I've provided a Containerfile for the alpine linux environment. You can run with docker (docker build -t bugged-example .) or podman (podman build -t bugged-example .) and it will output the error log I pasted below. If you change the first line from node:alpine to node:slim, the build will be successful.
If you keep the Containerfile as is (with node:alpine), and change the version of @sveltejs/adapter-cloudflare to ^3.0.0, or use @sveltejs/adapter-auto, the build will also be successful.
Logs
><EMAIL_ADDRESS>build
> vite build

vite v5.2.6 building SSR bundle for production...
transforming...
✓ 79 modules transformed.
rendering chunks...
vite v5.2.6 building for production...
transforming...
✓ 61 modules transformed.
rendering chunks...
computing gzip size...
.svelte-kit/output/client/_app/version.json                             0.03 kB │ gzip:  0.05 kB
.svelte-kit/output/client/.vite/manifest.json                           2.25 kB │ gzip:  0.44 kB
.svelte-kit/output/client/_app/immutable/entry/start.CS4bZmir.js        0.07 kB │ gzip:  0.08 kB
.svelte-kit/output/client/_app/immutable/nodes/0.sbPD3avW.js            0.60 kB │ gzip:  0.38 kB
.svelte-kit/output/client/_app/immutable/nodes/2.k97gLCY_.js            0.69 kB │ gzip:  0.45 kB
.svelte-kit/output/client/_app/immutable/nodes/1.TdFCRiDp.js            1.02 kB │ gzip:  0.59 kB
.svelte-kit/output/client/_app/immutable/chunks/scheduler.BvLojk_z.js   2.16 kB │ gzip:  1.02 kB
.svelte-kit/output/client/_app/immutable/chunks/index.fi1e1Nz5.js       5.44 kB │ gzip:  2.31 kB
.svelte-kit/output/client/_app/immutable/entry/app.CAu41V3K.js          6.12 kB │ gzip:  2.47 kB
.svelte-kit/output/client/_app/immutable/chunks/entry.Cjzq2A8j.js      27.35 kB │ gzip: 10.79 kB
✓ built in 908ms

/app/node_modules/wrangler/wrangler-dist/cli.js:29573
            throw a;
            ^
Error: spawn /app/node_modules/@cloudflare/workerd-linux-64/bin/workerd ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn /app/node_modules/@cloudflare/workerd-linux-64/bin/workerd',
  path: '/app/node_modules/@cloudflare/workerd-linux-64/bin/workerd',
  spawnargs: [
    'serve',
    '--binary',
    '--experimental',
    '--socket-addr=entry=<IP_ADDRESS>:0',
    '--external-addr=loopback=<IP_ADDRESS>:44133',
    '--control-fd=3',
    '-'
  ]
}

Node.js v21.7.1
Error: building at STEP "RUN npm run build": while running runtime: exit status 7

System Info
System:
  OS: Linux 6.8 Alpine Linux
  CPU: (12) x64 13th Gen Intel(R) Core(TM) i7-1355U
  Memory: 11.00 GB / 15.31 GB
  Container: Yes
  Shell: 5.2.26 - /bin/bash
Binaries:
  Node: 21.7.1 - /usr/bin/node
  npm: 10.5.0 - /usr/bin/npm
  pnpm: 8.15.1 - /usr/bin/pnpm

Severity
blocking an upgrade
Additional Information
No response

https://github.com/cloudflare/workerd/issues/286 seems relevant. I don't know whether there's a nice way to make the additions in #11732 degrade gracefully when the native binary fails.


Dropdown in responsive table in panel -> Android browser problem with y-overflow

If i put a dropdown inside a table cell, and i put the table in a div.table-responsive, and I put everything inside a panel, the dropdown of the last row is invisible due to y-overflow: hidden; at low resolutions
If I manually set the y-overflow to scroll, the problem is resolved in Chrome (desktop), but my Android browser, even though showing a vertical scroll bar upon opening the dropdown, doesn't want to scroll down to show the options.

No solution yet?


TreeBuilder Type Checking part 2A

Summary

Adds a system to convert the static types from #157 into a dynamic representation, using constexpr and all computed at compile time.
Tests that the dynamic representation is accurate for the various static types.
Adds a TypeCheckingWalker which allows you to extract from a data segment with type knowledge. For example, the number of items in a list (N) must be succeeded by N*Elements of the list.
Tests TypeCheckingWalker against each existing dynamic type.

It does not stitch these parts together for use in TreeBuilder yet. That will be in the next PR and will finish off phase 2.
Relates to #95
Test plan

CI

Great tests, comments and code!
Just one question to help me understand a bit better: What purpose do the dynamic types serve?
Maybe I glossed over something, but it appeared to me that they are only generated from static types, in which case aren't they always static themselves?

Perhaps the wording is a little poor, but this is more of static vs dynamic dispatch than the types themselves. At JIT time all of the types are known and we could use static dispatch for TreeBuilder, but at runtime we must use dynamic dispatch in either OID/OITB. That is, we can keep the template parameters in the "static" types in the JIT but they must all be gone to run the "dynamic" types at runtime.
This answers the question about std::span with a dynamic extent even though it points at a static array too. The static array with its fixed (templated) size exists in the JIT code and the constructor that builds the span. But other than that, the type has no template parameters which means it can be traversed in a dynamic program.
Does this clear things up, and is there an obvious point where this is missing in the comments?


Exception, when trying to run the example from the README

Hi @roughike, thanks for writing this lib, I had a major issue though...
I got this exception, when trying to run the example from the README:
E/flutter (31936): [ERROR:topaz/lib/tonic/logging/dart_error.cc(16)] Unhandled exception:
E/flutter (31936): MissingPluginException(No implementation found for method loginWithReadPermissions on channel com.roughike/flutter_facebook_login)
E/flutter (31936): #0      MethodChannel.invokeMethod (package:flutter/src/services/platform_channel.dart:278:7)
E/flutter (31936): <asynchronous suspension>
E/flutter (31936): #1      FacebookLogin.logInWithReadPermissions (package:flutter_facebook_login/flutter_facebook_login.dart:101:23)
E/flutter (31936): <asynchronous suspension>
E/flutter (31936): #2      LoginSelectPageState.loginWithFacebook (package:project/login/login_select_page.dart:61:41)

Flutter doctor:
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.5.1, on Linux, locale en_GB.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] Android Studio (version 3.1)
[✓] Connected devices (1 available)

• No issues found!
flutter doctor  13.61s user 1.22s system 185% cpu 8.014 total

it turns out a full rebuild was needed, problem solved, thanks!


Use the master's default ipv4 address, not ansible_host

Inventory files that have FQDNs for the hosts of a cluster instead of
raw IPs would fail.
    fatal: [osctrl-bgcloudv3-1.ece.comcast.net]: FAILED! => {"changed": true, "cmd": "kubeadm init --service-cidr <IP_ADDRESS>/12 --kubernetes-version v1.13.0 --pod-network-cidr <IP_ADDRESS>/16 --token <token> --apiserver-advertise-address osctrl-bgcloudv3-1.ece.comcast.net  ", "delta": "0:00:00.025122", "end": "2019-03-06 15:35:58.549072", "msg": "non-zero return code", "rc": 1, "start": "2019-03-06 15:35:58.523950", "stderr": "couldn't use \"osctrl-bgcloudv3-1.ece.comcast.net\" as \"apiserver-advertise-address\", must be ipv4 or ipv6 address", "stderr_lines": ["couldn't use \"osctrl-bgcloudv3-1.ece.comcast.net\" as \"apiserver-advertise-address\", must be ipv4 or ipv6 address"], "stdout": "", "stdout_lines": []}

LGTM


How can I write a custom SQL query using knex with objection js?

select * from products as outerQuery join (select products_id, providers_id, price from products_providers GROUP BY products_id, price ORDER BY price DESC) as innerQuery on outerQuery.id = innerQuery.products_id where category_id = 1 GROUP BY products_id

await Product.query()
  .alias('outerQuery')
  .join(
    ProductsProviders.query()
      .select(['products_id', 'providers_id', 'price'])
      .groupBy(['products_id', 'price'])
      .orderBy('price', 'desc')
      .as('innerQuery'),
    'outerQuery.id',
    'innerQuery.åroducts_id'
  )
  .where('category_id', 1)
  .groupBy('products_id')

Hello, Thanks for your reply.
the generated query from your code is:
select outerQuery.* from productsasouterQueryinner join (selectproducts_id, providers_id, pricefromproducts_providersgroup byproducts_id, priceorde r bypricedesc) asinnerQueryonouterQuery.id=innerQuery.products_idwherecategory_id= 1 group byproducts_id`
but it only returns the product info without the price and the provider info. although when I run this query in SQL I get the right result.
sql query:
select * from products as outerQuery inner join (select products_id, providers_id, price from products_providers group by products_id, price order by price desc) as innerQuery on outerQuery.id = innerQuery.products_id where category_id = 1 group by products_id
any idea why that happens?

Oh my god. You ARE allowed to use your brains. Use select to select whatever you want!


Update internal sdk jar

Verified that @seema-at-box has signed the CLA. Thanks for the pull request!


fix(addon-doc): downgrade dependency ngx-highlightjs (v6 => v5)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[X] Build or CI related changes
[ ] Tests related changes
[ ] Documentation content changes

What is the current behavior?
@taiga-ui/addon-doc uses<EMAIL_ADDRESS><EMAIL_ADDRESS>is:

compatible with Angular 16 (it is published using Ivy engine) ✅
not compatible with Angular 12 (peerDeps require Angular >= 13). ❌
It causes the following error:

/home/runner/work/maskito/maskito/node_modules/ngx-highlightjs/fesm2020/ngx-highlightjs.mjs:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import * as i0 from '@angular/core';
                                                                                ^^^^^^

    SyntaxError: Cannot use import statement outside a module

What is the new behavior?
@taiga-ui/addon-doc uses<EMAIL_ADDRESS><EMAIL_ADDRESS>is:

compatible with Angular 16 (it is published using Ivy engine) ✅
compatible with Angular 12 (peerDeps require Angular >= 12). ✅

See also

https://github.com/taiga-family/taiga-ui/issues/4606
https://github.com/taiga-family/taiga-ui/pull/4608
https://github.com/taiga-family/maskito/actions/runs/5853471264/job/15867544365?pr=416

Use npm overrides for Angular 12:
"overrides": {
    "ngx-highlightjs": "5.0.0"
},


Ch2, line 48, 62, & 77 :  don't seem to match book calc

Ch2, line62:
Issue#1:
If, line 48, you set self.actionCount to array of 10 zeros,
Then if, line 62, - np.asarray(self.actionCount) + 1 -  then adds +1 to the count of EVERY actionCount, not the SPECIFIC actionCount; this seems to be an error because...; note: asarray doesn't copy, it's ref'd
Then, line 77, self.actionCount[action] += 1;
Issue #2:
Also, if, line 62, self.qEst + \
then adds self.UCBParam * np.sqrt(np.log(self.time + 1) / (np.asarray(self.actionCount) + 1)) to EVERY ActionEstimate(qEst), not just the SPECIFIC ActionEstimate
The book does both these calc for each SPECIFIC action, not EVERY action; see page 37, Upper-Confidence-Bound Action Selection

On Issue#1: https://docs.scipy.org/doc/numpy/reference/generated/numpy.asarray.html says 'No copy is performed if the input is already an ndarray''. I tested this on https://www.pythonanywhere.com/try-ipython/, and it actually is changing the array; therefore line 77 is actually a duplicate calc.

But self.actionCount is a list (line 40) not an ndarray

My bad, python newbie mistake (sorry)

No problem. And even it's ndarray, it won't be changed. Because np.asarray(self.actionCount) + 1 simply returns a new ndarray without changing the original one.
Try
a = np.zeros(4)
b = np.asarray(a) + 1

and see the value of a and b

On Issue#2:
then line 90,
else:
# update estimation with constant step size
self.qEst[action] += 0.1 * (reward - self.qEst[action])
is duplicate because you already 'repaired every action estimation per formula' in line 62?

No. This is normal update for action estimation. Action estimation needs to be repaired whenever we  want to choose an action. But that repair isn't and shouldn't be lasting, it should be forgotten after having chosen an action.


Documentation clarification of "project" and "worker" concepts

In the docs, a worker and project are added in distinct array positions:
POST https://time.pondersource.com/v1/worked-hours
Authorization: Basic timeld ***
/* timestamp, worker, project (plus amount and description, not in docs) */
["2022-08-15T10:36:26.127Z","worker","test/ts1",0,"testing"]

In the response, the 'worker' is assigned to the API account holder, and the project concatenates the given worker and project:
[
{
"worker": "timeld",
"project": "worker:test\/ts1",
"timestamp_": "2022-08-15 10:36:26",
"amount": "0",
"description": "testing"
}
]

In the update-entry command, the 'project' assumes this concatenation, so a no-op update for the above data looks like this:
POST https://time.pondersource.com/v1/update-entry
Authorization: Basic timeld ***
/* timestamp, project, amount, description, id (currently not knowable :) */
["2022-08-15T10:36:26.127Z","worker:test\/ts1",0,"testing",123]

Please can you confirm this is correct?

@gsvarovsky Yes I will update this information, send you again and check it

Ah, those docs are wrong then! This is how you use the worked-hours command:
0. "worked-hours"

date, e.g. "20 September 2021"
client, e.g. "stichting" or "nlnet-timesh"
project, e.g. "Peppol for the Masses" or "Federated Timesheets"
number of hours worked on that date, e.g. 4
(optional) description of work performed during those hours

@ishifoev can you find the misleading docs and fix them?

The reason to have client and project separately is that PreJournal needs to determine the value flows based on that. It creates a movement of type "worked" from the worker to the project account within the client. The "account:subaccount" syntax is taken from Plain Text Accounting, see e.g. https://hledger.org/1.26/hledger.html#basic

@gsvarovsky apart from the misleading docs we unfortunately gave you, thanks for flagging this as something confusing, it indeed is, even when using the correct docs!
The worked-hours command has client and project separately and the update-entry command (and I think the print-timesheet-* commands too) have "client:project" as one of the required parameters, and then also call that "project".
So we should have three names:

one for strings like "stichting" ("client"?)
one for strings like "Peppol for the Masses" ("project"?)
one for strings like "stichting:Peppol for the Masses" (also "project"?)


Issue installing requirements

└─$ sudo pip install -r requeriments.txt                                                                                1 ⨯
Collecting validate_email
Downloading validate_email-1.3.tar.gz (4.7 kB)
Collecting pyDNS
Downloading pydns-2.3.6.tar.gz (28 kB)
ERROR: Command errored out with exit status 1:
command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-efytzi12/pyDNS/setup.py'"'"'; file='"'"'/tmp/pip-install-efytzi12/pyDNS/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-7j8z6e4m
cwd: /tmp/pip-install-efytzi12/pyDNS/
Complete output (7 lines):
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-efytzi12/pyDNS/setup.py", line 12, in
import DNS
File "/tmp/pip-install-efytzi12/pyDNS/DNS/init.py", line 14, in
import Type,Opcode,Status,Class
ModuleNotFoundError: No module named 'Type'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Same problem as me

same here

For the requirements, try to change pyDNS in requirements.txt by py3DNS, pyDNS doesn't work on Python3

Installation problem

How to install the software sir?


ampbyexample.com home page as a template

Is the ampbyexample.com home page available as a template?  I think it is not so I would suggest it as a candidate.
It is the one page everyone will see if they visit ampbyexample.com, so I think there's a decent chance of a user deciding that they want something like that as their starting point.

ampbyexample uses a different color combo of ampstart.com theme , so you could basically think of ampstart.com as the template :), we did add a bunch of custom stuff like previews that were website specific.
@spacedino @ericlindley-g - what do you think about this request?

This is a great idea, if we do say so ourselves :)   (We've been wanting to package the home page as a template—just haven't gotten around to it yet with other priorities like the configurator. Until then, as @camelburrito mentions, you could just download the page and use it as a starting place I suppose)
I think the next step is essentially to whitelabel the content so it's flexible enough to work as a generic 3-value-prop homepage. Passing to @spacedino for design (though not necessarily for this sprint—will have to see where this fits in with priorities)


Just a test

Current coverage is 31.73%

Merging #2 into master will not affect coverage as of 5bf16f1

@@            master      #2   diff @@
======================================
  Files           11      11
  Stmts          208     208
  Branches         0       0
  Methods         84      84
======================================
  Hit             66      66
  Partial          0       0
  Missed         142     142

Review entire Coverage Diff as of 5bf16f1

Powered by Codecov. Updated on successful CI builds.


Controller support?

Hi I am using this plugin to build my prototype and it'd be cool if you could give me some advice on how to implement controller support. any help would be greatly appreciated!

I did not design this plugin with controllers in mind. I think I'd have to write a completely new renderer and make extensive changes to the API in order to get that to work. I'm afraid I simply don't have the time :(


feature request: build docs for dependencies only

Idea: add a new flag to cargo-doc doing the opposite of --no-deps (e.g. --deps-only).
It would be useful to be able to do
cargo doc --deps-only --open

to generate the documentation for the dependencies of the crate, even when the crate itself doesn't compile.

I like that idea because sometimes my code does not compile because of errors to fix those I need a documentation for some external crate.

I'll take it.

This is a duplicate of #2644 so maybe it can be closed ?

This issue is specifically for documentation which has special dependency handling flags already like --no-deps. #2644 is broader build feature that is likely different enough in the needs there that we shouldn't combine the two.
For me, the question is how much is this

Wanting to have documentation targeted at me without taking the time to build local dependencies
Wanting have easy access to browsing what documentation did build when there is a failure (--keep-going can help for other workspace members)

if its the latter, I wonder if there is some level of still reporting or --opening we should do on error.


How to set the epoch?

Hello,
I am using fixmatch.py to build a SSL model for a custom dataset that I added. Yet, default value for the epoch is 1024. How to tweak the epoch. I could not find as an argument in the fixmatch.py. I would be very appreciated if you could help me.
Have a nice day!

The number of training steps is set here
https://github.com/google-research/fixmatch/blob/d4985a158065947dba803e626ee9a6721709c570/fixmatch.py#L176


program crashing

Description
when i open the desktop folder the program crash for no reason.
Steps To Reproduce

Desktop folder

Expected behavior
i don't have any idea why it's crashing
Files Version
last one
Windows Version
windows 10
Relevant Assets/Logs

@OMAR-3OOV what version of Files are you using?