Update MetaMask Entry

Previous entry seemed to be a hastily cloned Mathwallet entry.
Quite a few of our more recent features were missed:

Transaction scanning
Our snaps extensibility system (which enables custom chains, name resolvers, and account backup systems including MPC)

Some of our very long term features were mis-represented:

Mobile's in-app browser and provider injection.

We may have to come back and update some ENS entries again.

I can't see why Vercel failed. Opening for review since I got a sign-off from another member of my team.


Parameters not tied together in MCMC

Although the parameters can be tied together in the optimization run (using scipy), they are not tied together in the MCMC run. To do this, we will simply need to modify the log probability function to tie them together.

To do this, we would need to tie together the parameters in log_likelihood_bayes when we calculate each line's contribution.

I don't think this is really necessary right now. I am closing it until further notice.


SMTP Mail only works with Gmail Server

Issue Summary
I have my own Mail Server but no matter what I try it says fail to send magic link in first try and goes to time-outing me afterwards while with Gmail SMTP config it works fine. This is my SMTP config in config.production.json:
  "mail": {
    "transport": "SMTP",
    "from": "EMAILUSER",
    "options": {
      "host": "MAILSERVER",
      "port": 465,
      "secure": true,
      "auth": {
        "user": "EMAILUSER",
        "pass": "EMAILPASS"
      }
    }
  },

I can confirm that with Mail Client, SMTP with SSL/TLS security and the same port I am able to send emails successfully.
Steps to Reproduce

Change SMTP config to something else
Restart Docker container
Wait to reload
Try to register a new member

Ghost Version
5.84.1
Node.js Version
18.20.2
How did you install Ghost?
Bitnami Docker Image
Database type
Other
Browser & OS version
Safari/Firefox - macOS 14.5
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

@amirsaam Can you confirm that your Docker container is able to access the SMTP server? Could you confirm that the timeout is in the Ghost logs, or provide a console/HTTP error message? That would help in troubleshooting.

@9larsons
Hi there,
Any instructions on how to do asked things?
Unfortunately I am not that familiar with these.

also console error:
{
    "errors": [
        {
            "message": "Failed to send email. Reason: Hostname/IP does not match certificate's altnames: Host: CNAMEtoMAILSERVER. is not in the cert's altnames: DNS:MAILSERVER",
            "context": null,
            "type": "EmailError",
            "details": null,
            "property": null,
            "help": "Please see https://ghost.org/docs/config/#mail for instructions on configuring email.",
            "code": "ESOCKET",
            "id": "00f1dc50-278c-11ef-b0f9-59906d673b22",
            "ghostErrorCode": null
        }
    ]
}

@amirsaam
Thanks for sending through the errors!
It looks like the certificate that Ghost is seeing doesn't contain the domain of your mail server. Is it possible that you're using some other hostname for the mail server than the one which you made a certificate for, e.g. a hostname for the docker container instead of the FQDN?
You should be able to configure the hostname which is tested using the tls.servername property (documentation) like this:
  "mail": {
    "transport": "SMTP",
    "from": "EMAILUSER",
    "options": {
      "host": "MAILSERVER",
      "port": 465,
      "secure": true,
      "auth": {
        "user": "EMAILUSER",
        "pass": "EMAILPASS"
      },
      "tls": {
        "servername": "<hostname of your mail server here>"
      }
    }
  },

Which will allow you to continue to connect with the same host, but verify the SSL certificate using an alternative hostname. Hope this helps!

I'll try out this suggestion and then report if it does fix it because for now I need to rebuild my Mailserver.
Thanks!

@sam-lord I can confirm that the solution works, cheers!


refactor: [M3-8183] - Clean up loading components

Description 📝
We have a lot of loading components that are all basically just variations of CircleProgress. This PR cleans up those components.
I also moved the overage pricing tooltip text position in the Object Storage Create Bucket drawer to the top so that the tooltip doesn't block the CTA buttons
Preview 📷

Before
After

How to test 🧪
Verification steps
(How to verify changes)

Check the affected loading spinners throughout the app

As an Author I have considered 🤔
Check all that apply

[x] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[x] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Can we move the disableShrink  option into the theme?


Is somebody maintaining this repo?

Hi all! I see that there are a lot of useful PRs that weren't merged In this repo. I'm using this repo in my project and I would prefer to use it instead of forks (it is already in pip).
Kind regards

I would double that question and ask how we could help.
having 11 contributers  but no document about contribution seems strange.
3500 stars show this is a well liked project.
What is the limiting factor? Time, money or interest in the topic?
would love to read from you.

Hi Zuzanna, yes and no is the best short answer I suppose. I'm still here, just that work is busy and I've had to step back quite a bit.
Unfortunately the process of incorporating new features is much, much more involved than simply merging PRs. Doing so would lead rapidly to instability in the library and general chaos in the code base. In general, the PRs we receive are not production-worthy, lacking both documentation and tests and also often inconsistent with the architecture of the existing code. This is why so few are merged. In general it would be faster to re-develop the "feature" myself than get the PR to a suitable state. Extending a stable code base is hard, and most folks either don't have the required skills or experience or aren't willing to do the work.
If you have a long-term commitment to the project and would like to become part of the maintenance team, I'd be very pleased to speak with you about how you might contribute.

Dear @scanny,
thank you for your answer. I'm open to collaboration. Hope I can be useful.

Hi @scanny
Thanks for all the hard work. You implied that you look through the PRs (I hope I read that correctly) and they are just not good enough. Could you close the ones you already looked through? Or comment on then what's missing? This would probably be very helpful and prevents the creators from pushing their PR multiple times.
Also this issue could be closed.

python-docx is getting some new love, turns out LLMs are hungry to ingest Word files so I'll be more active than usual here for a while :)


Scope limited to 4G & 5G

Any reasons the scope is limited to 4G and 5G ? As the NumberVerification API can be independent of the access network or the implementation of the service, the implementation of the phone number extraction from the core network is dependent on the network.

readme.md updated - closing issue


refactor: use go-github package for ListRunnerGroup API for GitHub Cloud

Ref https://github.com/actions-runner-controller/actions-runner-controller/pull/1324 https://github.com/google/go-github/issues/2328 https://github.com/google/go-github/pull/2329
At the moment we use custom code for the new ListRunnerGroup API. At some point the go-github package will have support for this API (probably within the next month or two) at which point we should remove our custom implementation and use the package's implementations.
Note : We need to keep the old implementation around for GHES until the new parameter available in a GHES release
EDIT https://github.com/google/go-github/releases/tag/v45.0.0 has been released which has support for the new API

Closing this one as done!


Add Push documentation

Putting this up for review now but I still need to take a few screen shots for the docs. Need to be on a network that actually allows you to use phonegap serve.

Really great content @macdonst!


feat: change names of 1 and 2 folders

The first step of DE-223 is to rename the folders to reflect our updated desired names:
1_cta_full_refresh or 1_cta_incremental
There should be no 1_cta_base
2_partner_matviews
The only reason 2_partner_views should exist in a project is if `2_partner_matviews also exists.
If these things look true, then I'd love to get this merged into main before digging into each of the syncs to tidy up their dbt.

This PR is too confusing with merges, so I opened another PR doing the same thing on branch kane/DE-223_rename_folders


Upgrade SvelteKit to 1.0.0 stable release

Description
This PR implements the following features:

[x] Upgrade @sveltejs/kit to 1.0.1
[x] Upgrade @sveltejs/adapter-static to 1.0.0
[x] Update npm scripts to use vite and add vite config
[x] Update head and body template strings in app.html
[x] Set adapter static fallback route
[x] Update rendering configs
[x] Move global CSS file to src directory
[x] Extend SvelteKit tsconfig and update path aliases
[x] Add trailingSlashAlways config (works better with IPFS HTTP Gateway if more pages are added)
[x] Add rel="noreferrer" to outbound links

Link to issue
Closes #56
Type of change

[x] Refactor (non-breaking change that updates existing functionality)

Test plan (required)
The app should continue to work in local development, built, and published to Fission static site hosting.

One comment, but looks good otherwise! I've tested locally, but it may be good to test the prod build against Safari too to ensure we don't run into the same issue from the other day

Tested on Safari. No issues, merging this in! 🚀


Add nimbus checkpoint sync

Nimbus requires a separate container to checkpoint sync. This PR adds the functionality to do so.

no clue, can you have a look?


SAMZA-1482: Restart or fail Samza jobs in YARN when detecting changes…

… in input topic partitions
Some high-lights of the changes:

always instantiating StreamPartitionCountMonitor on all input system streams now
-- it is debatable whether we want to include systems that do not implement the optimized ExtendedSystemAdmin interface. We may need to configure a long partition monitor interval for this case and the case where there are tons of input topics. (Pending perf test)
moved the instantiation of StreamPartitionCountMonitor out of JobModelManager and allow ClusterBasedJobCoordinator associate a callback method directly to the monitor
allow callbacks to set different application status code before throwing exception to shutdown the job

@xinyuiscool @vjagadish @prateekm @jmakes could you help to review this? Thanks!


add document for service and role

I add documentation for service and role.

service (data_source and resource)
service_metadata (data_source and resource)
role (data_source and resource)
role_metadata (data_source and resource)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.884%

Totals

Change from base Build 977657354:
0.0%

Covered Lines:
2301

Relevant Lines:
2375

💛  - Coveralls

Thanks for responding to my comment 🙏


Revert "build: enable bazel node modules symlinking (#17675)"

This reverts commit 022acf84f9fa303c21b7c01b9c56c46d6b08b577.
Reverting this fixed the npm package build being broken.

Joey is currently testing this in a clean repo to confirm it fixes the problem


HAWQ-1594. Memory leak in standby master (gpsyncagent process)

@linwen @wengyanqing @radarwave help to review, thanks.

LGTM

+1


G303 (and probably others) DPI is not bounds-checked, can confuse ratbag-command

Somehow, ratbag-command happily pushed 13000dpi onto my mouse, and then wasn't able to change it back until I switched to a different profile and set it by reference (i.e. profile 0 resolution 1 dpi set 800). Then I was able to change it directly again.

any chance you can try and look for the bug (and fix it :). We're all a bit strapped for time atm

To give some hints to solve the bug:

ratbag-command is not aware of the min/max capabilities (by choice, currently), so the driver should be the one rejecting the erroneous value
I think the driver is driver-hidpp20.c in your case which calls hidpp20.c in a lot of various places
so I think in driver-hidpp20.c there should be a check on the incoming dpi to be sure we do not try to send something wrong in the mouse

Actually, after second thoughts, I think you would need a little bit more insights of the mice to fix that. The feature 0x8100 doesn't export the min/max DPI, so I think we would need to either rely on yet unimplemented functions of 0x8100 if any, or maybe in the adjustable_dpi feature (0x2201)...


[Bug]: Method Hugomyb\FilamentMediaAction\Tables\Actions\MediaAction::modal does not exist.

What happened?
hmmm, from my last issue #6
i fixed just give comment your code like this
protected function setUp(): void
{
    parent::setUp();

    // $this->modal();

    $this->modalSubmitAction(false);

    $this->modalCancelAction(false);

    $this->modalContent(function () {
        return $this->getContentView();
    });
}

and your package is already running in my app
why is that?
How to reproduce the bug
y
Package Version
latest
PHP Version
8.2.12
Laravel Version
10
Which operating systems does with happen with?
Windows
Notes
No response

You don't need to comment on this line, just repeat the code I gave you in the last issue and it'll work fine.

hmm, but if i uncomment $this->modal error still occurs
Is there any other configuration to be done? Other than the  composer require hugomyb/filament-media-action ?

Show me your code again please

`<?php
namespace App\Filament\Clusters\Audios\Resources;
use App\Filament\Clusters\Audios;
use App\Filament\Clusters\Audios\Resources\AudioResource\Pages;
use App\Filament\Clusters\Audios\Resources\AudioResource\RelationManagers;
use App\Models\Audio\Audio;
use Filament\Forms;
use Filament\Forms\Form;
use Filament\Pages\SubNavigationPosition;
use Filament\Resources\Resource;
use Filament\Tables;
use Filament\Tables\Table;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\SoftDeletingScope;
class AudioResource extends Resource
{
protected static ?string $model = Audio::class;
protected static ?string $navigationIcon = 'heroicon-o-list-bullet';

protected static ?string $cluster = Audios::class;
protected static SubNavigationPosition $subNavigationPosition = SubNavigationPosition::End;
public static function form(Form $form): Form
{
    return $form
        ->schema([
            Forms\Components\TextInput::make('name')->required()->maxLength('150'),
            Forms\Components\Select::make('category_id')->relationship('category', 'name')->required(),
            Forms\Components\TextInput::make('link_audio')->url()
                ->required()
        ]);
}

public static function table(Table $table): Table
{
    return $table
        ->columns([
            Tables\Columns\TextColumn::make('name')->sortable()->searchable(),
            Tables\Columns\TextColumn::make('category.name')->sortable()->searchable(),
            Tables\Columns\IconColumn::make('link_audio')->label('Sound')
                ->boolean()
                ->trueIcon('heroicon-o-speaker-wave')
                ->action(
                    \Hugomyb\FilamentMediaAction\Tables\Actions\MediaAction::make('link_audio')
                        ->iconButton()
                        ->media(fn($record) => $record->link_audio),
                ),

        ])
        ->filters([
            Tables\Filters\SelectFilter::make('category')->relationship('category', 'name'),
        ])
        ->actions([
            Tables\Actions\EditAction::make(),
            Tables\Actions\DeleteAction::make(),
        ])
        ->bulkActions([
            Tables\Actions\BulkActionGroup::make([
                Tables\Actions\DeleteBulkAction::make(),
            ]),
        ]);
}

public static function getRelations(): array
{
    return [
        //
    ];
}

public static function getPages(): array
{
    return [
        'index' => Pages\ListAudio::route('/'),
        'create' => Pages\CreateAudio::route('/create'),
        'edit' => Pages\EditAudio::route('/{record}/edit'),
    ];
}

}
`
this my code
its work when i comment $this->modal()

Your code works perfectly on my side.
Which package version are you using ? latest ?

yaa, i use version latest
this my composer
  "require": {         "php": "^8.1",         "filament/filament": "3.2",         "guzzlehttp/guzzle": "^7.2",         "hugomyb/filament-media-action": "^3.1",         "laravel/framework": "^10.0",         "laravel/sanctum": "^3.2",         "laravel/tinker": "^2.8"     },     "require-dev": {         "fakerphp/faker": "^1.9.1",         "laravel/pint": "^1.0",         "laravel/sail": "^1.18",         "mockery/mockery": "^1.4.4",         "nunomaduro/collision": "^7.0",         "phpunit/phpunit": "^10.0",         "spatie/laravel-ignition": "^2.0"     },

I've just tested installing the plugin from scratch and everything works fine on my end, maybe try uninstalling and reinstalling it.

hmmm, its very unique, i try install new laravel filament and install composer require hugomyb/filament-media-action
the result its same
is the problem with my computer?

I think so because I've just created a new Laravel project, installed Filament and my package, and everything is working properly... maybe your environment, idk..

Did you install with command composer require hugomyb/filament-media-action?

Yes, try php artisan optimize:clear, php artisan filament:clear, php artisan filament:assets

I have tried it, but still with the same error

However, the ->modal() method does exist in the CanOpenModal trait in Action, from which MediaAction extends:
public function modal(bool | Closure | null $condition = true): static
    {
        $this->hasModal = $condition;

        return $this;
    }

I can't imagine why it doesn't work for you...

However, the ->modal() method does exist in the CanOpenModal trait in Action, from which MediaAction extends:
public function modal(bool | Closure | null $condition = true): static
    {
        $this->hasModal = $condition;

        return $this;
    }

I can't imagine why it doesn't work for you...

is the code here? https://github.com/hugomyb/filament-media-action/blob/main/src/Concerns/HasMedia.php

It's not in my code, but in Filament's. My MediaAction class extends filament's Action class, which in turn extends the MountableAction class, which has a “CanOpenModal” trait.
https://github.com/filamentphp/filament/blob/3.x/packages/actions/src/Concerns/CanOpenModal.php#L15

I see the code on the DeleteAction button does not contain $this->modal
https://github.com/filamentphp/filament/blob/3.x/packages/tables/src/Actions/DeleteAction.php

I don't understand, I've just created a brand new project of my own, and it works. Here are the steps I took:

laravel new media
composer require filament/filament:"^3.2" -W
php artisan filament:install --panels
Create user
Create UserResource
Install composer require hugomyb/filament-media-action
In my UserResource :

return $table
            ->columns([
                Tables\Columns\IconColumn::make('url')
                    ->icon('heroicon-o-external-link')
                    ->action(MediaAction::make('url')
                        ->media('https://www.youtube.com/watch?v=PrmzB21ZPhw&pp=ygUOMTEzIG91YWlzIGdyb3M%3D'))
            ])

Result, it's working :

I don't understand, I've just created a brand new project of my own, and it works. Here are the steps I took:

laravel new media
composer require filament/filament:"^3.2" -W
php artisan filament:install --panels
Create user
Create UserResource
Install composer require hugomyb/filament-media-action
In my UserResource :

return $table
            ->columns([
                Tables\Columns\IconColumn::make('url')
                    ->icon('heroicon-o-external-link')
                    ->action(MediaAction::make('url')
                        ->media('https://www.youtube.com/watch?v=PrmzB21ZPhw&pp=ygUOMTEzIG91YWlzIGdyb3M%3D'))
            ])

Result, it's working :

can you share for me? your example

I've deleted it, add me to your project, I'll take a look and see if it works for me

 Tables\Columns\IconColumn::make('url')
                    ->icon('heroicon-o-external-link')
                    ->action(MediaAction::make('url')
                        ->media('https://www.youtube.com/watch?v=PrmzB21ZPhw&pp=ygUOMTEzIG91YWlzIGdyb3M%3D'))

sure, this my repo https://github.com/Bellukchips/sampe-filament-media-action.git
you can clone and analyst please

Fixed !
Your composer.json contained “filament/filament”: “3.2”, you needed “filament/filament”: “^3.2” and do a composer update as I said before. You weren't on the latest version of Filament.
I'll let you do the updating

cool, thanks for your time in helping me


Fix: Return default minimum level when category is not configured

Description
Fixes #1023.
Quality checklist

[x] Your code complies with our Coding Style.
[x] You've updated unit and/or integration tests for your change, where applicable.
[ ] You've updated documentation for your change, where applicable.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
[x] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
[ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

Should this be backported to 3.x?
/cc @TimHess

Should this be backported to 3.x?
/cc @TimHess

Yes, we should backport to 3.2


Double slash in some Make rules break compilation

For example:
make: *** No rule to make target `src//modules/flow/oic/oic.json', needed by  `build/soletta_sysroot/usr/local/Soletta/include/soletta/sol-flow/oic.h'.  Stop.

Note the double slash in "src//modules". There is a rule to generate this file, but with a single slash.
I don't know which Makefile contains those rules. Grep can't find anything.

@ceolin maybe @dorileo can help you with that.

i can help with this. Thiago how can i reproduce it ? I've never faced this problem in my system.

I don't know what caused it. I got the latest version and typed gmake.
On OS X.

ok, i'll check it correctly

fixed https://github.com/solettaproject/soletta/commit/9f60a08b67bbbc85b2d49c93f5af68bded453fd7


Upload through iframe: works in Safari, nowhere else

First off, mea culpa, I didn't test this much (at all) in other browsers while developing it. I made a simple upload form, used the documented technique to set the target to an iframe, and it works just great in Safari. But in Chrome and Firefox, clicking submit causes a new tab to open, which breaks the interaction between iframe and parent page, so my return never comes home to the correct controller method.
Here's the generated HTML:
<form class="form" target="uploader" id="new_blob_uploader" enctype="multipart/form-data" action="https://fling.s3.amazonaws.com/" accept-charset="UTF-8" method="post"><input name="utf8" value="✓" type="hidden">
    <fieldset class="well">

        <input name="key" value="uploads/f52d459f-9b75-4e47-9ce2-59acb825ad20/${filename}" id="blob_uploader_key" type="hidden"><input name="AWSAccessKeyId" value=" -- key -- " id="blob_uploader_aws_access_key_id" type="hidden"><input name="acl" value="public-read" id="blob_uploader_acl" type="hidden"><input name="policy" value=" -- crypted stuff here -- " id="blob_uploader_policy" type="hidden"><input name="signature" value=" -- signature -- " id="blob_uploader_signature" type="hidden"><input name="success_action_redirect" value="http://fling.walterdavisstudio.com/items/new" id="blob_uploader_success_action_redirect" type="hidden"><input style="display: none;" class="file" name="file" id="blob_uploader_blob" type="file">
<input readonly="readonly" class="form-control" type="text">Browse

        100MB limit per file

        <input disabled="" name="commit" value="Upload" class="btn btn-primary pull-right" data-disable-with="Uploading..." id="upload_file" type="submit">

    </fieldset>
</form>

and the iframe is on the same page:

I have experimented with different methods of hiding the iframe, in case that's the issue, but they don't seem to make any difference. Has anyone else seen this, and is there a work-around?

I just did a little test in a plain HTML file, and while Safari is happy to submit a form with a target attribute through a keyhole frame (I made mine visible and on-screen), neither Firefox or Chrome (current versions, on Mac) are willing to do this. They insist on a new tab no matter what. At the very least, this needs to be documented somewhere, and certainly confirmed with someone else testing it.
Thanks,
Walter

Sorry for the noise, I figured this out. The issue is not with the browser, but with my misreading the spec (and Safari's willingness to play along). If you don't give your iframe the name attribute, only an id, then you will get the behavior that I was seeing. If you give your iframe the name that matches the target attribute of the form tag, all will be well.


Home Page: "Connect with our founders" section creation

Create a section to highlight the founders of Oasis.
This section should include:

Image
GitHub icon + link
LinkedIn icon + link

Completed


Fix: Response is not able to parse binary segment elements

Response::findSegments and similar methods marked as deprecated:
They are not able to parse segment elements correctly, if there is a binary segment element.

Thank you for your PR!
This are too many changes though, I can't check them.
Please send small PRs :blush:

Hi @nemiah, you are right.
It was also a big problem.
@Philipp91 could you help?

This conflicts with my plan to build a fresh FinTs class (currently called FinTsNew, hopefully uploaded soon) and get rid of the messier parts of the old code. It "conflicts" because it puts logic specific to the old code into the new Parser class (and already marks it as @deprecated). While I don't mind those classes being used from the old FinTs or Response classes, I would prefer if they could remain untouched.
If you want to move forward with this for now (as I can't guarantee when the alternative design is ready), please move parseRawSegments() out (next) to its only call site, then I can rereview.

Sorry, but I won't merge this PR.
It's too messy and I cannot tell what it all does :slightly_frowning_face:

Frustrating, that Github is not able to show commit changes by ignoring space/line endings (like git does it).
I hoped, my commit messages would explain what happened, but i see, they do not.
Hopefully we could solve this space/line endings problem soon, because my IDE (PHPStorm) automatically normalise often the full file, when i change only a few lines.
So, i explain my changes by the overall file changes.
Summary:
"Response" is not able to parse segments with binary data elements. More than that, "Response" and especially "Response::findSegments" handles each data element as a string.
The most problem about that:
Within a binary data elements, delimiter will not be escaped. So there is always the risk, that the data elements are not detected correctly and splitted accidentally.
Another problem:
The splitted data elements are modified, by converting to a different character set(UTF8) or by handling XML payloads (f.e. in Response::findResponse()).
All these problems will destroy a binary payload.
In the past, someone has also detected this problem and had added an additional parameter "$fix = true" to Response::findSegments().
But this solves only some problems.
Problem 1:
The regex within Response:: unwrapEncryptedMsg() does not work, if a segment ends with a binary data element.
Probably because of that, someone has added a quick fix:
$rawResponse = preg_replace("/\@([0-9]*)\@HIRMG/", "@$1@'HIRMG", $rawResponse);

The problem with the quick fix is, that it generates two invalid formatted segments and will not be able to be parsed
Solution 1:
Response:: unwrapEncryptedMsg replaced and quick fix removed
Problem 2:
Response::findSegments() and similar methods modify data segments, ignore escaped delimiter and etc...
Solution 2:
Response should work only with correctly parsed segments. There is the "Parser", which is able to do that. Problem about that: each Response::findSegments() access has to be migrated manually (it's not done by simple search & replace) and I was not able to that in a small pull-request, so this is more a intermediate commit:

Wrong working methods like "Response::findSegments()" marked as deprecated
For compatibility reason a deprecated marked Response::$rawSegments introduced (Response::findSegments() will now use this array)
New methods introduced like Response::getSegments() : Segment\BaseSegment|Segment\AbstractSegment|null
Parser:: parseRawSegments() introduced and marked as deprecated to replace this faulty line:

$this->segments = preg_split("#'(?=[A-Z]{4,}:\d|')#", $rawResponse);

To show how the Response::getSegment() method works, Response::getDialogId() migrated

These are all changes within the class "Response" :)
Problem in class "Segment":
Segment::createFromString ignores completely escaped delimiter and binary data elements.
So replaced all by using the existing and working Parser::detectAndParseSegment().
Don't worry about the big change in the return value:
this method is currently not used
Changes in class "Parser":

Parser::parseBinaryBlock(): Only some new lines for more readability
Parser:: parseRawSegments(): New method introduced here and marked as deprecated, because it shares code from Parser::parseSegments()

Epilog
I do not insist, that the commit is merged as it is, especially if it conflicts with the solution from @Philipp91.
I can work with my fork until there is a new release. As @Philipp91 seems to work on this library offline the most time, i'm will not be able to help you there.
Beside of these changes, please don't forget to merge #126 someday.
This is a really big fail! I searched an (non existing) error in my own code for about 1,5 days until i discovered this issue.
As told in #117 i committed my full work to get PhotoTan and serialised "GetTanRequest" objects in https://github.com/fbett/phpFinTS/commits/develop
Probably the most interesting commits are:

New Segment: HITAN\HITANv6
Response\GetTANRequest extended to get "Challenge" and "Challenge Image" (PhotoTan) (here you are able to see the benefit of using Segment objects in the Response class.)
Response\GetTanRequest should be serialisable; Restorable DialogState introduced
FinTS::finishSEPATANFromSerialized() introduced to use if a GetTanRequest is serialized

Thank you for your explanations. I think I need to clarify:
I have no problem whatsoever with the changes of the PR, just with the amount of changes.
There are 13 commits. Some merges, some real changes. It's difficult for me to separate them and keep the overview. I see it as my job to make sure that I don't break (a lot of :grin:) things when merging any PR. Thus I ask you to please resubmit the PR with only the real changes :relaxed:


http2: propagates reset events to CodecEventCallbacks when sending RST_STREAM

We have found this patch useful in our testing.
The delta between the first and second commit demonstrates test coverage for the new code.
Commit Message: propagates reset events to CodecEventCallbacks when sending RST_STREAM
Additional Description:
Risk Level: low
Testing: ran unit and integration tests locally
Docs Changes:
Release Notes:
Platform Specific Features:

FYI @diannahu @RyanTheOptimist @alyssawilk


Can't access Vendor-specific information (opt 17 ipv6) in the hookup script.

Hi,
DHCPv6 server in Advertise message sending the 17 option to dhcpcd client. It could be seen on the Wireshark screenshot:

But when I'm printing all available options in hookup script. Only Enterprise ID (new_dhcp6_vivso_enterprise_number) is available.

Do you know how can I get Vendor-specific option data?
B/R
Denys

You need to add instructions to dhcpcd.conf on how to decode it - dhcpcd has no idea about per enterprise options.
The dhcpcd.conf man page should have instructions for that.

Hi, thanks for the quick reply!
As I learned from man dhcpcd.conf there is a possibility to request custom options, but I need to request existing one.
>dhcpcd -V
...
00017 vivso                             	 embed
...

I've tried to overwrite the existing one (option 17) with command in dhcpcd.conf file
...
define6 17 encap vendor_encap
...

but it's not working. dhcpcd client doesn't request the 17 option from DHCP server.

It is requesting it when I add option vivso into config file and remove define6 17 encap vendor_encap, but only part of it available in the hookup script (enterprise id).
I'm using:
dhcpcd 6.11.5
Copyright (c) 2006-2016 Roy Marples
Compiled in features: INET IPv4LL INET6 DHCPv6 AUTH

Do you have time to help me to solve my problem?
B/R
Denys

Oh, sorry, I've changed the instruction from define6 17 encap vendor_encap to define6 17 request encap vendor_encap and now it is requesting it.  My mistake!
But it can't be parsed, I will try to use another type.

Hi, the solution define6 17 request binhex vendor_specific_info.
B/R
Denys


Submit removal comment at the very end

It appears that Toolbox is sometimes too slow at stickying its own removal reason, resulting in the Flair Assistant not seeing it in the mod log yet. Moving it to the end might help a little.
https://github.com/PitchforkAssistant/devvit-flair-assistant/blob/b3f45d928715d46192c374e2b5c2ed2acab2ae8c/src/handlers/events.ts#L146C1-L165C6

resolved by 4858a31a65de133e5f0d4ff669a49eff285123ce


Move generated controller.pb.go to right place so it can be imported …

…properly without errors

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 62.684%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1275

Relevant Lines:
2034

💛  - Coveralls


[WIP] Initial implementation of Hilbert detector

PR Description
Addresses part of: #18
Implement the Hilbert Detector in the same 2-step approach as the other detectors.
Merge checklist
Maintainer, please confirm the following before merging:

[ ] All comments resolved
[ ] This is not your own PR
[ ] All CIs are happy
[ ] PR title starts with [MRG]
[ ] whats_new.rst is updated
[ ] PR description includes phrase "closes <#issue-number>"

So right now, _post_process_ch_hfos simply calls the threshold_func to determine the threshold, then applies this threshold to the data to identify events. Obviously this is too simple for a Hilbert detector, or something more complex. My initial attempt seems slightly wrong, so what do you think about this workflow.
if threshold-method == '<method>':     threshold_det_func = threshold_det_<method>     event_identification_func = event_identification_<method>     event_merging_func = event_merging_<method>     extra_params = dict(values=values,...)
This will allow us to keep things simple for RMS/Line Length Detectors, but allow for any level of complexity at each step for the more complicated detectors.

So right now, _post_process_ch_hfos simply calls the threshold_func to determine the threshold, then applies this threshold to the data to identify events. Obviously this is too simple for a Hilbert detector, or something more complex. My initial attempt seems slightly wrong, so what do you think about this workflow.
if threshold-method == '<method>': threshold_det_func = threshold_det_<method> event_identification_func = event_identification_<method> event_merging_func = event_merging_<method> extra_params = dict(values=values,...)

Would you mind explaining to me with some more detail here? I'm not quite following. So Hilbert rn requires 3 thresholds: i) zscore of the Hilbert transform envelope, ii) number of cycles found and iii) gaps (idr what gaps were, so maybe we need to document that better).
The issue is _post_process_ch_hfos performs thresholding of only one metric. It seems based on our convos so far, that Hilbert needs to store the output of the thresholding step? Or how is the thresholding step connected to later on?
If thresholding needs to be a distinct step in of itself, then we can have each fit be: i) _compute_hfo_metrics, ii) threshold and iii) post_process into HFO detections. Would that work? You then can i) refactor the threshold step for all detectors out of the _post_proc function and then ii) refactor the _band_z_score_detect function into postprocess?
If I'm missing anything, lmk.

So the basic idea of _run_detect_branch is to find the entire freq band that the HFO occurred in. Each freq band has a band_idx, so the goal is to check if there exists eventi[band_idx], eventj[band_idx+1] that overlap, and the recursion allows that to keep going for eventi[band_idx], eventj[band_idx+1], eventk[band_idx+2], .... is equal to one event
Once the overlapping events are merged, the HFO is defined as the [min start time, max end time] and the freq band is defined as [l_freq(band_idx), h_freq(band_idx+(n-1)]  for n overlapping events.
Unfortunately I don't think computational efficiency is going to be good for this no matter what, but this is generally the new idea:
#  For simplicity lets assume each detection has the form [start, stop, band_idx]
outlines = list
for detection in detections:
----if band_idx is 0:
--------append detection to outlines
----else:
--------for outline in outlines:
------------if detection overlaps outline:
----------------merge detection and outline
------------else:
----------------append detection to outlines
Then outlines should only have distinct HFO events

Looks like _band_zscore_detect in utils.py isn't covered. I think you don't need that anymore right since you refactored things?

Looks like _band_zscore_detect in utils.py isn't covered. I think you don't need that anymore right since you refactored things?

No, it is used by apply_hilbert function. I can test

Codecov Report

Merging #23 (f255b7e) into master (b9cc29c) will increase coverage by 1.26%.
The diff coverage is 46.03%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   70.96%   72.23%   +1.26%
==========================================
  Files          13       13
  Lines        1054     1167     +113
==========================================
+ Hits          748      843      +95
- Misses        306      324      +18

Impacted Files
Coverage Δ

mne_hfo/detect.py
59.09% <38.88%> (+21.65%)
:arrow_up:

mne_hfo/utils.py
51.59% <46.51%> (-12.34%)
:arrow_down:

mne_hfo/base.py
74.85% <54.90%> (+1.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cc29c...f255b7e. Read the comment docs.


chore: Remove legacy code for exit handling in node.js < 0.11.8

Coverage decreased (-0.009%) to 96.639% when pulling d7345a4a8354a2f6dd68cce6f7bd07153ee7888e on coreyfarrell:no-legacy-exit into 5d5f340d2d400e5d3f8f847c193796e284b1b7d1 on istanbuljs:master.


CORE-7040: Rename RPC leftovers into REST

Related PR: https://github.com/corda/corda-runtime-os/pull/3269

VirtualNodeRestResourceImpl.kt

Thanks @conalsmith-r3 - let's address those as a separate PR once this one is merged.

Just a note: the rpc-api and rpc-api-tls refer to constants used in the CryptoWorker, and defined in corda-api avro files s o some care should be taken when changing them.


Add information about the different available deployment types (Resource Group/Subscription)

[Enter feedback here]
There should be a mention that if deployed to a resource group (PS command: New-AzResourceGroupDeployment) is used then the budget is tied to the Resource group, whilst if New-AzSubscriptionDeployment is used with a subscriptionDeploymentTemplate then the scope of the budget is at subscription level and not resource group level.
Reference:
https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/deploy-to-subscription

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 080cd0e8-fd09-6361-8c14-fe9f80758417
Version Independent ID: 2bab0ac2-1fd5-c6d9-d5ac-a44fcb8c8d75
Content: Quickstart - Create a budget with an Azure Resource Manager template
Content Source: articles/cost-management-billing/costs/quick-create-budget-template.md
Service: cost-management-billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@SebastianClaesson Thanks for the feedback. We are looking into this and will get back to you shortly.

@bandersmsft FYI.

@SebastianClaesson Thanks for your input about the article. The schema at the top of the template ( https://schema.management.azure.com/schemas/2018-05-01/subscriptionDeploymentTemplate.json#) defaults to a subscription level deployment from ARM’s perspective. You can look for the complete set of $schema to create budget resources at https://docs.microsoft.com/azure/azure-resource-manager/templates/template-syntax. If you scroll down the $schema section, you can see which schema to pick for creating for what type of deployment/resource.
Hopefully that helps your situation. The intent of the article is to walk new users through creating a budget with a template. As you noted, there are other ways to create a budget but that might be a little advanced for this quickstart guide.
#please-close


🛠 Tooling: Investigate simplifying release commenter version name

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Following #427 -> #428: per https://github.com/apexskier/github-release-commenter/issues/432, it looks like ${{ payload.release.tag_name }} should be usable to get the tag name of the released version. It'd be nice to use that instead of having to manually run a command: https://github.com/JoshuaKGoldberg/create-typescript-app/blob/d53c4eea73e084307a2d5eb9386727d0e3bf91ac/.github/workflows/post-release.yml#L8
Investigation required. If this strategy does work, hooray! Accepting PRs!
Additional Info
No response

Ah, wrong link. Will fix.

I really hate debugging GitHub Actions...

Invalid workflow file: .github/workflows/post-release.yml#L11The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name
--

[Invalid workflow file: .github/workflows/post-release.yml#L11](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/11394888134/workflow)
The workflow is not valid. .github/workflows/post-release.yml (Line: 11, Col: 29): Unrecognized named-value: 'payload'. Located at position 1 within expression: payload.release.tag_name

Things are back to how they were in #1666. Still accepting PRs on this issue...


feat: add other entity types

Where did this change come from?  Presumably BC Registries?

And should it be “Associations” vs. “Association”?  It sounds like a single entity, which is what threw me off.

@amanji, Ping me when this is ready to go.

Ready to merge


Can't stop cursor blinks

Current Filetype:
Available Linters: []
Enabled Linters: []
Linter Variables:
Global Variables:
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = 'Error'
let g:ale_echo_msg_format = '%s'
let g:ale_echo_msg_warning_str = 'Warning'
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_keep_list_window_open = 0
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'always'
let g:ale_linter_aliases = {}
let g:ale_linters = {'html': []}
let g:ale_open_list = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = 0
let g:ale_sign_error = '✗'
let g:ale_sign_offset = 1000000
let g:ale_sign_warning = '⚠'
let g:ale_statusline_format = ['✗ %d', '⚠ %d', '']
let g:ale_warn_about_trailing_whitespace = 1
Command History:
My problem
I have configured neovim to avoid cursor blink and works well:
set termguicolors
hi iCursor guifg=bg guibg=white
hi nCursor guifg=bg guibg=#93a1a1
set guicursor=a:blinkon0
  \,n-c-v:block-nCursor
  \,i:block-iCursor
  \,r:hor20-iCursor

But If I enable ALE plugin the cursor blinks again.
I want stop the cursor blinks on insert mode.
Regards

I'll look into this, maybe tomorrow.

The lines above for set guicursor do not work for me, but the line from the NeoVim FAQ does.
:set guicursor=n-v-c:block-Cursor/lCursor-blinkon0,i-ci:ver25-Cursor/lCursor,r-cr:hor20-Cursor/lCursor

I don't experience any blinking after using that in init.vim.

Hi @w0rp
I made a video for you that shows the blink cursor on inser mode: https://screencast-o-matic.com/watch/cbiw3elzRP
The cursor configuration I've use is your configuration with minimal modifications:
hi iCursor guifg=bg guibg=white
hi nCursor guifg=bg guibg=#93a1a1
set guicursor=n-v-c:block-Cursor/lCursor-blinkon0,i-ci:block-iCursor/lCursor-blinkon0,r-cr:hor20-Cursor/lCursor-blinkon0

Look at the output you recorded. There is an exception being thrown for ALEGetStatusLine. Could you copy and paste those errors here? It's possible that an exception being thrown in the configuration means that you line for disabling cursor blinking isn't being run.

@w0rp the errors is because I have deactivated ALE plugin and I have added this to my status line
set statusline +=\ %2*%=\ %l:%v\ %P\ %*\%{ALEGetStatusLine()}%*

Now I have changed this line for this and I have not errors:
set statusline +=\ %2*%=\ %l:%v\ %P\ %*\%*

Okay. Does the cursor stop blinking if you use the option from the NeoVim FAW exactly?
ALE doesn't change the guicursor option at all, so I don't know why it would make a difference.

Can you create a minimal configuration file, containing nothing but the cursor settings and ALE, which I can try and repeat the bug with?

@w0rp yes, but I can't load only the ale plugin. I try with this but I can't:
set runtimepath+=~/.config/nvim/plugged/ale/autoload/

@w0rp I've found the problem. My configuration causes the blink cursor in conjunction with ALE plugin. To see the active branch I have used this function:
" Git branch
function! GitBranch()
  let branch = system("git branch 2> /dev/null | sed -e '/^[^*]/d' -e 's/* //'")
  if branch != ''
      return ' ' . substitute(branch, '\n', '', 'g') . ' '
  en
  return ''
endfunction

and when I insert this to the statusline the cursor blinks:
set statusline =\%2*\ %-2{GitBranch()}\ %*\ %f\ %m

For some reason this problem stops if I deactivate ALE plugin.
I'm going to find another way to see my git branch...
Thanks for your help :D


When reading CodeIntegrity events, the RequestedPolicy value is not parsed

I'm unsure if this is from the DB extraction not working properly or something else, but for event ID 3033, you will get this:
Code Integrity determined that a process (some.exe) attempted to load \Device\HarddiskVolume1\Windows\System32\some.dll that did not meet the 8 signing level requirements.
This should say "Microsoft"
Value comes from here in the XML:
 <Data Name="RequestedPolicy">8</Data>

It's not with the database, it is with the event record itself.
Since the events "EventData" has that "Data" value of 8 is why it gets displayed in the description as 8. There isn't any logic against these properties so whatever we pull from the event properties and the event template is what we resolve into the description.


Backtick replacement

Rationale
Backtick command substitution `..` is legacy syntax with several issues.

It has a series of undefined behaviors related to quoting in POSIX.
It imposes a custom escaping mode with surprising results.
It's exceptionally hard to nest.

$(..) command substitution has none of these problems, and is therefore strongly encouraged.

LGTM.  Have you tested these changes on a working loop yet?

I intend to rebuild a second rig with these changes tonight and I'll report back tomorrow.

Ok, cool.  I might merge them to the oref0-setup branch and test them
tonight if I have time, too.

Ok, merging.  This is a squash and merge, so you should merge dev back into your dev_vanilla branch (or start a new one) for future merges.


Consider removing the unknown userAgent warning

We might consider removing the warning at all. This would remove the need of a whitelist and remove the need to "simulate" a valid userAgent.
Also note that at some point the warning is used to file detection bugs as well. One would perhaps wonder why styles do not get prefixed correctly which is where the warning often helped to understand the problem.

I'd be in favor of at least allowing it to be removed -- currently, if you use JSDOM as a test environment, this warning is thrown in tests because the user-agent is Node.js (darwin; U; rv:v5.5.0).
Related -- my expectation is that if the user agent cannot be parsed for any reason, the prefixer will fallback to use prefixAll.

Yeah, I also got those warnings within my tests (but basically just ignore those). As I still think removing is kind of a bad idea, using prefixAll as a fallback gives pretty much sense.
Still I'd like to think more about that the next couple days. I am happy to see other feedback and thanks @irvinebroque !

Would be really good to get a way to disable this warning, makes running unit tests awkward.

+1
Personally I don't think the code should log anything when it doesn't recognise a user-agent. Also not everyone uses a fake DOM that spoofs the UA, so I wouldn't log anything then, either.

I guess providing the prefixAll fallback actually also removes the need for a warning as the warning was used to tell "Hey, you might end up with broken (as unprefixed) styles in some browsers."
I think we can also upgrade to 1.0 after this is implemented as it then supports basically* every browser.

Of course there still might be a case where the detection tool fails and returns wrong browser data which leads to wrong prefixing, but that's nothing we can change or should focus on.


Can't import

I've found this repo from here:
http://antonioleiva.com/navigation-view/
but when I try to import it, I get this error:

Why does it happen? and how do I fix it?

@AndroidDeveloperLB I've just deleted lines in the build.gradle:
signingConfigs {
        release {
            storeFile file(RELEASE_STORE_FILE)
            storePassword RELEASE_STORE_PASSWORD
            keyAlias RELEASE_KEY_ALIAS
            keyPassword RELEASE_KEY_PASSWORD
        }
  }

And
signingConfig signingConfigs.release
In the buildTypes section.

I still have this issue. :(

@AndroidDeveloperLB try clean and rebuild project.

@AndroidDeveloperLB just have a look: https://gist.github.com/anonymous/c617a07c601009ae8270

Thanks @KChernenko !

@KChernenko What to look there for? I've used the normal import via Android-Studio, and it failed to import, so it won't even show the opened project.

@AndroidDeveloperLB after Android Studio shows you this error, you should press ok button, and find&fix build.gradle in the project hierarchy tree.

@KChernenko Pressing the OK dialog will close it and return to the previous screen I had (previously opened project, for example), so I can't choose the build.gradle file.
Do you mean I should edit the file outside of Android-Studio? This isn't needed for any repo. Why does it occur here?

@AndroidDeveloperLB if you are using the clone project from Github, it should already be downloaded. After you press OK, go to "open existing project" in the Android Studio start screen, you will have to navigate to the folder it saved the repo and open it again. Once you have it open you can apply the changes in the build.gradle file.

After double importing (which I don't understand why it's needed), I see the "build.gradle" quite minimal. It does lack some important things. It doesn't even have "buildTypes"...
How come?
How do I add the buildTypes that you wanted? In a normal app, I see both "defaultConfig" and "buildTypes" being set.

@AndroidDeveloperLB There is several build.gradle files within the project, look through every folder in the tree and you will find the one with the defaultConfig and buildTypes in it (I'm not at my PC with Android Studio atm sorry). Once you have put the right values in it make sure you clean and rebuild the project.

Oh, for some reason this file is missing from the "gradle scripts" category. After deleting the problematic lines, all went well.
How could this be?
Also, I've noticed you have a settings item. May I recommend this repo I've made:
https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary
?


 : Adding a file system watcher that sends messages when…

Implementing https://github.com/lloydmeta/schwatcher/issues/64
This way consumers can directly use an actor for their FSWatch needs.

Hey, would you be interested in adding this actor to schwatcher. That way I do not have to maintain the code in my Project.

Hey would these changes be sufficient?

Ok. How about now?

So sorry for the delay. I keep forgetting to submit the review feedback after writing comments...

Fixed.

Done.

Thanks, it looks good to me now. Merging :) Thanks for your hard work.

Pushed 0.3.3 to Maven Central.


Decode responses from redis

FIxes:
    return_value = f(*args, **kwargs)
  File "/usr/local/lib/python3.8/site-packages/flanker/addresslib/address.py", line 322, in validate_address
    plugin = plugin_for_esp(exchanger)
  File "/usr/local/lib/python3.8/site-packages/flanker/addresslib/validate.py", line 129, in plugin_for_esp
    if grammar[0].match(mail_exchanger):
TypeError: cannot use a string pattern on a bytes-like object

Can one of the admins verify this patch?

This might not be true for everyone. (We have no such issue in our prod environment)
You could make this optional for example.
decode_resp = os.environ.get('REDIS_DECODE_RESPONSES, '')

to make it optional.

@thrawn01 Thanks for the review.
Done the changes.


extract-text-webpack-plugin@2 support in extract-svg-plugin

throw new Error("Breaking change: ExtractTextPlugin now only takes a single argument. Either an options " +
		^

Error: Breaking change: ExtractTextPlugin now only takes a single argument. Either an options object *or* the name of the result file.
Example: if your old code looked like this:
    new ExtractTextPlugin('css/[name].css', { disable: false, allChunks: true })

You would change it to:
    new ExtractTextPlugin({ filename: 'css/[name].css', disable: false, allChunks: true })

The available options are:
    filename: string
    allChunks: boolean
    disable: boolean

Duplicate of #54

Shipped with 0.0.30. Also now you can omit extract=true option, loader will try to detect extract mode automatically.


Bug report:There is an abnormal black rectangular block in the status bar of the screen opening page

Describe the bug
When opening the application and entering the screen opening stage, an abnormal black rectangular block can be seen in the screen opening status bar. Normally, there should not be this black rectangular block
To reproduce

Open application
pay attention to the status bar area

Expected behavior
When opening the application and entering the screen opening stage, an abnormal black rectangular block can be seen in the screen opening status bar. Normally, there should not be this black rectangular block
Screenshots

https://github.com/user-attachments/assets/3209b608-cffe-4b32-bc14-0d1e3c509da5
Desktop (please complete the following information)
aosp 12
Smartphone (please complete the following information)
aosp12
Additional context
No response

Regarding this issue, you can refer to flclash, which also uses Flutter
https://github.com/chen08209/FlClash
And the following two software also use Flutter, which had the same issue before and has now been fixed
https://github.com/Predidit/Kazumi/issues/280
https://github.com/qixiaoo/masiro/issues/17

According to developer Qixiaoo, the specific reason is that the theme for entering the app and the theme for the screen opening page are not the same, and need to be set separately for the screen opening pageLaunchTheme

This comment is from the following issue
https://github.com/Predidit/Kazumi/issues/280


Revert "upgraded jboss-ip-bom to 6.0.7.Final (#225)"

This reverts commit 21ce25c7e67755a71824aae2d9f58215bda29d97.
As ip-bom 6.0.7.Final contains an upgrade to <version.com.thoughtworks.xstream>1.4.9 and this
contains Java 8 (non-backwards compatibile) code, which causes Webpshere to prevent the BPMS
webservice from deploying we have to revert this.

+1


fix: allow overriding specific build output files with aliases

🔗 Linked issue
https://github.com/nuxt/framework/issues/5013
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
In some cases, such as the linked issue (which we could resolve by adding an alias to a stub file in the case of ssr: false), it is helpful to be able to override individual #build/some-file.js aliases, and to do this we need #build to be defined last in the object.
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

We have dynamic virtual imports (https://nitro.unjs.io/config/#virtual) that can be used in order to override any import. (I made this feature initially for linked issue in fact)
env.alias can be used to override other aliases for any similar situation.


git submodule update

git submodule update

Please update the git submodule as well. It is currently pointing to
https://github.com/openxc/openxc-ios-framework/tree/3c96b45cddc866247d96d25250c5f8a1394b6c9b
Should point to current master.

updated in a new branch


marker.setPosition(latLng) doesn't change map_icon_label correctly

Hello,
when I tried to change position of an already created marker, it changes only the icon, without map_icon_label.
Here is the code for changing the position:
// marker is instance of Marker
marker.setPosition(latLng);

Here is the screenshot:

Regards,
Jordan

Could this be linked to https://github.com/scottdejonge/map-icons/issues/39 ?

I don't think so.


MLServer init error when deploying model in mlflow runtime

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
follow the example on https://kserve.github.io/website/0.10/modelserving/v1beta1/mlflow/v2/#deploy-with-inferenceservice, copy-pasted most of the code, except using a MinIO on local machine instead of the GoogleStorage
Error log from the pod, tried with different mlflow flavor and all resulted in the same error
TypeError: __init__() got an unexpected keyword argument 'required'
2024-11-21 19:59:14,931 [mlserver] INFO - Couldn't load model 'mlflow-v2-wine-classifier'. Model will be removed from registry.
2024-11-21 19:59:14,940 [mlserver.parallel] ERROR - An error occurred processing a model update of type 'Unload'.
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/worker.py", line 160, in _process_model_update
    await self._model_registry.unload_version(
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 302, in unload_version
    await model_registry.unload_version(version)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 201, in unload_version
    model = await self.get_model(version)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 237, in get_model
    raise ModelNotFound(self._name, version)
mlserver.errors.ModelNotFound: Model mlflow-v2-wine-classifier not found
2024-11-21 19:59:14,943 [mlserver] ERROR - Some of the models failed to load during startup!
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/mlserver/server.py", line 125, in start
    await asyncio.gather(
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 293, in load
    return await self._models[model_settings.name].load(model_settings)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 148, in load
    await self._load_model(new_model)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/registry.py", line 161, in _load_model
    model = await callback(model)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/registry.py", line 152, in load_model
    loaded = await pool.load_model(model)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/pool.py", line 74, in load_model
    await self._dispatcher.dispatch_update(load_message)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/dispatcher.py", line 123, in dispatch_update
    return await asyncio.gather(
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/dispatcher.py", line 138, in _dispatch_update
    return await self._dispatch(worker_update)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/dispatcher.py", line 146, in _dispatch
    return await self._wait_response(internal_id)
  File "/opt/conda/lib/python3.8/site-packages/mlserver/parallel/dispatcher.py", line 152, in _wait_response
    inference_response = await async_response
mlserver.parallel.errors.WorkerError: builtins.TypeError: __init__() got an unexpected keyword argument 'required'

What did you expect to happen:
model deploy successful
What's the InferenceService yaml:
kubectl get isvc mlflow-v2-wine-classifier -oyaml
apiVersion: serving.kserve.io/v1beta1
kind: InferenceService
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"serving.kserve.io/v1beta1","kind":"InferenceService","metadata":{"annotations":{},"name":"mlflow-v2-wine-classifier","namespace":"default"},"spec":{"predictor":{"model":{"modelFormat":{"name":"mlflow"},"protocolVersion":"v2","storageUri":"s3://mlflow/0/7b391abd963b40dfb2297ad01c32783e/artifacts/model"},"serviceAccountName":"sa"}}}
  creationTimestamp: "2024-11-21T19:57:02Z"
  finalizers:
  - inferenceservice.finalizers
  generation: 1
  name: mlflow-v2-wine-classifier
  namespace: default
  resourceVersion: "675545"
  uid: 5e3c2aae-47a0-43bc-a808-f9d561544fe1
spec:
  predictor:
    model:
      modelFormat:
        name: mlflow
      name: ""
      protocolVersion: v2
      resources: {}
      storageUri: s3://mlflow/0/7b391abd963b40dfb2297ad01c32783e/artifacts/model
    serviceAccountName: sa
status:
  components:
    predictor:
      latestCreatedRevision: mlflow-v2-wine-classifier-predictor-00001
      latestReadyRevision: mlflow-v2-wine-classifier-predictor-00001
      latestRolledoutRevision: mlflow-v2-wine-classifier-predictor-00001
      traffic:
      - latestRevision: true
        percent: 100
        revisionName: mlflow-v2-wine-classifier-predictor-00001
  conditions:
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    severity: Info
    status: "True"
    type: LatestDeploymentReady
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    severity: Info
    status: "True"
    type: PredictorConfigurationReady
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    message: Ingress has not yet been reconciled.
    reason: IngressNotConfigured
    status: Unknown
    type: PredictorReady
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    message: Ingress has not yet been reconciled.
    reason: IngressNotConfigured
    severity: Info
    status: Unknown
    type: PredictorRouteReady
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    message: Ingress has not yet been reconciled.
    reason: IngressNotConfigured
    status: Unknown
    type: Ready
  - lastTransitionTime: "2024-11-21T20:02:16Z"
    reason: PredictorRouteReady not ready
    severity: Info
    status: Unknown
    type: RoutesReady
  modelStatus:
    states:
      activeModelState: ""
      targetModelState: Pending
    transitionStatus: InProgress
  observedGeneration: 1

[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version: 1.20.3
Knative Version: 1.13.1
KServe Version:0.13.0
Kubeflow version: not installed
Cloud Environment:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube/Kind version:1.34.0
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

@mzhl1111 Did you use the model provided in the example or your own ? It seems like the version incompatibility with the model. I have tested the example. It is working fine for me

Tried firstly on my own model and then used the exact script in the example, both end up the same error

@mzhl1111 That's interesting. I am not able to reproduce the error. Can you proivde the yaml ?

@sivanantha321 did you try with 0.14?
@mzhl1111 can you please try with the latest version as well?

Yes. I tried with 0.14 with mlserver 1.5.0 and mlserver 1.3.5 (which is the default runtime in 0.13)

I posted my knowledge from testing with KServe version 0.12 to the Discussion.
https://github.com/kserve/kserve/discussions/4100
I suspect the inability to reproduce the conda environment in MLServer might be the cause.
MLflow model includes a requirements.txt file, so ideally it could reproduce the conda environment from that,
but it seems MLServer doesn't have that functionality implemented.

@sivanantha321 @spolti tried, still the same mlserver error.


fix: resolve issue where results may not be obtained from sidecar logs

fix: #8028
If the sidecar is not completed, the complete log may not be retrieved from it, thus unable to parse the final task results.

Changes

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[ ] pre-commit Passed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
fix: resolve issue where results may not be obtained from sidecar logs

/kind bug
This issue should affect the most recent LTS versions.

From v0.43 https://github.com/tektoncd/pipeline/issues/5851

Ref:

https://github.com/tektoncd/pipeline/issues/6133

/test pull-tekton-pipeline-alpha-integration-tests

/retest-required

This modification will cause the integration test for the alpha feature to fail. I will fix it later.

/lgtm

We are running into the same issue, can we cherry pick this to 0.59?
/cherrypick release-v0.59.x


✨ feat: built-in themes from PlantUML (#40)

BREAKING CHANGE: renaming of public enum PumlThemes to Theme and isolated breaking changes in this enum
#40

Codecov Report

Merging #41 (d322e08) into main (20ac611) will decrease coverage by 0.37%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   88.70%   88.33%   -0.38%
==========================================
  Files          21       21
  Lines         779      797      +18
==========================================
+ Hits          691      704      +13
- Misses         88       93       +5

Impacted Files
Coverage Δ

...lantUMLFramework/Configuration/Configuration.swift
70.58% <50.00%> (-3.61%)
:arrow_down:

...s/SwiftPlantUMLFramework/Configuration/Theme.swift
80.00% <80.00%> (-20.00%)
:arrow_down:

...ources/SwiftPlantUMLFramework/PlantUMLScript.swift
95.83% <100.00%> (+0.18%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Can't hide check box in the folder settings.

Description
When deactivate showing chek box when select, it doesn't works.
Steps To Reproduce

seetings button in the right up corner.
click "folder" tab
select display part, then navigate to "shwo check boexes when selecting items"

Requirements

eg. Fix crash that occurs when...
eg. Correct action happens when clicking...

Files Version
<IP_ADDRESS>
Windows Version
win 11 professional, 22H2, 22621.1555
Log file
debug.log

Thanks for the report. I am unable to reproduce this, Can you give the following information.

Did you turn the option off?
Is this in certain layouts?
Are you hovering over the selected item? As the option is so it only shows on hover.

@chrisli6867 is this the same issue #12181?

@chrisli6867 assuming this is the same issue, it'll be resolved in v2.5.


[Tracking Issue][Unity][WebGPU] Supporting fp16 in WebGPU backend

This issue is to track progress for FP16 in WebGPU Backend

[x] P1. Support FP16 dtype in WGSL codegen (#14904)

Triage

backend: webgpu

cc @quic-sanirudh

This is now landed

Try out https://github.com/mlc-ai/web-llm/tree/main#get-started with RedPajama-INCITE-Chat-3B-v1-q4f16_0


python312Packages.crc16: refactor, python312Packages.pyoppleio: refactor

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 313582 run on x86_64-linux 1

8 packages built:

python311Packages.crc16
python311Packages.crc16.dist
python311Packages.pyoppleio
python311Packages.pyoppleio.dist
python312Packages.crc16
python312Packages.crc16.dist
python312Packages.pyoppleio
python312Packages.pyoppleio.dist


doc: updated eddsa

Pull Request Description

The doc for the eddsa example has been updated

@ThomasPiellard please fix errors + merge


#98 Add space in axis names

#98 Add a space in the axis names
closes #98

Good catch 😄  It should be fixed now. I forget to change in index.ts as well


Fails to compile with PSRDADA enabled

CMake doesn't add PSRDADA libraries, so compilation fails when PSRDADA is enabled. Can be fixed by adding the following to CMakeLists.txt after the first set(TARGET_LINK_LIBRARIES) line (copied from AMBER):
if($ENV{PSRDADA})
  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DHAVE_PSRDADA")
  set(TARGET_LINK_LIBRARIES ${TARGET_LINK_LIBRARIES} psrdada cudart)
endif()

Fixed.


Auto Capture

Can we enable automatic photo capture with the getCameraImage() method? I need such a feature.

I presume  you  whant to take a  photo directly with a call to the plugin? This is not possible due to plugin uses the default camera app.
To make this work you need to implement a whole camera application into the plugin.
You may look into CameraServer https://docs.godotengine.org/en/stable/classes/class_cameraserver.html . The documentation on this is a bit lackning tough.

It does not support Android.

You may edit https://github.com/funabab/godot-camera-plugin to get what you want. The plugin has implement a camera into the plugin.

modul not working


feat(article): don't show reply requests with <=0 score for users not logged in yet

As title.
Fixes #522
Not logged in

Logged in

Coverage: 76.249%. Remained the same when pulling 2dc543117ac9804ee906d5351c11d1bc178b5abf on hide-reply-request-for-anonymous into ade621bb997239d320af089868035b19b21d602f on block-seo-m3.


fix null props not overwrite parent context

Q
A

Bug fix?
yes

New feature?
no

Issues
Fix #1970

License
MIT

So weird! The code was there but at the wrong place!

Could we add a test or two to prevent regression in the future ?

Thanks for fixing this bug Matheo.


Don't quite understand code in npy.rs

There's a function in candle-core/src/npy.rs, from line 246: and I don't understand the last 3 lines. We read the file to data vec, and don't do anything with it? And we call from reader, but the reader is already reached the end. What do I miss here?
pub fn read_npy<T: AsRef<Path>>(path: T) -> Result<Self> {
    let mut reader = File::open(path.as_ref())?;
    let header = read_header(&mut reader)?;
    let header = Header::parse(&header)?;
    if header.fortran_order {
        return Err(Error::Npy("fortran order not supported".to_string()));
    }
    let mut data: Vec<u8> = vec![];
    reader.read_to_end(&mut data)?;
    Self::from_reader(header.shape(), header.descr, &mut reader)
}

Oh nice catch, I think this might be a bug that was introduced through some debugging. read_npy is probably never used as read_npz is much more convenient. If you have the cycles to write a small test, check that it fails, and remove the two weird lines then check that it works, that would be great! Otherwise no worries I'll take a stab at it later today or tomorrow.

To be honest, I am new to the AI stuff, and not even sure what npy means. :-) That's the reason I start leaning by reading the source code. Probably nobody found it before because nobody actually read the source code unless they hit a wall. :-)
Never used python, so I think I can't help this for the moment. Just trying get my head around what is a model, and what is a tensor, and how exactly they work for now.:-)

Just created #1080 that adds a test for reading npy and npz files. Reading npy files indeed fails and passed after removing the lines you noticed, thanks again for reporting 🙏


Not able to see the related list

The related list has been loading since I have opened the account and it still showing the loading icon

Hey would you uploads som screen shoots of the problem please.
What's the component's config on the flexi page?

Hi,
Is there any way of having this appear in the Salesforce App?

Hi,
Is there any way of having this appear in the Salesforce App?

Hey @Pioneerhardware , do you mean the SF mobile APP? At this stage salesforce doesn't allow custom lightning component on the SF mobile app. But I can see SF is making that feature in the near future, I'll keep you posted and update this rep once it's out.

Hi,
Is there any way of having this appear in the Salesforce App?

Adding a new issue and closing this one.


🐛Tina CMS - Tina Cloud Authorization failed - Invalid Site URL

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!
I am trying to log in to Tina CLoud via GitHub, but the pop shows that it's an invalid site URL after I click the "Authorization with GitHub" button.

Reproduction
https://kristenhu.github.io/tina-cloud/admin/
Steps to reproduce

Click the "Continue to Tina Cloud" button

Click the "Authorization with GitHub" button

System Info
Browser: Google Chrome Version 126.0.6478.127

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

Hi @KristenHu,
I have checked your records in Tina Cloud and your account appears to be configured correctly.

Do you see "https://kristenhu.github.io" in your project overview at Tina Cloud at the location indicated in the screenshot below?
If you are already logged in to Tina Cloud, are you still getting the same error when you authenticate at https://kristenhu.github.io/tina-cloud/admin/ ?

Figure: Site URLs location on the project overview

Succeed after clearing the cache data😊


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
8253693f4e9c3b8dda028840e9eb7013d6871010
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Fix & clarify phase 5

Problem:
The code blocks are not formatted consistently. Since the file source is not typically viewed, this isn't a huge problem. However, at least tree of the code blocks in "Phase 5: Deploy a development branch" are not rendered correctly due to the formatting issues:

Step 1 of the deployment section is showing the shell tag for the code block as part of the code, and the line breaks are not being rendered.

Step 1 of the access section is also showing the shell tag for the code block.

Additionally, the instructions to view the new job and it's console output are terse and vague. It is assumed that the reader is familiar with Jenkins and knows how to access these things.
Fix:

I reformatted the code blocks in phase 5 so they are consistent
All blocks are indented with 3 spaces
All blocks have a blank line above and below them
The "Deploy" vs "Access" stages of the "Deploy a development branch" have been more clearly defined, with full instructions on how to access the Console Output of the Jenkins build.

Before:

After:

FYI: This will conflict with #44. So will need to be rebased if that is merged first.

Thanks again @Chekote!!


Where do we need to place the .pem file in our rails app?

Here,
RestClient::Request.execute(method: :get, url: 'http://example.com/resource',
                            ssl_ca_file: 'myca.pem',
                            ssl_ciphers: 'AESGCM:!aNULL')

I have a .pem file and to assign it to ssl_ca_file where do I need to place it in my app? And what is ssl_ciphers ? From where do I get that value?

The ssl_ca_file is just a filename. You should place the CA file somewhere on your filesystem and then pass rest-client the path to it.
I would not set ssl_ciphers unless you know you need to. Closing this issue, as it is not a bug in rest-client.


Reduce initial delay for keycloak deployment

This fixes #853

@lulf do you think that this can be merged?

@kornys I'll rebase it against master and see what the test results will be. I wasn't sure why the PR tests were failing at the time.


Referencing an array in the same ASDF file

I would like to save many ultra-high-resolution spectra to the same ASDF file. The total size of  all these spectra combined does not fit into my computer's memory, so I have to use a loop to incrementally update the tree:

asdf.open("myfile.asdf", mode="rw")
add the wavelength and the flux arrays to the tree
update()
close()

However, many (but not all) of the wavelength arrays are exactly the same, so in these cases I would prefer that it's stored only once, and refer to that array where possible. I only see one way to create references and that is with make_reference(). However, the docs mention that the function is designed to assign a reference to another tree. Should I also be using make_reference() to make a reference in the same tree, or is there a better way?

The last release makes this easy so long as the underlying array is exactly the same object (i.e., not copies of the same array). But if you look at PR #777 you will see that one of the new features is the automatic recognition of identical objects and the use of YAML references to indicate that in the YAML. This is part of ASDF v2.6 (is that what you are using?). Your case could be more complicated in that you are adding these over time through the update method and we'll have to check if references are handled properly in that case. Could you check that you are using exactly the same array object?

I updated to v2.6, and it seems to work as expected. Thanks for the info, it's a nice feature!


Add check recordType XML element exists before referencing text

Certain objects in Salesforce profile XML schema are not required to have a recordType child element of layoutAssignment node.  This fix prevents an exception being thrown when updating orgs with these objects in the profile metadata.

@jstvz I've reviewed this change, tested it locally, and implemented with @rtoepferveruna in a repo with active CI builds using CumulusCI. I can't see any risk to adding it as it current would be throwing an exception for anyone hitting the issue.


P417 missing comma

The very beginning of P417 missing a comma after "configBlocks":
_invokeQueue: invokeQueue,
_configBlocks: configBlocks
_runBlocks: []
};

Fixed, thanks


How to get wrist & palm data from Aria Everyday Activities dataset

Hi,
The MPS sample data from the Project Aria tools comes with a CSV for hand tracking. Is it possible to get hand tracking (i.e. wrist and palm location)for the Aria Everyday Activities dataset?

Hi @JoaoM07, thanks for your question and your interest in the Aria Everyday Activities dataset! Hand tracking is a relatively new output from MPS so it was not generated at the time we released AEA. We have added this feature request to our queue, and we can inform you when/if it becomes available. In the meantime, if you have an Aria Research Kit, you can generate your own MPS results (including wrist and palm data) using our CLI or on-demand service. If you do not, you can apply here: https://www.projectaria.com/research-kit/.

@JoaoM07 closing this task but please feel free to re-open if you have any additional comments or questions!


Add Lens tls.enabled option

Hi! I'm not a Ruby developer, but I gave this a whirl.
Motivation: Ingress into our cluster passes through a load balancer that handles https off-loading / termination (before reaching Traefik).
I'm not familiar with how to test this, but it should be most of the way there. :-)

Good job, considering you are not a Ruby developer! Thanks
Couple of changes I would propose:
How about if introducing method tls_enabled? instead of set_defaults
def tls_enabled?
  config.tls&.enabled != false
end

It can be passed to manifest templates on apply_resources:
apply_resources(
  host: host,
  email: config.tls&.email,
  tls_enabled: tls_enabled?,
  user_management: user_management_enabled?
)

and resolving protocol would be more straight-forward too:
protocol =  !tls_enabled? || config.tls&.email ? 'http' : 'https' # with cert-manager we have to use http since tls secret is not in place immediately

And in manifest files it would be more readable to, for example (12-ingress.yml.erb):
<%- if tls_enabled -%>
  tls:
    - hosts:
      - <%= host %>
      <% if email %>
      secretName: kontena-lens-tls
      <% end %>
<%- end -%>

Note: <%- #code -%> ignores new lines after the ruby block, which is handy when manipulating YAML files.
To test modifications and running pharos up command from the source code, you can use:
PHAROS_NON_OSS=true bundle exec ./bin/pharos-cluster up

(you must execute bundle install before first run)
OR just ping me and I can test this out.

Awesome, thanks! Tested and working. 😄

Please let me know what I can do to help get this in faster.
I can't see the build failure reason, is there something I need to address? Thanks!

@Timer needs conflict resolving.

Now since we are not polling dashboard readiness anymore I think we can just use protocol in post-install message:
    protocol = !tls_enabled? 'http' : 'https'
    message = "Kontena Lens is running at: " + pastel.cyan("#{protocol}://#{host}")

AFAIK this is ready to go, correct?

Yes, looking good!


Add artifactory_catalog_connector

What changes were proposed in this pull request?

Adds a catalog connector for Artifactory
See component-catalog-connectors/artifactory-connector/README.md for information about usage
Screenshot:

How was this pull request tested?

The connector has been tested using a real-world Artifactory repo

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC or @akchinSTC, this PR adds the ability to store components in Artifactory repos.
I am not sure if its best suited as an example (in this repo), or as a part of the core Elyra.

I haven't had a chance to review the implementation in detail, but glancing over the files this looks good!
Timing is a bit unfortunate though, because we've just changed the connector API. Those changes are minor but required, since the old API is marked as deprecated in the upcoming release and support will be removed  in the 4.0 release. I'll add comments to indicate what those changes are. (We went through this with the core connectors, e.g. https://github.com/elyra-ai/elyra/pull/2520 and https://github.com/elyra-ai/elyra/pull/2518)

I am not sure if its best suited as an example (in this repo), or as a part of the core Elyra.

We've discussed this in our daily dev meeting this morning. You have two options:
Contribute the connector to https://github.com/elyra-ai/elyra
If you agree to maintain the connector going forward, this would be our preferred option. This would result in a couple additional TODO items:

some (minor) 'packaging' rework would be required to take advantage of the native integration with Elyra
the pipeline components documentation would require updates
some basic automated unit tests would need to be added similar to what we have included for the updated Airflow connectors in  https://github.com/elyra-ai/elyra/pull/2520

Publish the connector in any third-party github organization
Since non-core connectors are provided as-is, no additional work (aside from accommodating  the API changes and moving this to another repository) would be required.

@ptitzler I think Elyra should be careful about including packages that connect to external systems in the core libraries, as this means updates/fixes are then only pushed in new Elyra versions. (Airflow recently went the opposite direction, and has split all the old operators into "providers" which are versioned separately)
But in this specific case (given how prolific Artifactory is) it probably makes sense to include the connector upstream, but I will leave this decision up to you. I am happy to help maintain it, but I somewhat doubt there will be significant changes, as this connector is using Artifactory APIs that haven't changed in over 12 years!
What should I do to get this merged upstream (feel free to just steal the code if you can make the PR faster).

I expect that if we include Artifactory and GitHub connectors upstream, they will make up  > 90% of Elyra component catalogs. (NOTE: A GitHub connector would explore a repo for component YAML, and return them using the raw.githubusercontent.com/xxxx URL)

Just for reference: built-in connectors are currently located several locations:

Generic connectors: https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline (catalog_connector.py)
Airflow specific connectors: https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline/airflow
KFP specific core connectors: https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline/kfp (there are none today)

Even though the proposed connector implementation is KFP specific, it should be treated as a generic connector because the underlying catalog is not runtime specific. If we were to continue using the current file system layout, the source code would need to be moved to a subdirectory in https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline.

These should be a complete list of  'migration' steps. The Airflow links are included for illustrative purposes and reflect what was done for https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline/airflow/provider_package_catalog_connector when that connector was migrated:

[ ] Add two entrypoints (one for the schema, one for the connector implementation) to Elyra's setup.py:

https://github.com/elyra-ai/elyra/blob/master/setup.py#L140
https://github.com/elyra-ai/elyra/blob/master/setup.py#L153

[ ] Add the schema JSON file to Elyra's MANIFEST.in:

https://github.com/elyra-ai/elyra/blob/master/MANIFEST.in#L49

[ ] Create a artifactory_connector directory in https://github.com/elyra-ai/elyra/tree/master/elyra/pipeline

[ ]  Move the content of https://github.com/thesuperzapper/elyra-examples/tree/artifactory-connector/component-catalog-connectors/artifactory-connector/artifactory_catalog_connector into the newly created directory

[ ] Move https://github.com/thesuperzapper/elyra-examples/blob/artifactory-connector/component-catalog-connectors/artifactory-connector/README.md to the new artifactory_connector and update (most information currently in the README is not applicable to built-in connectors --> https://github.com/elyra-ai/elyra/blob/master/elyra/pipeline/airflow/provider_package_catalog_connector/README.md)

[ ] Update the content of https://github.com/thesuperzapper/elyra-examples/blob/artifactory-connector/component-catalog-connectors/artifactory-connector/artifactory_catalog_connector/artifactory-catalog.json to reflect above changes

e.g. https://github.com/thesuperzapper/elyra-examples/blob/artifactory-connector/component-catalog-connectors/artifactory-connector/artifactory_catalog_connector/artifactory-catalog.json#L3, https://github.com/thesuperzapper/elyra-examples/blob/artifactory-connector/component-catalog-connectors/artifactory-connector/artifactory_catalog_connector/artifactory-catalog.json#L12, ...

@ptitzler sorry about the long delay, but this is ready to merge now.
I have migrated to the new Elyra 3.7 API for component catalogs, and added LOTS of unit tests!
PS: this is probably stable enough to go into upstream Elyra, but it is fairly specific to Artifactory so may not be widely used. Either way, to get this out there, let's release it under this repo initially.
PSS: we can probably use the same approach as this connector for a possible GitHub connector (see https://github.com/elyra-ai/elyra/issues/2139)

Overall the functionality, documentation, and tests look good!

Does this support Artifactory https Urls with PKI / public key infrastructure for https that included non-publicly trusted CAs? I am having this question also with regards to downloading components from a wheel file that is stored in Artifactory.

@ptitzler I have addressed the outstanding issues you raised, can you take a quick look and see if we can finally get this merged!

It's now live at https://pypi.org/project/elyra-artifactory-catalog-connector/0.1.0/. If you provide me with your PyPI user ID I'll add you as a maintainer.

@ptitzler its the same as my github thesuperzapper


Review the code for potential thread safety problems

(Note: The actual contents of this issue is written "as if" it referred to a single function of a single class. It does not. There certainly are many places where a review with the appropriate scrutiny would uncover potential race conditions. I'm just using one class and one function as an example here. These "general considerations" will have to be broken down into individual issues that can be addressed via dedicated PRs)
There have been reports of occasional crashes in cesium-unreal, and the term "occasional" always means that there is some threading issue behind that. (Well, maybe not always. But occasionally...). As an example, some of the traces pointed to CreditSystem::createCredit. This is currently implemented as
Credit CreditSystem::createCredit(const std::string& html) {
  // if this credit already exists, return a Credit handle to it
  for (size_t id = 0; id < _credits.size(); ++id) {
    if (_credits[id].html == html) {
      return Credit(id);
    }
  }

  // this is a new credit so add it to _credits
  _credits.push_back({html, -1});

  // return a Credit handle to the newly created entry
  return Credit(_credits.size() - 1);
}

which iterates over a vector and may modify that same vector, so clearly is not thread safe. But looking at possible "call trees" leading to that function, one can see one call to that function in Tileset.cpp with:
this->_externals.pAssetAccessor->requestAsset(this->_asyncSystem, ionUrl)
  .thenInMainThread([this](std::shared_ptr<IAssetRequest>&& pRequest) {
    this->_handleAssetResponse(std::move(pRequest));
  })

via
void Tileset::_handleAssetResponse(std::shared_ptr<IAssetRequest>&& pRequest) {
    ...
      this->_tilesetCredits.push_back(
          this->_externals.pCreditSystem->createCredit(
          html->value.GetString()));

and one call from BingMapsRasterOverlay.cpp with
Future<std::unique_ptr<RasterOverlayTileProvider>>
BingMapsRasterOverlay::createTileProvider(
  ...
  ) {
  ...
  return pAssetAccessor->requestAsset(asyncSystem, metadataUrl)
      .thenInWorkerThread(
      [ ... ](std::shared_ptr<IAssetRequest> pRequest)
          -> std::unique_ptr<RasterOverlayTileProvider> {
        ...
          credits.push_back(
              {pCreditSystem->createCredit(
               creditString->value.GetString()),
               coverageAreas});

and from a very quick glance, this looks like the function is once called via thenInMainThread and once via thenInWorkerThread.
This specific issue can probably be solved easily: Wrapping the work of createCredit into some mutex, and explicitly adding a /** This function can be called from any thread */ hint in the docs.
But more generally, we should allocate some time for examining the functions that may be called from multiple threads, review their actual call sites, and maybe try to more diligently add prominent comments like /* May only be called from thread X*/ or /* May be called from any thread */.

Good analysis Marco, that definitely looks like a true race condition to me. And auditing for other similar cases is definitely worthwhile.

One could argue that this particular case is unlikely to be the reason for the crashes in the linked issue (I think there was no BingMaps involved). But this was only an example to show that there definitely are cases where such functions are called from multiple threads. Looking at the call sites and "going up" the call tree, until the calling thread is known, may bring some insights.
More specifically: I assume that the credit system should be thread safe (with some mutex here and there). In other cases, the issue might be causes by some resource (that is not supposed to be thread safe) being used by "the wrong" thread accidentally.

I assume that the credit system should be thread safe

Yep, similar to the other interfaces like IAssetAccessor. I think it will be ok performance-wise to just put all of createCredit in a mutex, though it's definitely possible (but not easy) to do less locking if it ever becomes a hotspot.
It probably doesn't affect the solution at all, but just for background and context... the createCredit call in _handleAssetResponse probably can't race with any of the others, because it will complete before any other tiles are downloaded and therefore before any other credits are created. But multiple raster overlay tiles can and will be loaded simultaneously, so the createCredit in BingMapsRasterOverlay::createTileProvider will race with itself and with other similar work happening in a worker thread.

The specific case mentioned in this issue was fixed in #232, and our threading policy (no instances can be shared between threads unless the type's documentation explicitly says otherwise + don't pass non-thread-safe objects to work threads at all) is doing a decent job of avoid race conditions. We need to be constantly vigilante of course, but I don't think there's any particular action for this issue, so I'm closing it.