[$1000] Clicking the Delete key doesn't remove number from magic code input field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to sign in page and input email
Input numbers in Magic code input fields
Click "Backspace" and notice it removes number
Click "Delete" key

Expected Result:
Delete key should also remove the number inside of the input field
Actual Result:
Hitting the Delete key doesn't remove number from the input field
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.9-16
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/236055847-5089da8b-b8d6-43b2-9cc4-d21e1a007cb7.mp4
https://user-images.githubusercontent.com/43996225/236055868-f35176a5-cc6d-47da-a643-dd7d91fd6aa4.mp4
Expensify/Expensify Issue URL:
Issue reported by: @nathan-mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683099279280519
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b408cfdd33e4ef34
Upwork Job ID:<PHONE_NUMBER>044697600
Last Price Increase: 2023-05-13

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I'll test this one soon.

I've run out of time this week; I will test over the weekend to continue the process.

No update

I need to verify with the team if onscreen keyboards are common practice.

Hey @alexpensify , the on-screen keyboard is just to show the steps for testing. This issue is present when user clicks "delete" key on a normal physical keyboard.

Thanks for clarifying, I'll test again soon.

Alright, as an alternative to step 4, I was able to replicate the experience by clicking Control D to act as the Delete button. In short, it appears that only the Mac Delete key deletes the Magic Code. I'll need to start a discussion with the team about this one.

After thinking about this more, let's address this problem because some people might use the control functions on their keyboard. I've assigned external.

Waiting for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking the Delete key doesn't remove number from magic code input field
What is the root cause of that problem?
Condition for KeyValue === 'Delete' is not handled in onKeyPress.
https://github.com/Expensify/App/blob/293f23b57be2bca3f3eb0af903d5e0c2894cb36a/src/components/MagicCodeInput.js#L201
What changes do you think we should make in order to solve the problem?
Add a condition for KeyValue === 'Delete' in onKeyPress.
With this implementation, the Delete key removes the value at focusedIndex if it is not empty already. If the focused index is already empty, it removes the focusedIndex + 1 till it reaches CONST.MAGIC_CODE_LENGTH -1 index. This enables the standard Delete behaviour in magic code input field.
https://github.com/Expensify/App/assets/24949760/35764fcd-cfd3-481c-8269-e4741dba4139
I have this working on MacOS / Chrome / Safari, I'll be testing this on other platforms. I've attached the video snippet to demonstrate the behaviour.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/harjotsingh30

Lovely @HarjotSingh8! Try to write less of a code in the proposals in future.
@mananjadhav What do you think of the proposal?

it will be inconsistent with normal delete behaviour never the less becasue normally the content shifts to the same place when you use delete
Could you potentially check how Slack handles it? @HarjotSingh8

I can see that too, I am on a fence. @alexpensify @mananjadhav what do you think, should we implement this?

@mountiny - I've been on the fence on this one too. My notes are here and here. If you think we should not fix it, then let's see what @mananjadhav has to say as a deciding vote.

I ma more inclined to not fixing this, feels like we will be adding more complexity to this flow than needed, curious for @mananjadhav

Thats quite dumb approach I agree

Ok I think this is just more complicated and confusing than if the del does nothing.
I would advice to close this out and pay $100 to @HarjotSingh8 and @hoangzinh for working on this, it was our fault we added the HelpWanted label, do you agree @alexpensify ?

I just came online and yeah I agree it's not worth fixing. We've been down the road earlier, and DEL handling for such inputs can lead to a lot more complexities and bad user experience.

ok @alexpensify  le tme know what you think of the partial reward here for the efforts and closing out

I've started the payment process in Upwork for @hoangzinh and @HarjotSingh8. Please accept and I can complete the process. Thanks!

Alright, @hoangzinh and @HarjotSingh8 - thank you for your understanding here. I've closed the job and issued these rewards via Upwork. I'm closing this GitHub to avoid future confusion.


"Followed Users Only" control is no longer available in Following Feed Preferences. Regression or just moved?

In an earlier version of the web/mobile apps, Home Feed Preferences included an option to only show replies between users that you follow.

(screenshot taken from #1762 )
This control no longer appears to be available, and we've seemingly reverted to the original options: all or nothing.

(screenshot from web app. mobile app is identical.)
I've looked around in other preference windows, and I just cannot find it anywhere. What's happened?

I've since been informed (by @surfdude29 in #1762) that this was an intentional change.
Context: https://bsky.app/profile/bsky.app/post/3l2s5vdthls2h

Because we changed the way that replies show in Following, we simplified the Following Feed preferences to no longer have a "Followed users only" toggle and to no longer have a "number of likes" filter.

 Cannot understand why these options would be removed, especially after they were requested by a pretty decent number of users last year.


Update README.md

Add Rop wargames

@dogrocker Thanks for the PR. The list has to be in alphabetical order, so the build failed. See here for more information on build. Can you fix the order and update the PR?

OK. I reordered, Sorry for that :).

Thanks, this has landed into master.


Issue when downloading site contents

Hi. There seems to be a problem when you have a lot of content to download. I had a 254 MB download which took around 931 seconds to successfully download and then all downloads after this failed with a similar error to the one below.
This may be because my login is timing out, but for a site with a lot of content, this may prove difficult.
This may be due to my rest api session timing out (my organisation wants session timeout set at 10 minutes, no arguments) but I was thinking that what I may attempt is to add a Sign Out Class and sign out after every download, and sign back in before every download. Wasteful and tedious, I know, but worth a shot?
000,  19/05/2016 20:06:04, Download failed after .6 seconds. https://MYTABURL/api/2.2/sites/d00944ca-80c8-4cd9-a69f-8b46009c4e96/datasources/f70dc130-0914-11e5-805f-03397faea0ed/content
001,  19/05/2016 20:06:04, Error during Datasource download Discovery SPARRA Lowest Level
  https://MYTABURL/api/2.2/sites/d00944ca-80c8-4cd9-a69f-8b46009c4e96/datasources/f70dc130-0914-11e5-805f-03397faea0ed/content
  System.Net.WebException: The remote server returned an error: (401) Unauthorized.
   at TableauServerSignedInRequestBase.DownloadFile(String urlDownload, String downloadToDirectory, String baseFilename, DownloadPayloadTypeHelper downloadTypeMapper) in C:\Users\graham01\Documents\Visual Studio 2015\Projects\TabMigrate-master\TabRESTMigrate\RESTHelpers\TableauServerSignedInRequestBase.cs:line 52
   at DownloadDatasources.ExecuteRequest() in C:\Users\graham01\Documents\Visual Studio 2015\Projects\TabMigrate-master\TabRESTMigrate\RESTRequests\DownloadDatasources.cs:line 87

Just for a bit more info, I upped the wgserver.session.idle_limit to 60 minutes and the issue does go away, but because we need a 10 minute idle time out in our organisation, this doesn't really rectify the problem. I'm in the process of trying to implement a logout class and will report back if it works.
As a further update, it seems to be a result of downloading lots of data sources from a project, not just a single large data source. If you start downloading 50 data sources from a project, and from the first to the last takes longer than your idle timeout setting on the server, subsequent datasources will fail to download after the timeout ocurrs because your session has exired due to inactivity.

Just for a bit more info, I upped the wgserver.session.idle_limit to 60 minutes and the issue does go away, but because we need a 10 minute idle time out in our organisation, this doesn't really rectify the problem. I'm in the process of trying to implement a logout class and will report back if it works.

This is an interesting problem.  I will log this as an issue for our Tableau Server API team, but I suspect a fix is non-trivial.  What I suspect is happening:

Your file download for a specific *.twbx is taking a long time (e.g. 15+ minutes).
Unlike uploads (which are sent in small/mid-sized chunks), downloads come as a HTTP request/response.  – Thus they are dependent on the speed of your local network, the server, and the client, which have to move all this data in 1 http request/response cycle.
If the single download request/response exceeds you session timeout, the session will expire.  Thus subsequent requests will fail since the session is no longer active.
A work around:  During the download, if you had a separate thread that made simple REST API requests at a frequency below the timeout threshold, this would likely keep the Tableau Server session alive.  – There should be no problem with parallel requests (the download, and the keep alive) occurring at the same time. – If desired, I can look at adding this kind of background keep-alive into the TabMigrare tool.

Hi Ivo. I agree, that sounds like they likely cause. I like the parallel thread solution to keep the session alive. I may just set up a request to query sites but limit this to 1 item per request to keep the size small. Thanks for the suggestion. I'll try that this weekend.

Hi there,
Take a look at v1.05.  I just added a “keep alive” checkbox in the export site.  This makes a request every 2 minutes.
From: graham-macleod<EMAIL_ADDRESS>Sent: Friday, June 17, 2016 12:28 PM
To: tableau/TabMigrate<EMAIL_ADDRESS>Cc: Ivo Salmre<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [tableau/TabMigrate] Issue when downloading site contents (#3)
Closed #3https://github.com/tableau/TabMigrate/issues/3.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/tableau/TabMigrate/issues/3#event-696365153, or mute the threadhttps://github.com/notifications/unsubscribe/ANVziLZcJVz0RLAGhyqWOhSmm7iTz_oKks5qMvU1gaJpZM4IilQT.

(v1.06 -- made one more subtle fix the encoding of messages sent to server)


Ability to specify base_url

I really appreciate your work on this wrapper!  I am writing a Python program and I hope to use it in the near future.  Currently, I'm self hosting Piston, however the Client does not allow for me to specify a base_url.  I don't think it would be too hard to add an optional parameter to the PystonClient to set base_url.
Here's the line where the public API is hard coded:  https://github.com/ffaanngg/pyston/blob/ca2a88eea730acdf13f44023e97566ca07f96345/pyston/client.py#L116

I have updated the package.
The base url can be specified as a kwarg called base_url when making an PystonClient instance.
Example:
client = PystonClient(base_url="custominstance.com/")

The package can be updated using pip install aiopyston --upgrade

Thank you!


show an error when i run  train_mineral_shards

show an error when i run  train_mineral_shards
File "C:\Anaconda3\lib\site-packages\pysc2\run_configs_init_.py", line 39, in get
if FLAGS.sc2_run_config is None:  # Find the highest priority as default.
File "C:\Anaconda3\lib\site-packages\absl\flags_flagvalues.py", line 491, in getattr
raise _exceptions.UnparsedFlagAccessError(error_message)
absl.flags._exceptions.UnparsedFlagAccessError: Trying to access flag --sc2_run_config before flags were parsed.

Yeah I just followed the tutorial and got this far as well.

If you are using PyCharm 2019.1 you need to downgrade to 2018.6.
Or just use powershell. 😂


Timecode.FromTimeSpan

Hi,
Is it possible to implement a constructor that take a TimeSpan ?
Regards.

  public static Timecode FromTimeSpan(TimeSpan ts, FrameRate frameRate, bool isDropFrame)
        {
            FrameRateSanityCheck(frameRate, isDropFrame);

            var tc = new Timecode(frameRate, isDropFrame)
            {
                TotalFrames = Convert.ToInt32(ts.TotalSeconds * frameRate.ToDouble())
            };
            tc.UpdateByTotalFrames();
            return tc;
        }

Thank you for your suggestion, I'm going to implement it soon.
PR is always welcome :)

Hi @ailen0ada and @dust63,
We've got some problem after this change. Test bellow doesn't pass.
[Fact]
public void RegressionTestForToTimeSpan()
{
	var expected = new TimeSpan(0, 0, 59, 58);
	var actual = Timecode.FromString("00:59:58:00", FrameRate.msec, false).ToTimeSpan();
	Assert.Equal(expected, actual);
}

That change https://github.com/ailen0ada/Timecode4net/commit/c913c1cedcb40c175f19d977616f2e62331fd05c#diff-490f15db8b3504ae544a30b594d702a7L100 isn't clear for me.


Make Written Off payments not count as open payments in BDI

Currently NPSP Batch Data Import will match to written off payments while matching donations.
In #4282 we've got the front end work done to exclude written off payments from donation matching - basically, not considering written off payments as open payments.

**lurch: attach W-034100

Tracking W-034100

Included in beta release 3.160 (Beta 3)

Included in production release 3.160


Distinct referenced commits style

Before

Before (with explanation of the problem)
Confusing, looks like the pull request commits and the commit that references this pull request are in the same branch.

After

Style
.discussion-item-header[id^=ref-] .discussion-item-icon {
  background-color: #6db2ff;
  color: #ffffff;
}

.discussion-item-header[id^=ref-]::before {
  content: '';
  position: absolute;
  display: block;
  z-index: -1;
  left: -25px;
  top: -40px;
  width: 2px;
  height: 140px;
  background-color: #ffffff;
}

.discussion-item-header[id^=ref-commit-] + .discussion-item-body .timeline-commits .commit .commit-icon {
  color: #6db2ff;
}

.discussion-item-header {
  position: relative;
}

.discussion-item-header[id^=ref-commit-]::after {
  content: '';
  position: absolute;
  display: block;
  z-index: 0;
  left: -25px;
  top: 30px;
  bottom: -20px;
  width: 2px;
  background-color: #6db2ff;
}

.discussion-item-header[id^=ref-commit-] + .discussion-item-body .timeline-commits {
  position: relative;
}

https://gist.github.com/sompylasar/99b5d307da3168b833c1119fb95caf11

Yeah, this is a good improvement. PR welcome :)
Please also suggest the improvement to GitHub: github.com/contact

@sindresorhus do we want to add this CSS straight in or hide it behind a RGH class so it can be toggled off?
@sompylasar do you want to open a PR?

@busches I would say just plain CSS. The change is uncontroversial and I don't see why anyone would genuinely need to disable it.

@busches Thanks for asking! I currently don't have enough time to do a proper PR and test it, please feel free to copy and adapt the code I shared. I think this feature should be disableable as any other refined github feature because it has its quirks due to how GitHub markup is currently structured.

@busches Can I take this one? This would be my first issue here 😅

@dakshshah96 have at it.

@sompylasar where did you get that blue color from? It's nice and we can probably have it as a CSS variable

@bfred-it

@sompylasar where did you get that blue color from? It's nice and we can probably have it as a CSS variable

It was a long time ago but I think I just played with the color picker.

Let's only drop the commit icon and possibly drop the bigger "bookmark" icon to deemphasize it even more.

I see the vertical line as a timeline, this can contain commits, but also comments and also references. The reference contains a description and the commit where reference happened. My suggestion would be to combine them by removing the commit icon. Now it's just one reference.
First one has the commit icon removed:

The same is already done when referencing PR:

CSS:
.discussion-item-header[id^='ref-commit-'] + .discussion-item-body .timeline-commits .commit .commit-icon {
	visibility: hidden;
}

This is really annoying. I sent another request at https://github.com/contact

Commit references in PR are very confusing
Open this: https://github.com/sindresorhus/refined-github/pull/2167/#ref-commit-7d6e4d1
Can you tell which commits are part of the current PR and which aren't?
Answer: only the merge commit is, but there's no way to tell.
Please display commits with PR references differently in PRs.
More context: https://github.com/sindresorhus/refined-github/issues/1579


[ASCII-2536] remove subscribers functionality from remote tagger

What does this PR do?
Removes subscriber functionality from the remote tagger and their dependencies
The subscribe method is called in the tagger server, which is only use for core Agent that runs the local tagger
https://github.com/DataDog/datadog-agent/blob/043922b67eb043ad69e26bb889890d2bd8a95f5d/comp/core/tagger/server/server.go#L61
Motivation
Continue reducing the size of the remote tagger
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


--help --version should stop completion

Environment:

Python version: 3.10.5
Click version: 8.1.3

https://github.com/psf/black/issues/1576#issuecomment-1228801355
Expected behaviour:
❯ black --help <TAB>
no more arguments

Actual:
❯ black --help --<TAB>
unsorted
--code                        Format the code passed in as a string.
--line-length                 How many characters per line to allow.
--target-version              Python versions that should be supported by Black's output. [default: per-file auto-detection]
--pyi                         Format all input files like typing stubs regardless of file extension (useful when piping source on standard input).

This is not possible due to the very dynamic nature of Click. --help and --version aren't fixed names, and any callback, not just those two, could potentially terminate processing early. The parser (and completer) only know about the tokens, not what those tokens might do.
There's nothing inherently wrong about typing more things after an option that ends processing. This is not something I plan to address.


Add key generation support to nv2

The nv2 binary doesn't currently have a way to generate a key pair for signing which makes it harder than it needs to be for new users to use nv2. Please add a subcommand that generates a keypair.
I suggest nv2 keygen as a subcommand. At a minimum, it needs to perform the functional equivalent of the following as mentioned here.
openssl req \
  -x509 \
  -sha256 \
  -nodes \
  -newkey rsa:2048 \
  -days 365 \
  -subj "/CN=${REGISTRY}/O=wabbit-networks inc/C=US/ST=Washington/L=Seattle" \
  -addext "subjectAltName=DNS:${REGISTRY}" \
  -keyout ./wabbit-networks.key \
  -out ./wabbit-networks.crt

big 👍

We might also want to put the keypair in a default location like ~/.notary/keys/ for example so that it can be picked up as a default for other commands for example.
docker notary sign \
  --key ./wabbit-networks.key \
  --cert ./wabbit-networks.crt \
  $IMAGE

I would expect that the command could be simplified to docker notary sign $IMAGE

to be more generic, we might want to keep with nv2 sign, which could reference any artifact (image, sbom, wasm, scan result)

It's worth calling out that this openssl command does not generate a key, it generates a certificate (which contains a key). If the certificate is self-signed like it is in this case, there's not much value in having it over just a keypair, which can come from something like:
openssl genrsa -out myprivate.pem 512

for the private key and
openssl pkcs8 -topk8 -in myprivate.pem  -nocrypt'

for the public key.
I'm not sure about this line:

-addext "subjectAltName=DNS:${REGISTRY}" \

It seems to put the registry itself into the cert as a SAN field. I'm not sure how this could be used. What's the trust model/use-case for someone to check this value in the cert?

-nodes \

This like means the private key will not be encrypted at all, meaning it may not be safe to store on disk.


podman -  XDG_RUNTIME_DIR directory "/mnt/wslg/runtime-dir" is not owned by the current user

Windows Version
Microsoft Windows [Version 10.0.19045.4291]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 24.04
Other Software
podman 4.9.3+ds1-1build2
Repro Steps
install Ubuntu 24.04 - wsl --install Ubuntu-24.04
basic setup: username/password, proxy in .bashrc and /etc/apt/apt.conf.d/01proxy
DNS - disable automatically generated by WSL and setup resolve.conf manually
update system: sudo apt update -y && sudo apt upgrade -y
install podman: sudo apt -y install podman
run podman info: podman info
test podman run
Expected Behavior
podman info should show relevant information and work as expected
Actual Behavior
$ podman info
ERRO[0000] XDG_RUNTIME_DIR directory "/mnt/wslg/runtime-dir" is not owned by the current user
$
$ podman run hello-world
ERRO[0000] XDG_RUNTIME_DIR directory "/mnt/wslg/runtime-dir" is not owned by the current user
Diagnostic Logs
No response

Thank you, this is a known issue with ubuntu 24.04, because there's already a UID=1000 before the WSL user is created, so the WSL user gets a different UID, which breaks wslg's expectation and leads to errors like the one you're seeing.
We've contacted the distribution maintainer to see if the UID can be fixed from their end

Seems there is an default "ubuntu" user with Ubuntu-24.04 with id 1000, user created with installation have id 1002.
$ id 1000 uid=1000(ubuntu) gid=1001(ubuntu) groups=1001(ubuntu),4(adm),24(cdrom),27(sudo),30(dip),1000(lxd)
if i switch to that user i could run podman info, but this is not expected
$ sudo -i
# su - ubuntu
$ podman info
WARN[0000] "/" is not a shared mount, this could cause issues or missing mounts with rootless containers
host:
  arch: amd64
  buildahVersion: 1.33.5
  cgroupControllers: []
  cgroupManager: cgroupfs
  cgroupVersion: v1
...
version:
  APIVersion: 4.9.3
  Built: 0
  BuiltTime: Thu Jan  1 01:00:00 1970
  GitCommit: ""
  GoVersion: go1.22.1
  Os: linux
  OsArch: linux/amd64
  Version: 4.9.3
$

As a workaround you can install Ubuntu not from the Microsoft Store, but via wsl --import and get the image archive from here: https://cloud-images.ubuntu.com/wsl/
This way there is no prompt for creation of a new user. Note that things like Windows Terminal profile won't be added automatically.

Seems there is an default "ubuntu" user with Ubuntu-24.04 with id 1000, user created with installation have id 1002. $ id 1000 uid=1000(ubuntu) gid=1001(ubuntu) groups=1001(ubuntu),4(adm),24(cdrom),27(sudo),30(dip),1000(lxd)
if i switch to that user i could run podman info, but this is not expected
$ sudo -i
# su - ubuntu
$ podman info
WARN[0000] "/" is not a shared mount, this could cause issues or missing mounts with rootless containers
host:
  arch: amd64
  buildahVersion: 1.33.5
  cgroupControllers: []
  cgroupManager: cgroupfs
  cgroupVersion: v1
...
version:
  APIVersion: 4.9.3
  Built: 0
  BuiltTime: Thu Jan  1 01:00:00 1970
  GitCommit: ""
  GoVersion: go1.22.1
  Os: linux
  OsArch: linux/amd64
  Version: 4.9.3
$

This might be why I have a command entry in my /etc/wsl.conf
[boot]
systemd=true
command = mount --make-rshared /

I think this is also related to #10473, #10498, and #9689.

Would be interested to have news for this ? I've just installed new Ubuntu 24.04 from scratch and I got issue like that for other tools :(

I beleive its resolved in latest version. you will need to update wsl and reinstall ubuntu24
wsl --update --pre-release
wsl --install

I updated WSL to 2.3.21 and re-installed Ubuntu-24.04 and I still have the issue. UID 1000 is preallocated to the ubuntu user.

@tusharsnx

I updated WSL to 2.3.21 and re-installed Ubuntu-24.04 and I still have the issue. UID 1000 is preallocated to the ubuntu user.

You might have an old image.
I just imported noble/20240917, and it doesn't have the pre-allocated user; I could not quickly find a changelog mentioning it.
https://cloud-images.ubuntu.com/wsl/

@Stelminator I guess I have to wait until they release a new update to the store/release-channel. The current version is still broken.

For me it works now with 24.04.1 LTS, and user created with installation below have id=1000. I did not checked rootfs images as this is more preferable way on our side, but seems this was fixe as of Juni 2024.
wsl --list --online
wsl --install -d Ubuntu-24.04

Any way to avoid reinstalling Ubuntu ?

@salcinad Thanks. It now works for me too. I just had to --unregister (before uninstalling Ubuntu-24.04) to get it working.


⚠ Bofrost.at has degraded performance

In 5e9e1ed, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 928 ms

Resolved: Bofrost.at performance has improved in f295b52.


show all when no search term is entered

like the finder and file explorer

Do you mean, on startup?  I've added this in the latest code and will be available in the next release (with Sorting and Albums and Folders)

I mean when no text is entered in the field, which happens at startup but also when i delete the search field

This is how it works currently. If you delete the search field and press enter, it will show all.

Ah that's not the default when the app launches and it requires enter which I'm not used to anymore.


IWBootStrap and cgdevtools Grid

Hi,
I'm working with delphi 10 Seattle. I've an intraweb application with iwbootstrap. I want to link a iwcgjqgrid into the project but I can't have bootstrap style in my grid.
What can I do to have it?
Thanks by advance

Desculpe amigo, eu não uso esses componentes.
Em 05/04/2016 06:20, TiteLive escreveu:

Hi,
I'm working with delphi 10 Seattle. I've an intraweb application with
iwbootstrap. I want to link a iwcgjqgrid into the project but I can't
have bootstrap style in my grid.
What can I do to have it?
Thanks by advance
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/kattunga/IWBootstrapFramework/issues/25

Hi, this is a CgDevTools issue, not an IWBootstrap issue.
jqGrid support bootstrap styles from version 5.0.
Take a look to IWBootStrap demo, there an example with jqGrid 5.0.
I think that iwcgjqgrid is using an older jqGrid version.
You should ask about this in CgDevTools forum.
Regards


[cinder-csi-plugin] Refactor csi-cinder to improve code climate

What this PR does / why we need it:
Refactor cinder-csi-plugin to make golangci-lint happy.
Which issue this PR fixes(if applicable):
Relates to #1883
Special notes for reviewers:

Release note:

NONE

/lgtm

/approve

/retest

/test openstack-cloud-csi-cinder-e2e-test

/lgtm


Add simple bare metal debugging

Anubis is a pretty large system, so up until now the main debug environment has been through make debug which will launch a bunch of microservices in docker containers. This is proving to be too much for new contributes with MacOS and or Windows machines.  Whatever, rant for another day.
This PR should create a new dev environment for anubis called mindebug that should allow for native debugging. I can confirm that it works on linux (where everything just works). We just need confirmation it works on OSX and Win.

[x] Linux
[x] Windows
[ ] OSX

Can confirm this works on Windows.

OSX Works!


Add summary support in AddSpentTimeOptions

Goal
This PR is adding a summary field in the AddSpentTimeOptions structure.
This structure is used to call the add spent API endpoints for merge requests and issues.
Today we can only pass the duration of the time spent when calling gitlab API, however the 2 endpoints also accept a summary optional field (see merge request and issues).
Adding this new field in the structure will allow users to set a specific summary value while calling gitlab API.

Thank @airclovis and @svanharmelen.
We're relying on this library and were exactly looking for this feature. I saw the PR has been merged. @svanharmelen do you plan to push a new release anytime soon? 🙏

Tagged v0.93.1

Thank you for your prompt reaction!


Remove the name Rnnt from class names

The name Rnnt in the code is confusing. We are not using recurrent connections (i.e., RNN, GRU, LSTM) in our transducer models and we should  use transducer to replace Rnnt in the code.

OK.  If it spans across multiple codebases, e.g. icefall vs. k2, we may need to introduce aliases for compatibility.

OK.  If it spans across multiple codebases, e.g. icefall vs. k2, we may need to introduce aliases for compatibility.

I am mostly concerning with the code in sherpa. The changes would be implementation details and won't be visible to end users.


spago build appears to include the test directory of (local) dependencies

I'm getting a compilation error saying that Main has been defined multiple times and it's pointing at the test directory of my local dependencies.

No problem! 🙂

I had some existing local dependencies that I was converting to try out spago.
I ran spago init in the respective project directories to get spago.dhall and packages.dhall - but I didn't realise it also created a src/Main.purs file.

I have done this a few times too. It's no biggy, but maybe init with files shouldn't create a main.purs?.

Or, perhaps it should by default but there should be a flag to prevent
that.

Let's step back and consider the different reasons why this would be useful and annoying.
If one is migrating from psc-package to spago, then it's probable that the user already has their project structure set up correctly. They simply want to migrate to spago. Thus, adding a Main.purs file would be annoying to them.
If one is starting a new project via spago, then it would be nice if spago created all the necessary project structure: src and test folders and other spago-related files. Thus, adding a Main.purs file would be convenient and appreciated by them.
Others might want to use spago to write a library (as that can be done now via <IP_ADDRESS>, right?) but I don't think that's a common activity yet.
So, there are a few options here:

address all concerns in one command, init, with reasonable defaults and provide flags to customize it as needed for special situations
address the migration concern in a separate command (i.e. psc-package-migrate?) from the new project/library concern via the command, init

@JordanMartinez good points 👍
A small note first: the detection "can we migrate a psc-package file" doesn't happen specifically in the init, but every time Spago needs a spago.dhall, so this is not as clean-cut as I'd like it to be (the whole "is our configuration here" probably needs some refactoring)
Also I would like to keep the CLI-surface as small as possible, and I wouldn't like to add another command that does almost the same thing as init.
So there's a "fix" up in #105, I went with checking if src and test exist, and skipping the file copy if they do, so e.g. it would prevent what happened to @LiamGoodacre and @btrepp.
If one has sources in another folders it would still not be a problem, because they are not included by default in Spago (and here I wonder if the Config should have a setting for specifying the "source paths", since it's a common use-case)

Thanks for the clarification!
Yeah, keeping the CLI-surface small makes sense. I'd prefer that anyway.


SSTable entry TTL

Currently similar to RocksDB if an expiry doesn't hit time to expire before flush marking a tombstone, the key will still live in the flushed and compacted sstables.  To resolve this we can add TTL on the KeyValue struct and populate accordingly on flush, then check when we get the entry from a page.
type KV struct {
	Key   []byte // Binary array of key
	Value []byte // Binary array of keys value
	TTL  *time.Time // Time to live
}

Implemented here
https://github.com/guycipher/k4/commit/bdb2f9a78b0442740ed04f7bb36d8cb9c8f11073


Fix DefaultBlockWorker mistakenly commit block

What changes are proposed in this pull request?
Fix the race condition that the reader would try to commit the block belongs to the other writer when closeUfsBlock. More specifically it happens in code from line 158 in JobUtils.
Also cleanup the code
Why are the changes needed?
Does this PR introduce any user facing changes?

alluxio-bot, merge this please


Replace --hp-zone in README

Please replace --hp-zone with --hp-region and -Z with -R in the README to show the correct options.

We have deprecated knife-hp, please look into knife-openstack.


Component flicker

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
When switching page on client side, components with bounded props will flicker.
https://user-images.githubusercontent.com/5869244/192134835-f5d88595-78c2-46b2-ad0f-1df8b1aee35e.mov
Expected behavior 🤔
No response
Steps to reproduce 🕹
Steps:

Context 🔦
No response
Your environment 🌎
No response

fix:
function RenderedNodeContent({ node, childNodeGroups, Component }: RenderedNodeContentProps) {
  ...

  const nodeProps = (node as appDom.ElementNode).props as Record<string, unknown>;

  ...
      if (typeof hookResult[propName] === 'undefined') {
        if (
          nodeProps &&
          nodeProps[propName] &&
          (nodeProps[propName] as ConstantAttrValue<any>).type === 'const'
        ) {
          hookResult[propName] = (nodeProps[propName] as ConstantAttrValue<any>).value;
        } else if (argType) {
          hookResult[propName] = argType.defaultValue;
        }
      }
    }

 ...
}

@Janpot

@WangLarry Thank you for trying out Toolpad. Full transparency, I've been on holiday the past week and will be spending the following week in the mountains, so expect low input from my side. I will take a deeper look into these when I'm back in October.

Thank you so much for reporting this and suggestion a solution @WangLarry!
I've noticed this issue too, we'll definitely look into it and try out your suggestion - will keep you posted.

fix:
function RenderedNodeContent({ node, childNodeGroups, Component }: RenderedNodeContentProps) {
  ...

  const nodeProps = (node as appDom.ElementNode).props as Record<string, any>;
  const nodeLayout = (node as appDom.ElementNode).layout as Record<string, any>;
  ...
      if (typeof hookResult[propName] === 'undefined') {
        if (
          nodeProps &&
          nodeProps[propName] &&
          (nodeProps[propName] as ConstantAttrValue<any>).type === 'const'
        ) {
          hookResult[propName] = (nodeProps[propName] as ConstantAttrValue<any>).value;
        } else if (argType) {
          hookResult[propName] = argType.defaultValue;
        }
      }
    }

 ...
      if (typeof hookResult[propName] === 'undefined') {
        if (
          nodeLayout &&
          nodeLayout[propName] &&
          (nodeLayout[propName] as ConstantAttrValue<any>).type === 'const'
        ) {
          hookResult[propName] = (nodeLayout[propName] as ConstantAttrValue<any>).value;
        } else if (argType) {
          hookResult[propName] = argType.defaultValue;
        }
     }

 ...
}

2022-09-<IP_ADDRESS>.mov

Thanks you for reporting this issue and suggestion a solution, @WangLarry .
Your solution seems great to me and it fixes the issue, I've created a PR based on it at https://github.com/mui/mui-toolpad/pull/1061
Feel free to submit a PR directly next time. external contributions are always welcome!


policy issue when used with tf.exe even after copying the dll to the tf.exe location.

Hello,
this is in continuation about my previous issue. as you have told i have placed "ColinsALMCheckinPolicies.dll" in  C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE but still i get the same error as before.
Please see the screen shots. You can replicate on your local as well.
this is a production issue that we are facing.

Duplicate of #15

I'm asking the VSTS Team what they suggest. Can you double check that the versions are the same (that you're using tf.exe for VS 2015 - that seems to be the version of the extension that you're using).

Colin, the version of TF.exe is 14.102.25619.0

hello @colindembovsky any update on the issue.


Error C2338 in tensorflow/compiler/tf2xla/cpu_function_runtime.h(71)

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 64 bit
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): source
TensorFlow version: branch r1.13
Python version: Python 3.6.8 :: Anaconda, Inc.
Installed using virtualenv? pip? conda?: conda 4.6.8
Bazel version (if compiling from source): 0.21.0
GCC/Compiler version (if compiling from source): cl.exe C/C++ Optimizing Compiler Version 19.16.27026.1 for x64, Visual Studio Build Tools 2017
CUDA/cuDNN version: CUDA Toolkit V10.0.130, cuDNN 7.5.0
GPU model and memory: GTX 1060 6GB

Describe the problem
Got error C2338 while building tensorflow from r13.1 branch in this section of code
28    class BufferInfo {
29     public:

[...]

66      // Encodes this BufferInfo into two 64 bit integers that can be used to
67      // reconstruct the BufferInfo later using the constructor.  We need this
68      // because we use BufferInfo in places where using protocol buffers would
69      // negatively impact binary size.
70      std::pair<uint64, uint64> Encode() const {
71        static_assert(sizeof(*this) == 16, "");    <====
72        uint64 upper = Pack(kind(), size_);
73        uint64 lower = entry_param_number_;
74        return {upper, lower};
75      }

Provide the exact sequence of commands / steps that you executed before running into the problem
(tf_gpu) D:\Neural\tensorflow>python ./configure.py
ERROR: Failed to query DisplayName of HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\{4A656C6C-D24A-473F-9747-3A8D00907A04}
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
nul
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
INFO: Invocation ID: 083eb68f-20f4-4c71-8c8d-9b76a9b0d5cf
You have bazel 0.21.0- (@non-git) installed.
Please specify the location of python. [Default is D:\Programs\Anaconda3\envs\tf_gpu\python.exe]:

Found possible Python library paths:
  D:\Programs\Anaconda3\envs\tf_gpu\lib\site-packages
Please input the desired Python library path to use.  Default is [D:\Programs\Anaconda3\envs\tf_gpu\lib\site-packages]

Do you wish to build TensorFlow with XLA JIT support? [y/N]: y
XLA JIT support will be enabled for TensorFlow.

Do you wish to build TensorFlow with ROCm support? [y/N]:
No ROCm support will be enabled for TensorFlow.

Do you wish to build TensorFlow with CUDA support? [y/N]: y
CUDA support will be enabled for TensorFlow.

Please specify the CUDA SDK version you want to use. [Leave empty to default to CUDA 10.0]:

Please specify the location where CUDA 10.0 toolkit is installed. Refer to README.md for more details. [Default is C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.0]:

Please specify the cuDNN version you want to use. [Leave empty to default to cuDNN 7]:

Please specify the location where cuDNN 7 library is installed. Refer to README.md for more details. [Default is C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v10.0]:

Please specify a list of comma-separated Cuda compute capabilities you want to build with.
You can find the compute capability of your device at: https://developer.nvidia.com/cuda-gpus.
Please note that each additional compute capability significantly increases your build time and binary size. [Default is: 3.5,7.0]: 6.1

Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is /arch:AVX]: /arch:AVX2

Would you like to override eigen strong inline for some C++ compilation to reduce the compilation time? [Y/n]:
Eigen strong inline overridden.

Preconfigured Bazel build configs. You can use any of the below by adding "--config=<>" to your build command. See .bazelrc for more details.
        --config=mkl            # Build with MKL support.
        --config=monolithic     # Config for mostly static monolithic build.
        --config=gdr            # Build with GDR support.
        --config=verbs          # Build with libverbs support.
        --config=ngraph         # Build with Intel nGraph support.
        --config=dynamic_kernels        # (Experimental) Build kernels into separate shared objects.
Preconfigured Bazel build configs to DISABLE default on features:
        --config=noaws          # Disable AWS S3 filesystem support.
        --config=nogcp          # Disable GCP support.
        --config=nohdfs         # Disable HDFS support.
        --config=noignite       # Disable Apacha Ignite support.
        --config=nokafka        # Disable Apache Kafka support.
        --config=nonccl         # Disable NVIDIA NCCL support.

(tf_gpu) D:\Neural\tensorflow>bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package

[...]

FAILED: Build did NOT complete successfully

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Full log here

Found a workaround to fix this error message.

See #26679


Nuimo App doesn't start properly if Sonos speaker isn't reachable via it's IP address

Can be easily reproduced by adding a section to nuimo_app.cfg such as:
[deadbeef]
type = sonos
id = deadbeef
device_ids = deadbeaf-1
ip_address = <IP_ADDRESS>

Make sure that there's actually no device/speaker with that IP address.

I reckon this issue has been solved in PR #290 , where the fix has been applied to all kinds of devices being controlled over the wifi network.


chore(deps): update all non-major

This PR contains the following updates:

Package
Type
Update
Change

cockroachdb/cockroach

patch
v23.1.10 -> v23.1.11

leptos
dependencies
patch
0.5.0 -> 0.5.1

rust
final
minor
1.72-alpine3.17 -> 1.73-alpine3.17

Release Notes

leptos-rs/leptos (leptos)
v0.5.1
Compare Source
This is primarily a bugfix release, but it also includes a new feature: making the fallback prop on Show, Suspense, and Transition optional.
For 0.5 release notes in general, click here.
What's Changed

docs: fix For view prop name (closes #1813) by @gbj in https://github.com/leptos-rs/leptos/pull/1814
Missing docs and Copy impl for Callback by @gbj in https://github.com/leptos-rs/leptos/pull/1818
Fix template! cfg condition by @Dragonink in https://github.com/leptos-rs/leptos/pull/1822
Docs: DX improvements: add section about jetbrains intellij-rust by @sebadob in https://github.com/leptos-rs/leptos/pull/1804
made show fallback optional by @maccesch in https://github.com/leptos-rs/leptos/pull/1817
Fixes #1828, making SSR behavior match the Hydrate behavior. by @dgsantana in https://github.com/leptos-rs/leptos/pull/1829
fix: make explicit allowances for local-only suspense fragments in SSR/hydrate mode (closes #1823) by @gbj in https://github.com/leptos-rs/leptos/pull/1824
fix: correctly quote spread attributes in {..attrs} syntax (fixes #1826) by @gbj in https://github.com/leptos-rs/leptos/pull/1831
Allow disposing of Signal & StoredValue by @PaulWagener in https://github.com/leptos-rs/leptos/pull/1849
Make Async Mode return Content-Type header in Response by @benwis in https://github.com/leptos-rs/leptos/pull/1851
feat: support stored values in with! and update! by @blorbb in https://github.com/leptos-rs/leptos/pull/1836
Removed warning in build artefacts. by @martinfrances107 in https://github.com/leptos-rs/leptos/pull/1840
fix: update log debug to use get_untracked for logged in user to resolve client side console error by @kevinold in https://github.com/leptos-rs/leptos/pull/1834
fix: panic during generate_route_list if you immediately dispatch an action (closes #1832) by @gbj in https://github.com/leptos-rs/leptos/pull/1853
fix: clippy "needless lifetimes" warning (closes #1825) by @gbj in https://github.com/leptos-rs/leptos/pull/1852
"#two" was being hidden. Added another # to unhide by @he00741098 in https://github.com/leptos-rs/leptos/pull/1847

New Contributors

@Dragonink made their first contribution in https://github.com/leptos-rs/leptos/pull/1822
@kevinold made their first contribution in https://github.com/leptos-rs/leptos/pull/1834
@he00741098 made their first contribution in https://github.com/leptos-rs/leptos/pull/1847

Full Changelog: https://github.com/leptos-rs/leptos/compare/v0.5.0...v0.5.1

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

GitHub release
v0.7.0

Your semantic-release bot :package::rocket:


Missing Secure access support in the Readme

I would like to address that we support secure access in our feature matrix on DevHub:
https://developer.kenticocloud.com/v1/docs/delivery-sdks
Please add this information to the Readme file.

This has been updated.  Closing issue.

Thanks, Adam! I updated the docs on DevHub: https://developer.kenticocloud.com/v1/docs/javaandroid#section-supported-features


Add support for Consul TTLs and multiple checks.

This may potentially close #57, depending on how the original author wishes to
solve the problem. On each refresh, Registrator will write the current timestamp into
the check's notes.
Further, this change also introduces the ability to have multiple health checks
types. For example, a TTL may be used in conjunction with a script. This allows
for a more reliable service discovery mechanism, reducing the risk of services
reclaiming old ports. These changes also open the door for a simple, native HTTP
check integration with Consul. Because Registrator doesn't currently have an API
to store the upstream state of the service (i.e. remote check IDs), the Consul
adapter filters the defined checks into an ordered list, which it then
correlates to the check ID in Consul based on index. Consul's API implementation
suggests this is safe; however, this behaviour is not documented.
Sadly, this breaks compatibility with Consul 0.4.x, which only supported one
service check per service.

+1

+1

+1

+1

And rebase and we'll merge :)

+1

@burnison, would you please rebase your branch so this PR can be merged. would love to see multiple types of consul health checks supported 😸

+1


Files required through node --eval or node --require do not get instrumented

Demo repository
Expected Behavior
Files required through node --eval or node --require should be instrumented.
Observed Behavior
They do not get instrumented.
The demo repository contains two empty files index.js and other.js.
Running the file instrument it correctly:
$ nyc node index.js
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
 index.js |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

Requiring it through --eval does not instrument it:
$ nyc node -e 'require("./index")'
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

Requiring it through --require does not instrument it:
$ nyc node -r ./index.js other.js
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |        0 |        0 |        0 |        0 |                   |
 other.js |        0 |        0 |        0 |        0 |                   |
----------|----------|----------|----------|----------|-------------------|

Forensic Information
Operating System: Ubuntu 18.04
Environment Information: node v11.3.0, npm 6.4.1, nyc 13.1.0
Notes
nyc has a --require flag. However this only works when node is fired as the top-level command, not as a child process.
For example I am testing a library that has a register.js file that performs monkey patching on load (like @babel/register does). The only way to test it without polluting the global environment of the other tests is to run it as a child process. I.e. my unit test runs childProcess.spawn() using --require register.js.
I can work around the problem and avoid --eval or --require by loading a file that fires require() instead, but there might be other use cases that this limitation of nyc might impact.

Bumping again

I can answer part of this bug, it's not possible for files required via --require to be automatically instrumented.  To get this working you must pre-instrument the file to be included via --require, along with any sources it require's (if you want those files to be covered).  The --require options are processed before nyc can hook anything, partly due to startup order and partly due to the fact that --require options can actually be used to perform the instrumentation (see ES2015 tutorial for example).
The way that I know will work is if you have a module where sources are in ./lib/*.js and you want to test node --require ./lib/register.js, you would have to use the nyc instrument command to build an instrumented copy of the lib folder.  Then you would tests with node --require ./instrumented/register.js.
As for node --eval, I'm not sure if it's possible to hook this.  Like --require this is run very early in the process of starting a node process, before nyc can do anything.  Again I think the only way to accomplish coverage testing of stuff loaded so early is to pre-instrument it.

I've marked this issue so the stale bot will not touch it anymore, but understand that no code fix is planned.  The intent is to create a tutorial at istanbul.js.org for how to perform coverage testing of a --require script.

I understand, thanks for explaining the reason behind this. I do think this is a limitation in the current hooking system that should be documented.
A workaround I am doing which does not require an extra build step is to add a require() at the beginning of the first file to be executed. This only works if you can modify that file though (which is my case).
Another thing: I have seen that there has been some work in Istanbul towards offering NODE_V8_COVERAGE as an alternative for instrumentation. Would this solve that problem?

Native V8 coverage can be processed by c8 in place of nyc, it only uses istanbul to generate reports.  From what I can tell it doesn't yet support any kind of comment hints for disabling coverage.  I'd assume that native v8 coverage would pick up on node --require ./something.js, but I've never tried.

Yes exactly.
Thanks for your help, I am going to close this issue as this probably won't be fixed. However thanks for checking it out.


Host Page UI issues

Rancher versions: 6/6
Issues:

[x] When hosts are first being setup, the States has 0 containers, its small, doesn't match other pages format and is not centered

[x] In Group and State views of host, the Untested Docker version text does not have any space under it

[x] When no stats available, the text is not centered properly

[x] For AWS when I put the Access Key & Secret Key in and click Next, there is ...loading... text that is not aligned properly (goes by too fast for me to get screen shot.)

Results:

Version - 6/26 master (2.0)
Verified fixed


make pvc crud pages yaml-only

#1597
Moving persistentvolumeclaim.vue into @/edit/workload/storage so it can be used to provision pvc's as part of workloads, without showing up as the PVC create/edit/view page

Closing this in favor of #1650


HRE spherelings into sphere

see what relation type HREmperor has over them and sphere them.

https://forum.paradoxplaza.com/forum/threads/the-eu4-to-v2-converter-development-thread-not-for-troubleshooting.707362/page-260#post-26917369

Solved by #633


Add allow-require option to no-commonjs rule

This fixes #548

Coverage increased (+0.006%) to 95.969% when pulling d8dfc3b6ee7271de6eee1068629aae968ea78940 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.01%) to 95.976% when pulling 11d6d510b6991a428761ad83fa8841ed25675c30 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.04%) to 96.008% when pulling 759efd4cc61fb72b91e4d6fb64591b2477767742 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.04%) to 96.008% when pulling 759efd4cc61fb72b91e4d6fb64591b2477767742 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.04%) to 96.008% when pulling 759efd4cc61fb72b91e4d6fb64591b2477767742 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.04%) to 96.008% when pulling 759efd4cc61fb72b91e4d6fb64591b2477767742 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.04%) to 96.008% when pulling 759efd4cc61fb72b91e4d6fb64591b2477767742 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

Coverage increased (+0.02%) to 95.98% when pulling 0cdfb67d54a29b8e68f6a3c36b1b45b19e059c38 on futpib:no-commonjs-allow-require into 8101d39ea7fe94c1611b7183e5b171428f86f042 on benmosher:master.

I'm so waiting for this to release. Is there anything else to do for me?

@futpib i'd ilke @benmosher or @jfmengels to review it prior to merging.

Hi @futpib, sorry it has been literally forever since you submitted this and I'm finally getting back to it. 😅
I just upgraded this to semver-major because it changes the options on this rule. If you'd like to get it merged into the next 2.x release, can you make the options match the existing rule?
i.e. 'allow-require' instead of allowRequire: true. This is not my first choice; I like the flags-based options you've implemented better, but again, they are a breaking change to the existing rule.

@benmosher still got semver-major label though


Error while creating the New Relic AWS Lambda cloud integration

While trying to setup our NewRelic Lambda integration and deploying using serverless we get the following error with little suggestion on what to change and fix:
Serverless: Enabling New Relic integration for linked account: New Relic Lambda Integration - ****** and aws account: ************.
Serverless: Error while creating the New Relic AWS Lambda cloud integration: TypeError: Cannot destructure property `linkedAccounts` of 'undefined' or 'null'..

Here is our custom block in serverless.yml:
  newRelic:
    accountId: ${opt:newRelicAccountId, ""}
    apiKey: ${opt:newRelicApiKey, ""}
    cloudWatchFilter: "*"
    debug: true
    enableExtension: true
    enableIntegration: true
    layerArn: arn:aws:lambda:us-east-1:451483290750:layer:NewRelicNodeJS14X:5
    logEnabled: true
    logLevel: debug

Has anyone run into this problem before?

Thank you for the report, @Joaker4 !
I'm assuming that your accountId and apiKey are being defined at runtime in your command options, but I've also seen options fail for some properties. The custom block should be evaluated late enough to receive opt definitions. Could you try ruling that out by attempting a deployment with those temporarily filled in with hardcoded strings? (No need to show them here, but I'm interested to see if the behavior changes.)
(One other suggestion I'd have is not to define the layerArn, so you can pick up the latest, but that wouldn't affect the problem you're reporting.)

Thanks for the great suggestions @mrickard.
I tried hardcoding the values, creating new API Keys and removing the layerArn from our custom block, but unfortunately we're getting the same error.
I'm thinking the request to NerdGraph's API is not succeeding and returning an error, but not sure.

@Joaker4 I can think of a couple reasons that might be: one is someone in the NR EU region defaulting to the US NerdGraph endpoint, though since you were using a us-east-1 layer, I don't think that'd be the case for you. (In that case, you'd define nrRegion: eu in your serverless.yml)
Another possibility is that the NerdGraph API key isn't the correct one. I'd double check what values you see when you go to our Set Up AWS Lambda nerdlet in the UI. Does the key match what gets printed out in the command line examples in step 2, here? https://one.nr/0znQxNkxdRV

@mrickard Thanks for the follow up once again, we are in the US region, I double checked the values, created new API Keys via nerdlet in the UI, with no luck unfortunately.
The only error I'm getting is the
Serverless: Error while creating the New Relic AWS Lambda cloud integration: TypeError: Cannot destructure property `linkedAccounts` of 'undefined' or 'null'..

which lets me know that something is not parsing correctly or the request to the actual API is not succeeding. Do we know the values to make a manual request to the NerdGraph API in this case with my credentials?

@mrickard So it appears this is an Uncaught Warning of sorts? I think it's trying to integrate AWS and NewRelic but, doing some manual queries to NerdGraph Api, this step is already done and the request to integrate, when deploying serverless, returns empty data or nothing at all. If this is the case, then I think the log should catch this case.
Anyhow, it works as expected now, thanks for the previous suggestions.


fix: on website input grouping heading overlaps example

closes #3802
Signed-off-by: Florin Borceanu<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
The heading of the Input groups section overlaps previous Do/Don't section.
Issue Number: #3802
What is the new behavior?
Everything is ok.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
The height: 100% set to clrweb-DoxMedia-img class was added for the Timeline component documentation, where one of the images was misaligned. I reverted that change and I added to the specific image a inline style.

That fixes the problem, but I'm not entirely sure that it's bad to have the .clrweb-DoxMedia-img height: 100%. Another approach may be to follow up the parent tree and see if it breaks somewhere. And it breaks at .clrweb-DoxMedia. If we set it to 100% too, then it also fixes the problem.
I'd like to hear more from the team about it, before we chose a solution.
Also, we seem to have some issues with Travis currently. After the problem is resolved I'll restart the build there.

I also think that inline styles are not that good way to go.

I have no problem with inline styles, but the height: 100% being added to all of the images is not desirable since it wasn't needed before. I'm not sure why it causes the issue but this is also just our website vs a deliverable so I'm not terrible worried about it.

@florin-borceanu could you rebase with master so the Travis build will pass. Thanks ;)


Input color isn't immediately set after pressing enter with Key Remapping enabled

When the Key Remapping plugin is reset, the chatbox has no keyboard focus by default. Pressing enter enables chat input, but the chat input is colored default blue until one starts typing (or presses a modifier key like shift or control), regardless of what channel the user is currently in. I would prefer to immediately see a green star after pressing enter, when in the clan chat tab or in /c chat mode.

Along with this, it is confusing to have this plugin with Key Remapping enabled also. It no longer shows "Press Enter to Chat..." in the textbox when this plugin is enabled. I like the idea of this plugin, however, I currently have it off due to this.

I actually came here to report the same thing as Ashton. I love the plugin but if it could keep the "Press Enter to Chat..." that would be really appreciated

This was fixed by #9.


Discord voice does not work with local files

Issue description
createAudioResource('./aSong.mp3')
Does not work. The bot just joins and then leaves (because of my on idle).
It does however work with a published file on for example discord:
createAudioResource(https://cdn.discordapp.com/attachments/456207/aSong.mp3')
Am I the only one having the same issue? There are no errors, the bot just goes to idle immedietly after joining the channel.
Code sample
No response
@discordjs/voice version
0.7.5
Node.js version
16.3
Operating system
Windows
Priority this issue should have
Medium (should be fixed soon)

Me being stupid not clicking all the way in on the docs..


Section <IP_ADDRESS>

Version: Draft of “Probabilistic Machine Learning: An Introduction”. March 8, 2021
equation (7.75)  \bar{x} has dimensions of 1xD
The equation (7.81) assumes \mu to have dimension Dx1. Accordingly, the text below which says \mu = \bar{x} should ideally be read as:
\mu = \bar{x}^T
or better would be equation (7.75) defines l.h.s as \bar{x}^T which would make it consistent with equation (7.84)
Further equation (7.84) is missing subscript of N
It reads as
$\tilda{X} = X - \bold{1}\bar{x}^T$
but it should be read as
$\tilda{X} = X - \bold{1}_N\bar{x}^T$

fixed, thanks


uwsgi: <IP_ADDRESS> -> 2.0.18

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/uwsgi/versions.
meta.description for uwsgi is: '"A fast, self-healing and developer/sysadmin-friendly application container server coded in pure C"'.

Checks done (click to expand)

built on NixOS
/nix/store/5rz2q1f5cp46xbzvnfvxbfyrfkqsysi4-uwsgi-2.0.18/bin/uwsgi passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 2.0.18 with grep in /nix/store/5rz2q1f5cp46xbzvnfvxbfyrfkqsysi4-uwsgi-2.0.18
directory tree listing: https://gist.github.com/b6d9c2c3acbd8481f6d76ac3e1c0f791
du listing: https://gist.github.com/d7f12cd0b7fe0454279cf659c6dec765

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)
3 package rebuild(s)
3 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
cutelyst
uwsgi
virtlyst

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5rz2q1f5cp46xbzvnfvxbfyrfkqsysi4-uwsgi-2.0.18 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A uwsgi https://github.com/r-ryantm/nixpkgs/archive/37d1f59b362a78222dd754030414dc3cd8f2a6ec.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5rz2q1f5cp46xbzvnfvxbfyrfkqsysi4-uwsgi-2.0.18
ls -la /nix/store/5rz2q1f5cp46xbzvnfvxbfyrfkqsysi4-uwsgi-2.0.18/bin

cc @abbradar @schneefux for testing.

When will merge this PR?

nix-review all built. @shadchin It helps if you test the package in your use case using the testing instructions. If someone has tested a PR, it is more likely to get merged quickly.


Update book "Trailblazer. A New Architecture For Rails"

@ydakuka thanks for this patch and the other ones! Any reason why you closed the PR? The changes look good to me.

@Florent2 stop, I create a big PR, soon I will edit it.


how to derive eddsa method

nc DeriveChildKeyFromHierarchy(indicesHierarchy []uint32, pk *ExtendedKey, mod *big.Int, curve elliptic.Curve) (*big.Int, *ExtendedKey, error) {
var k = pk
var err error
var childKey *ExtendedKey
mod_ := common.ModInt(mod)
ilNum := big.NewInt(0)
for index := range indicesHierarchy {
ilNumOld := ilNum
ilNum, childKey, err = DeriveChildKey(indicesHierarchy[index], k, curve)
if err != nil {
return nil, nil, err
}
k = childKey
ilNum = mod_.Add(ilNum, ilNumOld)
}
return ilNum, k, nil
}
how the eddsa derive

and hot adjust the eddsa signing code

I just submitted a PR, hoping it will be helpful: https://github.com/bnb-chain/tss-lib/pull/299

thank you

2024-07-09T21:01:49.803+0800	INFO	tss-lib	tss/party.go:139	party {1,2}: eddsa-signing round 1 starting
2024-07-09T21:01:49.803+0800	INFO	tss-lib	tss/party.go:139	party {0,1}: eddsa-signing round 1 starting
2024-07-09T21:01:49.803+0800	INFO	tss-lib	tss/party.go:139	party {2,5}: eddsa-signing round 1 starting
2024-07-09T21:01:49.822+0800	INFO	tss-lib	tss/party.go:176	party {1,2}: eddsa-signing round 2 started
2024-07-09T21:01:49.822+0800	INFO	tss-lib	tss/party.go:176	party {0,1}: eddsa-signing round 2 started
2024-07-09T21:01:49.822+0800	INFO	tss-lib	tss/party.go:176	party {2,5}: eddsa-signing round 2 started
2024-07-09T21:01:49.863+0800	INFO	tss-lib	tss/party.go:176	party {1,2}: eddsa-signing round 3 started
2024-07-09T21:01:49.864+0800	INFO	tss-lib	tss/party.go:176	party {0,1}: eddsa-signing round 3 started
2024-07-09T21:01:49.865+0800	INFO	tss-lib	tss/party.go:176	party {2,5}: eddsa-signing round 3 started
2024-07-09T21:01:49.866+0800	ERROR	tss-lib	signing/local_party_test.go:305	Error: task eddsa-signing, party {2,5}, round 4: signature verification failed
local_party_test.go:306:
Error Trace:	/Users/malingzhao/mpc/binance/tss-lib/eddsa/signing/local_party_test.go:306
Error:      	task eddsa-signing, party {2,5}, round 4: signature verification failed
Test:       	TestE2EConcurrentWithHDDerive
--- FAIL: TestE2EConcurrentWithHDDerive (0.07s)

You should refer to this code: https://github.com/bnb-chain/tss-lib/blob/master/ecdsa/signing/prepare.go

You need to adjust the public keys like ecdsa does: https://github.com/bnb-chain/tss-lib/blob/master/ecdsa/signing/local_party_test.go#L249
You need to adjust the private key like ecdsa does: https://github.com/bnb-chain/tss-lib/blob/master/ecdsa/signing/round_1.go#L129

You need to adjust the public keys like ecdsa does: https://github.com/bnb-chain/tss-lib/blob/master/ecdsa/signing/local_party_test.go#L249
You also need to adjust the private key like ecdsa does: https://github.com/bnb-chain/tss-lib/blob/master/ecdsa/signing/round_1.go#L129


Fix Transport.ts

this.socket.write - doesn't match Node's signature and gives an error: "Cannot determine controller. Device unreacheable."
Node: socket.write(data[, encoding][, callback])
This change was tested and it's working.

Awesome, let me test this. Thank you.

Thank you so much. Updated with this version in 1.9.5. If you can, please join the discord server and let me know it's you.

My pleasure, thank you for keeping this alive, not an easy task, and for a super fast response!


Nominator: Return the correct enum value for MaybeValid values

This error message floods the log, because it is logged at Error level.
It is currently only returned if there are unknown txs (nominated txs we don't know about).
In this case, the node shouldn't outright reject the nomination,
but return the associated SCP value (`kMaybeValid`).

IIRC, this was intentional.
https://github.com/bosagora/agora/pull/1495#discussion_r558036529

Thanks for the link. Will dive into the code to see how to best handle it. But at the very least we should silence this message.

#2748 addresses the original motivation for this PR, which was the missing TX messages flooding the logs.


[move-cli] Include stdlib in move compile by default

This includes the Move stdlib as dependencies in the move compile command, and also updates things so this command respects the modes that are passed as well. This fixes #8673
Tests
Added a test from #8673  to make sure that compilation will fail with --mode bare and will compile with the default mode setting (stdlib).

/land

:broken_heart: Test Failed - ci-test

/land


[QUESTION] longhorn-backend is stuck in access in offline environment

Question

Suggest to use https://github.com/longhorn/longhorn/discussions to ask questions.

Environment

Longhorn version: 1.3.1
Kubernetes version: 1.23.7
Node config

OS type and version: CentOS 7.9
CPU per node: 4
Memory per node: 16G
Disk type: HDD
Network bandwidth and latency between the nodes: N/A

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): KVM

Additional context
longhorn-driver-deployer is stuck in init state, and after some search I found that the deployer is waiting until longhorn-backend is available.
$ kubectl get po -n longhorn-system
NAME                                           READY   STATUS     RESTARTS   AGE
engine-image-ei-766a591b-6nrxh                 1/1     Running    0          21m
instance-manager-e-02da1558                    1/1     Running    0          21m
instance-manager-e-ad36de1c                    1/1     Running    0          21m
instance-manager-r-4c395386                    1/1     Running    0          21m
longhorn-admission-webhook-54f48dc685-hv7fd    1/1     Running    0          22m
longhorn-admission-webhook-54f48dc685-vd6x5    1/1     Running    0          22m
longhorn-conversion-webhook-797859b9c8-bgxhz   1/1     Running    0          22m
longhorn-conversion-webhook-797859b9c8-wwhjf   1/1     Running    0          22m
longhorn-driver-deployer-6d6ff48c99-xlfjd      0/1     Init:0/1   0          22m
longhorn-manager-7dprq                         1/1     Running    0          22m
longhorn-manager-ck56b                         1/1     Running    0          22m
longhorn-ui-545566656-4x25b                    1/1     Running    0          22m

The strange part is the DNS of longhorn-backend can be resolved in longhorn-driver-deployer, so I don't think my coredns has any problem in configuration. When I invoke v1 URL using CURL,it was stuck, and does not return any result.
longhorn-driver-deployer-6d6ff48c99-xlfjd:/ # curl http://longhorn-backend:9500
{"data":[{"actions":{},"id":"v1","links":{"self":"http://longhorn-backend:9500/v1"},"type":"apiVersion"}],"links":{"latest":"http://longhorn-backend:9500/v1","self":"http://longhorn-backend:9500/"},"resourceType":"apiVersion","type":"collection"}
longhorn-driver-deployer-6d6ff48c99-xlfjd:/ # curl http://longhorn-backend:9500/v1
(stuck)

Followings are the logs from my longhorn-manager, and it seems that the manager receives the request from deployer.
time="2022-09-17T07:36:52Z" level=debug msg="CheckEngineImageReadiness: nodes [centos-offline-master] don't have the engine image longhornio/longhorn-engine:v1.3.1"
<IP_ADDRESS> - - [17/Sep/2022:07:36:54 +0000] "GET /v1 HTTP/1.1" 200 3923 "" "curl/7.66.0"
<IP_ADDRESS> - - [17/Sep/2022:07:36:57 +0000] "GET /v1 HTTP/1.1" 200 3923 "" "curl/7.66.0"
<IP_ADDRESS> - - [17/Sep/2022:07:37:00 +0000] "GET /v1 HTTP/1.1" 200 3923 "" "curl/7.66.0"
<IP_ADDRESS> - - [17/Sep/2022:07:37:04 +0000] "GET /v1 HTTP/1.1" 200 3923 "" "curl/7.66.0"
<IP_ADDRESS> - - [17/Sep/2022:07:37:07 +0000] "GET /v1 HTTP/1.1" 200 3923 "" "curl/7.66.0"
(repeat)

In longhorn-manager POD, I can access v1 URL, it returns the result instantly.
longhorn-manager-7dprq:/ # curl http://longhorn-backend:9500/v1
{"actions":{},"id":"v1","links":{"PVCCreateInputs":"http://longhorn-backend:9500/v1/pvccreateinputs","PVCreateInputs":"http://longhorn-backend:9500/v1/pvcreateinputs","UpdateAccessModeInputs":"http://longhorn-backend:9500/v1/updateaccessmodeinputs","UpdateDataLocalityInputs":"http://longhorn-backend:9500/v1/updatedatalocalityinputs","UpdateReplicaAutoBalanceInputs":"http://longhorn-backend:9500/v1/updatereplicaautobalanceinputs","UpdateReplicaCountInputs":"http://longhorn-backend:9500/v1/updatereplicacountinputs","activateInputs":"http://longhorn-backend:9500/v1/activateinputs","apiVersions":"http://longhorn-backend:9500/v1/apiversions","attachInputs":"http://longhorn-backend:9500/v1/attachinputs","backingImageCleanupInputs":"http://longhorn-backend:9500/v1/backingimagecleanupinputs","backingImageDiskFileStatuses":"http://longhorn-backend:9500/v1/backingimagediskfilestatuses","backingImages":"http://longhorn-backend:9500/v1/backingimages","backupInputs":"http://longhorn-backend:9500/v1/backupinputs","backupListOutputs":"http://longhorn-backend:9500/v1/backuplistoutputs","backupStatuses":"http://longhorn-backend:9500/v1/backupstatuses","backupTargets":"http://longhorn-backend:9500/v1/backuptargets","backupVolumes":"http://longhorn-backend:9500/v1/backupvolumes","backups":"http://longhorn-backend:9500/v1/backups","cloneStatuses":"http://longhorn-backend:9500/v1/clonestatuses","controllers":"http://longhorn-backend:9500/v1/controllers","detachInputs":"http://longhorn-backend:9500/v1/detachinputs","diskConditions":"http://longhorn-backend:9500/v1/diskconditions","diskInfos":"http://longhorn-backend:9500/v1/diskinfos","diskUpdateInputs":"http://longhorn-backend:9500/v1/diskupdateinputs","diskUpdates":"http://longhorn-backend:9500/v1/diskupdates","engineImages":"http://longhorn-backend:9500/v1/engineimages","engineUpgradeInputs":"http://longhorn-backend:9500/v1/engineupgradeinputs","errors":"http://longhorn-backend:9500/v1/errors","events":"http://longhorn-backend:9500/v1/events","expandInputs":"http://longhorn-backend:9500/v1/expandinputs","instanceManagers":"http://longhorn-backend:9500/v1/instancemanagers","instanceProcesses":"http://longhorn-backend:9500/v1/instanceprocesses","kubernetesStatuses":"http://longhorn-backend:9500/v1/kubernetesstatuses","nodeConditions":"http://longhorn-backend:9500/v1/nodeconditions","nodes":"http://longhorn-backend:9500/v1/nodes","orphans":"http://longhorn-backend:9500/v1/orphans","purgeStatuses":"http://longhorn-backend:9500/v1/purgestatuses","rebuildStatuses":"http://longhorn-backend:9500/v1/rebuildstatuses","recurringJobs":"http://longhorn-backend:9500/v1/recurringjobs","replicaRemoveInputs":"http://longhorn-backend:9500/v1/replicaremoveinputs","replicas":"http://longhorn-backend:9500/v1/replicas","restoreStatuses":"http://longhorn-backend:9500/v1/restorestatuses","salvageInputs":"http://longhorn-backend:9500/v1/salvageinputs","schemas":"http://longhorn-backend:9500/v1/schemas","self":"http://longhorn-backend:9500/v1/apiversions/v1","settingDefinitions":"http://longhorn-backend:9500/v1/settingdefinitions","settings":"http://longhorn-backend:9500/v1/settings","snapshotInputs":"http://longhorn-backend:9500/v1/snapshotinputs","snapshotListOutputs":"http://longhorn-backend:9500/v1/snapshotlistoutputs","snapshots":"http://longhorn-backend:9500/v1/snapshots","supportBundleInitateInputs":"http://longhorn-backend:9500/v1/supportbundleinitateinputs","supportBundles":"http://longhorn-backend:9500/v1/supportbundles","tags":"http://longhorn-backend:9500/v1/tags","volumeConditions":"http://longhorn-backend:9500/v1/volumeconditions","volumeRecurringJobInputs":"http://longhorn-backend:9500/v1/volumerecurringjobinputs","volumeRecurringJobs":"http://longhorn-backend:9500/v1/volumerecurringjobs","volumes":"http://longhorn-backend:9500/v1/volumes","workloadStatuses":"http://longhorn-backend:9500/v1/workloadstatuses"},"type":"apiVersion"}

Any hints to resolve the issue?
Add any other context about the problem here.

Turns out that it is MTU issue.
Once I configure the correct MTU, it issue was resolved.

resolved


Order of Checklist Items

I suggest we reorder the checklist items generally on fastest/easiest to slowest/hardest, but also consider if certain items build or link to each other.
Just looking at it as a list, here's the best reordering I could come up with:
Devices:
Keep your devices up to date
Use two-factor authentication
Use a password manager
Create a strong device passcode
Encrypt your devices
Internet:
Use encrypted messaging apps when sharing sensitive information
Change your DNS settings to <IP_ADDRESS> or <IP_ADDRESS>
Use a VPN
Use a privacy-first web browser
Use a privacy-first search engine
Use a privacy-first email provider
Set up a mobile carrier PIN
Freeze Your Credit
Learn and Review:
Educate yourself about phishing attacks
Review the privacy of your physical space
Review location, camera, and other sensitive device permissions
Review and remove metadata attached to photos you share
Review your social media privacy settings

There's no possibility of grouping cards together by topic, but it's a neat idea. A small side menu pointing to the different topics could then be added, to understand the page structure at a glance


Models produced by SavedModel.simple_save can't be loaded with saved_model.loader

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows
TensorFlow installed from (source or binary):
PIP
TensorFlow version (use command below):
1.12.0/'v1.12.0-rc2-3-ga6d8ffae09'
Python version:
3.6.2

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior
TF.saved_model.simple_save can't be loaded by tf.saved_model_loader  - it states
RuntimeError: MetaGraphDef associated with tags serve could not be found in SavedModel. To inspect available tag-sets in the SavedModel, please use the SavedModel CLI: `saved_model_cli`

Describe the expected behavior
a model created with tf.saved_model_simple_save can be loaded by using
tf.saved_model.loader.load(sess, tf.saved_model.tag_constants.SERVING, "./model")
Code to reproduce the issue
import tensorflow as tf
import numpy

learning_rate = 0.01
training_epochs = 2

# Training Data
train_X = numpy.asarray([3.3, 4.4, 5.5, 6.71, 6.93, 4.168, 9.779, 6.182, 7.59, 2.167,
						 7.042, 10.791, 5.313, 7.997, 5.654, 9.27, 3.1])
train_Y = numpy.asarray([1.7, 2.76, 2.09, 3.19, 1.694, 1.573, 3.366, 2.596, 2.53, 1.221,
						 2.827, 3.465, 1.65, 2.904, 2.42, 2.94, 1.3])
n_samples = train_X.shape[0]

with tf.Session() as sess:
	X = tf.placeholder("float")
	Y = tf.placeholder("float")

	W = tf.Variable(1.0, name="weight")
	b = tf.Variable(2.0, name="bias")

	pred = tf.add(tf.multiply(X, W), b)
	cost = tf.reduce_sum(tf.pow(pred - Y, 2)) / (2 * n_samples)
	sess.run(tf.global_variables_initializer())

	optimizer = tf.train.GradientDescentOptimizer(learning_rate).minimize(cost)
	for epoch in range(training_epochs):
		for (x, y) in zip(train_X, train_Y):
			sess.run(optimizer, feed_dict={X: x, Y: y})

	tf.saved_model.simple_save(sess, "./model", inputs={"x": X, "y": Y},
							   outputs={"c": pred})

with tf.Session() as sess:
	tf.saved_model.loader.load(sess, tf.saved_model.tag_constants.SERVING, "./model")

Other info / logs
When I go to check the model with 'saved_model_cli' - show lists the tag 'serve':
saved_model_cli.py show --dir . --all

MetaGraphDef with tag-set: 'serve' contains the following SignatureDefs:

signature_def['serving_default']:
  The given SavedModel SignatureDef contains the following input(s):
    inputs['x'] tensor_info:
        dtype: DT_FLOAT
        shape: unknown_rank
        name: Placeholder:0
    inputs['y'] tensor_info:
        dtype: DT_FLOAT
        shape: unknown_rank
        name: Placeholder_1:0
  The given SavedModel SignatureDef contains the following output(s):
    outputs['c'] tensor_info:
        dtype: DT_FLOAT
        shape: unknown_rank
        name: Add:0
  Method name is: tensorflow/serving/predict

but when I try to run it, I encounter the same issue:
saved_model_cli.py run --dir . --tag_set 'serve' --signature_def 'serving_default' --input_exprs x=[1];y=[2]
Traceback (most recent call last):
  File "C:\Users\coverste\AppData\Local\Continuum\anaconda3\Lib\site-packages\tensorflow\python\tools\saved_model_cli.py", line 827, in <module>
    sys.exit(main())
  File "C:\Users\coverste\AppData\Local\Continuum\anaconda3\Lib\site-packages\tensorflow\python\tools\saved_model_cli.py", line 823, in main
    args.func(args)
  File "C:\Users\coverste\AppData\Local\Continuum\anaconda3\Lib\site-packages\tensorflow\python\tools\saved_model_cli.py", line 644, in run
    init_tpu=args.init_tpu, tf_debug=args.tf_debug)
  File "C:\Users\coverste\AppData\Local\Continuum\anaconda3\Lib\site-packages\tensorflow\python\tools\saved_model_cli.py", line 304, in run_saved_model_with_feed_dict
    tag_set)
  File "C:\Users\coverste\AppData\Local\Continuum\anaconda3\lib\site-packages\tensorflow\python\tools\saved_model_utils.py", line 49, in get_meta_graph_def
    ' could not be found in SavedModel')
RuntimeError: MetaGraphDef associated with tag-set 'serve' could not be found in SavedModel

The tags to load should be a list in your last line:
	tf.saved_model.loader.load(sess, [tf.saved_model.tag_constants.SERVING], "./model")

When I run with that, everything works as expected. Closing this issue; please reopen if I have misunderstood.

Thanks - that resolved my issue. It would be nice to have an example using simple saver in the API docs or type annotations or something.


Rootfs is not passed to the farm and node filters

Search first
in some weblets rootfs not passed to the node/farm filter,

https://github.com/threefoldtech/tfgrid-sdk-ts/pull/893
https://github.com/threefoldtech/tfgrid-sdk-ts/pull/912
this changes will help to fix this issue

Status: PR #937 is ready for review

Verified.


Integration changes for ComprehensiveBufferize changes

This commit fixes tests that were broken due to changes in the upstream
bufferization.

@matthias-springer do you mind waiting for PR #26 to go in before you land this. Should be a simple rebase. Planning to land that in an hour

Sure, no problem.


Notify user when they visit in a browser that doesnt support Web Bluetooth

Mobile safari doesnt support web bluetooth, so we should notify users of this and suggest they install bluefy

Done


<IP_ADDRESS> Android Double

Please fill out either the bug or feature request section and remove whatever section you are not using.
Bug
<IP_ADDRESS> Android Double
double x = 1.5;
Settings.FontFactor = x;
var y = Settings.FontFactor; (returns 15, not 1,5)

What does your: Settings.FontFactor code behind look like?

This works in 2.5.1 - so I rolled back :-)
 public static double FontFactor
        {
            get
            {
                return AppSettings.GetValueOrDefault("fontFactor_" + Singleton.Instance.brugerID, (double)1);
            }
            set
            {
                AppSettings.AddOrUpdateValue("fontFactor_" + Singleton.Instance.brugerID, value);
            }
        }

interesting... will investigate

Sorry about that. Pushed out <IP_ADDRESS> and added Unit tests. Was an optimization in doubles and of course that small regression sorry.

Thanks James
Real fan of all your hard work 👍


Remove Void*Promise

Motivation:
Sometime in the past we introduced the concept of Void*Promise. As it turned out this was not a good idea at all as basically each handler in the pipeline need to be very careful to correctly handle this. We should better just remove this "optimization".
Modifications:

Remove Void*Promise and all the related APIs
Remove tests which were related to Void*Promise

Result:
Less error-prone API

I don't think s/voidPromise()/newPromise()/ is a safe transformation, as before it was halfway asserting there would be no failure and with newPromise() any failure is ignored.

(I'm fine with the principle of this change, but anywhere users of voidPromise are taking an simplistic approach and will need to add a listener when a real promise is being used)

yeah I was just about to say maybe we should add the ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE when ctx.voidPromise() etc was used. Is this what you mean ?

yeah I was just about to say maybe we should add the ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE when ctx.voidPromise() etc was used. Is this what you mean ?

Yeah. Something along those lines is what I expected.

yeah I was just about to say maybe we should add the ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE when ctx.voidPromise() etc was used. Is this what you mean ?

Yeah. Something along those lines is what I expected.

Although we may want to revisit that at some point. Ideally the exception would be fired relative to the handler's ctx, not the start of the pipeline. But "whatever" as far as this PR goes.

Yeah .. it always was from the beginning

Am 01.06.2021 um 17:37 schrieb Eric Anderson @.***>:

yeah I was just about to say maybe we should add the ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE when ctx.voidPromise() etc was used. Is this what you mean ?
Yeah. Something along those lines is what I expected.
Although we may want to revisit that at some point. Ideally the exception would be fired relative to the handler's ctx, not the start of the pipeline. But "whatever" as far as this PR goes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This change will literally kill my Load Balancer. Many times, LB handles small UDP packets at a rate of 2-3 Mpps, and all writes are done with voidPromise(). I cannot afford newPromise() at every write. What should I do now? :-|

@hyperxpro I would like to see a benchmark backing this claim ...

Benchmark of what exactly?

@hyperxpro like for example some flame graph etc

It's not about performance. voidPromise saves object allocation of ChannelPromise. At 2-3 Mpps, newPromise() will create 2-3M instances. GC will hit every second. Isn't there any alternative?

@normanmaurer If you can publish a snapshot of Netty 5, then I can test my LB and do profiling of Shenandoah GC.

Well GC is also about Performance ... like I Said i would like to see the difference in terms of throughput for your use-case. As of the GC works too hard it will also affect throughput/ latency etc

Alright, will do profiling probably next week, and I will post reports here.
PR can be merged though, I won't block this.

I have a concern similar to @hyperxpro.
I find in the applications I work on (mostly Minecraft-related but also an unrelated game server) this optimization tends to be extremely useful, and furthermore it reduces clutter in my code. The case of using voidPromise() is the common case in my application.
When dealing with forwarding lots of packets to servers behind my proxy, every bit of performance I can get out of it is extremely valuable, and that includes avoiding GC when possible. In particular, consider that my particular application needs to effortlessly handle many millions of packets per second (Minecraft connections can often spike to over 10,000 packets per second - multiply by 500 players and we have to handle 5Mpps). Furthermore, as earlier pointed out, it's not as simple as swapping out ctx.voidPromise() for ctx.newPromise().
This API definitely isn't for the uninitiated, and in general I am on board with the idea of simplifying the API where possible. This change will remove a lot of cruft from the internals of Netty, but without a credible alternative, this is a deal breaker for me to switch to Netty 5 (which I am otherwise very much looking forward to!)

I got the same opinion of @astei and @hyperxpro , we use Netty as building block of the ActiveMQ Artemis broker and saving that extra allocations in the hot path is definitely worth, although I also don't have any numbers to show it. Saving this hot path allocation is going to save a bit of TLAB capacity and for sure some CPU time to handle whatever garbage is going to be produced, but I am sure @normanmaurer is already aware of this: maybe some of the (ex)DataStax folks have some number/history to support/reject this? @belliottsmith

@astei @hyperxpro @franz1981 thanks a lot for the valuable feedback. I highly appreciate it! I am currently working on a POC that will restore the ability to do something similar as what we did with VoidPromise but without all the drawbacks of it. I will cleanup this PR to address the comments of @ejona86 and then merge it. After this I will open another PR with the alternative API which allows to use "zero allocation" like the VoidPromise did.

+1 for removal. I'm also looking forward to your callback API idea. :rocket:

Late LGTM, this is a good change and hope we can provide an escape hatch for essential VoidPromise usage

@hyperxpro @franz1981 @astei @ejona86 See https://github.com/netty/netty/pull/11378 for a draft that would still allow for "zero-allocation".


python310Packages.resolvelib: 0.5.5 -> 1.0.1

Description of changes
Diff: https://github.com/sarugaku/resolvelib/compare/0.5.5...1.0.1
Changelog: https://github.com/sarugaku/resolvelib/blob/1.0.1/CHANGELOG.rst
The concern about resolvelib in ansible has already been resolved.
https://github.com/ansible/ansible/pull/80196

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253239 run on x86_64-linux 1

48 packages built:

ansible (python310Packages.ansible-core)
ansible-later
ansible-later.dist
ansible-lint
ansible-lint.dist
ansible.dist (python310Packages.ansible-core.dist)
ansible_2_13
ansible_2_13.dist
ansible_2_14
ansible_2_14.dist
kargo
kargo.dist
molecule (python310Packages.molecule)
molecule.dist (python310Packages.molecule.dist)
pdm
pdm.dist
python310Packages.ansible-compat
python310Packages.ansible-compat.dist
python310Packages.ansible-kernel
python310Packages.ansible-kernel.dist
python310Packages.ansible-runner
python310Packages.ansible-runner.dist
python310Packages.ansible-vault-rw
python310Packages.ansible-vault-rw.dist
python310Packages.pytest-ansible
python310Packages.pytest-ansible.dist
python310Packages.pytest-testinfra
python310Packages.pytest-testinfra.dist
python310Packages.resolvelib
python310Packages.resolvelib.dist
python311Packages.ansible-compat
python311Packages.ansible-compat.dist
python311Packages.ansible-core
python311Packages.ansible-core.dist
python311Packages.ansible-kernel
python311Packages.ansible-kernel.dist
python311Packages.ansible-runner
python311Packages.ansible-runner.dist
python311Packages.ansible-vault-rw
python311Packages.ansible-vault-rw.dist
python311Packages.molecule
python311Packages.molecule.dist
python311Packages.pytest-ansible
python311Packages.pytest-ansible.dist
python311Packages.pytest-testinfra
python311Packages.pytest-testinfra.dist
python311Packages.resolvelib
python311Packages.resolvelib.dist

@natsukium Are you still interested in this?
Ansible_2_13 has already been dropped and Ansible_2_14 will be EOL in a month (https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html) so we probably don't want to have that in 24.05 anyways.
So maybe we can finally get rid of this 3 year old resolvelib in nixpkgs? :)

@phaer Thanks for letting me know. Let's drop ansible_2_14 and update resolvelib.

I think this just needs a rebase but otherwise should be unblocked since https://github.com/NixOS/nixpkgs/pull/303372 hit master.