Continious refresh gives different alert count

hi!
i got pretty strange behaviour on my production system.
i simplified my karma config as much as default one and remove all logic from it.
% cat karma/karma.yml
alertmanager:
  interval: 5s
  servers:
    - name: global
      uri: http://XXXX:9093
      timeout: 10s
      proxy: true
annotations:
  default:
    hidden: false
  hidden: []
  visible: []
  keep: []
  strip: []
custom:
  css: ""
  js: ""
debug: true
filters:
  default: []
grid:
  sorting:
    order: startsAt
    reverse: true
    label: alertname
    customValues:
      labels: {}
karma:
  name: karma
labels:
  keep: []
  strip: []
  color: {}
#    custom: {}
#    static: []
#    unique: []
listen:
  address: ""
  port: 8080
  prefix: /
log:
  config: true
  level: debug
  format: text
jira: []
receivers:
  keep: []
  strip: []
sentry:
  private: ""
  public: ""
silenceForm:
  author:
    populate_from_header:
      header: ""
      value_re: ""
  strip:
    labels: []
ui:
  refresh: 30s
  hideFiltersWhenIdle: true
  colorTitlebar: false
  darkTheme: false
  minimalGroupWidth: 420
  alertsPerGroup: 5
  collapseGroups: collapsedOnMobile

but almost every refresh gives me different count of alerts in group.
"totalAlerts":20 in "/alerts.json?sortOrder=&sortLabel=&sortReverse=&q=alertname%3DAlertName" then 26 then 21 then 46.
but i got 54 in alertmanager and count count(ALERTS{alertname="AlertName"}) shows that same number in latest 12 hours.
on debug log i got this
time="2019-10-29T11:49:02Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:02Z" level=info msg="[global] Got 20 silences(s) in 180.660098ms"
time="2019-10-29T11:49:02Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:03Z" level=info msg="[global] Got 136 alert group(s) in 446.790363ms"
time="2019-10-29T11:49:03Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:03Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:03Z" level=info msg="[global] Merging autocomplete data (996)"
time="2019-10-29T11:49:07Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:08Z" level=info msg="[global] Got 20 silences(s) in 129.363067ms"
time="2019-10-29T11:49:08Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:08Z" level=info msg="[global] Got 136 alert group(s) in 643.953836ms"
time="2019-10-29T11:49:08Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:08Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:08Z" level=info msg="[global] Merging autocomplete data (1002)"
time="2019-10-29T11:49:12Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:13Z" level=info msg="[global] Got 20 silences(s) in 203.510286ms"
time="2019-10-29T11:49:13Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:13Z" level=info msg="[global] Got 136 alert group(s) in 784.56864ms"
time="2019-10-29T11:49:13Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:13Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:13Z" level=info msg="[global] Merging autocomplete data (982)"
time="2019-10-29T11:49:17Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:18Z" level=info msg="[global] Got 20 silences(s) in 122.204322ms"
time="2019-10-29T11:49:18Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:18Z" level=info msg="[global] Got 136 alert group(s) in 580.695934ms"
time="2019-10-29T11:49:18Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:18Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:18Z" level=info msg="[global] Merging autocomplete data (998)"
time="2019-10-29T11:49:22Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:23Z" level=info msg="[global] Got 20 silences(s) in 193.127741ms"
time="2019-10-29T11:49:23Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:23Z" level=info msg="[global] Got 136 alert group(s) in 694.194664ms"
time="2019-10-29T11:49:23Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:23Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:23Z" level=info msg="[global] Merging autocomplete data (1008)"
time="2019-10-29T11:49:27Z" level=info msg="[global] Collecting alerts and silences"
time="2019-10-29T11:49:28Z" level=info msg="[global] Got 20 silences(s) in 123.690509ms"
time="2019-10-29T11:49:28Z" level=info msg="[global] Detecting JIRA links in silences (20)"
time="2019-10-29T11:49:28Z" level=info msg="[global] Got 136 alert group(s) in 887.478799ms"
time="2019-10-29T11:49:28Z" level=info msg="[global] Deduplicating alert groups (136)"
time="2019-10-29T11:49:28Z" level=info msg="[global] Processing unique alert groups (106)"
time="2019-10-29T11:49:28Z" level=info msg="[global] Merging autocomplete data (1000)"

there was no changes in alert count in alertmanager but Merging autocomplete data changes count frequently.
Most painful in that case that sometimes alert dashboard misses some teams entire.
Any idea how to debug this ?

Which alertmanager version are you using? There were some issues with the API fixed in alertmanager 0.19 (#812)

0.18.0.
Will try to update now

Tnx. maybe that issue is a good point to add some notice about 0.18.0 broken with karma. in the logs for example

Good idea, added a log warning via #1101


Brackets are not correctly added when nested.

When the Antlers plugin is enabled, the code formatting, indenting and brackets as you type is not working correctly.
PhpStorm version
PhpStorm 2022.2.1 Preview
Build #PS-222.3739.28, built on August 5, 2022
(using EAP for the UI Preview program)
Video of issue
https://www.awesomescreenshot.com/video/10406461?key=5c7ca37705ea5526a79c6935abb8a3c0
Interesting notes:

First use of {{ appears to work correctly - it creates the correct double closing
Use a div, then try {{ and you only get one } - expected }}
Outside (and after) the div, try {{ and you get three }}} closing brackets

I see there is already issue #19 regarding indentation too - was able to confirm incorrect indentation.

Fixed in bbf01f0e1492f816b15b33d4bb839de7b2e03e21


autodetect: add support for zip and rar archive type

Signed-off-by: Ma Shimiao<EMAIL_ADDRESS>

ping @opencontainers/image-tools-maintainers   any comments?

I think you need to add TypeImageZip in validateTypes and other places. Also need to modify the man file.

And please rebase and modify.

rebased

LGTM

ping @coolljt0725 @xiekeyang

LGTM

ping @coolljt0725 @xiekeyang @stevvooe

This is not work for me.
$ oci-image-tool validate busybox.zip
1 errors detected:
busybox.zip: validation failed: file does not exist

I debugged and guess it should be something wrong with zipWalker   (https://github.com/opencontainers/image-tools/pull/141/files#diff-52676de86adecced88d6dc21eb58fbcaR222), the get method is same with the tarWalker here, but I think it should be different, because when open a tar archive with vim it shows like this
" tar.vim version v29
" Browsing tarfile /home/lei/images/busybox.tar
" Select a file with cursor and press ENTER

busybox/
busybox/oci-layout
busybox/index.json
busybox/blobs/
busybox/blobs/sha256/
busybox/blobs/sha256/8ac8bfaff55af948c796026ee867448c5b5b5d9dd3549f4006d9759b25d4a893
busybox/blobs/sha256/8baf43d43a34a0e6649c254b0200c2406fc40a501a852ba51a86ac3672dc0441
busybox/blobs/sha256/40a114053d955a2b80ee2cf6e13410b28b59594ceee9036b41e12c42d3e16615

but  open a zip archive with vim, it shows like this
" zip.vim version v27
" Browsing zipfile /home/lei/images/busybox.zip
" Select a file with cursor and press ENTER

blobs/
index.json
oci-layout

I think that's why this can't work?
Does this work for you ? or Am I missing something?

I think that maybe because you didn't put oci-layout, blobs and index.json into the root of the archive. A valid archive of image should have those at the root of the archive, not nested within a top-level directory as busybox.

It works for me:
➜  oci-image-tool validate ubuntu.zip
oci-image-tool: reference "latest": OK
ubuntu.zip: OK
Validation succeeded

I'm looking for the reason for your mistake.

sorry, It seems something wrong with my zip archive, it works with another zip archive
$ oci-image-tool validate busybox.zip
oci-image-tool: reference "latest": OK
busybox.zip: OK
Validation succeeded

Can we  avoid adding a new TypeImageZip type and just use TypeImage, let the TypeImage to handle the different archive format? An zip format archive is also a file for image tool.  And in this way, I think we can reduce some duplication code. WDYT?

Letting TypeImage to handle different archive is a good option. But I think we have to do a lot changes to reach that.
Based on current structure, add TypeImageZip is the best choice, and rebuild the structure has less to do with the subject - adding support zip and rar.
So, how about making a follow-up PR to implement that after this PR landed? I can submit such PR later.

@Mashimiao  ok.  LGTM wait for other's opinion  @opencontainers/image-tools-maintainers

LGTM


rclone does not timeout on sftp backend when client ip address changes

After reconnect forcement of DSL, client gets a new ip address, but rclone does not reconnect or timeout

What is your rclone version (eg output from rclone -V)

rclone v1.36

Which OS you are using and how many bits (eg Windows 7, 64 bit)

macOS Sierra

Which cloud storage system are you using? (eg Google Drive)

sftp

The command you were trying to run (eg rclone copy /tmp remote:tmp)

rclone sync

A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)

2017/07/18 07:22:52 INFO  :
Transferred:   7.391 MBytes (12.604 kBytes/s)
Errors:                 0
Checks:                 5
Transferred:            0
Elapsed time:     10m0.3s
Checking:
 * data/41/410883dfee13fc6dd57059db8bd20ba90c1e30678018baa1e320b19133f05a53
 * data/b0/b033e57a1bf1e60262bf47c212ffc77eec61bfdf4571da1bd9280e8270549ec6
 * data/b9/b919f39bd9e6e1da7850bbed78444ef438a73ed12c05b7ff72c9c25c26830b2d
Transferring:
 * ...29988f9d56dd9edd60264cc9547d448b3f5eab1ada:  8% done, 0 Bytes/s, ETA: 0s
 * ...3bf2422f479f0c92cea9a7243887c2d16a22a64b1f: 45% done, 0 Bytes/s, ETA: 0s
 * ...44a6794f30c5a62bdf6711224d9e1e15f6252761b2: 73% done, 0 Bytes/s, ETA: 6135h35m13.167859712s
 * ...71c258dc05a410af921fff854f90af24d824754ecb: 22% done, 0 Bytes/s, ETA: 769937h14m41.232273408s

Fixing this would also fix #1538

This implements connection pooling for multiple ssh connections
A connection may be opened for each `--transfers` and `--checkers`
now.  Connections are checked when putting them in the pool and
getting them out the pool so it should recover from network errors
much better.

https://beta.rclone.org/v1.37-076-g5b6585f5/ (uploaded in 15-30 mins)
Please test and reopen the issue if you are still having a problem, or make a new issue with more info.
Thanks

I'm still seeing stalled connections with this beta version, multiple lines of:

..: 23% done, 0 Bytes/s, ETA: 0s

(sftp, rclone copy, 12 transfers

@Chainfire those connections should timeout eventually (5 minutes) and then rclone will open new ones

I found 11 of 12 transfers stalled both this morning and yesterday morning, apparently for several hours already (the transfers weren't much further along than I left them the night before)... I wish there was something more helpful I could say at this point.


fix typo Item#URLMoble to URLMobile

In api/product.go, struct Item, URLMoble is incorrect name. Because this parameter means URLsp(Smart Phone), URLMobile is correct name.

Coverage remained the same at 91.827% when pulling 43704d1c0e788dc40527f2a95ec273bcf2075cd3 on hidaruma:fix_typo_URLMoble into 28e956484d01e2c3264c7976ecfa2e1245660da8 on dmmlabo:master.


[HW]

Name: AMRIT KALSI
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/amrit-kalsi-399a541a4/
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:
-- images removed by team --

Looks good Amrit, thank you. Here's your badge -> https://api.badgr.io/public/assertions/q8HpismyRHqgvSVpS8r3pw?identity__email=amritkalsi7%40gmail.com


Remove schema.rb, it seems redundant.

This file appears irrelevant, must be a remnant of the CouchDB days. It's also using a strange module called GeoZone...

Coverage remained the same at 94.18% when pulling 0ce2d69a8a6fab23802bbafca38b8e890b5bc400 on huba:remove-old-file into 9636bc124f38c700f706d845a40d18664d3a79a3 on ioquatix:master.

Thanks, yeah, not sure what that was doing in there lol.


Refactors Bindinds to use Async Workers

This fixes concurrency issues reported in #189.
The code changed quite dramatically, better take a look at the files directly

https://github.com/Project-OSRM/node-osrm/blob/async_worker/src/node_osrm.hpp
https://github.com/Project-OSRM/node-osrm/blob/async_worker/src/node_osrm.cpp
https://github.com/Project-OSRM/node-osrm/blob/async_worker/src/node_osrm_support.hpp

References:

https://github.com/nodejs/nan#asynchronous-work-helpers
https://github.com/nodejs/nan/blob/master/doc/asyncworker.md#api_nan_async_worker
https://github.com/nodejs/nan/blob/master/doc/asyncworker.md#api_nan_async_queue_worker

/cc @TheMarex rebased into the initial commit you made for me

The support code could benefit from some refactoring.
I didn't touch it except for moving it into a separate header.

@daniel-j-h - can you share more about what was wrong with the original code, what the specific fix needed was, and how you confirmed the fix impacted performance? I'm asking because its not clear to me whether the fixes here apply or are relevant to other async code I maintain for other node c++ modules.

@springmeyer a couple of weeks before this pull request I learned about npm / node / nan by writing node bindings for @danpat's route-annotator. For making its features asynchronous I used NAN's beautiful async. abstractions. More concretely: 1/ inherit from Nan::AsyncWorker implementing the interface, 2/ enqueue the worker with Nan::AsyncQueueWorker.
If you take a look at the code before this changeset, node-osrm used libuv directly as in uv_work_t, uv_queue_work etc. --- when the performance regression came up during the sprint, I quickly prototyped the switch to NAN's async. abstractions for the Match service for which @TheMarex and I verified that it solved the problem. Eventually I rewrote all services (and added some abstractions that allows us to share code between the services).
Looping in libuv-wizard @kkaefer here.

@daniel-j-h - Thank you for the clarification. If I am understanding correctly then:

The code using uv_work_t/uv_queue_work directly was buggy somehow and not performing well
Porting to Nan fixed the issue
You benchmarked to confirm the performance difference

Is that correct? If so, there are dozens of node c++ modules that we (Mapbox) maintain which need fixed. So my further questions are:

Was the performance problem restricted to node v4 and not node v0.10?
Do you understand what Nan is doing that helped perf?

If you don't know no problem, I'm just trying to understand before diving in to figure out whether we need to change many node c++ modules and why/how. Thanks!

If I am understanding correctly then:

The code using uv_work_t/uv_queue_work directly was buggy somehow and not performing well
Porting to Nan fixed the issue
You benchmarked to confirm the performance difference

Is that correct?

The code using uv_work_t / uv_queue_work worked fine until we switched to Node 4.x (which updated the bundled libuv version, too). We never traced down the changes in libuv or the reason for the limited concurrency beyond the direct libuv usage, because the AsyncWorker approach fixed it and refactored the code at the same time quite nicely.
If you want to dig into this, this is what I would do:

checkout the commit before this changeset
get familiar with the source code that is using libuv a bit (maybe you find issues in it)
reproduce concurrency issue (see the original issue at the top)
read the Nodejs Changelog and get the libuv version number that comes bundled with it
check the libuv docs and source for this version and the features the source code is using
build a small self contained example reproducing the issue

Was the performance problem restricted to node v4 and not node v0.10?

Yes, I'm not sure though what else changed since I haven't had a close eye on node-osrm before, but I think that was the reason. Maybe @TheMarex or @lbud know more about this.

Do you understand what Nan is doing that helped perf? Is it using the libuv API differently?

From reading the NAN source, it looks like a really thin wrapper around libuv's uv_work_t / uv_queue_work. Take a look here:

AsyncWorker
AsyncQueueWorker

Hope that helps.

Thanks @daniel-j-h - I'll try to replicate and dig in when I have time.

@springmeyer FWIW, it may be that the way node-osrm was using uv_work_queue was incorrect, and other usages @Mapbox are just fine.
We noticed this when we were running benchmarks - we were maxing out at 2 CPUs in use and couldn't drive usage any higher.  If you aren't seeing that performance problem elsewhere, then it's probably a non-issue.
Rather than diving into what was wrong with our direct usage of uv_work_queue, @daniel-j-h just swapped in AsyncWorker and we got our performance back.  This tidied up the code and simplified things a lot, so we ran with it.


Fix two testing functions and move out tf.test

cc @gabrieldemarmiesse.

Ok I found the reason. When calling evaluate on the dictionary to get eval_result, all the values in the dictionary become numpy arrays (not TF tensors). Since here we're not calling evaluate, we end up with tensorflow tensors in the dictionary. As such, the same functions cannot be called. A cleaner change would be to call .numpy() when creating the eval_result dictionary, then we wouldn't need to do that cast, gather and such.

Thanks @gabrieldemarmiesse. It looks cleaner instead of simply conversion.


Possible for controls to slide two separate sliders?

For example:
+----------+
|  info1   |
+----------+
+----------+
< controls >
+----------+
+----------+
|  info2   |
+----------+

You click Next and Prev in the controls and both sliders move.

Both sliders use the same custom controls.

Hi @ganlanyuan thanks for the quick response, that works. At present can the drag event from the first slider info1 effect info2? So essentially can the drag be synchronised?

Drag may not work.
But I will check the possibility later on.


Update LICENSE

The copyright was given to conda-forge in the original license, but it should probably be something like CLIVAR. Please propose an alternative copyright holder if CLIVAR is not correct.

@eguil @yyplanton We found this issue with the license during code review for conda-forge. Can you please take a look and let me know if this is the correct copyright holder?

@lee1043

@acordonez I think copyright owned by CLVIAR sounds natural.


[Ethan] Custom templates

Ability to specify custom templates.
https://www.pivotaltracker.com/story/show/23706463
NOTE: This was branched off of the layout_refactor branch, so it probably needs to be merged first.

Or just merge this one. Or does it even matter? What's the preferred way to handle this?

Just so you know, I added some more commits to the layouts_refactor branch/pull, so I rebased this one. I think that was the right thing to do.


CHIP-0035: DataLayer Delegation Capabilities

Thanks, Yak, for the submission! This CHIP is now a Draft. Feel free to leave your reviews here. For general discussion of this CHIP, please use the #chips channel in our Discord.

I've updated the CHIP's category to Informational and its sub-category to Chialisp Puzzle at @danieljperry's suggestion.  Standards Track/Chialisp is meant for changes to chialisp (the language), not for new puzzles.

I have a few questions for y'all

Have you considered using the reference merkle tree puzzle here for permissioning: https://github.com/Chia-Network/chia-blockchain/blob/main/chia/wallet/puzzles/p2_1_of_n.clsp? This should support as many arbitrary puzzles as needed without requiring a comittment to the specific available roles.  It also should save cost at least in the owner spend case because you wouldn't have to reveal all of the permissioning logic for each spend type.
Could you elaborate on the additional complexities introduced by wallets supporting oracle management/usage?   Can you explain how wallets should overcome these existing assumptions and what new UX paradigms might be required?
Is the assertion of the new proposed memo format that datalayer singletons should not be hinting to their own launcher IDs?  Currently if you subscribe to the launcher ID of a datalayer singleton, you will not only recieve the launcher spend from a full node but also the spend of all of its descendants because it is hinting to its own launcher ID.  Is this functionality you intended to override?
Does the proposed oracle spend of (list (list CREATE_COIN [oracle_fee_address] [oracle_fee]) (list CREATE_PUZZLE_ANNOUNCEMENT ‘$’)) recreate the singleton as well?  As I understood it, it's manually creating a payment coin to the operator of the oracle but it's not doing anything else.
Is there any plan to support non XCH payments to oracle operators?  As the current puzzle sits, it seems like you pay the oracle by burning the appropriate amount of XCH kinda like a fee in order for the oracle spend to be valid.  Any consideration given to using the offer puzzle paradigm to rely on an announcement of any kind of asset?  Also are there any ideas to support multiple way of paying the oracle?
(very minor but you don't need to use $ announcements.  That's an unfortunately very public misunderstanding that adds 12000 cost to every spend.)

Hi Quex, and thank you for the questions (and the fast review)!

Have you considered using the reference merkle tree puzzle here for permissioning: https://github.com/Chia-Network/chia-blockchain/blob/main/chia/wallet/puzzles/p2_1_of_n.clsp? This should support as many arbitrary puzzles as needed without requiring a comittment to the specific available roles. It also should save cost at least in the owner spend case because you wouldn't have to reveal all of the permissioning logic for each spend type.

We've gone with a new puzzle for a few reasons:

If any admin/writer puzzles are given permission to update the store, owner spends become more of an assurance (uncommon - day-to-day txes would be done by the admin/writer).
The admin/writer delegated puzzles would need filters that ensure they're not updating the metadata updater hash. They would also need to re-create the coin via a CREATE_COIN, which would prove difficult since p2_1_of_n does not wrap CREATE_COINs and does not provide the MERKLE_ROOT to the child. To ensure the writer does not change MERKLE_ROOT, you'd have to 'rebuild' the current puzzle and assert it via a condition. You'd have to curry the singleton, NFT state, and p2_1_of_n layers, and that is a lot of args to either provide in the solution or curry in: singleton struct, NFT state layer mod hash, current metadata sha256tree, p2_1_of_n mod hash, and current merkle root.
Assuming the above are implemented: when the admin layer would change the list of delegated puzzle hashes, you'd have to run an additional validator puzzle that ensures the Merkle root still contains the owner's puzzle hash (we don't want admins to 'kick' the true owner out) and that the other puzzles are either an oracle or wrapped in the admin/writer filters. Otherwise, admins could add access to a puzzle that has the same permission as the owner and then fully take over the store in the next spend (which can be bundled in the same tx). I personally think this is a pretty cool program to code for things like vaults, but, in this case, the custom delegation layer removes the need for a lot of code, including this part.

Could you elaborate on the additional complexities introduced by wallets supporting oracle management/usage?  Can you explain how wallets should overcome these existing assumptions and what new UX paradigms might be

The former assumption is the easiest to overcome, as wallets already detect coin state changes. All wallets can tell you when they receive new coins, and update their state when transactions are confirmed (some coins are spent, some new coins might be created). Moreover, the official protocol supports subscribing to coin state changes (both on-chain and in the mempool).
As for the latter assumption: TibetSwap/warp.green are great examples since both feature singletons that everyone can spend. They work by fetching the latest coin on-chain and then also looking at the mempool - if there is a spend that's already pending, the drivers will build on top of it and then use the RBF mechanism. Wallets can implement a similar mechanism as the data store essentially becomes a 'shared/public singleton.'

Is the assertion of the new proposed memo format that datalayer singletons should not be hinting to their own launcher IDs? Currently if you subscribe to the launcher ID of a datalayer singleton, you will not only recieve the launcher spend from a full node but also the spend of all of its descendants because it is hinting to its own launcher ID. Is this functionality you intended to override?

The assumption was that the spends would be tracked one by one - after a spend is parsed, info about the new coin would be requested. However, I agree that letting the launcher ID be the hint has the potential to significantly speed up syncing - I will make the necessary updates to change the memo format from dg_layer_memos to (list launcher_id . dg_layer_memos) (the reasoning for removing root_hash and inner_puzzle_hash still stands).

Does the proposed oracle spend of (list (list CREATE_COIN [oracle_fee_address] [oracle_fee]) (list CREATE_PUZZLE_ANNOUNCEMENT ‘$’)) recreate the singleton as well? As I understood it, it's manually creating a payment coin to the operator of the oracle but it's not doing anything else.

The oracle is a delegated puzzle, so the delegation layer add the condition that re-creates the coin for each spend.

Is there any plan to support non XCH payments to oracle operators? As the current puzzle sits, it seems like you pay the oracle by burning the appropriate amount of XCH kinda like a fee in order for the oracle spend to be valid. Any consideration given to using the offer puzzle paradigm to rely on an announcement of any kind of asset? Also are there any ideas to support multiple way of paying the oracle?

Creating XCH payments this way is more efficient cost-wise. While non-XCH payments are not included in this CHIP, they're possible (as you noted) by using the offer puzzle. Moreover, the hinting scheme can be extended to add a new type of oracle that handles payments with CATs. I'm not sure what other ways there are to pay the oracle - could you provide an example?

(very minor but you don't need to use $ announcements. That's an unfortunately very public misunderstanding that adds 12000 cost to every spend.)

I chose '$' after reviewing this puzzle specifically, but it's also used in other places (e.g., p2 singleton). I assumed (list CREATE_PUZZLE_ANNOUNCEMENT 0) would take the same amount of space (-> same cost). Could you please provide the more cost-efficient way to create the announcement? Would be happy to update the spec accordingly.
Let me know if any concerns need more clarification, or if there are any more questions :)

Hello everyone,
You'll notice I pushed two small changes to the CHIP:

The memo format now uses a store's launcher id as the hint. See my earlier answer for the reason this is better - in short, it allows clients to query a bunch of datastore coins instead of getting them one-by-one. This optimization is worth it, even if it adds 32 * 12.000 = 384.000 cost to each spend.
A store's metadata may now hold 3 optional fields: label, description, and size. Any combination is valid (e.g., a store owner might provide a label and the store's size, but no description). To best accommodate this and provide the ability to add more fields in the future, optional fields will be stored as (key . value) inside the metadata.

See the changes in the CHIP document for full info. The reference implementation & tests have also been updated accordingly.

Hey @Yakuhito , I cannot speak to the rest but regarding:

I chose '$' after reviewing this puzzle specifically, but it's also used in other places (e.g., p2 singleton). I assumed (list CREATE_PUZZLE_ANNOUNCEMENT 0) would take the same amount of space (-> same cost). Could you please provide the more cost-efficient way to create the announcement? Would be happy to update the spec accordingly.

You should be able to just use () in place of $ to save that extra byte and reduce the clvm cost :+1:

@Yakuhito I wanted to propose that we change the standard metadata field size to bytes this way its no ambiguous how to update that data. For everyone else, a little background context, we want mirror providers to be able to make informed decisions on whether they want to mirror the store or not. Currently the only way to find out storage requirements of a store is to download it first and then check, which is less then ideal. My making it a standard that the client calculates the size of the store after the new merkle root is generated and about to update the chain. We think that having that info side by side to the roothash is the most ideal setup despite an increased cost, which imo is tolerable.

Hey @Yakuhito , I cannot speak to the rest but regarding:

I chose '$' after reviewing this puzzle specifically, but it's also used in other places (e.g., p2 singleton). I assumed (list CREATE_PUZZLE_ANNOUNCEMENT 0) would take the same amount of space (-> same cost). Could you please provide the more cost-efficient way to create the announcement? Would be happy to update the spec accordingly.

You should be able to just use () in place of $ to save that extra byte and reduce the clvm cost 👍

Hey @Yakuhito , I cannot speak to the rest but regarding:

I chose '$' after reviewing this puzzle specifically, but it's also used in other places (e.g., p2 singleton). I assumed (list CREATE_PUZZLE_ANNOUNCEMENT 0) would take the same amount of space (-> same cost). Could you please provide the more cost-efficient way to create the announcement? Would be happy to update the spec accordingly.

You should be able to just use () in place of $ to save that extra byte and reduce the clvm cost 👍

I asked for clarification because I don't understand why a byte would be saved. () is treated as 0 and still an atom (serialized as 0x80), so the size should be the same. Here's how I tested:
(venv) yakuhito@catstation:~$ run -d '(mod () (list CONDITION "$"))'
ff01ff89434f4e444954494f4eff2480
(venv) yakuhito@catstation:~$ run -d '(mod () (list CONDITION ()))'
ff01ff89434f4e444954494f4eff8080
(venv) yakuhito@catstation:~$ run -d '(mod () (list CONDITION 0))'
ff01ff89434f4e444954494f4eff8080

@Yakuhito I wanted to propose that we change the standard metadata field size to bytes this way its not ambiguous how to update that data.

I've updated the CHIP & reference implementation accordingly.

Drivers are now available in chia-wallet-sdk starting with version 0.13.0. Note that you'll need the chip-0035 feature to use them.
Special thanks to @Rigidity for making it possible :)

This CHIP is now in Review. Please leave your reviews here. If no major changes are required, we will work toward finalizing this CHIP soon.

Yak and Michael presented this CHIP on youtube here:
https://www.youtube.com/watch?v=jyg4Ji9LvKI

We'll be moving this CHIP to Last Call soon. Please leave your review here if you have not already done so. Thanks!

This CHIP is now in Last Call. If no further changes are required in the next two weeks, it will be moved to Final.

This CHIP is now Final. No further changes are allowed, other than adding errata. Thanks Yak and Michael!


[MM-47024][MM-47708] Create remote entrypoint for webapp to be imported by desktop, add basic module registry

Summary
This is the beginning of the work to allow the Web App to be consumed as a module by the Desktop App.
We use Module Federation to expose a remoteEntry.js file that the Desktop App will pick up and read. That file exposes certain entry points for the Desktop App to load and use as it sees fit. Right now we are only exposing the Redux Store, the styles, and the root component.
In order to allow for overrides, I've added a super basic module registry that is also exposed to the Desktop App. This allows the Desktop App to override any module that is marked as effectively "overridable" in the Web App.
This is still a WIP, but I'm keeping it up here so that development on this can be tracked as it goes.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47024
Related Pull Requests
Desktop PR: coming soon
NONE

@hmhealey Ready for another pass.

https://github.com/mattermost/desktop/pull/2343


Add install instructions to docs

Fills out the install section of the docs and updates the README to link to this updated section (rather than duplicating the information).

Closes #56

I would have implemented this PR differently:

On the README, I would only have the build from the source instructions and link to documentation for full install instructions. We expect some people to have trouble with Pip, so I don't think we should lead with that. Once we get the package on Conda, then we can replace build from the source with conda install instructions.
In the install docs, I would lead with build from source, then conda (with a note about it being forthcoming), then pip with the warnings. Build from the source first since it is most likely to work since it is really just a conda install. Then conda and pip since they both have problems. One being that we have not implemented it yet and the other being tough dependency installs for windows.
I would have used #. for the numbering in lists since it autonumbers.

That being said, I am interested in your thoughts.

@Rowlando13 - this is good feedback. Ultimately I would like the package to be easy to install via pip and so we could just lead with that but we're not quite there yet. I've revised the README to just link directly to the docs and I've lead with installation from source. Let me know what you think.

I meant to say this before, it is really nice to have another person work on documentation. I looked at the changes. Another finer point about restructured text, you used ^^^^^ for breaking the sections, but the python style guide says to use -----------. Sphinx does not actually care. As you noticed, it generated valid sections. I think we should standardize now to make it easier for contribution down the line.

@Rowlando13 @machallboyd - thanks for the review!
@Rowlando13 - I like the idea of standardizing the documentation format and so I went ahead and updated that in b0a112f4148e9dab383848c19f9cf437e9cdc5f0


Document token/org selection

Explain that a token will be used if one of the orgs matches the org of a given request.

I think it's made clear enough now.


Add FAQs

Why do we seem increase in impact with decrease in budget:
One of the conditions of the budget optimisation is that treatment must be the last intervention for which coverage is reduced when reducing the available budget.
This is implemented by removing any lower-coverage treatment options when the budget is high enough. When the budget is reduced below this theshold then the lower-coverage treatment options become available again.

For low incidence places, due to model stochasticity, it is possible for a run with lower tx coverage to have lower case numbers than a run with higher treatment coverage.

As a result of 1 and 2, it is possible to see unintuituve impact trends when the budget proportion crosses this threshold.
A the optimisation is a fucniton of both cases and deaths, this could also be caused by the trend being driven more by the "other" output (ie a counter intuitive trend in cases may be driven by the optimisation being shaped by deaths)

How can impact be greater than GP impact?


Button to Parse more CV

Add button to MainScreen on the right side

Last MVP branch merge solve the issue


Temperature module, ramp drawstyle uses wrong icon for temperatures near base and warn temperatures

Bug Description
Expected behavior
In the Temperature module documentation, the ramp settings says:

The icon selection will range from base-temperature to warn-temperature,
temperatures above warn-temperature will use the last icon
and temperatures below base-temperature will use ramp-0

This leads the user to think that the last icon is only used for temperatures above warn-temperature, and likewise ramp-0 for temperatures below base-temperature.
Actual behavior
The the last icon is actually used for temperatures slightly below warn-temperature, and ramp-0 for temperatures slightly above base-temperature. This disrupts the style of the module (example).
Reproduction
Using this module and font-awesome:
[module/temp0]
type = internal/temperature
thermal-zone = 0
base-temperature = 40
warn-temperature = 80

format = <ramp><label>
format-warn = <ramp><label-warn>

label = "%temperature-c%"
label-foreground = ${color.temp-shade}
label-background = ${color.bg}
label-padding= 1

label-warn = "%temperature-c%"
label-warn-foreground = ${color.fg-alt}
label-warn-background = ${color.temp-shade}
label-warn-padding = 2
ramp-0 = 
ramp-1 = 
ramp-2 = 
ramp-3 = 
ramp-4 = 
ramp-5 = 
ramp-6 = 
ramp-padding-left = 1
ramp-foreground = ${color.temp-shade}
ramp-background = ${color.bg}
ramp-6-foreground = ${color.fg-alt}
ramp-6-background = ${color.temp-shade}

Which should produce the above output, we can see that the icon in ramp-6 is used for 71C, which is below the warn-temperature of 74C.
This causes the ramp and label nodes to have different styles, making the whole thing ugly.
What I did to fix it
I made the temperature module calculate the variable m_perc as an unbounded-percentage instead of a normal percentage, this will allow temperatures below and above the normal range be reflected in the percentage value.
I wrote a ramp function get_by_percentage_with_border which will use the first and last ramp icons exclusively for percentage values outside the range (0, 100) and used it for the ramp in temperature instead

The previous commit was commited by mistake, I'm trying to revert it.
I'm sorry for the clumsiness, this is my first time making a pull request.

Thanks for the insight!
I made the requested change.


denied no match

when a wk is on queue it gives a wrong message:

This is a wrong behaviour, we will fix in the next release.

Fixed


HPLIP should be installed along with CUPS

Many HP printers require binary blobs to be installed for them to work.  HP provides them with an installer HPLIP - https://developers.hp.com/hp-linux-imaging-and-printing.  Could this be installed on your image?

@SonicMike thanks for opening this issue!
The hplip package is included in the Dockerfile. Does this package not include the required binary blobs you are mentioning?

@SonicMike thanks for opening this issue!
The hplip package is included in the Dockerfile. Does this package not include the required binary blobs you are mentioning?

I saw that HPLIP was mentioned, after adding this issue, in the tutorial on the Balena blog.  Sorry for not checking the directions more closely. When I add my printer CUPS finds it and in the next step there's 7 identical drivers to choose from. They are titled "HP LaserJet 1020, hpcups 3.18.12, requires proprietary plugin (en)" so I assumed that the proprietary plugin was something that was missing.  My printer is very old so I'm not surprised that its difficult to get working. It did work with Ubuntu however.  Printing the test page fails when connected to my RPI. I'll try redoing the steps from the Blog to see if that helps.

@SonicMike any luck after running through the tutorial again?

After I did some research I found out that the cause of the problem was hpcups and that foo2zjs  would drive the printer without issue.  So that's what I ended up doing.  This printer is very old and quirky (it needs firmware sent to it to work).

Gotcha! Since you were able to resolve the issue, I am going to mark this topic as closed. Thanks!

@SonicMike so what did you do exactly for this? i'm using HP Color Laserjet Pro CP 1025, here is same issue when use hplip, but foo2zjs driver is work for it. But i dont know how to include this foo2zjs driver into Balena-CUPS.
@willswire would you please also come out some guide about how to do include foo2zjs driver? checked steps on blog, see "this requires manually installing the drivers and plugins" for these printers equire proprietary plugins:


Is it possible to add statistical modification For example: total_time_played?

Is it possible to add statistical modification
For example: total_time_played

Or course technically it's possible, and you know it. It's just that I'm not really interested in implementing such functionality. If you feel like it - you are welcome to implement it and send a PR.


We want to generate a face wearing glasses, which are the style of our given picture， how should we do? Thank you!

Hello, this application is for designing bespoke eyeglasses rather than fitting existing ones to the face.


Get displayed months on multiple years

Hello,
Thanks for your work !
When I use startDate for a year and a endDate to year+1 (or more), I can't display months of the next year.

Hello, @MasterCynder how you apply start and end date?

Calendarro(
displayMode: DisplayMode.MONTHS,
startDate: DateTime.now(),
endDate: DateTime(2020, 12, 31),
)
I can slide to the last month of this year but, I can't slide beyond.

Hey @MasterCynder I just checked it.
Yes, it's a bug. I'll fix in this weekend I hope :)
Stay tuned!

@MasterCynder
Actually the fix was quite easy so I just uploaded v1.1.1 !
Let me know if all works! :)

Everything is okay. Thank you very much !


feat: post festival page

Description
This PR implements the post-festival page layout

Review Error for AshishYelekar @ 2023-09-01 14:02:16 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help


Can't run flutter on android

Hello,
i cannot run my flutter app on android
can somebody please help me with this?
flutter run -t lib/main_dev.dart --verbose
I get
                                                                                 1 ↵  23  12:04:00
[  +33 ms] executing: [/Users/b.sellahi/Desktop/flutter-workspace/flutter/] git log -n 1 --pretty=format:%H
[  +45 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[        ] bc7bc940836f1f834699625426795fd6f07c18ec
[        ] executing: [/Users/b.sellahi/Desktop/flutter-workspace/flutter/] git describe --match v*.*.* --first-parent --long --tags
[  +35 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[        ] v1.6.3-0-gbc7bc9408
[  +10 ms] executing: [/Users/b.sellahi/Desktop/flutter-workspace/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +10 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [/Users/b.sellahi/Desktop/flutter-workspace/flutter/] git ls-remote --get-url origin
[   +8 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[  +49 ms] executing: [/Users/b.sellahi/Desktop/flutter-workspace/flutter/] git rev-parse --abbrev-ref HEAD
[  +16 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] beta
[ +324 ms] executing: /Users/b.sellahi/Library/Android/sdk/platform-tools/adb devices -l
[  +10 ms] Exit code 0 from: /Users/b.sellahi/Library/Android/sdk/platform-tools/adb devices -l
[        ] List of devices attached
           emulator-5554          device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86 transport_id:2
[   +7 ms] executing: idevice_id -h
[  +32 ms] /usr/bin/xcrun simctl list --json devices
[ +236 ms] More than one device connected; please specify a device with the '-d <deviceId>' flag, or use '-d all' to act on all devices.
[   +3 ms] /Users/b.sellahi/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop
[  +33 ms] ro.hardware = ranchu
[   +4 ms] Android SDK built for x86 • emulator-5554                        • android-x86 • Android 10 (API 29) (emulator)
[        ] iPhone Xs                 • D841AE69-DB5B-402C-85C0-6E4C1874B2EE • ios         • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
[  +10 ms] "flutter run" took 677ms.
[        ] "flutter run" took 677ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:24:3)
#1      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:257:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:467:11)
<asynchronous suspension>
#3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:424:33)
<asynchronous suspension>
#4      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:29)
<asynchronous suspension>
#5      _rootRun (dart:async/zone.dart:1124:13)
#6      _CustomZone.run (dart:async/zone.dart:1021:19)
#7      _runZoned (dart:async/zone.dart:1516:10)
#8      runZoned (dart:async/zone.dart:1463:12)
#9      AppContext.run (package:flutter_tools/src/base/context.dart:152:18)
<asynchronous suspension>
#10     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:415:20)
#11     CommandRunner.runCommand (package:args/command_runner.dart:196:27)
<asynchronous suspension>
#12     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:396:21)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:29)
<asynchronous suspension>
#14     _rootRun (dart:async/zone.dart:1124:13)
#15     _CustomZone.run (dart:async/zone.dart:1021:19)
#16     _runZoned (dart:async/zone.dart:1516:10)
#17     runZoned (dart:async/zone.dart:1463:12)
#18     AppContext.run (package:flutter_tools/src/base/context.dart:152:18)
<asynchronous suspension>
#19     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:356:19)
<asynchronous suspension>
#20     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:111:29)
#21     new Future.sync (dart:async/future.dart:224:31)
#22     CommandRunner.run (package:args/command_runner.dart:111:11)
#23     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:242:18)
#24     run.<anonymous closure> (package:flutter_tools/runner.dart:60:20)
<asynchronous suspension>
#25     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:29)
<asynchronous suspension>
#26     _rootRun (dart:async/zone.dart:1124:13)
#27     _CustomZone.run (dart:async/zone.dart:1021:19)
#28     _runZoned (dart:async/zone.dart:1516:10)
#29     runZoned (dart:async/zone.dart:1463:12)
#30     AppContext.run (package:flutter_tools/src/base/context.dart:152:18)
<asynchronous suspension>
#31     runInContext (package:flutter_tools/src/context_runner.dart:51:24)
<asynchronous suspension>
#32     run (package:flutter_tools/runner.dart:51:10)
#33     main (package:flutter_tools/executable.dart:59:9)
<asynchronous suspension>
#34     main (file:///Users/b.sellahi/Desktop/flutter-workspace/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#35     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:298:32)
#36     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

[✓] Flutter (Channel beta, v1.6.3, on Mac OS X 10.14.5 18F132, locale de-DE)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2.1)
[✓] Android Studio (version 3.4)
[✓] VS Code (version 1.37.0)
[✓] Connected device (2 available)

• No issues found!

You have to many devices connected.
To get a devices list run flutter devices and insert the value of the 2nd column of the device you want to run the app on into this command: flutter run -d ID and replace ID with the value.

@riobijanero, I think it's safe to close the issue.
More than one device connected; please specify a device with the '-d <deviceId>' flag, or use '-d all' to act on all devices.
was mentioned in the log you posted.
I hope @jld3103 comment helped you to solve the issue. Anyway, feel free to open a new one to comment this one so I can reopen it.


Cards

🚀 Pull Request
Description
I decided to replace the tabular layout of the property listing page with an interactive card-based design .This new layout creates a more engaging and user-friendly interface for browsing properties.
Objective covered

Each card will display key details like property images, price, description and other relevant information.
The design is fully responsive, ensuring that the cards adapt seamlessly across all screen sizes, from mobile devices to desktops..

Related Issue
Fixed issue #244

Type of Change
What kind of change does this pull request introduce?

[ ] 🐛 Bug fix
[x] 🚀 New feature
[x] 📄 Documentation update
[x] 🛠 Code improvement/refactor
[x] 🖼 UI/UX update
[ ] Other (please specify)

Screenshots (if applicable)
Add screenshots or screen recordings to demonstrate the new feature or fix.

Checklist
Please ensure the following tasks are complete before submitting the pull request:

[x] I have tested my changes and ensured they work as expected.
[x] I have added any necessary documentation or comments.
[x] I have checked the existing issues and pull requests to avoid duplicates.
[ ] I have starred this repository.
[x] I have reviewed my code for best practices and readability.
[ ] I have included any relevant tests (if applicable).

Additional Context
Please add label of gssoc ext 2024 and hacktoberfest before merging PR.

Hey @ShradhaSaxena23 please resolve the merge conflicts.


Incorrect method when user defined headers are set.

When user headers are defined, getValue() method is not found. Use getFieldBody() method.

Nice spot, seems good to me.
Thanks for your work, we will merge this into master and create a new release with your fix.

Seems good.
https://github.com/swiftmailer/swiftmailer/blob/master/lib/classes/Swift/Mime/Header.php#L85

Ok then I will prepare more changes. (:


fix(dapp console): Various bugbash fixes_

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#176  👈
#175
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @imranjami and the rest of your teammates on  Graphite


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 1cbe58f, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 7040 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in 6bbe219.


How to harden / customize SSL config?

I filed https://github.com/JrCs/docker-letsencrypt-nginx-proxy-companion/issues/197 on the companion container, but maybe that issue belongs here.
I want to harden my SSL config to use either the Modern or Intermediate config from here: https://wiki.mozilla.org/Security/Server_Side_TLS
What is the way to customize the config from this container?

+1

You might take a look at my SSL Enhancement PR, it is functional and tested, and provides an A+ rating:
https://github.com/jwilder/nginx-proxy/pull/589


Exit application on --hpx:version/-v and --hpx:info

Exit application on --hpx:version/-v and --hpx:info  after printing the respective information

This addresses #1494

Works fine!

LGTM

Thanks Hartmut!


Release process: notification of content freeze

Original report on BitBucket by Taina Jääskeläinen.

This is an issue relating to the general release process. As the release requires a content freeze:

At the time of the freeze, the Editor should have a notification in the UI saying something like: The service is under maintenance today.
Notifications of the freeze start and end sent to the SL and TL admin by email. Probably by the Content Contact.

In short term, create static 'Maintenance' page and use DNS change (with short life) to redirect users.

The server should also return a 503 status code as well

@matthew-morris-cessda  Can this be used for the 3.2.0 release on 09/05/2023?

I believe this is resolved and we can close the issue? @john-shepherdson

@matthew-morris-cessda Will this be resolved for the 3.3.0 release?, if not is should be removed from the milestone

This has been removed from the 3.3.0 milestone

@matthew-morris-cessda Will the issue still be resolved? If so, we can add it to the milestones again.

@matthew-morris-cessda Since according to your comment (September 2023) the issue has not yet been resolved, I assume that it is still open.

Yes, this has not been resolved

@matthew-morris-cessda Thanks for the info. How long would it take or how much time would it take to resolve the issue?


fix: normalize coverage directory

Jest allows root directory <rootDir> string token to be specified for path configurations.
This fix allows this variable to be resolved into path.dirname(configPath).
Fixes #22

@rbardini kindly review / approve the workflow run.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@7671d61). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main       #26   +/-   ##
========================================
  Coverage        ?   100.00%
========================================
  Files           ?         7
  Lines           ?        71
  Branches        ?         0
========================================
  Hits            ?        71
  Misses          ?         0
  Partials        ?         0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for the fix, @anlesk! This solves the default use case, but eventually we should resolve <rootDir> to the rootDir option set in the Jest config, maybe using Jest's replaceRootDirInPath util.

@rbardini, I agree. The code assumes that root directory is where config file is located, but should take other options into account.


Endless wait for a basic_ack

Hello,
any idea why a wait after a basic_ack in lapin 0.26.9 would block indefinitely? The same channel as for the consumer creation is used and nothing else happens on this channel, yes, a second channel exists but that's only for some basic_publish calls which work fine.
All the threads except for the application thread are stuck in a mio poll...

Hello,
I'll give this a look. Do you always reproduce the problem or does it only happens sometimes?
Do you have a minimal reproducer available?

I am afraid that it happens somewhat anytime. The relevant code is here: https://github.com/tyrylu/feel-the-streets/blob/master/server/src/bin/worker.rs
Some of the tasks can create a second connection, but that does not change the outcome.

How can I easily reproduce the problem?
On Mon 2 Sep 2019 at 12:57, Lukáš Tyrychtr<EMAIL_ADDRESS>wrote:

I am afraid that it happens somewhat anytime. The relevant code is here:
https://github.com/tyrylu/feel-the-streets/blob/master/server/src/bin/worker.rs
Some of the tasks can create a second connection, but that does not change
the outcome.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sozu-proxy/lapin/issues/204?email_source=notifications&email_token=AABWNXVSACMYGPOA2XFXCCDQHTWRVA5CNFSM4IS33PC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5VPTAQ#issuecomment-527104386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABWNXWE4CGJ6SKPDDJCIPTQHTWRVANCNFSM4IS33PCQ
.

The behavior is even weirder with the 0.27 beta 5 version. Calling channel.basic_ack(...).into_error() (as in the example) results in a return, however the trace logs indicate that no ack frame is being send:
[INFO  worker] Task executed successfully.
[TRACE lapin::connection] connection send_frame; channel_id=1
[TRACE lapin::connection] connection set readable
[INFO  worker] Task acknowledged.
[TRACE lapin::connection] connection send_frames; channel_id=2
[TRACE lapin::connection] connection set readable
[TRACE lapin::io_loop] io_loop send continue; can_read=true, can_write=true, has_data=false
[TRACE lapin::io_loop] io_loop do_run done; can_read=true, can_write=true, has_data=false, status=Setup
[TRACE lapin::io_loop] io_loop run
[TRACE lapin::io_loop] io_loop poll
[TRACE lapin::io_loop] io_loop poll done
[TRACE lapin::io_loop] io_loop do_run; can_read=true, can_write=true, has_data=false
[TRACE lapin::io_loop] io_loop do_run done; can_read=false, can_write=true, has_data=false, status=Setup
[TRACE lapin::io_loop] io_loop run
[TRACE lapin::io_loop] io_loop poll

As if the io loop didn't notice the request to send the data or something.

Ok, I got what's going on:
Currently, the thread running the consumers is the same as the one doing the I/O. Waiting for the result of basic_ack hence blocks it, preventing it from actually sending the basic_ack.

Wrt the into_error stuff, I'll just remove it, it's misleading, it basically tells you if there was an error when scheduling the message to be sent, it doesn't actually wait for it to be sent.
I'll try to find an easy fix until the various io_loop issues are fixed. in the meantime, i suggest you to use a crossbeam channel, spawn a thread (or more), waiting for new messages, and in your consumer, juste post the message in the crossbeam channel. (This is the pattern I use everywhere, that's why I never hit this bug myself)

Thank you, i'll look into it, i thought that i will simplify the worker (previously there were threads mainly because of some tokio runtime related issues), so it seems they'll return at least for a while.

Can you retry with 0.27.0-beta.6?

I'll try and report sometime tomorrow in the morning after the scheduled task executes.

Thank you, beta 6 works as expected.

Thanks for confirming!


Auth middleware in route

Hi Author.
Thanks for your code, very clear and easy for starter, i have a problem with auth, in routes.js, how i can add auth middleware.
Thanks so much.

Currently this is not available, but you can write it ;) In Google you can find many examples how do this eg. https://gist.github.com/iNikNik/1eabfc6bcc132384368c

Thanks so much


TextInputLayout clipped when adding textInputStyle

Library Version:
3.1.0 (tested with a2c743b15a3d4f37983b9e39c9fdb3656b0531a6 as well)
Affected Device(s):
Emulator Pixel 3 with Android Q Beta 5
Describe the Bug:
When adding a style to all text inputs via textInputStyle, the input box on the dialog is clipped. Adding a TextInputLayout to a non-dialog layout works fine.
To Reproduce:

checkout a2c743b15a3d4f37983b9e39c9fdb3656b0531a6
add <item<EMAIL_ADDRESS>to AppTheme in the sample module
open a input dialog

When added to my app, it looks different but also clipped:

Expected Behavior:
The input box in a dialog should behave like all other TextInputLayout in the app. When setting  textInputStyle on the theme, the dialog should respect it.

This looks like #1707, #1701, #1695, #1712 and I am using material 1.1.0-alpha08 but as mentioned, this happens in 1.0.0 as well (as used in the sample app).

Looks like it can be fixed by just using the defaults of TextInputLayout. This means, removing app:hintEnabled and style from TextInputLayout and TextInputEditText in md_dialog_stub_input.xml.
This results in the known UI when not setting textInputStyle:

And when setting it, it uses the same style as all the other TextInputLayout in the app - which is what we want:

Hint: The missing horizontal margin on the box is fixed in material 1.1.0-alpha08 so it should be fine to not set any margin manually.

@afollestad why do we need app:hintEnabled and the styles MD_Dialog_Input_Layout and MD_Dialog_Input_Layout.Message? Did I miss something?

I will work on this.

@ChristineWasike please have a look at #1858 where I've already "fixed" this.

Using ConstraintLayout as a Container and adjusting width to 0dp worked in my case, even I use the OutlinedBox Material Style

@GTripathee do you mean in a custom layout for the dialog?
This might be a workaround but as the library directly provides the possibility to show a text field it would be nice to have this fixed instead of needing a custom view (see discussion in #1858).

Yes I tried in the custom layout.
You are right that its good to have the fixes on the library dialog.
This might be helpful for the people trying out custom layout.


SCT-1221 Add user lookup configuration to the builder.

Tested manually with the cli script and the service.
This doesn't test the user name verification yet, but will test later.

Pull Request Test Coverage Report for Build 175

29 of 43 (67.44%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 94.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/jgikbase/idmapping/builder.py
28
42
66.67%

Files with Coverage Reduction
New Missed Lines
%

src/jgikbase/idmapping/builder.py
2
62.5%

Totals

Change from base Build 174:
-0.3%

Covered Lines:
944

Relevant Lines:
1001

💛  - Coveralls


Implement provenance checking

Flesh out the method for provenance checking.

While writing the provenance checking, an inconsistency in ARA / KP  edge attribute value syntax became apparent.
I give these three snippets of TRAPI edge attributes to illustrate the issue:
{'attribute_type_id': 'biolink:original_knowledge_source', 'value': ['infores:panther'], ...}

{'attribute_type_id': 'biolink:aggregator_knowledge_source', 'value': 'infores:aragorn', ...}

{'attribute_type_id': 'biolink:aggregator_knowledge_source', 'value': ['infores:automat-panther'],...}

All from one test result...  As further background, I remind us all that biolink:original_knowledge_source is multivalued: false in the Biolink Model, whereas, biolink:aggregator_knowledge_source is multivalued: true.
However, TRAPI spec does not exclude a list value, i.e.
        value:
          description: >-
            Value of the attribute. May be any data type, including a list.

If a given association slot is multivalued, then would the best practices be to replicate the attribute entries, rather than to aggregate their values into a list?
On the other hand, (from Eric Deutsch): "...if an original_knowledge_source is a database, not a journal article and if two databases independent curate the information from a paper, then there are two original_knowledge_sources, right? It is not obvious to me that they shouldn't be a list under original_knowledge_source..."
In this spirit, the following could be permitted for, say, the aggregator_knowledge_source:
{'attribute_type_id': 'biolink:aggregator_knowledge_source', 'value': ['infores:aragorn', 'infores:automat-panther'],...}

In the short term, perhaps the SRI Testing harness component for provenance checking needs to be a lenient enough to let lists pass through(?).

Resolved by https://github.com/TranslatorSRI/SRI_testing/pull/24, although not 100% sure that Eric's use case was fully captured (I'd have to think) but provenance lists shouldn't choke the code at this point (I think...)


Remove protocol deafult

violating:= Set new.
SystemNavigation default
	allClasses do: [ :class |
		(((class protocols ifNil: #()),
		(class class protocols ifNil: #())) includes: 'deafult')
			ifTrue: [ violating add: class ].
		 ].
violating

You will get

The project is outside feenkcom
The issue with deafult is present in branch Pharo11
https://github.com/pharo-spec/NewTools/tree/Pharo11
But is not present in Pharo12 or Pharo13


[FEATURE REQ] add docs for necessary using statements in readme examples

Library name
Azure.Monitor.Query
Please describe the feature.
Not sure if this is a .NET decision or not, but it'd be great to mention somewhere the necessary using statments you need to execute the readme examples. Had to figure out myself that I needed using Azure and using Azure.Monitor.Query.Models to get the readme examples to work

This is a problem for all .NET client libraries. Issue https://github.com/Azure/azure-sdk-tools/issues/2438 will be used to track this feature request.


Multisig. Create multisig. Can proceed with empty signatories

Description
Example:
https://github.com/user-attachments/assets/e00c3f97-510f-409a-ab09-aec645840166
Steps to Reproduce

Go to Multisig creation flow
Select main account
Add signatories, but does not fill them with data
Click Continue

Expected Behavior
Can't proceed with empty signatories
Actual Behavior
Attempt to create Multisig
Environment
https://github.com/novasamatech/nova-spektr/commit/6ca515af94bd4d44ea25ada390bcc01455cd4bc4

Status verification: ✅


Create dependabot.yml

Enable dependabot for updates and security upgrades https://docs.github.com/en/code-security/supply-chain-security/managing-vulnerabilities-in-your-projects-dependencies/configuring-dependabot-security-updates
The dependabot settings have to be updated in the admin section.

Thanks!

@wiz need some admin here

@qustavo sorry just set you as maintainer, try now


compose: Fix bolding/italicizing after triple-clicking in Chrome.

Fix bolding/italicizing after triple-clicking in Chrome #19191
The bug

This commit makes the following changes

I have tested this with various input, and it's working correctly.

@andersk  Does this code changes remove the mutation part ? I added a local variable to avoid mutation.

I don't understand how this change can work; it seems to add a new function that is never called.

@timabbott The issue related to this PR was solved in another PR by @amanagr, this was the fix I implemented before the changes. Before that, I only implemented that if the last character of the selected text is a \n character, then pop the last character.
Thank you !!


Fixing shaders of OESVerticalStereo and OESHorizontalStereo #1671

Shaders OESVerticalStereo and OESHorizontalStereo were not ported for the 4.0 changes.
GearVRF DCO signed off by: Abhijit Jagdale<EMAIL_ADDRESS>

looks good.. we can merge this.

how was this tested?  (what app / videos?)  and on what hardware?

@thomasflynn I had modified gvr-sceneobjects demo and had changed VideoTypes in it.

was it tested on both Mali and Adreno?

@thomasflynn I tested on Adreno only.

ok, tested on Mali.  can verify the shaders compile and do not produce errors.  however, i do see this output every frame:
12-29 11:52:01.229 30675 30751 V gvrf    : DataDescriptor: mat4 u_bone_matrix[60]
I don't think that was introduced by this check-in, i'll merge this anyway.  But we should squash any per-frame log output that isn't an error.

Wait.  Maybe it was introduced by this check-in.  I do not see this log output with a video type of MONO.

ok, talked with @NolaDonato.  I'm going to go ahead and merge this and she's gonna figure out where that debug log is coming from and fix it.


[FR] git-daemon-export-ok

Would it be possible to add an option to ensure presence of git-daemon-export-ok file for public repositories and its absence for private ones? The presence of this file guides the git-daemon used to provide git:// protocol as to which repositories to actually expose.
AFAICT, using git-daemon to expose repos read-only in parallel with gogs works, but there is no distinction for private / public ones, so it exposes either none of them (cause the file is not present), or all of them (if run with --export-all).

See also #2950 for another problem related to Gogs making no distinction between private / public repos.

Looking at the code the support for adding/removing git-export-ok should be added to https://github.com/gogits/git-module, I suggest you file an issue there @herby

@strk Why there? It depends on the private/public setting of the gogs itself, it is not very much of a git operation... ping @Unknwon.

Because that's the module used to interact with the git repo.
So that module should expose a function to add/remove the git-daemon-export-ok
and Gogs itself should be using that function.
Ideally the module would also expose functions to set the repository ownership and permissions, to deal with #2950

I see.
Dňa 16. apríla 2016 19:10:37 CEST používateľ Sandro Santilli<EMAIL_ADDRESS>napísal:

Because that's the module used to interact with the git repo.
So that module should expose a function to add/remove the
git-daemon-export-ok
and Gogs itself should be using that function.
Ideally the module would also expose functions to set the repository
ownership and permissions, to deal with #2950

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/gogits/gogs/issues/2940#issuecomment-210860513

Hmm... any reference for git-daemon-export-ok, did not know about this feature of git before.

It's feature of git daemon, https://git-scm.com/book/en/v2/Git-on-the-Server-Git-Daemon.
无闻 wrote:

Hmm... any reference for |git-daemon-export-ok|, did not know about
this feature of git before.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/gogits/gogs/issues/2940#issuecomment-212583943

Thanks for the link. I think we need to let Gogs support git:// protocol first?

I don't know what do you mean by that. I asked you via comment on faq if I can run git-daemon in parallel and you said it was ok. This would just tell it which o es to expose and which not.
If you mean to support git:// protocol directly by gogs code, that would be completely different issue.

I agree there's no need for Gogs to support git:// protocol itself
(although it could be useful to allow adding an indication of git://
access method when available by external means).
On the other hand, having access mediated by different servers is
always a risk, unless all servers carefully agree on what kind
of access level to grant to the resources (I'm thinking about the
"require sign in" setting of Gogs for public repos, for example).
The usage of file-based configurations (like git-export-ok) is a good
way to encode permission levels at the filesystem level. Maybe Gogs
could use a similar mechanism for the "require-sign-in" config.

if I can run git-daemon in parallel and you said it was ok

Yes, if you run parallel, that's 100% OK, but now you ask Gogs to control private/public, and that is completely different issue.

??? Confused. Don't see "two steps".
But yes, I am asking about the option to add/remove git-daamon-export-ok file depending on whether repo is set private or public in gogs.
Is there some misunderstanding (you told "I think we need to let Gogs support git:// protocol first?" I don't know what you mean by that. No "support first" is needed, though I don't know what do you mean by that)? Just to add/remove the file that help git-daemon control the exposing, if used.

@herby Gogs does no support git:// provided by git-daemon, how should Gogs care/manage settings for it?

I don't know what's the communication problem here, but there must be some.
What I ask in this issue is the creation of one empty file for a public(ized) repo and deleting that file for private(ized) repo.
The use case is, of course, to allow to run git daemon in parallel (read-only) which works by your own words.
So I only ask for that one flag file management.
Is the problem that you must "declare that gogs supports git:// protocol" to implement the issue? I think not. Yoy can just add it for convenience of those who do use the protocol, but still not saying "gogs supports ...".
Or is there another problem? I am a bit desperate here to spot one, but I see you see it there, when I only ask for the silly adding/removing one specific file flagging the public state of repo, but you are always telling about supporting git protocol (you do not need to, git daemon does all the work).
Dňa 26. apríla 2016 5:56:46 CEST používateľ "无闻"<EMAIL_ADDRESS>napísal:

@herby Gogs does no support git:// provided by git-daemon, how
should Gogs care/manage settings for it?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/gogits/gogs/issues/2940#issuecomment-214605674

cc @bkcsoft : can you work on this one? I think it needs some changes in git-module as well.

Yeah sure, should be fairly simple :) Don't think I have to involve
git-module at all TBH

Done #3046
(@Unknwon and no need for fiddling in git-module :trollface:)

BTW if this https://github.com/bower/bower/issues/1841 ends up positively, maybe this issue could be put on hold, if needed (but I still did not get an answer). I only needed git:// protocol was only protocol allowed in bower.

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io.


SSD1306 Wrong contrast initialisation and display mode

In the function void ssd1306_init(void) the configuration seems wrong:
    uint8_t display_mode = 0;

#if defined CONFIG_LV_INVERT_COLORS
    display_mode = OLED_CMD_DISPLAY_INVERTED;
#else
    display_mode = OLED_CMD_DISPLAY_NORMAL;
#endif

    uint8_t conf[] = {
        OLED_CONTROL_BYTE_CMD_STREAM,
        OLED_CMD_SET_CHARGE_PUMP,
        0x14,
        orientation_1,
        orientation_2,
        OLED_CMD_SET_CONTRAST,
        display_mode,
        0xFF,
        OLED_CMD_DISPLAY_ON
    };

We can see that the double byte command OLED_CMD_SET_CONTRAST (SSD1306 datasheet rev 1.1 p.28) is followed by display_mode.
So the contrast is set to 0xA6 or 0xA7 depending on the display mode configured and the display mode isn't configurable.
The fix that worked for me is to invert display_mode and 0xFF:
    uint8_t conf[] = {
        OLED_CONTROL_BYTE_CMD_STREAM,
        OLED_CMD_SET_CHARGE_PUMP,
        0x14,
        orientation_1,
        orientation_2,
        OLED_CMD_SET_CONTRAST,
        0xFF,
        display_mode,
        OLED_CMD_DISPLAY_ON
    };

Can you please submit a Pull Request for this? Thanks!

Thanks! It's working for me so I close the issue!


fix: frontend code cleaup

AM-3256
:id: Reference related issue.
:pencil2: A description of the changes proposed in the pull request
:memo: Test scenarios
:computer: Add screenshots for UI
:books: Any other comments that will help with documentation
:man: :woman:@mentions of the person or team responsible for reviewing proposed changes
This is a nice example: https://github.com/gravitee-io/gravitee-access-management/pull/1822

No need to apply it on 4.4


Regression: Variables exposed from

Version
3.2.12
Reproduction link
sfc.vuejs.org/
Steps to reproduce
Open the reproduction and observe the error. Switch to v3.2.11 and observe that it works. Then comment the exported variable and uncomment the non-exported variable. Observe that you now get an error in v3.2.11. Switch to v3.2.4 and observe that it works.
What is expected?
Variables defined in

According to: https://github.com/vuejs/rfcs/blob/master/active-rfcs/0040-script-setup.md

The options passed to defineProps and defineEmits will be hoisted out of setup into module scope. Therefore, the options cannot reference local variables declared in setup scope. Doing so will result in a compile error. However, it can reference imported bindings since they are in the module scope as well.

it seems to be a known behavior.

The docs specify setup scope. My variables are defined in a regular script block so they're in module scope.

Error: [@vue/compiler-sfc] `defineProps()` in <script setup> cannot reference
locally declared variables because it will be hoisted
outside of the setup() function.
If your component options requires initialization in the module scope,
use a separate normal <script> to export the options instead.

<script>
export const bar = 14;
//const bar = 14;

export default {};
</script>

<script setup>
defineProps({
  foo: {
    type: Number,
    default: _bar,
  }
});
</script>

<template>
  <h1>{{ foo }}</h1>
</template>

would have worked and compiled to this without the compiler error.
/* Analyzed bindings: {
  "foo": "props",
  "bar": "setup-const"
} */
import { toDisplayString as _toDisplayString, openBlock as _openBlock, createElementBlock as _createElementBlock } from "vue"

export const bar = 14;
//const bar = 14;

const __default__ = {};

function setup(__props) {

return (_ctx, _cache) => {
  return (_openBlock(), _createElementBlock("h1", null, _toDisplayString(__props.foo), 1 /* TEXT */))
}
}

const __sfc__ = /*#__PURE__*/ Object.assign(__default__, {
  props: {
  foo: {
    type: Number,
    default: bar,
  }
},
  setup
})
__sfc__.__file = "App.vue"
export default __sfc__


Use a better docker image

And we add another quick fix in the same PR to fix the docker build.
Stripping off the "v" from the version results in a 404 during docker build.

/cc @cpanato


scheduleExtraUpdate does not exist in Doctrine\ODM\MongoDB\UnitOfWork

I get the error
Attempted to call method "scheduleExtraUpdate" on class "Doctrine\ODM\MongoDB\UnitOfWork"

gedmo/doctrine-extensions/lib/Gedmo/Loggable/LoggableListener.php - line 141

The method "scheduleExtraUpdate" used in

lib/Gedmo/Tree/Strategy/ODM/MongoDB/MaterializedPath.php
lib/Gedmo/SoftDeleteable/SoftDeleteableListener.php
lib/Gedmo/Loggable/LoggableListener.php
lib/Gedmo/Tree/Strategy/AbstractMaterializedPath.php

but it does not exist in Doctrine\ODM\MongoDB\UnitOfWork

what version of ODM?

latest dev-master

latest dev-master

it seems that it has been deleted there: https://github.com/doctrine/mongodb-odm/compare/f9d26e2...master#diff-ae2c9f4b58c612dce08a0f60ff683aecL1538

well if you have time, you can try to submit a pull request with a fix. an alternative to schedule extra update.. not sure when I have time to look into it

Is this possible to replace scheduleExtraUpdate with something different here in Extensions? Justification for removal was "this is marked as internal and we're not using it for some time"

If I'm not mistaken the scheduleExtraUpdate was used to create reference between inserted item and its log, right? In ODM ids are assigned at the time of persist so there is no need to call scheduleExtraUpdate just to update the field, id could be passed to log entry upfront. Also this could be changed to use @ReferenceOne() without targetDocument specified which allows you to link anywhere, but I guess this is bigger change and is not feasible.

well, if someone is suffering from this one, you can open a PR? not sure when I will be able to submit a fix..

Cross referencing with #1346

@malarzm @l3pp4rd atm master of mongo-odm is not usable anymore with e.g. softdeletable behaviour ...

@phiamo are you checking with DoctrineExtensions with #1346 merged?

@malarzm i used a composer update.
i added gedmo/doctrine-extensions dev-master too and it works, before it was pulled in by stof/doctrine-extensions, which seemed to lead to a more stable version than master, without this fix.

ok, need to publish a tag, materialized path may have some issues, not sure whether it will work well with mongo

composer update gedmo/doctrine-extensions

yeah works like a charm :-)


fix: Disable knative liveness and readiness probs

Fixes #N/A
Description

We are seeing issues were knative readiness and liveness probs are require to use port 8080. If port 8080 is being utilized we see that user will have issues with karpenter start up. https://github.com/aws/karpenter/issues/4145

How was this change tested?

Manually tested

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 81.42%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6994

Relevant Lines:
8590

💛  - Coveralls


Windows shell integration system settings

This is the Atom side of atom/settings-view#811 that provides the parts necessary for that one and facilitates;

Only installing the file handler by default (no more context menus by defaut but you keep them if you already have them)
Allows side-by-side of Atom.exe and AtomBeta.exe which can set, unset and upgrade independently

Allows side-by-side of Atom.exe and AtomBeta.exe which can set, unset and upgrade independently

Do we know when this is set to release? As in which beta version would be the first I can install side by side with stable? I am very interested in some 1.10 features but wouldn't want to lose safety of a stable install on main workstation.


limit the level or depth of search to top level "require()"

Hi
I'm using this library to find problems related to circular dependencies. Is there any options for limiting  madge to just  top level require statements in js files?
for example I need to exclude a require statement inside a function like this:
// a.js
function f(){
    const b = require('./b');  // this will not cause a cyclic dependency problem
}
const bb = require('./b'); // but this one does!!

//b.js
const a = require('./a');

thank you very much
This library helped me to find cycles and after that I solved the problems manually

"aside from short-circuiting parts of the dependency-tree generation as a performance optimization." the problem is that I need to audit a large codebase to only the depth of 1, and this restriction completely bars me from being able to use this package because it will take far too long.

In #328 some want to detect dynamic imports, which contradicts this issue. Maybe we should add an option?
I think we can see the cyclic dependency problem in test / runtime so we can(?) ignore this case.


[BUG]  Please fix the contact page

Description
In the footer contact link not working. showing 404 error.a
Screenshots
https://user-images.githubusercontent.com/88102392/229873090-bef3982a-d522-4bea-b76f-561be400b75a.mp4
Browser 🥦
Brave
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no)

Oh wow, i haven't noticed it.
Assigining this to you !

hi @IAmTamal should I add your social profile links or GitHub discussion link?


[#1043] Implement DownloadAction

Closes #1043

DownloadAction tests
BlockDownloader mock

This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation).  For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[x] Automated tests: Did you add appropriate automated tests for any code changes?
[x] Code coverage: Did you check the code coverage report for the automated tests?  While we are not looking for perfect coverage, the tool can point out potential cases that have been missed.
[ ] Documentation: Did you update Docs as appropiate? (E.g README.md, etc.)
[ ] Run the app: Did you run the app and try the changes?
[ ] Did you provide Screenshots of what the App looks like before and after your changes as part of the description of this PR? (only applicable to UI Changes)
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?You will find manual testing guidelines under our manual testing section
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage befor and after your changes and when possible, leave it in a better place. Learn More...
[ ] Documentation: Did you review Docs, README.md, LICENSE.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data.

@pacu these new tests for State Machine Actions are done in OfflineTests context. The Network and DarkSide tests are broken. We know about it and Michal is working on fixes in parallel. So this task itself is outside of Network/Dark side.


Allow authorized users to add a marker with a Video from SHOMREI HADERECH

Allow authorized users to add a marker with a Video from SHOMREI HADERECH.
Using right click menu.

SH1.zip

Do they provide a link to a video which was already uploaded or do they provide a file?


Segmentation Fault when gbm device doesn't outlive gbm buffer object

$ uname -a
Linux ayrtonslaptop 6.3.8-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 14 Jun 2023 20:10:31 +0000 x86_64 GNU/Linux

https://github.com/Smithay/gbm.rs/blob/8d3cb5a6520c5f1bef667b007afee0e73f480e98/src/buffer_object.rs#L493
Is causing a segmentation fault on my system when the gbm::Device is dropped before the buffer object. I'm not using any unsafe code so I don't think this should be allowed to happen.
Let me know if you need any more details.

No, that shouldn't happen, see https://github.com/Smithay/gbm.rs/pull/25 for a potential solution.


Document how to check constraint conformance etc.

Specifically, add docs for the new system tables that provide insight
into:

Whether data is under-replicated or unavailable

Violations of data placement requirements

Which localities have data that is at risk in the event of node
failure

Fixes #4730.
Addresses #2957, #5636.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fe6b1381846d3805640498fd3953b5d3a300e4eb/
Edited pages:

v19.2/admin-ui-replication-dashboard.md
v19.2/configure-replication-zones.md
v19.2/verify-constraint-conformance.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cc8df51c4daa247369733db428d5a919729ccaaf/
Edited pages:

v19.2/admin-ui-replication-dashboard.md
v19.2/configure-replication-zones.md
v19.2/run-replication-reports.md

So I'd be inclined to do something to make you happy sooner rather than later, but the question is what. That's why I was asking tour opinion about future views (or perhaps even future virtual tables) in the system database. Cause if that's a possibility, then it does give us a migration path and so people can probably just start using these names and we don't have to warn them.

The thing is, the UX design for this feature was simply not done. It's not that it was incorrect or that we were lacking the proper directions etc. I'd argue that it was simply not done, as in, nobody really cared about our API stability guidelines, the experimental-beta release process, etc.
There's a process failure right there, and I am hard at work to figure out what to do about this so it does not happen in the future.
In the meantime the proper thing to do is to acknowledge that the work was rushed and our current standard way to acknowledge this is to mark the thing as "experimental".
But I don't have a quick answer for you as to what's going to happen afterwards i.e. how to make it non-experimental. There's something to be said about publicizing crdb_internal because there is a huge ask about this. We also have huge precedent about introducing SHOW porcelain, and I am sincerely surprised this has not happened here from the get go. Oh well.
There are multiple things to be said against publicizing system, which I will come back to (later).
So in the meantime, let's keep it at the warning and the disclaimer.

The thing is, if indeed we don't want people using the system.replication_foo names, then I don't know if we should have pages and pages of documentation about them.

That's actually a legitimate concern. If @awoods187 wasn't so keen on pushing docs on this new feature, so it can be marketed/advertised as a flagship new feature, I'd also recommend not documenting it — because it was rushed and it's not polished enough yet.
But I do also acknowledge that there is so much push from sales and support to have something like this feature that it'd be silly to be completely silent. I think @rmloveland did fantastic work here and all the content in these pages will naturally adapt (with a simple substitution) when we have the adequate crdb_internal views / tables / built-ins.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e70ec203a2317509cf0ee301ec9027798e3fb440/
Edited pages:

v19.2/admin-ui-replication-dashboard.md
v19.2/architecture/overview.md
v19.2/configure-replication-zones.md
v19.2/run-replication-reports.md
v19.2/start-a-node.md

@andreimatei are you ok with this doc after the latest round of changes?
If so I'll pass along to Docs team for review so we can have it merged by next week's release.
If not, I'm happy to make any necessary updates.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/372ecb174b3fca438abb368df1552de69f0a73aa/
Edited pages:

v19.2/admin-ui-replication-dashboard.md
v19.2/architecture/overview.md
v19.2/configure-replication-zones.md
v19.2/query-replication-reports.md
v19.2/start-a-node.md

@ericharmeling I think the engineering review is winding down, this should be ready for a look sometime Monday AM. 🤞

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/167a87fabdce7e6239dddf24586d3837916d0021/
Edited pages:

v19.2/admin-ui-replication-dashboard.md
v19.2/architecture/overview.md
v19.2/configure-replication-zones.md
v19.2/query-replication-reports.md
v19.2/start-a-node.md

Thanks Jesse!
Created https://github.com/cockroachdb/docs/issues/5831 to track adding linkage, etc.

I just saw "Query Replication Reports" used in a document as the name of the feature (which is "replication reports"). The fact that "query" here was supposed to be a verb and not a noun got lost.

Bummer!  Understandable error, though.

What do you think about renaming this to just Replication Reports? It looks like not all pages in these guides have actions in their titles.

I'm fine with it.  @jseldess do you have any objection as long as we put in a redirect from the current name?

Btw, do you think there's another place besides Guides in which we should list these tables?

As far as the tables specifically, I'm not sure - I don't think we document system tables anywhere.
However, I just took a look through some other docs, and I think we should write something about these reports on the main Configure Replication Zones page.  Maybe a new section on that page that talks about the replication reports and links to the longer doc.  What do you think of that approach?

Created https://github.com/cockroachdb/docs/issues/6857 to work on the things mentioned in my previous note.  Please comment over there if you have thoughts/opinions.


Issue #62 - Added test checking icon for random drone generator

What this does
This pull request addresses issue #62 - Adds a test to simulation.drone.spec.js to ensure that generateRandom() returns an object that contains an icon property.
Thanks for the opportunity to get my first PR!

Looks great! Just merged it. 🎆
My apologies that it took so long.
I hope this is the first of many contributions to open source for you.
Please join us on our contributors channel where we discuss the project, and other opportunities to get involved with open-source.


[Event Request] OnPostBankAccOnBeforeCheckLedgEntry2Modify - missing parameter it attempts to modify

🕮 Describe the issue
codeunit 12 Gen. Jnl.-Post+Line
🔧 To Reproduce
Event as called:
OnPostBankAccOnBeforeCheckLedgEntry2Modify(CheckLedgEntry, BankAccLedgEntry);

Existing procedure:
[IntegrationEvent(false, false)]
local procedure OnPostBankAccOnBeforeCheckLedgEntry2Modify(var CheckLedgEntry: Record "Check Ledger Entry"; var BankAccLedgEntry: Record "Bank Account Ledger Entry")
begin
end;

📣 Expected behavior
New Event call:
OnPostBankAccOnBeforeCheckLedgEntry2Modify(CheckLedgEntry, CheckLedgEntry2, BankAccLedgEntry);

New procedure:
[IntegrationEvent(false, false)]
local procedure OnPostBankAccOnBeforeCheckLedgEntry2Modify(CheckLedgEntry: Record "Check Ledger Entry", var CheckLedgEntry2: Record "Check Ledger Entry"; var BankAccLedgEntry: Record "Bank Account Ledger Entry")
begin
end;
// no var on CheckLedgEntry, but yes var on CheckLedgEntry2

Screenshots
Additional context
based on event name (..."BeforeCheckLedgEntry2Modify"), I would presume the event would allow you to make additional adjustments to CheckLedgEntry2, but that record is not in the parameters. My suggestion would allow updates to CheckLedgEntry2.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11880.


The weather is not randomized following the input config of the init function

ISSUE TEMPLATE

[ ] I have marked all applicable categories:

[ ] exception-raising bug
[ ] RL algorithm bug
[ ] system worker bug
[ ] system utils bug
[ ] code design/refactor
[ ] documentation request
[x] new feature request

[ ] I have visited the readme and doc
[ ] I have searched through the issue tracker and pr tracker
[ ] I have mentioned version numbers, operating system and environment, where applicable:import core, torch, sys
print(core.__version__, torch.__version__, sys.version, sys.platform)

In the following code in carla_simulator.py, it seems that the weather is not randomized following the input config of the init function.

You can see that the config specifies a subset of the whethers.

It is also possible that I misunderstand the "weathers" in config. Because I also find "whether" in the config.

If you are using benchmark setting (i.e. FullTown01-v1 or NoCrash), the default weather config in simulator will be blocked. So the actual weathers will be decided by benchmark settings.
We also provide a 'weathers' key in benchmark collector\evaluator which is used to change the default weather setting in benchmark. For example a user wants to run FullTown01's routes with a provided list of weathers not defined in existed benchmark settings. It can be manually set by change the 'weathers' key in benchmark collector\evaluator.
So in short the priority of weather configs should be: benchmark config ('weathers' in benchmark) > benchmark default > simulator config ('weather' in simulator)


Validate that layer source analysis exist

This closes #12549.

Ok, this is the server side validation for a layer: it won't accept any source if source doesn't exist previously as a visualization analysis.
The first error comes quick. STR:

Create a map with a dataset (mine was a simple one with two points, but that shouldn't be relevant).
Add a centroid analysis.
You get this error

The failing PUT is the edition of the layer, and the next PUT is the analysis change. The first PUT tries to set the new a1 analysis as source, but it doesn't exist yet. It will after the second PUT, which adds it.
@javitonino take a look at the code. Do you think that this is a valid approach? I'll mention xavijam after that so we discuss how to procede.

Approach using validations looks good to me. But we should also add the same validation to widgets source_id field and to the analysis model as well (the case when the top node of an analysis is removed before updating the layer should fail).

Ok. I'll continue working on the backend side. Nevertheless, I think that we need a frontender on this to fix the first problem once you enable validations. I'd work iteratively on this. What do you think, @xavijam , how do you want to proceed?

I feel we already changed that @juanignaciosl, didn't we @rubenmoya ?

I just merged master and the STR are the same.

Hi! Sorry for being late to the party.
We did changes related to the requests order in user-actions, but I'm not sure if that changes fix this problem, since this is creating a new analysis, and our changes were related to moving analysis out of layers if I'm not mistaken.

@rubenmoya , @xavijam then, if we want to add the validations, we need to fix that. I've just pushed the latest changes for sources validation, including analysis, layers and widget validations (what could go wrong?). I'd need help with the frontend fix for previous STR in order to keep doing the basic manual testing, even before CR.

Closing this. cc @javitonino


Fixing filter when labeling is disabled

Hello,
I am using docker swarm and I have deployed the Ouroboros.
It doesnt do anything because we dont use ouroboros labes and they are filtered by default.
In service logs of Swarm I can see: No services monitored
I believe it is because in Service class the services are filtered no matter what the config is (refering to https://github.com/pyouroboros/ouroboros/wiki/Usage#label-enable).
This pull request should fix it

Thoughts on this @DirtyCajunRice

Going to decline this as a swarm infers a large amount of containers and a stronger understanding of docker. If you are using swarm you should be able to label your containers appropriately. Thank you though.

@DirtyCajunRice: In documentation: https://github.com/pyouroboros/ouroboros/wiki/Usage#label-enable you have a explicit option which this pull request fixes, else it does not work. Do you care to reconsider?