ignore all type of thread reports to determine concierge report

Details
This PR fixes the logic (i.e here) for identifying a concierge chat. The current logic looks at the participant account id to determine if Concierge account id is present in it. However, the concierge account id would also be a participant in all its thread reports. So, while we need to check if the report is a thread report we do not have to explicitly check for chat type reports as any thread report should not be considered as a concierge report. We achieve this by using isThread utility instead of isChatThread.
Fixed Issues
$ https://github.com/Expensify/App/issues/45700
PROPOSAL:
Test
Prerequisite: Use an account which
a) Have Concierge as onboarding chat
b) Have set up Track and Manage Expenses onboarding step
c) Is in Free trial
Steps:
1	Verify that the LHN for Track an Expense report does not display the Free Trial Badge
2	Click on the Track an Expense
3	Verify that the report header does not display the Free Trial Badge

[x] Verify that no errors appear in the JS console

Offline tests
Same as the Steps in Tests Section.
QA Steps
Same as the Steps in Tests Section.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Desktop
https://github.com/user-attachments/assets/ae369303-7615-47fb-8455-9b8b00094d48

iOS
https://github.com/user-attachments/assets/c1b8e481-8a39-4c98-ac22-8d818a699358

Android
https://github.com/user-attachments/assets/6eae5dbd-d996-4028-9fd9-02e68385f6be

Mobile Web - Chrome
https://github.com/user-attachments/assets/4945a77b-b472-495e-9afb-a4e928b1da0a

Mobile Web - Safari
https://github.com/user-attachments/assets/530311ba-7662-4f38-b686-f29c31123123

Web
https://github.com/user-attachments/assets/80d5b733-9d05-49c3-b279-3fb318a5d7e8

@fabioh8010 Please review.
The root cause though turned out to be within isConciergeChatReport as the logic to determine the concierge chat turned out to be faulty with the introduction of onboarding tasks for guided setup. Ideally, we should have caught this as part of guided setup implementation. But anyway I think it’s worth to fix this in isConciergeChatReport than solving this within isChatUsedForOnboarding. This will fix additional issues like not seeing Members in Report Details Page for tasks coming out of Concierge chat as shown in test video below. For a normal chat threads for Concierge chat though Members are displayed.
https://github.com/user-attachments/assets/f3a94d67-e6d6-41d5-accf-9e1e5a6ed6e7

Is possible that it could happen to Expensify chat too? If the checklist is sent there and the user create threads or something?

The check for Expensify chat aka System chat is pretty clean here as it depends on type of chat. So, this issue does not occur.
However, the check for Concierge chat depends on the presence of concierge account id which is why we have the issue here as the thread reports will also have this id.

Looks good then, I've also checked here and confirmed the Expensify DM is not affected by this issue

@mountiny Since the change is small can you please do the final review and take this further?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.10-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


does not work when it is a nested struct

e.g.,
jsonmesh=struct('MeshNode',{"MeshNode",[0 0 0;1 0 0;0 1 0;1 1 0;0 0 1;1 0 1;0 1 1;1 1 1]},...
'MeshElem',[1 2 4 8;1 3 4 8;1 2 6 8;1 5 6 8;1 5 7 8;1 3 7 8],...
'MeshSurf',[1 2 4;1 2 6;1 3 4;1 3 7;1 5 6;1 5 7;...
2 8 4;2 8 6;3 8 4;3 8 7;5 8 6;5 8 7],...
'MeshCreator','FangQ','MeshTitle','T6 Cube',...
'SpecialData',[nan, inf, -inf])

@andyandhope, can you rephrase the question title and body - what does not work? what codes do I need to reproduce what you see? what version of JSONLab, is it matlab or octave?

I am using the most recent version of JSONLab in matlab.
i try to conver the 'nested' struct varible as json. It seems not work when the structure object is a nested struct.
for example:
jsonmesh = struct('MeshNode', {'MeshNote', [0,0,0; 1,0,0;1,1,0]})
I am not sure if i make myself clear.

@andyandhope, first of all, the issue you are reporting, if I understood you correctly, is not JSONLab's problem, but a general matlab utility question.
if you are trying to create a "nested struct", your above command is not going to do it. what you wrote is not a nested struct, but a struct array - if there is a cell element inside a struct(), struct will create an array of struct.
if you want it to be a nested struct, you should use struct() as the value instead of a cell array. see the difference below
>> jsonmesh = struct('MeshNode', {'MeshNote', [0,0,0; 1,0,0;1,1,0]})

jsonmesh =

  1×2 struct array with fields:

    MeshNode

>> jsonmesh = struct('MeshNode', struct('MeshNote', [0,0,0; 1,0,0;1,1,0]))

jsonmesh =

  struct with fields:

    MeshNode: [1×1 struct]

closing as it is irrelevant to JSONLab functions


Add brute force importance in stellargraph library

Description
Currently the brute-force approach of calculating node/link importance is implemented in the demo notebooks, however this functionality could be moved into the library:

it will remove duplication of this logic across the demos
it makes it easier for us to compare the brute force vs integrated gradient approaches in tests
the brute force approach can be an option for users when using any of the other algorithms that do not currently have the integrated gradient approach implemented

User Story
As a data scientist
I want to use the brute force importance calculations in stellargraph
So that compare with IG importances or use it for algorithms that don't have IG implementations
Done Checklist

[ ] Produced code for required functionality
[ ] Tests written and coverage checked
[ ] Code review performed
[ ] Documentation on Google Docs  (if applicable)
[ ] Documentation in repo
[ ] Version number reflects new status
[ ] CHANGELOG.md updated
[ ] Team demo

After having thought about and experimented a bit, I'm now thinking of doing a few pieces leading up to this work that roughly seems to me like it'd work for methods that use full-batch or sampled generators.
Initially wanted to just create a corrupting-wrapper sort of thing around the StellarGraph class (https://github.com/stellargraph/stellargraph/pull/1217) but it ended up looking a bit too fragile to me given that there's no guarantee that things don't start breaking if you change the underlying graph in any given stellargraph pipeline.
So now, the eventual resulting API I'm thinking for brute force importance is something like:
model = ... # some node model
generator = ... # some node generator

target_node_id = ... # node to make predictions for
target_class = ... # class for which you want to compare prediction scores for (for multi-class classification)
node_to_exclude = ... # you're wondering how important this node is

# baseline prediction without any "corruption"
pred_baseline = model.predict(generator.flow([target_node_id]))[0]

# sequence with missing node
seq = generator.flow_exclude_node([target_node_id], node_to_exclude)
pred_exclude_node = model.predict(seq)[0]

# take the difference to get the importance of excluded node on the target node
importance_score = pred_baseline[target_class] - pred_exclude_node[target_class]

1. Implement flow_exclude_node and flow_exclude_edge for full batch generators only
This looks like it'd be relatively straightforward for full batch generators, since their flow methods simply create a FullBatchSequence using the feature and adjacency matrices
class FullBatchGenerator:
    def flow_exclude_node(ids, node_to_exclude):
        ...
        return FullBatchSequence(corrupted_features, self.Aadj, None, node_indices)
    def flow_exclude_edge(ids, link_to_exclude):
        ...
        return FullBatchSequence(self.features, corrupted_adj, None, node_indices)

2. Refactor functionality of GraphWalk classes to allow easier switching of underlying graph:
I'm thinking this would be easiest by converting GraphWalk classes to just be "pure" functions instead (SampledBreadthFirstWalk, SampledHeterogeneousBreadthFirstWalk, DirectedBreadthFirstNeighbours). I think the idea behind them being classes currently is only for them to share a little bit of validation code and as a form of logical grouping. The only internal "state" that the classes keep track of is its random state, which can be taken out and managed elsewhere and passed into the function each time (SeededPerBatch might be a good place). This then allows for step 2...
3. Refactor Sampled generators to allow for excluding nodes/edges:
I'm thinking we can take sample_features out from each subclass generator of BatchedNodeGenerator and BatchedLinkGenerator as a "pure" function that takes in whatever it needs access to.
For example for HinSAGENodeGenerator this could be something like
def hinsage_batch_features(head_nodes, graph)

# or if we update `get_neighbors` to handle filtering by types
def hinsage_batch_features(head_nodes, get_node_features, get_neighbors)

This would allow us to define a "corrupt" version of it by passing in corrupt versions of the graph, for example:
class GraphSageNodeGenerator:
    def flow_exclude_nodes(self, node_ids, node_to_exclude):
        # validation/pre-processing from .flow
        ...

        def node_features(nodes, node_type):
            # replace all instances of `node_to_exclude` from `nodes` with -1 then call neighbors
            ...
        def batch_features(head_nodes, batch_num):
            return graphsage_batch_features(head_nodes, node_features, self.graph.get_neighbors)

        return NodeSequence(batch_features, self.batch_size, node_ilocs)


Boolean text with "multiple strings" (different strings for TRUE and FALSE) is reversed

As reported here:
https://forums.jki.net/topic/3518-boolean-text-issue-in-localizer-tool-kit/

Fixed in 1.0.2


Implement Mount\Umount ubiquity interfaces for SCBE

uses the block_device_utils and also adjust the remote detach function to apply to block storage as well (we should first clean multipath device and only then conduct the detach process).
How to test
run a container with volume and make sure the volume on the storage system has been mapped to the host. then stop the container and make sure the volume on the storage is no longer mapped.

@liortamari  already review the code so i move the ticket to waiting for testing.


vagrant rsync command does not work

This is likely related to #85. The rsync subcommand does not currently work w/ the google provider. The plugin does not generate the .vagrant/machines/default/google/synced_folders file that the vagrant rsync command uses to perform the sync.

@bryanwb The change has been reverted due to NFS issues: https://github.com/mitchellh/vagrant-google/issues/94
I was hoping there is an official way to fix this, but considering that upstream bug is not getting update a workaround will probably be needed. Something like a custom action "FixSyncedFolders" which would force disable NFS with each folder.
It's on my list of things to fix when I have some cycles.
Meanwhile - patches are very welcome and I can help with code review.

@Temikus tks for the quick reply. I have a workaround atm, but I'll try to come back to this

@numediaweb Didn't have time to do this yet, I'm afraid. Will be happy to give you pointers or take a look at a PR, if you're willing to do one.
Re:workaround - depends on what you're trying to do. The rsync command is not available but folders do sync via rsync correctly on "up". You need to resync without reprovisioning?

@numediaweb @bryanwb  This should be fixed, new release that uses built-in rsync is now available.


Nerdfont Icons partially cut on workspaces (i3)

active workspaces affected
all of a sudden, the Icon displaying the active workspace, and ones which have notifcations on it are displayed incorrectly.
Inactive workspaces are displayed correctly.
Screenshot:

Expected behavior:
display all icons in the same way.
Actual behavior:
active workspace icon is partially cut.
What actually happens
Was it working before?
yes, changed all of a sudden. Suspect a Nerdfont update.
Version                   : 2.1.0-1 (installed March 20)
Installed on:         : Fr 20 Mar 2020 21:33:35
To Reproduce
A minimal but complete config with which the problem occurs:
; MWE for Issue creation
;

[colors]
background = #ffffff

foreground = ${xrdb:foreground}
foreground-alt = ${xrdb:color7}

; Mappings from Xresources

color0 = ${xrdb:color0}
color1 = ${xrdb:color1}
color2 = ${xrdb:color2}
color3 = ${xrdb:color3}
color4 = ${xrdb:color4}
color5 = ${xrdb:color5}
color6 = ${xrdb:color6}
color7 = ${xrdb:color7}
color8 = ${xrdb:color8}
color9 = ${xrdb:color9}
color10 = ${xrdb:color10}
color11 = ${xrdb:color11}
color12 = ${xrdb:color12}
color13 = ${xrdb:color13}
color14 = ${xrdb:color14}
color15 = ${xrdb:color15}

primary = ${xrdb:color3:#fff}
secondary = ${xrdb:color4:#e60053}
alert = ${xrdb:color5:#bd2c40}
warning = ${xrdb:color1:#ff8800}

[bar/mwe]
width = 95%
height = 25
offset-x = 2%
radius = 2
module-margin = 2

font-1 = SauceCodePro Nerd Font:pixelsize=13;1
font-0 = "Google Sans Medium:size=10;3"
modules-left = i3
tray-position = right
tray-padding = 2
override-redirect = true

cursor-click = pointer
cursor-scroll = ns-resize

[module/i3]
type = internal/i3
format = <label-state> <label-mode>
index-sort = true
wrapping-scroll = false

ws-icon-0 = 1;
ws-icon-1 = 2;
ws-icon-2 = 3;
ws-icon-3 = 4;ﭮ
ws-icon-4 = 5;

label-mode-padding = 2
label-mode-foreground = ${colors.color6}
label-mode-background = ${colors.color3}

; focused = Active workspace on focused monitor
label-focused = %icon%
label-focused-background = ${colors.color1}
label-focused-foreground = ${colors.color7}
label-focused-underline = ${colors.background}
label-focused-padding = 2

; unfocused = Inactive workspace on any monitor
label-unfocused = %icon%
label-unfocused-padding = 2
; visible = Active workspace on unfocused monitor
label-visible = %icon%
label-visible-background = ${self.label-focused-background}
label-visible-underline = ${self.label-focused-underline}
label-visible-padding = ${self.label-focused-padding}

; urgent = Workspace with urgency hint set
label-urgent = %icon%
label-urgent-background = ${colors.color7}
label-urgent-padding = 2

Polybar Log
launched MWE with polybar mwe -c ~/.config/polybar/mwe --log=trace
* Loading config: /home/h1ghrise/.config/polybar/mwe
- config: Current bar section: [bar/mwe]
* Loaded monitor eDP1 (2160x1440+0+0)
* Bar geometry: 2052x25+43+0; Borders: 0,0,0,0
- bar: Attach X event sink
- bar: Attach signal receiver
- controller: Install signal handler
- controller: Setup user-defined modules
* Found matching X resource "color1" (value=#C65A56)
* Found matching X resource "color7" (value=#cfc7d1)
* Found matching X resource "color1" (value=#C65A56)
* Found matching X resource "color7" (value=#cfc7d1)
* Found matching X resource "color3" (value=#395987)
* Found matching X resource "color6" (value=#7289B3)
* Starting application
- controller: Main thread id = 1
* Starting module/i3
* Entering event loop (thread-id=1)
- module/i3: Thread id = 2
* Eventqueue worker (thread-id=3)
- bar: Create renderer
- renderer: Get TrueColor visual
- renderer: Allocate colormap
- renderer: Allocate output window
- renderer: Allocate window pixmaps
- renderer: Allocate graphic contexts
- renderer: Allocate alignment blocks
- renderer: Allocate cairo components
- renderer: Load fonts
* Configured DPI = 96x96
* Loaded font "Google Sans Medium:size=10" (name=Bitstream Vera Sans, offset=3, file=/usr/share/fonts/TTF/Vera.ttf)
* Loaded font "SauceCodePro Nerd Font:pixelsize=13" (name=SauceCodePro Nerd Font, offset=1, file=/usr/share/fonts/TTF/Sauce Code Pro Nerd Font Complete.ttf)
* Bar window: 0x0800001
- bar: Reconfigure window
- bar: Set window WM_NAME
- bar: Set window _NET_WM_WINDOW_TYPE
- bar: Set window _NET_WM_STATE
- bar: Set window _NET_WM_DESKTOP
- bar: Set window _NET_WM_PID
- bar: Map window
- bar: Received expose event
- bar: Draw empty bar
- bar: Setup tray manager
- tray: Find systray selection atom for the default screen
* Activating tray manager
- tray: Create tray window
* Tray window: 0x0800008
- tray: Restacking tray window
- bar: Set window WM_NAME / WM_CLASS
- tray: Set window WM_PROTOCOLS
- tray: Set window _NET_WM_WINDOW_TYPE
- tray: Set window _NET_WM_STATE
- tray: Set window _NET_WM_PID
- tray: Set window _NET_SYSTEM_TRAY_VISUAL
- tray: Set window _NET_SYSTEM_TRAY_ORIENTATION
- tray: Set _NET_SYSTEM_TRAY_COLORS to ff000000
- tray: Change selection owner to 0x0800008
- tray: visibility_change (state=1, activated=1, mapped=0, hidden=0)
* module/i3: Rebuilding cache
- bar: Force update
* Redrawing bar window
- renderer: flush(1 geom=78x25+0+0, falloff=0)
* Notifying pending tray clients
- tray: Received client_message
* Processing docking request from 0x140006b
- tray: Get client _XEMBED_INFO
- tray: Update client window
- tray: Configure client size
- tray: Add client window to the save set
- tray: Reparent client
- tray: Send embbeded notification to client
- tray: Map client
- tray: Received client_message
* Processing docking request from 0x0c00145

Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

WM: i3
Distro:  OS: Manjaro Linux x86_64, Kernel 5.5.11-1-MANJARO
Output of polybar -vvv:

polybar 3.4.2

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -fno-plt -Wall -Wextra -Wpedantic -O3 -DNDEBUG
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now

Additional context
Fonts are used system-wide, and have no display issues somewhere else.


Fixed requested_authn_context config

There can be multiple AuthnContextClassRef, the previous implementation didn't took that into consideration.

@pandafy please can you rebase to dev branch?


Dunfell updates for Toradex

Just a few minor things for Toradex builds on Dunfell.

@TheYoctoJester can you give this a review?


Allow to select all accounts when accepting dApp connection

Seems that nobody has created a PR for this, so I try to contribute this...
Usage: cy.acceptMetamaskAccess(true);

hi @shawnwang0715, can you add 1 fix in this PR for 2 updated selectors?
code
pages/metamask/notification-page.js
const confirmSignatureRequestButton = `${notificationPage} .request-signature__footer__sign-button`;
const rejectSignatureRequestButton = `${notificationPage} .request-signature__footer__cancel-button`;

should be changed to
const confirmSignatureRequestButton = `${notificationPage} .signature-request-footer :last-child`;
const rejectSignatureRequestButton = `${notificationPage} .signature-request-footer :first-child`;

because without that method confirmMetamaskSignatureRequest() fails.

@kabaneridev I added the code you suggested. But did my PR break the confirmMetamaskSignatureRequest() feature? Why?

Hi, I am also depending on this feature, since I want to test my dapp with both a admin account (account 2) and a regular user (account 3), but I can only connect to one of both, and if switching to the other, it is not connected to the dapp.
Any workaround for that issue?
Cheers Max

hi @shawnwang0715, can you add 1 fix in this PR for 2 updated selectors?
code pages/metamask/notification-page.js
const confirmSignatureRequestButton = `${notificationPage} .request-signature__footer__sign-button`;
const rejectSignatureRequestButton = `${notificationPage} .request-signature__footer__cancel-button`;

should be changed to
const confirmSignatureRequestButton = `${notificationPage} .signature-request-footer :last-child`;
const rejectSignatureRequestButton = `${notificationPage} .signature-request-footer :first-child`;

because without that method confirmMetamaskSignatureRequest() fails.

actually, with the changes it fails for me, but with the original version:
const confirmSignatureRequestButton = `${notificationPage} .request-signature__footer__sign-button`;
const rejectSignatureRequestButton = `${notificationPage} .request-signature__footer__cancel-button`;

it works

Hey @shawnwang0715, thank you very much for contribution. Sorry for late response, I have been affected by situation on Ukraine, so I couldn't work past 2 weeks.
Cheers,
Jakub.

It has been released as<EMAIL_ADDRESS>

@drptbl thank you so much. I hope you are all safe over there!


Quick question:What is the reason for Ciphey to not work with Windows Py3.9+?

Idea
Can we attempt to fix it?
Is this a python problem or a c++ problem?
If its strictly c++ compilation problem we can try rust for those parts.
Since compiling numeric intensive in rust has similar performance,
Pros
If we could solve it then we can make it works in windows ,which make the notice>
Ciphey can only work in py3.7&3.8 in windows not needed.
Cons
may need to take a look at rust py and make the cipheycore more complex.

Hi!
We are actually rewriting Ciphey entirely in Rust over on https://github.com/bee-san/Ares
:)

https://github.com/Ciphey/Ciphey/issues/764 :)

I see hahaha,nice well I will just close this issue and try out ares instead.


delete k8s sidecar injector

I'm not the owner of the plugin but this should go away and looks good.

I'm going to create a redirect instead of deleting it outright.


Try to get HomDir even $HOME is not available

Sometimes we would clean up all environment variables.

Thanks your PR!
But user.Current() uses CGO AFAIK, so this library will fail on cross compile.


Support binary data type in build_struct_array.

Which issue does this PR close?
Closes #701
Rationale for this change
We encounter this issue in delta-rs project where partitionValues in delta spec could contain binary type values.
What changes are included in this PR?
Add binary type support and corresponding test case.
Are there any user-facing changes?
No.

Codecov Report

Merging #702 (9d68c56) into master (38e5d22) will increase coverage by 0.00%.
The diff coverage is 91.30%.

:exclamation: Current head 9d68c56 differs from pull request most recent head 498e15d. Consider uploading reports for the commit 498e15d to get more accurate results

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   82.45%   82.46%
=======================================
  Files         168      168
  Lines       47397    47419   +22
=======================================
+ Hits        39083    39102   +19
- Misses       8314     8317    +3

Impacted Files
Coverage Δ

arrow/src/json/reader.rs
83.83% <90.90%> (+0.10%)
:arrow_up:

arrow/src/array/array.rs
81.73% <100.00%> (ø)

parquet/src/encodings/encoding.rs
94.48% <0.00%> (-0.20%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e5d22...498e15d. Read the comment docs.

Thanks!
Out of curiosity, isn't json always valid utf8?

Yeah, I've only ever base64 encoded to a string, so I wonder if there'd be some data loss if we don't do some conversion to a string representation

I pushed a change to fix a cargo fmt nitpick and once this PR passes CI I plan to merge it in. Thanks again @zijie0 !

Thank you all! Feeling excited to become a new contributor.

Looks great -- thank you again @zijie0  -- I'll plan to include this as part of arrow 5.3.0 (eta release in about 10 days time)

Yeah, I've only ever base64 encoded to a string, so I wonder if there'd be some data loss if we don't do some conversion to a string representation

I think writer needs to take care of the encoding and the reader needs to decode accordingly. For example encoding arbitrary binary into base64 is one way to do this. Another way is to encode binary as 2 bytes unicode code point. Whatever the encoding/decoding strategy gets picked, the writer is responsible to encode the binary into valid utf8 string. So it's really just a convention that the writer and reader needs to follow.


Detailed README

Hello, I just read your paper and am looking at the code. I appreciate your efforts for this new method. I want to use this method on my database and I am not getting it after reading this how can I do this or it is just for spider data?  I would be grateful if you could guide us on how can we use on own data.
Thanks !!

Hi,
Thank you for expressing your interest. We apologize for the inconvenience, as the provided code is specifically designed for Spider data and may require additional efforts for adapting it to a Text2SQL assistant. However, if you wish to apply it to your own database, we can offer some suggestions. Since our solution is a few-shot approach, it requires example candidates. In this case, you can utilize the Spider train data as the candidate pool. Additionally, for application purposes, using the Masked Question Similarity Selection should suffice. You may need to create your own utils/linking_process.py function to facilitate this process.


MM-26074 Cypress test for MM-T2098 and MM-T2096 - Clock Display Settings

Summary
Cypress/E2E on Clock Display Settings
Ticket Link
Jira ticket: https://mattermost.atlassian.net/browse/MM-26074
TM4J tickets: MM-T2098 and MM-T2096

Tested and passed. Non-blocking but the expected "In RHS, consecutive reply timestamp is spaced properly and does not run up against the RHS edge" seemed to be not covered. Maybe it's worth clarifying to QA channel? I don't know why it's there and I'm also interested with history/logic behind it. (Maybe related to timezone, that renders long date format when specific timezone is not supported.)

@saturninoabril I'll merge this PR and then deal with that scenario later. I created a JIRA ticket to monitor https://mattermost.atlassian.net/browse/MM-26669


Update initiative-definition-structure.md

Description is also an optional Policy Parameter attribute. Call it out as such.

@ctraftoncodes : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@timwarner-msft
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
#assign:@MicrosoftDocs/public-repo-pr-review-team

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

@timwarner-msft - Is this PR okay to merge?

@timwarner-msft - Can this old PR be merged?

#sign-off


Fix ccrewriter bugs to support roslyn-based compiler

All tests are passing.
Main difference between old and new compilers are related to "static closures". Here is an example of non-capturing lambda expression (a.k.a. static closure):
public class Foo
{
     public string Method(params string[] strings)
     {
        Contract.Ensures(Contract.ForAll(strings, s => Contract.Result<string>() == s));
        return "42";
     }
}

In this case old compiler will generate following code (pseudo code in C#):
	public class Foo
	{
		[CompilerGenerated]
		private static Predicate<string> CS$<>9__CachedAnonymousMethodDelegate1;
		public string Method(params string[] strings)
		{
			if (Foo.CS$<>9__CachedAnonymousMethodDelegate1 == null)
			{
				Foo.CS$<>9__CachedAnonymousMethodDelegate1 = new Predicate<string>(Foo.<Method>b__0);
			}
			Contract.Ensures(Contract.ForAll<string>(strings, Foo.CS$<>9__CachedAnonymousMethodDelegate1));
			return "42";
		}
		[CompilerGenerated]
		private static bool <Method>b__0(string s)
		{
			return Contract.Result<string>() == s;
		}
	}

But roslyn-based compiler uses different approach. It will generate "static closure class" with instance methods and a singleton instance:
	public class Foo
	{
		[CompilerGenerated]
		[Serializable]
		private sealed class <>c
		{
			public static readonly Foo.<>c <>9 = new Foo.<>c();
			public static Predicate<string> <>9__0_0;
			internal bool <Method>b__0_0(string s)
			{
				return Contract.Result<string>() == s;
			}
		}
		public string Method(params string[] strings)
		{
			Predicate<string> arg_21_1;
			if ((arg_21_1 = Foo.<>c.<>9__0_0) == null)
			{
				arg_21_1 = (Foo.<>c.<>9__0_0 = new Predicate<string>(Foo.<>c.<>9.<Method>b__0_0));
			}
			Contract.Ensures(Contract.ForAll<string>(strings, arg_21_1));
			return "42";
		}
	}

This distinction leads to number of changes to understand new patterns in the IL but preserve backward compatibility.

@mike-barnett, could you please take a look at this PR?

:exclamation: If available, we should pull the Roslyn binaries from NuGet instead of adding them to this pull request.
If the binaries are available on NuGet, we can add a file .nuget/packages.config which declares the dependency, like I did here for the IKVM dependencies in the ANTLR 4 C# target (which don't apply to any specific project). Then we just update the paths to reference the binaries under the packages folder instead of the binaries you included in this pull request.

:memo: I'm going to run a quick test and see if I can send a pull request that changes the current code to use NuGet instead of embedded binaries (no other changes). Then you can update this pull request so commit c1767c5 just updates the version number in packages.config and perhaps a path, but otherwise works and is much simpler.

@SergeyTeplyakov : Looks great! Let's get a new release out!

:exclamation: So, it turns out the new Roslyn binaries weren't added to this pull request which means two things:

It's easier to add them from NuGet (no rebase necessary)
The tests fail when run inside Visual Studio on other computers because it can't find the compiler

:exclamation: So, it turns out the new Roslyn binaries weren't added to this pull request which means two things:

My bad. That's because all executables are excluded in .gitignore. I thought that they were added in previous iterations.
It would be good to add NuGet support. Can you update this PR or what the easiest way to do this?

I'm good with this to get the initial build working.

Thanks, Sam.


Attendee list layout visual bugs

The list is not horizontally centered

On smaller screens the names of the attendees are not centered

@MrSunshyne I created a PR


[Event Request] Table 5050 Contact - OnTypeChangeAfterCheckInteractionLog

Please add a new publisher event to the function TypeChange as follows:
.
.
  InteractLogEntry.SETRANGE("Contact No.","No.");
  IF InteractLogEntry.FINDFIRST THEN
    ERROR(Text003,FIELDCAPTION(Type));

//>> Start New Publisher Call
  OnTypeChangeAfterCheckInteractionLog(Rec, xRec);
//<< End New Publisher Call

  Task.SETRANGE("Contact Company No.","Company No.");
  Task.SETRANGE("Contact No.","No.");
  IF NOT Task.ISEMPTY THEN
.
.

New Publisher Event:
LOCAL [IntegrationEvent] OnTypeChangeAfterCheckInteractionLog(VAR Contact : Record Contact;xContact : Record Contact)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


upgrade archaius

Coverage increased (+0.2%) to 64.893% when pulling 4b2be2b95a5a5d1fe00cd5b64f3c2e7f8870872c on tianxiaoliang:master into c6ae500f6b9c981692e7b1ca1d1e606e12a720cb on go-chassis:master.


feat: bench bls12-381 and bn254 tower operations and pairing check

Operation
BLS12-381 (cycles)
BN254 (cycles)

add-fp
538
500

sub-fp
536
500

mul-fp
546
500

add-scalar / add-fr
430
617

sub-scalar / sub-fr
430
669

mul-scalar / mul-fr
593
586

add-fp2 / add-fq2
819
552

sub-fp2 / sub-fq2
819
552

mul-fp2 / mul-fq2
837
576

add-g1
7,625
2,040

mul-g1
2,932,312
568,675

add-g2
3,554
4,910

mul-g2
1,720,463
1,400,521

pairing
3,593,525
4,106,606

pairing-check
4,706,637
8,047,245

Bn254 is slower because it isn't completely optimized to not copy data.

Optimized Bn254 operations in https://github.com/sp1-patches/bn/pull/1

Operation
BLS12-381 (cycles)
BN254 (cycles)
BN254 Optimized (cycles)

add-fp
538
500
500

sub-fp
536
500
500

mul-fp
546
500
500

add-scalar / add-fr
430
617
617

sub-scalar / sub-fr
430
669
669

mul-scalar / mul-fr
593
586
586

add-fp2 / add-fq2
819
552
536

sub-fp2 / sub-fq2
819
552
536

mul-fp2 / mul-fq2
837
576
576

add-g1
7,625
2,040
1,972

mul-g1
2,932,312
568,675
565,310

add-g2
3,554
4,910
4,959

mul-g2
1,720,463
1,400,521
1,482,133

pairing
3,593,525
4,106,606
2,910,573

pairing-check
4,706,637
8,047,245
5,842,191


Adding an automatic dir seek key

Originally, the bowtie2 path pointed to the directory, and then we changed it to point to the prefix actually consumed by bowtie2.
Now I'm finding in CWL I need the path to the directory again: https://cwl.discourse.group/t/can-you-convert-an-input-string-into-a-file-or-directory-input/218
So, we could just add a directory seek key (maybe bowtie2.dir?) to the recipe so you can get at that with a specific seek key. But then it struck me that maybe this should just be a universal built in : the .dir seek key could be a special  case that just always points to the asset's directory. Then it would never have to be specified in a recipe and would just always work.
Not sure if this is a good idea. Just brainstorming here.

FWIW, there is already a way to do this in RefGenConf.seek if you set enclosing_dir=False.
Maybe we could add  this to the CLI? refgenie seek --enclosing-dir?

I see. Well, in this case, I actually need to be able to specify this at the time of specifying registry path... so it's actually neither in a refgenie seek call, nor in a rgc.seek() call... it would be a pipeline author writing refgenie://hg19/bowtie2_index -- how can this person specify it?
Enabling refgenie://hg19/bowtie2_index.dir would solve that, but it has to be via a seek key

Ok, it seems like seek key is the way to go then.
Do you think it's a seek key explicitly defined in the recipe (enforced by recipe schema, so it always has to be there) or added automatically to every asset within refgenie?
I think I'd prefer this to be defined in the recipe for 2 reasons: 1) Flexibility: maybe this will not always be the same, enclosing dir, 2) Explicitness

Ok, in that case we don't need to change anything. I just have to add the 'dir' seek key to the bowtie 2 inde -- and in fact I did this in my test case and it works. But this issue was proposing to make it universal somehow so that all assets would have the ability inherently.
About Flexibility -- what do you mean? In fact it would always be the same -- it's just the enclosing dir of the asset, the {asset_outfolder} referred to in the recipe. There's always one of these for any recipe. So making it automatic does have something going for it: 1) Consistency: so a user knows they can always do .dir (or whatever) and get that parent {asset_folder}. You're right about explicitness though, what I'm proposing would be a magic extra thing that's not part of the recipe.
You're right that for many assets, this is in fact the default seek key already. But for ones that aren't, it might be useful to have a blanket way to always get the asset folder.
For bowtie2 I just make the ASSET section in recipe like so:
        ASSETS: {
            "bowtie2_index": "{genome}"
        },

becomes:
        ASSETS: {
            "bowtie2_index": "{genome}",
            dir: "."
        },

But now, do we want to add this capability for every other recipe that doesn't specify the folder already? In fact it's only a few right now for which this may be useful -- the ones that would fall into this category are: bwa index, and tallymer index. I think most others are either: 1) already pointing at the directory with the default seek key, or 2) only have 1 file in the asset anyway, so it's unlikely to be useful to point to the directory.

Probably could be solved as part of #198

Should we implement this now, as a part of cloud links milestone or wait for the recipe system revamp?

Let's just do it now; I don't think it needs to be tied to the recipe system revamp.

ok, so in the most basic case it's as simple as dict.update({"dir": "."}).
But what about edge cases? Do we disallow using dir seek_key in the recipes with a schema (I created one some time ago: https://github.com/refgenie/refgenie/blob/master/refgenie/schemas/recipe_schema.yaml)? Or just override the potentially defined dir seek key?

But what about edge cases? Do we disallow using dir seek_key in the recipes with a schema

That's what I did, the other option might lead to confusion, I think.

@stolarczyk when was the .dir seek key added? it's not documented in the changelog, and doesn't work in v 0.11.0
efgenie seek hg38/bowtie2_index.dir
Traceback (most recent call last):
  File "/home/nsheff/.local/lib/python3.8/site-packages/attmap/ordattmap.py", line 46, in __getitem__
    return super(OrdAttMap, self).__getitem__(item)
KeyError: 'dir'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nsheff/.local/lib/python3.8/site-packages/refgenconf/refgenconf.py", line 747, in seek
    seek_val = asset_tag_data[CFG_SEEK_KEYS_KEY][seek_key]
  File "/home/nsheff/.local/lib/python3.8/site-packages/attmap/pathex_attmap.py", line 59, in __getitem__
    v = super(PathExAttMap, self).__getitem__(item)
  File "/home/nsheff/.local/lib/python3.8/site-packages/attmap/ordattmap.py", line 48, in __getitem__
    return AttMap.__getitem__(self, item)
  File "/home/nsheff/.local/lib/python3.8/site-packages/attmap/attmap.py", line 32, in __getitem__
    return self.__dict__[item]
KeyError: 'dir'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/nsheff/.local/bin/refgenie", line 8, in <module>
    sys.exit(main())
  File "/home/nsheff/.local/lib/python3.8/site-packages/refgenie/cli.py", line 162, in main
    rgc.seek(
  File "/home/nsheff/.local/lib/python3.8/site-packages/refgenconf/refgenconf.py", line 749, in seek
    raise MissingSeekKeyError(
refgenconf.exceptions.MissingSeekKeyError: Seek key 'dir' not defined for: 'hg38.bowtie2_index:default'

It was added in 0.11.0, I think.
Maybe the asset you're seeking simply doesn't consist of dir seek key?

Can you explain what you mean? I thought the point of this is that all assets have an automatic .dir seek key?

All assets that are built with refgenie > 0.11.0 have a .dir seek key added automatically, so it's automatic in this sense. Thanks to that we have the seek keys listed in list, listr and on the asset pages on the server at no cost.
Asset seeking did not change at all with regard to that. We could add a patch to RefGenConf.seek so that it's compatible with old assets.

ah, that makes sense. so probably re-pulling the asset would fix it.

yes, re-pulling or re-building will help. Or just manually add dir: . in seek_keys section ;)


feature requests

when on the main youtube.com page if you scroll down for a while these is a section called "Latest YouTube posts". This section uses the same number of posts per row as the number of videos per row that you select in your extension. I use 5 videos per row but this results in very little text shown next to the video for the posts in the "latest youtube posts" section. I would like for there to be an additional setting in your extension to specify the number of posts to show per row.
Here is a screenshot showing this: https://i.imgur.com/9rnhFya.jpeg
I would also like a setting to expand the "show more" button that shows additional videos or posts by default.

I believe the new feature "Post per row" should fix for Latest YouTube posts" section.


Blank, short, not match and common password validation errors for change password are all 'password required' rather than the appropriate error

Title. If needed more information can be provided upon request.

Can you show me an example HTTP requests that would reproduce the error? We have tests for this and they're passing. The code itself looks right too.
It sounds like you're not sending a valid request or you're missing headers.

This currently passes with the decorated expected failures. I am going to switch from using force_authenticate to credentials which may be causing the unexpected behaviour.
import re
from unittest import expectedFailure

from django.contrib.auth.models import User
from django.core import mail
from rest_framework import exceptions, status
from rest_framework.reverse import reverse
from rest_framework.test import APIClient, APITestCase

client = APIClient()

class PasswordTestCase(APITestCase):
    """
    Test case specific to the password field.
    """

    @classmethod
    def setUpTestData(cls):
        cls.PATTERN = re.compile(r'^.*email/(.*)/.*$',
                                 re.DOTALL)
        cls.USER = {'username': 'user',
                    'email'<EMAIL_ADDRESS>                    'password1': 'complex_password',
                    'password2': 'complex_password'}
        cls.URL = reverse('rest_password_change')
        client.post(reverse('rest_register'),
                    cls.USER)
        key = re.match(cls.PATTERN, mail.outbox[0].body).group(1)
        client.post(reverse('account_email_verification_sent'),
                    {'key': key})

    def setUp(self):
        user = User.objects.get(username=self.USER['username'])
        client.force_authenticate(user)  # This may be the cause of the behaviour.

    def tearDown(self):
        client.force_authenticate(None)

    def test_missing_password(self):
        """
        Missing passwords should generate 400 bad request and an error message.
        """
        payload = {}
        response = client.post(self.URL,
                               payload)

        self.assertEqual(response.status_code,
                         status.HTTP_400_BAD_REQUEST)
        self.assertDictEqual(
            response.data,
            {'new_password1': [exceptions.ErrorDetail('This field is required.',
                                                      'required')],
             'new_password2': [exceptions.ErrorDetail('This field is required.',
                                                      'required')]})

    # TODO the current error message is wrong password required is being used
    #  for all password validation errors
    @expectedFailure
    def test_blank_password(self):
        """
        Blank passwords should generate 400 bad request and an error message.
        """
        payload = {'password1': '',
                   'password2': ''}
        response = client.post(self.URL,
                               payload)

        self.assertEqual(response.status_code,
                         status.HTTP_400_BAD_REQUEST)
        self.assertDictEqual(
            response.data,
            {
                'password1': [exceptions.ErrorDetail('This field may not be '
                                                     'blank.',
                                                     'blank')],
                'password2': [exceptions.ErrorDetail('This field may not be '
                                                     'blank.',
                                                     'blank')]})

    @expectedFailure
    def test_short_password(self):
        """
        Short passwords should generate 400 bad request and an error message.
        """
        payload = {'password1': 'pass',
                   'password2': 'pass'}
        response = client.post(self.URL,
                               payload)

        self.assertEqual(response.status_code,
                         status.HTTP_400_BAD_REQUEST)
        self.assertDictEqual(
            response.data,
            {'new_password1': [exceptions.ErrorDetail('This password is too '
                                                      'short. It must contain '
                                                      'at least 8 characters.',
                                                      'password_too_short')],
             'new_password2': [exceptions.ErrorDetail('This password is too '
                                                      'short. It must contain '
                                                      'at least 8 characters.',
                                                      'password_too_short')]})

    @expectedFailure
    def test_password_not_match(self):
        """
        Passwords that don't match should generate 400 bad request and an error
        message.
        """
        payload = {'password1': 'pass',
                   'password2': 'word'}
        response = client.post(self.URL,
                               payload)

        self.assertEqual(response.status_code,
                         status.HTTP_400_BAD_REQUEST)
        self.assertDictEqual(
            response.data,
            {'non_field_errors': [exceptions.ErrorDetail("The two password "
                                                         "fields didn't match.",
                                                         'invalid')]})

    @expectedFailure
    def test_common_password(self):
        """
        Common passwords should generate 400 bad request and an error message.
        """
        payload = {'password1': 'password',
                   'password2': 'password'}
        response = client.post(self.URL,
                               payload)

        self.assertEqual(response.status_code,
                         status.HTTP_400_BAD_REQUEST)
        self.assertDictEqual(
            response.data,
            {'password1': [exceptions.ErrorDetail('This password is too '
                                                  'common.',
                                                  'password_too_common')]})

@brian-e-haley This is because of the force authentication technique.
I have made another piece of test which seems passing.
from django.test import TestCase
from rest_framework.exceptions import ErrorDetail

from dj_rest_auth.registration.serializers import RegisterSerializer

class TestRegisterSerializerSerializer(TestCase):
    def test_short_password(self):
        serializer = RegisterSerializer(
            data={
                "username": "test",
                "email"<EMAIL_ADDRESS>                "password1": "pass",
                "password2": "pass"

            }
        )
        self.assertEqual(serializer.is_valid(), False)
        self.assertEqual(
            serializer.errors,
            {
                'password1': [
                    ErrorDetail(
                        string='Password must be a minimum of 6 characters.',
                        code='invalid'
                    )
                ]
            }
        )

@iMerica I hope this issue can be closed now

@jerinpetergeorge As I mentioned in my Edit1: which I left here in August using client.credentials() in place of client.force_authenticate() does not change anything so I don't think it is fair to say that client.force_authenticate() is the cause.
I posted this months ago though so my memory is a bit fuzzy so I doubt I will be of much help.


Adds EuroSAT to the list of supported datasets

Following up on #5108, this PR introduces the following modifications:

adds the EuroSAT dataset to the list of supported datasets (please note that there is no train/test split)
adds a corresponding unittest
adds the corresponding entry in the documentation

Any feedback is welcome!
cc @pmeier

@frgfm the test failures are related. Could you have a look?

@frgfm the test failures are related. Could you have a look?

Oops, I overlooked that one. This should be fixed now :+1:


Run tests with lbcd and lbcwallet (and update production?)

can be closed after merging scribe branch into master


Alignment Syntax Formatting

When a table is generated via the stock Atom snippet, we get an extra leading space before the : character, however, this is changed by markdown-table-editor, any possible way to have this implemented to have consistency with the formatting of the stock snippet?

The top table is from the snippet where the bottom table is formatted by markdown-table-editor.

If you are preparing tables from the snippet:
You don't need it! Please follow the quick guide.
If the tables are generated by other people, and you want to make your tables consistent with them:
Currently there are no way to configure the padding of delimiter cells.
You can format all tables by Markdown Table Editor: Format All command, or I will implement a new option to change the padding of delimiters if it is really needed.

It isn’t absolutely necessary.  Just wanted to say it formatted differently from the way the snippet inserts it.  But it is ok for me to manually adjust it.  Thank you.


API limitation?

After writing a script to parse my music and download lyrics I've found that after several queries I'll start getting an exception like this:
File "musixmatch.py", line 90, in get_lrc
tracks = body["track_list"]
This seems to be related to some API limitation.  If I sit for a few minutes, (5-6) I can execute queries again.
Is this limitation documented, and is there some way to capture it?

Yeah similar to #35, I made a commit to handle non-200 status code to return None so we request next providers. It seems it is a captcha from what I see in API JSON:
{'message': {'header': {'status_code': 401, 'execute_time': 0.0026848316192627, 'hint': 'captcha'}, 'body': []}}


NioWorker.write0(...) can throw NPE

Like 489 of NioWorker:
} catch (Throwable t) {
    *buf.release();*
    channel.currentWriteEvent = null;
    channel.currentWriteBuffer = null;

can throw an NPE if "buf" is set to null in the try block and an exception is throw after (line 471 sets buf to null, for example).

Let me have a look..

Fixed.. thanks!


Add feature to customize ts types generated for some SQL types

By default, node-postgres parses bigint and numeric as strings, to preserve full information on the number since javascript doesn't support 64 bits integers.
Depending on the application, the developer can choose to parse big numbers (int8) as strings or integers.
Eg, for bigint, we used to change the parsing as following :
pg.types.setTypeParser(20, function (val) {
	// remember: by default, all values returned from the server are either NULL or a string
	return val === null ? null : parseInt(val);
});

So it would be useful to be able  to define accordingly in schemats the ts type to generate.

To get that, we would need to make https://github.com/SweetIQ/schemats/blob/master/src/schema.ts#L79 extendable. I'll think about some possible ways to do it. Please let me know if you have any plans :)

Related read: pg-promise returns integers as strings.


Accessory not responding

Hi!
Denon X1400H
quickselect was configured in the Denon App.
Config:
{
"accessory": "denon-quickselect",
"name": "MEDIA PLAYER",
"quickselect": 3,
"host": "<IP_ADDRESS>",
"zone": 1
}
Accessory is appear in HomeApp, but it constantly refreshing and after timeout i get "Not responding" state. So it is not working.
In the logs i get:
when bridge starts i get
[2019-3-19 11:30:22] [MEDIA PLAYER] Initializing denon-quickselect accessory...
after that
[2019-3-19 11:30:44] [MEDIA PLAYER] null

please update readme. find solution! for my reciever wich is officially no web-based interface. just add port 8080 to host parameter and it's work!!! example:
{
"accessory": "denon-quickselect",
"name": "MEDIA PLAYER",
"quickselect": 3,
"host": "<IP_ADDRESS>:8080",
"zone": 1
}

@Partizan7676 Interesting, which model do you have?

@Partizan7676 Ah, I overread that you use the Denon X1400H. I'll add it to the README - Thanks for your hint 👍


chore(deps): bump golang-ci version to support go 1.21

Overview
Support go v1.21.
Will fix CI for: https://github.com/celestiaorg/celestia-app/pull/2540
Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #2547 (140ef86) into main (cc8a3a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2547   +/-   ##
=======================================
  Coverage   20.55%   20.55%
=======================================
  Files         131      131
  Lines       15313    15313
=======================================
  Hits         3147     3147
  Misses      11863    11863
  Partials      303      303

I guess it should:
https://github.com/celestiaorg/celestia-app/blob/cc8a3a834011d30fc87718124eab32f5d69ab5b5/.github/dependabot.yml#L18-L24
that's weird

I think that config will just monitor the Github action version which in this case is https://github.com/golangci/golangci-lint-action/releases/tag/v3.7.0

aaaah makes sense :+1:


Fix default status of StatefulsetAutoDeletePVC when beta

StatefulsetAutoDeletePVC has been on by default since it
graduated to Beta in 1.27
Fixes #43976
Signed-off-by: Naadir Jeewa<EMAIL_ADDRESS>

/hold
Until this PR only covers one language.
(Okay to unhold once thats done)

/remove-language zh
/approve

/hold cancel

Removed whitespace changes, en only.

This is ready for LGTM - for someone else (from someone else, as it'll deploy to the live site once merged).
Tech signoff from SIG Apps would be good to confirm this is the right fix; I'm sure it is, mind.

Not from SIG Apps but as per blog- Kubernetes 1.27: StatefulSet PVC Auto-Deletion (beta)
 , the change is correct.

Thanks for the update!
/lgtm


Fix JSDoc/TS of writeTextToCanvas

This moves the changes over from https://github.com/CesiumGS/cesium/pull/9196 since I didn't seem to have push access to that branch in the fork.
This fixes the return type of writeTextToCanvas which can return undefined, and updates CHANGES.md and adds a test in index.ts.

Thanks for the pull request @OmarShehata!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.


Housekeeping

Migrates testing, coverage, and build scripts to jest and npm scripts (no gulp).

This drops support for Node < 4.5.0. If anyone desires support for those older versions, they use use this package at v2.1.1.

Don't directly merge, merge into release branch.


Refactor SafeAttributePersistenceProvider and AttributePersistenceProvider to move ember-specific bits to codegendatamodelprovider

Intent for this is to reduce ember-specific calls in generic calls, so that we can eventually have applications that have providers without any ember dependencies.
This fixes #36472
Changes:

Separate out SafeAttributePersistenceProvider as its own stand-alone class. Our unit tests only test this one so move the tests accordingly
Make AttributePersistenceProvider use composition instead of inheritance on SafeAttributePeristenceProvider
Make Server be responsible of SafeAttributePersistenceProvider (since that is in libCHIP and does not depend on Ember) and make CodegenDataModelProviuder initialize the AttributePersistenceProvider that attribute-storage.cpp and a few other clusters use. Recommendation seems to be to use the SafeAttributePersistenceProvider

Closing for #36658 (after offline discussion about an updated approach)


cargo-deny: 0.12.2 -> 0.13.0

Description of changes
https://github.com/EmbarkStudios/cargo-deny/compare/0.12.2...0.13.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 197936 run on x86_64-linux 1

1 package built:

cargo-deny


Splitcards GRN/RNA

Splitcards from GRN and RNA (5U and 5R in each set) are not recognized as "owned" anymore (since last patch I guess.

Thanks for reporting, investigating


update main.go- works with initialisation scripts

line 247: need a way to initialise submodules if we want to push them later (line 297 and following)
presently done via some bash scripts later on.

This version is not stable, but better than the current master version wich do not work at all with submodules.

This works !
Let's merge and make a release !

PS, we will better get a .cff file before the release. will prepare this.


fix machineTemplate deletion logic to prevent panics in the hypershift operator (fixes IBMCloud deploys)

What this PR does / why we need it:
some providers like None and currently IBM Cloud UPI (Satellite) do not have explicit machine template types.
This PR changes that so the default is if something is not explicitly defined an empty list is returned which will allow a graceful skip of the machineTemplate deletion logic instead of a stopping cleanup of the nodepools.
Current code stops here:
https://github.com/openshift/hypershift/blob/767e7abff226c8559935a13b1287d377072e1633/hypershift-operator/controllers/nodepool/nodepool_controller.go#L150
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes regression found in IBMCloud regression tests
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[x] This change includes docs.
[x] This change includes unit tests.

/retest

/retest

The PR titles says the code panics but then the PR desc points to a specific line of code where we return an error, can yoiu clarify?
Also can you please add a test case for this is TestListMachineTemplates?

/hold
So it does not get merged before discussing https://github.com/openshift/hypershift/pull/899#issuecomment-1019954658

/hold adding unit test

@enxebre the hard crash was the Route pr I apologize I mixed threads. This just blocks node pool deletion.
Added unit test

/unhold

Could you please ensure the PR desc and the commit desc are the same?
You can do that with git commit -m"" -m"Desc goes here" and GH will automatically use it for the PR desc.

Thanks!
/lgtm
/approve

/merge


chore: use React 17

WIP
This PR uses React 17.0.0-rc.0 to ensure that current master is compatible with the next major release of React.
Deployment to Vercel shows running doc site and the test suite is passing except few tests, but it related to Enzyme as cleanup functions in hooks are executed after wrapper.unmount().
This waits for https://github.com/enzymejs/enzyme/issues/2429 to run our test suite over React 17.

Note: For now, you can use 3rd party adapter I built based on enzyme-adapter-react-16: https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17

Codecov Report

Merging #4031 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4031   +/-   ##
=======================================
  Coverage   99.84%   99.84%
=======================================
  Files         186      186
  Lines        3255     3255
=======================================
  Hits         3250     3250
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3640e4...ae8ace9. Read the comment docs.

Codecov Report

Merging #4031 into master will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4031      +/-   ##
==========================================
+ Coverage   99.75%   99.84%   +0.09%
==========================================
  Files         180      186       +6
  Lines        3231     3255      +24
==========================================
+ Hits         3223     3250      +27
+ Misses          8        5       -3

Impacted Files
Coverage Δ

src/modules/Popup/Popup.js
98.75% <0.00%> (-0.02%)
:arrow_down:

src/addons/Portal/Portal.js
100.00% <0.00%> (ø)

src/modules/Dropdown/Dropdown.js
100.00% <0.00%> (ø)

src/modules/Modal/ModalDimmer.js
100.00% <0.00%> (ø)

src/addons/Pagination/Pagination.js
100.00% <0.00%> (ø)

src/modules/Transition/Transition.js
100.00% <0.00%> (ø)

src/lib/hooks/useIsomorphicLayoutEffect.js

src/lib/hooks/useClassNamesOnNode.js

src/addons/Responsive/Responsive.js
100.00% <0.00%> (ø)

...ddons/MountNode/lib/computeClassNamesDifference.js
100.00% <0.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cab91...55c24df. Read the comment docs.


Save dialog for arm-template files should suggest saving with JSON extension like json files do

OS: Win10
Build Version: 20200621.8
Repro Steps:

File --> Select "New File" --> Select Language Mode "JSON“.
Copy/paste the following into the editor:
{ "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
"variables": { "appInsName": "appIniCheck", "responseAlertName": "[concat('ResponseTime-', toLower(variables('appInsName')))]" },
"resources": [ { "apiVersion": "2014-04-02", "name": "[variables('appInsName')]", "type": "Microsoft.Insights/components", "location": "[parameters('location')]", "properties": {
"ApplicationId": "[variables('appInsName')]"
} } ] }
Save this json file by "Ctrl+s".

Actual:
File type is recognized as txt format.

Suggestion:
File type is recognized as json format will be better.
More info:
File type is recognized as json format if it is an empty file.

Weird.

Doesn't appear to be a way I can do this.  Created vscode bug: https://github.com/microsoft/vscode/issues/102438


"fatal error." on raw view

Thank you for sharing your code. It's a lovely project. I had two issues.

I "fixed" the first but not sure it is the right one. I had to uncomment the "burnAfter" from the migration file to make things work. I hope that uncommenting that does not cause other issues.

I can create new pastes and see them in the dashboard. But clicking on "raw" gives me "Fatal error." I have the debug set to true but there is nothing in the logs or in whoops. Sorry not to have more details to report.

Any thoughts would be appreciated.

same error


PWM on RPi B+ not working

Thanks for the cool EMBD framework. It's really great.
I see in the docs for the PI B+ that the GPIO18 should work as PWM pin. However it's not supported in the host (host/rpi/rpi.go).
I get this if I try:

Error in NewPWMPin (18)!
panic: gpio: pwm not supported on this host

Code:
    pinNo := 18
    pwm, err := embd.NewPWMPin(pinNo)
    if err != nil {
        fmt.Println("Error in NewPWMPin (18)!")
        panic(err)
    }
    defer pwm.Close()
    // 500 Hz == 2.000.000 ns
    pwm.SetDuty(2000000)

@akofoed did you resolve this, or are the doc's incorrect on supporting PWM for the Pi?

Hi chaosaffe
No, I wrote it in C, so problem solved.


Document working with Ansible

I'd like to see more examples of this working with other configuration management tools besides Puppet.

Same here

I'd be glad to accept PRs.  I don't use Ansible so I can't really help much here. (Actually, I thought Ansible has its own mechanism for storing secrets... wouldn't that eliminate the need for Blackbox?)

What you are referring to is ansible-vault; however, it still requires a master vault password file.
See: https://docs.ansible.com/ansible/latest/user_guide/vault.html#providing-vault-passwords

Ah, yes, having a way to store the master vault password would be awesome.  Do you use blackbox for that?  Would you write brief few steps on how to set it up?


index not bound checked.

I am getting a crash using this for a personal project, and have determined that it is due an error in heap_alloc.
    while (found == NULL) {
        if(index >= BIN_COUNT)
            return NULL;

        temp = heap->bins[++index];
        found = get_best_fit(temp, size);
    }

Notice the index increment, and access, without first checking if it is below BIN_COUNT.

Ahh I must not have checked what happens when the heap is full...
So you are saying the line index >= BIN_COUNT should be index >= BIN_COUNT - 1 ?

Whoops, sorry looks like I pasted in my hacked in fix instead of the original code by mistake in my original message.
    while (found == NULL) {
        temp = heap->bins[++index];
        found = get_best_fit(temp, size);
}

The hack fixed I ended up going with was actually:

    while (found == NULL) {
        if(index + 1 >= BIN_COUNT)
            return NULL;

        temp = heap->bins[++index];
        found = get_best_fit(temp, size);
    }

That seems to have worked for me. Hmm, but honestly I haven't tested it thoroughly enough to really make any guarantee on it. But with that in there, it should be returning null if there is no memory left.

Oh that looks like it should work, good catch!
You could go ahead and create a pull request, or I could go ahead and fix it.

Cool, when I get back in the office on Monday I'll look at making a pr. Thanks!

#9


Testing with pytest-xdist lib

I want use pytest-xdist run tests as
pytest -n 4 tests
but SanicTestClient bind 42101 port, and get OSError: [Errno 48] Address already in use,
i hope  SanicTestClient bind unused port when app server start.

The sanic test client will always try to bind port 42101 by default.

I'm not entirely sure that the unittests would be good to run in parallel.


[BUG] Repair JDBC connection of Oracle

Purpose of the pull request
Repair JDBC connection of Oracle
Brief change log
Repair JDBC connection of Oracle
Oracle SID:
jdbc:oracle:thin:@::
Oracle Service Name
jdbc:oracle:thin:@//:/<service_name>
Verify this pull request
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #7883 (e441bb4) into dev (ae09702) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                dev    #7883      +/-   ##
============================================
- Coverage     41.03%   40.99%   -0.05%
+ Complexity     3696     3693       -3
============================================
  Files           637      637
  Lines         27025    27045      +20
  Branches       3063     3067       +4
============================================
- Hits          11090    11086       -4
- Misses        14867    14888      +21
- Partials       1068     1071       +3

Impacted Files
Coverage Δ

...i/datasource/oracle/OracleDataSourceProcessor.java
44.82% <50.00%> (-0.79%)
:arrow_down:

...inscheduler/api/controller/ExecutorController.java
10.00% <0.00%> (-15.00%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.70% <0.00%> (-2.82%)
:arrow_down:

.../org/apache/dolphinscheduler/api/enums/Status.java
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae09702...e441bb4. Read the comment docs.

considering that it's your first contribution, I think we can get deep communiction, you can contact me through mail or add wechat(KerwinZhuang), when mail or added, please tell me who you are, I think I can help to familiar with the DolphinScheduler if you meet with problems.


Provided guidance on error detection or validation that Writes are successful

Here and in the accompanying API docs (like WriteTextAsync) there's no info on how these methods can fail, throw exceptions, or how to validate that the write was successful and stored to the file.  It'd be great to see guidance here and there on how to determine that a write was successful and recover from error cases.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b36404b8-4385-81d9-2ee8-486f0a55fc37
Version Independent ID: 7b6ce4df-6ab2-3aa6-059f-b38aa9ea8062
Content: Create, write, and read a file - UWP app developer
Content Source: windows-apps-src/files/quickstart-reading-and-writing-files.md
Product: uwp
GitHub Login: @laurenhughes
Microsoft Alias: lahugh

Thanks for your feedback! We are in the process of pulling together a lot of in-depth guidance about what the WritexxxAsync methods do internally, how and why various parts of these operations can fail, and what you can do in response to the failures. I'll update this issue when this new guidance is published in our docs.

It looks like there is no actionable feedback here, so I am closing the issue. Please open a new issue if you have feedback you would like to be addressed.


Add dedicated documentation site hosted on Github using ReadTheDocs.

ReadTheDocs repo with a quick start.

WIP on the FracturalVNEDocs repo. The site is launched but the documentation + tutorials is unfinished.


How to make a sticky footer that has padding from body with react-router?

Im trying to have a sticky footer but it is not sticky. Any ideas?
Here is my router handler:
var React  = require('react');
var Navbar = require('./Navbar.js');
var Footer = require('./Footer');
var Router = require('react-router');

var RouteHandler = Router.RouteHandler;

var App = React.createClass({
  render: function () {
    return (

        <Navbar />

                <RouteHandler />

    );
  }
});

module.exports = App;

And this is the footer.js:
var React  = require('react');
var Router = require('react-router');
var Link = Router.Link;
var Navigation = require('react-router').Navigation;

var Footer = React.createClass({

  mixins: [Navigation],

  render: function () {

    return (

© 2015

<Link to="contactus">Contact Us</Link>

<Link to="about">About</Link>

      );
    }
  });

module.exports = Footer;

Any idea the best way to do this?

I'm not sure this issue is related to react-router.

Why not?

The router only matches the views to the your components and manages the address bar.
Visual styling (such as a sticky footer) is completely up to you and is out of scope of this project.
Here's what I found searching “sticky footer CSS”:
http://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/
This might be helpful if you're fine with using Flexbox (in 2015, with Autoprefixer I'd say it's the best solution). If you'd rather avoid Flexbox, you might look for other solutions.

For future googlers who end up here....
Many sticky footer techniques like this one:
https://css-tricks.com/snippets/css/sticky-footer/
Need all parent element to have a height of 100%. In normal html pages, usually this is enough:
html, body {
height: 100%;
}

But using react, you get some more redundant parent elements eventually. Like the div that is needed, so that your app gets injected into it, or the mandatory wrappers that JSX requires. For your sticky footer to work, remember to add classes, and height for those as well.

No. Does not work. This Does:
In App.js:
import React, { Component } from 'react';
import {Header} from './components/Header';
import {Main} from './components/Main';
import {Footer} from './components/Footer';

class App extends Component {
	render() {
		return (

		);
	}
}

export default App;

And in _sticky-footer.css (I use POSTCSS):

:root {
    --space: 1.5em 0;
    --space: 2em 0;
}

.Site {
    display: flex;
    flex-direction: column;
    min-height: 100vh;
}

.Site-content {
    flex: 1 0 auto;
    padding: var(--space) var(--space) 0;
    width: 100%;
}

.Site-content:after {
    content: '\00a0';
    display: block;
    margin-top: var(--space);
    height: 0;
    visibility: hidden;
}

So, instead of adding .Site className to  tag, you add it to the outermost

 tag treating it as if it is the body tag. And as far as React is concerned, it is. Then you add the second div right below it adding the .Site-content className to i. You just had to make sure that everything is included in the flexbox styling EXCEPT the , just as in traditional flexbox sticky footer styling. Philip Walton's flexbox sticky footer solution here: https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/

so @gaearon its 2018. still we need to mess up the css to get the sticky footer for react?


Fix keyframes bug from prefixed inline styles.

Fixes #973
@LanF3usT @sunny -- If you get a chance, mind kicking the tires on this branch and confirm the fix is good?
/cc @alexlande

Coverage remained the same at 94.406% when pulling 9ea2f1278d1f3f2929aa26dd679adad1bfe864e0 on bug/isp-keyframes into<PHONE_NUMBER>2a9fd2c085c481e19398056deee894 on master.

@ryan-roemer: I did try the fix. It's all good! xD

Released in<EMAIL_ADDRESS>


Add drag and drop reorder of columns (directly rather than via the tool panel)

As mentioned (incorrectly) in https://github.com/ceolter/ag-grid/issues/593
Can create a pull request if the feature is acceptable?
the difference is in https://github.com/ceolter/ag-grid/blob/0fa265e8f876c4a99683d14839f3c3ab40f90ff5/src/ts/headerRendering/renderedHeaderCell.ts https://github.com/ceolter/ag-grid/blob/0fa265e8f876c4a99683d14839f3c3ab40f90ff5/src/ts/headerRendering/renderedHeaderCell.ts
inside private setupComponents() method, added this code  e.g. line 160 (after this.addMenu() -> self = this))
        if (self.gridOptionsWrapper.gridOptions.enableColReorder) { //TODO - find the best place for this
            headerCellLabel.setAttribute('draggable', 'true');
            headerCellLabel.addEventListener('dragstart', ev => sourceColumn = self.column);

            headerCellLabel.addEventListener('drop', ev => {
                ev.preventDefault();

                self.gridOptionsWrapper.gridOptions.columnApi.moveColumn(sourceColumn.index, self.column.index);
            });

            headerCellLabel.addEventListener('dragover', ev => ev.preventDefault());
        }

if you create a pull request, it will stand a better chance of been included. however no promises. i plan on implementing draggable columns in the coming weeks and will be taking my time to implement a full solution.

Thank you, will create one hopefully tonight.
On another note, would be nice some methods to be made protected (rather than private) so methods can be extended without typescript complaining of extending private methods/ properties. It will allow overwriting classes to add custom behaviour. E.g. want to add setState / getState pair to add sort property to the state.
Typescript still compiles if we ignore the errors.
Let me know your thoughts.
thanks

Will the commit be merged anytime?

the latest relesat 3.3.3 has it

I searched for "suppressMovableColumns" in the code (documented on ag-grid website), but I couldn't find anything that uses it. Am I drunk? :)

used here
https://github.com/ceolter/ag-grid/blob/master/src/ts/headerRendering/renderedHeaderCell.ts

Is there a movable columns' s example? We can't use it...


my tool bar disappear

how I can put again my right side tool bar

Hi @rafagaska, you might have enabled No Distractions-mode by accident. You can turn it back off from View -> No Distractions or CTRL+SHIFT+2 (CMD+SHIFT+2 on Mac IIRC).


aarch64 support

Please refer to https://github.com/jpype-project/jpype/issues/1227. I can't reopen the issue so I have to start a new one.
Only 1.2.1 has pre-built wheel for aarch64 platform and the later releases don't.

Why is this the case? Is anything wrong during the release?
Why did @marscher close my issue without clarifying my issue? Do you think it's fine?

seriously - whats wrong with you?

seriously - whats wrong with you?

seriously what did you not show respect and close my issue without clarifying any of the questions?

Use the search function, your "issue" was already filed. Opening up duplicate issues, being impolite and wasting peoples time isn't respectful either.


Adjust City Lights and Nord color to comply with specification

Added doom-nord-region-highlight variable to specify the region highlight style: "forest", "snowstorm" and default
Adjust modeline-bright so that they looks more natural
Adjust specific faces (City Lights org-block)

This looks great, thanks!


Updated Twitter (X) logo

Description
[Include a brief description of the changes you've made]
Updated Twitter logo to new X logo
Related Issues
#470
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@blindaks Have you tested it locally? Share screenshot it you did.

If you are running it locally than please share the screenshot.


[turborepo] - git diff misses changes when not ancestor

What version of Turborepo are you using?
1.5.5
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Describe the Bug
When you do a filter of the form
pnpm turbo<EMAIL_ADDRESS>If the git rev is not an ancestor of HEAD changes are missed.
It seems like in git.go
the git_rev becomes the from commit, and HEAD is the to commit.

Although not quite the same its similar to:existing Issue
Expected Behavior
Have a git diff based directly off the commit im passing in.
Basically like the issue linked above describes.
To Reproduce
create a branch off main and make some changes.
create a separate branch off main and make different changes.
Do a git diff from the commit sha of HEAD from the initial branch.  Those changes will be missed.
Reproduction Repo
No response

Checked in latest canary and this has been resolved!


Single Digit Files Collection Names

Problem:

Project names (Files Collection names) containing a single digit fail validation and prevent a user from submitting the form to create a new collection.

Solution:

Modify regex to allow numbers.

Test:

Login to application.
Click on My Files tab.
Fill out form, being sure to enter a single digit in the Name field.
Observe that the collection is created without issue.

This works! Nice. 🚀


One Click Remote Desktop App Already Exists

I don't know what you do when you find an app that does some of this functionality. However, I have used Chrome Remote Desktop for a while now, and it's only getting better. As long as you have Chrome, it's a single click to install an app, and then an access code to connect. You can do it for your own computer too and connect via your phone if you want, though I have regularly done it with my grandparents so that I can help them fix problems with their computer from afar.

I've seen that, and tried it for this purpose. But the codes + having to sign in is honestly too much; i really just want like a "Visit this link and consent to give me access to your computer" type of thing (which would be malware without the consent button).


[Quick PR] Add authz authorizations for core modules param changes

Adds param changes authorizations for DAO.

Summary by CodeRabbit

New Features

Enhanced authorization framework with multiple new entries, allowing for granular permission settings across various functionalities in the Cosmos ecosystem, including software upgrades and governance management.
Extended authorization capabilities for managing interactions within the Cosmos blockchain.

These improvements aim to provide users with a more flexible and robust permission management system.

Merging with a couple of flaky tests failing.


test:  disable check with td-agent alias status

td-agent (alias of fluentd service) should be enabled, but systemctl status td-agent may fail frequently with exit 3. It means inactive (dead) status.
Until finding correct solution to fix this issue, disable it for a while.

As #504 was merged, rebased with it.


VNode.elm missing for nested slots after component update

Version
2.2.6
Reproduction link
https://jsfiddle.net/jingkaizhao/f11tpysz/5/
Steps to reproduce

open and run fiddle
open chrome devtool
click 'update' button
see result in console

What is expected?
In updated hook, vnode inside slots children (this.$slots.default) should have a reference to its DOM element on property vnode.elm
What is actually happening?
vnode.elm is undefined

Did some investigation on it.
It just happened on nested component, (<slot> as children for another component). And it only happened after patching, it means in the initial stage (mounted hook), the vnode has correct reference to its DOM node, but after update (updated hook), the elm reference is missing.

It seems slot vnode will be copied across different components. So the vnode in nested copmonent is not updated. Still needs deeper investigation...

This is somewhat expected behavior because slot nodes are shallow-cloned during render, so when nested passes the slot nodes down to block, block clones the slot nodes and then patches them (adding .elm in the process), however, the slot nodes in nested remain non-patched.
This is a wontfix because you should not be relying on vnode.elm in your render functions. This is not part of intended usage for vnodes.


V1.Kv_ro is gone, use mirage-kv instead

mirage-runtime is superfluous now here

travis failure in reverse dependency git, fixed by https://github.com/mirage/ocaml-git/pull/181

@samoht you noticed this as well (and https://github.com/mirage/mirage-dev/issues/292)?

yes, thanks for the PR. I am still trying to fix ocaml-git revdeps, but I hope to look at irmin's PRs soon.

merged via #395


small tweak to simple search

Should exact match come first?
I noticed here that it doesn't

Should exact match come first?

Definitely!  That's a bit of an oversight.  I've fixed it for the morning.


Add Instagram Clone

Is your feature request related to a problem? Please describe.
I want to Add Instagram Clone
Describe the solution you'd like.
I want to add instagram clone to the website and make a contribution.  Made using ReactJS
Describe alternatives you've considered.
No response
Add any other context or screenshots about the feature request here.
No response

Already open #222 so I have to close this sorry


make format on save work

#62 is fixed for me at least. lmk if this doesn't fix for you after merge and we can continue to debug. some other things I did that might have helped make it work for me:

cmd+, to open settings --> search "format on save" --> editor: Format On Save ✅ (marked check box)
I have the extension Prettier - Code Formatter https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode which I think this uses. People might need to download this, so we can add to the getting started if it's needed.

I also deleted the rust thing because I was getting a lint that the feature wasn't supported.
btw, the lints in here are disgusting. I'll try to figure out how to fix more of them on save / get that experience better.
Also, this PR defaults to VSCode PR -- we need to change that to Pear. I'll make an issue.
https://github.com/trypear/pearai-app/assets/19260511/47d1ba0f-e015-421d-bfe4-14d703d5cefb

shit idk how to use git, I added a new thing to this to fix the prettier and some single quote stuff. I'll try to figure out how to get it out of this one


[feat] Option to opt-out of tracking

Understand that it's handy to have analytics running to track usage and user flows, but it's also standard to allow users to opt-out of all analytics/tracking in apps, would be good to add an option to Inboxer for that (though imagine that would require custom app-wide preferences first)

cc @JohnnyBui

This is especially true since the GDPR came into force on May 25th.

Working on it

Closed by #69. Will be released ASAP.