Uncaught ReferenceError: test is not defined

I'm trying to run some tests for a React component I'm building (my first one, new to the node world), and I'm seeing this error when using karma run:
Uncaught ReferenceError: test is not defined

/Users/temp_setup/projects/react-embedded-twitter-timeline/tests.webpack.js:21237 <- webpack:///~/after/test/after-test.js:6:0`

It seems to be complaining about test on this line https://github.com/Raynos/after/blob/master/test/after-test.js#L6 - I'm unsure where test is (or should be) defined.

test is part of the mocha's DSL, which is used as a test framework for this project. I'm not sure why you're getting ReferenceErrors, please provide more info if this is still an issue for you.

you should not be running this file working on your project, it's an internal file only relevant to this module

That's part of mocha.
Not sure why your including the tests, i dont think you want to do that.


weird behavoir

New Issue Checklist

[x] I have tried with the latest version of OHHTTPStubs
[x] I have read the README
[x] I have read the Using the right Swift Version of OHHTTPStubs for your project section
[x] I have searched in the existing issues
[ ] I have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue

Environment

version of OHHTTPStubs: [LIB VERSION HERE]
integration method you are using:

[x] Cocoapods
[ ] Carthage
[ ] submodule
[ ] other

version of the tool you use: 1.2.0

Issue Description
Not stubbing even though condition is true
Complete output when you encounter the issue (if any)
 func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        // Override point for customization after application launch.

        let condition : OHHTTPStubsTestBlock = { (request : URLRequest) in
            if request.url!.host == "localhost"{
                print("true")
                return true
            }
            print("false")
            return false
        }

        stub(condition: condition ) { _ in
            print("Stubbing")
            return OHHTTPStubsResponse()
        }

        return true

    }

The condition is always true but the print("Stubbing") never runs

Hi
Are you saying that the print("true") is executed and shows up in your console but the print ("Stubbing") doesn't?
Did you try with anything other than localhost?
I'm thinking maybe the iOS URL Loading System treats localhost as a special case and doesn't ask NSURLProtocol chain in those cases or bypass the system?

Yes that's exactly what happened. Now i changed it to
 func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
        // Override point for customization after application launch.

        let condition : OHHTTPStubsTestBlock = { (request : URLRequest) in
            if request.url!.host! == "www.mocky.io"{
                print("true")
                return true
            }
            print("false")
            return false
        }

        stub(condition: condition ) { _ in
            print("Stubbing")
            return OHHTTPStubsResponse()
        }

        return true

    }

and still nothing changes. prints true all the time but never prints stubbing

I'm using Alamofire

Okay i think i knew what wrong. When using a RxSwift wrapper around Alamofire it doesn't work. i think due to asynchronous calls? when sending the request like this
  Alamofire.request("http://www.mocky.io/v2/590c43ed270000d70ab2a7ca").responseJSON { response in

        }

it works!
is thiss doable using an RxSwift wrapper around Alamofire

What's the Rx wrapper you are using?
At my company we use a custom-made Rx wrapper around Alamofire too (and not the RxAalmofire pod) and it works as expected…
Maybe you're creating your Alamofire.SessionManager too early, so before OHHTTPStubs has time to swizzle and inject the stubs protocol before the NSURLSession.configuration has time to be created?

It's a really simple wrapper that doesn't affect the manager. Here is it
extension DataRequest{

    public func processMap<N>(mapObject:@escaping (AnyObject)->N?) -> Observable<N>{

        return Observable.create{ (observer) -> Disposable in
            self.responseJSON(completionHandler: { (response : DataResponse<Any>) in
                switch response.result {
                case .success :
                    guard let o = mapObject(response.result.value! as AnyObject) else{
                        observer.on(Event.error(ObjectMapError.MapError(response.result.value as? JSON)))
                        return
                    }
                    observer.on(Event.next(o))

                case .failure :
                    observer.on(Event.error(ObjectMapError.APIResponseError(response.result.value as? JSON)))
                }
            })
            return Disposables.create {
                self.cancel()
            }
        }
    }

    public func rx_responseArray<T:Mappable>(type:T.Type) -> Observable<[T]>{
        return self.processMap(mapObject: { (json) in
            Mapper<T>().mapArray(JSONArray: json as! [JSON])

        })
    }

    public func rx_responseObject<T:Mappable>(type:T.Type) -> Observable<T>{
        return self.processMap(mapObject: { (json) in
            Mapper<T>().map(JSON: json as! [String : Any] )

        })
    }
}

If you want you can test it. Here's link for the wrapper https://github.com/wassimseif/rxalamofiremapper

Strange indeed.
I'm not sure I'll have much time to look at in very soon, as I have quite some work and also talks to prepare. So what I can propose you is:

Compare your code with our own wrapper we use: NetworkStack — maybe you'll find some differences and see what would make ours work but not yours and get some inspiration from that?
Hope someone will have time to take a look at your problem (@Liquidsoul ?) before I have more free time myself
Ping me in a week or two if you didn't have any progress on the issue, I might have some more time by then

Hi @wassimseif
Thanks again for reporting your issue!
You are saying here that you are using Cocoapods to integrate OHHTTPStubs but your wrapper rxalamofiremapper does not seem to use Cocoapods but Carthage.
Does this mean that you are using both dependency managers in your project?
I tried to use your wrapper but failed to do so in a test App because it lacks a shared scheme needed by Carthage to build the framework (I tried the latest version and the master branch).
I am afraid I will not be able to reproduce your issue and help you out unless you give us a configured project exposing the problem 😞
BTW, your issue seems to be missing the version of Cocoapods you are using and the OHHTTPStubs one (6.0.0) is not in the correct spot. Could you edit your issue to confirm these informations please? ☺

Hello @Liquidsoul
Thank you for your time to lookup the issue. I have updated the issue. I'm using Cocoapods 1.2.0 to install OHHTTPStubs  version 6.0.0. For the wrapper, I'm not using any dependency manager to install it, just by copying the files to my project. Since the wrapper requires RxSwift
and Alamofire. I'm also using Cocoapods to install them. Hears the output of my Podfile.lock
PODS:
  - Alamofire (4.4.0)
  - Nimble (6.0.1)
  - ObjectMapper (2.2.6)
  - OHHTTPStubs/Core (6.0.0)
  - OHHTTPStubs/Default (6.0.0):
    - OHHTTPStubs/Core
    - OHHTTPStubs/JSON
    - OHHTTPStubs/NSURLSession
    - OHHTTPStubs/OHPathHelpers
  - OHHTTPStubs/JSON (6.0.0):
    - OHHTTPStubs/Core
  - OHHTTPStubs/NSURLSession (6.0.0):
    - OHHTTPStubs/Core
  - OHHTTPStubs/OHPathHelpers (6.0.0)
  - OHHTTPStubs/Swift (6.0.0):
    - OHHTTPStubs/Default
  - Quick (1.1.0)
  - Realm (2.6.2):
    - Realm/Headers (= 2.6.2)
  - Realm/Headers (2.6.2)
  - RealmSwift (2.6.2):
    - Realm (= 2.6.2)
  - RxBlocking (3.4.0):
    - RxSwift (~> 3.4)
  - RxCocoa (3.4.0):
    - RxSwift (~> 3.4)
  - RxSwift (3.4.0)
  - RxTest (3.4.0):
    - RxSwift (~> 3.4)
  - SWHttpTrafficRecorder (1.0.2)
  - SwiftEventBus (2.2.0)
  - Swinject (2.1.0)

DEPENDENCIES:
  - Alamofire (~> 4.4)
  - Nimble
  - ObjectMapper (~> 2.2)
  - OHHTTPStubs/Swift
  - Quick
  - RealmSwift
  - RxBlocking (~> 3.0)
  - RxCocoa (~> 3.0)
  - RxSwift (~> 3.0)
  - RxTest (~> 3.0)
  - SWHttpTrafficRecorder
  - SwiftEventBus (from `https://github.com/cesarferreira/SwiftEventBus.git`, tag `2.2.0`)
  - Swinject (~> 2.1.0)

EXTERNAL SOURCES:
  SwiftEventBus:
    :git: https://github.com/cesarferreira/SwiftEventBus.git
    :tag: 2.2.0

CHECKOUT OPTIONS:
  SwiftEventBus:
    :git: https://github.com/cesarferreira/SwiftEventBus.git
    :tag: 2.2.0

SPEC CHECKSUMS:
  Alamofire: dc44b1600b800eb63da6a19039a0083d62a6a62d
  Nimble: 1527fd1bd2b4cf0636251a36bc8ab37e81da8347
  ObjectMapper: '042708195cc46c20871cbcbec0453826398273fd'
  OHHTTPStubs: 752f9b11fd810a15162d50f11c06ff94f8e012eb
  Quick: dafc587e21eed9f4cab3249b9f9015b0b7a7f71d
  Realm:<PHONE_NUMBER>5b9f831228f81b63f0e38a97a4d700
  RealmSwift: d161a80f96cb91ae88391a7d5a9cf08024a7bc8e
  RxBlocking: 1797b8c1a3ad7b08965145e6e2294c2e101515aa
  RxCocoa: d14ef6b6029e1ddc6e966508c09289090de68ff9
  RxSwift: 3789a1af753002a14edecdb698a2424624296a9c
  RxTest: beb6beb882cf1dcac5fc9fdbd4760a5254e7f3a6
  SWHttpTrafficRecorder: 6c0804d3f8edf9c7f3a1e0eec9f6bf5e4b241b9f
  SwiftEventBus: 39cde57d1881f9d6e8afb1f9e41f973e331bf847
  Swinject: 85e468ac75c5c2d234076f98c591d57d56bc64bc

PODFILE CHECKSUM: 0caf8a7da8bfb24ce2beb4e76bb04bb2f69177d5

COCOAPODS: 1.2.0

@AliSoftware i checked NetworkStack and it's really interesting. do you have any sample app to demo it?

@wassimseif we have a lot of work to do on it it to better document it, make a proper README and examples & demo projects indeed, haven't had that much time for that; but I know there's a pending pull request from one of my colleague adding a lot on that regard: check the "documentation" branch I think he even added sample projects in there

Maybe you need an asynchronous wait?
Sent from my iPhone

On May 5, 2017, at 8:00 AM, Wassim Seifeddine<EMAIL_ADDRESS>wrote:
Yes that's exactly what happened. Now i changed it to
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.
    let condition : OHHTTPStubsTestBlock = { (request : URLRequest) in
        if request.url!.host! == "www.mocky.io"{
            print("true")
            return true
        }
        print("false")
        return false
    }

    stub(condition: condition ) { _ in
        print("Stubbing")
        return OHHTTPStubsResponse()
    }

    return true

}

and still nothing changes. prints true all the time but never prints stubbing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@wassimseif Any update on this, especially did you indeed ensure that you didn't forget the asynchronous wait in your test (e.g. using XCTestExpectation like explained here in the Wiki)

@AliSoftware I migrated to the network stack you provided the link for. it's much more mature than the one i wrote.

Cool! Did this solved your issue?
If so, would you mind closing the issue? 😊

@Liquidsoul Yess. Thank you very much for your help. Awesome people!


Issue #4: Convert cerner_tomcat to HWRP and add full sub-resource sup…

…port
test-evidence

Looks good, merging


Error using sample code in readme

Any ideas?
await browser.init()
^^^^^^^
SyntaxError: Unexpected identifier
at Object.exports.runInThisContext (vm.js:76:16)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:509:3

Hi! Each method of the module returns a promise; In the readme case, if you want to make use of "await" in each promise, you have to put your code inside an async fn (like in this case: https://github.com/LucianoGanga/simple-headless-chrome/issues/2#issuecomment-305537661)
I hope it helps!
Cheers,
Luciano

Thanks for the fast response! I've pared it back to just a few lines and that example throws an error too.
await function navigateGoogle () {
^^^^^^^^
SyntaxError: Unexpected token function
at Object.exports.runInThisContext (vm.js:76:16)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:509:3
Could you suggest a quick code snippet so i can test a simple fetch HTML to get me started? Really appreciate your work and help!

Just using browser.goto gives this error
async init () {
^^^^
SyntaxError: Unexpected identifier
at Object.exports.runInThisContext (vm.js:76:16)
at Module._compile (module.js:542:28)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/home/robk/node/node_modules/simple-headless-chrome/index.js:1:80)
at Module._compile (module.js:570:32)
Feels like I've got something configured wrong?

What Node version are you using?
"async" functions are available since node version 7.10.

ah crap. just upgraded to 8.10 now. that seems better in that it executes now and returns. is there an easy way to turn on some sort of logging for the session? i've tried headless: true but it doesn't show anything.


Grails 3(12) and quartz:2.0.5 not compiling or starting app

Java 1.8
Grails 3.0.12
removed all cache files from anywhere I can think of
New project: grails create-app junk1
add     compile 'org.grails.plugins:quartz:2.0.5' to build.gradle
grails
create-job Testme88
Edit Testme88Job and put:
1 package testme66
2
3 class Testme88Job {
4     static triggers = {
5         simple name: 'mySimpleTrigger',  startDelay:5000, repeatCount: 1
6     }
7
8     def execute() {
9          log.debug("Domain name job processing");
10
11     }
12 }
All seems good.
Now
run-app
Lots of errors, This is the start of them.
Grails 3 / quartz 2.05 / java 1.8 / groovy 2.4.5
I am at a loss why I cannot get jobs to work.
Honestly grails 2.4.5 I do not have any issues and may not even upgrade to grails 3 as it seems to be a completely different animal.
Any ideas ?
From scratch out of the box does not seem to work at all.
HealthIndicatorAutoConfiguration.DiskSpaceHealthIndicatorConfiguration
- matched (OnPropertyCondition)
Exception in thread "main" org.springframework.context.ApplicationContextException: Failed to start bean 'quartzScheduler'; nested exception is org.springframework.scheduling.SchedulingException: Could not start Quartz Scheduler; nested exception is org.quartz.SchedulerConfigException: Failure occured during job recovery. [See nested exception: org.quartz.impl.jdbcjobstore.LockException: Failure obtaining db row lock: Table "QRTZ_LOCKS" not found; SQL statement:
SELECT * FROM QRTZ_LOCKS WHERE SCHED_NAME = 'quartzScheduler' AND LOCK_NAME = ? FOR UPDATE [42102-176] [See nested exception: org.h2.jdbc.JdbcSQLException: Table "QRTZ_LOCKS" not found; SQL statement:
SELECT * FROM QRTZ_LOCKS WHERE SCHED_NAME = 'quartzScheduler' AND LOCK_NAME = ? FOR UPDATE [42102-176]]]
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:176)
at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:51)
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:346)
at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:149)
at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:112)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:772)
at org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:139)

You have to manually create the quartz tables... the plugin does not do
that for you. Download the quartz package from quartzscheduler.org and
create the tables for your DB under the doc directory. Or set
quartz.jdbcStore = false, for the RAMStore (no database).
On Fri, Jan 22, 2016 at 6:45 PM, netadmin2015<EMAIL_ADDRESS>wrote:

Java 18
Grails 3012
removed all cache files from anywhere I can think of
New project: grails create-app junk1
add compile 'orggrailsplugins:quartz:205' to buildgradle
grails
create-job Testme88
Edit Testme88Job and put:
1 package testme66
2
3 class Testme88Job {
4 static triggers = {
5 simple name: 'mySimpleTrigger', startDelay:5000, repeatCount: 1
6 }
7
8 def execute() {
9 logdebug("Domain name job processing");
10
11 }
12 }
All seems good
Now
run-app
Lots of errors, This is the start of them
Grails 3 / quartz 205 / java 18 / groovy 245
I am at a loss why I cannot get jobs to work
Honestly grails 245 I do not have any issues and may not even upgrade to
grails 3 as it seems to be a completely different animal
Any ideas ?
From scratch out of the box does not seem to work at all
HealthIndicatorAutoConfigurationDiskSpaceHealthIndicatorConfiguration

matched (OnPropertyCondition)
Exception in thread "main"
orgspringframeworkcontextApplicationContextException: Failed to start bean
'quartzScheduler'; nested exception is
orgspringframeworkschedulingSchedulingException: Could not start Quartz
Scheduler; nested exception is orgquartzSchedulerConfigException: Failure
occured during job recovery [See nested exception:
orgquartzimpljdbcjobstoreLockException: Failure obtaining db row lock:
Table "QRTZ_LOCKS" not found; SQL statement:
SELECT * FROM QRTZ_LOCKS WHERE SCHED_NAME = 'quartzScheduler' AND
LOCK_NAME = ? FOR UPDATE [42102-176] [See nested exception:
orgh2jdbcJdbcSQLException: Table "QRTZ_LOCKS" not found; SQL statement:
SELECT * FROM QRTZ_LOCKS WHERE SCHED_NAME = 'quartzScheduler' AND
LOCK_NAME = ? FOR UPDATE [42102-176]]]
at
orgspringframeworkcontextsupportDefaultLifecycleProcessordoStart(DefaultLifecycleProcessorjava:176)
at
orgspringframeworkcontextsupportDefaultLifecycleProcessoraccess$200(DefaultLifecycleProcessorjava:51)
at
orgspringframeworkcontextsupportDefaultLifecycleProcessor$LifecycleGroupstart(DefaultLifecycleProcessorjava:346)
at
orgspringframeworkcontextsupportDefaultLifecycleProcessorstartBeans(DefaultLifecycleProcessorjava:149)
at
orgspringframeworkcontextsupportDefaultLifecycleProcessoronRefresh(DefaultLifecycleProcessorjava:112)
at
orgspringframeworkcontextsupportAbstractApplicationContextfinishRefresh(AbstractApplicationContextjava:772)
at
orgspringframeworkbootcontextembeddedEmbeddedWebApplicationContextfinishRefresh(EmbeddedWebApplicationContextjava:139)

—
Reply to this email directly or view it on GitHub
https://github.com/grails-plugins/grails-quartz/issues/53.

RAMStore not working from 2.0.1. Pull request awaiting!:)

Using grails, the development mode has a database that is removed after you stop-app. I guess I could put those create tables in the Bootstrap and have them run each time. I assume version 2 had all this by default and it was removed for this version of the plugin.
I am use to (spoiled) by the Grails 2 version of everything. Grails 3 in almost every situation requires handholding.  I decided to just download the jar files and not use the plugin. Found out that grails 3 does not even have a lib directory anymore.
Anyhow thanks again.

Use 2.0.1 plugin version! Or wait before rvanderwerf apply my pull at last.
https://github.com/grails-plugins/grails-quartz/pull/51

this was fixed with #50 as far as the referred pull request and released today


Add vector3 iterator

🎉 New feature
Closes #33
Summary

added iterator for Vector3 with begin()  and end() functions.
Test it

added test at Vector3_Test  Iterator, I could turn it to examples but I don't know how to edit the make files.
Checklist

[ x] Signed all commits for DCO
[ x] Added tests
[ ] Added example and/or tutorial
[x ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina @scpeters 3 days !!?

As a beginner open source contributor, this is disappointing.

@KareimGazer , are you planning to continue working on this PR? Let us know how we can help. Thanks!

No, it was hard to install tools, and I didn't receive help or attention. Now, I'm busy with my engineering studies.
a better contribution and installation guide would be helpful instead of scattered wikis across versions.

Ok, I'll close it for now, feel free to reopen if you ever want to get back to it.


Show Orchestrator info when clicking on a delegator

Right now if you click on a delegator in the eventViewer, it clears your current selected orchestrator info
On clicking an address in the event viewer, set a loading screen in the orchestrator viewer, if getOrchestrator returns an empty list, getOrchestratorByDelegator (separate issue)  and remove the loading screen once we have an orchestrator. If we do not have an O at this point, show an error
In src/livepeer.js render the OrchestratorViewer if we have a loaded Orchestrator object, else the text

On clicking an address dispatch both a delegator request and a orchestrator request

Fixed and pretty quickly now that caching for delegators/orchestrators is fixed.
Can be improved later


compose_ui: Revert changes for replace_syntax done in 1ca4566eb2.

This commit reverts the changes for replace_syntax in 1ca4566eb2 and we again use JS replace instead of replace from text-field-edit.
We do this change because replace from text-field-edit leaves the replaced text selected, which we don't want. This change is temporary and we can probably use replace method from text-field-edit once this issue is fixed in upstream.
Discussion - https://chat.zulip.org/#narrow/stream/9-issues/topic/selection.20after.20upload

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Looks good to me!


When using an ImageWriter with 'Code39' the add_checksum option is ignored

When using the generator function to create a 'Code39' barcode, the writer_options={'add_checksum': False} is ignored.
The addition of the check digit happens during the class init which hasn't received the writer_options.
I have a fix for this by moving the check into the render function and adding  an instance variable to track when it has been added.  (I wasn't sure if the render function could end up being called more than once and didn't want additional check digits adding.
Will create a PR for the fix.

Breaking code:
generate('code39', my_bar_code, writer=ImageWriter(), output='fp_svg', writer_options={'add_checksum': False})
Continued to add a checksum.

I believe this is fixed. Lemme know if you still have any issues.

I still have this issue on version 0.14. Did something change?
c_barcode = '201822052211050114571102'
barcode.generate('code39', c_barcode, output='barcode_image', writer=ImageWriter(), writer_options={ 'add_checksum': False})
It renders a letter at the end of the generated code.


Source Code cleanup, null checks and collection ordering

Closes no issue
Changes:

Order collection when it's created so it's not needed to sort it on every method call.
Remove blank lines
Check for nulls during item insertion instead of doing it when we need to use the collection

Outstanding! Thanks very much David. Keep at it.


Wrong tab

7 should be Cryptography tab and not the Request Handling tab.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54caa849-b978-ca6c-c44f-dd043f25d1a2
Version Independent ID: d7327f1d-f884-c2fd-b04d-d423142ee935
Content: Configure the Workstation Authentication Certificate Template (Windows 10)
Content Source: windows/security/identity-protection/windows-firewall/configure-the-workstation-authentication-certificate-template.md
Product: w10
GitHub Login: @brianlic-msft
Microsoft Alias: justinha

@schnitz76 Thanks, the topic has been corrected.


fix: update required ibm provider version to < 1.7

Error: [ERROR] Error deleting serviceID: Unable to find object.
Unrelated to code changes, re-running..

/run pipeline


Breaking Change in Header Styling from Index 0 to Index -1 in Tag 0.13.0 -> 0.13.1

From tag 0.13.0 to tag 0.13.1, there was a breaking change where the header styling in the table changed from index 0 to index -1 (a great improvement, by the way). However, this affected several scripts after updating the library.
I suggest we use the Semver standard for new tags 1.0.1, ..., 2.1.0 to avoid surprises, especially for developers who use go get -u=patch ./....

I almost forgot, the README.md and the code comments became outdated after this change.

Thanks, @joaogmguimaraes, and apologies about the change in API. We'll put this on our to-do list, but feel free to open a PR with the fixes if you'd like, too.


Remove duplicate functions and update function signature

Removed duplicate functions. Functions were duplicated by the implementation of: https://github.com/weareprestatech/hotpdf/pull/58
Renamed extract_page to extract_page_text
Made page for extract_page_text to be required.
Added tests for new functions

@callegarimattia it makes more sense to have get_page_text to have page number as mandatory. Makes usage easier


Clazy cleanup

Clazy analysis and code cleanup. Except for narrowing and vice-versa, most of warning was about:
warning: overrides a destructor but is not marked 'override' [inconsistent-missing-destructor-override]
warning: signal shouldn't be const [clazy-const-signal-or-slot]
warning: signal arguments need to be fully-qualified  [clazy-fully-qualified-moc-types]
warning: slot arguments need to be fully-qualified [clazy-fully-qualified-moc-types]
warning: enumeration value 'None' not explicitly handled in switch [switch-enum]
warning: Missing emit keyword on signal call [clazy-incorrect-emit]
warning: 'break' will never be executed [unreachable-code-break]
warning: Don't call QList::operator on temporary [clazy-detaching-temporary]
warning: 'qsrand' is deprecated: use QRandomGenerator instead [deprecated-declarations]

A huge work! I'll look though it, thanks!

A huge work! I'll look though it, thanks!

When you're going to merge it, I will start the other PR with code style (I still don't know which one though).

When you're going to merge it, I will start the other PR with code style (I still don't know which one though).

There is requestet changes, that's why this one hasn't been merged.

Please, re-submit after rebasing and implementing the request.


TextField two-way binding

I'm trying to two-way bind the TextField.Value but for some reason it does not work. Here is my code:
        <TextField Label="Anything" Type="text"<EMAIL_ADDRESS>                                   @bind-Value="@Name" OnChange="OnNameChanged"/>

        private string m_str = "Hello";
        private string Name
        {
            get { return m_str; }
            set
            {
                m_str = value;
            }
        }

        private void OnNameChanged(ChangeEventArgs args)
        {
            string temp = Name;
            temp = args.Value?.ToString();
            temp = null;
        }

This is a server-side application. The Name.get method is called and used by the TextField, however the set method is never called. Interesting that the OnNameChanged is called but the Name is always the original "Hello".
The same code with InputText works however.
Can you help me what am I doing wrong?
Thanks! :-)
PS: Great job with this library :-)

hi. thanks.
currently the components are not @bind friendly. when you are using bind you might not need the change handler.
can you try the below code?
        <TextField
               Label="Anything"
              Type="text"
<EMAIL_ADDRESS>              Value="@Name"
             OnChange="OnNameChanged" />

        private string m_str = "Hello";
        private string Name
        {
            get { return m_str; }
            set
            {
                m_str = value;
            }
        }

        private void OnNameChanged(ChangeEventArgs args)
        {
            Name = args.Value?.ToString();
        }

I'm coming to Blazor from WPF where two-way binding is heavily used and IMHO makes the code simpler - at least for me :-)
I understand - today this is a limitation.

sure. i understand that. as this library relied on react way of data flow and when i started that time blazor bind was not there. hence not tested bind feature. should be easy to identify and fix that. will do in next release

Next release you mean version 3.0 of your components? Would be great!

Binding is added in 5.1.0 release.
<TextField
          Label="Anything"
          Type="text"
<EMAIL_ADDRESS>          @bind-Value="@Name" />

@code
{
     private string Name { set; get; }
}

closing the issue now. feel free to re-open if required.


Create Apa-Itu-Fintech.mdx

👷 Deploy Preview for batpay processing.

Name
Link

🔨 Latest commit
c51a233bf90bf7a6232918aa886c11bce53f7730

🔍 Latest deploy log
https://app.netlify.com/sites/batpay/deploys/64d4848ff6afbd000874246a


spec.componentKinds not sufficiently described

In README.md spec.componentKinds lack descriptions for the 'group' key. This seems to be either empty, core or apps in the samples. Please describe.
Also the GroupKind is written as a link, but the link target does not exists.

The group key refers to the resource's API Group.
The README description should be updated to add that link. Also, I just noticed the README has an example where the group field is empty. This was originally a short-hand for "core", but I believe the short-hand is now discouraged.

Thanks for the explanation. Before I send a PR to update it, do I understand right that the purpose of specifying the componentKinds is additional filtering on top of the label selector?

It is more like a necessity so that the client (e.g. a console UI) knows which APIs to list (before matching against the label). It does also have the implication of being an additional filter on top of the label.

FYI, there is a PR in https://github.com/kubernetes-sigs/application/pull/74 since two weeks, that ways for review/merge.


Removes self-referential link

Removes link redirects to the current page.
Link in question:
https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/

Thanks @johnaoss for your contribution!
/lgtm
/approve


Web SDK sending info via searchParams

Summary
This PR

updates coop check to return compatibility result
sends over app info to SCW FE via search params for better understanding window.opener reliability issue, including

SDK name, version
app origin
coop compatibility

How did you test your changes?
Unit Test + Manually verified work as expected
https://github.com/user-attachments/assets/1a71a599-2fdb-4d6e-9ec2-4ac3255cb4a9

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

@fan-zhang-sv will you add a demo video to the PR please? Thank you.

@cb-jake included demo in description 🙏


Dealing with lambda cold starts in the real-time data pipeline

The blog post is also available in Google Doc: https://docs.google.com/document/d/1N_3vd_IJpnqAVrtTufF1AiGTbgBEmDxHvbs144nq5lU/edit?tab=t.0


Update Get-SPEnterpriseSearchLinguisticComponentsStatus.md

Format example

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Get-SPEnterpriseSearchLinguisticComponentsStatus.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Right-click to close all displays error

Description
When I set the language to Simplified Chinese, the 'close all' option displays as '关闭关闭' I think it should be '关闭全部'

DBeaver Version
DBeaver Community 23.2.5
Operating System
Windows 10
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

Thank you for bug report. It's a duplicate of #17697


Ply reader

This adds support for reading from ply files, of the format:
ply
format ascii 1.0
comment ...
element vertex 2440181
property float x
property float y
property float z
property float nx
property float ny
property float nz
end_header

BTW, this worked straight up amazing on 3 million point ply files. Resulting in this rendering:
https://www.youtube.com/watch?v=BbkCnsKESJU
Thankyou very much!

Thanks! I'll make some small changes to the code

If you have the time, maybe consider rewriting it using custom structs instead of using the HashMap based access? See e.g. https://github.com/Fluci/ply-rs/blob/master/examples/read_ply_to_structs.rs

Yeah, OK.
I was going to do this, but couldn't implement the trait on na::Vector3 directly (I wonder if there is a workaround for this?), and it seemed kinda invasive to add those structs just for one file format.
I will look at this in the next couple of days.
Thanks!

Yeah, right. I think one could work around this by introducing a transparent newtype:
use nalgebra::Vector3;

#[repr(transparent)]
struct Vec3r(Vector3<Real>);

implementing the trait on this and then just transmuting the result of the parser from Vec<Vec3r> to Vec<Vector3<Real>>.
Although in general, I don't really like that the PropertyAccess trait does not support any error reporting as it only returns Options and not Resultss... But I guess missing or unparsable components of the vectors should usually not be a problem (as PLY files are usually created by other software that probably writes correct files), and in the rare case this happens, one can still give a respective message in the panic.
One thing we should make sure later though is to give meaningful errors if you try reading e.g. a file with doubles as a f32 Vec.


Create Sorted_squares.java

here I solved question number  977 of leetcode and want to contribute to your repo hope it help other
Issue Id you have worked upon - nik132-eng
Briefly explain your program logic -
it is a simple, function calling algorithm
Screenshots(Attach 2 screenshots of your own input and output) -

Checklist:
Eg - If your code follows the below guidelines. Kindly change [] to [x]
All the conditions should be fulfilled for considering your code for merging -
[] I have mentioned the question as a comment in my solution file.
[] My code follows the guidelines of this project.
[] I have performed a self-review of my own code.
[] I have commented on my code.
[] My code gives the correct output.
[] I confirm that I have not copied the code from anywhere. In case it's found that I have copied I can be banned from the repository.
[] I affirm that I strictly follow contributing guidelines and code of conduct.

@nik132-eng,
Kindly create an issue first and get it assigned to you.

ok sir, Sorry I am new at GitHub and open source contribution just a few minutes ago solve this problem and want to contribute.it maybe helps others.

ok sir, Sorry I am new at GitHub and open source contribution just a few minutes ago solve this problem and want to contribute.it maybe helps others.

NO worries, I welcome beginners. You may ask as many questions as you want to to clarify your doubts. Feel free

if all things are perfect so can you please accept my PR?
it helps me in hacktoberfest.

@nik132-eng,
Kindly fill the PR templete properly


test_profile.py::TestIpother FAILS against some version

We need a Root Cause Analysis.

i figured this one out, this is due to the absence of DESCRIPTION argument for this resource, however despite the 400 error, the resource is created. I will refactor this test to accomodate

resolved


[ISSUE #4349]: Fix the potential 'IndexOutOfBoundsException' etc

Make sure set the target branch to develop
What is the purpose of the change
For #4349
Brief changelog

Fix the potential IndexOutOfBoundsException
queueId may be a negative value, fix it.

Verifying this change
XXXX

Codecov Report

Merging #4350 (28c58d3) into develop (82a48be) will decrease coverage by 0.10%.
The diff coverage is 14.28%.

@@              Coverage Diff              @@
##             develop    #4350      +/-   ##
=============================================
- Coverage      48.18%   48.08%   -0.11%
+ Complexity      5082     5067      -15
=============================================
  Files            642      642
  Lines          42770    42775       +5
  Branches        5597     5599       +2
=============================================
- Hits           20609    20567      -42
- Misses         19655    19688      +33
- Partials        2506     2520      +14

Impacted Files
Coverage Δ

...pache/rocketmq/client/latency/MQFaultStrategy.java
16.32% <0.00%> (-1.07%)
:arrow_down:

...etmq/client/latency/LatencyFaultToleranceImpl.java
48.10% <33.33%> (-1.25%)
:arrow_down:

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (-9.38%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-8.96%)
:arrow_down:

...org/apache/rocketmq/store/ha/WaitNotifyObject.java
66.07% <0.00%> (-5.36%)
:arrow_down:

...ava/org/apache/rocketmq/filter/util/BitsArray.java
59.82% <0.00%> (-2.57%)
:arrow_down:

...va/org/apache/rocketmq/logging/inner/Appender.java
34.83% <0.00%> (-2.25%)
:arrow_down:

...a/org/apache/rocketmq/filter/util/BloomFilter.java
60.43% <0.00%> (-2.20%)
:arrow_down:

...mq/client/impl/consumer/RebalanceLitePullImpl.java
72.05% <0.00%> (-1.48%)
:arrow_down:

...a/org/apache/rocketmq/store/StoreStatsService.java
36.41% <0.00%> (-1.13%)
:arrow_down:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a48be...28c58d3. Read the comment docs.

Coverage decreased (-0.001%) to 52.147% when pulling 28c58d3ee9d2001fbff3e141dd5b43385f40f778 on XiaoyiPeng:issue#4349 into 82a48be00a6d9def14abb871a40cb68cf8a041e9 on apache:develop.

Coverage decreased (-0.001%) to 52.147% when pulling 28c58d3ee9d2001fbff3e141dd5b43385f40f778 on XiaoyiPeng:issue#4349 into 82a48be00a6d9def14abb871a40cb68cf8a041e9 on apache:develop.

I think modify this method is better.

This method want to return a positive value, but fail in above situation.

Good catch! IMO its better to modify incrementAdnGet method.

@ni-ze , @HScarb ,
Thanks for your review.
But IMO,  For code consistency, I recommend not changing this method ThreadLocalIndex#incrementAndGet(), because this method is used in many places.
In most scenarios, it determine whether the result returned is positive or negative after the call, as  shown below:

And it we changing this method(ThreadLocalIndex#incrementAndGet()), The variable index it returned  may still be a positive number, eg: Integer.MAX_VALUE.  when Math.abs(++index) is called, we still need to judge if this value is negative, just looks like in the screenshot.
Hi @panzhi33 , @RongtongJin  what's your opinion?

@ni-ze , @HScarb ,
Thanks for your review. But IMO, For code consistency, I recommend not changing this method ThreadLocalIndex#incrementAndGet(), because this method is used in many places. In most scenarios, it judge whether the result returned is positive or negative after the call, as shown below:

And if we changing this method(ThreadLocalIndex#incrementAndGet()), The variable index it returned may be a positive number(eg: Integer.MAX_VALUE). when Math.abs(++index) is called, we still need to judge if this value is negative, just looks like in the screenshot.
Hi @panzhi33 , @RongtongJin what's your opinion?

I think it is better to modify org.apache.rocketmq.client.common.ThreadLocalIndex#incrementAndGet.

I think it would be better to change ThreadLocalIndex#incrementAndGet(): if index reaches Integer.MAX_VALUE, set it to 0 instead of incrementing it.

OK, Thanks for your review,sir.
I will check  whether this solution is compatible with the current usage of ThreadLocalIndex#incrementAndGet() .

Hi, @caigy :
I noticed that this issue has been solved in another PR #4447.  I will close this PR.


Local Storage Example

Hello, thanks for your work on Gren, it looks like a really exciting project. I was looking through the examples and noticed that there was one for local storage, which I was pleased to see, especially with the tasks api. I can't get this to work on my computer as the LocalStorage module is missing and I can't find it in any of the Gren repos. Is there any way to install this? @aaalvik I think you provided the example.

Hi.
Unfortunately, the LocalStorage API isn't finished yet. It's under development though, and we hope to finish it in H2 2022.

No worries, I'll revisit this later in the year!

The web-storage package has now been released, and the example has been updated :)


Give xsd files a maximum 1 minute cache time

XSD files were recently added to our website and they have an odd cache time of 7 days instead of 1 minute like the rest of the core files.
This pull allows xsd files to get a 1 minute max-age,

Not sure why XML files are being assigned a "gzip encoded" header even though they aren't being compressed.
Could be a bug. Neither do I know where the XML files are being used or served so I couldn't test the behaviour.


feat(crash-feedback): 🚀  add sentry implementation

This PR is related to #19
@MrBamBam You had some suggestions to use the sentry/react version and to potentially include an errorboundary(hook) ?

When I heard about using sentry I thought it would be nice to implement it with something that empowers the developers to get more insightfull logging. This to me feels helpfull as it's more than what we currently have, however I think using this in combination with something like ErrorBoundary feels like the right implementation to me.
So tldr; Catch all for unexpected (and unaccounted for errors), but also enable specific logging in the way of using errorBoundaries to handle errors gracefully (while still getting logged).

When I heard about using sentry I thought it would be nice to implement it with something that empowers the developers to get more insightfull logging. This to me feels helpfull as it's more than what we currently have, however I think using this in combination with something like ErrorBoundary feels like the right implementation to me.
So tldr; Catch all for unexpected (and unaccounted for errors), but also enable specific logging in the way of using errorBoundaries to handle errors gracefully (while still getting logged).

It would be very useful to also upload the sourcemap to sentry at build time, which helps in debugging errors. Can you add this?
Also would be nice if you could add a bit of documentation on this, as it requires setting up some env vars, generating an api key in sentry, etc. :)
Regarding the error boundary, to me it would be fine if it was a different issue / branch too, since it's not required for sentry to function.

It would be very useful to also upload the sourcemap to sentry at build time, which helps in debugging errors. Can you add this?
Also would be nice if you could add a bit of documentation on this, as it requires setting up some env vars, generating an api key in sentry, etc. :)
Regarding the error boundary, to me it would be fine if it was a different issue / branch too, since it's not required for sentry to function.

closes issue #19

closes issue #19

closes #19

closes #19


Version 0.3.26 requires S3::Object#content(true) to fetch object contents

It appears that fc4d193 introduced a change that has initialized @content in S3::Object#initialize. By doing this if defined?(@content) returns true, thus returning a nil object.
I made a short test to isolate and verify the issue. Small test and output over various Ruby versions can be located in a gist.
Unfortunately I'm not sure what the intent is behind fc4d193 so I'm not really able to submit a PR for this.

I think the main intent was reducing amount of warning messages in Ruby 2.4. Thank you for describing the issue accurately. I'm pretty sure we could replace the defined? with @content ||=  and it should work fine as well. Are you able to submit a proper PR to fix it?

@qoobaa Hi, I opened #126 which should address this.


OpenSSL 1.1.0 s_server doesn't work with secp384r1 and secp521r1

As the title says, 1.1.0 s_server is not working with secp384r1 and secp521r1, but at 1.0.2a it is ok.
I tried OpenSSL 1.1.0 and OpenSSL 1.0.2a with curves from ecparam -list_curves and these 2 curves differs.
OpenSSL 1.0.2a s_client and s_server - both curves are ok
OpenSSL 1.1.0 s_server:
error:1417A0C1:SSL routines:tls_post_process_client_hello:no shared
cipher:ssl/statem/statem_srvr.c:1422

then OpenSSL 1.1.0 s_client:
error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake
failure:ssl/record/rec_layer_s3.c:1382:SSL alert number 40

Keys and certs generated by:
openssl ecparam -genkey -name prime256v1 -out ca.key
openssl req -x509 -batch -new -key ca.key -out ca.cert -subj '/CN=ca'

for t in server client; do
          openssl ecparam -genkey -name prime256v1 -out $t.key
          openssl req -batch -new -key $t.key -out $t.csr -subj "/CN=$t"
          openssl x509 -req -CAkey ca.key -CA ca.cert -CAcreateserial
-in $t.csr -out $t.cert
          rm -f $t.csr
done

s_server command:
openssl s_server -key server.key -cert server.cert -CAfile ca.cert
-sigalgs ECDSA+SHA384:ECDSA+SHA256 -Verify 1 -named_curve secp384r1

s_client command:
openssl s_client -connect localhost:4433 -cert client.cert -key
client.key -CAfile ca.cert -tls1_2 -sigalgs ECDSA+SHA384:ECDSA+SHA256

Yes, @vdukhovni independently discovered this same issue recently. The problem is that in 1.1.0 the supported curves affect both ECDHE and ECDSA. They should really be independent of each other. This means you can't use a different curve in your ECDSA certificate to the curve used for ECDHE.
Ping @vdukhovni and @snhenson, how do we progress this?

The correct approach is outlined in the TLS 1.3 draft.  We need to choose a certificate that matches a client supported signature algorithm if possible, but otherwise go with some default certificate.
What this means for OpenSSL is that the server's ECDHE curve list SHOULD  NOT be used to constrain the server's certificate.  While we must choose the ECDHE curve based on the intersection of the server and client supported curves list, the server certificate need only appear on the client curve list, and the server curve list should be ignored in this context. In addition if the only EC certificate uses a curve that is not on the client's supported curves list, and we have no alternative (RSA or DSA) certificate to choose from, we just go with the certificate we have, and leave its ultimate suitability up to the client.

Actually the supported curves list affects ECDH and ECDSA in both 1.1.0 and 1.0.2. The difference is that the -named_curve option works by changing the list of server supported curves in 1.1.0: it didn't in 1.0.2.

Sure, so we may also need to fine-tune 1.0.2 at some point, with the 1.1.0 situation being a bit more "urgent" as it is not backwards-compatible.  Are you willing to take this on, or will it have to wait for me to find the time?

I would like to use ECDHE with the secp384r1 curve to adhere to NSA's suite B, is there a workaround at the moment?

ics-openvpn/issues/721

Did you come up with a plan how to fix this issue? haproxy is a nice tool to trigger this issue.

@darix LibreSSL?

My focus area is chain verification, which is rather separate from SSL protocol cipher selection, ...  I hope that @mattcaswell will take a look at this, and decouple the certificate from supported curves...

My focus area is chain verification, which is rather separate from SSL protocol cipher selection, ... I hope that @mattcaswell will take a look at this, and decouple the certificate from supported curves...

Such as PR #5601?
That only fixes master though. A different fix would probably be needed for 1.1.0. Do we want that?

Yes Please. Even it it is just to fix https://discourse.haproxy.org/t/haproxy-openssl-1-1-and-ecdsa-certs/2229

I think official fix would be very welcome for distributions and other users that will remain on 1.1.0 branch for a while. Some cannot immediately move to 1.1.1

I still seem to be suffering from this issue when using a TLS openvpn server that uses ECDSA certs signed using the brainpoolP384r1 curve. The server, using openssl 1.1.0h, starts ok, but when a client, also using 1.1.0h, tries to connect the connection fails. A client using 1.0.2o connects fine. Using certs signed using secp384r1 means the client using 1.1.0h can then connect.

I still seem to be suffering from this issue when using a TLS openvpn server that uses ECDSA certs signed using the brainpoolP384r1 curve. The server, using openssl 1.1.0h, starts ok, but when a client, also using 1.1.0h, tries to connect the connection fails. A client using 1.0.2o connects fine. Using certs signed using secp384r1 means the client using 1.1.0h can then connect.

Sounds like a different issue. An OpenSSL client in 1.1.0 does not send the brainpool curves in its default supported groups list. It used to in OpenSSL 1.0.2. That's a deliberate policy change. You can customise that using SSL_CTX_set1_curves_list() or SSL_set1_curves_list() on the client side.

Oh ok, apologies if this is the wrong place. I was just following the chain of github issues with openvpn that seemed to lead here.
I did actually add SSL_CTX_set1_curves_list(ctx->ctx, "brainpoolP384r1"); to src/openvpn/ssl_openssl.c before compiling, as I had read that that would fix this issue, but that was on the server side. I'll try adding to client and see if that helps. Thanks

@eccgecko what you're experiencing sounds like #2237


HTTPS support

This relates more to the instance at wzrd.in than this codebase, but it would be great if wzrd.in supported HTTPS so it could be used on SSL-only sites like some Mapbox documentation pages.

shipped thanks to @konklone !


Improves CI & fixes no_std

Improves CI:

switches to actions-rust-lang/setup-rust-toolchain
adds cargo-hack powerset check (checks all feature combinations)
adds cargo clippy check
adds rustfmt check

Fixes no_std
Fixes a few other odds and errors caught by cargo-hack

No idea why its failing to run:
jobs:
    hack:
        name: cargo hack
        runs-on: ubuntu-latest
        steps:
            - uses: actions-rust-lang/setup-rust-toolchain@v1
            - uses: taiki-e/install-action@cargo-hack
            - run: cargo hack check --feature-powerset --no-dev-deps

Run cargo hack check --feature-powerset --no-dev-deps
  cargo hack check --feature-powerset --no-dev-deps
  shell: /usr/bin/bash -e {0}
info: --no-dev-deps modifies real `Cargo.toml` while cargo-hack is running and restores it when finished
error: process didn't exit successfully: `/home/runner/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/cargo metadata --format-version=1 --no-deps` (exit status: 101)
--- stderr
error: could not find `Cargo.toml` in `/home/runner/work/jsonptr/jsonptr` or any parent directory

Error: Process completed with exit code 1.

@asmello i copied over jonhoo/rust-ci-conf and one of the checks that's failing is miri. Could you look at the output when you get a chance please?

There are two failing checks that I do not know how to resolve:
Miri
~/dev/jsonptr  improve-ci ✔                                               5m  ⍉
▶ cargo +nightly miri test
   Compiling jsonptr v0.5.0 (/Users/chance/dev/jsonptr)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.14s
     Running unittests src/lib.rs (target/miri/aarch64-apple-darwin/debug/deps/jsonptr-42b38b1574134774)

running 26 tests
test assign::tests::test_assign_json ... error: Undefined Behavior: trying to retag from <271676> for SharedReadOnly permission at alloc70916[0x4], but that tag does not exist in the borrow stack for this location
   --> /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/raw.rs:140:9
    |
140 |         &*ptr::slice_from_raw_parts(data, len)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |         |
    |         trying to retag from <271676> for SharedReadOnly permission at alloc70916[0x4], but that tag does not exist in the borrow stack for this location
    |         this error occurs as part of retag at alloc70916[0x4..0x8]
    |
    = help: this indicates a potential bug in the program: it performed an invalid operation, but the Stacked Borrows rules it violated are still experimental
    = help: see https://github.com/rust-lang/unsafe-code-guidelines/blob/master/wip/stacked-borrows.md for further information
help: <271676> was created by a SharedReadOnly retag at offsets [0x5..0x8]
   --> src/pointer.rs:860:15
    |
860 |     let ptr = s.as_ptr().offset(-1);
    |               ^^^^^^^^^^
    = note: BACKTRACE (of the first span) on thread `assign::tests::test_assign_json`:
    = note: inside `std::slice::from_raw_parts::<'_, u8>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/slice/raw.rs:140:9: 140:47
note: inside `pointer::extend_one_before`
   --> src/pointer.rs:862:17
    |
862 |     let slice = slice::from_raw_parts(ptr, len);
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside closure
   --> src/pointer.rs:189:41
    |
189 |                     let back = unsafe { extend_one_before(back) };
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^
    = note: inside `std::option::Option::<(&str, &str)>::map_or_else::<(token::Token<'_>, &pointer::Pointer), {closure@src/pointer.rs:184:17: 184:19}, {closure@src/pointer.rs:185:17: 185:32}>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/option.rs:1206:24: 1206:28
note: inside `pointer::Pointer::split_front`
   --> src/pointer.rs:181:9
    |
181 | /         self.0[1..]
182 | |             .split_once('/')
183 | |             .map_or_else(
184 | |                 || (Token::from_encoded_unchecked(&self.0[1..]), Self::root()),
...   |
191 | |                 },
192 | |             )
    | |_____________^
note: inside `assign::json::assign_value`
   --> src/assign.rs:251:41
    |
251 |         while let Some((token, tail)) = ptr.split_front() {
    |                                         ^^^^^^^^^^^^^^^^^
note: inside `assign::json::<impl assign::Assign for serde_json::Value>::assign::<serde_json::Value>`
   --> src/assign.rs:240:13
    |
240 |             assign_value(ptr, self, value.into())
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `pointer::Pointer::assign::<serde_json::Value, serde_json::Value>`
   --> src/pointer.rs:397:9
    |
397 |         dest.assign(self, src)
    |         ^^^^^^^^^^^^^^^^^^^^^^
note: inside `assign::tests::Test::<serde_json::Value>::run`
   --> src/assign.rs:584:28
    |
584 |             let replaced = ptr.assign(&mut data, assign.clone());
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside closure
   --> src/assign.rs:572:61
    |
572 |             tests.into_iter().enumerate().for_each(|(i, t)| t.run(i));
    |                                                             ^^^^^^^^
    = note: inside closure at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:815:29: 815:36
    = note: inside closure at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/adapters/enumerate.rs:108:27: 108:51
    = note: inside closure at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/array/iter.rs:271:13: 271:77
    = note: inside closure at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/ops/try_trait.rs:392:39: 392:46
    = note: inside `<std::ops::index_range::IndexRange as std::iter::Iterator>::try_fold::<(), {closure@std::ops::try_trait::NeverShortCircuit<()>::wrap_mut_2<(), usize, {closure@<std::array::IntoIter<assign::tests::Test<serde_json::Value>, 19> as std::iter::Iterator>::fold<(), {closure@<std::iter::Enumerate<I> as std::iter::Iterator>::fold::enumerate<assign::tests::Test<serde_json::Value>, (), {closure@std::iter::Iterator::for_each::call<(usize, assign::tests::Test<serde_json::Value>), {closure@src/assign.rs:572:52: 572:60}>::{closure#0}}>::{closure#0}}>::{closure#0}}>::{closure#0}}, std::ops::try_trait::NeverShortCircuit<()>>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:2410:21: 2410:32
    = note: inside `<std::iter::ByRefSized<'_, std::ops::index_range::IndexRange> as std::iter::Iterator>::fold::<(), {closure@<std::array::IntoIter<assign::tests::Test<serde_json::Value>, 19> as std::iter::Iterator>::fold<(), {closure@<std::iter::Enumerate<I> as std::iter::Iterator>::fold::enumerate<assign::tests::Test<serde_json::Value>, (), {closure@std::iter::Iterator::for_each::call<(usize, assign::tests::Test<serde_json::Value>), {closure@src/assign.rs:572:52: 572:60}>::{closure#0}}>::{closure#0}}>::{closure#0}}>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/adapters/by_ref_sized.rs:45:9: 45:68
    = note: inside `<std::array::IntoIter<assign::tests::Test<serde_json::Value>, 19> as std::iter::Iterator>::fold::<(), {closure@<std::iter::Enumerate<I> as std::iter::Iterator>::fold::enumerate<assign::tests::Test<serde_json::Value>, (), {closure@std::iter::Iterator::for_each::call<(usize, assign::tests::Test<serde_json::Value>), {closure@src/assign.rs:572:52: 572:60}>::{closure#0}}>::{closure#0}}>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/array/iter.rs:267:9: 272:11
    = note: inside `<std::iter::Enumerate<std::array::IntoIter<assign::tests::Test<serde_json::Value>, 19>> as std::iter::Iterator>::fold::<(), {closure@std::iter::Iterator::for_each::call<(usize, assign::tests::Test<serde_json::Value>), {closure@src/assign.rs:572:52: 572:60}>::{closure#0}}>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/adapters/enumerate.rs:114:9: 114:58
    = note: inside `<std::iter::Enumerate<std::array::IntoIter<assign::tests::Test<serde_json::Value>, 19>> as std::iter::Iterator>::for_each::<{closure@src/assign.rs:572:52: 572:60}>` at /Users/chance/.rustup/toolchains/nightly-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:818:9: 818:31
note: inside `assign::tests::Test::<serde_json::Value>::all::<[assign::tests::Test<serde_json::Value>; 19]>`
   --> src/assign.rs:572:13
    |
572 |             tests.into_iter().enumerate().for_each(|(i, t)| t.run(i));
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `assign::tests::test_assign_json`
   --> src/assign.rs:604:9
    |
604 | /         Test::all([
605 | |             Test {
606 | |                 ptr: "/foo",
607 | |                 data: json!({}),
...   |
748 | |             },
749 | |         ]);
    | |__________^
note: inside closure
   --> src/assign.rs:601:26
    |
599 |     #[test]
    |     ------- in this procedural macro expansion
600 |     #[cfg(feature = "json")]
601 |     fn test_assign_json() {
    |                          ^
    = note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)

cargo test
cargo test --locked --all-features --all-targets
  shell: /usr/bin/bash -e {0}
  env:
    CARGO_HOME: /home/runner/.cargo
    CARGO_INCREMENTAL: 0
    CARGO_TERM_COLOR: always
 Downloading crates ...
   I don't encounter it locally.

Will look into the miri report, could be a legitimate find, could be a limitation of its unsafe lifetime checker.
As for the other one, I think it's because quickcheck has an issue with a transitive dependency, where their locked version doesn't match the one we resolve with the default version resolver. Will also give it a look but we may need to hack the Cargo.toml to workaround until they fix it upstream.

Second one was solved by specifying the most recent versions of serde (1.0.203) and serde_json (1.0.119).

Ah, I forgot I also switched to -Zdirect-minimal-versions
I'm guessing neither change (using most recent versions and not using -Zminimal-versions) are optimal, though.

Yeah the miri thing goes deep into Rust intrinsics. I have a few theories, having to do with how Rust (or miri) tracks borrows for a given memory span. I suspect the borrows are tagged at the start of the span, and by shifting the pointer we invalidate the tag that was tracking its lifetime. Not sure how something like get_unchecked causes a new tag to be pushed onto the stack — if it didn't, it'd run into a similar issue.
Probably the easiest solution is to avoid the pointer arithmetics. I have a few alternatives I want to try that should be just as performant, and lean more heavily on composition over std primitives, which should keep miri happy.

I'm guessing neither change (using most recent versions and not using -Zminimal-versions) are optimal, though.

I think using the most recent version is fine as a workaround, since we already have those as optional dependencies regardless. But for future reference, I believe the way to get around that error otherwise would be to add a section like this to the cargo manifest:
[target.'cfg(any())'.dependencies]
serde = { version = "x.y.z", default-features = false, optional = true }

The trick being that this forces -Zminimal-versions to account for the version we want, but doesn't affect the dependencies we actually build with (due to the target selection being the empty set).

Hah, I saw a comment by Jon in DOCS.md from his actions repo and assumed it was a typo. That is such a weird syntax.
It must not have been serde. I can't infer from the error output what dependency it may be. I'm not seeing anything jump out at me from cargo tree --frozen --edges all --verbose.

Miri is quite slow, we may need to tune it to only run for a subset of tests or not at all unfortunately...
Let me see if I can find out which dependency quickcheck is failing on (it's not the end of the world to use the direct variant if not).

Nah don’t worry about the dep. I’ll figure it out. You’ve got the unsafe
bit which I can’t help with at all right now.
On Mon, Jul 1, 2024 at 5:20 PM André Mello @.***> wrote:

Miri is quite slow, we may need to tune it to only run for a subset of
tests or not at all unfortunately...
Let me see if I can find out which dependency quickcheck is failing on
(it's not the end of the world to use the direct variant if not).
—
Reply to this email directly, view it on GitHub
https://github.com/chanced/jsonptr/pull/51#issuecomment-2201092739, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIGFZCLFNGJ2AXAHZWDXLLZKHBY7AVCNFSM6AAAAABKETGMO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBRGA4TENZTHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The only crate which would make sense to me at the moment is syn but syn only appears to be used by quickcheck_macros

I think that's exactly right, the CI error does point to that crate (sorry if I confused you by saying it was quickcheck, didn't look very closely...).
I think this is what we need:
syn = { version = "1.0.109", optional = true }

Yay, it worked! Also relevant: https://github.com/BurntSushi/quickcheck/pull/317
I guess little chance we can get the fix pushed upstream, but we can try... Should be a trivial patch version bump...

Yay, it worked! Also relevant: https://github.com/BurntSushi/quickcheck/pull/317

Rock on!
I don't understand why we have to be explicit here though. Why is the resolver introducing<EMAIL_ADDRESS>when the only dependent is quickcheck_macros and it specifies 1.0:
syn = { version = "1.0", features = ["full"] }

I'm going to go ahead and merge this in.

I don't understand why we have to be explicit here though. Why is the resolver introducing<EMAIL_ADDRESS>when the only dependent is quickcheck_macros and it specifies 1.0:
syn = { version = "1.0", features = ["full"] }

It's the other way around! The -Zminimal-dependencies resolver works the opposite of the normal resolver, and will pick the smallest version that satisfies the constraints in the manifest. Since quickcheck-macros has 1.0 as the constraint, the normal resolver will pick 1.0.109, which works just fine, while the minimal resolver will pick 1.0.0, which fails. This reveals a bug both in syn and in quickcheck-macros - the former having done a breaking change in a patch release, and the latter having a dependency on a higher version that it specifies.
The workaround, on our end, is to specify the smallest version of syn that compiles quickcheck-macros successfully. We could do so by directly listing out the version among our dependencies, but that's kinda unfortunate, since we don't actually use it. So instead we do this trick of Jon's, where we add a dummy target with that version, which constrains the resolver, making it pick the correct version (hence the minimal-dependencies build succeeds), but doesn't actually change our dependencies when compiling for a real target.

I didn't mean to seem dubious about the solution. I'm stoked about it!
That was just my general confusion being expressed. Thanks for solving it.

No worries, man, it didn't read like that. 👍

It's the other way around! The -Zminimal-dependencies resolver works the opposite of the normal resolver, and will pick the smallest version that satisfies the constraints in the manifest. Since quickcheck-macros has 1.0 as the constraint, the normal resolver will pick 1.0.109, which works just fine, while the minimal resolver will pick 1.0.0, which fails. This reveals a bug both in syn and in quickcheck-macros - the former having done a breaking change in a patch release, and the latter having a dependency on a higher version than what it specifies.

Ah! I was under the impression it was picking up 2.0, assuming that 1.0 -> 2.0 introduced the breaking change. I didn't anticipate the breaking change having occurred in 1.0.0 -> 1.0.9. In @BurntSushi's defense, I wouldn't have expected a change in dependency versions to introduce a breaking change for downstream users.
Thank you for the explanation!

Edit: actually, wow, I just realized that this isn't the result of him changing versions. Merely that he needs to specify exactly 1.0.109 (or whichever version introduces the change).

This! Yeah it's a really easy pitfall... That's why Jon recommends this check in CI, even though it can be annoying due to transitive problems. It's a sign of brokenness with cargo, but in general I've found that specifying the full version down to patch is the best approach, as dependabot can ensure we still receive patch updates automatically.


:logout fails

using 0.0.9 on OpenBSD, :logout command from #162 exists (eg :log<tab> completes it) but it fails with Failed command: Invalid argument

You need to specify the account you want to log out of to avoid accidentally logging out of the wrong account. Try logging out with :logout @user:example.com.


Node 0.8

Can wobot be updated to allow installation with Node >= v0.8.0? The series is pretty far along now.

It is not working with Node 0.8x anymore. There are included node_modules that require >= 0.10 and npm install wobot breaks with all various engine errors.
I even see:
npm WARN deprecated<EMAIL_ADDRESS>Please use node-xmpp-client / node-xmpp-server / node-xmpp-component
Can anyone post an example of how to install this without errors in a modern environment?

Ah! Nevermind. Wobot is working with Node v4.0.0. The install warning seems meaningless.
I made the mistake of TRYING to use 0.8x then everything broke.
The initial trouble with Node v4.0.0 was simply some configuration issues with the node package that uses wobot.


Update Excel (Angular) quick start

Fix issues that were created when Yo Office was recently rev'd.
Remove mkdir and cd steps from all Yo Office quick starts.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/excel/excel-add-ins-get-started-angular.md
:white_check_mark:Succeeded

docs/images/yo-office-excel-angular.png
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-angular.md
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-jquery.md
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-react.md
:white_check_mark:Succeeded

docs/includes/file-get-started-onenote.md
:white_check_mark:Succeeded

docs/includes/file-get-started-powerpoint.md
:white_check_mark:Succeeded

docs/includes/file-get-started-project.md
:white_check_mark:Succeeded

docs/includes/file-get-started-word.md
:white_check_mark:Succeeded

docs/quickstarts/excel-quickstart-angular.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Runtime and Results

Hello, author. I spent about 2 hours running the MVTec classification work on an RTX 4070. Is this time reasonable? The results under 1-shot are about 1 point lower (for MVTec) and 5 points lower (for VISA) compared to the data in your paper. Is this normal, or could there be some other issue?

Please provide the hyperparameters for your running code
@.***
From: kirnde
Date: 2024-10-18 22:50
To: FuNz-0/PromptAD
CC: Subscribed
Subject: [FuNz-0/PromptAD] Runtime and Results (Issue #21)
Hello, author. I spent about 2 hours running the MVTec classification work on an RTX 4070. Is this time reasonable? The results under 1-shot are about 1 point lower (for MVTec) and 5 points lower (for VISA) compared to the data in your paper. Is this normal, or could there be some other issue?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I used the default settings from the original code, with 100 epochs. Today's experimental results show that the VISA results are similar to those in the paper, but the MVTec results are about 1-2 points lower. The results from three runs are exactly the same. Is the runtime for this experiment considered long? It mainly relies on the CPU, and the GPU consumption is not very high.

The sampling of the training data has an impact on the results of the model. You can try different samples
The reason for high CPU utilization is that most of the tests are performed on the CPU

@.***
From: kirnde
Date: 2024-10-21 20:36
To: FuNz-0/PromptAD
CC: FuNz; Comment
Subject: Re: [FuNz-0/PromptAD] Runtime and Results (Issue #21)
I used the default settings from the original code, with 100 epochs. Today's experimental results show that the VISA results are similar to those in the paper, but the MVTec results are about 1-2 points lower. The results from three runs are exactly the same. Is the runtime for this experiment considered long? It mainly relies on the CPU, and the GPU consumption is not very high.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


input hook for qt option... cannot undo

From<EMAIL_ADDRESS>on 2014-05-10T17:14:26Z
Spyder Version:  2.2.5
Python Version:  2.7.6
Qt Version    :  4.8.3, PyQt4 (API v2) 4.9.4 on Darwin
pyflakes >=0.5.0:  0.4.0 (NOK)
pep8 >=0.6      :  None (NOK)
IPython >=0.13  :  2.0.0 (OK)
rope >=0.9.2    :  None (NOK)
sphinx >=0.6.6  :  None (NOK)
matplotlib >=1.0:  1.3.1 (OK)
sympy >=0.7.0   :  0.7.3 (OK)
pylint >=0.25   :  None (NOK)
What steps will reproduce the problem?
1.Console->external Modules->Install Spyder's input hook for qt 2. 3.
What is the expected output? What do you see instead?
Cannot open python or ipython shells.
Please provide any additional information below
. I was trying to make the matplotlib window active, so that I could use it interactively to save figures.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1815

From ccordoba12 on 2014-08-23T14:07:34Z
I solved this in 2.3.0, and will be improved in 2.3.1 (to be released in a week or so), so please update.
Status: WontFix


can not query gpu nodes

Description
user can not query GPUs nodes and know if the nodes have GPUs implemented on them or not .
networks :testnet,mainnet.

Yes, This was removed from tfchain and subsquid indexer. see here for more context.


OLS-241: Set tls to disabled by default for now

Description
https://github.com/openshift/lightspeed-service/pull/524 is going to enable tls by default, but the operator isn't ready for TLS to be enabled, so this disables
TLS for now.
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

/assign @xrajesh
@raptorsun @xrajesh ptal
@nemerna fyi, this should make it safe for https://github.com/openshift/lightspeed-service/pull/524 to merge.


Ensure Requestor Info validation shows error growl

Details
Follow up to this PR, which was accidentally merged early.
Adds the Growl for non-server errors on the Requestor Info VBA step. These errors are not yet displayed in the error Modal, so we need to continue to show with the Growl.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/175331
Tests
0) Test Setup

Create a new user
From the global create menu, tap 'New Workspace', then the 'Get Started' button
Tap 'Connect Manually' and use the data from this StackOverflow post to fill the Routing and Account number

1) Verify that Modal validation errors DO NOT show as a Growl

Using the stack overflow post, fill each field except 'Company Website', leave that as https://
Hit 'Save & Continue'
You should see the Company Website field highlighted red with an error message
You should see a Modal popup with an error message
You should NOT see a Growl with the same message

2) Verify that server errors DO show as a Growl

Continue from the end of test 1
Enter a valid website
Set the 'Phone Number' field to  12345678
Hit 'Save & Continue'
You should see a Growl with an error message
You should NOT see the field highlighted red
You should NOT see a Modal popup

2) Verify that unhandled validation errors DO show as a Growl

Continue from the end of test 2
Enter valid information in every field
Hit 'Save & Continue'
At the 'Requestor Information' step, enter first and second name only
Hit 'Save & Continue'
Fix each error one by one, ensure a Growl message shows for each
These will be changed to Modal validation in a separate issue

QA Steps
Run above tests
Tested On

[x] Web
[ ] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web

Mobile Web
Desktop

iOS

Android

🚀 Deployed to staging by @marcaaron in version: 1.0.88-3 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

@Julesssss We will test this via the Bank-account/new flow. We currently don't have access to the "Get started" button since all our testing domains already have the expensify card.

Hi @isagoico, that makes sense. Is this how you have tested all other Bank account PRs up to now?

Yes! we have used this method for those PRs.

Thanks, then the plan sounds fine. I'll just tag @MitchExpensify and @kevinksullivan to ensure we test internally in addition.

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Update README to list "features" of S3 connector

I came up with these features.  Please add comments for updates

Generic S3 object store queries (hive not required)
Tested on Dell Technologies Elastic Cloud Storage (ECS), Scality CloudServer and MinIO Object Storage Server
Supports CSV, JSON, Parquet and Avro input
Snappy and gzip compressed files
Create table support (CSV and JSON), including 'Create Table AS'
Uses Dell Schema Registry for dynamic table creation, but also supports static configuration of tables using JSON configuration files

We might want to mention explicitly that we use the AWS S3 client. I'm also thinking that we should mention the S3 Select support.
"Dell Schema Registry" is the Pravega schema registry, right? https://github.com/pravega/schema-registry


Fix tests

🤔 What's changed?

Fixed a failing test around output from find getting .NET project paths
Refactored that code a bit to remove duplication of the buggy bit
Fixed a failing test for GPG key
Added a self-test for the test runner to make this less likely to happen again.
Refactored the test runner, while I had my attention on it

⚡ What's your motivation?
When we introduced shellcheck (#46), I inadvertently changed the test runner so it didn't actually pick up on failures anymore! I didn't notice this as the build was green and I didn't think to check it. This was fixed in https://github.com/cucumber/polyglot-release/commit/a2f92f5e5ad8e0490bb22acf0b774c582a7b315d but there's no guarantee it won't happen again.
Green build; working app!
🏷 What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

♻ Anything particular you want feedback on?
Is there a simpler way to get find to return a clean relative path instead of ./Project.sln?
📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code

[x] I have added/updated tests to cover my changes.

This text was originally generated from a template, then edited by hand. You can modify the template here.

I broke protocol and just merged this, following the "doesn't make it any worse" principle.

Still happy to receive feedback though!


Fix most CI-Pipeline problems

The CI-Pipelines shows a lot of possible problems where most of them should be adressed

Merged in #115


Remove EOL Python, Django and DRF versions

Remove all no longer supported Python, Django and DRF versions. Also fixes #684 as after Python 3.8 no workaround is necessary.
Closes #702

Hey @Andrew-Chen-Wang,
Can you take a look at this PR?
Thanks!

Python 3.12 has been released and pkg_resources is not installed by default in venv.
This means djangorestframework-simplejwt doesn't work on 3.12 if users forget to install pkg_resources aside.
Therefore this PR is very important to ease python 3.12 upgrade 🙂

DeprecationWarning's are now being thrown because of this, which will fail tests that set warnings as errors. It would be great to get this merged and released onto PyPI.

love it thank you!


Remove lazy_static dependency

Do we have to have VK_LIB as a static? Can there be an API exposed for the user to hold it, instead?

Did you open this on the wrong repo? ash has no such dependency, nor any such variable.

Did you open this on the wrong repo? ash has no such dependency, nor any such variable.

Looks like #194 already removed lazy_static as a dependency. This has been released since version 0.29.0 (Apr 27, 2019).

Looks like #194 already removed lazy_static as a dependency. This has been released since version 0.29.0 (Apr 27, 2019).

Wonderful news! Bugs that are fixed in the past are best kinds of bugs :) I just had an older copy of Ash, where I saw that, and I didn't check the recent one.

Wonderful news! Bugs that are fixed in the past are best kinds of bugs :) I just had an older copy of Ash, where I saw that, and I didn't check the recent one.


Issue/stackoverflow logger 1000903

Please read the commit messages for detailed information about the content of this pull request.
In short, this pull request fixes:

The stackoverflow exception that was occurring when the console appender was being enabled.
When running in headless mode, set the default log level to DEBUG and always enable the console appender.
No more: No appenders could be found for logger (ScalaPlugin). at startup.

Go ahead with the merge.

The first commit (474110d9a067cb2fe841b44a51d64a159819a10b) doesn't to be related to the same problem.

Merging it manually in master.


enableAnnotationCache needed?

When I try the incremental index and I set enableAnnotationCache property I get the following error 400. Once removed it works fine:
{
"error": {
"code": "",
"message": "Configuration property 'enableAnnotationCache' is not supported."
}
}
Probably useful to add in the doc that the actual cache will be found under the blob storage provided, inside a new container called ms-az-search-indexercache-somebinarycode

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fee6d54-cebf-e17a-3cfd-8ff346e947ec
Version Independent ID: 2d50c9c9-9d28-2d30-b12a-dd00d3af37e6
Content: Add incremental indexing (preview) - Azure Cognitive Search
Content Source: articles/search/search-howto-incremental-index.md
Service: cognitive-search
GitHub Login: @vkurpad
Microsoft Alias: vikurpad

@ignaciofls , Thanks for raising the issue. We will investigate and update you.

@ignaciofls, Apologies for the delay! Thanks for bringing this to our attention. I seem to see the same behavior. I have shared your feedback with the content author (@vkurpad) to review further and update the document as appropriate.

@vkurpad, Requesting your comments on this.

@AjayKumar-MSFT @ignaciofls @vkurpad   I get a 400 if the indexer does not have a skillset, but 204 if it does.  Skillsets are required for incremental indexing. For clarity, I'm going to request that we rename the feature to "incremental enrichment".
By the way, the error about skillset requirement only shows up if I try to set "storageConnectionString" by itself (without "enableReprocessing": true line).
I'm updating the docs to make sure the steps are clear about the skillset requirement. I'm also closing this issue because I think I found the right fix, but if you disagree, please re-open.
#please-close


Sync up the validator with the latest grammar from the matcher.

Also, updated some test cases to work with the latest grammar.

Looks great! Thanks, @chisholm


enveloped-signature must go first for verification to work properly

Hi, i was dealing with a verifying problem.
[ 'invalid signature: for uri #_0 calculated digest is I6QnT6OKRlqeJXVGIb/UIiV1k/ArtW5/fAJkjGoxP8Y= but the xml to validate supplies digest 3g7fAmI5/vWlkDLK4zlU3/GSmjdFOlOCGs+pNMNqSVM=' ]
The calculated digest when verifying was different from the generated when signing.  The problem i had was the order of the transform algorithm.
Have to change mi code from
beforeChanges :

sig.addReference("//*[local-name(.)='CFE']", [ "http://www.w3.org/2001/10/xml-exc-c14n#","http://www.w3.org/2000/09/xmldsig#enveloped-signature"])

afterChanges:
sig.addReference("//*[local-name(.)='CFE']", ["http://www.w3.org/2000/09/xmldsig#enveloped-signature", "http://www.w3.org/2001/10/xml-exc-c14n#"])

The problem with the first code, was that exclusive-canonicalization algorithm returns a string and enveloped-signature can't find signature form string, it must recibe node format to work ok.  This can be repaired adding one line of code on enveloped-signature.js

EnvelopedSignature.prototype.process = function (node) {
  node = new Dom().parseFromString(node)  // new line
  var signature = xpath(node, ".//*[local-name(.)='Signature' and namespace-uri(.)='http://www.w3.org/2000/09/xmldsig#']")[0];
  if (signature) signature.parentNode.removeChild(signature);
  return node;
};

Not sure if it would be wright to support both transformation orders ([ "http://www.w3.org/2001/10/xml-exc-c14n#","http://www.w3.org/2000/09/xmldsig#enveloped-signature"] or [ "http://www.w3.org/2000/09/xmldsig#enveloped-signature","http://www.w3.org/2001/10/xml-exc-c14n#"])

I think you are on the right track based on this spec: https://www.w3.org/TR/xmldsig-core/ in 6.6.3 XPath Filtering

Each signature must omit itself from its own digest calculations, but it is also necessary to exclude the second signature element from the digest calculations of the first signature so that adding the second signature does not break the first signature.

Yes @markstos I agree with that. The doubt I have is, say you have this code
<xmltosign>
<data>....</data>
<signature>....</signature>
</xmltosign>
When verifiying, the envelope-signature transformation indicates to remove signature node to before calculate the document digest, and the second transformation will indicate to normalice to exc-c14n document. I think this is the correct order and in fact it's what works properly with this library. But what I can't confirm is if it is a regulated thing by the standard (can't find it in the official documentation) or it's simple the logical order.  To sum up xml-crypto works fine with first order of transformation and fails to verify with the second order. If the order is a standardized thing perhaps an error message would save lot of time for those that get stucked on this.
I've already revolve the verifying stage but I have a hard time figuring the errors I was making and any error message would have been useful.
I'd be glad to help if is a valid requirement.

@ponyesteves , if you'd be willing to contribute a PR with a test suite, even if that PR is just a better error message, we'd love to have it. Please consider helping the community in this way.


Use errors.New() to output the error message and fix some typos

Use errors.New() directly to output the error message and fix some typos I found.
Signed-off-by: fate-grand-order<EMAIL_ADDRESS>

Codecov Report

Merging #2195 into master will decrease coverage by -10.01%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master    #2195       +/-   ##
===========================================
- Coverage   61.24%   51.23%   -10.01%
===========================================
  Files         125      125
  Lines       11450    11450
===========================================
- Hits         7012     5866     -1146
- Misses       3552     4838     +1286
+ Partials      886      746      -140

Impacted Files
Coverage Δ

blobs.go
62.5% <ø> (ø)
:white_check_mark:

errors.go
19.04% <ø> (ø)
:white_check_mark:

configuration/configuration.go
68.59% <100%> (ø)
:white_check_mark:

registry/storage/driver/gcs/gcs.go
0.4% <ø> (-68.94%)
:x:

registry/storage/driver/oss/oss.go
0.56% <ø> (-57.23%)
:x:

registry/storage/driver/s3-aws/s3.go
4.58% <ø> (-56.31%)
:x:

registry/storage/driver/s3-goamz/s3.go
0.5% <ø> (-50.76%)
:x:

registry/client/transport/transport.go
69.69% <ø> (-9.1%)
:x:

notifications/sinks.go
94.7% <ø> (+0.66%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f87c80...4f97629. Read the comment docs.

LGTM


Fix (#6984) doc links in OpenMetaData

Describe your changes :
Change NotFound links which were pointing towards docs

Type of change :

[x] Bug fix
[x] Documentation

@harshach Can you review above changes? I am bit confused over some of the links


Project structure refactor

Big project refactor here but should not see any externally facing behavior.
Summary of changes

Refactored module to use one file per function.
Moved to comment-based help instead of MAML and generated MD files using PlatyPS. This should make it easier to keep the help up to date and to include MD files in the RTD site.
Updated nuget.exe to <IP_ADDRESS>06.
Added chocolateyUninstall.ps1 script to Chocolatey package.
Update Linux/macOS tests to use PowerShell 6.0.0-rc and new pwsh executable name. #4214
Added VSCode tasks.
Updated build.ps1 to include common build tasks (PSScriptAnalyzer, Pester, BuildNuget) for the project and a basic implementation of task dependencies. Borrowed from @jaykul's gist. Not ready for psake tasks to manage psake just yet 😏

Related Issue
#226
#225
#197
How Has This Been Tested?
Manually ran test suite on Windows 10 and macOS with no issues. AppVeyor tests pass but oddly the Travis ones do not. This will have to be tracked down.
@PowerSchill, you added the Travis tests initially, maybe you can take a peek and see if I messed something up?
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I would recommend a tasks.json like this which is very similar to what we use on the PowerShell extension for VSCode.
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",

    "windows": {
        "options": {
            "shell": {
                "executable": "powershell.exe",
                "args": [ "-NoProfile", "-ExecutionPolicy", "Bypass", "-Command" ]
            }
        }
    },
    "linux": {
        "options": {
            "shell": {
                "executable": "/usr/bin/pwsh",
                "args": [ "-NoProfile", "-Command" ]
            }
        }
    },
    "osx": {
        "options": {
            "shell": {
                "executable": "/usr/local/bin/pwsh",
                "args": [ "-NoProfile", "-Command" ]
            }
        }
    },

    "tasks": [
        {
            "label": "CreateMarkdownHelp",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task CreateMarkdownHelp -Verbose"
        },
        {
            "label": "PublishPSGallery",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task PublishPSGallery -Verbose"
        },
        {
            "label": "PublishChocolatey",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task PublishChocolatey -Verbose"
        },
        {
            "label": "Test",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task Test -Verbose",
            "group": {
                "kind": "test",
                "isDefault": true
            },
            "problemMatcher": "$pester"
        },
        {
            "label": "BuildNuget",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task BuildNuget -Verbose"
        },
        {
            "label": "Analyze",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task Analyze -Verbose"
        },
        {
            "label": "Pester",
            "type": "shell",
            "command": "${cwd}/build.ps1 -Task Pester -Verbose",
            "problemMatcher": "$pester"
        }
    ]
}

This eliminates a number of warnings about the deprecated fields: suppressTaskName and taskName.

Thanks @rkeithhill. I'll make those changes.

A couple of other suggestions.  I wonder if we could put the nuget folder (and NugetPackageBuilder.ps1) under build since these are artifacts required to build the nuget pkg.  I like Joel's approach of putting the source under a folder called src.  To make this repo easier to import, you create a build task that copies the appropriate files into a folder under the repo root named with the upcoming version number e.g. psake\4.7.0.  This also helps with getting the generated help files put into place and if you authenticode sign the files, you can sign them in this output folder and not have to touch the original source files.
Given that, there should be a build task in build.ps1 and a corresponding build task in tasks.json that has the following setting:
            "group": {
                "kind": "build",
                "isDefault": true
            },

This will allow you to kick off a build with Ctrl+Shift+B.
Also, psake.ps1, psake-config.ps1 and psake.cmd are source files and should go under src. I don't think we need to ship the README.md, do you?  I think we'd be far better off with an about_psake.help.txt file to provide an overview of psake that would be accessible from the PowerShell help system.  I don't think that exists yet so maybe we create that for a future release (don't need to hold this one up for that).
Sorry, probably more feedback than you wanted.  :-)

RE this:
25:131ms> Invoke-psake -task test
psake version 4.6.0
Copyright (c) 2010-2014 James Kovacs & Contributors

Error: 11/20/2017 9:59:13 PM:
 +         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [<<==>>] Exception: Assert: Could not find the build file psakefile.ps1.

Should we rename the build.ps1 to psakefile.ps1??

I'm getting this error when I try to import the module in my WSL console:
/mnt/c/Users/Keith/GitHub/psake/psake/psake [project-layout ≡ +0 ~1 -0 !]
> ipmo ./psake.ps
psake.psd1  psake.psm1
> ipmo ./psake.psd1
LoadConfiguration : The term 'LoadConfiguration' is not recognized as the name of a cmdlet, function, script file, or
operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At /mnt/c/Users/Keith/GitHub/psake/psake/psake/psake.psm1:100 char:1
+ LoadConfiguration
+ ~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (LoadConfiguration:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

build.ps1 isn't a psake script so invoke-psake won't work on it. Just run .\build.ps1 -task test

Yeah, I guess if build.ps1 were a psake file you'd need a older version to bootstrap the build of psake. :-)

The term 'LoadConfiguration' is not recognized as the name of a cmdlet, function, script file, or
operable program.

Interesting. That is the same error that Travis spits out. https://travis-ci.org/psake/psake/jobs/305103591#L531
On my personal mac the tests clean. In the travis macOS build, Pester runs but fails on a few. Something is afoot.

Yeah, I guess if build.ps1 were a psake file you'd need a older version to bootstrap the build of psake. :-)

I wasn't ready to go that meta yet. 😄

Ah, case-sensitivity on Linux is biting us.  These two lines in psm1 should be:
$public = @(Get-ChildItem -Path (Join-Path -Path $PSScriptRoot -ChildPath 'public/*.ps1') -Recurse -ErrorAction Stop)
$private = @(Get-ChildItem -Path (Join-Path -Path $PSScriptRoot -ChildPath 'private/*.ps1') -Recurse -ErrorAction Stop)

I would recommend using EA stop because the SilentlyContinue was hiding the real error.
Also because we no longer support PS2, can we change the ModuleToProcess in the manifest to RootModule?

With the above fix, only two Pester tests fail on Linux:
    [-] dotNetCore1.1.0_should_pass 324ms
      Expected: {True}
      But was:  {False}
      52:             $psake.build_success | should -be $expectedResult
      at Invoke-Assertion, /home/hillr/.local/share/powershell/Modules/Pester/4.1.0/Functions/Assertions/Should.ps1: line 209
      at <ScriptBlock>, /mnt/c/Users/Keith/GitHub/psake/psake/tests/integration/spec.tests.ps1: line 52
    [-] dotNetCore2.0_should_pass 378ms
      Expected: {True}
      But was:  {False}
      52:             $psake.build_success | should -be $expectedResult
      at Invoke-Assertion, /home/hillr/.local/share/powershell/Modules/Pester/4.1.0/Functions/Assertions/Should.ps1: line 209
      at <ScriptBlock>, /mnt/c/Users/Keith/GitHub/psake/psake/tests/integration/spec.tests.ps1: line 52

This is probably something simple to figure out.

This line in tasks.json isn't needed:
    "type": "process",

Each of the tasks is declaring its type as shell.

OK latest changes are looking good on Linux.  Just those two test failures - and those are failing because I don't have dotnet installed in WSL.

Installed dotnet, now all Pester tests pass on Linux.

Awesome! I'm going to make your suggested changes re: src and create the Build task.

This is looking good!  Can you add this to the settings.json file:
  "files.exclude": {
    "**/.git": true,
    "?.?.?/": true
  },

This will prevent workspace searches from find matches in the output folders.

@rkeithhill Done.

Do you want to bump the PSD1 version number in this PR to 4.7.0 or are you waiting to do that in a separate prep-release PR?   Other than that, this PR is looking good!

I'll do another PR with the version bump and the final changes to the changelog.