Fix set null value on string property

What kind of change does this PR introduce?
This PR skip the null check on the expected type of a table column if it's a string.
What is the current behavior?
Because reflexion does not make difference between string and string?, updating text column with a null value failed :
System.ArgumentException: Expected Value to be of Type: String, instead received: .
at Supabase.Postgrest.Table`1.Set(Expression`1 keySelector, Object value)

What is the new behavior?
If a new value is of type string, the null check is bypassed.
Additional context
This should be improved with NullabilityInfoContext (https://devblogs.microsoft.com/dotnet/announcing-net-6-preview-7/#libraries-reflection-apis-for-nullability-information), but not available with netstandard2.0

LGTM! Thanks for the contribution @alustrement-bob


libnl: backport fix for updated object notifications

Backport the fix for updated object notifications, where the update was accidentially set to the update, not the updated object.
This fixes incomplete ecmp route update notifications.

Depends on https://github.com/bisdn/basebox/pull/438


Add PyTorch 1.5.0 to tests. Remove 1.2.0

This is a small change to make tests on PyTorch 1.5.0 available. I've removed tests on 1.2.0 as it would make the tests take much longer to leave them in and there was already an issue with 1.2.0 and Windows.  This way we can close issue #112

Weirdly it shows all my commits from my previous pull request, but I only made one new commit since then.

Good idea to move on from 1.2 and make everything good to go with 1.5!  Thanks for putting in the legwork here.  I think there are a couple places where things need to change in the code, namely grad_norm-->grad_norm.item() for info logging, and also the DistributedDataParallelCPU class (or whatever is the other one for CPU-only) is deprecated.  Anything else?

@astooke for grad norm, we should probably use an isinstance check to keep it backward compatible. I'm not sure what else 1.5 breaks, but those could possibly be revealed through testing


Capitalization: remove option, make "all" the fixed behavior

@nickbart1980 says:

When exporting to bibtex and biblatex, words in Zotero title fields that contain capital letters are protected by enclosing them in braces (except the first word) – that’s fine.
...
I don’t think a preference ‘Preserve capitalization’ is necessary at all (unless you are aware of users who say they never use biblatex styles that convert titles to sentence case [such as apa], and insist they do not want the extra braces).

The existence of the preference relates to my explanation in #383. I am taking liberties with the text as entered by the user; I need to have that optional. The default is set such that the behavior you mention is the default.


Consuming a message - How to detect if this is the last message on the partition

I am trying to establish if the message I am consuming is the last message on the partition. Trawling through the Confluent.Kafka lib I am able to get the current offset but not the end offset even the Offset.cs class seems to have this available.
Any guidance on how to achieved would be great. @mhowlett be great to get your thoughts

enable partition eof consume results by setting the EnablePartitionEof config property to true and testing IsPartitionEOF property.


Build improvements

The objective is to modernize our builds. The first commit updates all packages to their latest versions, except for Webpack. The second commit performs the upgrade to Webpack 4. The third commit includes the package-lock.json file in the repository since this is recommended and it allows for reproducible builds using pinned versions.
Fixes #9688.
Fixes #9000.

/botio-linux preview

/botio test

/botio-windows test

/botio-windows test

/botio-windows test

/botio-windows preview

@yurydelendik @brendandahl Unfortunately this doesn't solve the OOM errors on the bots. I think the only solution left is to increase the maximum allowed memory usage on the bots. For that, we need to set the environment variable NODE_OPTIONS="--max-old-space-size=4096" for a maximum of 4GB (which I hope is enough) on the bots. Could you make that persist on both bots or should be set it somewhere in the botio-files-pdfjs repository?

/botio-windows test

/botio-windows test

@timvandermeij do you want me to bump the default for max_old_space_size on the bots?

/botio-windows test

I also had to bump the node version to 8 to use NODE_OPTIONS. Let's see how it does...

/botio-windows test

/botio-windows test

/botio-windows test

/botio-windows test

Try with the bot on this time...
/botio-windows test

/botio-linux test

/botio-windows test

I'm afraid we need to do something about Webpack's excessive memory usage and perhaps the bundle size first before we're able to land this...

What's strange is your branch seems to build fine for me locally on MacOS, but the windows bot hangs forever (it doesn't run out of memory).

A bundle of master does eventually finish. It takes 16 minutes though!

Wow, that's not great. It works just fine locally on Linux for me too, so I'm not sure why the bots are struggling with this so much...

I simplified the commits and rebased onto the current master branch. Here we go...
/botio test

Fortunately there is some progress here. The bots are now passing the Webpack stage, which is where things broke previously. The unit tests and font tests also work now, but the regression tests still hang for both bots and browsers.
@brendandahl Can you see what's causing the timeout on the bots? Do they both use at least the latest LTS version of Node.js (8.11.2)? If possible, we can also upgrade to the latest stable version (10.3.0). Or perhaps both bots just need a reboot.

In the browser console:
ReferenceError: pdfjsLib is not defined[Learn More] driver.js:274:5
Driver
http://<IP_ADDRESS>:61499/test/driver.js:274:5
<anonymous>
http://<IP_ADDRESS>:61499/test/test_slave.html:35:18

/botio preview

/botio lint

/botio test

Yay! Does anyone have time to review this? I have amended the commits to have the latest versions of every package.

Thanks for the updates!

[d81ead787607028d954356fa89cfce6a9ba53f1f](Https://jekyllmio.io)


Fix the build.

Always define a glibc version check macro.
Regroup the Posix check more sensibly.

Simplified this based on comments.

I've merge the POSIX timer conditionals into a single place with an explanatory comment.
It looks like a definite improvement :)

Travis failure is unrelated.

Fixed glib -> glibc changes.

I've just verified that this builds on VMS.

I've just verified that this builds on VMS.

Then what prevents you from approving this? Mine wouldn't make the difference...

Mine wouldn't make the difference...

Actually, it would to me.  You see, I value your opinion, and I wanted to wait and see if you had anything more to say.

(I'll merge this, since I know @paulidale is away)

Merged.  4cd58771d8387c6bfbd0fd9936aaeb3ba63a6fe6

Thanks @levitte
@dot-asm your input was much appreciated and the result is better for it.
I'm still away but the place I'm staying has some limited capability to access the internet.  Not enough to pull down and merge repositories unfortunately.

Then enjoy your vacation and don‘t worry too much about repositories... :wink:


Make OpenAI model configurable via environ variables

OpenAI updates models by first allowing you to to upgrade manually, then eventually upgrading the pointer from the stable version. Because of this it would be nice to be able to keep the stable version as the default value, but allow environ variable configurability for easy upgrade. See screenshot from OpenAI new model announcement email below

Time to try out GPT-4.

She's been on it for a week :^)


Could not sign in

I followed the configuration readme section and set up all env vars, then I started leaf and tried to log in but couldn't, it returns status code 303, redirects to / then redirects back to /login.

What could be the problem? If I try to pass the wrong password, it returns the error message, so the entered password is correct. I'm on macOS. Log output is empty.

Did you set LEAF_SECURE_COOKIE=false? That's required if you're not accessing it over https.

No, I missed that.
Much thanks for the help, now it works:)

Excellent. I know that aspect is not very intuitive. I've added an issue to simplify it.


An unexpected error occurred: (', DeserializationError: (", AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'"))', 'Unable to build a model: (", AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'"))', DeserializationError(",  AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'")))

Package Name: from azure.mgmt.datafactory.models import TumblingWindowTrigger, TriggerReference
Package Version: azure-mgmt-datafactory 5.0.0
Operating System: Windows 10 64 bit
Python Version: 3.8.9

Describe the bug
While running this code facing issue:
An unexpected error occurred: (', DeserializationError: (", AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'"))', 'Unable to build a model: (", AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'"))', DeserializationError(",
AttributeError: 'str' object has no attribute 'get'", 'Unable to deserialize to object: type', AttributeError("'str' object has no attribute 'get'")))
Code:
`import trigger_config
from azure.identity import DefaultAzureCredential
from azure.mgmt.datafactory import DataFactoryManagementClient
from azure.mgmt.datafactory.models import TumblingWindowTrigger, TriggerReference
from azure.core.exceptions import HttpResponseError
subscription_id = trigger_config.SUBSCRIPTION_ID
resource_group_name = trigger_config.RESOURCE_GROUP
data_factory_name = trigger_config.DATA_FACTORY_NAME
trigger_name = 'test1'
pipeline_name = 'src2stg_accountsreceivable_edw_tedw_wf'
credential = DefaultAzureCredential()
adf_client = DataFactoryManagementClient(credential, subscription_id)
print("adf_client",adf_client)
pipeline_id = adf_client.pipelines.get(resource_group_name, data_factory_name, pipeline_name).id
print("pipeline_id", pipeline_id)
trigger_properties = TumblingWindowTrigger(
pipeline=pipeline_name,
frequency='Hour',
interval=24,
start_time='2024-02-08T07:00:00Z',
delay='00:00:00',
max_concurrency=1,
retry_policy={'count': 3, 'intervalInSeconds': 60},
depends_on=[]
)
print("trigger_properties",trigger_properties)
try:
trigger_reference = TriggerReference(type='PipelineReference', reference_name=pipeline_id)
print(trigger_reference,"trigger_reference")

adf_client.triggers.create_or_update(resource_group_name, data_factory_name, trigger_name, trigger_properties, trigger_reference)
print("Trigger created successfully.")

except HttpResponseError as ex:
print(f"Failed to create trigger: {ex.response.status_code}: {ex.message}")
except Exception as e:
print(f"An unexpected error occurred: {str(e)}")`
To Reproduce
Steps to reproduce the behavior:

Install the mentioned packages
Run the shared code
the error would occur than

Expected behavior
Trigger creation in the respected subscription of Azure Data Factory
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I am trying to create Trigger using SDK for python on Azure Datafactory and while achieving this facing the issue.

Hi @pj250183, thank you for opening an issue. If I'm reading your code correctly, it looks like the exception is coming from the except Exception as e: portion. Is this nested under the except HttpResponseError as ex: block? i.e. Is this exception coming from an exception while trying to run
print(f"Failed to create trigger: {ex.response.status_code}: {ex.message}")

? If that's the case, have you tried exposing the HttpResponseError directly, without attempting to parse it manually?
If possible, it would be great if you can reformat your code into a Python code block so it's more clear.
I'll loop in someone who should be able to help further; we'll get back to you as soon as possible.

Hi @pj250183
You have wrongly passed the parameter pipeline which should be an object instead of string. Please update the code as the sample below and try.
import trigger_config
from azure.identity import DefaultAzureCredential
from azure.mgmt.datafactory import DataFactoryManagementClient
from azure.mgmt.datafactory.models import TumblingWindowTrigger, TriggerPipelineReference, PipelineReference, TriggerResource
from azure.core.exceptions import HttpResponseError

subscription_id = trigger_config.SUBSCRIPTION_ID
resource_group_name = trigger_config.RESOURCE_GROUP
data_factory_name = trigger_config.DATA_FACTORY_NAME

trigger_name = 'test1'
pipeline_name = 'pipeline1'

credential = DefaultAzureCredential()

adf_client = DataFactoryManagementClient(credential, subscription_id)

trigger_properties = TumblingWindowTrigger(
    pipeline=TriggerPipelineReference(pipeline_reference=PipelineReference(reference_name='pipeline1', type="PipelineReference")),
    frequency='Hour',
    interval=24,
    start_time='2024-02-08T07:00:00Z',
    delay='00:00:00',
    max_concurrency=1,
    retry_policy={'count': 3, 'intervalInSeconds': 60},
    depends_on=[]
)

try:
    trigger = TriggerResource(properties=trigger_properties)
    adf_client.triggers.create_or_update(resource_group_name, data_factory_name, trigger_name, trigger)
    print("Trigger created successfully.")
except HttpResponseError as ex:
    print(f"Failed to create trigger: {ex.response.status_code}: {ex.message}")
except Exception as e:
    print(f"An unexpected error occurred: {str(e)}")


Fix malformed Git-PsRadar.psd1

I was not able to import the module because of the problems outlined in my response in #2. I'm not sure how the file got malformed (when clearly GitHub was able to read it), but I just copy-pasted the raw text output on GitHub into a UTF-16 LE file and saved over Git-PsRadar.psd1.
I might be wrong in doing this, open to whatever, but I do know that after doing this I was able to import the module just fine.

Module file converted to UTF-8


Is Visual Studio 2019 still in preview on hosted agent?

On this page it says that the  'windows-2019' hosted agent is still running Visual Studio 2019 Preview. Is it really still using the preview version now that the final VS 2019 is released?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99af681d-41ad-da15-0b72-08b5cd5a11ac
Version Independent ID: 2fa0df36-a437-8cbb-b019-b49b31b1e116
Content: Microsoft-hosted agents for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/agents/hosted.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

This PR looks related: https://github.com/Microsoft/azure-pipelines-image-generation/pull/745
From page

Version: VisualStudio/16.0.0+28711.60.rc.2

From the Agent Pool settings on my Azure DevOps

Version: VisualStudio/16.0.0+28729.10

CLosing as this should be resolved, let us know if not the case


build: build/gen everything out of src dir

Changes

v2 (since #583):

also include -I$(build_stagedir)/lib/flow and -I$(build_stagedir)/lib/common

Rationale
We don't want to have anything being built or generated inside the src
dir, this patch removes all the remaining resources being generated
there.
The only remaining resource being generated in the source dir is the
oic.json - which in my option should remain there.
See: https://github.com/solettaproject/soletta/issues/561
Signed-off-by: Leandro Dorileo<EMAIL_ADDRESS>

:+1:

+1

applied..


[#FLAT-462] Show loading spinner if data is loading

https://sourceclear.atlassian.net/browse/FLAT-462

:+1:


Plugin-API Command:args(args) parses given arguments as positional arguments inside quotes

What system are you running Yazi on?
Linux Wayland
What terminal are you running Yazi in?
foot version: 1.18.1 +pgo +ime +graphemes -assertions
yazi --debug output
Yazi
    Version: 0.3.3 (40211df 2024-10-01)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (Arch Linux 2024-09-05)

Emulator
    Emulator.via_env: ("foot-extra", "")
    Emulator.via_csi: Ok(Foot)
    Emulator.detect : Foot

Adapter
    Adapter.matches: Sixel

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-1")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : Some("/run/user/1000/sway-ipc.1000.1204.sock")
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/bin/bash")
    EDITOR             : Some("helix")
    VISUAL             : Some("helix")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : No such file or directory (os error 2)
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: No such file or directory (os error 2)
    magick           : 7.1.1-38
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.1
    chafa            : No such file or directory (os error 2)
    zoxide           : No such file or directory (os error 2)
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1

--------------------------------------------------

Did you try the latest nightly build to see if the problem got fixed?
Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried
Describe the bug
When I try to pass arguments to a command that is called via the plugin-API Command:args(args), the arguments are passed to the command as positional arguments, not as named arguments.
Example:
Calling Command("fd"):args({ "--type d" }):output() results in an error, because the command that is executed is fd "--type d" instead of fd --type d (notice the quotation marks in both examples).
For some commands this might work fine since they seem to be able to parse positional arguments as named arguments aswell, for example ls -l and ls "-l" both run fine, but there are some commands, like fd, which are not able to do that.
(Note: fd is just used as an example here, I know that there is an inbuilt fd but this is not relevant for this issue).
Minimal reproducer
-- ~/.config/yazi/test.yazi/init.lua
return {
  entry = function()
    local fd =
      Command("fd")
        :args({ "--type d" })
        :output()
  	ya.notify { title = "fd error", content = fd.stderr, timeout = 5, level = "error" }
  end
}

then call the plugin by using a keybinding in keymap.toml:
[manager]
prepend_keymap = [
        { on = "t", run = "plugin test", desc = "Test" },
]

Anything else?
No response

This is expected behavior. Yazi's Command API is a layer of abstraction over Rust's Command, so it follows Rust's parameter conventions.
You should use args({ "--type", "d" }) instead of args({ "--type d" }). You can see more examples at https://doc.rust-lang.org/std/process/struct.Command.html#method.args.


Remove horizontal scrolling from content listing

Most pages on our docs have horizontal scrolling, which we should do without. We already re-size/fold content based on window width, horizontal scrolling on top of that adds the following clipping effect.

@irfansharif, I just remembered that some pages required horizontal scrolling, for example, pages with broader SQL diagrams: https://www.cockroachlabs.com/docs/stable/configure-zone.html#synopsis.
I think the real fix is removing a horizontal scrollbar when no content exceeds the main body frame of the page. Does that sound reasonable to you?

SQL diagrams: https://www.cockroachlabs.com/docs/stable/configure-zone.html#synopsis.

IMO just the components that are that broad should have horizontal scroll, not the entire page.

Good point. That should be possible. @anagio, do you think you could squeeze this in at some point? I think you're the one to figure out how to make this happen. In a way, it's a variation of the other scrolling PR you have open, which is about making vertical scrollbars more visible: https://github.com/cockroachdb/docs/pull/6420.

I took a quick look. From what I can see, this will necessitate modifying the  tags around each SQL diagram to identify them as special components that require horizontal scroll. The diagrams currently do not have a  identifier. Example:

(From https://raw.githubusercontent.com/cockroachdb/docs/master/v19.2/configure-zone.md)
In short, we go through and audit which components require horizontal scroll, then modify their  tags. After that we can enable horizontal scroll for said components while disabling broadly.

hi, looping in as part of redesign work. @irfansharif do you have examples of those broad components that would merit horizontal scroll? my instinct is saying to remove it all together

I don't have an authoritative list, no, but the example I screen-shotted above was from https://www.cockroachlabs.com/docs/stable/install-cockroachdb-mac.html. I believe the pattern applies broadly, so I'd second your instinct.

Looks like this was fixed with the broader docs redesign. For example, on https://www.cockroachlabs.com/docs/stable/configure-zone.html#synopsis, when the screen is too narrow to show the complete diagrams, the scroll is just on those diagrams now rather than the entire body of the page. Closing, but if this is still a problem anywhere, we can reopen.

Thanks Jesse, that's great to see!


[Network] az network virtual-appliance connection: Add show and list commands for NVA connection

Related command

az network virtual-appliance connection show
az network virtual-appliance connection list
Description

This PR adds two new commands mentioned above. connection is a child resource of virtual-appliance
Testing Guide

az network virtual-appliance connection show : this command Gets the specified Network Virtual Appliance connection connected to a Network Virtual Appliance.

e.g.  az network virtual-appliance connection show -n <connectionName>  --nva <nvaName> -g <resourceGroupName> --subscription <subscriptionID>

az network virtual-appliance connection list : this command lists all the connections in the given virtual appliance

e.g. az network virtual-appliance connection list --nva <nvaName> -g <resourceGroupName> --subscription <subscriptionID>

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

Network

/azp run


Issues on development environment in other languages

Great starter, but i got the error in frontend
Uncaught Error: invariant expected app router to be mounted at useRouter"
I set up it several time using the readme and video tutorial.
At the end of the story, the issue was, that the startup used the locale "de" but nothing was available.
Maybe the error message should be adapted or ensure the starter is working on all machines.

@rengert thank you for the comment. Will look into it, and update if locale is not set to throw a more appropriate error.

Same for me. The middleware picks the preferred language from the 'Accept-Language' header. Which is German for me. You can easily modify the code to always use 'en' or remove 'de' from the i18n settings (there needs to be a match between preferred language and available languages). Anyway, there is a check, if page data is available in the requested language and if not, a language selector component should be displayed, avoiding any errors. But this is not working as expected, still don't found out why. But keep searching.

@mbieberstein I haven't had a chance to take a look in more detail into this issue yet, if you end up finding the issue first let us know or feel free to make a PR request.🙂

I have same issue when trying to open a link with newly added locale
Uncaught Error: invariant expected app router to be mounted at useRouter"

@eugene-beliaev  This is a next.js error. It complains about missing HTML and BODY tags in the response.
Look at my previous comment for an explanation.
The fallback mechanism for missing page data in a certain locale will never be reached, when the global configuration (navigation, etc.) is also not available in that locale. In that case the global layout.tsx returns null, which results in an empty layout. That's what next complains about.
in line 64 in frontend\src\app[lang]\layout.tsx you find this comment: // TODO: CREATE A CUSTOM ERROR PAGE
So, this seems to be work in progress. But I suggest to redirect to the default locale instead of treating this as an error.
Missing global configuration in a certain locale indicates, that there wont be any content available either.
@PaulBratslavsky In my opinion: The available locales should not be hard coded in the i18n configuration, but retrieved from the strapi localization api (needs to be public then).
At first, the preferred locale of the user is determined by the Accept-Language header: ok. If this preference does not match the available locales, a redirect to the (strapi) default locale takes place. But this fallback locale needs to be persisted in the user session (cookie), otherwise this roundtrip will happen on each subsequent request.
There should be a possibility for the user to select the locale (dropdown in navigation, etc.) to switch preferences. This selection should then update the cookie value, which functions as the 'master' locale.
Anyway, there needs to be content available in every supported locale, at least on the global level. If certain pages are not available in that locale, the fallback component should appear. But the link to the default locale needs to be dynamic, redirecting to the requested page, not home.
I am currently working on a POC for this mechanism and, as you suggested, will make a PR as soon as it works.


Downloaded media are not playable cleanup

Motivation and Context
Following #230 PR closed a bit quickly to send for external testing.
Description
Thank you to @defagos for the review in #230
Checklist

[x] The branch has been rebased onto the develop branch.
The code followed the code style:

[x] swiftlint has run to ensure the Swift code style is valid.
[x] rubocop -a has run to ensure the Ruby code style is valid.

[x] Remote configuration properties have been properly documented (if relevant).
[x] The documentation has been updated (if relevant).
[x] Issues are linked to the PR, if any.

I re tested the migration. ✅ Same expected changes as before, with a better logic and implementation.


MAINT: Pytest refactoring

Refactored the  asset classes to take advantage of pytest fixtures
re-enabled a test example that was originally skipped (it works on linux)

There are varying (small) numbers of tests failing with pandas 1.1, such as some of the example strategies.

There are varying (small) numbers of tests failing with pandas 1.1, such as some of the example strategies.
I can confirm on my machine (Debian 10, python3.8.5) that indeed pandas-1.1.5 is failing the test_examples.py , it wasn't such a bad idea to re-enable the tests_examples after all... (pandas-1.2.4 passes the test)
I haven't found the issue, the  error message is not helpful,  but I strongly suspect at the moment that pandas-1.1.5  can't properly load the data.

I think the example tests fail because there need to be data for each pandas version (see (example_data)[https://github.com/stefan-jansen/zipline-reloaded/tree/main/tests/resources] files - data and rebuild_. This should probably only be required per minor version.

Indeed I completely overlooked that (facepalm) .... pandas could be indeed considered mature enough for considering only minor numbering changes. BTW   rebuild_example_data hasn't been deleted from the repo when you added the missing extension


DB Column disappeared in Objective-C with Xcode8.1

Hi,
Using this SQLClient with iOS on macSierra and Xcode8.1, I've got a problem.
I'm retrieving image data from MSSQL DB, but I can not get the image field.
In other words, the Image field is not in the result of SQLClient query execute.
I can not use the key for image.
Please help.
Best Regards

Please try the types branch. This is the pre-1.0 release and has proper data type conversion.

Thanks for your reply. I will try.


Identifiers taking a long time due to using crypto/rand

First, thank so SO MUCH for this amazing package.  I didn't know it but incremental computation is something I've been wanting for a year or two for one of my projects, and your package has saved me a lot of effort and false starts.
One thing I noticed when doing testing, was that a significant amount of time in my testing was spent in rand.Read() when creating new identifiers: for the basic test with 200 input units (which results in probably 1-2k nodes), setting up the graph takes nearly 2 seconds.  Since the prototype "real" system has 8000 units, and I'm hoping to scale that into tens of thousands, that will be a significant issue.
I've done simple tests just replacing crypto/rand with math/rand, an the problem goes away.  Since I don't expect this to be a security-sensitive domain, I'd like at least the option of switching to math/rand.  (And you might consider defaulting to math/rand, and allowing people to opt into crypto/rand if they need the extra security.)
I'm happy to send you a PR, but I wanted to get your input on the best way to solve the issue.  I guess you'd want to pass that as an option to NewGraph(); but the problem is NewIdentifier() is called all over the place in contexts where graph isn't available.  So unless you ether just switch unilaterally to math/rand, or have a global variable for the rand source, it will require a lot of refactoring.
Let me know if you have any ideas.

Hey @gwd congrats on the first issue on this repo!
Yeah the choice of crypto/rand versus math/rand for identifier setup was motivated by google's choice for crypo/rand in their library for v4 uuids (https://github.com/google/uuid/blob/master/uuid.go#L9).
I think a narrow fix here is to use their pooled approach for spinning up identifiers to help with throughput. I'll take a crack at that tonight.

I had a free second right now, if you pull latest main it should have the new version of the identifier generator (using the pooled approach similar to google's). In local benchmarking it performed about as well as math/rand (i.e. a 2x speedup) but let me know if it does the same for you.

Specifically going forward, if math/rand is still significantly faster, I can add a top level setting function (e.g. UseInsecureRandomForIdentifiers(bool) to configure which random reader to use.
I'm hesitant to default to math/rand given crypto/rand is the existing behavior, but it would be an easy way to switch out for folks that do want the extra performance.

Hey!  Benchmarking a hotspot does seem to be the same between using math/rand and your new pool method.  Thanks for the quick response!

A couple bits of context

Profiling in go is a snapshot profiler, that is, every Q quantum a stack dump is taken of all the goroutines, their frames are aggregated (moving left to right basically is start to finish over the profiling period, but not really).
As a result, the "width" of a flamegraph segment can be thought of as "the relative amount of time a random stack trace has this function in it" which can mean one of two things; your code is spending a lot of time in that function because it takes a long time to execute, or that function is called very frequently.

Based on my testing, and unless something is very esoteric about your setup, there are not meaningful gains in switching to math/rand at this point. I went even so far as to test what would happen if you just binary encoded an atomically incremented uint64 as a [16]byte for the identifier, and it was basically the same as the pooled crypto rand read and the math/rand read. Further, math/rand.Read is marked as deprecated, and I would rather not have that lint warning + exception if possible.
All this to say, I think the identifier code is about as fast it can be.
The only other thing that jumps out from your flamegraphs (which are super helpful, btw!) is that in one you're using Map and the other you're using MapN; is that intentional? That might have some performance implications, but also likely not.
Finally, the library generally isn't super optimized for creating graphs, there is a lot of consideration given to computing the heights correctly on start, and deferring as little work as possible so that Stabilize calls are fast. This extends from the library generally being used in an "online" capacity where you eat the cost of instantiating ~8k nodes (1) time and then push a lot of updates through the graph with Stabilize over the lifetime of the program.
One last thing to zoom in on; how are you observing the graph? Is the entire graph required? Do you wait until the graph is mostly constructed before adding observers? This may help a bit in reducing the churn (a lot of work is done when you observe nodes, as that marks them as necessary and then the entire tree up from there).

So to give you some context: This incremental computation is replacing a SQL query that's about 7 layers deep.  The total computation has 3 "global" variables, then each "readunit" has 6 internal variables and 4 observation varibles, and each "word" has 9 internal variables and 6 observation variables; since a word may be in multiple readunits and each readunit has multiple words, you get quite a "web" of connections by the end.   So yes, some of the variables are maps of a fixed number of inputs, usually of different types (using Map); and some have an indeterminate number of inputs of the same  type (MapN).  The observation variables are basically necessary; the end computation will choose a specific "readunit" to study, but it's helpful for the end user to understand why a given readunit was chosen (i.e., because of the properties of this specific word -- hence the internal observation variables).
The vast majority of operations are incremental; and even with a "naive" implementation, it's already 4x faster than the SQL version.  I'm sure that could be made tens of times faster still by the judicious use of Cutoff().  So I definitely appreciate the work you've put in to make Stabilize fast.
But the performance of "opening" the connection is still something to think about, and there are a number of operations where it's awkward to modify the computation in-place: If, for instance, the mapping of readunit to words change, then excising the connections from MapN variables is a lot more work than just recomputing the whole tree.
One thing that's almost certainly an inefficiency in the current set-up function is that it will call Add() repeatedly for a MapN variable, even when a full slice's worth is known.  I actually only noticed yesterday that you can pre-populate MapN variables; that should git rid of the vast majority of growslice operations.  If adding observers as then last step would be more efficient, I could look at rearranging that as well.
Regarding samples: I understand in general how the samples work; but what I'm not sure of is, in the flame graph, how they interact with goroutines executing in parallel.  It looks like the time reported on the flame graph is wall-clock time; but of course the runtime does lots of work in background goroutines.  Having the growslice and other such work done by background goroutines would be one explanation of why slashing go-incr.NewIdentifier() would result in only a small improvement in wall-clock-time.
At any rate, let me do the optimizations I know I can do -- adding observers at the end, and adding contents of MapN() variables at creation when possible rather than repeatedly calling Add().  Then I'll try it again with idpool vs mathrand and see what results we get.
Thanks as always for your time, and the library!

Hey,  just a quick follow-up -- here's the results from adding all the observations at the end (using math/rand rather than your "idpool" solution), after all the internal nodes had been set up.  (func5 and func2 are the functions which initialize the observation nodes at the very end.)  It shifted the work around, but it doesn't look like it fundamentally made anything faster.  NB the performance here isn't a critical thing for me (at least not yet), but if it does become an issue, I might take a look at whether any of the node creation stuff could be made more efficient by pre-allocating, as growing maps and slices seems to be a fairly significant amount of the work being done.
So  with that, I think I'm done for now (unless you're particularly motivated to dig into the performance of MustObserve(), in which case I'm happy to run some more benchmark / profile runs).
Thanks again!

👋 One more optimization worth trying; I've added some new options for the graph itself (specifically OptGraphPreallocateNodesSize(size)) that will let you set the initial capacity of the backing node map to cut down on some overhead in bootstrapping large graphs. There are separate options for Observers and Sentinels as well if you have large numbers of those.
The performance impact looks somewhat decent:

Hopefully this helps!

I've added a new top level function SetIdentifierProvider which will let you add a custom implementation of the NewIdentifier function. I've also added a basic implementation of an atomic counter based provider as an example. The existing providers aren't exported for now, so this will be very much an "experts only" method.

Great, thanks for all your help.


:construction: Create german localization

This is still 🚧 Work In Progress. Help is highly appreciated (simply leave a comment down below)!

General

[ ] Metadata selection
[x] Progress bar
[x] Menu

Windows & Wizards

[x] Settings window
[ ] Platform settings window
[x] Crash report window
[ ] First-time wizard
[ ] Emulator wizard

Games

[ ] Game actions
[x] Game fields
[ ] Game edit window

Misc.

[ ] Errors
[ ] "Misc. misc."

:unamused:


Updating vendor files

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind new feature

/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

What this PR does / why we need it:
Some of the vendor files was missing. Updating those vendor files.
Also, add a script to create image and binary and upload image
https://github.com/sodafoundation/multi-cloud/pull/1233/files#diff-44ecdde8f62040bc362d610ebbe22f7c057dd203846bf9853b823278f06bfcb3
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

*Locally tested
simply run # ./release_multicloud
Special notes for your reviewer:

Please create an issue for the PR and tag it for QIP #1247


Client connection resets cause goroutine panics

We've been running your awesome app in production using WebRTC but recently tried pulling video with HLS too. A goroutine panic happens when a client, like AWS MediaLive, resets the connection while requesting a segment.
2021/06/30 21:02:38 http: panic serving <IP_ADDRESS>:63759: write tcp <IP_ADDRESS>:443-><IP_ADDRESS>:63759: write: connection reset by peer

crash.log

This panics are caused by gin. See https://github.com/gin-gonic/gin/pull/2150
We've modified gin to respond 404 instead of 500 and removed the panic call.

This panics are caused by gin. See https://github.com/gin-gonic/gin/pull/2150
We've removed the panic line from gin and modified the render method to respond with status code 499 Client Closed Request instead of 500 in order to make those request logs easily searchable.


add option to run SegmentRelocator sequentially and kinda fairly

Previously, SegmentRelocator just keeps adding new rebalance tasks periodically, w/o knowing the previous ones may be still running and perhaps for the same table. This option adds a waiting queue for SegmentRelocator to run rebalance tasks sequentially and w/o redundancy.
Running tasks sequentially is mainly to avoid cpu overload on controllers. When table has a large ideal/external states, the waitForExternalViewToConverge() method can be very cpu costly, as it has to deserialize those large helix state. Besides, this method is called by TableRebalancer in a while-true loop to rebalance table incrementally, incurring the cost of deserialization repetitively. We found when running many SegmentRelocator tasks in parallel, the cpu util of controllers could go up to 100%, affecting other cluster activities like real-time ingestion.
Release notes
controller.segmentRelocator.rebalanceTablesSequentially - false by default

Codecov Report

Merging #10118 (bf810c6) into master (eb2b941) will decrease coverage by 0.04%.
The diff coverage is 63.26%.

@@             Coverage Diff              @@
##             master   #10118      +/-   ##
============================================
- Coverage     68.62%   68.57%   -0.05%
  Complexity     5738     5738
============================================
  Files          1995     1995
  Lines        108050   108087      +37
  Branches      16420    16424       +4
============================================
- Hits          74151    74123      -28
- Misses        28630    28692      +62
- Partials       5269     5272       +3

Flag
Coverage Δ

integration1
24.63% <30.61%> (+<0.01%)
:arrow_up:

unittests1
68.01% <ø> (-0.02%)
:arrow_down:

unittests2
13.71% <38.77%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...roller/helix/core/relocation/SegmentRelocator.java
64.08% <62.50%> (-1.69%)
:arrow_down:

...va/org/apache/pinot/controller/ControllerConf.java
59.05% <100.00%> (+0.14%)
:arrow_up:

...data/manager/realtime/DefaultSegmentCommitter.java
0.00% <0.00%> (-80.00%)
:arrow_down:

...er/api/resources/LLCSegmentCompletionHandlers.java
43.56% <0.00%> (-18.82%)
:arrow_down:

...data/manager/realtime/SegmentCommitterFactory.java
70.58% <0.00%> (-11.77%)
:arrow_down:

...ore/query/scheduler/resources/ResourceManager.java
88.46% <0.00%> (-11.54%)
:arrow_down:

...inot/core/util/SegmentCompletionProtocolUtils.java
57.69% <0.00%> (-7.70%)
:arrow_down:

...mmon/request/context/predicate/NotEqPredicate.java
76.92% <0.00%> (-7.70%)
:arrow_down:

...altime/ServerSegmentCompletionProtocolHandler.java
51.88% <0.00%> (-6.61%)
:arrow_down:

...core/operator/filter/predicate/PredicateUtils.java
59.09% <0.00%> (-6.07%)
:arrow_down:

... and 33 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implemented committee manager relations

Closes #794

What can/should I test here?

What can/should I test here?

There isn't much, basically all places where the committee managers or their number were displayed, previously used a certain workaround to get those values. They now use the proper method, but should work just the same as before.


podman restart behaves not the same as podman stop && podman start (firewalld specific?)

/kind bug
Description
The command
podman restart mycontainer
appears to behave differently from
podman stop mycontainer && podman start mycontainer
This is observed when a container which needs internet access via the host is restarted, which apparently does not update the firewall rules (in my case on Fedora adding e.g. <IP_ADDRESS>/32 to the trusted zone, where the ip is the one of the container).
After the restart, the container networking is broken.
If, instead, podman stop is used, the firewall rule is removed, and a new one put in place (matching the new container ip) after podman start
I am running firewalld with nftables backend, which is also specified in /etc/cni/net.d/87-podman-bridge.conflist as
	{             "type": "firewall", 	    "backend": "nftables" 	},
Steps to reproduce the issue:
execute
podman restart mycontainer
vs
podman stop mycontainer && podman start mycontainer
Describe the results you received:
Firewall rules are unaffected and networking (e.g. network request from the container on a host running firewalld) is broken for the first command.
Describe the results you expected:
Firewall rules are updated the same as when using podman stop (deletes container specific ip in trusted zone) and podman start (creates corresponding new rule)
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
podman version 1.7.0

Output of podman info --debug:
debug:
  compiler: gc
  git commit: ""
  go version: go1.13.5
  podman version: 1.7.0
host:
  BuildahVersion: 1.12.0
  CgroupVersion: v2
  Conmon:
    package: conmon-2.0.9-2.fc31.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.9, commit: 7d46f3e7711aa3578488284ae2f98b447658f086'
  Distribution:
    distribution: fedora
    version: "31"
  MemFree: 281800704
  MemTotal:<PHONE_NUMBER>8
  OCIRuntime:
    name: crun
    package: crun-0.10.6-1.fc31.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 0.10.6
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 8
  eventlogger: journald
  hostname: microserv.fritz.box
  kernel: 5.4.12-200.fc31.x86_64
  os: linux
  rootless: false
  uptime: 168h 24m 22.16s (Approximately 7.00 days)
registries:
  search:
  - docker.io
  - registry.fedoraproject.org
  - registry.access.redhat.com
  - registry.centos.org
  - quay.io
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 4
  GraphDriverName: overlay
  GraphOptions:
    overlay.mountopt: nodev,metacopy=on
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "true"
  ImageStore:
    number: 7
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.7.0-2.fc31.x86_64

Hm. I think we might be reusing the old network namespace - which, as you point out here, could be a bad thing in certain circumstances.

Confirmed, we're not tearing down the network namespace when we stop the container. Easy fix, I think.

Fix in #5052

Now that's what I call a quick fix!
Thanks!


Epg for HD Plus not working

Guide
https://iptv-org.github.io/epg/guides/de/hd-plus.de.xml
Description
Epg doesnt seem to work for a couple of days now

At the moment the guide is working fine:


Feature/scheduling

Summary
Support Spark Fair Job Scheduling by setting the following properties:
scheduling {
max-jobs = 1 // Max number of jobs to submit in parallel
mode = "FIFO" // FAIR or FIFO
file = "" // full path of the file describing the pools if not located in the metadata directory
pool-name = "default" // pool name to use
}
**Related Issue: #132 **
PR Type: Feature
Status:Ready to review
Breaking change? No

Codecov Report

Merging #138 (a91b294) into master (aead83c) will decrease coverage by 4.97%.
The diff coverage is 43.51%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   67.75%   62.77%   -4.98%
==========================================
  Files         123      125       +2
  Lines        5266     5368     +102
  Branches      278      257      -21
==========================================
- Hits         3568     3370     -198
- Misses       1698     1998     +300

Flag
Coverage Δ

unittests
62.77% <43.51%> (-4.98%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/main/scala/ai/starlake/job/ingest/AuditLog.scala
46.15% <ø> (ø)

...i/starlake/job/sink/bigquery/BigQueryJobBase.scala
21.80% <ø> (ø)

...tarlake/job/sink/bigquery/BigQueryLoadConfig.scala
88.88% <ø> (ø)

...starlake/job/sink/bigquery/BigQueryNativeJob.scala
0.00% <ø> (ø)

.../starlake/job/sink/bigquery/BigQuerySparkJob.scala
18.75% <ø> (ø)

...n/scala/ai/starlake/job/sink/es/ESLoadConfig.scala
70.37% <ø> (ø)

...main/scala/ai/starlake/job/sink/es/ESLoadJob.scala
83.05% <ø> (ø)

...ala/ai/starlake/job/sink/http/HttpSinkClient.scala
0.00% <0.00%> (ø)

.../starlake/job/sink/jdbc/ConnectionLoadConfig.scala
97.43% <ø> (ø)

.../ai/starlake/job/sink/jdbc/ConnectionLoadJob.scala
93.33% <ø> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ed1c19...a91b294. Read the comment docs.


feat: switch to badger by default

We've tested this long enough that it seems safe enough to use by default.
This change also removes all references to the conversion tool, which isn't
ready for prime time.

I think this might break IPFS in all low-memory devices (older Raspberry Pis). Badger tries to allocate too much memory up-front (1GB by default). It would only work by setting TableLoadingMode and ValueLogLoadingMode to Disk (reducing the ValueLogFileSize did not help back in the day).
I suggest that the low-power profile use flatfs. Alternatively it should use badger with the Disk options above (but I think these are not exposed on the spec so it's more work - unless things changed).

I think this might break IPFS in all low-memory devices (older Raspberry Pis). Badger tries to allocate too much memory up-front (1GB by default). It would only work by setting TableLoadingMode and ValueLogLoadingMode to Disk (reducing the ValueLogFileSize did not help back in the day).

Damn. I forgot about that issue.

Closing due to the memory issue. Continuing in #70 by at least declaring it stable.

Ok, so I fixed the memory issue by tweaking the parameters a bit. Badger now uses ~20MiB of memory.

@Stebalien did you test on a raspberry or should I?

@hsanjuan a raspberry test would be useful. I think the plan is that badger won't be switched to default for 0.5, so no need to do so quickly

Yeah, I'm going to close this again. It looked fine, then I noticed that badger loads value logs entirely into memory when garbage collecting (taking up ~1GiB of memory).


Constructor already exists

Upon requiring pg-restify I get the following error:
AssertionError [ERR_ASSERTION]: Constructor already exists!
I tried rolling back restify to 6.0.1 to see if it was some change to the restify API, but the error persists.
Any ideas?

It looks like you need to downgrade restify-errors to 5.0.0 as well.
I just pushed a new version (0.5.0) with upgraded versions of restify and restify-errors so you won't have to worry about this.

Thank you!


issue 499: support @Qualifier annotation in SpringBeanParameterResolverFactory

support for @Qualifier annotation in SpringBeanParameterResolverFactory

@Qualifier annotation on event handlers' parameter take precedence over @Primary annotated bean candidates
no support for custom @Qualifier annotations

Don’t worry about the codacy warnings. Those rules shouldn’t apply to test cases...


Ensure that the @ValidateMembers() decorator is included in all workload tests, such as the ZMachine workload.

Which package/s are you suggesting this feature for?
Dashboard
Is your feature request related to a problem? Please describe
A new validation role has been added to the GridClient for the Compute Capacity module. It needs to be added to the other modules as well.
Describe the solution you'd like
A new validation role has been added to the GridClient for the Compute Capacity module. It needs to be added to the other modules as well.

duplicate of #3038


Create a gitops module to provision an event streams instance

@seansund this module is ready for review, please review.

@JyotiRani ,
You need to disable the AWS test from the test matrix in verify.yaml.
Re-Run the GH Actions again to get this module tested


[Bug-UI] - Menu right position not fixed

This menu should have fixed position, so when scroll down it will not goes up.
Also adding border bottom in li is better.

Close in #12


api: mark internal listener as implemented and change internal listener binding

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Commit Message: Expose internal listener functionality. Marks the fields as implemented. Adds the following functional changes prior to publishing:

do not use the address field per https://github.com/envoyproxy/envoy/pull/21132, and instead use the listener name field as originally expected.
add an endpoint_id field to upstream address to fix https://github.com/envoyproxy/envoy/pull/22420; it's not possible to have multiple internal addresses to the same listener in a single pool without some extra identifier beyond the listener name, because pools identify addresses using asString().
fixes https://github.com/envoyproxy/envoy/issues/20665 by using stat prefix listener.envoy_internal_<listener_name>.

Adds a few sample configs (and fixes https://github.com/envoyproxy/envoy/issues/20335):

minimal two chained tcp_proxy listeners;
encap HTTP in HTTP CONNECT;
decap HTTP in HTTP CONNECT;

Risk Level: low, hidden prior
Testing: yes
Docs Changes: yes
Release Notes: yes

@adisuissa would you mind taking a look
/wait-any

Looks like a simple API change: throwing over to @htuch as Adi is out.
@kyessenov should this also have a release note as well?

@kyessenov following Alyssa's comment, if the server_listener_name field now implemented, then a release note should be added.

/wait on review notes - I'm happy to do that pass.  I think if we don't have example configs we're going to want that as part of making this non-hidden.

Affected by https://github.com/envoyproxy/envoy/issues/22483.

Per https://github.com/envoyproxy/envoy/pull/21132, I'm cleaning up the usage of address to replace with a field in InternalListener instead.
I'm also making a provision to address https://github.com/envoyproxy/envoy/pull/22420 with a dedicated field in upstream address for a port-like identifier.

I'll add a release note and update config samples. There're several issues that could be resolved in this PR, so I'm trying to be systematic before exposing this.

LGTM

/retest
(emsdk download returned 500)

/retest

/retest

/retest

/retest

Thanks @lambdai for doing the actual work! Hopefully we can get more usage and value now that it's public and easily available.


chore: update CRDs to v1.6.0

This PR was automatically created by 🏗 Update CRDs workflow on run #10420986652.
This was triggered by commit refs/tags/v1.6.0 on traefik/hub-crds.

Rejected.
It should not remove the Gateway API CRD.


Improve front page (suggestions)

(I am just trying to make an issue after out meeting yesterday. However, it is more a comment with my suggestions on how the front page could be impoved)
Text: First section is about "funds, finding personnel, and allocating resources" but that is not our main concern/aim. E.g. start with the next section ("aims to ease the burden of building, managing, sharing, and accessing health data") insead. It should be clear for the reader/reseacher in the first paragraph why seedcase is a good idea ("installable software [...] to better connect data collectors, researchers, clinicians, and other stakeholders to created data") and why we chose the name "seedcase".
We mention that it is aimed at health data, but in the last section, diabetes is all of a sudden introduced. There is no need to include this here (better to move it to the section "About" where Steno+DD2 is mentioned).
Small correction: "people with people with"
Logo: Add the logo as a bigger picture (not just the small one in the corner) in order for the reader to actually see what it is. Explain the name/logo and maybe simplify/change color?

@lwjohnst86 This seems to be a bit outdated? Are there something from these comments that you would like to include on the landing page?


[Discussion] How to get around ERROR: Package 'spleeter' requires a different Python: 3.8.2 not in '>=3.6, <3.8'?

I tried installing this again since it's been awhile.
But I am still getting this error.
"ERROR: Package 'spleeter' requires a different Python: 3.8.2 not in '>=3.6, <3.8'"
How do I get around this? I'm on Ubuntu 20.04 btw.

Spleeter is not compatible with python 3.8 yet (as tensorflow 1.15 which is a needed dependency is also not compatible).
We should release a compatible version soon. In the meantime, you have to use python 3.6 or 3.7.
The easiest way to do this without messing things in your main python installation is to use a virtual env in conda:
conda create -n py37 python=3.7
conda activate 3.7
pip install spleeter

I tried to install conda and do it that way, but it wouldn't work.
I'll just wait for the next version then.
Thanks for your response.

It should be:
conda create -n py37 python=3.7
conda activate py37
pip install spleeter

Right. I cannot find conda in the package manager, so I'm not sure what version ofconda I need to install.
I tried the version from pip but that one wasn't compatible.
So like I said, I'll be waiting for the next version of Spleeter.


Ignore missing file

Hello everyone, first of all thanks for this project.
I'd like to introduce ( as in the Ruby counterpart ) the skip-on-missing-file feature, particularly handy for dev/test environments.
This implementation introduce this feature for load and overload and provides a new force_load method to explicitly retain the current behaviour ( throw on missing ).

@GrahamCampbell thank you for reviewing the code.
I made the required changes!

@GrahamCampbell I refactored the code as you requested.
But reading the load function in Loader ( lines 75 and 78 ) my understanding is that the same race condition exists. Am I wrong?
Thank you.

dupe of https://github.com/vlucas/phpdotenv/pull/224? 👀

@svjacob the main idea behind this PR was to be more similar to the ruby dotenv library.
The final implementation after some reviews by @GrahamCampbell is really similar to the one in the #224. ( Code has been rebased, so unfortunately is not possible to look at that implementation anymore )
Personally I would avoid a flag that changes method behaviour :) but I'm open to alternatives.

@svjacob the main idea behind this PR was to be more similar to the ruby dotenv library.

I'd rather maintain BC than mimic the ruby API.

This PR looks very good now. 👍
One other thing. Is there any chance you could add @throws annotations to the functions that may raise the exception. This is really a documentation bug on our part. :)

Will merge this as is, and make an issue for the other thing.
Thank you! 🍻

Thank you!
I'll follow the related issue and make a PR for it tomorrow ( I'm in CEST
timezone ).

@GrahamCampbell Today I noticed that the 2.4.0 release does not contain this code. Is this expected?


Getting errors while trying to Build and run in the nix store

I'm performing this following code and it's getting errors.
nix-build -A connectScripts.mainnet.wallet -o "./launch_$(date -I)_$(git rev-parse --short HEAD)"
Please refer the following screenshot.

Hello, it's best to enable the IOHK binary cache before building. Otherwise it will take a really long time. Instructions are here: https://github.com/input-output-hk/cardano-sl/blob/master/docs/nix.md


Figure out how to start serving after leader elected

https://github.com/tisonkun/morax/blob/3e3a1468043785d30dc5dd24d0abc9be9d9cca15/morax-controller/src/main/java/org/tisonkun/morax/controller/ControllerStateManager.java#L102-L103
Currently, for testing, I wait for one second and hope the leader election is finished. But we need a programming method to ensure that leader is ready.
Or perhaps we tolerate and retry. IIRC IoTDB uses a similar strategy.

@SzyWilliam could you share a bit of best practices on how we wait for a Ratis RaftServer to establish leadership?

@tisonkun We're also bothered by this problem until recently, https://github.com/apache/ratis/pull/906 a new callback isLeaderReady is added to statemachine. We can start leader-related services there.

@SzyWilliam Thank you! But it seems that the patch hasn't been released yet?

I use a HACK instead for now - https://github.com/tisonkun/morax/pull/28
When we implement multi nodes controller cluster, we can do some refactor to handle leader transfer between multiple nodes.


In industrial scenarios, it is necessary to increase the processing of special data structures such as union and bit fields.

At present, there is a very common data structure as follows:
typedef struct
{
	union
	{
		unsigned short word;
		struct
		{
			unsigned code1		:3;
			unsigned code2		:5;
			unsigned code3		:2;
			unsigned code4		:6;
		}block;
	}order;
	...
}

In order to be compatible with a large number of early module codes, this is a necessary data structure, and this data structure will be transmitted with high-level programming languages.
After careful study, the conclusion is that under the current use scenario, the union cannot be serialized in general, but can only be parsed in a targeted way. In consideration of the universality of Jstruct, it is recommended to negotiate the special data types that may be encountered at present and in the future.

When processing this type of data, it is also necessary to consider the problem of big-endian and little-endian, which may cause dislocation in the transmission process of different 'arch'.

I don't recommend doing this, jstruct just provides serialization and deserialization for json, I want to keep it simpl, not to understand the meaning inside the protocol, this work should be do by protocol parsing.

In fact, the union should be an extension of the base data type, but the data defined by the union cannot be parsed according to the original logic, so the protocol is proposed. Do you think the extension of union should not be parsed or the description of protocol is inappropriate? If it is the latter, I will put the protocol in other files and extend the jstruct in the form of modules.


Use pkgconf as our pkg-config implementation

The original freedesktop pkg-config implementation we use is pretty dead (no stable release since 2017, no commits in 3 years, no code changes since 2019), and has a variety of issues, including an awkward circular GLib dependency that makes bootstrapping more annoying, and missing support for useful .pc features.
pkgconf is a compatible from‐scratch reimplementation that avoids all these issues; they have a (biased, naturally, but still) comparison to pkg-config. Fedora has already moved to pkgconf as its pkg-config implementation, as have Arch, Alpine, and Debian.
@reckenrode will be using pkgconf in the Darwin SDK rework because of build issues with pkg-config’s vendored GLib, so the problems here are not just theoretical. I think we should strongly consider moving wholesale to pkgconf.

@reckenrode will be using pkgconf in the Darwin SDK rework because of build issues with pkg-config’s vendored GLib, so the problems here are not just theoretical. I think we should strongly consider moving wholesale to pkgconf.

One thing I’d like to clarify is that it’s used only in the bootstrap. The final package set will have whatever pkg-config implementation is used by default in nixpkgs.
The problem for Darwin is that pkg-config bundles its own glib, which fails to build in the new bootstrap because it needs arpa/nameser.h, which is provided by libresolv, which is built with Meson, which depends on pkg-config. I need to break the chain of circular dependencies somewhere, which I have opted to do by making pkgconf the top-level pkg-config in the bootstrap.
(For those who are not aware, it’s such a hassle dealing with xcbuild to build source release packages that it’s easier/faster to reimplement their build systems using Meson. I chose Meson because it is easy to use and readable.)

Right, I didn’t mean to imply that we’re getting a platform split on this, just to point to an example of how our existing pkg-config implementation is actively worse for us in practice such that we resort to pkgconf anyway. pkg-config’s bootstrapping issues are well‐known in other distros and a big motivator for why the ecosystem has largely moved over to pkgconf.

Sure, sorry if I came across like you were. I wanted to address those less familiar with what’s in the plans for Darwin in case someone got an incorrect impression about it.

@reckenrode will be using pkgconf in the Darwin SDK rework because of build issues with pkg-config’s vendored GLib

I'm looking to have an LLVM based bootstrap in the future possibly and from the looks of it, we might run into the same exact problem as Darwin because of this problem. Using pkgconfig instead of pkg-config sounds great.

Working on this.

I would also like to see this happen. I also noticed that the pkgconf derivation doesn't have the pkg-config binary at the moment.

There is an important difference between the two in nixpkgs tho:
pkg-config is patched to ignore Requires.private for --cflags without --static, whereas libpkgconf is not. I believe such a change also has to be made for pkgconf to be viable.

That patch is bad and has caused us problems. Avoiding it would be one of the benefits of switching we discussed when running into issues with wlroots recently because of it. We would have to either propagate more packages or (preferably) figure out a way to have absolute paths to private .pc dependencies.


Self referential link for MAC reporting?

The link Teams activity reports in the Microsoft 365 admin center now redirects so has become self-referential. See if there's a new article that replaces the old one or else remove this link.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78ade1a4-092c-1132-44df-ee2c683fdd33
Version Independent ID: 396b1aee-2f40-9895-9b00-07e38d11d31b
Content: Microsoft Teams analytics and reporting - Microsoft Teams
Content Source: Teams/teams-analytics-and-reports/teams-reporting-reference.md
Service: msteams
GitHub Login: @SerdarSoysal
Microsoft Alias: serdars

@ashishguptaiitb thank you for reaching out and helping to improve Microsoft Docs. Would this be the correct link to add here? https://docs.microsoft.com/microsoft-365/admin/activity-reports/activity-reports?view=o365-worldwide

Would this be the correct link to add here? https://docs.microsoft.com/microsoft-365/admin/activity-reports/activity-reports?view=o365-worldwide

Hello @lindspea , allow me to suggest that you reach out to @SerdarSoysal for accurate info on what the new destination should be.

@tiburd

Thanks, all! I merged the PR. Closing this issue.


Cannot see   checkbox

Bug, feature request, or proposal:
Cannot see my  at all within the  nor can I see it at the bottom of the form

    **<ng-container matColumnDef="select">
      <mat-header-cell *matHeaderCellDef>
        <mat-cell *matCellDef="let vehicle">
          <mat-checkbox>
          </mat-checkbox>
        </mat-cell>
      </mat-header-cell>
      <mat-cell *matCellDef="let row">
        <mat-checkbox [checked]="true">
        </mat-checkbox>
      </mat-cell>
    </ng-container>**

    <ng-container matColumnDef="vin">
      <mat-header-cell *matHeaderCellDef>   {{"Vin" | translate}}  </mat-header-cell>
      <mat-cell *matCellDef="let vehicle"> {{vehicle.vin}} </mat-cell>
    </ng-container>

    <ng-container matColumnDef="plate">
      <mat-header-cell *matHeaderCellDef> {{"Plate" | translate}} </mat-header-cell>
      <mat-cell *matCellDef="let vehicle">  {{vehicle.plateNumber}}</mat-cell>
    </ng-container>

    <ng-container matColumnDef="terminalId">
      <mat-header-cell *matHeaderCellDef> {{"TerminalId" | translate}} </mat-header-cell>
      <mat-cell *matCellDef="let vehicle">  {{vehicle.terminalId}}</mat-cell>
    </ng-container>

    <mat-header-row *matHeaderRowDef="columnsToDisplay"></mat-header-row>
    <mat-row *matRowDef="let row; columns: columnsToDisplay;"></mat-row>
  </mat-table>

  **<mat-checkbox>Check me!</mat-checkbox>**

</form>

with .ts file
this.columnsToDisplay = ['select', 'vin', 'plate', 'terminalId'];
What is the expected behavior?
see the checkbox in table and at the bottom
What is the current behavior?
Don't see the checkbox at all.
What are the steps to reproduce?
See above code
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/animations": "^5.2.0",
"@angular/cdk": "^5.2.5",
"@angular/common": "^5.2.0",
"@angular/compiler": "^5.2.0",
"@angular/core": "^5.2.0",
"@angular/forms": "^5.2.0",
"@angular/http": "^5.2.0",
"@angular/material": "^5.2.5",
"@angular/platform-browser": "^5.2.0",
"@angular/platform-browser-dynamic": "^5.2.0",
"@angular/router": "^5.2.0",
"@ngx-translate/core": "^9.1.1",
"@ngx-translate/http-loader": "^2.0.1",
"angular2-jwt": "^0.2.3",
"classlist.js": "^1.1.20150312",
"core-js": "^2.4.1",
"rxjs": "^5.5.6",
"zone.js": "^0.8.19"
browser = chrome Version 65.0.3325.162
Is there anything else we should know?

Looks like your code paste got a little messed up, could you just provide a small repro at stackblitz please. Also if this is only a question this would be better suited at stackoverflow.

@lvendramini
Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


Suggestion: allow function for minimum

I am very grateful for the current minimum argument: it has helped me on many occasions. However, I am wondering if it would be possible for minimum to also accept a function/lamda, since this would simplify a lot of things? For instance, something like:
zipf_frequency("dog", "en", minimum=lambda word: math.log10(len(word)))

Thanks for the suggestion. But it appears to me that this could be done in a shorter, simpler way with no extra code needed in wordfreq:
max(zipf_frequency("dog", "en"), math.log10(len(word)))


[Commands] Use library based llbuild by default

The implementation seems to work fine with several community packages and should now pass integration tests.

@swift-ci please smoke test


merge package template from Kronos-Tools/npm-package-template

package.json

chore(scripts): update semantic-release@semantic-release from template
chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 80.22% when pulling b2dda42633835478944f1e615e7beeb16e25a56c on template-sync-1 into 4690f4c40a5cb3573c375a05d0dc2c07a7450bc0 on master.

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   84.21%   84.21%
=======================================
  Files           1        1
  Lines          57       57
=======================================
  Hits           48       48
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4690f4c...b2dda42. Read the comment docs.


Update implementing-recommendations.md

Before selecting the "Create pull request" button:

Enter a meaningful title above^, using a prefix if necessary and keywords "New" or "Update" indicating the nature of changes.

Describe the summary, scope, and intent of this PR:
I did WA Assessment for some of my clients and noticed that it helps a lot if from the beginning we prioritize the pillars according to business needs. I've added this so it can help others.

Insert links(s) to any related work item(s) or supporting detail:
[DELETE-OR-REPLACE-THIS-TEXT]

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@ckittel sorry but I messed up and unintentionally deleted the previous PR so I just created a new one.

I tried to keep the content the same as what agreed earlier. So I think this should be ready for sign-off.

PnP #sign-off
#remove-label:"pnp-review-in-progress"
#remove-label:"do-not-merge"
#label:"ready-to-merge"


Add train/val/test split script for raw

Given a folder data/raw/... where ... = the downloaded v2d datasets, we need a script to partition (move) them into subdirectories called train, val, and test.
This is because the 4M folder directories expect the train/val/test to precede the modality, e.g.
train/video_rgb/class0/000.tar
train/video_det/class0/000.tar
train/video_transcript/class0/000.tar
```.

Then we can just run the merge_data.sh to go from raw to 4m-data 3 times (one for each split).

For now we can use a split of 70/10/20.

See #15


fix: find repository if it's not in current workspace path

[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

Fixes https://github.com/lapce/lapce/issues/2039

Codecov Report

Merging #2069 (dd74185) into master (0ae86e6) will increase coverage by 0.06%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories.  Learn more

CHANGELOG is conflicting :)


Could not resolve com.razorpay:customui:3.9.+.

Razorpay maven server XML urls are throwing 403.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:checkDebugAarMetadata'.

Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Could not resolve com.razorpay:customui:3.9.+.
Required by:
project :app > project :razorpay_flutter_customui
Failed to list versions for com.razorpay:customui.
Unable to load Maven meta-data from https://jcenter.bintray.com/com/razorpay/customui/maven-metadata.xml.
Could not HEAD 'https://jcenter.bintray.com/com/razorpay/customui/maven-metadata.xml'.
Read timed out

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1m 37s
Exception: Gradle task assembleDebug failed with exit code 1
-- @vivekshindhe @ramprasadAnand @razorraghib  Please provide a fix for this asap.

@skalex4 Facing the same issue please give update ASAP I am trying to solve since last 4 hrs
-- @vivekshindhe @ramprasadAnand @razorraghib

@AamilLiveKeeping Seriously. I tried to contact support yesterday afternoon.
they told us that they'll provide the fix at the earliest.
But still no fix.
-- @vivekshindhe @ramprasadAnand @razorraghib Requestiing you to please provide the fix as soon as possible..
our releases have stalled because we are unable to generate the builds.

@skalex4 I think issue is resolved now i am able run app

@skalex4 I also face same issue yesterday and today it solved automatically , now I can able to build app. For me also it looks that the issue is from Jcenter() as their website also contains about this issue. As they said yesterday they are working on resolving it , today it resolves.

yes, @niteshdkart
They deployed the fix by 1 o'clock today, and it's working after that.
I think they change to maven from Jcenter.

Issue fixed on v1.3.3. Basically removed jcenter from the build.gradle file. Thank you for you patience.


Feature: Mount Ready-Only S3 Buckets

We are cloning remote instances with https://github.com/sitegeist/Sitegeist.MagicWand for local development.
It would be nice to mount the same S3-Buckets locally and remote to prevent syncing all resources.
I prefer to mount the S3 Bucket locally as read-only to not accidentally remove or add files.

Maybe its easier (and safer) to create a new S3 Storage User with readonly access to the bucket 🤔


Glimmer compatibility

Previously we could count on Ember simply replacing all elements when the collection changes. Glimmer’s element re-use demands a new approach.
Concerns:

[ ] Strip transforms
[ ] Clear cached _y
[ ] Somehow avoid weird transitions

Closed by #21


[ALLUXIO-2701] Specify null variable in DataByteBuffer.java precondition check

https://alluxio.atlassian.net/browse/ALLUXIO-2701
Specify null variable in DataByteBuffer.java precondition check

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14422/
Test PASSed.


Does not recognize Samsung Internet Browser

Describe the bug
Reports Chrome when the browser is actually Samsung Internet Browser.
To Reproduce
Try a user agent like:
Mozilla/5.0 (Linux; Android 13; SAMSUNG SM-A528B) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/21.0 Chrome/110.0.5481.154 Mobile Safari/537.36
Expected behavior
Should return Samsung not Chrome.

This PR resolves the issue:
#1005

@halukakin
Thank you very much for reporting this issue, and I much appreciate your pull request contribution.
Best regards,
Sarin

@wangkanai Glad to help any time. Thank you for paying attention to this issue. 🙏

This change will be in the next release publish to NuGet


Emit OpenTelemetry tracing

OpenTelemetry has become the de-facto standard for distributed, cross-platform tracing; it is being rapidly adopted both inside the .NET ecosystem and outside. OTel defines semantic conventions for how a database client traces information; these specifications are currently in experimental state, but stabilization is likely start happening soon.
There is a separate instrumentation library, OpenTelemetry.Instrumentation.SqlClient, which AFAIK uses the DiagnosticSource instrumentation already emitted by SqlClient to then emit OpenTelemetry tracing.
However, ideally SqlClient would emit this tracing data directly, without requiring a 3rd-party library.

Why is it better to emit third party specific information rather than have their adapter deal with the diagnostic information we already emit?

@Wraith2 this isn't 3rd-party specific information, but rather the emerging standard for how database clients emit tracing information; fundational components in the .NET ecosystem (such as ASP.NET itself, but also Npgsql) are being instrumented to emit OpenTelemetry tracing directly, which is the best user experience and guarantees both accurate tracing and best performance. This really belongs in the driver rather than some 3rd-party adapter which may or may not have access to the needed information in an efficient way.

If there is additional information needed in the diagnostic data that we emit then we should identify and add it so that it can be available to the open telemetry adapter. I've already got an issue open at open telemetry about changing the diagnostic information to be strongly typed so it's more aot friendly so adding any new information would be best done along with that work.
I don't see why it's beneficial to have open telemetry as s direct dependency/implementation inside sqlclient though. It adds complexity and another set of diagnostic logging (we already have 2) and isn't needed by many people. If we want to make things pay-for-play then an external adapter that people can opt into sounds like the best approach to me.

I don't see why it's beneficial to have open telemetry as s direct dependency/implementation inside sqlclient though.

There's no OpenTelemetry dependency - everything needed to emit tracing (or metrics) data is already present in the framework (e.g. System.Diagnostics.ActivitySource). In addition, the APIs have been optimized so that their overheads when tracing isn't enabled is negligible.
So there's no real pay-per-play aspect here, and no real downside to implementing this in-the-box for people.
As I wrote above, this is becoming the de-facto standard for distributed tracing - not just in .NET. Note that this is also a different type of tracing: this isn't about adding tracing events to each and every function, generating very large dumps for method-by-method debugging; it's much more about emitting high-level information about what database commands are being executed, how long they're taking, and reporting various aspects about them. It's indeed probably possible to derive that information from SqlClient's existing tracing, but that kind of approach is always less efficient and requires that users discover and add yet another dependency.
I suggest taking a look at how this look for Npgsql; here's the doc page (I know some demos are planned for this in .NET Conf).

I don't see why it's beneficial to have open telemetry as s direct dependency/implementation inside sqlclient though.

There's no OpenTelemetry dependency - everything needed to emit tracing (or metrics) data is already present in the framework (e.g. System.Diagnostics.ActivitySource). In addition, the APIs have been optimized so that their overheads when tracing isn't enabled is negligible.
So there's no real pay-per-play aspect here, and no real downside to implementing this in-the-box for people.
As I wrote above, this is becoming the de-facto standard for distributed tracing - not just in .NET. Note that this is also a different type of tracing: this isn't about adding tracing events to each and every function, generating very large dumps for method-by-method debugging; it's much more about emitting high-level information about what database commands are being executed, how long they're taking, and reporting various aspects about them. It's indeed probably possible to derive that information from SqlClient's existing tracing, but that kind of approach is always less efficient and requires that users discover and add yet another dependency.
I suggest taking a look at how this look for Npgsql; here's the doc page (I know some demos are planned for this in .NET Conf).

+1. Having libraries natively instrumented is the ideal case. As an example, HttpClient and ASP.NET Core are also moving towards that change. .NET8.0 has added metrics support in HttpClient and ASP.NET Core. Reference: https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics-aspnetcore.
Tracing is considered for .NET9.0: see https://github.com/dotnet/runtime/issues/93019.
@roji How does Npgsql handle experimental semantic conventions part?

@vishweshbankwar Npgsql implements the current database tracing semantic conventions in their experimental state, and that support is itself documented as experimental in our docs. When the specs mature and reach stable, we'll align to those (users may need to react).

Upvoting :) ❤ to see this!

Semi-related to this, but the SqlCommand class (both the deprecated System.Data.SqlClient.SqlCommand and the now-relevant Microsoft.Data.SqlClient.SqlCommand) are a bit hard to use with OpenTelemetry in the sense that it seems virtually impossible to add a 3rd party "query name" tag to the instantiated SqlCommand. 🤔 This kind of information would be incredibly useful to be able to include in the distributed tracing data, to distinguish different queries from each other.
The reasons why I claim this is impossible:

SqlCommand is sealed, making it impossible to simply subclass it and add the relevant property
SqlCommand provides no custom Attributes dictionary or similar, where you could add user-provided data needed by your application somehow

If either one of these options were available, you could then easily use the OpenTelemetry.Instrumentation.SqlClient-provided Enrich() method, to set arbitrary tags in the tracing data being submitted. We tried setting a dummy Parameter with a user-defined name of the query, but unfortunately this can cause undesired breakage when running certain SQL queries.

Sorry for hijacking the issue quite a bit (...) but I guess what I'm stretching for is:

Does anyone (perhaps you, @cijothomas?) have any ideas on how to workaround this short-term? I thought about a Java:ish approach of using a thread-local variable for this, but unsure if we can guarantee that the Enrich() lambda runs on the same thread as the code creating the SqlCommand in the first place, because of the async nature of modern .NET code.
When investigating this issue in the long run, please take this into consideration ("make it possible to provide a user-defined query name") since it'll make the tracing much more valuable and useful.

It would work but because SqlCommand are short lifetime objects (usually) it would cause a lot of traffic and be perf concern as you point out. Adding an identifier property (call it Tag?) to a command isn't a difficult thing to do and would likely be approved. The problem is getting it into the diagnostic output or waiting for the full implementation of the open telemetry

Thanks @KalleOlaviNiemitalo, appreciated! 🙏

It would work but because SqlCommand are short lifetime objects (usually) it would cause a lot of traffic and be perf concern as you point out.

It (ConditionalWeakTable) could actually be an option in our case, despite not a perfect solution. Might give this a try as an interim solution at least.

Adding an identifier property (call it Tag?) to a command isn't a difficult thing to do and would likely be approved.

Thank you for that @Wraith2 - let's give it a try: https://github.com/dotnet/SqlClient/pull/2925

The problem is getting it into the diagnostic output or waiting for the full implementation of the open telemetry

That's actually not a problem, at least with the current approach taken by the OpenTelemetry.Instrumentation.SqlClient-tracing-related code, because it's Enrich-property is defined like this. 👇
    /// <summary>
    /// Gets or sets an action to enrich an <see cref="Activity"/> with the
    /// raw <c>SqlCommand</c> object.
    /// </summary>
    /// <remarks>
    /// <para><b>Enrich is only executed on .NET and .NET Core
    /// runtimes.</b></para>
    /// The parameters passed to the enrich action are:
    /// <list type="number">
    /// <item>The <see cref="Activity"/> being enriched.</item>
    /// <item>The name of the event. Currently only <c>"OnCustom"</c> is
    /// used but more events may be added in the future.</item>
    /// <item>The raw <c>SqlCommand</c> object from which additional
    /// information can be extracted to enrich the <see
    /// cref="Activity"/>.</item>
    /// </list>
    /// </remarks>
    public Action<Activity, string, object>? Enrich { get; set; }

Since we have access to the raw SqlCommand there, it's trivial to then "pass it on" into the Activity object which gets sent to the OpenTelemetry collector:
var cmd = (SqlCommand)command;
activity.SetTag("query.name", cmd.Tag); // Depending on the new property not yet available in SqlCommand

Of course, for the full (SqlClient-"native") OpenTelemetry implementation, things might be a completely different beast, I'm just talking about "how could we make this work at all right now" scenario right now.

I thought about a Java:ish approach of using a thread-local variable for this, but unsure if we can guarantee that the Enrich() lambda runs on the same thread as the code creating the SqlCommand in the first place, because of the async nature of modern .NET code.

You might as well just use AsyncLocal. It works very similar to ThreadStatic, though it's passed through async context.

@perlun this is indeed quite off-topic to this issue, would be better to have this conversation in its own issue.

Alright @roji, fair point indeed. I created a new issue at https://github.com/dotnet/SqlClient/issues/2931 now, and copied my comments there. Let's continue that thread there instead.
Feel free to flag the comments related to this thread as off-topic to keep the original content more readable. 👍


Add compilation traces

Please provide a description of this PR:

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2f71131f233924c1f2254e1125b5f3c9bd70b154
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests

/test unit-tests

/test  unit-tests_istio

/test unit-tests

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add option --list-file-types

This patch documents the file types which were made searchable in #283

Please resurrect this. I dont know what file types are supported.


Decouple node deployment and resource managment from test running in CI

Motivation
Our testing infrastructure in tests is coupled deeply with deploying on K8S, I'm not suggesting removing K8S (for now), but I do think we should split the code and make the tests modular to be able to "drop-in" tests or "play scenarios" inside an existing running network or just get network information essential to development and debugging easily.
Action plan

Create a simple API (first code and maybe evolve to RESTful) to perform changes in network structure and querying nodes

Network management API
Node client API to perform actions or checks

"Plug" tests into the API or pass network info by params to run the wanted changes and checks on the network
Test results reported back to some central or temporary central (for a temporary network) server, GH should able to consume results.
Reports about important information about network during run (nice to have for now)

the above will probably be broken into smaller issues

Eventually we'll want to be able to run tests on every compatible network infra and provide easy ways to make a network compatible.


Possible to serve up a file so that it is available at localhost:9876, and not /base/ ?

I have {pattern: './src/newWave.html', watched: false, served: true, included: true}, in my files list, but I would like this file to be available at localhost:9876/newWave.html, and not localhost:9876/base/src/newWave.html/ (the way it is now)
How would I do this?

figured it out
proxies: {
'/newWave.html': '/base/src/newWave.html'
},

Great that you found it yourself, and thank you for reporting your solution :)


Add option to check account availability before login

This feature introduces an option that allows the system to verify the existence of a user account before proceeding with the login process. The primary goal is to enhance security and user experience by ensuring that only existing accounts can attempt to log in.
Key Changes:

New Configuration Option: check_account_exists_before_login

This option can be enabled or disabled to control whether the system verifies account availability during the login process.

Error Handling:

If the account is not found, a message saying "Couldn’t find your account" will be displayed to the user.

Benefits:

Enhanced Security: Prevents login attempts with non-existent accounts.
Improved User Feedback: Provides clear feedback when an account is not found.

This feature provides flexibility for applications that require pre-login account validation and improves the overall user experience during authentication.

Note: Inspired by the account verification flow in Google login. 😉

I'm closing this PR and will restructure and redo it later.