Bumping image version 1.1.6 -> 1.1.7

Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>

/lgtm

/approve

/approve


PhysicalIdentifiableItem should not have an identifiedBy restriction

As I understand it, a PhysicalIdentifiableItem is any discrete thing, like a table, a book, a plant, as opposed to a PhysicalSubstance like water, sugar, oil - essentially these capture the distinction between count and mass nouns in English. Surely not all of these are expected to have an ID.

As an aside, because the range of identifiedBy is ID, you don't need to state a someValuesFrom ID restriction - it would be (if it were correct) more concisely expressed as a min cardinality constraint. Ditto for madeUpOf.

I agree that the identifiedBy restriction is incorrect. What is closer to correct is that in principle it would be possible for something to have an identifier, not that it does in fact have one.

Closing: fixed in PR #676.


a few issues

I click to change it to Turkish or English and it doesn't work. Why?

You need to reopen the tab after changing the language settings.
The language setting only controls which localization folder the game reads text from; the software itself currently supports only Chinese.

I also clicked on the place where I clicked to select the game folder, but it does not open.

Are you referring to the dialog not popping up?

I'm not sure why the selection dialog isn't appearing, but if you'd like to set the directory, please click the button on the left.

Have your issues been resolved?

It looks like you do not know WinUI development, right?

I can release a version that I compiled later.

Ok, I have already released it.

Is it working properly now?

 Do I click on this? If I click on this, it opens but those buttons still do not work.

yes
I'm not sure why the button is still not working, I wonder if it might be because your Windows version is too low?

My friend also used this software, and he didn't have this issue

You can record the process as a video

According to Microsoft's official documentation, the minimum requirement for WinUI is Windows 10 1809 - Build 17763 or newer.

oh，let me test it on my computer

I think I need to spend some time investigating the cause.

I'm sorry for taking up so much of your time

I wrote a test app for pop-up windows. Could you download it and test whether the pop-up displays correctly?
OneDrive

Sorry, I don't understand Turkish. What does this sentence mean in English?

I have tried to fix it. You can download the source code, compile it, and run it to test it out.
ButtonTestAppCode.zip

Like the Moder project

I have tried to fix it. You can download the latest source code for the Moder project, compile it, and run it to test it out.

 Is it normal for it to appear this color?

Do you mean the background?

this thing has also gone into a loop.

This is a bug, and I have just fixed it.

The buttons in the second image are now working. What should I do now?

Using this software? Currently, you can only edit state files and use a half-finished character editor.

I am considering whether to add localization support for the software. However, my English is poor, and I initially thought that most users of Moder would be Chinese (since I only promoted it on Chinese video websites). I didn't expect the first person to report a bug to be a foreigner😄.

It looks like an IDE error message

Let's focus on feature development for now. I can start by localizing the README file into English.

Once I have completed the character editor, I can consider working on localization.


lilypond: 2.24.1 -> 2.24.2

Description of changes
https://gitlab.com/lilypond/lilypond/-/releases/v2.24.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Is there an ETA on this ?

I should be able to test tomorrow.

works on my machine :tm: thanks!


Outline view sort alphabetically

I searched issues with label of Outline and couldn't find any open request about a possible way to sort the list alphabetically. I don't always put my functions in alphabetical order in my classes but I really wish there would be a way to show them alphabetically in the Outline view. They seem to be always sorted in VS (by symbol, then alphabetically), so it would be nice to also have this option in VSCode.

Check the overflow menu. There is sort by name.

@jrieken
Thanks I did not even know there was a menu for Outline.
However, I see that there's only 1 sort possible at a time, so I cannot sort by type then by name.
Could that be a feature request to add in the future?

so I cannot sort by type then by name. Could that be a feature request to add in the future?

It should be stable, e.g having sorted by name then by kind, then we shouldn't mixup items of equal kind. That's a known bug with the tree.


Crashing immediately on startup

VSCode Version:

Ω code -v
1.8.1
ee428b0eead68bf0fb99ab5fdc4439be227b6281

OS Version:

Ω system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: macOS 10.12.2 (16C68)
      Kernel Version: Darwin 16.3.0

Also might be worth noting that I have<EMAIL_ADDRESS>on this machine.
aka Mac OS 10 Sierra
Steps to Reproduce:

download the latest .app from chrome
click on the downloaded zip icon (which uses ??? to unzip it)
move the unzipped .app to Applications
double click it
crashes immediately

Here is output of --verbose.
(master) Ω code -v
1.8.1
ee428b0eead68bf0fb99ab5fdc4439be227b6281
(master) Ω code --verbose
[main 7:12:16 AM] Sending env to running instance...
[main 7:12:16 AM] Sent env to running instance. Terminating...

Downgraded to 1.7 and ...
(master) Ω code -v
1.7.2
7ba55c5860b152d999dda59393ca3ebeb1b5c85f
(master) Ω code --verbose
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[warn] kq_init: detected broken kqueue; not using.: Undefined error: 0
[main 7:14:40 AM] Sending env to running instance...
[main 7:14:40 AM] Sent env to running instance. Terminating...

Upgrading to 1.9.0-insider - and no more immediate crashing!
(master) Ω code-insiders -v
1.9.0-insider
2cdc2b3da8f0fd5322b48747241584cf9dd98f8f
(master) Ω code-insiders --verbose
[main 7:25:18 AM] Starting VS Code in verbose mode
[main 7:25:18 AM] from: /private/var/folders/b1/h9wy_qtd2ml588hrfcg2vtlh0000gn/T/AppTranslocation/B0B632EC-003B-4560-A274-8366DEE642D2/d/Visual Studio Code - Insiders.app/Contents/Resources/app
[main 7:25:18 AM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'new-window-if-not-first': false,
  'reuse-window': false,
  r: false,
  performance: false,
  p: false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false }
[main 7:25:20 AM] IPC#vscode-workbenchLoaded
# cut off for brevity

@ritch After trying to open vscode and it crashes, do you see any additional information? Is there a "Report Problem For Electron Window"?
#17034 had a similar error. Do any of the suggestions in that issue help?

 -	    kqueueop->events[0].flags != EV_ERROR) {
 +	    !(kqueueop->events[0].flags & EV_ERROR)) {

buzz here http://libevent.org

@ritch so you say 1.9 insider works fine for you? are you using the macOS native zip tool for unzip?

are you using the macOS native zip tool for unzip?

yes

@ritch After trying to open vscode and it crashes, do you see any additional information? Is there a "Report Problem For Electron Window"?

no... just a very quick open of the app icon in the dock then it goes away... pretty odd.

After a restart I downloaded 1.8.1 recovery and it just opened without issue...
Would downloading a new build clear out my installed extensions?
I think the zombie process think is worth looking into, because it would explain this workaround.

Yeah, very likely to be zombie process related. Happy to hear it works again.


SymbolProc may break code

I have a piece of controller code like this:
class Api::SubstancesController < Api::BaseController
  ...
  def destroy
    super([:pharmaceut]) do |substance|
      substance.destroyable?
    end
  end
  ...
end

Rubocop wants to autocorrect this to:
> rubocop -a app/controllers/api/substances_controller.rb
Inspecting 1 file
E

Offenses:

app/controllers/api/substances_controller.rb:20:5: C: [Corrected] Pass &:destroyable? as an argument to  instead of a block.
    super([:pharmaceut]) do |substance|
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
app/controllers/api/substances_controller.rb:20:25: E: unexpected token tLPAREN2
    super([:pharmaceut])(&:destroyable?)
                        ^
app/controllers/api/substances_controller.rb:42:1: E: unexpected token $end

1 file inspected, 3 offenses detected, 1 offense corrected

Rubocop even detects two Errors - all due to the code it generated on its own.
The final result:
  def destroy
    super([:pharmaceut])(&:destroyable?)
  end

As you can see this is clearly erroneous syntax.
Version
> rubocop -v
warning: parser/current is loading parser/ruby21, which recognizes
warning: 2.1.6-compliant syntax, but you are running 2.1.5.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
0.33.0

I have tried to add 'super' to ignored methods in config (seeing this cop inspects this configuration attribute) but that did not help
Style/BlockDelimiters:
  IgnoredMethods:
    - super
    - lambda
    - proc
    - it

super is not a method. We need to add an exception for it in the code.

Or even better - we should auto-correct code with super as:
def destroy
    super([:pharmaceut], &:destroyable?)
end

Thanks, @bbatsov !


Fix/39053: Distance- Blank space above waypoints when transitioning

Details

This fixes a regression introduced in PR, which intended to fix this issue
Fixed Issues

$ https://github.com/Expensify/App/issues/39053
PROPOSAL: NA
Tests

Go to staging.new.expensify.com

Go to workspace chat
Click + > Request money > Distance
Enter addresses
Click Next
Proceed to confirmation page
Swipe right to return to previous page.
Verify that the waypoint list isn't moved

Offline tests

Same above
QA Steps

Same above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/141406735/7770a5e8-9781-4ce6-a195-9eab10055e8d

Android: mWeb Chrome
https://github.com/Expensify/App/assets/141406735/30f6fd54-bc46-43d7-aa6f-5b6474b65098

iOS: Native

https://github.com/Expensify/App/assets/141406735/6e70a776-a532-49a9-968e-c54b8d5625d0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/141406735/e72ffed7-1b30-469d-9823-5dd7f656102c

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/141406735/6e144c6c-8856-4239-affb-d0b2ab7ea4a1

MacOS: Desktop

https://github.com/Expensify/App/assets/141406735/89317a4c-163f-4fac-b9f2-da9fbd85259d

@MelvinBot So surprising cuz you assign to the correct reviewer

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Not an emergency, all checks passed as shown here https://github.com/Expensify/App/pull/39151/checks

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.59-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Terms file is not included

I believe that the terms.rs file is no longer included in the source tree. Maybe it should be removed?

Yeah, it should be removed


Maps File Format and Location

I managed to convert an osm map of a campus to .xodr(open drive format). Could I use this file as a new map in Apollo? I read that it uses the open drive format but I couldn't find where these maps are so that I could add my own. I may be totally wrong with this. Do you have any advice as how to take a real world map and use it?

The current code takes file ends with '.xml' for open drive format map. Two places which is loaded are as the following:

for path planning

int HDMapImpl::LoadMapFromFile(const std::string& map_filename) {
  Clear();
  // TODO(startcode) seems map_ can be changed to a local variable of this
  // function, but test will fail if I do so. if so.
  if (apollo::common::util::EndWith(map_filename, ".xml")) {
    if (!adapter::OpendriveAdapter::LoadData(map_filename, &map_)) {
      return -1;
    }
  } else if (!apollo::common::util::GetProtoFromFile(map_filename, &map_)) {
    return -1;
  }
  return LoadMapFromProto(map_);
}

for routing

bool GraphCreator::Create() {
  if (common::util::EndWith(base_map_file_path_, ".xml")) {
    if (!hdmap::adapter::OpendriveAdapter::LoadData(base_map_file_path_,
                                                    &pbmap_)) {
      AERROR << "Failed to load base map file from " << base_map_file_path_;
      return false;
    }
  } else {
    if (!common::util::GetProtoFromFile(base_map_file_path_, &pbmap_)) {
      AERROR << "Failed to load base map file from " << base_map_file_path_;
      return false;
    }
  }

  ...
}

I have not tried this format myself. Good luck and please let me know if it works.

Thank you,
For now I'll try to manually convert some maps from a driving simulator called carla, I'll keep you posted on what I find when I'll try to convert a real world map. Do you happen to know what the scale for the coordinates is? For example, I used the map_gen_two_lanes_right_ext.py script to generate a base_map and in the input file I wrote a bunch of coordinates, like 0,24 24,24 and so on to describe the road geometry, but I couldn't find how much one unit is in meters or something similar( let's say the distance between the points 0,0 and 0,1).

Hi @SanduIrina,
what tool have you used to convert an OSM to OD format?
Have you been succeed to load the converted map into apollo?
Regards,
Alex

Hi, i couldn't find any tool that would do that, so I learned the open drive format and wrote a basic map myself by taking real coordinates from google maps


feat: NotificationService

Change Log

AtClient has a getNotificationService method to get the NotificationService instance that is instantiated in the constructor of AtClientImpl
AtClientValidation.java has a new method validateNotificationRequest(NotificationParams, String rootDomain, int rootPort)
under common/, we have NotificationEnums.java which has enums used by Notifications.
New NotifyListResponseTransformer that transforms a response from running the verb notify:list into usable Java objects
Refactored NotificationStatusVerbBuilder to NotifyStatusVerbBuilder
New api/notification/ directory which contains the following:

AtNotification.java - object represents an AtNotification
NotificationParams.java - object to enter inside of the notify method
NotificationResult.java - object returned upon using NotificationService methods that holds information after executing said method.
NotificationService.java - interface defining functions to be implemented by Impl
NotificationServiceImpl.java - implementation of Notification
Tests for NotifyListResponseTransformer (ensure a given notify:list input creates a desired output)

Not Done

[ ] AtClientValidation tests for checking the NotificationParams object are commented out in AtClientValidationTest.java
[ ] validateNotificationRequest is not used by NotificationServiceImpl and untested

Usage
See NotifyListExample.java, NotifyRemoveExample.java, and NotifySendExample.java for usage examples.
closes #6

@JeremyTubongbanua i've made a new PR for this , i messed things up here ,sorry

Please do check #67 PR

@gkc
I have a blocker with the last 2 outstanding tasks to merge this PR. They are related to validating the NotificationParams object. In my opinion, I do not think it is a major issue to omit validation for now. Notifications still work in this PR. I've left comments and the ground work is laid out in case we really want to add Notification validation in the future. If you think this PR is okay, it is good to merge.
More Info on the Issue:
Unable to implement the use of static method AtClientValidation.validateNotificationRequest(NotificationParams, String, int) in line 49 of NotificationServiceImpl.java
The summary of the problem is that the method requires the RootURL of the atDirectory server but the AtClient instance does not have access to this variable because the core factory method (that actually instantiates the AtClientImpl instance) does not store it because it takes the remote secondary address as an argument (as opposed to the root url).
Sources:

Dart AtClientValidation using AtClientPreference to get rootDomain and rootPort https://github.com/atsign-foundation/at_client_sdk/blob/f8998895e11a4a45c8869a2c7433b5a140a85c4b/packages/at_client/lib/src/util/at_client_validation.dart#L133
Dart NotificationServiceImpl actually using the method https://github.com/atsign-foundation/at_client_sdk/blob/f8998895e11a4a45c8869a2c7433b5a140a85c4b/packages/at_client/lib/src/service/notification_service_impl.dart#L339
Java AtClient factory method that actually creates the instance https://github.com/atsign-foundation/at_java/blob/d280422ccdd48e090cfd17089e763206f86ad00e/at_client/src/main/java/org/atsign/client/api/AtClient.java#L106 (note that this method does not ask for a rootUrl, there are other factory methods that ask for a rootUrl as an argument but eventually call this method).

Branch has merge conflicts that need to be resolved


Update MiMa check to include all 1.2.x releases

Contributor Checklist

[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?

Type of Improvement

API Impact

Enforce binary compatibility against all previously published versions on the release branch
Backend Code Generation Impact
None
Desired Merge Strategy
Don't care

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you mark as Please Merge?

How did I test this? I deleted all firrtl jars from my cache and ensured that mimaReportBinaryIssues downloaded each version:
sbt:firrtl> mimaReportBinaryIssues
[info] downloading https://repo1.maven.org/maven2/edu/berkeley/cs/firrtl_2.12/1.2.4/firrtl_2.12-1.2.4.jar ...
[info]  [SUCCESSFUL ] edu.berkeley.cs#firrtl_2.12;1.2.4!firrtl_2.12.jar (327ms)
[info] downloading https://repo1.maven.org/maven2/edu/berkeley/cs/firrtl_2.12/1.2.3/firrtl_2.12-1.2.3.jar ...
[info]  [SUCCESSFUL ] edu.berkeley.cs#firrtl_2.12;1.2.3!firrtl_2.12.jar (331ms)
[info] downloading https://repo1.maven.org/maven2/edu/berkeley/cs/firrtl_2.12/1.2.0/firrtl_2.12-1.2.0.jar ...
[info]  [SUCCESSFUL ] edu.berkeley.cs#firrtl_2.12;1.2.0!firrtl_2.12.jar (585ms)
[info] downloading https://repo1.maven.org/maven2/edu/berkeley/cs/firrtl_2.12/1.2.1/firrtl_2.12-1.2.1.jar ...
[info]  [SUCCESSFUL ] edu.berkeley.cs#firrtl_2.12;1.2.1!firrtl_2.12.jar (201ms)
[info] downloading https://repo1.maven.org/maven2/edu/berkeley/cs/firrtl_2.12/1.2.2/firrtl_2.12-1.2.2.jar ...
[info]  [SUCCESSFUL ] edu.berkeley.cs#firrtl_2.12;1.2.2!firrtl_2.12.jar (605ms)
[success] Total time: 6 s, completed Mar 11, 2020 12:25:46 PM

Weird that tests are failing because it works for me locally...

@seldridge I changed this to require binary compatibility with 1.2.+, the idea being that it will always use the newest published version which means we should be inductively binary compatible all the way back to 1.2.0, except for the fact that we haven't tested those. So I'm going to test that up to 1.2.4 manually, and then it should be true going forward.

I'm good with the induction.

What's the benefit over simply ensuring compatibility with 1.2.0?

What's the benefit over simply ensuring compatibility with 1.2.0?

If we add something in 1.2.1 then accidentally remove it, we wouldn't notice and then 1.2.2 could be binary incompatible with 1.2.1. Unless you also enforce forwards binary compatibility (which the Scala collections do), you need to check against each prior version.

@seldridge @ucbjrl @albert-magyar I updated this to check for binary compatibility against 1.2.4 and I manually ran the check against 1.2.0-1.2.4 and confirmed that we are good so far 🙂


Pre-configured logging prefix

Would be useful to have an option to set a logging prefix to use on all console log messages generated. This could then be used to quickly filter the log output in the console accordingly.

@johnrix good point, if you take a look at the code that is here, it should be pretty easy to add this. If you want to take a stab at this and submit a PR that would be great !

Would the prefix be added even if no text was selected?

@pdonias, yes i was thinking that i would remove the whole 'TEST' prefix config option if no text was selected, adn have a new option (logging prefix). That way if a user selects this option, they must define a logging prefix, and it is used for all console log functions. I would also like to have a part of this prefix be the line number, so that if a person just has a bunch of console log statements in different parts of the code, instead of just saying something like "console.log('PREFIX')", it could say something like "console.log('PREFIX LINE 40')" making it easier to identify.

Sounds great :)

@pdonias, were you planning on taking a shot at this ? i got started a little while back, but am going to be bogged down with some of my job responsibilities till the ned of the year, so wont be able to get to this anytime soon. Also, thanks so much for cleaning up some of the other issues for the package ?

I wasn't planning to do it right now but maybe later, I don't know.
But I'll make sure to let you know if I'm working on it (by assigning myself on the issue, for example) so we don't do the same job twice.

perfect thanks.

Hi guys, apologies I didn't respond previously. I did clone the repo and start looking at it, but like yourself, got bogged down in work commitments. First time looking at Coffeescript or Atom extensions also, which slowed me up.
I do have another suggestion for improvement though, which is to have configurable log statements to support different languages besides Javascript, as well as custom log commands. I use PHP a good bit and have my own custom log command for the application I work on. It would be so handy to have this work for that also.
Perhaps a logging command template that applies per file extension? Maybe should be logged as a separate issue though?

@johnrix good idea, i think there is an issue already for this https://github.com/vishysank/console-log-atom/issues/5. I dont really use php, but do you have a sense of the log commands that you use ? Maybe if you can document them in an issue to enable php support, someone can pick it up to add that functionality

I've used various logging commands for PHP over the years, some being roll-your-own tools, other third party tools and also some PHP built-in commands, all depending upon the use case. Most recently, I wrapped one of my own in a global function named 'consolelog' with the same argument signature as the javascript console.log() function, so I can use your plugin and just remove the '.' before saving (PHP's object method/property access syntax uses arrows (->) instead of dots, so 'console.log' isn't feasible).
It would be handy to simply have a template field per file extension, where you can insert placeholders for the variable to log and the associated label eg.
myDebugClass->debug(%var, %label);
somedebugthing %var
etc.


Fix Display Names in action connectors

In Power Apps, action connectors don't use Display Names

Can this break existing customers using connectors?


Net::SSH::AuthenticationFailed

When passing "image_id", an AuthenticationFailed appears when trying to login as 'ubuntu', even if I set ssh_username or vm_user. Right now It makes no effect setting this last 2 parameters, I think this is a bug.
 - Waiting for transport on virtualmachine ...[2014-10-20T20:28:52+00:00] INFO: Executing sudo pwd on<EMAIL_ADDRESS>[2014-10-20T20:28:52+00:00] DEBUG: Opening SSH connection to<EMAIL_ADDRESS>with options {:timeout=>10, :password=>"..."}
[2014-10-20T20:28:54+00:00] DEBUG<EMAIL_ADDRESS>unavailable: SSH authentication error: #<Net::SSH::AuthenticationFailed: Authentication failed for user<EMAIL_ADDRESS>
machine_options = {
    :bootstrap_options => {
      :cloud_service_name => 'cloudservicename',
      :storage_account_name => 'storageaccountname',
      #:vm_size => "A7"
      :location => 'West US',
      :ssh_username => 'centos',
      :vm_user => 'centos'
    },
    :image_id => '0b11de9248dd4d87b18621318e037d37__RightImage-CentOS-6.5-x64-v13.5.3',
    # Until SSH keys are supported (soon)
    :password => "..."
}

Please reopen if the proposed remedy doesn't work for you :)


chore(ci/perf): fix build procress of performance workflow

@ADD-SP @fffonion Please open the EE cherry-pick PR for this PR.


Double the size of the OpenChain logo

Per request of @shanecoughlan , please increase the size of the OpenChain logo to fill the border.

Resizing causes other issues with crowding the navigation bar.
We decided to leave the logo the same size.


feat: Independent search engine

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


dvc show workflow: target metric change is not reflected in a graph

A metric was changed from 0.59 to 0.60 as result of algo params change and dvc repro. However, the change was not reflected in the graph.
I assume this is a result of the last design change.

Not relevant anymore. Closing.


sap.m.List: Keyboard page down doesn't account for visible row count

OpenUI5 version: latest
Browser/version (+device/version): Chrome, Firefox, IE 11
Any other tested browsers/devices(OK/FAIL):
URL (minimal example if possible): http://jsbin.com/pasuho/edit?html,js,output
User/password (if required and possible - do not post any confidential information here):
Steps to reproduce the problem:

Resize browser so that only 5 rows are visible
Click the first item (text 1)
Press Page Down key

What is the expected result? On page down, the 5th or 6th row should now be at the top
What happens instead? On page down, the 19th row is now at the top
Any other information? (attach screenshot if possible) In ListBase, here's the code:
// TODO: Maybe we need a real paging algorithm here
this._oItemNavigation.setPageSize(this.getGrowingThreshold());
The List is using growingThreshold property to determine how many rows to page down and up. By default, growingThreshold property has the value of 20. So if it's less than 20, it'll just go to the end or start of the list. It does not account for how many visible rows are within the view container. In
other words, if it's showing 5 rows, page down will go to row 21, skipping rows 6 to ~19

Hi,
Thanks for your feedback.
Page size calculation is never done by any control in ui5 it is not specific with sap.m.List.
Here is the keyboard handling spec for List from UX.
[sap.m.List] [PAGE UP]
 If focus is on item level, move focus up by page size. By default, page size is 20
items. Page size can be set by applications.
 If there are less item than needed by the page size above the focused item,
move focus to the first item.
 If focus is on the first item, do nothing
So it works exactly how it is specified but I will definitely inform UX and related colleagues whether we can do this in ItemNavigation or not.

Thanks for the response. Not sure I understand the ItemNavigation comment, but ideally the page size could be automatically determined at the time it's needed so that each application doesn't have to perform this same logic (perhaps inconsistently) across all instances of controls that support paging. Anything your team can do to help improve this would be appreciated.


优化 ConcurrentLruCache 的 computeIfAbsent 方法，避免多次调用 generator

Codecov Report

Merging #5602 (63b3930) into master (c9c32ba) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5602      +/-   ##
============================================
- Coverage     58.71%   58.70%   -0.01%
  Complexity    27640    27640
============================================
  Files          1323     1323
  Lines        127097   127095       -2
  Branches      23928    23927       -1
============================================
- Hits          74623    74613      -10
- Misses        43202    43214      +12
+ Partials       9272     9268       -4

Files
Coverage Δ

...ava/com/alibaba/druid/util/ConcurrentLruCache.java
75.10% <71.42%> (+1.06%)
:arrow_up:

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c32ba...63b3930. Read the comment docs.

ConcurrentLruCache 是从 spring 6.x 那边参考过来修改的，修改点有：
1、不通过构造器传入 generator
2、提供 computeIfAbsent 方法，语义和  ConcurrentMap 的 computeIfAbsent 相同
3、提供了 keys 和 forEach 方法，执行时没有加锁，数据不会特别准确


total_faces value returns to 0 between 2 scans

@robmarkcole this behaviour was noticed on HA 70.1 with stock component and multiple cameras. The types of cameras are generic rather than local file.
In HA dev tools States, I can see the value of total_faces increase temporarily when a face is present. It quickly reverts back to 0 between scans.  It should really stay at the max value until the next scan, as this could be great for specific uses. An example would be for shop owners trying to track the number of customers present in their store at any time.
Here is the code used:
  - platform: facebox
    ip_address: 192.168.x.x
    port: 8080
    scan_interval: 30
    source:
      - entity_id: camera.garden
        name: Garden

And here is a capture of the presence detection entity's history showing the total_faces attribute reverting back to 0 in between 2 image captures:

Do other users notice the same with multiple camera setups?
Is it recommended to use the local_file camera component rather than the generic one in order to only initiate image processing when motion is detected?

How are you triggering the scan? I guess you have set a long scan_interval and are using an automation?

Right now, I'm updating the generic camera every 30 seconds. Even if a scan happens in between updates, should be the same image.
Will look into logging this, but night time makes testing tricky! You mean a HA log, right? Not Facebox-side?

Yes HA logs

The regular HA log has no info. I started using the logger on the image_processing entities, but will update when morning/light comes!

Mmmh, I'm getting timeout in the log:
2018-06-21 22:10:21 WARNING (MainThread) [homeassistant.components.image_processing] Updating facebox image_processing took longer than the scheduled update interval 0:00:10
2018-06-21 22:10:23 ERROR (MainThread) [homeassistant.helpers.entity] Update for image_processing.kitchen fails
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 387, in _make_request
    six.raise_from(e, None)
  File "<string>", line 2, in raise_from
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 383, in _make_request
    httplib_response = conn.getresponse()
  File "/usr/local/lib/python3.6/http/client.py", line 1331, in getresponse
    response.begin()
  File "/usr/local/lib/python3.6/http/client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "/usr/local/lib/python3.6/http/client.py", line 258, in _read_status
    line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
  File "/usr/local/lib/python3.6/socket.py", line 586, in readinto
    return self._sock.recv_into(b)
socket.timeout: timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 440, in send
    timeout=timeout
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 639, in urlopen
    _stacktrace=sys.exc_info()[2])
  File "/usr/local/lib/python3.6/site-packages/urllib3/util/retry.py", line 357, in increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/usr/local/lib/python3.6/site-packages/urllib3/packages/six.py", line 686, in reraise
    raise value
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 601, in urlopen
    chunked=chunked)
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 389, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
  File "/usr/local/lib/python3.6/site-packages/urllib3/connectionpool.py", line 309, in _raise_timeout
    raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
urllib3.exceptions.ReadTimeoutError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8080): Read timed out. (read timeout=9)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity.py", line 204, in async_update_ha_state
    yield from self.async_device_update()
  File "/usr/src/app/homeassistant/helpers/entity.py", line 325, in async_device_update
    yield from self.async_update()
  File "/usr/src/app/homeassistant/components/image_processing/__init__.py", line 145, in async_update
    yield from self.async_process_image(image.content)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/image_processing/facebox.py", line 78, in process_image
    timeout=9
  File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 112, in post
    return request('post', url, data=data, json=json, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 508, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/sessions.py", line 618, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/requests/adapters.py", line 521, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPConnectionPool(host='<IP_ADDRESS>', port=8080): Read timed out. (read timeout=9)

Will try to use "scan_interval: 30" for the image processor... Now scanning every 10 seconds, but a new image arrives every 30 seconds!

OK, I believe this is due to using the generic camera rather than local file. I guess I'll have to figure how to always write the picture with the same file name and use local file camera. This makes more sense as it can be set to only process images when detecttion triggers on the camera anyway.
I can close this issue if you want.


atom --dev yields "nslog was compiled using a different version"

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

I am trying to run Atom in Dev Mode following these instructions. When I run atom --dev I get the following error:
Uncaught Exception:
Error: The module '/Users/junker/web/atom/node_modules/nslog/build/Release/nslog.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 64. This version of Node.js requires
NODE_MODULE_VERSION 57. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (module.js:671:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:166:20)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/junker/web/atom/node_modules/nslog/lib/nslog.js:5:11)
    at Object.<anonymous> (/Users/junker/web/atom/node_modules/nslog/lib/nslog.js:15:4)

This is what I've tried:

script/clean and script/bootstrap again

Rebuilding with npm rebuild and electron-rebuild.

Using node versions 6, 7, 8, 9, and 10. Same error.

Also worth noting is that script/bootstrap takes about 10 min to complete.
Steps to Reproduce
https://flight-manual.atom.io/hacking-atom/sections/hacking-on-atom-core/
Expected behavior:
It runs

Actual behavior:
Get error

Reproduces how often:
100%

Versions
macOS 10.14.3
Node.js 8.16.0 (but I've tried with 6, 7, 9, and 10 as well)
npm 6.4.1
Python v2.7.16
Command Line Tools for Xcode

The error is due to a mismatch in the Node.js versions used to compile the module. In this case it isn't your system Node.js, but the one embedded in Atom itself. The current stable release of Atom bundles Node.js 8.9.3 while the beta (and master) bundle Node.js 10.2.0.
I'm assuming that you are trying to use ATOM_DEV_RESOURCE_PATH, which means you need to be running a compatible version of the Atom binary, either atom-beta or the result of running script/build.
Thanks for reaching out!

Because we treat our issues list as the Atom team's backlog, we close issues that are questions since they don't represent a task needing to be completed. For most questions about Atom there are a lot of options, check out:

User Documentation — The Atom Flight Manual
Developer Documentation — Atom API Documentation
FAQ — The Atom FAQ on Discuss
Message Board — Discuss, the official Atom and Electron message board
Chat — Join the Atom Slack team

On Discuss and in the Atom Slack team, there are a bunch of helpful community members that should be willing to point you in the right direction.


Profile page jessica

Status:

Description

Fixes #
Todos

Screenshots

Hellooo this is Eesha updating the PR because I accidentally added my CSS changes to Jessica's branch instead of adding Jessica's profile page changes to mine 🙈 oopsie.
I've successfully styled the class cards according to figma, and I am currently working on how to align the wonky classes as well as building out the delete class button in the frontend.

Jessica - looks absolutely amazing! This was one of the bigger issues and it tackled many different frontend concepts (ie - useEffect, API wrappers, CSS, flex, async/await, callback functions). Super proud of you for implementing them all!
One thing is, your "Add Class" and "Submit" buttons aren't centered for me for some reason. Maybe you centered these using absolute positioning so it looks centered on your screen but not on other screens of different dimensions? Not 100% sure. If you could center both of those, that would be great!
Also, for some reason, when I add classes using the class form, once in a while it will only edit or replace a class instead of add it. I'm not sure why this is the case. If I refresh, it works as expected, but we shouldn't have to refresh every time. Please look into this too
Most of my other comments are about code style. You'll also need to pull from main to get DetailsModal. Great job overall!

Thank you much!! Appreciate all the help throughout the process :) I have resolved all your comments now!


Add clang-format in CI

Is your feature request related to a problem? Please describe.
We currently lack a unified format. It will be more difficult to maintain a unified format if we allow new pushes to follow their own format it will be difficult to maintain a unified format after we achieve one.
Describe the solution you'd like
run clang tidy as part of every CI run and fail the pipeline if the CI finds any discrepancies
Describe alternatives you've considered
run clang tidy as part of every CI run and automatically fix any discrepancies.

duplicate


Rendering of component not working

Hi! I remember that I had to implement own function to render component (related: #147), because rendering component had an error, thought I was my fault and continued with my project, but I tried to do it theRightWay™ and had this error: TypeError: html.replace is not a function, just right here:
html = self.settings.render[templateName].apply(this, [data, escape_html]);
// add mandatory attributes
if (templateName === 'option' || templateName === 'option_create') {
	html = html.replace(regex_tag, '<$1 data-selectable');
}

Selectize is expecting html to be string, but is an object.
Possible fix:
_componentToDOM: function _componentToDOM(componentName, data) {
      var componentLookup = (0, _emberGetownerPolyfill['default'])(this).lookup('component-lookup:main');
      var ComponentClass = componentLookup.lookupFactory(componentName);

      if (!ComponentClass) {
        throw new TypeError('component ' + componentName + ' does not exist.');
      }

      var component = ComponentClass.create({
        data: data
      });

      component.createElement();

      return component.element.outerHTML;
    },

Can you try 0.5.6 and close if it works?

Sure, will try


Setting log_path in GORACE fails on Windows

What version of Go are you using (go version)?
$ go version
go version go1.9.2 windows/amd64

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
$ go env
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\innix\Documents\dev\go-workspace
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?

Build a program with -race (here's a minimal program with a race condition).
Set the GORACE env var so that detected races are logged to a file instead of stderr.
Run program.

$ go build -race
$ GORACE='log_path=C:\reports\myprogram' ./test.exe

What did you expect to see?
The Go data race detector should have logged a data race to a file called C:\reports\myprogram.<pid>.
What did you see instead?
The program just outputs ERROR: expected '=' then exits:
$ GORACE='log_path=C:\reports\myprogram' ./test.exe
ERROR: expected '='

$

Other notes
This only happens when using absolute Windows paths. The following GORACE values with relative paths work as expected:
$ GORACE='log_path=myprogram' ./test.exe
$ GORACE='log_path=./myprogram' ./test.exe
$ GORACE='log_path=../../../myprogram' ./test.exe

Absolute paths still don't work if I use forward slashes instead, or if I use double backslash:
$ GORACE='log_path=C:\\reports\\myprogram' ./test.exe
$ GORACE='log_path=C:/reports/myprogram' ./test.exe

The directory C:\reports\ already exists and the program has permission to write files into it.
I'm using Git Bash for Windows in these examples, but the same problem occurs if I use Windows native tools. It's not a Git Bash issue.

@innix thank you very much for raising this issue. I can confirm it on windows/amd64. Unfortunetly the code for this lives in http://llvm.org/git/compiler-rt.git
I will let @dvyukov decide what to do here.
Alex

Closing this issue in favor of google/sanitizers#884.  There isn't anything we can change in the Go distribution  to fix this.


Update PlatformIO to latest (4.4 as of writing)

https://registry.platformio.org/tools/platformio/framework-espidf should be update to the latest release of esp-idf (4.4 as of writing)

Duplicate of https://github.com/platformio/platform-espressif32/issues/710
Please vote for https://github.com/platformio/platform-espressif32/issues/710


Adding Atomic pair counter

includes class definition and unittest.

(just to document) Out of the box this PR fails to link
nvlink error   : Undefined reference to '_ZN6Kokkos4Impl25g_device_cuda_lock_arraysE' in '..../pixeltrack-standalone/obj/kokkos/test/kokkos/AtomicPairCounter_t.cc.cuda.o'

because Kokkos is currently built as a shared library, and device link ignores code from shared objects.

Now the test builds, but both serial and cuda versions fail to run
$ ./test/kokkos/AtomicPairCounter_t.serial
size 8
Kokkos::abort: Requested Team Size is too large!Aborted (core dumped)

$ ./test/kokkos/AtomicPairCounter_t.cuda
.../pixeltrack-standalone/src/kokkos/test/kokkos/AtomicPairCounter_t.cc:45: lambda [](const Kokkos::Impl::CudaTeamMember &)->auto::operator()(const Kokkos::Impl::CudaTeamMember &)->auto: block: [0,0,0], thread: [0,0,0] Assertion `dc_d(0).get().m == n` failed.
terminate called after throwing an instance of 'std::runtime_error'
  what():  cudaDeviceSynchronize() error( cudaErrorAssert): device-side assert triggered .../pixeltrack-standalone/external/kokkos/source/core/src/Cuda/Kokkos_Cuda_Instance.cpp:139
Traceback functionality not available

OK, serial and cuda both work now and give consistent results with CUDA version of the unit test.


Additional metadata in package.json to avoid warnings

Right now, running 'npm install' on the analysis directory gets several warnings because it's missing some fields that installer hopes to see: description, readme, and repository. This pull request adds the missing fields.
Unlike the previous version of this pull request (#30), these changes did not adversely affect the javascript files. Grunt did re-write a few css files and an image file -- I hope that these are the normal sorts of grunt fluctuations and not substantive changes. Please let me know if there's still a problem!

Thanks for these changes!


Docs update for v0.9.1

Issue #, if available:
Description of changes:
Docs update for v0.9.1
/cherrypick release-0.9
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.9


Update rdf4j-model, rdf4j-query, ... to 4.0.4

Updates

org.eclipse.rdf4j:rdf4j-model
org.eclipse.rdf4j:rdf4j-query
org.eclipse.rdf4j:rdf4j-queryalgebra-evaluation
org.eclipse.rdf4j:rdf4j-queryalgebra-model
org.eclipse.rdf4j:rdf4j-queryparser-sparql
org.eclipse.rdf4j:rdf4j-rio-rdfxml
org.eclipse.rdf4j:rdf4j-storage

from 3.7.7 to 4.0.4.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.eclipse.rdf4j" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.eclipse.rdf4j" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #57.


License

Any chance you could provide an explicit license for jquery-dragster?  Most other jQuery plugins I've seen just copy jQuery's MIT license, but any clarification would be much appreciated.

Sure, can you send a pull request?

Yep, hopefully I did that right—first time doing a pull request.


Conditional removal of changelogs

Fixes

Fixes #4726 by @sarayourfriend
Description

Based on an environment variable conditionally removes the changelogs
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend I am not sure if this is the right approach for this issue.
For some reason, while setting up the project locally for some reason, after following the general development guidelines , the local test runs keep failing, should I ask for a solution in the slack channel ?

@kb-0311 Can you confirm you have you set up ov for linting? It comes pre-loaded with pre-commit so shouldn't have that issue. The output of cat .git/hooks/pre-commit should be this, if you have:
#! /usr/bin/env bash

export TERM=xterm

./ov hook pre-commit "$@"

If not, please follow the ov setup instructions on this documentation page, starting with ./ov init from the repository root, and then committing again.
Let me know if you run into any issues with setting up ov.

Thanks a lot , fixed the env setup error : )
Coming to how the redirects are being handled here in my PR:
https://github.com/WordPress/openverse/blob/c95cc0777c53d76e0362a8f88d24eb5937d292f3/documentation/conf.py#L139-L144
I am not really sure if this is the right way to go about it. Also, I could not really find the "Page not found" file location so just added a temporary value for now.

This LGTM! I have two small requests, and then this will be good to go from my perspective.
First is to add the following to documentation/conf.py so that we don't see non-actionable warnings in local builds:
nitpick_ignore_regex = () if INCLUDE_CHANGELOGS else (
    ("myst", ".*/changelogs/index.*"),
)

This uses the Sphinx configuration option nitpick_ignore_regex to ignore "nitpick" warnings about the invalid cross-reference which is the only targeted method to ignore this error that MyST's documentation describes.

The other thing to do is address the redirect. I like the idea of using a redirect, and it simplifies things a lot to do so. However, it would be nice to redirect to a page that explains why the changelogs are missing, if someone happens to run across a link to the changelogs that doesn't resolve when they are working in docs locally. Here is a diff you can work from that does that, by adding an orphan page under meta to redirect to when INCLUDE_CHANGELOGS is false:
diff --git a/documentation/conf.py b/documentation/conf.py
index 86035b925..a4d5e33ac 100644
--- a/documentation/conf.py
+++ b/documentation/conf.py
@@ -137,9 +137,6 @@ redirects = {
 }

 if "changelogs" in exclude_patterns:
-    # temporary placeholder for now
-    redirects["changelogs/"] = (
-        "/general/contribution/github_contribution_practices.html"
-    )
+    redirects["changelogs/index"] = "/meta/missing_changelogs.html"

 myst_enable_extensions = ["linkify"]
diff --git a/documentation/meta/missing_changelogs.md b/documentation/meta/missing_changelogs.md
new file mode 100644
index 000000000..c98635e87
--- /dev/null
+++ b/documentation/meta/missing_changelogs.md
@@ -0,0 +1,13 @@
+---
+orphan: true
+---
+
+# Changelogs missing from local build
+
+The documentation build excludes changelogs unless it is in a CI environment or explicitly instructed to include changelogs. This significantly reduces the number of files processed for local preview builds, which cuts startup time of the documentation preview by half and improving the ergonomics of working with preview documentation locally.
+
+To force the inclusion of the changelogs, run the documentation build with `INCLUDE_CHANGELOGS=1` in your environment. For example, the following will run the preview build, including changelogs:
+
+```shell
+ov env INCLUDE_CHANGELOGS=1 just documentation/serve
+```

Let me know if these requests make sense, or if you would like help implementing them, and thanks as always for the contribution @kb-0311 :pray:

@sarayourfriend Added the suggestions as well in the new commit, please do take a look when you are free.
And thanks a lot for the help : )


add pyqt5 and qtpy for ci

this PR adds pyqt5 and qtpy for testing with ci. I'm not sure if this is the best way or if we should explicitly require pyqt.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3598df9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   29.16%
=======================================
  Files           ?        5
  Lines           ?      120
  Branches        ?        0
=======================================
  Hits            ?       35
  Misses          ?       85
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3598df9...8975530. Read the comment docs.


Remove mutate image ref

Changes
Remove mutate_image_container_image reference
Fixes #
https://github.com/shipwright-io/operator/issues/127
-->
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[ ] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE

docker pull ghcr.io/shipwright-io/build/image-processing
Using default tag: latest
Error response from daemon: Head https://ghcr.io/v2/shipwright-io/build/image-processing/manifests/latest: unauthorized
lets wait the package going public before merging this

From the Shipwright refinement meeting, PR is on-hold until the new release v0.12.0 is ready.

/hold
Per @qu1queee's comment.
Since the v0.12 release will lead to some refactoring of the operator, should we cut a "release candidate" of the build before we add it here?

We also have nightly releases yamls - those could be used ahead of a release as well.


the tutorial made sense up until actually exporting the sounds

so it says to "Use the hammer2cbt.py script to convert your desired effects, it takes a few necessary arguments: etc..."
where should i be putting these "arguments"
i drag and drop all 3 files to the py script and nothing happens, and i have no idea where you expect me to input those things

hammer2cbt.py (And most python tools of it's style) Are supposed to be used through the command line interface. I'm not sure how exactly the python enviroment is on windows (I'm guessing you're doing this on windows) but it shouldn't be too different, just open a command line, call the script and you'll see the help message.


Add lines labels to  /crate/**/source/

While generating some links, I noticed that source files under https://docs.rs/crate/{crate}/{version}/source/src/{file} don't support line labels. This is opposed to the sources under https://docs.rs/{crate}/{version}/src/{krate}/{file}.html#{line} that do.
Usually, I'd just use the second link with line label support for everything. However, rustdoc can sometimes remap paths, for example if a path is set in Cargo.toml. This means that the second link doesn't always work. At the end of the issue, I'll give a detailed example of this.
For my use case, the best solution would be to add line numbers and line labels to the sources under crate/{crate}/{version}/source/.
I'd be happy to give the implementation a shot, if this is something that would be accepted and I get some hints where to start :dagger:

Specific example:
We run Clippy in our CI and collect lint emissions. These diagnostics have paths as seen by rustc. It would, for example, look like this: ./src/lib.rs:15. I now want to take these file names and link to docs.rs to help us investigate the lint emissions. For most crates, the link is simply constructed like this:

https://docs.rs/{krate}/{version}/src/{krate}/{file}.html#{line}

And this works for most crates, expect crates that remap their path in Cargo.toml, like this (Taken from rust-lang/cargo):
[lib]
name = "cargo"
path = "src/cargo/lib.rs"

The lint emission then has the path ./src/cargo/lib.rs but the documentation generated by rustdoc removes the cargo from the path. So using the previous link template generates:

https://docs.rs/cargo/0.80.0/src/cargo/cargo/lib.rs.html#10

This doesn't work due to the cargo/cargo. The correct link with the remapped path is:

https://docs.rs/cargo/0.80.0/src/cargo/lib.rs.html#10

This remapping only happens for rustdoc and not the source files under crate/ so if those would support line labels, it would be a simple way to always use the same link template.

I would be totally fine with having this feature and definitely see a use-case.
I'm happy to review any PR adding this. the interesting files are:

https://github.com/rust-lang/docs.rs/blob/master/src/web/source.rs
https://github.com/rust-lang/docs.rs/blob/master/templates/crate/source.html

I'll look into this :D
@rustbot claim

there is a current PR (#2292) that will change template rendering, not sure if you want to wait with your changes until it lands, or base your work ontop of it.

In that case, I'll wait a bit. Thank you for the early notice :D

#2292 is merged, so feel free to start @xFrednet :)

I've made some decent progress. My next step is now to highlight the line numbers. I found the implementation of rustdoc which seems to work well. Can I copy and adapt it, as long as I add a comment mentioning where it comes from? I'm asking regarding the license etc.

IANAL, but IMO you can just copy & adapt the code, even without attribution.
@GuillaumeGomez what do you think?
( also about the piece of code )

Yes it's completely fine. Just need to be careful that the line height of the line number is aligned to the code line.


Feat(compiler_base_error): Add methods to the DiagnosticHandler that emits Diagnostic as string.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

2. What is the scope of this PR (e.g. component or file name):

compiler_base_error.
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

add method "emit_all_diags_into_string" for 'DiagnosticHandler' to emit all diagnostics into strings.
add method "emit_nth_diag_into_string" for 'DiagnosticHandler' to emit one diagnostics into string.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
24 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.7%) to 89.617%

Files with Coverage Reduction
New Missed Lines
%

compiler_base/error/src/tests.rs
2
94.22%

compiler_base/error/src/diagnostic/diagnostic_handler.rs
22
82.93%

Totals

Change from base Build<PHONE_NUMBER>:
-0.7%

Covered Lines:
2106

Relevant Lines:
2350

💛  - Coveralls


Configuration cache

Describe the bug
Unable to take advantage of the gradle configuration cache as the swagger codegen is failing with error
Execution failed for task ':platform.clients.assets:generateSwaggerCodeApi'.
> Could not get unknown property 'swaggerCodegen' for configuration container of type org.gradle.api.internal.artifacts.configurations.DefaultConfigurationContainer.

Was wondering if there are any plans to update the plugin to support configuration cache.
To Reproduce:
Expected behavior:
Environment
Plugin version: 2.19.2
Swagger Codegen version: org.openapitools:openapi-generator-cli:6.2.0 and org.openapitools:openapi-generator-cli:4.3.0
Gradle version: 8.1.1
Java version: 11
OS: Mac

FWIW, there is on more issue listed when the build fails with the above error:
Configuration cache problems found in this build.

1 problem was found storing the configuration cache.
- Task `<redacted>` of type `org.hidetake.gradle.swagger.generator.GenerateSwaggerCode`: invocation of 'Task.project' at execution time is unsupported.

And yet another one
- Task `<redacted>` of type `org.hidetake.gradle.swagger.generator.ResolveSwaggerTemplate`: invocation of 'Task.project' at execution time is unsupported.

These are the minimal amount of changes we needed to do to get it working: #409
(ResolveSwaggerTemplate probably also needs adjustments, I think we do not use that)


Put generation of wrong sHO attribute behind feature toggle

This issue is imported from pivotal - Originaly created at Feb 26, 2019 by Thijs Kinkhorst
Engineblock contains special handling of the schacHomeOrganization attribute because of an error in the past. When schacHomeOrganization enabled in the ARP, it will release 3 attributes, all with the same value:

urn:mace:terena.org:attribute-def:schacHomeOrganization (correct)
urn:oid:<IP_ADDRESS>.4.1.25<IP_ADDRESS> (correct)
urn:oid:<IP_ADDRESS>.4.1.14<IP_ADDRESS>.15 (INCORRECT)

This was done very early in EB's life. Because it is released unconditionally if sHO is enabled, we have no good way to currently know which SP's still use this wrong value.
However, new/other installs of EB should not be bothered with this legacy. Therefore, the generation of the 3rd variant should be put behind a feature toggle, default OFF. So this only happens if you specifically want it (if you are SURFconext production).

Using the eb.arp_remove_non_conforming_sho_attribute feature toggle. Release of the deprecated attribute can be enabled. The following parameter can be used to explicitly enable it: feature_eb_arp_remove_non_conforming_sho (Michiel Kodde - Aug 11, 2020)

In retrospect it was deemed better to remove the flag and the incorrect OID from the config file. If any federation needs to rely on the incorrect alias of the sHO, it can manually configure it in the application/configs/attributes.json (Michiel Kodde - Aug 18, 2020)


BotStateScope to get full bot state memory

Fixes #1782
Description

Refactored BotStateScope to get full bot state memory.
Specific Changes

Refactored BotStateScope to return full state memory object
Put UserMemoryScope/ConversationMemoryScope back to default memory scopes
Allow reading UserState/ConversationState cache from TurnState

Testing

Unit tests covered.

Pull Request Test Coverage Report for Build 122317

42 of 51 (82.35%)  changed or added relevant lines in 6 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 77.204%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

libraries/botbuilder-dialogs/src/dialogManager.ts
22
25
88.0%

libraries/botbuilder-dialogs/src/memory/scopes/botStateMemoryScope.ts
9
15
60.0%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-dialogs/src/memory/dialogStateManager.ts
7
86.71%

Totals

Change from base Build 122201:
-0.1%

Covered Lines:
11845

Relevant Lines:
14616

💛  - Coveralls


R home directory is not defined

Hi,
I am running a .NET Core 2.0 Web API within a linux Docker container. This API uses the R.NET (1.7.0) NuGet package.
When debugging, it crashes in line number 182:

Fatal error: R home directory is not defined
The program '[211] dotnet' has exited with code 0 (0x0).
The program '' has exited with code 0 (0x0).
This is very weird as if I get inside the docker container by docker exec -it {containerID} bash  and execute which R I get the path where the R executable is installed: /usr/bin/R.
Therefore, I am able to execute R scripts manually within the container, but I am not through the R.NET library.

Has anyone faced this issue before?

Despite the fact I was setting the R_HOME environment variable via:
REngine.SetEnvironmentVariables(rPath, rHomePath); , the R_HOME env. variable never got set.
I reckon this is a bug and should be fixed.
The solution was to add the following line in my Dockerfile:
ENV R_HOME /usr/lib/R

I get the same error now with version 1.8.2.
REngine.SetEnvironmentVariables doesn't change anything.
Calling  Environment.SetEnvironmentVariable("R_HOME", "/usr/lib/R");    before   doesn't change  anything.
And passing RHome = "/usr/lib/R"   in StartupParameter  raise
System.NotSupportedException: Specified method is not supported. at RDotNet.StartupParameter.set_RHome(String value)
Web app running on kestrel .net core 3.1

in net8， my workaround like below:
// in my docker file
RUN apt-get update && apt-get install -y
libc6-dev
RUN ln -s /lib/x86_64-linux-gnu/libdl.so.2 /lib/libdl.so
RUN R_HOME="/usr/lib/R"
RUN export R_HOME
ENV R_HOME /usr/lib/R
// in the init code
Environment.SetEnvironmentVariable("R_HOME", "/usr/lib/R"); // I am not sure where it useful
REngine.SetEnvironmentVariables("/usr/lib/R", "usr/lib/R");


Adding hover effects to the intership cards of the internship web page

What's the style idea?
We need to improve the style of internship cards by adding suitable hover effects and adjusting the alignment of cards making them position in the right way.

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSoC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

please assign me this issue


Strange 'if' statement

Can you explain why, in section 'Meteor Method: Better Abstraction and Security' you don't close the 'if' statement?
Meteor.call('postInsert', post, function(error, result) {
      // display the error to the user and abort
      if (error)
        return alert(error.reason);
      Router.go('postPage', {_id: result._id});
    });

I wrote this as:
Meteor.call('postInsert', post, function(error, result) {
      // display the error to the user and abort
      if (error){
        return alert(error.reason);
      Router.go('postPage', {_id: result._id});
      }
    });

Which seems to accomplish the same.  I'm unclear if this is something unique to Meteor methods or if I'm missing something big here.

It's just an alternative syntax for one-line if statements in JavaScript :)

methodbox, ... you don't need curly brackets around a single-line statement (the single statement after an if condition), but with what you wrote (with a curly bracket) the code will never execute your Router.go statement..

Okay yeah I figured this out later.
So I'm okay to use the syntax I used but my Router.go should be outside the if statement, correct?

So like this:
Meteor.call('postInsert', post, function(error, result) {
      // display the error to the user and abort
      if (error){
        return alert(error.reason);
      }
    Router.go('postPage', {_id: result._id});
    });

yes

Awesome.  Appreciate the responses guys. I like to stick with a consistent syntax even if not required.


Commands after the image does not work.

Looks like a bug.
Example:
docker run --rm -it -p 50000:50000 -p 8080:8080 --name opcplc mcr.microsoft.com/iotedge/opc-plc:latest --pn=50000 --autoaccept --nospikes --nodips --nopostrend --nonegtrend --nodatavalues --sph --sn=25 --sr=10 --st=uint --fn=5 --fr=1 --ft=uint

What is the current output?*
version: '3.3'
services:
    iotedge:
        ports:
            - '50000:50000'
            - '8080:8080'
        container_name: opcplc
        image: 'mcr.microsoft.com/iotedge/opc-plc:latest'

What is the expected/desired output?
version: '3.3'
services:
    iotedge:
        ports:
            - '50000:50000'
            - '8080:8080'
        container_name: opcplc
        image: 'mcr.microsoft.com/iotedge/opc-plc:latest'
        args:
            - '--pn=50000'
            - '--autoaccept'
            - 'and so on...'

I had a worse case of this:
Input:
docker run -ti --rm -v ~/.ivy2:/root/.ivy2 -v ~/.sbt:/root/.sbt -v $PWD:/app -w /app mozilla/sbt sbt shell

Output:
version: '3.3'
services:
    shell:
        volumes:
            - '~/.ivy2:/root/.ivy2'
            - '~/.sbt:/root/.sbt'
            - '$PWD:/app'
        image: shell

So it gets the image completely wrong, and ignores -w

Indeed.  This is still an issue to this day.
Input:
docker run --detach --name stationeers --publish 27016:27016/udp hetsh/stationeers -load "My saved game" moon

Output:
version: '3.3'
services:
    moon:
        container_name: stationeers
        ports:
            - '27016:27016/udp'
        image: moon

Completley borked.

Still an issue not being recognizing the args in the docker run command --rm
Example:
docker run --rm -d -p 2022:22 --name workloader-ssh ansred/ubuntu-workloader-ssh
Current output (Missing the --rm arg)
version: '3.3'
services:
    ubuntu-workloader-ssh:
        ports:
            - '2022:22'
        container_name: workloader-ssh
        image: ansred/ubuntu-workloader-ssh

@ansred I cannot find any mapping for --rm, just ignored in my PR, is it right ?

@ederfdias : actually, args: is neither valid nor existing, all arguments need to be put either as string in command: or as array ([] or yaml form). So reimplemented as quoted string :
version: '3.3'
services:
	iotedge:
		ports:
			- '50000:50000'
			- '8080:8080'
		container_name: opcplc
		image: 'mcr.microsoft.com/iotedge/opc-plc:latest'
		command: '--pn=50000 --autoaccept --nospikes --nodips --nopostrend --nonegtrend --nodatavalues --sph --sn=25 --sr=10 --st=uint --fn=5 --fr=1 --ft=uint'

By the way, this probably suppose that the docker image define an entrypoint because there is no real command in your sample

Hi, this is solved by my PR https://github.com/magicmark/composerize/pull/571 deployed at https://deploy-preview-571--composerize.netlify.app/


M3-5999: Cloning in Cloud Manager should highlight the Linode to be cloned in the "Select Linode to Clone From" matrix

Description 📝
What does this PR do?

In the Plan selection table, default selection to the currently selected Linode's plan
Add the "Current Plan" chip to the selected Linode's plan
Focus the correct tab on the plan selection table.

Addressed this in both cloning and resizing Linode.
Preview 📷
https://user-images.githubusercontent.com/119517080/208792119-de97f49c-47a8-43dc-9c73-ac965661a92f.mov
https://user-images.githubusercontent.com/119517080/208792460-e90a5334-4f72-4e62-9c72-c3411258780e.mov
How to test 🧪
What are the steps to reproduce the issue or verify the changes?

Click clone Linode

Select Linode to be cloned

Scroll down the page and validate selected tab w.r.t the Linode's plan.

Click resize Linode

Scroll down the modal and validate selected tab w.r.t the Linode's plan.

How do I run relevant unit or e2e tests?
yarn cy:run

In the Resize flow, if you select a different plan, you get two "Current Plan" chips:

In the Clone flow, when you select a different plan, the "Current Plan" chip moves to whichever plan is selected at that moment. Is this the intended behavior per the discussion on the ticket?

IMO the behavior for the Resize flow should remain as it is in prod with regards to the chip, but we should have the appropriate plan tab selected upon modal open. And for the Clone flow, maybe the "Current Plan" chip should be displayed on the plan of the to-be-cloned-Linode, unless the user selects a different plan, at which time the chip would go away?
I also left a few other minor comments related to the linter and conventions.

@dwiley-akamai Good catch! Applied the fix.  Also, I think we should revisit the linter configurations, since we are loosing some of the TS features.
https://user-images.githubusercontent.com/119517080/209161730-6d0f6f40-792b-4350-8273-71678f0ab177.mov


Need example of how to deploy using Azure Pipelines

Not setting repositoryUrl is fine on first deploy, but on second deploy (or after deploying the application), I get the following error:
undefined: RepositoryUrl is invalid.  Cannot change the RepositoryUrl. Please detach your static site first if you wish to attach to another repository.
This indicates that the repositoryUrl is set to something and running the ARM deployment again tries to change this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb567df0-dc83-c3d4-a65e-6a792d4197b0
Version Independent ID: f5cb30b7-f99b-c50a-d322-194f9f7db831
Content: Tutorial: Publish Azure Static Web Apps using an ARM template
Content Source: articles/static-web-apps/publish-azure-resource-manager.md
Service: static-web-apps
GitHub Login: @petender
Microsoft Alias: petender

@heing
Thanks for your feedback! We will investigate and update as appropriate.

@petender, Requesting your comments on this feedback.

Thanks for the comments, petender. @heing, We will close this out, but if you feel you need more information please just let us know.

Thanks for the reply. I do not set repositoryUrl, but the AzureStaticWebApp@0 task sets it when deploying my application. After that, I cannot run ARM template deployment. Setting repositoryUrl to null in the ARM template does not help. How can I prevent the AzureStaticWebApp@0 from setting repositoryUrl when deploying using Azure Pipelines?

Hi Heing, the repositoryURL parameter gets set during the deployment, whether you run this from an ARM template or from Azure DevOps. Once this setting has been set (the unique URL.azurestaticapps.net) you see on the service, it cannot be changed. As said earlier, the SWA team is working on an update in the next release of SWA to allow more IaC scenarios taking care of this.


choose solution for tolerating legacy ids in MongoDB despite new minter capabilities and new schema validation patterns

tolerate two different patterns via LinkML any_of?
change or remove the pattern or structured_pattern assertions? and apply some imperative validation on objects in MongoDB after the fact?

A Berserker Squad meeting just ended, and I believe @cmungall was advocating for removing the structured_pattern assertions, but leaving the settings intact. I don't think that's a good idea, because the per-class typecodes aren't expresses as settings anymore. They are hard-coded into the  structured_patterns to make their lookup more direct.
I had just merged code that adds gen-linkml with --materialize-patterns right before gen-jsonschema. Some rudimentary pattern assertions are still in place too. I could remove the pattern assertions, and we could have two versions of the jsonschema: one with --materialize-patterns and one without.

structured_patterns have been asserted but will not be materialized in advance of GSP, so legacy ids will validate.


🐛 [Bug] PM2 doest restart on deploy

🐛 Bugreport

@einhornimmond said that the PM2 process running the backend (apollo) server is not restarting properly when deploying a new version on staging.
Is this still the case?
What is/was the probem?
How can we ensure we will not have it again?

I have fixed it so far.
I use nvm (https://github.com/nvm-sh/nvm) for node and npm version managing. That makes it easy to use different node versions parallel. Also it is easy to install a specific node version.
Bad it is not good for scripting. Because in scripts you must call the binaries with her complete path (or add the path manually), as you should have seen in build_frontend.sh
So I have update the call to pm2 with the complete path, and now it should work.


Importing pyfolio implicitly imports every module in PyFolio

This has two major negative consequences:

During development, an import-time error (e.g. a syntax error, or a missing package) anywhere in the repo causes all imports to fail.
Importing anything in the library takes an annoyingly long (almost 3 seconds on my machine) amount of time.  Most of this time is spent in seaborn.__init__.

@twiecki is there a reason we're doing this in the module __init__?
from . import utils
from . import timeseries
from . import pos
from . import txn

from .tears import *  # noqa
from .plotting import *  # noqa

I'm not a big fan of having the user know about sub and subsubmodules for using the module. If you look e.g. at pandas or seaborn, most of the user-facing functions are in the main name-space. The reason for the #noqa is that flake8 complains otherwise. We should probably add the functions we want to expose via __all__ however.

If you look e.g. at pandas or seaborn, most of the user-facing functions are in the main name-space.

This is my least favorite thing about the pydata ecosystem.  It makes it a pain to find where things are actually defined, which often contributes to circular dependencies which get resolved with runtime imports rather than proper package structure (which in turn bites us on Quantopian because we run in a chroot for security reasons), and it means that performance issues in any of your dependencies leak into module in your code, which creates an unpleasant user experience.
I'm not arguing that there's no place for putting important functionality in a top-level namespace, but we should be careful about what we choose to export in this way, and we should be aware of the performance and maintenance costs that come from this.

I don't think it's a big deal. People can always selectively import if they want to and there's no sense in importing a module if you don't want to use it.

People can always selectively import if they want to and there's no sense in importing a module if you don't want to use it.

What's meant here by "people can always selectively import"?  The issue here, in my mind, is precisely the fact that people can't selectively import, because if you import from any file in PyFolio you trigger execution of every file in PyFolio.  This means that, as an application developer, I can't import PyFolio at module scope anywhere in my application if three seconds of startup latency is unacceptable (which it is in Quantopian Research).  This in turn means that if I want to use PyFolio I have to do lazy runtime imports everywhere, which hurts package organization and makes module dependencies unclear.
There are real arguments to be made that namespace convenience is worth the cost of the above issues, but I don't think it's fair to say this isn't an issue.

Ah, you're right. I had assumed a selective import gets around that issue.

I think we should raise an issue with seaborn about this.

OK, lets wait for upstream to fix it then. I don't think this should have any consequence for research anyhow, aren't we importing matplotlib.pyplot there by default? That way the pyfolio import should be snappy.

Hi Guys I think I am facing an import error, both Ubuntu 14.04LTS and OSX. Using anaconda, and zipline 0.7.0 at the moment (waiting for the conda update). I am aiming to start testing pyfolio in standalone mode, when there errors are depending if I have imported pandas or not, please see below. Would appreciate if have any help here.
import pyfolio as pf

ValueError                                Traceback (most recent call last)
 in ()
----> 1 import pyfolio as pf
//anaconda/lib/python2.7/site-packages/pyfolio/init.py in ()
2
3 from . import utils
----> 4 from . import timeseries
5 from . import pos
6 from . import txn
//anaconda/lib/python2.7/site-packages/pyfolio/timeseries.py in ()
22 import scipy as sp
23 import scipy.stats as stats
---> 24 from sklearn import preprocessing
25
26 import statsmodels.api as sm
//anaconda/lib/python2.7/site-packages/sklearn/init.py in ()
55 else:
56     from . import __check_build
---> 57     from .base import clone
58     __check_build  # avoid flakes unused variable error
59
//anaconda/lib/python2.7/site-packages/sklearn/base.py in ()
9 from scipy import sparse
10 from .externals import six
---> 11 from .utils.fixes import signature
12
13
//anaconda/lib/python2.7/site-packages/sklearn/utils/init.py in ()
8 import warnings
9
---> 10 from .murmurhash import murmurhash3_32
11 from .validation import (as_float_array,
12                          assert_all_finite,
numpy.pxd in init sklearn.utils.murmurhash (sklearn/utils/murmurhash.c:5029)()
ValueError: numpy.dtype has the wrong size, try recompiling
In [2]:
d
import pandas as pd
In [3]:
as pf
import pyfolio as pf
ImportError                               Traceback (most recent call last)
 in ()
----> 1 import pyfolio as pf
//anaconda/lib/python2.7/site-packages/pyfolio/init.py in ()
1 import warnings
2
----> 3 from . import utils
4 from . import timeseries
5 from . import pos
ImportError: cannot import name utils

I think this is unrelated to pyfolio but suggests that you're using an incompatible numpy. I'd try reinstalling that and making sure you're using the anaconda python.

Thanks for the prompt reply, I did try reinstalling it a couple of time no luck! Actually, I think zipline install using conda, downgrades the issue numpy!! The reason, I am using that is I am facing issues with pip install on zipline, which bit frustrating, and was wating for conda 0.8.14 release! Seems like I have no choice, I will give it a go! thanks for the feedback!

Just a feedback, the issue was related to downgrading grading of numpy etc while installing zipline using conda, I can't get pip install zipline (0.8.3) to work (if you could help that would be great, I have posted details)
So end of the day, pyfolio works fine in standalone mode, and in zipline (0.7.0) installed using conda, would be good to have them working togther. Not sure if waiting for zipline conda package to 0.8.
3  is the best way forward ? I seems to have spend a lot of time installing!!
Again many thanks for your help in first place :)

Yes, I'd wait for zipline 0.8.4 on conda. I hope we can make it numpy 1.10 compatible or it might not help with this.

Thanks that great, actually, pyfolio on conda would also be perfect Actually, I think these are main barriers to wider usage of the amazing work at quantopain. Have a look at the blogs probably installation issues, end up taking a lot of your time as well!!
Down grading numpy to 1.9 also broke my other packages, which are even trickier to install :(((((((

Yep, I'm well aware.
We can add pyfolio conda packages, just haven't so far as it should be very easy with pip install just because it doesn't require compilation but might as well add it.

@jehillparikh I uploaded a conda  package. Can you try: conda install -c quantopian pyfolio?

conda pyfolio works! However, numpy was upgraded during installation, to
1.10, along with others, thus zipline doen'st work anymore, which I
expected.  I got the following error whiling running your Markovitz
portfolio example.
Is it possible to build pyfolio with same version as zipline ? Otherwise we
wait till zipline upgrade ?? Thanks!
runfile('/home/jehill/temp.py', wdir='/home/jehill')
[[  2.77880107e-09]
[  3.20322848e-06]
[  1.54301198e-06]
[  9.99995251e-01]]
IBM
GLD
XOM
AAPL
MSFT
TLT
SHY/home/jehill/anaconda2/lib/python2.7/site-packages/pandas/io/data.py:33:
FutureWarning:
The pandas.io.data module is moved to a separate package
(pandas-datareader) and will be removed from pandas in a future version.
After installing the pandas-datareader package (
https://github.com/pydata/pandas-datareader), you can change the import
from pandas.io import data, wb to from pandas_datareader import data, wb.
FutureWarning)
[2016-01-06 15:42] WARNING: Loader: No benchmark data found for date range.
start_date=2016-01-06 00:00:00+00:00, end_date=2016-01-06 15:42:51.878100,
url=
http://ichart.finance.yahoo.com/table.csv?s=^GSPC&a=0&b=6&c=2016&d=0&e=6&f=2016&g=d
/home/jehill/anaconda2/lib/python2.7/site-packages/zipline/data/loader.py:230:
FutureWarning: iterkv is deprecated and will be removed in a future
release, use iteritems instead.
for tr_dt, curve in treasury_curves.T.iterkv():
Traceback (most recent call last):
File "", line 1, in
runfile('/home/jehill/temp.py', wdir='/home/jehill')
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/spyderlib/widgets/externalshell/sitecustomize.py",
line 699, in runfile
execfile(filename, namespace)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/spyderlib/widgets/externalshell/sitecustomize.py",
line 81, in execfile
builtins.execfile(filename, *where)
File "/home/jehill/temp.py", line 341, in
results = algo.run(data)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/zipline/algorithm.py",
line 398, in run
self.sim_params.first_open)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/zipline/history/history_container.py",
line 171, in init
self.create_return_frames(initial_dt)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/zipline/history/history_container.py",
line 264, in create_return_frames
index = pd.to_datetime(index_at_dt(history_spec, algo_dt))
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/pandas/util/decorators.py",
line 89, in wrapper
return func(*args, **kwargs)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/pandas/tseries/tools.py",
line 276, in to_datetime
unit=unit, infer_datetime_format=infer_datetime_format)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/pandas/tseries/tools.py",
line 395, in _to_datetime
return _convert_listlike(arg, box, format)
File
"/home/jehill/anaconda2/lib/python2.7/site-packages/pandas/tseries/tools.py",
line 383, in _convert_listlike
raise e
ValueError: Tz-aware datetime.datetime cannot be converted to datetime64
unless utc=True
Jehill
On 6 January 2016 at 15:25, Thomas Wiecki<EMAIL_ADDRESS>wrote:

@jehillparikh https://github.com/jehillparikh I uploaded a conda
package. Can you try: conda install -c quantopian pyfolio?
—
Reply to this email directly or view it on GitHub
https://github.com/quantopian/pyfolio/issues/73#issuecomment-169356062.

@jehillparikh Thanks for letting me know. Yeah, the only sensible thing is to have zipline work with numpy 1.10. @richafrank is working on the conda zipline package.


Exclude book notebooks from execution does not seem to work

Hi jupyter-book team,
I hope this is the right place to add my question/issue
I am working on a jupyter-book: https://github.com/CUQI-DTU/CUQI-Book
Some of the Python notebooks that are included in the _toc are time-consuming or need a special environment set up, so I want to exclude them from execution but still include them in the book.
I saw an example of how to set that in: https://jupyterbook.org/en/stable/customize/config.html by adding the directive exclude_patterns but it does not seem to work.
In particular, this is the setting from reference:
exclude_patterns: []    # A list of patterns to *skip* in execution (e.g. a notebook that takes a really long time)

When I add patterns in [] (e.g. ['*chapter01*']) the corresponding files still get executed.
your help is greatly appreciated!

I am closing this because it is resolved for me, I figured out that putting the file path in the string pattern does not work, and I need to put a pattern that matches the notebook name only.
e.g. for notebook ch01/notebook1.ipynb, the pattern should be something like:
exclude_patterns: ['noteb*']    # A list of patterns to *skip* in execution (e.g. a notebook that takes a really long time)

not like
exclude_patterns: ['ch01/noteb*']    # A list of patterns to *skip* in execution (e.g. a notebook that takes a really long time)


Missing .s in domain display

In the Domains table, we are showing a user's domains, but they are missing all the .s except for the first one:

I have confirmed that this is not the case in the DB or Route53, it only happens in the UI.  I think it's probably due to how we're doing the UI to show the subdomain with a different colour.
cc @Myrfion

resolved in #369


add what's new note about Rect → Rectangle

Suggested by @jburel re. something on a docs card.
--no-rebase

Ah, now found https://trello.com/c/2Mzfzvho/74-developer-doc-updates -- not that Trello bothered notifying me my name was there, bah!

just added your name after we spoke!!

Conflicting PR. Removed from build OMERO-DEV-merge-docs#95. See the console output for more details.
Possible conflicts:

Conflict detection failed

None

To be cherry-picked onto #1313.


Ceepos integration: Use correct tax codes for Tampere

Use the Tampere specific Ceepos tax codes in the Ceepos integration.
Refs TTVA-39

Self-merging this as a fix up to TTVA-9


WIP: Allow for creation of recurring and adhoc subscriptions

Add support for creating a recurring subscription (i.e. monthly payment via card for R 99) or adhoc (i.e. R 10 airtime voucher when the user requests the payment).

Sorry I have included a security patch here.  Can this be merged ASAP?  The code coverage I will look at and submit another pull request for.

If you need this in a tagged release please let me know, please verify that it works in a production environment first.

Please tag (I've tagged my fork for use with production).

Released as v2.2


Anti-Entropy loops endlessly with empty shard [Port to 2.0]

Port https://github.com/influxdata/influxdb/issues/21273 to 2.x branch
Associated PR: https://github.com/influxdata/influxdb/pull/21275

@danxmoran - Added you as a co-owner, because this is a simple cherry-pick, but I don't have a working 2.0 build.  Commit on master-1.x is 7f300dc248d767ee1a96642480dfa1daa28f18ba
Not a priority, because this is actually a fix for an Enterprise bug, but we should put it in to maintain consistency of behavior in the situation across OSS versions.
I may get 2.0 building before we get around to this, of course, and I'll do the cherry-pick, then.