[ Request ] - lsp_document_symbols filter argument

Hey there,
I've never been a big fan out "outline" views in Vim as I can't get them to ever work well with split windows.
I've been experimentin with using lsp_document_symbols command to work similarily to a document outline, but obviously a bit flatter.
What would be interesting is if I was able to do something similar to FzfLua lsp_document_symbols METHODS and output all the methods of the file. Repeat for any LSP kind.

It’s already possible with workspace_symbols by supplying queryargument:
:FzfLua lsp_workspace_symbols query=METHODS

I will add this functionality to document symbols too, is this what you’re after?

Would be great!
On Tue, Aug 31, 2021 at 8:42 PM ibhagwan @.***> wrote:

It’s already possible with workspace_symbols by supplying queryargument:
:FzfLua lsp_workspace_symbols query=METHODS
I will add this functionality to document symbols too, is this what you’re
after?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ibhagwan/fzf-lua/issues/80#issuecomment-909764147,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLBVFWFOJXFE3DU3WWKRG3T7VZI7ANCNFSM5DFIUPOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It’s already possible with workspace_symbols by supplying queryargument:
:FzfLua lsp_workspace_symbols query=METHODS

~I will add this functionality to document symbols too, is this what you’re after?~ I actually cannot add query to document_symbol as this is not supported by the LSP implementation only the workspace_symbol function supports {query}.

Ahh I see.

It’s already possible with workspace_symbols by supplying queryargument:
:FzfLua lsp_workspace_symbols query=METHODS

~I will add this functionality to document symbols too, is this what you’re after?~ I actually cannot add query to document_symbol as this is not supported by the LSP implementation only the workspace_symbol function supports {query}.

Ahh I see.

I can still easily do it, but the filtering would have to be done inside fzf-lua instead, try out the lsp_live_workspace_symbols provider which sends your queries to the LSP server as you type (similar to live grep).
If these results are what you’re after I can add a current_buffer_only flag to lsp_workspace_symbols you can use that instead of lsp_document_symbols.

To emulate a replacement to an "outline" plugin, all symbols in the
document should be present first (not have to be searched for).
On Wed, Sep 1, 2021 at 1:33 PM ibhagwan @.***> wrote:

It’s already possible with workspace_symbols by supplying queryargument:
:FzfLua lsp_workspace_symbols query=METHODS
I will add this functionality to document symbols too, is this what you’re
after? I actually cannot add query to document_symbol as this is not
supported by the LSP implementation only the workspace_symbol function
supports {query} https://neovim.io/doc/user/lsp.html.
Ahh I see.
I can still easily do it, but the filtering would have to be done inside
fzf-lua instead, try out the lsp_live_workspace_symbols provider which
sends your queries to the LSP server as you type (similar to live grep).
If these results are what you’re after I can add a current_buffer_only
flag to lsp_workspace_symbols you can use that instead of
lsp_document_symbols.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ibhagwan/fzf-lua/issues/80#issuecomment-910501701,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLBVFSL573D7HJXK66UMCLT7ZPWJANCNFSM5DFIUPOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I'm not aware of the the outline plugin, I just added the option to filter all LSP functions by current buffer, try it out and let me know if that works for you?
:lua require('fzf-lua').lsp_workspace_symbols({ current_buffer_only = true, query = 'edit' })
:lua require('fzf-lua').lsp_references({ current_buffer_only = true })

Note that you now have to use lsp_workspace_symbols and not lsp_document_symbols as the latter does not support a query argument.

This works pretty good! thanks.

Great :)
Closing.


unable to load Tables on  Storage Explorer

Unable to retrieve child resources.
Details:
self signed certificate in certificate chain

@pluo2000 please see our troubleshooting guide for help with this issue:
https://docs.microsoft.com/en-us/azure/storage/common/storage-explorer-troubleshooting?tabs=Windows%2C1804#error-self-signed-certificate-in-certificate-chain-and-similar-errors

Closing due to lack of response. Please open a new issue if you're still having problems.


⚠ GitLab Server has degraded performance

In 9e47e6e, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11564 ms

Resolved: GitLab Server performance has improved in 46f2643.


Changes for the header& the categories part to make it more appealing.

@Trisha-tech  please find the attached.
I can make the header hovering option more appealing.
please add the necessary labels.
Thank you!

@saatvika07 go ahead with it, assigned to you


help me

======== Exception caught by widgets library =======================================================
The following assertion was thrown building BlocBuilder<WishlistCubit, WishlistState>(dependencies: [_InheritedProviderScope<WishlistCubit?>], state: _BlocBuilderBaseState<WishlistCubit, WishlistState>#88fb7):
'package:flutter/src/widgets/scroll_view.dart': Failed assertion: line 116 pos 15: 'semanticChildCount == null || semanticChildCount >= 0': is not true.

@RothaSoeurn
When opening an issue, please try to use new issue template and fill out requested details so that we'll have enough info to work with.
Closing for now, as no details are provided. Just posting error message isn't enough to properly address the issue.


🙉 When will OKHTTP 5. x release

We plan to use JDK 21 in the production environment to optimize requests through coroutine, but currently there has been no release for OKHTTP, so we are unsure if there may be any issues. So, when will OKHTTP 5. x release?

It's hopefully close, a few small improvements to make but that are generally existing problems in 4.x also.  But we don't promise dates.
The 4.x APIs and functionality should be considered supported still, and if you avoid the experimental APIs, then you should consider 5 production ready.


Nested tag support for querying

Hi there! First off thanks for such an awesome plugin 💥
I'm trying to come up with a good workflow for tracking my travels. Currently I have a folder named "Activities" where I put all of my travel notes. Each activity note has a nested tag (ie. activity/food, activity/hike) but none of the activity notes have the top level activity tag on them. I also have a folder named "Places" where I put all of the places I want to go or am interested in. I would like to have a map of all the places I've had an activity, and a different map describing all of the places I want to go.
Based on how the dataview queries work, I expected a configuration like this to show all notes tagged with activity (including nested tags):
{"name":"Default","mapZoom":1,"centerLat":41.244517994223585,"centerLng":-37.26562500000001,"query":"tag:#activity","chosenMapSource":0}

Unfortunately, this only queries for notes that have exactly activity as a tag. I ran across this issue https://github.com/esm7/obsidian-map-view/issues/10 and was hoping since other people are using nested tags this would be a nice feature to complement nested tag support for icons.

You're right, tag wildcards work for icons but not for queries, and that's an annoying gap that I want to close soon. Will fix.

Added in 3.0.2.


2.3 - Peer review

Completed the peer review at this link: https://github.com/UBC-MDS/DSCI532-peer-review/issues/13


feat: clean-up package structure and partial TypeScript fixes

This PR is rather long. I am not done yet, but I figured it was a good moment to wrap it up as I am half way through it.
Here are the things that I've done so far:

Removed some stuff that we are not using right now:  turborepo, manypkg, node-gyp and more
Regrouped dependencies to match what current package is using
Cleaned up extraneous workspace dependencies: should not contain anything React Native / Expo related.
Removed resolutions for React versions. I don’t think we need it. We can always check with yarn-dedupe or inspect the lock file. If we end up with multiple versions of React, there must be a reason, so it’s better to debug that reason first before jumping to fixing. We already have an auxiliary script check-deps to ensure correct versioning within the monorepo.
Run check-deps to fix some issues. Otherwise, fresh project didn’t want to build.
Moved some gitignore files to the top-level and removed inner ones.
Removed .nvmrc (no clear guidelines we use it actually. I e.g. use something else) and moved Node engine requirement to the top-level package.
I haven’t tested release-related code yet. We will figure this out later, but I am leaving placeholder for now at the top-level only.
Changed yarn build to not run on every install. It is not necessary. We’re using source files anyways during development.
Got rid of tamlgui-build in favour of unified build pipeline with react-native-bob for simplicity
Renamed app to @react-native-templates/app (for now) and re-grouped its structure to match other packages (it's pending refactoring anyway)
Removed babel plugin to rewrite imports inside rise-mobile and using normal module system at this point. Had to re-export some members (with * for now) from the app package

We can get back to using yarn once I resolve some build issues, but I think for time being, defaulting to Node LTS and bundled npm is not a bad idea at all.

Additional changes:

Removed react-native-builder-bob and will be running a single tsc script to build all packages
Cleaned up duplicated Tamagui configuration and invalid Next.js configuration (we now import web extension over normal one, so React Native code does not get loaded)
Added CONTRIBUTING.md file with a starting point to document ways of working on this project and helpful commands
Some other smaller changes that I lost track of


[BACKPORT][v1.2.x][BUG] After automatically force delete terminating pods of deployment on down node, data lost and I/O error

ref: https://github.com/longhorn/longhorn/issues/4384

Verified passed on v1.2.x-head (longhorn-manager 06a53b8)


Add embbed vector_search in uri

Description

Related Issues

Checklist

[ ] Is this code covered by new or existing unit tests or integration tests?
[ ] Did you run make test successfully?
[ ] Do new classes, functions, methods and parameters all have docstrings?
[ ] Were existing docstrings updated, if necessary?
[ ] Was external documentation updated, if necessary?

Additional Notes or Comments

Can we make vector search an interface, like compute or storage backends?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (34830a7) 80.33% compared to head (88792f5) 69.13%.
Report is 1291 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1520       +/-   ##
===========================================
- Coverage   80.33%   69.13%   -11.21%
===========================================
  Files          95      104        +9
  Lines        6602     7313      +711
===========================================
- Hits         5304     5056      -248
- Misses       1298     2257      +959

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ibmcloud cf install app-autoscaler plugin failed

when using ibmcloud 1.2.3 version ,
 ibmcloud cf install-plugin -r CF-Community "app-autoscaler-plugin"
Invoking 'cf install-plugin -r CF-Community app-autoscaler-plugin'...

Plugin repository CF-Community not found.
Use 'cf list-plugin-repos' to list registered repos.
FAILED

but when using 1.1.0, it works,
# ibmcloud cf install-plugin -r CF-Community app-autoscaler-plugin
Invoking 'cf install-plugin -r CF-Community app-autoscaler-plugin'...

Searching CF-Community for plugin app-autoscaler-plugin...
Plugin app-autoscaler-plugin 3.0.0 found in: CF-Community
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin app-autoscaler-plugin? [yN]: y
Starting download of plugin binary from repository CF-Community...
 10.07 MiB / 10.07 MiB [============================================================================================] 100.00% 22m11s
Installing plugin AutoScaler...
OK

Plugin AutoScaler 3.0.0 successfully installed.

and I directly use cf install command, it also works,
# cf version
cf version 6.53.0+8e2b70a4a.2020-10-01

# cf install-plugin -r CF-Community app-autoscaler-plugin
Searching CF-Community for plugin app-autoscaler-plugin...
Plugin app-autoscaler-plugin 3.0.0 found in: CF-Community
Attention: Plugins are binaries written by potentially untrusted authors.
Install and use plugins at your own risk.
Do you want to install the plugin app-autoscaler-plugin? [yN]: y
Starting download of plugin binary from repository CF-Community...
 10.07 MiB / 10.07 MiB [============================================================================================] 100.00% 22m11s
Installing plugin AutoScaler...
OK

Plugin AutoScaler 3.0.0 successfully installed.

Can you please check if any issue with ibmcloud version 1.2.3?

@aqan213 CF CLI 6.53.0 introduce a break change in their configuration file, which will wipe out the configuration data when IBM Cloud CLI interact with it. You probably is the victim of that issue.
That issue should have been fixed. Try to upgrade to the latest version of IBM Cloud CLI. If CF-Community repo is still not found, run ibmcloud cf add-plugin-repo CF-Community https://plugins.cloudfoundry.org to add it.

@aqan213 CF CLI 6.53.0 introduce a break change in their configuration file, which will wipe out the configuration data when IBM Cloud CLI interact with it. You probably is the victim of that issue.
That issue should have been fixed. Try to upgrade to the latest version of IBM Cloud CLI. If CF-Community repo is still not found, run ibmcloud cf add-plugin-repo CF-Community https://plugins.cloudfoundry.org to add it.

The issue of  CF CLI 6.52.0 was recorded here: https://github.com/cloudfoundry/cli/issues/2096

The issue of  CF CLI 6.52.0 was recorded here: https://github.com/cloudfoundry/cli/issues/2096


Cannot have "attributes" as a relation name

I have a model named "Blob" as shown below
class Blob
  include Mongoid::Document
  field :name, type: String
  embeds_many :attributes, class_name: "BlobAttribute"
  accepts_nested_attributes_for :attributes
end

and model named "BlobAttribute" below
class BlobAttribute
  include Mongoid::Document
  field :name, type: String
  embedded_in :blob, inverse_of: :attributes
end

On page load (on loading of BlobAttribute class in development mode), I get a "System Stack too Deep" error.
When I change the name of the relation to be "blob_attributes" instead, it worked.
I suspect that there is a method named "attributes" that overlap with the relation so that we cannot have a relation named "attributes". I am on Mongoid 4.0.0

attributes is a reserved word in Mongoid as you would be overriding Mongoid's attributes method by defining a relation with this name. It's just simply not allowed in this case.


Add Support to Define Type Alias for Primitive Types

Description:
Currently the GraphQL package doesn't allow to define type aliases for primitive types(int, string, boolean, decimal, float) due to a limitation in ballerina lang. Since we are generating the GraphQL schema in compile time, this limitation is not further affected. Therefore, this support can be added.

Mainly this support is needed for define constraints on scalar type arguments. But there are some limitations to complete this.
Consider the following type;
type Foo int;

Approach 1:
If we add this support, we have to interpret the Foo type as a custom scalar in GraphQL schema. But when we creating a custom scalar type from the type Foo, it missed the information of parent type(int) since GraphQL __Type cannot have  the ofType for scalars as per the spec. Hence, we cannot validate the custom scalar type at the runtime.
Approach 2:
Due to the above limitation, we tried to add a directive including the parent type info. But there is no way to introspect the schema directives in GraphQL. Therefore we cannot find the parent type at the runtime for validations.
Due to these reason, we cannot add this support at the moment.
However, if we introduce the custom scalar support , constraints support can be added for scalar arguments as well. Hence closed this issue.


Unintended white spaces are appended to the end of lines frequently

Unintended white spaces are appended to the end of lines frequently
** Suspect: Indent lines on paste option

This phenomenon is due to my habit and auto indentation.


Components

What does this PR do?

Deleted all the boilerplate from Create React App (text, images, styles).
Created a new directory called components.
Inside the components directory, created a new Calculator.js file.
In Calculator.js, created a React component that matched this design.
Implemented the design only (JSX and CSS).
Used functional components.
Created at least 1 child component.
Once the Calculator was ready, imported it and used it in your top-level component: App.js.
Tested it in the browser; it rendered without problems.

Hi @Obote, please fix the Stylelint linter error, this is a comment not a review 👍🏿


Order CompaniesDatasetView by modified_on to support delta-based ingests

Description of change

Checklist

[ ] Has this branch been rebased on top of the current main branch?

Explanation
The branch should not be stale or have conflicts at the time reviews are requested.

[ ] Is the CircleCI build passing?

General points

Other things to check

Make sure fixtures/test_data.yaml is maintained when updating models
Consider the admin site when making changes to models
Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Abandoning for now - there are related models fetched in the endpoint that don't have a modified_on date


[bug] style of error message in components that use a fieldset doesn't comply with dsfr

Error messages in components that use a fieldset (i.e. checkbox/radio/rich radio) are surrounded by <div class="fr-messages-group">, and the p child element has the fr-message and fr-message--error classes (see https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/case-a-cocher).
Without these classes the border on the left of the component doesn't render correctly.

Hi @isMattCoding, I'm not sure I fully understood the issue, but I submitted a PR to fix classes and tags mismatch on fieldsets (react-dsfr vs DSFR docs).
Let me know if this should fix this issue.

Closing this, I guess the PR did the job.


Documentation fixes

This Pull Request is related to issues :

#104
#107

Changes proposed in this Pull Request:

fixing some broken links in the documentation

Checklist:

[x] Descriptive title
[x] Targets the main branch
[x] Changes are functional
[ ] My code is explicit and comments were added to it
[ ] Code conforms with PEP8
[ ] Tests were added for the changes and they complete successfully
[ ] Existing tests were updated (if needed) and they complete successfully
[x] Documentation was updated

Hi @elodiegermani ! Please feel free to check if this PR answers what you suggested in the issues :slightly_smiling_face: Thanks !

Hi Boris! Well, actually, that does not really answer my questions about the "pipeline_test".
Actually, it was because I had a pipeline that was functional, it passed all the tests except this one because it is not set as an "implemented pipeline" in the Pipeline class init file but when I tried to change this, it raised other errors due to tests you implemented regarding the number of implemented pipeline, etc.
So I was wondering, is this part already functional in the test?
If so, do you want to decide on your side if a pipeline is implemented or not? Or can we add it ourselves?
If we can add it ourselves, it would be nice to have a list of tests to modify to be able to pass this test :)

Hi Elodie,
I understand your concern : the test you are talking about (test_utils() inside narps_open_pipelines/tests/pipelines/test_pipelines.py) is not relevant and should be changed. In fact, it is going to be changed soon, as part of one of my PRs.
Furthermore, i'll add something in the doc about modifying the implemented_pipelines dictionary, which you can do it by yourself of course, when starting a new pipeline reproduction.
Thanks !


Found some references to CivClassic, starter book also refers to a new player guide on the CivClassic subreddit, copy to CivMC ?

Welcome book definitely needs updating but this is as good a start as any, thanks


Icons for field values

The field schema provides for an icon representing the field itself (for now: #30), but it has no way to indicate an icon for an individual option in a combobox or similar. In some cases, the individual values of a key would be more recognizable by a small pictogram than by a textual description. For example:

mtb:scale:imba values are associated with basic colored shapes, but openstreetmap/id-tagging-schema#462 is resorting to emoji instead of images.
network on road route relations is usually associated with route shields, which can look good and discernible at a small size. (Try filtering this list by network.) The actual values follow a format that would only be familiar to more experienced mappers.
roof:shape is literally about a shape that could be depicted in an icon. Not everyone knows the names well.

I’d recommend that these icons be used only in situations where they would make the name more easily understood, not for decorative purposes. The name would still be present, so downstream consumers wouldn’t be forced to display these icons, which might not be possible anyways in some contexts.

I’d recommend that these icons be used only in situations where they would make the name more easily understood, not for decorative purposes

This criterium is a little fuzzy. What is considered as helpful for understanding differs from person to person. Do these help to understand the sport? https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/sport
IMO yes, but whether one really needs an icon for "tennis" can be taken into question.
With no clear definition, it is either up to the individual maintainer (@tyrasd) to decide on a case-by-case basis or/and (experience tells me) that more and more unimportant icons will creep in over time. Whether this is a bad thing, I don't know, I am just saying that it is a new can of worms. It may help to at least at the beginning have a strict guideline what icons may be included and which not.

As a proof of concept, iD now supports tag-value icons for the crossing:markings tag / field

I think that is a great idea and good solution that looks like something we would want as part of the schema so we can add more custom icons to more translated fields.

decide on a case-by-case basis or/and (experience tells me) that more and more unimportant icons will creep in over time.

I think we just have to see how popular this gets. I'd guess that iconography will almost always be of benefit, given that the chosen icons are good, which is IMHO the trickiest part here (e.g. due to the small size of the displayed icons). From my experience, people rarely have the time to put in extra effort to create good quality icons for presets already (we use much too many generic icons for presets already, see https://github.com/openstreetmap/id-tagging-schema/issues/41), so I'd actually be quite happy if we saw more people interested in making good icons for this new feature.


First attempt at addressing #104.

I failed to decipher the intent of what the "what about style?" part was, so that was removed.If someone can explain to me I'd be happy to add it back.

Preview | Diff

@pes10k, @hober wanted your LGTM before landing this.

@pes10k, @hober wanted your LGTM before landing this.


terminus site deploy fails with "Undefined property: stdClass::$body"

A ticket of the same name (#148) is closed, but I'd like to gingerly and respectfully suggest that this problem should be addressed.  Perhaps the author of #148 was suggesting that this issue belongs in a non-terminus issue queue (i.e. it's an issue at the API level)?  I would like to suggest that terminus should at the very least 1) indicate to the user whether the deploy succeeded or failed and 2) suppress repeating php errors.
I'm attempting to further automate our Drupal update scripts and conditions like this one are difficult to handle.
bwood@mbp bin$ terminus cli version
Terminus version: 0.5.5
Terminus script: terminus

terminus site deploy --site=websolutions-ob --from=test --env=live --cc --updatedb --note="istdrupal-updates-apply.php"

Notice: Undefined property: stdClass::$body in phar:///Users/bwood/bin/terminus-055/php/class-terminus-command.php on line 258

Call Stack:
    0.0015     226752   1. {main}() /Users/bwood/bin/terminus-055:0
    0.0126     844440   2. include('phar:///Users/bwood/bin/terminus-055/php/boot-phar.php') /Users/bwood/bin/terminus-055:4
    0.0127     857752   3. include('phar:///Users/bwood/bin/terminus-055/php/terminus.php') phar:///Users/bwood/bin/terminus-055/php/boot-phar.php:5
    0.0169    1683536   4. Terminus\Runner->run() phar:///Users/bwood/bin/terminus-055/php/terminus.php:37
    0.0226    2282872   5. Terminus\Runner->_run_command() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:155
    0.0226    2282936   6. Terminus\Runner->run_command() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:75
    0.0226    2284456   7. Terminus\Dispatcher\Subcommand->invoke() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:68
    0.0234    2345344   8. call_user_func() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/Subcommand.php:227
    0.0234    2345376   9. Terminus\Dispatcher\CommandFactory::Terminus\Dispatcher\{closure}() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/Subcommand.php:227
    0.0236    2367752  10. call_user_func() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/CommandFactory.php:35
    0.0236    2367784  11. Site_Command->deploy() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/CommandFactory.php:35
    3.3361    7134144  12. Terminus_Command->waitOnWorkflow()
    phar:///Users/bwood/bin/terminus-055/php/commands/site.php:718

(error repeats about 30x)

I completely sympathize with the annoyance of failing API requests dumping context-less stack-traces. My initial assumption here is that the deploy workflow is polling for status and for some reason it is erroring out in the API. We should be trapping those API errors and returning something human-readable and debuggable.

The thing causing this error to appear was fixed last month, but the fact that it would spit out this long, ugly error message was fixed in #477.


Is it possible to show overlay in cluster?

I'd like to know if it's possible to show overlays like MKCircle in cluster? Thanks.

Yes. Not in cluster but in MapView. Cluster and MKCircle both are different thing. You need to Use

func mapView(_ mapView: MKMapView, rendererFor overlay: MKOverlay) -> MKOverlayRenderer

method.
Here is sample code,
    func mapView(_ mapView: MKMapView, rendererFor overlay: MKOverlay) -> MKOverlayRenderer {
        if overlay is MKCircle {
                 let circle = MKCircleRenderer(overlay: overlay)
                 circle.strokeColor = UIColor.red
                 circle.fillColor = UIColor.red.withAlphaComponent(0.5)
                 circle.lineWidth = 1
                 return circle
             }
       else {
            guard let tileOverlay = overlay as? MKHipsterTileOverlay
                else {
                    return MKOverlayRenderer()
            }
            return MKTileOverlayRenderer(tileOverlay: tileOverlay)
        }
    }
![Screenshot 2020-01-09 at 11 53 20 AM](https://user-images.githubusercontent.com/11573422/72043133-665d4480-32d6-11ea-833e-936e41e39230.png)


Swift Package Manager support

Added SPM support for the framework. If anything needed to be changed let me know.

Looks great! Thanks you @sarathsarah

can you merge it?

I don't have that permission unfortunately.


fix: prevent extendBaseUrl recursion

🔗 Linked issue

#2034

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Fixes the recursive wrapping of nuxtI18nOptions and investigated and described here https://github.com/nuxt-modules/i18n/issues/2034#issuecomment-1855097787.
This PR https://github.com/nuxt-modules/i18n/pull/2620 by @s00d would have fixed this issue as well (credited in commit), I opted for making a copy of nuxtI18nOptions instead, to ensure the options are not mutated elsewhere by requests.
I will publish a new release after this is merged, after which I think we can close the issues related to the memory leak.

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Looking very good with my project. The main leak is gone now, only some left but I guess those are on me 😉

That's good to hear, I'll publish a release in a bit, it worries me that the latest release contains this recursion issue 😥.. I still do think there are leaks, but I haven't found a reliable way to reproduce them.


Create unique Queue subscription Policy

Create a unique Queue subscription Policy to avoid Policy limitations when having multiple messages for same Queue.

@gertjvr could you review this PR? I don't understand the policy implications.

@gertjvr and @phatboyg, let me add more information about the issue.
AWS SQS has limits in the Queue Policy (https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-limits.html#limits-policies). The ones that affect MassTransit are:

max 8,192 bytes in size
max 20 statements

MassTransit.AmazonSQSTransport uses the AWS SubscribeQueue (that calls internally SubscribeQueueToTopics) wich performs two actions:

Adds a statement to the Queue Policy for the Topic.
Creates the Subscription between the Topic and the Queue.

This is explained in this AWS SDK issue: https://github.com/aws/aws-sdk-net/issues/378.
The code of SubscribeQueue can be found here: https://github.com/aws/aws-sdk-net/blob/6c3be79bdafd5bfff1ab0bf5fec17abc66c7b516/sdk/src/Services/SimpleNotificationService/Custom/AmazonSimpleNotificationServiceClient.Extensions.cs#L84.
So using the SubscribeQueueToTopics method, the Queue can only subscribe to 20 Topics. However, the 8K bytes limit is reached before 10 Topics with the unit test created for this PR.
This PR uses code from the SubscribeQueueToTopic to add the Policy statement manually. Instead of adding one for each Topic it adds a generic one using a wildcard. From my point of view this should not affect neihter the behavior nor the security. Even we are adding a Policy to allow access to any Topic created by MassTrasint in that Host, we are only creating Subscription for the required ones.

That helps a lot, and now I understand. The policy is on the queue-side of the subscription, and configures SQS to allow messages from SNS that match that ARN (which is a wildcard in this case). The topic (SNS) still has a subscription binding to the queue, separate from the policy which allows the queue to receive the message. Got it. Thank you for explaining it!

Thanks for the extra, the change makes sense just trying to understand the security implications for the new policy.
The current policy restricts only topic with subscriptions to publish messages to a queue, where the new policy allows any topic to publish messages to any queues?

My intention in the PR is not to set a wildcard for the whole Topic ARN but only for the message name part:
var topicArnPattern = topicArn.Substring(0, topicArn.LastIndexOf('_') + 1) + "*";

@codigoespagueti I just spun up your changes and compared the policies.
I think we need to have a closer look at your topicArnPattern as I understand the topic name is based on c# {namespace}-{message type} and all . replaced with _ for example

MassTransit.TestFramework.Messages.PingMessage -> MassTransit_TestFramework_Messages-PingMessage
MassTransit.AmazonSqsTransport.Tests.Configuring_AmazonSQS.Message0 -> MassTransit_AmazonSqsTransport_Tests-Configuring_AmazonSQS_Message0

As I understand the policy any messages published from similar named assembly like MassTransit_TestFramework_Foo or MassTransit_TestFramework_Bar would also be allowed to publish to input-queue
Initial thoughts are something is incorrect with the policy, the intent was to restrict what message the queue would except based on bus topology.
I'll try and explain let's say we have message 1, message 2 and message 3 and topology setup as follow message 1 and message 2 have a consumer queue named long_multi_subs_queue and message 3 a consumer queue named input-queue', the new policy would allow both consumer queues to accept message 1, 2 or 3 the only thing restricting this is the missing topic to queue subscription`.
Comparison of the current and new policy for input-queue
Current Policy
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "69f53fed1d374b75b1cc8c4150d274e4",
      "Effect": "Allow",
      "Principal": {
        "AWS": "*"
      },
      "Action": "sqs:SendMessage",
      "Resource": "arn:aws:sqs:ap-southeast-2:134693456886:input-queue",
      "Condition": {
        "ArnLike": {
          "aws:SourceArn": "arn:aws:sns:ap-southeast-2:134693456886:MassTransit_TestFramework_Messages-PingMessage"
        }
      }
    }
  ]
}

New Policy
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "2ad3101dce584ba7bed190e718b2cff6",
      "Effect": "Allow",
      "Principal": {
        "AWS": "*"
      },
      "Action": "sqs:SendMessage",
      "Resource": "arn:aws:sqs:ap-southeast-2:134693456886:input-queue",
      "Condition": {
        "ArnLike": {
          "aws:SourceArn": "arn:aws:sns:ap-southeast-2:134693456886:MassTransit_TestFramework_*"
        }
      }
    }
  ]
}

That's fine though, right? Because the subscriptions are only going to be created for topics that are subscribed on the queue. The policy wildcard just makes it less verbose as to which message types are allowed. I think this should be fine.

In that case I would either remove the ArnLike Condition which allows everything
or
change it to var topicArnPattern = topicArn.Substring(0, topicArn.LastIndexOf(':') + 1) + "*" to restrict it the the message assembly.

@gertjvr I don't understand your last suggestion.

@codigoespagueti I would add a wildcard policy allowing any sns topic to publish to the queue, masstransit will create the topic-to-queue-subscriptions which will controls where the messages come from. Hope that makes more sense.

@gertjvr yes thanks for the clarification.

@phatboyg @gertjvr Review findings applied.

Looks good to me.

Rebased/merged.

Thanks!


[Question]: RetrieverQueryEngine with CustomRetriever and LLM other than OpenAI

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I try to set up a simple hybrid search
Like this one
https://gpt-index.readthedocs.io/en/latest/examples/query_engine/CustomRetrievers.html
I use a custom LLM
llm_predictor = LLMPredictor(llm=CustomLLM())
embed_model = LangchainEmbedding(HuggingFaceEmbeddings(model_name="T-Systems-onsite/cross-en-fr-roberta-sentence-transformer"))
service_context = ServiceContext.from_defaults(  llm_predictor=llm_predictor,  embed_model=embed_model)
And Indexes for this LLM
vector_index = VectorStoreIndex.from_documents(docs, service_context=service_context)
keyword_index = SimpleKeywordTableIndex.from_documents(docs, service_context=service_context)
I set up the query engine like this :
vector_retriever = VectorIndexRetriever(index=vector_index, similarity_top_k=4)
vector_query_engine = RetrieverQueryEngine(
retriever=vector_retriever,
response_synthesizer=refined_response_synth,
)
the reponse synthetiser use refined text_qa_template
refined_response_synth = get_response_synthesizer(text_qa_template = qa_template2, response_mode = ResponseMode.COMPACT)
vector_query_engine = RetrieverQueryEngine(
retriever=vector_retriever,
response_synthesizer=refined_response_synth,
)
When I query I have this error
response = vector_query_engine.query("Quel est le contenu de l'article 222-29?")
print (response)
AuthenticationError: No API key provided. You can set your API key in code using 'openai.api_key = ', or you can set the environment variable OPENAI_API_KEY=). If your API key is stored in a file, you can point the openai module at it with 'openai.api_key_path = '. You can generate API keys in the OpenAI web interface. See https://platform.openai.com/account/api-keys for details.
If I initialize the VectorIndexRetriever with the service_context I have the same error....

To make it easy when working at this low level, just set a global service context and don't worry about passing it in
from llama_index import set_global_service_context

set_global_service_context(service_context)


'torch_geometric.transforms' has no attribute 'ToDevice'

📚 Installation

Environment

OS: Mac 11
Python version: 3.7
PyTorch version: 1.9
CUDA/cuDNN version:
GCC version:
How did you try to install PyTorch Geometric and its extensions (wheel, source): Pip
Any other relevant information:

Checklist

[x ] I followed the installation guide.
[x] I cannot find my error message in the FAQ.
[x] I set up CUDA correctly and can compile CUDA code via nvcc.
[x] I do have multiple CUDA versions on my machine.

Additional context
Which version of argva_node_clustering do I use? The version currently on the git repo does not work with the pytorch-geometric I have installed. The argva_node_clustering from the previous commit does. Link to file https://github.com/rusty1s/pytorch_geometric/blob/master/examples/argva_node_clustering.py

Yes, some files changed in current master. You need to install from master or use an older version of the example.


More advanced favorite structuring and management

What's the Problem?
In our corporate environment we have quite a complex folder structure and managing all jump points can be really complicated. On top comes the issue that we have the same folder names within different trees (e.g. for multiple product versions we're developing).
Also many people work in different focus areas like development and project management in parallel. Depending on your current task and project you are working on, different kinds of favorites might be of relevance.

The Favorites listed in the sidebar do not provide a good out-of-the-box solution to this complex file hierarchies in corporate environments.

There is no possiblity to organize the favorites in hierarchies (nested folders) and also renaming items according to your preference is not possible leaving you with multiple favorites looking the same.

Solution/Idea
Web Browsers do a great job with favorites (aka. bookmarks):

Chrome has a bookmark bar and a bookmark manager allowing you a more complex organization of your favorites in folder hierarchies with names on folders and items according to your preference.
Firefox has a bookmark button, a bookmark bar (if enabled) and a bookmark manager allowing you a more complex organization of your favorites in folder hierarchies with names on folders and items according to your preference.
Microsoft Edge has a similar approach like Firefox.

Browsers allow you to organize bookmarks in the bookmark manager and items added to a special folder "Bookmarks Bar" will be shown within the bar. Other bookmarks can be accessed through the menu item.
This is also the solution I would love to see within Files:

A bookmark manager allowing you to organize all your favorites with a custom folder structure and renaming of items.
A Special folder in the bookmark manager for manging the favorites in the sidebar
A Special folder in the bookmark manager for managing the favorites which are shown within a newly added bookmark bar.

The bookmark bar could be only a second step, in a first step of improvement we could also foresee:

A bookmark manager for better hierarchical organization of your favorites with the option to rename them (and maybe specify icons if we want to get really fancy)
Extend the favorites sidebar to handle "bookmark folders". Here I see two possibilities:
a) Use the expander approach. A click on the bookmark folder will expand the items within the sidebar. This also can be nested. Maybe some idention for visual indication is needed.
b) Open a context menu on click listing all items in a structure there for navigation.

Alternatives
The alternative approach (which I also used as workaround in the classical file explorer) is to create locally on your disk somewhere folders where you put in your bookmarks. then from the favorites you jump into this bookmark folder and then use the right plane with the file/folder list to jump further.
While it works it has various drawbacks on usability:

the bookmark folder navigation spoils your navigation history. When jumping back and forth between two folders you always need two navigation steps.
does not provide a quick "at a glance" jumping. A bookmark bar or favorites have the benefit of very quickly jumping with one click to a desired location once you are used to the "on-screen location" of the item.

Priorities

Capability
Priority

This proposal will allow end users to manage the favorites through a new more advanced favorites manager
Must

This proposal will allow end users to modify favorite items to show a custom label
Must

This proposal will allow end users to nest favorites into hierarchies using folders which are shown as expanders or context menu in the sidebar
Must

This proposal will allow end users to display bookmarks in a bookmark bar beside the sidebar like web browser allow it
Should

This proposal will allow end users to modify favorite items to show a custom icon
Could

Files Version
Version: <IP_ADDRESS> OS Version: 10.0.19041.1237
Windows Version
Windows 10 Enterprise 2004 19041.1237
Additional comment
I tried to cover my overall vision of the favorites in one single issue but I see chances to break this feature down to smaller steps like:

Only allow renaming of favorites through context menu
Add folder support to favorites (maybe also simply through context menu on the favorites and existing favorite folders)
Add advanced favorite manager UI
Add bookmark button to access additional favorites not shown in sidebar (like Edge and Firefox)
Add bookmark bar

@Danielku1 Currently, all changes to sidebar items are actual changes to the folder, this includes changing the name and icon. Treating favorites as a bookmark can work, but it would introduce another layer of complexity as renaming an item from the sidebar would no longer reflect on the actual path and while some would prefer this behavior, many users do not.
We have a bundles feature that allows you to group folders from different directories together in a virtual folder and quickly launch them from there. Perhaps this can be an alternative to what you're trying to accomplish without adding the extra complexity of treating favorites as a bookmark with a virtual name. If this works for you, perhaps we can consider allowing users to pin bundles to the sidebar to make it easier to jump to them.

This would be the one benefit to make me switch permanently. Switching between project folders is a pain in the a**, compared to the browser bookmarks experience. New Project, new Bookmark in a dedicated bookmarks bar? Problem solved! Would be very very happy!

The next version of Files is coming with a new widget for tags. This is a great way to organize important documents and while it's not exactly what's being requested, it checks most of the boxes and I think it'll do the trick.

Still I don't know why all the file explorer communities promote the inferior favorites sidebar instead of a full customizable bookmarks bar. Do you ever use a browser, create bookmarks, bookmark folders and rename bookmarks? This is way superior to this. Imagine bookmarks in your browser worked liked favorites in file explorers you

could only see the title of the page
you couldn't edit the entry
you couldn't group them into folders

Yeah sometimes bookmarks expire. Yes they have there problems. But they work and boost productivity and safety by a huge amount.
So please consider this killer feature in a proper implementation 🙏

For point one they function the same. You see the icon and name if you hover over it you see where it goes.
For point two you can edit the entry by just pinning the folder you want there a removing the ones you don't. Renaming favourites item only is being tracked with #3422
For point three you can use tags as a favourite folder. If you just want only groups of folders you can turn the favourites section off and just use tags.

let's say it like James Franco, „same same but still different“. Just image on sec. how it would feel. A bookmarks bar is a already difficult for most end users. However most of my clients and non tech users don't customize the favorites in their file explorer but are still somewhat able to manage bookmarks in the browser. As they now the „web browser“, they might also know how to use a files browser better, if the good interface elements are somewhat similar.
Unifying the experience would be a great benefit for low tech users as well as high productivity users. It still could be optional. And I guarantee you, as soon as the techies notice the utility and availability of a bookmarks bar, the popularity of files will explode!

I bookmark bar like in the file manager "clover" would be useful. To create bookmarks, the folders or files are dragged and dropped onto the bookmarks bar. It should be possible to import and export the bookmarks to a file.

Have you tried the tags widget? The UX is a little different, but it allows you to organize folders and files under tags. You can open tags from the sidebar and there is a widget on the home page where you can view tags side by side.
We're going to continue expanding the feature set for tags and while I understand this isn't the same exact, I hope you give it a try and see if it can be part of your workflow.
I'm going to leave this discussion open because tags are still a new feature and it's hard to know if it's a suitable alternative. Additionally, if it were up to me, I'd replace the sidebar with a bookmarks bar. I did some experimentation on this a couple of months ago, but the majority of users weren't ready for such a drastic change.

@yaira2 thanks, I tried it and its like 10% of what real Bookmarks do.
Just look at the screenshot @luke-motto provided. That would be perfect 😍
As for user adoption:  just make it optional. Yet I still want to repeat: most (end) users are nowadays more familar with the browser interface. When I tell clients to open "File Explorer" most people look confused. Almost NOBODY uses the favorites functionally correctly, yet SOME use bookmarks in the browser.
I understand your argument, but it's not the "users aren't ready", they are, the we dev's aren't ready, because favorites always worked the way it worked. So I still beg you all masters of code: please reconsider. Just give it a try, you might like it. The only promise I can make, is to promote the hell out of your software, as soon as this features drops 🙏

A key difference between a file manager and web browser is the window size. Users tend to make their browsers full screen while they keep file managers in windowed mode. There are exceptions but this seems to be the case for most users.

So I suggest again, make it an optional feature and let's see how it's welcomed. I would also guess, that most end users don't download third party file explorers, while many power users would do. And those power users are the ones that benefint from bookmarks most.

ther could always be the option, to make the bookmarks bar vertical, like most browsers do nowadays.

Example:

This could be difficult to implement, especially now that we have set Favorites to automatically sync with File Explorer

Instead of having folders used for holding favourites/bookmarks - what if we had "Collections"
It would appear as a tree item, in a Favourites tree - and can include virtual links to folders.

Collections might be a good way to solve #11900 as well.

Collections might be a good way to solve #11900 as well.

"Save tabs to collection"
And then the ability to open all of the collection's folders in a new window, or tabs in the existing window.
Now this then needs us to think about if we need to have a way to show grouped tabs, if a collection is open and non-collection tabs are also open?

I must again mention that a bookmarks bar is a highly used and effective way for what we want to accomplish. As the browser is more and more in the center of the daily UX, i suggest it would be best for everyone to copy the experience into the files browser, especially the good ones.
I guess the Favorites thing is some kind of qwerty effect. Because it way always there it must be good. And I do not suggest to get rid of them, but make them more versatile. Browsers do implement vertical bookmarks bars.  Make Folders (lets call them Collections for the sake of good) where I can store Folders and posssible even Files in the same manner as in Browsers. And make the layout (horizontal/vertical) an option in the settings.
🙏

I must again mention that a bookmarks bar is a highly used and effective way for what we want to accomplish. As the browser is more and more in the center of the daily UX, i suggest it would be best for everyone to copy the experience into the files browser, especially the good ones.
I guess the Favorites thing is some kind of qwerty effect. Because it way always there it must be good. And I do not suggest to get rid of them, but make them more versatile. Browsers do implement vertical bookmarks bars.  Make Folders (lets call them Collections for the sake of good) where I can store Folders and posssible even Files in the same manner as in Browsers. And make the layout (horizontal/vertical) an option in the settings.
🙏

I appreciate your reasoning for asking for this, and like yourself I use the bookmarks/favourites bar in my browser.
The way Files' UI is designed, will lead to 4 rows of UI at the top of the window, and having both the sidebar and another level of navigation for folders, will become quite overwhelming (even if it is optional).
Finding a way to implement this kind of feature will take time, and care.

i absolutely woudn't mind a thrid main row (i guess the 4th row would be the action row in the right panel). It still would look like the same as in any commonly used browser, which has three main rows (tabs, adressbar, bookmarks bar).
Currently there is only limited space. a horizontal bookmarks bar exponentially gives users more space to easily navigate. Folders in a horizontal bookmarks bar can moreover be expanded without layout shift, which is hugely distracting.
However, though not as convenient as a "bookmarks bar", it would still be a huge improvement, if the favorites panel could have "folders/collection" functionality. Just look as @DennisGaida example.
And again my example: I have multiple clients and all of those folders have the same naming convention. While I can create separate folders per client in my browser and make a "collection of all relevant websites for this client project".
Whereas in my file explorer, I may would like to "pin" the "image" folders of each client to my favorites. But all have the same name, there is no way to differenciate. Oh could I just "rename" my favorites  and/or create collections. But then it's the same functionality as a bookmarks bar and my personal preference is horizontal for those.
Although if you really disagree, please at least add the functionality to the vertical favorites 🙏🙏🙏

It has not been decided on if this will be added and functionality hasn't been discussed.

While not exactly the same as a bookmarks bar, #11900 will address some of the use cases.

I still don't get the resistance. I truly believe the "favorites" are simply the way they are, because Microsoft decided so and because of lack of competition, it still behaves the way it behaved decades ago.
I only want to ask one thing: Imagine the browser did not have a bookmark bar, how bad would it be? Nobody would use a browser without a bookmark bar. Nobody.
It is really hard to beleive, that "workspaces", while welcome, are implemented and a booksmark bar is not. Workspaces are definitley a "confusing pro/heavy user feature", while even novice users know how to use bookmarks. Well, I guess I give up my hopes. Farewell :(

@ptmrio please tone down the rhetoric, we haven't made a decision on either feature. I was simply pointing out that there is another feature request that will cover some of the same use cases.


Fix CI by bumping versions of google libs

Problem seen in multiple CI failures including https://github.com/pypa/warehouse/pull/9247/checks?check_run_id=2433386938

    ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    Collecting google-api-core<2.0.0dev,>=1.21.0
        google-api-core<2.0.0dev,>=1.21.0 from files.pythonhosted.org/packages/b3/fe/e127cd00d018efb1b026dd4a55c62b6b53de3dcc94b54530d1ef5bcad335/google_api_core-1.26.3-py2.py3-none-any.whl#sha256=099762d4b4018cd536bcf85136bf337957da438807572db52f21dc61251be089 (from google-cloud-core==1.6.0->-r requirements/main.txt (line 280))
    Error: Process completed with exit code 1.

Reproduced by taking a clean venv and launching pip install -r requirements.txt
Tried lauching pip-compile but it didn't change anything
Solved by manually removing google libs from main.txt, and only then running pip-compile --allow-unsafe --generate-hashes --output-file=requirements/main.txt requirements/main.in

Here's the changelog for impacted libs:

https://github.com/googleapis/python-api-core/releases
https://github.com/googleapis/google-auth-library-python/releases
https://github.com/googleapis/python-bigquery/releases
https://github.com/googleapis/python-storage/releases
https://github.com/grpc/grpc/releases

There doesn't seem to be advertised breaking changes.

Thank you @ewjoachim!

Thank you !


Add an example with short tutorial

Adding an example with a tutorial on how to use the library. This could be in the form of a .ipynb notebook (or myst file, i.e. more readable as a .md file but executable as a Jupyter notebook). This would definitely help the user to find out what the library can do.
This could be linked in the readme

Done with #16


Cannot resolve symbol 'applyDecorators'  Validate ES6 imports

I was trying to use autobind decorator. It's Babel 6 without .babelrc file. So I am unable to use decorator legacy plugin. Anyway this code below works with a warning.
import { applyDecorators } from "core-decorators"
Why? Warning is: Cannot resolve symbol 'applyDecorators'  Validate ES6 imports
I am using: "core-decorators": "0.20.0".

Sorry for the delay, making my way through a huge backlog. I'm not sure why that happens. Does any of the other imports work? If you're using the ESM build it seems to be exported correctly<EMAIL_ADDRESS>

I am using it with Create-React-APP. It complains always in Webstorm about
applyDecorators. Also, I don't see that in exported list either.
Thanks for replying.
On Wed, May 9, 2018 at 7:48 PM, Jay Phelps<EMAIL_ADDRESS>wrote:

Sorry for the delay, making my way through a huge backlog. I'm not sure
why that happens. Does any of the other imports work? If you're using the
ESM build it seems to be exported correctly: https://unpkg.com/core-
<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jayphelps/core-decorators/issues/149#issuecomment-387820374,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUiPu6msByUSfGH9CjM9pgGqPDKTz1ks5twyv_gaJpZM4Skjz4
.

--
ROBIN
+46738741993
https://wwwsajjadrobin.com https://www.sajjadrobin.com

I don't see that in exported list either.

Can you clarify? it shows up here<EMAIL_ADDRESS>

I’ll check my npm package and version number also. I’ll update
On Wed, 9 May 2018 at 21:51, Jay Phelps<EMAIL_ADDRESS>wrote:

I don't see that in exported list either.
Can you clarify? it shows up here:
<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jayphelps/core-decorators/issues/149#issuecomment-387855193,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUiEYZPJMNIc1vr-OApGPhb03wcl-8ks5tw0ivgaJpZM4Skjz4
.

--
ROBIN
+46738741993
https://wwwsajjadrobin.com https://www.sajjadrobin.com

Hi Jay,
I am using version 20 also. Is applyDecorator exported from
https://github.com/jayphelps/core-decorators/blob/master/index.d.ts like
<EMAIL_ADDRESS>?
On Wed, May 9, 2018 at 10:03 PM, Md Sajjad Robin<EMAIL_ADDRESS>wrote:

I’ll check my npm package and version number also. I’ll update
On Wed, 9 May 2018 at 21:51, Jay Phelps<EMAIL_ADDRESS>wrote:

I don't see that in exported list either.
Can you clarify? it shows up here: https://unpkg.com/core-
<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jayphelps/core-decorators/issues/149#issuecomment-387855193,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUiEYZPJMNIc1vr-OApGPhb03wcl-8ks5tw0ivgaJpZM4Skjz4
.

--
ROBIN
+46738741993
https://wwwsajjadrobin.com https://www.sajjadrobin.com

--
ROBIN
+46738741993
https://wwwsajjadrobin.com https://www.sajjadrobin.com


Prefix for terraform

Hi!
First of all, this repository is great and can be help me. Today I work into in project shared into my company, and to create a new resource ever need declare an team prefix, however the autoscaler don't provide this into your terraform configs.
So, would it be possible to provide an prefix variable for terraform? If the answer is yes, I can pull this implementation and send a PR.

Hi Bernardo,
we discussed about your suggestion, and want to understand your use case better.
Would it be possible for you to have separate projects instead of using a prefix to differentiate between resources within the same project?
Having one project per application per environment is one of Google's recommendations in our best practices for enterprise organizations.
We are a bit worried that adding a prefix means possibly copy pasting the same snippet over and over throughout all the resources in the Autoscaler, or coming up with some other way of generating the resource names with a prefix.

Hi @davidcueva!

Would it be possible for you to have separate projects instead of using a prefix to differentiate between resources within the same project?

It's possible. I will communicate with an infrastructure team to provide a new project for Autoescaler.

We are a bit worried that adding a prefix means possibly copy pasting the same snippet over and over throughout all the resources in the Autoscaler, or coming up with some other way of adding the prefix to the resource names.

My first approach was to include the field to define the prefix in the terraform. I agree to separate projects

Awesome ! Thanks Bernardo.
Since you are looking into having separate projects I will close this issue for now, but feel free to reopen if you run into issues.


Support all GEORADIUS Commands

Description
Covers:

GEORADIUS
GEORADIUSBYMEMBER
GEORADIUSBYMEMBER_RO
GEORADIUS_RO

closes #1952

Checklist

[x] Does npm test pass with this change (including linting)?
[X] Is the new or changed code fully tested?
[X] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Codecov Report

Merging #2017 (a0aaec1) into master (ac7d50c) will decrease coverage by 2.93%.
The diff coverage is 96.19%.

:exclamation: Current head a0aaec1 differs from pull request most recent head 89d87d4. Consider uploading reports for the commit 89d87d4 to get more accurate results

@@            Coverage Diff             @@
##           master    #2017      +/-   ##
==========================================
- Coverage   94.94%   92.00%   -2.94%
==========================================
  Files         358      369      +11
  Lines        3343     3441      +98
  Branches      409      414       +5
==========================================
- Hits         3174     3166       -8
- Misses         85      187     +102
- Partials       84       88       +4

Impacted Files
Coverage Δ

packages/client/lib/commands/BITFIELD.ts
100.00% <ø> (ø)

packages/client/lib/commands/LMOVE.ts
66.66% <ø> (-33.34%)
:arrow_down:

packages/client/lib/commands/SORT.ts
100.00% <ø> (ø)

packages/client/lib/commands/BITFIELD_RO.ts
42.85% <42.85%> (ø)

packages/client/lib/client/commands-queue.ts
76.47% <100.00%> (-3.80%)
:arrow_down:

packages/client/lib/cluster/commands.ts
100.00% <100.00%> (ø)

packages/client/lib/commands/DUMP.ts
100.00% <100.00%> (ø)

packages/client/lib/commands/GEOADD.ts
100.00% <100.00%> (ø)

packages/client/lib/commands/GEORADIUS.ts
100.00% <100.00%> (ø)

packages/client/lib/commands/GEORADIUSBYMEMBER.ts
100.00% <100.00%> (ø)

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7d50c...89d87d4. Read the comment docs.


Fix typo in fibonacci snippet

Fix typo in fibonacci snippet
Description
Change apoend to append  in documentation/description.
What does your PR belong to?

[ ] Website
[x] Snippets
[ ] General / Things regarding the repository (like CI Integration)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (non-breaking improvement of a snippet)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have checked that the changes are working properly
[x] I have checked that there isn't any PR doing the same
[x] I have read the CONTRIBUTING document.

Thanks for the fix, merging right away!


Android virtual controller

Please add virtual joystick and virtual controller for Android device and script with .gd extension

@Harsh-Malakar  You can easily integrate Virtual Joystick
https://github.com/MarcoFazioRandom/Virtual-Joystick-Godot


Feature/binary

This PR solved #150
Because unleash-api now automatically checks and migrates the database on startup we don't have to confuse the user with setting up their own migrations.
Using the binary is now as simple as:
$ npm install unleash-server -g
$ unleash -d postgres://unleash_user:passord@localhost:5432/unleash -p 4242

Unleash started on port:4242

/cc @sveisvei

wfm! 👍

fixed. Whats really nice is that it should be fairly easy to add new hooks later, e.g. an option to disable db-migration, allow user to only do migrations and so on..

Merge it like its hot 💯


chore: remove variables

#17715

Wow, this is nice! Choose the name you prefer.
bors d+

Bors merge


Custom status feature

Summary

Add types and actions to set and unset custom status.

Hello @chetanyakan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Hello @chetanyakan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


[Backport release-23.11] #273048

Backport failed for release-23.11, because it was unable to cherry-pick the commit(s).
Please cherry-pick the changes locally and resolve any conflicts.
git fetch origin release-23.11
git worktree add -d .worktree/backport-273048-to-release-23.11 origin/release-23.11
cd .worktree/backport-273048-to-release-23.11
git switch --create backport-273048-to-release-23.11
git cherry-pick -x<PHONE_NUMBER>09a7d564c159983f3bb4a51aed1ea3 7c97d5f5c441cce6ad717a85676eec7c7ff1b27e

Originally posted by @github-actions[bot] in https://github.com/NixOS/nixpkgs/issues/273048#issuecomment-1850858620

This was also incorporated into https://github.com/NixOS/nixpkgs/pull/273040 xD

Tracked by #273040.


updated dependencies for FreeBSD

Hi there,
I updated the install script for the dependencies to support FreeBSD.
Cheers,
tpltnt

Thank you!


Model does not grow on HAM minimal media

Description of the issue:
I am trying to grow the model with the "ham" minimal media
The metabolites I was given of the Ham MM are:
arginine
histidine
lysine
methionine
phenylalanine
tryptophan
tyrosine
alanine
glycine
serine
threonine
aspartate
glutamate
asparagine
glutamine
isoleucine
leucine
proline
valine
cysteine
thiamin
hypoxanthine
folate
biotin
pantothenate
choline
inositol
nicotinamide
pyridoxine
riboflavin
thymidine
aquacob(III)alamin
lipoic acid
glucose
sulfate
linoleate
linolenate
O2
H2O
retinoate
Fe2+
Pi
alpha-tocopherol
gamma-tocopherol
converting them to exchange reactions in my model the list is:
R_EX_HMR_9455,D-arginine_C6H15N4O2=-50.0
R_EX_HMR_9038,histidine_C6H9N3O2=-50.0
R_EX_HMR_9041,lysine_C6H15N2O2=-50.0
R_EX_HMR_9042,methionine_C5H11NO2S=-50.0
R_EX_HMR_9043,phenylalanine_C9H11NO2=-50.0
R_EX_HMR_9045,tryptophan_C11H12N2O2=-50.0
R_EX_HMR_9064,tyrosine_C9H11NO3=-50.0
R_EX_HMR_9061,alanine_C3H7NO2=-50.0
R_EX_HMR_9067,glycine_C2H5NO2=-50.0
R_EX_HMR_9069,serine_C3H7NO3=-50.0
R_EX_HMR_9044,threonine_C4H9NO3=-50.0
R_EX_HMR_9070,aspartate_C4H6NO4=-50.0
R_EX_HMR_9071,glutamate_C5H8NO4=-50.0
R_EX_HMR_9062,asparagine_C4H8N2O3=-50.0
R_EX_HMR_9063,glutamine_C5H10N2O3=-50.0
R_EX_HMR_9039,isoleucine_C6H13NO2=-50.0
R_EX_HMR_9040,leucine_C6H13NO2=-50.0
R_EX_HMR_9394,D-proline_C5H9NO2=-50.0
R_EX_HMR_9046,valine_C5H11NO2=-50.0
R_EX_HMR_9065,cysteine_C3H7NO2S=-50.0
R_EX_HMR_9159,thiamin_C12H17N4OS=-50.0
R_EX_HMR_9358,hypoxanthine_C5H4N4O=-50.0
R_EX_HMR_9146,folate_C19H18N7O6=-50.0
R_EX_HMR_9109,biotin_C10H15N2O3S=-50.0
R_EX_HMR_9145,pantothenate_C9H16NO5=-50.0
R_EX_HMR_9083,choline_C5H14NO=-50.0
R_EX_HMR_9361,inositol_C6H12O6=-50.0
R_EX_HMR_9378,nicotinamide_C6H6N2O=-50.0
R_EX_HMR_9144,pyridoxine_C8H11NO3=-50.0
R_EX_HMR_9143,riboflavin_C17H20N4O6=-50.0
R_EX_HMR_9423,thymidine_C10H14N2O5=-50.0
R_EX_HMR_9269,aquacob(III)alamin_C62H90CoN13O15P=-50.0
R_EX_HMR_9167,lipoic acid_C8H13O2S2=-50.0
R_EX_HMR_9034,glucose_C6H12O6=-50.0
R_EX_HMR_9074,sulfate_O4S=-50.0
R_EX_HMR_9033,NEFA blood pool in_CHO2R=-50.0
R_EX_HMR_9035,linoleate_C18H31O2=-50.0
R_EX_HMR_9036,linolenate_C18H29O2=-50.0
R_EX_HMR_9048,O2_O2=-50.0
R_EX_HMR_9047,H2O_H2O=-50.0
R_EX_HMR_9404,retinoate_C20H27O2=-50.0
R_EX_HMR_9076,Fe2+_Fe=-50.0
R_EX_HMR_9072,Pi_HO4P=-50.0
R_EX_HMR_9151,alpha-tocopherol_C29H50O2=-50.0
R_EX_HMR_9153,gamma-tocopherol_C28H48O2=-50.0
However when trying to grow the model on this media I have zero biomass.
Do I have a mistake, as some of the metabolites are taken in the D-  format.
Thanks
Raphy

Hi @raphyz, thanks for posting the issue.
Here is the list of metabolite IDs and names corresponding to those in Ham's media as defined in the Human-GEM metabolic task list, as well as their corresponding exchange reaction that should be opened to enable biomass flux.

mets
metNames
rxns
rxnEqns

m01365s
arginine
HMR_9066
arginine[s] <=>

m02125s
histidine
HMR_9038
histidine[s] <=>

m02426s
lysine
HMR_9041
lysine[s] <=>

m02471s
methionine
HMR_9042
methionine[s] <=>

m02724s
phenylalanine
HMR_9043
phenylalanine[s] <=>

m03089s
tryptophan
HMR_9045
tryptophan[s] <=>

m03101s
tyrosine
HMR_9064
tyrosine[s] <=>

m01307s
alanine
HMR_9061
alanine[s] <=>

m01986s
glycine
HMR_9067
glycine[s] <=>

m02896s
serine
HMR_9069
serine[s] <=>

m02993s
threonine
HMR_9044
threonine[s] <=>

m01370s
aspartate
HMR_9070
aspartate[s] <=>

m01974s
glutamate
HMR_9071
glutamate[s] <=>

m01369s
asparagine
HMR_9062
asparagine[s] <=>

m01975s
glutamine
HMR_9063
glutamine[s] <=>

m02184s
isoleucine
HMR_9039
isoleucine[s] <=>

m02360s
leucine
HMR_9040
leucine[s] <=>

m02770s
proline
HMR_9068
proline[s] <=>

m03135s
valine
HMR_9046
valine[s] <=>

m01628s
cysteine
HMR_9065
cysteine[s] <=>

m02982s
thiamin
HMR_9159
thiamin[s] <=>

m02159s
hypoxanthine
HMR_9358
hypoxanthine[s] <=>

m01830s
folate
HMR_9146
folate[s] <=>

m01401s
biotin
HMR_9109
biotin[s] <=>

m02680s
pantothenate
HMR_9145
pantothenate[s] <=>

m01513s
choline
HMR_9083
choline[s] <=>

m02171s
inositol
HMR_9361
inositol[s] <=>

m02583s
nicotinamide
HMR_9378
nicotinamide[s] <=>

m02817s
pyridoxine
HMR_9144
pyridoxine[s] <=>

m02842s
riboflavin
HMR_9143
riboflavin[s] <=>

m02996s
thymidine
HMR_9423
thymidine[s] <=>

m01361s
aquacob(III)alamin
HMR_9269
aquacob(III)alamin[s] <=>

m02394s
lipoic acid
HMR_9167
lipoic acid[s] <=>

m01965s
glucose
HMR_9034
glucose[s] <=>

m02946s
sulfate
HMR_9074
sulfate[s] <=>

m02387s
linoleate
HMR_9035
linoleate[s] <=>

m02389s
linolenate
HMR_9036
linolenate[s] <=>

m02630s
O2
HMR_9048
O2[s] <=>

m02040s
H2O
HMR_9047
H2O[s] <=>

m02833s
retinoate
HMR_9404
retinoate[s] <=>

m01821s
Fe2+
HMR_9076
Fe2+[s] <=>

m02751s
Pi
HMR_9072
Pi[s] <=>

m01327s
alpha-tocopherol
HMR_9151
alpha-tocopherol[s] <=>

m01935s
gamma-tocopherol
HMR_9153
gamma-tocopherol[s] <=>

Also, make sure that you are using the most recent version of the model (1.4.0), otherwise you may have boundary metabolites that will need to be removed prior to performing flux simulations.

@raphyz Can you verify if the list of reactions above, when opened, enable biomass production?

I am closing this issue since there has been no activity in some time, but feel free to re-open it if necessary.


Set up PSR standard and test environment

I happened to come across it by chance, and because I liked the concept, I decided to review it and ended up submitting a pull request.

Support composer
Support PSR-12
Support phpunit testing
Fix some formatting errors
Configure GitHub Actions to test and format
Adhere to the PHPDoc standards

Thank you very much for your interest in the PHP mapper. I have reviewed all of your commit. I really appreciate your contributions in helping to provide a more convenient way of usage for those who need this idea. I will also strive to put in more effort moving forward.


[Feature request] Array variables

In Make, one can do something like val := ent1 ent2 ent3 ..., which Make will interpret as an array. Can we have something similar to it that'll also be compatible with variadic recipes and functions?
Bonus point for "post setting",  eg
var := initial
# yada yada
var += additions

I'd like this, but currently just only has string-valued variables, which makes things very simple, since you don't need to know the types of anything, and it's always guaranteed to be a string. We can't use += for arrays, because + is already the concatenation operator. Also, justfiles are order independent, so append can't work like that, since there's no sequential order to what's in a justfile.
I would like to have a general solution to this though. We already have * and + args, which are pretty hacky. One approach would be to make everything a list of strings, ala rc.

How about considering add dictionary type variables?

I opened #2458 to track the possibility of making all values lists of strings.


Fix setup

Based on what I can see the additions that already existed come from black rectifying the code right?
setup.py seems good to me

Yeah black and isort. I'll get these in a pre-commit hook soon.

The pre-commit hook would be sweet - looks good.
merging the PR


dist/debian:add python3 as dependency

In https://github.com/scylladb/scylladb/pull/11440 we will start building Scylla docker images based on Ubuntu:22.04, adding python3 as a dependency since python package is not available anymore

The patch looks good, but does Python3 actually work for the current Scylla tools, especially cqlsh?

it looks like cqlsh require python2.7 to be installed. updated https://github.com/scylladb/scylladb/pull/11440

The patch looks good, but does Python3 actually work for the current Scylla tools, especially cqlsh?

it looks like cqlsh require python2.7 to be installed. updated scylladb/scylladb#11440

So I don't understand - is this PR still correct?

The patch looks good, but does Python3 actually work for the current Scylla tools, especially cqlsh?

it looks like cqlsh require python2.7 to be installed. updated scylladb/scylladb#11440

So I don't understand - is this PR still correct?

yes, it is.

But this change suggests that "python3" is enough, while it isn't: cqlsh, part of scylla-tools-java - can't (currently...) run on python3.
Or maybe the python thing is only used to build scylla-tools-java, and doesn't say anything about what is required to run it?

But this change suggests that "python3" is enough, while it isn't: cqlsh, part of scylla-tools-java - can't (currently...) run on python3. Or maybe the python thing is only used to build scylla-tools-java, and doesn't say anything about what is required to run it?

@nyh you are correct , it's only related to the build section

@yaronkaikov @nyh this need to be yanked out, cqlsh doesn't support python3, and cause of this change our AMIs now don't have python2, and cqlsh fails !!!!

@yaronkaikov @nyh this need to be yanked out, cqlsh doesn't support python3, and cause of this change our AMIs now don't have python2, and cqlsh fails !!!!

FYI, see https://github.com/scylladb/scylladb/issues/11435 for more place we notice there's no more python2.
but we can't break it like that, not until we'll have the replacement for the old cqlsh code in place.

I mentioned this above, but @yaronkaikov "promised" me above that it only affects the build, not the runtime in the AMI.
The patch is already in so please submit a new patch to fix it. I'm not sure if the new patch should be to scylla-tools-java (adding python2 back), or to the AMI (which needs python2 to run stuff - not to build it).

FYI, see scylladb/scylladb#11435 for more place we notice there's no more python2.

Isn't this a separate (and somewhat opposite) problem - i.e., it's a system where Python2 isn't available at all, so we can't ask to install Python2 even if we wanted to?

FYI, see scylladb/scylladb#11435 for more place we notice there's no more python2.

Isn't this a separate (and somewhat opposite) problem - i.e., it's a system where Python2 isn't available at all, so we can't ask to install Python2 even if we wanted to?

it's all boils to the same issue, our cqlsh code isn't ready to be used with python3, if a distro version doesn't have python2 anymore, we first need to address the issue with cqlsh, and only after that we can move to those distro versions.
anyhow the OR here isn't correct, the tools doesn't need python3 (at least not right now), we have a relocatable python3 that we probably should be using once we cqlsh work for python3.
I think that meanwhile the whole move to ubuntu 22.04, need to be retracted, until we have this sorted out.

I mentioned this above, but @yaronkaikov "promised" me above that it only affects the build, not the runtime in the AMI.
The patch is already in so please submit a new patch to fix it. I'm not sure if the new patch should be to scylla-tools-java (adding python2 back), or to the AMI (which needs python2 to run stuff - not to build it).

@nyh My mistake :-1: , please revert this patch

@yaronkaikov it seems like everyone wants me to do it, so I can, but this is not the proper process: A "git revert" isn't a dequeue - it's a real patch (undoing the previous one), and it should come with a real commit message explaining why the revert was done, and review from people who know what the heck this patch means. I thought the original patch was wrong, but I didn't know enough to resist it, and unfortunately I didn't. I would have liked someone who does know enough about the context of this patch to review this revert.
BUT, all that being said, this time I'll revert it myself. Next time please consider just doing reverts as a normal PR.

@yaronkaikov it seems like everyone wants me to do it, so I can, but this is not the proper process: A "git revert" isn't a dequeue - it's a real patch (undoing the previous one), and it should come with a real commit message explaining why the revert was done, and review from people who know what the heck this patch means. I thought the original patch was wrong, but I didn't know enough to resist it, and unfortunately I didn't. I would have liked someone who does know enough about the context of this patch to review this revert.
BUT, all that being said, this time I'll revert it myself. Next time please consider just doing reverts as a normal PR.

@nyh Thanks, and sorry for the mess, next time i will just do the revert

Reverted.


command idea's

/tpto teleports to the block you are lookin at
/heal
/feed
/skin (takes a skin from the web)
/nick, /unnick
/alias (checks for possibile alt accounts using ip adresses)

Thanks, will be added to my To Do's for this Plugin.

Added /nick, /unick, /account (/alias), /heal, /feed, /tpto and /skin will not be added yet.


TF_CONFIG cluster spec has wrong FQDN name

v1alpha2 seems to introduce TF_CONFIG cluster spec with FQDNs:
     TF_CONFIG:                {"cluster":{"master":["mnist4555-master-0.kubeflow.svc.cluster.local:2222"],"ps":["mnist4555-ps-0.kubeflow.svc.cluster.local:2222"],"worker":["mnist4555-worker-0.kubeflow.svc.cluster.local:2222","mnist4555-worker-1.kubeflow.svc.cluster.local:2222"]},"task":{"type":"worker","index":0}}

This is problematic because we use a different cluster-domain (and not 'cluster.local') and so after upgrading to kubeflow 0.2.2, workers got stuck in "CreateSession still waiting for response from worker"
I've dug through the code in the operator and can't find anything wrong at a glance: https://github.com/kubeflow/tf-operator/blob/bb430c980ad03b187a5de607dc12503250ec8200/pkg/controller.v2/tfcontroller/controller_tensorflow.go#L116

I think we are using the service name instead of the FQDN

Thanks for the response.
So I won't expect "mnist4555-worker-0.kubeflow.svc.cluster.local" to be in
the cluster spec in this case. I expect the TF_CONFIG to have
"mnist4555-worker-0"
which is my service name.
Can anyone help explain why/how my service name is getting expanded to the
full FQDN when it ends up in the TF_CONFIG? This is breaking all the
distributed tensorflow jobs.
On Sun, Aug 5, 2018 at 12:40 AM, Ce Gao<EMAIL_ADDRESS>wrote:

I think we are using the service name instead of the FQDN
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/770#issuecomment-410502169,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPagvcjwS1ehTcoNjogTEC1sG42jdks5uNqGBgaJpZM4VvPL4
.

@jlewi
Do we cherry pick the commit in 0.2?
https://github.com/kubeflow/tf-operator/commit/a5a5f49f2a9f3a783301c0df38727b938c3bbc3c

@ashahab
Maybe you could have a try on master. We have a commit to fix your issue here: https://github.com/kubeflow/tf-operator/commit/a5a5f49f2a9f3a783301c0df38727b938c3bbc3c

Thanks I'll try.
On Sun, Aug 5, 2018, 8:48 AM Ce Gao<EMAIL_ADDRESS>wrote:

@ashahab https://github.com/ashahab
Maybe you could have a try on master. We have a commit to fix your issue
here: a5a5f49
https://github.com/kubeflow/tf-operator/commit/a5a5f49f2a9f3a783301c0df38727b938c3bbc3c
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/770#issuecomment-410528892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPfq62NpCj9rnmjkmAW1D22wpcH78ks5uNxO9gaJpZM4VvPL4
.

Is there a tf-operator image from master or an easy way to generate one?
On Sun, Aug 5, 2018 at 9:55 AM, Abin Shahab<EMAIL_ADDRESS>wrote:

Thanks I'll try.
On Sun, Aug 5, 2018, 8:48 AM Ce Gao<EMAIL_ADDRESS>wrote:

@ashahab https://github.com/ashahab
Maybe you could have a try on master. We have a commit to fix your issue
here: a5a5f49
https://github.com/kubeflow/tf-operator/commit/a5a5f49f2a9f3a783301c0df38727b938c3bbc3c
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/770#issuecomment-410528892,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPfq62NpCj9rnmjkmAW1D22wpcH78ks5uNxO9gaJpZM4VvPL4
.

You can check the available tag by querying https://gcr.io/v2/kubeflow-images-public/tf_operator/tags/list.

Thanks so much for all the quick help(this community is great!).
I assume v20180724-13863edf would be a tag with the patch merged?
On Mon, Aug 6, 2018 at 1:46 AM, cheyang<EMAIL_ADDRESS>wrote:

You can check the available tag by querying https://gcr.io/v2/kubeflow-
images-public/tf_operator/tags/list.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubeflow/tf-operator/issues/770#issuecomment-410634567,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAqJPXGfmgoNJmrDzStyl8CKwTtKGULJks5uOAJcgaJpZM4VvPL4
.

Yes it looks like that commit should include the fix
https://github.com/kubeflow/tf-operator/blob/13863edf7ccf6a2786457f098a9fc115c097d14b/pkg/controller.v2/controller_tensorflow.go#L106


Updated roadmap

Had to create a new branch with the changes, as there was an issue with the current branch.  Please look at this one instead - https://github.com/alphagov/pay-product-page/pull/694


Anonymous error message when hosting twitchbot locally but not on Glitch

Hello, I followed a tutorial for writing a twitchbot using tmi.js and have the bot up and running - currently hosted on Glitch.com. I wanted to break away from the restrictions fo the site and host it locally. It appears it is due to an anonymous message being sent, despite the user details being supplies from an external .env file (to avoid putting the OAuth token in the JS file).
Actual behaviour:
When keyword is using that bot should reply to I get: (node:6568) UnhandledPromiseRejectionWarning: Cannot send anonymous messages.
This occurs inside of the client.js _sendMessage function prototype (line 1196 of client.js). This error does not occur when hosted on Glitch.
Expected behaviour:
Expected the same behavior as Glitch where it successfully retrieves user details from .env file and sends a message with credentials (not anonymously).
Error log:
(node:6568) UnhandledPromiseRejectionWarning: Cannot send anonymous messages.
warning.js:32
(node:6568) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
warning.js:32
(node:6568) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Server configuration

Operating system: Win10
Express version: 4.17.1
tmi.js version: 1.5.0

Which Node version are you using? I think it broke i Node 14.

Additional information, Outdated and Deprecated Dependency:
https://www.npmjs.com/package/request


Choose custom title for graph nodes

The current implementation does not allow to change the node's title. It will always display their id.
In parse_dataframe.py, we already fill in a column title if not already present. This column should be used to label the nodes.

Hey @claudius-kienle thanks for the PR.
Just wanted to understand the requirements here - as you can set the custom node title by changing the id details.

Hey @imohitmayank,
I have a use case, where I want to show titles for the nodes that are different than their IDs. Working with the IDs would require to update the edge list too.
Additionally the IDs must be unique but in my case the title I want to show is not unique, so using the IDs as titles would not have worked.
I think it is a good idea to seperate the node's I'd from its title.

Hey @claudius-kienle thanks for the PR. This feature should be available from the new version [v0.1.7](https://pypi.org/project/jaal/)
Let me know in case of any issue.

Thanks for integrating the change so quickly!

Hello!
As a result, constant showing labels and pop-up titles of nodes are the same.
How can I make them different?
Really want to show short names and full information in pop-up
Thanks


Support for --webpack-stats-json

Hey everyone! First of all, thanks for this nice plugin!
I was wondering if I would still be able to output a stats file by using it, as I currently do with Webpack, by running storybook build --webpack-stats-json.
Is that supported?

Yes, --webpack-stats-json is superseded by --stats-json in Storybook. We already support stats. Here's a screencap of the example in this repository.
pnpm build:storybook --stats-json

Have a try.

Sorry, I didn't realize that the stats support wasn't on a release version before. I just released a new version, have a try.


Workshop Mod Compatibility

Overview
This PR introduces the ability to load ApeSphere at the same time as ApeSphere-Custom. The project has also been renamed SMB2PracticeMod. The sister PR for Apesphere-Custom (renamed SMB2WorkshopMod) can be found here.
Changes
The primary changes on the Practice Mod side are:

Hook REL loader one instruction after Workshop Mod's rel loader hook, so it always loads after Workshop Mod (if it's loaded)
If Workshop Mod is loaded, the Practice Mod rel loader allocates space for the REL and BSS from Workshop Mod's heap instead of from main_loop.rel's relocation data
Hook the Practice Mod tick() function one instructions after Workshop Mod's
patch::hook_function() can hook a function more than once, chaining the hooks together. This is useful when Workshop Mod and Practice Mod need to hook the same function.

Testing
I tested all Practice Mod features while Workshop Mod was loaded with all patches enabled. Some Workshop Mod patches still need to be tested themselves however.
TODO

Update documentation
Coordinated release with Workshop Mod

The workshop mod PR has been merged so I'm merging this now. Will make a new release once a workshop mod release is made.


Adaptive Template SDK Exception Class

Description
Added AdaptiveTemplateException Class.
How Verified

All unit tests are ran and passed.
Added a new unit test for testing invalid test case.

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


Minor grammar correction

Every object is defined by two things - first, it's → its geometry [...] and second, its attributes [...].

Thank's for that @M1dgard

No problem :)


docs should mention limitation of sbert

Hi,
I encounter time and time again people disappointed by the effectiveness of the sentence-transformers models. Usually the reason being that the models have very short "max sequence length" (the default model is 256) and everything after that is silently clipped.
GIven that this happens silently, I think most people are not aware of that. And the multilingual models have even shorted length!
I brought that up several times here on langchain and there too.
So I think it would be good to mention this in the README.md.
And if anyone is down for writing a simple wrapper that does a rolling average/maxpooling/whateverpooling of the input instead of clipping it that would be awesome! That would be a workaround that can't possibly be worse than just clipping the input right?
Cheers and llm is great!
(related to https://github.com/simonw/llm/issues/220)

Thanks, that's a good tip - I've added it to the "usage" section.

I'm sharing my own 'rolling' sbert script to avoid clipping the sentences. It's seemingly functionnal but not very elegent, a class would be better of course but I just hope it helps someone :
from sentence_transformers import SentenceTransformer

model = SentenceTransformer("all-mpnet-base-v2")

# sbert silently crops any token above the max_seq_length,
# so we do a windowing embedding then sum. The normalization happens
# afterwards.
def encode_sentences(sentences):
    n = model.max_seq_length  # max length supported by the model
    n23 = (n * 2) // 3  # overlap each 2/3 of n

    add_sent = []  # split long sentences go there
    add_sent_idx = []  # indices to keep track of sub sentences

    # check the length of each sentence
    for i, s in enumerate(sentences):
        # skip if the sentence is short enough
        length = len(model.tokenizer.encode(s))
        if length <= n:
            continue

        # otherwise, split the sentence at regular interval
        # then do the embedding of each
        # and finally add those sub embeddings together
        sub_sentences = []
        j = 1
        while length >= n23 * j:
            sub_sentences.append(s[n23 * j: n23 * j + n])
            j += 1

        # remove empty text just in case
        if "" in sub_sentences:
            while "" in sub_sentences:
                sub_sentences.remove("")
        add_sent.extend(sub_sentences)
        add_sent_idx.extend([i] * len(sub_sentences))

    # sanity check that sentences contains only valid lengths
    assert sum([
            len(model.tokenizer.encode(s)) > model.max_seq_length
            for s in sentences + add_sent
            ]) == 0, (
            "Some sentences are too long for the "
            "transformer and are cropped. The rolling average "
            "failed apparently.")

    # note that normalization is turned off, the idea is to avoid cascading
    # approximations by summing normalized embeddings and instead normalize
    # at the end
    vectors = cached_encoder(
            sentences=sentences + add_sent,
            show_progress_bar=True,
            output_value="sentence_embedding",
            convert_to_numpy=True,
            normalize_embeddings=False,
            )

    if add_sent:  # reconstitute the vector
        # at the position of the original sentence (not split)
        # add the vectors of the corresponding sub_sentence
        # then return only the 'summed' section
        assert len(add_sent) == len(add_sent_idx), (
            "Invalid add_sent length")
        offset = len(sentences)
        for sid in list(set(add_sent_idx)):
            id_range = [i for i, j in enumerate(add_sent_idx) if j == sid]
            add_sent_vec = vectors[
                    offset + min(id_range): offset + max(id_range),:]
            vectors[sid] += add_sent_vec.sum(axis=0)
        return vectors[:offset]
    else:
        return vectors

I like the idea - but how well does it work?

@thiswillbeyourgithub
I like the idea of that "rolling window".
Is it the way to do it, or is it just to have an alternative to clipping i.e how well does it work?

Keep in mind that my implementation is pretty naive and can certainly be vastly optimized but the idea is there. An implementation for langchain can be found here. A nonlangchain implementation in a code I'm using regularly can be found here
I don't know if I have found by chance the way but probably not. In my example I did a maxpooling but I could have done a meanpooling instead. That also brings about the question of L1 vs L2 if doing a normalization. Also one can think about having an exponential decay of the importance of each new token of text etc.
In my experience: Maxpooling or meanpooling seem to work fine.
In my opinion: Any kind of rolling window seems in theory vastly superior to silently cropping and the difference between each windowing method is probably negligeable compared to cropping.
More tests would be needed with proper metrics to find out which is best and if the enhancement is not just placebo that degrade results.


Nisse Engström: Watch komalshrma.com

Nisse Engström requests the watch of the watch_keyword komalshrma\.com. See the Metasmoke search here and the Stack Exchange search here.

komalshrma\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Coverage remained the same at 65.732% when pulling ae24ce2a81af9d49001be18815ef0ebdeb036cfb on auto-blacklist-1527846547.1635227 into 62dea0e4a56591a5fb693b618cc491d0e12d2bf5 on master.

!!/approve


WIP [CLOUD-1384] Add openshift.io/display-name and description annota…

…tions to all templates
openshift.io/discription is copied from the description annotation. The script I ran cleaned up some of the spacing inconsistencies too(Is that okay?). Let me know what you think and what needs to be changed

I think "openshift.io/description" is redundant. Openshift already takes the "description" field into consideration (tested in web console for 3.3 and 3.4).
Also, IMO, the display-name could be more elaborated WRT abbreviations. For example:
A-MQ62 (Basic) → A-MQ 6.2 (Basic) or Red Hat JBoss A-MQ 6.2 (Basic)
Datagrid65 (MySQL) → Data Grid 6.5 (Using MySQL) or Red Hat JBoss DataGrid 6.5 (Using MySQL)
...

Similar to @jwendell's comments.  We should be using the product names (e.g. Red Hat JBoss A-MQ 6.2) and the description field is just "description".  The templates in the origin repository have some additional annotations (not yet released), which include template.openshift.io/long-description.  Also, CLOUD-1384 only refers to the display-name field.  All of the annotation changes required are described in CLOUD-1381 and openshift.io/description (or template.openshift.io/long-description) is not on that list.  I appreciate your enthusiasm though.

Thanks for the feedback,  I have updated the files based on the comments. Let me know how it looks and if anything else needs to be changed

Wait hold one second on that I forgot one thing....adding now

Alright, changes made, now it is ready for your eyes again

Dang, you have sharp eyes, I can't believe I missed those!

LGTM, except maybe, for this minor phrasing:
Product (Using <Database> Persistent) → Product (Using Persistent <Database>)
(here the database is mounted upon a persistent volume, so, we can say the database is persistent; or that we are using a persistent database)
You native English spoken guys may have a better feeling than I though.

I agree that this should be changed, what if we did something like:
Product (Using  Persistent) → Product (Using  With Persistent Volume)
Would that be ok too?
This way we would also clarify that products without a database have a persistent volume:
Product (Persistent) → Product (With Persistent Volume)
That is, if users are not sure what "(Persistent)" means. If they already know, this option could make things more verbose and confusing. Maybe I am over thinking this. Let me know what you think. I can change it easily either way.

It's difficult to say what's perfect.  I think we should maybe use the following strategy:
Red Hat JBoss EAP 6.4 (Basic, no https) - the basic templates
Red Hat JBoss EAP 6.4 - the complete templates (i.e. https)
Red Hat JBoss EAP 6.4 (plus MySQL persistent)
Red Hat JBoss EAP 6.4 (plus MySQL ephemeral)
Something like that.  We should get clarification on the exact name to use for EAP and should follow the scheme used by the other templates (e.g. the MySQL template).  By separating out "basic" instead of https, we highlight that basic is special, since all the other templates support https.

Tweaked the names a bit, rebased and pushed.


KAFKA-9780: Deprecate commit records without record metadata

NOTE: Requires a new KIP.
Since KIP-382 (MirrorMaker 2.0) a new method commitRecord was included in SourceTask class to be called by the worker adding a new parameter with the record metadata. The old commitRecord method is called from the new one and it's preserved just for backwards compatibility.
The idea is to deprecate this method so that we could remove it in a future release.
KIP related here.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ok to test

Still waiting for final approval of https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata

Green builds on JDK 11 and 8, and unrelated failure on JDK 14.


[applysite] Add new methods that ease insertion of code after FullApplySites

Specifically:

I renamed the method insertAfter -> insertAfterInvocation and added an
ehaustive switch to ensure that we properly update this code if we add new apply
sites.

I added a new method insertAfterFullEvaluation that is like
insertAfterInvocation except that the callback is called with insertion points
after the end/abort apply instead of after the initial invocation of the
begin_apply.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci smoke test and merge