Spark example fails in Databricks with the latest build (0.1.4-b6)

Summary
I am failing to run the spark demo from the examples in Databricks.
Steps to Reproduce it

Set up the cluster with the runtime version 8.1 (includes Apache Spark 3.1.1, Scala 2.12)
Add the whylogs libraries:

ai.whylabs:whylogs-java-spark_3.1.1-scala_2.12:0.1.4-b6
ai.whylabs:whylogs-java-core:0.1.4-b6

Try running the example in the scala notebook.

Example
export.csv is the file exported from the example:
%scala
import java.time.LocalDateTime

import org.apache.spark.sql.functions._
import org.apache.spark.sql.{SaveMode, SparkSession}
import com.whylogs.spark.WhyLogs._

val path = "/FileStore/sasha/export.csv"
val raw_df = spark.read
    .option("header", "true")
    .csv(path)

val df = raw_df.withColumn("call_date", to_timestamp(col("Call Date"), "MM/dd/YYYY"))

val profiles = df
    .newProfilingSession("FireDepartment") // start a new WhyLogs profiling job
    .withTimeColumn("call_date") // split dataset by call_date
    .groupBy("City", "Priority") // tag and group the data with categorical information
    .aggProfiles() //  runs the aggregation. returns a dataframe of <timestamp, datasetProfile> entries

profiles.write
    .mode(SaveMode.Overwrite)
    .parquet("profiles_parquet")

What is the current bug behavior?
Generating a profile fails with
Caused by: NoClassDefFoundError: Could not initialize class com.whylogs.core.message.DatasetProperties$TagsDefaultEntryHolder

What is the expected correct behavior?
The examples should just work.
Relevant logs and/or screenshots
See the full logs.

Did it work on a previous version ?
Trying whylogs for the first time.

I believe this is because Spark comes with an older version of Protobuf, which is a core dependency for whylogs.
I think we need to build a shadowJar with protobuf shaded rather than pulling it as a runtime dependency.
Can @aptlin try using the snapshot bundle instead (we haven't published the bundle to the main maven yet):
https://oss.sonatype.org/content/repositories/snapshots/ai/whylabs/whylogs-spark-bundle_3.1.1-scala_2.12/0.1-21aeb7b2-SNAPSHOT/
You can download the jar directly here if you don't want to bother setting up the Snapshot dependency: https://oss.sonatype.org/content/repositories/snapshots/ai/whylabs/whylogs-spark-bundle_3.1.1-scala_2.12/0.1-21aeb7b2-SNAPSHOT/whylogs-spark-bundle_3.1.1-scala_2.12-0.1-21aeb7b2-20210903.224257-1-all.jar

I verified the jar Andy references with a Databricks (version 8.3) cluster, some notes on versions used and an updated example that also uploads the profiles to Whylabs is posted here: https://github.com/whylabs/whylogs-examples/blob/mainline/scala/src/main/scala/WhyLogsScalaLendingClubToWhylabsExample.scala#L2-L4


Korean translation

Hello. I'd like to translate this tutorial for my school assignment. Can I simply translate a few things?

You don't have to merge..

Hello,
You can do what you want with these Notebooks, but you should remember to say where you have the original code from.
Some of the Notebooks you are working on are outdated, number 3 on Pretty Tensor and number 3B on the Layers API.
I am hosting the Chinese translation in my own github account, because the original translator suddenly disappeared and I didn't have permission to change the repo, when another translator wanted to continue the work.
https://github.com/Hvass-Labs/TensorFlow-Tutorials-Chinese
I'm not going to merge your pull request. But if you make a github repository in your own account with the Korean translation and name it TensorFlow-Tutorials-Korean, then I can take a look and add a link to the README if the quality looks good. I don't think there's any need to host it in my own github account.


Introduce keyboard shortcut for Clear buffer command

Description of the new feature/enhancement
Introduce a default keyboard shortcut, such as Control + Shift + K, for the Clear buffer command to ease keyboard users clearing the buffer.

Thanks for filing! This is a good idea, we don't remember why we didn't do that haha.
We're thinking about changing this action to "Clear and reset" (and adding a reset action for when someone plays around with win32 input mode).


feat: Overwrite the simpleExtensions especially the markdown config

Describe the feature you'd like to request
I am trying to modify the config in the markdown under the simpleExtensions. I am planning to make transformCopiedText as false. Is there any way I can do it? Thankss in advance
Describe the solution you'd like to see
It is better if we can overwrite the extensions in simpleExtensions just like the rest of extensions.
Additional information
No response

I think you can do it like this, a agree actualitythis is not the best way to do this, but it working expected for me :)
// sure you have tiptap-markdown installed in you project
import { Markdown } from "tiptap-markdown";

import { simpleExtensions as novelSimpleExtensions } from "novel/extensions";

const markdown = Markdown.configure({
  // your config
});

// remove markdown extension from simpleExtensions array
export const simpleExtensions = novelSimpleExtensions.filter(
  (ext) => ext.name !== "markdown"
);

// export your custom config of markdown extension and another extensions
export const defaultExtensions = [
   // rest of extension
   markdown,
   ...simpleExtensions
]

Thanks for the solution. Yeah, this could be the workaround. Let me try it out. Thanks.

did it work for you @saculNiot ? No luck here


plyr (fast-forward / rewind)

Hi, :)
can you please guide me how would i go on about adding fast-forward and rewind buttons to the component? i have been trying for a few hours and of no luck, i cant seem to be able to access plyr's base functions through component.

Plyr is there:  kutr/resources/assets/js/services/playback.js
Adding buttons is straightforward, you'll need to react on click by triggering the action on the plyr instance.
The playback service will catch the action and deal with it to the action you want to do.
So basically, you'll do:

Add fastForward() method to playback that's calling the fast forward method of the plyr instance (via document.querySelector('.plyr').fastForward() ?? I don't know,  you'll need to look into plyr's documentation)
In the component/site-footer/index.vue, you'll add your button in the HTML part
In the javascript code below, you'll add a method fastForward() { return playback.fastForward() }

This suppose you had a button that, when clicked, advance the playing time by a fixed amount. I'm pretty sure such behavior is useless, and likely, a seek function would be better. But that's another question, I guess.

:) got it working, thanks!


Possible to show multiple colours for different titles of pagingviewcontroller?

Hello, Is it possible to show different colours for multiple tabs of paging view controller?

Yes, this is definitely possible!
The implementation depends a bit on what you are trying to achieve. If you can base the color on the index of the item you can just create a custom menu cell subclass like this:
class CustomPagingCell: PagingTitleCell {
  override func setPagingItem(_ pagingItem: PagingItem, selected: Bool, options: PagingOptions) {
    super.setPagingItem(pagingItem, selected: selected, options: options)

    if let item = pagingItem as? PagingIndexItem {
      switch item.index {
      case 0:
        contentView.backgroundColor = .red
      case 1:
        contentView.backgroundColor = .blue
      case 2:
        contentView.backgroundColor = .green
      default:
        contentView.backgroundColor = .white
      }
    }
  }
}

...

let pagingViewController = FixedPagingViewController(viewControllers: viewControllers)
pagingViewController.menuItemClass = CustomPagingCell.self

Another approach is to create a custom PagingItem that will hold the color for each menu items. Then you have to use PagingViewController directly, and have to setup your own data source using PagingViewControllerDataSource. You can take a look at the UnplashExample on how to achieve that. Let me know if you are stuck and I can provide an example implementation for that as well 🙂

Closing this for now, but feel free to open if you have any more questions 🙂

Hey @rechsteiner, is this still possible? I can't seem to find menuItemClass. I don't exactly have to use this but I need a way to make certain items stand out to the user as I'm using this for a form


Generate protobuf files for all services

To support Dependabot and make it easier to do development on the demo, we will be pre-generating the protobuf definitions for each service. The proto files have not been updated in over a year, and we do not expect these definitions to receive further updates, barring a major change in the demo.
This issue is meant to track the progress of this effort across each service, grouped by language.

.NET

[ ] accounting
[ ] cart

C++

[ ] currency

Go

[ ] checkout
[ ] product catalog

Java

[ ] ad

JavaScript

[ ] payment

Kotlin

[ ] fraud detection

PHP

[ ] quote

Python

[ ] recommendation

Ruby

[ ] email

Rust

[ ] shipping

TypeScript

[ ] frontend

Go and Python should be marked off as completed.


Shematic bugs fixed, PCB connections made

Closes #50

Please read document of the branch name standart.


Fixed visiblity issue for close, minimize, and maximize in light mode.

Fixed visiblity issue for close, minimize, and maximize in light mode.

Wow, nice work. Has this been tested to fix the problem when the user changes the theme to differ from the System theme? If so, LGTM

I noticed the same thing happens with the Dark theme, when system is set to Light mode. Would this PR fix that too?

In my testing it did.

Well, in that case...


Fixed: Typo in docs/getting_started.md

Summary: depencies should read dependencies

@facebook-github-bot Just signed the CLA. (but it's a bit much for fixing a typo, don't you think?)


added Firefox OS

please check my PR

I added this lib https://www.npmjs.com/package/open

you will need to add the dependency to package.json also.

any update about it?

this PR is generating conflict with some files....


[tabs-extended] disabled tab labels style regression in Canary vs RC

original Slack discussion
disabled tabs appear to have a regression in Canary vs RC since the text color differs
Canary

RC

disabled vertical tabs also don't seem to be correct as reported by @ariellalgilmore on Slack

Moving to To be Triaged pipeline.  Design decision needed.

This is an issue. Disabled text is expected to be: $disabled-02


[Core]Support product function for agg table

Purpose
Support product function for agg table

Tests

API and Format

Documentation

Flink CDC Tests of CI failed. It doesn't seem to be the cause of the code and needs to be rerun.


[NIFI-9690] Display icon on Connection Label to show when head of the queue is penalized

Description of PR
Displays a new icon on Connection Label to show when head of the queue is penalized
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for the PR @koccs! Since the flowFileAvailability is part of the connection status we'll need to make a few updates here.

Thanks for the review @mcgilman, I was not aware of the property hierarchy. I have updated my solution, please check it again.

Thanks @koccs! +1 This has been merged to main.


feat(multisig): create keys on-the-fly

Generate multisig keys on-the-fly during Sign instead of using the kv-store to maintain keys after Keygen.

a couple tweaks

added recommendations at a single commit


Add Probot: OOO

Probot: OOO allows you to respond with an auto-responder when you are out of office (OOO).
E.g.
Use the /ooo slash command to let everyone know when you will be OOO:

While are enjoying your OOO, probot-ooo will respond on your behalf to anyone who mentions you, with an out of office reply:

Merging this even though CI is failing (for unrelated things) because this app is cool and deserves to be shared 🎉


Absence of timeout for endless rebuffering

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.19
v2.5.10
Can you reproduce the issue with our latest release version?
N/A
Can you reproduce the issue with the latest code from master?
N/A
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Universal Windows Platform (Windows 10)
Microsoft Edge v18.19041
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; Xbox; Xbox One; MSAppHost/3.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.19041
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Xbox One
What are the manifest and license server URIs?
All of our content is using DASH but we are unable to share the manifests due to client confidentiality.
What did you do?
Unable to provide steps to reproduce. See the What actually happened? section for a description of the problem.
What did you expect to happen?
If a video is stuck in a rebuffering state for many hours or days, we expect that the Shaka Player will timeout and produce an error or buffering state change event.
What actually happened?
We have received a sampling of Mux data from October 2020 through February 2021 for a variety of videos that start playback normally and, without viewer interaction, we see a single start buffering event occurs that results in many hours (e.g., 10 hours) or even multiple days of buffering before an end buffering event occurs (there are no other events recorded during this window of time). The data we have shows that the start buffering event can occur at any portion of the video. We have data for videos under 30 mins and videos that are longer than 1-2 hours. We also have data showing this issue occurring with both DRM (PlayReady) and non-DRM content.
In our custom app, we listen for the Shaka Player error and buffering events and they do not appear to fire during the endless rebuffering period. We are wondering why the Shaka Player does not timeout or error when playback does not recover after a long period of time.
We have been digging into this issue for a few weeks and have not been able to reproduce the behavior on our testing devices. We'd like to start a discussion to learn more about the Shaka Player's expected behavior as it relates to endless rebuffering and timeouts to find out if this is a bug or not.
A portion of our Shaka Player configuration:
"drm": {
    "retryParameters": {
        "backoffFactor": 2,
        "baseDelay": 400,
        "fuzzFactor": 0,
        "maxAttempts": 4,
        "timeout": 10000
    }
},
"manifest": {
    "retryParameters": {
        "backoffFactor": 2,
        "baseDelay": 400,
        "fuzzFactor": 0,
        "maxAttempts": 4,
        "timeout": 10000
    }
}
"streaming": {
    "bufferBehind": 30,
    "bufferingGoal": 10,
    "jumpLargeGaps": false,
    "smallGapLimit": 6,
    "rebufferingGoal": 2,
    "retryParameters": {
        "backoffFactor": 2,
        "baseDelay": 400,
        "fuzzFactor": 0,
        "maxAttempts": 4,
        "timeout": 10000
    }
}

We have been digging into this issue for a few weeks and have not been able to reproduce the behavior on our testing devices.

If you can't reproduce it, and you can't share content, and you can't share repro steps, then it will be very hard to help you solve this issue.

What version of Shaka Player are you using?
v2.5.19

What browser and OS are you using?
Universal Windows Platform (Windows 10)
Microsoft Edge v18.19041
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; Xbox; Xbox One; MSAppHost/3.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.19041

We only just built test automation for Xbox One in our lab, so up until v3.0.8/v2.5.20, we can't guarantee that anything is necessarily working on Xbox One.

We'd like to start a discussion to learn more about the Shaka Player's expected behavior as it relates to endless rebuffering and timeouts to find out if this is a bug or not.

Since your segment requests have a timeout configured, I would guess that your requests aren't failing.  But somehow, the buffering state never ends.
The logic for buffering currently looks like this:

If we're buffering, the state ends when we have rebufferingGoal seconds of content buffered ahead, or if we have buffered to the end of the presentation.
If we're not buffering, we enter a rebuffering state when the buffered content reaches rebufferingGoal / 2 or 0.5 seconds, whichever is smaller.

I think the most likely loopholes could be the calculations of "buffered to the end" and "buffered ahead".
If there is a gap in the media timeline, you may not have anything "buffered ahead" of your immediate playhead position.  The utility method shaka.media.TimeRangesUtils.bufferedAheadOf appears to account for gaps, though, and I confirmed that this utility is being used to feed information to shaka.media.BufferingObserver.
The calculation of "buffered to the end" for MediaSource-based playback is in Player's isBufferedToEndMS_ private method.  You're buffered to the end if:

video.ended is true
OR this.mediaSourceEngine_.ended() is true, meaning the final segment has been appended for video, audio, and text
OR for live content, if we've buffered up to or past the calculated live edge

So, questions for you:

When these infinite buffering events occur, is the content live or VOD?  (If live, we should dive deeper into some other details)
Do the affected users have subtitles enabled when this occurs?  (If so, this could be #2957, which was just fixed this week)

Also, is this a buffering event from the Player or are you using other events (like waiting) from the video element?  If the latter, we may be stalled behind a gap.  You can listen for the largegap event from the Player or set the streaming.jumpLargeGaps config to true to have us jump these automatically.

Thanks for the help guys. Much appreciated! I know there are no guarantees since we are unable to reproduce or share specific content. Please see below for the answers to your questions.

Stream Type: VoD
Segment Size: 4-6 seconds
Subtitles On/Off: We have data on this issue for videos with and without subtitles
buffering event source: We are only using the Shaka Player buffering event
Manifest minBufferingTime: 6-7 seconds

If it's VOD, that eliminates any of the special cases for live.  If it happens with and without subs, then that eliminates any of the special cases around text.
You could try setting streaming.jumpLargeGaps to true, or you could try a newer build (v2.5.20 or the latest cherry-picks in the v2.5.x branch).  You could also try the v3.0.x releases.
I'm not sure what else to suggest without a way to reproduce the issue.  We have an automation framework for Xbox One in our lab now, so if you can provide content URLs and any guesses about how to trigger the issue, we could try to help you out that way.
Incidentally, what percentage of your users/playbacks are affected by this?  Is it common?

We do not have enough data to calculate a percentage but it is definitely not common. We are going to continue looking into this on our end with the information you have provided and will try to reproduce it.

Closing due to inactivity. If you need to reopen this issue, just put @shaka-bot reopen in a comment. Thanks!


Add combine PRs workflow

Description

https://www.hrvey.com/blog/combine-dependabot-prs

Superseded by #18


Cannot download file 478232_intl_x64_zip.exe

Start-CcDownload is having an issue.
When trying to download fix 478232_intl_x64_zip.exe this point to URL https://go.microsoft.com/fwlink/?LinkId=852532
This URL points to:
https://hotfixv4.microsoft.com/Windows 8.1/Windows Server 2012 R2/sp1/Fix514814/9600/free/478232_intl_x64_zip.exe which is invalid due to DNS misconfiguration. This DNS name "hotfixv4.microsoft.com" points to <IP_ADDRESS> which is a Broadcast IP, invalid to any connectivity. Whitout this File you can not advance in deployment of CCE. Can you please give any workaround?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f8755fc-851d-7fca-4bb6-02b8b6713d4f
Version Independent ID: 070aa207-eb18-1c13-c9b8-59723359123f
Content: Prepare your Cloud Connector appliance
Content Source: Skype/SfbServer/skype-for-business-hybrid-solutions/plan-your-phone-system-cloud-pbx-solution/prepare-your-cloud-connector-appliance.md
Product: skype-for-business-itpro
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Hi Everyone,
Yes, it was an Issue with the Microsoft network. After some time, they fixed it. So now the link is working fine, but in any case, I upload the required file to my OneDrive. So if anyone is having the same issue, must download this file and put it in the .\SiteDirectory\Bits\KB2982006 folder
https://1drv.ms/f/s!AhRW9EpDcfF5gbh1LhcmpzpVy1lX1g
best regards,
Javier


Site deployment

I've just updated something. How can I get it deployed?
@jasononeil @ncannasse @back2dos @nadako @andyli

There are also some undeployed fixes like #212, #59, #221, #236 and probably more. I would like the deployment process to be at least documented, or better yet, somehow automated.

I'm willing to work on the automation once I've haxelib server access (I don't have yet).

A reminder that for #221 we need a cache clear in ufront in case that's not automatic when deploying.

For the API, you will have to replace the index.n in /api/3.0 or something. For the site, I don't know.

There's some deploy.json file, but i don't know how it's used.

Somewhat related to deployment: #56

@jasononeil has been taking care of the deployment. Jason, could you get in touch with Andy so he can get access?

I've just deployed a new version. Please check if everything is working correctly.
I'll config Travis to auto deploy, but we should have good test coverage first to prevent careless commits annoying the whole haxe community.

Maybe it would make sense to only deploy if the commit message contains some special instruction like [ci-deploy].

Or use the master/development branches system.

@nadako @ibilon Good ideas!
I will use master/development branches as it is similar to the haxe repo.

Nice!

Done ;)


Add a 'best practices' section to the Snapshot Testing Guide

Fixes #5812
cc: @thymikee @SimenB
Summary
As explained in the issue referenced above (opened by @thymikee), Jest's Snapshot Testing Guide could benefit from some clearer usage guidelines.
The issue's wording specifically called out adding content that would help devs avoid common mistakes and misuses of snapshot testing. After giving the page a good read it seemed like the guide already had the nucleus of this content with the "Tests Should Be Deterministic" section.
Added some content that closely follows the recommendations outlined in the @kentcdodds's article Effective Snapshot Testing referenced in the issue, then grouped this and the existing "Tests Should Be Deterministic" section under a "Best Practices" heading.
Moved the note about snapshots not being automatically written on CI into the FAQ section, since it seemed more like an FYI than part of the guide's core content.
This is just a first-pass, so feedback is warmly welcomed! 😄
Test plan
N/A (this is an isolated docs change)

I think this is great, thanks! Here's a recommendation for a third item:
3. Use descriptive snapshot names
Always strive to use descriptive test and/or snapshot names for snapshots. The best names describe the expected snapshot content. This makes it easier for reviewers to verify the snapshots during review, and for anyone to know whether or not an outdated snapshot is the correct behavior before updating.
For example, compare:
exports[`<UserName /> should handle some test case`] = `null`;

exports[`<UserName /> should handle some other test case`] = `

  Alan Turing

`;

To:
exports[`<UserName /> should render null`] = `null`;

exports[`<UserName /> should render Alan Turing`] = `

  Alan Turing

`;

Since the later describes exactly what's expected in the output, it's easy to see when it's wrong:
exports[`<UserName /> should render null`] = `

  Alan Turing

`;

exports[`<UserName /> should render Alan Turing`] = `null`

I linted the markdown for you 👌

Codecov Report

Merging #6101 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6101   +/-   ##
======================================
  Coverage    64.1%   64.1%
======================================
  Files         217     217
  Lines        8335    8335
  Branches        4       4
======================================
  Hits         5343    5343
  Misses       2991    2991
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c75933...6469cd6. Read the comment docs.

Can somebody make the changes @SimenB asked for?

Thanks @trustyknave!

@SimenB, PR submitted - no need to do 22.4 specifically as the snapshot doc is inheriting from 22.3


Pass on all split filter golden tests.

With this we get:
Finished in 25.01 milliseconds
974 examples, 0 failures, 0 errors, 384 pending

The CI needs a fix.. it's failing installing crystal.


Reading inital pin state switches it to high

Hello,
I'm trying to make a project crash proof if node fails. When the project starts I want to read the state of pins to see if they were set low, however the default init script I've found online defaults all the pins being read to HIGH. Is there a bug somewheres?
Reading on app start. This sets all the pins to HIGH even if one of them is LOW.
for(var i = 0; i < 4; i++)
{

  var input = new gpio.DigitalInput({
    pin : 'P1-' + pins[i]
  });
  //_state[i] =
  console.log(TAG + input.read());

}

This works great but I can't
  for(var i = 0; i < 4; i++)
  {

    var output = new gpio.DigitalOutput('P1-' + pins[i]);

    if(state[i])
      output.write(gpio.HIGH);
    else
      output.write(gpio.LOW);

  }

P1-0, P1-1, and P1-2` are not valid GPIO pins, so that's probably why you're seeing strange behavior. Can you try your code with only valid GPIO pins, as listed here?

That's just they key used in the array. The actual pins are [16,18,13,15]

Not sure if this is a but but I've noticed you can't use this to do very good signal processing of sensors. I have a temp/humity sensor and have to use Python because the Node version doesn't seem to be able to keep up with the singal. Still a great library and works well for solid state use of the pins.

That's just they key used in the array. The actual pins are [16,18,13,15]

Ah, I see, makes sense then. I'm out of ideas then, you're code should work, assuming your circuit is wired with pull up/down resistors correctly. You can see where we initialize the value to the current pin value: https://github.com/nebrius/raspi-gpio/blob/master/src/index.ts#L143.
I realized though, you are setting the pin to input mode, reading that value, and then setting it to output. This won't read the previous value set in a previous run when the pin was in output mode, because as soon as you set it to input mode, the previous written value is lost.

Not sure if this is a but but I've noticed you can't use this to do very good signal processing of sensors. I have a temp/humity sensor and have to use Python because the Node version doesn't seem to be able to keep up with the singal. Still a great library and works well for solid state use of the pins.

Interesting. The bindings to C++ are about as thin as possible, and this library really isn't much more than exposing Wiring Pi's C bindings to JavaScript, but maybe the marshalling/unmarshalling that V8 does is just too slow?
That said, if I were worried about throughput, I'd use Wiring Pi and C directly, not even Python, much less Node.

Closing due to inactivity. Feel free to reopen if this is still an issue.


[Feature] Ability to specify timeout when building image

Building some image could end up taking a long time. We should expect users to modify timeout on local file and push to codebuild.
Solution: Add a timeout option to enable user to pass in timeout intended

this is now supported


Is there an issue with nesting providers?

I have two apps:

A field or set of fields that can be edited in place
A table that displays rows of data.

We want to allow the rows of data to be edited in place.  The store shape for a set of fields is different than that of the report, and I'm not sure how I could combine the stores.  What I have now that seems to work is nested providers.  One provider wraps the table.  When a cell in my table is rendered in an editable state, I wrap the field in a form.  The form transforms the state from the table to a new state that that it passes to a new provider that wraps the fields.  One reason for doing this is that my fields are used in other parts of my app.  I am basically taking functionality for editing a few fields and rolling it into the table to update its data.
I understand combining reducers and one store per app.  But I'm not sure how two combine these two apps that feel very different.  Also, when data in the form's store is being updated, it seems wrong to have all the components in the table subscribe to updates to the form data when it has no effect.
Is this terrible?
Note - I'm new to react, redux, and jsx.

If you use more than one store in an app (which in most cases we don’t suggest), don’t use <Provider> for nested stores. I would suggest passing store as a prop to any connected components explicitly.

If I combine the stores, I worry that any update to the form data will cause all the cells to update.  I have three questions.

If I use the connect method, when the store's data changes - does the mapStateToProps method check if any of the props given were changed before triggering the render on the component?
If so, can I have some props populated by mapStateToProps and some populated the standard way by the parent component?
And finally, will the check done because of mapStateToProps hinder updates caused by the parent passing new props to the component.  Meaning if only a standard props changes, will the component still re-render?

I'm sorry for all the questions.  We just started down this path and in my design I'm trying to think ahead to how everything will come together and how performance maybe impacted.  Thanks for taking the time to answer and make these libraries.

If I use the connect method, when the store's data changes - does the mapStateToProps method check if any of the props given were changed before triggering the render on the component?

Yes. A connect-ed component is only re-rendered when any of the mapped props are changed.

If so, can I have some props populated by mapStateToProps and some populated the standard way by the parent component?

Sure. Both props passed from a parent and props from the connect() method are merged together into the component’s props.

And finally, will the check done because of mapStateToProps hinder updates caused by the parent passing new props to the component. Meaning if only a standard props changes, will the component still re-render?

Yes. A component re-renders when either props from connect(), props from a parent, or the component state is updated.

^^^ these answers are correct, thanks @iamakulov for answering!

If you use more than one store in an app (which in most cases we don’t suggest), don’t use  for nested stores. I would suggest passing store as a prop to any connected components explicitly.

What is the problem with nested Provider? Since all the Provider does it to set children context then when children of the inner provider will get the context from that Provider and not from the parent Provider


cartesian - when using group_by and stack, x-axis gets extended

just make sure xaxis's data are strings, not numbers


Flat Pattern sketch

I see that you are creating a sketch to figure out the flat pattern area.  Would it be possible to delete this after the program finishes as the more times I run the batch program the more sketches I get and it really dirties up the file.

Where is the sketch being created? I'm not seeing a new sketch on either the part or flat pattern.

It was in the flat pattern... but it's all good now that you fixed it so we could use project geometry as construction lines
Get Outlook for Androidhttps://aka.ms/ghei36

From: FlyingGardenGnomeStudios<EMAIL_ADDRESS>Sent: Tuesday, February 19, 2019 3:33:41 PM
To: FlyingGardenGnomeStudios/Inventor-Batch-Program
Cc: Myles240; Author
Subject: Re: [FlyingGardenGnomeStudios/Inventor-Batch-Program] Flat Pattern sketch (#15)
Where is the sketch being created? I'm not seeing a new sketch on either the part or flat pattern.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/FlyingGardenGnomeStudios/Inventor-Batch-Program/issues/15#issuecomment-465338714, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ArdyoXLiRYB0RR-7yUvZYkeCKb_FOo2Yks5vPHvFgaJpZM4a2e1v.


Unknown Fields

I've run into a situation where I'm trying to decode a buffer created in Python that includes unknown fields.
The Python data looks suspicious because it seems to have duplicate tag numbers. Here's the protoscope output from two examples:
I can parse this one:
1: 100
2: {
  1: {"identifier"}
  2: {
    14:SGROUP
    13: 101
    13:EGROUP
    13:EGROUP
    14:SGROUP
  }
  3: {"rpo"}
  4: {
    "https://www.example.com"
    "1234567890"
  }
  5: {"checksum"}
  6: 1
  7: 241532
}

This one fails:
1: 100
2: {
  1: {"identifier"}
  2: {
    14:SGROUP
    13: 101
    13:EGROUP
    13:EGROUP
    14:SGROUP
  }
  3: {"rpo"}
  4: {
    "https://www.example.com"
    "1234567890"
  }
  5: {"checksum"}
  6: 1
  7: 257372
}
1: {"enum_identifier"}     # <-- This is an UnknownField on the Python side

In the second example, you'll notice the duplicate tag number of 1. Based on the .proto definition, tag 1 should be an enum, which 100 properly resolved to. The second 1 however is a mystery to me. It appears to be an object with a string that matches an enum value, but it should be an integer. The dart parser goes off the rails when it encounters this message.
If I call DiscardUnknownFields on the Python side I can read that serialized message, as the duplicate tag is removed.
Ultimately, I'm unsure if this is an issue with how Dart handles this unknown field or how Python serializes it's unknown field. Unfortunately, I don't have access to the Python side which generates the data so I'm in a tough spot.

public class Hello1
{
   public static void Main()
   {
-      System.Console.WriteLine("Hello, World!");
+      System.Console.WriteLine("Rock all night long!");
   }
}

A more specific approach that only changes optional enum field handling.
      case PbFieldType._OPTIONAL_ENUM:
+        if (fs._hasField(tagNumber)) {
+          fs._ensureUnknownFields().mergeFieldFromBuffer(tag, input);
+        } else {
          final rawValue = input.readEnum();
          final value = meta._decodeEnum(tagNumber, registry, rawValue);
          if (value == null) {
            final unknown = fs._ensureUnknownFields();
            unknown.mergeVarintField(tagNumber, Int64(rawValue));
          } else {
            fs._setFieldUnchecked(meta, fi, value);
          }
+        }
        break;

Could you share the encoded message, version of the Dart protobuf you're using, and the error message?
I tried to come up with a repro myself but failed. Unknown fields are already assumed to be repeated so you can have a tag for an unknown field multiple times in a message it's handled fine. If you could share your repro that would make debugging easier.

I'm using protobuf 3.1.0.
The error I'm seeing is:
try {
  ei.ConfigResponse.fromBuffer(bytes);
} catch (e) {
  print('error: $e'); // InvalidProtocolBufferException: Protocol message end-group tag did not match expected tag.
}

Zip file with raw message and proto definition: message.zip
The field in question starts at byte 32737, if that's helpful at all. For the time being, I manually change the byte to give it a different tag value.

Thanks. I can reproduce the bug with the zip file, but the input is huge so it's still not easy to debug.
What's the name of the message (in the proto definitions you shared in the zip file) you use in the text protos in your original message?
Your fixes are not correct, they break existing tests.
Since you seem to have a minimal reproducer already (as you shared in your original message) if you could share it with us with all the involved files this should take a few minutes to debug.

The text protos you show in your original message seem to be malformed, they have end groups without matching starts:
  2: {
    14:SGROUP
    13: 101
    13:EGROUP <--------- here
    13:EGROUP <--------- and here
    14:SGROUP
  }

So perhaps this is not a bug in this library.

Yes apologies for the size of the message, but it's the only example I have unfortunately. Not surprised my "fixes" break other things, was just hoping they may provide some context on what the underlying issue is.
The name of the message I use to decode the message is ConfigResponse from the provided proto definition. I referenced it in this comment.

The name of the message I use to decode the message is ConfigResponse from the provided proto definition

By "the message" do you mean the text proto messages in your first message, or the message in the zip?
The text messages in your first message are not valid (as explained in my previous comment) so it's not surprising that they don't decode.
Are you able to decode your message with any protobuf implementation other than this library? (maybe in an implementation in another language, e.g. C++ or Java implementations in https://github.com/protocolbuffers/protobuf/)

Sorry, re-reading my previous message and realizing it's super confusing.
By message, I mean the binary file I included in the zip file. The protobuf type is ConfigResponse from the included proto definition file.
The examples in my first comment were excerpts from the protoscope output generated from this message. I understand what you're saying though about how they don't appear to be valid. Which is a bit confusing to me since I am able to decode the message when I manually change the appropriate byte to change the tag number of the field in question.
Hopefully this is a little clearer.
The only other language I've tried is Python, which not surprisingly succeeds probably because it was used to generate the message. I can give it a go in scala or java but don't have time at the moment.

@osa1 I am using grpc java and protocol buffer can't decode generated message from java as well. At first I got DATA_LOSS which never happend. I tested a bunch and server did return a correct response as protocol buffer code was generated by official plugin. However protobuf dart can't deserialize this. I searched the exception and a lot of flutter apps are suffering this issue. Please fix it.

@njovy please share your proto files and the binary message that Dart protobuf library fails to decode.

@osa1 I apologize for the inconvenience caused by the outdated messages in the serialized protocol buffer. This was a misunderstanding on my part.


install fails with<EMAIL_ADDRESS>

install fails:
release istio-operator failed: customresourcedefinitions.apiextensions.k8s.io "istios.istio.banzaicloud.io" already exists

my mistake, I merged charts with helm fetch...pfff


System.AccessViolationException in BeginPlot

I created a new project in vscode and added the NuGet packages, and copied the demo code over to test the setup. However, I get the following on startup:
Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Repeat 2 times:
--------------------------------
   at DearImPlot.ImPlot+__Internal64.BeginPlot(System.String, IntPtr, DearImPlot.ImPlotFlags)
--------------------------------
   at DearImPlot.ImPlot.BeginPlot(System.String, System.Numerics.Vector2, DearImPlot.ImPlotFlags)
   at DearImPlot.ImPlot.BeginPlot(System.String)
   at TestApp.MyGameWindow.OnRenderFrame(OpenTK.Windowing.Common.FrameEventArgs)
   at OpenTK.Windowing.Desktop.GameWindow.DispatchRenderFrame()
   at OpenTK.Windowing.Desktop.GameWindow.Run()
   at TestApp.Program.Main(System.String[])

I can see from Process Hacker that the x86-64 glfw3.dll, imgui.dll, and implot.dll binaries (v1.8 / v0.14) are being loaded fine. These are the exact ones from the NuGet package.

It's a direct copy/paste of the sample app.
The fault occurs on this call:
https://github.com/aybe/DearImGui/blob/36b43ba90284ab13fb5940fbc4330838c3057707/SampleApplication.OpenTK/MyGameWindow.cs#L80

Push your repo somewhere.

I'm getting this also. It works fine if I clone this repository, build, then run the sample application. But when I replace the sample application's dependency on the DearImPlot project with a dependency on the DearImPlot NuGet package, I get the AccessViolationException.
When I enable native code debugging and attach source for implot.cpp (from the commit depended on by DearImGui: 15e494b, I get the following error at implot.cpp line 2332:
Exception thrown: read access violation.
Window was 0xFFFFFFFFFFFFFF64.


Updated package-json lib to not need DI

The underlying package-json package has had i18n ripped out using the new tpl utility instead
It's also then been refactored to not be a class that needs instantiating
This means it can be required directly and its public interface methods used where needed
This is a much nicer, neater pattern for what is a mature utility library :)

opened this for testing as I had local failures


Performance ingesting events

Hello,
we have Exceptionless 4.1 self hosted, and the events are appearing almost 10 minutes later in the UI...
Can you give me some advice how to improve this ? can I run more jobs to ingest the events ? the webserver is really low in CPU usage.. so it looks like we could use it more.
Or maybe the issue is in the elastic indexes ? i can see that the "stack-v1" index is almost 1 Gb, with 15000 documents.. and the status is yellow (not a good sign, but i don't know what it means)
Any advise about how to improve the performances would be helpful
thank you
John

You can run more jobs but it would be good to identify the root cause. Is Elasticsearch bogged down (it's memory and IO intensive)? Are the jobs running (what's the cpu usage look like, you said low)? You could bump up the job count and see if that helps but kind of sounds like elastic may need more configuration. Are you running a single node of elasticsearch?

hey Blake :)
thanks for your feedback.
I will ask my sys admin about the elastic usage... i think we have one node with 32GB of RAM and 8 cpu. you might be right that it is the bottleneck.
I've noticed that if i restart the application pool, then there is some more recent events on the dashboard, but after a short period of time, they start to be older..
The cpu on the webserver is less than 5 %.
the configuration in web.config is as below:

so i guess it's normal to not see any other processes ? i've tried to run them in a command prompt (is it EventPostJob.exe ?) but i don't see any difference..
btw, how can i see which jobs a running and how many ?

I think it would be best to focus on upgrading to 5.x which requires no data migration. It runs on asp.net core in docker and it's way more efficient in every regard and you can be 100% certain how it runs as it all runs in docker using the same prod images we use. You should see output as long as it's configured to be run out of process (config is updated to point to Redis etc.)

yeah, but sadly we don't have the infra yet to host any docker or kubernetes... and i will have no resource for this as the project here is to replace EL by a in house system (not my decision :-(  and I just want to make it work as good as possible until it's decommissioned.
I'm checking the elastic server as it seems to be the issue

I'm guessing that you are running a single box installation which is really meant more for simple setup and not geared toward performance. It runs a single instance of all the jobs in process. Most likely you could change it to run more than 1 instance of the event queue processing job to make it work better. We can definitely do more to improve things when running in a simple single box configuration, but we just wanted to make it easy to run for now.

actually it is runing on two servers, a front end and an elasticsearch on linux.
I think I've spotted the issue: it was coming from the stacks-v1 index that had become huge (1 gb) and the jobs struggle to insert the events..
I don't know why there was so many stacks btw... for now we have just restart from blank stacks & events indexes


Any call to OSSL_ENCODER_CTX_new_byXXX needs to support passing a libctx.

This is related to some new encoder code that ignores the libctx:
e.g:
PEM_write_bio_Parameters() uses the macro IMPLEMENT_PEM_provided_write_body_vars()
which then calls
OSSL_ENCODER_CTX_new_by_##type(x, PEM_SELECTION_##asn1, "PEM", PEM_STRUCTURE_##asn1,  NULL, NULL);
The last 2 params are the libctx, propq which will not work if they are just NULL..
So we either need to extract the libctx (which doesnt address that there is no propq)..
using
const OSSL_PROVIDER *prov = EVP_KEYMGMT_provider(pkey->keymgmt);
OSSL_LIB_CTX *libctx = ossl_provider_libctx(prov);

OR have a PEM_write_bio_Parameters_ex(libctx, propq) ??
To reproduce this locally do..
export OPENSSL_TEST_LIBCTX=1
apps/openssl genpkey -genparam -algorithm DSA

So we either need to extract the libctx (which doesnt address that there is no propq) using
const OSSL_PROVIDER *prov = EVP_KEYMGMT_provider(pkey->keymgmt);
OSSL_LIB_CTX *libctx = ossl_provider_libctx(prov);

Side note: this actually had me wonder why EVP_ENCODER_CTX_new_by_XXX() should even take a libctx argument.  I had that because OSSL_DECODER_CTX_new_by_XXX does, but while the latter does need it, the former...  doesn't really.

ossl_encoder_ctx_setup_for_EVP_PKEY() calls OSSL_ENCODER_CTX_get_num_encoders() which returns 0..
i.e: it cant find the encoders as they are not in the default lib context

Was that an answer to my side note?

Maybe I didn't make myself clear enough.  The question in my mind is, why doesn't EVP_ENCODER_CTX_new_by_PKEY() do this internally instead of being passed a libctx?
const OSSL_PROVIDER *prov = EVP_KEYMGMT_provider(pkey->keymgmt);
OSSL_LIB_CTX *libctx = ossl_provider_libctx(prov);

In other words, instead of passing an explicit libctx to EVP_ENCODER_CTX_new_by_XXX(), let it extract it from the object it's supposed to encode?

Either way, for this issue, I [ahem] have a branch lying around.  It's half ready, just needs some finishing touches.

In other words, instead of passing an explicit libctx to EVP_ENCODER_CTX_new_by_XXX(), let it extract it from the object it's supposed to encode?

And my subquestion was where does the propq come from..

And my subquestion was where does the propq come from..

I didn't say anything about propq.  That one still needs to be passed explicitly.

I didn't say anything about propq. That one still needs to be passed explicitly.

Regardless of which parameter it is - it is not being propagated. So we probably still need the _ex variant anyway..

Regardless of which parameter it is - it is not being propagated. So we probably still need the _ex variant anyway..

I never questioned that.  My side note was a side note, not a direct answer to this issue.

I'll raise another issue regarding that side note

Proposed fix in #13547


saveMcamFrame causes a seg fault ~50% of the time

In the Mantis C api saving an Mcam frame using the function saveMcamFrame causes a seg fault maybe every other operation. Requesting the most recent frame doesn't seem to cause it to faullt.

@camerongivler I believe you looked into this yesterday. If not, I believe this is something you will need to look at.

I have not looked into this, but will make it a priority

According to @bjschwa2, this was fixed in the latest API release (the one that didn't compile).

@bmaione could you verify if this is still an issue?

Please include the version info provided with the -h option to make sure we know what version the issue comes from.

@bmaione can you post the code that is causing the seg fault? I can't seem to reproduce this error without passing the saveMCamFrame method a NULL image buffer in the FRAME struct.
Aside: Should we perform a NULL pointer check on the FRAME struct given to the saveMCamFrame function, or should the burden be on the user to check that they are giving the method a valid FRAME struct?

We should check for a null frame and generate the appropriate message. Developers may not be experts, especially for the python api
Sent using OWA for iPhone

From: Andrew Ferg<EMAIL_ADDRESS>Sent: Thursday, May 18, 2017 2:29:00 AM
To: Aqueti/mantis_examples
Cc: Steve Feller; Comment
Subject: Re: [Aqueti/mantis_examples] saveMcamFrame causes a seg fault ~50% of the time (#12)
@bmaionehttps://github.com/bmaione can you post the code that is causing the seg fault? I can't seem to reproduce this error without passing the saveMCamFrame method a NULL image buffer in the FRAME struct.
Aside: Should we perform a NULL pointer check on the FRAME struct given to the saveMCamFrame function, or should the burden be on the user to check that they are giving the method a valid FRAME struct?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/Aqueti/mantis_examples/issues/12#issuecomment-302313297, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE_1Fq2LRBstqKiEJy3HhJKnexA3_793ks5r6-UsgaJpZM4NYCy3.

@bmaione is this the issue we fixed today? I doubt it's the same, but could be.

Not the same issue. I haven't had a chance, (or a need to rather) to verify saving capability through a the mantis API.

Added checks to saveMCamFrame that:

Check m_image buffer for nullptr
Check file name char* for nullptr
Check allocated CamImage size to prevent segfault when writing

@bmaione can you check if this fixed the issue for and close if it's resolved? I haven't been seeing the seg fault to begin with, so I can't verify myself that this changed anything.


Revert "Make sure we always de-serialize transparent functions."

This reverts commit 821b3650543ebec19279d616555a3d22b4a099bd.
It caused a bunch of execution time regressions.
rdar://30590884

@swift-ci Please smoke test and merge

Thanks!


Delete fields from objects

Like #7 but for deleting fields–there should be a field like removeField or something... :smile:

Fixed via #27. :sparkles:


Update local-path-provisioner to v0.0.27

This PR contains the following updates:

Package
Update
Change

local-path-provisioner
patch
v0.0.26 -> v0.0.27

Release Notes

rancher/local-path-provisioner (local-path-provisioner)
v0.0.27: Local Path Provisioner v0.0.27
Compare Source
What's Changed

Repair code example in storageClass description. by @c4lliope in https://github.com/rancher/local-path-provisioner/pull/368
Update README.md to 0.26 by @e-minguez in https://github.com/rancher/local-path-provisioner/pull/373
Update README.md,rm /manager by @terryzwt in https://github.com/rancher/local-path-provisioner/pull/379
Fix duplicate labels by @runningman84 in https://github.com/rancher/local-path-provisioner/pull/393
drone: remove s390x support by @derekbit in https://github.com/rancher/local-path-provisioner/pull/391
Feature/multiple storage classes by @meln5674 in https://github.com/rancher/local-path-provisioner/pull/361
Remove duplicate labels and add ability to set helperpod resource requests/limits by @visokoo in https://github.com/rancher/local-path-provisioner/pull/394
Automatic reloading of the helper pod manifest by the provisioner by @js185692 in https://github.com/rancher/local-path-provisioner/pull/399
Add support for custom path patterns by @AlbanBedel in https://github.com/rancher/local-path-provisioner/pull/385
adding pvc with node name example by @sebastianohl in https://github.com/rancher/local-path-provisioner/pull/382
Add e2e test for custom path patterns by @derekbit in https://github.com/rancher/local-path-provisioner/pull/404
Give the helper pod more range of MCS categories by @galal-hussein in https://github.com/rancher/local-path-provisioner/pull/402
Fix: Chart.yaml file is missing on helm install by @jamshidi799 in https://github.com/rancher/local-path-provisioner/pull/388
drone: disable e2e test by @derekbit in https://github.com/rancher/local-path-provisioner/pull/405
Allow customizing helper pod by @justusbunsi in https://github.com/rancher/local-path-provisioner/pull/365
test: use reclaimPolicy Delete instead by @derekbit in https://github.com/rancher/local-path-provisioner/pull/406
chart: fix pathPattern by @derekbit in https://github.com/rancher/local-path-provisioner/pull/409

New Contributors

@c4lliope made their first contribution in https://github.com/rancher/local-path-provisioner/pull/368
@e-minguez made their first contribution in https://github.com/rancher/local-path-provisioner/pull/373
@terryzwt made their first contribution in https://github.com/rancher/local-path-provisioner/pull/379
@runningman84 made their first contribution in https://github.com/rancher/local-path-provisioner/pull/393
@visokoo made their first contribution in https://github.com/rancher/local-path-provisioner/pull/394
@AlbanBedel made their first contribution in https://github.com/rancher/local-path-provisioner/pull/385
@sebastianohl made their first contribution in https://github.com/rancher/local-path-provisioner/pull/382
@galal-hussein made their first contribution in https://github.com/rancher/local-path-provisioner/pull/402
@jamshidi799 made their first contribution in https://github.com/rancher/local-path-provisioner/pull/388
@justusbunsi made their first contribution in https://github.com/rancher/local-path-provisioner/pull/365

Full Changelog: https://github.com/rancher/local-path-provisioner/compare/v0.0.26...v0.0.27

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Tab-completion in shell-mode

Hi,
I am using latest selectrum (installed via straigh.el and pulled this morning), but I have a problem with tab-completion in shell-mode.
This is what I do from emacs -Q:

install selectrum (I followed this instructions: https://github.com/raxod502/straight.el#using-straightel-to-reproduce-bugs)
M-x shell
M-x selectrum-mode
type cd Vid and hit TAB

I only have one directory starting with "Vid" in my home directory. However, with selectrum disabled I get this, which is what I was expecting:

Which means "Vid" immediately becomes "Videos/" after hitting TAB.
These are some information about my system in case they could help:
GNU Emacs 28.0.50

➤ Master branch commit:
   2581beba6580e0928cd5076b3437ff27d6da0131
   Make abbrev-tests.el more deterministic

➤ Configured with the following options:
   --with-harfbuzz --with-json --with-mailutils

➤ Running on:
   Ubuntu 20.04 LTS
   GNOME Shell 3.36.4 (x11)
   GTK+ Version 3.24.18, cairo version 1.16.0

Thanks, we should also rethink how to handle exit function in this case. When there is only a single candidate you don't want to have a space inserted because you might want to continue. I also noticed the syntax table is not setup so you can't move by path levels using sexp-commands as in find-file and other commands using read-file-name.

Should be fixed by #261?

Yes, it works as expected now. Thanks a lot for the quick fix.


release-20.1: cli: Support cluster name flags in all non-sql client commands

PR: https://github.com/cockroachdb/cockroach/pull/48016
From release notes:

Client commands such as cockroach init and cockroach quit now support the --cluster-name and --disable-cluster-name-verification flags in order to support running them on clusters that have been configured to use a cluster name. Previously it was impossible to run such commands against nodes configured with the --cluster-name flag. [#48016][#48016] {% comment %}doc{% endcomment %}

Duplicates #7649.


scipy.stats.combine_pvalues with stouffer method cannot deal with p values that has 1.0

<<Please describe the issue in detail here, and for bug reports fill in the fields below.>>
When using scipy.stats.combine_pvalues with stouffer method, when there is a 1.0 in the p value array, it returns (-inf, 1.0)
Reproducing code example:
<<A short code example that reproduces the problem. It should be self-contained, i.e., possible to run as-is via 'python myproblem.py'>>

pvals = [1e-5, 1.0]
stats.combine_pvalues(pvalues=pvals,method='stouffer')
(-inf, 1.0)
note that fisher method has no problem dealing with 1.0
stats.combine_pvalues(pvalues=pvals)
(23.025850929940457, 0.0001251292546497022)

Error message:
<<Full error message, if any (starting from line Traceback: ...)>>

NA
Scipy/Numpy/Python version information:
<<Output from 'import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)'>>

1.0.0 1.13.3 sys.version_info(major=3, minor=6, micro=2, releaselevel='final', serial=0)
At last, thanks so much for this excellent package!

I am not very familiar with these tests, but looking at https://en.wikipedia.org/wiki/Fisher's_method, the result is formally correct:
since you need the inverse of the normal CDF evaluated at 1 - p, you get +inf if p=0 or -inf if p=1.
(you get (nan, nan) if you run stats.combine_pvalues([0, 1], method='stouffer')).
Also stats.combine_pvalues([0, 0.5]) gives (inf, 0.0).
So these are really boundary cases and one can think about how to treat them. The R package metap displays seems to remove such cases and shows a warning (https://cran.r-project.org/web/packages/metap/metap.pdf).

I guess then this is rather a caveat of stouffer method itself.


Relative reference to Package.swift

Ah I see, that's a bug in swift build --generate-xcodeproj. Feel free to close.

The reason we share the Xcode project is for the shared schema. You should still do swift build -X on your own machine.


Playback speed seems a little fast

I've only been using this for a week or so, and really like it. Listening to some music that I've played a lot previously and it seems to be playing back a little bit on the fast side - as if someone had turned up the speed. I noticed the pitch was on the high side for the voices. I tried playing back in the browser and noticed a difference.
The music I was playing are files that I've synced to my personal quota on Play Music.
Thanks :)

The player doesn't make any attempt to modify the playback speed different from the browser version. Can you provide concrete evidence?

Closing due to lack of response with evidence. If you can provide evidence that the playback speed is indeed increased we'll look into it., but it should be entirely normal.


Javascript lint

This commit adds a JavaScript linter and corrects some linting errors.

I'd really prefer this wasn't added as a ruby gem, when it's a node application.

@carolinegreen I think the gem is just a wrapper so you can run it from the rake task. Not sure if we have a preference for how to run these things: at the moment some things are scripts in bin, some are run by rake and some via npm.
It's not ideal but for a prototype I don't mind so much. Would you prefer to keep the javascript stuff handled by the node toolchain?

@MatMoore I know what it is, but it's pretty bizarre to run a rake task in a node application to lint javascript.  I would prefer we use npm.  It is a prototype, but if code is being refactored in other pull requests, there is some kind of standard being applied here.  Even if that wasn't happening, it's still weird to lint using something that's really not meant for this situation.

Linting is a good idea, but it would be better to use node.  I'm going to close this, so it doesn't get merged.


shm_size and fix for 3.5

Reference: https://stackoverflow.com/questions/51517189/docker-compose-error-build-contains-unsupported-option-shm-size

Thank you! Merging


closes #124

Thanks @dgruano !

I added the change to production, so should work on the hosted version as well.


Updating duckv1.SourceStatus to include CloudEventAttributes

Needed for adding EventType registry information. See https://github.com/knative/eventing/pull/2770 and https://github.com/knative/eventing-contrib/pull/1036.
Is worth taking a look at the context from the eventing PR first.

/assign @lionelvillard @n3wscott @vaikas @mattmoor

/lgtm
/approve

/lgtm

Synced offline with @mikehelmick , he is fine with letting this in so that we can maintain current functionality and unblock the refactor PRs:
https://github.com/knative/eventing/pull/2770
https://github.com/knative/eventing-contrib/pull/1036
We will revisit EventType in https://github.com/knative/eventing/issues/2750


chore Remove useless get provider code in regression framework

Proposed changes

The following get provider and check logic code is useless.

run buildall


Table of content support in markdown

@rufuspollock, what do you mean by in markdown? I's this how it's supposed to work?
(from our docs)

Maybe it would be better to use a boolean switch in frontmatter for this, instead of creating an empty heading?

You often want to control where ToC shows up so boolean does not work as well. I think we can just use https://github.com/remarkjs/remark-toc


Enabled APPLICATION_EXTENSION_API_ONLY in tvOS framework target.

Set APPLICATION_EXTENSION_API_ONLY to YES in tvOS Framework target.

Thanks @Baza207! 🍻

I ended up resetting the merge and just cherry picking your change in 2d8466cd. In the future, if you could rebase before you push up your PR, that would be greatly appreciated.
Thanks again!

Ops sorry. I thought I'd done that properly. I'll rebase from now on so I don't cause any more issue.


Add secret ssh-keys

Please test this

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

please test this

PR with older code.
Updating and creating a new PR.


MaxByOrDefault

Currently, MaxBy will throw an exception if executed on an empty enumerable.  I would like a way to provide it with a default value to use, or have it use default(Source).
Example usage:
var emptyEnumerable = Enumerable.Empty<Person>();
var result = emptyEnumerable.MaxByOrDefault(person => person.Age);
Assert.Equal(0, result);

result = emptyEnumerable.MaxBy(person => person.Age, 10);
Assert.Equal(10, result);

Originally reported on Google Code with ID 96
Reported by<EMAIL_ADDRESS>on 2014-12-08 20:12:09

I don't think this makes sense. One could just as well do src.DefaultIfEmpty(value).MaxBy(p => p.Age) plus null checks if value is null.

After coming back to this I agree with @fsateler.  The proposed methods/overloads might be a bit redundant.

Wish it was implemented MaxByOrDefualt.


Random seed is not respected

What version of OR-Tools and what language are you using?
Version: ortools==7.4.7247
Language: Python
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
CP-SAT
What did you do?
Steps to reproduce the behavior:
we set a random seed value using
solver.parameters.random_seed
What did you expect to see
we expect to be able to reproduce the results every time we run our code (based on solution id, not time).
What did you see instead?
We see different solutions and we are not able to reproduce the results on the same hardware

Not sure if this is normal behavior or a bug. Unless it is a bug, is there another setting we can use to get the same first solution every time we run the code?
Thanks.

Please try with 9.0. It could have improved a little since then.

are you using parallelism ?

Please try with 9.0. It could have improved a little since then.
The same problem in 9.0 version

are you using parallelism ?
Yes, we use parallelism to speed-up the search.

Parallelism is not deterministic.
Laurent Perron | Operations Research | @.*** | (33) 1 42 68 53
00
Le lun. 27 sept. 2021 à 20:24, ajouzali @.***> a écrit :

Please try with 9.0. It could have improved a little since then.
The same problem in 9.0 version
are you using parallelism ?
Yes, we use parallelism to speed-up the search.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/2793#issuecomment-928158579,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUPL3M63RYVTTSPWVPNQRTUECZFXANCNFSM5E2DWV2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Document C++11 build requirements and enforce them in CI.

Clarify the state of C++03 and C++11 support in CONTRIBUTING.md,
and add a new CI test to ensure that Ninja builds and works
correctly with a C++11 compiler.

We already built with C++11 in CI: New GCC releases and MSVC default to it.
I prefer the old sentence in CONTRIBUTION.md as it allows C++11 for unimportant tools.

I see. This is not obvious at all, and if these compilers decide to switch to C++14 next year, the upgrade will be silent and we may miss some breakages (e.g. someone using a C++14 specific feature like variable templates, but guarding it with #if __cplusplus >= 201103L incorrectly).
I think it would be better to enforce standards compliance with explicit compiler switches instead (e.g. -std=c++03 and -std=c++11 in this case) to avoid these and make everything completely explicit to everyone looking at the CI build rules. Also in case of failure, it will be easier to see in the log if this is related to a standard feature or not. What do you think?
I have clarified that the last restriction does not apply to tests and unimportant tools (but maybe it would be nice to better describe what these are).

If the compilers decide to switch we won't be affected as the compiler versions are fixed in the CI by using a specific Ubuntu/CentOS version.
Btw have you seen #2089? Given that PR and my general resistance against change (sorry), I'm closing this one.

However, I think it would be useful for new contributors to properly document the state of C++ standard support (and Python too) and clarify that this is enforced in CI.

And you think that "Any code merged into the Ninja codebase which will be part of the main executable must compile as C++03." is not enough?

And you think that "Any code merged into the Ninja codebase which will be part of the main executable must compile as C++03." is not enough?

It does not reflect what is already in the code base of the main executable, which already contains a few C++11 specific code path alternatives. Some of them were accepted recently, for good performance-related reasons (moves instead of copies, or better containers). This is surprising to any new contributor.

Can you give an example? auto_ptr for example was removed in C++17 so ifdefs were added to support newer compilers.

Well, just grep for 201103L in the code base:

Faster containers in src/missing_deps.h

One to avoid a crash in src/graph.cc when edge_->inputs_ is empty (this is in the commit message, but should really be a comment, so no-one tries to remove this later thinking these are the same things, a better fix would probably not call the function at all if explicit_deps_count is 0 though)

missing_deps is an "unimportant tool" and the crash in graph.cc only happens in MSVC and debug mode.
And even with __cplusplus ifdefs the point still stands: The code must compile as C++03.

Ah, I see why I was confused: I thought that "unimportant tools" meant the things that are under misc/ and which are not part of the main executable. And also in the current case, "missing_deps.cc" is definitely covered by "any code merged into the Ninja codebase which will be part of the main executable". And what is an "important" or "unimportant" tool anyway?
It would be useful to everyone if things could be clarified or made explicit (I don't know if you realize that the project's situation is a little confusing for any new contributor). I'd be happy to provide PRs to update the documentation in this direction, so don't be surprised if I submit a few more similar PRs in the future, and let me know if there are more important tasks there than others.

And there is no use of std::move() though, I was confused because I have local branches that add these to avoid a few extra string copies in certain places, but nothing important that needs to be submitted now :-)

And also in the current case, "missing_deps.cc" is definitely covered by "any code merged into the Ninja codebase which will be part of the main executable". And what is an "important" or "unimportant" tool anyway?

Good points, I see what you mean now :)
Regarding C++11 I think it would be best to just enable it, that's probably the least confusing situation for new contributors.
BUT: Contributing to Ninja is very frustrating as I don't have time to review most of the PRs. So making anything more attractive to new contributors might give a false impression.


[stdlib] Switch some cold paths to inline-never

Fetching the non-native implementation or creating a bridged wrapper shouldn't need to be inlinable.

@swift-ci please smoke test

@swift-ci please benchmark

Performance: -O

Regression
OLD
NEW
DELTA
RATIO

EqualSubstringSubstring
21
27
+28.6%
0.78x

LessSubstringSubstring
21
27
+28.6%
0.78x

EqualSubstringString
21
27
+28.6%
0.78x

LessSubstringSubstringGenericComparable
21
27
+28.6%
0.78x

EqualStringSubstring
22
28
+27.3%
0.79x

EqualSubstringSubstringGenericEquatable
22
28
+27.3%
0.79x

DistinctClassFieldAccesses
174
196
+12.6%
0.89x (?)

StringComparison_longSharedPrefix
320
356
+11.2%
0.90x

ArrayInClass
805
890
+10.6%
0.90x (?)

Hanoi
2040
2250
+10.3%
0.91x (?)

StringHashing_slowerPrenormal
550
600
+9.1%
0.92x (?)

Improvement
OLD
NEW
DELTA
RATIO

ArrayAppendOptionals
710
600
-15.5%
1.18x (?)

ObjectiveCBridgeStubFromNSStringRef
107
95
-11.2%
1.13x (?)

LazilyFilteredArrayContains
18500
16700
-9.7%
1.11x (?)

UTF8Decode_InitDecoding
126
116
-7.9%
1.09x (?)

Breadcrumbs.IdxToUTF16Range.longASCII
29
27
-6.9%
1.07x

Code size: -O

Regression
OLD
NEW
DELTA
RATIO

NopDeinit.o
5297
5462
+3.1%
0.97x

ClassArrayGetter.o
5496
5649
+2.8%
0.97x

ArrayOfGenericRef.o
11422
11662
+2.1%
0.98x

ArrayOfRef.o
11539
11779
+2.1%
0.98x

SortLettersInPlace.o
8669
8781
+1.3%
0.99x

COWTree.o
12236
12380
+1.2%
0.99x

DictionaryGroup.o
16197
16362
+1.0%
0.99x

Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

LessSubstringSubstring
21
27
+28.6%
0.78x

EqualSubstringString
21
27
+28.6%
0.78x (?)

LessSubstringSubstringGenericComparable
21
27
+28.6%
0.78x (?)

EqualSubstringSubstring
22
28
+27.3%
0.79x

EqualStringSubstring
22
28
+27.3%
0.79x (?)

EqualSubstringSubstringGenericEquatable
22
28
+27.3%
0.79x

DistinctClassFieldAccesses
176
206
+17.0%
0.85x (?)

ArrayLiteral2
100
117
+17.0%
0.85x (?)

StringComparison_longSharedPrefix
320
356
+11.2%
0.90x

ArrayInClass
850
935
+10.0%
0.91x (?)

Set.isStrictSuperset.Seq.Empty.Int
148
160
+8.1%
0.93x (?)

Improvement
OLD
NEW
DELTA
RATIO

Set.isDisjoint.Int.Empty
57
53
-7.0%
1.08x (?)

Code size: -Osize

Regression
OLD
NEW
DELTA
RATIO

SortLettersInPlace.o
8259
8451
+2.3%
0.98x

DictionaryKeysContains.o
7503
7607
+1.4%
0.99x

DictionaryRemove.o
10560
10688
+1.2%
0.99x

Improvement
OLD
NEW
DELTA
RATIO

COWTree.o
13036
12468
-4.4%
1.05x

ClassArrayGetter.o
5619
5389
-4.1%
1.04x

NopDeinit.o
6257
6027
-3.7%
1.04x

ArrayOfGenericRef.o
12598
12262
-2.7%
1.03x

ArrayOfRef.o
12635
12331
-2.4%
1.02x

DictionaryGroup.o
13684
13540
-1.1%
1.01x

Performance: -Onone

Regression
OLD
NEW
DELTA
RATIO

EqualSubstringSubstringGenericEquatable
25
31
+24.0%
0.81x

LessSubstringSubstringGenericComparable
25
31
+24.0%
0.81x

EqualSubstringSubstring
26
32
+23.1%
0.81x

LessSubstringSubstring
26
32
+23.1%
0.81x

EqualSubstringString
26
32
+23.1%
0.81x (?)

EqualStringSubstring
27
32
+18.5%
0.84x

DataAppendDataMediumToMedium
3020
3320
+9.9%
0.91x (?)

Improvement
OLD
NEW
DELTA
RATIO

UTF8Decode_InitDecoding
144
129
-10.4%
1.12x (?)

ObjectiveCBridgeStringHash
43
40
-7.0%
1.07x (?)

Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

Can one of the admins verify this patch?

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

How to change the base branch: (Link)
More detail about the branch update: (Link)


improve proxy bypass on Windows

See #3976

Codecov Report

Merging #3979 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
- Coverage   89.73%   89.67%   -0.06%
==========================================
  Files          15       15
  Lines        1949     2209     +260
==========================================
+ Hits         1749     1981     +232
- Misses        200      228      +28

Impacted Files
Coverage Δ

requests/utils.py
85.45% <0%> (+0.42%)
:arrow_up:

requests/cookies.py
82.01% <0%> (+4.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8674db...d7b4a95. Read the comment docs.

Well coverage drops obviously as these tests are only run on Windows :-/
From my POV this is ready to get merged, please review.

The code is copy pasted from Python 3.5's urlib/request.py with the lines doing DNS lookups (and appending to host) removed. I would recommend leaving it as is (maybe add a clarifying comment about this).

I'm a bit disinclined to do that unless we think this is going to be temporary code (which it won't be until we drop 2.7 support at least). If we are going to support it I'd like the code to be sensible and comprehensible. 😃

@Lukasa Please give me a note when AppVeyor tests are working. Then I'll udpate this PR.

@Lukasa Should I revert c121b98c4eb1e4ee8927995d9b9f1d6bdccd9349? With this PR there is no reason anymore for caching the results...

@schlamar Yeah, might be worth doing.

close/reopened to get appveyor to re-run

It'll need to be rebased on top of master.

@Lukasa @nateprewitt Updated, please review again.

BTW, coverage drops because reverting 8e6e47af43d1d89a0201bd58e97c700bebbddd5e and c121b98c4eb1e4ee8927995d9b9f1d6bdccd9349 removes a lot of covered lines. My changes alone do not negatively affect coverage.

@schlamar Based on codecov's output the actual reason you're reducing coverage is that the diff isn't covered enough to avoid regressing it. To match coverage you'd need to cover 90% of the diff, but only 86% is covered. You can see the lines we're missing here: what are the odds that we can write tests that appropriately cover them?

@Lukasa Updated, please review again :)

When was the proxy bypass cache introduced? I'd like to make a reference but can't find anything in the changelog :)

@schlamar, I believe it was only a couple months ago (#3885).

Ah yes, this wasn't even released yet. @Lukasa in this case I would ignore this?!

Yeah, you would. =)

:tada:


"Work Order Type" is not displayed in Summary tab as indicated

In # "2 Create a work order or use one from sample data", the field "Work Order Type" is not displayed in the Summary Tab. It is in the Business Process, Work Order stage.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a68c418-1920-98ac-e21b-6f2b3e3f4e01
Version Independent ID: b27e4361-63e2-8843-46e1-08b130442182
Content: Quickstart: Schedule a work order and view it on the mobile app - Dynamics 365 for Field Service
Content Source: ce/field-service/quickstart-schedule-work-order.md
Service: dynamics-365-customerservice
Technology: field-service
GitHub Login: @krbjoran
Microsoft Alias: FieldServiceDave

"Work Order Type" is in also in the "Settings" tab.

Hi James - thanks for bringing this to our attention. Dave and I just updated the screenshot to show that "Work Order Type" also appears on the summary tab.


typo fix insert load doc error

Proposed changes
Issue Number: close #18770
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Whether to modify the English document at the same time. And change the PR title,like : typo fix insert load doc error

Whether to modify the English document at the same time. And change the PR title,like : typo fix insert load doc error

English without error

run buildall


Add to wallet button in docs (Issue #355)

Fixes #355.
Adds a button to add Chainlink to a user's Ethereum wallet.

Here's a link to the standard for adding to wallets that I found in order to implement the code: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-747.md

I poked around a bit more, using arbitrary HTML in the @readme/markdown plugin doesn't seem to be allowed. It sanitizes all HTML strings by default and strips away all Javascript. There doesn't seem to be a way around this. We need to be able to include the little chunk of JavaScript inside the markdown table to hook into the wallet to add the coin.
The simplest solution would be to convert the whole page to a liquid template and remove markdown entirely for this section. Then adding custom Javascript wouldn't be sanitized. I think for this particular case, that would make the most sense.  The downside, is the tables are converted to normal HTML tables instead of the markdown syntax tables.
Let me know what you think.

@jamsea is this ready to be delivered?

@PatrickAlphaC @dwightjl I have a fuller than usual schedule this week but I can have it wrapped up by Saturday. 👍

thanks so much, @jamsea.
just reworked the original PR as there were a few things to take into account:

Keep markdown
Ensure that we are wallet extension is installed (for now, I've coded only support for Metamask. We can support other wallets in the future)
Add a button "Add to wallet" only near the right contract address (e.g.: if you are connected to Kovan then you'll see a button near the address)
Reload the page when the user changes the chain

@PatrickAlphaC could you have a look please?

@aelmanaa thats a smart solution! I couldn't figure out how to keep the markdown, great job

This looks good to me now :) Thanks!

Squashed and rebased to main


FireEye Network Security TemplateSpec Solution

Change(s):
See guidance below
Reason for Change(s):
This PR is part of template spec solution migration for solution FireEye Network Security.
See guidance below
Version Updated:
2.0.0
Required only for Detections/Analytic Rule templates
See guidance below
Testing Completed:
The link for test results is - https://microsoftapc.sharepoint.com/:w:/r/teams/SentinelCATTeam/_layouts/15/Doc.aspx?sourcedoc={503BD47C-CDAC-4F69-A833-CE5AD2607FFB}&file=Sentinel Solution Migration -TemplateSpec - FireEye Network Security.docx&action=default&mobileredirect=true&share=IQF81DtQrM1pT6gzzlrSYH_7AcRT6DeiLPABAlYDTtAqPww
See guidance below
This is an ISV solution.

Looks good


Inline markup?

Is it possible to inject extra SVG/HTML markup into the SVG to be inlined?
This would allow to add text and other dynamically generated markup and
let the SVG handle the effect / adjust its dimensions to it.

@Log1x: Are there any plans for this in near future?

Enable with:
add_filter('bladesvg_inline', function () {
    return true;
});

and use the docs seen here to inject classes, ID's, etc.


report data every minute, 2 decimal points

This addresses #19 with precision for CO2 and Temp data, but not the precision on latitude/longitude
I also added color scale to the map so that datapoints are color coded based on CO2 reading

Looks perfect!

Resolved the merge conflicts and merging now :).


Updating i18n locale files at runtime

Hey there,
I'm implementing a new feature which allows bot admins to be able to change bot texts and/or adding new languages to the bot.
However for this to work (changes to key-values at locale files get applied), bot needs to restart.
Is there any hacks or possible solution to this? Thanks a lot.

You can

create an instance of this plugin, and return it from bot.lazy rather than installing it with bot.use
re-create that instance whenever the translations change

That way, your bot will always automatically use the latest strings, and you do not even need to restart anything.

Thanks for reply, I tried this:
const localesPath = `${process.env.DATA_PATH}/locales`;

if (!existsSync(localesPath)) {
  this.log.info(
    "No data/locales folder found! creating one from ./locales folder"
  );
  cpSync("locales", localesPath, {
    recursive: true,
  });
}
this.i18n.loadLocalesDirSync(localesPath);
// this.tg.use(this.i18n);
this.tg.lazy(this.i18n.middleware);

But receiving this error:
Unknown error: TypeError: Cannot read properties of undefined (reading 'fluent')
    at middleware (/node_modules/@grammyjs/i18n/script/src/i18n.js:102:32)
    at /node_modules/grammy/out/composer.js:530:38
    at /node_modules/grammy/out/composer.js:51:41
    at /node_modules/grammy/out/composer.js:61:19
    at /node_modules/@grammyjs/conversations/out/conversation.js:272:15
    at /node_modules/grammy/out/composer.js:51:41
    at /node_modules/grammy/out/composer.js:61:19
    at /node_modules/grammy/out/convenience/session.js:65:15
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /node_modules/grammy/out/composer.js:61:13

Perhaps I've misplaced middleware factory required for lazy loading
middleware(): MiddlewareFn<C & I18nFlavor>

Check out the example in the API ref: https://deno.land/x/grammy@v1.20.3/mod.ts?s=Composer&p=prototype.lazy
I was referring to
let i18n: I18n;

async function initI18n() {
  i18n = new I18n(..);
  // do setup here
}

await initI18n();
bot.lazy(() => i18n)

// when translations update, just call
await initI18n();
// again

Works perfectly, thanks a lot!


Impossible to connect with a peripheral with BLE and zephyr 2.7.99, BT_HCI_ERR_UNKNOWN_CONN_ID error

I am having a connectivity problem with a central Bluetooth device (nrf52832) that needs to be connected to a peripheral (nrf52840), previously this connectivity worked correctly with zephyr 2.5.0 but now that I wanted to update to zephyr 2.7.99 it has stopped working correctly since I rarely get connected to the peripheral, most of the time I don't get it and I get an error=2 from the callback of connected bt_conn_cb, I also tried to increment the timeout of bt_conn_le_create_param  with no positive result. The only modification I did was the CONFIGS
This is what I have now with zephyr 2.7.99:
CONFIG_BT=y
CONFIG_BT_L2CAP_TX_MTU=252
CONFIG_BT_BUF_ACL_RX_SIZE=248
CONFIG_BT_BUF_EVT_RX_SIZE=255
CONFIG_BT_BUF_CMD_TX_SIZE=255
CONFIG_BT_DEVICE_NAME_DYNAMIC=y
CONFIG_BT_BAS=y
and this is what I had with zephyr 2.5.0:
CONFIG_BT_L2CAP_TX_MTU=252
CONFIG_BT_L2CAP_RX_MTU=252
CONFIG_BT_RX_BUF_LEN=260
CONFIG_BT_DEVICE_NAME_DYNAMIC=y
CONFIG_BT_BAS=y

Can you reproduce this issue on the latest main

Hi, thanks for your reply it would be really tedious and time consuming for me to move to the latest 3.2.0-rc1 version as my firmware has a lot of dependencies right now. do you think we can try to make it work in this version?

@rubenwat can you manage to reproduce this using a (or multiple) samples in-tree? A branch with some sample code can also do the trick if you prefer.

With those sample I do get to perform a connection, maybe the error is that my connection interval is so fast (7,5ms) but I do not understand why with zephyr 2.5.0 works correctly though.

@rubenwat  we need additional details:

Are you using vanilla Zephyr or Nordic NCS?
Which exact revision (SHA) are you using?
Can you please capture a sniffer trace of the failed connection and attach it to this issue?


feat: 🎸 add raw ID to BaseAsset class

add getter method to return asset ID in hex format
Description

Breaking Changes

JIRA Link

Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 26.0.0-beta.5 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


prepare using robots with cartesian controller

this brings in according launch files and parameters for using twist_control with all cob4-1/cob4-2 components currently available....(just need to be uncommented)

FR: OK

mergin in order to allow @ipa-fxm-cm and @ipa-bfb a cleaner start for their contribution


Create placeholders for all the delegate and event articles. Fixes #236 and #241

Fixes #236 (sub-task of #63)

Second commit fixes #241 (sub-task of #64)

LGTM modulo feedback.

I just updated based on @cartermp feedback.

Now that this is merged, I'll rebase the other PRs

:+1:


West build fails

Great to see you have kept the Hypnos project going!
Running west build fails with the following error
devicetree error: missing data after phandle in <Property 'pwms' at '/pwmleds/pwm_led_0' in '/home/operator/Development/pine-time/pinetime-zephyr/zephyr/misc/empty_file.c'>
To get the build working I updated pinetime_devkit0.overlay with the following, but I think its not correct as the backlight never turns on :-)
pwm_led0: pwm_led_0 {
                       pwms = <&pwm0 23 PWM_MSEC(20) PWM_POLARITY_NORMAL>;

fixed


Speaker ID in inference notebook

Thank you for this amazing implementation. Everything is working perfectly except I wasn't able to figure out how to select speakers during inference (I have trained with 5 speakers).
Any hints would be really appreciated!

Hello! Sorry for bothering you. I am also trying to implement multi-speakers TTS using IEMOCAP database. Did you train it successfully without changing anything like hparams.py? My net training just cannot work at the beginning. ; ;
Any replies would be really appreciated!


Change callback function for Basic Authentication to verifyPassword

@gtaban here's an issue for your PR.

https://github.com/IBM-Swift/Kitura-CredentialsHTTP/pull/22

Merged.


[BUG] branch outputs are /merge rather than the branch name

Is there an existing issue for this?

[X] I have searched the existing issues

Does this issue exist in the latest version?

[X] I'm using the latest release

Describe the bug?
When running the action from a pull_request_review, none of current_branch, head_ref_branch and ref_branch actually include the branch name from the PR.
Here's what I see in the debug output:
##[debug]-e "CURRENT_BRANCH=20/merge" \
##[debug]-e "HEAD_REF_BRANCH=" \
##[debug]-e "REF_BRANCH=20/merge" \

To Reproduce
      - name: get branch name
        id: branch-name
        uses: tj-actions/branch-names@v6
      - name: run thing
        run: |
          docker run \
          --pull=always \
          -e "CURRENT_BRANCH=${{ steps.branch-name.outputs.current_branch }}" \
          -e "HEAD_REF_BRANCH=${{ steps.branch-name.outputs.head_ref_branch }}" \
          -e "REF_BRANCH=${{ steps.branch-name.outputs.ref_branch }}" \
          ...

What OS are you seeing the problem on?
ubuntu-latest or ubuntu-20.04, ubuntu-18.04
Expected behavior?
I'm not sure if my use case (triggering on pull_request_review) just isn't the desired one but my hope would be to have SOME way of consistently getting the branch name from the PR that the review was submitted for
Relevant log output
Included above

Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It looks like github.event.pull_request.head.ref includes the right information on a pull_request_review

@chrisjohnson This issue has been resolved in the latest release.

Thanks :)


Add support for acquiring remote projects from the asset library

Adds support for downloading projects from  the asset library.
Created a new tab that shows all project assets available for a specific version.  All asset listings can be clicked, which brings up a description for the asset with the option to download it. Downloading it will allow for the user to select the name of the new project and the path to install it to.
Uses TuxFamily to acquire information on what versions currently exist and the official asset library API available at https://godotengine.org/asset-library/api/asset (and documented at https://github.com/godotengine/godot-asset-library/blob/master/API.md#assets-api).
This does not download asset icons or asset previews. I believe we shouldn't download the images without caching them, to avoid making heavy use of the bandwidth (I don't know how heavy the usage is, I just don't want to risk DOSing the asset library).  This is something that should be implemented in the future.
Screencast from 2023-09-06 00-47-50.webm

Great work, thank you!
Anyway, there is something that has to be done before we'll be able to merge it.
The main flow of how assets are getting installed: it has to not block the user for doing his stuff. That is why I think of redoing the feature in the way how Godot handles it already - download zip in background, then install it.
We have the desired implementation in EditorDownload, but it is too coupled to the domain. So, first we should generalize it #16, and then reuse in Asset Library.
Also, one parallel task is also has to be implemented first: importing the project from zip. It will be useful in this case (asset library) and in Drag&Drop functionality. #15
After the tasks are merged in the main, we'll be able to continue working on this.

Starting from now it should be possible to use both the asset_download.tscn and ../components/projects.tscn::install_zip(.., ..) to download and install projects from Asset Lib.

Starting from now it should be possible to use both the asset_download.tscn and ../components/projects.tscn::install_zip(.., ..) to download and install projects from Asset Lib.

Thanks! I will probably take some time, since I'm a bit occupied with some other stuff, but I will be back on it within some days.

Closed as implemented in #48


DEX-515 Change social-groups PATCH to only use /members

Add social group integration test

Change social-groups PATCH to only use /members
Remove /member PATCH path and instead use /members to be consistent.
When op is "add", the members are added (or replaced if they already
existed).  When the op is "removed", the member or list of members are
removed.  When the op is "replaced", the members are set to exactly what
the user provides.

Fix error when social group member is not valid uuid
E               sqlalchemy.exc.StatementError: (builtins.ValueError) badly formed hexadecimal UUID string
E               [SQL: SELECT individual.created AS individual_created, individual.updated AS individual_updated, individual.viewed AS individual_viewed, individual.guid AS individual_guid, individual.featured_asset_guid AS individual_featured_asset_guid, individual.version AS individual_version
E               FROM individual
E               WHERE individual.guid = %(param_1)s]
E               [parameters: [{'%(140645722029696 param)s': '4037'}]]

/rebase

/rebase

Also as API has changed, please update the doc: https://docs.google.com/document/d/1d1L8j6vOy1h3tpcdl7qWQcn87gYkyDTsCzNISnEGVgM/edit#heading=h.i3s24ptpxrf4

Done :+1:


Add description, validation_message, and introduced fields into openssl resources

Get these updated for the latest and greatest before we ship Chef 14
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

I fixed up a few of them a bit


Bump version 2.9.7

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin please rerender

The version 2.9.x is for the legacy software, the C version not the CXX.


 MPD doesn't particularly enjoy this, so Empede should do something to limit this
E.g. for the idle SSE, only one connection in total is needed as (without client-to-client communication, which Empede doesn't use) all clients receive the same events

Done in v0.2.1


fix setting of lines-changed-only

The README states that the value of true focuses on lines in diff with additions only.
Setting it to 'diff' will use the original behavior (meaning entire diff chunks with unchanged lines).
However, I forgot to change this value's interpretation in the src code (& test).
This commit makes the README accurate.

Codecov Report

Merging #90 (a03b252) into master (600b1aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   80.47%   80.47%
=======================================
  Files           6        6
  Lines         630      630
=======================================
  Hits          507      507
  Misses        123      123

Impacted Files
Coverage Δ

cpp_linter/run.py
78.76% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Related to https://github.com/cpp-linter/cpp-linter-action/issues/74#issuecomment-1212471581


Since F1 works, I was thinking it'd be simpler not to use F2? Thoughts?

I already removed them :D
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/663/files