My nightmare returns...

Hello. It would appear that I'm doing something wrong (Once more)
I believe that the client gets disposed at some point after receiving a long byte[] from remote connections... I have checked with the client.test and server.test those work perfectly fine. I'm just doing something wrong in my own implementation of the package... How can I move the client and the server networking to a separate class and instantiate it ?(You talked to me about this before) Do I need to use the { get; set; } ? This issue has me really confused, I'm sure that my router network works fine, I'm just doing something wrong in the code... It used to work fine for small byte[] but when I try to send a .wav file for example it just disposes itself or something like that... I get the following error:
Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host.
Edit: Here are the full errors in both exception and .json formats.
[ERROR] System.IO.IOException: Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host. ---> System.Net.Sockets.SocketException: An existing connection was forcibly closed by the remote host    at System.Net.Sockets.Socket.Send(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)    at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)    --- End of inner exception stack trace ---    at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)    at WatsonTcp.WatsonTcpServer.SendDataStream(ClientMetadata client, Int64 contentLength, Stream stream)    at WatsonTcp.WatsonTcpServer.SendInternal(ClientMetadata client, WatsonMessage msg, Int64 contentLength, Stream stream)
  "ClassName": "System.IO.IOException",   "Message": "Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host.",   "Data": null,   "InnerException": {     "NativeErrorCode": 10054,     "ClassName": "System.Net.Sockets.SocketException",     "Message": "An existing connection was forcibly closed by the remote host",     "Data": null,     "InnerException": null,     "HelpURL": null,     "StackTraceString": "   at System.Net.Sockets.Socket.Send(Byte[] buffer, Int32 offset, Int32 size, SocketFlags socketFlags)\r\n   at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)",     "RemoteStackTraceString": null,     "RemoteStackIndex": 0,     "ExceptionMethod": "8\nSend\nSystem, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089\nSystem.Net.Sockets.Socket\nInt32 Send(Byte[], Int32, Int32, System.Net.Sockets.SocketFlags)",     "HResult": -2147467259,     "Source": "System",     "WatsonBuckets": null   },   "HelpURL": null,   "StackTraceString": "   at System.Net.Sockets.NetworkStream.Write(Byte[] buffer, Int32 offset, Int32 size)\r\n   at WatsonTcp.WatsonTcpServer.SendDataStream(ClientMetadata client, Int64 contentLength, Stream stream)\r\n   at WatsonTcp.WatsonTcpServer.SendInternal(ClientMetadata client, WatsonMessage msg, Int64 contentLength, Stream stream)",   "RemoteStackTraceString": null,   "RemoteStackIndex": 0,   "ExceptionMethod": "8\nWrite\nSystem, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089\nSystem.Net.Sockets.NetworkStream\nVoid Write(Byte[], Int32, Int32)",   "HResult": -2146232800,   "Source": "System",   "WatsonBuckets": null
Edit2: These errors specifically happen when sending large byte[] with the Server.Send(IpPort, byte[]) method
Edit3: I looked a bit more into it, I believe that this could be caused by "IpPort" mismatches, like, the server sends data to a port the client doesn't expect to receive them from? I noticed that more ports than the one initially set up as the actual port to use are being used to send/receive data

Hi @Antwns good to hear from you and sorry the issue is still plaguing you.  I would try defining the WatsonTcpServer instance in your App.xaml.cs, and then instantiate it there.  If the class is instantiated from within one of your views, it's likely to get disposed (garbage collected) if the view changes.  Weird things happen in views/forms that way.  You should be able to access things defined in your App.xaml.cs, i.e. WatsonTcpServer Server = new... and then accessing it using App.Server(....
Do you still have the code that I sent your way?  I believe I followed this model.  Cheers, Joel

I believe this is the patch I sent: https://github.com/jchristn/WatsonTcp/files/5424294/patch.zip
In your case, WatsonTcpServer would be instantiated in your AntVaultServer App.xaml.cs:
    public partial class App : Application
    {
        public static MainServerWorker Server = null;
    }

And then instantiated in your MainServerWindow.xaml.cs:

        public MainWindow()
        {
            InitializeComponent();

            App.Server = new MainServerWorker();
        }

And then used MainServerWorker.cs class:
            _AntVaultServer = new WatsonTcpServer("<IP_ADDRESS>", _Port);

Have you had a chance to give that a try?  Cheers, Joel

I did but the problem is that I switched to a console app instead for the server. I have implemented the above changes to the client, should I do the same for the server? I noticed that the client connects for a bit, asks the basic information(strings) from the server and then somehow it just gets disconnected before it can send a login request(strings) to the server, how would I implement the above changes on a console app? Thanks for all the help so far, I really appreciate it 😀

If I understand correctly, I need to move everything about WatsonTCP to a SINGLE class, event the events_messagereceived and then simply instantiate it in parts of my code where I need to use it?

UPDATE: I have moved everything server and client related to their own classes and instantiated them later on, however things keep getting disposed, in the seperate classes I created nothing has the static modifier... I don't understand...

Hi @Antwns if you invite me to your repo, I'll be happy to clone, take a look, and contribute recommendations.

I did it! Thank you so much!

Haven't forgotten about you @Antwns - the week kinda got away from me.  Still on my list.

I'm sorry but the newest version completely bricked my app... I moved on to a different package and cross-network communication works too. I'm sorry @jchristn , I waited ~4 days I understand you had alot to work with and that's okay

Thank you Antwns - glad to hear you have a working solution!


Uncaught TypeError: Cannot read property 'length' of undefined

[Enter steps to reproduce:]

...
...

Atom: 1.28.2 x64
Electron: 2.0.5
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'length' of undefined
At C:\Users\RusBear55\AppData\Local\atom\app-1.28.2\resources\app\node_modules\text-buffer\lib\screen-line-builder.js:328

TypeError: Cannot read property 'length' of undefined
    at ScreenLineBuilder.emitText (~/AppData/Local/atom/app-1.28.2/resources/app/node_modules/text-buffer/lib/screen-line-builder.js:328:31)
    at ScreenLineBuilder.buildScreenLines (~/AppData/Local/atom/app-1.28.2/resources/app/node_modules/text-buffer/lib/screen-line-builder.js:140:22)
    at DisplayLayer.getScreenLines (~/AppData/Local/atom/app-1.28.2/resources/app/node_modules/text-buffer/lib/display-layer.js:643:41)
    at TextEditorComponent.queryScreenLinesToRender (~/AppData/Local/atom/app-1.28.2/resources/app/src/text-editor-component.js:881:57)
    at TextEditorComponent.updateSyncBeforeMeasuringContent (~/AppData/Local/atom/app-1.28.2/resources/app/src/text-editor-component.js:385:16)
    at TextEditorComponent.updateSync (~/AppData/Local/atom/app-1.28.2/resources/app/src/text-editor-component.js:275:16)
    at TextEditorComponent.didMouseWheel (~/AppData/Local/atom/app-1.28.2/resources/app/src/text-editor-component.js:1560:59)

Commands
     -6:28.1.0 line-ending-selector:show (atom-text-editor.editor.is-focused)
     -0:33.1.0 intentions:highlight (input.hidden-input)

Non-Core Packages
atom-beautify 0.32.5
atom-clock 0.1.16
atom-live-server 2.3.0
autocomplete-modules 2.1.0
browser-plus 0.0.98
busy-signal 1.4.3
color-picker 2.3.0
comment 0.6.1
double-tag 1.5.0
emmet 2.4.3
file-icons 2.1.22
git-plus 8.0.0
highlight-selected 0.14.0
intentions 1.1.5
javascript-snippets 1.2.1
linter 2.2.0
linter-ui-default 1.7.1
merge-conflicts 1.4.5
minimap 4.29.8
minimap-autohide 0.10.1
minimap-codeglance 0.4.7
minimap-cursorline 0.2.0
minimap-git-diff 4.3.1
open-in-browser 0.5.2
pigments 0.40.2
project-manager 3.3.6
remote-ftp 2.2.0

Also happening on macOS 10.13.6.

Thanks for contributing!
We noticed that this looks like a duplicate of https://github.com/atom/atom/issues/16892 so you can subscribe there for updates if you'd like.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Service Principal "az login" example command contains wrong placeholder

Hi all,
Under the section "Authenticate via Azure Service Principal" I see the command to login to the azure cli:
az login --service-principal -u <service_principal_name> -p "<service_principal_password>" --tenant "<service_principal_tenant>"

and it suggests to use the service principal name/<azure_principal_name> for the -u argument. Unfortunately, in my experience using the service principal's name does not work. When I use the name, I get a 400 unauthorized error.
Instead, it seems to require the service principal's appId. Maybe a better placeholder for this line would be <azure_principal_appId> instead of <azure_principal_name>?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d35c94ec-c9ad-0233-4115-3ddc43ddcd38
Version Independent ID: 6b231b6b-523b-445d-2b15-7dfc04da7ef9
Content: Quickstart - Configure Terraform using Azure Cloud Shell
Content Source: articles/terraform/get-started-cloud-shell.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@awkimball Thank you for the feedback. These articles (the Get Started content and the Authentication steps) have been rewritten. Please let me know if you see any continued or new issues. Thanks again!


when using any version greater than 3216, it doesn't render diagrams

Question
Would anyone let me know if you have had the same issue, please?

btw, the generated JSON files are totally different between version 3216 and any later ones (like 'latest')

Duplicate of #135


netset update networks described in plan not correct?

this is a cosmetic issue in the plan/output.
When you add a network to an existing netset, (it works) but the tf apply seems to indicate a "-" next to the the existing networks, leading you to believe there will be network deletions from the netset, but that is not the case.  It does work and does the right thing, but just wanted to raise awareness.
let me know if you need screengrabs or more info.

We will look into this and back to you

Hi @rismoney ,
Not able to reproduce. We are getting below
Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the
following symbols:
~ update in-place
Terraform will perform the following actions:
oneview_network_set.NetworkSet will be updated in-place
~ resource "oneview_network_set" "NetworkSet" {
id                      = "TestNetworkSet"
name                    = "TestNetworkSet"
- network_set_type        = "Regular" -> null
# (12 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
Please share the screenshot and the configuration file

Did not hear from you. Closing it here. Please it


Add hack scripts to run tests in containers.

These scripts will make it easy to run each of these tests in the same
container that is used to run it in CI.

This is a prerequisite for https://github.com/metal3-io/project-infra/issues/18

/cc stbenjam

/lgtm


add support for MinGW

When cmake build gcov target, The following error occurred：
The process cannot access the file because it is being used by another process

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines           20        20
=========================================
  Hits            20        20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78d5f3...cc98e93. Read the comment docs.

Does this also work in the Windows-Subsystem für Linux?
Does win64 have /dev/null?

Does this also work in the Windows-Subsystem für Linux?
Does win64 have /dev/null?

I think WSL is a Linux, and MinGW will not be used at this time
According to my test, for Windows 10, dir > /dev/null is also effective in cmd (also powershell), but it will report an error "The process cannot access the file because it is being used by another process" when executing multiple processes. Perhaps this time Windows treats /dev/null as a real file, but dir > NUL can be executed in multiple processes in cmd.

In my Windows 10 VM I'm not able to use > /dev/null. > NUL works in cmd, but Powershell isn't able to use this either, as it asks me to create these virtual files.

Does this also work in the Windows-Subsystem für Linux?
Does win64 have /dev/null?

I think WSL is a Linux, and MinGW will not be used at this time

Probably my question should be: is win32 set in cmake for WSL, or is it successfully identified as linux in cmake?

According to my test, for Windows 10, dir > /dev/null is also effective in cmd (also powershell), but it will report an error "The process cannot access the file because it is being used by another process" when executing multiple processes. Perhaps this time Windows treats /dev/null as a real file, but dir > NUL can be executed in multiple processes in cmd.

Is win32 set in cmake on a 64-bit windows? I was wondering, why you only use NUL for win32.

In my Windows 10 VM I'm not able to use > /dev/null. > NUL works in cmd, but Powershell isn't able to use this either, as it asks me to create these virtual files.

Sorry, it's my problem.
I checked it carefully. It turns out that my D drive happened to have the folder dev. I tested > /dev/null under D drive. In fact, it was written to the D:/dev/null file, so I felt successful.
So /dev/null cannot be used under windows (I also felt very strange at first).
The equivalent method under cmd is > NUL, and > $null PowerShell.
Because cmake --build does not call PowerShell, even if executed under PowerShell, it is always possible to use NUL under WIN32.

If CMake doesn't run Powershell, even if its run in Powershell itself, this should be fine.

Is win32 set in cmake on a 64-bit windows? I was wondering, why you only use NUL for win32.

@jprotze according to the CMake docs WIN32 is set for 32 and 64bit. I don't know if this covers Windows on arm, too.

According to this answer on Stack Overflow CMake's execute_process() function can truncate the stdout of a command. Maybe we could use this to silence the output platform independent?

According to this answer on Stack Overflow CMake's execute_process() function can truncate the stdout of a command. Maybe we could use this to silence the output platform independent?

execute_process () can only be used in the configuration phase, not in the build phase?

That's right, but you can call another CMake command in the build phase by using ${CMAKE_COMMAND}. As the answer on Stack Overflow suggests an separate CMake file needs to be used to execute the process. If we could avoid the extra file and pass the command via parameter, this could be a portable solution for this problem.

Does this also work in the Windows-Subsystem für Linux?
Does win64 have /dev/null?

I think WSL is a Linux, and MinGW will not be used at this time

Probably my question should be: is win32 set in cmake for WSL, or is it successfully identified as linux in cmake?

According to my test, for Windows 10, dir > /dev/null is also effective in cmd (also powershell), but it will report an error "The process cannot access the file because it is being used by another process" when executing multiple processes. Perhaps this time Windows treats /dev/null as a real file, but dir > NUL can be executed in multiple processes in cmd.

Is win32 set in cmake on a 64-bit windows? I was wondering, why you only use NUL for win32.

The cmake in WSL (such as ubuntu) is also installed through apt-get install cmake, so in cmake it can be determined to be a linux system and WIN32 is False.
I installed WSL ubuntu 18.04 and did a test, the result is indeed the case.
yes, it can be found in the cmake documentation as mentioned above. But may use CMAKE_HOST_SYSTEM_NAME without ambiguity.So I suggest changing to this if(CMAKE_HOST_SYSTEM_NAME MATCHES "Windows")

@zhongpan I would like to stay at WIN32, as this is the official way provided by CMake.

I modified the title of this PR, because this PR only solves 1.1 in the following features.

support Windows
1.1 MinGW + MinGW Makefile + gcov
1.2 MinGW + MinGW Makefile + lcov
1.3 MinGW + Ninja + gcov
1.4 MinGW + Ninja + lcov
1.5 Clang + MinGW Makefile + gcov
1.6 Clang + MinGW Makefile + lcov
1.7 Clang + Ninja + gcov
1.8 Clang + Ninja + lcov
......

@zhongpan I would like to stay at WIN32, as this is the official way provided by CMake.

WIN32 is okay. It is the name of the OS. It is used in history and does not represent the CPU architecture.
However, CMAKE_HOST_SYSTEM_NAME is also officially provided by CMake, and the effect should be the same.


Issue Template Addition

This PR adds an issue template to the project.

@TylerGillson feel free to add fields or anything else you would like 😄


Migration error: unable to create type with index

EdgeDB Version: 1.0-alpha.2+dev.505.g5b68ec24

Steps to Reproduce:
Running this migration
START TRANSACTION;
CREATE MIGRATION test TO {
    module default {
        type Author {
            required property name -> str;
        }

        type Comment {
            required property body -> str;
        }

        type CommentRating {
            required link author -> Author;
            required link comment -> Comment;

            index on ((__subject__.author, __subject__.comment));
        }
    }
};
COMMIT MIGRATION test;
COMMIT;

results in crypric error: InvalidReferenceError: schema item 'default::__|author@@default|CommentRating' does not exist
It looks like there is a problem with index creation: creating type before migration works. Working code:
START TRANSACTION;

CREATE TYPE CommentRating;  # <----- added

CREATE MIGRATION test TO {
    module default {
        type Author {
            required property name -> str;
        }

        type Comment {
            required property body -> str;
        }

        type CommentRating {
            required link author -> Author;
            required link comment -> Comment;

            index on ((__subject__.author, __subject__.comment));
        }
    }
};
COMMIT MIGRATION test;
COMMIT;

Confirmed.  This is a DDL dependency sorting bug.


build fails with issue with rss blade source template

Tried building the docs template which worked fine, when building the blog template it errors at the build stage for the rss template
In b1bd50064881d5d5fd15ab8102895a60541340af.php line 1:

  syntax error, unexpected 'version' (T_STRING) (View: /home/chris/blog/sourc
  e/_layouts/rss.blade.php) (View: /home/chris/blog/source/_layouts/rss.blade
  .php)

build [--pretty PRETTY] [-c|--cache [CACHE]] [--] [<env>]

I can't reproduce this issue; did you alter rss.blade.php in any way? Can you tell me a little bit about your system setup?

https://asciinema.org/a/tXpjZRjcHddYf9AwVGZYYmn0m
here is a quick video of me building it.
on ubuntu with php v7.2.13, node v10.14.2 and npm v6.5.0

I just pushed an update to the blog template (v1.0.3) that should fix the issue...could you give it a shot on a fresh install?

yes, builds fine now, thanks


Make secret volume plugin use tmpfs storage

Fixes #4602; split from #4625; depends on #5162

@thockin @erictune @smarterclayton @markturansky

assign @erictune because it's a followup to  #5162

Closing this since its parent was closed too. Feel free to send the other PR and I'll be happy to review :)


NET-enabling start-tag requires SHORTTAG YES

I'm using Hugo 0.16 and it's automatically adding the generator META tag to my home page, causing a warning and an error in http://validator.w3.org/ as a result of the trailing forward-slash:
<meta name="generator" content="Hugo 0.16" />

Message from the validator:

For the current document, the validator interprets strings like <FOO /> according to legacy rules that break the expectations of most authors and thus cause confusing warnings and error messages from the validator. This interpretation is triggered by HTML 4 documents or other SGML-based HTML documents. To avoid the messages, simply remove the "/" character in such contexts. NB: If you expect <FOO /> to be interpreted as an XML-compatible "self-closing" tag, then you need to use XHTML or HTML5.

This warning and related errors may also be caused by an unquoted attribute value containing one or more "/". Example: W3C. In such cases, the solution is to put quotation marks around the value.

Would you entertain a PR to remove the trailing forward-slash from the META tag? I'm attempting to create a theme using HTML 2.0 and don't see another way to avoid this hiccup given the auto-generated code.

Closing this to help keep the repo clean.


Proposal: Add helper command that fills out version numbers for github issues

Description
Its probably considered a toy more than a tool, but recently I got into submitting issues and amongst other things, filling out version numbers is a little inconvenient. This simple command helps with that.

[x] Visual changes (if any) are shown using screenshots/recordings of before and after.

Code style

[ ] composer cs command has been run.

Testing

[ ] Changes have been tested.

Documentation

[ ] Documentation is up-to-date.

Thanks


fix: remove duplicate receiver check

This check is already done by validateBridgeData.

please pull to fix the forge test


more typing

Codecov Report

Merging #100 (e4b6bbb) into master (1ef9da2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   81.15%   81.07%   -0.08%
==========================================
  Files          11       11
  Lines         987      983       -4
==========================================
- Hits          801      797       -4
  Misses        186      186

Impacted Files
Coverage Δ

src/JET.jl
44.44% <100.00%> (ø)

src/reports.jl
87.37% <100.00%> (-0.19%)
:arrow_down:

src/typeinfer.jl
100.00% <100.00%> (ø)

src/abstractinterpretation.jl
95.95% <0.00%> (-1.02%)
:arrow_down:

src/print.jl
79.59% <0.00%> (+0.80%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef9da2...e4b6bbb. Read the comment docs.


Fix overwriting config_section definitions:

"name" and "param_name" is strongly connected with plugin's code (even in base classes)
so these MUST be not changed by subclasses (subclass MUST use same names)
separate "param_name" from "name" to detect overwriting "param_name" by subclasses to raise errors
and add "variable_name" method as internal utility
make it possible to change default values in finalized sections
because it's very popular that 3rd party plugin prefer different default value for built-in predefined parameters
make it possible to change "init" specification of finalized sections
because newly added/changed default values might be able to init sections

@repeatedly @sonots I'll merge this later if there's no objection.


Update Dart library to new algorithms

Update Dart library to use integer algorithms for encode and decode (issues #313 and #307).
Also fix bug in computeLatitudePrecision, add test and add benchmark tests.

Hi @zongweil can you check this please? All fixed and reformatted.


Blog Post Spacing

Adjust Blog Post spacing to be consistent with the FJ visual spacing rhythm
Changes

Updated ' static/css/post.less' to adjust margins to be consistent with the FJ visual spacing rhythm.

Review

@jimmynotjim
@anselmbradford
@duelj

Preview

:+1:

:+1:


Unit 3 Sections 14-15 Hacks Submissions

Comment your Hacks review tickets here! :D

Alex's Hacks

Aaron's Hacks

Alexa Carlson's Hacks

Mati Danish's Hacks

Kaiden's Hacks

Amay's Hacks

Ava Carlson's Hacks

Claire Zhao's Hacks

Liav Bar's Hacks

Jake's Hacks

Annika Liao's Hacks

David's Hacks

Nathan's Hacks

Ederick's Hacks

Steven Zhu's Hacks

Claire's Hacks

Sri's Hacks

Shruthi's Hacks

Jeongwoo Lee's Hack

Luka review ticket

Taiyo's Hacks

Safin's hacks
I spoke to Saavan today in class regarding an extension.

Luna's

yasha's hacks


[WFLY-11764] Expose UndertowOptions.PRESERVE_PATH_ON_FORWARD in Under…

…tow settings
JIRA: https://issues.jboss.org/browse/WFLY-11764

I'm not sure if the undertow xsd version needs to be bumped as well for this change.
@fl4via could you review please?

This would need transformation handling so having this in a domain mode config where legacy slaves are used would be handled properly.

This doesn't seem like it is about a listener resource. It seems like it controls the behavior of the servlet container, which has its own resource.

Is this a legitimately configurable behavior (i.e. multiple correct settings), or is this just a case of we had a bug, we fixed the bug, but some people may have been relying on the buggy behavior so we want a flag to let those people opt out of the fix?
If so just using the system property and logging a WARN if anyone sets it to the value that indicates wanting the buggy behavior seems appropriate. WARN should state the setting may be removed in a future release.

@bstansberry yes I think it's more of an opt-out then actual configuration option. I'll rewrite this to use system property tomorrow morning. Thanks.

@bstansberry the behavior is not buggy. It is just that it is different from previous server, and although the spec doesn't enforce one way or another, some users were relying on the behavior of previous server. However, if we change that behavior out of the blue to be compatible to previous server, we may end up in the same situation with users relying on the way Undertow has behaved so far. That's why the property was created, to allow toggling between two different, acceptable, behaviors.
As per @bmaxwell, this property may be removed in the future if we decide to stick to the new behavior, the one that mimicks previous server.

@bstansberry  / @fl4via - yeah so I'm not a struts expert, but I know a little JSF, so based on JBEAP-16397 it looks like struts actions are like JSF where mappings where you would go to page.faces which is page.xhtml but routed through the Servlet which does the magic.  So it looks like in EAP 6 user went to page.action which does the magic on page.jsp , and either the customer app or the 3rd party thing they were using needs to know the path that was navigated to , and in EAP 7 we are returning the resolved for lack of better word path, when it needs the other.  So if we change this again in the future we should deprecate it and warn people using that system property and also have a response for Struts and other use cases like this as to what they should be using if getServletPath / getRequestURI is not correct.

Just to make sure I get it right this time :) - it sounds like this should be a management option rather than system property after all (since both behaviours are acceptable)?

@spyrkob
It's up to @fl4via whether she wants to support the current (without this fix) behavior in the future or whether she intends to remove it and standardize on the "EAP 6 way".
@fl4via if you know you'll support it, or you're not sure, use a management attribute.  If you know you're going to move to the "EAP 6 way" only, then the system property is fine.
Don't use a system property for the "I'm not sure yet" case. If we're not sure, that means that today both are valid options and that means we should have a management attribute. We don't use a system property for a valid configuration option. We use those for workarounds.
You could even add a management attribute and deprecate it! That in effect exposes a proper config option but says it may go away.
This is all a bit legalistic I know.

@bstansberry sorry for missing this comment. I think it should be an attribute, following the line of thinking that this is not a bug and might be something that users will want to configure.

@spyrkob since we are on a tight schedule for the code freeze, we decided to move forward with the system property. I'll wait for the PR to be rebased before reviewing. Thanks a lot for your work on this!

@jstourac @fl4via @spyrkob I have updated the PR to address various points made

retest this please

This has passed the tests once and @kabir has confirmed the changes are okay so I've added the ready-to-merge label.

@jamezp @bstansberry I am adding the feature label to remind you to close out a the rfe paperwork. It should be good to go


WIP: Eliminate the use of io.fabric8:kubernetes-api.

This is currently work in progress and shouldn't be merged yet.
Removed the use of Controller and KubernetesHelper where possible.
We still need KubernetesHelper for the getServiceURL(), so I created the following feature request in the kubernetes-client side:
https://github.com/fabric8io/kubernetes-client/issues/1139
Also, in some cases, some utility functions are used from KubernetesHelper (like nullsafe gets and name sanitizations). Created a feature request for those too:
https://github.com/fabric8io/kubernetes-client/issues/1140

Ike Plugins (test-keeper)
Thank you @iocanel for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

@iocanel don't forget to update the pom.xml to remove the dependency on io.fabric8:kubernetes-api

@iocanel any progress in this? We'll probably require the Impersonate user feature implemented in https://github.com/fabric8io/kubernetes-client/pull/1117 (which isn't available in our current version of the kubernetes-client)

Reopening a separate PR as I don't have rights to update this.


[BEAM-13210] [Playground]: support streaming output on the frontend

Please add a meaningful description for your change here
I added support streaming output and handling new execution statuses on the frontend.
Now execution status provides an output that is showing at the UI before finishing execution.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @damondouglas
cc: @pabloem


Add ssl script

opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Enhancement

Github Issue # or road-map entry, if available:
Certificate management tool

Description of changes:
Added a script that will create self-signed certificates and keys that are more secure than the demo configurations.

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1530 (48a8d50) into main (ff4432b) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1530      +/-   ##
============================================
- Coverage     64.85%   64.82%   -0.03%
- Complexity     3227     3228       +1
============================================
  Files           247      247
  Lines         17335    17335
  Branches       3072     3072
============================================
- Hits          11242    11237       -5
- Misses         4536     4542       +6
+ Partials       1557     1556       -1

Impacted Files
Coverage Δ

...org/opensearch/security/rest/TenantInfoAction.java
77.94% <0.00%> (-10.30%)
:arrow_down:

...a/org/opensearch/security/tools/SecurityAdmin.java
47.52% <0.00%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4432b...48a8d50. Read the comment docs.

Hi @opensearch-project/security team, could someone please review these changes? Thanks!

@opensearch-project/security Nudge!  Nudge McNudgeFace!

How has this change been tested, I think that the current process might not work for multi-node clusters.

Manually tested on latest opensearch release distribution, by replacing the existing install_demo_configuration.sh script with this new version.

How has this change been tested, I think that the current process might not work for multi-node clusters.

Manually tested on latest opensearch release distribution, by replacing the existing install_demo_configuration.sh script with this new version and running the tool to setup certificates and related settings.

If you try installing security plugin 1.3.00 on OpenSearch 1.3.0 after running the script install_demo_configuration.sh, you'll see the issue. Security plugin cannot be installed correctly.


Improve outline view management on new feeds

Followup of #1445

I haven't tested but I did review the code and it looks like it works 😛


et_pb_generate_responsive_css() not working for 'color-alpha' field

Problem Description
I enabled resposive settings for the 'color-alpha' field and tried to generate the responsive CSS using the et_pb_generate_responsive_css() function but it did not work.
The responsiveness is enabled in VB (tablet and phone tabs are activated and colors selected for all devices) but the problem is with the CSS generated ( and not generated :) ) on the frontend.
Issue 1:
The responsive CSS is not being generated for tablet and phone on the frontend, but only for desktop. But that one is not applied neither because of the issue 2 below.
Issue 2 :
There is a 0(zero) added to the color code which makes it invalid. For example, #ffffff is printed as 0#ffffff, and if the color code contains a 0(zero) it gets removed, like this: #8300e9 becomes 0#83e9. The same happens to rgba color.
I am sure I'm missing something :) . Any help appreciated. Thanks.
Steps To Reproduce
1. Add the color-alpha field
'header_bg_clr' => array(
	'label'           => esc_html__( 'Background Color', '' ),
	'type'            => 'color-alpha',
	'option_category' => 'basic_option',
        'mobile_options'    => true,
        'responsive'        => true,
        'custom_color'    => true,
        'description'     => esc_html__('Description.', ''),
        'default'         => '',
	'tab_slug'        => 'advanced',
	'toggle_slug'     => 'header_toggle',
),

2. Implement the responsive CSS generation
$header_bg_clr = $this->props['header_bg_clr'];
$header_bg_clr_tablet = $this->props['header_bg_clr_tablet'];
$header_bg_clr_phone = $this->props['header_bg_clr_phone'];
$header_bg_clr_last_edited = $this->props['header_bg_clr_last_edited'];

if ( '' !== $header_bg_clr_tablet || '' !== $header_bg_clr_phone || '' !== $header_bg_clr ) {
        $header_bg_clr_responsive_active = et_pb_get_responsive_status( $header_bg_clr_last_edited[0] );

        $header_bg_clr_values = array(
            'desktop' => $header_bg_clr,
            'tablet'  => $header_bg_clr_responsive_active ? $header_bg_clr_tablet : '',
            'phone'   => $header_bg_clr_responsive_active ? $header_bg_clr_phone : '',
        );

        et_pb_generate_responsive_css( $header_bg_clr_values, '%%order_class%% .header', 'background-color', $render_slug );
}

Screenshot and/or gif

Hi @IvanChiurcci, there is new method to generate responsive settings and accept all field types. It's called et_pb_responsive_options()->generate_responsive_css. It has similar argument with et_pb_generate_responsive_css except additional parameter to determine what is the current field type to use here.
/**
 * Generates the css code for responsive options.
 *
 * Uses array of values for each device as input parameter and css_selector with property to
 * apply the css.
 *
 * Copy of et_pb_generate_responsive_css() with some modifications to improve.
 *
 * @since 3.23
 *
 * @param  array  $values_array   All device values.
 * @param  mixed $css_selector    CSS selector.
 * @param  string $css_property   CSS property.
 * @param  string $function_name  Module slug.
 * @param  string $additional_css Additional CSS.
 * @param  string $type           Value type to determine need filter or not. Previously, it only
 *                                accept value from range control and run a function to process
 *                                range value.
 * @param  string $priority       CSS style declaration priority.
 */
et_pb_responsive_options()->generate_responsive_css( $values_array, $css_selector, $css_property, $function_name, $additional_css = '', $type = 'range', $priority = '' );

For example, to process color-alpha field type, you need to pass color on the 6th argument.
et_pb_responsive_options()->generate_responsive_css( $open_toggle_background_color_values, '%%order_class%% .et_pb_toggle_open', 'background-color', $render_slug, '', 'color' );

Thank you @ayubadiputra , this one works properly. Is there an equivalent JS function for VB part as well?

@IvanChiurcci Unfortunately, there is no similar Utils method available for 3PS yet. But, there is an open issue for that, you can follow it here https://github.com/elegantthemes/create-divi-extension/issues/115. Some people also discuss about responsive CSS here https://github.com/elegantthemes/create-divi-extension/issues/143, maybe it can help you.
Since the main question in current issue is answered, I will close it. Thank you.


Safely Handle Various Arguments in Calls to Promise.reject()

Resolves redux-saga/redux-saga#1395
I found the issue with redux-saga/redux-saga#1395, and there are several layers:

Rejecting a promise with undefined does actually crash sagas. This is a fairly easy fix.

A promise with an unhandled reject() that has an argument other than an Error() object causes that rejection to skip the onError method and just write to the console. This one is a bit more hairy, because the failure is silent in that we can't log it on our end.

The simplest possible solution I can think of is to convert the first argument passed into reject() into an Error() object for promises only... this is a bit dishonest because it's not technically what got passed into reject() but it's not so bad because we're already handling reject() like it's an error anyways
@Andarist Thoughts?

@max-winderbaum dont worry about CI, its a separate problem

@Andarist Ok, this should do it!

Thanks!


Add the Jest automated testing library

As a project manager I will require components be tested using the Jest automated test framework so that we can ensure the components are working as designed over time.
https://jestjs.io/docs/tutorial-react

Added Jest and all dependencies on may2023 branch.


Sitemap collector tries downloading/parsing image files.

Sitemap collector tries downloading/parsing image files (ie: PNG)
It appears it only exclude PDF files, but perhaps it should only be including htm/html files instead?

@skidvis Any idea on the best angle to attack this?

Curiously, not sure why it avoids PDF documents, as those can be parsed. Perhaps a SiteMap w/PDF and SiteMap w/o PDF could be handy.

@Mike-Benoit  What sitemap are you using? So I can test this

@timothycarambat There's a PR to block images.
@Mike-Benoit PDFs are only parsed in the hotdir folder. Using the sitemap feature to parse them would require downloading them to a temp folder somewhere, parsing them, and then deleting them. That feature currently does not exist, and it would also be problematic storage-wise if there were many large pdfs.
If enough people ask for this, it may be worth implementing, but currently the hotdir should be where pdfs are handled.

resolved by #56


hls-<IP_ADDRESS> installer returns 404

Problem description
Trying to install the hls language server fails with the following error:
[ERROR Wed 27 Apr 2022 03:33:27 PM CEST] ...installer/lua/nvim-lsp-installer/core/installer/init.lua:79: Installation failed, name="hls", error='...taller/lua/nvim-lsp-installer/core/managers/std/init.lua:61: Failed to download file "https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz".\nspawn: curl failed with exit code 22. curl: (22) The requested URL returned error: 404 \n'
And indeed, https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz does result in a 404.
It looks like from <IP_ADDRESS>, the binaries are placed in a different place. https://github.com/haskell/haskell-language-server/releases/ has a link to https://downloads.haskell.org/~hls/haskell-language-server-<IP_ADDRESS>/ which lists different binaries for this language server.  It also notes "Subsequent releases will also be available at https://downloads.haskell.org/~hls"
Neovim version (>= 0.6)
NVIM v0.7.0
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by runner@fv-az316-460
Operating system/version
<IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 GNU/Linux
I've recently downloaded the latest plugin version of both nvim-lsp-installer and nvim-lspconfig

[X] Yes

Affected language servers
hls
Actual behavior
I get the error:
[ERROR Wed 27 Apr 2022 03:33:27 PM CEST] ...installer/lua/nvim-lsp-installer/core/installer/init.lua:79: Installation failed, name="hls", error='...taller/lua/nvim-lsp-installer/core/managers/std/init.lua:61: Failed to download file "https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz".\nspawn: curl failed with exit code 22. curl: (22) The requested URL returned error: 404 \n'
Expected behavior
A version of hls is installed.
LspInstallInfo output
Downloading file "https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz"...
        ...taller/lua/nvim-lsp-installer/core/managers/std/init.lua:61: Failed to download file "https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz".
        spawn: curl failed with exit code 22. curl: (22) The requested URL returned error: 404

Installation log
[INFO  Wed 27 Apr 2022 03:40:42 PM CEST] ...-installer/lua/nvim-lsp-installer/ui/status-win/init.lua:682: Starting install server_name="hls", requested_version=""
[ERROR Wed 27 Apr 2022 03:40:42 PM CEST] ...rt/nvim-lsp-installer/lua/nvim-lsp-installer/process.lua:153: Failed to spawn process. cmd="gh", err="ENOENT: no such file or directory"
[ERROR Wed 27 Apr 2022 03:40:44 PM CEST] ...installer/lua/nvim-lsp-installer/core/installer/init.lua:79: Installation failed, name="hls", error='...taller/lua/nvim-lsp-installer/core/managers/std/init.lua:61: Failed to download file "https://github.com/haskell/haskell-language-server/releases/download/<IP_ADDRESS>/haskell-language-server-Linux-<IP_ADDRESS>.tar.gz".\nspawn: curl failed with exit code 22. curl: (22) The requested URL returned error: 404 \n'
[INFO  Wed 27 Apr 2022 03:40:44 PM CEST] ...-installer/lua/nvim-lsp-installer/ui/status-win/init.lua:701: Installation completed server_name="hls", success=false

Healthcheck
nvim-lsp-installer: require("nvim-lsp-installer.health").check()
========================================================================
## nvim-lsp-installer report
  - OK: neovim version >= 0.6.0
  - WARNING: **Go**: not available
  - WARNING: **Composer**: not available
  - WARNING: **PHP**: not available
  - WARNING: **javac**: not available
  - WARNING: **java**: not available
  - WARNING: **julia**: not available
  - OK: **bash**: `GNU bash, version 5.1.4(1)-release (x86_64-pc-linux-gnu)`
  - OK: **gzip**: `gzip 1.10`
  - OK: **curl**: `curl 7.74.0 (x86_64-pc-linux-gnu) libcurl/7.74.0 OpenSSL/1.1.1n zlib/1.2.11 brotli/1.0.9 libidn2/2.3.0 libpsl/0.21.0 (+libidn2/2.3.0) libssh2/1.9.0 nghttp2/1.43.0 librtmp/2.3`
  - OK: **wget**: `GNU Wget 1.21 built on linux-gnu.`
  - WARNING: **pip3**: not available
  - OK: **python3**: `Python 3.9.2`
  - ERROR: **node**: unsupported version `v12.22.5`. Node version must be >= 14
  - OK: **npm**: `7.5.2`
  - OK: **RubyGem**: `3.2.5`
  - OK: **Ruby**: `ruby 2.7.4p191 (2021-07-07 revision a21a3b7d23) [x86_64-linux-gnu]`
  - OK: **cargo**: `cargo 1.58.0 (7f08ace4f 2021-11-24)`
  - OK: **sh**: `Ok`
  - OK: **tar**: `tar (GNU tar) 1.3

Screenshots
No response

Looking at the releases page of the haskell language server is appears they've moved the packaged releases to their site per the latest release. They're now hosted at https://downloads.haskell.org/~hls/.
The current target attempts to get the lsp on github, which they no longer provide there.

I noticed there are some shell executables at the root of the tar file (ending with .in). The "old" executables are now located inside bin/. Does anyone know the difference, which one is preferred?

Is there a way to download an older version of hls as a workaround for this problem until it gets sorted?

@cdimitroulas :LspInstall<EMAIL_ADDRESS>should work 🤞

fix/hls-install (#651) ought to fix this. Detecting Linux distro is a bit of a hassle, so for now I've resorted to prompting the user which archive to download, like so:
https://asciinema.org/a/DVoMB32hq4xZXeYU0fgIu0wl8

Installing now works indeed. One side note is that installing older versions no longer works.
One issue I have, but I am not sure if it is this plugin's problem, or of haskell-language-server. The hls that is installed is now dynamically linked, and gives me the following issue (in ~/.cache/nvim/lsp.log):

[ERROR][2022-05-03 07:48:45] .../vim/lsp/rpc.lua:420	"rpc"	"haskell-language-server-wrapper"	"stderr"	"/home/thonoht/.local/share/nvim/lsp_servers/haskell/bin/haskell-language-server-8.10.7: error while loading shared libraries: libHSCabal-<IP_ADDRESS>-ghc8.10.7.so: cannot open shared object file: No such file or directory\n"

I have been able to work around this for now by using ghcup to install hls, and symlinking ~/.local/share/nvim/lsp_servers/haskell/bin (after renaming the original folder) to ~/.ghcup/bin, so it is tricked into using the ghcup version which does work.
I believe (but haven't checked) that the vscode plugin used ghcup to install hls. And I found that it is possible to use ghcup install hls VERSION -i TARGET_PATH to tell ghcup to install to a specific location. Would this maybe be a way to install hls here as well? It also seems to automatically choose the right version for your distribution.
The directory structure seems to have changed though.
ghcup install hls <IP_ADDRESS> -i TARGET_PATH Seems to place all binaries statically linked directly in the specified path.
ghcup install hls <IP_ADDRESS> -i TARGET_PATH Creates a structure:
bin\
  all binaries (statically linked)
lib\haskell-language-server-<IP_ADDRESS>\
  bin\
    all binaries (dynamically linked)
  lib\
    libraries per version

And I found that it is possible to use ghcup install hls VERSION -i TARGET_PATH to tell ghcup to install to a specific location. Would this maybe be a way to install hls here as well?

This seems much better, will look into this ASAP. Otherwise, PRs always welcome!


Collocate handlers by protocol

It would be better to collocate handlers by protocol as mentioned in #17.
I'm still not sure whether to keep them in handlers folder and group by "protocol" folders or put them directly into protocols to given protocol. I tried to keep minimal dependencies between protocols and the second option would make it worse.

Solved by #23


Argument "name" is missing

It looks like argument/input "name" is missing, this is required for output variables/dependencies.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0e444c2-69c6-4d71-6fd0-94d0f4097d3a
Version Independent ID: 3a727833-1cc3-c2fb-c5b3-22605eee2721
Content: PowerShell task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/powershell.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vtbassmatt
Microsoft Alias: macoope

@pnwguy -- thank you for your feedback.
@vtbassmatt -- please supply the prose, and I'll create a PR to update this article.

Any task can have a name (or env, or displayName, or one of several other properties). They are not documented on each task; they're documented in the YAML schema section on "steps".


hover.mode = 'dataset' throwing error

I am playing with ChartJS 2.0.0-alpha.
When I am setting Line chart's config hover.mode to dataset, its throwing up an error, telling this.getDatasetAtEvent is not defined.
I did not find a definition for this function in the code. While I found definitions for this.getElementAtEvent and this.getElementsAtEvent responsible for hover modes label and single.

Note: Collaborator, please add the relevant milestone

Is this fixed in the proposed alpha3 release @tannerlinsley?

Closing as #1458 was merged.


Note population interpretation

          There should probably a note somewhere (perhaps not right here though) that this is like having 4000 towns/cities so results need to be interpreted accordingly - this is probably most relevant to outbreaks where 1 outbreak with 10 infections could behave quite differently to 10 outbreaks with 1 infection

Originally posted by @RomeshA in https://github.com/amath-idm/starsim/pull/235#discussion_r1496504937
Also: "Not sure where the 50 million came from?"

I think we can close this; if this comes up again as we review the tutorials then we can address it then.


Document where to pull Workspace{Key,Id} from

WorkspaceId is visible in the Properties blade, but current portal design makes it unintuitive to determine where WorkspaceKey is found.
It's actually under Advanced Settings > VMs > {Linux | Windows} - there's a different key per OS.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cefed4e0-440d-18d5-8b8d-4a345f396e9b
Version Independent ID: 2882136f-7fde-685d-c24f-037ee7626667
Content: Azure Monitor virtual machine extension for Windows
Content Source: articles/virtual-machines/extensions/oms-windows.md
Service: virtual-machines-windows
GitHub Login: @roiyz-msft
Microsoft Alias: roiyz

Thanks for the feedback! We are currently investigating and will update you shortly.

@stewartadam
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

actually they've moved again - the Advanced Settings menu is gone. Click on the "Quick Starts" menu to find the workspace id and keys

@a30001539 Thanks for the update.
@roiyz-msft The doc would need to be updated as view is updated again. Thanks :)

Via powershell:
##Get Workspace ID
$workspaceId = Get-AzOperationalInsightsWorkspace -Name $LAWorkspaceName -ResourceGroupName $ResourceGroupName
##Get Workspace Key
$workspacekey = Get-AzOperationalInsightsWorkspaceSharedKey -ResourceGroupName $ResourceGroupName -Name $LAWorkspaceName
$PublicSettings = @{ "workspaceID" = $workspaceId.CustomerId}
$ProtectedSettings = @{ "workspacekey" = $workspacekey.PrimarySharedKey}

@cynthn Can you please help assign this to the right person as roiyz is not in the team anymore. Thanks :)

@Karishma-Tiwari-MSFT I have a spreadsheet of owners. I'll ping you offiline.

#reassign: @MicahMcKittrick-MSFT

This is already mentioned in the doc

#please-close

That's pretty vague. Besides being more specific on where it can be found (which is nested 3 levels deep in settings menus), there's also no mention of the OS-specific keys in our current docs.


Make it easy for users to override

https://colcon.readthedocs.io/en/released/user/overriding-packages.html#how-to-make-it-easier-for-your-users-to-override

Have you tested this locally to prove that it works?


RecursionError: maximum recursion depth exceeded in comparison

I get RecursionError: maximum recursion depth exceeded in comparison when i try to start many sessions using asyncio
This is my code:

It works for 8 iterations, and fails with RecursionError
Stacktrace:

What i'm doing wrong? Or it's bug? Works perfect with only one session

The same issue, everything was good with one account at tdata if more than get 'maximum recursion depth exceeded'

У меня такая же проблема возникла . С одной записью tdata. Видимо это зависит от конктеных tdata. Некоторые конвертируются, другие нет.

Unfortunately, I couldn't replicate this bug, can you provide more information?
This recursive error is weird, I don't understand how it could happen.
Can you change the tdesktop.py line 666
From this:
 account.api = value

To this:
if account.api != value:
    account.api = value

And see what would happen?

Unfortunately, I couldn't replicate this bug, can you provide more information? This recursive error is weird, I don't understand how it could happen. Can you change the tdesktop.py line 666 From this:
 account.api = value

To this:
if account.api != value:
    account.api = value

And see what would happen?

I tried it and nothing changed.
P.S To reproduce the error try to convert tdata which contains at least 2 accounts or more, the error does not occur if the account is one

if account.api != value:
    account.api = value

tdesk = TDesktop("tdata", api=oldAPI)

File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\tdesktop.py", line 141, in init
self.LoadTData()
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\tdesktop.py", line 203, in LoadTData
self.__loadFromTData()
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\tdesktop.py", line 438, in __loadFromTData
account = td.Account(
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\account.py", line 661, in init
self.api = api.copy()
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\account.py", line 679, in api
self.owner.api = self.api
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\opentele\td\tdesktop.py", line 667, in api
Here's the beginning of the recursion issue

Any updates?

in tdesktop.py, comment two lines
    @api.setter
    def api(self, value) -> None:
        self.__api = value
        # for account in self.accounts:
        #     account.api = value

The fix above works on the multi-account tdata and is selects the latest active account to work with


[pentest] Cherry-pick Fix bugs in AES SCA

This PR manually cherry-picks "Fix bugs in AES SCA" #21784 as the automatic cherry-pick failed due to a merge conflict.

Thanks for the review, this PR can be merged as the CI failure is not related to the changes.


[TypeScript] Fix and improve type definition

Fix broken type definition
I find some type such as combinations and permutations return Iterable<T> (array of scalars) instead of Iterable<T[]> (array of arrays). This makes no sense to me, so I decided to fix it.
Improve type definition
TypeScript 3.0+ allows users to use tuple generic arguments which I take advantage of to have more accurate function annotations.
Function definitions I changed are: combinations, combinationWithReplacement, permutations, and product.
Added dependencies
I added typescript-tuple as a production dependency (which I created and maintain) to utilize its generic utilities (such as Repeat, Prepend, Reverse).
Potential Breaking Changes
JavaScript users are unaffected.
On TypeScript side, this change requires TypeScript version 3.0 or later, but it's OK since TypeScript is completely useless prior to https://github.com/sithmel/iter-tools/pull/54 ~(i.e. right now)~.
TL;DR No breaking changes.
Additional Changes
This pull request includes changes from https://github.com/sithmel/iter-tools/pull/54 because any change of type definition without type definition being detected is useless.
Additional Requests

Is it OK if I add myself as a CODEOWNER of *.ts files? Because I want to make sure no one give a broken type definition.

If this were to be merged, I ask you to merge to a "experiment" branch and publish it under "rc" tag (so that I can install it) in npm so that I can do more testing in order for it to work.

@sithmel Wait! Why did you merge it directly into master, I asked you to make an "experiment" branch and publish it under "rc" tag so that I can test it better.

@KSXGitHub given your explanation about "Potential Breaking Changes" I would publish a patch release. Is that ok?
About codeowner: for now it is not necessary, given the number of contributors.
Can you add yourself to the contributors in package.json ? I think you earned it :wink:

@KSXGitHub where did you ask for that ?

About codeowner: for now it is not necessary, given the number of contributors.

It wasn't about credit. I want to make sure no one breaks TypeScript definition. Before the merging of this pull request, iter-tools has some incorrect type definition.

BTW, since you don't add me to codeowners, can you please notify me when someone change typescript files?

@KSXGitHub it will be a pleasure

@KSXGitHub before publishing: can you please have a look at typescript linting?
The project uses tslint and we are getting a few warnings now.
npm run tslint

If you don't like tslint or you know better alternatives, any input would be helpful. I added it, but I am not a TS user so I don't know the ecosystem very well.

@sithmel

The project uses tslint and we are getting a few warnings now.

It gives me warnings (in VSCode) even before I touch the code so I disabled it. But if you want me to fix it, I will. Is it OK if I add tslint to build script?

yes please

Great! I'm gonna test them.


Keymap copy-pase doesn't escape backslash

I want to change the keybinding for "cmd-\". The Settings say that I can override these keybindings by clicking on the copy button pasting them into your keymap file. When I do so for cmd-\, this is what is pasted:
'.platform-darwin':
  'cmd-\': 'tree-view:toggle'

However, when I go to save the file, it gives me an error:
Failed to load /Users/oscargarcia/.atom/keymap.cson
[stdin]:38:29: error: missing '
  'cmd-\': 'tree-view:toggle'

The correct syntax is to escape the backslash like so:
'.platform-darwin':
  'cmd-\\': 'tree-view:toggle'

This is a minor bug for an unusual use case, but I thought I would mention it.
Atom 1.11.2
OS X 10.11.6

Can you please reopen this on the atom/settings-view repository?  Thanks.

Turns out this issue is a duplicate of https://github.com/atom/settings-view/issues/363.


Table : empty state makes search columns disappear

Package
filament/tables
Package Version
v2.16.19
Laravel Version
v9.33.0
Livewire Version
v2.10.7
PHP Version
8.1.0
Problem description
The header row with the search inputs disappears and make the all things stuck.
Before :

After :

Expected behavior
That the header is isolated from the rows of data.
Event when there is no search inputs, I think it's better UI/UX that keep the header visible.
Steps to reproduce
Nothing particular, just make a search that doesn't give any data.
Reproduction repository
Filament
Relevant log output
No response

Duplicate of #4224

Sorry I didn't take a look


Update README.md

Mentioned medicaltorch in the README
I'm not sure how to add properly https://github.com/perone/medicaltorch to requirements.txt especially that this file is then read by setup.py.
I tried simply by appending the following
git+https://github.com/perone/medicaltorch

but this does not work...

Thanks @vfdev-5 !


Please release helm chart 1.0.6

Hi,
I recently had a PR approved to make some fixes to the helm chart.
I did bump the Chart.yaml version to 1.0.6, but I think a step was missing to release it like the following release.
Please could you release that helm chart.
I think perhaps some action needs to take place but I am not sure.
@liyinan926 did I miss a step in the PR process?

1.0.8 is released now anyway


Possible duplicate export template installation

Forgive me if I'm missing something, but I noticed entrypoint.sh downloads and installs export templates even though the base image also installs them. This could unnecessarily slow down actions.

Hello! Thanks for the interest in this action! :smile:
The export templates have to be installed in the user's home directory. The GitHub action's user is different from the one in the base image. Because of that, the action currently does template installation at runtime.
Though, I believe it would be possible to decrease build times for matrix builds by having it in the build action step. Also since the templates are already on the image, but with the wrong dir a move could be done instead of a download. I'll add both of those to my todo.

Correction: not user, home directory

How about copying/ moving it to the right directory in your docker file?


Array Formatting

closed in https://github.com/Sobeston/ziglearn/commit/c2b6d518c1234a81bc9f161e9aef43a0defbb76b

closed in https://github.com/Sobeston/ziglearn/commit/c2b6d518c1234a81bc9f161e9aef43a0defbb76b


Does it can continue autoplay when hover on slides?

Step:

I created a carousel and set it autoplay.
I hover on slides, it will pause autoplay.
I mouse out slides, it will continue autoplay.
I set pauseOnHover to false, and try step2 again, it will pause autoplay.
Question:
Is there any way to make slides always autoplay? Even if I hover on the slides.

I'm not sure if that's the case. I just checked again and it works as expected.

The latest version doesn't have the mentioned issue.

I'm sorry, it works.
I use react, and set pauseOnHover="false" which it the wrong way to set value.
I change code to pause OnHover={false}, it works.

Step:

I created a carousel and set it autoplay.
I hover on slides, it will pause autoplay.
I mouse out slides, it will continue autoplay.
I set pauseOnHover to false, and try step2 again, it will pause autoplay.
Question:
Is there any way to make slides always autoplay? Even if I hover on the slides.

yes you should to add another property in your object autoplay: true
instead of pauseOnHover


feat: add validation and filtering to SimpleIndexer

This PR adds validation and filtering to ensure that docs inserted into the indexer are valid and have valid embedding (all with the same shape) and also filter out any existing docs in index that have invalid embedding so that we don't run into situations where if one doc indexed is invalid, then all subsequent searches fail as a result. (We need filtering for backward compatibility, when we want to re-use an already existing index/memmap file)
Opening the draft PR to collect feedback on the overall direction of adding this feature. More tests will be added. Thanks.

Ah one more thing, @cristianmtr's comments reminds me that instead of validating self._storage, we should validate self._storage.traverse_flat() instead?

Discussed with @numb3r3 that It is better to move the validation/filter logic to the match function. This will be addressed in the next commit. Tests in this PR will be kept and merged until the update to match is merged.


iota(int.min, int.max).length is incorrect

davidbennett (@DavidBennettPIO) reported this on 2018-06-26T04:06:25Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=19027
CC List

greeenify
schveiguy (@schveiguy)

Description
---
void main()
{
  import std.range : iota;
  import std.conv : to;

  auto length = iota(int.min, int.max).length;
  assert(length == uint.max, "opps... length is " ~ length.to!string);
}
---

fails with:

core.exception.AssertError@[snip]: opps... length is<PHONE_NUMBER>3709551615
----------------
??:? _d_assert_msg [0x18578d52]
??:? _Dmain [0x1855e6cc]

I iota seems work fine with byte, short and long, it's just int that has issues.

Thanks,
David

greeenify commented on 2018-06-26T06:18:04Z
PR https://github.com/dlang/phobos/pull/6614


Rework the removal of dynamic checks

To avoid interference with other passes, we do this one earlier on ullbc. This happens to also be a lot nicer to write.
Fixes https://github.com/AeneasVerif/charon/issues/125

This is a bit dirty, I've got a better solution in mind

I opened https://github.com/AeneasVerif/charon/issues/142 and checked aeneas locally.

This may be breaking Eurydice but I haven't had time to investigate

You can merge when you want.
@protz: this may break Eurydice.

This also breaks const MONTGOMERY_R: i32 = 1 << MONTGOMERY_SHIFT;. I'll leave this as draft for now

Alright, this is blocked until I can figure out how to implement the new Checked* binops for all backends


Crashes When Incorrect Size is Specified

The viewport is expected to be 512 x 512, so when the screen is larger we try writing pixel data to memory that isn't owned by Holodeck. There has to be a more robust way to do this that accepts variable size screens, possibly specified by Python. It may also make sense to just move away from using the viewport to capture pixels if we can get a decent alternative.

Fixed in develop branch.


panic in libovsdb.update() callback

I occasionally observe the following panic in my test environment.
+++++++++
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x520fa4]
goroutine 74 [running]:
github.com/mapuri/libovsdb.update(0xc20802e840, 0xc2080c9940, 0x2, 0x4, 0xc2080f6800, 0x0, 0x0)
/var/lib/jenkins/jobs/NetpluginPullRequestSanity/workspace/src/github.com/mapuri/libovsdb/client.go:130 +0x564
reflect.Value.call(0x723400, 0x877570, 0x13, 0x7bdd30, 0x4, 0xc20813bf78, 0x3, 0x3, 0x0, 0x0, ...)
/usr/local/go/src/reflect/value.go:419 +0x10e5
reflect.Value.Call(0x723400, 0x877570, 0x13, 0xc20813bf78, 0x3, 0x3, 0x0, 0x0, 0x0)
/usr/local/go/src/reflect/value.go:296 +0xbc
github.com/socketplane/libovsdb/Godeps/_workspace/src/github.com/cenkalti/rpc2.func·001(0x0, 0xc208109900, 0x6)
/var/lib/jenkins/jobs/NetpluginPullRequestSanity/workspace/src/github.com/socketplane/libovsdb/Godeps/_workspace/src/github.com/cenkalti/rpc2/client.go:150 +0x1ad
created by github.com/socketplane/libovsdb/Godeps/_workspace/src/github.com/cenkalti/rpc2.(*Client).readRequest
/var/lib/jenkins/jobs/NetpluginPullRequestSanity/workspace/src/github.com/socketplane/libovsdb/Godeps/_workspace/src/github.com/cenkalti/rpc2/client.go:168 +0x5bc
++++++++++
My environment involves multiple go tests, where each test roughly does the following (I have intentionally removed error handling; logic etc for simplicity) :
func SomeTest(t *testing.T) {
  client, err := libovsdb.Connect();
  defer func() {
     if client {
        client.Disconnect()
     }
  }

  //registers some notification handlers
  client.Register(myNotifier);
  ...
  //perform some ovs operations
  ...
 }

Based on my understanding of the libovsdb client code I have a potential root-cause, as follows:
In clearConnection() it appears that we set the value pointed by the connection to be nil. I think this leaves a room for a timing window where a go routine (handling ovs notifications over rpc client) might still have some outstanding notifications, while the main go routine (where Disconnect() was called) would have set the value pointed by this key as nil resulting in occasional invalid memory access.
I believe, once a client has called Disconnect() or we receive a disconnect from underlying rpc client, then not keeping the rpc client around shall be okay. So as a fix, I am wondering if deleting the key instead as shown below will help? I have tried it locally and the issues seems to have disappeared for me. Please let me know if this seems like a reasonable fix and I will be happy create a PR.
diff --git a/client.go b/client.go
index 52907a1..6418bdc 100644
--- a/client.go
+++ b/client.go
@@ -231,7 +231,7 @@ func getTableUpdatesFromRawUnmarshal(raw map[string]map[string]RowUpdate) TableU
 }

 func clearConnection(c *rpc2.Client) {
-       connections[c] = nil
+       delete(connections, c)
 }

LGTM!


VertexArray index element size can be INT, SHORT and BYTE

Description
Support UNSIGNED_INT, UNSIGNED_SHORT and UNSIGNED_BYTE index buffers in VertexArray.
Added an optional index_element_size parameter (default: 4) were users can specify this. It can be 1, 2 or 4.

Failed on docs and might want to make a test or two..

All done. Was a few more small commits due it pycharm messing up tabs/spaces in C files. Think I will use VS Code for projects like this in the future.

Sorry for the different indentation in py & cpp files. I was using spaces for python and tabs for c++.
I will run the tests today and merge.
Thank you!

Nothing wrong with the indentation. It was my tools failing me.
Also, it would be nice to see a new release when this is merged :)

You might want to squash this PR to remove all these spammy indentation commits 😄

Just for inspiration: VC.gltf from gltf sample library with mixed 8, 16 bit index buffers.

Wow 😄

Also, it would be nice to see a new release when this is merged :)

Released: ModernGL 5.3.0

Thanks ❤


How did you obtain the raw data?

The repository and the README instructions refer to your pre-processed files from the original corpus of papers. Would it be possible to describe how you arrived at those files? I want to use the ACL subset of S2ORC, and it would be great if you could share how you obtained and processed it.

Sorry, I only saw the other issue answering this very question after I opened this.

Never mind, I'm reopening this. The paper and the previous issue don't describe how you got the papers. You mentioned you got them from the Semantic Scholar API, but did you filter them only for the ACL Anthology papers? What endpoint did you use? Can you share the query?

Hi @oyarsa Thank you very much for your interest in our research. Unfortunately, we used an internal API by AI2, which probably cannot match the semantic scholar API. We only choose the ACL papers in our paper based on source field from AWS database . Our crawled papers only have title and abstracts. I think you can ask in Semantic Scholar API Slack for more detailed information.

Thanks for the prompt response! I'll reach out to Semantic Scholar for further help in this.

Good luck!


Fixes #6

Fixed some front end issues
#6

Make short description and page URL as it was before

Make short description and page URL as it was before

doesnt this look better?
if you want i can make it as it was

please check my updated commit !
Open to suggestion

Sorry but UI changes are not going overall website theme


Getting generic error message: No configuration setting found for key 'play' on every config issue

I initially opened this case for PlayFramework but they think it may be because of the way play2-maven-plugin is loading the play server. Here's the link to that issue:
https://github.com/playframework/playframework/issues/8058#issuecomment-348389031
Detail:
Play Version (2.6.6 or 2.6.7)
API (Scala 2.11.11)
JDK (Oracle 1.8.0_72)
Play Maven Plugin Version - 1.0.0-rc1
Following stacktrace bleeds on log in multiple situation. I have seen it on hot reload error due to compilation issue, missing configuration, when Modules or Routers are not loaded, Dependencies are missing or conflicting.
Sometime hitting the same url gives different error message and that can actually point to real issue but it shouldn't be the case. Hitting same url should be idempotent as far as play framework is concern.
I think is very misleading to use this stacktrace which doesn't pin point any issue. Proper error should catch via responsible component and emits meaningful error messages.
e.g. For compilation issue on hot reload, it shouldn't even try to refresh application and just emit compilation errors
For missing configuration, it should be able to tell what key is missing. I don't see in such key or variable as 'play' in my application.conf. If it's internal present the documentation on that.
For missing modules or routes definition give user a WARN messages
For missing dependencies give a meaningful error message in first place.
com.typesafe.config.ConfigException$Missing: No configuration setting found for key 'play'
at com.typesafe.config.impl.SimpleConfig.findKeyOrNull(SimpleConfig.java:152)
at com.typesafe.config.impl.SimpleConfig.findKey(SimpleConfig.java:145)
at com.typesafe.config.impl.SimpleConfig.findOrNull(SimpleConfig.java:172)
at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:184)
at com.typesafe.config.impl.SimpleConfig.find(SimpleConfig.java:189)
at com.typesafe.config.impl.SimpleConfig.getObject(SimpleConfig.java:264)
at com.typesafe.config.impl.SimpleConfig.getConfig(SimpleConfig.java:270)
at com.typesafe.config.impl.SimpleConfig.getConfig(SimpleConfig.java:37)
at play.api.ConfigLoader$$anonfun$36$$anonfun$apply$34.apply(Configuration.scala:1065)
at play.api.ConfigLoader$$anonfun$36$$anonfun$apply$34.apply(Configuration.scala:1065)
at play.api.ConfigLoader$$anon$3.load(Configuration.scala:1021)
at play.api.ConfigLoader$$anon$2.load(Configuration.scala:1013)
at play.api.Configuration.get(Configuration.scala:214)
at play.core.server.common.ForwardedHeaderHandler$ForwardedHeaderHandlerConfig$.apply(ForwardedHeaderHandler.scala:233)
at play.core.server.common.ReloadCache.reloadForwardedHeaderHandler(ReloadCache.scala:74)
at play.core.server.AkkaHttpServer$$anon$3.reloadValue(AkkaHttpServer.scala:170)
at play.core.server.AkkaHttpServer$$anon$3.reloadValue(AkkaHttpServer.scala:167)
at play.core.server.common.ReloadCache$$anonfun$1.apply(ReloadCache.scala:25)
at play.core.server.common.ReloadCache$$anonfun$1.apply(ReloadCache.scala:25)
at play.utils.InlineCache.fresh(InlineCache.scala:69)
at play.utils.InlineCache.apply(InlineCache.scala:55)
at play.core.server.common.ReloadCache.cachedFrom(ReloadCache.scala:31)
at play.core.server.AkkaHttpServer.play$core$server$AkkaHttpServer$$modelConversion(AkkaHttpServer.scala:183)
at play.core.server.AkkaHttpServer.play$core$server$AkkaHttpServer$$handleRequest(AkkaHttpServer.scala:189)
at play.core.server.AkkaHttpServer$$anonfun$5.apply(AkkaHttpServer.scala:106)
at play.core.server.AkkaHttpServer$$anonfun$5.apply(AkkaHttpServer.scala:106)
at akka.stream.impl.fusing.MapAsync$$anon$23.onPush(Ops.scala:1172)
at akka.stream.impl.fusing.GraphInterpreter.processPush(GraphInterpreter.scala:499)
at akka.stream.impl.fusing.GraphInterpreter.processEvent(GraphInterpreter.scala:462)
at akka.stream.impl.fusing.GraphInterpreter.execute(GraphInterpreter.scala:368)
at akka.stream.impl.fusing.GraphInterpreterShell.runBatch(ActorGraphInterpreter.scala:571)
at akka.stream.impl.fusing.GraphInterpreterShell$AsyncInput.execute(ActorGraphInterpreter.scala:457)
at akka.stream.impl.fusing.GraphInterpreterShell.processEvent(ActorGraphInterpreter.scala:546)
at akka.stream.impl.fusing.ActorGraphInterpreter.akka$stream$impl$fusing$ActorGraphInterpreter$$processEvent(ActorGraphInterpreter.scala:728)
at akka.stream.impl.fusing.ActorGraphInterpreter$$anonfun$receive$1.applyOrElse(ActorGraphInterpreter.scala:743)
at akka.actor.Actor$class.aroundReceive(Actor.scala:517)
at akka.stream.impl.fusing.ActorGraphInterpreter.aroundReceive(ActorGraphInterpreter.scala:653)
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:527)
at akka.actor.ActorCell.invoke(ActorCell.scala:496)
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
at akka.dispatch.Mailbox.run(Mailbox.scala:224)
at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
Steps to reproduce:
It is been tested only with Play-maven projects as that is what I am trying to build on:
Download play-scala-rest-api from here: https://github.com/playframework/play-scala-rest-api-example
Disable Module from applicaiton.conf : play.modules.disabled += "Module"
Run server using mvn play2:run
Hit any url on server. e.g. http:localhost:9000
Another way to reproduce:
Download play-scala-rest-api from here: https://github.com/playframework/play-scala-rest-api-example
Keep the Module enabled in applicaiton.conf : play.modules.enabled += "Module"
Change PostResoureHandler definition to add WSClient dependency.
class PostResourceHandler @Inject()(
ws: WSClient,
routerProvider: Provider[PostRouter],
postRepository: PostRepository)(implicit ec: ExecutionContext)
Add play-ws dependency suggested on play-maven site.
com.typesafe.play
play-ws_${play2-scala.version}
${play2.version}
Run server using mvn play2:run
Hit any url on server. e.g. http:localhost:9000

Thank you for reporting. I will look at this problem soon.


Translate location or course data to . delimitator if , is sent in

I've seen this happen both in the point and the track level.
Example with course:
<event version="2.0" uid="xxxxxxx" type="a-f-G-U-C-I" time="2022-08-18T19:44:02.78Z" start="2022-08-18T19:44:02.78Z" stale="2022-08-18T19:50:17.78Z" how="h-g-i-g-o">
  <point lat="0" lon="0" hae="0" ce="9999999" le="9999999"/>
  <detail>
    <takv version="<IP_ADDRESS>" platform="WinTAK-CIV" os="Microsoft Windows 10 Home" device="LENOVO xxx"/>
    <contact callsign="xxxx" endpoint="*:-1:stcp"/>
    <uid Droid="Golf OPS"/>
    <__group name="Purple" role="HQ"/>
    <status battery="45"/>
    <track course="0,00000000" speed="0,00000000"/>
  </detail>
  <__taky_err>
    <!--Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/taky/cot/models/event.py", line 90, in from_elm
    ret.detail = TAKUser.from_elm(child, uid=ret.uid)
  File "/usr/local/lib/python3.8/dist-packages/taky/cot/models/takuser.py", line 91, in from_elm
    ret.course = float(d_elm.get("course"))
ValueError: could not convert string to float: '0,00000000'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/taky/cot/client.py", line 270, in feed
    evt = models.Event.from_elm(elm)
  File "/usr/local/lib/python3.8/dist-packages/taky/cot/models/event.py", line 97, in from_elm
    raise UnmarshalError(f"Issue parsing {child.tag}") from exc
taky.cot.models.errors.UnmarshalError: Issue parsing detail
-->
  </__taky_err>
</event>

Oooog. There are four ways to go about fixing this.

The hacky way is to say, "Look for commas, and replace with periods". This would probably work in most cases, but is a bit risky.

The more appropriate way is to take the locale from the XML document (which is being tossed right now), and use that to parse number fields correctly per user. One frustration with this is that Python seemingly uses a global locale for the entire program.

Another way is to just... treat it as a string instead of a float, and send that out without casting it at all. How do other ATAK / WinTAK clients handle getting commas?

It seems, looking at the TAKServer implementation, that they are using Float.parseFloat(), which doesn't handle internationalization. Perhaps we can just ask clients to change their localization?

is what we've done so far and people are usually okay with that.

For instances where they are not there exist workarounds to trick single programs. Closing out the issue.

@tkuester
At least WinTAK hangs / crashes on startup if the localization does not use . and , the US way...


feat：duckdb

hi，I am building a local application for analyzing large amounts of data. How can remult be combined with duckdb?

Hi @thevincentlee we've added support for duckdb.
Here's how you can use it
import express from 'express'
import { remultExpress } from 'remult/remult-express'
import { SqlDatabase } from 'remult'
import { Database } from 'duckdb'
import { DuckDBDataProvider } from 'remult/remult-duckdb'

const app = express()

app.use(
  remultExpress({
    dataProvider: new SqlDatabase(
      new DuckDBDataProvider(new Database(':memory:')),
    ),
  }),
)


🚀 Feature: Set ownership for new Postgres schema's

🔖 Feature description
Currently backstage creates new postgres schema's by running CREATE SCHEMA IF EXISTS new_schema.
This creates schema's owned by the current user. However, this current user is not always the user which needs to access the schema's (see Context section).
To get around this, it would be great to be able to set the ownership for new schema's. Postgres offers the AUTHORIZATION keyword for that: CREATE SCHEMA IF EXISTS new_schema AUTHORIZATION role;
This feature request is about adding a config parameter to set the role of the newly created schema's.
🎤 Context
Our infrastructure is a HashiCorp stack (Nomad, Vault, ...). When we spin up a new allocation (ie. job/container/..) it gets postgres credentials from Vault. The way this works is that Vault provisions postgres with a temporary user and password (v-username-<random_id>). These users are member of a parent role.
When migrations are triggered, schema's get created by a random v-user-... This sets the PG Schema ownership to be that specific user:
backstage_d=> \dn
                List of schemas
    Name    |              Owner
------------+----------------------------------
 app        | v-backstage-d-f87FlaQV61pl4MEFoE
 auth       | v-backstage-d-f87FlaQV61pl4MEFoE
 catalog    | v-backstage-d-f87FlaQV61pl4MEFoE
 public     | postgres
 scaffolder | v-backstage-d-f87FlaQV61pl4MEFoE
 search     | v-backstage-d-f87FlaQV61pl4MEFoE

When a new allocation comes up, it gets provisioned with a different user. This user cannot access the schema's owned by the previous user and thus fails. Currently our only way to get around this is to manually reassign the schema's to the parent role.
By allowing to set the correct autorizations during schema creation, we could automate this.
✌ Possible Implementation
replacing this function with something along the lines of:
const ensureSchema = async (database: string) => {
  if(dbConfig.setRole) {
    await admin.raw(`CREATE SCHEMA IF NOT EXISTS ?? AUTHORIZATION ??`, [database, dbConfig.setRole]);
  } else {
    await admin.raw(`CREATE SCHEMA IF NOT EXISTS ??`, [database]);
  }
}

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hi @joeppeeters - noticed this as well with Vault - and was a bit surprised :) Didn't know this was possible with Postgres, so I decided to use "static role" in Postgres - so the user does not change all the time - and Vault just rotates the password. An ok workaround I guess, but... :)
And for "human" access - we also have a "dynamic" role into Postgres.

@joeppeeters I think this seems reasonable - go ahead a shoot a PR!

@benjdlambert PR is ready for review, please let me know if something needs to change.


Cannot disable the kebab dropdown in pf-list-view

I have a use case where I need to either hide or disable the kebab dropdown in the PF list view.
I noticed that there is a ng-class="{'disabled': checkDisabled(item)}" in the generated html to disable the kebab dropdown as shown below, which does not work.
<button class="btn btn-link dropdown-toggle" type="button" id="dropdownKebabRight_0" ng-class="{'disabled': checkDisabled(item)}" ng-click="setupActions(item, $event)" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"></button>

Also, is there an option to hide the kebab dropdown based on a condition?
/cc @jeff-phillips-18

@AparnaKarve Please checkout #324 to see if this will meet your needs.


aliasing seemingly caused by prgba_to_bgra method??

You might not notice/need to change it for your own use case but I did notice this...

I found that removing it entirely and supplying GUID_WICPixelFormat32bppPRGBA to CreateBitmapFromMemory gives a better result...

I rendered the SVG from this page in a giant Columns UI button and it looks OK to me:

How are you rendering the image? Are you sure it doesn't require pre-multiplied alpha? (Just using GUID_WICPixelFormat32bppPRGBA won't cause a conversion.)

My first screenshot was using your original code untouched. Right colour but aliased.
The 2nd screenshot was removing the call to prgba_to_bgra but replacing the original GUID_WICPixelFormat32bppPBGRA with the GUID_WICPixelFormat32bppPRGBA which I thought "fixed" it but I really am trialling/erroring without really knowing what I'm doing. 😬
By leaving the original GUID_WICPixelFormat32bppPBGRA, I get the same colour as your screenshot which I consider to be wrong??
This is the original in a browser and what I consider to be the "right" shade of green.
https://raw.githubusercontent.com/marc2k3/jscript-panel/0a510d3521a8ea0e78a642a4558947f785cb8f34/component/samples/svg/android.svg
This is my entire SVG reading method (basically your code with a few tweaks) ...
static IJSImage* svg_to_image(wil::zstring_view str, uint32_t max_width)
{
	resvg_options* opt = resvg_options_create();
	resvg_render_tree* tree{};
	const int status = resvg_parse_tree_from_data(str.data(), str.size(), opt, &tree);
	resvg_options_destroy(opt);

	if (status == RESVG_OK)
	{
		resvg_fit_to fit_to{};
		const resvg_size size = resvg_get_image_size(tree);
		uint32_t width{}, height{};

		if (max_width == 0)
		{
			width = to_uint(size.width);
			height = to_uint(size.height);
			fit_to = resvg_fit_to(RESVG_FIT_TO_TYPE_ORIGINAL, 1.f);
		}
		else
		{
			width = max_width;
			height = to_uint(size.height / size.width * max_width);
			fit_to.type = RESVG_FIT_TO_TYPE_WIDTH;
			fit_to.value = to_float(width);
		}

		const uint32_t stride = width * 4U;
		std::vector<uint8_t> data(stride * height);
		wil::com_ptr_t<IWICBitmap> bitmap;

		resvg_render(tree, fit_to, resvg_transform_identity(), width, height, reinterpret_cast<char*>(data.data()));

		if (SUCCEEDED(g_imaging_factory->CreateBitmapFromMemory(width, height, GUID_WICPixelFormat32bppPRGBA, stride, stride * height, data.data(), &bitmap)))
		{
			return new ComObjectImpl<JSImage>(bitmap);
		}
	}
	return nullptr;
}

This is my DrawImage code from my yucky javascript-y component using, no gdi in sight. :P
STDMETHODIMP JSGraphics::DrawImage(IJSImage* image, float dstX, float dstY, float dstW, float dstH, float srcX, float srcY, float srcW, float srcH, float opacity, float angle)
{
	RETURN_HR_IF(E_POINTER, !m_render_target);
	if (srcW < 1.f || srcH < 1.f) return S_OK;

	IWICBitmap* wic_bitmap = nullptr;
	RETURN_IF_FAILED(image->get(arg_helper(&wic_bitmap)));

	wil::com_ptr_t<ID2D1Bitmap> d2d_bitmap;
	wil::com_ptr_t<ID2D1DeviceContext> context;

	// wic bitmaps can seemingly be valid but fail here, returning S_OK to suppress errors :/
	if (FAILED(m_render_target->CreateBitmapFromWicBitmap(wic_bitmap, &d2d_bitmap))) return S_OK;
	RETURN_IF_FAILED(m_render_target->QueryInterface(IID_PPV_ARGS(&context)));

	if (angle == 0.f)
	{
		context->DrawBitmap(d2d_bitmap.get(), to_rectf(dstX, dstY, dstW, dstH), opacity, D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC, to_rectf(srcX, srcY, srcW, srcH));
	}
	else
	{
		const D2D1_POINT_2F centre = { dstX + (dstW / 2.f), dstY + (dstH / 2.f) };
		context->SetTransform(D2D1::Matrix3x2F::Rotation(angle, centre));
		context->DrawBitmap(d2d_bitmap.get(), to_rectf(dstX, dstY, dstW, dstH), opacity, D2D1_INTERPOLATION_MODE_HIGH_QUALITY_CUBIC, to_rectf(srcX, srcY, srcW, srcH));
		context->SetTransform(D2D1::Matrix3x2F::Rotation(0.f, centre));
	}
	return S_OK;
}

The SVG I linked is actually a different shade of green to yours. Now the screenshot I took does also show in the wrong shade of green in the browser for me, but I'm guessing that's to do with colour profiles because the real thing matches the colour of the original (ignoring some some off-by-one errors).
At the moment the component is outputting GUID_WICPixelFormat32bppBGRA (no P), with GDI use in mind. So if you're going to switch back to this, it sounds like you would need/want an option in the API to output pre-multiplied alpha (GUID_WICPixelFormat32bppPRGBA) to match your D2D render target.

Sorry to have wasted your time with this. I didn't think to test gdi but I'm pretty sure I would have made a fool of myself using that too! 😁


When will the dataset release?

I know it will be a great contribution to this society. Please hurry up to make it !!!  Thanks~~~

I know it will be a great contribution to this society. Please hurry up to make it !!! Thanks~~~

I too want to emphasize the importance of this dataset to the community, it would accelerate the whole medical AI field greatly!


Added my name

pls review..Hope it was done correctly

I added my name to be among the list

can you update your code by pulling from the upstream, then push again

pls can you update your code one more time

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.

Sorry I have to close this PR, kindly update your code and initiate a fresh PR
Cheers 🥂

Its failing to upload
On Tue, 9 Aug 2022, 22:39 Success Chikezie, @.***>
wrote:

pls can you update your code one more time
—
Reply to this email directly, view it on GitHub
https://github.com/Oluwasetemi/altschool-opensource-names/pull/193#issuecomment-1209921121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZAD6VGRC7MG2UXZ6XRW6CDVYLFYHANCNFSM56ABZJMQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***
com>


Use links when loading pages and property details

Description
Consider using links when loading the pages in the pagination and when loading the property details, so that users can also use the browser's back button to go back.
For example, the back button we provide on the property details page can be missed or forgotten by a user who's scrolled all the way down. A user may use the browser's back button to go back to the results, and at this point, they will be taken completely out of the Find Properties page, which would result to an unfavourable user experience.

an additional suggestion may be to add the property id as a search parameter (NextJS's useSearchParam hook would work here ) to the url, so that in addition to fixing the back-button UX, you could also share a specific lot with someone else through the url (which is currently not possible)

@brandonfcohen1 — I was starting to work on this, but was unable to get a specific feature or property given an OPA_ID (which, given a search parameter of something like https://cleanandgreenphilly.org?id=12345, would pull the id from the url, fetch a matching property, and set it to the page's state) — is there direction you can provide in terms of a function or endpoint that may be available to make this fetch? the only feature set I was able to find came from the mapbox source, which required the map to load first before a feature could be provided, and was wondering if there was a more direct way.

@brandonfcohen1 — I was starting to work on this, but was unable to get a specific feature or property given an OPA_ID (which, given a search parameter of something like https://cleanandgreenphilly.org?id=12345, would pull the id from the url, fetch a matching property, and set it to the page's state) — is there direction you can provide in terms of a function or endpoint that may be available to make this fetch? the only feature set I was able to find came from the mapbox source, which required the map to load first before a feature could be provided, and was wondering if there was a more direct way.

As the app is currently set up this would be a challenge. The simplest way would be to basically load the map and then query the features, but might take a few seconds.
If this becomes a high priority I'll have to come up with another way to get the property data into memory.


Confusing Prompt from AddTatinDependencies

The question should make it clear that the question is about which of my open projects to add vikings to. For example:
"Which open project should vikings be added to?"

Currently:
  ]cider.addTatinDependencies vikings

--- Select a Cider project: ----------

#.vikings  c:/tmp/vikings
#.christ   c:/tmp/christ

Also, after asking this, the subsequent question
"christ: add dependencies to tatin-dependencies/ ? (Y/n)"
... seems unnecessary ...

Fixed in 0.40.0


Azure data lake gen2 connectivity issue from local spark

Delta works fine for reading/ writing locally in a azure VM, however, when we try to connect to Azure Data Lake Gen2 as per the delta documentation, we are getting this exception as below. Kindly assist.

Originally posted by @kumaran-chandrababu in https://github.com/delta-io/delta/issues/771#issuecomment-914158122

This looks like an Azure specific issue. Could you reach in your Azure support to help you?

For those who end up here with the same issue - I solved it by making sure my spark version was appropriate with the delta version. I used spark 2.4.2 with delta 0.6.1

Thanks for posting your action here! Closing this as this was not a Delta issue. Feel free to reopen this if fixing the Spark version/Delta version doesn't fix the problem.