Variables with different last character get the same color

The screenshot says it all. Is this behaviour intentional? It makes cases like the last demonstrated one (posX, posY, posZ) very hard to read in comparison. I'd expect those variables specifically to vary strongly in color.

This is something I've noticed as well. Would love for it to work where it differentiates them.

The FNV1a change should resolve this. :smile:


Last will

I found what is the problem of the non functional last will message. You have to move setLastWill(); call before you connect to mqtt broker, as the last will message must be defined before the actuall mqtt connection. Now its called after connection in topic subscription function. I cant test it, but I am sure thats it.

Thanks for the advice, I'll check it and fix it.

@Goodwillson
I should connect to send the last will message. So I've put the last will send before the first interaction after the connect.
Please try it, I've put the binary to the dev_binary folder

You really have to move it before you call connect, because the last will data is sent directly in that connection function in the library, look into row 898 in https://github.com/arduino-libraries/ArduinoMqttClient/blob/761ee7957facaa6315b0a74236c5f79b7c8c69b1/src/MqttClient.cpp
there is stated   flags |= _willFlags;

Example https://github.com/arduino-libraries/ArduinoMqttClient/blob/ab5a0ce6eb3c2d00625597f7a18e193ea1356048/examples/WiFiAdvancedCallback/WiFiAdvancedCallback.ino

Tested the last binary, does not set last will, make please above change and I will test it again.

I applied my above suggestions together with #35 and it works as expected.


Return response body chunks in specified encoding

MRI will return content read from the socket in the ASCII-8BIT (binary) encoding, whereas JRuby will return it in the UTF-8 encoding. In whichever encoding the body is retrieved, we want to force its encoding to the one specified (charset response header if present, otherwise binary). This is already the behaviour in Response::Body#to_s, we just extend it to Response::Body#readpartial as well.
Fixes #413.

Thanks!


When I call addText() function and after click on that text I can't edit that text and get error Uncaught TypeError: Cannot read property 'style' of null

I check your codes and there I see that on line 13979 writed this.useItext = useItext; and for that I can't change text after call addText() function.When I change this.useItext = useItext;  to this.useItext = true; everything depends text working fine.
eg.I tried send useItext with :options prop but I doesn't works too.

@GHarutyunyan
Are you using custom UI your own? ImageEditor using IText when includeUI option is set.
Could you tell me more details of your development environment and codes for help you out?

Same issue, but I solved it.
In my case, I use custom UI. I need to init imageEditor.startDrawingMode('TEXT') before imageEditor.addText('text').

Same as @Akari1987, init imageEditor.startDrawingMode('TEXT') work for me.


Create AWS CLI command to grab deployed frontend image SHA

Problem:
We don't have a reliable way to check which image SHA is deployed
Solution:
We should be able to use AWS CLI to query ECS task JSON file to parse the SHA tag
https://us-west-2.console.aws.amazon.com/ecs/v2/task-definitions/dp-staging-stagestack-frontend/421/json?region=us-west-2

@danieljhegeman @ebezzi @prathapsridharan as discussed in the huddle, I created a ticket for parsing ECS task JSON to get image SHA. Thank you!

CC: @dsadgat @metakuni something for oncall eng to do. Thank you!


Fixed wrong application domain selected

In the process of starting the listener to receive the notifications from SQL Server instance, if there isn’t a process dispatcher, we should obtain it first. In this process, we need the main application domain in the active process that has access to Microsoft.Data.SqlClient assembly to create an instance of SqlDependencyProcessDispatcher type.
The issue occurred when we tried to create the instance on the wrong domain.
The complementary description enclosed in the attached file!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: DavidEshtehari sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

In the process of starting the listener to receive the notifications from SQL Server instance, if there isn’t a process dispatcher, we should obtain it first. In this process we need the main application domain in the active process that has the access to Microsoft.Data.SqlClient assembly to create an instance of SqlDependencyProcessDispatcher type.
The issue occurred when we tried to create the instance on a wrong domain.
The complementary description enclosed in the attached file!
SqlDependency-issue401-description.docx

Uploading package for testing:
Microsoft.Data.SqlClient.2.0.0-PR410.nupkg.zip


[fix] keep references of modals when available.

keeping a reference of all modals in order to manage
when to add/remove classes and aria from elements
correctly.
solution based on @MarkMurphy, but it uses a simple list
to work on IE (don't really support Set).
Fixes #218 #231 #308.
Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.
[x] Documentation (README.md) and examples have been updated as needed.
[x] If this is a code change, a spec testing the functionality has been added.
[x] If the commit message has [changed] or [removed], there is an upgrade path above.

Coverage increased (+0.8%) to 81.271% when pulling 09880af9745a0a89c7102df3e70fc6fff137eb85 on diasbruno:fix/modal-reference-count into ebec6386156fe7fbe57f3365cfdce6d26fb4c962 on reactjs:master.

Hi @diasbruno, I've taken your tests from this PR and proposed an alternative solution here: https://github.com/reactjs/react-modal/pull/328
Please let me know if you have any questions or if I'm missing a case we should be testing for 😸

@ajfuller awesome. I'll check it.

@diasbruno thanks for the heads up on this. Any idea when this update might land?

can you resolve the branch conflict and submit this?

@ChenRoth this needs to be ported to v1. I'll do it.

@diasbruno this hasn't been released yet has it?

@boonier I'll try to write the backport to v1 today.

@boonier PR is #358. Please, if you have time, review the PR.


Move all Cucumber REST tooling in a dedicated sub-package

This allows clearer organization when you have other technology tooling (SOAP, Kafka, ...) in Cucumber tests

@pascalgrimaud : this one is ready for merge too :)


Add debug page on Monitor

Create a debug page on the monitor and a debug endpoint to display all
of the REST endpoints available on the monitor
Also create a variable to store the live port number when the server
starts up

Would catalog, inventory or even help be a more fit name than debug?  Debug seems to imply something different than a list of end points.

@EdColeman I renamed the endpoint to "all".

I'm not convinced it's a good idea to add this without a disclaimer at the top of the template that these pages are subject to change from version to version.

Isn't everything on the Monitor subject to change from version to version?

I'm not sure who this listing of endpoints is expected to help, because the site is already pretty intuitive to navigate.

Anyone? The one endpoint is broken and I don't even think anyone knew it was there. I added this to help with debugging.

I'd be concerned about users relying on these endpoints as fixed. They have the JSON/XML endpoints to rely on for information that the monitor knows... they should not rely on these endpoints for any kind of automation, permanent bookmarks, etc., since they are subject to change.

They are fixed. It isn't easy to change them without breaking the monitor. I would argue that we should treat the endpoints better so users can rely on them for stuff like that.

Isn't everything on the Monitor subject to change from version to version?

Yes, but we do try to keep the XML/JSON compatible and at a well-known location, because it can be used by automation.

I'm not sure who this listing of endpoints is expected to help, because the site is already pretty intuitive to navigate.

Anyone? The one endpoint is broken and I don't even think anyone knew it was there. I added this to help with debugging.

If it's only for debugging, then should this be off by default?
The main concern I had here is "Implied reliability":
Advertisements of information generally come with the implication that people can rely on the information in the advertisement. As an analogy, a flyer with a notice that an item is on sale at a store comes with the implication that a consumer can rely on getting the sale price when they visit the store to purchase the item. Similarly, a telephone/address directory listening comes with the implication that a person/business can be contacted at that telephone/address. -- This new page feels to me like it's a kind of advertisement of information, in that it seems to imply to me that those pages will exist and contain the expected information. Conversely, this implication does not seem present to me in the normal user experience of navigating menus on the site because our menus and other hyperlinks are more navigational, whereas this is more of an advertisement of information. In other words, with our current links, the information can be expected to be found only because the link is clickable... not because the information's address has been published in a listening, as is the case with this new page.
Secondarily, I'm also concerned about addition of new navigation on the site that doesn't substantially add information for users.  It's an extra link with extraneous information. Extraneous information, and extra paths to the same information, can increase confusion and decrease usability. To maximize user experience and minimize potential confusion, we need to balance between convenience and conciseness. Imagine having a button to take you to some piece of information. Now, imagine adding a second button "for convenience" that takes you to the same information. Perhaps this second button displays the information very slightly differently (FWIW, Vanguard.com's website does this right now, and it's very frustrating), or perhaps it takes you to the exact same information. In either case, it can be confusing to users. They may ask "what's the difference between these two?" or "do I need to visit both links to avoid missing out on important information?" or "these look the same, but are they actually the same?". Even the most well-intentioned changes for convenience can make a site slightly more confusing overall, even if it is an improvement for the use case it was intended.

I'd be concerned about users relying on these endpoints as fixed. They have the JSON/XML endpoints to rely on for information that the monitor knows... they should not rely on these endpoints for any kind of automation, permanent bookmarks, etc., since they are subject to change.

They are fixed. It isn't easy to change them without breaking the monitor. I would argue that we should treat the endpoints better so users can rely on them for stuff like that.

They aren't fixed. We've already changed them a few times during 2.1's development. We renamed master to manager (granted that was a special case), we changed a numeric type from integer to long, we added external compaction stuff, we added an endpoint to append log events and renamed the one to clear logs, we separated the garbage collection information into a separate endpoint and removed the old endpoints, and possibly breaking formatting changes to several of the String-based values as well.
While it's probably a good idea to have fixed endpoints at some point, it's difficult to do this when these need drive the monitor. They will need to change as our needs for the monitor change. Their primary task is to empower the views, not to provide automation to users. That's what the dedicated JSON/XML endpoints are for.
These were also not designed to be consumed by end users. If they had been, I think we should have spent more time on deciding what these should look like... we probably wouldn't have 10 of 23 endpoints dedicated to separate /rest/statistics/time values, and then also had a /rest/tservers/serverStats, but then aggregated everything about the manager into a single /rest/manager endpoint. These are what you get when you are trying to solve an immediate problem of getting data to the page... they are not what you get when you design them for end-user automated consumption.
I'm not opposed to having fixed rest endpoints at some point, well documented and ready for automated consumption by users... but I don't think what we have now are anywhere close to what those should look like. Maybe with a bit of design effort, they could be, but not right now.

@ctubbsii do you want me to revert this change? Is there any follow on work you would like done?

@ctubbsii do you want me to revert this change? Is there any follow on work you would like done?

Personally, I think it should be reverted (except the changes in logging the port that was used should be kept... that was a good change). Reverting is the position I've been arguing for above. However, I'm open to other positions, if a strong case can be made for doing something else.

I think there may be a way to get these dynamically from the Application Resources or by peeking at the class path and looking at the @GET and @POST annotations.

There may be a way to do this dynamically, but I don't know how and that seems more complicated.

But, do we really want users to write applications to the Monitor REST API?

If we don't want users writing applications to get data from the Monitor, than that is fine. I wasn't trying to advertise any "implied reliability". The Monitor is very complex and we currently don't have any active web developers in the community to maintain it. I was only trying to provide developers and admins a way to see the data that is present through REST APIs that are present.
By having a link to the current REST endpoints  I had originally called everything "debugging" for this reason. This page is nice for debugging what end points exist and what data is returned. The only way to do that now is to grep the code and try to assemble a proper URL from the strings. Then it is more work to try and get a valid URL from those strings... good luck. Here is the commands I ran on my development box to just obtain the rest endpoints.
grep "rest" server/monitor/target/**/functions.js | sed -e 's/return $.getJSON(//g' | sed -e 's/var call = //g' | sed -e 's/, function(data) {//g'
Then from those strings, you have to expunge the parameterized endpoints.

If the point is to help with debugging rest endpoints, and we don't want to advertise to users (and I don't think we should), then I think we should just put it at /rest without any menu linking to it. The alternative is to make it off by default, and have a flag that turns it on. However, I prefer just putting it at /rest and removing the menu option. As a follow-on, I would be willing to investigate trying to get it to be auto-generated from the webapp resources.

I think we should just put it at /rest without any menu linking to it

I had tried this by using an annotation in WebViews but it didn't seem to work. I wonder if its cause we set the Servlet in Monitor here:         server.addServlet(getRestServlet(), "/rest/*");

I think we should just put it at /rest without any menu linking to it

I had tried this by using an annotation in WebViews but it didn't seem to work. I wonder if its cause we set the Servlet in Monitor here:  server.addServlet(getRestServlet(), "/rest/*");

I briefly looked into locating it at /rest... it's probably more trouble than it's worth to put it there.
Also, I don't see the problem with just relying on the WADL, that's provided by default with Jersey applications. There is a missing runtime dependency to get it working for the rest/ endpoints, though. I've fixed that in #2654


[reggen] Move shadow register error aggregation into reg_top

This was duplicated in all of the different IPs that used shadow
registers and it's not particularly difficult to just put the giant
ORs in reg_top instead. Do so.

ah that's a good idea, thanks for doing that.


[bug]: LND consumes a lot of memory during start up, subsequently releasing when start up is successful.

Background
I observed that lnd takes a lot of memory during startup as if it is trying to cache some data it does not require. Once the start up is successful, the memory is released to reasonable level.
In my environment, the it peaked at 7-8 GB during startup before dropping back to 2.4 GB after successful startup. However I had to add additional swap file to allow lnd to start.
I have ~4GB channel.db and ~200 channels.
Your environment

version of lnd
"version": "0.16.4-beta.rc1 commit=v0.16.4-beta.rc1"
which operating system (uname -a on *Nix)
Linux umbrel 5.10.17-v8+ # 1421 SMP PREEMPT Thu May 27 14:01:37 BST 2021 aarch64 GNU/Linux

in my environment
db.no-graph-cache=true (slower path finding)
db.prune-revocation=true
caches.reject-cache-size=69000
caches.channel-cache-size=21000
Not sure if this has any bearing on the startup.
Other observations

The memory starts increasing when these messages are bring printed

2023-07-13 07:49:31.957 [INF] HSWC: Cleaning circuits from disk for closed channels
2023-07-13 07:49:32.396 [INF] HSWC: Finished cleaning: num_closed_channel=436, num_circuits=0, num_keystone=0
2023-07-13 07:49:32.396 [INF] HSWC: Restoring in-memory circuit state from disk
2023-07-13 07:49:32.473 [INF] HSWC: Payment circuits loaded: num_pending=836, num_open=6
2023-07-13 07:49:33.464 [INF] HSWC: Trimming open circuits for chan_id=797916:2092:1, start_htlc_id=1595
2023-07-13 07:49:33.464 [INF] HSWC: Trimming open circuits for chan_id=780689:2336:3, start_htlc_id=4790
2023-07-13 07:49:33.464 [INF] HSWC: Trimming open circuits for chan_id=797935:1980:1, start_htlc_id=1608
... there are several of these messages

keeps increasing while these messages are being printed

2023-07-13 08:04:25.116 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>63476489 occurred
2023-07-13 08:04:25.131 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>75258625 occurred
2023-07-13 08:04:25.132 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>75258625 occurred
2023-07-13 08:04:25.132 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>75258625 occurred
2023-07-13 08:04:25.134 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>75258625 occurred
2023-07-13 08:04:25.362 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>08011008 occurred
..... and there are so many of these

continues to increase when these are printed

2023-07-13 08:32:58.464 [INF] NTFN: New spend subscription: spend_id=1, outpoint=411664e09eef1246b56b8b8edd4ec5bf1d929de62fc56a4038853610532ed181:1, script=0 9454a85d4983f0a6071f0515ffc44ae5dbb6a49b0044e2b2308221772f460271, height_hint=798499
2023-07-13 08:32:58.562 [INF] NTFN: Dispatching historical spend rescan for outpoint=411664e09eef1246b56b8b8edd4ec5bf1d929de62fc56a4038853610532ed181:1, script=0 9454a85d4983f0a6071f0515ffc44ae5dbb6a49b0044e2b2308221772f460271, start=798499, end=798506
2023-07-13 08:32:58.596 [INF] NTFN: New spend subscription: spend_id=54, outpoint=d6a24e9fb889213cead5fdb52489d3952716d9ba4bff6a35fec595dbdac261b2:3, script=0 99ba71472237b32177fdacb7aa90a3cef4fefc74398446e386a5407509484016, height_hint=798499
2023-07-13 08:32:58.607 [INF] NTFN: Dispatching historical spend rescan for outpoint=d6a24e9fb889213cead5fdb52489d3952716d9ba4bff6a35fec595dbdac261b2:3, script=0 99ba71472237b32177fdacb7aa90a3cef4fefc74398446e386a5407509484016, start=798499, end=798506
2023-07-13 08:32:58.607 [INF] NTFN: New spend subscription: spend_id=113, outpoint=2e90aaa85c7cfec30d43e41f97131b11ec3e59bb20f159d43c6f38e74ff7c7d7:1, script=0 8df4ff26cc8f5b85cedcbf2610db24734b86492a1e23b99a0015da82a43d0ba2, height_hint=798499
2023-07-13 08:32:58.607 [INF] NTFN: Dispatching historical spend rescan for outpoint=2e90aaa85c7cfec30d43e41f97131b11ec3e59bb20f159d43c6f38e74ff7c7d7:1, script=0 8df4ff26cc8f5b85cedcbf2610db24734b86492a1e23b99a0015da82a43d0ba2, start=798499, end=798506
2023-07-13 08:32:58.607 [INF] NTFN: New spend subscription: spend_id=4, outpoint=50cf6cc8b7f3a0e1993f1353a649dd087049ec65d60374c6bbb242b7e474e543:1, script=0 659ed0c82627fdf9646b9cb0e260e615e9b12403405e5e5ed7a40d5f31384d4f, height_hint=798499
2023-07-13 08:32:58.607 [INF] NTFN: Dispatching historical spend rescan for outpoint=50cf6cc8b7f3a0e1993f1353a649dd087049ec65d60374c6bbb242b7e474e543:1, script=0 659ed0c82627fdf9646b9cb0e260e615e9b12403405e5e5ed7a40d5f31384d4f, start=798499, end=798506
... again a lot of them

followed by these still increasing

2023-07-13 08:33:04.359 [INF] CNCT: Close observer for ChannelPoint(5bb5c4e25bda0f23e3db4449bfb85077175c788dd484dfc7ec7c31c773268e76:1) active
2023-07-13 08:33:04.386 [INF] CNCT: Close observer for ChannelPoint(411664e09eef1246b56b8b8edd4ec5bf1d929de62fc56a4038853610532ed181:1) active
2023-07-13 08:33:04.411 [INF] CNCT: Close observer for ChannelPoint(f0a500aca9dd2b81fc4909575609fa3c9e041cc98b17706c767207f812d53286:0) active
2023-07-13 08:33:08.763 [INF] CNCT: Close observer for ChannelPoint(8b380cde45f60026c6b68f3d574195863b036bae0dac7d9fa475e88cf5a3272c:1) active
2023-07-13 08:33:08.790 [INF] CNCT: Close observer for ChannelPoint(df53e636da5f6fbdfba0b89c124b668fda7d33ef315187b426c5798ec2640cdd:1) active
2023-07-13 08:33:08.816 [INF] CNCT: Close observer for ChannelPoint(8b95123b58ce5e2188ab44c8ff8be86d3476577b8daa62b737cce3c4d05653d9:1) active
2023-07-13 08:33:10.886 [INF] CNCT: Close observer for ChannelPoint(efb2cbe7169491adec2a774fc764e93a62ee866b0ec97fb8776d44052e0fcdea:1) active

followed by these still increasing

2023-07-13 08:34:40.713 [INF] CNCT: ChannelArbitrator(ae1fc53d0a3a7fa01e7e490cfe66dec8672a1ddb0b2f765f74ffb66322ba20bd:1): starting state=StateDefault, trigger=chainTrigger, triggerHeight=798506
2023-07-13 08:34:40.790 [INF] CNCT: ChannelArbitrator(78338a3ee6acdcb489d31f5be01a4022053a24dcc10eb2926d16528c97ebaf7f:1): starting state=StateDefault, trigger=chainTrigger, triggerHeight=798506
2023-07-13 08:34:42.159 [INF] CNCT: ChannelArbitrator(f5d500e4fbab17d13aa297b3ab35e403b486a00c69a63c78d02433078ccd8ee0:1): starting state=StateDefault, trigger=chainTrigger, triggerHeight=798506
2023-07-13 08:34:42.201 [INF] CNCT: ChannelArbitrator(3be9cf587c8510bc0bd8607e88ac19f715f3a50444fcf233eb84777a793c147c:1): starting state=StateDefault, trigger=chainTrigger, triggerHeight=798506
2023-07-13 08:34:42.238 [INF] CNCT: ChannelArbitrator(6c529e35ddb449f73546e9aaa0c0b2e523fe3cd581ed9f9f8dc7c47dbdc5919e:0): starting state=StateDefault, trigger=chainTrigger, triggerHeight=798506

followed by this

2023-07-13 09:42:43.972 [INF] CRTR: Resuming payment 05037851b13a2b631aefb07920839d671bffe430cfb3d033458e33f92365d321
2023-07-13 09:42:43.972 [INF] CRTR: Resuming payment 0b2938018fcd83f236d5152005a285d2d9d990b5b6ec60ac9793d7d377ab9c05
2023-07-13 09:42:43.972 [INF] CRTR: Resuming payment 0d0727d8b2d42b5d61fcad5efb0c64695e0bdcf12a11db1e9b99ed0642febcef
2023-07-13 09:42:43.972 [INF] CRTR: Resuming payment 0ebcd3a97920af6cf47c25a64372f61bb40fbda0de7272df73c2c1cb3fc49c20
2023-07-13 09:42:43.973 [INF] CRTR: Resuming payment 113302faf9b5707550cdb1af427d331a47cfc5d816bfd02b15aa8771c695eddb
2023-07-13 09:42:43.973 [INF] CRTR: Resuming payment 131b3bf4337fe3c9752326c77eff73e59d45c56336dc27260c409afa60f58c94
2023-07-13 09:42:43.973 [INF] CRTR: Resuming payment 1a8ad8ec794ce7fbf541515a11991c08848b3429d7f2359bb6b19741bdba786a
.... again a lot of them

followed by these

2023-07-13 09:42:44.203 [INF] CRTR: Resuming payment shard 928679 for payment 0b2938018fcd83f236d5152005a285d2d9d990b5b6ec60ac9793d7d377ab9c05
2023-07-13 09:42:44.207 [INF] CRTR: Resuming payment shard 1458899 for payment 0d0727d8b2d42b5d61fcad5efb0c64695e0bdcf12a11db1e9b99ed0642febcef
2023-07-13 09:42:44.224 [INF] CRTR: Resuming payment shard 298857 for payment 113302faf9b5707550cdb1af427d331a47cfc5d816bfd02b15aa8771c695eddb
2023-07-13 09:42:44.228 [INF] CRTR: Resuming payment shard 559484 for payment 131b3bf4337fe3c9752326c77eff73e59d45c56336dc27260c409afa60f58c94
2023-07-13 09:42:44.243 [INF] CRTR: Resuming payment shard 235328 for payment 0ebcd3a97920af6cf47c25a64372f61bb40fbda0de7272df73c2c1cb3fc49c20
... again so many

finally the memory is released here

2023-07-13 09:42:55.125 [WRN] CHBU: Replacing disk backup for ChannelPoint(cb5dd56c3cb77306daf84f15151cedd3123d2da9de9dafa427a0f61378ee22bc:2) w/ newer version
2023-07-13 09:42:55.150 [INF] CHBU: Updating backup file at /data/.lnd/data/chain/bitcoin/mainnet/channel.backup
2023-07-13 09:42:55.157 [INF] CHBU: Swapping old multi backup file from /data/.lnd/data/chain/bitcoin/mainnet/temp-dont-use.backup to /data/.lnd/data/chain/bitcoin/mainnet/channel.backup

Steps to reproduce
Observe memory used by lnd while it is starting up.
Expected behaviour
Memory should not increase to unreasonable level.
Actual behaviour
Memory used keeps increasing during start up. Once successful, it is released to reasonable levels.

Since I run it in docker it may not be possible for me to run profile. I do not think it comes with go tool installed. If you are able to see this behaviour in your own environment then may be you will have some luck with running profiling too.

2023-07-13 07:49:32.473 [INF] HSWC: Payment circuits loaded: num_pending=836, num_open=6

what does this imply?

Since I run it in docker it may not be possible for me to run profile. I do not think it comes with go tool installed.

You can expose the port to the host, then run the profiling tools on the host directly.
So far all those logs are just normal operations for all the channels during start up: you have a lot of channels, and in flight payments.
The memory spike is certainly unusual though: are you seeing that in resident or virtual memory? RSS is what's actually allocated by the process (working set in use), with VSS is virtual memory which is skewed by boltdb (it allocate a lot of virtual memory as it memory maps the entire file).

you have a lot of channels, and in flight payments.

I have 278 channels but I do not think there are many inflight payments. At any given time I do not have more than 10-12 open HTLCs. May be this is related to the other issue where lnd does not clear expired inflight payments. #6834

The memory spike is certainly unusual though: are you seeing that in resident or virtual memory? RSS is what's actually allocated by the process (working set in use), with VSS is virtual memory which is skewed by boltdb (it allocate a lot of virtual memory as it memory maps the entire file).

I was monitoring RSS in top. I have 8 GB RAM + 4 GB Swap. They both were exhausted (as reported by free -h. I have now added additional 8 GB Swap which allows lnd to start (and then release all occupied memory). In running state my lnd uses 2.2-2.5 GB memory which also makes me believe the start up memory hog 3x the steady state requirement is excessive.

You can expose the port to the host, then run the profiling tools on the host directly.

How do I go about installing go tool

How do I go about installing go tool

You just install Golang normally on your local machine, then point it to the docker container.

Further update. I tried to run profile but may be there is an issue in how I setup the ports in docker I could not access it from outside. Will investigate and update during next restart.
I observed closely meanwhile in current startup. I do not understand what are those ~1500 routing failures messages going on. It appears lnd is processing some very old payments in flights which are erroneously marked payment in flight and due to this issue the payments are not removed from the channel db as well.

Before Stopping 2.3 GB

Compacting database 588MB

2023-07-15 08:10:32.056 [INF] CHDB: Compacting database file at /data/.lnd/data/graph/mainnet/channel.db

15.7 GB VIRT/5.7 GB RES

2023-07-15 08:24:46.444 [ERR] LNWL: unable to fetch transaction 56629003b953cd0cb3eed587ce9edc7e4b33019f29f3ceb4a23d3da063242e17 from mempool: -5: No such mempool or blockchain transaction. Use gettransaction for wallet transactions.
2023-07-15 08:28:28.507 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>19475457 occurred
.....
2023-07-15 08:35:57.562 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>34524417 occurred
2023-07-15 08:35:58.994 [INF] LTND: Channel backup proxy channel notifier starting

There are about ~1500 such lines
umbrel@umbrel:~ $ grep "Routing failure for local channel" ~/lndlog/lnd.log | wc -l
1473

Steady State after start up 15.9 GB VIRT/2.3 GB RES

2023-07-15 08:28:28.507 [WRN] CRTR: Routing failure for local channel<PHONE_NUMBER>19475457 occurred

In addition, @ziggie1984 suggested that these messages are part of building mission control and can be moved to DBUG instead of WRN level.
Does building mission control spike up the memory during startup? Suggestion was to resetmc before startup and I will try that in next startup.

There is definitely a marked improvement doing lncli resetmc before startup. No more memory spike.

21/07/2023
0. Before Stopping 16.1 GB VIRT 1.9 GB RES

1. Steady State 5.5 GB VIRT 1.1 GB RES

Thank you @ziggie1984 for the suggestion and clue.
I am still unsuccessful in setting up profile. On my umbrel/pi I have 6060 port open and listening.
tcp        0      0 <IP_ADDRESS>:6060            <IP_ADDRESS>:*               LISTEN      -
tcp6       0      0 :::6060                 :::*                    LISTEN      -

In addition, lnd docker component is also listening on port 6060
c31c7543de1a   lightninglabs/lnd:v0.16.4-beta.rc1   "lnd"                    8 minutes ago   Up 8 minutes   <IP_ADDRESS>:6060->6060/tcp, :::6060->6060/tcp, <IP_ADDRESS>:8080->8080/tcp, :::8080->8080/tcp, <IP_ADDRESS>:9735->9735/tcp, :::9735->9735/tcp, <IP_ADDRESS>:10009->10009/tcp, :::10009->10009/tcp   lnd
lnd log also confirms profiler is running
2023-07-21 12:02:40.379 [INF] LTND: Pprof listening on <IP_ADDRESS>:6060
but when I run the profiler on my mac (same local network, I am able to ssh to my node) I get
$ go tool pprof -svg http://umbrel.local:6060/debug/pprof/heap
Fetching profile over HTTP from http://umbrel.local:6060/debug/pprof/heap
http://umbrel.local:6060/debug/pprof/heap: Get "http://umbrel.local:6060/debug/pprof/heap": read tcp [fe80::1c15:e97f:e94d:9977%en0]:63257->[fe80::49b3:d0e0:e3e:d03e%en0]:6060: read: connection reset by peer
failed to fetch any source profiles

Anything I am missing?

Pprof listening on <IP_ADDRESS>:6060

Try --profile=<IP_ADDRESS>:6060 to make this work with Docker.

I have managed to run profiler now. Today's start up (with corresponding profiles is attached).
The memory peak was 1.1 GB. The main difference is that I now run mission control with 69420 records compared to 2169420 records when I was experiencing start up peak.
29/07/2022
0. Before Stopping 1.5 GB RES (no profile)
1. Before compacting DB 298 MB RES (profile 1)
2. Afrer compacting channel DB 237 MB RES  (profile 2)
3. After startup/steady state 1.1 GB (profile 3)

pprof.lnd.alloc_objects.alloc_space.inuse_objects.inuse_space.001.pb.gz
pprof.lnd.alloc_objects.alloc_space.inuse_objects.inuse_space.002.pb.gz
pprof.lnd.alloc_objects.alloc_space.inuse_objects.inuse_space.003.pb.gz


[Vm] az vm monitor log show: Deprecate azure-loganalytics and apply azure-monitor-query

Related command

Description

Testing Guide

History Notes

[Vm] az vm monitor log show: Deprecate azure-loganalytics and apply azure-monitor-query

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

closed https://github.com/Azure/azure-cli/issues/27952

Vm


Add a output writer to open-falcon agent.

This pr just for the review action of how to create a new output writer. I will continue to finish it if this way is correct.

[ ]   General Comment
 This look mostly good. An integration test for the factory would be nice. A more in depth test of the format of your writer would be nice as well.
 @gehel Thanks very much. I will complete it soon. And some docs/introduction will be add after finish local integrate test. It would be a good time to merge (if possible) by then.
 can not mvn clean install success,   have any resolution? thanks.
 Looking at the travis build, it seems there is an issue with license headers. Running mvn license:format should fix that. If the error you have is not the one I can see in the travis build, please let me know what error you have.
 thanks @gehel
[ ]   File: jmxtrans-output/jmxtrans-output-core/src/main/java/com/googlecode/jmxtrans/model/output/OpenFalconWriter.java:L1-111
 the
 does not match the header template. You can use mvn license:format to automatically format the files.
[ ]   File: jmxtrans-output/jmxtrans-output-core/src/test/java/com/googlecode/jmxtrans/model/output/OpenFalconWriterTest.java:L1-55
 We already have JsonUnit as a dependency. This could help you write a test that checks a bit more of the content.
 @gehel Thanks so much for you continued paying attention on my changes. I will refactor this commit while I finish the development on our project.
 I wanted to have a look and add a few unit tests, but did not find the time yet :-(

This pull request is now managed with CodeReviewHub. Refresh.

This look mostly good. An integration test for the factory would be nice. A more in depth test of the format of your writer would be nice as well.

@gehel Thanks very much. I will complete it soon. And some docs/introduction will be add after finish local integrate test. It would be a good time to merge (if possible) by then.

can not mvn clean install success,   have any resolution? thanks.

Looking at the travis build, it seems there is an issue with license headers. Running mvn license:format should fix that. If the error you have is not the one I can see in the travis build, please let me know what error you have.

thanks @gehel

:x: Build jmxtrans 176 failed (commit https://github.com/jmxtrans/jmxtrans/commit/fbdb0cb339 by @hsqlu)

Wow, lot of history in this branch! It would probably make more sense to start over. Or replace that last merge with a rebase (which is probably more time consuming than just starting over:)

Closed. Refer to #670


Update parameter "aim_abs_pCO2" default value

parameter aim_abs_pCO2 (used if aim_select_pCO2=1,3) previous default was
not meaningful; change it for a calibrated value (from David Ferreira).
Please check that the PR fulfils our requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

What changes does this PR introduce?
fix 1 parameter default value in pkg/aim_v23 new pCO2 LW scheme
Does this PR introduce a breaking change?
Other information:

LGTM
Ran various aim tests (none of which have pCO2!) and they still work.
Maybe @dfer22 could add something in pkg AIM_V23 documentation at some point - current documentation. The documentation for this is a bit #sad at the moment.


Remove custom change address from CoinJoin tab

CoinJoin spends inputs completely, any leftover is added to fee to ensure all is spent, because of this there is a check / stop in place to prevent accidentally sending with a overly large fee.
The "Custom Change Address" field and select box should be removed from the CoinJoin tab.
This is present on both current mainnet release and current testnet release.

Looks to me like the Coinjoin tab isn't displayed at all somehow it's showing a clone of the send tab.

Looks to me like the Coinjoin tab isn't displayed at all somehow it's showing a clone of the send tab.

send and coinjoin tabs use the same form/code the only difference is on the initialization of the 2 instances (_fCoinJoin = false or true)
SendCoinsDialog::SendCoinsDialog(bool _fCoinJoin, QWidget *parent) :
note: the Custom Change Address cannot be removed but it can be hidden (need to see if it don't break the page layout)

With the help.of @Bigpiggy01 we will try to explain how to build a fix for this during our first Build in Public screen casting session which will be shared on YouTube.

Fixed on pr #340


https://github.com/request/request/issues/3142

Summary

Simplest Example to Reproduce

request({
  method: 'GET',
  url: 'http://example.com', // a public URL that we can hit to reproduce, if possible
  more: { 'options': 'here' }
},

Expected Behavior

Current Behavior

Possible Solution

Context

Your Environment

software
version

request

node

npm

Operating System

Summary
Simplest Example to Reproduce
request({
  method: 'GET',
  url: 'http://example.com', // a public URL that we can hit to reproduce, if possible
  more: { 'options': 'here' }
},

Expected Behavior
Current Behavior
Possible Solution
Context
Your Environment
software	version
request
node
npm
Operating System


Layer spy example in IE 9 virtual environment

I tested Layer spy example in IE 11 and it worked perfectly.
then I changed browser version to 9 in F12 tools and it shows an error.
it highlights this.element.classList.add("ol-hidden")
and says this.element.classList is undefined or null so it can't use add.
is this happening the same in real IE 9 ?
I guess it is the part in ol-debug.js
/**
   * @private
   * @type {number|undefined}
   */
  this.rotation_ = undefined;

  if (this.autoHide_) {
    this.element.classList.add(ol.css.CLASS_HIDDEN);
  }

Since 3.15 you need a polyfill for this.
https://github.com/openlayers/ol3/releases/tag/v3.15.0

Thanks @ischas !
load polyfill then it's done?


feat(helm): remove the requirement that fetch/install need version

This removes the requirement that a fetch or install command must
explicitly state the version number to install. Instead, this goes to
the strategy used by OS package managers: Install the latest until told
to do otherwise.
Closes #1198

This change is

This PR removes the requirement that users supply versions for charts when doing the following operations:

helm install
helm inspect
helm upgrade
helm fetch

The new format for a chart reference is REPO_NAME/CHART_NAME:

stable/mariadb
incubator/mongodb

It is now illegal to supply a version suffix to the chart name (stable/mariadb-0.1.0). To supply a version, use the --version flag:
$ helm install stable/mariadb --version 0.0.9

Other changes in this PR:

Docs updated
Additional field added to provenance.Verification to disambiguate which file was verified
repotest.Server can now replicate a client-side cache (to ease testing)

Closes #1262

"That's one small step for a helm user, one giant leap for helm user experience." - Michelle Noorali

Not a blocker by any means but the first half of the error message is a little unclear.
helm [feat/1198-no-version-required*]$ bin/helm fetch tscharts/alpine --version 3.0.0
Error: chart "alpine" not found in tscharts index. (try 'helm repo update'). No chart version found for alpine-3.0.0

Manually tested! Looks good.

got a mess of extra line returns
% helm install tscharts/alpine
Fetched tscharts/alpine to alpine-0.2.0.tgz
quarreling-but
Last Deployed: Fri Oct  7 10:49:19 2016
Namespace: default
Status: DEPLOYED

Resources:
==> v1/Pod
NAME                       READY     STATUS              RESTARTS   AGE
quarreling-but-my-alpine   0/1       ContainerCreating   0          0s

manually tested


how to use react-router-dom alongside ladle

import { Link } from 'react-router-dom'
import { Button } from '@mantine/core'

export const TryLogin = () => (
    <Link to='/auth/login'>
      <Button variant='default'>login</Button>
    </Link>
)

I'm trying to render this prop into ladle, however it fails because it requires react router context.
// router.tsx
export const router = createBrowserRouter([
  {
    path: '/auth/login',
    element: <LoginPanel />,
  },
])

// App.tsx
import { RouterProvider } from 'react-router-dom'
import { router } from './router'

export const App = () => {
  return <RouterProvider router={router} />
}

I've read https://ladle.dev/docs/providers but was unable to figure out how to provide context for every elements. any help would be appreciated.

It's this: https://ladle.dev/docs/providers
You need to create .ladle/components.tsx and export/define Provider.

I've read ladle.dev/docs/providers but was unable to figure out how to provide context for every elements.

to clarify more, I'm getting difficulties on how to put RouterProvider into Provider. I've blindly tried
import type { GlobalProvider } from '@ladle/react'
import { RouterProvider } from 'react-router-dom'
import { router } from 'router'

export const Provider: GlobalProvider = ({ children, globalState }) => (
  <RouterProvider router={router} />
)

but it doesn't seems to work.

You are not returning children aka the story itself.


Communication between Spring boot admin server and SteelToe Management actuators to use gRpc

Is your feature request related to a problem? Please describe.
There are two kinds of deployment that are possible with Spring boot admin server and .NET core SteelToe apps. Sometimes it would be in the same cluster and in some scenario it would be deployed on separate cluster other than apps. In all the cases we would like to have the spring boot admin server and SteelToe Actuator use gRpc to communicate rather than rest.
Describe the solution you'd like
SteelToe apps can communicate with SpringBoot Admin server using Steel Admin client library and steel toe actuator. The feature we are asking here is that we that communication to be able to happen on gRpc. When getting the details of admin client details, there should be an additional option to state whether the access should be based on Http or gRpc. The admin server should also expose two endpoints one for Http access and another for gRpc access. When running in the same cluster we could use the gRpc endpoint whereas when running in a heterogeneous cluster Http could be a good option without any tweaking to LLB or any other additional gateway configurations.
Describe alternatives you've considered
None
Additional context

@VenkateshSrini does Spring Boot Admin support gRPC? I'm not finding any information on support from that end

@TimHess. I see this project https://github.com/yidongnan/grpc-spring-boot-starter and hence assumed that Spring boot admin server has now started supporting gRpc

@TimHess  I have raised a feature request also here Spring boot admin server with gRpc endpoints

Hi @VenkateshSrini,
Seeing the response to the linked issue , it looks like there's not much for us to do here, sorry. If either Spring Boot or SBA adds support in the future we can revisit, but I'm going to close this issue for now

@TimHess The Spring boot admin server is expecting the actuator teams to publish a proto that they can use to gather the data and put it up on a pleasing UI. So from SteelToe the proto has to be published is my understanding.


Searching ontology synonyms

It would be helpful if the GO term autocomplete allowed for searching on synonyms.
The display would include both the main term name and the synonym, perhaps something like this if the curator searched for 'receptor binding':
GO:0005102 signaling receptor binding (syn: receptor binding)
This is a more general issue and may relate to this ticket here:
https://github.com/geneontology/noctua/issues/257

@cmungall @kltm @thomaspd any comment on this?

This is supported by the backend. The issue is likely with the hard-coded queries in the code that you inherited.

@kltm the graph doesn't do it either

It is in AmiGO and AFAICT it works in Noctua too, at least in some cases.
"Cajal body" (http://amigo.geneontology.org/amigo/term/GO:0015030) can be found in the "Add individual" autocomplete with the synonym "Gems". Similarly in the "Add annoton" cellular_component autocomplete.

From the curators, was the request for synonyms for ontology terms, or was it for gene name synonyms?  I think it might be for gene names/symbols.

The original request was for ontology term synonyms.
In Seth's case of searching on 'Gems' the 'Cajal body' synonym is found in the form, the graph, and AmiGO.
In the use case that led to this ticket, though, we were searching with 'receptor binding' which didn't get us to 'signaling receptor binding' but maybe this is because the list of terms that contains the 'receptor binding' string in name, synonyms or definition is long while the list of terms containing 'Gems' in the name, synonyms or definition is very short.


Release 1.1.5.Final

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

ah, I forgot release should be done from main project not fork @mjurc

I'm pretty sure that's why release failed...


Revise installation instructions

Installation instructions are out of date and need revision. Readthedocs also is missing an installation guide.
This issue benefits from:

[x] #16
[ ] #106
[x] #124

Compiling tetgen

Install MinGW using MSYS2 (https://www.msys2.org/)
Follow the installation instructions!

Install/update packages:
pacman -Syu
Install development toolchain:
pacman -S --needed base-devel mingw-w64-x86_64-toolchain

Add C:\msys64\mingw64\bin to the Windows Path environment variable:
https://code.visualstudio.com/docs/languages/cpp#_add-the-mingw-compiler-to-your-path

Compile tetgen
g++ -O0 -c .\predicates.cxx
g++ -O3 -o tetgen tetgen.cxx predicates.o -lm

Move tetgen.exe to a location on your system path

Closed by #139


wrap verifier calls in catch_unwind

This prevents the Rust FFI calls from panicking and terminating the program with SIGABRT. Instead the verifier indicates an unsuccessful validation to the caller.
It is still the obligation of the caller to insure that the arguments are valid non-null null-terminated C-strings.
I would consider it a preliminary solution. Ideally, the verifier should return an error code (and/or possibly a message) on failure that that indicates what went wrong and allows the application to provide meaningful feedback to the user. (e.g. "invalid input encoding" vs. "proof validation failed").

I haven't tested this PR yet, but it's worth mentioning it might be worth looking at RFC 2945 and possibly using "C-unwind" abi instead of "C" if we are using catch_unwind.


Can not check go files.

Hi:
My vim can't check go files. I don't know why.
:SyntasticInfo

output
Syntastic version: 3.7.0-180 (Vim 704, Darwin)
Info for filetype: go
Global mode: active
Filetype go is active
The current file will be checked automatically
Available checkers: go gofmt golint gometalinter govet
Currently enabled checkers: -

I don't know how to config. Can you help me?
Thank you very much!

Please consider installing vim-go insetad.  If you still want to enable syntastic for Go, then read the answer to the first question in the FAQ (in particular the second paragraph), and act accordingly.

I have a try. Thank you.

Maybe I found the reason. I update the golang with dev version. It was not work. but before. it work  well.

Syntastic relies on version strings to find out if a given option of go can be used or not.  And since it isn't possible to tell whether version "31ad583" came before or after something like "1.5", syntastic only works with release versions of Go. shrug


StringListWidget scrollbar disappears

When a StringListWidget contains a lot of items the scrollbar disappears around item 106700. When trying to scroll to the very bottom, it goes back to the top after reaching a certain point.

Looks like integer overflow


ci: update image name for goreleaser

The image name in here was overseen by me in 91539d0.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.037%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
323

Relevant Lines:
538

💛  - Coveralls


[SPARK-33736][SQL] Handle MERGE in ReplaceNullWithFalseInPredicate

What changes were proposed in this pull request?

This PR handles merge operations in ReplaceNullWithFalseInPredicate.
Why are the changes needed?

These changes are needed to match what we already do for delete and update operations.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

This PR extends existing tests to cover merge operations.

cc @dongjoon-hyun @HyukjinKwon @cloud-fan @viirya @sunchao

Test build #135207 has started for PR 31579 at commit 1c08374.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39788/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39788/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39788/

Thank you all. Merged to master.

Test build #135207 has finished for PR 31579 at commit 1c08374.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135207/

My late thank you to everyone for reviewing, @HyukjinKwon @dongjoon-hyun @viirya!


test merge and mergeDeep of Map instances with Symbol keys

adds tests to cover merge and mergeDeep of Map instances with Symbols as keys.

@leebyron Am I crazy, or is this actually working? I think this proves the use-case I described in #1392, with no changes to source. Did something else in master change?

Is it possible that Symbol is getting compiled by typescript to a string?

I can't reproduce this test passing locally, something is fishy

I'm not sure why you and I are seeing different things, but I did throw a couple of console.log statements in one of these tests, and this is what came out...
  console.log __tests__/merge.ts:224
    Map {}

  console.log __tests__/merge.ts:225
    Map {}

I'll make sure the tests I'm running check for specific values at specific key depths without lazily checking object equivalency. These false positives (for me) were definitely under the radar!


split out dev apt dependencies

resolves #32470
Description
This PR updates the tools/install_ubuntu_dependencies.sh script to improve flexibility and user interaction.
Changelog:

Adds a prompt for installing extra packages
Adds a NON_INTERACTIVE variable for a non-interactive mode using an environment variable

Verification
To run interactively:
./tools/install_ubuntu_dependencies.sh

To run in non-interactive mode:
NON_INTERACTIVE=yes ./tools/install_ubuntu_dependencies.sh

Thanks! Want to pick up another bounty like https://github.com/commaai/openpilot/issues/26956?


Transform my personal dataset into the MERR data format

Hello, great work!!! Could you please provide a script to transform my personal dataset into the MERR data format?

Thank you for your interest in our work!
I have a clarification to make: are you concerned about how to extract features from different encoders, or are you looking to generate multimodal samples corresponding to the videos?

I want to get the information from this picture that corresponds to my Video. Actually, I see that your Emotion-Llama can also get the corresponding information from an input video and audio?

Thank you for your interest in our work!
I have a clarification to make: are you concerned about how to extract features from different encoders, or are you looking to generate multimodal samples corresponding to the videos?

I want to get the information from this picture that corresponds to my Video. Actually, I see that your Emotion-Llama can also get the corresponding information from an input video and audio?

Thank you for your interest in our work!
I have a clarification to make: are you concerned about how to extract features from different encoders, or are you looking to generate multimodal samples corresponding to the videos?

I want to get the information from this picture that corresponds to my Video. Actually, I see that your Emotion-Llama can also get the corresponding information from an input video and audio?

Sure, I understand your question. In our paper, we discussed prompts related to extracting visual information using MiniGPT-v2 and audio information with Qwen-Audio.
You can try setting up the corresponding environment for these projects to generate the multimodal information related to your data.
Once I finalize the scripts, I will make them open source.

"We constructed the MERR dataset, which includes 28,618 coarse-grained and 4,487 finegrained annotated samples, covering a wide range of emotional categories such as “doub” and “contempt”. Unlike previous datasets, MERR’s diverse emotional contexts allow models to learn from varied scenarios and generalize to real-world applications, serving as a valuable resource for advancing large-scale multimodal emotion model training and evaluation." This is one of the main contributions of your work. Could you provide the script code for building the MERR dataset? I would like to process my own dataset into the MERR format. Thank you!!!

We are currently organizing our code and plan to make everything open source. The script for building the MERR dataset involves multiple projects, and we need to consolidate everything before releasing it. Please bear with us for a moment.

Hi, Author,
I noticed in the reasoning task that the code includes the line:
caption = self.MERR_coarse_grained_dict[video_name]['caption']
Could you please explain how I can generate the 'caption' for my own dataset?
Thank you!

Vision: Use the open-source OpenFace tool to extract facial expression AU (Action Unit) information in advance, then map the AU data into corresponding textual descriptions through character mapping.
Audio: Use QwenAudio to generate tonal descriptions of the input audio.


Issue with validation codes generation

Hi, I discovered an issue when testing via https://github.com/snok/drf-openapi-tester
I have a related field in serializer and also have validation of it in validate_field_name. the problem is that in spec there are only supported codes does_not_exist, incorrect_type, null, and required.  There is no invalid code.
An example of a model and serializer is below
class Recommendation(BaseModel):
    """Model defines data for a recommendation from MAL.

    Recommendation works in the following way: If you `liked` this anime, you would
    like `recommend`ed anime.

    """

    mal_id = models.CharField(
        max_length=255,
        unique=True,
        null=True,
        blank=True,
        editable=False,
        verbose_name=_(
            "Constructed Id of recommendation from MAL",
        ),
        help_text=_(
            "MAL Id constructed of three parts: "
            "username who gave the recommendation, "
            "mal_id of anime which you liked,"
            "mal_id of anime which user recommends you to watch",
        ),
    )

    liked = models.ForeignKey(
        to="anime.Anime",
        on_delete=models.CASCADE,
        related_name="recommendation_liked",
        verbose_name=_("Liked anime"),
    )

    recommend = models.ForeignKey(
        to="anime.Anime",
        on_delete=models.CASCADE,
        related_name="recommendation_recommend",
        verbose_name=_("Recommended anime"),
    )

    reason = models.TextField(
        verbose_name=_("Reason"),
    )

    recommended_by = models.ForeignKey(
        null=True,
        to="users.User",
        on_delete=models.CASCADE,
        related_name="recommendations",
        verbose_name=_("Recommended by"),
    )

class RecommendationSerializer(ModelBaseSerializer):
    """Serializer to show info about recommendation."""

    class Meta:
        model = models.Recommendation
        fields = (
            "id",
            "created",
            "modified",
            "reason",
            "liked",
            "recommend",
        )

    def validate_recommend(self, data):
            raise ValidationError(
                _("Some error"),
            )

Actually, error codes are collected from the error messages defined for each field rather than actually inspecting the code and identifying each raise ValidationError. In order to see the invalid error code in the generated schema, you'll need to follow the example from the docs (last item under "Notes").
Another option which will be available starting next release (0.12.5) is using the extend_validation_errors decorator, sth like
@extend_validation_errors(["invalid"], field_name="recommend", method="post")

The error code will be added to the list of already collected error codes for validation errors. More info in the corresponding section in the docs

@ghazi-git With 0.12.5 it's working as expected, thank you


Add system theme for documentation

It would be nice to add support for the preferred system theme in the docs.
I usually did that with the following configuration:
theme:
  name: material
  palette:
    # Palette toggle for automatic mode
    - media: "(prefers-color-scheme)"
      scheme: default
      toggle:
        icon: material/brightness-auto
        name: Switch to light mode
      primary: black

    # Palette toggle for light mode
    - media: "(prefers-color-scheme: light)"
      scheme: default
      toggle:
        icon: material/brightness-7
        name: Switch to dark mode
      primary: black

    # Palette toggle for dark mode
    - media: "(prefers-color-scheme: dark)"
      scheme: slate
      toggle:
        icon: material/brightness-4
        name: Switch to system preference
      primary: black

This needs to be adjusted to the prefix-dev color scheme probably...

fixed by #654


Use older version of docker that doesn't break beats

What does this PR do?
So, when I added the docker container tests, I didn't realize that the newest version of the docker API is completely different, and once I imported it into beats, the newer version of the docker library just broke everything. I figure the easiest way to deal with this is just to use the same version of docker here and in beats.

If there is a CVE reported against the current docker patch version we are going to be doing this work anyway. It may be better to just update the types downstream now, otherwise someone with no context on the problem might end up having to deal with as a result of a vulnerability scan result.

How much work is fixing up Beats? Is it just a bunch of find/replace work? If so I'd say just do it.
If this involves rewriting actual logic then create a separate issue and we'll merge this and do the changes separately.

It looks like mostly library/type name changes, but there's a ton of them. Guess I'll take a crack at it and find out.

@cmacknz so, it looks like all our other elastic-agent-* libraries are also on 24.x.x, and looking at git, that branch is still getting updates as of two months ago, so I assume we'd get any fixes for CVEs on that branch as well. I think we might be better off sticking with 24.x.x for now, unless we have a reason to update the entire ecosystem of helper libs.


Add AAD and EA references

ER authorizations can span outside of subscription, tenant, and EA boundaries

@jaredr80,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jaredr80 : Thanks for your contribution to the Azure documentation! The author, @cherylmc, has been notified to review your proposed change.

#sign-off


Adding duck duck go as a search option for those who want it.

Unfortunately, I'm going to have to close this pull request. Please note that although I'm not going to accept your specific changes, the features added in this pull request will be implemented! I'm working on them now and they'll be added shortly. You can check out how it will be implemented here: https://retropage.co/dropdown-test.html


fetch: add unfetch polyfil

"Bare minimum fetch polyfill in 500 bytes."
https://github.com/developit/unfetch

Thanks!


Close with a cross

Hi, I'm looking for a way to build-in a cross at the right top of the tooltip, where you can close th tooltipp manually on click and/or touch. In Addition it should auto-close after several seconds.
Kind regards glupto

Hi, please use the show/hide/etc API methods to achieve the behavior you wish. Thank you.


CMD vs ENTRYPOINT

The documentation for running etcd under docker (https://coreos.com/etcd/docs/latest/docker_guide.html) assumes that the docker image has etcd set as the entrypoint. This was true for previous versions (e.g 2.3.7). I just tried my service file on quay.io/coreos/etcd:latest and it seems to use CMD instead of ENTRYPOINT, so the syntax in the documentation (omitting the etcd binary) no longer works.

Sorry, we have changed it to CMD to support etcdctl running in the container.
Please refer to https://github.com/coreos/etcd/blob/master/Documentation/op-guide/container.md#docker for now. We will fix the documentation.

@immesys CoreOS latest doc is not yet synced with the release doc at https://github.com/coreos/etcd/blob/release-3.0/Documentation/op-guide/container.md. For the new lease, the updated doc is more accurate.


AI help chatbot

Milestones

[ ] introduce alongside classic search
[ ] deploy as a GitHub action
[ ] retire search feature?

Ux

[x] show citations inline
[x] show citation sources at bottom
[x] show examples on zero state
[x] support dark mode
[ ] embed on home page
[ ] floating button entry point
[ ] keyboard shortcut
[ ] file issue for bad response

Preprocessing

[ ] replace file
[ ] extract pydocstring?

Eval

[ ] generate handful of questions and preload them
[ ] do sxs eval for different response strategies


[Idea] Allow configuration of pattern groups through a config file

What if there was a file that holds common queries, in a rc file somewhere on the home dir:
e.g.
context-groups:
  prod-new:
    include: "/prod/"
    exclude: "^/legacy/"
  stg:
    include: "/stg/"

$ kubectl allctx -g prod -- get nodes # g used as a flag for context group

It is a great idea! I will try to implement this feature and raise a PR.

No need.
This is basically just a note so that I don't forget someday later. It doesn't mean I'm interested in adding this.


[ MB-11317 ] Labeled details for TOO editing of orders

Jira ticket for this change
Summary
This work is tied to a couple of PRs and should be merged into the default branch only after the others have been merged.

#8410
#8407

Setup to Run Your Code

💻 You will need to use two separate terminals to test this locally.
Terminal 1
Start the UI locally.
make client_run

Terminal 2
Start the Go server locally.
make server_run

Additional steps

Login as a TOO in the office app
Edit all fields of an Order on a given Move
View the /history page and show all the fields you have edited

Verification Steps for Author
These are to be checked by the author.

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Three commits from this PR were cherry-picked from #8407

Fails

:no_entry_sign:
Yarn Audit Issues Found:
high - Path Traversal: 'dir/../../filename' in moment.locale
Package moment
Patched in >=2.29.2
Dependency of moment
Path moment
More info https://github.com/advisories/GHSA-8hfj-j24r-96c4
1 high vulnerabilities and 0 critical vulnerabilities found

Messages

:book:
:link: MB-11317

  Generated by :no_entry_sign: dangerJS against 50d4ce71e9e5ad81d8ef04235767ef5a1f533cce

I added a quick sketch for writing a test. I ran into some issues, but I won't be able to finish without a fresh pair of eyes in the morning 👍🏽


Bump emr-etl-runner to 1.0.4

This got squeezed into ec15e8a9795f7ecda50d949168a7b8acc9c4f0b0 when rebasing the PR after the reviews and fixing it with the submodules is a pain so I'll leave it there.


Correction for raw affiliation LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France

Correction needed for raw affiliation LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France
raw_affiliation_name: LIP, UMR 5668 CNRS — ENS Lyon — UCB Lyon — Inria, France
new_rors: 02kvxyf05;029brtt94;02feahw73;04msnz457
previous_rors: 02kvxyf05;029brtt94;02feahw73
works_examples: W2132257274
contact: a4a4f782c1fc86d3d0a91ba68bd85add:140c7c5c482d9638428f75bf975c @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Can't distinguish single nodes from lists with one item

There is currently no way of distinguishing between a single element (e.g. $sxml->Result[0]) and a list of elements (e.g. $sxml->Result or $sxml->children()) which happens to include only one item. They can however behave differently - foreach ( $sxml->Result[0] as $result ) is equivalent to foreach ( $sxml->Result[0]->children() as $result ).
As far as I can see, there is no way of determining this with the current API. However, since the behaviour is different, the extension itself clearly tracks this distinction. It should probably be raised with the maintainers to add PHP access to this property for a future release.

Haha, just was stumbling over your README because I linked to the project in a recent SO answer and then stumbled over that and thought: mhm, that should be answered. And yes it is, I've also created an example here: http://3v4l.org/fttGI  (backup as gist: https://gist.github.com/hakre/05df2b71e520ac0a09b3)


[OCP3] allow isolated flatpaks

CLOUDBLD-7764

Signed-off-by: Robert Cerven<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
n/a JSON/YAML configuration changes are updated in the relevant schema
n/a Changes to metadata also update the documentation for the metadata
n/a Pull request has a link to an osbs-docs PR for user documentation updates

rn updated


React testing

Summary

Added tests for all components.
Added tests for all reducers(mission, rockets).

@Whoistolu  Thank you for your reviews.


How to remove the script from the index.html to use useGoogleGeoApi ?

I tried to removed the script of index.html
<script type="text/javascript" src="https://maps.google.com/maps/api/js?key=myKey&libraries=places"></script>

to
  public userSettings5: any = {
    geoCountryRestriction: ['fr'],
    geoTypes: ['address'],
    showSearchButton: false,
    showRecentSearch: false,
    useGoogleGeoApi: true
  };

But not work

hi,
without the google map script mentioned in index.html, the directive won't work with Google API.
If u want to remove the script then u have to implement your own API which u can give the link to the directive to use. please refer demo and read the document.

Exactly, it's because I use agm-core at the same time, so with the src script I have a conflict with 2 google API called at the same time.

I had the same issue because two scripts were being loaded at the same time which was causing the issue.

I was able to make it work by not loading the Google Maps API in AgmCoreModule.
If you put this in your AppModule, AgmCoreModule does not load Google Maps API:
providers: [     ...BROWSER_GLOBALS_PROVIDERS, {provide: MapsAPILoader, useClass: NoOpMapsAPILoader}   ],
Of course you have to leave the <script> in index.html.
This is a suboptimal but easy solution to make the two libraries cooperate.

Unfortunately I need the agm core to display a Google map (with markers, ...) on another page of my website, so ..

Same here, but for me that is still working with this setup.

    AgmCoreModule.forRoot({
      apiKey: 'AIzaSyDH1n-WWp1WgfRbK17-J0-BTlkF7i_czMg'
    }),
    //ng4-geoautocomplete
    Ng4GeoautocompleteModule.forRoot(),
    //infinite scroll
    InfiniteScrollModule
  ],

This code got me api conflict when i call ng4-geoautcomplete and agm-core same time
Console screen error


Unable to change gender of customers from Edit Customer Page.

Framework version: 0.1.2

We should remove the gender field from the customer edit form from the admin panel as the provision for setting gender for customer comes only when they edit their profile from account section.

Made gender editable.

Framework Version: 0.1.3
Fixed


Fixing github issues

Fixed github issues #66, #22, #29.

Sorry for delay while out - looking at this now

Looks and tests good


correlate2d and convolve2d inconsistent results with non-default boundaries with swapped inputs

scipy.signal.correlate2d and scipy.signal.convolve2d produce inconsistent results with non-default boundaries (either boundary != 'constant' or fillvalue != 0.0) across the different modes when in1.size < in2.size.
Reproducing code example:
import numpy as np, scipy.signal as sig
a = np.arange(1, 4*4+1, dtype=float).reshape(4, 4)
b = np.arange(1, 4*3+1, dtype=float).reshape(4, 3)

#### a.size > b.size ####
sig.correlate2d(a, b, mode='valid', boundary='wrap')  # outputs array([[812., 890.]])
sig.correlate2d(a, b, mode='same', boundary='wrap')
# array([[606., 596., 674., 632.],
#        [822., 812., 890., 848.],  # second and third values are 'valid' output
#        [606., 596., 674., 632.],
#        [534., 524., 602., 560.]])

#### a.size < b.size ####
# valid mode output the reverse of the above one which is expected
sig.correlate2d(b, a, mode='valid', boundary='wrap')  # outputs array([[890., 812.]])
sig.correlate2d(b, a, mode='same', boundary='wrap')
# array([[ 872.,  804.,  832.],
#        [1160., 1092., 1120.],
#        [ 872.,  804.,  832.],
#        [ 776.,  708.,  736.]])
# That output does not contain the 'valid' output any where in it which seems wrong
# Additionally, it doesn't contain any values from the original order of the arguments

This also occurs when boundary == 'symm' or boundary == 'constant' and fillvalue != 0.0. Since the correlate and convolve functions always use a constant-0 boundary, they are not effected by this issue.
When moving from 'same' to 'full' the 'same' output is found within the 'full' output but still the 'valid' output is not found in the 'full' output.
While it seems that from the 'valid' results that the problems lies with 'same' and 'full', however if one compares against scipy.ndimage is seems as though 'same' is actually correct:

sig.correlate2d(a, b, mode='same', boundary='wrap') == ndi.correlate(a, b, mode='wrap', origin=(-1, 0))
sig.correlate2d(b, a, mode='same', boundary='wrap') == ndi.correlate(b, a, mode='wrap', origin=(-1, -1))

Overall very confusing since the 'valid' region should always be the same regardless of the boundary but it isn't there any more, but using a different tool ends up showing that it isn't the valid region afterall...
Scipy/Numpy/Python version information:
1.5.0rc2 1.18.5 sys.version_info(major=3, minor=8, micro=3, releaselevel='final', serial=0)

Ultimately this may be okay and all within how things are defined, it is just odd how there are some inconsistencies. The real problem I was running into when I discovered these odd behaviors is in #12686. That one definitely needs to be fixed.


Can I have the converted value as a just the number value, not a (value as string + symbol)?

First of all, nice library!
I'm working in an application and testing this library as the solution for our unit conversion system.
In our case, I need to be able to convert a value (let's say from meters to feet), but I need to be able to control the number of digits in this output value (as I will display this value in a constrained space).
Is there a way for to convert a value to another unit without the output being a string with the symbol added, but just the number value, so I can proper parse this to a string with the desired number of decimals (or precision)? Also, do I have a way to access the symbol of this converted value so I can also use it on the final presentation?
Ideally I would think on something like this:
measurementInMeters = Measure.of(150, meters)
console.log(measurementInMeters.value) // 150
console.log(measurementInMeters.symbol) // 'm'

measurementInFeet = measurement.in(feet)
console.log(measurementInFeet.value) // 492.126
console.log(measurementInFeet.symbol) // 'ft'

Of course, for retro-compatibility purposes, other method names could be used.
If you're open to accept contributions, I would definitely be able to work on those features.

I've actually found my way to do it in a functionality that was not documented:
measurementInMeters = Measure.of(0.123456, meters)

console.log(measurementInMeters.in(meters) // 0.123456 m

const formattingOptions = { formatValue: (value) => value.toFixed(2) }

console.log(measurementInMeters.in(meters, formattingOptions) // 0.12 m

Glad you found the solution for this. There's documentation for this here: https://jscheiny.github.io/safe-units/measures.html#conversions Let me know if the documentation needs improvement.


Ignore journal collection on Windows.

Summary:
Instead of returning an error, we just warn. This is not ideal. However, a proper solution would
require a refactoring of Diagnostics.
JIRA issues: D2IQ-65143

Codecov Report

Merging #167 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #167   +/-   ##
======================================
  Coverage    66.9%   66.9%
======================================
  Files          30      30
  Lines        2961    2961
======================================
  Hits         1981    1981
  Misses        793     793
  Partials      187     187

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83b9b5...e1248c8. Read the comment docs.

Windows build is failing. I thought we talked about disabling journald collection on Windows instead of returning no error


New zos test command

Add a new zos test command, that will run truffle test behind the scenes if it detects the project is a truffle one, or run a custom testing for the project.
Design what features the custom testing should provide:

Automatically running ganache vs requiring it to be run on a separate project
Using mocha out of the box or picking a different fwk
Initializing web3

We now have https://github.com/OpenZeppelin/openzeppelin-test-env for this :-)


next for custom login pages

Sorry about the delay.
This functionality is absolutely necessary.
But can you please add a test regarding this functionality if you have time. Otherwise I'll do it later.


.Net Core implementation that works with Lambda Serverless?

One of the big selling points for the ease of Alexa dev is how easy (and cheap) it integrates with lambda. Also some orgs are moving to Core as it becomes more stable. Any future plans to have this work with .Net Core for those easy Lambda projects?

+1 would be great to get this to work with the recently added C# support in Lambda

Another +1.  I've been using the Slight.Alexa version thats been ported to Core... but it's incomplete at the moment.

I have a .Net core (netstandard) port of this in a fork that initially is working for me but I will test further before declaring success beyond It works on my machine ™  - I will also verify it works in core on Azure and AWS Lambda

verified it is working on azure just now, up next AWS Lambda verification (but if it works on .net core it should on another)

@tonysurma I couldn't find any nuget feed with your version of this lib (for .net core) so I allowed myself to create one: https://www.myget.org/feed/ami/package/nuget/AlexaSkillsKit.Net (if any of you need it, you can reference it). Quite useful, because local dll can't be referenced in easy way in VSCode.

@szymczakk Happy to amend the "official" NUGet package definition so it can be used from .NET Core if you can educate me a bit about what I need to do. (My head is still on .NET Framework 4.6 and I haven't had time to learn about porting stuff to .NET Core.) Is the package definition you published on MyGet available somewhere for me to look at?

@stefann42 yes it is!  I moved to 1.6 (no reason other than it needed to be a different version.  in .NET Core it comes from the csproj now so you can see the details here (I literally copied over what you had done from the nuspec to the csproj).
I also chose the right netstandard so it will work with .NET Core and the version of .NET Framework you had previously targeted so it is compatible and should work without change in existing .NET 4.6 deployments.
The changes are all in the fork  I made and I strove to make each commit 'small' so it documented the porting.  Happy to help however I can and if you would like it I can make a PR with these changes and anything else you would need to convert.

thank you @szymczakk for posting that.  I hadn't gotten to that step yet.  I had been using a custom nuget feed entry that pointed to a local folder where I had the package (simple but it worked for me)

@tonysurma  How did you handle the request? When I create API project, and in controller get the Request it's type Microsoft.AspNetCore.Http.HttpRequest and Speechlet in method GetResponse require System.Net.Http.HttpRequestMessage and I don't know how to convert it. I was thinking about rewriting GetRespose method to use request from .net Core, what do you think?

@szymczakk I made a SampleCore  project here to demonstrate that and included commit(s) that showed each step to 'upgrade' the Sample to Core.  The trick for that I recall is including WebApiCompatShim which allows you to inherit from ApiController and aligns to the types expected by the Speechlet API
I did that as it was the quickest/most direct port.  I was also thinking of adding another GetResponse method/overload to adapt to the .net core approach but recall there were some items that the Speechlet wanted that would be a bit messy to get.

@tonysurma sory for disturbing you, but have another question, can you look here and see what do I do wrong? By wrong I mean

The remote endpoint could not be called, or the response it returned was invalid.

as an response from service simulator in Skill config console on AWS. I got request, but response that I send to Alexa is invalid 😢

@szymczakk no worries, I will try to look at that a bit later.  Can you see the response you are sending from your code and are you sure you got called? I ask only as I have gotten that error when tunneling or some other url issue was the cause.

@tonysurma Yep, Im 100% sure that my server is called, because I'm attached with debugger to it, and see everything is happening. I will try to catch my whole response with Fiddler and show you ;)

got it @szymczakk - just looked through the code and nothing stood out (looked at startup, controller, speechlet) and all looks good with no gotchas.
I also reverified my deployment with this version is working as well as made a quick simple one and it worked for me.  Curious what the response is that it doesn't like.  Sorry I couldn't be more helpful (yet)

@tonysurma Thats weird. I'm unable to capture my trafic with Fiddler, but I can stop execution by debugger (so my local server is called). How did you configure your server? Do you use IIS? How about certificate? Slefsigned or trusted? And do you have static IP address or you use some DynDNS (like no-ip etc) ?

It's been a bit since I did the self hosting (I do updates now to deployed instances in Azure App Service websites) but I recall following this guide.  I recall getting tripped up a couple of time and used this guide  and another I can't find right now.  Eventually I went to just using the site on azure and logging and other mechanisms as it was faster (especially since I tend to dev on combination of desk pc and a couple of laptops).  Sorry I don't have any more insights there

Ok, I found the response:

{"endpointRegion":"EU","text":"hello","applicationId":"","locale":"en_US","session":null}

hmmm, let me look and compare - hopefully there is something there

@tonysurma I compared it with amazon specification and it's problem with respone :/ Ehhh... have to figure it out somehow 😉

gotcha - yeah.
My response from an app on the same build of the framework looks like this (removing a few specific bits)
{   "version": "1.0",   "response": {     "outputSpeech": {       "type": "PlainText",       "text": "My content"     },     "shouldEndSession": true   },   "sessionAttributes": {     "intentSequence": "MyIntentId"   } }
Definitely looks like stuff is missing in the response building.

Hey @tonysurma ! Sory for taking it so long, but have some more info, maybe you will know how to handle it. When I debug the request it shows that the response that is generated by code is

{"response":{"card":{"type":"Simple","content":"SessionSpeechlet - Hello","title":"SessionSpeechlet - Title","subtitle":"SessionSpeechlet - Sub Title"},"outputSpeech":{"type":"PlainText","text":"Hello"},"shouldEndSession":true},"sessionAttributes":{"intentSequence":"HelloWorldIntent"},"version":"1.0"}

but when I finally cought the correct resposne that is sent by server it turns out that it's

{
"version": {
"major": 1,
"minor": 1,
"build": -1,
"revision": -1,
"majorRevision": -1,
"minorRevision": -1
},
"content": {
"headers": [
{
"key": "Content-Type",
"value": [
"application/json; charset=utf-8"
]
}
]
},
"statusCode": 200,
"reasonPhrase": "OK",
"headers": [],
"requestMessage": null,
"isSuccessStatusCode": true
}

I run dotnet core in kestrel and then host it on IIS on windows 10. Do you have any idea why do I got such resposne?

Sorry but unfortunately I do not. It looks to be like it's encoding the http response itself in json which is strange and i've never seen before myself.

Hey @tonysurma, look what I found. And this link is explaining why it wasn't working. But funny case is that your code works for you, but you don't have this function in your source.

Interesting, great find.  I will take a look. Might be an omission from the sample project I had in my test and production projects... thanks

Thanks again @szymczakk I had that edit in each of my projects and missed it in the SampleCore project as I never 'directly' ran the sample.  I was using the SampleCore project as the basis for my projects to test and run and forgot to 'back port' that line into the sample.  I pushed this now.

Hey @tonysurma and @stefann42 any chance we could still get this merged and published to nuget? Now that we've got .net core 2.0, it'd be great to get .net core support.

@JustMaier if @stefann42 is open to it, I can update/test my fork with netstandard 2 to ready it for merge

@tonysurma By all means. I'm happy to accept the PR, just let me know if I need to be aware of any specifics. We don't yet use .NET Core in our production deployment so I don't have an environment to test myself.

Now, when interfaces support is merged, I believe .Net Core support is our main priority. @tonysurma changes in your fork looks great to me. Could you, please, create a PR with your changes, so that we can include .Net Core support to the nearest library release? Just tell if you need any help in preparing PR or merging with latest changes.

One thing to note. Current library is compatible with VS2012 for both Speechlet authors and AlexaSkillsKit.Net contributors. .Net Standard version will require .Net Core1.x SDK and VS 2017 or VS Code for development. @stefann42 are you ready for these kind of changes in our development environment?
For Speechlet authors we can provide multitargeting NuGet package, ofcourse.

I think we should start a separate branch for version 2 and make that compatible with .NET Core. We’re not ready to move off .NET Framework 4.7.
From: Sergey Greenko<EMAIL_ADDRESS>Sent: Monday, December 18, 2017 10:52 PM
To: AreYouFreeBusy/AlexaSkillsKit.NET<EMAIL_ADDRESS>Cc: Stefan Negritoiu (FreeBusy<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [AreYouFreeBusy/AlexaSkillsKit.NET] .Net Core implementation that works with Lambda Serverless? (#20)
One thing to note. Current library is compatible with VS2012 for both Speechlet authors and AlexaSkillsKit.Net contributors. .Net Standardhttps://docs.microsoft.com/en-us/dotnet/standard/net-standard version will require .Net Core1.x SDK and VS 2017 or VS Code for development. @stefann42https://github.com/stefann42 are you ready for these kind of changes in our development environment?
For Speechlet authors we can provide multitargeting NuGet package, ofcourse.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/AreYouFreeBusy/AlexaSkillsKit.NET/issues/20#issuecomment-352655681, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAr7oeCMQfkVTOzAv6WuZyxvQoVydt3Aks5tB10UgaJpZM4LqTTc.

I have slightly different proposal, which I've tried to describe in newly created wiki Roadmap document.

@ElvenMonky Love the Roadmap! Let's have an online meeting together next week (between Christmas and New Year's) and discuss merged PRs and strategy for moving forward. Please see https://freebusy.link/stefan for my availability and to schedule the meeting.

thanks @ElvenMonky for noting two issues with my fork.  I just addressed those and will also bring it up to date with this repository recent commits.  Happy to help as you all decide on how to address .net core 2

Well. currently I think we can drop VS 2012 support, after already implemented code is released.
@stefann42 Probably I'll reschedule for your 27th evening (my 28th morning).

the myget URL posted above doesn't work. Is it still alive?
[ask.net myget] 'doctype' is an unexpected token. The expected token is 'DOCTYPE'. Line 1, position 3.

in VS 2<IP_ADDRESS>

@brandonh-msft Do you mean this one https://www.myget.org/feed/ami/package/nuget/AlexaSkillsKit.Net/1.7.0 ?? This one is still working (just checked it)

is this branch still alive?

Development in this repository is inactive since January 2018. It seems nobody is interested.
This is a 3rd party library, while Java version is supported officially by Amazon.


It seems odd that Expr appears twice in validated.ref

https://github.com/dada-lang/dada/blob/12dd605181cc4ff36b88ea03a4f19357ef7c0015/dada_tests/hello_world/validated.ref#L21-L23
Now Expr always appears twice in the validated.ref, which seems a little odd to me, would it be better to only appear once? @nikomatsakis

@XFFXFF They are different counters -- one is the 'validated' id, the other is the 'syntax' id. It would be better if that were clearer. Maybe better to use {} form so we can give them names.

Or change the names to SExpr and VExpr or something.

@nikomatsakis  I see, one more question, why do we need to show expr id in validated.ref or syntax.ref ? Actually, I can't get much information from these ids, what can you get from them?

@XFFXFF other parts of the code sometimes references the id of an expression -- e.g. the breakpoint is set at a particular expression. Being able to cross-reference and see which part of the code that refers to is useful. That said, I agree that it's harder to read than it used to be.


Unable to launch gdx Liftoff on macOs

Please ensure you have given all the following requested information in your report.
Issue details
[LWJGL] GLFW_FORMAT_UNAVAILABLE error
Description : NSGL: Failed to find a suitable pixel format
Stacktrace  :
org.lwjgl.glfw.GLFW.nglfwCreateWindow(GLFW.java:2058)
org.lwjgl.glfw.GLFW.glfwCreateWindow(GLFW.java:2229)
com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createGlfwWindow(Lwjgl3Application.java:527)
com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createWindow(Lwjgl3Application.java:463)
com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createWindow(Lwjgl3Application.java:449)
com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.(Lwjgl3Application.java:163)
gdx.liftoff.Main.main(Main.java:198)
Exception in thread "main" com.badlogic.gdx.utils.GdxRuntimeException: Couldn't create window
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createGlfwWindow(Lwjgl3Application.java:530)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createWindow(Lwjgl3Application.java:463)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.createWindow(Lwjgl3Application.java:449)
at com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application.(Lwjgl3Application.java:163)
at gdx.liftoff.Main.main(Main.java:198)
i have installed jdk 21 on macOs device

I'm guessing you're running in a VM (or a Hackintosh setup), and not actually running on Apple hardware, since some quick googling finds only results containing NSGL: Failed to find a suitable pixel format when someone is using a VM. I would suggest either running Liftoff on whatever host is running the virtualization, or downloading and editing one of the pre-generated templates: https://github.com/libgdx/gdx-liftoff-demo (Java) or https://github.com/libgdx/gdx-liftoff-demo-kotlin (Kotlin).


Good introduction to each subject

We can do more then that, atleast explain the subject, if u can expain deeper: go on

start with english and we can translate to french as we move forward


Display loaded file name next to "Select Tree JSON" button

Describe the improvement you'd like to see
It would be nice if I could see the file name for the selected tree json next to the button, or a "file loaded" message"
Is your suggestion related to a problem? Please describe.
It may not be clear to every user that the file was successfully loaded, thought the "get started" button becoming active helps!
Additional context

Done!


Instance.Clone method definition does not account for Instance.Archivable behavior

According to the documentation of Instance.Archivable, when this property is false, it introduces the possibility of Instance.Clone() failing by returning nil rather than throwing an error.

Calling Clone directly on an object will return nil if the cloned object is not archivable.

https://roblox-ts.com/playground/#code/DYUwLgBAlgdgzmAhjAxiCBeCMQHcICS8SqIAFAEQCyA9gCYjAUCUAdAMLA05nMQD0-CGAAWUOBBQ0ArsDoQARugAG0mAwBmsEHWUAoPQAcATrDBlYCZGlYA5RAFsQzIA

This is unfortunately a conscious decision that is slightly unsafe. The Archivable property is very rarely used, and the inconvenience of the possibly-undefined type outweighs the benefit of the better correctness.

Fair enough, though it may be necessary to add some sort of warning specifically when cloning models, as character models are not archivable by default.

I agree with what Dionysusnu said above. Going to close this for now.


Add rake tasks to sync OAuth Secrets as Kubernetes Secrets

This adds the kubernetes:sync_token_secrets[<config_map_name>] rake task, which will retrieve a config map from Kubernetes which lists the emails for ApiUsers who's authorisation tokens are to be synchronised with Kubernetes. The task will then create or update Kubernetes Secrets for every token associated for that ApiUser.
Also adds the kubernetes:sync_app_secrets[<config_map_name>] rake task, which will retrieve a config map from Kubernetes which lists the names for OAuthApps who's client ID and Secret are to be synchronised with Kubernetes.
We'll use a cron job/workflow to trigger this task on a regular interval to keep the secrets up to date. This intended to replace signon-resources.

@robinjam Thanks again for the review - implemented all the changes you've suggested!