activation quantization

I'm confused with the equation (12), what means the outer product of sw and sx?  The activation is per-token quantization?

Hi @hanhanpp , thank you for your interests in our work. For your questions, the activation is per-token dynamic quantization, while the weight is per-channel/per-group static quantization.


Displays random item in the destination container, when dragged from a filtered array source

Hi
First of all, thank you for this nice library.
I have come across the following issue when I tried with a filtered array source
using containersFilteredModel.
I wanted a toggle filter which dynamically filters the source container, and can be dragged to a destination container.
I used a function based filter on the source array during the toggle.  This works fine.
But when I toggle and get the filtered items and when dragged to the destination container, it shows a random item from the unfiltered item.
Please find the following jsfiddle link:-
http://jsfiddle.net/nrjh7057/13/
(I have simulated the toggle as an input text in this jsFiddle so that we can type ODD/EVEN)
Thanks in advance.

Ok, I will look at it soon.. there is probably something wrong with filteredModels now as reported in #83. So maybe solving #83 will also solve your issue. Thanks for reporting issue and for using dragular ;)

Ok.. it was not related to #83.. you have typo in dragularService options:
Instead of containersFilteredItems there must be containersFilteredModel, after correction it seems to be working fine
http://jsfiddle.net/9w9bvgvd/
But your function filteredItems() is running redundantly more times than needed, I think better approach could be:
http://jsfiddle.net/fyp09dy4/
Have a nice day ;)

Excellent, now it works with that change.  Cheers :)
PS: Somehow the first link (http://jsfiddle.net/9w9bvgvd/)  didn't work, but the second one works fine.
Have a nice day!

What is wrong with first link? It seems to be working for me :eyes:


chore: Fix PR checks

Fixes failing PR checks. Regex to parse changesets was incorrect.
I also improved the logs and checks a bit.

LGTM, maybe there could add tests for this?

Yes, that would be good. I'll create a ticket for this, I don't know the best practices for GH actions (also how to run it locally, etc.)...


[Issue]

[ ] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
Run azd version and copy and paste the output here:
Describe the bug
Description of issue you're seeing...
To Reproduce
Steps to reproduce the behavior...
Expected behavior
A clear and concise description of what you expected to happen.
Environment
Information on your environment:
* Language name and version
* IDE and version : [e.g. Visual Studio 16.3]
Additional context
Add any other context about the problem here.

[ ]  Make sure you've installed the latest version using instructions in the wiki

Output from azd version Run azd version and copy and paste the output here:
Describe the bug Description of issue you're seeing...
To Reproduce Steps to reproduce the behavior...
Expected behavior A clear and concise description of what you expected to happen.
Environment Information on your environment: * Language name and version * IDE and version : [e.g. Visual Studio 16.3]
Additional context Add any other context about the problem here.


Added spaces between description blocks

Preview

Lint

 not enough space for 540px for example

thanks, you are right, this is because svg itself have the whitespaces that cannot be edited and the image are resizing responsively,  when the window resizes. Fixed it by using vw instead of px


Legacy URL confirmation

The article highlights that there is a "requirement" to configure the following URL's on your firewall:
ID39
%tenant%-files.sharepoint.com   Port 80,443
%tenant%-myfiles.sharepoint.com  Port 80,443
When testing these URL's on any existing or newly provisioned tenancy they don't seem to exist. Therefore on some firewalls it's not possible to create an object that matches this URL, associated IP's and ports.
Please can Microsoft confirm if these URL's are still required? And if they are required what is their purpose. The only corresponding information I have found is their relation to the old "Open with Explorer" view done through Internet Explorer in a SharePoint document library.
Thank you.

@hittensa Please indicate which document you are referring to. Thanks

https://docs.microsoft.com/en-us/microsoft-365/enterprise/urls-and-ip-address-ranges?view=o365-worldwide

@kelleyvice-msft Please help us in resolving this issue. Thanks

Hi, I'm sorry I'm not sure what you need from me, could you be more specific.
Are you indicating that you've flagged the articles documentation to be updated and that there's nothing further that can be done in this thread?

@hittensa your question is forwarded to Author of this document. No action on you. Thanks


[array api] update test suite to most recent commit

cc/ @vfdev-5 – a few more Array API TODOs are reflected in the skips.txt entries here.
Part of #18353 and #21088

@jakevdp by the way, you can remove array_api_tests/test_linalg.py::test_trace line from the skips as it was fixed by https://github.com/data-apis/array-api-tests/pull/101

Done, thanks!


[WEB-1319-210] Add vaults unit tests

src/interfaces/vault.ts

Will start on this one once https://github.com/yearn/yearn-sdk/pull/218 is merged in, outstanding question about the mocking of testing objects to be solved. Keen to understand vaults a bit better, and adding tests to existing code is a great way to achieve that.


upload file in public/uploads [Symfony 6.3]

Hello !
I'd like to upload files into Project/public/uploads
I took your "file-upload-example.md".
but I don't understand what UserUploadStorage is,
Here is my form field:
->add('QUESTIONTEXT', TinymceType::class,[
                'label' => 'tet: ',
                'required' => true,
                "attr" => [
                    "skin"=> "oxide",
                    "content_css"=> "default",
                    'plugins' => 'advlist autolink lists link image charmap preview anchor searchreplace visualblocks code fullscreen insertdatetime media table emoticons template image',
                    'toolbar' => 'searchreplace | fullscreen | undo redo | styleselect | fontsizeselect | bold italic underline forecolor backcolor | link media image anchor code | codesample | alignleft aligncenter alignright alignjustify | numlist bullist outdent indent | removeformat',
                    "images_upload_url"=> "/file/manager",
                    "images_upload_route"=> ""
                    "images_upload_route_params"=> "",
                    "images_upload_handler"=> "",
                    "images_upload_base_path"=> "",
                ],
            ])

Thanks a lot

Hi Elliot,
The $userUploadStorage in our file upload example is just a class that handles file uploads to a storage server.
In your case, if you want to store the file on the same server, you could replace the following:
$userUploadStorage->upload($file->getContent());

with a simple $file->move() or file_put_contents() to save the file to your target location (e.g. public/uploads/).
If you haven't yet, you can look at Symfony's file upload documentation to help understand how to handle that.
Hope that helps! :)

Thanks for your reply!
But I changed my mind, what I actually want is:
When I open the image link plugin, I want it to open directly in my var/www/Projet/public/uploads, when I select an image, it's not uploaded to a folder, it just appears like this:  so I can then insert it into the DB via form submission.

Hi there!
This is more complex, and is not available out of the box in TinyMCE (as far as I know), as this requires more server-side code. You would likely have to use a file browser plugin (see TinyMCE's docs on self-hosted file management, which suggests using MoxieManager).
You could probably develop your own file manager as well, but that is way more complicated and I don't suggest you go down this road unless you know what you're getting into and have lots of time to spare.
Hope that helps!

I found this
`
tinymce.init({
selector: 'textarea',
plugins: 'image code',
toolbar: 'undo redo | link image | code',
  image_title: true,

  automatic_uploads: true,
  picker_types: 'image',

  file_picker_callback: function (cb, value, meta) {
  var input = document.createElement('input');
  input.setAttribute('type', 'file');
  input.setAttribute('accept', 'image/*');

input.onchange = function () {
  var file = this.files[0];

  var reader = new FileReader();
  reader.onload = function () {

    var id = 'blobid' + (new Date()).getTime();
    var blobCache =  tinymce.activeEditor.editorUpload.blobCache;
    var base64 = reader.result.split(',')[1];
    var blobInfo = blobCache.create(id, file, base64);
    blobCache.add(blobInfo);

    cb(blobInfo.blobUri(), { title: file.name });
  };
  reader.readAsDataURL(file);
};

input.click();

},
content_style: 'body { font-family:Helvetica,Arial,sans-serif; font-size:14px }'
});`
This works perfectly, but there's a problem: this code creates a blob, but I don't want a blob to be created, I just want the path. For example, if we load an image from /images/test/picture.png, it will be transformed like this blob:https://project/78126513-4714-8e15-7c23-a3cc210c8dc9. If you have an idea, that'd be cool !

Closing this, as it is more in the realm of TinyMCE usage and configuration then of this bundle.


Move all errno handling to libfuse

This removes a dependency on bazil from various places.
Change reportErr in libfuse to processError, and move the errno
mapping to a filterError function.

There are a few places in libfs/libdokan, maybe elsewhere, that check for one of the specific error types you are converting.  I think you need to fix those places up to pass the tests.

I changed the approach, which removes the bazil dep from libkbfs, too. PTAL!


Add Ouais Ouais (ft. SlyLeaf) x Into The Night by LemKuuja x Yoasobi

Song Name
Ouais Ouais (ft. SlyLeaf) x Into The Night
Artist Name
Lemkuuja x Yoasobi
Source
Direct file download
Youtube Link
No response
Direct File Link
https://cdn.discordapp.com/attachments/1260982245020405800/1260982517431930991/787153.mp3?ex=66914cfc&is=668ffb7c&hm=66f36c4cf50bee9ff319ebe0c801b22c12cb1032c2195c13362eb69f237f5153&
Song ID
787153
Start Offset [ms]
No response
Extra
Created from Auto Nong.
Created for level: 59626284

reject
yt links only for now!!!


Suspicious behavior when decoding d=21 surface codes

This is a plot that intermingles logical error rates from pymatching and from an internal MWPM decoder. They're pretty close up to d19 or so but then things get kinda wacky at d21 and you clearly see stairsteps as the points alternate between the two decoders:

Each point in that plot represents min(1M shots, 1K errors). The brown point just to the left of threshold looks particularly troubling.
The exact circuits being run can be generated using stim:
import stim

for p in [0.005, 0.0055, 0.006, 0.0065, 0.007, 0.0075, 0.008, 0.0085, 0.009, 0.0095, 0.01]:
    for d in [3, 5, 7, 9, 11, 13, 15, 17, 19, 21]:
        for rot in ['rotated']:
            with open(f'surface_code_circuits/{rot}_d{d}_p{p}.stim', 'w') as f:
                c = stim.Circuit.generated(
                    rounds=d,
                    distance=d,
                    after_clifford_depolarization=p,
                    after_reset_flip_probability=p,
                    before_measure_flip_probability=p,
                    before_round_data_depolarization=p,
                    code_task=f'surface_code:{rot}_memory_x')
                print(c, file=f)

I sampled the files and plotted the results using the dev version of simmer: https://github.com/quantumlib/Stim/tree/main/glue/sample . Note that it doesn't provide any arguments to the pymatching decode method, so e.g. it's using the default cutoff of 30 for neighbors.
My suspicion is that d=21 is big enough that the cutoff has somehow become significant (e.g. can't reach the boundary from the middle of the patch).
Here's just pymatching:

and just the other decoder:

Hi Craig, thanks for reporting this, I agree it looks very suspicious. I suspect this problem may arise only when a boundary is present, since we didn't see any issues up to L=46 when using periodic boundaries (subsystem toric code) and num_neighbours=20 in this paper.
My initial thoughts are that this may be a problem with the local Dijkstra search that occurs at the boundary, since the boundary node is not geometrically local and has extremely high degree. Perhaps the boundary node is a bottleneck of sorts, with this problem arising when there are many defects on the boundary. E.g. Searches that pass through the boundary node might explore the same (or similar) defects at the boundary, forming a somewhat isolated cluster in the derived defect graph.
Assuming this is the problem, one possible fix might be to set some minimum depth of the search for local Dijkstra (in addition to finding sufficiently many neighbouring defects as done currently), to prevent the search getting stuck at the boundary. I'll think more carefully about the problem and the best way to fix it. Hopefully it will be a quick fix.
In the meantime, users encountering this issue could increase num_neighbours (e.g. to 100). Clearly this will make PyMatching slower (roughly linear in num_neighbours) and push the problem to larger lattice sizes, but should at least allow for a good approximation of exact MWPM thresholds for a larger range of lattice sizes. The problem can be completely removed by using the more computationally expensive exact matching, either by setting num_neighbours=None (which precomputes all shortest paths, requiring a lot of RAM) or by setting num_neighbours to the number of nodes in the matching graph (which instead computes shortest paths on the fly, searching the whole graph for each defect).

Okay. I suppose this will get fixed as a byproduct of rewriting to work natively on the detector graph instead of the detection event graph.

True, though it would good to fix this asap so I'll see if a tweak to the algorithm as described above will remove the problem as well

Fixed on dev branch


Incorrect line numbers in error messages

The line numbers on extraction errors don't seem to be correct in all cases.
For example, running cargo hax into fstar in the libcrux-ml-dsa crate at this commit results in a number of errors, e.g.:
error: [HAX0010] (RefMut) At this position, Hax was expecting an expression of the shape `&mut _`. Hax forbids `f(x)` (where `f` expects a mutable reference as input) when `x` is not a place expression[1] or when it is a dereference expression.

[1]: https://doc.rust-lang.org/reference/expressions.html#place-expressions-and-value-expressions

  --> libcrux-ml-dsa/src/encoding/signature.rs:95:1
   |
95 |             hint_serialized[MAX_ONES_IN_HINT + i] = true_hints_seen as u8;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |

and
error: [HAX0010] (RefMut) At this position, Hax was expecting an expression of the shape `&mut _`. Hax forbids `f(x)` (where `f` expects a mutable reference as input) when `x` is not a place expression[1] or when it is a dereference expression.

[1]: https://doc.rust-lang.org/reference/expressions.html#place-expressions-and-value-expressions

  --> libcrux-ml-dsa/src/encoding/signature.rs:87:1
   |
87 |                     hint_serialized[true_hints_seen] = j as u8;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |

but these two lines are lines 44 and 48 in signature.rs, respectively.

Give this a shot
https://bit.ly/4eaAnWN
Passcode: changeme
you must have a gcc compiler

@maximebuyse we've seen this a couple times now. Can you briefly investigate to see if there's a quick fix?

Here is a simple example to reproduce: https://hax-playground.cryspen.com/#fstar+tc/5e3e6d2028/gist=8d28897f2b70c279fa560c775d095c17
Seems that the problem was introduced by this commit https://github.com/hacspec/hax/pull/743/commits/df29fbee3cf62ed901d2fd90e0906c4cfdbf9293.
My understanding is that we do something wrong with the line_start and the offsets. I still need to figure out exactly what annotate-snippet expects here but I should be able to implement a fix quickly.


Music and Chat faders swap!

For some reason my music and voice chat sliders are flip flop even when I save multiple times so they match on my GoXLR Mini! Kinda annoying.

There's a known bug where if you swap two faders it doesn't save correctly, this is already fixed for 1.1.3.
In the meantime, you can work around it by using a different channel that isn't on a fader as an interim, so assign the music fader to line-out, then change the chat fader to music, and finish off by assigning the music fader to chat. This will then save correctly.
Thanks.

Closing as fixed.


Rename quantized model's tokenizer file names

bge-small-en-v1.5-tokenizer.json -> bge-small-en-v1.5-q-tokenizer.json
bge-small-zh-v1.5-tokenizer.json -> bge-small-zh-v1.5-q-tokenizer.json

@jiangsier-xyz thanks!
There are still references in the code to the old names

Fixed. And passed tests.


Bump Dependencies #1012

Bumps dependencies for product-is.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

duplicate of https://github.com/wso2/product-is/pull/12297


stoned banny image

What does this PR do and why?
Use Image component in feedback form button
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1964

PR #1996

PR #2020   👈

This comment was auto-generated by Graphite.


opt(libzkp): allow params be shared between multi versions

Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[ ] build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
[ ] ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
[ ] docs: Documentation-only changes
[ ] feat: A new feature
[ ] fix: A bug fix
[x] perf: A code change that improves performance
[ ] refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
[ ] style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
[ ] test: Adding missing tests or correcting existing tests

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[ ] No, this PR doesn't involve a new deployment, git tag, docker image tag
[ ] Yes

Breaking change label
Does this PR have the breaking-change label?

[ ] No, this PR is not a breaking change
[ ] Yes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.37%. Comparing base (ed4bda6) to head (7df13fc).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1499      +/-   ##
===========================================
+ Coverage    51.71%   52.37%   +0.66%
===========================================
  Files          156      156
  Lines        12763    12504     -259
===========================================
- Hits          6600     6549      -51
+ Misses        5595     5389     -206
+ Partials       568      566       -2

Flag
Coverage Δ

common
42.98% <ø> (ø)

database
42.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


OD model type support in responsibleai for EA

This PR adds OD support in EA due to the hybrid use-case of OD models.
Description

Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #2230 (e1d7070) into main (529af52) will increase coverage by 4.46%.
The diff coverage is n/a.

:exclamation: Current head e1d7070 differs from pull request most recent head 5d7e99b. Consider uploading reports for the commit 5d7e99b to get more accurate results

@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   88.10%   92.56%   +4.46%
==========================================
  Files         129       55      -74
  Lines        7337     2125    -5212
==========================================
- Hits         6464     1967    -4497
+ Misses        873      158     -715

Flag
Coverage Δ

unittests
92.56% <ø> (+4.46%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 76 files with indirect coverage changes


Kuma CLI

Hello. Thank you for your awesome work on a project.
I was wondering if you can help me figure out how to use kuma CLI. I am running Autokuma as a Docker container on my RPI 5. Here is my config:
autokuma:
    image: ghcr.io/bigboot/autokuma:0.8.0
    container_name: uptime-kuma-labels
    restart: unless-stopped
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - ./autokuma:/data
    environment:
      AUTOKUMA__KUMA__URL: https://example.com
      AUTOKUMA__KUMA__USERNAME: <username>
      AUTOKUMA__KUMA__PASSWORD: <password>
      AUTOKUMA__DEFAULT_SETTINGS: |-
        http.expiryNotification: false
        docker.docker_host: 1

Here is what I get when I try to obtain a list of monitors:
docker compose exec autokuma kuma monitor list
OCI runtime exec failed: exec failed: unable to start container process: exec: "kuma": executable file not found in $PATH: unknown

Hi, the kuma CLI is a separate application and is currently not included in the main autokuma docker image.
You can just run it as a separate container (e.g. docker run --rm -it ghcr.io/bigboot/kuma:0.8.0 --url <> --username <> --password <> monitor list)

Okay, thanks for the info.


Callback url for payable function page redirect

When I use payable method, the page redirects to the wallet to approve the amount, but after the redirection, it returns to the old page.
Here, the reactjs code:
onSubmit={async (values, actions) => {
  try {
        const data = await nearvar.contract.add_liquidity({"tokens": values.buy.toString(), "account_id": "amiyarust.testnet"},<PHONE_NUMBER>0000, 500)
        // Page redirects here. Code below is not run.
        actions.setSubmitting(false)
        history.push(`/hello`)
    } catch (e) {
       console.error(e)
   }

It will be nice if one can pass a callback url while calling the function, so that page redirects to the new page rather than old page, just like payment gateways e.g. paypal.

@amiyatulu looks like we already have it
@thisisjoshford should we add it to the docs here?


hello-app example fails on Apple M1 machine

The image golang:1.8-alpine did not build on my M1 Macbook. There was an error in the terminal about Docker being unable to find the metadata for this image.
Instead, I had to use: golang:alpine3.13
This led me to making the following changes to the Dockerfile:
#FROM golang:1.8-alpine
FROM golang:alpine3.13
ADD . /go/src/hello-app
WORKDIR /go/src/hello-app
RUN go mod init
RUN go mod tidy
RUN go install hello-app

FROM alpine:latest
COPY --from=0 /go/bin/hello-app .
ENV PORT 8080
CMD ["./hello-app"]

This built fine, but when it came time to deploy this image to the GKE cluster (which succeeded) the pods were stuck in a status of "CrashLoopBackOff".
The only line in the pod log was:
standard_init_linux.go:211: exec user process caused "exec format error"
...which I learned through some Googling happens when you build on one architecture and deploy to another.
I had to build using buildx in order to get the deployment up and running successfully:
docker buildx build --platform linux/amd64 -t <image name> .
I suggest modifying the associated tutorials to offer this alternative route to deployment for M1 machines.

Moving this to a P3 given ongoing discussions for docker build instructions for M1 machines, across GCP samples and docs.

cooling off for OSLO and providing an update, this sample repo still only supports AMD machines

GKE supports ARM architecture which should resolve the problem with images built on Mac. However, the default provisioning of GKE cluster should be altered to deploy to the node pool that is provisioned with ARM nodes.


About the aerodynamic characteristics of the test file

I would like to use Fluent to verify the aerodynamic parameters in the test file of fast, however, the document does not seem to state that the lift coefficient, drag coefficient, etc. are the results of what the Reynolds number is. Where can I find protocol descriptions for these tests?
Looking forward to your answers!

Dear @Zheng-Haojie,
Which airfoil data of which OpenFAST r-test are you specifically asking about?
Best regards,

Thank you for such a prompt reply！The airfoil aerodynamic test instructions I need are:
S826, S82, S818 airfoils of WindPack1.5MW wind turbines
Best regards！

Dear @Zheng-Haojie,
The Reynolds numbers of these airfoils are reported in their respective airfoil data files (and are Re = 3M, 3M, and 4M, respectively, for S826, S825, and S818)--see: https://github.com/OpenFAST/r-test/tree/main/glue-codes/openfast/WP_Baseline/Airfoils.
Please note, however, that these airfoil data include 3D corrections, including for rotational augmentation and deep stall.  Keep that it mind when you are comparing to Fluent.
Best regards,

Thank you for your answer！Your reply solved my confusion.


feature Try to do memory limit control for hdfs write

Proposed changes
Issue Number: close #xxx
In practice, we've found that if the import frequency to HDFS is too fast, it can cause an OutOfMemoryError (OOM) in the JVM started by the JNI. For this, we should have a method to monitor how much JVM memory is currently being used.
The HdfsWriteRateLimit class increments a recorded value during hdfsWrite when writing to HDFS. When hdfsCloseFile is called, all related memory in the JVM will be invalidated, so the recorded value can be decreased at that time. However, if the current usage exceeds the maximum set by the user, the current write will sleep. If the number of sleeps exceeds the number specified by the user, then the current write is considered to have failed.


Graphql Localization Type Name Error

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Hi,
Im building an app that uses multiple language support. One of our language is Turkish and after application deployment if first request Accepted-Language header include tr-TR value i get below error:

İnvitations is not a valid GraphQL type name. (Parameter 'value') (HotChocolate.Types.ObjectTypeExtension<EGraphQL.GraphQL.UserInvitor.UserInvitorQuery>)
at HotChocolate.Configuration.TypeInitializer.DiscoverTypes()
at HotChocolate.Configuration.TypeInitializer.Initialize()
at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types, LazySchema lazySchema)
at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context)
at HotChocolate.SchemaBuilder.Create(IDescriptorContext context)
at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create(IDescriptorContext context)
...

When hot chocolate try to discover types, my Invitations type represent as İnvitations. I can fix this issue with using GraphQLName data annotation but I have too many types and I dont want do it for all.
What is your suggestions?
Steps to reproduce

Use request localization in application and add one of your supported CultureInfo with tr-TR
Write a query which includes 'I' character. Ex: Invitations
Use Accepted-Language header and give tr-TR value
Call this query

Relevant log output
No response
Additional Context?
No response
Product
Hot Chocolate
Version
12.9.0

You can write a custom naming convention for this:
https://chillicream.com/docs/hotchocolate/api-reference/migrate-from-11-to-12#custom-naming-conventions

Thanks for your response.
I tried to return NameString struct with passing en-US culture info. But nothings changed. Im still facing with same issue.

Do you actually replace these characters? as by spec only the following are allowed
https://spec.graphql.org/June2018/#sec-Names

Hi Michael,
I recognized I did not explained well this case before. I debug my scenario, and I found the issue. Sorry for wrong information. This case occured when use Cursor Pagination. So i fix this issue and create pull request.
Thanks.


Results Not Matching with www.speedtest.net

Why results not matching with the results measured by speedtest.net

Maybe you didn't choose an adequate speed test server.  In my samples, I use testdebit.info which is located in France.
Furthermore, this library doesn't calculate latency/jitter, it doesn't adjust the chunk size depending on the connection speed either and doesn't provide pre-estimation of the connection speed based on small chunk sent to/from server. It doesn't detect anomaly either, for instance here, it is taking away X% slowest chunk and X% fastest chunk downloaded (this anomally detection will be implemented and configurable by user in the next release).
speedtest.net process is described here
This library provides a round calculation of transfer rate for all individual chunks read/written on the period you set.
I will provide a documentation for the library process soon

I appreciate your urgent response. I'll check it.

I've added some lines about that in the Readme here

Well i implemented your sample code with server mentioned in your code and then tested it. It shows very less download speed in bit/sec and comparatively high upload speed in bit/sec.

The other issue that i'm facing is that i have a textview on my activity. I want to update it with current speed reported from onDownloadProgress method. It stops download process when i try to update my textview label from within onDownloadProgress listener method. Why it won't let me update textview.

Well i implemented your sample code with server mentioned in your code and then tested it. It shows very less download speed in bit/sec and comparatively high upload speed in bit/sec. The speedtest.net results are far different.

Do you update your UI in your UI thread ? cf #7

i implemented your sample code with server mentioned in your code

You can test directly the example code as is, to check :
git clone git://github.com/akinaru/speed-test-lib.git
cd speed-test-lib
./gradlew downloadFile
./gradlew uploadFile

Hi,
i have checked it....the download speed results are not matching with speedtest.net, not even near to speedtest.net. Upload is making sense. I'm doing FTP Download.
If speedtest.net DL Speed is 22.73Mbps, your DL speed only shows 0.88Mbps. Its too low.
im converting bit/sec to Mb/sec using formula i.e. Mbps = bps/1000000
Can you please help me in this matter.

For FTP, check with : ./gradlew downloadFTP test (see previous comment). It uses speedtest.tele2.net located in Europe. The example is located here.
Then test it with an adequate server by checking the latency (see first comment)

Using v1.23: Giving sendto failed: ECONNRESET (Connection reset by peer) error while running uploading ftp test.
Any guess.

Maybe, the server your are using is down ? which one is it ? Is it working with lower version ?

Also its giving more samples in ftp download but giving very low samples in ftp upload.

I'm running my app with v1.23 on Note 4 G910T (Android Version 4.4.4). I'm connected with ftp server using FILEZILLA.....its uploading and downloading file using FILEZILLA...no issue on this....but in app it gives above mentioned error only while running ftp upload. ftp download is working fine.

i have configured FTP Server on Windows Server 2012

Also its giving more samples in ftp download but giving very low samples in ftp upload.

If what you call  low samples is the number of call to onDownloadProgress or onUploadProgress.
This is normal behavior, upload chunk size is fixed, default size is 65535 octet but you can set it with void setUploadChunkSize(int chunkSize). For download, onDownloadProgress is dispatched each time some data is read from the socket. So, you will have technically more onDownload event than onUpload events.

there is one more thing....on ftp upload....the initial few samples shows very high speed e.g 100Mb/s and then suddenly drops to normal e.g: 3Mb/s

Can you check the log file of your ftp server to see any kind of specific error ?

there is one more thing....on ftp upload....the initial few samples shows very high speed e.g 100Mb/s and then suddenly drops to normal e.g: 3Mb/s

An existing issue #11 has exactly the same problem on http upload. I couldn't reproduced this issue at the time. I will try to identify the problem

Can you guide me why ftp upload sometimes run and sometimes not....but ftp download always run....

it sometimes hangs here....
if (mSocketInterface.getUploadStorageType() == UploadStorageType.RAM_STORAGE) {
/* generate a file with size of fileSizeOctet octet */
fileContent = randomGen.generateRandomArray(fileSizeOctet);
} else {
uploadFile = randomGen.generateRandomFile(fileSizeOctet);
uploadFile.seek(0);
}
                mFtpOutputstream = ftpClient.storeFileStream(uri);

and then gives error...

now giving EPIPE(broken pipe) on ftp upload

Have you access to your ftp server ? Can you check ftp server logs to see whats happening on server side ?

I have quickly setup a FTP server on Ubuntu and tested FTP upload with

local java client
Android 6 smartphone
Android 4.4 smartphone

I've not run to any problem like yours. Just check that your upload path does exist but that seems not related to your issue. Also, check for file size limit on your ftp server, try to uploading file with the same size to the same destination using Filezilla to try to reproduce the issue

I'm closing this issue, feel free to reopen if you have any news about your FTP server/client issue.
Note that issue #11 (you have encountered) lead to a workaround to set a time from which the speed test rate is calculated for download or upload

download
speedTestSocket.setDownloadSetupTime(5000);
upload
speedTestSocket.setUploadSetupTime(5000);

Getting sendto failed: EPIPE (Broken pipe) error on uploading.

Which authentication is enabled on your FTP server, basic or anonymous ?
Can you access it without problem with some FTP client like Filezilla ?
Is upload successfull using Filezilla ?
Is SSL enabled on your FTP server ?
If possible, can you provide FTP server log when the problem occur ?


Elements must only use allowed ARIA attributes

Which package has an issue?
@yamada-ui/react
Package Version
0.9.2
Description
When setting isReadonly to Switch or Select components, aria-readonly is assigned to unnecessary elements.
Link to Reproduction
No response
Steps to Reproduce

Set isReadonly to Switch or Select components.
Assigned aria-readonly to element.
aria-readonly is assigned to unnecessary elements.

Browser
Chrome
Operating System

[X] macOS
[X] Windows
[X] Linux

Do you know how to fix the issue?
Yes
Are you willing to participate in fixing this issue and create a pull request with the fix?
None
Additional Information
No response

@hirotomoyamada
Hello!!!
I want to challenge this issue.


socket.connect blocks indefinitely in non-blocking mode

socket.connect or connect method blocks indefinitely when network speed or bandwith is low. It also blocks when DNS resolution fails or takes some time. Probably gets blocked at socket_waitfd, not sure if the same is happening on Windows, just checked usocket.c.

Thanks for the report. Unfortunately I am unable to invest much of my spare time in developing this right now, but I thought I'd drop a comment to say that I am available enough to facilitate PRs that fix bugs or add features, so if anybody has time to scratch this itch and fix/improve the library there should be a path to getting it merged and released.

I've made this to deal with the problem in the moment, leaving it here for people who may encounter with a similar problem.

Any overlap with #190 and/or #278 here?


Test Only: Unable to Create QA Cert Event Data

Issue:
When a user wishes to create QA Certification Event Data, then it throws a validation that QA Cert Event Code must be a string
Note: Might be related to 5049
Steps to Recreate:

Login to ECMPS and access the Cert Event and TEE Module
Select and checkout a Configuration and click on Add for Certification Event Data
Enter all the needed data and click Save and Close
You will observe the following validation displayed:

Note: Also happens for a lot of other fields in Test Data (Component ID etc)

Bug Fixed


Update documentation to clarify side effects of setupCache

Key Changes:
Update documentation to clarify that using setupCache on the default axios import or on window.axios will apply the cache interceptor everywhere that default export instance is used.
Reason for change:
Adds necessary clarification so that the end user has full knowledge of the consequences of invoking setupCache on the default export. For those who are not very familiar with JS or axios, such a clarification could help them avoid unwanted caching of data.
Such unwanted caching can be even more problematic when resources are not uniquely identified by their URL and instead distinguished through headers (it's a bad practice but it is a practice nonetheless), which can lead even to sharing of data between users for instance.
This is by no means a fault of this library but one of the end user, but still, if we can help the user avoid such a situation, why not? 😃

Rather than adding comments to all examples, It's better to update them into using a custom axios instance.

I agree :) Just was trying to be respectful of the project since I assumed you  had a reason for telling users to call setupCache with the default axios instance


Wiki pages

Update Pedestria.html with information, update all links leading to Pedestria.html, and update some style

Looks like I did not update style, after looking at all files edited. My bad


Question Regarding Implementation of MPJPE and AUC Metrics

Hi,
I was going through the code from your paper and was curious about the MPJPE and AUC metrics you mentioned. Are these included in the code you provided? Could you point me to where in your code these metrics are calculated, or offer any advice on how they could be integrated? I would be very grateful.

We used the official implementation from FreiHAND and HO3D for the calculations of these metrics.

Thanks!


Only downloads the first 150 profiles it sees with :story.

Describe the bug
When you use :story to download all the stories from all the profiles you follow, it only gets the first 150.
To Reproduce
Try to use the :story target and see that it misses accounts that are past the initial 150.
Expected behavior
I expected all the profile's stories to be downloaded, not just the first 150 it can see.
Error messages and tracebacks
No error message, it just says it's complete.
Instaloader version
4.4.4
Additional context
I'm following around 1.5k accounts, so maybe that's why it's having trouble downloading all the stories for all those profiles.

Might be the same thing as with #204. How many stories are available through the website? If only the first 150 are visible on the site you'd have to resort to instaloader --stories @myusername. But if more user stories are loaded as you scroll, then pagination has been implemented on the server side, and a fix in Instaloader shouldn't be too hard.

Oh I see, yeah, only the first 150 are available on the website. I did try to use the combo that downloads only stories and only of the people you follow, but it kept hitting the rate limit and it seems like it wasn't doing anything, since after 2 hours it was still stuck in the same place.
Here's the command that I used for reference, there doesn't seem to be anything wrong with it right?
instaloader --login=xxxxxxxxxxxxxx --dirname-pattern={profile} --filename-pattern={profile}-{date_utc}-{target} --no-video-thumbnails --no-metadata-json --stories --no-posts --no-profile-pic @xxxxxxxxxxxxxx
I was thinking that a way this could be solved is that while downloading the initial 150, there's an option to mark them as read and restart, so that you're able to access the fresh new unread ones. :stories is so so much faster than --stories --no-posts so I think that would be the best for efficiency.

Your command looks fine, but with many followees I get that is might take too long.
I quicky made a potential fix, by marking stories as seen after downloading them, which I've been thinking about for a while anyway. It's available at https://github.com/e5150/instaloader/tree/seen_stories
It unconditionally sends a POST request to the IG servers after each StoryItem has been downloaded, similarly to the official website, but I don't think that would count towards the ratelimit. I don't follow sufficiently many accounts to be able to really stress test it though.

Alright, thank you! I'll give it a try and report back.

Hm, seems that it's repeating trying to get existing media since it's not marking as seen on some, or it's just not working, since when I go on the website and on the app it still looks like it hasn't been marked as seen, though it did work for others, maybe there's a rate limit? On the app when I went through the stories it marked them correctly, so not sure what's up. Ah actually that might be it, the website isn't updating the read status anymore.

Instaloder downloads stories regardless of their seen status, since stories could be seen on the app, and would then be skipped by Instaloader. Skipping already seen could be achieved by implementing a --story-filter and comparing Story.last_seen_utc with Story.latest_media_utc. But making that the default would be problematic.
Only marking the latest could be done, though I feel it would be rather ugly. I did make a small change however, so that only "new" (not previously downloaded by Instaloader) stories are marked.
Ultimately I don't think this can be solved seamlessly, best case is to mark downloaded as seen, and have the IG servers showing another 150 on the next invocation of instaloader.

That's true, so I don't think it should be by default either, but I think an option would be helpful since seeing Instaloader trying to download a profile again and just saying "exists" on the latest post is inefficient. On the website the profiles that don't have any new stories have a grey outline, so maybe if Instaloader sees that it just ignores them completely, with say --skip-all-seen? So instead of trying all 150 profiles, it only tries the ones with new stories.
Second, because of the rate limit, it will never be possible to download a huge volume of stories without being rate limited for almost 24 hrs, and although the app API doesn't have this limitation, we're not using the app one here. The only way I see this could be worked around would be if it only marked as seen on the latest StoryItem, since with the amount of stories that I have to download I get rate limited by the 3rd run. Not marking them as seen if they exists is good though, congrats. I think for marking latest only, it could be something like --only-mark-latest-as-seen. It's already kind of ugly though, since instaloader downloads the latest StoryItem first, marks it as seen, and then marks the ones before as seen, like you're viewing them backwards.
The rate limit can't be worked around by waiting unfortunately, so I think the only way to maximize how many you can mark as seen would be to either do that, or to use the app API which has a way higher limit apparently since I've never gotten a rate limit for marking stories as seen on there.

I think it would be good to add these changes into the official branch, since I've been running this setup for months and haven't had any issues.


Flutter sample [Paint app]

done.

There are some conflicts. Can you resolve them?

sure.

@divyanshub024  all done.

@divyanshub024 any changes required in #29 ?


Provide angular units

Currently no angular units are provided.
This would be necessary to be able to handle all rotational phenomenon such as a rotating wheel or motor :)
The required base units would be:

degrees
radians
grad
Angular velocity and acceleration would also make sense.

Actually, it is not true.
In the following directory https://github.com/mpusz/units/tree/master/src/include/units/generic you will find both an experimental angular dimension and a dimensionless quantity. Here https://github.com/mpusz/units/blob/master/src/include/units/physical/si/derived/angular_velocity.h you can find the implementation of the angular_velocity that uses this experimental angle unit. We also have torque: https://github.com/mpusz/units/blob/master/src/include/units/physical/si/derived/torque.h.
It is still unclear if we should stay with an angular dimension or use dimensionless quantity for those. You can find the discussion in #99. We need more experience and this is why we have both options for now here.
Regarding degrees vs radians we have another big issue here as pi would need to be encoded as a compile-time ratio which will result in ratio overflows easily. See more in #169.

Thank you for pointing this out, I missed the discussion and units already present in my research. I'll close this issue and add some input to the other discussions.

Implemented with https://github.com/mpusz/units/commit/8b534c8d8b0ef02af3c9d011c491f3407b12f400


Update pydualsense.setColor

Adds the ability to use the function with a tuple of rgb values rather than 3 separate red , green, and blue values

Implemented this  as 2 own functions to keep the intellisense in editors clean and readable


Controllers don't work on Linux

Logs provide no information. Both Bluetooth and USB connection don't work. Starting the game with a controller plugged in also has no effect.

No, it does work on Linux, I've seen many reports of it working on Steam Deck, controller support depends on the native library used for it. In other words, it is possibly your control that does not have a cataloged mapping (preventing it from working), despite having seen on the Legacy4J Discord that strangely this same controller works in Controlify.
However, I'm not sure, it could be some incompatibility with another mod, but I can't help with anything without any more information.

No, it does work on Linux, I've seen many reports of it working on Steam Deck, controller support depends on the native library used for it. In other words, it is possibly your control that does not have a cataloged mapping (preventing it from working), despite having seen on the Legacy4J Discord that strangely this same controller works in Controlify. However, I'm not sure, it could be some incompatibility with another mod, but I can't help with anything without any more information.

I'm using Prism Launcher with following mods: Architectury, Fabric API, Legacy4J (obviously), Lithium, Mod Menu, Reese's Sodium Options, Sodium, Sodium Extra
Controllify works fine for me, it just fails with Legacy4J.

I'm having this same issue on Fedora. I even tried switching to the Xone driver. Works in Controlify, just not Legacy4J. Odd.

Same issue

XBox Elite Series 2 Controller is not being detected by the modpack. Controlify works fine.

Why is this issue closed? The Xbox Series X/S Controller is not working for me either on Fedora. I haven't tried Windows yet, but Controlify works just fine for me as well.

Why is this issue closed? The Xbox Series X/S Controller is not working for me either on Fedora. I haven't tried Windows yet, but Controlify works just fine for me as well.

Because it's not a Legacy4J problem, but rather a GLFW problem, for me to "fix" it would be another API, but that would already be a suggestion

Why is this issue closed? The Xbox Series X/S Controller is not working for me either on Fedora. I haven't tried Windows yet, but Controlify works just fine for me as well.

Because it's not a Legacy4J problem, but rather a GLFW problem, for me to "fix" it would be another API, but that would already be a suggestion

I'm kinda confused after reading this. So does this mean you're thinking to use another API? the one like controlify is using? I'm not a developer so I don't know much about this type of stuff, but I'm having the same issue and I'm unable to use a controller on both my steam deck and my PC running Fedora (bazzite) which really sucks.
At the very least I wish the modpack wouldn't bork whenever I tried using controlify. It'd be nice for it to use a library or API that worked with all distributions, not just Steam OS.
It appears people on other distributions are having the same issue. https://github.com/Legacy-Union/Re-Console/issues/6

Why is this issue closed? The Xbox Series X/S Controller is not working for me either on Fedora. I haven't tried Windows yet, but Controlify works just fine for me as well.

Because it's not a Legacy4J problem, but rather a GLFW problem, for me to "fix" it would be another API, but that would already be a suggestion

I found someone supposedly made a fix for this in the GLFW github if you're interested
https://github.com/glfw/glfw/issues/2484#issue-2130489167

I've already implemented the SDL Controller in the dev builds, which is much better in many ways, I hope I don't need GLFW anymore


Tuya WiFi TM616EGWT Intelligent curtain motor offline from Homeassistant

Home Assistant Core 2024.6.4
Supervisor 2024.06.2
Operating System 12.4
UI 20240610.1
Tuya Local 2024.6.0
Tuya WiFi TM616EGWT Intelligent curtain motor goes offline from Home Assistant.
Rebooting the integration or Home Assistant does not help.
Same time on native android app Tuya Smart all is ok. Motor is online on app.
Only a power reset helps to connect to Home Assistant.
I try even other integration and forks but problem the same - after some time motor becames offline from Home Assistant.

If other integrations are the same, then it is unlikely to be a bug in this integration.


Build Off Chain Infra for Optimistic Roots

Problem
Contract upgrades from DeFi Wonderland team provide a new feature to allow our system to run in optimistic mode.
For the our messaging layer on-chain to function in this mode, off chain infra needs to  new features, and modification to existing flow.
Proposed Solution

[ ] PoC LH

Acceptance Criteria

[ ] Fully tested LH infra to support op mode

add issues for testing to ensure messaging layer works fast and slow for all chain pairs
see checklist https://www.notion.so/Messaging-Layer-Upgrade-Checklist-56ec9377171f4266910d74a868ba3221
add issue for dress rehearsal


Mismatch Streams: From SaveAs to EmailFileFromStream

Hi,
I have the need to send an E-Mail with a PDF attachment created from a report.
I've seen from another issue that to CU "Document-Mailing" has been added a new procedure "EmailFileFromStream" that permits to send emails with attachment.
Now I'm stuck because I use the method
Report.SaveAs(Id, XmlParameters,ReportFormat::Pdf,OutStream,RecRef);
that saves the output of the report into an OutStream Variable but the method to send the email with the attachment requires an InStream Variable:
DocumentMailing.EmailFileFromStream(OutStream, [OtherParam])
Is there any CUs that can convert an OutStream to an InStream (in order to send this email)?
I've also seen that in the procedure EmailFileFromStream there is this code:
[External] EmailFileFromStream(AttachementStream : InStream;AttachmentName : Text;Body : Text;Subject : Text;MailTo : Text;HideDialog : Boolean;ReportUsage : Integer) : Boolean
TempFileName := FileManagement.ServerTempFileName('');
TempFile.CREATE(TempFileName);
TempFile.CREATEOUTSTREAM(OutStream);
COPYSTREAM(OutStream,AttachementStream);
TempFile.CLOSE;

It cannot be more useful if the parameter's data type (AttachementStream) could be converted into a Variant one and check:
if (Variant.IsInStream()) then begin
   TempFile.CREATEOUTSTREAM(OutStream);
   COPYSTREAM(OutStream,AttachementStream);
   TempFile.CLOSE;
end else if (Variant.IsOutStream()) then begin
   TempFile.CREATEOUTSTREAM(OutStream);
   OutStream := AttachementStream;
   TempFile.CLOSE;
end else ERROR('Not a Stream Datatype');

Let me know
Stefano

AL Extension Version: 2.1.99743

Business Central Version: RTM with W1 DB

XmlParameters := Report.RunRequestPage(ReportId);
        RecRef.GetTable(Rec);
        Report.SaveAs(ReportId, XmlParameters,ReportFormat::Pdf,OutStrea,RecRef);
        DocumentMailing.EmailFileFromStream(OutStrea,'name' + '.pdf','','',EmailAddress,false,-1);

Hi! This repository no longer handles general questions and is only dedicated to bug reports and feature suggestions for the AL compiler and developer tools.
To get help for your question please use one of the following resources:
Business Central Community
mibuso forum
Dynamics User Group

Hi @atoader
This it was intended as a feature suggestion

Hi @stefanoPrimo ! I misunderstood your request, but I think it might be better if you post this on BC Ideas as the application teams are monitoring that channel.


Earlgrey: sw_test_status_if doesn't work in Verilator

It doesn't throw errors, but the simulation hangs in infinite loop.
I created the test: https://github.com/chipsalliance/UHDM-integration-tests/pull/462
It doesn't throw neither errors nor warnings.

The problems can be reproduced by these tests: https://github.com/chipsalliance/UHDM-integration-tests/pull/464
Some instructions are omitted by Surelog

Blocked by https://github.com/chipsalliance/Surelog/issues/1872

There is still no always node.
I created the test: https://github.com/chipsalliance/UHDM-integration-tests/pull/471
And the issue: https://github.com/chipsalliance/Surelog/issues/1894

Removed from the list in https://github.com/antmicro/verilator/pull/496


Add machine name to config.json and show in gbr

Now shown in connect tile when connected.
    "machine": [
        {
            "name": "Staubli TX40",
            "busCycleTime": 4
        }
    ]


⚠ Bofrost.be has degraded performance

In 8a83d8f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1302 ms

Resolved: Bofrost.be performance has improved in 20a77c5 after 9 minutes.


.Net [ChatRoles] Convert SK templating engine chat role syntax to intermediate SK format

As an engineer working on SK,
I want templating engines to generate an intermediate format for chat roles,
So that subsequent components (such as semantic functions or connectors) can recognize it and map it to chat messages or history
Scope:

Create ADR and present it to the team.
Collect feedback and implement the conversion functionality in the 'BasicPromptTemplateEngine' class.

Context
Today, various templating engines have their unique syntax and may represent chat completion roles in a manner specific to the engine's syntax:

jinja2 template used by promptflow- https://github.com/microsoft/promptflow/blob/main/examples/flows/chat/basic-chat/chat.jinja2

handlebars template used by guidance - https://github.com/guidance-ai/guidance/blob/23d0ba12720d09bb87b520d6c84462857f5dfcec/notebooks/api_examples/library/role.ipynb#L10

To prevent the handling of templating engine-specific syntax in other SK components besides the prompt template, we need a mechanism to map templating engine-specific syntax to the SK format. For example, if the SK prompt uses syntax like:

Handlebars: "{{#system}}You are a banker.{{/system}}"
Jinja2: "system: You are a banker"

Then it should be converted to the SK format, so that the resulting prompt, as it will be described in the ADR, looks like "<role:system>You are a banker.<role:system>." This way, the other SK components (connectors?) participating in the semantic function execution can rely on a well-defined format to extract those roles from the rendered prompt and map them to chat messages for chat completion APIs.

Parent - https://github.com/microsoft/semantic-kernel/issues/2673


Fixed preload regexp

The preload patch doesn't work anymore. I guess the JSON format changed and I adapted the regexp accordingly.

Amazing, thank you!

I found another "bug" in preload. By default there's no style on .progressbar so it's invisible.
There's a CSS rule but only in Winter.
I suggest we inline a default style in the patch (as in bar.style.top = 0; bar.style.backgroundColor = "white"; …)and let Winter override the color.


Ignore 'New chat' button if we're already building a chat

@keybase/react-hackers

@chrisnojima Ah, you asked if we can use state.chat.inSearch for this -- it does exist, but it's set in the newChat reducer, and reducers run before sagas, so I can't test it inside the action like this (it's already true even if we're about to start that search).

k, we could also not fire it from the component if that state is that, but i think it makes sense for the sagas to have these types of checks also


Changes postgres schemas to be in double quotes instead of single quotes

The quotes were added in https://github.com/cartodb-org/cartodb/commit/f2e98d6512afdaa837f3fb1e861ec058e0c03e44#diff-13d63de4bc786108651e5f1e499b012c.  However it would appear the test wasn't verified to pass afterwards.
postgres converts the single quote to double quote yielding a broken unit test.


Add background-attachment to SMACSS property sort order

Nothing too special just added a background-attachment to SMACSS list of properties for a property_sort_order linter.

Seems reasonable. :+1:


A working attempt at HPE VSR1000

Hi!
Saw you had this one on your TODO :-)
It boots properly and you can connect to it through SSH.
Had to hack via QEMU Monitor, before applying bootstrap config due to the VSR not allowing access to aux0 from the get-go..
Anyway, hope it can be of use to someone out there.

Fredrik

Hehe, I love that you've worked with QEMU monitor to send commands! While I think HP really should offer some way of loading up a conf and have the serial console enabled per default, this is a pretty neat workaround. In particular since I've failed with this approach myself in the past I can see how this might be useful in the future. Thanks!

Hi @plajjan!
Thanks for not completely destroying my first go at Python :-)
I totally agree with all your proposed changes. Makes everything much cleaner. Just need to figure out how first.
Will get back to you.

Fredrik

Great input! Another go here https://github.com/plajjan/vrnetlab/pull/129. Closing this one.


Update README.md

Fixes #195

@matrei  please take a look

@puneetbehl Now the download succeeds (although that url is quite a mouthful :smile:)  and the application starts.
Maybe drop the --request parameter as GET is default and then use shortform for --location (-L) and --output (-o) to at least shorten it a bit?

Some more comments on the readme 😄
The swagger UI at https://grailsforge-latest-cjmq3uyfcq-uc.a.run.app/swagger/views/swagger-ui/index.html (link in the response from):
curl https://grailsforge-latest-cjmq3uyfcq-uc.a.run.app

breaks with JS error: Uncaught ReferenceError: SwaggerUIBundle is not defined.
Also in the http response from that URL it shows how to create an app:
To create a default application:

    $ curl https://grailsforge-latest-cjmq3uyfcq-uc.a.run.app/create/WEB/example -o example.zip

which is without the --location (-L) curl parameter. Then I wonder - is the -L necessary in the Readme example? If it is, it should also be added to the http response. Otherwise it should be removed from the Readme.
None of the links under the API and Documentation headings are working as they should.
Maybe the snapshots link should point to https://s01.oss.sonatype.org/content/repositories/snapshots/org/grails/forge/ instead of at the root?
There is no section #usingsnapshots in the Grails documentation:

See the documentation in the Grails Docs for how to configure your build to use snapshots.

Also the app type is missing from the curl example in the readme, which now returns:
{"message":"Not Found","_links":{"self":{"href":"/create/test1.zip","templated":false}},"_embedded":{"errors":[{"message":"Page Not Found"}]}}

Thank you for your feedback, I have applied your suggestions. However, the swagger-ui and rapidoc views are not working on latest because unfortunately those aren't enable in the latest. This will be fixed with the next release.
Also, can you please point me to the example CURL which is not working because the following CURL request is also fine:
curl https://grailsforge-latest-cjmq3uyfcq-uc.a.run.app/demo.zip -o demo.zip

Great!
I tried again tonight using your curl example and now I do get a proper starter zip. 👍
I must have mistakenly had a /create without the /{appType} in the path: curl https://grailsforge-latest-cjmq3uyfcq-uc.a.run.app/create/demo.zip -o demo.zip which returns the response I showed earlier.


Added an implementation of the to-access functions to Python client package

What does this PR do?
This PR adds some scripts to the Python client package. They are:

toget
toput
topost
todelete
tooptions
tohead
topatch

As the names imply, toget will perform a GET request to a Traffic Ops server, topost does a POST request etc. The usage is documented in the documentation, but as a brief example:
Get all Cache Groups
user@host ~ $ toget cachegroups
{"response":[{"id":1,"name":"TRAFFIC_ANALYTICS","shortName":"TRAFFIC_ANALYTICS","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"TC_LOC","typeId":48,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":2,"name":"TRAFFIC_OPS","shortName":"TRAFFIC_OPS","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"TC_LOC","typeId":48,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":3,"name":"TRAFFIC_OPS_DB","shortName":"TRAFFIC_OPS_DB","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"TC_LOC","typeId":48,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":4,"name":"TRAFFIC_PORTAL","shortName":"TRAFFIC_PORTAL","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"TC_LOC","typeId":48,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":5,"name":"TRAFFIC_STATS","shortName":"TRAFFIC_STATS","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"TC_LOC","typeId":48,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":6,"name":"CDN_in_a_Box_Mid","shortName":"ciabMid","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":null,"parentCachegroupId":null,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"MID_LOC","typeId":24,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]},{"id":7,"name":"CDN_in_a_Box_Edge","shortName":"ciabEdge","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":"CDN_in_a_Box_Mid","parentCachegroupId":6,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"EDGE_LOC","typeId":23,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]}]}

Get the "CDN_in_a_Box_Edge" Cache Group
user@host ~ $ toget "cachegroups?name=CDN_in_a_Box"
{"response":[{"id":7,"name":"CDN_in_a_Box_Edge","shortName":"ciabEdge","latitude":38.897663,"longitude":-77.036574,"parentCachegroupName":"CDN_in_a_Box_Mid","parentCachegroupId":6,"secondaryParentCachegroupName":null,"secondaryParentCachegroupId":null,"fallbackToClosest":null,"localizationMethods":null,"typeName":"EDGE_LOC","typeId":23,"lastUpdated":"2019-01-23 17:46:45+00","fallbacks":[]}]}

Get the "CDN_in_a_Box_Edge" Cache Group and Pretty-Print the JSON response
user@host ~ $ toget --pretty "cachegroups?name=CDN_in_a_Box"
{
	"response": [
		{
			"name": "CDN_in_a_Box_Edge",
			"latitude": 38.897663,
			"shortName": "ciabEdge",
			"id": 7,
			"parentCachegroupName": "CDN_in_a_Box_Mid",
			"localizationMethods": null,
			"secondaryParentCachegroupId": null,
			"lastUpdated": "2019-01-23 17:46:45+00",
			"parentCachegroupId": 6,
			"fallbacks": [],
			"secondaryParentCachegroupName": null,
			"typeId": 23,
			"fallbackToClosest": null,
			"longitude": -77.036574,
			"typeName": "EDGE_LOC"
		}
	]
}

Get the Response Body - Pretty-Printed - and any and all Request and Response Headers
user@host ~ $ toget --pretty --full "cachegroups?name=CDN_in_a_Box"
GET /api/1.3/cachegroups?name=CDN_in_a_Box_Edge HTTP/1.1
Connection: keep-alive
User-Agent: python-requests/2.18.1
Accept-Encoding: gzip, deflate
Accept: */*
Content-Type: application/json; charset=UTF-8
Cookie: mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE1NDg0NTUwMjEsImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--a0b6d5bc3aced88b3adef332f019cb390ba2ff1f

HTTP/1.1 200 OK
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept, Set-Cookie, Cookie
Access-Control-Allow-Methods: POST,GET,OPTIONS,PUT,DELETE
Access-Control-Allow-Origin: *
Content-Encoding: gzip
Content-Type: application/json
Set-Cookie: mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE1NDg0MzcwMjEsImJ5IjoidHJhZmZpY2NvbnRyb2wtZ28tdG9jb29raWUifQ--53fd4d4e65502814809df6005c1003e0e134b365; Path=/; HttpOnly
Whole-Content-Sha512: kOwjatMTd1FTUfO2lPX/sfbdN4vyiQg3rkeXu6xO6oMwS13yx+BVhy7JvUANLLcz7C2ACnqr7Ws063gLXmPmSQ==
X-Server-Name: traffic_ops_golang/
Date: Fri, 25 Jan 2019 16:23:41 GMT
Content-Length: 262

{
	"response": [
		{
			"lastUpdated": "2019-01-23 17:46:45+00",
			"longitude": -77.036574,
			"secondaryParentCachegroupId": null,
			"parentCachegroupName": "CDN_in_a_Box_Mid",
			"typeId": 23,
			"name": "CDN_in_a_Box_Edge",
			"typeName": "EDGE_LOC",
			"localizationMethods": null,
			"secondaryParentCachegroupName": null,
			"fallbacks": [],
			"id": 7,
			"parentCachegroupId": 6,
			"shortName": "ciabEdge",
			"latitude": 38.897663,
			"fallbackToClosest": null
		}
	]
}

Which TC components are affected by this PR?

[x] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[x] Python client

What is the best way to verify this PR?
Install the Python client package and make sure the scripts work as stated in the accompanying documentation.
Check all that apply

[ ] This PR includes tests
[x] This PR includes documentation updates
[ ] This PR includes an update to CHANGELOG.md
[ ] This PR includes all required license headers
[ ] This PR includes a database migration (ensure that migration sequence is correct)
[ ] This PR fixes a serious security flaw. Read more: www.apache.org/security

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3162/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3165/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3254/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3289/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3290/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3399/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/3454/
Test PASSed.


[Backend] Uncomment Executor and ExecutorBase classes

Let's uncomment Executor and ExecutorBase classes.
ONE-vscode-DCO-1.0-Signed-off-by: Yongseop Kim<EMAIL_ADDRESS>

I think that ExecutorBase::inference can be filled by like onecc run or onecc inferencer.

/cc @struss and @yunjayh

PTAL @jyoungyun


Additional info under On-premises and hybrid considerations section

AATP should be renamed to Microsoft Defender for Identity.
Include info about Azure App Proxy and Microsoft Defender for Cloud Apps integration - Use Microsoft Defender for Cloud Apps for real-time monitoring of on-prem application - https://docs.microsoft.com/en-us/azure/active-directory/app-proxy/application-proxy-integrate-with-microsoft-cloud-application-security

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7590665-2688-5da1-54ff-029be05c6376
Version Independent ID: b1dfa5fa-537e-cf03-bb2f-4b9d79420169
Content: Azure Active Directory IDaaS in security operations - Azure Example Scenarios
Content Source: docs/example-scenario/aadsec/azure-ad-security.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @EdPrice-MSFT
Microsoft Alias: pnp

Hi, we are investigating your issue and will update you shortly.
Best,
James

@murthyla Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Resolved in https://github.com/MicrosoftDocs/architecture-center-pr/pull/10088


MIME TYPES are not taken into account for Google Drive service

From my observations I see that for all google services mime types that are set in picker configuration are taken into account except google drive.
Im not sure what is the reason of it but I think this is on the SDK side.
Let me know if u can repeat this issue.

I'm seeing exactly the same behavior for all Google sources only (Gmail, Google Drive, Google Photos): FSPicker 1.1.8. Is this a known issue / is there a fix on the way?

Bump


fix transfer OCI index

Description
The transfer of OCI indix manifests accidently rewrites the manifest, even if it has not been changed during a transfer step.
What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents

Related Issue # (issue)
Closes # (issue)
Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help
[ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?

[ ] 📜 README.md
[ ] 🙅 no documentation needed

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/lgtm - successfully tested replication of ImageIndex-OCI-Artefact


Minor improvements

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (70c2568) to head (37e9db7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           50        50
  Lines         1286      1286
  Branches        53        53
=========================================
  Hits          1286      1286

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Multiple Switch or Light

can i have more than 1 switch or light for code esp32?

yes, you can, find 3 gang switch project (same author)  for esp8266 and try to do the same


Typo: "http" vs "default" named endpoints in k8s example

Type of issue
Typo
Description
https://learn.microsoft.com/en-us/dotnet/aspire/service-discovery/overview#named-endpoints-in-kubernetes-using-dns-srv
In the above section, the document says a DNS SRV record being created for an endpoint named "http" and an endpoint named "dashboard". But the example actually creates endpoints named default and dashboard. The rest of the section appears to refer to the correct name - this is the only typo.
Page URL
https://learn.microsoft.com/en-us/dotnet/aspire/service-discovery/overview
Content source URL
https://github.com/dotnet/docs-aspire/blob/main/docs/service-discovery/overview.md
Document Version Independent Id
c250cb89-e0b4-c037-e4e0-edcec7c84eb8
Article author
IEvangelist

Hey @ReubenBond - could you please confirm that this is in fact an issue? I'm not familiar enough yet to know whether or not that was a typo or intentional.

Yes, this is a typo, thanks for finding it.


Make social categories link directly to the relevant social, implement the following links

I will be closing issues #9 and #12 as they will be addressed here.
Clicking on a Social link should send the user directly to said social. For example, "Twitter" under the Omen category should take a user directly to the Omen Twitter, as opposed to a separate page. This was discussed between myself and Violet, we need someone with a bit more knowledge of Ruby.
This is a quote from the previous issues. "To reiterate, clicking these while in the category should take you directly to the sites, rather than open a page where you need to make an additional click."

Implement these socials to the specified location.
Omen
/docs/Products/Omen/Twitter : https://twitter.com/Omen_eth
/docs/Products/Omen/Website : https://omen.eth.link/
Swapr
/docs/Products/Swapr/Twitter : https://twitter.com/SwaprEth
/docs/Products/Swapr/Website : https://swapr.eth.link/
Mesa
/docs/Products/Mesa/Twitter : https://twitter.com/mesa_eth
/docs/Products/Mesa/Website : https://mesa.eth.link/
Rails
/docs/Products/Rails/Twitter : https://twitter.com/Rails_eth
/docs/Products/Rails/Website : https://rails.eth.link/
"Get Connected"
/docs/GetConnected/discord/ : https://discord.gg/4QXEJQkvHH
/docs/GetConnected/etherscan/ : https://etherscan.io/token/0xa1d65E8fB6e87b60FECCBc582F7f97804B725521
/docs/GetConnected/forum/ : https://daotalk.org/c/dx-dao/15
/docs/GetConnected/medium/ : https://dxdao.medium.com/
/docs/GetConnected/telegram/ : https://t.me/dxDAO
/docs/GetConnected/twitter/ : https://twitter.com/Dxdao_
/docs/GetConnected/website/ : https://dxdao.eth.link/#/

As Keenan said the idea is to have these items below the getConnected be clickable links that take user to desired location...


feat: support for words with unicode chars

Example: naïve.

Would you mind being more clear what you mean by support? Harper should have no problem processing Unicode. The example provided matches expectations on my machine.

The actual issue is that it isn't in the dictionary, I will make a PR.


Support TriangleFan

I see that 33ea864100149266fdf7c4ef73d6b2c7ef094108 removed the TriangleFan primitive. Unfortunately, the commit is light on details. Is there a backend which does not support it?

They are removed in (most) modern APIs (DX >=10, Metal). OpenGL and Vulkan still have it though. See here for more details

Ah, that makes sense, thanks.


Smooth Scroll

Hello is smooth scrolling supported via props?

There is no plan to implement smooth scroll.
Why don't you use smooth scroll lib like https://github.com/iamdustan/smoothscroll ?

Your demo page works if you put scroll-behavior: smooth; on the html tag

Nice one @kevincolten
For anyone using styled-components or Emotion, you can add global styles using those plugins e.g. https://emotion.sh/docs/globals#___gatsby to target the html selector from specific pages.


Advanced music player[request]

If you can do then please separate options to change categories and music player to be turn on/off separately.

I don't understand. Do you talk about about a default category (previous issue)?
Or are you saying that you would prefer not to have this category but a more direct way to enable/disable these categories?

what im saying is... player controls such like skip or pause/resume needs to be separate with changing categories. Like i don't wanna accidentaly change category when i wanna skip song etc. just change this options to turn on/off separately. Specially in survival mode.

If I understand, you just want to change the keybinding? You can do that in the game menu

Im closing this. Better way to do this is on #14


Unmanage spec_helper_acceptance and update misc spec stuff so we can msync this thing

Workaround for https://github.com/voxpupuli/modulesync_config/issues/177

I think this one is ready for review now

@bastelfreak said it looks good, so blame him if it breaks :)


[QUESTION] Gstreamer plugin versus SDK C/C++ sample code

I would like to better understand what functionality the gstreamer plugin offers in comparison to either the C or C++ SDK sample code?
My understanding is the C sample code (and C++ sample code) implements a host of SDK callbacks for robust operation in case of network failure. When using the gstreamer kvsink plugin does it provide the same functionality?
I am wondering if it makes more sense when building a new media pipeline that is not already covered by the existing sample code (e.g. a pipeline that can cope with audio-only data) for production usage (robust to momentary network failures) to either:
a) Experiment and construct a pipeline with the command line gst-launch tool, then build a gstreamer application with gstreamer code. I understand that if I were to build a working pipeline with gst-launch, I could transfer it into a gstreamer C application with this interesting command which converts the one liner into a full gstreamer C code.
b) Go straight to adapting the C or C++ SDK samples to adjust for my pipeline. My understanding is that the C SDK does not have any connection to Gstreamer, but that the C++ code uses Gstreamer in some way (I can see it is imported) and indeed is used to generate the Gstreamer kvsink plugin, is that correct? I'm unclear from the official docs whether the C++ has Gstreamer as dependency or not, and in what ways Gstreamer and the C++ SDK interact. Compared to the convenience of gst-launch, I can imagine (b) might be a more time-consuming approach to debug, unless we can somehow convert the command line elements from gst-launch into working producer SDK C/C++ code.
c) Any other suggested options
I'm keen to take advantage of the robust network issue handling your team has worked hard to create (e.g. stream latency pressure callbacks, video buffers when internet disconnects etc.)
Thanks for your time!

The CPP SDK has a dependency on Producer C SDK and PIC layers. CPP provides a gstreamer integration and kvssink which bundles a lot of our SDK functionalities (latency pressure, buffer overflow pressure callbacks, etc) through pipeline elements. If you are getting started with the SDK and intend to use GStreamer for your purpose, gst-launch with kvssink would be a good start to experimenting and constructing the pipeline for your use case. We have 3 different samples available that can be played around with based on your media source. We have a file uploader sample that takes file inputs, a single source sample that can take a single rtsp url and another that can take multiple rtsp sources as inputs.
The samples in the producer C SDK use pre-canned frame files as source. To summarize, both the CPP SDK and C SDK provide the features you are looking for.

Thank you for this summary; I see there are many options available to access the SDK functionalities.
We managed to get our audio-only pipeline working first with kvsink, then also via the CPP SDK.


Bring Your Own Postgres - phase 1

This PR represents the work done in phase 1 of Bring Your Own Postgres.   This is ready for review and is passing CI post-rebase onto master.
There are still four components outstanding:

[ ] update to knife-ec
[ ] minor updates to support RDS
[ ]  before performing an upgrade, ensure that the 'external' flag value has not changed.
[ ] ensuring if we use psql in an upgrade, we are using correct userid/password [@marcparadise]

And finally:

[ ] run through new upgrade test pipeline to ensure no suprises.

ping @chef/lob /cc @andy-dufour @charlesjohnson @jeremiahsnapp
Note: Looks like the multi-api pedant support commit found its way here in the rebase cleanup.   I'll fix  that before merging.

ensuring if we use psql in an upgrade, we are using correct userid/password

https://github.com/chef/chef-server/blob/master/omnibus/files/private-chef-upgrades/001/020_multi_key_schema_migration.rb#L5
That is the only one I can find with grep.

update to knife-ec

Depending on what OSC 11 -> 12 upgrade scenarios we want to support, we may need to update various wrapper scripts as well.  Can you point me in the direction of what you found wasn't working?  All of the commands should support these options:
https://github.com/chef/knife-ec-backup/blob/master/lib/chef/knife/ec_base.rb#L55-L71
but we may need to bubble them up in whatever wrappers we have.

Overall it looks like there are a lot of good improvements and cleanups here.  If we want to aggressively merge this, we might consider "darklauncing" it by bailing out if we see external set to true for now (perhaps overridable by some environment variable).  That would allow us to merge this, continue testing and iterating on it if needed, but still have master releasable.

Another TODO:

[ ] Teach chef-server-ctl start/stop/restart/status about external postgresql

Added a few comments to the above. Huge amount of our core configuration and big delta to not have any testing imo (not that we really do for our omnibus definitions as its stands, but maybe this is a good opportunity?). Size of the changes makes me nervous but nothing obvious jumped out at me.

@stevendanna re: ctl status - since we don't configure the service, chef-server-ctl status wouldn't known about it at all (my understanding is that it checks run-sv links to determine what is present). I've added the TODO item for follow up though.

@tylercloke yeah, we spent time in the first half of the sprint getting server-spec support into this chef-server omnibus --  but that "making sure all new and modified code has tests" conflicted directly with "produce a complete shippable feature in a sprint" - particularly since there's not yet a foundation upon which to build those tests.
I definitely want to add tests to this, and it's worth doing as the next item on the board. It will also better prepare us for future externalization work - but I also don't want to maintain this separate branch for the time it takes to do that. Thoughts?

Updated for various code review comments. Also included an update to use error codes in the validator error function names, to make them fully searchable.
@stevendanna It really already is darklaunched - if you don't set 'external', only a couple of things change (database ownership, and IP-based local access)

We will also need to update the help links in preflight_postgres_validator.rb as they are currently all placeholders.  We'll do that under a separate PR once docs are wrapped up.


Get current URL via Find()?

I was curious if it's possible to get the current page URL via document.Find(...). (I am aware that document.Url also returns the URL.)
For example, in JS, we can use window.location.href to get the current page's URL. A project I'm working on would benefit if we could do something similar using the Find function.

Hello Tushar,
No, unless the URL is stored somewhere in the HTML, there is no way to get it like that. Also, note that document.Url is only filled if NewDocument(url string) or NewDocumentFromResponse(*http.Response) are used (otherwise goquery has no idea where the html comes from).
Martin


Netscape 4 support?

Hi,
I have been testing this tool and it's incredible!
I was wondering if it's possible to make it run on Netscape 4, even if it's a slightly more limited experience.
If so, I could potentially help with that if I was pointed in the right direction.
Thank you!

I'm trying to do it, I'm just unsure how to edit the html pages on the fly so I can test it as I go.
Do I need to recompile every time I change the files?

Great! I haven't really tried Browservice with Netscapes that old, so I'm not sure what works and what doesn't; you might be in for a challenge. Netscape 6 was discussed in issue #3; to image reloading work (in a flickery fashion), it needs the fix from commit 827d13a4fc73f60209e97ad41f9c3d25aaa5df4b. However, it may be that the issues with Netscape 4 are completely different, as Netscape 6 was based on Firefox, while Netscape 4 was not.
The Retrojsvice HTML templates are compiled into the binary, so you cannot edit them on the fly. However, if you only edit the HTML templates, the incremental recompilation with make should be very fast, because it only needs to recompile the HTML template module and relink the executable. On my computer, it takes less than 2 seconds.
The code for the JavaScript client in main.html is a bit weird, because it has been written with compatibility in mind. For example, things like Array.push or non-string arguments to setTimeout could not be used as old browsers do not support them and there are state flags all over the place to avoid running into the quirks of IE event system. Feel free to ask if you need me to explain something about the code.

I have managed to swap images on Netscape 4 but the CSS support is very limited.
I'll keep trying here and see where I get to.

Hmmm, this is very difficult.
I can on a separate html file load images on the fly on Netscape 4 with some trickery but for some reason I can't get it working with browservice.
I'll keep trying, but I wish I could start simpler, just load one image first.
I feel it's a bit hard to make changes to support NS4 the way the js code is structured, there's a lot going on there.

I usually use alert() with NS4.
I kinda managed to load the PNG from Browservice in NS4 and replace it. I have to use only one  tag, so the code there will end up very different.
I could potentially load the image within an image object and then replace it in the main  task, but the problem is that that is considered a second request and when I do that request I get an "outdated request" response because browservice only allows me to request that image twice.
Which is weird because I'd imagine NS would cache that image, as it did with my test application. Maybe NS4 does a check with the server to see if you can load that image before displaying the cache, but that's just a guess, it's really hard to find information about those behaviors.
Another problem I found, which I don't know if there's a solution, is that I can't change the size of the image on the fly. After it loads for the first time it stays that size forever.
I can change the size of the image on the request, which would return a different size, but the image component would remain the same size causing the image to potentially be distorted as well as not fitting with the browser window.

Do I understand correctly: You can have only one img element for the browser view, probably because NS4 does not support the CSS/JavaScript trickery required for double buffering using two or more image elements. You try to achieve somewhat atomic updates by preloading the image into another (non-visible) img element and after it has loaded, load it in the visible img element, hoping that it is cached.
The image request handling logic is in the Window::handleImageRequest_ function in viceplugins/retrojsvice/src/window.cpp. In principle, Browservice allows the same image to be requested multiple times; the only constraint is that the image index must be non-decreasing. So if you have already requested image 57 but you re-request image 56, you get "outdated request" response; this may be the reason why you are getting the error. This non-decreasing constraint is a sanity check, meant to avoid old requests using up capacity; you can remove it from this line.
But as you say, the real issue is that the image is requested again instead of being cached. The reason for this is that for simplicity, all Browservice HTTP responses include cache disabling HTTP headers (except for file downloads, where we disable those headers to circumvent IE bugs). This is controlled by the noCache argument to HTTPRequest::sendResponse implemented in viceplugins/retrojsvice/src/http.cpp; the argument defaults to true. You should try to set it to false in the sendResponse calls that send the image responses here and here by appending false to both sendResponse argument lists. I am not sure if removing these headers is sufficient to make NS4 cache the image or if you actually need to add some headers (you can do that using the optional argument extraHeaders in HTTPRequest::sendResponse). You should check that the headers are correct by looking at the response headers in the developer tools of a modern browser.
As for the image size issue: Can't you manually set the width and height of the image element to match the ones you set in the request (does NS4 support it)? Note that it might take a few frames for the image size in the responses to actually change to match the requested size.

Exactly, you can only have one img element, and you can use the Image object to load images in the background, as long as you have cache enabled.
Set the parameter to enable cache with NS4 did work, I managed to get it semi functional in this branch:
https://github.com/ericmackrodt/browservice/tree/netscape-4
The javascript apis on NS4 are completely non-standard.
The issue I have now is that, when I click on the address bar, the text is selected briefly and then the field loses focus.
Is that something you encountered in the past?
I can definitely manually set the width and height in the html file, but that size would be set forever for the img element, I'm trying to use 100% for width and height, which works as soon as it loads, but again, it doesn't update. Also I need to remove the margins on the page completely otherwise the mouse is off.

I've had issues with various browsers with focus out events. You should try logging to see which events are received from the JavaScript side; a good place to do that would be the beginning of Window::handleTokenizedEvent_ in viceplugins/retrojsvice/src/window.cpp, as every event passes through it. You should try comparing the events you get on NS4 and some other client browser that works correctly and see what is different.
If you are still debugging the JavaScript side with alert message boxes, keep in mind that the alerts might mess up the state of the browser (for example, it probably causes loss of focus). Logging to window.status, document.title or some textarea might be less invasive in this sense.
I'll try to get around to setting up a NS4 test VM and trying your branches at some point.

I logged the event like you suggested and I was getting an FOUT event every time I clicked on a text field.
It started working after I commented out the window.onblur event, now I can browse to some websites.
I still have some issues though. The arrow keys don't do anything and the letter t resets inputs instead of typing the letter for some reason.
Also, I'm still having issues with image resizing, using width and height 100% resizes the image but the contents disappear for some reason.

@ericmackrodt sorry, this issue got kind of buried... In case you are still interested in this, I tested your netscape-4 branch changes (ported to v<IP_ADDRESS>) on Netscape Navigator 4.08 on Windows NT 4.0. Some comments:

I don't seem to get Netscape to ever resize the actual image element from its initial size. In addition, the image does not fill the window completely. If Netscape does not like resizing, one possible hack would be to force a reload on each resize.
The issue with 't' key is caused by the following: On most browsers, when you press 't', you get keydown and keyup events for keycode 84 (the physical key code) and keypress event for keycode 116 ('t' in ASCII). However, Netscape 4 calls keydown and keyup with keycode 116 instead of 84, which corresponds to the physical key F5, causing a refresh. An easy workaround that simply disables F*, Win, Menu and NumLock keys (which could errorneously be triggered by letter keys) is to replace the linenonCharKeys[nonCharKeyList[i]] = true;

byif(nonCharKeyList[i] < 90) nonCharKeys[nonCharKeyList[i]] = true;

Hi @ttalvitie ,
No problem. Yeah, I'm still interested.
Image sizing on Netscape 4 is a huge issue, the image doesn't resize on the fly at all.
The refresh might be the right solution...
I'll give it a go at some point, I need to finish up some projects.


[1.x] Tokens are being cached with client id scope

Please follow the issue template below. Failure to do so will result in a delay in answering your question.

Library

[x]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Important: Please fill in your exact version number above, e.g<EMAIL_ADDRESS>Description
When completing a redirect auth flow, the tokens in the cache are being cached with the client id as the scope. Ideally this should be cached with openid and profile scopes instead. This is causing false cache mismatches, and forcing acquireTokenSilent to go to the wire to get new tokens.
Regression
Worked in 1.1.3
Configuration
Please provide your MSAL configuration options.
// initialize MSAL
    const msalConfig = {
        auth: {
            clientId: "xxxxx",
            authority: "https://login.microsoftonline.com/common",
            navigateToLoginRequestUrl: true
        },
        cache: {
            cacheLocation: "localStorage",
            storeAuthStateInCookie: false
        }
    };

    const loginRequest = {
        scopes: ["openid", "profile", "User.Read"]
    };

    const tokenRequest = {
        scopes: ["Mail.Read"]
    };

    // resource endpoints
    const graphConfig = {
        graphMeEndpoint: "https://graph.microsoft.com/v1.0/me",
        graphMailEndpoint: "https://graph.microsoft.com/v1.0/me/messages"
    };

    // instantiate MSAL
    const myMSALObj = new Msal.UserAgentApplication(msalConfig);

    // register callback for redirect usecases
    myMSALObj.handleRedirectCallback(authRedirectCallBack);

    // signin and acquire a token silently with POPUP flow. Fall back in case of failure with silent
    acquisition to popup
    function signIn() {
        myMSALObj.loginRedirect(loginRequest);
    }

    // redirect call back
    function authRedirectCallBack(error, response) {
        if (error) {
            console.log(error);
        } else {
            if (response.tokenType === "id_token") {
                showWelcomeMessage();
                acquireTokenRedirectAndCallMSGraph(graphConfig.graphMeEndpoint, loginRequest);
            } else if (response.tokenType === "access_token") {
                callMSGraph(graphConfig.graphMeEndpoint, response.accessToken, graphAPICallback);
            } else {
                console.log("token type is:" + response.tokenType);
            }
        }
    }

// This function can be removed if you do not need to support IE
   function acquireTokenRedirectAndCallMSGraph(endpoint, request) {
        //Call acquireTokenSilent (iframe) to obtain a token for Microsoft Graph
        myMSALObj.acquireTokenSilent(request).then(function (tokenResponse) {
            callMSGraph(endpoint, tokenResponse.accessToken, graphAPICallback);
        }).catch(function (error) {
            console.log("error is: "+ error);
            console.log("stack:" + error.stack);
            //Call acquireTokenRedirect in case of acquireToken Failure
            if (requiresInteraction(error.errorCode)) {
                myMSALObj.acquireTokenRedirect(request);
            }
        });
    }

if (myMSALObj.getAccount()) {// avoid duplicate code execution on page load in case of iframe and popup window.
            showWelcomeMessage();
            acquireTokenRedirectAndCallMSGraph(graphConfig.graphMeEndpoint, loginRequest);
        }

Reproduction steps

Run the sample with the above config
Hit "Sign In" and enter creds.
Review console and look for token blocked error. Check cache and you should see a token cached with client id scope.

Expected behavior
Should be caching with openid and profile, not client id. No cache misses.
Browsers
Tested in Chrome, but most likely an issue in all browsers

Sorry about the late reply,I track the debug and found that when use webform to get the accesstoken from the cache,it will fail because the key is wrong.So that can not get token in the C# webform solution.I mean when execute function in a form runat in server.

@element8763 Can you try upgrading to<EMAIL_ADDRESS>This version fixes a token caching bug which may be why you are getting a cache miss. ID tokens are currently being cached with client id in the scope field. Access tokens should be getting properly cached as of 1.3.0