Add extensions workflow + resolve dependency warnings

Coverage increased (+3.9%) to 86.515% when pulling dc481154467979f1e65595846e3623395409985d on resolve-dependency-warnings into 2e6ee2df66baa47d4ad77cb29c94454680d668b0 on dev.


Improve IDE Autocompletion for Subpath Exports

Describe the bug
When using VSCode or other IDEs, autocompletion for subpath imports like lenis/react or lenis/snap incorrectly suggests paths from the dist directory. While the main library's autocompletion works correctly, the subpath exports are not being properly recognized by IDEs.
Current Behavior

Importing from lenis/react suggests: lenis/dist/lenis-react.js
Importing from lenis/snap suggests: lenis/dist/lenis-snap.js

The issue stems from the order of exports in package.json. The wildcard pattern "./dist/*" is placed before specific subpath exports, causing IDE's module resolution to prioritize dist paths.
To Reproduce
Reorder the exports field in package.json to place the wildcard pattern after specific subpath exports:
"exports": {
    ".": {
      "types": "./dist/lenis.d.ts",
      "default": "./dist/lenis.mjs"
    },
    "./react": {
      "types": "./dist/lenis-react.d.ts",
      "default": "./dist/lenis-react.mjs"
    },
    "./snap": {
      "types": "./dist/lenis-snap.d.ts",
      "default": "./dist/lenis-snap.mjs"
    },
    "./vue": {
      "types": "./dist/lenis-vue.d.ts",
      "default": "./dist/lenis-vue.mjs"
    },
    "./dist/*": "./dist/*"
  }

Addtional Context
If you don't mind, can I take over this Issue?

Nice catch @no3232, can you do a PR?

Thanks for pointing this out. I was wondering why it did this. Didn't know the order in the package.json made a difference. Just pushed the fix to main.


Html5 UI-router compatibiltiy

Hello,
Any chance to have the permalink=true feature working without the "#" added in the URL.
Indeed due to this # we can t load a new state witu UI-ROUTER as " #" is not allowed in the url.
Any workaround ?
Thks,
matt

Hi !
I don't think hashbang is incompatible with ui-router when using html5 routing: $locationProvider.html5Mode(true);


mini.comment disrespects indentation with tabs

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.comment
Description
Currently, mini.comment replaces indentation by tabs with the same number of spaces.
Neovim version
0.6
Steps to reproduce

:set noexpandtab ts=4 sw=4 sts=0 nosmarttab
In any buffer, type <tab><tab>asdf
Toggle comment twice.

Expected behavior
The line \t\tasdf
Actual behavior
The line __asdf where _ is a space.

Thanks, reproduced in both Neovim 0.6.0 and 0.5.1. I'll look into this.

Should be fixed now.


Cadl rename to TypeSpec

Cadl has renamed to TypeSpec.  Ensure to update wording and links related in the SDK Release App
Cadl -> TypeSpec
Getting started Docs:  https://aka.ms/cadl/azuredoc -> https://azure.github.io/typespec-azure/

We need to change it by follow sequence: Cadl -> SDK emitter -> SDK automation pipeline -> Powerapps. For now, we can only edit the static word just like Note or describe. But leave the pipeline related text to CADL.
CC:  @maririos

Information from Ray:

With this PR change, sdk generation docker image would support typespec naming. Please change the image name to sdkgeneration.azurecr.io/sdk-generation:beta-1.1 if you want to keep using the old image with cadl naming in SDK release app.

@maririos Is this done?   If not, can you put exactly what needs to be done in the description.


Use @envoy//bazel:boringssl

This makes sure we use @envoy//bazel:boringssl.
Signed-off-by: Dhi Aurrahman<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dio
Once this PR has been reviewed and has the lgtm label, please assign lizan for approval by writing /assign @lizan in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dio, Shikugawa
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Shikugawa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Feature Request]: is24HourFormat function

Description
Hi! It would be nice if this lib offers a is24HourFormat function:
It could be based on https://github.com/steffenagger/react-native-device-time-format (which is not really maintained anymore)
Use Case
Formatting of times used to be done based on the user's locale. This is in fact incorrect, since both iOS and Android have a separate setting for the clock format.

Hi there! What you want is this: https://github.com/zoontek/react-native-localize
It's maintained quite well, I use it

Thanks for the response! react-native-localize was already included in our project, I just wasn't aware of the method. Sorry for wasting your time 🤦


Register HEExLexer as sigil lexer in makeup_elixir

This commit adds the HEExLexer as a custom lexer for the ~H sigil in makeup_elixir. It also adds a postprocessing to format any unknown tags as best as we can to improve the highlighting.
cc @josevalim

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


CHANGE copyright in readme file

This is my first try. I changed vue vixens to front end foxes in readme file

thanks @FlorIBG !


broke display of attachments in webapp

we now get:
List(NounPhrase, Entity) => production
------------------------------
Rule => simple-np++Decrease_ported_syntax_2_verb
Type => TextBoundMention
------------------------------
NounPhrase, Entity => production
* Attachments: org.clulab.wm.eidos.attachments.Decrease@1c905409, org.clulab.wm.eidos.attachments.Quantification@b716b2d4
------------------------------

It looks like I forgot to test something.  Thanks for finding my bug.

thanks for everything you do, man!
On Tue, May 1, 2018 at 3:26 PM, Keith Alcock<EMAIL_ADDRESS>wrote:

It looks like I forgot to test something. Thanks for finding my bug.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/issues/297#issuecomment-385809142, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniXhrqLkhxm51zVU5U3z5ugP5EZ3Fks5tuOEMgaJpZM4TuliK
.

Hopefully fixed with #298.  Yell at me if not.


[Java] Upgrade to Arrow 0.10.0

Parquet is using Arrow 0.8.0 but version 0.10.0 was recently released. There are numerous bug fixes and improvements, including building with JDK 8.
Reporter: Andy Grove / @andygrove
Assignee: Andy Grove / @andygrove
Related issues:

[Java] parquet-arrow is broken due to different JDK version (is duplicated by)

PRs and other links:

GitHub Pull Request #516

Note: This issue was originally created as PARQUET-1390. Please see the migration documentation for further details.

Uwe Korn / @xhochy:
Issue resolved by pull request 516
https://github.com/apache/parquet-mr/pull/516

Andy Grove / @andygrove:
PR: https://github.com/apache/parquet-mr/pull/516


Add workspace templates to extended tests

Resolves #3702
What is being addressed
Add workspace creation tests to extended tests.

/test-extended

/test-extended

Tests are now failing correctly - https://github.com/microsoft/AzureTRE/actions/runs/6103122391
Wil fix the bundles.

/test-extended

/test-force-approve
passed - https://github.com/microsoft/AzureTRE/actions/runs/6107126915

/test-extended

/test-destroy-env

/test-extended

/test-extended


Downloads not getting flushed sometimes

Downloads not getting stopped sometimes even if we force flush the whole download database using warpdl flush -f.
Steps to reproduce:

Start downloading a file
Proceed with a Ctrl + C interrupt on the client side of the cli (Now, download won't stop because we have just detached from the downloader this way, it will keep downloading in background using daemon)
Try warpdl flush -f, This command is intended to force flush but it won't be working because our file is currently downloading, flushing it midway can cause unexpected errors.
Now, try stopping the download using warpdl stop HASH
Try flushing again... You'll notice that it is still not getting flushed. However, it should be able to flush now as we have safely stopped the download.

@qewertyy is working on this issue.


Ability to filter non-mutable requests from output

There can be a ton of read-only requests generated from navigating around the console that people might want to filter out. This can reduce output and make it easier to identify which modifying requests are being made.

Hi Pat,
Thanks for raising. Could I confirm that this would be for the Boto3 output and/or the other SDKs?
Fair warning, this one could take a little bit.

I've only looked at the CLI output so far, but this could be helpful for all of the output formats.
How do you currently block mutable requests? Assuming a role with a ReadOnly IAM policy?

The extension is 100% passive, so only looks at the calls you are making with your role.
I've manually mapped which calls are or aren't mutable on a per-method basis, but it's not easy to use for the reverse due to the way its originally coded.

Do you have a link to the section of the code with the manual mapping?

In bg.js, anywhere that has:
if (blocking) {
    notifyBlocked();
    return {cancel: true};
}

Which translates to, "if the block mutable requests option is on, show a popup and block the request".
Looking at it now though, I also realise I have a was_blocked property on each output that was used for putting the little comment in informing you that request was blocked. We can probably do a quick condition on that before it gets exported to the actual template.

From Option to hide ec2_client.describe_ actions  (issue #41, referenced above)
Boto3 output generates a high number of ec2_client.describe_ commands.
This comes out very noisy if performing an action through a wizard. This is especially noticeable with autocomplete form fields, such as the "add tags" form when launching an EC2 instance - a new ec2_client.describe_tags command is added for each keystroke.
These are read-only commands which don't write or display their output anywhere. I'm sure these are useful to someone designing a user flow on top of AWS Console, but I imagine most users are only interested in the commands that alter their AWS resources.
Would love a settings parameter or on-page filter to hide/remove all ec2_client.describe_ actions (or read-only actions in general).
Better yet, the ability to filter/hide output based on regex or something.


Molecule Idempotence test failed for bbaassssiiee.base_postgres

$ molecule --version molecule, version 1.25.1
$ ansible --version ansible 2.7.4
--> Idempotence test in progress (can take a few minutes)...
--> Starting Ansible Run...
ERROR: Idempotence test failed because of the following tasks:
ERROR: * [vm] => bbaassssiiee.base_postgres : set listen on on ipv4 addresses
* [vm] => bbaassssiiee.base_postgres : set replication setting: wal_level
* [vm] => artifactory : create configuration file
* [vm] => artifactory : install artifactory as a service
* [vm] => artifactory : ensure storage properties configuration is present with derby driver

bbaassssiiee.base_postgres fixed.

Tested idempotence with tox, molecule 1.25.1 is a bit weird molecule converge reports no changes when run repeatedly.

Fixed.


[GetX Migration] Migrate all 'email checking' to GetUtils.isEmail

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #community-contributions.

Done. my beta branch


WinMD: remove forEach for for ... in

THe forEach usage had no real purpose here.    Replace the instances of the forEach with the
proper iteration and remove the functions.

Codecov Report

Merging #102 (9664261) into main (ad7da5a) will increase coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##            main     #102      +/-   ##
=========================================
+ Coverage   9.74%   10.10%   +0.36%
=========================================
  Files         53       53
  Lines       1160     1118      -42
=========================================
  Hits         113      113
+ Misses      1047     1005      -42

Impacted Files
Coverage Δ

Sources/WinMD/CILTables.swift
0.00% <0.00%> (ø)

Sources/WinMD/Compression.swift
0.00% <0.00%> (ø)

Sources/WinMD/TablesStream.swift
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7da5a...9664261. Read the comment docs.


[Meta] Stable Storage Tracking Issue

[x] First Implementation (#1562 )
[ ] Add comments and documentation
[x] Use constants instead of literals as versions
[ ] Support storing more parts of the state

[ ] Items from the Key Store (deleting key package should also delete secrets, see note on hierarchical deletion)
[ ] Items that live in CoreGroup

[ ] GroupEpochSecrets
[ ] own leaf index
[ ] use ratchet tree extension
[ ] MessageSecretsStore (see note below)
[ ] ResumptionPskStore

[ ] Items that live in MlsGroup

[ ] JoinConfig
[ ] ProposalStore

[x] append
[x] query proposal
[x] query proposal list
[x] is_empty

not needed, since answering that query requires fetching and parsing the list anyway. Just query the list and call is_empty on that

[ ] clear proposal queue

[ ] own leaf nodes
[ ] aad
[ ] MlsGroupState, incl. PendingCommitState
[x] InnerState

can be removed, because we just persist everything immediately

[ ] load PublicGroup from storage
[ ] load CoreGroup from storage
[ ] load MlsGroup from storage

Note on hierarchical deletion: There are cases where removing one entry implies removing other ones, and which ones are to be removed follows from the contents of the first entry. For example, when removing a KeyPackage, it would be nice if we also removed the respective secrets.
However, the storage layer mostly sees the serialized data. One way this could be done is to add methods on the deleted entity to retrieve the storage keys to the transitive deletes that have to be deleted.

First PR to get in #1565

@keks can you update this and clearly list all open issues and file follow ups where necessary?

I initially started working on #1562, but it turned out that the approach to duplicate all the types of a foreign crate made it impossible to keep the approach we use for using types to indicate validated values.
In #1565 we merged an implementation of a more pragmatic approach, which kept the serialization inside the openmls crate. This is theoretically a little more fragile, but at least it is possible, and the fragility can be caught with tests.
In #1579 @franziskuskiefer added some fixes for a method that @kkohbrok eventuallly noticed was duplicate, so we removed it in #1591.


Remove  edx_django_utils.cache.disable_forced_cache_miss_for_none toggle

Reference PR

https://github.com/openedx/edx-django-utils/pull/330

Description

This toggle is used for backward compatibility during rollout until the toggle and old broken behavior can be removed.
This toggle was added to make the old behavior as default (treating None as cache miss) and also to control the error outage if there exists any by just turning off/on the switch
Switch off means = None will be treated as cache miss
Switch on means = None will be treated as valid value

### Tasks
- [ ] Remove toggle from stage, prod and edge admin

Done in:

https://github.com/openedx/edx-django-utils/pull/363


Support for 2.0 async driver

The underlying driver is now at a 2.0 release which uses a fully async stack.
We'll have to update the repository for this release.
https://github.com/mongodb/mongo-csharp-driver/releases

I'm considering a separate branch / project for this; this way we can keep supporting the 1.x driver ("the 1.x series of the driver will continue to be developed") and the 2.x driver. Any thoughts on this are welcome. PR's too ;-)

Hi and thanks for not forgetting about us. I also hope to see async 2.0 mongodb driver version support soon.

The separate branch sounds good.

PR's are very welcome; I am currently very busy and notced that there are pretty much breaking changes...

The API is very different.. I've started a branch on my fork https://github.com/fsbdev/MongoRepository/tree/v2.x which I've updated for the new API, replacing implementations where I understand what to do in the new API (mostly the collection CRUD calls).
There are many other methods that I'm not sure yet how to implement with the new API, some related to indexes. For those I have simple added throw new NotImplementedException() in order to get things to compile in the meantime. I also removed the .NET 3.5 and 4.0 projects from the solution in this branch since the 2.0 driver dropped support for them. If anyone wants to add to my progress please feel welcome. This is just a first dive, I haven't performed any tests on the current change yet.

I've added support for EnsureIndex now (which uses the CreateIndex method underneath). https://github.com/fsbdev/MongoRepository
Still quite a bit to go but could be enough to start testing for some. Contributions welcome.

I should point out though that the 2.0 driver doesn't support LINQ as 1.0 did, they are rewriting the LINQ provider and will have support back in 2.1.

I should point out though that the 2.0 driver doesn't support LINQ as 1.0 did, they are rewriting the LINQ provider and will have support back in 2.1.

Yeah, I found that out too. Maybe it'd be wise to wait for 2.1. Not sure.

Yeah I probably will.

Is there any progress on supporting the latest mongo driver and async operations? I see there are some forks that seem to be working on this, but they don't seem to be active.

I was waiting for LINQ support to come back (2.1 last time I checked).

https://github.com/cccsdh/NLog.MongoDB20 - you could use this fork of the project...

Wouldn't it at least be an option to compile MongoRepository against the legacy driver that comes with the 2.0.* packages? That way it's possible to have MongoRepository co-exists with code that uses the new driver.

@vegar You could try to update the driver and run the unittests and let me know; I am currently very busy selling my house, moving and working so it may be a little while before I get around to it. Sorry.

I have a local branch that runs the tests ok, but I had to remove net3.5/4.0 support.

I could be mistaken but some methods (like GetTotalDataSize(), GetTotalStorageSize(), RequestStart()() and RequestDone()) aren't supported anymore under 2.0.1 and GetServer() is obsoleted, isn't it?
We could use the 1.9.X for 3.5/4.0 support.

Yes, the methods mentioned are gone, but I didn't see any problems with GetServer().
I have made a pull request (#11) with my changes, so if you have some time in beween selling houses and getting some work done... ;-)

I appreciate the PR but I do have a few issues with it. Sorry.

There's no need to remove the GetTotalDataSize() and GetTotalStorageSize(); these are still available but via GetStats().DataSize and GetStats().StorageSize.
I'm not sure support for RequestStart() and RequestDone() is still there via alternative methods or if it has been dropped; in the latter case we should (I think) also drop the RequestStart() and RequestDone() methods. However, if there's still support via alternative methods we should at least try to make an effort to implement it without changing/breaking MongoRepository's public API.
I think simply dropping support for .Net 3.5/4.0 is, also, something that shouldn't be taken lightly; if there's a way to still support 3.5/4.0 we should make an effort. As I mentioned, we may still be able to provide support by using the 1.9.x driver for those platforms.

Not that I'm complaining, I'm grateful for the effort and PR, but I'd rather take a little more time than breaking people's projects when there's (possible) alternatives.

Hi Rob,
FYI:

Robert Stam (from MongoDB):

Yes, LINQ support is planned for version 2.1.

Me:

When will Version 2.1 come out?

Andy Kor (from MongoDB):

No date, but....
We are almost feature complete for 2.1.  We'll push a release candidate first to get feedback.

Best regards,
Chris

Sweet!

Hi guys, I was using MongoRepository <IP_ADDRESS> and all was working fine. My Database Provider has migrate the databases to version 3.0, and all my querys is not working now. I have updated the driver to connect to 3.0, and MongoRepository is not working now (bad results)... I have read all about this, but I don't know if I can test or something to make these MongoRepositry works fine... Thanks!!!!

You could try 1.6.8 (maybe force driver version 1.10 using Install-Package mongocsharpdriver -Version 1.10.1). Other than that I'm afraid we're going to sit this one out; we rely too much on the underlying driver's functionality to be able to provide all features we currently do. You could also define "bad results"; I'm not sure how to interpret that. Do you get errors? Unexpected results (but results nonetheless) or...?

I guess the most important thing to clarify is if the csharp-driver/mongorepository creates a different query now then before, or if mongo 3.0 executes the query differently.
You can turn on full profiling on the mongo server to see what query is executed.
Upgrading the server to version 3.0 should not affect anything, though. In theory...

MongoDB .NET Driver Version 2.1.0-rc0 is out. Seen? Go, go, go! :-P

2.2.0-rc0 was released yesterday, which introduces sync versions of all async methods:
"The 2.0 and 2.1 versions of the .NET driver featured a new async-only API. Some users gave us feedback that they wanted a choice whether to use a sync or an async API. Version 2.2 introduces sync versions of every async method."
https://github.com/mongodb/mongo-csharp-driver/releases/tag/v2.2.0-rc0

Hi guys!! What is the real state of this project? Thanks!!

PR's are welcome; other than that the current branches show the state as it currently is.
I still aim to get this done rather sooner than later but I've been very busy and with Christmas etc. coming up I don't see much improvement for the short term. Sorry; but again: feel free to start work and submit a PR :wink:

I've started a V2 branch and started initial work on it. But I'm still getting used to the V2 C# driver and haven't implemented everything yet. I hope to get some work done during the holidays but don't hold your breath... :stuck_out_tongue:

I think I made some nice progress. The sync part of the Repository should be almost done; that would probably be a 2.0 release and for 2.1 we could focus on Async support and maybe optimizing / cleaning up the current code a bit.

Thank you very much!!! ;) very good job I will try to help you with some
tasks!!
El El jue, 17 dic 2015 a las 18:13, Rob Janssen<EMAIL_ADDRESS>escribió:

I think I made some nice progress
https://github.com/RobThree/MongoRepository/commit/c901f60600aae45db34c9aab74d7f09e9ae06103.
The sync part of the Repository should be almost done; that would probably
be a 2.0 release and for 2.1 we could focus on Async support and maybe
optimizing / cleaning up the current code a bit.
—
Reply to this email directly or view it on GitHub
https://github.com/RobThree/MongoRepository/issues/4#issuecomment-165517908
.

I think I have implemented the 2.0 version for the most part (the sync part that is). But I haven't tested anything yet and the (poor) current unittests (although all green) really deserve to be dropped entirely and rewritten to a decent test-suite.
I kept 2.0 (let's call it 'alpha' for the time being) mostly backward compatible. Most notable changes are:
MongoRepository

Dropped: RequestStart() and RequestDone() methods
Collection property was of type MongoCollection<T>, now IMongoCollection<T>

MongoRepositoryManager

Dropped: EnsureIndexes(IMongoIndexKeys keys, IMongoIndexOptions options) overload
GetIndexes() method was of type GetIndexesResult, now List<BsonDocument>

Particularly the GetIndexes() method I would like to have another look at to maybe wrap it in a GetIndexesResult class from the MongoRepository namespace, as I've done with CollectionStatsResult and ValidateCollectionResult classes (which, by the way, are now a copy from the mongo-csharp-driver and will probably need to be re-implemented/re-written for licensing issues..?).
So there's still work left to be done; in order of importance:

Unittests, testing, testing, testing!
Try to 'fix' the GetIndexes() method on the MongoRepositoryManager to again return a GetIndexesResult for (better) backward compatibility
Go over code to look for improvements (particularly in the performance department)
Async support (2.1)

I have rewritten the V2 branch pretty much from the wrist without deep knowledge of the new driver and am quite sure there's lots of room for improvement. Also, I havent tested many things (yet), particularly in the MongoRepositoryManager department.
Anyone and everyone who wants to give the V2 branch a whirl to see how it performs, what works, what is broken etc. is very welcome! Simply clone, compile and reference the V2 in your (toy)project.
We are still very much in alpha, DO NOT use in production or for anything serious other than for testing purposes!

Aside from PR #8 I'm curious if there's any feedback on the progress so far. I'd like to begin finalizing and work towards a 2.0 release.

hello,
Is there any progress about IMongoCollection version ? We will go to production but we are waiting for your new API :)

I think I was pretty clear here and here, as is the help wanted tag. So maybe you shouldn't wait but help out :wink:

@RobThree does MongoRepository have LINQ support?

@RobThree does MongoRepository have LINQ support?

It does. Why would you think it didn't? Did you even try it out?

Yes I did and got an exception. Thanks
Nathan Yeung
On Fri, Aug 12, 2016 at 4:45 PM -0700, "Rob Janssen"<EMAIL_ADDRESS>wrote:
@RobThree does MongoRepository have LINQ support?
It does. Why would you think it didn't? Did you even try it out?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

"An exception"
Without code and the actual exception I won't be able to help. Please open a new issue with the required information/code to reproduce and the actual exception message. You're not supposed to "hijack" some random other issue for help on your problem. This issue is about async support for the 2.0 driver.

Thanks for the reply sorry for hijacking an issue. Take care
Nathan Yeung
On Fri, Aug 12, 2016 at 6:12 PM -0700, "Rob Janssen"<EMAIL_ADDRESS>wrote:
"An exception"
Without code and the actual exception I won't be able to help. Please open a new issue with the required information/code to reproduce and the actual exception message. You're not supposed to "hijack" some random other issue for help on your problem. This issue is about async support for the 2.0 driver.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

hi rob. are you just waiting on someone to validate this? do you have a nuget package around for the v2 branch? if not can you put up a prerelease build somewhere so we can test it easily?


the logo in the readme is very BIG

plzfix

ok and

i can't read the readme because the logo takes up the whole page lmao


Handle double click as double tap

We are used to double tap to zoom in/out e.g. web pages, but scrcpy does not seems to handle double click to achieve this.

Thank you for your report!
I broke it when I added the possibility to double-click on black-borders to resize the window.
Fixed on master.


Bug: Bloodlust magical Item breaks character sheet

Steps to reproduce: Create test Player Actor, Add Bloodlust weapon from the Magic Items Compendium, Try to equip, error will appear in console, close character sheet.  Can no longer open sheet.
If you delete item prior to closing the sheet, sheet works properly.
Suspect its due to active effects referencing system.bonuses.attackBonus and system.bonuses.damageBonus rather than meleeAttackBonus and meleeDamageBonus as they do not exist when looking at Player Attributes
However given the fact that there are abilities that add damage to all sources it may be better to add the generic attack and damage bonus attributes.

It looks like it's because that item has a property that isn't mapping over correctly.


The Reply button in the comments is not positioned correctly

The Reply button needs to be all the way to the right, but instead is 32px away from it because of the grid gap.

Fixed in commit cdfa9d565e04fb7bdca9f27ccea3d5b13e5dfd85


Modified LB test cases for the refactoring done for standalone LB

@alena1108 can you please review the changes ?

LGTM


Fix TS build issue

TypeScript tests should not import ChangeOptions, since that property has been removed.

What: Fix TypeScript tests

Why: There was a build issue in https://github.com/paypal/downshift/pull/165

How: Remove references to removed ChangeOptions

Checklist:

[ ] Documentation
[x] Tests
[x] Ready to be merged
[ ] Added myself to contributors table

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

@kentcdodds Thanks! I'm honored.


Body front/back laser cut panels are at different scale

RE: back_plate.DXF and front_plate.DXF submitted https://github.com/nasa-jpl/open-source-rover/commit/831708420ae1a5db06d0873cb76e857595a329ee
These two files appear to have been generated at different scales. When imported into Lightburn laser cutter software, back_plate.DXF is interpreted to be the correct size. However, front_plate.DXF comes in super tiny, approximately 2% of correct size.
Workaround in Lightburn, may be available in other laser cutter software:

Import back_plate.DXF
ungroup the paths.
Delete volt meter rectangle and power switch cutouts.
Use resulting cutout-free panel as front plate.

Could this be a units problem?  Metric/Imperial, cm/mm?
JHP

Not sure but at the moment I think it is something in Lightburn. When I import these files into Inkscape both files are at the same (correct) scale. Closing now, I'll reopen if I can pin it down to something we can change in rover DXF.


Add alerts for VMs unhealthy states

What this PR does / why we need it:
Sometimes VMs are stuck in unhealthy starting, migrating, or error status. This PR adds new metrics and alerts to provide more visibility over these situations.
For these metrics we considered some options:

We discarded using a binary value (0 or 1) to identify if a VM is or is not in a given status because we would lose a considerable amount of information such as for how long the VM has a given status, when did the transitions to those status happened, etc. Having the transition timestamps in the labels was not considered. Each different set of labels represents a new time series. If we had a new time series for each transition timestamp, that would dramatically increase the amount of data stored.

We considered using the number of seconds a VM is in a given status as the value. Despite allowing us to obtain all observability information we want, this approach would have 2 downsides. First, we would need to perform a calculation in the controller every time we push a metric, to know for how long the VM was in the given status (time.Now() - vm.Status.LastTransitionTime) and, secondly, since the value was different every time Prometheus would never be able to optimize the storage and querying.

The last option, and approach selected, was to use the VM last transition time as the metric value. This allow the user to have visibility on when the VM transitioned status, it is also possible to calculate how long the VM was in the given state, by subtracting the value from the timestamp of the metric. And since the value only changes when a status transition occurs, the value of the metric would be mostly the same.

Added metrics:
kubevirt_vm_error_status_last_transition_timestamp_seconds
kubevirt_vm_migrating_status_last_transition_timestamp_seconds
kubevirt_vm_non_running_status_last_transition_timestamp_seconds
kubevirt_vm_running_status_last_transition_timestamp_seconds
kubevirt_vm_starting_status_last_transition_timestamp_seconds

Example metric for VM in error state for 10 minutes:
kubevirt_vm_error_status_last_transition_timestamp_seconds{name='vm-example-1', namespace='ns-example-1'}<PHONE_NUMBER>

Added alerts:
KubeVirtVMStuckInErrorState
KubeVirtVMStuckInMigratingState
KubeVirtVMStuckInStartingState

Example alert for VM in error state for 6 minutes and 30 seconds:
KubeVirtVMStuckInErrorState:
  annotations:
    description: "VirtualMachine error-vm is in error state for 6m 30s"
    summary: "A Virtual Machine has been in an unwanted error state for more than 5 minutes"
    runbook_url: "https://kubevirt.io/monitoring/runbooks/KubeVirtVMStuckInErrorState"
  labels:
    severity: "warning"
    name: "vm-example-1"
    namespace: "ns-example-1"

Release note:

Add alerts for VMs unhealthy states

/retest

/retest

/retest

/retest

Hey these Counters doesn't sound like reliable source,
What about counter reset?
Counters are allowed to be reset to 0.

A general question:
To track times, we generally use timestamps in the VMI's status. For example, MigrationState struct contains the timestamp of the beginning and end of the last migration.
Creating a metric that is composed out of seconds that passed from a certain timestamp feels really wrong. We're basically populating data that is completely redundant and unneeded. Once you have a beginning migration timestamp, you easily know how second have passed in every momemt.
How do other projects create alerts that are based on time? This sounds like a common problem, I'd be happy to hear about alternative solutions.

In essence, his suggestion seems valid in the sense that seconds aren't being used here, but a timestamp. This makes much more sense since I guess (although not sure?) that behind the scenes Prometheus can optimize and deduplicate the data (e.g. keeping only one timestamp since all of the time stamps repeat themselves).
But before accepting any suggestions I would, as written above, try to explore how other projects are dealing with this problem. After all this sounds like a very common problem and we don't want to re-invent the wheel. My guess is that you'll find that other projects are doing something similar to what @Barakmor1 suggested, but we still need to validate that.
BTW, there might be a few common solutions with pros and cons to each one. Since we're tackling a broader question here (how to create metrics that track time) the best would be to present several alternatives and compare between them, determining what's best for our use-cases.

@iholder-redhat
I tested a new approach using the NewMetricWithTimestamp function which wraps "the provided Metric in a way that it has an explicit timestamp set to the provided Time"?
Used as shown for example in github.com/prometheus/client_golang/examples
wdyt?

/retest

/retest

@machadovilaca can you please add the metrics names and perhaps also copy their description to the commit message?

@machadovilaca can you please add the metrics names and perhaps also copy their description to the commit message?

added

After discussing this solution with @sradco, we don't think using NewMetricWithTimestamp is the best approach.
For each VM state, we would only have one metric, timestamped to when that state began. First of all, we would have a much harder time having visibility on the evolution of a state and understanding when a VM would no longer be in that state already. Secondly, we probably would have to deal with the Prometheus metrics rotation since we would only always have an "older" metric Prometheus would clean it, and we would stop having visibility on that state.
Also, using the timestamp as a label is not a good solution. Since Prometheus treats all labels as opaque strings, this would be the approach with the most difficult way of performing time calculations in Prometheus.
We feel the best solution is using an approach with time indication as the metric value as first proposed in this PR. The value should be a counter for the number of seconds from when the VM moved to that state. It's a duration metric. Even if we hit a reset, Prometheus would know how to handle it.

Hey @machadovilaca!

After discussing this solution with @sradco, we don't think using NewMetricWithTimestamp is the best approach.

This shouldn't be surprising, the documentation says: This is only useful in rare cases....

For each VM state, we would only have one metric, timestamped to when that state began. First of all, we would have a much harder time having visibility on the evolution of a state and understanding when a VM would no longer be in that state already. Secondly, we probably would have to deal with the Prometheus metrics rotation since we would only always have an "older" metric Prometheus would clean it, and we would stop having visibility on that state.

I agree

Also, using the timestamp as a label is not a good solution. Since Prometheus treats all labels as opaque strings, this would be the approach with the most difficult way of performing time calculations in Prometheus.

IMHO, this is the root of the problem.
Prometheus, as I understand it, is not built to perform time calculations on queries. Instead, it's built to periodically take samples to build time-series which then can be inspected by alerts to notify about interesting events. Configurations related to time are usually embedded within an alert (i.e. "if this happens for X time - fire an alert"). IOW, the alerts are declarative, letting Prometheus do all of the time calculations internally. I think that our queries should follow this design.

We feel the best solution is using an approach with time indication as the metric value as first proposed in this PR. The value should be a counter for the number of seconds from when the VM moved to that state. It's a duration metric. Even if we hit a reset, Prometheus would know how to handle it.

This feels very wrong to me. It's wasteful and goes against Prometheus design / mainstream usage.
If this is indeed a best-practice - are other projects use Prometheus that way?

@iholder-redhat
IMO I think a good example might be the prometheus/client_golang approach on go_memstats_last_gc_time_seconds. Prometheus sets the UNIX timestamp of a given event as the value of the metric. In this PR, I think we are following that concept of timestamping an event, by using a VM's last state transition timestamp as the metric value.

@machadovilaca @iholder-redhat  I dont think the value should be a timestamp. Its should be a counter that counts the number of seconds in a state, A duration metric. It should change to zero once it moves to a different state.

@sradco Looks good to me, wdyt @iholder-redhat?

After discussing this solution with @sradco, we don't think using NewMetricWithTimestamp is the best approach.
For each VM state, we would only have one metric, timestamped to when that state began. First of all, we would have a much harder time having visibility on the evolution of a state and understanding when a VM would no longer be in that state already. Secondly, we probably would have to deal with the Prometheus metrics rotation since we would only always have an "older" metric Prometheus would clean it, and we would stop having visibility on that state.

Regarding rotations, I think it isn't a problem if Prometheus is continuously scaping. That way we always get new data, although it's the same one. It also might help Prometheus to optimize its data.
Regarding the visibility argument, sure, it will make things clearer. I guess a trade-off between visibility and the use of resources such as memory is reasonable, and the fact that Prometheus themselves use this pattern makes it even more reasonable in my eyes.

Also, using the timestamp as a label is not a good solution. Since Prometheus treats all labels as opaque strings, this would be the approach with the most difficult way of performing time calculations in Prometheus.
We feel the best solution is using an approach with time indication as the metric value as first proposed in this PR. The value should be a counter for the number of seconds from when the VM moved to that state. It's a duration metric. Even if we hit a reset, Prometheus would know how to handle it.

To be honest, what I thought about initially is something similar to (this is pseudo-code obviously):
Expr: "VM in kubevirt_vm_$STATUS_status"
For: "5m"

That way all time calculations are delegated to Prometheus itself. If you think your current solution is better, than I don't think I should hold this PR anymore. Thanks a lot for your patience and this fruitful discussion.
/lgtm
@machadovilaca would you mind updating the PR description to include a summary of our discussion? e.g. how the metrics / alerts look like, why, etc.

To be honest i don't understand why should we deviate from the way we usually generate alerts.
Take LowVirtOperatorCount  for instance:
						Alert: "LowVirtOperatorCount",
						Expr:  intstr.FromString("(kubevirt_allocatable_nodes_count > 1) and (kubevirt_virt_operator_up_total < 2)"),
						For:   "60m",
						Annotations: map[string]string{
							"summary":     "More than one virt-operator should be running if more than one worker nodes exist.",
							"runbook_url": runbookUrlBasePath + "LowVirtOperatorCount",
						},
						Labels: map[string]string{
							severityAlertLabelKey: "warning",
						},
					},

We simply check if a condition is true for at least 60 minutes.
Why not using the same approach with vm state what is different ?
What do we gain here?
why not creating something like:
						Alert: "VmStuckInMigratingState",
						Expr:  intstr.FromString("( at_least_one_vm_in_migrating_state == 1 )"),
						For:   "60m",
						Annotations: map[string]string{
							"summary":     "vm is stuck in migrating state.",
							"runbook_url": runbookUrlBasePath + "VmStuckInMigratingState",
						},
						Labels: map[string]string{
							severityAlertLabelKey: "warning",
						},
					},

@iholder-redhat IMO I think a good example might be the prometheus/client_golang approach on go_memstats_last_gc_time_seconds. Prometheus sets the UNIX timestamp of a given event as the value of the metric. In this PR, I think we are following that concept of timestamping an event, by using a VM's last state transition timestamp as the metric value.

@machadovilaca Hi, I think the metric you've suggested as a comparison is a bit different from the situation we have. I suggest to do same like you did with migration phases, where you just raised a flag of a specific migration phase, shutting down others. And in the alerts you can define the threshold, that specific phase took too much, making a VM unhealthy. @machadovilaca
@sradco WDYT?

@iholder-redhat @enp0s3 I had a meeting with Joao.
For summery, We want the metrics to count the duration that the VM is in the state and to make it 0 once the VM moves to a new state.
This way we can alert per VM if he is in an unhealthy state for more that 300 second and provide the name and time that the VM is in that state.
In addition we will add in a separate PR an alert if there are more than X VMs stuck in a specific state. We will tell the user the number of VMs that are stuck in that state. It will indicate that there might be a more general issue and not something that is VM specific.

/retest

@iholder-redhat @enp0s3 I had a meeting with Joao. For summery, We want the metrics to count the duration that the VM is in the state and report the value in seconds and to make it 0 once the VM moves to a new state. This way we can alert per VM if he is in an unhealthy state for more that 300 second and provide the name and time that the VM is in that state. In addition we will add in a separate PR an alert if there are more than X VMs stuck in a specific state. We will tell the user the number of VMs that are stuck in that state. It will indicate that there might be a broader issue and not something that is VM specific.

I like @enp0s3's idea. IMHO It basically addresses all of our needs:

We don't perform calculations on time. Instead we delegate this task declaratively to Prometheus.
We don't waste resources on saving time-related data and let Prometheus optimize our metrics since they repeat themselves (as opposed to time that always changes).

WDYT?

I talked with @enp0s3 yesterday. We would like to have the information for the time the VM is in a state from the time it moved to it. Prometheus deleted old data and we will loss this information if we only report 0 or 1. The metric can be used later for maintenance and resources cleanup that can help the users. I would like to keep this data as part of these metrics.

We would like to have the information for the time the VM is in a state from the time it moved to it.

So what's wrong with a timestamp?

Prometheus deleted old data and we will loss this information if we only report 0 or 1.

I don't understand this. If Prometheus will some target and get the same bitmap, why would it be deleted? I'm not talking about one metric, but a series of mercis that will compose a time-series, but most of the metrics would have the same data that would be able to be optimized by Prometheus.

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/lgtm

/approve

/hold

@machadovilaca Can you please check why the sig-monitoring is failing? I also see in the PR history that sig-monitoring wasn't stable, can you please check that also?

/test pull-kubevirt-e2e-k8s-1.22-sig-monitoring

one thing that is failing its the runbooks, we need them to be merged https://github.com/kubevirt/monitoring/pull/100

/test pull-kubevirt-e2e-k8s-1.22-sig-monitoring

non-root lanes were bumped
/test pull-kubevirt-e2e-k8s-1.24-operator-nonroot
/test pull-kubevirt-e2e-k8s-1.24-sig-compute-nonroot
/test pull-kubevirt-e2e-k8s-1.24-sig-network-nonroot
/test pull-kubevirt-e2e-k8s-1.24-sig-storage-nonroot

/retest

/cherry-pick release-0.58

In the context of https://github.com/kubevirt/kubevirt/pull/8855#issuecomment-1339052896 I would suggest that this PR content gets revisited and this kind of metric being removed or changed. Storing timestamps or monotonous second increases in prom is out of scope for prom monitoring.

/cherry-pick release-0.53


Disable Animations?

I'm rendering some large graphs, it would be nice if they could just show statically instead of animating in....

Did this ever happen? I'm rendering a long scrollable page of line charts and the animation is hurting performance and causing a weird visual effect


[Input]: Not extract the TypeScript type of nested schema

Hi and thank you for your time on it
With the simple code below or Playground
Why do types in name still contain v.ObjectInput?
import * as v from "valibot"; // 0.74 kB

const loginSchema = v.object({
  email: v.string([
    v.minLength(1, "Please enter your email."),
    v.email("The email address is badly formatted."),
  ]),
  password: v.string([
    v.minLength(1, "Please enter your password."),
    v.minLength(8, "You password must have 8 characters or more."),
  ]),
  name: v.object({
    first: v.string([v.minLength(1, "Please enter your first name.")]),
    last: v.string([v.minLength(1, "Please enter your last name.")]),
  }),
});

type Login = v.Input<typeof loginSchema>;
//   ^?

I think, all examples on documentation should use a wildcard import to easy for the reader and less confusing

If I understand it correctly Input/Output do not infer nested schemas (https://github.com/fabian-hiller/valibot/blob/e00461daafbb1e636c4b1846f80fe41cd3881753/library/src/types.ts#L55C12-L55C12).

I suspect that this is due to TypeScript and I have only indirect influence on it. But the type itself is correct. TypeScript is just displaying it weirdly. I will investigate it anyway. This issue it related to #10.

I think, all examples on documentation should use a wildcard import to easy for the reader and less confusing

Why do you think wildcard imports are easier to understand? Feel free to explain in more detail. Currently I still prefer single imports.

If I understand it correctly Input/Output do not infer nested schemas

This is not correct, at least if I have not made a mistake. The types property always contains the final input and output type of a schema. You can assign a complex type to a variable and then check if nested properties are suggested.

I believe in these cases it's good to unwrap the type using this little handy thing:
export type Pretty<$Type> = {
	[$Key in keyof $Type]: $Type[$Key];
} & {};

Should be fixed in v0.8.0.


Review: Slate OPE Estimators

refactor
Refactored based on PR https://github.com/st-tech/zr-obp/pull/88#issuecomment-831071407 with following major changes.

renamed from SlateRecursiveIPS -> SlateRewardInteractionIPS
https://github.com/aiueola/zr-obp/blob/e81698cd49cf8c8f4662ada6b2a8f633e7644f8d/obp/ope/estimators_slate.py#L417
aggregate check input function into _check_slate_ope_inputs()
https://github.com/aiueola/zr-obp/blob/e81698cd49cf8c8f4662ada6b2a8f633e7644f8d/obp/utils.py#L342

the three check functions for sips, rips, and iips share many lines (such as checks for position, reward, and some others). I think it is better to create an additional function to put these repetitive lines together.

add usage description
https://github.com/aiueola/zr-obp/blob/e81698cd49cf8c8f4662ada6b2a8f633e7644f8d/obp/ope/meta_slate.py#L38
update example notebooks
https://github.com/aiueola/zr-obp/blob/slate_estimators/examples/quickstart/synthetic_slate.ipynb
changed description of alpha in confidence interval "P-value" to "Significant level of confidence intervals"
https://github.com/aiueola/zr-obp/blob/e81698cd49cf8c8f4662ada6b2a8f633e7644f8d/obp/ope/estimators_slate.py#L239

others

minor fix on typos and docstrings
add os.environ["PY_IGNORE_IMPORTMISMATCH"] = "1" to resolve ImportMismatchError in pytest confest.py on WSL virtual environment (dependency: py>=1.7.0, reference)
https://github.com/aiueola/zr-obp/blob/e81698cd49cf8c8f4662ada6b2a8f633e7644f8d/tests/ope/conftest.py#L20

@aiueola Great, thanks!


Bug fix legacyExplorer models / methods

Setting legacyExplorer=false prevents this error;
loopback deprecated Routes "/methods" and "/models" are considered dangerous and should not be used.
Disable them by setting "legacyExplorer=false" in "server/config.json" or via "app.set()".

Good suggestion.  slc loopback now sets this by default in a scaffolded app.


Add support for including comparison of installed version with BoM

Code of Conduct

[X] I have read and agree to the project's Code of Conduct.
[X] Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
[X] Do not leave "+1" or other comments that do not add relevant information or questions.
[ ] If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description
In System Overview Report we have deployed versions, maybe we can include comparison table to compare installed version vs BoM of current VCF version. Maybe in Health report this comparison can be useful as well.
With this we can identify is it AP Tool used (then AP tool need to be used for upgrade) or more importantly to validate that customer didn't used manual upgrade for some components, which is not so rare case. If they customer upgraded manually to version supported by AP tool that will be easy to solve before upgrade.  But if they used versions which are not supported by AP tool then it will not be easy to solve without GSS.
Use Case(s)
Identifying versions of components which are not part of VCF BoM and if AP tools is not used then upgrade will not be possible for that component without GSS involvement. Not so rare customers are using direct upgrade of components like ESXi, vCenter or NSX without AP tool and with this validation we will be able to identify before upgrade.
Potential Configuration
Adding comparison table of currently deployed versions with VCF BoM in System Overview Report and or Health report. Color coding will be good if version is part of BoM in green and red if its not.
If AP tool is used maybe we can add note that AP tool needs to be used for future VCF upgrades. This is documented in AP tool documentation but usually ignored by customers.
References
No response

Yes, that's how last time I notice at report:
"state": "YELLOW",
"timestamp": "Mon Nov 21 14:30:23 2022",
"message": "Failed. Version mismatch found for ESXI:esxi-01 BOM version 7.0.3-19482537, Component Running installed version 7.0.3-20036589 and VCF Inventory version 7.0.3-20036589 are not as expected.",
"status": "failed",
"alert": "YELLOW"

If AP tool is used maybe we can add note that AP tool needs to be used for future VCF upgrades. This is documented in AP tool documentation but usually ignored by customers.

I think the drift for a BOM release is easily doable with some regex; however, inclusion of sync Patch Tool ("APT") context might be more substantial.
One issue with bringing in APT may that we'd need to likely keep a .json file updated for each release and what APT supports, which could increase scope for the module and release cadence influenced by APT.
Let's discuss in the New Year.
Ryan

There is coverage, sans APT, in https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-reporting/pull/123.


ApplePaySession is not always available in Window

Summary
Since it's declared globally we can not expect ApplePaySession to always be available in the Window interface.

Thanks @rasmusbe for the contribution. Your change does make sense 👍  I am curious to know though - did you face any issues with the way that it is typed right now?

Yes, I found it when I activated the lint rule @typescript-eslint/no-unnecessary-condition and it warned about us checking if ApplePaySession exists in our code.

We're using 6.0.3 right now

@rasmusbe can you add the changeset for your change? Then I can approve and merge it.
Run yarn changeset in the root, flag as 'patch', and add a description of why this change. thanks


Generate patient self registration link for beta tester #3

We need to generate a registration link for our 3rd participant in the patient self registration beta test. See thread for details.

Done!


Release 0.3.19

@JuliaRegistrator register(branch=release)

Registration pull request created: JuliaRegistries/General/10380
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.3.19 -m "<description of version>" 25d238b386748dee72d2ec137b95a3c53bcf59ec
git push origin v0.3.19


Add support for elasticache CacheClusters

Describe the bug
No CRD to create a redis cluster?
Steps to reproduce
apiVersion: elasticache.services.k8s.aws/v1alpha1
kind: CacheCluster
metadata:
  name: my-redis-cluster
  namespace: kube-system
spec:
  cacheNodeType: cache.t4g.micro
  numCacheNodes: 1
  engine: redis
  engineVersion: "7.1"
  cacheSubnetGroupName: test
  securityGroupIDs:
    - sg-0e899eb4268ec8427

kubectl get crds | grep elasticache

cacheparametergroups.elasticache.services.k8s.aws         2024-05-28T15:58:40Z
cachesubnetgroups.elasticache.services.k8s.aws              2024-05-28T15:58:40Z
replicationgroups.elasticache.services.k8s.aws                  2024-05-28T15:58:41Z
snapshots.elasticache.services.k8s.aws                             2024-05-28T15:58:41Z
usergroups.elasticache.services.k8s.aws                           2024-05-28T15:58:42Z
users.elasticache.services.k8s.aws                                    2024-05-28T15:58:42Z

Expected outcome
A concise description of what you expected to happen.
Environment

Kubernetes version
Using EKS (yes/no), if so version?
1.30
AWS service targeted (S3, RDS, etc.)
Redis

CacheCluster is not supported, yet. To generate the CRD and controller implementation we'll have to comment out https://github.com/aws-controllers-k8s/elasticache-controller/blob/main/generator.yaml#L243 and regenerate the elasticache controller


Any updates on this for the new react router version 1.0.0?

Do you plan on updating your plugin?

I am not currently using this module in any projects so I am unable to dedicate any time to making that change. Willing to accept pull requests though.


Provide name to console server port

/lightbend/es-backend/issues/269
I didn't capture it, but on openshift there was an error message, providing a name resolved it.

Crap, this broke the kubectl proxy URL.

Going to rename it so it's not so long in the URL. https://github.com/lightbend/helm-charts/pull/148


No UI

./parity-deploy.sh --config aura (or  --release nightly), nothing on 8180

the same happens to me
I made some changes to open the UI inside the containers:
install ntpdate
sudo ntpdate -s us.pool.ntp.org
then in the authority.toml enter the ui
[ui]
force = true
disable = false
port = 8180
interface = "<IP_ADDRESS>"

and later
/parity/parity --chain /parity/spec.json --config /parity/authority.toml -d /parity/data/ signer new-token
and sometimes he takes it but now he has not caught me again

You did have an up to date repo right? So you can reproduce using:
git clone git@github.com:paritytech/parity-deploy.git ; cd parity-deploy ; ./parity-deploy.sh --config aura
Then run curl:  curl -s http://localhost:8180 | grep parity you don't get output:
 ???
I can't seem to.

Any update on this Peter?

I have no UI as well running git clone git@github.com:paritytech/parity-deploy.git; cd parity-deploy; ./parity-deploy.sh --config dev; docker-compose up and curl -s http://localhost:8180 returns nothing.
The problem is that docker-compose.yml doesn't contain a list of exposed ports. Even after exposing 8180 it suggest me to run parity signer new-token because token from output logs doesn't work.


Forward compatibility of Opensearch 1.3 with Opensearch 2.5 cluster

Is your feature request related to a problem? Please describe.
To have a smooth migration between Opensearch 1.3 to Opensearch 2.5, we must change the clusters first and then change to client.
Describe the solution you'd like
I would like to do the minimal changes to some request and responses, to allow empty type.
Describe alternatives you've considered
The alternative of taking a production system down for upgrading both the client and the clusters together is risky and hurtful for obvious reasons.
Additional context
Functions needed to be slightly changed:

org.opensearch.action.search.MultiSearchRequest#writeSearchRequestParams
org.opensearch.action.DocWriteResponse#DocWriteResponse(org.opensearch.index.shard.ShardId, java.lang.String, java.lang.String, long, long, long, org.opensearch.action.DocWriteResponse.Result)

Hey @andrross, thanks for the fast feedback.
Yes, you cannot work with 1.3 client against 2.5 clusters, which is what we want.
I found two places that I believe will support us to do that:

org.opensearch.action.search.MultiSearchRequest#writeSearchRequestParams:

Change this if to accept Strings.EMPTY_ARRAY :
        if (request.types() != null) {
            xContentBuilder.field("types", request.types());
        }

to:
        if (request.types() != null || request.types().length > 0) {
            xContentBuilder.field("types", request.types());
        }

For this I found a workaround without changing this code.

org.opensearch.action.DocWriteResponse#DocWriteResponse(org.opensearch.index.shard.ShardId, java.lang.String, java.lang.String, long, long, long, org.opensearch.action.DocWriteResponse.Result):
The 2.5 cluster doesn't return type, so this fails for any write operation when getting the response. So I suggest to change it to accept null, and use "_doc" which was the type before:
        this.type = Objects.requireNonNull(type);
to:
        this.type = Optional.ofNullable(type).orElse("_doc");

WDYT?

I recommend moving to https://github.com/opensearch-project/opensearch-java in which we are trying to deprecate this dependency altogether (https://github.com/opensearch-project/opensearch-java/issues/326). You should be able to upgrade the client that supports multiple versions of OpenSearch.

@erezgong Big +1 to @dblock's suggestion to move to opensearch-java which will give you more independence between client and server and avoid these issues. Is that an option for you?

I know it's the recommendation, but our usage of rest-high-level-client is huge, but cannot be replaced easily.
I've already checked my suggestion is enough for working with 1.3 client and 2.5 cluster.

@erezgong Stepping back, are you proposing to add support for 2.x servers to 1.x high level REST clients or vice-versa? While it works for MultiSearchRequest I think we'd have to do this much more broadly, and add some serious testing before we can include this reliably 😓

@dblock I think @erezgong is asking to make changes to the 1.3 client so that it can work with 2.x, at least in the cases he has identified where it is too strict about expecting _type to be present to work with 2.x.
@erezgong We're really only doing security patches and critical bug fixes to the 1.3 release line now. You're of course welcome to apply the patches you've identified yourself and make your own distribution build. Is that an option for you?

I think we all agree. Let's not add more features to 1.3.x, that would require bumping versions to 1.4 and we don't want to make any more 1.x's.
Should we close this?

@erezgong closing this for now. please feel free to ask to re-open if you still have some topics to cover.


BF: Make read_custom_montage() respect unit kwarg for Theta-phi montages

Reference issue
Fixes (the first bits of) #7320.
What does this implement/fix?
Makes montage.read_custom_montage() pass the unit kwarg down to _read_theta_phi_in_degrees()

@agramfort @larsoner
I need advice on how to add a test for this. I want to test for different units (and accordingly-scaled head sizes), as well as for an invalid unit which should raise. Not sure how to best approach this with the current test layout. Thank you!

I would do something like:
@pytest.mark.parametrize('unit, scale', [
    ('m', 1.),
    ('mm', 1000.),
])
def test_scale(unit, scale):
    mon = make_standard_montage(..., unit=unit, radius=1.)
    chs = mon._ch_pos
    assert_allclose(mon._ch_pos['Cz'], [0, 0, 1 * scale])
    # test degenerate
    with pytest.raises(ValueError, match='must be'):
        make_standard_montage(..., unit='foo')

or whatever the right inside code is, but at least this is how I would iterate over things

@larsoner this is what I would've done were I to create a test from scratch; however, I have the feeling this would lead to quite some annoying duplications, as we already have:
https://github.com/mne-tools/mne-python/blob/5152d60bbc1714d4920decce3e9f8416d8d86598/mne/channels/tests/test_montage.py#L222-L238
Therefore my question...

@larsoner tried to work sth out

One question that pops to mind. You add a unit to say in what unit is the head_size parameter
that the docstring says it must be in meters. If it's for internal use and I suggest not to affect the public API. It's the responsability of the use to pass the head_size in meters.
unless there is something I don't understand...

@agramfort
Maybe it's just a (confusing!) documentation bug, then.
You see, the docstring of read_custom_montage() currently only mentions 3 params: fname, head_size, and coord_frame. Like you said, for head_size it is suggested the value must be provided in m:
    head_size : float | None
        The size of the head in [m]. If none, returns the values read from the
        file with no modification. Defaults to 95mm.

First thing that caught my eye was that, although the value is supposedly to be specified in meters, the docstring says that the default is 95 milli-meters (instead of 0.095 m). Ok, that would be easy enough to fix.
But now, there's also a unit kwarg. It's currently undocumented. I (naively – or consequently?) assumed this param speficies the unit of the head_size (and, in cases of cartesian coordinates of the montage, the unit of these coordinates as well – although I'm not entirely sure about this approach, yet, so I didn't touch the related code). In any case, with polar coordinates as used by the "generic Theta-phi" montage specification, the unit kwarg cannot reasonably refer to anything but the head size. Therefore this PR. But happy to discuss more about this, of course!

I there is a misunderstanding here. The unit here that for mysterious reason was not documented and which was not detected by our CIs check doctrings refers to the unit in the file when you read certain file formats (typically not for theta/phi formats).  As I read it for example brainvision electrode position can benefit from specifying the unit. CLear?

@agramfort
Damn, this tripped me and two of my colleagues! I will try to propose a documentation improvement, probably in another PR.

Closing in favor of #7327


How to embed viemo private videos with video js?

I tried to use vimeo private video as a source for the video element. But this is not working. When I used any public vimeo video then it works well.
Below is the error message.
GET https://vimeo.com/api/oembed.json?url=https%3A%2F%2Fvimeo.com%2F217996500&url=https%3A%2F%2Fvimeo.com%2F217996500&byline=false&portrait=false&title=false 404 (Not Found)
Uncaught (in promise) Error: “https://vimeo.com/217996500” was not found.
Can someone help me to resolve this.

Same issue

Same issue


Add PartialOrd, Ord, and Hash to EasyBuf, generalize PartialEq.

This PR adds the derivable traits to EasyBuf so that types containing it can have the usual #[derive()]s.
It also generalizes PartialEq to all T: AsRef<[u8]>.

Thanks!


Lyche google search

When searching for lyche reservasjon on google the text says "linken - Samfundet.no"

Seems like this was automatically fixed by Google

In DuckDuckGo as well. I guess this was some part of Google's cache that wasn't updated or something similar.

Other searches seems to work as well, closing this out.


[BEAM-7274] Implement the Protobuf schema provider for compiled protocol buffers

Since compiled protocol buffers have efficient generated getters and builders, we reuse the ByteBuddy framework to create lazy rows that delegate to those methods.
Support for DynamicMessage is in a followon PR.
R: @alexvanboxel

If I remove the OneOf then tests will start failing, because we won't be
able to properly support the codegen for OneOf (basically we would then be
removing OneOf support in protobuf as well).
On Mon, Dec 23, 2019 at 2:39 AM Alex Van Boxel<EMAIL_ADDRESS>wrote:

@alexvanboxel requested changes on this pull request.
Maybe remove the OneOf in the Row (and let's mark it as a known issue). If
test are green + spotless I'll give a LGTM.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/10449?email_source=notifications&email_token=AFAYJVIB3HZJN2QCPGPQJP3Q2CWQ5A5CNFSM4J6IM3LKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQCJFUA#pullrequestreview-335844048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAYJVOORB4IBJV54TEVGKLQ2CWQ5ANCNFSM4J6IM3LA
.

If I remove the OneOf then tests will start failing, because we won't be able to properly support the codegen for OneOf (basically we would then be removing OneOf support in protobuf as well).
…

OK, let's keep it in then. Better to tackle it later then. Spotless and Java tests are failing though.

@alexvanboxel  support for wrapper types added, and all tests are now green.


Util to check if request is Hawk request

Resolves #37

Thanks, @kumar303. I took care of the merge conflict!


Fields unavailable in the subsequent actions

Describe the Bug with repro steps

Open LogicApp designer
Click on 'Try Preview Designer'
Add a trigger 'When HTTP request is received'
Add the payload schema as well (Schema having )
Add Action 'HTTP'
Try to access the fields

Observation - All fields are not available to be used in next/subsequent steps.
However, in generally available designer, we can access all the fields defined in 'When HTTP request is received'.
I have attached screenshot for both the scenarios.
Workflow JSON
NA

Screenshots or Videos
In Preview Designer

In Generally Available Designer

Browser
Chrome
Additional context
No response

@MisbahAfreen Thanks for reporting this issue, looks like it was regression with some other changes we had made, will take a look and try to get this fixed by our next release

@MisbahAfreen actually I'm not seeing this issue on my end, do you mind sharing your payload schema used in your request and I can try and repro it

Hi Eric,
Below is the payload I used to generate my schema:
Payload:
[
{
"name": "ABC",
"siteId": "ABC-1",
"address": null,
"postalCode": null,
"postOffice": null,
"description": "",
"relevant": null,
"createdBy": null,
"createdAt": null,
"location": null,
"status": "Active"
},
{
"name": "DEF",
"siteId": "DEF-1",
"address": null,
"postalCode": null,
"postOffice": null,
"description": "",
"relevant": null,
"createdBy": null,
"createdAt": null,
"location": null,
"status": "Active"
},
{
"name": "XYZ",
"siteId": "XYZ-1",
"address": null,
"postalCode": null,
"postOffice": null,
"description": "",
"relevant": null,
"createdBy": null,
"createdAt": null,
"location": null,
"status": "Active"
}
]
Payload Schema generated:
{
"type": "array",
"items": {
"type": "object",
"properties": {
"name": {
"type": "string"
},
"siteId": {
"type": "string"
},
"address": {},
"postalCode": {},
"postOffice": {},
"description": {
"type": "string"
},
"relevant": {},
"createdBy": {},
"createdAt": {},
"location": {},
"status": {
"type": "string"
}
},
"required": [
"name",
"siteId",
"address",
"postalCode",
"postOffice",
"description",
"relevant",
"createdBy",
"createdAt",
"location",
"status"
]
}
}

@MisbahAfreen can we verify if this is still happening? I'm seeing all the expected outputs

If this is still happening, feel free to reopen and we can have a deeper dive of why its happening for you


Fix codecov.yml

See #112

Codecov Report

Merging #124 into master will not impact coverage.

@@             Coverage Diff             @@
##              master      #124   +/-   ##
===========================================
  Coverage     83.422%   83.422%
  Complexity      1068      1068
===========================================
  Files            114       114
  Lines           3384      3384
  Branches         387       387
===========================================
  Hits            2823      2823
  Misses           415       415
  Partials         146       146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eee37...00e0385. Read the comment docs.

Codecov Report

Merging #124 into master will not impact coverage.

@@             Coverage Diff             @@
##              master      #124   +/-   ##
===========================================
  Coverage     83.422%   83.422%
  Complexity      1068      1068
===========================================
  Files            114       114
  Lines           3384      3384
  Branches         387       387
===========================================
  Hits            2823      2823
  Misses           415       415
  Partials         146       146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eee37...00e0385. Read the comment docs.

Codecov Report

Merging #124 into master will not impact coverage.

@@             Coverage Diff             @@
##              master      #124   +/-   ##
===========================================
  Coverage     83.422%   83.422%
  Complexity      1068      1068
===========================================
  Files            114       114
  Lines           3384      3384
  Branches         387       387
===========================================
  Hits            2823      2823
  Misses           415       415
  Partials         146       146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eee37...00e0385. Read the comment docs.


Use logo_id rather than logo_id1 (not recognized by atos)

Closes https://github.com/chtipepere/woocommerceAtosPlugin/issues/15

Looking forward to test this!


Remove JetBrains.IntelliJIDEA.Edu 2021.3.2 to JetBrains.IntelliJIDEA.Educational 2021.3.2

Microsoft Reviewers: Open in CodeFlow

URL: https://download-cdn.jetbrains.com/idea/ideaIE-2021.3.2.exe
Status Code: 200
(Automated message - build 869)


Fix JS error with disabled attachment and easymde

Not sure if this is a regression from https://github.com/go-gitea/gitea/pull/30513, but when attachments are disabled, this.dropzone is null and the code had failed in initEasyMDEPaste trying to access dropzoneEl.dropzone.

Good catch. The first regression is #23876, the if check is also missing for long time. In 1.20 - 1.22, pasting an image also triggers JS error, while main branch makes it happen easier (during init).


Faster license filtering

Ubuntu linux build with skipped tests mvn clean install -DskipTests:
Before: Total time:  03:53 min
After: Total time:  01:49 min
Windows 10 build with skipped tests in WSL mvn clean install -DskipTests:
Before: Total time:  01:24 h
After: Total time:  03:10 min
Looks like copy-resources plugin is scanning all directories recursively before applying includes. That means iterating over 50k files in every module (~220)
Signed-off-by: Daniel Kec<EMAIL_ADDRESS>

I am having the same issue as @danielkec


Add Labels to each Issue for enhanced clarity

As I'm not the owner of the repo, looks like I don't have the flexibility to attach any label to the issues. Please proceed with attaching a label against each issue as appropriate.
Reference:

https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

I already did that! please assign I'll create some more!

I've taken care of this issue for now. Going forward, please consider this step as an integral part while creating any Issues.


Support options for correction of overlapping bases in read-pairs and counting deletions in coverage depth

It seems like there is currently no support for possible correction/avoiding double counting of coverage overlap in paired-end read-pairs (samtools depth option -s) and deciding on whether to include reads with deletions in depth computation (samtools depth option -J).
Am I correct that these features are currently not present? Would you consider adding this in the future?
Thanks,
Madelon

Thank you very much for your suggestion. In the upcoming release, I will incorporate functionality equivalent to the -S and -J parameter in samtools depth.


500 internal server error & can_edit_file? in Media

Hi,
I'm getting an error only in Media page. And i want to upload  image same error in log but in page only show loading.

I checked gemfile and drapper version is true (gem 'draper', '~> 3'). And i install imagemagick again and install clear rails but nothing changed.

I found the problem you solved earlier ve i deleted can_edit_file in _render_file_item.html.erb, sorry.


Always get 'No files to update'

I just copy your update code and always get this

my yml:
`        run: python3 VideoParse.py
  - name: 'Update resources'
    uses: test-room-7/action-update-file@v1
    with:
      # Include all JS files from the `dist` directory
      file-path: Series.m3u
      commit-msg: Update resources
      github-token: ${{ secrets.PAT }}`

action info:
Run test-room-7/action-update-file@v1   with:     file-path: Series.m3u     commit-msg: Update resources     github-token: ***     allow-dot: false     allow-removing: false   env:     pythonLocation: /opt/hostedtoolcache/Python/3.8.7/x64 No files to update

my yml:
`        run: python3 VideoParse.py
  - name: 'Update resources'
    uses: test-room-7/action-update-file@v1
    with:
      # Include all JS files from the `dist` directory
      file-path: Series.m3u
      commit-msg: Update resources
      github-token: ${{ secrets.PAT }}`

action info:
Run test-room-7/action-update-file@v1   with:     file-path: Series.m3u     commit-msg: Update resources     github-token: ***     allow-dot: false     allow-removing: false   env:     pythonLocation: /opt/hostedtoolcache/Python/3.8.7/x64 No files to update

@lswlover2579 make sure your file is updated by other scripts and/or actions.

@lswlover2579 make sure your file is updated by other scripts and/or actions.

I just need your action to achive update task
But now I use another action over it lol

I just need your action to achive update task
But now I use another action over it lol


Create a Web Worker class for Wafer Map

Pull Request
🤨 Rationale
We need a Web Worker class.

👩💻 Implementation
Similar to what have been done here https://github.com/ni/nimble/pull/1788

🧪 Testing
Tested with unit tests

✅ Checklist

[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.

@DStavilaNI and @zszilagy are still codeowners. Make sure to work with them for what needs to be reviewed


Add Codemodder

Added Codemodder to Pre-commit tools

Hi @ErdemOzgen! Checking in to see if any changes need to be made to this request?


ARROW-10058: [C++] Improve repeated levels conversion without BMI2

Use a lookup table to emulate PEXT 5 bits at a time.
Remove the slow scalar path.

See JIRA issue for benchmarks. Would be nice to have benchmarks on other machines. @emkornfield

I also notice that we call internal::GreaterThanBitmap for each 64 levels, which always goes through the dynamic dispatch indirection (meaning two function calls, I think). We could call GreaterThanBitmapImpl but that requires compiling a specialized version of level_conversion_inc.h for AVX2, otherwise we lose performance.

@pitrou I'm devoting most of my bandwidth to try to finish up the parquet read component this week, is it ok if I take a closer look next week (hopefully with enough time before an RC is cut?)

I also notice that we call internal::GreaterThanBitmap for each 64 levels, which always goes through the dynamic dispatch indirection (meaning two function calls, I think). We could call GreaterThanBitmapImpl but that requires compiling a specialized version of level_conversion_inc.h for AVX2, otherwise we lose performance.

yeah it isn't ideal, it is possible there is a better factoring in there but it seemed hard to do and isolate BMI2 special instructions, I guess if this isn't too much slower then BMI2 on intel we could potentially collapse everything, but I would not expect that to be the case.

is it ok if I take a closer look next week

No problem.

but I would not expect that to be the case.

Right. The emulation is probably much slower.

Updated benchmarks on AMD Ryzen:
                         benchmark         baseline         contender  change %                                                                                counters
0     BM_ReadListOfStructColumn/50  392.881 MiB/sec   564.029 MiB/sec    43.562     {'run_name': 'BM_ReadListOfStructColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 23}
10            BM_ReadListColumn/50  485.560 MiB/sec   675.023 MiB/sec    39.019             {'run_name': 'BM_ReadListColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 42}
7     BM_ReadStructOfListColumn/50  341.782 MiB/sec   462.097 MiB/sec    35.202     {'run_name': 'BM_ReadStructOfListColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 20}
3       BM_ReadListOfListColumn/50  447.657 MiB/sec   566.594 MiB/sec    26.569       {'run_name': 'BM_ReadListOfListColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 39}
23            BM_ReadListColumn/99    1.168 GiB/sec     1.365 GiB/sec    16.883            {'run_name': 'BM_ReadListColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 102}
4     BM_ReadListOfStructColumn/99  975.429 MiB/sec     1.095 GiB/sec    14.925     {'run_name': 'BM_ReadListOfStructColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 56}
9     BM_ReadStructOfListColumn/99  798.058 MiB/sec   896.789 MiB/sec    12.371     {'run_name': 'BM_ReadStructOfListColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 46}
22      BM_ReadListOfListColumn/99    1.050 GiB/sec     1.168 GiB/sec    11.159       {'run_name': 'BM_ReadListOfListColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 94}
1      BM_ReadListOfStructColumn/1  654.576 MiB/sec   725.676 MiB/sec    10.862      {'run_name': 'BM_ReadListOfStructColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 38}
19             BM_ReadListColumn/1  919.949 MiB/sec  1005.740 MiB/sec     9.326              {'run_name': 'BM_ReadListColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 81}
11     BM_ReadListOfStructColumn/0  835.259 MiB/sec   908.920 MiB/sec     8.819      {'run_name': 'BM_ReadListOfStructColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 49}
17     BM_ReadStructOfListColumn/1  605.129 MiB/sec   649.556 MiB/sec     7.342      {'run_name': 'BM_ReadStructOfListColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 35}
8              BM_ReadListColumn/0    1.067 GiB/sec     1.145 GiB/sec     7.334              {'run_name': 'BM_ReadListColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 92}
5      BM_ReadStructOfListColumn/0  700.157 MiB/sec   740.414 MiB/sec     5.750      {'run_name': 'BM_ReadStructOfListColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 41}
6        BM_ReadListOfListColumn/0  929.109 MiB/sec   966.896 MiB/sec     4.067        {'run_name': 'BM_ReadListOfListColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 82}
14  BM_ReadStructOfStructColumn/50    1.537 GiB/sec     1.595 GiB/sec     3.772   {'run_name': 'BM_ReadStructOfStructColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 45}
13          BM_ReadStructColumn/99    4.211 GiB/sec     4.330 GiB/sec     2.835          {'run_name': 'BM_ReadStructColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 252}
20          BM_ReadStructColumn/50    1.155 GiB/sec     1.187 GiB/sec     2.755           {'run_name': 'BM_ReadStructColumn/50', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 69}
15   BM_ReadStructOfStructColumn/1    1.802 GiB/sec     1.849 GiB/sec     2.566    {'run_name': 'BM_ReadStructOfStructColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 53}
12           BM_ReadStructColumn/1    1.798 GiB/sec     1.843 GiB/sec     2.521           {'run_name': 'BM_ReadStructColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 110}
2   BM_ReadStructOfStructColumn/99    3.464 GiB/sec     3.530 GiB/sec     1.898  {'run_name': 'BM_ReadStructOfStructColumn/99', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 100}
16   BM_ReadStructOfStructColumn/0    6.021 GiB/sec     6.065 GiB/sec     0.724   {'run_name': 'BM_ReadStructOfStructColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 179}
21           BM_ReadStructColumn/0    6.821 GiB/sec     6.812 GiB/sec    -0.137           {'run_name': 'BM_ReadStructColumn/0', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 410}
18       BM_ReadListOfListColumn/1  805.644 MiB/sec   801.480 MiB/sec    -0.517        {'run_name': 'BM_ReadListOfListColumn/1', 'run_type': 'iteration', 'repetitions': 0, 'repetition_index': 0, 'threads': 1, 'iterations': 70}

sorry some personal issues came up.  hope to have time tonight to review this and other parquet related CLs

For the record, if I profile BM_ReadStructOfListColumn/50, I get the following hot spots (in cycles spent):

~19% in DefRepLevelsToListInfo
~15% in DelimitRecords
~11% in BitRunReader::NextRun
~10% in SpacedExpand
~6% in DictionaryConverter<int>::Copy
~5% in PathWriteContext::AppendRepLevels

And ExtractBitsSoftware (the PEXT emulation) only takes ~1.1%, which seems good enough for now.

+1.  Thanks.


Bump zwave-js-server to 1.22.0

I think we need another release that adds the rest of the changes needed for v10.


Autoupdate not working

I installed webdriver_auto_update 1.2.0 in my env and tried to update the chromedriver.
But it failed with this error: urllib.error.HTTPError: HTTP Error 404: Not Found
In terminal, I see it is trying to download the chromedriver from this link :
https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/121.0.6167.184/win64/chromedriver-win64.zip.
Could you please fix this issue in package or any suggestion?

Special thanks to @antoniopegorelli for the fix. @Cassar88226 Kindly refer to the latest commit. 0fccc5d The updates have been incorporated into the main branch https://github.com/competencytestlvl/webdriver_auto_update


Connecting Firebase SDK to Xcode (tvOS) project

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Xcode version: 10.1
Firebase SDK version: _____
Firebase Component: Core (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: _____

[REQUIRED] Step 3: Describe the problem
I am trying to connect my tvOS project to my Firebase database.
I have downloaded the tvOS open source CocoPods for "FirebaseCore, FirebaseDatabase" however when setting up the SDK in the firebase console I am unable to connect between my FirebaseApp and Xcode project.
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Relevant Code:
// TODO(you): code here to reproduce the problem

AppDelegate.swift

import UIKit
import CoreData
import FirebaseCore

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {

    var window: UIWindow?

    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        // Override point for customization after application launch.
        FirebaseApp.configure()
        return true
    }

Make sure that -ObjC is included in the Other Linker Flags in Build Settings


npm vue:route routeName is broken.

Describe the issue / bug.
#
It looks like tasks/vue/route.js is malformed after generating a project. Specifically, this chunk, on line 25 of the generated file:
routes.splice(
  routes.length - 2,
  0,
  routesTemplate
    .replace(//g, routeName) // <--- this isn't a valid regex expression, so the javascript parser barfs.
    .replace(/\n$/, '')
)

How can I reproduce this problem?
#
vue init simulatedgreg/electron-vue my-project
npm run vue:route foobar
Tell me about your development environment.

Node version: 7.1.0
NPM version: 3.10.9
vue-cli version: 2.5.0
Operating System: Ubuntu Linux 16.04

@radicaled
I'm aware that the scripts are broken for the time being, as noted within the docs. I've been meaning to rewrite them, but there hasn't been much concern about them to make it a priority since most people use snippets within their text editors.
So for now, they will still be experimental, unless you want to create a PR and rewrite them. Not trying to be rude, but the main concern for the time being is supporting main process bundling.

Sorry, I didn't see anything in the documentation implying they were intentionally broken. When I see "experimental" I tend to think "working but rough around the edges" or "fails some edge cases," not, "doesn't work at all."
My bad.

No problem, probably bad wording on my part. In the end, rewriting them is still on the todos in the GitHub Project.


feat: 🎸 move hydration to be wrapped in requestIdleCallback

This will be shipped with v1.5.0
In our development of several projects with Elder.js we've found that using window.addEventListener('load', ()=>{}) to bootstrap the IntersectionObserver can result in First Input Delay (FID) of greater than 200ms on pages with many hydrated components.
To remedy this situation, Elder.js will now use RequestIdleCallback to bootstrap the IntersectionObserver. If you are unfamiliar with RequestIdleCallback it allows the browser to run a callback when the event loop is idle or when a timeout is set. Whichever comes first. Elder.js's default timeout is set to 1000ms.
This means that if the main loop is blocked for 1000ms your components may not be mounted until then with the default Elder.js config.
Since Elder.js is an SEO-first framework, we believe this is a sensible default as Web Vitals are now a ranking signal.
If you have a component above the fold that must be hydrated right away, we recommend using <Component hydrate-client={{props}} hydrate-options={{loading : 'eager'}} /> or setting <Component hydrate-client={{props}} hydrate-options={{timeout : 0}} /> to retain the prior defaults.

Codecov Report

Merging #190 (68dece3) into master (58e027a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   90.17%   90.19%   +0.01%
==========================================
  Files          43       42       -1
  Lines        1680     1683       +3
  Branches      369      395      +26
==========================================
+ Hits         1515     1518       +3
  Misses        165      165

Impacted Files
Coverage Δ

src/hooks/index.ts
97.05% <ø> (ø)

src/utils/index.ts
100.00% <ø> (ø)

src/partialHydration/hydrateComponent.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e027a...68dece3. Read the comment docs.


RfE: German Locale de_DE

I'm planning to contribute that localization next week.

Closing as stale as no activity in 3 months


Fix missing passes if running with 'importCpg'

Run language specific passes such as 'PythonTypeHintCallLinker' for importCpg just like it behaves for importCode.

Thank you, good catch!

I was wrong: the post-processing passes run after the base layer has been applied, but before data flow calculation.


Loads and shuts down when accessing  list of subscriptions

Two days ago the program worked fine, and I managed to do my daily scrape. But when I tried it again the same afternoon, the program first failed to log in. I then noticed I had been logged out of Onlyfans on this machine. Logged back in, updated all the files with fresh cookies etc. Started the program again, log in works fine but then it get stuck gathering list of models for a good 5 minutes and then quickly display this text before closing the program:

? What would you like to do?
Download content from a user
Warning: Numbering on OF site can be iffy
Example Including deactived accounts in expired
See: https://of-scraper.gitbook.io/of-scraper/faq#number-of-users-doesnt-match-account-number
Traceback (most recent call last):
File "main.py", line 15, in
File "main.py", line 10, in main File "start.py", line 129, in main
File "start.py", line 126, in main File "start.py", line 62, in main
File "commands\scraper.py", line 416, in main File "commands\scraper.py", line 398, in main
File "commands\scraper.py", line 429, in scrapper File "utils\exit.py", line 89, in inner
File "utils\exit.py", line 82, in inner
File "commands\scraper.py", line 58, in process_prompts
File "commands\scraper.py", line 274, in run
File "commands\scraper.py", line 332, in run_helper
File "commands\scraper.py", line 316, in run_helper
File "utils\userselector.py", line 37, in getselected_usernames
File "utils\userselector.py", line 54, in parsed_subscriptions_helper File "utils\userselector.py", line 112, in filterNSort
Exception: You have filtered the user list to zero
Please Select less restrictive filters and userlists
[968] Failed to execute script 'main due to unhandled exception!

Tried the program again yesterday and  today, Same issue. Downloaded latest version of the scraper and the issue remains. Anyone know what the issue may be? Flying by the seats of my pants when it comes to coding, but so far I managed to run this script and it's predecessor for a few years

If you run with --output debug you should get the number of accounts as the filters are applied
Try with 3.4.2

This was change to force change of filters rather then crash


Please add support for Firebase tools

It would be really nice if either below Firebase tools cloud be added to the CLI
Crashlytics
Performance
Analytics
or a documentation is provided that guides how to integrate these tools to TWA.

We'd probably want to support other non-Firebase tools, like AppsFlyer

Nice, but is there any specific reason for adding support of third party tool and not Google's own Firebase?

Some developers already use other tools in their apps. Making the solution work across apps allows developers to use their preferred tool

In case of AppsFlyer, we first need to send the event data to our server and then our server sends the event to AppsFlyer. This approach doesn't seems elegant.

Update: android-browser-helper] v2.2.0 enables calling code that runs asynchronously when starting the LauncherActivity and waiting for it to finish before launching the Trusted Web Activity. This was a blocker for Firebase running. There's a firebase analytics demo here.

Update: android-browser-helper] v2.2.0 enables calling code that runs asynchronously when starting the LauncherActivity and waiting for it to finish before launching the Trusted Web Activity. This was a blocker for Firebase running. There's a firebase analytics demo here.

That's awesome! Thank you so much @andreban :)

That's awesome! Thank you so much @andreban :)

@andreban just a quick feedback, it would be great if you could please also add some brief docs/readme in each demo
https://github.com/GoogleChrome/android-browser-helper/tree/master/demos so that people who're not much familiar with Android app development know what are the exact changes they need to make to their project to enable certain feature.

@andreban just a quick feedback, it would be great if you could please also add some brief docs/readme in each demo
https://github.com/GoogleChrome/android-browser-helper/tree/master/demos so that people who're not much familiar with Android app development know what are the exact changes they need to make to their project to enable certain feature.

Updates on this: We won't add support for Firebase tools directly into Bubblewrap, as the output application wouldn't be compatible with Trusted Web Activity on Chrome OS.

Update: android-browser-helper] v2.2.0 enables calling code that runs asynchronously when starting the LauncherActivity and waiting for it to finish before launching the Trusted Web Activity. This was a blocker for Firebase running. There's a firebase analytics demo here.

Did you found a bug relate to this ? Which hangs up in splash screen in the first load ?


 Dzięki 😉

Looks Great, Thanks for the huge contributions 👍


[BugFix][CherryPick] fix nested agg/join mv rewrite bug for 3.1 (#27583)

Fixes #27578
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/Binder.java
1
1
100.00%
[]