The config file is not loaded automatically

System OS
Termux (Android)
Python Version
3.10 (CPython)
Install Source
pip / PyPi
Install version / commit hash
v4.0.0-rc.2
Expected Behavior vs Actual Behavior
i have changed the output to be {title}.{output-ext} in the config file but it doesn't load that as .its expected to be

Steps to reproduce - Ensure to include actual links!
spotdl download "https://open.spotify.com/track/7qM1BWAsZMTYh4BcYLb0uQ?si=Y1RE6NIvSTeqYOx8EbQpJw"
Traceback
Downloaded "Juice WRLD - Already Dead":
https://www.youtube.com/watch?v=WMGVnpaBE-I

### Other details

_No response_

Config file gets loaded, I think it's a bug with output option


fix(flux2): add variable to customise cluster domain (#139)

add new clusterDomain variable which defaults to cluster.local
use clusterDomain for source-controller storage-adv-addr argument
use clusterDomain for events-addr argument

NOTES:
The source-controller manifest included a hard-coded advertising address with cluster.local. In some environments, the cluster domain is modified, which broke the kustomize controller from being able to resolve the source controller to acquire artifacts.
BREAKING CHANGE:
The eventsaddr variable has been removed as it is no longer necessary. The new clusterDomain variable is now used to create a fully-qualified addresses throughout the deployment manifiests.
Signed-off-by: Deavon M. McCaffery<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #139

Special notes for your reviewer:
Checklist

[X] DCO signed
[X] Chart Version bumped
[X] helm-docs are updated
[X] Helm chart is tested
[X] Update artifacthub.io/changes in Chart.yaml
[X] Run make reviewable

If we are making breaking changes I would suggest correcting the variables names, some of them are not capitalized correctly for example serviceaccount should be serviceAccount, additionalargs should be additionalArgs, watchallnamespaces should be watchAllNamespaces.

I agree. It drives me nuts. 🙃

@stefanprodan I fixed the casing of everything that I could find. I've left them each in separate commits to make them easier to review. Per the contributing guide, changes should be squashed before opening a PR, but I figured that would make this much more difficult to review.


Implements parsing ciID as int and string from JSON

Your second commit looks way better.
Please don't change the type of the field, keep it as int, everything else would be a breaking change and there is already lots of code using this that shouldn't have to change.
I hope you noticed that the tests are now failing, because they are unable to parse current requests.
You need to fix that (without changing the tests, they are correct) before we can proceed.
Also I'd like to have a new test introduced that tries unmarshalling the value from a string too, you can look at the existing (failing) tests to see how it's done.


Make player slow down in air when out of stamina

Right now players can jump and maintain the same sprinting speed despite having no stamina left.
2 other options are:

Bring back landing speed to slow down player when landed
Add 'negative stamina' that let you make use of more stamina in certain situations but will take a longer to replenish

Both not an option. Keep it as it is for now. Replenish rate will increase anyway.


On windows, the react-scripts module is not found when running yarn-start

This requires some investigation:
Using node 16, npm 8.1.2
from the ui directory:
$ yarn start
yarn run v1.22.17
$ react-scripts start
'react-scripts' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Apparently this is a common problem on windows.

I found no useful help on the windows question.  FB closes issues quickly and react-scripts is a part of the larger create react app project.

You can run the script as follows:

node node_modules/react-scripts/scripts/start.js
node_modules/.bin/react-script start

I'll document this.  I still have some bugs running on windows but I'm not going to worry about it for now.


Couldn't get initDataTransform working for Fairplay

Hi,
I'try to use FairPlay in Shaka, and right now I'm not able to get it working when it comes to initDataTransform method.
I've following piece of code (only interesting part):
player.configure('drm.initDataTransform', (initData) => {
    const processedData = String.fromCharCode.apply(null, new Uint16Array(initData.buffer)).substring(1);
    const contentId = new URL(processedData.substring(1)).hostname;
    const cert = player.drmInfo().serverCertificate;
    serverProcessSPCPath = processedData.substring(1).replace('skd://', 'https://');
    return shaka.util.FairPlayUtils.initDataTransform(initData, contentId, cert);
});

player.configure({
    drm: {
        servers: {
            'com.apple.fps.1_0': licenseServerUrl
        },
        advanced: {
            'com.apple.fps.1_0': {
                serverCertificate: new Uint8Array(cert),
            },
        },
    },

});

When I try to play something then I'm receiving error 6015. Actually I'm able to assign result of this method to variable and see, the result but in general Shaka throws error which points to this method. I've also investigated values from all variables and everything looks just fine.
Any suggestions, what might be wrong?

I've already got this part in other place in my code.
Here is the whole code, I've only erased URLs and sensitive data (I can send full, uncensored version via email/PM):
import * as shaka from 'shaka-player';

let customData = null;
let serverProcessSPCPath = null;
const initializeShaka = () => {
    shaka.polyfill.installAll();

    if (shaka.Player.isBrowserSupported()) {
        const player = new shaka.Player();
        player.getNetworkingEngine().registerRequestFilter((type, request) => {
            if (type == shaka.net.NetworkingEngine.RequestType.LICENSE) {
                request.headers['DrmChallengeCustomData'] = customData;
                request.url = serverProcessSPCPath;
            }
        });
        window.player = player;
        player.addEventListener('error', shakaOnErrorEvent);
    } else {
        alert('Browser not supported!');
    }
};

const shakaOnErrorEvent = (event) => {
    shakaOnError(event.detail);
};

const shakaOnError = (error) => {
    alert(error);

    console.error('Error code', error.code, 'object', error);
    if (window.player) {
        window.player.detach();
    }
};

const play = async () => {
    const url = 'my_url';
    const licenseServerUrl = 'license_server_url';
    customData = 'my_custom_data';

    const response = await fetch('url_to_certificate');
    if (!response.ok) {
        alert('Could not get certificate!');
        return;
    }
    const cert = await response.arrayBuffer();
    window.player.attach(document.getElementById('video'));
    window.player.configure('drm.initDataTransform', (initData) => {
        const processedData = String.fromCharCode.apply(null, new Uint16Array(initData.buffer)).substring(1);
        const contentId = new URL(processedData.substring(1)).hostname;
        const cert = player.drmInfo().serverCertificate;
        serverProcessSPCPath = processedData.substring(1).replace('skd://', 'https://');
        return shaka.util.FairPlayUtils.initDataTransform(initData, contentId, cert);
    });

    window.player.configure({
        drm: {
            servers: {
                'com.apple.fps.1_0': licenseServerUrl
            },
            advanced: {
                'com.apple.fps.1_0': {
                    serverCertificate: new Uint8Array(cert),
                },
            },
        },

    });

    try {
        await window.player.load(url);
        console.log('The video has now been loaded!');
    }
    catch (exception) {
        shakaOnError(exception)
    };
}

document.addEventListener('DOMContentLoaded', async () => {
    initializeShaka();
    await play();
});

So to clarify, you're getting SERVER_CERTIFICATE_REQUIRED even with the code to set the server certificate?

You’re right. I’ve made a mistake in my question. Right now I’m receiving 6016 (INIT_DATA_TRANSFORM_ERROR), not 6015. But it also looks like, that everything in this method is working..

Ah, okay.  That makes more sense now.  In that case, the docs for 6016 give you another hint:

INIT_DATA_TRANSFORM_ERROR | 6016 | number | An error was thrown while executing the init data transformation.error.data[0] is the original error.

So you'll want to look at error.data[0] to see what error was thrown, which should lead you to the problem in your transform function.

Yes, I know. I’ve already read the docs:) This error points to line:
const cert = player.drmInfo().serverCertificate;
But this line actually is working, and even the last line of this method is called - like I said in my question - I was able to assign result of this last line call to variable.
Therefore I’m a little bit confused, where to look for an error.

Well, since I can't see the error, I can't really give you much more advice than that.  If the error points to this line:
const cert = player.drmInfo().serverCertificate;

My best guess at why this would throw would be if drmInfo() returned null for some reason.
It's also possible that the line number might be wrong (such as might happen with minification or transformations that don't provide source maps). So you may want to ignore line numbers and add console.log statements throughout the transform function to see how far you get.

Already tried that, but tried now one more time:
window.player.configure('drm.initDataTransform', (initData) => {
    console.log('a');
    const processedData = String.fromCharCode.apply(null, new Uint16Array(initData.buffer)).substring(1);
    console.log('b');
    const contentId = new URL(processedData.substring(1)).hostname;
    console.log('c');
    const cert = player.drmInfo().serverCertificate;
    console.log('d');
    serverProcessSPCPath = processedData.substring(1).replace('skd://', 'https://');
    console.log('e');
    const retValue = shaka.util.FairPlayUtils.initDataTransform(initData, contentId, cert);
    console.log('f');
    return retValue;
});

all the letters a,b,c,d,e,f are in console and after there is, error occured.
Also are variables have data;)
I've already spent on this issue couple of hours, before asking:)

Thanks for being patient with me.
What version of Shaka Player are you using?  (shaka.Player.version)
How many times is the init data transform callback invoked?
What exactly does the error contain?  (Full object, including error.data and a backtrace.)

2.5.5
Ok I see this issue now.
First time it works perfectly. After this, method is called for the second time and in variable processedData I've characters which looks like a chineese characters..
And therefore script is not able to process this..

Excellent!  I'm glad we were able to help you track it down.
Is there anything else we do for you?

Thank you for your help.
I'll try now investiagate, why this method is called twice, and why the results are so strange.

Sounds good.  If you need to reopen this issue, just put @shaka-bot reopen in a comment.  Thanks!

@jpiechowiak how did you managed to fix this? Looks like related to #2214 to me

@victordidenko Actually right now I'm not using shaka for Fairplay.. I'm using standard approach (No additional libraries) which works like a charm.

@jpiechowiak I'm having the same issue as well.


Remove Travis CI

Since we migrated all the static checks and tests from Travis to GitHub Actions and these new GHA CIs are stable for quite some time, it's safe to remove Travis CI from Apache Druid project.
P.S:

Although check_test_suite.py, check_test_suite_test.py scripts were earlier used by only Travis, they're kept around to be used by GHA CIs for optimizations in near future.
Travis documentation for new ITs (experimental then) was removed since they're stable for quite some time and GHA related documnetation can be added if needed in future.
Build & Test on ARM64 architecture jobs aren't migrated from Travis to GHA since GitHub doesn't yet provided ARM based runners. To be added once they're available.

Awesome. Thank you @tejaswini-imply for all your work in getting us here.


Add Adobe Reader

100 character limit seems reasonable to me. I have a hard time considering this one "dumb".

Too easy, cheers!


yii\rest\Serializer should apply with() on ActiveDataProvider query when "expand" is present

Rest Serializer does not pre-configures ActiveDataProvider query with relations when "expand" parameter is passed, resulting in the performance issue with SQL queries being fired for each model and each relation.
What steps will reproduce the problem?
Execute a REST call with the "expand" parameter to include relations in the result.
What is the expected result?
1 SQL query to get models, 1 SQL query for each relation in "expand" to get related records data.
What do you get instead?
1 SQL query to get models, 50 SQL queries for each relation in "expand" to get related records data.
Additional info

Q
A

Yii version
2.0.14

PHP version
7.1

Operating system
MacOS

the query is performed in ActiveDataProvider, not the serializer, so the dataprovider should be aware of all this.

If I return ActiveDataProvider from my action, then yes, I can return it preconfigured with with() in the active query. However, params "field" and "expand" are used in the serializer, so it seems logical to extend the use of "expand" parameter to cover the scenarios above.


Specifying DATA_FOLDER in ob.cfg causes avatar and cover photo to not load correctly (OSX)

Everything works fine when I have the DATA_FOLDER commented out in the ob.cfg configuration file (using OSX). However, when I uncomment this line, add the full path of my real data folder (which is in the default location), and restart the server, the client doesn't load my avatar image nor the cover photo image. Everything else seems to work fine. Bizarre.
I am using OSX, and I have specified the data folder by
DATA_FOLDER = /Users/lunokhod/Library/Application Support/OpenBazaar

Give that the server correctly loads my OB-Mainnet.db file, I presume that the syntax is fine. Just to check, I have tried putting quotes around the path string (this doesn't work), and I have tried backslash escaping the space between Application and Support (but that doesn't work either).
Resolution of this issue is necessary if you wish to run two instances of OpenBazaar on the same machine.

I would like to add that in addition to the avatar and cover photo images not loading, the photos for store items do not load either. When clicking on the store item, the item does not load.

I had the same problem. I am using a 32-bit Ubuntu Server installation

This is still an issue and needs to be fixed. This happened two times in a row for me

Can confirm this has affected me.  Would like to see it resolved. :)
+1 👍


[Bug]<EMAIL_ADDRESS>doesn't work with jest-snapshots

Version
29.6.1
Steps to reproduce
1、use package:
"jest": "^29.6.1",
"jest-environment-jsdom": "^29.6.1",

2、test.test.tsx
const testObj = {
  a: 'a',
  b: 'b',
};

test('testObj', () => {
  expect(testObj).toMatchSnapshot();
});

3、run test

generate test.test.tsx.snap file, but generated file content is empty and no snapshot data has been generated.
using -- - u to update the snapshot also generates an empty file.

Expected behavior
Expected: The generated file content is not empty, generating snapshot data correctly
Actual behavior
generate test.test.tsx.snap file, but generated file content is empty and no snapshot data has been generated.
Additional context
No response
Environment
node:16.14.0
pnpm:8.1.0
system:windows10

I get this following your steps

@SimenB :
add jest.setup.tsx file,
// @ts-ignore
global.Buffer.from = (arg) => new Uint8Array(arg);// mock

jest.config.js add
setupFilesAfterEnv: [
    './jest.setup.tsx',
  ],

result: generate test.test.tsx.snap file, but generated file content is empty and no snapshot data has been generated.

because: Buffer is not instance of UInt8Array in jsdom
so: use mock Buffer.from
then: generate test.test.tsx.snap file, but generated file content is empty and no snapshot data has been generated
why?


converting gridworld draw

i've tried to convert gridworld-viz to underscore. i'm still getting error messages. if you could have a quick look (30 mins) and see if you can diagnose the problem, that'd be great.

GridWorld.draw in master is working fine for me, can you post the script that you're running (and the branch if its not master) and the errors you're getting? Hard to help without that.


customdata type should not be string

README.md:

I tried to put it together and in client.go there's code that should list projects. However, there probably some inconsitencies in the API definition, for instance the customdata parameter doesn't work out-of-the-box:

I'm not sure if this is an OAS3 option or if it is OAS2/Swagger2 compatible, but we might be able to fix this by removing type: string from the customdata fields in the spec. type is optional in OAS3, and when omitted the field is understood to be any type.
https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.21
For the response value, we know that it may be nullable, boolean, string, int, or a map. I think the undefined type will work for this case too.

fixed in #4 by pathcing the customdata type to object. @displague please consider closing this.
It should still be fixed in the API JSON though.

fixed in #4 by pathcing the customdata type to object. @displague please consider closing this.
It should still be fixed in the API JSON though.

To get the interface{} type, we may have to remove "type": for customdata fields.

To get the interface{} type, we may have to remove "type": for customdata fields.

I'll send along to the upstream any patches we identify.

I'll send along to the upstream any patches we identify.

To get the interface{} type, we may have to remove "type": for customdata fields.

"type": "object" seems to work as well

To get the interface{} type, we may have to remove "type": for customdata fields.

"type": "object" seems to work as well

I was worried that this would not generate a client that can support values of "1" (or the other types we saw in https://github.com/packethost/packngo/pull/225#issuecomment-744594881).  The generated type is interface{}, so it seems ok.

I was worried that this would not generate a client that can support values of "1" (or the other types we saw in https://github.com/packethost/packngo/pull/225#issuecomment-744594881).  The generated type is interface{}, so it seems ok.


A few minor things

Suggestion: Change the type of the IO_SPI_FIFO generic from natural to positive, since it cannot be 0.
I was reading the user guide and found these typos.
In the 4.4.3. C Standard Library section:
These stubs are available in sw/source/syscalls.c and were adapted for the NEORV32 processor.
The path should be sw/lib/source/syscalls.c.
See sw/example/hellp_cpp for a minimal example.
Should be: sw/example/hello_cpp

Thanks for the hints! Since these are not really critical, I'll update/fix those within the next commits.

I fixed the documentary typo within the docs rework in https://github.com/stnolting/neorv32/pull/549.
I am not sure about the natural/positive thing... I would like to keep the amount of different generic types to a minimum (just boolean, natural and std_ulogic_vector) as this makes conversion to Verilog slightly more complicated (I know that the CFS config generics are still using positive...).
The VHDL sanity checks (assert ... report ...) should inform the user if there is an invalid generic configuration. However, at least Xilinx Vivado seems not to care about those assertions... 😅
So I am not sure what to do with those generic types. What do you think?

I don't do Verilog but I thought Verilog only had an integer type not even a natural type. So, wouldn't you avoid 'natural' types, also?
I'm not all that set on the use of positive or natural here -- natural is fine.  The tools throw an error fairly quickly if IO_SPI_FIFO is set to 0.
The reason I really like your RISC-V core is that its written in VHDL (I cannot read Verilog) and how well documented it is. Now, I know why you used 'std_ulogic' --  for Verilog conversion. However, the use of the 'std_ulogic' drives me nuts -- after 25 years of VHDL coding (using std_logic/std_logic_vector), I cannot get my fingers to type that u!! 😂

I don't do Verilog but I thought Verilog only had an integer type not even a natural type. So, wouldn't you avoid 'natural' types, also?

Good point, so maybe we should move all generics to type integer :thinking:

The reason I really like your RISC-V core is that its written in VHDL (I cannot read Verilog) and how well documented it is.

Thank you very much!

Now, I know why you used 'std_ulogic' -- for Verilog conversion.

Actually, I have been using the unresolved VHDL types year before making friends with Verilog. Just my opinion, but I think it makes debugging a bit easier (like finding multi-driver situations).

@stnolting  I do not like it so much to restrict to the less sophisticated type-system of Verilog. What makes you believe that using VHDL's constrained integer types

makes conversion to Verilog slightly more complicated

?

I do not like it so much to restrict to the less sophisticated type-system of Verilog

Me neither - VHDL is just so much ~cleaner~ better! 😅

What makes you believe that using VHDL's constrained integer types [...]

It is not really about this specific situation. Using integer and bit vectors as generics seems to be closer to Verilog - as this is what I have seen so far being used as Verilog parameters.

I think it would be fine to use integer, natural, or positive for generics -- they all map to an integer in Verilog. In Verilog, you just would not have the range checking on the constrained types (but that is the way it is in Verilog). (Again, I'm not very knowledgeable in Verilog, so I may be missing something.)

Actually, I have been using the unresolved VHDL types year before making friends with Verilog. Just my opinion, but I think it makes debugging a bit easier (like finding multi-driver situations).

But, you give up so much more: modeling pull/down resistors, "don't cares" (e.g., with std_match()), spotting undriven signals, ...

I think it would be fine to use integer, natural, or positive for generics -- they all map to an integer in Verilog. In Verilog, you just would not have the range checking on the constrained types (but that is the way it is in Verilog). (Again, I'm not very knowledgeable in Verilog, so I may be missing something.)

:+1:

But, you give up so much more: modeling pull/down resistors, "don't cares" (e.g., with std_match()), spotting undriven signals, ..

That's right, but modelling pull-down/pull-up resistors should not be a thing "inside" a digital design. Don't cares are not very well supported by the tools (just my opinion) - seems like they are treated like a '0'. Undriven signals are not pretty, but they do not hurt I think ;)

I think this can be closed, right? 😉


Optimize prepare stage for frames that did not change

Disclaimer: I don't know how much impact this actually has on the performance.

Actually this has a pretty good! :)
If you actually want you can optimize it even more by splitting the function into two functions.
One that is just preparing the uniform buffers [prepare_uniform_buffers]
and one just for the instance buffer [prepare_instance_buffer]
They should be independent, but beside that it would be also more organized.
However, you don't have to ofc.

I see what you mean, but wouldn't they both have mut access to GrassCache and thus not run in parallel?

ah, but they could have other early return guards, I see!

The other return guards doesn't matter as much because these 2 functions are the only two that could run in parallel
(The only in the RenderStage::Prepare at least currently)
This means we'd need to split the buffers in separate resources or use unsafe code.
I'm against the second option and unsure about the first

It is definitely better readable though

How about this for the moment? This way, we at least distinguish the cases of config changed vs grass changed

Ah also the functions are named the wrong way around. prepare_instance_buffer is currently preparing all uniform buffers :smile:

hehehe, good catch. Fixed.

Nice, looks almost good now. If you simplify the for loop mentioned above I'll merge.
Have you looked into the issues btw?

Which loop did you mention? Do you mean like this?
Checking the issues now 👍

Yes now it's perfect


add a callback to allow filtering of incoming connections by IP address

We should be able to reject connection attempts from blacklisted IP addresses.
Ideally, we'd be able to send a CONNECTION_CLOSE with a special error code for this, to allow the client to recognize that they've been blocked (and that there's no point in trying again any time soon).

hi , would this kind of implimentation work ?

func (s *baseServer) handlePacketImpl(p *receivedPacket) bool /* should the buffer be released */ {
        // If we're creating a new session, the packet will be passed to the session.
        // The header will then be parsed again.
        hdr, _, _, err := wire.ParsePacket(p.data, s.config.ConnectionIDLength)

        //if blocked ,  sending the connection close directly
        if isBlocked(p.remoteAddr) {
                if err := s.sendConnectionClosed( p.remoteAddr, hdr); err != nil {
                        s.logger.Debugf("Error closing connection: %s", err)
                }
               return false
        }

        ....
}

Yes, something along those lines. A few thoughts:

It probably makes sense to only do this for Initial packets.
It should use the CONNECTION_REFUSED error.

The tricky thing here is getting the API right, and I'd like to hear @lucas-clemente's opinion on this:
We could add a callback to the quic.Config:
AcceptConnection func(net.Addr) bool

or maybe the other way round:
RejectConnection func(net.Addr) bool

thanks for the suggestions ;  just a doubt ,  should we even quic-parse the packet if it is from a banned ip ?

Summarizing the conclusion we arrived at back then (can't find where): Using a special error code here is dangerous, as the peer might act upon this error code, and avoid dialing us back for a prolonged period of time. The problem is that this error code is sent in an Initial packet, i.e. unencrypted and unauthenticated. Injecting a CONNECTION_CLOSE using that error code would thus be an easy way for an attacker to prevent two peers from connecting.

Turns out we already have this! It's called quic.Config.GetConfigForClient. This callback gets passed a quic.ClientHelloInfo, which has a RemoteAddr field.
I'm going to close this issue, since there's no need to introduce another config option with exactly the same functionality. I'm not even sure if there's anything left to do documentation-wise:
	// GetConfigForClient is called for incoming connections.
	// If the error is not nil, the connection attempt is refused.
	GetConfigForClient func(info *ClientHelloInfo) (*Config, error)

If anybody is interested in improving the documentation, I'd be happy to review a PR.


here is a bug on this.props.history.push and goBack function

taskAction.js?version=14988:59379 Uncaught TypeError: Cannot read property 'type' of undefined
    at Object.dispatch (taskAction.js?version=14988:59379)
    at Object.dispatch (:2:1620)
    at Detail.startTask (taskAction.js?version=14988:48370)
    at Detail.onFooterButtonPress (taskAction.js?version=14988:48401)
    at Object.touchableHandlePress (bundle.js:17619)
    at Object._performSideEffectsForTransition (bundle.js:8925)
    at Object._receiveSignal (bundle.js:8844)
    at Object.touchableHandleResponderRelease (bundle.js:8596)
    at Object.ReactErrorUtils.invokeGuardedCallback (bundle.js:10518)
    at executeDispatch (bundle.js:5741)
-----------------------
bug find in :
function routerMiddleware(history) {
	  return function () {
	    return function (next) {
	      return function (action) {
	        if (action.type !== _actions.CALL_HISTORY_METHOD) {
	          return next(action);
	        }

	        var _action$payload = action.payload,
	            method = _action$payload.method,
	            args = _action$payload.args;

	        history[method].apply(history, args);
	      };
	    };
	  };
	}
----------------
action.type is undefined,i use push import from react-router-redux is ok

Please don't open duplicate issues.


[BUG] Depleted molten salt bucket and fluid issue

Is there an existing issue for this?

[X] I have searched the existing issues

Description

How to reproduce:

place using /setblock a depleted molten salt

A few of info that i have notify before it but i think that still as same issue :

thermal expansion fluid encapsulator have same item bucket as result of molten salt and depleted molten salt (i dont have touched it)

(like how i have try on the gif)  if clicked with depleted molten salt bucket or molten salt bucket they return molten salt

Multiplayer?
Singleplayer
Operating System?
Windows
Version
other
Minecraft Version
1.19.2
Forge Version
43.3.7
Links
No response

Hey! Thank you for your report. I found the problem and will fix it in the next version of Thorium! Have a nice day


Admissions webhook rejects when helm upgrade done with renamed ScaledObject

Report
Let's say I have a ScaledObject already installed with "name: initial-scaled-object", and it's target is a deployment with name "target-deployment".
Now, if I rename the ScaledObject in my helm charts to "name: renamed-scaled-object", admissions webhook starts failing the helm upgrade with:
upgrade.go:367: [debug] warning: Upgrade "<<RELEASE_NAME>>" failed: failed to create resource: admission webhook "vscaledobject.kb.io" denied the request: the workload 'target-deployment' of type 'apps/v1.Deployment' is already managed by the ScaledObject 'initial-scaled-object'

Expected Behavior
Scaled object with "renamed-scaled-object" name gets created, then "initial-scaled-object" gets deleted by helm upgrade.
Actual Behavior
Creation of "renamed-scaled-object" fails with above error.
Steps to Reproduce the Problem

Install a scaledobject with some name targeting some deployment.
Rename the scaledobject in your helm charts and do a helm upgrade.

Logs from KEDA operator
No response
KEDA Version
2.11.2
Kubernetes Version
1.25
Platform
Amazon Web Services
Scaler Details
No response
Anything else?
No response

I think this is the correct behavior because the name is the identifier of the ScaledObject. Automatically replacing the current ScaledObject with another ScaledObject that has a new identifier can be a little tricky.

What's the right way to rename a ScaledObject when used with helm then?

We are also encountering a similar issue. In our case, the creation of the ScaledObject is failing because there is already an HPA for a deployment that we are attempting to update, as we are transitioning from native HPA to ScaledObject.
helm.go:84: [debug] admission webhook "vscaledobject.kb.io" denied the request: the workload 'app-prod-http' of type 'apps/v1.Deployment' is already managed by the hpa 'app-prod-http'

We are also encountering a similar issue. In our case, the creation of the ScaledObject is failing because there is already an HPA for a deployment that we are attempting to update, as we are transitioning from native HPA to ScaledObject.
helm.go:84: [debug] admission webhook "vscaledobject.kb.io" denied the request: the workload 'app-prod-http' of type 'apps/v1.Deployment' is already managed by the hpa 'app-prod-http'

For anyone else running into this, this did the trick for me.


Serenity-netCore news Questions & migration process

Hey Volkan, thanks for the direction the framework is going, everything is logical and makes sense in the decisions taken in your framework.
One small question :
Why you did not choose to (for those shared code) use of #if COREFX at least the time for the people to move to .netCore.
For now i have both applications on .netFullFramework and on .netCore and i could share components using this kind of directives (moved all the common stuffs into a shared package).
One day when all my applications have moved i will simply remove all #if !COREFX code.
I am currently in the transition period, probably like many.
ex :

And it also is useful to learn (visually) the differences between these 2 Framework versions.
Yes it leads to useless code but at least facilitate transitions without having to list all modifications in every file of the generated applications.

Another (1) small question related to aspnetCore Version.
I noticed Vegas plugins is still present but no progress bar is made visible (even on serenity.is/demo).
Is that normal ?

In demo there is a progress bar.
I'll better remove all these ifdefs, and will soon be obsoleting .NET MVC version.
Legacy .NET framework is dead, we have to accept it. .NET 5 will be based on .NET Core.

yes they are obviously not the future but please do not forget to warn us when you decide to remove (please not the way they do on webhosting when they suddenly decide to remove support of a PHP version).
I have personally not moved all my current applications to .netCore but in the process (my personal goal is max time october in order to be ready to move to .net5).
Thanks

Opened an issue for migration process, closing.


How can I enable loudspeaker on iOS? (Unity)

Thanks for writing this library, it was a great start to getting running in Unity!
I'm having trouble getting the audio to play through the speaker on iOS and am hoping someone can offer some advice. For android this technique from sebjf  worked but I was unable to create a similar function on iOS.
(Note I am not using the broadcast extension or anything - the code is mostly based on the Sora/PeerConnection example - I can provide more if relevant)
What I have tried

Setting the configuration in Unity:

Calling this function either before or after initialization of the RTC module and audio track:

#import <AVFoundation/AVFoundation.h>

void iOSAudio_setupAudioSession()
{
	AVAudioSession *session = [AVAudioSession sharedInstance];

    NSError *setCategoryError = nil;
    if (![session setCategory:AVAudioSessionCategoryPlayback
                  withOptions:AVAudioSessionCategoryOptionDefaultToSpeaker
                        error:&setCategoryError]) {
        // handle error
        NSLog(@"Audio already playing through speaker!");
    }
    else{
        NSLog(@"Forcing audio to speaker");
    }
}

Calling this function either before or after initialization of the RTC module and audio track:

#import <AVFoundation/AVFoundation.h>

void iOSAudio_setupAudioSession()
{
    AVAudioSession*session =[AVAudioSession sharedInstance];
	[session setCategory:AVAudioSessionCategoryPlayAndRecord
	                mode:AVAudioSessionModeVideoChat
			     options:AVAudioSessionCategoryOptionMixWithOthers | AVAudioSessionCategoryOptionDefaultToSpeaker | AVAudioSessionCategoryOptionAllowBluetooth
				    error:nil];

    [session setActive:true error:nil];
	[session overrideOutputAudioPort:AVAudioSessionPortOverrideSpeaker error:nil];
}

None of these seem to affect how audio is played back, and it is always coming out of the earpiece rather than the loudspeaker.
Is there any ideas as to why this might not work?
Cheers
Cam

Use RTCAudioSessionConfiguration. This project does not provide a binding for the class (yet), so write a generic binding or a function specific to your use case by yourself just like you did as iOSAudio_setupAudioSession. If you wrote a generic binding, we would appreciate a pull request for it.


Cleanup Validate Function

The switch statement in the validate function is getting a little bit ugly.

Renamed to "General Cleanup" as there are a lot of issues that could be addressed.
Because this project hasn't had any real organizational fixes or changes in 5 years, it might be time to reshuffle things around.  I'm thinking about the following:
One file for each API method that contains both the url construction and validation rules.  Also a corresponding .spec file for each.
Also adding a .jshint (to make sure all the missing curly braces and semi-colons get fixed)
I'd also like to switch everything to strict comparison operators (=== and !===) but I'm not totally sure that won't introduce regression issues.
Also worth considering is supporting a callback-as-second-argument in addition to the callback property so it plays nicer with promisify (I have no desire to switch the library to promises, but making it easy to wrap if someone desires would be a good convenience).  It wasn't really a standard convention when the library was created, but it definitely is now.
I'm not interested in switching to es6 (const/let) or adding additional build process/compilation.
Also would like better documentation, possibly using github wiki or a github-page example for browsing through the api methods.  This could be generated from jsdoc comments.


SignalRSamples route /deployment throw because of attempted SynchronousIO

Describe the bug
The sample uses :
  using (var textWriter = new StreamWriter(context.Response.Body))
  using (var writer = new JsonTextWriter(textWriter))

when the using statement ends, it will call Dipose() then Flush() ... ending up attemping to do Synchronous IO, that will blow up because it's disabled by default now
To Reproduce

checkout release/3.0-preview7
Run the SignalRSamples project
Hit the /deployment route
See error

Expected behavior
Not throwing ;)
Fix
using System.Json.Text.Utf8Writer is an IAsyncDisposable so it would fit the await using statement from the sample

Good catch! We could possibly even just remove this endpoint. It was part of a plan to do functional testing (and we needed the test app to "report" the commit/version/etc. it was running on) and we found a different way to do it. Fixing it is fine too though :).

@anurse the linked PR seems only fix it for Signalr samples
if the same route is used in other part i could try to fix others
i guessed it was for infra/internal check but did not dig deeper TBH

Fixed via https://github.com/aspnet/AspNetCore/pull/12165

if the same route is used in other part i could try to fix others

It should only be used in the SignalR samples. Thanks for the fix-up!


Added content for retail

Summary of the Pull Request

PR Checklist

[ ] Closes Issue #xxx
[ ] Code of Conduct signed. If not, go to Code of Conduct.

Validation Steps Performed

Adjusted structure of retail guidance
Adjusted structure/scope of retail solutions
Adjusted structure/scope of retail reference implementation


Add mbedtls_ssl_get_cipher_info() accessor

Description
Add mbedtls_ssl_get_cipher_info() accessor for mbedtls 3.0
This is a follow-up to an item in #5331
Status
READY
Requires Backporting
NO
Migrations
Yes: adds accessor to retrieve (const mbedtls_cipher_info_t *) from session
Todos

[x] Changelog updated

Follow-up from #5331 where @mpg wrote:

By the way:
I can't think of a meaningful difference between SSL_CIPHER_ALGKEYSIZE and SSL_CIPHER_USEKEYSIZE with any ciphersuite currently in use (or at least, implemented in Mbed TLS / that I know of). Perhaps this was meaningful for export ciphersuites which used artificially short keys (for example 40-bit RC4), but I think nowadays those two are always equal.

That is my thought, too, but I am not an expert in this area.

I've tried looking around a bit, and it's not clear to me what SSL_CIPHER is actually supposed to hold: namely, if it's the name of the cipher proper, or of the TLS ciphersuite. In all examples I've found, it was the name of the ciphersuite, and and actually the non-standard name used by the SSL engine (so, OpenSSL in most cases).

Ah, the joys of magic numbers vs (non-standard) human-readable strings.  Thanks for pointing it out.

Generally speaking, is there any kind of standard about what variables are to be defined in a CGI environment and what they should mean? Or has it evolved organically, with everyone trying to provide compatibility with previous/popular implementations?

Yes for CGI variables RFC3875 The Common Gateway Interface (CGI) Version 1.1
No for SSL variables.  Variables like SSL_CIPHER_ALGKEYSIZE and SSL_CIPHER_USEKEYSIZE likely did have significance at some point in the past.  The same may be said for some other SSL_ variables.  Still other SSL_ variables can be quite useful for backends implement policy checks on the same machine servicing requests where TLS is terminated in the web server.

const char *cs_name = mbedtls_ssl_get_ciphersuite( &ssl );
int cs_id = mbedtls_ssl_get_ciphersuite_id( cs_name );
size_t key_bits = mbedtls_ssl_get_ciphersuite_key_bits( cs_id );

Would that work for you?

That is a bit wasteful to look up a name, and then take the name to look up an id in a different table, when the first func operated with the id that is the result.  (ssl->session->ciphersuite)
const char *mbedtls_ssl_get_ciphersuite( const mbedtls_ssl_context *ssl )
{
    if( ssl == NULL || ssl->session == NULL )
        return( NULL );

    return mbedtls_ssl_get_ciphersuite_name( ssl->session->ciphersuite );
}

Aside: given the naming convention for accessors, I might expect mbedtls_ssl_get_ciphersuite_id() to take &ssl as its param instead of (const char *) (or might expect mbedtls_ssl_get_ciphersuite() to return the ciphersuite member, which is the ciphersuite id, but there would need to be an alt routine for the name, e.g. mbedtls_ssl_get_ciphersuite_name()).   Also, mbedtls_ssl_get_ciphersuite_key_bits does not exist (yet?).
I'd prefer a single convenience routine (this PR) which gets the (const mbedtls_cipher_info_t *) for the session, and I can use the accessor size_t algkeysize = mbedtls_cipher_info_get_key_bitlen(cipher_info);  Based on your observation above, I may choose mbedtls_ssl_get_ciphersuite( &ssl ) instead of mbedtls_cipher_info_get_name(cipher_info); for SSL_CIPHER.
I am ok with updating the lighttpd code to note that SSL_CIPHER_ALGKEYSIZE and SSL_CIPHER_USEKEYSIZE are equivalent with the current set of modern ciphers.

That is a bit wasteful to look up a name, and then take the name to look up an id in a different table, when the first func operated with the id that is the result.

Yes,I was just trying to re-use the existing API. If I was designing that API from scratch today, it would probably look different. However, while it's indeed inefficient and feels wrong to first look up a string from a numerical identifier and then immediately loop up again the other way, in the grand scheme of things, this only happens after the handshake, which was way more resource consuming, so I'm not sure it's worth redesigning that part of the API for that now, especially as the natural name for a function that get the ciphersuite id from the context is already taken by a function which, as you note, does something different.
(Perhaps in 4.0 we can clean that up. But for now existing functions have to stay as they are and we can only add new functions.)

Also, mbedtls_ssl_get_ciphersuite_key_bits does not exist (yet?).

Yes, I meant to suggest we add that function. Reading my message again, I did not make that clear at all, sorry.

I'd prefer a single convenience routine (this PR) which gets the (const mbedtls_cipher_info_t *)

At any other time that would indeed be the obvious right thing to do. But this is a special time: as I explained, we are phasing out the Cipher module (or at least as a first step, its usage from the TLS layer). We'd like, in some 3.x version of Mbed TLS, to be able to compile the TLS part with MBEDTLS_CIPHER_C disabled, and in a future major version, completely remove cipher.c. So, we absolutely don't want to expose mbedtls_cipherstructures in the public API, or design APIs so that people need to call mbedtls_cipher functions. Again, other than that this solution would very reasonable, but given our plans, it's just not acceptable, sorry.
So, I would suggest:

Adding a function that takes a ciphersuite ID and returns the corresponding key length.
If you need to extract some other info, add functions taking a ciphersuite ID and returning the info you need.
If you can find a good name for it given the constraints of the existing functions, adding a function that takes an SSL context and returns the corresponding ciphersuite ID (numerical), because I agree the current double look-up is irritating.

Would that work for you?

(I had labeled "enhancement" by mistake: this is a regression, because some useful information that was accessible before 3.0 is no longer conveniently accessible.)

At any other time that would indeed be the obvious right thing to do. But this is a special time: as I explained, we are phasing out the Cipher module (or at least as a first step, its usage from the TLS layer). We'd like, in some 3.x version of Mbed TLS, to be able to compile the TLS part with MBEDTLS_CIPHER_C disabled

Thanks for repeating that.  I had not grok'ed that I should also avoid mbedtls_cipher_info_get_*() functions to keep up with the future direction of the library.
Should I close this PR and create a new PR to discuss mbedtls_ssl_get_ciphersuite_key_bits and similar?

Prior art in ssl_ciphersuites.h suggests
mbedtls_ssl_ciphersuite_get_name()
and extending that to the underlying cipher (which you want to abstract from the TLS layer)
mbedtls_ssl_ciphersuite_get_cipher_key_bitlen()  (instead of mbedtls_ssl_get_ciphersuite_key_bits())
These would take (mbedtls_ssl_ciphersuite_t *) and could (at least for mbedtls 3.0) be inline functions in ssl_ciphersuites.h
To obtain (mbedtls_ssl_ciphersuite_t *) -- and with mbedtls_ssl_get_ciphersuite() and mbedtls_ssl_get_ciphersuite_id() already used incompatibly -- I would propose following prior art in ssl_ciphersuites.h, where mbedtls_ssl_ciphersuite_from_string() and mbedtls_ssl_ciphersuite_from_id() already exist.  Would a new mbedtls_ssl_get_ciphersuite_id_from_ssl() be acceptable in ssl.h?

Alternate proposal filed as PR #5428 and should replace this PR.

Closing, replaced with #5428


layers/meta-opentrons: reboot mlan0 on crash

Sometimes, the wifi adapter firmware crashes, and the device goes down. To fix (well, "fix") this, we can add a watcher script for NetworkManager's dispatcher interface, look for the down event, and restart the bus .

Put a build on a robot, ssh'd in, unbound the wifi interface, and it came right back!


Add publish action

What problem does this PR solve?
When we build a new release, this action will publish to pypi.org auto.
What is changed and how it works?
defalut: none
Check List

[ ] unit test
[ ] integration test
[ ] modify doc
[ ] change source code

https://github.com/pingcap/dbt-tidb/wiki/How-to-release-dbt-tidb please update this wiki


onedrive: Overwrite object size value with real size when reading file.

Because of a bug in the Onedrive API it will sometime report the wrong size. If the size is wrong other remotes that depend on the size might fail. To fix this we overwrite the objects size with the real size from ContentLength header.

Is this about workin around this bug in onedrive?
This fix makes me slightly nervous since it effectively masks problems which might occur with the download truncating the size of the file... I guess reading it from the ContentLength is reasonably definitive since that must have been set by Microsoft.
How did you notice the problem?

Yes exactly. This is a work around for the wrongly reported size. I noticed when I tried backing up my Onedrive to B2. I have about 30GB of mixed data and it failed for both quite a lot PDFs and image files because of file size diff between what B2 backend put in its header and the actual size sent.
I thought that it was better to put the fix in the onedrive backend even while the b2 upload failed and nto download from onedrive since its onedrive that is causing the problem and hence should own this ugly workaround (also in case some other backends than B2 uses it).
I updated the PR with a if statement around it to check that the contentlength is > 0.
I also had some thoughts about range download, if the whole file is not downloaded at once since the content length would only be the size of the chunk in that case.. But in my testing it never happened, and Im not familiar enough with rclone to know if it can happen? (this is the first time I tried using it and also first time looking at the code)

One test failed in travis, but seems like its unrelated to this PR..?

I thought that it was better to put the fix in the onedrive backend even while the b2 upload failed and nto download from onedrive since its onedrive that is causing the problem and hence should own this ugly workaround (also in case some other backends than B2 uses it).

It is a great fix - I wish I'd thought of it :-)

I also had some thoughts about range download, if the whole file is not downloaded at once since the content length would only be the size of the chunk in that case.. But in my testing it never happened, and Im not familiar enough with rclone to know if it can happen? (this is the first time I tried using it and also first time looking at the code)

Yes rclone can use range requests - well spotted.
I think you want another term in your if statement so you don't set the size if there is a Content-Range header.  You could also skip adding the size if the response wasn't http.StatusOK.  I'd probably do both of those things - I've seen enough out of spec HTTP servers while writing rclone ;-)

One test failed in travis, but seems like its unrelated to this PR..?

The cache tests are a little intermittent which we've been trying to fix in #2045 - sorry!

Sounds reasonable, ive updated the PR


Fixes propagation handling

awaiting a release of brave 4.15.1 as it fixes a small glitch in the test fixture

ok bumped to released version and fingers crossed

I thought I saw a message about a leak. I immediately looked for things
that could leak (span in scope is the only thing besides things that could
use it threadlocalspan).
It was a shotgun response
On Wed, Feb 14, 2018 at 11:57 AM, Ho Yan Leung<EMAIL_ADDRESS>wrote:

@hyleung commented on this pull request.
In src/main/java/ratpack/zipkin/internal/DefaultServerTracingHandler.java
https://github.com/hyleung/ratpack-zipkin/pull/56#discussion_r168072185:

 });

ctx.next();

//place the Span in scope so that downstream code (e.g. Ratpack handlers
//further on in the chain) can see the Span.
try (Tracer.SpanInScope scope = tracing.tracer().withSpanInScope(span)) {

I would never have spotted that - out of curiosity, what do the logs say
in this case (and would it warrant a test failure)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hyleung/ratpack-zipkin/pull/56#discussion_r168072185,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD6130FsojC6Cg-VS75OkoGTCahlTTxks5tUlm8gaJpZM4SDXZp
.

So the risk here is that there's a thread jump between the client
requestConfigurer and the wiretap listener. I'll poke around for a
different approach, and regardless add some code comments about the
impact.

last commit on https://github.com/hyleung/ratpack-zipkin/pull/57 fixes
the thread local approach. nice catch @hyleung


Specifying cuda version doesn't work

According to the readme it should be possible to specify the cuda version as a role variable. It isn't specified how to define it, though, and none of the ways I tried work.
This probably is just a documentation issue, but how am I supposed to specify the cuda version?
Version: 1.6.6
What did I try
Specify the cuda-10-0 package
cuda_packages
    - cuda-10-0

Result:
googlecompute: TASK [cscfi.cuda : Install CUDA packages (1.5-2GB download, also restarts if cuda_restart_node_on_install is set to True)] ***
googlecompute: failed: [default] (item=cuda=cuda-10-0) => {"ansible_loop_var": "item", "cache_update_time":<PHONE_NUMBER>, "cache_updated": false, "changed": false, "item": "cuda=cuda-10-0", "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"      install 'cuda=cuda-10-0'' failed: E: Version 'cuda-10-0' for 'cuda' was not found\n", "rc": 100, "stderr": "E: Version 'cuda-10-0' for 'cuda' was not found\n", "stderr_lines": ["E: Version 'cuda-10-0' for 'cuda' was not found"], "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information..."]}

Specify the cuda package version:
cuda_packages
    - cuda=10.0

Result:
googlecompute: TASK [cscfi.cuda : Install CUDA packages (1.5-2GB download, also restarts if cuda_restart_node_on_install is set to True)] ***
googlecompute: failed: [default] (item=cuda=10.0) => {"ansible_loop_var": "item", "cache_update_time":<PHONE_NUMBER>, "cache_updated": false, "changed": false, "item": "cuda=10.0", "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"      install 'cuda=10.0'' failed: E: Version '10.0' for 'cuda' was not found\n", "rc": 100, "stderr": "E: Version '10.0' for 'cuda' was not found\n", "stderr_lines": ["E: Version '10.0' for 'cuda' was not found"], "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information..."]}

Interesting! How about with apt install?
Which works?
Maybe the whole packagename like cuda-10-0_10.0.130-1_amd64  or cuda-10-0_10.0.130 if you are on Ubuntu 1804?
With Ubuntu it seems each ubuntu releaser supports very few cuda versions : https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/

Sorry, I should have specified - yes, I'm on Ubuntu 18.04!
It was silly of me to just try 10.0 - of course I need to define the full package version. Thanks for pointing that out to me. If I use cuda=10.0.130-1 installation works like a charm, but the cuda version shown by nvidia-smi is still 10.1. Not exactly sure how and why this happens, as there aren't any cuda 10.1 packages installed ....

Thanks!
I created PR #30 to document how to do that. To be honest I never thought specifying the package like that would actually work. So thank you @tgamauf !
About nvidia-smi I do not follow, at least https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/ has cuda-10.1 packages?
Also I'm not sure what nvidia-smi checks, probably the kernel modules loaded so if one downgrades cuda-rpm I would maybe still make sure dkms/kernel modules are actually really updated.
(Our openstack's CentOS images also have yum autoupdate on enabled which would update cuda rpm within a day or so. )

About nvidia-smi I do not follow, at least https://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/x86_64/ has cuda-10.1 packages?

cuda-10.1 (and now cuda-10.2) packages are available in the repo, but they haven't been installed in the image I created. However, I found a likely cause - it looks like nvidia-smi only shows the maximum supported cuda version, not the currently installed (see the comment by talonmies to this stackoverflow answer).
I checked the cuda version using nvcc and everything is alright.
Thanks again!


The entire Lodash library is being imported

Lodash is being imported with this syntax:
import _ from 'lodash';

This is bad for bundle size as the entire Lodash library is being imported. Instead, the import statements should look like this:
import _get from 'lodash/get';
import _isEqual from 'lodash/isEqual';
import _findIndex from 'lodash/findIndex';
import _assign from 'lodash/assign';

This issue has been resolved. Thanks!


Reduced amount of libraries included in several container images.

Description

Reduced amount of libraries included in several container images.
Only very few dynamic libraries are actually required in the cni, typha
and kube-controllers containers as most functionality is statically linked
into the binaries. Therefore, it is not required to bundle all libraries
from the base image, but it is sufficient to only include a select few.
Related issues/PRs

Fixes #6123.
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

/sem-approve


Make sure that account is correctly rekeyed back

This addresses issue https://github.com/joe-p/account_abstraction/issues/6 and makes sure that in verifyRekeyToAbstractedAccount the controlled account is rekeyed back to the app account.

This seems like something we should actually follow through on merging.


[AUTOPATCHER] Patches CVE-2022-22824 for expat

        Patches CVE-2022-22824 for expat.
        This patch and PR was automatically generated and needs human verification before merging.

Will be resolved by #1934


gh-250: Fix Jest testing error

This simply reverts a change made in gh-202 and added some comments about when the line of code can be restored.

I'm going to close this PR as the change was required for #236 anyway, where I've done the same change and updated the README for explanation. See PR #245 for review.


URL for socketIO connection

Abodepy is working great for me. However, I'm looking for the socketIO URL. I want to ensure that SSL is being used and my username and password are not being passed unencrypted. Thanks.

URL's and other things that don't change are stored in the CONSTS file and used throughout the source

Main URL here: constants.py#L48
Main URL combined with the login path here: constants.py#L50
SocketIO URL here: constants.py#L86

The SocketIO url is a Secure Web Socket URL (WSS).
Here is where the POST request is made using the login URL with your username and password: init.py#L132
You can see that the SOCKETIO_URL is passed to the event controller here: init.py#L64
Which is passed in to the SocketIO client here: event_controller.py#L30
After we login to Abode we are handed back a cookie that is stored within the session object that we can use to make follow up requests with. We utilize the same session in the login request to connect to the Abode websocket server here: event_controller.py#L126-L130
TL;DR: We login with your username and password as a POST request to the LOGIN_URL above, which is using HTTPS and thus your username and password are sent encrypted to Abode. Abode hands us back a cookie after a successful login. We then connect using a secure web socket connection (WSS) to the SOCKETIO_URL and pass that same cookie along. Your username and password are never sent to the websocket server, but all communication is encrypted.

Perfect. Thanks for the references.
On Fri, Feb 15, 2019, 10:35 AM Mister Wil<EMAIL_ADDRESS>wrote:

URL's and other things that don't change are stored in the CONSTS file and
used throughout the source

Main URL here: constants.py#L48
https://github.com/MisterWil/abodepy/blob/master/abodepy/helpers/constants.py#L48
Main URL combined with the login path here: constants.py#L50
https://github.com/MisterWil/abodepy/blob/master/abodepy/helpers/constants.py#L50
SocketIO URL here: constants.py#L86
https://github.com/MisterWil/abodepy/blob/master/abodepy/helpers/constants.py#L86

The SocketIO url is a Secure Web Socket URL (WSS)
https://devcenter.heroku.com/articles/websocket-security#wss.
Here is where the POST request is made using the login URL with your
username and password: init.py#L132
https://github.com/MisterWil/abodepy/blob/master/abodepy/__init__.py#L132
You can see that the SOCKETIO_URL is passed to the event controller here:
init.py#L64
https://github.com/MisterWil/abodepy/blob/master/abodepy/__init__.py#L64
Which is passed in to the SocketIO client here: event_controller.py#L30
https://github.com/MisterWil/abodepy/blob/master/abodepy/event_controller.py#L30
After we login to Abode we are handed back a cookie that is stored within
the session object that we can use to make follow up requests with. We
utilize the same session in the login request to connect to the Abode
websocket server here: event_controller.py#L126-L130
https://github.com/MisterWil/abodepy/blob/6f84bb428fd1da98855f55083cd427bebbcc57ae/abodepy/event_controller.py#L126-L130
TL;DR: We login with your username and password as a POST request to the
LOGIN_URL above, which is using HTTPS and thus your username and password
are sent encrypted to Abode. Abode hands us back a cookie after a
successful login. We then connect using a secure web socket connection
(WSS) to the SOCKETIO_URL and pass that same cookie along. Your username
and password are never sent to the websocket server, but all communication
is encrypted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MisterWil/abodepy/issues/42#issuecomment-464093019,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ag6q4WrgDPJGx8qHVFNIqqf-GQfYebAMks5vNtPOgaJpZM4a9Wyz
.


Fix a number of sphinxdocs errors

Description
When you run make docs, sphinx will list any errors encountered during docs generation in red.  (they can come from anywhere: docstrings that are unparseable, errors in rst, etc).  Currently, we have a lot of them.  This PR aims to fix as many as possible, and also adds a few niceties, like auto-linking of PR numbers in our sphinx release notes, to the respective PRs.
sidenote/reminder:  codeblocks in .rst require two backticks (`) instead of one. so I changed them in our release notes.
There are two remaining issues that are harder to fix, which I'm happy to leave till later:

hook_specifications.rst:2: WARNING: duplicate object description of napari.plugins.hook_specifications.napari_get_reader, other instance in api/napari.plugins, use :noindex: for one of them

the problem here is that we'd like to have a special page for hook specifications, and apidocs don't give you granular control over indexing or not indexing specific functions.

CONTRIBUTING.md:40: WARNING: None:any reference target not found: ../pyproject.toml

problem here is that we move the devdocs when building them for sphinx, so relative links break. longer term solution is to pick whether we're writing docs for distribution on github or sphinx, and stick with one method.

sidenote/reminder: codeblocks in .rst require two backticks (`) instead of one. so I changed them in our release notes.

Given the merge on #1043 our release notes are going to be markdown moving forward. I was actually planning a dedicated PR just to convert our old ones to the new formatting so maybe best not to change them in this PR.

undid those backtick changes (but I did leave a couple changes in there where newlines in a list were not indented)


Nontrivial tests

The existing tests are pretty trivial. We need to test the actual behaviour properly.

I'm going to stop here and do the next bunch in a new branch. Ready for review. :-)

:+1:


Prompt for parameters

Installed the new 6.0.2 version and now whenever I trie to run my previously fine working scripts I get a prompt to bind parameters:

Previously this part was working fine:

Now I get an error:

Can you please tell me what has changed, where is the problem now ?

Hi,
I have exactly the same issue with PostgreSQL and the "$" character.
With PostgreSQL, it is possible to use double dollar as character string delimiter.
For example, the following query is syntaxically correct:
SELECT $$A text$$, col1 FROM table1;
But when I try to execute the query, DBeaver asks for bind parameters, since there is no bind parameters, because it automatically detects $ as a bind parameter.
Is it possible to choose its own character as bind parameter character?
Thanks in advance for your help.
Regards,
Cedric

Ok, I have found that it is possible to inactivate variables in the SQL settings.

the problem was in incorrect parameter prefix config in SQL Server extension. Now resolved.


[QUESTION] How to use pytorch multiprocess to launch deepspeed ？

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Closing, please re-open if this is still an issue.


add map for matcher or regex

type: suggestion
could author consider to add a map(dict) for url matcher or url regx?
just like:
url : https://exmpale.com/...../&model=purchase.order&action=523&menu_id=233
my mind is to match (purchase.order), and then use dict map, may be:  (PO)，and then showing in tab title with transferred value: PO

sorry, it's first time to add suggestion in github, may be the article didn't have right format


inotify detecting new files but not file changes where the filename remains the same

I don't know if this is the way inotify is supposed to work or not but the behavior I'm seeing is that inotify will detect a change for newly create files (ie. imports of new movies or upgrades (ie. movie-bluray720p.mkv changing to movie-bluray1080p.mkv)) but it will not detect file changes when the file remains the same (ie. file being converted where the file size gets reduced but the name remains the same).

Are those changes being written/processed from the same machine that autoscan resides on? Is the disk the changes are being written to local to the host that autoscan is running from? I ask because, if you have the storge network attached on the host autoscan is on, and the initial writes are occuring from that host to the network storage, autoscan will see that, but if another system reaches out and modifies the content on said network storage, autoscan will not see that (unless that second host is reaching out to local disks on host where autoscan resides)


Context is not aligned properly in API card

Context is not aligned properly in API card

Fixing with https://github.com/wso2/carbon-apimgt/pull/7261


Avoid libbpf-dev dependency for CNDP applications

Currently CNDP applications using xskdev.h header needs to include libbpf-dev as dependency because xskdev.h includes <bpf/xsk.h>. Is it possible to refactor xskdev_info_t structure in xskdev.h  such a way that we can include “xskdev_xxx” data types in some private structure defined in an internal header file like xskdev_internal.h and then have a member variable like void *priv in xskdev_info_t structure.
File: xskdev_internal.h
#include <bpf/xsk.h>

typedef struct xskdev_info_internal {
    xskdev_rxq_t rxq;              /**< RX queue */
    xskdev_txq_t txq;              /**< TX queue */
    xskdev_get_mbuf_addr_tx_t     __get_mbuf_addr_tx;         /**< Internal function to set the mbuf address on tx */
    xskdev_get_mbuf_rx_t           __get_mbuf_rx;                   /**< Internal function to get the mbuf address on rx */
    xskdev_pull_cq_addr_t          __pull_cq_addr;                  /**< Internal function to pull the complete queue */
}

File: xskdev.h
typedef struct xskdev_info {
      …..

      void *priv; /**  >struct xskdev_info_internal > **/
       …..
}

File: xskdev.c
#include  xskdev_internal.h
#include xskdev.h

xskdev_info  xskdev;
struct xskdev_info_internal *xskdev_internal = (struct xskdev_info_internal *) xskdev->priv;

I don't understand what the benefit of this is? that dependency is based on the low level APIs/structs living in libbpf?
Also the location of the xsk.h file is dependent on kernel version as it may come from libxdp?

Can we hide libbpf-dev dependency from CNDP applications ? That way CNDP applications doesn't have to include libbpf-dev as a dependency. CNDP apps only would need libbpf library dependency and not header files. One option I'm thinking is the possibility to include "bpf/xsk.h" in xskdev.c instead of xskdev.h .

If we strongly feel we need to change it we can do it. However from this point onwards I would resist changing "core" APIs unless these changes are really needed.

I agree with Maryam here. I do not see the need to not include libbpf-dev in the install process. Having too many void * pointer can make it difficult for the compiler to detect issues. I am worried we are making this change just for Rust and after the PMD static builds causing a lot of issues, it does not seem like it provides significant benefit overall.
We can leave the issue as an open for now.

Issue was related to including libbpf-dev for CNDP OMEC-UPF / BESS instead of just using libbpf0. I think this header file dependency could be resolved. But if it's too much of a hassle we can deprioritize or close this issue.

I'll try to convince the OMEC UPF maintainers that libbpf-dev is a required dependency for CNDP since CNDP public header file (xskdev.h) includes libbpf header file. If still there is concern we can consider refactoring xskdev.h.

@manojgop Can we close this issue now?


Bug in appending functions to list

lst = []
lst += [lambda a: 7]
print(lst[0])

lst = []
lst.append(lambda a: 7)
print(lst[0])

When executing in browser the transcrypt 3.9.0 version we obtain:
>> f
>> function __lambda__(a){return 7}

while for standard python we should obtain the function in any of the two cases!

After a bit I realized that it was because of the missing __pragma__("opov").
Still I would not expect implicit conversion to string in such a case!


Add MANIFEST.in for source distribution

This PR adds the MANIFEST.in file required to add necessary files into the source distribution uploaded to PyPI (those files are bundled in the .whl file via setup.py). It is based on https://github.com/NSLS-II/scientific-python-cookiecutter/blob/master/{{ cookiecutter.repo_name }}/MANIFEST.in.
Comparison:
main branch:
$ tree lixtools-2<IP_ADDRESS>
lixtools-2<IP_ADDRESS>
├── PKG-INFO
├── README.md
├── lixtools
│   ├── __init__.py
│   ├── atsas.py
│   ├── hdf.py
│   ├── mailin.py
│   ├── modeling.py
│   └── notebooks.py
├── lixtools.egg-info
│   ├── PKG-INFO
│   ├── SOURCES.txt
│   ├── dependency_links.txt
│   ├── requires.txt
│   └── top_level.txt
├── setup.cfg
└── setup.py

this PR branch:
$ tree lixtools-2<IP_ADDRESS>
lixtools-2<IP_ADDRESS>
├── LICENSE
├── MANIFEST.in
├── PKG-INFO
├── README.md
├── lixtools
│   ├── __init__.py
│   ├── atsas.py
│   ├── hdf.py
│   ├── mailin.py
│   ├── modeling.py
│   ├── notebooks.py
│   ├── plate_label_template.html
│   └── template_report.ipynb
├── lixtools.egg-info
│   ├── PKG-INFO
│   ├── SOURCES.txt
│   ├── dependency_links.txt
│   ├── requires.txt
│   └── top_level.txt
├── setup.cfg
└── setup.py

I'd recommend using the https://github.com/NSLS-II/scientific-python-cookiecutter project to generate all infrastructure files for this project (docs, CI, etc.) Would you like to give it a try following the detailed instruction in https://nsls-ii.github.io/scientific-python-cookiecutter/preliminaries.html, @lyang11973?

I'd recommend using the https://github.com/NSLS-II/scientific-python-cookiecutter project to generate all infrastructure files for this project (docs, CI, etc.) Would you like to give it a try following the detailed instruction in https://nsls-ii.github.io/scientific-python-cookiecutter/preliminaries.html, @lyang11973?

I opened an issue https://github.com/NSLS-II-LIX/lixtools/issues/2 for this request, which should be done via a separate PR. This PR is targeting a fix for the missing files (LICENSE, plate_label_template.html, template_report.ipynb).
Also, I haven't observed any tags for this repo. It would be great to have a tag for each PyPI build. The procedure we follow is documented here: https://nsls-ii.github.io/scientific-python-cookiecutter/publishing-releases.html.
Please merge this PR, cut a new tag, and push to PyPI. Then I'll be able to build a conda package via https://github.com/nsls-ii-forge/lixtools-feedstock. Right now, with the missing files, the package is incomplete.

Hi Maxim, since I'm the only one contributing to this package, I would
rather keep it simple for now. The files on PyPI are up to date.
On Wed, Feb 24, 2021, 6:18 PM Maksim Rakitin<EMAIL_ADDRESS>wrote:

I'd recommend using the
https://github.com/NSLS-II/scientific-python-cookiecutter project to
generate all infrastructure files for this project (docs, CI, etc.) Would
you like to give it a try following the detailed instruction in
https://nsls-ii.github.io/scientific-python-cookiecutter/preliminaries.html,
@lyang11973 https://github.com/lyang11973?
I opened an issue #2 https://github.com/NSLS-II-LIX/lixtools/issues/2
for this request, which should be done via a separate PR. This PR is
targeting a fix for the missing files (LICENSE, plate_label_template.html,
template_report.ipynb).
Also, I haven't observed any tags for this repo. It would be great to have
a tag for each PyPI build. The procedure we follow is documented here:
https://nsls-ii.github.io/scientific-python-cookiecutter/publishing-releases.html
.
Please merge this PR, cut a new tag, and push to PyPI. Then I'll be able
to build a conda package via
https://github.com/nsls-ii-forge/lixtools-feedstock. Right now, with the
missing files, the package is incomplete.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NSLS-II-LIX/lixtools/pull/1#issuecomment-785458130,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNJXDYUVTSEUWI3BN56OL3TAWCNRANCNFSM4YFNFF7Q
.

As explained in the description, there are missing files in the source distribution .tar.gz file. These updates from the present PR are needed to fix it for the next release.

Hi Maxim, since I'm the only one contributing to this package, I would rather keep it simple for now. The files on PyPI are up to date.

@lyang11973, by "simple", do you mean avoiding tags? I don't think they should be disregarded. How does one know what commit was used for a specific version on PyPI? From the packaging perspective that would be useful, for example, if we wanted to temporarily use the archived files from the GitHub tags instead of the sources on PyPI, to work-around the situation with the missing files in the source distribution on PyPI. Does it sound convincing?
From the DAMA perspective of maintaining the beamline-specific packages, anything that goes in the production conda environments on the experimental floor has to meet minimum requirements, and this PR is attempting to address some of them. Please accept and merge this PR, so that we could provide an expected package during the next deployment.

@lyang11973, I think the xlrd dependency should be removed from setup.py, as the package is not maintained for .xlsx files starting from v2. Here is my earlier investigation: https://github.com/NSLS-II-IOS/profile_collection/pull/11#issuecomment-771346996. The openpyxl should be used for that purpose, which you already have in your requirements. I'll update the list here.

@lyang11973, I saw another release on PyPI today, which still does not contain these fixes: https://pypi.org/project/lixtools/2<IP_ADDRESS>/#files. You can verify it yourself by downloading https://files.pythonhosted.org/packages/c4/a0/c2a5deb94962e3966afc2049c94f52dcca8327fecf4178cf24906a0a0845/lixtools-2<IP_ADDRESS>.tar.gz and unpacking it. You will see that the package is incomplete:
$ tree lixtools-2<IP_ADDRESS>
lixtools-2<IP_ADDRESS>
├── PKG-INFO
├── README.md
├── lixtools
│   ├── __init__.py
│   ├── atsas.py
│   ├── hdf.py
│   ├── mailin.py
│   ├── modeling.py
│   ├── notebooks.py
│   ├── ot2.py
│   └── webcam.py
├── lixtools.egg-info
│   ├── PKG-INFO
│   ├── SOURCES.txt
│   ├── dependency_links.txt
│   ├── requires.txt
│   └── top_level.txt
├── setup.cfg
└── setup.py

The wheel file is OK though, as it's controlled by setup.py, not MANIFEST.in. I have to mention that if the .whl file exists on PyPI, it will be used during the pip installation. However, conda uses .tar.gz sources from PyPI, which is a cause of the problem (current build fails: https://github.com/nsls-ii-forge/lixtools-feedstock/pull/3). Also, people may be interested in the source archive for code inspection, etc., so maintaining a proper package is critical. Please consider merging this update ASAP, so the conda packaging can be done flawlessly, and you get the package during the next deployment.


Not compatible with waterfall?

Hi!
Trying to install this on my Bungeecord proxy, I use a fork called Waterfall found here:
https://aquifermc.org/
This error happens on Bungee load:
https://pastebin.com/6UYRF9uf
Let me know if I'm doing something wrong, thanks!

You're attempting to load the Bukkit version on the Bungee server. You need to grab LuckPerms-Bungee from here https://ci.lucko.me/view/LuckPerms/job/LuckPerms/ for bungeecord :)


Log warning if UF2 block skipped due to mismatching family IDs

This pull-request outputs a warning when a UF2 block is skipped due to mismatching UF2 family IDs. I found this  useful when debugging an issue on my STM32F405 board.
If you believe this needs a discussion first or should be part of a larger logging effort then please feel free to reject it :grin:

there is a similar defined for logging here, would you mind update PR to use it instead. and also revert changes to the test files.

closed due to lack of response from user

Sorry @hathach, I forgot about this MR. Thanks for closing it.
Seasons Greetings! :christmas_tree:


Any plans to support Typer

Interesting project, does this support Typer or plans to be supported as one of those CLI packages?

Thanks for the suggestion. Definitely worth investigating imo
Atm I know very little about it beyond it wrapping click so given the partial click support I think it might be a challenge to offer full application support
I'll add it to my to-do list :)

Looked at sorting this and unfortunately the license changes with pysimplegui have resulted in some pretty big refactor work to support dearpygui. So this has been pushed back somewhat. Absolutely still on my radar though. Though if anyone wants to make a pr for this then you're welcome to


CTCP-2099: Update dependencies and ensure repo is ready for development

This compiles and is ready for development. It also properly marks the repo as public.

Yup, this was a "bare minimum" effort.


Thread pinning in AnnotatedSagaRepository.doLoad

Basic information

Axon Framework version: 4.7.4
JDK version:  OpenJDK 20 with --enable-preview switch
Complete executable reproducer if available (e.g. GitHub Repo): Haven't prepared anything, but I think it's still worth reporting

I've been experimenting recently with project Loom by replacing various thread pools with virtual thread executors and running my application with -Djdk.tracePinnedThreads=full JVM option. The stack trace below popped up after I replaced my Quartz scheduler thread pool and QuartzDeadlineManager triggered my saga's @DeadlineHandler method:
org.axonframework.modelling.saga.repository.jpa.JpaSagaStore.loadSaga(JpaSagaStore.java:157)
org.axonframework.modelling.saga.repository.AnnotatedSagaRepository.doLoadSaga(AnnotatedSagaRepository.java:231)
org.axonframework.modelling.saga.repository.AnnotatedSagaRepository.lambda$doLoad$1(AnnotatedSagaRepository.java:111)
java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708) <== monitors:1
org.axonframework.modelling.saga.repository.AnnotatedSagaRepository.doLoad(AnnotatedSagaRepository.java:110)
org.axonframework.modelling.saga.repository.AnnotatedSagaRepository.doLoad(AnnotatedSagaRepository.java:56)
org.axonframework.modelling.saga.repository.LockingSagaRepository.load(LockingSagaRepository.java:64)
org.axonframework.modelling.saga.AbstractSagaManager.send(AbstractSagaManager.java:235)
org.axonframework.deadline.quartz.DeadlineJob.lambda$executeScheduledDeadline$4(DeadlineJob.java:183)

The thread pinning happens because of synchronized block in ConcurrentHashMap.computeIfAbsent method. That block wraps a call to mapping function which happens to do I/O when underlying SagaStore implementation is anything different than InMemorySagaStore (in my case it is JpaSagaStore).
At first this may look like something that should be reported to OpenJDK guys, but after quick skimming of JDK's mailing list it turns out that they are aware of this, but the fix is nowhere near close (according to Doug Lee himself), so it might be worthwhile to fix it in the framework itself before Loom goes GA (which happens in a few months apparently). The obvious solution would be to replace ConcurrentHashMap with HashMap + ReadWriteLock combo.
Expected behaviour
Virtual thread is not pinned to carrier thread when a saga is first loaded into managedSagas map in AnnotatedSagaRepository.
Actual behaviour
Virtual thread is pinned, which might lead to a potential deadlock in the JVM when all carrier threads become blocked.

This is extremely helpful of you to share with us, @mjagus!
Was the only spot you faced issues with this on using Virtual Threads?
We tried Virtual Threads some time ago for our Streaming Event Processors, which seemed to work fine.
But if there are more spots you have encountered, that would be helpful.
Do note that I do not think we are dealing with a bug here, if I am honest with you.
It is more of an enhancement request to support a new feature from a JDK version thatAxon Framework is not built on.
Granted, providing that support is fair at some stage.
I will, however, remove the bug field and rename the ticket to Virtual Thread support.

Hi Steven,
This is the only example of thread pinning I encountered during runtime. Every other part of the framework that I used seemed to work flawlessly with virtual threads enabled.
I also briefly looked at framework's source code to see if there are any obvious code patterns that may lead to thread pinning and I noticed EventProcessorTask.run method that has a synchronized block inside of which it may indirectly call event handlers:
    @Override
    public void run() {
        synchronized (runnerMonitor) {
            boolean mayContinue = true;
            int itemsAtStart = taskQueue.size();
            int processedItems = 0;
            while (mayContinue) {
                processNextTask();
                processedItems++;
                // Continue processing if there is no rescheduling involved and there are events in the queue, or if yielding failed
                mayContinue = (processedItems < itemsAtStart && !taskQueue.isEmpty()) || !yield();
            }
        }
    }

Since event handlers are allowed to do I/O, this code will most likely cause the virtual thread executing this code to be pinned. EventProcessorTask seems to be only used by a subscribing event processor when AsynchronousEventProcessingStrategy is configured. Since I'm using tracking event processors in production, this has not popped up during my experiments with Loom.

Minor update on this issue, mainly concerning the milestone.
I attached this issue to 4.9.0 with a two-fold desire:

Further validate AF works with JDK21 and keep validating - covered through PR #2866
Investigate and adjust use of synchronized blocks to more nicely align with Virtual Thread support.

"Desire" one will be covered in release 4.9.0, but desire two cannot.
We simply do not have the resources to work on this at the moment, hence we'll move this effort towards a later point in time.
@mjagus, if you so desire, you're free to provide a pull request for your specific suggested points.
With the above, I think it's clear why I'll remove this issue from milestone 4.9.0.

Added this issue to release 5.0.0 as it will move to JDK21. This move should at least ensure we utilize its features correctly.


unknown flag: --network

I have my key setup in the config and it works but whenever I try to use the network flag it says it is unknown.
❯ ./go/bin/di-tui --network jazzradio
unknown flag: --network
Usage of ./go/bin/di-tui:
--password string   your di.fm password
--username string   your di.fm username
unknown flag: --network
All I have in my config is token and album art.  I'm curious what I might be doing wrong?

Wow, thanks for catching this. Version 1.10.0 was waiting in Draft mode to be published as the latest release.
When you upgrade to 1.10.0, you should be all set!

I am running into the same issue.  I installed it via go install and made sure I deleted it before reinstalling.  I can't tell what version it is though since there is no -v flag.  Am I typing it properly with di-tui --network jazzradio?

Yeah sorry about the no -v flag. This project started as me building something for myself, and was surprised that people found and used it.
With that said, head over to the releases (https://github.com/acaloiaro/di-tui/releases/tag/1.10.0) section and download the correct build for your platform. Whatever version you're currently running is not 1.10.0.
The command and args you provided above is correct for playing jazzradio.

It's a great client.  So much faster than the clunky web UI so thank you for sharing it!
Still have the same issue.  I think the problem is the packages in the 1.10.0 release are from May 5th which seems to be 1.91 and the source is from 2 weeks ago which was 1.92.

I just downloaded di-tui_1.10.0_Linux_x86_64.tar.gz from the releases page and it contains version 1.10.0, with the --network switch.
Which package are you downloading?

But downloading the di-tui_1.10.0_Linux_x86_64.tar.gz seems to work. Not sure why the other methods didn't. Just happy it works now.

Glad you got it working!

It would be cool if you could play the playlists in addition to the stations. Guessing that is a limitation with DI?

Believe it or not, I'm not a DI expert. When you say playlists, do you mean the tracks that you see available for a station from the web UI? If so, that's an entirely different API that's rather thard to reverse engineer. I've done the work to reverse it, but the audio format it serves doesn't have any native Go decoders, so I opted not to incorporate it since one of this app's priorities is being go-native. We get away with that by using Pulseaduio and not importing any platform-specific audio software.
The other reason di-tui is unlikely to support everything available in the web UI is because it's an undocumented API that can change at any time. Which is partially true of the one this app currently uses, but to a much lesser degree. Only login via username/password uses an undocumented API as of right now. We used to support adding/removing favorites through the undocumented API, but when they added Cloudflare in fron of it, it ended up blocking all of di-tui's requests.
I'll go ahead and close this issue for now.
Cheers!


Import from another package

This import is relative to another package, it does not work if bower directory is other than default, which is my case in some projects.
@import '../bower_components/foundation-sites/scss/util/util';

try this:
for those line with errors remove: ../bower_components/ and replace it with ../../
hope it helpts

As SASS doesn't allow variables in imports in this case you need to update the path manually.


Version bumb and --unstable warning

Hey @raluvy95 noticed you create a fork with some welcome changes 😄
Wondered if it is OK with you if I merge them?

yes, you can


provide missing configuration in DatabaseClientFactory.Bean

Add configuration missing in com.marklogic.client.DatabaseClientFactory.Bean:
https://github.com/marklogic/java-client-api/blob/develop/marklogic-client-api/src/main/java/com/marklogic/client/DatabaseClientFactory.java#L1205-L1486

by checking against com.marklogic.client.ext.DatabaseClientConfig:
https://github.com/marklogic-community/ml-javaclient-util/blob/dev/src/main/java/com/marklogic/client/ext/DatabaseClientConfig.java

Refer to #1020 for tests.


Missing PID for sample types created from templates

Currently, the IRI of a template_attribute won’t appear in the sample_attribute PID after a sample type is created from a template.

Related to issue https://github.com/seek4science/seek/issues/1010


portworx-essentials: add authors to the ci.yaml

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Are you familiar with our operator pipeline?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Your submission should not

[x] Add more than one operator bundle per PR
[x] Modify any operator
[x] Rename an operator
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description of the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

Please review the PR and approve it with /lgtm comment.
@piyush-nimbalkar @haibinxie @pure-jliao @cnbu-jenkins

@mantomas I thought if you are part of the reviewers list, then you don't need an approval. I am already part of the reviewers list.

/lgtm

@piyush-nimbalkar yeah, sorry for that, we have overlooked this. Should have been merged automatically - on it.

@mantomas No worries. Thank you for the quick turnaround.


bio_hansel handle interweave and compressed reads

Need to add option to allow for interweave and/or compressed reads as well. Default output from fastq-dump from sratoolkit is to have compressed reads so be best that it can work.

Works on compressed reads (gzip ) from fastq-dump.
Will not worry about interweave reads till someone ask for it.


NSInMemoryStoreType option

@mmorey, @tLewisII and contributing team
During my latest project, I found I would setup and teardown a persistenceController quite a number of times to thoroughly test a Core Data backed application. Using mocks would have been ok, but I really wanted to lean on the features that CD provides.
With this in mind .. and wanting to keep my test run-time as low as possible ... I thought using an InMemoryStoreType would be more efficient than hitting the disk for an SQLite file.
MDMPersistenceController API
Not wanting to make any breaking changes to the existing interface, I added a 2 new initializers to the MDMPersistenceController API to allow for creating an inMemoryStoreType.
I've tried to mimic the functionality of the existing default (SQLite) initializers.
- (id)initInMemoryTypeWithModel:(NSManagedObjectModel *)model

- (id)initInMemoryTypeWithModelURL:(NSURL *)modelURL

Before I pursue this, I wanted to get your thoughts .. is this feature necessary or does it complicate things ?

@mattglover looks good. Lets go ahead and update the README too.

README .. will do.
Thanks for your feedback.

@mmorey Let me know what you think .. :+1:

Thanks again @mattglover


Android Basics: change-app-theme

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-change-app-theme?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-change-app-theme#8
In which task and step of the codelab can this issue be found?
Describe the problem
Cómo personalizar el tema
Sigue las instrucciones de MaterialThemeBuilder/README.md. Te ayudará a personalizar atributos como el tipo, la forma y los colores.
https://github.com/material-components/material-components-android-examples/blob/develop/MaterialThemeBuilder/README.md
Page not found 404
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Duplicate of #241


Website hangs when searched for essentials on smartphone

Describe the bug
Site crashes when we search for essentials on Smartphones.
To Reproduce
Steps to reproduce the behavior:

Go to Menu
Click on Essentials
Click on Search
Type anything in Search Keyword
See error

Expected behavior
At least it should return 'No results found' when the search fails or it should return say top x items related to the search.
Screenshots

Smartphone (please complete the following information):

Device: OnePlus6T
OS: Android 10 OxygenOS 10.3.2
Browser Chrome 80.0.3987.149
Version 80.0.3987.149

I can look into this.

The same issue is happening on chrome Mac as well, the page becomes unresponsive

@ravindranrahul Are you working on this? This is a critical fix. Will need to add it soon.

Else we planned to disable search bar functionality for a while. If possible, Let me know the updates on this.

Yes, am working on this, meanwhile can we hotfix this by disabling search?

It would be ideal if we merge #1532 and i can add the fixes on this page too.

@ravindranrahul

For issue #1486 solution might be the same which I have implemented.
Use the inbuilt useDebounce hook which is already defined in react-script - @chinmaydalvi


failure to launch

When the user launches an application too quickly. Not all of the deployment fields are set. Notably the credential ID is missing, causing the deployment to fail. The launch buttons need to be more reliably enabled/disabled to avoid this behavior.

Is this still an issue?

No it's fixed


Add arbitrary position offsets for AnalyticOptics; rationalize overall shift/offset framework

Right now now can shift a FITSOpticalElement, but not an AnalyticOpticalElement. It should be possible to shift both of them via consistent API or function arguments.
Also right now there is a (undocumented?) det_offset option for Detector elements to offset them. Ideally this too should be made consistent in terms of interface and then documented.

See also https://github.com/mperrin/poppy/issues/40

Shifting analytic optics has been added, and a couple examples added to the docs. Just needs some unit tests eventually but I will add that to #71.
Still could do something about the det_offset option, maybe.

Cleaning up the undocumented det_offset option will wait until the next release.

The det_offset option is its own issue, #40 . I don't see any reason to keep this issue here open any longer.


Fix star-imports from stix2.v20 and v21

Fixes #399 .
stix2/__init__.py currently does a star-import from stix2.v20.  Unfortunately that brings in a "base" symbol which becomes stix2.base, and hides the actual stix2/base.py module.  This PR adds __all__s to the v20 and v21 modules which explicitly lists what symbols should be imported, so we don't get "base" by mistake from them.
(Impl note: the text block split() technique makes it easier to keep the __all__ lists up-to-date, because you can just copy-paste the symbol lists from the imports above.)

Codecov Report

Merging #404 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   98.44%   98.44%
=======================================
  Files         127      127
  Lines       14634    14636    +2
=======================================
+ Hits        14406    14408    +2
  Misses        228      228

Impacted Files
Coverage Δ

stix2/v20/__init__.py
100.00% <100.00%> (ø)

stix2/v21/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e41825...7def04f. Read the comment docs.

Thanks @chisholm!