LF reporting GoVendor is both active and not installed

OS: Debian Stable
LF versions: 5.4.0 and 3.1.1
I am trying to run license_finder on the repository https://github.com/prometheus/node_exporter. With version 3.1.1, LF is detecting dependencies. But with latest version, it reports contradictions - that LicenseFinder::Govendor is both active and not installed. See log below
$ license_finder version
5.4.0
$ license_finder
LicenseFinder::Go15VendorExperiment: is active
LicenseFinder::Govendor: is active
LicenseFinder::Govendor: is not installed

No dependencies recognized!

<Uninstalled latest version and then reinstalled version 3.1.1>
$ license_finder version
3.1.1

$ license_finder
.......................
Dependencies that need approval:
github.com/beevik/ntp, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, unknown
github.com/coreos/go-systemd, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, unknown
github.com/ema/qdisc, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, MIT
github.com/godbus/dbus, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, unknown
github.com/mattn/go-xmlrpc, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, MIT
github.com/mdlayher/wifi, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, MIT
github.com/prometheus/client_golang, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, "Apache 2.0"
github.com/prometheus/client_model, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, "Apache 2.0"
github.com/prometheus/common, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, "Apache 2.0"
github.com/prometheus/procfs, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, "Apache 2.0"
github.com/soundcloud/go-runit, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, MIT
golang.org/x/sys, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, "New BSD"
gopkg.in/alecthomas/kingpin.v2, vendored-05e55bddad50d79e6e5e28c7bfa7adc524135f41, MIT

The lines seems confusing/wrong to me
LicenseFinder::Govendor: is active
LicenseFinder::Govendor: is not installed

Hi @balasankarc this is a case where the wording in the log messages may be a little confusing. LicenseFinder first checks various criteria to see which package managers the project is using. In the case of govendor, LicenseFinder is looking for the existing of a vendor/vendor.json file. If it finds that file, it makes the package manager "active".
It's only after a package manager is considered active that it checks to see if the command it uses to get the list is installed and in the path.
You're seeing different behavior with 3.1.1 because it appears that in that version, it is silently falling back or including the results from the Go15VendorExperiment package manager.

It's only after a package manager is considered active that it checks to see if the command it uses to get the list is installed and in the path.
it is silently falling back or including the results from the Go15VendorExperiment package manager.

@kdykeman Two doubts

What does Go15VendorExperiment use as the command to get the list ?
How can I force LF to use Go15VendorExperiment as package manager?

Go15VendorExperiment uses go list -f "{{join .Deps \"\n\"}}" ./..., and then filters out the standard packages by subtracting the results of running go list std. The main issue with Go15VendorExperiment is this method of vendoring doesn't maintain any information about which version you've vendored. For this method, LF just gets the commit sha for your current working directory, prepends that with vendored- and uses that as the version for every package.
There's currently no way to override LF's decision about which Golang package manager to use. If you want to trick it into using Go15VendorExperiment, you could remove or rename the package management file that activates that package manager. In the case of govendor, you'd remove/rename vendor/vendor.json.


Navigation: Swipe to the right to go back

It would be neat to swipe right to go back to previous views
See this gif

Thanks!

I've considered it. One reason I haven't implemented it so far is that I think it will conflict with the swipe option for comments. The other one is that, if this is the type of navigation one prefers, why not simply use the OS's gesture navigation instead?

A lot of apps I use support this type of navigation, so it's a bit odd for me using Glider.
You would probably need a settings view with options to enable or disable this type of navigation and an alternative way to react to comments. I understand this is a big ask but would love to see it. This is the only well supported Hacker News android app, and it's great so far!

I had a go at this and wasn't too happy with the result. The typical suggestion for implementing swipe-to-go-back in Flutter is to just use CupertinoPageRoute which has this functionality baked in. That results in a very iOS-y interaction that doesn't look natural on Android devices.
If someone has a better suggestion for an implementation, such as a well-documented Flutter package that provides this feature, I'd like to hear about it.

Thanks for the update, I wish I could provide some info on that but I am clueless about Flutter.

Implemented in dabb2684abf7484b89a743434546538ddc85d6a6 and released to production as part of v1.9.0. In the end I did choose the option of copying and modifying the CupertinoPageRoute, throwing out any code I didn't need and customizing the behavior to fade the underlying page rather than sliding it into view. To prevent any conflict with the existing sliding actions, the swipe gesture only triggers on the edge of the page.

U

I use pixel like navigation where you navigate back by swiping from the edge of the screen.
So sometimes, swiping from the left when in news page, it goes back to the feed and also closes the app. (Screen recording below)
I would like to propose an option to enable the user to disable or enable the gesture navigation feature within the app.

Hmm. That's probably the same underlying problem as #32, actually. I think this is a bug in the Flutter framework as https://github.com/flutter/flutter/issues/83087 describes the same behavior. Would you mind opening a separate issue for this to make it easier to keep track of?

Hmm. That's probably the same underlying problem as #32, actually. I think this is a bug in the Flutter framework as flutter/flutter#83087 describes the same behavior. Would you mind opening a separate issue for this to make it easier to keep track of?

sure


Bot does not like mobile Youtube links (m.youtube.com)

Describe your context:
Bot fails to play music when there is an 'm.' before the link, for example: /play https://m.youtube.com/watch?v=bIgVecA77Qo will cause the bot to fail. But if you remove the 'm.' (https://youtube.com/watch?v=bIgVecA77Qo) the bot will play the Youtube link just fine. I believe this is just a quality of life request, if a user inputs a m.youtube link, have the bot remove the 'm.' part?
The path to the bug:
After performing /play https://m.youtube.com/watch?v=bIgVecA77Qo, the console outputs error:
[ERROR IN PLAYHANDLER] -> Traceback (most recent call last):
  File "/home/container/Handlers/PlayHandler.py", line 33, in run
    musicsInfo = await self.__searcher.search(track)
  File "/home/container/Music/Searcher.py", line 21, in search
    raise InvalidInput(self.__messages.UNKNOWN_INPUT, self.__messages.UNKNOWN_INPUT_TITLE)
Config.Exceptions.InvalidInput
 {<class 'Config.Exceptions.InvalidInput'>}

Screenshots:

Fixed

Same thing with videos with limited access (by link)

Can you give an example?

Thanks for the quick reply! Didn't describe the problem very correctly. Not a song, but a playlist.  Link to playlist

[ERROR IN PLAYHANDLER] -> Traceback (most recent call last):   File "/home/grisha/MusicBot/Handlers/PlayHandler.py", line 33, in run     musicsInfo = await self.__searcher.search(track)   File "/home/grisha/MusicBot/Music/Searcher.py", line 21, in search     raise InvalidInput(self.__messages.UNKNOWN_INPUT, self.__messages.UNKNOWN_INPUT_TITLE) Config.Exceptions.InvalidInput  {<class 'Config.Exceptions.InvalidInput'>}


Appstudio update test-component-pac-muct

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-muct-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
32 seconds
build-container

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
10 seconds
inspect-image

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
11 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
20 seconds
label-check

✅ Succeeded
20 seconds
optional-label-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom


i18n "ERROR in Unknown placeholder INTERPOLATION_1" with specific values

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.
@angular/cli: 1.3.2
node: 8.2.1
os: linux x64
@angular/animations: 4.3.6
@angular/common: 4.3.6
@angular/compiler: 4.3.6
@angular/core: 4.3.6
@angular/forms: 4.3.6
@angular/http: 4.3.6
@angular/platform-browser: 4.3.6
@angular/platform-browser-dynamic: 4.3.6
@angular/router: 4.3.6
@angular/cli: 1.3.2
@angular/compiler-cli: 4.3.6
@angular/language-service: 4.3.6

Repro steps.
ng new test-i18n
app.component.html - Add the following line:
<div i18n>Page {{'5'}} of {{'5'}}</div>

Extract Translation Data
ng xi18n --locale en --output-path src/i18n
"Translate" the file using some tool, in this case just copying the source to target, saving as "messages.en.xlf"
ng serve --aot --i18n-file=src/i18n/messages.en.xlf --i18n-format=xlf --locale=en
The log given by the failure.

ERROR in Unknown placeholder "INTERPOLATION_1" ("Page  of [ERROR ->]"): i18n@0:32

Desired functionality.
Shows "Page 5 of 5" instead of error.
Mention any other details that might be useful.
The error only occured if BOTH Interpolation parts were '5'
Using anything else: e.g. variables (page_offset), other numbers ('4' with '5' or '1' with '1'), numbers instead of strings (5), even using double quotes ("5") DID NOT result in the error.
This means after knowing that I can easily get around that, but still it is a very confusing issue.....
Or is there something I did not see?

Hello, can you give me the content of your xlf file please ?
Is this reproducible in plunkr?

messages.en.xlf.zip
(Do not know about Plunkr, never had Angular running there, especially with i18n)

So based on your xlf file:
<source>Page <x id="INTERPOLATION"/> of <x id="INTERPOLATION"/></source>
<target state="translated">Page <x id="INTERPOLATION"/> of <x id="INTERPOLATION_1"/></target>

In source you have two times INTERPOLATION but in target you have: INTERPOLATION and INTERPOLATION_1 which is why it doesn't work (INTERPOLATION_1 doesn't work)

Hm, so the tool is to blame that I used to make the translation, will have a look at that.
But still wondering why Angular i18n reacts so strange in that case...

well the IDs are used to match your translations with the content of your templates, if the ID is wrong then it fails and throws

For anyone encountering this error and ending up here - this can also occur if you've given identical IDs to two different messages.

@ocombe
Hello i'm currently working with i18n also and i found problems with translating dynamic text
How does i18n solve it ?

We plan to add a service for dynamic translations at runtime in ivy (the new renderer that we are working on). Right now it's not possible with built-in i18n.


Add row/col/box screenshot tests where we remove one modifier element from a child

Ensure the image changes as expected

Can we add these modifier removal test functions to the existing shared screenshot tests AbstractFlexContainerTest?

What is the proper method for switching to an empty modifier? I tried widget.modifier = Modifier which results in different behaviors from ComposeUI and View.
For example when I created and recorded the following screenshot test inside AbstractFlexContainerTest
@Test
  fun testColumnWithChildModifierChanges() {
    testContainerWithChildrenModifierChanges(FlexDirection.Column)
  }

  @Test
  fun testRowWithChildModifierChanges() {
    testContainerWithChildrenModifierChanges(FlexDirection.Row)
  }

  private fun testContainerWithChildrenModifierChanges(
    flexDirection: FlexDirection,
  ) {
    assumeTrue(flexDirection in listOf(FlexDirection.Row, FlexDirection.Column))
    val container = flexContainer(flexDirection)
    container.width(Constraint.Fill)
    container.height(Constraint.Fill)

    val first = text(longText(), backgroundColor = Red)
    first.modifier = MarginImpl(30.dp)

    container.add(first)
    container.add(text(mediumText(), backgroundColor = Green))
    container.add(text(shortText(), backgroundColor = Blue))
    container.onEndChanges()
    verifySnapshot(container, "Assigned_Modifier")

    first.modifier = Modifier
    container.onEndChanges()
    verifySnapshot(container, "Empty_Modifier")
  }

ComposeUI outputs the expected screenshots, while View always outputs the screenshot with a margin applied, Note that I tried different modifiers and widgets and I get similar results
I feel that I'm missing something 😅

Platform
Assigned Modifier
Empty Modifier

ComposeUI

View

Also in AbstractBoxTest When I attempt to call verifySnapshot(widget.value) once with the modifier assigned and again when the modifier is emptied, I receive a crash from the View platform.
app.cash.redwood.layout.view.ViewBoxTest > testChildrenModifierChanges[RTL] FAILED
    java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
        at android.view.ViewGroup.addViewInner(ViewGroup.java:5248)
        at android.view.ViewGroup.addView(ViewGroup.java:5077)
        at android.view.ViewGroup.addView(ViewGroup.java:5017)
        at android.view.ViewGroup.addView(ViewGroup.java:4989)
        at app.cash.redwood.layout.view.ViewBoxTest.verifySnapshot(ViewBoxTest.kt:69)
        at app.cash.redwood.layout.view.ViewBoxTest.verifySnapshot(ViewBoxTest.kt:33)

Test function
@Test
  fun testChildrenModifierChanges() {
    val redColor = coloredText(MarginImpl(30.dp), longText(), Red)
    val widget = box().apply {
      width(Constraint.Fill)
      height(Constraint.Fill)
      children.insert(0, redColor)
      children.insert(1, coloredText(text = mediumText(), color = Blue))
      children.insert(2, coloredText(text = shortText(), color = Green))
    }
    verifySnapshot(widget.value)
    redColor.modifier = Modifier
    widget.children.onModifierUpdated(0, redColor)
    verifySnapshot(widget.value)
  }

@JakeWharton , sorry for bothering you with a lot of questions 🙏, Let me know if my approach with the test functions is what we need

So it sounds like views are just broken today (which is the point of the tests!). We can file a separate bug about them not clearing state.


import-vm-apb template is using datavolumes not pvc

backport https://github.com/kubevirt/web-ui-components/pull/87 to v1.3

Pull Request Test Coverage Report for Build 256

2 of 7 (28.57%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 61.065%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Wizard/CreateVmWizard/CreateVmWizard.js
1
3
33.33%

src/components/Wizard/CreateVmWizard/utils.js
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/components/Wizard/CreateVmWizard/utils.js
1
14.29%

Totals

Change from base Build 249:
0.2%

Covered Lines:
458

Relevant Lines:
683

💛  - Coveralls

backport #87 to v1.3
can you explain please a bit more why is this PR here twice?

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1646947


Appium Inspector not able to display the Flutter elements only for iOS

Hi,
Background:
We are trying to build A automation for our apps. Recently we chose Browserstack and Appium as our tools of choice as these can automate tests for any mobile platform
We started with Android and there were no issues, but when we started with iOS we noticed the following:

We could get the list of elements from Appium Inspector if we inspect an iOS running within Simulator
We could not get  list of elements from Appium Inspector if we inspect an iOS running on real device
We could get the list of elements from Appium Inspector, if we enable Settings -> Accessibility -> Spoken Content -> Speak Selection, Speak Screen. I found this out through following this ticket: https://github.com/flutter/flutter/issues/17988. See comment: https://github.com/flutter/flutter/issues/17988#issuecomment-688674451

Seems like Flutter disables the list of elements if it's not a simulator
Is there a configuration or setting I can use to re-enable this on real devices please?
I have tried using: RendererBinding.instance.setSemanticsEnabled(true). This did not work for me, if this is the solution can someone please mention where do I need to enable this setting and is there anything else I need to do?

@harnit-bakshi
Flutter app don't yet fully support Appium yet, so the behavior you are seeing could be expected. See this comment  which indicates the required iOS support for appium isn't there yet.
You may follow-up in this issue for further reference / updates on Flutter's support for Appium, https://github.com/flutter/flutter/issues/18060 and https://github.com/flutter/flutter/issues/17988 for accessibility related updates.
Closing from here.

@darshankawar I have read all those tickets. My question relates to if I can see the elements for Flutter iOS app in Simulator then I should be able to see it in Real Device
So I am not even asking about Appium but generally questioning why is the List of Elements hidden for real device. Can you answer this specific question


use argparse on the list-variable-source script and remove hardcoded directory

originally requested at:
https://github.com/googlefonts/fontbakery/issues/1414
@felipesanches said:
@m4rc1e We need to use argparse on bin/fontbakery-list-variable-source.py and pass the following hardcoded directory as a command line argument:
parent_dir = '/Users/marc/Documents/googlefonts/manual_font_cleaning/'

To be done after merging #10

@felipesanches said:
This looks similar to https://github.com/googlefonts/fontbakery/issues/1416

Also use arparse on bin/gftools-ots.py

This script is now deprecated in #638, which moved everything to argparse anyway.


update all tables in the rules doc to contain all benchmarks

recommend to do so in the meeting so that there is no ambiguity.
https://github.com/mlperf/training_policies/blob/master/training_rules.adoc#3-benchmarks

This document is also now very out of date and we should fix it.
https://github.com/mlperf/training_policies/blob/master/training_summary.adoc

SWG:
The table has to be updated to list default models.


What is the reason being train dataset length hardcoded to 1000?

Thanks for the great work!
I don't understand why this line is hardcoded to 1000
https://github.com/kwea123/ngp_pl/blob/2865dbbae14b2313654a8da383dd641e4e825642/datasets/base.py#L19
For the original NeRF blender synthetic dataset, the num of training images is 100, but I saw tqdm going to 1000. Debugging through the code to find the reason, I saw this was hardcoded to 1000 in the base class of the dataset.
So in some sense, for nerf synthetic, are we doing 200 epochs in the benchmark script as compared to 20?
I noticed this when I saw the time taken for 1 epoch is quite large as compared to https://github.com/ashawkey/torch-ngp. Setting that line to 100 makes the epoch speed comparable.
I suppose we should be inferring the dataset length instead of setting to 100/1000 ofc

Here are some runs:

Y axis is num of epochs, X-axis
Higher slopes are with fixed dataset length to 100, lower slope cluster corresponds to current main branch (1000)

Y axis is time taken per epoch, X-axis is num_of_epochs

The slower cluster (higher on Y axis) is with 1000
the faster cluster is with 100

Train PSNR
"shorter" curve length correponds to 100

Loss curves
trimmed this one

Also, I notice not much change in time wrt 8192 and 16384 rays per batch on V100 wrt time, I guess gpu was being underused

I don't understand why it's set to 1000

This is by experiments, I find that this number allows the to reach comparable results within comparable training time, so I chose this value.

I saw the time taken for 1 epoch is quite large compared to torch-ngp
I don't remember what is the data size for it, but I remember it takes 10x epoch time to reach the same quality, so it's data size should be around 100, therefore setting that line to 100 makes the epoch speed comparable.

I suppose we should be inferring the dataset length instead of setting to 100/1000 ofc

The total iterations is epochxdata size, so in my experiment it corresponds to 20k iterations by default, you can balance epoch data size whatever you want, it doesn't matter at all, you can even train with 1 epoch with data size = 20000, initially I wanted to monitor the training progress (ie val psnr) more so I set more epochs.

got it, thanks!


Add glyph x/y offset command tags

This was used in SKPD, but I don't think it has wide-ranging utility.


Callback to handle HPP response + HPP_VERSION 2

I have a need for a more bespoke solution for hosted payments than your SDK currently provides.
This PR adds the following features by adding an addition function, setup() (naming isn't one of my strengths :smile:)

Accepts a callback

Allows custom submission of HPP response to merchant server (e.g. using XHR, setting headers, or combining it with other data)
Allows the JS code to know something of what happened (e.g. HPP response received, or user closed lightbox without paying) and act accordingly

Doesn't automatically add event listener

Offers more flexibility, and works better where the DOM is dynamic, or when using frameworks such as React

Adds cleanup function to remove message listener, so rxp-js can be used multiple times in an app lifecycle without leaking

In doing this, I've done some small refactoring, to allow me to reuse functions, and also added UMD, so it can be more easily used with build tools such as webpack & browserify.
I was going to add unit tests for rx-hpp.js, but I found this very difficult to test because of the tight-coupling with the DOM, and the fact that the RxpLightbox is private, and therefore impossible to mock.

Shame this isn't merged I really wanna use this.


VM tags bug on multiple change

There are Steps to reproduce:

Go to VM's details, Tags tab
Try to change the value of any Tag twice.

Expected result: The value was changed twice
Actual result: The value was changed once. On second time error occurs ""Unable to find resource by uuid undefined and type UserVm".
There should be added an error catch for deleting tag too. So if it cannot be deleted, it should not start to create the updated tag.
Connected feature ID:

vm_tag_edit
vm_tag_delete

To test:

vm_tag_edit

Regressions:

vm_tag_create
vm_tag_delete

Test on qqcky/825-change-tag-bug

Tested on qqcky/825-change-tag-bug


Ensure elements in list are ordered so that test is stable

Merging as @systay and I paired on this

This could've been a great use case for the unordered matching of lists :)

@petraselmer When using ORDER BY, we should use the step Then the results should be, in order.


Performance improvement

Hi.
Some time is spent to perform the test:
    if any(data[:, 0] != np.sort(data[:, 0])):
        raise ValueError('data should be sorted on first column')

i think you could replace this by:
    if np.any(np.diff(data[:, 0])<=0):
        raise ValueError('data should be sorted on first column')

that allows to speedup this test by a factor 2

More efficient (again):
    if np.any(data[1:, 0]<=data[1:, 0]):
        raise ValueError('data should be sorted on first column')

Thanks for the suggestions, @guilllaumeB. That is a much better way of doing the check :)
I've implemented these in v. 0.2.0, and added you to the contributor list in the Readme.

Shouldn't the check be np.any(data[1:, 0]<data[:-1, 0])? I'm getting the ValueError raise being that two values in a sorted array are equal.

@ardzoht
To my mind, a time series implies that abscissas are strictly growing. Then a vector with equal values is not a valid abscissas vector.
But maybe I'm wrong, time series are not my field of expertise, I used to work with analog signals, that implies strictly growing abscissas


Bamtools unable to write into split files

I am trying to split a large BAM file into smaller bam files by tags that contain a cellular barcode. Bamtools is able to generate the files, but is unable to write the sequences into them.
I used the following command:
bamtools split -tag CB -in possorted_genome_bam_1.bam
It generated a bunch of empty bam files. This is an example of the filename it outputted:
possorted_genome_bam_1.TAG_CB_TTTGACTGCCCTCA-1.bam
It returned the following error message:
bamtool split ERROR: could not open possorted_merged_H32MNBGXY.TAG_CB_ACGATGACGATACC-1.bam for writing.
Is it possibly having trouble due to the characters in its file string? Thanks

I am having exactly the same issue...following

I'm also having exactly the same issue. Did you find a solution?
I found a really dumb way to do the same thing converting to sam files and using grep, but it surely takes much longer.
Any suggestion?
Thanks in advance

Having the same issue.

I still haven't figured out a solution, but I believe I have found a possible cause - it may be linked to the headers of the BAM files. I mainly have the issue with BAM files generated by 10x's Cell Ranger pipeline. I was able to split bam files from other sources.

I'm using dropseq data from the McCarroll pipeline and getting the same problem.
Haven't been able to figure out why either :(

I was having this issue too (on 10X single cell data). I think that the issue is bamtools exceeding the limit on the number of open files (check 'ulimit -n'). Even if the expected number of cells is smaller than the file limit, the number of files created may be much larger due to sequencing errors creating many extra cellular barcodes.

I am having this issue on 10x single cell data too. Do you know how to split the bam file from other sources?

@asenabouth I have the same issue with you. Could you share the sources which you used to split the bam file?  Thanks a lot!

To write a valid BAM file, bamtools opens a file for each barcode, writes the header, and then starts adding the reads that match the barcode.
The problem is that keeping a file open costs resources, so the operating systems limits the amount of files that can be open at the same time.
As the BAM file with 10X data can easily hold a million different barcodes, the above method fails fast.
Fixing this isn't easy, as for other users, the current way might work, and other ways to do this are probably a lot slower.
As a workaround, I have written a very small python script, which will split the single BAM file into ~1M separate files, one for each barcode.
As the filesystem doesn't like 1M files in a single folder, it creates subfolders :
import os
import fileinput
for line in fileinput.input():
    line=line.strip()
    tags = line.split()[11:]
    for tag in tags:
        tag_split=tag.split(':')
        if 'BX' in tag_split:
            barcode=tag_split[-1]
            directory = barcode[:5]
            outfile = directory+"/"+barcode
            try:
                f=open(outfile,"a+")
                print(line, file=f)
                f.close()
            except:
                os.mkdir(directory)
                f=open(outfile,"a+")
                print(line, file=f)
                f.close()

Usage :
samtools view BAM-file | python split_script.py
(this will take a while)
After that the header needs to be added to each file to be able to use it.

Hi @jvhaarst - nice work around, will give that a try when I have a chance.

Out of curiosity, instead of holding the files open for writing, could they be opened for appending only when they need to be written to, perhaps with a "connection pool" of sorts which only holds on to, say, the getrlimit(RLIMIT_NOFILE)/2 most recently accessed files? This would allow bamtools to still be much more efficient while not exceeding the system resource limits.

Relatively quick option for spitting barcodes with <<1M unique barcodes. Script will split on any unique CB entry, but has only been tested with .bam files sorted with samtools on tag CB. Should work on unsorted as well, but will likely a take a lot longer due to opening and closing of files.... To sort on CB tag:
samtools sort -t CB unsorted.bam > sorted_tags.bam
Script runs uses pysam to read bam file without need for conversion, details for conda install of pysam can be found here.
##### Code has not been tested on unsorted bam files, sort on barcode (CB):
##### samtools sort -t CB unsorted.bam > sorted_tags.bam
###
##### INPUT: .bam file to be sorted and output directory to place split BC
##### OUTPUT: .bam file for each unique barcode, best to make a new directory

### Python 3.6.8
import pysam

### Input varibles to set
# file to split on
unsplit_file = "/path/to/dir/of/data/sorted_tags.bam"
# where to place output files
out_dir = "/path/to/dir/of/out_data/"

# variable to hold barcode index
CB_hold = 'unset'
itr = 0
# read in upsplit file and loop reads by line
samfile = pysam.AlignmentFile( unsplit_file, "rb")
for read in samfile.fetch( until_eof=True):
    # barcode itr for current read
    CB_itr = read.get_tag( 'CB')
    # if change in barcode or first line; open new file
    if( CB_itr!=CB_hold or itr==0):
        # close previous split file, only if not first read in file
        if( itr!=0):
            split_file.close()
        CB_hold = CB_itr
        itr+=1
        split_file = pysam.AlignmentFile( out_dir + "CB_{}.bam".format( itr), "wb", template=samfile)

    # write read with same barcode to file
    split_file.write( read)
split_file.close()
samfile.close()

After downloading script and changing name to split_script.py, change input file and output directory in script to desired locations and run:
python split_script.py
or if still using python2
python3 split_script.py
Runtime was about ~35sec for a test run ~1 million reads and ~5k unique barcodes.

Relatively quick option for spitting barcodes with <<1M unique barcodes. Script will split on any unique CB entry, but has only been tested with .bam files sorted with samtools on tag CB. To sort on CB tag:
samtools sort -t CB unsorted.bam > sorted_tags.bam
Script uses pysam to read bam file without need for conversion, details for conda install of pysam can be found here.
##### Code has not been tested on unsorted bam files, sort on barcode (CB):
##### samtools sort -t CB unsorted.bam > sorted_tags.bam

Dear @herrinca, thank you for proposing this solution! While your Python-code is correct, I've found out that samtools sort -t CB removes CB tag from file: CB_itr = read.get_tag( 'CB') line throws an error. This is very strange. Are you sure that this is the only command one needs to run to form the correct input of your script? I've tried to re-header the sorted file using the head from original BAM but with no success. I have samtools v. 1.9 and BAM files formed by CellRanger, a tool from 10x Genomics. CB tag is present in that BAM file

is is very strange. Are you sure that this is the only command one needs to run to form the correct input for your script? I've tried to re-header the sorted file using the header from original BAM but with no success. I have samtools v. 1.9 and BAM files formed by CellRanger, a tool f

Hi, @ivanov-v-v
I have the same problem, did you find out how to make it work?
Thanks

Hi, about "samtools sort -t CB unsorted.bam > sorted_tags.bam"
I have the same problem, did you find out how to make it?
Thanks


#20073 Add support of different identifier quotes to the grammar

Square brackets in identifiers are in MS SQL Server

Back quotes can be tested in Clickhouse or MariaDB

Double quotes are in PostgreSQL

Please, note, that if alias contains only 1 letter, in most cases no proposal appear as it's supposed that you've already wrote full alias. It's an old behavior.

I haven't found database with single quotes in identifiers, so I removed support of single quotes in identifier names.

verified


Support for programmatically adding the SwiftSiriWaveformView

Not everyone uses exclusively Storyboards, it'd be nice if there was a support to instantiate simply like this:
let bounds = CGRect(x: 0, y: 0, width: UIScreen.main.bounds.width, height: 60)
let siriWaveFormView: SwiftSiriWaveformView = SwiftSiriWaveformView(frame: bounds)

It seems you haven't created the default init().

I see that even if the noise changes in the background the wave never changes


Clients not appearing

Hello, I Used the builder and sent the client executable to my friends however when they open it i get nothing appearing on the connections list, my friends have confirmed that they have opened it but i get no connection

did u use dns ? if not are u sure u are listening and you have foward good ports ? Anti Virus ? you see him launch or he just say it to you ?

When building and executing the client please make sure you have done the following

Have properly configured the client to listen to your local IP either through DNS or Pastebin
You must port forward the ports you selected on your mode
Make sure the Clients antivirus is disabled, it could be interfering with it

There are many tutorials online (or example, youtube) of how to do this, please check online if you need help setting up a client with the correct settings

I already done all that, I have moved onto a new rat called quasar now


Add suport for parsing comments inside of function bodies

Problem
Hello all!
As it currently stands, comments inside of a function body are not parsed by swag. As an example, given an anonymous handler inside of a function with a comment and another handler outside, also with a comment:
package main

// @Router /api/outside [get]
func outside() {}

func main(){
    // @Router /api/inside [get]
    _ = func() {}
}

// @Router /api/inside [get] will not be parsed while // @Router /api/outside [get] will get parsed. This behavior means that the use of anonymous function handlers is not possible if you also want to use swag.
Solution
I would like to add support for parsing comments inside of function bodies. This could be achieved by adding an optional boolean flag to control parsing all comments as opposed to only doc comments as it is today. The ast.File object that is currently used for parsing doc comments already contains all comments from a given source file. As such, adding this feature would require only minimal changes to the package. Additionally, by adding a flag to control this behavior, it would be opt-in only and would not disrupt users who are expecting the current behavior.

I have created a PR here for this suggested feature: https://github.com/swaggo/swag/pull/1824.


UPS ImportControl support

To import a package to your own country you have to use ImportControl with UPS.
When using the ImportControl option, you will also have to add a package description which used for returns so I used it to support ImportControl also.

http://idaho-dental-studio.com/wp-content/uploads/2012/11/Shipping-Package-XML-Developers-Guide.pdf
Check this and let me know if you have any further comments.

I asked a number of questions already. And I'm not searching a 260 page document to get the answer to my question. Please provide the supporting details to explain your changes.

Ooops, I merged also another change that I work for fedex. can you reset the fedex.rb file from the pull request? or please tell how can I do it my self?
Anyway, I made the changes.
And regarding the info,
in order to import international package with UPS u will need to add support in request...
According to UPS (page 126 in the file I sent)
ImportControlIndicator: Indicates that the Shipment is an ImportControl shipment.
LabelMethod:  Type of ImportControl Label
Code: LabelMethod types:'01' =
ImportControl Print and
Mail'02' = ImportControl
One-Attempt'03' =
ImportControl ThreeAttempt'04'
= ImportControl
Electronic Label'05' =
ImportControl Print Label
Description: Label Method description
Regarding the removal of the [:return] condition, ImportLabel requires package description too.
I think that if you have a package description it can do no harm, so remove this condition. please correct me if I got it wrong.

can you reset the fedex.rb file from the pull request? or please tell how can I do it my self?

I'm sorry, I don't know what this means.

Also, the file you linked is four years old, and is not coming from UPS.

Closing due to inactivity & state of PR.


build with images hangs

Running python generator.py build --images goes through the process of building the HTML pages with images, but then the build process hangs (right after processing the bitwise and example). This happens on OSX with a fresh install of the repository; you can see it happening in Linux here (this is testing a branch that I'm working on in my own fork of the repo, but the problem here is identical to what I'm seeing on OSX).

possibly related: http://bugs.python.org/issue2475


[DO NOT MERGE] Test Only

@zhijie-zh : if it's test only and do not merge, then why it has verifying label?


Style all components

Styled all components - currently rendering directly out of App as router is not set up correctly.

https://media1.tenor.com/images/a072136812e618940db133136ee9e1ef/tenor.gif?itemid=5380173


Laravel 10.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 10.x.
Before merging, you need to:

Checkout the l10-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/Centaur.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "srlabs/centaur": "dev-l10-compatibility",
    }
}

Finally, run: composer update

Thank you for setting up this pull request.  We won't be able to introduce Laravel 10 compatibility to this package until the underlying cartalyst/sentinel package supports it.


set value without triggering any event

I have some problem, i wanna set value without triggering any event.
this because i wanna make input decimal, which can use . or , key
when , key pressed i modify element value directly with adding . char
that already work but problem when i press on end input, it cant modify input because triggering masking function.
ex.
12(cursor here)3 then i press , key, it success change value to 12.3
but if
123(cursor here) then i press , key, it supposed change to 123, but it not work
so i wanna know if there any solution for changing value without triggering masking event

@avalon1412 ,
With version 5.0.7 the decimal substitues , and . already out-of-the-box.


documentation for get_diagnostics()

This is for #258 and #637
Contributor Checklist:

[ ] I have added myself to the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases

Is there anything that needs to be added to the already existing documentation for get_diagnostics or is it enough?

Is there anything that needs to be added to the already existing documentation for get_diagnostics or is it enough?

The documentation for the base class is enough IMO. You could document what information the get_diagnostics() methods in each subclass return.
Are the changes in win_tweaks.py intentionally in this PR or just included by accident?

The documentation for the base class is enough IMO. You could document what information the get_diagnostics() methods in each subclass return.

Ok, will include them too.

Are the changes in win_tweaks.py intentionally in this PR or just included by accident?

Intentional. Also, intend to include tests for examples notebooks (#595) and profiling techniques (#589) in this too. I will change the name of the PR to something more general once I figure it out.

Intentional. Also, intend to include tests for examples notebooks (#595) and profiling techniques (#589) in this too. I will change the name of the PR to something more general once I figure it out.

Keeping unrelated changes in separate pull requests works better. That way they can be reviewed and merged separately. You can keep them in separate branches. In my workflow I keep the master branch of my fork in sync with the upstream master and make all my modifications in branches. That makes it easy to always create new branches starting from the current upstream master, and rebase branches on the current master when necessary.
What about first finishing with #258 before tacking more issues? Did you reproduce the error described in the issue and confirm that your change fixes it? On my system it still happens with Git for Windows Bash when I run your version.

What about first finishing with #258 before tackling more issues?

Okay, will do that

Did you reproduce the error described in the issue and confirm that your change fixes it?

No, I haven't. I had no idea that it could be done that way. How do you do it?

How do you do it?

With Git for Windows Bash instead of cmd.exe, for example. 🤷

With Git for Windows Bash instead of cmd.exe, for example. 🤷

Yeah, but that runs the master branch. How do I run my version which has all the commits that I have made?

How do I run my version which has all the commits that I have made?

Please see the installation documentation - adjust the steps accordingly, if you already have a clone of your fork on your computer. Let me know if this works for you.

Made a few mistakes, cannot even delete the previous commits. Closing this. Will open a new PR.


feat(main.rs): append/use plugin name rather than package filename

This allows for an arbitrary package/executable name but ensures the plugin is invoked by its assigned name via spin.
This won't change the behavior when the plugin name and package filename are the same, which might usually be the case, but supports use cases where the filename may differ per the plugin developer's use case.  For example a foo plugin whose package filename is foo-plugin:
name = "foo"
version = "0.1"
spin_compatibility = ">=0.7"
license = "Apache-2.0"
package = "./target/release/foo-plugin"

Regardless of the package filename, the plugin will be invoked via its given name, here "foo", eg spin foo bar.

Thanks @itowlson; updated.  Also open to var name alternatives if os_specific_name is too wordy or otherwise insufficient.

Sorry @vdice, I wasn't clear - the worry is not about using an OS string - it is that on Windows, the name needs to have a .exe suffix.  We mangle the source executable path at https://github.com/itowlson/spin-pluginify/blob/466d7e889a4828421ef12352ce455465933d39f0/src/main.rs#L257 - but with your change we no longer mangle the tarred executable name.  Hope that makes more sense now.

I see now (I hope), thank you.  Added a bit of code though eager for pointers on simplifying or a better way to do the job.


CLM massive lags for the whole raid

Describe the bug
A clear and concise description of what the bug is.
Whenever someone enters the raid or leaves or loot is rolled out for bidding or loot is awarded or DKP is giving out the whole raid /guild everyone who is on roster has a 5 - 10 second lags.

AddOn and Game Version:

v5.0.1

Dear Sirs,
please debugg the lags a raid with CLM in wow classic is not possible anymore the lags are too heavy

and I got kicked and discord lol holyshit haha what bad thing did I do cant even check where I can pay well that makes it easy xD

So to summarize:

You don't have to pay
But you also can't demand stuff from open source maintainer.
The tone you use in your message is definitely not a friendly help request, if that's what you think is friendly ask your parents for some more parenting.

Have fun switching to another add-on, I'm sure that community is happy to have another spoiled little child join them.


Implement Client::GetNotification().

This fixes #1034. It implements the API, the usual unit tests, extends
the integration test to call the API, adds a sample, and runs the sample
as part of the CI build.

This change is

PTAL.

@houglum PTAL.


Mined Transaction Details in Dogecoin-QT is wrong

When I have a mined transaction I see the following description:
Generated coins must mature 50 blocks before they can be spent. When you generated this block, it was broadcast to the network to be added to the block chain. If it fails to get into the chain, its state will change to "not accepted" and it won't be spendable. This may occasionally happen if another node generates a block within a few seconds of yours.

That is fixed in 1.10 now as it uses the same constant to calculate.


Graves are causing me to crash

Describe the bug
When I died my game crashed, so I re-spawned and went back to the grave and crashed again. Only other players (on LAN) can go near the graves but I can't (it happens on single player and LAN worlds)
To Reproduce
Steps to reproduce the behavior:

Go to 'The chunk with the grave'
I crashed, don't know if this happens with anyone else

Desktop (please complete the following information):

OS: MacOS
Minecraft Version: 1.18.1
Version: 1.2.22

I would imagine this is connected to the grave that should display a glowing-like effect (which is possible to disable for a temporary fix). Do you have any logs to provide?

I you mean the crash report this is one of them:
---- Minecraft Crash Report ----
// I just don't know what went wrong :(
Time: 02/04/2022, 17:37
Description: Rendering Block Entity
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_276.method_1235(boolean)" because the return value of "net.minecraft.class_761.method_22990()" is null
at net.minecraft.class_4668.method_34556(class_4668.java:477)
at net.minecraft.class_4668.method_23516(class_4668.java:36)
at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:422)
at net.minecraft.class_1921$class_4687.method_23595(class_1921.java:929)
at net.minecraft.class_4668.method_23516(class_4668.java:36)
at net.minecraft.class_1921.method_23012(class_1921.java:727)
at net.minecraft.class_4597$class_4598.method_22994(class_4597.java:96)
at net.minecraft.class_4597$class_4598.getBuffer(class_4597.java:45)
at net.minecraft.class_327$class_5232.accept(class_327.java:283)
at net.minecraft.class_5223.method_27477(class_5223.java:17)
at net.minecraft.class_5223.method_27473(class_5223.java:120)
at net.minecraft.class_5223.method_27472(class_5223.java:84)
at net.minecraft.class_5223.method_27479(class_5223.java:80)
at net.minecraft.class_327.method_1724(class_327.java:344)
at net.minecraft.class_327.method_27529(class_327.java:181)
at net.minecraft.class_327.method_27522(class_327.java:124)
at net.minecraft.class_327.method_27521(class_327.java:120)
at com.b1n_ry.yigd.client.render.GraveBlockEntityRenderer.render(GraveBlockEntityRenderer.java:280)
at com.b1n_ry.yigd.client.render.GraveBlockEntityRenderer.method_3569(GraveBlockEntityRenderer.java:41)
at net.minecraft.class_824.method_23079(class_824.java:84)
at net.minecraft.class_824.method_23081(class_824.java:73)
at net.minecraft.class_824.method_3554(class_824.java:98)
at net.minecraft.class_824.method_3555(class_824.java:73)
at net.minecraft.class_761.method_22710(class_761.java:1368)
at net.minecraft.class_757.method_3188(class_757.java:1031)
at net.minecraft.class_757.method_3192(class_757.java:811)
at net.minecraft.class_310.method_1523(class_310.java:1117)
at net.minecraft.class_310.method_1514(class_310.java:733)
at net.minecraft.client.main.Main.main(Main.java:238)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.class_4668.method_34556(class_4668.java:477)
at net.minecraft.class_4668.method_23516(class_4668.java:36)
at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:422)
at net.minecraft.class_1921$class_4687.method_23595(class_1921.java:929)
at net.minecraft.class_4668.method_23516(class_4668.java:36)
at net.minecraft.class_1921.method_23012(class_1921.java:727)
at net.minecraft.class_4597$class_4598.method_22994(class_4597.java:96)
at net.minecraft.class_4597$class_4598.getBuffer(class_4597.java:45)
at net.minecraft.class_327$class_5232.accept(class_327.java:283)
at net.minecraft.class_5223.method_27477(class_5223.java:17)
at net.minecraft.class_5223.method_27473(class_5223.java:120)
at net.minecraft.class_5223.method_27472(class_5223.java:84)
at net.minecraft.class_5223.method_27479(class_5223.java:80)
at net.minecraft.class_327.method_1724(class_327.java:344)
at net.minecraft.class_327.method_27529(class_327.java:181)
at net.minecraft.class_327.method_27522(class_327.java:124)
at net.minecraft.class_327.method_27521(class_327.java:120)
at com.b1n_ry.yigd.client.render.GraveBlockEntityRenderer.render(GraveBlockEntityRenderer.java:280)
at com.b1n_ry.yigd.client.render.GraveBlockEntityRenderer.method_3569(GraveBlockEntityRenderer.java:41)
at net.minecraft.class_824.method_23079(class_824.java:84)
at net.minecraft.class_824.method_23081(class_824.java:73)
at net.minecraft.class_824.method_3554(class_824.java:98)
at net.minecraft.class_824.method_3555(class_824.java:73)
at net.minecraft.class_761.method_22710(class_761.java:1368)
at net.minecraft.class_757.method_3188(class_757.java:1031)
-- Block Entity Details --
Details:
Name: yigd:grave_block_entity // com.b1n_ry.yigd.block.entity.GraveBlockEntity
Block: Block{yigd:grave}[facing=east,waterlogged=false]
Block location: World: (224,63,-72), Section: (at 0,15,8 in 14,3,-5; chunk contains blocks 224,0,-80 to 239,255,-65), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,0,-512 to 511,255,-1)
Block: Block{yigd:grave}[facing=east,waterlogged=false]
Block location: World: (224,63,-72), Section: (at 0,15,8 in 14,3,-5; chunk contains blocks 224,0,-80 to 239,255,-65), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,0,-512 to 511,255,-1)
Stacktrace:
at net.minecraft.class_824.method_3554(class_824.java:98)
at net.minecraft.class_824.method_3555(class_824.java:73)
at net.minecraft.class_761.method_22710(class_761.java:1368)
at net.minecraft.class_757.method_3188(class_757.java:1031)
at net.minecraft.class_757.method_3192(class_757.java:811)
at net.minecraft.class_310.method_1523(class_310.java:1117)
at net.minecraft.class_310.method_1514(class_310.java:733)
at net.minecraft.client.main.Main.main(Main.java:238)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
-- Affected level --
Details:
All players: 1 total; [class_746['Lunar_Wolf_07'/146, l='ClientLevel', x=220.81, y=71.80, z=-67.80]]
Chunk stats: 625, 370
Level dimension: minecraft:the_nether
Level spawn location: World: (-252,64,1865), Section: (at 4,0,9 in -16,4,116; chunk contains blocks -256,0,1856 to -241,255,1871), Region: (-1,3; contains chunks -32,96 to -1,127, blocks -512,0,1536 to -1,255,2047)
Level time: 736915 game time, 769953 day time
Server brand: fabric
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.class_638.method_8538(class_638.java:408)
at net.minecraft.class_310.method_1587(class_310.java:2402)
at net.minecraft.class_310.method_1514(class_310.java:752)
at net.minecraft.client.main.Main.main(Main.java:238)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:416)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
-- Last reload --
Details:
Reload number: 1
Reload reason: initial
Finished: Yes
-- System Details --
Details:
Minecraft Version: 1.18.1
Minecraft Version ID: 1.18.1
Operating System: Mac OS X (x86_64) version 10.14.6
Java Version: 17.0.1, Microsoft
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft
Memory: 687537392 bytes (655 MiB) /<PHONE_NUMBER> bytes (2048 MiB) up to<PHONE_NUMBER> bytes (2048 MiB)
CPUs: 4
Processor Vendor: GenuineIntel
Processor Name: Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
Identifier: Intel64 Family 6 Model 142 Stepping 9
Microarchitecture: Amber Lake
Frequency (GHz): 1.60
Number of physical packages: 1
Number of physical CPUs: 2
Number of logical CPUs: 4
Graphics card #0 name: Intel UHD Graphics 617
Graphics card #0 vendor: Intel
Graphics card #0 VRAM (MB): 1536.00
Graphics card #0 deviceId: 0x87c0
Graphics card #0 versionInfo: Revision ID: 0x0002
Memory slot #0 capacity (MB): 4096.00
Memory slot #0 clockSpeed (GHz): 2.13
Memory slot #0 type: LPDDR3
Memory slot #1 capacity (MB): 4096.00
Memory slot #1 clockSpeed (GHz): 2.13
Memory slot #1 type: LPDDR3
Virtual memory max (MB): 13312.00
Virtual memory used (MB): 9913.19
Swap memory total (MB): 5120.00
Swap memory used (MB): 3918.50
JVM Flags: 8 total; -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
Fabric Mods:
apoli: Apoli 2.2.2
architectury: Architectury 3.7.37
bclib: BCLib 1.3.5
betternether: Better Nether 6.0.11
botania: Botania 1.18.1-429-FABRIC
calio: Calio 1.4.2
cardinal-components-base: Cardinal Components API (base) 4.0.0
cardinal-components-entity: Cardinal Components API (entities) 4.0.0
chipped: Chipped 1.2
cloth-basic-math: cloth-basic-math 0.6.0
cloth-config: Cloth Config v6 6.2.51
dawn: Dawn API 3.2.0
enva: Environmental Armor 1.4.3
extrakeybinds: ThatRobins Extra Origins Keybinds 1.18-0.1.0
extraorigins: Extra Origins 1.18-9
fabric: Fabric API 0.46.6+1.18
fabric-api-base: Fabric API Base 0.4.2+d7c144a865
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.5.3+d7c144a865
fabric-biome-api-v1: Fabric Biome API (v1) 6.0.2+d7c144a865
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.10+3ac43d9565
fabric-command-api-v1: Fabric Command API (v1) 1.1.7+d7c144a865
fabric-commands-v0: Fabric Commands (v0) 0.2.6+b4f4f6cd65
fabric-containers-v0: Fabric Containers (v0) 0.1.19+d7c144a865
fabric-content-registries-v0: Fabric Content Registries (v0) 0.4.9+d7c144a865
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.9+3ac43d9565
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.10+a1d9bbf565
fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.6+d7c144a865
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.17+d7c144a865
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.9+d7c144a865
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.11+d7c144a865
fabric-item-api-v1: Fabric Item API (v1) 1.3.1+691a79b565
fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.7+3ac43d9565
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.9+d7c144a865
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.7+b4f4f6cd65
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 1.4.13+713c266865
fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.9+d7c144a865
fabric-mining-level-api-v1: Fabric Mining Level API (v1) 1.0.7+d7c144a865
fabric-mining-levels-v0: Fabric Mining Levels (v0) 0.1.12+b4f4f6cd65
fabric-models-v0: Fabric Models (v0) 0.3.4+d7c144a865
fabric-networking-api-v1: Fabric Networking API (v1) 1.0.19+d7c144a865
fabric-networking-v0: Fabric Networking (v0) 0.3.6+b4f4f6cd65
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 1.11.5+737332ce65
fabric-object-builders-v0: Fabric Object Builders (v0) 0.7.13+d7c144a865
fabric-particles-v1: Fabric Particles (v1) 0.2.10+526dc1ac65
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.9.2+ad01bfbd65
fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.11+b0b66fc365
fabric-renderer-indigo: Fabric Renderer - Indigo 0.4.15+6825030165
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.10+b4f4f6cd65
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.5+d7c144a865
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 0.1.19+3ac43d9565
fabric-rendering-v0: Fabric Rendering (v0) 1.1.12+b4f4f6cd65
fabric-rendering-v1: Fabric Rendering (v1) 1.10.6+713c266865
fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 1.0.2+d7c144a865
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.15+8906aafd65
fabric-screen-api-v1: Fabric Screen API (v1) 1.0.8+d7c144a865
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.1.12+d7c144a865
fabric-structure-api-v1: Fabric Structure API (v1) 2.1.3+d7c144a865
fabric-tag-extensions-v0: Fabric Tag Extensions (v0) 1.2.9+d7c144a865
fabric-textures-v0: Fabric Textures (v0) 1.0.10+3ac43d9565
fabric-tool-attribute-api-v1: Fabric Tool Attribute API (v1) 1.3.9+fb3b57b465
fabric-transfer-api-v1: Fabric Transfer API (v1) 1.5.10+c329913d65
fabricloader: Fabric Loader 0.13.3
fallingtree: FallingTree 3.2.1
fiber: fiber 0.23.0-2
java: OpenJDK 64-Bit Server VM 17
kanos_config: Kanos Config 0.1.4+1.14.4-1.17.1
libcd: LibCapableData 3.0.3+1.16.3
minecraft: Minecraft 1.18.1
more_gems: More Gems <IP_ADDRESS>
morethanapickaxe: MoreThanAPickaxe 0.1.6b
mushroomorigins: Mushroom Origins 1.2
naturescompass: Nature's Compass 1.18.1-2.0.3-fabric
origins: Origins 1.3.1
patchouli: Patchouli 1.18.1-65-FABRIC
pehkui: Pehkui 3.1.0+1.14.4-1.18.1
playerabilitylib: Pal 1.3.0
promenade: Promenade 2.5.1
pugh_tools: Pugh Tools 1.1.18
reach-entity-attributes: Reach Entity Attributes 2.1.1
roughlyenoughitems: Roughly Enough Items 7.3.443
seedfix: Seed Fix 1.0.0
step-height-entity-attribute: Step Height Entity Attribute 1.0.0
survivalplus: SurvivalPlus 0.1.6b
terraform-shapes-api-v1: Terraform Shapes API (v1) 2.1.0
terralith: Terralith for Fabric 2.0.12
trinkets: Trinkets 3.2.0
yigd: You're in Grave Danger 1.2.22
Launched Version: fabric-loader-0.13.3-1.18.1
Backend library: LWJGL version 3.2.1 build 12
Backend API: Intel(R) UHD Graphics 617 GL version 4.1 INTEL-12.10.12, Intel Inc.
Window size: 1708x960
GL Caps: Using framebuffer using OpenGL 3.2
GL debug messages:
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
Type: Integrated Server (map_client.txt)
Graphics mode: fast
Resource Packs: vanilla, Fabric Mods, file/Invisible Item Frame Pack(1.16) (incompatible), file/Silverwood Acacia v1.1 (incompatible), file/VanillaTweaks_r992490 (incompatible), file/VanillaTweaks_r234141 (incompatible), file/VanillaTweaks_r245566 (incompatible), file/VanillaTweaks_r394169 (incompatible), file/VanillaTweaks_r468418 (incompatible), file/VanillaTweaks_r557643 (incompatible), file/VanillaTweaks_r810855 (incompatible), file/VanillaTweaks_r855377 (incompatible), file/VanillaTweaks_r965264 (incompatible), file/MoreVariations - Lilypads (incompatible), file/Bees bee wings (incompatible), file/Philza-pack (incompatible), file/Dark+Modern+GUIs+32x+-+1 (incompatible)
Current Language: English (US)
CPU: 4x Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
Server Running: true
Player Count: 1 / 8; [class_3222['Lunar_Wolf_07'/146, l='ServerLevel[World 23]', x=220.81, y=71.80, z=-67.80]]
Data Packs: vanilla, Fabric Mods

I have to agree where the crash report says "I just don't know what went wrong". I'm pretty sure that the error is triggered by a value being "null" after it's made sure it's not "null".
Is this happening in singleplayer as well? I can't seem to replicate this, not do I understand why it happens. If you are using a publicly available modpack that could also be useful to know incase there is a incompatible mod

I has happened on a singleplayer world and that same world when it was open to LAN (other players on the LAN server weren’t affected and could interact with graves without any issues)
These are the mods that I was using;
Better Nether
Your In Grave Danger
Botania
Chipped
Environmental Armor
extra key binds
extra origins
Falling Tree
More Gems
More Than A Pickaxe
Mushroom Origins
Natures Compass
Origins
Promenade
Roughly Enough Items
Terralith
APIs;
Archtectury
Bclib
cloth config
dawn
Patchouli
Pehkui
Survival Plus
Trinkets
Version info
architectury: Architectury 3.7.37
bclib: BCLib 1.3.5
betternether: Better Nether 6.0.11
botania: Botania 1.18.1-429-FABRIC
chipped: Chipped 1.2
cloth-config: Cloth Config v6 6.2.51
dawn: Dawn API 3.2.0
enva: Environmental Armor 1.4.3
extrakeybinds: ThatRobins Extra Origins Keybinds 1.18-0.1.0
extraorigins: Extra Origins 1.18-9
fabric: Fabric API 0.46.6+1.18
more_gems: More Gems <IP_ADDRESS>
morethanapickaxe: MoreThanAPickaxe 0.1.6b
mushroomorigins: Mushroom Origins 1.2
naturescompass: Nature's Compass 1.18.1-2.0.3-fabric
origins: Origins 1.3.1
patchouli: Patchouli 1.18.1-65-FABRIC
pehkui: Pehkui 3.1.0+1.14.4-1.18.1
promenade: Promenade 2.5.1
roughlyenoughitems: Roughly Enough Items 7.3.443
survivalplus: SurvivalPlus 0.1.6b
terralith: Terralith for Fabric 2.0.12
trinkets: Trinkets 3.2.0
yigd: You're in Grave Danger 1.2.22

Some extra info- I added the yigd mod after I’d made the world, I don’t know if this would be a contributing factor or not, I was also carrying three bundles in my inventory when I died and since bundles are not enabled in-game by default (I used the /give command to obtain them) I was woundering if that would have any affect on or contribute to the issue.

Ok I have really tried my best to test this after your instructions, but it will not crash like it has for you. When it comes to the bundles, the bundles, they definetely don't have anything to do with this issue as it's just the grave rendering that is crashing.
Best I can do is unfortunately to ask you to perhaps reinstall the mod. Something might've gone wrong in that process. Keep in mind that if you log in on the world whithout the grave mod all graves will disappear. That part will probably not be necessary though.
If you try to reinstall the mod and it's still crashing, go to the config file, find glowingGrave and set that to false. It would be kind of you to update me if the reinstall works or not

Alright Thank you for the advice, I will re-install the mod tomorrow as I don’t have time now and I’ll keep you updated on it.

I re-installed the mod but it still crashed when I entered the chunk with the grave, so I found the config file and set 'glowingGrave' to 'false' and I no longer crash and I can interact with my grave to retrieve my items. Thank you for fixing the issue :)

Well the issue probably lies in that you are using a mac then, as I am using windows. This partially means I can't know if I've fixed this error or not but I hope that it will be playable with this config enabled in the next update of the mod.
For now I'll leave the issue open, since this update is not out yet.
Thank you for reporting this! When I update the mod I'll try to remember to tell you in here

I might've fixed the issue. I just released a new version for 1.18.1 and 1.18.2 with a potential fix. Since I think the issue is resolved I will close it, but if it reappears make sure to notify me. I'm also very sorry for the delay I've been busy for the last few weeks
Anyway thanks for reporting in this issue!


Remove spaces in the Feature Parameter Examples

As the documentation, there should be no spaces in the feature list:
"/FEATURES, which is a multivalued parameter, but its format is /FEATURES=AS,RS,IS without a space, comma-delimited "

Hi @PiJoCoder, awesome, thanks for noticing these :) #sign-off


Agree and plan the content needed for Kit docs research

What
Agree what content is needed for the upcoming Prototype Kit docs research, commencing Monday 18 March.
Why
To ensure we'll have necessary content in place for the research task, and that we are all on the same page about what's being created.
Who needs to know about this
Amy, everyone
Further detail
Draft content structure
Done when

[x] List of content work drafted
[x] List of content work needed agreed with @DebsDee and @RosieClayton
[x] Plan played back to team
[x] Cards created for individual pieces of content work

Closed issue as its in the done column on the Kanban board


fix: HL 1170  unclosed p-tag

Description :sparkles:
Decision text factory had an unclosed p-tag, which causes an error in Ahjo
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

API branch is deployed to platta: https://helsinkilisa-pr2851.api.dev.hel.ninja/healthz :rocket::rocket::rocket:

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2851.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-pr2851.dev.hel.ninja :laughing::tada::tada::tada:

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2851.dev.hel.ninja :rocket::rocket::rocket:

TestCafe result is success for https://helsinkilisa-ui-handler-pr2851.dev.hel.ninja :laughing::tada::tada::tada:


Permit searching from any page

Many pages in the Material skin do not display a search icon (in Google Chrome on Linux). Examples are:

Viewing the Albums page (Home > My Music > Albums)
Viewing the tracks of any album

When you're on one of these pages, you can't search. You have to navigate through the UI to reach a page that has a search icon. This feels unnatural in a modern application.
Would it be possible to have a search icon always available?
Thank you.

Duplicate of #623


std::thread stack size configuration (IDFGH-10371)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
According to the documentation, ESP32 supports std::thread in C++. However, in many cases, the stack size of a newly created thread in not enough for use. I do know that using the RTOS functions, the stack size could be configured when creating a new thread.
I have also heard of the use of pthreads functions, but that does not seem to be compatible with std::thread, and that using esp_pthread_set_cfg will overwrite the global rule of new thread creation, whereas I am only looking for a solution to configure stack size for individual thread.
Please do let me know if I am wrong in the aforementioned statements.
So, is there a way to set stack size of a thread created using std::thread?
Thank you very much.

esp_pthread_set_cfg sets a thread-local value which will be inherited by pthreads and std::threads created from the current thread/task. It shouldn't affect creation of threads by other tasks running at the same time.

Thank you. However, what I meant was that I was trying to create multiple threads from the same main thread. By using esp_pthread_set_cfg would overwrite the thread creation configuration in the main (originating) thread. So, is there a way to create threads with custom stack sizes without overwriting any default rules? Thanks.

From: Ivan Grokhotkov @.>
Sent: 09 June 2023 20:28
To: espressif/esp-idf @.>
Cc: Tony Zhu (Q-2020) @.>; Author @.>
Subject: Re: [espressif/esp-idf] std::thread stack size configuration (IDFGH-10371) (Issue #11629)
esp_pthread_set_cfg sets a thread-local value which will be inherited by pthreads and std::threads created from the current thread/task. It shouldn't affect creation of threads by other tasks running at the same time.
—
Reply to this email directly, view it on GitHubhttps://github.com/espressif/esp-idf/issues/11629#issuecomment-1584496094, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXQECHT6W5NON7NWKKLYKFLXKMJIXANCNFSM6AAAAAAZAKQ4NY.
You are receiving this because you authored the thread.Message ID: @.***>

I think you could do something like (pseudocode)
// save the old config
esp_pthread_cfg_t orig_cfg;
esp_pthread_get_cfg(&orig_cfg);

// set up the new config
esp_pthread_cfg_t new_cfg = { ... };
esp_pthread_set_cfg(&new_cfg);

// create a thread
auto t = std::thread(...);

// restore the old config
esp_pthread_set_cfg(&orig_cfg);

@Zhu-jiatong Does @igrr's suggestion work for you?

Yes. Thanks.

From: 0xjakob @.>
Sent: 25 June 2023 16:21
To: espressif/esp-idf @.>
Cc: Tony Zhu (Q-2020) @.>; Mention @.>
Subject: Re: [espressif/esp-idf] std::thread stack size configuration (IDFGH-10371) (Issue #11629)
@Zhu-jiatonghttps://github.com/Zhu-jiatong Does @igrrhttps://github.com/igrr's suggestion work for you?
—
Reply to this email directly, view it on GitHubhttps://github.com/espressif/esp-idf/issues/11629#issuecomment-1605928374, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXQECHRZG2XXBUUMYDHWTWDXM7YIRANCNFSM6AAAAAAZAKQ4NY.
You are receiving this because you were mentioned.Message ID: @.***>

@Zhu-jiatong Great to hear. We are closing this issue then. Feel free to re-open it if you encounter any problems directly related to the std::thread stack size configuration.


Improve static analysis compatibility

Right now when you use @from "...", IDEs are not smart enough to expand the macro and locate the definition of a symbol. This means that useful features like hover help will not work when developing locally with FromFile.jl. I think this really hurts the rate of adoption.
I see two ways of fixing this:

Patch LanguageServer.jl to recognize custom macros for including files. Perhaps there could be a configuration file in the root of a project which tells the language server what symbols should be treated as equivalent to include.
Modify the syntax of FromFile.jl to use include. For example:

@from include("types.jl") import ...

it is one more symbol, but would successfully trick the language server to pick up the definition of symbols. (You can even trick the language server with macro ignore(args...) end; @ignore include("types.jl"), which is useful for enabling hover help in test files).
For 2, since this is slightly different syntax, I would also encourage you to use a different macro name instead, like @import include("types.jl"): ..., which is closer to existing Julia style (and would help win support from any core devs with allergic reactions to Python).

Related to https://github.com/julia-vscode/julia-vscode/issues/2548 from @MariusDrulea

Tricking language server could be possible. I used to do that in https://github.com/Shuenhoy/ThinModules.jl, which takes an even smaller step that still keeps the standard include structures but only reorders the module definitions by auto topo sorting (now it's like rust somehow).
The problem here is there are bigger gaps between the semantics of include and from .. import ... And my concern is that sometimes this may work, but other times language server would provide the wrong intelligence, depending on the actual structure formed by from .. import ...
But if it could be proved that the wrong situations are rare or easily avoided, this would be a very practical and cheap way.

I think since this package was made as a proposal for issue 4600, we should expect these things to be supported by the Julia compiler in some way instead of special case in LanguageServer (otherwise, other package defines a macro named @from would have wrong linting). As I mentioned in the other discussion, I think the cleanest solution would be supporting custom package plugin for the linter, which is possible but hard to do in Julia based on the previous discussions in julia-vscode/julia-vscode#2548.
I'm not a fan of changing the syntax as this is more of a technical problem rather than the issue of the syntax design.

You can even trick the language server with macro ignore(args...) end; @ignore include("types.jl"), which is useful for enabling hover help in test files

IMO, this just seems wrong for a language server... one cannot guarantee the correctness of linting a macro, as the syntax is customed. The only way is. to specialize the corresponding linting for a specific macro.

Very fair points! If language server can be fixed soon that would be great. But it is definitely a significant change vs simply using “include” in the syntax.
Since (1) I just want hover help to work, and (2) the technical issue seems like it has an undefined timeline, I think modifying the syntax to allow @from include(“myfile.jl”) import … is a simple short-term solution. It would probably only require a couple lines changed in the macro, and you could still support the current syntax by default. Then when (if) language server is patched you could deprecate it.

As a temporary solution to this problem, I have forked the StaticLint package here: https://github.com/MariusDrulea/StaticLint.jl. This fork has support for the @from macro.
You can simply replace the default StaticLint of the LanguageServer julia environment. This has three steps: navigate inside the julia vscode extension into the language server folder, activate the language server environment and add the desired StaticLint package. Restart vscode and now the language server is able to hancle the @from macro.

I am strongly in favor of keeping the syntax of FromFile as it is. The problems are elsewhere and we shall focus on these problems by:

Making the language server support custom macros; David Anthoff mentioned a good medium-term solution here: https://github.com/julia-vscode/julia-vscode/issues/2548#issuecomment-1001250804.
Contribute to the julia's include system. Julia's include system is really ugly and we shall have it more like it is in java, C#, python.
https://github.com/JuliaLang/julia/issues/4600/
https://github.com/JuliaLang/julia/issues/4600#issuecomment-1221666767

@MariusDrulea i did the steps you described to replace StaticLint but the LanguageServer stopped working altogether. Luckily, i figure out how to make it work with the following steps:

Locate the julia-vscode extension folder. Generally, this directory lives at ~/.vscode/extensions/.vscode/extensions/julialang.language-julia-<VERSION>/.
Navigate to the scripts/packages directory.
Locate the StaticLint directory and delete it or rename to something else in case it doesn't work.
Run git clone https://github.com/MariusDrulea/StaticLint.jl  StaticLint
Open VSCode and check if everything works.


Fixed #30427, Fixed #16176 -- Corrected setting descriptor in Field.contribute_to_class().

Replaces #11337.
Updates, and puts the tests in place that were hanging from the previous PR. It's difficult to follow so I've commented hoping to make them clear (for now and the next poor soul coming back to this 😀)
We had release notes in an earlier version 5fc4884ba104c502e9aac9b72c2dfec1d7df1560 — those were incorrect since the multiple inheritance example never worked. See 4bbe8261c402694a1da3efcaafe3332f9c57af15.
The change in behaviour proposed is allowing that structure. See the adjustment in the (now named) test_multiple_inheritance_allows_inherited_field method.
Inheritance works ≈as expected except for the depth-first resolution in diamond-shaped cases. Calling that out in docs/topics/db/models.txt is I think probably worth while. I need to think about exactly where to put that/what to say. Input welcome. 😜

Calling that out in docs/topics/db/models.txt is I think probably worth while. I need to think about exactly where to put that/what to say.

Yes definitely. Perhaps just a really terse description is enough...
Fields attach descriptors to every model class that includes them.
Because of this, diamond inheritance will cause a leaf model to inherit fields depth-first rather than breadth-first.

For anyone attempting diamond inheritance (certainly a small minority) this note may be enough (?). I don't think a long section with diagrams is warranted, given the rarity.

Thanks both. I'll tidy this up and pull it in.
(What a set of tickets 😅)

Will this be backported to 3.2.x?

No, the backport policy only allows “Security fixes and data loss bugs” for a feature change like this: https://docs.djangoproject.com/en/dev/internals/release-process/#supported-versions .

Ok, thanks!


feat: receiving and sharing qeaas

https://github.com/user-attachments/assets/f28263c1-5e58-4526-9ec0-74a6662dac38

@TimoGlastra added a video. I think it's easiest of you just run it and test it and lmk if you run into anything.

Video looks nice! Thanks. I'm only not so sure about the share overlay with yellow top and then the shared attributes below on white. I think it should look a bit more like a card maybe? It's quite a big contrast. Can't we add an overlay with a certain transparency so white text on top of it is always visible (or black text)?
Also -- does it support multiple credentials being presented?

Also -- we can do this later, but i think we might have to tweak the UI just a little bit so it's not exactly the NL wallet design (i think it's good inspiration, but also no need for it to look 100% the same i think?)

Both can be improved later, this is already a very good improvements, so good to merge on my side 🙌

Video looks nice! Thanks. I'm only not so sure about the share overlay with yellow top and then the shared attributes below on white. I think it should look a bit more like a card maybe? It's quite a big contrast. Can't we add an overlay with a certain transparency so white text on top of it is always visible (or black text)?
Also -- does it support multiple credentials being presented?

Can you share a screenshot of what you mean? I'm not following.
The UI supports sharing multiple credentials but there is an error thrown from a lower level so I've created a ticket out of it.

Also -- we can do this later, but i think we might have to tweak the UI just a little bit so it's not exactly the NL wallet design (i think it's good inspiration, but also no need for it to look 100% the same i think?)

Yes, this is in the back of my mind. I've already changed the view of attributes back to what we have in the Paradym wallet. This makes it stand out a bit more. Still thinking about a different view for the home cards as well.

The UI supports sharing multiple credentials but there is an error thrown from a lower level so I've created a ticket out of it.

That will be resolved by #180, but we need to wait for a new release of PEX


Client side validation

Hello again Jeremy,
This is structure of my code, client side validation is working fine for 'CompanyName'. But for in case of remaining properties in Contact class, client validation is not working but server side works. Can you suggest me what to do?
[Validator(typeof(ClientValidator))]
public class Client
{
public string CompanyName{get;set;}
private volatile Contact Shipping = null;
private volatile Contact Billing = null;

}
public class Contact : Address
{
}
public class Address
{
public String Name{get;set;}
public String Phone{get;set;}
}
public class ClientValidator : AbstractValidator
{
///
///
///
public ClientValidator()
{
RuleFor(x => x.CompanyName).NotNull().WithMessage("Required").Length(1, 15).WithMessage("Length issue.");
		RuleFor(x => x.Shipping.Name).NotNull().WithMessage("Required").Length(1, 15).WithMessage("Length issue.");
		RuleFor(x => x.Shipping.Phone).NotNull().WithMessage("Required").Length(1, 15).WithMessage("Length issue.");
		RuleFor(x => x.Billing.Name).NotNull().WithMessage("Required").Length(1, 15).WithMessage("Length issue.");
		RuleFor(x => x.Billing.Phone).NotNull().WithMessage("Required").Length(1, 15).WithMessage("Length issue.");
	}
}

I believe that the clientside validation only works for top-level properties, not nested properties. I think you'd need to introduce a separate AddresValidator if you wanted clientside validation for the address properties.

Ok Suppose i have created seperate AddressValidator class then how can i apply these validations in Client class for shipping & Billing for both.

There's two options. If you're using the automatic MVC integration, then just annotate your Address class with [Validator(typeof(AddressValidator))] and MVC will take care of the rest.
The other option is to use SetValidator. See this page in the documentation: https://github.com/JeremySkinner/FluentValidation/wiki/b.-Creating-a-Validator#complex-properties
...but I don't think clientside validation works with this (MVC's validation infrastructure is very limited, so FV can only hook into it in certain situations).


Upgrading electron

I noticed that the lockfile mentions electron 22, and based on this table any version prior to electron 27 is EOL. Are there plans to upgrade to a secure version?

That makes sense to do. We are spread pretty thin at the moment. Would accept a PR making that change ;-)


Why is this still not showing failing @v0.97.1

Based on the fact that this version breaks Meteor, I don't see how this is passing.

Why open an issue already known ?

Fixed in #2056


Add withDelay function

This commit adds the withDelay function to FRP.Event.Time. My
personal reason for using this was that, for every tick of the RAF
event, I wanted to progress a pre-scripted animation. So, if the
animation were to last for 1000ms, the withDelay stream let me check
the progress through the animation, and then eventually when it had
finished (i.e. to stop animating).
I know this is a "maybe", @paf31, so I'm quite happy to have this one closed. As @justinwoo said, this library might not be the best place for hundreds of Rx operators! 🙃

Closing this for now; I think it's perhaps too specific, and it's out-of-date :)


Fixes docs that reference messaging service

Describe your changes :

I worked on the documentation because it incorrectly referenced "messaging service" instead of "pipeline" or "dashboard".

Type of change :

[x] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

Thanks @juliarvalenti . This looks great. You marked the PR as draft, so will wait to merge if you have any further changes you want to add to this PR

Hi @harshach!
All fixed, I was trying to run unit tests locally, so that's why I marked it as draft, but everything seems to be good :)

Thanks @juliarvalenti for you contributions. changes are merged in :)


Sperf core statuslogger does not parse debug log

We do this in other tooling and I think it just got missed when we started parsing debug logs

due to business ticket volume this was rolled into 68 support, tests were added for this case and the ability to parse the debug log was added and turned on by default


Challenge 55 (Create a Set of Radio Buttons) Not Showing Best Practices

In the Create a Set of Radio Buttons challenge of the HTML5 and CSS section (https://www.freecodecamp.org/challenges/create-a-set-of-radio-buttons), it states:

Here's an example of a radio button:
<label><input type="radio" name="indoor-outdoor"> Indoor</label>

Yet, in more official Mozilla documentation (https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/How_to_structure_an_HTML_form#The_<label>_element), it states:

Note that a widget can be nested inside its  element, like so:
<label for="name">
  Name: <input type="text" id="name" name="user_name">
</label>

Even in such cases however, it is considered best practice to set the for attribute because some assistive technologies do not understand implicit relationships between labels and widgets.

This was discussed here: https://forum.freecodecamp.org/t/anyone-notice-that-some-of-the-challenges-dont-demonstrate-best-practices/151348
Please update the challenge to reflect best practices.

Ill work on this issue. Just a clarification, do i have to like update wherever its written the set with the new documentation

@darthgera123 Awesome! Thanks.
I'm not sure if you're asking me or the experienced Free Code Camp contributors, but I'd say yeah, change the code/language wherever it needs to be changed, not just in the specific example/challenge cited above. In my opinion, every Free Code Camp challenge should suggest and show code that matches current best practices, even if the code in a particular challenge is just supporting code and not the focus of that challenge. Does that answer your question or were you hoping to get an answer from someone else?

Yeah more or less it does. Ill do what i can

@darthgera123 the challenge code is here
You would need to update the instructions and the tests for this challenge, then update the instructions and tests for the checkbox challenge after, and update the code that is preloaded in the editor for every subsequent challenge.
@freeCodeCamp/moderators I'm fine with this change, but would like to hear others' thoughts.

@camper-fcc Yes - if you're talking about just nesting the checkbox within the label (instead of having everything on one line), sure, we can teach the recommended way.
Please note that when you make this change, you'll need to also change the lesson instructions which introduce this syntax, and you may need to update some tests. You'll also need to update subsequent challenges that have that element in their challenge seeds.

@camper-fcc thanks for the report.
@QuincyLarson
IMHO, I think we do not need to modify the tests to check for this attribute. Because we are not enforcing best practices but recommending them where we can.
So, any best practice updates to any challenges can be done async.
To contributors:
This line needs to be updated
https://github.com/freeCodeCamp/freeCodeCamp/blob/f792a4380a894ba294873b69d4eca747b8564fef/seed/challenges/01-responsive-web-design/basic-html-and-html5.json#L1772
to add the for="indoor" into the sample snippet, and additional clarification as simple text like so:

It is considered best practice to set the for attribute for assistive technologies to be able to link the relationship between the label and the child elements such as an input in this case.

@raisedadead I agree that we shouldn't be enforcing the more fashionable best practices, but if it's a long-held and wide spread norm, I think it's OK to mention it in the lesson text and have a test for it.

Yes - if you're talking about just nesting the checkbox within the label (instead of having everything on one line), sure, we can teach the recommended way.

Is the point discussion about the nesting or the for attribute, and how it improves screen reader experience?

The OP's intention is discussion about the for attribute and how it improves screen reader experience.

@darthm3gatron and others. Thanks for fixing this and taking it seriously! :1st_place_medal:


[Feature] Collaborative developpement

I would like to participate in the development of Beeftext, however, I don't know how to build it.
https://github.com/xmichelo/Beeftext/tree/c0eea17fd116d85feced959cb41d4d6cf4767d92#building-beeftext

Detailed build instructions are not available at the moment.

I'd be interested if you could spend a bit of time explaining go into some level of details about how to build Beeftext, and how to test it manually. Alternatively or in complement, we can use this issue to discuss the installation, with me asking for help whenever I feel helpless. In such a case, I can summarize the whole developement environment installation procedure once we're done.
Have a good day

Hi @mathieucaroff
Thank you for your interest in contributing. Unfortunately, and even if this it may look strange, I am not looking for contributors. Even further I will not look at an PR submitted.
The reason is simple: I'm busy as with my day job as an engineer, and I have a maximum of 4 to 5 hours to spend on Beeftext per week. A good portion of this is spent dealing with issues. I want to keep the rest of my time for actual development, not discussion or code reviews.
That said, you can still build Beeftext for your own pleasure. What you need is to setup Qt for development with Visual Studio:

Install Visual Studio 2019 (the free Community edition is sufficient).
Install Qt: The online installer will require a free account. From the options, grab the latest release (5.15.1 as I write this message), The only component you need is MSVC 2019 32-bit, and in the Tools section, grab OpenSSL.
In Visual Studio 2019, install the Qt Visual Studio Tools extension from the Marketplace (`Extensions ➜ Manage Extensions ➜ Online), and configure it.

You should now be able to open and compile the Beeftext VS solution Beeftext.sln


Should disable 'Filter' button when no value has been selected

I think it'd be a better user experience than the current, which allows the user to click 'Filter' and does nothing.

This is fixed in the latest release :-)


Create user-persona-page-header.html

note: need to finish description

note: need to finish description


libatomic_ops: 7.6.2 -> 7.6.4

Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/libatomic_ops/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 7.6.4 with grep in /nix/store/n84mhrmyf5gi8ypx3rk8vnj3jzpcr4ss-libatomic_ops-7.6.4
directory tree listing: https://gist.github.com/3efac1c700e321bd79a10ade1fb376ee

cc @7c6f434c for review

Add RISC-V support

cc @shlevy :grin:

Should remove the patch then :wink:

Success on x86_64-darwin (full log)
Attempted: libatomic_ops
Partial log (click to expand)
Patching '/nix/store/0xk4c0kadqwfgah2ff74b7q167qphl8l-libatomic_ops-7.6.4-dev/lib/pkgconfig/atomic_ops.pc' includedir to output /nix/store/0xk4c0kadqwfgah2ff74b7q167qphl8l-libatomic_ops-7.6.4-dev
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4sdc1zk5nla415hr0hs763qvyn6jgldf-libatomic_ops-7.6.4/lib
patching script interpreter paths in /nix/store/4sdc1zk5nla415hr0hs763qvyn6jgldf-libatomic_ops-7.6.4
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0xk4c0kadqwfgah2ff74b7q167qphl8l-libatomic_ops-7.6.4-dev/lib
patching script interpreter paths in /nix/store/0xk4c0kadqwfgah2ff74b7q167qphl8l-libatomic_ops-7.6.4-dev
strip is /nix/store/0fzpxnsanc02i4jsb1yhchjp4p62b2n3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/vcfikdjrl0pyklabdxz26rzqwisdz8rm-libatomic_ops-7.6.4-doc
/nix/store/4sdc1zk5nla415hr0hs763qvyn6jgldf-libatomic_ops-7.6.4

Success on x86_64-linux (full log)
Attempted: libatomic_ops
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/4dirmp2mnijhma4gx2f6bnrigwh6h91l-libatomic_ops-7.6.4-dev
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4dirmp2mnijhma4gx2f6bnrigwh6h91l-libatomic_ops-7.6.4-dev/lib
patching script interpreter paths in /nix/store/4dirmp2mnijhma4gx2f6bnrigwh6h91l-libatomic_ops-7.6.4-dev
checking for references to /build in /nix/store/4dirmp2mnijhma4gx2f6bnrigwh6h91l-libatomic_ops-7.6.4-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/m85hzi9gcyri571v7yql0wjdqsb0b2z4-libatomic_ops-7.6.4-doc
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/m85hzi9gcyri571v7yql0wjdqsb0b2z4-libatomic_ops-7.6.4-doc
checking for references to /build in /nix/store/m85hzi9gcyri571v7yql0wjdqsb0b2z4-libatomic_ops-7.6.4-doc...
/nix/store/n84mhrmyf5gi8ypx3rk8vnj3jzpcr4ss-libatomic_ops-7.6.4

Success on aarch64-linux (full log)
Attempted: libatomic_ops
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/azbilvkw07b8q48k2a30ri3aj2kaif8w-libatomic_ops-7.6.4-dev
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/azbilvkw07b8q48k2a30ri3aj2kaif8w-libatomic_ops-7.6.4-dev/lib
patching script interpreter paths in /nix/store/azbilvkw07b8q48k2a30ri3aj2kaif8w-libatomic_ops-7.6.4-dev
checking for references to /build in /nix/store/azbilvkw07b8q48k2a30ri3aj2kaif8w-libatomic_ops-7.6.4-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/lyq8pjvrqqwgx7rman7nn82q9rrqbi8x-libatomic_ops-7.6.4-doc
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/lyq8pjvrqqwgx7rman7nn82q9rrqbi8x-libatomic_ops-7.6.4-doc
checking for references to /build in /nix/store/lyq8pjvrqqwgx7rman7nn82q9rrqbi8x-libatomic_ops-7.6.4-doc...
/nix/store/9ypqyr5775x4i74xmzsb6d3l3kmjy609-libatomic_ops-7.6.4

@GrahamcOfBorg built chase

Too bad asking for LibreOffice is not a practical request…

Fixed by https://github.com/NixOS/nixpkgs/commit/6dc900c06896168f1e93fb3952b5a37f2228d12a

(tested the chase build locally)


re-enable Spray test suite

figure out why https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/33/console
failed spray.httpx.unmarshalling.ScalaXmlUnmarshallerSpec

@adriaanm writes:

i had to disable spray's tests
i think we may have broken their xml unmarshalling...
https://scala-ci.typesafe.com/job/scala-2.11.x-integrate-community-build/34/console
dbuild conf: https://github.com/adriaanm/community-builds/commit/f4d747374253a6ac0533ed988c9b5e15ec4fc327

In v1.3.3 we introduced a test (and some configuration changes) to guard against XXE attacks in spray/spray#1024. See here:
https://github.com/spray/spray/blob/master/spray-httpx/src/test/scala/spray/httpx/unmarshalling/ScalaXmlUnmarshallerSpec.scala
In the failing run the errors are these:
[spray] [info] The ScalaXml (NodeSeq) unmarshaller should
[spray] [info] + unmarshal XML bodies
[spray] [info] x parse XML bodies without loading in a related schema
[spray] [error]    'MalformedContent(,Some(java.lang.NullPointerException))' is incorrect:  (ScalaXmlUnmarshallerSpec.scala:44)
[spray] [info]
[spray] [info] x parse XML bodies without loading in a related schema from a parameter
[spray] [error]    'MalformedContent(,Some(java.lang.NullPointerException))' is incorrect:  (ScalaXmlUnmarshallerSpec.scala:59)
[spray] [info]
[spray] [info] x gracefully fail when there are too many nested entities
[spray] [error]    'MalformedContent(,Some(java.lang.NullPointerException))' is incorrect:  (ScalaXmlUnmarshallerSpec.scala:74)
[spray] [info]
[spray] [info] x gracefully fail when an entity expands to be very large
[spray] [error]    'MalformedContent(,Some(java.lang.NullPointerException))' is incorrect:  (ScalaXmlUnmarshallerSpec.scala:84)

where the tests instead expects a SAXParseException instead of a NPE. As an NPE could mean anything from a bug in the implementation to a dependency on a specific JDK version, the tests should probably be rewritten to output the full exception including stack trace in case the exception isn't of the expected type.

Thanks, @jrudolph!

@jrudolph if or when you have a new version for us to test, let us know. for now, in the community build we are leaving the tests disabled and the version pegged at v1.3.3

for the 2.11 builds, it's fine to leave spray as-is, I think.
in the 2.12 build, spray is actually commented out because of some JSON library problem — might be easy to fix, we should revisit it

returning to this now — #324 should clear the way

these dependencies look potentially problematic:

old Akka version (2.1, should be 2.4.x)
old Shapeless version (1.2, should be 2.x)
old ScalaTest version (2.2, should be 3.0.x)
old Specs2 version (2.3, should be 3.8.x)
two different twirl-api dependencies (??? — not sure what this is about)

@sirthias @jrudolph offhand, this looks like too many outdated libraries for likely success at including spray in the Scala 2.12 community build. it's possible that you're actually using these libraries in ways that are source-compatible with the versions in the community build, but offhand it looks like a slog for us. are you interested in embarking on your own program of library-refreshing...? you might need to anyway if you plan to support Scala 2.12.
I'd suggest we park this ticket until you've published spray for Scala 2.12.0-RC1 (or later)

I don't think having spray as part of the community still makes sense going forward.
spray is end of life and will not be maintained.
Additionally, basically all its logic has been moved over to Akka HTTP, which is already part of the build (AFAIK). So, there shouldn't be too many constructs that adding spray would test in addition to Akka HTTP.
Therefore, I'd vote to simply close this ticket.

@sirthias got it! thanks for letting us know.
yes, akka-http is in the 2.12 community build now.