log txid in logger

Description
Logging txid with rest of message improves debugging
Type of change
Please select all options that apply to this change:

[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Documentation update

Checklist:
Confirm you have completed the following steps:

[X] My code follows the style of this project.
[X] I have performed a self-review of my code.
[ ] I have made corresponding updates to the documentation.
[ ] I have added/updated unit tests to cover my changes.
[ ] I have added/updated integration tests to cover my changes.

actually txid is present in Metadata()


npm install doesn't work when using homestead

Not your fault, seems like the homestead version of npm (coming with ubuntu) is too old and has some issues. Will post a fix here once I've found one.

Thank you! I haven’t used Homestead, so I didn’t come across that. Looking forward to the fix. :wink:

Actually the fix is simple, just need to run
sudo npm -g install npm@next

to bump to the latest version of npm. Then running
sudo npm install

and it's all good :)
Thanks for the repo! It clarified some things I didn't quite understand before with JWTAuth.

Okay, thanks for the response. I’m happy the repo could help you with that. :)


move storybook and ignore it

As for #94
remove storybook from the source code,
I remain it in another directory and add it to gitignore to run it locally
so, it won't push to GitHub.

@ofirelarat can you please rebase with main? Thanks

merged


Proposal of more photos

Hi.
I think that you could add more photos in the current object, that is, that you can see more photos in carousel format for the object you are currently viewing.
I do not know if I have explained myself properly, but this is implemented by Tinder and other applications.
Thanks.

Yes, it's supported. But it's need you code in the default slot.
It’s a bit complicated as a demo, so I didn't make it.

Thanks for your reply.
Is there not an example that I can see to know how to do it?


fix paath resolution for relative urls using leading slash

For a master located at
http://example.com/hls/playlist.m3u8
with stream locations advertised as
/hls/chunklist.m3u8
the location that should be requested for the chunklist is
http://example.com/hls/chunklist.m3u8
however the use of path.join causes hls-fetcher to request
http://example.com/hls/hls/chunklist.m3u8

I added a test to verify this behavior


Insufficient contrast for highlighted search matches

Search results will highlight the matched sections with a different background color but does not change the font color making it hard to read the text.
Screenshots

Dang, I changed this for one context and it broke another. Thanks for filing! I'll try to fix it soon.

Just worked on this! Please update! (might need to restart code to see the changes) thanks for reporting!

@sdras Woohoo it works now! Thank you so much for fixing this so quickly 🎉


The repl freezes for several seconds every time you type db

I am going to present a problem and offer a workaround here.
I found out by using the repl that every time you type db, the console freezes for several second.
This seems to happen because the whole prisma object gets inspected and possibly logged.
To avoid that, you can use a custom inspect function (https://devdocs.io/node/util#utilinspectcustom)
For example, after starting the repl, we can type:
const customInspectSymbol = Symbol.for('nodejs.util.inspect.custom');
db[customInspectSymbol] = function () { return '' };

and that would prevent the freezes.
Also posted here: https://github.com/prisma/prisma/issues/18320

It would be nice if this workaround could be done in the prisma-repl code so that we don't have to do it manually every time.


fixes in CurrentForecast.local_time

Hi, here are some changes I had to make to get weather.current.local_time to work for me.
Cheers

Oh god i forgot about those - Thanks for the contribution!


Update kpng-local-up.sh and fix potential IPVS panic

While trying to run the project locally using hack/kpng-local-up.sh, I encountered several problems:

Using the ipvs backend used to cause a panic, because the base distro being used in the kind node was out of date hence there was no proc/sys/net/ipv4/vs present, resulting in Setup() to fail silently. Later when a new service gets synced, AddIP() panics because s.dummy never got set.
The hack/kpng-local-up.sh is out of date using envsubst instead of j2

Thanks for doing this! I just want to see what Per has to say about re-using J2 since he just merged https://github.com/kubernetes-sigs/kpng/pull/345

/assign @qabpea

@aryan9600 Overall this looks great and I tested locally, do you mind also adding a quick note to the readme in /hack/ Explaining how to spin up a devel cluster with ./hack/test_e2e.sh  -d -i ipv4 -b <backend> and the difference between that and ./hack/kpng-local-up.sh?
I'll go ahead and give it an lgtm ig you want to tackle that in a follow up PR
/lgtm

Hrm
# github.com/cilium/ebpf/internal
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:6:14: syntax error: unexpected any, expecting ]
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:12:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:16:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:21:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:37:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:40:2: syntax error: non-declaration statement outside function body
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:52:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:53:6: zero redeclared in this block
	/home/runner/go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:38:6: previous declaration
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:55:2: syntax error: non-declaration statement outside function body
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:70:16: syntax error: unexpected [, expecting comma or )
../../../go/pkg/mod/github.com/cilium/ebpf@v0.9.3-0.20220920164205-03b648ce0c4c/internal/deque.go:53:6: too many errors
note: module requires Go 1.[18](https://github.com/kubernetes-sigs/kpng/actions/runs/3092361770/jobs/5003547330#step:3:19)

/hold
Just until  CI is green

@astoycos  I pinned cillium/ebpf to v0.9.2 in hack/test_e2e.sh, to avoid this, i'll do it in the github workflow as well

/lgtm
/un-hold

/un hold

/approve
/unhold

@jayunit100 This should be good :)

/lgtm
/approve


feat: add support for Azure private DNS

Checklist

[ ] Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
[x] The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
[ ] The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
[ ] Helm releases are meeting otomi's baseline security policies, if applicable.
[ ] Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@j-zimnowoda why was this approved so quickly when it was obviously not ready:

duplication of configuration
no requirements
no justification for the chosen approach

Please stay critical. Especially when new contributors like @srodenhuis submit their PR.


Expression doesnt work in ng-maxlength

here is the plink: http://plnkr.co/edit/FgmK1b?p=preview&s=tempoooo
checks the maxlength that is 5 using an expression, and it's not validated however, using {{expression}} it shows the value

This is not going to be backported to 1.2, so can be closed


Rewrite with ScriptingBridge (was Rewrite with PyXA)

This looks like a much better way of interacting with Notes: PyXA
As an example:
>>> import PyXA
>>> app = PyXA.Application("Notes")
>>> print(app.notes().name())

Prints titles of all notes instantly

Actually, might be able to implement this with ScriptingBridge without the overhead of PyXA (which looks awesome but still immature and has some weird dependencies: python==3.11, numpy, all of pyobjc)
python
^[[APython 3.11.0 (main, Dec 25 2022, 14:21:02) [Clang 12.0.0 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import ScriptingBridge
>>> from ScriptingBridge import SBElementArray
>>> app = ScriptingBridge.SBApplication.alloc().initWithBundleIdentifier_("com.apple.Notes")
>>> notes = app.accounts()[1].notes()
>>> len(notes)
394
>>> import AppKit
>>> predicate = AppKit.NSPredicate.predicateWithFormat_("name contains[cd] %@", "cocktail")
>>> predicate
name CONTAINS[cd] "cocktail"
>>> results = notes.filteredArrayUsingPredicate_(predicate)
>>> len(results)
4
>>> names = [results.arrayByApplyingSelector_("name")]
>>> names
[(
    "You\U2019ve Never Heard of One of the Bahamas\U2019 Most Popular Cocktails",
    "Watermelon Mint Mojito Cocktails - Creative Culinary",
    "Gin Basil Smash cocktail",
    "Tequila Sunrise Cocktail"
)]
>>> ids = [results.arrayByApplyingSelector_("id")]
>>> ids
[(
    "x-coredata://BA47E88C-3599-48BE-88DD-5CBC118E9CE6/ICNote/p1038",
    "x-coredata://BA47E88C-3599-48BE-88DD-5CBC118E9CE6/ICNote/p1030",
    "x-coredata://BA47E88C-3599-48BE-88DD-5CBC118E9CE6/ICNote/p659",
    "x-coredata://BA47E88C-3599-48BE-88DD-5CBC118E9CE6/ICNote/p661"
)]
>>> note = notes.filteredArrayUsingPredicate_(AppKit.NSPredicate.predicateWithFormat_("id == %@", ids[0][0]))
>>> len(note)
1
>>> note[0].name()
'You’ve Never Heard of One of the Bahamas’ Most Popular Cocktails'
>>>

Making progress on this but looks like I can't get rid of the AppleScript completely.
There are some conditions (e.g. using selection on Catalina or using a predicate) where the ScriptingBridge sets the object ID to 0.  I haven't been able to figure out why but in this case, the id can be determined by examining the string representation of the object which looks like this:<SBObject @0x7fd721544690: <class ''> id "x-coredata://19B82A76-B3FE-4427-9C5E-5107C1E3CA57/IMAPNote/p87" of application "Notes" (55036)>
Using this, I can get the Note ID then use the existing AppleScript calls to get the note details. This isn't elegant but works in all cases I've been able to test.

Making progress on this but looks like I can't get rid of the AppleScript completely.
There are some conditions (e.g. using selection on Catalina or using a predicate) where the ScriptingBridge sets the object ID to 0.

I just looked into this for PyXA (thanks for the feedback btw!). It seems to be an issue with how PyObjC's lazy evaluation of SBObjects works when using predicates -- it ends up evaluating the object at its index within the result of the filtered array. E.g., if filtered_array is the result after applying a predicate, then filtered_array[0] will effectively evaluate as [the object with ID 0 of [filtered array]]. HOWEVER, there is a workaround! Call get on the SBElementArray prior to

Making progress on this but looks like I can't get rid of the AppleScript completely.
There are some conditions (e.g. using selection on Catalina or using a predicate) where the ScriptingBridge sets the object ID to 0.

I just looked into this for PyXA (thanks for the feedback btw!). It seems to be an issue with how PyObjC's lazy evaluation of SBObjects works when using predicates -- it ends up evaluating the object at its index within the result of the filtered array. E.g., if filtered_array is the result after applying a predicate, then filtered_array[0] will effectively evaluate as [the object with ID 0 of [filtered array]]. HOWEVER, there is a workaround! Call get on the SBElementArray prior to

@SKaplanOfficial Thanks. I saw that you did call get() in PyXA and tried it but wasn't able to reliably make it work. Part of that may be that I do some of my development on Catalina (because I still use an old MB Pro laptop that won't run newer OS) and Catalina's Notes AppleScript interface is horribly broken.  I may drop Catalina support if I can make this work reliably on newer versions of macOS. In the meantime, I built a very hacky but working work-around that evaluates the string representation of the SBObject (which will include the ID in form: <SBObject @0x7fd721544690: <class ''> id "x-coredata://19B82A76-B3FE-4427-9C5E-5107C1E3CA57/IMAPNote/p87" of application "Notes" (55036)> from which I can extract the ID with a regex. Not elegant but it works.

@SKaplanOfficial Thanks. I saw that you did call get() in PyXA and tried it but wasn't able to reliably make it work. Part of that may be that I do some of my development on Catalina (because I still use an old MB Pro laptop that won't run newer OS) and Catalina's Notes AppleScript interface is horribly broken.  I may drop Catalina support if I can make this work reliably on newer versions of macOS. In the meantime, I built a very hacky but working work-around that evaluates the string representation of the SBObject (which will include the ID in form: <SBObject @0x7fd721544690: <class ''> id "x-coredata://19B82A76-B3FE-4427-9C5E-5107C1E3CA57/IMAPNote/p87" of application "Notes" (55036)> from which I can extract the ID with a regex. Not elegant but it works.


implements seata-tcp-transport and format some codes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error: Incorrect command line when extracting a master after fresh install

Hi,
after a fresh installation and when trying to rollout a master I get this message:
==>extracting D:\Lab\Labbuildr\Master.labbuildr\2012R2FallUpdate.7z to D:\Lab\L
abbuildr\Master.labbuildr
==>Using C:\Program Files (x86)\VMware\VMware Workstation\7za.exe with x -bb0 -
bso0 -bsp0 -oD:\Lab\Labbuildr\Master.labbuildr D:\Lab\Labbuildr\Master.labbuildr
\2012R2FallUpdate.7z
Error:
Incorrect command line
==>Sucess expanding D:\Lab\Labbuildr\Master.labbuildr\2012R2FallUpdate.7z
--
==>extracting D:\Lab\Labbuildr\OpenWRT_15_5_1.7z to ./
==>Using C:\Program Files (x86)\VMware\VMware Workstation\7za.exe with x -bb0 -
bso0 -bsp0 -o./ D:\Lab\Labbuildr\OpenWRT_15_5_1.7z
Error:
Incorrect command line

PS D:\Lab\Labbuildr> .\build-lab.ps1 -version
labbuildr version 2016-3rd Anniversary SP1 on branch : master
labbuildr Git Release  Fr, 06 Jan 2017 07:18:06 GMT
vmxtoolkit Git Release Mo, 21 Nov 2016 09:02:21 GMT
scripts Git Release  Fr, 23 Dez 2016 13:46:14 GMT
labtools Git Release  Sa, 31 Dez 2016 05:40:10 GMT

what Version of vmware Workstation are you using ?

should be fixed now if using VMware older 12.5 ...

Running version 11.1.3 ;-)

can you please try with latest build-lab.ps1  update followed by receive-labopenwrt -start ?

Works now - thanks a lot :)


chore: automated PR to update VHDVersion for 202409.04.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202409.04.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.35%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2600

Relevant Lines:
3644

💛  - Coveralls


Use title of one of the notes for the new combined note

Arguably, using one of the note instead of the other may not be optimal but the chances it is better than the generic Combined note are quick good so I think it would be an option worth investigating.
Do you foresee any issue implementing this ?
A good bet IMO would be using the title of the most recently updated note.

I think I will make this configurable, that the first selected note name will be used.

Please add this! Your plug-in is one of the most useful ones I use. I typically create drafts and bibliographies by combining notes which makes your plug-in my most used. But, having all the titles mixed in makes me have to manually go in and remove them all.
@JackGruber are you keeping this plugin active or have you abandoned it?


Support the use of an image in UIButton from python code without a theme entry

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
Let us to make a button to use an image from code instead of setting it up in the theme json.
In the game I'm working, I'm using buttons to create a hotbar where the player can select spells. Each spell has its own icon, and there are some 50+ possible icons.
Setting each possible icon in the theme file and a ObjectID for each spell would be really annoying.
Using code to retrieve each image from the spell database would be much more useful.
Describe alternatives you've considered
As a workaround, I'm setting button.normal_image = my_surface, button.hovered_image = .... and running button.rebuild() and replacing _set_any_images_from_theme in a subclass.
This seems to work, but I'm not sure it would have undesired consequences.
I think implementing this, would open the way for a future implementation of icons for UISelectionList, since behind the scenes each item of a selection list is an UIButton.

For me, the approach of adding a custom UIImage on top of an empty UIButton widget has worked without needing to specify anything in a theme file, at the expense of needing some additional manual layout work:
manager: UIManager
button = UIButton(
    relative_rect=pygame.Rect(...),
    text="",
    manager=manager,
)
UIImage(
    relative_rect=pygame.Rect(...),
    image_surface=pygame.image.load("image.png"),
    parent_element=button,
    manager=manager,
)


How to transfer USDT token?

I have tried different ways to send USDT token but none of them work, now I am trying to do this but it doesn't work either, how to do it?
version: "tronweb": "^4.4.0"
const tronWeb: any = new TronWeb({
    fullHost: 'https://api.trongrid.io',
    headers: {
      'TRON-PRO-API-KEY': "api-key",
      'Content-Type': 'application/json'
    },
});

const receiver = 'TXVDSPH9CFio9ALCYya6ADYNJhQ2cmmCHc';

  async function sendUSDT() {
        let contract = await tronWeb.contract().at('TR7NHqjeKQxGTCi8q8ZY4pL8otSzgjLj6t')
        console.log('contract', contract)
        let result = await contract.transfer(receiver, 1).send()
        console.log('res', result)
    }

You have to provide privateKey when you instantiating tronweb.

Вы должны предоставить privateKey при создании экземпляра tronweb.
const tronWeb: any = new TronWeb({
    fullHost: 'https://api.trongrid.io',
    headers: {
      'TRON-PRO-API-KEY': "api-key",
      'Content-Type': 'application/json'
    },
    privateKey: 'your private key'
});

i tried, then this error comes out

I get the private key through tronWeb.fromMnemonic
maybe I'm doing something wrong? where do you get the private key from?

You have to get an account before using tronweb. If you already have and you get your mnemonic, you need to use it as follow:
const tronWeb: any = new TronWeb({
    fullHost: 'https://api.trongrid.io',
    headers: {
      'TRON-PRO-API-KEY': "api-key",
      'Content-Type': 'application/json'
    },
    privateKey: TronWeb.fromMnemonic('your mnemonic').privateKey
});

Please paste up all your related code.

If you are using tron network, the privateKey and mnemonic should work. The error come out when the format of your privateKey is wrong. So you can console.log your privateKey to see if it's right.


Fix the distance definition

diff = x_1 - x_2
return max(diff, 2)

Add a FIXME for @mencattini  in 30e0969843f5ed3f95b3783e5300566b43c38ea6 to improve (if needed) the definition of the distance in knn.

Not sure to understand the fixme. This code "clip" the value only if it become greater than bound.
Let take an exemple :
x1 = [1,0,-1,-1], x2 = [1,1,-1,1], the distance should be the sum [0,1,0,2], which is ok with my code.
x1 =[1, 20, 1], x2 = [1, 10, 1], the distance should be the sum [0, 10, 0] which is "cliped" to [0, 2, 0]
By the construction of the array, the value of binary componants can't exceed 2.
Did i miss-understand the initial querry ?

If you have the following vectors: x1 = [1,0,1,2] and x2 = [1,1,-1,3], then the result should be [0,1,2,2], because there is a distance of 2 between -1 and 1, but also because there is a distance of 2 for the last part, because values are greater than 1.

Ok. I didn't understand the mertic on this way.
But is it a problem when there is only one feature that isn't in ternary forme ?

For instance?

Distance is fixed by 6781f39. Can you check ? (I explain the algorithm in the comments)


Could not lazy loading component, import work fine

import Vue from "vue";
import VueRouter from "vue-router";

Vue.use(VueRouter)

const Home = resolve => require(['./component/home/home.component'], resolve)
const About = resolve => require(['./component/about/about.component'], resolve)

export default new VueRouter({
  mode: 'history',
  base: __dirname,
  routes: [
    {path: '/', component: Home},
    {path: '/about', component: About},
    {path: '*', redirect: '/'}
  ]
})

error:
vue.js:2532 [Vue warn]: Failed to mount component: template or render function not defined. (found in anonymous component - use the "name" option for better debugging messages.)

What is in your .component? Is it an alias of .vue?
And please specify the version of webpack and vue-loader you are using.

it was js file
export default {
  name: 'About',
  template: require('./about.template'),
  style: require('./about.style'),
  data(){
    return {
      name: 'About'
    }
  }
}

https://github.com/Dreampie/resty-cms

You are requiring .template file which is not registered in your webpack config
loaders: [
      {test: /\.js$/, exclude: /(node_modules|dist)/, loader: "babel?presets[]=es2015"},
      {test: /\.css$/, loader: "style!css"},
      {test: /\.less$/, loader: "style!css!less"},
      {test: /\.html$/, loader: "html"},
      {test: /\.(eot|svg|ttf)$/, loader: "file"},
      {test: /\.(png|jpg|gif)$/, loader: "url"},
      {test: /\.woff2?$/, loader: "url?limit=10000&minetype=application/font-woff"}
    ]

no.My filename is  about.template.html

I see... Since this is not related to vue-router, please check your webpack config and/or other related configs.

@LinusBorg It would be very kind of you to help OP as to find out what's wrong in the configs, so I'll leave this issue as it is.

Yeah _I'll try to look into it.

@Dreampie I'm not sure weither it's releated, but the "base" option should not be a file system path - it should be the root path relative to the URL.
http://yourapp.com/we-start-here/ => mode: '/we-start-here'

Hm this is really weird. You even have an alias in your webpack config to properly load the standalone version, yet this error seems like its using the runtime-only (or maybe i'm mixing up simialr error messages in my head).
This may take some work to track down (unless I find it to be a config problem after all) could be related to vue-loader or vue-router.

compile result:
var Home = function Home(resolve) {
	  return __webpack_require__.e/* nsure */(1, resolve);
	};
	var About = function About(resolve) {
	  return __webpack_require__.e/* nsure */(2, resolve);
	};

	exports.default = new _vueRouter2.default({
	  mode: 'history',
	  base: __dirname,
	  routes: [{ path: '/', component: Home }, { path: '/about', component: About }, { path: '*', redirect: '/' }]
	});

@Dreampie Shouldn't the about.component.html be about.vue instead?

@posva
it's about.component.js which exports a component options object, inside of which je requires home.template.html
This shouldwork as far as I can tell.

Does it work by inlining that inside about.component.js? It may be a bug on webpack

You used export default inside the component, which only works with import.
When you require it, it will give you an object of {default: (your component)}
So change the lazy load from
const Home = resolve => require(['./component/home/home.component'], resolve)

to
const Home = resolve => require(['./component/home/home.component'], m => resolve(m.default));

@fnlctrl  shouldn't babel compile the ES6 export to commonjs module.exports syntax?

Yes and no. If you took a look at the compiled result, you would see something like exports.default = ....
This is to distinguish ES6 export default from traditional CommonJS module.exports, using the older syntax exports of node

@fnlctrl the loaders[ ... ] option was a lifesaver. Just realised i was requiring template files which were not registered. I have been looking for that answer for days. now it works like magic for me.
Thanks :)

Thank you @fnlctrl !!! Your solution solved my problem.


Set PEX_ROOT to container working directory/.pex

This is needed for YARN. When yarn users run headless, pex attempts to unzip files at /home and we get permission denied.

Thanks for the patch. I will testing it now.

LGTM :+1:
I deployed a topology on a YARN cluster. .pex directory is created inside container's working directory. I do not see the permission denied error any more.

👍 once CI passes.

GREAT!!!


Mocking with Jest

I saw some old posts, but still I'm getting TypeError: mailgun_js_1.default is not a constructor error. I'm trying to mock Mailgun. I'm using "mailgun.js": "^8.0.6" version. Please let me know which part I'm missing. I don't want to use     "esModuleInterop": true parameter. Because it brokes other parts :). Here is my codes:
const emailMessage = {
  id: 'test',
  message: 'test',
  status: 200,
  details: 'n/a',
};

jest.mock('mailgun.js', () =>
  jest.fn(() => ({
    client: () => ({
      messages: {
        create: jest.fn().mockResolvedValue(emailMessage),
      },
    }),
  })),
);

I mocked as below. It's working well.
const emailMessage = {
  id: 'test',
  message: 'test',
  status: 200,
  details: 'n/a',
};

jest.spyOn(Mailgun.prototype, 'client').mockImplementation(() => {
  return {
    messages: {
      create: jest.fn().mockResolvedValue(emailMessage),
    },
  } as any;
});


New areas script update

I did not know how to add new dependencies to the cargo file; thus, I added cargo-edit  to add click dependency; I hope that's ok.
I modified the select_msoas.py script to make it slightly easier to use.

I have followed your suggestions and done what you've requested. Please take a look at the added commits.

@mfbenitezp, please take a look at the changes:

I reverted the Cargo.lock changes and deleted DS_Store from git
No more csv.DictWriter at all; it's lots of pointless extra steps to write literally one column
Transforming the LAD name to a Unix-friendly output filename without spaces. We can further name this whatever we want; two_counties and west_yorkshire_large are just constructs that were useful
Warn when the input isn't a known LAD at all

The lookup table has a bunch of other columns; we could make this even nicer by asking the user which category they want to search by too. If we wanted, it could even prompt users to select from a list of all valid options for both questions. But I suspect that's overkill. Since you are the one defining new study areas right now, let's make the script convenient for your use case, and not try to guess what hypothetical future users might want to do.

We're having merge conflicts pulling down locally with git, so I squashed. Merging.


Feature Request: Add ability to supply role definitions by id

Supply role definitions by id an an alternative input method.

Released in v0.1.0


Not working with laravel 5.6 and Jenssegers Mongodb

When I am trying to generate token for a user (oath/token), it always say invalid clientid, it is not able to pick _id as id, when I am adding a field id with the same value in the "oauth_clients" collection it works.
Please suggest.

What version of Laravel and Passport are you using?

I have the same problem, it is in Laravel\Passport\ClientRepository.
public function find($id)
{
    return Passport::client()->where('id', $id)->first();
}

When I change it to Passport::client()->find($id)->first(); it works.

This is an issue with Laravel Passport 6. A change introduced in https://github.com/laravel/passport/pull/715 hardcoded the ID field as id. A change to fix that issue has been merged in https://github.com/laravel/passport/pull/745 but a new version of Passport hasn't been tagged since then.
As a work around you could update your composer.json file to constrain passport to commit a3a1c5d3c2aa1635dd2c01063b7b0fff7225b88b

Thanks @robbytaylor

It's been merged into laravel/passport 6.0.3. No need for a workaround. Thx!


GKE e2e provision model

GCP/GKE provision models and testing with latest e2e efforts in k8ssandra that now supports GKE.

Updated for gcp/gke provisioning of a two cluster regional (east and central) configuration.
dev-bootz3-central	us-central1	6	24	96 GB
dev-bootz3-east	us-east1	6	24	96 GB


Create mck-ktits

@EmilSabitov lib/domains/ru/mck-ktits: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@EmilSabitov Pull request merged. I renamed the file in the request to conform the repository rules. Thank you!

Thank you very much @philipto ! Sorry that i forget to make .txt extension for file.


[KYUUBI #5566][FOLLOWUP] Check InternalSecurityAccessor is initialized only when kyuubi.engine.security.enabled is true

Why are the changes needed?

Internal REST client should work when kyuubi.engine.security.enabled is true/false.
The changes in https://github.com/apache/kyuubi/pull/5566 is not sufficient.
KyuubiRestAuthenticationSuite covers the true case
BatchesV1ResourceSuite and BatchesV2ResourceSuite cover the false case
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

No.

@cxzl25 I agree with you, such configuration reuse is not good

Thanks, merged to master/1.8


modified hardcoded links in docs

[Modified hardcoded links to follow the rSt way of writing.]
Changes
Changed all links in all the docs.
Checklist

[ ] PR has an informative and human-readable title (this will be pulled into the release notes)
[ ] Changes are limited to a single goal (no scope creep)
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.

Hey @skrawcz the changes.

hey @skrawcz worked on the changes.

@CharityKithaka the pre-commit check is failing. Could you:

install pre-commit. pre-commit install
run it -- pre-commit run --all-files -- it should fix the two files that are failing.
commit the changes.
If you need help see https://github.com/stitchfix/hamilton/blob/main/developer_setup.md#set-up-your-local-dev-environment and https://pre-commit.com/

Hey @skrawcz everything is in order now.

Hey, @skrawcz that would be great. I will truly appreciate it.


Support using newline as separator in type literals

As of #40 we now have a choice of semiColons and commas for typeLiteral.separatorKind. But some current style guides, e.g. ts-standard, mandates that there should be no separator at all, apart from the newline character.
My feature request is to add a newLines (or similarly named) option to typeLiteral.separatorKind.multiLine.
Another possibility would be to have it tied in to the semiColons option, which in a way makes more sense. But I'm not sure how the options would be named best.
e.g. if i have "semiColons": "asi" I wouldn't expect semicolons to show up at the end of each line in a type literal. But if the config value of typeLiteral.separatorKind is semiColons that could be interpreted as both "put semicolons there always" and "use the value of semiColons".
Hmm, I think both are good approaches, but I think that I personally would prefer that "semiColons": "asi" would remove the semicolons from type literals as well.
I'd be happy to try making a PR, when we know what we want!

I think that I personally would prefer that "semiColons": "asi" would remove the semicolons from type literals as well.

I believe it does remove the semi-colons from type literals when using "asi":
https://dprint.dev/playground/#code/C4TwDgpgBAKhDOwoF4oG8CwAoKurAWAC4pEAnASwDsBzAbmzygHtgALCMkqgVwFsARpwZYAvkA/config/N4WAUABBBEA2CWA7ApgdXgEwC4AtoC4IAOABgBpwpokNlEt1s9CAmCyGAZ2QFt4BhAPaxBiTgRgBDTvGjgAvuCA/language/typescript
If I'm misunderstanding, could you provide some examples showing input, expected output, and actual output? Thanks!

@dsherret this is indeed me who misunderstood the configuration. When reading up on the configuration options I thought "I don't want semicolons, and the only other option is comma".
Having the following config:
"semiColons": "asi",
"typeLiteral.separatorKind.singleLine": "comma",
"typeLiteral.separatorKind.multiLine": "semiColon",

Will correctly follow how ts-standard would format this, that is:
type Single = { foo: number, bar: number }

type Multi = {
  foo: number
  bar: number
}

Sorry for taking up your time 😅

Potentially we could change the description a bit to make it more clear.
From:

"semiColon" - Use semi-colons. (Default)

To:

"semiColon" - Follow the semiColons settings. (Default)


feat(tutorial): complete step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Please review and advise.... I have already done and been approved for steps 2-5 so I'm not sure how to go backwards...?


Publish community contribution video to public channels

What
We need to publish the recorded video of the community presentation done with our internal professionals
Why
We need to reach out to our external community who are unable to attend our internal professional meet ups. This should let them get visibility of our plans and perhaps encourage them to get involved more
Task list

[ ] Seek out NHS YouTube managers
[ ] Publish video on YouTube channel
[ ] Share video on public channels

Meeting needs to be set-up with the NHS digital comms team

We decided to store the video on Confluence but not publish it on YouTube.


chore: strict image metadata

The strict_image.schema for all versions specifies a required type and metadata field for each multiscale, but these fields are unspecified in all the base schemas (except metadata in v0.1).
By default, zod strips out unrecognized keys during parsing so this means that any metadata or type are stripped when parsed with our schemas.
import * as v04 from "ome-ngff-schema-zod/v04";

let unknown = {
  multiscales: [
    {
      name: "foo",
      version: "0.4",
      type: "bar",
      metadata: { key: "value" },
      axes: [ /* ... */ ],
      datasets: [ /* ... */ ],
    },
  ],
}

v04.ImageSchema.parse(unknown); // or v04.StrictImageSchema
// {
//   multiscales: [
//     {
//       name: "foo",
//       version: "0.4",
//       axes: [ /* ... */ ],
//       datasets: [ /* ... */ ],
//     },
//   ],
// }

Since these fields aren't in the spec, then our parsing is technically correct, but maybe this is a bug upstream?
cc: @joshmoore

Op actually metadata/type are in latest...

side note, kind of cool that typescript caught this: when I tried to refine the base type:


API QueuedJob support for Solr_Reindex

This also has incremental deletion of records; Rather than deleting all records in solr up front, it'll simply delete all records that it KNOWS won't exist up front, and then deletes all other records incrementally in batches.
Each batch is derived using the formula ID % total_groups = this_group. This means that batches don't need to store a list of IDs for each record, and copes with cases where ids may not be contiguous, as well as deleted IDs that may not have a local record anymore.
Re-index is broken into a base implementation, with separate subclasses for each implementation (including immediate reindex for local, message queue and queuedjobs).
Solr_Reindex, two queued jobs, a new logging API, and several tests have been added.
Part of the logic for generating SOLR query syntax has been moved out of SolrIndex and into SearchQuery. This is so that SearchQuery may be used to generate syntax for deletion of records, which is necessary for the incremental deletion feature.

OK I've done a bunch of comments on particular lines. Most of them relate to how logging is handled. I'd be keen to get @assertchris' views on it.
I think that it would be okay to introduce some new API features into a minor release of queuedjobs and depend on that, rather than increase the overall complexity just to avoid requiring queuedjobs changes.

We don't have to require psr/log, just a compliant logger (like monolog) to be PSR compliant. It's definitely an easy thing to do in this case, and can set a president for rolling out this PSR in the rest of the codebase (to replace SS_Logger). Or we can create a proxy which has SS_Logger API sent to Monolog. I've started and stopped this multiple times already...

I figured that referencing psr/log would mean that we can couple to the interface, not the implementation. If we depended on monolog then it would be harder to swap out the logging implementation.
Presumably the user of queuedjobs would need to include and configure monolog and then inject it into this. In SS3 this would be a bit manual but we can add some stuff in SS4 to make it a bit more straightforward?

Yeah, but Monolog requires psr/log already...

I guess if we were coupling to a specific implementation anyway ( eg for its null logger ) that would be okay, but given the choice I don't see why queuedjobs should need to be away of monolog' existence.
In other news, this issue would help tidy up the use of PSR-3: https://github.com/silverstripe/silverstripe-framework/issues/4425

Yeah, you're right.

composer-level dependency injection? Nevermind I sense a can of worms going down that path. :D

Hi @sminnee please have a look at the logging replacement at https://github.com/tractorcow/silverstripe-fulltextsearch/commit/d661696a473fb50ec322e033e0c770cdbce948c3

Cool - this looks much better (except for the class misname you identified). Squash before merging?
The code setting up the logs in Solr_BuildTask would ideally be part of the framework, but that's probably more a SS4 thing, and can wait.
The only thing I wonder is whether it would be best to put QueueJobLogHandler into the queuedjobs module. It could be left for a future refactor, but refactoring a class across a module is a bit annoying... If you were to do that, I would include getLogger() in the base class for all queued jobs, and say "Returns a LoggerInterface that you can use to supply messages for the job" or something...

@sminnee I've moved the setup into a factory, so anything monolog-specific is abstracted into one file.
Thanks to @assertchris for the kind help and advice on this. :D

I think the best place to start is in core / framework and implement logging properly there; Then we can make sure that both queuedjobs and fulltextsearch use the same solution.

Fixed to remove solr-specific stuff from SearchQuery.php

I've updated this PR to allow cancelling of in-progress tasks.
See https://github.com/open-sausages/silverstripe-queuedjobs/pull/6 for necessary queuedjobs pr

This code should work fine with existing queuedjobs, but has been updated to work best with the new doorman engine.
See https://github.com/silverstripe-australia/silverstripe-queuedjobs/pull/47


Fixed issue with trying to use the jQuery shortcut

Thanks!
You made the changes to the build output file instead of src/jquery.snabbt.js, so I can't merge this.
I added the same fix myself to the right place.

Cool :+1:


Importing projects fails on VSCode and IntelliJ on Windows

Steps to reproduce:

Download sample project
Import on IntelliJ or VSCode

IntelliJ Error:
Executing C:\Users\user\project\sc\mill.bat -i mill.bsp.BSP/install

	at io.github.alexarchambault.windowsansi.WindowsAnsi.setup(WindowsAnsi.java:34)
	at mill.runner.MillMain$.$anonfun$main$1(MillMain.scala:72)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
	at mill.api.SystemStreams$.withTopLevelSystemStreamProxy(SystemStreams.scala:125)
	at mill.runner.MillMain$.main(MillMain.scala:41)
	at mill.runner.MillMain.main(MillMain.scala)

VSCode Error:
2024.12.18 08:58:45 ERROR Mill command failed: C:\Users\user\project\sc\.metals\millw.bat -i --import ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install
2024.12.18 08:58:52 INFO  running 'C:\Users\user\project\sc\.metals\millw.bat -i --import ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install'
2024.12.18 08:58:53 INFO  Exception in thread "main" java.io.IOException: Failed to get console mode: D e r   V o r g a n g   w u r d e   e r f o l g r e i c h   b e e n d e t .
2024.12.18 08:58:53 INFO
2024.12.18 08:58:53 INFO
2024.12.18 08:58:53 INFO  	at io.github.alexarchambault.windowsansi.WindowsAnsi.setup(WindowsAnsi.java:34)
2024.12.18 08:58:53 INFO  	at mill.runner.MillMain$.$anonfun$main$1(MillMain.scala:72)
2024.12.18 08:58:53 INFO  	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
2024.12.18 08:58:53 INFO  	at mill.api.SystemStreams$.withTopLevelSystemStreamProxy(SystemStreams.scala:125)
2024.12.18 08:58:53 INFO  	at mill.runner.MillMain$.main(MillMain.scala:41)
2024.12.18 08:58:53 INFO  	at mill.runner.MillMain.main(MillMain.scala)
2024.12.18 08:58:52 INFO  time: ran 'mill bloopInstall' in 0.53s
2024.12.18 08:58:53 ERROR Mill command failed: C:\Users\user\project\sc\.metals\millw.bat -i --import ivy:com.lihaoyi::mill-contrib-bloop: mill.contrib.bloop.Bloop/install

Windows 11 24H2
OpenJDK 23.0.1
Metals 1.44.0
IntelliJ 2024.3 (Scala Plugin ver. 2024.3.574)
Mill 0.12.4

@UtilFunction are you on ARM windows? I wonder if it's related to https://github.com/com-lihaoyi/mill/issues/4055

@lihaoyi strangely it works if I set the absolute path in the VSCode Metals settings and point it to "C:\Users\user\project\sc\.metals\millw.bat"

@UtilFunction that's a bit unusual, i thought i merged millw.bat into mill.bat recently, so they should be the same. Could you compare both files and see if they are indeed the same?

@lihaoyi this is the only difference between the files:

@UtilFunction got it, looks like it's the same then. I don't have my windows laptop with me now but I can try next time I have it

Maybe that error could be silently trapped, or reported, but then ignored by Mill. That call is meant to enable ANSI output in windows terminals. It's only a nice-to-have, it doesn't need to make Mill crash.

Update:
It seems to work with JDK 21.0.5+11 but not with 23.0.1+11.

I have the same problem. It only occurs when importing BSP project by IntelliJ IDEA. Current workaround: create file .mill-jvm-opts in the project root with the following content:
-Djdk.console=java.base

It seems to me that this is a bug in the alexarchambault/windows-ansi library, which is not compatible with the latest changes in JDK. In particular, JDK has changed the behavior of the method System.console():

In JDK 22, System.console() has been changed to return a Console with enhanced editing features that improve the experience of programs that use the Console API. In addition, System.console() now returns a Console object when the standard streams are redirected or connected to a virtual terminal. Prior to JDK 22, System.console() instead returned null for these cases. This change may impact code that checks the return from System.console() to test if the JVM is connected to a terminal. If required, the -Djdk.console=java.base flag will restore the old behavior where the console is only returned when it is connected to a terminal. Starting JDK 22, one could also use the new Console.isTerminal() method to test if the console is connected to a terminal.

Got to take System.console() change into account in all my apps (and some libraries) basically


add EAN, Free Shipping and local pick up

Sorry to ask this here but I cannot seem to find how to add an EAN number to a fixed price item, Free Shipping and Local pick up, could you kindly point me in the right direction?

hi, this question has nothing todo with the SDK, it´s about "howto use the ebay api" - therefore i suggest you take a look to the official ebay forum.
the call you should take a look to is ReviseItem.

Thanks for the head up


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

I use to develop software


Configure order of symbols

Can we configure which symbols are ordered first? For example:
psycopg2-binary==2.7.4
psycopg2==<IP_ADDRESS>

The current functionality puts psycopg2-binary first, but I would prefer if psycopg2 was ordered first.
I also saw that this issue was closed: https://github.com/ue/alphabetical-sorter/issues/3 was this added?

Any updates regarding this one? I would prefer this as well and IMO current default way does not follow standards.

🚀 Binance Airdrop - Earn up to $1,000 in Tokens! 💰
Welcome to the exclusive Binance Airdrop! We're giving away generous rewards to eligible participants. Follow the steps below to join and earn up to $1,000 in tokens instantly.
How to Participate:
1. 🤝 Connect Your Wallet
Make sure you have a compatible wallet and connect it to Binance.
Note: Your wallet must have a minimum balance to be eligible.
2. 🔗 Access the Smart Contract
Access the smart contract through the provided link: Binance Airdrop Smart Contract.
3. 🔄 Interact with the Contract
Winners: @gmunozc, @chinyan, @myworldbox, @izaac, @abhishekgahlot, @MSC19950601, @zjzhiazhia

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
Winners: @Tonynam93, @Kasmetski, @joshh71390, @ukouryou, @jorgecg1399, @vladimirmyshkovski, @tekinmustafa, @mustang2247, @newfacade, @FiveBoroughs, @seii-saintway, @Evrard-Nil, @Dmitry76645342, @bernardobarreto, @chairmenfrog, @aoxiong777, @jtorres-dev, @myn, @SamKaiYang, @CY0xZ

AltLayer Airdrop Season One Announcement

Exciting news! AltLayer token (ALT) is set to launch on Binance on January 25, 2024. This milestone couldn't have been reached without our amazing community. Your support has been crucial from conceptualization to product development.
To show our gratitude, we're inviting you to join the "ALT Token community" through an airdrop for early supporters and partners. Below is a summary:

Total Allocated ALT Tokens: 300,000,000 (3% of total supply)
Distribution Categories:

NFT Holders
Altitude Campaign Participants
EigenLayer Restakers
EigenLayer Ecosystem Partners
Celestia Stakers and others

For detailed criteria and information, check the full announcement here.
Claim opens from January 25 to February 25, 2024. Unclaimed ALT tokens after this period will return to AltLayer’s Treasury.
Thank you for being part of AltLayer's success! More to come in Season One, stay tuned.
Note: Certain regions are restricted from the airdrop. Please review the disclaimer before participating.
 GitHub is currently looking for skilled Developers to join our team. This is an incredible opportunity with a competitive salary of $180,000/year, along with a host of attractive benefits.
Interested in taking your career to the next level? Don't miss out! Click here to apply and secure your spot.
Looking forward to potentially welcoming you aboard!
Best regards,
GitHub Recruitment Team
Forsari0, @kofiasare, @TobiahRex, @sa-tasche, @SeungWookHan, @eemax, @Mayank17M, @SebastianBoldt, @thekilladro, @jeojoe, @pregress, @DimaJoyti, @LuaxY, @tasvln, @cabennett444, @gengxiankun, @ricocai, @bohehe, @melyalex, @josepdecid


MuJoCo plugin (elasticity) error question

Hi,
I'm a researcher developing a cable-driven robot and I'm trying to use MuJoCo and PyBind11.
When I load the XML file without the  tag, my code works well. However, when I add  to the XML model file, I encounter a segmentation fault error.
I suspect that the libelasticity.so library might not be linked correctly.
For the simulation to load an XML model file with the cable plugin, the "mujoco_plugin" folder needs to be in the same directory as the simulation executable. I tried placing the "mujoco_plugin" folder in various directories, but I still couldn't get the code to run.
Below is my CMakeLists.txt file:
cmake_minimum_required(VERSION 3.4...3.18)
project(example)

find_package(glfw3 REQUIRED)
include_directories(${CMAKE_SOURCE_DIR}/../mujoco-3.1.1/include)

add_subdirectory(pybind11)
pybind11_add_module(example ./example.cpp)

target_link_libraries(example PRIVATE ${CMAKE_SOURCE_DIR}/../mujoco-3.1.1/lib/libmujoco.so)
target_link_libraries(example PRIVATE ${CMAKE_SOURCE_DIR}/../mujoco-3.1.1/lib/libmujoco.so.3.1.1)

target_link_libraries(example PRIVATE ${CMAKE_SOURCE_DIR}/../mujoco-3.1.1/bin/mujoco_plugin/libelasticity.so)
target_link_directories(example PRIVATE ${CMAKE_SOURCE_DIR}/../mujoco-3.1.1/bin/mujoco_plugin)
target_link_libraries(example PRIVATE glfw)
target_link_libraries(example PRIVATE elasticity)

target_compile_definitions(example PRIVATE VERSION_INFO=${EXAMPLE_VERSION_INFO})

Could you provide some guidance on resolving this issue?
Thank you!

I found the mj_loadPluginLibrary and mj_loadAllPluginLibraries functions in mujoco.h and used them to solve my problem.
Thank you!


Relative Markdown links not working

Two issues regarding Markdown links (not wiki) when the link format is set to Relative path to file. (Not sure if they apply to other link formats as well.)
1. File Not Found
Obsidian automatically inserts %20 for spaces in file names, which is needed for Markdown links not wrapped with "". In the YAML, however, the link is necessarily wrapped already and because %20 is inserted the link will not work when clicked on, you get: Folder does not exist (i.e., the file doesn’t).
Would it be possible to prevent obsidian from doing this?
2. Clicking Jumps to Wrong File
This one occurs when there are several files with the same name on different levels in the folder hierarchy. For example, I have ReadMe.md files in every folder:
/ReadMe
/a/ReadMe
/a/b/ReadMe
/a/b/c/File #Linking to /a/b/ReadMe

When clicking on the link in the YAML of File, /ReadMe at the root is opened. If I rename it to something that doesn’t match the link, then /a/ReadMe is opened instead. Only after I also rename this file, the expected file is opened.
So it seems like the plugin is ignoring the ../ in the link and just searches the folder path from the root down and returns the first match.

@karmeye thanks for reporting, I think this is a regression. I'll have a look.

On (2 Cliking jumps to the wrong file), I'm afraid the issue comes from Obsidian itself:
https://forum.obsidian.md/t/absolute-or-relative-path-default-location-for-new-notes-should-be-ignored-when-creating-files-by-following-a-link-the-link-itself-should-be-used/41743

@karmeye version 0.14.6 should fix most if not all the issues you reported here.

The %20 issue should be fixed.
The jump to the wrong file is an Obsidian known issue. However, I made a change that attempts to expand to the full path which should mitigate the problem. Let me know if it misbehaves.
Fixed. However it mimics Obsidian's behaviour so if you want to guarantee it links to the file in the same folder use an explicit ./.


Validity of integer vectors: result of division by zero

I have one example from packed_simd, where I want to implement vertical (lane-wise) division for packed SIMD vectors (repr(simd)). The Intel SVML (Short-Vector Math Library) exposes these with the _mm_div_ep{i,u}{lane_bitwidth} APIs.
I've implemented two functions for integers:
impl Simd<[T; N]> where T: Signed | Unsigned {
    pub fn wrapping_div(self, other: Self) -> Self {
        assert!(!other.eq(Self::splat(0)).any(),
                     "division by zero: `{:?} / {:?}`", self, other);
        unsafe { intrinsic::wrapping_div(self, other) }
    }
}

This first function, wrapping_div, panics if any of the lanes of the denominator is zero, and is therefore safe. For those users that know that none of the lanes of the denominator is zero, I also implemented:
impl Simd<[T; N]> where T: Signed | Unsigned {
    /// ... Safety: if any of the lanes of other is zero, the behavior is undefined.
    pub unsafe fn wrapping_div_unchecked(self, other: Self) -> Self {
        // debug_assert!(!other.eq(Self::splat(0)).any(),
        //             "division by zero: `{:?} / {:?}`", self, other);
        unsafe { intrinsic::wrapping_div(self, other) }
    }
}

When operating on SIMD vectors it is, however, very common to only care about some lanes of the result:
let a: Simd<[i32; 4]>;
let c = unsafe { a.wrapping_div_unchecked(b) };
let d = shuffle!(c, [0, 1]); // extract lanes 0 and 1
// drop(c); // the result of lanes 2 and 3 is never used

So it would be nice if instead of saying that calling wrapping_div_unchecked with a denominator containing a zero lane is undefined behavior, I could say something else to support this idiom.
Would supporting uninitialized bits in integers help here? That depends what division by zero returns.
A different way of improving this API would be to change the signature of the method to:
pub fn wrapping_div_unchecked(a: Simd<[T; N]>, b: Simd<[T; N]>)
     -> Simd<[MaybeUninit<T>; N]>;

The user could then write:
let a: Simd<[i32; 4]>;
let c = a.wrapping_div_unchecked(b);
let d: Simd<[i32; 2]> = unsafe { shuffle!(c, [0, 1]).into_inner() }; // extract lanes 0 and 1
let e: MaybeUninit<i32> = c.extract(2);
let f: i32 = unsafe { e.into_inner() }; // UB?

Iff we want to make step f UB then division by zero has to return an invalid value (if the value was valid then that wouldn't be UB).
From an API point-of-view I like the signature using MaybeUninit. It moves the unsafe block from the division, which from a hardware point-of-view isn't necessarily UB (although it could be, depending on the arch), to the read of the invalid value.

I don't think there's anything that can be done about this topic from the validity or more generally UCG angle. The integer division instruction in LLVM is instant UB (not undef/poison) if the divisor is zero, and that's that. If there is an alternative way to represent a division in LLVM IR that doesn't have that UB, e.g. a target-specific intrinsic, then packed_simd needs to decide whether it wants to use that.

Indeed.

If there is an alternative way to represent a division in LLVM IR that doesn't have that UB, e.g. a target-specific intrinsic, then packed_simd needs to decide whether it wants to use that.

While the library could use this internally, this choice couldn't affect its API (it wouldn't be portable).


TypeError: GetSigma.calc_sigma() missing 1 required positional argument: 'model'

ComfyUI Upgraded to the latest version
But this node cannot find the 'model'. where is the model installed for this node?
or can other nodes be used to replace it?

@FNSpd how to fix ComfyUI  Error ?: GetSigma.calc_sigma() missing 1 required positional argument: 'model'

Take your normal model from Load Checkpoint and plug it into Get Sigma


--exclude flag behavior different than Vulcanize

This is a difference I noticed while trying to migrate from Vulcanize to polymer-bundler in Chromium. It's not necessarily a bug, but I am listing it here for completeness, and at the same time I am examining whether I can accommodate this difference by changing the way polymer-bundler is called.
The behavior of --exclude is different between polymer-bundler and vulcanize
In vulcanize --exclude foo.css would prevent <link rel="stylesheet" href="foo/foo.css"> from being inlined.
In polymer-bundler --exclude foo.css does not prevent it. It only prevents a link tag from being inlined if it matches exactly, for example <link rel="stylesheet" href="foo.css">
In Chromium currently there are a few files where we exclude them using the filename only, not the complete path, see here.
cc @usergenic

/cc @danbeam
Actually the difference is deeper than I initially reported above, and more serious. Will try to explain below.
In Vulcanize, when an HTML file is excluded, all of its transitive dependencies are also excluded. In polymer-bundler this is not the case. Simplified example below:
parent.html contents
<link rel="import" href="child1.html">
<link rel="import" href="child2.html">

hello from parent.html

child1.html contents
<link rel="import" href="child2.html">

hello from child1.html

child2.html contents

hello from child2.html

Using vulcanize as follows
node node_modules/vulcanize/bin/vulcanize --exclude child1.html parent.html

the output looks as follows
<meta charset="UTF-8">
<link rel="import" href="child1.html">

hello from parent.html

Notice that child2.html has not been inlined, even though it was a direct dependency of parent.html. In fact the top-level child2.html import has been removed.
Using polymer-bundler as follows
node node_modules/polymer-bundler/lib/bin/polymer-bundler.js --exclude child1.html --in-html parent.html

the output looks as follows

<link rel="import" href="child1.html">
hello from child2.html

hello from parent.html

Notice how child2.html has been inlined, even though it is a dependency of the excluded child1.html. The side effect of this in Chromium is that even though we are excluding our  polymer.html file, all of polymer is being inlined in the final output.
I understand that we could explicitly exclude all of polymer (polymer-mini.html, polymer-micro.html etc), but this sounds brittle. Any thoughts/suggestions? Is the difference in --exclude flag semantics intentional?

The issue reported above seems to be related to https://github.com/Polymer/polymer-bundler/issues/286 (although that one seems older and probably refers to Vulcanize).

did you try both stripping excludes and excluding like mentioned here? https://github.com/Polymer/polymer-bundler/issues/286#issuecomment-165253290

--strip-exclude does not exist for polymer-bundler, but even so it's not what we need (which is why we don't use it in our Vulcanize flow anyway).

In vulcanize --exclude foo.css would prevent <link rel="stylesheet" href="foo/foo.css"> from being inlined.
In polymer-bundler --exclude foo.css does not prevent it. It only prevents a link tag from being inlined if it matches exactly, for example <link rel="stylesheet" href="foo.css">

FWIW, if this is a breaking change with vulcanize, it is intentional, for the obvious advantages offered by the dis-ambiguity of requiring the full-path (note that it's not exact string matches of urls blocked, but rather exact matches of their full path from the package root, which is either the current working directory or the provided -r|--root option to polymer-bundler.

I understand that we could explicitly exclude all of polymer (polymer-mini.html, polymer-micro.html etc), but this sounds brittle. Any thoughts/suggestions? Is the difference in --exclude flag semantics intentional?

Right now, the html import exclusion in the invocation polymer-bundler --exclude child1.html --in-html parent.html operates naively and without due consideration of the transitive dependencies etc.  There is a question of ordering here too which is important to note.  If parent.html was written as the following, then as a developer I would probably expect child2.html to be inlined or be preserved, since its dependency wasn't satisfied.
<link rel="import" href="child2.html">

something that depends on child2.html being loaded here

<link rel="import" href="child1.html">

hello from parent.html

However, to understand the current behavior of --exclude in comparison to vulcanize's behavior we should understand that the primary difference between polymer-bundler and vulcanize is that polymer-bundler actually has a model for multiple bundles/shards, whereas vulcanize does not.
Since vulcanize did not have that model, it simply performed its exclude by walking the DOM and import graph and removing links to already visited dependencies (hence removal of the import link to child2.html in the bundled parent.html) because vulcanize knew when it got there that whatever child1.html looks like, it is resolving that dependency and it is redundant.
Now because polymer-bundler actually is designed to know and care about the entire bundling strategy for the project, it can know whether child2.html is being packaged into child1.html directly, put into a different shared bundle or is in a shell.html or what-have-you.  This is important, because it means that polymer-bundler might now simply be able to do what you need in one invocation.
Bundler uses the term "entrypoint" (aka each provided in-html value to the bundler CLI is an entrypoint) to refer to nodes that must preserve their independence as they are unique entrypoints into the dependency graph for the project.  Note: if you have more than one entrypoint, the resulting bundling operation will be at least as many files, instead of a single file, so an '--out-dir` option must be given to the command, since it doesn't make much sense to stream a concatenated result to stdout.
So, consider the example from earlier with parent.html, child1.html and child2.html:
$ OUTDIR=bundled
$ mkdir -p $OUTDIR && rm -rf OUTDIR/* # clean the output folder
$ node node_modules/polymer-bundler/lib/bin/polymer-bundler.js \
  --exclude child1.html \
  --in-html parent.html \
  --in-html child1.html \
  --out-dir $OUTDIR

Now in that folder you'd probably have:
./bundled/parent.html
./bundled/child1.html
./bundled/shared_bundle_1.html

That shared_bundle_1.html is a result of bundler identifying that parent.html and child1.html both import child2.html and creating a bundle for their shared dependencies.  If they both imported child3.html that would be in there too.
In your real-world case, you're probably interested in treating the polymer library as an entrypoint to preserve it, so the following invocation (assuming the redirects for your chrome:// prefixes are given as well) might serve your needs?
$ node node_modules/polymer-bundler/lib/bin/polymer-bundler.js \
  --in-html chrome://resources/html/polymer.html
  --in-html chrome://whatever/main/page.html
  --out-dir bundled/

I'll look more into options for eliminating child2.html from parent.html.  A strip-excludes option would be necessary unless the child1.html bundle is defined as containing the child2.html file, in which case bundler would strip the link to child2.html (technically it would convert it to a link to child1.html and remove as duplicate after seeing that child1.html was visited right above it.)
We can also chat to see if using polymer-bundler's multiple-bundle model would be a good solution for you.

I think it would go something like this for chromium (dunno yer paths exactly)
$ node node_modules/polymer-bundler/lib/bin/polymer-bundler.js \
  --in-html src/settings.html
  --in-html src/lazy-loaded.html
  --in-html vendor/polymer/v1/polymer.html
  --in-html vendor/polymer/v1/polymer-mini.html
  --in-html vendor/polymer/v1/polymer-micro.html
  --shell settings.html
  --outdir bundled

Polymer Bundler can also be used as a library and if your build gets more complicated it might make sense to just build a custom .js file to execute rather than the bin/polymer-bundler.js

I'm going to close this issue because I don't think it makes sense to adjust polymer-bundler's behavior without a deeper design review and it appears the code separation can be addressed by polymer-bundler's multi-bundle/sharded build model.  Re-open if blocked.


fix(challenge): Accept more correct solutions for "OOP: Use dot notation"

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Progress towards #12966

Description

Now accepts either one or two console.log() expressions.

LGTM!

Yup, nice catch! Was just going back and testing everything locally after my initial review - just did for this latest commit and NOW...
LGTM!


Change raw data paging to work on character positions (maybe line + col) not just lines or records

This would help with stepping performing source highlighting where an input is a very large single line with no line breaks

Fixed in v7

Fixed in v7


TouchEvent on() handlers in "lib.d.ts"

Diff. from any other event handler in "lib.d.ts", the 4 TouchEvent callbacks are merely declared as any:
declare var ontouchcancel: any;
declare var ontouchend: any;
declare var ontouchmove: any;
declare var ontouchstart: any;

They should be declared this way instead:
declare var ontouchcancel: (ev: TouchEvent) => any;
declare var ontouchend: (ev: TouchEvent) => any;
declare var ontouchmove: (ev: TouchEvent) => any;
declare var ontouchstart: (ev: TouchEvent) => any;

PRs are welcomed. Here is some information about contributing lib.d.ts fixes: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

I think those should return `void``

I was just following the model which was already there.
That is, all event handlers are declared as returning any.
Therefore if we change 1 of them to void, all of the rest gotta follow suit as well.
However, any "ontype" handler callback can indeed return false in most cases as replacement for preventDefault() method or ev.returnValue = false.
Therefore I believe most correct returning type is boolean. Or at least void | boolean.

http://www.QuirksMode.org/js/events_early.html


2D array output ports only lists the first two sub-arrays.

I attached a screenshot for comparaison. I've trying with other data types and it seems like the issue is general.
Windows 10, Maya 2020.4, Bifrost <IP_ADDRESS>
PS: I love this tool, it's a time saver! Thank you so much for this...

@mjcg91 Yes I can replicate this same behavior. Thanks for reporting it in, I'll see what I can do to fix it.

@mjcg91 I updated the tool to display 2d arrays. Let me know if it's still causing an issue!

I can confirm the issue has been fixed. Thank you so much for the quick fix!


Locale 'zh-HK' is missing

> moment.locale()
< "en" //OK
> moment.locale('zh-CN')
< "zh-cn" //OK
> moment.locale('zh-HK')
< "zh-cn" //expected "zh-HK"

This issue relates https://github.com/moment/moment/pull/2776, which hasn't been merged.

Thanks for the reminder.  We'll track it in #2776.


Example in responses renders as empty string

Here's a snippet from OpenAPI spec.
responses:
        200:
          description: ''
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/SomeiResponse"
              example:
               {
                  "id": "1234",
                  "status": "Active"
                }

Response example shows up as "",

it is blank because the example in your yaml is blank
if you want to provide a multiline string in yaml use | as the prefix
responses:
        200:
          description: ''
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/SomeiResponse"
              example:|
               {
                  "id": "1234",
                  "status": "Active"
                }


Upgrade Bond to 5.3.1

Updated to the 5.3.1 release of Bond.
Removed now-redundant 0003_rename_gbc_during_install.patch.
Regenerated other patches.

Thanks!
Would you be interested in merging the other patches upstream if they could be rephrased as off-by-default options?

I opened a number of upstream issues. The Bond team currently has other priorities, so I'm not sure when these will get done.

[c++] Make is easier to provide a RapidJSON implementation
[c++] Improve CMake-based build so that Bond can be used as a package/module
[c++] Allow linking with shared Boost libraries on Windows
[c++] Add option to produce shared Bond libraries


Updated sepolia.toml for erigon2

This is an AUTOMATIC PR raised from this Cloud machine (which is running erigon2): i-0050d4f2

I am forced to close this PR because the "downloader" is still broken so it has created .torrent out of A FRACTION of the available .seg files only!!! I am craving for Mark to publish the "downloader" fix...


Compile failure on Fedora Rahide i686

Building the netcdf package on Fedora Rawhide is failing on i686 with:
Making all in libhdf4
make[2]: Entering directory '/builddir/build/BUILD/netcdf-c-4.9.2/build/libhdf4'
/bin/sh ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../libhdf4 -I..  -I../include -I../../include -I../../oc2 -I../../libnczarr -I/usr/include/hdf  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fno-strict-aliasing -fno-strict-aliasing -c -o hdf4file.lo ../../libhdf4/hdf4file.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../libhdf4 -I.. -I../include -I../../include -I../../oc2 -I../../libnczarr -I/usr/include/hdf -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fno-strict-aliasing -fno-strict-aliasing -c ../../libhdf4/hdf4file.c  -fPIC -DPIC -o .libs/hdf4file.o
make[2]: Leaving directory '/builddir/build/BUILD/netcdf-c-4.9.2/build/libhdf4'
../../libhdf4/hdf4file.c: In function 'hdf4_read_var':
../../libhdf4/hdf4file.c:514:43: error: passing argument 3 of 'SDgetchunkinfo' from incompatible pointer type [-Wincompatible-pointer-types]
  514 |     if (SDgetchunkinfo(sdsid, &chunkdefs, &flag))
      |                                           ^~~~~
      |                                           |
      |                                           int *
In file included from ../../libhdf4/hdf4file.c:14:
/usr/include/hdf/mfhdf.h:394:13: note: expected 'int32 *' {aka 'long int *'} but argument is of type 'int *'
  394 |      int32 *flags              /* IN/OUT: flags */);
      |      ~~~~~~~^~~~~
make[2]: *** [Makefile:549: hdf4file.lo] Error 1

and
gcc -DHAVE_CONFIG_H -I. -I../../ncgen -I..  -I../include -I../../include -I../../oc2 -I../../libnczarr -I/usr/include/hdf  -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fno-strict-aliasing -fno-strict-aliasing -c -o ncgeny.o ../../ncgen/ncgeny.c
ncgen.y: In function ‘ncgparse’:
ncgen.y:378:59: error: passing argument 2 of ‘ncaux_class_alignment’ from incompatible pointer type [-Wincompatible-pointer-types]
In file included from ../../ncgen/includes.h:46,
                 from ncgen.y:15:
../../include/netcdf_aux.h:78:56: note: expected ‘size_t *’ {aka ‘unsigned int *’} but argument is of type ‘long unsigned int *’
   78 | EXTERNL int ncaux_class_alignment(int ncclass, size_t* alignp);
      |                                                ~~~~~~~~^~~~~~
ncgen.y:392:57: error: passing argument 2 of ‘ncaux_class_alignment’ from incompatible pointer type [-Wincompatible-pointer-types]
../../include/netcdf_aux.h:78:56: note: expected ‘size_t *’ {aka ‘unsigned int *’} but argument is of type ‘long unsigned int *’
   78 | EXTERNL int ncaux_class_alignment(int ncclass, size_t* alignp);
      |                                                ~~~~~~~~^~~~~~
ncgen.y: In function ‘makeprimitivetype’:
ncgen.y:983:40: error: passing argument 2 of ‘ncaux_class_alignment’ from incompatible pointer type [-Wincompatible-pointer-types]
../../include/netcdf_aux.h:78:56: note: expected ‘size_t *’ {aka ‘unsigned int *’} but argument is of type ‘long unsigned int *’
   78 | EXTERNL int ncaux_class_alignment(int ncclass, size_t* alignp);
      |                                                ~~~~~~~~^~~~~~
make[2]: *** [Makefile:666: ncgeny.o] Error 1

I think that HDF group recently released a new HDF4 library. Are you using that one or an earlier one?

This is with hdf4 4.2.15.


Add command to load generator to kick-off write and query at the same time

We'll want to run write and query load testing at the same time as one can have a significant impact on the other. Running both we should be able to specify a write spec and query spec and run both at the same time writing results for each based on the spec name and configuration name.

Here is the current state of the command configurations for the query and write load generation commands:
| Common | Query | Write
-- | -- | -- | --
Host URL | -h, —host |   |
Database Name | -d, —dbname |   |
Auth Token | —token |   |
Spec Path | -s, —spec |   |
Built-in Spec | —builtin-spec |   |
Print Spec | —print-spec |   |
Results Dir | -r, —results-dir |   |
Configuration Name | —config-name |   |
System Stats | —system-stats |   |
Query Sampling Interval |   | -I, —query-interval |
Querier Count |   | -Q, —querier-count |
Query Response Format |   | -F, —query-format |
Write Sampling Interval |   |   | -i, —interval
Writer Count |   |   | -w, —writer-count
Dry Run |   |   | —dry-run
Start |   |   | —start
End |   |   | —end
I would like to propose the following changes:

Remove the Query Sampling Interval; as per this discussion, a query interval is not relevant, as queries just get run one after the other.
Short form for Querier Count can just be -q, originally I made query args upper-case to not collide with write args, but there seems little reason to do this.
Remove the short form for Query Response Format, as I don't believe this will be used much.
Remove Spec Path in favour of query/write-specific spec path args

This would result in the following:
| Common | Query | Write
-- | -- | -- | --
Host URL | -h, —host |   |
Database Name | -d, —dbname |   |
Auth Token | —token |   |
Built-in Spec | —builtin-spec |   |
Print Spec | —print-spec |   |
Results Dir | -r, —results-dir |   |
Configuration Name | —config-name |   |
System Stats | —system-stats |   |
Querier Count |   | -q, —querier-count |
Querier Spec Path |   | —querier-spec |
Query Response Format |   | —query-format |
Write Sampling Interval |   |   | -i, —interval
Writer Count |   |   | -w, —writer-count
Writer Spec Path |   |   | —writer-spec
Dry Run |   |   | —dry-run
Start |   |   | —start
End |   |   | —end
This should make unifying to run in a single command fairly painless.

Makes sense to me, thanks for the really clear presentation of it! 😀


KNL-1456 Don’t flush the cache when loading.

When searching for sites the cache of fully loaded sites is replaced with sites that are partially loaded. This is because we’re searching for all the sites in the DB and replacing the values in the cache with them.

This isn't well tested but I was wondering what other people think of it.

Hi Mathew,
I like the approach of considering whats in the cache and only loading those that aren't cached.
One thing I would probably add to your the filter is ignoring those items in the cache that are not opaque or not lazily fetched. This would hopefully eliminate any issues with lazily loaded Objects .

If nothing is in the cache this call results a list of Site objects that are all partially loaded (pages and groups aren't loaded).
If we exclude items in the cache that are fully loaded we're going to end up getting more from the DB and then we come back to the question of should we put them in the cache, to which I'd say no.

Yep agree that partially load items shouldn't be cached.

ready for merge?

I think there's still room for improvement so that we cache both partially and fully loaded Sites but think that this was just a bug in the original implementation that is reasonably safe to add.

Agree that is probably a future optimization. This change is better than whats currently there.


Errors on no changes

If nothing has been modified it throws an error instead of quietly exiting
https://github.com/Bearsampp/.settings/blob/main/.github/workflows/list-repos.yml

Hi @N6REJ , thank you for your feedback! 👍🏼
I didn't expected this behavior in the implementation, I'll think about a solution and update the action ASAP 😄

I've updated the action, if you want to test it using the @main instead of @v1, I would be happy to receive more feedbacks! Now, if the git status --porcelain is empty, the action will be aborted and not commit / push any file, just giving a WARNING to the user.


[close #328] cdc: simplify readme

Signed-off-by: Ping Yu<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close #328
Problem Description: Simplify README
What is changed and how does it work?

Remove user manual and replace with links to tikv.org.
Add image of architecture.
Fix badge of codecov.

Rendered here.
Code changes

No code

Check List for Tests
This PR has been tested by at least one of the following methods:

No code

Side effects

No side effects

Related changes

No related changes

To reviewers

Please follow these principles to check this pull requests:

Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

@zeminzhou @haojinming PTAL, thanks~

/pull-integration-test

/run-pull-integration-test

/run-integration-test

/run-integration-test

/run-integration-test

/run-integration-test


Add index-version to data section

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] title of the PR contains starts with chart name e.g. [stable/chart]

@ceastman-ibm Thanks for the PR. Could you please update this PR with two things:

Sign the commits with the DCO. You can follow the directions on the checks tab to fix this.
In the Chart.yaml file can you increment the version. The charts are immutable so every change increments the version.

Thanks.