[V.2.0.1] Parent inheritance problem

Please check this: https://codesandbox.io/s/wplNXEN1J
Check .modifier & { underneath.
Using this CSS:
.wrapper {
  background-color: green;
  .modifier & {
    background-color: red;
  }
}

And this JSX:
<Container>

Hello World, this is my first styled component!

  </Container>

const Container = styled.div`
  .wrapper {
    background-color: green;
    .modifier & {
      background-color: red;
    }
  }
`;

Renders this HTML:

Hello World, this is my first styled component!

The CSS is compiled as:
.sc-bdVaJa {}
.YJEIW .wrapper{background-color: green;}
.wrapper .modifier .YJEIW{background-color: red;}

I think the modifier should be: .YJEIW .modifier .wrapper

Which styled-components version are you using?

I'm trying think what should be the correct behavior here.
Going from how sass handles this, since
.modifier & {
color: red;
}
// produces
.modifier .YJEIW{
    color: red;
}

Shouldn't
.wrapper {
    .modifier & {
        color: red;
    }
 }
// produce
.modifier .YJEIW .wrapper

assuming .YJEIW is the enclosing namespace.

@k15a v.2.0.1 (I added to the title).

.YJEIW is the enclosing namespace.
@thysultan Could also be right yes, though that's more a library decision. I believe Sass would always put the modifier within the enclosing namespace, but outside it probably would serve more use cases and would be consistent with how injectGlobal would work.

Btw @ehtb. Not trying to chime in here, but:
I'm not sure what you're trying to achieve here, but .modifier in your example isn't a modifier as in BEM. It's just a separate element class.
Modifiers should use interpolations. No matter whether this is a bug or not, the code you're writing doesn't seem to follow some best practices :wink:

Hi @philpl It is only to illustrate the issue, not to be a real world example.

The way sass handles it looks more consistent across the board of possible uses. i.e would the following
.a{ .b { .c &{ color:red } } }

produce .YJEIW .c .a .b or .YJEIW .a .c .b?
@ehtb Can you give me example cases that one would be to able handle over the other?
.modifier <parents>

vs

.YJEIW .modifier <immediate parent>

vs

.YJEIW .modifier <parents(excluding top-level namespace)>

patterns

Sorry, I should have read the complete issue. I think the current behavior is great because the & acts like a variable for the generated class which is quite reasonable. This way you don't have to think twice how your current selector looks like because & gets replaced with the generated class and if there is no & in the selector the generated class is prepended.

@k15a I agree, I feel that that is the correct behaviour too. I was unsure if the library wanted to render: .YJEIW .modifier .wrapper, or .modifier .YJEIW .wrapper. In the current version this is rendered as .wrapper .modifier .YJEIW, which I think is the actual bug.

patched in stylis 3.1.6, works like it would in scss.

@thysultan awesome :tada:
@ehtb can you confirm, please, that it's now working correctly for you? 😄

@thysultan Great, thanks for the fast fix!
@philpl Just did, can confirm that 2.0.1 with stylis 3.1.6 works. Awesome work!


add "blockchain" to topbar with a dropdown

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind ui-change

What this PR does / why we need it:
add "blockchain" to topbar with a dropdown
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


696 get infectivity is wrong

Changes
Please briefly list the changes made:
see issue
Merge Request - GuideLine Checklist

Check our git workflow before opening a Pull request/Merge request.
Request a reviewer when your work is ready to review, before this please use the draft feature.

Checks by code author

[x] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
[x] New code adheres to coding guidelines
[x] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
[x] Tests are added for new functionality and a local test run was successful
[x] Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
[x] Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

[ ] Corresponding issue(s) is/are linked and addressed
[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
[ ] Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Additional context
Please list additional information or things a reviewer should look out for.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (2f70877) 92.80% compared to head (0c9299c) 92.80%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   92.80%   92.80%
=======================================
  Files         107      107
  Lines        8245     8245
=======================================
  Hits         7652     7652
  Misses        593      593

Impacted Files
Coverage Δ

cpp/models/abm/infection.cpp
91.30% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Fix incorrect INTEGER type in ALTER TABLE COLUMN TYPE example

Fixes https://github.com/questdb/documentation/issues/54.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @Juneezee !!


How to change the output to 44KHz

Hi,
I try to play adlib at 44KHz, but I it play at a lower pitch (normal)
But whatever I put here as parameter, nothing change...
emu8950_opl = OPL_new(OPL_CLOCK, PICO_SOUND_SAMPLE_FREQ);
Do you know what we should do ?

Is OPL_CLOCK 3579545Hz and PICO_SOUND_SAMPLE_FREQ 44100Hz?
If so, please make sure the playback audio rate is 44100Hz in your environment.


Server error during sign up with special character in the username

When trying to register with a username containing . or / (maybe other special characters too), we get this error:

It would be better to have a simple red message like this one:

I don't know if it is linked with the recent email confirmation feature. Maybe it was there already and we missed it.

Related issue: #759


iabbr and imap

I have a lot of biniding for vhdl development like this:

iabbr ;s SIGNAL

imap ;v : STD_LOGIC_VECTOR( DOWNTO 0);4ba

but they are not working. Is there a solution or workaround for this?

Nvim does not control insert mode


Irmin graphql subscriptions

⚠ Experimental! Depends on https://github.com/andreas/ocaml-graphql-server/pull/133 ⚠
This PR updates irmin-graphql to use graphql-cohttp. This change should happen regardless, as graphql_lwt no longer includes a HTTP server. (no longer necessary)
This PR adds the ability to watch the entire store or a specific key with notifications delivered via the GraphQL subscription mechanism (currently only websockets, possibly Server-Sent Events or chunked HTTP responses in the future).
Adding Irmin_unix.set_listen_dir_hook () to cli.ml may be required...

[x] Pending the release of graphql 0.9.0 (PR)

/cc @zshipko

This looks great!
@samoht just merged my graphql-cohttp integration branch so there are a bunch of conflicts, but the subscription related code should definitely be included ASAP.
We're preparing for an irmin release soon, so will have to hold off on merging this until the upstream changes have been published to opam. Definitely keep us updated as things progress, but I will also watch out for the cohttp and websocket-lwt releases!

@samoht just merged my graphql-cohttp integration branch so there are a bunch of conflicts, but the subscription related code should definitely be included ASAP.

Ah, great -- I'll rebase 😄

We're preparing for an irmin release soon, so will have to hold off on merging this until the upstream changes have been published to opam. Definitely keep us updated as things progress, but I will also watch out for the cohttp and websocket-lwt releases!

Sure, will do. Merging this depends on both a new release of cohttp and graphql-cohttp, but I'll keep you posted.

I've updated this PR to be the minimal patch to support websocket based subscriptions based on https://github.com/andreas/ocaml-graphql-server/pull/133.
While making these changes, I noted that having run_server as part of Irmin_graphql.S causes a lot of the complexity. If instead Irmin_graphql.S only allowed creating a value of type Cohttp_lwt.S.Server given a store, then I think a lot of the complexity would go away. This is essentially what I did in this commit<PHONE_NUMBER>ee78e09955169d2eea509df3e09990, which was part of the previous version of this PR. What are your thoughts on that approach? 😄

Thanks!
Yeah, I was looking at your code and like how simple the interface is using only Cohttp_lwt.S.Server rather than the custom SERVER type. That approach seems much less complicated! I am happy to make the changes needed to remove SERVER and create a new PR to review it. How does that sound?

I've rebased on #599 now.

graphql et al v0.9.0 has now been released on OPAM, so this PR is ready for review/merge 🎉
Travis passes for irmin-graphql passes, but irmin-unix is failing for a seemingly unrelated reason:
#=== ERROR while compiling irmin-unix.dev =====================================#
# context     2.0.3 | linux/x86_64 | ocaml-base-compiler.4.06.1 | pinned(file:///home/travis/build/mirage/irmin)
# path        ~/.opam/ocaml-base-compiler.4.06.1/.opam-switch/build/irmin-unix.dev
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p irmin-unix -j 1
# exit-code   1
# env-file    ~/.opam/log/irmin-unix-16226-ffb3fd.env
# output-file ~/.opam/log/irmin-unix-16226-ffb3fd.out
### output ###
#     ocamlopt src/irmin-unix/bin/main.exe (exit 2)
# (cd _build/default && /home/travis/.opam/ocaml-base-compiler.4.06.1/bin/ocamlopt.opt -w -40 -g -o src/irmin-unix/bin/main.exe -I /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/angstrom -I /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/astring -I /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/base -I /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/base/caml -I /home/travis/.opam/oca[...]
# File "_none_", line 1:
# Error: Files /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/digestif/ocaml/digestif_ocaml.cmxa
#        and /home/travis/.opam/ocaml-base-compiler.4.06.1/lib/digestif/c/digestif_c.cmxa
#        both define a module named Digestif_bi

/cc @samoht @zshipko

/cc @dinosaure seems that we are double-linking digestif.

@andreas is there any library where we are using digestif.ocaml and digestif.c while we were supposed to use only digestif ?

Ah this makes sense. I've specified digestif.ocaml as a dependency in graphql-cohttp 😞 I'll update it..


How to load libexample.so at other application?

Hi, @asprecic
I want to compile libexample.so and use hand_pose at my own application not at QT. And how to call the API to do hand pose, do you have a demo code to share?
Thanks in advance.

Compiling libexample.so is the same for any C++ application that you want to use, I just used Qt as it's easiest to demonstrate.
So, just use the header file, and libexample.so, link it, add it to include in whatever you're using, make, cmake or g++/clang CLI itself.
As for a demo, I don't have one, but you can use the mpintegrationexample.cpp as a starting point to see how to use the API, call which functions etc.
The basic jist of it is this:
// Create object
MPIntegrationExample example;
// use setGraph to select which example you want to use (in your case hand pose)
example.setGraph(StyleClass::Graphs::SelfieSegmentation);
// call process to process images one by one
uint8_t* data = m_mp->Process(input_img.data(), input_img.width(), input_img.height());
// pointer data now points to image data of processed returned image, whose width and height is the same as input image

So I'm trying to do something similar in running the example implementation. I'm running this command: "g++ example_impl.cpp -l libexample.so". However I get errors saying that certain mediapipe files don't exist. Is it possible to compile like this, or are there more steps I should be doing?
Any help would be much appreciated, thanks!

You have to use bazel to compile mediapipe, as is written in the step by step guide in both this repo and my forked mediapipe repo.

Sorry for the misunderstanding, but just to clarify, you can't use clang/make/etc by itself with libexample.so(generated with bazel). You need to generate libexample.so and then use bazel to run mediapipe?

Libexample.so should be compiled statically and everything should be self contained in there. You can run ldd libexample.so to confirm.
If you check the qmake (.pro file) in this repo, you can see that I am simply linking against libexample.so and nothing else.
Also, in your previous command, did you include the corresponding header files for libexample?
Can you post exactly what mediapipe files are missing?

The header file is in mediapipe/examples/desktop/libexample/example.h
Libexample.so and example.h should be the only thing you need

Yah I included the corresponding file header, these are the files missing:
#include "absl/status/status.h"
#include "mediapipe/framework/calculator_framework.h"


List breaks if enter todo items with same content.

We cant use index of items as key because this is not item UID here. Also we can't use todo text as key because it is not unique. Shouldn't we implement some ID, hash, timestamp or something like this?

Yes we should!
I've been thinking about this and I regret not doing this from the start. Whatever we do, we'll need to have a migration strategy (my wife's already spent time entering in a bunch of todos). Ideas?

@kentcdodds so we could implement migration handler for store reading or smth like that. I'll think about it

:+1:


1.1.0h -> lost quotes in c_rehash

Since #5533 the c_rehash here has no quotes which were specified in "quotify1":
my $dir = {- quotify1($config{openssldir}) -};
my $prefix = {- quotify1($config{prefix}) -};
See Debian bug 894282. I reverted commit
77ba00bc3b7a ("util/dofile.pl: only quote stuff that actually needs quoting")
to around it. Any idea?
Sebastian

Yeah, it's horribly broken. The backslash-escaping only escapes things which need escaping inside double quotes, and assumes that anything which doesn't need any backslashes also doesn't need quote, but that's not true. Forward slashes don't need to be escaped, but either mean a search pattern or division, based on whether they are at the start of the string. I don't know the full perl grammar, but it seems to me that, if you want to avoid double quotes when not necessary (which seems like a waste of time that causes needless problems like this, if you ask me, but that's not my call), that should be whitelisted with something like [A-Za-z0-9_]+ or whatever the grammar specifies.

Side note: the given URL for the Debian bug report didn't work for me, but this does: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894282

Thank you for the report, btw.  Will fix.

Yeah, it's either bugs.d.o/BUGNUM or bugs.d.o/cgi-bin/bugreport.cgi?bug=BUGNUM, not bugs.d.o/cgi-bin/BUGNUM.

I did, however, make that change for a reason...  Unfortunately, I can only remember vaguely something about an empty argument that shouldn't have been there because some perl array contained an undef or something like that.
Anyway, I'm reverting that change and seeing what breaks because of it.  Be right back...

Side note: while I understand the nature of habit, I would urge those who can (and this most definitely includes Linux as far as I know) to switch to use openssl rehash.  c_rehash is a kinda fallback script that will disappear at some point.

Regarding the side note: I'm seeing fewer symlinks generated by openssl rehash compared to c_rehash… Is there any documentation regarding your recommendation to switch and the possible side effects?

On Wed, Mar 28, 2018 at 08:15:06AM -0700, Cyril Brulebois wrote:

Regarding the side note: I'm seeing fewer symlinks generated by openssl rehash compared to c_rehash… Is there any documentation regarding your recommendation to switch and the possible side effects?

The c_rehash in Debian is patches to provide both the new and old
symlinks, because when we switched to the new other libraries like
gnutls broke. I have no idea what the current state is.

On 2018-03-28 16:46:11 [+0000], Kurt Roeckx wrote:

On Wed, Mar 28, 2018 at 08:15:06AM -0700, Cyril Brulebois wrote:

Regarding the side note: I'm seeing fewer symlinks generated by openssl rehash compared to c_rehash… Is there any documentation regarding your recommendation to switch and the possible side effects?

The c_rehash in Debian is patches to provide both the new and old
symlinks, because when we switched to the new other libraries like
gnutls broke. I have no idea what the current state is.

The -compat/md5 option in Debian was forced in due to #622679 in 2011.
gnutls-cli uses /etc/ssl/certs/ca-certificates.crt and does not care if
the symlinks are gone. It won't do anything if the symlinks are
available (md5+sha1) but the ca-cer…crt file is missing.
This is now. It seems that we can drop that compat from GnuTLS point of
view.
I will open a bug against ca-cert and asking them to replace c_rehash' with openssl rehash' instead and ping the gnutls deb maintainer if they
know anything about the need regarding the md5 hash.
Sebastian


[Feature]: Rework profile delete using remix-forms/zod

Contact Details
No response
What do you like to be improved?

Also handle error message from await deleteUserByUid(currentUser.id);

Done in #168


Analyser: index.lock: File exists

Look how/if this gets reported and if we can clear it up:
2020-05-15T17:39:52.883069388Z [ ERROR ] analysis error: ShellOut encountered an error
2020-05-15T17:39:52.883122027Z Status code: 128
2020-05-15T17:39:52.883138198Z Message: "fatal: Unable to create '/checkouts/github.com-facebook-facebook-ios-sdk/.git/index.lock': File exists.
2020-05-15T17:39:52.883142468Z
2020-05-15T17:39:52.883146168Z Another git process seems to be running in this repository, e.g.
2020-05-15T17:39:52.883149748Z an editor opened by 'git commit'. Please make sure all processes
2020-05-15T17:39:52.883153048Z are terminated then try again. If it still fails, a git process
2020-05-15T17:39:52.883156258Z may have crashed in this repository earlier:
2020-05-15T17:39:52.883159378Z remove the file manually to continue."
2020-05-15T17:39:52.883162458Z Output: ""

Also looks like this isn’t marked as processed and stays at the top of the analysis candidate list:


safe-to-evict annotation should be true by default

As a followup to https://github.com/beacon-biosignals/julia_pod/pull/12 I'd like to suggest that the cluster-autoscaler.kubernetes.io/safe-to-evict annotation be set to "true" by default (or unset), while giving the user the possibility to override it. This is because:

the annotation can prevent scale-in which leads to wasted resources and $$
as a best practice, workloads should ideally be tolerant of interruptions anyway.

As always, this choice is a trade-off worth discussing. If the monetary savings aren't worth the consequences of pods occasionally being evicted, then no change is needed. Unfortunately, I don't know of a straightforward way to get numbers that would tell us exactly how much compute is being wasted, but I can say that if people are setting safe-to-evict by default, then we will probably need to switch to smaller instance types on the projects cluster, so that a single pod can't cause a huge metal instance to run for days+, for example. (I regularly see stale pods hanging around, so I'm concerned that this could be :money_with_wings: :money_with_wings: :money_with_wings:)
(See also here)

Bump? This seems even more important given that it doesn't seem like processes are always properly terminated when they've finished or have crashed. (I think @ericphanson and @haberdashPI encountered this recently? and I've observed other apparent cases as well.)

FYI my case was unrelated to safe-to-evict (or julia_pod; I wasn't using it), and was an issue in how I was running the code (I wasn't releasing workers when they were done work, ref https://github.com/beacon-biosignals/K8sClusterManagers.jl/issues/87).

Huh, I guess I don't have a very clear idea about where K8sClusterManagers.jl ends and julia_pod begins.
IIUC: if safe-to-evict is not set, then one pod that's not using many resources might still get evicted during scale-down in some cases, like if some CPU usage threshold isn't being met... but I'm not 100% sure on the details.
On the other hand, if it's set to false, then it will prevent a scale-down, even if the pod isn't doing anything.

julia_pod is basically a big shell script to build a docker image, spin up a pod, and sync logs and files between the two, so you can interactively work on a pod. It doesn't require a local Julia install (but it dumps you in a Julia session on the pod you spin up) and doesn't use K8sClusterManager, but it installs it on the pod for you to use there if you want.
K8sClusterManagers lets you spin up more pods from a pod in a Julia-friendly way (i.e. using the Distributed stdlib which was made for managing remote workers etc, though often on a university HPC cluster rather than a cloud or k8s cluster). It can be used interactively or non-interactively, from a julia_pod-powered session or from any other Julia session that happens to be running on a k8s pod. I often spin up a "manager" pod just using kubectl create ... (no julia_pod) and have that run a script that uses K8sClusterManagers to spin up more pods and send them work to do, etc.


Wish: kodi plugin

Maybe i could look into writing this myself.  After watching a movie or episode send update to watcharr.
But apart from that great idea and works very well for me.
Thank you!

Hi, thanks for opening this issue @airdogvan!
I've never used Kodi before, so your guidance on how it should work would be much appreciated.
I suppose the plugin would be downloaded in Kodi by the user, then they would authenticate against Watcharr and the plugin can scrobble watched content automatically?
Do you think auth should be handled via api keys the user can generate in Watcharr: #360 (if you do look into writing this plugin, you could manually grab your real auth token for now, then we could swap it over to use api keys later when implemented if you think that's suitable) - only problem I see is they could be a pain to type out on a TV (not sure if there's an easy way to get around that).

Although I did use Kodi several times a week I've never had the need to write a plugin.
But I do know how to write code and can certainly look into it.
Yes api would be the way to go (wasn't sure if Watcharr did provide one.
For testing purposes the key would be fine but that wouldn't work for real user auth, as you rightly mentioned, a pain to type with a remote.
Could use a method similar to debrid, they display a 6 or 8 digit number that you need to enter in a field below and if they both match the user is authenticated.  So maybe Watcharr could generate an API key and write that to the user's profile if authenticated correctly on screen.
Give me a day or 2 to look into this and I'll get back to you.
As for watched content (history) this is going to be dicey as each plugin in Kodi handles that differently.  Usually the approach (forgot the name of the other service that already does this) is to grab watched data starting from the first usage.
Again let me look into this.
Mar 29, 2024 22:13:56 Mr 'notifications at github.com' @.***>:

This email was sent to @.*** from @.***
Click here[https://app.addy.io/deactivate/022cc3db-6fd8-4177-8ee9-e7c2e50b7a0f?signature=c71858ffacf8d3e9be43c2aa0cb6d980030174651ae2fda2b9e769c21abf2a88] to deactivate this alias
Hi, thanks for opening this issue @airdogvan[https://github.com/airdogvan]!
I've never used Kodi before, so your guidance on how it should work would be much appreciated.
I suppose the plugin would be downloaded in Kodi by the user, then they would authenticate against Watcharr and the plugin can scrobble watched content automatically?
Do you think auth should be handled via api keys the user can generate in Watcharr: #360[https://github.com/sbondCo/Watcharr/issues/360] (if you do look into writing this plugin, you could manually grab your real auth token for now, then we could swap it over to use api keys later when implemented if you think that's suitable) - only problem I see is they could be a pain to type out on a TV (not sure if there's an easy way to get around that).
—
Reply to this email directly, view it on GitHub[https://github.com/sbondCo/Watcharr/issues/450#issuecomment-2027920320], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AHRKLJ3IWEK6LB3QIXFT2F3Y2ZCYVAVCNFSM6AAAAABFPEYIQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHEZDAMZSGA].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/AHRKLJ6LPVCUL5PMVOAXVOLY2ZCYVA5CNFSM6AAAAABFPEYIQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTY36N4A.gif]

That's great @airdogvan, thank you for taking the time.
If you are able to get the base functionality (scrobblinh) working, I can look into how we could handle the auth a little easier (the token thing you mention sounds good, the user could probably create a one time small token to grant access to the kodi plugin).
For the watched content, is that referring to syncing watched history from kodi to Watcharr?
Not sure where the best place to put it would be, I think you could make a plugins/kodi folder in the main repo?
Thanks again! Let me know if you run into any problems.

@ IRHM  I've found an addon that already does the heavy lifting script.myepisodes and am seriously thinking of using that as a solid base.
Authentication could be done easily in the settings once the user has generated her/his API key.
Tell you the truth, until some form of API implemented not much I can do for the moment.  I'll use the time getting familiar with the existing code and wait for further progress.  Unless of course you have other suggestions.

Sounds good @airdogvan, will hopefully get api keys fully done at some point.
As long as the kodi plugin can get a TMDB content id, then it should work to add content against the current Watcharr api by making a post request to /api/watched (routes.go:352).
Hopefully Kodi is able to give us the TMDB id, otherwise we may need to make other changes to support whatever ids it does have.

cannot give you a 100% guarantee but Kodi's been around for a while so I would be very surprised that it doesn't handle TMDB.

+1 request for Kodi support. I would love to ditch Trakr.....
Kodi does have a comprehensive API... I would imagine one can get list of watched items.

Yes but I have discovered that writing for Kodi is something of an extreme sport, blindfolded and with your hands tied behind your back.
Debugging is reduced to its very minimal, documentation almost non existant.
Working hard on it and hope to come up with results soon.
@IRHM do i need to pass the TMBD info to your API?  As Watcharr is going to have to check if show or movie already in your db.
Wouldn't the title, season and episode be enough?
Or I could get you the TMBD ID and pass that to Watcharr.
Apr 11, 2024 05:40:35 hernandito 'notifications at github.com' @.***>:

This email was sent to @.*** from @.***
Click here[https://app.addy.io/deactivate/022cc3db-6fd8-4177-8ee9-e7c2e50b7a0f?signature=c71858ffacf8d3e9be43c2aa0cb6d980030174651ae2fda2b9e769c21abf2a88] to deactivate this alias
+1 request for Kodi support. I would love to ditch Trakr.....
Kodi does have a comprehensive API... I would imagine one can get list of watched items.
—
Reply to this email directly, view it on GitHub[https://github.com/sbondCo/Watcharr/issues/450#issuecomment-2049606870], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AHRKLJYYVLW67A5SGUMTUN3Y42ADRAVCNFSM6AAAAABFPEYIQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGYYDMOBXGA].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/AHRKLJ2BPUMCW2ZZTZNMLQTY42ADRA5CNFSM6AAAAABFPEYIQKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT2FKCNM.gif]

Hey @airdogvan, yep just the TMDB ID and content type should be good enough.
You can make a POST request to /api/watched with a body following this schema:
I've simplified a struct from the code to make it easier to quickly reference:
type WatchedAddRequest struct {
	status?: WatchedStatus;
	rating?: int8;
	thoughts?: string;
	contentId: int;
	contentType: "movie" | "tv";
	// Pass a watched date and we will set the CreatedAt (and initial UpdatedAt)
	// properties for this watched entry to this specific date.
	watchedDate?: time.Time;
}

The contentId must be set to a tmdbId and the contentType must be set to movie or tv. All the other parameters or optional.
An example of adding a tv show (Upright) as watched could look like this (request body):
{"contentId":95913,"contentType":"tv","status":"FINISHED"}

I should probably look into generating api docs to help out with anyone needing anything like this. For now, you can half reverse engineer by performing an action in the browser, then looking in your dev tools network tab and seeing what requests it made to the server (or feel free to ask me here, I don't mind helping out!).
Thanks! Let me know if you need anything else!

@IRHM is there a way we could communicate somewhere else?  Lots of technical details will get tedious for others and would clog this issue.
You can reach me at fossilvan on Telegram.  Would be grateful if you could delete this after reading so I don't get swarmed by spam.

Hey @airdogvan, I don't have telegram, but we do have a public matrix server (https://matrix.to/#/#watcharr:matrix.org) we could talk in or you can pm me: @irhm:matrix.org

sent you a DM but says profile doesn't exist...

sent you a DM but says profile doesn't exist...

My username might have to be all lowercase, github looks to have uppercased it to @ this gh account.
You can join the Watcharr matrix space if that doesnt work and ping me from there.

Thanks to @airdogvan we now have a kodi plugin in beta: https://github.com/airdogvan/watcharr_kodi
You can download the first beta version from the release: https://github.com/airdogvan/watcharr_kodi/releases/tag/beta (direct download).
I personally don't use kodi so my feedback probably doesn't matter, but if anyone tries this out please tell us about your experience! I'm sure @airdogvan would be happy to hear what you have to say!


Why do we need to set n_device_per_batch like this？

the python file is /distrifuser/distrifuser/utils.py, and I can't understand why do we need to set variable n_device_per_batch like "n_device_per_batch = world_size // 2".  Is n_device_per_batch  means that N devices for one patch as described in the paper?
Partial code is as follows：
if do_classifier_free_guidance and split_batch:
        n_device_per_batch = world_size // 2
        if n_device_per_batch == 0:
            n_device_per_batch = 1
        else:
            n_device_per_batch = world_size

        self.n_device_per_batch = n_device_per_batch

I can't understand why n_device_per_batch = world_size // 2

Hi! Diffusion model inference often uses classifier-free guidance, where the batch size will double. So here, we first the split the batch and within a batch we use displaced patch parallelism.

Hi! Diffusion model inference often uses classifier-free guidance, where the batch size will double. So here, we first the split the batch and within a batch we use displaced patch parallelism.

 Thank you so much!

Another question，if I can understand what you say in this way: if we have world_size=2 devices totally and they will be split in two parts. Every part(half of batch) having one device. In other word, just one device for one patch. So there is no patch  parallelism in this case.
If we want to set patch parallelism, we must set  world_size>=4 so that within 2 devices  at least for one patch?

Hi! Diffusion model inference often uses classifier-free guidance, where the batch size will double. So here, we first the split the batch and within a batch we use displaced patch parallelism.

Another question，if I can understand what you say in this way: if we have world_size=2 devices totally and they will be split in two parts. Every part(half of batch) having one device. In other word, just one device for one patch. So there is no patch  parallelism in this case.
If we want to set patch parallelism, we must set  world_size>=4 so that within 2 devices  at least for one patch?


Autogenerate pem

It would be possibly nice to autogenerate the https keys on first start in private server mode, similar to how https://github.com/shennoether/mininodo works.

As in, self-signed certificate? If so, that would need to be an opt-in option!
I can't speak for anyone else, but personally I wouldn't want a system to generate its own private key + public self-signed certificate.
Maybe partially because I want to be in control of these things, but mostly because I'm proxying The Lounge behind nginx, which is in charge of the key management.
Also, I would (and do) prefer not using a self-signed certificate and go for one that is recognized by the browsers. With Let's Encrypt, there are far less reasons not to do so :-)
Others, thoughts?

Maybe a command line flag for it would be better? (Could also be such a flag to get the let's encrypt version)

It's not our job to generate certificates. As for let's encrypt, that's perfectly suited for a plugin (which we don't support yet 😆)


kCircleHeightBackground could not be changed

kCircleHeightBackground, the background circle's height could not be changed

I can, please illustrate what you tried and what you got


Using AbstractDifferentiation and Zygote as package dependencies errors: UndefVarError: ZygoteBackend not defined

I wanted to abstract the AD calls in one of my packages that currently uses Zygote.
However, using the readme example in a package results in a UndefVarError: ZygoteBackend not defined.
module TestADDependency

using AbstractDifferentiation, Zygote
ab = AD.ZygoteBackend()

end

(TestADDependency) pkg> status
Project TestADDependency v0.1.0
Status `~/Developer/TestADDependency/Project.toml`
  [c29ec348] AbstractDifferentiation v0.4.3
  [e88e6eb3] Zygote v0.6.40

(TestADDependency) pkg> precompile
Precompiling project...
  ✗ TestADDependency
  0 dependencies successfully precompiled in 3 seconds. 35 already precompiled.

ERROR: The following 1 direct dependency failed to precompile:

TestADDependency [34f2ebba-d68a-4a13-a6cd-2ada1134ccab]

Failed to precompile TestADDependency [34f2ebba-d68a-4a13-a6cd-2ada1134ccab] to /Users/funks/.julia/compiled/v1.8/TestADDependency/jl_EHrP9j.
ERROR: LoadError: UndefVarError: ZygoteBackend not defined
Stacktrace:
 [1] getproperty(x::Module, f::Symbol)
   @ Base ./Base.jl:31
 [2] top-level scope
   @ ~/Developer/TestADDependency/src/TestADDependency.jl:4
 [3] include
   @ ./Base.jl:422 [inlined]
 [4] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
   @ Base ./loading.jl:1400
 [5] top-level scope
   @ stdin:1
in expression starting at /Users/funks/Developer/TestADDependency/src/TestADDependency.jl:1
in expression starting at stdin:1

Here is a Minimum Working Repository that replicates the issue: https://github.com/adrhill/TestADDependency.jl

Issue doesn't persist on v0.5.2.


Bug: BigQuery: Need a way to set JobId...

There doesn't appear to be a way to set the JobId, making cancel(String JobiD) challenging.
Looking at Python L35, The query Job takes a JobId.  There doesn't appear to be a similar method for Java. ;(

@tswast FYI

There doesn't appear to be a way to set the JobId

Where? and why is cancel challenging?

Tim's explanation of the string variant of cancel(String "id") is that it is a name provided by the user on create, in the case of the Python samples a UUID.  The .jobId() is the other kind.  If you can't ever set / create with a name/id, then what's the point of the string method?
I presume, I could perhaps, use  .jobId().toString(), in the snippets, but that just seems weird.
It's also terribly possible that I'm not understanding something, but Tim couldn't find it either, and wrote another issue for it.

But you can create a job passing your own name:
String jobName = "my_job";
JobInfo jobInfo = JobInfo.of(JobId.of(jobName), QueryJobConfiguration.of("SELECT * FROM table"));


Suggestion: Prevent hiding super class properties and methods

Code

class A
{
   public member = {};
   public click = () =>
   {
   }

   constructor()
   {
      member.a = "Member";
      document.body.addEventListener("click", this.click);
   }
}

class B extends A
{
   public member = {};
   public click = () =>
   {
       // Implementer of subclass expects this to get called on body click
   }

   constructor()
   {
      super();
      console.log(this.member.a) // would print undefined
   }
}

It would be nice if we were able to generate a warning or error to say that B's member is hiding A's member, as well as the fact that B's click is hiding A's click.  I'm not sure whether a new keyword would be appropriate, or just an option in tsconfig.json to generate an error or warning would make me happy.
Not having this has lead me to some head scratching to why things aren't working as I rearrange how things inherit from each other due to me not noticing that I have redefined a method or property in the subclass.

#2000 tracks the override keyword for handling this problem

I've read through that issue and I feel that my problem is a little different.  For me I'd rather be able to designate on my base class that something shouldn't be overridden, maybe #1534 is closer to what I'm thinking, although I'd also like the ability to seal an instance property.

I do not think this is #2000, this is rather different. this is akin to using a virtual function in the constructor of the base class. usually not a good recipe, see some comments for C++ http://stackoverflow.com/questions/962132/calling-virtual-functions-inside-constructors and for C# http://stackoverflow.com/questions/119506/virtual-member-call-in-a-constructor.
I would suggest either using capture in the call site:
   constructor()
   {
      member.a = "Member";
      document.body.addEventListener("click", ()=> { this.click() } );
   }
}

or making this a constructor argument.

I was thinking of the issue I'm having similar to hiding inherited members in C#

When used as a declaration modifier, the new keyword explicitly hides a member that is inherited from a base class. When you hide an inherited member, the derived version of the member replaces the base class version. Although you can hide members without using the new modifier, you get a compiler warning. If you use new to explicitly hide a member, it suppresses this warning.
From here:
https://msdn.microsoft.com/en-us/library/435f1dw2.aspx

I understand what you mean, however my goal is to prevent the user from redefining the function/property in the subclass.

still does not solve your issue. the problem is not that you are shadowing a member. the problem is you are using it in the base constructor before the new member have been installed on the object.

We use a lot of observable objects in our ViewModels so we like to associate a callback for when they are changed in our constructor.  It feels right to do this in the constructor, Otherwise I'd have to call some setupEvents() method after the object is constructed.

then you should capture the this and invoke the handler when needed, instead of capturing the handler directelly, i.e.:
document.body.addEventListener("click", ()=> { this.click() } );

instead of:
document.body.addEventListener("click",  this.click );

The only issue I have with this is I wouldn't be able to remove the event listener.

const listener = ()=> { this.click() };
document.body.addEventListener("click",  listener);
document.body.removeEventListener("click", listener);


fresh install ubuntu 14.04

Getting the below errors in nginx logs on a fresh install.
also noticed that there is no vendor folder from what ever is being installed by composer.
2015/10/30 21:41:00 [notice] 13880#0: *19 "^/(.*)/(.*)/(.*)$" does not match "/install.php", client: <IP_ADDRESS>, server: , request: "GET /install.php?install HTTP/1.1", host: "<IP_ADDRESS>:8000"
2015/10/30 21:41:00 [error] 13880#0: *19 FastCGI sent in stderr: "PHP message: PHP Warning:  require(vendor/autoload.php): failed to open stream: No such file or directory in /usr/local/nginx/html/_start.php on line 4
PHP message: PHP Fatal error:  require(): Failed opening required 'vendor/autoload.php' (include_path='.:/usr/share/php:/usr/share/pear') in /usr/local/nginx/html/_start.php on line 4" while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /install.php?install HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "<IP_ADDRESS>:8000"
2015/10/30 21:41:22 [notice] 13880#0: *21 "^/(.*)/(.*)/(.*)$" does not match "/install.php", client: <IP_ADDRESS>, server: , request: "GET /install.php?update HTTP/1.1", host: "<IP_ADDRESS>:8000"
2015/10/30 21:41:22 [error] 13880#0: *21 FastCGI sent in stderr: "PHP message: PHP Warning:  require(vendor/autoload.php): failed to open stream: No such file or directory in /usr/local/nginx/html/_start.php on line 4
PHP message: PHP Fatal error:  require(): Failed opening required 'vendor/autoload.php' (include_path='.:/usr/share/php:/usr/share/pear') in /usr/local/nginx/html/_start.php on line 4" while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /install.php?update HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "<IP_ADDRESS>:8000"
2015/10/30 21:41:26 [notice] 13880#0: *23 "^/(.*)/(.*)/(.*)$" does not match "/", client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "mystreamer:8000"
2015/10/30 21:41:26 [notice] 13880#0: *23 "^/(.*)/(.*)/(.*)$" does not match "/index.php", client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", host: "mystreamer:8000"
2015/10/30 21:41:26 [error] 13880#0: *23 FastCGI sent in stderr: "PHP message: PHP Warning:  require(vendor/autoload.php): failed to open stream: No such file or directory in /usr/local/nginx/html/_start.php on line 4
PHP message: PHP Fatal error:  require(): Failed opening required 'vendor/autoload.php' (include_path='.:/usr/share/php:/usr/share/pear') in /usr/local/nginx/html/_start.php on line 4" while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "mystreamer:8000"
2015/10/30 21:42:18 [info] 13880#0: *25 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:8000
2015/10/30 21:42:18 [info] 13880#0: *26 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:8000
2015/10/30 21:42:18 [info] 13880#0: *28 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:8000
2015/10/30 21:42:18 [info] 13880#0: *27 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:8000
2015/10/30 21:42:18 [info] 13880#0: *29 client closed connection while waiting for request, client: <IP_ADDRESS>, server: <IP_ADDRESS>:8000

i fixed on thing by doing
apt-get install php5-cli -y

then
curl -sS https://getcomposer.org/installer | php
mv composer.phar /usr/local/bin/composer

fixed by doing
composer require illuminate/database

you might need to add this to the install file

adding a stream i get which i presume i need to add a transcode profile first?
2015/10/30 21:59:47 [error] 13880#0: *81 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught exception 'PDOException' with message 'SQLSTATE[42S22]: Column not found: 1054 Unknown column 'trans_id' in 'field list'' in /usr/local/nginx/html/vendor/illuminate/database/Connection.php:390
Stack trace:
#0 /usr/local/nginx/html/vendor/illuminate/database/Connection.php(390): PDO->prepare('insert into `st...')
#1 /usr/local/nginx/html/vendor/illuminate/database/Connection.php(644): Illuminate\Database\Connection->Illuminate\Database\{closure}(Object(Illuminate\Database\MySqlConnection), 'insert into `st...', Array)
#2 /usr/local/nginx/html/vendor/illuminate/database/Connection.php(611): Illuminate\Database\Connection->runQueryCallback('insert into `st...', Array, Object(Closure))
#3 /usr/local/nginx/html/vendor/illuminate/database/Connection.php(391): Illuminate\Database\Connection->run('insert into `st...', Array, Object(Closure))
#4 /usr/local/nginx/html/vendor/illuminate/database/Connection.php(347): Illuminate\Database\Connection->statement('insert into `st" while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "POST /manage_stream.php HTTP/1.1", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "mystreamer:8000", referrer: "http://streamer.robserver.com:8000/manage_stream.php"

fixed by doing the install update script

Nice, good job.


dotnet vstest -h does not display help

Ported from - https://github.com/dotnet/cli/issues/6000
Steps -
run dotnet vstest -h
Expected -
dotnet vstest help is displayed.
Actual -
E:\migrate\NuGet.Client [dev-anmishr-migrate2 ≡]> E:\migrate\NuGet.Client\cli\dotnet.exe vstest -h
Microsoft (R) Test Execution Command Line Tool Version <IP_ADDRESS>
Copyright (c) Microsoft Corporation.  All rights reserved.

The test source file "E:\migrate\NuGet.Client\-h" provided was not found.

Info -
E:\migrate\NuGet.Client [dev-anmishr-migrate2 ≡]> E:\migrate\NuGet.Client\cli\dotnet.exe --info
.NET Command Line Tools (1.0.0)

Product Information:
 Version:            1.0.0
 Commit SHA-1 hash:  e53429feb4

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.14393
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   E:\migrate\NuGet.Client\cli\sdk\1.0.0

Extra -
dotnet vstest --help works fine though.

This has been fixed!


Drill picking completely broken

This happens in master but not in 1.49 so it needs to be fixed before the release on Monday
This drill picking example causes the browser to hang.
http://localhost:8080/Apps/Sandcastle/index.html?src=Picking.html&label=All
@lilleyse @bagnell

This is related to https://github.com/AnalyticalGraphicsInc/cesium/pull/7069. I'm looking into it.

Spoke with @lilleyse offline, my preference is to revert #7069 and revisit it in the context of #6934 (since it's such a small change anyway).


Update build, add docs

Changed:

Updates the Dockerfile & makefile from the previous deployments
Add basic documentation for compiling, building and flashing the image.
Add GitHub action, delete it if issues/unwanted

TODO:

YAML file version check and locked as suggested.
ESP32 support

Conflicting. Closing


Summon Token Reverts after being Placed

Not sure if this is due to configuration but for some reason the summon token seems to revert back to the default image once the token is actually placed.

Avatar Image remains though

The token Image is set to default

Does this happen with all summons or just this one?  Have you tried with only my module and it dependencies enabled?

Ah sorry about that. Found a conflict with another module that has a feature that can interact with token art. The feature was toggled to disabled but seems like it still affects the token art somehow. Removed the module for now and it works just fine, will notify them of the interaction to see if they can take a look.


conv-paint as default segmentation

I suggest conv-paint to be the first/default segmentation method in the segmentation menu. The list should be

conv-paint
cellpose
precomputed
(ilastik and farid if they are still relevant)

Also fixed in dc947d7f5c69eb364d3ae1e31cdf43faa3c0c2cb


zkasm_runner::run_zkasm returns a struct with no public field or method

As I see zkasm_runner::ExecutionResult, which is the result type of zkasm_runner::run_zkasm is a struct with no public field or method. Therefore, currently there is no way to somehow extract results. Should we add some public method to extract results?

Yes, I've made some fields public in https://github.com/near/wasmtime/pull/231, would these be enough?

Yes, I've made some fields public in #231, would these be enough?

At least for the testing infra it should be enought


error at touch the clock area

Process: com.jakewharton.telecine
Flags: 0xc8be44
Package: com.jakewharton.telecine v1020000 (1.2.0)
Build: OPPO/X9007/X9007:5.0/LRX21M/1426582430:user/release-keys

java.lang.RuntimeException: An error occured while executing doInBackground()
	at android.os.AsyncTask$3.done(AsyncTask.java:300)
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
	at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
	at java.util.concurrent.FutureTask.run(FutureTask.java:242)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.IllegalArgumentException
	at android.media.MediaMetadataRetriever.setDataSource(MediaMetadataRetriever.java:160)
	at com.jakewharton.telecine.RecordingSession$3.doInBackground(RecordingSession.java:321)
	at com.jakewharton.telecine.RecordingSession$3.doInBackground(RecordingSession.java:318)
	at android.os.AsyncTask$2.call(AsyncTask.java:288)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	... 4 more

How do you reproduce this? Do you just "touch" the clock?

@jaredsburrows yes.

@binsee I just tried to reproduce this with the Google Play version and cannot. However, when I click on the "clock", it "stops" recording.

@binsee Can you give more details? or can we close this @JakeWharton.

Sorry, it's been a long time not to pay attention to GitHub. Now the phone is replaced by CM13 system, this problem has not been tested again. Please close this.


-internal not getting the right docker container ip

I want to use registrator to just add the new docker run internal ip to consul but I'm not getting the correct IP.
steps:
start consul
docker run --name consul -p 8400:8400 -p 8500:8500 -p 8600:53/udp -h node1 -d progrium/consul -server -bootstrap

start registrator with internal flag
docker run --name registrator -v /var/run/docker.sock:/tmp/docker.sock -h $HOSTNAME -d gliderlabs/registrator -internal consul://<IP_ADDRESS>:8500

when I run a new test container (DockerFile EXPOSE 8080)
docker run -d ljcp/simplenodeserver

result of curl <IP_ADDRESS>:8500/v1/catalog/service/simplenodeserver
[{"Node":"node1","Address":"<IP_ADDRESS>","ServiceID":"ubuntu:testserver:8080","ServiceName":"simplenodeserver","ServiceTags":null,"ServiceAddress":"","ServicePort":8080}]

But when i do docker inspect in my running test container i get         "IPAddress": "<IP_ADDRESS>",
I don't know why registrator sets the <IP_ADDRESS> instead of <IP_ADDRESS> ?
or the <IP_ADDRESS> should be populated to ServiceAddress: "" ??? to later correctly use the dns lookup ?
Looks like I'm searching a feature to use the internal docker ip of the container instead of a global host ip or some internal ip
Is there a way around for doing this with registrator ?? for the moment i don't want to expose all my containers to the host ..
I looked at resolvable project but resolvable doesn't push anything to consul and I need consul , so I guess if there is no way here , I'm going to fork this project or skydock and made the changes to just register the internal container ip to consul.
If this a feature I can do some work and make a pull request :)
this project looks pretty active :+1:  , I really appreciate any advice

Yes, this is very common requirement, however, seems not working.

Yeah looks like registrator focus on exposing ports to the host machine and nothing else , so later you can interconnected remote machines , but I'm looking something that use the internal docker container ips to resolve the dns with consul just like skydock works but with consul , I'm wondering if the scope of this project can handle a feature like that or better moving this into another project uhmmm

Until we cut a release later today you should be using :master of registrator.

Ahh going to test it with master and I will let update my tests here  soon if that fixes the problem of the internal docker ip :) , thanks

Now I see the "ServiceAddress" populated with the internal container ip
Thank you so much !

@ljcp, can u try the gliderlabs/registrator docker image? It was built 2 days ago, however, not working to get the ServiceAddress even with the -internal option.


Please reset the settings and try on other network and update :)


graphql/ not loading, js error. Can't get schema.

Hello, I tried to setup GraphiQL on dontnet aspnet core 2.1  site, but got follow js error.
invariant@http://localhost:22735/graphql/graphiql.js:24179:11
defineFieldMap@http://localhost:22735/graphql/graphiql.js:27207:4
getFields@http://localhost:22735/graphql/graphiql.js:27164:44
typeMapReducer@http://localhost:22735/graphql/graphiql.js:28869:20
GraphQLSchema@http://localhost:22735/graphql/graphiql.js:28758:21
buildClientSchema@http://localhost:22735/graphql/graphiql.js:30166:10
_fetchSchema/<@http://localhost:22735/graphql/graphiql.js:2140:25

With debugger I figured that comes after try to get schema with follow command

  query IntrospectionQuery {
    __schema {
      queryType { name }
      mutationType { name }
      subscriptionType { name }
      types {
        ...FullType
      }
      directives {
        name
        description
        locations
        args {
          ...InputValue
        }
      }
    }
  }

  fragment FullType on __Type {
    kind
    name
    description
    fields(includeDeprecated: true) {
      name
      description
      args {
        ...InputValue
      }
      type {
        ...TypeRef
      }
      isDeprecated
      deprecationReason
    }
    inputFields {
      ...InputValue
    }
    interfaces {
      ...TypeRef
    }
    enumValues(includeDeprecated: true) {
      name
      description
      isDeprecated
      deprecationReason
    }
    possibleTypes {
      ...TypeRef
    }
  }

  fragment InputValue on __InputValue {
    name
    description
    type { ...TypeRef }
    defaultValue
  }

  fragment TypeRef on __Type {
    kind
    name
    ofType {
      kind
      name
      ofType {
        kind
        name
        ofType {
          kind
          name
          ofType {
            kind
            name
            ofType {
              kind
              name
              ofType {
                kind
                name
                ofType {
                  kind
                  name
                }
              }
            }
          }
        }
      }
    }
  }

Can you help, what to check to solve that?

The reason was - I had empty MutationClass, but assigned in Schema, after i commented that out everything fine.
Could be closed.

Thanks for updating the issue and closing it off 👍


check code format on CI

Hi @amiremohamadi 👋
I wrote a new workflow based on the #4  issue you posted to check the code format on CI.

thanks for your contribution 🎉 i suggest to move all these changes and the contents of test.yaml into a single file. we can name it precheck.yaml or check.yaml.

it's done :)
now we have both test and format check in precheck.yaml

LGMT! thanks for contribution.


Cannot see Duo Emulator after installed SDK preview with VS2019

hi , guys .
I cannot see any Surface Duo Emulator in Visual Studio 2019 .
My dev environment :
OS : Windows 10(19555.0)
Hardware : Surface Book 2
The screenshots as bellow

so , does any solutions for this issue ?

@winecos
Did you:

Edit the run.bat script as mentioned in the Docs article?
Did you start the emulator and can you see it running?

@tscholze  thanks .

Edit the run.bat script as mentioned in the Docs article?
==> yes . added the path of Android SDK.
Did you start the emulator and can you see it running?
==> yes , starting the emulator and then open the Xamarin.Duo.Samples.sln file . but, it haven't

Thanks.

Good morning @winecos,
I meant if you edited the run.bat like mentioned in Docs article (see section "Xamarin"). That means to remove the port parameter of a call that's included in the file.
Yes is see the emulator running and I'm able to select in VS.
If you have any further problems, you might want to visit the official technet community of the SDK (see link).

@tscholze  Thanks very much !
if remove the port parameter of a call in run.bat , can't start the Surface Duo Emulator on the desktop icon.

@winecos
than let us revert all.
What happens when you just copy past (and edit the android path) and run the run.bat from a Command Line? This should print out some errors which might be wrong.
You can also reset the emulator by running the clean start skript in the same folder as the run script is.

Sorry to hijack this thread but I can't see the Surface Duo emulator as one of the options but this time on Visual Studio for Mac. I do have Surface Duo emulator running just fine in the background however. How can I get the Xamarin.Forms sample to run via VS for Mac?

@winecos Is now everything running as you expect?

The latest emulator (since this issue) has a separate batch file specifically for Visual Studio run_vs.bat, hopefully this makes it easier to use. Please raise a new issue if needed.


Add AbstractRepositoryFactory

As mentioned earlier, writing own Repository factory seemed tedious so I propose to introduce an abstract factory that will ease the process and allow developer to focus on instantiation itself.

@alcaeus agree with your comments, will apply them soon. Frankly I've just copy-pasted what was in original DefaultRepositoryFactory without thinking much :)

Offhand I've also started writing some docs about this, should be ready on Monday

@alcaeus actually I think that instead of narrowing ObjectRepository to DocumentRepository we should do the opposite, for instance I've found such check

Oh, good find. In that case, make it ObjectRepository and let's look at that again for 2.0. We might want to use our own interface depending on the functionality.

@alcaeus done

@malarzm doc needed please!

@mdjaman the docs were updated long time ago: https://www.doctrine-project.org/projects/doctrine-mongodb-odm/en/1.2/reference/document-repositories.html#repositories-with-additional-dependencies


Please check ioBroker.lupusec with js-controller 2.0

Hi,
the new js-controller 2.0 will come into latest repository in the next days and we want to make sure that all adapters are working well. We already did a 2 weeks Beta test and so some adapter were aleady checked and some needed slight adjustments.
You can find more information in https://github.com/ioBroker/ioBroker.js-controller/issues/482 and in the ioBroker Forum. If you have more technical questions please write in the referenced issue or in the Developer thread please. General questions are best in the genral thread.
Please update your systems to js-controller 2.0 and check your adapter.
Please close this issue once you have checked your adapter or received successfull reports from users.
Thank you very much for your support. Please contact us in the other Threads or Forum on any question.

I installed js-controller 2.0 on my development system. The adapter works fine, test was successful.


Post-release updates: heroku/nodejs-yarn 0.1.7

We were able to release the image for heroku/nodejs-yarn 0.1.7 here: https://github.com/buildpacks/registry-index/issues/2147
However, the rest of the release script failed (including generating this PR) here. I'm creating this PR manually, because the release action won't ever pass for the same release again (the buildpack registry rejects duplicates).

I've yanked 0.1.7 from the registry: https://github.com/buildpacks/registry-index/issues/2151.
I've also deleted the tag here on GitHub.
We never published this buildpack to ECR, so it's like this release (0.1.7) never happened.


Table 24 add 2016 cohort

add 2016 cohort to table 24

Be good to still keep 1999 in there as it shows the full 20 years. May just have to make the font smaller.....


Calculating scroll position

When using slidebars, plugins like wow.js (http://mynameismatthieu.com/WOW/) and other plugins calculating scroll position won't work.
Afaik the issue occurs, because you scroll the #sb-site DIV instead of the body.
Any suggestions?

I was having this issue. I found it was caused by setting height: 100%; for html, body after slidebars' css had loaded.


Add image and PPP

Update AboutUs.md to include my photo and current role (#47).
Add my photo in doc/images/pokezardvgc.png.
Add my skeletal PPP in docs/team/pokezardvgc.md (#49).

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (51fc3a6) compared to base (9a139dc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #63   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


styling fixes for layout of birds eye view plot with overlayed vs faceted plots

Noticed this in the LLINEUP study:
when plot is not stratified, birds eye shows on right side of plot:

when an overlay is added, birds eye moves to below the plot (presumably because the birds eye view is less important than the featured plot):

when a facet is added, birds eye now moves to the top of the plot!

we need to be consistent with the placement of the birds eye view so it doesn't jump around as the user builds their visualizations

This is mainly an issue for small screens.  The moving of the supplementary plots between faceted and non-faceted is intentional and I think has already been through the committee.
There is a related issue with the new map viz which causes wrapping of the birds eye plot below the map, which @chowington and I have discussed (but I don't remember where). The map's main viz panel is wider than the other plot types, so it makes things wrap more readily.
When the birds eye goes below the plot or map, it doesn't look great. It needs some padding/margin above it.

@bobular Obviously, I don't know the history of these UX conversations. I played with this Friday afternoon and thought it made sense to fix the table, birds eye, and legend to be above the visualizations. I've attached pictures to demonstrate how it behaves when building a visualization. My screenshots are in Firefox on a 27" monitor.

New scatterplot

Set axis variables

Add an overlay

Add a facet

We should also consider @danicahelb , @asizemore  etc hiding the empty completeness table because IMO it looks weird.
We should be careful that things don't jump around the screen while things are loading. For example, the birds eye component is hidden with, IIRC,  the visibility CSS property, in order to preserve its real-estate.
Just for the record, this is mentioned (in passing only) here: https://github.com/VEuPathDB/web-eda/issues/994

discussed in 4/11/2022 EDA UX meeting.
In non-faceted view, the layout should be 2 columns:

Left column, ordered from top to bottom: (i) plot and (ii) viz controls
Right column, ordered from top to bottom: (i) legend, (ii) birds eye bar plot, (iii) variable completeness table

In the faceted view, the right column should be transposed into a row above the left column. The order from left to right should be (i) legend, (ii) birds eye bar plot, (iii) variable completeness table
Additional notes from the EDA meeting:
With this proposed change, in the faceted view, the legend, birds eye bar plot and variable completeness table appear above the main plot being created (ie, scatterplot, box plot, etc)

It is important that the plot legend does not end up far below the main viz (ie, if we move the legend, birds eye bar, and var completeness table to below the plot controls, the legend will be quite separated from the main plot)
We considered just placing the plot legend above the main plot, and placing the birds eye bar & variable completeness table below the plot controls, however this leaves lots of empty space to the right of the plot legend
Note that faceted plots that do not have an overlay will still have their birds eye bar and variable completeness table appearing above the main plot
We may need to revisit this layout in the future based on user feedback. Generally, we want the most important aspects of the visualization to appear highest on the page. Placing the birds eye bar and variable completeness table above the main plot in the faceted view may be confusing.
However, as the user builds their visualization, they will first select axis variables and the birds eye bar will take a secondary position to the right of the main plot. Hopefully, this will help the user to understand the importance of the main plot

@bobular @jernestmyers I also agree that we should hide the variable completeness table until it is populated

this looks great, thanks @jernestmyers!
I did create a related ticket (NOT for b57), I'm hoping I could get some feedback to see whether this new ticket is worth fixing or not?


fix(#17): src should sync with tag

to fix #17

The $SCRCPY_VER tag is used in order to download a binary that will be used as some kind of a cache.
You can notice that this binary is passed to the meson build as prebuilt_server=/scrcpy-server.
The git clone step, however, will download the latest code - i.e. from HEAD - and will compile that.
By passing $SCRCPY_VER to git clone, you end up cloning and building the exact same version than the binary that was just downloaded :-|


error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

Describe the bug
just updated my pack and ran into that error message in the Build Modpack Step
  error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I)

         at «none»:0: (source not available)
  Error: The process '/nix/var/nix/profiles/default/bin/nix-env' failed with exit code 1

To Reproduce
Steps to reproduce the behavior:

push to branch
it errors in the Handle Releases step

Expected behavior
it should work
Additional context
pipeline that errored
https://github.com/Fauli1221/PonyCraftANewGenerationVanilla/actions/runs/8480132868/job/23235321967

Fixed with #80


Fix type check tests are broken due to error message change

Some type check tests fail due to change error message. The change seemed to be caused at c5d2744c045f9ad058cbc799f2434d90a6d83516. These failures occur on current master branch CI. This PR fixes the tests by adjusting the expected error messages.

ah thanks!


Release 2.1.16: metrics file loses a line every time training is stopped and then continued

Let's say you train for 10 checkpoints and stop. The metrics file will have info for 10 checkpoints, and the latest params file will be params.00010.
Now, suppose you continue training and stop after an additional 10 checkpoints. The metrics file will have info for 19 checkpoints, and the latest params file will be params.00020. The line that was lost was the line corresponding to params.00010. All of the lines from the 10'th on are now incorrect. Line (9+n) of the metrics file actually contains information about checkpoint (9 + n + 1).

Hi @tuglat thanks for reporting this issue! I was able to reproduce and it turns out we incorrectly save the training state before adding metrics to it. #860 should fix it.


Ignored is not a great default.

Hi, I'm giving a twirl and learning about droppable components. Great comments for a noob, thanks for that.
My issue is that I think the default behavior of ignoring unnaccepted mimes or max files without error or callback is not great. I'm going to try to edit the component myself to see if I'm able to show some messages to the user. Please consider adding that feature.

I think I'll keep the behavior of ignoring unaccepted mimes/files. If you want to handle it yourself, it's always possible to check that inside your handleFiles function instead of setting the allowsMimes and max props.
Feel free to publish your own package if you find a solution you like!


Remove title change event to prevent flickering in some apps

This PR removes the (so far) unused TITLE CHANGE event, which was causing flickering effects on several apps (editors):

Notepad
JetBrains products (in particular, the text editing window)
Some Sun AWT based products

Note: this is not a complete fix for JetBrains issues (#61) or Sun AWT. However, it makes the IDE and other applications very usable, with the additional filter added in your configuration (in particular, for dropdowns, menus and other floating windows in Sun AWT):
    context.WindowRouter.AddFilter((window) => !window.Class.Contains("SunAwtWindow"));

Good job. Looks good to me :)

with the additional filter added in your configuration (in particular, for dropdowns, menus and other floating windows in Sun AWT)

Would it make sense to add that as a default-filter to make this more usable out of the box?
Maybe you could send a PR for that too? :smiley:


How to SendAsync to Caller or Others on the IHubContext<>?

Is it at all possible to access the Caller and Others clients when working with the IHubContext?
I have read through various issues, including:
https://github.com/aspnet/SignalR/issues/734
Where it suggests using
Clients.Client(Context.ConnectionId).InvokeAsync(...)
I'm following the pattern here https://github.com/aspnet/SignalR/issues/182, that suggests using a separate "HubMethods" class to host / share hub logic between the actual Hub implementation and say a controller action method.  As such I'm working with the IHubContext interface rather than a Hub and thus don't have access to the Context property used in the above example.
I just can't figure out how I can SendAsync to the Caller.  Is this possible when working with the IHubContext?
Here is a snippet of the code I'm using,  It's in the commented out method that I want to make an explicit call to the Caller.
    public class AllocationHubCommands
    {

        private readonly IHubContext<AllocationHub> _hubContext;

        public AllocationHubCommands(IHubContext<AllocationHub> hubContext)
        {
            _hubContext = hubContext;

        }

        public Task SendAllocationCreatedMessage(AllocationCreated allocation)
        {

            return _hubContext.Clients.All.SendAsync("AllocationCreated", allocation);
        }

        //public Task SendAllocationSavedSuccesfullyMessageToCaller(AllocationCreated allocation)
        //{

        //}
    }

It's not possible to access those from IHubContext. Caller and Others both depend on knowing which client is the caller. When you're in IHubContext, we don't know and there may not even be a current caller since you could be in an MVC controller action, etc.

Just on a side note, I did notice when trying to get things hooked up, that it is possible to see, in the private member variables, a reference to the LifetimeManager and within that I can see the Connection and ConnectionId properties.  I guess these won't always be populated if the client caller is not known, but is there any way to expose this?

The LifetimeManager may contain a list of connections for internal tracking purposes, but it's not going to be exposed.
Like @anurse said, there is no way of knowing who the current caller is from the IHubContext.

therefore you're basically limited to sending to All

Using Groups and Users is one way to mitigate this. If you have access to the User ID of the user who initiated the action, you can use .Users(userId) to send a message to all of that user's connections. Similarly, you add the SignalR connections to a group and send to that group using .Group(groupName)

@anurse, @BrennanConroy, thanks for taking the time to provide feedback.  The advise has been helpful.


Add link to use cases mapping

We might long-term want to standardize this kind of quick reference for each product team?

Probably in the end each use case summary page should link back to the feature areas that enable it.


feature-request: run any file, instead of run current selected file

as the name imply, ability to specify what script to run, instead of run the current selected script.
i dont need an front end for this, just an way to pass parameters (file name)

You can run script with options (from the corresponding menu). Does it suit your needs?

ok, im stupid...
what im trying to do:
open electron to test my app.
how i was trying to do that: add an toolbar to electron, tried to add an option to open electron from the toolbar, since the toolbar was not enough to do that, i installed this add'on ( script) and tried to call electron from it.
the issue is, instead of runing an external program as i wanted, it try to run the current selected file.
so i had to click on the other script file then click on run, i tried to config the {FILE_ACTIVE} to point to an external file, but im not sure how to do that.
instead i found another solution, much simple and easier:
put electron on the F**** Ubuntu unity launcher. ¬¬
now im feeling stupid for wasting hours trying to do something the harder way possible, instead of use the default option of the OS...


fix: Replace Intercom metadata with OpenAPI

Summary
Added OpenAPI file for Intercom.
Scraper tool no longer extracts data from UI.
Removed index.json (used for scraping) and regenerated new schema.json based on OpenAPI file.
Schema changes
schema.json has some changes that I went comparing.
Object names that were lost:

tickets - it can be retrieved via POST /tickets/search, not a conventional GET (as of now Read operation supports GET)
data_events - also gone from UI search
notes - URL contains IDs, so not relevant to us
linked_objects and ticket_type_attributes - these structure are not direct, independent objects (rather member fields, and we do not provide nested schemas)

Some objects were added:

/companies/scroll
/events
/news/newsfeeds == identical OpenAPI definition to == /news/news_items

#961  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Cobalt0s and the rest of your teammates on  Graphite

@eberle1080 just heads up, since your review I moved intercom script under scripts/openapi. I think it is more explicit to keep them there instead of scripts/scrapper (and the last one should be called scraper).


upgrade vm-memory to 0.8.0

The rust-vmm community uses the Comparison requirements form for specific dependencies. The advantage of this is that when a new version of the crate is released, there is no need to update the version for each dependent crate.  But, if the new version of the crate is API incompatible. All libs that depend on it must either be modified accordingly, or the version number must be locked. This is exactly what we do in kata currently. So in the next step we need to modify all the dependent libraries.
Making this work requires the following changes.

[ ] upgrade vm-memory to 0.8.0 for https://github.com/cloud-hypervisor/fuse-backend-rs
[ ] upgrade vm-memory to 0.8.0 for https://github.com/dragonflyoss/image-service
[ ] Use QueueStateSync in virtio-queue instead of QueueState for dbs-virtio-devices. And upgrade virtio-queue to 0.3.0.
[ ] upgrade vm-memory to 0.8.0 for all crates.

Maybe I could help you to upgrade vm-memory to 0.8.0 for fuse-backend-rs and image-service.

@uran0sH Hello there~ You are welcome to help us to upgrade vm-memory to 0.8.0 for fuse-backend-rs and image-service.
And if you encounter any problem during upgrading, please let us know:)

Hi @uran0sH , are you working at vm-memory update in image-service ? Do you need any help about that?

Hi @uran0sH , are you working at vm-memory update in image-service ? Do you need any help about that?

Yeah, but it seems to require waiting for the latest version of fuse-backend-rs to be released to upgrade image-service

@uran0sH Got that, thanks. Let me check whether fuse-backend-rs could do a release.

Hi @uran0sH , fuse-backend-rs has released a new version and maybe you could try to update the vm-memory image-service .
If you encounter any probleam, please let me know.

#213


Nested alternator groups not working

I am trying to validate the following:
((9{1,3})|(S|N)(E|W))-9{1,3}
Valid combinations should be:
999-999
SE-999
NE-999
SW-999
NW-999
But with the multiple groups I get the result:
(S))-123
Is there a way to nest alternators?

@yesman85 ,
(9{1,3})|(S|NE|W)-9{1,3} is currently working
Still working on
(9{1,3})|((S|N)(E|W))-9{1,3} which is actually the same mask but with a complexer syntax.


Added Languages

Languages Added :

coffeescript
dart
zsh
json
ada
agda
charm
coconut
swift
wumpus

Changes Made :

Removed spaghetti code in Readme.md

👍


Table of contents is blank page

Hi,
I'm implementing functionality to export pdf file used ASP.Net core 2.2 and DinkToPdf 1.08. In the first time run project, i can export pdf with table of content as well. But in the next time, it's blank page.
Below is my code:
`
[Serializable]
public class TableOfContentsSettings : ObjectSettings
{
public TableOfContentsSettings()
{
this.ProduceTableOfContents = true;
}
[WkHtml("isTableOfContent")]
public bool ProduceTableOfContents { get; set; }

}
 var doc = new HtmlToPdfDocument()
{
GlobalSettings = {
ColorMode = ColorMode.Color,
Orientation = Orientation.Portrait,
PaperSize = PaperKind.A4,
Margins = new MarginSettings() { Top = 10 },
DocumentTitle = "PDF Report",
},
Objects = {
        new ObjectSettings()
        {
            Page = Path.Combine(currentPath, FOLDER_APP_DATA, "topReport.html"),
        },
        new TableOfContentsSettings()
        {

        },
        new ObjectSettings()
        {
            Page = Path.Combine(currentPath, FOLDER_APP_DATA, "report_new.html"),
        }
}

};
var pdf = _converter.Convert(doc);`

Hello! 😎
Did you ever find a solution for this issue? I tried several things, but without success.

Same here i tried several things but no success,  someone have a solution?


Update ruby-vips to latest version.

This updates vips to latest version. Don't know if it's related to the issues we've had, but I figured it's worth a shot.

Coverage decreased (-0.02%) to 96.0% when pulling 6a25b390a366e435ffa31d5d849da6a7fae19fc2 on update-vips into 82fb30b2013300bcc8b2b6441cb6289d6d65d30e on master.


Completes #100 & misc.

Added enabled flag to SettingsMenuLink.
Added same tile-wide click behaviour to SettingsListDropdown as other list tile components.

This should completely close #100 now.

Thanks!
Having two different versions it's difficult...


Getting errors while removing a song from the list

Based on the code provided, the task 'Getting errors while removing a song from the list' could be referring to an issue in the MusicPlayerCore component. This class handles manipulation of the song list.
These are the following files relevant to this issue:

/Users/macadmin/Desktop/vue-mini-player/src/main.ts
/Users/macadmin/Desktop/vue-mini-player/src/assets/fonts/iconfont/iconfont.js
/Users/macadmin/Desktop/vue-mini-player/src/packs/MusicPlayerCore.ts

Plan:

Firstly, we should inspect the MusicPlayerCore.ts file where the songs appear to be managed. This will include the 'AppendSong', 'UpdateSongPosition', 'PlaySelectSong', 'NextSong', and 'PrevSong' functions among others. It's curious that there is no obvious function to delete a song from the song list here.

Secondly, the issue may lie in how the app uses the MusicPlayerCore component, possibly in the main.ts file or another component. Maybe the program is attempting to reference an id on the SongIdList that has been removed.

Overall, the potential fix for this issue might be modifying how songs are removed from the songs list in the MusicPlayerCore class or fixing where the MusicPlayerCore class is used in your other files.

Suggestion:

Provide a delete or remove function in the MusicPlayerCore class to handle the deletion of a song in a coordinated fashion. This should also take care of any references in the song list that might lead to an exception or error.

Additionally, add proper error handling and logging to identify issues instantly should this issue arise in the future.

If these songs are stored in a database, the issue might be with how the database handles deletion of records. It would be beneficial to check how that is handled in the backend functionality.


Children of FeatureHub provider (react SDK) should be typed as ReactNode rather than JSX.Element

Describe the bug
The Typescript type definition specifies the children of the FeatureHub provider to be a JSX.Element.  While this is true in most cases, the more accurate representation is ReactNode which can express things that React is willing to accept as children, like strings, numbers, booleans, etc. (see here for reference: https://www.totaltypescript.com/jsx-element-vs-react-reactnode).  While this is a nitpicky thing, it does make for a conflict with some strict type systems.
Which area does this issue belong to?

[x] SDK
[ ] SDK examples
[ ] Documentation
[ ] Other

To Reproduce
Steps to reproduce the behavior:

Use typescript
In a component, add something like:

return (
<FeatureHub url="..." apiKey="...">{"Foo Bar Baz"}</FeatureHub>
)

See tsc fail, even though this is a valid (albeit contrived) example.

Expected behavior
tsc would properly typecheck.
Versions

React SDK version 1.2.0

Sorry, missed this PR. 👀

No worries!  Just kinda snuck up on y'all. 😜

Forgot to close this issue with the merge!


Relax validation checks for consumer on DEV-52, as it is manager res…

…ponsibility.

Closes #
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] I have selected a committee co-chair to review the PR

ℹ Additional Information

Closing this PR as a new one with text proposed in WG email created instead.


iOS disable fullscreen

On iOS, video always plays in fullscreen.
Is there a way to play video without going fullscreen on iOS?
This feature works ok on Android.
It seems that webview_flutter can support this?

@despie What's the version you're using ?

I was using youtube_player_flutter: ^6.1.0+2. But I see that this is fixed now in youtube_player_flutter: ^6.1.0+4.
@sarbagyastha Thank you!


Docker push requires Dockerfile

Required Information
Question, Bug, or Feature?
Type: Bug
Enter Task Name: Docker
Issue Description

DockerV2 task push command implementation relies on Dockerfile existence
Although Dockerfile input is used, it is not available in Designer for push command since visibility is: command = build || command = buildAndPush

Which leads to inability to use push command at all, forcing to use V1 or buildAndPush instead.
Task logs
Unhandled: No Dockerfile matching  /home/vsts/work/r1/a//Dockerfile  was found.
Unhandled: No Dockerfile matching  /home/vsts/work/r1/a//Dockerfile  was found.
Suggestion
Docker push should not rely on Dockerfile at all. That's a must.
But task needs to publish deployment metadata to the TeamFoundationCollection URL, it wants to know the base image name. It is not possible to get base image name from the docker image itself.
Also, it is kind of bad design to rely on one base image, since many and many projects use multi-stage builds, hence multiple base images sequentially. But it could be a different topic.
Option 1: Use LABEL (my preference)
Instead of getting base image on the push command, it is wise to retrieve it where we build such container. So, I would keep current logic, but use BUILD task for it instead, adding LABEL with base image information.
Then, in PUSH, I would get base image name using docket image inspect command. No label? Use "unknown" placeholder. Easy-peasy.
Option 2: Provide access to the Dockerfile configuration
So our artifacts should contain Dockerfile and we should be able to provide its path in push command, solved by updating visibility command. But still, leaves Dockerfile requirement and forces to create artifact for it.
Option 3: Remove push command
Since it is now useful in any kind of way right now

@ajinkya599 we should fix this.

Is there anything I can do if I want to push an image in our repository?

@SebAubin, You can either use buildAndPush command or use docker v1 task till push command is fixed. @ajinkya599 should be able to fix the push command early next week in docker v2.

Thanks you!


[release-1.4] Fix reconcile conflict error

This is an automated cherry-pick of #660

@irisdingbj If you can do the @googlebot I consent. Thanks.


Low volume in few videos

Describe the bug
File 1 - https://nyaa.si/view/1890432
File 2 - https://nyaa.si/view/1890473
The audio is particularly low in the first file so I downloaded another file but of the same content and the audio in the second file was also low just like how it was in the first file. So I played the same two files in nextplayer and the audio wasn't low, it reflected the volume level which was at 80%, the audio in mpvkt felt like it was at 50%. No volume boost or anything was enabled in both the players and I tried all the decoders and the audio was low across all the decoders.
To Reproduce
Steps to reproduce the behavior:

Download both the files and nextplayer
Click on either one of the files in mpvkt and then play the same file in nextplayer and you should notice the audio being low in mpvkt, you can even try the second file as well for confirmation that the file is not corrupt.

Expected behavior
The audio level should be the same as nextplayer.
Actual behavior
The audio was quite low when compared to nextplayer, even though the volume was at 80%, it felt like it was at 50% while in nextplayer, it sounded like it was at 80%
Crash logs
If applicable, upload a the text file provided by the app's crash screen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional info (please complete the following information):

Device: OnePlus 12
Android version: Android 14
App Version: v0.1.6

Additional context
Add any other context about the problem here.

I have noticed Vlc and Mpvkt have the same sound levels , While mx player pro is more louder even at low level

iirc, vlc changes the system's volume through android and same with mpvKt.
on the other hand, i don't know how or what mx player is doing to get "lowder" sounds.


Cover using proxy with tests

internal issue id: DDS-2942

Codecov Report

Merging #48 (65358ad) into master (a7bf68a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #48   +/-   ##
=========================================
  Coverage     81.52%   81.52%
  Complexity      347      347
=========================================
  Files            53       53
  Lines          1034     1034
  Branches         52       52
=========================================
  Hits            843      843
  Misses          172      172
  Partials         19       19

Impacted Files
Coverage Δ

.../ee/sk/mid/MidAuthenticationResponseValidator.java
82.02% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


PBJVision returned video URL not working

I'm trying to use PBJVision to get the URL of a video then preview it on a separate part of the app. I'm passing along the URL created with this code:

(void)vision:(PBJVision *)vision capturedVideo:(NSDictionary *)videoDict error:(NSError *)error{
NSString *videoPathString = [videoDict objectForKey:PBJVisionVideoPathKey];
NSURL *videoPathURL = [NSURL URLWithString:videoPathString];
...
}

eventually into this code as selectedMediaURL:
self.player = [[MPMoviePlayerController alloc] initWithContentURL:selectedMediaURL];
[self presentMoviePlayerViewControllerAnimated:self.player];
[self.player.view setFrame:CGRectMake(0, 0, 320, self.view.frame.size.height - 44)];
[self.view addSubview:self.player.view];
[self.player play];
However, the URL seems not to work. If I instead open the same video from the photos album using WSAssetPickerController, I get a different URL but it works.
The URL I get looks something like this: /private/var/mobile/Containers/Data/Application/52A39C59-88A1-4C4F-896B-2D2BECBB0ACE/tmp/video_DCE2796D-992A-423A-9590-63CAB0F7CC67.mp4
However, when I load the same video from the saved photos album I get this URL which does work: assets-library://asset/asset.mp4?id=56E8F701-188C-44C8-B141-9BB7C623A7CC&ext=mp4
Any thoughts?

Don't use:
NSURL *videoPathURL = [NSURL URLWithString:videoPathString];
use:
NSURL *videoPathURL = [NSURL fileURLWithPath:videoPathString];
instead.

thanks @mnmaraes


Last steps before v3.2.1 release

🚀 Pull Request
Description
Now that the bug fixes #4610 and #4605 are in I would to cut the v3.2.1 release.
In this PR I updated the version string and what's new. I also made a fix to a problem with the whats new that I had introduced in #4604. Turns out that underlining your headings with * (aka for chapters) adds an extra link in the side panel. Below shows what the current docs build for the v3.2.x branch looks like:

Fixing the underline to be = (aka for sections), the build of this branch looks like:

Consult Iris pull request check list

Thanks for merging @trexfeathers !


fix(Search): adjustments to place clear button

Suggestions to place clear button and minor adjustments found along the way ☺

Closing this since this was copied over to the main search branch, which is not merged


Add statement expand/collapse option

Description:
Currently there is no way users can collapse statement blocks when going through the diagram like we do in source code.

Suggested Labels (optional):
[Type/UX]

Issue is no longer valid for Swan Lake release. Hence, closing it.

Issue is no longer valid for Swan Lake release. Hence, closing it.


jekyll-crosspost-to-medium-0.1.14/lib/jekyll-crosspost-to-medium.rb:21:in `require': cannot load such file -- kramdown (LoadError)

Here is the complete trace:
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Using bundler 1.16.1
Fetching jekyll-crosspost-to-medium 0.1.14
Installing jekyll-crosspost-to-medium 0.1.14
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Bundled gems are installed into `/usr/local/bundle`
/usr/local/bundle/gems/jekyll-crosspost-to-medium-0.1.14/lib/jekyll-crosspost-to-medium.rb:21:in `require': cannot load such file -- kramdown (LoadError)
	from /usr/local/bundle/gems/jekyll-crosspost-to-medium-0.1.14/lib/jekyll-crosspost-to-medium.rb:21:in `<top (required)>'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:81:in `require'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:81:in `block (2 levels) in require'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:76:in `each'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:76:in `block in require'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:65:in `each'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler/runtime.rb:65:in `require'
	from /usr/local/lib/ruby/gems/2.5.0/gems/bundler-1.16.1/lib/bundler.rb:114:in `require'
	from /usr/gem/gems/jekyll-3.6.2/lib/jekyll/plugin_manager.rb:51:in `require_from_bundler'
	from /usr/gem/gems/jekyll-3.6.2/exe/jekyll:11:in `<top (required)>'
	from /usr/gem/bin/jekyll:23:in `load'
	from /usr/gem/bin/jekyll:23:in `<main>'

Here is hot I installed it.

The Kramdown requirement was old. I removed it. Give it a go now.

But I use it markdown: kramdown.
Why is it a problem?

Hard to say. Maybe Kramdown is only in the bundle?

OK, after removing Gemfile.lock and vendors, it vanished.
I now get:
Error: could not read file /srv/jekyll/vendor/bundle/gems/jekyll-3.7.3/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb: Invalid date '<%= Time.now.strftime('%Y-%m-%d %H:%M:%S %z') %>': Document 'vendor/bundle/gems/jekyll-3.7.3/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb' does not have a valid date in the YAML front matter.
ERROR: YOUR SITE COULD NOT BE BUILT:
       ------------------------------------
       Invalid date '<%= Time.now.strftime('%Y-%m-%d %H:%M:%S %z') %>': Document 'vendor/bundle/gems/jekyll-3.7.3/lib/site_template/_posts/0000-00-00-welcome-to-jekyll.markdown.erb' does not have a valid date in the YAML front matter.

Does not look related to this package.


Reason for PHP 5.6 composer requirement

Hi there,
Just trying to figure out what requires PHP 5.6 in the 2.9 branch of this module? I've had to mirror and knock the dependency down the 5.5 and not seen any issues currently
Cheers

Hi @tr33m4n,
The PHP 5.5 version is not supported by PHP anymore see: http://php.net/supported-versions.php
It could be that it is working in older versions but I highly recommend to use a supported version.
Regards,

@rikterbeek That was what I thought, just wondering whether there was anything in the code base that required 5.6. Thanks for the help
Cheers

Hi @tr33m4n,
No problem any reason why you are not upgrading to 5.6 ?
Regards,
Rik
Adyen

I'd just like to jump in and point out that whilst PHP versions below 5.6 are no longer receiving security fixes directly from PHP, some of those versions do have continued support from certain Linux distributions.  Debian and Ubuntu's LTS releases, for example, are running PHP 5.4.45 / 5.5.9 with ongoing support until May 2018 / April 2019.
There will be developers in the wild whom, for various technical and/or bureaucratic reasons, don't have control over their hosting environment and/or can't upgrade to PHP 5.6, and thus can't upgrade adyen/payment, despite their operating system & PHP package technically still being supported. This is a major sticking point given customers must upgrade to the latest release of this package 2.9.0 for continued Mastercard support.
I understand and agree with dropping support for outdated PHP versions, but in this case I think the limit should've been set a little lower; PHP 5.4 is the earliest version of PHP I can see with ongoing, albeit third-party, support.

I understand your issue but till now we only heard the problem here by two persons and the rest of our merchants are fine with this. We believe it is still the best thing to use PHP versions that are supported by PHP itself.
Regards,
Rik
Adyen

@rikterbeek
With all due respect, I don't think Adyen's idea of what's best should dictate my tech stack. My problem is Adyen unnecessarily restricting the environment in which this plugin runs, in contradiction to the claim of what your plugin is compatible with:

The plugin supports the Magento Community (version 1.8 and higher) and Enterprise edition (version 1.13 and higher).

I can only find information on CE 1.9+ and EE 1.14+, but those versions of Magento require a minimum PHP version of 5.4 and 5.5 respectively.
Although PHP 5.4 and 5.5 is unsupported by PHP themselves, its supported by the latest Magento 1.x release, and it has ongoing security support by Linux distribution maintainers – as my previous comment explains.
If you have a technical reason for requiring PHP 5.6 and above, then that's fair enough – I'll concede my argument if that's the case.
But as far as I can tell, which this discussion hasn't shed any light on, there is no technical argument for the constraint; you guys just decided one day to require PHP 5.6 one day, and you have put the onus on your customers to work around that.
For our projects, we don't want to be in a position where we're running outdated code. We also don't want to upgrade our production runtime environment on a whim, because that's a high risk change. We're working around this by maintaining a private fork of this plugin with the version constraint removed – and that's running just fine on PHP 5.5.
If we accept the realities of our industry, however, surely you recognise that you are putting your customers in a position where they'll just continue running an outdated Adyen plugin, because that is both the path of least resistance, and least risk to their site overall. Is that what you want your cusotmers to be doing?


enable bidirectional code file updates

Goal: when a user edits a SQL or YAML file outside of Rill Developer while the application is running, it should (1) perform reconciliation and (2) update the UI.
We've decided in the interest of expediency that we'll handle this reconciliation in the frontend. As such, we'll need to implement the following:

surface any additions to / removals from the filesystem in the navigation bar
if a file artifact is active (i.e. a user has a model focused in the workspace) and the underlying artifact updates, a.) update the artifact in the UI and b.) perform reconciliation. We should poll the file for these changes as well.

Notion doc is here: https://www.notion.so/rilldata/WIP-Update-code-files-bidirectionally-838773df2e3e4638ba96ded5bc14d9fb