RuntimeError: cuda runtime error (77) : an illegal memory access was encountered

当我训整个框架的时候，出现了：
THCudaCheck FAIL file=/pytorch/aten/src/THCUNN/generic/SpatialClassNLLCriterion.cu line=134 error=77 : an illegal memory access was encountered
Traceback (most recent call last):
File "exp/spatial_correction_cityscapes/python/train.py", line 292, in
train()
File "exp/spatial_correction_cityscapes/python/train.py", line 181, in train
loss_semantic, loss_cfnet = net(img_list, label=gt_label)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 445, in forward
output = self.module(*inputs[0], **kwargs[0])
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/data/video_network/DAVSS/lib/model/scnet.py", line 75, in forward
loss_semantic += self.semantic_loss(img_3_out_propagate, label)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/modules/module.py", line 550, in call
result = self.forward(*input, **kwargs)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/modules/loss.py", line 932, in forward
ignore_index=self.ignore_index, reduction=self.reduction)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/functional.py", line 2317, in cross_entropy
return nll_loss(log_softmax(input, 1), target, weight, None, ignore_index, None, reduction)
File "/data/anaconda3/envs/wang-davss/lib/python3.7/site-packages/torch/nn/functional.py", line 2117, in nll_loss
ret = torch._C._nn.nll_loss2d(input, target, weight, _Reduction.get_enum(reduction), ignore_index)
RuntimeError: cuda runtime error (77) : an illegal memory access was encountered at /pytorch/aten/src/THCUNN/generic/SpatialClassNLLCriterion.cu:134
terminate called after throwing an instance of 'c10::Error'
what():  CUDA error: an illegal memory access was encountered (insert_events at /pytorch/c10/cuda/CUDACachingAllocator.cpp:771)
然而不知道出了什么问题，不知道作者遇到过没有，希望予以解答。

Thanks for the interest in our work. Actually, I haven't encountered this problem. It may be caused by incompatible pytorch version or cuda version.


OIDC Authentication with Authentik

Describe the bug
When attempting to login using OIDC authentication with Authentik as the SSO, once SSO returns the authentication information back to Firezone, receive an 502 Bad Gateway.  The return URL being generated is:
https://firezone.domain.com/auth/oidc/authentik/callback/?code=[REMOVED]&state=[REMOVED]
The ConfigID is set to "authentik".  If logs are needed, please let me know which ones.
However, the user is actually created and added to the Firezone database.  I'm not sure if the returnurl is correct, but Nginx reports a 502 error.
Platform (please complete the following information):

Firezone Version [e.g. 0.7.30]
OS: Linux
Distro: Ubuntu 22.04
Kernel version: 5.15.0
Deployment method: Docker

Closing, increasing buffers on my reverse proxy (nginx) solved.

Closing, increasing buffers on my reverse proxy (nginx) solved.


Add option for a area graph in markets with multiple options

It's very hard to make sense of this graph:

A much better option, in my opinion since all markets have a constant sum, would be a total area graph:

Might be better to break up the catch-all chart into individual charts -- give the top three options their own line chart.

Moved to CH


Cannot share view variables that depend on session

Session is started using middlewares after every service provider is booted, so if I try to access currently authenticated user in boot method to share it between views, the session isn't started yet so user is inaccessible.
To handle this I create wildcard view creator:
View::creator('*', function ()
{
  static $shared = false;

  if ($shared) return;

  // share view vars...

  $shared = true;
});

Is there a better way?

Yeh, don't use a closure, but an object bound as a singleton.

You're not following me. Try adding such code to AppServiceProvider::boot:
$this->app['view']->share('user', $this->app['auth']->user());

You'll always get null even if the user successfully logged in. That happens because session is started in SessionStart middleware that is executed after the application is booted.
My only solution is to add a wildcard view creator and use static variable to make sure that required variables are shared only once.

I can't replicate. It's working fine for me https://github.com/StyleCI/StyleCI/blob/master/app/Composers/LoggedUserComposer.php.

It works fine with view composers, of course, but I need global view variables that will be available for every view ($currentUser, $signedIn, etc). This is done by using shared variables.

Maybe share a closure?

I could use helper functions instead =) The problem is that you can't access session data in boot method, not view variables, it's just a case.

Use Illuminate\View\Factory::compose('*', ComposerClassHere).
This will be called on all views. You can share all the variables you want there.


Added the ability to prettify GraphQL queries

This PR intends to add the ability to do GraphQL query prettification. It adds a editor shortcut (cmd-p or ctrl-p) and also a button above the query editor to do prettification.
I am not a pretty big fan of the icon for the prettify button, I had that auto-fix magic wand icon in my mind but I think it is removed from the material icons collection now. @liyasthomas it would be awesome if you could replace that with something more aesthetically pleasing.
NOTE to Translators: Added new entries for i10n

@AndrewBastin you beat me to this. I thought about adding this the other day hehe :D Nice!


The test setting is wrong.  cid for one dollar should be 0.0

Challenge Exact Change has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/601.4.4 (KHTML, like Gecko) Version/9.0.3 Safari/601.4.4.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
function checkCashRegister(price, cash, cid){
  var change = (cash - price).toFixed(2);
  console.log("change: " + change);
      unitCoinValue = {
        "PENNY": 0.01,
        "NICKEL": 0.05,
        "DIME": 0.10,
        "QUARTER": 0.25,
        "ONE": 1.00,
        "FIVE": 5.00,
        "TEN": 10.00,
        "TWENTY": 20.00,
        "ONE HUNDRED": 100.00
      };
      result = {};
  var cidTotal = cid.map(function(each){return each[1];})
                 .reduce(function(a, b){return a + b;});

  if (change < 0){
    throw new Error ("Not enough money to pay the price");
  }else if (change === 0){
    return ("Just the right amount to pay for the price.");
  }

  if (change > cidTotal){
    return "Insufficient Funds";
  }else if (change == cidTotal){
    return "Closed";
  }

  for (var i=cid.length-1; i>=0; i--){
    var coinName = cid[i][0],
        unitValue = unitCoinValue[coinName];
        coinValue = cid[i][1];
        console.log(coinName);
    while (change - unitValue >= 0 && coinValue - unitValue >= 0){
        change = (change - unitValue).toFixed(2);
        coinValue = (coinValue - unitValue).toFixed(2);

        console.log("change: " + change);
        //result[coinName] ?  result[coinName] += unitValue : result[coinName] = unitValue;
        if (!result[coinName]){
          result[coinName] = unitValue;
        }else {
          result[coinName] += unitValue;
        }
    }
  }
/*
  if(change > 0){
    return "Insufficient Funds";
  }else if(i === 0 && coinValue === 0){
    return "Closed";
  }
*/

  var changeArr = [];
  for (var key in result){
    changeArr.push([key, result[key]]);
  }
  console.log(changeArr);
  return changeArr;
}

// Example cash-in-drawer array:
// [["PENNY", 1.01],
// ["NICKEL", 2.05],
// ["DIME", 3.10],
// ["QUARTER", 4.25],
// ["ONE", 90.00],
// ["FIVE", 55.00],
// ["TEN", 20.00],
// ["TWENTY", 60.00],
// ["ONE HUNDRED", 100.00]]

checkCashRegister(19.50, 20.00, [["PENNY", 0.01], ["NICKEL", 0], ["DIME", 0], ["QUARTER", 0], ["ONE", 1.00], ["FIVE", 0], ["TEN", 0], ["TWENTY", 0], ["ONE HUNDRED", 0]]);

//```["ONE", 1.00],  should be ["ONE", 0], otherwise it would not be "insufficient fund".  Thanks.

The reason ["ONE", 1.00] should return "Insufficient funds" is because you cannot give the customer a 1 dollar bill if the change is 50 cents. You would need some combination of coins (such as 5 dimes or 2 quarters) and the only coin in the drawer is 1 penny.

@alistermada Thanks for the quick answer!

Thanks.  oops, I missed that.
On Wed, Apr 13, 2016 at 12:11 AM, Alister Najib Mada <
<EMAIL_ADDRESS>wrote:

The reason ["ONE", 1.00] should return "Insufficient funds" is because
you cannot give the customer a 1 dollar bill if the change is 50 cents. You
would need some combination of coins (such as 5 dimes or 2 quarters) and
the only coin in the drawer is 1 penny.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/8084#issuecomment-209217902


Responses based the context of the conversation

Hi, How to make a response based in the context of the conversation?
I mean, if the user say 'I have an error' is not the same if previously he said he was transferring money that if previously he said he was changing his password
So, how can I manage responses based in the context of the conversation?

Hi @juanpialbano, I am currently working on changes that will add support for this functionality. It currently isn't possible but it will be once I finish making those modifications. See #828 for details.


ERROR: Cause: executing external native build for cmake

I download your code but cant compile it on my machine
ERROR: Cause: executing external native build for cmake C:\projects\lz4-android-master\library\CMakeLists.txt
I'm using Android Studio
My project cant figure about the cmakelists, so Iam asking how should I compile it, what I might did wrong?

Sorry for the late reply! I forgot to watch my own project... Can you try again with the latest master? Make sure you have the right CMake version in Android studio with Tools > SDK Manager > SDK Tools (tab) > Show package details,  matching the one referenced in Gradle library build file. (3.18.1 at the time of this writing)


importing s3 changes

IBM Cloud Continuous Delivery Bill of Materials
 Download Bill of Materials Report: [JSON Format]
Bill of Materials Diff
Compare To: [Branch = master] [Commitid = d1ce87ed3ea045a5bc9d160e1ceb47fb394deac5]
No diff found

IBM Cloud Continuous Delivery Vulnerability Report

 :white_check_mark: Manifest File: Dockerfile-openliberty/open-liberty:kernel-slim-java11-openj9-ubi

Vulnerability Data by Clair
No OS package vulnerabilities found

 :white_check_mark: Manifest File: pom.xml

Vulnerability Data by Snyk
No application package vulnerabilities found

IBM Cloud Continuous Delivery Deployment Configuration Analysis
:white_check_mark:    Manifest File: manifests/deploy-openshift.yaml
 No configuration risks discovered


Homework help C++

I’ve always got some project doing on around the house. I had been using what was originally to be a storage closet as an office. It has a laminate floor which are supposed to be indestructible, but after 20+ years of moving an office chair back and forth, the layers began to separate and now I’ve got a worn spot in the middle of the room. Unfortunately the separate pieces of laminate are glued together so now I have to replace the entire floor. We’ve decided to replace it with vinyl tile and I need to figure out how much new tile I need because the tile comes in different sizes and prices. I also want to be able to compare the cost between different styles of tile..
Assume that the tiles come in square pieces, of some length and width, and the dimensions of the room is a rectangle. The way to figure this out is:
Figure out how many tiles are needed to go across one “stripe” of the room. If there is a fractional amount of tiles needed, you’ll need to round up (since you’re using a whole tile and cutting it up). For example, if the room was 10 feet across, and a tile was 2 feet across, you would need 5 tiles. If the room was 10 feet across, and a tile was 3 feet across, you would need 4 tiles (since 10/3 rounds up to 4).
Figure out how many different stripes of tiles are needed, again rounding up if you have a fraction.
Multiply the tiles per stripe times the number of stripes to get the number of tiles needed for the whole room.
Multiply the number of tiles times the per tile cost.
Your job is to write a C++ program where the relevant information is input as doubles and computes the (integer) number of tiles needed and cost. Recall that cmath has a “ceil” function that takes a double and returns the double rounded up to the next integer if it is not an integer already.
You should use the assert statement to ensure that all values that are input are positive.

one of the test cases
Enter the size of a tile: 1.5
Enter the length of the room: 8
Enter the width of the room: 7.5
You will need 30 tiles
Enter the cost per tile: 2.25
Total cost of the floor is $ 67.50


IndexError: list index out of range

hello, Dr. thank you for your work.
When I run this step, it has this problem. Could you help me? Thank you!

Yes, it solved. Thank you! But I meet another problem.  It always show this. Could you help me? Thank you!


SystemExit: fail to find libnux

Hi.
The SystemError is raised during
from optimum.furiosa.utils import export_model_to_onnx

in the run_image_classification.ipynb when running in colab
SystemExit: fail to find libnux

and in image_classification.ipynb on import
from optimum.furiosa import FuriosaAIModelForImageClassification

Hi @amrzv, have you followed these setup instructions?
It seems that furiosa-libnux has not been installed in your environment.


[Nodes Page] Nodes detail page

⚠ This PR depends on #1218
This PR separates the tabs in the nodes detail page into container and component.
Testing this PR will require the cnvs-upgrade branch in reactjs-components checked out and linked locally, and use of the REACT_JS_COMPONENTS_LOCAL=true EV.

I'm going to merge this and open a PR against mod/1.10 to remove all inverse classes and bind the PureRenderMixins.


Rails 5 WARNING

➜  rails generate devise:install                                                                                ruby-2.3.0
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Volumes/Media/Projects/rails5/SkyEngine/config/application.rb:8)
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Volumes/Media/Projects/rails5/SkyEngine/config/application.rb:8)
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from <top (required)> at /Volumes/Media/Projects/rails5/SkyEngine/config/application.rb:8)
Running via Spring preloader in process 58559
conflict  config/initializers/devise.rb
Overwrite /Volumes/Media/Projects/rails5/SkyEngine/config/initializers/devise.rb? (enter "h" for help) [Ynaqdh] y
force  config/initializers/devise.rb
identical  config/locales/devise.en.yml

fixed))

How did you solve it? Im refereeing to master branch but i still getting this warning many times.


Update card details doesn't work

When updating card details on an existing contribution, once all details are entered, the "save" button does not light up. In order to update my details, I had to cancel my subscription and re-affiliate with the page in question.

@GazCloud Thank you for reporting that. Can you try again?
If this doesn't work can you make a video of it? Alternatively, provide a precise description of every step with screenshots?

Hi François,
I tried this several times on the last attempt, but just once today - it worked first time. No idea what the issue was last time around...
Thanks,
Gareth

From: François Hodierne<EMAIL_ADDRESS>Sent: 07 November 2018 10:22
To: opencollective/opencollective
Cc: Lowe, Gareth (Branch Activist); Mention
Subject: Re: [opencollective/opencollective] Update card details doesn't work (#1409)
@GazCloudhttps://github.com/GazCloud Thank you for reporting that. Can you try again?
If this doesn't work can you make a video of it? Alternatively, provide a precise description of every step with screenshots?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/opencollective/opencollective/issues/1409#issuecomment-436576495, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Aqu_Wkdyrxks45NKrYA_nXwSDqddnYmRks5usrR9gaJpZM4YSJMi.
Disclaimer
The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful.
This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website.


Xcode 14.3 - Swift 5.8

Describe the bug
Swift Version 5.8 is not working and ClientRuntime is throwing an error:
Cannot use a version of Swift greater than available.
Please create a Github issue for us to add support for the version of Swift you want to use.

Steps To Reproduce
Steps to reproduce the behavior:
1. Update Xcode to 14.3
2. Install amplify-swift package with version set to 2.0.0 Next Major
3. Run your project
4. Compile error shows up displayed as above

Expected behavior
Project should compile and run
Amplify Framework Version
2.2.1
Amplify Categories
API
Dependency manager
Swift PM
Swift version
5.8
CLI version
10.7.2
Xcode version
14.3
Relevant log output
<details>
<summary>Log Messages</summary>

INSERT LOG MESSAGES HERE

```
Is this a regression?
No
Regression additional context
No response
Device
iPhone 14 Pro
iOS Version
iOS 16.4
Specific to simulators
No response
Additional context
No response

Hey @kaanselhep, thanks for opening this issue.
This was fixed once the Xcode 14.3 beta was released in February. You'll just need to update to version 2.4.1 or later. We recommend using the most recent version 2.7.1 to get the newest features and bug fixes.
linking original issue: https://github.com/aws-amplify/amplify-swift/issues/2771

Hi @atierian , yep it compiles with 2.7.1! Thanks for that!


force:mdapi:listmetadata returns an array or an object depending on the number of results

Summary
When calling force:mdapi:listmetadata the type of the response result varies depending on the number of records returned. A better approach would be to always return an array to guarantee the integrity of response format.
Steps To Reproduce:

Run a list metadata command which returns a single record.

sfdx force:mdapi:listmetadata -m LeadConvertSettings --json
{
	"status": 0,
	"result": {
		...
		"type": "LeadConvertSettings",
		...
	}
}

Run a list metadata command which returns multiple records.

sfdx force:mdapi:listmetadata -m CustomPermission --json
{
	"status": 0,
	"result": [{
		...
		"type": "CustomPermission",
		...
	}, {
		...
		"type": "CustomPermission",
		...
	}]
}

Expected result
sfdx force:mdapi:listmetadata -m LeadConvertSettings --json
{
	"status": 0,
	"result": [{
		...
		"type": "LeadConvertSettings",
		...
	}]
}

Additional information
SFDX CLI Version:
sfdx-cli/7.57.1-dbf54fc584 win32-x64 node-v10.15.3
OS and version:
Windows 10.0.18363 Build 18363

On current versions, the result is always an array


Could not find com.opentok.android:opentok-android-sdk:2.10.1-REL-2782.

I have a module(sdk) in my android project that uses opentok internally. Lately my builds are failing on CircleCi with the following error :
> Could not find com.opentok.android:opentok-android-sdk:2.10.1-REL-2782.
           Required by:
               project :identity

Works okay locally, but when the build gets generated on CircleCi, i'm getting the above error. It used to work earlier though. Didn't know where to go, appreciate any sort of help.
Thanks in advance.

Hi @tejasna
Please, replace the old maven url for this new one "maven { url 'https://tokbox-telefonica.bintray.com/maven' }".
Best,
Marina

Hey @marinaserranomontes
That did the trick!  You just saved me hours of effort.
Thank you so much.

@tejasna Please keep in mind that this URL has been temporarily changed, we will keep you updated if there are any more changes.

@tejasna As of 11/15/17 ~7:45 am PST: We've restored the original URL: https://tokbox.bintray.com/maven/
Please switch back from using the temporary URL to the original URL.

Thanks @msach22, can confirm the original URL tokbox.bintray.com/maven/ works 👍


Stop subscriptions

Add methods to start and stop the GraphQL subscription manager

Could you please elaborate more on start feature?
I can understand why stop  all subscriptions makes sense, but what is the point of having start?

The start feature re-enables the auto-connect feature in doSubscribe(), which we disable when we call stop() (by setting the state to STOPPING/STOPPED).  We want to disable the auto-connect feature so that new subscribe() calls will not cause transport.connect() to be called.
The use case where we need it is when the Android app is stopping, in which case we want to close the web socket gracefully, and be sure it isn't inadvertently restarted.  I think the edge case we're concerned about is when a user navigates to a Fragment that initiates a subscription in onStart(), and then immediately exits the Activity (which would call stop() in the Activity onStop()) .  In that case, there is a possible race condition between the subscribe call and the doUnsubscribe() calls in stop() (since subscribe() runs doSubscribe() on the dispatcher thread pool).

Sorry for the delay was off the grid, could you please add unit tests as well

And try to rebase to the latest master, not sure why CI is failing


Upgrade checks for both server and CLI

Is your feature request related to a problem? Please describe.
It would be very useful to let someone using the Epinio CLI to know that they should update their client when the server gets updated. It would also be useful to an admin to show when an update to Epinio as a whole can be upgraded.
Describe the solution you'd like
A MOTD-like output when there is a mismatch in client/server or an upgrade available to the server. This could also be shown in the UI as well.
Extra points for a way to let the client update itself in-place.

We can add an header with the version to every server response, so the CLI can check it and show the message eventually.

I started working on this here: https://github.com/epinio/epinio/tree/1153-cli-check-new-version
The version mismatch warning is easy to implement. This is what I'm doing so far:
~/workspace/epinio/epinio (1153-cli-check-new-version)$ epinio app list

🚢  Listing applications
Namespace: workspace
2022/09/22 16:40:51 EpinioApiClient: "msg"="Epinio server version (v1.2.0-23-g11a2d241) doesn't match client version (v1.2.0-24-g933c0883)" "error"="version mismatch"

✔  Epinio Applications:
| NAME | CREATED | STATUS | ROUTES | CONFIGURATIONS | STATUS DETAILS |
|------|---------|--------|--------|----------------|----------------|

This doesn't even need to compare the 2 versions and tell which one is older. It simply states the mismatch. I think this is ok since sometimes what you need is a downgrade of the client (e.g. when switching to an epinio instance that runs and older version).
Suggesting an upgrade of Epinio needs us to compare the current epinio-server version with the latest release. I think there are libraries that can compare semantic versions but this still poses some problems:

When should that check happen? (keep in mind it involves some request to discover the latest Epinio release version)
Who should be able to see this? (The epinio client doesn't have a concept of the user's role, it simply sends requests over to the server. Should it happen server side?)
What versions do we compare? An upgrade may be needed if a new helm chart version is released, even if the server version is the same. On the other hand, if someone deploys Epinio manually, without helm (which is possible), the helm release version is no longer relevant.

In any case, warning about a full Epinio upgrade should be a separate issue. I will stick to the client "sync" for this issue and we can create another one for the full upgrade, if we decide we want it.

There are 2 options on when to put the server version in a header:

Put it in every request (unauthenticated requests too)
Put it only in authenticated requests

Solution #1 can be considered bad from a security perspective because we are making the server version available to the world. In case it has a security issue, everyone will be able to tell.
Solution #2 will be  problem if the out-of-sync client is unable to login (e.g. because we changed how authentication works).
I'm not sure which one is worse.

kuberlr is trying to handle the LinkError too: https://github.com/flavio/kuberlr/blob/master/internal/downloader/download.go#L195
let's see if we also need this

haha, i think this is indeed useful as some of our engineers waste hours to figure out why thier cli/deployment not working.
In our CI/CD, we just run this command to ensure client and server are in sync
#Makefile
ep-ver-check:
	./scripts/makefile.sh ep-ver-check

# makefile.sh
function ep-ver-check {
	TMP_DIR=$(mktemp -d -t epinio.XXX)
	epinio info > ${TMP_DIR}/ep-version.txt
	cat ${TMP_DIR}/ep-version.txt
    SERVER_VER=$(cat ${TMP_DIR}/ep-version.txt | grep 'Server Version' | awk -F\: '{print $2}' | sed 's/[[:alpha:]]//g' | sed 's/[[:space:]]//g')
    CLIENT_VER=$(cat ${TMP_DIR}/ep-version.txt | grep 'Client Version' | awk -F\: '{print $2}' | sed 's/[[:alpha:]]//g' | sed 's/[[:space:]]//g')
    if [ ${SERVER_VER} != ${CLIENT_VER} ]; then
        echo "$SERVER_VER != $CLIENT_VER"
        exit 1
    fi
}

I solved the Windows error by first moving the running binary and then copying the new binary to the original location: https://github.com/epinio/epinio/commit/f57180b984e6b1f5b40b8d625b5cd57e075b02da#diff-4e6707db4f2615e4e307ba0ef9616f5adf2999a9209b27f19e2de60d536b7513R57-R68
Windows are fine with that. The only problem is that I can't delete the running binary (I can only move it), but I moved it to a tmp directory so it's up to the OS to clean it up. I've read Windows are not very good in cleaning up tmp directories but that's the best solution I could find.

How about naming the old binary in the tmp directory in a distinctive way ?
Then, when the user uses the new binary, let it look in tmp for its old copy and remove it.

How about naming the old binary in the tmp directory in a distinctive way ? Then, when the user uses the new binary, let it look in tmp for its old copy and remove it.

that's #3 also suggests here: https://github.com/restic/restic/issues/2248#issuecomment-903872651 . I'm not sure even invocation of the binary should try to cleanup old binaries. This is an operation that could fail for many reasons and it would render the binary unusable until fixed.

Ignore failures in the cleanup ?

I'd rather leave this to the OS to be honest. If the OS does its job, it should be fine.

Checked on branch on MacOS and working


Update sbt-updates to 0.6.1

Updates com.timushev.sbt:sbt-updates from 0.6.0 to 0.6.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.6.0).
You might want to review and update them manually.
ember-server/js/yarn.lock
prometheus-metrics/src/main/scala/org/http4s/metrics/prometheus/Prometheus.scala
website/src/hugo/content/changelog.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.timushev.sbt", artifactId = "sbt-updates" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

Redundant following #5777


Is this package still being maintained?

Thanks to the authors for a great package. I think judging by the stars and issues list you have many loyal users. It'd be great to know how the community could help take up some of the slack.
Let us know!

Hey, it's very nice that you are offering to help maintain this library, I'd love to use any help. When creating it, I wanted to share something that was very necessary in the early project, but the assumptions have grown very much, so for example, we have so many animations in it. My minimum plan was to create a wrapper for previewing photos, which I suspect was successful. I will share with you the plans I had and which I still have, but I cannot implement them in the near future due to excess work.
What is the goal?
Create a tool not only for previewing photos, but give users more opportunities to create something similar to movement and the way it is done, known from the Miro application. With support for html, canvas etc.
For this you need a few things:

Most of the features are in place, now it would be time to clean up and optimize the library code
Improving how props are accepted and organized in the application (it's also a matter of architecture)
Support for prop "ref" to allow external access to the state library and methods
Correct velocity calculations for different zoom levels
Try to significantly increase the performance of the library
Implement full typescript support (in the beginning I created the library in pure js)
Automatic library tests

If anyone would like to help me in further development, please let me know. Thanks for such interest and commitment!

Hey,
Thanks for replying! It's really a great package so I'd definitely be interested in helping out. I can't give a lot of time but I should be able to give some.
I think your vision sounds great. In order to learn the codebase the best way for me to start is probably to begin triaging issues and pull requests, if that's ok with you.
Hopefully others will come along too!

Hey,
Thanks for replying! It's really a great package so I'd definitely be interested in helping out. I can't give a lot of time but I should be able to give some.
I think your vision sounds great. In order to learn the codebase the best way for me to start is probably to begin triaging issues and pull requests, if that's ok with you.
Hopefully others will come along too!

Sounds great, thanks!!

Hello @prc5,
Please review my PR #156. In the PR, I have added types that were missing which will be useful for the end-user. I believe that it is one of the goals that you have mentioned in this issue (improving typescript support).
Thank you in advance.

Some update from my side - as I started the project long time ago, I didn't really though it will get so much attention. I know I wasn't super active for more than year. I'm really glad that so many posted pull requests but the lib state itself wasn't good enough to iterate over this old codebase - so I managed to rewrite it to typescript, not like it was before. Now I need to clean up some stuff there, prepare docs, go through the issues and manage to fix what's left and close what's fixed. I've added some more features, fixed broken/bad logic, simplified it and boosted the performance. There will be proper typescript as I mentioned, everything got it's full types setup. I've moved from my custom docs page to the storybook - it will have much better usability I think, so it will be a good place to build the proper, interactive documentation.
Version 2.0 will also make some changes to the props setup - better namings, less confusing props - and the best one - support for the ref - you will get the whole class reference there, as well as state and helpers etc. I hope you will like it :)


Possibly incorrect polarity position

As I am investigating https://github.com/clulab/eidos/issues/717, I found that the root cause (without going into too much detail about why after various conversions it ultimately results in an error) is a possibly misplaced polarity flag at: https://github.com/WorldModelers/Ontologies/blob/master/wm_metadata.yml#L1711-L1733. If I shift the polarity on line 1733 inwards to be under water_commodity, the error is resolved.
Would making this change be correct? Or am I missing something?

I think so.  Polarity and name seem to need to be indented the same.


Max cookie size assert

In relation to https://github.com/simplabs/ember-simple-auth/issues/1534#issuecomment-365184577

@marcoow Thanks for the review! I've made the changes and added a unit test
Now, I wasn't sure whether you prefer the MAX_COOKIE_SIZE_LENGTH to be used by the unit test, or whether to decouple the test from the unit entirely. So I've gone for the latter option, the for-loop runs enough times to generate a value that is always above 4096 bytes.

I restarted the build - seems like the failures were unrelated actually.

@omairvaiyani: tests run now but there are some ESLint issues…

I fixed the linter errors. This should be good to go after #168 is merged and this is rebased.

Hey @marcoow thanks for sorting this!


Make inserting the small deletion register repeatable with .

This was a small annoyance of mine, not being able to repeat inserting the small deletion register using .
So now you can use ciw"<C-R>-" and surround your word with quotes. This is kind of like what surround provides (I think). After you have done this once, press . on a word to have the whole operation repeated for the word under the cursor.
While at it, I noticed a comment that hasn't been updated, since do_put has been put into registers.c, so remove mentioning do_put in ops.c.

looks like the codecov step on github actions is brocken :(

Yes, codecovsh fails since a few days...

looks like @ichizok took already care of it: https://github.com/codecov/codecov-action/issues/186 and this needs fixture on codecovs side.


[4.0] [APINotes] Always provide an unversioned SwiftName of some kind.

Explanation: We use API notes to record whether a particular C/ObjC API has changed its name for Swift 4. However, if it had a custom name in Swift 3 and then went back to the default in Swift 4, the Swift 4 name would not be visible in Swift 3 mode. (This is a correctness issue for types, which we always import under their Swift 4 name.) This patch fixes that by explicitly recording the absence of a custom name.
Scope: Fairly narrow; the situation described doesn't seem common. The Swift-side change affects the order things are printed in, but only the order.
Issue: rdar://problem/31826517
Reviewed by: @DougGregor (Clang-side change), @nkcsgexi (Swift helper change)
Risk: Low. Does not affect non-API-notes Clang at all, and uses existing code paths on the Swift side. One minor change to the way declarations are printed in Swift is needed for consistent behavior across platforms.
Testing: Added compiler regression tests, verified that the original test case now behaves as expected.

@swift-ci Please test

Hm, I may have still missed something.

apple/swift#9414
@swift-ci Please test macOS

Note: this passed full testing in apple/swift#9453.

Aack, wrong branch.


[BugFix] - Prefetching on GPU is actually executed on CPU

When applying the following:
dataset = dataset.apply(
    tf.data.experimental.prefetch_to_device(
        '/gpu:0',
        buffer_size=1,
    )
)

Tensorflow behind the hood does two additional things:

Create an _OptionsDataset (everything is fine since the underlying _variant_tensor is not touched)

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/experimental/ops/prefetching_ops.py#L76-L78
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/ops/dataset_ops.py#L4323

Prefetch a number of batches on GPU depending on buffer_size => Issue is Here
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/experimental/ops/prefetching_ops.py#L54

The problem is that gen_dataset_ops.prefetch_dataset defaults on CPU and basically re-copy the dataset back on the CPU. Effectively killing the purpose and adding some overhead.
The fix is simple, just adding with ops.device(input_dataset._variant_tensor.device): depending on where the _variant_tensor is already located
CC: @sanjoy
To Be Noted: This issue will re-appear if the user does not prefetch to device as the "last step" of the TF Data Pipeline. Maybe a warning should be executed in case the user does not respect this heuristic
Eventual Question: Could someone explain the rationale behind these lines, why prefetching to device should have optimizations and autotune deactivated?
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/data/experimental/ops/prefetching_ops.py#L73-L75
options = dataset_ops.Options()
options.experimental_optimization.apply_default_optimizations = False
options.experimental_optimization.autotune = False
return _CopyToDeviceDataset(
  dataset, target_device=target_device,
  source_device=source_device).with_options(options)

CC @jsimsa @mrry @rohan100jain

@DEKHTIARJonathan thank you for the detailed information. Would you be interested in submitting a fix for this issue? If so, please also include a unit test that fails prior to your bug fix and passes afterwards.
As for your eventual question, the reason for those settings is to avoid chaining the ModelDataset and OptimizeDataset transformations to the end of the input pipeline because the transformations only have GPU kernels.

@jsimsa It's a PR so you just have to merge and we are good ;)

As for your eventual question, the reason for those settings is to avoid chaining the ModelDataset and OptimizeDataset transformations to the end of the input pipeline because the transformations only have CPU kernels.

Stop me if it doesn't make any sense
Why instead of doing:

CopyToDevice
Deactivate Optimization & Autotune
Prefetch

We don't do:

Activate Default Opt & Autotune
CopyToDevice
Prefetch

Sorry, I thought this is an issue (as opposed to a PR) :-).
The options need to be set because otherwise tf.data will chain the two datasets to the end of the input pipeline when creating an iterator for it. However, you have a good point in that the host dataset should have optimizations and autotuning applied to it. This can be done as follows and you are welcome to add this functionality to this PR. Thanks!

I would be in favor of cherrypicking this into TF 2.2.

@jsimsa I have added two lines in the unittests, that should be fine and sufficient to show pass/fail.
Btw. I just found that this code lead again to the same issue:
iterator = dataset_ops.make_initializable_iterator(device_dataset)
next_element = iterator.get_next()

@jsimsa I pushed the unittest showing both issues and fixed the problem in the same way for prefetch and iterator.get_next()
Please let me know if I can do anything else

@jsimsa Exploring a little I find a bunch of couple identical bugs. I have updated the PR, however numerous changes needs to be done before/after merging this PR:

Relying on the TensorFlow placer implementation as you suggested instead of ops.colocate_with().

Most TF Data Options are in fact incompatible with GPU placements. I removed the .with_options() from the prefetch_to_device implementation and directly bypassed the options in case we are running on GPU. This has two advantages:
2.1 Users can still set the options ( even if they are not used ) and later benefits from any GPU implementation we provide with updating their code.
2.2 This is more generic as most (all ?) of the optimizations are in fact failing if the dataset._variant_tensor is on the GPU.

@sanjoy Could we discuss a little the strategy here next Wednesday meeting ? @jsimsa feel free to join ;)

tf.device is much better, thanks. I am still unsure what happens if the
user places the iterator creation in a device scope; now we'll ignore their
action and always place it on the dataset device. I think the same number
of copies happens in either case but if the iterator gets put on the user's
device (as opposed to the device we choose) we might be able to a better
job of prefetching the tensors there.
I'm not sure; I need to think a little more about this.
On Tue, Apr 7, 2020 at 4:32 PM Jonathan DEKHTIAR<EMAIL_ADDRESS>wrote:

@DEKHTIARJonathan commented on this pull request.
In tensorflow/python/data/ops/dataset_ops.py
https://github.com/tensorflow/tensorflow/pull/37277#discussion_r405173524
:

@@ -2194,14 +2194,17 @@ def _make_initializable_iterator(self, shared_name=None):  # pylint: disable=mis
dataset = self._apply_options()
if shared_name is None:
shared_name = ""

iterator_resource = gen_dataset_ops.iterator_v2(

with ops.colocate_with(self._variant_tensor):

@alextp https://github.com/alextp thanks you so much for you answer :)
I wasn't aware of this issue with colocate_with.
I did something really naive and replaced with ops.colocate_with() to with
ops.device().
That actually perfectly works and even pass my unittest easy.
bazel test --verbose_failures //tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test
Could this be acceptable ?
it has the advantage to completely fix the colocation issue you raise and
fully address point 1) and 2) without any additional change. And most
likely will be good for Horovod (I gotta try).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/37277#discussion_r405173524,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHROKTYE5Y32ZHOJXNA3RLOZ2TANCNFSM4LAYRPHA
.

--

Alex

Let's discuss tomorrow then. I'm sure any concern can be addressed. We seem on good track

I agree that tf.device is better.  I am still not convinced that doing this in Python is better than doing this in placer but assuming the PR addresses my comments below I support the change.
The current version of the PR only fixes the iterator placement issue for TF 1 graph-mode only.
Please extend this PR to also fix the iterator placement issue for TF 2 eager mode and tf.function graph-mode. This will require additional tf.device scopes and I will create a test that will help us validate that your change works in TF 2 eager mode and tf.function graph-mode. Furthermore, this PR should also use the device scope for reduce-based consumption of tf.data elements.

@jsimsa do you want write access to my fork ? That way you can directly push your unittest in the PR.
When do you think we could have it ?
Great, sounds like a plan to me.

I already created the test internally and will ping this PR when it is submitted.

My change has been submitted and you will need to resolve merge conflicts.
On a second thought, I suggest that instead of updating existing unit tests, you write new unit tests that check that the prefetch_with_device and iterator op placement is fixed by your change.
In other words, please add the following tests:

prefetch_to_device_test.py: eager mode and graph mode test that checks that the device of the prefetch dataset variant tensor matches the target device

iterator_test.py:

eager mode test that checks that the device of the eagerly created iterator (i.e. iter(dataset) matches the device of the input dataset
graph mode test that checks that the device of iterator created by make_one_shot_iterator and make_initializable_iterator matches the device of the input dataset

@jsimsa @alextp I applied the requested changes, let me know if that looks good with you.
$ bazel test //tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test

Target //tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test up-to-date:
  bazel-bin/tensorflow/python/data/experimental/kernel_tests/prefetch_to_device_test
INFO: Elapsed time: 20.261s, Critical Path: 9.85s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
//tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test (cached) PASSED in 4.4s

INFO: Build completed successfully, 1 total action

$ bazel test //tensorflow/python/data/kernel_tests:iterator_test

INFO: Analyzed target //tensorflow/python/data/kernel_tests:iterator_test (328 packages loaded, 24880 targets configured).
INFO: Found 1 test target...
INFO: Deleting stale sandbox base /root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/sandbox
Target //tensorflow/python/data/kernel_tests:iterator_test up-to-date:
  bazel-bin/tensorflow/python/data/kernel_tests/iterator_test
INFO: Elapsed time: 27.329s, Critical Path: 17.28s
INFO: 1 process: 1 local.
INFO: Build completed successfully, 2 total actions
//tensorflow/python/data/kernel_tests:iterator_test                      PASSED in 7.1s

Executed 1 out of 1 test: 1 test passes.
INFO: Build completed successfully, 2 total actions

@jsimsa @alextp any update?

@DEKHTIARJonathan Alex left a comment for you on Thursday that (AFAICT) you have not addressed:

The Tensor.device attribute is present in tf2 graph mode. Or are we not getting the device of a tensor? Can you print the object which doesn't have the device attribute on a failure and paste the result here or in a gist?

Hmm ... I did, anyway probably lost in the comment thread or dismissed by pushing an new commit.
By the way, here the issue is the iterator (not a tensor) missing _device attribute (not device):

So by just commenting if not tf2.enabled() or context.executing_eagerly():
I obtain the following error:
======================================================================
ERROR: testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2 (__main__.IteratorTest)
testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2 (__main__.IteratorTest)
testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2(mode='graph', tf_api_version=2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/absl_py/absl/testing/parameterized.py", line 263, in bound_param_test
    test_method(self, **testcase_params)
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 314, in decorated
    execute_test_method()
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 297, in execute_test_method
    test_method(**kwargs_to_pass)
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1098, in testIteratorOnDeviceGraphModeInitializableIterator
    device_dataset, device_iterator, device_tensor
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1037, in assert_dataset_placement
    "cpu:0" in host_iterator._device.lower() or host_iterator._device == ""
AttributeError: 'Iterator' object has no attribute '_device'

======================================================================
ERROR: testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2 (__main__.IteratorTest)
testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2 (__main__.IteratorTest)
testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2(mode='graph', tf_api_version=2)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/absl_py/absl/testing/parameterized.py", line 263, in bound_param_test
    test_method(self, **testcase_params)
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 314, in decorated
    execute_test_method()
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 297, in execute_test_method
    test_method(**kwargs_to_pass)
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1078, in testIteratorOnDeviceGraphModeOneShotIterator
    device_dataset, device_iterator, device_tensor
  File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1037, in assert_dataset_placement
    "cpu:0" in host_iterator._device.lower() or host_iterator._device == ""
AttributeError: 'Iterator' object has no attribute '_device'

----------------------------------------------------------------------

>>> dir(host_iterator)

['__class__', '__delattr__', '__dict__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__gt__', '__hash__', '__init__', '__init_subclass__', '__le__', '__lt__', '__module__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_add_variable_with_custom_getter', '_checkpoint_dependencies', '_deferred_dependencies', '_element_spec', '_flat_tensor_shapes', '_flat_tensor_types', '_gather_saveables_for_checkpoint', '_get_next_call_count', '_handle_deferred_dependencies', '_initializer', '_iterator_resource', '_list_extra_dependencies_for_serialization', '_list_functions_for_serialization', '_lookup_dependency', '_maybe_initialize_trackable', '_name_based_attribute_restore', '_name_based_restores', '_no_dependency', '_object_identifier', '_preload_simple_restoration', '_restore_from_checkpoint_position', '_setattr_tracking', '_single_restoration_from_checkpoint_position', '_string_handle', '_tf_api_names', '_tf_api_names_v1', '_track_trackable', '_tracking_metadata', '_unconditional_checkpoint_dependencies', '_unconditional_dependency_names', '_update_uid', 'element_spec', 'from_string_handle', 'from_structure', 'get_next', 'initializer', 'make_initializer', 'output_classes', 'output_shapes', 'output_types', 'string_handle']

As you can see _device does not exist
>>> import pprint
>>> pprint.pprint(host_iterator.__dict__, indent=4)

{
    '_element_spec': TensorSpec(shape=(), dtype=tf.int64, name=None),
    '_flat_tensor_shapes': [TensorShape([])],
    '_flat_tensor_types': [tf.int64],
    '_get_next_call_count': 1,
    '_initializer': <tf.Operation 'MakeIterator' type=MakeIterator>,
    '_iterator_resource': <tf.Tensor 'IteratorV2:0' shape=() dtype=resource>,
    '_string_handle': <tf.Tensor 'IteratorToStringHandle:0' shape=() dtype=string>
}

It needs to be iterator._iterator_resource.device, it seems
On Mon, Apr 13, 2020 at 9:45 AM Jonathan DEKHTIAR<EMAIL_ADDRESS>wrote:

Hmm ... I did, anyway probably lost in the comment thread or dismissed by
pushing an new commit.
By the way, here the issue is the iterator (not a tensor) missing _device
attribute (not device):
So by just commenting if not tf2.enabled() or context.executing_eagerly():
I obtain the following error:
======================================================================ERROR: testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2 (main.IteratorTest)
testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2 (main.IteratorTest)
testIteratorOnDeviceGraphModeInitializableIterator_test_mode_graph_tfapiversion_2(mode='graph', tf_api_version=2)----------------------------------------------------------------------
Traceback (most recent call last):
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/absl_py/absl/testing/parameterized.py", line 263, in bound_param_test
test_method(self, **testcase_params)
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 314, in decorated
execute_test_method()
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 297, in execute_test_method
test_method(**kwargs_to_pass)
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1098, in testIteratorOnDeviceGraphModeInitializableIterator
device_dataset, device_iterator, device_tensor
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1037, in assert_dataset_placement
"cpu:0" in host_iterator._device.lower() or host_iterator._device == ""AttributeError: 'Iterator' object has no attribute '_device'
======================================================================ERROR: testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2 (main.IteratorTest)
testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2 (main.IteratorTest)
testIteratorOnDeviceGraphModeOneShotIterator_test_mode_graph_tfapiversion_2(mode='graph', tf_api_version=2)----------------------------------------------------------------------
Traceback (most recent call last):
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/absl_py/absl/testing/parameterized.py", line 263, in bound_param_test
test_method(self, **testcase_params)
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 314, in decorated
execute_test_method()
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/framework/test_combinations.py", line 297, in execute_test_method
test_method(**kwargs_to_pass)
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1078, in testIteratorOnDeviceGraphModeOneShotIterator
device_dataset, device_iterator, device_tensor
File "/root/.cache/bazel/_bazel_root/a8fc6d0749b4f3c43761726a36e8ec4c/execroot/org_tensorflow/bazel-out/k8-opt/bin/tensorflow/python/data/kernel_tests/iterator_test.runfiles/org_tensorflow/tensorflow/python/data/kernel_tests/iterator_test.py", line 1037, in assert_dataset_placement
"cpu:0" in host_iterator._device.lower() or host_iterator._device == ""AttributeError: 'Iterator' object has no attribute '_device'

dir(host_iterator)

['class', 'delattr', 'dict', 'dir', 'doc', 'eq', 'format', 'ge', 'getattribute', 'gt', 'hash', 'init', 'init_subclass', 'le', 'lt', 'module', 'ne', 'new', 'reduce', 'reduce_ex', 'repr', 'setattr', 'sizeof', 'str', 'subclasshook', 'weakref', '_add_variable_with_custom_getter', '_checkpoint_dependencies', '_deferred_dependencies', '_element_spec', '_flat_tensor_shapes', '_flat_tensor_types', '_gather_saveables_for_checkpoint', '_get_next_call_count', '_handle_deferred_dependencies', '_initializer', '_iterator_resource', '_list_extra_dependencies_for_serialization', '_list_functions_for_serialization', '_lookup_dependency', '_maybe_initialize_trackable', '_name_based_attribute_restore', '_name_based_restores', '_no_dependency', '_object_identifier', '_preload_simple_restoration', '_restore_from_checkpoint_position', '_setattr_tracking', '_single_restoration_from_checkpoint_position', '_string_handle', '_tf_api_names', '_tf_api_names_v1', '_track_trackable', '_tracking_metadata', '_unconditional_checkpoint_dependencies', '_unconditional_dependency_names', '_update_uid', 'element_spec', 'from_string_handle', 'from_structure', 'get_next', 'initializer', 'make_initializer', 'output_classes', 'output_shapes', 'output_types', 'string_handle']
As you can see _device does not exist

import pprint>>> pprint.pprint(host_iterator.dict, indent=4)

{
'_element_spec': TensorSpec(shape=(), dtype=tf.int64, name=None),
'_flat_tensor_shapes': [TensorShape([])],
'_flat_tensor_types': [tf.int64],
'_get_next_call_count': 1,
'_initializer': <tf.Operation 'MakeIterator' type=MakeIterator>,
'_iterator_resource': <tf.Tensor 'IteratorV2:0' shape=() dtype=resource>,
'_string_handle': <tf.Tensor 'IteratorToStringHandle:0' shape=() dtype=string>
}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/37277#issuecomment-612982080,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRJSPIMZZDRWNQ5OPYTRMM6TLANCNFSM4LAYRPHA
.

--

Alex

@alextp Funny enough, what I showed is working perfectly in TF1 or TF2 Eager.
Shall I just update with you propose ?

@alextp are you sure replacing with iterator._iterator_resource.device is the proper way ?
As stated above: host_iterator._device is working perfectly in TF1 or TF2 Eager.

Oh if it works in tf1 and tf2 then it's fine.
On Wed, Apr 22, 2020 at 1:53 PM Jonathan DEKHTIAR<EMAIL_ADDRESS>wrote:

@alextp https://github.com/alextp are you sure replacing with
iterator._iterator_resource.device is the proper way ?
As stated above: host_iterator._device is working perfectly in TF1 or TF2
Eager.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/37277#issuecomment-618034617,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRI52P6LDXL7U3WWHIDRN5KNFANCNFSM4LAYRPHA
.

--

Alex

It just doesn't work in TF2 graph mode. The attribute does not exist. Hence I only check this for TF1 and TF2 eager. If that's good with you then we can merge

It also needs to work in tf2 graph mode.
On Wed, Apr 22, 2020 at 2:02 PM Jonathan DEKHTIAR<EMAIL_ADDRESS>wrote:

It just doesn't work in TF2 graph mode. The attribute does not exist.
Hence I only check this for TF1 and TF2 eager. If that's good with you then
we can merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/37277#issuecomment-618038688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRKZEX733EEU4AMCD5DRN5LOFANCNFSM4LAYRPHA
.

--

Alex

I can't fix it in this PR. It looks to be an issue in the Iterator in TF2 graph mode. A complete different issue than this PR tries to solve.

Can't you do the fix I suggested if in tf2 graph mode? Something like if
not executing_eagerly() and executing_eagerly_outside_functions()?
On Wed, Apr 22, 2020 at 2:05 PM Jonathan DEKHTIAR<EMAIL_ADDRESS>wrote:

I can't fix it in this PR. It looks to be an issue in the Iterator in TF2
graph mode. A complete different issue than this PR tries to solve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/pull/37277#issuecomment-618040158,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABHRPWA4Y7XGHCHXGDOOTRN5L2JANCNFSM4LAYRPHA
.

--

Alex

That's exactly what I did: https://github.com/tensorflow/tensorflow/blob/65b1a97ab98f09b197ee7b06a1ac6290349be816/tensorflow/python/data/kernel_tests/iterator_test.py#L1036-L1038
@jsimsa was complaining about this:

Why are are we not checking the iterator device placement in TF2 graph mode?
This is somewhat worrisome because if the test code cannot access .device that neither will non-test code and since the code you have modified will run in TF2 graph mode, I suspect that this is an issue.
@alextp does it make sense that the .device attribute is no present in TF2 graph mode?

The reason you should use _iterator_resource instead of _device is because there are two different implementations of tf.data.Iterator -- one for eager mode + tf.function and one for graph mode. Only the former has the _device property, while both of them have the _iterator_resource property.

Perfect. Just wanted to make sure this was expected and we understood correctly the issue ;).
Just pushed the fix. Let me know if there's any other blocking issue to merge this PR.
Target //tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test up-to-date:
  bazel-bin/tensorflow/python/data/experimental/kernel_tests/prefetch_to_device_test
INFO: Elapsed time: 19.913s, Critical Path: 6.06s
INFO: 1 process: 1 local.
INFO: Build completed successfully, 5 total actions
//tensorflow/python/data/experimental/kernel_tests:prefetch_to_device_test PASSED in 3.8s

Target //tensorflow/python/data/kernel_tests:iterator_test up-to-date:
  bazel-bin/tensorflow/python/data/kernel_tests/iterator_test
INFO: Elapsed time: 14.175s, Critical Path: 1.97s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
//tensorflow/python/data/kernel_tests:iterator_test             (cached) PASSED in 5.0s

@jsimsa https://github.com/tensorflow/tensorflow/pull/37277#discussion_r413351911
I can't see the issue with the indent here. Looks good to me ...

@jsimsa fixed linting issue: 0f26cfa90c2477392da1b1409f690c70cdf050f7
Can you re-approve the PR ? Thanks

There is still a couple of lint issues:
FAIL: Found 3 non-whitelisted pylint errors:
tensorflow/python/data/ops/dataset_ops.py:2277: [C0330(bad-continuation), ] Wrong hanging indentation (add 2 spaces).

tensorflow/python/data/ops/dataset_ops.py:2285: [C0330(bad-continuation), ] Wrong hanging indentation (add 2 spaces).

tensorflow/python/data/ops/dataset_ops.py:2286: [C0330(bad-continuation), ] Wrong hanging indentation (add 2 spaces).

AFAICT, the windows failures are unrelated.

@jsimsa I did not modify these lines
https://github.com/tensorflow/tensorflow/blob/0f26cfa90c2477392da1b1409f690c70cdf050f7/tensorflow/python/data/ops/dataset_ops.py#L2277-L2287
And honestly I'm not sure how to fix them, if I apply the suggested fix, i'll get indent errors.

@jsimsa I did not modify these lines
https://github.com/tensorflow/tensorflow/blob/0f26cfa90c2477392da1b1409f690c70cdf050f7/tensorflow/python/data/ops/dataset_ops.py#L2275-L2287
And honestly I'm not sure how to fix them, if I apply the suggested fix, i'll get indent errors.

The line numbers are wrong (not sure why) but the indent issues exists. You could have just carefully review the PR diff. To make it easier for you, I commented on the lines that have the wrong indent in your PR.

@jsimsa linting issues fixed in 356a3dd
Please approve again ;)
Any way I can run the linter by myself ?

FYI, this got rolled back automatically because of internal test failures. I will take a look, time permitting. Please ping me if you do not see a response in a week.

@jsimsa ping

@jsimsa any chance we could get an update on when do you plan to re-merge this PR ?  It's a quite important PR that impact performance. Let me know if I can help.

This should be fixed now by https://github.com/tensorflow/tensorflow/commit/8be4d61574f29568c8699708d88945b441bfd317

@aaudiber : the commit you linked is far from addressing all concerns. If you look at this PR diff, you will see that it modifies much more things.
It namely completely ignores placing the Iterator on the correct device. Consequently, doing x = iterator.get_next() triggers a copy back on CPU. Unfortunately, this makes 8be4d61 totally useless since we bump in the same issue a bit further down the input pipeline
CC: @nluehr @jsimsa

@DEKHTIARJonathan The linked commit fixes a bug where the prefetch dataset would be placed on CPU. As demonstrated by the included unit test, the prefetch dataset is now placed on GPU.
There is a separate issue that iterators are not automatically colocated with their inputs. We originally tried to address both issues with this PR, but automatic colocation broke internal tests, so we had to roll this PR back. It will take some time to figure out the root issue. It should be possible to work around the issue by explicitly putting the get_next inside a device scope. Could you open a separate issue for iterator colocation? Please include details about why it is important, to help us prioritize the issue.


Validate idea (result columns by view creation) WIP

investigate and validate:

create view by pggen query (only select queries?)
pggen.args -> use default value of type, is this step needed?
goal: better result column analysis -> is it really better?

Interesting, so the idea is given a source query like SELECT 3 * pggen.arg('foo'), create a view like:
CREATE VIEW pggen_foo_view AS
SELECT 3 * null -- or a default value

Yep, I think it would only work for select queries. Maybe you can put inserts and updates in CTEs?

Currently, pggen, runs the query using null for all the parameters. Null has the nice property of working for all values. I worked on that section code of yesterday. The reason it works is that Postgres still reports the types even if there was a constraint violation caused by using null.

I'm not sure if the column analysis with a view is more informative than by running the query. Maybe there's something interesting in the catalog tables?

I think the most promising method is to use the explain plan. pggen already has the explain plan and uses it a bit in inferOutputNullability.

I think there's too many potential issues to pursue it:

The view won't provide any additional information beyond what we can get by running the query.

Won't work for insert, update, delete queries.

It's not clear what the views would be useful for and how to keep them up to date.


Fix ls8 fc

Apply a group of linear regression coefficients on ls8 fc unmixing results, such that ls8 fc can be close to ls7 fc enough.
Sorry if you don't like the name fc_coefficients, tried my best in naming things and willing to accept any other suggestion.
It shouldn't affect any current thing if leaving out fc_coefficients, which is only intended to fix the difference we observed in dea fc product.

Do you think we should perhaps call it output_regression_coefficients?

I don't particularly  mind the naming things. It depends on how firm you'd insist on changing it. :P


Create interface for races

Create an interface for races, including the following:

Races
Subraces
Traits

Completed by #12


Show count on mouse hover

Is your feature request related to a problem? Please describe.
Areas should be clicked to know the count in that area, this is inconvenient in most cases. A whole different Modal box seems overkill to only show the count.
Describe the solution you'd like
Besides the district name, the count should also be shown on mouse hover. Some pretty UI boxes can be designed to improve user experience. Same should work in mobile devices, which is, data should be shown on tap, but the same way as in desktop (not any modal).
Describe alternatives you've considered
None
Additional context
None

Showing count on mouse hover is a good idea. Thank you.
I'm working on it.
As hovering isn't possible on mobile devices, I used the modal to show data. And, I'm planning to show some more insight on the modal.

I added the count with the name on the tooltip box.
Please have a look at the preview here!
If you think any more changes should be made, please let me know.
Thank You.


Case insensitive search

Hi,
Could it be possible to make default filtering case insensitive or at least add a parameter to do so?
I saw in the _fncheck method that a RegExp object is created to test the callback against data. The second parameter defines flags of the regular expression:
var _regex = new RegExp(callback, 'i');
return _regex.test(data);

Thanks in advance and keep up the good work! :)

yes, this would be super helpful!!!!
i tried something like this which works where I can see my filter is called however, the ng-repeat bind seems to not notice the update as quick when my filter is only one keystroke.  When my filter is many keystrokes(or a backspace), it is almost instantaneous:

    <tree-dnd ng-init="getTopoData();" id='tree_nodes'
...
    filter="TopoFilter(filter_name)"
    template-url="topoManager/views/tree/tree-dnd-template-render.html">
  </tree-dnd>

where TopoFilter is:
      $scope.TopoFilter = function(filterName) {
        filtersubtopo($scope.topo_data, filterName)
        console.log('F', $scope.topo_data);
        return true;
      }

      function filtersubtopo(topoTree, filterName) {
        //set those that do not match to __visible__=false
        //intial $scope.topo_data is an array of empty object with id=0
        if (topoTree[0].id) {
          for (var i = 0; i < topoTree.length; i++) {
            if (topoTree[i].isfolder) {
              filtersubtopo(topoTree[i].__children__, filterName);
            } else {
              if (!filterName || topoTree[i]['name'].toLowerCase().indexOf(filterName.toLowerCase()) > -1) {
                topoTree[i].__visible__ = true;
              } else {
                topoTree[i].__visible__ = false;
              }
            }
          }
        }
      }


noship Microsoft.AspNetCore.Server.IIS

@JunTaoLuo will this remove Microsoft.AspNetCore.Server.IIS from the meta packages?

What's going on with this? Are we pushing it out to rc or beyond 2.1? If we are just moving it to rc, I'd just mark https://github.com/aspnet/Universe/blob/dev/build/artifacts.props#L312-L313 as noship. If we are committed to not shipping it for 2.1 then revert the change Nate mentioned.

@JunTaoLuo out of 2.1 was my understanding.

@natemcmaster I added the revert in this PR too.


Double quotes and strings

Currently, double quoted items seem to be of a separate data type. This does not fit into ISO. It seems you copied this from SWI 7, which departed from ISO conformity about 5 years ago and which causes a lot of pain.
If you really want a separate string data type, use back-quoted items for them. They are even defined in 13211-1 6.4.7 Back quoted strings, while noting:
NOTE — This part of ISO/IEC 13211 does not define a token
(or term) based on a back quoted string.
It would be a valid extension of this part of ISO/IEC 13211 to
define a back quoted string as denoting a character string
constant.
However, note that you would have to replicate all built-ins defined for atoms now for strings, too, like atom_length/2, atom_concat/3, sub_atom/5, atom_chars/2, atom_codes/2. So a lot of non-ISO built-in predicates would be needed which makes your programs very non-portable. Also, such a type would be as moded as atoms are: you always have to have them fully defined, while in Prolog we also like things to be only partially known. Even worse, a separate string type does not work together with DCGs which is one of the key elements of Prolog.
So before adding a new separate string data type,  rather consider to use the same approach Haskell does where strings are lists of characters:

GHCi, version 7.6.3: http://www.haskell.org/ghc/  :? for help
Loading package ghc-prim ... linking ... done.
Loading package integer-gmp ... linking ... done.
Loading package base ... linking ... done.
Prelude> ['a','b'] == "ab"
True

With set_prolog_flag(double_quotes, chars) the same is possible in ISO Prolog:

| ?- ['a','b'] == "ab".
yes
| ?- [a,b] == "ab".
yes

Consider set_prolog_flag(double_quotes, chars) as default. For full conformance, all three values are needed.
Now for reasons of efficiency, you may use (internally) an alternate representation for lists of characters: a null-terminated UTF-8 string. See #24

I would like to endorse this! It would be awesome to have a Prolog system where double_quotes is set to chars by default! This would be rather unique (even though it was, historically, the convention) and significantly improve usability. With the ideas from #24, it would also be quite efficient.


Remove redundant code, fix typos, improve readability, refactor

Codecov Report

Merging #419 (76f8220) into master (1c3503b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   97.80%   97.80%
=======================================
  Files          22       22
  Lines        2143     2143
=======================================
  Hits         2096     2096
  Misses         47       47

Impacted Files
Coverage Δ

robocop/checkers/duplications.py
98.33% <ø> (ø)

robocop/checkers/naming.py
98.94% <ø> (ø)

robocop/rules.py
100.00% <ø> (ø)

robocop/checkers/spacing.py
99.64% <100.00%> (ø)

robocop/checkers/tags.py
100.00% <100.00%> (ø)

robocop/config.py
93.93% <100.00%> (ø)

robocop/utils/misc.py
99.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3503b...76f8220. Read the comment docs.

Closes #420


Fix windows crush

stable-diffusion-webui\extensions\tag-autocomplete\scripts\tag_autocomplete_helper.py", line 18, in get_tags_base_path
    if (script_path.is_relative_to(EXT_PATH)):
AttributeError: 'WindowsPath' object has no attribute 'is_relative_to'

This fix solves that problem. If the code is not very nice, you can suggest something better.

I'm on windows too and this error doesn't happen to me. Which Python version are you using?
is_relative_to was introduced with Python 3.9, so for 3.10.6 which the webui recommends you should have no problem.
Now I'm not against your version, just wondering if it's necessary since I do find the "modern" version a bit more elegant.

I tried to find information about this, but I didn't realize it was only in the new python. I used python 3.8 and python and some online compiler site, and both gave a similar error. So I thought it only worked on linux. Sorry for the false PR.


No way to build and run on android

Hello,
as soon as I add Cesium package 1.9.0 I'm not able to build and run on Android.
This happes on 2021.3.x, 2022.3.x, and 2023 on Windows
The proces stuck on "Building scene 0: ...." and lasts forever.
I don't know what to do

try this:  it worked for me

Hi @kiuma, is this still an issue for you?
If so, can you please update this issue with more information? For example, what Cesium objects are in the scene when you are packaging? Are you able to build an empty scene?

I'm closing this due to inactivity. If this is still an issue, please reopen with the information requested above. Thank you!


Convert parameters

Is there a reason the Convert parameters aren't part of the Command parameter set?

@jdhitsolutions could you link me to example?

@jdhitsolutions are you talking about New-MarkdownHelp -Command? Can you, please, elaborate.

New-MarkdownHelp has parameters for ConvertNotesToList and ConvertDoubleDashList but when using the last parameter set. I would like to have these parameters at least for the first parameter set which generates help from a command.

Yes, it would make sense. Unfortunately, -ConvertNotesToList is limited by the implementation. Original thread about it. In short, this knowledge (at least, as described by @TimShererAtAquent, applicable to msdn) exists only on maml level. I took the same approach with -ConvertDoubleDashList , because it made the code really simple.

This will not be an issue when we move to the markdig engine. Double dash lists will not be supported.

This will not be an issue when we move to the markdig engine. Double dash lists will not be supported.


beacon: parameterize proposal size in the first vote msg

Motivation

Closes #3072
Closes #2794

Changes

reject proposals that arrive too late
reject votes that arrive too early
refactor epoch-specific data to state to separate protocol logic and epoch proposals/votes manipulation
parameterize the size of proposal in the first vote message
match beacon size to be the same as the proposal size to signal the same level of entropy

Test Plan

unit tests / system tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bors try

bors merge

bors merge


Adding argument identifiers

@rohrerb : Thanks for your contribution! The author, @shants123, has been notified to review your proposed change.

#sign-off


refactor(semantic)!: rename SymbolTable::get_flag to get_flags

Part of #4991.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5030  👈
#5028
#5027
#5026
#5025
#5024
#5023
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Issue/Suggestion Logo not visible properly

Issue and Steps to Reproduce:
Logo is not visible properly on the (Power of Knowledge Blogs) Blogs page as a similar Logo shows consistency on webpages.
Screenshots:

Expected:

Actual:
NIL
Additional Details:
Please assign this to me under GSSoC'23. @akshitagupta15june

go for it

Hello, @prathamesh-borse I am working on this issue and will require two more days as my semester exams are going on.
Sorry for the delay.


"Fildu de Jos" , "Fildu de Mijloc" , "Fildu de Sus" , "Tetișu" are listed in the drop-down menu

Description:
When user writes "Fildu de Jos" , "Fildu de Mijloc" , "Fildu de Sus" , "Tetișu" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Fildu de Jos"

Expected results
The location appears in the drop-down menu as "Sat Fildu de Jos, SĂLAJ (Fildu de Jos)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Fildu de Sus"

Expected results
The location appears in the drop-down menu as "Sat Fildu de Sus, SĂLAJ (Fildu de Jos)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.


An utility for code style checking based on flake8

Thanks! LGTM.
BTW In the future, we might want to use https://github.com/psf/black as autoformatter - I'm using PyCharm and it's reformatting the code before each commit automatically, but once there are more contributors it'll probably be good to have an easily accessible CLI utility.


eval_rst block doesn't internationalize

E.g. for https://github.com/Bjwebb/recommonmark-i18n-bug/blob/gh-pages/docs/index.md the messages I get pulled out by sphinx-build -b gettext are https://github.com/Bjwebb/recommonmark-i18n-bug/blob/gh-pages/_build/locale/index.pot - the content from the eval_rst block is missing.
(This also used to be an issue for bullet points, but is now fixed, see https://github.com/rtfd/recommonmark/issues/21)

This is fixed for the latest versions of Sphinx and recommonmark.


fix(cronjob): Run cron job every 2 hours instead of minutes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.2%) to 62.5%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/job/main.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
1.2%

Covered Lines:
100

Relevant Lines:
160

💛  - Coveralls


Centos 7 - qtwebkit-devel not available

Hi,
I'm trying to install capybara-webkit on centos 7 as per the instructions at https://github.com/thoughtbot/capybara-webkit/wiki/Installing-Qt-and-compiling-capybara-webkit#centos-7 but I'm getting an error
$ who am i
root     pts/1        2015-04-03 13:11 (<IP_ADDRESS>)
$ yum install qtwebkit-devel
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: mirror.bytemark.co.uk
 * extras: mirror.simwood.com
 * updates: centos.openitc.uk
No package qtwebkit-devel available.
Error: Nothing to do

Steps to reproduce
mkdir capybara-webkit-issue
cd capybara-webkit-issue
vangrant box add chef/centos-7.0
vagrant init
vim Vagrantfile # enable the chef/centos-7.0  box
vagrant up
vagrant ssh

sudo su -
yum install qtwebkit-devel

I'm not familiar with the Centos mirror/package system, but I see a number of search results under "Centos 7" for "qtwebkit" - http://pkgs.org/search/qtwebkit
Unfortunately, the maintainers don't have the resources to debug Qt install issues for every system, and none of us use Centos, so there isn't much we can do to help you debug this.
If you do discover a better way to install on Centos 7, it would be helpful to future users if you could update the wiki. We rely on members from the community to document the install steps for each system.

Don't mean to drag up an old thread but the fix for this is to install epel-release first, since the package qtwebkit-devel is from epel.
yum install -y epel-release
yum -y update

@ericenns thanks!  I've been building from source, but this could be handy


Set correct application title in notifications

OS: Arch Linux
Issue Descriptions: When displaying a notification the originating application is shown as electron instead of something like "Google Play Music Desktop Player"
Steps to Reproduce: Do something that will display a notification, then look at the originating app. May not be displayed by all DEs
Purely cosmetic bug, no inpact on functionality

@adnidor This is because you are using gpmdp-git on arch.  This is a package not supported by us and actually runs the github repository in development mode so it doesn't rebrand the Electron executable.  Nothing we can do about it


message-box: close/cancel

We needed 3 states for our confirm. In Tipe if you make an edit and leave the page we ask if they want to Cancel (discard changes) or Success (save and continue). We needed a Close state for when they click on [x] or click out of the modal to close the modal without doing anything

Success
Cancel
Close

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English | Español).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

@gdi2290 Is it necessary to add close status?
We usually use message-box as follows:
this.$messageBox('title', 'content').then(callback).catch(callback)

The confirm status and cancel status correspond to the status of Promise. It seems there's no need to add one more status.

@ziyoung yeah for our needs we named the cancel button something else so we reactive to the user depending on 3 states (confirm, cancel, close). If we had a way to add another success button then we can also use that so the catch can remain the cancel. It would be better to provide different success calls
Here's our use-case

The [x] is the same as discord changes but it would be better to cancel the model/route change.
Here's the code vue.js/nuxt.js that deals with the 3 states in the router leave lifecycle hook.

So we either need to add more error options or add more success options

How about adding a prop to decide if clicking on [x] or clicking out of the modal are considered to be close instead of cancel? And this prop should default to false for backward compatibility.

yeah I can work with that

@gdi2290 #11831 distinguishCancelAndClose attribute has been added to MessageBox.

thanks!

why it dosent work when I copy demo's code on http://element-cn.eleme.io/#/zh-CN/component/message-box.
I missing what type?


Notification when app is in the range of iBeacon

When the app is in the range of iBeacon, the local notification should be displayed.
https://github.com/katzer/cordova-plugin-local-notifications

This should be implemented in the application not in the SDK


Change Class.new's return type to T::Class[T.untyped]

Motivation
The current T::Class[Object] means in some cases incorrect typing error would be raised when using Class.new to create a class with a custom constructor, like:
class A
  r = Class.new do
    def initialize(a)
    end
  end

  r.new(123) # => reporting wrong number of arguments
end

This PR fixes the issue by changing the return type to T::Class[T.untyped].

@jez I've updated tests and CI is green now.


Added extract_tff pass to find toggle flipflops in a netlist

Like with the adder stuff, I don't think we should add "commands" that are just ABC+extract scripts, especially since extract is very inefficient for the large haystack + small needle scenario.
I'll be adding a small framework that will simply matching small subcircuits. Give me a few weeks to get to that..

This looks to be superseded by #521 (and I think the "small framework" may have ended up being pmgen?) so I'll close this. If I'm wrong leave a comment!


Return concrete Type for Submodules

Is your feature request related to a problem?
The lack of proper submodule types introduces unsafe access.
For instance, when we use Dialogic.Text, we won't be able to work with the actual type nor does the compiler know whether the accessed properties exist.
An example, := is not accepted:
var info := Dialogic.Text.get_autoadvance_info()

If we call Dialogic.Text.random_fantasy_method(), we won't get any warning either.
Describe the solution you'd like
We may need concrete class types for the submodules and a way to access them from Dialogic.

I am not sure how possible this would be in GDScript today, I am not too familiar with the whole code base, but if I am correct, these submodules get added dynamically, which makes it hard for static type system to figure out what they are supposed to be and if they exist at all. For the built in submodules you could get away by declaring them ahead of time, but extensions would have the short end of the stick.
Using C# as an example, one way to go about it would be with generics.
public T GetSubSystem<T>(string name) where T : Submodule
{
    T module = GetNode(name) as T;

    if (module is null)
        throw new Exception($"subsystem \"{name}\" not found, make sure the path and type is correct");
    return module;
}

But GDScript seems to lack generics at this point in time, so this approach is not possible until then.
If it at some point does get introduced, it could looks something like this (warning, syntax speculation ahead)
func get_subsystem_as<T>(_name:String) -> T:
    var module := get_node(_name) as T
    assert(module != null)
    return module

This would not really a silver bullet for the problem, but would be a possible path a developer can walk with type safety.

It's possible with internal core submodules, by adding class names to them and then providing properties or methods to access returning declared concrete types. Additionally, using the setget feature is a possibility.
Right now, every access on Dialogic.SubModule is an unsafe call, this is not really nice.
However, this won't work for custom submodules, hence the solution is limited.
As you have mentioned, GDScript has no generics.

What naming convention would be good to follow for the submodule class names, something like DialogicSubmoduleXXX (for example DialogicSubmoduleText) is the first thing to come to my mind.

Definitely Subsystem instead of submodule (as Subsystem is what we use for these scripts everywhere else).
But other then that yeah, DialogicSubsystemText (alternatively DialogicSubsystem_Text) or DialogicTextSubsystem I would say.


node overwrites other node? (video linked for showcase)

Rancher versions:
rancher/server or rancher/rancher: latest
rancher/agent or rancher/rancher-agent: 2.0.6
Docker version: (docker version used)
Client:
 Version:      17.03.2-ce
 API version:  1.27
 Go version:   go1.7.5
 Git commit:   f5ec1e2
 Built:        Tue Jun 27 01:35:00 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.03.2-ce
 API version:  1.27 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   f5ec1e2
 Built:        Tue Jun 27 01:35:00 2017
 OS/Arch:      linux/amd64
 Experimental: false

Operating system and kernel: (cat /etc/os-release used)
NAME="RancherOS"
VERSION=v1.4.0
ID=rancheros
ID_LIKE=
VERSION_ID=v1.4.0
PRETTY_NAME="RancherOS v1.4.0"
HOME_URL="http://rancher.com/rancher-os/"
SUPPORT_URL="https://forums.rancher.com/c/rancher-os"
BUG_REPORT_URL="https://github.com/rancher/os/issues"
BUILD_ID=

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Bare-metal
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
HA rancher(?) as per Manual Quick Start
Steps to Reproduce:

Install RancherOS to disk (from ISO)
run sudo docker run -d --restart=unless-stopped -p 80:80 -p 443:443 rancher/rancher
Login, create password
Add custom cluster with Kubernetes 1.10.5-rancher1-1 and Canal, requiring a compatible docker version and no cloud provider.
enter the command thing into two different nodes
bug!

Results:
See this video.
Sorry for doing it with a video, it was the easiest for me to explain and show the bug

Duplicate of https://github.com/rancher/rancher/issues/13999

Did not see that one... whoops


BeanConfig needs some examples without Spring

BeanConfig seems to be touted as the answer to our configuration problems, allowing scanning of packages for annotated classes (see issues #173, #174 and #175).
It would be very helpful if we had some examples of how to use it. But the only examples I could find were using Spring. Please create some generic examples.
I've tried just creating a new one in the PostConstruct of a Singleton/Startup bean, but none of my resources are found, so I must be doing something wrong.
I initialize my BeanConfig like this:
      BeanConfig beanConfig = new BeanConfig();
      beanConfig.setVersion( "1.0" );
      beanConfig.setScan( true );
      beanConfig.setResourcePackage( MyResource.class.getPackage().getName() );
      beanConfig.setBasePath( "http://localhost:9080/v1/api" );
      beanConfig.setDescription( "My RESTful resources" );
      beanConfig.setTitle( "My RESTful API" );

All I get on localhost:9080/v1/api/api-docs is this:
{"apiVersion":"1.0","swaggerVersion":"1.2"}

I don't get anything from MyResource (which has Api annotation on the class and ApiOperation annotation on the GET resource).

I spent ages trying to bypass BeanConfig, classpath scanning, reflection, Spring, XML and anything that wasn't plain java specifying what to configure. The result is here in case anyone else is interested.


ShareJS 0.7.3 support?

Hi there,
I'm currently looking into adding sharejs 0.7.3 support to meteor-sharejs. Before I get too involved, I wanted to check to see if anyone here done this yet?
The main reason i'm looking to do this, is because from what i've been told, ShareJS 0.6 does not support multiple server instances, which was implemented in 0.7.3.

No, no one has done that.
I'm not sure what multiple server instances means, but you should definitely think about that also from the Meteor perspective (where there may be many Meteor servers running off a single DB.)
I'm pretty sure that 0.7.3 support would require a rethinking of the many little hacks that I used to get 0.6 to work. But I'm happy to take a look at anything you start working on.

Hey,
This will explain the 'multiple servers' better than I can.
https://josephg.com/blog/sharejs/
He talks about it in the section titled: "Scalable database backend"
I'll tinker around a bit, and if I come up with something that works, i'll see about submitting a pull request. Thanks for the info.

I'm thinking about how to integrate ShareJS 0.7 as part of #50.

Recent ShareJS discussion seems to indicate that 1.0 will be based on 0.6, not 0.7, while 0.7 is forking into a JS OT focused library.  Might make sense to wait for 1.0 and keep this library focused on flat text... and start a new library for JS OT. :-)
https://groups.google.com/forum/?fromgroups#!topic/sharejs/NGJ-I9Zuz_8


tool_name is not a valid input

I am getting the following warning in the logs

@esafzay
Thanks for the feedback.
I've found the cause and will fix the problem.