[Puppeteer] Private api _clickablePoint() doesn't exist

What are you trying to achieve?
Use moveCursorTo()
What do you get instead?
TypeError: els[0]._clickablePoint is not a function
at Puppeteer.moveCursorTo (node_modules\codeceptjs\lib\helper\Puppeteer.js:632:26)
at processTicksAndRejections (internal/process/task_queues.js:94:5)

Provide console output if related. Use --verbose mode for more details.

CodeceptJS v2.5.0
Helpers: REST, Puppeteer
Plugins: screenshotOnFail

@MoveCursorTo test --
    [1] Starting recording promises
    Emitted | suite.before ([object Object])
  test
    Emitted | test.before ([object Object])
    Emitted | hook.start ([object Object])
    Emitted | step.before (I am on page "https://codecept.io/")
    Emitted | step.after (I am on page "https://codecept.io/")
    Emitted | step.start (I am on page "https://codecept.io/")
    I am on page "https://codecept.io/"
    » [Url] https://codecept.io/
    Emitted | step.passed (I am on page "https://codecept.io/")
    Emitted | step.finish (I am on page "https://codecept.io/")
    Emitted | hook.passed ([object Object])
    Emitted | test.start ([object Object])
    Emitted | step.before (I wait for element "div.playwright-home")
    Emitted | step.after (I wait for element "div.playwright-home")
    Emitted | step.before (I move cursor to "div.playwright-home")
    Emitted | step.after (I move cursor to "div.playwright-home")
    Emitted | step.before (I click "div.playwright-home")
    Emitted | step.after (I click "div.playwright-home")
    Emitted | step.start (I wait for element "div.playwright-home")
    I wait for element "div.playwright-home"
    Emitted | step.passed (I wait for element "div.playwright-home")
    Emitted | step.finish (I wait for element "div.playwright-home")
    Emitted | step.start (I move cursor to "div.playwright-home")
    I move cursor to "div.playwright-home"
    [1] Error | TypeError: els[0]._clickablePoint is not a function
    Emitted | step.failed (I move cursor to "div.playwright-home")
    Emitted | step.finish (I move cursor to "div.playwright-home")
    [1] Error | TypeError: els[0]._clickablePoint is not a function
    Emitted | step.failed (I click "div.playwright-home")
    Emitted | step.finish (I click "div.playwright-home")
    [1] Error | TypeError: els[0]._clickablePoint is not a function
    [1] Starting <teardown> session
    Emitted | test.failed ([object Object])
    Emitted | test.finish ([object Object])
    [1] <teardown> Stopping recording promises
  × FAILED in 1443ms

    [2] Starting recording promises
    Emitted | test.after ([object Object])
    Emitted | suite.after ([object Object])

-- FAILURES:

  1) @MoveCursorTo test
       test:
     els[0]._clickablePoint is not a function

  TypeError: els[0]._clickablePoint is not a function
      at Puppeteer.moveCursorTo (node_modules\codeceptjs\lib\helper\Puppeteer.js:632:26)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

Provide test source code if related

Feature('@MoveCursorTo test');

Before(I => {
    I.amOnPage('https://codecept.io/');
});

Scenario('test', async I => {
    I.waitForElement('div.playwright-home');
    I.moveCursorTo('div.playwright-home');
    I.click('div.playwright-home');
});

Details

CodeceptJS version: 2.5.0
NodeJS Version: 12.14.1
Operating System: Win 10
puppeteer
Configuration file:

Default for puppeteer.

@DavertMik I still see the _clickablePoint in https://github.com/puppeteer/puppeteer/blob/master/lib/JSHandle.js

@DavertMik  Anyone looking into this issue? If not, then i can check.

Is there an ETA when this fix will be on npm?


know if there are update device or not

Hello,
For each device, can you make a sensor that tells us if there is a device update to be done or not?
Thanks.
screen to my ewelink web page:

I don't have time for this. Maybe someone else will.


WIP - Use Pundle as the module bundler

⚠  This PR is in no way feature complete and is just meant to start the discussion ⚠
Reference: https://github.com/facebookincubator/create-react-app/issues/93#issuecomment-234733143
This PR uses the Pundle module bundler instead of Webpack
What's working?

Hot reloads
Everything JS + JSON

What needs some work?

Non JS requires
ESLint

I will be implementing the missing plugins for Pundle as we make progress on this PR
What's the benefit?
Well documented and maintained software that has extremely fast bundling and hot reload speed compared to Webpack
cc @gaearon

Does pundle support any sort of built-in proxying behavior? We need something like that to support backend servers.
If we used pundle instead of webpack, do you think pundle should also be used to package files for the test environment? Or is that not a good fit for pundle?

You would want to change build.js too I presume, so that we would no longer have any webpack dependencies.

Pundle supports fully configurable bundle paths (including their source map and hmr paths) so it's very easy to use it behind a proxy. In fact we're already using it in our dev environment.
Also Pundle has two main external components, The Dev Server and the main CLI, it can compile anything and probably more than what webpack is capable of :)
Also I'm working on transitioning build.js too right now, as the title says it's still a WIP but reviews are very much welcome on the stuff committed in

Would love to see production build sizes and benchmarks on the page speed.

This doesn’t currently handle styles, does it?

This is build time in Pundle vs Webpack (respectively)

That's like a 2.3x boost. Pundle is especially fast at HMR, it's HMRs are near-instant.
@gaearon Yeah it's being actively worked on, as the ETA it's happening soon :)
@TheLarkInn Pundle's build sizes are slightly bigger than webpack's at the moment but the runtime performance is probably faster. Sizes are gonna be fixed soon.

Closing as outdated, but feel free to reopen when there is a reasonable feature parity!

I wonder if there is any update on this. ?


YUNIKORN-414: Add partitions REST API to fetch list of partitions

First cut implementation. Need to add few more attributes in JSON response.

Travis tests have failed
Hey @manirajv06,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2

golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint

     make lint

running golangci-lint
pkg/webservice/handlers.go:557:3: ifElseChain: rewrite if-else to switch statement (gocritic)
		if app.IsRunning() {
		^
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1

TravisBuddy Request Identifier: c7643c70-0e36-11eb-964d-5d54b4986782

Travis tests have failed
Hey @manirajv06,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
1st Build
View build log

     curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2

golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint

     make lint

running golangci-lint
pkg/webservice/handlers.go:557:3: ifElseChain: rewrite if-else to switch statement (gocritic)
		if app.IsRunning() {
		^
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1

TravisBuddy Request Identifier: eb7198a0-13b9-11eb-a355-c174999d48b2

hi @manirajv06  Looks almost good, but still need to fix the lint issue
$ make lint
running golangci-lint
checking against commit sha 2bf276764227
pkg/scheduler/objects/application.go:141:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsCompleted() bool {
^
pkg/scheduler/objects/application.go:145:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsKilled() bool {
^
pkg/scheduler/objects/application.go:149:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsRejected() bool {
^
Makefile:58: recipe for target 'lint' failed
make: *** [lint] Error 1

you can run make lint locally to ensure there is no more lint issues before updating the PR. Thanks

hi @manirajv06  Looks almost good, but still need to fix the lint issue
$ make lint
running golangci-lint
checking against commit sha 2bf276764227
pkg/scheduler/objects/application.go:141:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsCompleted() bool {
^
pkg/scheduler/objects/application.go:145:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsKilled() bool {
^
pkg/scheduler/objects/application.go:149:1: receiver name ai should be consistent with previous receiver name sa for Application (golint)
func (ai *Application) IsRejected() bool {
^
Makefile:58: recipe for target 'lint' failed
make: *** [lint] Error 1

you can run make lint locally to ensure there is no more lint issues before updating the PR. Thanks

Fixed.

Fixed.

Oops, I can't get this merged as there are some conflicts.
Could you pls fix the conflict? Thanks!

Oops, I can't get this merged as there are some conflicts.
Could you pls fix the conflict? Thanks!


If renaming a column fails, the error is not shown

Open a dataset.
Rename any column to created_at.

As that's not a valid name, the request fails: "That column name is reserved, please choose a different one". Nevertheless, no error is shown to the user.
cc @ivanmalagon @ramiroaznar

Stale issue. Closing 👋


[QUERY] How to mock ConfigurationClientExtensions.AsPages without access to internal class

Library name and version
Azure.Data.AppConfiguration 1.4.1
Query/Question
When writing unit tests using Moq there's no way to mock extension methods, and calling this method results in an InvalidOperationException because it tries to cast the pageable object as AsyncConditionalPageable, which is an internal class.
I see this issue is similar, but the tracking issue mentioned in this comment is closed, and it seemed like this might need attention as well.
Environment
.NET SDK:
Version:           8.0.300
Commit:            326f6e68b2
Workload version:  8.0.300-manifests.ca8b4b2d
MSBuild version:   17.10.4+10fbfbf2e
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.22631
OS Platform: Windows
RID:         win-x64
Base Path:   C:\Program Files\dotnet\sdk\8.0.300\
Visual Studio 2022 - Version 17.10.2

Hi @amerjusupovic.  Can you help me understand the end-to-end scenario of what you're trying to test?
Unless you've got an unusual scenario, you shouldn't need to mock the extensions, but would be mocking the client method to return your own pagable, in a pattern similar to what is demonstrated in [Unit testing and mocking with the Azure SDK for .NET](https://learn.microsoft.com/dotnet/azure/sdk/unit-testing-mocking?tabs=moq#explore-paging:
Page<SecretProperties> page1 = Page<SecretProperties>.FromValues(
    new[]
    {
        new SecretProperties("secret1"),
        new SecretProperties("secret2")
    },
    "continuationToken",
    Mock.Of<Response>());

Page<SecretProperties> page2 = Page<SecretProperties>.FromValues(
    new[]
    {
        new SecretProperties("secret3"),
        new SecretProperties("secret4")
    },
    "continuationToken2",
    Mock.Of<Response>());

Page<SecretProperties> lastPage = Page<SecretProperties>.FromValues(
    new[]
    {
        new SecretProperties("secret5"),
        new SecretProperties("secret6")
    },
    continuationToken: null,
    Mock.Of<Response>());

Pageable<SecretProperties> pageable = Pageable<SecretProperties>
    .FromPages(new[] { page1, page2, lastPage });

AsyncPageable<SecretProperties> asyncPageable = AsyncPageable<SecretProperties>
    .FromPages(new[] { page1, page2, lastPage });

Thanks, my scenario is that I want to test my code that calls ConfigurationClient.GetConfigurationSettingsAsync.AsPages(IEnumerable<MatchConditions>). Before, I only had calls to AsPages() without any params and that was fine because I could create a mock of AsyncPageable<ConfigurationSetting> and implement a mock AsPages method. However, that doesn't work anymore because I'm not allowed to mock an extension method in Moq and I can't just create a new AsPages on the mock pageable like I have before, since it won't be an extension.
For example, I can't do this:
            var mockClient = new Mock<ConfigurationClient>(MockBehavior.Strict);

            mockClient.Setup(c => c.GetConfigurationSettingsAsync(
                It.IsAny<SettingSelector>(),
                It.IsAny<CancellationToken>())
            .AsPages(
               It.IsAny<IEnumerable<MatchConditions>>(),
               It.IsAny<string>(),
               It.IsAny<int>()))
            // rest of setup

and I can't just mock GetConfigurationSettingsAsync because when it calls the AsPages(IEnumerable<MatchConditions>) extension method, it throws InvalidOperationException.
Let me know if that makes sense or if there's a different way to test the extension.

@amerjusupovic:  In this case, you'd want to combine the approach that I described above along with a custom mock extension method.  By defining your extension method in the same namespace as the code calling it and using actual types rather than open generics, it will be the implementation that the compiler prefers.
for example:

Page<ConfigurationSetting> page1 = Page<ConfigurationSetting>.FromValues(
    new[]
    {
        new ConfigurationSetting("secret1", "val1"),
        new ConfigurationSetting("secret2", "val2")
    },
    "continuationToken",
    Mock.Of<Response>());

Page<ConfigurationSetting> page2 = Page<ConfigurationSetting>.FromValues(
    new[]
    {
        new ConfigurationSetting("secret3", "val3"),
        new ConfigurationSetting("secret4", "val4")
    },
    "continuationToken2",
    Mock.Of<Response>());

Page<ConfigurationSetting> lastPage = Page<ConfigurationSetting>.FromValues(
    new[]
    {
        new ConfigurationSetting("secret5", "val5"),
        new ConfigurationSetting("secret6", "val6")
    },
    continuationToken: null,
    Mock.Of<Response>());

AsyncPageable<ConfigurationSetting> asyncPageable = AsyncPageable<ConfigurationSetting>
    .FromPages(new[] { page1, page2, lastPage });

var mockClient = new Mock<ConfigurationClient>();

mockClient
    .Setup(c => c.GetConfigurationSettingsAsync(
        It.IsAny<SettingSelector>(),
        It.IsAny<CancellationToken>()))
    .Returns(asyncPageable);

// Invoke the mocks
var mockPagable = mockClient.Object.GetConfigurationSettingsAsync(new(), default);
var mockPages = mockPagable.AsPages(new[] { new MatchConditions() });

// Mock extensions with more specific typing and namespace locality.
public static class MockExtensions
{
    public static async IAsyncEnumerable<Page<ConfigurationSetting>> AsPages(
        this AsyncPageable<ConfigurationSetting> instance,
        IEnumerable<MatchConditions> matches,
        string continuationToken = null,
        int? pageHint = null)
    {
        await foreach (var page in instance.AsPages())
        {
            yield return page;
        }
    }
}


Formatting fixes - OTEL Traces Instrumentation

Purpose of this pull request
Formatting fixes - OTEL Traces Instrumentation
Select the type of change

[x] Minor Changes - Typos, formatting, slight revisions
[ ] Update Content - Revisions, updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)
https://sumologic.atlassian.net/browse/DOCS-255

Great work @kimsauce. LGTM!!

Thank you!🥹☺


Change delimiter in links so Zoom displays clickable URLs correctly

Zoom chat really doesn't like the '-' character in PeerPad URLs... when they are posted to Zoom chat, it doesn't highlight the last part of the URL, which has the write key, which results in a read-only link, which is super confusing.
It's really a bug in Zoom, but I think maybe if we switch the delimiter to an underscore or similar, we can avoid that bug.

It should be easy to do with a regex... I'll try to do it now.

I coded up a complete fix... but then I discovered Zoom doesn't like the underscore either.
I experimented with the URLs a bit in a Zoom chat session, and it's actually breaking because the URLs are too long. Any portion of a URL past a certain length limit ... Zoom will chop the clickable part of the URL. :-(
I can't think of a good simple fix that doesn't involve using a URL shortener.
For now, we can just educate testers on our team to select the entire URL with their mouse and copy-and-paste it. For wider testing with Zoom users, we'll need a different solution.

With '_' delimiter:

No delimiters at all, remove slash:

@jimpick are you using the macOS client of Zoom? Seems to be a platform dependent bug in Zooms client, as the links work properly for me on Ubuntu 18.04.

Have we reported this to Zoom? It's clearly not a good behaviour in the client, maybe they'll be able to solve it quickly.

I couldn't find a good bug reporting form, so I sent an email to<EMAIL_ADDRESS>

I received a response from Zoom: "Our engineers have told me that this is a known issue and that it will be fixed in an update before too long."

I tested with the current version of Zoom, and it's fixed, so I'm closing this.


Adjust facts handling to only downcase fact names in facts hash

Only the top-level keys, corresponding to the fact names, in the
facts hash should be downcased. Puppet leaves any keys as part
of a hash returned from a structured fact in the original case.

Changes Unknown when pulling febd2f343f8a3998c28ae14572a7e9314ef97f5b on seanmil:issue-506 into ** on rodjek:master**.

Changes Unknown when pulling 6fedee5b81452c36118a7a064432d63377e57204 on seanmil:issue-506 into ** on rodjek:master**.

Changes Unknown when pulling eb45a799fd021932ffb5610f820950c42c073eb2 on seanmil:issue-506 into ** on rodjek:master**.

Is there anything needed on this PR? Just hoping it doesn't get missed if there is a new release in the works.

Thanks for your contribution. No worries, we would have done a triage/merge pass before release anyways.


Renamed getStart => getStartPosition for consistency.

Renamed Node#getStart to Node#getStartPosition to be consistent with Node#getEndPosition.

@dantleech,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@dantleech, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Cleaning up PRs - I'm going to close this for the reasons in the comment above, but I still want to make these names consistent. I filed #166 to come up with better names.


openssh-sftp-error needs to bump major version

openssh-sftp-error has a break change about bumping openssh version in 0.3.2, but it only updates a minor version from 0.3.1.
This will result in a compilation failure, which occurs in https://github.com/apache/incubator-opendal/actions/runs/6885228025/job/18729057412

@silver-ymz I've yanked.v0.3.2 , can you publish a new version of it and openssh-sftp-client please?
I don't have access to my laptop now.

can you publish a new version of it and openssh-sftp-client please?

Yes. Thank you.

openssh-sftp-error is a dependency of openssh-sftp-client-lowlevel and openssh-sftp-client.  It seems that if we release a new major version of openssh-sftp-error, openssh-sftp-client-lowlevel and openssh-sftp-client also need to bump major version.
Should we yank openssh-sftp-client v0.14.0 and release v0.14.1? When user use openssh-sftp-client v0.14.0, openssh 0.9.9 and 0.10.0 will be used at the same time to result in a compilation failure.

@silver-ymz Yankee openssh-sftp-client v0.14.0, there's no v0.14.1

done in #113, https://crates.io/crates/openssh-sftp-client/versions


Release an 'agile' version of Navigation

Brief
By the end of the cycle
We want to release an 'agile' version of Navigation, here is the card where we captured what we have defined agile as.
Here are some tasks we can probably do as a team:

Final code changes
Final browser testing
Final accessibility testing
Prepare preview pages and examples
Design review
Engagement with stakeholders

Aligns with step 7 of the contribution model:

Publish

We worked on step 6 in the previous cycle, Plan and determine how to release Navigation #3888
Epic lead
Charlotte
Driving role(s) as referenced in the team playbook
beeps, Calvin
Supporting role(s) as referenced in the team playbook
Anika, Izabela, whole team (?)
Further detail

Here is the mural board we were working on to define the agile release
Here is the retro board with the suggestions on how we can improve this cycle
We have a squad slack group #ds-navigation, we use the canvas for tracking documents we create

General tasks and planning
### Epic lead and delivery
- [ ] https://github.com/alphagov/govuk-design-system/issues/3778
- [x] Review [Navigation Decision Log](https://docs.google.com/spreadsheets/d/1zduTR-kZc5j28PFMi98-KNoP8W8S-8iJtisf9nLAbIM/edit#gid=1037439525), ensure it's up-to-date
- [x] Put together our plan for unsure decisions (from retro)
- [x] Identify blockers at start of cycle, prioritise work to unblock them (from retro)
- [ ] https://github.com/alphagov/govuk-design-system/issues/3914
- [ ] https://github.com/alphagov/govuk-frontend/issues/5271
- [ ] https://github.com/alphagov/govuk-design-system/issues/4076

### All squad
- [x] review oustanding guidance changes from previous cycle
- [ ] https://github.com/alphagov/govuk-design-system/issues/4038
- [x] Decide whether to change guidance in 'Phase banner' re: where to place

### Accessibility and Development
- [x] Final accessibility testing (may need to defer due to team leave)
- [x] Implement a more legible version of the navigation items
- [x] Two variations of the blue bar that sit beneath the black header bar, known as 10px border-bottom on the govuk-header__container
- [x] Refactor active state styles
- [x] Explore accessibility considerations (landmark announcement)
- [x] Create a preview release link for guidance examples

### Guidance
- [ ] https://github.com/alphagov/govuk-design-system/issues/4036
- [ ] https://github.com/alphagov/govuk-design-system/issues/4039
- [ ] https://github.com/alphagov/govuk-design-system/issues/4040
- [ ] https://github.com/alphagov/govuk-design-system/issues/4041
- [ ] https://github.com/alphagov/govuk-design-system/issues/4042
- [x] Update phase banner guidance (small)
- [x] add guidance into preview pages

### Design
- [x] Double check focus state of refactored active navigation items
- [ ] https://github.com/alphagov/govuk-design-system/issues/4065
- [ ] https://github.com/alphagov/govuk-design-system/issues/4052
- [x] Check that stakeholders know we are releasing an 'agile' release

Navigation is published 29 August 2024 🎉


Adds support for using findings from list ofmonitors as input data for a monitor in workflow

Please add the description piece for the PR


Drop pearls when going through portals

When the pearl is dropped, could it get pulled through the portal? Or moved through with a dispenser?

Nah, ExilePearl handles that in this class by cancelling that. although in our case, it would likely mean those taking pearling into the nether from overworld will go through the portal and sacrifice the pearl to the void
Dispensers shouldnt have any effect on portal stuff


Ios receives notifications in json

Expected Behaviour
Supposed to be just text
Actual Behaviour
Get json.

Is it a bug? Was working perfectly, we changed nothing. Started 1 of september.

Sorry to be a jerk but I'm now closing issues that don't follow the issue submission guidelines. This plugin takes a lot of work to maintain and I can't afford the time required to solicit the required info from everyone.
I'm closing this issue but please feel free to re-open the issue if you provide the requested details from the new issue submission guidelines.
https://github.com/phonegap/phonegap-plugin-push/blob/master/.github/ISSUE_TEMPLATE.md


Need a way to specify tag for image during build

Currently there is an issue that during build, image name is derived from the project name (converted to lowercase) but tag is generated. This  becomes a problem if Tekton pipeline is only used for build/push and deploy is done using Jenkins. Image name and tag needs to be specifed in the Jenkins files.
Link to guide for reference: https://kabanero.io/guides/jenkins-integration-with-kabanero/
Deploy task use image name and tag specified in app-deploy.yaml file but there is no way to specify tag (and image name) for the build task.

I'm working https://github.com/kabanero-io/kabanero-pipelines/issues/159 and consider that to be prereq work for this item.
As of today, I consider this issue at risk for dcut.

The team, Steve, Brian and Vijai, are working on solving the issue.

Update the Jankins guide to reflect the options for the user to figure out the tag.

@brianxjx is going to open a doc issue with ID to complete the update to the guide and add the link to the doc in this issue.

Current thinking by the team is that we doc the way forward.
A simple modification to the pipeline (by the customer) would preserve the repoName as app_image &
replace default behavior of commit from git as tag with a tag the customer chooses to place both in the trigger binding files for the pipeline and in the jenkinsFile.
e.g.
14c15
<     value: $(body.repository.name):$(body.pull_request.head.sha)
---
>     value: $(body.repository.name):latest
34c35
<     value: $(body.repository.name):$(body.head_commit.id)
---
>     value: $(body.repository.name):latest

https://github.com/kabanero-io/guide-jenkins-integration-with-kabanero/issues/24

@brianxjx - Please update this issue with what would be provided for SVT to test with.

Update to the guide will be made. Provide a task with a pipleline to be used by the Jankins.

Will be included in the rc-6 pipeline and @brianxjx is working on the docs.

the build push variants of the pipeline(s) have been updated to lift the image from the appsody name in the app-deploy.yaml and the tag as latest.
This matches the guidance in the jenkins guide.

the  issue kabanero-io/guide-jenkins-integration-with-kabanero#24 has been closed.  Updates were made via https://github.com/kabanero-io/guide-jenkins-integration-with-kabanero/pull/23

@brianxjx - Does @mtamboli has what she needs to verify this issue?

@brianxjx I am verifying this defect. I created a webhook with the pipeline java-microprofile-build-push-jk-pl .
I see that the image name seems to be picked up by the name field instead of applicationImage field? I would have expected it to be picking applicationImage. Am I missing anything?
metadata:
  name: jmp-svt
spec:
  # Add fields here svt
  version: 1.0.0
  applicationImage: svt-jmp-jk

@brianxjx is taking the next steps to make the guide more intuitive. Thereafter, we can close the issue.

@brianxjx How are we resolving this?

@mtamboli Is this not resolved?
Unfortunately I have been temporarily removed from the pipelines team.  @kvijai82 ?

@brianxjx is taking the next steps to make the guide more intuitive. Thereafter, we can close the issue.

@brianxjx No worries. There was a comment above that you were modifying the guide so wanted to confirm if that is done?

@kvijai82 Let us discuss and try to resolve this.


HLS is not LIVE

When I am playing as HLS, it's always starting from first ts. That means it doesn't show live.

Please read wiki

I have already saw the wikiw. But here it is not mentioned how to change mode/HLS type (Live, Event, Loop...)


fix: Fix extension publish script

copilot:all

Current dependencies on/for this PR:

main

PR #3202   👈

This comment was auto-generated by Graphite.


Call it developerId everywhere

It's a little annoying that some APIs give developerId while others take as input devId (e.g .app(), .developer())
We should pick one naming scheme and stick with it everywhere.

PRs welcome


python312Packages.pony: fix python3.12 compat, fix flask-mailman, fix flask-security-too

Description of changes

Pull upstream PR to fix python3.12 compatibility.
Update flask-mailman to fix compatibility with python3.12 (found during nixpkgs-review)
Fix flask-security-too by relaxing a dependency (failure found during nixpkgs-review)

Since these new build failures are only apparent when pony is fixed and are downstream, they are included in this PR
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

closes https://github.com/NixOS/nixpkgs/pull/326096

Add a :+1: reaction to pull requests you find important.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 325181 run on x86_64-linux 1

3 packages failed to build and are new build failures:

agda-pkg: plain log
agda-pkg.dist: plain log
tribler: log was empty

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python311Packages.ponywhoosh.dist:

got build log for '/nix/store/h91ma0rjsc3kbxkdw6cnvvrn5nszn1dq-python3.11-ponywhoosh-1.7.8-dist' from 'daemon'
When evaluating attribute ‘python311Packages.ponywhoosh.dist’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/ponywhoosh/default.nix:26:
   |
26 |     description = "Make your database over PonyORM searchable";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

python311Packages.ponywhoosh:

got build log for '/nix/store/s7x8vzwnidih2pyddiv3nsyc9waflq87-python3.11-ponywhoosh-1.7.8' from 'daemon'
When evaluating attribute ‘python311Packages.ponywhoosh’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/ponywhoosh/default.nix:26:
   |
26 |     description = "Make your database over PonyORM searchable";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

python312Packages.ponywhoosh.dist:

got build log for '/nix/store/p0grs3dhqsyjvqkgn5vljqwdl3kndrj9-python3.12-ponywhoosh-1.7.8-dist' from 'daemon'
When evaluating attribute ‘python312Packages.ponywhoosh.dist’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/ponywhoosh/default.nix:26:
   |
26 |     description = "Make your database over PonyORM searchable";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

python312Packages.ponywhoosh:

got build log for '/nix/store/jkirpmb8vkv9g8di671pbmcivig0fbj1-python3.12-ponywhoosh-1.7.8' from 'daemon'
When evaluating attribute ‘python312Packages.ponywhoosh’:
warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/python-modules/ponywhoosh/default.nix:26:
   |
26 |     description = "Make your database over PonyORM searchable";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-python-tests.md

3 packages failed to build and are new build failures:
* agda-pkg: [plain log](https://termbin.com/zvul)

* agda-pkg.dist: [plain log](https://termbin.com/vztb)

Python3.12 related (ModuleNotFoundError: No module named 'distutils')

* tribler: log was empty

Probably also Python3.12 related

Git commit body is missing release notes for:

python312.flask-mailman: 1.1.0 -> 1.1.1

Result of nixpkgs-review pr 325181 run on x86_64-linux 1

3 packages failed to build:

agda-pkg
agda-pkg.dist
tribler

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

Result of nixpkgs-review pr 325181 run on aarch64-darwin 1

14 packages failed to build:

agda-pkg
agda-pkg.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist

10 packages built:

mutmut
mutmut.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

Darwin build is failing:

python311Packages.flask-mailman: https://termbin.com/fbax

Result of nixpkgs-review pr 325181 run on aarch64-darwin 1

2 packages failed to build:

agda-pkg
agda-pkg.dist

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

@superherointj thanks for the build and review! I was unable to reproduce your build failure for some reason?

agda-pkg is just:

ModuleNotFoundError: No module named 'distutils'

Result of nixpkgs-review pr 325181 run on aarch64-darwin 1

14 packages failed to build:

agda-pkg
agda-pkg.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist

10 packages built:

mutmut
mutmut.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

@superherointj thanks for the build and review! I was unable to reproduce your build failure for some reason?

Might host might be unreliable. It's the shared community darwin builder. And I'm a bit too locked there to try to sort this out.
I will trust your host then.
Can you just fix agda-pkg? Seems straightforward.
I'd prefer zeroing the builds failures.

Result of nixpkgs-review pr 325181 run on x86_64-linux 1

3 packages failed to build:

agda-pkg
agda-pkg.dist
tribler

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

Actually, it seems agda-pkg is being unmaintained upstream (https://github.com/agda/agda-pkg/issues/49). Since no pkgs inside nixpkgs seem to depend on it and this does not appear to be a simple fix, I'll vote to remove this package.  @alexarice you are listed as maintainer of this package: What do you recommend?

tribler fails due to a dependency failure of libtorrent-rasterbar-1.2.11 (also a distutils python3.12 issue). I'd rather keep the scope of the PR down (as it fixes packages with some dependencies, alongside pgadmin4). Maybe some of the maintainers of tribler can have a look into it? (libtorrent-rasterbar is unmaintained)

I think its safe to remove agda-pkg if it isn't maintained upstream. I believe it isn't widely used and is not used in any of the agda infrastructure

I found a fix for libtorrent-rasterbar-2_0_x. Add to pkgs/top-level/all-packages.nix:

python = python3Packages.python.withPackages (p: [ p.setuptools ]);

python = python3Packages.python.withPackages (p: [ p.setuptools ]);

Cool. But doesn't tribler use a special libtorrent-rasterbar-1_2_x version?

python = python3Packages.python.withPackages (p: [ p.setuptools ]);

Cool. But doesn't tribler use a special libtorrent-rasterbar-1_2_x version?

Yeah, just mark it broken then.

python = python3Packages.python.withPackages (p: [ p.setuptools ]);

Cool. But doesn't tribler use a special libtorrent-rasterbar-1_2_x version?

Yeah. I can mark it broken if you don't want.

Done

Just FYI: I did try your suggestion with the 1.2 version and it got passed the initial distutils error, but later failed to build with
libtorrent-rasterbar> Making all in python
libtorrent-rasterbar> make[2]: Entering directory '/build/source/bindings/python'
libtorrent-rasterbar> /nix/store/m22r7gsvm4w3ib3y2jcsnx0l7mis050q-python3-3.12.4-env/bin/python ./setup.py build
libtorrent-rasterbar> /build/source/bindings/python/src/converters.cpp: In static member function ‘static void to_string_view::construct(PyObject*, boost::python::converter::rvalue_from_python_stage1_data*)’:
libtorrent-rasterbar> /build/source/bindings/python/src/converters.cpp:159:63: error: ‘PyUnicode_AS_DATA’ was not declared in this scope; did you mean ‘PyUnicode_DATA’?
libtorrent-rasterbar>   159 |             data->convertible = new (storage) lt::string_view(PyUnicode_AS_DATA(x)libtorrent-rasterbar>       |                                                               PyUnicode_DATA
libtorrent-rasterbar> /build/source/bindings/python/src/converters.cpp:159:85: error: ‘PyUnicode_GET_DATA_SIZE’ was not declared in this scope
libtorrent-rasterbar>   159 |             data->convertible = new (storage) lt::string_view(PyUnicode_AS_DATA(x), PyUnicode_GET_DATA_SIZE(x));
libtorrent-rasterbar>       |                                                                                ^~~~~~~~~~~~~~~~~~~~~~~
libtorrent-rasterbar> error: command '/nix/store/kp2j7yn0wzwq5piy494r54dafrh83s6s-gcc-wrapper-13.3.0/bin/g++' failed with exit code 1

So, yeah, seems broken either way

Result of nixpkgs-review pr 325181 run on x86_64-linux 1

1 package marked as broken and skipped:

tribler

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

Result of nixpkgs-review pr 325181 run on aarch64-darwin 1

22 packages built:

mutmut
mutmut.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-mailman
python311Packages.flask-mailman.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.pony
python311Packages.pony.dist
python311Packages.ponywhoosh
python311Packages.ponywhoosh.dist
python312Packages.flask-mailman
python312Packages.flask-mailman.dist
python312Packages.flask-security-too
python312Packages.flask-security-too.dist
python312Packages.pony
python312Packages.pony.dist
python312Packages.ponywhoosh
python312Packages.ponywhoosh.dist

@gador I want to merge this but CI eval isn't helping... Wake me up when this is done.

We should have seen this #325297


Rabby doesn't connect when manually calling activateBrowserWallet

Try calling activateBrowserWallet({ type: 'metamask' }) with Rabby. It won't connect until you reload the page (eagerly connects).

This issue is only present at the start of a new browser instance. Subsequent connections work properly.

This seems like an issue with Rabby, and I could not find a workaround.
Users must refresh the page after the first connection attempt and it'll work properly from there.


DROOLS-707 - more test failures when changing order of rules

I found other 2 cases where I get not consistent behavior with variables and order of the rule lines.
I created this pull request with a few cases, if I remember correctly, the line that throws a NPE is exactly the same as the problem has been fixed already in DROOLS-707.

Can one of the admins verify this patch?

This was just a failing test to replicate the bug, the patch of this bug has gone live with 6.2.0.Final

@fpeloi-bmj thanks for the info, closing the PR.


Monolog custom logger non existent service

My Symfony 5.2.9 app is running on my local Apache 2.0 server (on my machine) with php 8.0.3
My app is using a custom monolog logger (user_activity), defined both in dev and prod environment
dev/monolog.yaml
monolog:
  channels: [ 'user_activity' ]
  handlers:
    main:
      type: stream
      path: "%kernel.logs_dir%/%kernel.environment%.log"
      level: debug
      channels: [ "!event", "!user_activity" ]
    console:
      type: console
      process_psr_3_messages: false
      channels: [ "!event", "!doctrine", "!console", "!user_activity" ]
    user_activity:
      type: rotating_file
      path: "%kernel.logs_dir%/user_activity.log"
      level: debug
      channels: user_activity
      max_files: 14 # 2 settimane

prod/monolog.yaml
monolog:
  channels: [ 'user_activity' ]
  handlers:
    main:
      type: fingers_crossed
      action_level: error
      handler: nested
      excluded_http_codes: [ 404, 405 ]
      buffer_size: 50 # How many messages should be saved? Prevent memory leaks
    nested:
      type: stream
      path: "%kernel.logs_dir%/%kernel.environment%.log"
      level: debug
      channels: [ "!user_activity" ]
    console:
      type: console
      process_psr_3_messages: false
      channels: [ "!event", "!doctrine", "!user_activity" ]
    user_activity:
      type: rotating_file
      path: "%kernel.logs_dir%/user_activity.log"
      level: debug
      channels: user_activity
      max_files: 14 # 2 settimane

When i run composer on my local machine it's all ok.
I've deployed in AWS with CodePipeline + Beanstalk (this is using Nginx instead of Apache).
The problem is that the deployment fails due to
eb-engine.log
Script cache:clear returned with error code 1
!!
!!  In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
!!
!!    The service "App\Model\Payment\StripePayment" has a dependency on a non-exi
!!    stent service "monolog.logger.user_activity". Did you mean one of these: "m
!!    onolog.logger.http_client", "monolog.logger.security"?
!!
!!
!!
Script @auto-scripts was called via post-update-cmd

But if i run php bin/console debug:container monolog the service is there showing in all of his splendor

Do someone knows whta the h*ll is going on?

Mistake with the APP_ENV=dEv


Is it maintained?

Hi!
This library has some interesting syntax solutions. However, looking at Pulse, I wonder is it still maintained?

Yes it is and since all the development is done, there is hardly anything else I can add to it

Thanks for reply
Hm, there seems to be 10 unresolved issues and some non-Greenkeeper PRs, so that made feeling of abandoned library...


application: Sherrington Kirkpatrick (SK) model

Summary
I added the Sherrington Kirkpatrick (SK) model to the applications part of qiskit-optimization module.
Details and comments

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: lca:x: X-Liborlca seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

In regards of the code - if you run make black in youre repo clone root then it will format the code according to how its checked (CI checks the format via black but does not change things) We use black nowadays to ensure consistent style rather so the tool can just be run - rather than using style checks and expecting the code to be manually fixed.

For spelling issues, names are often the case where they are not in the standard dictionary, we have a custom dictionary file here https://github.com/Qiskit/qiskit-optimization/blob/main/.pylintdict where you just add the word(s) - lowercase and in order alphabetically so its easier to manage - so if the word is correctly spelled please just add it to that dictionary file and commit the change with this PR.

To have the documentation come out and have the class exposed it should be added to the applications init file here https://github.com/Qiskit/qiskit-optimization/blob/main/qiskit_optimization/applications/init.py
Since you fixed the spelling I assume you have figured you look at the build Details of a given job to see what is failing - often its the same across 3.6, 3.7 etc where we test under the different Python versions.

Could you add SKModel to the docstring of __init__.py of applications?

The discussion threads get long. So, let me summarize it.

Input of the constructor: This PR receives the number of sites and random number generator as input of the constructor to ensure all edge weights satisfy the SK model property, i.e., ±1. I proposed to make edge weights as input so that users can manually set them. They may give edge weights that do not satisfy the property ±1. I think the constructor can raise a warning in such case.

# PR
def __init__(self, num_of_sites: int, rng: np.random.RandomState = np.random.RandomState(0))

# my proposal
def __init__(self, num_of_sites: int, edge_weights: np.ndarray)

Destructive update of instance: This PR includes a public method new_instance to destructively update the edge weights. I proposed to make a new instance with new edge weights, e.g.,

@staticmethod def random_instance(num_sites, rng: np.random.Generator)

Minor point:

This PR uses the legacy random state of numpy and I propose to use the new random generator.

If anything missing, feel free to add comments @X-Libor.

The discussion threads get long. So, let me summarize it to ask for comments of other developers.
1. Input of the constructor: This PR receives the number of sites and random number generator as input of the constructor to ensure all edge weights satisfy the SK model property, i.e., ±1. I proposed to make edge weights as input so that users can manually set them. They may give edge weights that do not satisfy the property ±1. I think the constructor can raise a warning in such case.

# PR
def __init__(self, num_of_sites: int, rng: np.random.RandomState = np.random.RandomState(0))

# my proposal
def __init__(self, num_of_sites: int, edge_weights: np.ndarray)

1. Destructive update of instance: This PR includes a public method `new_instance` to destructively update the edge weights to evaluate different edge weights efficiently. I proposed to make a new instance with new edge weights, e.g.,

@staticmethod
def random_instance(num_sites, rng: np.random.Generator)

It might not be as efficient as this PR but I think my proposal is easier to reproduce an instance.
Minor point:
* This PR uses the [legacy random state](https://numpy.org/doc/stable/reference/random/legacy.html) of numpy and I propose to use the new [random generator](https://numpy.org/doc/stable/reference/random/generator.html).

If anything missing, feel free to add comments @X-Libor.

I cannot comment directly to this.
Checking just \pm 1 is not sufficient for the asymptotic behavior the model has. It is a solvable model and the weights are random from some distribution that has mean 0 and variance 1. (please see the SK model review I shared).

If we evaluate the asymptotic behavior, we need to solve multiple instances of the model. What kind of usage do you have in mind? Could you give me an example of how to evaluate the asymptotic behavior with this class?
As for performance, it would be good to avoid using networkx as an internal data structure because it is slow. I'm actually working on replacing all networkx in applications with retworkx #150 because the latest retworkx supports visualization as networkx.
I think 2D ndarray is a better option because you make a complete graph and 2D ndarray can directly represents weights. If you return weights as ndarray instead of graph method, users can generate networkx graph for visualization. It is more efficient because users need to generate an networkx object only when necessary.
import numpy as np
rng = np.random.default_rng(1)

a = np.triu(rng.choice([-1, 1], (4, 4)), k=1)
b = a + a.T # symmetric weights of ±1
print(b)
# [[ 0  1  1  1]
#  [ 1  0  1  1]
#  [ 1  1  0 -1]
#  [ 1  1 -1  0]]

import networkx as nx
g = nx.Graph(b)
print(g.edges.data('weight'))
# [(0, 1, 1), (0, 2, 1), (0, 3, 1), (1, 2, 1), (1, 3, 1), (2, 3, -1)]

If we evaluate the asymptotic behavior, we need to solve multiple instances of the model. What kind of usage do you have in mind? Could you give me an example of a typical use case of this class?
As for performance, it would be good to avoid using networkx as an internal data structure because it is slow. I'm actually working on replacing all networkx in applications with retworkx #150 because the latest retworkx supports visualization as networkx.
I think 2D ndarray is a better option because you make a complete graph and 2D ndarray can directly represents weights. If you return weights as ndarray instead of graph method, users can generate networkx graph for visualization. It is more efficient because users need to generate an networkx object only when necessary.
import numpy as np
rng = np.random.default_rng(1)

a = np.triu(rng.choice([-1, 1], (4, 4)), k=1)
b = a + a.T # symmetric weights of ±1
print(b)
# [[ 0  1  1  1]
#  [ 1  0  1  1]
#  [ 1  1  0 -1]
#  [ 1  1 -1  0]]

import networkx as nx
g = nx.Graph(b)
print(g.edges.data('weight'))
# [(0, 1, 1), (0, 2, 1), (0, 3, 1), (1, 2, 1), (1, 3, 1), (2, 3, -1)]

Can we have a discussion thread for this? I am sorry, I cannot reply to your comments.
*Even if you do not evaluate the asymptotic properties you want the model to actually be the model that it claims to be.
*You can always get rid of all graphs and represent them with adjacency/Laplacian matrices. Do you want this? Why is it so important. How slow is it? I consider this to be a scientific and not a production application --- people are actually using SK to benchmark QAOA (and so). (BTW: I don't believe that this will be a bottle neck.)

I talked with @X-Libor offline. I understood that this application is used like a random instance generator and he does not want users to define instances manually. I personally like to implement an instance generator as a static method, but I'm OK to do it in the constructor.
I checked recirq for reference and found that they implemented the generator as a function and the problem instance as a data class.
https://github.com/quantumlib/ReCirq/blob/144323f212757775a8541dbe2f938b64534b25ec/recirq/qaoa/problems.py#L203

The discussion threads get long. So, let me summarize it to ask for comments of other developers.
1. Input of the constructor: This PR receives the number of sites and random number generator as input of the constructor to ensure all edge weights satisfy the SK model property, i.e., ±1. I proposed to make edge weights as input so that users can manually set them. They may give edge weights that do not satisfy the property ±1. I think the constructor can raise a warning in such case.

# PR
def __init__(self, num_of_sites: int, rng: np.random.RandomState = np.random.RandomState(0))

# my proposal
def __init__(self, num_of_sites: int, edge_weights: np.ndarray)

1. Destructive update of instance: This PR includes a public method `new_instance` to destructively update the edge weights to evaluate different edge weights efficiently. I proposed to make a new instance with new edge weights, e.g.,

@staticmethod
def random_instance(num_sites, rng: np.random.Generator)

It might not be as efficient as this PR but I think my proposal is easier to reproduce an instance.
Minor point:
* This PR uses the [legacy random state](https://numpy.org/doc/stable/reference/random/legacy.html) of numpy and I propose to use the new [random generator](https://numpy.org/doc/stable/reference/random/generator.html).

If anything missing, feel free to add comments @X-Libor.

@t-imamichi I changed the pseudo rng. Please check.

The discussion threads get long. So, let me summarize it to ask for comments of other developers.
1. Input of the constructor: This PR receives the number of sites and random number generator as input of the constructor to ensure all edge weights satisfy the SK model property, i.e., ±1. I proposed to make edge weights as input so that users can manually set them. They may give edge weights that do not satisfy the property ±1. I think the constructor can raise a warning in such case.

# PR
def __init__(self, num_of_sites: int, rng: np.random.RandomState = np.random.RandomState(0))

# my proposal
def __init__(self, num_of_sites: int, edge_weights: np.ndarray)

1. Destructive update of instance: This PR includes a public method `new_instance` to destructively update the edge weights to evaluate different edge weights efficiently. I proposed to make a new instance with new edge weights, e.g.,

@staticmethod
def random_instance(num_sites, rng: np.random.Generator)

It might not be as efficient as this PR but I think my proposal is easier to reproduce an instance.
Minor point:
* This PR uses the [legacy random state](https://numpy.org/doc/stable/reference/random/legacy.html) of numpy and I propose to use the new [random generator](https://numpy.org/doc/stable/reference/random/generator.html).

If anything missing, feel free to add comments @X-Libor.

I cannot comment directly to this.
Checking just \pm 1 is not sufficient for ensuring the asymptotic behavior of the model.
It is a solvable model and the weights are random from some distribution that has mean 0 and variance 1.
(please see the SK model review by Panchenko I shared).

Dear @t-imamichi I adressed the legacy pseudo rng. Please see.

Could you add a release note following the instruction?

Could you add a release note following the instruction?

Done. Please see --- it might be "Much Ado About Nothing".


notification bar display error

During the automatic upload process, if user by coincidient paused the upload process at the very end, (shortly before finishing uploading), all pictures could be uploaded successfully, but the bar cannot be removed afterwards. Also there will be no record for this in recent process.

it happens again when I try to upload pictures by manual upload
14. March 2017

fixed


HA-bridge for QNAP 4.3.2

Just installed version 4.3.2 at my QNAP NAS and it doesn't work.
The ha-bridge doesn't start?

Little more precision would be nice. What about the logfiles?

That version is interesting... Please search the closed issues please, this has been discussed


ShouldHaveValidationErrorFor fails to say the test failed (when it should have failed).

Hi @JeremySkinner  :wave:
I've got a weird one here - and here is a full repo of the issue.
When I try and use ShouldHaveValidationErrorFor in my unit test, and i'm validating against a collection using RuleForEach the normal validator correctly captures the error (yay!) but the unit test extension method fails to find that error message in the (internal) Errors collection. As such, it thinks there was no error for the property I'm testing.
The reason for this is that the Property name is Foo but because this is really a collection of Foo's, the property name in the error is Foo[0] (or which ever item in the collection failed).
Here's a screen shot of the sample error:
RuleForEach(user => user.Links)
                .Must(LinkMustBeAUri) // given a string, return true/false if it's a URI.
                .WithMessage("Link '{PropertyValue}' must be a valid URI. eg: http://www.SomeWebSite.com.au");

...

_validator.ShouldHaveValidationErrorFor(l => l.Links,
                    new [] { "!2134242", "adhgahsjdasdgjhad" },
                    ResidentialListingValidator.MinimumRuleSet);

ValidationResultTester.cs line: 46

So. to recap.

I've got: public string[] Links { get; set; }
I'm validating that the content of this collection is valid
The validator correctly finds the error. YAY!
The test extension method fails to figure this out. Damn :cry:

As linked above - a full repo of the code is above.

Thanks, yes, the TestHelper doesn't support RuleForEach at present.

@JeremySkinner is that something you'd like to do eventually? If so, I'll create a new issue to discuss it and reference this one there.

Yes, although it might not be for a while!

I've just come across this same issue myself. In a lot of places, I'm able to avoid the issue by using collection validators. However, that also doesn't work if the collection type is a simple type rather than a class. I've got places where I need to validate a collection of int values are within a range, etc.
@JeremySkinner Is there any possibility of supporting RuleForEach tests soon?

@richardp-au do you have your code hosted in github?
I would like to see it.

I've added this to the backlog but currently have no timeframe from this. Would appreciate community contributions if this is something you'd find valuable, otherwise I'm afraid it's not likely to be added for quite a while.

This is fixed in the latest commit.


Fixing unmatched header defines and recursive inclusion of threadmana…

…ger.hpp in threadmanager.hpp

Sorry hartmut, i think i have misinterpreted the name in the file thing then. i thought we had to change the name thing as soon as we get involved in a file, i thought it was a thing to identify and blame people in case some stuff goes wrong, so more like a obligatory requirement.
i am happy to not show up, as i didnt really contribute but just changed a minor thing :D

@hendrx No problem at all!


split dev directories to own repo

trying to split core library from development work

To notify the larger github community - @PerryBhandal is actively working towards this. The new repo for dev will be located at: https://github.com/NASA-Tensegrity-Robotics-Toolkit/DTRLdev
If you have commit access to NTRTsim, you should have commit access to DTRLdev.

A few ongoing things in examples and test_integration need to occur prior to migration. I've started on them here: https://github.com/NASA-Tensegrity-Robotics-Toolkit/NTRTsim/tree/DevFreeExamples
Currently on that branch core and examples build w/o dev, but I still need to:
(1) Update dev with the new paths
(2) Move some integration test dependencies into a better location.


stableToken checks exchangeIdentifier exist in the registry on initialization

Description
Checks that exchangeIdentifier is valid on initialization.
Other changes

Tested
Added unit tests.
Related issues

Backwards compatibility

closes https://github.com/celo-org/celo-labs/issues/795

We agreed we wont fix this.


rename get getters

depends on https://github.com/gtk-rs/gir/pull/1021
cc @fengalin
I have noticed few properties having their getter removed, is that normal? there were also some ones that didn't got renamed. I will have another look tomorrow and point them to see whether there's something actionable or not. Otherwise seems to be working fine!

This can be closed now, thanks to @fengalin's PR! :D


MINOR increase develocity expiry to 4 hours

We are using short-lived access tokens for ge.apache.org. The default expiry time is 2 hours which is not long enough for some of our CI workflows. This patch increases the expiry to 4 hours. This gives us some buffer beyond our CI timeout of 3 hours.

@mumrah I think we should clear the branches we create in the apache/kafka repo once work is complete. I see we have a bunch of gh- branches.


findSequenceOnDisk() should try to observe the provided padding chars when matching

When findSequenceOnDisk() is given a sequence such as "/path/to/foo.@@@@@.ext", it really just treats the padding as a single wildcard like "/path/to/foo.*.ext". This will work fine in cases where directories observe conventions of not containing mixed sequences. Even having mixed sequences in the same directory would be fine, but in cases where there are two sequences named exactly the same but using different frame padding, the results will not reflect the one that matches the originally specified padding.
Example:
/path/to/foo.1-100@@@@@.ext
/path/to/foo.1-100#.ext
findSequenceOnDisk("/path/to/foo.#.ext")
# /path/to/foo.1-100@@@@@.ext

findSequenceOnDisk() now has a "strictPadding" flag to apply filtering based on the padding size of the given pattern:
findSequenceOnDisk("/path/to/foo.#.ext")
# /path/to/foo.1-100@@@@@.ext

findSequenceOnDisk("/path/to/foo.#.ext", strictPadding=True)
# /path/to/foo.1-100#.ext


Cross-compile fedimint-sqlite in CI

Inspired by https://github.com/fedimint/fedimint/pull/1270, our CI should probably check that mint-client and fedimint-sqlite can compile on ios / android targets since most mobile apps will use these 2 libraries in tandem.
Not sure how much this will slow down CI, though ...

I'm not sure how to test these commands locally on a mac ...
% nix build -L .#cross.aarch64-android.fedimint-sqlite
error: No Android SDK tarballs are available for system architecture: aarch64-darwin

Also, I notice there is a FM_CLIENT_SQLITE environment vairable in the integration tests. Perhaps we should just use that for CI?

CI was stuck, retriggered

@justinmoon I did some testing and I don't think this sqlite will work on wasm. I mean - wasm32-unknown-unknown doesn't even have an IO, so how would it work?

diff --git a/fedimint-sqlite/Cargo.toml b/fedimint-sqlite/Cargo.toml
index 1fbbaf44ea..9bce28ce30 100644
--- a/fedimint-sqlite/Cargo.toml
+++ b/fedimint-sqlite/Cargo.toml
@@ -11,7 +11,7 @@ path = "src/lib.rs"
 anyhow = "1.0.66"
 async-trait = "0.1"
 futures = "0.3.24"
-sqlx = { version = "0.6.2", features = ["runtime-tokio-native-tls", "sqlite"]}
+sqlx = { version = "0.6.2", default-features = false, features = ["runtime-tokio-native-tls", "sqlite"]}
 fedimint-api = { path = "../fedimint-api" }
 rand = "0.8"
 tracing = "0.1.37"
diff --git a/flake.nix b/flake.nix
index 5855f4f4b7..295ec918df 100644
--- a/flake.nix
+++ b/flake.nix
@@ -38,7 +38,7 @@
         # Env vars we need for wasm32 cross compilation
         wasm32CrossEnvVars = ''
           export CC_wasm32_unknown_unknown="${pkgs.llvmPackages_14.clang-unwrapped}/bin/clang-14"
-          export CFLAGS_wasm32_unknown_unknown="-I ${pkgs.llvmPackages_14.libclang.lib}/lib/clang/14.0.6/include/"
+          export CFLAGS_wasm32_unknown_unknown="-I ${pkgs.llvmPackages_14.libclang.lib}/lib/clang/14.0.6/include/ -I ${pkgs.pkgsi686Linux.glibc.dev}/include/"
         '' + (if isArch64Darwin then
           ''
             export AR_wasm32_unknown_unknown="${pkgs.llvmPackages_14.llvm}/bin/llvm-ar"

For reference the changes I made.

Replaced by #1366


Carthage: RealmSwift unavailable after running 'carthage update'

Having trouble getting RealSwift.framework to appear in the Carthage/Build/iOS/ folder after running carthage update. Using Carthage v0.7.4-beta.2
Have cleared the cache and removed the .resolved, etc. Not sure what the issue is...

What are the contents of your Cartfile? Realm Swift cannot be built from source by Carthage (see https://github.com/Carthage/Carthage/issues/437), so you'll have to use a prebuilt binary release from GitHub. So you can specify github "ReactiveCocoa/ReactiveCocoa" ~> 0.93.1 (or any other versioned requirement) in your Cartfile. Also see #2034 for potentially more information.

I've haven't had to do this before. In the past using github
"realm\realm-cocoa" did the trick.
Why the change?
If this is the new method, please update the docs on realm.io to reflect
this.
Thanks!
On Jun 1, 2015 5:42 PM, "JP Simard"<EMAIL_ADDRESS>wrote:

What are the contents of your Cartfile? Realm Swift cannot be built from
source by Carthage (see Carthage/Carthage#437
https://github.com/Carthage/Carthage/issues/437), so you'll have to use
a prebuilt binary release from GitHub. So you can specify github
"ReactiveCocoa/ReactiveCocoa" ~> 0.93.1 (or any other versioned
requirement) in your Cartfile. Also see #2034
https://github.com/realm/realm-cocoa/issues/2034 for potentially more
information.
—
Reply to this email directly or view it on GitHub
https://github.com/realm/realm-cocoa/issues/2035#issuecomment-107721736.

We recently introduced a new tag (null-string-beta-2), which caused Carthage to think that this was actually Realm v2.0.0, which doesn't have an associated GitHub release, and therefore no attached binaries, which finally means no prebuilt RealmSwift.framework.
https://github.com/Carthage/Carthage/pull/508 was just merged into Carthage, and should likely be available in an upcoming version of the tool. This will restore the previous behavior you saw which is that specifying github "realm/realm-cooca" in your Cartfile should detect the latest stable version of Realm Objective-C and Realm Swift and not null-string-beta-2.

Ok. So for now, we have to manually copy the RealmSwift.framework into the Carthage build directory?

@kevinmlong in the meantime, you can specify github "realm/realm-cocoa" ~> 0.93.1 in your Cartfile.

Great. Thanks!

Hi guys, I am trying to use Realm with Carthage and also Swift 2 here. Any idea how I can get this combination to work since there's no prebuilt binary release for the swift branch?

@NicholasTD07 at the moment, you'll either need to build for source or use something like a git submodule and a subproject to build non-released versions of RealmSwift due to some limitations in Carthage.

@segiddins Thank you.
It came to me that, I can use Carthage to manage Realm as a dependency. The only thing Carthage can't do, well, without a prebuilt binary, is to build the RealmSwift project which I can do it by hand. :)


Use (bytes, len) instead of C strings

It is more versatile to return a struct of (bytes, len) than a null-delimited C string.
The same goes for error callbacks: they should be (bytes, len).

This is done.


Rename NotADag

Validation can fail for reasons other than not being a directed acyclic graph, so the name is misleading. Perhaps InvalidGraph?

That's a bug in the Dag checker 😅 . I have a fix in the works.

If it's a bug in the DAG checker then it's also a documentation bug:
    #[error("The children of an operation {optype:?} must form a dag with single source and sink. Loops are not allowed, nor are dangling nodes not in the path between the input and output. In node {node:?}.")]
    NotADag { node: Node, optype: OpType },

(The docs already imply that there are more conditions than not being a DAG.)

The "single source and sink" requirement is an special kind of DAG. I think we are still in the NotADag category, and the user should be able to see the docs or the error message with the specific info.

Just seems odd to get an error called NotADag for something that is in fact a DAG, just not the right kind of DAG.

Hmm...
https://cs.stackexchange.com/questions/67849/what-do-you-call-a-dag-with-a-single-root-source
How about NotABoundedDAG? "Bounded" because if we interpret it as a poset then it has a maximal and a minimal element?


Add testing scripts & coverage badges to readme

Description
Add script for generating Jest code coverage report.
Add script for generating code coverage badges.
Add badges to README
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x]Generated code coverage report with script.
[x] Generated code coverage badges with script.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 Add code coverage with Jest scripts & badges to README


ARROW-6086: [Rust] [DataFusion] Add support for partitioned Parquet data sources

I discovered this last minute while running manual tests. I have been able to run parallel queries against parquet files using this branch as a dependency.

Sorry @paddyhoran I found this last minute issue ... pretty small fix though.


python311Packages.python-crontab: disable failing test

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Some failures are addressed in #280764.

Result of nixpkgs-review pr 280766 run on x86_64-linux 1

4 packages failed to build:

archivebox
archivebox.dist
baserow
baserow.dist

6 packages built:

python311Packages.django-celery-beat
python311Packages.django-celery-beat.dist
python311Packages.python-crontab
python311Packages.python-crontab.dist
python312Packages.python-crontab
python312Packages.python-crontab.dist


Send report on connection change

Detects when a connection is available and attempts to send any reports which are stored on disk.

Thanks for the feedback @kattrali - I've updated the PR to use SCNetworkReachability directly.

Thanks for all the review comments @kylef - they've been really useful!
@kattrali would you be able to have a look through this PR again? The way we're handling SCNetworkReachability callbacks has changed quite a bit.

This will require updating the manual configuration docs to add SystemConfiguration to frameworks during installation, but I think this is otherwise ready to go.


Enhancement to Components: Configuration property

Current Behavior
In adherence to Meshery Model's design principles:

Treat 3rd-party-authored content/manifests/schemas as hermetically sealed objects.
Treat all Definitions similarly within Meshery’s object model.

Components need a way of capturing declared configuration.
Implementation

Move “configuration” from Designs to Components (https://github.com/meshery/schemas/blob/a7561a749e4dd8b9312fd39f4d11b8b0aac08f74/schemas/constructs/v1beta1/designs.json#L54-L58)
Move “id” from Designs to Components (https://github.com/meshery/schemas/blob/a7561a749e4dd8b9312fd39f4d11b8b0aac08f74/schemas/constructs/v1beta1/designs.json#L23-L26)

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Can I take up this issue ?


feat(query): add new query for tencentcloud TKE resource

Hello, There is something new query for TencentCloud TKE resource:
tke_cluster_has_public_access
tke_cluster_log_disabled
tke_cluster_encryption_protection_disabled
Please help review the PR
Thanks
I submit this contribution under the Apache-2.0 license.

Hello
Please help review the PR
This is my local test

Hello
Please help review the PR
Thanks


Adds NETWAYS Web Services to USERS.md

NETWAYS Web Services added Cilium as CNI option to its Managed Kubernetes offering last year. Thus, we'd like to add ourselves to the users list.
Please ensure your pull request adheres to the following guidelines:

[X] For first time contributors, read Submitting a pull request
[X] All code is covered by unit and/or runtime tests where feasible.
[X] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[X] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[X] All commits are signed off. See the section Developer’s Certificate of Origin
[X] Provide a title or release-note blurb suitable for the release notes.
[X] Are you a user of Cilium? Please add yourself to the Users doc
[X] Thanks for contributing!

Thanks for the addition!


Update bootstrappers

@ryanbrandenburg,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@ryanbrandenburg  @natemcmaster Ping

The changes looked fine to me. @ryanbrandenburg  is OOF, and figured I'd let him take this in when he is back.


Feat add flush method on Android

Summary
Add a method to flush cookies

Test Plan

Call the CookieManager.flush and the cookies should be flushed
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
❌

Android
✅

Checklist

[X] I have tested this on a device and a simulator
[X] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

We call flush in varies methods, I'm assuming the motivation behind this PR is that there are cases where it did not call flush correctly.
This begs the question should the methods manage calling flush themselves or the developer should always explicitly call flush?

We call flush in varies methods, I'm assuming the motivation behind this PR is that there are cases where it did not call flush correctly.
This begs the question should the methods manage calling flush themselves or the developer should always explicitly call flush?

@safaiyeh I don't know what the motivation I only expose this method because this issue @perottilds can you explain with do you need to call this method?

Sure, @luancurti
Below a method I had to use to workaround the fact that I can't directly flush the cookies when my page first loads.
Since flushing is not immediate, I save the token in async storage (yes it's not safe yada yada) and fetch it as soon as the user opens up the app again, since most interactions with the app have a short life span
import { LoginData } from '../observables/OnLoginObservable';
import RNCookieManager from '@react-native-community/cookies';
import AsyncStorage from '@react-native-community/async-storage';
import { config } from '../config';

const ACCESS_TOKEN_STORAGE_KEY = 'cookies.accessToken';

export class CookieManager {
  static async handleLogin(_loginData: LoginData | null) {
    const cookies = await RNCookieManager.get(config.DOMAIN);

    if (!cookies || !cookies.accessToken) {
      return;
    }

    await AsyncStorage.setItem(
      ACCESS_TOKEN_STORAGE_KEY,
      JSON.stringify(cookies.accessToken),
    );
  }

  static async setAccessTokenFromStorage() {
    const accessToken = await AsyncStorage.getItem(ACCESS_TOKEN_STORAGE_KEY);

    if (!accessToken) {
      return;
    }

    await RNCookieManager.set(config.DOMAIN, JSON.parse(accessToken));
  }
}

That makes sense @perottilds thanks!
Appreciate the work on this @luancurti landing this.


i18n replacement and pluralization

This PR creates a new class to translate and also integrates pluralization for strings following a new format for them. Solves #1792 and #1187

@OlivierJaquemet Please check this PR and let me know your thoughts. For the translations you created I'll need them to follow the format specified in English and Spanish NOT translating the word plural, given that is the name of the filter I'm using to pluralize. Refer to the rules inside the i18n file but you'll need to provide up to 3 different strings concatenated with :. Let me know if you have any questions/concerns

Thanks for reviewing this. About the first item, I'll see how can I integrate the rules inside the t method, since your arguments are valid. The Wordpress part I'll remove it. I could integrate a fallback but I think it will be better to integrate this right at once; so if you can assist with this I'd appreciate it. Let me know your thoughts

Regarding the update of existing translation files to prevent use of a fallback : we do not have our own translators at Jalios, we rely on an external provider for this job. Because this service is quite expensive, but mainly due to the release cycle of our software, we only send the translation every 6/9 months or so. Unfortunately I already sent the previous strings to translation at the begining of the week... :( I'll see if I can request a modification with them and I'll keep you posted.
But you should really consider providing this fallback in the meantime...

@OlivierJaquemet I'll add the fallback for now and let me know when you have the new translation available so we conclude this. I'll keep you posted. Thanks

@OlivierJaquemet Changes in place; please review and let me know. @ocean90 can you review this as well, please?

@OlivierJaquement I noticed an issue with re Brazilian Portuguese translation; shouldn't it be exports[pt-BR] instead of exports.pt?

And also as a reminder you need to check which languages would need 3 strings once you send them for an update; all the ideographic languages like Chinese or Japanese won't need it. Russian, Polish, etc. will need 3 and the romantic languages 2. Any questions let me know

Brazilian portuguese should indeed follow all other translation format. see #1872
@odnamrataizem : you initially commited this pt-BR translation which is no longer up to date given the new strings that were introduced since your transalation. Could update your work starting from the english version please ?
@ron666 reminder regarding 3strings vs 2 duly noted.

@OlivierJaquemet  and @ocean90 I refactored the method following the conventions of PluginForm.jsm using semi-colon concatenated strings to determine proper plural, and added all the plural forms to have a complete set of translations. Please review and let me know your thoughts

As a last pass I'll add documentation in the event someone wants to create a translation file. @OlivierJaquemet any comments on this that could be useful for other contributors? @ocean90 I hope with this new way it's more conventional and doesn't disturb the current support to WordPress, any more comments about this PR?

No comment I can think of for the moment. Thanks again for your work.

@OlivierJaquemet Any comments on the approach of semi-colon strings, rather than using brackets? Do you think it is more standard this way?

@ron666  I had not seen this modification (my apologies ... too much work here, not much time to properly review :/)
If I understand correctly, you expect the whole message/sentence (and not just each parameter) to be proposed in several variations ?

this is definitely not a standard I had seen (but again, I'm not an expert in I18N and properly management plurals for ALL languages is still a work to do for our translations at Jalios...)
it completely prevents the use of several parameters should you want to display a message like Playlist contains {0,no videos|one video|{0} videos} and {1,no sounds|one sound|{1} sounds}.
for very long message, this adds a lot of duplicated text in the JS file

@OlivierJaquemet correct. The problem with that is that I saw on some languages is almost a completely new string and that in the long term would complicate things. Now, for the purposes of the player, and to maintain compatibility with WordPress, I think it's more likely to have something like the new approach and it won't be as confusing as the first approach I took. The highest number we can get is 6 translation (Arabic)

@ron666 I'm fine with it. And it will definitely be simpler for translators (that would otherwise have to learn and understand complex syntax). How to do you insert a semicolons if you need one to be displayed to the end user ? (The answer can be : you don't :p)

@OlivierJaquemet yeah you don't but if it's needed I can change it by using something more unusual (like ~ or #) or simply doubling the semi-colons (;;)

@OlivierJaquemet I will change the semi-colon separated string to an array so we can account for semi-colons as @ocean90 pointed out

@OlivierJaquemet and @ocean90 I changed this to arrays and it will be even more clear and we won't have to worry about punctuation signs. Let me know your thoughts

Arrays are good, thanks.
One missing bit : when messages are inserted as HTML or HTML attribute, some characters must be encoded (as HTML entities) to output valid HTML.
Two possibilities to address this :

encoding is integrated in the t function, eg t("R&D") --> R&D
another function wrapper is used each time t return value must be inserted in HTML encodeFor...(t("R&D"))

Obsviously, the first solution has the advantage of being applied globally to ensure proper encoding is never forgotten. the second solution allows for more use case (eg if I18N message but be printed in console, or any other plain text output), but they are probably not in use for now.

Thanks for pointing this. I'll add this later to complete this PR. Any other concerns? @ocean90 any thoughts or this is good to go once the HTML tags are escaped?

@OlivierJaquemet HTML escaping added. I'll wait for your final feedback as well as @ocean90 to merge this next week. Thanks.

Any objections if I merge this by tomorrow? I'm speeding this since this must be part of 3.0 and we are going to release it soon

It looks good to me.

@OlivierJaquemet  and @ocean90 thanks for your help


Transfer repo and rename to kubevirt-ipam-controller

This PR renames the org and repo
so we will adapt to the transfer under kubevirt/ipam-extensions.
It renames the controller to kubevirt-ipam-controller.
It also rename resources named controller-manager to manager
so once the prefix of kubevirt-ipam-controller- is added, it won't be
kubevirt-ipam-controller-controller-manager
Note: we will need please a new tag on the new repo, so we can use the new image location.

Cherry picked https://github.com/kubevirt/ipam-extensions/pull/31 here
and done the additional required changes

after the PR was merged, the e2e started to fail (on postsubmit and on new PRs)
fix is here https://github.com/ovn-org/ovn-kubernetes/pull/4475
(btw it is weird that it run it postsubmit, but this is other story)


Request for integration - ESPHome Light Component (RGBW)

Hello Dutchman,
i would like to ask for integration.
2021-03-01 15:53:06.241 - warn: esphome.0 (11603) DeviceType Light | State-Keys {"key":3048698813,"state":false,"brightness":1,"red":1,"green":1,"blue":1,"white":1,"colorTemperature":0,"effect":"None"} | [entityStateConfig] {"config":{"objectId":"quinled_quad","key":3048698813,"name":"QuinLED_Quad","uniqueId":"esphome_developer_qlquad_dev4lightquinled_quad","supportsBrightness":true,"supportsRgb":true,"supportsWhiteValue":true,"supportsColorTemperature":false,"minMireds":0,"maxMireds":0,"effectsList":["None","My Slow Random Effect","My Fast Random Effect","My Insane Random Effect","Totally loco","Strobe Effect With Custom Values"]},"name":"Light","type":"Light","unit":""}
Thanks
Mario

Implemented v0.1.1


Make SubmissionBox rounded

I'm beginning to experiment with Kass Yassin's re-skinning design for Metriq. Here are rounded SubmissionBox elements, from the CSS in his mockup:

He doesn't have the tabs bar, in his redesign on the homepage, and we might want to follow suit and totally remove it, but, for now, I wanted something that looked reasonably graphically matched to the rounded submission boxes.

By the way, here's some of the knock-down to other views, (because we designed this in a modular-enough manner):

New footer look:

@vprusso I want this on QA, so we can actually see it. Take a look there, please. (http://<IP_ADDRESS>/) It'd be great to have this for our IBM demo, but I can prep that very quickly, over the weekend, if we can't review this (on QA) in time.
So, any review feedback you have, or problems you notice, please go by what's on QA, once I merge this, and share that commentary here.


Add XML tag on SVGs in component updation

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

Codecov Report
Base: 16.62% // Head: 12.31% // Decreases project coverage by -4.30% :warning:

Coverage data is based on head (3132083) compared to base (c1f6461).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6901      +/-   ##
==========================================
- Coverage   16.62%   12.31%   -4.31%
==========================================
  Files         116      116
  Lines       15912    15912
==========================================
- Hits         2645     1960     -685
- Misses      12793    13639     +846
+ Partials      474      313     -161

Flag
Coverage Δ

gointegrationtests
?

unittests
12.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/start.go
1.57% <0.00%> (-54.58%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.51% <0.00%> (-53.79%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.00% <0.00%> (-46.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.73% <0.00%> (-43.48%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.97% <0.00%> (-43.05%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.66% <0.00%> (-42.67%)
:arrow_down:

mesheryctl/internal/cli/root/root.go
25.49% <0.00%> (-40.20%)
:arrow_down:

mesheryctl/internal/cli/root/version.go
0.00% <0.00%> (-34.24%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.00% <0.00%> (-24.25%)
:arrow_down:

mesheryctl/internal/cli/root/error.go
0.00% <0.00%> (-20.00%)
:arrow_down:

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Vs Code extension does not detect issues in json files

Describe the bug
The VS Code extension (but not .NET implementation) doesn't apply any rules to .json files (it appears to be any files with type application/json as other json based formats also don't work).
This isn't obvious because the default rules don't have any json rules.

This is fixed in the latest 0.8 alpha.


Error: Code: STG_E_INVALIDNAME == 0x800300FC

Hi!
I am recovering individual items from Office 365 using Windows 10, Office 2013 and the latest version MFCMapi.exe.16.0.16319.01 that I've downloaded today from your website.
For some objects, I get the following 3 errors that I have to manually acknowledge by clicking OK (3 times).
It very much seems like there is an issue with parsing the subject and generating the .msg filename, i.e. invalid characters; or filepath is too long?
I managed to reduce the amount of errors by exporting to C:\1\ instead of to my Desktop under C:\Users\raoul\Desktop\export\
Error:
Code: STG_E_INVALIDNAME == 0x800300FC
Function MyStgCreateStorageEx( szFileName, STGM_READWRITE | STGM_TRANSACTED | STGM_CREATE, STGFMT_DOCFILE, 0, &myOpts, nullptr, __uuidof(IStorage), reinterpret_cast<LPVOID*>(&pStorage))
File File.cpp
Line 600

Error:
Code: STG_E_INVALIDNAME == 0x800300FC
Function CreateNewMSG(szFileName, bUnicode, &pIMsg, &pStorage)
File File.cpp
Line 650

Error:
Code: STG_E_INVALIDNAME == 0x800300FC
Function SaveToMSG( lpMessage, szFileName.c_str(), bUnicode, hWnd, false)
File File.cpp
Line 454

When prompted for the name of the file to use, I assume you're accepting the default - could you copy it out and paste it here so we can see the file name that got generated?

Thanks @stephenegriffin for your quick reply.
I did not try to recover individual files, but tried to recover all items:

Logon to the outlook account (Office 365 in my case)
Open the store (double click)
Go to Root Container / Recoverable Items / Purges
Right click -> Export folder -> As MSG files...
Uncheck "Save associated items" and "Save as Unicode MSG" (unchecked is the default for both)
Choose a folder to export to and wait.

In my case, I was dealing with >10000 deleted emails (IPM.Note) and 15500 overall deleted items (incl. IPM.File, IPM.File.Document, IPM.Schedule.Meeting....., IPM.Contact)

Ew - so were you not able to identify which message caused the problem?
MFCMAPI has logging - you could turn on logging before you do the export - I think that'll log out the subject of the exported message.

@stephenegriffin sorry, I moved all the messages back to a folder that is accessible via Outlook.
Therefore, I cannot reproduce this as of now.
Also, logging does not seem to be enabled by default?
Anyways, my suggestion would be to please add some kind of debug-information in a pop-up-ish dialog in case such an error is triggered. This should then help with debugging.
Also, one could add some information that i.e. the PATH of the folder where messages are saved to also plays a role here - that the overall path+filename length is limited to something around 256 in Windows.
What do you think?

The problem is there are over 400 functions wrapped in the error macro that results in that particular dialog. There's no general purpose solution I could implement - I need to hand tune an error dialog for this particular scenario. And since I don't have a repro for the scenario, anything I write there is a potential time bomb. I'll see if I can hack out a repro and fix the underlying bug. In the meantime, no, debug logging is not on by default - it would fill your drive. But it's easy to turn on and it would definitely have the path information in it.


Add support for Platform.OS

Description
The goal of this issue is to add support for Platform.OS = 'visionos'.
The work might require writing a custom metro resolver.

Update from my work in this area:
Managed to add support for visionos as a new platform (similar to macos). It revealed that we either need to convert/bridge existing .ios.js files to visionos.js or add a fallback platform. Tried the fallback platform solution by customizing reactNativePlatformResolver:
https://github.com/callstack/react-native-visionos/blob/ca6ac0a461579f4e6dc0781150541c66aa048ef1/packages/community-cli-plugin/src/utils/metroPlatformResolver.js#L28-L44
to accept
platformImplementations: {
  [platform: string]: [string, string | undefined],
}

as an argument, where the tuple would read as [platform = "visionos", basePlatform = "ios"]. This way I tricked Metro into resolving ios extensions as fallbacks, however this revealed another issue with Platform.OS being visionos, while internally we have lots of Platform.OS === "ios" calls. Which we would either need to augment with visionos checks (as tried here by @okwasniewski: https://github.com/callstack/react-native-visionos/pull/2/commits/e5b83e0dc7be12dd889ad5eaf7b39d74d8d3a17f) or entirely replace. Which adds maintenance overhead for an out-of-tree platform like this. Even then, for React Native VisionOS, which largely shares the same code with React Native iOS, it would mean we wouldn't be able to use most of the community iOS native packages, unless contributing extra platform checks. That's not scalable.
As a potential followup, I'm going to explore extending Platform primitive with a new "variant" concept. Variant would serve as an extension for the base platform. visionos would be variant of ios. tvos would be variant of ios. Maybe even macos could be variant of ios, but that's debatable. Adding variant support would likely mean either hacking around Platform concept between Metro and RN for iOS. Or extending Metro with this concept.

This feature won't be supported out of the box. There is metro-resolver-platform-variants package created by @douglowder that allows to achieve this.