fix: data race in EachDBNodes

There are two data races in EachDBNodes:

the write of err is a data race and could cause a crash when reading the error.
the read/write of hasErr is a data race, though I don't think it will cause severe issues, its usage does not make much sense in a concurrent program.

other minor improvements:

don't log "retry execute command" before timeout
refactor to EachDBNodes and IsRetryErrorForPtView

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B
[ ] Test cases to be added
[ ] No code

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@fx408 review required, please

tks @localvar


[Bug Fix] Fix Incremental Query Id Issues in Multiple Frontend

What do these changes do?
as titled.

Related issue number

Fixes #2974

Codecov Report

Merging #3026 (ce6777e) into main (c1df6f2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3026   +/-   ##
=======================================
  Coverage   42.62%   42.62%
=======================================
  Files          99       99
  Lines       10685    10685
=======================================
  Hits         4555     4555
  Misses       6130     6130

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4131d...ce6777e. Read the comment docs.


Consider a compound index on user ID field to speed up gallery queries

We recently indexed street ID in the database, which sped up the lookup speed of the street immensely.
Currently the biggest performance hit comes from looking up the user's gallery, with an average time of 18.5s. This query:
get /api/v1/users/:user_id/streets

suggests that we might see a similar boost by indexing on the user_id field.

18.5s is a very long time. +1 for testing this change to see if it makes a significant impact.

I tested this locally just now. It loads the gallery faster than it can animate into place (although I guess locally, latency is not a factor!)

~18s to about 60ms!


Edge Artifacts present on speed 2 but not on speed 3

Reported via IRC:
<Guest67> soichiro: I just noticed that I get strange artifacts with speed 2 that don't appear with speed 3 (red flickering line on the right edge of blue frames). I'm using the lastest git.
<soichiro> Blue frames specifically? That seems very odd. Would you mind filing an issue on the Github repo, preferably with a test clip if you can
<Guest67> I don't think it's specific to blue frames
<Guest67> But my uncommonly sized video (1788x1080) has blue frames with artifacts
<Guest67> https://upload.disroot.org/r/DhdDGxuf#4DBfgG751sPRFyJ7tHFNdyP9XTL7bjzSUebY8cxXcpE=
<Guest67> Here's a test clip (artifacts start at frame 17)

Clickable test clip

I wonder if Guest67 could come around and upload a link to the source they used for this clip. I tried it with my own source for the same scene, but wasn't able to replicate it with speeds 1-4.

Test clip is no longer available on Disroot server
Error: the file existed but was deleted.

I recall the source was the title screens from A Clockwork Orange. Although as mentioned, I was only able to reproduce it with the version the original reporter posted, I was not able to reproduce it when using my own copy of the bluray. Sadly it does look like all the disroot links are dead and I no longer seem to have a copy.

https://people.xiph.org/~mindfreeze/rav1e_2912_sample.ivf
I found it in my PC


base image: upgrade to ubi9

bcc and gobpf need to be upgraded

ubi9 has both clang 15 and 16. That seems to cause kepler to hit this issue:
CommandLine Error: Option 'mc-relax-all' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

While my RHEL 9 system has only clang 15, so it is not a problem for my setup.
Investigating now.

@rootfs was the issue fixed?


zsh: fix basic completion

compctl -k is expecting an array of possible completions. To get a
better completion for free, we could also use the bash completion
directly.
Another PR will come with this solution.

Thank you.


Fixed typo

Changed 'fund' in 'A good writer can put a fund' to 'fun'.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Fixed one typo from' fund' to 'fun'.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.


changed to fxmanifest.lua

Please stop using old __resource.lua

please stop making tiny patches for code that has been unmaintained for 4 years.


Update README

I think this is too little information for the top level README. I am pretty comfortable with the length and verbosity of what we've got.

@DanGiaime Are you going to add to this?

@DanGiaime I am going to close this if this is stale

Had my notifications set up wrong :(
Will update within the next two days.


Deeply nested queries not working

Trying to query works.boq.id (or any other field at that level) returns no results
db.search({
query: '1001',
fields: ['works.boq.id'],
include_docs: true
}).then(function(docs){
console.log(docs);
   });

Here's the json:
{"_id": "13bfce01-02ac-3994-bb1c-f90aa18ffc1c",
"_rev": "1-c989370c0b10d24b83a7c32d4200cf9d",
"id": 2,
"type": "contract",
"contract_name": "Enterprise-wide methodical infrastructure",
"ref": "578",
"address_1": "1202",
"address_2": "Taryn Ranch",
"address_3": "",
"address_4": "",
"town": "Stephaniemouth",
"county": "Massachusetts",
"postcode": "13032-0620",
"country": "Kyrgyz Republic",
"created_at": null,
"updated_at": null,
"deleted_at": null,
"works": [
{
"id": 101,
"_id": "bedfb0a8-fe0f-3993-9447-4317d0a73364",
"type": "works_instruction",
"contract_id": 2,
"scope_of_works": "Proactive discrete task-force",
"created_at": null,
"updated_at": null,
"deleted_at": null,
"boq": [
{
"id": 1001,
"_id": "ca9d7ab8-768e-3483-9480-6c0c756a6900",
"type": "boq_item",
"works_instruction_id": 101,
"item_name": "Compatible secondary toolset",
"quantity": 1,
"unit": "No.",
"rate": 311.3,
"total": 311.3,
"created_at": null,
"updated_at": null,
"deleted_at": null
},
},
}

Hello @tomgosling2017 this work only for deeply nested objects, in your case works and boq are arrays. Something like that works:

var document = {
  _id: 'mydoc',
  "type": "contract",
  "contract_name": "Enterprise-wide methodical infrastructure",
  "ref": "578",
  "address_1": "1202",
  "address_2": "Taryn Ranch",
  "address_3": "",
  "address_4": "",
  "town": "Stephaniemouth",
  "county": "Massachusetts",
  "postcode": "13032-0620",
  "country": "Kyrgyz Republic",
  "created_at": null,
  "updated_at": null,
  "deleted_at": null,
  "work": {
    "id": 101,
    "_id": "bedfb0a8-fe0f-3993-9447-4317d0a73364",
    "type": "works_instruction",
    "contract_id": 2,
    "scope_of_works": "Proactive discrete task-force",
    "created_at": null,
    "updated_at": null,
    "deleted_at": null,
    "boq": {
      "id": 1001,
      "_id": "ca9d7ab8-768e-3483-9480-6c0c756a6900",
      "type": "boq_item",
      "works_instruction_id": 101,
      "item_name": "Compatible secondary toolset",
      "quantity": 1,
      "unit": "No.",
      "rate": 311.3,
      "total": 311.3,
      "created_at": null,
      "updated_at": null,
      "deleted_at": null
    },
  },
}

DB.put(document).then(function (res) {

  DB.search({
    query: '1001',
    fields: ['work.boq.id'],
    include_docs: true,
  }).then(res => console.log(res.rows))

})


Fix GlobalHeader for latest SLDS

Fixes https://github.com/salesforce/design-system-react/issues/1416
Additional description
This changes the GlobalHeader component inline with recent SLDS changes
Pull Request Review checklist (do not remove)

[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Thanks @johnbeynon !


InteractionManager crash when cancelling promise task before it completes

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
react-native 0.47.2
Steps to Reproduce

Schedule a long-running promise task with InteractionManager.runAfterInteractions

    const promise = InteractionManager.runAfterInteractions({
      gen: () => {
        // do a long fetch and return a promise
      }
    });

After the task has started but before it is done, cancel the task

    promise.cancel()

When the task completes TaskQueue will throw an exception

    TaskQueue: Error resolving Promise in task undefined: undefined is not an object (evaluating '_this2._queueStack[stackIdx].popable = true')

Expected Behavior
No error would be thrown. InteractionManager (TaskQueue) would ignore the completion of a cancelled task and start the next task.
Actual Behavior
Error was thrown from TaskQueue line 158:
iOS: TaskQueue: Error resolving Promise in task undefined: undefined is not an object (evaluating '_this2._queueStack[stackIdx].popable = true')
Android: TaskQueue: Error resolving Promise in task undefined: Attempted to assign to readonly property.
Reproducible Demo
https://snack.expo.io/HJivJZ33-

@sahrens It looks like you've worked on this code the most. Any thoughts on this issue?
My use case is starting a task in componentDidMount and canceling it in componentWillUnmount. If the cancel comes after the task is started, it throws this error.


Types of changes

[ ] New feature
[ ] Bug fix
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Performance improvement
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context

Solution

How is the change tested?

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Checklist:

[ ] Test suite passes (npm run test)
[ ] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[ ] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

这个为啥要回退呢

这个为啥要回退呢

有点问题，之后重新上


Memory leak in SearchResults

Description
If the tools that use MonacoEditor are not displayed beforehand, they will consume more memory.
Once all the tools are displayed, the memory consumption will slow down.
Steps To Reproduce

Start DevToys.
Enter text into the tool's search (e.g. 0).
Press the Enter key several times.

Expected behavior
Data used in the search is referenced only once.
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | b972462 | b972462
Relevant Assets/Logs

@btiteux,
I investigated the bug and I think I have gone to the bottom of it. Here is what I found:

When we type a query in the search box and press [Enter], we navigate to a page by calling this method:
https://github.com/veler/DevToys/blob/aa8624afee5e55de1506d41180506d7ec59d64c8/src/dev/impl/DevToys/ViewModels/MainPageViewModel.cs#L440-L483
In this method, we change the selected item in the NavigationView and notify that the SelectedMenuItem property changed, so the NavigationView update with the selected item: https://github.com/veler/DevToys/blob/aa8624afee5e55de1506d41180506d7ec59d64c8/src/dev/impl/DevToys/ViewModels/MainPageViewModel.cs#L472-L472
By raising this property, some properties of MatchedToolProvider are being get because they're binded to some NavigationViewItem: https://github.com/veler/DevToys/blob/aa8624afee5e55de1506d41180506d7ec59d64c8/src/dev/impl/DevToys/Api/Tools/MatchedToolProvider.cs#L18-L153
Now here is the weirdness:

When all the groups in NavigationView are expanded, MatchedToolProvider.Icon is not called.
When all the groups in NavigationView are collapsed, MatchedToolProvider.Icon is called for each hidden item.
The impact of this is that we load some SVG, Font Glyph...etc. This is what allocates memory, and this is what explains the memory leak.

The proper fix in long term, in my opinion, is to continue our work on making all the tools icons a font. It likely cost less than our routine for loading the SVGs.
Additionally, we might need to open an issue on WinUI repository because it's quite obscur to me that this property is being called in this scenario.

I was also looking at this issue and I found another problem here:
https://github.com/veler/DevToys/blob/aa8624afee5e55de1506d41180506d7ec59d64c8/src/dev/impl/DevToys/Core/ToolProviderFactory.cs#L38-L49
This caching is not working correctly. It seems like every time you start a new search, a new IToolProvider instance is created and passed to this method. When it tries to look for a match inside the dictionary, it never finds an usable ViewModel as the comparison is made by reference, hence the cache dictionary begins to fill with repeated ViewModels.
This only happens with SearchResultToolProvider, the other providers does not have this problem. I am not sure why...

Good catch @youkai95 ! I just fixed it on my machine but it doesn't address the memory issue.


Gracefully handle playbook generation and explanation not available

This PR moves the generic handling of error code's from the backend service in to the Language Server.
Exceptions thrown by the Language Server are handled by JSON-RPC and converted into messages following a standard format.
We, however, want to preserve the code from the backend service and show meaningful messages to users.
The response from the Language Server is now always considered to be successful to avoid JSON-RPC handling exceptions but the payload represents either success or failure state. This is comparable to how shell scripting, C etc and Go handle exceptions: The function calls always succeed however the result may indicate success (rc=0) or failure (rc>0) states.

Hi @ssbarnea @TamiTakamiya @goneri
I wonder if you can advise... when running
task build
task package
task test

The changes I've made moving a utility function from the extension to LSP are not found and the extension shows an error message:

Activating extension 'redhat.ansible' failed: Cannot find module '@ansible/ansible-language-server/src/utils/handleApiError'
Require stack:

/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/client/src/features/lightspeed/api.js
/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/client/src/features/lightspeed/base.js
/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/client/src/extension.js
/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/test-resources/VSCode-linux-x64/resources/app/out/vs/loader.js
/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/test-resources/VSCode-linux-x64/resources/app/out/bootstrap-amd.js
/home/manstis/workspaces/git/manstis/forks/vscode-ansible/out/test-resources/VSCode-linux-x64/resources/app/out/bootstrap-fork.js.

However if I install the .vsix built everything runs fine.
Is there some magic I need to perform (especially for this PR?)

I will run test on my machine.  I guess the failure occurred in "E2E" test, i.e. even though
yarn als-compile
yarn compile
yarn webpack-dev
yarn package
yarn coverage-ui-with-mock-lightspeed-server

passes,
yarn als-compile
yarn compile
yarn webpack-dev
yarn package
yarn coverage-all

fails.  Let me try it on my machine.

Yes, yarn coverage-all failed after yarn package
   :
Error: Cannot find module '@ansible/ansible-language-server/src/utils/handleApiError'
Require stack:
- /home/ttakamiy/git/ansible/vscode-ansible/out/client/src/features/lightspeed/api.js
- /home/ttakamiy/git/ansible/vscode-ansible/out/client/src/features/lightspeed/base.js
- /home/ttakamiy/git/ansible/vscode-ansible/out/client/src/extension.js
  :

ansible-language-server (ALS) runs in a separate process (previously it was in a separate repository).  When we package it in a .vsix file, we stores ALS files under out/server and configure the server uses the files in that directory.  So originally it was not designed to share files in ALS in VS Code extension.
When we package .vsix file, we run webpack and it resolves dependencies and creates bundled js files.  On client (VS Code extension) part, it is provided as extension.js file.  I believe that bundled extension.js contains the handleApiError.js. So it works with .vsix.
To resolve this isssue, I think we can create a js file, which is webpacked even when E2E test is running like what I did for "SyntaxHighlighter", which is used for Playbook Generation. I will describe it later (after standup).

To resolve this isssue, I think we can create a js file, which is webpacked even when E2E test is running like what I did for "SyntaxHighlighter", which is used for Playbook Generation. I will describe it later (after standup).

In webpack.config.ts, I added a new entry:
  syntaxHighlighter: "./src/features/utils/syntaxHighlighter.ts",

We define output location as
"[name]/src/[name].js"

so yarn webpack or yarn webpack-dev will generate the bundled js as out/syntaxHighlighter/src/syntaxHighlighter.js
src/features/lightspeed/playbookGeneration.ts has the following ugly code to load syntaxHighlighter.js:
        // eslint-disable-next-line @typescript-eslint/no-explicit-any
        let syntaxHighlighter: any;
        try {
          syntaxHighlighter =
            await require(/* webpackIgnore: true */ "../../syntaxHighlighter/src/syntaxHighlighter");
        } catch (error) {
          syntaxHighlighter =
            await require(/* webpackIgnore: true */ "../../../../syntaxHighlighter/src/syntaxHighlighter");
        }

In the production env, the dynamic loading occurs from (bundled) src/extension.js. That's why I need to have two dynamic import calls...
So if we do

Add an entry to webpack.config.ts
Statically link the entry to handleApiError.js
Dynamically link the webpacked js where it is needed

it should work... but it may be too much for this...
For this case, simply creating a symlink might work.  Let me try that approach.

@manstis Still trying to find a better solution... For running E2E test, we are using "testRunner", which is descrbed here.  If the testRunner could resolve the dependencies, we do not have to change the runtime code because .vsix runs w/o issues. I think there should be a way to specify additional path and checking the doc.

@mantis  THIS is my atttempt to fix this with a webpacked js. Since it's too ugly, I will spend some more time on searching better solutions after fixing the Playbook Explanation issues with task files/role-based playbooks.

@manstis I have simplified my test fix. Would you take a look?

@manstis thank you Michael!


Clean up DROP DATABASE documentation

Closes #486

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/1db751418764dd4efab0e1f46fb91cfeab6e6c00/

@Amruta-Ranade, the restructuring looks good, but there's a little but of expanding to do as well, I just realized. As the intro says, DROP DATABASE drops a database and all its objects. That second part is missing from the diagram and from the documentation. Based on the full grammar, there should be an opt_drop_behavior at the end. When that's inlined, that turns into two options, CASCADE and RESTRICT. These options are available in the DROP TABLE docs as well, so it's probably good to go and read about them there first.
Then you'll want to:

Rest out how those options work in the SQL shell.
Rework the diagram to show those options.
Add them to the parameters list.
Cover them in the examples.

I assume that deleting all dependent objects of a database means deleting all tables in the database, all indexes on those tables, and all views depending on any of those tables, but you'll need to test things out to confirm. Also, feel free to ask CockroachDB devs questions in Gitter. @dt might be a good first contact.

@jseldess I checked the full grammar for drop statements, and it appears that opt_drop_behavior is only for dropping tables and indexes, not databases. I tested the drop database commands using the Cascade and Restrict options, but an error was displayed. The options worked perfectly for dropping tables though. So I think opt_drop_behavior does not apply to the drop database command. I will cross-check with the CockroachDB devs on Gitter.

I think you're right, @Amruta-Ranade. I just created a database, created a table inside it, and then created a view dependent on that table. Despite those objects, I was able to drop the datase without CASCADE:
root@:26257/> create table test.test (a int primary key);
CREATE TABLE
root@:26257/> create view test.test_view as select a from test.test;
CREATE VIEW
root@:26257/> drop database test;
DROP DATABASE

So I think you're right that those options aren't relevant. What this tells us, though, is that we need a clear warning, something like the one here https://www.cockroachlabs.com/docs/drop-table.html#remove-a-table-and-dependent-objects-with-cascade.

Yes, I agree. Will work on that.

@jseldess I checked the drop table warning again. The warning is for dropping dependent objects when using the cascade option. The dependent objects refer to other tables in the database who might be dependent on the table being dropped, hence the warning is required to make the user aware that dependent tables will be dropped as well. We are not recommending that the users drop the columns or other objects within the table being dropped.
In case of the drop database, there seems to be no scenario where other databases are dependent on the dropped database. And I don't think we recommend the users drop the individual tables before dropping the database. Hence the warning might not be applicable for the drop database documentation. Please let me know what you think.

@Amruta-Ranade, sorry for the delay. You're right that the situation is a bit different than dropping a table. But I do think we should add a simple warning stating that dropping a database will drop all tables and views within the db. We don't want users doing that accidentally.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/aa865626240f026d5d427d01e7a8f99d9fed2674/

Thanks, @Amruta-Ranade. Looks great. I'll merge.


Patch release 3.5.2

@RedHatProductSecurity/osidb-devs , any idea about the failing test?

@skontar probably a new version of bandit (seems like 1.7.6 and the bandit repo seems to have reverted/deleted the release), could you pin it in tox.ini to 1.7.5?


[Bug]: Installed new create app can't start dev

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
App
Expected behavior
The dev server should have started per the instructions stated in the instructions
📁~/site/shopify ➜ yarn create @shopify/app
yarn create v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Installed "<EMAIL_ADDRESS>with binaries:
      - create-app

Welcome. Let’s get started by naming your app. You can change it later.
✔ Your app's name? · test-cli3
✔ Which template would you like to use? · node
✔ Template downloaded
✔ App initialized
  ✔ Liquid parsed
  ✔ Updated package.json
✔ Dependencies installed with yarn
  ✔ Installed dependencies in /
  ✔ Installed dependencies in /web/
  ✔ Installed dependencies in /web/frontend/
✔ Completed clean up
✔ Git repository initialized

  test-cli3 is ready for you to build! Remember to cd test-cli3
  To preview your project, run yarn dev
  To add extensions, run yarn scaffold extension
  For more details on all that you can build, see the docs: shopify.dev (https://shopify.dev) ✨

  For help and a list of commands, enter yarn shopify app --help

Done in 107.02s.

Actual behavior
Dev server failed to start
 📁test-cli3 ⬢ v16.13.0 took 6s ➜ yarn dev
yarn run v1.22.17
$ shopify app dev
✔ Dependencies installed

━━━━━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    libsecret-1.so.0: cannot open shared object file: No such file or directory

    Stack trace:    at node         node:internal/modules/cjs/loader:1183

    at load         node:internal/modules/cjs/loader:981
    at _load        node:internal/modules/cjs/loader:822
    at require      node:internal/modules/cjs/loader:1005
    at require      node:internal/modules/cjs/helpers:102
    at <anonymous>  keytar/lib/keytar.js:1                 var keytar = require('../build/Release/keytar.node')
    at _compile     node:internal/modules/cjs/loader:1101
    at js           node:internal/modules/cjs/loader:1153
    at load         node:internal/modules/cjs/loader:981
    at _load        node:internal/modules/cjs/loader:822

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Stack trace
━━━━━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    libsecret-1.so.0: cannot open shared object file: No such file or directory

    Stack trace:    at node         node:internal/modules/cjs/loader:1183

    at load         node:internal/modules/cjs/loader:981
    at _load        node:internal/modules/cjs/loader:822
    at require      node:internal/modules/cjs/loader:1005
    at require      node:internal/modules/cjs/helpers:102
    at <anonymous>  keytar/lib/keytar.js:1                 var keytar = require('../build/Release/keytar.node')
    at _compile     node:internal/modules/cjs/loader:1101
    at js           node:internal/modules/cjs/loader:1153
    at load         node:internal/modules/cjs/loader:981
    at _load        node:internal/modules/cjs/loader:822

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Reproduction steps

yarn create @shopify/app
cd test-cli3
yarn dev

Operating System
Windows Linux Subsystem Ubuntu 20.4
Shopify CLI version (check your project's package.json if you're not sure)
3.0.24
Shell
zsh
Node version (run node -v if you're not sure)
16.13.0
What language and version are you using in your application?
Node 16.13.0

Thanks for creating the issue! We are working on it, sorry for the inconvenience.

Hey @gonzaloriestra. I think this might be related, although it's not a direct issue with Shopify's CLI. Just commenting this here for awareness.
I also couldn't start the dev build from a newly created app. Steps were exactly the same, except using npm.
This issue happened because npm gave me precompiled node addons, even though they didn't match my machine's architecture. In particular, keytar and sqlite3 were giving me x86 binaries instead of arm ones.
I'm running macOS v12.3.1/Monterey with the new Apple silicon (M1), and as usual this is the root cause..
Error 1: npm run dev fails
━━━━━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    dlopen(~/test-cli3/node_modules/keytar/build/Release/keytar.node, 0x0001): tried: '~/test-cli3/node_modules/keytar/build/Release/keytar.node' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64e'))

    Stack trace:    at node         node:internal/modules/cjs/loader:1196
    at load         node:internal/modules/cjs/loader:988
    at _load        node:internal/modules/cjs/loader:834
    at require      node:internal/modules/cjs/loader:1012
    at require      node:internal/modules/cjs/helpers:102
    at <anonymous>  keytar/lib/keytar.js:1                 var keytar = require('../build/Release/keytar.node')
    at _compile     node:internal/modules/cjs/loader:1112
    at js           node:internal/modules/cjs/loader:1166
    at load         node:internal/modules/cjs/loader:988
    at _load        node:internal/modules/cjs/loader:834

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Workaround - recompile keytar
From the initialised app directory:

Make sure node-gyp is installed
cd node_modules/keytar
node-gyp configure --arch=<target architecture here>

For M1 chips, node-gyp configure --arch=arm64

node-gyp build

npm run dev should work after this.
Error 2: Node server crashes immediately on deployment
backend    | node:internal/modules/cjs/loader:946
backend    |   const err = new Error(message);
backend    |               ^
backend    |
backend    | Error: Cannot find module '~/test-cli3/web/node_modules/sqlite3/lib/binding/napi-v6-darwin-unknown-arm64/node_sqlite3.node'

Workaround - recompile sqlite3
From the initialised app directory:

Make sure node-pre-gyp is installed (sqlite3's build process depends on node-pre-gyp rather than node-gyp)
cd web/node_modules/sqlite3
node-pre-gyp configure --arch=<target architecture here>

For M1 chips, node-pre-gyp configure --arch=arm64

node-pre-gyp build

After those steps everything was fine.

Thanks @jeannly for your comment. I ran into the same issue running npm on MacOS Monterey 12.2, zsh, node 16.15.0.
In my case I was able to get npm run dev to work after just the first workaround, re-building keytar in arm64 architecture.
I did not need to recompile sqlite3.

As a workaround for linux users, installing libsecret should solve this issue:

Debian/Ubuntu: sudo apt-get install libsecret-1-dev
Red Hat-based: sudo yum install libsecret-devel
Arch Linux: sudo pacman -S libsecret

gnome-keyring is also required.


chore: update gleap

Description
Bumps gleap, gleap appears to be working fine on dev
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

:tada: This PR is included in version 1.477.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Vertical actions

Can we put actions vertically?
Like an HTML Notification:

Did you already make this or can i tackle this?


implement threefold data rest api

Add restapi for threefold_data.
Todo

[ ] add this yaml library to install scripts (or clone manually to ~/.vmodules/yaml or install like v install --git https://github.com/jdonnerstag/vlang-yaml)
[ ] replace image/logo and related fields with full URL (instead of the relative one)
[ ] support publishtools macros in the blog content
[ ] update/add docs for all endpoints and supported features (add README.md to publishtools ore publishtools/rest directory and to publishtools manual)

Suggestion
To make it easy to apply macros and processing of wiki sites to blog content, we can add this threefold_data as a wiki site configured in current publishtools by default, with constant name of e.g threefold_data, it will get processed and we can just replace links in returned metadata to link to correct documents (content) and images in this wiki site.
This way, we can serve images from wiki site of threefold_data, also the processed documents too.

What is the status here? I see this PR is very old. Do we still need it? If so can you work on it. If not lets remove the branch.

i've rebased on it on our latest code to see changes


[MAJOR] Add extensive test plan system with customized test plan syntax

The PySOA Test Plan system allows for writing streamlined action-testing test plans, fixtures, and test cases to make testing your services easier. It comes with a base class for all test plans, a parser for the syntax, a PyTest plugin, and an extensive set of sytax directives meeting most needs. Our internal SOA system will add more directives for handling our proprietary auth tokens, and users are encouraged to do the same for their services.

Awesome job porting a large code base.  Some questions:

The  doc generator will always be complete unless other modules that provide grammar plugins are also installed and present.  How is this intended to be used?

Speaking of the other modules, have any of those been ported/tested under the new structure (The django model and gargoyle ones are probably critical and complicated).

Are there any aids to the conversion of old soa test plans to pysoa test plans?


Browser hangs when dot entered between numbers with "decimal" mask

Confige mask: $('#id_totalLandArea').inputmask("decimal");
Then, 1. enter to the input field "33"
2. place cursor between "3" and "3"
3. enter "." -> browser hangs with 100% cpu.
Reproducible on this example http://jsfiddle.net/scottned/8Jpdd/4/
Tested in IE 11 and Chrome 42

Duplicate https://github.com/RobinHerbots/jquery.inputmask/issues/870


Default Adapter

I experience a lot of problems with the default adapter and would like to suggest switching the default to Hackey, as it seems to provide the most stable experience out the box.

Hi,
What issues are you experiencing? The advantage to having httpc as the default adapter is that it is build-in into OTP and does not require any additional dependencies.

Hackney is full of issues, timeouts, crashes, ...  IMHO the point of Tesla is to get rid of hackney.

The point of Tesla is not to get rid of hackney, nor any other http adapter. The point is to let the end use choose the adapter that suits best or write a custom one if needed.

@ourway What do you propose to use instead then?

@jtomaszewski Erlang' default httpc


Update train.py to support subsampling the dataset

Add parameters 'train_subsampling_ratio' and 'eval_subsampling_ratio' to obtain a subset of dataset

Hi, Jingfeng. Could you give me a brief explanation of the meaning of introducing this function?

Sure! This function allows users to obtain a subset of a dataset. Using a subset of a dataset in machine learning reduces computation time, enables efficient prototyping, and helps identify data issues early. This approach streamlines model development and debugging before scaling up to the full dataset. For a detailed explanation, refer to this article: link. Thanks!

Hi, Jingfeng. Could you give me a brief explanation of the meaning of introducing this function?

Sure! This function allows users to obtain a subset of a dataset. Using a subset of a dataset in machine learning reduces computation time, enables efficient prototyping, and helps identify data issues early. This approach streamlines model development and debugging before scaling up to the full dataset. For a detailed explanation, refer to this article: link. Thanks!

Thanks for your suggestions! I will submit another pull request for enhancing this function.

Welcome, and thank you for being one of Pointcept's contributors.


Is it possible to extract the scene graphs ?

Hi,
I want to know if it is possible to extract the scene graphs generated by this framework, and if so, how can I do it ?

Not something we support. Feel free to start a discussion in https://github.com/facebookresearch/habitat-lab/discussions to see if you or something else in the community wants to build this.


weaken some context bounds

That OAuthSuite compilation error snuck through CI.  Merging/rebasing series/0.22 should make it go away.
I am surprised this is binary compatible?
It also reminds me of https://github.com/http4s/http4s/pull/2325, an argument that I haven't managed to rehydrate into my brain yet this morning.

@rossabaker oh wow, sorry I did not see breaking test.  Thanks for resolving it.

I am surprised this is binary compatible?

I think changing a parameter type to a supertype is always binary compatible, no?

It also reminds me of #2325, an argument that I haven't managed to rehydrate into my brain yet this morning.

Looks like this is just clearing up loose ends from https://github.com/http4s/http4s/pull/2906.

Oh, looks like this is failing on mima for Scala 2.
Also looks like mima isn't checking anything for Scala 3 - is this intended?

oh wow, sorry I did not see breaking OAuthSuite test

No worries.  I probably merged something that hadn't passed CI.  That's on me.

I think changing a parameter type to a supertype is always binary compatible, no?

It's source compatible, but not binary compatible.  Adding this takes care of the "method apply" error, but not the "static method apply" error.
  @deprecated("Preserved for binary compatibility", "0.22.4")
  protected[HttpApp] def apply[F[_]](run: Request[F] => F[Response[F]])(implicit F: Sync[F]): HttpApp[F] =
    Http(run)(F: Defer[F])

I think that static forwarder is only used in non-Java interop.  I don't love making exceptions, but that one is probably okay?  We should be able to test the general case by compiling an app on http4s-0.22.3, and running against a snapshot built with this.  I think it will fail without the above method, and succeed with.

I don't think so.  It needs to be public, and when it becomes public, we run into an ambiguous overload.
I knew this problem was familiar: https://github.com/typelevel/cats-effect/pull/584

If we're going to tackle this, we probably want to loosen constraints here too.
https://github.com/http4s/http4s/blob/series/0.22/core/src/main/scala/org/http4s/syntax/KleisliSyntax.scala#L55
I think F needs Functor and G needs Defer, neither need Sync.
I think those should be easier since we can just deprecate KleisliHttpAppOps and add a replacement class.

Some of the other syntax classes might need similar treatment, I've not checked yet.

If we want to be bincompat purists:

If we want to be bincompat purists:

Add defer and localDefer alongside apply and local with the constraints we want.
Scaladoc on apply and defer why those other ones are better.
On main, fix apply and local and deprecate local and localDefer.

It gives people a path on 0.22 and 0.23 without violating any traditional bincompat guarantees.  But it's more work for people who adopt the better ones on 0.22 and 0.23 as they move to 1.0, all to support a hypothetical Java interop that probably nobody does.

But it's more work for people who adopt the better ones on 0.22 and 0.23 as they move to 1.0, all to support a hypothetical Java interop that probably nobody does.

Yeah I get that. I'll defer (pun intended) to whatever you think is best here.

I'm truly on the fence.  My inner pragmatist is yelling "just break bincompat!" and my scars are reminding me "almost every time you break bincompat, something unexpected bites you in the ass."  I'm still hoping someone has a workaround the rest of us haven't seen.

How about just explicitly saying bincompat isn't guaranteed for Java interop?

Let's proceed.  If a Java user stumbles into this, I'll point them to the changelog, and then feel bad, and look at bytecode postprocessing options.

Looks like the only thing we have to do here is add the MiMa exceptions.

I didn't realize this changes again in 0.23 until I hit a merge conflict.


HDR - high quality photo for camera

been using the library in test app for a while, am noticing on samsung phone , the quality doesnt match the phone capability , during onTake photo ,image is clear but on preview ,it at a lower resolution than expected always using lower resolution
Would appreciate any help. Thank You.

Hi here is the some explanations: #25, #5. Ratio is calculated based on media quality(photo, video) and preview View size, that's why photo will be in requested quality but preview size tries to keep best aspect ratio, and can be different from the requested media quality. Well I know its not the solution, but since I have many such requests I will try to implement some solution for it asap.


Bluetooth: Mesh: Check response address in Configuration Client

The Configuration Client doesn't check the address in a received
response. This means that a response from any device will be accepted.
This change ensures that the correct response will be accepted.
Signed-off-by: Pavel Vasilyev<EMAIL_ADDRESS>

Btw, the health client probably also needs a fix like this

Answering myself: yes, health_cli.c needs a similar fix. Should be easy to do, @PavelVPV will you pick up that task?

Yes, I'm on it.

Btw, while I already approved this one and am fine with merging it, we could consider being a bit more forward looking and refactor out the common parts of cfg_cli.c and health_cli.c to reduce duplicated code and to enable easier implementation of other synchronous client model implementation.
To do that I'd suggest creating a new bt_mesh_cli struct and embedding it in the current cfg and health structs:
struct bt_mesh_cli {
        struct k_sem          op_sync;
        uint32_t              op_pending;
        uint32_t              op_pending;
        void                 *op_param;
        uint16_t              op_addr;

Also, instead of having a cli_response_check() function I'd make this bt_mesh_cli_param_get():
void *bt_mesh_cli_param_get(struct bt_mesh_cli *cli, uint32_t opcode, uint16_t addr)
{
        if (opcode == cli->op_pending && addr == cli->op_addr) {
                return cli->op_param;
        }

        return NULL;
}

If you'd also put the BT_WARN() into that function instead of the message handlers you'd eliminate a bunch of repeated code.


Ready for testing 🧪 Multi-policy training support

I've modified to onnx inference to handle different action spaces, and to handle models exported with Rllib differently than SB3 exported models by the following process:
1) Check the output size of the onnx model
2) IF all actions are continuous:
      IF output size of onnx model matches total continuous action size set in Godot: Read all action values
      ELSE: Skip action logstd values

There's still testing needed as I might have overlooked something or caused some regression with the code, otherwise, this should finally bring full support for multi-discrete, continuous and hybrid actions for models trained with Rllib, and keep the continuous only action support for SB3 for now.


Critical typo: squeeze the y_pred tensor even when it’s the same rank and shape as the y_pred tensor should be == instead of !=

https://github.com/tensorflow/tensorflow/blob/a32a1c9123a7c4fb926c1cdc3d99188a171cdfe5/tensorflow/python/keras/utils/losses_utils.py#L191
should be:
if (y_pred_rank - y_true_rank == 1) or y_pred_shape[-1] == 1:
Current behavior will squeeze the y_pred tensor even when it’s the same rank and shape as the y_pred tensor.

@rodriguesk Thank you for reporting an issue here.
Could you please elaborate the issue you are facing here ?
I was able to run the file successfully, please find the gist here!
Thank you!

The issue is that the code is written wrong. read the code comments and what it’s supposed to do (only squeeze when the ranks differ by exactly 1 and not squeeze for situations of equal rank). Yet the code’s if statements will squeeze whenever the ranks are equal, which is wrong.On Jan 2, 2024, at 1:09 AM, sushreebarsa @.***> wrote:External Email
@rodriguesk Thank you for reporting an issue here.
Could you please elaborate the issue you are facing here ?
I was able to run the file successfully, please find the gist here!
Thank you!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@rodriguesk I have created a fix internally, once the changes are verified this issue will be resolved.
Thank you!

it looks like the PR you made was closed as this is a fix needs to be made in the keras repo? What's the plan?

@sushreebarsa I made a PR for the appropriate tf-keras repo. https://github.com/keras-team/tf-keras/pull/719


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4156

Questions ?
Please refer to the Backport tool documentation


android-studio-for-platform: init at 2<IP_ADDRESS>

Description of changes
android-studio-for-platform is a variant of the Android Studio IDE designed specifically for working on AOSP.
homepage: https://developer.android.com/studio/platform
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Had a previous PR open here: https://github.com/NixOS/nixpkgs/pull/269108 but forgot about it and deleted my fork of nixpkgs, which closed the pull request.
I will be re-testing to see if the errors I mentioned in the comments of that PR still exist or if they impact any functionality.

Result of nixpkgs-review pr 278361 run on x86_64-linux 1

1 package built:

android-studio-for-platform

Had a previous PR open here: #269108 but forgot about it and deleted my fork of nixpkgs, which closed the pull request.
I will be re-testing to see if the errors I mentioned in the comments of that PR still exist or if they impact any functionality.

Fixed the Soong sync errors found there.

If you need testers for this PR, let me know. I'm running NixOS on x86_64 Linux, and have several AOSP trees to work with. I have around 32GB of RAM.
I was just about to start work on a branch, but no need now. Good luck!

Also removed some un-needed dependencies in the latest push.


After redeploying DH, fewshot_examples_retriever doesn't work

Recently I started to experience this scenario after redeploying DH (both DH/mongo containers).
> Entering new AgentExecutor chain...
Action: fewshot_examples_retriever
Action Input: << input question >>
Observation: fewshot_examples_retriever is not a valid tool, try one of [sql_db_query, get_admin_instructions, get_current_datetime, db_tables_with_relevance_scores, db_relevant_tables_schema, db_relevant_columns_info, db_column_entity_checker].

But if after re-deploy, I refresh all the golden-records (i.e. delete/upload via API), it works again.
I'm using the default VECTOR_STORE and CONTEXT_STORE.
This didn't happen before.
Can't figure out why this is happening yet.

@ppmarkus Hi Markus, I'm looking into this issue, and let you know as soon as we find the bug or solution. Thanks for all your contribution so far.

@ppmarkus This PR: https://github.com/Dataherald/dataherald/pull/224 should address the issue you mentioned.
Please let me know if the issue still persists. Thanks.

Hi @MohammadrezaPourreza,
Np thank you vm for looking into it.
Today OpenAI API was down for most of the day for us which I didn't experience before.
I'm sure it'll improve over time but shows that having multiple vendors is a good idea.
After testing the change, I see that the previous observation namely this one below is gone
Observation: fewshot_examples_retriever is not a valid tool, try one of [sql_db_query, get_admin_instructions, get_current_datetime, db_tables_with_relevance_scores, db_relevant_tables_schema, db_relevant_columns_info, db_column_entity_checker].

but DH goes straight into Action: db_tables_with_relevance_scores
> Entering new AgentExecutor chain...
Action: db_tables_with_relevance_scores
Action Input: << Question >>
Observation: Table: <<table>>, relevance score: 0.711, ...

If I rerun the POST [/api/v1/golden-records] API end point then it works as expected.
> Entering new AgentExecutor chain...
Action: fewshot_examples_retriever
Action Input: 5
Observation: Question: ....

@ppmarkus Thank you for your insightful comment. I'm a bit unclear on the issue at hand. Currently, the engine's workflow involves calling the fewshot_examples_retriever tool when there are golden records present. However, in cases where there are no golden records, the agent skips the fewshot_examples_retriever tool and proceeds directly to the next tool, which is db_tables_with_relevance_scores.

Hi @MohammadrezaPourreza
Np. That makes sense of course. If there are no golden-records then the agent will carry on and use the next best option (db_tables_with_relevance_scores)
What I meant was that say I initialize the server (db/tables/golden records) via the API and it works as expected (fewshot_examples_retriever agent is used), but then if I then bounce DH (stop/start via docker compose), the golden records are then not referenced when asking a question. I can see the entries in MongoDB but perhaps but as mentioned above are used. (DataheraldSQLAgent.create_sql_agent() is being called with max_examples=0)
Just to confirm, is it expected behaviour that the golden-records need to be re-applied via the API after bouncing DH?

@ppmarkus Thank you for providing clarification.
Re-applying these settings after bouncing DH is not an expected behavior. Could you kindly inform me which vector store you are using: Chromadb or Pinecone?
If you are using Chromadb, this behavior is expected since the golden records in the vector store are stored within containers, and they are lost when the container is rebuilt.
Regarding the 'max_examples' setting, I couldn't locate the specific reference you mentioned. The default value for golden records was intended to be set at five (max_number_of_examples: int = 5  # maximum number of question/SQL pairs).

Hi @Mo, thank you for the clarification.
I am using the default Chromadb so it all makes sense now. I see the chromadb persistent store being initialized.
I have added a step in our ci/cd pipeline to re-apply the golden-records after DH is deployed.
Thank you for your patience and explanation.


Unexpected reactivity watching shallowReactive array

Vue version
3.3.12
Link to minimal reproduction
https://play.vuejs.org/#eNqNVE1zmzAQ/Ss7XMBTCk1yo8TTtM2hPSSdJJ0eQg4EFkwiSxpJ2O54+O9dSQYzHTfTE9Lu27dvP9A+uJIy2fQYZEGuK9VJAxpNL4GVvL0sAqOLYFnwbi2FMrAHhU0M96uSMbG9s2d96lxWpttgDNvSVKuYgrwBBmiUWENICcOCF7xipdbQCAH7ggOAVEKeZTP+XBvV8XYJl7NEURguPk748ww8iDBhSPbBMQuuDYjnlzMyc9zaJJGNmhznfzlGVyUYQ5Ir+DypLyB6tIyxC3+aB61R67JFTSFjsdHjAeGaEB1pY4gWcLn0JY+Biez1Kgp/WSwqoILaFhXWEMI7J/NraTBaWMYh9qE1osygKZnGmKw+WdNzr72XNUXcklzK5rt7lPD44SlxvU42JeuRVFv6hItttEiMuHf9dF1xzZxIy7omxhOEXv7UzkNknvqVogWii8G1ZJSGbgC5XObPvTFE+qliXfVKuzaXTFv3013B3iHSK9GzGm5uH8begFmhXzBUizz1ZMs8lf/kH9UT91VdW+KJ9z84HevqfPngoTrLU7o5a8/cl06sg837RijKFh1GG0PHa9wt6DNNuwgge8XfhHI+ErTfj04YhjxlnWdOHXWeznoXxPRT0tY1XZu8aMHpz3XTKIJKrGXHUN1KOxJKkh3mRD63xt+dzajeLoy3U6XV6wn7iyZVGR1+KNSoNlgEk8+UqkXj3df3N7ij8+Rci7pnhH7DeYdasN5q9LDPPa9J9gzn1H5zbw4t4oO+3hnkeizKCrXIweGLgF6TL2+UfpR7kVy4OFrOYPgDw/GuRw==
Steps to reproduce
Click on Update Obj1 (should NOT trigger the watcher) and you will see the message of the watcher having triggered.
What is expected?
That the watcher is not triggered since it is watching a shallowReactive array and has set { deep: false }, so only should trigger when applying changes to the array
What is actually happening?
It is triggeing also when props of objects in the array are changed
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 22.42 GB / 31.93 GB
  Binaries:
    Node: 20.7.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.1.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.8.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Chrome: 120.0.6099.129
    Edge: Chromium (120.0.2210.91)
    Internet Explorer: 11.0.19041.3636
  npmPackages:
    vue: ^3.0.0 => 3.3.12

Any additional comments?
https://github.com/vuejs/core/discussions/9900
In my case (open source vue project), is causing an extra overhead and lower performance since it is triggering and causing unwanted loop

Maybe we shouldn't force deep here if the passes deep:false
https://github.com/vuejs/core/blob/a8d0b1b38b092ec2d10b32bedcee2eea33b77657/packages/runtime-core/src/apiWatch.ts#L211-L214

@edison1105 I think we need two changes:

Do not set deep to true if the user option explicitly has deep: false
If the source is reactive and is shallow, we should use a shallow traverse (i.e. only traverse the root level).

Is it possible to implement it based on this PR: https://github.com/vuejs/core/pull/9572/files. It does something similar.
/cc @Alfred-Skyblue

@edison1105 I added the depth option in #9572 to control the depth of monitoring. When the monitored data source is shallowReactive, it only listens to the first layer.

@yyx990803
👍 for respecting { deep: false }, but RE: depth 1 for shallow reactives:
This PR is an (unannounced) breaking change in a patch (not even minor!) release!! Before 3.4.2 a shallow reactive was deeply observed, after upgrade to 3.4.3 it is only observed shallowly, leading to observable changes in behavior.
Worst, briefly looking at the source change I have the impression that deep observation is not even possible at all anymore!
At first glance, even passing { deep: true } will not work because of new condition isShallow(s) || deep === false ? 1 : undefined that can't be bypassed!!
For the philosophical discussion: I think it's not a good change as it ties the behavior of watch to unrelated implementation details of its source.
Shallow vs deep is not indicative of where reactive state is, it's more a DX preference for creating reactive state. For example, I default to shallow refs 90% of the time, but I still have nested reactive state. Just because I use a shallow reactive array for perf and predictability doesn't mean I don't put nested reactive state inside that array.
Whereas this somewhat made sense in @ragnarlotus example, because everything was located close together and he was in control of both the source and the watcher, it's not always this simple.
Consider for example a library author that creates a composable function, that internally uses a watch on a source that's passed from outside.
This can have nasty "changes at distance" effect, consider:
In file A, I change an array that was a deep reactive into a shallow reactive.
Doing so, I unknowingly create a bug in file B, where that array was imported and passed to watch, whose behavior has now changed.
This kind of cascade effects are very trappy. Most devs would not anticipate such consequences as they're highly unintuitive.
👉 please consider reverting the shallow rule, and merging something like @edison1105 's PR #9572 to let watch authors control the depth of observation instead.

@jods4 You can still use deep: true to deeply watch shallowReactive, and it will trigger the following logic:
https://github.com/vuejs/core/blob/8f85b6da442cec326c22418ead6486e914245656/packages/runtime-core/src/apiWatch.ts#L296-L299
playground

@jods4 deep: true is still respected if explicitly passed on a shallow reactive source. That said, it does occur to me that we are double-traversing in this case. I've updated the code to avoid the double traverse when deep: true is passed, and also added a test case for deep: true + shallowReactive source in 24d77c25c

Reverted the shallow default behavior - see https://github.com/vuejs/core/issues/9965#issuecomment-1875067499


SlashCommand Doesn't support dark mode

The codeblocks and todos also do not support dark mode.

Did you find a solution for it? Having the same issue currently

https://novel.sh/docs/quickstart#anatomy components are now modular, you can style them for your specific case


Black holes and invalid link to keras model (for hole filling)

Required Info

Camera Model
l515

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 20

Platform
PC

SDK Version
2.0

Language
python

Segment
others

Issue Description
Hello,
today I received the realsense and recorded some depth images. I want to train a machine learning model with the depth information.  Therefore I need images like in this data set Nyu. My first problem are many invalid pixels on black objects (like displays, tables, chairs). Is there a better configuration for the realsense to receive better results?
For the denoising and hole filling, I want to use the Keras model like described in the examples. But I can not download the Keras Unet model from git examples Part 5. All links are invalid on this page (AccessDenied). Can somone provide a valid link to this model?

Hi @Basti110   It is a general physics principle (not specific to RealSense) that dark grey and black objects can be difficult for the camera to read depth information from because such colors absorb light.  The darker the shade, the less light that is reflected back.  Projecting a strong light source onto such objects can help to bring out depth detail, as demonstrated in the L515 case linked to below where areas that light reflects from are rendered in blue instead of empty black areas of no depth information.
https://github.com/IntelRealSense/librealsense/issues/6757
Holes may also be reduced when using L515 if there is a wall behind the object to bounce light off.
In regard to the broken link, I will tag the provider of the model file into this discussion.  Hi @nohayassin  Can you provide a working link for the DEPTH_Keras_Unet.zip model file for Example 5 of the TensorFlow wrapper please?  Thanks!

Okay Thank you :)
I will try to play with the light sources a bit. Maybe together with the denoising, the results are usable for me.

Hi @Basti110 , the url had changed to https://librealsense.intel.com/rs-tests/ML/Depth_Learning/DEPTH_Keras_Unet.model.zip
I will fix it, thanks for your notice.

Hi @Basti110  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


Add an AXIN card to the library datasets page

Jira Ticket: https://broadworkbench.atlassian.net/browse/DC-853
Summary of changes:
Add a card for the AXIN dataset to the Terra datasets page. This card is hidden by default and must be enabled by using the terra feature flag settings.
Notes

This uses a hardcoded snapshot ID, which is somewhat fragile, although we don't expect the value to change often once a data release occurs. During testing it may change often, however, and has a different value in dev and in prod.
The link is also hardcoded and should use Nav instead, but currently this page doesn't register its path with Nav

Testing strategy
Manual testing
Visual Aids

The link is also hardcoded and should use Nav instead, but currently this page doesn't register its path with Nav

How big of a lift would it be to register the path with Nav?

The link is also hardcoded and should use Nav instead, but currently this page doesn't register its path with Nav

How big of a lift would it be to register the path with Nav?

I was looking at the wrong version of navPaths, it turns out it is registered, I'll update the code to use Nav instead


Pug wrong "reserved" keyword in v-for

Using type as a variable name in loops causes the syntax highlighting to break down:

<template lang="pug">
div.first

div(v-for="type in types" :key="type")

div.second
</template>

Duplicate of #520


Rancher v1.6.14 Cattle

Describe your issue here
221/5000
Dear, I'm using version 1.6.14 of the rancher and after uploading some containers in different stacks, the hosts are not subdividing the stacks as they were in previous versions. Anyone else with the same problem?

Useful
Info

Versions
Rancher v1.6.14 Cattle: v0.183.37 UI: v1.6.37

Access
ldap admin

Orchestration
Cattle

Route
host.containers

It looks good in v1.6.22
Please let us know in a comment if you can still reproduce the issue, and we'll reopen it


fix(input): camel-case md-prefix and md-suffix

Renames the md-prefix and md-suffix directives to camelcase.

Closes #2636

LGTM


Pare down the ignite commands to what is feasible.

Currently I can be in any folder and type ignite and I'll see every option.

Technically some of these are not proper for a user, but they must be typed find that out.

^ see?  The very first command listed and RED TEXT.   An experienced Ignite user knows... but a non-experienced ignite user immediately gets nada!
So my suggestion is, when you're in an empty folder you get:
  doctor         Checks your dev environment for dependencies.
  new (n)        Generate a new React Native project with Ignite.
  plugin (p)     Manages ignite plugins
  version (v)    Prints current version of installed ignite

🌅  Ahhhh, so clean, so friendly.
and when you're in an Ignite project, you get:
  add (a)        Adds an Ignite plugin.
  doctor         Checks your dev environment for dependencies.
  generate (g)   Generates some files.
  plugin (p)     Manages ignite plugins
  remove (r)     Removes an Ignite plugin.
  spork          Copy templates as blueprints for this project
  version (v)    Prints current version of installed ignite

w00t!  What a great set of options that all make sense!

This is a great idea.

*pare

I'm trying this

In order to allow some commands to be show only within an ignite folder, and
others outside, a change is required in Gluegun. The hidden status of a command
is determined by the presence of certain strings in the content of source
files. Practically speaking, they are determined at compile-time. I thought of
a way we could do this.
Introduce a dynamic option that is invoked with a particular keyword that would
go in the place "true" is usually found. For example, near the top of Ignite's
add command is this line:
@cliAlias a
Change the token finder in Gluegun to look for that. When the option is
detected, Gluegun will check the directory for a file. In our case, this would
be a directory sharing the name with the plugin. There might be more options
people want, but this is all we would need.
How this would look in a command file such as Ignite's add command:
@cliHidden whenExists /ignite/ignite.json
Gluegun would then look for ./ignite/ignite.json in the cwd
Thoughts?

I guess another option would be to change some of this, and evaluate whether cwd is an ignite directory there. It would be a lot simpler and wouldn't require changing Gluegun.

Steve gave me the idea to hijack and modify print-commands from Gluegun so that we can control the logic determining whether each command shows up in the help message.
I understand the change that’s needed in print-commands, but I don’t know where I should perform that modification. It can’t be in /ignite/src/cli/cli.js because that isn’t run just once. Is there an npm after-install script or something that would work?

@mlaco I'd like to still do this, but basically we'd just need to do something custom here:
https://github.com/infinitered/ignite/blob/6e8145c6a0a589bf56da4f3fda807bcdd8e66175/src/commands/help.ts#L13

:tada: This issue has been resolved in version 3.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adjust github workflows to the new repo

Don't run e2e workflow when pushing a PR
Remove 'make manifets' from generate workflow
Run 'make test' instead of 'go test' in unit workflow Remove go-fmt go-mod go-vet
Add a workflow 'make-linit'

Why have you removed the go-mod and the go-vet workflows?

and the go-fmt

OK go-vet should be covered by the default settings of golangci-lint.
However gofmt must be enabled manually if you want to run it in the context of golangci-lint.
Also, golangci-lint does not seem to offer an alternative to the go-mod check.

OK I have removed my merge-commit (sorry about that).
Now Github still complains about a conflict. @itzikb-redhat Can you please rebase onto main and force-push?

aaah wait I got it. Give me a sec

This is better. All good, the PR is scheduled to merge as soon as the tests pass.


http://pichalite.com this demo page is something wrong.

hello ! As the title say. Can you fix this demo page so that i can see the theme directly  ? Sincere thanks～

Demo is still working.


search_range code needs a slight fix. it does not work for certain conditions

nums = [5,7,7,7,7,8,8,8,8,10]
target = 7
search_range(nums , target)
output : [4, 4]

Can I contribute to this Issue?

Can I contribute to this Issue?

Sure

@KishoreTG go ahead with the contribution, tag me on your PR to review it.


Feature Request: Expose default styles for use in custom components

While Tremor comes with many great components, it will never fulfill 100% of everyone's needs. It would be great if it were easy to reuse Tremor's default styles when we need to build new, custom components.
Today I believe I need to copy over a bunch of style information in order to stay consistent with the rest of my dashboard, when I build something custom. It'd be awesome if Tremor provided some easy way to reuse those defaults style when new components are needed.
Alternatively, it'd be great if Tremor offered a component designed for extensibility with recharts so if you need to make a more complex, or purpose-specific chart you could keep the design consistent with other Tremor charts.

@bernsno, I agree that maintaining design consistency with the remaining app may is difficult with how tremor works currently. Do you have a suggestion on how we could expose our styles for reuse?
Also, our next larger thing on the roadmap is theming / custom colouring, we don't have a specific timeline on that though unfortunately.

It'd be awesome if Tremor provided some easy way to reuse those defaults style when new components are needed.

with utility classes being used across the library inheriting styles doesn't really fit with the methodology

Do you have a suggestion on how we could expose our styles for reuse?

wonder if a design methodology page added to the docs would help? calling out things like shaddow-xl rounded-lg and pointing people to tailwindcss for more info

Sorry I haven't had a chance to open an example PR for this, will try to do next week. @JPrisk you make good points about utility classes. What I'm hoping could be offered are easy ways to create graphs that are more complex than what tremor needs to support for most use cases, but maintain the existing styles (type, color, spacing around components). Your suggestion of highlighting design methodology could be a good starting point, but curious if there's a way to create an extensible chart component that gets someone part of the way to a new component.

Hey there, despite not solving all the issues mentioned here, I hope the ability to style root elements through className, as well as the theming added in v3 helps with this issue. If that rings true, I'd say we could close this issue. Let me know @bernsno

I am going to close this issue, thanks for the discussion!


ARROW-3444: [Python] Add Array/ChunkedArray/Table nbytes attribute

https://issues.apache.org/jira/browse/ARROW-3444
Question is then what the expected result is for a sliced array? (because the buffers do not take that into account)

Question is then what the expected result is for a sliced array? (because the buffers do not take that into account)

I think it would be very misleading if it didn't report the size of the actual number of elements rather than the number of elements in the entire buffer.
e.g. pyarrow would hopefully follow numpy here:
In [2]: import numpy as np

In [3]: x = np.random.randn(1000, 1000)

In [4]: x.size, x.nbytes
Out[4]: (1000000, 8000000)

In [5]: x[::10, ::10].size, x[::10, ::10].nbytes
Out[5]: (10000, 80000)

In [6]: x[:1, :1].size, x[:1, :1].nbytes
Out[6]: (1, 8)

There is a trap here in that referencing a single element in a view won't release a potentially very large buffer, but it's a gotcha that anyone familiar with numpy will know about - if you want to release the memory take an explicit copy.
I think there's a huge benefit in following the numpy precedent so peoples code and intuitions will be more portable.

@dhirschfeld I agree it would be surprising if it did not report the size of the actual array but rather the size of the entire buffer.
I checked, and also __sizeof__ in numpy only looks at the actual slice and not the full array.
@pitrou what's your thought on this?  (the +1 means you are fine with the current behaviour, or think this is fine as a follow-up ?)

@dhirschfeld I agree that following Numpy would ideally be better here, but probably harder (especially for variable-length types such as list).


Inventory not populated, unless you search explicitly from the web interface

Hi! I'm trying to use netdisco in its docker form to extract some infos from my network devices. Since I'm trying to use it in a fully automated environment, I don't want to use the web interface at all: I just generate the deployment.yml file, fire the containers and then I directly extract what I need from the DB.
Everything works just fine, beside a very important detail: even though I populated correctly the inventory through deployment.yml, nothing is ever discovered, unless I first try to discover at least one device through the web interface. If I try that, then magically all the devices in the deployment.yml are discovered as well.
Thanks for any help/insight!
Expected Behavior

When firing the containers, devices should be discovered according to schedule defined in deployment.yml.
Current Behavior
Discovery is never started, Inventory is empty (clicking the page brings you back to the homepage) unless interaction from the web interface happens, trying to discover at least one ip using this field:

Possible Solution
Implement a way to "wake up" the thing (even though I assume that it should have done it by itself, which would be best), maybe using netdisco-do; but it must NOT rely on knowing a specific ip to discover (e.g. run a generic operation like netdisco-do stats). This currently doesn't work but would be enough to solve the problem.

Steps to Reproduce (for bugs)

Make default installation of netdisco-docker
Provide a deployment.yml in the correct directory (below mine).
Verify that the Inventory and the DB are never populated.

Context

I'm trying to use it in a fully automated environment, I don't want to use the web interface at all: I just generate the deployment.yml file and then I directly extract what I need from the DB using another container I built.
Your Environment

netdisco container versions: 2.74.1 and 2.72.1 (tried these two, neither works)
docker engine version: 24.0.7
docker-compose version: v2.21.0
host operating system: 5.15.0-86-generic #96-Ubuntu.

Config info (deployment.yml and docker env settings)
`
site_local_files: true
no_auth: true
host_groups:
discover_only:
- <IP_ADDRESS>-13
- <IP_ADDRESS>
devices_only:

'group:discover_only'

device_auth:

tag: 'default_v2'
community: xxx
read: true
write: false

schedule:
discoverall:
when: '55 09,14 * * *'
macwalk:
when: '55 09,14 * * *'
arpwalk:
when: '55 09,14 * * *'
nbtwalk: null
expire:
when: '30 23 * * *'
makerancidconf: null
`

Device information
All devices are Cisco, various platforms, it doesn't seem to be related to which device is defined in the inventory.

A recent release just added a "pingsweep" to netdisco-do. Could you just run netdisco-do pingsweep --enqueue <IP_ADDRESS>/24 somewhere in your process, then together with your discover_only setup it should combine to discovery everything replies in your ranges.
If you want to write it more generically use a larger range in the pingsweep that matches your networks.
For netdisco to start polling without a single seed device as you describe is difficult to support in a generic way, since one can have a deployment.yml without a single ip or network in it to get started on.

A recent release just added a "pingsweep" to netdisco-do. Could you just run netdisco-do pingsweep --enqueue <IP_ADDRESS>/24 somewhere in your process, then together with your discover_only setup it should combine to discover everything replies in your ranges.
If you want to write it more generically use a larger range in the pingsweep that matches your expected networks.

Hi, thanks for the idea :) unfortunately it doesn't really resolve my problem as I would have to know the target of the pingsweep... Devices might not be all in the same subnet for instance, like <IP_ADDRESS> and <IP_ADDRESS>: if I ping one, would it discover the other one as well? Anyway it's a nice idea and worth a shot.

For netdisco to start polling without a single seed device as you describe is difficult to support in a generic way, since one can have a deployment.yml without a single ip or network in it to get started on.

So this is by design? There's no "internal" trigger (e.g. like running something in the backend container...?) that forces the backend to discover what I configured in the deployment.yaml?

Theoretically Netdisco can discover your whole network from one well-connected seed device, it uses various neighbor discovery protocols. But it's easy to break this by a single hop that has LLDP disabled, so typically you'll want more than one, e.g. one router per building in all your branch locations.
How do you get the ranges you put into discover_only right now? Maybe you can just ping sweep all of these?

The IPs are inserted manually into a scripts that generates the whole configuration (docker-compose.yml, deployment.yml etc) so I might add at the end, after composing, a pingsweep command, that's definitely something I could do.
To understand better, I tried to make a pingsweep on a single ip just to make a test (I've used <IP_ADDRESS>) and that + two other devices (<IP_ADDRESS> & .12) became available in the inventory... I don't understand, I find it a little bit weird/random: shouldn't that just make the .6 available? How can I be sure, on the other hand, that if I ping sweep the entire network, no devices will be missed from my list? And what happens if in the range that I sweep (let's say a /24) I have other devices that I DON'T want to incorporate in that moment? Will Netdisco try to discover them?
Sorry, I don't want to be annoying, I'm just trying to understand what's the logic behind this.
Thank you for your answers, I greatly appreciate them.

Don't worry these are all valid questions :)

other devices (<IP_ADDRESS> & .12) became available in the inventory.

This is the neighbor discovery mechanism, when discovering one device Netdisco looks at the neighbors via CDP/LLDP/BGP/etc, and tries to discover the neighbors too. You can disable or limit this "infectious" discovery via discover_neighbors/discover_routed_neighbors/skip_neighbors configuration.

How can I be sure, on the other hand, that if I ping sweep the entire network, no devices will be missed from my list?

You really can't, as a lot of stuff can go wrong with discovering a device: your config doesn't have a valid SNMP community for it, device has ACLs, unreachable etc.... to be really sure you'd need to know the exact list that should be there, compare with what was found, and go investigate what went wrong with each device that's missing.

And what happens if in the range that I sweep (let's say a /24) I have other devices that I DON'T want to incorporate

You'd add them into the discover_no configuration.

Great explanations, thank you! Now it's clear. You are very kind and patient :)
May I ask you one more question please? I noticed that in the containers date is set to UTC, therefore the schedule put in deployment.yml uses UTC as timezone, even though the host machine is in another TZ.
Is there any way to change/configure that? I'm asking this because I'm in CEST and the schedule run 2h after what I put in the deployment.yml.
I could just anticipate by 2h but this would not follow the summer/winter pattern... I could install tzdata via docker run apk add but I wanted to put everything in an air-gapped environment, so it would be better to have a solution that doesn't rely on Internet connection.
Is there anything you could suggest to resolve this scenario? Maybe I'm missing some configuration somewhere? Thank you :)

tzdata should already be installed in the current container image. You can set TZ in the docker environment and timezone in postgresql.conf, see e.g. https://github.com/netdisco/netdisco-docker/issues/46
This only works well if all your users + devices are in the same time zone and is not extensively tested or supported, but it seems to do ok for the people that tried so far.

oh you're right, we've added tzdata once but it was in the wrong place. The next release should include it in all the images.

Thank you very much. Closing the issue as everything seems to be sorted out.
THANK YOU 👍


How to setup diff_drive_controller?

Hello everyone, congratulations on the amazing work with ROS1 and ROS2 control.
We are migrating our robot to ROS2 . For a first test, I am trying to use diff_drive_controller from ROS2 Control at Gazebo. I setup the ros2_control tags and the gazebo_ros2_control plugin the same way presented in the ros2_control_demos. It worked fine for position_controllers and velocity_controllers, but it did not work for the diff_drive_controller. I am having the following error message:
[gzserver-1] [INFO] [1617050376.482951728] [controller_manager]: Loading controller 'diff_drive_controller'
[gzserver-1] terminate called without an active exception
[gzserver-1] Aborted (core dumped)
[ERROR] [gzserver-1]: process has died [pid 80076, exit code 134, cmd 'gzserver /PATH_TO_WORLD_FILE                                                                   -s libgazebo_ros_init.so   -s libgazebo_ros_factory.so
I tried to find an example of it, but I did not find it. Is there any example package using this controller?
I am attaching the parts related to the wheels transmissions, ros2_control, and controller parameters. Thank you.
robot_controller.yaml.txt
ros2_control.urdf.xacro.txt
wheels.transmission.xacro.txt

I did not spot anything wrong on the first look at these files.
Have you tried this demo implementation? https://github.com/ros-controls/ros2_control_demos/pull/70/files

I'll close this issue because there are several tutorials or example out there nowadays, e.g. first-hand

https://control.ros.org/master/doc/gazebo_ros2_control/doc/index.html#gazebo-ros2-control-demos
https://control.ros.org/master/doc/ros2_control_demos/example_2/doc/userdoc.html


TailwindCSS styles are purged

When developing a custom component or custom page, some TailwindCSS classes are not working as the styles are being purged including only folders from within the filament package.
// Current tailwind.config.js file
module.exports = {
  purge: {
    layers: ['utilities'],
    content: [
      './src/**/*.php',
      './resources/views/**/*.php',
      './resources/js/**/*.js',
      './packages/forms/src/**/*.php',
      './packages/forms/resources/views/**/*.php',
      './packages/tables/src/**/*.php',
      './packages/tables/resources/views/**/*.php',
    ],
  },
  // ...
}

Instead, what I would propose is to add the resources/filament folder to the purge configuration, so that styles also include user classes:
// Current tailwind.config.js file adding the resources folder from project
module.exports = {
  purge: {
    layers: ['utilities'],
    content: [
      './src/**/*.php',
      './resources/views/**/*.php',
      './resources/js/**/*.js',
      './packages/forms/src/**/*.php',
      './packages/forms/resources/views/**/*.php',
      './packages/tables/src/**/*.php',
      './packages/tables/resources/views/**/*.php',
      '../../../resources/views/filament/**/*.php',
    ],
  },
  // ...
}

Thanks in advance!
Raúl

Adding the user's resources/views folder won't actually solve the problem as you'd need to recompile them Tailwind anyway.

Yeah Ryan is correct here, apologies!


assetPrefix ignored by stylesheet when import from pages/index.js

Examples bug report
This bug may be related to next-sass plugin
Example name
with-next-sass
Describe the bug
assetPrefix doesn't apply for stylesheets (same as https://github.com/zeit/next.js/issues/3967)
when import from index.js or _app.js, assetPrefix doesn't apply.
To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

set assetPrefix for with-next-sass example  and build

module.exports = withSass({
  assetPrefix: "assetPrefix"
})

Set config.output.publicPath.
module.exports = withSass({
  assetPrefix: '_foo',
  webpack: (config) => {
    config.output.publicPath = `/_foo/_next/`;
});


Remove less deps

No need for them in core CLI, now that templates are extraneous to the downloadable.

Template authors will declare their own style-* loaders
We use proxy-loader which will pick up the necessary loaders (if properly defined)

Agreed, but we need to improve on documentation for all these things.


Enable StrictHostKeyChecking

StrictHostKeyChecking is turned off and the upstream action doesn't provide an option to enable it.

Another project supports this out of the box: https://github.com/spyoungtech/mirror-action
The host key verification seems broken though.

ℹ  Support for StrictHostKeyChecking available via fork at the moment.


Completely broken

This does not show up on the menu. Adding it using git #1.0.0 prevents Unity from downloading it. Dragging the folder in makes it not recognized. The version on booth.pm is not even a .unitypackage in the archive. Adding it via git without #1.0.0 allows it to get downloaded but it still fails to load or show on the menu.
You have some paid products on booth that I was interested in but are they the same quality as this?

This is a partially extracted version of a package in Booth, a library file, not the type that brings up a tool window.

And this is something that was left until the VPM environment was ready. I have never declared this a release.

You have some paid products on booth that I was interested in but are they the same quality as this?

I recommend that you read the description carefully before using my products.

I guess I was confused on how to use this.


The hint for webapp:config is confusing

Define value for javaVersion(Default: jre8):

jre8 [*]
java11
Enter index to use:
Define value for runtimeStack(Default: TOMCAT 8.5):
TOMCAT 9.0
jre8
TOMCAT 8.5 [*]
WILDFLY 14

javaVersion : jre8 and java 11? why not Java 8 and Java 11?
runtimeStack: the order should be sorted, so TOMCAT 9.5 and 8.5 will be conjunct, and all the value should be case consistent: jre8 and TOMCAT is weird , and you should also have some description about these options, user will NOT know what does jre8 runtime mean.

Fixed in #675


Repo sync for protected CLA branch

The pull request is created from main637913614649525141 to main to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

#please-close


BUG: Misaligned Content on Website

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

There is a misalignment issue on the website where some elements appear slightly up or down relative to each other. This affects the visual consistency and layout.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hi @Rupalpy !
The footer is already been assigned and undergoing chnges, we will be updating it very soon.
Keep looking for new issues in the repo and website.
happy coding ✨


chore: info log whenever ConfigGenApi::state is changed

Fixes #3499
I am pretty sure I covered all occurrences of changes to ConfigGenApi::state, but I am not sure If LOG_NET_PEER_DKG is the appropriate log channel and I would appreciated suggestions for improving the messages.

In the future you can also just amend commits and force push or squash them in the end before merging, so there aren't any fixup commits for previous commits in the same PR.


ACR: consistency review and docs and samples

adds  size to UploadBlobResult
adds default value to OciImageManigest
cleans up docs and adds code snippets

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-containers-containerregistry


fix: eventually-openapi config again to work with firebase emulator

#45 did not actually fix that issue.  This PR is an addendum to #45.  It adds a fallback for the PORT config env variable.  If it is invalid in any way it will default to 3000 to pass validation.
Just for clarification my use case requires me to run eventually-express in listen(true) silent mode since the firebase functions framework handles listening in it's own way.  I am not allowed to set an arbitrary value for the PORT env variable because it is reserved when using the firebase-tools CLI, so I needed a way to circumvent this check.

The firebase emulator sets the PORT env variable to a string pipe name which fails zod validation and throws an error (NaN) on startup. The fallback I implemented here catches that validation error and sets the port to 3000 so it can proceed in silent mode without throwing during config validation.

Ah, I see now... you have to accept the invalid port set by the emulator
there is actually a simple way to do this in zod, something like this below ... want to try it?
const Schema = z.object({   port: z.number().int().min(1000).max(65535).catch(3000),   oas_ui: z.enum(OAS_UIS) });

Your previous config call fix also fixed this issue.  Sorry for the distraction!

Great. Let me know how it goes and if there is anything else I can do to help 👍


Main class for CredentialManager

hi, I am Prem Murmu, New for .net programmer, I need this program main class or method to execute the code.

Thanks for advance..

Hi @prem16 this is a class library, not an executable. Yo uneed to write your own executable, referencing this library, and use it as shown in readme.


Add code coverage

Hi @agoscinski,
I'd like to setup Codecov for this repo, but right now the uploads are failing since I don't have the Codecov token. Rather then generating the token specific to this repo, we could instead either.

Not require tokens for uploads (in the past Codecov required them, but now they do not.
Setup a global token for the aiidateam organization and add it as a organization-level secret (this is what we have setup for AiiDAlab I believe. The settings should be on this page

It looks like the tokenless approach is the easiest here (requires codecov/action v5, more info here:
https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token
Thanks for your help

I added for now an organization secret CODECOV_TOKEN from code cov. I don't want to deactivate the requirement for tokens before I have talked with some other people about it.

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Fix for issue #1102.

Issue - Floating Label with Error breaks UI

@akhil-geekyants Many cases not considered with this PR
Can you reconsider this


correct nomad-autoscaler configuration

Thanks! I don't had the autoscaler within my test harness. :-/
Sorry for that and greetings from "vacationing" :-)


schematics: Cannot generate same element again

My use-case, I'd like to generate .spec.ts file only into already existing components/pipes generated by CLI.
src/app/core/components/
└── my-cmp
    ├── my-cmp.component.html
    ├── my-cmp.component.scss
    ├── (my-cmp.component.spec.ts) <-- I want to generate this later
    └── my-cmp.component.ts

Currently, I cannot generate spec without other files.
> ng g component core/components/my-cmp --spec
error! src/app/core/components/my-cmp/my-cmp.component.html already exists.
error! src/app/core/components/my-cmp/my-cmp.component.ts already exists.

--force option allows do that, but it will initialize existing code. I'd like to just append .spec.ts.

Is it better that I send this issue to CLI repo?

This is the right place for this.
I'm just unsure of the practicality of splitting up the spec file into a separate schematic. Which would be the right way to handle this functionality. It would require the duplication of many of the options as well as complicate collections which would extend this default schematic collection.
I also don't think this feature would be very widely used, but I may be wrong.


merge for bugfix sonar cloud

:tada: This PR is included in version 4.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: move pointwise set files to Algebra._.Pointwise

The remaining files depend on Data.Set.Pointwise.SMul, which I intend on reworking.

bors merge


Reconsider allowing standard:no-consecutive-comments if there are empty lines, and allow automatic fix

Observed Behavior
#1454 introduces rule standard:no-consecutive-comments, which doesn't allow mixing comment types even if there is empty line between them. For example, you may want to create a large comment common to multiple dependencies, and then follow the structure of having one comment describing one individual dependency, which of course is friendlier on version control diffs:
dependencies {
    /**
     * Common libraries
     * ... some longer trivia...
     */

    // LazyInitializer if you don't want to use @Getter(lazy = true)
    implementation("org.apache.commons:commons-lang3:3.16.0")

    // Support .jar files in a `/libraries` directory without making these deps transitive
    implementation(fileTree("libraries"))
}

I haven't found this convention in Kotlin Coding Conventions, and it's not linked in any place accessible when we stumble upon this error.
Additionally, when we run ./gradlew spotlessApply to fix all code style issues, this problem cannot be fixed automatically, completely halting our workflow as if some fatal error occurred. What's worse, the name of the file where the issue happened isn't even displayed in the error message; we can be glad that at least the error line is shown.
Furthermore, what's worse is that there is no user-friendly way to disable this rule. I haven't found anything in the documentation, except maybe disabling all experimental rules altogether. And I stumbled upon another bug within the Spotless Gradle Plugin https://github.com/diffplug/spotless/issues/2226 where even if I want to override EditorConfig (which I don't have in the project), suddenly the "default" behavior of this plugin completely changes, and this (experimental?) rule becomes disabled altogether whenever any override parameter is specified - it can be one that doesn't exist at all. So, the issue accidentally gets resolved even if you mistakenly add a parameter like "standard:no-consecutive-comments" to "false", which shouldn't work (but would be intuitive, because there should be exactly one ID from the error message that we can directly add to our Gradle configuration to exclude it). I'm also asking you to add a documentation of how this rule can be disabled to the content of the error message if possible.
Expected Behavior
There should be at least a parameter we can use to allow mixing comment types when they are separated by an empty line if it can't be allowed by default. Error message should allow us to resolve this problem automatically, or even better, if you actually have any real conventions about how this should be handled, you can apply it as an automatic fix.
Your Environment

Version of ktlint used: 1.3.1
Relevant parts of the .editorconfig settings: none
Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): https://github.com/diffplug/spotless/tree/main/plugin-gradle
Version of Gradle used (if applicable): 8.9
Operating System and version: Windows 10

I haven't found this convention in Kotlin Coding Conventions

That is correct. It is an attempt to prevent unclear documentation/code. For example a KDoc, followed by a commented-out function.

, and it's not linked in any place accessible when we stumble upon this error.

I am not sure what you mean with this. Do you mean any other reference to such a covention outside the ktlint documentation?

Additionally, when we run ./gradlew spotlessApply to fix all code style issues, this problem cannot be fixed automatically, completely halting our workflow as if some fatal error occurred. What's worse, the name of the file where the issue happened isn't even displayed in the error message; we can be glad that at least the error line is shown.
Furthermore, what's worse is that there is no user-friendly way to disable this rule. I haven't found anything in the documentation, except maybe disabling all experimental rules altogether. And I stumbled upon another bug within the Spotless Gradle Plugin https://github.com/diffplug/spotless/issues/2226 where even if I want to override EditorConfig (which I don't have in the project), suddenly the "default" behavior of this plugin completely changes, and this (experimental?) rule becomes disabled altogether whenever any override parameter is specified - it can be one that doesn't exist at all. So, the issue accidentally gets resolved even if you mistakenly add a parameter like "standard:no-consecutive-comments" to "false", which shouldn't work (but would be intuitive, because there should be exactly one ID from the error message that we can directly add to our Gradle configuration to exclude it). I'm also asking you to add a documentation of how this rule can be disabled to the content of the error message if possible.

For questions regarding any integration with ktlint (Spotless or Gradle), please contact the maintainers of those projects. Ktlint offers functionality to disable individual rules (https://pinterest.github.io/ktlint/latest/faq/#how-do-i-enable-or-disable-a-rule), or to suppress errors at certain locations (https://pinterest.github.io/ktlint/latest/faq/#how-do-i-suppress-errors-for-a-lineblockfile). Also, you can use the Ktlint CLI (https://pinterest.github.io/ktlint/latest/install/cli/) which gives clear feedback for your example:
 $ ktlint-1.3.1 --relative -F  **/Foo3.kts
src/main/kotlin/Foo3.kts:2:5: A KDoc is not allowed inside 'block' (cannot be auto-corrected) (standard:kdoc)
src/main/kotlin/Foo3.kts:7:5: an EOL comment may not be preceded by a KDoc. Reversed order is allowed though when separated by a newline. (cannot be auto-corrected) (standard:no-consecutive-comments)
src/main/kotlin/Foo3.kts:2:5: A KDoc is not allowed inside 'block' (cannot be auto-corrected) (standard:kdoc)
src/main/kotlin/Foo3.kts:7:5: an EOL comment may not be preceded by a KDoc. Reversed order is allowed though when separated by a newline. (cannot be auto-corrected) (standard:no-consecutive-comments)

Summary error count (descending) by rule:
  standard:kdoc: 2
  standard:no-consecutive-comments: 2

As ktlint offers functionality to disable this specific rule, I see no reason for changing ktlint.

There surely could be a rule against it being followed by a commented-out function; especially if there is no empty space in between.


feat: bottom panel support accordion

Types

[x] 🎉 New Features

Background or solution
仅仅是简单对底部面板渲染层增加了 accordion 视图，以支持注册 webviewview 到底部的需求

🤖 Generated by Copilot at 6aeed2b

Refactor panel view component to use generic containerRef, configContext, and CustomComponent prop (link)
Add accordion container component to render multiple collapsible views in the panel (link)
Add minSize prop to accordion container to control view height (link)

Changelog

🤖 Generated by Copilot at 6aeed2b
This pull request enhances the panel view component with an accordion container and custom rendering options. It also cleans up some code in panel.view.tsx and related files.

/next