Monolithic and cumulative rather than "rolling"

If you're reading this, you're probably me, which means you probably know that recently I've been undergoing a philosophical shift as to how I think I should live my life. Specifically, it seems better to stay in touch with what I happen to be doing right now than to try to hang onto everything from the past.
For this repository, the impact would be that I should notice how I only really use the scripts (really just env.sh) when I reinstall my OS or switch machines. And the "automation" aspect isn't the important part; the whole convenience of this repository is that it lets me document my troubleshooting so I don't have to repeat it. Thus I should probably restructure it to be more oriented around "here's how to do this thing" rather than "here is a script to install all the things I've ever used".

I think I'm going to do a couple things:

[ ] Learn Bash.
[ ] Factor out common patterns in env.sh (such as apt) to make it more declarative.
[ ] Replace the once.sh/env.sh dichotomy with just a single script with checks throughout so that it doesn't try to reinstall things that are already there.
[ ] Add continuous integration to test the setup script on Ubuntu and macOS.

I should also make a list of things that I want the setup script to do after this rewrite. As before, it should assume that Git is already installed.

[ ] Configure Git.

[ ] I guess this should include setting up SSH keys for cloning GitHub and Bitbucket repos?

[ ] Install programs.

[ ] Sync apt packages; so, install the ones from the following list, but also push manually installed ones to some running list somewhere? Kind of like my VS Code setup. Also this should automatically add-apt-repository too.

[ ] nautilus-dropbox
[ ] gnome-shell-pomodoro
[ ] texlive-full
[ ] latexmk

[ ] Similarly snap packages I guess?

[ ] spotify
[ ] --classic code
[ ] --channel=edge shellcheck (mostly just because I have a VS Code extension for it installed)

[ ] And other things that I feel like probably didn't come preinstalled...

[ ] Chrome

[ ] Configure VS Code to use the GitHub Gist that that one extension uses.

Everything else should go. Good riddance lol


Remove "Fun" from "PlayerColor"

It's fun.

It's fun.

It's not that "Fun" compared to the other "Fun" commands
like rainbow and etc.
I see "Color" more as the same thing invisible and hat, shirt does
most of the time people disable fun to hinder access to something like :rainbow or whatever
and :color is kinda innocent

see it also as avatar editing and not fun


Add test in CI

Using this example we should be able to run test with xargo.

See https://travis-ci.org/pollen/stm32f0/jobs/287176674 for compilation issue.

Compiling std for the std will fail on armv6. And testing on x86 will fail due to the use of asm instructions.


Auth does not redirect to login page after JWT has expired

After JWT expiry, and user tries to login. The authentication fails because token has expired. However, user is not redirected to login page when this occurs.

Hello there! I would like to contribute to this project and work on the "Auth does not redirect to login page after JWT has expired" issue.
I have experience with authentication systems and handling JWTs, and I believe I can help address this problem.

I have assigned this to you. Please create a new branch to work on. When you are ready, create a PR for review.
Some notes on how I intend to address this issue:

When user first logs in, a token and refresh token shall be created and stored in cookies;
Token shall have expiration of [3] days and refresh token [30] days;
When the application loads, it should try to auto-login by using token;
If token has expired, then it shall try to use refresh token to authenticate;
On logout, both token and refresh tokens shall be blacklisted


Rename oCIS' Proxy to ocis-proxy

The way the oCIS command ties together all services, proxy is an existing go-micro service, and it must be renamed on our end.

renamed where ? in code or in documentation ?

My bad @PVince81, I didn't provide enough context.
Context: https://github.com/owncloud/ocis/blob/master/pkg/micro/runtime/runtime.go#L25
Micro has a service named Proxy. The current runtime implementation doesn't play well with 2 subcommands with the same name, and since we don't use micro/proxy it can be entirely removed from our runtime.
I recently opened a ticket describing possible alternatives to the current runtime, but for the scope of this issue, any micro subcommand SHOULD be removed (and tested on the developer side that behaves the same way).

So does it mean it's commented out in all our ocis-* services and we need to delete that line there ?

exactly

@refs seems to be done? https://owncloud.github.io/extensions/proxy/configuration/#proxy-server

thanks @wkloucek


How to do these all Triggers in Code Behind ?

Hi @nmano2188
The reason for why there's no C# Trigger examples is that Triggers are specifically designed for XAML usage. While you could use the Trigger class from C# there's no advantage to doing so. In fact, it would over complicate what can already be achieved in C# using conventional techniques. For example, there's no need to use an event trigger in C# as you can just create event handlers and register them against an event. Similarly, there's no need to use a property trigger in C# as you can just listen for a property changed event and handle that.

I got it


eden: [profiles] social field enhancements/additions

There are a number of requests around profile/social field enhancements, including:

See message here: https://t.me/eden_dev/5358


MB-12807 convert pkg/services tests

Jira ticket for this change
Summary
Converts the package and tests in a number of ./pkg/services/ to use transactions. See ticket for full list.
Pattern for server tests conversion explains more about the approach used.
Setup to Run Your Code
A clean run of make server_test is sufficient.
Verification Steps

[x] No subtests are run with suite.T().Run(...) - they all use suite.Run(...)
[x] There is no unjustified usage of Truncate in the tests
[x] There is no unjustified usage of suite.AppContextForTest().DB() - instead suite.DB() is used directly
[x] Fatalf is deprecated in favor of other assertions/checks
[x] Go's testing package is only imported in the setup test file. (In this case there was no separate setup file)

Messages

:book:
:link: MB-12807

  Generated by :no_entry_sign: dangerJS against c274c4fe733396b9022a2165c9314a7cc14a39dd


libexec/rbenv-exec: simplify/fix sourcing exec hooks

Fixes two issues reported by shellcheck:
In libexec/rbenv-exec line 37:
IFS=$'\n' scripts=(`rbenv-hooks exec`)
                   ^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
                   ^-- SC2006: Use $(..) instead of legacy `..`.

Amended.

btw: (why) is Travis not running tests?

Closing.


[PyArrow] null values not found when reading CSV

👋, I'm having trouble getting pyarrow.csv.read_csv to parse null values:
>>> from pyarrow import csv
>>> convert_options = csv.ConvertOptions(column_types=arrow_types)
>>> parse_options = csv.ParseOptions(escape_char='\\')
>>> table = csv.read_csv(fn, convert_options=convert_options, parse_options=parse_options)
>>> col = table.column('PATIENT_DOB')
>>> col.null_count
0
>>> 'NULL' in col.unique()
True
>>> col.to_pandas().value_counts()['NULL']
38546

But have no problem if I read the CSV w/ pandas and convert to a Table...
>>> import pandas as pd
>>> df = pd.read_csv(fn, dtype=pd_types, escapechar='\\')
>>> df.PATIENT_DOB.isna().sum()
38546
>>> table = pyarrow.Table.from_pandas(df)
>>> table.column('PATIENT_DOB').null_count
38546

I've tried passing various arguments to ConvertOptions(...,null_values=) but from my reading of https://github.com/apache/arrow/blob/f7ef65e5fc367f1f5649dfcea0754e413fcca394/cpp/src/arrow/csv/options.cc#L28-L30
it seems like literal 'NULL' strings should be converted to NaN? I've tried various combinations of read_csv with/without ParseOptions, with/without ConvertOptions (including and not including column_types), etc.
Ultimately I'm looking to convert these CSV to parquet; ideally I can go csv -> table -> parquet but it seems like csv -> dataframe -> table -> parquet is my only option?

Can you please open a JIRA issue with a minimal reproduction? Thanks

Here you go, https://issues.apache.org/jira/browse/ARROW-5195

Thanks


Fix leaking bullets

Thanks for the great demo. I`d like to use it for a small js workshop in my company. This pr just removes objects from the game that, like Elvis, have left the building.

Thanks a lot for this.  I'm afraid I'm not going to merge it because I want to keep the code as simple as possible.  I'm sorry to say no, and thanks again for sending the PR.

No problem.


Merge Sort in Python

This pull request is for issue number #33

Thanks a lot!


feat(isolated-declarations): improve the inference template literal

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3797  👈
#3793
#3792
#3791
#3790
#3789
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on  Graphite


Add release tag for S17 lab

Once we reach a reasonably complete state we should add a release tag for the S17 version of the lab.

Done.


Private branch plato 655 process the banner visibility

Adds a condition to show the banner, and the presence of a referrer query param. This is to ensure the banner is only shown when the user comes from outside the web app.
Ticket: https://contentful.atlassian.net/browse/PLATO-655

Can remove the don't merge label, as we're just merging into the feature branch right


You may need to run helm dependency build to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory

Describe the bug
I have created my own Helm dependency that I call in another Helm repository in the Chart.yaml. When I don't use the argocd-vault-plugin plugin (sidecar), argocd pull and execute my chart correctly. But when I use it, I get an error message
Unable to create application: application spec for abj is invalid: InvalidSpecError: Unable to generate manifests in h1: rpc error: code = Unknown desc = plugin sidecar failed. error generating manifests in cmp: rpc error: code = Unknown desc = error generating manifests: sh -c helm template $ARGOCD_APP_NAME -n $ARGOCD_APP_NAMESPACE ${ARGOCD_ENV_HELM_ARGS} . | argocd-vault-plugin generate -  failed exit status 1: Error: An error occurred while checking for chart dependencies. You may need to run helm dependency build to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: app-web Error: No manifests Usage: argocd-vault-plugin generate  [flags] Flags: -c, --config-path string path to a file containing Vault configuration (YAML, JSON, envfile) to use -h, --help help for generate -s, --secret-name string name of a Kubernetes Secret in the argocd namespace containing Vault configuration data in the argocd namespace of your ArgoCD host (Only available when used in ArgoCD). The namespace can be overridden by using the format :

yes but i m using sidecare
avp-helm.yaml: |
---
apiVersion: argoproj.io/v1alpha1
kind: ConfigManagementPlugin
metadata:
name: argocd-vault-plugin-helm
spec:
allowConcurrency: true
discover:
find:
command:
- sh
- "-c"
- "find . -name 'Chart.yaml' && find . -name 'values.yaml'"
generate:
command:
- sh
- "-c"
- |
helm template $ARGOCD_APP_NAME --include-crds . |
argocd-vault-plugin generate -
lockRepo: false
the init is only for argocd-cm right ?
onfigManagementPlugins: |

name: argocd-vault-plugin-helm
init:
command: [sh, -c]
args: ["helm dependency build"]
generate:
command: ["sh", "-c"]
args: ["helm template $ARGOCD_APP_NAME . --include-crds | argocd-vault-plugin generate -"]

I did what you asked me, I hope I didn't make any mistake, but I still have an error
Note: this command is run before any Helm templating is done, therefore the logic is to check
if this looks like a Helm chart
discover:
find:

  command:

    - sh

    - "-c"

    - "find . -name 'Chart.yaml' && find . -name 'values.yaml'"

init:
  command:

    - sh

    - "-c"

    - "helm repo update"

    - "helm dependency build"

generate:
# **IMPORTANT**: passing `${ARGOCD_ENV_helm_args}` effectively allows users to run arbitrary code in the Argo CD

# repo-server (or, if using a sidecar, in the plugin sidecar). Only use this when the users are completely trusted. If

# possible, determine which Helm arguments are needed by your users and explicitly pass only those arguments.

command:

  - sh

  - "-c"

  - |

    helm template $ARGOCD_APP_NAME -n $ARGOCD_APP_NAMESPACE ${ARGOCD_ENV_HELM_ARGS} . |

    argocd-vault-plugin generate -

lockRepo: false
error :
Unable to create application: application spec for abj is invalid: InvalidSpecError: Unable to generate manifests in h1: rpc error: code = Unknown desc = Manifest generation error (cached): plugin sidecar failed. error generating manifests in cmp: rpc error: code = Unknown desc = error generating manifests: sh -c helm repo update helm dependency build failed exit status 1: Error: no repositories found. You must add one before updating
thank you

any update ?

 Your running this command helm repo update helm dependency build . You have to split the commands with &&. If you are trying to add a helm repo you have to run helm repo add before the dependency update. Or you can vendor the chart. Similar issue https://github.com/argoproj-labs/argocd-vault-plugin/issues/175#issuecomment-892888255

For anyone searching, you can add and build the chart in the init block, like below.
     init:
        command:
          - sh
          - "-c"
          - |
            helm repo add chartname <chart-repo>
            helm dependency build  ```

on my side this config work:  (I had to add ;)
I still don't know where @shazinahmed found the syntax: chartname chart-repo !
  avp-helm.yaml: |
    ---
    apiVersion: argoproj.io/v1alpha1
    kind: ConfigManagementPlugin
    metadata:
      name: argocd-vault-plugin-helm
    spec:
      allowConcurrency: true

      # Note: this command is run _before_ any Helm templating is done, therefore the logic is to check
      # if this looks like a Helm chart
      discover:
        find:
          command:
            - sh
            - "-c"
            - "find . -name 'Chart.yaml' && find . -name 'values.yaml'"
      init:
        command:
          - sh
          - "-c"
          - |
            helm repo add chartname chart-repo;
            helm dependency build;
      generate:
        # **IMPORTANT**: passing `${ARGOCD_ENV_HELM_ARGS}` effectively allows users to run arbitrary code in the Argo CD
        # repo-server (or, if using a sidecar, in the plugin sidecar). Only use this when the users are completely trusted. If
        # possible, determine which Helm arguments are needed by your users and explicitly pass only those arguments.
        command:
          - sh
          - "-c"
          - |
            helm template $ARGOCD_APP_NAME -n $ARGOCD_APP_NAMESPACE ${ARGOCD_ENV_HELM_ARGS} . |
            argocd-vault-plugin generate -
      lockRepo: false

to be honest the "good" syntax is:
      init:
        command:
          - bash
          - "-c"
          - |
            chartname=$(helm dependency list | tr -s '[:space:]' | tail -n 1 | tr -s '[:space:]' | cut -f1);
            chartrepo=$(helm dependency list | tr -s '[:space:]' | tail -n 1 | tr -s '[:space:]' | cut -f3);
            helm repo add $chartname $chartrepo;
            helm dependency build;

This init command is only working for charts with exactly one dependency though. Additional ones are ignored. If the chart has none, then this will fail, since it will try to use the header line in the command (helm repo add NAME REPOSITORY (literally)).
Also I would not recommend to use the chart name as the name of the repository. You could have multiple dependencies from the same repository. And adding the same repo multiple times with different names will fail as well.
My take on this is the following:
init:
  command:
    - /bin/sh
    - -c
    - |
      #!/usr/bin/env bash
      set -Eeuo pipefail

      # add all repositories from this chart
      for REPO_URL in $(helm dependency list | tail -n+2 | tr -s '[:space:]' | cut -f3)
      do
        helm repo add $(echo "${REPO_URL}" | base64) "${REPO_URL}"
      done

      # finally downloading the charts dependencies
      helm dependency build

(the trailing ; are not necessary when you execute a multiline bash script)

I spend quite some time trying to set this plugin up for applications with dependencies. Turns out it's easier to not go through all these hoops to restore default behavior and instead use https://github.com/crumbhole/argocd-lovely-plugin which has a nice feature to chain plugins.
There's also a build of it which has this vault plugin bundled and ready to use out of the box.


Build iGeom separately from CGM

Currently, iGeom is built as part of the normal process of building CGMA (by default?).  It should be possible to decouple these, building iGeom as a standalone library, linked to an already build CGMA that is built without iGeom.

Consider just moving current itaps files to a different location and building against their full implementation and against a CGM that may have iGeom turned off???

Can @ejwilson3 comment on this - can we consider it closed?  either complete or deemed unnecessary?  Other comments?

I think this should be complete; I don't have it built as a standalone library, but have it inside of the mcnp2cad part of the plugin.


Tree SHA is not a tree object error

I am trying to create an empty commit in GitHub using go-github.
The following code:
func createHeadBranchForPR(ctx context.Context, baseBranch, repo, owner string,
	client *github.Client) (newBranch string, err error) {
	newBranch = createRandomBranchName()
	baseBranchRef, _, err := client.Git.GetRef(ctx, owner, repo, "heads/"+baseBranch)
	if err != nil {
		return "", err
	}
	latestCommitSHA := baseBranchRef.Object.GetSHA()
	// Create a new tree with no changes from the latest commit on the base branch
	newTree := &github.Tree{
		SHA: &latestCommitSHA,
	}
	currentTime := time.Now()
	newCommit := &github.Commit{
		Message: github.String("Test commit"),
		Tree:    newTree,
		Parents: []github.Commit{
			{
				SHA: github.String(latestCommitSHA),
			},
		},
		Author: &github.CommitAuthor{
			Name:  github.String(prCommitterAuthorName),
			Email: github.String(prCommitterAuthorEmail),
			Date:  &currentTime,
		},
		Committer: &github.CommitAuthor{
			Name:  github.String(prCommitterAuthorName),
			Email: github.String(prCommitterAuthorName),
			Date:  &currentTime,
		},
		SHA: &latestCommitSHA,
	}
	newCommitResponse, _, err := client.Git.CreateCommit(ctx, owner, repo, newCommit)
	if err != nil {
		return "", err
	}
	// Create a new branch based on the new commit
	newBranchRef := &github.Reference{
		Ref:    github.String("refs/heads/" + newBranch),
		Object: &github.GitObject{SHA: newCommitResponse.SHA},
	}
	_, _, err = client.Git.CreateRef(ctx, owner, repo, newBranchRef)
	if err != nil {
		return "", err
	}
	return newBranch, nil
}

Fails in
newCommitResponse, _, err := client.Git.CreateCommit(ctx, owner, repo, newCommit)

with
422 Tree SHA is not a tree object []

Does the error make sense since this is a tree created from a valid commit sha or is this a bug?

Might this comment be relevant from the provided example?
https://github.com/google/go-github/blob/master/example/commitpr/main.go#L18-L20
// Note, for this to work at least 1 commit is needed, so you if you use this
// after creating a repository you might want to make sure you set `AutoInit` to
// `true`.

The repository already exists and I am (trying to) create an empty commit from master, so not sure if this applicable.

The repository already exists and I am (trying to) create an empty commit from master, so not sure if this applicable.

In that case, have you tried running the provided example just to make sure all your scopes are set appropriately?
I don't have time to try out your example yet... maybe by this weekend I can give it a shot.

Cool thanks for taking the time even to respond. I will try to run the example end to end and if you have any updates pls do share.

This seems to address the issue.


Read package ID and activity name from .apk for Gradle-based builds.

The gradle build scripts can be configured to output different
application IDs for different build types, so we need to examine the
built .apk to figure out the name of the package and activity.
Re-landing this change, updated to only get information from the .apk
if it exists.
Since the tools create an AndroidApk instance early, even before we've
actually built an .apk, we have to create a new instance after building,
so we can start the right app/activity.
Fixes #8327.


directory structure organization

Repo directory structure reorg as per shortcut 82412 for discussion and consideration purposes.

A few comments about some files that have been copied in. So far it looks like this is just a direct copy of the examples repo from the starter repo. I imagine some things can be removed and the initial scaffolding done in #1 doesn't seem to be here.
Also it may be helpful to add an example for the first pattern, so we can have an understanding of what that should look like on future PRs? What's documented in applications/determined-ai/README.md I think would qualify as patterns.

Is that a pattern or an application?  My understanding is that a pattern is a snippet or subset of a solution that can be reused.
I believe the intention here for this PR is to propose a directory so we can iterate on it.

Is that a pattern or an application? My understanding is that a pattern is a snippet or subset of a solution that can be reused.

If i'm understanding correctly I think that each individual example i documented in the determined README would be a pattern use case.

If i'm understanding correctly I think that each individual example i documented in the determined README would be a pattern use case.

@diamonwiggins yea it could be, no hard rule that it has to be. The fact that they're all documented in the examples seems like a reasonable way to handle it as well. I honestly think we'll make the decision by which direction you come at it from. If you write an entire app, put the notes in it's readme. If you just have one pattern to document and it's not reasonable to write a while app just put it in patterns.

@drohnow PR only needs to slight directory structure modification highlighting the github workflow pattern. After that, feel free to merge .


feat: support notification template

related issue: https://github.com/grafana/grafana-operator/issues/1736

Thanks for the contribution! Can you use the common fields introduced in https://github.com/grafana/grafana-operator/pull/1765? I'd also like to wait for https://github.com/grafana/grafana-operator/pull/1770 to be merged just so we won't need to do this work again for notification templates as well

I'm also in favour of having this PR rewritten based on #1765 and #1770 (the latter is still in progress).

Sure, I'll do that.

Wow!!! This is awesome @chenlujjj!
We really need this and I was actually thinking about opening an issue to ask if I can contribute it myself.
Awesome thanks!

Any ETA for this nice feature to be released?
Many thanks!

Hi @CarlosLanderas ,I'm waiting for https://github.com/grafana/grafana-operator/pull/1770 to be merged, so that I can rewrite this PR on top of it.

Perfect @chenlujjj , thanks!

@chenlujjj we just merged #1770 so if you have the time to rebase ontop of that, that'd be great!

Thank you @Baarsgaard , I've updated the code based on your review suggestions and implementation of grafana folder controller.

@Baarsgaard Thanks for your patient review. I resolved all the comments.
I've got one question: in the following code
	if err != nil || len(instances) == 0 {
		setNoMatchingInstancesCondition(&notificationTemplate.Status.Conditions, notificationTemplate.Generation, err)
		meta.RemoveStatusCondition(&notificationTemplate.Status.Conditions, conditionNotificationTemplateSynchronized)
		notificationTemplate.Status.NoMatchingInstances = true
		controllerLog.Error(err, "could not find matching instances", "name", notificationTemplate.Name, "namespace", notificationTemplate.Namespace)
		return ctrl.Result{RequeueAfter: RequeueDelay}, err
	}

does it matter to return ctrl.Result{RequeueAfter: RequeueDelay}, err or return ctrl.Result{RequeueAfter: RequeueDelay}, nil ? I saw different implementations in different resource controllers?

@Baarsgaard Could you please take another review, thank you.

@chenlujjj Both #1801 and #1804 were merged, you can now continue, and I will not be opening any more PRs that interfere with this!

Thank you @Baarsgaard .
Hi @theSuess  @weisdd  Can anyone of you have a review ?


Move from Travis to CircleCI

This PR addresses issue #265 raised by @kgodey regarding the replacement of Travis with CircleCI.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

So far this PR only runs linter tests. Work on adding the remaining tests is underway.

Is this PR still valid? Want help?

@rodrigondec Sorry work on this PR has lapsed. Feel free to take it up!

I'm going to close this for now since work has stopped; whoever takes this up next can build off of this PR.


Trev8939/basemap styles all

PR to update the last of our old basemaps to the new basemapstyles

I'll assign myself to this PR.

Moved the branch merge to v.next instead.

Moved the merge branch to v.next from main


add schema.exists

Codecov Report
Patch coverage: 90.95% and project coverage change: -0.20 :warning:

Comparison is base (8f7e154) 96.14% compared to head (1aeafb7) 95.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   96.14%   95.95%   -0.20%
==========================================
  Files          61       64       +3
  Lines        7295     7460     +165
==========================================
+ Hits         7014     7158     +144
- Misses        281      302      +21

Flag
Coverage Δ

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

integration/test_timeout.py
100.00% <ø> (ø)

weaviate/backup/backup.py
100.00% <ø> (ø)

weaviate_grpc/weaviate_pb2.py
40.74% <40.74%> (ø)

weaviate_grpc/weaviate_pb2_grpc.py
63.15% <63.15%> (ø)

weaviate/connect/connection.py
90.53% <82.19%> (+0.47%)
:arrow_up:

weaviate/config.py
83.33% <83.33%> (ø)

weaviate/schema/crud_schema.py
79.42% <84.61%> (+0.41%)
:arrow_up:

weaviate/gql/multi_get.py
86.36% <86.36%> (ø)

weaviate/client.py
98.55% <91.66%> (+0.24%)
:arrow_up:

integration/test_authentication.py
89.34% <92.85%> (+0.25%)
:arrow_up:

... and 19 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Which release is this going to be part of? Used 3.17.1 but got the error that schema doesn't have the method exists.

The next one, probably 3.18.0

Checking again: This should already be included in 3.17.0 and works locally

I checked as well and it works starting version 3.17.0.


add compatibility with older versions of the docker daemon (pre 1.9.0)

image build context now contains the docker clients for the last two versions of docker: 1.9.0 and 1.9.1
if the docker daemon does not match one of those versions, a small program (gosetup) will download the compatible docker client and install it when the container is started

fixes #21

@gdevillele in the Dockerfile, I don't think this is correct: ADD ./docker_linux_x64/docker /bin/docker
You should now copy all binaries from docker_linux_x64 to /bin, no?

Also in go/src/goproxy/main.go, I would add a comment about DOCKER_VERSION_TO_USE variable, and use a name like REMOTE_API_VERSION, because that's what it is.
Same in go/src/gosetup/main.go, use remoteApiVersion instead of dockerVersionNeeded.

Remote API version != Docker Version :disappointed:
IIRC, Docker 1.9 uses remote api version 1.20

I agree, since we need to get the client version matching the daemon, I think I will continue to rely on the Docker Version... WDYT? cc @aduermael @dave-tucker

@gdevillele plain old DockerVersion works for me

Some minor nits but overall, LGTM.
I wouldn't say no to a test or two for the logic in gosetup though 😉

I agree about the camel case, thanks for the update @gdevillele!
We should quickly add some integration tests (golint, govet...), but that should be another issue.

And I agree about about Remote API version != Docker Version statement.
So, LGTM! :+1:

Oh no wait, there are still some variables that are not camel cased like DOCKER_DAEMON_VERSION. @gdevillele

@dave-tucker docker client is now downloaded (ADD get.docker.com [...])
@aduermael I fixed variable names. Also I agreed that go validation and tests are another issue.
I think this PR is good to be merged...

LGTM

LGTM!
It's actually pretty cool, I can't use the CLI using a machine with Docker 1.8.2, but Dockercraft works! :p

fwiw, also see https://github.com/docker/docker/pull/15964, which is implementing a DOCKER_API_VERSION env var, to allow communicating with a different daemon version.


Extra vertical whitespace padding above h1 in theme v0.10.0

I just noticed that numpydoc's documentation looks strange with the latest pydata-sphinx-theme. I built the docs locally and can confirm that the extra vertical whitespace above the main title is present w/ v0.10.0 and later.
I went ahead and bisected which ID'ed #861 as the PR which introduced the behavior change.

+1 to revert #861. @choldgraf OK by you? You're the one who oversaw that one.
crossref to #904 which I think was also caused by #861

That PR did a bunch of stuff right? Can we just revert the changes that added a UI bug?

Any issues with #861 can be addressed separately. This issue can be closed with the 0.11 release and https://github.com/numpy/numpydoc/pull/434/commits/4d694446e55fae31e164f69296de8c4da5e433d7.

It'd be nice not to have to annotate the rst file in the project with metadata in order to prevent the extra whitespace, so a solution within the theme itself would be preferable longer-term. Just wanted to mention that since this issue was closed!

It's not clear to me what else needs to be done to resolve this - @rossbar or @jarrodmillman can you please clarify the steps we need to take to fix this problem?


nodejs-16_x: 16.12.0 -> 16.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for nodejs-16_x is: "Event-driven I/O framework for the V8 JavaScript engine"
meta.homepage for nodejs-16_x is: "https://nodejs.org"
meta.changelog for nodejs-16_x is: "https://github.com/nodejs/node/releases/tag/v16.13.0"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0/bin/node passed the binary check.
/nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0/bin/npx passed the binary check.
/nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0/bin/corepack passed the binary check.
/nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0/bin/npm passed the binary check.
4 of 4 passed binary check by having a zero exit code.
2 of 4 passed binary check by having the new version present in output.
found 16.13.0 with grep in /nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0
found 16.13.0 in filename of file in /nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0

Rebuild report (if merged into master) (click to expand)

25 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
6 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
6 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
lumo
nodejs-16_x
nodejs-slim-16_x
nodejs-slim_latest
nodejs_latest
peertube
wasm-bindgen-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nodejs-16_x https://github.com/r-ryantm/nixpkgs/archive/b59803b96d4f794994e64587ccaf95e3d5225cf8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0
ls -la /nix/store/4q78myv2km8zinw9pk3cxp74c18zc5bj-nodejs-16.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

lumo
nodejs-16_x
nodejs-slim-16_x
peertube
wasm-bindgen-cli

Maintainer pings
cc @cillianderoiste @gilligan @cko @marsam for testing.

FYI the build failed on x86_64-darwin, though it looks like an issue with the build machine.


dashboard/config/linux: disable CONFIG_STACKPROTECTOR for KMSAN

Linux v6.4-rc1 built with Clang versions <= 16 with stack protector enabled panic with the following stack trace:
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: start_kernel+0xd8a/0xd90 CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.3.0-rc1-00042-g9ea7e6b62c2b-dirty #106 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014 Call Trace:

__dump_stack lib/dump_stack.c:88
dump_stack_lvl+0x1bc/0x250 lib/dump_stack.c:106
dump_stack+0x1e/0x20 lib/dump_stack.c:113
panic+0x4cd/0xc10 kernel/panic.c:340
__stack_chk_fail+0x18/0x20 kernel/panic.c:759
start_kernel+0xd8a/0xd90 init/main.c:?
x86_64_start_reservations+0x2e/0x30 arch/x86/kernel/head64.c:556
x86_64_start_kernel+0x118/0x120 arch/x86/kernel/head64.c:537
secondary_startup_64_no_verify+0xcf/0xdb arch/x86/kernel/head_64.S:358

https://github.com/ClangBuiltLinux/linux/issues/1815 describes the problem, which is fixed on the Clang side
(https://reviews.llvm.org/D147975), but before the fix reaches syzbot we'll have to keep the stack protector disabled.

Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md

does anything need to be reverted here now that the fix has landed?


Visual differences between PixiJS v4 and PixiJS v5 with resolution of 0.75

When upgrading from v4 to v5, I'm seeing visual rendering differences when the resolution is less than 1. This is most noticable when it's set to 0.75, and is throwing off some visual aspects of the games.
v4:

v5:

You can see things very slightly move, like the text. And the sprites then also move very slightly; in this case messing up the tiling effect.
Some pixi playgrounds to demonstrate this
v4: https://www.pixiplayground.com/#/edit/i9g9G07R5FOkkC3ieRbP6
v5: https://www.pixiplayground.com/#/edit/A2RzqbjAKoxoQRzVMNND4
Change the resolution to 1 or above, and both playgrounds look identical. But take it below 1, and there are differences.
This only occurs on the WebGL Renderer. The Canvas Renderer is uneffected.
Environment

pixi.js version: 5.2.2
Browser & Version: Chrome 78
OS & Version: Windows 10

Ok, doing some hunting, and it's because for roundPixels
v4: for each value something like: float32View[index] = ((vertexData[0] * resolution) | 0) / resolution;
v5: vertexData[i] = Math.round(vertexData[i]);
If I hack together the v5 to do vertexData[i] = Math.round((vertexData[i] * 0.75 | 0) / 0.75); then it's a lot lot closer; close enough for me, anyway. The problem is, calculateVertices doesn't have access to the renderer, so doesn't have access to the resolution ... and it's not all routes to calling calculateVertices have an instance of the renderer as a param in the first place.
Any ideas?

Yes, I've changed that, I think I and @GoodBoyDigital decided that it wasnt that important.
Turns out it is :)
For temp fix, you can override Sprite.prorotype.calculateVertices that way it uses your global resolution to round stuff.


Rapid increase in total node count after indexing

Probably all messages are being added to graph node build queue, though after it builds, graph is normal. It's just a lot of unnecessary resolving that could he fixed with  a simple check.
https://github.com/user-attachments/assets/ca419c78-f4c7-4771-a503-e708a3b6eac3


Infinite Streaming Fail with sever API request error Error: 14 UNAVAILABLE: 408:Request Timeout

I am running infiniteStreaming.js and after several minute of transcription I am getting below error.

290000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
580000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
870000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
1160000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
1450000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
1740000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
2030000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
2320000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
2610000: RESTARTING REQUEST
API request error Error: 14 UNAVAILABLE: 408:Request Timeout
API request error Error: Cannot call write after a stream was destroyed
2900000: RESTARTING REQUEST

Hi @abramovi  — are you using the infiniteStreaming.js as is or are you adding custom logic to the sample? If you can please provide a bit more information, including a code snippet, that'd be useful.

Thank you for filing this issue. We asked some clarifying questions a week or more ago and never heard back from you. We are unable to proceed with this issue until then, so we are closing it. Please feel free to re-open this issue with more information.


Checksums on plugins.gradle.org are not always accurate

Expected Behavior
The checksum file kotlin-gradle-plugin.pom.sha1 (plugins.gradle.org) should match the file content for kotlin-gradle-plugin.pom (plugins.gradle.org)
Current Behavior
The checksum file kotlin-gradle-plugin.pom.sha1 (plugins.gradle.org) is identical to the checksum file kotlin-gradle-plugin.pom.sha1 (jcenter). However, the POM files themselves differ. jcenter is consistent with itself, whereas plugins.gradle.org is not self-consistent. jcenter and maven-central also agree with each other.
Also worth noting is that kotlin-gradle-plugin.pom.sha1 (plugins.gradle.org) actually redirects to kotlin-gradle-plugin.pom.sha1 (jcenter). So jcenter is internally consistent, but plugins.gradle.org is not.
I can't tell which piece is wrong: is the problem that the POM file doesn't agree with the other repositories or is the problem that the checksum isn't consistent with the file?
Context
I'm trying to mirror gradle plugins for use in an environment with no internet access. I'm using Artifactory with the default checksum policy of "generate if absent". Here's the documented behavior of that option. I'd rather not turn off checksum verification, since it's generally good.
Steps to Reproduce (for bugs)

Download kotlin-gradle-plugin.pom (plugins.gradle.org)
Compute a SHA-1 sum of that file
Compare to the content of kotlin-gradle-plugin.pom.sha1 (plugins.gradle.org)

For me, the computed SHA-1 is b8a482a948be42a18547b5fcc6f75411e30608b2, whereas the advertised SHA-1 in 2f497fbce005e703e500f7e769cb3a939a7194ca.
Your Environment
Nothing relevant.

The problem is that the plugin portal does not provide checksums at the moment, but it falls back to jcenter for artifacts it can't find. This means it'll also fall back for checksums if jcenter has them. We are currently fixing the missing checksums, see #3799

The plugin portal now provides checksums properly. #3799 has been fixed. Please let me know if you see any further issues.


Improve Ui for cards

Description
Cards for post look really dull or I should say simple. We can design them better with some border/border radius etc. Align the contents to the left similar to a Instagram post
Screenshots

Additional information
No response

hi @narayan954  i can take this up. please assign me

sure @najeebkp


Three Column Layout doesn´t expand on Andriod 4.2

Hej there! First of all, thanks for the great work you did here!
I´m having some problems with the three column layout on my LG G2:

Any idea what might be wrong? Is it related to the Android EMail Pinch-To-Zoom feature?
Code:

									CONTENT

									CONTENT

									CONTENT

We've updated to th's in v2, which should address Android responsive issues. We recommend using v2, however we're more than happy to merge a PR for our v1.0.0 request.
Thanks!


Fix TODOs in StaffScreenTest

We can run the test by clicking the "Run" button on the left side of Android Studio.

https://github.com/DroidKaigi/conference-app-2024/blob/0a15d6b930e981217645ecd0d1be5bde4d412f22/feature/staff/src/androidUnitTest/kotlin/io/github/droidkaigi/confsched/staff/StaffScreenTest.kt#L53
You can refer to this PR to fix this issue
https://github.com/DroidKaigi/conference-app-2024/pull/304/files

I've finished other tasks, so I'd like to start working on this one. 🙋

Thanks! Assigned 👍


CI: Only run workflows on push to master or stable

Currently when you open a PR, the Build and Lint workflows run twice because they run on any push event in addition to the pull request event. Instead, limit the push events to the master or stable branch.

Notice how this PR has 4 workflows, but #584 has 6 workflows with the Build and Test workflows repeated.


Please add database diagramming

Issue Type: Feature Request
Please add database diagramming with the option to just show primary and foreign keys.
Thank you.
SQL Operations Studio version: sqlops 0.30.6 (df7e3ec7d52a82febee5b597a1019cabf021b883, 2018-06-19T21:45:43.589Z)
OS version: Windows_NT x64 6.1.7601

This is a duplicate of #94. I'll close this as the majority of feedback was on this existing issue. Thanks for raising.


[ENH]: HNSW max_seq_id persistence

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

We persist the HNSW max_seq_id when the index is written; this will help with WAL cleanup and will not require loading the HNSW index before cleanup.

Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python

Documentation Changes
N/A

This is already persisted as part of the "PersistentData" in the persistent hnsw segment isn't it?

that is true, but we do have to load the metadata to find out the max_seq_id, so I thought, why not keep it in the WAL max_seq_id table?

@HammadB, have a look. I think this should work.
The pickle file metadata is now moved to segment metadata, including the dict mappings between id - label - seqId (dumped as json tuple). Performance is on par with pickle dumps/loads.
WIP - tests for migration from pickle file (it works but it has to be tested)


Update DevHome docs to remove references to deprecated snap feature

Update DevHome docs to remove references to deprecated snap feature.

Learn Build status updates of commit 7804a5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

uwp/xbox-apps/dev-home.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ca09273:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

uwp/xbox-apps/dev-home.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Handled in private repo


Go to declaration does not work after update

Goto declaration does not work when i use cmd+leftMouseClick. I have tried using F12 also but it does not take me to any declaration weather a class, function or a variable. Please help me. I have Unity and VS on my system. Is this causing the problem?

Please file this against the C# extension


optimize: optimize decode exception

Ⅰ. Describe what this PR did
optimize: optimize decode exception
fix #1700  #2451 #2555 #2570 #2677 #2729 #3648
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
telnet <IP_ADDRESS> 8091
input "xxxxxxxxxxxxxxxxxxxxxx"
Ⅴ. Special notes for reviews

Codecov Report

Merging #3895 (8ddff1e) into develop (a1ae790) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #3895      +/-   ##
=============================================
- Coverage      40.80%   40.71%   -0.10%
  Complexity      3057     3057
=============================================
  Files            681      682       +1
  Lines          22872    22850      -22
  Branches        2839     2790      -49
=============================================
- Hits            9333     9303      -30
+ Misses         12669    12652      -17
- Partials         870      895      +25

Impacted Files
Coverage Δ

.../java/io/seata/core/exception/DecodeException.java
0.00% <0.00%> (ø)

...ta/core/rpc/netty/AbstractNettyRemotingServer.java
0.00% <0.00%> (ø)

.../io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java
0.00% <0.00%> (ø)

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0.00%> (-9.53%)
:arrow_down:

...otobuf/convertor/BranchReportRequestConvertor.java
90.90% <0.00%> (-9.10%)
:arrow_down:

...obuf/convertor/BranchRollbackRequestConvertor.java
92.00% <0.00%> (-8.00%)
:arrow_down:

...otobuf/convertor/GlobalBeginResponseConvertor.java
92.59% <0.00%> (-7.41%)
:arrow_down:

...otobuf/convertor/GlobalCommitRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

...otobuf/convertor/GlobalStatusRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

...obuf/convertor/GlobalRollbackRequestConvertor.java
93.75% <0.00%> (-6.25%)
:arrow_down:

... and 31 more

LGTM


Add dependencies.io github workflow to upgrade cairo, freetype etc

This is the github workflow for dependencies.io originally contributed by @davegaeddert
Adding now, even though workflows are confusing me a bit - especially under what conditions they actually appear in the actions tab.
When this works, there should be an option under "Actions" to run this, via workflow dispatch.
This is also set to run once a day.
You will need to get an account with dependencies.io, and can start an evaluations, they are up for helping out open source so it's worth contacting them - I got a key for open source work.

I'll leave this open as a reminder until I have time to go through all the additional steps it requires.


[Bug] It is judged to be a malicious app and cannot be installed

Device
Phone/Tablet
Device name
Samsung Galaxy Z Flip 5
Android Version
14
App version
0.16.2
Script version
4.7.1
WebView name and version
No response
Reproduction Steps
When I try to install it, it is not installed because it is a malicious app suspected of voice phishing.

It's a false-positive report: https://www.virustotal.com/gui/file/fc4e43b13d893bbb0ba2b1a9f0dd20dd775fbbbb25141d3646ed30b18239485e


Add support for reportValidity on form elements

Adding support for form.reportValidity() as described here.

I'd suggest using every instead of reduce to make it more readable.

The polyfill for this plugin is tightly scoped to the validity property to keep file size down. As such, this PR is out-of-scope. There are other polyfills that provide broader JS validity support (with a larger footprint).


Test for ruby head

Test for most recent ruby version but allow it to fail.

Looks like a good idea, warns us of impending catastrophes in upcoming Ruby versions :)


query service

Add a strawman hack query service

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: mansu:white_check_mark: vthacker:x: Suman KarumuriSuman Karumuri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Guard new-ish formats in an #ifdef to not break older vulkan.h such as Android uses.

Android ships VK_HEADER_VERSION as old as 28, which chokes on
VK_FORMAT_*_2PLANE_* and VK_FORMAT_*_3PLANE_*

I would like to note this repo already has (updated) [https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/tree/master/include/vulkan](Vulkan header). I assume those are used during build?

Closing this PR. We generally keep the NDK vulkan header reasonably up-to-date but if it's lagging you can use the latest header from this repo. No need to customize core repo based on old header versions. If you're specifically limited to an older header then you'll have to get older versions of the layers or customize them locally for your particular header.

@tobine I'm not sure how one would use a newer header with new format values, then pass them to the Android Vulkan entrypoint and it would work.

@volcanoauthors It would work normally...? (Assuming you enable the required extension)
I am not exactly sure what you are asking.


rofimoji: init at 4.3.0, wtype: init at 2020-09-14

Motivation for this change
rofimoji is a unicode selector using Rofi. Now with Wayland support. Wayland support depends on wtype.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Okay, these expressions look all good. The issue now is we need to adhere with the commit policy.
The headers of the commits are good, it's just they need to be individual like
maintainers: add JustinLovinger
rofimoji: ...
wtype: ...

Could you fix this by doing a git reset @~1 --soft and re staging and committing them separate?

Okay, these expressions look all good. The issue now is we need to adhere with the commit policy.
The headers of the commits are good, it's just they need to be individual like
maintainers: add JustinLovinger
rofimoji: ...
wtype: ...

Could you fix this by doing a git reset @~1 --soft and re staging and committing them separate?

Done :)

@JustinLovinger Just merged. Thanks for the contribution :sparkles:


Optimise The recent workflow & add testing coverage

Reason/Context

The current UI Testing Workflow takes 10 minutes to run, the task now is to improve this workflow and reduce the running time .
Add a suite for testing coverage

Description
Please try answering few of those questions

Optimise workflow , using either Cypress Parallel ( or research something else )
No this will not be a breaking change

any update on this? @reachaadrika @akshatnema @derberg

@AnimeshKumar923 currently we are working on it

@sambhavgupta0705 Got it. Thanks for the update.

Is it still relevantt to work on it ?

yes @Vishal2002
You may work on it

Going through the component tests for the website, some more work can be done to improve on them. Some of the issues I want to work on include:

reducing test flakiness
pair more tests together; The tests are written like unit tests which less efficient. Cypress runs a bunch of cleanup and setup functions btw it blocks so they recommend not breaking tests up unnecessarily.
make better use of cypress commands
expand test scenarios

@anshgoyalevil @sambhavgupta0705, can I start working on these?

@SalihuDickson We are trying to phase-out Cypress by migrating AsyncAPI website to TypeScript.
I don't think we need this feature implemented as of now

Understandable, @anshgoyalevil. Thanks for getting back to me. Only wish you had told me before I spent all that time rewriting the tests😅. If I may ask, what other testing frameworks are in consideration to replace cypress.

status? @sambhavgupta0705 @anshgoyalevil

closing this as not planned


python312Packages.bloodyad: 2.0.8 -> 2.1.1

Diff: https://github.com/CravateRouge/bloodyAD/compare/refs/tags/v2.0.8...v2.1.1
Changelog: https://github.com/CravateRouge/bloodyAD/releases/tag/v2.1.1

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 361389

x86_64-linux

:white_check_mark: 6 packages built:

autobloody
autobloody.dist
python311Packages.bloodyad
python311Packages.bloodyad.dist
python312Packages.bloodyad
python312Packages.bloodyad.dist


Invalid imagePullSecrets using Vault provider

Describe the bug
An imagePullSecret created using the docs at https://external-secrets.io/v0.8.5/guides/common-k8s-secret-types/#dockerconfigjson-example does not seem to be working:
The following secret that has been created manually using kubectl works:
$ kubectl -n my-ns get secret harbor-test -ojsonpath='{.data.\.dockerconfigjson}' | base64 -d
{"auths":{"registry.mysite.com":{"username":"robot$repo-read","password":"xxxx","auth":"yyyy"}}}

But the following which has been created using the Vault operator does not:
$ kubectl -n my-ns get secret harbor-image-pull -ojsonpath='{.data.\.dockerconfigjson}' | base64 -d
{"auths":"{\"registry.mysite.com\":{\"username\":\"robot$repo-read\",\"password\":\"xxxx\",\"auth\":\"yyyy\"}}"}

To Reproduce
Steps to reproduce the behavior:
With a vault-backend SecretStore pointing to a Vault server:

Manifests:

apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: pull-secret
  namespace: my-ns
spec:
  data:
  - remoteRef:
      key: pull-secret
    secretKey: secret
  refreshInterval: 1m
  secretStoreRef:
    kind: SecretStore
    name: vault-backend
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    name: harbor-image-pull
    template:
      data:
        .dockerconfigjson: '{{ .secret }}'
      engineVersion: v2
      mergePolicy: Replace
      type: kubernetes.io/dockerconfigjson

This has been taken from the docs
Command used to push the secret inside vault:
kubectl create secret docker-registry --dry-run=client -ojsonpath='{ .data.\.dockerconfigjson}' --docker-server='registry.mysite.com' --docker-username='robot$repo-read' --docker-password='xxxx' pull-secret | base64 -d | jq -c '.auths' | tr -d $'\n' | vault kv put -address http://<IP_ADDRESS>:8200 my-store/pull-secret auths=-

provide the Kubernetes and ESO version

Kubernetes version: RKE2 v1.23.17+rke2r1
ESO version: 0.8.5
Expected behavior
ImagePullSecrets generated using the vault operator matches the one created manually, perhaps without the string escaping sequences?

A setup that works for the Vault operator vault is to use Base64 encoding:
kubectl create secret docker-registry --dry-run=client -ojsonpath='{ .data.\.dockerconfigjson}' --docker-server='registry.mysite.com --docker-username='robot$repo-read' --docker-password='xxxx' pull-secret | vault kv put -address http://<IP_ADDRESS>:8200 paas/pull-secret .dockerconfigjson=-

A working yaml file:
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: pull-secret
  namespace: my-ns
spec:
  dataFrom:
  - extract:
      conversionStrategy: Default
      decodingStrategy: Base64
      key: pull-secret
  refreshInterval: 1m
  secretStoreRef:
    kind: SecretStore
    name: vault-backend
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    name: harbor-image-pull

Your .secret is a string, which gets rendered as-is.
{"auths":"{\"registry.mysite.com\":{\"username\":\"robot$repo-read\",\"password\":\"xxxx\",\"auth\":\"yyyy\"}}"}
         ^ string starts

This should be an object, not a string.
You can probably just wrap it as follows:
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: pull-secret
spec:
  data:
  - remoteRef:
      key: pull-secret
      property: auths
    secretKey: secret
  refreshInterval: 1m
  secretStoreRef:
    kind: SecretStore
    name: vault-backend
  target:
    creationPolicy: Owner
    deletionPolicy: Retain
    name: harbor-image-pull
    template:
      data:
        .dockerconfigjson: '{"auths":{{ .secret }}}'
      engineVersion: v2
      mergePolicy: Replace
      type: kubernetes.io/dockerconfigjson


buttons in dropdowns

I would assume the class would be btn btn-link or btn btn-text-link. This is blocking Atlas RTM

should there be a dedicated btn-dropdown class? or should it just work if you have a btn in a dropdown

fixed it this way in atlas... we can fix it how we like here are and then remove whats in atlas whats we release the next version of cyclops
  .dropdown-menu .btn.btn-link {
    display: block;
    padding: 3px 20px;
    clear: both;
    font-weight: normal;
    white-space: nowrap;
    text-decoration: none;
    color: #cacaca;
    opacity: .8;

    &:hover {
      opacity: 1;
      color: white;
    }
  }


Added Step Contour from FANTASTIC toolbox

Implemented the Step Contour features from FANTASTIC (Müllensiefen, 2009) https://www.doc.gold.ac.uk/isms/m4s/FANTASTIC_docs.pdf
Takes an input list of pitches (ints) and durations (floats) and normalizes them to an array containing 64 ints. These ints are the pitch values, repeated proportionally to their duration in the inputs. Script contains multiple functions capturing features of this contour representation.
TODO: fix long lines in a way that doesn't break the doctest

Some good stuff, some things to follow up on though!


Frequent random WebSocket disconnects

Describe The Bug:
The plugin frequently disconnects from the SysAP with error 1006 and immediately reconnects.
To Reproduce:
Wait.
Expected behavior:
No random reconnects without apparent reason.
Logs:
[7/22/2023, 9:43:31 AM] [free@home] Websocket to System Access Point was closed with code 1006:
[7/22/2023, 9:43:31 AM] [free@home] Attempting to reconnect in 200ms [1/10]
[7/22/2023, 9:43:31 AM] [free@home] Connection closed
[7/22/2023, 9:43:31 AM] [free@home] TLS certificate verification is disabled! This poses a security risk, activating certificate verification is strictly recommended.
[7/22/2023, 9:43:31 AM] [free@home] Connection opened

Plugin Config:
{
    "name": "free@home",
    "host": "192.168.xxx.xxx",
    "user": "xxx",
    "password": "xxx",
    "tlsEnabled": true,
    "disableCertificateVerification": true,
    "verboseErrors": false,
    "experimental": false,
    "ignoredChannels": [
        "ABB6B6161344/ch0011",
        "ABB6B6161344/ch0012",
        "ABB6B6161344/ch0013"
    ],
    "platform": "FreeAtHomeLocalApi"
}

Screenshots:
N/A
Environment:

Plugin Version: v1.6.0
Homebridge Version: v1.6.1
Node.js Version: v16.16.0
NPM Version: 8.11.0
Operating System: hb-service on Synology DSM 7

I spent some time yesterday trying to understand what is happening yesterday:

All my appplications using the free@home local API client are affected.
When a disconnect happens, all clients are disconnected at the same time. I've reproducibly observed clients on separate machines disconnected within a couple of milliseconds.
I tried to activate logging on the SysAP. It informs me that to activate logging, the "application has to be restarted". I don't know which application it refers to.
After that there were no reconnects at all for a couple of hours. Then it started again with the previous frequency.
This leads me to believe that the origin might not be in the local API client after all.
When the disconnect happens, there is no error happening. It's just a disconnect. The reason is always empty.
In my logs I've seen a number of events related to a Sonos device close to reconnects. I need to investigate further to see if it's related of just coincidence.

The reconnects are still there, also with the current firmware version released after the issue was first observed. I don't have any leads as to what is causing the behavior and the trivial workaround is to reconnect when the connection is closed. So I'll close the ticket and will re-open if the issue becomes actionable.


Move examples from deprecated @rules_cc//cc:find_cpp_toolchain -> @bazel_tools//tools/cpp:toolchain_utils.bzl

Hey wonderful Bazel folks,
I'd been following this example (linked from https://docs.bazel.build/versions/main/integrating-with-rules-cc.html). While doing, I happened to notice that the code was still calling the deprecated find_cpp_toolchain. This threw me for a quick loop on Bazel rolling, so I figured I'd toss up a quick PR to fix it. See discussion below about @bazel_tools.
Deprecation comment here: https://github.com/bazelbuild/rules_cc/blob/main/cc/toolchain_utils.bzl
Thanks for all you do!
Chris
(ex-Googler)

Oh, err, maybe you'd want to point to the bazel_tools one instead because that's what the docs reference, rather than rules_cc?
I'm unclear whether the current philosophy is pointing people to rules_cc or bazel_tools. Sorry this isn't the slam dunk I thought it was.

I returned to this and decided that since the docs and the rest of the toolchain code pretty uniformly referenced @bazel_tools instead, I'd add a commit standardizing around @bazel_tools. Seems right to me, but the first commit is still there if you'd rather merge it, instead.

Thanks for getting to these, @oquenchil! Cheers
(lmk if you need anything more before merging)

Yay! Thanks @oquenchil


Create New Terminal Integrated Terminal (With Profile) command appears multiple times in the command palette

Testing #129416
I noticed this while creating terminal using extension contributed profiles.

/duplicate https://github.com/microsoft/vscode/issues/129514


Is it possible to change the SecAuditLogStorageDir variable so that the logs are sorted by vhost?

Hello.
Default SecAuditLogStorageDir = /opt/modsecurity/var/audit
and all logs are written together, regardless of vhost.
Is it possible to sort by vhost?
/opt/modsecurity/var/audit/site1.com/
/opt/modsecurity/var/audit/site2.com/
...
Thx.

Hi @vukitoso,
I can consider this is a feature request.
Beside you sent requests like this, please keep it mind that this module is not ready for production.

This module is built from https://github.com/owasp-modsecurity/ModSecurity-apache?

No. This module is built from https://github.com/owasp-modsecurity/ModSecurity, but from the branch v2/master.


LeanMapper entity action param condition inverted

At the method getLeanMapperEntityProperty, specifically the row 190, the condition seems to be inverted.
The code roughly goes like this: "If property exists, throw exception if strict or return null, otherwise resolve property".
I'd create a pullrequest but rn I gotta scoff to work. I'll hopefully get back to it later today.

Thx.


fix unittest failures in debug build

trivial

I'm not really understanding why the unit test was added, looked in history, and you added it when the new AA implementation was done. I also don't understand why this passes in release mode and fails in debug mode.
So I'm inclined to just accept this PR on that basis :)
Can you give some explanation behind the adding of the test?
I fully agree with the numToString change, in fact, I think the original is 2 elements too short, should have been a +1 instead of a -1.

I agree with the numToString change, though that function is still wrong for values < -1: it will print duplicate '-'. Plus, it doesn't do proper rounding, though that's probably not so important if it is just used in core.time's unittest.
I'm not so sure about removing the AA unittest: it fails with a range violation (that is not checked in release), because the allocated entry has zero length, so the respective allocation returns null. This looks like a number of operations fail (also E.init in aa), though in fact, they did not. Mapping a type with just a single state and zero storage to another similar type doesn't sound very useful, but might happen in some generic code. I think we should at least allocate a single byte for the (key,value) entry to achieve consistent semantics for this edge case, too.

I think we should at least allocate a single byte for the (key,value) entry to achieve consistent semantics for this edge case, too

I agree with this.

Also, why are we not testing in debug mode on druntime, I thought that was happening? It at least happens on phobos.

The problem was that zero size keys wouldn't compare equal.

I stepped through the code in the debugger and aa[E.init] returned from _aaGetY at https://github.com/MartinNowak/druntime/blob/3af384a89d250e4f04e36068ff65aa4d7efcf9f6/src/rt/aaA.d#L362 with p.entry being null. TypeInfo_StaticArray.equals always returns true for me with 0 elements.

@rainers I think Martin was talking about why he added the test in the first place.
In any case, I think an AA of this nature is quite useless. I can't see a reason to have an AA with only one possible node, there are better ways to do something like that.

I'm OK to merge this if you are, @rainers

Wait, I'll debug this and see where the range error came from. I added this test originally to maximize coverage.

updated

LGTM

Auto-merge toggled on


Mix campaign fixes

This PR contains a series of bug fixes in the Mix MDC2020 campaign, including setting the DbService.purpose to MDC2020i.

Hi @soleti,
You have proposed changes to files in these packages:

CampaignConfig
MDC2020

which require these tests: build.
@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.
:hourglass: The following tests have been triggered for 632c5cfcd13193e3a47ab27c032d3abd0d7cfe67: build  (Build queue has 1 jobs)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The tests passed at 632c5cfcd13193e3a47ab27c032d3abd0d7cfe67.

Test
Result
Details

merge
:white_check_mark:
Merged 632c5cfcd13193e3a47ab27c032d3abd0d7cfe67 at 39e69d536a809de852b09412e7bc3ebc2465da24

build (prof)
:white_check_mark:
Log file. Build time: 13 min 58 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 632c5cfcd13193e3a47ab27c032d3abd0d7cfe67 after being merged into the base branch at 39e69d536a809de852b09412e7bc3ebc2465da24.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.


Session cookie Secure flag and lifetime

I noticed that the _session_ cookie is not protected with the Secure flag. This happens even when DRONE_SERVER_PROTO=https is set. I would like to propose checking this environment variable and setting the Secure flag when appropriate. :smiley:
Besides, the lifetime of the cookie is several decades long. Maybe this could be reduced a bit :wink:

Sure, I recommend sending a pull request. First you can add an environment variable to the configuration [1] and and pass to the session manager, and then you can update the session manager to set the value [2]. Should be a simple patch.
[1] https://github.com/drone/drone/blob/master/cmd/drone-server/config/config.go#L256
[2] https://github.com/drone/drone/blob/master/session/session.go#L46

Besides, the lifetime of the cookie is several decades long. Maybe this could be reduced a bit

the contents of the cookie is a cryptographically signed string that has the expiration date encoded in the value. So we have do an expiration date.

Thanks for the explanation! I'm not a go programmer but this looks comparably simple. Maybe I find time to do this.
One question: Why is the introduction of a new environment variable required? Can't we simply check if DRONE_SERVER_HOST=https? This does already exist.

Why is the introduction of a new environment variable required

We do not want to make assumptions with regards to how people want their instances configured. It is possible to use Drone with http and https, and we do not want to break any existing installations.
In this case, and explicit configuration parameter is best.

It is possible to use Drone with http and https, and we do not want to break any existing installations.

I don't see what possibly could break. If DRONE_SERVER_HOST=https but port 80 is still exposed, it does nothing more than returning a redirect to https. So everything should be fine.
Explicit configuration is usually a good idea, but it also introduces complexity and admins can easily forget to set the new variable to true. At least if the default is false.
Do you still demand a new variable and if yes what should the default value be?

we should use DRONE_COOKIE_SECURE as the variable name

Great, thanks!
I was working on a PR and had it almost ready but needed to look up some Go specific stuff first.
Thanks anyways :smiley:


Choosing day view in Agenda errors with table index is nil

Describe the bug
This errors out with:
[orgmode] ....vim/plugged/orgmode/lua/orgmode/agenda/views/agenda.lua:115: table index is nil

Here's a link to that line: https://github.com/nvim-orgmode/orgmode/blob/f98f3243bc1a4c3a1f86d0daac505794b3f75f7b/lua/orgmode/agenda/views/agenda.lua#L115
Steps to reproduce
Enter Agenda view with <leader>oaa and then try going to day view with vd.
Expected behavior
Show day view.
Emacs functionality
No response
Minimal init.lua
/
Screenshots and recordings
No response
OS / Distro
Manjaro 21.2.6
Neovim version/commit
0.8
Additional context
No response

Closed with #347


Variable model was not provied - Connection Error

Hi,
I have a Thermia Diplomat Inverter and I have downloaded and installed all the files here according to the instructions.
When Adding the Integration, I see this error window.

Even after entering the IP-address, I get connection error.
What am I doing wrong?

Change homeassistant language to Swedish and it will work.

You need to enable modbus TCP, you find this setting under installer settings/installatörs inställningar if i recall correctly.
The pump has to be in OFF setting to show this menu.
Above atleast apply on my Thermia Calibra, i would assume it is the same for your model.


Add loop inversion pass

At the moment this applies indiscriminately wherever it can, and while I don't
think that's a terrible default it could maybe do with some more nuance.
Perhaps either:

Only perform when the condition expression is "small" for some definition of
small
Add a loop-uninvert pass, which will uninvert any loops where sccp was unable
to eliminate the first condition check

Still left to do is check and fix all the cross compile tests where the output
has changed, and check that copying over the loop decorations is always correct.

hmm, some later pass is generating invalid Ir, note how in the second snippet 39 is being read before it's written (in the first snippet this value is being passed back using a parameter, which has been removed). Is there some requirement/assumption which the first snippet is violating (and which isn't picked up by the validator?)
[backwardDifferentiable]
[DifferentiableTypeDictionaryDecoration]
[export("_S3tu023test_loop_with_continuep1pff")]
[nameHint("test_loop_with_continue")]
func %testx5Floopx5Fwithx5Fcontinue	: Func(Float, Float)
{
block %68(
		[nameHint("y")]
		param %y	: Float):
	unconditionalBranch(%69, %y)

block %69(
		[nameHint("t")]
		param %t	: Float):
	unconditionalBranch(%70)

block %70:
	[loopMaxIters(3 : Int)]
	loop(%71, %72, %71, %t, 0 : Int)

block %73(
		[nameHint("t")]
		param %t1	: Float,
		[nameHint("i")]
		param %i	: Int):
	let  %74	: Bool	= cmpLT(%i, 3 : Int)
	ifElse(%74, %75, %72, %71)

block %71(
		param %76	: Float,
		param %77	: Int):
	let  %78	: Bool	= cmpGT(%76, 4 : Float)
	ifElse(%78, %79, %80, %80)

block %79:
	unconditionalBranch(%81, %76)

block %80:
	let  %82	: Float	= mul(%76, %76)
	unconditionalBranch(%81, %82)

block %81(
		[nameHint("t")]
		param %t2	: Float):
	let  %83	: Int	= call %10(1 : Int)
	let  %84	: Int	= add(%77, %83)
	unconditionalBranch(%73, %t2, %84)

block %75:
	unconditionalBranch(%71, %t1, %i)

block %72:
	return_val(%76)
}

### BEFORE-SPECIALIZE:
[backwardDifferentiable]
[DifferentiableTypeDictionaryDecoration]
[export("_S3tu023test_loop_with_continuep1pff")]
[nameHint("test_loop_with_continue")]
func %testx5Floopx5Fwithx5Fcontinue	: Func(Float, Float)
{
block %34(
		[nameHint("y")]
		param %y	: Float):
	[loopMaxIters(3 : Int)]
	loop(%35, %36, %35, %y, 0 : Int)

block %37:
	let  %38	: Bool	= cmpLT(%39, 3 : Int)
	ifElse(%38, %40, %36, %35)

block %35(
		param %41	: Float,
		param %42	: Int):
	let  %43	: Bool	= cmpGT(%41, 4 : Float)
	ifElse(%43, %44, %45, %45)

block %44:
	unconditionalBranch(%46, %41)

block %45:
	let  %47	: Float	= mul(%41, %41)
	unconditionalBranch(%46, %47)

block %46(
		[nameHint("t")]
		param %t	: Float):
	let  %48	: Int	= call %intx5Fx24init(1 : Int)
	let  %39	: Int	= add(%42, %48)
	unconditionalBranch(%37)

block %40:
	unconditionalBranch(%35, %t, %39)

block %36:
	return_val(%41)
}

It feels like there really should be a PHI node inserted for that jump.
What's been changed in this PR?

There is the requirement that all uses of a value must be dominated by its def, I wonder why validation isn't complaining on that.

I have not carefully examined the logic here, but if all tests are passing, I am assuming it is correct.

Looking forward to giving this comment a chuckle down the line :)


[Feature] ignore # in $issue get

Describe the solution you'd like
Allow $issue get #<num> as well as just $issue get <num>
(optional) Your discord tag
Azloxion

rejected in favour of int type check thanks to slash commands


Show a success alert after successfully saving TI client edits

Description
When a TI successfully saves edits to a client, show a USWDS success alert rather than a toast message.  The alert shows on the client edit page, so we are no longer redirecting to the TI dashboard when the user clicks "Save".
Release notes
Show a success alert after successfully saving TI client edits rather than showing a toast message.
Instructions for manual testing

Log in as a TI.
Create a new client if you don't have any yet.
Click "Edit" next to the client name on the client card.
Update the client name.
Click "Save".
Note the alert banner near the top of the form.

Issue(s) this completes
Fixes #6906

Hi Melanie, Are we sure we don't want them to be navigated to the Dashboard after adding the Client? As a user, after updating a Client info, I would like to see the updated Client data in the table..

Copying link the Sijia's confirmation in Slack that the alert should show on the edit page and we are relying on the user to navigate back to the dashboard:  Slack conversation


Reseting the price scale

I set the initial data for the graph. Then set the time and price axis scaling using the left mouse button. Next, I set new data for the graph. And to display the chart, you need to reset the price axis by double-clicking the left mouse button. How to make an automatic reset of the price axis after installation of the new data for the graph?
Help, please )

How to make an automatic reset of the price axis after installation of the new data for the graph?

You can enable autoScale option via applyOptions of price scale.

here is the code
chart.priceScale().applyOptions({autoScale : true})

Just a helpful note.
Two things that I missed are:

It did not work without 'right'. So chart.priceScale('right').applyOptions({autoScale : true}).
I needed to do it before I called setData on the series.


improvement checkpoint thread update tablet invert index

Proposed changes
Checkpoint thread doesn't update tablet invert index, then in checkpoint thread TabletInvertedIndex.getTablet/getReplica will return null.  It may cause some problems.  Fix this,  let checkpoint thread also update tablet invert index.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Move plugin documentation

The plugins, that become more irrelevant every day, take up a lot of room in the main readme file. Let's move it to the wiki or simplify it.

Moved to the Plugins wiki page.


why I can not achieve the hopping?

I run the program first:
btle_rx -c chan -g gain -a access_addr -k crc_init -o
I can see the adv data,then I connect my phone with bluetooth modules,but I can not see the hopping data,any help will be appreciated.

You need to share the packets you captured, then I can take a look.

@lanlanwei This may be because you are looking in the wrong place. Since Bluetooth core V4.0, connection requests in the form of AUX_CONNECT_REQ can go across the secondary advertising channels. These channels are specified as the 37 PHY channels that were previously reserved for Data PDUs.
So if you have a bluetooth device that implements V4.0+ you may have to scour the data channels instead.
From the Bluetooth Core Specification page:

BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 6, Part B Section 2.3

BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 1, Part A Section <IP_ADDRESS>.2


add linter/autofixer for comment line lengths

to avoid nitpicking on these

Can I get assigned to this?


[(ngModel)] two-way binding doesn't work with --minifyjs

just a simple code
LoginPage:
@IonicPage()
@Component({
	selector: 'page-login',
	templateUrl: 'login.html',
})
export class LoginPage {
	private login: any = {};
	doLogin() {
		console.log(this.login.username);//this will be undefined
	}
}

login.html：

	<ion-item>
		<ion-label fixed>name</ion-label>
		<ion-input type="text" [(ngModel)]="login.username"></ion-input>
	</ion-item>

	<button ion-button block color="danger" (click)="doLogin()">Login</button>

this code：  [(ngModel)]="login.phoneNum" works fine when i run with serve cmd. but when i build the project with 'ionic build --minifyjs' and deployed on web server, it cann't bind my input to ts code: this.login.username, and doLogin will always output with undefined.
btw, i tryed to import FormsModule， it doesn't work too.

probably related to https://github.com/ionic-team/ionic/issues/13718

@jennielynshapiro use raw html input for instead is ok！

@jennielynshapiro what do you mean when using login.phoneNum as ngModel and logging as login.username?
Is there something wrong?

@longgt 3q, i fixed the example code. the problem is still there.

As the workaround you can freeze uglyfy-es version in your project.json:

@sid-ihycq Change version of @ionic/app-scripts to 3.1.7
npm install<EMAIL_ADDRESS>--save-dev --save-exact

and try your example.

@anatoly-spb version 3.1.7 it's work for me.

@anatoly-spb  it's work for me. thank you！

I am going to close this assuming that the upgrade to @ionic/app-scripts will work for @sid-ihycq  the same as it worked for @anatoly-spb. If it does not, we will be happy to re-open the issue.

thanks a lot of the fix, I was getting frustrated how the ionic serve works but after deployment ionic-input just breaks down


Videojs IMA Chromecast

Hello everybody:
I have a web page and my player and my ads is working but when I try send to the chromecast with the plugin silrvermine-videojs-chromecast the ads play in my browser and the video play in my chromecast and I want that all play it at the chromecast
https://sportsvr.tv
Thanks for all
Best regards

Hi,
This is beyond the scope of this issue tracker, we don't support the issues related to the videojs-chromecast  plugin. However, the IMA SDK which is the underlying SDK of our plugin also provides the IMA SDK for Cast that you can use to integrate ads display feature in your Cast app.

Hi,
I’m closing this issue because it has been inactive for more than a month. Please reopen if you still encounter this issue with the latest stable version
Thank you!


Fix the FindHIP.cmake script.

Added the CMake Flags necessary to maintain standard using of regular CMake commands when building a HIP target.
When building HIP targets, COMPILE_DEFINTIONS were dropped. So append the COMPILE DEFINITIONS from the directory into the hcc invocation line.
Also extract the include directories and pass it into the correct variable.

/cc @mangupta

@mangupta Changes made.

I don't have access to the ROCm CI so it's basically a black box from my side. But, I'm assuming your suggested fix doesn't work.
Could you post the error log from your CI?

@Jorghi12 The build issue that is occurring now is due to a typo that got introduced in your last commit. I have fixed it and pushed the fix to your branch. The PR works locally for me. Hopefully it will pass on the CI as well. I will approve and merge it in case it passes.


instantiating 'Assertion+#valid?()'

I came across this bug a few times.  I tried to make it as simple as possible, but this was the best i could do, between reproducing the bug and #6996 made it a bit more challenging.
https://play.crystal-lang.org/#/r/5ijv
require "json"

  class Validator
    getter assertions : Array(Assertion)
    getter errors : Array(String) = [] of String

    def initialize(@assertions : Array(Assertion) = [DummyAssertion.new("", "")] of Assertion)
      @errors = @assertions.reject(&.valid?).map(&.message)
    end
  end

module MyModule
  include JSON::Serializable
    ASSERTIONS = {
    	Email             => [] of Symbol
  }

  {% for t in ASSERTIONS %}
    # :nodoc:
    annotation {{t}}; end
  {% end %}

  @[JSON::Field(ignore: true)]
  getter validator : Validator = Validator.new

  def after_initialize
    assertions = [] of Assertion
    {% for ivar in @type.instance_vars %}
      {% for t, v in ASSERTIONS %}
        {% ann = ivar.annotation(t.resolve) %}
        {% if ann %}
          assertions << {{t.id}}Assertion({{ivar.type.stringify.id}}).new({{ivar.stringify}},{{ann[:message]}},{{ivar.id}})
        {% end %}
      {% end %}
    {% end %}
    @validator = Validator.new assertions
  end
end

  abstract class Assertion
    getter message : String
    getter field : String

    def initialize(@field : String, message : String?)
      @message = message ? message : "'#{@field}' has failed the #{{{@type.class.name.split("::").last.split('(').first.underscore}}}"
    end

    abstract def valid? : Bool
  end

  class EmailAssertion(ActualValueType) < Assertion

    def initialize(
      field : String,
      message : String?,
      @actual : String?,
    )
      super field, message
    end

    def valid? : Bool
	  #true
    end
  end

  class DummyAssertion < Assertion
    getter message : String = ""

    def valid? : Bool
      true
    end
  end

class Test

  include MyModule

  @[Email]
  property name : String
end

pp Test.from_json %({"name":"john"})

Error in line 84: instantiating 'Test.class#from_json(String)'

in /usr/lib/crystal/json/from_json.cr:13: instantiating 'new(JSON::PullParser)'

  new parser
  ^~~

in /usr/lib/crystal/json/serialization.cr:227: instantiating 'after_initialize()'

      after_initialize
      ^~~~~~~~~~~~~~~~

in line 29: expanding macro

in macro 'macro_94024165002640' eval:29, line 10:

   1.
   2.
   3.
   4.
   5.
   6.
   7.
   8.
   9.
> 10.           assertions << EmailAssertion(String).new("name",nil,name)
  11.
  12.
  13.

instantiating 'Assertion+#valid?()'

The error can be fixed my uncommenting the return value on line 63.  I would expected this to return an error like Return type should be Bool, got Nil.  This is quite vague and makes debugging a bit harder.

There's definitely a compiler bug here, as you can see from the cut-off stack trace which suddenly stops at instantiating 'Assertion+#valid?()' where is should continue.

A more minimal example, in a situation I've run into several times now:
require "json"

abstract class Parent
  include JSON::Serializable
  property string = "a string prop"
  abstract def number
  abstract def boolean
end

class ImpA < Parent
  property number = 5
  property boolean = false
end

class ImpB < Parent
  property boolean = true
  property number = -5
  property not_in_parent = 10.03
end

var = Array(ImpA | ImpB).from_json <<-JSON
[ { "string": "strprop", "number": 12, "boolean": true } ]
JSON

https://carc.in/#/r/6bw1

I ran into this again :(

Reduced some more
require "json"

abstract class Type
  include JSON::Serializable
end

Array(Type).from_json ""

That will never work...

Also, it seems related to being able to instantiate abstract classes.

I mean, you can't use an abstract type in JSON mapping. Or what is your expected behaviour here? This wi always result in a compile error, I think, no matter how ugly or pretty the message is.

That will never work...

Yea I never expected it to, was just assuming something else is going on due to the error messge seemingly getting cut off
Error in line 7: instantiating 'Array(Type).class#from_json(String)'

in /usr/lib/crystal/json/from_json.cr:13: instantiating 'new(JSON::PullParser)'

  new parser
  ^~~

in /usr/lib/crystal/json/from_json.cr:103: instantiating 'new(JSON::PullParser)'

  new(pull) do |element|
  ^~~

in /usr/lib/crystal/json/from_json.cr:110: instantiating 'JSON::PullParser#read_array()'

  pull.read_array do
       ^~~~~~~~~~

in /usr/lib/crystal/json/from_json.cr:110: instantiating 'JSON::PullParser#read_array()'

  pull.read_array do
       ^~~~~~~~~~

in /usr/lib/crystal/json/from_json.cr:111: instantiating 'Type.class#new(JSON::PullParser)'

    yield T.new(pull)
            ^~~

in line 4: expanding macro

in macro 'included' /usr/lib/crystal/json/serialization.cr:122, line 5:

   1.       # Define a `new` directly in the included type,
   2.       # so it overloads well with other possible initializes
   3.
   4.       def self.new(pull : ::JSON::PullParser)
>  5.         instance = allocate
   6.         instance.initialize(__pull_for_json_serializable: pull)
   7.         GC.add_finalizer(instance) if instance.responds_to?(:finalize)
   8.         instance
   9.       end
  10.
  11.       # When the type is inherited, carry over the `new`
  12.       # so it can compete with other possible intializes
  13.
  14.       macro inherited
  15.         def self.new(pull : ::JSON::PullParser)
  16.           super
  17.         end
  18.       end
  19.

instantiating 'allocate()'

Which is similar to the compile error i was getting in my initial example above.


(node:29) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED <IP_ADDRESS>:80

Description
When I launch the "docker-compose up" command everything seems to be fine, but as soon as I connect from the browser that error message comes out on the terminal. Also to connect I use port :3000 for the web interface, while here the error indicates port 80, I don't understand...
Steps to Reproduce the Bug

docker-compose up
connect <IP_ADDRESS>:3000
Error

Expected Behavior
When I launch the "docker-compose up" command everything seems to be fine, but as soon as I connect from the browser that error message comes out on the terminal. Also to connect I use port :3000 for the web interface, while here the error indicates port 80, I don't understand...
Actual Behavior
This is error:
(vicuna-matata) steppi@ubuntu4090:~/sp2/Agent-LLM$ sudo docker-compose up Starting agent-llm_backend_1 ... done Starting agent-llm_frontend_1 ... done Attaching to agent-llm_backend_1, agent-llm_frontend_1 frontend_1  | yarn run v1.22.19 frontend_1  | $ next start frontend_1  | ready - started server on <IP_ADDRESS>:3000, url: http://localhost:3000 backend_1   | INFO:     Started server process [7] backend_1   | INFO:     Waiting for application startup. backend_1   | INFO:     Application startup complete. backend_1   | INFO:     Uvicorn running on http://<IP_ADDRESS>:7437 (Press CTRL+C to quit) backend_1   | INFO:     <IP_ADDRESS>:59966 - "GET /api/provider HTTP/1.1" 200 OK frontend_1  | Promise { <pending> } frontend_1  | { frontend_1  |   mutate: [Function (anonymous)], frontend_1  |   data: [Getter], frontend_1  |   error: [Getter], frontend_1  |   isValidating: [Getter], frontend_1  |   isLoading: [Getter] frontend_1  | } frontend_1  | (node:29) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED <IP_ADDRESS>:80 frontend_1  |     at Function.AxiosError.from (file:///app/node_modules/axios/lib/core/AxiosError.js:89:14) frontend_1  |     at RedirectableRequest.handleRequestError (file:///app/node_modules/axios/lib/adapters/http.js:591:25) frontend_1  |     at RedirectableRequest.emit (events.js:400:28) frontend_1  |     at ClientRequest.eventHandlers.<computed> (/app/node_modules/follow-redirects/index.js:14:24) frontend_1  |     at ClientRequest.emit (events.js:400:28) frontend_1  |     at Socket.socketErrorListener (_http_client.js:475:9) frontend_1  |     at Socket.emit (events.js:400:28) frontend_1  |     at emitErrorNT (internal/streams/destroy.js:106:8) frontend_1  |     at emitErrorCloseNT (internal/streams/destroy.js:74:3) frontend_1  |     at processTicksAndRejections (internal/process/task_queues.js:82:21) frontend_1  | (Use node --trace-warnings ...to show where the warning was created) frontend_1  | (node:29) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag--unhandled-rejections=strict(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 3) frontend_1  | (node:29) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. frontend_1  | Promise { <pending> } backend_1   | INFO:     <IP_ADDRESS>:59966 - "GET /api/provider HTTP/1.1" 200 OK frontend_1  | (node:29) UnhandledPromiseRejectionWarning: Error: connect ECONNREFUSED <IP_ADDRESS>:80 frontend_1  |     at Function.AxiosError.from (file:///app/node_modules/axios/lib/core/AxiosError.js:89:14) frontend_1  |     at RedirectableRequest.handleRequestError (file:///app/node_modules/axios/lib/adapters/http.js:591:25) frontend_1  |     at RedirectableRequest.emit (events.js:400:28) frontend_1  |     at ClientRequest.eventHandlers.<computed> (/app/node_modules/follow-redirects/index.js:14:24) frontend_1  |     at ClientRequest.emit (events.js:400:28) frontend_1  |     at Socket.socketErrorListener (_http_client.js:475:9) frontend_1  |     at Socket.emit (events.js:400:28) frontend_1  |     at emitErrorNT (internal/streams/destroy.js:106:8) frontend_1  |     at emitErrorCloseNT (internal/streams/destroy.js:74:3) frontend_1  |     at processTicksAndRejections (internal/process/task_queues.js:82:21) frontend_1  | (node:29) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag--unhandled-rejections=strict(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 5) backend_1   | INFO:     <IP_ADDRESS>:38128 - "GET /api/provider HTTP/1.1" 200 OK
Additional Context / Screenshots
No response
Operating System

[ ] Microsoft Windows
[ ] Apple MacOS
[X] Linux
[ ] Android
[ ] iOS
[ ] Other

Python Version

[ ] Python <= 3.9
[X] Python 3.10
[ ] Python 3.11

Environment Type - Connection

[X] Local
[X] Remote

Environment Type - Container

[X] Using Docker
[ ] Not Using Docker

Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of Agent-LLM.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

I think it's similar to https://github.com/Josh-XT/Agent-LLM/issues/193#issuecomment-1533518780

The port in Docker is 3000 if running inside of Docker, but port 80 is the exposed port when using docker.


[Quick Fix : Performance] Lazy load Open Api 2/3 parsers

Please lazy load parsers import based on the submitted schema at run time.
https://github.com/PayU/api-schema-builder/blob/784c5ad4e1213a53c84e4fc7d5733edbdab684de/src/index.js#L8
Currently i'm using for Openapi v2 but v3 parsers are getting loaded.

hi @manwithsteelnerves , thanks for reporting this issue.
we'll look into it.


Face Reenactment

Could you please explain (or ideally upload the scripts) how to apply FlashAvatar for face reenactment task?
Should I train FlashAvatar on source head, run tracking on the target head, and then in test.py use viewpoints obtained from target and gaussians from the trained FlashAvatar?
I am a bit confused with the pipeline, so would be happy if you upload the reenactment script.
Thanks in advance!

For face reenactment, you need to use relative expression transfer because the expression and shape are not well disentangled in FLAME tracking.
You can take a look at NeRFace to see how it is done.


AMA-319 add user details of migration initiator to the log

Example:
2022-10-07 15:52:54,000 - [INFO] - Migration for site 33fe0f1c-c2dd-446e-9846-724646d9c4a5 started by Nosipho Mali<EMAIL_ADDRESS>

@TurRil  Please review and merge when happy.


Fix logging of header X-DC-DEVKEY

coverage: 75.163% (+0.03%) from 75.132% when pulling 1a66b4fe4d285597161f814eca6ac70a5c0bcc4e on jmcrawford45:PS-4615 into 5cbdc296ea585fce2ef3306001a435e1c037d686 on Netflix:master.