support JSON source prefix

This version makes Sockeye able to support JSON input format with special source tokens as follows:

Special source tokens can be added (e.g. verbosity token, formality token, multilingual token) in Sockeye's JSON input format
Long input sequence is chunked in the way that the special source tokens are added to each chunk.

Examples of JSON input object that can be used during inference are as below (noticed of the keyword: source_prefix and source_prefix_factors):
{ "text": "(@@ A@@", "source_prefix": "a@@"}
{ "text": "(@@ A@@", "source_prefix": "a@@ a@@"}
{ "text": "(@@ A@@", "factors": ["(@@ A@@"], "source_prefix": "a@@ a@@", "source_prefix_factors": ["(@@ A@@"]}

Pull Request Checklist

[x] Changes are complete (if posting work-in-progress code, prefix your pull request title with '[WIP]'
until you can check this box.
[x] Unit tests pass (pytest)
[x] Were system tests modified? If so did you run these at least 5 times to account for the variation across runs?
[x] System tests pass (pytest test/system)
[x] Passed code style checking (./style-check.sh)
[x] You have considered writing a test
[x] Updated major/minor version in sockeye/__init__.py. Major version bump if this is a backwards incompatible change.
[x] Updated CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Regarding style checks: are you using the mypy & pylint versions defined in requirements/requirements.txt?

Very useful feature, thanks for adding!
A few comments/suggestions:

source_prefix should actually be a list of tokens, not a string
I think we can simplify the code greatly by adding properties to the TranslatorInput dataclass.
please add unit-test cases for TranslatorInput that cover chunk, with_eos methods
please add unit tests for computing max length

Regarding style checks: are you using the mypy & pylint versions defined in requirements/requirements.txt?

Following your suggestion I recheck their versions and it works OK now.

Very useful feature, thanks for adding!
A few comments/suggestions:

source_prefix should actually be a list of tokens, not a string
I think we can simplify the code greatly by adding properties to the TranslatorInput dataclass.
please add unit-test cases for TranslatorInput that cover chunk, with_eos methods
please add unit tests for computing max length

I updated the code based on your suggestion. Please take a look. Meanwhile I have a question regarding adding unit-test cases with_eos method and unit tests for computing max length. Since I don't really change those parts, not really sure how to write unit tests for them properly. Please advise me on that.

Thanks for the changes! Unit tests look fine to me!
Would you be able to document this feature in https://github.com/awslabs/sockeye/blob/main/docs/inference.md#input-and-output-with-json?
To get this ready, please also bump the minor version (sockeye/__init__.py) and create a corresponding entry in CHANGELOG.

I followed your suggestions and modified the code. Please take a look!


Vim9: cannot use key from dictionary as iteration variable

Steps to reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script
    def Func()
        var d = {k: 'aaa'}
        for d.k in ['bbb', 'ccc', 'ddd']
            echo d.k
        endfor
    enddef
    Func()
EOF
)

These lines are echo'ed:
aaa
aaa
aaa

Expected behavior
Not sure.  Either these lines are echo'ed:
bbb
ccc
ddd

Or an error is given:
E1234: cannot use key from dictionary as iteration variable

In any case, I think the current situation is not OK, because it leads to unexpected results, which might be hard to debug.
Operating system
Ubuntu 20.04.3 LTS
Version of Vim
8.2 Included patches: 1-3640
Additional Context
No issue in legacy:
vim9script
function Func()
    let d = {'k': 'aaa'}
    for d.k in ['bbb', 'ccc', 'ddd']
        echo d.k
    endfor
endfunction
Func()

bbb
ccc
ddd

Are we meant to be able to use a dictionary key as iteration variable in Vim9?  If not, maybe it should be documented.

Some languages allow using a dictionary key for iteration. For example, in Python:
#!/usr/bin/env python3

d = {"k": "aaa"}

print(d["k"])

for d["k"] in ["bbb", "ccc", "ddd"]:
    print(d["k"])

print(d["k"])

Output:
aaa
bbb
ccc
ddd
ddd

Same behavior when we iterate with a list member:
vim9script
def Func()
    var l = ['aaa']
    for l[0] in ['bbb', 'ccc', 'ddd']
        echo l[0]
    endfor
enddef
Func()

aaa
aaa
aaa

No error is given, and l[0] silently fails to iterate over the members of ['bbb', 'ccc', 'ddd'].
And again, no issue in legacy:
vim9script
function Func()
    let l = ['aaa']
    for l[0] in ['bbb', 'ccc', 'ddd']
        echo l[0]
    endfor
endfunction
Func()

bbb
ccc
ddd

Just to be clear: if this syntax is deemed too confusing, that's fine.  What is not OK is that Vim silently ignores the iterated list.

Let's first look at script level.  Currently this gives an error:
var i = 0
for i in [1, 2, 3]
   echo i
endfor

The reason is that it may accidentally use variable "i".  It's like
declaring a variable that was already declared.
Now this also means that using a list or dict member gives the error for
the variable already existing:
var l = [0]
for l[0] in [1, 2, 3]
   echo l[0]
endfor

If we would allow this, because it's a member and not a declared
variable, things get confusing.  So perhaps re-using a variable should
not be an error?  That might lead to mistakes.
To be consistent, we should just say that the loop variable must not
exist yet.  That disallows assigning to a list or dict member, but is
that really a problem?  In case you need it there is just one extra
line:
var l = [0]
for i in [1, 2, 3]
   l[0] = i
   echo l[0]
endfor

It's a small price to pay for simplicity.
Extending this to compiled functions, it should work the same way.
Then the problem is that this does not give an error:
def Func()
  var l = [0]
  for l[0] in [1, 2, 3]
    echomsg l[0]
  endfor
enddef

I'll add the missing error check.  Then it should work consistently.
--
BRIDGEKEEPER: What is your favorite colour?
GAWAIN:       Blue ...  No yelloooooww!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


A build of my app does not work with iohook on windows. Can't find iohook.node

I am very new to electron, but I think this error is not on me.
I have an electron app that works well on Ubuntu Linux 18.04, but fails when trying to run it on Windows 10 (64 bit).
Expected Behavior
I would expect the app to run and work just like on Linux
Current Behavior
When trying to start the app with electron ., the app crashes instantly with a Windows popup error window, and this in the console:
C:\Users\maido\Desktop\temp\webueno-tracker>electron .

 App threw an error during load
Error: The specified procedure could not be found.
\\?\C:\Users\maido\Desktop\temp\webueno-tracker\node_modules\iohook\builds\electron-v69-win32-x64\build\Release\iohook.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:722:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:160:31)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (C:\Users\maido\Desktop\temp\webueno-tracker\node_modules\iohook\index.js:10:21)
    at Object.<anonymous> (C:\Users\maido\Desktop\temp\webueno-tracker\node_modules\iohook\index.js:397:3)

I can in fact find the file that is supposedly missing at the path specified, but the path in the error message seems to be malformed. A similar error appears in the version of the app packaged with electron-packager regardless of whether I package it on Windows or Linux
Possible Solution
Native node extensions are way out of my comfort zone at the moment, but Googling around has brought me to this issue on a different package.
https://github.com/agracio/electron-edge-js/issues/32
As you can see in the issue, the path is malformed in the same way, and it seems to be related to this issue:
https://electronjs.org/docs/tutorial/using-native-node-modules#troubleshooting
Regarding the win_delay_load_hook. Which is in the iohook package itself.
Steps to Reproduce (for bugs)

Create an app with electron 4.0.4.
Try and run it on Windows

Context
The app is supposed to track user activity and put it self on pause if there was no user activity in the last 5 minutes. That is what I am using iohook for. The feature works on Ubuntu Linux 18.04 LTS, but not on Windows. Windows and MacOS users are very important to me. I still have not tested it on a Mac.
Your Environment
Windows 10 64 bit
Iohook 0.4.0
Electron 4.0.4

Same thing happens to me when running the https://github.com/wilix-team/iohook/tree/master/examples/electron-example example project

I'm seeing the same problem with latest ABI version of electron 69.

Here is the console error I'm getting as well.
Uncaught Error: The specified procedure could not be found.
\?\H:\test_app\node_modules\iohook\builds\electron-v69-win32-x64\build\Release\iohook.node
at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:722)
at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:160:31)
at Module.load (internal/modules/cjs/loader.js:602)
at tryModuleLoad (internal/modules/cjs/loader.js:541)
at Function.Module._load (internal/modules/cjs/loader.js:533)
at Module.require (internal/modules/cjs/loader.js:640)
at require (internal/modules/cjs/helpers.js:20)
at Object. (H:\test_app\node_modules\iohook\index.js:10)
console.log('info: ', process.versions.modules);
Yields ABI: 69,
Using "win32", 64 bit
Node version: 10.15.1

I have the same Problem on windows 10 x64 , electron 4.1.0 , iohook 0.4.0  on requiring iohook.
err:
Error: Cannot find module '.\node_modules\iohook\builds\electron-v69-win32-x64\build\Release\iohook.node' at Module._resolveFilename (internal/modules/cjs/loader.js:584:15) at Function.Module._resolveFilename (.\electron\dist\resources\electron.asar\common\reset-search-paths.js:43:12) at Function.Module._load (internal/modules/cjs/loader.js:510:25) at Module.require (internal/modules/cjs/loader.js:640:17) at require (internal/modules/cjs/helpers.js:20:18) at Object. (C.\node_modules\iohook\index.js:10:21) at Object. (.\node_modules\iohook\index.js:397:3) at Module._compile (internal/modules/cjs/loader.js:693:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10) at Module.load (internal/modules/cjs/loader.js:602:32)
but it works with node js fine.
What your solution for this?
Does it exist a module for electron (worked on windows) for mouse event like iohook?

Any updates with this version of iohook and latest version of electron 64-bit windows? if not I'll probably have to downgrade to an older version.

https://github.com/nodejs/node-addon-api/issues/269#issuecomment-455580129 Seems to be what we have to do. Step 1 is easy enough, though Step 2 will require some code changes (hopefully quite simplistic)

I'm just curious if anyone has gotten iohook with Electron 4.1.0 ABI 69 working. I just went back to Electron 2.0.0+ for the time being.

Yep, MacOS and Linux work fine. https://github.com/wilix-team/iohook/issues/144

Can someone else publish a binary for Windows 10 64-bit? Seems the last release didn't compile properly.

@GimpMaster could you help us with this ? https://github.com/wilix-team/iohook/pull/157

@Djiit Absolutely. Just an FYI...I saw you pushed a new release 0.4.1. I did the following:
npm install https://github.com/wilix-team/iohook.git  -save
This installed 0.4.1. I even confirmed the build folder:
electron-v69-win32-x64\build\Release had the same binaries as what is in the tagged release.
But I still get the following error.
Uncaught Error: The specified procedure could not be found. \\?\H:\Fast_Dev\line_app\node_modules\iohook\builds\electron-v69-win32-x64\build\Release\iohook.node     at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)     at Object.Module._extensions..node (internal/modules/cjs/loader.js:722)     at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:160:31)     at Module.load (internal/modules/cjs/loader.js:602)     at tryModuleLoad (internal/modules/cjs/loader.js:541)     at Function.Module._load (internal/modules/cjs/loader.js:533)     at Module.require (internal/modules/cjs/loader.js:640)     at require (internal/modules/cjs/helpers.js:20)     at Object.<anonymous> (H:\Fast_Dev\line_app\node_modules\iohook\index.js:10)     at Object.<anonymous> (H:\Fast_Dev\line_app\node_modules\iohook\index.js:397)
I'll see what I can do in issue #157

I'm closing this since it was resolved elsewere.

@Maidomax
Maybe this help:
https://github.com/wilix-team/iohook/issues/160

@Maidomax
Maybe this help:
#160

@karacas Did not help :(
Works on some machines, on some not.


Port iptables_rule to core

We should be able to manage iptables firewall rules with chef out of the box

I think this shouldn't be "port iptables_rule", but "what should a firewall resource that works for all our platforms look like in core chef"


chore: remove unused dependencies

package-build-stats installs esbuild-webpack-plugin as a dependency which installs<EMAIL_ADDRESS>which in turn is so old, that its incompatible with my m1-macbook and the complete pnpm i for feltefails.
As vite + package-build-stats don't seem to be used anywhere in the packages, this PR removes both packages.

Whoops. That vite dependency was a vestige from when Vite was not bundled with SvelteKit. Thanks for removing it!
Regarding package-build-stats, I use it to check if the bundles we are releasing are compatible with Bundlephobia. Since it's not compatible with pnpm mono repos (or rollup as far as I know) I kept it there to use it as a cli tool. But yeah... it's probably not useful as a dev dep anyway.
Weird that it's failing for you, I'm also using an M1 MacBook, but I have Rosetta enabled on iTerm, maybe that's why it's not failing for me?
It seems the lock file has some conflicts, by the way

@pablo-abc<EMAIL_ADDRESS>failed as it uses prebuilt go-binaries which aren't available for darwin arm in this version. Maybe you have installed esbuild globally?

It seems the lock file has some conflicts, by the way

Could you elaborate on this one? Don't see anything failing or conflicting in the CI or on my end.

@pablo-abc<EMAIL_ADDRESS>failed as it uses prebuilt go-binaries which aren't available for darwin arm in this version. Maybe you have installed esbuild globally?

It sounds to me more like we have Rosetta 2 set up in a different way tbh 😅. Anyway I'm ok with removing this since it's not useful for the build itself.

Could you elaborate on this one? Don't see anything failing or conflicting in the CI or on my end.

Ah, in the pull request. pnpm-lock.yaml has a conflict with the latest changes. You can fix it easily by merging the latest changes from main, discarding the changes to pnpm-lock.yaml on the merge conflict and running pnpm i again.

git wouldn't let me merge the conflicts and I didn't had the patiance to figure out why. So I redid the branch and opened a new pr #47.


use the current position in reprojection

Bug was introduced in #278 found by @sunzj
As now the current histogram is reprojected, also the current position should be used.

A more descriptive title would be nice, such that the git history is somewhat meaningful.
Otherwise I'm fine with this. Can you notice the difference in SITL?

@nicovanduijn  no, I don't see a difference, the effect is minimal.

I think this is small enough, SITL testing should be sufficient.


Proposing an Enhancement in XPath Engine of WinAppDriver w.r.t Inspect.exe

Hello WinAppDriver Team,
I would like to propose an enhancement in the XPath engine of WinAppDriver.
I see that all windows elements which are available in Inspect.exe have their properties in lowercase
but while building the Page source I see the first letter of Windows elements are uppercase
like Edit, Window etc..
In below screenshot, the window object mentioned in Inspect.exe and the exported page source shows differently.

If we could have uniformity in object naming then building XPath would be very easy and object discovery would be much simpler.
I learned that W3C specification says the tags mentioned in XPath should be in lower case letter.

@dhapolapankaj True but LocalizedControlType is language dependent (over here I get "venster" in Dutch). So it's a valid remark but not so useful for users whose Windows is not set to English.
On another note: does XPath even work with your WindowsDriver code? Here I get absolutely no results from XPath whatsoever... See issue 216.

@Exoow It was just an example.
BTW, I am able to locate any windows element present in Page Source. I am very fond of XPath and I use it heavily in my project. The only problem is it is slower than other locators like ID or Name.
The reason I raised this enhancement proposal will resolve your issue. The case sensitivity in XPath tags and attribute is main culprit you are not able to locate elements.
While embarking on WinAppDriver it took me sufficient amount of time to understand the XPath resolution behavior. Just give the Page source, I can locate any element and can create complex XPaths too ;)
Regards
PD

@dhapolapankaj Okay thanks, makes sense.
If you would be so kind to help, here you can see the first part of my Page Source, and my failing XPath. I have tried many variations but none work.
https://sqa.stackexchange.com/questions/28163/appium-why-does-xpath-not-work-at-all-as-expected

@Exoow could you please try solution mentioned in issue number #216

Hi Pankaj
How can I export page source for a UWP app, for which I don't have the source code i.e I have to automate the UWP app after deployment.

HI @anunayaabb,
PageSource attribute is available from any element and can be retrieved as shown in the following snippet taken from https://github.com/Microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/Source.cs#L39
var source = session.PageSource;

Xpath is throwing element not found exception but through UI recorder i got the below xpath:
/Pane[@Name="Desktop 1"][@ClassName="#32769"]/Window[@Name="Calculator - Calculator"][@ClassName="ApplicationFrameWindow"]/Window[@Name="Calculator"][@ClassName="Windows.UI.Core.CoreWindow"]/Group[@AutomationId="NumberPad"]/Button[@AutomationId="num8Button"][@Name="Eight"]
Anyone look into this what wrong in this

Hi @prasanna532,
If you're still facing this issue with the latest WinAppDriver v1.1.1 patch, can you please create a new ticket? Thanks!


⚠ Samsung has degraded performance

In 39f658d, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2444 ms

Resolved: Samsung performance has improved in a44865c.


App continuously running?

Does the application have to run continuously on my computer or is there a way to host this somewhere where it could receive a POST request?

You can run it wherever, but it does have to continuously run.
It would probably fit nicely on a free tier EC2 instance.


[v2.5] KDM release: k8s feb patches

This KDM release is going out with Rancher v2.5.6 release for new k8s versions: v1.17.18, v1.18.16, v1.19.8 and v1.20.3.

There are existing k8s versions in dev-v2.5 that haven't been released (absent in release-v2.5), so the same versions can be updated. Following versions need to be updated with their compatible rancher server versions:

update version from
to
update rancher version constraints

v1.20.2-rancher2-1
v1.20.3-rancher1-1
2.5.6+

v1.19.7-rancher2-1
v1.19.8-rancher1-1
2.5.0+

v1.18.15-rancher2-1
v1.18.16-rancher1-1
2.4.5+

v1.17.17-rancher2-1
v1.17.18-rancher1-1
2.4.4+

Following system images need to be updated:

Name
Kubernetes Version
Version

windowsPodInfra
v1.20.3
v0.1.6

Update constraints for all addon versions so the new Kubernetes versions use the right template. Refer to the table below to confirm the template name.

 Confirm the versions for System Images and Addon templates are correct. Update this table if new versions get introduced. Click to view the full list.

Name
Kubernetes Version
Version
Update constraints for addon versions if required

etcd
1.17.18, v1.18.16
v3.4.3-rancher1

etcd
v1.19.8
v3.4.13-rancher1

etcd
v1.20.3
v3.4.14-rancher1

kube-dns
v1.17.18
v1.15.0
kubeDnsv116

kube-dns
v1.18.16
v1.15.2
kubeDnsv116

kube-dns
v1.19.8, v1.20.3
v1.15.10
kubeDnsv116

core-dns
v1.17.18
v1.6.5
coreDnsv117

core-dns
v1.18.16
v1.6.9
coreDnsv117

core-dns
v1.19.8
v1.7.0
coreDnsv117

core-dns
v1.20.3
v1.8.0
coreDnsv117

flannel
v1.17.18, v1.18.16
v0.12.0
flannelv116

flannel
v1.19.8, v1.20.3
v0.13.0
flannelv116

calico, canal
v1.17.18, v1.18.16
v3.13.4
canalv117PrivilegedCalico3134, calicov117Privileged

calico, canal
v1.19.8
v3.16.5
canalv3165, calicov3165

calico, canal
v1.20.3
v3.7.2
canalv3171, calicov3171

weave
v1.17.18, v1.18.16
v2.6.4
weavev116

weave
v1.19.8
v2.7.0
weavev116

weave
v1.20.3
v2.8.1
weavev120

aci
all
<IP_ADDRESS>.1ae238a
aciv500

metrics-server
v1.17.18, v1.18.16, v1.19.8
v0.3.6
metricsServerv18

metrics-server
v1.20.3
v0.4.1
metricsServerv120

podInfra
v1.17.18, v1.18.16
3.1

podInfra
v1.19.8, v1.20.3
3.2

node local
v1.17.18, v1.18.16
1.15.7
nodelocalv115

node local
v1.19.8, v1.20.3
1.15.13
nodelocalv115

rancher forks

dns-autoscaler
v1.17.18, v1.18.16
v1.7.1

dns-autoscaler
v1.19.8, v1.20.3
v1.8.1

flannel-cni
all
v0.3.0-rancher6

ingress
v1.17.18, v1.18.16, v1.19.8
nginx-0.35.0-rancher2
nginxIngressV11512

ingress
v1.20.3
nginx-0.43.0-rancher1
nginxIngressV11512

ingress-backend
all
1.5-rancher1

rke-tools
all
v0.1.71

windowsPodInfra
v1.17.18, v1.18.16, v1.19.8, v1.20.3
v0.1.6

Verifications on 2.5.6-rc5  – PASS
Spin up a rancher cluster with 2.5.6-rc5.
Verified the metadata is pointing to dev-v2.5
KDM job pointing to dev-v2.5 for all the network providers on the k8s version v1.20.4-rancher1-1.
Once the job succeeds, ran network test cases on all the clusters - PASS
Ran validation test cases on the canal cluster - PASS
Verification on Rancher | v2.5.5 - PASS
Spin up a rancher cluster with 2.5.6-rc5.
Verified the metadata is pointing to release-v2.5 and updated it to dev-v2.5
KDM job pointing to dev-v2.5 for all the network providers on the k8s version v1.19.8-rancher1-1, v1.18.16-rancher1-1, v1.17.17-rancher2-1 for all the network providers.
Once the job succeeds, ran network test cases on all the clusters - PASS
Ran validation test cases on the canal cluster - PASS

Verification of Upgrade testing (v2.5.5) KDM -- PASS

using rancher v2.5.5 with release-v2.5 KDM:

test downstream clusters on v1.19.7-rancher1-1 and v1.18.15-rancher1-1
run preupgrade checks PASS
change KDM to dev-v2.5
upgrade all ds clusters by one patch version (v1.19.7-rancher1-1 or v1.18.16-rancher1-1)
run postupgrade checks (PASS -- one test failed, no signs it was related to version changes)
verified all other image versions matched expected version number (rke-tools, etcd, node local, ...)

Verification of Min checks (v2.5.3) KDM -- PASS

using v2.5.3 pointing to dev-v2.5:

test downstream clusters on the latest (v1.19.7-rancher1-1 and v1.18.16-rancher1-1)
run network tests (PASS -- one test failed, no signs it was related to KDM version)
verified all other image versions matched expected version number (rke-tools, etcd, node local, ...)

Reopening this to check 1.17.7-rancher2-1 (rke tools version)
To validate:

fresh install of 2.5.6-rc5 Deploy canal cluster with 1.17.7-rancher2-1 k8s version.
Verify new rke-tools is available
Run network checks on this cluster

On 2.5.5
Steps:

changed KDMDeploy canal cluster with 1.17.7-rancher2-1 k8s version.
rke-tools available - rancher/rke-tools v0.1.71
tests on the cluster look good


Update README.md

am I right this should be --recipe instead of --recipe-file ?

Hey you're completely right!


chore: bdd-sbrp-import-1577539636 to 0.0.1

chore: Promote bdd-sbrp-import-1577539636 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add Pittsburgh event

Add Pittsburgh event

himm... I made some amendments but apparently was not able to manage to resolve the conflict :( could anyone help me please?


Add "Juice" to picking a card.

Slightyly scale card up when hovering over it; scale it down when not.
Apply wobble (squash and stretch) when clicking on it (Mouse button down).
Rotate card (show face, hide back) when confirming clicking (Mouse button up).
Can be done through animations.

Card flipping added through animation.
Card highlighting when hovering over has to be done through code.

Card highlighting when hovering over has to be done through code.
Can also be done through adding Node2D that owns sprites, and changing its transforms


vagrant up fails, ceph.com trusty gpg issue

==> ceph-admin: Running: inline script
==> ceph-admin: stdin: is not a tty
==> ceph-admin: Get:1 http://security.ubuntu.com trusty-security InRelease [65.9 kB]
==> ceph-admin: Ign http://archive.ubuntu.com trusty InRelease
==> ceph-admin: Get:2 http://archive.ubuntu.com trusty-updates InRelease [65.9 kB]
==> ceph-admin: Get:3 http://security.ubuntu.com trusty-security/main Sources [124 kB]
==> ceph-admin: Hit http://archive.ubuntu.com trusty-backports InRelease
==> ceph-admin: Hit http://archive.ubuntu.com trusty Release.gpg
==> ceph-admin: Get:4 http://security.ubuntu.com trusty-security/universe Sources [49.3 kB]
==> ceph-admin: Get:5 http://archive.ubuntu.com trusty-updates/main Sources [391 kB]
==> ceph-admin: Get:6 http://security.ubuntu.com trusty-security/main amd64 Packages [579 kB]
==> ceph-admin: Get:7 http://ceph.com trusty InRelease
==> ceph-admin: Splitting up /var/lib/apt/lists/partial/ceph.com_debian-hammer_dists_trusty_InRelease into data and signature failed
==> ceph-admin: Ign http://ceph.com trusty InRelease
==> ceph-admin: E
==> ceph-admin: :
==> ceph-admin: GPG error: http://ceph.com trusty InRelease: Clearsigned file isn't valid, got 'NODATA' (does the network require authentication?)
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

I tried with http://download.ceph.com and kraken, that seems to not have this issue.


flutter 3.0 support

                 ^

/D:/soft/flutter/.pub-cache/hosted/pub.flutter-io.cn/pull_to_refresh-2.0.0/lib/src/internals/indicator_wrap.dart:393:22: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/D:/soft/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {

Warnings after migrate do flutter 3:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/smart_refresher.dart:788:20:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/smart_refresher.dart:796:20:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/smart_refresher.dart:803:20:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/internals/indicator_wrap.dart:260:24:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/internals/indicator_wrap.dart:290:22:
/c:/flutter/.pub-cache/hosted/pub.dartlang.org/pull_to_refresh-2.0.0/lib/src/internals/indicator_wrap.dart:393:22:

Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('/c:/flutter/packages/flutter/lib/src/widgets/binding.dart').
      WidgetsBinding.instance!.addPostFrameCallback((_) {
                     ^

: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback(
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addObserver(this);
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.removeObserver(this);
^
: Warning: Operand of null-aware operation '?.' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance?.addPostFrameCallback((_) => onReady());
^
: Warning: Operand of null-aware operation '?.' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance?.addPostFrameCallback((_) => onReady());
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.

'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback((_) {
^

: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.

'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback(
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.addObserver(this);
^
: Warning: Operand of null-aware operation '!' has type 'WidgetsBinding' which excludes null.
'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/widgets/binding.dart').
WidgetsBinding.instance!.removeObserver(this);
^
: Warning: Operand of null-aware operation '?.' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance?.addPostFrameCallback((_) => onReady());
^
: Warning: Operand of null-aware operation '?.' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance?.addPostFrameCallback((_) => onReady());
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback((_) {
^
: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('../../../Downloads/flutter/packages/flutter/lib/src/scheduler/binding.dart').
SchedulerBinding.instance!.addPostFrameCallback((_) {
^

Please add this to your pubspec.yaml file while this repo haven't approved the PR
dependency_overrides:     pull_to_refresh:         git:             url: https://github.com/miquelbeltran/flutter_pulltorefresh

dependency_overrides:
pull_to_refresh:
git:
url: https://github.com/miquelbeltran/flutter_pulltorefresh

dependency_overrides: pull_to_refresh: git: url: https://github.com/miquelbeltran/flutter_pulltorefresh

this doesn't work for me.
i have this error:
Because myProject depends on dependency_overrides from unknown source "pull_to_refresh", version solving failed.
pub get failed (1; Because myProject depends on dependency_overrides from unknown source "pull_to_refresh", version solving failed.)

@nixonoftheyear
Use it like this:
dependency_overrides:
pull_to_refresh:
git:
url: https://github.com/miquelbeltran/flutter_pulltorefresh
ref: master

@nixonoftheyear
Use it like this:
dependency_overrides: pull_to_refresh: git: url: https://github.com/miquelbeltran/flutter_pulltorefresh ref: master

another problem now:
Because myProject depends on dependency_overrides from unknown source "pull_to_refresh", version solving failed.
is there any command for enable unknow source or anything similar?

You have original dependency added in dependencies?
dependencies:
pull_to_refresh: ^2.0.0
dependency_overrides:
pull_to_refresh:
git:
url: https://github.com/miquelbeltran/flutter_pulltorefresh
ref: master
This one works for me without any issue.

Also please remember that spacing/tabulation in yaml file is important the dependency_overrides needs to be at the same level as dependencies.
Like this:

Also please remember that spacing/tabulation in yaml file is important the dependency_overrides needs to be at the same level as dependencies.
Like this:

yes, i have
but android studio  highlight suggest: Remove prohibited property "pull_to_refresh"

Also please remember that spacing/tabulation in yaml file is important the dependency_overrides needs to be at the same level as dependencies.
Like this:

resolved! i was wrong to align dependency_overrides as the daughter of dependencies. thank you!
is it normal that the flutter pub get takes a long time (72 seconds instead 3 seconds)?

Also please remember that spacing/tabulation in yaml file is important the dependency_overrides needs to be at the same level as dependencies.
Like this:

resolved! i was wrong to align dependency_overrides as the daughter of dependencies. thank you! is it normal that the flutter pub get takes a long time (72 seconds instead 3 seconds)?

Great :)
Could be if fetching first time some repo.

While I greatly appreciate miquelbeltran's effort on providing a fork, I urge people to use ref: 6d7fbdd instead of just ref: master in your dependency overrides.
Using ref: master means whatever is commited to that repository is bundled and delivered in your application, no questions asked.

Hi everyone! I don't endorse the use of my fork (because I don't plan on maintaining it), instead, please insist on the library authors to merge this PR: https://github.com/peng8350/flutter_pulltorefresh/pull/589

same issue

pub search pull_to_refresh_flutter3


Handling "Non-Standard" AnnData Zarr Data

Related to https://github.com/hubmapconsortium/vitessce/issues/713, but this line for example https://github.com/vitessce/vitessce-python/blob/816e47dbb8b58aeece6013442d0b7f8e81abd8c4/vitessce/wrappers.py#L312-L313
is for a custom part of the AnnData so we should probably not have it as a standard loadable object.  Am I wrong? I can't find any documentation for CellType on the website.  This part of the documentation lays out how to use __categories/MY_CATEGORY (which is part of the zarr store) but also has a reference to cell_type.
I am coming across this stuff as I write the JSON API for declaring parts of AnnData store for usage in Vitessce.  It's tricky because it's not clear what we should have - for example, for spatial you might have something like
        {
          "type": "cells",
          "fileType": "anndata-cells.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": {
            "obsm.spatial": "xy",
            "obsm.poly": "poly"
          }
        },

Where the correspondence between our JSON schema terminology and this config is one to one but then for something like
        {
          "type": "cell-sets",
          "fileType": "anndata-cell-sets.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": {
            "obs.CellType": "sets"
          }

you don't have such a nice correspondence at which point you are dealing with "magic" strings.
I think the reason I am mentioning this hear is that we probably want to harmonize the terminology we use for custom parts of the store across languages.  Thoughts?

Yes 'CellType' is just specific to one .h5ad file I was working with at the time. I started to move away from it on this branch https://github.com/vitessce/vitessce-python/blob/keller-mark/widget-method/vitessce/wrappers.py#L315 where I added a parameter for the AnnDataWrapper contructor to identify which column of adata.obs to use for cell sets. This is still a bit limiting though since as you point out there can be multiple columns with categorical data and we may want to output all of them as multiple cell set hierarchies. Maybe we can instead support a list of columns, like cell_set_obs_cols = [] and then the user could write something like AnnDataWrapper(adata, cell_set_obs_cols=["CellType", "leiden"]) based on the columns they want to use for cell sets.

When reading straight from JSON, I think it may be helpful if the options object is reversed:
{
          "type": "cell-sets",
          "fileType": "anndata-cell-sets.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": {
            "sets": ["obs.cellType", "obs.leiden"]
          }

and
{
          "type": "cells",
          "fileType": "anndata-cells.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": {
            "xy": "obsm.spatial",
            "poly": "obsm.polygon"
          }
        },

I was just typing that...the sets example was making me think that the direction was wrong in how I laid things out...  I am still not a fan of magic strings but I like where it's headed.  I think we should try to cover our bases in Python around customization as much as possible and then port it to Javascript/JSON since once it's out in JS, we can't take it back whereas here we have a bit of a sandbox here to play in.  I'll try loading Matt's datasets as well as going out and looking for others on the internet.

When these are the values rather than the keys, we don't need to use magic strings, we can use arrays like ["obsm", "X_umap"] which would mean obsm.X_umap

Maybe
{
          "type": "cell-sets",
          "fileType": "anndata-cell-sets.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": {
            "sets": [["obs","CellType"], ["obs", "leiden"]]
          }

where each element of "sets" is a path to the column that should be used to define each cell set hierarchy

When these are the values rather than the keys, we don't need to use magic strings, we can use arrays like ["obsm", "X_umap"] which would mean obsm.X_umap

I was referring more to sets as a key as opposed to xy and poly for example, but perhaps I am being too nit-picky. sets does not exist in our json schema but xy and poly do.

Ah I see. Actually then something more like the cell-sets-tabular schema may be better https://github.com/hubmapconsortium/vitessce/blob/master/src/schemas/cell-sets-tabular.schema.json
Maybe
{
          "type": "cell-sets",
          "fileType": "anndata-cell-sets.zarr",
          "url": "http://<IP_ADDRESS>:8081/habib.zarr",
          "options": [
              {
                   "group_name": "Cell Type",
                   "set_name": ["obs", "CellType"],
                    "prediction_score": ["obs", "CellTypeScore"]
               },
              {
                   "group_name": "Leiden Clustering",
                   "set_name": ["obs", "leiden"]
               }
          ]

where set_name and prediction_score are assumed to be paths to AnnData columns, and group_name is assumed to be the name of the hierarchy, and cell_id is not needed since it would be automatically assigned based on the Cell IDs in the AnnData index.

I will close this now that we have https://github.com/vitessce/vitessce/pull/807 and open a new issue for integrating it here


PANGOLIN-3515 - CH MoneyDraft & Payment presets

The following is covered in this PR:

Adjustment to the CH PaymentDraft preset withUsdCurrencyCode to accommodate recent fixes to to PaymentStatus of the last major release.
Further narrowing down of a the withUsdCurrencyCodeCentMax preset for CH MoneyDraft
Pull the withUsdCurrencyCodeCentMax preset into PaymentDraft.amountPlanned, as this was also causing an Int cannot represent non 32-bit signed integer value error (discovered once Transaction.amount was settled).

Approving but do want to see the follow up happen in https://commercetools.atlassian.net/browse/PANGOLIN-3488 as I suspect we can get rid of the withUsdCurrencyCodeCentMax if we update the MoneyDraft generator to only generate values that can possibly be stored in the database and be accepted by the coco api. If we know this is a needed global fix, we shouldn't contain it to just our presets.


Error when adding bottle of type Irish Whiskey

sqlalchemy.exc.DataError: (MySQLdb.DataError) (1265, "Data truncated for column 'type' at row 1") [SQL: INSERT INTO bottle (id, date_created, name, type, year, abv, url, description, review, stars, cost, date_purchased, date_opened, date_killed, image_count, distillery_id, user_id) VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s)] [parameters: (UUID('07656daa-999c-4bc7-8685-998caa8f6220'), datetime.datetime(2023, 3, 4, 21, 49, 42, 966296), 'asdf', 'irish_whiskey', None, None, None, None, None, None, None, None, None, None, 0, '7b476ba2-4c10-465e-a8d7-0d2cc24575d5', '5adf9c67-136d-4f85-af17-7e85eedaebda')] (Background on this error at: https://sqlalche.me/e/20/9h9h)
Seems weird. This is an enum field.

For some reason, 'irish_whiskey' was not part of the enum column def. Fixed on local and prod.


Cannot start on Ubuntu 24.04: "RuntimeError: unable to mmap ... Cannot allocate memory (12)"

I'm very new to this, and it's possible that I am missing the obvious.
ubuntu 24.04
$ uname -a
Linux benj-pc 6.8.0-40-generic #40-Ubuntu SMP PREEMPT_DYNAMIC Fri Jul  5 10:34:03 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

$ python -V
Python 3.10.14

$ lspci -vnn | grep -A 12 '\''[030[02]\]' | grep -Ei "vga|3d|display|kernel"
0c:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M] [1002:73ff] (rev c7) (prog-if 00 [VGA controller])
	Kernel driver in use: amdgpu
	Kernel modules: amdgpu

$ free -h
               total        used        free      shared  buff/cache   available
Mem:            31Gi        10Gi       1.2Gi       206Mi        19Gi        20Gi
Swap:          8.0Gi       512Ki       8.0Gi

I followed the README instructions, and I get the following:
$ python -m flux --name flux-schnell --loop
You are using the default legacy behaviour of the <class 'transformers.models.t5.tokenization_t5.T5Tokenizer'>. This is expected, and simply means that the `legacy` (previous) behavior will be used so nothing changes for you. If you want to use the new behaviour, set `legacy=False`. This should only be set if you understand what it means, and thoroughly read the reason why this was added as explained in https://github.com/huggingface/transformers/pull/24565
/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/transformers/tokenization_utils_base.py:1601: FutureWarning: `clean_up_tokenization_spaces` was not set. It will be set to `True` by default. This behavior will be depracted in transformers v4.45, and will be then set to `False` by default. For more details check this issue: https://github.com/huggingface/transformers/issues/31884
  warnings.warn(
Traceback (most recent call last):
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 575, in load_state_dict
    return torch.load(
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/torch/serialization.py", line 1087, in load
    overall_storage = torch.UntypedStorage.from_file(os.fspath(f), shared, size)
RuntimeError: unable to mmap<PHONE_NUMBER>9 bytes from file </home/benj/.cache/huggingface/hub/models--google--t5-v1_1-xxl/snapshots/3db67ab1af984cf10548a73467f0e5bca2aaaeb2/pytorch_model.bin>: Cannot allocate memory (12)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 584, in load_state_dict
    if f.read(7) == "version":
  File "/usr/lib/python3.10/codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 64: invalid start byte

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/benj/workspace/flux/src/flux/__main__.py", line 4, in <module>
    app()
  File "/home/benj/workspace/flux/src/flux/cli.py", line 250, in app
    Fire(main)
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/home/benj/workspace/flux/src/flux/cli.py", line 158, in main
    t5 = load_t5(torch_device, max_length=256 if name == "flux-schnell" else 512)
  File "/home/benj/workspace/flux/src/flux/util.py", line 131, in load_t5
    return HFEmbedder("google/t5-v1_1-xxl", max_length=max_length, torch_dtype=torch.bfloat16).to(device)
  File "/home/benj/workspace/flux/src/flux/modules/conditioner.py", line 18, in __init__
    self.hf_module: T5EncoderModel = T5EncoderModel.from_pretrained(version, **hf_kwargs)
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 3738, in from_pretrained
    state_dict = load_state_dict(resolved_archive_file)
  File "/home/benj/workspace/flux/.venv/lib/python3.10/site-packages/transformers/modeling_utils.py", line 596, in load_state_dict
    raise OSError(
OSError: Unable to load weights from pytorch checkpoint file for '/home/benj/.cache/huggingface/hub/models--google--t5-v1_1-xxl/snapshots/3db67ab1af984cf10548a73467f0e5bca2aaaeb2/pytorch_model.bin' at '/home/benj/.cache/huggingface/hub/models--google--t5-v1_1-xxl/snapshots/3db67ab1af984cf10548a73467f0e5bca2aaaeb2/pytorch_model.bin'. If you tried to load a PyTorch model from a TF 2.0 checkpoint, please set from_tf=True.

RTX 4070 12G - Same problem.

You both do not have enough VRAM. This model, even the smaller one, is still very large. As far as I understand, you really do need something like an A100 to run this. I cannot run this on my 4070 Super because UVM doesn't work on nvidia drivers (it should work, but it doesn't), and like you, I run out of VRAM.
If you do not have enough VRAM, or working "Shared Memory" (nvidia doesn't work: https://github.com/NVIDIA/open-gpu-kernel-modules/issues/663)
I can't tell you for AMD, how to get shared memory to work. I have never had an AMD card. Good luck.
If you want to try it without the GPU, python -m flux --name flux-schnell --loop --device cpu will allow you to run this. However, as you can imagine, very, very slow. Integrated GPUs also can be used, if you have one. Usually these have good shared memory support.
Unfortunately, on Windows, shared memory usually works fine. You may have better luck with that+ WSL2.
The real solution is for the graphics card manufacturers to fix their shared memory implementation in their linux kernel drivers. You can send them a strongly worded email :smiley:

I have a 3060 12GB, driver version 555.58.02, and I am running Pop OS, using the provided scripts gave me the same out of memory error. However, I was able to run it with the following script in the same venv.
import torch
from diffusers import FluxPipeline
torch.cuda.empty_cache()
pipe = FluxPipeline.from_pretrained("black-forest-labs/FLUX.1-dev", torch_dtype=torch.bfloat16)
pipe.enable_model_cpu_offload()
pipe.enable_sequential_cpu_offload()
prompt = "Your Prompt Here"
out = pipe(
prompt=prompt,
guidance_scale=1.5,
height=768,
width=1360,
num_inference_steps=7,
).images[0]
out.save("image.png")
Hope this helps.

Thanks man. It sucks the startup examples given in the readme don't take this into account - however - an effective gatekeeping method (It certainly gatekept me!)


Is this project alive?

Or is there a recommended successor?  This project came as "the" recommended one for local machine scala dataframes by a UK professor two years ago .. so it would be of interest:   https://darrenjw.wordpress.com/2015/08/21/data-frames-and-tables-in-scala/

Hi! I'm not actively maintaining this project anymore. I'd probably take a look at Frameless, which runs on top of Spark, and see if that'll work.

on top of spark .. well i gave a talk on spark DataFrame's in 2015 .. so i
kinda know about that already . I need a local version.  Looks like
pandas/python it is..
2017-08-20 19:12 GMT-07:00 Tom Switzer<EMAIL_ADDRESS>
Hi! I'm not actively maintaining this project anymore. I'd probably take a
look at Frameless https://github.com/typelevel/frameless, which runs on
top of Spark, and see if that'll work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tixxit/framian/issues/73#issuecomment-323630672, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZEkbmbmY9pCTE0sf1CNMhFG0o7GEYyks5saOeTgaJpZM4O8vAr
.

Ah yeah, sorry then - I'm not sure if there is a good replacement. Good luck!


switch forwards and settled payments to grammy

Switching notifyOfForwards and postSettledPayment to use grammy over request.
Files changed:
post/notify_of_forwards.js
post/post_settled_payment.js

https://github.com/alexbosworth/balanceofsatoshis/issues/176

these are cool, my main concern is that we saw some problems with the other changes where send couldn't be a drop in replacement because sendMessage(request) does a fallback to no-markdown which is a second post to telegram
when we dropped it in, it caused a problem where some messages got dropped when there was an error
2 ways to go here:

if await send fails, try again without markdown or any formatting
convert formatting of messages to use MarkdownV2 and do proper escaping everywhere

I can convert to MarkdownV2, from what I tested I don't see any errors, but we never know with these formattings.

I've seen some forwards posted to my telegram with markdown symbols in them, which means it failed on the first pass

I added escaping and switched to V2 and it seems to be working ok, the only issue I don't seem to understand is, for some reason, it's notifying a forward twice.

I think this will cause test_notify_of_forwards to fail if the strings aren't updated?

Right, I think the test needs to be updated with escaping and also with the send function replacing request and API args.

I replaced the previous tests, it just requires making a dummy send function and then putting \ next to the special characters

Updated the test. * need not be escaped btw.

ok looks like the duplicate forward message issue got fixed as well. No idea how it fixed itself though, maybe return cbk() vs return; was causing an issue.


Guidelines implementation: Attributes

[ ] Implement and apply rule awslint:attribute-coverage: AWS resource construct interface should expose all CFN resource attributes
[ ] Implement and apply rule awslint:attribute-tag: Resource attribute properties should be tagged with "@attribute"
[ ] Implement and apply rule awslint:attribute-name: Resource attribute properties should begin with the type name ("bucketArn" instead of "arn")
[ ] Implement and apply rule awslint:attribute-name-tag: If a property starts with "bucket", it must be a resource attribute
[ ] Implement and apply rule awslint:attribute-readonly: Resource attribute properties must be readonly
[ ] Implement and apply rule awslint:attribute-type: Resource attributes should have a "string" or "string[]" type
[ ] Implement and apply rule awslint:attribute-doc-returns-token: Resource attribute jsdocs should include text that indicates this is an opaque token

Split into multiple issues


How to render more than one viewer in one template/dom

I need to render multiple pdfs in multiple viewers respectively in the same template/dom.
I'm getting the following issue even though I'm using different canvases with different ids. I think the issue is because of the promises(of the first pdf) are not being resolved in time. which makes the second viewer break. I mean I'm getting the first pdf properly in the first viewer but second is breaking and giving the below issue.

Appreciate the help! Thanks

The error is thrown at https://github.com/mozilla/pdf.js/blob/103f4616accbd29755e6d150f0a7c2e7a6bc6546/src/display/api.js#L2402-L2406, so it looks like some canvas is being reused. Even though they have different IDs, your code may have a reference to another canvas. Without the code it's impossible to tell though, so unless that's provided as stated in the issue template, there is nothing more we can do.


Slow perfomance of Hands in iOS Safari

Please make sure that this is a solution issue.
This issue is reproduced in Hands solution.
System information (Please provide as much relevant information as possible)

Have I written custom code (as opposed to using a stock example script provided in Mediapipe): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4): iOS 15.4.1
MediaPipe version: latest v0.8.9
Bazel version: -
Solution (e.g. FaceMesh, Pose, Holistic): Hands
Programming Language and version ( e.g. C++, Python, Java): JS

Describe the expected behavior:
Official web example on code pen, run extremely slow at iOS devices (tested on iPhone 11, iPhone 12 Pro max, iPhone 13 pro). It show around 6-7 fps at all. At same time, at Android it run pretty well.
Also if i run raw graph "Hand Tracking" at MediaPipe Visualizer it run at 30 FPS at iOS devices.
Standalone code you may have used to try to get what you need :
If there is a problem, provide a reproducible test case that is the bare minimum necessary to generate the problem. If possible, please share a link to Colab/repo link /any notebook:
Just open web demo at iOS device.
Other info / Complete Logs :
Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached:

Hi @spaskhalov ,
could you please share any reference videos w.r.t above issue.

Of course. Here it is.Pay attention to FPS counter and web cam feed.
https://youtube.com/shorts/2RHGtFGeiUk?feature=share

I can also confirm that on a Mac M1 Max (similar ARM son architecture), the frame rate drops precipitously.

@sureshdagooglecom can you confirm, that problem exists for you?

Hi @spaskhalov ,
Below is the code to build Ios.
load("@build_bazel_rules_apple//apple:ios.bzl", "ios_framework")
ios_framework(
name = "MyFramework",
hdrs = [
"ObjcClass.h",
],
infoplists = ["Info.plist"],
bundle_id = "com.noppelab.MyFramework",
families = ["iphone", "ipad"],
minimum_os_version = "10.0",
deps = [
":HandTrackingGpuAppLibrary",
"@ios_opencv//:OpencvFramework",
],
)
objc_library(
name = "HandTrackingGpuAppLibrary",
srcs = [
"ObjcClass.mm",
],
hdrs = [
"ObjcClass.h",
],
sdk_frameworks = [
    "AVFoundation",
    "CoreGraphics",
    "CoreMedia",
    "UIKit"
],
copts = ["-std=c++17"],
data = [
    "//mediapipe/graphs/hand_tracking:hand_tracking_mobile_gpu.binarypb",
    "//mediapipe/modules/hand_landmark:hand_landmark.tflite",
    "//mediapipe/modules/hand_landmark:handedness.txt",
    "//mediapipe/modules/palm_detection:palm_detection.tflite",
],
deps = [
    "//mediapipe/examples/ios/common:CommonMediaPipeAppLibrary",
    "//mediapipe/util:annotation_renderer",
] + select({
    "//mediapipe:ios_i386": [],
    "//mediapipe:ios_x86_64": [],
    "//conditions:default": [
        "//mediapipe/graphs/hand_tracking:mobile_calculators",
        "//mediapipe/framework/formats:landmark_cc_proto",
    ],
}),

)
Could you please check this https://github.com/google/mediapipe/issues/2507#issuecomment-916900036 to buld hands on ios.

@sureshdagooglecom, Hi! I have problems with running Hands solution in Safari on iOS. So i don't think that my problem is related with https://github.com/google/mediapipe/issues/2507#issuecomment-916900036 . BTW in native iOS app Hands solution performance is great!

I can confirm, that forcing set useCpuInference to false (more details here) is help us.


WIP : Move Logs to var directory.

Automated message from Dropbox CLA bot
@staranjeet, it looks like you've already signed the Dropbox CLA. Thanks!

Merged these, after some fixes to directly update .gitignore and not put the build-release-tarball output logs in a confusingly different place.  Please check 44d2397 to see the preferred style.
Thanks @staranjeet!


Did you intend to remove docker support?

Dockerfile, docker-compose.yml were removed in this commit: https://github.com/avatsaev/angular-contacts-app-example/commit/2796b400c939391592302e4acc9cd05a6b017bb6
Not sure if accidentally removed or not, but docker is still referenced in latest README

Sorry I needed to update the whole Docker thing to use Angular CLI's new Workspaces workflow.
This commit adds docker support: https://github.com/avatsaev/angular-contacts-app-example/commit/878de465c11036cf9318b052a6e56db73454ac01
Should work fine, let me know if it worked for you


Race condition on @on_load callback

Describe the bug
Initially reported here: https://github.com/elixir-lang/elixir/issues/12777
This code:
https://github.com/swoosh/swoosh/blob/v1.11.3/lib/swoosh/mailer.ex#L236-L256
Uses Code.ensure_loaded/1 which is not sufficient if the adapter module is defined within the same application as the mailer module, as Code.ensure_loaded/1 does not wait for the module to be compiled, so depending on the order compilation goes, the check may fail.
Steps to Reproduce the Bug or Issue
It is hard to reproduce since it is a race condition but we have isolated the root case.
Expected behavior
One quick fix is to use Code.ensure_compiled/1. However, my suggestion is to move the @on_load check altogether to compile-time (via @before_compile/@after_compile callbacks) and use Code.ensure_compiled there. I don't see the need to check for this at runtime. The way Elixir manages your dependencies, you should assume that if a module is available at compile-time, it will be available at runtime.
Thank you!
Your reproducible example
No response
Screenshots or Videos
No response
Platform
It happens in any Erlang/OTP and Elixir version, but some versions may be more likely than others depending on how fast compilation goes.
Additional context
Thank you! :heart:

I love that making the compiler faster exposes a race condition.

Released 1.11.4 with Code.ensure_compiled/1. This should buy me time for the bigger refactor :)

Closing as explained in #793. Thanks!


Consider using PostCSS

https://github.com/ai/postcss
In v4 it should be fairly trivial to switch parsers.
Look at this once #17 is complete.
Would address #33.

:+1:

@BlessCSS/contributors I think this is still valid.

Agreed, I'd rather approach this once we bring in the ES6 changes from #62 though. Should be equally simple to do with those changes.

There might be something better in the works that I can't discuss yet.
Wanted to make a note as a reminder for later.

Hi @paulyoung I'd like to help out to make this happen. I really want this to be done in my postcss pipeline. Is there anything I could help with? Starting at #17?

Hi @tomchentw! I've added some information to #17, but probably best to coordinate with @mtscout6.

@paulyoung Is this absolutely required for 4.0? Or can we kick it out of the v4 milestone?

@mtscout6 I don't think it's a prerequisite for a 4.0 release. In theory it should be a backwards-compatible change anyway.

Ok, do you mind if we drop it from the milestone then?

Done :+1:


Add happy-case walkthroughts to user docs

Problem
The "Users" docs for Jupyter Scheduler only cover installation, not usage.
Proposed Solution
Add descriptions, with screen shots, of what users can do with Jupyter Scheduler and how they can do it.
Additional context
This is a follow-up to #311, which created ReadTheDocs docs.

Fixed by #323


Add a way to mirror webcam

For cameras that are flipped (or when using it via an actual mirror)
Inspiration: https://twitter.com/smashjarchive/status/1319356710939693057

Hey there, I'm working on a project similar to Handsfree but this is much farther developed so I'd like to help out where I can!
If doing this in CSS is okay, I used (works on laptop and mobile):

video {
-webkit-transform: scaleX(-1);
transform: scaleX(-1);
}
canvas {
-webkit-transform: scaleX(-1);
transform: scaleX(-1);
}

Oh this totally works! Maybe this can be configurable? Something like:
handsfree = new Handsfree({
  feedback: {
    enabled: true,
    flipped: true
  }
})

//or

handsfree.feedback.flip()

And I would love some help, even comments like these are immensely helpful. Also let me know how I can help you as well, or if you need any features like a gesture recorder (which I'll be starting after I finish the docs). I've been getting a few DMs recently so I plan on starting a Slack or Discord once the docs are finished so that I can offer support quicker.

Making it configurable would be cool!
Thank you, I'm a student and I want to try and contribute where I can since this project reflects a passion of mine as well! I've been trying to implement hand pose for accessible augmented reality on smartphones and the basic interaction functionality is pretty similar to this.
I would love to help in every capacity that I can. I've been looking at the Roadmap and will hopefully start creating PRs soon!

Oh right I was looking at your work yesterday night that is sooooo amazing!
It's undocumented, but I have raycasting from finger tips partially working:

I've disabled that plugin because in my case it didn't work well with the hand pointed at the screen (I was trying to create "finger laser pointer"), but I think this will work really well in your use case with the hand pointing away. Here's a simple plugin that could implement the raycaster from fingers:
handsfree.use('raycaster', {
  onFrame ({hand}) {
    // Dig into the handpose helpers (will document soon)
    this.handsfree.handpose.three.raycaster.set(this.handsfree.handpose.three.arrow.position, this.handsfree.handpose.three.arrow.direction.normalize())

    // Do something with hits
    const hits = this.handsfree.handpose.three.raycaster.intersectObject(this.handsfree.handpose.three.screen, true)
    if (hits) {
      // ...
    }
  }
})

Anyways, I'm really excited by what you are doing!


Feature/downvote response

WIP

Add the ability for a user to give a detailed rating on a query

Let's reduce the width of the modal to the width of the chatbox such that it is a floating modal at the bottom. Now, its too wide

I've made the necessary changes for this


chore(main): release 0.6.0

:robot: I have created a release beep boop
0.6.0 (2024-07-14)
Features

Move the Python bindings into a standalone repository (ded267a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

0.6.0
:sunflower:


[rtextures] ImageText() scaling spacing incorrect

rtextures.c, Line 1243:
int spacing = fontSize/defaultFontSize;
As long as the fontSize is identical to the defaultFontSize, all is good. If you try to scale the font to, say, 4x the default size, the you get the spacing squared, so instead of 4 pixels between letters, you get 16.
The line should read:
int spacing = 1;
Code block at line 1303 already scales everything up, so no need to do it twice.

@fctr Sorry, I don't understand the issue. If fontSize = 40 and defaultFontSize = 10, then spacing = 4 as expected...

MeasureText and DrawText don't match. Do a fontSize = 10 and defaultFontSize = 10, and DrawText("Hello World"). Then do a fontSize = 40 and defaultFontSize = 10, and DrawText("Hello World"). You'll notice for the second one, the spacing between the characters is wrong, and MeasureText returns what it SHOULD be, but not what it actually is.

@fctr Please, could you provide some screenshot or sample code illustrating the issue?

int main()
{
    InitWindow(640, 480, "RayLib Rocks");
    Image i = GenImageColor(640, 300, RED);
    ImageDrawText(&i, "This is a test", 1, 1, 10, WHITE);
    ImageDrawText(&i, "This is a test", 1, 31, 40, WHITE);
    SetTargetFPS(60);
    while (!WindowShouldClose())
    {
        Texture2D t = LoadTextureFromImage(i);
        BeginDrawing();
        DrawText("This is a test", 1, 1, 10, WHITE);
        DrawText("This is a test", 1, 51, 40, WHITE);
        DrawTexture(t, 0, 100, WHITE);
        EndDrawing();
        UnloadTexture(t);
    }
    UnloadImage(i);
    CloseWindow();
    return 0;
}

Give that a whirl and you'll see what I mean. You'll need to change line 3158 in rtextures.c to:
ImageDrawTextEx(dst, GetFontDefault(), text, position, (float)fontSize, (float)1.0f, color);   // WARNING: Module required: rtext
and change line 1227 in rtext.c to:
textSize.x = (tempTextWidth + (float)((tempByteCounter - 1) * spacing)) * scaleFactor; // Adds chars spacing to measure

THANK YOU SO MUCH FOR EVERYTHING!

@fctr I'm afraid the proposed change just broke MeasureTextEx():

            DrawText("Congrats! You created your first window!", 190, 200, 20, LIGHTGRAY);
            DrawRectangle(190, 200, MeasureText("Congrats! You created your first window!", 20), 20, Fade(RED, 0.5f));

I'm reverting the change, please, send a PR with an update when reviewed.

Reviewed it and it seems it works as expected


fix:  Not able to see all the options of Font property as it is not scrollable +  Canvas scroll to top when I drop Tab widget on the canvas

Fixes #13582
Fixes #13598
Fixes #13591
Fixes #13641
Type of change

Please delete options that are not relevant.

Bugfix

How Has This Been Tested?

Manually tested

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/theming-bugs

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
56.57 (-0.01)
38.36 (-0.01)
35.84 (0)
56.82 (0)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

:green_circle:
app/client/src/widgets/TabsWidget/component/PageTabs.tsx
97.87 (-0.05)
85 (1.67)
100 (0)
97.73 (-0.05)

:green_circle:
app/client/src/widgets/TabsWidget/component/index.tsx
90.32 (5.61)
61.11 (0.58)
78.57 (15.41)
88 (7.7)

@jsartisan Tab issue is tested and working fine. I have tested Font Family issue on 13105

/ok-to-test sha=13641

/ok-to-test sha=13641

/ok-to-test sha=8b76e47

/ok-to-test sha=f4f6837

/ok-to-test sha=f4f6837

/ok-to-test sha=161665d

/ok-to-test sha=161665d

/ok-to-test sha=161665d

/ok-to-test sha=161665d

/ok-to-test sha=32270d4

/ok-to-test sha=d2f5725


[Enhance] Modify to let the plugin do the build completion detection not file system.

Fixed https://github.com/Jonghakseo/chrome-extension-boilerplate-react-vite/issues/184

@Jonghakseo And the question, we need to create this warn

IMO it's a little annoying, if i see i had an error, but in real i don't have, it's only information, clearing it don't work, cause after clean, we use it again, and after each socket disconnect this warn goes into this console.

IMO it's a little annoying, if i see i had an error, but in real i don't have, it's only information, clearing it don't work, cause after clean, we use it again, and after each socket disconnect this warn goes into this console.

@PatrykKuniczak
Good. I fixed it to output a log instead of a warning and try to reconnect every 1 second.

Works better, but after rebuild is done, the plugin don't be displaying properly.
THIS HAPPENED ONLY WHEN I'M ADD CODE
....

In my case, the problem was intermittently clearing files while waiting for a build of an existing file. I've modified the options, can you give it another try?


Raise distinct exceptions

This is a feature request to raise different distinct exceptions for meaningfully different scenarios

ICANN domains
Private domains
Actually invalid domains

Can you clarify the scenarios 1 and 2?

Gladly.
ICANN
> PublicSuffix.parse(URI.parse("http://engine.aero").host).domain
 => PublicSuffix::DomainIsICANN: engine.aero is an ICANN-protected domain

Private
> PublicSuffix.parse(URI.parse("http://blogspot.com").host).domain
 => PublicSuffix::DomainIsPrivate: blogspot.com is a private domain

Invalid (illogical)
> PublicSuffix.parse(URI.parse("http://asdf").host).domain
 => PublicSuffix::DomainNotAllowed: asdf is not allowed according to Registry policy

What is the purpose of this difference? Can you show me an example of how you plan to handle these cases (1, 2) differently?

Here's a simplified version of what I would like to do
User A is allowed to CRUD any logical domain
User B is allowed to CRUD any logical domain, excluding IANA domains
User C is allowed to CRUD any logical domain, excluding IANA and private domains
Domain column applies custom domain: true validation that tries to parse the the domain and returns true if it parses, or adds an error if it does not, except if the current user is users A or B and if the error class is DomainIsPrivate or if the current user is user A if the error class is DomainIsIANATLD it returns true.

You can't exclude IANA TLDs, this library would not make sense at all without them. Also, as I explained in #132, this library doesn't perform formal validation therefore foo_bar.com would be valid.
If what you are trying to achieve with this library is validating a domain, then this is probably not the correct library. You should probably use https://rubygems.org/gems/addressable or the URI stdlib package.

Will do -- thanks for your consideration.


I am using DeepExplainer, I need mini-batch.

Because GPU memory limitation, I implement a mini-batch version, even though my codes are not elegant.
#define explainer
background = np.load('ref.npy')
background1 = background[0:NUM_REFERENCE, :, :, :]
background2 = background[NUM_REFERENCE:NUM_REFERENCE*2, :, :, :]
e_list1 = []
for i in range(len(dicts_models)):
e = shap.DeepExplainer(dicts_models[0]['model'], background1)
e_list1.append(e)
e_list2 = []
for i in range(len(dicts_models)):
e = shap.DeepExplainer(dicts_models[0]['model'], background2)
e_list2.append(e)
'''generating saliency maps:'''
shap_values1 = e_list1[model_no].shap_values(img_preprocess, ranked_outputs=ranked_outputs)
shap_values2 = e_list2[model_no].shap_values(img_preprocess, ranked_outputs=ranked_outputs)
shap_values = copy.deepcopy(shap_values1)
for i in range(ranked_outputs):
    shap_values[0][i] = (shap_values1[0][i] + shap_values2[0][i])/2

I hope you can implement mini-batch, so I do not need...

Thanks for sharing! Can't promise when that will happen, but am adding help wanted in case someone else has the bandwidth to do it.


Support for circuitikz

Add support for http://www.texample.net/tikz/examples/circuitikz/
This requires to load the package circuitikz via \usepackage[symbols]{circuitikz} and support for an additional environment,
\begin{circuitikz}
    ...
\end{circuitikz}

Loading the package is straight forward via the -p argument. Adding an additional environment, however, is actual work for which I do not have time. You are welcome to submit a pull request, though.

This was fixed by PR #20

How are you supposed to use circuitikz?


Support logs in namespace k8s.io

What is the problem you're trying to solve
Currently nerdctl logs do not support containers in namespace moby and k8s.io
We can supportnerdctl logs in namespace k8s.io( or container created via CRIPlugin)
Describe the solution you'd like
Refer to this commit https://github.com/zhaojizhuang/nerdctl/commit/c8c2a66e74725e01029c9b30fe64ec950f2a1637

get LogPath from containerMetadataExtension(which only use in container created by CRI)
add text logdriver
tail LogPath,and redirect stdout、stderr in logfile to os.stdout os.stderr

Additional context
No response

Thanks, left comments in https://github.com/zhaojizhuang/nerdctl/commit/c8c2a66e74725e01029c9b30fe64ec950f2a1637

@AkihiroSuda OK，Thanks, I will create a PR for it


iOS Catalyst: full width images are offset to the right

Looks like the images have the correct width but they have an unintended left margin.
A couple examples are in #1421.

This seems to be fixed based on recent changes; if you can still repro, please re-open with more info.

This is trivially reproducible for me on every single full-bleed image on my 10.5ʺ iPad Pro. I haven't ever been able to get it to not happen. Please let me know what else you need!

Trying on various device sizes in the Simulator, the images seem to be mostly either correctly full-width, or hard against the left margin.
I think this might be a CSS thing, not something the app does. I've experimented a bit, but can't figure out how to improve it yet.

Should have mentioned (on a real device) that it only occurs in landscape orientation with the sidebar visible. If I rotate to portrait, the image is correctly full-width. If I hide the sidebar, the image ends up against the left margin.

Wondering if this bug and #1419 could be related. When I went back into the app this time after the above experimentation, I was able to see the entire width in landscape mode with the sidebar visible, but the entire web view appeared zoomed out.

When I went to the next story, it was offset as in #1419 (but still zoomed out):

I connected to my iPad with the Xcode view debugger (all the view bounding boxes look fine) and Safari web debugger and think I agree with you that this is CSS related. The erroneous (?) definition seems to be "margin-left: -30px !important"; when I uncheck this, everything magically works, as it no longer shadows the iPad size-specific "margin-left: -90px !important" below it.

![IMG_0323](https://user-images.githubusercontent.com/68303/112758160-d67ae780-8fba-11eb-9e24-2d3aec3815db.png)

This should be better now, based on recent changes. Reopen with more info if not.


[BUG]Reaper can't find the plugin

Thanks for taking the time to write a bug report! Use the following prompts to help you describe what's going on.  The more info you provide, the easier it'll be to understand how to fix it for you without having to come back and ask you questions.
Describe the bug
A clear and concise description of what the bug is.
The plug in doesn't show up when I search for it in Reaper, I also downloaded NeuralAmpModeler into the VST Plugin Folder
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Windows 10
Latest Plugin Version
Both standalone and VST
Reaper
Focusrite Scarlett Solo 3rd Gen
44.1 kHz
256 samples

Additional context
Add any other context about the problem here.

I also downloaded NeuralAmpModeler into the VST Plugin Folder

The download, NeuralAmpModeler-v0.7.9-win.zip is an installer. You should be downloading it to wherever, then running the installer, which should install the plug-in to the correct location.
Does that solve the problem?

Latest Plugin Version

Which version is that?

Closing since I haven't heard back in a while; assuming it's fixed.


added the max rectangle code with changes

Have you read the Contributing Guidelines on Pull Requests?
yes
Description
added the code for max_sum rectangle with recent changes requested
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#937

Changed the PR please check it and let me know for changes
@iamrajiv


Few Questions regarding training on custom data

Hi, I am trying to train OneFormer on the custom dataset and I was able to start the training. But, I have a few questions regarding choosing the right settings. Currently I resued ADE20k config file after editing the number of classes, iterations, and batch size.

What does DETECTIONS_PER_IMAGE do and how to choose the right value?
How to choose the right crop size? and will it impact the training or prediction time?
I have 20k labeled images and I am training on 4  NVIDIA A100 40GB GPUs with batch size 4, what is the minimum number of iterations required to get good results?

@praeclarumjj3 could you please help

Hi @rono221, thanks for your interest in our work. To answer your questions:

DETECTIONS_PER_IMAGE is the top k queries considered from the total number of queries during the inference stage for the final instance segmentation predictions. Usually, it's fine to set it equal to NUM_QUERIES.
https://github.com/SHI-Labs/OneFormer/blob/761189909f392a110a4ead574d85ed3a17fbc8a7/oneformer/oneformer_model.py#L214
https://github.com/SHI-Labs/OneFormer/blob/761189909f392a110a4ead574d85ed3a17fbc8a7/oneformer/oneformer_model.py#L445

The right crop size depends on your use case. If, during the inference, you want to input high-resolution or low-resolution images, it's beneficial to train with a comparable resolution. The crop size is only used during training, so training with a larger resolution will take more time.

It depends on the number of classes in your dataset as well, but since the size is similar to ADE20K, I would recommend training for 160k iterations to establish a baseline.

Closing this, feel free to re-open.


us225 acceptance test, also commented out scenario in lr_casework_sea…

us225 acceptance tests
commented out scenario Verify deed status is PARTIALLY-SIGNED from “lr_casework_search_for_deed.feature"
as requested by Aaron

:+1:  LGTM
Thanks for sorting the casework stuff too :)


New version: ObjectDetector v0.2.8

Registering package: ObjectDetector
Repository: https://github.com/r3tex/ObjectDetector.jl
Created by: @IanButterworth
Version: v0.2.8
Commit: 6fe1e17c95fff53ecdacb5245598fdf3d93b0dd6
Reviewed by: @IanButterworth
Reference: https://github.com/r3tex/ObjectDetector.jl/commit/6fe1e17c95fff53ecdacb5245598fdf3d93b0dd6#commitcomment-75650369
Description: Pure Julia implementations of single-pass object detection neural networks.

cc. @DhairyaLGandhi sorry for the delay!


add dma_timer related methods

Yep that looks good (especially with the compiler warning; (I think it had a point!)


k8s 1.29 in test matrix

Pull request

What this PR does / why we need it
Adds k8s 1.29 in the test matrix
Which issue(s) this PR fixes

Fixes #
Describe testing done for PR

Additional information or special notes for your reviewer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f24db59) 70.10% compared to head (bd1c1f2) 70.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   70.10%   70.10%
=======================================
  Files          17       17
  Lines         950      950
=======================================
  Hits          666      666
  Misses        263      263
  Partials       21       21

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Refresh memcache server(s) periodically

The memcache client resolves hostnames on creation, so if DNS is not available when fluxd is starting, memcache operations will fail consistently.
This was less of an issue when we (mostly) used the service discovery (SRV record) lookup, since that resets the server list once every minute or so. But when we started recommending the "fixed" server lookup (a.k.a., hostname resolution) it became more prevalent.
The simplest fix, which I've done here, is to refresh the hostname lookup in the same way as the service discovery implementation.
Fixes #1907. Addresses #1766.

/review-roulette


New version: CirculatorySystemModels v0.3.1

Registering package: CirculatorySystemModels
Repository: https://github.com/TS-CUBED/CirculatorySystemModels.jl
Created by: @TS-CUBED
Version: v0.3.1
Commit: 0deb97dddbb0583a3316491d342c05911d31b8c5
Reviewed by: @TS-CUBED
Reference: https://github.com/TS-CUBED/CirculatorySystemModels.jl/issues/14#issuecomment-1822608028
Release notes:

## Breaking changes since version 0.1.X:

1. The Double-Hill chamber `DHChamber` is now in terms of `dV/dt` rather than `dp/dt` which increases computation speed by an order of magnitude. The old form can be recovered using the `inP` argument. The parameter `Ev` has been removed. Please use the ventricular volume as an initial condition instead of the pressure. This can be calculated as $V = p/E_{min}$
2. `Compliance` and `Elastance` are now in terms of dV/dt. Use the new argument `inP=true` to recover the old form. Initial conditions need to be changed accordingly.
3. `Compliance` and `Elastance` have options for external pressure as parameter `has_ep` and as a connector pin to connect other pressures to `has_variable_ep` - the latter can take an equation like `C.ep.p ~ LV.p * K`.
4. Chamber has been deleted and replaced with `VariableCompliance` which can take a function for `E(t)` and has external pressure options like the other compliances and elastances.
5. `ShiChamber` already was formulated in terms of dV/dt. It now has the argument `inP=true` to allow the `dp/dt` form. Initial conditions need to be changed accordingly.

_*NOTE: the use of `inP` is strongly discouraged, since it needs the first derivative of the Elastance function, is less stable, and an order of magnitude slower. If you want to define initial condtions in pressure, it is advised to calculate the corresponding initial volume.*_

This seems to be a problem with NonLinearSolve if I read the stacktrace correctly?
Anything I can do?


Implement query string support in the list function

As a developer
I need the List function to process query strings,
So that the API can return filtered results based on the query
Details and Assumptions

The List function currently does not interpret or use query strings
Proper utilization of query strings can significantly enhance the API's flexibility

Acceptance Criteria
Given a query string is provided in the List method call,
When the List function processes this call,
Then it should parse the query string and apply the filtering before returning the results.

Examples:
https://github.com/nyu-devops/lab-flask-bdd/blob/master/service/routes.py#L49-L83
https://github.com/nyu-devops/lab-flask-bdd/blob/master/service/models.py#L177-L245
Our Code:
https://github.com/CSCI-GA-2820-SP24-001/orders/blob/master/service/routes.py#L186-L198
https://github.com/CSCI-GA-2820-SP24-001/orders/blob/master/service/models.py#L134-L138


Includes for pgmspace modified so also work on ESP8266

A few lines that allow the code to compile both for classic AVRs and ESP8266 platforms.
If accepted, please remember to bump version to eg. 1.0.2 in library.properties before creating the new release. Otherwise the Arduino package manager system will not pick up the new release.

Thanks for the version bump reminder!


Data export

[x] JSON (export/import)
[ ] CSV (export only)
[ ] PDF (export only)

CSV and PDF seem invalid and/or not possible to implement now. Closing as JSON works as expected.


Implement binomial

The implementation avoids overflows and fractions.

For consistency, it might make sense to call this binom; a lot of maths libraries do this. Rust also shortens names of maths functions like hypot as well.

For consistency, it might make sense to call this binom; a lot of maths libraries do this. Rust also shortens names of maths functions like hypot as well.

I don't really care about the name. That being said, we might later want to add a more general function that calculates the multinomial coefficients, and I think multinom would be an awkward name.

Also, would it make sense to have a factorial function too?

Not sure how useful it would be. It does not make much sense for non-bigints, because it grows so quickly.

I think there would be room for a checked version of this too, as it's really easy for binomials to generate huge values and overflow. A checked version might even be a little faster, as its multiply_and_divide could try r * a directly first, before relying on the more expensive gcd.

This could be done in a later pull request. There might be room for an iterator over the binomial coefficients as well. I also have an implementation for the calculation of the multinomial coefficients (they reduce to a product of binomial coefficients), they are more exotic though.

I can reproduce the Travis failure on nightly, but it is in a different crate.

The (unrelated) failure should be fixed on the current nightly.

@homu r+

:pushpin: Commit 40cbe1f has been approved by cuviper

:zap: Test exempted - status


Passing Arc_KDTree to partial wrapper changes it to scipy based cKDTree

Hello,
I am constructing my tree beforehand and passing it with my data to do further processing, however, when i pass it to partial function from functools, tree type is changing to scipy based one, due to which i am getting the error - search for 2 dimensional point in 3 dimensional space.
def construct_geopoints(s):
    property_geopoints = [tuple(x) for x in s[['longitude','latitude']].to_records(index=False)]
    tree = KDTree(property_geopoints, distance_metric='Arc', radius=pysal.cg.RADIUS_EARTH_KM)
    return tree

tree = construct_geopoints(masterdata)

print tree
<pysal.cg.kdtree.Arc_KDTree object at 0x113d744b0>

def myfunc(d,e,tree,mydict,s):
      print tree

<scipy.spatial.ckdtree.cKDTree object at 0x113e8b6d0>

out = mypool.imap(partial(myfunc,d,e,tree,mydict), (group for name,group in df_gp))

Platform information:

>>> import os; print(os.name, os.sys.platform)
 ('posix', 'linux2')
- Python version:
```python
>>> import sys; print(sys.version)
2.7.13 |Anaconda custom (64-bit)| (default, Dec 20 2016, 23:09:15)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-1)]
- SciPy version:
python
>>> import scipy; print(scipy.__version__)
0.19.0
- NumPy version:
```python
>>> import numpy; print(numpy.__version__)
1.12.1

I can't replicate this straightforward when I do what you've shown:
import pysal as ps
import numpy as np
np.random.seed(312211)
lngs = np.random.uniform(-180,180,(100,1))
lats = np.random.uniform(-90,90,(100,1))
coords = np.hstack((lngs,lats))

tree = ps.cg.KDTree(coords, distance_metric='Arc', radius=ps.cg.RADIUS_EARTH_KM)

def test_partial(a,b,tree,d,final):
    print(tree)
    return type(tree)

from functools import partial

partial(test_partial, 1, 2, tree,d)(3)
<pysal.cg.kdtree.Arc_KDTree object at 0x7f08e30efbb0>
pysal.cg.kdtree.Arc_KDTree

The type instability isn't with the partial application, so far as I can tell. I can replicate once I recalled that multiprocess uses pickle under the hood to pass stuff around:
import pickle as pkl
pkl.loads(pkl.dumps(tree))
<scipy.spatial.ckdtree.cKDTree at 0x7f08e3040d50>

So, this likely boils down to the fact that our Arc_KDTree does not define its own __reduce__ method.

We'll have to look into how to build that reduce method correctly. I'm not sure off the top of my head, & I've never written code that works with this end of the pickling systme.

I am getting the same issue. Specifically,
from __future__ import print_function
import pickle
import pysal as ps
import numpy as np
from scipy.spatial import cKDTree

np.random.seed(42)
lngs = np.random.uniform(-180, 180, (100, 1))
lats = np.random.uniform(-90, 90, (100, 1))
coords = np.hstack((lngs, lats))

tree = ps.cg.KDTree(coords, distance_metric='Arc', radius=ps.cg.RADIUS_EARTH_KM)
# This works if we use the default scipy cKDTree.
#tree = cKDTree(coords)

print(tree.query((90, 0), k=2))

pickle.dump(tree,open('tree.p','wb'))
tree = pickle.load(open('tree.p', 'rb'))
print(tree.query((90, 0), k=2))

Gives the error:
Traceback (most recent call last):
  File "test.py", line 19, in <module>
    print(tree.query((90, 0), k=2))
  File "scipy/spatial/ckdtree.pyx", line 731, in scipy.spatial.ckdtree.cKDTree.query (scipy/spatial/ckdtree.cxx:7657)
ValueError: x must consist of vectors of length 3 but has shape (2,)

This is happening  because the nested class is not being pickled properly (see here), so query is not performing the self._toXYZ(x) call found in Arc_KDTree.
You can work around it by applying the necessary transformations (convert (lng,lat) to XYZ, and convert linear distance to arc distance) after loading the pickled object:
import pysal.cg.sphere as sphere

tree = pickle.load(open('tree.p', 'rb'))
d, i = tree.query(sphere.toXYZ((90, 0)), k=2)
print((np.array([sphere.linear2arcdist(dx, sphere.RADIUS_EARTH_KM) for dx in d]), i))


Teste

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


Updated AppShell

Removed AppShell.xcworkspace and embed XWalkView into the
AppShell.xcodeproj directly; also added a simple index.html to
make AppShell a runnable app.

@zliang7 PTAL