Incorrect results when involving .detach() with second-order derivatives

Here's my code that uses the 'straight-through estimator' in the function q(x). In JAX, I would have implemented it using jax.stop_gradient() but I don't see that option here, so I used Tensor.detach(). If there is another option, please let me know.
import torch
import functorch as ft
import numpy as np

def q(x):
    N = 1
    fake_func = torch.tanh(x)
    return fake_func + (
        torch.clip(torch.round(x), -N, N) - fake_func
    ).detach()

def f_L(x, y, M, lamda):
    return torch.norm(M @ q(y) - M @ x, 2) + lamda * torch.norm(y, 1)

f_y = ft.grad(f_L, argnums=1)
f_yy = ft.jacrev(f_y, argnums=1)

# Test the functions
M = [[-1.7055013,  0.214439 ],
     [ 1.5994732,  1.179864 ]]
x = [ 0.279999 , -1.8200971]
y = [-0.33679163, -1.0274953 ]

M = torch.tensor(np.array(M))
lamda = 0.1

x = torch.tensor(np.array(x))
y = torch.tensor(np.array(y))

print('f_L')
print(f_L(x, y, M, lamda))

print('f_y')
print(f_y(x, y, M, lamda))

print('f_yy')
print(f_yy(x, y, M, lamda))

The above code prints
f_L
tensor(0.9713, dtype=torch.float64)
f_y
tensor([-0.4033,  0.2633], dtype=torch.float64)
f_yy
tensor([[-0.1969,  0.0000],
        [ 0.0000,  0.5616]], dtype=torch.float64)

However, the equivalent code in JAX prints
f_L
0.9713378
f_y
[-0.40328947  0.26329258]
f_yy
[[4.933743   0.7883494 ]
 [0.78834945 0.6827129 ]]

which is clearly different in the values of f_yy.
Btw, thank you for the amazing work! This library is truly awesome.

@mujjingun I can't say why it does not work with detach but torch.no_grad should work:
def q(x):
    N = 1
    fake_func = torch.tanh(x)
    with torch.no_grad():
        resid = torch.clip(torch.round(x), -N, N) - fake_func
    output = fake_func + resid
    return output

Executing the complete code I get:
f_yy
tensor([[4.9337, 0.7883],
        [0.7883, 0.6827]], dtype=torch.float64)

Thank you!

Thanks for the bug report, @mujjingun. This is definitely a bug and as @vfdev-5 suggested, torch.no_grad is a workaround for now. We'll look into fixing this

This should be fixed by https://github.com/pytorch/pytorch/pull/71707 ! Please do let us know if it isn't.


Fix the closing button in the modal, and styling of button text

Modal title header should have circular Icon.
Button Text Font does not match the figma
Relevant logs and/or screenshots
Implemented version:

Figma:

Related to #32

@rayyan224 @MateusbrMedeiros Modal has now circular close icon.
https://github.com/web3ui/web3uikit/pull/311

@MateusbrMedeiros please approve @dani69654 's fix

@locothedev @dani69654 @rayyan224 Fixed buddies!

Buddies, I've checked one thing in Figma, and the button is silver on there and was implemented in blue.
@dani69654 @locothedev can you check this please?


Random is null in the context when created by Global.generatorContext()

Describe the bug
The Random field is null when it is created by Global.generatorContext()
Expected result
When no Seed is configured in the settings a random seed should be used to provide a DefaultRandom.
See Global#CONFIGURED_RANDOM
null is used instead of using the NoArg constructor:
public DefaultRandom() {
        this(Seeds.randomSeed());
    }

Actual result
Nullpointer Exception:
Caused by: java.lang.NullPointerException: Cannot invoke "org.instancio.Random.intRange(int, int)" because the return value of "org.instancio.generator.GeneratorContext.random()" is null
	at org.instancio.internal.generator.util.CollectionGenerator.hints(CollectionGenerator.java:139)
	at org.instancio.internal.handlers.UsingGeneratorResolverHandler.getResult(UsingGeneratorResolverHandler.java:65)
	at org.instancio.internal.GeneratorFacade.getGeneratorResult(GeneratorFacade.java:131)
	at org.instancio.internal.GeneratorFacade.generateNodeValue(GeneratorFacade.java:90)

Additional information
The Generator is created by the ServiceLoader (see https://github.com/CommentSectionScientist/InstancioGeneratorContextRandom/blob/master/src/test/java/de/ossi/generator/MyClassGenerator.java#L17)
Link to a minimal sample project reproducing the issue or runnable sample code
https://github.com/CommentSectionScientist/InstancioGeneratorContextRandom/blob/master/src/test/java/de/ossi/generator/ReproducerTest.java

Java version: 17
Instancio version: 4.1.0

Thanks for raising this issue and creating a sample project. It helps a lot!
Unfortunately, this usage is not supported because CollectionGenerator and Global  are internal classes. Anything under internal package or annotated with @InternalApi is not intended to be used by users.
Based on the sample project, I assume the goal is to generate a collection of size 1 (by default) for MyClass.values. If that's the case, you could use the provided Generators instance in your SPI implementation:
public class MyClassGenerator implements InstancioServiceProvider {

    @Override
    public InstancioServiceProvider.GeneratorProvider getGeneratorProvider() {
        return (node, generators) -> {
            if (matchesNode(node)) {
                // 'generators' provides access to all built-in generators
                return generators.collection().size(1);
            }
            return null;
        };
    }

    private boolean matchesNode(Node node) {
        Field field = node.getField();
        return field != null
                && MyClass.class.isAssignableFrom(field.getDeclaringClass())
                && node.getTargetClass() == List.class;
    }
}

Does this work for you use case?

Hey,
thanks for the answer, i did not see the annotation.
Just to clarify: All custom Generators should just implement the Generator interface, correct?
(My code provided is not a real Generator since it just delegates, so it shouldnt implement the interface)

All custom Generators should just implement the Generator interface, correct?

That's right, all generators should implement the Generator interface. The Global class contains an internal instance of Random and Settings. Since you already get those objects using public APIs, the Global class shouldn't be needed for a custom generator. To delegate to the collection generator, you can use the collection() method as above.

Ok thanks.
The suggested solutions works with version 4.1.0
(i got some exception when using 3.6.0 in our main project, so I just bumped up the version)

i got some exception when using 3.6.0 in our main project, so I just bumped up the version

Thanks for the update. This makes sense now. There was a fix for this bug not too long ago:

#882

Let me know if you run into other issues.


Add JSON Type definition support

Reason/Context
It would be great to have support for JSON Type definition standard as supported inputs: https://jsontypedef.com/
To support it we need to add a new input processor, which you can read about how to add here: https://github.com/asyncapi/modelina/blob/master/docs/contributing.md#adding-a-new-input-processor
The TLDR; is that we want to convert their structure into our Meta Models. Unless there are tooling available to handle references, the initial implementation might not support this. Feel free to document the limitations of the implementation as needed in an input document: https://github.com/asyncapi/modelina/tree/master/docs/inputs
Happy to help further if you get stuck on something :v:

@jonaslagoni I would love to work on this.

Hi @jonaslagoni I was going through the modelina .readme and I think in this code:

for (const model in models) should be this for (const generatedModel in models)
else  the whole code should be this:
for (const model in models) {
  const generatedCode = model.result;
  const dependencies = model.dependencies;
  const modeltype = model.type;
  const modelName = model.modelName;
  ...
}```

You are right @sagarkori143 👍

@jonaslagoni Is this still relevant? The website for jsontypedef is currently offline 😅

https://github.com/jsontypedef still gets updates, so I am sure it is just a fluke 😄
So yea I would say it is 👍


⚠ Bofrost.at has degraded performance

In 08953fb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1545 ms

Resolved: Bofrost.at performance has improved in 8d88cd9 after 6 minutes.


Add native styling documentation for Pie/Doughnut chart

document styling for pie/doughnut chart
fix bar chart xml tags

Herewith the native styling documentation for the soon-to-be released Pie/Doughnut chart widget.
Please do not merge this until the widget is released to the marketplace. I will respond here when this is done. I would add a label unfortunately I don't have the permissions to do this.


Inquiry about lit-llama's training speed

It would be helpful to know how fast lit-llama can be trained as it is crucial for pre-training costs. Some comparable data can be found in the link provided: https://github.com/s-JoL/Open-Llama#和其他开源模型性能对比.

We are starting looking into pre-training now, so giving you a number might be premature, but definitely thanks for sharing this. We'll be posting numbers as soon as we are ready.

First timings from #217, with that we are around 2k tokens/sec/GPU

no xformers
no torch.compile (unfortunately activation checkpointing is not supported by torch.compile yet, and without it we OOM with 40GB)

It would be interesting to understand what cloud help closing the gaps. What machine did you use to run your benchmarks?

Thank you for providing the information. During training on the internal server (A100 80Gx8), approximately ~2.9k tokens/sec/GPU were achieved using large gradient accumulation and Magatron-Deepspeed.
The link above is a project I found, but it's unclear where it was trained on cloud.

Yeah I think the extra memory (40GB vs 80GB) allows for a larger micro batch size and can really give you an edge there.
We'll test it in the future, in the meantime I'm running further tests and will report back.

As an update, I'm getting 2.2k by using a larger effective batch size during gradient accumulation (since it amortizes the optimizer step).
Feel that moving to a larger micro batch on a 80GB node and using torch.compile (or something similar) to fuse ops will fill the gap substantially.


[Storage] possible bug in streamToBuffer2() when pos === bufferSize at the end

From @mikeharder (slightly updated for code formatting)
This now downloads the whole response but fails with:
  1) Highlevel 1
       uploadStream should success:
     Error: Stream exceeds buffer size. Buffer size: 269484032

However, this exactly matches the content-length of the GET response, so I don't know why the buffer is not large enough:
    "content-length": "269484032",

[Yesterday 6:54 PM] Mike Harder
well, it looks like the streamToBuffer2() function (which I did not modify) has a bug
[Yesterday 6:55 PM] Mike Harder
It doesn't handle the case where pos is equal to bufferSize but stream.read() returns undefined
[Yesterday 6:56 PM] Mike Harder
https://github.com/Azure/azure-sdk-for-js/blob/9da9f89ae29e2c233b8fc6530c2667eb95c40d52/sdk/storage/storage-blob/src/utils/utils.node.ts#L86
[Yesterday 6:56 PM] Mike Harder
    return new Promise<number>((resolve, reject) => {
    stream.on("readable", () => {
      if (pos >= bufferSize) {
        reject(new Error(`Stream exceeds buffer size. Buffer size: ${bufferSize}`));
        return;
      }

      let chunk = stream.read();
      if (!chunk) {
        return;
      }

[Yesterday 6:56 PM] Mike Harder
The check for pos >= bufferSize should be after if (!chunk) { return; }

@jeremymeng
I tried to repro it but failed. Could you provide more details?
Are you talking about this test case?
https://github.com/Azure/azure-sdk-for-js/blob/c75db3ce8f9afb207b22442910c062141a773dfd/sdk/storage/storage-blob/test/node/highlevel.node.spec.ts#L194

I will create a PR with a unit test showing the issue and what I believe is the fix.

Here's a new test I added which should pass, but fails due to the bug in streamToBuffer2().  I'm still thinking of the best way to fix this.
https://github.com/Azure/azure-sdk-for-js/pull/7236/files#diff-519893dc04f5187705f69451f9b53880R234-R259

PR is ready for review: https://github.com/Azure/azure-sdk-for-js/pull/7236


Competitions require a minimum of 3 participants to “pay out”, otherwise they just expire without any refund.

https://github.com/ReyMArias/IT202009/pull/45


Service catalog adds extra backslashes to error message.

When the creation of a serviceinstance errors out, the error object contains extra backslashes to the json object.
{
   "type":"Failed",
   "status":"True",
   "lastTransitionTime":"2017-10-19T13:24:55Z",
   "reason":"ProvisionCallFailed",
   "message":"Provision call failed: ServiceInstance \"myproject/rails-pgsql-persistent-c8zpj\": Error provisioning: \"secrets \\\"rails-pgsql-persistent\\\" already exists\\nservices \\\"rails-pgsql-persistent\\\" already exists\\nroutes \\\"rails-pgsql-persistent\\\" already exists\\nimagestreams \\\"rails-pgsql-persistent\\\" already exists\\nbuildconfigs \\\"rails-pgsql-persistent\\\" already exists\\ndeploymentconfigs \\\"rails-pgsql-persistent\\\" already exists\\npersistentvolumeclaims \\\"postgresql\\\" already exists\\nservices \\\"postgresql\\\" already exists\\ndeploymentconfigs \\\"postgresql\\\" already exists\""
}

Trying to access the message will result into string with unescaped backslash and double quotes.
Provision call failed: ServiceInstance "myproject/rails-pgsql-persistent-krncf": Error provisioning: "secrets \"rails-pgsql-persistent\" already exists\nservices \"rails-pgsql-persistent\" already exists\nroutes \"rails-pgsql-persistent\" already exists\nimagestreams \"rails-pgsql-persistent\" already exists\nbuildconfigs \"rails-pgsql-persistent\" already exists\ndeploymentconfigs \"rails-pgsql-persistent\" already exists\npersistentvolumeclaims \"postgresql\" already exists\nservices \"postgresql\" already exists\ndeploymentconfigs \"postgresql\" already exists"

Ideal state would be not to have those extra backslashes there, so when accessing the message the string would be in properly escaped.

Yeah, that's annoying.  We should fix this

That is proper JSON escaping. The result from a json message string should be evaluated through a string processor.

It has been. The message is escaped twice

Looks like this might be fixed since the issue was opened, however.

Confirming that the issue is solved in the latest service-catalog version... Closing


fix: skip ansible-lint rule 208 when recurse: yes

Remove mode: 0750 for file tasks where recurse: yes.
All the files in the directory will inherit this mode, which is wrong.
This mode was added in commit d70ad62 to resolve an error reported by
ansible-lint. Use #noqa 208 instead to skip the qa for this task, we can
rely on default mode set during the installation of the RPM.

@giacomo-mcevoy if you want to review 😉

@btravouillon thanks for the ping.
We tested this change in a virtual environment and now these two roles are idempotent.
One detail though, now a non-root user can do "ls /var/log/conman" and "ls /var/log/rsyslog" and see the directory contents (but cannot read the files). Not sure if this is acceptable or not.

One detail though, now a non-root user can do "ls /var/log/conman" and "ls /var/log/rsyslog" and see the directory contents (but cannot read the files). Not sure if this is acceptable or not.

I guess it is. These are the default permissions from the OS.


Plugin was infected by a virus

Hello,
I found the plugin was infected with a virus, scanned by Bitdefender. Not sure if it was a false alarm.

As Bitdefender suggested, I have to rescan and restart the computer:

Thanks for considering the issue

Please share problematic server.py python file.

It looks like there could also be more information under the "Suspicious web page detected" block that would be useful!

(The originating file is https://github.com/astral-sh/ruff-lsp/blob/main/ruff_lsp/server.py, FWIW.)


[ISSUE #2532]: add  in shenyu-examples' module pom.xml

// Describe your PR here; eg. Fixes #issueNo

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #2533 (24e1f17) into master (3359b3c) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2533      +/-   ##
============================================
- Coverage     60.23%   60.00%   -0.23%
+ Complexity     4190     4157      -33
============================================
  Files           651      651
  Lines         18334    18347      +13
  Branches       1658     1659       +1
============================================
- Hits          11043    11009      -34
- Misses         6451     6502      +51
+ Partials        840      836       -4

Impacted Files
Coverage Δ

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
51.57% <0.00%> (-12.64%)
:arrow_down:

...ache/shenyu/admin/utils/PluginHandleH2Trigger.java
63.63% <0.00%> (-9.10%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...che/shenyu/admin/model/vo/DashboardUserEditVO.java
62.50% <0.00%> (-4.17%)
:arrow_down:

...ache/shenyu/admin/model/dto/DataPermissionDTO.java
59.25% <0.00%> (-3.71%)
:arrow_down:

...yu/plugin/grpc/resolver/ShenyuServiceInstance.java
96.29% <0.00%> (-3.71%)
:arrow_down:

...rg/apache/shenyu/admin/model/page/CommonPager.java
44.82% <0.00%> (-3.45%)
:arrow_down:

...he/shenyu/admin/model/vo/DataPermissionPageVO.java
50.00% <0.00%> (-3.34%)
:arrow_down:

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3359b3c...24e1f17. Read the comment docs.


fix: inserting a table from external resources lead Lexical crash

Fix https://github.com/facebook/lexical/issues/5812
Before:
see https://github.com/facebook/lexical/issues/5812

After:

reason for crash: When press Enter the program gets stuck in a dead loop while checking for INTERNAL_$isBlock(node).
I haven't thought of a suitable way to fix the problem in lexical or lexical/table, but I think I can avoid the Lexical crash by wrapping Paragraph around elements other than paragraphs, lists, code blocks, Quote in the playground.
Please let me know if there have a better solution.

i wonder what html is being copied onto the clipboard. i would be curious to know what (or if theres any) dom element wrapping the text node that results in it being a top level element to table cell

i wonder what html is being copied onto the clipboard. i would be curious to know what (or if theres any) dom element wrapping the text node that results in it being a top level element to table cell.
do u mind sharing what html is being copied to clipboard? u may inspect that by downloading pasteboard: https://github.com/sindresorhus/Pasteboard-Viewer
(i learnt this from @zurfyx , thanks for sharing this useful tool!)
lastly good job debugging and finding the root cause!

However, instead of adding a custom table cell, which will be hard to replicate by others, I would explore why this happens and whether insertNodes can do this for us as it doesn't happen for the RootNode.

Thanks for the review and for suggesting a better solution. I'll give it a try.

do u mind sharing what html is being copied to clipboard

@potatowagon of course here the html

  <colgroup>
    <col>
    <col>
    <col>
    <col>
  </colgroup>

        text

        something wrong when print enter.

        text

        5.5,5.6

do u mind sharing what html is being copied to clipboard

@potatowagon of course here the html

  <colgroup>
    <col>
    <col>
    <col>
    <col>
  </colgroup>

        text

        something wrong when print enter.

        text

        5.5,5.6

https://github.com/facebook/lexical/pull/5857 may fix this as tgat PR would wrap inline text nodes in a paragraph if theres nothing between the inline node and the root (or shadow root in this case for td
will be testing your case on that pr

do u mind sharing what html is being copied to clipboard

@potatowagon of course here the html

  <colgroup>
    <col>
    <col>
    <col>
    <col>
  </colgroup>

        text

        something wrong when print enter.

        text

        5.5,5.6

just realised this is the copied html of the table in lexical editor, could u share instead the copied html after copy from the external app?

just realised this is the copied html of the table in lexical editor, could u share instead the copied html after copy from the external app?

You're right, what I got before was the html after saving on lexical, I think the following is the original pasted html.

        text

        something wrong when print enter.

        text

        5.5,5.6

I wonder if the crash is fixed by https://github.com/facebook/lexical/pull/6139 since the example here all have TBODY tag, which we didn't respect in the TableObserver. Thoughts @potatowagon @zurfyx ?

I wonder if the crash is fixed by #6139 since the example here all have TBODY tag, which we didn't respect in the TableObserver. Thoughts @potatowagon @zurfyx ?

afaik this issue is solved already
what could have fixed the crash was text nodes inside of a  now being wraped in a  on pasting, which wont lead to crash

closing since this issue is solved


Suggestions api not working

https://saavn.dev/api/songs/yDeAS8Eh/suggestions in this route not show suggestion show this massage ={"success":false,"message":"Cannot read properties of undefined (reading 'id')"} fix this issue

same issue

yupe same issue


create istio-ca-root-cert cm for each remote ns

https://github.com/istio/istio/issues/23138

--set values.global.centralIstiod=true
central istiod will create istio-ca-root-cert cm for each remote ns

default install
central istiod will not create istio-ca-root-cert cm remote ns

manually tested above two scenarios and passed

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

update-ref-docs-dry-run_istio
6261fec896a1347e064748e42906f8d8aa60480e
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

update-ref-docs-dry-run_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

update-ref-docs-dry-run_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

update-ref-docs-dry-run_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test unit-tests_istio

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test unit-tests_istio

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
778f2c8a9c3d764301becb4cb5adfbaa25e17841
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
778f2c8a9c3d764301becb4cb5adfbaa25e17841
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
778f2c8a9c3d764301becb4cb5adfbaa25e17841
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

unit-tests_istio
778f2c8a9c3d764301becb4cb5adfbaa25e17841
link
/test unit-tests_istio

update-ref-docs-dry-run_istio
61f6b1d4ff6df85b7bbea1b7665ee92ef645f7e9
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

update-ref-docs-dry-run_istio
61f6b1d4ff6df85b7bbea1b7665ee92ef645f7e9
link
/test update-ref-docs-dry-run_istio

unit-tests_istio
61f6b1d4ff6df85b7bbea1b7665ee92ef645f7e9
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
3acfb72ef466026f4f00191215bc6334aeea7cab
link
/test integ-security-k8s-tests_istio

unit-tests_istio
61f6b1d4ff6df85b7bbea1b7665ee92ef645f7e9
link
/test unit-tests_istio

update-ref-docs-dry-run_istio
f35124803fe6f39eb6bb70fa0519ccfeb10e3d6b
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj To the PR description or the PR code, can you add a description of the workflow involved with this PR? E.g., where is the root CA certificate obtained? what is a remote ns? how to configure a ns as a remote ns?

I agree with John on the importance of the tests. Both unit tests and integration tests should be added to cover the feature related to this PR. The unit tests can be added to this PR and if the implementation of the feature is incomplete yet, the PR should add a to-do comment for the integration tests so that the integration tests will be addressed by follow-up PRs.

Re. testing: single cluster behavior is covered already by e2e tests.
MC behavior is also covered, at least in the common case.
I think we should have a e2e test for the entire 'central Istio' use case - but for 1.6 since it's new
we can probably test manually.
What is missing and must be fixed: an env or mesh config or annotation on the MC secret to turn on or off this feature. I'm pretty sure it'll have really bad effects in some configurations where you have multiple istiod clusters, and each will attempt to create the config maps - possibly with different roots.
And that's hard to capture in tests.
So please make it 'opt in' and off by default, with the option to enable including enough info for users to know to not turn it on unless they are in this scenario.

So please make it 'opt in' and off by default

+1, that is my main concern that it may impact multiple istiod clusters.
perfectly fine with approving if its disabled
On Thu, Apr 23, 2020 at 8:50 AM Costin Manolache<EMAIL_ADDRESS>wrote:

Re. testing: single cluster behavior is covered already by e2e tests.
MC behavior is also covered, at least in the common case.
I think we should have a e2e test for the entire 'central Istio' use case

but for 1.6 since it's new
we can probably test manually.

What is missing and must be fixed: an env or mesh config or annotation on
the MC secret to turn on or off this feature. I'm pretty sure it'll have
really bad effects in some configurations where you have multiple istiod
clusters, and each will attempt to create the config maps - possibly with
different roots.
And that's hard to capture in tests.
So please make it 'opt in' and off by default, with the option to enable
including enough info for users to know to not turn it on unless they are
in this scenario.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/23173#issuecomment-618478507, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXLP2EZNZQPE5CAZTMTROBPVPANCNFSM4MO4M2GQ
.

On John's comment: I hope nobody is expecting this to be a 'supported feature' in 1.6, it just landed.
It is alpha or experimental - and once enough testing and feedback is available we can move to beta, etc.

Thank you for the valuable comment @howardjohn @costinm @lei-tang !  I agree with opt-in for this.

@linsun @howardjohn @costinm @lei-tang @GregHanson Thanks for the review, PTAL.

@irisdingbj thank you for adding the opt in flag by user's choice.  @howardjohn @costinm I think this is safe to merge, can you check?
The additional feedback that should be addressed in a separate PR:

caRoot comment from @lei-tang
possible unit test if we can
add an additional writer service account only for ConfigMap, and only for the ConfigMap called istio-ca-root-cert
investigate and test impact with multi-revision support. We are currently under the assumption that multi-revision would share the same root cert so the impact may be minimal or none.

Let me know anything else I missed.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

update-ref-docs-dry-run_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test update-ref-docs-dry-run_istio

gencheck_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test gencheck_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

lint_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test lint_istio

release-test_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test release-test_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-galley-k8s-tests_istio

gencheck_istio
b8044059e7a3f0b3f0730943adcb7d662cfe67e4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-galley-k8s-tests_istio

gencheck_istio
b8044059e7a3f0b3f0730943adcb7d662cfe67e4
link
/test gencheck_istio

lint_istio
c574078e6c330b7ac0a2246b5a4e18c6b698adc5
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-conformance-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-conformance-k8s-tests_istio

integ-distroless-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-telemetry-k8s-tests_istio

integ-local-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-local-tests_istio

integ-multicluster-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-multicluster-k8s-tests_istio

integ-security-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-pilot-k8s-tests_istio

integ-galley-k8s-tests_istio
cf220530273af4a42756c7951f7418ca50027202
link
/test integ-galley-k8s-tests_istio

lint_istio
c574078e6c330b7ac0a2246b5a4e18c6b698adc5
link
/test lint_istio

gencheck_istio
9479a812211e4bb91ce9616fed24c7c53ebc77a6
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@irisdingbj thank you for adding the opt in flag by user's choice. @howardjohn @costinm I think this is safe to merge, can you check?
The additional feedback that should be addressed in a separate PR:

caRoot comment from @lei-tang
possible unit test if we can
add an additional writer service account only for ConfigMap, and only for the ConfigMap called istio-ca-root-cert
investigate and test impact with multi-revision support. We are currently under the assumption that multi-revision would share the same root cert so the impact may be minimal or none.

Let me know anything else I missed.

Thanks Lin for this summary, opened an issue https://github.com/istio/istio/issues/23263 to track

@irisdingbj I believe this breaks my cluster-local change from https://github.com/istio/istio/pull/23150/files#diff-8cc1e432737fa0d93dc76b5bc10cac83R159
You removed the setting of the DomainSuffix on the environment. Was this intentional?

@nmittler Thanks for taking care of this.  My fault for bad merge :(

@irisdingbj I think this change is reverted from master but still exist in 1.6.  Could you double check?  We still want the function in master as well.

@linsun change is not reverted in master. But need new change since https://github.com/istio/istio/pull/23684 changed the ca certs behaviour.


Compatibility with pydantic v2.10+

Details in https://github.com/langchain-ai/langchain-google/issues/610#issuecomment-2493831993

I've opened https://github.com/googleapis/python-aiplatform/pull/4701.


Workbox Webpack Plugin v3

tl;dr
This is a prototype for the workbox-webpack-plugin for the v3 release. This address some of the points mentioned in #696 . Not all of the configuration from the existing workbox-webpack-plugin has been migrated (or configuration from sw-precache-webpack-plugin) but that was not the focus of this prototype. The goal of this prototype is to solve for some of the difficult webpack-specific features, including:

Supporting webpack-dev-middleware by generating the service-worker, file-manifest, and built version of workbox-sw in-memory (rather than writing to disk). I've tested this and confirmed support for webpack-dev-middleware / webpack-dev-server.
Filtering files by chunk names.
Copyingworkbox-sw to the webpack assets.

⚠ I haven't updated the tests yet, I was manually testing by using an ejected create-react-app instance that imports the plugin using a relative file path.
⚠  One issue (mentioned in the blocks section below, was that I wasn't able to import the workbox-sw package into the workbox-webpack-plugin package. See details in the blocks section for my work-around.
V3 Changes to workbox-webpack-plugin
Following are details of the design, proposed api changes, and issues I am having that I am hoping someone will provide help with.
Requirements
from the #725 v3 tracker

[ ] Switch to CDN by default
[ ] Include option to not use CDN and copy files over
[ ] Update API to implement v3 proposal
[x] Use compilation assets to generate a manifest (instead of globPatterns)
[x] Allow user to specify chunks to be used when creating the manifest
[x] Generate service worker “in-memory” and make webpack responsible for writing to file system
[ ] Support sw-precache config in workbox-webpack plugin (runtime-caching? drop staticFileIgnores in favor of “chunks” api)

Im not clear what the CDN related tasks are.
Re-architecture
The objective is to provide a seamless experience for developers who want to use workbox in projects that rely on webpack for building.
Webpack contains information about the build files and versions of those files that workbox can leverage to manage service worker caching.
Tenets

Try to use as many existing workbox utilities to generate the service worker through webpack without compromising the developer experience.
Ensure all required service worker assets are emitted through webpack so workbox can be used with webpack-dev-middleware.

Design

In most webpack build systems, webpack is aware of all the built static assets as well as if there are changes in those assets. Were going to use webpack to generate a file manifest that workbox-sw can use for precaching instead of using workbox-build/generate-file-manifest.
Filter manifest files to include / exclude files by chunk name. This is provided by the config.chunks and config.excludeChunks, respectively (mirroring the html-webpack-plugin api).
If we need to use the compiler.inputFileSystem._readFile method instead of fs.readFile, use the workbox-webpack-plugin/utils/read-file.js method that is configured to use compiler.inputFileSystem._readFile during the run phase of the webpack compilation lifecycle.
workbox-build will copy a built workbox-sw into the service worker output path. This needs to done through the webpack. During the make phase of the webpack compilation, we use workbox-webpack-plugin/utils/copy-workbox-sw to add a built version of workbox-sw to the webpack compilation assets array. We can't use the workbox-build/utils/copy-workbox-sw utility because it writes to the filesystem.
The version of workbox-sw is included in it's filename so we need that information to import it in the generated service worker. workbox-webpack-plugin/utils/copy-workbox-sw also returns the workbox-sw filename so we can pass it to workbox-webpack-plugin/generate-webpack-sw.
During the emit phase of the webpack lifecycle, we:

Get the manifest entries
Use the entries to generate a file-manifest
Generate a service worker with the file-manifest name and workbox-sw filename or copy a service worker from the config.swSrc then prepend it with the required importScripts(workbox-sw.js, file-manifest.js).
Add both the file-manifest and the service-worker to the webpack assets.

Todo

I'm not passing any configuration into sw-build.generateSW as we would need to. This is because of the pattern where utilities write to the file system. If we don't change the utilities, one way to fix this would be to copy the template populate logic from sw-build/generate-sw. Ideally we could abstract the populating logic from generate-sw into a util that does not write to the file system.
Honor swDest incase users want to separate the service worker from build directory.
There may be cases where assets are not emitted by webpack (the public/ dir in create-react-app, for example). We should provide a way to "merge" workbox-build/get-file-manifest-entries with workbox-webpack-plugin/get-webpack-manifest-entries.  workbox-build/get-file-manifest-entries supports globPatterns for finding assets, and can be used to generate manifest entries for files that do not go through webpack. Could be a simple Object.assign(webpackEntries, workboxEntries).
Supoort sw-precache-webpack-plugin configurations.
Fix tests (once the sw-build/generate-sw) item is resolved.

API changes
These are just proposals, we can stay within the exisiting API but I wanted to collect feedback for these changes.

Running workbox-build in injectManifest mode will not copy workbox-sw over but this is a known pain point for developers. Instead, copy the workbox-sw over then prefix the existing service worker with an importScripts(workbox-sw-V.xxx.js) line.
Always generate a file manifest (do not support injectManifest mode). We can effectively "inject" the manifest by taking a config.manifestVarName parameter that will be used in the file-manifest.js template: (self.${config.manifestVarName} = ${fileManifest}) and prepend an importScripts(${manifestFileName}) line to the existing service worker.

Blocks

I wasn't able to import the workbox-sw package into the workbox-webpack-plugin package (in the workbox-webpack-plugin/utils/copy-workbox-sw utility). I kept getting a "module not found error" when I manually tested using the create-react-app approach). My work around was to add the copy-workbox-sw to the workbox-build package (that I was able to import) and manually test using that.
A lot of the utilities use fs to read lodash templates. There may be problems using fs in webpack plugins (I removed it from sw-precache-webpack-plugin and @TheLarkInn mentioned using compiler.outputFileSystem instead).
Utilities often populate then write the populated template to the filesystem. I'm having to duplicate and isolate the populate logic and am referencing the lodash templates across modules.

I signed it!

Thanks so much, @goldhand!
I'll give it a thorough review in a bit.
Some housekeeping: we'll want to target the v3 branch with this PR, as we still might cut a few releases using the v2 major version number from master before we're ready to launch any breaking changes. At the top of my TODO list is to port over the workbox-build module to the v3 branch, which should then make it easier for you to land your code in v3 as well.

At the top of my TODO list is to port over the workbox-build module to the v3 branch, which should then make it easier for you to land your code in v3 as well.

Was just talking to @gauntface about this. Exciting to see this slowly coming together, @goldhand. Thanks for getting this work started!

Cool, I'll move this to target the v3 branch. This is still very "WIP", just wanted to get something out there to see if anyone could help in areas.

Thanks for this work @goldhand.
I'm very keen to get all the changes to workbox-build known for V3 so this is very timely for @jeffposnick's work.
Blocks

workbox-sw would need to be added as a dependency to the webpack plugin to be able to copy the files over. This will likely change in V3 (but there will still be copying done).

Basically workbox-sw currently contains all the code from a number of modules. In V3 these will be seperate files and developers only need to pull in what they use.

 When generating a service worker, we'll need to grab an example template and alter it. compiler.outputFileSystem sounds weird to me in that the reading is done before anything is outputted. Would it make send to alter workbox-build to use some other file reader API or would we need to switch to a template which is a string and manipulate that rather than read a file?
What would an ideal API surface in workbox-build be to prevent you from needing to duplicate the logic? Would it make sense to add API's to workbox-build that would return a string (in the case of generating a SW) and an API that accepted and returns strings as taking in a service worker file and returning an altered service worker file.

API Changes
I think it would be good to have a brainstorm on fixing this. There are a number of issues around this space and a number of possible solutions, all with varying degrees of magic / flexibility and usefulness.
@jeffposnick Do you think you could work on a proposal for workbox-build that would address some of the concerns raised above? If not I'm more than happy to have a crack at it, but I know you are owning that module and I think having a fresh pair of eyes on it would be good. Also happy if you'd like to have a discussion of possible ideas and approaches before attempting a proposal. Basically don't want to block and don't want to waste your time.
I think a proposal might be helpful before starting work.
What is the CDN?
@goldhand In V3 we are planning on supporting a CDN. This should make it easy for developers to use Workbox on Glitch and also avoid the issue of needing to know where workbox-sw is in node_modules + it avoids having magic to inject stuff in a service worker script (as the cdn import can be copy and pasted).

@goldhand, as an FYI, #811 is now merged, so workbox-build is in the v3 branch. The codebase at the moment is functionally equivalent to what was in master, so it doesn't have the modified interfaces we've been discussing (tracked in #803), but it does bring into v3 testing setup and build steps for node projects, which were previously missing.
It should be possible to rebase against v3 at this point, in advance of waiting for the workbox-build interfaces to be updated. Or you could wait for those interface changes, and do it all in one go. Let us know if you run into any rough patches.

https://github.com/GoogleChrome/workbox/issues/803#issuecomment-333951970 has an update on the current state of workbox-build in v3, with an eye on features that should simplify this PR.

Thanks @jeffposnick I will be working on this over the weekend! generate-sw.js is exactly what I needed and sweet async/await

I'm late to the party, I'd love to review this PR and test it against our complicated webpack configuration @trivago.

Thanks @anilanar ! Would appreciate that. Should have a more complete working version after this weekend. Here is the webpack-related work that will support running with webpack-dev-server. Need to bring in more of the workbox functionality now so if you want to add to this pr or use as a starting point for another pr, please do!

@jeffposnick I made a decent amount of progress this weekend:

Migrated to v3 branch
Used workbox-build utilities where I could
Updated documentation where requested in feedback
Renamed files / functions so it was clearer what they do
Noted missing todo's in code comments with links to the review comments for details (in case someone else wants to make these fixes).
Added a method that returns all configuration params for generateSWString. I am highlighting this because the idea was we could explicitly specify whatever properties WorkboxWebpack plugin config should pass to generateSWString. This allow should allow us to easily customize the api / experience.

Going to call it a night but I'll try to update with more details / respond to any questions on this pr over this next week.

Great work! I'll retest after HtmlWebpackPlugin is handled.

Thanks for your work on this, @goldhand, and thanks for your feedback, @anilanar!
I plan on giving it a thorough review and address some of the workbox-build comments. As discussed, given the amount of work in this PR, we're open to the idea of merging into v3 as long as the core functionality is there, and track some incremental changes or outstanding feature requests in issues to be addressed in follow-up pRs.

I'm going to merge, and have filed separate issues to track some unresolved questions/feedback to be addressed in follow-up PRs:

https://github.com/GoogleChrome/workbox/issues/933
https://github.com/GoogleChrome/workbox/issues/934
https://github.com/GoogleChrome/workbox/issues/935

There will also be some general code style and workbox-build integration PRs post-merge.

When will you guys publish the V3 to npm, so I can use the latest version to solve problems in webpack-dev-middle, thx


The results of FSD on nuscenes or kitti

Hi, have you ever tried the fsd model on nuscenes or kitti.

Someone has tried FSD on KITTI: https://github.com/tusen-ai/SST/issues/77
The design of the nuScenes version is slightly different due to its evaluation metric being quite different from the WOD. We will release it in a couple of months.

Thanks for your quickly replay, Would you mind telling me what the slightly difference is? In my opinion, fsd depends on the result of segmentation. Therefore, whether it is not very friendly to the datasets consist of many categories like nuscenes.

It‘s a misunderstanding. FSD can well handle the Argoverse 2 dataset in our paper, which contains up to 30 classes.
Differences are:

nuScenes does not use IoU as a metric, so the label assignment in the GroupCorrection head should not use IoU.
In WOD, a point cloud could belong to more than 1 category (Binary sigmoid CE loss as segmentation loss). In nus or Argo, we restrict a point only belonging to a single class, so we use softmax CE loss as segmentation loss and the group_sample function to sample fg.

I got it, thanks again~


Support endpoint authentication

As it is quite common to have restricted access to SPARQL endpoints, there should be an easy way to set HTTP Basic authentication parameters in the config file that are then passed through SPARQL HTTP requests for the default SPARQL endpoint.

Good point @RinkeHoekstra -- we could consider going back to using SPARQLWrapper and use their http auth (wrapper.setCredentials(user, passwd)). As I remember (from #33) the issue with SPARQLWrapper was lack of support for content type plaintext. I'll look into it.

You can also pass auth=(user,pass) to a requests get or post.
Sent from my iPhone

On 16 Feb 2018, at 11:39, Carlos Martinez<EMAIL_ADDRESS>wrote:
Good point @RinkeHoekstra -- we could consider going back to using SPARQLWrapper and use their http auth (wrapper.setCredentials(user, passwd)). As I remember (from #33) the issue with SPARQLWrapper was lack of support for content type plaintext. I'll look into it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Not defined SQLite

const Database = require('simplest.db').SQLite;
const db = new SQLite({
path: './database.sqlite',
});
when i am running this code i am getting error that SQLite is not defined. (const db = new SQLite())
Please help me how to reslove it
Thanks

const Database= require('simplest.db').SQLite;
const db = new Database({
path: './database.sqlite',
});


Quick Question..

Hi There,
I am planning on using this. I see that this script uses segment as the format. Newer version of ffmpeg has support for HLS format. Is there a big difference between 2 formats?
https://www.ffmpeg.org/ffmpeg-formats.html#hls-1

Hi,
Not a major difference, no. When I first created the script, HLS didn't exist in ffmpeg, and when it first got added it seemed a little too unreliable.
I've not really revisited since then to see whether it's more suitable now. The script's output should be valid HLS none-the-less

Thanks @bentasker. Another related question. I saw few articles talk about GOP size and aligned frame.
http://stackoverflow.com/questions/33225026/creating-hls-variants-with-ffmpeg
Do i have worry about that if use this script? Just want to make sure that I am not missing anything. I am new to FFMPEG world.

Hi,
I've not seen any issues without it when switching between variants, though it's possible that's selection bias on the sources I've been using.
If you do find you need it, it's fairly simple to specify at run time. Assuming you want a 2 second interval and your video runs at 30fps
FFMPEG_FLAGS="-g 60"
export FFMPEG_FLAGS
./HLS-Stream-Creator.sh # etc

If you do find you need to do the above, though, let me know and I'll look at building something into the script.

Thank @bentasker. This is helpful. For now, I am good.


Hacky first fix for issue 164.

I want to look whether there is a better fix for this, maybe by moving this check into the override checker.
Instead, maybe something is wrong with the logic in the return statement that follows this change.
Let me know if this looks familiar.

Again, LGTM.
I will test this in the Google codebase and report back, but I don't think that even that is a blocker for merging. (If I discover that things somehow break as a result, we can always revert the commit :))
My next thought is that it does seem that this new case "shouldn't be necessary": nullnessEstablishingPathExists should find the "path" from T to T.
Ah, I wonder if somehow those are two different T types, as if the step of "adapting the formal parameter types of N to the type parameters of M" from JLS 8.4.2 is not being applied? That would be my guess: I seem to recall that the Checker Framework will let you override a supermethod <T extends Object> void foo() with a submethod <T extends @Nullable Object> void foo(), similar to how it allows parameter contravariance. Presumably that would require holding two different concepts of T in mind simultaneously when checking that any formal parameters have covariant types. (This is fresh on my mind because I was spreading FUD about it yesterday :)) So the Checker Framework may be checking overrides in a fundamentally different want than the JLS does... but I guess still delegating to isSubtype as part of that? I think that may line up well with my understanding of your fix. Or I could have any number of things totally wrong :)
Anyway, I've now talked myself into at least sort of having a theory about what's going on. And if that theory is right, your fix is probably the best we can do on the jspecify-reference-checker side. If so, it's still possible that something more can be done on the checker-framework side. But I wouldn't worry about it: There's still a decent chance that we end up redoing some of this code as a result of changes in design decisions and/or to make it fit more naturally into the Checker Framework model (instead of having this extensive isSubtype logic in jspecify-reference-checker at all).

It looks like I may be seeing fewer "incompatible parameter type" errors, albeit still not zero. It's a bit hard to tell how much of the reduction is because of #159 crashes that hide other problems, but clearly at least some of the reduction is real.
An example of a line on which I'm still seeing a problem is this one:
https://github.com/google/guava/blob/858caf425cdf3183776b61b437ba7a4129b6539b/guava/src/com/google/common/collect/MultimapBuilder.java#L472
Both the "found" type and the "required" type are "Multimap<? extends K, ? extends V>."

The remaining issue might be restricted to type parameters that extend other type parameters (and, similarly, wildcards that extend type parameters). Here's an example:
import org.jspecify.annotations.NullMarked;
import org.jspecify.annotations.Nullable;

@NullMarked
class Issue164Continued {
  interface Super<T extends @Nullable Object> {
    <U extends T> void foo(Lib<? extends U> lib);
  }

  interface Sub<T extends @Nullable Object> extends Super<T> {
    <U extends T> void foo(Lib<? extends U> lib);
  }

  interface Lib<T extends @Nullable Object> {}
}

$ ./demo Issue164Continued.java
Issue164Continued.java:11: error: [override.param.invalid] Incompatible parameter type for lib.
    <U extends T> void foo(Lib<? extends U> lib);
                                            ^
  found   : Lib<? extends U>
  required: Lib<? extends U>
  Consequence: method in Sub<T>
    void foo(Lib<? extends U>)
  cannot override method in Super<T>
    void foo(Lib<? extends U>)
1 error

It's a rare enough problem that I'd feel OK with adding suppressions for it. (I could believe that a proper fix would involve more areCorrespondingTypeVariables+isSubtype checks recursively on the bounds when the bounds are themselves type parameters.)

(Well, I guess we'll see how common it really is after the crashes are gone. Maybe it's worse than I think.)

At a higher level:

In addition to helping with various cases, this PR doesn't make anything worse (as far as I can tell).
If we merge it, and if we then find a fix for #159, and if nothing new breaks at that point, and if the crashes from #159 aren't hiding anything big, then I think we'd be ready to switch Google over, as the problems I reported above and in #172 appear to be minor.
To get a preview of all that, I applied the hacky checker-framework patch from my comment on #159 to silence the crashes. I didn't notice any new kinds of errors, and the level of errors does appear tolerable. (And I encountered at least a couple errors that were legitimate (if probably harmless), too!)

@cpovirk Thanks for the additional test!
The override checks seem a bit odd, but let's not try to fight them now. Adding an additional check for the subtype type variable being captured, in https://github.com/jspecify/jspecify-reference-checker/pull/171/commits/9421ef85843ad589c578c721aa35731fd6b90cc2, fixed the additional test and doesn't change the conformance results.
I like using different type variable names for different type variable declarations. That makes it easier to see in messages that it is looking at different types. The areCorrespondingTypeVariables check makes sure the different TVs from the two methods correspond.
If this is producing okay results, I would propose merging and cleaning up the CF interaction and wonkiness separately.


specialisations of ValueType::get() not obvious in GraphqlResponse.h

When looking at the definition of ValueType::get() in include/graphqlgen/GraphqlResponse.h,
91  // Specialized for all Types.
92  template <typename ValueType>
93  ValueType get() const;

the actually implemented template specialisations are not obvious. For example, trying to access a stringType value by
  v.get<graphql::response::stringType>()

will result in a linker error:
ctas.cxx:35: undefined reference to `std::__cxx11::basic_string<char, std::char_traits, std::allocator > graphql::response::Value::get<std::__cxx11::basic_string<char, std::char_traits, std::allocator > >() const'
This is because the actually implemented specialisation is
template <>
const StringType& Value::get<const StringType&>() const

Note the const reference type. I think the actually implemented specialisations template specialisation should be listed in GraphqlResponse.h:

const MapType&    get<const MapType&>()
const ListType&   get<const ListType&>()
const StringType& get<const StringType&>()
const ScalarType& get<const ScalarType&>()
BoleanType        get()
IntType           get()
FloatType         get()

At the very least a comment block would help. I'm not sure if I can make it 100% backward-compatible, but introducing a traits template which automatically picks the right type would help too.


[Fix]Added request header validation

Purpose of the pull request
refer to #9911

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #9912 (cd30c1c) into dev (15a15de) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9912      +/-   ##
============================================
- Coverage     40.32%   40.32%   -0.01%
  Complexity     4532     4532
============================================
  Files           835      835
  Lines         33747    33747
  Branches       3726     3726
============================================
- Hits          13608    13607       -1
- Misses        18852    18853       +1
  Partials       1287     1287

Impacted Files
Coverage Δ

...r/plugin/task/sqoop/parameter/SqoopParameters.java
53.33% <0.00%> (-1.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a15de...cd30c1c. Read the comment docs.


Previous and new users being stuck in pending status

I ran into an issue with my cluster where my users were all created and I could login into each of the nodes with my users but now I cant and they are stuck in this pending to be created state.

Active
Failed to execute cluster-init script '/mnt/cluster-init/slurm/login/scripts/00-install-login.sh' in project 'slurm' (return code: 1)
Software Configuration
Edit and re-upload the script to correct the error and try again
Get more help on this issue
Detail:
Script output:
An error occured during installation. See log file /var/log/azure-slurm-install.log for details.
2024-07-15 16:33:39,877 ERROR: An error occured during installation.
Traceback (most recent call last):
File "install.py", line 631, in
main()
File "install.py", line 604, in main
munge_key(settings)
File "install.py", line 207, in munge_key
ilib.copy_file(
File "/opt/cycle/jetpack/system/bootstrap/azure-slurm-install/installlib.py", line 148, in copy_file
shutil.copyfile(src=source, dst=dest)
File "/opt/cycle/jetpack/system/embedded/lib/python3.8/shutil.py", line 264, in copyfile
with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: '/sched/clusterpoc/munge.key'

Did you restart the cluster when you saw the issue in cluster-init? which version of CC is this?


How to provide EventHub consumer group ?

If I need to have mulitple consumers, I need to provide consumer group. Can that be add that to this sample?
Also this sample is using Kafka surface! To be honest, I was disappointed - or else the document be retitled as Connect .NET for Apache Spark to Apache Kafka. Is it possible to provide native clean EventHub sample without involving Kafka surface.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2625dc76-70f0-d481-2c90-2c65339f21bb
Version Independent ID: 24e94c5c-006c-a8b6-bc92-15590ebc0c59
Content: Connect .NET for Apache Spark to Azure Event Hubs
Content Source: docs/spark/how-to-guides/connect-to-event-hub.md
Product: dotnet-spark
GitHub Login: @Niharikadutta
Microsoft Alias: nidutta

We're no longer updating the .NET for Apache Spark documentation and have archived it to https://learn.microsoft.com/previous-versions/dotnet/spark/what-is-spark. As a result, we're closing all the active .NET for Apache Spark issues. I'm sorry we couldn't address your issue.


support for PostgreSql

Dear Developer(s),
Do you have any plan to add support for PostgreSql?
thanks,

https://github.com/borisdj/EFCore.BulkExtensions/issues/67


JS-Controller 3.3 - LOG-EIntrag State value to set for "mihome-vacuum.0.control.sound_volume"

mihome-vacuum.0 | 2021-04-30 10:03:55.788 | warn | (19112) State value to set for "mihome-vacuum.0.control.sound_volume" has value "2" less than min "100"

Which mihome-vacuum version?
version 2.2.5 has 30 as min and version 3.1.1 min is 0

Maybe object needs to be deleted to get it updated?

Here another Information, which got after updating JS to 3.3.2
Installed Adapter V 3.1.4

fixed in 3.1.6


Initial silde will not be displayed when lazyLoad mode enabled

Initial silde will not be displayed when lazyLoad mode enabled, and set lazyLoad: false slide will be displayed correctly. It seem some weird behavior in lazyLoad mode. Below is my setting when encountered this issue:
const settings = {
      className: 'center',
      infinite: false,
      speed: 500,
      lazyLoad: true,
      slidesToShow: 3,
      centerMode: true,
      centerPadding: '60px',
};

I was able to replicate this issue https://jsfiddle.net/kirana/xq3ph2vx/1/
I will try to fix it soon

@akiran Any update on this?

+1 I have the same problem.


add function:filterByOverlappingRegions

for multiple regions data select.

Can one of the admins verify this patch?

Jenkins, test this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1634/Build result: FAILURE[...truncated 3 lines...]Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1287/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains<PHONE_NUMBER>1bd4535c372f6c54dfa496a16372a2 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1287/merge^{commit} # timeout=10Checking out Revision<PHONE_NUMBER>1bd4535c372f6c54dfa496a16372a2 (origin/pr/1287/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f<PHONE_NUMBER>1bd4535c372f6c54dfa496a16372a2First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

From the failed Jenkins build
[INFO] Compiling 71 source files to /home/jenkins/workspace/ADAM-prb/HADOOP_VERSION/2.6.0/SCALAVER/2.10/SPARK_VERSION/1.5.2/label/centos/adam-core/target/2.10.6/test-classes at<PHONE_NUMBER>868
[ERROR] /home/jenkins/workspace/ADAM-prb/HADOOP_VERSION/2.6.0/SCALAVER/2.10/SPARK_VERSION/1.5.2/label/centos/adam-core/src/test/scala/org/bdgenomics/adam/rdd/read/AlignmentRecordRDDSuite.scala:110: error: not found: value resourcePath
[ERROR]     val inputPath = resourcePath("artificial.sam")
[ERROR]                     ^
[ERROR] one error found

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1635/
Test PASSed.

Merged! Thank you very much @liamlee for the contribution!

My pleasure.


addForeignKey Error -->Cannot read property 'onDelete' of undefined

I'm submitting a...

[x] Bug report
[ ] Feature request
[ ] Question

Current behavior
I'm creating my first table through db-migrate (YEAH) and added a foreign key to one of the columns:
exports.up = function(db, callback) {
 db.createTable('code_values', {
    columns: {
      id: {
        type: "int",
        primaryKey: true,
        notNull: true,
        autoIncrement: true
      },
      category_id: {
        type: "int",
        notNull: true,
        foreignKey: {
          name: "code_values_code_category_id_fk",
          table: "code_categories",
          mapping: {
            category_id: "id"
          }
        }
      }
    }
  },
  callback);
};
I get the following error when I run the migration:
[ERROR] TypeError: Cannot read property 'onDelete' of undefined     at Object.addForeignKey (/test/node_modules/db-migrate-pg/index.js:542:13)     at /test/node_modules/db-migrate-base/index.js:124:21     at Object.recurseCallbackArray (/test/node_modules/db-migrate-base/index.js:104:37)     at Object.<anonymous> (/test/node_modules/db-migrate-base/index.js:243:21) From previous event:     at Object.createTable (/test/node_modules/db-migrate-base/index.js:241:6)     at /usr/local/lib/node_modules/db-migrate/lib/driver/shadow.js:34:50     at runCallback (timers.js:763:18)     at tryOnImmediate (timers.js:734:5)     at processImmediate (timers.js:716:5)
Expected behavior
I expected the table to be created without the explicit rules added to the foreign key.  As for the foreign key, I expected it to default to NO ACTION for ON DELETE and ON UPDATE.
What is the motivation / use case for changing the behavior?
I was able to get things working when adding the following rules to the foreign key:
          rules: {             onDelete: 'RESTRICT',             onUpdate: 'RESTRICT'           }
Looking at db-migrate-pg's index.js, I believe the problem is that the function addForeignKey mandates a value for rules; and subsequently when rules.onDelete is called, the variable is undefined.
I'm willing to check this out further and work on a fix, but would love feedback in advance, especially since this would be my first time contributing to an open-source project.  Please let me know your thoughts and understand, I'd like to isolate my first potential commit to this specific item (updated documentation included of course) and look globally in the future.
Environment

db-migrate version: 0.11.1
plugins with versions: X.Y.Z
db-migrate-pg version: 0.4.0

Additional information:
- Node version: 9.9.0
- Platform:  Mac
- PostgreSQL 10.3
- Postgres 2.1.5

Closing issue - I meant to post in db-migrate-pg.  APOLOGIES!


Tag a commit with a release beyond v0.0.0-dev

This will help us to run sqlc as a go run command instead of downloading the binary.
Ex:
go run github.com/kyleconroy/sqlc/cmd/sqlc

Thank you very much!

@vinicio Sorry that I've been ignoring this issue. I'm not sure that I'm ready to start tagging releases. Currently, sqlc is released automatically from tip. Until that changes, I don't think tags make sense.
I know that's going to make it more difficult to use sqlc, but I think it's the right choice for the project at this time.


chore(button-group): add Button group React wrapper

Related Ticket(s)
[button-group]: add React wrapper to Storybook #8616
Description
Add React wrapper for Button Group
Changelog
New

DDSButtonGroup React Wrapper story, documentation, and codesandbox example

@annawen1 Looks good! Might want to adjust the grid columns in >=lg breakpoints. Adding additional buttons is a little tight. Also looks like you need to do a yarn format maybe?


GaloisKeys serialization crash

With the following code snippet, I'm receiving SIGKILL, it seems to be an infinite loop at the save step.
 #include "seal/seal.h"

 using namespace std;
 using namespace seal;

 std::string SEALSerialize(const GaloisKeys& sealobj) {
     std::stringstream stream;
     sealobj.save(stream);

     return stream.str();
 }

 GaloisKeys SEALDeserialize(const SEALContext& sealctx, const string& in) {
     GaloisKeys out;
     std::stringstream stream;
     stream << in;
     out.load(sealctx, stream);
     return out;
 }

 int main() {
     EncryptionParameters parameters(scheme_type::ckks);
     parameters.set_poly_modulus_degree(8192);
     parameters.set_coeff_modulus(
         CoeffModulus::Create(8192, {40, 21, 21, 21, 21, 21, 21, 40}));

     auto ctx = SEALContext(parameters);
     auto keygen = KeyGenerator(ctx);
     auto sk = SecretKey(keygen.secret_key());

     GaloisKeys gk;
     keygen.create_galois_keys(gk);

     auto serial = SEALSerialize(gk);
     auto new_gk = SEALDeserialize(ctx, serial);
     SEALSerialize(new_gk);

     return 0;
 }

My only "custom" flags for the build system are
set(CMAKE_CXX_STANDARD 17)

I ran the test with strace, and it actually shows an infinite loop of mmaps until it crashes.
mmap(NULL, 79695872, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbdca7a000
mmap(NULL, 79958016, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbd7e39000
mmap(NULL, 80220160, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbd31b8000
mmap(NULL, 80482304, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbce4f7000
mmap(NULL, 80744448, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbc97f6000
mmap(NULL, 81006592, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbc4ab5000
mmap(NULL, 81268736, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbbfd34000
mmap(NULL, 81530880, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbbaf73000
mmap(NULL, 81793024, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbb6172000
mmap(NULL, 82055168, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbb1331000
mmap(NULL, 82317312, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efbac4b0000
mmap(NULL, 82579456, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efba75ef000
mmap(NULL, 82841600, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efba26ee000
mmap(NULL, 83103744, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efb9d7ad000
mmap(NULL, 83365888, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efb9882c000
mmap(NULL, 83628032, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efb9386b000
mmap(NULL, 83890176, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efb8e86a000
mmap(NULL, 84152320, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7efb89829000
+++ killed by SIGKILL +++
Killed

Tested with SEAL 3.6. Ubuntu 20.04. gcc 9.3.0
The code was OK with SEAL 3.5.9, I hope I didn't miss something in the updated API.

Duplicate of #248

Thanks for the helpful report!
This was a pretty serious bug in native/src/seal/util/ztools.cpp. Our in-place Zstandard compression didn't update the "read-head" correctly so that the in-place compression basically didn't work, and all output was always written into temporary buffers. Since the output size continues to grow as more data is compressed, a new allocation was always done for each new size temporary buffer. Since these were allocation from a SEAL memory pool, the memory was not released until the function returned, and you ended up with huge memory drain. Linux killed your process because of this.
We'll release v3.6.1 shortly to fix this.

Thank you for the explanation&fix, @kimlaine! :rocket:

3.6.1 is now available. Please let us know if there are further issues.

The issue doesn't reproduce with 3.6.1.
Thank you so much for the quick fix! :+1:


Not hitting a breakpoint when going to bar

OS: Windows
Go: 1.17.2
I was going through your talk on the gophercon and follow along. Somehow I'm not encountering any breakpoint when visit the bar. Same with the gym.
I have cloned this version of code. https://github.com/suzmue/gophercon/tree/ffabae99c43a511fe7e53451aa3761d639012a69

Thanks for your response.
Not sure what made it work. But it is working now. I'll post the logs if it happens again.


Small issue with JaparyCraft

1.12.2
Sounds from JaparyCraft are not displayed in "Individual sounds configuration" menu.

I did a google of JaparyCraft and did not see anything related to such a mod.  Can you provide a link?  As for not showing if a mod handles its own sound handling outside of Minecraft/Forge framework then it would not show.

Here is the link: https://minecraft.curseforge.com/projects/japaricraftmod?gameCategorySlug=mc-mods&projectID=267324

Took a quick look at the source tree and do not see any sounds for the mod or any code related to sound registration.  Are you sure the mod has it's own sounds?

Yes, it has!

Don't see sound resources in their build tree.  For Minecraft there would be a location in the asset directory with the OGG files.  I will post an issue to find out where there are at.  It could be they are kept separate for whatever reason they do that.

Thank you!


Need usecase doc

Originally reported on Google Code with ID 135
It would be helpful to provide documentation on the purpose of this project like, how
this is comparable to official play... are we able to use all plugins and play features,
etc

Reported by<EMAIL_ADDRESS>on 2013-09-13 10:45:29

After migration to GitHub documentation was migrated from Wiki pages to Maven generated site. I will improve it.


Apis

GET Purchases, Sales, and Cases API calls

Coverage increased (+1.06%) to 29.484% when pulling bd5272457684c442e95e348cdb5a32aed1fe33c9 on apis into 547833a99b9a0820869f16cc1350f8284813facd on master.

Coverage increased (+1.1%) to 29.394% when pulling 403ce3e071419cc1755171099cea0c31e5a991bf on apis into 748e9e58fdabb4b7e7557825fb3efcb98eb51afa on master.


Feature chat

Description
Chat component is functional on frontend and backend with socket. Chats are errand specific, so open to anybody who can see that an errand is being run. In the FriendsList component clicking on the message icon next to a friend should open a modal with a list of errands being run currently. Direct one to one (private) chat isn't implemented.

Easy to reuse within any pressable Text or Icon or Image add this:
onPress{() => navigation.push('Chat', {errand: errand.chatId })}
Should route to appropriate chat. The errand.chatId would need to come from the associated errand data.
Also added a reusable IconModal component in the /components/Modals folder. It takes in parameters. Meant to make this a more reusable HOC but haven't gotten there yet.
I'm still using dummy data since db isn't fully populated yet. Backend controllers are in place but commented out. I also added the above code to the ErrandTracker's MessageButton component although I wasn't able to test it out.
How to test
Open the app, navigate to the FriendsList and then click on aaron's message icon. Click on the errand name
Notes

Apologies for any hackiness due to using dummy data over db data.
The FriendsList message modal is lookin real sorry. If anybody feels like styling next week just let me know
Check the chats dummy data for message configuration

Issue tracking
(https://trello.com/c/SgTr4Hji/60-chat-functionality-fullstack)

 Chat Functionality [Fullstack]

 Chat Functionality [Fullstack]

Fixed the merge conflict and made sure it was up to date with current dev. pulling