UX on touch devices: Close opened comment when user touches outside of sidebar comment or modal

Similar to #63, but for touch events.

@lpagliari, sorry to bother you, but I've got a question that you had chimed in on a month or so ago, and I'm trying to resolve. It sounds like @JohnMcLear is busy with other projects, per some of his previous communication I was cc'd on. I had previously noted that the dev ep_comments plugin seemed to throw two errors in the console regarding font-awesome fonts ONLY when minification is turned on in the main etherpad settings.json. I believe you both thought this to be related to the dev Etherpad instance or something (sorry I can't for the life of me find the previous comment on github - which is why I write to you here). Anyway, I'm trying to resolve that on my local instance, and I'm wondering if you can point me in the right direction. Maybe this is something that has already been fixed??? Do you have any workarounds or suggestions? I've got a very slow loading Etherpad, particularily in Safari (utilizing Comments and Page View), and I really need to get the minification working. I've tried some various tricks like manually placing minified versions of the two fonts that come up in the console error in a spot that looks to be where the files are trying to be located, to no avail. Any help would be appreciated, or maybe you can point me to a better spot to ask questions regarding this. Thanks!!!

@DanielBickley you probably didn't find the conversation because it was on Etherpad ploject: https://github.com/ether/etherpad-lite/pull/2690#issuecomment-111518519.
About the fix, the latest code from develop branch should not have the issue, there was a PR that fixed it. If you get the latest version of Etherpad, do you still see the error when minification is on?

@lpagliari Yep, bingo! Thank you so so very much. I really appreciate it. I found that even after the patch and turning minification back on that just Safari was still very sluggish. Turns out that sluggishness only in Safari was due to some Adware on the particular machine, and I've since removed it, retested Safari, and all is well. On to the next battle ;)

Awesome!


added script to create indices

would it be possible to make the bwc index creation a bit more generic?

ack if travis is green


rsync: explicit DESTDIR, no static link

resolves #1001
Existing package

[x] I am the maintainer of this package.

Any particular reason to drop static linking?

Closing in light of your comment on #1001

I assume static linking was just carried over from when this was in core. I don't think KISS lends itself well to static linking outside of system-critical packages.


Visualization of volcanoes location and other related information

See https://plot.ly/python/mixed-subplots/

Adding  https://openlayers.org/ in Galaxy for Visualizing geoJSON is on its way.

ping @anuprulez


Not working in android opera browser

https://play.google.com/store/apps/details?id=com.opera.browser

It's not possible to debug this issue without additional information. If this is still an issue, please leave a comment or open a new issue.


The container name "/airsend.kafka.worker.high" is already in use

This time i am getting this error
here we go
Error response from daemon: Conflict. The container name "/airsend.kafka.worker.high" is already in use by container "bc8d2d3c78bc9597afc595dd059ea640b8b562e37652c584e4c39d66dfcfec08". You have to remove (or rename) that container to be able to reuse that name.

any update for it ?


ENG-306 - move new dashboard value from localStorage to user/aceConfig

I've moved the flag into a separate property. (features didn't really work for me)
It is an enum now.

@mrfinch I'm not really sure what was my issue with features last time, but now it works...
Backend PR: https://github.com/codecombat/codecombat-server/pull/834


Question - how safe is deep-populate to use with unchecked input?

I am considering to write a REST API that by default just maps the database to the json object, e.g.
/products/<product-id>

Since there are a lot of object references it makes sense in some cases to allow deep population based on parameters, e.g.
/products/<product-id>?details=price,catalogue.store,catalogue.store.leadingMedia

where this would end up somewhat like:
foo.deepPopulate(['price', 'catalogue.store', 'catalogue.store.leadingMedia']);

Can this lead to stuff like sql injection or is deepPopulate safe in that regard?

You should whitelist the fields. So it should be safe.


ReactDOMServer.renderToString results in empty accordion shell.

Steps to Reproduce

Follow the create-react-app instructions to create a new project.
Use the code below in the src/index.js file (it's just the example in RAA's README.md file with ReactDOMServer.renderToString instead of ReactDOM.render).
Run yarn start and observe the results in the browser's console.

import React from 'react';
import ReactDOMServer from 'react-dom/server';

import {
    Accordion,
    AccordionItem,
    AccordionItemTitle,
    AccordionItemBody,
} from 'react-accessible-accordion';

// Demo styles, see 'Styles' section below for some notes on use.
import 'react-accessible-accordion/dist/fancy-example.css';

const Example = () => (
    <Accordion>
        <AccordionItem>
            <AccordionItemTitle>

Simple title

            </AccordionItemTitle>
            <AccordionItemBody>

Body content

            </AccordionItemBody>
        </AccordionItem>
        <AccordionItem>
            <AccordionItemTitle>

Complex title

With a bit of description

            </AccordionItemTitle>
            <AccordionItemBody>

Body content

            </AccordionItemBody>
        </AccordionItem>
    </Accordion>
);

console.log(ReactDOMServer.renderToString(<Example />));

Notes
I originally saw this issue happening in the context of a gatsbyjs project, which uses ReactDOMServer.renderToString for server side rendering.
For reference, the output that I see in the console is:

I ran through the render process and found that when AccordionItem renders it checks the accordionContainer.state.items array for a currentItem, and if it doesn't exist, it returns null, effectively resulting in no rendered contents in the final HTML string.
The first render (which is the case of SSR through ReactDOMServer.renderToString) will not have anything in the items array, as AccordionItem only populates that array on componentDidMount, which happens after the first render.

Gidday @jdfm, thanks for your issue and my apologies for the delayed response. This was an issue that we were aware of, and it's unfortunately a very difficult one to fix, related to a significant change in one of our dependencies unstated. I've made a PR to refactor it away, which you can track here.
Thanks for your patience :)

@jdfm thanks for your patience - it should be fixed with today's release 🍾
Would appreciate it you could please try it out for us, and if it looks good then I encourage you close this issue. Thanks again!

I'll try to get to it today or tomorrow, will let you know once I've done so. Thanks for looking into this! Cheers!

@ryami333 I just encountered this problem in my own Gastby project so I was happy to see a new version had been released since I first installed react-accessible-accordion.
Unfortunately after upgrading to 2.4.5 the problem still persists. I also tried with a fresh create-react-app project as mentioned by @jdfm in the original post and the result is the same.

@ryami333 I just tried it locally, it's still giving me the results I was seeing before unfortunately.

We're having the same issue - had to roll back to 2.4.2 because of the empty div being rendered.

Approach has been totally overhauled, and SSR has been addressed in next branch. Will be published with 3.0.0.


Failing tests for dense modulus

Some tests are failing for generated secp256k1 fields which has 256 bit dense modulus value. To regenerate in a clean directory:
goff -m<PHONE_NUMBER>37316195423570985008687907853269984665640564039457584007908834671663 -o . -p secp256k1_fp -e Element
go mod init tmp && go mod tidy
go test

@kilic thanks for raising this issue :)
The field arithmetic code generation for multiplication [saturated moduli only] was missing a carry propagation. Fixed, and goff is updated to latest gnark-crypto .

On a side note, we are also looking at secp256k1 fields  (not the curve operations), and might end up re-working these type of moduli in the future, perf-wise.


HIVE-14585: Add travis.yml and update README to show build status

We should probably test with java7 also.


[FEATURE REQUEST] Remove unnecessary design docs.

Is your feature request related to a problem? Please describe.
We have old design docs that can be misleading for someone using Epiphany.
Describe the solution you'd like
We want to review existing design docs and remove unnecessary ones.
Describe alternatives you've considered
None.
Additional context
None.

DoD checklist

[ ] Changelog updated
[ ] COMPONENTS.md updated / doesn't need to be updated
[ ] Schema updated / doesn't need to be updated
[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade

[ ] Idempotency tested
[ ] Documentation added / updated / doesn't need to be updated
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license
[ ] Backport tasks created / doesn't need to be backported

Example - https://github.com/epiphany-platform/epiphany/blob/develop/docs/design-docs/cicd-server/comparision_cicd.md

@seriva , @atsikham , @to-bar, @plirglo, (and all others)
Please tell me, what do you think about the new approach for design-doc:
The design-doc we store should be related to the feature we are going to implement.
During the SPIKE, design-doc should be created.
After implementing the feature and release a new epicli version design-doc should be removed.

In the following approach, we would avoid a mess in this documentation.
If you agree, I will remove all .md's not related to the release 2.0 version (everything beside rook).

@seriva , @atsikham , @to-bar, @plirglo, (and all others)
Please tell me, what do you think about the new approach for design-doc:
The design-doc we store should be related to the feature we are going to implement.
During the SPIKE, design-doc should be created.
After implementing the feature and release a new epicli version design-doc should be removed.

In the following approach, we would avoid a mess in this documentation.
If you agree, I will remove all .md's not related to the release 2.0 version (everything beside rook).

Yeah I think this is a good idea.

IMO if feature is present in source code then corresponding design-doc may be helpful for someone to get familiar with the feature (especially when the doc contains a diagram) or to find out why a decision has been made.
For me standard docs are rather addressed to users (how to use, user guide) and design-docs are addressed to team-members or advanced users (how it works or why that's way).
But I see one problem with keeping a design-doc as long as feature is present - it should be updated - keep in sync with implementation and later changes.


Changing the documentation for Add lookup values

Hi team,
Happy new year 2023! Hope you had a great and happy holiday!
Regarding to this documentation, I have the testing in application 10.0.30 & 31. If we are following the doc in the step 1, adding the custom in DimensionSetEntity the lookup will not show, just showing if we added the custom in DimensionCombinationEntity. Please help verify this point and update the documentation for prevent confusing for other if need. Thank in advance.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9e649d6b-376d-e6fd-e6c2-756034a29b6d
Version Independent ID: b9101768-d4e3-ce5e-3f50-16f7caa43677
Content: Add lookup values for financial dimensions to Excel templates - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/financial/add-dimensions-excel-templates.md
Service: dynamics-365-cross-app
Product: ****
Technology: ****
GitHub Login: @RyanCCarlson2
Microsoft Alias: rcarlson

Bug 777969 has been logged to address this issue.


sieemma submission space for testnet

id1 submission space

B1 submission
Node ID: ffdca1a555384751

confirmed:ID1
account1:33CvPDc9hQWHJvPys4PfTkox7EAVzRLkJx1xnNgw5QuZjHKnXC
account2:3yNoRkWmBV3Kj3jBkFn2ocfrwi8Ygy65AFpDwg5bmYfp9Hkt76

confirmed:B1
node:ffdca1a555384751

confirmed:B1
node:ffdca1a555384751

confirmed:ID2
account1:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
account2:3jCR1zpVB7ZXdjroYUdqPHKKhbR2kLsqjfzcC5i3nmNEiWXkrN
PublicDataAttributes:Verified
DeviceMake&Model:Verified

confirmed:ID2
account1:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
account2:3jCR1zpVB7ZXdjroYUdqPHKKhbR2kLsqjfzcC5i3nmNEiWXkrN
PublicDataAttributes:Verified
DeviceMake&Model:Verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:B3

confirmed:B3

confirmed:ID4
AccountAddress:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
DeviceDetails:verified

confirmed:ID4
AccountAddress:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
DeviceDetails:verified

pending:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified
Screenshot:missing
We cannot fully verify this submission. Please provide us with screenshots with all four transactions.
@sieemma

pending:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified
Screenshot:missing
We cannot fully verify this submission. Please provide us with screenshots with all four transactions.
@sieemma

This isn't possible
On Tue, 12 Jan 2021 at 10:29, Suhas Hegde<EMAIL_ADDRESS>wrote:

pending:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified
Screenshot:missing
We cannot fully verify this submission. Please provide us with screenshots
with all four transactions.
@sieemma https://github.com/sieemma
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Concordium/Testnet3-Challenges/pull/75#issuecomment-758561729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIP2VEWPKOQEZXCJUFORSCTSZQP7FANCNFSM4SRY2PIA
.

This isn't possible
On Tue, 12 Jan 2021 at 10:29, Suhas Hegde<EMAIL_ADDRESS>wrote:

pending:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified
Screenshot:missing
We cannot fully verify this submission. Please provide us with screenshots
with all four transactions.
@sieemma https://github.com/sieemma
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Concordium/Testnet3-Challenges/pull/75#issuecomment-758561729,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIP2VEWPKOQEZXCJUFORSCTSZQP7FANCNFSM4SRY2PIA
.

confirmed:ID4
AccountAddress:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
DeviceDetails:verified

confirmed:ID4
AccountAddress:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
DeviceDetails:verified

confirmed:B4
address:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
baker:620

confirmed:B4
address:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
baker:620

confirmed:T2
account1:4stdLq7RzgYqCfLkGHdKB6wBuDXr8rDj41hUKtJweqHWBLPzJM
account2:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg

confirmed:T2
account1:4stdLq7RzgYqCfLkGHdKB6wBuDXr8rDj41hUKtJweqHWBLPzJM
account2:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg

confirmed:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified

confirmed:T1
account1:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w
account2:35AceGYGufY4sshqXUX7pGakNsbsQ6mX26Nw4yD9ne8Ru9ipLZ
DeviceDetails:verified

rejected:B5
address:3E6MtsihqZfu4yRFjPsj7qx5Umk2t6WqHxAzN69TtizEQjE3tg
reason: no 'update baker account' or 'update baker key' transactions found on-chain

confirmed:B5
address:4GXgdK2iuEjtzVkX4x3hFnFYahnvRHkzJY36XXqh3F7GTByw4w

Form Submitted at  around 1.30. Timezone is UTC 0


Wondering if inventor conversion is coming soon in Chunker

I was delighted to learn about Chunker today. I had a very involved Minecraft PE world that I saved from an older Kindle but could not use and wanted to play it again on Mac OS. Your utility did it! I was disappointed to see no inventory conversions. Is that coming soon? If not, I can just continue in this world and find new resources.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9f2fb27f-0ce1-9541-e617-7fe8148f8297
Version Independent ID: 6777fa19-93ad-1984-5fd8-a9adc3dc3a3a
Content: Chunker - Overview
Content Source: creator/Documents/ChunkerOverview.md
Service: minecraft-bedrock-edition
GitHub Login: @neonerz
Microsoft Alias: mikeam

Hi David!
Inventories should convert using Chunker so it might be that it's in an older format than Chunker supports, if you would like to email the world over to us<EMAIL_ADDRESS>(using OneDrive etc if the world is too big to be emailed). We'd be happy to check over it and see if there's anything we can do to improve the conversion.

Ahh! I'm glad to hear, I'll pass your comments on to our team :)


User code is still referenced on page even though that sign in method has been retired.

[Enter feedback here]
User code is still referenced on page even though that sign in method has been retired.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a671ef3-7321-b9b6-2ca5-9378c613a31b
Version Independent ID: 26462292-c010-d177-6ebb-6d63ae82e5f7
Content: Install and sign in to Live Share in Visual Studio Code - Live Share
Content Source: docs/use/install-live-share-visual-studio-code.md
Product: visual-studio-family
Technology: live-share
GitHub Login: @fubaduba
Microsoft Alias: fishah

https://learn.microsoft.com/en-us/visualstudio/liveshare/use/install-live-share-visual-studio-code#sign-in-by-using-a-user-code
This whole section of functionality doesn't seem to exist any more


Errors in ONYXKEYS.USER_WALLET getting cleared instantly without user interaction

Regression coming from: https://github.com/Expensify/App/pull/10447/files#r1017060491
If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Have a user with 2 bank accounts

Go to /settings/payments in new dot
Click the bank account that is not your Default

Click "Make default payment method"
Input a bad password

https://user-images.githubusercontent.com/87341702/200663920-ab6260ae-6260-4a2d-a6a7-df06eb1f0cb5.mov
Expected Result:
There will be an error below the "Add payment method" button, the error should stay there until you click the X
Actual Result:
The error appears below the "Add payment method" button, but gets immediately removed
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
View all open jobs on GitHub

cc @Justicea83

@aldo-expensify No we are not testing error in the regression.

@aldo-expensify No we are not testing error in the regression.

Sorry, not sure what this means. I mean, in the testrail tests, do we have a manual test that do these steps and look for this error? I'm guessing that we don't have and that's why this regression got to production

@aldo-expensify

No we are not testing error in the regression.

Sorry, I meant there are no testrail steps to test the errors.

ok!, thanks

you don't mean errors in general, right? you are talking about errors in this page or particular button?

I was able to reproduce this. There is no error when entering the wrong password. Should this be External @aldo-expensify?

@lschurr I'll take care of it internally, I know already where the bug is :)

@lschurr added you back because I think we need to handle the C+ @thesahindia review in the PR

Hm, so do we need a job posting for this in Upwork @aldo-expensify?

hehe, I'm a bit lost too, but I think:

@thesahindia should be assigned to this issue because he is the C+ that reviewed the PR
An Upwork job posting should be created to pay @thesahindia

@Beamanator is this correct?

Kinda looks like a decent amount of people are still unclear how this works :D https://expensify.slack.com/archives/C01SKUP7QR0/p1668104342206089

Asked for more guidance here.

Ok, I posted the job.
https://www.upwork.com/ab/applicants/1592221542839255040/job-details
https://www.upwork.com/jobs/~01431277aec358749a
@thesahindia - can you apply in Upwork so that we can pay you for reviewing the PR?

Also @aldo-expensify - do you know if a regression test has been added to testrail for this one?

@lschurr I requested a test to be added/updated for it here: https://github.com/Expensify/Expensify/issues/241841

@thesahindia - can you apply in Upwork so that we can pay you for reviewing the PR?

@lschurr, done!

Cool - the PR has been merged right @aldo-expensify? Can we consider this bug fixed?

Yup, it's on staging.

The update of the manual test to include this case is done (https://github.com/Expensify/Expensify/issues/241841).

@thesahindia has been paid in Upwork. I believe we can close!


Make LazyMap pickleable.

Do you know what the problem is with the CI failures?

Ci fixed in #548

One random failure, all good otherwise.


Introduce error handling on loadImage

Is there any reason to resolve the loadImage promise even if some image failed loading? Need some identification on my project if there is a failure on image loading.
I was not able to add a pull request. Put my changes in this issue.
@@ -126,7 +126,7 @@ function loadImages(images, imageLoadingInfo) {
  */
 function loadImage(src, container) {
   // console.log('--> start loading img: %s', src);
-  return new Promise((resolve) => {
+  return new Promise((resolve, reject) => {
     const img = new Image();
     img.onload = () => {
       // console.log(`src: ${src}`);
@@ -134,8 +134,7 @@ function loadImage(src, container) {
     };
     img.onerror = () => {
       console.error(`[prefetch-image]: "${src}" failed`);
-      //still resolve even if some image failed loading
-      resolve(src);
+      reject(src);
     };
     img.src = src;
     container.push(img);

Thanks

We could add an option to indicate whether it should reject the whole promise, or just ignore the errored images, not sure when I will have some time to add it

Thanks for the fast response, adding an option would be great and enough.

Can you give me a time approximation, when are you be able to add the option?

not sure about this 😅 , you may need to copy the file by yourself for now


Implement Raise a Request Functionality for Requesting Logos

What is this issue related to?
Feature
Description
User can raise a request for their company logo by providing their email ID and company url.
Expected Behavior

On home page in Try it now section when user searches for a brand logo and doesn't find one an error message is displayed below  as Logo Not Available. Beneath this error message a section to Raise a Request will be added with a message Couldn't find your logo try raising a request and a button Raise a Request. Upon clicking this button a modal will open up which is a form asking for user email Id and company URL. Upon this form submission user's request for their logo is processed.

Corresponding APIs needs to be created to handle form submission.

Current Behavior

There is no Raise a Request section for user to request their company logo upon failing to find their logo.

No backend APIs have been implemented yet to handle Raise a Request form submission.

Additional Information (optional)
It's yet to be determined if existing schema is going to be used to handle Raise a Request feature or will be needing a new schema.
Confirmation Checklist

[ ] I have searched for similar issues before creating this one.
[X] I have provided all the necessary information to understand and reproduce the issue.

This task is delayed by weeks.


"delete_entity" method is limiting the deletion of only ~ 120 elements at a time

We're facing a challenge when trying to bulk delete GUIDs from Azure Purview using "delete_entity(guids)" method. In sum, we can not provide lists greater than 100 elements.
This is a big issue when we need to delete several items. For example, we're trying to bulk delete more than 4 Million items and this may take several days to complete if we don't use parallel processing techniques.
Succesful deletion (~ 100 items):

Parse error when trying to delete more than 120 items:

Hi @richardsonbq - Thank you for using the PyApacheAtlas package!
This is a Purview / Atlas limitation.
If you're just clearing out the catalog, you might delete the Purview service itself and re-build it.
Depending on your type definitions and relationships, you might be able to delete a high level entity that has COMPOSE relationships to other entities.

For example, if you delete an Azure SQL Table, it will also delete its child columns because of the relationship type definition.
You might investigate whether certain types you are deleting are interrelated in such a way.

Thanks, Will! I'm trying to clean up AWS S3 entities from a full load that we have done as part of a Private Preview in our main account. Therefore, creating a new one is not an option right now.
I haven't checked yet whether the deletion of the compose relationships actually works for S3, but definitely will check on that. Either way, the multithreading strategy is working fine (even not being the most effective one).
Thank you!


news Page

Description
Added the menu log and the heading card on News Page
In progress #19

pls fix the merge conflicts and we are gtg @debidattasuryaprakash :+1:


add installation command to readme

add installation command to readme linked with issue https://github.com/pberkes/big_O/issues/35

Thank you!


document how to connect to any fabric network

A good example is here https://github.com/hyperledger/fabric-samples/tree/main/token-sdk


use random grpc port

KubeArmor/config/config.go : define a constant for the pid file path
KubeArmor/feeder/feeder.go : use a random grpc port number and save it to a file
previously we can't use random grpc port
now we can use random grpc port number by specifying "0" as the port number, by using port number 0, we will listen on random port and then we save the random port number to a pid file located in /opt/kubearmor
Signed-off-by: nthnieljson<EMAIL_ADDRESS>

this is addressing the issue on #623 to use random grpc port number

Codecov Report

Merging #672 (38028e1) into main (925a26a) will decrease coverage by 7.46%.
The diff coverage is 9.67%.

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   43.35%   35.89%   -7.47%
==========================================
  Files          23       25       +2
  Lines        8530     9033     +503
==========================================
- Hits         3698     3242     -456
- Misses       4378     5336     +958
- Partials      454      455       +1

Impacted Files
Coverage Δ

KubeArmor/config/config.go
85.85% <ø> (+1.95%)
:arrow_up:

KubeArmor/monitor/systemMonitor.go
48.06% <0.00%> (-1.28%)
:arrow_down:

KubeArmor/feeder/feeder.go
53.10% <16.66%> (-0.94%)
:arrow_down:

KubeArmor/monitor/syscallParser.go
54.54% <0.00%> (-23.71%)
:arrow_down:

KubeArmor/feeder/policyMatcher.go
37.56% <0.00%> (-3.09%)
:arrow_down:

KubeArmor/core/kubeUpdate.go
43.68% <0.00%> (-1.10%)
:arrow_down:

KubeArmor/enforcer/appArmorEnforcer.go
48.29% <0.00%> (-0.60%)
:arrow_down:

KubeArmor/enforcer/SELinuxEnforcer.go
0.00% <0.00%> (ø)

KubeArmor/enforcer/appArmorHostProfile.go
0.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d78301...38028e1. Read the comment docs.

@nthnieljson can you make all the changes in a single commit in order to merge this PR?


Improve Zod errors

Description

Starts some work improving our Zod error map.
Refactors all safeParse() calls on Zod schemas to use a new parseWithFriendlyErrors() utility which bundles up our logic for throwing an error with the error map.

size-limit report 📦

Path
Size

/index.html
5.23 KB (0%)

/_astro/*.js
21.54 KB (-0.02% 🔽)

/_astro/*.css
13.13 KB (0%)


api_docs: Reorder and rename endpoint titles in left sidebar and documentation page.

This PR reorders endpoints in left sidebar of API documentation and renames endpoint titles to make them consistent across left sidebar and documentation page.
CZO discussion

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @Vector73!


Tracking dhcpv6 dhcpd6 overide PD fix

Missing the overide section for PD!

I've issued this PR on the stable branch so users can just patch it. I'll issue a PR for master in a few moments.

patching works regardless of branches, especially because both branches carry the same code

When I created the patch using master there were other changes that appeared in the diff that did not apply to 18.7 stable, I was taking no chances. :)


[SPARK-30410][SQL][2.4] Calculating size of table with large number of partitions causes flooding logs

What changes were proposed in this pull request?

Backported from pr#27079. For a partitioned table, if the number of partitions are very large, e.g. tens of thousands or even larger, calculating its total size causes flooding logs.
The flooding happens in:

calculateLocationSize prints the starting and ending for calculating the location size, and it is called per partition;
bulkListLeafFiles prints all partition paths.

This pr is to simplify the logging when calculating the size of a partitioned table.
How was this patch tested?

not related

Test build #116336 has started for PR 27143 at commit 77607bb.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21127/
Test PASSed.

Test build #116336 has finished for PR 27143 at commit 77607bb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116336/
Test PASSed.

Merged to branch-2.4. Thanks!

Thank you all!


cclib task document is missing the molecule field

See https://github.com/materialsproject/atomate2/issues/342. To be patched upstream in https://github.com/materialsproject/atomate2/pull/343.

Fixed upstream.


use recomended hash prefix for task name

In google/cloud-tasks/src/V2/Gapic/CloudTasksGapicClient.php the createTask docs say
Explicitly specifying a task ID enables task de-duplication. If a task's ID is identical to that of an existing task or a task that
was deleted or executed recently then the call will fail with [ALREADY_EXISTS][google.rpc.Code.ALREADY_EXISTS]. If the
task's queue was created using Cloud Tasks, then another task with the same name can't be created for ~1hour after the
original task was deleted or executed. If the task's queue was created using queue.yaml or queue.xml, then another task with
the same name can't be created for ~9days after the original task was deleted or executed. Because there is an extra lookup
cost to identify duplicate task names, these [CreateTask][google.cloud.tasks.v2.CloudTasks.CreateTask] calls have
significantly increased latency. Using hashed strings for the task id or for the prefix of the task id is recommended. Choosing
task ids that are sequential or have sequential prefixes, for example using a timestamp, causes an increase in latency and
error rates in all task commands. The infrastructure relies on an approximately uniform distribution of task ids to store and
serve tasks efficiently.

I'm interpreting this as meaning that making the md5(timestamp) as the prefix will be a performance increase because google can search for duplicate task names quicker.

Thanks for the PR! Great idea, which has got me thinking...
Initially, a custom task name was added in this pull request to make it more clear which task is in the queue. While I like that, I value the performance of inserting tasks more. I'm currently inclined to remove the $task->setName(...) (and thereby lose the task deduplication feature in Cloud Tasks) because Laravel also has task deduplication and it's more powerful.
The downside is that the task names are less readable. But to be honest, this is not very readable either 😛 :
5f4dcc3b5aa765d61d8327deb882cf99-Tests-Support-SimpleJob-f47ac10b-58cc-4372-a567-0e02b2c3d479
What do you think? @ted-selig-five9

I think it would be worth it to do it like that too, I can try to implement that.


Fix table header of v1.25

We should separate table for v1.25.16+rke2r1 and lower.

Closing in favor of https://github.com/rancher/rke2-docs/pull/243, thanks for finding this @masap


Add TAFE SA + Department for Education SA

@lennykano I am sorry, at least one of the domains in the request does not belong to a university, nor to a college. I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page before submitting a new request.
The repository is for email domains belonging to colleges and universities. We do not add email domains of umbrella and government organizations here. Please send a request by email to<EMAIL_ADDRESS>in order to discuss available options, depending on your specific needs. Thank you.

@philipto my apologies, I'll admit I wasn't particularly thorough with reading what is eligible.
After checking again TAFE SA does seem to fit the criteria so I've done another MR (https://github.com/JetBrains/swot/pull/8381) for that one.


i download the code and i try to run it according to readme. but i got an error when using python3, the reason is that image not fonund, could you help fix it,Thank you

python3 skadnetwork_server.py
Traceback (most recent call last):
File "skadnetwork_server.py", line 6, in
from ecdsa_wrapper import ECDSA
File "/Users/kevin/Downloads/Singular-SKAdNetwork-App-master/skadnetwork-server/ecdsa_wrapper.py", line 6, in
from fastecdsa import curve as fe_curve, keys as fe_keys, ecdsa as fe_ecdsa
File "/Library/Python/3.7/site-packages/fastecdsa/keys.py", line 6, in
from .ecdsa import verify
File "/Library/Python/3.7/site-packages/fastecdsa/ecdsa.py", line 5, in
from fastecdsa import _ecdsa
ImportError: dlopen(/Library/Python/3.7/site-packages/fastecdsa/_ecdsa.cpython-37m-darwin.so, 2): Library not loaded: /usr/local/opt/gmp/lib/libgmp.10.dylib
Referenced from: /Library/Python/3.7/site-packages/fastecdsa/_ecdsa.cpython-37m-darwin.so
Reason: image not found

Hi @kevin-ma - did you resolve the issue? if not let us know and we'll take a look at this, otherwise would be great if you can share you solution...
Was it just an installation issue with the fastecdsa package?
Thanks


owl-top failed on macOS: string.h not found

Specifically on macOS Mojave I needed to run:
https://stackoverflow.com/a/55465527/128028
open /Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg

Please update documentation so people using macOS can benefit from it. After installing the package above, I could install owl-top without issues.

I will find somewhere to mention this, but it does not seem like owl specific issues.


Make compatible with pull_request_target

By looking up the PR GITHUB_HEAD_REF instead of using the GITHUB_REF we allow this action to be run for pull_request_target GitHub action events.
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
I believe that for actions running on pull_request, GITHUB_REF == GITHUB_HEAD_REF so this should be backwards compatible.
https://docs.github.com/en/actions/reference/environment-variables
I'm conscious that I've made a couple of changes that are not aligned with some of the existing style, do let me know if you want me to revert them:

this.pr -> maybe undefined instead of null. This was for convenience with .find but also personally I try to avoid null in JS code because I don't want to have to deal with 2 different null states, so I choose the one js uses internally (ie. undefined)
Some shared state in the test code with prNumber and basePull - I don't see this as problematic but happy to change back to redefine inside every test case.

The reason this is useful for me in particular is that I wanted this to auto-run on PRs opened by dependabot, however dependabot only has readonly access
For completeness, this is what that action looks like:
name: Reviewer lottery
on: pull_request_target
jobs:
  test:
    if: github.event.pull_request.user.login == 'dependabot[bot]'
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: Phil-Barber/reviewer-lottery@pr_target
        with:
          repo-token: ${{ secrets.GITHUB_TOKEN }}

hi @Phil-Barber! I haven't had time to have a look at it yet but I'll do this week. I was planning on doing something similar myself so thanks for taking the time 🙇

hi @Phil-Barber! I haven't had time to have a look at it yet but I'll do this week. I was planning on doing something similar myself so thanks for taking the time 🙇
In the meanwhile, could you update the documentation in the Readme to reflect this? if it's indeed backwards compatible, I think we should have this as the default config for users. I think we want to have it run on [opened, ready_for_review, reopened] anyways, not the default for pull_request_target which is [opened, synchronize, reopened].

Yep absolutely! I'm also reasonably busy atm but I'm sure I can get this ready next week 👍

@uesteibar I've pushed those changes now - I hope you're happy with them. Do let me know if there are further adjustments to be made! I've lost a little context on this since opening it so fingers cross what I've written is still accurate 🤞

thanks for this @Phil-Barber! I've released this as v2 because it requires a config change on .github/workflows.reviewer-lottery.yml

Exciting - thanks 😁


Mentions don't show in polls

Channels and user mentions don't show in poll, as the description is put in the title. I believe descriptions were added into a field when we had trup.

Description should go into the description field :P But yea, definitely!


Review questionnaire selector in URL

When adjusting the questionnaire selector on the review page, its state should be in the URL so that users can send links to each other.

So this relates to the beneficiary page, for example https://app.impactasaurus.org/beneficiary/dan?vis=radar&agg=question. You can see in the URL we currently keep reference to the visualisation options I have selected, so I was looking at the radar viz with a question aggregation. However, the link does not detail what questionnaire I was looking at. So when I share this link to you, you won't necessarily see the same thing I did (for example I am looking at the #161 questionnaire).
This story aims to get the currently selected questionnaire into the URL as well.
https://github.com/impactasaurus/app/issues/83 is worth looking at, this is the issue which added the visualisation parameters into the URL.

 General refinement


bugfix: camera_photo_interval is not set correctly

Seems like this field was just ignored...
Resolves this issue in Swift.
@byuarus @douglaswsilva: FYI

Tested to work by @byuarus.


Heroes on buildings map

Display hero positions (lanes) on buildings map, also probably if it's possible - heat-map from the performances page on icon hover.

I think we have the data for both of these already, so it's definitely possible!

I've started working on this one - will hopefully keep you posted / open a PR soon!

Awesome, thanks!

@samwhite any update on this?

It seems that this has been inactive for a while so I started implementing it.
I can submit a PR for hero icons soon.
Currently I have it like this: Display the player icon on the corresponding lane and have a React Tooltip for it where I can say whether the player is roaming or not. Is this way okay?
Also was wondering about the size and positions of the icons.
Any other recommendations or tooltip information suggestions?

LGTM.  Is it possible for the icons to cover the buildings if say, everyone goes mid?

I modified it somewhat from before: made the icons smaller and adjusted positions a bit.
No buildings or other heroes can get covered.
For example even if I add everyone to every lane on their own team (this looks a bit confusing but can never happen, it would mean 20v20):

Normally it looks like this:


How to click a button to flip page?

Hi There,
It's so nice to see your library. I'm trying to customized it. After research couple day, I still have some questions:

How to determine which page that user move finger in (left page or right page)?
How is clickToFlip() works?, I want to know that because I want to detect the action click to flip the page.
Can I use the pageFlipView as a customize view in layout? It's seem wrong Point X Y when I'm trying to do that.

After couple hours, I have my own answer for question number 2 and 3, but I have a new question.
2. ClickToFlip() works as the action like fingerDown() and fingerUp() in the same coordinates.
3. Yes we can use pageFlipView as a customize view in layout. My problem was I use the onTouchListener of all the Activity instead of the only pageFlipView.
My new question is

I'm trying to customize the Double pageFlipLayout that one size page is the square instead of the rectangle. I don't know why all photo is black.

@tranchunghieu118 do you have a sample app to let me take a look? Currently, the PageFlip don't support margin or padding set, I thought to support them but eventually I gave up, that because it could brings more complex for computing and drawing.
Another way, maybe you can try to put the PageFlipView in a layout, the layout is responsible for drawing the margin or padding areas, and your PageFlipView is a square in it and only need to drawing for itself. I'm not sure if it is possible but you can try

Close it since no response is received


Recipe tests

Implement #62
Improve #61 with comments and coverage
Improve #54 with comments

Why is CI failing here?


Scatter Chart Addition

Adds functionality to plot scatter charts using scatter_chart tag

Thanks for the pull request! Can you also add it to the readme?

I'm trying to generate a scatter chart, however I'm getting:
Invalid block tag on line 53: 'scatter_chart', expected 'endblock'. Did you forget to register or load this tag?


Move GNOI RPCs into GNOI specific feature profiles

This PR relocates all the GNOI related tests into GNOI features, with subfeatures mapping to the same layout as the GNOI repo uses.
This is to complete the conversation previously brought up in #264.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.965%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
783

Relevant Lines:
1187

💛  - Coveralls


Fix OOB access in FlagHeadsAndTails

Fix the issue about out-of-boundary access in the BlockDiscontinuity::FlagHeadsAndTails method.

LGTM, I'll kick off testing on this soon.

DVS CL: 30052178
gpuCI: NVIDIA/thrust#1455


fix(42133): undefined[] converted to any[] in js

Fixes #42133

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

Since this is a 4.3 bug, let's hold this until after 4.2's RC period is over.


Ability to have a fake the sdk actions

To facilitate in the unit testing of an operator I think it would be helpful to have something like this, or some other mechanism to fake out the Query/Create/Update... actions.

Closing this issue. After #615 the controller runtime has this feature. https://github.com/kubernetes-sigs/controller-runtime/tree/master/pkg/client/fake


more fully featured bristleback serial_payload_example app

Modifications to support PME dev, can run MicrDOT with the default example apps:

copied relevant code from BMDK serial_payload_example to BB version for more full PLUART features and configs.
enable 5V output on BMDK version (this has tripped up at least one forum user already too).
fix a logging bug in BMDK version.

@towynlin @matt001k @victorsowa12 - I have no objections to any of the proposed improvements / changes, but this is all just straight copied over from the BMDK version of this app. Would prefer to save improvements for an eventual cleanup of the overall serial payload examples.
Going to merge this one in now as-is for PME support.

Makes perfect sense. I'll queue up a backlog story for the improvements.


[CARBONDATA-3752] Reuse Exchange to fix performance issue

Why is this PR needed?
Spark ReusedExchange rule can't recognition the same Exchange plan on carbon table.
So the query on the carbon table doesn't reuse Exchange, it leads to bad performance.
For Example:
create table t1(c1 int, c2 string) using carbondata

explain
select c2, sum(c1) from t1 group by c2
union all
select c2, sum(c1) from t1 group by c2

physical plan as following:
Union
:- *(2) HashAggregate(keys=[c2#37], functions=[sum(cast(c1#36 as bigint))])
: +- Exchange hashpartitioning(c2#37, 200)
: +- *(1) HashAggregate(keys=[c2#37], functions=[partial_sum(cast(c1#36 as bigint))])
: +- *(1) FileScan carbondata default.t1[c1#36,c2#37] ReadSchema: struct<c1:int,c2:string>
+- *(4) HashAggregate(keys=[c2#37], functions=[sum(cast(c1#36 as bigint))])
 +- Exchange hashpartitioning(c2#37, 200)
 +- *(3) HashAggregate(keys=[c2#37], functions=[partial_sum(cast(c1#36 as bigint))])
 +- *(3) FileScan carbondata default.t1[c1#36,c2#37] ReadSchema: struct<c1:int,c2:string>

after change, physical plan as following:
Union
:- *(2) HashAggregate(keys=[c2#37], functions=[sum(cast(c1#36 as bigint))])
:  +- Exchange hashpartitioning(c2#37, 200)
:     +- *(1) HashAggregate(keys=[c2#37], functions=[partial_sum(cast(c1#36 as bigint))])
:        +- *(1) FileScan carbondata default.t1[c1#36,c2#37] ReadSchema: struct<c1:int,c2:string>
+- *(4) HashAggregate(keys=[c2#37], functions=[sum(cast(c1#36 as bigint))])
   +- ReusedExchange [c2#37, sum#54L], Exchange hashpartitioning(c2#37, 200)

What changes were proposed in this PR?
change CarbonFileIndex class to case class.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2566/

Build Success with Spark 2.4.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/858/

LGTM
good finding. This is applicable only for fileFormat ?

@ajantha-bhat it also impact carbondata table.


Resolve: You cannot cancel multiple marks at the same time in a paragraph where there are already multiple marks

… where there are already multiple marks

This change looks very suspicious. You're going to have to at least describe the problem you're trying to solve here properly.

This branch solves the problem that only one of the marks will be canceled when clicking on the corresponding mark in the middle of the field that has been underlined and bolded italics on the official website

That's still not very specific. The way I understand it is you've made some bold+italic text in the demo on the website, put the cursor in there, and click off the buttons for bold and italic in the menu bar. If I do that and then type, I get plain, unmarked text.

I just tried the operation I mentioned on the official website and indeed obtained a plain text font. However, in the Tiptap project, we can only cancel one of the marks before. We may need to wait for them to update the version before looking at it. I will merge and close this first. Thank you for your reply


Initialized Front-END

Initialized React JS and made a about page
@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: Initializing the front-end of the application with React JS and creating an about page.
📝 PR summary: This PR initializes the front-end of the application using React JS. It includes the configuration for Vite, ESLint, and the package.json file for managing dependencies. It also includes the creation of an about page with some basic styling.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 2, because the PR mainly involves setting up the front-end environment and adding a simple about page, which is straightforward to review.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The PR is well-structured and follows good practices for setting up a React application. However, it would be beneficial to separate the styling from the components to maintain a clean structure. Also, consider adding tests to ensure the components render correctly.
 🤖 Code feedback:relevant fileclient/frontEnd/src/App.csssuggestion
Consider using CSS modules or styled-components for styling to ensure that styles are scoped to the components they are used in and to avoid potential naming conflicts. [medium]
relevant line@import url('https://fonts.googleapis.com/css2?family=Bebas+Neue&display=swap');relevant fileclient/frontEnd/src/App.jsxsuggestion
It's a good practice to separate the logic and presentation in your components. Consider creating a separate component for the About section. [medium]
relevant line

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Review

 ⏱ Estimated effort to review [1-5]
2, because the PR primarily involves the initialization of a React project with Vite, including basic configuration for ESLint, package.json, and a simple About page. The changes are straightforward and mostly involve configuration and setup, which are generally easier to review than complex logic changes.

 🧪 Relevant tests
No

 🔍 Possible issues
Possible Bug: The target="_blank" attribute in App.jsx can be a security risk without rel="noopener noreferrer". This can expose the application to potential window object attacks from the linked domain.

 🔒 Security concerns
- Sensitive information exposure: Ensure that no sensitive information (e.g., API keys, secrets) is hardcoded in the application's codebase, especially in configuration files like vite.config.js and .eslintrc.cjs.

 Code feedback:
relevant fileclient/frontEnd/src/App.jsx
suggestion

Add rel="noopener noreferrer" to the anchor tag to mitigate potential security risks associated with target="_blank". This is important to prevent the newly opened page from accessing the window object of the original page. [important]

relevant lineProject Details
relevant fileclient/frontEnd/src/App.css
suggestion

Consider using CSS variables for colors and fonts to improve maintainability and readability of the CSS code. This allows for easier theme management and updates. [medium]

relevant linebackground-color: blue;
relevant fileclient/frontEnd/package.json
suggestion

Lock dependency versions by removing the caret (^) symbol to ensure consistent builds and avoid potential issues with automatic updates to newer versions. This can help in reducing bugs due to unexpected changes in dependencies. [medium]

relevant line"react": "^18.2.0",
relevant fileclient/frontEnd/src/App.jsx
suggestion

Extract the About section into a separate component to improve modularity and readability of the App.jsx. This approach enhances the maintainability of the code by separating concerns. [medium]

relevant line

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

Persistent review updated to latest commit https://github.com/kalviumcommunity/S51_ForgeSavant/commit/c2a9f07fde856f7c03f8b83d913fc6d3bccea17e


How to use “email report”?

The document for email report is too simple so that I can not follow the steps.

The documentation need more Details. I can't follow the steps.

the documentation is the toughest on superset in general. we should all make an effort (aka pull requests) to improve it. I will do that for the email reporting soon.

the documentation is the toughest on superset in general. we should all make an effort (aka pull requests) to improve it. I will do that for the email reporting soon.

I am facing issues to send an email from superset. Config part is done SMTP configured but still, I am not able send an email


Fixed compatibility with newer numpy interfaces, docs update, and clarified environment setup via Docker

Summary
Changes

Integrated fixes by @manmay-nakhashi which include support for newer librosa. This is from PR https://github.com/haoheliu/voicefixer/pull/56 which is not merged to main yet.
Fixed compatibility with newer NumPy interfaces, as nn.utils.weight_norm is now nn.utils.parametrizations.weight_norm.
Added ability to initialise weights only - useful to cache the setup without processing any files, via a new argument switch --weight_prepare.
Added Dockerfile that allows a clear easy replicable way of running the tool with exact environment setup.
Docs fix: Clarified what the run modes mean.
Docs fix: Removed hardcoded references to version 0.1.2 as these are not relevant from a docs perspective and by default latest should be used which is the default behaviour when version is not specified
Docs fix: Moved Changelog into a separate CHANGELOG.md file.

Related PRs

https://github.com/haoheliu/voicefixer/pull/56

fyi @manmay-nakhashi and @haoheliu


(maint) Remove module related content

Since we're now transition to strings as a RubyGem only, remove the
module related content from the repository.

I'm guessing that including the puppet-strings-0.4.0.gem file in this commit was unintentional?

@kylog Whoops, you're totally right. I git added too ambitiously, let me remove that.

Updated! 👍


usb: dfu: convert z_timeout_end_calc to sys_clock_timeout_end_calc

The z_timeout_end_calc function was replaced by
sys_clock_timeout_end_calc in #33302. A reference to the old function
snuck into master through #30015.
Signed-off-by: Trond Einar Snekvik<EMAIL_ADDRESS>

cc @jmgao

Whoops. LGTM.

Merging since @jfischer-no is currently on holiday.


No warning where sidewalk crosses service road without node

Description
I drew a new sidewalk and it crosses a service road, but no warning was generated to suggest I should connect them with a node
Screenshots
No response
Version
2.2.5
What browser are you seeing the problem on? What version are you running?
Chrome v122.0
The OS you're using
win
Steps to reproduce
Draw a new sidewalk on the map that crosses highway=service then check warnings
The browser URL at the time you encountered the bug
https://rapideditor.org/edit?#background=Mapbox&datasets=fbRoads,msBuildings&disable_features=buildings,boundaries,points&gpx=https://mwai-tasking-manager-production-api.mapwith.ai/api/v2/projects/166/tasks/queries/gpx/%3Ftasks%3D10&id=w1262951059&map=20.68/34.07665/-118.25879
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36

Hey @cbeddow  I just took a look..
That sidewalk is tagged with layer=-1 , that's why it doesn't generate a warning.


translation issue in mlp.md

Job d2l-zh/PR-762/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-762/

Job d2l-zh/PR-762/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-762/


Specifying Version Number in nodejs_npm_global_packages

I tried a few variations but I can't seem to get this to work:
nodejs_npm_global_packages:
  - { name: phantomjs, version: 1.9.8 }

I'm sure I just have something funky in my syntax here. I've also tried running vagrant provision and vagrant reload after each change.
What's the correct syntax for specifying specific versions or ranges in the config.yml file like you would installing via the command line
npm install -g<EMAIL_ADDRESS><2.0"
This would probably be a good addition to the documentation.

Nevermind... I think I asked this before my final vagrant provision finished working
This seems to have done the trick:
nodejs_npm_global_packages:
  - { name: phantomjs, version: 1.9.8 }

That was it - glad you could get it going!


New web example

The old example in moor/example_web is outdated, it doesn't even compile. I've deleted it on develop for now, but there should be a new one.

https://github.com/rodydavis/moor_shared

Thanks! For now I'll link to your repo from the web documentation.


feat: logout if there's no activities for a long time

fix: https://github.com/casdoor/casdoor/issues/3230

@dacongda plz review


Kiosk mode: SyntaxWarning: invalid escape sequence '?'

Describe the bug
Yesterday, I integrated the FusionSolar kiosk mode.
Data is displayed in Home Assistant, but the log-file shows the following warning:
WARNING (ImportExecutor_0) [py.warnings] /config/custom_components/fusion_solar/fusion_solar/kiosk/kiosk.py:16:
SyntaxWarning: invalid escape sequence '?'
id = re.search("?kk=(.*)", self.url).group(1)
** Debug information **
Answer the questions below before submitting a new issue.

Are you using the latest version of Home Assistant? -> yes
Are you using the latest version of this integration? -> Yes
Have you looked into the closed issues and did not find a similar issue. -> Yes
Are you using Kiosk or Northbound / OpenAPI mode? -> Kiosk mode
If you are using Kiosk mode. Have you checked that the url is still valid? See I am using the kiosk mode, but the data is not updating
If you ar using Northbound / OpenAPI mode. Check if your credentials are still valid. See How can I verify my Northbound API / OpenAPI credentials?
Have you checked the logs for any info?

To Reproduce
Steps to reproduce the behavior:
Restart Home Assistant, and the same message pops up.
Expected behavior
No warning
Screenshots
This error originated from a custom integration.
Logger: py.warnings
Source: custom_components/fusion_solar/sensor.py:21
integration: Fusion Solar (documentation, issues)
First occurred: 11:59:46 (1 occurrences)
Last logged: 11:59:46
/config/custom_components/fusion_solar/fusion_solar/kiosk/kiosk.py:16: SyntaxWarning: invalid escape sequence '?' id = re.search("?kk=(.*)", self.url).group(1)

I don't see the message anymore after updating the core from 4.1 to 4.2. So seem to be OK


Feature: Show permissions as a separate tab

Description

Move permissions code into a separate for better readability and maintainability.
Separate Permissions node from Encryption so that it would be displayed in the frontend as a separate tab.
Use more user friendly permission labels such as replacing canModify with Modifying and values such as Allowed and Not Allowed instead of true, false.
Show permissions regardless of the encryption state.

Pros of this implementation:

Less effort displaying the data as it's already ready for display.
Frontend doesn't need to know much about the business nor the expected values for the data, just more focus on how the data is displayed instead.

Cons of this implementation:

Permission labels are different from before.
Permission labels are not conforming to snake case nor camel case, each word separated by a space instead; requiring users downloading the data as Json to input it into their applications to adapt to these changes and maybe even adding extra logic to map the permission labels to their fields (but it's more user friendly).

Closes #2387
Encryption present case:

No Encryption present case:

Checklist

[x] I have read the Contribution Guidelines
[x] I have performed a self-review of my own code
[ ] I have attached images of the change if it is UI based
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
[ ] My changes generate no new warnings
[ ] I have read the section Add New Translation Tags (for new translation tags only)

I suggest that we separate words in the frontend (regardless of how it's implemented in backend) so that it would be more user friendly, example: EncryptionAlgorithm -> Encryption Algorithm and so on.

I believe the intent was to have a translation layer enhancement ontop to map those names to the translated message keys in the future
Hence no spaces etc

I think this was missed work somewhere down the line and we forgot

I am happy to merge this PR tho

Ah, understandable. I can still bring back the old labels/keys, it shouldn't take much time

That can get picked up in new work whenever it gets done, for now readability Is best :)


Vishalk91 4 about issue

Related Issue

Information about the related issue

Closes: #209
Describe the changes you've made
I have created an About.tsx file in the Pages section in that I have added hero image and written about the purpose of Vibey,
Then I've add a know region where I have added three cards according to the devices, their display may change from 3 to 2 to 1, thosse contain some text about event, cfp and hackathon and a know more button through which they can access the direct links to these pages
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[  ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update.
[ ] This change requires a documentation update

How Has This Been Tested?
 I've tested all these changes locally through multiple browsers and across all devices from mobile to laptop so as to make sure the code does not break out
Checklist

[  ] My code follows the guidelines of this project.
[  ] I have performed a self-review of my own code.
[  ] I have commented on my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[  ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[  ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)
Screenshot of About Us Section
Dark Mode Laptop View

Light Mode Mobile View

Code of Conduct

[   ] I agree to follow this project's Code of Conduct

@Deepu178 @J-Harsh could you please review this pull request and if possilbe the PR #233 also which I've updated

@Vishalk91-4  You need to fix this
Warning: Run autofix to sort these imports!  simple-import-sort/imports

@Deepu178 just add the footer.tsx file from issue #233 and check this, if it doesn't impress then I can also add the our team section if you want
Please review it

@Deepu178 I have made changes, according to what you said in the footer, could you please check and merge it

@Deepu178, could you please review these two PRs, #243  and #233, merge them

@Deepu178 Can you tell what are the other content you want in here

@Deepu178 , i've made the neccesary changes, it's most probably done now, could you please review and merge it

@Vishalk91-4 You are doing amazing in making efforts but sometimes it's not the way a project look for. Please join the discord channel and ping the maintainers for one to one meeting about this issue.

@Deepu178 okay, I've joined the discord and will be getting in touch with them, can you merge this one, where I've aligned the things #233

@Vishalk91-4 Any update on this pr?

@Deepu178 Actually my exams are going on and they will end at 22nd, so I have not updated the page, the design is the same as it was, when you preview it

@Deepu178 , could you make this a level 2/3  since a new page was added, level 1 is for bugs
And according to GSSoC23 guidelines it should be 3 not 1


Tour Company Website[GSSOC'23]

Title and Issue number

Tour Company Website
Issue no. #3584
Please take a review & merge it
Video
https://github.com/pranjay-poddar/Dev-Geeks/assets/114172928/dc67c7a6-de46-41c2-844e-9acadf96b0cd
Close #3584

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

@MohitGupta121 @TusharKesarwani @pranjay-poddar please take a review & merge it under GSSOC

@MohitGupta121 I have removed the img file & already have used the img links in HTML from somewhere else. So can you please review & merge it?


execution of line 63 produces error

TypeError                                 Traceback (most recent call last)
 in
59
60 # Creating train and validation data
---> 61 split_data = train_test_split(featureSet, labels, val_ratio=.2)
62 x_train, x_val, y_train, y_val = (np.array(item) for item in split_data)
63
/opt/conda/lib/python3.7/site-packages/sklearn/model_selection/_split.py in train_test_split(*arrays, **options)
2123
2124     if options:
-> 2125         raise TypeError("Invalid parameters passed: %s" % str(options))
2126
2127     arrays = indexable(*arrays)
TypeError: Invalid parameters passed: {'val_ratio': 0.2}
Has something to do with line 63, and change to train_test_split function:
Creating train and validation data
split_data = train_test_split(featureSet, labels, val_ratio=.2)
x_train, x_val, y_train, y_val = (np.array(item) for item in split_data)

Thanks for pointing this out! I've fixed this in a commit.
Closing this issue now. Feel free to open it if need be.

Thanks for pointing this out! I've fixed this in a commit.
Closing this issue now. Feel free to open it if need be.


feat:add the openai support and remove async in the most functions.

Add the openai support and remove async in the most functions.

@bjwswang
The changes is as the following:

add BaseQAProvider
remove opt
use isort to sort the import


Migrate asynctest to stdlib's AsyncMock

Asynctest doesn't work with python 3.8 and above.
Asynctest upstream is aware of this breakage and recommends using the built-in AsyncMock instead. See also https://github.com/Martiusweb/asynctest/issues/144 and https://github.com/Martiusweb/asynctest/issues/126 .

Thank you for reporting! 😊 I've tried reproducing the errors described in the issues you linked, yet to no avail - all tests succeed on Python 3.8.5, Databay 0.1.5. I can carry out the migration to AsyncMock right away, but I'd first like to know that I'm fixing whatever issues happen using asynctest on Python 3.8.
I'm assuming you tried running the tests and they failed for you? It would be great to know which tests failed and in what way.
Could you please provide more details? Use the following template if you may:

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Environment
Databay version:
Python version:
OS:
Additional context
Add any other context about the problem here.
Suggest a Fix
If you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit).

Thank you!

On a Fedora system (local build for the RPM package):
[...]
platform linux -- Python 3.8.5, pytest-4.6.11, py-1.8.2, pluggy-0.13.1 -- /usr/bin/python3
[...]
test/test/unit/outlets/test_print_outlet.py::TestPrintOutlet::test_push PASSED                                                                                [ 98%]
test/test/unit/outlets/test_print_outlet.py::TestPrintOutlet::test_push_only_payload PASSED                                                                                [ 99%]
test/test/unit/outlets/test_print_outlet.py::TestPrintOutlet::test_push_skip_update PASSED                                                                                [100%]

============================================================================================================= FAILURES =============================================================================================================
______________________________________________________________________________________________ TestConfig.test_event_loop_policy_3_7 _______________________________________________________________________________________________

self = <test.unit.test_config.TestConfig testMethod=test_event_loop_policy_3_7>, version_info = <MagicMock name='version_info' id='140633192203696'>

    @patch('sys.platform', 'win32')
    @patch('sys.version_info')
    def test_event_loop_policy_3_7(self, version_info):
        version_info.__getitem__.side_effect = lambda x: [3, 7][x]

        # fake a manual 3.8 default setup
>       asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy())
E       AttributeError: module 'asyncio' has no attribute 'WindowsProactorEventLoopPolicy'

test/test/unit/test_config.py:36: AttributeError
______________________________________________________________________________________________ TestConfig.test_event_loop_policy_3_8 _______________________________________________________________________________________________

self = <test.unit.test_config.TestConfig testMethod=test_event_loop_policy_3_8>, version_info = <MagicMock name='version_info' id='140633192146640'>

    @patch('sys.platform', 'win32')
    @patch('sys.version_info')
    def test_event_loop_policy_3_8(self, version_info):
        version_info.__getitem__.side_effect = lambda x: [3, 8][x]

        # fake a 3.8 default setup
>       asyncio.set_event_loop_policy(asyncio.WindowsProactorEventLoopPolicy())
E       AttributeError: module 'asyncio' has no attribute 'WindowsProactorEventLoopPolicy'

test/test/unit/test_config.py:24: AttributeError
========================================================================================================= warnings summary =========================================================================================================
/usr/lib/python3.8/site-packages/asynctest/mock.py:434
  /usr/lib/python3.8/site-packages/asynctest/mock.py:434: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
    def wait(self, skip=0):

/usr/lib/python3.8/site-packages/asynctest/mock.py:448

Thanks @fabaff for this report. This one in particular seems to be unrelated from the asynctest issue and is an issue of its own, as instead it is caused by running windows-specific test on a non-windows platform. If you had any error logs from the asynctest tests under Python 3.8 we'd appreciate these too.

We just released version 0.2.0 that should address this issue. Please reopen if the problems persist. Thanks for submitting it 👋


Strand cross-correlation analysis before, or after de-duplication?

According to this publication:

"The evaluation of ChIP quality following duplicate removal may therefore underestimate the extent of ChIP enrichment relative to background..." ... "We recommend the assessment of RSC and NSC prior to blacklisting or duplicate removal..."

Thus, perhaps, steps phantompeakqualtools and calculateNSCRSC could be performed on the non-deduplicated data, instead of the deduplicated?

Thanks @sifakise! Any thoughts on this @chuan-wang / @orzechoj?

Thanks for this info @sifakise! I will look into this.


[SPARK-8567] [SQL] Increase the timeout of o.a.s.sql.hive.HiveSparkSubmitSuite to 5 minutes.

https://issues.apache.org/jira/browse/SPARK-8567
Looks like "SPARK-8368: includes jars passed in through --jars" is pretty flaky now. Based on some history runs, the time spent on a successful run may be from 1.5 minutes to almost 3 minutes. Let's try to increase the timeout and see if we can fix this test.
https://amplab.cs.berkeley.edu/jenkins/job/Spark-1.5-SBT/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.0,label=spark-test/385/testReport/junit/org.apache.spark.sql.hive/HiveSparkSubmitSuite/SPARK_8368__includes_jars_passed_in_through___jars/history/?start=25

Merged build triggered.

Merged build started.

LGTM pending Jenkins

test this please

test this please

Merged build triggered.

Merged build started.

Test build #42767 has started for   PR 8850 at commit d9a2c17.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42766/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Merged build triggered.

Merged build started.

Test build #42771 has started for   PR 8850 at commit d9a2c17.

Test build #42767 has finished for   PR 8850 at commit d9a2c17.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42767/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #42786 has started for   PR 8850 at commit d9a2c17.

Test build #42771 has finished for   PR 8850 at commit d9a2c17.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class CountVectorizer(JavaEstimator, HasInputCol, HasOutputCol):
class CountVectorizerModel(JavaModel):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42771/
Test PASSed.

Test build #42786 has finished for   PR 8850 at commit d9a2c17.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42786/
Test PASSed.

Merging into master 1.5.


Fix suggestions for '.' after code mode has exited.

Fixes #2733

Add with_trivia parameter to LinkedNode::prev_sibling
Use this parameter in compete_field_accesses to disallow trivia nodes before '.' during an inline expression in markup mode.

Questions:

Should such a parameter also be added to LinkedNode::next_sibling for consistency?
Should a separate function (for example LinedNode::prev_sibling_with_trivia) be used instead, since LinkedNode::prev_sibling is mostly called with with_trivia: false

We could also, in the place where we need it, check that the end offset of the previous node and the start offset of the following node are equal. That might be simpler.
If we decide that we don't like that, I think I'd prefer an additional method over the parameter.
Could you please add a unit test as well?

Thanks!


Missing Translations!

The Crowdin Project doesn't have these strings (compare with this: https://github.com/TerraformersMC/ModMenu/blob/1.20/src/main/resources/assets/modmenu/lang/en_us.json):
"option.modmenu.quick_configure", "option.modmenu.quick_configure.true", "option.modmenu.quick_configure.false".
So they should appear in that project too.

The crowdin is sadly a mess, I really don't like nor really understand how it works. I may have to end up shutting it down and just accept translations via PRs again since I don't really have time to figure it out

The crowdin is sadly a mess, I really don't like nor really understand how it works. I may have to end up shutting it down and just accept translations via PRs again since I don't really have time to figure it out

Then should I make ASAP PR with tranlsation?

sure, if you'd like!

sure, if you'd like!

Then I need more explanation what "Quick Configure" does.

It allows double clicking on a mod to open its config screen without having to hit the config button on the right hand side.

Ok, then check this -> #634


Don't emit an empty player status.

This can be potentially confusing for client applications and crashes the example code.
Sometimes, when streaming to a warm device, I'll see this MEDIA_STATUS message come down:
{ type: 'MEDIA_STATUS', status: [], requestId: 0 }

media.js then tries to pull out data.status[0] and emits a 'status' event with an undefined payload.
This small patch simply holds off on emitting until there's actually data to emit, so users don't have to nullcheck on 'status' events.

Awesome :) thanks


Update Python and Django version metadata

Correct setup.py and README.rst to match the supported versions.

Thanks for the PR. What about also setting Development Status to Production/Stable, as suggested by Uri (https://github.com/jazzband/sorl-thumbnail/issues/683#issuecomment-1036183156)

Sure, will do!


[Bug]: Operator Keeps Recreating Pods when Deleting sources in projectedVolumeTemplate

Is there an existing issue already for this bug?

[X] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[X] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[X] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
<EMAIL_ADDRESS>Version
1.21.1
What version of Kubernetes are you using?
1.26
What is your Kubernetes environment?
Self-managed: kind (evaluation)
How did you install the operator?
YAML manifest
What happened?
Operator keeps recreating postgres pods, causing the Postgres cluster to run in a permanent erroneous, misconfigured state. It happens when we try to delete the sources in the projectedVolumeTemplate.
The operator keeps recreating pods with the log message "Pod rollout required" and "Recreating instance pod". And the reason from the log message is
"Restarting instance test-cluster-3, because: projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"

Apparently the operator is having a bug in the checkProjectedVolumeIsOutdated function, where is DeepEqual function is not working properly.
Cluster resource
First deploy the Postgres Cluster with the following CR, with an example projected volume from ConfigMap.

apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  name: test-cluster
spec:
  description: "Example of cluster"
  imageName: ghcr.io/cloudnative-pg/postgresql:16.1
  instances: 3
  startDelay: 300
  stopDelay: 300
  primaryUpdateStrategy: unsupervised

  postgresql:
    parameters:
      shared_buffers: 256MB
      pg_stat_statements.max: '10000'
      pg_stat_statements.track: all
      auto_explain.log_min_duration: '10s'
    pg_hba:
      - host all all <IP_ADDRESS>/16 md5

  bootstrap:
    initdb:
      database: app
      owner: app
      secret:
        name: cluster-example-app-user
    # Alternative bootstrap method: start from a backup
    #recovery:
    #  backup:
    #    name: backup-example

  enableSuperuserAccess: true
  superuserSecret:
    name: cluster-example-superuser

  storage:
    storageClass: standard
    size: 1Gi

  projectedVolumeTemplate:
    sources:
      - configMap:
          name: sample-configmap
          items:
            - key: key1
              path: config/key1
            - key: key2
              path: config/key2

  resources:
    requests:
      memory: "512Mi"
      cpu: "1"
    limits:
      memory: "1Gi"
      cpu: "2"

  affinity:
    enablePodAntiAffinity: true
    topologyKey: failure-domain.beta.kubernetes.io/zone

  nodeMaintenanceWindow:
    inProgress: false
    reusePVC: false
---
apiVersion: v1
data:
  key1: value1
  key2: value2
  key3: value3
kind: ConfigMap
metadata:
  name: sample-configmap

Then, delete the sources from the projectedVolumeTemplate, by setting it to `[]`. By applying the following CR:
```yaml
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  name: test-cluster
spec:
  description: "Example of cluster"
  imageName: ghcr.io/cloudnative-pg/postgresql:16.1
  instances: 3
  startDelay: 300
  stopDelay: 300
  primaryUpdateStrategy: unsupervised

  postgresql:
    parameters:
      shared_buffers: 256MB
      pg_stat_statements.max: '10000'
      pg_stat_statements.track: all
      auto_explain.log_min_duration: '10s'
    pg_hba:
      - host all all <IP_ADDRESS>/16 md5

  bootstrap:
    initdb:
      database: app
      owner: app
      secret:
        name: cluster-example-app-user
    # Alternative bootstrap method: start from a backup
    #recovery:
    #  backup:
    #    name: backup-example

  enableSuperuserAccess: true
  superuserSecret:
    name: cluster-example-superuser

  storage:
    storageClass: standard
    size: 1Gi

  projectedVolumeTemplate:
    sources: []

  resources:
    requests:
      memory: "512Mi"
      cpu: "1"
    limits:
      memory: "1Gi"
      cpu: "2"

  affinity:
    enablePodAntiAffinity: true
    topologyKey: failure-domain.beta.kubernetes.io/zone

  nodeMaintenanceWindow:
    inProgress: false
    reusePVC: false
---
apiVersion: v1
data:
  key1: value1
  key2: value2
  key3: value3
kind: ConfigMap
metadata:
  name: sample-configmap

### Relevant log output

```shell
{"level":"info","ts":"2023-12-20T23:55:48Z","msg":"Setting replica label","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"52cd1910-466d-4615-a76d-ede2b70bda28","uuid":"4c7ed210-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3"}
{"level":"info","ts":"2023-12-20T23:55:57Z","msg":"Pod rollout required","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"9a116368-fdbf-4d0d-95e4-37103029a72c","uuid":"51dde089-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","reason":"projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:55:57Z","msg":"Recreating instance pod","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"9a116368-fdbf-4d0d-95e4-37103029a72c","uuid":"51dde089-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","to":"ghcr.io/cloudnative-pg/postgresql:16.1","reason":"Restarting instance test-cluster-3, because: projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:56:01Z","msg":"Creating new Pod to reattach a PVC","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"6d07ca8c-ae3c-4ea0-9a37-c58186573f63","uuid":"5440e177-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","pvc":"test-cluster-3"}
{"level":"info","ts":"2023-12-20T23:56:03Z","msg":"Setting replica label","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"4069a145-058d-4016-a586-c3e3340d779d","uuid":"5572c5a2-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3"}
{"level":"info","ts":"2023-12-20T23:56:12Z","msg":"Pod rollout required","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"a7e2b8f9-0629-44be-aaec-ccfdb45d661f","uuid":"5ad221cb-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","reason":"projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:56:12Z","msg":"Recreating instance pod","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"a7e2b8f9-0629-44be-aaec-ccfdb45d661f","uuid":"5ad221cb-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","to":"ghcr.io/cloudnative-pg/postgresql:16.1","reason":"Restarting instance test-cluster-3, because: projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:56:16Z","msg":"Creating new Pod to reattach a PVC","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"ce4b29f9-1e7e-4db8-ae8f-1f31483a696a","uuid":"5d34d987-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","pvc":"test-cluster-3"}
{"level":"info","ts":"2023-12-20T23:56:18Z","msg":"Setting replica label","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"fef11604-3250-4801-88f6-71022c94ce6b","uuid":"5e66cdf2-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3"}
{"level":"info","ts":"2023-12-20T23:56:27Z","msg":"Pod rollout required","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"5053968e-143a-4a7a-ace9-d119b7074243","uuid":"63c60507-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","reason":"projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:56:27Z","msg":"Recreating instance pod","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"5053968e-143a-4a7a-ace9-d119b7074243","uuid":"63c60507-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","to":"ghcr.io/cloudnative-pg/postgresql:16.1","reason":"Restarting instance test-cluster-3, because: projected volume configuration changed, old: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}, new: &ProjectedVolumeSource{Sources:[]VolumeProjection{},DefaultMode:*420,}"}
{"level":"info","ts":"2023-12-20T23:56:31Z","msg":"Creating new Pod to reattach a PVC","controller":"cluster","controllerGroup":"postgresql.cnpg.io","controllerKind":"Cluster","Cluster":{"name":"test-cluster","namespace":"cnpg-system"},"namespace":"cnpg-system","name":"test-cluster","reconcileID":"b331d496-7a65-438a-9fc8-d2610c11b070","uuid":"6628d104-9f93-11ee-8a58-2e2e6e0be252","pod":"test-cluster-3","pvc":"test-cluster-3"}

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I can reproduce this issue


[Chore] Updating security report mailing list

Signed-off-by: leecalcote<EMAIL_ADDRESS>Description
A new mailing list address for vuln reports.
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit a460b7454e2c638c66fd5bc6bc8998663deea9f0 at: https://618c52ffed5172529c0df39c--meshery-docs-preview.netlify.app

Codecov Report

Merging #4600 (a460b74) into master (159cb04) will decrease coverage by 7.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4600      +/-   ##
==========================================
- Coverage   33.05%   25.93%   -7.12%
==========================================
  Files          60       60
  Lines        5086     5086
==========================================
- Hits         1681     1319     -362
- Misses       2964     3438     +474
+ Partials      441      329     -112

Flag
Coverage Δ

gointegrationtests
?

unittests
25.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/start.go
1.11% <0.00%> (-58.52%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.50% <0.00%> (-47.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-47.44%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.86% <0.00%> (-27.59%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.29% <0.00%> (-20.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56098f...a460b74. Read the comment docs.

Looks good to me @leecalcote . One question though, are "normal product bugs" things like CVE's in Meshery's dependencies?

Thanks. @s1ntaxe770r, you might have to rephrase this question....


esm: infer types if an index.d.ts exists next to main

I opened an issue with @google-cloud/vision which does not specify the types field but includes type definitions next to the main entry point. Since tsc module resolution handles this implicitly, perhaps esm.sh can do this too.

lgmt, thanks @marcushultman