Support for Azure container Registry

Is there support for ACR, as i see there is support for AWS S3 but for OCI based registries, the option is not provided.
Can you guide me where the changes should occur, just like its done for S3

Haven't used ACR but if it supports OCI it will work, this is the default protocol if you don't specify any other options
https://github.com/nflaig/semantic-release-helm/blob/ae5ed181b59933e292b9eb36a03ed3a1d6540869/lib/publish.js#L81-L83
Based on their docs seems like it

Yes, i saw that it already supports oci and will try that. thank you!
Will update here if it worked.. or will create a PR if necessary.

seems like helm could not login to acr registry. i get the following error.
It works when i execute helm registry login directly on the ci file but not when using the semantic release
[9:43:11 AM] [semantic-release] › ✖  An error occurred while running semantic-release: Error: Command failed with exit code 1: helm registry login --username robot$xxx-platform+helm-ci --password-stdin oci: time="2023-06-26T09:43:11Z" level=info msg="Error logging in to endpoint, trying next endpoint" error="Get \"https://oci/v2/\": dial tcp: lookup oci on xx.xx.0.12: server misbehaving" Error: Get "https://oci/v2/": dial tcp: lookup oci on xx.xx.0.12:53: server misbehaving
Should'nt this code here split the oci from the  repo uri that starts with oci://acrregistry.azurecr.io/repo/
https://github.com/nflaig/semantic-release-helm/blob/ae5ed181b59933e292b9eb36a03ed3a1d6540869/lib/verifyConditions.js#L14C4-L20

this is the url im setting oci://acr001.azurecr.io/chart-helm/

This would be the resulting login url
> "oci://acr001.azurecr.io/chart-helm/".replace("oci://", "").split('/')[0]
'acr001.azurecr.io'

Not sure where the https:// prefix is coming from, this is not added by the module.

ya.. im not sure if its being done in the ci cd repo in gitlab.. somewhere i think its appending the https because its by default always registers with harbor,, maybe i need to look deeper

Are you using the latest versio (v2.6.0) of the module?
There was an issue with oci prefix but that was fixed a while ago

https://github.com/nflaig/semantic-release-helm/pull/14

Also helm is known to introduce breaking changes in minor releases, it hard to keep this module compatible. My recommendation is to only upgrade to a newer helm version if it is really required.

I'm not sure, I have to check where this release version is set, after the update i created the new release version (v2.10.0) which should include this change you mentioned..

I'm not sure, I have to check where this release version is set

package.json

so, to update the lock file, what should be done ? im new to npm here.

just update the version in package.json and run npm install

Yes, updated that.. but still get the same error that its trying to use the https://.. im not sure where this is coming from.
2:36:39 PM] [semantic-release] › ✖  An error occurred while running semantic-release: Error: Command failed with exit code 1: helm registry login --username robot$hypertrust-platform+helm-ci --password-stdin acr001.azurecr.io Error: Get "https://acr001.azurecr.io/v2/": unauthorized: aad access token with sp failed client id must be guid

not sure where this is coming from

Likely helm doing that, as mentioned above, they introduce breaking changes like this even in minor versions. This module is mostly tested with 3.10 and below, can't tell if it works with high versions without any changes.

the issue is fixed. you are correct, gitlab was passing the registry creds from the global env variables and the precedence was not working.. exposting them worked. Thank You!


Type-Erased Node References

What's Changed

Added AnyNodeRef for type-erased node references
Introduced ToAnyNodeRef trait for converting between typed and untyped node refs
Implemented conversion for HTML, SVG, and Math node types
Also reorganized the workspace & shared versioning

Why
Enables more flexible handling of DOM node references across different element types. Specifically It's needed for updating this implementation https://github.com/RustForWeb/radix/issues/26 for 0.7.X
Examples
let div_ref: NodeRef<html::Div> = NodeRef::new();
let any_ref = div_ref.to_any(); // Type-erased conversion

Working towards:
pub fn compose_refs(refs: impl IntoIterator<Item = AnyNodeRef>) -> AnyNodeRef {
    let composed_ref = AnyNodeRef::new();
    let refs: Vec<_> = refs.into_iter().collect();
    // ...
}

My Checklist

[x] Added new functionality
[x] Updated tests
[x] Ran all tests
[x] Maintained existing behavior

Would you like me to modify this further @DanielleHuisman?

I haven't had much time during the holidays to review this. Do you still want me to look at it?


PEP 541: transfer ownership of Flask-CRUD

Module: https://pypi.org/project/Flask-Crud
Last release: 2014
Project description: UNKNOWN
I have opened a ticket on GitHub asking if I can take it over and sent an email to the author at<EMAIL_ADDRESS>Thanks!

Issue: https://github.com/plumdog/flask_crud/issues/2

I received no word back :/

Still no response. Possible to take this over?


Update PowerShell to install in Sandbox

The current script does not work, there is a typo and missing dependency as well as being an older version. I have fixed these, tested with Windows 10 and 11 but tried to keep the script simple and like the original.

@KevinLaMS appreciate you are probably busy, but please could you let me know if there is a process I should follow to get this reviewed, or if I have missed something. Thanks

@glawrence, thank you for this. I came up with a different solution using the Microsoft Store URI for Microsoft.UI.Xaml.2.7, but found the Invoke-WebRequest inconsistently resulted in an "Access Denied" error.  Your solution works much better.
The only thing I would change is to either make the dot-sourcing of the files consistent, which would keep it simpler, or, since these commands may be put into a script residing on a read-only mapped folder inside the Windows Sandbox, put the downloaded files into the user temporary folder.  This would change the commands to:
$ProgressPreference='SilentlyContinue'
Invoke-WebRequest -Uri https://github.com/microsoft/winget-cli/releases/download/v1.4.10173/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle -OutFile "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle"
Invoke-WebRequest -Uri https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx -OutFile "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Invoke-WebRequest -Uri https://www.nuget.org/api/v2/package/Microsoft.UI.Xaml/2.7.3 -OutFile "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip"
Expand-Archive -Path "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3.zip" -DestinationPath "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3" -Force
Add-AppxPackage "$($Env:TEMP)\Microsoft.VCLibs.x64.14.00.Desktop.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.UI.Xaml.2.7.3\tools\AppX\x64\Release\Microsoft.UI.Xaml.2.7.appx"
Add-AppxPackage "$($Env:TEMP)\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle"

I also found that I could install the latest version of winget automatically by changing the URI for it to 'https://github.com/microsoft/winget-cli/releases/latest/download/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle', but any future changes in dependencies in newer versions would require the article to be updated again.

Thank you for this contribution @glawrence. Apologies for the delay. This issue was fixed in https://github.com/MicrosoftDocs/windows-dev-docs/commit/ca90ce0471458f85af6dc789200b263affcfd8ec

@mattwojo It looks like the commit you refer to does not address the issue of the missing dependency on Microsoft.UI.Xaml. It only fixes the missing period in the filename. I think the fix from this PR is still needed.

Oh! Thanks @PDeets. I'll reopen.

I have taken on board your suggestion @VShrubowich
@mattwojo and @PDeets I believe this is all good to go, but happy to be corrected on that

@mattwojo @PDeets @KevinLaMS - Could you review this PR?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sorry @ShannonLeavitt @mattwojo @PDeets and @KevinLaMS I think this PR has a dodgy commit from me as well as a validation warning, so I have rerolled it with #4332 so I will close this, but hopefully we can now switch to my new one


I had some problems training stpls3d .

Hello Author！
Your research is excellent and I benefit a lot from it.I configured the training environment in accordance with "read.md", installed the required packages in accordance with "requirements.txt", put stpls3d in /data/raw/stpls3d folder and divided train, validation and test（15:5:5）.
After I run stpls3d_preprocessing.py in Pycharm , I tried to  run main_instance_segmentation.py in Pycharm Terminal with following commands (copy from stpls3d_val.sh):
python main_instance_segmentation.py general.experiment_name="validation_query_${CURR_QUERY}topk${CURR_TOPK}dbscan${CURR_DBSCAN}size${CURR_SIZE}" general.project_name="stpls3d_eval" data/datasets=stpls3d general.num_targets=15 data.num_labels=15 data.voxel_size=0.333 data.num_workers=10 data.cache_data=true data.cropping_v1=false general.reps_per_epoch=100 model.num_queries=${CURR_QUERY} general.on_crops=true model.config.backbone.target=models.Res16UNet18B general.train_mode=false general.checkpoint="checkpoints/stpls3d/stpls3d_val.ckpt" data.crop_length=${CURR_SIZE} general.eval_inner_core=50.0 general.topk_per_image=${CURR_TOPK} general.use_dbscan=true general.dbscan_eps=${CURR_DBSCAN}
The program finished running in a few seconds. I didn't see any error messages, but I didn't find any save results.
The output in pycharm's terminal is as follows:
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ export OMP_NUM_THREADS=3
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ CURR_DBSCAN=14.0
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ CURR_TOPK=750
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ CURR_QUERY=160
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ CURR_SIZE=54
(mask3d) zy@zy-cau:~/3D_Instance_Segmentation/Mask3D$ python main_instance_segmentation.py \

general.experiment_name="validation"
general.project_name="stpls3d"
data/datasets=stpls3d
general.num_targets=15
data.num_labels=15
data.voxel_size=0.333
data.num_workers=10
data.cache_data=true
data.cropping_v1=false
general.reps_per_epoch=100
model.num_queries=${CURR_QUERY}
general.on_crops=true
model.config.backbone.target=models.Res16UNet18B
data.crop_length=${CURR_SIZE}
general.eval_inner_core=50.0

wandb: Tracking run with wandb version 0.13.2
wandb: W&B syncing is set to offline in this directory.
wandb: Run wandb online or set WANDB_MODE=online to enable cloud syncing.
/home/zy/anaconda3/envs/mask3d/lib/python3.10/site-packages/pytorch_lightning/utilities/seed.py:55: UserWarning: No seed found, seed set to<PHONE_NUMBER>
rank_zero_warn(f"No seed found, seed set to {seed}")
Global seed set to<PHONE_NUMBER>
{'target': 'pytorch_lightning.loggers.WandbLogger', 'project': '${general.project_name}', 'name': '${general.experiment_name}', 'save_dir': '${general.save_dir}', 'entity': 'schult', 'resume': 'allow', 'id': '${general.experiment_name}'}
/home/zy/anaconda3/envs/mask3d/lib/python3.10/site-packages/pytorch_lightning/loggers/wandb.py:352: UserWarning: There is a wandb run already in progress and newly created instances of WandbLogger will reuse this run. If this is not desired, call wandb.finish() before instantiating WandbLogger.
rank_zero_warn(
/home/zy/anaconda3/envs/mask3d/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/accelerator_connector.py:446: LightningDeprecationWarning: Setting Trainer(gpus=1) is deprecated in v1.7 and will be removed in v2.0. Please use Trainer(accelerator='gpu', devices=1) instead.
rank_zero_deprecation(
/home/zy/anaconda3/envs/mask3d/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/callback_connector.py:57: LightningDeprecationWarning: Setting Trainer(weights_save_path=) has been deprecated in v1.6 and will be removed in v1.8. Please pass dirpath directly to the ModelCheckpoint callback
rank_zero_deprecation(
GPU available: True (cuda), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
generate data/processed/stpls3d/train_database.yaml first
wandb: Waiting for W&B process to finish... (success).
wandb:
wandb: You can sync this run to the cloud by running:
wandb: wandb sync /home/zy/3D_Instance_Segmentation/Mask3D/wandb/offline-run-20230426_200434-1lt52f5z
wandb: Find logs at: ./wandb/offline-run-20230426_200434-1lt52f5z/logs
Thank you for your help and I am looking forward to your reply.

Hi!
Thanks for your interest in our work. :)
This is the "key" line:

generate data/processed/stpls3d/train_database.yaml first

You need to process the dataset first. See here.
Best,
Jonas

I have a similar issue above, have you solved it?

Hi! :)
Thanks for your interest in our work!
we have just released a fix which most likely will solve your issue. Just pull the latest version of the project and recreate your virtual python environment following the instructions here.
Previously, the issue occurred because we did not lock the packages in the Python environment to specific versions. We now made sure that the packages in the environment remain the same.
I will close the issue now. Please feel free to reopen it again if you continue to experience issues.
Best,
Jonas


Referenced  jQuery path doesn't exist in Django 1.9+

The path admin/js/jquery.js referenced in the CMS wizard doesn't exist anymore since Django 1.9 (and Django 1.8 is officially EOL since 1st of April 2018). This leads to a 404 (or a 500 when using ManifestStaticFileStorage).
The path in Django 1.9+ is admin/js/vendor/jquery/jquery.js. But possibly including a copy of jQuery in this repo might also be a solution.

For for reporting this. I think we should still rely on django own jquery, to avoid shipping multiple copies of jquery in a single project.
Setting the path according to the detected Django version is the best fix.

Thanks @stefanw  for reporting this
Fixed by #447
It will be released in the next 0.9 release


check for incompatible version of mergo

Added unit test to catch accidental upgrade of mergo library.

/lgtm
get green

Oh, and pin the dep. that way we'll see a glide conflict.

/lgtm


test moon-ci

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Build.pm6 should probably be deleted

The problem
It's in the main directory, I'm not sure it's used.
Suggestions
Check for hidden usage and delete it if it's no longer used.

It's used in p6doc, which is spun off...

It's a part of the install process with zef. see #3206

Yep, but still, it's only used in p6doc, which is now in another repo. So probably should be removed.

I need a pointer to how the install of docs from this repo is supposed to work with the now-separated p6doc tool, so I can figure out what's left for installation in this repo. My expectation was that we would still be installing these docs so that p6doc could find them, and there are other tickets in this repo for fixing the install process in general.

The correct issue is: "Do we want to install the documentation" from this repo;
If yes, we'll update the Build.pm to address it. If not, we'll update it to error out if someone tries to do an install.
There are other issues tracking that question.


Proposal: execute flow for a date range (backfilling)

I propose Azkaban to support executing a flow for an arbitrary date range. This would execute a given flow multiple times so that it gets a different "base date" on each execution.
Why? Many times there's a need to reprocess some "history", ie. execute a flow in a sequence for a set of dates. As far as I know, Azkaban doesn't currently provide any built-in way to support that.
Backfill command of Airflow
Airflow (another workflow scheduler, similar purpose as Azkaban is for) has a command called backfill that is more or less about the same thing. They say it's to:

Run subsections of a DAG for a specified date range

With the command line client it's run something like this:
airflow backfill "tutorial-flow" -s "2015-06-01" -e "2015-06-07"

Related Airflow documentation:

https://airflow.incubator.apache.org/cli.html (search for backfill)
https://airflow.incubator.apache.org/tutorial.html#backfill

Azkaban feature proposal
Sub-sections below (sorry, issue descriptions can't have real links):

Providing the base date to the flows/jobs
Date range executions in Azkaban web UI
Additional execution options

Providing the base date to the flows/jobs
Azkaban provides the base date as a Runtime property, for example:
azkaban.flow.basedate=2017-07-01

See also: currently provided Runtime Properties in Azkaban Documentation > Job Configurations.

Date range executions in Azkaban web UI
For convenience, Azkaban could allow executing a date range via the Web UI.
Preparing an execution with date range

Date pickers for start & end date to define the date range

This could also allow adding individual dates, in case it's not a full range without gaps that one wants to run

As usual when preparing an execution: possibility to disable jobs, set flow override props, set concurrent option and failure mode

Tracking a date range execution in the UI

Azkaban will provide a single view for tracking the date range execution

This allows killing the entire date range execution, ie. all executions that were launched or queued by this "date range execution"

This should probably be some dedicated new kind of UI. Something similar to the flow executions page, but only showing the executions that are part of this "date range execution".

The listing shows the base date of each execution, and obviously the status (running, succeeded, queued,.. )
I think it's not possible to just generate a flow where each day is a sub-flow, because the UI won't scale to that. We have tried, it's too much for the browser.

Additional execution options
User can choose how to execute the days: in a sequence or in parallel

If parallel, optionally limit how many days to execute in parallel

User can choose a failure action on "day level", ie. whether to continue to the next day or not if the execution fails for some day.
User can set a number of retries, in case some of the dates in the date range fail.
Beyond date ranges: dynamically resolved array of props
To extend on a "built-in" date range support, another use case is executing a flow with an array of dynamically resolved parameters. This would basically mean:

Run a job that spits an array of properties as its output
Take the array of output props and execute a given flow with each array element passed to it as flow override properties

For example, a "parameter resolving job" could generate this array:
[
  {"prop": "a", "hour": 1},
  {"prop": "b", "hour": 1},
  {"prop": "c", "hour": 2},
  {"prop": "d", "hour": 2}
]

So in this case the flow would be executed 4 times, first with {"prop": "a", "hour": 1} passed to it, then another execution with {"prop": "b", "hour": 1}, etc.
In practice this could be described in job files as something like this:
generate_array.job:
type=example_output_props_job
output=echo '[ {"prop": "a", "hour": 1}, {"prop": "b", "hour": 1}]'

loop_params_array.job:
type=array
dependencies=generate_array
forward_output_props=true
flow_property=this_is_same_for_all_executions
flow.name=flow_to_run

flow_to_run.job:
type=command
command=echo "${flow_property} - ${prop} at ${hour}!"

Here the job type example_output_props_job  implements Job#getJobGeneratedProperties by returning the value of output.
Well, in reality, currently getJobGeneratedProperties returns a flat set of Props. There should be a new method that can be used to return an array instead (Props[]).

Otherwise the new built-in job type array would act so that if you go see it in the Azkaban UI, you get a similar view as Date range executions in Azkaban web UI (see above).
Dynamic flow generation?
Finally, while the "array" job type above is a way to keep things in control with flow definitions validated on deployment-time, maybe it would be better to instead provide support for entirely dynamic flow generation on runtime.
In practice this could mean that a job can output an entirely new flow definition, and azkaban will execute that flow. I wonder what the format should be.. Maybe just a directory of .job and .properties files.

Backfill support is something we are considering too.
The details need to be hashed out. But what you described at high level sounds good to me.
We would like to build future UIs purely based on APIs. So it will be good to design and implement the APIs first.

Thanks for the comment.

Backfill support is something we are considering too.

Can you see it on some position of your 4.x roadmap? ping @ameyamk

Something new about the issue?!
Is there some way to set an EndDate to my flow??


Thanks for taking the project forward

I wanted to thank you Grant for taking the time to improve my original project, as I don't seem to find the time to manage the project myself. I am happy that this fork has already improved things, and added much requested features, and I look forward to following the progress.
Dale

Thanks @dale-roberts for starting this out. Just a little history for the record books on how this came to be.
The original repo/project that started it all: https://github.com/dale-roberts/MouseUnSnag. That was forked by @GrantMoyer with some improvements at https://github.com/GrantMoyer/MouseUnSnag that then made its way to its own group here (via the discussion at https://github.com/dale-roberts/MouseUnSnag/issues/3#issuecomment-997311048 on the original project).

@dale-roberts: Should we update the README.md in your original repo with a notice at the top pointing to this repository instead? Maybe not right now, but eventually, since I think we should upload an executable release before that happens (so folks have an app they can actually download).
p.s. @GrantMoyer my currently outstanding pull requests are based on branches that I created and pushed to this repository. However moving forward, I'll update my workflow to instead be based on branches that live in my fork instead (which is now re-created and forked from this repo instead of @dale-roberts's original repo). Should make PR review a bit cleaner with less branches polluting the new canonical repository.

Putting a link on the old page (eventually) sounds like a good idea. We can leave this issue open until that time comes, or if you think it more appropriate to start a new issue, that works too.

Maybe by the next release? By then we should have a few new features in combination with the system tray icon stuff from v2.1. Some of those new features are already present, but have some minor bugs that will be resolved by either #5 or #7
Just setup a milestone v2.2 to target some issues/PRs that are currently outstanding. https://github.com/MouseUnSnag/MouseUnSnag/milestones/v2.2


ImportError: No module named 'setuptools'

I also get an error when trying to install:
python3 setup.py install --user -r requirements.txt
Traceback (most recent call last):
File "setup.py", line 3, in
from setuptools import setup
ImportError: No module named 'setuptools'
I am able to run mauritso's LiqBot on this same machine.

setuptools may well be prerequisite.
try python setup.py install --user -r requirements.txt
without the python’3’.

setuptools may well be prerequisite.
try python setup.py install --user -r requirements.txt
without the python’3’.

On 12 Jun 2016, at 18:35, Urdawg<EMAIL_ADDRESS>wrote:
I also get an error when trying to install:
python3 setup.py install --user -r requirements.txt
Traceback (most recent call last):
File "setup.py", line 3, in
from setuptools import setup
ImportError: No module named 'setuptools'
I am able to run mauritso's LiqBot on this same machine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/xeroc/stakemachine/issues/6, or mute the thread https://github.com/notifications/unsubscribe/AFydwdkWaDNWjBFqZq1dIKNHloqSxzhxks5qLENLgaJpZM4Iz14Y.


Allow bulk downloading of hpl technical spec files

Description
This will allow user officers ,instrument scientist and access tokens to download attachments on proposals.  These can be samples ,sub templates or basic file questions.

Motivation and Context
HPL will need a way of being able to bulk download all technical spec files (uploaded with each proposal) ahead of the FAPs.
The technical specification (or technical pack) is a word document file that goes out with the call of access. PIs and their team fill it out with diagnostics info they are hoping to use and upload it as part of the proposal process. This allows HPL to do an assessment ahead of the FAPs from a technical perspective.

How Has This Been Tested

Fixes
Closes: https://github.com/UserOfficeProject/user-office-project-issue-tracker/issues/843

Changes
Files changed:

apps/user-office-backend/src/datasources/postgres/TemplateDataSource.ts
apps/user-office-backend/src/factory/pdf/genericTemplates.ts
apps/user-office-backend/src/factory/pdf/proposal.ts
apps/user-office-backend/src/factory/pdf/sample.ts
apps/user-office-backend/src/middlewares/factory/factoryServices.ts
apps/user-office-backend/src/queries/ProposalQueries.ts
apps/user-office-backend/src/queries/TemplateQueries.ts
apps/user-office-frontend/src/components/proposal/ProposalAttachmentDownload.tsx
apps/user-office-frontend/src/components/proposal/ProposalTableInstrumentScientist.tsx
apps/user-office-frontend/src/components/proposal/ProposalTableOfficer.tsx
apps/user-office-frontend/src/components/proposal/TableActionsDropdownMenu.tsx
apps/user-office-frontend/src/context/DownloadContextProvider.tsx
apps/user-office-frontend/src/graphql/proposal/getProposals.graphql
apps/user-office-frontend/src/hooks/proposal/useDownloadPDFProposal.ts
apps/user-office-frontend/src/hooks/proposal/useProposalsData.ts
apps/user-office-frontend-e2e/cypress/e2e/proposalAdministration.cy.ts
apps/user-office-frontend-e2e/cypress/e2e/instruments.cy.ts
apps/user-office-frontend-e2e/cypress/types/template.d.ts
apps/user-office-frontend-e2e/cypress/support/template.ts

Depends on

Tests included/Docs Updated?
E2e tests

[x] I have added tests to cover my changes.
[x] All relevant doc has been updated

@bolmsten have a failing test  Should be able to verify pdf download and compare with a fixture
looks like file file 2023_proposal_fixture.pdf might have changed in size: Error: Timed out retrying after 15000ms: File size 89390 is not 56494


How to ignore cdn based system js modules, like that of libraries, while building with system js builder

Hi,
I am making an angular2 project. I am including the angular2 module from CDN and it is not present in my local development system. I have no mapping for angular2 in my config.js too.
I want to bundle my local system js modules into a single js file. But I cannot do so as my local modules import angular2. I have been trying hard to overcome this but it doesn't work.
I think I am missing something in system js' documentation. Or CDN based modules are not supported while building with system js builder.

Try something like this (depending on how you're loading your modules):
meta: {
  "angular/*": {
    build: false
  }
}

Thanks


Bring back UdpSocket::only_v6 (fixes #1424)

Here's a minimal attempt, let me know what else is needed.

Pff, that was a bit painful. Please have a look!

Thanks @djc.

Could you publish this on crates.io?

I want to merge https://github.com/tokio-rs/mio/pull/1422 first, it has a couple of fixes.


New-HTMLGage title

hi,
in "New-HTMLGage" what is the diff between "-Title" & "-Label" ?
also, any chance we can get a font size for the title in that widget as well?

Visitors is a title, per minute is a label. I don't see font size for Title in docs for https://github.com/toorshia/justgage
I can see it for labels and values. I guess one could try to add it to JS code, make a PR and then use it.


Change Get-JenkinsObject - use passed attributes when folder is specified.

Get-JenkinsObject should use passed attributes when folder is specified.

This change is

Awesome job @shege  - thank you for submitting this. Are you able to add a new entry to a new section called ### Unreleased to the ## Versions section in the README.MD file mentioning the change?
e.g. https://github.com/IAG-NZ/jenkins/blob/master/readme.md#versions
## Version

### Unreleased

- Fixed Get-JenkinsObject to use passed attributes when folder is specified.

I'll merge and then trigger the release process straight after so that it publishes to the PS Gallery. Awesome job with the tests too BTW!

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@PlagueHO Thanks! readme.md file has been updated.

Nice! Thanks @shege

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


JSON text component does not autocomplete some fields (notably storage, nbt, entity, block, selector, and score)

Details:

VSCode 1.58.2 on Windows x64 (it has been this way for a while)
Problem does not fix after reinstallation, even if the extension is cleared from disc manually
Subcomponents (like name and objective of score) do autocomplete once the components specified above are manually typed in
Syntax highlighting is performed correctly once the key is typed in (such as highlighting for selector and nbt)
The only issue is that these keys do not show up in autocomplete, but they work in all other aspects.

How to replicate:

Type in the line tellraw @a {
Press ctrl+space to trigger autocomplete suggestions if necessary (other options should show up)
The tags listed in the title do not show up

Duplicate of #832, which will be fixed in the next major release.


Compatibility with H, J and L series

Do you know which TV models work with this code? I guess the K-Series is working fine but what about the other models like H, J and L?

H is a 2014 model and J/L are 2015. These should be covered by homebridge-samsungtv.

This does not work on JS9000


PrivateUserOwnership should be PrivateUsersOwnership in the systemd-nspawn module

Describe the bug
According to man pages, the name is PrivateUsersOwnership, not PrivateUserOwnership
The file in question:
https://github.com/NixOS/nixpkgs/blob/a63021a330d8d33d862a8e29924b42d73037dd37/nixos/modules/system/boot/systemd/nspawn.nix#L30

Thanks for reporting the issue. I created a PR to fix it.


LF-253: iframe integration script

iframe integration script gets new functionality including drawer mode 💥

@mathiasmoeller Yeah, TS is not used there mainly because of how the current CRA config works. It can't compile files that are not in the /src folder. I'll figure this out for redesigned widget, not satisfied with that as well. This js file is also not minimized and obfuscated, which I plan to fix in a new one.
Regarding the quick fix for horizontal scroll, I agree it doesn't look lovely, we definitely can fix this, but I'm not sure we should spend time on this now. What do you think?


Configurable Grid Group Row Rendering

Would be nice to be able to customize the group row rendering a bit without having to use agOptions.
Some ideas on what we could/should be able to configure:

Display value
Turn off child count
Expand/Collapse icon?

Agree on all these points.  Perhaps rowGroupOptions as a sub-config object to GridModel?

Note that using the new GridModel.groupRowRenderer isn't entirely as friendly as it could be. Returning a custom value here will only fill in the "inner" part of the group cell - the expand collapse arrows will still show (which is probably good) but so will the counts (which are more likely to be something developers want to turn off).
You can take over the entire row by supplying a groupRowElementRenderer and returning a React element, but then you need to do more work on the styling, and expand/collapse arrows go away again.
We could push farther if desired - maybe using CSS classes to hide child counts, etc. - but will let #1685 close out this ticket for today!


Add AboutCode GSoD proposal for 2024

https://github.com/nexB/aboutcode/wiki/GSOD2024
https://github.com/nexB/aboutcode/wiki/GSOD-2024-Proposal
https://github.com/nexB/aboutcode/wiki/GSoD-Technical-Writer-Selection-Process

Thanks++ @emckean!


[WIP]Tutorial on PairPotential impl. Intro and impl.

This PR will teach users how to add a PairPotential to Lumol.
These are the steps discussed in the tutorial:

[x] Introduction
[x] Prerequisites
[x] Building the struct
[x] impl Potential
[x] impl PairPotential
[ ] add API documentation
[ ] add unit tests
[ ] add parser for input files
[ ] add documentation in the manual

Wording and formatting is not fleshed out yet.
You can clone this PR and locally build the manual using
mdbook serve --open

from within the lumol/doc/ directory (you can install mdbook using cargo).

This looks very nice!
I have a suggestion about the organisation of this tutorial. Lumol is written such as it can be extended from the outside; which means the users do not need to write code in this repository to have it work with the rest of the engine. The tutorial could be written to use this property: just create a new cargo project, make it depend on the lumol crate, and implement the potential here.
This can have two benefits:

the tutorial can be made into a real repository that people can clone, and that can be tested with respect to lumol changes.
the tutorial does not need to deal with "extra work" that is needed for inclusion in this repository, but not when one just want to make the code work.

Your tutorial outline could then be splitted in two parts: the basics with

Introduction
Prerequisites
Building the struct
impl Potential
impl PairPotential

and then the extra, only needed to include code in the main repository

add API documentation
add unit tests
add parser for input files
add documentation in the manual

The only issue is until we get a plugin system (#45), users needs to write there own main function if they want to use any newly developed potential/MC move/propagator/...

Thanks for the feedback!

The tutorial could be written to use this property: just create a new cargo project, make it depend on the lumol crate, and implement the potential here.

That's a good idea, I reorganize the tutorial accordingly. Would you still have this as part of the manual (I would, see the 2nd part about docs and input) or would we treat tutorials of this kind differently? Where would you put the tutorial repo?
I'll keep on pushing to this PR - it already includes all codes necessary to put them into a separate repo so this will be a quick change in the end.

Concerning organisation, I think we can have everything in this repo for now, so the text in the manual, and the code in a tutorials directory. If it gets annoying, we can still move it to a separated repo later.

Added first part of the tutorial. I also added a tutorials directory in the root with a separate package that implements the discussed material as well as a small sample simulation setup to test the implementation.

No, this does not look like so =)

Not sure how long it will take me to write the second part. Maybe it makes sense to merge this as is.

Yeah, we can merge this as it is, and keep the advanced part of the tutorial for later.

Can you also add a test in .travis.yml that check that the code compiles (you don't need to run the simulation, just build everything with cargo build), and that it keeps compiling even when we will change other things?

I'm done with this part.

And thank you again for doing this: having a good documentation is essential, especially for open source software!


Problem installing after following the instructions

got:
Python 2.7.11
Microsoft Visual C++ 2010 Express
Windows 7 SDK (https://www.microsoft.com/en-us/download/details.aspx?id=8279)
node-gyp.
Been searching online and nothing has resolved it from not working.
This is what happens when I run the following command: npm install pomelo -g
https://ghostbin.com/paste/ye7m4

you don't need install pomelo in windows, i tried but i failed. Other solution is clone folder (lib) pomelo was install in ubuntu and paste it to folder node_modules of your project, it like this picture
pomelo

And now you clone some sample project of pomelo to try it, i successed with above solotion.
Here is pomelo was complied from ubuntu that i used
https://drive.google.com/file/d/0B-hxz6ee5n8_TEtzdllzZGo5bjg/view?usp=sharing

Oh cool thanks. I will try that out.

I am having troubling running the command line tool. I am able to do something like node_modules/pomelo/bin/pomelo, but even then I still get exceptions about it running. How can I install or setup the bin for the directory?
https://ghostbin.com/paste/853t3

the solution only help you programming with pomelo, i'm also falil when run commanline pomelo.
Here source chatofpomelo is customize by me, you can download and extract then run with commandline
node app.js for both web-server and game-server.
That project i just customize with multi chat processor
{
"development":{
"connector":[
{"id": "connector-server-1", "host": "<IP_ADDRESS>", "port": 4050, "clientPort": 3050, "frontend": true},
{"id": "connector-server-2", "host": "<IP_ADDRESS>", "port": 4051, "clientPort": 3051, "frontend": true},
{"id": "connector-server-3", "host": "<IP_ADDRESS>", "port": 4052, "clientPort": 3052, "frontend": true}
],
"chat":[
{"id": "chat-server-1", "host": "<IP_ADDRESS>", "port": 6050},
{"id": "chat-server-2", "host": "<IP_ADDRESS>", "port": 6051},
{"id": "chat-server-3", "host": "<IP_ADDRESS>", "port": 6052}
],
"gate":[
{"id": "gate-server-1", "host": "<IP_ADDRESS>", "clientPort": 3014, "frontend": true}
]
},
"production":{
"connector":[
{"id": "connector-server-1", "host": "<IP_ADDRESS>", "port": 4050, "clientPort": 3050, "frontend": true},
{"id": "connector-server-2", "host": "<IP_ADDRESS>", "port": 4051, "clientPort": 3051, "frontend": true},
{"id": "connector-server-3", "host": "<IP_ADDRESS>", "port": 4052, "clientPort": 3052, "frontend": true}
],
"chat":[
{"id": "chat-server-1", "host": "<IP_ADDRESS>", "port": 6050},
{"id": "chat-server-2", "host": "<IP_ADDRESS>", "port": 6051},
{"id": "chat-server-3", "host": "<IP_ADDRESS>", "port": 6052}
],
"gate":[
{"id": "gate-server-1", "host": "<IP_ADDRESS>", "clientPort": 3014, "frontend": true}
]
}
}

@cdrandin  i just fixed it on windows to run commend line tool
please run this command line to know where is global folder of node moduls
npm list -g
on my computer global folder of node module is  C:\Users\KSTN-NAM\AppData\Roaming\npm
Then copy pomelo folder ( https://drive.google.com/file/d/0B-hxz6ee5n8_TEtzdllzZGo5bjg/view?usp=sharing) to that path
and create 2 file pomelo and pomelo.cmd like in this picture

I attach 2 file here
https://drive.google.com/file/d/0B-hxz6ee5n8_WmQ3NDRpZ21aR2M/view?usp=sharing
Last step is config path to system know where is pomelo using System variables Path

ok now you can using command line like pomelo list, pomelo start ....

Awesome, thanks!. I will check this out in the morning.

Hey, sorry for the delay. I was able to get the command line tool working, however, it stopped when trying to install dependencies.
debug log: https://ghostbin.com/paste/y27nz
I just followed the instructions for creating a new project.
Here is what I currently have in the project: https://gyazo.com/55e340a01ad2906bb8706b3cac3365f5
I also get bunch of exceptions when trying to start, list, stop using the pomelo command, but I assume that is the case because I am missing the dependencies.

you do not has pomelo lib in node modules.Please insert it to node_modules
And you should using command "pomelo init" to create your project
You can try this project that i create by manual commandline 'pomelo init' and copy paste pomelo lib into node_modules
Dowload in from https://drive.google.com/file/d/0B-hxz6ee5n8_Q1JfbzRZelBqT3M/view?usp=sharing

Oh so I also need to put pomelo into the project's node_modules folder as well? I thought doing -g in npm install would just let it work since it is considered to be in global space now.

pomelo start works under game-server. However, I get the following error when trying to run node on app.js under web-server https://ghostbin.com/paste/4k22n

Upon further messing around. It seems a lot of the code in the web-server/app.js methods don't work because they are no longer bundled with Express
https://ghostbin.com/paste/mrwdo

please run only game-server in https://drive.google.com/file/d/0B-hxz6ee5n8_Q1JfbzRZelBqT3M/view?usp=sharing
And if error then send me some of picture about error, perhaps i can help you
Express is other node modules its is independent pomelo.
If you can run game-server is ok
Express will has other solution
Note please run project i send by link https://drive.google.com/file/d/0B-hxz6ee5n8_Q1JfbzRZelBqT3M/view

Hey, so I got pomelo working properly. It seems I couldn't have 2 different instances running.

like

After searching a bit I was able to find.
https://github.com/NetEase/chatofpomelo
https://github.com/NetEase/pomelo-unitychat
So far this is helping. One thing I am confused about is how the handlers are called.
How pclient.request("connector.entryHandler.enter", userMessage, (data)=>{
is able to call  handler.enter = function(msg, session, next) {
Does pomel automatically handle the naming scheme when trying to make a request on client side?


merge another admin template

is there a way to add admin Template like http://themeforest.net/item/fuse-angularjs-material-design-admin-template/12931855?s_phrase=&s_rank=9 to your cms?

No, you should change css by yourself if want another look.


Android implementation not working because of gist library

I installed the SDK for React Native on iOS and on Android. On iOS worked as expected but for Android I cannot build the project because it's throwing this error:
Could not determine the dependencies of task ':app:mergeBetaDebugAssets'.
> Could not resolve all task dependencies for configuration ':app:betaDebugRuntimeClasspath'.
   > Could not find any matches for build:gist:2.1.+ as no versions of build:gist are available.
     Searched in the following locations:
       - file:/Users/user/myApp/app-mobile/node_modules/react-native/android/build/gist/maven-metadata.xml
       - file:/Users/user/myApp/app-mobile/node_modules/jsc-android/dist/build/gist/maven-metadata.xml
       - https://repo.maven.apache.org/maven2/build/gist/maven-metadata.xml
       - https://jcenter.bintray.com/build/gist/maven-metadata.xml
       - https://dl.google.com/dl/android/maven2/build/gist/maven-metadata.xml
       - https://www.jitpack.io/build/gist/maven-metadata.xml
       - https://developer.huawei.com/repo/build/gist/maven-metadata.xml
     Required by:
         project :app > project :gistproduct_react-native
   > Could not find build:gist:2.1.4.
     Searched in the following locations:
       - file:/Users/user/myApp/app-mobile/node_modules/react-native/android/build/gist/2.1.4/gist-2.1.4.pom
       - file:/Users/user/myApp/app-mobile/node_modules/jsc-android/dist/build/gist/2.1.4/gist-2.1.4.pom
       - https://repo.maven.apache.org/maven2/build/gist/2.1.4/gist-2.1.4.pom
       - https://jcenter.bintray.com/build/gist/2.1.4/gist-2.1.4.pom
       - https://dl.google.com/dl/android/maven2/build/gist/2.1.4/gist-2.1.4.pom
       - https://www.jitpack.io/build/gist/2.1.4/gist-2.1.4.pom
       - https://developer.huawei.com/repo/build/gist/2.1.4/gist-2.1.4.pom
     Required by:
         project :app > project :customerio-reactnative > io.customer.android:messaging-in-app:3.0.0

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

Note:
I added the in-app dependency to the dependencyResolutionManagement block in my android/settings.gradle not in android/build.gradle

Hi @santipt. Looks like gradle files are unable to find the required repositories. Since you mentioned you added the in-app dependency to android/settings.gradle, can you please share the code you added to it?
Also, please note that dependencyResolutionManagement was introduced from gradle 6.8. So if you are using an older version or if your project is using the older way of setting up repositories, you might need to add the repository to android/build.gradle as mentioned in 2 -> [Android] -> b -> [build.gradle] here

Hi @mrehan27 thanks for the quick reply. Here is the code I added in the android/settings.gradle:
dependencyResolutionManagement {
   repositories {
      maven { url 'https://maven.gist.build' }
   }
}

When I saw that adding the dependency on android/settings.gradle wasn't working I tried to add it on android/build.gradle but then I had another error: Records requires ASM8.

Thanks for updating @santipt. Records requires ASM8 could be coming from moshi. Can you please add the repository back to android/build.gradle instead of android/settings.gradle and try adding the following to your android/gradle.properties?
android.jetifier.ignorelist=moshi-1.13.0

You can find more details on this issue here

@mrehan27 I tried to add back the repository to android/build.gradle and also to add android.jetifier.ignorelist=moshi-1.13.0   in my android/gradle.properties before and it didn't work. However, I just tried again to double check and I'm having the same error: Records requires ASM8.
Also to add some extra info. This is my current Gradle Version:

@santipt Sorry to hear that. Can you please share complete stack-trace of build errors when running the build after adding the repository to android/build.gradle?

Hey @santipt, this is a very unusual issue, so any help that you can provide here would help us to debug this case even faster.
Here is the link to our sample application for react, which you can probably go through and match implementation.
Also, Records requires ASM8 relates to jetifier, which is only needed when you have not done the AndroidX migration, so is it possible that you are using another dependency/library, which is not migrated to AndroidX?
Last but not least, if nothing works, can you try adding Moshi dependency in your app separately? and exclude our ReactNative SDK? just want to confirm if Moshi conflicts with your App or any other dependency.

Hi @mrehan27  I just sent the email with the stack-trace of build errors to<EMAIL_ADDRESS>@Shahroz16 let me check your suggestions to see what I can do there and then I'll come back to you  :eyes:

@Shahroz16 I checked and we are using another library that seems that is not migrated to AndroidX. Also I added the moshi dependency and excluded yours. I realised if I add the moshi dependency version 1.8.0 I don't see the error about Records requires ASM8 however if I use moshi 1.13.0 it shows up again. Maybe that could help you.

@santipt thanks for all the help. If possible can you try one more thing. Update the Gradle plugin version to 7.2 or 7.2+?
We can also probably create another version with Moshi updated but don't want to rush it out without making sure it doesn't break anything else.

Hey @Shahroz16 updating the Gradle plugin version to 7.2.2 worked!  :tada: I run a debug build and my app is running without errors. Thanks a lot for the help :blush:

woot woot !! thanks for confirming @santipt.
Closing this issue, feel free to reopen it if this arises again. 🕺


Add update workflow

I entered all code that was merged onto dev from update-metadata into the update-workflow script so that the update-workflow.py file contains the same TODOs and common code parts as the update-metadata.py file.
I modified the commit history with git rebase -i to combine some commits and wrote more descriptive commit messages.
The README.md contains a section that describes the update-workflow part and needs to be resolved manually.

I also refactored the code to get rid of the code duplications and worked on all TODOs that were part of the update_metadata script

All requested changes were made

Sven, it would be great if you would test run the script before committing/updating the PR. The current version of the script creates this mess:
$ ./update_workflow.py -d -b v1.2.0 -w ../../../workflow-smk-genome-onesie-assembly/

I didn't even touch that part in the last fixes and to my knowledge it worked flawless before. Something else must have changed that caused splitting each PosixPath list item into a new list of every character separately.
This issue has been resolved and in the process another bug during the check and create of potentially missing subfolders in the working folder has been fixed.

Dealt with that in a non-standard way due to several non-linearity issues in the history; relevant commits cherry picked into dev. Closing this now...


Added collapseMultipleWhitespaces option

Added an option collapseMultipleWhitespaces to replace series of multiple whitespaces with a single one, if true. Otherwise do that only for leading and trailing.
See #361

With the option turned on, the conversion would become broken. There can be arbitrary sequences of whitespace anywhere in the original HTML. Even though you trim leading and trailing WS runs, the whitespace inside of the text can introduce e.g. paragraphs or indented code blocks that are not present in the original HTML.
Also, mixing ASCII and non-ASCII whitespace differs between HTML and Markdown - see the specs and it would have consequences in escaping rules.
What Turndown tries to do, is convert the whitespace to the best semantic equivalent. Preserving the insignificant white space from HTML syntax is not completely possible by design. And even though there can be some partial preserving some whitespace, I currently think it's not worth it.
You can check the complexity of dealing with significant whitespace translation, which is currently done for:

preformatted code blocks - #318, PR #319
dealing with mixed unicode and ascii whitespace - PR #315

I suggest to better describe the need of preserving insignificant WS in the related ticket. Based on that, we should decide whether to rework or close this PR. Thanks.

With the option turned on, the conversion would become broken. There can be arbitrary sequences of whitespace anywhere in the original HTML. Even though you trim leading and trailing WS runs, the whitespace inside of the text can introduce e.g. paragraphs or indented code blocks that are not present in the original HTML.
Also, mixing ASCII and non-ASCII whitespace differs between HTML and Markdown - see the specs and it would have consequences in escaping rules.
What Turndown tries to do, is convert the whitespace to the best semantic equivalent. Preserving the insignificant white space from HTML syntax is not completely possible by design. And even though there can be some partial preserving some whitespace, I currently think it's not worth it.
You can check the complexity of dealing with significant whitespace translation, which is currently done for:

preformatted code blocks - #318, PR #319
dealing with mixed unicode and ascii whitespace - PR #315

I suggest to better describe the need of preserving insignificant WS in the related ticket. Based on that, we should decide whether to rework or close this PR. Thanks.


AWS Batch Support

Support AWS batch per issue #781. This is somewhat of a draft of the whole thing to make sure the overall structure looks sane before I go up and CloudFormation all the things. Note that for the JobQueue resource's state property I diverged from the CF documentation and used the REST API documentation for CreateJobQueue which states that ENABLED or DISABLED are valid values.
The following resources are added:

AWS::Batch::ComputeEnvironment
AWS::Batch::JobDefinition
AWS::Batch::JobQueue

The following property types are added:

AWS Batch ComputeEnvironment ComputeResources
AWS Batch JobDefinition ContainerProperties
AWS Batch JobDefinition Environment
AWS Batch JobDefinition MountPoints
AWS Batch JobDefinition RetryStrategy
AWS Batch JobDefinition Ulimit
AWS Batch JobDefinition Volumes
AWS Batch JobDefinition VolumesHost
AWS Batch JobQueue ComputeEnvironmentOrder

If this looks good I'll go ahead and do the runtime testing. As for updating README.md's list of supported resources do you want that as a separate commit or should I just squash with the python code commit?

This looks excellent. Note: I might have combined the state validators, added enabled/disabled constants, and possibly alphabetized the various props (the purest in me would prefer the AWS docs to be in alphabetical order but I know why you chose that order). I'm not asking for changes since this looks good to go. Feel free to add additional runtime and I'll commit. Thank you for this change! How about opening up a README issue and I'll update with the various new resources in 1 commit.

@markpeek Let me do re-order on the props and some of the objects then to have them in alphabetical order (though the objects I can only re-order to the point of python being able to properly resolve definitions). To make an easier read I'll toss in a few comments to break up the file by Batch resource. I agree on the constants an validators so I'll go ahead and update that as well.
For the runtime testing it's going to take a bit since putting this all together into a template will be rather time consuming. Possibly middle of next week?
Okay on the README issue. I though there might be other services that got left out but wanted to get this finished out and didn't have a chance to do a full comparison.

Thanks!


Swift 4 web proxy in swift

Today we use python web server to execute the swift binary.
python will pass input JSON via stdin and expect executable to respond with the last line of stdout as the output JSON.
The problems is that the swift code needs to initialize everything on every invoke. if creates instances of a Class, or reads a file into an instance. this work needs to be done from scratch on every invoke.
Other runtimes like nodejs and python in OpenWhisk don't have this problem, since the web proxy server is in the same language and holds into memory.
It would be good to have a web proxy server to be implemented in swift, this way anything created on /init or /run can remain in memory as long the container lives.
One alternative is look into Kitura 2.0 to build a very small and fast web proxy that listens on port 8080 that handles the standard OW interface with /init and /run

We might use in the interim a go proxy which seems to be faster than the python flask that we use today.

Closing, as we are using the go proxy now


mount through procfd: no such file or directory: unknown

All of a sudden a few days ago I started receiving this error:
OCI runtime create failed: container_linux.go:367: starting container process caused: process_linux.go:495: container init caused: rootfs_linux.go:76: mounting \"proc\" to rootfs at \"/proc\" caused: mount through procfd: no such file or directory: unknown

The important part I believe being "mount through procfd".
I did some digging and it seems like it's something introduced to runc recently:
https://github.com/opencontainers/runc/commit/0ca91f44f1664da834bc61115a849b56d22f595f#diff-e0932af06cb46065b2ef5fc89bc2bd9b880c9578e01b89ef4ecaeffb78a8bef0
In fact, that's the most recent commit to runc as of right now. It's related to a high severity CVE:
https://github.com/opencontainers/runc/security/advisories/GHSA-c3xm-pvg7-gh7r
Which was just released a few days ago, right before I started experiencing the issue:
https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc95
Though, I'm not sure how I got the update so quickly. In any case, I don't have much more information on this right now, but I thought I'd get a discussion started. I'll be working to try to get some reproduction steps. Here's some information about my current setup. I'm currently on Ubuntu 21.04:
$ uname -a
Linux desktop-linux 5.11.0-17-generic #18-Ubuntu SMP Thu May 6 20:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

$ apt-cache show docker.io | grep Version
Version: 20.10.2-0ubuntu2

$ apt-cache show sysbox | grep Version
Version: 0.2.1-0.ubuntu-focal

In case you're wondering, I was on Ubuntu 20.04 until recently which is why I'm able to have installed sysbox via apt when installing via apt on 21.04 isn't (yet?) supported.
Let me know if there's any information I can provide in the mean time.
Other relevant links:
<EMAIL_ADDRESS>

Hi @ScottG489 , thanks for filing the issue.
Yes, if you could provide us with repro steps, that would help.
Also, I noticed you have Sysbox v0.2.1; you may want to retry with the latest Sysbox version (v0.3.0) as it introduces multiple improvements and fixes (though I am not sure it will address the issue).
Regarding support for Ubuntu 21.04: yes, we need to update the sysbox installer to support the latest Ubuntu releases (20.10 and 21.04). We will likely do this for the upcoming release in the next few weeks.

Hey @ctalledo! Thanks for getting back to me so quickly.
Here are reproduction steps (start this in a new/clean dir). You can copy/paste these into your shell directly for each section:
# On the host
vagrant init --minimal bento/ubuntu-20.04 \
&& vagrant up \
&& vagrant ssh

# In the VM
SYSBOX_VERSION=0.2.1 ; \
sudo apt update \
&& sudo apt install -y docker.io \
&& wget https://github.com/nestybox/sysbox/releases/download/v${SYSBOX_VERSION}/sysbox_${SYSBOX_VERSION}-0.ubuntu-focal_amd64.deb \
&& sudo apt-get install -y ./sysbox_${SYSBOX_VERSION}-0.ubuntu-focal_amd64.deb -y \
&& sudo apt-get install -y linux-headers-$(uname -r) \
&& sudo docker run --runtime=sysbox-runc -it --entrypoint bash ubuntu:20.04

# In the container
apt update \
&& apt install -y docker.io \
&& (dockerd > /var/log/dockerd.log 2>&1 &) \
&& sleep 3 \
&& docker run alpine

This will result in:
docker: Error response from daemon: OCI runtime create failed: container_linux.go:367: starting container process caused: process_linux.go:495: container init caused: rootfs_linux.go:76: mounting "proc" to rootfs at "/proc" caused: mount t hrough procfd: no such file or directory: unknown.
The docker version installed on the VM is Docker version 20.10.2, build 20.10.2-0ubuntu1~20.04.2
Interestingly, if you use sysbox v0.3.0, instead of getting that error it will just hang indefinitely on docker run alpine.
What's strange is that I'm not doing anything special in these reproduction steps. This almost seems like a "hello world" for trying out sysbox. Certainly I must be missing something?
Let me know what you think. I'm going to try out a few more combinations of Ubuntu and docker versions and will let you know the results. Let me know if there's anything specific you'd like me to test.

I installed version 20.10.2 of the static binaries (the same version Ubuntu was using) version that was installed and it worked fine:
DOCKER_VERSION=20.10.2 ; \
apt update \
&& apt install -y wget iptables \
&& wget https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz \
&& tar xzvf docker-${DOCKER_VERSION}.tgz \
&& cp docker/* /usr/bin/ \
&& (dockerd > /var/log/dockerd.log 2>&1 &) \
&& sleep 3 \
&& docker run alpine

I also did the same with the latest version 20.10.6 and it also worked fine.
Perhaps this indicates it's an issue specifically with the Ubuntu distribution?

Hi @ScottG489, thanks for the extra investigation, though it's hard to understand what's going on. I'll be working on this today, hopefully we can sort this out.

Interestingly, if you use sysbox v0.3.0, instead of getting that error it will just hang indefinitely on docker run alpine.

I am able to reproduce this on my side, using the repro steps you mentioned (i.e., running a sysbox container with Ubuntu:20.04, installing docker inside (apt install -y docker.io), and launching an inner alpine container).
I can see the inner runc is stuck while creating the inner container, will investigate ASAP why this is.
In my repro, the inner runc is at version 1.0.0~rc93:
root@6a901129e176:/#  apt-cache show runc | grep Version
Version: 1.0.0~rc93-0ubuntu1~20.04.2
Version: 1.0.0~rc10-0ubuntu1

Inside the sysbox container, I installed version 20.10.2 of the static binaries (the same version Ubuntu was using) and it worked fine:

I am able to confirm this too.
Since the statically-linked binaries work but the dynamic-lib binaries don't, this suggests that there is some shared library in the sysbox container's ubuntu:20.04 image that is not compatible with the latest runc version. Will investigate what that is.

I tried using a sysbox image with ubuntu:20.10, then installed the docker 20.10 using the dynamic-linked binaries, and the problem persists.
Another possible suspect is the version of the linux headers in the host kernel, which sysbox implicitly mounts into the sysbox container.

Thanks for looking into this, @ctalledo. Let me know if I can help with anything.

Another clue:
On my host, I cloned the OCI runc repo, checkout version 1.0.0~rc93, and built it from source (i.e., make runc). This generates dynamically linked binaries.
I then started a sysbox container ( docker run --runtime=sysbox-runc -it --entrypoint bash ubuntu:20.04), installed docker in it (apt install -y docker.io) and replaced the runc with mine. With this runc, I can't reproduce the problem, even though it's at the exact same version as the prior one:
root@0b1a54faa8af:/# runc --version
runc version 1.0.0-rc93
spec: 1.0.2-dev
go: go1.14.4
libseccomp: 2.5.1

Will continue looking ...

Hi @ScottG489, it appears the problem is with the docker.io package.
If I install Docker 20.10 using docker-ce package as shown in the docker docs, things work:
$ docker run --runtime=sysbox-runc -it --rm ubuntu:20.04

/# apt-get update
/# apt-get install     apt-transport-https     ca-certificates     curl     gnupg     lsb-release
/# curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg
/# curl -fsSL https://download.docker.com/linux/ubuntu/gpg | gpg --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg
/# echo "deb [arch=amd64 signed-by=/usr/share/keyrings/docker-archive-keyring.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null
/# cat /etc/apt/sources.list.d/docker.list
/# apt-get update
/# apt-get install docker-ce docker-ce-cli containerd.io

Then:
/# dockerd > /var/log/dockerd.log 2>&1 &

/# docker run -it alpine
Unable to find image 'alpine:latest' locally
latest: Pulling from library/alpine
540db60ca938: Pull complete
Digest: sha256:69e70a79f2d41ab5d637de98c1e0b055206ba40a8145e7bddb55ccc04e13cf8f
Status: Downloaded newer image for alpine:latest
/ #     <inside alpine container>

The inner docker version and runc are at the same version on which you originally found the problem:
root@bd23e3276cfd:/# docker --version
Docker version 20.10.6, build 370c289

root@bd23e3276cfd:/# runc --version
runc version 1.0.0-rc93
commit: 12644e614e25b05da6fd08a38ffa0cfe1903fdec
spec: 1.0.2-dev
go: go1.13.15
libseccomp: 2.5.1

Given this info plus our prior findings above, I don't believe the issue is a problem in sysbox per-se, but something specific to the runc version in the docker.io package.
Could you confirm if the installation procedure described above works for you?
Also, I've not been able to reproduce the problem you originally reported via this issue (i.e., mounting \"proc\" to rootfs at \"/proc\" caused: mount through procfd: no such file or directory). I am not sure it's worth pursuing that since it occurred with sysbox v0.2.1 and I don't see it with sysbox v0.3.0.

Thanks for looking into this, sorry for the false alarm.

Given this info plus our prior findings above, I don't believe the issue is a problem in sysbox per-se, but something specific to the runc version in the docker.io package.

OK, that sounds about right. I wasn't able to reproduce with anything other than the docker.io package. Perhaps I should report this to Ubuntu's tracker?

I am not sure it's worth pursuing that since it occurred with sysbox v0.2.1 and I don't see it with sysbox v0.3.0.

Agreed. It might be a good idea to keep an eye out for when a docker version with runc version 1.0.0-rc95 or later is released. When using the docker.io package, the runc version is actually reported as runc version spec: 1.0.2-dev, and I have no idea what that is. I can only imaging they must have patched in the CVE fix (https://github.com/opencontainers/runc/commit/0ca91f44f1664da834bc61115a849b56d22f595f) themselves before runc even released it. No other way I can think of that would have brought about that mount through procfd error.

Hi @ScottG489,

It might be a good idea to keep an eye out for when a docker version with runc version 1.0.0-rc95 or later is released.

Makes sense. Let's see if we can repro that mount through procfd error at that time.

When using the docker.io package, the runc version is actually reported as runc version spec: 1.0.2-dev, and I have no idea what that is

That's the version number for the OCI spec (i.e., the spec that governs the interface between the container manager (e.g., containerd or CRI-O) and runc). It's different from the runc version (which should be 1.0.0-rc* these days).
Thanks again for reporting this.

Indeed the cause is the new version of runc that incorporates the fix for CVE-2021-30465 which was recently added (backported into stable version of runc) in the official Ubuntu Focal and Debian Bullseye repositories and is installed with the docker.io package.
As a workaround you can find and install an old version of runc (e.g. runc_1.0.0~rc93-0ubuntu1~20.04.1_amd64.deb for Ubuntu Focal, runc_1.0.0~rc93+ds1-3_amd64.deb for Debian). That will of course reintroduce the vulnerability so do it at your own risk.

BTW, it seems like the new version also just landed to the official Docker for Ubuntu repos. Rebuilding nestybox/ubuntu-focal-docker from the Dockerfile reproduces the problem. Cause is containerd.io=1.4.6-1 which got released today.
Downgrading there also works (i.e. add RUN apt-get install -y --allow-downgrades containerd.io=1.4.4-1 to the end of the nestybox/ubuntu-focal-docker Dockerfile). Same warning, this will reintroduce the vulnerability so do it at your own risk.

Thanks @joanbm; let's re-open this issue then.
I can confirm that with runc 1.0.0-rc95 I can reproduce the hang that Scott reported. Let me investigate further.

I can confirm the hang is caused by a bug in sysbox, triggered by the CVE fix in the (inner) OCI runc. Will work on a fix ASAP.

Fix is under code-review (see https://github.com/nestybox/sysbox-fs/pull/38).

Fix committed: https://github.com/nestybox/sysbox-fs/commit/af3e5db26075be022f047cb896b29ff8563148d1
Closing.


Added missing parameter to table for create schedule for backup

Fixes DOC-4990
Quick fix to add the missing targets parameter to the parameters table for CREATE SCHEDULE FOR BACKUP

This change is

@kathancox  - can you add the deploy preview URL? (or teach me how to generate it?)

Sure, here is the page for this: https://deploy-preview-14523--cockroachdb-docs.netlify.app/docs/stable/create-schedule-for-backup.html
You'll find the deploy preview link above our comments in the Netlify Preview table on this PR. That will take you to the docs home site, which you can then navigate to the page you want to see.
I do try and add the link as a courtesy, but sometimes there are several pages, sorry I forgot for this one!


Refused to apply style

Hello I have a problem with import of file css.
I imported
<link<EMAIL_ADDRESS>rel="stylesheet"> in the index.html but I have this error =>
Refused to apply style from<EMAIL_ADDRESS>because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
How do I have to make it work please?
I don't have angular.json or angular-cli.json

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.
(this is a canned response)


Auto-generate top-level objects?

We might think about auto-generating the top-level objects. The main benefit would be the ability to explicitly define keywords in the methods for better tab-completion. Also, if we do it well it will be less work to keep things up-to-date as the Vega-Lite schema evolves.
On the other hand, maintaining templates is probably harder than maintaining code in the long-run.

I ended up using a decorator-based solution to make the docstring and call signature more useful: see https://github.com/ellisonbg/altair/commit/bc9b1c66945aeaefe0da8cc42298dcfff01cf1be


Segmentation Fault in XML::Parser

I am trying to track down recurring segmentation fault in a production app, and while I'm not convinced that addressing the failing test indicated here would solve my problem, I thought I should mention it.
The following resulted in a Segmentation Fault using ruby-1.9.3-p545:
require 'xml'

XMLFEED = <<-XMLFEED
<?xml version="1.0" encoding="UTF-8"?>
<example>
	<parse1>Parse twice you get an parse1</parse1>
	<parse2>Parse thrice you get a SEGFAULT!!!</parse2>
</example>
XMLFEED

xml_object = XML::Parser.string(XMLFEED)
puts "\nFirst Time"
begin
	doc = xml_object.parse
	puts doc.inspect
rescue => e
	puts e.message
end

puts "\nSecond Time"
begin
	doc = xml_object.parse
	puts doc.inspect
rescue => e
	puts e.message
end
puts

puts "\nThird Time"
begin
	doc = xml_object.parse
	puts doc.inspect
rescue => e
	puts e.message
end

I'm no expert at running kernel level debuggers, but I think I may have tracked down the issue to the following methods using valgrind:
==28223== Invalid read of size 8
==28223==    at 0xA3AF4F: xmlDictFree (in /usr/lib/libxml2.2.dylib)
==28223==    by 0xA6CE56: xmlFreeParserCtxt (in /usr/lib/libxml2.2.dylib)

Invalid free() / delete / delete[] / realloc()
==28223==    at 0x7237: free (in /usr/local/Cellar/valgrind/3.9.0/lib/valgrind/vgpreload_memcheck-amd64-darwin.so)
==28223==    by 0xA6CE56: xmlFreeParserCtxt (in /usr/lib/libxml2.2.dylib)

I ran across this because I'm trying to track down a segfault that I also thought might be a conflict between nokogiri and libxml. But this test case segfaults for me even without nokogiri loaded, just libxml-ruby, so this one doesn't look like a conflict.

See #116.


Cannot copy text on OS X

When highlighting text and pressing the Command-C keyboard shortcut, I get:
Error storing selection to clipboard. Failed to create pasteboard: [NSPasteboard generalPasteboard] failed

This is on OS X 10.12.2 with the latest Alacritty master (commit 7d07b5a1655dc9d1cda62f1dd3005b966c0fa76a).

It works for me on 8d8fca6. (10.12.2)

It could be something weird with my system, too. I'd be happy to help debug this with the right pointers.

The problem is most likely with how you started alacritty. How did you start alacritty? My guess is you are not attached to the user namespace... like running inside screen or tmux?
this "reattach-to-user-namespace" program fixes your issue:
http://www.economyofeffort.com/2013/07/29/reattach-to-user-namespace-the-fix-for-your-tmux-in-os-x-woes/

Yup, that was the problem. When I relaunched Alacritty from outside tmux, all the clipboard problems went away.

cool.. can you please close the issue?


[BUGFIX] .txt file with commas in URLs

The current implementation seems to fail when the URLs in a .txt input file have commas in them.  This modification seems to fix the bug.
(Disclaimer: I am not 100% I am passing data the way that's intended ... if so, my mistake and please correct me!)

I am also still having this issue. I get a CSV parse error like the below if the URL has one or more commas:
pyarrow.lib.ArrowInvalid: CSV parse error: Expected 1 columns, got 2: http://1.bp.blogspot.com/-xf8FZNbm-O4/UVbWL6XBdOI/AAAAAAAAFYs/1IPtSSmYZiI/s640/Big+sage,+Lantana ...

let's instead make the separator be something that never occurs

Got the same issue. I change the delimiter from ',' to '\t' and it works (line 100 of reader.py):
df = csv_pa.read_csv(file, read_options=csv_pa.ReadOptions(column_names=["url"]), parse_options=csv_pa.ParseOptions(delimiter="\t"))


refactor: replace event type strings with enum

Following up on some of my suggestions (plus some basic renaming).
Please note that the previous PR introduced some unwanted formatting (mostly in the test source file), namely 120 chars/line instead of original 80, which you seem to have missed. I find 80 ch/line too limiting and use 120 for my own projects; I forgot to change it then, but it's corrected now. Apologies.
Not sure how to modify the changelog before actually creating a PR, since it needs the PR reference. If you don't have any objections and willing to modify the changelog yourself, please merge, else let me know. Thanks!

Originally, I planned two refactorings: using enums for event types (this one) and consolidating event streams. Since there are some renaming involved, there would be merge conflicts between two PRs. Perhaps it should be a single one, bigger but simpler to merge. Closing this for now.


delete job definition after job is submitted

This avoids the proliferation of job definitions that are used only once. At my institute, with potentially hundreds of users sharing the same AWS Batch account, not having this could create a huge number of job definitions.

OK, just pushed those changes.

thank you.


Allow Tags to be given as a list when creating Resource that allows Tags

Added: Allows to pass in a CFN format list of Tags and transform it into a Tags() object on instantiation.
Added the exception for basestring as it seemed to be yelling in my import :thinking:
Example of code doing it:
QueueA:
  Properties:
    Tags:
      - Key: Name
        Value: abcd
      - Key: VPC
        Value: vpc-id

#!/usr/bin/env python
try:
    basestring
except NameError:
    basestring = str

from troposphere.sqs import Queue
with  open('test.yml', 'r') as fd:
    content = fd.read()
import yaml
content_dict = yaml.load(content, Loader=yaml.Loader)
queue = Queue('queuea', **content_dict['QueueA']['Properties'])
print(queue.to_dict())

If there is a better place to do it, or a nicer way to import a native CFN format into creating the object in full, I would love to see how :)
Many thanks for your consideration. Keep up the awesome work!

+1

No idea why the py2.7 tests fail :/

Opened under the wrong user :facepalm:


docs: time::PrimitiveDateTime::now is deprecated but how users should replace it?

Subj, probably deprecation warning should mention what users are supposed to do

Well, what time zone are you expecting the datetime to be in? It's not clear what the PrimitiveDateTime method should return.
Generally speaking, you can use OffsetDateTime::now() to get it in UTC, and OffsetDateTime::now_local() to get it in your systems time zone. You can convert freely to the desired time zone from either.

Sure, but it is more of a question what are you planning to do with PrimitiveDateTime.
Since you're deprecating I can assume that these methods are to be removed eventually?

PrimitiveDateTime itself will stay around. The methods that are deprecated are because they assume an offset of UTC, which is not clear from the method name or arguments.
OffsetDateTime is almost certainly what people need; PrimitiveDateTime is only for situations where it's not sensible to have an offset. The "direct replacement" depends on what you're trying to do! That's why it's deprecated in the first place.

I actually think assuming UTF offset as no offset was pretty sensible, but it is up to you I guess


EVCC HomeAssitant Addon - multiple ModbusProxy ports

Is your feature request related to a problem? Please describe.
I have two Invertes, each accessible via Modbus (TCP). Since both inverters only accept one client each I would like to use 2x ModbusProxy.
I use EVCC as addon installed in my HomeAssitant. Since I use HomeAssitantOS I can only use the "Configuration" page to manage the ports over which the container is accessible. Unfortunately this page only allow for ONE port only.
Describe the solution you'd like
Since I want to use two ModBusProxy instances I would need to specify a list of two ports.
Describe alternatives you've considered
None
Additional context
Add any other context or screenshots about the feature request here.

add Port 5201 https://github.com/evcc-io/hassio-addon/commit/4ca1da9b53329c2b01dcd6672b3c1d6a9ceabad7 && https://github.com/evcc-io/hassio-addon/commit/e7a5ad0f632175c988c4ee7ca61f4d9b47e6f362
@andig I believe that the dockerfile in evcc.io/evcc should be also adapted to two new ports 5200 and 5201

Dockerfile doesn‘t do anything 👍🏻

As a workaround I'm now using this fork of the ModbusProxy HA-Addon which can handle up to three devices
https://github.com/TCzerny/ha-modbusproxy

@Kugelfang666 if you reinstall evcc you should able to configure 2 ports [5200, 5201] in addon config. Pls hit three dor menu -> check for updates between the un- and installation. There will be no update, but ha will pull the latest file from https://github.com/evcc-io/hassio-addon.

thanks for looking into this and indeed I can confirm that I know have the additional field.
That being said. somehow I cannot get the ModbusProxy of EVCC working. I configured it in the evcc.yaml like this
modbusproxy:
  - port: 5200       #Port specified in the addon setting
    uri: <IP_ADDRESS>:502 #Inverter1
  - port: 5201       #Port specified in the addon setting
    uri: <IP_ADDRESS>:502 #Inverter2

meters:
  - name: pv_inverter_one
    type: template
    template: huawei-dongle-powersensor
    usage: pv
    modbus: tcpip
    id: 1
    host: <IP_ADDRESS>       # IP of my HomeAssitant
    port: 5200
    timeout: 15s

 - name: pv_inverter_two
    type: template
    template: huawei-dongle
    usage: pv
    modbus: tcpip
    id: 2
    host: <IP_ADDRESS>        # IP of my HomeAssitant
    port: 5201
    timeout: 15s

If I use the dedicated modbusproxy add-on in HomeAssitant (the one with multipel servers) and adapt the port on the cvcc config accordingly it now works

First: Did you take care, that nothing else out of Home Assistant is using these ports?
Second: In Meter config you have to enter the ip adress and ports (.144/502 & .179/502) of the invertersor <IP_ADDRESS> since evcc is taking care about the evcc internal proxying of the connections.

First: Did you take care, that nothing else out of Home Assistant is using these ports?
Second: In Meter config you have to enter the ip adress and ports (.144/502 & .179/502) of the inverters or <IP_ADDRESS> since evcc is taking care about the evcc internal proxying of the connections.

That did the trick, to be honest, it felt a bit wrong that I had to specify the inverters as if there would be no proxy. My naive assumption was that I have to specify the IP and Ports on the same machine. Maybe something worth pointing out in the docu!
Anyway I can confirm it's working now. Thanks a lot for the fast response!

BTW any way to check if the communication is now really going via the proxy and not directly to the Inverter?

If you have a proxy user outside of evcc and shut evcc down, no com should be able. Inside evcc there is no way (which I know) to see which com is used.
Wireshark could help here, but I think there is no need, since it is working.


Consolidate implementation into files, or implement an amalgamation step?

In the spirit of making vendoring simpler for users, I'm wondering what we can do to reduce the total number of files in the project. In very large projects that are intending to be vendored (like DuckDB or SQLite), they implement an amalgamation that does a topological sort of dependencies and stitches together all the files to create one big header and one big compiled file.
I see two different approaches here:

Do all the implementation work in a single .C file (or a few .C files) and try to make it as brief as possible
Implement an amalgamation similar to DuckDB or SQLite.

If you look at https://github.com/nanopb/nanopb, there are 4 headers and 3 .C files. Do you think we could get closer to that?

That seems odd that VSCode would struggle with large files (should this be reported as a bug?). It does not seem like a reason to compromise the design of the library.


Shutdown hook for conductor workers

Hey,
I am going through the conductor Java client and it seems that there is no function to gracefully shutdown the polling. I was wondering if adding a shutdown() method to stop polling is good idea ?
This shutdown method can be called by the worker in it's shutdown hook during deployments or other graceful shutdowns.
It will also be useful if we want to dynamically add a new worker in the task coordinator without restarts. We can shutdown the old coordinator and start a new coordinator.
Please let me know if this is a good idea. I will be interested in submitting a pull request for the same.

@mudit3774 . It is an excellent idea in my opinion. This would be a good start
We don't want for the workers to poll indefinitely and put more load on the server. Ideally the workers should work like lambda functions. Do the work and gracefully shutdown the coordinator.
The better approach would be push tasks to the registered workers instead of polling indefinitely.  NIO http APIs may help with push design. This is a research

Thanks for the response @jvemugunta. I will work on the PR.
That is the idea. If we can shutdown the coordinator, a small worker manager should be able to achieve optimizations like time scaling and lamda like functionality.
On push / pull, I am not very sure but think the idea of a poll model is to have a system responsible for the task at all times, either the server or the worker.

@mudit3774 Just saw your idea and code change, that's a good idea for me as well. But I have a question for a running poll service how we can get the running WorkflowTaskCoordinator then shutdown it? is that possible to get the coordinators by exist function or api? Or we should implement is by ourselves?

@JasperB : We have abstracted the workflow clients at our present organization. We wrote a small wrapper over the java client and we maintain a map of task and coordinator. We right now run 1 task in 1 coordinator. The wrapper shuts down the tasks coordinator when we need to stop a task or on worker shutdown. For me it was more of a high level construct. Let me know your thoughts.

@mudit3774 Thank you for the quick reply. It's helpful for us, we also have multiple tasks so we plan to implement the work group, for example several works regarding to one task in one coordinator, then all the coordinators construct in a map with task name as the key, then we can expose a api to shutdown it by task name.


'System-UI was stopped' if Bluetooth or GPS is turned off on specific Sony Devices

Describe the bug
If I turned on the "Risiko-Ermittlung", which works pretty fine, and turn Bluetooth off after that my device says 'System-UI was stopped' (originally "System-UI wurde angehalten"). After closing this message, everything except my wallpaper disappears. After a few seconds instead of my current wallpaper, a black screen is showing. How do I know that this is a black screen showing instead of my phone getting locked? I have a display overlay active which is visible at the whole time unless I lock my phone. Then again after a few seconds my current wallpaper is showing again. This procedure repeats all the time which ends in a loop of these actions which I can only escape if I restart my phone which I can still do with holding the power button and than selecting 'Restart' (originally "Neu starten"). After a restart, the whole loop just begins after a few minutes. I cannot do anything else like using the notification bar or getting feedback if I touch anywhere on my screen.
The weird thing is that seeing my wallpaper like that only happens if I restart my phone and then want to immediately use the pre-installed launcher of my phone which I does not use anymore so this is even more confusing.
Expected behaviour
By turning off Bluetooth it should just remind me in my notification bar that I turned off Bluetooth which is needed so that the app is working properly.
Steps to reproduce the issue

Turn "Risiko-Ermittlung" on
Turn off Bluetooth

Technical details

Sony Xperia Z2
Android 6.0.1

If any logs are needed, please let me know which logs you need and what I should do or connect to to create such logs.
Possible Fix
Since I do not know why it is behaving like that I am not able to suggest a fix.
Additional context

I already updated the Google Play Services as my device told me to do so.

EXPOSUREAPP-1855

After I turned off "Risiko-Ermittlung" for testing, I turned Bluetooth off again and now the System-UI did not crash / was not stopped.
Maybe if "Risiko-Ermittlung" is turned on but Bluetooth is not turned on, I think that something does not work properly as the Corona-Warn-App requires Bluetooth to be turned on. And I think that if something (Bluetooth) is missing that the app needs to work, the system results in a crash like stopping System-UI for some reason, right?

I've had the same issue with a Sony Xperia E5. I'm guessing that is has to do with the Google ENS API.  Maybe the Sony specific UI doesn't play well with this notification for some reason. But I could be totally wrong here.

Same behavior on Xperia Z3 Compact with Android 6.0.1.

I just got an Error 4000 while tryinig to reproduce this.
On my Huawei Mate 10 pro i only disabled Bluetooth and then an error popup was shown "4000". I clicked on details an a list of calls appears. Unfortunally i could not screenshot them to post here.

Same behavior on Xperia Z3 Compact with Android 6.0.1.

Can confirm. Same here.

@buergerapp please take a look at #712

Just a quick update: We will try to identify the issue in detail. We are seeing multiple issues on Sony devices related to this crash and think this is a device bug. We will update here once we have more information. The issue does not appear on specific model numbers. Also we do not see this specific issue outside of Sony Xperia devices.
Current known affected Devices:

Xperia Z2
Xperia Z3 (D6603 but not D5803)
Xperia Z3 Compact

Please add the  "Sony Xperia E5 (F3311) to the list (reported via email)

I have similar behavoir on
Xperia XZ1 (G8341)
Android 9
And I even have this problems when I dont have installed the warn app.
It seems to be a problem with the google services.
In the comments for the Corona App I found a statement from "Robert Koch Institut"

Dieser Fehler wird mit dem Update der Google Play Dienste behoben, welches gerade bei allen Android-Geräten ausgerollt wird (ENF 1.5)

But for me the problems still exist, even after updating the google services

Alcatel Handy 5026D seems to have the same issue, but stopping only after 14 days of working:

Ich besitze ein Alcatel Handy 5026D, knapp 2 Jahre alt.
Die Corona App habe ich am zweiten Tag der Ausgabe erstmals geladen.
Danach habe ich sie im Juli erneut geladen, mit der "verbesserten Version".
 "Feedback" geht offenbar an google, eine Nachricht, wie dort damit verfahren wird, erhalte ich nicht. Bei "App erneut öffnen" beginnt der beschriebene Zyklus erneut von vorne "Die App witd weiterhin > angehalten...usw.".
 Nach einigen Tagen dann "geringes Risiko" und nach 15 Tagen "Corona Warn wurde angehalten" .

Please add Sony Xperia XZ2 Compact Android 10

Same behavior on Xperia Z3 Compact with Android 6.0.1.
Can confirm. Same here.
Same with my mobile.

Just a quick update: We will try to identify the issue in detail. We are seeing multiple issues on Sony devices related to this crash and think this is a device bug. We will update here once we have more information. The issue does not appear on specific model numbers. Also we do not see this specific issue outside of Sony Xperia devices.
Current known affected Devices:
* Xperia Z2
* Xperia Z3 (D6603 but not D5803)
* Xperia Z3 Compact
* Xperia E5 (F3311)

In case the information would be beneficial: Due to GPS problems (gps.conf - some settings seems to be faulty) I rooted the phone* and only after that, the "System UI..." message with installed CWA appears.
*After extensive research - I am a normal mobile user/newbie, not a programmer.
Is there something I can contribute or test to help to solve the issue?

@Ste678, thanks for reporting. We will update the ticket for the developers with your information.
Best wishes,
DS

Corona-Warn-App Open Source Team

I have just checked the linked Jira issue.
Jira Ticket is flagged as:
Resolution: Wont Fix
Status: Obsolete
Unfortunately, no additional information was added to this Jira ticket.


Unofficial Hungarian Pack

There's an unofficial Hungarian pack which isn't showed in the website:
https://play.google.com/store/apps/details?id=com.anysoftkeyboard.languagepack.hungarian

Hello there @smnthermes, sorry for the delay, it seems I've missed this. Can you contact the developer so maybe we can make it an official language pack and then add it to the website?
Thanks in advance!


RS-323: Update pricing page

Remove time counters
Add text to say that it’s when they are ready to migrate
Add contact form on pricing page
Mention Promotion on landing page
Trigger chat automatically (after 5 seconds on pricing page)

Alright :) I'll merge then, the chat triggers only in production, and we can set it directly on Crisp.


Portuguese (pt_PT) translation update

To comply with current core WordPress translation and glossary.

:+1:


adding Boox notePro

Hi, there's my contribution, thanks for the project, I'm adding the Note Pro support (West Europe tablet)

Thanks!
Verified and merged.


--warn throwing 'find' error due to incorrect directory

When doing arkmanager restart @scorched --warn manually, it is throwing an error due to find using a hardcoded directory.
steam@dev:~/servers/arkonia_server/backup$ arkmanager restart @scorched --warn
Running command 'restart' for instance 'scorched'
<RichColor Color="1.00, 0.00, 0.00, 1">[Attention]</><RichColor Color="0.45, 0.63, 0.72, 1">Ark</>onia Scorched Earth will shutdown in <RichColor Color="0.45, 0.63, 0.72, 1">15</> minutes.\n\n<RichColor Color="0.45, 0.63, 0.72, 1">Reason</>\nRestarting
Command processed
There are 17 players connected
find: `/home/steam/ARK/server1/ShooterGame/Saved/Logs': No such file or directory

I do not use /home/steam/ARK/server1/ShooterGame/Saved/Logs in any config file.
It will reoccurringly throw this error when it's supposed to be doing the broadcast instead.
https://log1x.com/screenshots/2016-09-18_14-25-16_cOZW1.png here's a screenshot so you can see what I mean.
The issue appears to be on line 1275. Looks like you simply just forgot to change the absolute path to use the variable instead.

This was fixed in v1.6.01


With powershell terminal, this fails.

cmd: The term 'cmd' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
cmd is not defined inside powershell
and Visual Studio code uses powershell (Windows 10)

Hi,
Thank you for reporting this issue!
This should now been fixed with the v0.0.5 release (changelog).
Instead of using 'cmd' the extension will now use the absolute path to 'cmd.exe' ("C:\windows\System32\cmd.exe" by default, can be changed in the user settings).
Cheers,
Nils


Update to modern buildToolsVersion on Android

This adds support for e.g. Gradle 2.3.3, which has been required by some external React Native ecosystem packages.
Fixes #11

Thanks for your contribution!


Added support for Image component and dynamic import!

Added import for Image component nii (nextjs import Image)

Added usage for Image component nui (nextjs use Image)

added import for dynamic nid (nextjs import dynamic)

added usage for dynamic nud (nextjs use dynamic)

added usage for dynamic with named exports nudwne (nextjs use dynamic with named exports)

learn more about Image Component
learn more about Dynamic Import

@pulkitgangwar


Create an encode_headers! macro

@fribeiro1 was kind enough to make a macro for putting together a HeaderList. It's a relatively low-level one, however, in that it avoids doing any encoding for the developer in case that's not what (s)he wants. This is not necessarily the most common use case. It would be nice to have an encode_headers! macro which expects tuples of (key: &str, value: &str) and invokes Header::encode_key_value on each.
e.g.
let headers = encode_headers![
  ("accept-version", "1.2"),
  ("heart-beat", "0,0"),
  ("content-length", "0")
];

This has been added and will be included in v0.6.0. It was included as an overloaded version of header_list!, with keys and values separated by =>. e.g.
let headers = header_list![
  "key1" => "value1",
  "key2" => "value2",
  "key3" => "value3"
]


Bug: Tranfer results in conflicting transaction

Bug description
Transfering results in conflicting transaction with reason The unlock block signature is invalid
https://explorer.iota.org/chrysalis/message/d97e23df2aa3e0c18dcc54dff66e2a5a132df9acb66308d6870a198b588fd433
Version
https://github.com/iotaledger/wallet.rs/commit/7dac8876bf7ad4531f9afdc5c7d5182a3e95e438
Python Bininding
Hardware specification
What hardware are you using?

Operating system: Ubuntu 18
RAM: 8Gb
Cores: 4
Device: Lenovo Thinkpad

Steps To reproduce the bug
Explain how the maintainer can reproduce the bug.

Create account with:

client_options = {
    'node': 'https://api.lb-0.testnet.chrysalis2.com',
    'local_pow': True
}

acc = iota_wallet.AccountManager(storage_path='iotadb')
acc.set_stronghold_password("yolo")
acc.store_mnemonic("Stronghold")
newacc = acc.create_account(client_options)
newacc.alias("hot")
newacc.initialise()

Fund with https://faucet.tanglekit.de/
Transfer with:

acc = iota_wallet.AccountManager(storage_path='iotadb')
acc.set_stronghold_password("yolo")
acc.store_mnemonic("Stronghold")
myacc = acc.get_account("hot")
myacc.sync().execute()

transfer = iota_wallet.Transfer(
    amount=1000000,
    address='atoi1qrsy0r77qdfps6yfrzq57eahnlcdtwmh6869ctn4pvr9e8y5luhv7z4dmxr',
    remainder_value_strategy="ReuseAddress",
)

node_response = myacc.transfer(transfer)

print(node_response)

Expected behaviour
Transaction should be valid on tangle

Can you check if this isn't the same issue as https://github.com/iotaledger/wallet.rs/issues/409 ?


replace polling with websocket

As discussed in forum, I removed the polling and used only websocket instead.
Additional I added livetvtolaunch button
Rg
Dirk

Hello Dirk,
if the polling isn't used in your code can you also please remove the polling interval edit box in the admin page?

Hi Sebastian,
is done


Add TravisCI and AppVeyor integration

Like it says in the title, we should have a continuous integration setup for BinExport.
The IDA SDK as the only commerical prerequitise is already checked in in encrypted form, so implementing this change is not too much effort.

Done. appveyor.yml exists and produces the correct binaries. Still need to add build badge and artifacts.


Docker container file and usage.

Hi,
First of all, thanks for sharing this tool that makes debugging for LINE bot program so much easier. I really appreciate it!
To avoid environment problem, I made a Dockerfile for this project so that it can be used within the container and prevent potential environment issues. Furthermore, I updated the Readme file for the usage of container.
If you think this can help the project, feel free to modify the code and merge into your repo!

You know what? This is good idea. We way want to provide docker image too? :)

Hi @kenakamu,
Sorry, I found that I made a little mistake while writing Readme document. The image tag should not be camel case. The correct command is like below. Please help revise it.
docker image build --tag=linesimulator .
docker container run -d --rm -p 8080:8080 linesimulator

Sorry for your inconvenience, that's my fault.

oh, that's actually right. okay.


Check that there are no missing note commitment trees after deduplication

Motivation
Test that the note commitment tree deduplication format upgrade keeps all unique note commitment trees.
Possible Design

Find every height with a tree change
Check that the number of notes added to that tree equals the number of notes in the transactions of the block at that height

I tested this manually on my local machine. It took 2 hours and 40 minutes on my machine, and timed out at 3 hours in CI:
https://github.com/ZcashFoundation/zebra/pull/7629#issuecomment-1738463244
I don't think it is worth trying to automate this check at this time, because it is not that important.
If it becomes important to do these kinds of checks in future, we could diff a full sync and an updated state at the end of every full sync test. (But we'd have to write that code, too.)


data.incident_catalog_type

In case people want to reference catalog types by either their name or the type_name, this data resource allows them to do that.

Gonna get this in and cut a new release.