Play button not working after bringing app to foreground(iPhone 11, iOS 14.6)

Describe the Bug
When I pause a track, lock my screen on my iPhone 11(iOS 14.6) and then open the app again the play button doesn't work, nothing happens when I press it.
I get this error message:
2022-02-07 12:27:57.601921+0100 appname[1760:1305811] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Error when sending event: remote-duck with body: {
  paused = 1;
}. RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in RNTrackPlayer, even though it's inherited from RCTEventEmitter.'
 RCTCallableJSModules is not set. This is probably because you've explicitly synthesized the RCTCallableJSModules in RNTrackPlayer, even though it's inherited from RCTEventEmitter.'

Steps To Reproduce

Clone the example app
In package.json remove the postinstall npm script
In package.json change "react-native-track-player": "file:.." to "react-native-track-player": "2.1.2",
Install and run the app
Press the play button
Press the pause button
Lock the screen
Open the app again
Press the play button

Code To Reproduce
N/A
Environment Info:
System:
    OS: macOS 11.6.2
    CPU: (4) x64 Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz
    Memory: 71.57 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.18.1 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
    Android SDK: Not Found
  IDEs:
    Android Studio: Not Found
    Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
  Languages:
    Java: Not Found
  npmPackages:
    @react-native-community/cli: Not Found
    react: 17.0.2 => 17.0.2
    react-native: 0.65.1 => 0.65.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Track Player version: 2.1.2
Real device, iPhone 11
iOS version: 14.6
How I can Help
Might be able to dig deeper in the future if the maintainers aren't able to fix it and the client wants it.

I have the same problem.

@janlonden ,
I recently noticed some strange behaviour with the play/pause button in the example app caused by a missing dependency in a callback hook which I've fixed here. I believe this is the root of the issue you were seeing. I've attempted to reproduce this behavior with the fix I linked to you in place and everything works. I'm going to close this issue as I believe it to be the cause and I can't reproduce it.
If this doesn't solve your issue please:

Update to v2.2.0-rc3
Create a repo that demonstrates the issue you're seeing consistently.

Hi @jspizziri ,
as you can see below I still have the issue.
Could I grant you access to my repo (private) for you to try to find the issue?

@iboxgithub , can you please try to reproduce it with the example app?

unfortunately I can't :(
it must be something related to the OS (MacOS in my case) but can't see what despite looking for it...tbh I saw several people having this issue so there is definitely something to dig in... I know it's annoying without being able to reproduce it on your environment... if you want I am totally down to do a video call with remote access to try to resolve this once and for all..cause tbh it's a bit scary as I would like to push an app in Production with this lib...and I don't know why/how the behavior could have changed...

@jspizziri I just found a way to make the app work again, the issue is gone (no clue) how: I reinstalled the app on my simulator (so I deleted it then ran expo run:ios again)
so, good for my dev environment but still a bit scary for when I will want to deploy live as app updates over the air won't solve the issue and I would definitely have to ask customers to delete then re-install the app :(
With that in mind: would you (or someone else for the team) be up for a live debug when this happens again? in order to strengthen the lib

@iboxgithub I'm open to live debugging it if it happens again (assuming that it happens at a time that I'm available).

I don't unfortunately (otherwise I would have posted it here I know it's WAY easier). The only thing I can do now is to use 2 of my commits to reproduce it (I can still give you the instructions on how I reproduce it locally, will have to grant you access to a private repo)

Hit this issue in my production app just yesterday, running<EMAIL_ADDRESS>Don't know how it was hit, but it's definitely still happening:

@jspizziri : although I don't have a reliable repro yet (much less in the example app, since this likely takes a confluence of things to make happen), should we potentially keep this issue open, since it's still a real issue that's being hit in the wild on the 3.2.0?


Unknown media on landing

What happened?
not showing media on landing
Please reproduce in steps
go on https://rmrk2.kodadot.xyz
Expected Behavior
show pics
What browsers are you seeing the problem on?
Chrome
At which address did you encounter bug?
beta.kodadot.xyz
Are you logged in?
No
Which wallet you are using?
No response
Screenshots

Relevant log output
No response
Payment link for reward
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you plsease send a link to any of the NFTs?

https://canary.kodadot.xyz/rmrk2/gallery/15784641-90c6619c6b94fcfd34-EVRLOOT_RESOURCES-OLD_ROPE-48
in strip under seems same

https://canary.kodadot.xyz/bsx/gallery/3030053998-2
cc @kodadot/internal-dev

This is normal png
We are working with @preschian on new image gateway, to have less edge cases

This is normal png
We are working with @preschian on new image gateway, to have less edge cases

yes

canary.kodadot.xyz/bsx/gallery/3030053998-2
cc @kodadot/internal-dev

But, in this case, it is a different root cause. this is because that component renders based on type attributes from metadata

link
type attributes on metadata
metadata

https://canary.kodadot.xyz/bsx/gallery/3030053998-2
type": "application/octet-stream"
https://image-beta.w.kodadot.xyz/ipfs/bafkreidn66nnudrhzfoblnri2ld272j4fnjmxuiaxodsl525rzlelssjeq

https://canary.kodadot.xyz/bsx/gallery/3030053998-9
type": "image/jpeg"
https://image-beta.w.kodadot.xyz/ipfs/bafkreie3ym2two2uzh26cwp4mixrenr6ify2da5k7cv6sampaj3lqlqbzy

So with highest probability I would guess this is a non-working <model-viewer>
cc @prury is this your NFT ?

So with highest probability I would guess this is a non-working <model-viewer>

that was the actual image
that nft metadata
media: https://cloudflare-ipfs.com/ipfs/bafkreifahjdjerrz65puqznmsu2acoktrxjbo3vvp2f2j4eb7h5tc345fi
animatedMedia: https://cloudflare-ipfs.com/ipfs/bafkreibmoyo6e7nasyzp7wo6v4zbvqg4p5j6x6mvlpm6sbvog2o4cwpoia

@vikiival
created by me owned by @prury

hi @daiagi, is it possible to upload a new item again with this metadata?
set the type attribute to image/jpeg
but, image attributes is other than jpeg or static image, maybe 3D
{
  "name": "Lorem Ipsum",
  "description": "Lorem Ipsum",
  "image": "ipfs://ipfs/cid", // actual content is not jpeg
  ...
  "external_url": "https://kodadot.xyz",
  "type": "image/jpeg" // set this as jpeg
}

Sorry @preschian I don't understand what you ask of me
I minted this nft on kodadot while testing something
I can create another one, but how can I specify the mime type?

Sorry @preschian I don't understand what you ask of me
I minted this nft on kodadot while testing something
I can create another one, but how can I specify the mime type?

its ok
so, it means you didnt aware that your item metadata https://image-beta.w.kodadot.xyz/ipfs/bafkreidn66nnudrhzfoblnri2ld272j4fnjmxuiaxodsl525rzlelssjeq is being set to application/octet-stream?

No I wasn't aware, and it could be that it was minted while the app had a bug.
I was minting it while building  and debugging massmint I think
I think we should find out if there are others like this one, with faulty type


Matrix.cs line 31 has coordinates reversed

I believe it should be
 mat[j][i] = values[j][i];

instead of
 mat[i][j] = values[i][j];

In this case, i has been chosen to represent columns and this matrix implementation is row-first.

Good catch! See the attached commit for my preferred fix, that would have had an out of bounds error for a non-square matrix (and also would have been transposing the input matrix if it is square)


codeql: 2.8.2 -> 2.8.5

Description of changes

update: v2.8.2 to v2.8.5
bugfix: support codeql database creation on nixos linux64 by swapping out the binary packaged java distribution for the nixos jdk11 distribution

The existing nixpkgs codeql package performs a sed operation to set a static path to nixpkgs jdk11 for the main codeql executable. However there are many other executables that need to be able to resolve a functioning java home inside the codeql binary distribution, including database extractors and autobuilders and they also depend on CODEQL_DIST and CODEQL_PLATFORM to resolve java home.
This update swaps out the codeql java distribution in its entirety by symlinking against nixpkgs jdk11 as well as enabling the autopatchElfhook such that all database extractors and autobuilders actually function on nixos. This means CODEQL_DIST and  CODEQL_PLATFORM are consistently correct for all binary dependencies inside the codeql distribution.
Prior to this update you could only use codeql main commands, i.e. run queries. This version of the package also enables you to create new databases.
Known issues:
The csharp extractor depends on an old version of libttng-ust (.so.0), nixpkgs currently ships a more modern version (.so.1), which makes autopatchElf fail against the csharp extractor. This means csharp extraction currently does not work on nixpkgs codeql.  This update ignores this dependency failure. All other extractors and autobuilders patch and function correctly. Once the codeql csharp extractor updates to a more recent libttng-ust dependency in a future release, this will automatically resolve itself.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

please rebase

Closed by #168228.


[BUG]: Eigen integration silently fails with recent versions of Eigen

Problem description
When I build the following simple nanobind module with the current master branch of Eigen:
#include <nanobind/nanobind.h>
#include <nanobind/eigen/dense.h>

namespace nb = nanobind;

NB_MODULE(nanobind_example_ext, m) {
    using Matrix = Eigen::Matrix<int, 1, 1>;
    m.def("add", [](Matrix a, Matrix b) { return a + b; });
}

The output of calling:
import numpy as np
nanobind_example.add(np.int32([0]), np.int32([0]))

is array([17726950], dtype=int32) instead of the expected array([0], dtype=int32).
This can be fixed by adding a return type:
-     m.def("add", [](Matrix a, Matrix b) { return a + b; });
+     m.def("add", [](Matrix a, Matrix b) -> Matrix { return a + b; });

and the example above works properly using the last stable release of Eigen, so I expect it has something to do with a change in the type produced by the addition. Unfortunately I don't know enough about the nanobind (or Eigen!) internals to know where to start debugging this, but I wanted to check here if this was an expected sharp edge, or if this is something that should work.
I note that I originally came across this issue when I discovered a test failure here:
https://github.com/wjakob/nanobind/blob/f3e2796d7bd12f77856eef53772644115a5e8788/tests/test_eigen.py#L303-L305
which has this same syntax.
Reproducible example code
#include <nanobind/nanobind.h>
#include <nanobind/eigen/dense.h>

namespace nb = nanobind;

NB_MODULE(nanobind_example_ext, m) {
    using Matrix = Eigen::Matrix<int, 1, 1>;
    m.def("add", [](Matrix a, Matrix b) { return a + b; });
}

import numpy as np
assert nanobind_example.add(np.int32([0]), np.int32([0])) == 0

I can't reproduce this issue on my machine. What version of Eigen are you using? What OS is this on?

I did sme more checking to see if there could be an issue involving ownership management: the expression caster turns the addition expression into a Eigen::Array<int, 1, 1, 0, 1, 1> and then uses the rv_policy::move RVP to convert it into a Python object. Since the array only encapsulates a small amount of memory, nanobind downgrades this to rv_policy::copy and creates a new NumPy array containing a copy of the result. It all looks good to me, so I don't understand the issue.
The CI also hasn't had shown any failures here in the last months. Could it be that there is a problem on your end? If this is truly a nanobind bug, could I ask you to make a PR that causes a failure to help reproducibility on my end?

Thanks for looking into this! I'm seeing this on my macbook with commit 44b16f48cb5c5e7b9f5ed2b4d6a14ed14ab302e1 of Eigen (the current tip of the master from https://gitlab.com/libeigen/eigen). The original error showed up in our internal CI at Google with an upgrade of Eigen to commit 2d4c9b400cca33d2f5cf316efc7151236244edb1 (the nanobind test10_eigen_scalar_default started failing then).
Let me try bisecting Eigen to see if I can narrow down when this occurred. I'll report back ASAP with more info. Thanks!

Bisecting was actually fast! It looks like the offending Eigen commit actually is 2d4c9b400cca33d2f5cf316efc7151236244edb1. I'm happy to open a PR using this Eigen commit to try to reproduce in CI if that would be helpful.

One possibly relevant thing is that both Google's CI and your macbook likely use clang as a compiler.
I tried to reproduce the same failure on my Linux machine with Eigen from master and was unable, but perhaps I didn't get the compiler stars to align right.

I expect @hawkinsp is right here! I've opened https://github.com/wjakob/nanobind/pull/749 demonstrating the issue in CI, and everything works fine using GCC on Ubuntu, but fails on macOS with clang. Hopefully this can be illuminating as to what's going on here!


Playlist download stopping and limit on playlist start of 999

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

WARNING
All the invalid issues will be rejected!!

Before going further

If your problem is a bug with the youtube-dl program or a request for new site support please report it here

Make sure you are using the latest youtube-dl-gui version: Options > About tab. If it's not please download & install the latest version for your OS and check if your issue still persists

Make sure you are using the latest youtube-dl version: Click the Update button on the main screen and check if your issue still persists

Make sure you searched the bugtracker for similar issues including closed ones

[x] I assure that my problem is NOT with youtube-dl
[x] I've verified and I assure that I'm running youtube-dl-gui 0.3.8
[x] I assure that i am using the latest version of youtube-dl
[x] Searched bugtracker

What is the purpose of your issue?

[x] Bug during the download process (encountered problems after hitting the Download button)
[ ] Bug other (encountered other problems with youtube-dl-gui)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Please remove the following section between the (---) if your problem does not belong to the bug during the download process category
Provide the full verbose output as follows:

Add -v flag to Options > Commands tab
Re-try to download the URL
Go to Options > Log tab and click the View Log button
Copy the whole content of the log file and insert it between the triple ``` part

WARNING: Requested formats are incompatible for merge and will be merged into mkv.
ERROR: requested format not available
ERROR: requested format not available
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: unable to extract uploader nickname
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
WARNING: unable to extract uploader nicERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
ERROR: requested format not available
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
ERROR: Unable to extract sources; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Falling back on generic information extractor.
WARNING: Falling back on generic information extractor.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: unable to extract uploader nickname
ERROR: Error in output template: unsupported format character 'V' (0x56) at index 30 (encoding: 'cp1252')
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
ERROR: unable to rename file: [WinError 183] Cannot create a file when that file already exists: 'F:\\[YouTube Video Downloads]\\egolei lei\\ \u30002017_1_8.f135.mp4.part-Frag235.part' -> 'F:\\[YouTube Video Downloads]\\egolei lei\\ \u30002017_1_8.f135.mp4.part-Frag235'
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
Usage: youtube-dl.exe [OPTIONS] URL [URL...]
[debug] System config: []
[debug] User config: []
[debug] System config: []

Please remove the following section between the (---) if your problem does not belong to the first two categories (bug report)
What operating system do you use ?
Windows 10
List of actions to perform to reproduce the problem:

Download a large play list from Youtube.com. The list i'm trying to grab has 2600+ videos. (https://www.youtube.com/playlist?list=UU1X5fwXl8zUSR-E9igZ5jfQ)

What is the expected behaviour ?
I would expect for YouTube-DLG to run through the playlist and grab each file going down the line.
What happens instead ?
The program downloads 70-170 videos and stalls out. If i stop and start it it will Pre Process them till it hit the same number as before.
Here is an image of what it looks like. http://i.imgur.com/t8WtLbU.png
I have found a workaround though. I began increasing the start number for the playlist each time it would stall out, -2 videos to cover overlap. It would then start up again and go for a while till it stalled out.
I wouldn't even be submitting this ticket if I didn't run into the issue of a 999 limit for the start number of a playlist.
I opened up the .json file and manually edited the starting number. When I started Youtube-DLG it was reduced back to 999 each time.

I'm not sure what you can do about the playlist download stopping. But it seems that raising the limit for a playlist start number would be fairly easy.

The playlist limit on the new UI is now 9999, but a new release is not yet available.
Regarding the issue with the playlist, is that the whole log content?
It seems that the youtube-dl debug output is truncated and also, that usage message in the log file seems pretty weird.

That is the whole log. When the program gets stuck in pre processing it never errors out. It just stalls. I have started to use --datebefore/--dateafter so that I can continue my hording. The same issue still happens with the downloads just stalling after 60-170 completed files.
For me, as long as I can change the start number to over 999 I can deal with this issue.

Can you do the following?

Go to Options > Log tab and clear the log file
Go to Options > Commands and add this: --skip-download
(You should now have the -v and --skip-download flags under the commands field)
Try to re-download the playlist URL and let it finish
Go to Options > Log tab, click view log and paste the log content here

Taking a quick guess here, but you can also try this build: latest portable (Feb 15 2016). Just remember to clear the -v and --skip-download flags under the commands field before trying to download your playlist. If this build works then it's an known issue which is already fixed.

I'm currently working on trying to recreate the error. I have two instances of youtube-dlg running on two different playlists. The same issue has been present on every playlist that was large enough.
I will report back as soon as the error repeats.

95% sure that it's the same issue with https://github.com/MrS0m30n3/youtube-dl-gui/issues/49, which makes sense due to the large playlist size.

...the subprocess module was deadlocking due to the large amount of ffmpeg output in the stderr pipe which had as a result to freeze the download process...

Also, it's not a coincidence that your issue is 149 and the old one is 49, that's a sign!!! :P

Lol 149 & 49. Nice.
I started a new playlist of 415 videos to test the settings. Adding the --skip-download seems to be just running through all the videos on pre processing without actually downloading anything.
Also, after adding the --skip-download I was forced to use login credentials for youtube. This was an issue at first because there isn't any way to input a verification code into YTDLG from a txt msg. I just ended up using one of my dummy gmail accounts to continue.

Just download the portable version mentioned above and everything should work fine.

already downloaded it. I will give it a try.

I just wanted to do say thank you for helping me out. It is awesome of you to have created this fork and to actually be supporting it.

The latest portable worked fine, right? If so, please close this issue.
Unfortunately, the latest installer build points to an outdated version which has a lot of bugs.
Hope i will be able to release 0.3.9 by the end of this month.

I was waiting till tonight to report back.
I have downloaded a ton of content on long playlists and didn't have a single issue.
Thank you again for all your help.


Memory leak in the once()/off(). Event not unbound

Framework7 version: 3.6.6 (and 4.0.1 seems have that bug also)
Any platform

Describe the bug
Memory leak happens when event  bound with once() and then unbound with off(). Event handler will not unbound.
To Reproduce
Run the kitchen-sink and watch for the memory allocations  in the Chrome devtools. When open and close the "Photobrowser" component several times you will see multiple objects which have pointers to 'swipeBackMove'.
Expected behavior
Event handler unbound and removed
Actual Behavior
I seen this in the framework7-3.6.6/packages/core/js/framework7.js (line 6792)
    function onModalLoaded() {
      // Create Modal
      var modal = app[modalType].create(modalParams);
      modalRoute.modalInstance = modal;

      var hasEl = modal.el;

      function closeOnSwipeBack() {
        modal.close();
      }
      modal.on((modalOrPanel + "Open"), function () {
        if (!hasEl) {
          // Remove theme elements
          router.removeThemeElements(modal.el);

          // Emit events
          modal.$el.trigger(((modalType.toLowerCase()) + ":init " + (modalType.toLowerCase()) + ":mounted"), r
          router.emit(((!isPanel ? 'modalInit' : '') + " " + modalType + "Init " + modalType + "Mounted"), mod
        }
        router.once('swipeBackMove', closeOnSwipeBack);
      });
      modal.on((modalOrPanel + "Close"), function () {
        router.off('swipeBackMove', closeOnSwipeBack);
        if (!modal.closeByRouter) {
          router.back();
        }
      });

Event bound with router.once('swipeBackMove', closeOnSwipeBack) but failed to unbind in router.off('swipeBackMove', closeOnSwipeBack);
It happens because .once() create a wrapper function which bound with .on() and when router.off('swipeBackMove', closeOnSwipeBack); searches for closeOnSwipeBack() it does not found it and not unbound.
Screenshoot

Fixed in latest 3.x and 4.x, should be better now


The setting of a function does not work properly.

If you get a element with getElm or getQuery and the element already has the text function it just pastes the definiton of the new function (See image)

Fixed with commit 6382973


Add Software Bill of Materials task for JS

Fixes #minor
Description
Need "software bill of materials" for our public facing products, per Presidential Executive Order.
Specific Changes
Task 'Generate Software Bill of Materials' added to nightly packaging build.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 84.543%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19660

Relevant Lines:
22028

💛  - Coveralls

/azp run Run-JS-Functional-Tests-BrowserBot-yaml


add balena-os-in-container worker

This adds a new worker that lets tests run on a balena-os in container device: https://github.com/balena-os/balenaos-in-container
You can use a saved docker image file, such as the ones generated by yocto jenkins jobs (balena-image.docker) to create a balenaos-in-container for that os version.
To run it, you can clone this branch, and run make container, then you can run the cloud test suite with it (with some modifications, such as commenting out preloading parts, and adding a line to write the config.json this required by the os-in-container tool)
Change-type: minor
Signed-off-by: Ryan Cooke<EMAIL_ADDRESS>

Can one of the admins verify this patch?


Add support for DuckDB #30

From @b-per https://github.com/AxelThevenot/dbt-assertions/pull/30

This is built on top of the other PR with integration_tests
It adds support for DuckDB and does some minor refactoring of some logic.
integration_tests results
Tests are passing for BQ, Snowflake and DuckDB
❯ sh run_test.sh
--- Running DuckDB ---

14:04:36  Running with dbt=1.7.4
14:04:36  Registered adapter: duckdb=1.7.1
14:04:36  Found 3 models, 1 test, 0 sources, 0 exposures, 0 metrics, 407 macros, 0 groups, 0 semantic models
14:04:36
14:04:36  Concurrency: 1 threads (target='duckdb')
14:04:36
14:04:36  1 of 4 START sql table model main.d_site ....................................... [RUN]
14:04:36  1 of 4 OK created sql table model main.d_site .................................. [OK in 0.10s]
14:04:36  2 of 4 START sql table model main.d_site_test .................................. [RUN]
14:04:36  2 of 4 OK created sql table model main.d_site_test ............................. [OK in 0.04s]
14:04:36  3 of 4 START sql table model main.downstream_model ............................. [RUN]
14:04:37  3 of 4 OK created sql table model main.downstream_model ........................ [OK in 0.04s]
14:04:37  4 of 4 START test dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [RUN]
14:04:37  4 of 4 PASS dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [PASS in 0.04s]
14:04:37
14:04:37  Finished running 3 table models, 1 test in 0 hours 0 minutes and 0.34 seconds (0.34s).
14:04:37
14:04:37  Completed successfully
14:04:37
14:04:37  Done. PASS=4 WARN=0 ERROR=0 SKIP=0 TOTAL=4

--- Running Snowflake ---

14:04:39  Running with dbt=1.7.5
14:04:40  Registered adapter: snowflake=1.7.1
14:04:40  Unable to do partial parsing because of a version mismatch
14:04:41  Found 3 models, 1 test, 0 sources, 0 exposures, 0 metrics, 446 macros, 0 groups, 0 semantic models
14:04:41
14:04:44  Concurrency: 4 threads (target='snow')
14:04:44
14:04:44  1 of 4 START sql table model dbt_bperigaud.d_site .............................. [RUN]
14:04:44  2 of 4 START sql table model dbt_bperigaud.d_site_test ......................... [RUN]
14:04:46  2 of 4 OK created sql table model dbt_bperigaud.d_site_test .................... [SUCCESS 1 in 2.08s]
14:04:46  3 of 4 START test dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [RUN]
14:04:46  1 of 4 OK created sql table model dbt_bperigaud.d_site ......................... [SUCCESS 1 in 2.18s]
14:04:46  4 of 4 START sql table model dbt_bperigaud.downstream_model .................... [RUN]
14:04:48  3 of 4 PASS dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [PASS in 1.60s]
14:04:48  4 of 4 OK created sql table model dbt_bperigaud.downstream_model ............... [SUCCESS 1 in 2.07s]
14:04:48
14:04:48  Finished running 3 table models, 1 test in 0 hours 0 minutes and 7.74 seconds (7.74s).
14:04:48
14:04:48  Completed successfully
14:04:48
14:04:48  Done. PASS=4 WARN=0 ERROR=0 SKIP=0 TOTAL=4

--- Running BigQuery ---

14:04:50  Running with dbt=1.7.5
14:04:51  Registered adapter: bigquery=1.7.2
14:04:51  Unable to do partial parsing because config vars, config profile, or config target have changed
14:04:51  Unable to do partial parsing because a project dependency has been added
14:04:52  Found 3 models, 1 test, 0 sources, 0 exposures, 0 metrics, 463 macros, 0 groups, 0 semantic models
14:04:52
14:04:54  Concurrency: 4 threads (target='bq')
14:04:54
14:04:54  1 of 4 START sql table model analytics.d_site .................................. [RUN]
14:04:54  2 of 4 START sql table model analytics.d_site_test ............................. [RUN]
14:04:56  2 of 4 OK created sql table model analytics.d_site_test ........................ [CREATE TABLE (3.0 rows, 0 processed) in 2.86s]
14:04:56  3 of 4 START test dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [RUN]
14:04:57  1 of 4 OK created sql table model analytics.d_site ............................. [CREATE TABLE (3.0 rows, 0 processed) in 2.99s]
14:04:57  4 of 4 START sql table model analytics.downstream_model ........................ [RUN]
14:04:58  3 of 4 PASS dbt_assertions_generic_assertions_basic_test_example_d_site_exceptions__site_id_is_not_null__True  [PASS in 1.55s]
14:05:01  4 of 4 OK created sql table model analytics.downstream_model ................... [CREATE TABLE (2.0 rows, 168.0 Bytes processed) in 4.04s]
14:05:01
14:05:01  Finished running 3 table models, 1 test in 0 hours 0 minutes and 8.70 seconds (8.70s).
14:05:01
14:05:01  Completed successfully
14:05:01
14:05:01  Done. PASS=4 WARN=0 ERROR=0 SKIP=0 TOTAL=4

@b-per  I closed the last Pull Request and I invited you to collaborate on this repository if you want
You'll be autonomous to merge this Pull Request :)

I added an other test thanks to you integration_tests project (thank you again!)
And I added an optional variable to change the default exceptions column name used by the package


Problem expanding in .Files.Glob().AsConfig

Output of helm version:
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-12T14:26:04Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.1", GitCommit:"d4ab47518836c750f9949b9e0d387f20fb92260b", GitTreeState:"clean", BuildDate:"2018-04-12T14:14:26Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
kubeadm-dind cluster with 2 nodes.
There is some strange behaviour when expanding config files into a ConfigMap. I have this template:
apiVersion: v1
kind: ConfigMap
metadata:
    name: {{ .Release.Name }}-log-config
data:
{{ (tpl (.Files.Glob "cfg/log4j-*").AsConfig . ) | indent 2 }}

and this values.yaml:
[snip]
system:
  logserver: 31000
[snip]

Now in a file log4j-standard.xml I have this snippet somewhere
[snip]
		<!-- Log Messages will be sent to the central Log Server -->
		<WamasSocket name="socket-appender" host="{{ .Release.Name }}-settings-server" port="{{ .Values.system.logserver }}">
			<SerializedLayout />
		</WamasSocket>
[snip]

helm template . (and helm install --dry-run . the same) always gives me:
Error: render error in "wamas-helm/templates/cfg-test.yaml": template: wamas-helm/templates/cfg-test.yaml:6:4: executing "wamas-helm/templates/cfg-test.yaml" at <tpl (.Files.Glob "cf...>: error calling tpl: Error during tpl function execution for [snip] </Loggers>\\n\\n</Configuration>\\n\"\n": parse error in "wamas-helm/templates/cfg-test.yaml": template: wamas-helm/templates/cfg-test.yaml:182: unclosed action

If I move the logserver definition out of the system interface to the top-level of values.yaml and adapt the expansion in the .xml file accordingly, it works as expected.
I have also tried to use with, both in the ConfigMap template YAML, as well as directly inside the log4j-standard.xml file to no avail. I also tried to pass a different context than . to tpl, which results in a different error message (Error: render error in "wamas-helm/templates/cfg-test.yaml": template: wamas-helm/templates/cfg-test.yaml:7:4: executing "wamas-helm/templates/cfg-test.yaml" at <tpl ($.Files.Glob "c...>: error calling tpl: Cannot retrieve Template.Basepath from values inside tpl function: [snip] </Loggers>\n\n</Configuration>\n"  (BasePath is not a value)

Did you figure out the solution to this? I'm having the same error.

Unfortunately not...

This might be related to the issue I found: https://github.com/helm/helm/issues/5446
Hope this helps.

apiVersion: v1
kind: ConfigMap
metadata:
    name: {{ .Release.Name }}-log-config
data:
{{ tpl (.Files.Glob "cfg/log4j-*").AsConfig $ | indent 2 }}

Just replace . with $ in the second argument for tpl
Also there's one more trick:

_helpers.tpl

{{/* tpl won't work here for each value because global scope is not available inside the template and Template.Basepath can't be recieved, but we can cover the entire result with "tpl" function */}}
{{- define "annotations" -}}
{{- range $k, $v := . }}
{{ $k | quote }}: {{ $v | quote }}
{{- end -}}
{{- end -}}

ingress.yaml

apiVersion: extensions/v1beta1
kind: Ingress
  annotations:
    # tpl works here as a wrapper around the entire template
    {{ tpl (include "annotations" .Values.annotations) $ | toYaml | indent 4 }}

values.yaml

annotations:
  customLabel.local: "A test long annotation with special characters ~!@#$%^&*(_+."

Closing as answered. Thanks!


[Bug Report] libxml2 and libxslt are not installed by default for 22.04 docker requirements

Describe the bug
For 22.04 Dockerfiles, libxml2 and libxslt are not installed by default, causing an error during ./create_venv installation.
To reproduce

After building the docker images, clone the TT-Metal repository at root directory
Set environment variables

export ARCH_NAME=grayskull
export TT_METAL_HOME=/tt-metal
export PYTHON_PATH=/tt-metal

Run the following command

./create_venv

Expected Behaviour
Virtual environment should be succesfully created without any errors.
Error
root@eb3f60526a10:/tt-metal# ./create_venv.sh
Creating virtual env in: /opt/tt_metal_infra/tt-metal/python_env
...
Collecting lxml==4.9.4
  Downloading lxml-4.9.4.tar.gz (3.6 MB)
     |████████████████████████████████| 3.6 MB 8.4 MB/s
    ERROR: Command errored out with exit status 1:
     command: /opt/tt_metal_infra/tt-metal/python_env/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-6jh1ewwv/lxml/setup.py'"'"'; __file__='"'"'/tmp/pip-install-6jh1ewwv/lxml/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-itaf3txn
         cwd: /tmp/pip-install-6jh1ewwv/lxml/
    Complete output (3 lines):
    Building lxml version 4.9.4.
    Building without Cython.
    Error: Please make sure the libxml2 and libxslt development packages are installed.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

For https://github.com/tenstorrent/tt-metal/issues/10469

@tt-rkim did you add something that required these dependencies recently?

Don't think so, could you send the full output so we can see where this requirement is coming from? @JushBJJ

@tt-rkim
Here: https://pastebin.com/raw/Hjg2Q00X
Did a little bit of testing just now, changing the pip version to 22.0.2 in ./create_venv.sh fixes the error while staying at pip v20.1.1  brings the error back. I originally suggested bumping the pip version of create_venv here https://github.com/tenstorrent/tt-metal/issues/11144#issuecomment-2307375188

I see - it's weird that a lower version of pip causes you to require these system dependencies. One thread of work we could check out to make sure we have the full picture is to use pipdeptree on installing the virtual env with those system libraries installed. Not that important though.
I've posted a longer comment here explaining the problem: https://github.com/tenstorrent/tt-metal/issues/11144#issuecomment-2318184316
tl;dr: it's to support editable install workflow, fix to unblock you guys may be to just check for ubuntu version and use higher pip version if >20.04

Should I remove libxml2-dev and libxslt-dev from the original PR for now and go forward with fixing #11859?

Should I remove libxml2-dev and libxslt-dev from the original PR for now and go forward with fixing #11859 only?

nah it's ok, we'll figure out why they're needed for 22.04 later

I see - it's weird that a lower version of pip causes you to require these system dependencies. One thread of work we could check out to make sure we have the full picture is to use pipdeptree on installing the virtual env with those system libraries installed. Not that important though.
I've posted a longer comment here explaining the problem: #11144 (comment)
tl;dr: it's to support editable install workflow, fix to unblock you guys may be to just check for ubuntu version and use higher pip version if >20.04

we should try cleaning out our pip dependencies, it's turning into a rat's nest

closing as this is now part of the 22.04 docker dependencies


Reset My Password - Bug fix

Previously, upon submitting the Reset My Password form, the user would be taken to a blank screen with a random string printed to the screen, as documented in this issue: https://github.com/gig-central/gig-repo-1/issues/92
Now, the reset password is written/updated in the DB, and the respective user receives an email with the new password,

Try to add a value to $config['encryption_key'] in your config file. Right now your's is probably just a empty string.
It should look like this:
$config['encryption_key'] = 'Your key will go here';
Thanks!


change progress-bar color and fix bug

I changed the color of the bar and fixed the bug that gif appears immediately.

Looks good!


[Regions] fix undefined on remove

Short description of changes:
Resolves #2712
The new contentEditable code was removing its listeners after the region element itself was already removed, so it threw.
This cleanup function wasn't actually necessary, as removing a parent element kills all its children's listeners too. So I just removed the on-remove handler.
I've also tweaked the remove button CSS a little to make it look nicer.
Breaking in the external API:
None.
Breaking changes in the internal API:
None.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 74.869%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
1232

Relevant Lines:
1562

💛  - Coveralls


ly

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71cfbf1a-c5b7-df0f-8194-6ebc03afcc7d
Version Independent ID: f36b567f-aa48-2c8f-4908-b1fe18cd2842
Content: Remote Desktop - Allow access to your PC
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/remote-desktop-allow-access.md
Product: windows-server-threshold
Technology: remote-desktop-services
GitHub Login: @lizap
Microsoft Alias: elizapo

Please close this ticket. It does not contain any useful information.

#please-close


Add popup-form component and infor popup sample

@nguyentien290401, please add some screenshots about the popup


Basic Auth and Password Strategies

Hi Daniel,
I've added a strategy for basic http authentication, seen here: https://gist.github.com/1337882.
The intention is to have a basic auth strategy for web services and a password strategy for the human web. The :default scope has [:password, :basic] for strategies.
This version works, except that not providing credentials never results in a 401, only wrong credentials. What would you recommend I do, create two 'unauthorized' routes, one for html and the other for json? Am I misunderstanding the use case?
I'd very much appreciate any insight you can bring.
Regards
Jamie

Hi Daniel,
I've gone ahead and added the dual fail route version to the original example gist: https://gist.github.com/1327195.
Does this look right to you?
Regards
Jamie

Here is an example of a split scope solution, where basic auth is running in the :api scope and html auth is running on :default: https://gist.github.com/1338190
Does this look right to you?

Were you able to get this fixed? I had a similar issue. I think the issue mostly has to do with the valid? method.
Here is a working version. https://gist.github.com/1691624


Correctly create the EFS share symlink on the XFCE desktop

🐛 Summary
The symlink to the EFS share that is being created on the XFCE desktop is borked.  The icon has a little lock on it, and @nickviola and other PCA assessors reported that they are unable to drag-and-drop files directly onto it.  I don't know exactly what is wrong with the symlink (the standard Linux permissions look OK, and lsattr adds no information), but I was able to verify the bug.  As a temporary workaround, one can double-click the symlink, which opens a file explorer window where files can be dragged-and-dropped.
The symlink is currently being created by xdg-autostart when the graphical environment is initialized.  Given that the symlink would also be useful from a terminal, I think it makes more sense to generate it via a systemd user service.  I will try this and see if it corrects the problem; I have vastly more control over a systemd use service than an xdg-autostart job.
To reproduce

Log into an XFCE desktop for any instance type in the COOL via Guacamole.
Try to drag any file onto the "Share" icon that is located on the XFCE desktop.
Observe that the attempted drag-and-drop/copy fails.

Expected behavior
I would expect the symlink to allow drag-and-drop.

Thanks for your help with this @jsf9k! Let me know if there is anything I can do to help.


popup_menu PopupMenuItem incorrect calculation of width step when spacing is used

Steps to reproduce
use PopupMenuItem with spacing inside
Expected results
size is enlarged
(Width of the menu is expanding in steps of 56 depending on the width of its children).
Actual results
size is not enlarged sometimes depending on text length and content is overflowing to a second line.
(calculation of the size from its children to select the right step does not work when spacing is used (see example), if i replace spacing with SizedBox of the same width, expanding to the next step is working).
Code sample
PopupMenuButton<MenuItem>(
     itemBuilder: (context) => [
             PopupMenuItem<MenuItem>(
                 height: 48,
                 value: MenuItem.deleteMessagesAll,
                 child: Wrap(spacing: 8, children: [
                   Icon(Icons.delete, color: colors.app_bar_text, size: 25),
                   Text("Delete message history",
                       style: const TextStyle(color: Colors.white, fontWeight: FontWeight.normal))
                 ])),
    ])

Screenshots or Video

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.9, on Ubuntu Noble Numbat (development branch) 6.6.0-14-generic, locale en_DE.UTF-8)
    • Flutter version 3.16.9 on channel stable at /home/bwahlen/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (3 weeks ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/bwahlen/android-sdk-linux
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /home/bwahlen/android-sdk-linux
    • Java binary at: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java
    • Java version OpenJDK Runtime Environment Temurin-17.0.10+7 (build 17.0.10+7)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /home/bwahlen/android-studio
    • Flutter plugin version 77.2.1
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version openjdk version "17.0.7" 2023-04-18

[✓] Connected device (2 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 14 (API 34) (emulator)
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 121.0.6167.184

[✓] Network resources
    • All expected network resources are available.

Hello @qeepcologne.
Thanks for filing this.
I can see an increase in the width i.e a wider width. Can you check with the sample below on your end as well

Default
with maxWidth

Code Sample

import 'package:flutter/material.dart';

/// Flutter code sample for [PopupMenuButton].

// This is the type used by the popup menu below.
enum SampleItem { itemOne, itemTwo, itemThree }

void main() => runApp(const PopupMenuApp());

class PopupMenuApp extends StatelessWidget {
  const PopupMenuApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: PopupMenuExample(),
    );
  }
}

class PopupMenuExample extends StatefulWidget {
  const PopupMenuExample({super.key});

  @override
  State<PopupMenuExample> createState() => _PopupMenuExampleState();
}

class _PopupMenuExampleState extends State<PopupMenuExample> {
  SampleItem? selectedMenu;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('PopupMenuButton')),
      body: Center(
        child: PopupMenuButton<SampleItem>(
          initialValue: selectedMenu,
          // Callback that sets the selected popup menu item.
          onSelected: (SampleItem item) {
            setState(() {
              selectedMenu = item;
            });
          },
          constraints:
              const BoxConstraints(minWidth: 2.0 * 56.0, maxWidth: 8.0 * 56.0),
          itemBuilder: (BuildContext context) => <PopupMenuEntry<SampleItem>>[
            const PopupMenuItem<SampleItem>(
              value: SampleItem.itemOne,
              child: Text('Item 1'),
            ),
            const PopupMenuItem<SampleItem>(
              value: SampleItem.itemTwo,
              child: Text('Item 2'),
            ),
            const PopupMenuItem<SampleItem>(
              value: SampleItem.itemThree,
              child: Text('Item 3'),
            ),
          ],
        ),
      ),
    );
  }
}

this is the max size, you need to add long items

issue updated


--export-keys is not compatible with the configuration cache

Steps to Reproduce
Run ./gradlew --export-keys with gradle/gradle repository
Expected Behavior
Builds suceeds, new keys are written
Current Behavior
Builds fails with over 9000 of configuration cache errors like Invocation of 'Task.project' by task ':architecture-test:compileArchTestGroovy' at execution time is unsupported.
Context
We fixed --write-verification-metadata mode, but --export-keys alone flew under radars. This mode causes all configurations to be resolved at the end of the build, materializing all tasks that contribute their outputs to these configurations. This is considered execution time, and task configuration code is not written to be execution-time compatible.
As a short-term workaround, we shouldn't use the configuration cache for --export-keys, just like we do not do that for --write-verification-metadata.
Your Environment
Build scan URL: https://ge.gradle.org/s/ptgiz3aldqgfw

Fixed in https://github.com/gradle/gradle/pull/24480


WIP: Clone external repositories

Zarp-cli relies on other github repositories, such as zarp. Those need to be available for successful execution.
This PR includes a new class in the module zarp.config.init that clones repos as submodules. See also the more comprehensive documentation of git submodules.
Fixes #22
A simple test was added, but the functionality of downloading and preparing new repos is not yet tested.
I manually ran the code and successfully cloned zarp into a directory of my choice submodules/zarp. However, addition as test was more complicated, as some files and directories need to be deleted and use of temporary directory does not work with submodules.
In particular, .gitmodules, .git/modules/ and the repo itself should be torn down after test.
Remaining issues:

[x] error handling
[ ] Mock cloning (or actual cloning with proper teardown)
[ ] installation of submodules dependencies (e.g. pandas for zarp execution)

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] Documentation update

Checklist
Please carefully read these items and tick them off if the statements are true
or do not apply.

[x] I have performed a self-review of my own code
[ ] My code follows the existing coding style, lints and generates no new
warnings
[x] I have added type annotations to all function/method signatures, and I
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
[x] I have commented my code in hard-to-understand areas
[x] I have added ["Google-style docstrings"] to all new modules, classes,
methods/functions or updated previously existing ones
[ ] I have added tests that prove my fix is effective or that my feature
works
[ ] New and existing unit tests pass locally with my changes and I have not
reduced the code coverage relative to the previous state
[ ] I have updated any sections of the app's documentation that are affected
by the proposed changes

If for some reason you are unable to tick off all boxes, please leave a
comment explaining the issue you are facing so that we can work on it
together.

This seems like quite a lot of work still and and we don't this to block. For now I will just require that ZARP and dependencies are installed and that the root path is passed during ZARP-cli init.
Closing for now but may be revisited in due time.
Some additional issues to consider when designing this:

Upgrading ZARP and ZARP-cli from within ZARP-cli, e.g., via zarp upgrade ...
Package ZARP-cli as Conda package and install via ZARP, then set ZARP dir automatically
Write installers for ZARP w/ and w/o cli, Singularity, dev deps


Rearrange input tiles

Drawing a repeating field of an output tile with all corners the same should produce the same output as drawing a repeating field of the corresponding input tile.
However, the output tiles are intended to be drawn offset by half a tile in both axes. So, the above condition will not be satisfied when the output tiles are drawn correctly. To fix this, rearrange the four quadrants of the input tiles like so:
12 -> 43
34    21

It's not obvious how to do this when #12 is done. Allow the user to choose in the options JSON?

Supporting odd tile resolutions (#12) will reopen this.


Shaderc - Matricies in DirectX are transposed

Hi,
when I init a mat3 using 3 vec3 (tbn matrix) and compile the shader for metal or glsl everything is working fine. If I switch to directx, the matrix is transposed.
Seems like some row major - column major missmatch in the mat3( vec3, vec3, vec3 ) constructor.

Now where I switched to the new shaderc version (Metal spirv), everything is working fine because I just read that HLSL uses row major access for matricies. I am used to use GLSL all the years doing computer graphics. So it was a bit confusing.


[BUG] High CPU usage when instance-manager-engine tries to shut down frontend device

Describe the bug
Using Longhorn (have a 200 Gb volume via a storage class with 2 replicas), the instance-manager-e-xxxx pod on the main node tries to shut down frontend device, but fail, and it looks like it creates CPU Hog (instance-manaeger-engine reaching constant 2 CPU usage on a 4 CPUs instance).
But the volume keeps working.
To Reproduce
Steps to reproduce the behavior:

Fresh install of Longhorn
Have 3 Longhorn dedicated nodes to handle Longhorn volumes
Label nodes with tags storage and slow, then disks with tag slow
Create a new StorageClass (see below for details)
Provision a volume
Wait

Expected behavior
Have a low CPU usage from pod instance-manager-e-xxxx (lower than consuming 2 CPU)
Log
[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=info msg="wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07] time="2020-06-29T06:49:51Z" level=error msg="Error when shutting down frontend:device pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78: fail to stop SCSI device: Fail to logout target: Failed to execute: nsenter [--mount=/host/proc/1889/ns/mnt --net=/host/proc/1889/ns/net iscsiadm -m node -o delete -p <IP_ADDRESS> -T iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78], output , stderr, iscsiadm: This command will remove the record [iface: default, target: iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78, portal: <IP_ADDRESS>,3260], but a session is using it. Logout session then rerun command to remove record.\niscsiadm: Could not execute operation on all records: session exists\n, error exit status 15"

time="2020-06-29T06:49:51Z" level=info msg="Closing: <IP_ADDRESS>:10015"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07] time="2020-06-29T06:49:51Z" level=info msg="Closing: <IP_ADDRESS>:10000"

[pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07] time="2020-06-29T06:49:51Z" level=warning msg="Failed to execute hook github.com/longhorn/longhorn-engine/app/cmd.startController.func1: errors when shutting down controller: frontend: device pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78: fail to stop SCSI device: Fail to logout target: Failed to execute: nsenter [--mount=/host/proc/1889/ns/mnt --net=/host/proc/1889/ns/net iscsiadm -m node -o delete -p <IP_ADDRESS> -T iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78], output , stderr, iscsiadm: This command will remove the record [iface: default, target: iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78, portal: <IP_ADDRESS>,3260], but a session is using it. Logout session then rerun command to remove record.\niscsiadm: Could not execute operation on all records: session exists\n, error exit status 15 backend: <nil>"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=info msg="wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process Manager: wait for process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 to shutdown before unregistering process"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=info msg="Process Manager: process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07 error out, error msg: exit status 1"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process update: pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07: state error: Error: exit status 1"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=info msg="Process Manager: successfully unregistered process pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07"

[longhorn-instance-manager] time="2020-06-29T06:49:51Z" level=debug msg="Process update: pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07: state error: Error: exit status 1"

Environment:

Longhorn version: 1.0.0
Kubernetes version: 1.14.6
Node OS type and version: RancherOS 1.5.4, with Ubuntu console

Additional context
Storage Class
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    storageclass.beta.kubernetes.io/is-default-class: "false"
  creationTimestamp: "2020-06-27T21:08:13Z"
  name: longhorn-slow
  resourceVersion: "184546402"
  selfLink: /apis/storage.k8s.io/v1/storageclasses/longhorn-slow
  uid: 501789a2-b8ba-11ea-a8a5-06aa83693c38
allowVolumeExpansion: true
provisioner: driver.longhorn.io
reclaimPolicy: Delete
volumeBindingMode: Immediate
parameters:
  baseImage: ""
  diskSelector: slow
  fromBackup: ""
  nodeSelector: storage,slow
  numberOfReplicas: "2"
  staleReplicaTimeout: "30"

There is something wrong with the ISCSI. Then the engine manager pod fails to create launch the volume and keeps trying to do ISCSI cleanup, which leads to the unexpected high CPU usage.
[pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78-e-bbfedf07] time="2020-06-29T06:49:51Z" level=error msg="Error when shutting down frontend:device pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78: fail to stop SCSI device: Fail to logout target: Failed to execute: nsenter [--mount=/host/proc/1889/ns/mnt --net=/host/proc/1889/ns/net iscsiadm -m node -o delete -p <IP_ADDRESS> -T iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78], output , stderr, iscsiadm: This command will remove the record [iface: default, target: iqn.2019-10.io.longhorn:pvc-4b94793f-b98e-11ea-a3d9-06bcb1d17c78, portal: <IP_ADDRESS>,3260], but a session is using it. Logout session then rerun command to remove record.\niscsiadm: Could not execute operation on all records: session exists\n, error exit status 15"

Since the reproducing step you provided above looks fine, we may need to verify if Longhorn still works fine on RancherOS 1.5.4 Unbuntu console + Kubernetes 1.14.
You can directly send the support bundle to us if possible.

As I understand we should avoid RancherOS now as it's only receiving security fixes.
And follow recommended OSes from Longhorn's best practices page.
I have another bug similar to this but I guess I'll wait for an update here before opening an issue.
Where should we send the support bundle ?
Thanks for your fast answer !

You can send it to<EMAIL_ADDRESS>

UPDATE : In the same cluster, I uninstalled Longhorn to install it on Ubuntu nodes. And it seems to behave correctly.
No more High CPU usage when running Workload and Longhorn Volumes on Ubuntu nodes.
Details (not sure if helpful or clear enough) :
I have worker and storage nodes.
worker are Kubernetes worker nodes that only run pods and co.
storage are Kubernetes worker nodes that hosts Longhorn disks, and where the volumes are provisioned. It is possible to schedule Workload on those nodes if they meet tolerations, affinity...
With RancherOS on worker and storage nodes, I was able to provision Longhorn Volumes for Workloads when workload was scheduled on storage nodes only.
With RancherOS on worker and Ubuntu on storage, I was able to provision Longhorn Volumes for Workloads when workloads was scheduled on storage nodes only.
With Ubuntu on worker and storage nodes, I was able to provision Longhorn Volume for Workloads when workloads was scheduled on both storage and worker nodes.

This issue still occurs when having mixed nodes.
I was able to reproduce it with Ubuntu nodes only, it happened cause the node on which I tried to schedule the volume had taints, so it was not able to schedule on it.
But even after removing the volume, the instance-manager was still consuming a lot of CPUs, and needed a restart to stop the hog.

@Wykiki RancherOS is not officially supported by Longhorn.
Can you elaborate on how you reproduce it on the Ubuntu nodes? It would be great if you can provide a reproduce steps, so we can follow up and fix it in the upcoming release.

NOTE : I hit another problem, not the same as described above, but may be linked.
As it was hard giving all the steps to meet the initial cluster configuration, I started with new cluster :

Rancher 2.4.5
Kubernetes 1.18
Longhorn 1.0.2
OS Ubuntu 18.04

Cluster setup :

1 master node (etcd, controlplane) => master-00
2 storage nodes

=> sto-00 : no taints
=> sto-01 : tainted longhorn=enabled:NoSchedule

1 worker node with taint os=ubuntu:NoSchedule => wrk-00

Reproduction steps :

Create Longhorn project
Install Longhorn

Default storage replica count : 2
Kubernetes Taint Toleration : longhorn=enabled:NoSchedule
Everything else default

Create a workload with no tolerations and a Longhron volume

It correctly schedule and able to access the volume

Create another workload with tolerations os=ubuntu:NoSchedule

Got event AttachVolume.Attach failed for volume "pvc-7a30b5b5-74b9-4f4d-b3fd-6ebd47ab8074" : node "ip-172-31-10-204" has no NodeID annotation, node name corresponding to wrk-00

I can see that there is no engine-image on the wrk-00 node. Could that be the problem ?
My goal here is to provision disk space only on sto-00 and sto-01, but being able to schedule workload that need volume on other nodes that may have taints.
If I change Longhorn Kubernetes Taint Toleration to include the taint os=ubuntu:NoSchedule, I'm afraid that it may try to allocate space on nodes with that taint too.
I think that I could try to match the configuration mentionned in previous comments, but I will need a bit more time for this.
Thanks for reading !

You have change Longhorn Kubernetes Taint Toleration to include the taint os=ubuntu:NoSchedule. If you don't want to have volumes scheduled on the other node, you have to use Storage Tags:
https://longhorn.io/docs/1.0.2/volumes-and-nodes/storage-tags/

Ok thanks !
Anyway, I didn't succeed to reproduce the same bug as mentionned in the thread, so I guess this issue can be closed, I'll reopen one if I encounter this problem.
About RancherOS, I think that might be nice to mention that Longhorn does not work correctly on this OS, maybe on this page ? https://longhorn.io/docs/1.0.2/best-practices/
Even if you already mention Ubuntu and CentOS as recommended OS, the fact that Rancher supports RancherOS and Longhorn, and the Longhorn documentation not stating explicitly that RancherOS is not supported, make this kind of issue appear.

@Wykiki Thanks for the suggestion. Now we've added a section to call out unsupported OS in the doc: https://longhorn.io/docs/1.0.2/best-practices/#oses-arent-supported-by-longhorn .

Is it okay to have Ubuntu console on RancherOS, or I have to switch to entirely to Ubuntu and leave RancherOS ?
(That would be very sad, because I worked hard on setup so many things with RancherOS and because I like it so much...)

Hello, I tried without Ubuntu console first and didn't work, then used Ubuntu console and still didn't work.
It's worth noting that Rancher seems to focus more on k3os instead of RancherOS, the latter only receiving security patch.
After all those problems with RancherOS (Longhorn one being one of a kind), we've decided to change to a more common Linux distribution (one of those mentioned in Longhorn doc)

@Wykiki OK, thanks for your feedback.
RancherOS seems so exciting to me, I hope the project is not totally dead. I will take a look on k3os.

It's not dead but I will be reassured when there will be more public reactiviy:
https://github.com/rancher/os/issues/3025
https://github.com/rancher/os/issues/3000

I'm having this same issue with the following setup:
Longhorn version: 1.2.3
Kubernetes version: 1.23.1
OS: Ubuntu 20.04
When I look at the node with high cpu I see a tgtd process utilizing 100% with errors very similar to those found here: https://github.com/longhorn/longhorn/issues/1533#issuecomment-651522821

Same here, same versions.

@yasker could we reopen this issue or should I create a new one? I'm seeing the exact same errors as https://github.com/longhorn/longhorn/issues/1533#issuecomment-651522821

@yasker could we reopen this issue or should I create a new one? I'm seeing the exact same errors as #1533 (comment)

You can create a new GitHub issue with the logs (& the support bundle if possible) to track it.

I have the same issue with 100% CPU usage by tgtd process.
Longhorn version: 1.2.3
Kubernetes version: 1.21.8
OS: Ubuntu 20.04.3

cc @keithalucas @derekbit

I have the same issue with 100% CPU usage by tgtd process.
Longhorn version: 1.2.3 Kubernetes version: 1.21.8 OS: Ubuntu 20.04.3

cc @keithalucas @derekbit

The cluster I was seeing this on actually had some unrelated critical failures so I lost the logs. @cod-r or @vavallee would one of you mind creating a new issue re: https://github.com/longhorn/longhorn/issues/1533#issuecomment-1038601469

For me it happened on a freshly installed RKE cluster.
I solved it by SIGKILL the tgtd processes on all nodes. One node had 3 tgtd processes.
After SIGKILL I had to delete and recreate the volumes because I was receiving `filesystem is readonly' messages.
If the problem appears again I'll open an issue

@shuo-wu I've created a new issue https://github.com/longhorn/longhorn/issues/3636#issue-1141651746 to track this


The Win32 section needs small updates for VS2019 and typo fixes

Bigger issue is: why isn't it editable? As in, why can't we at least submit pull requests? https://docs.microsoft.com/en-us/windows/win32/index

@GrantMeStrength can you take a look at this feedback?

Hi KaeLL. The Win32 section does not currently support PRs. That'll change later this month.
Thank you for your feedback!
is this the typo you refer to?
Navigate the full Win32 API index for developing desktop and server applications Windows 10 and earlier versions.
I've asked the writer who owns the page to check it.

Thanks for opening this issue, KaeLL. I'm in the process of fixing the typo mentioned in the previous comment (adding the missing "for" before "Windows 10"). Did you have other specific issues/feedback on the https://docs.microsoft.com/en-us/windows/win32/index page?

The Win32 section does not currently support PRs. That'll change later this month.
Thank you for your feedback!

Good and you're welcome.

is this the typo you refer to?
Navigate the full Win32 API index for developing desktop and server applications Windows 10 and earlier versions.

Not particularly. There are a few more in the rest of the tutorial, and the 1st Module 1 example is slightly different from the default one in VS2019 when you create a Win32 Desktop App project.

I'm in the process of fixing the typo mentioned in the previous comment (adding the missing "for" before "Windows 10").

Thanks.

Did you have other specific issues/feedback on the https://docs.microsoft.com/en-us/windows/win32/index page?

I've gone through only the Getting Started with Win32 and C++ part, so no feedback on the rest so far. Hopefully by the time I return to it and find an issue should there be any, I'll be able to submit the PR.

Thanks for the additional info. Could you please specify the URL of the tutorial you're referring to?

https://docs.microsoft.com/en-us/windows/win32/learnwin32/window-messages
-> Last code example is tagged as 'syntax', not C++
https://docs.microsoft.com/en-us/windows/win32/learnwin32/painting-the-window
-> First code example is broken in 2 boxes.

Thanks for the additional details. Both of those particular issues you pointed out are now fixed. Please also note again that we plan to enable public pull requests on this repo within the next few weeks, and at that time you will be able to submit your own fixes.

Hi @KaeLL. Public pull requests for articles in the Win32 conceptual docs repo are now enabled. Thanks for your patience!


[CHP 4, Add extra repositories] RPM-GPG-KEY-remi URL now https://

Not sure if Ansible follows http:// -> https:// upgrades, but the new path to RPM-GPG-KEY-remi is
https://rpms.remirepo.net/RPM-GPG-KEY-remi

@scottdavis99 - Thanks for filing this issue; I've updated the remi repo and remi gpg key URLs in chapter 4 and in the code here (just waiting for test to finish then I'll commit and close out this issue).
The fix will be in the next published version of the book. Thanks again!

Enjoying the book! Thx for keeping it up-to-date. I can only imagine what a challenge that is, given how quickly the ecosystem changes.


chore: update dependencies

Codecov Report
Patch coverage has no change and project coverage change: +0.17% :tada:

Comparison is base (4aeebd2) 97.35% compared to head (6467046) 97.53%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   97.35%   97.53%   +0.17%
==========================================
  Files           9        9
  Lines         151      162      +11
  Branches       43       41       -2
==========================================
+ Hits          147      158      +11
  Misses          4        4

see 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


For time like 05:22, default to future, but got still past

It's expected to be 05:22 tomorrow, if current time passed 05:22, but it returns 05:22 today.
anytime.Parse(as, time.Now(), anytime.DefaultToFuture)

Can you tell me the values of as and time.Now()?


restore original sigaction in restoreSignalHandler

Save original sigactions in a map called gSavedSigActions
In restoreSignalHandler, do nothing if there is no saved sigaction.
If there is a saved sigaction, then re-install it.
Fixes issue #253

Note that my error handling code for sigaction() < 0 is untested. I don't know how to cause a sigaction call to fail.

I haven't looked at your unit tests. If you can suggest where to add a unit test for reportSigactionError, I will try to do it.

👍  thanks @ebertland . I had some time and realized that if you haven't developed with g3log and tests it might be hard to get into.
 cmake -DADD_G3LOG_UNIT_TEST=ON .. is a start ;)


Add changelog

It will be great to have a library changelog

I'm using this format for my projects: http://keepachangelog.com/en/1.0.0/


Bug: Initializing save file wipes out everything in Plannit

Steps to reproduce:

Remove data/addressbook.json if any
Start the application
Execute command exit
Run application again, data/addressbook.json deemed as corrupted

Fixed by #166


refractor data preservation

Project milestone: preserve data
In this PR the following was implemented:

Checked the documentation for Ruby's JSON library.
On exit from our app saved all the data (books, people, and rentals) into JSON files. One per type of data you are storing and named accordingly (e.g. rentals.json)
On startup of our app loaded all data from files. Remember to handle the case when one or more of the files are missing.

@Reem-lab, thank you very much for the reviews; you have greatly enlightened us and we have fixed the issue according to your suggestion.


[FLINK-15062][orc] Orc reader should use java.sql.Timestamp to read for respecting time zone

What is the purpose of the change
Hive orc use java.sql.Timestamp to read and write orc files... default, timestamp will consider time zone to adjust seconds.
Our vector Orc reader should use java.sql.Timestamp to read for respecting time zone
Brief change log

OrcTimestampColumnVector should get SqlTimestamp from java.sql.Timestamp.
AbstractOrcColumnVector.createTimestampVector should fill data with java.sql.Timestamp.

Verifying this change
OrcColumnarRowSplitReaderTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

CC: @lirui-apache @KurtYoung @xuefuz @bowenli86

passed in https://travis-ci.org/JingsongLi/flink/builds/620972987


Implementing vale

As title says and coming from request on #249 by @PipKat
I'll leave you the error resolutions! =)

@RobPasMue All remaining Value issues can be resolved by excluding this folder from the Granta MI BomAnalaytics Vale check: C:\AnsysDev\GitRepos\PyAnsys\grantami-bomanalytics\doc\source_templates. I tried adding "-templates" to exclude_patterns in the config.py file but that didn't work. Also @Andy-Grigg, primariliy so that you know that Vale is implemented and only removing the _templates folder from the check is left to do.

Thanks for implementing this! I'm (mostly) off today and Monday, but I'll get this finished off next week.

Hey there! @Andy-Grigg @PipKat - I briefly discussed with Kathy, the way Vale works is basically "the other way around". You tell the tool which files to consider. And the way we have it configured in PyAnsys actions is to consider the entire "doc" folder. If you want to try and work around it, I suggest we implement the action "on our own" https://github.com/pyansys/actions/blob/main/doc-style/action.yml
This might be a bit tricky though... wouldn't it be easier to just solve the issues in the templates or ignore Vale in the files with the use of the pragmas ``.. vale off / .. vale on```? Depending on:

If it is an HTML file or Markdown: https://vale.sh/docs/topics/config/#markdown-amp-html
If it is an rST file: https://vale.sh/docs/topics/config/#restructuredtext

@Andy-Grigg I implemented .. vale off/.. vale in the RST files in the _templates folder. There are no longer Vale errors. I've approved but will let you decide if you want to merge.


Implement Api Generation

Implement the api generation to generate Kotlin wrappers for all Godot classes.
Similar to the K/N project.

Implemented by #57


[WIP] Display line and column locations for parse errors

This relies on an a branches of combine and combine-language that are not yet released (but will be tomorrow). It is also likely conflicts with #103, we can hold of merging this until after LALRPOP if you like @brendanzab, looks like it is getting pretty close(?).
<top>:Line: 1, Column: 7: Unexpected `Operator`
Expected `Equal`

let x <<
      ^~

Stacktrace:

Fixes #151

Looks fine to me! Build is failing though...

Had to put in path dependencies  to test everything since I haven't uploaded new versions of combine. Everything passes locally though and I will upload new versions today so figured I might as well make this PR since I can just rebase and change the Cargo.toml, nothing else will change.

Merge away when you are ready!


Implement support for .debug_loc

Section 2.6.2 Location Lists

For both the start and end address offsets:

This address offset has the size of an address and is relative to the applicable base address of the compilation unit referencing this location list.

We should new-type these so we/users don't accidentally use them as absolute addresses or anything like that.

I don't think there is a need for new-types. The base address handling is the same as for .debug_ranges, and we currently add the base address while parsing them. Have a look at .debug_ranges and let me know if you still think it needs new-types.

Ah, ok that WFM


Adding ability to specify which AWS Account ID is to be assigned

Ticket ref: https://issues.redhat.com/browse/OSD-11010
Previously we could only be assigned account ids found by the command , now we can specify an AWS Account ID we'd like to be assigned.
Added a unit test to cover this which tests the command at the Cobra CLI level - so it feels more like an integration test to me, but allows the flexibility of mocking when desired, this is open for scrutiny :)   To do so, I had to remove the CheckErr function wrapping the complete and run functions (as this would exit out of the test if an error was encountered)  and the cobra.Command parameter was changed to RunE instead of Run for testability purposes (now actually returning an error).

Thanks for your work on this Dan!
/lgtm


[Pull Request] - Different font colors per segment

Hi,
I have a requirement to use different font colors per segment, to account for contrast not high enough when using very dark and light colors on the same chart.
Basically for dark segments I wish to use a light font color and light segments a dark font color.
pieceLabel: {
	mode: 'value',
	fontColor: '#fff',
	fontSize: 20,
}

to
pieceLabel: {
	mode: 'value',
	fontColor: ['#fff', '#666'],
	fontSize: 20,
}

I have implemented and tested this feature in a fork, would a pull request for it be considered?

or config in dataset?
        datasets: [
          {
            label: 'My First dataset',
            data: [50445, 33655, 15900],
            backgroundColor: [
              '#FF6384',
              '#36A2EB',
              '#FFCE56'
            ],
            fontColor: [...]
          }
        ]

This can support multiple datasets although it's not common...

Would that use-case not also apply to all available options as well?
Eg, something like this:
new Chart(document.getElementById("PieceLabel"), {
	type: 'pie',
	data: {
		labels: ['January', 'February', 'March'],
		datasets: [{
			label: 'My First dataset',
			data: [50445, 33655, 15900],
			backgroundColor: [
				'#FF6384',
				'#36A2EB',
				'#FFCE56'
			],
			pieceLabel: {
				mode: 'value',
				fontColor: [ '#fff', '#fff', '#666' ],
				fontSize: 20,
			}
		},{
			label: 'My Second dataset',
			data: [30445, 23655, 15900],
			backgroundColor: [
				'#FF6384',
				'#36A2EB',
				'#FFCE56'
			],
			pieceLabel: {
				mode: 'percentage',
				fontColor: [ '#eee', '#eee', '#555' ],
				fontSize: 10,
			}
		}]
	}
});

this feature has added to v0.7.0.

Great! thanks


feature: add redirect plugin.

Related issues: issue-1137

Use automatic generation, not need to write manually.


Molecule 3.2.0a0 fails when /bin/bash does not exist

Issue Type

Bug report

Molecule and Ansible details
molecule 3.2.0a0
    ansible:2.10.2 python:3.8
    delegated:3.2.0a0 from molecule
    docker:0.3.3 from molecule_docker
    vagrant:0.5 from molecule_vagrant
/builds/sio/server_common/venv/bin/ansible --version
ansible 2.10.2
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /builds/sio/server_common/venv/lib/python3.8/site-packages/ansible
  executable location = /builds/sio/server_common/venv/bin/ansible
  python version = 3.8.5 (default, Jul 20 2020, 23:11:29) [GCC 9.3.0]

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Detail any linters or test runners used:
set -e
yamllint .
ansible-lint

Desired Behavior
Molecule does not crash when /bin/bash is not installed. /bin/sh should be good enough.
Actual Behaviour
Molecule (with docker plugin) crashes in docker sanity check stage. It tries to execute /bin/bash even when it's not installed, which results in an unhandled FileNotFoundError:
--> Sanity checks: 'docker'
Traceback (most recent call last):
  File "/builds/sio/server_common/venv/bin/molecule", line 8, in <module>
    sys.exit(main())
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/command/test.py", line 148, in test
    base.execute_cmdline_scenarios(scenario_name, args, command_args)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/command/base.py", line 104, in execute_cmdline_scenarios
    execute_scenario(scenario)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/command/base.py", line 146, in execute_scenario
    execute_subcommand(scenario.config, action)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/command/base.py", line 135, in execute_subcommand
    return command(config).execute()
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/command/destroy.py", line 108, in execute
    self._config.provisioner.destroy()
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/provisioner/ansible.py", line 702, in destroy
    pb.execute()
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/provisioner/ansible_playbook.py", line 107, in execute
    result = util.run_command(self._ansible_command, debug=self._config.debug)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/molecule/util.py", line 151, in run_command
    return run(args, env=env, stdout=stdout, stderr=stderr, echo=echo or debug)
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/subprocess_tee/__init__.py", line 88, in run
    result = loop.run_until_complete(_stream_subprocess(cmd, **kwargs))
  File "/usr/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/builds/sio/server_common/venv/lib/python3.8/site-packages/subprocess_tee/__init__.py", line 32, in _stream_subprocess
    process = await asyncio.create_subprocess_shell(
  File "/usr/lib/python3.8/asyncio/subprocess.py", line 216, in create_subprocess_shell
    transport, protocol = await loop.subprocess_shell(
  File "/usr/lib/python3.8/asyncio/base_events.py", line 1597, in subprocess_shell
    transport = await self._make_subprocess_transport(
  File "/usr/lib/python3.8/asyncio/unix_events.py", line 197, in _make_subprocess_transport
    transp = _UnixSubprocessTransport(self, protocol, args, shell,
  File "/usr/lib/python3.8/asyncio/base_subprocess.py", line 36, in __init__
    self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
  File "/usr/lib/python3.8/asyncio/unix_events.py", line 789, in _start
    self._proc = subprocess.Popen(
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/bin/bash'

Full log: https://gitlab.com/sio/server_common/-/jobs/823643538
Molecule 3.1.5 worked fine on the same runner (without /bin/bash).

What changed in-between was switching from sh to subprocess_tee library and considering that molecule does not specify any shell itself, this is an upstream bug. Please raise it at https://github.com/pycontribs/subprocess-tee/issues and as soon we fix it I will update molecule to require a version of subprocess-tee that has the fix in it.
It is not unreasonable to assume that some platforms may not have bash as default shell.

subprocess-tee >= 0.1.3 works fine! Thank you very much!


Set minimum block clock size to 200px width

Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

[X] I still think this issue should be opened here

Report
On my Android phone, the clock is too small. Minimum size should be 200px width. It is ~131px wide.

Hi @GBKS , what android device are you using?

It's a Galaxy A32 5G.

It's a Galaxy A32 5G.

Great I will test with a virtual device...
Also to make sure I'm able to reproduce it, which build are you using? Latest on main branch?

The math that defines the width is located here.
Math.min((root.parentWidth * dial.scale), (root.parentHeight * dial.scale))
The Galaxy A32 has a logical resolution of 360x800. The dial scale is either 1/2 or 1/3. parentWidth is set here as the parent.width - 40. So that puts the width at (360-40)/2 = 160 or (360-40)/3 = ~107. Not exactly the ~131 I roughly measured in my screenshot above, but both values are below the 200 minimum that we want. So maybe we change the line above to this?
Math.max(200, Math.min((root.parentWidth * dial.scale), (root.parentHeight * dial.scale)))
But that misses the scenario where the clock is shown in a widget. So you really don't want to go smaller than the screen width minus some padding. So maybe this?
Math.max(Math.min(200, root.parentWidth - 30), Math.min((root.parentWidth * dial.scale), (root.parentHeight * dial.scale)))
I am probably missing something, since my math above doesn't totally add up with my screenshot measurement.
Thanks for looking into this. I believe I am on the latest main branch.

@GBKS, thanks for your comment above, made my life very easy :)
build and tested with the change you suggested:

Math.max(Math.min(200, root.parentWidth - 30), Math.min((root.parentWidth * dial.scale), (root.parentHeight * dial.scale)))

Results below:
Before change (this a screenshot of a Galaxy A32 5G virtual device):

this a after the change:

I'll go ahead a start a PR, unless there's more to consider?

@GBKS just opened the PR with your fix https://github.com/bitcoin-core/gui-qml/pull/385


Implement Merge and Graph structures

[x] Merge
[ ] Graph

hey @transcranial, do you plan to implement Graph anytime soon? :)

@marcj soon, promise :) In fact, I'm in dire need of it myself...

that would be awesome! If I can help something, please ping me. Does it support then all layers in a graph?