Whitepaper

Hello, is there a whitepaper for the HE and PIR implementation? I was wondering why BFV was chosen. Also wondering in what circumstances to use aclsPir and mulPir specified here. How do those two protocols differ from simplePIR or hintlessPIR?

Hello, is there a whitepaper for the HE and PIR implementation?

Hi! There's no comprehensive whitepaper for Swift Homomorphic Encryption, but Section 6 in https://arxiv.org/pdf/2406.06761 has some optimizations implemented here. https://eprint.iacr.org/2019/1483.pdf also has some details on MulPir.

I was wondering why BFV was chosen.

BFV is well-studied and a good fit for PIR. Table 5 from https://eprint.iacr.org/2019/1483.pdf shows it's better suited for PIR than ElGamal, for instance. CKKS uses approximate arithmetic, so it's not a great fit for PIR. BGV is also a possibility.

Also wondering in what circumstances to use aclsPir and mulPir specified here.

AclsPir is actually unimplemented at the moment; https://github.com/apple/swift-homomorphic-encryption/pull/43 adds some checks to make this more clear. To answer the question though, AclsPir would be expected to have larger response size, but faster server runtime than MulPir. The introduction from https://eprint.iacr.org/2019/1483.pdf has some more details.

How do those two protocols differ from simplePIR or hintlessPIR?
From a practical perspective, SimplePir offers faster runtime, but requires the client to download and maintain a large offline hint. MulPir/AclsPir require only a very small client state, essentially just the database size.
HintlessPir removes the need for the hint, making it a similar scheme as MulPir/AclsPir in that sense.
The mechanics of the schemes differ, e.g. HintlessPir uses a fresh RLWE secret polynomial, and sends the evaluation key with each query, leading to larger query size than MulPir.

The ideal PIR scheme will depend on the problem setting, including tradeoffs between client/server, state/compute, online vs offline, bandwidth vs runtime, etc.

Would also love to learn the number of entries per shard.

In Swift Homomorphic Encryption, the sharding can be set as desired, e.g. in PirShardDatabase.

thank you that's very helpful


[Container Registry] Make ContainerRegistryClientOptions extend from CommonClientOptions

Packages impacted by this PR

@azure/container-registry

Issues associated with this PR

Fixes #20275

Describe the problem that is addressed by this PR
This PR makes the container registry client's ClientOptions extend from the correct interface.

Thanks for cleaning this up! 👍


Support bulk operations in pandevice

Define a new kind of object that contains other PanObjects.  This container itself does not generate xpath or xml like a PanObject does, but if create() or another method like it is called on the container, this would cause the children of the container to be created in an optimized way.
This container object would also handle situations such as namespaces, for example, the shared namespace could be handled with a container object.

Updating bug description to more accurately match the problem:  pandevice needs a way to do bulk operations.


Unable to deploy app (interal error)

I am trying to deploy hazel on now (with now zeit/hazel) but it always throws me these errors:

[debug] Retrying: Error: An unexpected internal error occurred
Error: An unexpected internal error occurred
at module.exports.EventEmitter.create.deployment.retry (C:\snapshot\now-cli\dist\now.js:437:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
[debug] get files ready for deployment: 0.298ms
[debug] v2/now/deployments: 1266.614ms
[debug] Retrying: Error: An unexpected internal error occurred
Error: An unexpected internal error occurred
at module.exports.EventEmitter.create.deployment.retry (C:\snapshot\now-cli\dist\now.js:437:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
[debug] get files ready for deployment: 0.349ms
[debug] v2/now/deployments: 1211.761ms
[debug] Retrying: Error: An unexpected internal error occurred
Error: An unexpected internal error occurred
at module.exports.EventEmitter.create.deployment.retry (C:\snapshot\now-cli\dist\now.js:437:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
[debug] get files ready for deployment: 0.383ms
[debug] v2/now/deployments: 1143.849ms
[debug] error: Error: An unexpected internal error occurred
Error: An unexpected internal error occurred
at module.exports.EventEmitter.create.deployment.retry (C:\snapshot\now-cli\dist\now.js:437:15)
at
at process._tickCallback (internal/process/next_tick.js:188:7)
Error! Unexpected error. Please try again later. (An unexpected internal error occurred)

I tried to reinstall/reauth now and also disabled my firewall. I initially opened a ticket in the zeit/hazel repository, because i thought that the errors were caused by it - but it seems that the problem is with now (https://github.com/zeit/hazel/issues/39)

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


Add support for chat streaming

Motivation and Context

responses will now be streamed directly from the Kernel to all users in the chat.
Description

ChatSkill.cs:

added StreamResponseToClient() to broadcast the streamed response to all clients.
changed GetChatResponseAsync() to use Task.WhenAll when extracting audience/user intent and semantic/document memories.
changed GetChatContextTokenLimit() to account for the tokens used in extracting the audience

Preview
regular messages:

planner messages:

multiuser messages:

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Have you tested the app with multiple users in the chat?

yes, added a couple of needed tweaks in just now and also added a gif in the description of a multiuser example.

Copy nit (tagging @matthewbolanos if you have any input on the following):
In the first screengrab gif, I recommend replacing Generating bot response... instead of Invoking AI model when the uber prompt is being invoked.

This helps keep the flow well defined in laymens terms, and we technically invoke the AI model on multiple occasions.

And then using Generating Semantic Memories instead of Extracting Semantic Memories....

@TaoChenOSU and I had a conversation about this before and extraction gets a bit confusing since it makes it seem like we're on the step that pulling the memories to use for the response generation, but "generating" implies that this step creates new memories based on the chat history, rather than extracting them from somewhere else.

good points. I've updated the strings to reflect this!


Add sin/cos/tan helpers for sf::Angle

Description
I noticed there were many instances of using asRadians just to use standard trigonometry functions so I added some additional functions that make it more easy to use sf::Angle with trig functions. This is a nice bit of syntactic sugar but also avoids the pitfalls of users calling asRadians which eschews the type safety of sf::Angle. We'd prefer any use of sf::Angle be in a type safe manner.
Tasks

[ ] Tested on Linux
[ ] Tested on Windows
[x] Tested on macOS
[ ] Tested on iOS
[ ] Tested on Android

I'm not convinced of this change. From my point of view this more API bloat than anything else. It puts the whole usage of sf::Angle in question, when we internally write short hands, because we consider the API too long/verbose. Additionally, while sin, cos and tan are the most common functions, what about asin, acos, atan, atan2, sinh, cosh, tanh, asinh, acosh, atanh? Or what about some other functions that takes angle?
On top of that, I really don't want SFML to pretend to be a math library, which by implementing our own version of sin, cos and tan you start to blur the line.

Once https://github.com/SFML/SFML/pull/1979 is merged, the need to explicitly use sin/cos will also be reduced. Maybe not so much for SFML itself, but definitely for the user.
In this regard, I see vector APIs as an abstraction layer above trigonometric functions.


Udpate Docker repository to use ghost:0.10.0

Seems like the new 0.10.0 Ghost version has not been pushed to the Docker repository. 👻
Do you need to tag the repo or simply update the repo details here:
https://github.com/docker-library/repo-info/blob/master/repos/ghost/tag-details.md
?
Thank you for any informations that you can provide to fix this issue 😅
Dockerfile:
FROM ghost:0.10.0

Output after docker build .
Step 1 : FROM ghost:0.10.0
Pulling repository docker.io/library/ghost
ERROR: Tag 0.10.0 not found in repository docker.io/library/ghost

Sorry, I didn't see this open PR
https://github.com/docker-library/official-images/pull/2108
Closing this issue then.
Thanks for your work on this image.


What's the right way to work with events that need to work with local react state?

I'm having trouble using onDragEnd.  In the handler for that event, the value from my state is always the same as it was on initialize.  How can I access the updated value in my handler?
Here's a basic example I typed up, hope this helps in conveying my issue.
const Map: React.FunctionComponent<{
  center: {
    latitude: number;
    longitude: number;
  };
}> = props => {
  const [mapState, setMapState] = React.useState({
    zoom: 13,
    center: props.center
  });
  const handleMapChange = (map: MapEvent) => {
    const { lat: latitude, lng: longitude } = map.getCenter();
    const newCenter = { latitude, longitude };
    const newZoom = Math.round(map.getZoom());

    // mapState.center is always the same as initial value, even after setMapState was called
    const distanceMoved = getDistance(mapState.center, newCenter, 100);

    if (distanceMoved > 4500) {
      setMapState({
        ...mapState,
        zoom: newZoom,
        center: newCenter
      });
    }
  };

  return (
    <Mapbox
      // @ts-ignore
      style="mapbox://styles/mapbox/light-v10"
      containerStyle={{
        height: '100%',
        width: '100%'
      }}
      center={[mapState.center.longitude, mapState.center.latitude]}
      zoom={[mapState.zoom]}
      flyToOptions={{
        speed: 0.8
      }}
      onDragEnd={handleMapChange}
      onZoomEnd={handleMapChange}
    >
      <MyLayer />
    </Mapbox>
  );
};

Hi,
you could take a look at this comment https://github.com/alex3165/react-mapbox-gl/issues/748#issuecomment-569395282 for a ref-based workaround.
(I'm having similar difficulties)

has there been any updates on this?


build: Skip custom vet check by default

Change the custom vet check flag (SKIP_CUSTOMVET_CHECK) default value from false to true. This allows Dev VM to start up. Without this change the Dev VM startup fails like this:
    runtime1: contrib/scripts/custom-vet-check.sh
    runtime1: main: ./... matched no packages
    runtime1: exit status 1
    runtime1: Makefile:511: recipe for target 'precheck' failed
    runtime1: make: *** [precheck] Error 1
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

Custom vet check was already disabled for CI builds:
test/provision/compile.sh:    sudo -u vagrant -H -E make SKIP_CUSTOMVET_CHECK=true LOCKDEBUG=1 SKIP_K8S_CODE_GEN_CHECK=false SKIP_DOCS=true

Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

Hi guys, is this problem solved? I had the same problem and I would like to share my thoughts about.
TL;DR: probably cilium was not cloned inside $GOPATH.
Why this error occurs?
After a long sequence of calls...
contrib/scripts/custom-vet-check.sh
tools/customvet
main() (vendor/github.com/cilium/customvet/main.go)
init()  (vendor/github.com/cilium/customvet/analysis/timeafter/time_after.go)
...
Run() (golang.org/x/tools/go/analysis/internal/checker/checker.go)
load() (golang.org/x/tools/go/analysis/internal/checker/checker.go)
the execution reaches Config.Load (golang.org/x/tools/go/analysis/internal/checker/checker.go) which returns an empty list of packages. Receiving this empty list, load() returns an error with the message "%s matched no packages".
Hope this helps someone ;)


Add open source contribution guide

This PR adds a guide for contributing to SAS open source projects on GitHub. It outlines how to get started making contributions, where to find resources, how to comply with our agreements, and what to expect from SAS's open source project maintainers.

@suehle and @isharacomix: As discussed, here's an initial draft of a SAS contributors' guide. Please take a look and let me know what you might change, add, etc.
Also flagging @cjdinger in case he has feedback to offer. And I'd be interested in @richmain-sas's impressions, too, but for some reason I'm unable to add him as a reviewer.
For context: this guide will be a sub-page of https://sassoftware.github.io/. It will be our "instructions of record" for open source contributors.
What I've committed so far is simply a Markdown file of draft text. When we're confident we've gotten the guide where we'd like it to be, I'll convert this document to HTML and re-circulate for additional review.

Thanks, @richmain-sas! I'll figure it out one of these days. 😏 Regardless, I really appreciate your review!

@isharacomix, @suehle, @cjdinger: I've converted this to a basic HTML page for easier review, just so you can see what I'm driving at here. It's staged internally at SAS if you'd like to see it in action.
As always, feedback welcome. Next I am working on connecting the primary landing page to the guide.

Okay! @isharacomix, @suehle, @cjdinger: After working through some internal feedback from @suehle, I think now have what I believe is a workable MVP of the new contributor handbook. This branch reflects all the changes, but I've also staged everything internally at SAS so you can see it in action.
1⃣ Refreshed home page
2⃣ The SAS Open Source Contributor Handbook
Please let me know what you think, especially if you have suggestions/requests for changes, ideas for improvements, etc. I'm all ears.
Operating on lazy consensus, if I don't hear objections to the new work in a day or two, I'll merge.

(Figured I would let @richmain-sas take a look at the page layout, too. 😎)

These changes are looking good @semioticrobotic! Just back from being away, and glad to see you didn't wait for my approval to proceed ;)

Great! Thanks, @cjdinger!

Also: welcome back!


Issue converting a tune for the Tandy1000.

Hello :)
I'm having trouble converting a tune (to 50Hz) I downloaded from VGM Rips:
(https://vgmrips.net/packs/pack/castlevania-tandy-1000 - Castlevania - Heart of Fire)
In the description of the tune, it says SN76489, PC Speaker but I don't seem to hear anything the SN couldn't produce when playing it back in windows.
Does it make sense the tune doesn't come out right (all distorted)?

Can you attach a recording of the output you're getting and maybe we could take it from there?

Sure 👍 here it is:
vgmconverter_Castlevania-HeartOfFire-q50.zip

so this is.......quite interesting.
so, on the page the VGM sounds correct (other than the misnotes from conversion, but that's not the point)
I threw this at one of my VGM replayers that I don't think understands "new" VGM, that is, PC speaker stuff is a pretty recent addition I think? it replays the bass line a few octaves up. and then your converted VGM does the same.
I'm just spitballing here, but one of my guesses is that the VGM format supports multichip (notably, to replay a Sega Genesis/MegaDrive tune, you need to include both YM2612 and SN76489), and so IBM PC VGMs could in theory include SN76489 and 8253PIT/Beeper, and maybe this did that and was confusing to the converter. maybe the bass line is played on the PC speaker since the 76489 doesn't really "do" bass, and the rest on the SN?
I think I'm gonna leave this one up to @simondotm as he wrote the tool, but that might be a good starting point for him!


App crashes when spamming emoji

Summary
App crashes when spamming emoji. If you don't get kicked from the channel after crashing, it keeps crashing when you open the app again.
Environment Information

Device Name: Oneplus 2
OS Version: Android 8.1.0
Mattermost App Version: 1.13.0 (build 147) and 1.12.0 (build 142)
Mattermost Server Version: 5.3.1

Steps to reproduce
Just spam a lot of emoji in a message (I used :belgium:)
Expected behavior
The app doesn't crash
Observed behavior
The app becomes unresponsive, crashes. When I restart the app, it goes to the same channel and crashes again, over and over
Possible fixes
?

Thank you @redfast00, we are able to repro this and created a ticket here: https://mattermost.atlassian.net/browse/MM-12668.

Hi @redfast00, letting you know that this a React Native, so we will open an Issue in their repo in the next upcoming days.


DPL-542 As PSD developer I want to agree with TOL the next stage of the sample ingestion development

Description
As PSD developer I want to agree with TOL the next stage of the development to provide a consumer to ingest samples from TOL into Traction because I want to coordinate any required changes in both sides to perform the coding of the solution.
Who the primary contacts are for this work
Eduardo Martin
Knowledge or Stake holders
Sujit Dey
TOL
Additional context or information
Any other useful context or information that may be useful.

Closed as done.


change overriddenstatus field name in pojo to allow for better serialization compatibility

further relax deser behaviour on overriddenstatus field to allow for both lower and camel case

@spencergibb I think this will fix https://github.com/spring-cloud/spring-cloud-netflix/issues/2941, do you agree?

Yup

This didn't fix things for us, since  @JsonProperty("overriddenstatus") is still the lowercase version :-(

I was wondering about that :(. Let me give it one last shot.

Changing that to camel case breaks tests in EurekaCodecCompatibilityTest

Unrecognized field "overriddenstatus". The opposite of what we have. When you have something in a branch/fork somewhere, let me know, I'll build and try so we don't end up releasing it broken again.


There is a gap in the y-axis between y_train and y_test when creating graph.

It seems to be created after create_sequences. train_data and test_data are plotted fine, but Y_train and Y_test are disconnected on the y-axis

I do not believe it matters so I will close it.

It does if you want to plot it... I think I will ad that later

The more the model is trained the more scuffed it is. This is a serious issue, but I do not understand the problem. It does not seems to be a stock split.
20 epochs

1000 epochs

The problem was in the test, not the model. It was being split incorrectly, which was not accounting for the first num_days being ignored.


Getting a GenServer timeout when refreshing config

Describe the bug
Using the auto policy, we are often getting a GenServer timeout from the FetchConfig genserver.
{:timeout, {GenServer, :call, [ConfigCat.ConfigFetcher, :fetch, 5000]}}

In CacheControlConfigFetcher, the handle_call for :fetch is making a request and using the HTTPoison library which has some timeouts that are larger than the GenServer.call/2 default time.
https://hexdocs.pm/elixir/GenServer.html#call/3

call(server, request, timeout \ 5000)

https://hexdocs.pm/httpoison/HTTPoison.Request.html

:timeout - timeout for establishing a TCP or SSL connection, in milliseconds. Default is 8000
:recv_timeout - timeout for receiving an HTTP response from the socket. Default is 5000

To reproduce
Run ConfigCat with the auto policy and  let it run, this will periodically happen.
Expected behavior
The genserver allows enough time for the fetching of the updated config from ConfigCat or handles this error in some way.

I'll add here that sometimes a call to ConfigCat.get_value will timeout as well, because it gets blocked behind an in-progress fetch.


add openAPI validation in migration doc

Description of the change:
Add info to help users fix the validation issues which may be faced with the open API version used.
Motivation for the change:
https://github.com/operator-framework/operator-sdk/issues/2042#issuecomment-546274495

/test e2e-aws-go
/test e2e-aws-helm
/test e2e-aws-subcommand
/test images
/test e2e-aws-ansible

/test e2e-aws-go
/test e2e-aws-helm
/test e2e-aws-subcommand
/test e2e-aws-ansible

/test e2e-aws-go
/test e2e-aws-helm
/test e2e-aws-subcommand
/test e2e-aws-ansible

HI @estroz,
However, the other changes are required to be performed before for the user be able to:

Run the command operator-sdk generate openapi

So, IMHO it is in the correct order for someone are able to follow up.
Are you ok with? Could we merge this one? WDYT @estroz @hasbro17 ?

/test e2e-aws-subcommand

/test e2e-aws-subcommand

/test marker

Seems a link is broken. Fixed in #2144

/retest


v1.2.0 - Add optional live validation for text-like fields on keyup and select fields on change

Nice feature, but my goal is to very deliberately NOT make this a full featured library.
It does one thing: validates on blur by augmenting native form validation. Why blur? Numerous usability tests have shown it's the best time to validate.
I can imagine exceptions (password fields with lengthy requirements for example), but that's not what this is for.

I see. That's why I made it optional. :) In any case: Great library and thanks for the in-depth explanations on css-tricks.com! Much appreciated!
I'll keep the feature in my fork. I know there will always be more feature requests. My aim is to only use the Constraint Validation API to be framework-independent but that to the full extend possible.

Optional or not, it's still more code in the code base, though, right? I've learned to be a bit ruthless with features.
Glad you enjoyed the series, and cheers!


Add PKI config to example

After the help @bonifaido gave me in Issue #180, I think it would be valuable to have a PKI example in the example External Config.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Missing string manipulation section

refer:
https://tldp.org/LDP/abs/html/string-manipulation.html

A word of caution:  The ABS is not highly regarded - it is outdated and promotes suboptimal practices.  Its maintainer has refused to accept contributions and has refused to collaborate with others.
Reference Greg Wooledge's Wiki and the Bash Hackers Wiki instead :)

thanks


Editable Children Flag Turns Off Due to Node Path Change

Godot version:
3.1
OS/device including version:
OSX Latest
Issue description:
I changed the node path of a node that has Editable Children enabled, and it disabled Editable Children. The edits made to the children do not change, but the child nodes are not accessible anymore. If I turn Editable Children back on, everything seems to go back to normal since the children node states are somehow preserved.
For example, if I enable Editable Children on a node, and I edit one of the children, the edit is preserved despite Editable Children being disabled from changing the path.
Steps to reproduce:

Open a Godot file
Make a new scene, say Scene A
Make new scene, say Scene B, and instance A in it
Enable Editable Children for the Instance A in Scene B
Change the name of Instance A in Scene B.
(Alternative to 5) Change the name of a parent node for the Instance A in Scene B

Expected: The name changes and that's it
Actual: The name changes, but Editable Children gets disabled
Edit:
As a side note, I'm having a hard time finding documentation for what Editable Children actually does. The inspector properties are all red, I don't know what that means. I don't know the limitations to Editable Children either.

Still happens in Godot 3.2 beta2

Duplicate of #20409


No public or protected classes found to document.

Occurs for all unij-bundle-* projects and empty unij-collect-* and unij-misc-* projects.
We probably just need to disable javadoc until the project contents are filled.

This still occurs for unij-bundle-* projects if we try to enable javadoc, even after #42 has been fixed.

Wonder how it works for JDK's java.se module, which also has no public or protected classes to document, and yet it's Javadoc gets generated:

source: https://github.com/openjdk/jdk/blob/master/src/java.se/share/classes/module-info.java
javadoc: https://docs.oracle.com/en/java/javase/11/docs/api/java.se/module-summary.html

Source:

thrown from: https://github.com/openjdk/jdk/blob/6bab0f539fba8fb441697846347597b4a0ade428/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AbstractDoclet.java#L193-L199
message: https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties#L60

The one potential workaround I found: https://stackoverflow.com/questions/1138390/javadoc-for-package-info-java-only (it'd require adding a dummy temporary file to javadoc sources - the original issue is about package-info, so I'm not sure it'd work here).

This is a bigger problem - even other modules for which the JavaDoc is generated don't have proper info about modules they require, etc.
The main problem here is this - modules are not specified as targets to be documented at all (there is no module summary in any of the modules).
I tried playing with --module, --module-source-path, and -Xmodule: options, but to no avail so far. It must be possible to do this in such a way that JavaDoc understands there are other modules and documents/links to them.
When it works, @moduleGraph option should probably work too (currently, it has no effect).

Some related links:

https://stackoverflow.com/questions/53973319/how-to-generate-javadoc-for-multiple-modules
https://stackoverflow.com/questions/49476559/java-9-error-not-in-a-module-on-the-module-source-path


Load the HTML pages when the appropriate About window tabs are clicked to save RAM.

Right now when the user opens the About window the RAM usage almost doubles to 55 MB or more depending on which tab they open.

Actually, the documents are now RTF documents loaded when the About window opens.


[AutoPR machinelearningservices/resource-manager] Revert "Adding usage id property to support usages by VM family, Workspace & Compute"

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6171

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5598


Hello，could you provide a parameter set for "Marquis2020" and "Yang2017"

Discussed in https://github.com/pybamm-team/PyBaMM/discussions/2798

Originally posted by IDontIikeHandwriting March 23, 2023
The sei_growth.py（https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/submodels/interface/sei/sei_growth.py） uses the "Yang2017" and "Marquis2020" parameter sets, but the input section of the GitHub file （https://github.com/pybamm-team/PyBaMM/tree/develop/pybamm/input/parameters/lithium_ion） does not provide these two parameter sets. Can you upload these two parameter sets to the GitHub? Thank you very much.

Hi, @IDontIikeHandwriting I cannot acess the files that you have referenced with the URLs. Can you please look into it?
Thank You.

It adds references to those papers (you can find the full details in CITATIONS.txt or by running pybamm.print_citations() at the end of a python file where you used the SEI growth model). That is different from parameter sets. There are no parameter sets for Marquis2020 and Yang2017 (we tried adding a parameter set for Yang2017, but they purposefully keep some of the parameters secret). Most of the parameter sets have some SEI parameters

It adds references to those papers (you can find the full details in CITATIONS.txt or by running pybamm.print_citations() at the end of a python file where you used the SEI growth model). That is different from parameter sets. There are no parameter sets for Marquis2020 and Yang2017 (we tried adding a parameter set for Yang2017, but they purposefully keep some of the parameters secret). Most of the parameter sets have some SEI parameters

Thanks for your reply！

Hi, @IDontIikeHandwriting I cannot acess the files that you have referenced with the URLs. Can you please look into it once? Thank You.

Hello, you can see these files in the code section of GitHub


Fixes button text not showing on open button on welcome

This PR fixes the issue of the "Open" button text not showing on the welcome page on macOS devices. It fixes the issue by adding the appropriate class to the mac only button.
This PR fixes #11366

Coverage decreased (-2.7%) to 37.601% when pulling a1b3fadc9cf7b99c4ce7f6a032213267f2178061 on fixes-button-type-not-showing-on-open-button-on-welcome into 8e2344e1e0ebc6258ef9ebeff41d33c1277c747e on release/1.21.


Read and Print File Contents

Description of Problem
Shows to read all of the contents of a file and print them to the console
Proposed Name of Folder/Module
Unique Recipe Name: ReadPrintFileContents

Additional context
This recipe should read the entire file's contents into memory. Another recipe could stream contents into memory and print things via stream, too.

I'll send a PR soon.


DI WIP

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Thanks for the suggestion, I'll definitely fix up the multiple values usages. And of course the PR will get proper commit messages and a lot of cleanup before I merge.

Still needs tests, and I have more diagnostics improvements pending.

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@swift-ci Please smoke test

Hey @jrose-apple @gottesmm this is ready for review.
There is a regression in diagnostics where sometimes we now point to the end location of a function instead of the 'return' in question when you return without initializing self. Technically this isn't a new problem, it was there all along, because the old logic was only happening with root initializers. Now that more initializers are delegating it's happening more.
Do you mind if I fix it in a follow-up PR? @jrose-apple needs the changes here for some resilience work he's doing.

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test source compatibility

@swift-ci Please test Linux

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility


[5.8] Custom column collations are ignored when changing a column in a migration.

Laravel Version: 5.8.16
PHP Version: 7.3
Database Driver & Version: MySQL 5.7

Description:
Setting a custom column collation in conjunction with the ->change() method in a migration doesn't work. The framework completely ignores the ->collation('') method, because there is not such thing as a "setCollation" option in Doctrine DBAL.
https://github.com/laravel/framework/blob/b4c0ef18e7c27bcbe125d5a3750e642544f7436d/src/Illuminate/Database/Schema/Grammars/ChangeColumn.php#L83
The collation can be set though by using the setCustomSchemaOption on Doctrine's column builder:
https://www.doctrine-project.org/projects/doctrine-dbal/en/2.9/reference/schema-representation.html#vendor-specific-options
Steps To Reproduce:
Create a new migration:
        Schema::create('tests', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->string('test_column');
        });

And create another one:
        Schema::table('tests', function (Blueprint $table) {
            $table->bigIncrements('id');
            $table->integer('test_column')->collation('')->change();
        });

Proposed change:
Before i create a pull request, i'd like to hear your thoughts on this:
https://github.com/JacksonIV/framework/blob/37c3a6decc9c6dc5f47dff0105b3c533bd7ac786/src/Illuminate/Database/Schema/Grammars/ChangeColumn.php#L83-L88

If Doctrine doesn't offers this then isn't this more of a feature request than a bug to support it? It doesn't explicitly say in the docs that we support this (although I can understand that it's a bit confusing).

@driesvints Doctrine does support it, please refer to https://www.doctrine-project.org/projects/doctrine-dbal/en/2.9/reference/schema-representation.html#vendor-specific-options.

Okay, feel free to send in a PR with a fix if you have something.

PR merged


xIisLogging: Move localization strings to strings.psd1 file

We should move the localization strings to a strings.psd1 file. See the localization https://dsccommunity.org/guidelines/localization/

#510


The keyboard disappears after each letter is typed or deleted

The keyboard disappears after each letter is typed or deleted and it is not clear why this is happening.
my code example:
<Autocomplete
                data={
                  autoCompleteWaterSourceData?.length === 1 &&
                  autoCompleteWaterSourceData[0]
                    ? []
                    : autoCompleteWaterSourceData
                }
                placeholder={placeholder1}
                value={querySourceCode}
                autoCorrect={false}
                onChangeText={setQuerySourceCode}
                flatListProps={{
                  keyboardShouldPersistTaps: 'always',
                  keyExtractor: (_, idx) => idx.Water_Source_Code,
                  renderItem: ({
                    item: { Water_Source_Code, Water_Source_Name },
                  }) => (
                    <TouchableOpacity
                      onPress={() =>
                        setQuerySourceCode(
                          Water_Source_Code + ' ' + Water_Source_Name
                        )
                      }
                    >
                      <Text style={styles.autoCompleteText}>
                        {Water_Source_Code + ' ' + Water_Source_Name}
                      </Text>
                    </TouchableOpacity>
                  ),
                }}
              />
              ```

The README mentions a known issue with ScrollViews:

By default the autocomplete will not behave as expected inside a . Set the scroll view's prop to fix this: keyboardShouldPersistTaps={true} for RN <= 0.39, or keyboardShouldPersistTaps='always' for RN >= 0.40. (#5). Alternatively, you can use renderResultList to render a custom result list that does not use FlatList. See the tests for an example.

Perhaps that is causing the issue?

I counter this error and than resolve but don't know why it comes again any other solution.


client: show names of members items in F2P

Depends on !10
Closes #5597
Closes #13282

This PR now also updates sidebar-based plugins to always use the real item name even when on F2P

Would this only show in f2p worlds or only if enabled? Judging by the code just by enabled.

It only affects F2P, since Members objects aren't a thing in P2P

After a chat with abex, it was decided to expose the true name of the item to be usable by sidebar-based plugins. This also ends up fixing multiple other issues of Members item being shown when the client is loaded up on a F2P world.

added in https://github.com/runelite/runelite/commit/09be0b63ce222624594b14bbda9502ed660c1529 and https://github.com/runelite/runelite/commit/fd2c4a40af8102890c742dd014e03bac5e608e77


realText may exceed character limit

I've just used $faker->realText, and despite the default 200 character limit, I encountered a result of 201 characters.
Probably straightforward to fix, but right here I don't have time to fix it, so posting an issue just to keep note.

In fact it happens only with localized providers, and is simply due to multibyte encoding.
As expected, results never exceed the character limit (though the number of bytes may, since db8bba3432059a69540691aac1608c501b1fd27e).


CB-10968 Update iOS 'Requirements & Supports' section

Sorry, the list I provided was for devices that supported iOS 8. I think we should add the devices that went out with iOS 9 (iPhone 6S, iPhone 6S Plus, iPhone SE and iPad Pro)

hmm, missed that earlier. Added them: https://en.wikipedia.org/wiki/IOS_9#Supported_devices


Adding memo to transfer type #248

also adding readscope to Transaction header #70

I'm working on fixing the build, will push in a moment.


chore(util): Update to xxhash v2 and add policy hash functions

Update to the v2 release of xxhash for hashing
Integrate protoc-gen-go-hashpb and add utility functions to hash policies and other protobufs.

Codecov Report

Merging #597 (4b40e45) into main (45aac7f) will increase coverage by 0.04%.
The diff coverage is 68.08%.

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   54.31%   54.36%   +0.04%
==========================================
  Files          82       83       +1
  Lines        8454     8485      +31
==========================================
+ Hits         4592     4613      +21
- Misses       3437     3446       +9
- Partials      425      426       +1

Impacted Files
Coverage Δ

internal/util/hash.go
0.00% <0.00%> (ø)

internal/policy/policy.go
9.67% <80.00%> (+9.67%)
:arrow_up:

internal/compile/compile.go
91.62% <100.00%> (+0.15%)
:arrow_up:

internal/policy/io.go
32.35% <0.00%> (+14.70%)
:arrow_up:


Set up travis CI

@rwinch Fair to assign this to you? We are unable to set up a CI for a spring-project AFAIK.

Yes this is now done


[AVM Module Issue]: Failed to read the file path "./templates/defaultDashboard.tpl"

Describe the issue:
When trying to apply the default examples module, get the following error:

Repro Steps:

Run command az login.
Run command azd auth login.
Run command azd init -t todo-python-mongo-terraform.
Replace the content of infra/main.tf with the following code:module "avm-res-portal-dashboard_example_default" {
  source  = "Azure/avm-res-portal-dashboard/azurerm//examples/default"
  version = "0.1.0"
}

Annotate the contents of the infra/output.tf file.
Run command azd provision.

Expected behavior:
Run command azd provision without any errors.
@mbilalamjad and @jongio for notification.

Sorry, this issue is not in the current repo.😄


chore(app): testing client source materials download

:tada: This PR is included in version 2.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


3.3.5 breaks parsing initial state

<input type="checkbox" name="quadicons_automation_manager" id="quadicons_automation_manager" value="true" data-on-text="Yes" data-off-text="No" checked="checked">

3.3.4: switch is in enabled state
3.3.5: switch is in disabled state
No errors in the console.

still broke on 3.4.0

(https://github.com/Bttstrp/bootstrap-switch/issues/707 and https://github.com/Bttstrp/bootstrap-switch/issues/709 are dups of this issue, referencing)

It appears 3.3.5 and 3.4.0 were not made by @LostCrew, or at least not committed to this repository.
Reporting to npm.

@himdel I've finally read and replied to your email sent to npm. Did you receive my answer? If not, would you mind giving me your email here or somewhere else private?

@LostCrew nope, I have not received any reply in that email thread. Which probably means that npm hasn't received it either, please try again, and use Reply All?
(If you received that email, my mail address is in there.)

@himdel Saw your email address in the first message, let's continue there!

您好，您的来信已收到。
祝好   致礼！


[WIP] test framework to test concurrent controllers with linearization

graphic visualization of an example  run, where two controller instances {0,1} run concurrently, each path from the start node to a leaf node represents a linearized run where the API calls from the two instances are interleaved. The path marked in red shows a failed run.

This may be useful in case we won't be able to avoid having a proper leader election for copies of the controller - or we find a resource managed by multiple controllers.


Update step1_search_by_location.py

Changed the variables names.
EXAMPLE:
all_users==>allUsers.
REASON:
As per industry standard most developers follow this kind of variable name structure so I hope this change would bring clarity to the developers in the future.

This looks better @geekrypter


architect support for multiple clients and protocols

Goose currently makes HTTP/HTTPS requests with the Reqwest client.
The intent is to support multiple HTTP/HTTPS clients (ie, Isahc, curl, hyper, ...), as well as to support other protocols (ie, gRPC), ...).
This ticket is to decide how to best support multiple clients and protocols.

My initial thought was to add protocol/client source files. For example, splitting the current HTTP support into src/http/reqwest.rs and src/http/common.rs. This could be combined with feature flags, which could be used to enable the different clients depending on your load testing needs (and would be necessary to avoid compiling unused dependencies).

My second idea is to split Goose into multiple libraries. So, you'd have a goose library which is the common functionality needed by all protocols and clients. Then you'd have a goose_http which depends on goose and adds the shared http functionality but wouldn't do anything useful itself. And finally you'd have a goose_reqwest library which would expose the actual client. In this design, a load test would depend on ie the goose_reqwest library instead of on goose itself.

I'm not sure if it's yet ready for general use, but tower provides traits for a generic services and tonic is built on top of it and probably some other tokio based networking crates. It might be genericising over the tower service traits could be an easy solution :smile:

@xd009642 thanks, I'll take a look!

I did have a look at it and it ended up being a lot of generics, might make it hard to make it all fit in. My initial thoughts on implementing it would be to create something similar to the current GooseTask::new but doesn't use GooseUser as the input parameter to the function but instead some generic type. That way someone like me using gRPC can replicate what GooseUser but more specific to gRPC. And then also add some form of User trait which exposes the methods currently in GooseUser that goose needs to work.
Potentially replacing GooseUser with a trait object like impl User doing what the trait describes could then be a way to change it and keep existing code working but extend the functionality.
Just an initial thought from a brief skim of the code base and looking at some of the docs. Might not be helpful :sweat_smile:

@xd009642 I appreciate the thoughts and feedback! It would be helpful if in #9 you could add some thoughts about what fields would be needed to support gRPC in the following Goose structures:

GooseRequest
GooseRawRequest
GooseDebug
GooseUser

Currently I'm leaning toward option 2 in my initial list in this ticket, which is to say splitting Goose into multiple libraries. The base Goose library will contain all common code, then the next level would be protocol, for example GooseHTTP and GoosegRPC, and then the third and final level would be library implementation, for example: GooseReqwest and GooseTonic. I expect 2nd and 3rd level libraries will need to implement specific Traits in order to work with Goose. Your project may depend only on GooseTonic, or maybe on all three levels, depending on which sorts of helpers are ultimately exposed from each.
I've only started exploring this briefly on my local development server, it's a long ways from being functional.  The first step will be the creation of GooseReqwest and a second library using a different Rust HTTP client. Once that level of abstraction is working, we'll move onto protocol abstraction.

As a first step, I intend to look at supporting multiple HTTP clients. Toward this goal, I've done a very quick review of Rust HTTP clients to see which might be good additions to Goose. Listed in the order I currently intend to add support:
Clients to support
Surf

Flexible
https://github.com/http-rs/surf
https://docs.rs/surf/2.1.0/surf/
async
multiple clients: curl, h1, hyper, wasm

Isahc

Libcurcl wrapper
https://github.com/sagebind/isahc/ -
https://docs.rs/isahc/0.9.10/isahc/
blocking and async both, sessions/cookies

Hyper

very low-level, Reqwest is built on top of it
https://github.com/hyperium/hyper
https://docs.rs/hyper/0.13.8/hyper/
async
looks like sessions/cookie-jar etc would have to be manually handled

Client Goose will not support:
Curl-rust

Libcurl wrapper
https://github.com/alexcrichton/curl-rust
https://docs.rs/curl/0.4.34/curl/
does not seem to support asnyc

uReq:

no async support
https://github.com/algesten/ureq
https://docs.rs/ureq/1.5.1/ureq/

attohttpc

"lightweight and simple"
https://github.com/sbstp/attohttpc
https://docs.rs/attohttpc/0.16.0/attohttpc/
not async
"for where performance isn't critical"

http_req

"Simple client"
https://github.com/jayjamesjay/http_req
https://docs.rs/http_req/0.7.1/http_req/
not async

A useful blog detailing how we might leverage Tower:
https://tokio.rs/blog/2021-05-14-inventing-the-service-trait


Error building from source

Hi,
I would like to build cracklord from the sources following the instructions in the readme but when I execute the next command:
go get github.com/jmmcatee/cracklord
I get this error:
can't load package: package github.com/jmmcatee/cracklord: no buildable Go source files in /root/work/src/github.com/jmmcatee/cracklord
In the past, I tried to build the sources succesfully with the commands in the wiki but now I can't. Could you help me?
Thanks

You need to build the two programs directly. Instead of building
github.com/jmmcatee/cracklord try building
github.com/jmmcatee/cracklord/cmd/queued and
github.com/jmmcatee/cracklord/cmd/resourced.
On Jul 26, 2016 2:52 AM, "klingsor83"<EMAIL_ADDRESS>wrote:

Hi,
I would like to build cracklord from the sources following the
instructions in the readme but when I execute the next command:
go get github.com/jmmcatee/cracklord
I get this error:
can't load package: package github.com/jmmcatee/cracklord: no buildable
Go source files in /root/work/src/github.com/jmmcatee/cracklord
In the past, I tried to build the sources succesfully with the commands in
the wiki but now I can't. Could you help me?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jmmcatee/cracklord/issues/121, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoUHLmtYz6wYbWx4bmYoXZ1aWBVZVg2ks5qZbymgaJpZM4JU4GO
.

Thanks @jmmcatee  but if I execute:
go get github.com/jmmcatee/cracklord/cmd/queued
I get the next error:
# github.com/jmmcatee/cracklord/cmd/queued src/github.com/jmmcatee/cracklord/cmd/queued/req_functions.go:510: undefined: logrus.WithError

This commit (7d7352e5115e1d5ec4184f68b86e7a95adf1dc74) I just made to master fixed this issue.


Folder search

Hi Schulte,currently, you I select folders as input and attach extra parameters for Peaks files. If I want to use result files from various different software tools (such as pNovo and Casanovo) placed in a folder as input and also set parameters like CutoffScore, how should I proceed?

Personally I have not used the folder option in a long while. There is no way you can set any of the parameters you mentioned for a Folder input. Additionally pNovo and Casanovo files will not be openend if you use the Folder input, because it will assume all .csv files to be Peaks files. I wrote this Folder input before I added support for any of the other file formats. Your best way forward for now would be to list all files separately. If you kepe using it in this way and having the Folder input option extended would be of help to you feel free to reach out again so that we can discuss how exactly it should behave.

Thank you for your response. I would like to use data from multiple enzyme cleavages together as input, which might provide better coverage. I've thought of two possible solutions: one is to merge de novo sequencing data from multiple enzyme cleavages into a single file as input, and the other is to first convert de novo sequencing data from multiple enzyme cleavages into a reads format. Since this would result in the loss of relevant scoring information, we need to confirm whether Stitch performs deletion for reads below the cutoff score. Additionally, PEAKs has a LocalCutoffALC in the stitch parameters, but pNovo and casanovo do not. I'd like to inquire if, for reads below the local cutoff ALC, they are entirely removed. Once these details are clarified, we can apply the cutoff during the conversion to the reads format. Do you think this approach is feasible?

First up one thing, you can have multiple input files in a single stitch run, just list them one after another in the input section:
Input ->
    Peaks ->
        Path     : ../datasets/200305_HER_test_04_DENOVO.csv
        Format   : Ab
        Name     : 01
        CutoffALC: 11
        -RawDataDirectory: R:\F1\peng0013\201912
        -XleDisambiguation: True
    <-
    Peaks ->
        Path     : ../datasets/200305_HER_test_05_DENOVO.csv
        Format   : Ab
        Name     : 02
        CutoffALC: 11
        -RawDataDirectory: R:\F1\peng0013\201912
        -XleDisambiguation: True
    <-
    Peaks ->
        Path     : ../datasets/200305_HER_test_06_DENOVO.csv
        Format   : Ab
        Name     : 03
        CutoffALC: 11
        -RawDataDirectory: R:\F1\peng0013\201912
        -XleDisambiguation: True
    <-
<-

So there should be no need for any file concatenation outside of stitch. For any reads below the cutoffALC/Score stitch fully ignores the reads, they will not be shown anywhere, you could call that deletion but your files are not touched in any way. The  LocalCutoffALC is used for the peaks format to retrieve smaller patches out of longer sequences that in full do not score well enough to be included, but have smaller stretches of amino acids that all score above the LocalCutoffALC (with a minimal length controlled by MinLengthPatch), these smaller patches will then be used a normal peptides. This is only implemented for Peaks because at the time of implementing we only used Peaks and since a long time we have not touched this option as it did not really seem to help our results, so I did not implement it for any of the other formats.

Thank you very much for your help and guidance. I understand your suggestions, and I will try the methods you mentioned above. Your assistance is greatly appreciated.


Bump Dependencies #3998344731

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/3998344731

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Added swedish translation

Hope this helps, could I get an invite to test the app? ;-)

Hope this helps, could I get an invite to test the app? ;-)

You can actually delete all files but the strings.xml from the values-sv folder. Or do you want a swedish specific styling for the app? :P
Contact me with my mail address shown on my profile page regarding test access.

Hope this helps, could I get an invite to test the app? ;-)

You can actually delete all files but the strings.xml from the values-sv folder. Or do you want a swedish specific styling for the app? :P
Contact me via my mail address shown on my profile page regarding test access.

I'm no Yoda i XML-markup, my biggest contribution would be that I speak Swedish ;-) I think many user might be from Sweden for this type of app.
I'll send an email to you.

@robinhellstrom if you check that checkbox "Allow edits from maintainers" on the right I can edit your pull request and delete the unneccessary files before merging 😉

@robinhellstrom if you check that checkbox "Allow edits from maintainers" on the right I can edit your pull request and delete the unneccessary files before merging wink

Yes, that's active now.

Good work! Some comments:

Perhaps we should  "kurva" or "graf" instead of "diagram"?
Generally, cross check the translations with the german version will most likely result in better wordings as I understand this is the native language of @Ixam97


Queue fixes and cleanups, work queue -> task spawn

This PR

cleans up imports in common.rs
cleans up a few pointer operations around the wifi queue
change send_queued to no longer assume that enqueue succeeds
fixed the way timeouts are detected
If in the previous code the now() + block_time overflowed, the code exited immediately because now() > (now()+block_time) was true. Instead, we calculate the number of elapsed ticks and compare that to the timeout. I get that this is basically once every 2 thousand years or so, but still incorrect :)
I've done some cleaning up in the task spawning code that was masquerading as a work queue.

Back to draft, subtracting doesn't just work with 52-bit underlying timers.


Setup documentation

Hey @teivah,
I'd like to explore this framework, but I'm unsure how to get going here. Is go get the right option?

Hi,
Thanks for your interest. You're right, there's a lack of documentation, in particular regarding the setup. Yet go get or the go dep tools for example should do the trick for the time being.  The only problem you may have is this: https://github.com/teivah/gosiris#troubleshooting.
Please let me know if you have further problems. I keep this issue open until we have a proper doc.


Excellent Trojan - detected by kaspersky , bit defender

Detected as Trojan , deleted by antivirus immediately.

Hi @MrBenzWorld, when we pushed out an auto-update yesterday it was detected as a trojan by some anti-viruses. We are working on getting this remedied as soon as possible.
Related #2519

Merging with https://github.com/ollama/ollama/issues/2519. This is a false positive and is a common issue in Go projects https://go.dev/doc/faq#virus

This issue hasn't gone away:


[REF-144] Automatically memoize stateful components

If a component depends on state or emits events, render it as its own component function outside of the page component.
The page itself no longer depends on state; this means any non-stateful components will not re-render when the state changes.
This results in a 10x re-render speedup on complex pages of reflex-web, like /docs/state/events/. With current main branch a react re-render consumes approximately 110ms, and with this branch, its down to about 13ms! ⚡
Some parts are still a bit ugly and need refinement, but this can now be tested against reflex-web repo.

Current implementation is not working with style props that depend on state or flexdown evaluated components that depend on state.

close in favor of #2198


Beautify contact page

Fixes issue - #13
Screenshots

Changed the border radius of input areas and of the buttons. Also added the selection, so that if user selects any text, the background color and the text color looks pretty.

Someone already made the same changes before you @yaten2302 , check the current version of website

Someone already made the same changes @yaten2302 , check the code in the file changed section
Alternatively since you are willing to work
You can add shadow to the input fields
And other things like error msg if the input is not in the right format in the fields and other things which you can think of


Specific iteration optimization

Bug Report
Description
this is not actually a big deal but i was skimming trough the codebase working on another issue and saw an unnecesary double loop first to filter and then to present the <option>s, see image below.
Bug Summary:
this section of the code could be optimized with just a conditional
Steps to Reproduce:
src/lib/components/chat/Settings/Interface.svelte lines 194-198
Expected Behavior:
do just one iteration
Actual Behavior:
does two iterations
Environment

Operating System: Windows
Browser (if applicable): None

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I have reviewed the troubleshooting.md document.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
[Include relevant browser console logs, if applicable]
Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):

Installation Method
none
Additional Information
none

i just found another loop like that one

i just found another loop like that one

in the end there were several (5 more) all of them addressed on #969 (^^")


Partially completed txn has mysterious state: 'complete'

I have a transaction which has state : 'complete'
It has many items. Some of the items are state : 'done' and some of them are state : 'pending'
It appears as if the transaction failed to fully complete the first time around, and there may have been an attempt to recover it with _repairAllIncomplete
However - I can't find any situation where the library will set  state : 'complete' for a transaction. That's the name of a selfRepairMode not a transaction state, as I understand it.
Does this ring any bells? In the meantime, I'll keep looking.

That's strange.  The line that sets the transaction state to done is here.  But this should only happen if all items were successfully set to state: done.
I can't find anywhere in the codebase that would set a txn state: complete.  I'll keep looking as well.

I found it: here

looks like when it's recovering from a hardware failure, it sets the state of the transaction to be the mode for recovery

Yep, you're right.  That's a bug.  I'll release a new version with a fix in the next few hours.

Thank you so much :)
FWIW: it seems that if Transact.prototype._repairIncomplete fails you get  this line

Actually, now that I look at it, I think it might have been intentional.  It's to prevent the same transaction from being continually "repaired" on app startup if it can't actually be repaired.  The intention was (I'm guessing -- it's so long ago, I can't really remember) to set the state to something other than pending and to also record the type of fix attempted (rollback or complete).  In hindsight, the state should be repairing-by-rollback or repairing-by-complete or maybe just state: repairing with repairMethod: rollback or repairMethod: complete, until it either succeeds or fails.
I'll think about it about more and release a new version soon.

I see, that makes sense to avoid continually retrying a repair that can't be completed.
It might also be good to have a method for retrying failed repairs, or perhaps have a setting that enables continual retrying, or a certain number of retry attempts.
The reason in my case the txn was failing seems to be the process running out of memory due to the sheer size of Mongo operations ( 3700 items ). In cases where it's failing because of resource overload / unreliable hardware then retrying failed repairs can make sense.

I'd be happy to help with coding this stuff too. Let me know if you'd like any help.

P.S. when I say "continually retry" or "retry X times" I don't mean retry immediately. I mean they'd be retried next time the app is restarted - e.g. after you've fixed a separate problem in the app that was hogging resources.

Any help with the coding would be gratefully received!
One scenario I want to avoid is: the retry attempt itself crashes the server process, the process restarts (via forever, or pm2 or systemd) and then the retry crashes it again, etc., etc.  This would be a very bad thing if it happened on a production server!

I had a look at your latest changes - they look great, thank you so much!
One small little thing... perhaps when calling retryFailedRepairs, it could also retry txns that crashed the process the first time around? I've submitted a PR with this change.

Cool. Thanks for that.  I've just published a new version with the PR merged.


SDS seekOverwrittenData error in 1hrs stress test with DSP KWD wakeword

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:
We have added a DSP Wakeword detect on top of the 1.8.0 and during the wakeup stress test we are seeing a crash after 1hrs. The Sample App fails to swith to the Listening mode thowing the following error.
2018-07-18 09:32:23.011 [  e] 0 xxxxxxKeywordObserver:onKeyWordDetected:event=starting microphone stream
starting Microphone Streaming
@@@@ startStreamingMicrophoneData @@@@
2018-07-18 09:32:23.012 [ 13] E SdsReader:seekFailed:reason=seekOverwrittenData
2018-07-18 09:32:23.012 [ 13] E InProcessAttachmentReader:ConstructorFailed:reason=could not create an SDS reader
2018-07-18 09:32:23.012 [ 13] E InProcessAttachmentReader:createFailed:reason=object not fully created
2018-07-18 09:32:23.012 [ 13] E AudioInputProcessor:executeRecognizeFailed:reason=Failed to create attachment reader
2018-07-18 09:33:11.177 [  e] E AbstractKeywordDetector:readFromStreamFailed:reason=streamOverrun,numWordsOverrun=18446744073709551456
2018-07-18 09:33:11.178 [  e] E AbstractKeywordDetector:readFromStreamFailed:reason=streamOverrun,numWordsOverrun=18446744073709551456
2018-07-18 09:33:11.179 [  e] E AbstractKeywordDetector:readFromStreamFailed:reason=streamOverrun,numWordsOverrun=18446744073709551456
2018-07-18 09:33:11.179 [  e] E AbstractKeywordDetector:readFromStreamFailed:reason=streamOverrun,numWordsOverrun=18446744073709551456
What is the expected behavior?

What behavior are you observing?

Provide the steps to reproduce the issue, if applicable:

Tell us about your environment:
PicoPi (IMX7) + DSP chip
What version of the AVS Device SDK are you using?
  1.8.0

Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[y ] Other - tell us more:
IMX7 PicoPi

Tell us about your OS (Type & version):

[y ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

@BennyAvramson ,
Thanks for the suggestion. i looked at the post and checked the CPU status and its under 5% all the time.   The network bandwidth also looks fine for me.
Anyway, i will go ahead and try increasing the SDS buffer size to see that has any impact on the issue.
Do you have any other inputs to try out?
Regards,
Deepu Raj

Let me know how increasing the SDS buffer size went.
Thanks,
Benny

We still face the same issue with different SDS buffer size also. The network speed also looks good as we have a script to monitor the same.

I am closing this issue due to inactivity. Please feel free to re-open it if it has been closed in error.


Add a "Correct-your-DEM cheatsheet" page to the documentation?

Most interactions I have with users are about knowing the right tool to deal with their DEM issues, typically "here's this bias I have, what's the cause and how to correct it?".
The most common scenarios:

Positive/Negative errors that look like the landforms = Horizontal coregistration,
Big vertical error that is only positive or negative error, but not completely consistent everywhere = Vertical reference (geoid/ellipsoid),
Patterns of errors after co-registration: What bias correction or other affine registration to use?
Positive/negative errors around point samples: What method to use to compare point and raster data? (rasterizing points within pixels creates location biases, need to interpolate the raster at point locations).

We could have a "Cheatsheet" for users to look up if their scenario falls among the typical ones (with illustrated example), and point towards the right xDEM tools. :slightly_smiling_face:

Great idea !


fix(#33): Pipes in children

Fixing pipe closing in children; need to research using valgrind with child processes, too

So, turns out there were several things causing the issue and making it difficult to notice.

Not closing unneeded pipes in children
Wrong fork behaviour: execve called in parent instead of child because of the wrong choosing between the child and the parent
Not closing pipes in parent before waiting for children

Number 2 is the funniest, IMHO. Turns out waitpid wasn't called because in child process all pids were zero. And that's why unclosed pipes didn't prevent the minishell process from hanging.
Anyway, #33 solves the problem. I also split the tests into independent problem, it makes it easier to isolate problems with hanging processes.


1.23 backport: Move ambient to REDIRECT mode instead of tproxy (#52622)

This is the same as the master PR, but off by default. This will allow some of the impacted users to stay on 1.23 but preview the feature, which should hopefully unblock them and give us more feedback,

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.23
c0e114036e66c559ebbce2065b9ad45fb2031224
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio_release-1.23
c0e114036e66c559ebbce2065b9ad45fb2031224
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


.editorconfig built-in support for VSCode

VSCode does not support/obey coding styles specified in .editorconfig file, out of the box. This functionality is currently provided by EditorConfig for VS Code plugin.
Editorconfig is a specification for coding styles and environment preferences to be obeyed while contributing/modifying source code. This is a feature increasingly supported by text editors of late as well as popular IDEs such as entire IntelliJ suite and Visual Studio 2017 as well. Can we have support for .editorconfig file built right in VS Code as well?
The EditorConfig website (linked above) contains details on availability and support over different platforms.

AS you said, there is an Editor config extension for this. I do not think we have plans to make it built in.

EditorConfig is present in Visual Studio, which may be confusing (at least I thought it is working even in VS Code).


Hide the messages popup when entering the command line

Problem: Command line is obscured by notification popup when cmdheight=0
Solution: Hide the popup when entering command line
I'm not sure this patch is perfect, but steps to reproduce are below:

vim --clean --cmd 'set cmdheight=0'
:echo 'this is a test'
(within 3 seconds) type :something

Expect: :something is shown (i.e. the command line is visible)
Actual: the this is a test popup is drawn over the command line.

It was working OK for me...   Looks like I missed a file in the patch.  I'll merge this in.


workflows: extend the test range

We don't necessarily need to stop testing on older versions for libraries, we can just extend the test range using the new workflow

@gurgunday The engines field in package.json is >=14 so this should probs be tested on that too, or we bump the engine.

Good spot, first, we should actually remove the engines field
Second, I think tap is failing at node 14 so I had to start from the lowest LTS version it currently supports

Oh or maybe we shouldn't? Since this is a package?


containerd is set up to use proxies for crictl pulls, but not for ctr pulls.

Description
containerd is set up to use proxies for crictl pulls, but not for ctr pulls.

cmd := exec.Command(filepath.Join(s.Root, "bin/containerd"), args...)
cmd.Env = append(os.Environ(), "HTTPS_PROXY=http://<IP_ADDRESS>:85")
Steps to reproduce the issue

Describe the results you received and expected
crictl pulls mirrors through proxy, ctr command doesn't work
What version of containerd are you using?
github.com/k3s-io/containerd v1.7.7-k3s1.26
Any other relevant information
No response
Show configuration if it is related to CRI plugin.
No response

containerd is started by using go's cmd command.ctr pulls the mirror operation:ctr --address /home/test/containerd/run/containerd.sock images pull docker-registry:81/test.

Can you try HTTPS_PROXY=YOUR_ADDR ctr --address /home/test/containerd/run/containerd.sock images pull docker-registry:81/test.
On my laptop, this makes the proxy work: sudo HTTPS_PROXY=https://<IP_ADDRESS>:80 ctr --debug i pull docker.io/library/aline:latest
crictl communicates with containerd's cri service which is part of containerd process. So it gets the env var you passed to containerd.
ctr is a separate CLI process, so it doesn't aware of containerd' env var.

This is possible, but I want to solve the problem of pulling the image automatically when the service starts, instead of manually going through ctr to pull the image。And I can't use export https_proxy because that would cause my other services to use this proxy address as well. Is there any other way to set only one environment variable for the proxy address for ctr, without having to set https_proxy when executing a ctr pull?

I'm not aware of existing features that you can enable proxy for ctr by default.
https://github.com/containerd/containerd/issues/8377 has a potential solution that may solve your problem (basically set up proxy via hosts.toml).

ok！Thanks

@gaoyonglong actually, did you look into containerd's host config? Does making <IP_ADDRESS>:85 as a mirror of a specific registry(s), or _default work for your case?

I found that my business needs were satisfied with crictl being able to pull mirrors through the container agent just fine, and didn't pursue the feasibility of ctr


SANE hangs when using brscan5 backend with certain scanners

Describe the bug
SANE hangs when reading the results of a scan using brscan5 backend and the ADS-2800 scanner.
Observations:

Can find and connect to the scanner
Is able to detect when the document feeder is empty or full
Is able to initiate a scan
Appears to hang when reading the scanned bytes from the document
Same behavior observed regardless of connecting via WLAN, LAN, or USB.
Same behavior observed when using version 1.2.9 and 1.2.7 (1.2.6 from nixos-21.11 is no longer provided on Brother's website)
Same behavior observed after disabling firewalls and ipv6
Same behavior observed after enabling + disabling avahi with nssmdns and reflector enabled + disabled as well
I have another scanner in my Brother printer (HL-L2395DW) which works fine under these configurations; though it connects using the  sane-escl backend (escl:http://fe80::dee9:94ff:fe1b:9728:80)

Steps To Reproduce

Connect an ADS-2XXX scanner from Brother to your local network or computer via USB
Set up the following configuration:

  # Scanning driver for Brother scanners (brother no longer provides the default version in nixpkgs)
  nixpkgs.overlays = [
    (self: super: {
      brscan5 = config.nix-unstable.brscan5; # Alias for nixos-unstable since broken on nixos-21.11
    })
  ];
  hardware.sane = {
    enable = true;
    brscan5.enable = true;
  };
  services.saned.enable = true;

Attempt to scan using any scanner (e.g., simplescan, gscan2pdf, scanimage, etc.)
Program will hang after the scanner scans the documents (yes, the scanner does actually scan the documents; SANE just cannot read the results using this backend)

Expected behavior
SANE is able to read the scanned bytes back rather than hang.
Logs
Here is an stace of the a scanimage run when connected via USB. Notice that it appears to hang when trying to first read the results of the scanned image: https://pastebin.com/M3iU0LLU
Results of netstat -tuonp for the saned ports:

tcp        9      0 <IP_ADDRESS>:6566          <IP_ADDRESS>:36186         CLOSE_WAIT  1/systemd            off (0.00/0/0)
tcp        9      0 <IP_ADDRESS>:6566          <IP_ADDRESS>:36174         CLOSE_WAIT  1/systemd            off (0.00/0/0)
tcp        0      0 <IP_ADDRESS>:36252         <IP_ADDRESS>:6566          ESTABLISHED 331273/scanimage     off (0.00/0/0)
tcp        0      0 <IP_ADDRESS>:6566          <IP_ADDRESS>:36244         ESTABLISHED 1/systemd            off (0.00/0/0)
tcp        0      0 <IP_ADDRESS>:36244         <IP_ADDRESS>:6566          ESTABLISHED 327271/simple-scan   off (0.00/0/0)
tcp        9      0 <IP_ADDRESS>:6566          <IP_ADDRESS>:36148         CLOSE_WAIT  1/systemd            off (0.00/0/0)
tcp        0      0 <IP_ADDRESS>:6566          <IP_ADDRESS>:36252         ESTABLISHED 1/systemd            off (0.00/0/0)

Results of scanimage -L:

device `v4l:/dev/video1' is a Noname HD Webcam C615 virtual device
device `net:localhost:brother5:bus3;dev3' is a Brother ADS-2800W USB scanner

Results of  brsaneconfig5 -d

sane-find-scanner

  # sane-find-scanner will now attempt to detect your scanner. If the
  # result is different from what you expected, first make sure your
  # scanner is powered up and properly connected to your computer.

  # No SCSI scanners found. If you expected something different, make sure that
  # you have loaded a kernel SCSI driver for your SCSI adapter.
  # Also you need support for SCSI Generic (sg) in your operating system.
  # If using Linux, try "modprobe sg".

could not open USB device 0x1d6b/0x0003 at 008:001: Access denied (insufficient permissions)
could not open USB device 0x04d9/0x4545 at 007:010: Access denied (insufficient permissions)
could not open USB device 0x046d/0xc52b at 007:009: Access denied (insufficient permissions)
could not open USB device 0x0a5c/0x21e8 at 007:008: Access denied (insufficient permissions)
could not open USB device 0x0bda/0x5411 at 007:007: Access denied (insufficient permissions)
could not open USB device 0x0556/0x0001 at 007:006: Access denied (insufficient permissions)
could not open USB device 0x046d/0x082c at 007:005: Access denied (insufficient permissions)
could not open USB device 0x0bda/0x5411 at 007:003: Access denied (insufficient permissions)
could not open USB device 0x0e8d/0x7612 at 007:002: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0002 at 007:001: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0003 at 006:001: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0002 at 005:001: Access denied (insufficient permissions)
could not open USB device 0x174c/0x3074 at 004:002: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0003 at 004:001: Access denied (insufficient permissions)
found USB scanner (vendor=0x04f9 [Brother], product=0x03b9 [ADS-2800W]) at libusb:003:007
could not open USB device 0x174c/0x2074 at 003:002: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0002 at 003:001: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0003 at 002:001: Access denied (insufficient permissions)
could not open USB device 0x8087/0x0029 at 001:004: Access denied (insufficient permissions)
could not open USB device 0x0b05/0x18f3 at 001:005: Access denied (insufficient permissions)
could not open USB device 0x05e3/0x0610 at 001:003: Access denied (insufficient permissions)
could not open USB device 0x1d6b/0x0002 at 001:001: Access denied (insufficient permissions)
  # Your USB scanner was (probably) detected. It may or may not be supported by
  # SANE. Try scanimage -L and read the backend's manpage.

  # Not checking for parallel port scanners.

  # Most Scanners connected to the parallel port or other proprietary ports
  # can't be detected by this program.

  # You may want to run this program as root to find all devices. Once you
  # found the scanner devices, be sure to adjust access permissions as
  # necessary.
-----------------------------
ls -R -all /proc/bus/usb
ls: cannot access '/proc/bus/usb': No such file or directory
-----------------------------
cat /proc/bus/usb/devices
cat: /proc/bus/usb/devices: No such file or directory
-----------------------------
scanimage -L
device `v4l:/dev/video1' is a Noname HD Webcam C615 virtual device
device `net:localhost:brother5:bus3;dev3' is a Brother ADS-2800W USB scanner
-----------------------------
-----------------------------
ping

Notify maintainers
@mattchrist
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.25, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.16`
 - channels(root): `"nixos-21.11.336177.1622abf0e78"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Note there are some errors in the syslog as well:
x2022-02-28T21:30:50.263<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36240).                                                                                x
x2022-02-28T21:30:50.265<PHONE_NUMBER> saned@58-<IP_ADDRESS>:6566-<IP_ADDRESS>:36240.service saned[318890] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:30:50.266<PHONE_NUMBER> saned@58-<IP_ADDRESS>:6566-<IP_ADDRESS>:36240.service saned[318890] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:30:50.266<PHONE_NUMBER> saned@58-<IP_ADDRESS>:6566-<IP_ADDRESS>:36240.service saned[318890] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:30:50.321<PHONE_NUMBER> saned@58-<IP_ADDRESS>:6566-<IP_ADDRESS>:36240.service saned[318890] DEBUG saned exiting                                                                                x
x2022-02-28T21:30:50.323<PHONE_NUMBER> init.scope systemd[1] INFO saned@58-<IP_ADDRESS>:6566-<IP_ADDRESS>:36240.service: Deactivated successfully.                                                                         x
x2022-02-28T21:31:44.892<PHONE_NUMBER> systemd-udevd.service systemd-udevd[326047] ERROR /nix/store/760c3b028xnjq52yfvk61m5xbky0l4v2-udev-rules/49-brother-mfp-brscan5-1.0.2-2.rules:17 Invalid key 'SYSFS'          x
x2022-02-28T21:31:54.241<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36242).                                                                                x
x2022-02-28T21:31:54.243<PHONE_NUMBER> saned@59-<IP_ADDRESS>:6566-<IP_ADDRESS>:36242.service saned[326286] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:31:54.243<PHONE_NUMBER> saned@59-<IP_ADDRESS>:6566-<IP_ADDRESS>:36242.service saned[326286] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:31:54.243<PHONE_NUMBER> saned@59-<IP_ADDRESS>:6566-<IP_ADDRESS>:36242.service saned[326286] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:31:54.299<PHONE_NUMBER> saned@59-<IP_ADDRESS>:6566-<IP_ADDRESS>:36242.service saned[326286] DEBUG saned exiting                                                                                x
x2022-02-28T21:31:54.301<PHONE_NUMBER> init.scope systemd[1] INFO saned@59-<IP_ADDRESS>:6566-<IP_ADDRESS>:36242.service: Deactivated successfully.                                                                         x
x2022-02-28T21:32:06.737<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36244).                                                                                x
x2022-02-28T21:32:06.739<PHONE_NUMBER> saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service saned[327901] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:32:06.739<PHONE_NUMBER> saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service saned[327901] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:32:06.739<PHONE_NUMBER> saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service saned[327901] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:33:30.971<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36246).                                                                                x
x2022-02-28T21:33:30.973<PHONE_NUMBER> saned@61-<IP_ADDRESS>:6566-<IP_ADDRESS>:36246.service saned[329792] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:33:30.973<PHONE_NUMBER> saned@61-<IP_ADDRESS>:6566-<IP_ADDRESS>:36246.service saned[329792] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:33:30.973<PHONE_NUMBER> saned@61-<IP_ADDRESS>:6566-<IP_ADDRESS>:36246.service saned[329792] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:33:30.982<PHONE_NUMBER> saned@61-<IP_ADDRESS>:6566-<IP_ADDRESS>:36246.service saned[329792] DEBUG saned exiting                                                                                x
x2022-02-28T21:33:30.983<PHONE_NUMBER> init.scope systemd[1] INFO saned@61-<IP_ADDRESS>:6566-<IP_ADDRESS>:36246.service: Deactivated successfully.                                                                         x
x2022-02-28T21:33:41.556<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36248).                                                                                x
x2022-02-28T21:33:41.558<PHONE_NUMBER> saned@62-<IP_ADDRESS>:6566-<IP_ADDRESS>:36248.service saned[329990] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:33:41.558<PHONE_NUMBER> saned@62-<IP_ADDRESS>:6566-<IP_ADDRESS>:36248.service saned[329990] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:33:41.558<PHONE_NUMBER> saned@62-<IP_ADDRESS>:6566-<IP_ADDRESS>:36248.service saned[329990] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:33:41.612<PHONE_NUMBER> saned@62-<IP_ADDRESS>:6566-<IP_ADDRESS>:36248.service saned[329990] DEBUG saned exiting                                                                                x
x2022-02-28T21:33:41.614<PHONE_NUMBER> init.scope systemd[1] INFO saned@62-<IP_ADDRESS>:6566-<IP_ADDRESS>:36248.service: Deactivated successfully.                                                                         x
x2022-02-28T21:33:51.876<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36250).                                                                                x
x2022-02-28T21:33:51.878<PHONE_NUMBER> saned@63-<IP_ADDRESS>:6566-<IP_ADDRESS>:36250.service saned[330164] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:33:51.878<PHONE_NUMBER> saned@63-<IP_ADDRESS>:6566-<IP_ADDRESS>:36250.service saned[330164] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:33:51.878<PHONE_NUMBER> saned@63-<IP_ADDRESS>:6566-<IP_ADDRESS>:36250.service saned[330164] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:33:52.147<PHONE_NUMBER> saned@63-<IP_ADDRESS>:6566-<IP_ADDRESS>:36250.service saned[330164] DEBUG saned exiting                                                                                x
x2022-02-28T21:33:52.147<PHONE_NUMBER> init.scope systemd[1] INFO saned@63-<IP_ADDRESS>:6566-<IP_ADDRESS>:36250.service: Deactivated successfully.                                                                         x
x2022-02-28T21:34:17.108<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36252).                                                                                x
x2022-02-28T21:34:17.110<PHONE_NUMBER> saned@64-<IP_ADDRESS>:6566-<IP_ADDRESS>:36252.service saned[331276] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:34:17.111<PHONE_NUMBER> saned@64-<IP_ADDRESS>:6566-<IP_ADDRESS>:36252.service saned[331276] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:34:17.111<PHONE_NUMBER> saned@64-<IP_ADDRESS>:6566-<IP_ADDRESS>:36252.service saned[331276] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:35:43.714<PHONE_NUMBER><EMAIL_ADDRESS>sudo[335629] STATS     jack : TTY=pts/1 ; PWD=/home/jack/downloads/1.2.9/data/opt/brother/scanner/brscan5 ; USER=root ; COMMAND=/run/current-system/sw/bin/nx
x2022-02-28T21:55:37.813<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36254).                                                                                x
x2022-02-28T21:55:37.815<PHONE_NUMBER> saned@65-<IP_ADDRESS>:6566-<IP_ADDRESS>:36254.service saned[375766] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:55:37.816<PHONE_NUMBER> saned@65-<IP_ADDRESS>:6566-<IP_ADDRESS>:36254.service saned[375766] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:55:37.816<PHONE_NUMBER> saned@65-<IP_ADDRESS>:6566-<IP_ADDRESS>:36254.service saned[375766] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:55:37.871<PHONE_NUMBER> saned@65-<IP_ADDRESS>:6566-<IP_ADDRESS>:36254.service saned[375766] DEBUG saned exiting                                                                                x
x2022-02-28T21:55:37.873<PHONE_NUMBER> init.scope systemd[1] INFO saned@65-<IP_ADDRESS>:6566-<IP_ADDRESS>:36254.service: Deactivated successfully.                                                                         x
x2022-02-28T21:57:09.485<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36256).                                                                                x
x2022-02-28T21:57:09.488<PHONE_NUMBER> saned@66-<IP_ADDRESS>:6566-<IP_ADDRESS>:36256.service saned[377466] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T21:57:09.489<PHONE_NUMBER> saned@66-<IP_ADDRESS>:6566-<IP_ADDRESS>:36256.service saned[377466] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T21:57:09.489<PHONE_NUMBER> saned@66-<IP_ADDRESS>:6566-<IP_ADDRESS>:36256.service saned[377466] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T21:57:09.545<PHONE_NUMBER> saned@66-<IP_ADDRESS>:6566-<IP_ADDRESS>:36256.service saned[377466] DEBUG saned exiting                                                                                x
x2022-02-28T21:57:09.547<PHONE_NUMBER> init.scope systemd[1] INFO saned@66-<IP_ADDRESS>:6566-<IP_ADDRESS>:36256.service: Deactivated successfully.                                                                         x
x2022-02-28T22:10:19.462<PHONE_NUMBER> systemd-udevd.service systemd-udevd[410827] ERROR /nix/store/zllvgdiwrnnysw2a4j4pqayr8bfq6cps-udev-rules/49-brother-mfp-brscan5-1.0.2-2.rules:17 Invalid key 'SYSFS'          x
x2022-02-28T22:10:32.951<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36258).                                                                                x
x2022-02-28T22:10:32.954<PHONE_NUMBER> saned@67-<IP_ADDRESS>:6566-<IP_ADDRESS>:36258.service saned[411140] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T22:10:32.954<PHONE_NUMBER> saned@67-<IP_ADDRESS>:6566-<IP_ADDRESS>:36258.service saned[411140] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T22:10:32.954<PHONE_NUMBER> saned@67-<IP_ADDRESS>:6566-<IP_ADDRESS>:36258.service saned[411140] DEBUG init: access granted to<EMAIL_ADDRESS>                                                                  x
x2022-02-28T22:10:33.009<PHONE_NUMBER> saned@67-<IP_ADDRESS>:6566-<IP_ADDRESS>:36258.service saned[411140] DEBUG saned exiting                                                                                x
x2022-02-28T22:10:33.011<PHONE_NUMBER> init.scope systemd[1] INFO saned@67-<IP_ADDRESS>:6566-<IP_ADDRESS>:36258.service: Deactivated successfully.                                                                         x
x2022-02-28T22:11:30.950<PHONE_NUMBER> saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service saned[327901] DEBUG saned exiting                                                                                x
x2022-02-28T22:11:30.956<PHONE_NUMBER><EMAIL_ADDRESS>systemd[4753] STATS app-gnome-simple\x2dscan-327271.scope: Consumed 3.097s CPU time.                                                                        x
x2022-02-28T22:11:30.957<PHONE_NUMBER> init.scope systemd[1] INFO saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service: Deactivated successfully.                                                                         x
x2022-02-28T22:11:30.957<PHONE_NUMBER> init.scope systemd[1] INFO saned@60-<IP_ADDRESS>:6566-<IP_ADDRESS>:36244.service: Consumed 547ms CPU time, received 320B IP traffic, sent 7.5K IP traffic.                          x
x2022-02-28T22:11:39.572<PHONE_NUMBER> init.scope systemd[1] INFO Started Scanner Service (<IP_ADDRESS>:36260).                                                                                x
x2022-02-28T22:11:39.574<PHONE_NUMBER> saned@68-<IP_ADDRESS>:6566-<IP_ADDRESS>:36260.service saned[412859] DEBUG saned (AF-indep+IPv6+systemd) from sane-backends 1.0.32 starting up                                       x
x2022-02-28T22:11:39.574<PHONE_NUMBER> saned@68-<IP_ADDRESS>:6566-<IP_ADDRESS>:36260.service saned[412859] DEBUG check_host: access by remote host: <IP_ADDRESS>                                                              x
x2022-02-28T22:11:39.574<PHONE_NUMBER> saned@68-<IP_ADDRESS>:6566-<IP_ADDRESS>:36260.service saned[412859] DEBUG init: access granted to<EMAIL_ADDRESS>

Thanks for the detailed report. I don't have an ADS-2XXX scanner to test with but I'll try to explore this issue when I make some time.

Happy to try out any recommendations from you as a proxy for testing; unfortunately, I have exhausted by knowledge of without getting into de-compilation. One thing that might help is to verify if 1.2.6 works or if the ADS series never worked at all with this package. If you have a link to a copy of the .deb, I am happy to plug it in an test (unfortunately, Brother no longer hosts it).

For what it's worth I've confirmed that my DS-640 still works with the 1.2.7-0 driver.
My tests so far have only been through USB, like this scanimage --device-name=brother5:bus2\;dev4 --format=png -o temp.png. That does seem to differ from your tests, which are going through saned.
Does scanimage work for you going direct to your device instead of through saned?
I am getting an error going through saned, but it seems to differ from your report (it doesn't hang).
> scanimage --device-name=net:localhost:brother5:bus2\;dev4 --format=png -o temp.png
scanimage: rounded value of br-x from 215.9 to 215.88
scanimage: rounded value of br-y from 355.6 to 355.567
scanimage: sane_start: Invalid argument

Arch wiki has an entry about firewall-related stuff causing hanging that sounds similar. I know you said you tried by disabling the firewall and such, but it might be illuminating to see what's happening on the wire.
Could you try to do a packet capture of the sane traffic? I think something like this should work:
sudo tcpdump -i lo port 6566 -w saned.pcap
Additionally, can you enable debug logging for the sane daemon?
  systemd.services."saned@" = {
      environment = {
        SANE_DEBUG_DLL="7"; SANE_DEBUG_BROTHER5="7"; SANE_DEBUG_NET="7";
      };
  };

I think that should get us some more detailed logs from the sane daemon.

Thanks you for the follow-up! All look like great next steps. I am in the middle of a move, so I will submit a detailed follow-up on these action items next week.


Need for urgent changes in GitHub Actions automation

This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.
It is up to maintainers to decide if it must be addressed in one or multiple PRs.
Below are 3 different sections describing 3 different important ci/cd changes.
IMPORTANT-START
For GitHub workflows that contain This workflow is centrally managed in https://github.com/asyncapi/.github/ you do not have to perform any work. These workflows were already updated through the update in .github. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects section
IMPORTANT-END
Deprecation of way data is shared between steps
Every single GitHub Action workflow that has echo "::set-output name={name}::{value}" need to be updated to follow echo "{name}={value}" >> $GITHUB_OUTPUT
We do not yet know when set-output will stop working. Previous disable date was 31.05 but now then say community needs more time.
For more details read official article from GitHub
Deprecation of node12

2nd bullet point is still relevant for you even if your projects in not nodejs project

Every single workflow that uses setup-node action needs an update to follow v3 version of this action, and make sure minimum node 14 is used
Now this part is more complex. Problem with node12 is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based on node12. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For example action/checkout needs to be updated to v3.

Node12 end of support in action is probably September 27th.
For more details read official article from GitHub
Upgrade Release pipeline - in case of nodejs projects

ignore this section if your project is not nodejs project

You have 2 options. You can:
A. choose to switch to new release pipeline using instruction from https://github.com/asyncapi/.github/issues/205
B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR https://github.com/asyncapi/.github/pull/226
I definitely recommend going with A
Workflows related to release:

.github/workflows/if-nodejs-release.yml
.github/workflows/if-nodejs-version-bump.yml
.github/workflows/bump.yml

@derberg i would like to take this issue

@derberg I would like to work upon this issue.

Hello, @derberg are these https://github.com/asyncapi/website/pull/1727 the required changes related to depreciation of set-output, if yes i can proceed to do it for the wrest of the repositories.

Yes @SumantxD those are the required changes related to depreciation of set-output.
Let @derberg confirm it once so you can start working on rest of the repositories...

note for others: this issue can still be taken up as only Deprecation of way data is shared between step is completed
No releases here so Upgrade Release pipeline - in case of nodejs projects can be ignored. So only Deprecation of node12 needs to be addressed

@derberg Is this issue still unresolved or it is handled through .github repo?

not resolved, not all workflows come from .github, like for example lighthouse-ci.yml that for sure needs an update

Ok, let's make it under Hacktoberfest to get some attention to this issue.

tbh, it is to complex for hacktoberfest. It will take more time to explain then the actual work 😃

Can you describe what tasks need to be done in this issue?