kraken tool kubectl get nodes fails due to missing computed_kubectl file.

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT
Kraken version (use kraken version):
rodin:plugins dwat$ kraken version
1.2.0-stable+git.sha.36456b1f383e7cbb74d2f739b51fc09a831fc420
rodin:plugins dwat$
What happened:
rodin:~ dwat$ kraken tool --config ~/.kraken/dew.yaml kubectl get nodes
Using Kraken config file: /Users/dwat/.kraken/dew.yaml
Pulling image 'quay.io/samsung_cnct/k2:v0.5' ███████▒▒▒ Complete
WARNING: --output not specified. Using /Users/dwat/.kraken as location
WARNING: all not specified. Using 'all' as tags
ERROR! the playbook: get could not be found
cat: can't open '/tmp/computed_kubectl.fMBNME': No such file or directory

rodin:~ dwat$

What you expected to happen:
The command should run without error.
How to reproduce it (as minimally and precisely as possible):
Install the latest homebrew version of kraken and run the command above. Run kraken generate to ensure you have the latest config file.
Anything else we need to know:
This is a user-facing problem for the primary user interface of kraken-lib. Therefore I am making it a p0. We can downgrade it to a p1 if someone else can verify that they do not see the same behavior.

@DStorck: Verified that she also sees this behavior:
DStorck~/chart-logging (update-docs)$ kraken tool --config ~/.kraken/config.yaml  kubectl get nodes
Using Kraken config file: /Users/deirdrestorck/.kraken/config.yaml
Pulling image 'quay.io/samsung_cnct/k2:v0.5' █▒▒▒▒▒▒▒▒▒ Complete
WARNING: --output not specified. Using /Users/deirdrestorck/.kraken as location
WARNING: all not specified. Using 'all' as tags
ERROR! the playbook: get could not be found
cat: can't open '/tmp/computed_kubectl.LIikOb': No such file or directory

So it appears to be a real bug.

This is because k2 version has been upgraded past the changes i tried to make on https://github.com/samsung-cnct/kraken-lib/pull/854#pullrequestreview-69963963
which I was hoping would be updated now. Note that the change was to be backwards compatible to kraken-lib v0.2.0 at the time of the pr, please view
https://github.com/samsung-cnct/kraken/blob/44f39d239df24d55b2e22e5d9df0e73f06f76621/cmd/tool_kubectl.go#L36
so I will need to merge that PR mentioned above, AND have to create a new pr with the latest version of kraken-lib before the merge. @davidewatson @coffeepac

So the last working version of our k2 image (for kraken) was v0.2 which about a month old. I am going to triage our PR's since then and see if I can track down the culprit.

As a workaround you can use an older k2 image. This should only be down when running kraken tool kubectl commands, e.g.:
./kraken --image quay.io/samsung_cnct/k2:v0.2 --config ~/.kraken/dew.yaml tool kubectl get pods

So my first thought was to submit a PR changing the backwards compatibility check here: https://github.com/samsung-cnct/kraken/blob/44f39d239df24d55b2e22e5d9df0e73f06f76621/cmd/tool_kubectl.go#L36
However, with the subsequent commits to kraken I do not think this will suffice. Here is the current behavior:
From HEAD (44f39d239df24d55b2e22e5d9df0e73f06f76621)
We have:
rodin:kraken dwat$ make ; ./kraken --config ~/.kraken/dew.yaml tool kubectl -- get pods
Using Kraken config file: /Users/dwat/.kraken/dew.yaml
Pulling image 'quay.io/samsung_cnct/k2:latest' ... Complete
WARNING: --output not specified. Using /Users/dwat/.kraken as location
WARNING: all not specified. Using 'all' as tags
ERROR! playbooks must be a list of plays

The error appears to have been in '/Users/dwat/.kraken/dew.yaml': line 2, column 1, but may be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

---
version: v1
^ here
cat: can't open '/tmp/computed_kubectl.MeCbdf': No such file or directory

rodin:kraken dwat$

From the previous commit (9acd833cb089d1c3d3f1569faeaf59a46dec1cef)
We have:
rodin:kraken dwat$ make ; ./kraken --config ~/.kraken/dew.yaml tool kubectl -- get pods
Using Kraken config file: /Users/dwat/.kraken/dew.yaml
Pulling image 'quay.io/samsung_cnct/k2:latest' ... Complete
WARNING: --output not specified. Using /Users/dwat/.kraken as location
WARNING: all not specified. Using 'all' as tags
ERROR! the playbook: get could not be found
cat: can't open '/tmp/computed_kubectl.LChICE': No such file or directory

rodin:kraken dwat$

I am fine with merging the PR above, though there is one minor requested change.
@coffeepac: Thoughts? I don't want this to interfere with the etcd and k8s 1.8 merges, or conformance testing.

kraken 1.2.1 and kraken-lib v0.6 have been released. Once the above is merged, kraken will be brew installable. I believe this closes out this issue.

tested with kraken 1.2.1 and this works.


[Feature Request] Add an option to throw an error after a configured amount of operations or time.

Is your feature request related to a problem? Please describe.
Some input strings, such as d6!>0, can cause an infinite loop. Therefore, I need to manually check input strings, but I do not know all of the possible strings that will cause the script to get stuck or run for too long.
Describe the solution you'd like
An option to make the dice rolls stop and throw an error after a configured amount of operations or time would allow the caller of the dice roll to regain control. For example, a user can specify a limit of 100 operations to force the dice roller to stop after 100 operations, or a time limit of 25 to prevent the dice roller from running for more than 25ms on any single roll. Time limits can check performance.now() from perf_hooks for increased resolution.
Describe alternatives you've considered
Ideally, the dice roller should throw errors from the beginning for syntax that would lead to an infinite loop, but it is difficult to ensure that all possible infinite loops are caught, and this alternative would also be unable to detect syntax that do not get stuck in a loop, but take up a lot of time.
Additional context
Use Case: I use this module in a Discord bot, so having the event loop get stuck in the dice roll is extremely bad, since people can exploit it to cause a denial of service. Currently, I am regex matching for known problematic syntax, but it is possible that someone might eventually discover a new input string that I have not filtered to crash the process.

That's a very interesting conundrum, and it definitely needs a solution.
I'll have to think about a good way around this. I think throwing an error for things like a compare point that will always return true is a god idea, it's just determining how that can be done.
The option of a timeout is an interesting one as well. I think this needs some proper investigation to see determine what notation can acuse such loops/
Do you have other examples that can cause infinite loops?

I have !>=0, !p>=0, !p>0, and a check for 5 digit numbers (I don't remember why exactly I added this check, but 5 digit numbers used in a certain way caused the dice roll to be very slow).

I think the reason for the 5-digit limit was to prevent things like 9999999d20.

Any progress on this? I am also trying to run this on a bot and for safety I ended up completely banning certain operations like '>', '<', '!', 'r', and some others, as well as a maximum digit limit as suggested above.
Checking for specifics is dangerous since I found things like !>=0 would also trigger a long loop on negative inputs, i.e. !>=- so I think a better work-around right now for those looking to use this in a bot would be completely disabling any operations that may lead to a long loop. My current banned list is ['>', '<', '!', "r", "exp", "log", "max", "min", "pow", "sign"]. Some of these may be fine but I'm being pretty cautious here so I banned some which may seem dangerous, though untested.
It would be helpful to maybe have options for ignoring certain dangerous modifiers or indeed have it terminate if it takes too long. Perhaps writing an asynchronous version would be helpful.

Sorry, no progress yet. It's been earmarked for the 4.3.0 release and I'm currently working on 4.2.0, which mainly includes group rolls #88.
My current thinking is to try and compare modifiers with compare points against the min/max values of the dice, so it throws an error if the comparison will always pass:
d6!>0
d6!<7

// Fudge dice have a min of -1 and max of +1
dF!>-2
dF!<2

And on top of that, have a maximum iteration count, that cuts it off if it loops too many times.
An asynchronous option is definitely something that could be considered.
I'm also always happy to receive PRs if you're up for taking a crack at it.

After a bit of thought, due to the amount of modifiers, and combinations of such, I think it's going to be very difficult to check the modifiers to ensure that they're sensible (e.g. will not always explode).
So I think a max cap on modifier iterations is probably the best way of solving this, perhaps if each modifier has a maximum iteration of 1000.
I'm also keen to look into the option of running it asynchronously, but will most likely look at that as a separate ticket.

@Yernemm just thought it worth saying that your ban list is probably catching a lot of false positives there:

'>', '<': These are used in quite a few modifiers, such as target success / failure, and shouldn't cause any issues in these cases. They'll only be problematic when used with exploding or re-rolling dice, as they're the only modifiers that create loops.
'!', "r": These are definitely the culprits to block if you're worried about infinite loops
"exp", "log", "max", "min", "pow", "sign": These use the standard JS math functions, so shouldn't cause any issues.

At present the only modifiers that should be causing issues are the exploding (Including compounding and penetrating), and re-rolling dice.
As mentioned above, I'm getting a fix in shortly so modifiers will only loop a maximum of 1000 times per roll, so that'll stop infinite loops from occurring entirely. So you may or may not be okay to not ban any of the modifiers.

Can you also add a configurable global (for all rolls for a given input) roll limit to prevent a large, but non-infinite, number of rolls from being done? For example, inputs like (99^99)d20 would block the thread for basically forever (over 10^197 rolls).

So, there's some kind of good news in disguise, although it's caused by a newly found bug.
The die quantities are all parsed to integers, using JS parseInt(). But parseInt() has issues with very large numbers:

Because some numbers use the e character in their string representation (e.g. 6.022e23 for 6.022 × 1023), using parseInt to truncate numbers will produce unexpected results when used on very large or very small numbers.

Running (99^99)d20, will calculate (99^99) as 3.6972963764973e+197. When this runs through parseInt() it comes out as 3.
So rolling (99^99)d20 will actually roll 3d20.
Obviously it needs to handle large numbers better - I've raised #159 to handle that.
But I'm thinking of limiting the die quantity to 5 digits / 99999.
After running some tests, that seems like a good max - any more than that and I start to see memory issues.
The library currently has no real sense of configurable options, so making this limit configurable would be quite a bit of work. I am looking into options for allowing finer configuration of things though, but it's not likely to be implemented soon.

Another thought - it's probably best to ensure that the numbers are also <= Number.MAX_SAFE_INTEGER (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER)

The fix for limiting modifier iterations to 1000 is done and will be going out in v4.3.0 shortly.
I'm going to leave this ticket open though, as there's still more that can be done to reduce the chance of bringing down a server.

I've just merged in #176 which adds proper handling of very large numbers, so they don't get incorrectly parsed to integers.
You can read my full explanation there: https://github.com/GreenImp/rpg-dice-roller/issues/159#issuecomment-667235131
In short, the dice roller can now handle very large numbers, which works really well for die sides, but needs to be restricted for qty as that'll cause some memory issues. I'm going to resolve that as part of this issue.

And I've now just merged in #177, which restricts the qty of each die to 999. After testing, I found more than that to be too heavy when dealing with lots of exploding / re-rolling dice, and also multiple dice.
So, these examples are valid:
999d20
999d10 + 999d6 * 999d20

But more than 999 per die is invalid;
1000d20

Will throw:

RangeError: qty must be between 1 and 999

These fixes, along with the previous one to stop infinite loops should cover most bases.
I'm not certain what else there is to do on this, but I'm open to suggestions!

Closing as I'm not sure there's anything else required.
Feel free to comment otherwise.


Builder for no parameters

Closes #462
Quick question: Was wondering if there is a need to add @Deprecated to the constructor?

No, no need to add @Deprecated.

Alright
On 15 May 2017 7:34 pm, "Ivan Savytskyi"<EMAIL_ADDRESS>wrote:

No, no need to add @deprecated https://github.com/deprecated.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/apollo-android/pull/494#issuecomment-301485113,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD1DEECwvbJq2tgk3JPjbO42RhglH68wks5r6FuEgaJpZM4NbCXj
.


Custom rules documentation

Hello everyone,
my CSS dude wants me to add a wrapper element within every li when translating markdown to HTML.
Looking at #598 I see it is possible to inject custom rules and functionality into markdown-it by
modifying mdi.renderer.rules. However, I can't find documentation in the readme as to which keys rules has/expects for certain elements.
When displaying the content of rules at build time it looks like only default rules are present, meaning I have to add new rules myself. But again, I am not sure how to properly extend rules: Looking at #598 I see the function itself doesn't differentiate between elements it applies its changes to all values it receives. So I guess it depends on the key name in rules which element the function is applied on? If so where can I find a list of which key names are available?
Best regards

Advanced modifications require some sources instept. See https://github.com/markdown-it/markdown-it/blob/master/lib/renderer.js
It uses default renderer function if "named" one not exists. Seems simple.

It uses default renderer function if "named" one not exists. Seems simple.

Indeed, but to know which rule I'd have to create I have to know what to name my key in the rule object.
Again looking at #598 I see that to add a rule to access the opening tag of a link I have to set the function at the key link_open. My question in detail is "What is the correct key to add to the rules object to access the opening tag of a li Element?" and in general "Is there a full list somewhere of the possible key names for the rules object?"

Advanced modifications require some sources inspect.

Yes, I did  read through parts of the source code but didn't find a solution (maybe looked in the wrong place, etc etc.).
I find it especially strange that the readme explicitly mentions (in the 6th line none the least)

Configurable syntax! You can add new rules and even replace existing ones.

But then there is no follow up on how to do that.

Parser is non trivial thing. We have no resources to write a big book. If you describe exactly what you need, i could try to help with direction.

What is the correct key to add to the rules object to access the opening tag of a li Element?

and

Is there a list somewhere of the possible key names for the rules object?

See tags in demo
You probably may wish to override default renderer rules for list_item_open and list_item_close. Something like md.renderer.rules.list_item_open = function (...) { ... }.
Is this what you need?

Yes, it is! Thank you very much.

Hi Team,
If I want to modify and want to have "$" and "$" as the begin and end to denote "bold" instead of "**", is there a straight forward way yo do it.
Comparing it with other markdown editors, they are called as textPatters. So, my question is - is there a way to pass custom textPatters to this markdownIt

Hi Team,
If I want to modify and want to have "$" and "$" as the begin and end to denote "bold" instead of "**", is there a straight forward way yo do it.
Comparing it with other markdown editors, they are called as textPatters. So, my question is - is there a way to pass custom textPatters to this markdownIt
-Regards
Dhrubajyoti


Return empty string if no controller is present

This allows users to render a template directly without going through a
controller. Previously, Brady would blow up since it could not generate
a body_class with no controller

This also fixes our failing build by upgrading to Elixir 1.3 to have access to the ExUnit.Case describe function.

@drapergeek let me know if this addresses your issue for https://github.com/thoughtbot/brady/issues/8


Add an 'indented' method to SyntaxProtocol

This method allows for easily indenting a node tree without needing to manually find where to place the new trivia.
I also chose not to implement a version that automatically detects an amount to indent by using BasicFormat.inferIndentation since that would probably produce better results if called higher up in the tree, and the user of this API can more easily cache that calculated indentation amount and pass it to indent multiple times as needed.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Why might the indented(by:) method not be able to be found? Things work fine for me locally.
/Users/ec2-user/jenkins/workspace/swift-syntax-PR-macOS/branch-main/swift-syntax/Sources/SwiftSyntaxBuilder/Syntax+StringInterpolation.swift:85:27: error: value of type 'Node' has no member 'indented'
      indentedNode = node.indented(by: lastIndentation)
                     ~~~~ ^~~~~~~~

A Node is not a kind of Syntax, it’s meta-information about the declaration of a syntax node the builder will spit out. You may want to revert your change in that file.

It’s a local generic type (which must be shadowing the real Node type): func appendInterpolation<Node: SyntaxProtocol>.

Why might the indented(by:) method not be able to be found? Things work fine for me locally.
/Users/ec2-user/jenkins/workspace/swift-syntax-PR-macOS/branch-main/swift-syntax/Sources/SwiftSyntaxBuilder/Syntax+StringInterpolation.swift:85:27: error: value of type 'Node' has no member 'indented'
      indentedNode = node.indented(by: lastIndentation)
                     ~~~~ ^~~~~~~~

You need to add Indenter.swift to CMakeLists.txt so we can find it when building swift-syntax using CMake for the compiler.

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test Windows


Cannot read property 'defaultLength' of undefined

Hi. I have error when I press unsupported key (any key except "arrows", "tab", "backspace", "Delete").

Can you help me with it?
I found there is some problem inside DateInputComponent.prototype.onKeydown method with nextSection variable

Closing this as per the above merge.


Resolve Address dialog coming to Unified Interface?

Hello UI team. In Classic, if an unresolved email address, we can double click and use the Resolve Address dialog to create a new record for it or add it to an existing record. Is this, or something equivalent, coming to the UI? Please could you add it to the capabilities not yet in the UI section.
I think it would also be helpful to have a section of Classic experiences which will never be on the UI (associated view icon on subgrids for example)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ab324e0-f5c6-64cb-d93b-85d238bf25d3
Version Independent ID: 94fbb660-5300-51a1-9c98-4b6500800e29
Content: About Unified Interface Dynamics 365 Customer Engagement
Content Source: ce/admin/about-unified-interface.md
Service: crm-online
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

+1 for the "Classic experiences which will never be on the UI". I critical planning tool while we're in this transitional phase.

Wait, "associated view icon on subgrids" will never be on UI?  What's the design reason for that?  Clicking on related tab then entity then selecting view is quite a long workaround, no?
Also will auto-resolve on tabbing out of a lookup field never be on the UI?  I obviously like the search-while-you-type but when you know it's unique (and used to resolve with one tacked-on key stroke) you don't want to go back to your mouse and position that cursor below for an extra click...

      Wait, "associated view icon on subgrids" will never be on UI?  What's the design reason for that?  Clicking on related tab then entity then selecting view is quite a long workaround, no?

Also will auto-resolve on tabbing out of a lookup field never be on the UI?  I obviously like the search-while-you-type but when you know it's unique (and used to resolve with one tacked-on key stroke) you don't want to go back to your mouse and position that cursor below for an extra click...

@Beck0Fish where did you hear/see that about the associated view icon on subgrids? I see no reference to that on this article

@robdawsoncranhillinsight   I got it from your original opening comment! "I think it would also be helpful to have a section of Classic experiences which will never be on the UI (associated view icon on subgrids for example)"...   Were you saying you want confirmation of this, not that this is an existing example of something which will never be on UI?   Sorry if I misread and have confused things.

Many field service functions are not available in UI such as booking recurrence dialog. This makes transition difficult as no workaround to show the recurrence setup in UI.

Not having the option to resolve contacts when we receive an email from an unknown address is a big issue for us. We are a charity and since GDPR there has been a big push to reduce the number of duplicate records for our supporters as we cannot comply with the regulations and honour people’s contact preferences when they have more than one record. As such, we really do not want the CRM automatically creating new records because the person contacting us is very likely to be known to us and have existing preferences. But if you do not have auto-create turned on and there is no option to resolve to an existing contact then I have found that even if you go to the contact record and add the email address (of the email just received) you could never get the email added to the record correctly. I hope MS find a way to give us back this important functionality. I have been told we could possibly recreate it with Javascript, has anyone out there done this or does anyone have any idea where I would start?


Warn on SSH connection for incorrect configuration

When setting.RepoRootPath cannot be found(most likely due to incorrect configuration) show "Gitea: Incorrect configuration" on the client-side to help easier with debugging the problem.

setting.RepoRootPath should not be leaked to client users.

A better approach is only showing the RepoRootPath in logs.

That's a problem... Those kinds of logs would only be show when ENABLE_SSH_LOG is enabled(which currently isn't mentioned in the dogs, see https://github.com/go-gitea/gitea/pull/19316).

Codecov Report

Merging #19317 (71d701a) into main (d242511) will decrease coverage by 0.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main   #19317      +/-   ##
==========================================
- Coverage   47.51%   47.49%   -0.02%
==========================================
  Files         944      944
  Lines      131549   131558       +9
==========================================
- Hits        62500    62486      -14
- Misses      61541    61560      +19
- Partials     7508     7512       +4

Impacted Files
Coverage Δ

cmd/serv.go
2.33% <0.00%> (-0.06%)
:arrow_down:

modules/setting/setting.go
45.50% <50.00%> (-0.12%)
:arrow_down:

modules/charset/charset.go
69.74% <0.00%> (-4.21%)
:arrow_down:

modules/git/repo_base_nogogit.go
70.58% <0.00%> (-3.93%)
:arrow_down:

modules/git/utils.go
66.29% <0.00%> (-3.38%)
:arrow_down:

models/issue_comment.go
51.35% <0.00%> (-0.68%)
:arrow_down:

modules/queue/queue_channel.go
81.48% <0.00%> (ø)

services/pull/pull.go
39.78% <0.00%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f4e95...71d701a. Read the comment docs.

-> #19437

To correct the review before (which was incorrect):

fail(RepoRootPath) would leak some server information to end users.
Since it's a rare case and shouldn't occur when Gitea works correctly, I can accept it.
A better approach is only showing the RepoRootPath in logs.

Only the first arg of fail (aka userMessage) will be returned to end user, while the second arg won't and it's for server log. Sorry for the misleading.


Inconstancy between the ReadMe and the Package.swift, is iOS supported?

Describe the issue
The read me doesn't list iOS as a supported platform, yet the Package.swift file seems to include it, which is correct
Vapor version
N/A
Operating system and version
N/A
Swift version
N/A
Steps to reproduce
Take a look at the ReadMe file and the Package.swift file.
Note that under supported platforms iOS is not listed yet in the Package.swift file it is listed under platforms
    platforms: [
        .macOS(.v10_15),
        .iOS(.v13),
       ...

I am interested in using this on iOS and would like to confirm that it is indeed supported. If so I'm more than happy to fix the ReadMe.
thanks
PS Sorry if creating a bug isn't the correct work flow for this case
Outcome
N/A
Additional notes
N/A

@TMinYou we provide experimental support for iOS for this. Note that we don't do any testing on iOS so can't guarantee it definitely works, but I can't see any reason why it wouldn't. Feel free to reopen if you hit issues, or create new issues


Restore .gitignore files to generated projects

Description
This PR restores the generated sample .gitignore and .gitattributes files included with projects generated by the archetype.
Related Issue
Bug filed here: #885
Motivation and Context
.gitignore is an important part of any AEM project, especially for projects using the frontend modules as there are generated client libraries that need to be ignored from source control.
How Has This Been Tested?
Tested using the it-basic profile included in the archetype
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@godanny86 Thank you for this fix!


update parser to handle batch on object with flowInput

This change is

/deploy

fixes https://github.com/kube-HPC/hkube/issues/1365


DAP throws error when debugging with neovim in Flutter 3.16.0 because threadIds are too large

Debugging stopped working after upgrading to Flutter 3.16.0
I am using neovim and https://github.com/mfussenegger/nvim-dap/ DAP adapter.
After some investigation I found that the issue is with thread ids - they are very big numbers, that does not fit to int.
Looks like this is known issue: https://github.com/dart-lang/sdk/issues/53086, there is a revert commit that fixes it: https://github.com/dart-lang/sdk/commit/eda6963e4df3118bf69fda08c32743a9de1bbccb
Would it be possible to include this fix to the next Flutter hotfix release?
More details:
There is an issue for this in https://github.com/akinsho/flutter-tools.nvim/issues/309
Request:
{
 reason = "breakpoint",
 threadId = 4.9230778108782e+15
}

{
   body = {
     error = {
       format = "{message}\n{stack}",
       id = 1,
       variables = {
         message = "type 'double' is not a subtype of type 'int' in type cast",
         stack = "#0      new StackTraceArguments.fromMap (package:dap/src/protocol_generated.dart:5650:36)\n#1      StackTraceArguments.fromJson (package:dap/src/protocol_generated.dart:5635:27)\n#2      BaseDebugAdapter.handle (package:dds/src/dap/base_debug_adapter.dart:118:21)\n#3      BaseDebugAdapter.handleIncomingRequest (package:dds/src/dap/base_debug_adapter.dart:419:7)\n#4      BaseDebugAdapter._handleIncomingMessage (package:dds/src/dap/base_debug_adapter.dart:295:7)\n#5      ByteStreamServerChannel._readMessage (package:dds/src/dap/protocol_stream.dart:82:18)\n#6      ByteStreamServerChannel.listen.<anonymous closure> (package:dds/src/dap/protocol_stream.dart:53:24)\n#7      _rootRunUnary (dart:async/zone.dart:1407:47)\n#8      _CustomZone.runUnary (dart:async/zone.dart:1308:19)\n#9      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1217:7)\n#10     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)\n#11     _DelayedData.perform (dart:async/stream_impl.dart:515:14)\n#12     _PendingEvents.handleNext (dart:async/stream_impl.dart:620:11)\n#13     _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:591:7)\n#14     _rootRun (dart:async/zone.dart:1391:47)\n#15     _CustomZone.run (dart:async/zone.dart:1301:19)\n#16     _CustomZone.runGuarded (dart:async/zone.dart:1209:7)\n#17     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1249:23)\n#18     _rootRun (dart:async/zone.dart:1399:13)\n#19     _CustomZone.run (dart:async/zone.dart:1301:19)\n#20     _CustomZone.runGuarded (dart:async/zone.dart:1209:7)\n#21     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1249:23)\n#22     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)\n#23     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)\n#24     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)\n#25     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:185:5)\n"
       }
     }
   },
   message = "type 'double' is not a subtype of type 'int' in type cast"
 }

 flutter doctor -v
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.0 23A344 darwin-arm64, locale en-LT)
    • Flutter version 3.16.0 on channel stable at /Users/ts/fvm/versions/3.16.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db7ef5bf9f (2 days ago), 2023-11-15 11:25:44 -0800
    • Engine revision 74d16627b9
    • Dart version 3.2.0
    • DevTools version 2.28.2

@christopherfujino @bkonyi looks like we unfortunately ended up with the Flutter stable getting a DDS release between the break and revert for this (looks like DDS 2.9.5 was never released, so Flutter was still on 2.9.4 until a later DDS release).
Hotfixing this would require a DDS 2.9.4 hotfix with the revert, then a Flutter hotfix to include that. I don't know how complicated that is or whether this will meet the bar. I think the issue only affects neovim users, but I don't know how many there are (@christopherfujino do you have any stats on flutter debug_adapter invocations that are neovim and/or not VS Code?).

Ah shoot, I didn't realize 2.9.5 hadn't been published. I checked out eda6963 and retrospectively published 2.9.5, so it should be a safe cherrypick into Flutter 3.16 if we decide to go for it.

@bkonyi yeah, I forgot to ping for it too. I think I had assumed there would be other fixes and a release and lost track.
I discussed with Jacob and he thinks this is worth cherry-picking. @christopherfujino this doesn't need a Dart SDK release, just updating the package from Pub. I recall the process for that was not so trivial - is it documented somewhere?
(btw I've opened https://github.com/flutter/flutter/issues/138736 to see if we can come up with a way to keep these things better in-sync around the time of releases)

CP request here

The fix shipped in Flutter 3.16.3 (see https://github.com/flutter/flutter/issues/139177#issuecomment-1843386696). @sidlatau please let me know if you're still seeing issues after upgrading.

The fix shipped in Flutter 3.16.3 (see flutter/flutter#139177 (comment)). @sidlatau please let me know if you're still seeing issues after upgrading.

Debugging works now, thanks for the fix!

Excellent, thanks for confirming :-)


404 at: /installation/rhel/

URL: /installation/rhel/
I got to this URL by searching using bing.
https://www.bing.com/search?q=red+hat+docker
Its the first result.  May need a redirect.

Thanks, redirect added! :)


Site UI layout is broken in IE7 when the Alert bar is being displayed.

Right now, when a user navigates the site in IE7 while there is a message to display in the Alert bar, only some of the elements on screen automatically shift downward as the bar pops into view on page load.
To reproduce this, follow these steps:

Navigate to http://qa.nugettest.org/Users/Account/LogOn in IE7. (For the record, I'm doing this on English Windows Vista Ultimate x64, SP2)
Observe that only some of the UI elements shift downward as the alert bar pops into view.

Given this constraint, we ought to consider having the Alert bar be static in our site UI.

Obsolete


Fix key rotation with multiple dex replicas

Should fix #976. Please review.

@Calpicow thank you so much for identifying this issue and proposing a fix for it. We decided that reverting dd1e901. and adding an info log message would be a better way to fix it.
Fixed in https://github.com/coreos/dex/pull/998


Fixed Copy&Paste error

It said insert where it actually deleted rows

@bb-froggy good catch. Could you please send a PR fixing this on the xml comments on the source of in the EntityFrameworkCore repo? Changes made here are not preserved when the API documentation is regenerated from the source.


Mouse event on stage doesn't capture mouseup/mousedown of right button

I have read the bug/enhancement 3963 which tries to make pixi.js interaction event closer to browser behavior.
However in my testing I have found it unable to capture mouse right button event on mouseup and mousedown events.
In the native browser behavior, mouseup and mousedown events are both captured/fired when I click the right button. You can see it in the second example of  the following link here.
In pixi.js 4.5.3, when I click/press the right button, neither on PC nor on Mac will these two events be captured. Only the contextmenu event is fired/captured. mouseup and mousedown are simply ignored. Unless I use "ctrl + left button" combo on Mac, which is not the same as a right click with mouse. Check it out here
What is the consequence?
It is hard to separate mouseup and mousedown events of the right button pressing and releasing. Sometimes I want the right button down to do something and mouseup to do some other thing but end up getting the opposite result. If this can't be fixed I have to use a native javascript event to do the job.

The mousedown event is still firing if the user has their mouse set to "one-click" or whatever they call it. Mine is setup for contextMenu so your browser preventDefault() catches it and kills the event.
I actually switched up your setup to use pointerEvents instead. That way I could track mouse and touch, and use the event.data.buttons to know what button triggered the event. You can see that here:
https://codepen.io/DennisSmolek/pen/OjbJZm?editors=1111
app.stage.pointerdown = mousedownEventHandler;

function mousedownEventHandler(e) {
  //get the data
  var button = e.data.button;
  console.log('Mouse Down: button is:', button);
}

@DennisSmolek OK it seems pointerdown/pointerup does similar things with mousedown/mouseup, I am not aware of that. So why do we need both mousedown/mouseup and pointerdown/pointerup in pixi.js? Why not just combine them?

In future versions of pixi, we may do, but for backwards compatibility within the v4 release it is important to keep mouse and touch events

Yeah, if you support less than IE 11 you can't use pointerEvents or need a shim. The biggest reason is that older apps used mousedown/mouseup and they dont want them to break when  they upgrade to the newer versions.
Moving forward though I would use pointerEvents as it makes it much much easier for different devices like Mice, Touchscreen, Pens, Tablets, etc...


docs: fixed broken documentation links

Thank you very much, I totally overlooked this with the last update! 🙏👍


gist-logs: close temp file before passing to curl, to ensure output availability

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same change?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

Fixes #417
Looks like there's a race condition with I/O buffering when gist-logs is passing a temporary data file to curl. close is not called on the tempfile handle, so the data isn't guaranteed to be flushed to the filesystem and visible to external processes. This appears to be behind the intermittent JSON parsing errors during gist creations on one of my machines: adding the earlier close made them go away.
This adds a close, ensuring that the data gets written to disk so curl can see it, avoiding intermittent JSON parsing errors in gist creation.
Strictly speaking, there may be a similar race condition with the reading of the header temp file, which is opened in the brew Ruby process before curl writes out to it. But I don't think it'll ever get hit, because no read is done before curl runs, so it probably doesn't have a chance to buffer any output from the "before" state of the file.

Nice find! This could be causing all kinds of issues when accessing the GitHub API and it's good to get this fixed (though I believe only gist-logs actually posts data, so might be the only one affected).

Thanks!
BTW, I was able to reproduce it on my other Mavericks machine, too, using a different formula.
$ brew-gist-logs gdk-pixbuf
Error: Your HOMEBREW_GITHUB_API_TOKEN does not have sufficient scope!
Scopes it has: ["gist", "notifications", "useremail"]
Create a new personal access token: https://github.com/settings/tokens
and then set the new HOMEBREW_GITHUB_API_TOKEN as the authentication method instead.
Error: Problems parsing JSON

Anything with a total log size of < 4K seems to trigger it for me. Which makes some sense, as that's the size of a page, so staying under that could affect buffering behavior.

Anything with a total log size of < 4K seems to trigger it for me. Which makes some sense, as that's the size of a page, so staying under that could affect buffering behavior.

This sounds quite plausible. It would also explain why this is usually not an issue for Gists posted due to build errors, as then the logs will usually be much larger. (At least I'm not aware of any problems users might have experienced with using brew gist-logs in recent times.)

Nice work here and thanks for fixing my 🐛. 🚢ing so users get it.


No requirements.txt file

Hey! I'm trying to work through this tutorial. It mentions a requirements.txt file in this project (Chapter 1), but I cannot locate this file anywhere. Was it accidentally deleted? Should I just download the rest of the dependencies listed?

Same

Hi @bynarsAreTRBL & @messiosa - it looks like the tutorial's been updated to match the new API: https://github.com/slackapi/python-slackclient/tree/master/tutorial


feat(core): try to extract repository url from ci env variables

Following #747, we want CI commands to gather the current repository URL from the CI environment variables first, falling back on git remote -v if variables are not found.

Codecov Report

Merging #791 (5f78ae6) into main (20d0b01) will increase coverage by 0.16%.
Report is 22 commits behind head on main.
The diff coverage is 94.38%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   91.68%   91.84%   +0.16%
==========================================
  Files         154      155       +1
  Lines        6348     6486     +138
==========================================
+ Hits         5820     5957     +137
- Misses        528      529       +1

Flag
Coverage Δ

unittests
91.84% <94.38%> (+0.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

ggshield/cmd/hmsl/hmsl_common_options.py
100.00% <ø> (ø)

ggshield/cmd/iac/scan/all.py
100.00% <ø> (ø)

ggshield/cmd/iac/scan/diff.py
80.76% <ø> (+2.56%)
:arrow_up:

ggshield/cmd/iac/scan/iac_scan_common_options.py
100.00% <100.00%> (ø)

ggshield/cmd/sca/scan/sca_scan_utils.py
87.23% <ø> (+8.51%)
:arrow_up:

ggshield/cmd/secret/scan/ci.py
96.42% <100.00%> (+0.13%)
:arrow_up:

ggshield/cmd/secret/scan/path.py
100.00% <ø> (ø)

ggshield/cmd/secret/scan/precommit.py
100.00% <100.00%> (ø)

ggshield/cmd/secret/scan/prepush.py
100.00% <100.00%> (ø)

ggshield/cmd/secret/scan/prereceive.py
93.54% <100.00%> (+0.10%)
:arrow_up:

... and 9 more

... and 4 files with indirect coverage changes


Missing udev volume mount in headless.yml?

I am extremely fresh to using this project, but have been following it for quite a while.
I have just been examining the headless.yml file in the compose/platforms folder, and something doesn't seem quite right..?
As far as I can ascertain, there's a udev:/run/udev/:ro volume entry, yet there isn't a volume mount..? - I can see ones for xorg and pulse - surely udev should be the same? - I have had a quick scan through the bash scripts and I cannot find where such a mount occurs..?

It does!
Thanks!


Dark Keyboard commented out?

I tried uncommenting and it crashed. It's a pitty would be nice!
Any idea on how to get it to work?

I wonder that too...

The feature was removed from iOS 7.1 beta 2.

I have seen dark keyboards in apps far beyond iOS 7.1 beta 2. It was just
removed from the settings but apps can still use them. For example in the
app eyeEm.
On 27 May 2015 at 15:45, Lucas Hosseini<EMAIL_ADDRESS>wrote:

The feature was removed from iOS 7.1 beta 2.
—
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic-plugin-keyboard/issues/93#issuecomment-105916430
.


typo: Double word "available"

@nschonni : Thanks for your contribution! The author, @rboucher, has been notified to review your proposed change.

Merging typo fix


Allow using wildcard listeners

what
Currently we can't handle wildcard listeners in the gateway. This is quite limiting as it means every host has to be explicitly added as a listener. There are certainly use cases where using a wildcard in a trusted environment would save a lot of repatative
The behaviour we want is the following

WildCard certificate created
WildCard DNS record created

The main issue is that we use the host name as the DNSRecord and CertName and * is not allowed in that name. It may just work if we workaround that naming problem.
It is important we add unit tests to cover this case


No Examples of Conditional Dialogs?

So I have been reading over the examples (in C#) and I am not seeing any examples of how to conditionally decide which dialog to return.   So as an example I have a bot that listens to all messages.  If someone asks to tell a joke then I want to return the IFormDialog that lets them pick the type of joke.  If on the other hand someone asks "What's the weather"  I want to return an IFormDialog   this has to be already baked in but I am not seeing it anywhere

The AlarmBot example binds to LUIS intents and then uses system dialogs depending on the intent that was selected--this sounds exactly like what you are looking for.  If you grab the source code you can also see some examples of Conditional fields in a form in the FormTest project and also of two forms being hooked together.

I read over the LUIS but then you would have to create LUIS intents,  I will look at the FormTest

You can do the same thing with a CommandDialog that uses regular expressions instead of LUIS.

Do you have an example of how to hook the CommandDialog up to the IFormDialog

If you look at the commit d2eb5b7, you can find a simple example of a bot that uses multiform dialogs.

@runxc1 Both the CommandDialog & LuisDialog classes are best thought of as switch statements which as Chris & Shahin suggest sound like exactly what you want. CommandDialog is nice because its RegEx based but the LuisDialog is way more flexible from a matching perspective. You just have to bite the built and learn LUIS.
 The switch determines the initial intent, "tell a joke" or "what's the weather?" and then redirects to the appropriate Joke or Weather dialog.

Ok so what was throwing me off without examples was that all of the methods in the CommandDialog called for ResumeAfter and I hadn't seen that it was a delegate and not a generic class.  So I finally wired something basic up and now get an error that the CommandDialog is not serializable
     internal static IDialog ContextSwitch()
        {

            var cd = new CommandDialog();
            cd.On(new Regex("Garmin Joke"),  (x,y)=> { return FormDialog.FromForm(GarminJoke.BuildForm).StartAsync(x); });

            return cd;
        }

        /// <summary>
        /// POST: api/Messages
        /// receive a message from a user and reply to it
        /// </summary>
        public async Task<Message> Post([FromBody]Message message)
        {
            if (message.Type == "Message")
            {
                return await Conversation.SendAsync(message, ContextSwitch);
            }
            else
            {
                return HandleSystemMessage(message);
            }
        }

The Nodejs documentation has more examples and shows how to use the CommandDialog but I am not seeing any examples on the CommandDialog. @Stevenic am I close or is it intended to be used much differently?

On a side note a lot of the dotnet teams (cli,roslyn,corefx) have created a https://gitter.im/ chat room associated with the Github repo and put a link on the information page for the repo...  That could be of use here

Thanks for the suggestion on gitter.  I've setup a BotBuilder room there.  We will also work up some examples of CommandDialog.


System Alerts | Update Default Carbon Intensities |1|

Task:
Create system alert for successfully updating the Default Carbon Intensities as an IDIR user
Messaging:
"Default carbon intensities saved"https://trello.com/c/aR8qSQ7b/1275-system-alerts-update-default-carbon-intensities-1

 System Alerts | Update Default Carbon Intensities |1|

 System Alerts | Update EER values |1|


Auto re-process ABAP SDK

Hi,
How to auto re-process the jobs failed in ABAP SDK to Microsoft Azure BLOB.

Hello @Srinivasak198 - Thanks for reaching out We updated the SDK master version and re-process job program ZREST_SCHEDULER functionality is upgraded. Please check and let us know.
Regards,
Vika


[IMPROVEMENT] Set default engine-replica-timeout vaule for engine controller start command

Is your improvement request related to a feature? Please describe (👍 if you like this request)
Set default engine-replica-timeout vaule for engine controller start command
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

ref: https://github.com/longhorn/longhorn-engine/blob/4bdb80d656dd32c563655986fadb63079a0b29e6/pkg/controller/init_frontend.go#L39-L46

Verified in longhorn master 4f35fd
Result Pass

In instance-manager-e log,  can not see log related to "Using default engine-replica timeout %v instead since the given value %v is not allowable". Because after https://github.com/longhorn/longhorn-engine/pull/782 merged, timeout have default value set, so the warning message in func DetermineEngineReplicaTimeout not triggered.
engine related test case passed in master-head pipeline


getEngine() now handles DB parameters (#2972)

For reference, Issue #2972.
Beforehand, any DSN parameters on MySQL or Postgres databases would cause an error due to the concatenated strings not checking if parameters already exists.
getEngine() now checks for existing parameters and correctly address the additional strings being concatenated for the databases according to whether a parameter exists. User may enter database name with or without parameters now.
This helps for certain databases that require specific configurations, such as MySQL databases using old_passwords=1 with the allowOldPasswords=1 argument being passed to the DSN.

Thought I should add that the affected databases were MySQL and PostgreSQL. Both had appended paremeters with no checks on the passed DSN. Tests were run using MySQL, but the DSN formatting is equivalent across both.

This fix was created since the codebase does have DSN parameter functionality even though it is suggested by gogs to append them.
Database setting is not correct: this user requires old password authentication. If you still want to use it, please add 'allowOldPasswords=1' to your DSN. See also https://github.com/go-sql-driver/mysql/wiki/old_passwords
Is the error message at the top of gogs when connecting to a database using old passwords. This issue exists for any database requiring parameters passed to the data source name via the database driver URI.

That error-message is most likely generated by go-sql-driver/mysql and not gogs itself. (Mainly mentioning this so there's no confusion...)

As of now the setup page for gogs only has a Database textfield where the user inputs the DSN.
This lets the user input the DSN as they would with any other database connector without gogs throwing errors. Before it had no logic to discern whether the DSN contained parameters and therefore caused the DSN to be malformed if there were any added by the user. This was a shortsighted in its initial design as the error thrown by go-sql-driver/mysql mentions a malformed DSN.
The current implementation takes the DSN textfield and automatically appends parameters. This is fine until the user wants to add their own, where the query appended to their DSN, signified by the ?, will cause the automatically appended ? in the models/models.go to short.
There are obviously several different way of handling the query portion of the DSN in models/models.go, however this method will simply check the input DSN for a query, and if it exists, will instead add further parameters in models/models.go with the correct delimiter.
Param is a somewhat poor variable name, is signifies whether a parameter existed in the DSN, and contains either the query character (?) or delimiter (&) accordingly.
I don't see how the DSN could be generated with your suggestion of using ?charset=utf8&parseTime=true%s, without splitting the DSN using a ? delimiter to pull the query portion of the DSN, which would actually require more processing than this proposed solution.
Example of current solution:
Using:

URI: database.example.com:3306
DSN: exampledb

# models/models.go
# cnnstr = fmt.Sprintf("%s:%s@unix(%s)/%s?charset=utf8&parseTime=true",
# DbCfg.User, DbCfg.Passwd, DbCfg.Host, DbCfg.Name)
cnnstr = "user:password@database.example.com/exampledb?charset=utf8&parseTime=true"

which works fine, but once you include parameters in your DSN (exampledb?testAttribute=true):
cnnstr = "user:password@database.example.com/exampledb?testAttribute=true?charset=utf8&parseTime=true"

While URI's containing multiple ?s does not make the URI invalid, however subsequent entries of ? are viewed as text, so the testAttribute=true becomes testAttribute=truecharset=utf8, which is not a valid entry for the database and also drops your charset=utf8 argument.
Now my solution, which checks the input DSN for a query (?), allows the user to input completely valid DSN entries while allowing models/models.go to still append the parameters it needs.
DSN: exampledb?testAttribute=true
# because DbCfg.Name contains "?":

cnnstr = "user:password@database.example.com/exampledb?testAttribute=true&charset=utf8&parseTime=true"

If you would like to split the DSN on `?` indefinitely instead of using a separate query/delimiter string that is based on the users DSN, it would work of course, but it's not as efficient.

Any updates after @bkcsoft 's comments? Seems no?

There were no updates since no one replied to my explanation for the change.
It seems there's a misunderstanding of what has been changed in this PR.
This only changes the way the URI is generated, so that existing parameters are still used to maintain consistency with the current code while allowing the user to add their own, which may be necessary for certain databases depending on their configuration.

bkcsoft:
Warn if Param is set in this mode

There are already arguments attached to each of the databases, that is what caused the issue in the first place since gogs does not correctly generate the DSN URI. Regardless of user-attached parameters, gogs automatically added ?sslmode=%s to PostgreSQL database URIs and %scharset=utf8&parseTime=true to MySQL database URIs.
This PR fixes the ability to add parameters to databases that require them.

Thanks. Just want to make sure, there is no possibilities that database name could contain ??

No, URIs use ? to signify the start of the query, such as ?charset=utf8&parseTime=true, and are not allowed in the DSN.  This change will allow more functionality in the user creation of the DSNs in the configuration of gogs.

OK, thanks!


React client files changes doesn't work without restarting Docker container

Hi!
First of all, thanks a lot for your awesome work with API Platform! :)
I have a problem with the React client:
After generating the client with this command (from website tutorial): docker-compose exec client generate-api-platform-client (no problem all files are generated and no error message), I edited the client/src/index.js as it's mentioned in the doc but when I add modifications, save the file, and reload the page (_https://localhost/books/_), "Not Found" is displayed.
Same thing when I edit client/src/Welcome.js file (add two exclamation points for example): nothing change.
I have to stop the client container, and restart it to see my changes :/
Do you see where is the problem?
I'm on Windows 10 with Docker for Windows (latest version).
Don't hesitate to ask me further information!
Thanks ;)

I also encountered that problem. Manually restarting the client container solves the "Not Found" problem, but it should pick up changes automatically.


custom tags stripped in tokenized corpora

HI @davidecaroselli and @nicolabertoldi ,
I hope all is well with you and your beloved ones and you are well and safe. I am happy to see things are improving in Italy. Stay safe!
I have a question about custom tags. I created a tmx file with some custom tags surrounding some terms.
Something like:
<financialstart>accounts payable<financialend> and I used the same tags in the target term.
By looking at the files at default/tmp/training/_temp_datagen/tokenized_corpora/ar__en/train
I see that all tags are stripped.
Can you please let me know how I can preserve such tags and protect them from stripping? I hope there is a way.
Thanks,
Mohamed

I also noticed the same is happening when I import the TMX into a memory.

Hello @mzeidhassan - since tags are stripped during inference and reinserted based on the attention distribution, it also makes no sense to include them during training, as they will be removed during inference anyways. From my knowledge you'd have to fork MMT and alter both its pre-processing for training, and it's pre/post-processing for inference, to get what you want, but I think you should make sure that you have a good reason for wanting to do so, instead of using the built-in tag processing functionality.

Thanks a million @ecly for your valuable feeds.
I actually was trying to experiment with this paper arxiv.org/pdf/1912.00567.pdf to see if using tags can handle terminology better.

Hi @mzeidhassan
if you just need tags to be as "metadata" for the translations, you already have the solution: use a custom identifier of your choice which is not an XML tag.
For example, you can use tokens such as __financialstart__ or [[financialstart]], they are not required to be actual XML.
As @ecly said, because ModernMT is XML-aware, the XML tags handling logic is very difficult to eradicate and/or change, because it is a fundamental feature of the engine. If you really want to use XML tags, you'll have to create your custom version of ModernMT starting from a fork of the project.


Provide text-to-Qtree converters

IntelliJ's PSI allows creating PSI elements from strings. We should have something similar for 007 and Qtrees.
Java doesn't have anything like quasi blocks, so the pressure to create Qtrees from strings in 007 is less... but not completely gone. Text is disgusting, unscoped, unsafe... and very flexible. A kind of safety valve for the things we simply can't do with quasis. And maybe a motivation to expand quasis into new use cases to push away text-based solutions. 😸
Best of all, we have all the ingredients in place already to do this; it's low-hanging fruit.

What would be the appropriate thing for the parser to do when it found an undeclared variable? Fail, or just provisionally accept it?
I'm leaning towards the latter — basically, not having a CHECK phase for those text-to-Qtree conversions, because I think it'd be more convenient. And we'll want to check it again anyway after it's spliced in somewhere.


Add Harrisonburg High School

Please add Harrisonburg High School (https://harrisonburg.k12.va.us/hhs/)
Engineering Related Course: https://www.harrisonburg.k12.va.us/hhs/Department/83-HHS-STEM

@jdkrei65 Pull request merged. Thank you!


imports at the module scope should not be selective

Because of the a well known DMD front-end bug, if you specify the symbol to import in a global import, then this symbol will becomes public.
For example if ones imports future.checkedint, in a module, these symbols will also be imported:
https://github.com/tsbockman/CheckedInt/blob/master/future.checkedint.d#L12
It's not recommended to use selective global import until this bug gets fixed.

Thanks, I am aware of that bug. I'm hoping it will be fixed before checkedint is released.
If not, I plan to clean up the imports when I do my big reformatting pass, since I have deliberately not followed the Phobos style guide while working on this.
I should also mention that the code in this repository is quite out-of-date:

I decided to significantly change the way that nothrow code is supported; it now uses an IeeeFlags like mechanism. This is much easier to use.
The checkedint package has been split into a hierarchy of sub-packages, with various things renamed to better manage symbol conflicts with other parts of Phobos.
Template bloat has been reduced.
It is now pretty fast on all three major compilers (if appropriate options are used), not just GDC (although GDC is still best).
etc.

The new version is set up as a DUB package, which I hope to upload soon in a fresh repository. I can ping you when it's ready, if you like.

@BBasile The new version is online now: checkedint.


Doesn't seem to support Webpack

I'm using Webpack to bundle my app and I'm trying to integrate SignaturePad. I tried using
import { SignaturePad } from "signature_pad", import "signature_pad", require("signature_pad") and many other variations, with "signature_pad/signature_pad", and even "signature_pad/src/signature_pad", but it seems that Webpack doesn't support the module types that SignaturePad uses.
The only way I got it to work is using exports-loader:
var SignaturePad = require("exports?SignaturePad!signature_pad/src/signature_pad");
Any plans to add Webpack support? Or am I missing something?

In the same boat too! Webpack :(

Personally, I have set it up in the webpack.config.js as follows (using the expose loader):
module: {
    loaders: [
        {test: require.resolve('signature_pad'), loader: 'expose?SignaturePad'},
        [...]
    ]
}

And then in my code simply:
let SignaturePad = require("signature_pad");

So, this is essentially what you are already doing, just that you can instead set it up once and then import the usual way.

In theory it should work - the production build uses Universal Module Definition (UMD) and has the main field in package.json file.
Anyone wants to investigate why it doesn't actually work and create a PR that fixes this issue?

Can you check if beta version (1.6.0-beta.1, can be installed using npm i signature_pad@beta) works?

Yes, now I can use var SignaturePad = require("signature_pad"); or import "signature_pad", though I still can't do `import { SignaturePad } from "signature_pad".

@szh Thanks for the info! It sucks that ES6 import doesn't work. I don't think that UMD is supposed to support ES6 export/import :/
I'll see if I have to provide 2 different builds - ES6 (that uses export default and is exposed using jsnext:main in package.json file) and UMD or if there's a simpler way.
If anyone knows anything about it already, it would be awesome!

I just tried import * as SignaturePad from "signature_pad"; and it works. It might not be worth the effort to create separate builds, maybe just add this to the readme instead.

@szh I still want to try it out and fix it (or at least document how it can be used with Webpack) before releasing 1.6.0 (or 2.0.0, because I'm also considering removing Bower support). I've noticed that I'm exporting SignaturePad class using module.exports = SignaturePad; instead of export default SignaturePad, but I have no idea if it changes anything.

So both import * as SignaturePad from "signature_pad"; and require('signature_pad') worked for me.
However, I had to add "plugins": ["transform-exponentiation-operator"] to my .babelrc file.  It seemed that babel was picking that plugin definition up from the .babelrc file in node_modules/signature_pad.
Once I installed and added that I was good to go.

Uh, I forgot about transform-exponentiation-operator. I'll remove it, because it doesn't really do much and everyone would need to add it.

Any luck figure out what type of builds you have to support to allow import {} syntax as well as require?
We're struggling with that internally as well.

Nope, not yet :/

I've just published a new beta version that hopefully fixes loading it with webpack. I tried it locally with webpack 2 and both import SignaturePad from 'signature_pad' and const SignaturePad = require('signature_pad') worked fine.
However, publishing UMD/ES6 library is new to me, so it's very possible that I broke something 😉 Let me know if it works for you. If you're using browserify, requirejs it would be awesome to confirm it still works there.

@collinforrester ☝

It works! Visual Studio 2015 doesn't seem to like it, but it does work fine.

@szh What does exactly Visual Studio 2015 doesn't like about it?

@szh Are you sure you have it in package.json dependencies or devDependencies? BTW. Do you have to use import { SignaturePad } from 'signature_pad'? `import SignaturePad from 'signature_pad' doesn't work?

I double checked, I do have it in package.json in dependencies: "signature_pad": "1.6.0-beta.6",. You're right, I don't need to use curly braces, I just did out of habit. I should note that VS had the same problem on 1.6.0-beta.1 as well - I don't remember if it did before that.
Also, before I only tested that it would transpile (I'm using TypeScript) w/o errors or warnings. I just tested a page which uses the component and I see that, whereas when using import * as SignaturePad from "signature_pad";, calling new SignaturePad(canvas, opts) would call the constructor correctly, now webpack converts it to var signature_pad_1 = __webpack_require__(335); ... new signature_pad_1.default(canvas, opts), or when importing with braces, signature_pad_1.SignaturePad, both of which fail.

@szh And what happens if instead of import * as SignaturePad from "signature_pad" you simply do import SignaturePad from "signature_pad"?

Sorry I wasn't so clear. That's what I'm doing now, and it compiles to var signature_pad_1 = __webpack_require__(335); at the top of the file, and then new signature_pad_1.default(canvas, opts). When I do import { SignaturePad } from 'signature_pad' with braces, then it's new signature_pad_1.SignaturePad(canvas, opts)

@szh I'm lost. Does it work with import SignaturePad from 'signature_pad'? I don't plan to support every possible version of import syntax 😉

import SignaturePad from 'signature_pad'; new SignaturePad(canvas, opts) generates var signature_pad_1 = __webpack_require__(335); new signature_pad_1.default(canvas, opts)
import { SignaturePad } from 'signature_pad'; new SignaturePad(canvas, opts) generates var signature_pad_1 = __webpack_require__(335); new signature_pad_1.SignaturePad(canvas, opts)
Both of those fail. The only thing that works is import * as SignaturePad from "signature_pad";

This will never end 😉 @szh Which version of webpack are you using? I thought I tried it with the latest webpack 1.x (though I was using my local version of this library via npm link) and it worked...

I'm using Webpack 1.14.0

@szh It works fine for me 😕
I created a repo I'm using to test it: https://github.com/szimek/signature_pad-webpack-1-test. It's basically the demo app, just with webpack 1.14.0. Run:
yarn && yarn run build && open index.html

to try it out.

I was able to reproduce the issue in your demo repo by using TypeScript...

@szh Could you make a PR to this repo I created that adds typescript and causes this error to show up?

https://github.com/szimek/signature_pad-webpack-1-test/pull/1

@szh This is probably the issue you're having: https://github.com/Microsoft/TypeScript/issues/13017 and https://github.com/rollup/rollup/issues/1156.

Aha. Good job tracking that down

Looks like it might get solved soon :/ The fastest fix would probably be to switch to webpack 2.x and use the es6 version of the library ;)

I think until it's fixed I'll continue using import * as SignaturePad from "signature_pad";
;)

I'll probably release 1.6.0-beta.6 as 1.6.0 then and just add info in the README file about this issue with TS. Thanks!

Sounds good to me! Thanks for the help!

I'm unable to import signature_pad with the syntax import SignaturePad from 'signature_pad'

@dlombardi Could you create a new issue with error message etc.?

I had this issue and what worked for me was directly importing the JS file as per this comment. I'm on webpack 2.2.1.

Same here... cannot import / require with webpack!

@divdax Are you using JS or TS? Which version of webpack?

I am in the same boat, is 3.0.0-beta.1 yard add-able?

I don't mean to re-open this issue, but I too ran into this while migrating an application that uses signature_pad to webpack.
The issue turned out to be a problem in the application code, not webpack or some interaction between webpack and signature_pad. Specifically a missing variable assignment keyword (var, let, const), which produced an error similar to the one @dlombardi had.
// Produces a SignaturePad undefined error without using var, let or const
signaturePad = new SignaturePad(document.querySelector('canvas'))

// works
let signaturePad = new SignaturePad(document.querySelector('canvas'))

So if you're new to ES6 and Webpack, don't forget about little things like this and maybe consider using a javascript linter to help spot similar issues.


fix: fixed 4 decimals for distance rates

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49336
PROPOSAL: https://github.com/Expensify/App/issues/49336#issuecomment-2362712374
Tests

WS currency set to ALL, enable tax rates
Open WS -> Distance rates
Create a new Distance rate with a 4-digit decimal value
Click on Distance rate -> Modify rate
Enter a 4-digit decimal value and save
Modify Tax reclamable on with another 4-digit decimal value and save
Verify that: All the values in step 2, 4 and 5 are displayed with 4-digit decimal point correctly.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

WS currency set to ALL, enable tax rates
Open WS -> Distance rates
Create a new Distance rate with a 4-digit decimal value
Click on Distance rate -> Modify rate
Enter a 4-digit decimal value and save
Modify Tax reclamable on with another 4-digit decimal value and save
Verify that: All the values in step 2, 4 and 5 are displayed with 4-digit decimal point correctly.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/c9726021-511d-4330-84d0-f7139d7417e5

Android: mWeb Chrome
https://github.com/user-attachments/assets/dd4d5c66-d672-462c-b652-47f28a8a4370

iOS: Native
https://github.com/user-attachments/assets/ced6e448-f7df-454b-b110-9061b7acac95

iOS: mWeb Safari
https://github.com/user-attachments/assets/dc050cb3-9885-43ca-93f3-b671633f5c66

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ceccc3ee-1695-4e9a-8684-bc369196e5f0

MacOS: Desktop
https://github.com/user-attachments/assets/17d9c10a-b80b-4625-bb35-cb3883f5fb33

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

LGTM :>

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Add net/http WrapHandler

Thank you for a nice OSS.
I want to use net/http.
There are probably many people who think so.
I created WrapHandler for net/http
https://github.com/pei0804/go-http-swagger
Is it possible to include this in the repository?
For examle custome error. more test cases...
If there is a problem I am motivated to improve.

Sure! Thanks all for your contribution. 💯
Please add  it in https://github.com/swaggo/http-swagger repo.

Sorry i miss commit....!
please wait.

I create PR
https://github.com/swaggo/http-swagger/pull/1


Test CI improvement meta issue

Just to track sub-issues that are closely related in one place

Closing as all sub-issues are complete


Don't include binder events in default CLR events

The binder events - for Fusion in .NET Framework and assembly load tracing in .NET Core/5+ - are for the targeted scenario of assembly bind tracing. They aren't generally helpful to have on by default and can come with a significant performance cost. This removes the binder events from ClrTraceEventParser.Keywords.Default, since I don't think those intentionally verbose events make sense in the default set.

@elinor-fung thanks for submitting this.  While these events can be costly, they are often quite helpful, as ETW traces are often used for troubleshooting issues that are related to assembly loading.  A good example is understanding NGEN image rejection on .NET Framework.  We include these by default because we use them enough and they aren't so costly that we want to have to ask for them each time we need them.  Unless something has changed, my preference would be to leave them in the default set.

@brianrob Can you point me at which events those are? From what I could tell, all the actual binder events in .NET Framework come through the Microsoft-Windows-DotNETRuntimePrivate provider and nothing actually comes through the FusionKeyword for Microsoft-Windows-DotNETRuntime in Framework.


styled text prototype

Sample pull request (will most likely revert)
currently only supports bold and italics

Yea I made the Styling class/enumeration. You can do pretty cool things with enums.


removed unnecessary write() from Member::logIn()

$this->write() is already called in regenerateTempID()

Hmm, I think the implied write in regenerateTempID isn't a good enough reason to change this as it makes the function more vulnerable to regression.
a write on an object that hasn't been modified won't touch the DB so this shouldn't be a big performance problem but makes the function more resilient

fair enough - good point, feel free to close


Get tests running again by fixing or skipping

Also basic addVariable working

This passes locally with skipped tests, will come back to github actions failing


Registry based config - Part 1

Adds the core of the registry system
Along for the ride, adds some __all__s. Will do a follow up PR that goes through and makes sure all the __all__s are correct.

[x] Manual test all register styles (registry-4-ia776l, temporarily commented out some loggers and registered them through the different registry methods)
[x] Write stub of the docs section
[ ] Pass through code again

What's the appropriate level for testing here?

@mvpatel2000 I did manual test of all the registration methods (see description), and have unit tests for all the registering methods. What other testing are you thinking? I could run the regression tests against this PR, not sure how much that adds though.

@mvpatel2000 should not require any yaml updates as the yaml API is not changing.


Metric could be analyst  by long time service.

Metric could be analyst by long time service.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 015f6f83-a6be-c2e8-773f-5220ec8ca41a
Version Independent ID: b962bde9-c513-ced9-6c91-013fc0c2baf5
Content: What is dedicated SQL pool (formerly SQL DW)? - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/sql-data-warehouse-overview-what-is.md
Service: synapse-analytics
Sub-service: sql-dw
GitHub Login: @WilliamDAssafMSFT
Microsoft Alias: wiassaf

@SIUNETWORKSGitHub
Thanks for your feedback! We will investigate and update as appropriate.

@SIUNETWORKSGitHub
Could you explain your query in more detail?


[BUG] harvester terraform provider 6.0 cleans up resource but reports timeout error

Describe the bug
Resource gets deleted correctly but terraform reports timeout issue.
Noticed when cleaning vlan vm-network on management network via terraform delete
To Reproduce
Steps to reproduce the behavior:

Create mgmt vlan vm-network (vlan_id=1) via terraform
Delete mgmt vlan vm-network via terraform

Expected behavior
A timeout error on Terraform to not be displayed
Environment

Harvester ISO version: v1.1.1
Underlying Infrastructure: bare-metal hp machine
Harvester Terraform:

    harvester = {
      source = "harvester/harvester"
      version = "0.6.0"
    }

Additional context
Log:
harvester_virtualmachine.dr27-head-vm: Destroying... [id=default/docker-rancher-27-head]
harvester_virtualmachine.dr27-head-vm: Destruction complete after 1s
harvester_ssh_key.dr27-head-ssh-key: Destroying... [id=default/dr27-head-ssh-key]
harvester_network.mgmt-vlan1-dr27-head: Destroying... [id=default/mgmt-vlan1-dr27-head]
harvester_image.ubuntu2204-jammy-dr27-head: Destroying... [id=default/ubuntu-2204-dr27-head]
kubernetes_secret.dr27-head-cloud-config-secret: Destroying... [id=default/dr27-head-cc-secret]
harvester_ssh_key.dr27-head-ssh-key: Destruction complete after 0s
harvester_image.ubuntu2204-jammy-dr27-head: Destruction complete after 0s
kubernetes_secret.dr27-head-cloud-config-secret: Destruction complete after 0s
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 10s elapsed]
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 20s elapsed]
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 30s elapsed]
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 40s elapsed]
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 50s elapsed]
harvester_network.mgmt-vlan1-dr27-head: Still destroying... [id=default/mgmt-vlan1-dr27-head, 1m0s elapsed]
╷
│ Error: timeout waiting for network default/mgmt-vlan1-dr27-head to be deleted
│
│
╵

updated reproducibility as this seems very easy to reproduce consistently with vm-networks based on mgmt vlan

@futuretea  - thanks for looking into this :smile: :+1:
Here is the outline of some of the files that were part of the rollout:
https://github.com/irishgordo/crop-bushels/tree/main/terraform/applications/docker-rancher269

@irishgordo @futuretea would be good if we can double-check this issue with the Harvester v1.1.2-head version, thanks.

@irishgordo @guangbochen I tried to reproduce the issue on Harvester v1.1.1/v1.1-head (today) + terraform v0.6.0, using the  terraform configuration https://github.com/irishgordo/crop-bushels/tree/main/terraform/applications/docker-rancher-27-head, but I could not reproduce the issue:
harvester_virtualmachine.dr27-head-vm: Destroying... [id=default/rancher27head]
harvester_virtualmachine.dr27-head-vm: Still destroying... [id=default/rancher27head, 10s elapsed]
harvester_virtualmachine.dr27-head-vm: Destruction complete after 13s
harvester_network.mgmt-vlan1-dr27-head: Destroying... [id=default/mgmt-vlan1-dr27-head]
harvester_ssh_key.dr27-head-ssh-key: Destroying... [id=default/dr27-head-ssh-key]
harvester_image.ubuntu2204-jammy-dr27-head: Destroying... [id=default/ubuntu-2204-dr27-head]
kubernetes_secret.dr27-head-cloud-config-secret: Destroying... [id=default/dr27-head-cc-secret]
harvester_ssh_key.dr27-head-ssh-key: Destruction complete after 0s
harvester_image.ubuntu2204-jammy-dr27-head: Destruction complete after 0s
kubernetes_secret.dr27-head-cloud-config-secret: Destruction complete after 0s
harvester_network.mgmt-vlan1-dr27-head: Destruction complete after 0s

Destroy complete! Resources: 5 destroyed.


Updated timeouts and documentation - PR request

Hey there!
Thank you for this playbook!
I had a few changes for the README and a few timings that helped to get this deployment working.
Would it be possible to submit a PR?

Please! Submit away!
Chris Short
https://chrisshort.net
https://devopsish.com
On Mon, Jul 2, 2018 at 4:27 AM, Tom F<EMAIL_ADDRESS>wrote:

Hey there!
Thank you for this playbook!
I had a few changes for the README and a few timings that helped to get
this deployment working.
Would it be possible to submit a PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rak8s/rak8s/issues/36, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVB-YvjWtHzzjrSoyRoR7sHtbvQOBRnks5uCdlogaJpZM4U-45B
.

Submitted PR #37
:)


Public link not working properly.

To Reproduce
Steps to reproduce the behavior:

Uploaded img in parent folder(Public).
Then took its public link and added it to one package.
Now created folder and then moved file into new folder.
Again took its public link and saved it in same package.

Functionality Changed.


semver v0.11 regression parsing openssl-src VersionReqs

See this RustSec PR and the versioning scheme used by the openssl-src crate:

https://github.com/RustSec/advisory-db/pull/450
https://crates.io/crates/openssl-src/versions

semver versions v0.10 and earlier were able to parse these requirements:

>= 111.9.0+1.1.1g
< 111.6.0+1.1.1d

With v0.11 I get the following error:

the given version requirement is invalid

Per the PR I'm trying to work around the issue by using a wildcard.

Interesting, these should be valid versions. Thanks / sorry.

we've noticed similar issues when we tried to upgrade semver in the crates.io codebase. specifically version requirements like https://github.com/dhylands/serial-monitor/blob/71e52ac9b66fd999681e5fbbb8ac415a36e69bd2/Cargo.toml#L26 are failing to parse, even though they can be parsed as a regular Version.
I've created https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6726d4731dd480fb26a48b2ed29ec491 to reproduce the problem.

I've also noticed that some pre-release fields like alpha.1a cannot be parsed as VersionReq on semver v0.11, while they are correctly parsed as Version:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6d7008e0bea904e17957909182e4bb1e

Relevant issue in the semver-parser crate, which is where the semver crate delegates to for the parsing logic: https://github.com/steveklabnik/semver-parser/issues/55.

This is fixed in 1.0.0.


procfile watcher should log when a problem occurs on add a new watcher

an example is a command that not exist

Same as #11.