Installation failed: TypeError: Cannot read property '1' of null

I am trying to install git-hours on Ubuntu 18.04 and I am getting an error:
/usr/local/lib/node_modules/git-hours/node_modules/promisify-node/utils/args.js:9
  var args = func.toString().match(/function\s.*?\(([^)]*)\)/)[1];
                                                              ^

TypeError: Cannot read property '1' of null
    at module.exports (/usr/local/lib/node_modules/git-hours/node_modules/promisify-node/utils/args.js:9:63)
    at /usr/local/lib/node_modules/git-hours/node_modules/promisify-node/index.js:79:29
    at Array.filter (<anonymous>)
    at processExports (/usr/local/lib/node_modules/git-hours/node_modules/promisify-node/index.js:60:6)
    at module.exports (/usr/local/lib/node_modules/git-hours/node_modules/promisify-node/index.js:112:10)
    at Object.<anonymous> (/usr/local/lib/node_modules/git-hours/node_modules/nodegit/generate/scripts/generateNativeCode.js:3:13)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)

I got things working on Ubuntu 16. Details posted here: https://github.com/kimmobrunfeldt/git-hours/issues/34

I get the same error trying to install on Windows 10. I don't think it's a nodegit issue because I installed nodegit separately and it worked.

Having same error on Mint 19, with npm 6.7.0.
nodegit is installed without problems

I got exact problem when installing using node v10.16.0
It runs perfectly when I install using node v6.17.1

For anyone cannot install this tool using new version of node, it seems to be a problem with dependency nodegit.
I assign a specific latest version of nodegit in package.json, it works fine.
{
"devDependencies": {
    "git-hours": "^1.3.0",
    "nodegit": "^0.26.1"
  },
  "resolutions": {
    "nodegit": "^0.26.1"
  }
}

same error here on node 10 on chromebook's debian installation
$ uname -a
Linux penguin 4.19.44-04937-gd773af751792 #1 SMP PREEMPT Thu Aug 8 21:43:29 PDT 2019 x86_64 GNU/Linux
apart from this tool's installation node works perfectly

For anyone cannot install this tool using new version of node, it seems to be a problem with dependency nodegit.
I assign a specific latest version of nodegit in package.json, it works fine.
{
"devDependencies": {
    "git-hours": "^1.3.0",
    "nodegit": "^0.26.1"
  },
  "resolutions": {
    "nodegit": "^0.26.1"
  }
}

Should be a workaround (also fixed #43 ) before the author publish the new version

Where is nodegit's package.json when installing -g globally?

I worked it out https://github.com/kimmobrunfeldt/git-hours/issues/56#issuecomment-786991024

After new release 1.5.0, npx git-hours works again! Tested with node 14, macOS. The node version is probably quite specific.


Merge up 2.4.x to 2.5.x

Summary
Merging up 2.4.x to 2.5.x before release

looks like it needs a rebase, I tried to do it, but I couldn't 😞


[Question] Is there a way to skip animation based on some conditional?

something like this where if immediate is true the animation will be skipped
animate(node, {}, { immediate: true })

Thanks

I think duration: 0 achieves the same effect?

duration: 0 doesn't work with spring

But it is possible already to do
animate(node, {}, immediate ? { duration: 0 } : spring)

I am not aware of that syntax. isn't spring an easing?
animate(node, {}, { easing: spring(), duration: 0 }

figured it out, Thanks for your help
animate(node, {}, immediate ? { easing: spring() } : { duration: 0 })


source: mysql: Setup common borked

(.venv) pdxjohnny@rza maintained $ pip install -r dffml-source-mysql
Requirement already satisfied: dffml==0.3.0 in ./.venv/lib/python3.7/site-packages (from -r packages (line 1)) (0.3.0)
Collecting dffml-source-mysql==0.0.2 (from -r packages (line 9))
  Downloading https://files.pythonhosted.org/packages/f7/af/574a9285e3237b6a4b82b2ccba100d591c31a453b956368de9d09b4d6e9d/dffml-source-mysql-0.0.2.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-7n6qa4kv/dffml-source-mysql/setup.py", line 3, in <module>
        from dffml_setup_common import SETUP_KWARGS, IMPORT_NAME
    ModuleNotFoundError: No module named 'dffml_setup_common'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-7n6qa4kv/dffml-source-mysql/
You are using pip version 18.1, however version 19.3.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Re-run dffml service dev create source dffml-source-mysql
copy implementation and test files from source/mysql into dffml-source-mysql
replace source/mysql with the newly created dffml-source-mysql

I'd like to work on this issue.

mysql test is failing now. If I run python setup.py test inside source/mysql/dffml-source-mysql then i get the following error:


Support step, next and finish in disassembly view

From user feedback: Only step was implemented from disassembly.

@gregg-miskelly @jacdavis

LGTM

:+1:


Restore account list look

Restores the look of the account renderer

fixes #4975

Since we're changing this can we listen to user feedback that name is confusing, and login (e.g. email) clarifies things? For reference, here is my dropdown from VS2019. It is way clearer and matches the fact we now show email in the Azure section of data explorer.
Account picker:

Account summaries:

We have an existing issue to handle adding email #3539. This is just to fix the bug that was causing the name to be hidden.

My question is: given we're changing this is it that hard to put in the email and be done with this?

Not sure, I didn't look too much into it, but I would like to get this into april release; since it just looks bad, so minimizing the change to existing functionality, while also fixing the bug, is my goal here.

Gotcha. My frustration was that this has been a known issue for so long, but understand you're doing a scoped fix. I would just reallly like us to look at larger issue soon.

The missing email address issue is annoying for me as well, since I have two accounts that both basically display the same and I have to remember which is my "Microsoft" account and which is my "Microsoft Account" account.  Fixed with https://github.com/Microsoft/azuredatastudio/pull/5015.
I think the underlying reason for long standing bugs like that is the folks that built this feature, and most other features, are now working in different areas and we're lacking committers (or have overcommitted committers) for many features.


[ITensors] Generalize correlation_matrix by ensuring it doesn't create ops on unused sites

Generalize correlation_matrix by ensuring it doesn't create ops on unused sites. Before it was hard-coded to use the first site to check Hermiticity of operators, which could cause trouble if the particular op isn't defined for that site. Now it uses the first site in the sites input.
This helps with calling correlation_matrix on MPS that have dangling bonds, such as ones sliced from other MPS (like infinite MPS, see https://github.com/ITensor/ITensorInfiniteMPS.jl/pull/72). In that case, you can make "dummy" MPS tensors as the first and last sites that are delta tensors made from the dangling indices, since dangling indices aren't handled correctly right now (though it would be nice to support dangling indices directly). These act like sites, but then can be skipped over with the sites input.
@nbaldelli

Codecov Report

Merging #1081 (9dbb508) into main (5d8af96) will decrease coverage by 25.83%.
The diff coverage is 0.00%.

:exclamation: Current head 9dbb508 differs from pull request most recent head 46a6248. Consider uploading reports for the commit 46a6248 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1081       +/-   ##
===========================================
- Coverage   67.81%   41.99%   -25.83%
===========================================
  Files          95       94        -1
  Lines        9999     9945       -54
===========================================
- Hits         6781     4176     -2605
- Misses       3218     5769     +2551

Impacted Files
Coverage Δ

src/mps/mps.jl
0.00% <0.00%> (-90.38%)
:arrow_down:

src/adapt.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/mps/adapt.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/mps/projmpo.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/mps/observer.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/physics/autompo/matelem.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/physics/autompo/qnmatelem.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/physics/autompo/opsum_to_mpo.jl
0.00% <0.00%> (-100.00%)
:arrow_down:

src/physics/autompo/opsum_to_mpo_qn.jl
0.00% <0.00%> (-97.62%)
:arrow_down:

src/physics/autompo/opsum_to_mpo_generic.jl
0.00% <0.00%> (-95.75%)
:arrow_down:

... and 34 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mps]


Aroma

This PR solves the issue with AROMA after its recent update.

Hi Tibor,
Thanks for working on this!
I saw the issue you opened on the AROMA repo in re 2.7 versus 3.6. Do that need to be resolved before this PR can be merged?
Also, I recall AROMA would not run here on anything but 2.7; other than the numpy dependency, has something changed in their code that fixes this?

No, we do not have to wait for that PR. My solution was to stick to an older commit, which does not ask for numpy=1.22.
You can try the installation I use for the CI. See the updated aamod_AROMA_denoise.m for instructions. Make sure you start from a new (conda) environment and you may consider switching off cache (i.e. pip install --no-cache-dir -r requirements.txt) to simulate a 'virgin' environment.

Downloaded this PR to test locally. Unfortunately, it doesn't get past aas_processBIDS:
Error using matlabpath
Must be a string scalar or character vector.

Error in rmpath (line 79)
	matlabpath([cmdirs{:}])

Error in toolboxClass/unload (line 147)
                rmpath(sprintf(['%s' pathsep],obj.toolInPath{:}))

Error in aas_processBIDS (line 159)
SPMtool.unload;

Stepping through rmpath in the debugger, it appears SPMtool.unload has deleted my entire Matlab path (therefore cmdirs{:} is empty at rmpath line 79, which matlabpath doesn't like).
Is there any chance you may have run across this error in the past and remember the fix? It's probably not an aas_processBIDS.m or toolboxClass.m issue because the versions of these files in this PR are identical to those in the older aa version I'm using here for production work which doesn't crash.
M

A bit more info: The problem seems to be related to spmClass.m. Currently load reads
        function load(obj)
            addpath(obj.toolPath);

            load@toolboxClass(obj)

            spm_jobman('initcfg');

            % Update stored path
            p = split(path,pathsep);
            obj.toolInPath = cat(1,...
                obj.toolInPath,...
                setdiff(p(cellfun(@(x) contains(x,obj.toolPath), p)),obj.toolInPath)...
                );

Here, obj.toolInPath  =  '/path/to/automaticanalysis/aa_tools/toolboxes/spm_mods' on entry, but it gets set to my entire matlab path contents (1085 directories) by the update (obj.toolInPath = cat(1,...). The SPMtool.unload that gets called when aas_processBIDS finishes tries to remove all of these, which leads to the crash.
FYI: The previous version of spmClass.m (which does not crash for me) does not update toolInPath:
        function load(obj)
            addpath(obj.toolPath);
            spm_jobman('initcfg');

            load@toolboxClass(obj)
        end

(Sorry for being derpy about this -- I'm just not familiar with the toolbox class code.)

UPDATE: Ok, I found the problem (it's was an incompatibility in my param file)
Will begin testing the AROMA changes...

Ok, I was able to get this to run on my machine using our denoising example script and my existing install of the AROMA toolbox (should be the same as git reset --hard e8d7a5891563aff7ff71375078314c417d32d808).  I actually tested it under both Python 2.7 and 3.6. Both work.
TLDR: PR looks good to go. Merge away.

Thank you, Mike, for the meticulous testing.


Bug on Beryllium: Datatable has an issue with switching from no data to data when playing with filters...

The issue was located on the way we were showing the "no data" message. if was outside of the datatable component with a if/else. but when the boolean used if the if block was switching from true to false, the datatable was recreated, and thus columns were emptied.
chagning the logic to include that message and the boolean into the datatable component.


net/frr: needs ECMP support turned on

Important notices
[X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues and I'm convinced that mine is new.
[X] The title contains the plugin to which this issue belongs
Describe the bug
frr from net/frr6 does not support multipath due to compile-time options. It's just a matter of turning the knob on. This is a very easy fix, but I can't find where make.conf equivalent options are these days.
Only needs a single-line fix: net_frr6_SET+="MULTIPATH"
To Reproduce
Build an ECMP configuration in FRR; ECMP will not actually work and only a single route will be inserted.
Expected behavior
ECMP should be enabled and possible by default; necessary kernel components are in GENERIC by default
Screenshots
N/A
Relevant log files
N/A; known limitation based on options.
Additional context
Since I use OPNsense as the endpoint for Anycast DNS, which needs ECMP, this is a pretty big problem. As load scales up, a single processor (out of 4) will tip over without being dropped as the solitary route for the given address. This is amplified further by 'first in wins' behavior where a single processing node becomes the primary for multiple addresses.
Environment
OPNsense 20.1, frr6 6.0.2_4 (os-frr 1.14)

Changed to say 'net/frr' since frr6 and frr7 are both listed in builds. Also found where it needs set. PR incoming...


feat: slash command implementation

This starts the implementation of slash commands into the project. It adds a command manger and the ability to register commands with Discord. It has primitive wrapping of the d.js API but this is subject to improvement.
One command, edit, has been implemented with this PR. The formatting of commands is subject to change.
Finally, this upgrades the typescript version of the project.
Closes #281.

I'm thinking that the UI/UX for the edit command is suboptimal, perhaps we could utilise embeds for readability there?


Add port for x86-windows triplet

Not a bit problem at the moment, as there is no concrete need for it. Feel free to re-open if necessary.


Updated documentation

Is there a more up-to-date version of this document anywhere? The steps above do not work with the current App Registrations UI or Microsoft Graph API permissions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3efb0913-3c25-caf7-306b-c1ddd78439fe
Version Independent ID: b262e742-c371-ffb9-108b-67f2f5bbc297
Content: User migration approaches in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-user-migration.md
Service: active-directory
Sub-service: b2c
GitHub Login: @mmacy
Microsoft Alias: marsma

@moseleycj Thanks for your feedback! We will investigate and update as appropriate.

Thanks for letting us know about this issue, we're still looking into this but will let you know as soon as possible once we have an update on this. Unfortunately, updating an entire doc might take some time, but we're looking to make these changes as soon as possible. Thanks for bringing this to our attention!

Hi @moseleycj, I'd like to get a bit more info from you on this issue, if possible.

On the app registrations, it is still a similar process, but instead of selecting App registrations, you select App registrations (Legacy). I'll get this updated in the doc, but want to check: is there something else about the process that isn't working for you?

When you mention "Microsoft Graph API,"  I'm wondering where you're attempting to use that. Currently, Microsoft Graph is unsupported for working with user objects in a B2C tenant, and you must continue to use AD Graph. Can you clarify where/how it was breaking on you?

Thanks!

Hi @mmacy
It may well be just that the documentation was written for the older App
Registrations UI. However, on my portal, there is no longer an option to
select App Registrations (Legacy), it's been removed.
[image: image.png]
[image: image.png]
So when attempting to follow the article, most menu options look different
so it makes little sense. Also, Microsoft Graph API is automatically added
as a permissions endpoint when using the new App Registrations and as the
document talks about connecting to Graph, I can see this causing confusion
for people.
Thanks,
Chris.
On Thu, Jul 25, 2019 at 12:10 AM Marsh Macy<EMAIL_ADDRESS>wrote:

Hi @moseleycj https://github.com/moseleycj, I'd like to get a bit more
info from you on this issue, if possible.

On the app registrations, it is still a similar process, but instead
of selecting App registrations, you select App registrations
(Legacy). I'll get this updated in the doc, but want to check: is
there something else about the process that isn't working for you?
[image: image]
https://user-images.githubusercontent.com/13394541/61834553-4079db80-ae2d-11e9-9b4e-d497e099771b.png
2.
When you mention "Microsoft Graph API," I'm wondering where you're
attempting to use that. Currently, Microsoft Graph is unsupported for
working with user objects in a B2C tenant, and you must continue to use AD
Graph. Can you clarify where/how it was breaking on you?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/35742?email_source=notifications&email_token=AEDBICPW3ZOAR65Z4ODPDCTQBDOPXA5CNFSM4IGOTQNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2X3OQY#issuecomment-514832195,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEDBICOD7DLKKPYLELE2ZZDQBDOPXANCNFSM4IGOTQNA
.

--
Regards,
Chris Moseley.

@moseleycj Hi Chris, thanks for the quick response. Unfortunately, your images aren't showing up in your comment, but if you indeed don't have that option, it may be a bug.

Select the Directory + subscription filter button in the upper-right section of the Azure portal
Select the directory containing your Azure AD B2C tenant.

Once you've selected the directory containing your B2C tenant, then select Azure Active Directory from the left-hand menu. I've checked the portal with both my internal and external (MSDN) Azure accounts, and both show App registrations (Legacy) as long as I'm in my B2C tenant-containing directory:
Azure Active Directory selected within my MSDN account
However, that's not to say that some customers such as yourself aren't seeing something different than I as updates to the portal roll out in a staged manner. If you can confirm that you have indeed selected the directory containing your B2C tenant before selecting Azure Active Directory in the left-hand menu, I'll get this issue reported.

@moseleycj Hi Chris, checking back in to see if you've had a chance to verify whether you had the directory containing your B2C tenant selected prior to selecting AAD in the menu.

Hi Marsh, Apologies, I can confirm that I did not have the B2C tenant
selected. When selected, the App Registrations (Legacy) option is available
as described.
On Tue, 30 Jul 2019, 16:37 Marsh Macy<EMAIL_ADDRESS>wrote:

@moseleycj https://github.com/moseleycj Hi Chris, checking back in to
see if you've had a chance to verify whether you had the directory
containing your B2C tenant selected prior to selecting AAD in the menu.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/35742?email_source=notifications&email_token=AEDBICJLISCMKOOZGZMVJBDQCBNZ3A5CNFSM4IGOTQNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3EMHKQ#issuecomment-516473770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEDBICKE3REPTDFN6RD7C2DQCBNZ3ANCNFSM4IGOTQNA
.

@moseleycj Thanks Chris! Will get the doc updated with the current UI showing "(Legacy)" and will make it more clear that the B2C-containing director must be selected. Leaving this issue open until fix is merged.


Client configured to require client_secret

I am trying to use the oidc-client-js library with an Angular application. We are using PingFederate as our Identity Provider. The client is configured to require client_secret, I know that the client can be configured to work without client_secret but the team currently does not want to do that. The oidc-client-js library allows to pass the client_secret, my question is how secure it is to pass client_secret as it can be easily read during the request.
Are there any other ways I can send client_secret which will be more secure?
Any suggestions are welcome.
Thank you,
Priyank Patel

Hi @priyank89patel,
there's unfortunately no safe way to include the client_secret. The client secret is not something that changes, so that would mean you'd have to include the secret in the build of your angular app. If someone were to retrieve that secret by inspecting the JS loaded in their browser, they could authorize themselves.
Client secrets are typically used in "back channel" communication, which means "server to server", which is considered to be secure since you "own" the environment the code is running on.  They're not meant to be used in the browser or by the user directly!
If you're unable to use the authorization code flow with PKCE, you should look at the implicit flow.

Hi @priyank89patel,
there's unfortunately no safe way to include the client_secret. The client secret is not something that changes, so that would mean you'd have to include the secret in the build of your angular app. If someone were to retrieve that secret by inspecting the JS loaded in their browser, they could authorize themselves.
Client secrets are typically used in "back channel" communication, which means "server to server", which is considered to be secure since you "own" the environment the code is running on. They're not meant to be used in the browser or by the user directly!
If you're unable to use the authorization code flow with PKCE, you should look at the implicit flow.

Hello @kevinbungeneers ,
Thank you for taking time out to respond, I completely agree with you that there is no safe way to include client_secret in the Angular app as it can be inspected in the console as well during the request which puts the app at such a huge risk. The team has decided to move forward without storing the client_secret in the Angular app, we are making a secured back channel call to retrieve token response.
Thank you once again, closing this issue.


Add support for pnpm exec command

Description
Contrary to yarn run, pnpm run only runs scripts defined in the project's package.json file and doesn't work for shell commands of installed dependencies located in node_modules/.bin. To run those commands, one has to use the pnpm exec command, instead.
Since the command nr translates to pnpm run, it means it can't be used to run a project's shell command in a pnpm projects.
The following won't work in a pnpm project:
nr jest

This can be fixed by using the short form of the command, and so translating nr to pnpm. When using the short form, pnpm will try to run first a defined script if present, or otherwise, run a shell command. This is similar to the behavior of yarn run.

I am not so sure about this, as npm does not seem to support this convention. To me, I think nr should be explicitly doing the action run to avoid confusion. If you want to execute them without run, I suggest you use na jest. Thanks for your contribution.


fix. delete_cookite can't delete alreday set Cookie

Fix #2700.
Response::deleteCookie can't delete already set Cookie.
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ] User guide updated
[x] Conforms to style guide

😢  what's wrong?

@Instrye travis build failure seems unrelated

@lonnieezell plese check the PR.
fix. #2836
fix. #2700


Path configuration optimisation suggestion

In https://github.com/ambient-innovation/django-migration-zero/blob/9931254f987675beb6ba1d76860dcb1f926004d6/django_migration_zero/settings.py#L12

I'm wondering why the default for migration_zero_apps_dir is  /.  Perhaps an error should be raised instead?

Fixed in https://github.com/ambient-innovation/django-migration-zero/pull/8.


syncUrl locations are not deleted after posting.

Your Environment

Plugin version: 2.3.6 (latest stable)
Platform: Android
OS version: 8.1.0
Device manufacturer and model: OnePlus 5t
Cordova version (cordova -v): 8.1.1
Cordova platform version (cordova platform ls): android 7.1.1
Plugin configuration options:
const config : BackgroundGeolocationConfig = {
desiredAccuracy: 0,
stationaryRadius: 5,
distanceFilter: 5,
locationProvider: 0,
stopOnTerminate: true,
startForeground: false,
startOnBoot: true,
notificationTitle: "Tracking",
notificationText: "Tracking Location",
interval: 20000,
pauseLocationUpdates: false,
fastestInterval: 20000,
activitiesInterval: 20000,
stopOnStillActivity: false,
url: ApiDefinition.postLocation.getUrl() + "?teamId=" + teamId + "&deviceId=" + deviceId,
syncUrl: ApiDefinition.postLocationBatch.getUrl(),
syncThreshold: 5
};
Link to your project:

Context
When providing a sync URL, the server gets overlapping posts with each new location recorded. This is a major issue, because it pwns the data of the client device quadratically.
Expected Behavior
After a successful post to syncUrl, the locations should be marked as deleted, and not re-posted to the syncUrl
Actual Behavior
Each additional location adds one record to the records posted to syncUrl, regardless of whether the call to url succeeds or fails.
Possible Fix
I have no idea. It could just be that the requirements on the server for url and syncUrl haven't been documented, so I'm doing something wrong on that side. Here is my debug server code (ASP.net Web Api):
url:
[HttpPost]
[AllowAnonymous]
[ApiReadOnlyTransaction]
[ApiLogAccess]
[Route(nameof(PostLocation))]
public void PostLocation([FromUri] string teamId, [FromUri] string deviceId)
{
    Trace.WriteLine($"TeamId: {teamId}, DeviceId: {deviceId}");

    var raw = Request.Content.ReadAsStringAsync().Result;
    var result = JsonConvert.DeserializeObject<LocationRequest[]>(raw);
    if (result != null)
    {
        foreach (var elem in result)
        {
            Trace.WriteLine(elem);
        }
    }
}

And syncUrl:
[HttpPost]
[AllowAnonymous]
[ApiReadOnlyTransaction]
[ApiLogAccess]
[Route(nameof(PostLocationBatch))]
public void PostLocationBatch()
{
    var raw = Request.Content.ReadAsStringAsync().Result;
    var result = JsonConvert.DeserializeObject<LocationRequest[]>(raw);
    if (result != null)
    {
        foreach (var elem in result)
        {
            Trace.WriteLine(elem);
        }
    }
}

Steps to Reproduce

Supply a url and a syncUrl
Observe that syncUrl is called and that locations are never deleted or retired.

Context
Commercial services marketplace app (new version) with automated check-in/check-out. I cannot use 3-alpha because it requires updating ionic to alpha (which is not stable at the moment).
Debug logs
None

Are you returning 2xx header in response from the server?
On Thu, Oct 11, 2018 at 6:43 PM Adam4224<EMAIL_ADDRESS>wrote:

Your Environment

Plugin version: 2.3.6 (latest stable)
Platform: Android
OS version: 8.1.0
Device manufacturer and model: OnePlus 5t
Cordova version (cordova -v): 8.1.1
Cordova platform version (cordova platform ls): android 7.1.1
Plugin configuration options:
const config : BackgroundGeolocationConfig = {
desiredAccuracy: 0,
stationaryRadius: 5,
distanceFilter: 5,
locationProvider: 0,
stopOnTerminate: true,
startForeground: false,
startOnBoot: true,
notificationTitle: "Tracking",
notificationText: "Tracking Location",
interval: 20000,
pauseLocationUpdates: false,
fastestInterval: 20000,
activitiesInterval: 20000,
stopOnStillActivity: false,
url: ApiDefinition.postLocation.getUrl() + "?teamId=" + teamId +
"&deviceId=" + deviceId,
syncUrl: ApiDefinition.postLocationBatch.getUrl(),
syncThreshold: 5
};
Link to your project:

Context
When providing a sync URL, the server gets overlapping posts with each new
location recorded. This is a major issue, because it pwns the data of the
client device quadratically.
Expected Behavior
After a successful post to syncUrl, the locations should be marked as
deleted, and not re-posted to the syncUrl
Actual Behavior
Each additional location adds one record to the records posted to syncUrl,
regardless of whether the call to url succeeds or fails.
Possible Fix
I have no idea. It could just be that the requirements on the server for
url and syncUrl haven't been documented, so I'm doing something wrong on
that side. Here is my debug server code (ASP.net Web Api):
url:
`
[HttpPost]
[AllowAnonymous]
[ApiReadOnlyTransaction]
[ApiLogAccess]
[Route(nameof(PostLocation))]
public void PostLocation([FromUri] string teamId, [FromUri] string
deviceId)
{
Trace.WriteLine($"TeamId: {teamId}, DeviceId: {deviceId}");
var raw = Request.Content.ReadAsStringAsync().Result;
var result = JsonConvert.DeserializeObject<LocationRequest[]>(raw);
if (result != null)
{
foreach (var elem in result)
{
Trace.WriteLine(elem);
}
}
}
`
And syncUrl:
[HttpPost] [AllowAnonymous] [ApiReadOnlyTransaction] [ApiLogAccess]
[Route(nameof(PostLocationBatch))] public void PostLocationBatch() { var
raw = Request.Content.ReadAsStringAsync().Result; var result =
JsonConvert.DeserializeObject<LocationRequest[]>(raw); if (result != null)
{ foreach (var elem in result) { Trace.WriteLine(elem); } } }
Steps to Reproduce

Supply a url and a syncUrl
Observe that syncUrl is called and that locations are never deleted
or retired.

Context
Commercial services marketplace app (new version) with automated
check-in/check-out. I cannot use 3-alpha because it requires updating ionic
to alpha (which is not stable at the moment).
Debug logs
None
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/492,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAV8GjsI70fXP7HSYqsTDztu5BZgt3T5ks5uj3UVgaJpZM4XX8Mg
.

Returning 200 from the same server method appears to result in the locations being deleted. So I think it was the return code, but I think you should document that a return code of OK - 200 is required, or fix is so that 2xx works.
I can close and submit a new issue if you like.

I thought it's obvious that server should return 2xx success code on success, but agree that's it's could be mentioned in the docs. Will you prepare PR for that?

Hi,
2xx doesn't work. You must return 200.
On Fri, 12 Oct 2018, 1:45 pm Marián Hello<EMAIL_ADDRESS>wrote:

I thought it's obvious that server should return 2xx success code on
success, but agree that's it's could be mentioned in the docs. Will you
prepare PR for that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mauron85/cordova-plugin-background-geolocation/issues/492#issuecomment-429312986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AqBoE2wx-De6NeajipcUeS9YHLtYL1-wks5ukI7VgaJpZM4XX8Mg
.

Yes, on version 2.3.6 only 200 header is supported. Closing as resolved.


Xcode 15 Exited with status code 127

Current behavior
Hi, when I try to build on Xcode 15 it throws Exited with status code 127.  I've tried it on my project and the example project, both throw the same error.
See atached .txt for the logs, it seems that it exits on /bin/sh -c /var/folders/tc/sj1dwpmd3wx006fkwntygshh0000gn/T/SchemeScriptAction-fuoWNX.sh, I've tried to run the script on my terminal and it throws No such file or directory
Build KeysExample-Dev_2023-09-27T10-42-05.txt
Expected behavior
Platform

[] Android
[X] iOS

React Native Version 0.72.5
React Native Compressor Version
Reproducible Steps And Demo

@efstathiosntonas can you send the screenshot of your preaction script?

@efstathiosntonas i tested, it is working on my side

@numandev1 thanks for the fast reply. I'm running the example from this repo.
steps:
0. Sonoma 14

yarn install
cd example
yarn install
cd ios
pod install
open on Xcode
build on simulator iOS 17

I'm not doing anything else, I didn't touched the schemas. Really weird.

I've runned it again, now it throws some more info at the ending lines of the log:
    /bin/sh -c /var/folders/tc/sj1dwpmd3wx006fkwntygshh0000gn/T/SchemeScriptAction-sh6CQB.sh

env: node: No such file or directory

if you are using nvm then please follow this guide https://github.com/numandev1/react-native-keys#using-node-with-nvm-fnm-or-notion

Yeah, I suspected nvm is the issue this after the error above, looking into it now

@numandev1 it's fine now, thank you for your help, keep it up!


How to use the logger to automatically log to slack

Thanks for the contribution to adonisjs ecosystem.
I just tried out the logger, and it works out-of-the-box for exception handling 🥳
However, what I did not get yet or probably set up wrong is the following:
What I did so far:
logger.ts
default: 'slack',
slack: {
      enabled: true,
      name: env.get('APP_NAME'),
      level: env.get('LOG_LEVEL', 'info'),
      icon: 'boom',
      url: env.get('LOG_SLACK_WEBHOOK_URL'),
      transport: {
        targets: targets()
          .pushIf(!app.inProduction, targets.pretty())
          .pushIf(app.inProduction, targets.file({ destination: 1 }))
          .toArray(),
      },
    },

I want to send it automatically to slack when I write somewhere in the code logger.error('New error'), however, it is just logged in the console but not sent to slack?
Am I doing something wrong?

hey @Tob0t , I have updated the documentation, please check again

Cool thanks a lot, now it works 👍


Transpiling with a coupling map strips qubit names, misidentifies ancillas, scrambles the measurement

Environment

Qiskit Terra version: 0.19.2
Python version: 3.9.7
Operating system: Ubuntu 20.04

What is happening?
Transpiling with a coupling map strips qubit names from instructions/data. It also scrambles the measurement, in some cases creating a measurement on an ancilla rather the originally targeted qubit.
Circuit, made by initializing an entangled state, transpiled with no coupling map gives:
  s_0: ───┤ Ry(π/2) ├────────────────────────────────┤ X ├┤ Ry(0) ├┤ X ├»
       ┌──┴─────────┴──┐ ┌───┐┌────────────────┐┌───┐└─┬─┘└───────┘└─┬─┘»
  s_1: ┤ R(2.6779,π/2) ├─┤ X ├┤ R(0.46365,π/2) ├┤ X ├──■─────────────┼──»
       ├───────────────┴┐└─┬─┘└────────────────┘└─┬─┘                │  »
  s_2: ┤ U3(2.3005,0,0) ├──■──────────────────────■──────────────────■──»
       └────────────────┘                                               »
c11: 3/═════════════════════════════════════════════════════════════════»
                                                                        »
«       ┌──────────┐┌───┐┌───────┐┌───┐┌─┐
«  s_0: ┤ Ry(-π/2) ├┤ X ├┤ Ry(0) ├┤ X ├┤M├───
«       └──────────┘└─┬─┘└──┬─┬──┘└─┬─┘└╥┘
«  s_1: ──────────────■─────┤M├─────┼───╫────
«                           └╥┘     │   ║ ┌─┐
«  s_2: ─────────────────────╫──────■───╫─┤M├
«                            ║          ║ └╥┘
«c11: 3/═════════════════════╩══════════╩══╩═
«                            1          0  2

Qubits:
[Qubit(QuantumRegister(3, 's'), 0), Qubit(QuantumRegister(3, 's'), 1), Qubit(QuantumRegister(3, 's'), 2)] [Clbit(ClassicalRegister(3, 'c11'), 0), Clbit(ClassicalRegister(3, 'c11'), 1), Clbit(ClassicalRegister(3, 'c11'), 2)]
Circuit, made by initializing an entangled state, transpiled with coupling map gives
      s_2 -> 0 ┤ U3(2.3005,0,0) ├──■──────────────────────■────X───────────»
               └────────────────┘  │                      │    │           »
ancilla_0 -> 1 ────────────────────┼──────────────────────┼────X───────────»
               ┌───────────────┐ ┌─┴─┐┌────────────────┐┌─┴─┐              »
      s_1 -> 2 ┤ R(2.6779,π/2) ├─┤ X ├┤ R(0.46365,π/2) ├┤ X ├──■───────────»
               └──┬─────────┬──┘ └───┘└────────────────┘└───┘┌─┴─┐┌───────┐»
      s_0 -> 3 ───┤ Ry(π/2) ├────────────────────────────────┤ X ├┤ Ry(0) ├»
                  └─────────┘                                └───┘└───────┘»
        c11: 3/════════════════════════════════════════════════════════════»
                                                                           »
«                                                    ░
«      s_2 -> 0 ─────────────────────────────────────░──────────
«                                                    ░       ┌─┐
«ancilla_0 -> 1 ──■──────────────────────────────■───░───────┤M├
«                 │                              │   ░    ┌─┐└╥┘
«      s_1 -> 2 ──┼────────────────■─────────────┼───░────┤M├─╫─
«               ┌─┴─┐┌──────────┐┌─┴─┐┌───────┐┌─┴─┐ ░ ┌─┐└╥┘ ║
«      s_0 -> 3 ┤ X ├┤ Ry(-π/2) ├┤ X ├┤ Ry(0) ├┤ X ├─░─┤M├─╫──╫─
«               └───┘└──────────┘└───┘└───────┘└───┘ ░ └╥┘ ║  ║
«        c11: 3/════════════════════════════════════════╩══╩══╩═
«                                                       0  1  2

Qubits:
[Qubit(QuantumRegister(4, 'q'), 0), Qubit(QuantumRegister(4, 'q'), 1), Qubit(QuantumRegister(4, 'q'), 2), Qubit(QuantumRegister(4, 'q'), 3)] [Clbit(ClassicalRegister(3, 'c11'), 0), Clbit(ClassicalRegister(3, 'c11'), 1), Clbit(ClassicalRegister(3, 'c11'), 2)]
How can we reproduce the issue?
#initialization
import matplotlib.pyplot as plt
import math

# importing Qiskit
from qiskit import Aer, transpile
from qiskit import QuantumCircuit, ClassicalRegister, QuantumRegister
from qiskit import transpile, QuantumCircuit
from qiskit.providers.aer import Aer
from qiskit.visualization import *

# import basic plot tools
from qiskit.visualization import plot_histogram

## Basic Setup
sv_backend = Aer.get_backend('statevector_simulator')

## Transpiler Settings
c_map=[[0,1], [0,2], [2,3], [1,3],[1,0], [2,0], [3,2], [3,1]]

# Init circuit with entangled state
circ = QuantumCircuit(QuantumRegister(3,'s'),ClassicalRegister(3))
circ.initialize([0, 0,  0,  1 / math.sqrt(6),   0 , 1 / math.sqrt(6),   math.sqrt(2/3),  0], [i for i in range(3)])
circ=circ.decompose().decompose().decompose().decompose().decompose()

#transpile two ways
tcirc=transpile(circ, optimization_level=3) # Transpile without Coupling Map
tcirc_map=transpile(circ, optimization_level=3, coupling_map=c_map) # Transpile with Coupling Map

#Draw and Print regs
tcirc.draw()
print(tcirc.qubits, tcirc.clbits)

tcirc_map.draw()
print(tcirc_map.qubits, tcirc_map.clbits)

What should happen?
I would expect that transpiling with the coupling map:

Keeps qubit names faithful to their original assignments
Identifies ancilla qubits added to the circuit as such in circuit.qubits
Does not induce measurements on ancilla quibits, or if it does to save swaps, renames the ancilla to be the original logical qubit.

Any suggestions?
No response

The names of qubits after transpilation will not generally line up with any single logical qubit in the circuit before transpilation.  This is expected, and to some degree it's a completely unsolvable problem, because due to the constraints of a real backend, we'll sometimes need to perform swaps in order to get two logical qubits close enough in hardware to actually perform the measurement.  That means that at various points, hardware qubit $0 may be representing different logical qubits, including ones that were added as ancillas.
After transpilation with a coupling map, you're looking at the hardware qubits, not the logical ones, so you'll see a lot of this swapping.  The names line up with which logical qubit starts on each hardware qubit as a rough guide, but I'm not sure I can see a sensible way for us to do more than that.

Hi Jake,
Thanks for the response! So there are two issues here:

One is that the graphical representation does not reflect the class data of the circuit -- we see that the labeled quits and ancillas are displayed on calling the .draw() method, however the names and information have been wiped from QuantumCircuit.qubits. I believe that these should be in agreement at all times. If I call the draw() method, I would expect to see the correct qubit names, even if they are wiped.

The second is that on a circuit with n < N qubits submitted with a coupling map, we run into issues with partial measurement. Since bit-ordering is jumbled, and get_counts() returns "0" for unmeasured qubits, it's actually unclear what states we are getting without a lot of backdoor hacking. Maybe the alternate fix is to return a place holder for a partial measurement rather than a "0"?

I am not sure I follow here.  The names have changed because one has mapped from virtual qubits to "physical" qubits.  The number of physical qubits used need not be the same as the input if the system is larger than the input circuit width.  If I have multiple quantum registers, which one should these one or more additional qubits be assigned?  There is ambiguity there.
get_counts returns the classical registers that you attach to a circuit.  Those elements of said registers not assigned a measurement result are 0 by convention.  So if you assign the same number of bits as the number of qubits in the target device, but you do not use them all, then there will be extra zeros.  The bit-ordering itself is never jumbled, and is always well defined.  I noticed that your original code is calling the statevector_simulator in which case there is a permutation due to swapping that moves the state of the qubits around.  If this is your issue then yes it is a bit tricky, and has been a known issue for some time.  I have had an example PR of how to get this permutation (so you can undo it) here: https://github.com/Qiskit/qiskit-terra/pull/6827, but it has obviously not gained any traction.


refactoring external CA tests

Please provide a description of this PR:

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc970d50c173d284eaa01e85211ab9d13be8e333
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
cc970d50c173d284eaa01e85211ab9d13be8e333
link
true
/test lint_istio

gencheck_istio
cc970d50c173d284eaa01e85211ab9d13be8e333
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
d13f7f591c1f41238c448faf3cb5603ea9949687
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
d13f7f591c1f41238c448faf3cb5603ea9949687
link
true
/test integ-security-istiodremote_istio

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
d13f7f591c1f41238c448faf3cb5603ea9949687
link
true
/test integ-security-istiodremote_istio

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-pilot_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-pilot_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-pilot_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-pilot_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-pilot_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-ipv6_istio

integ-telemetry_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry_istio

integ-operator-controller_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test lint_istio

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-ipv6_istio

integ-telemetry_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry_istio

integ-operator-controller_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-operator-controller_istio

integ-distroless_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-ipv6_istio

integ-telemetry_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry_istio

integ-operator-controller_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-operator-controller_istio

integ-distroless_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-distroless_istio

lint_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
3c338381aa139db663adef24932c84a9854a4b95
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test analyze-tests_istio

unit-tests_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test unit-tests_istio

integ-pilot_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-pilot_istio

integ-security_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-security_istio

integ-helm_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-helm_istio

integ-telemetry-mc_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry-mc_istio

integ-ipv6_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-ipv6_istio

integ-telemetry_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-telemetry_istio

integ-operator-controller_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-operator-controller_istio

integ-distroless_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-distroless_istio

lint_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test lint_istio

integ-cni_istio
4dafe242357dbc3de059331e6d2e38691e55c2e6
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

unit-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

unit-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test unit-tests_istio

lint_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

unit-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test unit-tests_istio

lint_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test lint_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

unit-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test unit-tests_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

lint_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

analyze-tests_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test analyze-tests_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

lint_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test lint_istio

unit-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

lint_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test lint_istio

unit-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test unit-tests_istio

analyze-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

lint_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test lint_istio

unit-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test unit-tests_istio

analyze-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test analyze-tests_istio

integ-distroless_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ipv6_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-ipv6_istio

integ-security-istiodremote_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-security-istiodremote_istio

integ-operator-controller_istio
f947d1d0e7b6da72c7a200ed542675e75091f2da
link
true
/test integ-operator-controller_istio

lint_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test lint_istio

unit-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test unit-tests_istio

analyze-tests_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test analyze-tests_istio

integ-distroless_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test integ-distroless_istio

integ-telemetry-mc_istio
3f03809443ddf3260ba492c96fc170c05bb8b045
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8b0d75b032aa7c0c006065ac40081442ad33616c
link
true
/test lint_istio

gencheck_istio
8b0d75b032aa7c0c006065ac40081442ad33616c
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-istiodremote_istio

@aryan16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8b0d75b032aa7c0c006065ac40081442ad33616c
link
true
/test lint_istio

gencheck_istio
8b0d75b032aa7c0c006065ac40081442ad33616c
link
true
/test gencheck_istio

integ-telemetry-istiodremote_istio
8b0d75b032aa7c0c006065ac40081442ad33616c
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I believe that could be happening for a reason, probably for some tests we would want to replace the overlays with the new overlays instead of just appending the new value.

Maybe. Then I suppose we would add a field to specify merge or overwrite. I guess we'd need a field (default overwrite) for backward compatibility anyway.

cc : @zirain

@aryan16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
cad51530d0b0919854ae9ce492b746ab7e135fd5
link
unknown
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Modal focus escapes when there is no focusable element after the modal HTML

You can escape the enforced focus of the modal, by using the tab key, if there is not focusable element after the modal's HTML markup, such as;

...
            <button ... data-toggle="modal" data-target="#myModal">Open</button> ...

...

If there is no focusable element in between the modal div and the close body tag, the focus will be lost by pressing the tab key.  See  http://codepen.io/anon/pen/vNORPG
The workaround is to add a focusable element in between, such as;

...

    ...

Hi @wcopenhaver!
You appear to have posted a live example (http://codepen.io/anon/pen/vNORPG.html), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 10, column 3: E013: Only columns (.col-*-*) may be children of .rows

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Successor: #17530.


Submit page validation improvements

@talhasch Nice, could we also add Tag-selector component line 66: if (e.keyCode === 13) { add this || e.keyCode === 32 || e.keyCode === 188 into tag selector for space and comma ? Much easier to follow for some people..

@feruzm sure

done


Use $log instead of console.log

The error statements should probably use Angular's built-in $log provider (https://docs.angularjs.org/api/ng/service/$log) rather than console.log.  This allows implementers to customize $log as they see fit.

Hey Ryan,
Looks like this change introduced a bug.  On the injection:
.run(['$rootScope', '$state', 'GRANT_ERROR', function($rootScope, $state, $log, GRANT_ERROR)
You never included the '$log'..

@mmaday good catch again. Not sure why I wasn't getting the error when I was testing, but should be good now. Please test on your end.

Looking good!  Thanks.


SEO friendly its not well documented and promoted CloudFlare

the SEO its not well explained( #26 ) , or maybe there's a bug, cos it said: disabled by default, since it requires a default redirection to index.html
means that due index.html is the default rendering and the javascrip only parsed the content of the file, the web server need to provide a way to rewrite the url that always request the index.html as end point of each root web page ?
but :
i put to true browserRoute and sitePAth to "/wiki"

when requesting localhost/wiki/ it renders good
when requesting localhost/wiki/page it does not renders if i call from url of browser
when requesting localhost/wiki/page it renders if i call from a link inside a rendered page

so due last case its called from "index.html" as you pointed, works but you never defined a more explicit method to get such results, i only got a vage idea using rewrite, event spend in CloudFlare and give more importance to a enterprise..
also navbar fails in rare cases:

I agree, giving Cloudflare as the only example was a bit lazy from me.
Which other servers examples would you like ? Nginx and Apache ?

I agree, giving Cloudflare as the only example was a bit lazy from me. Which other servers examples would you like ? Nginx and Apache ?

about SEO, i am making furthest investigation for examples and provide more explicit documentation.. for now .. i want to implement your great wiki "engine" in my documentation site and blog! @arnaudsm

oh i forgotten, i an testing in most rare servers, not only apache2 or nginx.. in fact i do not tested yet those "windoser like" flavours of servers :laughing:  that is so so well used


Access Keys are saved in cleartext

Currently the Access Key and Secret Access Key are saved under ~/.aws/config in clear text
Expected Behavior
The config file should be encrypted
Current Behavior
The config file is cleartext, containing sensitive information
Possible Solution
https://hackernoon.com/aws-credentials-stored-safer-m5673wd3

The credentials generated by this tool are temporary, which was part of the attraction to the STS pattern (1 hour lifetime).  Seeing as how they are so short lived, it doesn't seem like we're mitigating a very large risk by encrypting the credential file.
Let me noodle this for a bit, we might be able to make this an optional function, but making it easy to use for the consumers of the tool might be challenging.

@adamipv We partially reduced this risk by updating the file permissions to 0600 which gives access to only the file owner. https://github.com/Nike-Inc/gimme-aws-creds/pull/181
I agree with @Sector95  that because these are temporary credentials, in addition to the fact that the file permissions are restricted, there is a very narrow risk of exposure.
Looking at the article this looks like something that could easily be used in a standalone script to encrypt after running gimme-aws-creds. i.e gimme-aws-creds && encrypt. I like the unix philosophy of having a program do one thing, and one thing well. i.e retrieve credentials from okta. shrug
What do you think @adamipv  and @Sector95 ?

@adamipv file is controlled by AWS CLI, so it should be addressed to them.
You can mitigate it with using environment variables and not writing tokens to credentials file - write_aws_creds and output_format in gimme-aws-creds's config.


Add API Keys for fzf --listen

Summary
Provide optional hardened security for the FZF server. If the FZF_API_KEY environment variable is set, FZF would refuse any request that does not contain the specified API key. The API key can be any string, and should be the specified using the x-api-key header.
Background
fzf --listen currently accepts all requests, without any kind of authentication. This exposes the user to several threats:

A malicious script on the internet can bypass CORS and execute arbitrary commands on a running fzf instance by employing a DNS rebinding attack.
Non-browser applications have no concept of CORS, but often allow arbitrary POST requests to arbitrary URLs which can be manipulated by remote code.
Any non-containerized process running on the same machine, can force the fzf process to execute arbitrary shell commands, even if the other process is running as a different, non-privileged, user. This creates an opportunity for privilege escalation on multi-user machines.

See #3368 for more details.
Alternative Approaches

We can protect against the DNS rebinding vulnerability by blocking any request that doesn't specify localhost in the Host header. But this approach would only protect fzf against DNS rebinding, and it could also interfering with legitimate use cases where you want to bind another domain to the loopback interface.

The API key could be made mandatory, and randomly auto-generated if not explicitly specified. This approach would break all current usage of the --listen flag.

The API key could be specified with a new command line argument (e.g. --listen-key or --listen-api-key). I believe using an environment variable is cleaner, since it naturally propagates to child processes.

A different header name could be used. There are no standard headers for API authorization, but x-api-key is the closest thing we have to a popular choice for API keys (i.e. single-credential, directly-supplied secret keys for calling an API).

We could use the standard Authorization header, but it offers no standard scheme for API keys. The bearer scheme is meant for tokens (especially OAuth 2 tokens), while the Basic scheme requires two values (username and password) which makes it more complicated to use.

Points of note

Sending an invalid API key results in a 401 error.
Comparing API keys is done using subtle.ConstantTimeCompare() to prevent timing attacks. This requires converting the API key to a byte array, but it's well worth the price.
fzf is not returning any Content-Type header for error messages. I think it should return Content-Type: text/plain, but this is probably not this pull request's job to do that.

Thanks! We need to mention this variable on the man page. Also can you add a test case (in test_go.rb)? Let me know if you need any assistance.

Thanks, let me finish this up.

Merged, thanks!

Thank you!


Remove ie8 hacks

Coverage remained the same at 63.957% when pulling e18230b4c40b13402503aabf477d8d941be78eb0 on jimmywarting:patch-1 into 11dba41c9d9ea97b475c0dd6b13572c6c29d2635 on johndyer:master.

PR merged. Thanks


Can I verify a JWToken created by Auth0 ?

Should I implement my own verify_module ?
config.ex
config :guardian, Guardian,
    allowed_algos: ["HS256"],
   verify_module: BlackMamba.JWTHelpers,
    issuer: System.get_env("AUTH0_DOMAIN"),
  #  ttl: { 7, :days },
    verify_issuer: true,
  #  secret_key: System.get_env("GUARDIAN_SECRET") || raise("Missing GUARDIAN_SECRET"),
    secret_key: System.get_env("AUTH0_CLIENT_SECRET") || raise("Missing AUTH0_CLIENT_SECRET"),
    serializer: BlackMamba.GuardianSerializer

router.ex
pipeline :graphql do
     plug GraphqlLogger
     plug Guardian.Plug.VerifyHeader, realm: "Bearer", key: System.get_env("AUTH0_CLIENT_SECRET")
#   plug Guardian.Plug.EnsureAuthenticated
     plug Guardian.Plug.LoadResource
     plug BlackMamba.Context
 end

not sure what you're trying to achieve. Also, why use your client secret as a key in the verify header? That is not the secret that will be used, it's just a location in the assigns (allowing multiple sign ins at the same time). Whatever 'key' you use on your verify header module you use, you need to use that always - EnsureAuthenticated and LoadResource - need the same key. Usually the 'key' you'd use there would be something like 'default', 'admin'. It's just a label to tell guardian which login you're talking about. It's good for things like impersonation or temporary heightened security

I might be wrong but I think the idea is to use the token from auth0, rather than have guardian create it. Either way I am interested in this as well.
Right now I verify a correct response from auth0 and then have guardian create a separate token.
I added Auth0 login to the phoenix_guardian repo as an example. https://github.com/enilsen16/phoenix_guardian/tree/auth0

@enilsen16 I was about to write the same thing. The token was created by Auth0 and I do need to use their secret key to decode it, get the sub, split it and loading the resource from Token. I cannot make it work yet.

@alduro are you using @sntran's uberauth_auth0 package?

@enilsen16 ah no. Any sample to check ?

Here's the repo for the package: https://github.com/sntran/ueberauth_auth0
The last two commits in my auth0 branch here are adding it to phoenix guardian.

I just checked it out. The problem is I'm also interested in some other Guardian features like LoadResource based on sub payload. Well I dunno, maybe I can implement my own Plug.

I am using both(uberauth/guardian) and it seems to work just fine...

In order to use the auth0 as a token that you're going to trust as your applications token, I think you'd have to set your secret key to be the same signing secret that the auth0 token was signed with. At that point, when you receive the auth0 token you put it into the session/conn assigns the same way that the sign_in function does and it should all just work.
Just work might be a bit of a stretch though. Your token serializer will need to match whatever they put into the token, permissions likely won't work because I don't think that auto0 would have access to your bitmask and I'm not sure GuardianDb would work out of the box. For that to work it would need to have a jti specified.
Personally I like to put a boundary between my system and another. If I were using auth0 I would treat that like a login action where I received that token and then generated one of my own based on it. That's probably just me though ;)
You can use Guardian to decode the token from auth0 provided you know the signing secret.
Guardian.decode_and_verify(jwt, %{secret: auth0_secret})

Thanks guys ! I will check this out and let you know how it went before closing it I guess.

No luck. I really appreciate any code sample applying directions above.

@alduro is your project public? I don't actually use auth0 but if I could see some code it might help me identify what you're trying to do.

@hassox no. I will create an small gist for sharing.

Sorry, any clue ? @hassox

It was solved !
config :guardian, Guardian,
 11   allowed_algos: ["HS256"],
 10   verify_module: Guardian.JWT,
  9   issuer: System.get_env("AUTH0_DOMAIN"),
  8   verify_issuer: false,
  7   secret_key: System.get_env("AUTH0_CLIENT_SECRET") |> Base.url_decode64 |> elem(1),
  6   serializer: BlackMamba.GuardianSerializer

and in Serializer
def from_token("auth0|" <> id), do: {:ok, Repo.get(User, id)}


Release 2.0.0-rc1

What
Release 2.0.0-rc1
Why
https://github.com/stellar/stellar-disbursement-platform-backend/issues/245
Known limitations
[TODO or N/A]
Checklist
PR Structure

[ ] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR title and description are clear enough for anyone to review it.
[ ] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[ ] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[ ] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[ ] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[ ] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[ ] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[ ] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr246.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr246.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr246.previews.kube001.services.stellar-ops.com


[#noissue] code cleanup

Codecov Report

Merging #7587 (be1d8f9) into master (0cabe69) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #7587      +/-   ##
==========================================
+ Coverage   38.61%   38.63%   +0.01%
==========================================
  Files        3516     3517       +1
  Lines      100626   100634       +8
  Branches    12353    12349       -4
==========================================
+ Hits        38853    38876      +23
+ Misses      58769    58755      -14
+ Partials     3004     3003       -1

Impacted Files
Coverage Δ

...rp/pinpoint/bootstrap/plugin/test/ExpectedSql.java
0.00% <0.00%> (ø)

...inpoint/grpc/client/SocketIdClientInterceptor.java
0.00% <0.00%> (ø)

...pc/client/SupportCommandCodeClientInterceptor.java
0.00% <0.00%> (ø)

...int/grpc/client/interceptor/DiscardClientCall.java
85.96% <ø> (ø)

...point/test/plugin/shared/SharedProcessManager.java
0.00% <0.00%> (ø)

...avercorp/pinpoint/common/util/StringJoinUtils.java
63.15% <63.15%> (ø)

...m/navercorp/pinpoint/common/util/StringJoiner.java
65.38% <65.38%> (ø)

...vercorp/pinpoint/test/plugin/util/StringUtils.java
31.81% <77.77%> (+4.54%)
:arrow_up:

...point/collector/cluster/SupportedCommandUtils.java
80.00% <100.00%> (ø)

...com/navercorp/pinpoint/plugin/mongo/MongoUtil.java
50.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cabe69...be1d8f9. Read the comment docs.

Codecov Report

Merging #7587 (be1d8f9) into master (0cabe69) will increase coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #7587      +/-   ##
==========================================
+ Coverage   38.61%   38.63%   +0.01%
==========================================
  Files        3516     3517       +1
  Lines      100626   100634       +8
  Branches    12353    12349       -4
==========================================
+ Hits        38853    38876      +23
+ Misses      58769    58755      -14
+ Partials     3004     3003       -1

Impacted Files
Coverage Δ

...rp/pinpoint/bootstrap/plugin/test/ExpectedSql.java
0.00% <0.00%> (ø)

...inpoint/grpc/client/SocketIdClientInterceptor.java
0.00% <0.00%> (ø)

...pc/client/SupportCommandCodeClientInterceptor.java
0.00% <0.00%> (ø)

...int/grpc/client/interceptor/DiscardClientCall.java
85.96% <ø> (ø)

...point/test/plugin/shared/SharedProcessManager.java
0.00% <0.00%> (ø)

...avercorp/pinpoint/common/util/StringJoinUtils.java
63.15% <63.15%> (ø)

...m/navercorp/pinpoint/common/util/StringJoiner.java
65.38% <65.38%> (ø)

...vercorp/pinpoint/test/plugin/util/StringUtils.java
31.81% <77.77%> (+4.54%)
:arrow_up:

...point/collector/cluster/SupportedCommandUtils.java
80.00% <100.00%> (ø)

...com/navercorp/pinpoint/plugin/mongo/MongoUtil.java
50.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cabe69...be1d8f9. Read the comment docs.


(PDB-4271) query for fact expiration

Adds an "expires" field to the node response, that contains two embedded
fields: "facts" and "facts_updated"
If "facts" is true (the default), the node is subject to garbage
collection and expiration. If the value is set to false, the node is
excluded from the garbage collection procedure. If this value has been
explicitly set via a command, the facts_updated field will be a
timestamp representing when the field was set.

Test PASSed

CLA signed by all contributors.

Test PASSed

CLA signed by all contributors.

Test PASSed

Test PASSed


net: change net_time_t defined type.

Commit changes net_time_t to uint64_t and adjust related defines. The reason for this change is that in whole Zephyr time is fedined as unsigned integers.

@rlubos

Is that really a valid assumption? k_uptime_get()/k_uptime_ticks() for example both operate on signed int64_t.

That's correct but eg both PTP and IEEE drivers use uint as a representation of time. So defining the net time in int64_t is kind of incorrect.

I miss the information what problem are we trying to solve here, what was the issue with int64_t representation?

We actually can compare time between the Protocols mentioned above. Previously it wasn't the case since compared signed to unsigned in C. Plus we don't need to check any validity of type normal to unsigned when calling functions.

@pdgendt  this API is still experimental https://docs.zephyrproject.org/latest/develop/api/api_lifecycle.html#experimental So the above shouldn't apply.

Personally, I'm not quite convinced with this change. int64_t has capacity to store up to almost 300 years of timespan represented in ns (which seems more than enough) and by switching to uint64_t we're stripping the type from possibility to represent relative times in the past (negative values).
IMO if some user of net_time_t cannot handle negative values, it should be addressed in there, instead of changing the type globally.

Personally, I'm not quite convinced with this change. int64_t has capacity to store up to almost 300 years of timespan represented in ns (which seems more than enough) and by switching to uint64_t we're stripping the type from possibility to represent relative times in the past (negative values).
IMO if some user of net_time_t cannot handle negative values, it should be addressed in there, instead of changing the type globally.

I agree. There was lot of effort from @fgrandel to introduce this feature recently with some use cases in mind.
I think we need better reasoning than just ...whole Zephyr time is fedined as unsigned integers., so why do we need to change this, does something break if we do not change this, and more specifically what breaks if we introduce this change.

Closing due to gracefull solution already implemented.


Fix example meta charset to use name and content attribute names

Summary
The current example creates an attribute named charset when in HTML the attribute name should be content and charset belongs in another attribute named name.
Motivation
To be correct and give proper expectation that there is no special handling of the meta tag in this instance.
References
https://irclog.perlgeek.de/mojo/2017-04-23#i_14474559

Gasp, I thought to implement meta as a helper that supported the previous syntax only to find that meta might have an attribute named charset as seen in an example at w3schools.
Read:
https://www.w3schools.com/tags/tag_meta.asp


Implicitly discover doctests so we follow rules in conftest.py

Doctests are failing locally due to failure to skip tests that require fairseq. I'm not sure why this is working on GitHub CI, its possible fairseq is getting installed. This fix just uses automatic docstring discovery to run the tests, but I'm not sure why the old approach was used, so maybe we need a different approach to fixing this.
We also need to decide if we want these tests to be run on GitHub (if they aren't already).

Ok, I think for now the best approach is to restore the grep approach and update the list of files that we don't have to test.

We still need to add a comment to this code explaining the not-straightforward approach that's taken.

Right, feel free to add it and merge!
On Wed, 28 Apr 2021 at 09:35, Peter Plantinga @.***>
wrote:

We still need to add a comment to this code explaining the
not-straightforward approach that's taken.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/speechbrain/speechbrain/pull/685#issuecomment-828460526,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA2ZVVXCMUOCRM7OF4V6ETTLAFLZANCNFSM43PK7DVA
.


Babel setup

Babel setup
Check other open-source projects for inspiration

It might be a good idea to use a starter kit to get started quickly. Here are a few examples:
https://github.com/kriasoft/babel-starter-kit
https://github.com/krasimir/webpack-library-starter
https://github.com/babel/generator-babel-boilerplate
@theninja Feel free to suggest any others you might know about.

Babel and rollup setup done


Module not found: Error: Can't resolve 'path' in 'node_modules@nunomaduro\dd\dist'

I'm trying to import in my TypeScript file but I get that error.
import dd from '@nunomaduro/dd';

Seems to be using 'path' package, but is not listed in dependencies or peerDependencies
https://github.com/nunomaduro/dd/blob/3e45cd0cf62fb0343c5c86d3b2abe542677bcff6/src/concerns/findSourceCall.ts#L1
https://github.com/nunomaduro/dd/blob/3e45cd0cf62fb0343c5c86d3b2abe542677bcff6/package.json#L31-L33

I installed 'path' (npm i -D path) but I get this warning from Angular:
<EMAIL_ADDRESS>depends on 'path'.
CommonJS or AMD dependencies can cause optimization bailouts

Or this is not for client? 😅

This is node only.

I see.

Off topic question:
It can be used in a TypeScript script, with ts-node?
I tried to use in a direct script, but get some error too. (I'll check in a new issue when I get my PC,, but just asking).


Commit messages have unwanted characters.

The commits from aa35e2cea8bbb4f982f6658031bd386978ae539f to bad2494746d1adef0840c17dcfae832e641bb4cf have unwanted characters which may have come mistakenly while committing.

The way of writing this way is intended by the contributor. And I do not see any offending characters. They all are standard- ASCII even. What is wrong with these entries? Did you have any problems to handle them caused by their commit messages?

Oh, I thought this was not intentional and thought it had been done mistakenly. I saw the commit diffs and now it makes sense. Closing the issue.