[percy] Unsupported Percy CLI version, disabling snapshots is seen when using selenium-webdriver

I have a simple test that does the following...
...
const percySnapshot = require('@percy/selenium-webdriver')
...
it('should verify website title', async () => {
  driver.get(`${localhostUrl}?language=${lang}`)
  await percySnapshot(driver, 'Some Demo Homepage')
  const title = driver.getTitle()
  expect(title).to.equal('Some Title ')
})

I have followed the instructions here, https://docs.percy.io/docs/selenium-for-javascript , in regards to npm setup and such.
I am a little confused as to what is happening.
The tests run all ok ...
...
Tests finished
Killing mock server
...
[percy] stopping percy...
[percy] waiting for 0 snapshots to complete...
[percy] done.

👋🏼 Hey @SherBhachuOnFido thanks for the issue! When this is logged:
[percy] waiting for 0 snapshots to complete...

That usually means percySnapshot wasn't called in the test run. What does the test should verify website title log when tests run? Also, I think this would be a better test. Once percySnapshot is called, we're going to capture that exact page state (half loaded, not loaded, etc).
const percySnapshot = require('@percy/selenium-webdriver')

it('should verify website title', async () => {
  await driver.get(`${localhostUrl}?language=${lang}`)
  const title = await driver.getTitle()
  expect(title).to.equal('Some Title ')
  await percySnapshot(driver, 'Some Demo Homepage')
});

Also, I noticed there are two missing awaits in your example (await driver.get & await driver.getTitle). For example, this is in our example app: https://github.com/percy/example-percy-selenium-javascript/blob/master/tests/test.js#L30-L34 :D

As for the second comment, that's expected. Percy downloads a specific version of Chromium to do asset discovery in. This can be skipped by providing a path to your own browser executable: https://docs.percy.io/docs/skipping-asset-discovery-browser-download


LogEntry.log_create writes to read-only database

We are using a primary/replica database configuration in our production environment described like here: https://docs.djangoproject.com/en/4.0/topics/db/multi-db/
I have an issue where LogEntry is written to the read-only database. After some research I found the cause of this issue:
https://github.com/jazzband/django-auditlog/blob/master/auditlog/models.py#L70
By setting the database via .using() it omits the database router.
Anybody knows a solutions for this issue? (And why is the database set this way in de the code?)

We are having the same problem here.
I think I could just use self.create(**kwargs). And let the developer decide in which database he will write using the DATABASE_ROUTERS.
It sounds like a good idea?
I would like to know why the database is configured this way in the code.

Could this pull request be useful?
Pull Request 359

Fixed in https://github.com/jazzband/django-auditlog/commit/77ef852706ccfa8523f8de98e886fc9097e252d4


Create detail for tables in disease page

[x] Related diseases
[x] Phenotypes
[x] Drugs
[x] Bibliography

Done. Related diseases, Drugs and Bibliography are analogous to target page sections. Phenotypes is implemented as in the current webapp, but we may wish to revisit this.


Method to find Horizontal and Vertical Resolution

I'm trying to find the best way to calculate the scale factor that any given image needs to obtain the 300 DPI min requirement.
My current best way to do this is like this:
                int scaleFactor = 1;
                using (Bitmap sourceBitmap = new Bitmap(fileName))
                {
                    if (sourceBitmap.HorizontalResolution != 0 && sourceBitmap.VerticalResolution != 0)
                    {
                            // Do math to get scale factor based on Horizontal and Vertical Resolution
                            scaleFactor = mathResult;
                    }
               }

            using (var img = Pix.LoadFromFile(fileName))
            {
                    Pix preprocessedImg = img.Scale(scaleFactor, scaleFactor);

                    var page = engine.Process(preprocessedImg);

That works fine, and the Pix.Scale() often helps a good amount. It seems likely there's a better way to get Horizontal and Vertical Resolution other than loading a Bitmap from file.
So, next I tried this:
            using (Bitmap sourceBitmap = (Bitmap)Bitmap.FromFile(fileName))
            {
                int scaleFactor = mathResult from Horizontal and Vertical Resolution.
                using (Pix img = PixConverter.ToPix(sourceBitmap))
                {
                    Pix preprocessedImg = img.Scale(scaleFactor, scaleFactor);
                    using (var page = engine.Process(preprocessedImg))
                    {

Much to my surprise, the PixConverter.ToPix approach was both slower and had lower OCR precision.
Does anyone have a suggestion to get the Horizontal and Vertical Resolution values without creating a Bitmap object just for that?
Thank you.

If you want a good .NET image processing library then use this --> https://github.com/Sicos1977/ImageProcessor
It also avoids all the downsides in the System.Drawing namespace

Looks like a nice solution, thanks for pointing it out Less.
On 7 Jul 2016 10:19 a.m., "Kees"<EMAIL_ADDRESS>wrote:

If you want a good .NET image processing library then use this -->
https://github.com/Sicos1977/ImageProcessor
It also avoids all the downsides in the System.Drawing namespace
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/charlesw/tesseract/issues/278#issuecomment-231013299,
or mute the thread
https://github.com/notifications/unsubscribe/AAPzyKPhJmCQp0I13UTdUjBvgUloi-SUks5qTLaDgaJpZM4I2nWl
.


Extension doesn't play well with Logger++

I always use the Logger++ extension to see what goes out from Burp.
Lately I had to install CPH to "fix" some requests that the Scanner was generating. After enabling CPH I noticed that Logger++ is not showing the requests generated by the scanner in the log anymore.
Is there a way for both extensions to play well together?

Hi, @andresriancho! (w3af! :D)
That's weird, I'll mess around with it and see what's going on.

@andresriancho, I've been unable to recreate this so far. I had both CPH and Logger++ going, in different order (in the Extender tab), and performing request modifications. Still saw logs popping up for Scanner.
Can you confirm that only these 2 extensions are loaded, and tell me any other details that might help? Perhaps try it after resetting Burp to default settings?


Unresponsive Column Height

Description
It seems like the text in the column doesn't have the appropriate height which cause the column looks odd.
Steps To Reproduce

Open Any Directory (Download, Desktop, C:, D:, etc)
See the column
See error

Expected behavior
The text in should be aligned properly.
Files Version
v<IP_ADDRESS>
Windows Version
Windows 11 21H2 22000.194
Relevant Assets

This was a deliberate design choice to provide a separation between the toolbar above the header.
Fyi @itsmichaelwest

Ahh I see, however tbh I'm still not used with the design 😂. But I really appreciate it!

Ahh I see, however tbh I'm still not used with the design 😂. But I really appreciate it!

Good feedback! I think this is better than the alternative issue of having there be too much information stacked on top of each other, but we can definitely gather some feedback on this.


Remove node@13 add node@14

Pull Request Test Coverage Report for Build 354

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 349:
0.0%

Covered Lines:
29

Relevant Lines:
29

💛  - Coveralls


[HUDI-3963][Claim RFC number 53] Use Lock-Free Message Queue Improving Hoodie Writing Efficiency.

https://issues.apache.org/jira/browse/HUDI-3963
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Thanks @nsivabalan :)


Android SDK

Do we have this feature in mobile android sdk. If yes please guide me to pull data

Hi Natraj21, thanks for your interest in the project. This project is a Javascript map for visualizing the COVID-19 cases worldwide. Which feature are you referring to?

COVID-19 tracker implementation in android HERE-SDK

Hi Natraj, let me take that as a feature request.  At the moment we don't have plans for an Android version, but if you are interested please go ahead and implement one, we'd love to see what you come up with!


nmap scan logs a python error

Error:
INFO:homeassistant.components.device_tracker.nmap_tracker:Scanning
Exception ignored in: <module 'threading' from '/usr/lib/python3.4/threading.py'>
Traceback (most recent call last):
File "/usr/lib/python3.4/threading.py", line 1353, in _after_fork
thread._stop()
TypeError: 'Event' object is not callable
INFO:homeassistant.components.device_tracker.nmap_tracker:nmap scan successful
My config:
device_tracker:
platform: nmap_tracker
hosts: <IP_ADDRESS>/24
Using a git checkout from this morning. Let me know if you need more info.

The google groups has this relevant discussion: https://groups.google.com/forum/#!msg/home-assistant-dev/hKcH32MzQvs/kF98gmFCIUQJ
It seems that we need python-libnmap to release an update.

python-libnmap is no longer the dependency for nmap tracking.


The NPM script 'dev' exited without indicating that the Vue CLI was listening for requests;

This is generated after vs2019. Net core 3.0 is compiled. Take a look at the details? It's a little different from the "angular cli" next door。

cnpm Not installed


Feat/entry edit params on entry change

Hello team,
I was trying to make the Live Preview feature work with our Vue Storefront application. However, due to its architecture, I was unable to succeed with the task by following either of the paths specified in the documentation.
The path we should follow with Vue Storefront is a client-side path. Everything related to updating the content of our website happens on that side. However, there is a caveat: we fetch content from Contentstack by sending a request to our API middleware, which is on the server-side. The schema looks like this:

Vue.js component: Send axios request to the API Middleware, including the desired params => API Middleware: Create the Contentstack client and request data from Contentstack

In order to make the Live Preview work, we need to pass the entryEditParams (that is, the hash) as a param while sending a request to our API middleware.
The request needs to be sent from within the onEntryChange callback:
  onEntryChange((entryEditParams) => {
    if (entryEditParams) {
      search({
        url: id,
        entryEditParams: {
          ...entryEditParams,
          live_preview: entryEditParams.hash,
        }
      })
    }
  });

Currently, the callback for onEntryChange receives no arguments. This PR changes that. I've already discussed the solution with Chris Jennings but I'm open to further discussion.

Hello @Deepak-Kharah,
As requested, I've created a new PR pointing to the hotfix branch.
https://github.com/contentstack/live-preview-sdk/pull/14
Hereby I'm closing this one.


Materials related to SLEAP HPC example for software skills course

@adamltyson on this branch I am developing the materials for the SLEAP usage on HPC.
You can find the current draft of the presentation in SLEAP/presentation. It's made with quarto + revelajs, the source file is presentation.qmd , while the rendered presentation itself is available under presentation.html as a single page, for your viewing convenience.
My idea is to embed such an HTML page on the software-skills website, for the record. On the day of the course, I can use the same material rendered in "slides" format.
FYI, the presentation is not yet complete. I am planning to add an example of an array job, and maybe an example of running a Python script (if I make it in time).
Apart from the presentation this branch also contains:

some example scripts for running SLEAP commands using SLURM (in SLEAP/scripts). These are subject to change, as the presentation develops.
A SLEAP/HowTo.md guide, which is meant to represent a detailed user guide for the SLEAP module on the HPC. This is still incomplete, but I plan to finish it tomorrow. In the near future I intend to make a similar guide for the DeepLabCut module as well.

I am opening this up for review so you can monitor my progress if you wish to.

Warning
Apologies for the many many commit messages named "update SLEAP presentation"

Ok, I will merge now because content-wise it is complete.

the "How-To" guide has been expanded considerably
I've updated the example scripts and the presentation to also include running Python scripts and array jobs

If I find typos, or want to do small fixes ahead of the course, I will open a separate PR


kubectl-shell container don't stay up

Rancher versions:
rancher/server: rancher/server:v2.0-alpha6
rancher/agent: rancher/agent:v2.0-alpha4
Infrastructure Stack versions:
healthcheck: N/A
ipsec: N/A
network-services: N/A
scheduler: N/A
kubernetes (if applicable): N/A
Docker version: (docker version,docker info preferred)
17.03.2-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
4.9.45-rancher
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Bare-metal
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single node external DB
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
N/A (it's K8s)
Steps to Reproduce:
Simply bootstrap rancher/server, add host agent on the same host (with the correct CATTLE_AGENT_IP set)
Results:
kubectl-shell container don't stay up with error:
error on container (1i1341): an error on the server ("") has prevented the request from succeding (get namespace cattle-system)

External DB isn't working in v2.0.0-alpha6, which is the cause of your issue.

The preview tag has been updated to v2.0.0-alpha7 and now has support for external DB.
There is no support for upgrades between preview versions, so you'll need to do a fresh install.


sanitycheck should distinguish compile errors from link errors

We have several CI cases in which we get link errors for code size growth because we enable something like DEBUG, or build with a different toolchain.  It would be nice to distinguish these errors (build_error in sanity check) from actual compile errors.

You'd have to have Make pass a different return value if the build fails due to link in order for this to be possible, as the parallel build is controlled by Make and not sanitycheck.

I do not think this will work, you might also have link errors due to some missing symbols and other reasons, trying to cover all cases is just going to complicate sanitycheck without any value. This issue is not that common and should be dealt with using filters instead.

You'd have to have Make pass a different return value if the build fails due to link in order for this to be possible

The Makefile generated by sanitycheck could have three targets: build, link, run. Then sanitycheck could call each one in sequence. Of course this depends on CMake's ability to generate Makefiles or ninja files with such separate targets in the first place. It's probably the case already but with unpredictable target names.

I do not think this is worth the effort

I would not embark on such an adventure myself either; the value seems low to me too. However there may be a solution that doesn't increase complexity and if yes then I would be happy to review it if someone else cares deeply enough for some reason(s).


Reverse size property in the map

When something like energy is used as a property for dot size in the map, the most interesting points are the one with lowest energy, but they end up being the smallest.
We could provide an option to use -<property> instead of <property> for the size to support this use case.

I think we can use a "scale" option, that describes the relation between
the property and the radius. we could have "sqrt" (that should be default),
linear, log, -sqrt, etc.
Similarly, one should also be able to adjust the range.
On Tue, 23 Jun 2020 at 16:53, Guillaume Fraux<EMAIL_ADDRESS>wrote:

When something like energy is used as a property for dot size in the map,
the most interesting points are the one with lowest energy, but they end up
being the smallest.
We could provide an option to use - instead of  for
the size to support this use case.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cosmo-epfl/chemiscope/issues/52, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZY4CAYRDBKYGVV3IGTRYC6XHANCNFSM4OFX4S6Q
.

Similarly, one should also be able to adjust the range.

Do you means, setting min & max radius value?

I'm thinking to have size considered as an axis. So it's mapped between the
property range and sz_min -> sz_max, using a mapping function, very much
like an axis indeed.
On Wed, 24 Jun 2020 at 16:44, Guillaume Fraux<EMAIL_ADDRESS>wrote:

Similarly, one should also be able to adjust the range.
Do you means, setting min & max radius value?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cosmo-epfl/chemiscope/issues/52#issuecomment-648864918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZ2FGQ3VD6FVEJH3FFLRYIGLXANCNFSM4OFX4S6Q
.

Would that mean we also provide different mapping (sqrt, -x, …) for the x/y/z/color axis too?

If it's easy to achieve in plotly, I don't see why not. Wouldn't lose hours
otherwise
On Thu, 25 Jun 2020 at 16:14, Guillaume Fraux<EMAIL_ADDRESS>wrote:

Would that mean we also provide different mapping (sqrt, -x, …) for the
x/y/z/color axis too?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cosmo-epfl/chemiscope/issues/52#issuecomment-649571510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIREZ6Q25TUVNFGIRPXYATRYNLV3ANCNFSM4OFX4S6Q
.


No removeEventListener?

Hi,
I'm just wondering, aren't event listeners removed?
Thanks

I think that's because addEventListener is called in the constructor, and the handler is part of the object. I guess that does not cause circular references because there is only one reference (the element).
Can someone confirm?


Alternative version of #389 to see if tests are passing.

I think the remaining failure are due to playwrite changing from sending GET to HEAD to see if the server is up (see https://github.com/microsoft/playwright/issues/28893, so I'm going to merge as is).


[Question] How to enter in our own Google Maps API key ?

Expected Behavior
Actual Behavior
Steps to Reproduce
Other Information
OS:
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Depends on what version you are running.
Maybe -k
Maybe config
or changing the code

Please fill out all the required information (such as version of the bot you are running).


Match data.json location to Udon

This is the URL that the system is trying to query for data.json:
https://github.com/Mattshark89/OpenFlight-VRC/blob/683a0b093c24d67aceeb563928f3b7cf3a87f549/Packages/com.mattshark.openflight/Runtime/Scripts/Detection/AvatarListLoader.cs#L12-L13
This is the URL I was actually able to find data.json at: https://mattshark89.github.io/OpenFlight-VRC/data.json
This PR relocates the file to match where the Udon script is looking, my test shows up at https://kitl.pw/OpenFlight-VRC/Assets/OpenFlight-VRC/data.json
Grain of salt, I've not tested this PR in-game myself yet, because I didn't feel like throwing together a world to upload to test this.

This is actually just purely an issue because I never updated the source code to reference the root data.json location that was introduced. The prefab has the URL set appropriately

I Would suggest just changing this PR to defining the VRCUrl to the new correct one in the source code. Alongside that, the action changes suggested would break all existing worlds since it wouldnt be putting the data,json to the root of the website anymore. As for not using the copy-action and instead just using bash, im split on this. yes it would probably make the action run faster, but im not sure it would error the action if the copy fails anymore

sorry for slow reply, and for not realizing that there was a different place to specify the url!
would it be acceptable to put the json in both locations, just in case?
errors should still register, but i'd be willing to make sure of that, once i have time again.

you technically could, but I don't really see the point of doing this since no live systems right now should be using that URL
You probably have a better idea of how this prefab has spread than I do, so I'll take your word for it. I'm just used to seeing older versions of a prefab floating around worlds, and was thus advocating for making all URLs that were ever checked for the data json available on the website.

In that case, these is no point changing the copy action, since I only switched away because of needing to create the parent directory (and even then I suppose I could have split that into a step creating the parent directory and then using the copy action), so all this PR now does is edit the URL in udon source.
... I should probably actually open the repo from within unity so that the SerializedUdonAsset updates if needed, and commit that as well, shouldn't I.

@kitlith any update on this?
Apologies for the delay. I've not had a ton of extra time the past couple weeks, and this took a lower priority than anything else once I realized that what I had noticed wasn't actually indicating that things were broken.


Package Exports Need Docstrings

Here is a list of items exported by the package which do not currently have docstrings:
DiscreteUDE
MultiUDE
gradient_descent
BFGS!
LotkaVolterra
plot_leave_future_out_cv
func
LorenzLotkaVolterra
plot_covariates
vectorfield2d
nullclines2d
vectorfield_and_nullclines
gradient_descent
NUTS!
SGLD
predict

Just to make sure, they have to show up on a file in the docs within a @docs block?

To clarify, per our meeting yesterday, if we want all exported items from the package to have docstring descriptions, these items need both docstrings within the code and then also references within an @docs block.

The docstrings of the functions in Optimizers.jl were commented so they were not being read. I took the comment hash out of them and other functions in https://github.com/Jack-H-Buckner/UniversalDiffEq.jl/commit/af9b0673072a077469d6649b9011b1e37152d5df


Apache Pulsar 2.7.2 blog page

This is the PR to add a blog page for the 2.7.2 relase

@Anonymitaet I will ping you when I am done

@eolivelli OK

for reference, this is the query to get the contributors:
curl https://api.github.com/repos/apache/pulsar/compare/v2.7.1...v2.7.2
| jq '[.commits[].commit.author.name] | unique'

for reference, this is the query to get the contributors:
curl https://api.github.com/repos/apache/pulsar/compare/v2.7.1...v2.7.2
| jq '[.commits[].commit.author.name] | unique'

thank you @Anonymitaet
let's merge this patch only after the official announcement of the release


Regenerate zerotier-one client

fix #4 and #7
is progenitor still the right thing? looks ok.
for the zerotier-one service:

[ ] get it building with new rust or whatever
[ ] use the up to date spec
[ ] get it building in gh action
[ ] could use a test similar to the test in the spec repo. there is an unofficial(?) testcontainers rust
[ ] get it pushed to crates.io

I'm fine with moving this to be an internal dependency of zeronsd and archiving this repo. According to crates.io the only other downstream consumers are abandoned projects of ours so it's probably best to similarly mark them as archived until/unless we decide to resume working on them.

ztui dependant is under erikh's github account. so it's just zeronsd


Incompatible daemon

I've just started using mvn and noticed from the logs that, there are incompatible daemons due to the javaHome
$ mvnd --version
Sep 15, 2020 10:23:33 AM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Idle daemon 23a8041a-705b-48d6-8fd7-4b01b7f49ddf does not match the desired criteria: Java home is different.
Wanted: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt, options=[]
Actual: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre, options=[], mavenHome=/home/alext/.sdkman/candidates/mvnd/0.4.0, pid=153885, address=36049, idleTimeout=10800000, locale=en-US, state=Idle, lastIdle=1600129199872, lastBusy=1600129170749uid=23a8041a-705b-48d6-8fd7-4b01b7f49ddf

[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Idle daemon fa3a910f-f224-4242-b56e-98b112f851a3 does not match the desired criteria: Java home is different.
Wanted: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt, options=[]
Actual: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre, options=[], mavenHome=/home/alext/.sdkman/candidates/mvnd/0.4.0, pid=150998, address=33263, idleTimeout=10800000, locale=en-US, state=Idle, lastIdle=1600128961673, lastBusy=1600128960395uid=fa3a910f-f224-4242-b56e-98b112f851a3

[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Idle daemon 96a3257f-b375-47eb-bfb8-71273e43f6ac does not match the desired criteria: Java home is different.
Wanted: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt, options=[]
Actual: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre, options=[], mavenHome=/home/alext/.sdkman/candidates/mvnd/0.4.0, pid=151587, address=35369, idleTimeout=10800000, locale=en-US, state=Idle, lastIdle=1600129091986, lastBusy=1600129022672uid=96a3257f-b375-47eb-bfb8-71273e43f6ac

[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Idle daemon 1fb27912-2bca-4f46-93cd-c43da854b9e1 does not match the desired criteria: Java home is different.
Wanted: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt, options=[]
Actual: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre, options=[], mavenHome=/home/alext/.sdkman/candidates/mvnd/0.4.0, pid=154243, address=38191, idleTimeout=10800000, locale=en-US, state=Idle, lastIdle=1600129327995, lastBusy=1600129327949uid=1fb27912-2bca-4f46-93cd-c43da854b9e1

[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Idle daemon 78630163-9886-48a3-bd22-b58e06bd3ab4 does not match the desired criteria: Java home is different.
Wanted: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt, options=[]
Actual: javaHome=/home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre, options=[], mavenHome=/home/alext/.sdkman/candidates/mvnd/0.4.0, pid=154325, address=34881, idleTimeout=10800000, locale=en-US, state=Idle, lastIdle=1600129407112, lastBusy=1600129378438uid=78630163-9886-48a3-bd22-b58e06bd3ab4

[main] INFO org.jboss.fuse.mvnd.common.DaemonRegistry - Removing 0 daemon stop events from registry
[main] INFO org.jboss.fuse.mvnd.client.DaemonConnector - Starting a Maven Daemon, 1 busy and 5 incompatible Daemons could not be reused, use --status for details
Maven Daemon 0.0.4-linux-amd64 (native)
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/alext/.sdkman/candidates/mvnd/0.4.0
Java version: 1.8.0_265, vendor: AdoptOpenJDK, runtime: /home/alext/.sdkman/candidates/java/8.0.265.hs-adpt/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-47-generic", arch: "amd64", family: "unix"

It sounds like every time I ran mvnd, there is a new daemon created but incompatible to be reused?

I was able to reproduce when I had 8.0.265.hs-adpt as sdkman java default.
On the contrary, I was not able reproduce when I had 14.0.2.j9-adpt as a default.
Let me investigate more.

This seems to be caused by the fact that with 8.0.265.hs-adpt, JAVA_HOME is effectively set to ~/.sdkman/candidates/java/8.0.265.hs-adpt but when running an app through $JAVA_HOME/bin/java System.getProperty("java.home") returns ~/.sdkman/candidates/java/8.0.265.hs-adpt/jre.
mvnd client relies on JAVA_HOME but mvnd server relies on System.getProperty("java.home")
Earlier, we had some code in place that was passing the value of JAVA_HOME to the server, but I removed it as superfluous. Now I know why it was there :)

Fixed via https://github.com/mvndaemon/mvnd/pull/66

Fixed in the freshly released version 0.0.5


Instanced Scripts

Since i am not always up on the functions... let me know if i have just re-invented the wheel :)
I am also sure this could be done cleaner.. by someone with a better grip on the core.
But the changes allow you to instance scripts and start and stop them from your main script.
The instances will not run unless you add them, and can be aborted to stop.
The below script is an example of the Main script creating clone and starting and stopping them.
I have tried this with multiple ped doing different animations.
public class MainScript : Script
{
	public MainScript()
	{
		Tick += new EventHandler(OnTick);

		Interval = 1000;
	}

	private static Clone cloneA = null;
	private static Clone cloneB = null;

	private void OnTick(object sender, EventArgs e)
	{
		if (e.KeyCode == Keys.A)
		{
			if (cloneA == null)
			{
				cloneA = new Clone();

				MainScript.RegisterInstance(cloneA);
			}
			else
			{
				cloneA.Abort();

				cloneA = null;
			}
		}
		else if (e.KeyCode == Keys.B)
		{
			if (cloneB == null)
			{
				cloneB = new Clone();

				cloneB.Aborted += new EventHandler(CloneAbort);

				MainScript.RegisterInstance(cloneA);
			}
			else
			{
				cloneB.Abort();
			}
		}
	}

	private static void CloneAbort(object sender, EventArgs e)
	{
		if (cloneB != null)
		{
			cloneB = null;
		}
	}
}

public class Clone : ScriptInstance
{
	private static Ped clone = null;

	public Clone()
	{
		Tick += new EventHandler(OnTick);

		Interval = 1000;
	}

	private void OnTick(object sender, EventArgs e)
	{
		if (clone == null)
		{
			clone = World.CreatePed(new Model(PedHash.Agent14), Game.Player.Character.Position.Around(3f));
		}
	}

	private void Shutdown(object sender, EventArgs e)
	{
		if (clone != null)
		{
			clone.Delete();
		}
	}
}

I am yet to test this long term.
I only posted it so its out here to be discussed / refined.

I'm unsure on what this is doing, but it seems like to goes some way (albeit indirectly) to address #545

I pushed a new Branch.
The new Branch uses the base system better and provided error / console output.
It also has working "ScriptInstance.Wait(int ms)" #545

You can also create additional commits and push them, and you can directly update the pull request. Remember that.

I thought making a new branch would be simpler when viewing the changes in comparison.

But you can view changes per diff when you'd like to view, so you could add some commits and push the branch to update the PR. If the branch gets too confusing, you should make a new branch, though.

Moved to issues/659


Tree: Support option to expand on twistie click only

@jrieken Option is expandOnlyOnTwistieClick.

Verification: please code review.

Also verified the functionality in Problems view


⚠ ClamAV has degraded performance

In 2c24816, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 242 ms

Resolved: ClamAV performance has improved in 5930980.


Removing nft version in the build libs

⚠ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠
What kind of change does this PR introduce?

This PR will remove the double build libs (with or without nft extension). Because an issue with aframe image tracking this will be done only for threex and ar.js namespace.
Can it be referenced to an Issue? If so what is the issue # ?
see #402
How can we test it?

This still a WIP.
Summary

Does this PR introduce a breaking change?
For threex code if you want to use nft markers, you will import the ar-threex.js build lib instead of ar-threex-nft.js. That's all.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested on desktop Ubuntu 20.04.
Other information

As said in issue #402 the aframe nft example are not working correctly. I'm trying to catch the bug. i tested this commit 841be3ddc04daa62a1deb69d9f269c15460fb3af and the examples were working. I will continue this cehcking until i will found the bug.

version AR.js 3.3.3-es6-beta-03 seems fine i tested also the commit 604d87992446f60e09d7a8f6859031e15f87ff1d and it's fine.

worker can't load and continue loading resources with this commit 814435d3c3d25342fd109960dd814b76ef1005b4 So someting wrong when adding the event listener or initializig the arContext.

from twitter: https://twitter.com/githubstatus/status/1504526048591073293?s=20 seems some problems with github action

Now the action script run successfully the test script!

The README file need to be updated about which lib files to use for the different namespaces and nft or if location based or not. Will do this as well.

@nickw1 i will merge this as it will fix some important bugs and add prettier to format the code. When it will be merged we need to test if formatting works when every commit is created. We need also to format code after this PR. Prettier will format the code only .js files for now. We can include also other types (.css html md) but we can do in another step. Probably we can change the prettier configuration, to format the code in a better way, if you have some suggestions let me know.

@kalwalt ok looks good. No suggestions just yet but will see what results the code formatting produces.

I think we need to update also the AR-js-docs because are not updated with the latest changes.


Proxy page has no login "Looking for something else? Go to the previous version"

This may not be an issue as such, and might just be down to me misunderstanding the initialisation parameters, but I can't get the proxy page to return anything other than this screen. I can't login here to have the cookies retrieved.
Service host: alexa.amazon.com.au
Page: amazon.com.au
Is this a known issue?
I am using 5.0.25.
Thanks!

Not yet. Thanks for reporting. What happens when you scan and log in via the app? I presume the page should then automatically refresh and the cookie should be picked up.

Unfortunately not, the qr is just a link to "https://alexa.amazon.com/spa/index.html#v2/home", and is not associated with the page request.
https://alexa.amazon.com/spa/index.html
Redirects to a login page as expected. But I can't get to this page from the proxy to perform the login which can then (I assume) capture the cookie.

Thank you, got it.
Could someone with a AU service host confirm the problem (backup your cookie file first so you can go back to being logged in)?

The same on amazon.com. No chance to log in.

Alright. having the same problem now as well. Should be just a redirect/or different landing page url, I will debug it tonight.

I haven't delved much into alexa-remote2 as of yet, but as a quick personal hack...
alexa-cookie2/lib/proxy.js
Setting Line 138 to... _options.baseAmazonPag = 'amazon.com.au/spa/index.html'
Gets past the issue. Don't know about the intermediary layers of how this all comes together.

Yes 👍, I will add a PR on alexa-cookie to add /spa/index.html to the base url. This lib is used in alexa-remote which is used in applestrudel.

Gotcha! I should've raised the issue there, but posted on this repository before I bothered to look into it properly. Laziness I'm afraid, hence the want to automate in the first place :D

@gregorykau
Does the change you provided work? It throws an error for me.
https://alexa.amazon.com/spa/index.html/
HTTP ERROR 404
I think the problem is in the "/" at the end but I can't get rid of it. Are you able to send your alexa-cookie2/lib/proxy.js file? Because in mine in the given line there is something completely different.

It's not that easy. I hacked in the /spa/index.html appendix into the cookie library but then the proxy, unlike when opening it in the browser directly, gets a cloudfront error back.

@gregorykau Does the change you provided work? It throws an error for me.
https://alexa.amazon.com/spa/index.html/ HTTP ERROR 404
I think the problem is in the "/" at the end but I can't get rid of it. Are you able to send your alexa-cookie2/lib/proxy.js file? Because in mine in the given line there is something completely different.

This is working for me currently.
"version": "4.1.3",
alexa-cookie2\lib\proxy.js Starting at line 137
    let proxyCookies = '';

    _options.baseAmazonPag = 'amazon.com.au/spa/index.html';

    // proxy middleware options
    const optionsAlexa = {

It is not working for me :(

Here's a workaround that has always worked for me so far:
1.) Clear all your cookies from alexa.amazon.com
2.) Restart node-red so you get the open http://your-hostname:3456 message
3.) Open a new tab and go to https://alexa.amazon.com/spa/index.html -> login with your credentials
4.) Open a new tab and open the link that node-red shows -> If you get the page shown as below click on the "Looking for something else?" link in the top left.
5.) Login happens automatically, cookie is fetched and once you see http://your-hostname:3456/cookie-success in the URL bar you're all set and can go back to node red.

Can noone provide me with a fukll debug log of that? Normally  The / call on the proxy port should directly forward to the Login mask from amazon and not to that alexa.amazon.de page, thats why I would like to understand what happens here

Email sent. Thank you!

Thanks for your work!  I've been working on it for a while but nothing changes.  Which flavor of the node-red-alexa should I be working with?
TIA Doc

Thanks for your work! I've been working on it for a while but nothing changes. Which flavor of the node-red-alexa should I be working with? TIA Doc

https://github.com/Apollon77/alexa-remote and subsequently this uses https://github.com/Apollon77/alexa-cookie.


Request to customize HTTTRoute default settings

Describe the feature request
As we have dozens of micro services in the same kube cluster, to have a unified and common configuration of VirtualService, is there any way that we can specify or customize some HTTTRoute default settings, like route level timeout setting, and also http match ignoreUriCase setting.
virtualService->HTTPRoute->timeout
https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRoute
virtualService->HTTPMatchRequest->ignoreUriCase
https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPMatchRequest
We would like to:

Set route level timeout 30s as the default value for whole Istio, and also be able to overwrite the value in a specific VirtualService definition.
Set ignoreUriCase to be true for whole Istio, and also be able to overwrite the behavior in a specific VirtualService definition.

In this way, we don't need to specify these settings in each VirtualService, and it is also easier to maintain from operation aspect.
I am aware that ignoreUriCase can only support exact and prefix URI matches, it would be still preferred to set at the istio level.
Thanks.
Describe alternatives you've considered
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Additional context

cc @linsun @GregHanson @nrjpoddar

Thanks @wangmeng!  We are currently working on an RFC for adjusting timeout globally, perhaps we can add ignoreUriCase in there as well.
@GregHanson thoughts?

For the backgroud info about regex & v2 API deprecation. Thanks.
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/route/route_components.proto.html?highlight=case_sensitive
regex
This field has been deprecated in favor of safe_regex as it is not safe for use with untrusted input in all cases.

https://www.envoyproxy.io/docs/envoy/latest/api/api_supported_versions
    v2 xDS API (deprecated, end-of-life EOY 2020). This API will not accept new features after the end of Q1 2020.

    v3 xDS API (active, end-of-life EOY 2021). Envoy developers and operators are encouraged to be actively adopting and working with v3 xDS.

@linsun

We have a bunch of issues around defaults, lets consolidate into https://github.com/istio/istio/issues/6861 to clean things up. Please also see https://docs.google.com/document/d/1hY-ShGY6sgwWUw0NGLvsDWXWm3wNLvhM4HHuRjFzRT0/ which is a design doc for this being actively worked on.


vmq-admin usage output should include vernemq version number

VerneMQ Version: 1.5.0

vmq-admin output shows:
Usage: vmq-admin <sub-command>

Administrate the cluster.

Sub-commands:
  node        Manage this node
  cluster     Manage this node's cluster membership
  session     Retrieve session information
  plugin      Manage plugin system
  listener    Manage listener interfaces
  metrics     Retrieve System Metrics
  api-key     Manage API keys for the HTTP management interface
  trace       Trace various aspects of VerneMQ
Use --help after a sub-command for more details.

I was experimenting with various versions and containers and it's not that easy from the command line to figure out which version is running. So adding the version number to the output of the above command would make life little bit easier, like:
VerneMQ 1.5.0
Usage: vmq-admin <sub-command>

Administrate the cluster.

Sub-commands:
  node        Manage this node
  cluster     Manage this node's cluster membership
  session     Retrieve session information
  plugin      Manage plugin system
  listener    Manage listener interfaces
  metrics     Retrieve System Metrics
  api-key     Manage API keys for the HTTP management interface
  trace       Trace various aspects of VerneMQ
Use --help after a sub-command for more details.

It's in vernemq version - arguably it would be helpful to include it in vmq-admin as well

Closing for now, as vernemq version already serves this purpose.

Closing for now, as vernemq version already serves this purpose.

By this , still not able to see version .....

@vijapandey hm, I think you should see a version, even with self-compiled approach.
What version do you try to compile? (if that's not recursively impossible to answer :)
➜  vernemq git:(master) ✗ _build/default/rel/vernemq/bin/vernemq version
<IP_ADDRESS>-2-ge33f7ab

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.


Security issue: outdated cryptography is used

You're using elliptic, which has long been unmaintained, and has a few cases where it produces invalid outputs, which means in blockchain context "users lose money".
It is advised to replace it with audited @noble/curves.

Thanks for the advice. I'll try to migration.

done it #358

not done. you didnt remove elliptic

finaly #359


v1.7.2 planning

I'll release v1.7.2 soon, right after bumping up the dependencies for nerdctl-full.
cc @containerd/nerdctl-maintainers

LGTM

LGTM

https://github.com/containerd/nerdctl/releases/tag/v1.7.2


$timeout and $interval do not support function which binds to a 'this' value

Assume that we have a class named Test
 function Test(val) {
        this.v = val;
        this.get = function(v2) {
            return (this.v++) + v2;
        }
    }

We get a new instance of class Test and execute its method 'get',we get values from the 'this' reference.
var ins = new Test(5);
    console.log(ins.get(2));//7
    console.log(ins.get(2));//8
    console.log(ins.get(2));//9

But , if I use the $timeout service to execute the method asynchronously.
The 'this' value is deprecated,null is passed to function as 'this'.See a part of $timeout service source code  below.
timeoutId = $browser.defer(function() {
                    try {
                        deferred.resolve(fn.apply(null, args));//null is passed to function as this
                    } catch (e) {
                        deferred.reject(e);
                        $exceptionHandler(e);
                    } finally {
                        delete deferreds[promise.$$timeoutId];
                    }
                    if (!skipApply) $rootScope.$apply();
                }, delay);

I am a newbie for angularjs.
I think supporting function which binds to a certain 'this' value is useful in some scenario.
If this idea is rejected by the core dev team ,I want to know the reasons,thank you .
If this idea is accepted,I will creat a branch to accomplish this idea for $timeout and $interval.
My mentality of codeing is as below.
// Usage
// if you want to specify a 'this' value for function
// wrap function and 'this' in a array

$timeout([ins.get, ins], 3000, true, 2).then(function(result) {
    console.log(result);
});
// Service

function timeout(fn, delay, invokeApply) {
	// if you pass a array as fn
	// consider the fn[0] as function ,fn[1] as 'this'
	// if fn is not a array,this branch will not be executed
	// even if the users don't know the change of this service
	// It dosen't cause compatibility problem
        // They can only pass a function as the first parameter as usual after the code has changed.
    if (angular.isArray(fn)) {
        var thisArg = fn[1];
        fn = fn[0];
    }
    // other codes
    deferred.resolve(fn.apply(thisArg||null, args));//if thisArg is defined ,use it.otherwise use null
    // other codes
}

What you want is https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind which is a built in part of the language

Or if using ES6, the fat arrow => syntax suffices too
$timeout(() => foo());

@dcherman
function Test(val) {
this.v = val;
this.get = function(v2) {
return (this.v++) + v2;
}
}
var ins = new Test(5);
console.log(ins.get(2)); //7
console.log(ins.get(2)); //8
console.log(ins.get(2)); //9
console.log(ins.get.apply(null, [2]));//NaN
console.log(ins.get.bind(ins).apply(null, [2]));//10
in the source code ,the fn passed in is executed like this 'fn.apply(null,args)'
if I pass the ins.get ,it cause aproblem NaN
if I manually bind ins.get to ins itself,then it works.
So you mean pass ins.get.bind(ins) is more elegante than pass [ins.get,ins]?

@wesleycho
good suggestion!But we are still waiting the modern browser'usage to increase.
http://caniuse.com/#feat=arrow-functions

Adding this feature would complicate the API for very little benefit imo.
It will deviate further away (than necessary) from the native setTimeout API, which is not desirable and will affect all users, while it will (marginally) benefit a small minority of usecases only.
Furthermore, it will introduce just another way to do the same thing (binding a context to a function). As @dcherman mentioned, using .bind() is the "industry standard" (:smiley:) for accomplishing this and providing an alternative just for $timeout doesn't seem to give us much (there are dozen of other places where you need the same thing - basically, everything that accepts a callback could use context-binding).
There are other ways to bind the execution context for a function call as well, such as using arrow functions (as pointed out by @wesleycho) of using a wrapper function (function () { return ins.get(); }).
Based on the above, I'm going to close this as won't fix.

@gkalpak
thanks dude , I learned many coding skills form your comment.


RelationManager not found by Livewire

Describe the bug
If you are registering a resource in a package using Filament\PluginServiceProvider you get the following error when your resource includes a RelationManager.

To reproduce
Steps to reproduce the behavior:

Extend Filament\PluginServiceProvider in your package
Create a resource with a RelationManager
View the resource

Expected behavior
The relation manager should load correctly.

Screenshots
If applicable, add screenshots to help explain your problem.
Context

Package version: [e.g. 0.1.0] 1.5.5
Livewire version: [e.g. 2.0.0] 2.3.5
Laravel version: [e.g. 8.0.0] 8.32
Browser: [e.g. Chrome, Safari] Chrome
Server OS: [e.g. Ubuntu 18.04.4] Ubuntu 18.04.4
PHP version: [e.g. 7.4] 7.4
Database: [e.g. MySQL 8.0] N/A

Additional details
None

Closed by #191.


isDefEq throws unexpected bound variable #0

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

[X] Checked that your issue isn't already filed.
[X] Reduced the issue to a self-contained, reproducible test case.

Description
I'm learning how to write Tactics. Given the goal Q, the following code tries to find P -> Q in context, and if so, replace the goal with P
In the code below, isDefEq s t failed, because the first assumption of form . -> . is ∀ (P Q : Prop), (P → Q) → P → Q. And its bindingBody! is (Q : Prop) → (#0 → Q) → #0 → Q. isDefEq calls ... which calls isDefEqUnitLike which calls inferType which throws exception about unbound variable.
However, isDefEq t s works.
Did I misuse the code? Or perhaps we should make isDefEqUnitLike more robust?
import Lean
import Lean.Meta
import Lean.Meta.Tactic

open Lean Elab Elab.Tactic Meta

set_option trace.debug true

def apply_assumption : TacticM Unit := do
  let m := (←getLCtx)
  let goal ←getMainGoal
  let target ← getMVarType goal
  trace[debug] "target is {target}"

  for o in m.decls do
    if o.isSome && o.get!.type.isForall then
      let Expr1 := o.get!.type.bindingDomain!
      let Expr2 := o.get!.type.bindingBody!

      trace[debug] "o is {o.get!.type}"
      trace[debug] "expr1 is {Expr1}"
      trace[debug] "expr2 is {Expr2}"

      let (t, s) := (target, Expr2)

      -- if (t == s) then       -- works
      -- if (←isDefEq t s) then -- works
      if (←isDefEq s t) then    -- doesn't work
        let newGoal ← mkFreshExprSyntheticOpaqueMVar Expr1
        let theapp := mkApp o.get!.toExpr newGoal
        assignExprMVar goal theapp
        appendGoals [newGoal.mvarId!]

  return ()

elab "apply_assumption" : tactic => apply_assumption

example (P Q : Prop) (h : P → Q) (p : P) : Q := by
  apply_assumption
  exact p

Messages below (5)
39:2:
[debug] target is Q
39:2:
[debug] o is ∀ (P Q : Prop), (P → Q) → P → Q
39:2:
[debug] expr1 is Prop
39:2:
[debug] expr2 is (Q : Prop) → (#0 → Q) → #0 → Q
39:2:
unexpected bound variable #0

Steps to Reproduce
Expected behavior: isDefEqUnitLike returns false
Actual behavior: isDefEqUnitLike throws exception
Reproduces how often:
Versions
Lean (version 4.0.0, commit c2c2783f32b8, Release)

Did I misuse the code?

Yes, functions in MetaM etc. generally expect all expressions to be closed. You use forallBoundedTelescope to move a function type's binder into the local context, see e.g. tests using it in the repo.


New Crowdin updates

Closing because the initial Swedish translation file was regional-only

Closing because the initial Swedish translation file was regional-only


first/tap operators should unsubscribe before emit next value

Bug Report
Current Behavior
Currently, we are unsubscribing from source observables after emit the last message next to the chain. In some cases, it can raise incorrect and unexpected behavior (it seems to me).
In example below, we are still have processing new messages second observable in merge after first have emitted the first message. But expected behavior is that first operator must unsubscribe from all sources on receiving the first message.
Also, we have strange behavior: we can emit error from second observable and this exception will go through first operator and handle (in my example)  in catchError, but if we try to pass just a value through first, this operator (actually tap operator inside of first) will omit this message.
Reproduction
const notificator = new Subject();

merge(
  timer(1)
    .pipe(
      tap((m) => console.log('value from first: ', m)),
    ),
  notificator.pipe(
    tap(() => console.log('value from notificator')),
    switchMap(() => throwError(new Error('Some error'))),
))
  .pipe(
    first(),
    catchError((err) => {
      console.log('Catching error: ', err)
      return throwError('Continue receive error after first value');
    }),
    tap((value) => {
      console.log('value: ', value);
      notificator.next(null);
    })
  ).subscribe(
    (value) => console.log('Next value: ', value),
    (err) => console.log('Error: ', err),
  );

Output:
value from first: 0
value: 0
value from notificator
Catching error: Error {}
Error: Continue receive error after first value

You can try it here.
Expected behavior
As I told before, I think that we shouldn't get any effects (include errors) from source observables after the limit of allowed values in stream reached. And more, we should unsubscribe from them, to prevent any calculations inside source chain, we should unsubscribe before passing the last value next.
Environment

Runtime: Chrome/83.0.4103.97
RxJS version: 6.5.2

Possible Solution
In take operator we overriding next handler to:
https://github.com/ReactiveX/rxjs/blob/3f3c614d8b86c68d271a1db995ff11c61842e757/src/internal/operators/take.ts#L79-L89
I suggest changing them to make unsubscribe stuff before emitting next value. Also, this will allow us to omit if (count <= total) this strange check, because if we already unsubscribed from source that we will no longer receive a message.
If this change can affect something (backward compatibility), I think we should at least override _error handler to prevent passing errors. But I think, more correct just unsubscribe before next.
I will be glad to make a pull request if you agree with my arguments.

this behavior is kind of expected.
a workaround is to use a scheduler:
notificator.pipe(
  observeOn(asapScheduler),
  tap(() => console.log('value from notificator')),
  switchMap(() => throwError(new Error('Some error'))),
)

Unfortunately, the fix for this is a breaking change, and we're unable to have it until v8.


Add kind/improvement to  enforce-labels.yml workflow

🗣 Description

Noticed kind/improvement label and it wasn't supported in the enforce-labels.yml workflow.

Will remove kind/improvement as a label


Wrong replacing in contenteditable

I made an example with the strategy I have for completing HTML tags:
http://fiddle.jshell.net/p5qqvkp6/5/
when there is already a "<" (= & lt;) inside the text the replacing removes all text after that character - I think the replacing does something wrong in that case.
Would really appreciate if someone could check out my example!

I have the same issue with contenteditable.
+1

This issue is duplicate #282


Add iframe to show good-quality data

Example here:

To test:
git checkout af/202-good-data
cd docs
make html
cd /_build/html
open -a "Google Chrome" data-acquisition.html

Fixes #202

I tried your version https://github.com/spine-generic/spine-generic/pull/218/commits/753fe810177a6de07013651c56a04dbfa5e64e11, and it is not as good as what you posted in https://github.com/spine-generic/spine-generic/issues/202#issuecomment-690677535. The problem is that in https://github.com/spine-generic/spine-generic/pull/218/commits/753fe810177a6de07013651c56a04dbfa5e64e11, images are resampled, which prevents from appreciating the native spatial resolution.
Until Pierre fixes the bug on brainsprite, could you try to resample the images only in the z direction? (ie. making it isotropic resolution, e.g. 0.9x0.9x0.9 for the MT scans)

@jcohenadad I resampled the MTS images in https://github.com/spine-generic/spine-generic/pull/218/commits/6cb02f38b2356714ee46cec4c89fa81595bebf2b. Should I also resample the other ones (T1w, T2w, T2star) because they look downsampled as well?

Should I also resample the other ones (T1w, T2w, T2star) because they look downsampled as well?

only resample when res is anisotropic, right? (ie: to avoid the squeezing effect). https://github.com/spine-generic/spine-generic/issues/202#issuecomment-690677535 did not look downsampled to me

@jcohenadad
I updated the images. I had to resample only the T2star.
Could you please check ?

@alexfoias feedback on bdee084e:

looks gorgeous 🎉
i would definitely make each panel bigger (it is difficult to see the spinal cord, and there is space on the web page)
on the T2* the blue cross does not appear (at least on my browser)
could you reorganize the sections:

Data conversion: DICOM to BIDS
Checking acquisition parameters
Ethics and anonymization
Multi-center data
Example of datasets  --> this is where you can put your images

@jcohenadad I have triggered a new build. You can try it on the link: https://spine-generic.readthedocs.io/en/af-202-good-data/data-acquisition.html
For T2* i have the same problem with the cross.

@alexfoias i've checked a7c4c13e and this is very cool! A few comments:

don't worry about the cross on the T2*, that's a minor issue
How come the T2* and all GRE data seem "rotated" when displayed? for example, you can see on the sagittal image that the bottom makes an angle. Is there a possibility to display the images without such rotation/resampling? maybe try to turn off the background/template option?
Could you please also show the mean DWI image?

Thanks!

How come the T2* and all GRE data seem "rotated" when displayed? for example, you can see on the sagittal image that the bottom makes an angle. Is there a possibility to display the images without such rotation/resampling? maybe try to turn off the background/template option?

T2* is the only scan that has the orientation LAS, all the other ones are RAS. I didn't rotate the images.. We don't have a background for any of the images.

Could you please also show the mean DWI image?

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/065defdf3de144adbca8d437ce48dafeb4980dcf .

Could you add the subject ID next to each contrast

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/065defdf3de144adbca8d437ce48dafeb4980dcf .

How come the T2* and all GRE data seem "rotated" when displayed? for example, you can see on the sagittal image that the bottom makes an angle. Is there a possibility to display the images without such rotation/resampling? maybe try to turn off the background/template option?
T2* is the only scan that has the orientation LAS, all the other ones are RAS. I didn't rotate the images.. We don't have a background for any of the images.

right, but that didn't explain what's going on for the T2* and GRE scans (ie all the MTS). Do you see what i mean by "rotated"? there is something going on here. Maybe if you try to reorient to RAS?

I tried to reorient to RAS. I even tried LAS or RIP. They always orient the image from the iframe in the same way.

comments from 405e75ac:

can you remove "anatomical scan" from the DWI image
on the DWI image: can you use resampling as you did for the GRE scans (anisotropic resolution)
about the GRE and T2* orientations: ok, let's see if we can at least improve the appearance: would it be possible to zoom in a little, so we can better see the spinal cord? it looks very small

can you remove "anatomical scan" from the DWI image

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/f20b6098d8899539186a56e365a0f6f75e13a60d.

on the DWI image: can you use resampling as you did for the GRE scans (anisotropic resolution)

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/f20b6098d8899539186a56e365a0f6f75e13a60d.

about the GRE and T2* orientations: ok, let's see if we can at least improve the appearance: would it be possible to zoom in a little, so we can better see the spinal cord? it looks very small

I tried to use the variable dim in viewer_substitute  and width, height in bsprite.transform, but nothing seemed to zoom . Should I do a follow-up on the https://github.com/brainsprite/brainsprite/issues/98#issuecomment-690815406 ?

I tried to use the variable dim in viewer_substitute and width, height in bsprite.transform, but nothing seemed to zoom . Should I do a follow-up on the brainsprite/brainsprite#98 (comment) ?

no, they are too busy
DWI: I think you included the b=0 image in the average (not only the DWI data), as can be seen below (we see the vessels, which should not happen with DWI weighting):

Regarding the zoom: could you please crop the GRE data, eg: X: -56, +56 and Y: -60, +100? That should make the spinal cord bigger

DWI: I think you included the b=0 image in the average (not only the DWI data), as can be seen below (we see the vessels, which should not happen with DWI weighting):

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/8f6ddbdae62ea30321e85baa98a655f758d02426.
I had to separate the dwi images
sct_dmri_separate_b0_and_dwi -i /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi.nii.gz -o /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi_separated.nii.gz -bvec /Users/alfoi/code/data-multi-subject/sub-barcelona04/dwi/sub-barcelona04_dwi.bvec
sct_maths -i /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi_separated.nii.gz/sub-barcelona04_dwi_dwi.nii.gz -mean t -o /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi_mean_new.nii.gz
sct_resample -i /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi_mean_new.nii.gz  -mm 0.9x0.9x0.9 -o /Users/alfoi/Desktop/DATA/RAW/contrasts_good/sub-barcelona04_dwi_mean_new_isotropic.nii.gz

Regarding the zoom: could you please crop the GRE data, eg: X: -56, +56 and Y: -60, +100? That should make the spinal cord bigger

Done in https://github.com/spine-generic/spine-generic/pull/218/commits/3262a815b667c23adb15fee2c14a2156a59bddf3.

Regarding the zoom: could you please crop the GRE data, eg: X: -56, +56 and Y: -60, +100? That should make the spinal cord bigger
Done in 3262a81.

hum, it seems much more cropped than -56/56 (it shows -20/20). COuld you please try with a less aggressive cropping? ppl need to have an overview of the data as well-- thanks!

@jcohenadad Could you please check the new images ?

@jcohenadad Could you please check the new images ?

this is perfect! could you pls do the same for the T2* data-- thanks

also pls remove "anatomical scan"

@jcohenadad Done. Not sure if you want it more larger for T2star.

i still see the "anatomical scan":

(pls remove everywhere)
also, can you make the T2* look like the other MTS scans (currently it is smaller):

can you also please remove the colorbars?

@jcohenadad done. I think the best practice is to open the link in a new page incognito in order to grab the latest updates.

@alexfoias could you please document how you generated the html at the top of this PR?

I added the code.


Microsoft.DataFactory/Dataset: enum values removal of compressionType is causing issue to the dependency resources

PR #16563  deleted some enum values of compressionType and the removal is causing compiling issues of the dependency resource.

Hi @xiaxyi , PR #17036 adds these values back and is currently under review.

Sync offline, will not change. @xiaxyi @Jingshu923


extended_asset is using EOSLIB_SERIALIZE instead of EOSLIB_SERIALIZE_DERIVED

@tbfleming  asked me to create this issue.
I’m trying to adapt the issue action to use an extended_asset. the original issue action params body is:
{"to":"leo", "quantity": "100 TEST", "memo": "testing tokens"}
changed to extended_asset and tried the below parameters:
{"to":"leo", "quantity": {"amount": 100, "symbol": "TEST", "contract": "mytest"}, "memo": "testing tokens"}
But the extended asset is empty, like a brand new one, if I print it, this is what I have:
0.0000 SYS@mytest
So the contract is working but I’m not being able to set the amount and symbol. Any ideas?
I tried also "amount": "100 TEST" and also "asset": "100 TEST".. Nothing... Looks like I'm not being able to set the parent class (asset) attributes.

Simple case should not occur in future. should add to test case as well.

Don't try this, it will not work: "quantity": "100.0000 SYS@mytest"

How to create your own exchange


Consider adding Cargo.lock back

According to https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
cdylibs and binaries should have Cargo.lock, but rust libraries shouldn't. We're all three at once.

Ideally if we cargo-vendor the sources in the release tarballs Cargo.lock is not needed.

I'm reasonably certain Cargo will ignore Cargo.lock when rav1e is used as a library, so it should be safe to add back for when it's used as a binary. Is there any reason for specifically wanting it gone?

This page in the rust book specifically says to not include it: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

I'm guessing that's because it won't be used anyway for libraries. I found the section in the Cargo docs that explains it: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Users dependent on the library will not inspect the library’s Cargo.lock (even if it exists).

Moving the binary to its own crate would allow checking in its Cargo.lock and not the library's.

As a side note: Having an official Cargo.lock file available (in this Git repository, release tarball, or e.g. via a separate URL) would also be useful for the Nix package (vs. checking a custom Cargo.lock file with 1340 lines of code into a monorepo for many packages) and reproducible builds in general.

@Luni-4 can you please look into adding an automation to add the Cargo.lock to the tarball?
I do hate having the Cargo.lock in the main repository since it makes the diffs fairly large and fairly difficult to read in a normal setup.

@lu-zero
Yeah, it would be possible. I will update #1883

I manually added the Cargo.lock to the release 0.2.0. We could automate this as well.
@primeos would that work for you?

@lu-zero
Cargo.lock is inside the rav1e-$version.zip file

@lu-zero yes, that works and the automated solution from @Luni-4 is also fine, thank you very much :) I've merged the Nix(OS) package.
@Luni-4: Maybe it would make sense to add the Cargo.lock file separately as it isn't only relevant for Windows users. But I'm also fine with extracting it from the ZIP-Archive. Thank you for automating it.

@Luni-4: Maybe it would make sense to add the Cargo.lock file separately as it isn't only relevant for Windows users. But I'm also fine with extracting it from the ZIP-Archive. Thank you for automating it.

Yep, you're right. I will change that as soon as possible. Thanks! :)

@primeos
Changed in #1973


Use id instead of name in the label

Current Behavior
In the label, the for attribute points to the input name. In result the click on the label doesn’t trigger the the input focus.
Expected behavior
The for attribute should point to the input id
To associate the <label> with an <input> element, you need to give the  an id attribute. The <label> then needs a for attribute whose value is the same as the input's id.
Alternatively, you can nest the <input> directly inside the <label>, in which case the for and id attributes are not needed because the association is implicit:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

https://www.w3schools.com/tags/tag_label.asp
Suggested solution(s)
Change this
React.createElement(
            Label,
            { "for": field.name, className: "label-color" },
            props.label
        ),

to
React.createElement(
            Label,
            { "for": props.id, className: "label-color" },
            props.label
        ),

Thanks for pointing it out. Fixed with version 1.0.8.


Resolve clippy lints

Clippy has a few suggestions I've applied here:

Some small style changes in the fds module
Remove unnecessary borrows when calling exit
Switch from expect to unwrap_or_else. The old version would allocate the String for the expect even if the serialization succeeded. Switching to unwrap_or_else lets us avoid that.

I also added clippy and formatter checks to the CI.

Thank you!


refactor github api with es6 syntax and async/await

github library (@octokit/rest) natively supports promise.

I have not found any official documentation that the return for the res.render is required.  In favor of simplicity (less wordiness), lets remove the return that is for the res.render statement for now.  We may revisit this at a later point.

Thank you :)

Related: https://github.com/sahat/hackathon-starter/issues/720


download_and_extract.sh script hitting error on sed

Working on creating a repo for ESP examples.
With latest sources, I hit below error with sed:
+ sed -i '1 i\#ifndef _KISS_FFT_GUTS_H\n#define _KISS_FFT_GUTS_H\n' tensorflow/lite/micro/tools/make/downloads/kissfft/_kiss_fft_guts.h
sed: 1: "tensorflow/lite/micro/t ...": undefined label 'ensorflow/lite/micro/tools/make/downloads/kissfft/_kiss_fft_guts.h'
make: *** [tensorflow/lite/micro/tools/make/Makefile:600: tensorflow/lite/micro/tools/make/downloads/kissfft] Error 1

Culprit seem to be below lines of code added few weeks back in patch_kissfft function:
  sed -i '1 i\#ifndef _KISS_FFT_GUTS_H\n#define _KISS_FFT_GUTS_H\n' tensorflow/lite/micro/tools/make/downloads/kissfft/_kiss_fft_guts.h
  sed -i '$a\#endif // _KISS_FFT_GUTS_H\n' tensorflow/lite/micro/tools/make/downloads/kissfft/_kiss_fft_guts.h

cc @shlmregev

Can you confirm that you are hitting the issue with a fresh checkout (or after running make clean_downloads)?
Also, are you attempting on Linux or Windows?
The Linux CI is ok, so I would suspect this to be caused by some corner case not covered by the CI. Full reproduction steps would be very helpful for us to debug this further.


Fail to add desktop entry on Linux (openSUSE Leap 15)

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed: https://github.com/GetStream/Winds/issues

Description
The desktop entry fails to be added using the AppImage.
Steps to Reproduce

Download the AppImage
Make it executable chmod +x Winds-2.1.0-x86_64.AppImage
Execute the application ./Winds-2.1.0-x86_64.AppImage
Say yes to "Would you like to integrate /home/user/Downloads/Winds-2.1.0-x86_64.AppImage with your system?

Expected behavior: To have a desktop entry integrated with my system.
Actual behavior: Error message in the console when executing the AppImage and saying "yes" to the app system integration.
Error on file "/tmp/.mount_Winds-VrlHqf/winds.desktop": Key file contains line “For more information, visit https://getstream.io/winds/.” which is not a key-value pair, group, or comment
Reproduces how often: always
Versions
2.1.0

Same issue here on Arch Linux. Manually added the desktop entry with exec set to the "winds" executable file inside the app folder created in the temp directory. The desktop entry still doesn't register. Launching the app using the winds executable file (not the .AppImage file) does not produce the above error. Have set an environment variable to launch directly from terminal for now.

I'm working on this.
As @dashsd mentioned, the multi-line value for the key "description" in the "package.json" file is creating the issue. I'll make a PR soon.


NPE in SdlRouterService.writeBytesToTransport

Bug Report
After updating to lib version 4.7.2 we're getting a fairly high amount of crashes writeBytesToTransport.
Currently I'm not able to reproduce this crash, since I have no information about the situation it happens in.
java.lang.NullPointerException:
at com.smartdevicelink.transport.SdlRouterService.writeBytesToTransport (SdlRouterService.java:1839)
at com.smartdevicelink.transport.SdlRouterService$RouterHandler$1.run (SdlRouterService.java:513)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1162)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:636)
at java.lang.Thread.run (Thread.java:764)
Reproduction Steps

OS & Version Information

Android Version: 4.4 - 9.0
SDL Android Version: 4.7.2
Testing Against: Userfeedback/Crashreports currently not observeable with TDK

Test Case, Sample Code, and / or Example App
APP: n-tv Nachrichten => https://play.google.com/store/apps/details?id=de.lineas.lit.ntv.android

Yes, We also meet this NPE. Please help to fix in new release.

I wasn't able to reproduce this issue, but could easily see a possible race condition. I have provided a PR that should address the issue in #956. I have added it to the next release project to hopefully be included.


Error vim.schedule lua callback, attempt to index a nil value

At random I get this error:
Error executing vim.schedule lua callback: .../nvim/pack/packager/start/completion-nvim/lua/source.lua:73: attempt to index a nil value

I can reproduce it 100% of the time by editing lua files, and for some other file types happens randomly. Note that I don't have lsp for lua set up, so maybe that's the issue.
This is my config:
let g:completion_chain_complete_list = {
      \ 'default': [
      \    {'complete_items': ['lsp', 'snippet', 'path']},
      \    {'mode': 'tags'},
      \    {'mode': 'keyn'},
      \    {'mode': '<c-p>'},
      \  ]}

I messed something up in the latest change, it should be fixed now.

Looks good, thanks!

I am getting Error executing vim.schedule lua callback: ....vim/plugged/completion-nvim/lua/completion/matching.lua:59: attempt to call a nil value


[Mesh] export (from ANSYS) to import (FEniCS-X) with name tag BC

I create a mesh using ANSYS (both CAD and Meshing) with surface tagged for BC. Then I export them into .cgns format.
Could you please tell me how to preserve those tags while I can import those mesh into FEniCS-X.

same question


Bug on Spell Check Button

How to get the bug:->

Open any project
Go to 'Tools' , click on spell check button.
You will notice all the formatting is getting removed from the current page.

Completed on commit number :-> f6b7d43b5b1155665425838ae9b6dadde4ac0da3


help needed porting substrate-api-client to sgx

Hi @dingelish. We wrote a crate that needs to be used within an enclave now.
Our effort to port can be found here:
https://github.com/scs/substrate-api-client/tree/no_std
The current master works fine. The no_std branch fails at:
> cargo build --release
   Compiling substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client)
error[E0432]: unresolved import `std::sync::mpsc`
  --> src/lib.rs:32:16
   |
32 | use std::sync::mpsc::channel;
   |                ^^^^ help: a similar path exists: `ws::std::sync::mpsc`

as well as at
cargo build --release --no-default-features --features mesalock_sgx
   Compiling substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client)
error[E0432]: unresolved import `std::vec`
  --> src/extrinsic/mod.rs:22:10
   |
22 | use std::vec::Vec;
   |          ^^^ help: a similar path exists: `serde::std::vec`

as well as without the mesalock_sgx feature.
Your help would be greatly appreciated

@brenzi
just a quick look: https://github.com/scs/substrate-api-client/blob/no_std/Cargo.toml#L119
https://github.com/baidu/rust-sgx-sdk/tree/master/sgx_tstd/src/sync
sgx_tstd doesn't implement all of std:
https://github.com/baidu/rust-sgx-sdk/blob/master/release_notes.md#partially-supported-modstraits-in-sgx_tstd

Thanks @tomtau. I'm aware that sgx_tstd only implements std partially. I think I've gated off everything which isn't covered by #[cfg(feature = "std")]
https://github.com/scs/substrate-api-client/blob/1dad3a835d8f2f796c43cfcb4f9ae718bef44cc4/src/lib.rs#L31

Yes, butstd is on in cargo build --release .
for cargo build --release --no-default-features --features mesalock_sgx, perhaps use std::prelude::v1::Vec; instead of use std::vec::Vec; ?

I suspect the problem to be with the Cargo.toml file. I could fix some of the above errors by adding a few default-features=false to mesalock deps.
If I do cargo build --release, I'd expect sgx_tstd not to be a dependency, but here's my cargo tree:
sgx_tstd v1.0.9 (https://github.com/baidu/rust-sgx-sdk?rev=v1.0.9#407cbaaf)
├── itoa v0.4.4 (https://github.com/mesalock-linux/itoa-sgx.git#4f4b8dc2)
│   └── serde_json v1.0.40 (https://github.com/mesalock-linux/serde-json-sgx#7f602959)
│       └── substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client)
├── log v0.4.8 (https://github.com/mesalock-linux/log-sgx#93cf0f64)
│   ├── env_logger v0.6.2 (https://github.com/mesalock-linux/env_logger-sgx#b2f44420)
│   │   └── substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client) (*)
│   └── substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client) (*)
└── serde v1.0.101 (https://github.com/mesalock-linux/serde-sgx#bc160eaa)
    ├── serde_json v1.0.40 (https://github.com/mesalock-linux/serde-json-sgx#7f602959) (*)
    └── substrate-api-client v2.0.0 (/home/abrenzikofer/substrate-api-client) (*)

Looking at serde-json-sgx, I see that the std feature is not forwarded to dependency itoa. I guess this should be added, no?
update here: https://github.com/scs/substrate-api-client/tree/no_std

It seems that serde_json-sgx depends on ìtoawithoutdefault-features=false`
https://github.com/mesalock-linux/serde-json-sgx/blob/7f6029590cf312c412c225cb944c429e5fadd3b2/Cargo.toml#L22
which is translated to default=["mesalock-sgx"] here:
https://github.com/mesalock-linux/itoa-sgx/blob/4f4b8dc29204fc7408584df7083194329aa5cc59/Cargo.toml#L14
which then drags in sgx_tstd

@dingelish : AFAIK you have no samplecode that implements a crate that can be used within an enclave AS WELL AS outside in std environment. To my understanding, that's also why you have split sgx_crypto_helper and sgx_tcrypto_helper.
I'm trying a wrong approach? Should I just support no_std without relying on your sgx_tstd libs?

@dingelish : AFAIK you have no samplecode that implements a crate that can be used within an enclave AS WELL AS outside in std environment. To my understanding, that's also why you have split sgx_crypto_helper and sgx_tcrypto_helper.
I'm trying a wrong approach? Should I just support no_std without relying on your sgx_tstd libs?

Almost all of the forked crates are only available in enclave. But there are exceptions like serde, which has almost zero dependencies and I remember you can enable "std" without "mesalock_sgx" to make it work in normal untrusted app.
And you're right about crypto_helper and tcrypto_helper.
I would say that no_std crate is friendly to SGX enclave, but it sacrifices many stuffs. Let me look closer to your case and reply later :-)

Hi @brenzi , do you prefer the branch to be compiled enclave-only, or prefer to make it work on both untrusted side and trusted side?

One more remark: I only need parts of the substrate-api-client crate to be available on trusted side. See lib.rs for exclusions with #[cfg(feature = "std")]

I think the parity style can work:
https://github.com/scs/substrate-api-client/tree/no_std_rstd
at least it's building. further testing ahead.


fix: thorswap error handling

Description
Handle calling THORSwapper's getTradeQuote on unsupported assets by using monadic error handling to gracefully catch.
See screenshots below for console errors.
Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
N/A
Risk
Small risk to THORSwap quotes.
Testing
Ensure THORSwap quotes and trades still work as expected.
Engineering
☝
Operations
☝
Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4945   👈

This comment was auto-generated by Graphite.


"Add column..." dialog should have input focus in "New column name" field

As anyway you must enter name of column to create it, but now you need to Shift-Tab/Tab many times or move mouse in opposite directions each time.

It was decided by @katrinleinweber in #2139 to focus the expression input instead.

Without having seen this issue, though ;-)

I would say both options have their pros and cons… But if we have a change of mind it does not have to be set in stone!


Remove --ignore-missing-dependencies from delocate command

Even though the pyarrow libraries are explicitly excluded,  delocate-wheel still complains they are missing without --ignore-missing-dependencies


First public release of soca

Description
First public release of soca

do we care about workflow for this release (soca-science) ? Or are we just going to ignore that and include soca-workflow in a following release when it's ready?

do we care about workflow for this release (soca-science) ? Or are we just going to ignore that and include soca-workflow in a following release when it's ready?

Undecided yet. I'm up for keeping it simple.


MODOAIPMH-477 - new types of electronic access relationship

MODOAIPMH-477) - Adjust 856 mappings
Purpose
Describe the purpose of the pull request.
Approach
How does this change fulfill the purpose?
TODOS and Open Questions

[ ] Use GitHub checklists. When solved, check the box and explain the answer.

Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.


Fix CI (typing-extensions minimal requirement)

Fix CI (see https://github.com/huggingface/huggingface_hub/actions/runs/6664387296/job/18111901923?pr=1779).
By default on Python3.8 in the CI, typing-extensions==4.5.0 seems to be installed which leads to
 ImportError: cannot import name 'TypeAliasType' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/typing_extensions.py)

This PR adds an explicit dependency >=4.8.0. This shouldn't cause any problem as the [typing] extras is optional.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I'll merge this one since it fixes CI (+ not really important). Ping @LysandreJik for visibility.


Standardise error response

In order to provide a consistent error response for consumer, this PR introduces a new format for the error response. The error response deprecated the error and error_description attributes and also add following new attributes:

message
name
code
statusCode

LGTM 👍

cc @gstamp for one more round of review

+1 for this, it's a much appreciated improvement over the upstream. Looking forward to seeing it merged! Thanks, @joneslee85!


fix readme links

I run link checker against staging. Looks fine

Processed 59 web pages, found 0 broken links


Sudo does not use howdy on Ubuntu 23.04

I've added a model, and checked it works with sudo /lib/security/howdy/cli.py test. The file /usr/share/pam-configs/howdy is correct. pam-auth-update lists howdy as enabled.
But sudo -i doesn't enable the IR camera, it just shows password auth. Any idea why?

What is the content of the /etc/pam.d/sudo file?

Nothing mentioning howdy:
#%PAM-1.0

# Set up user limits from /etc/security/limits.conf.
session    required   pam_limits.so

session    required   pam_env.so readenv=1 user_readenv=0
session    required   pam_env.so readenv=1 envfile=/etc/default/locale user_readenv=0

@include common-auth
@include common-account
@include common-session-noninteractive

What is the content of the /etc/pam.d/sudo file?

#%PAM-1.0

# Set up user limits from /etc/security/limits.conf.
auth   sufficient        pam_python.so /lib/security/howdy/pam.py
session    required   pam_limits.so

@include common-auth
@include common-account
@include common-session-noninteractive

Is this the expected output? I think I added **/howdy/pam.py there manually by following some troubleshooting guides. Not sure if this is the expected content of the file.

This isn't the expected output indeed, it should have an entry for howdy. If you put this in the file, it should work.
auth   sufficient        pam_python.so /lib/security/howdy/pam.py