[BUG] Cannot set provider & tikmate returns null URLs

Glad the API endpoint is back up and running, thanks!
It seems the URL type= parameter, specified in the docs here and here, isn't working, e.g.
https://tdl.besecure.eu.org/api/download?url=https://www.tiktok.com/@thembta/video/7117992666561809706&type=downtik&rotateOnError=true

returns a JSON with "provider":"musicalydown" instead of downtik like specified. It seems to be defaulting to a random provider, specific to each video.
This is problematic because the tikmate provider, when that one happens to be chosen, returns "urls":[null] meaning certain videos cannot be downloaded.

Hello @frozenpandaman :wave:
Sorry for late response, can you test it again? I've fixed it on https://github.com/hansputera/tiktok-dl/commit/23cb390fe4b41f08dd500951b09191c49c4122f6, and https://github.com/hansputera/tiktok-dl/commit/7261fea7d9dafaf111c798efc092a2de30bb51c4

Well, you can test the next version of TikTok-DL.
https://tiktok-next.herokuapp.com/api/video?url=<TIKTOK_VIDEO_URL>
On this next version, I don't use a third party anymore. However, for now there are some issues such as not being able to get a response from the tiktok server, and sometimes there are unexpected errors.

@hansputera Using the tdl.besecure.eu.org URL in my original post, it still returns an incorrect provider – now it's giving "provider":"lovetik", still not downtik. And in the cases it uses getvidtik, the URLs are null and the video cannot be downloaded. So it's still not fixed.

I tried the new version running on Heroku and it works great so far, thanks!!
FYI occasionally I am getting this response:
{"_":"GetVideo","error":"dialing to the given TCP address timed out"}

I am also occasionally getting these errors:
{"_":"GetVideo","error":"no response"}

and
{"_":"GetVideo","error":"invalid character '\u003c' looking for beginning of value"}

@hansputera Using the tdl.besecure.eu.org URL in my original post, it still returns an incorrect provider – now it's giving "provider":"lovetik", still not downtik. And in the cases it uses getvidtik, the URLs are null and the video cannot be downloaded. So it's still not fixed.

It should works now

downtik:

tikmate:

getvidtik:

@hansputera The tiktok-next.herokuapp.com endpoint now gives me an error:
https://www.herokucdn.com/error-pages/application-error.html
Let me know if you have a fix!

@hansputera Using the tdl.besecure.eu.org URL in my original post, it still returns an incorrect provider – now it's giving "provider":"lovetik", still not downtik. And in the cases it uses getvidtik, the URLs are null and the video cannot be downloaded. So it's still not fixed.

It should works now

downtik:

tikmate:

getvidtik:

I

Sorry, since heroku doesn't offer free hosting again, the application is shutting down.

Thanks for the fast reply. Would you consider switching to Vercel or Netlify? Both have free tiers and seem to have largely superceded Heroku.

Sorry, since heroku doesn't offer free hosting again, the application is shutting down.
@hansputera Thanks for the fast reply. Would you consider switching to Vercel or Netlify? Both have free tiers and seem to have largely superceded Heroku.

Or, would you have instructions on how to run this on a local server?


v8 : Form elements within form-group div display badly

Looks like anything that is within a form-group class div that is a form element looks pretty bad / way different than it did in previous releases of concrete5. I'm pretty sure I noticed this on the installation page, but definitely on some of my package stuff as well. I'm sure there are other places being affected.

Fortunately I think this stuff will be easy to resolve.
I think there are four main issues with the form styling as it currently stands:

There are no borders on any form elements. On some pages it can be a mystery as to where an input actually is located and it makes previously clear forms confusing.
The form-group element is where a border bottom has been placed. This isn't bad as such, but when there aren't input borders it gets confused as to what the line is for. It either needs to be that the border is the bottom of the input field, or inputs both have borders and the line is lighter.
The margin bottom on form-group is unnecessarily large. Pages that once fit on one screen now don't.
The label element doesn't have a specific font size, meaning it's inhertiting a font size too big for comfort. I visually compared the youtube block interface between v5.7 and v7 and that jumped out at me immediately. I'm not against things being visually 'strong', but all the largeness makes it hard to fit more elements in without panels scrolling.
The install screen has had columns removed. This turns what was previously a screen that would fit on screen without scrolling into something that requires scrolling. In 5.7 the columns and other visual cues helped to associate items together, this has been lost somewhat, so it's a step backwards UX wise.

I have nothing against trying a new direction for the look and feel, but well tested design guidelines for form usibility shouldn't be ignored.

Some of these are the exact purpose of our Fieldless Forms approach, so they won't be addressed because they're done by design.
However, they probably ought to be ignored within the context of the authentication type form.

If there are specific bugs about how this approach isn't working, we can continue the discussion about specific implementations, but in general the aesthetic is very purposeful. The authentication is not a good example of that, however, so I've introduced a new class to opt into these styles, and placed it around the dialogs, the dashboard and the core panels. The authentication views now won't exhibit this behavior.

Can someone elaborate on what fieldless forms are, what problems they solve etc.?

@aembler I think there's already a concern towards this fieldless form design from a usability point of view.
Without borders or at least something to give definition to the form fields, the fields suffer from 'lack of affordance'. Affordance for an object is the design it has that suggests use and interactivity. (I'll admit that I've only recently learnt this term, but the concept is very well known).
I'd strongly recommend reading this article about form design, and what works and what fails:  http://alistapart.com/article/flat-ui-and-forms
The article has quite a number of examples that illustrate why without appropriate styling on form fields user experience suffers.
The fields don't have to be heavy of chunky, but they need something to outline them. Not having the fields visible would be a critical user interface design mistake.

This is all anyone is really asking for. Someone must have felt that the shading was important enough to include when you hover over a field so clearly that's helpful information so why send users on an Easter egg hunt. To play Devil's Advocate for a moment, why stop at just fieldless form elements? Why not make all the labels only appear when you hover over them as well? To be honest, that makes as much sense to me as making the places you actually enter stuff be invisible. I don't get it.
Also, in Franz's blog post regarding this issue, he mentions, "Let's show validation rules once you've broken them". Ah, no thank you. Having to guess what validates and what doesn't is a complete waste of a users time. I just tried to enter the 'handle' for a date attribute and I only get warned about the syntax after I submit the form. Personally, I know what the syntax of a handle is supposed to be but users don't (they don't actually know why they need a separate 'handle' at all) and so the attribute-creation form should either have the rules spelled out ahead of time or it should not allow illegal characters to be entered at all (preferably both). This is like not putting a stop sign up at an intersection and just having a cop hand out tickets after everyone in town gets into an accident. Sure, everyone in town will eventually learn to stop at that intersection but wouldn't a stop sign be a nice, simple solution?

I don't like the fieldless forms at all, I find them visually unappealing and think it makes forms look broken and confusing.

In general, I find anyone over 25 doesn't understand a fieldless form - designers and under 25s have less issues.
We've just watched a client implement a bunch of UI trends (hamburger menu, fieldless forms) and the outcome has been confusion and financial disaster - truly. So make sure you know your primary user, I’m betting many won’t understand a fieldless form.
Why? The name sums it up, a fieldless form!  Bad user experience.
 And in this instance, the hover is a solution to a new problem created by the fieldless form! Kind of mad right?
Dig up an old smashing magazine article on the myth of the sophisticated user.  All users lose.
Making things understandable while keeping things clean is the job of the designer (I’m a designer). In many situations, hamburger menus and fieldless forms are self-serving because they make our jobs easier - if we don't care about users that is.
Is it the end of the world? Nope. Would it be 1000 times better if the user immediately understood what to do? Yep.

Excellent point on hovers

I am in agreement that the current implementation of fieldless forms makes them more challenging to use.
In an attempt to bridge the gap between the concerns of the concrete5 community and design goals of Portland Labs, Mesuva and I have come up with a new iteration of a "happy medium" design. A design that uses fieldless forms, but should allow for a better user experience. Care was made to make all changes with specific reasoning and intention opposed to changes based on personal preference.
A couple things that appear to be causing the biggest issues in the current design are the "baselines" (the edge to edge horizontal borders) and margin and padding. The full width border looks like a section divider and not the baseline for entering text. There is also substantial margin and padding that is spreading out the different form elements, in particular the large space between the bottom border and the form input. When combined these are causing confusion for where form inputs are. One of the changes made was to replace the edge to edge horizontal border with a border on the bottom of the input - with the border spanning only the width of the input.
Ultimately, the goal was to make the forms look more like paper forms.
We have tested this new design with all the core blocks, multiple add-ons, and much of the dashboard. So far it appears to hold up and display correctly. The CSS for block forms, single pages, and other form modals is ready for a pull request. Page Settings pages, third-party form widgets like the datepicker, and other miscellaneous form inputs would be submitted as a second pull request.
Before & After Examples
Add Folder form modal
before

after

Feature block form modal
before

after

Image block form modal
before

after

Page List form modal
before

after

Page Types dashboard page
before

after

Testimonial block form modal
default
without content

with content

changes
inactive

input hover

input focus

input hover with content

input focus with content

inactive with content

Image Slider block form modal
annotated screenshots
default

changes

Much improved!
But I'm still struggling to understand what specific problem a line, as opposed to a box, actually solves?
It seems like we're trying to justify applying a cool design trend to forms. In which case, just do it! That's what cool design is all about.
Client's still find 5.7 editable areas more confusing than 5.6 - same issue. It requires more work to understand but I agree that it looks cleaner.

I'm afraid I agree with the concerns about the invisible elements (for such they are, initially). I find that, in use, they require a trial-and-error approach to finding out where the input element actually is—if there's one at all. It's rather like a 'hidden object' game, where one has to mouse over the screen trying to find clues.

The tab menu is also with "hidden" Active state (and very small text).
Idea for other design - i think its more clear "i am in tab "X" (or any other solution to this problem)

My solution to fieldless forms is a little css in my themes:
.ccm-ui div.form-group select.form-control, .ccm-ui div.form-group input.form-control, .ccm-ui div.form-group textarea.form-control {
background-color:#e5edf1 !important;
padding: 0 5px !important;
}
Make them look how you like and bye bye fieldless forms.

Do theme files get loaded on purely Dashboard pages?

It's working for me, I put it in my themes css/main.less

"text area" issue - a lot of padding
MrKarlDilkington your design its better - nice work.
For "single line" the design works fine. But for multi-line (text area) The lines must follow user text (Also without content the line need to be closer to the text and not - 60-70 pixels at the bottom).
This is maybe the main problem of this material form pattern (in box its really to show  "text area")
Example (smaller padding for text-area)
https://www.muicss.com/docs/v1/css-js/forms
https://www.google.com/design/spec/components/text-fields.html#text-fields-multi-line-text-field
Drop down issue - Mabye its better to work with "compact" dropdown
I am not sure it better design and ui that the drop-down icon is "align" block (to the container right edge  // JUSTIFY). I more like the "compact" design (Its more clear that way "i am drop down")
In general block look the "justify" align look better but this pattern is more clear!:
http://www.material-ui.com/#/components/dropdown-menu
Idea for errors design

Thanks for the thoughtful direction @MrKarlDilkington  Putting this type of thing together is helpful. This looks like it took a lot of time and there's some great ideas in here.
I love the clarity of the labels in your comps. It's important for people to know what those mean when they see them and for them to not fade into the input fields as an afterthought. It should be painfully clear what the system is asking of you vs. what you are entering to the system.
As I haven't posted to this thread, some background for the problems we're trying to solve is posted in detail here, if you haven't read it yet: https://www.concrete5.org/about/blog/news/fieldless-forms
I agree with @mhawke that you shouldn't have to wait through a form submission to learn validation rules. Of course, to be clear that's actually how it works today, but yes as we start to really focus on design here we should take the time to get that right. The point I was making in the blog post is I shouldn't have to scan over a bunch of tiny hard to read text for every form element if I'm just editing one. I think we could solve that pretty easily by having a spot for an additional context sentence that fades in when you focus on the field.
I believe the underlying consistent concern voiced here is on the issue of text fields and areas. Will anyone know they can click there to enter text, or will they patiently wait for the rest of the form elements to load? ;) The people I've actually given a working copy of 8 to instantly get it once they've been shown the first field. I do grant you however, that much like when we dropped the lines in edit mode with version 6, there's a real "uhh - is it broken?" moment I'm having to walk them through. Once you start typing a field value it comes together very quickly. But no, we certainly don't want to make it hard to figure out where to type. I don't think our target market is the same as Facebook's (referenced in the listapart article.) I do certainly agree that we don't want to go out of our way to make a first user's experience difficult. However we're designing for the people who use it every day, not for on-boarding people in a void. Obviously that's easy thing to type, but you won't have any daily users if it never makes sense in a demo/sales call. We understand and take seriously the delicate balance we're dancing with here.
Just to be clear if you haven't bothered to read the blog post. We're not just trying to make stuff look pretty or follow a passing visual fad. The value we're trying to create - the problem we're solving, is information overload.
We show so much cruft and have so much flexibility with crap everywhere in concrete5's Dashboard today, that the organization of this new approach is very appealing. The strength in what we have today so far is:
o.. The rows. The emphasis on one attribute, one row is simple and effective. It keeps every add-on developer from following their own path. It makes it so as a site owner extends functionality with new attributes the UX remains very consistent. It's always mobile friendly. It's one of those rare ideas that is unorthodox, simple, and effective.
o.. The emphasis on data and not chrome. Looking at some of our own dashboard designs over the years that still may need rethinking - there's so much stuff you're forced to look at just to accomplish your task.
o.. The unique styling between label and value. I think we actually need to do better here, but making it very clear at a glance: this is what the system is asking of you, this is what you're telling the system. Right now we're only doing that with font choice and dropcaps, I think we can do better.
Andy's incorporating some of these ideas into another rev with some options that he'll post before the weekend.
Thanks again for all the constructive feedback.

Came across this today, interesting idea and another take on fieldless forms. I guess the form label reduces and goes above when you click or touch into the form field?

@sciascia Yes. Google Material Design Spec on text fields has a lot of good design points to follow and learn from. All of that is in my opinion very readable, clear and pleasant to look at. And there are no hidden inputs that user has to search for so that would be a good compromise between usability and clarity.
Here are some live demos of that approach:

https://material.angularjs.org/latest/demo/input
https://getmdl.io/components/index.html#textfields-section
http://materializecss.com/forms.html

Tiny issue - missing design for "input-group".
This is very useful for working with fixed units (@, px, $) and so on.
http://v4-alpha.getbootstrap.com/components/input-group/#basic-example
I think in fieldless  it could look like this

@Siton-Design I believe input groups should already be handled. See this picture:

I'm going to close this issue and we can move discussion over to the other issue franz created. Thanks for the good discussion.


Add list of software and hardware requirements

Ideally, the only software requirement is CUDA 10 or higher (on any platform), and the only hardware requirement is an NVIDIA GPU (Pascal or newer).

At least test on DAS6, optionally DAS5
Would be nice if you have another (Linux) system available for testing
At least support Linux, testing on Windows and macOS would be nice to have
Support CUDA 10 and up, support GPU architecture Pascal and up
We can easily support loading of different CUDA version on DAS6 for CI testing. It would be good to test multiple different versions of CUDA in the CI test.

Originally posted by @svlugt in https://github.com/nlesc-recruit/cudawrappers/issues/6#issuecomment-1055461364

fixed by #102


Add RELLM experimental LLM decoding

RELLM is a library that wraps local HuggingFace pipeline models for structured decoding.
It works by generating tokens one at a time. At each step, it masks tokens that don't conform to the provided partial regular expression.
Checked it out and got a small HuggingFace model to generate structured format easily :)

@vowelparrot Is the output from the first cell correct? I think it's supposed to illustrate that the response that's generated isn't correct, but I don't see it generating an auto-completion response

Looks good to me @vowelparrot, @nfcampos let a comment.


Implement automatic movement from A to B for the proxy object

A could be the object's current position. There should be some way to enter B and the proxy object should move to B without user input.

Its speed should be tweakable.

Prepared the scene for navigation by baking a NavMesh for humanoid NavMesh agents, added a NavMesh Agent and created a script for its movement, which uses the SetDestination method.


Raiden-CLI doesn't return transaction request

Steps to Reproduce

Using master at commit 758f7e4dc0024ff0410289ef418b66c87ba5df00
Send payment

http POST localhost:5001/api/v1/payments/0x3ed0DaEDC3217615bde34FEDd023bC81ae49251B/0x5358D52F4a4728d34676454Bdbafd129f0095831 identifier=999 amount=1

Payment request should never return

##Raiden Sender Logs
raiden.log
Proof of successful payment
(demoenv001) oliver@bbpc:~/Arbeit/github/raiden_sensor_paywall/imx_buyer$ http localhost:5001/api/v1/payments
HTTP/1.1 200 OK
Access-Control-Allow-Origin: http://localhost:*/*
Connection: keep-alive
Content-Length: 2272
Content-Type: application/json; charset=utf-8
Date: Tue, 13 Oct 2020 16:01:31 GMT
ETag: W/"8e0-7U+HDWYAzK9rbq9XddmR/spepg4"
Vary: Origin
X-Powered-By: Express

[
   ...,
    {
        "amount": "1",
        "event": "EventPaymentSentSuccess",
        "identifier": "999",
        "initiator_address": "0xbD4B4C7155F55F6051A732772589C38480E58F71",
        "log_time": "2020-10-13T15:52:10.760Z",
        "secret": "0x71c888457ad07421391220cdbf6fbba111fde24bd59d59c0ed2a17e31bcc4459",
        "secret_hash": "0xd06e57b84653144a0a645dec3498da102b9d75672a45c447840143071cc48eb0",
        "target_address": "0x5358D52F4a4728d34676454Bdbafd129f0095831",
        "token_address": "0x3ed0DaEDC3217615bde34FEDd023bC81ae49251B"
    },
   ...
]

Expected Result

Payment request returns after successful payment

Actual Result

Payment seems to be completed but the request doesn't return

Just tested here, and it works for me™. Please, make sure your clients are all at latest master commit (your linked commit comes before the capabilities adjustments, so you may have been gotten with incompatible versions there), and don't forget to:

update dependencies
build sdk (it's not built automatically on pnpm install anymore)
build cli

Mhh Updated both clients to commit c666432af0ba53e9aa3972b17351048ec91b4d8c.
Unfortunately, I still have the issue of not returning payment requests.
http POST localhost:5001/api/v1/payments/0x3ed0DaEDC3217615bde34FEDd023bC81ae49251B/0x5358D52F4a4728d34676454Bdbafd129f0095831 identifier=222 amount=1

Sender logs:
sender.log
Receiver logs:
receiver.log
Both clients indicate that the transfer was successful. I can also confirm that by calling
http localhost:5001/api/v1/payments

@andrevmatos thank you for having a look at it.
Reinstalled the light-client on both machines using the latest master and the Tx work as expected.


cmd/gc: array slice return can produce wrong result

In some circumstances, returning a slice of an array
can return erroneous results.
To reproduce the issue:
go get github.com/rogpeppe/misc/bug/bug1
bug1

I see
failure: got<PHONE_NUMBER>000000020000000000000018000000000000000000000000000000 want<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000
under go 1.3.3 and:
failure: got<PHONE_NUMBER>0000000000000000000000d838b409757f000008400308c2000000 want<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000
under go 1.4.
package github.com/rogpeppe/misc/bug/bug1
package main
import (
	"fmt"
	"bytes"
	"github.com/rogpeppe/misc/bug/bug2"
)

type X struct {
	*bug2.X
}

type Intf interface {
	Get() []byte
}

func main() {
	x := &bug2.X{T: [32]byte{1,2,3,4}}
	var ix Intf = X{x}
	t1 := ix.Get()
	t2 := x.Get()
	if !bytes.Equal(t1, t2) {
		fmt.Printf("failure: got %x want %x", t1, t2)
	}
}

package github.com/rogpeppe/misc/bug/bug2/
package bug2

type X struct {
	T      [32]byte
}

// Signature returns the macaroon's signature.
func (x *X) Get() []byte {
	t := x.T
	return t[:]
}

This bug seems to be introduced in the Go 1.1 development cycle.
Still bisecting.

It's introduced in this CL https://golang.org/cl/7214044.

Temporary workaround: -gcflags -l.
Because it's a not 1.4 regression, I think we don't need to fix it in 1.4.1
?

Maybe. But it's also a pretty bad correctness bug and now that we know about it, it's pretty bad to keep shipping it. I'll let @rsc decide.

Let's see how invasive the patch is.

The problem is that the wrapper main.X.Get is allocating
t on stack, rather on heap, despite the fact that t obviously
escapes. (so the result of Get is a slice pointer to our own
stack. we can use this fact to corrupt the Go stack, and
even worse, violate the safety by overriding pointers on
stack to point to arbitrary locations, this is indeed a very
serious issue.) Simply put, I can use this bug to write a
pure Go function that turns an arbitrary uintptr to a pointer
without using unsafe or cgo. And you can also do arbitrary
pointer type conversion using reflect. (Because every
function/method declared in the same package will be in
xtop when doing escape analysis, I'm unable to write a
single package example, at least two packages are required
to trigger the bug.)
I played with this issue for quite some time and found no
simple and obviously safe solution than to disable the
inlining of wrappers. (one line change, remove inlcall(fn)
line in the genwrapper function in cmd/gc/subr.c)
When inlining is first introduced, we first do inlining and
then do escape analysis. This is the correct way.
As the backend will allocate any var not explicitly labeled
as escaped to heap on stack, it's utterly important to
run escape analysis on every function.
The CL (7214044) violates the order of inlining first and
escape analysis, and after its submission, we found #5056,
and this issue is actually another occurrence of #5056.
The fix to #5056 made the assumption that there is
escape analysis result on the copied nodes saved for
inlining.  this is true for the example program for #5056, but
unfortunately, not true for the example in this issue.

More preliminary results:
The reason the fix to #5056 doesn't fix this issue is that
the function comes from imported functions, so it's not
on xtop, but in importlist. And also, it doesn't have nbody,
as its body is saved in inl.
However, the imported functions are incomplete in that
they don't have PPARAMOUTs in their dcl list, so we can't
just call escapes(importlist). (After fixing the ONAME to be
OFUNCDCL).
We can't do escape analysis at genwrapper after inlcalls
either without changing the escape analysis code a lot.
For example, escape analysis makes the assumption that
it won't analyze functions that have already been analyzed,
but this isn't true here.
The escape analysis code can't handle temporary assignment
in ORETURN (it assumes every assignment in ORETURN is
to the PPARAMOUT). But it's possible here, as the bufio
package has this kind of RETURN node:
.   RETURN l(154) tc(1)
.   RETURN-list
.   .   AS l(154) tc(1)
.   .   .   NAME-bufio.autotmp_0041 u(1) a(1) l(154) x(0+0) class(PAUTO)
esc(N) tc(1) error
.   .   .   NAME-bufio.ErrNegativeCount u(1) a(1) l(25) x(0+0)
class(PEXTERN) tc(1) used(1) error
.   .   AS u(2) l(154) tc(1)
.   .   .   NAME-bufio.discarded u(1) a(1) g(1) l(152) x(16+0)
class(PPARAMOUT) f(1) tc(1) used(1) int
.   .   .   LITERAL-0 u(1) a(1) l(154) tc(1) int
.   .   AS u(2) l(154) tc(1)
.   .   .   NAME-bufio.err u(1) a(1) g(2) l(152) x(24+0) class(PPARAMOUT)
f(1) tc(1) used(1) error
.   .   .   NAME-bufio.autotmp_0041 u(1) a(1) l(154) x(0+0) class(PAUTO)
esc(N) tc(1) error
I haven't explored the possibilities of moving genwrappers
before the main escapes(xtop) yet. That should be the most
correct solution.

This bug was present in Go 1.3 and the CL that introduced the bug is nearly two years old. That suggests that the failure conditions are rare enough that we can wait a bit longer to fix it. The CL that introduced the bug also shows actual library functions (sort.Strings) getting 30% faster, which is not something to roll back lightly.
I am not sure what you are saying about bufio exactly, but the code you found is in Brad's new method that didn't ship in 1.4.
If someone can show me a trivial fix that isn't "roll it back" we can consider it for Go 1.4.2. And unless Rog speaks up and argues that it's important to fix, we can leave it for Go 1.5.

Hacky workaround: https://go-review.googlesource.com/3081 .

This time for sure: https://go-review.googlesource.com/3092 .


No wrapper for System.Net.WebClient

Could not find wrapper for System.Net.WebClient class (from System.dll)

Closing as there is already a better API to mock HTTP requests.


Support for mouse events with modifiers?

Maybe useful for special-clicking on coins to open web?
https://github.com/gdamore/tcell/issues/496

This actually seems to work at the tcell/mouse-event layer, but there's no support for mouse bindings in the config file.  Plus, terminals have a habit of consuming some mouse events, so hard-coding might be a bit unsafe.


fix: Bumps Flask Caching to fix RCE vulnerability

SUMMARY
This PR bumps Flask Caching from 1.10.1 to 1.11.1 to fix CVE-2021-33026. It also removes an explicit dependency with cachelib given that its assets are provided via flask_caching.backends.
Fixes https://github.com/apache/superset/issues/25077
Here's the changelog between versions:

TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Also, please add a note in the description about removing cachelib as an explicit dependency, as it may not be obvious why that's happening.

@villebro I updated the PR description.

@michael-s-molina Flask-caching 1.11.1 does not fixes CVE-2021-33026.
Lastest version of flask-caching still relies on pickle by default for deserialization from cache storage. For example:
Memcache
Rediscache
Am I missing something?

@SCH227 It looks like the CVE is still in DISPUTED state pending additional verification. Check https://github.com/pallets-eco/flask-caching/issues/345 for more context.


You must install or update .NET to run this application.

You must install or update .NET to run this application.

App: /home/runner/work/_actions/victorx64/pr-label/v0/on-pull_request/bin/Debug/net6.0/on-pull_request
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '6.0.0' (x64)
.NET location: /usr/lib/dotnet

The following frameworks were found:
  8.0.10 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

Learn more:
https://aka.ms/dotnet/app-launch-failed

To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=6.0.0&arch=x64&rid=ubuntu.24.04-x64&os=ubuntu.24.04
Error: Process completed with exit code 1.

I updated dotnet version to net8.0.

Thanks, fixed!


File Type Support

What would you like to be added:
SPDX defines an optional FileType field. This field can take any of these values:
SOURCE | BINARY | ARCHIVE | APPLICATION | AUDIO | IMAGE | TEXT | VIDEO | DOCUMENTATION | SPDX | OTHER
We could do a rapid scan of the files and do a quick determination of the type
Ref:  https://spdx.github.io/spdx-spec/file-information/#83-file-type-field
Why is this needed:
Scanning and determining this value results in a richer SBOM.

i will take this
/assign


Sync up .gitignore

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.05%. Comparing base (910a630) to head (375830c).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1148   +/-   ##
=====================================
  Coverage   0.05%   0.05%
=====================================
  Files        476     476
  Lines      24137   24137
  Branches    4498    4498
=====================================
  Hits          13      13
  Misses     24124   24124

Flag
Coverage Δ

unittests-aries-vcx
0.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


apply-setters incorrectly adds setter tags to fields

Expected behavior
The apply-setters function only updates the value of the field targeted by the setter.
Actual behavior
If the property targeted by the setter is an empty list and the following field does not have an explicit value, the apply-setter function correctly updates the field targeted by the setter, but also incorrectly adds a setter tag to the following property.
Steps to reproduce the behavior
Package only contains a single resource:
apiVersion: v1
kind: MyKind
metadata:
  name: foo
environments: [] # kpt-set: ${env}
foo:

The function config is:
apiVersion: v1
kind: ConfigMap
metadata:
  name: apply-setters-fn-config
data:
  env: |
    - prod
    - dev

We run the apply-setters function: kpt fn eval --image gcr.io/kpt-fn/apply-setters:v0.1.1 --fn-config ./fn-config.yaml
The result is:
apiVersion: v1
kind: MyKind
metadata:
  name: foo
environments: # kpt-set: ${env}
- prod
- dev
foo: # kpt-set: ${env}

This is a duplicate of https://github.com/GoogleContainerTools/kpt/issues/1342, which we think can be a good first issue for new contributor.


[BEAM-9883] Refactor SDF test restrictions.

Refactoring the restriction used for testing SDFs. Instead of having
some obtuse behavior that we can validate, it now just contains a bunch
of flags we can flip to track that it was used in each method.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @lostluck

LGTM thanks!


train loss don't converge

I use resnet34 as the backbone, after epoch 40, the train loss becomes very large, and don't converge in the remained epoches.

Hi @cbyzju, I have fixed the training code. You can try it again.

Hi @cbyzju, I have fixed the training code. You can try it again.

Thank you for your quick reply! after removing robust train strategy, model could converge normally. Moreover, I found you add 3d joint regression paradigm with weighted_laplace_loss, is it possible to use RLE loss to get better regression result during train stage?

Thank you for your quick reply! after removing robust train strategy, model could converge normally. Moreover, I found you add 3d joint regression paradigm with weighted_laplace_loss, is it possible to use RLE loss to get better regression result during train stage?

Yes, I am working on it.


RRv4 checks and navbar components added to App

Title of change
PR number two for shaping up React React 4

Fixes the checks for valid chapter/verse
Adds navbars to the routes

Checklist

[ ] Unit tests written
[x] Manually tested
[x] New dependencies were added with yarn
[x] Prettier & ESLint were run

Deployed to: http://staging.quran.com:32887

@mmahalwy manually tested and there are lot of breaks:
http://staging.quran.com:32887/1:1 => Should redirect to /1/1
http://staging.quran.com:32887/001  => Should redirect to /1 but got 500 error
http://staging.quran.com:32887/1:120 => Should redirect to invalid-ayah
Jump to Surah or Ayah is breaking on Surah page.

@naveed-ahmad okay, good to know. Thanks for doing this. I will add tests and fix these

rebuild

rebuild

Deployed to: http://staging.quran.com:32892

Going to merge this. Iterating on it on staging


Remove is_web_instance logic and service_type property

RuntimeContainer has a service_type property that's either "web" or "worker". The only place we use this property is in the is_web_instance method, and the only purpose of that method is to avoid redundant metrics from being reported on worker containers.
This is not necessary, though, because worker containers won't have web metrics to report. The WebMetricsCollected can be allowed to run on worker containers, and it'll essentially be a no-op.

Fixed in #67.


Allow using a bare TOTP token instead of an otpauth:// URL

If an otpauth:// URL is not present, but totp: or totp-secret: is available, then use that with the default settings for generating an OTP code.

I don't use OTP via pass so I can't really test this, but the change looks all right to me.
Let me ping @qbit who implemented the OTP support, if he doesn't have objections until the next release, I'll merge.

This is more in line with how it's done in gopass. Tests fine for me.


feat: add support for bg as true

Description

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


doc: add readme_cn

What type of PR is this?

doc
What this PR does / why we need it (en: English/zh: Chinese):

en: add Chinese version README
zh: 添加中文 README
Which issue(s) this PR fixes:

/LGTM


Baseline Rubocop compliance

Rubocop violations
+---------------------------------------+------+-------------------------------------------------------------------------------------------------------------------------------+
| File                                  | Line | Reason                                                                                |
+---------------------------------------+------+-------------------------------------------------------------------------------------------------------------------------------+
| db/sample_data.rb                     | 54   | Redundant curly braces around a hash parameter.                                                                               |
| db/sample_data.rb                     | 54   | Space inside { detected.                                                                                |
| db/sample_data.rb                     | 54   | Space inside } detected.                                                                                |
| db/sample_data.rb                     | 56   | Unused block argument - n. You can omit the argument if you don't care about it.                                            |
| db/sample_data.rb                     | 70   | Unused block argument - n. You can omit the argument if you don't care about it.                                            |
| db/sample_data.rb                     | 83   | Space inside { detected.                                                                                |
| db/sample_data.rb                     | 89   | Space inside } detected.                                                                                |
| spec/main/shared/app/main_people.rb   | 3    | Redundant curly braces around a hash parameter.                                                                               |
| spec/main/shared/app/main_people.rb   | 4    | Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.                  |
| spec/main/shared/app/main_people.rb   | 10   | Indent the right brace the same as the first position after the preceding left parenthesis.                                   |
| spec/main/shared/app/main_posts.rb    | 3    | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.                           |
| spec/main/shared/app/main_posts.rb    | 4    | Extra empty line detected at block body beginning.                                                                            |
| spec/main/shared/app/main_posts.rb    | 6    | Redundant curly braces around a hash parameter.                                                                               |
| spec/main/shared/app/main_posts.rb    | 7    | Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.                  |
| spec/main/shared/app/main_posts.rb    | 12   | Indent the right brace the same as the first position after the preceding left parenthesis.                                   |
| spec/main/shared/app/main_posts.rb    | 15   | Unused method argument - slug. If it's necessary, use _ or _slug as an argument name to indicate that it won't be used. |
| spec/main/shared/app/main_posts.rb    | 15   | Surrounding space missing in default value assignment.                                                                        |
| spec/main/shared/app/main_posts.rb    | 16   | Redundant curly braces around a hash parameter.                                                                               |
| spec/main/shared/app/main_posts.rb    | 17   | Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.                  |
| spec/main/shared/app/main_posts.rb    | 25   | Indent the right brace the same as the first position after the preceding left parenthesis.                                   |
| spec/main/shared/app/main_projects.rb | 4    | Surrounding space missing in default value assignment.                                                                        |
| spec/main/shared/app/main_projects.rb | 5    | Redundant curly braces around a hash parameter.                                                                               |
| spec/main/shared/app/main_projects.rb | 6    | Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.                  |
| spec/main/shared/app/main_projects.rb | 17   | Indent the right brace the same as the first position after the preceding left parenthesis.                                   |
+---------------------------------------+------+-------------------------------------------------------------------------------------------------------------------------------+

  Generated by :no_entry_sign: danger


feat/refactor_argo_cd_app_project

Title
feat/refactor_argo_cd_app_project
Description
Refactoring Argo-CD AppProject
Changes

examples
templates
test-values
chart

Command Input:
./scripts/helm_chart_test.sh charts/common-library charts/common-library/examples/ArgoCD_AppProject.yaml

Command Output:
==> Linting charts/common-library
1 chart(s) linted, 0 chart(s) failed
Source: common-library/templates/ArgoCD_AppProject.yaml
apiVersion: argoproj.io/v1alpha1
kind: AppProject
metadata:
name: test-project
namespace: default
spec:
description: test-project
clusterResourceBlacklist:

group: ""
kind: Namespace
clusterResourceWhitelist:
group: ''
kind: ''
namespaceResourceBlacklist:
group: ""
kind: ResourceQuota
group: ""
kind: LimitRange
group: ""
kind: NetworkPolicy
namespaceResourceWhitelist:
group: apps
kind: Deployment
group: apps
kind: StatefulSet
roles:
description: Read-only privileges to my-project
groups:

my-oidc-group
name: read-only
policies:
p, proj:my-project:read-only, applications, get, my-project/*, allow

description: Sync privileges for guestbook-dev
jwtTokens:

iat:<PHONE_NUMBER>
name: ci-role
policies:
p, proj:my-project:ci-role, applications, sync, my-project/guestbook-dev, allow
destinations:

namespace: guestbook
server: https://kubernetes.default.svc
sourceRepos:
'*'


No Reset Filter option extractor hood

Not sure if tis counts as an issue, but i am missing the "reset filter" option in the integration. I do have this in the HomeConnect App.
Was hoping on not needed that app anymore but find no way to reset the filter notification from my siemens extractor hood,

The mobile app is using a private API and can do more things than the integration. To check if this is even possible please press the "Home Connect Debug Info" button in the HA UI and upload your log file here.

To check if this is even possible please press the "Home Connect Debug Info" button in the HA UI and upload your log file here.

Thank you for the information.
Is this what you mean?
home-assistant_home_connect_alt_2024-02-21T11-28-50.149Z.log

Found it :)
Is this one correct?
home-assistant_home_connect_alt_2024-02-21T19-05-09.508Z.log

Yes, that's right.
I see you have several appliances but you didn't specify which one you're trying to reset. I'm guessing it's the hood.
The hood doesn't seem to offer a direct why to do what you want. It may (not sure at all) be possible to do it using the BSH.Common.Command.AcknowledgeEvent command, however, you will have to know the name of the event that indicates a dirty filter. In the log I don't see that you are getting that event. If you really want to try this you'll have to listen to events published by the integration, or scan through your logs when debug logging is enabled for the integration and look for an event that indicates the filter needs to be clean/replaced. If you actually find such an event then let me know and I'll explain what you need to do with it.

I believe the relevant events are:
Cooking.Common.Event.Hood.GreaseFilterMaxSaturationNearlyReached
and
Cooking.Common.Event.Hood.GreaseFilterMaxSaturationReached
However, I do not know how to perform the reset.

You can try using the Run Command service, use "BSH.Common.Command.AcknowledgeEvent" as the command key and either of those event keys as the value.

Thank's for the explanation,
I never worked with evets jet, tbh i do not know what to do/try now 🙈
Do you meen the events like discribed here?
https://www.home-assistant.io/docs/configuration/events/

You said you already know the names of the events, so you can just go ahead and try calling the service, as I explained above, and see if that works.

You said you already know the names of the events, so you can just go ahead and try calling the service, as I explained above, and see if that works.

No that was not me :P  but i will try in when i am home :)

It was me, just chiming in.
The available events for Home Connect are documented here. The ones of interest in this discussion can be found by searching for "GreaseFilter". I have not found any documentation on resetting the filter. AcknowledgeEvent would be my only guess.
FWIW, a good resource for undocumented Home Connect features is the Homebridge implementation located here. I don't believe he has a reset for the hood filter either.

I tried this command, not sure if it is the correct way to use?

But gives an error.
I do not have a "saturated" hood atm. So will try when it is 100% again.

Please try version 1.1.3, it should fix this bug. That still doesn't mean the command will actually work but if it fails the error should come from the Home Connect API saying it's not supported or something like that.

As you expected:
2024-02-24 08:22:57.711 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [139779413723072] Error handling message: Command value: Cooking.Common.Event.Hood.GreaseFilterMaxSaturationReached not supported (home_assistant_error) Denny Page from <IP_ADDRESS> (Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.3.1 Safari/605.1.15)
If I come across the undocumented command that resets the filter, I will let you know.

Yeah, unfortunately their public API is limited compared to the internal API used by their mobile app.
I'm going to close this issue now as it doesn't seem possible.


feat: add --to argument to diff else it can only use the default buildDir

This makes it compatible with the build command. Else build builds to its own, but diff still creates the .sst/dist folder, and that does not work well within nx.
As we know have to provide arguments to build and deploy to make this work, I suggest buildDir becomes a single setting at a single spot somewhere.

Oh cool didn't notice this in your replies on Discord. @thdxr let's take a look?


lakeFS Hadoop FileSystem: make Hadoop a provided dependency

And run all tests on Hadoop 2 and 3.
Jar was tested on Databricks 10.4 (Spark 3.2.1)
Resolves #3956.

@arielshaqed, thanks for the review. Regarding your comments:

I have tested the basic functionality (reading and writing a dataframe) in DataBricks. Do you have ideas for a more thorough testing?

I'm assuming you're referring to the code in MetadataClient.java, where we try to get the object metadata in various ways. I've tested it and it works as expected*. In any case, I don't think we create an instance of the S3 client in our code.

With Hadoop <3.2, it uses the first fallback - getting S3 client from the FileSystem. With Hadoop >= 3.3, it actually uses the abstraction of FileSystem to directly get the metadata, which is the first thing we try.


Breakpoint exception

Operating System
osx 13.0
Ruby version
3.2.0
Project has a bundle

[X] Has bundle

Ruby version manager being used
rvm
Description
When I click execute, the error is reported as shown below

Closing this for now. Please let us know if you're still having issues in the latest versions.


Invoke-WebRequest -PassThru, when combined with -OutFile, should reflect the download file path.

Summary of the new feature / enhancement
Thanks to a contribution by @CarloToso, since v7.4.0 it has been possible to pass a directory  rather than a file path to -OutFile, in which the web cmdlets use the (ultimate) target URL's last segment as the file name.
Given that, when redirections are involved,  you won't know what that last segment is, being able to programmatically discover the resulting full download file path is important.
This will also apply to the planned support for using a  server-suggested output file name via a Content-Disposition response header field - see PR https://github.com/PowerShell/PowerShell/pull/19385
(Using -Verbose is a way to discover the file name interactively; while it's technically possible to programmatically parse the verbose output, that would be both cumbersome and brittle).
Thus - at least when -OutFile is used - the [Microsoft.PowerShell.Commands.WebResponseObject] instance returned via -PassThru should have an .OutFile property or similar that reflects the output file's full path.
Related:

#21081

Proposed technical implementation details (optional)
I don't know whether it's worth extending [Microsoft.PowerShell.Commands.WebResponseObject] or not.
If not, an ETS NoteProperty member could be used.

@PowerShell/wg-powershell-cmdlets discussed this, we agree that since the information is already available, it makes sense to have it as a NoteProperty rather than in the verbose stream


export_fig('-update') does not replace old version

export_fig('-update') in v3.0.5 (and earlier versions) creates a subdirectory export_fig-master in the path of the current version so that the current (old) version would not be replaced. I guess the zip file should be downloaded & extracted in a temporary directory first, and all files within the export_fig-master should be moved to the path of the current version?

This issue is expected to be fixed in the latest version (that I just uploaded). You will still need to download and install the new version, but after you install it then all the subsequent updates should be much easier, using the export_fig('-update') mechanism.


[release-1.4] improve cache performance, clarify variables

This is an automated cherry-pick of #18119

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
191e077c69265c5e9a741ce0b52d3df31ac7325d
link
/test lint_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.4
191e077c69265c5e9a741ce0b52d3df31ac7325d
link
/test lint_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
191e077c69265c5e9a741ce0b52d3df31ac7325d
link
/test e2e-simpleTests-distroless_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest
lint failure fixed in another pr

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio_release-1.4
191e077c69265c5e9a741ce0b52d3df31ac7325d
link
/test integ-pilot-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Addon won't open properly

Hi, sorry to be the bearer of bad news again! The addon won't open properly on 2 kodi installs since the update to 1.05/1.06. When I click on it just shows a blank screen, like the standard blank screen from before in the few seconds before the guide opens, but now the guide/channels won't display at all. Getting log errors on both boxes.

Hi, a quick update - I've reverted to 1.0.0, 2.0.9 and 2.1.3 and clear cache after but they all had some issues. Then downloaded zip made 10 minutes ago and it now shows the information for all programmes. Tried both safe mode on/off and ok does nothing. When I right click and 'play from here' it throws up a log error on every channel, and for some reason starts playing irishtv (which seems to work flawlessly).
Earlier I used iVue creator which basically scans video addons and extracts their play button for use with a tv guide. It worked fine and played every channel, though it needed to be updated every few hours due to the nature of ietvnow. This no longer works, and throws up a log error.
Thanks again for the help, don't mean to hurry you along, but thought I'd give an update on the issue.
As a matter of interest how has ietvnow been working on your box? Thanks.

Hi, you've done it! I turned on safe mode and cleared cache. When I go into the addon and right click 'play from here' things are working. Thanks a million!


Fullscreen support

Hello @Igor-Vladyka . I am trying to print my map into PNG format.  I'm not sure if it's a bug on domtoimage plugin or on this plugin but I noticed that it does not support printing on fullscreen mode. I'm using this plugin -> https://github.com/Leaflet/Leaflet.fullscreen.
This the result I often get is like this

Tried it on Chrome and Firefox (latest version for both browsers)  sometimes it's even exporting into .txt file if I include the documentTitle option
Appreciate the help!

Here's the proof where it exports it to .txt file

Hi,
You don't need fullscreen plugin to export/print map. browser print plugin isolates map + needed content(in this case there will be no additional content), creates fullscreen overlay and then zoom map to fit needed size.
In this case, fullscreen plugin somehow overrides plugin behavior.
So, actually - you just need to specify correct map(paper/image) size to print plugin and it will do everything else.
Please let me know if you have any other questions, and/or problems, I'm ready to help.
Regards,
Igor


[Feature Request] Bind value to the URL path. eg: /books/{id}/show

Is your feature request related to a problem? Please describe.
Currently there is Query tab to set query parameters. But i want to set parameters in path too.
Describe the solution you'd like
Bind the values to the url path template.
Thank you!

Something like Retrofit @Path("id") id: Int

You can set various tags in the path already. Hit ctrl + space to bring up the list.
There are all sorts of things you can configure

Prompt the user to type the value in before sending the request
Use an environment variable
Extract a property from another request in the workspace

thanks for answer sir, but i actually want that url value is set in UI like Query form, not defined via the environment

You can use a Prompt Tag to do that. When you send the request it will pop up a dialog asking you to enter the value of the placeholder.

using the prompt is slower since you have to click twice to send an http request

#203 would fix this issue for me

?


Handle responder_url edge case

In the 2.0.1 spec for AuthorizeRequest and GetCertificateStatusRequest there is a field responderURL that does not get converted from snake_case responder_url to camelCase responderURL. This PR adds handling of this edge case. in SetNetworkProfileRequest there is a field ocppCsmsUrl which is handled correctly but causes problems for a more general solution.
Let me know if the conditionals work for you.

@Jared-Newell-Mobility This one is also required for a v1 release. You can take it over the issue and finish it.

Thanks for highlighting this, it has been replaced with PR https://github.com/mobilityhouse/ocpp/pull/592, so it will close for now


Use hidden directory for config on Linux

This PR moves the config directory to ~/.GPMDP_STORE - a hidden directory, as is customary on Linux.
Linux users go to great lengths to make the home dir tidy, and then there's this, in all caps and visible!
Small downside is that Linux users will lose their config with this update, but it's worth it.
I have also abstracted the config directory resolution to it's own file. Please check if it's still working OK on Win and Mac.

#287 probably solves this better, but I think moving this logic to it's own file is a good idea.

Why not both? ;) I do think that respecting the XDG directories (putting it in ~/.config) is a good plan.

well that's what I meant :P
feel free to steal that piece from my PR, as it'll get closed anyway

I agree with @Polymetric
I like the idea of moving the "config/data" file creation to a separate file.  It will make the logging work I'm about to start much easier.
If @Polymetric can steal that file and implement it into his PR I'll merge that one :+1:


MSTest is broken when using deployment items

          Hi guys, I'm having the same issue on VS 2022 LTSC 17.8.10. I upgraded my VS last night along with installing Python extensions and my test project running on .Net Framework 4.8 started failing with the same issue. First, I tried updating the MSTest Nuget to the latest 3.4.0 and it didn't solve the issue, with/out DisableAppDomain. The only thing that worked for me is downgrading MSTest to 2.2.6

So, is there a valid fix to this?
Originally posted by @ndenkha in https://github.com/microsoft/testfx/issues/1493#issuecomment-2128179533

Yesterday everything is fine. But today I experienced some similar issue,  when I had updated the depended:

MSTest.TestAdapter
MSTest.TestFramework
;

I looked into the output panel by selecting "Test" there. It complains :
-------begin---------
Could not load type 'Microsoft.VisualStudio.TestTools.UnitTesting.TestIdGenerationStrategy' from assembly 'Microsoft.VisualStudio.TestPlatform.TestFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
-------end--------
The "Debug Tests", activated from context menu, finished silently. And the status bar sometimes displayed:
tests aborted: 0 tests run ... ( or something like that).
I then created a brand-new unit test project in visual studio, and found it works fine (that is: no above issue). I then noted from its dependencies for that two packages, and each is versioned at 2.2.10.
I tried to downgrade the two package to the immediate previous version, but the resulted project still did not work (for this step, I didnot investigate thoroughly; so I am not sure whether there might be other reasons that would contribute to the problem, making it not work).
I finally downgrade the two packages to v2.2.10, and also cleaned some residue "imports" of any unwanted test packages in the ".csproj" files ( and also commented some "error" template message in the ".csproj", but that is just a preempt preventive measure, and I am not sure that would contribute to the issue). I also deleted "bin/" and "obj/" folder, just in case, and inspected the references and the "packages.config" file to make sure nothing looks suspicious.  And it finally worked.

Looks like it could be related to #2922 where regression in assembly resolving was introduced.

I have tried with the repro file from the original issue and couldn't repro the issue on 3.4.0 so I will need you to provide us with a reproducer for the bug. As pointed out by @nohwnd we had an issue with the assembly resolver that plays part in the deployment feature so it's most likely linked.

Probably related to #3019


Add common conditions

Mirrors https://github.com/bevyengine/bevy/blob/main/crates/bevy_input/src/common_conditions.rs

Looks like CI fails, but the error is unrelated to the PR.

Right, I thought that markdown lint failed because of this:
 2023-03-20 23:16:49 [ERROR]   Failed to get [GITHUB_TOKEN]!
2023-03-20 23:16:49 [ERROR]   []
2023-03-20 23:16:49 [ERROR]   Please set a [GITHUB_TOKEN] from the main workflow environment to take advantage of multiple status reports!

But the actual error was this:
2023-03-10 21:40:29 [ERROR]   Found errors in [markdownlint] linter!
2023-03-10 21:40:29 [ERROR]   Error code: 1. Command output:
------
/github/workspace/RELEASES.md:9 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2]
------


jsx-a11y/anchor-is-valid

I have a Link component:
class Link extends React.Component {
  render() {
    const { to, children, ...props } = this.props;
    return (
      <a href={to} {...props} onClick={this.handleClick}>
        {children}
      </a>
    );
  }
}

And use it like this:
<Link to="/somewhere">Link</Link>
But I am getting ESLint error The href attribute is required on an anchor. Provide a valid, navigable address as the href value  jsx-a11y/anchor-is-valid
P.S. This Link components is a part of react-starter-kit by kriasoft

You'll have to provide settings that denote to as a "specialLink" property; see the rule docs.

FYI, here's a link to the rules docs

This worked for me (.eslintrc):
{
  "rules": {
    "jsx-a11y/anchor-is-valid": [ "error", {
      "components": [ "Link" ],
      "specialLink": [ "to" ]
    }]
  }
}

This worked for me:
.eslintrc
{
  "rules": {
    "jsx-a11y/anchor-is-valid": [ "error", {
      "components": [ "Link" ],
      "specialLink": [ "to" ]
    }]
  }
}

Sorry to necro a closed issue, but this came up when searching around to debug a similar issue I had. This was the solution I came up with, figured I'd share it for future debuggers.

If it’s an a, it should always have an href as a noJS fallback.

Or put another way - if it doesn’t have a url, it’s not semantically a link.


How to set up and run test in Angular?

I have a project using Angular and Electron, now I want to set up spectron for a testing so can I set up spectron with Karma or Protractor?
If setting up spectron either with Karma or with Protractor doesn't work, then what should I do to apply spectron for Angular and Electron to my project?
Thanks in advance?

I think you are missing the point slightly. Spectron is an end to end testing tool like Protractor. Unlike Protractor which is designed for webpages, Spectron is designed for Electron applications. You don't setup Spectron with Protractor, you use Spectron instead of Protractor.
When it comes to running unit tests with Karma you can start with looking at this
https://github.com/colinskow/angular-electron-dream-starter
This starter has Karma and Jasmine set up by default. You can check how they did it and copy it for your project, doing adjustments where necessary.
Hope this helps


Smart Contracts

Does this API have the capabilities to interact with Smart Contracts? Please respond.

In what way? I have not implemented the encodeParams and decodeParams from ethers.js yet, if that is what you need, but this will be coming in the future.
As for calling and sending transactions, that can be done through the Provider class.

Do you have timeline for the encode/decode ABI functions/parameters? We are very looking forward to it. :)
Thanks!


getContouringCost() detailed description

Hi, @alexliniger.
Thank you for your contribution!
I successfully run the C++ execution. Then I have been trying to understand your codes but confront the difficult parts about getContouringCost() function:
https://github.com/alexliniger/MPCC/blob/84cc61d628a165a424c805bbe071fe96b88da2d0/C%2B%2B/Cost/cost.cpp#L140
I don't understand (1) why partial derivatives(gradient) of contouring error are included in Q_contouring_cost and (2) why contouring_error_zero is multiplied by d_contouring_error:
https://github.com/alexliniger/MPCC/blob/84cc61d628a165a424c805bbe071fe96b88da2d0/C%2B%2B/Cost/cost.cpp#L164
https://github.com/alexliniger/MPCC/blob/84cc61d628a165a424c805bbe071fe96b88da2d0/C%2B%2B/Cost/cost.cpp#L170
I already read your paper about Optimization-Based Autonomous Racing of 1:43 Scale RC Cars . I guess $\Gamma_k$ may means the corresponding matrix operations but couldn't find the detailed description.
Please help me if you possible.
In advance I appreciate it.
Regards.

I found the similar issue (https://github.com/alexliniger/MPCC/issues/29).
However, What I don't understand is that the cost should be calculated by $\Delta x ^ T$ and $\Delta x$ with Hassian matrix but MPCC contouring quadratic cost function is calculated with just $x^T$ and $x$. Or am I misunderstanding?
In short, I want to know which of states or states's differences are calculated when cost matrices are calculated into scalar cost.
If $x_k$ is multiplied with quadratic cost matrix($Q_k$), I wonder what I didn't catch.

The paper is maybe a bit misleading since we tried to formulate it nicely as a cost function, but not necessarily how you would implement it. Γ is the weight matrix and most of the complexity of what you can find in the code is part of the term around Γ.
Regarding Δx vs x, I deal with this using the constant term discussed in this comment https://github.com/alexliniger/MPCC/issues/29#issuecomment-774301971
Δx = (x - x0). Depending on the implementation this term is used differently. The master implementation follows the paper, the implementation in the two other branches is a more classical SQP approach where the optimization variable is Δx.

Hi, @alexliniger.
why contouring_error_zero is multiplied by d_contouring_error in q_contouring_cost?

Thank you @alexliniger ,I just sent you an email to your gmail detailing my confusion.Hope to get your guidance

@alexliniger Your explanation is very detailed and I have understood it


Filter panel

Hi,
The branch at http://github.com/ketan/rack-bug/tree/filter-panel contains some support for rendering the timings on rails before/after/around filters.
I understand that this may not quite be upto any rack-bug standards, so I'm open to any feedback to help improve this patch.
Thanks for a great plugin!
-- Ketan

I'd still merge this in happily with a few more specs.


[Bug] the assets version of v2.15.5 are still v2.15.4

📦 Deployment Method
Other
📌 Version
v2.15.5
💻 Operating System
macOS
📌 System Version
15.1
🌐 Browser
Chrome
📌 Browser Version
版本 129.0.6668.100（正式版本） (arm64)
🐛 Bug Description
i have tried to download v2.15.5, but the assets are still v2.15.4

📷 Recurrence Steps
No response
🚦 Expected Behavior
No response
📝 Additional Information
No response

fixed.
thank you!


chore: change codeowners

Checklist

[ ] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[ ] Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
[ ] The description lists all applicable issues this PR seeks to resolve
[ ] The description lists any configuration setting(s) that differ from the default settings
[ ] All tests and CI builds passing

Description
Changes code owners from Conveyal to IBI Group.

Codecov Report

Merging #511 into dev will decrease coverage by 11.86%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              dev     #511       +/-   ##
===========================================
- Coverage   28.07%   16.21%   -11.87%
===========================================
  Files         313      313
  Lines       16881    15735     -1146
  Branches     5166     4795      -371
===========================================
- Hits         4740     2551     -2189
- Misses      10477    11261      +784
- Partials     1664     1923      +259

Flag
Coverage Δ

#end_to_end_tests
?

#unit_tests
16.21% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

lib/manager/components/validation/TripsChart.js
0% <0%> (-80.4%)
:arrow_down:

...nager/components/validation/ServicePerModeChart.js
0% <0%> (-78.27%)
:arrow_down:

lib/manager/components/HomeProjectDropdown.js
0% <0%> (-75.76%)
:arrow_down:

...b/manager/containers/ActiveFeedVersionNavigator.js
0% <0%> (-67.5%)
:arrow_down:

lib/manager/components/version/VersionDateLabel.js
0% <0%> (-66.67%)
:arrow_down:

lib/common/util/maps.js
25% <0%> (-62.5%)
:arrow_down:

lib/manager/components/CreateFeedSource.js
24.48% <0%> (-61.96%)
:arrow_down:

lib/admin/components/UserRow.js
0% <0%> (-57.9%)
:arrow_down:

lib/common/containers/App.js
0% <0%> (-56.63%)
:arrow_down:

lib/manager/components/ManagerHeader.js
0% <0%> (-55.89%)
:arrow_down:

... and 232 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff4194...8383cc8. Read the comment docs.

:tada: This PR is included in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Handling with constants

All constants should be in one place with good description, all of them needs to be realted to pond dimensions (Or other stuff if it would be better)

co robimy z tym issue?


Update app version to v3.0.0

This should not be merged before the iOS build has been created and published as a new version number forces a new approval process for the app whereas keeping the same version number skips the approval process.


Add IVORY in CSS frameworks

Add IVORY - https://github.com/IVORY-UI/ivory in CSS frameworks.

@kanthvallampati Looks like the website is down at http://ivoryui.com/ can't look at the documentation.

@Alaev The website is up. Kindly check the documentation.


Re-addition of std::net::IpAddr

(Firstly, I saw the discussion around its removal in #923, but that decision appears to have been made before SocketAddr was decided to have an enum structure like that of IpAddr. I'm thinking maybe it was an oversight that IpAddr was left out after that decision. In case it wasn't an oversight, here's my argument in favor of re-introducing IpAddr.)
I propose that the type IpAddr, as an enum with V4(Ipv4Addr) and V6(Ipv6Addr) variants should be re-added to std::net. In my experience, it is often necessary to express an IP address that is either IPv4 or IPv6 without the address being associated with a socket and, therefore, it not having an associated port value. For example, when a server retains the remote addresses of past clients. In such cases, it is not intuitive to store such an address as a SocketAddr instance. Also, the re-addition would mirror the SocketAddr enum, which itself has V4 and V6 variants containing structures to the specific types.
Additionally, I propose that the std::net::LookupHost type should be reverted to yield IpAddr types rather than SocketAddr as this also permits dealing with hostnames in cases where they are not directly related to any socket operations.  It should be noted that the ToSocketAddrs trait is already widely used within std::net to yield a series of SocketAddr instances and keeping lookup_host as-is would constitute a duplication of this functionality.
With these changes, I think it would also be helpful to add a convenience method for creating SocketAddr instances; e.g. fn new(ip: &IpAddr, port: u16) -> SocketAddr.

I missed the discussion around the RFC changes. I apologize if this isn't the usual way to bring up a discussion, but I feel like it's really clunky to have to make my own IpAddr enum in every net-related library and I hoped to have my concerns heard before the standard library became more difficult to change.
cc @carllerche @alexcrichton

cc me

@murarth I agree w/ you. I didn't really notice the removal of IpAddr in the RFC.

Another point to add, joining / leaving multicast groups should take an IP address as an argument, not a socket address as it does currently.

I agree with this issue -- I think this was an oversight in considering the usage too narrowly. @alexcrichton, I believe, agrees; I think we can file a PR together with an amendment.

+1. ran into this last night. it absolutely makes sense to have an enum over addres types irrespective of having a particular to connect to.

Also revert UdpSocket join_multicast() and leave_multicast() to take an IpAddr.  Could be others like these too.

This was re-added some time ago, so closing!


Managing acess rights using Akita

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

How about a blog post (or a recipe in the documentation, or just a couple of tips) which describes managing access rights, roles, and user groups using Akita? Would be great to see something like that.Thx :)

Will do. Thanks for the suggestion.

Hey, just wanted to say that I didn't forget you. I have an article about this topic, will publish it soon.

Here is an article about the topic. If you have any further questions, let me know.
https://blog.ng-book.com/managing-user-permissions-in-angular-using-akita/

I am wondering if you figured out any good solution for your problem? I want to have a dynamic Model the same as you.

Here is an article about the topic. If you have any further questions, let me know.
https://blog.ng-book.com/managing-user-permissions-in-angular-using-akita/

Hi, I would like to ask you.
`    <button *hasPermission="['write', 'admin']">Delete

You have this part of code. But you didn't showed how you handling this issue when you admin+[array of roles] or you have an inherited roles like each role has base functionality which is inherited from the parent or grandparent object.


Unconfuse parse_validate API

Sometimes we want to validate and parse an identifier, and sometimes we only want to validate. Have separate calls for that.
Make ParsedUri more useful by also using it for acct: URIs; new subclasses; move to utils
Better invalid-URI checking

Did you intend to assign this PR and #127 to me, or were you just requesting a review?

I did if that's okay. I always feel very strange if I approve my own PRs, I mean not that I'm beyond disagreeing with myself, but the disagreement is more likely going to be useful coming from somebody else...


Fix flake errors, assuming line length of 120 chars

This is a purely cosmetic set of changes to help flake8 to be quiet.
In some environments flake8 is run through the CI system blocking PRs which have flake errors in them - this may save some others a little pain.
The changes were made assuming a 120 line length which was inferred from the code

This is cool, thanks. Maybe we should also drop a few lines into README explaining how to use this thing?

I have added another commit with some info in the README.md. I ended up adding a setup.cfg for flake8 too so that people don't have to configure it themselves for the project. it's possible in the future the project will decide some errors are not important and this gives us a way to do this for everyone running flake.


raw base64url consistency?

ACA-Py seems to be permissive, in a certain sense, with the format that a base64 attachment payload can take: b64_payload = unpad(set_urlsafe_b64(self.base64, True)). However, this still enforces that the message sender must convert their base64 payload to rawURL format.
For interop, we'll need to decide how we standardize, and ensure it gets into AIP2.0. aries-rfcs/#561 (and also specifying whether to include/exclude padding), for total consistency? If that's not possible, do we push to standardize attachment signatures on the way you're converting a base64 payload to unpadded base64URL?

In several of the RFCs there is a line like this -- "NOTE: In receiving the out-of-band message, the base64url decode implementation used MUST correctly decode padded and unpadded base64URL encoded data."
Is that what we are talking about?  Deeper than that?

That part is good, however when attachments are signed, then either:
A. The recipient converts the payload to unpadded base64URL when assembling the detached payload and protected header into the signed data to verify the signature, in which case the sender must also convert the payload to unpadded base64URL to construct the signature.
or
B. The recipient must accept the payload with or without padding, using it as-is when assembling the detached payload and protected header into the signed data for verification, in which case the sender is free to pad or not pad their attachment payload, and have less special handling to do when signing.

Not sure if I'm missing something here, but signatures should be over the raw bytes of the payload, not the base64URL representation.

The decision made by the community is to send everything as base64url, but when decoding, accept either base64 or base64url, so if we are still receiving base64, everything still works. Note that we already (should be) decoding base64 with or without padding.
Here is a stackexchange on base64url decoding: https://unix.stackexchange.com/questions/628842/decode-encode-base64url-with-common-unix-tools
For ACA-Py, I think we need to do this:

change decode to handle either as input.  I think that means just assuming everything is a base64url, as if it is was encoded with base64, it will still work.
if the "AIP 2.0" flag command line flag (we have that, don't we?) is set, send everything as base64url
otherwise, leave what we are doing today (and a note on this issue what we do today).

Hope that makes sense.  @shaangill025 -- could you please take this one?


Cleanup tests

Reduced duplicate code.
Fixed warnings in generated code.
Added tests/no-std to main workspace members.

bors r+


Is overall suite status available within the suite?

I'd like to write the test status to an API for general reporting when the suite completes.  It would be more convenient to do this in a config.after(:suite) block rather than wrapping rspec and reading the exit code.  Is there an rspec API that can be used to read the suite status from within the suite?
Looking at https://github.com/rspec/rspec-core/blob/main/lib/rspec/core/runner.rb#L113-L126 it doesn't look like there is an overall pass/fail variable that can be read.  Instead it looks like to send notifications about the suite run from within the suite I'd need to use the config.reporter.register_listener hook and track overall pass/fail myself.  Is that accurate?

That's correct. Listen to :example_failed, :example_passed and :stop, should provide you with all the information you need. RSpec.world.non_example_failure might be of some interest to you as well.
If you get stuck with something, please let us know on the mailing list, or use StackOverflow. http://rspec.info/help/
We strive to limit Github issues to bugs and enhancement requests.

Not quite but you can listen to dump_summary which is called at the end of the suite, it gives you duration, examples, failed_examples, pending_examples, load_time and errors_outside_of_examples_count.
A suite will fail if it has any failed_examples or any errors out of examples.


Cleaning the Tests - 1

adding extra params to insert_into
creating some toolbox functions: dataset_reg, dataset_cl and dataset_num to simplify the tests
cleaning the headers
seeding the randomness of RF, XGB and Bisecting KMeans

Files to look at:

toolbox
vmodel

What is the verticapy/.DS_Store file? Is it added by mistake?

What is the verticapy/.DS_Store file? Is it added by mistake?

Yes, I deleted it.


There is no option to specify tenant ID in a multitenant environment

There is no option to specify tenant ID in a multitenant environment. Adding ?tenant=sometenantid to the URL does not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cdd3eb8d-0f4f-e8cd-7ed3-5ceccc433ddd
Version Independent ID: 2164905a-fae3-c9e8-a62f-08d9b7ac95de
Content: Connect to Microsoft Dynamics NAV with Power BI - Power BI
Content Source: powerbi-docs/service-connect-to-microsoft-dynamics-nav.md
Service: powerbi
GitHub Login: @SarinaJoan
Microsoft Alias: sarinas

Hi @jvincke, we currently do not support tenant selection for cloud instances. If you are running on-prem, the tenant is the instance you are connecting to and that is part of the URL path you enter when connecting.


Object values returned iterator is private

Hey there, thanks for the package!
It looks like, while the values function is public, the resulting iterator can't be used because it is privately scoped.
let map: Map<String, Value> = from_str(SOME_OBJECT_STR).ok()?;

for value in map.values().iter {
// ...

field iter of struct serde_json::map::Values is private

I'm a bit of a rust noob so apologies in advance if I'm mistaken here :+1:

Turns out the return type is iterable so there isn't a need to directly access iterator at .iter


Shortcut for Launch Center Pro

Hi
It would be great if launch center pro could recognize the app and create a shortcut

I'm not very familiar with Launch Center Pro, but I think the integration would have to be done on their side.
If all you want to do is launch NNW, couldn't you create a launch Shortcut in the Shortcuts app and then import that into Launch Center Pro?

Hi
It’s okay, it was just a feature request.
Here is an article for app developers describing URL schemes:
http://help.contrast.co/hc/en-us/articles/200865273
I havent looked at the IPA file for your app, but on iOS the URL scheme is part of the Info.plist package config file which is a lot of work for the user to do manually for each app they want to setup:
https://www.amerhukic.com/finding-the-custom-url-scheme-of-an-ios-app
You just fill out a short form to submit the URL scheme for your app so that launch center knows it. I do it for my ios mobile apps since a lot of developers like using launch center.
FYI shortcuts is not the preferred method for creating app shortcuts, it is very slow and always launches the shortcuts app which is very annoying.
Jeff Holmes
On Jun 23, 2021, at 1:22 PM, Maurice Parker @.***> wrote:

I'm not very familiar with Launch Center Pro, but I think the integration would have to be done on their side.
If all you want to do is launch NNW, couldn't you create a launch Shortcut in the Shortcuts app and then import that into Launch Center Pro?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

We've already got the custom URL scheme netnewswire set up on iOS.
@brentsimmons Could you fill out this form and submit it?
https://help.contrast.co/hc/en-us/articles/201402467
I don't mind doing it if you are too busy. I can fill it out with your info if you want so that you are the contact point incase something breaks.

Yes the URL scheme works. Sorry, it’s just a pain trying to find out what they are for each app.
Thanks
Jeff
On Jun 23, 2021, at 4:24 PM, Maurice Parker @.***> wrote:
We've already got the custom URL scheme netnewswire set up on iOS.
@brentsimmons https://github.com/brentsimmons Could you fill out this form and submit it?
https://help.contrast.co/hc/en-us/articles/201402467 https://help.contrast.co/hc/en-us/articles/201402467
I don't mind doing it if you are too busy. I can fill it out with your info if you want so that you are the contact point incase something breaks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/Ranchero-Software/NetNewsWire/issues/3185#issuecomment-867133081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUSD3JJZJAKLN64TOUEGSTTUI7GPANCNFSM47GGJ2ZA.


fix: Declare "EmptyObject" interface to wrap $CombinedState

name: Declare EmptyObject interface to wrap $CombinedState
about: Adding interface for $CombinedState appeases latest version of Typescript, allows exporting result of combineReducers
PR Type
Does this PR add a new feature, or fix a bug?
Fix a bug with lastest version of Typescript
Why should this PR be included?
No changes to exports are included, but the internal change from type->interface allows Typescript to correctly reference/export usage of $CombinedState
Checklist

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Is there an existing issue for this PR?

closes https://github.com/reduxjs/redux/issues/4030
Previous PR, different attempt at solution https://github.com/reduxjs/redux/pull/4026

[x] Have the files been linted and formatted?
[x] Have the docs been updated to match the changes in the PR?
[x] Have the tests been updated to match the changes in the PR?
[x] Have you run the tests locally to confirm they pass?

New Features
What new capabilities does this PR add?
None, just maintains support of typescript with latest 4.2.x releases
What docs changes are needed to explain this?
None
Bug Fixes
What is the current behavior, and the steps to reproduce the issue?
Upgrade to typescript v2.4.2
Create a file example.ts with the following content:
import { combineReducers, $CombinedState } from 'redux';

export default combineReducers({})

make sure declarations: true is in your tsconfig.json
Typescript will emit an error on:
Default export of the module has or is using private name '$CombinedState'.
Also see https://github.com/reduxjs/redux/pull/4029 for minimal reproducible issue
What is the expected behavior?
No error should be emitted
How does this PR fix the problem?
combineReducers<S>() returns a type of Reducer<CombinedState<S>>, and the CombinedState<S> is the type in question in this PR
https://www.typescriptlang.org/docs/handbook/advanced-types.html#interfaces-vs-type-aliases
Digging a bit into how Typescript works, but basically a type is an alias. So any usage of a type that internally uses $CombinedState means the resulting declaration must also use $CombinedState. Since that value is not exported, Typescript fails.
Using an interface however does not need direct access to $CombinedState, so the exporting of combineReducers will magically succeed.

It looks like the issue is more that we're saying readonly [$CombinedState]?: undefined extends just [$CombinedState]: undefined. So, just a signature mismatch that's no longer allowed.
In any case, this both resolves it and keeps it from being a likely issue in the future. Thanks!


Throwing both exception and receing track end event

After confirming that it has nothing to do with the library I'm using (wavelink.py) I wanted to ask if it's intended to raise First a TrackException and then a TrackEnd Event if the song is age restricted (doesn't work). Should it not be just an Exception or End?

If you start playing a track, you should be guaranteed that it is only ended if you receive a track end event (or you disconnect).
What is the problem with also throwing an exception?

Thats an issue with age restricted videos only, track is found, Lavalink "plays" it, instantly throws an Exception and a TrackEnd Event after a second or so. Lavaplayer didn't support age-restricted stuff till today: https://github.com/sedmelluq/lavaplayer/commit/e9a23f7df9b405bfff7bb6e90cf1a55e95a7aa53

I'm confused now.
Is this an issue about our error handling or the lavaplayer issue?
Please pick one.

I'm sorry ^^
Not my native language so hard to explain.
Lavaplayer didn't support age-restricted videos which led to my problem if you tried to play them via lavalink. Which resulted in the Exception and the TrackEnd afterwards.
But since they "patched" it works now.

Then this issue was fixed by https://github.com/Frederikam/Lavalink/commit/0ac18d970be085a6c0bf3554b127284c99bb177a


--insecure deprecation announcement; --socket update

Fixes #8397.
Fixes #8396.

For --insecure, adds a v21.1 deprecation announcement to the cockroach start parameters table and in a callout at the top of many deployment tutorials that use --insecure.

cc @jseldess in case you have suggestions on other places where this information should go.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d51e4675f82dec61bb1a1d491ab17fd631e04e09/
Edited pages:

v20.1/cockroach-start.md
v20.2/cockroach-start.md
v20.2/deploy-cockroachdb-on-aws-insecure.md
v20.2/deploy-cockroachdb-on-digital-ocean-insecure.md
v20.2/deploy-cockroachdb-on-google-cloud-platform-insecure.md
v20.2/deploy-cockroachdb-on-microsoft-azure-insecure.md
v20.2/deploy-cockroachdb-on-premises-insecure.md
v20.2/orchestrate-a-local-cluster-with-kubernetes-insecure.md
v20.2/orchestrate-cockroachdb-with-kubernetes-insecure.md
v20.2/start-a-local-cluster.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/007c66c230d1fa35174a3ce099f715e83d671aa1/
Edited pages:

v20.1/cockroach-start.md
v20.2/cockroach-start.md
v20.2/deploy-cockroachdb-on-aws-insecure.md
v20.2/deploy-cockroachdb-on-digital-ocean-insecure.md
v20.2/deploy-cockroachdb-on-google-cloud-platform-insecure.md
v20.2/deploy-cockroachdb-on-microsoft-azure-insecure.md
v20.2/deploy-cockroachdb-on-premises-insecure.md
v20.2/orchestrate-a-local-cluster-with-kubernetes-insecure.md
v20.2/orchestrate-cockroachdb-with-kubernetes-insecure.md
v20.2/performance-tuning-insecure.md
v20.2/start-a-local-cluster-in-docker-linux.md
v20.2/start-a-local-cluster-in-docker-mac.md
v20.2/start-a-local-cluster-in-docker-windows.md
v20.2/start-a-local-cluster.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/50969bca93fb000ef42eb133ded9a8f11760b8e7/
Edited pages:

v20.1/cockroach-start.md
v20.2/cockroach-start.md
v20.2/deploy-cockroachdb-on-aws-insecure.md
v20.2/deploy-cockroachdb-on-digital-ocean-insecure.md
v20.2/deploy-cockroachdb-on-google-cloud-platform-insecure.md
v20.2/deploy-cockroachdb-on-microsoft-azure-insecure.md
v20.2/deploy-cockroachdb-on-premises-insecure.md
v20.2/orchestrate-a-local-cluster-with-kubernetes-insecure.md
v20.2/orchestrate-cockroachdb-with-kubernetes-insecure.md
v20.2/performance-benchmarking-with-tpc-c-10-warehouses.md
v20.2/performance-benchmarking-with-tpc-c-100k-warehouses.md
v20.2/performance-benchmarking-with-tpc-c-10k-warehouses.md
v20.2/performance-benchmarking-with-tpc-c-1k-warehouses.md
v20.2/performance-tuning-insecure.md
v20.2/start-a-local-cluster-in-docker-linux.md
v20.2/start-a-local-cluster-in-docker-mac.md
v20.2/start-a-local-cluster-in-docker-windows.md
v20.2/start-a-local-cluster.md


Move CI to Circle

I've been happy, but lately we are seeing daily problems that are related to their infrastructure. I break CI enough without these being added into the mix, creating noise and delay.
Also it would be nice to run 5 concurrent builds ala circle/buildkite.
This is maybe not infrastructure, but apparently it's trying to run a branch that I just merged and then was deleted from github:
https://travis-ci.com/sudara/alonetone/builds/130981479

/cc @manfred — The "duplicate" branch/PR builds + the limitation of only being able to build 2 things at once is making me want to move away sooner than later.

Sure, do you want me to help you with that somehow?

Sure! This would be useful maybe after #793
We keep seeing errors of many flavors, latest one here: https://travis-ci.com/sudara/alonetone/builds/131839631?utm_source=slack&utm_medium=notification
I just don't know where it's most straightforward. Circle says we get to build 4 containers, not sure if that's by default or if I have to contact them. https://circleci.com/pricing/#faq-section-linux

I actually am not very well educated on what the options are. I guess Circle would give us slightly more parallel jobs and I'm moving https://github.com/sudara/stitches to it, so we could do that.

Wishlist:

Move to circle workflows 2.1
Cache as much as possible / use orbs if it helps
Run feature tests in parallel to rest of suite

Do you still want to switch to CircleCI or should I close this issue?

Do you still want to switch to CircleCI or should I close this issue?

#1063 moved us to GitHub actions. Nice catch...

#1063 moved us to GitHub actions. Nice catch...


Comment counts don't work if you're using Disqus

Also, allowing you to change the post url style means you lose Disqus comments if you ever change URL style

We probably need to create a unique identifier for each post to use with Disqus. This will allow us to get the comment count and also use that to retrieve the comment thread instead of the URL since that may change.

Seems like this may be closed... I noticed the following partial was added some time ago, and comment counts seem to be showing up accurately on FlyoverWorks.
<%= render "storytime/application/storytime/disqus_comment_counts" %>


fix: adjust mechanism used to determine if/when luis and qna teaching bubbles should pop out

Description
There were some strange behaviors in the get started experience when creating a skill due to the way Composer loads content and then progressively parses and indexes it.
Essentially, since the projects take a while to fully load and mark all of their LU files as empty or not empty, the test for needing to use LUIS or QNA would change over time, causing the get started content to flicker and shift as it loaded.
This PR shifts the mechanism, no longer using the parsed state of the files, opting for a simpler test on the files that is available at test time.  Additionally, this will now wait for the project to be fully loaded before launching the get started experience.
Task Item
Fixes #6939

Coverage decreased (-0.004%) to 51.118% when pulling 90fe60ca373e106e6e8670b902fae015f458b6d0 on benbrown/fixabubba into da887289bbccf4aa378b906983a9a73be853c7cc on main.


Update README.md

Missing pbkdf2 lib in the Requirements section
typo correction
RATs list updated according to decoders in the StandAlone folder

Thanks, took me a while but this is now resolved in the new release


fix: #40 windows keyboard shortcuts

Motivation
The shortcuts on windows did not work and the symbols did not match

vercel deployment failed, can you pull master to resolve conflicts & ensure this builds? otherwise pretty much lgtm

decided to resolve myself hehe, lgtm, thanks again!


Add subgroup option.

In GitLab it's possible to have subgroups to organize repositories. Protodep can not currently deal with this as it assumes the repo path follows GitHub rules and only contains github.com/$organization/$repo.
This commit adds a subgroup property to the dependency schema that allows the user to specify the subgroup or subgroups that are involved in the git URL reference. When the subgroup property is not present, the behavior remains unchanged so this should not be a breaking change.
As a concrete example consider this repo
https://gitlab.com/mergetb/portal/services
that has the structure https://gitlab.com/$group/$subgroup/$repo, in general arbitrary subgrouping on GitLab is possible
https://gitlab.com/$gropup/$a/$b/$c/.../$repo.
Thanks for the very useful tool!

Thank you for using protodep. Please wait a few days for review 🙏

@rcgoodfellow Great Fix! I am also using gitlab.  Any chance you could make the suggested changes and get this merged soon?

Requested changes have been made. Sorry for the delay.

@rcgoodfellow Awesome works! Thanks!
This feature has released in 0.1.5
@sf-jassmith Please use this version!


Make Hash initializer public

I believe that the Hash class's initialiser is not made public because configuration of the Hash is expected to be performed by:
app.hash.key = "secretkey"

However, in the initialiser of Application it is possible to set your own Hash instance, so it would appear to make sense to allow to be inited outside of the scope of the init of an Application.
There are also use cases for being able to have more than one Hash instance (with different keys) available at one time, or having an instance available without needing to create an Application along with it. I also can't think of any particularly good reasons for disallowing it, hence this pull request.

@bygri thanks for the pull request, contributions from the community are always awesome to see!
I understand now, what this issue was referring to https://github.com/qutheory/vapor/issues/195
These changes look good so far, glancing at the hash code, I think I have an issue w/ this var.
It's marked var, but based on its comments, it should absolutely be a let constant.
Would you mind also changing that, and making the initializer:
public init(key: String) {
    self.key = key
}

Unless there's objections from other members, once we have the updated key attribute, we'll get this merged in next release 👍

Agreed. Just didn't want to push it too far! Based on your comments, I have gone ahead and pushed it too far. In my view, setting the hash Driver is similar to setting the key, and may as well be done at init only. Also, if the key and driver properties are constant, I don't see any benefit in keeping them public so I made them private lets.

Making the initialiser require a key and keeping the key constant has a knock-on effect with Application() which needs to know the key at init so it can configure the Hash properly. This would require all users currently setting a hash key to alter their code to provide the key at Application.init(), which is not a change I want to make without some direction.
Can I just submit a PR making the initialiser public, which wouldn't affect any current code, and then subsequently put together a PR addressing your earlier comments for consideration?

@bygri that sounds great to me 👍