Unable to reproduce the results on ModelNet40

Hello,
I'm trying to reproduce the reported results on ModelNet40.
I have written a data loader for ModelNet40 and I'm training it with all the implementation details in the paper (Appendix G).
The maximum accuracy I'm getting is 92.8 which is way less than the reported numbers.
Can you upload the code for ModelNet40?

I would also like to run this code on the modelnet40 dataset to facilitate applying this model to my own dataset. @hancyran

Sorry for the late reply.
We have uploaded the implementation on segmentation tasks. And if you are interested in the repsurf model on modelnet, we will plan to upload it recently.
Thank you for your interest in our work!

Any updates for the ModelNet implementation?

Yes, I am waiting for this update.发自PORSCHE DESIGN HUAWEI Mate 40-------- 原始邮件 --------发件人： Seyedalireza Khoshsirat @.>日期： 2022年10月18日周二 03:38收件人： hancyran/RepSurf @.>抄送： Jieric @.>, Manual @.>主    题： Re: [hancyran/RepSurf] Unable to reproduce the results on ModelNet40 (Issue #4)
Any updates for the ModelNet implementation?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically,  after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful.
@khoshsirat-udel

@Margaretya, I have done a few modifications to my copy of the code, and I did not run this recently, but I hope it works. Make sure you using the modelnet40_normal_resampled
import os
import numpy as np
from torch.utils.data import Dataset

class ModelNet40DataLoader(Dataset):
    def __init__(self, root, split):
        assert (split == 'train' or split == 'test')
        cat = [line.rstrip() for line in open(os.path.join(root, 'modelnet40_shape_names.txt'))]
        classes = dict(zip(cat, range(len(cat))))

        self.data = []
        with open(os.path.join(root, f'modelnet40_{split}.txt')) as file:
            for i, line in enumerate(file):
                shape_id = line.rstrip()
                class_name = '_'.join(shape_id.split('_')[0:-1])
                class_id = classes[class_name]
                file_path = os.path.join(root, class_name, shape_id) + '.txt'
                self.data.append([file_path, class_id])

    def __len__(self):
        return len(self.data)

    def __getitem__(self, index):
        file_path, class_id = self.data[index]
        points = np.loadtxt(file_path, delimiter=',')
        return points.astype(np.float32).T, class_id

@khoshsirat-udel Thank you so much!

can someone confirm the score of "94.7" reported on modelnet? also were the modelnet scores reported with or without voting?

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically, after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful. @khoshsirat-udel

I also noticed this phenomenon. This is because the drop-out augmentation of ModelNet40 leads to the repetition of the point. So when the network query and group the KNN points,  some groups have many totally same points. After calculating the relative position,  the torch.cross operation return a zero vector, which makes normalized vector become a NaN.

Thanks for your excellent work!
As I said above, the default setting of drop-out augmentation leads to the NaN result. When I remove the drop-out augmentation, training is back to normal. However, This caused me to be unable to reproduce the results of modelnet40.
Could authors provide the correct augmentation codes of ModelNet40? Or is there any better solution? thanks a lot.

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically, after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful. @khoshsirat-udel

I also noticed this phenomenon. This is because the drop-out augmentation of ModelNet40 leads to the repetition of the point. So when the network query and group the KNN points, some groups have many totally same points. After calculating the relative position, the torch.cross operation return a zero vector, which makes normalized vector become a NaN.

Yes, we found it, too. Basically it cannot process any set contains same coordinates points. Remove dropout in dataloader help. Thank you for your information.

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically, after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful. @khoshsirat-udel

I also noticed this phenomenon. This is because the drop-out augmentation of ModelNet40 leads to the repetition of the point. So when the network query and group the KNN points, some groups have many totally same points. After calculating the relative position, the torch.cross operation return a zero vector, which makes normalized vector become a NaN.

Yes, we found it, too. Basically it cannot process any set contains same coordinates points. Remove dropout in dataloader help. Thank you for your information.

Thanks for your information. But when I remove dropout augmentation, I cannot reproduce the results in ModelNet40, may be because of the overfitting. How did you solve this problem? Looking forward to your reply.

Unfortunately, we cannot reproduce the results, either. We guess there are some tricks setting in dataloader. And we are looking forward the author’s official codes.

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically, after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful. @khoshsirat-udel

Hi, I came across this issue recently and my answer is: in my ModelNet40 data loader, I down-sample the point cloud data to 1024. Therefore, we should not down-sample again in the training code part. Hope this will help.

Can someone provide the specific shape of the input tensor to use with the ModelNet40 dataset? Thanks!
RuntimeError: Given groups=1, weight of size [10, 10, 1, 1], expected input[16, 9, 8, 1024] to have 10 channels, but got 9 channels instead

Hello,
We have also reproduced the ModelNet40 now. But the data are all NaN after UmbrellaSurfaceConstructor. specifically, after mlp in UmbrellaSurfaceConstructor. Would you mind sharing your data loader for ModelNet40? It will be very helpful. @khoshsirat-udel

I also noticed this phenomenon. This is because the drop-out augmentation of ModelNet40 leads to the repetition of the point. So when the network query and group the KNN points, some groups have many totally same points. After calculating the relative position, the torch.cross operation return a zero vector, which makes normalized vector become a NaN.

Yes, we found it, too. Basically it cannot process any set contains same coordinates points. Remove dropout in dataloader help. Thank you for your information.

Thanks for your information. But when I remove dropout augmentation, I cannot reproduce the results in ModelNet40, may be because of the overfitting. How did you solve this problem? Looking forward to your reply.

Unfortunately, we cannot reproduce the results, either. We guess there are some tricks setting in dataloader. And we are looking forward the author’s official codes.

Can you provide the specific shape of the input tensor to use with the ModelNet40 dataset? Thanks!
RuntimeError: Given groups=1, weight of size [10, 10, 1, 1], expected input[16, 9, 8, 1024] to have 10 channels, but got 9 channels instead


Streams closing due to recoverable errors when reading

I've observed my streams closing due to recoverable errors (generally EWOULDBLOCK) when reading.
Stream.write sits in a while loop to retry after recoverable errors, is there a reason Stream.read doesn't?  I've had success modifying Stream.read to sit in a while loop, but am worried that I'm missing a corner case.

No, this sounds like a reasonable change. Could you submit a PR?
If there are corner cases, manual testing in a bunch of scenarios should hopefully ferret them out (opening up vim in a container is usually a good one).


Handle MIME hdr parsing edge case

Change to handle edge case: FIN and Data sent in a single TCP packet, also only a single line feed at the end of the header. This causes the last MIME field to be missed in the parsing of the header.
Cause: because single CR LF, in MIME.cc:2427(case MIME_PARSE_INSIDE) raw_input_c = raw_input_e and zret = PARSE_RESULT_CONT (default) and S->m_state = MIME_PARSE_AFTER. This causes to it exit the loop rather than iterating once more and setting zret = PARSE_RESULT_OK to parse the field. When it goes to MIME.cc:2487 it thinks there is more data coming and appends it. When the SM re-enters, to MIME.cc:2461 raw_input_eof = true and data_size = 0, and thus returns PARSE_RESULT_DONE. So it gets a signal that parsing is finished even though there was data appended that hadn't been parsed.
Fix: If we have data and are in MIME_PARSE_AFTER, force it to parse at this point (PARSE_RESULT_OK) rather than appending and sending PARSE_RESULT_CONT. Thus, when the SM re-enters and sends PARSE_RESULT_DONE, all field will have actually been parsed.

[approve ci]

[approve ci autest]

Cherry-picked to 7.1.x.


Not obvious

I don't think any docs should use the word "obviously" - even if it seems obvious to one person it's patronising or belittling to people who are learning

@thommck : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @thommck, thanks for the feedback and for taking the time to help us improve the docs.
We don't have a hard and fast rule against the word "obvious" or "obviously". We also try to keep our docs tone casual and natural. In this case, the "obviously" fits with that tone.
Regarding the title you chose for this issue ("Not obvious"), there are definitely cases when something that's obvious to a developer or writer wouldn't be obvious to the user. But we don't think that this is one of them. If you're interested in connecting X to Y, we don't think it's patronizing to point out that you're going to need as X to get started :)
I'm going to close this issue, but feel free to comment again here or open a new one if you have additional requests.
#please-close


ui: remove extra table tag in service discovery

Signed-off-by: Julien Pivotto<EMAIL_ADDRESS>

:+1:
I'm surprised that didn't cause problems.

Here is the "problem" (space between federate_1 and federate_2) :

(present in last stable too:  http://demo.robustperception.io:9090/service-discovery )

Thanks!


how to avoid influence between dataflows

Hi, @frankmcsherry,
I have set up timely as a long-time service to server queries. But the problem is that in timely all dataflows share the same computation resources, which will lead to a long execution time for a simple dataflow when there is a big dataflow is operated at the same time. So i think if you have    an idea to address this problem?

Hello.
This is by design (so that dataflows can share data assets without requiring locks and such. Within a worker thread, operators are scheduled as cooperative fibers.
Differential dataflow has its expensive operators (e.g. join) yield control regularly (after 1M output records, but there could be better rules). In the future, things like async/await could make this easier, but at the moment it is up to you.
Other options include having compute intensive threads deposit results in a shared cache, so that other decoupled threads can read from it without awaiting the producing thread. Or, if the tasks are unrelated, you can spin up separate timely clusters for each independent computation.
Hope this helps!

In our application, we may run thousands of queries at the same time, each query was compiled to be a timely dataflow job.  Usually, queries take less than 1s, but we can not know which query would take much more time in advance; So we wonder is there a better way to concurrently run many timely-dataflow jobs in one timely environment(e.g. same network connections).  For example, if we can run different timely-dataflow jobs in different worker threads, but without establishing the TCP connections, it may be helpful.

A few things come to mind, but each of them have their trade-offs.

You could look in to the potentially expensive computations, and ensure that their operators are written to yield control if they take a long amount of time. Timely is meant to support multiple concurrent dataflows, but this only works if operators release control often enough.

You could write a timely dataflow operator which interacts with a task pool. This would allow compute heavy work to happen off of the timely worker threads, but this is only helpful if you can move the necessary state to another thread. It would probably require Arc wrappers around shared state, for example.

It's a bit tricky to know without a clearer understanding of the workload. The timely code is pretty close to allowing a pluggable scheduler (it is now hard to mis-schedule operators, although it is not yet easy to schedule them yourself).
If each of the dataflows are unrelated, and you just want to enact better resource sharing, this is a scheduling question (ensuring operators yield would be an important first step, but then more balanced scheduling would be a further improvement). If one dataflow is taking multiple timestamped requests and you would like to re-order them, this might be harder to do.
What is the system doing when you would prefer that it be working on short jobs?


Check boxes don't work after autoclosing

Expected Behavior
After autoclosing the vertical flyout, check boxes in it should be clickable.
Actual Behavior
Check boxes are unclickable after auto closing ~

Steps to Reproduce

In flyout_vertical.js: set Blockly.VerticalFlyout.prototype.autoClose set to be true
Drag any block out from the flyout
Click on any checkbox

Operating System and Browser
Win10 Chrome 70

You can just close it... I also meet the same problem,can someone give me some suggestions
 Blockly.VerticalFlyout.autoClose = false;

@MaggieLu We currently do not support auto-closing the flyout.


Filter Bypass

Hey goodone, I really like this project and it works amazingly well, some servers have something called filter.evo-filter.com when you input the cfx link, Is there any way to bypass this, if there is, a feature to do this would be amazing :)

Not possible. The only way is to use Wireshark and join the server.


Adding Emailed into OperationEnum

Adding Emailed into OperationEnum that it is used by the following entites:

Estimate
Invoice
Payment
SalesReceipt
CreditMemo
RefundReceipt
PurchaseOrder

This file is generated from the XSD file so I cannot just accept manual edits to this file otherwise they will get reverted the next time the file is generated.
See https://developer.intuit.com/app/developer/qbo/docs/learn/explore-the-quickbooks-online-api/minor-versions
Currently QuickBooksSharp uses version 3.56
Was this field added in a more recent version of the XSD?
If so, the new XSDs need to be added to the solution and the file must be regenerated.

I had a look at the latest XSD and I cannot see an 'emailed' value.
Is this documented in the API? If so, Intuit should have updated the XSDs accordingly.

I had configure Webhook in my application, and I notice that sometimes that I try to deserialize the EntityChange entity I receive an exception when the Operation property has the value of "Emailed". What is weird is that I couldn't find any documentation related to this type of operation, there are just questions that other users did.
But you can find the configuration for receive the Emailed notification when you enter in the Dashboard/Webhooks of your application

It doesn't appear in the xsd. See https://github.com/intuit/QuickBooks-V3-DotNET-SDK/blob/5b4edc68aa5eef6396ffcf155a347f80768e3414/IPPDotNetDevKitCSV3/Tools/XsdExtension/Intuit.Ipp.XsdExtension/Schema/IntuitRestServiceDef.xsd#L452
Neither does it appear in the official .NET library object. Open https://raw.githubusercontent.com/intuit/QuickBooks-V3-DotNET-SDK/5b4edc68aa5eef6396ffcf155a347f80768e3414/IPPDotNetDevKitCSV3/Tools/XsdExtension/Intuit.Ipp.Data/CDMEntities/Fms.cs and search for "enum OperationEnum".
Can you raise an issue with Intuit directly to fix their XSD? As I said, this enum is generated from the XSD. If it was a class, it could be made partial, but enums cannot be partial.

Closing since I haven't heard back but feel free to re-open.


docs: request for triager role for maxakuru

I have read and understood the project's Contributing guide.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the below orgs:
jshttp
pillarjs
express
Refs: #4055

Makes sense @dougwilson.  Sorry I thought we had approved @gireeshpunathil's example.  What commit message would you like for this?

We did approve it, but the comment message that was landed was different from the normal pattern. Notably it had a reference to the PR in parenthesis on the first line and then in the body had a bullet point duplicating the message for some reason.

Yep, my fault.  I squashed because of the fixup and didn't edit the message it generated.  We will make sure the follow up ones follow the pattern. Sorry!

It's no problem, anything can be fixed in git. The only down site is that the merge reference in the original PR will then be broken (and all other merged commits made after it but before the message gets fixed would also have broken refs in the GitHub UI). We should get #4055 merged to add the triage defintion and stuff to the doc and then land these on top of that, I think. Let me know your thoughts on that plan.

Ok, yeah lets merge that to triage and then I will have these folks rebase on top.

Ok. Just remember the down side will be when it goes back to master all the commit hashes will change, which will break the references to the merged commits in the GitHub UI if that matters at all (I don't care too much, but not sure if others cared about the links working).

Ok, glad you were around @dougwilson to catch this!  It was too hectic in there to realistically manage merging these well.  To follow up:
@maxakuru is added to the triage role, but lets wait until we have a clear merge plan (hopefully tomorrow I can carve out time to review the new changes to the doc) to merge this.  I will comment in the other PR's for the status and a follow up so everyone knows what is going on.
cc: @expressjs/triagers

No problem! I just got home and plan to get it sorted out tonight as my only priority for OS work today :) It got quite busy at work so I dropped off earlier, haha.

Role added and merged in 7f5573e1c972384a629f816e9639d14ef8ff916d


Local variable not used

Analyzer Done
Code Fix Provider in progress
(2 test out of 5 passing)

Was thinking of using the same snippet of code to determine whenever a variable is not used.
From that, I get a collections a ISymbols of unusued variables.
Then, I would have resolved every variable declarator and get their ISymbol and verify is unusuedVariable.Contains().. and call remove node on each on them.
I don't have SyntaxNodeAnalysisContext with CodeFixProvider
@mkrueger  How can I do this? It should'nt take long and this can be merged too !

Basically the code fix provider should not do any analyzation because analyzation is very time consuming and they're running on the UI thread.
Therefore you've to give everything to the code fix provider  - a diagnostic can give a properties dictionary<string, string> to the diagnostic. On the code fix provider side it's accessible via diagnostic.Properties.

Some additional notes:

An exception is thrown as soon as code contains methods without body.
I've disabled TestUnusedVariable2 for now, since support for multi-variable declarations seems not to be implemented yet and that test makes the build "red".

I've fixed the 2 mentioned issues (d941e4e2da73000540910e57250f4dec02c88225), the exception was quite annoying when thrown all the time while debugging with my test project.


Java indexer: stop an exception from being thrown when a line contains multiple comments [phab:D487]

Created by schroederc at 2015-09-01 21:09:25:

zarko accepted this revision at 2015-09-01 22:32:53

schroederc closed via commit 263ab77c403b64be41f388f5aeff12c14110049a at 2015-09-01 22:33:42


doc/dev/release.md: add new branch release

Description of the change: Add a new section to create a new release branch for minor releases. This PR also includes some minor formatting fixes.
Motivation for the change: We did not make release branches for v0.5.x and v0.6.x since we did not have this in the release doc.

lgtm


Minor fixes so the plugin could be used in future versions of UE4

I use this plugin within both Blueprint and C++ programming environment. Although it works splendidly with Blueprint, the plugin was not usable  with C++. More precisely, I need to reference UCoverPoint objects in my project for AI, but the project did not compile. I then added a small, yet important fix to make this awesome plugin more extensible! Thanks for making this plugin free!

Thank you for the Pull request @mhoangvslev :)
Was quite busy in the last months so didn't have time to check it out, but happy to know that this plugin is useful to others. Would love to see what you've been using it for!


CXDirection takes way more time than it should

Information

Qiskit Terra version: master
Python version:
Operating system:

What is the current behavior?
CXDirection pass is extremely expensive.  This should surely not be the case.  It should be profiled to see where things are going wrong.
Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

Is this closed by PR #3173 ?

Thanks @brandhsn
Closed via #3173


Minor UX issue in Mikan endless mode [wightwulf]

When Mikan search screen loads more items in endless mode it temporarily shows a loading message that covers the whole content area.

Fixed by 656fd8e902b68c1da2647c014d6707d91f803b65


How to use with frontend Javascript

Despite of using require.js I am unable to use this library properly. The following simple code generated many errors:
u = Units.convert('1', 'eth', 'wei')
    console.log(u)

errors:
require.js:5 Uncaught Error: Module name "bignumber.js" has not been loaded yet for context: _. Use require([])
http://requirejs.org/docs/errors.html#notloaded
    at makeError (require.js:5)
    at Object.o [as require] (require.js:5)
    at requirejs (require.js:5)
    at index.js:1

Hey @kadnan, this repository is quite old and hasn't been kept up to date, we plan to deprecate it relatively soon. I'd recommend using the unit conversion functions in e.g. ethers


Player change

DSL Pull Request
Changes:

[ ] Is this an update to the schedule?

[ ] Does this change the layout?

Just saw this I'll accept it now but lmk if you send one so I accept it faster or I think you can tag me @MaxShalom in the PR description to notify me


la-go-live

Docs Build status updates of commit 483dfe9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/apps-in-teams-meetings/create-apps-for-teams-meetings.md
:white_check_mark:Succeeded
View

msteams-platform/assets/images/tabs/Samplewebapp.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/tabs/Samplewebapp2.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/tabs/image-capability-screenshot.jpg
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/mobile-camera-image-permissions.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/device-capabilities/native-device-permissions.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/design/tabs.md
:white_check_mark:Succeeded
View

msteams-platform/tabs/what-are-tabs.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/what-are-task-modules.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add oneshot::Sender::is_connected_to method

I was gonna open an issue asking for this, but it was trivial to implement so I figured I'd just go straight to a PR.
This adds a method to oneshot::Sender to check whether it's connected to a given Receiver:
/// Tests to see whether this `Sender` is connected to the given `Receiver`. That is, whether
/// they were created by the same call to `channel`.
pub fn is_connected_to(&self, receiver: &Receiver<T>) -> bool {
    Arc::ptr_eq(&self.inner, &receiver.inner)
}

Does this seem like a good idea? It would be useful for me.

Thanks!


Update Telepot to Bot API 2.3

Full changelog: https://core.telegram.org/bots/api#recent-changes
The big one seems to be channel post notifications, the other ones sound very simple to implement.

Thanks. If all goes well, update should be available on or before Nov 30th.

I'll try to help if I can. Will channel messages just have a "channel" chat_type, or do you plan on doing more than that?


⚠ Bofrost.es has degraded performance

In 2bf6a5d, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1692 ms

Resolved: Bofrost.es performance has improved in 3a2c9ba after 6 minutes.


Fix duplicate downloads and refactor code

Pre-Checklist
Note: please complete ALL items in the following checklist.

[x] I have read through the CONTRIBUTING.md documentation.
[x] My code has the necessary comments and documentation (if needed).
[x] I have added relevant tests

Description

fix duplicate downloads logic
make outputs more beautiful
refactor some code

Related Issues
close #818
New Behavior (screenshots if needed)
The version in 3 screenshots is a forced change during testing, and the commits have been submitted in accordance with the normal.
Download all plugins from remote

Download some plugins from remote

No need to download plugins from remote

Init in dev version

Very good refactor. Well done! @iyear

@hxcGit need another review here. Please have a local test if possible.

It's very cool! @iyear 🚀


Where should I find iot-connected factory architecture

I would like to know azure iot-connected-factory solution architecture from start to end.  Like how the data coming to IOT, time series insights, what the vm is doing, what is rdx service.. each and every component how it is used in the solution..

@reddyeswar161 -
Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

@reddyeswar161 -
Thank you for your question.
Can you please share with us the URL of the document that you are having issues with?
Please note that we scope issues on this repo to feedback related to the docs. If you have a product question, please post it on Microsoft QnA or Stack Overflow. Thank you for your understanding.

https://github.com/Azure/azure-iot-connected-factory

@reddyeswar161 - Thanks for providing the details.
Looks like you have a product issue and not a doc feedback. Please note that this channel (the Azure Docs repository) is only for driving improvements related to the Azure documentation. The best place for specific answers about implementations are going to be the Microsoft QnA and Stack Overflow forums. Our Engineers and Community are active in answering questions in the forums. and will do our best to get you going in the right direction!
At this moment, Since there is no doc update required, We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


[T3A5][F11-A2]Teo Ming Yi

Ready for review

:+1: well extracted, good job, however for future PRs, do be sure that the commit(s) only relates to the activity you are PR-ing with. (	Encapsulate feedbackToUser string	 & Use getter method getFeedbackToUser is for A2).


clicking help button beneath search field causes out of order events

Setup: Kubernetes with Sockshop on Ubuntu
Browser: chrome version 56.0.2924.87 (64-bit)
To reproduce:

Select Container view
Type zipkin into the search field (don't press return)
Click the help button.

Note that help does not appear.

click on the container and the details screen does not appear.

click on the help button in the lower right hand corner and the details screen appears.

Here's a recording:
http://recordit.co/O44Ck1x7AM

I should add also that the WC UI freezes after you perform those steps.

@abuehrle Could you re-check this in production? I merged a bug fix for the 'help' icon a few days ago.

@jpellizzari one really minor thing.  It opens nicely when you click the ? beneath the search field, but then you can't make it go away by clicking the ? again beneath the search.  Although, this works from the help icon in the lower right hand corner.
Other than that the help looks really good. I should also add that to the guide for the website and expand on it.
http://recordit.co/nC3JtXkXrx


Does this arduino library block some GPIO ports when reading the RTDB?

I was trying to run a stepper motor through an ESP32 where the speed is determined by the value given in the firebase but every time the ESP tries to read the firebase data it stops the stepper motor. Might be a GPIO issue or the Stepper motor library I am using but knowing if the firebase library does any blocking action would be beneficial. i can't really post my code due to NDA restrictions

It is not async library, mcu may take time for waiting during sending and reading data.
You can run your code on another RTOS task that can run with higher priority.

You can try this new async Firebase client library.

Thank you, i appreciate you for taking the time out of your day for solving my query


[Feature Request] Add creation timestamp when expand storage node

Now the expansion event is recorded during the expansion, but the event is short of time.
[root@master1 ~]# kubectl get lsn work1 -o yaml
apiVersion: hwameistor.io/v1alpha1
kind: LocalStorageNode
status:
  conditions:
  - lastTransitionTime: "2023-04-07T02:39:21Z"
    lastUpdateTime: "2023-04-07T02:39:21Z"
    message: Sufficient storage capacity
    reason: Available
    status: "True"
    type: Available
  poolExtendRecords:
    LocalStorage_PoolHDD:
    - description:
        diskType: HDD
      diskRefs:
      - apiVersion: hwameistor.io/v1alpha1
        kind: LocalDisk
        name: work1-sdd
        resourceVersion: "6204386"
        uid: 47862f84-94f7-4539-9b8a-c0ad469c6904
      nodeName: work1
      owner: local-storage

Adding the time of the event may make the event more clear for troubleshooting or other cases when this event is needed.

Also consider LocalDiskNode expand events.


Ephemeral Port for UDP encapsulation

Is there a way to bind the udp encapsulation port to an ephemeral port? Usually we use 0 to do that but https://github.com/sctplab/usrsctp/blob/master/Manual.md#usrsctp_init defines 0 to mean "no encapsulation"?!

There is currently no way to do that. I'm also not sure why you would want that...

Thanks for your answer.. I already thought so..
Well if you have multiple applications on the same host that want to communicate with SCTP over UDP, how would you do that without pre-assigning UDP ports for each application?

Just to make sure I understand correctly: I have to embed one stack into each (server) application since there is no straight-forward way to share as single stack between multiple applications and each server with its own stack would bind to a different UDP port for encapsulation.

Hi @tuexen, @gabm

I'm also not sure why you would want that...

I would like to use this for unit/integration tests to avoid collisions with other applications or other users running the tests at the same time on the same host. Also on CI/CD systems usually you have little control what else is running on the host and what ports are free.
So I've decided to try to implement this and I've found that currently when usrsctp_init is called with 0 port the UDP threads are started and a random (usually different) ephemeral ports are bound for IPv4 and IPv6.
$ netstat --udp -lp
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
udp        0      0 <IP_ADDRESS>:54391           <IP_ADDRESS>:*                           11562/./baseserver/
udp6       0      0 [::]:44974              [::]:*                              11562/./baseserver/

The only missing thing is that you can't easily get those ports from the API. So I've decided to set the sctp_udp_tunneling_port to the bound ephemeral port so the application could get it with usrsctp_sysctl_get_sctp_udp_tunneling_port (see 75836415b4dc337e38e914cd59750c4e0112b1a9). I've tested it on Linux only. If you like it I could open a PR or you could cherry pick it from my repo.


Lower performance on Kinetics using model zoo TDN-ResNet50 checkpoint

I followed your Testing instructions (3-crops, 10-clips) and evaluated model zoo TDN-ResNet50 checkpoint on Kinetics.
The only difference is that I use extracted frames as you process Something-V1&V2 instead of raw video inputs you process Kinetics.
I ran the Testing twice and got 75.05/91.95  and 75.10/91.97 respectively.
I know there is some dataset differences but it should not bring such a big performance gap.
Would you kindly check if the Testing setting is the one you obtain the reported performance?

Besides, there is a small bug in main.py Line 220:

prec1, prec5, val_loss = validate(val_loader, model, criterion, epoch, logger)

The parameter 'epoch' here should be removed.

Besides, there is a small bug in main.py Line 220:

prec1, prec5, val_loss = validate(val_loader, model, criterion, epoch, logger)

The parameter 'epoch' here should be removed.

Hi @caidonkey , Thanks for your comments.  I think you might run this scripts for one time, which only does one clip and three crop test.
CUDA_VISIBLE_DEVICES=0 python3 test_models_three_crops.py  kinetics \
--archs='resnet50' --weights <your_checkpoint_path>  --test_segments=8 \
--test_crops=3 --batch_size=16 --full_res --gpus 0 --output_dir <your_pkl_path>  \
-j 4 --clip_index <your_clip_index>

You need run this script for ten times and change the <your_clip_index> from 0-9 then you will ensemble 30 pkl files with pkl_to_results.py

Hi @caidonkey , Thanks for your comments.  I think you might run this scripts for one time, which only does one clip and three crop test.
CUDA_VISIBLE_DEVICES=0 python3 test_models_three_crops.py  kinetics \
--archs='resnet50' --weights <your_checkpoint_path>  --test_segments=8 \
--test_crops=3 --batch_size=16 --full_res --gpus 0 --output_dir <your_pkl_path>  \
-j 4 --clip_index <your_clip_index>

You need run this script for ten times and change the <your_clip_index> from 0-9 then you will ensemble 30 pkl files with pkl_to_results.py

The only difference is that I use extracted frames as you process Something-V1&V2 instead of raw video inputs you process Kinetics.

We use the raw video dataset for online training and inference, the shorter side of each video is 320p, which might result in lower performance if you extract frames with lower resoultion
If you have more questions, please free to comments or email me<EMAIL_ADDRESS>

The only difference is that I use extracted frames as you process Something-V1&V2 instead of raw video inputs you process Kinetics.

We use the raw video dataset for online training and inference, the shorter side of each video is 320p, which might result in lower performance if you extract frames with lower resoultion
If you have more questions, please free to comments or email me<EMAIL_ADDRESS>

Hi @caidonkey , Thanks for your comments. I think you might run this scripts for one time, which only does one clip and three crop test.
CUDA_VISIBLE_DEVICES=0 python3 test_models_three_crops.py  kinetics \
--archs='resnet50' --weights <your_checkpoint_path>  --test_segments=8 \
--test_crops=3 --batch_size=16 --full_res --gpus 0 --output_dir <your_pkl_path>  \
-j 4 --clip_index <your_clip_index>

You need run this script for ten times and change the <your_clip_index> from 0-9 then you will ensemble 30 pkl files with pkl_to_results.py

No, I have ran the test from 0-9 index and emsembled the results as you mentioned.
The only difference is that I use 340x256 extracted frames. I'll check later with raw video inputs.
Thanks.

Hi @caidonkey , Thanks for your comments. I think you might run this scripts for one time, which only does one clip and three crop test.
CUDA_VISIBLE_DEVICES=0 python3 test_models_three_crops.py  kinetics \
--archs='resnet50' --weights <your_checkpoint_path>  --test_segments=8 \
--test_crops=3 --batch_size=16 --full_res --gpus 0 --output_dir <your_pkl_path>  \
-j 4 --clip_index <your_clip_index>

You need run this script for ten times and change the <your_clip_index> from 0-9 then you will ensemble 30 pkl files with pkl_to_results.py

No, I have ran the test from 0-9 index and emsembled the results as you mentioned.
The only difference is that I use 340x256 extracted frames. I'll check later with raw video inputs.
Thanks.

Hi,  @caidonkey ! you can also check this Data Benchmark done by MMaction2.

Hi,  @caidonkey ! you can also check this Data Benchmark done by MMaction2.

Hi, @caidonkey ! you can also check this Data Benchmark done by MMaction2.

Thanks for your kind remind.
I have used MMAction and MMAction2 to conduct extensive experiemnts, but with only 4 GPUs. The performance seemed reasonable. (340x256 extracted frames;  224x224 input)
Just considering the dataset difference, using MMaction2, under config "tsm_r50_dense_1x1x8
_100e_kinetics400_rgb", model zoo reported 72.9/90.44 and we obtained 72.74/90.37.
Recently, I also evaluated TAM (https://github.com/liu-zhy/temporal-adaptive-module) and obtained 75.25/91.99 on our validation set (76.1/92.3 reported). But when we trained using the released config setting, we could obtain 75.59/92.04. I think the performance gap by data is also reasonable.

Hi, @caidonkey ! you can also check this Data Benchmark done by MMaction2.

Thanks for your kind remind.
I have used MMAction and MMAction2 to conduct extensive experiemnts, but with only 4 GPUs. The performance seemed reasonable. (340x256 extracted frames;  224x224 input)
Just considering the dataset difference, using MMaction2, under config "tsm_r50_dense_1x1x8
_100e_kinetics400_rgb", model zoo reported 72.9/90.44 and we obtained 72.74/90.37.
Recently, I also evaluated TAM (https://github.com/liu-zhy/temporal-adaptive-module) and obtained 75.25/91.99 on our validation set (76.1/92.3 reported). But when we trained using the released config setting, we could obtain 75.59/92.04. I think the performance gap by data is also reasonable.

Hi, @yztongzhan nice work!  Can you share your version of kinetics400 with me? My current version is similar to @caidonkey , with short side equals 256. My email address is<EMAIL_ADDRESS>Many thanks !

您好！我在训练后得到最好的模型为73.13/91.16，但是测试效果一直接近0不知道什么原因，您方便把kinetics测试的指令及代码发给我参考一下吗？谢谢！

我按照您的测试说明（3 次裁剪、10 次剪辑）并在 Kinetics 上评估了模型动物园 TDN-ResNet50 检查点。
唯一的区别是我在处理Something-V1&V2时使用提取的帧，而不是处理Kinetics的原始视频输入。
我运行了两次测试，分别得到了 75.05/91.95 和 75.10/91.97。
我知道有一些数据集差异，但它不应该带来如此大的性能差距。
请您检查一下测试设置是否是您获得报告性能的设置？

你好！我在训练后得到最好的模型为73.13/91.16，但测试效果一直接近00不知道什么原因，你可以把动力学测试的指令和代码知道我看看一下吗？谢谢！

我按照您的测试说明（3 次裁剪、10 次剪辑）并在 Kinetics 上评估了模型动物园 TDN-ResNet50 检查点。
唯一的区别是我在处理Something-V1&V2时使用提取的帧，而不是处理Kinetics的原始视频输入。
我运行了两次测试，分别得到了 75.05/91.95 和 75.10/91.97。
我知道有一些数据集差异，但它不应该带来如此大的性能差距。
请您检查一下测试设置是否是您获得报告性能的设置？

你好！我在训练后得到最好的模型为73.13/91.16，但测试效果一直接近0不知道什么原因，可以把动力学测试的指令和代码知道我看看一下吗？谢谢！

I followed your Testing instructions (3-crops, 10-clips) and evaluated model zoo TDN-ResNet50 checkpoint on Kinetics.
The only difference is that I use extracted frames as you process Something-V1&V2 instead of raw video inputs you process Kinetics.
I ran the Testing twice and got 75.05/91.95 and 75.10/91.97 respectively.
I know there is some dataset differences but it should not bring such a big performance gap.
Would you kindly check if the Testing setting is the one you obtain the reported performance?

Hi! The best model I got after training is 73.13/91.16, but the test result is always close to 0. I don’t know why, can you send me the instructions and code for the kinetics test? Thanks!


Cancel stream listener

When using the option isLive: true, the stream always opens even we navigate to another screen.
With this PR, automatically gathering all stream listeners and cancel it on dispose().

@all-contributors please add @ghprod for code

Thanks @excogitatr


Bucket URL does not always contain S3

On line 210 of the s3iam.py file you state:
TODO: bucket name finding is ugly, I should find a way to support
both naming conventions: http://bucket.s3.amazonaws.com/ and
http://s3.amazonaws.com/bucket/
This is true but what i always do is create a bucket called: mybucket.example.com and then the url is: mybucket.example.com.s3.amazonaws.com or s3.amazonaws.com/mybucket.example.com/
But if you create a CNAME like this:
mybucket.example.com. 300 IN CNAME mybucket.example.com.s3-eu-west-1.amazonaws.com.

So it would be great of you build support in for that usage as well.

I think this would be covered in #30, with a syntax like s3://mybucket.example.com/
If the bucket name has dots in them we have to use path-style URL instead of virtual-hosted–style URL (see here for the differences), otherwise we'll get TLS validation errors. There's a more detailed explanation on the topic.
In any case we wouldn't be using the CNAME entry, because it would cause TLS issues (connecting to mybucket.example.com and getting a *.s3-eu-west-1.amazonaws.com certificate).


typo: paramter -> parameter

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Excel.Chart.BeforeDoubleClick.md
:white_check_mark:Succeeded
View

api/PowerPoint.View.PasteSpecial.md
:white_check_mark:Succeeded
View

api/Visio.Addons.GetNamesU.md
:white_check_mark:Succeeded
View

api/Visio.Documents.GetNames.md
:white_check_mark:Succeeded
View

api/Visio.InvisibleApp.EnumDirectories.md
:white_check_mark:Succeeded
View

api/Visio.Master.GetFormulas.md
:white_check_mark:Succeeded
View

api/Visio.Window.DockedStencils.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


fixed AFC and Azure RG deployment get-azrmvmcustomscriptextension

Hi @rajatagrawal-dev, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rajat Agrawal). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Can you confirm if you have validated this in both different Azure SDK agents. Changes look fine to me.

ok


Fix the components configuration record error

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix the components configuration record error
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @wzshiming

/approve
/lgtm


nitpicking on licensing statements in files

Why this double license statement?
// <copyright...> Licensed under the MIT license.
// SPDX-License-Identifier: MIT

I would tend to say that repetition is unlikely needed?

We like SPDX identifiers, but they are not yet accepted as "the licensing statement"


Hey made a few changes. Hope u like them !

I added a favicon , bootstrap buttons and few changes in social media icons. Hope u like the changes.

thank you


DeveloperGuide.adoc: update user stories

Coverage remained the same at 92.398% when pulling edcbf1ec2e2e84772730f72a2be6c465eede1b1c on jelneo:update_dg into cb29c3ccaabedaafe0a3ee1c26f3a5792dda9e5a on CS2103AUG2017-T17-B1:master.

Coverage remained the same at 92.398% when pulling eabdd5b0f48e57690818476b01d453ab1c7a3dfc on jelneo:update_dg into cb29c3ccaabedaafe0a3ee1c26f3a5792dda9e5a on CS2103AUG2017-T17-B1:master.


Ubuntu 22.04 fails to boot with read-only filesystem (Docker Desktop for macOS)

Hi Jeff,
I'm getting started with ansible and molecule, and am happy to find your pre-built images (thanks!). I'm having some trouble with the new Ubuntu 22.04 image. I'm using Docker Desktop 4.7.1 with default settings (no experimental features) on macOS 12.3.1 on a 2021 MBP w/M1 Pro.
When running docker as per the steps in README.md (except with -it instead of --detach so I can see the output), it fails to boot:
❯ docker run -it --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro geerlingguy/docker-ubuntu2204-ansible
Failed to look up module alias 'autofs4': Function not implemented
systemd 249.11-0ubuntu3 running in system mode (+PAM +AUDIT +SELINUX +APPARMOR +IMA +SMACK +SECCOMP +GCRYPT +GNUTLS -OPENSSL +ACL +BLKID +CURL +ELFUTILS -FIDO2 +IDN2 -IDN +IPTC +KMOD +LIBCRYPTSETUP -LIBFDISK +PCRE2 -PWQUALITY -P11KIT -QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD -XKBCOMMON +UTMP +SYSVINIT default-hierarchy=unified)
Detected virtualization docker.
Detected architecture arm64.

Welcome to Ubuntu 22.04 LTS!

Failed to create /init.scope control group: Read-only file system
Failed to allocate manager object: Read-only file system
[!!!!!!] Failed to allocate manager object.
Exiting PID 1...

If I change the volume to read-write mode (by changing --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro to --volume=/sys/fs/cgroup:/sys/fs/cgroup:rw) it boots successfully:
❯ docker run -it --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:rw geerlingguy/docker-ubuntu2204-ansible
Failed to look up module alias 'autofs4': Function not implemented
systemd 249.11-0ubuntu3 running in system mode (+PAM +AUDIT +SELINUX +APPARMOR +IMA +SMACK +SECCOMP +GCRYPT +GNUTLS -OPENSSL +ACL +BLKID +CURL +ELFUTILS -FIDO2 +IDN2 -IDN +IPTC +KMOD +LIBCRYPTSETUP -LIBFDISK +PCRE2 -PWQUALITY -P11KIT -QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD -XKBCOMMON +UTMP +SYSVINIT default-hierarchy=unified)
Detected virtualization docker.
Detected architecture arm64.

Welcome to Ubuntu 22.04 LTS!

Couldn't move remaining userspace processes, ignoring: Input/output error
Queued start job for default target Graphical Interface.
Unnecessary job was removed for /dev/vda1.
[  OK  ] Created slice Slice /system/modprobe.
[  OK  ] Created slice User and Session Slice.
[  OK  ] Started Dispatch Password Requests to Console Directory Watch.
etc…

Is there a reason this image should be run in read-only mode, or is it safe to use in read-write mode?

Just for comparison, I also tried to boot your Ubuntu 18.04 and 20.04 images. They boot successfully in read-only mode – except for the Failed to allocate manager object, freezing error, do you know what is causing that?
Here's geerlingguy/docker-ubuntu1804-ansible:
❯ docker run -it --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro geerlingguy/docker-ubuntu1804-ansible

Welcome to Ubuntu 18.04.6 LTS!

[!!!!!!] Failed to allocate manager object, freezing.

Here's geerlingguy/docker-ubuntu2004-ansible:
❯ docker run -it --privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro geerlingguy/docker-ubuntu2004-ansible

Welcome to Ubuntu 20.04.4 LTS!

[!!!!!!] Failed to allocate manager object.

This seems like it's related, but I don't really understand it: https://serverfault.com/questions/1053187/systemd-fails-to-run-in-a-docker-container-when-using-cgroupv2-cgroupns-priva

The release notes for Docker Desktop 4.3.0 include this note about using cgroup v2 (emphasis mine):

Docker Desktop now uses cgroupv2. If you need to run systemd in a container then:

Ensure your version of systemd supports cgroupv2. It must be at least systemd 247. Consider upgrading any centos:7 images to centos:8.
Containers running systemd need the following options: --privileged --cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw.

This github issue for docker desktop confirms this requirement by many users, and has lots of backlinks from other projects that use systemd that broke when Docker Desktop 4.3.0 was released. There's this comment that specifically mentions Ubuntu 22.04 requiring these options, and how the --cgroupns=host option may not be required, which my tests confirm.
So, with regards to your docker-ubuntu2204-ansible image, I think the fix is to update README.md to include these options that are required to run it on Docker Desktop.

This github issue for the Moby Project also confirms that it appears necessary to expose /sys/fs/cgroup as read-write as of systemd version 248.
Its author offers workarounds:

boot host with systemd.unified_cgroup_hierarchy=0
remove ro flag from docker run arg -v /sys/fs/cgroup:/sys/fs/cgroup:ro but this contaminates the host cgroup, causing e.g. docker top to get confused:

Another user suggests it can also be solved using namespace isolation (--userns-remap) or by just using podman instead of docker.

Containers running systemd need the following options: --privileged --cgroupns=host -v /sys/fs/cgroup:/sys/fs/cgroup:rw.

I had the same issue and I can confirm that it works with these changes...

Did by kernel parameter:
Not nice, but it works:
sudo rpm-ostree kargs --append='systemd.unified_cgroup_hierarchy=0'
https://docs.fedoraproject.org/en-US/fedora-coreos/kernel-args/


Question about Filename Formatting

Is it possible to use built-in feature to formatting the filename or foldername? Like:
%node_name.widget_name%
https://blenderneko.github.io/ComfyUI-docs/Interface/SaveFileFormatting/#search-and-replace-strings

Yes please. When doing tests, I love to put the name of the lora in the file name, sometimes the seed, sometimes the checkpoint, or reference an iteration number, etc... All my file names are set up so that I can type a project name in a box, and the generic image saver makes a folder for that by looking at what is typed in that box. I use this stuff constantly.


How to process variable length inputs?

Hello!
The S4 code as it stands allows the masking of padded inputs based on a given length, but this requires all inputs within a batch to be masked to the same length. Is there an alternative way to deal with padding of different sizes within a given batch (e.g., similar to a self-attention mask)? Would setting masked values to extremely small numbers (e.g. 1e-9) be a viable alternative?
For example, consider the following batch and mask:
batch = torch.LongTensor([
    [1, 2, 3, 0, 0, 0],
    [1, 2, 3, 4, 5, 6],
    [1, 2, 3, 4, 5, 0]
])

mask = torch.LongTensor([
    [1, 1, 1, 0, 0, 0],
    [1, 1, 1, 1, 1, 1],
    [1, 1, 1, 1, 1, 0]
])

The current code for masking lengths (pasted below) appears to assume all require the same length masking:
def forward(self, u, state=None, rate=1.0, lengths=None, **kwargs): # absorbs return_output and transformer src mask
    """
    u: (B H L) if self.transposed else (B L H)
    state: (H N) never needed unless you know what you're doing

    Returns: same shape as u
    """
    if not self.transposed: u = u.transpose(-1, -2)
    L = u.size(-1)

    # Mask out padding tokens
    # TODO handle option for mask - instead of lengths, which assumes suffix padding
    if isinstance(lengths, int):
        if lengths != L:
            lengths = torch.tensor(lengths, dtype=torch.long, device=u.device)
        else:
            lengths = None
    if lengths is not None:
        assert isinstance(lengths, torch.Tensor) and lengths.ndim == 1 and lengths.size(0) in [1, u.size(0)]
        mask = torch.where(torch.arange(L, device=lengths.device) < lengths[:, None, None], 1., 0.)
        u = u * mask

From reading through other posts here it seems like S4D is better able to deal with inputs of different lengths than S4, but the S4D code does not contain a masking strategy.
Thanks in advance for your help!

The second part of that code snippet assumes lengths is a tensor that can be different for every example and creates a mask that plays the same role as your mask. Is this not what you want?

The second part has an assert statement that assumes that the tensor lengths only has one dimension. In the example above, mask has two-dimensions: a mask for each item in the batch.
If this seems okay, then I can remove the assert statement and provide a mask for each item (instead of lengths of the batch).

The mask in the snippet plays the same role as your mask. There are many ways to modify it to handle the same interface. For example, you can simply comment out the lengths logic and just keep the line u = u * mask after directly passing in your mask. Or if you don't want to modify the S4 code, you can convert your mask into a lengths tensor easily (e.g. lengths = torch.sum(mask, axis=-1)). Or you can bypass all the masking logic in the S4 module and just do u = u * mask outside the module.

Thanks, just making sure that the logic would not mess with the implementation. Closing issue.


1.0.3

Includes

formatting pre-commit
format checking during merge
primate reaching label series for num_steps > 1
add device arg to benchmark run


Added Rotate_number_by_K.cpp

Rotate the digits of number by K
Program motive
It inputs a number from the user( as a string in ), inputs the number of shifts(as integer K) wants in number and outputs the resulting number after required shifts.
Issue
This PR is under issue #482
Sample Test case

number => 123456
k => 2 (rotate clockwise | shift left)
result => 345612

please merge this PR @amritansh22

Hey  @AKSHATNEMA
Please star this repository to show your support. In the meantime I am reviewing the PR.

@amritansh22 please merge this PR of you have reviewed it.


(documentation) Create build process video

Item type: AMOS formal requirements
Description as provided by the official documentation:

Create build process video and upload to Deliverables folder
Consider using OBS Studio for creating the video
Name and upload file to sprint-05/build-process-video.mkv
Or use other common container/codecs

Build process video
The build process video demonstrates that you mastered the build process.
Typically, the video will show your terminal window.

Please narrate over the video to explain what you are doing
You can stop the process while explaining and continue thereafter.
The build process consists of four main and one optional step:
Clone (the repository to start with a clean slate)
Build (the product from the clean repo)
Test (the product using automated test suites)
Optional: Deploy (to production environment)
Run (the product to show it starts up)

The most common scenario is to git clone and then build, test, deploy, and run using your build tool. If you have a fully automated CI process using GitHub, please trigger and show that.
If some steps cannot be automated, please carry them out by hand; you may want to copy over the commands from a separate text file to make things run smoothly.

Comments from the Professor sent via email:

Some projects don’t have to show much for a build process video, I guess. If you have no deployment model but run some Python code from the command line, there is nothing to show. (Running the Python code, like for data extraction, is not the build process, it is the application running.) Maybe you should containerize things. If there is nothing to show then maybe show your extraction code or training code but understand this is not the build process and comment accordingly. But again, I want to see the build process, not the application, in the upcoming deliverable.
If you have long running tasks that you can’t show in a single short session like for the mid-project review, then just create different environments (VMs if necessary) and stop them in different stages so that you can start a process for demo purposes in VM A and switch to VM B where it already finished. Or something like this. Be smart. You can also put this in a video.

User Story
As a member of this team
I need to fulfill the formal module requirements
so that I can successfully progress in the next steps of the AMOS module without problems
Acceptance Criteria

[ ] A concept / script / list of steps has been created that describes the build process components and steps.
[ ] The contents and structure of the video match the requirements listed in the description of the official documentation (provided above)
[ ] The screencapture video has been produced and (if needed) edited.
[ ] The video had been renamed and upladed in the respective documentation directory.

@lukas-varga
@eloinoel
Guys, you might want to create and connect a branch for this task because we will need to submit it anyway (if I am not mistaken in the docuementation directory) so it might as well be done like that.

Okay let's do it like that.

@lukas-varga
@eloinoel
Guys, you might want to create and connect a branch for this task because we will need to submit it anyway (if I am not mistaken in the docuementation directory) so it might as well be done like that.

Okay let's do it like that.

@lukas-varga
@eloinoel
Updated the description of the task to include the formal requirements so that everything is in one place.


Basic DSE

Execution of exhaustive script.
Every configuration aspect inherited from the current CO-Sim tab.

I'm bumping this to post-M18

@CarlGamble , following our discussion, I'm keeping this one on track for M25.

With the latest release, this is available.


⚠ Samsung has degraded performance

In a3c16f4, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3014 ms

Resolved: Samsung performance has improved in 5a2b228.


[CANNOLI-233] Update ADAM dependency version to 0.31.0

Fixes #233

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/222/
Test PASSed.

Coverage decreased (-12.5%) to 0.0% when pulling aba9dd04764554033b41ed598e60464c88f5536e on heuermh:adam-0.31.0 into 7f03e12e3d88e434e65b8be8013436d0f4d6bdaf on bigdatagenomics:master.


I don't understand How/Where to run the usage command..

I have 0% knowledge in programming, I don't understand How/Where to run the usage command..

This tool doesn't work unless you have a very, very old version of Telegram Desktop (before 2020). Don't bother trying unless you do.


Doubly LinkedList Implementation

Please review and merge :)
Issue #2

also @Rohanfizz , pls make a .md file named readme.md in the implementation folder explaining about the program(a few lines should be enough)

also @Rohanfizz , pls make a .md file named readme.md in the implementation folder explaining about the program(a few lines should be enough)

Okidoki


[SP-5319] Backport of PDI-15164 - Partitioning Method Dialog- misspelling (8.3 Suite)

Merge Masters: @pentaho-lmartins  and @smmribeiro
Cherry-picks:

https://github.com/Pentaho/pentaho-kettle/commit/31cf5d95746011f599a871de6b3929589dd3a999
https://github.com/Pentaho/pentaho-kettle/commit/4141f1f06f15df86c24b32453125ae4869044c89

:white_check_mark: Build finished in 11m 14s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1083, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 17m 16s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1083, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 16m 46s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1083, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 16m 1s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1083, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 11m 8s
Build command:
mvn clean verify -B -e -Daudit -amd -pl ui

:ok_hand: All tests passed!
Tests run: 1083, Failures: 0, Skipped: 0    Test Results

:information_source:  This is an automatic message


Publish an official release

I will upload a tag 1.0.0 and maybe upload to pypi?

Done: `1.0.01 released!


Error "error TS2339: Property 'subscribe' does not exist on type 'AngularFireList<{}>"

Hello,
I have updated to the most recent version of AngularFire2 and made a simple program to list all entries in the database collection from Firebase, but this results in the following error:
ERROR in src/app/app.component.ts(13,25): error TS2339: Property 'subscribe' does not exist on type 'AngularFireList<{}>'.
I also used the developer guidelines on this Github page to edit my code, but also those changes don't work. Is there perhaps a full guide available where all detailed code that is valid for the latest version of AngularFire2 is presented? No YouTube videos, content on Stackoverflow, or elsewhere on the internet addresses this.
Below I include the excerpts with code.
For Firebase, I use the Realtime Database.
Version info

Angular:
"@angular/cli": "1.6.8"
Firebase:
"firebase": "^5.0.2"
AngularFire:
"angularfire2": "^5.0.0-rc.7"
Other (e.g. Ionic/Cordova, Node, browser, operating system):
MacOS, both Safari and Firefox (latest versions)
How to reproduce these conditions
app.module.ts
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';

import { AngularFireModule } from 'angularfire2';
import { AngularFireDatabaseModule } from 'angularfire2/database';

import { AppComponent } from './app.component';
import { environment } from '../environments/environment';

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    AngularFireModule.initializeApp(environment.firebase),
    AngularFireDatabaseModule
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

app.component.ts
import { Component } from '@angular/core';
import { AngularFireDatabase } from 'angularfire2/database';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.css']
})
export class AppComponent {
  courses: any[];

  constructor(private db: AngularFireDatabase) {
    db.list('/courses').subscribe(courses => {
      this.courses = courses;
      console.log(this.courses);
    });
  }
}

app.component.html

{{ course.$value }}

Debug output
** Errors in the JavaScript console **
`ERROR in src/app/app.component.ts(13,25): error TS2339: Property 'subscribe' does not exist on type 'AngularFireList<{}>'.
Expected behavior
List all items in the database collection, formatted in an unordered list.
Actual behavior
Error.

You need to use one of .valueChanges(), .snapshotChanges(), etc.


How does scoring work?

I'm a little unsure of the end conditions or how scoring works, can we run through this at some point?

The game ends when only one warrior has any active tasks or a time limit is reached. There is an EndCondition class in the simulator which should demonstrate this. If the time limit is reached the game is a draw. Usually multiple rounds are played and points are awarded for wind and draws.

Yeah, sorry I meant more specifically how the points are awarded.
I've seen some things online with %'s and things so was wondered how you score a program vs other programs in hills and things

"There are two styles of KotH tournaments, "classical" and "multi-warrior". The "classical" KotH is a one-on-one tournament, that is your warrior will play 100 battles against each of the 20 other programs currently on the Hill. You receive 3 points for each win and 1 point for each tie. (The existing programs do not replay each other, but their previous battles are recalled.) All scores are updated to reflect your battles and all 21 programs are ranked from high to low. If you are number 21 you are pushed off the Hill, if you are higher than 21 someone else is pushed off."
http://www.koth.org/info/corewar-faq-.html

Excellent, thanks. I wanted to get this info so I could start thinking about how the hills would work

Scoring implemented in #186 - take percentage of wins * 3 + percentage draws


Common-utils Feature: Pin to major version 2

Ref: https://github.com/devcontainers/features/pull/326

I believe the uid and gid option names have changed, so must be update here. (same https://github.com/devcontainers/images/pull/308)
https://github.com/devcontainers/features/blob/a9a7a25d60585ce2145374ec6825cbdc7f16cb90/src/common-utils/devcontainer-feature.json#L40-L57

Yep, thanks for catching. Updated

I am also wondering if it is possible to change the meta.env's path.
https://github.com/devcontainers/features/blob/a9a7a25d60585ce2145374ec6825cbdc7f16cb90/src/common-utils/bin/devcontainer-info#L7

I think we could update that, it would mostly need an update to the vscdc tool here. @Chuxel any concerns?

I am also wondering if it is possible to change the meta.env's path.
https://github.com/devcontainers/features/blob/a9a7a25d60585ce2145374ec6825cbdc7f16cb90/src/common-utils/bin/devcontainer-info#L7

I think we could update that, it would mostly need an update to the vscdc tool here. @Chuxel any concerns?

Yep. Looks like @eitsupi did a PR already to update the common-utils devcontainer-info command to check the dev-containers folder in addition to vscode-dev-containers, so updating the image generation should be all that is required!

I am also wondering if it is possible to change the meta.env's path.
https://github.com/devcontainers/features/blob/a9a7a25d60585ce2145374ec6825cbdc7f16cb90/src/common-utils/bin/devcontainer-info#L7

I think we could update that, it would mostly need an update to the vscdc tool here. @Chuxel any concerns?

Yep. Looks like @eitsupi did a PR already to update the common-utils devcontainer-info command to check the dev-containers folder in addition to vscode-dev-containers, so updating the image generation should be all that is required!

Great! I'll create another PR once this one's merged, thanks!


fix: do not override where clause

close #44

:tada: This PR is included in version 2.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add shifting in the blaze server

This fixes TODO about pool shifting in the blaze server.

@danicheg gentle ping on this one. Sadly, I am not qualified to review these changes. They seem idiomatic, but it is a semantic change that I do not know if it is correct.

Actually, I think this isn't bad or something, but yeah, we need some blaze-ninja to check these changes are reasonable.

Doesn't renderResponse run on the executionContext, which in modern times will be the one from Async[F]?  I'm not following why we're specifically shifting back on this effect.

This became a casualty of the schism, sorry!


Automatically provision a proxy for the daemon

It would be beneficial to migrate to docker-compose and automatically provision a proxy that sits in front of the daemon. This can be done manually, but it may be wise to utilize/integrate other projects like jwilder/nginx-proxy and JrCs/docker-letsencrypt-nginx-proxy-companion. Doing so would allow users to run this project by itself without issue, or run it on a server running other containers already utilizing the aforementioned projects.
Benefits gained from using a proxy and automatically using letsencrypt:

Ability to configure the server for a specific domain name (enables hosting instances for abstract domains)
Ability to proxy different host ports to individual containers (e.g. clients would connect to domain.com:123 and be proxied to yourserver:456), which enables hosting multiple containers for a single domain
Ability to automatically provide free SSL via LetsEncrypt (should we manage ciphers, or leave that up to the person running the container? see https://cipherli.st)

Resources:

https://github.com/mumble-voip/mumble/issues/1680 Updating the SSL Certificate

This should potentially be moved into a separate repository.


Two FFF classes,

In the fastfeedforward project, the Class FFF is defined  in  fastfeedforward/fastfeedforward/fff.py
In the   UltraFastBert project the class FFF is defined in UltraFastBERT/training/cramming/architectures  /fff.py
While both inherit from torch.nn.Module, they both have two different implementation of the foward() function.
I assume the UltraBert forward function is an implementation of algorithm 1 in the paper, "Exponentially Faster Language Modeling", but I don't understand the notation in algorithm 1, so I cannot verify that the python code corresponds to algorithm 1.
From what I can understand, the forward method in UltraFastBert would be eval_forward(), if UltraFastBert were to be used in the same context.
Please unify the architecture, or change one to FFFAlpha, and the other to FFFBeta. It sounds dumb, but I'd appreciate if you could concisely explain when each forward() should be used.

Hi,
Yeah, the idea is that eventually all FFFs are living together in this repository. Currently, the one branch closest to the idea is sparse, but we're hoping to have a well-performing native CUDA implementation in a month or so.
Which part of the notation of the Algorithm 1 do you not understand? Happy to help there.


The dataset have many columns (40+),whether  the table could move horizontally ?

Thanks your code, it looks powerful!
Now , my dataset have many and many columns,.I want to konw whether the table could scroll horizontally?
many thanks!

Hi zhoutonghan,
first of all I want to thank you for the positive feadback! :)
If you want to do some horizontal scrolling you can do that by simply putting the TableView inside a android.widget.HorizontalScrollView. The table will work the same way you have experienced before and the HorizontalScrollView enables you the shift the complete table to the left and right.
Kind Regards,
Ingo

Hi ISchwarz23,
Thank you very much! I will try it .
BEST WISHES!

ps: it may be better,if the data's Gravity in the cell is Gravity.CENTER. I think so.
thank you!

You are free to do so by writing your own TableDataAdapter. All you need to do is to create a new TextView with width MATCH_PARENT and then center the Text inside ;-)
Am 18.01.2016 08:37 schrieb zhoutonghan notifications@github.com:ps: it may be better,if the data's Gravity in the cell is Gravity.CENTER. I think so.
thank you!
—Reply to this email directly or view it on GitHub.


Appstudio update hacbs-test-project-gepp

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-gepp-on-pull-request-
creating pipelinerun hacbs-test-project-gepp-on-pull-request- in namespace rhtap-demo-vrka-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request


Fix the problem for setting pooling strategy for BUCC and Tatoeba tasks

This PR fixes #72 by passing commandline argument pool_type to extract_embeddings function whenever it's called in evaluate_retrieval.py.

Thanks for fixing this.


Update dependencies

fix: Upgrade client_common to v1.0.0-beta.21 fix: Keep me logged in text alignment (#58)

fix: Upgrade client_common to v1.0.0-beta.21

feat!: Upgrade client_common to v1.0.0-beta.22

feat: Upgrade client_common to v1.0.0-beta.23

feat: Upgrade client_common to v1.0.0-beta.24

fix: Upgrade client_common to v1.0.0-beta.25

fix: Upgrade lenra_components to v1.0.0-beta.51


how do i add custom attributes to material component ??

i want to add custom attributes to one of material component.. (tabs component)
<md-tab>         <template md-tab-label [routerLink]="['/dvsOverview']">Overview</template>         <template md-tab-content>            <dvs-overview></dvs-overview>         </template> </md-tab>
how can i add custom attributes like that ??
@jelbourn @kara @DevVersion @hansl @robertmesserle @crisbeto

don't put them directly on the template element..
<template md-tab-label>
  <a [routerLink]="['/dvsOverview']">Overview</a>
</template>

@fxck  did the exact same thing..

@ashishsajwan In the future, please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.
Giving a direct mention to the entire team is also not polite, please refrain from doing that again.


Remove server support for TLS1.0

This should not be needed any more and is not recommended.
Signed-off-by: Justin Cormack<EMAIL_ADDRESS>

cc @n4ss

I think that go-connections is used pretty much everywhere, and some clients (ex: homebrew's docker-compose between ] Snow Leopard ; Sierra ]) do not support TLS > 1.0 yet because of the super old OpenSSL version (0.9.8) that is linked with the default macOS python.
This is why I added modifiers on the default config generators: https://github.com/docker/go-connections/commit/5bd7d320e8c44eaa221c55748c646a0b74a04c7e
That way we can set the min TLS version project-by-project / product-by-product accordingly to back-compatibility.

For Docker for Mac (which may only support 10.11 and 1.12 now?) we can ship compose linked against any version we like. That is also what Apple seems to recommend anyway. For self install most people use homebrew, which has later versions. So I think we should fix this in compose.

Is there any good reason to keep around TLSv1.1 as the minimum version as opposed to just going straight to TLSv1.2. I don't know of any clients that support 1.1 and not 1.2

Yes, happy to remove 1.1 at the same time.

@n4ss Possibly docker-compose and docker-py may support TLS>1.2 - at least, if it's pip install-ed it should:  https://github.com/docker/docker-py/pull/1563.

LGTM

lgtm


md-input ngControl attribute no longer works. since angular2-rc

Note: for support questions, please use one of these channels:
https://github.com/angular/material2/blob/master/CONTRIBUTING.md#question.
This repository's issues are reserved for feature requests and bug reports.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Using an ngControl on md-input causes error:
Error: Uncaught (in promise): No value accessor for 'username'
when providing in template as:

<form #loginForm="ngForm" (submit)="onSubmit(loginForm.value)">
        <md-input ngControl="username" placeholder="user" ></md-input>
        <md-input ngControl="password" placeholder="pass" type="password"></md-input>
      <button md-raised-button color="primary" [disabled]="!loginForm.valid" type="submit">login</button>
    </form>

If the current behavior is a bug,
please provide steps to reproduce and if possible a minimal demo of the problem
via https://plnkr.co or similar.

What is the expected behavior?
No errors shown, and works as normal input (changing md-input to normal input makes this functional again)

What is the motivation / use case for changing the behavior?
It seems to break every usage of ngControl on these inputs.

Which version of Angular and Material, and which browser and OS does this issue affect?
Did this work in previous versions of Angular / Material?
Please also test with the latest stable and snapshot versions.
I'm running the lastest config on webpack-angular2-starter, so the latest (alpha 4) material release and angular rc 1.

Other information

Trying to set up a plnkr atm.

I was adding the FORM_DIRECTIVES from 'angular2/common';
That is wrong and that breaks stuff so no issue.


Article on factorial of large numbers

Have you read the Contributing Guidelines on Pull Requests?
Yes.
Description
Article on factorial of large numbers
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
Fixes #155

@HarshCasper please review my PR.

@HarshCasper made the desired changes have a look.
Thanks!


Output directory now used by target_file_name

Fixup bug from clap migration where the target file name was determined using the target argument and the docs indicate that it should be determined using the output argument.

Fixes  #90

There's a bit of non-trivial logic going on here, could you extract this into a fn and add some unit tests?

There's a bit of non-trivial logic going on here, could you extract this into a fn and add some unit tests?

Done, added a test for each of the cases in that logic.

Thanks a lot.


pull request for e2e test at 01/30/2017 12:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Hi I have built a collaborative video editor using evolu

You can check my app here
https://www.starpy.me/

@danilaplee Wow! Will check as soon as I finish refactoring (no API changes, new features)

@danilaplee May I add to https://www.evolu.dev/docs/showcase?

Added to https://www.evolu.dev/docs/showcase
@danilaplee Thank you :-)


Refactor code for readability and maintainability

Refactor of codebase to aid with readability and maintainability.
The code is mostly identical to the existing code but functions and data declarations have been moved into separate files.  Some refactoring has been done to split functionality into separate functions to provide a cleaner separation.
In general, files named with a prefix of agon are responsible for hardware features, and those starting with vdu are handlers of the VDU byte stream.  Other files provide higher level capabilities and abstractions and are named according to their function.
Incorporates the screen mode change fix from #80
This refactor mostly represents/mirrors the codebase that will form the basis of the VDP code for the Agon Console8.  The only differences at present is the Console8 version of the VDP code already includes the audio enhancements from #76, and further audio enhancements to add frequency envelope support.
The refactoring in this PR will allow for easier further refactoring to help make better use of PSRAM, thus reducing the use of internal RAM on the VDP.  This will enable work to be done on adding in various new features.

This PR has been updated so that it will merge, rebasing it on the current main branch.
NB it is arguably superseded by #88 as that PR contains all of the changes from this, plus the frequency envelope support from #86 as well as significantly improved memory management.
This PR represents an earlier step along the way to the codebase in #88 - in principle it could be merged first, as all of these commits are present in that later PR.  As noted in the description for this PR, there is very little in the way of actual code changes here - those came later.

Closed as 'Won't Do' as this is now duplicated by  #88


update submodules OmniXXX: prevent bogus pod suspended message

This fixes an intermittent error where user is incorrectly told their pod is suspended.
It has been reported several times for Loop and a Loop Report file was captured one time.
This enabled analysis that this spurious message occurs when attempting to bolus following a comms error.
This change was determined to be correct from code inspection.
Please see: Bug: Incorrect pod suspended message when bolusing after comms error

Merging with 2 approvals.


add script to generate a diagram of JDL grammar

Hi @MathieuAA!
I just created this PR to show you a chevrotain tool that I found really useful in the Java parser we developed: it generates an HTML diagram of the JDL grammar. I think it could be useful when debugging some tricky bugs
Please make sure the below checklist is followed for Pull Requests.

[ ] Checks are green
[ ] Tests are added where necessary
[ ] Documentation is added/updated where necessary
[x] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

I didn't see it was already done :)


Support multi-platform images

Right now only linux/amd64 architecture is supported, but image can be build for a variety of architectures.
I believe only a simple change to the GitHub workflow based on this guide is required. I will do y best to create a PR, although I am not an expert

stumbled over the same: there is also a blog post for that https://www.docker.com/blog/multi-arch-images/


Explicitly add -analyzed flag to analyze & export

Without this flag export is unable to reuse layers.
This results in errors on rebuilds like:
Error: failed to export: cannot reuse io.buildpack.java, previous image has no metadata for layer io.buildpack.java`

This flag appears to be incompatible with existing builders.
cc @trisberg


Fix receipt broadcast to listening clients; add unit tests

Fixing the broadcast of transaction receipts to listening clients.
A client can listen for receipts on websocket by connecting to the ws://<host>:<port>/ws endpoint. It will be registered with the fabconnect server once it sends the following payload:
{"type":"listenreplies"}

Codecov Report

Merging #77 (0fa9d80) into main (291490c) will decrease coverage by 5.09%.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   54.84%   49.75%   -5.10%
==========================================
  Files          35       39       +4
  Lines        3147     3668     +521
==========================================
+ Hits         1726     1825      +99
- Misses       1315     1734     +419
- Partials      106      109       +3

Impacted Files
Coverage Δ

internal/rest/receipt/leveldb.go
4.09% <0.00%> (ø)

internal/rest/receipt/memdb.go
27.90% <0.00%> (ø)

internal/rest/receipt/mongodb.go
0.00% <0.00%> (ø)

internal/rest/receipt/receiptstore.go
37.14% <18.18%> (ø)

internal/rest/restgateway.go
79.54% <100.00%> (+5.68%)
:arrow_up:

internal/rest/router.go
29.76% <0.00%> (+3.17%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291490c...0fa9d80. Read the comment docs.

I was getting the following error when trying to push a commit for addressing the review comments. So will leave them to a later PR.
remote: error: GH006: Protected branch update failed for refs/heads/receipt-broadcast.
remote: error: Required status check "DCO" is expected.
To github.com:hyperledger/firefly-fabconnect.git
 ! [remote rejected] receipt-broadcast -> receipt-broadcast (protected branch hook declined)
error: failed to push some refs to 'github.com:hyperledger/firefly-fabconnect.git'


feat(styles): Update buttons colors

@rouvenpost I need your design review to check if it's correct and if I didn't miss any change.

I think we shoul remove the «Accent colors» Section altogether. They should not be used anymore.

I think we should remove the «Accent colors» Section altogether. They should not be used anymore.

You're right. They will be deprecated with this ticket: https://github.com/swisspost/design-system/issues/2863


Adding AreChangesTracked to EM and splitting API to run on RS5+.

I realized that the APIs for EM can work down-level.  The only feature that needs windows 11 is reverting changes.  To address this I propose to

Add a 2nd method that returns a boolean indicating if the ev changes will be tracked.
Change the behavior of IsSupported to always return true.

spec PR: https://github.com/microsoft/WindowsAppSDK/pull/2544

Closing because the PR is done.


In 'Your Observations', inconsistent timezone between Grid View, List View 'Observed' column, and List View 'Added' column

Describe the bug
Observation observed, added, and viewed from within the same timezone.
However, the timezone used for the 'Your Observations' page is not the same:

whether it is viewed as Grid, or as List
when viewed as List, between 'Observed' and 'Added' columns.

To Reproduce
Steps to reproduce the behavior:

Go to 'Your Observations' to view any obs (in the example below, made, added, and viewed from within the same timezone at the same time of year, in the example below 'CEST' = 'UTC+02:00')
Click on 'Grid'
Note the timezone used when hovering over the 'am-time-ago' text for that obs, e.g. "Observed on 2024-07-22T10:14:00+02:00" (which is correct)
Click on 'List'
Note the timezone used in the 'Observed' column, e.g. "Jul 22, 2024 9:14 AM CET" (which is wrong, cf. point 3)
Note the timezone used in the 'Added' column, e.g. "Today 12:00 PM WAT" (which is wrong, cf. point 1)

Expected behavior
Everything should be reported consistently: either in agreement with the one timezone chosen by the user in their 'Settings' page; or in agreement with the timezones (occasionally different) in effect respectively during the observation, during the addition, and during viewing for an obs.
Context

OS: Windows 11
Browser: MS Edge
Version: 128.0.2739.42 (Official build) (64-bit)

Additional context
Logged in user, viewing a proper observation created from a photo (a) taken from within CEST/UTC+2 zone with a functioning and properly-configured camera (b) added from within CEST/UTC+2 zone with a notebook computer (c) viewed from within CEST/UTC+2 zone with that same notebook.

Could you please provide a URL to an explore search demonstrating the problem? The expected behavior after releasing a fix for this issue is that the time observed should be in the observers time zone and the time added should be in the viewers time zone, the same as is shown on the observation details page. If they are the same time zone, then indeed they should be presented the same.
We prefer users post to the iNaturalist Forum. There is a bug report template there that asks for things like screenshots and URLs, and that venue is better for other community members to offer their experiences on the issue, all of which help us investigate the problem efficiently. When a staff member confirms the issue, they will make a Github issue linking to the discussion in the Forum.

Oh ok, sorry for the noise, forget about it.

Ok, sorry for the noise.


chore(dartdoc): don't cross link to sources

Remove dartdoc —add-crossdart flag.
cc @kwalrath

LGTM


Modify gcloud-java logo to be white svg

Screenshot?

LGTM. I'll wait for JJ to sign off on the screenshot.

Here's a demo: http://ajkannan.github.io/gcloud-python/

LGTM


development: test GitHub Codespaces for developing the package

How long does the environment take to start up
How much idle time does it allow you?

let's not worry about this now.


Can't show /users page

NodeBB v1.6.0
No user data
Theme Persona is ok

This one's weird, the templates are almost identical not sure why it is not rendering on material.


Apple M1 MacBook Pro: winit bump

On an Apple M1 MacBook Pro, the winit dependency build fails with:
   Compiling winit v0.19.3
error[E0308]: mismatched types
   --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/view.rs:209:9
    |
205 | extern fn has_marked_text(this: &Object, _sel: Sel) -> BOOL {
    |                                                        ---- expected `bool` because of return type
...
209 |         (marked_text.length() > 0) as i8
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `bool`, found `i8`

error[E0308]: mismatched types
   --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:102:26
    |
102 |             is_zoomed != 0
    |                          ^ expected `bool`, found integer

error[E0308]: mismatched types
   --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:174:57
    |
174 |                 self.window.setFrame_display_(new_rect, 0);
    |                                                         ^ expected `bool`, found integer

error[E0308]: mismatched types
    --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:1290:48
     |
1290 |         window.setFrame_display_(current_rect, 0)
     |                                                ^ expected `bool`, found integer

error[E0308]: mismatched types
    --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:1297:48
     |
1297 |         window.setFrame_display_(current_rect, 0)
     |                                                ^ expected `bool`, found integer

error[E0308]: mismatched types
    --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:1314:48
     |
1314 |         window.setFrame_display_(current_rect, 0)
     |                                                ^ expected `bool`, found integer

error[E0308]: mismatched types
    --> /Users/jsm/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/macos/window.rs:1321:48
     |
1321 |         window.setFrame_display_(current_rect, 0)
     |                                                ^ expected `bool`, found integer

This is fixed in winit v0.24.x (see https://github.com/rust-windowing/winit/issues/1782 where this was reported originally).
So, I bumped winit and made a bunch of changes to catch up with its more recent API. After that, I was able to run some of the examples on an M1 Mac (eg. canvas_minimal is working). See this diff for the changes required to canvas_minimal/src/main.rs: https://github.com/lancelet/pathfinder/commit/720785e5abee0a27759b9ebfbcfe3b4ecd3bff40#diff-53ffc830c4d0e3773cb67c3cedd3e24330ba22eccc7ccb66f731b9586fdf6584
However, there's a circular dependency between both pdf and pathfinder, which is making it difficult for me to complete the refactoring within pathfinder itself. pdf and pdf_render bring in a dependency on winit, and use a part of the pathfinder API that has been made private:
error[E0599]: no method named `points` found for reference `&Contour` in the current scope
  --> /Users/jsm/.cargo/git/checkouts/pdf_render-56211f49c16f7190/a57d54f/render/src/graphicsstate.rs:83:50
   |
83 |                 let clip_polygon = outer_contour.points();
   |                                                  ^^^^^^ private field, not a method

To make things worse, pdf and pdf_render seem to be using patches on top of pathfinder, so that confuses the matter still further.
I don't know what the best way forward is. If pdf depends on pathfinder, perhaps it's best not to use pdf examples in pathfinder itself, but rather put appropriate examples in the pdf package instead? (Or in a third party repository which coordinates a minimum bound on the two?) Any suggestions? If I raised a PR to remove pdf and pdf_render as dependencies for all of pathfinder (ie. removing those examples), would that be accepted?

Pathfinder is not actively maintained, but pdf_render relying on a fork of pathfinder does make it harder. It looks like the API issue is due to the pathfinder fork exposing a method that this repository does not: https://github.com/s3bk/pathfinder/commit/32497ee2d23eae8f3be46cdd4fadf562018ed524 .
What if you made a PR to update winit in pdf_render first? Would that be enough to allow updating the pdf_render dependency in this repository?

I'll give that a go.

Yes the points method is a bit of a hack to get nested clip paths working. But I also can't really remove it without breaking clip paths in pdf_render.

@jdm is there a chance of merging #474 ?
If not I have to figure out a way to keep clip paths working without it.
Keeping the fork is quite annoying for everyone.

Yep, sorry about that!

This issue isn't fixed, despite merging #474, right? I'm still getting 'mismatched types' errors for winit when trying to run the demo/native example.

Sorry, I will test it now.

pdf_render does not have a fixed version of winit, so I would expect that a cargo update should fix it?

It runs on linux.. until it crashes.

well. I am a git "master". Turns out it helps to test in the correct repository ...
I am trying now with https://github.com/servo/pathfinder/pull/490

It compiles in https://github.com/servo/pathfinder/pull/491 .. but instantly crashes.
The application panicked (crashed).
Message:  attempted to leave type `platform::platform::x11::util::input::PointerState` uninitialized, which is invalid
Location: /home/sebk/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.19.3/src/platform/linux/x11/util/input.rs:94

Still getting the winit compilation errors. I mean, the version still seems to be on, <0.19.4, right?

Maybe your x11 errors are unrelated?

Maybe. I will try updating winit to 0.26

Surfman needs updating too ....

Yeah. Just found the surfman dep as well.

We are using this commit it seems like: https://github.com/servo/surfman/blob/f3df871ac8c3926fe9106d86a3e51e20aa50d3cc/surfman/Cargo.toml

Seems to be the @pcwalton's last commit on the project. That explains it.

shall I send you my changes so far?

You could. I guess it's just a lot of winit changes to accommodate.

Not the winit expert myself. Don't really know which of these errors just need their names changed and which need complete overhaul. Can't tell how much winit has changed since then.

Same. But it is quite late here and I need to fix my font crate.
Maybe it is useful.
https://gist.github.com/s3bk/b4749790561b80778275cc4fde5873b8

BTW @s3bk, why are u trying to debug this? Are you interested in this crate because of glyph dilation as well? Or different reason?

I was just trying to get the demo back working for you.
I use pathfinder via https://github.com/s3bk/pathfinder_view which is working.
The font crate is used to (duh) render pdfs... and extract text from it.

Hello! Now that the servo project is being reactivated, are bugs like this one expected to be addressed moving forward?

No. Pathfinder is not used in Servo at this point in time,and I'm not aware of plans to integrate it.

Thank you. What does Servo currently use for vector graphics rasterization/rendering?

Servo does not perform vector graphic rasterization at this time.

@jdm Got it, thank you. How is Servo currently rendering text and vector-based graphics, such as svg? Is that CPU-based currently?

Servo does not support svg at this point. It uses font-kit for rendering text.


macOS 12.6 breaks MailTrackerBlocker

Just updated to 12.6, and macOS now disables MailTrackerBlocker and calls it incompatible. Any updates?

Same here. Have downloaded what this page suggests may be the latest version. Still get that error each time. Any ideas, please? Thanks!

Fixed in 0.7.4, see #186.

I’m still getting the error with this file https://github.com/apparition47/MailTrackerBlocker/releases/download/0.7.4/MailTrackerBlocker.pkg.
My pols: what am I doing wrong, please?

On Sep 12, 2022, at 18:34, Aaron Lee @.***> wrote:
Fixed in 0.7.4, see #186 https://github.com/apparition47/MailTrackerBlocker/issues/186.
—
Reply to this email directly, view it on GitHub https://github.com/apparition47/MailTrackerBlocker/issues/187#issuecomment-1244790172, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATC536GZX3NWMBWM2DYK4M3V57KZDANCNFSM6AAAAAAQKYF5GA.
You are receiving this because you commented.

--
best...
Mark Sealey
www.markworks.com
‘It is the microbes that will have the last word' Louis Pasteur (1822-1895)

@MarkSealey Sorry, had to pull this update. 0.7.5  should work instead. Thanks for reporting

@MarkSealey Sorry, had to pull this update. 0.7.5 should work instead. Thanks for reporting

Huh, 0.7.4 did the trick for me (Big Sur 11.7). And I also await the improved 0.7.5 🙏 Thanks for the quick turnaround Mark!


[FLINK-16501][sql] Support IS JSON predication for Table API in blink…

What is the purpose of the change
Support IS JSON predication for Table API in blink planner
IS_JSON_VALUE
IS_JSON_OBJECT
IS_JSON_ARRAY
IS_JSON_SCALAR
IS_NOT_JSON_VALUE
IS_NOT_JSON_OBJECT
IS_NOT_JSON_ARRAY
IS_NOT_JSON_SCALAR
Brief change log
(for example:)

Introduce IS JSON predicates to BuiltInFunctionDefinitions.java and BaseExpressions.java
Implement supporting generation logic, including a new jsonExpressions.scala
Add corresponding test cases

Verifying this change
(Please pick either of the following options)
This change added tests in JsonFunctionsTest.scala
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Finalized in #16805