✨ Consider Pinning Node to LTS release

What are you trying to do?
A user reported that they were surprised to see us using a non-LTS version of Node in our Typescript SDK.
We should consider pinning our TypeScript SDK to the LTS version of node as we approach "dagger 1.0"
Why is this important to you?
Since we expect people to adopt this SDK in their production pipelines, I think we will have a lot less issues long term if we stick to a stable version of node. Node's own documentation recommends using only LTS releases for production applications since they will come with 30 months of support instead of just 6 (for odd numbered releases)

Major Node.js versions enter Current release status for six months, which gives library authors time to add support for them. After six months, odd-numbered releases (9, 11, etc.) become unsupported, and even-numbered releases (10, 12, etc.) move to Active LTS status and are ready for general use. LTS release status is "long-term support", which typically guarantees that critical bugs will be fixed for a total of 30 months. Production applications should only use Active LTS or Maintenance LTS releases.

How are you currently working around this?
N/A

Thanks for reporting, I can take care of the changes and see if it break anything this week.

As explained in #7481, instead of pinning Node to LTS release, we'll support dynamic version so the user can configure which version he wants to use by setting the field engine.node in its package.json.
By default, we'll use the LTS version, probably 20.14 until v22 become the active LTS release.
Here's a copy of the discussion in #7481

Node upgrades / downgrades are always tricky since its not just the user code that you have to be worried about. Internally we use 20.11, and one of our devs was setting up a new machine and he had 20.13 installed. Things broke.

I like the ability to configure which version of node is used, while having a minimum supported version. Something like this will probably be needed for the bun runtime since that is adding new features on a quicker cadence

Alright, I'm closing this PR for now, as you said, it's better to allow node configuration which is possible by checking the engine.node field of the package.json.

I'll take care of that later, I'll put a comment in the issue as a reminder

Hi. So, the use of version 21 is actually breaking me right now. Is there a workaround I can use to get Dagger to use version 20 until this is released?


Formatter discards scientific notation info

See https://github.com/rtfeldman/roc/pull/1039/files#r583947846

The formatter doesn't seem to affect scientific notation, but the compiler sure doesn't like it!
[jan@framey roc]$ cat test.roc
app "test"
    packages { pf: "examples/hello-world/platform/main.roc" }
    imports []
    provides [main] to pf

main = Num.toStr (5e4 + 5e-4)
[jan@framey roc]$
[jan@framey roc]$ roc format test.roc
[jan@framey roc]$
[jan@framey roc]$ cat test.roc
app "test"
    packages { pf: "examples/hello-world/platform/main.roc" }
    imports []
    provides [main] to pf

main = Num.toStr (5e4 + 5e-4)
[jan@framey roc]$
[jan@framey roc]$ roc test.roc
🔨 Rebuilding host...
An internal compiler expectation was broken.
This is definitely a compiler bug.
Please file an issue here: https://github.com/roc-lang/roc/issues/new/choose
thread 'main' panicked at 'Undefined Symbol in relocation, (+49b6, Relocation { kind: Relative, encoding: Generic, size: +20, target: Symbol(SymbolIndex(+1e8)), addend: +fffffffffffffffc, implicit_addend: false }): Ok(Symbol { name: "", address: +0, size: +0, kind: Section, section: Section(SectionIndex(+8)), scope: Compilation, weak: false, flags: Elf { st_info: +3, st_other: +0 } })', crates/linker/src/lib.rs:2731:25
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[jan@framey roc]$

Actually, the formatter doesn't seem to care about... anything...
[jan@framey roc]$ cat test.roc
app "test"
    packages { pf: "examples/hello-world/platform/main.roc" }
    imports []
    provides [main] to pf

main = Num.toStr (5e4 + 5efgh-4)
[jan@framey roc]$
[jan@framey roc]$ roc format test.roc
[jan@framey roc]$
[jan@framey roc]$ cat test.roc
app "test"
    packages { pf: "examples/hello-world/platform/main.roc" }
    imports []
    provides [main] to pf

main = Num.toStr (5e4 + 5efgh - 4)
[jan@framey roc]$

Like Jan noted, the formatter is respecting this syntax now. However there seems to be some other bugs preventing it from working as expected. I think it is a good thing that the formatter should respect 5efgh even though it is of course invalid. I don't see anything that needs to be done for this issue in particular, so I will close it.


Extra addons

Is there a way to introduce add-ons from the vaadin directory. I would like to add support for maps but not sure how to do that in vertx-vaadin. I know there is a separate widgetset. Is there a way to extend it?
Thank you in advance for your reply.

If you are on vaadin 14 you can use compatible addons from directory; there's no widgetset anymore for components.
GWT is now used  for the low level communication stuff between client and server, but not for components.
Beware that you can have troubles if the addon has explicit referencs  on servlet stuff (eg VaadinServletRequest).
In general a Vaadin application written to run into a servlet container should work without changes with vertx-vaadin.
However, if the application uses PUSH you should exclude flow-push and flow-client and depend on vaadin-flow-sockjs module.
See https://github.com/mcollovati/vertx-vaadin/tree/master/vertx-vaadin-flow-parent/vertx-vaadin-flow/README.md for some detail.

Thanks a lot for your reply. Is it possible to use vaadin-vertx 8 with add-ons?
Also, if you were to start a new project would you go with vaadin 8 or 14? Do you think vaadin 14 is mature enough?
In my scenario I need to use a map component. I can use one of the available in jQuery. Do you think there is a good support for external JavaScript components (with callbacks support) in vaadin-vertx 14?

You can use vertx-vaadin 8 with addon, but in this case may have to recompile the widgetset ( (as you said).
For a new project I would definitively got with Vaadin 14; Vaadin 8 maintenance will end on February 2022;
and IMO integrating external components is much easier with Vaadin 14, especially web-components (https://vaadin.com/docs/v14/flow/web-components/integrating-a-web-component.html).
Furthermore Element javascript api now allows also to obtain return value of function executed on client side
(https://vaadin.com/docs/v14/flow/element-api/client-server-rpc.html#return-values)
Also for map it seems there are several addons for Vaddin 14 on directory

Thank you very much that helps a lot.
Two last things,

Is it possible to compile the vaadin-vertx 14 (with my custom views and add-ons) into a single JAR and use it in another project?
Regarding "If you are on vaadin 14 you can use compatible addons from directory", Is there some extra steps (like pre-compilation) I need to take to be able to use those add-ons?

I think there should be no problem creating an uber jar with vertx-vaadin, addons and your code, but I can't see how this can be better than simply depend on them separately on the other project.
Only extra step should be configure maven or gradle vaadin plugin (see https://vaadin.com/docs/flow/getting-started/getting-started-gradle.html)

Thanks.
Regarding 2. vaadin-vertx already has it configured, am I right here? I mean the maven plugin. As such, if I decide to go with maven setup (instead of gradle) I don't need to do anything. Is that correct?

vertx-vaadin is just a library. You should configure the build tool (maven or gradle) on your own.
Getting started section of REAMDE may help you to setup a simple project with maven..

I'm going to close this issue. If you need further help we can get in touch in then newly created Gitter room


Remove username from password_reset MBP payload

Fixes #3921
Remove username from mbp password_reset payload as it's not used by the Mandrill template.

:+1:


Add build for with NumPy 1.21

A vulnerability of NumPy has arisen.
https://github.com/advisories/GHSA-6p56-wp2h-9hxr
We should review our build matrix.

https://numpy.org/neps/nep-0029-deprecation_policy.html#nep29
see https://numpy.org/neps/nep-0029-deprecation_policy.html#implementation

When a project releases a new major or minor version, we recommend that they support at least all minor versions of Python introduced and released in the prior 42 months from the anticipated release date with a minimum of 2 minor versions of Python, and all minor versions of NumPy released in the prior 24 months from the anticipated release date with a minimum of 3 minor versions of NumPy.

So that means currently (Jun 21, 2022) we should support py 3.8+ np1.20+
As numpy 1.23 and python 3.10 have been released, I think we should be building (and testing):

python version
numpy versions

3.6
1.15

3.8
1.20, 1.21, 1.22, 1.23

3.9
1.20, 1.21, 1.22, 1.23

3.10
1.21, 1.22, 1.23

https://numba.readthedocs.io/en/stable/user/installing.html#:~:text=Numba is compatible with Python,versions 1.18 up to 1.22.
Numba is compatible with Python 3.7–3.10, and Numpy versions 1.18 up to 1.22.
So I propose we build:

python version
numpy versions

3.6
1.15

3.8
1.20, 1.21, 1.22

3.9
1.20, 1.21, 1.22

3.10
1.21, 1.22


Fill the description and website at the top of repo

Put the link https://github.com/The-Brains/ChaosGame as the website.

I meant https://the-brains.github.io/ChaosGame/

Done.


Year update 2018 for meta data.

I actually think removing the year makes the most sense but I'll merge this for now.


Hide / Show of chart containers fails to render chart properly

I am having an issue on a site that (unfortunately) I cannot link to.  I have attempted to create a mock of the problem in JSFiddle but I am not getting the same behavior.  Essentially I am using the c3 charts as widgets for a dashboard page.  Our application allows a user to have multiple "tabs" open like the worksheets in excel, where the dashboard page is the main tab and is always open.  When a user creates a new tab it essentially hides the others and only show's the tab they have selected.  At some point during this process when they click back to the dashboard tab, the c3 chart is rendered without taking into account the right hand boundary of the div it is bound to.  This results in a long stretched chart that runs into other widgets on the page.  I was unable to reproduce this in JSFiddle but I can reproduce "something".  I have been able to fix the rendering of the chart by manually calling $.resize() on the widget container any time tab visibility changes.  Just wanted to know if anyone else has experienced this type of thing.  On the JS fiddle below you can see some other wacky behavior where if you hide the chart, then resize the output container (drag the window boundaries or something) and then show the widget the chart fails to render at all.  Clicking the "resize" button calls the $.resize() event which re-renders the chart.
http://jsfiddle.net/24enb809/1/

@lilasquared Hi! Thanks for reporting.
Hmmm... This seems like a duplicate of #934 and possibly #924. Can't say I've ever run into the initial behaviour you mention; would you mind reporting that in a separate issue if you can isolate it via a jsfiddle? Thanks!

Reopening because this issue documents the fact that rendering fails if generate is called on any hidden element, which may be a different issue than the Chrome tab one.
@lilasquared Thanks for the really good example, BTW! Here's an updated Fiddle — calling c3.generate() on any element not visible causes rendering to fail. Try hiding the widget, redrawing the chart, and then showing the widget. No chart!

Update: I totally know why this is happening. C3 is trying to get the containing element's width and height, which are undefined when an element is hidden (or, I'm guessing, in an inactive Chrome tab). If you explicitly set the width and height via chart.size.width and chart.size.height, it renders properly when unhidden. See this SO answer about a similar behaviour in AMCharts, and this updated Plunker, wherein the width/height are explicitly defined (try hiding and redrawing, or hiding and resizing the window — the chart is properly rendered when shown).
@masayuki0812 Not sure whether this is a bug that we can address or an edge case that has to be handled by the user. My feeling is the latter — we could walk up through the elements' parents until we come across an element with height or width defined, but I can totally seeing that causing more issues than it solves...

Thanks Andrew for such a prompt and thorough response!  I can see that adding the width to the chart size options is a valid solution and will solve the problem I am having, but in the future we will be using widgets of various sizes so explicitly defining the size on the chart would be a painful thing to do.  I may be able to rewrite the functionality that hides and shows tabs to set the visibility property instead of display.  Your input has helped a lot!  Thanks so much!

@aendrew also in your latest jsFiddle in chrome once the hide and show happen with the visibility the axes are no longer rendered.  Not sure if you addressed that or not.  Again thanks for the info!

@lilasquared Lulz, hadn't even noticed that. That's really bizarre, will investigate further and possibly post a new issue. Thanks for mentioning it!

@aendrew Haha yeah definitely some bizarre behavior.  For now I might suggest explicitly setting the chart width.

@aendrew we're already doing that https://github.com/masayuki0812/c3/blob/master/src/size.js#L44 . And sorry I don't have any idea to solve this issue. Calling resize or flush when it's visible seems an easy and reasonable solution, I think.


Fix bug with extra uncacheable dependencies

Fixes #479.

I'm going to push this through b/c it's an important fix, but feel free to review post-merge.

I don't understand extra dependencies. Steps must be pure functions or the whole idea of caching them doesn't work. So how can we possibly need an extra dependency that's not an input to the step? The only way it could ever affect the outcome is through side-effects, which breaks all assumptions that make caching work.

Steps must be pure functions or the whole idea of caching them doesn't work.

Ideally, sure. But in practice things are not always that clear-cut. For example, I need to build large datastores for a project I'm working on, and those datastores are so big that using Tango's caching mechanism to pass them around between steps is just way too inefficient. Instead I just save the datastores to NFS, and so my steps that build the datastores don't have any real output. They have side-effects, you would say, that other steps depend on.
I don't think this "breaks all assumptions that make caching work." Caching still works just fine.

The steps should read and write handles to the actual data then. A Format could do this transparently.

Okay, sure, I guess that's not the best example since those steps still have an output, but see the original issue for another example. FYI you approved the PR that added this feature... 🤔

I know I did. And I would have approved this one too. But it has me thinking about the whole thing.
I get the original motivation. In that scenario the two steps don't communicate through side effects, so it seems safer.
Though even in that scenario, I'd either

write a step that passes through unchanged whatever is passed to it, and also prints something
derive a step that first prints before calling super().run(...).
I like the first thing a lot actually.


We need to cache the front page stats

Currently it takes a long time to load up the front page
http://<IP_ADDRESS>
Can we cache those stats of something to make it load up faster?

It is bug, because the statistic for world on staging just taking like 2-3 secs
Already fixed by https://github.com/healthsites/healthsites/pull/1107


NIFI-7255 Cleaning up obsolete nodes when connecting to cluster

NIFI-7255
Problem statement: In case the connection details of a node changes in a NiFi cluster and restarted, it might occur that the nodes with the old parameters remain in the "node list" of the nodes combined with the new version, thus duplicating the nodes. This results unreachable nodes and fail of replication in the end.
Solution proposal: both the node coordinator needs to clean up obsolete nodes, both the other nodes. This happens with comparing existing information from the local storage and incoming information from connection messages. As the id remains during these property changes that is considered as the key of comparison. Note: due to the equals method of the NodeIdentifier is based on only the id, that was not satisfying for check changes. I went with comparing getFullDescription as changing the equals would affect behaviour outside of this fix.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

As this effects only older versions, changing the current main does not seems to be a satisfying solution. This review will be abandoned, a different approach is taken.


Inquiry About Merging the TensorRT Branch

I see there is a branch: tensor-rt that added TensorRT support, but it hasn't been merged. May I ask if there are any issues encountered? And is there an ETA for when it may be merged? Thank you.

Hi @mjason, I spent some time on it this weekend, but wasn't able to get it working with all the tests. Was running into the following error (both with and without a custom logger).
OnnxRuntime::Error: /onnxruntime_src/include/onnxruntime/core/common/logging/logging.h:294 static const onnxruntime::logging::Logger& onnxruntime::logging::LoggingManager::DefaultLogger() Attempt to use DefaultLogger but none has been registered.

Happy to review a PR if someone is able to figure it out.


Tests failing for cross-compile 1.1.0i on linux (for windows 64 - mingw64)

I just stumbled to a similar situation https://github.com/openssl/openssl/issues/5004, trying to build 1.1.0i for windows 64. It works on linux (and tests pass OK), but cross-compiling on linux for windows I have two problems.
First, is that when I use ./Configure mingw64 shared --cross-compile-prefix=x86_64-w64-mingw32-, it gives the same compiling errors from that other issue (regarding BN_ULONG redefinition and others). So, I removed the parameter shared (is that ok?), and now it builds, but fails tests.
make test
make depend && make _tests
make[1]: Entering directory '/home/imcoelho/git-reps/openssl-build/openssl-1.1.0i/build-win-64'
make[1]: Leaving directory '/home/imcoelho/git-reps/openssl-build/openssl-1.1.0i/build-win-64'
make[1]: Entering directory '/home/imcoelho/git-reps/openssl-build/openssl-1.1.0i/build-win-64'
( cd test; \
  mkdir -p test-runs; \
  SRCTOP=../.. \
  BLDTOP=../. \
  RESULT_D=test-runs \
  PERL="/usr/bin/perl" \
  EXE_EXT=.exe \
  OPENSSL_ENGINES=`cd .././engines; pwd` \
  OPENSSL_DEBUG_MEMORY=on \
    /usr/bin/perl ../../test/run_tests.pl  )
../../test/recipes/01-test_abort.t ............ ok
../../test/recipes/01-test_sanity.t ........... ok
../../test/recipes/01-test_symbol_presence.t .. ok
../../test/recipes/02-test_ordinals.t ......... ok
../../test/recipes/03-test_exdata.t ........... ok
../../test/recipes/03-test_ui.t ............... ok
../../test/recipes/04-test_err.t .............. ok
../../test/recipes/04-test_pem.t .............. ok
../../test/recipes/05-test_bf.t ............... ok
../../test/recipes/05-test_cast.t ............. ok
../../test/recipes/05-test_des.t .............. ok
../../test/recipes/05-test_hmac.t ............. ok
../../test/recipes/05-test_idea.t ............. ok
../../test/recipes/05-test_md2.t .............. skipped: md2 is not supported by this OpenSSL build
../../test/recipes/05-test_md4.t .............. ok
../../test/recipes/05-test_md5.t .............. ok
../../test/recipes/05-test_mdc2.t ............. ok
../../test/recipes/05-test_rand.t ............. ok
../../test/recipes/05-test_rc2.t .............. ok
../../test/recipes/05-test_rc4.t .............. ok
../../test/recipes/05-test_rc5.t .............. skipped: rc5 is not supported by this OpenSSL build
../../test/recipes/05-test_rmd.t .............. ok
../../test/recipes/05-test_sha1.t ............. ok
../../test/recipes/05-test_sha256.t ........... ok
../../test/recipes/05-test_sha512.t ........... ok
../../test/recipes/05-test_wp.t ............... ok
../../test/recipes/10-test_bn.t ............... ok
../../test/recipes/10-test_exp.t .............. ok
../../test/recipes/15-test_dh.t ............... ok
../../test/recipes/15-test_dsa.t .............. ok
../../test/recipes/15-test_ec.t ............... ok
../../test/recipes/15-test_ecdsa.t ............ ok
../../test/recipes/15-test_genrsa.t ........... ok
../../test/recipes/15-test_rsa.t .............. ok
../../test/recipes/15-test_rsapss.t ........... ok
../../test/recipes/20-test_enc.t .............. ok
../../test/recipes/20-test_passwd.t ........... ok
../../test/recipes/25-test_crl.t .............. ok
../../test/recipes/25-test_d2i.t .............. ok
../../test/recipes/25-test_pkcs7.t ............ ok
../../test/recipes/25-test_req.t .............. ok
../../test/recipes/25-test_sid.t .............. ok
../../test/recipes/25-test_verify.t ........... ok       T
../../test/recipes/25-test_x509.t ............. ok
../../test/recipes/30-test_afalg.t ............ skipped: test_afalg not supported for this build
../../test/recipes/30-test_engine.t ........... ok
../../test/recipes/30-test_evp.t .............. ok
../../test/recipes/30-test_evp_extra.t ........ ok
../../test/recipes/30-test_pbelu.t ............ ok
../../test/recipes/40-test_rehash.t ........... skipped: test_rehash is not available on this platform
../../test/recipes/60-test_x509_dup_cert.t .... ok
../../test/recipes/60-test_x509_store.t ....... skipped: test_rehash is not available on this platform
../../test/recipes/60-test_x509_time.t ........ ok
../../test/recipes/70-test_asyncio.t .......... ok
../../test/recipes/70-test_bad_dtls.t ......... ok
../../test/recipes/70-test_clienthello.t ...... ok
../../test/recipes/70-test_packet.t ........... ok
../../test/recipes/70-test_sslcbcpadding.t .... ok
../../test/recipes/70-test_sslcertstatus.t .... ok
../../test/recipes/70-test_sslextension.t ..... ok
../../test/recipes/70-test_sslmessages.t ...... ok
../../test/recipes/70-test_sslrecords.t ....... Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/11 subtests
../../test/recipes/70-test_sslsessiontick.t ... skipped: Unable to start up Proxy for tests
../../test/recipes/70-test_sslskewith0p.t ..... skipped: Unable to start up Proxy for tests
../../test/recipes/70-test_sslvertol.t ........ skipped: Unable to start up Proxy for tests
../../test/recipes/70-test_tlsextms.t ......... skipped: Unable to start up Proxy for tests
../../test/recipes/70-test_verify_extra.t ..... ok
../../test/recipes/80-test_ca.t ............... ok
../../test/recipes/80-test_cipherlist.t ....... ok
../../test/recipes/80-test_cms.t .............. ok
../../test/recipes/80-test_ct.t ............... ok
../../test/recipes/80-test_dane.t ............. ok
../../test/recipes/80-test_dtls.t ............. ok
../../test/recipes/80-test_dtlsv1listen.t ..... ok
../../test/recipes/80-test_ocsp.t ............. ok
../../test/recipes/80-test_pkcs12.t ........... ok
../../test/recipes/80-test_ssl_new.t .......... ok
../../test/recipes/80-test_ssl_old.t .......... ok
../../test/recipes/80-test_ssl_test_ctx.t ..... ok
../../test/recipes/80-test_sslcorrupt.t ....... ok
../../test/recipes/80-test_tsa.t .............. ok
../../test/recipes/80-test_x509aux.t .......... ok
../../test/recipes/90-test_async.t ............ ok
../../test/recipes/90-test_bio_enc.t .......... ok
../../test/recipes/90-test_bioprint.t ......... ok
../../test/recipes/90-test_constant_time.t .... ok
../../test/recipes/90-test_fatalerr.t ......... ok
../../test/recipes/90-test_fuzz.t ............. ok
../../test/recipes/90-test_gmdiff.t ........... ok
../../test/recipes/90-test_heartbeat.t ........ skipped: heartbeats is not supported by this OpenSSL build
../../test/recipes/90-test_ige.t .............. ok
../../test/recipes/90-test_memleak.t .......... ok
../../test/recipes/90-test_p5_crpt2.t ......... ok
../../test/recipes/90-test_secmem.t ........... ok
../../test/recipes/90-test_shlibload.t ........ ok
../../test/recipes/90-test_srp.t .............. ok
../../test/recipes/90-test_sslapi.t ........... ok
../../test/recipes/90-test_threads.t .......... ok
../../test/recipes/90-test_v3name.t ........... ok

Test Summary Report
-------------------
../../test/recipes/70-test_sslrecords.t     (Wstat: 1280 Tests: 11 Failed: 5)
  Failed tests:  7-11
  Non-zero exit status: 5
Files=99, Tests=532, 1187 wallclock secs ( 0.65 usr  0.10 sys + 95.36 cusr 116.44 csys = 212.55 CPU)
Result: FAIL
Makefile:157: recipe for target '_tests' failed
make[1]: *** [_tests] Error 1
make[1]: Leaving directory '/home/imcoelho/git-reps/openssl-build/openssl-1.1.0i/build-win-64'
Makefile:155: recipe for target 'tests' failed
make: *** [tests] Error 2

Strange enough, without shared option, it still generates .dll.a, but I don't know if I can trust this one... what do you think?

I see that tests are also failing for LTS 1.0.2p, cross build: ./Configure mingw64 shared --cross-compile-prefix=x86_64-w64-mingw32-
The following command should have some OK's and some failures
There are definitly a few expired certificates
../util/shlib_wrap.sh ../apps/openssl verify -CApath ../certs/demo ../certs/demo/*.pem
../certs/demo/ca-cert.pem: C = AU, ST = Queensland, O = CryptSoft Pty Ltd, CN = Test CA (1024 bit)
error 20 at 0 depth lookup:unable to get local issuer certificate
../certs/demo/dsa-ca.pem: C = AU, ST = Some-State, O = Internet Widgits Pty Ltd, CN = CA
error 20 at 0 depth lookup:unable to get local issuer certificate
382:error:0B06E06B:x509 certificate routines:X509_get_pubkey_parameters:unable to find parameters in chain:x509_vfy.c:2057:
../certs/demo/dsa-pca.pem: C = AU, ST = Some-State, O = Internet Widgits Pty Ltd, CN = PCA
error 18 at 0 depth lookup:self signed certificate
C = AU, ST = Some-State, O = Internet Widgits Pty Ltd, CN = PCA
error 10 at 0 depth lookup:certificate has expired
OK
../certs/demo/pca-cert.pem: C = AU, ST = Queensland, O = CryptSoft Pty Ltd, CN = Test PCA (1024 bit)
error 18 at 0 depth lookup:self signed certificate
C = AU, ST = Queensland, O = CryptSoft Pty Ltd, CN = Test PCA (1024 bit)
error 10 at 0 depth lookup:certificate has expired
OK
Makefile:273: recipe for target 'test_verify' failed
make[1]: *** [test_verify] Error 2
make[1]: Leaving directory '/home/imcoelho/git-reps/neo-hypervm-igor/build/openssl-1.0.2p/test'
Makefile:473: recipe for target 'tests' failed
make: *** [tests] Error 2

I don't think it's the same type of failure... strange.

My solution for 1.0.2p version is (compile linux first, then windows):

I wouldn't call it solution. It just happens to work because of a quirk. Switching among different configurations in same directory can be supported only if you run make distclean prior switching to another configuration. But whatever. Thing is that it's impossible to guarantee that there is solution for make test in cross-compiled case. Things might happen to work or they might not. Well, make test for cross-compiled mingw does work in master, but it doesn't automatically mean that it works in all previous versions. And for previous versions question would be how much effort is sensible to put into it. In other words suggestion is to take it at current face value. If passing all of the make test [in non-master branch] is that important, consider doing it "natively" without cross-compiling.

Thanks for that information @dot-asm . I didn't know master was so much ahead of version 1.1.0i. How much would you say? Is it closer to a new release? By the way, I couldn't use the cross compiled libraries anyway, they somehow didn't seem to work... when I compiled natively on windows they did work on the same scenario. Well, I can say I took this cross compiling as a challenge too, didn't imagine that was even possible :)

Is it closer to a new release?

We are expecting beta release 6 (pre9) today, which is hopefully the last beta before the final release. See also our release plan https://www.openssl.org/policies/releasestrat.html.

The following command should have some OK's and some failures
There are definitly a few expired certificates
../util/shlib_wrap.sh ../apps/openssl verify -CApath ../certs/demo ../certs/demo/*.pem
../certs/demo/ca-cert.pem: C = AU, ST = Queensland, O = CryptSoft Pty Ltd, CN = Test CA (1024 bit)
error 20 at 0 depth lookup:unable to get local issuer certificate
../certs/demo/dsa-ca.pem: C = AU, ST = Some-State, O = Internet Widgits Pty Ltd, CN = CA
error 20 at 0 depth lookup:unable to get local issuer certificate
382:error:0B06E06B:x509 certificate routines:X509_get_pubkey_parameters:unable to find parameters in chain:x509_vfy.c:2057:
../certs/demo/dsa-pca.pem: C = AU, ST = Some-State, O = Internet Widgits Pty Ltd, CN = PCA

I met the exactly same error days ago, in WSL Ubuntu18, which caused by copying source from Linux to Windows. Windows does not support symbolic link, the links in certs/demo, which created by make, are zero-sized. Solution is rm certs/demo/*.0; make clean; make; make test.


support macos 10.13 at least

std::filesystem is not available on macos below 10.15. Despite 10.14 and lower is already beyond their end-of-life date, some people will still use that.
This seems to be a good solution: https://github.com/gulrak/filesystem

closed in next


Create run demo page on wiki

Have a page that starts from deployment of the sample/manifest with lake-creator and lake-user ,  to download demo data, run lake-creator notebook and then run user regression.  Document step by step.

Better yet, create a notebook that execute the demo scripts once the deployment is over.

WIP. Using orbit cli run notebook command, creating demo notebook in lake creator teamspace.

Completed demo notebook creation. Merged to main.


haskell-modules: Add revision argument to callHackageDirect

Previously, callHackageDirect was only able to fetch the first revision of a package.
Resolves #134747
Description of changes
Tested with a random package which needs a revision. Fails without revision argument:
nix-build -E - <<EOE
with import ./default.nix {};
haskellPackages.callHackageDirect {
  pkg = "hopfli";
  ver = "<IP_ADDRESS>";
  sha256 = "sha256-tW96rAmt0SyWXEfm6GdzCFQVS8JigA4ID2rkd9u9pMg=";
} {}
EOE

[...]
Error: Setup: Encountered missing or private dependencies:
QuickCheck >=2.6 && <2.11, hspec >=<IP_ADDRESS> && <2.5

error: builder for '/nix/store/sm9p7bd4kdqpq4yyc2fb24fy8f5q6yrh-hopfli-<IP_ADDRESS>.drv' failed with exit code 1

Succeeds with revision argument:
nix-build -E - <<EOE
with import ./default.nix {};
haskellPackages.callHackageDirect {
  pkg = "hopfli";
  ver = "<IP_ADDRESS>";
  sha256 = "sha256-tW96rAmt0SyWXEfm6GdzCFQVS8JigA4ID2rkd9u9pMg=";
  rev = { revision = "1"; sha256 = "116jns5im51sb9xiwpx308wz3pr67335633anrf8f704pz8vwjka"; };
} {}
EOE

/nix/store/7hfbgajzlbxjpffc858glcq7j37ygl9g-hopfli-<IP_ADDRESS>

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Nope, thank you!
And thank you for posting an easy test in the description. Very helpful.


dismiss method will be called after a long time when main thread busy

test code：
-(void)fadeIn:(id)data {
    @weakify(self)
    [[NSOperationQueue mainQueue] addOperationWithBlock:^{
        @strongify(self)
        NSLog(@"-=-= start");
        NSTimer *timer = [NSTimer timerWithTimeInterval:1 target:self selector:@selector(dismiss) userInfo:nil repeats:NO];
        [[NSRunLoop mainRunLoop] addTimer:timer forMode:NSRunLoopCommonModes];
    }];
    for (NSInteger index = 0; index < 10000; index++) {
        dispatch_async(dispatch_get_main_queue(), ^{
            NSLog(@"other");
        });
    }}

so SVProgressHUD will dismiss After a long time.

Wouldn't this behaviour be the same with any other library?

if like this:
'''objc
[SVProgressHUD showSuccessWithStatus:str];
[SVProgressHUD dismissWithDelay:1];
'''
SVProgressHUD will dismiss as expected.


Published swagger specs are not working

The swagger specs we have published

https://developer.omisego.co/elixir-omg/docs-ui/?url=master/security_critical_api_specs.yaml#/Status/status_get

and their execution appears not to be working without adding -H "Content-Length: 0".
curl -X POST "https://watcher.samrong.omg.network/status.get" -H  "accept: application/json" -H "Content-Length: 0"
{"data":{"byzantine_events":[],"contract_addr":"0x740ecec4c0ee99c285945de8b44e9f5bfb71eea7","eth_syncing":false,"in_flight_exits":[{"eth_height":4975673,"piggybacked_inputs":[],"piggybacked_outputs":[],"txbytes":"0xf8f6d3c6835711138080c3808080c3808080c3808080f8bff294f1deff59da938e31673da1300b479896c743d96894000000000000000000000000000000000000000087b1a2bc2ec50000f3944522fb44c2ab359e76ecc75c22c9409690f1224194000000000000000000000000000000000000000088063eb89da4ecfff6eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000","txhash":"0x12c07db5686ac6713c6b72f90adf72f8da1ac85e8e2797d68753c8e8824bc358"},{"eth_height":5283535,"piggybacked_inputs":[],"piggybacked_outputs":[],"txbytes":"0xf8f6d3c68382a9388001c3808080c3808080c3808080f8bff294690fe5ca41dcee0bacf7b9c29e853af7107fb1ce94000000000000000000000000000000000000000087b1a2bc2ec50000f3941d1d04ee452993079fc57daec10180c7401d6c4994000000000000000000000000000000000000000088058d15e17627ffeceb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000","txhash":"0xc8c27bfedb0363991d4b043f5b2fddf939ac3186551626fe925b46c6b7a72d85"},{"eth_height":4975679,"piggybacked_inputs":[],"piggybacked_outputs":[],"txbytes":"0xf8f6d3c6835711148080c3808080c3808080c3808080f8bff294f1deff59da938e31673da1300b479896c743d96894000000000000000000000000000000000000000087b1a2bc2ec50000f3944522fb44c2ab359e76ecc75c22c9409690f1224194000000000000000000000000000000000000000088063eb89da4ecfff6eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000","txhash":"0xd084832ffe7459a81cedf5b499f5ceb3277f1a30d788398f693144aeb1360921"},{"eth_height":4975691,"piggybacked_inputs":[],"piggybacked_outputs":[],"txbytes":"0xf8f6d3c6835714f88001c3808080c3808080c3808080f8bff294f1deff59da938e31673da1300b479896c743d96894000000000000000000000000000000000000000087b1a2bc2ec50000f3944522fb44c2ab359e76ecc75c22c9409690f1224194000000000000000000000000000000000000000088058d15df221c1bf6eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080eb94000000000000000000000000000000000000000094000000000000000000000000000000000000000080a00000000000000000000000000000000000000000000000000000000000000000","txhash":"0xd9cfdb85cc75f2069c63921953499796763ced82d51d6d01de794e086337ed88"}],"last_mined_child_block_number":8681000,"last_mined_child_block_timestamp":1571813486,"last_seen_eth_block_number":5311758,"last_seen_eth_block_timestamp":1571815481,"last_validated_child_block_number":8681000,"last_validated_child_block_timestamp":1571813486,"services_synced_heights":[{"height":5311758,"service":"block_getter"},{"height":5311746,"service":"challenges_responds_processor"},{"height":5311746,"service":"competitor_processor"},{"height":5311748,"service":"convenience_deposit_processor"},{"height":5311746,"service":"convenience_exit_processor"},{"height":5311748,"service":"depositor"},{"height":5311746,"service":"exit_challenger"},{"height":5311746,"service":"exit_finalizer"},{"height":5311746,"service":"exit_processor"},{"height":5311746,"service":"ife_exit_finalizer"},{"height":5311746,"service":"in_flight_exit_processor"},{"height":5311746,"service":"piggyback_challenges_processor"},{"height":5311746,"service":"piggyback_processor"},{"height":5311758,"service":"root_chain_height"}]},"success":true,"version":"0.2"}

test  $ curl -X POST "https://watcher.samrong.omg.network/status.get" -H  "accept: application/json"
<!DOCTYPE html>

  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
  <title>Error 411 (Length Required)!!1</title>

411. That’s an error.

POST requests require a Content-length header.  That’s all we know.

That's only for masterbranch!

That's only for masterbranch!

What do you mean @InoMurko?

curl in 0.2 is missing content-length header as well.
curl -X POST "localhost:7434/status.get" -H  "accept: application/json" | jq .success (on master) is working without the header

Isn't it CloudFlare related issue? This particular endpoint neither send body nor specify content length.
(SwaggerUI and httpie are adding this header out of the box.)

if it's claudflare... is it setup differently for Samrong -> 2.0?

Hey @InoMurko please note that swaggerUI for master branch points to Ari address

which is not alive from some time...
The other issue is that curl command shown in swagger UI does not work on any ENV (reason: probably CF requires content-length for such request see ☝ )


How to change P, I, and D parameters after running begin?

Looking to edit the P, I, and D coefficients dynamically.

You can change the gain variables directly in your sketch whenever/wherever you'd like - the same ones you pass to the begin() function

Is it preferred to use the setCoefficients() function for dynamically setting PID? the PID gains in begin() are not passed by reference, unlike the input, output, and setpoint.
From the example
myController.begin(&input, &output, &setpoint, p, i, d);


Failed to load source for a dependency on compiler_builtins

I believe my xargo is fully updated, and yet while trying to build a small no-std binary it fails. I was trying to build a custom target, but also find that it fails for the builtin host target. From looking through the issues this looks similar to the failures that were fixed by 0.3.13…
Version:
$ xargo --version
xargo 0.3.13
cargo 1.33.0-nightly (2b4a5f1f0 2019-01-12)

Failing case:
$ xargo build --target x86_64-apple-darwin
warning: Patch `rustc-std-workspace-core v1.0.0 (/Users/c/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src/tools/rustc-std-workspace-core)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.
   Compiling core v0.0.0 (/Users/c/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcore)
    Finished release [optimized] target(s) in 31.54s
error: failed to load source for a dependency on `compiler_builtins`

Caused by:
  Unable to update /Users/c/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcompiler_builtins

Caused by:
  failed to read `/Users/c/.rustup/toolchains/nightly-x86_64-apple-darwin/lib/rustlib/src/rust/src/libcompiler_builtins/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
error: `"cargo" "build" "--release" "--manifest-path" "/var/folders/6f/l9rcfr1d2s55xy9vd6rtnvv00000gn/T/xargo.9N6Ub5sxQilY/Cargo.toml" "--target" "x86_64-apple-darwin" "-p" "compiler_builtins"` failed with exit code: Some(101)
note: run with `RUST_BACKTRACE=1` for a backtrace

I am hitting the same issue when I am compiling arm-none-eabi

Have you tried switching to cargo-xbuild?

I was hit with this issue while compiling a project to a freestanding binary. I fixed it by force updating cargo-xbuild with cargo install cargo-xbuild --force


Allow conditionally required fields (required='C')

From https://www.fixtrading.org/online-specification/introduction/#message-and-component-definitions
Messages are comprised of required, optional and conditionally required (fields which are required based on the presence or value of other fields) fields. Systems should be designed to operate when only the required and conditionally required fields are present.
So they should just be treated as optional for the code gen part

Do you see any practical difference between Optional and Conditionally Required fields?
It's up to the user to decide if conditions for optional fields to be present are met.
Use InputResponder::reject https://github.com/ldanko/easyfix/blob/6b8cad4a79611c1faac53bccffa5a88c70397883/easyfix-session/src/application.rs#L58
(or just send Reject<3> message)

From what I see requirements for conditional fields is not formally specified, so it's application specific and should generate runtime error.
So my take on that is:

for the generated API messages this is the same as optional, since it should support cases of those fields omitted
for the "reflection" way to inspect schema (easyfix-dictionary crate?), those fields might be good to mark as conditionally required, so user could treat them specially or at least know about them


feat(api): env var to control exam environment

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

@ShaunSHamilton I went overboard with caution and made it impossible to turn on the exam env while we're in production mode. I'll probably have to change this as we get closer to deployment.

Unrelated test failure.


Url tweaks

@petele @PaulKinlan please review

Side related to this PR.  Do we even want to encourage people to do what I did in this getting started guide in the original WF - i.e, have references to "previous" article.

previous and next is fine.


Jpcbertoldo/mvtec ad loco

Disclaimer
I am creating this just to keep track of the branch, please ignore the PR for the moment.

Description

Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

Fixes #471

Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which refactors the code base)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[ ] My code follows the pre-commit style and check guidelines of this project.
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing tests pass locally with my changes

MVTec.__init__ has the following lines
        if self.transform_config_train is not None and self.transform_config_val is None:
            self.transform_config_val = self.transform_config_train

which i did not do in MVTecLOCO.__init__.
Is there a good reason for assuming this? For me it could make sense that self.transform_config_val could have light data augmentations (say, tiny brightness changes) but that should not be repeated in the validation set.

another part, in anomalib.data.mvtec.make_mvtec_dataset, which i didnt understand why it's there and removed in mvtec loco
    # Split the normal images in training set if test set doesn't
    # contain any normal images. This is needed because AUC score
    # cannot be computed based on 1-class
    if sum((samples.split == "test") & (samples.label == "good")) == 0:
        samples = split_normal_images_in_train_set(samples, split_ratio, seed)

if that case does happen then there is a violation in the dataset files and an error should be raised
...right?

yet something i dont understand in anomalib.data.mvtec
# in MVTecLOCODataset.__getitem__
pre_processed = self.pre_process(image=image, mask=mask)

how this works?
does the transform re-apply the last call when mask is not None?

Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB

@samet-akcay is this some sort of integratin in the project?

Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB

@samet-akcay is this some sort of integratin in the project?

We use ReviewNB for notebook reviews. It's not so easy to review jupyter notebooks on GitHub. ReviewNB makes it significantly easier.

i messed some git commands, i'm closing this one and openning another one


On using an existing etcd cluster

Hi guys,
First of all, thank you so much for open sourcing the Vault operator. This is a great milestone for the community and the overall security story of Kubernetes!
It seems that the Vault operator leverages  the automation provided by the etcd operator for the Vault’s datastore, which seems like a great integration point for most people!
However, for those who deploy Vault as a base Kubernetes service, it seems that it would be beneficial to use the already existing and managed etcd cluster that supports the Kubernetes API, as it is often closely monitored (etcd metrics, node metrics, ...), has alerts set up as well, backups, disaster recovery plan, etc.
Is supporting existing secured etcd cluster something that you may consider adding to the operator in the short term?
Thanks again.

@Quentin-M That’s an interesting idea. While I’m not sure of the feasibility and side effects of sharing the API server's etcd store, the general idea of using an existing etcd cluster is definitely useful.
Roughly speaking if the etcd endpoints and the trusted client cert/key are passed
in the VaultService CR spec then the operator should be able to reuse the existing etcd cluster for the Vault cluster's storage.
I can't guarantee how soon we can move on this due to other commitments but I’m going to experiment a bit more with this idea in the coming week or so and will try to update with a more detailed proposal.

I thought we already had a doc on how to do this but I can't find it.
Regardless I think we could easily add a mode that points to an existing etcd cluster instead of deploying one. Perhaps this is a different resource type vs an option on the existing type.

@philips The vault-operator does not support using an existing etcd cluster. You might be thinking of the etcd-backup operator which supported creating backups from an existing etcd cluster.
https://github.com/coreos/etcd-operator/blob/master/example/etcd-backup-operator/backup_cr.yaml#L6
And I think that this could be supported as an option in the existing VaultService CR rather than having a new resource type since it's just an extension to override the default. Something like:
apiVersion: "vault.security.coreos.com/v1alpha1"
kind: "VaultService"
metadata:
  name: "example"
spec:
  storage:
    etcd:
      endpoints: <comma separated list of endpoints>
      tlsClientSecret: <secret containing: etcd-client.key etcd-client.crt etcd-client-ca.crt>
  nodes: 2
  version: "0.9.1-0"

So if the user specifies spec.storage.etcd then the operator uses that. Otherwise it creates a new etcd cluster using the etcd operator.

I like the sample syntax yaml proposed by @hasbro17. Is there a way to do this now? I cannot find any documentation..

@hasbro17 any update on this?

I think it would also be interesting to be able to choose another storage that ETCD (I would rather use something else), basically to allow any storage configuration.


Added UI for PGVector and ChromaDB into assistant and groupagents

Why are these changes needed?
This is adding RAG to advanced options for assistant and groupchat agents
Related issue number
Checks

[ ] I've included any doc changes needed for https://ag2ai.github.io/ag2/. See https://ag2ai.github.io/ag2/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Hey @Knucklessg1, thanks so much for this!
We're planning to move studio to, possibly, a new repository and bring it up to date against the current AG2 code base. Are you interested in helping out?

Absolutely! I would love to contribute 😊

Absolutely! I would love to contribute 😊
Edit: I just saw Victor's update on the original repository of the UI redesign. 😅
I'll be closing this MR as it is no longer relevant.


Assemble two model into one, but encount ValueError: Graph disconnected

Please go to TF Forum for help and support:
https://discuss.tensorflow.org/tag/keras
If you open a GitHub issue, here is our policy:
It must be a bug, a feature request, or a significant problem with the documentation (for small docs fixes please send a PR instead).
The form below must be filled out.
Here's why we have that policy:.
Keras developers respond to issues. We want to focus on work that benefits the whole community, e.g., fixing bugs and adding features. Support only helps individuals. GitHub also notifies thousands of people when issues are filed. We want them to see you communicating an interesting problem, rather than being redirected to Stack Overflow.
System information.

Have I written custom code (as opposed to using a stock example script provided in Keras):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): windows10
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.8
Python version: 3.7
Bazel version (if compiling from source):
GPU model and memory:
Exact command to reproduce:

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with:
python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the problem.
Assemble two model into one, but encount ValueError: Graph disconnected
Describe the problem clearly here. Be sure to convey here why it's a bug in Keras or why the requested feature is needed.
Describe the current behavior.
i have two models:
first one is mobile_net, which is a mobilenet assign with input shape of 192,192,3, and output shape of 6,6,1280.it contains pretrain weights.
second model is model_0 assign with input shape of 6,6,1280, which has two layers of GlobalAveragePooling2D and Dense.( model_0 is well trianed)

now i connect the mobile_net and model_0 together, hoping the data will flow through.
I finally assembled the two model successfully, the assembled model is named model_1
But when i extract some layer outputs of the model_1, wired things happened~~
i can get the -4 layer output successfully
i can get the -3 layer output successfully
i can not get the -2 layer output
i can not get the -1 layer output

Describe the expected behavior.
Contributing.

Do you want to contribute a PR? (yes/no):
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue.
the demo code is here
inputs=tf.keras.layers.Input([6,6,1280])
x=tf.keras.layers.GlobalAveragePooling2D(
name=‘global_average_pooling2d_0’)(inputs)
y=tf.keras.layers.Dense(5,name=‘dense_0’)(x)
model_0 = tf.keras.Model(inputs,y,name=‘model_0’)

mobile_net = tf.keras.applications.MobileNetV2(
input_shape=(192,192,3),
include_top=False,
weights=‘imagenet’)
assert mobile_net.output_shape==(None, 6, 6, 1280)
y1=model_0.get_layer(‘global_average_pooling2d_0’)(mobile_net.output)
y2=model_0.get_layer(‘dense_0’)(y1)
model_1 = tf.keras.Model(mobile_net.input,y2,name=‘assembled_model’)

tmp=tf.keras.Model(model_1.input,model_1.layers[-3].output) # successfully
tmp=tf.keras.Model(model_1.input,model_1.layers[-2].output) # failed
tmp=tf.keras.Model(model_1.input,model_1.layers[-1].output) # failed

the failed outputs are

ValueError: Graph disconnected: cannot obtain value for tensor KerasTensor(type_spec=TensorSpec(shape=(None, 6, 6, 1280), dtype=tf.float32, name=‘input_12’), name=‘input_12’, description=“created by layer ‘input_12’”) at layer “global_average_pooling2d_0”. The following previous layers were accessed without issue: []

ValueError: Graph disconnected: cannot obtain value for tensor KerasTensor(type_spec=TensorSpec(shape=(None, 6, 6, 1280), dtype=tf.float32, name=‘input_12’), name=‘input_12’, description=“created by layer ‘input_12’”) at layer “global_average_pooling2d_0”. The following previous layers were accessed without issue: []
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.

Source code / logs.
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

@fjzhangcr
In order to expedite the trouble-shooting process, please provide a complete code snippet to reproduce the issue reported here. Thank you!


Crash on running PowerToys Run

Microsoft PowerToys version
0.67.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce

Invoked PowerToys Run with keyboard shortcut ALT + SPACE
Started tying some letters
Backspaced to fix a typo
Started typing again, crashed with pop-up

✔ Expected Behavior
To get a list of search results.
❌ Actual Behavior
Crash report pop-up, program exited.
2023-02-26.txt
Other Software
No response

System.InvalidOperationException: Dispatcher processing has been suspended, but messages are still being processed.
Source: WindowsBase
TargetAssembly: WindowsBase, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
TargetModule: WindowsBase.dll
TargetSite: IntPtr WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Plugins installed looks to be
Program files
Window Walker
Terminal

/dup #18166

For any users that are able to replicate this consistently, can you please update to 0.68.1 and disable thumbnail generation to verify if it fixes the issue? Please let us know on #18166!


Use nodejs v8 for having npm

There are more reasons why we benefit from switching to latest version -- at least later EOL, and availability on more arches than x86_64 only.

Tests are passing and changes look good.
@hhorak Should this be tested somehow specially?

I just wanted to re-check that all s2i-based containers already use the env. variable and not hard-code the nodejs6.. so, please, don't merge for now, I can merge once I confirm the other images status.

Just checked, all should be fine.

[test]


User Component needed

Currently, a lot of the recent site updates include repeatable areas that could be built into components. It might not be a bad idea for someone to create an 'user' component (check out the home page users - name, image, related title).

This will be done as part of login phase 2 and 3


Accessibility Flexibility

added some flexibility for accessibility. Included two new props, one for scrollview modal and cancel button. There was also a small bug with android where the 2nd option was being focused instead of the 1st. That should be fixed as well.

Thanks @jessamp .
It looks like the accessible prop was replaced by the new props, but it's still in the Readme as a separate prop.  Should it be removed from the documentation?

Oh yes it should. I thought I removed it.

Oh wait....no it shouldn't....that actually controls the individual items in the list. I left it there in case someone wants to do something different for the accessibility for individual items. But I'll rename it so it's not confusing.
Also, I'm adding another accessible term. I just came across another issue when I use this as a wrapper. We should add the capability to control that accessibility as well in case their wrapped component has accessibility specifically defined.

@peacechen changes were added. Thanks!

Thanks again @jessamp .   It took some head-scratching to understand what wrappedComponentAccessible applied to.  Hope you don't mind that I renamed it to openButtonContainerAccessible

Sounds good to me!

@peacechen curious when you'll be able to push the change out to the npm release?

We'll publish soon.  It'll be bumped to 1.0.0 since the updated accessibility props are breaking changes.

It is published now as v1.0.0. Could then issue #88 be marked as resolved?


Update: update documents for roadmap (Updates #56)

Introduction: reformatted
Introduction to Git and GitHub: translated
Workflow for Contributing: typo correction, small rephrasings
GitFlow Workflow: typo correction, formatting, created issue #54
(ForkingWorkflow: not listed in checklist but typo correction)
"Add: Create own GitHub account #8": created issue #55
"Read Issue Add: Install Git #9": typo correction (InstallingGit.md)
"Read Issue Add: Connect Visual Studio Code with GitHub #11": formatting of related .md doc
"Read Formulating Commit and Merge Request Messages": typo correction in related .md doc

point "Read Issue Add: Contribute to Content of
Introduction #12" not yet included

Added also new issue #58 about issue template usage.


warn on implicit state transition

On 2015-02-11 13:19, Phil Shafer wrote:

Marcel Moolenaar writes:

BTW: Is there a way to have libxo do the state transitions
verbosely (i.e. emit a warning)? That way we don=E2=80=99t end up
with a bunch of broken utilities. Something cryptic would
be fine as I see it only being useful to check correctness
of utilities that are being modified (i.e. converted).

I can certainly add this, but there's no means currently.  Should
it be part of the normal "warn" flag or something distinct?
In general, this implicit transitions are meant to help coders avoid
having to make some calls, as a convenience mechanism.  Perhaps the
best think would be just to warn when the transition makes no sense
at all, such as when the xo_close_list("file") is seen after the
implicit transition has already closed it when the
xo_open_container("total") was seen.
Thanks,
Phil

That seems reasonable. But maybe also a 'strict' flag or mode,
especially for something like the test suite to use, to detect when
libxo was misused.
--
Allan Jude

Fixed in develop


Remove Python linking dependency if USE_PYTHON=OFF

A similar fix proposed previously by #5602 failed the CI tests. I made some amendments, and it is compilable in my environment.
It should now correct the problem raised in #5863 as well.
Closes #5602.
Resolves #5863.

Also, might be worth seeing if we can remove the following lines
https://github.com/pytorch/vision/blob/2e70ee1af3bb3c5ba0f9a8bcf16cd1611831690f/torchvision/csrc/vision.cpp#L17-L27
since this is what blocks us to have to include python (but this wasn't supposed to be the case). Maybe we can now remove this, or folks from torchaudio have found a different workaround since then? cc @mthrok

My intention is to wait a couple of days for the rest of the people to respond and merge afterwards. Please don't close the PR. Thanks in advance!

My pleasure.

Right now our CI is still broken due to PyTorch upstream issues, so it's not a good time to test it. Let's wait until they are resolved (tracked at #5881) and then check what the CI things about them.

The quote is from comments under #5602. This is surprising to me as the tests failed again. Since I have permission to look at the CircleCI logs for my commit, I reckon this might be an issue due to the CI system environment. I guess the docker image cimg/python eliminates the shared object files of LibPNG to reduce the overall size, but I don't have a chance to check this. I suggest adding a preparation step like apt-get install libpng-dev to the CircleCI configuration.

I found a related issue in python-pillow/Pillow#5813.
I think the error indicates that the shared object path resolution might be broken in the testing environment, but adding the Python target to the linkage dependency somehow resolves this issue. The last commit I pushed might solve the problem on CEntOS-based testing environments, but not on those running macOS.
From my perspective, it might be necessary to prune the whole building and testing scripts to actually resolve this issue, but this involves a large amount of work. I will now close my PR and see if any smarter coders could propose a better solution instead.

@laitingsheng Understood, thanks for the effort!


Error in GetValueAsBool

hi
i have old source of pkcs11 lib, that read my token
today i updated to least version and get error in ReadCertificate method, i debug it and found an inner method in ObjectAttribute.cs in HightLevelApi
public bool GetValueAsBool()
        {
            if (this._disposed)
                throw new ObjectDisposedException(this.GetType().FullName);

            if (Platform.UnmanagedLongSize == 4)
                return (Platform.StructPackingSize == 0) ? _objectAttribute40.GetValueAsBool() : _objectAttribute41.GetValueAsBool();
            else
                return (Platform.StructPackingSize == 0) ? _objectAttribute80.GetValueAsBool() : _objectAttribute81.GetValueAsBool();
        }

that throw error: Unable to convert byte to bool
but my old source that work and read certificate:
public bool GetValueAsBool()
        {
            if (this._disposed)
                throw new ObjectDisposedException(this.GetType().FullName);

            if (UnmanagedLong.Size == 4)
                return _objectAttribute4.GetValueAsBool();
            else
                return _objectAttribute8.GetValueAsBool();
        }

Update:
i found that  this method throw eception: public static bool BytesToBool(byte[] value)
in file .\Common\ConvertUtils.cs
i fixed with these codes:
public static bool BytesToBool(byte[] value)
        {
            // Cryptoki uses boolean flag with size of 1 byte
            if ((value == null) || (value.Length != 1))
                value = new byte[] {0};

            return BitConverter.ToBoolean(value, 0);
        }

Problem solved. please fix in your source

Your application seems to be reading the value of some attribute which is expected to have a bool value. In PKCS#11 bool values are represented with CK_BBOOL type which is exactly 1 byte long. Skipping the check for correct length of attribute value may hide serious bugs in unmanaged PKCS#11 libraries.
Please provide the answer for following questions:

Which attribute is causing the problem?
What is the value of attribute? Is it null or is its length other than 1?
Did you check CannotBeRead member of ObjectAttribute  class before using attribute value?

It would be great if you could use PKCS11-LOGGER to troubleshoot your issue and send me the logs.

ok, i test,  i am using pkcs11-logger and library speed increased!!!! i do not know why
also i have some exception that there is not exist any more (i think some thing need logger)
i will test and report result about this issue

pkcs11-logger-x64.zip
this is log file when using this method and it throw exception

You seem to be using Pkcs11Admin application which in its current version requires 5 attributes to be readable on certificate object.
However unmanaged PKCS#11 library does not consider CKA_PRIVATE attribute to be valid and marks the attribute as such by setting the ulValueLen field to hold the value -1<PHONE_NUMBER>).
Pkcs11Admin foolishly expects CKA_PRIVATE attribute of the certificate object to be readable and does not check if it really is. That's why you are getting "Unable to convert bytes to bool" exception.

I will most likely modify Pkcs11Admin to no longer assume that some attributes are essential and always readable because this case clearly shows they are not. Regardless of that I believe that Longmai should fix handling of CKA_PRIVATE attribute in their library which BTW also incorrectly encodes the value of CKA_SERIAL_NUMBER attribute. I'll notify Longmai engineers about this thread via LinkedIn.
Meanwhile it would be great if you could change line 535 in Pkcs11Slot.cs from
CkaPrivate = requiredAttributes[0].GetValueAsBool(),

to
CkaPrivate = (requiredAttributes[0].CannotBeRead) ? false : requiredAttributes[0].GetValueAsBool(),

and report back with the results.

yes Pkcs11Admin is some part of my codes, there are three certificate in token and only one of them has CKA_PRIVATE attribute and when reading this section in throw exception.
i fix it with codes that you provided.

@mahdiit did suggested code change fixed the issue for you?

sorry for long time response, i am busy and testing, so yes this fix problem but i found i must test this for every property because can cause problem in my application.
thanks


Write visualization user stories to capture use cases

See #17 #18 #20 #21 #26 for specific visualization functionalities.

We have issues for the above listed functionalities now, so i am going to close this issue!


Create leonidov.toml

Description
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging to draft

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present

This toml has an incorrectly formatted dkg key. Please ammend and resubmit for the next testnet


ExploreWith Functions not Available

Describe the bug
Since upgrading software and package versions, the ExploreWithNteract and ExploreWithSandDance functions don't appear to be available. Have they been renamed or shifted? Versions as follows:
.NET SDK: v6.0.102
VS Code: v1.64.2
.NET Interactive: v1.0.2606010
Jupyter: v2022.1.1001760686
SandDance for VS Code: v3.3.0
C#: v1.24.0
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ): v1.0.2606010

OS

[ ] Windows 11
[x] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[x] Brave
[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Visual Studio
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.
My project:

Sample project:

These have been moved to separate packages:
https://www.nuget.org/packages/nteract.InteractiveExtension/
https://www.nuget.org/packages/SandDance.InteractiveExtension/

Excellent, thank you. This has resolved it:
#r "nuget:nteract.InteractiveExtension"
#r "nuget:SandDance.InteractiveExtension"


Enable syncing for tiddlers with meta files

Regarding #171
Though I don't know much about the rest of the codebase, this small tweak has fixed the issue for me.

Thank you for the pull requests


Add option to sort HTML view by date or alphabetically

A user has requested the option to sort tasks in the HTML view by Due Date or alphabetically.
I am investigating how feasible this is, and will consider adding the functionality.


Suggestion: Add settings for selection of monitors

I like this simple piece of software, but I lack one feature here - I want to select to which monitors it applies this shift, because I have multimonitor setup and only one of it is OLED, therefore I dont need it on the other ones and I find it quite annoying when its turned on, am playing some game in fullscreen, but it moves some windows on side monitor.
I dont want to hustle over turning it off and on...

Hey,
Thanks for the suggestion, that actually makes a lot of sense! I haven't considered that setup since a single widescreen is more than enough for me as it is 😂
Adding the option to select which monitors OLEDShift applies to should be doable with the Win32 API. My main concern will be making sure that we can reliably save these settings, specifically figuring out if monitor IDs stay consistent after a reboot.
I’m a bit swamped with exams and work right now, but I’ll try to look into this towards the very end of the year. Appreciate the feedback!

I think monitor IDs should stay consistent after reboot imho, but I am not sure of the behaviour in the situation, when e.g. I turn off one of the monitors 🤔 (sometimes I dont need OLED at all, so I preserve its lifetime by this).. Windows 11 remembers positions and settings of my setup and if I turn it on again, it behaves correctly.
Hopefully it can be consistent even in this way, but I will be happy enough even with basic functionality of this :D

Haha, yeah, that would definitely be ideal if the IDs stayed consistent! But unfortunately, the APIs we get to work with are a bit of a mixed bag. This is mostly off the top of my head, so don’t quote me on it, but I think Windows has about three different APIs for monitors and they all seem to handle IDs inconsistently. Turning off a monitor, rebooting, or even just swapping video cables can cause the IDs to change, even though Windows itself recognizes each display correctly.
I still remember how much of a headache it was for the WinDynamicDesktop guys when they added multi-monitor support 😅

Hey @pitris90,
I've added the selectable monitor feature you requested
If you have some time, could you please test it with your multi-monitor setup and let me know how it goes?
You can get the latest build here:
https://github.com/Marko19907/OLEDShift/actions/runs/12527779883
Thanks for the suggestion, cheers! 🙌


[feature] ability to work with Angular Universal

At the moment if you attempt to add the library to an application using Universal, you'll get :
Exception: Call to Node module failed with error: ReferenceError: Element is not defined

seen here (https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues/44)
ng2-bootstrap faced similar hurdles when making their library universal, it looks like they can be fixed with some TS work-arounds potentially. https://github.com/valor-software/ng2-bootstrap/issues/964
Here's one check in that fixed similar issues.
https://github.com/valor-software/ng2-bootstrap/commit/d20ccf109c9a718823b2eab4f971b3595b04a83f
Just wanted to get it out there!
A good article here on deploying libraries to keep them usable outside of the browser platform as well.  http://blog.mgechev.com/2017/01/21/distributing-an-angular-library-aot-ngc-types/

Did not realize the error had anything to do with universal, thank you for making this clear.
So there isn't any specific fixes suggested yet?

I'm not aware of anything to fix it just yet, the library itself is accessing the NativeElement and such (which I believe is where the errors are stemming from).  A few things would have to be updated/changed here to let the library be used in Webworkers / Server / etc.

Will fix today. Thanks!

Fixed in 2.8.0.
Please verify

This is great news.
However I tried 2.8.0 (with universal) and this is showing up in the console:
An unhandled exception has occurred: Call to Node module failed with error: ...\node_modules\angular2-tree-component\dist\angular2-tree-component.js:10
import { NgModule } from '@angular/core';
^^^^^^
SyntaxError: Unexpected token import

It looks like you're trying to use the component without bundling it with something like webpack.
Can you share link to your code?

It is bundled into my vendor.js with webpack like this:
(I can see it gets appended to the bottom of the file)
    entry: {
        vendor: [
            ....
            'angular2-tree-component'        <-- I assume this is correct

This is just tested in a larger project of mine, I might be able to set up a smaller test project and share the code.

I have created an asp.net test project, it is based on the "asp.net core angular 2 starter application" template. I still have the same error.
The component is loaded into the Dashboard component

@Moalpima did you want to try re-testing it out? I think I remember you were running into this issue with the Component.
Thank you @adamkleingit ! :100: :+1:

Hi,
I also have this error:
import { NgModule } from '@angular/core';
SyntaxError: Unexpected token import

I'm on an angular2-meteor app.
Is it corrected on your side @nxplus ?
Thx

Unexpected token import is coming from typescript not being transpiled, make sure you have the appropriate loaders in webpack or whatever you're using to set TS up.

Sorry, I don't figure out what is wrong on my side.
I see that the content angular2-tree-component is bundled in my output js file... but I still have this error Unexpected token import:

Can it be my tsconfig.json?
{
  "compilerOptions": {
    "target": "es6",
    "lib": [
      "es6",
      "dom"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "sourceMap": true,
    "types": ["meteor-typings"]
  },
  "compileOnSave": false,
  "angularCompilerOptions": {
    "genDir": "aot",
    "skipMetadataEmit": true
  }
}

Thank you for your help

you have an es6 target, try es5?

Yes I did, event with target es5 I have the same thing.

@jycouet still same error, my example is taken directly from the visual studio angular 2 template here:
https://marketplace.visualstudio.com/items?itemName=MadsKristensen.ASPNETCoreTemplatePack
As of now I really have no clue where to look. I also tried changing some tsconfig settings without luck.

I'm guessing this is a webpack config issue?
Maybe this line:
    externals: [nodeExternals({ whitelist: [allFilenamesExceptJavaScript] })] // Don't bundle .js files from node_modules

Hi. I'm using Tree component 2.8.1 with angular-universal and getting following error:
Exception: Call to Node module failed with error: Prerendering failed because of error: ReferenceError: Element is not defined
I little digging shows, that problem is not showing up, if i comment out "import './vendor/closest';" row in polyfills.js. Is there any workaround for this?

@adamkleingit that seems very likely, thank you for taking your time.
Perhaps this is also the reason why I have had trouble with some other components that are using multiple js files.
I tried "whitelist: ['angular2-tree-component']" but it didn't seem to work, will investigate further.

Right.
I'll need to reimplement closest using Angular renderer

I'll fork then and try to implement using Angular renderer, because i need it now. Will create pull request, if it be actual at that moment.

@Soarc  Thanks I would really appreciate the help

Sup @Soarc, is there any good news about the fix?
Or is there any kind of workaround i can do to solve it?

Also need to overwrite .getBoundingClientRect().height in both lib/directives/tree-animate-open.directive.ts and lib/models/tree-virtual-scroll.model.ts

Where are we with this? Does 5.0.0 fix this and not call the DOM directly?

@JohnGalt1717 @IgorMoreira @Soarc
Fixed in 5.2.1 - can you verify?


Wrong path on installing using whl

The section on installing using whl files seems to quote a wrong path as it worked for me when I put it in the libraries.zip

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6062879d-b323-e01a-bfc0-b31124e74ea8
Version Independent ID: ba40190c-159c-b29f-4697-77b6275f8cfb
Content: Manage libraries for Apache Spark - Azure Synapse Analytics
Content Source: articles/synapse-analytics/spark/apache-spark-azure-portal-add-libraries.md
Service: synapse-analytics
Sub-service: spark
GitHub Login: @euangms
Microsoft Alias: midesa

@pramodsb We are checking this and will get back to you.

@pramodsb Can you elaborate your feedback, which part of the document you have this specific issue. Screenshot will help alot as well.

This the section on "Manage a Python Wheel". The path provided to upload the whl file is<EMAIL_ADDRESS>However such a path does not exist (there is no directory "python" inside "libraries"; creating one does not work). What works is when I include the whl file as a part of the libraries.zip inside the "libraries" directory)

@euangms - Please check the feedback above and help to edit the document if needed.

Please assign to @midesa

Hi @pramodsb, if the path does not exist, you can add the 'python' folder within the 'libraries' folder.  Once the Spark pool is instantiated, it will bundle all your dependencies and packages appropriately.

#please-close


[Feature request] Tags: Revenge

More than once I've been asked to reintroduce tags in v3.
However, the previous implementation had some design flaws and problems and I don't want to restore it.
The purpose of this issue is to discuss common uses and requirements (ie should tags be assigned to entities or not?), then try to find an implementation that works and makes sense.
I'd like also to understand if it's something that most of the users want back or not, so please add at least a :+1: to the issue if you want to see tags also in v3 but you don't want to participate to the discussion.
Thanks.

Personal opinions from my own experiments and projects.
A "singleton component" is something ive allways used, a lot of times. I tended to use the tag feature before, but when it got deleted i just implemented my own.
My singleton implementation just consists of reserving one entity, and you have functions that mirror get, accumulate, and set, but have no entity. This methods will just affect the singleton entity.
The usage of singleton components is very common when you want "engine-wide" globals. I have a GameTimeComponent, wich holds pause state, delta time, and other similar values, and then i use it everywhere. I also use singleton components to store System related data, like an acceleration structure. This lets me have multiple different systems that affect the same acceleration structure, or query it to do physics.
I think a possible implementation is just to go with that singleton entity, as its barely a couple lines of code, and even lets you have multiple of the same "singleton", if you create a new entity and assign that component, as the singleton entity will still appear in Views.

I like the idea of singletons being tied to the registry mainly because a) if I have multiple registries for simultaneous simulations, i'd want multiple singletons for each and b) I like to think of the registry as the ultimate source of truth of data c) easier for system functions to access the singleton data if associated with the registry. allows for perfromSimStep(Registry) instead of simStep(Registry, cameraSingleton, timeSingleton),

Added a note the to the TODO list. Not sure I'll reintroduce them with v3, but I'll do my best to do it. :+1:


Deploy production via jenkins

A PR already exists for this, before a ticket was made: https://github.com/ResearchSoftwareInstitute/MyHPOM/pull/125

Merged in #125. Thanks, @dsummersl!