Build: adds signing config to gradle

What this PR changes/adds
Adds publication config, such as project name, description, etc. plus the OSSHR Maven repository as well as signing configs to the build file.
Why it does that
Required by OSSRH/MavenCentral
Todo

Should the signing stuff get moved into its own plugin?

Further notes:

./gradlew publishToMavenLocal now takes very long (>5min on an Intel i9), and it seems not to be multi-thread-able. It's probably the signing that actually takes so long.

Linked Issue(s)
Closes #1147
Closes #1123
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[x] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1149 (468e157) into main (24956ec) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1149      +/-   ##
============================================
+ Coverage     62.63%   62.65%   +0.01%
- Complexity     2973     2981       +8
============================================
  Files           694      694
  Lines         15420    15428       +8
  Branches       1043     1048       +5
============================================
+ Hits           9658     9666       +8
+ Misses         5332     5331       -1
- Partials        430      431       +1

Impacted Files
Coverage Δ

...taspaceconnector/core/base/policy/ScopeFilter.java
92.64% <ø> (ø)

...paceconnector/boot/system/runtime/BaseRuntime.java
0.00% <0.00%> (ø)

...sfer/core/transfer/TransferProcessManagerImpl.java
78.22% <ø> (ø)

...transform/IdsRepresentationToAssetTransformer.java
71.42% <ø> (ø)

...r/ids/transform/IdsResourceToAssetTransformer.java
66.66% <ø> (ø)

...ataspaceconnector/azure/cosmos/CosmosDocument.java
71.42% <ø> (ø)

...aceconnector/sql/lease/SqlLeaseContextBuilder.java
86.66% <ø> (ø)

...tor/spi/types/domain/transfer/TransferProcess.java
75.75% <0.00%> (ø)

...s/core/policy/CustomIdsConstraintDeserializer.java
96.66% <0.00%> (-3.34%)
:arrow_down:

...aspaceconnector/ids/policy/IdsPolicyExtension.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24956ec...468e157. Read the comment docs.

@jimmarino @juliapampus @MoritzKeppler @mspiekermann how do we proceed with this? should we merge it and try to get it to build on JIPP?


Linux AMS server not working. Connection via Windows is working

The other day I was trying to connect to a Beckhoff CX5120 PLC running windows and TC3 runtime. We managed to connect via a windows machine and read back some PLC variables. Our master machine is a Linux PC so windows is no option in this case.
On Linux ( Arch )  however, the pyads 2.2 package does not work, it seems the AMS server is not working properly. Netstat tells me a tcp connection is opened but when I try to make a ADS connection it fails with a timeout.
Is there a good way to debug this thing? What kind of information can I collect in order to get to a working sollution?

Please try to run the tests by calling
$ python setup.py test

Do the tests pass or are you getting errors? If the tests pass the problem must be somewhere else...

Have you added a route on the target machine? You need to manually add a route on your target PLC to allow it to send the response to the right place. This is handled automatically with the TwinCAT router on Windows, however there's no equivalent with the Linux version.
To add the route on the target you'll need the IP address (or hostname) of your Linux machine, and its AMS address. You can get the AMS address like this:
>>> remote_ip = '<IP_ADDRESS>'  # Replace with target IP
>>> adr = pyads.AmsAddr('<IP_ADDRESS>.1.1', pyads.PORT_SPS1)  # Replace with target AMS address
>>> pyads.add_route(adr, remote_ip)

# NOTE: get_local_address() won't work properly until you've added a route as above
>>> pyads.get_local_address()
'<IP_ADDRESS>.1.1'

Then you can login to the remote machine (PLC), open up the TwinCAT router UI and add a static route using these details (set the 'Remote Route' to None).

You can also use the new-style Connectionclass. This class takes care of the routing automatically on connect and disconnect.

Yes I should have mentioned that. The connection class will automatically add the local route, but you will still need to manually add a return route on the target PLC from my experience.

Thanks for your help, guys. Very kind..
@ dabrowne
Yes I tried al sorts of variants of this setup, and we do get a AMS address like expected but the connection itself failes.
The testserver ( $ python -m pyads.testserver ) also works and I can even poll for dummy variables like indicated within the official documentation.
pyads.open_port()
30000
remote_ip='<IP_ADDRESS>'
adr=pyads.AmsAddr('<IP_ADDRESS>.1.1', pyads.PORT_SPS1)
pyads.add_route(adr,remote_ip)
2017-09-25T11:59:25+0200 Info: Connecting to <IP_ADDRESS>
2017-09-25T11:59:25+0200 Info: connection closed by remote

pyads.get_local_address()
<AmsAddress <IP_ADDRESS>.1.1:30000>

@MrLeeh
Pytest was not installed but after installation it gave me this out put back:
$ python setup.py test
running test
running egg_info
writing pyads.egg-info/PKG-INFO
writing dependency_links to pyads.egg-info/dependency_links.txt
writing top-level names to pyads.egg-info/top_level.txt
reading manifest file 'pyads.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'pyads.egg-info/SOURCES.txt'
running build_ext
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.6.2, pytest-3.2.2, py-1.4.34, pluggy-0.4.0
rootdir: /run/media/wouter/DATA/Workspace-IE/Firmware/Beckhoff Cx5120/pyads, inifile: tox.ini
collected 29 items

tests/test_ads.py .
tests/test_connection_class.py ................
tests/test_integration.py ............

@MrLeeh
It was not clear to me the new .Connections style was a replacement for the old manual implementation so I gave it a try.  I needed to open a port first as you can see in the following terminal output.
import pyads
plc=pyads.Connection('<IP_ADDRESS>.1.1' , 851 )
pyads.get_local_address()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/pyads/ads.py", line 72, in get_local_address
    return adsGetLocalAddressEx(port)
  File "/usr/lib/python3.6/site-packages/pyads/pyads_ex.py", line 160, in adsGetLocalAddressEx
    raise ADSError(error_code)
pyads.pyads.ADSError: ADSError: ads-port not opened (1864)
import pyads
pyads.open_port()
30000
plc=pyads.Connection('<IP_ADDRESS>.1.1' , 851 )
 pyads.get_local_address()
<AmsAddress <IP_ADDRESS>.1.1:30000>
 plc.open()
2017-09-25T12:25:43+0200 Info: Connecting to <IP_ADDRESS>
 2017-09-25T12:25:43+0200 Info: connection closed by remote
plc.pyads.get_local_address()
<AmsAddress <IP_ADDRESS>.1.1:30000>

@wouterjoris Yes, to get the local address you still need to call pyads.open_port(). Maybe I could add a more convenient function as static method of pyads.Connection that opens and closes the port itself and returns the local address.
Did your routing work now? I could imagine you run into trouble because you are mixing the remote ip
with to local AMSAddr. I think it should be:
>>> remote_ip = '<IP_ADDRESS>'  # Replace with target IP
>>> remote_ams_addr = '<IP_ADDRESS>.1.1'  # Could be different, depends on your target
>>> adr = pyads.AmsAddr(remote_ams_addr, pyads.PORT_SPS1)  # Replace with target AMS address
>>> pyads.add_route(adr, remote_ip)

I think this last tip of you certainly is most helpfull. I did mixup those adresses.  But the problem however stays the same: "connection closed by remote"
As @dabrowne already pointed out; I also should add a route on the PLC side. This seems not to work in Twincat3 runtime.  I always get the error: 1800 device busy.
There is also the option of a broadcast search but I don't see a response out of pyads. Is pyads meant to answer to these multicasts?

Have a look if your Firewall is active. I just had the same issue here. If you deactivate the firewalls on both sides you should be able to see the other side via Broadcast Search.

@wouterjoris
The linux AMS router won't answer the multicast request as far as I know. It's very different to the Windows implementation in that it doesn't actually exist as it's own process, it's just a c++ library which is invoked by the pyads module. On Windows the router is always running as a daemon so it is able to answer the multicasts.

@MrLeeh  @dabrowne
>>> plc.read_device_info()
('PLC Server', <pyads.structs.AdsVersion object at 0x7fa9db636cf8>)

I finally got a reply from the PLC.  :-)
I installed twincat 2 on the PLC ( V2.11.2259 ) where I could add a route back to my PC.  Twincat3 ( V3.1.4022.2) runtime does not seem to work at this point. I have some more testing to do to confirm this for sure but it makes me hopeful now I have a working connection running.
Thanks again for the assistance!

Happy that it works for you now. However TwinCAT3 should work too. I'm doing my testing with TwinCAT3 ... but from a Windows PC. This works well. Would be nice to know if it is a general issue with Linux and TwinCAT3 or maybe just a setting thing. Let us know if you found anything ;)
Greetings

The connection with TC3 works on Windows. For the Linux case only TC2 works for now.
So my idea was to switch runtimes within the TC3 VC2013 environment in order to program the PLC but this seems quite a hassle too. The PLC won't run if it's programmed with TC3 while switching back to TC2.
I'll let you know for sure if I manage to get some progress in the situation but I'm a bit out of ideas at the moment.
kind greetings
Wouter

I'm happily using a TC3 PLC with a Linux pyads client. I suspect that the issue may be separate from pyads as the manual route failed on the PLC.
I added my routes by logging into the PLC with remote desktop (or if you have a monitor attached, just working on the PLC directly), right clicking on the TwinCAT icon on the taskbar and going router > edit routes > add. You should also be able to do the same from TwinCAT Engineering (Visual Studio) on your Windows machine, but this is just another option to try.
Here's a screenshot of the configuration just to make extra sure. Note that your linux machine will need a static IP.

Yes, I finally got a working connection with TC3.
>>> plc.read_device_info()
('Plc30 App', <pyads.structs.AdsVersion object at 0x7f9beaca6a20>)

For some reason I was not able to add a route on the PLC to the master Linux machine so I used the same settings with my Windows machine using Twincat 3 VC2013. ( which I need anyway to program the PLC. ) Once setup the route could be added on the PLC and this works all the same when switched back to Linux.
I must say I'm not impressed with the Beckhoff software provisions but like they say here at the office:
Once you get it running your good to go. :o)
I'm happy with the working connection and thanks you again for the kind help.
Kind greetings
Wouter

Hi reader,
I have to communicate a PLC (Beckhoff CX9020) with a raspberri pi thru python, and I have been hitting my head against the wall for the past 3 days. For the record, I have the communication going well with TwinCAT and I can read variables with python if I do it from Windows. It seems like the issue is very related to this thread, I tried following but I couldn't solve the puzzle.
I need help, please contact

The connection class will automatically add the local route, but you will still need to manually add a return route on the target PLC from my experience.

how do I add the route?

Thanks for your help, guys. Very kind..
@ dabrowne
Yes I tried al sorts of variants of this setup, and we do get a AMS address like expected but the connection itself failes.
The testserver ( $ python -m pyads.testserver ) also works and I can even poll for dummy variables like indicated within the official documentation.
pyads.open_port()
30000
remote_ip='<IP_ADDRESS>'
adr=pyads.AmsAddr('<IP_ADDRESS>.1.1', pyads.PORT_SPS1)
pyads.add_route(adr,remote_ip)
2017-09-25T11:59:25+0200 Info: Connecting to <IP_ADDRESS>
2017-09-25T11:59:25+0200 Info: connection closed by remote

pyads.get_local_address()
<AmsAddress <IP_ADDRESS>.1.1:30000>

I mannaged to make something similar to this to work, so I know my AmsAdress... what do I do with it?
any help is more than welcome

Hello Sofia,
could please you post the code you used to establish the connection.
You will need to create a route on the PLC for the communication to
work.
Did you use add_route_to_plc for this?

Freundliche Grüße
Stefan Lehmann
Am 24.02.2021 08:51 schrieb Sofia:

Hi reader,
I have to communicate a PLC (Beckhoff CX9020) with a raspberri pi
thru python, and I have been hitting my head against the wall for the
past 3 days. For the record, I have the communication going well with
TwinCAT and I can read variables with python if I do it from Windows.
It seems like the issue is very related to this thread, I tried
following but I couldn't solve the puzzle.
I need help, please contact

The connection class will automatically add the local route, but you
will still need to manually add a return route on the target PLC
from my experience.

how do I add the route?

Thanks for your help, guys. Very kind..
@ dabrowne
Yes I tried al sorts of variants of this setup, and we do get a AMS
address like expected but the connection itself failes.
The testserver ( $ python -m pyads.testserver ) also works and I
can even poll for dummy variables like indicated within the official
documentation.
pyads.open_port()
30000
remote_ip='<IP_ADDRESS>'
adr=pyads.AmsAddr('<IP_ADDRESS>.1.1', pyads.PORT_SPS1)
pyads.add_route(adr,remote_ip)
2017-09-25T11:59:25+0200 Info: Connecting to <IP_ADDRESS>
2017-09-25T11:59:25+0200 Info: connection closed by remote
pyads.get_local_address()
<AmsAddress <IP_ADDRESS>.1.1:30000>

I mannaged to make something similar to this to work, so I know my
AmsAdress... what do I do with it?
any help is more than welcome
--
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
Links:
[1] https://github.com/stlehmann/pyads/issues/34#issuecomment-784871191
[2]
https://github.com/notifications/unsubscribe-auth/ABDNGBQQJ5LK6KRYDXHB5ADTASVWXANCNFSM4D4F6LTA

On Windows this gives a good working conection:
import pyads
plc = pyads.ads.Connection('<IP_ADDRESS>.1.1',  851)
plc.open()

state = plc.read_state()
print(state) # (5, 0)

on linux it gives "ADSError: target port not found   ADS Server not started (6)"
Then I tried with some variations on the codes I found on this thread and the furthes I got is to this
import pyads

port = pyads.open_port()
print('port: ', port)
remote_ip = '<IP_ADDRESS>'
target_AMS_address = '<IP_ADDRESS>.1.1'
adr = pyads.AmsAddr(target_AMS_address, pyads.PORT_SPS1)  # Replace with target AMS address
pyads.add_route(adr, remote_ip)

local_address = pyads.get_local_address()
print ('local_address: ', local_address)

# # Code above gives me folowing return from linux
# port:  30000
# 2021-02-25T11:30:44+0100 Info: Connected to <IP_ADDRESS>
# local_address:  <AmsAddress <IP_ADDRESS>.1.1:30000>
# 2021-02-25T11:30:44+0100 Info: connection closed by remote

Also I want to mention, in my ideal setup there would be 2 simultaneous connections, one from TwinCAT on windows and another one reading data from PLC on linux to save on a database.
I tried the code taken from here:https://pyads.readthedocs.io/en/latest/quickstart.html and it seems to be adding the route to the plc (I saw the name I provided there in Thru the TwinCAT) but it still returns an error. My code:
import pyads

port = pyads.open_port()
print('port: ', port)

# create some constants for connection
CLIENT_NETID = "<IP_ADDRESS>.1.1"
CLIENT_IP = "<IP_ADDRESS>"

# CLIENT_NETID = "<IP_ADDRESS>.1.1"
# CLIENT_IP = "<IP_ADDRESS>"
TARGET_IP = "<IP_ADDRESS>"
TARGET_USERNAME = "Administrator"
TARGET_PASSWORD = "1"
ROUTE_NAME = "route-to-my-plc-ubuntu"

# add a new route to the target plc
pyads.add_route_to_plc(
    CLIENT_NETID, CLIENT_IP, TARGET_IP, TARGET_USERNAME, TARGET_PASSWORD,
    route_name=ROUTE_NAME
)

# connect to plc and open connection
# route is added automatically to client on Linux, on Windows use the TwinCAT router
plc = pyads.Connection('<IP_ADDRESS>.1.1', pyads.PORT_SPS1)
plc.open()

# check the connection state
state = plc.read_state()
print(state)
# close connection
plc.close()

# # The error it returns
# pyads.pyads_ex.ADSError: ADSError: target port not found   ADS Server not started (6).

At this point I am super lost, please help.

Hello Stefan Lehmann,
I somehow managed to make th connection work from linux. I wanted to let you know that the method "add_route_to_plc" gives me a timed_out every time. I had to add the route manually from TwinCAT and it worked (after lots of tweaks to my code).
import pyads
pyads.open_port()
pyads.set_local_address(CLIENT_NETID)
pyads.close_port()
# pass
# connect to plc and open connection
# route is added automatically to client on Linux, on Windows use the TwinCAT router
plc = pyads.Connection(TARGET_ADS, 851, TARGET_IP)
plc.open()

# check the connection state
state = plc.read_state()
print(state)

this gives me a connection status of "(5, 0)", thank you for your help

The most issues we had with route_to_plc so far were because the parameter names are a bit confusing and got mixed up. Would you mind sending the code you used for that so we can investigate?

Hi Stefan.
After much hitting my head against the plc, I discovered that the problem was not pyads but the program the plc was running... it had an overflow problem, so all I was trying was being savotaged by unexpected problems on the side. Sorry to make you worry about pyads, and thank you for your help, time and attention.


<urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1045)>

First of all, great tool! I'm using for the Fast.ai course to get some images. Encountered the following error when using it in another laptop after successfully running it in another (both macs). Apparently on Python 3.6 and 3.7 certificates are not installed you need install separately. Maybe something to document unless this is just something standard that I missed setting-up: https://stackoverflow.com/questions/27835619/urllib-and-ssl-certificate-verify-failed-error
googleimagesdownload --keywords "baloons" -l 10
Item no.: 1 --> Item name = baloons
Evaluating...
<urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1045)>
Starting Download...
Traceback (most recent call last):
File "/Library/Frameworks/Python.framework/Versions/3.7/bin/googleimagesdownload", line 11, in
sys.exit(main())
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/google_images_download/google_images_download.py", line 888, in main
paths = response.download(arguments)  #wrapping response in a variable just for consistency
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/google_images_download/google_images_download.py", line 843, in download
items,errorCount,abs_path = self._get_all_items(raw_html,main_directory,dir_name,limit,arguments)    #get all image items and download images
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/google_images_download/google_images_download.py", line 695, in _get_all_items
object, end_content = self._get_next_item(page)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/google_images_download/google_images_download.py", line 660, in _get_next_item
start_line = s.find('rg_meta notranslate')
AttributeError: 'NoneType' object has no attribute 'find'

@patrickluvsoj

This is sloved my problem..

cd /Applications/Python\ 3.7/
./Install\ Certificates.command

ref: https://github.com/slackapi/python-slackclient/issues/334#issuecomment-433498349

@daolq3012 thanks for the comment. I will add this in the docs within the troubleshooting section.

Added to the docs
closing this issue as it is external to the library.

On Ubuntu, this worked for me.
$ sudo update-ca-certificates --fresh
$ export SSL_CERT_DIR=/etc/ssl/certs

On Ubuntu, this worked for me.
$ sudo update-ca-certificates --fresh
$ export SSL_CERT_DIR=/etc/ssl/certs

This worked!

How to solve this error on Windows?


Can´t run the example in Meteor 1.3.1

I´m getting the following error when running the example.
While loading plugin mss from package nathantreid:css-modules:
fs.js:439:18: ENOENT, no such file or directory
'C:\Users\santiago\Desktop\meteor-react-toolbox-example-master\meteor-react-toolbox-example-master\node_modules\react-toolbox\lib_colors.scss'
I couldn´t make it run with any of the instructions.
Please help!

I'll be glad to help - please provide a github repo with the issue, and I'll take a look to see what's going on. :smile:

Thanks Nathan.
It´s simply checking out this repo (Meteor-react-toolbox-example) and running "npm install && meteor" on it.
I´m using meteor 1.3.1 on Windows and not much more than that.
I´m getting:
"Uncaught Error: Cannot find module './style'" on "meteorInstall.node_modules.react-toolbox.lib.app_bar.AppBar.js" line 876.
Don´t worry about the other error "while loading plugin mss", it was my mistake.

Hi Nathan.
Any ideas on what could be wrong? Sorry to insist, I would really love to use the toolbox in my project!

My apologies - it looks like I just needed to update this to the latest version of my CSS modules plugin.
Please try again, it should work this time. You can update your local version by running meteor update nathantreid:css-modules. Also make you sure you run meteor npm install instead of npm install (I've updated the documentation to reflect this).

Now it works! Thanks!
Do you mind answering one last question? What would be the difference between "meteor npm install" and "npm install"? I thought they were the same.

npm install is dependent on your installed version of npm, whereas meteor npm install uses the version of npm that meteor uses internally. On my computer right now with node 5.1.1 installed, npm --version displays 3.3.12 and meteor npm --version outputs 2.14.22.
For react-toolbox and this demo, if you have npm 3+ installed you have to manually install normalize.css and some other react-toolbox dependencies. Npm 2 automatically downloads them.

Thanks for the clarification!


Site to check in 0.9 SA viridian/G trees - N203

Viridian clearly offers an improvement here with v 0.3.7 - want to check for regression or improvement in 0.9
G illumina

V illumina

closing - trees are cleaner with refactor, and these issues have become noise. have added a label so can find again


Handle users and notify online/offline in gtalk

This patch makes the gtalk adapter create users and send Robot.EnterMessage / Robot.LeaveMessage on login/logoff.
One question: what is the expected behaviour when a user logs off: remove it from the users list or not?

We keep them in the list in the campfire adapter.  User persistence turns out to be quite useful.


Change "Whitherable" → "Witherable"

Seems to be a simple typo that permeated throughout the doc/docstrings.
Before submitting a pull request, please make sure the following is done:

[x] Fork the repository and create your branch from master.
[x] Run npm install in the repository root.
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] Ensure the test suite passes (npm test).

Thanks @ptrfrncsmrph


Include node ID and kind in Conflict & Update records

Previously, we were only including the (internal to the graph) NodeIndex in the structs for representing conflicts & updates. While this is all that's strictly necessary for performing the updates and (eventually) having SDF report what the conflicts are, having more contextual information such as the node weight kind, and the ID of the node makes things a bit easier for debugging issues when looking at spans & traces.

bors merge

bors will have failed due to CI having a termination signal in it -

# Received cancellation signal, interrupting
--
  | Terminated
  | 🚨 Error: The command exited with status 143
  | user command error: The plugin docker command hook exited with status 143

ooohhhhh it does a retry now - I forgot!!


[KOGITO-3375] - Make the operator to fetch the metrics endpoint to add Prometheus support

Many thanks for submiting your Pull Request :heart:!
https://issues.redhat.com/browse/KOGITO-3375
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

@ricardozanini
Could you please review package structure. I am not clear How should I arrange these files. Code to make rest call is at below location :
https://github.com/vaibhavjainwiz/kogito-cloud-operator/blob/99eb0b61dd073e686c25521c6d15a5bba428f8b5/pkg/infrastructure/services/prometheus.go#L70

@vaibhavjainwiz Please rebase, will do a review once Zanini's comments are addressed.

Small BDD adjustment for these changes, can be added as part of this PR - https://github.com/vaibhavjainwiz/kogito-cloud-operator/pull/1

Checked the built operator image on OCP, works as expected.

looks good, just left a question, and please take a look on the failing test.

lgtm
Please merge PR adjustment from @sutaakar : vaibhavjainwiz#1

done

/jenkins test

@vaibhavjainwiz Sorry for wrong information in previous comment....
Right now the ServiceMonitor created by Kogito operator points to wrong port, causing Prometheus to miss Kogito application.
There are two options to specify what port should be used

port (https://github.com/prometheus-operator/prometheus-operator/blob/master/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml#L179) pointing to the service port
targetPort (https://github.com/prometheus-operator/prometheus-operator/blob/master/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml#L239) pointing to the pod's port

Right now this implementation use targetPort, however it is passing service port there, which is wrong.
So we can either adjust the implementation to use port or change the passed port to pod's one.

Right now this implementation use targetPort, however it is passing service port there, which is wrong.
So we can either adjust the implementation to use port or change the passed port to pod's one.

I'd rather use the service one since we can abstract the exposed port in the container.
Thinking about it now, I think we can get rid of the spec.httpPort attribute. There's no practical use. The default http port being served by the service addresses all the issues and make it way simpler to do svc discovery/injection.
@sutaakar @spolti @vaibhavjainwiz wdyt?

@ricardozanini  if there's no use cas for this property anymore, +1 for removing it.

@vaibhavjainwiz is the problem reported by @sutaakar addressed?

@ricardozanini fine for me

Right now this implementation use targetPort, however it is passing service port there, which is wrong.
So we can either adjust the implementation to use port or change the passed port to pod's one.

I'd rather use the service one since we can abstract the exposed port in the container.
Thinking about it now, I think we can get rid of the spec.httpPort attribute. There's no practical use. The default http port being served by the service addresses all the issues and make it way simpler to do svc discovery/injection.
@sutaakar @spolti @vaibhavjainwiz wdyt?

Prometheus operator provides both options to create Service monitor and Pod Monitor. Kogito-operator creates service monitor objects to expose services for scraping so it make sence to provide service pod.
@ricardozanini I am agree with @sutaakar point to take spec.httpPort as input.

@ricardozanini fine for me
Edit: How do we recognize then what port is used by Kogito application? IMHO the spec.httpPort is mainly used for this, to define what port should be set in Deployment as ContainerPort

The question is: why do we need to recognize this? The port should always be defined on 8080 and exposed by the image. This should not change, there's no practical use case for this.
The operator creates a service exposing this port through the default HTTP one. Other services within the cluster will just call the application.
That's my point. There's no use to change the port, no use case. It's there just because. :)

@ricardozanini fine for me
Edit: How do we recognize then what port is used by Kogito application? IMHO the spec.httpPort is mainly used for this, to define what port should be set in Deployment as ContainerPort

The question is: why do we need to recognize this? The port should always be defined on 8080 and exposed by the image. This should not change, there's no practical use case for this.
The operator creates a service exposing this port through the default HTTP one. Other services within the cluster will just call the application.
That's my point. There's no use to change the port, no use case. It's there just because. :)

Its spring functionality which allow user to set his desired port through service.port=9090 prop in application.properties file. Atfer setting this property, every time user start its service through java -jar myapplication.jar, its embedded tomcat server will start at user provided port.
Currently I can't think of any specific reason to explicitly change its default port. In my previous project I used to explictly change port values because we have to run multiple java service on our local machine to test some functionality and we can't run containers on dev system due to hardware constraints.
But in QA/Prod env we always run all services at 8080 port in containers.

Its spring functionality which allow user to set his desired port through service.port=9090 prop in application.properties file. Atfer setting this property, every time user start its service through java -jar myapplication.jar, its embedded tomcat server will start at user provided port.
Currently I can't think of any specific reason to explicitly change its default port. In my previous project I used to explictly change port values because we have to run multiple java service on our local machine to test some functionality and we can't run containers on dev system due to hardware constraints.
But in QA/Prod env we always run all services at 8080 port in containers.

Thanks for sharing your experience, @vaibhavjainwiz. But in this containers scenarios we won't clash ports since there's only one process running within the container and we control it. In case of sidecars injections to share the network from a pod, this other injection pod would require a different port, but again controlled by the operator. There's no use case to change this port any more, only on local environments where you need to share the network resources.
There's no practical usage for this and we are only adding unnecessary code/complexity to our use case. The container will be deployed and served at port 80 by the Kubernetes service. Consuming the Kogito service within the cluster will be straightforward like: http://name.namespace.

Thanks for sharing your experience, @vaibhavjainwiz. But in the container scenario we won't clash ports since there's only one process running within the container and we control it. In case of sidecars injections to share the network from a pod, this other injection pod would require a different port, but again controlled by the operator. There's no use case to change this port any more, only on local environments where you need to share the network resources.
There's no practical usage for this and we are only adding unnecessary code/complexity to our use case. The container will be deployed and served at port 80 by the Kubernetes service. Consuming the Kogito service within the cluster will be straightforward like: http://name.namespace.
And I'd say that we should always force 8080 even if a external configuration like service.port is passed since we are forcing the port to be exposed on 8080 in the images:
EXPOSE 8080

@ricardozanini Totally agree with your. Inside Image we control service port through env var HTTP_PORT but image default exposed port is always 8080.
https://github.com/vaibhavjainwiz/kogito-images/blob/f229b91aeeec09c12a20c3a68010a8f7d40ddde0/modules/kogito-quarkus/added/launch/kogito-quarkus-native.sh#L13-L12

Thanks for bringing the link, @vaibhavjainwiz :D
Opened: https://issues.redhat.com/browse/KOGITO-3568

@vaibhavjainwiz Sorry for wrong information in previous comment....
Right now the ServiceMonitor created by Kogito operator points to wrong port, causing Prometheus to miss Kogito application.
There are two options to specify what port should be used

port (https://github.com/prometheus-operator/prometheus-operator/blob/master/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml#L179) pointing to the service port
targetPort (https://github.com/prometheus-operator/prometheus-operator/blob/master/example/prometheus-operator-crd/monitoring.coreos.com_servicemonitors.yaml#L239) pointing to the pod's port

Right now this implementation use targetPort, however it is passing service port there, which is wrong.
So we can either adjust the implementation to use port or change the passed port to pod's one.

Right now this implementation use targetPort, however it is passing service port there, which is wrong.
So we can either adjust the implementation to use port or change the passed port to pod's one.

I'd rather use the service one since we can abstract the exposed port in the container.
Thinking about it now, I think we can get rid of the spec.httpPort attribute. There's no practical use. The default http port being served by the service addresses all the issues and make it way simpler to do svc discovery/injection.
@sutaakar @spolti @vaibhavjainwiz wdyt?

Prometheus operator provides both options to create Service monitor and Pod Monitor. Kogito-operator creates service monitor objects to expose services for scraping so it make sence to provide service pod.
@ricardozanini I am agree with @sutaakar point to take spec.httpPort as input.

@sutaakar Now our expose port is 80 so don't need to define it explicitly inside ServiceMonitor. I tested it on my local machine, its generating metrics now.

@vaibhavjainwiz this might be a silly question, but can we change the "endpoint" field to reflect the actual port (80)? Or this is the pod IP and port?

@vaibhavjainwiz this might be a silly question, but can we change the "endpoint" field to reflect the actual port (80)? Or this is the pod IP and port?

I had already tried it by explictly setting EndPoint.Port = 80 but it didn't work.
its description dictates as :
// Name of the service port this endpoint refers to. Mutually exclusive with targetPort.
Port string `json:"port,omitempty"`

/jenkins test

@spolti can be merged


Option Request: "Smooth Scroll Speed" (To Better Track "Go To Definition" Movements in Large Files)

When working in large files, smooth scroll is great because when you "Go to definition", you're able to get a sense of where you're jumping to relative to where you came from.
The problem is that the smooth scroll default speed is just too fast. If we could choose the speed at which smooth scroll is applied (or at least for when you're using "Go to definition" / jumping to variables / etc.) it would be a huge life saver!
Video explanation / demo:
https://github.com/microsoft/vscode/assets/304269/1210e0a2-314a-4e54-98ff-5a69ec5b014e

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:) https://github.com/microsoft/vscode/issues/192875

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Introduction to OOP

Simple introduction to OOP. This is written with #46 in mind, but can be moved in the advanced topics as well.
Starts addressing #23 and #24.

I am crazy busy this whole week, then off on Monday. So if @j-m-dean or @alexsquires have a chance to look at this feel free. If not I can deal with it next week (sorry for the delay @RMeli).

Thank you for the extensive review @j-m-dean ! Sorry for the many typos, I thought I removed most of them but obviously the spell checker is not working well with Jupyter.
Regarding masks, should we introduce them here or add something to the numpy section?

TODOs:

[ ] Add pre-requisites section
[ ] Change to "I/we"
[ ] Comment on pass keyword
[ ] Introduce masks with numpy (see above)
[ ] Add figures

[ ] Acetylene
[ ] Class (UML)
[ ] Masking

[ ] Fix typos

Additional TODOs:

[ ] Add Google-style doctsrings; they are introduced in the section about functions.

@j-m-dean there is only one typo I did not address (see comment below). Please let me know if you do not agree with my explanation and I'll be happy to make the suggested change.

Therefore should be usually processed together —> therefore should be processed together

I used "usually" because some operations can be performed on only part of the data (i.e. rotating a molecule will involve coordinates only).

Ah, I see why you have added the usually now. However, I do not think "therefore should be usually processed together" makes sense. May I suggest: "therefore should be, in most cases, processed together"?

Sorry for the delay on this, I've been very busy lately. I added UML-style images for the classes. This should address all the comments beside masking. However, I think that the concept of masking is better in the section about numpy arrays. What do you think?

Need to merge https://github.com/pythoninchemistry/intro_python_chemists/commit/7a0ed35e679e0f1ba73ed7576013378fd1fd97f9 into your code to get it to pass CI btw, see issue #71
I will leave the actual review to @j-m-dean

Looks great! Thank you for all the added stuff. I agree, it does not make sense to introduce masks in this section. I'll add in a little section at the bottom of numpy_arrays at some point.

Sounds good. Thank you for all the valuable feedback @j-m-dean !


the info.plist error

What i need to add in info.plist error, The error occurs when i upload app to review

Hi @mohanarchu
Please can you show me your error log?


Delete firestore-shorten-urls-dynamic-links

This extension was in open alpha. It has now been moved to the experimental extensions repo: https://github.com/FirebaseExtended/experimental-extensions/tree/next/firestore-shorten-urls-dynamic-links

LGTM, could also be removed from here: https://github.com/firebase/extensions/blob/next/lerna.json#L7 but not a blocker.

Thanks @Salakar! Removed it


Is this project dead?

Just wondering if I need to fork it

If you have a specific question, ask it. If you're not satisfied with the response then use the power of opensource and just fork it!
I am not the project owner but I have gotten good response to issues and questions on this project.

@jonbartels is there any reason that a good PR like [https://github.com/tim-group/java-statsd-client/pull/31] doesn't get any review ?

You're right in that the project is not very active. I know it can be frustrating to try and contribute and not have pull requests acknowledged.
I'd suggest three things to get your pull request accepted:

Update it so there is a description explaining what the change does and why it is helpful or valuable to the project. For example what use case does a batched UDP sender help solve?
Include test classes for your change.
Ask more direct questions of the project about the pull request. "Why wasn't this change reviewed or accepted?" is a clear question about the pull request. "Is this project dead?"

For what its worth, I looked over your commit and it is well written. I wonder if using a different constructor (NonBlockingBatchStatsDClient?) instead of a boolean flag might be better. I am not sure though.
I hope that helps. Your contribution looks OK to me but I don't control the master project, I am just another contributor!

@coderlol I would recommend looking to DataDog/java-statsd-client for a more up-to-date codebase and a more responsive maintainer.


add get_table_by_scope to eosjs

Issue 503

This looks great, thanks for contributing! Before merging, can you add a test for this new function similar to the one for get_table_rows? https://github.com/EOSIO/eosjs/blob/develop/src/tests/eosjs-jsonrpc.test.ts#L382

updated.

Great work, thanks!


Several fixes for 5.6 toolchain

Reactor model support
Update sanitizer support object

This is required to resolve https://github.com/TokamakUI/Tokamak/pull/475

Thank you so much for investigating it. This is great, I really appreciate your hard work on these issues! 🙏

Do we still need so_sanitizer.wasm file for this to work? With this PR as is I get ~/.carton/static/so_sanitizer.wasm: No such file or directory error, but I'm not sure if this file is no longer needed and we're no longer supposed to link with it, or the file was just lost in my static.zip archival process.

Hmm, weird. I didn't change anything except for the content of so_sanitizer.wasm. The support object file is still necessary.

I had to point tests utilizing Tokamak to the branch of https://github.com/TokamakUI/Tokamak/pull/475. Waiting for that to be approved, then will tag new Tokamak and merge this one.


It looks like this package is no longer available from npm

Searching for @opentelemetry/exporter-otlp-http on npm shows no results now.

The rename from @opentelemetry/exporter-collector to @opentelemetry/exporter-otlp-http happened via #2476 which was after 0.25.0 release which is the current latest.
Once 0.26.0 is released (see #2505) it should show up on NPM.
@dyladan it seems publishing of canary versions seems to be not done for new/renamed packages. Is this intended?

@Flarna So it looks like the old package is available but the new one is not yet. Raised ticket as the ReadMe points to the new package that does not exist.


Error in the fifth step of the program: (GPEN)

Traceback (most recent call last):
File "inference.py", line 342, in
main()
File "inference.py", line 198, in main
pred, _, _ = enhancer.process(img, img, face_enhance=True, possion_blending=False)
File "C:\AI-3\third_part\GPEN\gpen_face_enhancer.py", line 116, in process
mask_sharp = cv2.GaussianBlur(mask_sharp, (0,0), sigmaX=1, sigmaY=1, borderType = cv2.BORDER_DEFAULT)
UnboundLocalError: local variable 'mask_sharp' referenced before assignment
Looking for any help and answers, thank you teachers and designers.

Its' similar to this issue.
Hope this helps~

它與this issue類似。
希望這有幫助~

Ok, thanks for the guide!


Adding compatibility to python3.6

Pull Request Test Coverage Report for Build 41

19 of 27 (70.37%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-6.0%) to 94.03%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

recursive_decorator/transformer.py
19
27
70.37%

Totals

Change from base Build 38:
-6.0%

Covered Lines:
126

Relevant Lines:
134

💛  - Coveralls


character creation script

create script and code for players to choose race and class...

Add functionality to the races and classes of characters based on what they rolled.


Snapshot name to include super modules?

I can see that snapshot names include module name (typically just test). I think there might be conflicts when a couple of modules at the same level have a "test" submodule with identical test functions. For example:
mod1.rs has a submodule "test" with a test "test_foo()"
and
mod2.rs  has a submodule "test" with a test "test_foo()".
There are few ways to avoid this situation: put modules into subdirectories, rename test submodules or test functions. But I think it could be the most convenient to have snapshot names include super modules too: mod1__test__foo.snap, mod2__test__foo.snap, etc.

For reference, duplicates https://github.com/mitsuhiko/insta/issues/78.


Add description of new forecast file year control format

New option for Fcast_years controls in forecast file triggered by -12345 needs to be added to the user manual.
Description and example input are in https://github.com/nmfs-stock-synthesis/stock-synthesis/issues/493.

Updates for this have already been included in PR #183 if you look at the forecast file changes here:
https://github.com/nmfs-stock-synthesis/doc/blob/64f006fb60946e252c6f06498b6eef849f0073f6/7forecast.tex#L110-L150

@iantaylor-NOAA Let me know if there are any further changes that you think should be made.

Those updates look just great. My confusion was that the current user manual doesn't include them even though PR #183 was merged a while ago. There seems to be an issue with the github action posting the User Manual to the github.io page. I'll post a separate issue covering that.

The user manual on the github io page is only the manual from the most recent release


Toggle speaker not working on Android

Hi MrHertal, i have 2 problem when using the package:

I did implement Toggle speaker on the app, but i notice it only works on IOS, but not Android, do you have any solution for this issues?

2, this issues only happen on Android, i did using "backToForeground" when the Android phone make voice call, sometime it working, sometime the native callkit screen will back to foreground, do you have any solution for this?
Appreciate if you can provide the solution, Thanks :)

Sorry for late response,
Have you tried to reproduce this issue with the last version of the example app?


[fix](routine load) do not cancel job if not found transaction

If do not find transaction when planning for the routine load task, the routine load job will be canceled. In cloud mode, it may RPC timeout. Meanwhile, it should not cancel the job if the transaction cannot be found, as the job can still be rescheduled.

run buildall

run buildall

run buildall

run buildall


Bump Plex to 1.1.3 at stable

no hurry :)

1.1.3 created 05.10.2023

@ticaki
Nothing special - your PR was only used as a test for the new auto-info function :-)


sorry by mistake this problem facing

please resolve this issue

Little bit more details would be helpful as "sorry by mistake this problem facing" and "please resolve this issue" doesn't really explain what issue are you facing.

[image: image.png]i am facing this issue
On Wed, 23 Mar 2022 at 01:40, ccris02 @.***> wrote:

Little bit more details would be helpful as "sorry by mistake this problem
facing" and "please resolve this issue" doesn't really explain what issue
are you facing.
—
Reply to this email directly, view it on GitHub
https://github.com/polkadot-js/phishing/issues/1322#issuecomment-1075591871,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYLTV6IDWC452SG6UDY4W7LVBISMBANCNFSM5RL5HTQA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sorry, I don't understand your issue.
Do you have trouble accessing some websites or are you an owner of a site that was blocked?

Sorry to hear that. Your site was tagged as impersonating https://polkadot.network/
As you can see in the provided images in PR #1319

[image: image.png]how to remove this page
On Wed, 23 Mar 2022 at 23:27, ccris02 @.***> wrote:

Sorry to hear that. Your site was tagged as impersonating
https://polkadot.network/
As you can see in the provided images in PR #1319
https://github.com/polkadot-js/phishing/pull/1319
—
Reply to this email directly, view it on GitHub
https://github.com/polkadot-js/phishing/issues/1322#issuecomment-1076646431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYLTV6NSXRKIPI42ZKUNIBLVBNLQVANCNFSM5RL5HTQA
.
You are receiving this because you authored the thread.Message ID:
@.***>

i removed all pages from server please remove this page
[image: image.png]
On Thu, 24 Mar 2022 at 00:31, may i help you by chota Solanki <
@.***> wrote:

[image: image.png]how to remove this page
On Wed, 23 Mar 2022 at 23:27, ccris02 @.***> wrote:

Sorry to hear that. Your site was tagged as impersonating
https://polkadot.network/
As you can see in the provided images in PR #1319
https://github.com/polkadot-js/phishing/pull/1319
—
Reply to this email directly, view it on GitHub
https://github.com/polkadot-js/phishing/issues/1322#issuecomment-1076646431,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYLTV6NSXRKIPI42ZKUNIBLVBNLQVANCNFSM5RL5HTQA
.
You are receiving this because you authored the thread.Message ID:
@.***>

client hold

Coinpolkadot.com

Care to explain how the project is related to polkadot
why was there a polkadot logo etc?


Development

Changes Proposed in this Pull Request:

moving to final version 1 for publication
parse energies from Rosetta-generated PDB files
more Fragment manipulation
parse MASTER
get sequence from labels (both alone or as alignment)

Check List:

[ ] closes #xxxx
[ ] tests added / passed
[ ] whatsnew entry
[ ] documentation updated and re-compiled

Pull Request Test Coverage Report for Build 244

0 of 0   changed or added relevant lines in 0 files are covered.
141 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.5%) to 82.836%

Files with Coverage Reduction
New Missed Lines
%

.tox/py36/lib/python3.6/site-packages/rstoolbox/components/designFrame.py
14
90.73%

.tox/py36/lib/python3.6/site-packages/rstoolbox/analysis/sequence.py
16
86.67%

.tox/py36/lib/python3.6/site-packages/rstoolbox/utils/tools.py
26
70.29%

.tox/py36/lib/python3.6/site-packages/rstoolbox/io/rosetta.py
85
72.33%

Totals

Change from base Build 241:
-1.5%

Covered Lines:
3499

Relevant Lines:
4224

💛  - Coveralls


Load play data for a given player

Get the play/event data for a player page. Individual player pages are specified by the path parameter /hashmarks/player/<PLAYER ID>. This should be a function that takes a player suggestion, and a sequence of PlayType containing the type of plays to get.

Resolved with commit 3b31493460f25358c72ba97f4b60a8a865eb4b70


Question on communication with share extension and main app

Hi, thanks for this component.
On iOS all its fine configured and running, also I used the module react-native-swiss-knife to enables sharing the URL value between share extension and the main app (workes fine).
My question is: how can I notify about the new URL value and open the main app after closing the share extension?
Thanks!

as far as I know, you can't use openURL to open any app including the main app from share extension.
You can let the user know to open your app. if your app is not loaded, then you can get it from react-native-swiss-knife. if your app is already launched, you have to use App State to detect opening your app and check if a new value has been added or not.
I will close this ticket, but feel free to continue the discussion.

Thanks for your quick response.
I manged to do it with openURL- first i set the URL scheme (Register URL Schemes), then i tried to implement it with RN but i couldn't make work, so i did it with Objective-C (openURL Deprecated in iOS 10)

@adambmc Can you explain a bit more about how you achieved this? As @alinz says, you are not really supposed to be able to use openURL inside share extensions on iOS.

@isaachinman You could use openURL method of NSExtensionContext: https://developer.apple.com/documentation/foundation/nsextensioncontext/1416791-openurl?language=objc
Here is the implementation of native module for Today Widget: https://github.com/matejkriz/react-native-today-widget/blob/master/ios/TodayWidgetExtension/Linking.m

@matejkriz Unless I misunderstood, that only applies to Today extensions. This utility, react-native-share-extension, specifically works with Share extensions. It seems like your proposed solution avoids this repository completely?

@isaachinman I believe you could reimplement the same for react-native-share-extension. Share extension also use NSExtensionContext: https://developer.apple.com/library/content/documentation/General/Conceptual/ExtensibilityPG/Share.html#//apple_ref/doc/uid/TP40014214-CH12-SW1

@isaachinman BTW: https://github.com/alinz/react-native-share-extension/pull/67/files

Ah wow! I had no idea you had a PR open. There are several PRs open for this project that add extremely useful functionality (eg multi-image support, and this). I will check it out now. Thanks!

It's not mine PR, I just have it in bookmarks because I was looking for inspiration for react-native-today-widget...

Yeah, I saw that as soon as I opened it. It's a familiar face, @birkir. I assume he has deployed apps with Apples approval containing this method (?).

Yes, this method passes apple's approval 👍


Remove Travis CI

Changes

Remove .travis.yml, which pushed release images to quay.io. This is no
longer needed now that we have release jobs with GitHub Actions.
Removed references to Travis in the Makefile and docs.
Removed references to Travis in script comments.

/kind cleanup
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[ ] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes
NONE

/assign @qu1queee
/cc @ImJasonH

/approve


Pod yaml in this page has syntax issue

Pod yaml in this page has a syntax issue.
Reproduce steps:

copy the pod yaml in the below link
https://learn.microsoft.com/en-us/azure/aks/azure-csi-files-storage-provision#use-the-persistent-volume

use "kubectl apply" to deploy it in your AKS cluster

Error message:
kubectl apply -f azure-pvc-files.yaml
error: error parsing azure-pvc-files.yaml: error converting YAML to JSON: yaml: line 8: mapping values are not allowed in this context

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bdb3a253-ff94-1b97-62c9-e21153598452
Version Independent ID: b95ca0b2-e809-a149-dec7-a15ac2146ee1
Content: Create a persistent volume with Azure Files in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/azure-csi-files-storage-provision.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@alexxiongxiong
Thanks for your feedback! We will investigate and update as appropriate.

@alexxiongxiong - I've identified the formatting issue with the yaml manifest and I am going to open a PR now to get it corrected.

Created PR - https://github.com/MicrosoftDocs/azure-docs-pr/pull/248469.
As a result of addressing the primary issue raised, I'm going to proceed with closing this PR. Thanks for bringing this problem to our attention. #please-close


dvm use version substring / use problem

On windows 7, powershell:
dvm i 1.9.0
dvm use 1.9
(no error message, but there should be one?)
docker ps
(docker command not found)
dvm use 1.9.0
(now it works fine)

Thanks! Definitely a bug on my end.


Master

I think you need to use a different starting point for your PR, and explain what it is that you're trying to achieve.

Please disregard.  It was a mistake.
Thanks,
Tim
On Jun 8, 2015 2:39 PM, "Paul"<EMAIL_ADDRESS>wrote:

I think you need to use a different starting point for your PR, and
explain what it is that you're trying to achieve.
—
Reply to this email directly or view it on GitHub
https://github.com/angular-ui/ng-grid/pull/3727#issuecomment-110102671.


[Bug][master] proccess will wait permanently

**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
Describe the bug
When the master gets a process with more than 100(master.exec.threads - activeCount) sub processes, it will wait permanently.
To Reproduce
Steps to reproduce the behavior, for example:

Go to 'Define process A, there are 10 common subprocesses, define a process B, there are 10 processes A'
定义流程A，里面有10个普通子流程，定义一个流程B里面有10个子流程A
Click on 'run'
点击运行
See error at process instance list，process B will wait permanently.

Expected behavior
run process B，Keep it running
Screenshots
If applicable, add screenshots to help explain your problem.
Which version of Dolphin Scheduler:
-version:all
Additional context

Requirement or improvement
I don't think process B should be directly put into the waiting thread when dividing the main process, otherwise it will never have a chance to run. Maybe when adding a new process, judge the number of subprocesses and give a friendly prompt.
我认为分割主流程时不该直接将process B放入等待线程，否则永远没有机会运行，也许新增流程时判断子流程数量，给出友好提示

we have removed this status in 2.0.0


Suggestion: Allow mlocate/slocate as file list sources as opposed to find

Category

[ ] fzf binary
[ ] fzf-tmux script
[x] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[x] Etc.

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[x] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[x] zsh
[x] fish

The shell script bindings use find. For large filesets this takes an appreciable time, and given find's nature this is probably unavoidable. I've tested against mlocate/slocate /file/path and see that fzf finishes almost instantly. Would you be open to providing a environmental variable to control what utility does the underlying searching for the built shell bindings?

We already have configuration variables.
https://github.com/junegunn/fzf#key-bindings-for-command-line


server is in ES5

https://github.com/cloverfield-tools/universal-react-boilerplate/blob/master/app/node_modules/server/index.js contains a bunch of ES5 instead of ES6

Yeah. Looks like a pretty simple change. PR?

Yep in a bit

I've scrapped the whole thing and implemented ES6 in this commit

awesome


Disable ml2 port_security extension

In order to achieve parity between upgraded and freshly installed
environments, the ml2 port_security extension is disabled in Liberty.
While greenfield environments are not affected, environments upgraded
from Kilo to Liberty will experience VM breakage when connecting to
pre-existing networks. https://bugs.launchpad.net/neutron/+bug/1509312
has more detail, including a patch that allows neutron to handle this
gracefully, but that patch has not yet merged into Mitaka or Liberty as
of this writing.
Addresses #929
(cherry picked from commit 84827b83b6c7313040c1b3b5e9e0dc9f2a98b804)

simple backport :+1: (if checks pass)

:+1:


Query strings after URL to assets, are removed on exporting.

Environment

macOS High Sierra v10.13.6
Local by Frywheel v3.2.1

nginx
PHP v7.3.2
MySQL v5.6.34
WordPress v5.2.2

What I did

I added img tag to index.php in twentynineteen theme. The image URL in this tag has a query string.

/Users/{User Name}/Local Sites/{Site Name}/app/public/wp-content/themes/twentynineteen/index.php
<?php
get_header();
?>

	<img src="<?php echo get_stylesheet_directory_uri(); ?>/screenshot.png?v=1" alt="screenshot">

I exported as ZIP file with pushing Start static site export button in admin page, with following settings, and downloaded.

Where will you host the optimized version of your site?:
ZIP archive (.zip)

Allow offline usage:
No

Destination URL:
http://{Local by Flywheel site domain}

Expected results
The image URL in downloaded index.html, also has query string.

Because query strings are used for cache busting.
Actual results
The image URL in downloaded index.html, does not have query string.

Query strings are removed in this method.
https://github.com/WP2Static/wp2static/blob/2956be326fcd3ca54423f57a676757ee3c3981aa/src/RemoveQueryStringFromInternalLink.php#L7

I have travel booking site, where I use query strings, in links, to redirect for external search.
E.g.: , after static generation it's removed and becomes:

Query strings for dynamic content aren't supported on a static site.
I'd suggest you setup pretty URLs instead of query strings, ie /redirect/21/23/, which would allow generation to go complete, putting an index.html in each of those directories

"Note supported easily" to be precise. You can do things with JSON files and JavaScript, for example, but that's usually not going to be what you want to do when converting a WordPress site to static

I am reading out the query parameters with JavaScript but they indeed get writed out when running wp2static. Can we make this an option in the settings? e.g. Rewrite query parameters yes/no.

@Sef1995 definitely getting this in.
Another major rewrite underway before v7, which should make this option easier to implement

note: Hugo's use of content hash seems ideal here: https://github.com/gohugoio/hugo/issues/621#issuecomment-63184122

Like @Sef1995, I'm using query parameters with JS. +1 to being able to toggle this setting on and off. Please make sure the setting applies globally and not just to assets, etc.
This took me a while to track down because of how unexpected it was. :/

Noted, @logoscreative. May I ask - is this purely for cache-busting or are you using query strings for something else in the static site?

@leonstafford Actually, just passing some basic context back and forth between pages. I know there are fancier ways to do it, but it works fine for my use case.

Thanks @logoscreative - ah, great! Will see how it's being done in V7 now and hopefully a quick configurable option.

@dsktschy and all - V7 core plugin won't touch query strings, and should be good to start testing: https://github.com/WP2Static/wp2static/releases/tag/7.0-alpha-003
Advanced HTML/CSS processor addons coming to allow cachebusting control or modification of existing query strings.

Thanks Leon! I'll use the Alpha :D
Sharing another use case here in case helpful:
I use a CDN combined with automatic image optimization, so query params are really useful e.g. image.jpg?width=200


possible to install docker on running gce instance?

Greetings,
Im sorry if this has already been talked already as I dont seen any yet. I was looking if its possible for machine to install docker on a running host with no docker installed yet?

There is an experimental driver called "generic" that would do this but it's not yet merged.  Feel free to test it out and comment :)  https://github.com/docker/machine/pull/406


[COH-18373] Enhance/trace levels and context

I've created a JIRA task for that.
Renamed the field to "Trace Filtering"
The levels are now "Level 1/2/3"
Fixed the names (this was done on the backend)
Added ":"


Handling images upload with angular

Hey guys, first thanks for this amazing inline editor.
I've included the editor in an angular webapp, using the following directive code  :
 angular.module('editorApp', [])
    .directive('ngEditor',  function(){
        function link(scope, element, attrs){

            // Initialise the editor
            editor = new ContentTools.EditorApp.get()
            editor.init('[ng-editor]', 'ng-editor')

            // Bind a function on editor save
            editor.bind('save', function(regions, autoSave){

                scope.$apply(function(){
                    scope.regions = regions;
                });

                // "regions" contains all the html for each editable regions
                // Now, "regions" can be saved and used as needed.

            })

        }

        return {
            link: link
        }

    })

My problem is that I can't upload images. I've tried to insert the blueprint code given on http://getcontenttools.com/tutorials/handling-image-uploads in this directive like so :
angular.module('myAwesomeAppToChangeTheWorld')
  .directive('ngEditor', function () {
    function link(scope, element, attrs){

            // Initialise the editor
            var editor = new ContentTools.EditorApp.get();
            editor.init('[ng-editor]', 'ng-editor');

            var imageUploader = function(dialog){
                console.log('DIALOG : ' + JSON.stringify(dialog));
                Materialize.toast('IMAGE DIALOG LOAD', 2000);

                dialog.bind('imageuploader.cancelupload', function () {
                    // Cancel the current upload
                    Materialize.toast('CANCELED', 2000);
                    // Stop the upload
                    if (xhr) {
                        xhr.upload.removeEventListener('progress', xhrProgress);
                        xhr.removeEventListener('readystatechange', xhrComplete);
                        xhr.abort();
                    }

                    // Set the dialog to empty
                    dialog.state('empty');
                });

                dialog.bind('imageuploader.clear', function () {
                    // Clear the current image
                    dialog.clear();
                    image = null;
                });

                dialog.bind('imageuploader.fileready', function (ev) {
                    console.log('FILE READY : ' );
                    Materialize.toast('FILE READY', 2000);
                });

                dialog.bind('imageuploader.save', function () {
                    console.log('FILE SAVE : ' );
                    Materialize.toast('FILE SAVE', 2000);
                });
            };

            ContentTools.IMAGE_UPLOADER = imageUploader;

            // Bind a function on editor save
            editor.bind('save', function(regions, autoSave){

                scope.$apply(function(){
                    scope.regions = regions;
                });

                // "regions" contains all the html for each editable regions
                // Now, "regions" can be saved and used as needed.

            });

        }

        return {
            link: link
        }
  });

I've replaced the "addEventListener" on dialog by the "bind" method, because when I use "addEventListener" it says "dialog.addEventListener is not a function", whereas dialog is well defined.
And now it just doesn't work with "bind".
So do you know where my problem come from ? Any idea ?

Hi @jimmy4701,
OK first thing to check is what version you're using, bind has been replaced by addEventListener for all CT UI components since release 1.2.0 (we're currently on 1.2.11). If you're on an older version you'll need to upgrade to 1.2.11 for the blueprint in the handling image uploads tutorials to work.
If you are on the latest version or you upgrade and still get the problem can you console.log the dialog variable as the first line in the imageUploader function and post the output here so I can see what's being sent through.

Hi @anthonyjb,
Thanks in advance for your help :)
According to bower info, I'm on 1.2.11 version
bower ContentTools#*        not-cached https://github.com/GetmeUK/ContentTools.git#*
bower ContentTools#*           resolve https://github.com/GetmeUK/ContentTools.git#*
bower ContentTools#*          checkout 1.2.11

Then, here is what I got doing a console.log( JSON.stringify(dialog) ) :
{"_bindings":{},"_parent":null,"_children":[],"_domElement":null,"_busy":false,"_caption":"Insert image","_cropMarks":null,"_imageURL":null,"_imageSize":null,"_progress":0,"_state":"empty"}

If you console.log(dialog.bind, dialog.addEventListener) what do you get? In 1.2.11 addEventListener for dialogs is a function (or should be) and bind shouldn't exist. Ultimately all UI components inherit from WidgetUI which is where they get the addEventListener method (https://github.com/GetmeUK/ContentTools/blob/master/src/scripts/ui/ui.coffee#L93) and there is no bind method.

Here are the results for the console logs :
bind : function (eventName,callback){return void 0===this._bindings[eventName]&&(this._bindings[eventName]=[]),this._bindings[eventName].push(callback),callback}
event listener : undefined

Unless I'm going mad (or missing something really obvious) that looks like the version is incorrect - can you try using the CT library from the repo or just including via the CDN (http://cdn.jsdelivr.net/contenttools/1.2.11/content-tools.js).
If that fixes it then somehow I'm screwing up the bower updates :(

I've tried with the CDN version, and I've exactly the same results :/

@jimmy4701 sorry for the delayed reply - I'm a bit stumped now :(
I've just looked back over your initial post and the code and I can see you're using
// Bind a function on editor save
editor.bind('save', function(regions, autoSave) ...

If this is working then the wrong version of the library is definitely getting dragged in as bind doesn't exist against the editor and that wouldn't work it would just error. Since your getting to the point where the editor starts (e.g your issue is with uploading an image) I think this has to be a version issue.
Any chance you can give me access to or send me a complete example I can debug live?

@anthonyjb Thanks for your help but I can't give you an access to the code (company code).
I just created a directive using the code I've pasted in my last posts (with editor.bind('save') ).
Don't worry if my problem persists. Unfortunately I had to change from ContentTools to another package, because of time.
Thanks for your help and for your time anyway. Hope the problem will still be an exception.
And thanks for ContentTools which is a pretty good package (and which works on my other projects so ...^^)


[CDS-85246] CDS 816xx release notes.

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the CODEOWNERS.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore
[x] Release notes

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://655f99b5bd73482239daa042--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6564b84b84f30806fc7083ca--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6565679298ee271e3b812f98--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6565faa18f3814040625d469--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65660a1e0b5f96008418cd7c--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65674de5e50eab24b79a022e--harness-developer.netlify.app


Match the change with odh-manifests tests for consistency

Match the change with odh-manifests tests for consistency
Description
With this PR,
the controller pods are explicitly checked, as in odh-manifests there multiple components installed and it cant be assumed only DSPO is installed on the namespace.
To have consistency we are including the same changes here.
https://github.com/opendatahub-io/odh-manifests/blob/master/tests/basictests/dsp-operator.sh
How Has This Been Tested?
Already tested in odh-manifests.
cd tests
make build
make run

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/lgtm
/approve

/lgtm


Unfortunatelly, PepperoniAppTemplate has stopped

Get error message while starting vanila project 1.0.0 on android. Please find attached. The app also complain about env component.
Any Ideas?

Take a look at installation instuctions here: https://github.com/futurice/pepperoni-app-kit/blob/master/docs/SETUP.md#installation. You have to create a blank env file.

Worked! Thanks!

We'll improve the visibility of the setup instructions in the docs. Thanks for your help on responding to this fast @gaykov!


Running magic to create magic database files takes too long

This appears to be a regression in a recent patch, but essentially, Running magic to create magic database files. takes 3x as much time as it used to. I'm not sure how this is happening, but it's greatly inflating PDK build times.

I need more information, as there is nothing updated recently that should be causing extra time here.  But if it's a real effect, I want to know what happened.

I noticed a couple of magic processes were taking quite a while to complete. Not sure if it is the same issue @donn is seeing, but a profile shows:
Samples: 102K of event 'cycles', Event count (approx.):<PHONE_NUMBER>03
Overhead  Command     Shared Object      Symbol
  89.35%  magicdnull  tclmagic.so        [.] DBFullResidueMask
   5.99%  magicdnull  tclmagic.so        [.] lefWriteMacro

A wild guess, but we did add a call to DBFullResidueMask in lefWriteMacro in https://github.com/RTimothyEdwards/magic/commit/ee1d1ae5b0219c272edd4775dccaa3e39647f381

@antonblanchard :  That appears to be the result of running "lef write" on a layout with a huge number of labels, a pretty specific case.

The slow magic process is called from 'make io-A' and when I strace it, it is writing out incredible slowly (1 write every second):
22:29:14.845929 write(4, "END\n    PORT\n      LAYER met3 ;\n"..., 4096) = 4096
22:29:15.906640 write(4, "  RECT 67.530 198.785 67.850 199"..., 4096) = 4096
22:29:17.051336 write(4, "    END\n    PORT\n      LAYER met"..., 4096) = 4096
22:29:18.154393 write(4, "30 197.975 66.650 198.295 ;\n    "..., 4096) = 4096
22:29:19.247822 write(4, "65.900 28.060 66.100 28.260 ;\n  "..., 4096) = 4096

It does seem to be specific to the overlay cells.  sky130_fd_io__overlay_vssio_hvc has thousands of entries for pin VSSIO.  The LEF file for that one I/O cell takes up 10% of the output LEF library.
The LEF library should not contain the overlay cells, anyway, just the top level cells.  I can change the build process to put only the top level I/O cells in the LEF library.

Then please go ahead and do that.


Redshift copy operation does not support map type

Describe the bug
when I'm trying to load parquet files from S3 to Redshift, I'm getting following error:
awswrangler.exceptions.UnsupportedType: Unsupported Redshift type: map<string, string>

One of my fields has map type and can be saved as super type.
How to Reproduce
Create athena table with field of type map<string, string> and try to load it into Redshift table with following script.
import logging

import awswrangler as wr
from redshift_connector import Connection

logging.basicConfig(level=logging.INFO, format="[%(name)s][%(funcName)s] %(message)s")
logging.getLogger("awswrangler").setLevel(logging.DEBUG)
logging.getLogger("botocore.credentials").setLevel(logging.CRITICAL)

con = Connection(
    user='---',
    password='---',
    host='---',
    port=---,
    database='---'
)

entity = "---"

wr.redshift.copy_from_files(
    path=f's3://prod-dwh-transformed/inc/{entity}',
    con=con,
    table=entity,
    schema="---",
    iam_role='---',
    serialize_to_json=True,
    parquet_infer_sampling=0.1
)

con.close()

Expected behavior
data is loaded
Your project
No response
Screenshots
No response
OS
Mac
Python version
3.10.0
AWS DataWrangler version
2.14.0
Additional context
No response

PR #1186 with the fix merged, thank you for your contribution.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.10 to before v5.10.85",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=05c6c029a44d9f43715577e33e95eba87f44d285",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=1e434d2687e8bc0b3cdc9dd093c0e9047c0b4add"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "05c6c029a44d9f43715577e33e95eba87f44d285",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "1e434d2687e8bc0b3cdc9dd093c0e9047c0b4add",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "scsi: pm80xx: Do not call scsi_remove_host() in pm8001_alloc()\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.85 by commit 1e434d2687e8bc0b3cdc9dd093c0e9047c0b4add, it was introduced in version v5.10 by commit 05c6c029a44d9f43715577e33e95eba87f44d285. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002518


[Grid] Improve display of time

✅ Closes: #175

:tada: This PR is included in version 1.26.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Roll engine 44c9fab7b4d8..8ea19b1c76f6 (4 commits)

git@github.com:flutter/engine.git/compare/44c9fab7b4d8...8ea19b1c76f6
git log 44c9fab7b4d8..8ea19b1c76f6 --no-merges --oneline
2019-10-31<EMAIL_ADDRESS>Roll src/third_party/skia 549325c87e9d..809ec77893be (1 commits) (flutter/engine#13458)
2019-10-31<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from p7XYM... to JngMB... (flutter/engine#13456)
2019-10-31<EMAIL_ADDRESS>[fuchsia] [packaging] Prettify parent folder name (flutter/engine#13463)
2019-10-31<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from nhX22... to 866GG... (flutter/engine#13450)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


Hover color of the suggestion item

Thank you so much for creating an amazing package.
I have one question: how can I add a hover color to the suggestion item?

@innodep-joonk  Thanks for filing the issue, I am currently working on this should be out in couple of hours.

@innodep-joonk  Released in v0.9.6 Thank you for using the package. Feel free to leave feedback or report any issues you encounter.
Thank you for your contribution!
Best
Mahesh


Add support for history=off + case insensitive

It would be nice if all GET routes could support both history=on and history=off.

Done in branch develop.


APIX Update

Updated for APIX
Replaced NameplateHandler hooks with AddonLifeCycle

Thank you very much.  This looks like it leaves nameplate distances permanently enabled, but I will take care of that when I test things later.

Thanks for accepting my PR. In regards to the nameplate distances. From my testing, it looks like it's fine if this is what you mean?
With Nameplate distances toggled:

With Nameplate distanced turned off:

Ya, it still hides the nodes in the checks for what to show, but it no longer stops updating the nodes completely when disabled.  I guess I need to check the update times again; if it is still performant with maximum people, I probably can just leave it always updating.  Either way, it's no big deal.  Thank you very much for doing this.

Oh I see now and no problem.

Oh thank Bastet, you are working on this mod!  I can't judge the range for my standard/tech step with out it!

Well, I tested things and submitted the new version, but it unfortunately might be a while before it is available through the main plugin repo.

Can it be added through the experimental section of dalamund?

If you want to build it yourself, sure.  I guess I can try to put back up a third-party repo later, but like the safest thing would be to wait, since going into the main repo puts another set of eyes on it, especially with the new API.  I am honestly not sure how it would interact having a plugin on both the main repo and a third party repo with the same name, and I could see that screwing up updates in the future, so I need to think about it.

ok, ill wait.  Thanks for working on this.  My dancer would hug you if she could.


Mixtral-8x7B repetitive answers

System Info
CPU Architecture x86_64
GPU: 2 x NVIDIA H100
TensorRT-LLM v0.9.0
Image: tritonserver:24.05-trtllm-python-py3
Model weights: https://huggingface.co/mistralai/Mixtral-8x7B-Instruct-v0.1
Who can help?
No response
Information

[x] The official example scripts
[x] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
 What should I do?"

Expected behavior
The model should provide responses without repetitiveness, ensuring higher quality and more coherent answers.
actual behavior
On a lot of prompts I get a very repetitive answer. Here are two examples
Example 1:
Command:
mpirun -n 2 python3 /data/TensorRT-LLM/examples/run.py --engine_dir /data/trt_engines/mixtral/pp2 --tokenizer_dir /data/Mixtral-8x7B-v0.1 --max_output_len 512 --input_text " I'm sick but I have to work. What should I do"

Output:
"<s> I'm sick but I have to work. What should I do?"
 If you are sick and have to work, you should take precautions to prevent the spread of germs.

- Put your used tissue in the waste basket.
- If you don't have a tissue, cough or sneeze into your upper sleeve, not your hands.
- Wash your hands after coughing, sneezing or blowing your nose.
- Try to avoid close contact with sick people.
- If you are sick, stay home and avoid close contact with others to keep from infecting them.
- If you are sick with flu-like illness, CDC recommends that you stay home for at least 24 hours after your fever is gone except to get medical care or for other necessities. (Your fever should be gone without the use of a fever-reducing medicine.)
- Keeping away from others will help prevent others from getting sick too.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay home.
- If you have a fever, you should stay"

Example 2:
Command:
mpirun -n 2 python3 /data/TensorRT-LLM/examples/run.py --engine_dir /data/trt_engines/mixtral/pp2 --tokenizer_dir /data/Mixtral-8x7B-v0.1 --max_output_len 512 --input_text "Give me a pizza recipe and explain it in terms of thermodynamics."

Output:
Input [Text 0]: "<s> Give me a pizza recipe and explain it in terms of thermodynamics."
Output [Text 0 Beam 0]: "

I’m not sure if this is a joke or not, but I’ll give it a shot.

Pizza is a type of food that is made by baking dough with toppings on it. The dough is usually made from flour, water, yeast, and salt. The toppings can be anything from cheese to vegetables to meat.

The thermodynamics of pizza can be explained in terms of the energy that is required to make the dough and the toppings. The dough needs to be mixed and kneaded, which requires energy. The toppings need to be cooked, which also requires energy.

The energy that is required to make pizza can be calculated using the following equation:

E = mc2

Where E is the energy, m is the mass of the dough and toppings, and c is the speed of light.

The energy that is required to make pizza can also be calculated using the following equation:

E = mgh

Where E is the energy, m is the mass of the dough and toppings, g is the acceleration due to gravity, and h is the height of the pizza.

The energy that is required to make pizza can also be calculated using the following equation:

E = mc2

Where E is the energy, m is the mass of the dough and toppings, c is the speed of light, and h is the height of the pizza.

The energy that is required to make pizza can also be calculated using the following equation:

E = mc2

Where E is the energy, m is the mass of the dough and toppings, c is the speed of light, and h is the height of the pizza.

The energy that is required to make pizza can also be calculated using the following equation:

E = mc2

Where E is the energy, m is the mass of the dough and toppings, c is the speed of light, and h is the height of the pizza.

The energy that is required to make pizza can also be calculated using the following equation:

E = mc2

Where E is the energy, m is the mass of the dough and toppings, c is the speed of light, and h is the height of the pizza.

additional notes
The same problem occurs when using Llama3-8b-instruct and the triton-cli where the conversion and engine creation is done automatically. The model returns very lyrical answers with a lot of repetitiveness.
triton import --model llama-3-8b-instruct --backend tensorrtllm --model-repository /data/models

@BugsBuggy
Hi, can you try with the latest TRT-LLM to see whether the issue still exist?
There are recent fixes as to MoE related kernels.
Thanks
June

Hi @BugsBuggy,
We did a reference run using "non TRT-LLM" deployment framework with the same Mixtral-8x7B checkpoints and configs (sampling config, max_output_len, etc) and observed the same repetitive answers as you shared.
In TRT-LLM, the default sampling config uses top_k=1 and top_p=0. If you change them to top_k=-1 and top_p=1 to consider all tokens, the output answer has less to no repetition as shown below:

 TRT-LLM default uses top_k=1, which is a greedy search and can be more prone to generating repeated tokens. From the above, our current conclusion is that this is not a bug. Please try tweaking the sampling config and let us know if you see different behaviors than we described.

Hi @BugsBuggy,
We did a reference run using "non TRT-LLM" deployment framework with the same Mixtral-8x7B checkpoints and configs (sampling config, max_output_len, etc) and observed the same repetitive answers as you shared.
In TRT-LLM, the default sampling config uses top_k=1 and top_p=0. If you change them to top_k=-1 and top_p=1 to consider all tokens, the output answer has less to no repetition as shown below:

TRT-LLM default uses `top_k=1`, which is a greedy search and can be more prone to generating repeated tokens. From the above, our current conclusion is that this is not a bug. Please try tweaking the sampling config and let us know if you see different behaviors than we described.

If I set top_k to -1 and top_p to 1, an error will occur:
RuntimeError: [TensorRT-LLM][ERROR] Assertion failed: topK.value() >= 0 (/home/jenkins/agent/workspace/LLM/release-0.11/L0_PostMerge/llm/cpp/tensorrt_llm/executor/samplingConfig.cpp:231)
1       0x7fead35a0c01 tensorrt_llm::common::throwRuntimeError(char const*, int, std::string const&) + 82
2       0x7fead35d35a2 /root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/libs/libtensorrt_llm.so(+0x7575a2) [0x7fead35d35a2]
3       0x7fead52ebfae tensorrt_llm::executor::SamplingConfig::SamplingConfig(int, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&, std::optional const&) + 78
4       0x7feb4e6da0ed /root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/bindings.cpython-310-x86_64-linux-gnu.so(+0xa80ed) [0x7feb4e6da0ed]
5       0x7feb4e68b16c /root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/tensorrt_llm/bindings.cpython-310-x86_64-linux-gnu.so(+0x5916c) [0x7feb4e68b16c]
6             0x4fdc87 /root/anaconda3/envs/trt_llm/bin/python3.10() [0x4fdc87]
7             0x4f741b _PyObject_MakeTpCall + 603
8             0x509cbf /root/anaconda3/envs/trt_llm/bin/python3.10() [0x509cbf]
9             0x50a869 PyVectorcall_Call + 185
10            0x507a1c /root/anaconda3/envs/trt_llm/bin/python3.10() [0x507a1c]
11            0x4f7786 /root/anaconda3/envs/trt_llm/bin/python3.10() [0x4f7786]
12      0x7fec67d8fc2b /root/anaconda3/envs/trt_llm/lib/python3.10/site-packages/matplotlib/_c_internal_utils.cpython-310-x86_64-linux-gnu.so(+0x16c2b) [0x7fec67d8fc2b]
13            0x50a659 PyObject_Call + 521
14            0x4f0c69 _PyEval_EvalFrameDefault + 11129
15            0x5099ce /root/anaconda3/envs/trt_llm/bin/python3.10() [0x5099ce]
16            0x50a508 PyObject_Call + 184
17            0x4f0c69 _PyEval_EvalFrameDefault + 11129
18            0x4fe0cf _PyFunction_Vectorcall + 111
19            0x4ee40f _PyEval_EvalFrameDefault + 799
20            0x5950f2 /root/anaconda3/envs/trt_llm/bin/python3.10() [0x5950f2]
21            0x595037 PyEval_EvalCode + 135
22            0x5c5e67 /root/anaconda3/envs/trt_llm/bin/python3.10() [0x5c5e67]
23            0x5c0fb0 /root/anaconda3/envs/trt_llm/bin/python3.10() [0x5c0fb0]
24            0x45970e /root/anaconda3/envs/trt_llm/bin/python3.10() [0x45970e]
25            0x5bb53f _PyRun_SimpleFileObject + 415
26            0x5bb2a3 _PyRun_AnyFileObject + 67
27            0x5b805d Py_RunMain + 909
28            0x588679 Py_BytesMain + 57
29      0x7fed09831d90 /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7fed09831d90]
30      0x7fed09831e40 __libc_start_main + 128
31            0x58852e /root/anaconda3/envs/trt_llm/bin/python3.10() [0x58852e]

@BugsBuggy
Hi, can you try with the latest TRT-LLM to see whether the issue still exist? There are recent fixes as to MoE related kernels.
Thanks June

hi @juney-nvidia
tensorrt-llm 0.11.0
The version has this issue.

Hi @BugsBuggy , I tried again w/ tensorrt-llm 0.11.0 with Mixtra 8x7B and top_k=0 (minimal value, should be 0 instead of -1 as I mentioned earlier) and top_p=1 and it doesn't have repetitive answer.  Can you try these two flags w/ Mixtra and Qwen again?


Always include stateMutability information in generated ABI

What is wrong?
We currently do not always include the stateMutability property for functions in the ABI that we generated. That's a problem as it will break tooling such as hardhat which expects that information to be present.
How can it be fixed
:hocho:

This has an open PR that is loosely related: #527


Workaround server-side apply not working

Description of the change:
Explicitly set container port protocol to TCP.
NB: This should have been fixed already while upgrading to k8s 1.20 (see https://github.com/kubernetes/kubernetes/issues/92332 and probably https://github.com/kubernetes/kubernetes/commit/d3e641e84ec9e5a9e551ef394509f65c6e6782b6). Is there some tooling issue?
Motivation for the change:
Fixes:
error calculating structured merge diff:
error building typed value from config resource:
.spec.install.spec.deployments[0].spec.template.spec.containers[0].ports: element 0: associative list with keys has an element that omits key field "protocol" (and doesn't have default value)

Architectural changes:

Testing remarks:

Reviewer Checklist

[ ] Implementation matches the proposed design, or proposal is updated to match implementation
[ ] Sufficient unit test coverage
[ ] Sufficient end-to-end test coverage
[ ] Bug fixes are accompanied by regression test(s)
[ ] e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
[ ] tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
[ ] Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
[ ] Docs updated or added to /doc
[ ] Commit messages sensible and descriptive
[ ] Tests marked as [FLAKE] are truly flaky and have an issue
[ ] Code is properly formatted

@sathieu I've rebased your PR from this side

/lgtm

@perdasilva Thanks for your review. What can I do to move this forward?

/lgtm

Thanks @perdasilva :pray: !