Bruno crashes when I try to export a collection.

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
Bruno crashes whenever I attempt to export a collection. The application displays an error screen with the message "Oops! Something went wrong." (screenshot attached). I am using the official production build.
.bru file to reproduce the bug
No response
Screenshots/Live demo link

Hi @shw2ypro, thanks for reporting this issue. We're working on this.

@shw2ypro , I was able to reproduce the issue while exporting collections as postman collection with empty requests (requests with no url)/ requests with unsaved changes. Did you encounter the error while doing the same or is it something else? Thanks!

Hi @shw2ypro, this issue has been taken care of in our latest release(1.34.2). Please check it out!

Hello @sreelakshmi-bruno I've downloaded the latest version of the app (release 1.34.2), but I'm still encountering the same issue with some collections—not all—when attempting to export as Postman.

@shw2ypro, can you share more details about the collections which aren't working for you/ how i can reproduce them?

Just adding here that this has been fixed in v1.34.2 🎉


[bug] Make all fails grpc related lint error

Describe the bug
Running make all fails with:
coverage: 100.0% of statements
ok      github.com/guacsec/guac/pkg/misc/slice  1.114s  coverage: 100.0% of statements
go tool cover -html=coverage.txt
xargs: goimports: No such file or directory
Testing formatting and imports
test -z ""
Testing copyright notice
test -z ""
golangci-lint run ./...
WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
pkg/collectsub/client/client.go:72:15: SA1019: grpc.Dial is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
        conn, err := grpc.Dial(opts.Addr, grpc.WithTransportCredentials(creds))
                     ^
make: *** [Makefile:74: lint] Error 1

To Reproduce
Go to root of repo and run make all
Running on M1 Mac.
Versions:
go version go1.22.3 darwin/arm64
Guac commit: 9a20f1ec494b72800d4a3d7d5595b437039b2fbe
atlas version v0.24.2-ddf7355-canary
libprotoc 27.0

Unsure if I'm missing any other key dependencies to list their versions.

There is also issues with make build. I will paste the error later but it's related to the copy to bin directory after goreleaser completes.

Here is the error message:
  • build succeeded after 31s
  • thanks for using goreleaser!
cp: ./bin/dist/guacrest_darwin_arm64/guacrest-darwin-arm64: No such file or directory
cp: guacrest: No such file or directory
cp: guaccsub: No such file or directory
cp: guacgql: No such file or directory
cp: guacingest: No such file or directory
cp: guaccollect: No such file or directory
cp: guacone: No such file or directory
make: *** [build] Error 1

goreleaser succeeds but copying from the dist to the bin directory fails.
I have seen other users have this issue and this needs to be made more robust.


Linkvertise bypass not working

I downloaded FastForward to try using it to block Linkvertise but it currently does not work.

Dupe #1419


Specifically strconv.ParseBool(string)
https://golang.org/pkg/strconv/#ParseBool
"ParseBool returns the boolean value represented by the string. It accepts 1, t, T, TRUE, true, True, 0, f, F, FALSE, false, False. Any other value returns an error."
This change returns any matching ParseBool string to that boolean value, or if the string is not one of those values, the error being thrown, returns a false.

Also added test to check for these specific values.
Note: Values such as "tRuE" which used to be parsed as true are now parsed explicitly as false for not matching the whitelist. This may be resolvable via converting the string to lowercase.
I can see reasons to, and not to do so however. If done, all casings of "true" and "false" will parse. Unfortunately, this comes at the cost of diverging from the ParseBool list, which this commit is explicitly addressing.

I really can't see a problem with this PR, so I merged it. Thanks!


Make DirectoryListingService instances be managed by Spring Application Context

Task Description
Currently, we have inline instantiation of  DirectoryListingServiceImpl with different baseUrl parameters within LoggingManagementController and BrowseController. In this task we should re-work it to inject DirectoryListingService instances through Spring.
As an option we can use classifiers to have different instances of same DirectoryListingService interface.
Tasks
The following tasks will need to be carried out:

[ ] Create org.carlspring.strongbox.config.DirectoryListingServiceConfig  configuration with DirectoryListingService beans.
[ ] Replace DirectoryListingServiceImpl instantiation with Spring Application Context managed beans injection.

Task Relationships
This task:

Is a follow-up of: #1046

Help

Our chat
Points of contact:

@sbespalov
@fuss86
@steve-todorov
@carlspring

Dear @carlspring ,
May I work on this task ?

Sure! Thanks for offering to help!


Update EDI Tool Documentation on Ballerina Pages

Description:
Update Ballerina By Example page documentation and Integration Tools page documentation with new revamp changes
Describe your task(s):
The Ballerina By Example page (https://ballerina.io/learn/by-example/record-to-edi/) and Integration Tools page (https://ballerina.io/learn/edi-tool/) need to be updated to reflect the recent revamp changes made to Ballerina's documentation and tooling.

Changed were done and merged to the dev-web-site/u9 release branch.


Suggestions for new functionality

Thanks a lot for the time you have put into the development of SBAM. This covers majority of the functionality that I needed to manage my Fronius / BYD solution. To be quite honest I was somewhat surprised that this is not part of the default solution from Fronius, but it is great that you have developed it.
I have two suggestions for enhancement of the functionality:

I have two arrays of solar panels on my roof, which face in different directions. Therefore my production estimate is the sum of two Solcast forecasts (one for each array) and this is possible to emulate on the hobbyist account it just requires two calls to Solcast with different ressource_id's and then adding the forecasts. Perhaps it could be feasible to include an URL2 as option setting in the config? Would love to contribute on this, but I'm new to Go :-)

I suspect that I later in the year will need to force a charge of my battery during daytime as well. That would be required to ensure I have enough battery capacity to be self-sufficient in the evening peak hours (which are becoming prohibitively expensive). Is this just a matter of extending the crontab hours into the afternoon? Or is there a smarter way?

Thanks a lot. It is really appreciated.
Morten

Hi @Morten-bigum,
thanks for using SBAM ;)
about your suggestions:

It's a really good feature indeed, and I completely agree with you that we need to support multiple arrays.
The implementation is not too hard; we just need to create a list for the Solcast API endpoints and iterate the same methods we already have in SBAM, summing the power estimates.
This feature should be an excellent opportunity to learn golang; the best motivation is coding for our passions, Why don't you give it a try? No deadline here :) .
I would like to code that in the future, but I can't promise any specific date (maybe in November). I'm quite busy at work at the moment, and SBAM is a hobby for me. Of course, I'm looking for new contributors.

Yes, you need to play with crontab and/or start/end hours.

-t, --crontab string          crontab (default "0 0 0 0 0")
-e, --end_hr string           END_HR (default "05:55")
-s, --start_hr string         START_HR (default "00:00")

@Morten-bigum, I'll start working on the URL2 option. I think I'll code it for November.


Segmentation fault on Manjaro Linux (TN installed via coc-tabnine)

please complete the following information:

OS version: Manjaro Linux 20
Editor: NeoVim (coc-tabnine)
Editor version: 0.4.3
Programming language: all (irrelevant)
TabNine extension version: current git HEAD

> ~/.config/coc/extensions/coc-tabnine-data/binaries/2.8.7/x86_64-unknown-linux-musl/TabNine
Segmentation fault

This is on Linux x1 5.6.16-1-MANJARO #1 SMP PREEMPT Wed Jun 3 14:26:28 UTC 2020 x86_64 GNU/Linux. CoC either completely ignores TabNine or says "timed out after 5000ms".

The same happens on our Gentoo installation.

However, replacing the binary with the one manually downloaded using this repository's script works, so I guess it's something with coc-tabnine.


benchmark extension fields

Create a benchmark for square, inv, and mul of trait Field.
implement benchmark for extension fields

https://github.com/Plonky3/Plonky3/issues/130#issuecomment-1751935060 gives the detail performance.
For sqaure, Inv, Mul the performance gains are:
quadraticBef provides a gain of 30%, 17%, 27%for goldilocks and 25%, 40%,14% for MersenneComplex;
cubicBef provides a gain of 40%,55%,16% for MersenneComplex

Could you please try with lto = "fat", and maybe codegen-units = 1, to be sure LLVM considers all opportunities for inlining and related optimizations? On my machine at least, this seems to make the performance equal -
BinomialExtensionField<Goldilocks, 2> square
                        time:   [1.9162 ns 1.9187 ns 1.9212 ns]
QuadraticBef<Goldilocks> square
                        time:   [1.9098 ns 1.9106 ns 1.9117 ns]

I didn't look at the generated assembly, but I suspect that with the default config, the compiler was not inlining addition and thus unable to optimize away 0 + something. With that config change, I suspect identical code is probably generated for both.

Could you please try with lto = "fat", and maybe codegen-units = 1, to be sure LLVM considers all opportunities for inlining and related optimizations? On my machine at least, this seems to make the performance equal -
BinomialExtensionField<Goldilocks, 2> square
                        time:   [1.9162 ns 1.9187 ns 1.9212 ns]
QuadraticBef<Goldilocks> square
                        time:   [1.9098 ns 1.9106 ns 1.9117 ns]

I didn't look at the generated assembly, but I suspect that with the default config, the compiler was not inlining addition and thus unable to optimize away 0 + something. With that config change, I suspect identical code is probably generated for both.
(#147 has related discussion about these config options)

Thanks for the suggestions, I updated the bench data as: https://github.com/Plonky3/Plonky3/issues/130#issuecomment-1752370388. Since another ticket will handle this, I will not update the cargo.toml in this PR.
It seems the base field efficiency dominates the performance. For Goldilocks, both implementations have similar results. But for mersen31complex, its specialized implementation is dramatically more efficient than generalized implementation. A gain of 95% for mul/square, 25% for quadratic ef; 98% gain for mul/square and 50% gain for cubic ef;

LGTM, other than one nit and the black_box (or bench_with_input) change mentioned in #130

LGTM, other than one nit and the black_box (or bench_with_input) change mentioned in #130

Thanks for the hint. Add black_box according to (https://gendignoux.com/blog/2022/01/31/rust-benchmarks.html) and change the para name. The resulthttps://github.com/Plonky3/Plonky3/issues/130#issuecomment-1754209404  seems more reasonable as

@dlubarov @unzvfu, there is one last thing we need to decide. Should we keep the qudraticBef and cubicBef for mersenne31Complex?


How to use it??

Can you add a section, as of how to use this package.
People from none python background have no idea about this.

Hi
There is an Example file that shows complete config files. What specifically would you like more details on?

I will update the specific error, when i get hold of a system

This is error i am getting
spawned: 'dependentstartup' with pid 122
2018-06-05 21:01:43,587 ERRO pool dependentstartup event buffer overflowed, discarding event 0

@sunel
I've seen that error some times. But have you checked the log file? What is the content?

Although I try the plugin as the example, it seems does not work.

I git clone the repos
entry the code directory and python setup.py install
do it as the examples described and occur the error

2018-11-21 15:34:21,916 - supervisord_dependent_startup - [INFO   ] supervisord-dependent-startup event listener starting...
Traceback (most recent call last):
  File "/usr/bin/supervisord-dependent-startup", line 9, in <module>
    load_entry_point('supervisord-dependent-startup==1.2.0', 'console_scripts', 'supervisord-dependent-startup')()
  File "build/bdist.linux-x86_64/egg/supervisord_dependent_startup/supervisord_dependent_startup.py", line 725, in main
  File "build/bdist.linux-x86_64/egg/supervisord_dependent_startup/supervisord_dependent_startup.py", line 528, in __init__
  File "/usr/lib/python2.7/site-packages/supervisor/childutils.py", line 17, in getRPCInterface
    return xmlrpclib.ServerProxy('http://<IP_ADDRESS>', getRPCTransport(env))
  File "/usr/lib/python2.7/site-packages/supervisor/childutils.py", line 11, in getRPCTransport
    return SupervisorTransport(u, p, env['SUPERVISOR_SERVER_URL'])
  File "/usr/lib64/python2.7/UserDict.py", line 23, in __getitem__
    raise KeyError(key)
KeyError: 'SUPERVISOR_SERVER_URL'

@jasonhubs Are you running supervisord like described in the example with supervisord  -c /tmp/tmp_home/etc/supervisord.conf -n?

@bendikro
yes! my supervisord.conf is:
[eventlistener:dependentstartup]
command=python2 /root/supervisord-dependent-startup/supervisord_dependent_startup/supervisord_dependent_startup.py -c /etc/supervisord.conf
autostart=true
events=PROCESS_STATE

@jasonhubs
The supervisord.conf in  the example doc contains much more. Didn't you include everything?

Hey @bendikro.  I'm hitting the same error.  Is there an undocumented dependency around RPC here?
I'm using python3, so perhaps should drop back to 2.

Okay.  I kept digging and the example is not complete.  It needs this as well:
[unix_http_server]
file=/var/run/supervisor.sock   ; (the path to the socket file)
chmod=0700                       ; socket file mode (default 0700)

This helped: https://github.com/Supervisor/supervisor/issues/480#issuecomment-203545042

I think this is now resolved by the updated README.md as discussed in #6

Cool


I got this error after execute

https://ibb.co/bF3d5nW

That usually happens if you have an AMD driver but use something like a VM so that the driver can't access the driver files.

But does the miner work with other device drivers?

Yes it works with CUDA (Nvidia) and OpenCL (AMD). The reason it doesn't work on your screenshot is because the driver location is not accessible which usually happens on VMs.

But it works on all devices, just not on vm or shit ?

Yes, AMD OpenCL drivers sometimes don't work on VMs without also installing it on the VM since your Windows folder on your main computer that contains the driver files cannot be accessed by the VM. That's a problem with AMD and has nothing really to do with the miner.

Good, thanks for fast answer and explain bro :)

No problem, good luck with mining

Now i understand why rdp's not working haha

Thankss


edit minor language issue around TD vs TTD

the current TD is X and we are trying to reach a TTD. minor nit

Thanks! I will fix the wording in other places as well


W3C schema ambiguous

From<EMAIL_ADDRESS>on October 18, 2012 13:19:11
While an RNG schema can be generated without problems, creating a W3C schema from that RNG (as is done by the customization service) leads to ambiguous content models for model.layerLike, staff, lem, and rdg, making the W3C schema unusable.
Original issue: http://code.google.com/p/music-encoding/issues/detail?id=132

From<EMAIL_ADDRESS>on October 18, 2012 14:22:33
This issue was closed by revision r714 .
Status: Fixed


[CP] raw socket support

Commit(s) to merge
0
Target
stable
Prepared changelist for beta/stable
0
Issue Description
i'm not talking about RawSocket
talking about this raw socket
i understand that i can use ffi to run compiled native code and cover these things but it would be easier to maintain code and will simplify the building process
What is the fix
add support for
socket(AF_INET, SOCK_RAW, n) and socket(AF_INET6, SOCK_RAW, n)
give access to socket options like IP_HDRINCL
Why cherry-pick
with raw socket access we can implement icmp, path mtu discovery and a lot of cool things :)
also allows us to modify the traffic class of the packets
Risk
medium
Issue link(s)
nil
Extra Info
No response

This is not a cherry pick request. Please use the General issue template instead to request a feature. A cherry-pick request is for requesting that an already landed commit is merged to a release branch.


Issues with $arguments in visible closure on Filament\Actions\Action: Empty Arguments and Disabled Actions

Package
filament/actions
Package Version
v3.2.115
Laravel Version
v11.25.0
Livewire Version
v3.5.6
PHP Version
PHP 8.3
Problem description
There are 2 main bugs in the provided repo:

$arguments  is empty inside the visible closure on an Action (Filament\Actions\Action) when provided through a blade file. The arguments work fine in other closures (see modalDescription)

@if($this->testVisibleAction->isVisible())
        {{ ($this->testVisibleAction)(['message' => 'HELLO']) }}
@endif

public function testVisibleAction(): Action
{
        return Action::make('testVisible')
            ->visible(fn(array $arguments) => dd($arguments))
            ->requiresConfirmation()
            ->modalDescription(fn(array $arguments) => 'Message from arguments:' . $arguments['message'])
            ->action(fn() => Notification::make()->success()->title('testVisible Success')->send());
}

Result:
[] // app/Livewire/SubscriptionManagement.php:134

Using $arguments inside the closure causes the button to become disabled even when the result returns true from that closure. If you have other actions on the page and then activate one, the actions that use $arguments within the closure disappear from the page while the new modal is open, and reappear when its closed.

===================
The repo can be spun up using Laravel sail for ease.
composer install && npm install

./vendor/bin/sail up

./vendor/bin/sail npm run dev

Same login credentials as the example  for test panel:
'email' =><EMAIL_ADDRESS>'password' => 'password',

Showing 2 buttons disabled when they should be enabled.

After clicking on an enabled action, those actions using $arguments inside the closure are hidden.

NOTE: If the result of the closure is false, then it hides the button correctly.
Expected behavior

$arguments inside the visible closure should be populated if arguments are present.

Using $arguements inside the visible closure should show an enabled action if the result of that closure is true.

Steps to reproduce
Since I used sail in the repo, I'll use it in these steps as well.

Create a custom page - sail artisan make:filament-page TestAction
Add required traits and interfaces to new page -

use Filament\Actions\Concerns\InteractsWithActions;
use Filament\Actions\Contracts\HasActions;

class TestAction extends Page implements HasActions
{
    use InteractsWithActions;

Create 2 actions - this will allow you to test the disappearing and reappearing bug.

public function testVisibleAction(): Action
{
    return Action::make('testVisible')
        ->visible(fn(array $arguments): bool => count($arguments) == 0)
        ->requiresConfirmation()
        ->modalDescription(fn(array $arguments) => 'Message from arguments:' . $arguments['message'])
        ->action(fn() => Notification::make()->success()->title('testVisible Success')->send());
}

public function testVisibleHardCodedAction(): Action
{
    return Action::make('testVisibleHardCoded')
        ->visible(true)
        ->requiresConfirmation()
        ->modalDescription(fn(array $arguments) => 'Message from arguments:' . $arguments['message'])
        ->action(fn() => Notification::make()->success()->title('testVisibleHardCoded Success')->send());
}

Add action and visibility check into blade file (along with action modals blade).

<x-filament-panels::page>
    @php
        $arguments = ['message' => 'HELLO'];
    @endphp

    @if($this->testVisibleAction->isVisible())
        {{ ($this->testVisibleAction)($arguments) }}
    @endif

    @if($this->testVisibleHardCodedAction->isVisible())
        {{ ($this->testVisibleHardCodedAction)($arguments) }}
    @endif

    <x-filament-actions::modals />
</x-filament-panels::page>

Test action on page.

Reproduction repository (issue will be closed if this is not valid)
https://github.com/Kane-R-G/filament-action-bug
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Does it work if you create the action with arguments first?
@php
$testVisibleAction = ($this->testVisibleAction)(['message' => 'HELLO']);
@endphp

@if($testVisibleAction->isVisible())
        {{ $testVisibleAction }}
@endif

Thanks for the response. Weirdly, that example allows everything to work as expected.
The below code still causes the same issue.
@if($this->testVisibleAction->isVisible())
        {{ ($this->testVisibleAction)(['message' => 'HELLO']) }}
@endif


Hive 10689

+1

Looks good, +1.

Issue has been resolved through manual patch process:
https://issues.apache.org/jira/browse/HIVE-10689


{Freeway-Bug} [Adaptive Card > RestaurantOrder.Json]: After typing any character on the edit field, on screen keyboard is getting disappeared.

Target Platforms
iOS
SDK Version
Version 1.0 (2.4.0-beta.20220628.3)
Application Name
Adaptive Cards
Problem Description
Test Environment:
Device: iPhone 11
iOS Version: 15.5
Screen Reader: Voice Over
Repro Steps:

Launch Adaptive Cards iOS application.
Home screen will appear.
Navigate to "V1.5" control and select it.
Navigate on "V1.5" screen and select "Scenarios" button.
'Scenario' screen will appear.
Navigate to "RestaurantOrder.json" control and double tap to activate it.
Navigate to the 'Please Choose' edit field under 'Which entry would you like?'.
Double tap to edit and type some character and observe the issue.

Actual Result:
While navigating to edit field under 'Which entry would you like?' on typing some character on screen keyboard is getting disappeared.
Expected Result:
On screen keyboard should not be disappeared while typing any character under edit field under 'Which entry would you like?'
Note:

After selecting any option from the list focus is going on hidden element as well.
This issue is repro without swipe gesture as well. As on typing any character manually it is also getting disappeared.

User Experience:
It will impact the screen reader user if the on screen keyboard will disappear every time while typing any character in edit search field.
MAS Reference:
https://liquid.microsoft.com/Web/Object/Read/MS.Accessibility/Requirements/04.03.01
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots
https://user-images.githubusercontent.com/95913748/176640988-b7399f83-1b21-4330-853d-4ec7060ddf4d.MP4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

@vagpt
Thanks for reporting this issue.

This issue is working fine on the environment, hence closing this issue.
Test Environment:
Device: iPhone 11
iOS Version: 16.4
App Version: 1.0(2.4.0-beta.<IP_ADDRESS>)


zippyshare changed somehow?

Hey, since today i can't process zippy links, it's testing them before output and all are getting redirected to hell and outputting this error:
if count > 3:
logging.error('{} redirected more than {} times'.format(link, count))
return None
i've tried to increase count but no dice...

@ns6000 It feels like something has changed from Zippyshare side. I will take some time to debug this.

@ns6000 I have pushed out a fix for this. It is working for me. Please checkout the latest code from this repo and try on your end.

it's working now, thank you!

I'm not complaining, just FYI. I've got chance to put it through it's paces and it's not 100% successful, there are maybe 1 or 2 instances per 50 links where it's still unable to generate true download link. But it's some timeout issue I presume, because if you try it multiple times, it eventually works.

@ns6000 I am facing a similar issue as well. This will take some time to debug. Till then, you can try increasing the retry count (I had already increased it to 8, maybe 10-15 should give enough chances that the links are parsed).

ok, thanks for the tip

@ns6000 I am facing a similar issue as well. This will take some time to debug. Till then, you can try increasing the retry count (I had already increased it to 8, maybe 10-15 should give enough chances that the links are parsed).

see the source code  of jdownloader2 it works perfectly with all zippyshare files although its wrriten in java

@advith231 I haven't looked too deep but afaik jdownloader uses an actual browser instance in the java process to run the javascript code and generate the download link.
We have discussed a similar approach for this project here. But that approach is not as fast the current approach where we don't run any JS but extract the link by matching the link generation logic.
As long as this works, I will not move to a browser runtime approach.

@ns6000 I have taken a new approach for generating download links. In my testing, this has proven more robust than previous approach. Please give it a try by cloning the latest code. (Note: Install the dependencies).

@Cartmanishere i've tried 20 files and all without problems, great job, thank you!


Add data flow diagram for various ETL steps in pipelines

Fixes

Fixes #4455 by @AetherUnbound
Description

This PR adds a document which visualizes and describes the current and proposed data flows for the project. It also enumerates the ETL steps at each stage to make it easy to understand which operations are happening at which step.
I didn't include any transformations that happen between the client and the frontend because I wasn't aware of them, but please feel free to point them out and I can add them!
Testing Instructions

Check out the document preview and make sure it makes sense.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (just catalog/generate-docs for catalog
PRs) or the media properties generator (just catalog/generate-docs media-props
for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Excited to spend more time reviewing this!
Tiny error detail I noticed to begin with, but the API pulls from ES, and does dead link filtering on the ES hits (meaning, only has ES's data) + Redis (which is being both read from and written to during this process), not the API DB. The API only pulls the API DB results just before passing to the serializer, after all the search_controller routines are finished working on the ES hits. The difference there is that any dead link filtering that happens only has ES and Redis to work off of (currently), and to incorporate the API DB there would require a new API DB query for each ES query. Right now, there's only ever one single API DB request, and 1 ... n ES queries (limited by the max iteration depth of search_controller._post_process_results).
The change to the graph would be to say, the API pulls from ES, filters and processes the ES results, and then only pulls the final presented subset from the API DB. So ES + Redis -> dead link filtering (filter) -> API DB -> API serializers (transform) -> requester, and then if the frontend is the requester, the frontend also does some additional processing (like generating attributions), but those are not a necessary (as in, constant) part of the data lifecycle. It might be self-evident, but worth keeping in mind that the frontend is not the only API consumer, and transformations created at the frontend level are not getting to anyone else. That's fine if they're just for the frontend to use, but not fine if those transformations could also matter to other clients (like the WP media inserter, or Openverse Slack Reaction app).
There's a cyclical relationship between the API DB and ES in that one informs the way the other is used, either to decide what data to load into ES to begin with, but then also what results to present from the API DB, with the API DB results being those that are presented, not the ES hits.
Additionally, it would be good to add the fact that Redis is both written to and read from during dead link filtering (which is basically itself an ETL process, I guess, we're at the very least generating data, if not extracting it, though we do save the specific status code, not just a dead/not-dead boolean).
Really awesome, though, very excited to dig into this more, and to get a more cohesive view of how each part of our data lifecycle works with the other parts.

Especially with the ingestion server removal project, we're pulling things more inline with treating Airflow as the coordinator of movement in our data infrastructure. Using the EC2 workers as workers is standard practice (I've learned this recently), but something like the ingestion server never was! It was doing Airflow's job, and way more tediously. Moving towards more Airflow-y way of coordinating our Catalog -> API DB -> ES ETL was not an explicit intention (we instead wanted to simplify data refresh to make it easier to work on, without ever explicitly saying that the reason it would be simpler is because it would be more in line with how Airflow should be used to coordinate these things!), but is a significant and meaningful realignment and readjustment of how the ETL pipelines are thought about. That's excellent, because it means we are making prescriptive changes towards a vision of "how things should be for Openverse", by saying "Airflow is the place for this".

It's interesting to hear you say this. I feel like I've been trying to communicate this point and push for exactly this way of thinking about Airflow for a while 🙂 It was part of the reason I wanted to see if we could use the ECSRunTaskOperator or something similar for the actual reindexing step rather than keep the Falcon server/indexer workers that we had. Airflow is built for this kind of coordination and centralized management, and it's definitely a vision I've been working to communicate.
What I'm hearing, though, is that it might have been useful to make that intention explicit in some form of policy or "vision" document. That might have helped make it clearer to communicate "this is what we want to use Airflow for" rather than me saying it over and over during the occasions where an opportunity to leverage it cropped up organically. That's helpful feedback, and hopefully that can also be part of the things we make explicit:

The catalog database is the data warehouse where we store as much information as we can/is reasonable.
Airflow is the orchestrator for our data management and automation workflows, particularly those that interact with multiple systems or aspects of our stack.

@AetherUnbound the changes look great :+1:

Airflow is the orchestrator for our data management and automation workflows, particularly those that interact with multiple systems or aspects of our stack.

I think the specific thing that didn't connect to me is that Airflow isn't even a data engineering tool, per se. It's just a task scheduler and you can do anything with it. The data engineering happens with other tools, like Postgres, or Python scripts. It didn't click to me until I read about data engineering tools generally and realised that Airflow doesn't have much to do with it aside from being a task coordinator.
With respect to the ingestion server removal, I did not understand the difference. I still don't think ECS is a good option (FARGATE's pricing structure is actively hostile to resource cost/utilisation optimisations and wildly expensive), but AWS Batch with spot instances would be a tremendous change and I'd support going in that direction.
Yeah, for whatever reason it never clicked that Airflow is just a task coordinator :confused:. Sorry! I haven't been that involved in data things until the ingestion server removal project, so I'm not sure I encountered that idea before, and when reviewing that IP I did not understand the idea of removing the API from the indexer workers. We can still do that if we want, and swap out the ASG for AWS Batch, even without spot instances, and it would be an improvement and move towards a more airflow-y model for sure. I think I was also specifically hung up on ECS FARGATE, which as I said above I think is a specifically bad solution, but it's possible to structure the containerised workload such that the execution environment doesn't matter, so swapping ECS for kubernetes or AWS Batch becomes more or less trivial. I apologise for not understanding that, something just didn't click until I learned more about data engineering as a whole and Airflow in particular in the past two weeks.

The only thing that struck me as potentially confusing is placing the temp table within the ingestion server visually, when this is really a temp table in the API database that later gets promoted. Not sure how best to reflect that via the diagram but maybe we could add a section explaining what the temp table is, and have it be clickable like the other elements?

This was definitely a tough thing to convey 😅 we already had enough connections to the API database that I wanted to try and have it be separate. I'll add a note for it at the bottom of the diagram, thanks!

Not sure where or how to document this, but I just remembered the provider occurrance tallying we aggregate on a weekly basis into Redis: https://github.com/WordPress/openverse/blob/0891970b5252a00630f3cb971f1121264d55b1af/api/api/utils/tallies.py#L26
It doesn't fit into and current ETL wants (like dead link detection does) but it strikes me that it could be useful to have a place where we've described the data we're generating overall, regardless of whether it's currently part of or intended to be part of an entire ETL pipeline. Provider occurrance rate might be a useful relevancy metric, for example, and it'd be a shame if we forgot about it because we aren't referring to it regularly (that I know of).
Just mentioning in this PR because of it's tangential relevancy to the subject, not because I think it should be included in this documentation. I needed to write it down somewhere and this was the easiest and most sensible place in the immediate.


[Pagination] page error when pageSize changed

change the page size(bigger) on the last page it will change twice.

here is the example
<script>
	import { Pagination } from 'carbon-components-svelte';

	let page = 1;
	let pageSize = 10;
	let pageSizes = [10, 15, 20];
	let totalItems = 35;

	$: console.log(`page: ${page}, pageSize: ${pageSize}`);
</script>

<Pagination bind:page bind:pageSize pageSizes={pageSizes} totalItems={totalItems} />

I send a request to get data when page changed, then I change pagination when I got the new data. This bug may lead to an endless cycle.

As a workaround, can you use the dispatched on:change event to handle pagination.
<Pagination
  on:change={(e) => {
    console.log("e", e.detail); // { page: number }
  }}
/>

This seems similar to the issue outlined in #1491. The root cause is that the update event is set in a reactive statement where the actual desired behavior is that it's fired "once" when the UI select value changes.
Can you use the dispatched on:change event to handle pagination? That's what #1497 was designed to solve.
<Pagination
  on:change={(e) => {
    console.log("e", e.detail); // { page: number }
  }}
/>

thanks to reply
I use on:change, but still error when I changed the page size
I changed page size from 10 to 15

<Pagination pageSizes={[10, 15, 20]}
            on:change={(e) => {console.log('detail: ', e.detail)}}/>

version: 0.72.1

Hi @diantongren, I tried reproducing your issue with this REPL: https://svelte.dev/repl/44c5b1191a5e41adb3614024f9c8a6fe?version=3.55.1
When I change the page size from 10 to 15, I see the correct value in the console.

Feel free to fork my REPL and see if you can make an example that reproduces the issue you've reported.

Hi @diantongren, I tried reproducing your issue with this REPL: https://svelte.dev/repl/44c5b1191a5e41adb3614024f9c8a6fe?version=3.55.1
When I change the page size from 10 to 15, I see the correct value in the console.
Feel free to fork my REPL and see if you can make an example that reproduces the issue you've reported.

I tried it on Mac with edge, safari and arc browser, I got the right value.
But I got the wrong value on Windows with chrome, edge, firefox.

Thanks for uncovering the issue; it appears this is caused by the ordering of bind:this and on:change in Select:
https://github.com/carbon-design-system/carbon-components-svelte/blob/57b6ea68b53368240b07faff80a8a8157fae0786/src/Pagination/Pagination.svelte#L137-L147
I believe placing bind:selectedId as the first <Select> prop should resolve the issue—for both <Select>s used in Pagination.
Here is a demo illustrating the differences: https://svelte.dev/repl/d5e85d47d87b482cbaef7960c1016c1f?version=3.55.1
Docs: https://svelte.dev/docs#template-syntax-element-directives-bind-property

If you're using bind: directives together with on: directives, the order that they're defined in affects the value of the bound variable when the event handler is called.

Please let us know if you have time to contribute a fix, otherwise I'll try getting to it.

Thanks for uncovering the issue; it appears this is caused by the ordering of bind:this and on:change in Select:
https://github.com/carbon-design-system/carbon-components-svelte/blob/57b6ea68b53368240b07faff80a8a8157fae0786/src/Pagination/Pagination.svelte#L137-L147
I believe placing bind:selectedId as the first <Select> prop should resolve the issue—for both <Select>s used in Pagination.
Here is a demo illustrating the differences: https://svelte.dev/repl/d5e85d47d87b482cbaef7960c1016c1f?version=3.55.1
Docs: https://svelte.dev/docs#template-syntax-element-directives-bind-property

If you're using bind: directives together with on: directives, the order that they're defined in affects the value of the bound variable when the event handler is called.

I'm unsure why this behaviour is different on macOS and Windows. I may open a ticket in the Svelte repository and link back here if I'm able to reproduce the behaviour. It may have something to do with the ordering of props in the underlying component and how props are defined by the parent.
Please let us know if you have time to contribute a fix, otherwise I'll try getting to it.

I'm sorry, can't help busy.

Note to self: a more complete solution could be leveraging the native on:change event provided by Select.
This is a reactive event loop issue that may differ depending on the browser or OS, so accessing values as directly as possible, and avoiding reactive values, may be the most precise way to dispatch changed values. Inspired by #1646.
      <Select
        id="bx--pagination-select-{id + 2}"
        class="bx--select__page-number"
        labelText="Page number, of {totalPages} pages"
        inline
        hideLabel
-       on:change="{() => {
+       on:change="{e => {
-         dispatch('change', { page });
+         dispatch('change', { page: e.target.value });
        }}"
        bind:selected="{page}"
      >


Absolute filepath for error and warnings.

On save file, if the file is in project, open new buffer with bad filepath so the buffer open is empty.
Before change:
gcc -c -x ada -gnats src/principale.adb
principale.adb:32:26: missing ";"

quickfix try to open principale.adb but file is in src/ not in current directory.
After change:
gcc -c -x ada -gnats -gnatef src/principale.adb
src/principale.adb:32:26: missing ";"

quickfix open file src/principale.adb.

Merged, thank you.


OCaml 4.06.0 support

Code copied from OCaml 4.06.0
#1608

Thanks! It looks like it's failing on (at least) 4.04 with "Location.deprecated" not being found.

Not sure how to make it work for pre-4.06 versions. It is due to Warnings.Deprecated type change.

cc @hcarty

Using cppo comes to mind...

Note that if you rebase, you'd pick up some commented code from OCaml that I copy/pasted into the repo, which would be useful for making the tests pass on all OCaml versions perhaps. I'm looking to add 4.06 support myself, so if there's anything else I can do to help, please feel free to reach out to me on Discord and I can help get this through.

Is there a reason why you bumped the menhir version?

Just want to use the latest. My bad. I will refrain from adding unrelated commits.

If it works with the latest menhir then it's probably worth reflecting that in the version constraints.

I've made this work with all ocaml compiler versions in this pr and I actually had to eventually bump menhir as you have in this diff. Thank you!


Would you share the trained model of GAIN with BERT-base?

Hi,  I want to reproduce the results of GAIN in your paper. But I can't get corresponding results.  Would you share the trained model of GAIN with BERT-base? Thank you very much!!

I just use the code published by the author of GAIN to train the model (https://github.com/DreamInvoker/GAIN).
Did you get a different result from what reported in our paper?
Best regards,
Quzhe Huang (黄曲哲)
Peking University
E-mail: @.***
On May 15, 2022, at 11:11 AM, XingYing-stack @.***> wrote:
Hi,
—
Reply to this email directly, view it on GitHub https://github.com/AndrewZhe/Revisit-DocRED/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJ5VTVOAUMCWG27PHAK6U3VKBTNBANCNFSM5V6OCXRQ.
You are receiving this because you are subscribed to this thread.


There is a gap with stable diffusion

After fine-tuning it with my own data set, I tested it. In the realistic style, t2i gen images, although the clarity has been improved somewhat, the beauty of the opponents and faces feels far behind than sdxl, let alone sd3. Because the model 0.6B itself has limited capabilities?

The main reason maybe the training dataset. Our goal is not to generate real images, but refined images. If you want to generate more realistic ones, collect your dataset and finetune the model would be fine. I don't think the model size would be a problem to handle realistic style.

The main reason maybe the training dataset. Our goal is not to generate real images, but refined images. If you want to generate more realistic ones, collect your dataset and finetune the model would be fine. I don't think the model size would be a problem to handle realistic style.

Is there any relevant research that shows that larger Pixart models will improve the authenticity and logic of production? When I input some prompts with spatial logic relationships, such as: there is a dog on a box, a cat on the left, and a horse on the right, there will be problems, and it always feels like an oil painting style.

If you have seen the limitation stated in our papar, you will know the spatial, counting is not our best. We tried to enlarge the model and the counting ability will be improved. As for the spatial logic, you need to design specific prompt in the dataset to enhance the ability

If you have seen the limitation stated in our papar, you will know the spatial, counting is not our best. We tried to enlarge the model and the counting ability will be improved. As for the spatial logic, you need to design specific prompt in the dataset to enhance the ability

Thank you for your efficient answer, I think in finetune my data set lost the relevant logic and was too concerned with the longer prompts and therefore lost the situation discussed in the article, I will reconstruct my data again to debug

@kelisiya @lawrence-cj
hi, thanks for your nice work
I just want to ask about your recent training progress @kelisiya


Update LICENCE

Coverage remained the same at 100.0% when pulling 311ee3d229335734340f07e6007f06f1ed63f044 on ots22-patch-1 into 21babee0c0645a548ef53f588bfb4fa4d22341ab on master.

Coverage remained the same at 100.0% when pulling 311ee3d229335734340f07e6007f06f1ed63f044 on ots22-patch-1 into 21babee0c0645a548ef53f588bfb4fa4d22341ab on master.


Faas-cli binary template for linux amd64

Description

faas-cli binary template did not have a amd64 linux branch in the
template.
This was reported under #173
Tested on linux amd64
Signed-off-by: Alistair Hey<EMAIL_ADDRESS>
Motivation and Context

[x] I have raised an issue to propose this change (required)
#173

How Has This Been Tested?

go build
./arkade get faas-cli

Downloading faas-cli
https://github.com/openfaas/faas-cli/releases/download/0.12.8/faas-cli
Tool written to: /tmp/faas-cli

Run the following to copy to install the tool:

chmod +x /tmp/faas-cli
sudo install -m 755 /tmp/faas-cli /usr/local/bin/faas-cli

On amd64 linux
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I've read the CONTRIBUTION guide
[ ] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

[ ] I have tested this on arm, or have added code to prevent deployment

Is there a unit test that could be added for regression testing? Did I miss this scenario in the tests?

I can do the test..


Allow any ember-cli-babel 7 version

Was this breaking something for you? Just curious.

No, it's just strange to fix an important dependency to a specific version. That's why there is ^ and semantic versioning. Also, my yarn.lock file now looks like this:
<EMAIL_ADDRESS>  version "7.1.3"
  resolved "https://registry.yarnpkg.com/ember-cli-babel/-/ember-cli-babel-7.1.3.tgz#a2a7374adb525369a3a205cedd54d8e0c3de3309"
  integrity sha512-wkftzRiPiLTKAhBKphsJEH8gmJIspq04f03DUvoS2/bqrssF04hhQVRquF4EF0ZiNxKI8f4ka/puVOGeBuRWDg==
  dependencies:
    ...

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>  version "7.5.0"
  resolved "https://registry.yarnpkg.com/ember-cli-babel/-/ember-cli-babel-7.5.0.tgz#af654dcef23630391d2efe85aaa3bdf8b6ca17b7"
  integrity sha512-wWXqPPQNRxCtEHvYaLBNiIVgCVCy8YqZ0tM8Dpql1D5nGnPDbaK073sS1vlOYBP7xe5Ab2nXhvQkFwUxFacJ2g==
  dependencies:
    ...

Which I find annoying. :D

Gotcha, yeah I agree it needs to be updated. Thanks for the PR.


move rust-project-goals repository to rust-lang

Given the pending FCP on https://github.com/rust-lang/rfcs/pull/3614, I'd like to move https://github.com/nikomatsakis/rust-project-goals to the rust-lang org. It will need to publish a GH pages setup as well.

I invited @Mark-Simulacrum to the repo

OK, https://github.com/rust-lang/rfcs/pull/3614 was merged.

The repo has been moved and is now managed in the team repo. I don't think there's any more work to be done, so I'll close the issue. :)


singularity: 2.4 -> 2.4.2

Motivation for this change
Upgrades singularity. Ensures local state directory is /var instead of within the nix store. To ensure the /var/singularity/* directories exist, a small module has been added. This fixes the issue identified in #36691.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build singularity

Success on x86_64-linux (full log)
Attempted: singularity
Partial log (click to expand)
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/handlers/archive-cpio.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/handlers/image-http.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/handlers/archive-tar.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/helpers/image.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/helpers/apps/list.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/helpers/help.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/helpers/check.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/libexec/singularity/helpers/inspect.sh: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/bin/run-singularity: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/jrcqiqxr9ballrcyn9xizx2ahxraypl1-singularity-2.4.2/bin/singularity: interpreter directive changed from "/bin/bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"

Success on aarch64-linux (full log)
Attempted: singularity
Partial log (click to expand)
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/deffile-driver-localimage.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/deffile-driver-docker.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/deffile-driver-debootstrap.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/deffile-driver-busybox.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/deffile-driver-arch.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/checks.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/libexec/singularity/bootstrap-scripts/functions: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/bin/run-singularity: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2/bin/singularity: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/l4krx3m1rmlxzcggrahkqmm6dfqk2znc-singularity-2.4.2

Thanks!


Logs from VideoWriter is not affected by set log level, using OPENCV_LOG_LEVEL

Expected behaviour
Setting environment variable OPENCV_LOG_LEVEL=OFF is expected to disable logs from OpenCV.
Actual behaviour
Initializing VideoWriter with fourcc as -1 is producing a list of fourcc.
I have read, setting fourcc -1 is expected to list the available fourcc for the format, but what is a potential way to disable this list of fourcc appearing in console?
Any help in disabling those messages is really helpful. Recommendations on setting this log level or disabling the messages from OpenCV on open forums didn't help.
Steps to reproduce
import cv2
out = cv2.VideoWriter("sample.mp4", -1, 30, (400, 400))

Issue submission checklist

[x] This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)

[x] I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)

[x] The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")

[x] I'm using the latest version of opencv-python

Hi @anitoanto, Could you share environment details in which you are trying to run this program?

Hi @anitoanto, Could you share environment details in which you are trying to run this program?

@l3002 Win 11, Python 3.11.7, opencv-python==<IP_ADDRESS>

@anitoanto I believe what you are seeing may not be logs but the intentional output from the FFMPEG Backend or OpenCV, fourcc=-1 is used for explicitly listing the available codec,
Since this behavior is intentional, the methods for suppressing logs (such as setting OPENCV_LOG_LEVEL) won't be affecting it. The codec list is generated and displayed as standard output from OpenCV's VideoWriter initialization.

@AdityaSinghDevs Even the fourcc is set incorrectly, the error message is displayed not respecting the set log level. Sample code give below.
import cv2
out = cv2.VideoWriter("sample.mp4", 2, 30, (400, 400))


Add a warning system

It would be nice if there is the possibility to warn a user if a feature triggers.
If the user reaches a specific warning level, a additional feature should execute a configurable action on it.
new action: warn
new feature: WarnWatcher

Could use the complainsystem from teamspeak itself. Than we don't need the WarnWatcher


Apply flatfield in mmirs_qrp

mmirs_qrp.py has not been designed to use flat fields.  Add a 'flat' keyword option of either integer values or filenames.  Then the code will combine the flats and flatfield images before A-B image differencing.

Begun to implement flat fielding in 4e39e6b but having some unusual issues with the final stacked products.  Not sure the cause; will debug further later.


fix #455

it split the path from the filename, add prefix "Run"  to the name, and append the path.

 I will redo it.
2017-08-19 22:54 GMT+02:00 Rahul Muttineni<EMAIL_ADDRESS>
@rahulmutt commented on this pull request.
Looks great. Though it might've been easier to implement the "Run"
prefixing via splitFileName in the filepath library, which is already a
dependency so you can use it freely. What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/typelead/eta/pull/463#pullrequestreview-57358361, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAf5ihF3WKZEIETfsi4v7bPooqAV5fZ1ks5sZ0uTgaJpZM4O8bsD
.

--
Alberto.

No worries! You got some experience implementing low-level path handling utilities though :)


About test data

Hey @ZhiyLiu, I saw you added test data at the top level, in this commit
The test data is already in: https://github.com/KitwareMedical/SRepExtension/tree/master/SkeletalRepresentationVisualizer/Testing/test_data.
Do you think that Testing/test_data location is ok? If yes, we shouldn't have duplicate files, and we could rever that commit. I can do it, but not sure if you are working locally in any other update. Could you revert it? Thanks!

You are right. I added it for the sake of the manual I’m writing. I’ll take care of it.

On Aug 14, 2018, at 12:57 PM, Pablo Hernandez-Cerdan<EMAIL_ADDRESS>wrote:
Hey @ZhiyLiu, I saw you added test data at the top level, in this commit
The test data is already in: https://github.com/KitwareMedical/SRepExtension/tree/master/SkeletalRepresentationVisualizer/Testing/test_data.
Do you think that Testing/test_data location is ok? If yes, we shouldn't have duplicate files, and we could rever that commit. I can do it, but not sure if you are working locally in any other update. Could you revert it? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@ZhiyLiu I am closing this issue if that was solved, thanks!
Also, for the future, I would recommend that, instead of pushing directly to master, it is best practice to develop changes in a branch, and then open a Pull Request here to merge that branch in master.
This allow two things, first you can develop features in parallel in different branches, and second, it allows the opportunity to review the changes by others more easily.
For minor things I think is still ok to push directly to master, specially because we don't have any continuous integration to test the changes.


Fix Sesssion InsertRecord bug

Coverage increased (+0.03%) to 53.587% when pulling 82bfd3ea963038f0605454aaf3b06d8d07bc4942 on SessionInsertDebug into a9fd419fbd339591791dde185f856eb117169afc on master.


Call to undefined method Vsch\TranslationManager\Translator::routes()

I'm getting this error:
Call to undefined method Vsch\TranslationManager\Translator::routes()
https://i.gyazo.com/f6884d38d1734eade0585bf0293b24c0.png
My routes.php:
https://i.gyazo.com/dcac53fddd96b26bfa5d0280bb277d33.png
Service providers:
https://i.gyazo.com/c6a6ff09f1424ea0a6055484667c23ca.png
Composer:
https://i.gyazo.com/3ad0d97be47d7c4e8d4288c76ad54e00.png
https://i.gyazo.com/b9b849b8170d69bf77c4c04355f88053.png
I have followed this guide to install
https://github.com/vsch/laravel-translation-manager/wiki/Installation
but even after several tries, I keep getting that same error;
any idea what to do?
Thanks.

@smartsal, you are using Laravel 5.2 the last version which was used with 5.2 is 2.1.4. Can you confirm which LTM version are you installing?

I just changed composer.json to use version "~2.1"
https://i.gyazo.com/2cea41ba700c57afbd994c1b10958119.png
(even completely deleted "vsch" folder from vendors)
and ran composer update. so I believe version !2.1 should be installed now.
still getting the same exact error:
https://i.gyazo.com/2df2f6180f55e79addf756fc661ba00e.png
when I check this file "\vendor\vsch\laravel-translation-manager\src\Translator.php" there is no routes() methos. shouldn't there be a "routes()" method ?

@smartsal, there was a change in routing from 5.1/5.2 to 5.3/5.4. The routes were modified by the LTM package without you needing to add anything to your routes, if memory serves me.
The installation instructions which were in effect when 2.1.4 was updated should be used: https://github.com/vsch/laravel-translation-manager/wiki/Installation/3708e8a61d3c1a20b3c4ffca59830fd10221b7c5

Aaah that fixed it, thanks. Indeed it was already fixed as you said (because I didn't have to modify the routes) but following step 7 in https://github.com/vsch/laravel-translation-manager/wiki/Installation
https://i.gyazo.com/807c3723990d152e7846c4313c46288e.png I modified it and then got confused.
So to conclude, anybody else who is using Laravel 5.2 use this guite for installation https://github.com/vsch/laravel-translation-manager/wiki/Installation/3708e8a61d3c1a20b3c4ffca59830fd10221b7c5 (and use "vsch/laravel-translation-manager": "~2.1" in your composer.json config.
Thanks for taking the time to reply and for making a great translator :)

@smartsal, you are welcome.

One more thing, because I'm pulling my hair out.
I'm in another project now, using Laravel v.5.2 and Laravel Translation Manager v.2.1
I followed the installation that you suggested above, for Laravel 5.2.
When I go to /public/translations I get an Error 404 page so I can't access translations.
When I run php artisan route:list it appears the routes are registered though: https://i.gyazo.com/fb384a732bc130e58961888afeb04e01.png
but \vendors\vsch\laravel-translation-manager\src\Controller\getIndex() is not being used at all - if I put whatever - die('this method is used') - nothing happens and I still get 404 page.
Do you have any idea what could be going wrong?

@smartsal, is there another package modifying the route mapping? For example based on localization information.
Also, is the right path /public/translations or just /translations?

Ahh, found it!
You hit the nail in the head once again. I was using /public/{slug} in my routes to get pages dynamically based on their slug, and that was obviously overriding/modifying it: https://i.gyazo.com/9a99ba723269b7b633959e47e6833e2d.png
I commented them out and now it's working: https://i.gyazo.com/640d2c4d6ba3668fba56e6652ce1bf79.png
I know that's a poor method to handle dynamic pages based on slug, but I have done it a few months ago when I was just starting with Laravel. Will have to improve on that.
Thanks for pointing me in the right direction though.
Have a great day bro!

@smartsal, I used to be a consultant and these types of solutions were often a necessity. Customer emergency fix now with a more robust solution later.
There is the ideal practice of software development and then there is the ugly reality of how those that write the checks and approve work orders see it.


readme: add project badges for release, downloads and license

Adds the following new badges to the readme:

/lgtm


fixed ui of deep-dive in new Navbar

Description of PR

Not maintaining proper padding by card container.
styled card for better UI Look.

Type of PR

[x] Bugfix

Relevant Issues
Fixes #1202
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Before Fix....

After Fix...

Binu can you please send me the source code? Of this stats :(

Binu can you please send me the source code? Of this stats :(

@spraveenofficial source code for this branch is here https://github.com/Binu42/covid19india-react/tree/deepDive or you can use git cmd to clone it   git clone --single-branch --branch deepDive https://github.com/Binu42/covid19india-react.git

@jeremyphilemon @sudevschiz these changes are approved by @s-naveen 2 days ago can you guys, look at it and merge it.

We went ahead and used #1082 for the UI and card design, so closing this. Thanks anyway :)


main.js not available

what can be the cause if main.js  is not available in .\dist?
keep getting 404's on that important file. dotnet ran fine.

never mind, forgot to run webpack

Glad you figured it out! Let me know if there's any other issues you run into.


client.readStatus shouldn't die if there are no indexes on the server…

…. Updated .travis.yml to use Pilosa v0.5.0.

Coverage remained the same at 100.0% when pulling 2f5e1e99d0969df91be5bd21ee4d9ef60edee4e8 on yuce:read-schema into 57e6d1976cb4f3bdcfee48cd0212bca6c38da548 on pilosa:master.


get_total_m2m()

The above mentioned function is not returning correct value please look into it.
I want the figure which is shown under PNL in Web App through API. Please look into it

@neevgujral7  I thought nobody is using this :) , I will see what is the issue

@algo2t long time no see

I think pnl and m2m are different things

how to retrieve pnl then ?
I'll also try by going to data return by get_order_history('order_id)

With the new API, I think this will not work, need to check the implementation again.
It is calculating the m2m based on positions. Better to check the funds view.


Use VS Code highlighting plugin

Expected Behavior
Themes should match their VS Code equivalents (very granular highlighting)
https://github.com/andrewbranch/gatsby-remark-vscode
Actual Behavior
Theme highlighting lacks the necessary tokens to accurately match their original / VS Code themes.

@atomiks would a solution like this, #990, work for you?
I have attempted to add the missing tokens, and if there are any more, I will consider adding them as well. I would also be happy to accept a PR that improves the theme options/configs.
Your proposed solution won't work for us, since Carbon doesn't use Gatsby. Do you know of a similar plugin for Codemirror (the library we use for syntax highlighting)?

I am sure it helps but I don't think it's as complete as the VS Code textmate tokenization.
Would you consider using Gatsby and that plugin (or taking a look at the way the plugin works and implement it standalone) just to take the screenshot? CodeMirror can still be used for typing/pasting code, but its colorization is so limited and you can't match themes correctly.
Actually, the best option would be using the Monaco editor with custom themes like CodeSandbox does in the browser.

Would you consider using Gatsby and that plugin (or taking a look at the way the plugin works and implement it standalone) just to take the screenshot

We would have to rewrite the entire application in order to use Gatsby, which is not an option we will consider.
Using a different editor might be feasible, but I am not sure the wins will be worth the effort.
I'll leave this open for further consideration.


btrfs fixes

lxd/storage/drivers/btrfs: Delete volume after receiving new one
lxd/storage/drivers/btrfs: Check length of snapshots slice

Fixes #10186

I also noticed an error I thought to have fixed which is cannot find parent subvolume. The error occurs only in certain scenarios but it's caused by us making subvolumes read-write before moving them to their final location (readonly subvolumes cannot be moved). When a received subvolume is set read-write, it loses some important information such as the Received UUID and Receive transid. Without this information, btrfs is unable to find the parent which leads to the error I mentioned.
There are two possible fixes for this:

We receive the subvolumes in their final location without having to move them. I already tried that but ran into problems with nested subvolumes. I might just have to try a bit harder :)
We use ioctl to modify the received UUID [0].

This will go into separate PR once I've figured it out.
[0] https://www.spinics.net/lists/linux-btrfs/msg75315.html


[MOCKS] Move to files

Move this to files
Originally posted by @vikmeup in https://github.com/trustwallet/blockatlas/pull/1239#discussion_r510997560

tracked here: https://github.com/trustwallet/blockatlas/issues/1336


Remove is_superuser from resource API

Do not sync is_superuser field on Users.

Documenting for hazard assessment:
https://github.com/ansible/awx/blob/444af2b500517e0cc09f791b7775d4b5b5ed6cf4/awx/api/views/__init__.py#L753-L769
AWX code enforces ALLOW_LOCAL_RESOURCE_MANAGEMENT, and it will allow updates of non-shared fields even if "local management" is not allowed. With this, is_superuser becomes a non-shared field, so it should work as intended.

But... I'm worried about eda-server and galaxy_ng
https://github.com/ansible/eda-server/blob/48b44cf06d4d0498d490810a043b4b3cf44578ac/src/aap_eda/api/serializers/mixins.py#L22-L27
and galaxy_ng
https://github.com/ansible/galaxy_ng/blob/b1c841132c4d3d27c3d0ae5ce5b744a656ef4bab/galaxy_ng/app/access_control/statements/standalone.py#L164-L167

Dependent PRs have merged, https://github.com/ansible/galaxy_ng/pull/2255 and https://github.com/ansible/eda-server/pull/1043


perf: reduced delays and syncs in functional tests to run faster

Issue being fixed or feature implemented
Functional tests take too long time to run.
(PR is recreated from https://github.com/dashpay/dash/pull/6268 because CI is broken)
What was done?

increased robustness feature_llmq_simplepose.py by adding missing bump for mocktime during block generations
removed sleep(1) from each stage of mine_quorum
removed sleep(6) from final stage of mine_cycled_quorum
size of batch for block generation in feature_asset_locks.py and in activate_fork_by_name() increased from 10 blocks to 50 blocks
moved governance's functional tests to "60 seconds+" category because they always the last one to wait if running more than 10 jobs at once
Plus extra refactoring which removes dead and commented code from test_framework.py

How Has This Been Tested?
Locally, the functional tests speed up with these fixes for 15% for overall time and 20% for accumulated time
test/functional/test_runner.py -j20
Before:
ALL                                                | ✓ Passed  | 7860 s (accumulated)
Runtime: 481 s

After:
ALL                                                | ✓ Passed | 6237 s (accumulated)
Runtime: 416 s

CI tsan job speeds up for 5 minutes in absolute time (~5%) and 1000 seconds in accumulated time.
ALL                                                | ✓ Passed  | 23854 s (accumulated)
Runtime: 6249 s

↑ old version vs new version ↓
ALL                                                | ✓ Passed  | 22901 s (accumulated)
Runtime: 5962 s

Breaking Changes
N/A
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone

@PastaPastaPasta see my comment here:
https://github.com/dashpay/dash/pull/6268#issuecomment-2358998909
Re-create PR due to CI stuck on previous PR and unavailable "re-open" button

Soooo do I no longer need to test / compare multiple commits here?

Soooo do I no longer need to test / compare multiple commits here?

If you can test, may you, at least b9961c4cc3b092bcae2ae3fd6b7c85c8d5287aec (with udjin's patch)?

@knst knst force-pushed the functional-tests-delays-p2 branch from b9961c4 to 874ef8c

rebased due to conflict with #6261


Open preferences hotkey does not work

macOS version:    darwin x64 17.7.0
Kap version:      3.0.0-beta.1
Steps to reproduce

Click Kap in the menubar and give it focus
Use the hotkey CMD + , to Open Preferences

Current behavior
Nothing happens
Expected behavior
Preferences page opens
Workaround
Click ... in the overlay and then select "Preferences..."

The shortcut currently only works when the menu is open, but yes, it should work when the cropper view is open too. Also the editor view.


Issues with Space Boundaries on Quest Pro When Running Unity 2022.3.1 Build

Environment

Unity Version: 2022.3.1 or 2022.3.4
Quest Pro (Runtime Version:<IP_ADDRESS>1.669.517337457)

Description
I'm experiencing an issue related to space boundaries on Oculus Quest Pro. Despite having completed the Physical Space setup in the Quest Pro settings, the space boundaries disappear when the content starts, making it impossible to place objects within the space.
Steps to Reproduce

Clone the project from GitHub.
Change the platform to Android.
Select the Discover scene.
Enter the Photon Fusion ID and Oculus/Platform App ID.
Build the APK and run it on Quest Pro.

Expected Behavior
The space boundaries should be visible, and objects should be able to be placed within the content.
Observed Behavior
The space boundaries disappear when the APK is run on the Quest Pro.
Additional Information

When connecting the Quest Pro to Unity Editor using Quest Link and running the scene, the space boundaries are correctly displayed.
The Discover app installed from App Lab worked correctly. The issue occurs after uninstalling the App Lab version and running the APK built from the GitHub source.
Here's a YouTube video for further clarification:

Issue Resolved
I've successfully resolved the issue. Following the guidance from this forum post, I added <uses-permission android:name="com.oculus.permission.USE_SCENE"/> to the AndroidManifest.xml. This triggered a confirmation dialog, and as a result, the Space boundaries became active.
Steps to Resolve

Open AndroidManifest.xml in your project.
Add the line <uses-permission android:name="com.oculus.permission.USE_SCENE"/>.
Rebuild the APK and run it on Quest Pro.

This should prompt a dialog for permission, and once confirmed, the space boundaries should function correctly.

@sakusan393, I faced the same issue as you did, where my built APK app couldn't detect any scene models (walls, floors, tables, etc.). However, when I run the app directly via Unity's play mode (i.e., Quest Link), it works fine. Thanks to your suggestion, the problem is now resolved.
@AlexThiv, I think this issue should be addressed in the document, as people might build on top of this project, and I have seen this problem occur several times (e.g. #8 #9).

We made an update to set the right permission. Thanks for the info and for solving this. We are also having talks internally on how to surface this better to developers.


Using with Rollup to bundle together

I can't figure out how to use react-spring while building a React component library. All the hooks (useTransition) etc work fine until I bundle everything together into a ES module (note that I also use rollup-plugin-terser which seems to maybe be the problem?)
After rolling the library into a ES module, I try to use it in a CRA app by importing the component using react-spring and I get the following error:
react__WEBPACK_IMPORTED_MODULE_0___default(...) is not a function
which traces itself back to

and it seems to come from AnimatedValue

Have you tried disabling Terser to see if the error persists?

Disabling Terser does indeed get rid of the error, but I'd like to use it.

If it works without Terser, then this is a Terser issue, no?

I'm not 100% sure, hence the question here.
Funnily enough, I took the same bundle (with Terser) and inserted it as a JS file in a React Codesandbox and it does not throw the error there.
Codesandbox with minimal bundle: https://codesandbox.io/s/blue-dawn-2g5x2
Now, using the same bundle in a CRA in the same manner throws:
TypeError: react__WEBPACK_IMPORTED_MODULE_0___default(...) is not a function

Then it must be a webpack issue. 😆

I think Codesandbox uses the same configuration as CRA does, yes :-)

cc @gaearon

For now, as a workaround I set react-spring as a peer dependency in my library, instead of bundling it together with components.


Resetting the password does not work as expected

First of all: thanks for the fantastic work!
Problem/Motivation
I forgot my admin password and I'm not able to reset it.
Expected behavior
Following the guide on https://github.com/louislam/uptime-kuma/wiki/Reset-Password-via-CLI should help.
Actual behavior
docker exec -it addon_a0d7b954_uptime-kuma /bin/bash
cd /opt/uptime-kuma
npm run reset-password
gives me
><EMAIL_ADDRESS>reset-password
> node extra/reset-password.js

== Uptime Kuma Reset Password Tool ==
Connecting the database
2023-01-29T11:16:57+01:00 [DB] INFO: Data Dir: ./data/
Error: select * from `user` limit 1 - SQLITE_ERROR: no such table: user
2023-01-29T11:16:57+01:00 [DB] INFO: Closing the database
2023-01-29T11:16:59+01:00 [DB] INFO: SQLite closed
Finished.

There seems to be a non-standard configuration for the database which is not linked to the reset-password tool.
Steps to reproduce
See section above.
Proposed changes
It would be fine if there is a possibility to reset the admin password. This possibility should be described in https://github.com/hassio-addons/addon-uptime-kuma/blob/main/README.md -  If such a possibility is pointed out to me, I would be happy to complete the README.md.
Thanks in advance,
Gregor

+1 can report the same issue with Home Assistant Supervised.

@ggruening here is a workaround for this solution:

Login to the Docker container > docker exec -it <container name, check with docker ps> sh
Delete the empty folder /opt/uptime-kuma/data > rm -r /opt/uptime-kuma/data
Create symlink > ln -s /data /opt/uptime-kuma/data
Et voila, reset your password :)

@lazmo88 perfect. Thanks a lot.
Here are my steps with some additional explanations - I hope this will benefit others in the community:
Find the name of your uptime-kuma container:
docker ps | grep uptime-kuma
Login to the Docker container
docker exec -it addon_[numberFromAbove]_uptime-kuma sh
Move the included but unused folder /opt/uptime-kuma/data out of the way
mv /opt/uptime-kuma/data /opt/uptime-kuma/data_dist
Create a symlink to the correct data folder
ln -s /data /opt/uptime-kuma/data
Reset your password
cd /opt/uptime-kuma
npm run reset password
@frenck - I can prepare this guide for the README in a pull request. Or maybe it's possible to hardcode the symlink into the addon? Then the instructions would be shorter...
In any case: Thank you so much!
Gregor

How can you reset the password if you aren't using Docker?  My Uptime Kuma instance is an add-on within my Home Assistant Blue.

How can you reset the password if you aren't using Docker? My Uptime Kuma instance is an add-on within my Home Assistant Blue.

@amathews84
If you run a Home Assistant instance, you are actually using Docker. Home Assistant is almost entirely based on Docker. Use the webterminal addon and the commands I documented above.
HTH
Gregor

So I got to the last command and when I run
npm run reset password
I get the following:

Could you please advise?

Edit: The command is actually "reset-password" (hyphenated)

@amathews84 Thanks for the hint. I corrected the typo above. You're fine now?
Best regards
Gregor

Yes all good now it worked perfectly.  Thank you.


[Card] Design guidelines

Summary
Add Card design guidelines.
List of notable changes:

added new ComponentLayout to Card docs
added design guidelines

What should reviewers focus on?

👀 Documentation: https://primer-36f18ace18-26139705.drafts.github.io/components/Card

Supporting resources (related issues, external links, etc):

Part of the epic: https://github.com/github/primer/issues/2231
Tracking issue: https://github.com/github/primer/issues/1980

Contributor checklist:

[ ] All new and existing CI checks pass
[ ] Tests prove that the feature works and covers both happy and unhappy paths
[ ] Any drop in coverage, breaking changes or regressions have been documented above
[ ] New visual snapshots have been generated / updated for any UI changes
[ ] All developer debugging and non-functional logging has been removed
[ ] Related issues have been referenced in the PR description

Reviewer checklist:

[ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
[ ] Check that tests prove the feature works and covers both happy and unhappy paths
[ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

 Before  After

@josepmartins here are a couple verbiage suggestions to clarify the usage section:

Keep content simple: I think making a point here about how the nature of the component should dictate it's content could help. Perhaps we could show the range and where the card fit: Pillar < Card < Box

Something like this?

In the stacked section, I'd suggest to make a statement about being cautious when using col-4 x4 in a row as it squeezes the content, and definitely doesn't allow photos. Maybe we should set 4 col as a Don't ?

I'd suggest to reach out to Brand to provide examples of how to use key art/photo - I'm afraid we are only showing the Don't, I can look into that if that feels relevant

@josepmartins here are a couple verbiage suggestions to clarify the usage section:

Keep content simple: I think making a point here about how the nature of the component should dictate it's content could help. Perhaps we could show the range and where the card fit: Pillar < Card < Box

Something like this?

In the stacked section, I'd suggest to make a statement about being cautious when using col-4 x4 in a row as it squeezes the content, and definitely doesn't allow photos. Maybe we should set 4 col as a Don't ?
I'd suggest to reach out to Brand to provide examples of how to use key art/photo - I'm afraid we are only showing the Don't, I can look into that if that feels relevant

Good point! I was thinking of adding an extra section in Usage as soon as we release the Pillar component this week.
Agree on the 4-column not allowing photos, I'll add that 👍 . Not sure about making it a Don't, I've seen some examples working good with short content using 4 columns in the https://github.com/pricing page.
Do we have guidelines on image assets? I took them from https://github.blog/

Good points @josepmartins

I agree, 4 column can work with icons only
I think a good example for a DO section for the image could be the blog, using some blog post could be a nice way to use some actual brand approved image in card for demo like this 👇


Linux release asset is incorrectly suffixed with the .gz extension

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest version
[X] Search the existing issues.

Summary
The latest release asset for linux is incorrectly marked as "tar.gz" even though it is not gzipped. The extension should be just ".tar" to avoid confusion while attempting to extract the tarball.
Steps to reproduce

Download either the DSC-3.0.0-preview.7-x86_64-unknown-linux-gnu.tar.gz or the DSC-3.0.0-preview.7-aarch64-unknown-linux-gnu.tar.gz asset files.
Attempt to extract with tar -xzf
Extract fails because tarball is not gzipped.

Expected behavior
Linux asset files should end with ".tar" and not "tar.gz".

Actual behavior
Linux asset files currently ends in "tar.gz".

Error details
N/A

Environment data
N/A

Version
v3.0.0-preview.7
Visuals
N/A

This will be fixed with next release


[Dev Build]; Console shows trio of errors on opening Godot.

The console spits this out right when the Win64 dev. build is opened and the project list is displayed. The errors themselves don't cause any bugs, but just to make sure they don't become real bugs down the line.
Verified on Windows 7, I hope you would consider it good practice to report things like these.

these errors appear for each projects whose directory have been manually deleted (or renamed) without being Erased into the project-manager first.
into the editor, into the Editor Settings, there is a list of projects. The manually deleted projects are still listed here.

Duplicate of #1267.


Add service configuration dynamically.

Hi Milos, question and thanks for you consideration in advance.
I want to add services dynamically, meaning, instead of defining services in a yml file, I want to load the idp metadata, SP's entity_id and base_url from the database when the app in booting.
I have implemented the EntityDescriptorProviderInterface and I am able to load the XML metadata.
I am having problems appending an entry to the services cofig option. I want it to look like this after a compiler pass or something like that. How would I accomplish this? thanks
....

alpha:
         idp:
               id: custom_entity_descriptor_service
         sp:
            config:
                 entity_id: http://example.com
                 base_url: http://example.com

Hi.
Is work on this ticket still in progress? I'm working on multitenant system which allow different SAML configurations per subdomain. I'm implemented custom idp service which reads IDP settings from database. And now I need to make SP entity ID dynamic based on subdomain, too. Is there a workaround for this?
Thank you.

A new version of lightsaml is available on https://github.com/lightSAML/lightSAML and no new features will be implemented to this old library version. The new lightsaml already supports dynamic party configuration: If you're using lightsaml-core then by composing idp entity store loaded with all metadata you wish, or if you're using lightsaml symfony bridge and sp bundle then by tagging your service that implements EntityDescriptorStoreInterface and will provide IDP parties dynamically with the tag lightsaml.idp_entity_store

@tmilos
Hi Milos,
Question about adding EntityDescriptors dynamically as you mentioned above. Can you share an example to do that because I am new to Symfony and I get error if I don't have entry in config for party.
light_saml_symfony_bridge:
...
party:
idp:
files:
- " ... .xml"
I have added my service in service.yaml
lightsaml.party.idp_entity_descriptor_store:
class: \IdpEDProvider
I haven't get any calls to that class when I was debugging. Please help me.
Thank you

@bMahadevan Sure, I will, but it's for next version in https://github.com/lightSAML/SpBundle. Please open issue there, so it's relevant, and can be shared with others. Thanks

@tmilos
I found the way to do. Just in case any reach this place like me. I share here.
tags:
- { name: 'lightsaml.idp_entity_store' }
and remove remove party from config.yaml
light_saml_symfony_bridge:


schema lambda support

General Question
is it possible to support schema lambdas (class methods) in kcl. we can have a self keyword which can be used to access a readonly instance.

In fact, KCL currently supports defining member functions for schemas and can omit self.
schema Person:
    firstName: str
    lastName: str
    getFullName: () -> str = lambda {
        firstName + " " + lastName
    }

p = Person{
    firstName = "Alice"
    lastName = "White"
}
fullName = p.getFullName()

The output is
p:
  firstName: Alice
  lastName: White
fullName: Alice White

Of course, this is not as complex in configuration languages, just defining it is enough.
schema Person:
    firstName: str
    lastName: str
    fullName: str = firstName + " " + lastName

p = Person{
    firstName = "Alice"
    lastName = "White"
}
fullName = p.fullName

In fact, KCL currently supports defining member functions for schemas and can omit self.
schema Person:
    firstName: str
    lastName: str
    getFullName: () -> str = lambda {
        firstName + " " + lastName
    }

p = Person{
    firstName = "Alice"
    lastName = "White"
}
fullName = p.getFullName()

The output is
p:
  firstName: Alice
  lastName: White
fullName: Alice White

Of course, this is not as complex in configuration languages, just defining it is enough.
schema Person:
    firstName: str
    lastName: str
    fullName: str = firstName + " " + lastName

p = Person{
    firstName = "Alice"
    lastName = "White"
}
fullName = p.fullName

In this case, how do I access the self object?

Is it possible to support
    getFullName = lambda {
        firstName + " " + lastName
    }

as well?

This is possible, but in KCL, schema members without type annotations are treated as private.

this is not very straightforward. can we have something like underscore in python or upper/lower case in golang. i know this already conflict with current version.

Make sense. We are exploring the possibility of simplifying KCL and clarifying its semantics. Perhaps this situation will change in future versions.


Hooked GetProcAddress does not behave as original GetProcAddress

Description
GetProcAddress(nullptr, *) on windows returns pointers from current module, while hooked version returns nullptr.
Repro steps
in following function, xx is nullptr. If I get xx before I try to load renderdoc, it's not nullptr.
static RENDERDOC_API_1_0_2* g_rdoc_api;
static void init_render_doc()
{
    HMODULE lib = LoadLibrary("renderdoc.dll");
	if (!lib) return;

	pRENDERDOC_GetAPI RENDERDOC_GetAPI = (pRENDERDOC_GetAPI)GetProcAddress(lib, "RENDERDOC_GetAPI");
	if (RENDERDOC_GetAPI) {
		RENDERDOC_GetAPI(eRENDERDOC_API_Version_1_0_2, (void **)&g_rdoc_api);
		g_rdoc_api->MaskOverlayBits(~RENDERDOC_OverlayBits::eRENDERDOC_Overlay_Enabled, 0);
	}

    auto xx = GetProcAddress(nullptr, "foo_test");
    xx = xx; // xx is nullptr here
}

extern "C" __declspec(dllexport) void foo_test() {}

https://github.com/baldurk/renderdoc/blob/7206a0cd2550fecf34335a8b01048dfbd54a23f9/renderdoc/os/win32/win32_hook.cpp#L706
Environment

RenderDoc build: latest commit - f82cce065d687ab69df6b2272a52c3e88c3a70bc
Windows 10
OpenGL, but happens before any initialization

If I replace https://github.com/baldurk/renderdoc/blob/7206a0cd2550fecf34335a8b01048dfbd54a23f9/renderdoc/os/win32/win32_hook.cpp#L706-L707
  if(mod == NULL || func == NULL)
    return GetProcAddress(mod, func);

everything works fine

Thanks for catching this! I hadn't appreciated that NULL was a special handle which is valid and points to the executable. That commit should fix it, the same way as you've identified.


Include sender in events

Good practice to include sender in events. Also makes it easier to write applications that support multiple Nuimo-devices.

Thanks a lot for updating your PR! It looks very good and is ready to merge – Can you do us a favor and also update the README.md file as part of this PR?

I already did?

I overlooked and took it for "real" code ;) Thanks!


Bind mounts able to be created after disabling; volumes do not appear for user

After disabling bind mounts for non-administrators (under Settings), a non-admin user is still able to create bind mounts via the creation of a stack.  Separately, neither bind mounts nor volumes appear in the user's Volume list.  Additionally, the container does not appear in the user's Containers list.  Both the container and the volume appear in the admin's Container and Volume list, respectively.  The creation of the bind mount was verified by logging into the container via the admin's UI.
Tested on Portainer 1.19.2.  As a note, userns-remap is enabled in the docker daemon.
Absent a creation error - given that bind mounts were disabled for users, I would have expected there to be an error - I would expect that the volumes would be listed in the user's Volume list and the container listed in the user's Container list.
The following is the stack created by the user.
version: "2"
services:
ubuntu:
image: ubuntu
command: tail -f /dev/null
volumes:
- /home/ubuntu:/tmp/home
- data/tmp/test
The first is the bind mount.  The second is the volume.
docker info:
Containers: 2
Running: 1
Paused: 0
Stopped: 1
Images: 2
Server Version: 18.06.1-ce
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local local-persist
Network: bridge host macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 468a545b9edcd5932818eb9de8e72413e616e86e
runc version: 69663f0bd4b60df09991c08812a60108003fa340
init version: fec3683
Security Options:
apparmor
seccomp
Profile: default
Kernel Version: 4.15.0-39-generic
Operating System: Ubuntu 18.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.66GiB
Name: node-1
ID: CKVO:D726:BS4K:A24A:J3CY:ZYDS:VWFA:SQRT:QGLY:VJGJ:ZROU:OOG3
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: true
WARNING: No swap limit support

We dont block bind mounts from stacks as we dont inspect the stack file. Other points, we will investigate
Rgds,
Neil Cresswell
On 30/11/2018, at 10:18 AM, alphaDev23 <notifications<EMAIL_ADDRESS>wrote:
After disabling bind mounts for non-administrators (under Settings), a non-admin user is still able to create bind mounts via the creation of a stack. Separately, neither bind mounts nor volumes appear in the user's Volume list. Additionally, the container does not appear in the user's Containers list. Both the container and the volume appear in the admin's Container and Volume list, respectively. The creation of the bind mount was verified by logging into the container via the admin's UI.
Tested on Portainer 1.19.2. As a note, userns-remap is enabled in the docker daemon.
Absent a creation error - given that bind mounts were disabled for users, I would have expected there to be an error - I would expect that the volumes would be listed in the user's Volume list and the container listed in the user's Container list.
The following is the stack created by the user.
version: "2"
services:
ubuntu:
image: ubuntu
command: tail -f /dev/null
volumes:

/home/ubuntu:/tmp/home
data/tmp/test

The first is the bind mount. The second is the volume.
docker info:
Containers: 2
Running: 1
Paused: 0
Stopped: 1
Images: 2
Server Version: 18.06.1-ce
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local local-persist
Network: bridge host macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 468a545b9edcd5932818eb9de8e72413e616e86e
runc version: 69663f0bd4b60df09991c08812a60108003fa340
init version: fec3683
Security Options:
apparmor
seccomp
Profile: default
Kernel Version: 4.15.0-39-generic
Operating System: Ubuntu 18.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.66GiB
Name: node-1
ID: CKVO:D726:BS4K:A24A:J3CY:ZYDS:VWFA:SQRT:QGLY:VJGJ:ZROU:OOG3
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/https://urldefense.proofpoint.com/v2/url?u=https-3A__index.docker.io_v1_&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=89306PwmHsMkb5ZfdIE5DQdF5zt47aGzJqHf_XuC0Io&s=qmquO0QTAsRBTjP8hT0RNPKyl2mH182tmFH-C1Cf2rA&e=
Labels:
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: true
WARNING: No swap limit support
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_2506&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=89306PwmHsMkb5ZfdIE5DQdF5zt47aGzJqHf_XuC0Io&s=aqSIzR19xz4AhUzNRIYAu--ToaNfVzOCT9xBcPViBbU&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrldR7ece-2DScERQIdx8Hqb-2DzKn7-5Frpks5u0E8vgaJpZM4Y6iEq&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=89306PwmHsMkb5ZfdIE5DQdF5zt47aGzJqHf_XuC0Io&s=TLU8QveQZoGoJWFjLBwNMneIpZ2tiyZH9uhsA7koEa4&e=.

@ncresswell, your comment "We dont block bind mounts from stacks as we dont inspect the stack file." is a bug,  An admin expects that if the "Disable bind mounts for non-administrators" is set then users will not be able work around the issue by simple creating a stack with a bind mount.   Under the current implementation, all a user has to do is create a bind mount to "/" and they can modify any aspect of the underlying host by accessing the container via the console and modifying files on that volume.
The settings is important though because it would be great to be able to allow non-admin users to create containers and/or stacks without concern of the non-admin user having full access to the docker host.
When will this issue be fixed?  Without a fix, Portainer is not viable for the above use case (which is what the feature is intended to be used for).

Closed via https://github.com/portainer/portainer/pull/3232