Layout cleanup

Overview
This PR does a few things in service of cleanup and consistency:

Cleans up the Header component. b407625 and d6ca52d
Moves the overall layout to flex-box all the way down 249510b

Header changes

Moves to a directory based approach for the component
Creates styles.ts to handle the quantity of mergeStyles generated classes
Moves HeaderLink into src/components/Header/components to co-locate the components that are only used within the Header component (this is a pretty opinionated move and the component could stay in src/components or even next to the index file as src/components/Header/HeaderLink.tsx)
Removes all inline styles and implements the mostly same files using mergeStyles to generate dynamic CSS classes.
Makes a slight adjustment to yml import to please the TypeScript compiler
Converts any touched files to TS
Adjusts styles so when wrapping occurs, all header content is aligned to the same left axis

Layout changes
The goal of these changes was to remove the need to have short and long layout variations along with the hardcoding or detection of header and footer sizes. For pages that might be shorter than the window height, the footer remains at the bottom of the window. When those pages grow, the footer appears at the bottom of the content as expected. For Fixed height layouts (such as the Explorer), we lean on flex-box to allow the content to grow to fill the screen. To summarize, this commit:

removes all isShort usage
removes all hardcoded sizes
adjusts the structure of the DOM and top-level CSS to allow for flex-box element stacking

Testing

Ensure the header looks correct under various screen size scenarios
Ensure that the all other pages look correct in their overall layout, especially the Explorer.

@mmcfarland I don't think I can assign. But this is ready for review.

Thanks, @alkamin this looks great. In testing, I found one issue with the new layout, and it's a bit tricky. If you look at the Explorer on this branch, the sidebar results panel does not get a fixed height equal to the screen height when the number of results exceeds the height. Rather than scroll the overflow, it just pushes the bottom of the page all the way down. You should be able to recreate it with this localhost url:
http://localhost:3000/explore?c=-6.1494%2C38.8686&z=6.07&r=Elevation+(terrain)&d=cop-dem-glo-90&m=Most+recent
and compare it to the existing behavior here:
https://planetarycomputer-staging.microsoft.com/explore?c=-6.1494%2C38.8686&z=6.07&r=Elevation+(terrain)&d=cop-dem-glo-90&m=Most+recent
I say it's tricky, because @jfrankl and I had some trouble initially getting that behavior to work. What ended up being key was setting a (calculated) fixed height on the main element, plus some height and overflow settings on various children. The working solution basically came down to this commit https://github.com/microsoft/PlanetaryComputerDataCatalog/commit/b90ac0e119e5402ff4a8c61e28ef475c64d16054
It would be ideal if we didn't have to use any calculated heights, but in the absence of an alternative, it might be expedient to continue to use it in this case. Can you take a look at adapting this PR to allow for a scrollable side panel there?

@alkamin Also, I'm not sure why PRs from forks aren't using the ephemeral staging deployments, I'll look into getting that enabled so the changes can be reviewed and tested more easily.

I don't want this PR to linger with the abnormal schedule around this time of year so I am going to revert the layout commit and attempt to get the scrolling working within a separate PR.

Good question. If you like the multi-level functionality then mergeStyleSets should provide something pretty close to that (though I find the usage a bit less clear than just using mergeStyles). I tried to stick with the guidelines outlined here: https://github.com/microsoft/fluentui/blob/master/packages/merge-styles/README.md and didn't end up experimenting too much with the styles object approach.
The types seem for both seem to lean on IStyle so I wouldn't expect any differences in that realm. IStyle is pretty permissive (it's a union of IRawStyle style among other things and hasn't helped me avoid typos.


Motor identifiaction

Gather motor-encoder characteristics for various motor power settings.

Gathered data in commit: 9c18ef3
Now need to determine transfer function based on these data. There will be separate TF for left and right motor as they behave diffferently due to inaccuracy of mechanical parts.

Gathered transfer functions.
For left motor: 1.682 / (0.2742 s + 1)
For right motor: 1.59 / (0.2222 s + 1)
PID settings for these models:
P = 2.61, I = 11.58, D = 0
The same PID will be used for both motors

Made adjustments to model. New model is:
1.4 / (0.215 s + 1)
New PID values for linear velocity are:
P = 6.6869
I  = 0.0
D = 0.03639

Tuned pid for linear velocity, but glued wheels have other characteristics so all process should be repeated.


[Feature Request] show-installed-packages recursion

It is a common problem to troubleshoot dependencies issues (FSharp.Core looking at you). show-installed-packages works on a per project basis, but it does not provide the option to recurse to sub folders, to pick up transitive projects. It would be a good feature if we could provide an option to allow show-installed-packages to recurse a specified folder.

for most of paket using only the project name is enough for the feature to work however for this one
λ» paket show-installed-packages project FSharp.Formatting.Common
Paket version 4.1.3
1 second - ready.
``

λ» paket show-installed-packages project .\src\FSharp.Formatting.Common\FSharp.Formatting.Common.fsproj
Paket version 4.1.3
Main FSharp.Compiler.Service - 12.0.2
Main FSharp.Core - 4.1.2
1 second - ready.
so this should be addressed too


Change wording on profile based on whether they have CORE deposits

User service requested on 2023-05-03
From a user: "I have had a profile set up on HC for a few weeks now and am very satisfied with it overall. I would only have one small suggestion for improvement regarding the consistency in the profile layout: If I decide to hide the "Work Shared in CORE" section on my profile, it would be nice if the following field would only say "Publications" instead of "Other Publications". Would it be possible to set it up that way?"
Is this something we are interested in updating?

Holding off on this until the profiles redesign project. Will take it into consideration in the future.


Forking of themes; request for maintainers

As mentioned in the other issue, I'd like to fork the themes into its own repository so that it can be maintained separately.  I will keep a couple popular themes in the main repository, but the rest will be moved outside.
I'd like to request volunteers to become the maintainers of this new repository.
Unlike the requirements of the core project, you don't need to know how to code or triage issues, however you will need to be able to:

Hit the green merge button.
Ensure that screenshots are provided, or to make them if missing.

The second point is particular important to make it easy for users to decide which theme they want to use.  There are currently 34 themes!
Please let me know if you're interested by commenting here.  Thanks.

i've held off on merging some theme related PRs because of this.  @chrisbra @mhartington unless there are objections i'm going to create the fork in the next couple days.
the only downside i can see is that in practice it'll just force everyone to add a second entry into their vimrc to pull down the new repository.

:+1:

I think the extra theme should be created like source of unite or neocomplete,It will be easy for user to creat his own theme.also it will be easy to merged into core theme repo.

@wsdjeg I think the current way themes are handled actually helps with this.
For me, my custom theme for my vim colorscheme was simple to add in autoload/airline/themes/ dir.
https://github.com/mhartington/oceanic-next/tree/master/autoload/airline/themes
This kind of structure should be easy to manage with various plugin managers

got it ,thanks a lot.will you create a new repo named vim-airline/vim-airline-theme or somethin else?

How do I stop vim from showing me the deprecation warning on startup?

Convenient link for future explorers: https://github.com/vim-airline/vim-airline-themes


Panasonic cloud could not be integrated in HA

Denne fejl stammer fra en brugerdefineret integration.
Logger: homeassistant.config_entries
Source: custom_components/panasonic_cc/pcomfortcloud/session.py:153
Integration: Panasonic Comfort Cloud (documentation)
First occurred: 19.53.39 (1 occurrences)
Last logged: 19.53.39
Error setting up entry for panasonic_cc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 353, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/panasonic_cc/init.py", line 79, in async_setup_entry
devices = await hass.async_add_executor_job(api.get_devices)
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 193, in get_devices
self.login()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 103, in login
self._create_token()
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 153, in _create_token
raise ResponseError(response.status_code, response.text)
custom_components.panasonic_cc.pcomfortcloud.session.ResponseError: Invalid response, status code: 403 - Data:
403 Forbidden

403 Forbidden

I have tried to solve it with the workaround, but it dos not help.

Apply the patched version https://github.com/sockless-coding/panasonic_cc/issues/76#issuecomment-1183476134

Fixed in release v1.0.32


Default extension shortcut conflicts with existing Firefox default shortcut

Setup
Browser: Firefox 110.0
Editor: nvim v0.7.2
Description
The default GhostText shortcut (Ctrl+Shift+H) for Firefox on Linux conflicts with an existing Firefox shortcut (open Library). As such it has to be remapped out of the box for the extension to work. Would it make more sense to pick a different shortcut so that the extension works with its default settings?

PR welcome to remove the default shortcut. Please ensure that it actually works though, it should still appear in the options so that users can set a shortcut


refine: refine interface of ManifestWriter

This PR refine the write interface of ManifestWriter according to ManifestWriter from pyiceberg. It add 3 interface add, delete, existing which will rewrite some metadata of manifest entry, e.g. snapshot id, sequence number, file sequence number.
These refined interfaces are benefit for MergeAppend.( I' m working on it now.

cc @liurenjie1024 @Xuanwo


[:sparkles:] Feature: make a command to go to next like the previus one

make a command to go to next file, like the previous one

What would you expect the "go to next" to do? I feel like the "go to previous" one is already kind of doing both. It doesn't work exactly like ctrl+o in vim, instead it will just go back and fourth between editors when calling it multiple times.

+1 for this feature.—missing next file, just to cycle in a specific direction. But you see it’s not constant, remapped your extension if I use vscode-vim:
if exists('g:vscode')
	nnoremap <leader>hl <Cmd>lua require('vscode-neovim').action('vscode-harpoon.gotoPreviousGlobalHarpoonEditor')<CR>
else:
	nnoremap <leader>ha :lua require("harpoon.ui").nav_next()<cr>
	nnoremap <leader>hl :lua require("harpoon.ui").nav_prev()<cr>
endif

so why not implement it consistent?

As far as i can tell, the harpoon nav_next and nav_prev functions do a compleatly different thing than this gotoPreviousHarpoonEditor does. The vscode-harpoon one goes back and fourth between two files, whereas the harpoon ones just nav throught the list of items.
I don't mind the feature, but it doesn't really have anything to do with the current gotoPreviousHarpoonEditor function

i understand but it will be a nice feature to add, so this way we have the next and previous functionality


Selective pattern embedding

It would be desirable to allow users to only embed specific hyphenation patterns via conditional compilation.

Presently marking this as "overly tedious to write down given current Cargo capabilities".


Resolve PR #2 conflicts

This seems to have pretty much killed the build for Android users.
It slows it down so the whole IDE no longer responds. For that reason I am not doing to merge this branch at this time.


Tooltip background doesn't scale with respect to text.

Describe the bug
If you attach the string dynamically to tooltip text. the background doesn't scale.
I tried even with static prefab, although the scripts for scaling is written but doesn't work as expected.
To Reproduce
https://github.com/Microsoft/MixedRealityToolkit-Unity/blob/master/Assets/HoloToolkit-Examples/UX/Readme/README_TooltipExample.md
Steps to reproduce the behavior:

Go to TooltipExample scene set any tooltip text dynamically or statically load the screen text goes out of the background.

Expected behavior
Text should fit in the background, as I observed in "ToolTip.cs" , "RefreshLocalContent()"
resizes the background based on the content size but it doesn't work.
Unity Editor Version
Unity 2018.2.5
Mixed Reality Toolkit Release Version
MRTK version(s) 2<IP_ADDRESS>
Additional context
Add any other context about the problem here.

Hi @rohitdesaidev,
Do you know if there is a quick solution for this problem until a new release solves it?
Regards,
Cristian.

@Cris21395
I Didn't find any solution yet as we have to modify MRTK scripts.
But rather than using dynamic sizing I prefer a static box size for every prefab.
Hope they solve this in coming release.
@StephenHodgson can please provide any solutions if you came across ?
Thanks,
Rohit Desai

HTK requires unity 2017.4
Closing older HTK issue as we are no longer actively working on HTK.
Please upgrade to MRTK V2 for the latest fixes.


usb

Is your feature request related to a problem? Please describe
No response
Describe the solution you'd like
please add Direct usb access
Describe alternatives you've considered
No response
Please specify the version of Windows Subsystem for Android
2209.40000.26.0

This issue is a duplicate of: https://github.com/microsoft/WSA/issues/103


Implement tobytes for CuPy arrays

Makes a simple implementation of tobytes for CuPy arrays, which converts the data back into a NumPy array and let's NumPy do the heavy lifting.

Thank you for the PR!
Jenkins, test this please.

Jenkins CI test (for commit c369dbbe9082f870030b592b993b42891a77f7af, target branch master) failed with status FAILURE.

Would it be possible to nudge Jenkins again? Think it is reporting for an old commit here.

Jenkins, test this please.

Thanks for the review! 😀


Support windows cmd cli

I have a lot of old windows pc's that I use as htpc's, so I wrote a quick script that uses putty to ssh to my Linux box, it execs into the beets container, and starts the audible plug-in. It works great and is super convenient since that .bat file lives on my nas I can double click it from any pc and instantly be tagging books.
The interface gets wonky though. Colors and special characters don't display right.  Is there any way to normalize the output so it can be easier to tag from my laptop?
I'll have to try powershell, or maybe another type of shell to see if anything else works a bit better, just wondering what is possible.
Here is a sample output:

See beetbox/beets#2766. I'm on Windows as well, and I believe using Windows Terminal should address this, let me know if it doesn't.
Closing because this is a known Beets issue, and out of scope for the plugin.

That's exactly the issue, thanks!
In case anyone else happens to stumble across this here's how I was able to fix in Windows 10 cmd.exe using the solution found here https://superuser.com/questions/413073/windows-console-with-ansi-colors-handling:

Open Powershell with admin rights (Right click Run as Administrator)
Set-ItemProperty HKCU:\Console VirtualTerminalLevel -Type DWORD 1


[4.2.2] Compiler crash with null pointer in  tsc.js: isWeakType resolved.callSignatures is null

Bug Report

🔎 Search Terms

resolved.callSignatures
🕗 Version & Regression Information

This is a crash
This changed between versions 4.1.0 and 4.2.2

⏯ Playground Link

Playground link with relevant code
💻 Code

// We can quickly address your report if:
//  - The code sample is short. Nearly all TypeScript bugs can be demonstrated in 20-30 lines of code!
//  - It doesn't use external libraries. These are often issues with the type definitions rather than TypeScript bugs.
//  - The incorrectness of the behavior is readily apparent from reading the sample.
// Reports are slower to investigate if:
//  - We have to pare too much extraneous code.
//  - We have to clone a large repo and validate that the problem isn't elsewhere.
//  - The sample is confusing or doesn't clearly demonstrate what's wrong.

source code:
function isWeakType(type) {
    if (type.flags & 524288) {
        var resolved = resolveStructuredTypeMembers(type);
        return resolved.callSignatures.length === 0 && resolved.constructSignatures.length === 0 &&
            !resolved.stringIndexInfo && !resolved.numberIndexInfo &&
            resolved.properties.length > 0 &&
            ts.every(resolved.properties, function (p) { return !!(p.flags & 16777216); });
    }
    if (type.flags & 2097152) {
        return ts.every(type.types, isWeakType);
    }
    return false;
}

error log:
TypeError: Cannot read property 'length' of undefined
    at isWeakType (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:50733:48)
    at isRelatedTo (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:49252:58)
    at checkTypeRelatedTo (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:48974:26)
    at isTypeRelatedTo (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:48938:24)
    at removeSubtypes (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:46041:33)
    at getUnionType (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:46131:26)
    at getWidenedTypeForAssignmentDeclaration (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:42011:28)
    at getTypeOfFuncClassEnumModuleWorker (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:42497:34)
    at getTypeOfFuncClassEnumModule (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:42476:51)
    at getTypeOfSymbol (/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/typescript/lib/tsc.js:42579:24)

value of the resolved variable at crash time:
Type {
  flags: 524288,
  id: 5978,
  objectFlags: 16,
  symbol: <ref *1> Symbol {
    flags: 33554960,
    escapedName: '_extends',
    declarations: [ [Node] ],
    valueDeclaration: Node {
      pos: 0,
      end: 479,
      kind: 251,
      id: 5476,
      flags: 131072,
      modifierFlagsCache: 536870912,
      transformFlags: 1052704,
      parent: [Node],
      original: undefined,
      decorators: undefined,
      modifiers: undefined,
      symbol: [Symbol],
      localSymbol: undefined,
      locals: Map(0) {},
      nextContainer: [Node],
      name: [Identifier],
      typeParameters: undefined,
      parameters: [Array],
      type: undefined,
      body: [Node],
      asteriskToken: undefined,
      returnFlowNode: [Object],
      jsDocCache: []
    },
    id: undefined,
    mergeId: undefined,
    parent: undefined,
    checkFlags: 0,
    exports: Map(2) { 'default' => [Symbol], '___esModule' => [Symbol] },
    cjsExportMerged: [Circular *1],
    type: Type {
      flags: 524288,
      id: 5976,
      objectFlags: 16,
      symbol: [Circular *1],
      members: [Map],
      properties: undefined,
      callSignatures: undefined,
      constructSignatures: undefined,
      stringIndexInfo: undefined,
      numberIndexInfo: undefined
    },
    resolvedExports: Map(2) { 'default' => [Symbol], '___esModule' => [Symbol] }
  },
  members: Map(2) {
    'default' => Symbol {
      flags: 2097152,
      escapedName: 'default',
      declarations: [Array],
      valueDeclaration: undefined,
      id: 6422,
      mergeId: undefined,
      parent: [Symbol]
    },
    '___esModule' => Symbol {
      flags: 1048580,
      escapedName: '___esModule',
      declarations: [Array],
      valueDeclaration: [Node],
      id: undefined,
      mergeId: undefined,
      parent: [Symbol]
    }
  },
  properties: [
    Symbol {
      flags: 2097152,
      escapedName: 'default',
      declarations: [Array],
      valueDeclaration: undefined,
      id: 6422,
      mergeId: undefined,
      parent: [Symbol]
    },
    Symbol {
      flags: 1048580,
      escapedName: '___esModule',
      declarations: [Array],
      valueDeclaration: [Node],
      id: undefined,
      mergeId: undefined,
      parent: [Symbol]
    }
  ],
  callSignatures: undefined,
  constructSignatures: undefined,
  stringIndexInfo: undefined,
  numberIndexInfo: undefined
}

value of resolved.symbol.declarations[0]:
seems to came from @babel/runtime (in v7.13.7 on my node_modules)
<ref *1> Node {
  pos: 0,
  end: 479,
  kind: 251,
  id: 5476,
  flags: 131072,
  modifierFlagsCache: 536870912,
  transformFlags: 1052704,
  parent: <ref *2> Node {
    pos: 0,
    end: 586,
    kind: 297,
    id: 5471,
    flags: 131072,
    modifierFlagsCache: 536870912,
    transformFlags: 32,
    parent: undefined,
    original: undefined,
    statements: [
      [Circular *1],
      [Node],
      [Node],
      pos: 0,
      end: 585,
      hasTrailingComma: false,
      transformFlags: 32
    ],
    endOfFileToken: Token {
      pos: 585,
      end: 586,
      kind: 1,
      id: 0,
      flags: 131072,
      transformFlags: 0,
      parent: [Circular *2]
    },
    fileName<EMAIL_ADDRESS>    text: 'function _extends() {\n' +
      '  module.exports = _extends = Object.assign || function (target) {\n' +
      '    for (var i = 1; i < arguments.length; i++) {\n' +
      '      var source = arguments[i];\n' +
      '\n' +
      '      for (var key in source) {\n' +
      '        if (Object.prototype.hasOwnProperty.call(source, key)) {\n' +
      '          target[key] = source[key];\n' +
      '        }\n' +
      '      }\n' +
      '    }\n' +
      '\n' +
      '    return target;\n' +
      '  };\n' +
      '\n' +
      '  module.exports["default"] = module.exports, module.exports.__esModule = true;\n' +
      '  return _extends.apply(this, arguments);\n' +
      '}\n' +
      '\n' +
      'module.exports = _extends;\n' +
      'module.exports["default"] = module.exports, module.exports.__esModule = true;\n',
    languageVersion: 99,
    languageVariant: 1,
    scriptKind: 1,
    isDeclarationFile: false,
    hasNoDefaultLib: false,
    externalModuleIndicator: undefined,
    bindDiagnostics: [],
    bindSuggestionDiagnostics: undefined,
    pragmas: Map(0) {},
    checkJsDirective: undefined,
    referencedFiles: [],
    typeReferenceDirectives: [],
    libReferenceDirectives: [],
    amdDependencies: [],
    commentDirectives: undefined,
    nodeCount: 129,
    identifierCount: 48,
    identifiers: Map(17) {
      '_extends' => '_extends',
      'module' => 'module',
      'exports' => 'exports',
      'Object' => 'Object',
      'assign' => 'assign',
      'target' => 'target',
      'i' => 'i',
      'arguments' => 'arguments',
      'length' => 'length',
      'source' => 'source',
      'key' => 'key',
      'prototype' => 'prototype',
      'hasOwnProperty' => 'hasOwnProperty',
      'call' => 'call',
      'default' => 'default',
      '__esModule' => '__esModule',
      'apply' => 'apply'
    },
    parseDiagnostics: [],
    path<EMAIL_ADDRESS>    resolvedPath<EMAIL_ADDRESS>    originalFileName<EMAIL_ADDRESS>    imports: [],
    moduleAugmentations: [],
    ambientModuleNames: [],
    resolvedModules: undefined,
    additionalSyntacticDiagnostics: [],
    locals: Map(2) { '_extends' => [Symbol], 'module' => [Symbol] },
    nextContainer: [Circular *1],
    commonJsModuleIndicator: Node {
      pos: 21,
      end: 353,
      kind: 216,
      id: 0,
      flags: 131072,
      modifierFlagsCache: 536870912,
      transformFlags: 32,
      parent: [Node],
      original: undefined,
      left: [Node],
      operatorToken: [Token],
      right: [Node],
      symbol: [Symbol]
    },
    symbol: Symbol {
      flags: 512,
      escapedName: '"/Users/jeromeh/Workspaces/experience-core/digitalexp-ui-base/node_modules/@babel/runtime/helpers/extends/index"',
      declarations: [Array],
      valueDeclaration: [Circular *2],
      id: undefined,
      mergeId: undefined,
      parent: undefined,
      exports: [Map]
    },
    symbolCount: 12,
    classifiableNames: Set(2) { 'export=', 'default' },
    jsDocCache: []
  },
  original: undefined,
  decorators: undefined,
  modifiers: undefined,
  symbol: Symbol {
    flags: 16,
    escapedName: '_extends',
    declarations: [ [Circular *1] ],
    valueDeclaration: [Circular *1],
    id: 6415,
    mergeId: 1689,
    parent: undefined,
    isReferenced: 1949695
  },
  localSymbol: undefined,
  locals: Map(0) {},
  nextContainer: <ref *3> Node {
    pos: 68,
    end: 353,
    kind: 208,
    id: 5472,
    flags: 131072,
    modifierFlagsCache: 536875008,
    transformFlags: 1048608,
    parent: Node {
      pos: 51,
      end: 353,
      kind: 216,
      id: 0,
      flags: 131072,
      modifierFlagsCache: 0,
      transformFlags: 32,
      parent: [Node],
      original: undefined,
      left: [Node],
      operatorToken: [Token],
      right: [Circular *3]
    },
    original: undefined,
    decorators: undefined,
    modifiers: undefined,
    symbol: Symbol {
      flags: 16,
      escapedName: '__function',
      declarations: [Array],
      valueDeclaration: [Circular *3],
      id: 6416,
      mergeId: undefined,
      parent: undefined
    },
    localSymbol: undefined,
    locals: Map(4) {
      'target' => [Symbol],
      'i' => [Symbol],
      'source' => [Symbol],
      'key' => [Symbol]
    },
    nextContainer: undefined,
    name: undefined,
    typeParameters: undefined,
    parameters: [
      [Node],
      pos: 79,
      end: 85,
      hasTrailingComma: false,
      transformFlags: 0
    ],
    type: undefined,
    body: Node {
      pos: 86,
      end: 353,
      kind: 230,
      id: 0,
      flags: 131072,
      modifierFlagsCache: 0,
      transformFlags: 1048608,
      parent: [Circular *3],
      original: undefined,
      statements: [Array],
      multiLine: true
    },
    asteriskToken: undefined,
    flowNode: { flags: 6208, antecedent: [Object], node: [Node] },
    returnFlowNode: { flags: 6152, antecedents: [Array], id: 81 },
    jsDocCache: []
  },
  name: Identifier {
    pos: 8,
    end: 17,
    kind: 78,
    id: 0,
    flags: 131072,
    transformFlags: 0,
    parent: [Circular *1],
    original: undefined,
    flowNode: { flags: 6146 },
    originalKeywordKind: undefined,
    escapedText: '_extends'
  },
  typeParameters: undefined,
  parameters: [ pos: 18, end: 18, hasTrailingComma: false, transformFlags: 0 ],
  type: undefined,
  body: Node {
    pos: 19,
    end: 479,
    kind: 230,
    id: 0,
    flags: 131072,
    modifierFlagsCache: 0,
    transformFlags: 1052704,
    parent: [Circular *1],
    original: undefined,
    statements: [
      [Node],
      [Node],
      [Node],
      pos: 21,
      end: 477,
      hasTrailingComma: false,
      transformFlags: 1052704
    ],
    multiLine: true
  },
  asteriskToken: undefined,
  returnFlowNode: {
    flags: 2064,
    antecedent: { flags: 2304, antecedent: [Object], node: [Node] },
    node: Node {
      pos: 401,
      end: 427,
      kind: 201,
      id: 0,
      flags: 131072,
      modifierFlagsCache: 536870912,
      transformFlags: 0,
      parent: [Node],
      original: undefined,
      expression: [Node],
      name: [Identifier],
      symbol: [Symbol],
      flowNode: [Object]
    }
  },
  jsDocCache: []
}

🙁 Actual behavior

Crash
🙂 Expected behavior

Don't crash

@paztis the “source code” section of the bug report is supposed to be the code that makes TypeScript crash, not the TypeScript code that crashes. I might be able to reconstruct something from the debug dumps you provided, but it would be really helpful if you could describe how to trigger this crash.

yes I know
I've difficulties to identify the problematic piece of code but just found it.
in @babel/runtime/helpers/extends/index.js (v7.13.7)
function _extends() {
  module.exports = _extends = Object.assign || function (target) {
    for (var i = 1; i < arguments.length; i++) {
      var source = arguments[i];

      for (var key in source) {
        if (Object.prototype.hasOwnProperty.call(source, key)) {
          target[key] = source[key];
        }
      }
    }

    return target;
  };

  module.exports["default"] = module.exports, module.exports.__esModule = true;
  return _extends.apply(this, arguments);
}

module.exports = _extends;
module.exports["default"] = module.exports, module.exports.__esModule = true;

If I replace it with its mjs version tsc compilation pass
in @babel/runtime/helpers/extends/_index.mjs (v7.13.7)
export default function _extends() {
  _extends = Object.assign || function (target) {
    for (var i = 1; i < arguments.length; i++) {
      var source = arguments[i];

      for (var key in source) {
        if (Object.prototype.hasOwnProperty.call(source, key)) {
          target[key] = source[key];
        }
      }
    }

    return target;
  };

  return _extends.apply(this, arguments);
}

So just compiling that file causes the crash? Or does the crash start with something that imports and uses _extends?

Something that import and use it
Don't know what
Le mer. 24 févr. 2021 à 19:06, Andrew Branch<EMAIL_ADDRESS>a
écrit :

So just compiling that file causes the crash? Or does the crash start with
something that imports and uses _extends?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TypeScript/issues/42942#issuecomment-785267713,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKMMPBQLOJSZYP3GK5EO3TAU53DANCNFSM4YE4L5BA
.

Can you at least tell me what your tsconfig is like? Clearly you’re compiling JS with checkJs, right? And I think there must be a maxNodeModulesDepth if this JS file is getting checked?

Sorry
Yes I add it:
{
  "compilerOptions": {
    "jsx": "react-jsx"
    "target": "esnext",
    "module": "esnext",
    "moduleResolution": "node",
    // Process & infer types from .js files.
    "allowJs": true,
    "maxNodeModuleJsDepth": 3,
    // Enable strictest settings like strictNullChecks & noImplicitAny.
    "strict": false,
    "noImplicitAny": true,
    "noImplicitReturns": true,
    // "noImplicitThis": true,
    "isolatedModules": false, // Disallow features that require cross-file information for emit.
    "esModuleInterop": true, // Import non-ES modules as default imports.
    "skipLibCheck": true, // Do not validate the dependencies definitions
    "experimentalDecorators": true,
    "suppressImplicitAnyIndexErrors": true,
    // resolution of dependencies/
    "resolveJsonModule": true,
    "baseUrl": ".",
    "paths": {
      "dependencies/*": [
        "node_modules/@types/*",
        "node_modules/*",
        "../node_modules/@types/*",
        "../node_modules/*",
        "../../node_modules/@types/*",
        "../../node_modules/*",
        "../../../node_modules/@types/*",
        "../../../node_modules/*",
        "../../../../node_modules/@types/*",
        "../../../../node_modules/*"
      ]
    }
  }
}

here is a repo where I reproduce the defect
https://codesandbox.io/s/twilight-sound-ll66d?file=/tsconfig.json
Locally, with the same code I've the error, but don't know why not on codeSandbox

Perfect, thank you!

Hmm nope, never mind, doesn’t repro for me.

you've create this repo locally ?
It contains only 4 files: package.json, tsConfig.json, src/index.ts and src/js/problematicFile.js
Do npm install (or yarn install), then npm run build

Yes. I’ve copied it exactly from the codesandbox.

on wich OS are you ? I'm on mac
Someone else try to reproduce it and it was working when coming from codeSandbox,
but fails from this zip:
test-module.zip

ok I've update the codeSandbox: https://codesandbox.io/s/twilight-sound-ll66d
I was setting index.js instead of index.ts
you can test in now it fails everywhere

I can now reproduce the error.
@andrewbranch If it helps, deleting lines 16 and 21 of https://unpkg.com/browse/<EMAIL_ADDRESS>from node_modules makes the error disappear.

I managed to create a smaller example:

package.json
{
  "name": "test-module",
  "version": "1.0.0",
  "scripts": {
    "build": "tsc --outDir lib/"
  },
  "dependencies": {
    "typescript": "4.2.2"
  }
}

tsconfig.json
{
  "compilerOptions": {
    "allowJs": true,
    "esModuleInterop": true,
    "noEmit": true,
    "baseUrl": "."
  },
  "include": ["src"]
}

src/index.ts
import dep from "./dep.js";

dep();

src/dep.js
function fn() {}
module.exports = fn;
module.exports = fn;
module.exports["default"] = module.exports;

ts-error-2.zip

babel team reject the responsability of their code. they said it is 100% typescript defect

@paztis My example above without any Babel code :shrug:
Btw, I can reproduce this starting from TS 4.1.2

Already fixed in https://github.com/microsoft/TypeScript/pull/42766.

Wait. It has been fixed just after the 4.2.2 publish 13 days ago ?
But it means fix will not be release in 4.2.3 but in 4.3.0 ?
As it is blocking here you're supposed to provide a patch version 4.2.3

How can we manage a workaround on this defect today ? I cannot modify babel source code... When is your fix supposed to be released ?

@paztis We'll put this into the next 4.2 release (4.3.2)

It is mostly to understand how many time my company will be block on this.
Le jeu. 25 févr. 2021 à 18:10, Ryan Cavanaugh<EMAIL_ADDRESS>a
écrit :

@paztis https://github.com/paztis We'll put this into the next 4.2
release (4.3.2)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TypeScript/issues/42942#issuecomment-786059427,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKMMMUTXJJMNKPE57DWRLTA2ACDANCNFSM4YE4L5BA
.

@paztis as a workaround downgrade @babel/runtime to 7.12, since it contains the file where TS crashes

Tu es good idea tks
Le jeu. 25 févr. 2021 à 18:46, Nicolò Ribaudo<EMAIL_ADDRESS>a
écrit :

@paztis https://github.com/paztis as a workaround downgrade
@babel/runtime to 7.12, since it contains the file where TS crashes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/TypeScript/issues/42942#issuecomment-786083056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIKMMOFVJIDZ37IM2EBADDTA2EGHANCNFSM4YE4L5BA
.

Sorry to bother you again
We limit the version of @babel/runtime to ~7.12.0, but lot of  other modules  are requiring the 7.13.0
We're in a big monolithic repository, and yarn hoist the most used version at root level.
It means we've not full control on it.
So we're in a blocking situation now.
Really not possible to cherry-pick your fix on a 4.2.3 patch ?
I don't see other solutions for now

@paztis You can pin it for your deps adding
"resolutions": {
  "@babel/runtime": "~7.12.0"
}

Ok know this one, but I hope it will not cause conflicts with other modules that requires version different from 7 of babel
Because yarn will install then a 7.12 even if they require 6.8

@babel/runtime only exist at version 7; it might cause problems in a few months after the Babel 8 release.

ok thanks for all these info
It means next month, Typescript 4.3.2 will be released, so it will be ok


Consistent focus color and set focus to tab input when edit button is clicked.

Clicking the edit button on a tab will now automatically focus the input element. I've also begun the process of making the focus styling more consistent. Maybe the close and edit buttons don't need focus:ring-2 focus:ring-ui-violet-500?

Excellent work @BradEstey! Thanks so much for this PR 😄
The UI looks a lot more polished with this consistency everywhere.

Maybe the close and edit buttons don't need focus:ring-2 focus:ring-ui-violet-500?

I think it looks good with the focus on the inner elements in the tab 👍
I see you're still making some changes to the PR -- let me know when you're finished up and I'll merge this in 🎉

I think I've got all of them addressed! Feel free to merge.
Maybe a shortcut focus color could be added to the tailwind.config.js to easily change them all later.
I had to get rid of your clever overflow-hidden rounded-lg container trick on the button groups in Editor.vue to make them individually selectable.
Let me know if I broke anything. I've never really used Vue before. :sweat_smile:

I think I've got all of them addressed! Feel free to merge.

Awesome!

Maybe a shortcut focus color could be added to the tailwind.config.js to easily change them all later.

Good idea, I'll definitely give this a shot 👍
Thanks again for your work 😄


Enable Bloom

Bloom wants a license key.  Unclear how to handle that.  Might just move it out of scope for now.
https://neo4j.com/docs/bloom-user-guide/current/bloom-installation/installation-activation/

This is already solved in the repo here.  Closing.  Opening new issue to bring in sync.  https://github.com/neo4j-partners/amazon-cloud-formation-neo4j


missing value for required property with a default

EdgeDB Version: 2.7+a86e274
EdgeDB CLI Version: 2.2.6+7eabbf9
OS Version: macOS 13.0.1

Steps to Reproduce:

Create an object type and populate the database with at least one object
Add a required json field with a default empty JSON object

        required property cadence -> json {
            default := <json>{}
        };

Create migration. Note no prompt for an expression to populate existing objects, presumably because a default is present

did you create property 'cadence' of object type 'default::Subscription'? [y,n,l,c,b,s,q,?]
> y
Created dbschema/migrations/00002.edgeql, id: m1dmdgqiffkbv7ws3bor2guc2rbzkdmijvcfxhz6h7ia6nvqdnihoa

Apply migration, migration fails

$ edgedb migrate
edgedb error: MissingRequiredError: missing value for required property 'cadence' of object type 'default::Subscription'
  Detail: Failing object id is 'd2abba9e-7690-11ed-8f09-f7eef23f2dfc'.

Schema:
module default {

    type Subscription {
        required property name -> str;

        required property cadence -> json {
            default := <json>{}
        };
    }
}

Suspect it has something to do with the interpretation of {}, so perhaps the issue is in the CLI vis a vis allowing that as a default for a required field.

<json>{} is not an empty json object, but an empty set, cast to json. {} is the empty set, not a free object with no elements. (The confusion is understandable.)
When setting defaults and when specifying fields in inserts, edgedb intentionally does not enforce requiredness at compile time, but does a runtime check.
I believe that this design predates the existence of assert_exists, but I think it is still mostly sound; it would be pretty frustrating to have to wrap so many things in it.
I don't think there is a bug here. Reopen if I've missed something!

Thanks Michael - the oversight about {} and the idea that whether the result of expressions exist is unknowable statically make sense.


TypeError: init() got an unexpected keyword argument 'callback_timeout' ERROR   2022-07-04 13:39:43 +0200   master-replica-0        NoneType: None

Hi,
I am trying to train a PyTorch model on GCP and I am reading a csv file from a cloud storage bucket in the mean time.
I get the same error when reading the file in two different ways:
1 - simply using pd.read_csv:
code:
`GCS_BUCKET = "led-test-run"
GCS_BASE_ROOT = f"gs://{GCS_BUCKET}"
TRAIN_DIR = os.path.join(GCS_BASE_ROOT, "bigpatent_sample_corpus_BIG_train_df.csv")
VAL_DIR = os.path.join(GCS_BASE_ROOT, "bigpatent_sample_corpus_BIG_val_df.csv")
train_dataset = pd.read_csv(TRAIN_DIR)`
error:
Exception ignored in: <function ClientSession.__del__ at 0x7f1ede3bd710> ERROR   2022-07-04 13:39:43 +0200   master-replica-0        Traceback (most recent call last): ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/aiohttp/client.py", line 326, in __del__ ERROR   2022-07-04 13:39:43 +0200   master-replica-0            if not self.closed: ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/aiohttp/client.py", line 963, in closed ERROR   2022-07-04 13:39:43 +0200   master-replica-0            return self._connector is None or self._connector.closed ERROR   2022-07-04 13:39:43 +0200   master-replica-0        AttributeError: 'ClientSession' object has no attribute '_connector' ERROR   2022-07-04 13:39:43 +0200   master-replica-0        ERROR:root:Traceback (most recent call last): ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/runpy.py", line 193, in _run_module_as_main ERROR   2022-07-04 13:39:43 +0200   master-replica-0            "__main__", mod_spec) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/runpy.py", line 85, in _run_code ERROR   2022-07-04 13:39:43 +0200   master-replica-0            exec(code, run_globals) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/trainer/task.py", line 78, in <module> ERROR   2022-07-04 13:39:43 +0200   master-replica-0            main() ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/trainer/task.py", line 74, in main ERROR   2022-07-04 13:39:43 +0200   master-replica-0            experiment.run(args) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/trainer/experiment.py", line 66, in run ERROR   2022-07-04 13:39:43 +0200   master-replica-0            train_dataset, test_dataset = utils.load_data() ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/trainer/utils.py", line 65, in load_data ERROR   2022-07-04 13:39:43 +0200   master-replica-0            train_dataset = pd.read_csv(TRAIN_DIR) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 610, in read_csv ERROR   2022-07-04 13:39:43 +0200   master-replica-0            return _read(filepath_or_buffer, kwds) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 462, in _read ERROR   2022-07-04 13:39:43 +0200   master-replica-0            parser = TextFileReader(filepath_or_buffer, **kwds) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 819, in __init__ ERROR   2022-07-04 13:39:43 +0200   master-replica-0            self._engine = self._make_engine(self.engine) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 1050, in _make_engine ERROR   2022-07-04 13:39:43 +0200   master-replica-0            return mapping[engine](self.f, **self.options)  # type: ignore[call-arg] ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 1867, in __init__ ERROR   2022-07-04 13:39:43 +0200   master-replica-0            self._open_handles(src, kwds) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/parsers.py", line 1368, in _open_handles ERROR   2022-07-04 13:39:43 +0200   master-replica-0            storage_options=kwds.get("storage_options", None), ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/common.py", line 563, in get_handle ERROR   2022-07-04 13:39:43 +0200   master-replica-0            storage_options=storage_options, ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/pandas/io/common.py", line 334, in _get_filepath_or_buffer ERROR   2022-07-04 13:39:43 +0200   master-replica-0            filepath_or_buffer, mode=fsspec_mode, **(storage_options or {}) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/core.py", line 476, in open ERROR   2022-07-04 13:39:43 +0200   master-replica-0            **kwargs, ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/core.py", line 306, in open_files ERROR   2022-07-04 13:39:43 +0200   master-replica-0            expand=expand, ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/core.py", line 657, in get_fs_token_paths ERROR   2022-07-04 13:39:43 +0200   master-replica-0            fs = cls(**options) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/spec.py", line 76, in __call__ ERROR   2022-07-04 13:39:43 +0200   master-replica-0            obj = super().__call__(*args, **kwargs) ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/opt/conda/lib/python3.7/site-packages/gcsfs/core.py", line 270, in __init__ ERROR   2022-07-04 13:39:43 +0200   master-replica-0            self.loop, get_client, callback_timeout=self.callback_timeout ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/asyn.py", line 66, in sync ERROR   2022-07-04 13:39:43 +0200   master-replica-0            raise return_result ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/asyn.py", line 26, in _runner ERROR   2022-07-04 13:39:43 +0200   master-replica-0            result[0] = await coro ERROR   2022-07-04 13:39:43 +0200   master-replica-0          File "/root/.local/lib/python3.7/site-packages/fsspec/implementations/http.py", line 29, in get_client ERROR   2022-07-04 13:39:43 +0200   master-replica-0            return aiohttp.ClientSession(**kwargs) ERROR   2022-07-04 13:39:43 +0200   master-replica-0        TypeError: __init__() got an unexpected keyword argument 'callback_timeout' ERROR   2022-07-04 13:39:43 +0200   master-replica-0        NoneType: None
2 - using gcsfs.GCSFileSystem:
code:
fs = gcsfs.GCSFileSystem(project='master-thesis-351911') with fs.open('led-test-run/bigpatent_sample_corpus_BIG_train_df.csv') as f:     train_dataset = pd.read_csv(f)
error:
The replica master 0 exited with a non-zero status of 1.  ERROR	2022-07-04 14:27:34 +0200	service		Traceback (most recent call last): ERROR	2022-07-04 14:27:34 +0200	service		  File "/opt/conda/lib/python3.7/runpy.py", line 193, in _run_module_as_main ERROR	2022-07-04 14:27:34 +0200	service		    "__main__", mod_spec) ERROR	2022-07-04 14:27:34 +0200	service		  File "/opt/conda/lib/python3.7/runpy.py", line 85, in _run_code ERROR	2022-07-04 14:27:34 +0200	service		    exec(code, run_globals) ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/trainer/task.py", line 3, in <module> ERROR	2022-07-04 14:27:34 +0200	service		    from trainer import experiment ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/trainer/experiment.py", line 13, in <module> ERROR	2022-07-04 14:27:34 +0200	service		    from trainer import model, metadata, utils ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/trainer/utils.py", line 24, in <module> ERROR	2022-07-04 14:27:34 +0200	service		    fs = gcsfs.GCSFileSystem(project='master-thesis-351911') ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/fsspec/spec.py", line 76, in __call__ ERROR	2022-07-04 14:27:34 +0200	service		    obj = super().__call__(*args, **kwargs) ERROR	2022-07-04 14:27:34 +0200	service		  File "/opt/conda/lib/python3.7/site-packages/gcsfs/core.py", line 270, in __init__ ERROR	2022-07-04 14:27:34 +0200	service		    self.loop, get_client, callback_timeout=self.callback_timeout ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/fsspec/asyn.py", line 66, in sync ERROR	2022-07-04 14:27:34 +0200	service		    raise return_result ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/fsspec/asyn.py", line 26, in _runner ERROR	2022-07-04 14:27:34 +0200	service		    result[0] = await coro ERROR	2022-07-04 14:27:34 +0200	service		  File "/root/.local/lib/python3.7/site-packages/fsspec/implementations/http.py", line 29, in get_client ERROR	2022-07-04 14:27:34 +0200	service		    return aiohttp.ClientSession(**kwargs) ERROR	2022-07-04 14:27:34 +0200	service		TypeError: __init__() got an unexpected keyword argument 'callback_timeout'

I'm having the same problem here. Mine had something to do with the reading in not asynchronous.
gcs = gcsfs.GCSFileSystem(token='anon')
`TypeError                                 Traceback (most recent call last)
Input In [169], in <cell line: 1>()
----> 1 gcs = gcsfs.GCSFileSystem(token='anon')
File /opt/anaconda3/lib/python3.9/site-packages/fsspec/spec.py:68, in _Cached.call(cls, *args, **kwargs)
66     return cls._cache[token]
67 else:
---> 68     obj = super().call(*args, **kwargs)
69     # Setting _fs_token here causes some static linters to complain.
70     obj.fs_token = token
File /opt/anaconda3/lib/python3.9/site-packages/gcsfs/core.py:269, in GCSFileSystem.init(self, project, access, token, block_size, consistency, cache_timeout, secure_serialize, check_connection, requests_timeout, requester_pays, asynchronous, loop, callback_timeout, **kwargs)
267 self.callback_timeout = callback_timeout
268 if not asynchronous:
--> 269     self._session = sync(
270         self.loop, get_client, callback_timeout=self.callback_timeout
271     )
272     weakref.finalize(self, sync, self.loop, self.session.close)
273 else:
File /opt/anaconda3/lib/python3.9/site-packages/fsspec/asyn.py:65, in sync(loop, func, timeout, *args, **kwargs)
63     raise FSTimeoutError from return_result
64 elif isinstance(return_result, BaseException):
---> 65     raise return_result
66 else:
67     return return_result
File /opt/anaconda3/lib/python3.9/site-packages/fsspec/asyn.py:25, in _runner(event, coro, result, timeout)
23     coro = asyncio.wait_for(coro, timeout=timeout)
24 try:
---> 25     result[0] = await coro
26 except Exception as ex:
27     result[0] = ex
File /opt/anaconda3/lib/python3.9/site-packages/fsspec/implementations/http.py:29, in get_client(**kwargs)
28 async def get_client(**kwargs):
---> 29     return aiohttp.ClientSession(**kwargs)
TypeError: init() got an unexpected keyword argument 'callback_timeout'`

Please check your versions - fsspec 2022.8.0 is out, but gcsfs has not yet gone through the process.

>>> gcsfs.__version__
'0.7.2'
>>> fsspec.__version__
'2022.02.0'

0.7.2 is very old, you should not be using that. https://pypi.org/project/gcsfs/0.7.2/

Strange, that's the version that installed by default when I executed conda install -c conda-forge gcsfs

Perhaps check your conda config? Is this perhaps an old version of python?
> conda create -n temp python=3.8 gcsfs -c conda-forge

...
## Package Plan ##

  environment location: /Users/mdurant/conda/envs/temp

  added / updated specs:
    - gcsfs
    - python=3.8

...
The following NEW packages will be INSTALLED:

...
  fsspec             conda-forge/noarch::fsspec-2022.7.1-pyhd8ed1ab_0
  gcsfs              conda-forge/noarch::gcsfs-2022.7.1-pyhd8ed1ab_0
...

(those are the latest versions on conda-forge)

I'm using Python 3.9.12. Could it be I need Python 3.8?

3.9 is the same. You must have some previously pinned packages in your system. Try installing gcsfs==2022.7.1 explicitly, and conda/mamba will tell you what other things need updating for that to happen.

My terminal can't seem to solve the environment necessary to install the latest version. Is there any way to make the solve an easier process?
conda install -c conda-forge gcsfs=2022.7.1=pyhd8ed1ab_0
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: / failed with initial frozen solve. Retrying with flexible solve.

You do not need the exact build number, which may depend on python and/or OS version.
conda install -c conda-forge gcsfs==2022.7.1

Hmm, same responses. Not sure what the fix is here.
conda install -c conda-forge gcsfs==2022.7.1
Collecting package metadata (current_repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: failed with initial frozen solve. Retrying with flexible solve.

I am still experiencing the same exception TypeError: init() got an unexpected keyword argument 'callback_timeout', even though I am already on newer versions:
gcsfs==2023.1.0
fsspec==2023.1.0

@martindurant - wondering is the fix already included in above version?

@c21 , there was no fix, I don't know why this might be happening to you. Perhaps you can use pdb to dig around and see where the extra kwarg is coming from? callback_timeout does not exist anywhere in this repo :|


Reflect pylint suggestions

Please drop commit 120f3a2b57433a4d0e86a9d4381c2692f4eeed4a.

Thanks for the feedback @istankovic
Going to address all items today.

Please drop commit 120f3a2

out of curiosity: why?

Please drop commit 120f3a2

out of curiosity: why?
Were all dict() intentional and should I mark them in code with # pylint: disable=use-dict-literal or disable it totally in .pylintrc?

First off, sorry I was so terse here, I should have definitely provided more context.
Yes, pretty much all the dict() instances were intentional and e.g. if you take a look at
        params = dict(fromBlock=self._from_block, toBlock=to_block, address=self._address)

vs.
        params = {
            "fromBlock": self._from_block,
            "toBlock": to_block,
            "address": self._address,
        }

the lint just forces you to use the more verbose, less ergonomic option. Less ergonomic because one needs to consider the quotes.
That is not to say that we never use dict literals, I do think there are examples of that in the code. It's just that in these
cases we opted for what seemed to be "better".
As is the case very often in programming, it is a matter of taste. In general, we follow the generally accepted Python conventions (especially e.g. PEP8), but also reconsider the convention if it makes our code harder to read, less ergonomic, more complex etc. I think I would phrase it as "generally, the linter is quite helpful, but if it makes your code harder to read and maintain, the linter is wrong".


Moved teku deserializers from teku into web3signer

Web3signer is referencing a few deserializers / serializers from teku, and I'm removing them from teku, so I've recreated them in web3signer to reduce integration issues...
I did have problems running tests, but I'm not sure why, this should be a relatively clean lift and shift...
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

[X] I thought about testing these changes in a realistic/non-local environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[HUDI-2063] Add Doc For Spark Sql Integrates With Hudi

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@leesf Leave it to you to land when ready

I am going to land it after we cut out the release since the spark shell uses 0.9.0 version.

@leesf Leave it to you to land when ready

@vinothchandar I am going to land it after we cut out the release since the spark shell uses 0.9.0 version.

@leesf @pengzhiwei2018 can we redo this based on the new site. We have code tabs. So we can just add a sql code tab for this and make it very simple


Chart path is slow to update

I'm having a slightly weird issue. The LineChart path is slow to update. I have transitions disabled. It may require looking closely. However, notice that when I change time ranges, the color changes a split second before the chart path does.
Video
https://www.loom.com/share/e5713040946c4145ba64433167b1dd73
Explanation
The color changes for a second before the actual path changes. It's bizarre.
To see it clearly: when I set the time range to 1D, notice that the horizontal line shows half a second before the chart path changes. I can't seem to think of what would cause this. My only guess is if internally there is some sort of state getting set inside of an effect? Or is there some sort of interpolation happening when it shouldn't?
I haven't tried to repro yet, but I will when I get the chance.
It's not like terrible but it makes the app seem laggy. There are no network requests being sent when you toggle the time range; it's all pre-fetched. It only has one state update.
Anything come to mind @jxom?
Thanks again!

I found the issue: it seems that it may be related to reanimated's animatedProps or something not rendering synchronously? In any case, using Path instead of AnimatedPath inside of LineChartPath solved it.
I opted to render Path directly when transitions are disabled.
import * as React from 'react';
import Animated, {
  useAnimatedProps,
  useAnimatedReaction,
  useSharedValue,
  withTiming,
} from 'react-native-reanimated';
import { Path, PathProps } from 'react-native-svg';

import { LineChartDimensionsContext } from './Chart';
import interpolatePath from './interpolatePath';
import { usePrevious } from '../../utils';

const AnimatedPath = Animated.createAnimatedComponent(Path);

export type LineChartPathProps = Animated.AnimateProps<PathProps> & {
  color?: string;
  width?: number;
  isInactive?: boolean;
  /**
   * Default: `true`.
   *
   * If `false`, changes in the chart's path will not animate.
   *
   * While this use case is rare, it may be useful on web, where animations might not work as well.
   *
   * **Example**
   *
   * ```tsx
   * <LineChart.Path
   *   pathProps={{ isTransitionEnabled: Platform.OS !== 'web' }}
   * />
   * ```
   */
  isTransitionEnabled?: boolean;
};

export function LineChartPath({
  color = 'black',
  width: strokeWidth = 3,
  isInactive,
  isTransitionEnabled = true,
  ...props
}: LineChartPathProps) {
  const { path } = React.useContext(LineChartDimensionsContext);

  ////////////////////////////////////////////////

  const transition = useSharedValue(0);

  const previousPath = usePrevious(path);

  useAnimatedReaction(
    () => {
      return path;
    },
    (_, previous) => {
      if (previous) {
        transition.value = 0;
        transition.value = withTiming(1);
      }
    },
    [path]
  );

  const animatedProps = useAnimatedProps(() => {
    let d = path || '';
    if (previousPath && isTransitionEnabled) {
      const pathInterpolator = interpolatePath(previousPath, path, null);
      d = pathInterpolator(transition.value);
    }
    return {
      d,
    };
  });

  const pathProps: React.ComponentProps<typeof Path> = {
    fill: 'transparent',
    stroke: color,
    strokeWidth,
    strokeOpacity: isInactive ? 0.2 : 1,
  }

  if (!isTransitionEnabled) {
    return <Path d={path as string || ''} {...pathProps} />
  }

  ////////////////////////////////////////////////

  return (
    <AnimatedPath
      animatedProps={animatedProps}
      {...pathProps}
      {...props}
    />
  );
}

Would you accept a PR for this?

Hi @nandorojo,
Thanks for raising this. I would be happy to look at a PR if you have one.


Karabiner seems to send a key signal every second without me doing or pressing anything.

Here is the console, these messages keep appearing and I am not pressing anything :

The log is event caught log.
Please check your devices state.


Fix hasChangesInDirectorySinceGitTag

To determine whether a package needs a new release, we ask if there have been any new commits that contain changes to any of the files within that package. In other words, we run a git diff on the repo and look for any files that match that package.
The problem is that git diff returns partial file paths, that is, file paths which are relative to the repository directory, whereas the subdirectory path that hasChangesInDirectorySinceGitTag takes is an absolute path. So when we look for matching packages we always come up short. This confuses the tool because it doesn't think there are any new changes to release.

@Gudahtt Ah, so I think the reason why this command pulls a list of files rather than a status is so that if we want to know whether multiple packages changed but we are using the same tag to get this information, then the command is run only once (because git diff <tag> is cached) rather than multiple times (because git diff <tag> <path1> would get run, then git diff <tag> <path2>, etc.)

The full list of changed files could be quite large, even if we're only asking for it once. I would expect getting a per-package status would be similarly fast or faster in all cases. But that's fine, this works for now.


SSL Certificate is down

Please create new certificate because it is expired
https://openzeppelin.org/api/docs/token_ERC20_MintableToken.html
Regards,
Kristiyan Tachev

Fixed. Thanks for the heads up!


Uncaught AttributeError in sendchat.py line 30

Aider version: 0.56.0
Python version: 3.12.5
Platform: Linux-6.10.6-amd64-x86_64-with-glibc2.40
Python implementation: CPython
Virtual environment: Yes
OS: Linux 6.10.6-amd64 (64bit)
Git version: git version 2.45.2
An uncaught exception occurred:
Traceback (most recent call last):
  File "aider", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "main.py", line 698, in main
    return 1
  File "base_coder.py", line 735, in run
    return self.io.get_input(
                ^^^^^^^^^^^^^^
  File "base_coder.py", line 772, in run_one
    self.io.tool_warning(f"Only {self.max_reflections} reflections allowed, stopping.")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "base_coder.py", line 761, in preproc_user_input
    else:

  File "commands.py", line 221, in run
    return self.do_run(matching_commands[0][1:], rest_inp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "commands.py", line 196, in do_run
    return cmd_method(args)
           ^^^^^^^^^^^^^^^^
  File "commands.py", line 235, in cmd_commit
    self.raw_cmd_commit(args)
  File "commands.py", line 249, in raw_cmd_commit
    self.coder.repo.commit(message=commit_message)
  File "repo.py", line 102, in commit
    commit_message = self.get_commit_message(diffs, context)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "repo.py", line 187, in get_commit_message
    commit_message = simple_send_with_retries(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "sendchat.py", line 38, in wrapper
    retry_exceptions(),
    ^^^^^^^^^^^^^^^^^^
  File "sendchat.py", line 30, in retry_exceptions
    litellm.llms.anthropic.chat.AnthropicError,
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'litellm.llms.anthropic' has no attribute 'AnthropicError'

Thanks for trying aider and filing this issue.
How did you install aider? What environment are you using? It looks like you don't have the correct set of dependencies installed. This doc may be helpful:
https://aider.chat/docs/troubleshooting/imports.html
I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.

Fwiw this was a long established install that's been working fine for weeks but did have an upgrade? that day.
That day and for a few days there were quite a few sporadic failures in the summarizer lookups? It seems like some difficult polish in failure paths around timeouts might be needed given the multiple possible failure steps from some models being unavailable.

When a model API is down/slow/flakey, aider retries patiently using exponential backoff. But after 1min it gives up.

Per the linked doc, how did you install aider? What version of aider and litellm are installed?

Ok, this is a 6+ week install thats been upgrading along the way.
I'll work on reinstalling.
Any thoughts on https://github.com/astral-sh/uv ?


[WIP] Adds reparametrization trick

WIP

Closing based on the main comment in https://github.com/PennyLaneAI/pennylane-sf/pull/55 - reparameterizing in analytic mode is slower than directly calling all_fock_probs. Hence, https://github.com/PennyLaneAI/pennylane-sf/pull/55 implements just for sampling mode.
Benchmark script used to come to these conclusions:
import pennylane as qml
from pennylane_sf.ops import ParamGraphEmbed
import numpy as np
import time
import cProfile
import pstats

modes = 4
cutoff = 6

dev = qml.device("strawberryfields.gbs", wires=modes, cutoff_dim=cutoff, use_cache=True)
A = 0.1767767 * np.ones((modes, modes))
params = np.ones(modes)

@qml.qnode(dev)
def vgbs(params):
    ParamGraphEmbed(params, A, 1, wires=range(modes))
    return qml.probs(wires=range(modes))

pr = cProfile.Profile()
pr.enable()

t0 = time.time()
p1 = vgbs(params)
t1 = time.time()

t_i = t1 - t0
print(f"Initial time {t_i}")

reps = 100

p = np.ones((reps, modes))

t2 = time.time()

for i in range(reps):
    vgbs(p[i])

t3 = time.time()

t_c = (t3 - t2) / reps
print(f"Average time for subsequent evaluations {t_c}")

pr.disable()
pr.dump_stats("time.pstats")
!gprof2dot -f pstats "time.pstats" | dot -Tpng -o output.png


Provide a way to place an extra widget above the sheet

Something like the FAB located on the top edge of the sheet in this image.

Can't one do this already with some Hero around the fab plus a Transformers.translate for the offset? Or do I miss something? 🤔

Yes, but it may take some effort.

Can anyone provide a small sample on how the widget tree will be for showing the button outside the boundaries of bottom sheet as mentioned in #273


Defining sequel and parallel blocks in test file

🚀 Feature Proposal
Be able to decide within a file whether or not a block should run in parallel or sequel. If in sequel, placement within the file dictates, if parallel, does not matter.
Motivation
I have tests that I wish I could have parallel. My example would be that I am writing tests that makes sure things are written to console.log. Several of these tests send data to console.log so in order for the tests to not contaminate each other must be done in sequel.
Other tests in the file are not affected by this and can simply be run in parallel.
Other examples I have come across in the past include testing default port numbers for various things.
Example
it('example test to be run in sequel', () => {}, true); // <-- if boolean, treat as run in parallel or sequel, if number, treat as timeout

it('example test to be run in sequel', () => {}, 3000, true); // <-- both timeout and run in sequel

describe('example block to be run in sequel', () => {
    it('example test to be run in sequel', () => {});

    it('example test to NOT be run in sequel', () => {}, false);
}, true);

describe('example block to NOT be run in sequel', () => {
    describe('example block to be run in sequel', () => {
        it('example test to be run in sequel', () => {});

        it('example test to NOT be run in sequel', () => {}, false);
    }, true);
    it('example test to be run in sequel', () => {}, 4000);

    it('example test to NOT be run in sequel', () => {}, 2000, true); // <- with timeout
});

Output in the terminal would be as it is today.
The default value for the boolean is false. If omitted it then takes this stance (current Jest behavior, to not create breaking changes).
Pitch
As you can see from the example, there really is no limit as to how you could structure which tests are sequel dependent and which are parallel. Grouping tests on context rather than sequel vs. parallel would make things a lot easier when setting up the development environment for developers not to mention the increase in readability and maintainability.
Why does this feature belong in the Jest core platform?
As you can see the proposed example affects the syntax of the blocks. So I'm guessing it would meddle with the internal workings of jest.
Common feature proposals that do not typically make it to core:

New matchers (see jest-extended)
Changes to the default reporter (use custom reporters instead)
Changes to node/jsdom test environments (use custom environments instead)

ctest has a nice simple concept based on a resource allocation system. ctest has no idea what a resource is, you can just specify what resources a test needs and when you run the tests you can specify how man of those resources you’ve got. ctest will then schedule tests so it will not executes tests until they can get the resource it needs.
For instance this can be used to say that you have one resource called “database” and all tests that are tagged with needing the resource “database” will then be run serially as only one test at the time can hold that resource.
https://cmake.org/cmake/help/latest/manual/ctest.1.html#resource-allocation

All tests run sequentially in jest unless you use the experimental test.concurrent. So I think what you're requesting is already possible.


SSR with Nuxt

The docs say:

"If using as a plugin with Nuxt be sure to disable server side rendering in nuxt.config.js."

Will this mean that all content which is wrapped with v-scroll-reveal will not be server side rendered?

That tip was provided by a contributor who used this library in Nuxt (see issue #3 and PR #8), so I can't speak to it's effect. I would personally hope that disabling just this library from SSR would only disable the reveal logic, not necessarily the (non-)rending of the element(s).
But, please, give it a try in your environment and let me know what you discover!

@tserkov It seems the content is properly loaded with pre-rendered content, even though ssr is disabled just for the plugin.
Congratulations on the great wrapper you wrote! You rock!


support enable IcebergCompatV2 on empty existing Delta table with ALTER

Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
support enable IcebergCompatV2 on empty existing Delta table with ALTER

no test for the change?

decided that this PR is not needed.


[!] Unable to find a specification for ' PINRemoteImage'.

[!] Unable to find a specification for ' PINRemoteImage'.

Hi @mengheangrat going to need a bit more info than that. Please reply if you have some, closing this for now.


3Box Integration

For https://github.com/UniversalLogin/UniversalLoginSDK/issues/102
I've noticed some issues for 3Box, please review:

https://github.com/uport-project/3box-js/issues/184

https://github.com/SilentCicero/ipfs-mini/issues/10

Notably, there are no options to set an optional host for ipfs-mini for threebox itself. I believe this is something that should be available when running the constructor method for 3box itself. I am open to writing pull requests to both ipfs-mini and 3box-js for this to actually work.
I've also updated the UI here:

@alexvandesande, due to how 3box works... Would we be using Mascara instead?
Yes, the buttons are tbd.
If we end up using mascara, it probably won't need an "enable Metamask" button.

Had a chat with @marekkirejczyk about the possibility of having universal logins always add by default an ethereum object. He thinks adding a global object could lead to many undesired collateral effects. Another possibility would be, in this particular case, create an ethereum provider specifically for threeBox.js that would send any personal_sign transaction towards the same functions at ether.js

Hey @alexvandesande, sorry this went in limbo for a few days.
It seems they updated the API the day after we had the conversation in regards to the problems with IPFS on Infura.
Here's the updated docs: https://github.com/uport-project/3box-js#Box.openBox
We also will need a service for a 3Box Pinning Server and Name Server:

https://github.com/uport-project/3box-pinning-server
https://github.com/uport-project/3box-address-server

If this makes sense, I'm going to update it with the Provider passed into the SDK.
I'm going to scrap this PR for a new one.

@ChrisCates @alexvandesande There is another option, that is not documented unfortunately, that allows you to create a 3box without having an ethereum account:
Internally 3box uses an indentity construct called "muport". You can create a muport identity without an ethereum account from a mnemonic. This muport can then be passed to the 3Box constructor. See the code below:
const mnemonic = bip39.generateMnemonic() // you can also derive the mnemonic from a base entropy, see the bip39 docs
const id = await MuPort.newIdentity({ name: 'name123' }, null, {
  mnemonic
})
const box = new Box(id)
await box._load() // this function has to be called in order for 3box to work correctly.
box._linkProfile = () => {} // this disables any further calls to the ethereum client

Note that this 3box will be independent and not be linked to any ethereum address.
Hope this is helpful in what you are trying to do. Let me know if you have any questions!


Submission More Details Modal

<bump> Just wanted to make sure the one link gets fixed, that's all I really care about

@billdybas @kayladavis can you look over my changes and approve/disapprove? Screenshot below.

addressed some nits, w/ updated PDF link shown below


Query: Shortern table alias

Resolves #8255
Resolves #8284

Updated. Removed the changes in result assertion for now.

The fix for #8284 is to change line 169 in StateManager.cs to:
entries = new Dictionary<object, InternalEntityEntry>(ReferenceEqualityComparer.Instance);

Don't forget to unskip the tests in ComplexNavigationsOwnedQuerySqlServerTest


[Repository] Release IQ quickstart errrors blocking PR merges

Relates to:
https://github.com/newrelic/newrelic-quickstarts/pull/855
https://github.com/newrelic/newrelic-quickstarts/pull/845
Issue
A PR #855 is being blocked due to errors introduced in #845.  Though the Release IQ quickstart doesn't have more than 6 images, and these dashboard properties mentioned below don't really apply.
Expected
We don't see these errors on #855 and the PR can be safely merged in and pass all checks.
Failures
https://github.com/newrelic/newrelic-quickstarts/runs/5300104868?check_suite_focus=true
Error: quickstarts/releaseiq/dashboard/riq-dashboard.json
	 must have required property 'title'
	 must have required property 'level'
	 must have required property 'authors'
	 must have required property 'logo'

https://github.com/newrelic/newrelic-quickstarts/runs/5300104930?check_suite_focus=true
Error: Each component should contain no more than 6 screenshots
  folder: '/home/runner/work/newrelic-quickstarts/newrelic-quickstarts/quickstarts/releaseiq',
  dashboardCount: 0,
  imageCount: 1,
  maxImages: 0

as a note all PRs in To Review are failing checks https://github.com/newrelic/newrelic-quickstarts/projects/3

i actually see the set of changes to make as already being made in an open pr: #856
will merge that rather than making the changes.


Run tests on OS X on Travis.

This branch updates the Travis config to make it possible to run tests on OS X.
Fixes #25

Current coverage is 100.00%

Merging #41 into master will not affect coverage as of f408a7e

@@            master     #41   diff @@
======================================
  Files           14      14
  Stmts          590     590
  Branches         0       0
  Methods
======================================
  Hit            590     590
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of f408a7e

Powered by Codecov. Updated on successful CI builds.


Fallback to default responder when there are no representers defined

I'd like to propose a feature
When defining a controller-wide responder using:
  def self.responder
    Class.new(super).send :include, Roar::Rails::Responder
  end

I get uninitialized constant NilClassRepresenter whenever respond_with nil is called. Wouldn't it be nice if Roar::Rails::Responder fallback to default rails responder when there aren't representers defined for the resource? With that in mind, any call to respond_with nil would call nil.to_json.
When a more complex class is passed to respond_with, say Post, and there arent a PostRepresenter defined, the responder would fallback to the default rails responder calling post.to_json or post.to_xml on the resource instance.

What is the current behaviour when having a nil value? Sounds good.

This line throws an uninitialized constant NilClassRepresenter, because there is no NilClassRepresenter defined. If the implementation fallback to the default responder it would call nil.to_json resulting in "null".
In my project I have a controller as follows:
module Api
  class EnvironmentsController < ApiController
    respond_to :json

    def show
      @environment = Environment.find_by_id(params[:id])

      respond_with @environment
    end

    private

    def self.responder
      Class.new(super).send :include, Roar::Rails::Responder
    end
  end
end

When there aren't Environments with the specified ID I have to provide a NilClassRepresenter. There are cases  which I want to use respond_with "any srting", :status => 500, so I have to provide a StringRepresenter and so on. Once rails default responder already deals with nils and strings (calling to_json) it would be nice to fallback to this implementation.

Hum, may I implement such feature? I'm just waiting for an okay :)

Of course, just be sure to test it! :-)
On Tue, Feb 14, 2012 at 1:16 AM, Guilherme Cavalcanti
<EMAIL_ADDRESS>wrote:

Hum, may I implement such feature? I'm just waiting for an okay :)

Reply to this email directly or view it on GitHub:
https://github.com/apotonick/roar-rails/issues/7#issuecomment-3951647


Fix recycling locator element type for React

Adds a global type for the recycling-locator custom element that's compatible with React projects (JSX)

:tada: This PR is included in version 1.22.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


#241, #242 Capture name of product and enum to schema

This PR implements features #241 and #242. However instead of adding name to all records and enums, TypeId was added so its possible to get fully qualified name like:
package zio.example {
  case class Person(age: Int)
  val personSchema = DeriveSchema.gen[Person]

  assertTrue(personSchema.id.fullyQualified == "zio.example.Person")
}

I am still missing macro schema generation for scala 3 which was recently added (scala 2 works fine)
In order to be able to convert from Schema.Record to DynamicValue.Record and back without loosing information TypeId was introduced also on DynamicValue.
Because of that, however, I don't know how to write Schema for DynamicValue.Record as Schema[DynamicValue] describes DynamicValue itself, not underlying untyped data structure. So even though for example DynamicValue is representation of
Address(street: String, number:Int, postalCode: String)
its Schema is a CaseClass1
Schema.CaseClass1[Map[String, DynamicValue], DynamicValue.Record](
        TypeId.parse("zio.scheema.DynamicValue.Record"),
        Schema.Field("values", Schema.defer(Schema.map(Schema.primitive[String], DynamicValueSchema()))),
        map => DynamicValue.Record(TypeId.Structural, ListMap(map.toSeq: _*)),
        record => record.values
      )

As you can see Schema provides a way how to construct data structure, which in this case is DynamicValue, however we don't know the name of data structure that DynamicValue represents (Address) - we just know how to construct it. The same applies also for enums.
Files in zio-schema-thrift/shared/src/test/scala-2/zio/schema/codec/generated/ were auto generated by new version of Thrift compiler 0.16.0 - no need to be reviewed.

Thank you for your work on this! This is a highly sought-after addition to ZIO Schema.

So even though for example DynamicValue is representation of Address(street: String, number:Int, postalCode: String)
its Schema is a CaseClass1

I think you have to use a hidden field inside the map, which stores the typeId for the record.
You can see it would affect this:
        map => DynamicValue.Record(/* extract out type ID from map */, ListMap(map.toSeq: _*)),
        record => record.values ++ /* store record type id into map */

The build is still failing, can you please take a look? 🙏

hey @jdegoes, took me some time to resolve issues for scala 2.12 and 3 but its ready to review now. Please check also the comment I made about extracting strings that I use for singleton types.
Prism[some.type, Option[A], Some[A]] // ok
Prism["Some", Option[A], Some[A]] // fails on 2.12


Add MANIFEST.in to include license file in source distribution

It would be helpful to distribute the license file with the source distribution

Okay, I've merged it. Should I make a new version and publish it on Pip?

And big thx btw., super cool to even get a pull request ;)


InertiaHandleRequest middleware bypassed when HTTP error occurs

Hi !
I am currently creating a project involving Inertia for the first time, and I came across a weir behavior.
Indeed, I tried to create some custom HTTP error pages for 404, 501, etc., but I found out that my shared data setup in the
InertiaHandleRequest middleware were not shared on error pages (see: https://inertiajs.com/error-handling for the backend implementation of error redirection).
The data that I wanted to have globally no matter the state of the app was containing:

app name
locale
available language for language selector
auth for navbar customization based on logged user

public function share(Request $request): array
{
      return array_merge(parent::share($request), [
          'appName' => config('app.name'),
          'locale' => app()->getLocale(),
          'availableLocales' => config('app.available_locales'),
          'flash' => [
              'message' => $request->session()->get('message'),
              'success' => $request->session()->get('success'),
              'error' => $request->session()->get('error'),
          ],
          'auth' => function () use ($request) {
              return [
                  'user' => $request->user() ? [
                      'id' => $request->user()->id,
                      'email' => $request->user()->email,
                  ] : null,
              ];
          },
      ]);
  }

Those were never passed to my custom error view.
The workaround I found was to create a custom Laravel middleware called SharedDataMiddleware that share the most important data like auth, appName and locale, and register this middleware as a global middleware for all request no matter what kind.
protected $middleware = [
    // \App\Http\Middleware\TrustHosts::class,
    \App\Http\Middleware\TrustProxies::class,
    \Illuminate\Http\Middleware\HandleCors::class,
    \App\Http\Middleware\PreventRequestsDuringMaintenance::class,
    \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
    \App\Http\Middleware\TrimStrings::class,
    \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
    \App\Http\Middleware\SharedDataMiddleware::class,
];

class SharedDataMiddleware
{
    /**
     * Handle an incoming request.
     *
     * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
     */
    public function handle(Request $request, Closure $next): Response
    {
        Inertia::share("appName", config("app.name"));
        Inertia::share("availableLocales", config("app.available_locales"));
        Inertia::share("locale", app()->getLocale());
        Inertia::share("auth", function () use ($request) {
            return [
                'user' => $request->user() ? [
                    'id' => $request->user()->id,
                    'email' => $request->user()->email,
                ] : null,
            ];
        });

        return $next($request);
    }
}

Is this a proper way to bypass the problem I have or is it not the recommended way ?
Please let me know if something is shady so I can fix my mistakes and continue with development.
Cheers.

It all depends on whether the error occurs before or after any "share" middleware is executed.
Your solution seems fine, although you may want to increase the priority of your middleware.
I would be mindful of depending on a database query to succeed (retrieving the user) in your error-handling approach though.


Update autoloading_and_reloading_constants.md

I've prepared a stage to preview changes. Open stage or view logs.


Code example was not showing in documentation

Code example was not working. Fixed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: FreyaA365 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @FreyaA365 ... Since 2.1 is no longer supported, the update is to drop the coverage.
btw --- Please sign the CLA ☝ if you agree with its terms. We can't accept the PR without that signature.


Support for notifications of async job completion

Currently, I understand that the job API require it to be polled to check its status. This makes asynchronous UX slow at best, and usually pushes the polling responsibility to end users.
Was it considered to have the the job API support a scaleable notification mechanism so that users that don't want to poll for underlying async operations, can enjoy a responsive blocking UX ?
See related CLI request at https://github.com/cloudfoundry/cli/issues/1354#issuecomment-427070213
(duplicated comment from V3 Asynchronous Operations Proposal )

We are archiving this repo in favor of colocating the information in the ccng repo, any issues or PRs are welcome in its new location. Thanks!


Fix TLV identifier serialization and COAPs support

Current head build does not work at all with setting COAPIFACES, as the value is not propagated to the correct setter
TLV identifiers in the range 8-16 bit are not serialized according to spec.

Thx  luif :)
Could you please sign the eclipse CLA and sign your commits too.

Right, I'll have to open a new pull request, since I see that i committed with wrong email account.

In this case you can change your commit (e.g. with interactive rebase), then do a push force in your banch, (but close the pull-request and open a new one is ok too)

See https://github.com/eclipse/leshan/pull/38


Page controls are not appearing with version 1.0.0

I have been trying to getting paging controls, I partially successful. I was able to get counts equivalent display, but not pages equivalent display like "<< 1, 2, 3 >>" pages. Here is the code, please let me know what is wrong in here.

                Date
                Order Id
                Customer
                Customer Phone
                Amount

                {{order.date}}
                {{order.orderId}}
                {{order.user.name}}
                {{order.user.phone}}
                {{order.totalAmount}}

Javascript part
scope.tableParams = new NgTableParams({
      page: 1,
      count: 10
    }, {
      paginationMinBlocks: 1,
      paginationMaxBlocks: 20,
      counts: [10, 25, 50, 100, 200, 500, 1000, 2000, 5000, 10000],
      getData: function(params) {
        var ords = [];
        scope.page = params.page();
        scope.count = params.count();
        const query = 'page=' + scope.page + '&size=' + scope.count;
        ds.get('/api?' + query, ords, function() {
          scope.orders = [];
          ds.push(ords.docs, scope.orders);
          scope.total = ords.total;
          params.total(scope.total);
          params.data = scope.orders;
          console.log(scope.tableParams);
          return scope.orders;
        });
      }
    });

I am also facing same issue.  Did you get any solution


Added missing setQueryPortsByPath function.

It seem that without setting queryPortsByPath there is no way to see multiple duplicate devices on Linux.
Example with queryPortsByPath=false (default) set:
comName /dev/ttyUSB1
pnpId usb-FTDI_FT232R_USB_UART_if00-port0
manufacturer FTDI

Example with queryPortsByPath=true set:
comName /dev/ttyUSB0
pnpId usb-FTDI_FT232R_USB_UART_if00-port0
manufacturer FTDI
Found
comName /dev/ttyUSB1
pnpId usb-FTDI_FT232R_USB_UART_if00-port0
manufacturer FTDI
Found

Am I correct to assume that a function like this is missing?
  factory.setQueryPortsByPath=function(val)
  {
	spfOptions.queryPortsByPath=val;
  }

Then this works:
serialPort.setQueryPortsByPath(true);
serialPort.list(function (err, ports) {
...
});

Looks like its trying to solve the same problem of #575


Rectangle API for specifying corner radius

I thought there was an existing scenery issue for this, but couldn't locate it. So pardon if this is a duplicate issue.
100% of the rounded rectangles that I've need to create have round corners, and therefore identical values for the arcWidth and arcHeight arguments, e.g.:
var rect = new Rectangle( 0, 0, 200, 300, 10, 10, { ... } );

For good coding hygiene, I'm forced to factor out the duplicate value, e.g.:
var radius = 10;
var rect = new Rectangle( 0, 0, 200, 300, radius, radius, { ... } );

Any of these would be much nicer:
(1) Add options.cornerRadius:
var rect = new Rectangle( 0, 0, 200, 300, {
  cornerRadius: 10
} );

(2) ... or if you want to avoid the problem of having both parameters and options that affect corner radius, then consider a new scenery node type:
function RoundedRectangle( x, y, width, height, cornerRadius, options )

(3) ... or a factory function:
Rectangle.createdRounded( x, y, width, height, cornerRadius, options )

Lots of ways to skin this cat, all of them better than the current API.

(1) Add options.cornerRadius:

Since we have { rectArcWidth: ..., rectArcHeight: ... }, should we consider { rectArc: ... } that sets both, and doesn't have a getter?
I'd alternatively opt for a renaming of all of the arc/radius/corner naming, like "cornerRadius", "cornerXRadius" and "cornerYRadius" if that helps.

(2) ... or if you want to avoid the problem of having both parameters and options that affect corner radius, then consider a new scenery node type:

I'd rather support the constructor directly like:
function Rectangle( x, y, width, height, cornerRadius, options )

and/or, like (3) with a factory function.
@pixelzoom, what is your opinion on:

Renaming corner/arc-related parameters for rectangle, and adding a setter that sets both with one value?
Adding support for the Rectangle constructor with just the single cornerRadius
Adding the factory function mentioned (3)

I think all three might work well.

@pixelzoom, what is your opinion on:

Renaming corner/arc-related parameters for rectangle, and adding a setter that sets both with one value?

I'd prefer to set corner radius via an option, so that it's instantiated correctly, not via a setter that needs to mutate the shape.

Adding support for the Rectangle constructor with just the single cornerRadius

Step in the wrong direction, see 3.

Adding the factory function mentioned (3)

Yes. And while we're at it, do away with Rectangle's constructor overloading and provide factory functions instead. Imo, constructor overloading is a bad pattern - it complicates the implementation, complicates the documentation, and makes usage more prone to programming errors. One well-documented constructor signature (for the most common use case) is preferable, along with convenience/factory functions for the other variations.

I'd prefer to set corner radius via an option, so that it's instantiated correctly, not via a setter that needs to mutate the shape.

I was recommending having cornerRadius as an option. Rectangle doesn't generally create Shape instances unless required, and ALL options (like left, opacity, visible) passed to a Node (using mutate()) calls setters. To be clear on what I was recommending:

Add setCornerRadius( radius ) and ES5 setter cornerRadius.
Add 'cornerRadius' to mutatorKeys, so that mutate() with 'cornerRadius' will call the setter.
Rename rectArcWidth to cornerXRadius, and rectArcHeight to cornerYRadius.

Yes. And while we're at it, do away with Rectangle's constructor overloading and provide factory functions instead.

Happy to reconsider, but https://github.com/phetsims/scenery/issues/149 (for that issue) noted:

1/27/15 dev meeting decision: Way too painful to change, leave as is. And some people like the overloaded constructor.

Adding developer-meeting tag to discuss cornerRadius and constructor overloading.

9/24/15 dev meeting notes:
• Above proposal sounds good.
• Leave Rectangle constructor as is, but enumerate the supported signatures in the constructor doc.

Implemented and tested, let me know if there's anything else.

I don't see the constructors signatures enumerated in the doc, as decided in https://github.com/phetsims/scenery/issues/467#issuecomment-142999972.  They appear as inline comments in the constructor, but I believe the decision was to consolidate them in the constructor doc.

Done, can you review?

Implementation looks good.
I still have questions about the constructor doc. Line 40 says:
with { ... } representing the optional Scenery-style parameter object
Do you mean options? If so, I would simply replace {...} with options in the constructor signatures. As currently written, it makes me wonder if it's something other than options (which it may be.)

Updated to [options] to indicate it's optional. Let me know if just options would be preferred (even though it makes it look required).

:+1: Closing.


Update languages

In general, just some minor fixes/modeline support.

language-javascript, as is now customary, got even more improvements to its JSDoc tokenization.
language-c can now tokenize operators.

@Alhadis if there's any merged modeline PRs that I forgot to bump the version for, please let me know.  I'll also try to get back to you on the incorrect-file-detection issue shortly.

if there's any merged modeline PRs that I forgot to bump the version for, please let me know.

Nope, everything looks fine. :-)
Regarding the "incorrect-file-detection" thing, once I have a definitive answer, I'll follow-up with PRs to other packages too... so you can include them in this PR if y'like.


updated to catch better

see this

Coverage remained the same at 65.826% when pulling c6c2ad52df456a0e9fc0bd76579878fe282df073 on WELZ-gh:patch-3 into 32afc01c5f854260639980104b558edff726f9d3 on Charcoal-SE:master.

Duplicate of #2121 which I merged


several parsing issues

While working with live squid logs and parsing i came across following issues:
ftp://mapasamazonsa.com.ve/ > null  ## maybe problem with ftp ?
http://www.geekvida.tp/ > null ## .tp is valid top level domain
http://www.extra.an/ > null ## .an is valid top level domain
http://y399.3466633.be:4/235222/399.html > null ## maybe problem with the port 4 ?
this%20file%20was% > crash with 'TypeError: Cannot read property '3' of null'

i wanted give you valid and should-be-working data.

Adding several more in order to add my 2cents to improve your repo:
wss://ie14.zopim.com/s/W/ws/zPYsGUAnWMyJ1XOL/c/1537265376519
wss://mp.sparkchess.com/
wss://<IP_ADDRESS>.prod.hosts.ooklaserver.net:8080/ws
wss://gscspeedtest1.dctechmicro.com.prod.hosts.ooklaserver.net:8080/ws
ws://lhg2-speedtest.globe.com.ph:8080/ws
wss://s-usc1c-nss-218.firebaseio.com/.ws

Another one seems to have trouble with a dot at the end of the domain, which is from dns and browser perspective a valid host;
http://server.dr.pt./ > null

Afaik the - is not allowed as last char:
{ tld: 'zip', domain: '7-1674-', subdomain: '' }


TL;RL cheat notes for IPv4 ipWhitelist when PI listening on IPv6

Hopefully save a google or support request --  while still using IPv4 addresses on MagicMirror network, need to set full address by using ::ffff: as prefix to IP in config.  e.g.  ::ffff:<IP_ADDRESS> and not <IP_ADDRESS>
Need to know when to use the ::ffff: or not or if PI running IPv6 or IPv4 ... see full explanation:
https://forum.magicmirror.builders/topic/1326/ipwhitelist-howto

Sorry to take your time, I should have caught the spaces.


Batch Logs

Feature Request.
I haven't been able to use this because I need to call the log event more than 5x/second. Would love to see periodic uploads added to this library.

Can you explain in more detail what stops you from using the library? If you keep calling log while a write to cloudwatch is in progress it queues the events and sends them in a batch on the next write.