Permission icon on toolbar not working

Is the permissions icon on toolbar supposed to work?

Internally it uses acledit.dll, which is still there and can be loaded in wfinfo.c:1772, but on the first call with FMEVENT_LOAD it fails.
This is why winfile unloads the .dll and the icon is grayed out further on
So there are few questions:

Is acledit@FMExtensionProcW deprecated completley with W10/W11? Think so.
On which plattforms does acledit@FMExtensionProcW work? WNT4/W2K/WXP/W7?
On which plattforms shall this Winfile work? W7/W10? or below?
If acledit@FMExtensionProcW is deprecated, is there a replacement for this call? I doubt because FMExtensionProcW is too specific

Not just deprecated, it's fully gone - it does nothing except return zero.
NT4/W2K/XP (32 bit only.)  It was never ported to 64 bit and was removed in Vista.
I'm not actually sure...? I think Vista+?  My tree targets 2000+, which requires changes not in this one.
I need to do more research here.  Like the other issue, one starting point would be to see what Explorer does, although it also might not be documented.  Obviously the raw functions to change file permissions are documented, so the part that's missing is the UI.  So one option would be to use explorer's UI; one would be to build new UI; one would be to take acledit from an old OS (that's a joke); another would be to try to release the source for the old acledit.  I'm really not sure how Craig was able to release winfile to begin with (I've never succeeded at releasing code) so don't know how feasible that last one is.

This repository seems to support W7/W8/W10/W11, since it is bound to WINVER==0x0600
So we could remove the 'security' icon for this version.

Fixed with #324


mkdnflow.nvim is broken on nvim v0.9.4

Plugin affected: mkdnflow.nvim
Nixpkgs channel: unstable
Home-manager version: (if applicable)
Description
mkdnflow.nvim is broken on nvim v0.9.4 due to API changes. It needs to be updated to this commit.
Config
N/A

Yes, I know about that. Plugins have not been updated upstream for a while.
I have a PR opened for that. I hope that it will get merged soon.
We cannot really do anything at the nixvim level.

I am not saying you should do it but nixvim could expose a vim plugin overlay.

Closing as it's fixed, thanks!


fix IOError: image file truncated” with big image

If the image size is too large, then such error will occur:
OSError: image file is truncated (13 bytes not processed).
The solution I found from stackoverflow: https://stackoverflow.com/questions/12984426/python-pil-ioerror-image-file-truncated-with-big-images.
I tested it and it actually works.

Thank you.
Could you add tests for such large images?


transfers: record processedAt when file is uploaded to ODFI

Fixes: https://github.com/moov-io/paygate/issues/542

Codecov Report

Merging #548 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   53.96%   54.13%   +0.16%
==========================================
  Files         102      102
  Lines        3821     3824       +3
==========================================
+ Hits         2062     2070       +8
+ Misses       1388     1386       -2
+ Partials      371      368       -3

Impacted Files
Coverage Δ

pkg/database/mysql.go
58.69% <ø> (ø)

pkg/database/sqlite.go
56.25% <ø> (ø)

pkg/transfers/pipeline/repository.go
57.57% <100.00%> (+1.32%)
:arrow_up:

pkg/transfers/repository.go
69.47% <100.00%> (+0.16%)
:arrow_up:

pkg/validation/microdeposits/repository.go
65.00% <100.00%> (+0.35%)
:arrow_up:

pkg/upload/sftp.go
69.10% <0.00%> (+2.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592eb67...9b2c074. Read the comment docs.


Gets a basic deep module reference test working with 1.1.0 node-resolve

For #51, this uses the 1.1.0 node-resolve to make deep module references mappable.
It works by adding a pathFilter that checks browser for a matching key and returns that value.  It handles if the user does or does not end the map with .js.
It includes a test.
Thanks!

@justinbmeyer This is all that is necessary to make direct require work and be able to shim via browser field in the nested modules?

Once you make the style changes, please squash into a single commit and reference the original discussion as you have. Great job on following this through!

@defunctzombie Yes, it seems like this is all that is needed as most of the hard work is now being done in node-resolve.  I tested this against the workflow in CanJS (where CanJS has everything in dist/cjs) that uses browserify and it worked right.
I will hopefully get the pull request cleaned up for tomorrow.  Thanks!

Updated.  Thanks!

published in v1.7.0
Thanks!

Now this seems to break browserify for me when I resolve files that are not .js files. I'm using custom transforms to precompile hogan templates which stopped working. If I manually downgrade browser-resolve to v1.6 it works fine again. But v1.7 is picked up by the current browserify release.

@mantoni Can you add a breaking test?    What error do you get?  I can get in a patch asap.

@justinbmeyer Thanks. Had to run away. Will try and isolate tomorrow.

Narrowed it down to this: https://github.com/substack/node-resolve/issues/69
Please consider nailing the dependency to<EMAIL_ADDRESS>for the time being.


Create a Guide/Template: How to Troubleshoot 1Password's One-time Password and Use Backup Codes

Overview
We need to create a guide on how to use backup codes in GitHub when 1Password's one-time password is not working for the user so that the user can still gain access.
Action Items

[x] Add the "TG: Create Guide" label
[ ] Create a guide

[ ] Once done, remove the "TG: Create Guide" label and add the "TG: Review Guide" label

[ ] Review the guide with product management communities of practice

[ ] Once done, remove the "TG: Review Guide" label and add the "TG: Leadership Review" label

[ ] Present to Hack for LA leadership team for sign off

[ ] Once approved, remove the "TG: Leadership Review" label and add the "TG: Place Guide" label

[ ] Possibly create an issue template on .github

[ ] Include link to template under resources if you add it as a template in .github

Resources

Update tracker issue https://github.com/hackforla/product-management/issues/123 with the name of item you are working
Folder

Guide
Graphics and Annotations slide deck
Header

@JasonEb Thanks for reaching out. I am so sorry I missed your comment in this issue earlier. Could you please @mention me in the future? Since I get so many notifications, the @mention helps me filter my notifications and prioritize ones that are directed directly towards me.

Progress: None but worked on a similar guide for Google Accounts: Guide: How to Set Up 2-Step Verification in a Google Account Using 1Password, which will help with the writing of this guide. I'm taking a few weeks week off from Hack for LA, except for attending a few meetings, responding to Slack messages, and dealing with GitHub notifications. I should be back fully by Thursday, September 15, 2022.
Blockers: None
Availability: None until Thursday, September 15, 2022
ETA: Not sure yet.

Hey Jessica, lets provide an update

Progress: "What is the current status of your project? What have you completed and what is left to do?"
Blockers: "Difficulties or errors encountered."
Availability: "How much time will you have this week to work on this issue?"
ETA: "When do you expect this issue to be completed?"
Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."

remember to add links to the top of the issue if they are going to be needed again.

Progress: I plan on starting to write up the guide including images this week hopefully; if not, then next week. None but worked on a similar guide for Google Accounts: Guide: How to Set Up 2-Step Verification in a Google Account Using 1Password, which will help with the writing of this guide.
Blockers: None
Availability: 6 hours this week
ETA: November 14, 2022

Progress: I plan on starting to write up the guide including images this week. None but worked on a similar guide for Google Accounts: Guide: How to Set Up 2-Step Verification in a Google Account Using 1Password, which will help with the writing of this guide.
Blockers: None
Availability: 6 hours this week
ETA: November 14, 2022

Progress: None because I have been having Internet issue. However, I worked on a similar guide for Google Accounts: Guide: How to Set Up 2-Step Verification in a Google Account Using 1Password, which will help with the writing of this guide.
Blockers: None
Availability: Not sure this week
ETA: November 30, 2022 for first draft

Progress update

Progress: Internet has been fixed
Blockers: None
Availability: Not sure this week
ETA: Jaunary 10, 2022 for first draft

Notes

Guide: How to Set Up 2-Step Verification in a Google Account Using 1Password, which will help with the writing of this guide.

Progress: I started a rough draft
Blockers: None yet
Availability: 6 hours
ETA: Thu, Dec 23, 2022

Progress update

Progress: I started a rough draft
Blockers: None yet
Availability: 6 hours
ETA: Sun, Jan 1, 2023 for first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password , replace the troubleshoot section with a link to this guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: Thu, Jan 12, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: Tue, Jan 24, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: Tue, Feb 11, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: Tue, March 14, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: Tue, March 14, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: April 30, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Progress update

Progress: I started a first draft but didn't quite finish it
Blockers: None yet
Availability: 6 hours
ETA: April 30, 2023 to complete first draft

Tasks

[ ] When the guide for this issue is done, in Guide: Log into a Google Account with 2-Step Verification Using 1Password, replace the troubleshoot section with a link to the troubleshooting guide.

Assignee, Labels, Project Board Placement, and Milestones for this issue in the Ops Repo:

@JessicaLucindaCheng  This guide issue is moving to the knowledgebase-content repo. If you would like to maintain edit access to the issue and its associated files, please fill out the Google Drive Access Form.

[(https://drive.google.com/drive/folders/12MRORAcPY_-UMHD183PiJFlAdVmOQmIX)]

Unable to view this document while moving this issue


Huggingface inference script

hi masters, great work! Is there an inference code for model downloading from huggingface?

Hi, please try this file mgm/serve/cli.py if you want to do simple inference. You can also set up a GUI following the guideline in README.


Cant read manga in colamanga

Steps to reproduce
Choise any manga
Choise any chapter
Expected behavior
Start read manga
Actual behavior

Crash logs
No response
Mihon version
0.16.5
Android version
Android 14
Device
Sony 1 VI
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.5.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Not an app-related issue, go check with whoever maintains your extensions instead, since Mihon doesn't have, associate, or provide any extensions/sources/content.


Improve lakeFS transactions by using deque, placeholders for commit SHAs

Similarly to fsspec, the transaction now lives in the lakefs_spec.transaction submodule.
Introduces the Placeholder generic type for a deferred value that is only available after transaction completion.
This is important for values that are not available immediately after execution of a transaction helper, such as a commit SHA, which has to be computed first by the backend, and this happens only on transaction completion.
To be able to still pass these values to other consumers in the transaction, the ref argument was changed to also take a Placeholder as an argument.
The placeholder is tracked by the transaction's file+op queue, and populated with the actual return value of the executed underlying client helper after the client helper operation completes.
In subsequent operations consuming these placeholder values (with now populated values), the placeholder values are unpacked before the client helper execution, which keeps the client helper interface clean.
These details are hidden away from the user, who just proceeds to use commit SHAs as normal. However, printing these placeholders during the transaction will not show the value for obvious reasons.

This means that some interfaces have to be relaxed to allow commits, such as the create_tag interface (specifically, its ref argument).
The tests were adjusted to reflect this new behavior.

cc @janwillemkl

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b9f9ec9) 88.64% compared to head (14f2465) 88.03%.
 Consider uploading reports for the commit 8330d4e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   88.64%   88.03%   -0.61%
==========================================
  Files           6        6
  Lines         405      418      +13
  Branches       57       57
==========================================
+ Hits          359      368       +9
- Misses         27       29       +2
- Partials       19       21       +2

Files
Coverage Δ

src/lakefs_spec/spec.py
86.04% <100.00%> (-0.76%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Deques and other changes in this PR were adopted upstream by fsspec, so a) the ideas we pursue are sound and b) we can eliminate some of our boilerplate again once we require a sufficiently new version of fsspec.


turtlebot cannot drive backwards with joystick

Hi,
I can't really make the robot drive backwards when controlling the turtlebot with the provided joystick, neither in or out of the safety mode. It would drive back maybe 10 cm, then stutter, then drive another 2 cm and then stop completely. After that, the robot refuses to drive backwards entirely. I need to drive forward (or turn) before another backwards drive can be attempted, but the behavior is always the same.
I have not tried driving backwards with other methods, but I wanted to clarify if this is the correct behavior?

How are you disabling the safety? I typically use the webserver to set safety_override to full.

Ah, that was unclear from my side. I meant using L1 or R1 on the controller to drive the robot. From my understanding, L1 is driving with safetly enabled, and R1 is driving without safety.
I have not tried to disable the safety via webserver. But since the driving back problem also exists with safety, I would guess that this is not the main issue?
I might add that after the robot stopps when trying to drive backwards, the LED ring lights up yellow (I think, I'd have to check the exact color again). A similar LED color change happens when the robot is kidnapped, but it seems a bit unlikely that the backwards driving would trigger a kidnap error (which probably uses the wheel suspension for its trigger?).

L1 simply limits driving and turning velocities, while R1 allows for faster speeds. Out of the box the Create 3 will have safety enabled and this needs to be disabled via the webserver to allow backwards driving.
The yellow lightring indicates that the wheels have been stopped. This occurs when you reach the backup limit, kidnap the robot, set the E-Stop, and some other situations.

Ok, thanks. I will try out disablinng the safety and report back if this worked.
Out of curiosity, into which error does the robot run when driving backwards with safety enabled? Is it maybe that the robot doesn't have cliff sensors for safe backwards driving and can only retract a maximal distance (is this what you mean by backup limit)?

Yes, the cliff sensors are located on the front half of the robot and prevent it from falling down. If you disable safety then the cliff reflex will be disabled and the robot can fall down stairs or ledges if you are not careful. If you want to keep safety enabled, you can simply rotate the robot 180 degrees on the spot and drive forwards instead of reversing. Also, the undock action will still allow the robot to reverse from the dock even with safety enabled.

Disabling the safety via the webserver worked. Thanks for your help!


feat: Adding option for repository when cleaning packages

Currently you cannot clean packages under a repository. Only if they belong to the organization.
This is fine, but it is a bit limiting when we have packages like pymapdl/mapdl (At PyMAPDL we do things differently to everybody it seems)
This PR adds the possibility to include the repo where you are cleaning the packages.
Based on:
https://github.com/fastai/ghapi/issues/84

Are you sure this is necessary? In the ansys-internal org we have packages that are linked to the repository, but cleaned by the action nonetheless.

Are you sure this is necessary? In the ansys-internal org we have packages that are linked to the repository, but cleaned by the action nonetheless.

Really? Can you send me the link to those workflows?

I think I know understand your point... But it might be more complicated than just doing this.

For those cases, your package name is actually repo/yourname such that you have pyansys/mapdl... In any case, we should try avoid doing that. Packages should be called ghcr.io/<org>/<package-name> and avoid using / inside <org> or <package-name>. I've experienced issues in the past because of this

Really? Can you send me the link to those workflows?

Summary of "offline" discussion: The packages I had in mind in ansys-internal don't apply, since they are not using an extra / in the package name.

I've experienced issues in the past because of this

Can you expand on this, besides the limitation this PR is trying to address?

I've experienced issues in the past because of this

Can you expand on this, besides the limitation this PR is trying to address?

Yep... see https://github.com/ansys-internal/api-eigen-example/actions/workflows/package_cleanup.yml
I tried in multiple ways to provide it but the way in which the request is parsed somehow dealt poorly with the / sybol. Maybe @germa89's PR will solve this. I need to test it out locally first.

For those cases, your package name is actually repo/yourname such that you have pyansys/mapdl... In any case, we should try avoid doing that. Packages should be called ghcr.io/<org>/<package-name> and avoid using / inside <org> or <package-name>. I've experienced issues in the past because of this

I kind of agree.... I was thinking about leaving ansys/mapdl for the vanilla docker image. And then using ansys/pymapdl/mapdl for a customized version of that docker image for running CICD and/or do development.

I tried in multiple ways to provide it but the way in which the request is parsed somehow dealt poorly with the / sybol. Maybe @germa89's PR will solve this. I need to test it out locally first.

That was the goal (deal with /). It worked for me locally, but I might have missed something. Please test it.
Also we might want to rename the repository argument for something more generic? Just in case someone wants their image to be ansys/ace/mapdl for example. (Or maybe that case should not be covered)

Also we might want to rename the repository argument for something more generic? Just in case someone wants their image to be ansys/ace/mapdl for example. (Or maybe that case should not be covered)

I tend to think we should just use the package-name argument for that, and make it accept names with /. If directly using the ghapi in this way doesn't work, we could just split the argument in our logic.
As far as I understand (might be mistaken..) the / is part of the package name in GHCR's terminology.

I tend to think we should just use the package-name argument for that, and make it accept names with /. If directly using the ghapi in this way doesn't work, we could just split the argument in our logic. As far as I understand (might be mistaken..), pyansys/mapdl is the package name in GHCR's terminology.

I agree with @greschd - let's do the name mangling on the script but accept it as "package-name" directly.

@RobPasMue see my sneak edit above..

Hmm no.. what's the difference between containers that don't render their / on the "packages" list (https://github.com/orgs/ansys/packages) such as pyansys/mapdl, and those that do (see https://github.com/orgs/ansys-internal/packages)?

I do think it's just the name of the package.

@greschd See my also sneak edit above 😄

Soo..... do we approve this or not? XD

Soo..... do we approve this or not? XD
I think having / is interesting. For example we could have pymapdl/mapdl for the docker image for developing on PyMAPDL (we could include the repo, currently we dont). Anyways this could be solved also with mapdl-pymapdl..... so it is not strictly needed.

We should approve it but I need to test it first, sorry... havent gotten to it yet

Getting back to this

The following script "should" work for the following package, but it isn't working. Please provide a token with the required auth.
https://github.com/ansys/api-eigen-example/pkgs/container/api-eigen-example%2Fpython-grpc-server
from datetime import datetime, timedelta
import os

from ghapi.all import GhApi
from ghapi.core import print_summary
from ghapi.page import paged

PACKAGE_TIME_FORMAT = "%Y-%m-%dT%H:%M:%SZ"

org_str = "ansys"
repo_str = "api-eigen-example"
pck_str = "python-grpc-server"
last_days_str = "7"
valid_tags_str = "latest"

last_days = int(last_days_str) if last_days_str != "" else None
valid_tags = [x.strip() for x in valid_tags_str.split(",")]

api = GhApi(debug=print_summary, repo=repo_str, token=os.getenv("PACKAGE_DELETION_TOKEN"))

if last_days:
    delete_before_date = datetime.now() - timedelta(days=last_days)

paged_packages = paged(
    api.packages.get_all_package_versions_for_package_owned_by_org,
    org=org_str,
    package_name=pck_str,
    package_type="container",
    state="active",
    per_page=100,
)

# Loop over all pages
for page in paged_packages:
    for package in page:
        # If keeping last days is requested, then check
        if (
            last_days
            and datetime.strptime(package.created_at, PACKAGE_TIME_FORMAT).timestamp()
            > delete_before_date.timestamp()
        ):
            continue

        # Check if the given package has valid tags
        package_tags = package.metadata.container.tags
        delete = True
        for tag in package_tags:
            if tag in valid_tags:
                delete = False
                break
        # In case it should, delete it
        if delete:
            print(f"Deleting package: {package}")
            api.packages.delete_package_version_for_org(
                org=org_str,
                package_name=pck_str,
                package_type="container",
                package_version_id=package["id"],
            )


WIP: Offload writing kvstore to disk to a secondary thread.

Offload writing kvstore to disk to a secondary thread.
Should take a decent amount of time off of the critical path in large projects when the cache is cold.

Motivation

Speed++
Test plan

Covered by existing tests. One test is currently failing; will fix if this works as expected.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Iw7dzwFSVjy6dT
→ https://go/builds/bui_Iw7dwdJvpfjoOP

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_Iw8IR0Svmp3zbL
→ https://go/builds/bui_Iw8IyWhEFwe1FO

I think this works... but the perf numbers coming out of my development box aren't consistent at the moment and I'm throwing away counters/timers created on this thread. I'll want those counters/timers so I can tell what operations the thread overlaps with.


:sparkles: [WIP] Improve logging of Data creation

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #250

/hold

/ok-to-test

/hold cancel

/assign @fmuyassarov

/test-v1b1-integration
/test-v1b1-centos-integration

/test-v1b1-ubuntu-integration

/test golangci-lint
@chatla-telekom would you be able to commit to this and check the comment from @kashifest

/test golangci-lint @chatla-telekom would you be able to commit to this and check the comment from @kashifest

Sorry I was caught up with internal work. I'll update it and push it today.

@chatla-telekom can you please squash your commits? Otherwise this looks good to me

/test-v1b1-ubuntu-integration

/retitle :seedling: Improve logging of Data creation

/hold
@chatla-telekom can you please rebase on top of main?

the rebase was not correctly done it seems

the rebase was not correctly done it seems

Yeah I'm fixing it :smile:

/lgtm
/test-v1b1-ubuntu-integration
Adding lgtm since rebasing removed it.

/test-v1b1-ubuntu-integration


Error on plot_topo_timecourse() following PR #88

The new way of integrating conditions in the plot_topo_timecourse() function breaks previous workflow.
When calling
hmp.visu.plot_bootstrap_results(bootstrapped, info, init_accuracy,
                               epoch_data = accuracy_epoch)

It results in an error
File ~/owncloud/projects/RUGUU/hsmm-mvpy/src/hsmm_mvpy/visu.py:197, in plot_topo_timecourse(channels, estimated, channel_position, init, conds, time_step, ydim, figsize, dpi, magnify, times_to_display, cmap, ylabels, xlabel, max_time, vmin, vmax, title, ax, sensors, skip_channels_computation, contours, event_lines, colorbar, topo_size_scaling)
    195 for iteration in np.arange(n_iter):
    196     times_iteration = times[iteration]*time_step
--> 197     channels_ = channels[iteration,:,:] if not cond_plot else channels[iteration]
    198     n_event = int(sum(np.isfinite(channels_[:,0])))
    199     channels_ = channels_[:n_event,:]

IndexError: too many indices for array: array is 2-dimensional, but 3 were indexed

The fix shouldn't be too complex and I will take a look soon but @jelmerborst you might see where that comes from more easily?

You're not working with the latest code, though I'm not sure that's the problem.

OK I'll update and will check whether your latest commit happens to fix that
On Tue, 5 Sept 2023 at 11:38, Jelmer Borst @.***> wrote:

You're not working with the latest code, though I'm not sure that's the
problem.
—
Reply to this email directly, view it on GitHub
https://github.com/GWeindel/hsmm_mvpy/issues/89#issuecomment-1706280771,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3LE57RCEBZOLAFHSGL4QTXY3XILANCNFSM6AAAAAA4LPMNC4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Fix oneof defaults

Reasons for making this change
Fixes #1293, Fixes #1229
Checklist

[ ] I'm updating documentation

[ ] I've checked the rendering of the Markdown text I've added

[x] I'm adding or updating code

[x] I've added and/or updated tests
[x] I've updated docs if needed
[x] I've run npm run cs-format on my branch to conform my code to prettier coding style

[ ] I'm adding a new feature

[ ] I've updated the playground with an example use of the feature

Actually #1293 is not fixed completely yet, working on it


Class Barryvdh\LaravelIdeHelper\ModelsCommand located in ./vendor/barryvdh/laravel-ide-helper/src/Barryvdh/LaravelIdeHelper/ModelsCommand.php does not comply with psr-4 autoloading standard.

I'm getting this warning during composer dump-autoload --optimize with composer v 1.10.1

Class Barryvdh\LaravelIdeHelper\ModelsCommand located in ./vendor/barryvdh/laravel-ide-helper/src/Barryvdh/LaravelIdeHelper/ModelsCommand.php does not comply with psr-4 autoloading standard.  It will not autoload anymore in Composer v2.0. in /usr/share/php/Composer/Autoload/ClassMapGenerator.php:201

Is there anything I can do to fix this?

I can't reproduce this (using composer 1.10.1 and 2.6.7).
Are you on the latest version https://github.com/barryvdh/laravel-ide-helper/releases/tag/v2.6.7 ?

Sorry to bug you. Updating to 1.9 fixed the message.

Great! Please close the issue, thanks

@barryvdh nothing to do here anymore, issue can be closed :}


pull request for e2e test at 01/16/2017 21:15:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Replace test files with "lorem ipsum"

Some of the test files contain text from OSS Gadget files, including some fragments containing 'MD5':
https://github.com/microsoft/RecursiveExtractor/search?q=md5
While this isn't a security risk, it'll show up in automated scans, so we should switch out those files for "Lorem Ipsum" type text, since the content doesn't matter.

Fixed by #44


Fix some info

Signed-off-by: zhouhao<EMAIL_ADDRESS>

LGTM. As an aside, I would recommend having more descriptive commit messages. For example, I would name your commit something like docs: update references to tool name and invocation.

@cyphar Thanks for your advice, I did not pay attention to these things before.

LGTM. Thanks.

LGTM


docs: add scatterplot

💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #90   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          102       102
  Lines         1137      1137
  Branches       327       327
=========================================
  Hits          1137      1137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ec67...0b03137. Read the comment docs.


chore: Use docker volume instead of file system for postgres

I was stumbling over this error when starting the maker.
2023-03-08 10:12:46 ERROR r2d2: connection to server at "localhost" (::1), port 5432 failed: FATAL:  database "maker" does not exist

It appears I had an old postgresql database state on the filesystem which had to be cleared so that the init script will be executed again.
Although this is a workable solution, it's nicer to mount the postgres data into a docker volume instead the file system. This way a simple docker-compse down -v will also clear the postgres volume.

I'm fine with this but the effect is the same: you either have to delete the postgres volume or the pgdata folder.

It is the same effect, but as mentioned, it's one command less :)

Can you also update gitignore please? We are currently ignoring pgdata and this is unnecessary now :)

Yes, I can do that, I was just thinking it doesn't hurt and it would be less annoying for everyone, as they wouldn't see a dirty workspace after catching up to this change. But you're right, it's not needed, I am going to remove it from the gitignore.

bors r+


Either monad hints

either throwE pure ==> liftEither.

liftEither is only available in mtl, and transformers is preferred to mtl, so not going to add this hint.


Making distinction between visual and gestural domains with a notationtype.ges attribute

In some cases, it can be desirable to make the distinction between the visual and the gestural domains regarding the notation type as given in staffDef@notationtype. It can be the case when dealing with notations from transition phases in music history, for example between mensural to cmn. One might want to have the visual domain of one notation type, but having the gestural domain of another. This would require to add a<EMAIL_ADDRESS>attribute. Then it would be possible to do:
<staffDef notationtype="mensural" notationtype.ges="cmn"/>

to force a mensural staff to be calculated as a CMN, but still visually rendered as mensural, and
<staffDef notationtype="tab" notationtype.ges="mensural"/>

to force a tablature staff to be calculated as mensural (and not cmn, which is probably the default for tab in general).

Do we need (more) discussion on this? If there is not objection I will make a PR.

See my initial comments over in #645.


Sets the installed profile name from sigh in an environment variable …

…and lane context
Why
Because we used to need the UUID in the past for really ugly reasons but now Xcode likes the have the name so yolo
Example Usage
sigh
profile_name = Actions.lane_context[SharedValues::SIGH_NAME]

fastlane_require 'xcodeproj'
project_path = File.absolute_path File.join(path, "MyProject.xcodeproj")
xcproj = Xcodeproj::Project.open(project_path)
xcproj.targets.each do |target|
  target.build_configuration_list.set_setting 'PROVISIONING_PROFILE_SPECIFIER', profile_name
end
xcproj.save

@jdee That's so cool! Had no idea 😇


⚠ Bofrost.es has degraded performance

In 3ea02a9, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1703 ms

Resolved: Bofrost.es performance has improved in dc59483 after 13 minutes.


"Failed to Fetch Chat Response" on File Only

The general chat section of the page works without issue.  If I go to the files section and try to chat I get the error "Failed to Fetch Chat Response".
When trying to upload a file to the page I get the error "looks like not all documents were indexed".  Its a a single page PDF I am testing with.
Anyone have these issues with the file portion of the page?

Hey @jwwillman, has this worked for you previously, and is now broken? Or is this a fresh install, and it hasn't worked since? A couple of things I usually do to fix random issues like this include verifying all settings in the Web App Configuration settings, and ensuring the Document Intelligence service is provisioned and is receiving content. Lastly, check the token limit settings in AOAI instance.


Failure to install under Windows Subsystem Linux (WSL 2) and Debian 11

Trying to install into Windows WSL 2 Debian v11 (Bullseye) on a new dev machine where I'm trying to keep a lot in WSL.
It fails with
WARNING: seems you still have not added 'pyenv' to the load path.
Then a stack trace:
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
/home/napland/.pyenv/bin/pyenv: line 3: $'\r': command not found
/home/napland/.pyenv/bin/pyenv: line 15: syntax error near unexpected token `$'{\r''
'home/napland/.pyenv/bin/pyenv: line 15: `abort() {
: invalid optionyenv/bin/pyenv: line 2: set: -
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
/home/napland/.pyenv/bin/pyenv: line 3: $'\r': command not found
/home/napland/.pyenv/bin/pyenv: line 15: syntax error near unexpected token `$'{\r''
'home/napland/.pyenv/bin/pyenv: line 15: `abort() {

Seems something's afoot.
Any ideas?
Thanks

Here's the full log with my installation method.
napland@BigDaddy:/mnt/d/Repos$ sudo apt-get update; sudo apt-get install make build-essential libssl-dev zlib1g-dev \
libbz2-dev libreadline-dev libsqlite3-dev wget curl llvm \
libncursesw5-dev xz-utils tk-dev libxml2-dev libxmlsec1-dev libffi-dev liblzma-dev

Get:1 http://security.debian.org/debian-security bullseye-security InRelease [44.1 kB]
Get:2 http://ftp.debian.org/debian bullseye-backports InRelease [39.3 kB]
Hit:3 http://deb.debian.org/debian bullseye InRelease
Get:4 http://deb.debian.org/debian bullseye-updates InRelease [36.8 kB]
Get:5 http://security.debian.org/debian-security bullseye-security/main amd64 Packages [29.4 kB]
Get:6 http://security.debian.org/debian-security bullseye-security/main Translation-en [15.7 kB]
Fetched 165 kB in 3s (57.5 kB/s)
Reading package lists... Done
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
build-essential is already the newest version (12.9).
libbz2-dev is already the newest version (1.0.8-4).
curl is already the newest version (7.74.0-1.3+b1).
libffi-dev is already the newest version (3.3-6).
llvm is already the newest version (1:11.0-51+nmu5).
make is already the newest version (4.3-4.1).
libncursesw5-dev is already the newest version (6.2+20201114-2).
libreadline-dev is already the newest version (8.1-1).
libsqlite3-dev is already the newest version (3.34.1-3).
tk-dev is already the newest version (8.6.11+1).
wget is already the newest version (1.21-1+b1).
liblzma-dev is already the newest version (5.2.5-2).
xz-utils is already the newest version (5.2.5-2).
zlib1g-dev is already the newest version (1:1.2.11.dfsg-2).
libssl-dev is already the newest version (1.1.1k-1+deb11u1).
The following additional packages will be installed:
  icu-devtools libevent-2.1-7 libgcrypt20-dev libgmp-dev libgmpxx4ldbl libgnutls-dane0
  libgnutls-openssl27 libgnutls28-dev libgnutlsxx28 libgpg-error-dev libicu-dev libidn2-dev libnspr4
  libnspr4-dev libnss3 libnss3-dev libp11-kit-dev libtasn1-6-dev libtasn1-doc libunbound8 libxmlsec1
  libxmlsec1-gcrypt libxmlsec1-gnutls libxmlsec1-nss libxmlsec1-openssl libxslt1-dev libxslt1.1
  nettle-dev
Suggested packages:
  libgcrypt20-doc gmp-doc libgmp10-doc libmpfr-dev dns-root-data gnutls-bin gnutls-doc icu-doc
The following NEW packages will be installed:
  icu-devtools libevent-2.1-7 libgcrypt20-dev libgmp-dev libgmpxx4ldbl libgnutls-dane0
  libgnutls-openssl27 libgnutls28-dev libgnutlsxx28 libgpg-error-dev libicu-dev libidn2-dev libnspr4
  libnspr4-dev libnss3 libnss3-dev libp11-kit-dev libtasn1-6-dev libtasn1-doc libunbound8 libxml2-dev
  libxmlsec1 libxmlsec1-dev libxmlsec1-gcrypt libxmlsec1-gnutls libxmlsec1-nss libxmlsec1-openssl
  libxslt1-dev libxslt1.1 nettle-dev
0 upgraded, 30 newly installed, 0 to remove and 0 not upgraded.
Need to get 20.4 MB of archives.
After this operation, 80.9 MB of additional disk space will be used.
Do you want to continue?
(Reading database ... 39904 files and directories currently installed.)
Preparing to unpack .../00-icu-devtools_67.1-7_amd64.deb ...
Unpacking icu-devtools (67.1-7) ...
Selecting previously unselected package libevent-2.1-7:amd64.
Preparing to unpack .../01-libevent-2.1-7_2.1.12-stable-1_amd64.deb ...
Unpacking libevent-2.1-7:amd64 (2.1.12-stable-1) ...
Selecting previously unselected package libgpg-error-dev.
Preparing to unpack .../02-libgpg-error-dev_1.38-2_amd64.deb ...
Unpacking libgpg-error-dev (1.38-2) ...
Selecting previously unselected package libgcrypt20-dev.
Preparing to unpack .../03-libgcrypt20-dev_1.8.7-6_amd64.deb ...
Unpacking libgcrypt20-dev (1.8.7-6) ...
Selecting previously unselected package libgmpxx4ldbl:amd64.
Preparing to unpack .../04-libgmpxx4ldbl_2%3a6.2.1+dfsg-1_amd64.deb ...
Unpacking libgmpxx4ldbl:amd64 (2:6.2.1+dfsg-1) ...
Selecting previously unselected package libgmp-dev:amd64.
Preparing to unpack .../05-libgmp-dev_2%3a6.2.1+dfsg-1_amd64.deb ...
Unpacking libgmp-dev:amd64 (2:6.2.1+dfsg-1) ...
Selecting previously unselected package libunbound8:amd64.
Preparing to unpack .../06-libunbound8_1.13.1-1_amd64.deb ...
Unpacking libunbound8:amd64 (1.13.1-1) ...
Selecting previously unselected package libgnutls-dane0:amd64.
Preparing to unpack .../07-libgnutls-dane0_3.7.1-5_amd64.deb ...
Unpacking libgnutls-dane0:amd64 (3.7.1-5) ...
Selecting previously unselected package libgnutls-openssl27:amd64.
Preparing to unpack .../08-libgnutls-openssl27_3.7.1-5_amd64.deb ...
Unpacking libgnutls-openssl27:amd64 (3.7.1-5) ...
Selecting previously unselected package libgnutlsxx28:amd64.
Preparing to unpack .../09-libgnutlsxx28_3.7.1-5_amd64.deb ...
Unpacking libgnutlsxx28:amd64 (3.7.1-5) ...
Selecting previously unselected package libidn2-dev:amd64.
Preparing to unpack .../10-libidn2-dev_2.3.0-5_amd64.deb ...
Unpacking libidn2-dev:amd64 (2.3.0-5) ...
Selecting previously unselected package libp11-kit-dev:amd64.
Preparing to unpack .../11-libp11-kit-dev_0.23.22-1_amd64.deb ...
Unpacking libp11-kit-dev:amd64 (0.23.22-1) ...
Selecting previously unselected package libtasn1-6-dev:amd64.
Preparing to unpack .../12-libtasn1-6-dev_4.16.0-2_amd64.deb ...
Unpacking libtasn1-6-dev:amd64 (4.16.0-2) ...
Selecting previously unselected package nettle-dev:amd64.
Preparing to unpack .../13-nettle-dev_3.7.3-1_amd64.deb ...
Unpacking nettle-dev:amd64 (3.7.3-1) ...
Selecting previously unselected package libgnutls28-dev:amd64.
Preparing to unpack .../14-libgnutls28-dev_3.7.1-5_amd64.deb ...
Unpacking libgnutls28-dev:amd64 (3.7.1-5) ...
Selecting previously unselected package libicu-dev:amd64.
Preparing to unpack .../15-libicu-dev_67.1-7_amd64.deb ...
Unpacking libicu-dev:amd64 (67.1-7) ...
Selecting previously unselected package libnspr4:amd64.
Preparing to unpack .../16-libnspr4_2%3a4.29-1_amd64.deb ...
Unpacking libnspr4:amd64 (2:4.29-1) ...
Selecting previously unselected package libnspr4-dev.
Preparing to unpack .../17-libnspr4-dev_2%3a4.29-1_amd64.deb ...
Unpacking libnspr4-dev (2:4.29-1) ...
Selecting previously unselected package libnss3:amd64.
Preparing to unpack .../18-libnss3_2%3a3.61-1_amd64.deb ...
Unpacking libnss3:amd64 (2:3.61-1) ...
Selecting previously unselected package libnss3-dev:amd64.
Preparing to unpack .../19-libnss3-dev_2%3a3.61-1_amd64.deb ...
Unpacking libnss3-dev:amd64 (2:3.61-1) ...
Selecting previously unselected package libtasn1-doc.
Preparing to unpack .../20-libtasn1-doc_4.16.0-2_all.deb ...
Unpacking libtasn1-doc (4.16.0-2) ...
Selecting previously unselected package libxml2-dev:amd64.
Preparing to unpack .../21-libxml2-dev_2.9.10+dfsg-6.7_amd64.deb ...
Unpacking libxml2-dev:amd64 (2.9.10+dfsg-6.7) ...
Selecting previously unselected package libxslt1.1:amd64.
Preparing to unpack .../22-libxslt1.1_1.1.34-4_amd64.deb ...
Unpacking libxslt1.1:amd64 (1.1.34-4) ...
Selecting previously unselected package libxmlsec1:amd64.
Preparing to unpack .../23-libxmlsec1_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1:amd64 (1.2.31-1) ...
Selecting previously unselected package libxmlsec1-gcrypt:amd64.
Preparing to unpack .../24-libxmlsec1-gcrypt_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1-gcrypt:amd64 (1.2.31-1) ...
Selecting previously unselected package libxmlsec1-gnutls:amd64.
Preparing to unpack .../25-libxmlsec1-gnutls_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1-gnutls:amd64 (1.2.31-1) ...
Selecting previously unselected package libxmlsec1-nss:amd64.
Preparing to unpack .../26-libxmlsec1-nss_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1-nss:amd64 (1.2.31-1) ...
Selecting previously unselected package libxmlsec1-openssl:amd64.
Preparing to unpack .../27-libxmlsec1-openssl_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1-openssl:amd64 (1.2.31-1) ...
Selecting previously unselected package libxslt1-dev:amd64.
Preparing to unpack .../28-libxslt1-dev_1.1.34-4_amd64.deb ...
Unpacking libxslt1-dev:amd64 (1.1.34-4) ...
Selecting previously unselected package libxmlsec1-dev.
Preparing to unpack .../29-libxmlsec1-dev_1.2.31-1_amd64.deb ...
Unpacking libxmlsec1-dev (1.2.31-1) ...
Setting up libgnutls-openssl27:amd64 (3.7.1-5) ...
Setting up libtasn1-doc (4.16.0-2) ...
Setting up libgmpxx4ldbl:amd64 (2:6.2.1+dfsg-1) ...
Setting up libgpg-error-dev (1.38-2) ...
Setting up libnspr4:amd64 (2:4.29-1) ...
Setting up libevent-2.1-7:amd64 (2.1.12-stable-1) ...
Setting up icu-devtools (67.1-7) ...
Setting up libgnutlsxx28:amd64 (3.7.1-5) ...
Setting up libidn2-dev:amd64 (2.3.0-5) ...
Setting up libxslt1.1:amd64 (1.1.34-4) ...
Setting up libxmlsec1:amd64 (1.2.31-1) ...
Setting up libtasn1-6-dev:amd64 (4.16.0-2) ...
Setting up libicu-dev:amd64 (67.1-7) ...
Setting up libp11-kit-dev:amd64 (0.23.22-1) ...
Setting up libnspr4-dev (2:4.29-1) ...
Setting up libgmp-dev:amd64 (2:6.2.1+dfsg-1) ...
Setting up nettle-dev:amd64 (3.7.3-1) ...
Setting up libxmlsec1-openssl:amd64 (1.2.31-1) ...
Setting up libnss3:amd64 (2:3.61-1) ...
Setting up libxml2-dev:amd64 (2.9.10+dfsg-6.7) ...
Setting up libunbound8:amd64 (1.13.1-1) ...
Setting up libgcrypt20-dev (1.8.7-6) ...
Setting up libxmlsec1-gcrypt:amd64 (1.2.31-1) ...
Setting up libxmlsec1-nss:amd64 (1.2.31-1) ...
Setting up libnss3-dev:amd64 (2:3.61-1) ...
Setting up libxmlsec1-gnutls:amd64 (1.2.31-1) ...
Setting up libgnutls-dane0:amd64 (3.7.1-5) ...
Setting up libxslt1-dev:amd64 (1.1.34-4) ...
Setting up libgnutls28-dev:amd64 (3.7.1-5) ...
Setting up libxmlsec1-dev (1.2.31-1) ...
Processing triggers for libc-bin (2.31-13) ...

napland@BigDaddy:/mnt/d/Repos$ sudo curl https://pyenv.run | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   270  100   270    0     0    825      0 --:--:-- --:--:-- --:--:--   825
Cloning into '/home/napland/.pyenv'...
remote: Enumerating objects: 777, done.
remote: Counting objects: 100% (777/777), done.
remote: Compressing objects: 100% (402/402), done.
remote: Total 777 (delta 426), reused 495 (delta 278), pack-reused 0
Receiving objects: 100% (777/777), 413.52 KiB | 3.69 MiB/s, done.
Resolving deltas: 100% (426/426), done.
Cloning into '/home/napland/.pyenv/plugins/pyenv-doctor'...
remote: Enumerating objects: 11, done.
remote: Counting objects: 100% (11/11), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 11 (delta 1), reused 5 (delta 0), pack-reused 0
Receiving objects: 100% (11/11), 38.64 KiB | 1.10 MiB/s, done.
Resolving deltas: 100% (1/1), done.
Cloning into '/home/napland/.pyenv/plugins/pyenv-installer'...
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 16 (delta 1), reused 7 (delta 0), pack-reused 0
Receiving objects: 100% (16/16), 5.75 KiB | 5.75 MiB/s, done.
Resolving deltas: 100% (1/1), done.
Cloning into '/home/napland/.pyenv/plugins/pyenv-update'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 10 (delta 1), reused 5 (delta 0), pack-reused 0
Receiving objects: 100% (10/10), done.
Resolving deltas: 100% (1/1), done.
Cloning into '/home/napland/.pyenv/plugins/pyenv-virtualenv'...
remote: Enumerating objects: 57, done.
remote: Counting objects: 100% (57/57), done.
remote: Compressing objects: 100% (51/51), done.
remote: Total 57 (delta 11), reused 22 (delta 0), pack-reused 0
Receiving objects: 100% (57/57), 35.39 KiB | 1.47 MiB/s, done.
Resolving deltas: 100% (11/11), done.
Cloning into '/home/napland/.pyenv/plugins/pyenv-which-ext'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 10 (delta 1), reused 6 (delta 0), pack-reused 0
Receiving objects: 100% (10/10), done.
Resolving deltas: 100% (1/1), done.

WARNING: seems you still have not added 'pyenv' to the load path.

: invalid optionyenv/bin/pyenv: line 2: set: -
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
/home/napland/.pyenv/bin/pyenv: line 3: $'\r': command not found
/home/napland/.pyenv/bin/pyenv: line 15: syntax error near unexpected token `$'{\r''
'home/napland/.pyenv/bin/pyenv: line 15: `abort() {
: invalid optionyenv/bin/pyenv: line 2: set: -
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
/home/napland/.pyenv/bin/pyenv: line 3: $'\r': command not found
/home/napland/.pyenv/bin/pyenv: line 15: syntax error near unexpected token `$'{\r''
'home/napland/.pyenv/bin/pyenv: line 15: `abort() {
napland@BigDaddy:/mnt/d/Repos$

Similar happens for me with Ubuntu 20.04 under wsl, the tail of the output is:
Cloning into '/home/richard/.pyenv/plugins/pyenv-which-ext'...
remote: Enumerating objects: 10, done.
remote: Counting objects: 100% (10/10), done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 10 (delta 1), reused 6 (delta 0), pack-reused 0
Unpacking objects: 100% (10/10), 2.92 KiB | 995.00 KiB/s, done.

WARNING: seems you still have not added 'pyenv' to the load path.

/usr/bin/env: ‘bash\r’: No such file or directory
/usr/bin/env: ‘bash\r’: No such file or directory

Ok this is due to line endings. I switched off autocrlf and it worked:
git config --global core.autocrlf false


✨ Allow writing plain CSS in playground

Clear and concise description of the problem
We don't have an editor to write raw CSS in the playground for providing a reproducible examples. We do have preflight option but providing separate CSS panel is more convenient just like tailwind:

reproducible examples
Suggested solution
Provide a separate CSS panel just like "Ouput CSS"
Alternative
Using Tailwind Playground for now
Additional context
N/A
Validations

[X] Read the Contributing Guidelines.
[X] Read the README.md of using the package.
[X] Already used the Interactive Docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I would like to make it happen. I might need some advice on the UI panel.
/cc @antfu


Adds MacOS Sequoia

This MR adds the MacOS 15 "Sequoia" name

I am really confused right now... Sequoia has already been added in #171, yet it still says in this MR it is not yet added. I'm just going to close this again...


Cannot create masked/rounded image from Figma

Describe the bug
I need to use a rounded/circular image in my layout but after sending it to after effects it becomes rectangular.
To Reproduce
I've tried several different approaches:

A circle with an image as background
A circular mask
A rectangular mask using rounded corners
A frame with clipping and rounded corners

Expected behavior
An image which is circular in Figma should look the same in After Affects.
Version: 0.7.5a

I've run into a similar issue with the rounded corners on a rectangle shape. My current workaround is to "Copy as SVG" into Illustrator then use @adamplouff  Overlord plugin which I already own to export that shape into AE. It copies the path directly into a selected shape layer.
Wondering if a new feature could be implemented to skip the Illustrator go between.

I've run into a similar issue with the rounded corners on a rectangle shape. My current workaround is to "Copy as SVG" into Illustrator then use @adamplouff  Overlord plugin which I already own to export that shape into AE. It copies the path directly into a selected shape layer.
Wondering if a new feature could be implemented to skip the Illustrator go between.


config: Move valid-value rules to their own section

This wording just landed via #673, but the rule is generic and not unique to platform-specific properties.
Also adjust the wording somewhat to match the more established wording from the “Extensibility” section.

I think the original wording is much more straightforward and easier to understand than the changes in this PR.

LGTM

LGTM


CSV Export Loses Global Sort Order Due to Using Chunks (Observed with PostgreSQL)

Package
filament/filament
Package Version
v3.2.116
Laravel Version
v11.29.0
Livewire Version
v3.5.12
PHP Version
PHP 8.2.22
Problem description
When exporting data to CSV using Filament's Export action, the global sorting order is not maintained when the data is processed in chunks. This issue has been observed with PostgreSQL under these conditions:

The chunk size is smaller than the total number of records
Any sort order is applied, whether through:

Custom sort via modifyQueryUsing()
Default table sort configuration
User-triggered column sorting in the Filament table

Importantly, the sorting works correctly when the chunk size is larger than the total number of records, confirming this is specifically a chunking issue rather than a general sorting problem.
Current workaround:

Setting the chunk size larger than the total number of records resolves the issue
However, this is not a scalable solution for large datasets

Additional context:
The issue appears to be related to how ORDER BY clauses are handled during chunked queries. The fact that the sorting works correctly when processing all records in a single chunk suggests that the chunking mechanism isn't properly maintaining the global sort order when splitting the data.
This affects all sorting methods available in Filament:

Default table sorting
Interactive column sorting
Custom query modifications

This might require either:

A modification to how chunks are processed to maintain global order
A database-specific implementation of the chunking strategy
A warning in the documentation about this limitation

Environment:

Database: PostgreSQL 14.x
Records: Works correctly when chunk size > total records
Sorting: Affects all available sorting methods in Filament

Expected behavior
The CSV export should maintain a consistent global sort order regardless of:

The chunk size used
The total number of records
How the sort order was specified (default table sort, column sorting, or custom sort)
The specific sort order applied

The chunking process should preserve the global ordering while still allowing for efficient processing of large datasets.
Steps to reproduce
See ReadMe in Reproduction repository.
Reproduction repository (issue will be closed if this is not valid)
https://github.com/kaspernowak/filament-issue
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

I will write about what I have discovered through my investigation.
I analyzed the SQL queries executed by MySQL and PostgreSQL. Please note that the investigation is still ongoing.
I will update this document as progress is made.
First, regarding the differences in the SQL queries executed by MySQL and PostgreSQL:
It was observed that PostgreSQL performs an ORDER BY using the id. As a result, it seems to sort by chunks.
-- MySQL
SELECT DISTINCT * FROM `patients` WHERE `patients`.`is_valid` = true ORDER BY `name` ASC LIMIT 100 OFFSET 0;
-- PostgreSQL
SELECT DISTINCT ON ("patients"."id") * FROM "patients" WHERE "patients"."is_valid" = true ORDER BY "name" ASC LIMIT 100 OFFSET 0;

Since I don't have much time, I will proceed with the investigation gradually and report my findings.

I submitted a pull request to fix the issue in #15181.
The PostgreSQL SQL now looks like this:
-- before
select distinct on ("patients"."id") * from "patients" where "patients"."is_valid" = true order by "patients"."id" asc, "name" asc limit 100 offset 0

-- after
select * from "patients" where "patients"."is_valid" = true order by "name" asc limit 100 offset 0

I hope this resolves the issue.


Time Range selection for backup does not work for Chrome

It works for Safari and FireFox, not Chrome

Looks like Chrome is more pedantic about type="date" than FF is...
I'll just switch them to type="text", since we built our own date picker anyway...


Cannot save diagram as external image

System information:

Microsoft Windows 10 Pro Version	10.0.17134 Build 17134
DBeaver <IP_ADDRESS>901202008
Java version 1.8.0_201 64 bit

Connection specification:

MapR distribution with Apache Drill and Hive db
I have vpn of client company which we're working on a project (we use OpenVPN to connect)

Describe the problem you're observing:
I need to get ER diagram of a Hive database (very large), so I double click on the db and it visualizes the tables : I click on export diagram as image, but every time it prompt
**

No more handles [GetLastError=0x57]

**
I don't have any logs or error to show.
Tried to add -vmargs -Xms500m at the path, but it didn't solve nothing.
any help please?

This happens because of too big image. It has to fit in memory. Big diagrams (thousands of tables, say 100k x 100k dots) may produce raster image sized in tens of gigs..

Workaround is to save diagram as SVG and then export SVG to raster image on some 3rd party image editor.

This is still an issue.
Windows 10
DBeaver version <IP_ADDRESS>001051908
160 objects in schema

Still an issue, what can I do.. not even png is being saved

Still an issue 👀

Still an issue :'(

Still an issue

using version 7.3, still an issue,,

Using Version 22.0.1, still an issue.

still, save diagram as >224 tables and dbveaver frozen

Using 24.1.202406231636, still an issue.


Provide example of custom click handler for marker InfoWindow

Issue Type
[ ] Improvement
Description and/or steps/code to reproduce the problem
Would it be possible to update the documentation to include examples of creating a marker InfoWindow with a custom onClick event?  Or even expose a method on either InfoWindow or BasicInfoWindow to set a click handler?
Version of osmdroid the issue relates to:
6.0.1

nice avatar! sure


[WFCORE-5409]: Upgrade JGit to <IP_ADDRESS>105131744-r

upgrading JGit to <IP_ADDRESS>105131744-r
upgrading Apache SSH to 2.6.0

Jira: https://issues.redhat.com/browse/WFCORE-5409

@ehsavoie FYI the test failures on this one appear directly related to the component upgrade.

@ehsavoie thanks


[stable/traefik] storeconfig job is not removed when release is deleted

Is this a request for help?:
No
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug report

Version of Helm and Kubernetes:
Helm 2.12.3
Kubernetes Client 1.13.0
Kubernetes Server 1.12.5-gke.5
Which chart:
stable/traefik
What happened:
When running helm del --purge my-release, the storeconfig jobs remained. When subsequently running helm upgrade, it failed, as the jobs were still present, and a new job could not be created with the name.
What you expected to happen:
I expected the storeconfig jobs to be removed as part of helm delete
How to reproduce it (as minimally and precisely as possible):
helm install stable/traefik --name my-release --set kvprovider.consul.endpoint="consul:8500",kvprovider.consul.prefix=traefik
helm delete --purge my-release
helm install stable/traefik --name my-release --set kvprovider.consul.endpoint="consul:8500",kvprovider.consul.prefix=traefik

Anything else we need to know:
This relates to, but is not the same as, #11766

This is a a Problem of Helm itself. Resources created by Hooks are not managed by Helm, so also not removed after purging the Chart.
Same applies to CRDs created by a Chart. In order to remove the Chart completely you have to:
helm delete --purge my-release
kubectl delete all -l app=traefik

Another way to work around this would be removing the Job on success which without further research should work.

@alwinmarkcf indeed, removing it upon success works. However, another way to approach it would be to have a single job that's part of the template, rather than hook-controlled. The downside of that is that you would only ever have the logs of the most recent job available, but it would mean that the job would get removed when deleting the release.


MicroBuild v2: Fix logic in run_build.ps1 to correctly use the provided value of $binpath if it is provided.

Thanks @abodalevsky for pointing this out.

@tcare would you mind reviewing this logic change quickly? @boingoing is out sick

Looks good


Add new versions of gateway-api manifests (1.2.0)

Hey @JuniorJPDJ Im on vacation for the next 2 weeks but Ill take a peek at this when I get back.
If you want to give it a try yourself in the meantime, adding new manifests is pretty easy.

Copy the CRD's into this directory: ETL/crds
Run yarn etl
Add the version to: lib/oaspec.tsx
Open a PR :)

thanks! I'll do that!


Make the editor fully-fledged, for code completion, just like vs code

Code formatting feature and more. I need to be more productive!!

Hello there,
This has been discussed in the past. However, including code formatting/completion/intellisense has two main downfalls:

Overwhelms some campers when they are just getting started
Decreases the effectiveness of learning the syntax, and debugging code. Campers learn much more effectively, if they are required to type everything out.

If this bothers you, you are welcome to complete the challenges in your own environment, and copy-paste to submit.
I will leave this up for others to weigh in.

I  understand the desire for this, but I'd agree with @Sky020. If you're just learning the syntax, autocompletion is not going to help. Students need to try and recall themselves, as 'Active Recall' is important for committing to long-term memory.

Thanks for reporting and requesting this feature.
We do not have plans for changing the editor behavior for reasons that others have mentioned.
Happy coding.


Update deps

For personal preference, I've updated almost all dependencies to the latest.
Appearently it works, so I'll make it a pull request so that you can merge this.

Thanks, I'll merge this, however please note

The website is exceeding vercel's free usage tier, they not turn down the website going forward

Since the game now introduce 一括掃討, persoanlly I'm not using this tool anymore.

Due to these reasons, I might consider shut down the website in near future 😔 I'll merge your pr but I'm not planning to release a new version for it.

Thank you for mantaining this tool. But sorry, this pr fails to build because I couldn't fix the error that crashes with Assertion failed message from libuv. And I don't know why it happens. So I recommend to revert this.
About edge requests, the current cache control for equipment images is:
cache-control: public, max-age=0, must-revalidate

So, once the page is loaded, 100+ image (revalidation) requests are occured.
Instead of specifying public/* to the src, importing and passing them to the src returns this responce:
cache-control: public, max-age=315360000, immutable

I think this helps to reduce edge requests. But I'm not sure that it is a good solution because I couldn't find any example of importing many images like this, though.
And it appears that equipments.json and campaigns.json are also fetched for each mount. It also can be fixed by specifing appropriate cache-control. I'll make pr about them later.
Indeed "一括掃討" is useful, but I think this tool is still useful to manage TODOs and stock of pieces.

Thanks, let me think about it(Can probably transfer the maintainer to the community if people still find it useful).


Light2D texture ignored when using canvasitem light shader

Godot version
4.1.1-stable
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (NVIDIA; <IP_ADDRESS>5) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
Issue description
Canvasitem light shader process ignores light2d textures and only uses their bounding box to determine if a pixel is lit or not. In this example the light is circular, but it's treated as square when covering the object using a shader.

Steps to reproduce
Make a PointLight2D. Overlap it with a Sprite2D with this shader as material:
shader_type canvas_item;
render_mode blend_mix;

void light()
{LIGHT = texture(TEXTURE,UV);}

Minimal reproduction project
LightTestProject.zip

Does changing the light shader to this help? LIGHT is both input and output and you overwrite it completely instead of modifying it.
void light()
{
	LIGHT = LIGHT * texture(TEXTURE,UV);
}

Does changing the light shader to this help? LIGHT is both input and output and you overwrite it completely instead of modifying it.

It doesn't. The light() function works just like fragment(), but for pixels that are lit up. It clearly only partially works, since only pixels inside the light's bounding box are affected. Using the light_only render mode (as seen on the grass in the example pic) does accurately work as intended, but that forces all unshaded pixels to be invisible, which is very limiting.

Looks like the altas is wrong：

The root cause seems like the name TEXTURE is not treated well when inside light function, or let's say it will make user confuse.
As you see the left is the normal one with the default shader (correct version) , right is the provided custom shader (the broken one).

The left uses vec4 light_color = textureLod(atlas_texture, tex_uv_atlas, 0.0); to sample light texture and it's correctly set as the light  texture:

The right uses light=texture(color_texture, uv); in light_compute and color_texture is the item's own color texture:

The shader appears to work as intended. TEXTURE is the same texture used in the fragment function. It is not the light's texture. Light shader's don't expose the light's texture instead they expose the light's color per-pixel with LIGHT_COLOR.
LIGHT = texture(TEXTURE,UV); will do exactly as the OP shows, it mixes the color of the CanvasItem's texture with itself (in the region of the light).
There isn't a bug here. The docs on CanvasItem shaders also explain this nicely https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/canvas_item_shader.html#light-built-ins

Even if you use LIGHT = LIGHT_COLOR, the behavior is the same (light texture is not correctly taken into account). The "region of the light" is a rectangle that ignores the shape of the light texture. This cannot possibly be intended behavior.

For posterity, here is the solution:
LIGHT = texture(TEXTURE,UV) * LIGHT_COLOR;
This will give the correct desired behavior.


Question about cluster.empty_infra

Hi, I'm using shortest first scheduler in your simulator but get an output "This cluster is not large enough to run the job", which seems unreasonable as shortest first scheduler is preemptive. By digging deeper, I find that the empty_infra in _Cluster class does not reset mem of each node. I'm a little confused about this. Is this specially designed or a bug? Looking forward to your reply!

@Rivendile
Thanks for trying out Tiresias. The message should mean that the cluster can not satisfy the resource requirement (especially, GPU) of the top job in the queue. Would you please check if there is any extra large (but short) job in the job file?
We assume GPU machines are always with very large main memory space. Therefore, main memory is not considered as a constraint in resource allocation.

@juncgu
Hi, I use n32g4 cluster setup, check the 60_job trace provided in this repo, and find no extra large job.
Each job is set to use 5GB memory per GPU in your code. I think that If the memory is not reset when preemption happens, the memory will be used up sooner or later.
I reset the memory in _Cluster.empty_infra, and get reasonable results.


Setting global vector to some values

In Earthformer, the number of global vectors is set to 8 which improves the prediction quality a lot without adding much computational cost. I wonder why is it set to 0 here. Is there any specific reason?

Thank you for your question. The implementation of global attention in practice introduced a slightly more computational overhead. We set the number of global vectors to 0 for faster trials. While using global vectors may further increase the performance, we didn't give a try due to the high costs of diffusion model training and inference.

I have encountered some problems again. I found that the model is producing varying outputs for the same input (I am using the original sampler from ddpm). Is that due to the use of xformer? Or it is just a kind of property for conditional diffusion?
Sorry for bothering you. I am quite new to diffusion model so I will be appreciated if you could offer some help.

I have encountered some problems again. I found that the model is producing varying outputs for the same input (I am using the original sampler from ddpm). Is that due to the use of xformer? Or it is just a kind of property for conditional diffusion?
Sorry for bothering you but I am quite new to diffusion model, so I will be appreciated if you can offer some help.

Thank you for your question. This is an intrinsic property of a probabilistic forecasting model. As introduced in Section 2.1 in our paper, the model parameterizes $p_\theta(x|y)$ instead of a deterministic mapping (a $\delta$ distribution) from $y$ to $x$, to represent the inherent uncertainty of the system. Therefore, for a given input $y$, various plausible futures $x$ can be generated by sampling from $p_\theta(x|y)$.


[elastic] Sync to the upstream

The upstream trims the AST of the dependencies to reduce the memory
usage. That means for the symbol defined in dependencies langserver will
reparse the source files to get the full ASTs, this approach will
introduce overhead for the cross-repo jump.
Upstream has supported the workspace folder change, the ManageDeps
should apply to the workspace folder change API to handle the repository
that owns vendor file or contains multiple modules.

I will commit this sync PR, the potential performance issue will fix in the future.


Ensure consistency amont camel case vs snake case

The links spec introduced snake casing, instead of camel casing. So we should ensure that these get moved over to camel casing.
These 3 are what I found:

link_type
context_id
chain_id

We should also add a linter to ensure snake casing isn't added in any future proposals.

@xibz, If ok, you can close this issue?


Open with file_browser

First of all, thank you for this; very useful!
Suggestion: telescope-packer seems to also have an option to "open with file_browser", which I think can be useful.

Thanks for the suggestion.
I'll look into adding that functionality too.

Hey @tsakirist , thank you for getting into this so quickly
However, it doesn't seem to work for me, when I press Alt+b on a plugin, I think the file browser window appears for less than a second and disappears. I tried changing the mapping to something like <C-r>b, but the same thing happens.
The funny thing is that, after that happens, file_browser seems to break as well, and when I do :Telescope file_browser, nothing happens

Hello, can't reproduce it locally neither on my end nor on my colleagues.
I've tried a minimal config with only telescope related plugins and this extension and it works.
Make sure to double check your file browser configuration to see if something interferes. Since the only thing this extension does is to just call the file browser API.
Also provide a minimal reproducible example to help me debug too, since it's not reproducible on my end.


Use port-forward instead of exec to get control plane version

This provides a bit of performance improvement and security.
It lets us address questions related to https://github.com/istio/istio/issues/24331

Currently Pilot provides XDS on 15012 and /version on 15014.  Can we combine these?
Should there be a gRPC version endpoint?  Should it look like XDS Events or something else

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4c7ebb3e9732b32dec096aa6c962f837afa4ccc8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4c7ebb3e9732b32dec096aa6c962f837afa4ccc8
link
/test lint_istio

integ-mixer-k8s-tests_istio
4c7ebb3e9732b32dec096aa6c962f837afa4ccc8
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
cdc78131d83c9e139ac45fb6f51db2658c3c153a
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@esnible: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
cdc78131d83c9e139ac45fb6f51db2658c3c153a
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
cdc78131d83c9e139ac45fb6f51db2658c3c153a
link
/test release-test_istio

integ-distroless-k8s-tests_istio
cdc78131d83c9e139ac45fb6f51db2658c3c153a
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Docker badges invalid

Are you experiencing an issue with...
shields.io
🐞 Description
Docker badges are failing
🔗 Link to the badge
https://img.shields.io/docker/pulls/lizardbyte/plexyglass?style=for-the-badge&logo=docker
https://img.shields.io/docker/pulls/lizardbyte/sunshine?style=for-the-badge&logo=docker
💡 Possible Solution

Cache data and show last known number of pulls
Use multiple accounts for API requests
Discuss with Docker to request a rate limit increase for shields.io

Working now, guess it was related to https://github.com/badges/shields/issues/8579

I seem to be having this issue again today, so maybe not related to that issue.

https://img.shields.io/docker/pulls/lizardbyte/themerr-plex?style=for-the-badge&logo=docker
What is odd is that the badge works if I open the URL directly, but not in my readme on GitHub.
I tired opening in a private window to ensure it's not a cache issue on my end. Any ideas?

The INVALID message means we got something like an http 500 response from the upstream provider. There's really nothing we can do about that, and it's unrelated to #8579 (an issue on our end/with our hosting provider).

What is odd is that the badge works if I open the URL directly, but not in my readme on GitHub.

GitHub caches pretty aggressively, and doing something locally like a private window won't impact that. You can try the purge techniques described in their docs within https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/about-anonymized-urls, but probably easier to just give it some time and check to see if there's any known issues upstream in Dockerhub


Fix unreachable pattern warnings on aarch64

This fixes warning: unreachable pattern on aarch64, as seen when running e.g. cargo clippy or cargo run --example compute.
As suggested by this comment in #267 (which this PR replaces).

I think the build failures should be fixed by #275.

Please proceed when you feel ready


[SPARK-47146][CORE] Possible thread leak when doing sort merge join

What changes were proposed in this pull request?
Add TaskCompletionListener to close inputStream to avoid thread leakage caused by unclosed ReadAheadInputStream.
Why are the changes needed?
SPARK-40849 modified the implementation of newDaemonSingleThreadExecutor to use newFixedThreadPool instead of newSingleThreadExecutor .The difference is that newSingleThreadExecutor uses the FinalizableDelegatedExecutorService, which provides a finalize method that automatically closes the thread pool. In some cases, sort merge join execution uses ReadAheadSteam and does not close it, so this change caused a thread leak. Since Finalization is deprecated and subject to removal in a future release, we should close the associated streams instead of relying on the finalize method.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No

Thanks for surfacing this issue !
To fix this, I would suggest to change ReadAheadInputStream to take TaskContext as a parameter - and add a task completion listener - which calls close.
That would fix the issue, more proactively release resources (instead of waiting for finalization to kick in) and also future proof this code (when support for finalize is removed from JDK)

Also, +CC @HeartSaVioR who reviewed the previous PR

Thanks for surfacing this issue !
To fix this, I would suggest to change ReadAheadInputStream to take TaskContext as a parameter - and add a task completion listener - which calls close.
That would fix the issue, more proactively release resources (instead of waiting for finalization to kick in) and also future proof this code (when support for finalize is removed from JDK)

To fix this, I would suggest to change ReadAheadInputStream to take TaskContext as a parameter - and add a task completion listener - which calls close.

Thanks, that's a very good point. I will try this modification.

Hi, @viirya . Did you see any thread leaks while you are working on Join (or shuffle)?

Hi, @viirya . Did you see any thread leaks while you are working on Join (or shuffle)?

Hi, @dongjoon-hyun. No, I've not seen it. Maybe it is because our tests are not long running ones that have no chance to show any symptom of noticeable leak.

Merged to master.
Thanks for fixing this @JacobZheng0927 !

@JacobZheng0927, might be a good idea to backport this to 3.5 as well - will you be able to create a backport PR ?
(I ran into some issue locally when trying to merge to branch-3.5 and bailed)

@JacobZheng0927, might be a good idea to backport this to 3.5 as well - will you be able to create a backport PR ? (I ran into some issue locally when trying to merge to branch-3.5 and bailed)

I created this pr https://github.com/apache/spark/pull/45390

Any thoughts https://github.com/apache/spark/pull/45327#discussion_r1507120685 @dongjoon-hyun , @sunchao ?

Sorry for the delay @mridulm . Posted my reply. This PR LGTM too.


NETOBSERV-346 revamp upstream doc / readme

WIP:

README.md first pass almost finished (until I get feedback) => check it here: https://github.com/netobserv/network-observability-operator/blob/8a42d8ed950b1c68647d8931c562c7eee4fa86ac/README.md
new file DEVELOPMENT.md still to do

Thank you @stleerh 🙏
I've integrated most of your suggestions; when I didn't, I replied here.

/retest

/approved


Support job cancellation/interruption

Any client should be able to interrupt any job running on any worker given a job Reference.

Done as of v0.15.0!


Fix check auto role update

Thanks a lot. Was waiting for this. I am facing another issue, sorry for posting it here. Whenever I try to use ;cache problemsets all, The log channel gets massive errors like "WARNING:ProblemsetCache:Problemset fetch failed for contest 1487. CodeforcesApiError('Codeforces API error')"
And after the operation finishes, the ProblemsetsCache on disk doesn't get populated. Could you please look into it?

I tried this today. It seems codeforces API returns 5xx code, and there is no issues when caching only one contest (;cache problemsets 1487). I guess codeforces stops to respond because of many requests.
I will merge this pull request and open an issue for more discussion.


Consul Service Discovery Make Node Meta Information Available

Consul SD makes service tags available via __meta_consul_tags but these are not as flexible as labels. Consul provides meta data for nodes which would be much more useful for setting labels such as group="Web", environment="Production", etc.
We could either have this meta data become labels when written to the TSDs or make them available via hidden labels similar to the way marathon SD does it (_meta_marathon_port_mapping_label)
Consul nodes:
[sporkboy@lappy:Consul]$ curl http://server2.example.com:8500/v1/catalog/nodes | jq '.'
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   476  100   476    0     0    817      0 --:--:-- --:--:-- --:--:--   817
[
{
"ID": "",
"Node": "server1.example.com",
"Address": "server1.example.com",
"Datacenter": "denver",
"TaggedAddresses": null,
"Meta": {
"Environment": "Test",
"Group": "prometheus-poc",
"Team": "Unix"
},
"CreateIndex": 61,
"ModifyIndex": 5256
},
{
"ID": "",
"Node": "server2.example.com",
"Address": "server2.example.com",
"Datacenter": "denver",
"TaggedAddresses": null,
"Meta": {
"Environment": "Perf",
"Group": "prometheus-poc",
"Team": "Unix"
},
"CreateIndex": 5,
"ModifyIndex": 218
}
]
consul services:
[sporkboy@lappy:Consul]$ curl http://server2.example.com:8500/v1/catalog/services | jq '.'
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   211  100   211    0     0   3467      0 --:--:-- --:--:-- --:--:--  3516
{
"consul": [],
"node": [
"tag1",
"tag2"
],
"node-exporter": [
"prometheus",
"exporter"
],
"node2test-service": [
"monkeys",
"brains",
"test",
"prometheus",
"exporter"
],
"process-exporter": [
"prometheus",
"exporter"
],
"web": [
"rails"
]
}

See #2966

Added in #2966.


Scala 3

https://github.com/twitter/algebird/issues/1099

[x] address compiler warnings/errors
[x] setup kind-projector migration
[x] implement common derive macros
[x] Cuber and Cuber derivation
[x] Roller and derive macros
[x] resolve conflict
[x] write ArbitraryCaseClassMacro in Scala 3 and pass tests

NOTE:
changes for compatibility between 2.11, 2.12, 2.13 and 3.x
Source files compatible across all Scala version above are located in algebird-core/src/main/scala directory.
The most of changes in scala dir are to add explicit apply (()) and to resolve ambiguous values.
Some files in scala-2.11 and scala-2.12+ are almost the same but there are a few differences.

*s from kind-projector are replaced by _ in 2.12+.
Type wildcards _ are replaced by ? in 2.12+.
There are a few code that require explicit type annotation or unsafe conversion (asInstanceOf[T])

(1) and (2)  are necessary mainly because Scala 2.11 does not support "-Xsource:3" and "-P:kind-projector:underscore-placeholders" which are necessary for smooth kind-projector migration.
These duplicated files can be deleted after dropping Scala 2.11. For more details, see https://docs.scala-lang.org/scala3/guides/migration/plugin-kind-projector.html
Scala 3 macros
Macros in algebird-core are ported to Scala 3, but there are still room for peformance and type safety improvement.
Scala 3 macros in algebird-core are extracted to https://github.com/i10416/algebird-macros for debug and test purpose.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for doing this!
I'll look at it in the next days.
It's quite large obviously so it will take some time.

Codecov Report
Patch coverage: 80.94% and project coverage change: -0.03 :warning:

Comparison is base (3cefba6) 89.60% compared to head (b4f663c) 89.58%.

:exclamation: Current head b4f663c differs from pull request most recent head 1d4bf3d. Consider uploading reports for the commit 1d4bf3d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1105      +/-   ##
===========================================
- Coverage    89.60%   89.58%   -0.03%
===========================================
  Files          119      124       +5
  Lines        10016    10050      +34
  Branches       695      572     -123
===========================================
+ Hits          8975     9003      +28
- Misses        1041     1047       +6

Impacted Files
Coverage Δ

...d-core/src/main/scala-2.12/monad/EitherMonad.scala
0.00% <0.00%> (ø)

.../scala-2/com/twitter/algebird/macros/package.scala
88.88% <ø> (ø)

.../src/main/scala/com/twitter/algebird/Batched.scala
67.69% <0.00%> (ø)

...main/scala/com/twitter/algebird/HashingTrick.scala
0.00% <0.00%> (ø)

...main/scala/com/twitter/algebird/MomentsGroup.scala
81.57% <0.00%> (ø)

...src/main/scala/com/twitter/algebird/Preparer.scala
32.14% <0.00%> (ø)

...rc/main/scala/com/twitter/algebird/SketchMap.scala
92.45% <ø> (ø)

...m/twitter/algebird/matrix/SparseColumnMatrix.scala
30.76% <0.00%> (ø)

...ore/src/main/scala-2.12/monad/StateWithError.scala
48.38% <48.38%> (ø)

...gebird-core/src/main/scala-2.12/monad/Reader.scala
50.00% <50.00%> (ø)

... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This is great! I can help out with the review.

algebirdCore 3.2.2 compiles in https://github.com/twitter/algebird/pull/1105/commits/c7834ec0733f44d239c58d7ccb5ff2bfa1a22583 though tests do not compile yet.

Now, algebird compiles in Scala 2.11, 2.12, 2.13 and 3 at https://github.com/twitter/algebird/pull/1105/commits/7042270677205a07518e2e0359a62c33bc53de73
and all tests but CollectionSpecification pass.

I didn't come up with nice solution for them, so I will keep them for now.

https://github.com/twitter/algebird/pull/1105/commits/d123047e716a83ef7ae0495c34c57389a17d013d
https://github.com/twitter/algebird/pull/1105/commits/2f1f2f7f2792e7ee7fa3403652463f8e400da48e

@regadas  Hi, could you run CI and look through changes?

Sorry for forgetting fmt and check before asking for review.

I found the same issue in scalameta. https://github.com/scalameta/scalameta/issues/3063

@regadas Sorry for the previous request, it is now ready for review (this time, for sure)

minimized reproduction of https://github.com/twitter/algebird/pull/1105/commits/d51aa1b2227061def8c2639562fe271c6f305387
https://github.com/i10416/reproduce-missing-symbol-error-in-scala-3

@regadas Could you review changes when you have a time?


STYLE: Fix lightning deprecation warnings

I'm fixing a few issues that would prevent upgrading the pytorch-lightning package. Trainer.lr_schedulers is being replaced with trainer.lr_scheduler_configs. In future versions, using trainer.logger with multiple loggers will only return the first logger available, so I'm iterating through trainer.loggers instead. And LightningLoggerBase.close is being replaced with LightningLoggerBase.finalize.
Closes #751

@microsoft-github-policy-service agree

@dkarhi, thanks a lot for this PR! Approved.


Update glossary.md

VScode

@MaryConnolly5 this is so embarrassing that you would do this on your own repo instead of mine.

this is embarrassing

I'll try to be less embarrassing in the future.


Propose and document release process

We should have a clear cookbook of how we cut a new release.

I am hoping we can get in #159 before doing this.  That change removes 4 places that the version identifier is repeated and merging it will help simplify the release process.

I've added a wiki page with the release process.  I followed this process in #161, and here is the resulting release: v1.0.0-beta.1.


Bug: Workflow update does not do anything

I triggered the Workflow update but "Fetching Updates" stays forever.

Versions

Alfred version: 4
macOS version:10.14.5
Safari Assistant: 0.7.2

Expected behaviour

Show that I am on latest version or update workflow notification
Actual behaviour

Stalled in Fetching Update
Steps to reproduce

Enter "safass" > Safari Assistance Config
Check for Updates

Debugger output

15:39:17 update.go:154: Latest release: 0.7.2
15:39:17 magic.go:287: No update available

Anything else?

Just saw few lines were missing in my previous post but seems to be important:
15:33:42 update.go:328: Fetching https://api.github.com/repos/deanishe/alfred-safari-assistant/releases ...
15:33:42 update.go:334: [200] https://api.github.com/repos/deanishe/alfred-safari-assistant/releases
15:33:42 github.go:91: invalid release: no workflow files in release v0.4.5
15:33:42 github.go:58: 17 release(s) in repo deanishe/alfred-safari-assistant
15:33:42 update.go:154: Latest release: 0.7.2
15:33:42 magic.go:287: No update available

You have the latest version already. This is the expected behaviour.
I can make the “Check for Update” message clearer (e.g. “Workflow is up to date”), but showing a notification would require rewriting the update mechanism.
Currently, it uses the library’s built-in update mechanism and that has no ability to show notifications.

For user experience it would be better to tell that wf is up to date. I assume checking logs is not a solution.
Anyhow minor improvement.

For user experience it would be better to tell that wf is up to date

That’s not so clear cut because the information might be out of date.
In any case, the workflow will tell you when an update is available.
Perhaps I should just remove that item from the settings. It’d be a lot of work to make a very minor feature work provide accurate feedback.
That would hide the update mechanism from people who don’t already know how it works, and knowing how it works, they won’t be confused by the (lack of) feedback.

Got it! In that case automatic update request in the background would be better like OneUpdater.
But I don't want to stretch this topic. Feel free to close....the WF is great!

Got it! In that case automatic update request in the background would be better like OneUpdater.

That’s already how it works. There is no need to check for updates manually.


Import ABC from collections.abc for Python 3.9 compatibility.

Importing ABC from collections module will raise ImportError in Python 3.9 and raises DeprecationWarning from 3.4 . Hence use collections.abc and also preserve compatibility with Python 2. Ref : https://github.com/python/cpython/pull/10596

Thanks for the contribution!
The code has evolved past this and uses typing.Mapping. Closing as stale.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.51%. Comparing base (e323933) to head (6cc86e1).
Report is 267 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   60.47%   60.51%   +0.03%
==========================================
  Files          83       83
  Lines        5048     5052       +4
==========================================
+ Hits         3053     3057       +4
  Misses       1995     1995

Files with missing lines
Coverage Δ

binstar_client/utils/config.py
67.72% <100.00%> (+0.83%)
:arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e323933...6cc86e1. Read the comment docs.


rdgen failed

warning: classpath entry points to a non-existent location: /Users/fangyi/repos/Plugin/build/riderRD-2019.2-SNAPSHOT/lib/rd/rider-model.jar
/Users/fangyi/repos/Plugin/protocol/src/main/kotlin/model/rider/MyPluginModel.kt:3:22: error: unresolved reference: rider
import com.jetbrains.rider.model.nova.ide.SolutionModel
                     ^
/Users/fangyi/repos/Plugin/protocol/src/main/kotlin/model/rider/MyPluginModel.kt:8:31: error: unresolved reference: SolutionModel
object PaketPluginModel : Ext(SolutionModel.Solution) {
                              ^
Compilation finished in 5802 ms
Compilation failed. Return code: 1(COMPILATION_ERROR).

I've had a look and there seems to be code to setup the snapshot library in the build dir, could anyone help? Thanks

In particular
https://github.com/JetBrains/resharper-rider-plugin/blob/master/content/build.gradle#L22
I'm not sure where is this directory set up?

What command do you use to compile the plugin?

I have similar problem.
Steps to reproduce:

Create new project from template
Run configuration to generate protocol

Workaround:
Find specific version of Rider snapshot in gradle cache and copy it to build folder.
Should looks like this:

This should be fixed by https://github.com/JetBrains/resharper-rider-plugin/commit/c9cbef1b86d72674fc671a1143455b44121bfe2c.


Substitute CDN urls in compile target for vendor dependencies

Perhaps this is already possible and I'm missing it, but for production builds I'd like to avoid concat of certain vendor files in favor of CDN hosted versions.
Is there a strategy for this that you'd recommend?

Has there been any news on this? I'm getting errors with karma:unit when including CDN sources in index.html and including  the corresponding dependencies on the main module. (For instance, firebase).
Including the sources in karma-unit.tpl.js  doesn't help either


enable gl blending

This makes transparency work correctly.
fixes #56

https://www.opengl.org/archives/resources/faq/technical/transparency.htm

Thanks!


[AVM Module Issue]: hostpool registration token not in output

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
(Optional) Module Version
0.1.4
(Optional) Correlation Id
No response
Description
Only the azurerm_virtual_desktop_host_pool.this resource is outputed. This makes it impossible to retrieve the much needed registration token info  to register vms to the host pool. I believe adding the azurerm_virtual_desktop_host_pool_registration_info.registrationinfo.token to the output would be beneficial.
Proposed additition in outputs.tf:
output "registration_token"  {
  value = azurerm_virtual_desktop_host_pool_registration_info.registrationinfo.token
  sensitive = true
}

I am experiencing the same issue with the AVM module where the hostpool registration token isn't included in the output. The absence of this token complicates the process of registering VMs to the host pool, which is a critical step for us.

Hi @jensheerin is it possible to get this output added?