Heroku Deployment

We need:

[x] heroku instance for the frontend running something more stable than gulp serve
[x] heroku instance for the backend
[x] config settings in both the frontend/backend that allow us to figure out where the heck we need to talk to

BOOSH!


improv(tracer): set AWS_XRAY_CONTEXT_MISSING to IGNORE_ERROR when no value is set

Summary
Changes

Please provide a summary of what's being changed

This PR updates the Tracer utility to set the AWS_XRAY_CONTEXT_MISSING environment variable to IGNORE_ERROR by default.
This change has been made in response to customers adopting features that rely on top-level await and finding the error logs produced by X-Ray SDK not useful.
The X-Ray SDK for Node.js was not designed with this feature in mind, and by default it logs an error when a code path attempts to send trace data outside of the context of a request.
This is because without the request context, there's no X-Ray Trace ID, and so the SDK is unable to establish the lineage of a segment/span.
In many cases this is a desired behavior (although I'd have preferred it was a warning rather than an error log), however now that making async operations during the init phase is possible, it's not uncommon to make outbound http requests or use the AWS SDK to retrieve data or perform setup operations.
In those cases, the auto instrumentation features of Tracer (& the underlying X-Ray SDK) attempt to create a segment for these operations but don't find one because these tasks are run during the init phase, and thus outside of the context of a request.
The change has been made with backwards compatibility in mind, to an extent. Before setting the value we check if the env variable is already set and if so, we leave it as-is.
I believe this is a good middle ground between furthering our features and maintaining flexibility.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2406

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Yea good point - I added it elsewhere because that one you linked is for reading from the env var, but I think it's the same.


Provide plugin's "ping"

Provide "ping" functionality to check

the plugin is installed
connection to VDSM is properly configured

The 'ping' command is invoked by:
HOST:PORT/ovirt/ovirt#/ping
The status is returned as content of
 containing both human- and parser-friendly messages.
The JSON-response for a parser is content of the
 element.


Scope's compass headings are wonky

As shown above, there are two problems that need to be addressed with the compass headings:

[ ] Headings are not aligned relative to the aircraft's position (red)
[ ] Strange behavior in alignment, probably related to same core issue (blue)

As @sandpatch discovered, they are apparently drawn in relative to the position of the airport, not the aircraft.

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


[SDK] WIP: Publish and deploy flow for modular pattern contract

/release-pr

/release-pr

/release-pr

/release-pr


Support marathon master discovery via ZK

In HA mode marathon stores the master(s) address in zk using a format very similar to server sets. While this isn't an officially supported format and could possibly change, it would be a nice feature for environments where a constant http address for marathon does not necessarily exist.

good idea!
looks like marathon does twitter commons' leader election (1 2) under /marathon/leader by default.

@olix0r would a reasonable solution be to make a class that implements namer for the twitter commons's leader election class? Then rather than modifying the marathon namer configuration options directly, one could just make a http router for marathon and then use that? something like:
namers:
- kind:      io.l5d.experimental.marathon
  prefix:    /marathon-test
  host: <IP_ADDRESS>
  port: 11111

routers:
- protocol: http
  servers:
  - port: 11111
    ip: <IP_ADDRESS>
  interpreter:
    kind: io.l5d.namerd
    dst: /$/some.new.class.extending.namer/zkhost:2181/marathon/leader

That's a neat idea.  We could simply implement a leader namer (there's nothing marathon-specific about it), and use that as a way to configure the marathon namer:
namers:
- kind:      io.l5d.experimental.marathon
  dst: /$/io.l5d.zk.leader/zkhost:2181/marathon/leader
...

Thanks @adleong !


Sometimes thumbnails don't include all inputs

Repro steps
Reproed in debug mode.

Create a Value node
Create a Combine node
Connect the Value node to all the inputs on the Combine node
Delete the Combine node
Use ctrl Z and ctrl shift Z to undo and redo the deletion for half a minute or so

Result
Sometimes the combine node's output is not white.
Expected
The output should always be white.
Note
This does not only affect the thumbnail, the actual output is wrong.

Fixed!
Issue was that changes to the graph could sneak in unnoticed at certain points in the asynchronous code. This meant that old data was being used and thought to be current.
The solution was to plug the holes and mark nodes dirty if this happened during calculation.


Correct scale for add/subtract

In add and subtract functions you run bcmath with 0 scale which floored the result.

@frederikbosch can you please review this?

@sagikazarmark Will do, it seems OK. But I am missing tests that prove the point.
@angekouf Can you add a test that shows that there the calculator is not correct at some point?

Ping @angekouf can you please take a look at the tests?

Ping @angekouf can you please take a look at the tests?

Tests fail, no clear reason why to do it. It can only make sense when using PreciseMoney. Closing until better explanation given.


Effect Schema: ArrayFormatter fails to get array item error when min/max length are defined

What version of Effect is running?
3.0.3
What steps can reproduce the bug?
Given the following schema:
const Schema = S.Struct({
  outcomes: pipe(
    S.Array(
      S.Struct({
        id: S.String,
        text: pipe(
          S.String,
          S.message(() => 'common.error_invalid_outcome_type'),
          S.minLength(1, { message: () => 'common.error_required_field' }),
          S.maxLength(50, { message: () => 'common.error_max_length_field' })
        ),
      })
    ),
    // If you uncomment this line, the test passes
    S.minItems(1, { message: () => 'common.error_min_length_field' })
  ),
});

If you run
const result = pipe(
    {
      outcomes: [
        { id: '1', text: '' },
        { id: '2', text: 'this one is valid' },
        { id: '3', text: '1234567890'.repeat(6) },
      ],
    },
    S.decodeUnknown(Schema),
    Effect.catchTag('ParseError', (error) => ArrayFormatter.formatError(error)),
    Effect.tap((result) => Effect.log(result)),
    Effect.runSync
  );

console.log(result);

See stackblitz: https://stackblitz.com/edit/node-i8ixxo?file=package.json,test/basic.test.ts,README.md
What is the expected behavior?
I expect the code above to return:
{
      _tag: 'Refinement',
      path: ['outcomes', 0, 'text'],
      message: 'common.error_required_field',
}

What do you see instead?
Instead it returns:
[
    {
      _tag: "Refinement",
      message: "common.error_min_length_field",
      path: ["outcomes"],
    },
  ]

Which is wrong as the outcome's array has more than 1 item.
Additional information
If you comment the line     S.minItems(1, { message: () => 'common.error_min_length_field' }) then you would get the desired output.

The behavior is as intended, meaning that when setting a custom message, it takes precedence over everything else (see https://github.com/Effect-TS/effect/blob/main/packages/schema/README.md#custom-error-messages). However, upon reflection, I realize that this logic may work well for scalar value refinements but not for a case like this, where we refine a more complex data structure (such as an array of a struct). Therefore, I'm considering refactoring the message logic in the next minor version of the schema so that the high precedence of the message is opt-in.
In short, the logic could be as follows, given a filter:

If there is a custom message defined on it:

If this message is marked as override: true, then this message is used unless the error concerns a previous refinement and that refinement has a custom message, in which case the message of that previous refinement is calculated.
If the message is NOT marked with override: true:

If the error concerns this refinement and not a previous one, its custom message is used.
Otherwise, if the error concerns a previous refinement, the corresponding message is calculated.

Otherwise, the default message is calculated.

Just to give more details on my usage as this might be a common use-case.
I have a form which contains a list of items. This list needs to have at least one item. Each item needs to be a string with length > 1 and < 50.
I want to be able to show an error next to the input that is currently invalid.
It would be awkward for the user to start writing their 3rd item in the list, somehow make that item invalid and have an error saying that the list does not have at least 1 item.
I really can't understand how the expected behaviour could be to show a minLength error on an array that has 3 items.

I agree that the current behavior is not good.
It's the "expected behavior" given how the messaging system currently works, not in the sense that it's correct overall and especially not in your case: as I wrote above, the current behavior would work fine for refinements of scalar values (such as string or number) but not for refinements of more complex data structures like the case you presented (a refinement of an array of structs).
So the behavior encoded in the formatter needs to be refactored to improve it, which is exactly what I'm doing right now by working on the development branch of the next minor https://github.com/Effect-TS/effect/pull/2634

Awesome, thank you for the quick feedback.


gradle-java-plugin adds a broken unspecified dependency

For the following build.gradle with Gradle 7.2
plugins {
    id 'java-gradle-plugin'
}

Expected Behavior
gradle :dependencies --configuration testImplementation should give GAV coordinates or some similar resource locator for all dependencies
gradle --write-verification-metadata sha256 build writes hashes of all dependencies to gradle/verification-metadata.xml, and a subsequent Sync operation in IntelilJ will succeed.
Current Behavior
gradle :dependencies --configuration testImplementation produces the following unhelpful output:
testImplementation - Implementation only dependencies for source set 'test'. (n)
\--- unspecified (n)

(n) - Not resolved (configuration is not meant to be resolved)

gradle --write-verification-metadata sha256 build writes no hashes to gradle/verification-metadata.xml, and a subsequent Sync operation in IntelilJ fails due to not being able to verify.
* What went wrong:
Dependency verification failed for org.gradle.groovy:groovy-all:1.3-2.5.12
One artifact failed verification: groovy-all-1.3-2.5.12.pom (org.gradle.groovy:groovy-all:1.3-2.5.12) from repository Gradle Libs

Context
I was trying to create a Gradle plugin with dependency verification enabled, using IntelliJ Idea and this seems quite difficult to make an empty project import.
Steps to Reproduce
Create a build.gradle as per above with an empty settings.gradle.
Simply opening the above project in IntelliJ 2021.2.3 after attempting to write verification metadata will fail.
Your Environment
Gradle 6.8, 7.2
IntelliJ Idea 2020.2.3
Build scan URL: https://scans.gradle.com/s/ekbh6i52crdh6

For the dependencies task, you should be using a resolvable configuration. Why unspecified is printed, that's indeed weird and we'll look into it, but beyond that, you really need to use a resolvable configuration.
About the verification part, we'll investigate.

I was running the dependencies task so I could manually add the deps to my verification metadata, which seems like a valid use case to me.
Even attempting to disable verification doesn't let a sync complete without failing verification
configurations.all {
	it.resolutionStrategy.disableDependencyVerification()
}

That will not fully disable dependency verification. It needs to be done for both project and buildscript configurations.
And still, I believe the feature will be exercised when an IDE attempts to download sources.
So if you want to disable dependency verification, your best bet is to remove the config file.

FWIW this issue breaks other tooling such as the Gradle Dependency Submission action - see e.g. this build where I tried to use it with a Gradle plugin project.


Use stricter CL on test_type_secondary_indexing

We were running into EC issues with the Write, Read, Assert pattern. As sometimes we would read from a replica w/o the data yet
@knifewine to review, as he and I broke this in the first place.

LGMT. +1 if it runs clean.


i can't build flutter after 1 year, it worked before!

Steps to Reproduce
hi
i can't build flutter after 1 year, it worked before!
its work when i want test app in emulator but at release version can't make output
Expected results:
Actual results:

gradle-wrapper.properties:
#Fri Jun 23 08:50:38 CEST 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

build.gradle:
buildscript {
    ext.kotlin_version = '1.6.10'
    repositories {
        google()
        mavenCentral()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:4.1.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
    }
...
}

error Logs

Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Could not resolve all artifacts for configuration ':url_launcher_android:debugUnitTestRuntimeClasspath'.
   > Could not find core-1.0.0.aar (androidx.test:core:1.0.0).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/androidx/test/core/1.0.0/core-1.0.0.aar
   > Could not find monitor-1.2.0.aar (androidx.test:monitor:1.2.0).
     Searched in the following locations:
         https://dl.google.com/dl/android/maven2/androidx/test/monitor/1.2.0/monitor-1.2.0.aar

flutter doctor:
[√] Flutter (Channel stable, 3.0.2, on Microsoft Windows [Version 10.0.19042.985], locale en-US)
    • Flutter version 3.0.2 at C:\flutter\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cd41fdd495 (7 months ago), 2022-06-08 09:52:13 -0700
    • Engine revision f15f824b57
    • Dart version 2.17.3
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at D:\sdk
    • Platform android-32, build-tools 32.0.0
    • ANDROID_HOME = D:\sdk
    • Java binary at: D:\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2020.3)
    • Android Studio at D:\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[√] VS Code (version 1.67.2)
    • VS Code at C:\Users\EzioSliverHand\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.56.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19042.985]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 108.0.5359.125
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 105.0.1343.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

pubspec.yaml:
name: untitled
description: A new Flutter project.

version: 1.0.0+1

environment:
  sdk: ">=2.17.0-45.0.dev <3.0.0"

dependencies:
  flutter:
    sdk: flutter

  cupertino_icons: ^1.0.2
  animate_do: ^2.1.0
  percent_indicator: 4.2.2
  http: ^0.13.4
  flutter_svg: ^1.0.3
  flutter_spinkit: ^5.1.0
  shared_preferences: ^2.0.13
  url_launcher: ^6.1.7
  persian_datetime_picker: ^2.5.0
  jalali_calendar: ^1.0.4
  persian_date: ^0.1.5
  internet_connection_checker: ^0.0.1+3
  shamsi_date: ^1.0.1
  super_list_view: ^0.0.5
  flutter_inappwebview: ^5.4.3+7
  model_viewer_plus: ^1.3.3

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_launcher_icons: "^0.9.2"
  flutter_lints: ^1.0.0
flutter_icons:
  android: "launcher_icon"
  ios: true
  image_path: "assets/icon/icon.png"

flutter:

  uses-material-design: true

  assets:
    - assets/images/
    - assets/models/
    - assets/models/textures/
    - assets/models/scene.gltf

  fonts:
    - family: vazir
      fonts:
       - asset: assets/fonts/Vazir-Light.ttf
         weight: 700

Hi @ezioadf2
The goal of this Github repo is not to give assistance on personal code or the whole package/plugin project,
but to improve flutter reporting bugs or feature requests.
If you encounter behavior that you believe could be a bug, please provide a completed and minimal reproducible code sample that represents the problem along with the output of flutter run -v.
Instead, if you think that the issue might depend on your implementation, please see flutter's community for resources and ask questions like this. You may also get some help if you post it on Stack Overflow and flutterhelp.
Thank you!


Add to existing translations when collecting

Updating translations to match new sources requires three steps: collecting, merging and renaming the resulting file.
If the output already exists collect could keep the existing translations, add new messages and move redundant messages to "rejected", file like currently done by merge. This would really simplify update, especially for the less experienced users.

Solved in #67.


Messages profile pictures clickable

When tapping on the small profile picture circle for a message on a PRIVATE CONVERSATION (that means not on a tribe) we should take user to the EDIT CONTACT view. Same view we take user to when tapping on CHAT HEADER of a private conversation.
In addition the header is clickable but the circular profile picture on it is not. That should be fixed so it's clickable as well.

Hello @tomastiminskas
this issue now fixed in #485

Closing issue as its now fixed thanks @MathRoda


ZenYandex: Unable to extract metadata

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I'm running yt-dlp version 2023.10.13 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Provide a description that is worded well enough to be understood
Yt-dlp breaks on every video from dzen when trying to extract metadata. I think they did some sort of backend update over there at yandex, which broke the search regex. I already tried to fix it myself, but the i'm not familiar with yt-dlp's codebase and writing extractors for it. Would appreciate any help.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://dzen.ru/video/watch/6002240ff8b1af50bb2da5e3']
[debug] Encodings: locale cp1251, fs utf-8, pref cp1251, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[b634ba742] (pip)
[debug] Python 3.11.5 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 3.0.9 30 May 2023)
[debug] exe versions: none
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2023.07.22, mutagen-1.47.0, sqlite3-3.42.0, websockets-11.0.3
[debug] Proxy map: {}
[debug] Loaded 1890 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>yt-dlp is up to date<EMAIL_ADDRESS>
[ZenYandex] Extracting URL: https://dzen.ru/video/watch/6002240ff8b1af50bb2da5e3
[ZenYandex] 6002240ff8b1af50bb2da5e3: Downloading webpage
[ZenYandex] 6002240ff8b1af50bb2da5e3: Redirecting
ERROR: [ZenYandex] 6002240ff8b1af50bb2da5e3: Unable to extract metadata; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "C:\test\.venv\Lib\site-packages\yt_dlp\extractor\common.py", line 715, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\test\.venv\Lib\site-packages\yt_dlp\extractor\yandexvideo.py", line 260, in _real_extract
    data_json = self._search_json(
                ^^^^^^^^^^^^^^^^^^
  File "C:\test\.venv\Lib\site-packages\yt_dlp\extractor\common.py", line 1277, in _search_json
    json_string = self._search_regex(
                  ^^^^^^^^^^^^^^^^^^^
  File "C:\test\.venv\Lib\site-packages\yt_dlp\extractor\common.py", line 1263, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)

Duplicate of #8275


dnf-plugins-core: Fix bad python path in cmake call

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

#2630 caused a build break due to a change to the cmake call in dnf-plugins-core. The change caused cmake to be given python3 instead of the desired file path /usr/bin/python3. This caused the build of dnf-plugins-core to fail, since the cmake script expects either a major version number or a file path.
This PR changes the cmake call to use the full python3 binary file path.
Change Log

dnf-plugins-core: Pass cmake the file path of our python3 binary to fix build
dnf-plugins-core: no changelog entry/release bump, since this release has not been published

Does this affect the toolchain?

NO
Test Methodology

N/A

License map seems to be out of date. updating that as well.


Error: jenkins: job.config: jenkins: crumbIssuer.get: not found

Hi Team,
I am getting this exception while trying to run my Jenkin file from VsCode.

[2019-06-17 17:09:51.301] [Jenkins] [info] Creating Jenkins instance @url=http://inblresdpjkp02.eng.med.ge.com, with user=xxxxxx, password=****
[2019-06-17 17:09:51.302] [Jenkins] [info] Creating pipeline build using job test-pipeline @http://inblresdpjkp02.eng.med.ge.com, with params undefined
[2019-06-17 17:09:51.302] [Jenkins] [info] Fetching remote XML config for job test-pipeline @http://inblresdpjkp02.eng.med.ge.com
[2019-06-17 17:10:01.756] [Jenkins] [info] Parsing and updating XML with new pipeline script
[2019-06-17 17:10:01.774] [Jenkins] [info] Pushing remote XML config for job test-pipeline @http://inblresdpjkp02.eng.med.ge.com
[2019-06-17 17:10:09.129] [Jenkins] [error] Error starting job test-pipeline #undefined @http://inblresdpjkp02.eng.med.ge.com}: Error: jenkins: job.config: jenkins: crumbIssuer.get: not found
[2019-06-17 17:10:09.129] [Jenkins] [error]

Error 404 Not Found

HTTP ERROR 404
Problem accessing /crumbIssuer/api/json. Reason:
    Not FoundPowered by Jetty://

[2019-06-17 17:10:13.457] [Jenkins] [info] Stopping job test-pipeline #undefined @http://inblresdpjkp02.eng.med.ge.com
[2019-06-17 17:10:13.457] [Jenkins] [info] Stopping job test-pipeline #undefined @http://inblresdpjkp02.eng.med.ge.com

I fixed this by enabling CSRF protection with default crumb https://support.cloudbees.com/hc/en-us/articles/219257077-CSRF-Protection-Explained

I forgot to update the docs in the 1.2.0 release, but you can also use the useCrumbIssuer field on a host defined in settings.
CSRF protection will not be used if this is set to false.

Closing - I think this issue is resolved, but please re-open if you experience any more problems.


feat: Update sops version 3.9.0

https://github.com/getsops/sops/releases/tag/v3.9.0
reasons to update:

1384 This version ensures consistent handling of SOPS metadata across different output formats, with a unified sops top-level key for YAML, JSON, and INI files, and sops_ prefix for DotEnv files.
1093 The upgrade allows configuring SOPS to encrypt secrets with KMS keys from different AWS accounts using named AWS profiles. This ensures that if one has access to at least one of the keys, they can decrypt the file. This enhancement supports using multiple AWS profiles seamlessly for key management.
CVE updates

@yxxhero hi I hope you are doing good, I see one test is failing does not seem related to my changes? can you please take a look when you have some time


Enable AVX2 avg HBD function.

Coverage increased (+0.07%) to 65.601% when pulling 976aca568f86fcaa696c1b4c5e3bfb904b5dab2c on negge:avg_hbd into 8b930d2aa1f74bdd6a90293c4bd668f924fc17a2 on xiph:master.


watch all symlinked node_modules

js/css watchers should work on symlinked (eg: npm linked) node_modules.

here yeh go @zarend :)


I would like to inquire about robot vibrations while watching a video.

Thank you for sharing your research results.
In the video you uploaded, I noticed that the robot is vibrating.
What could be causing this phenomenon and can it be resolved?

This is caused by the hardware. This is resolved by switching to the ARX L6 robot arm.

Can you please provide more details about what is wrong with the hardware (and its SDK)?
Is there no way to solve the problem with the Aloha mobile robot?

This is caused by the hardware (and its SDK). This is resolved by switching to the ARX L6 robot arm.

New ARX sdk, no vibrations 🥳
https://github.com/user-attachments/assets/340920f2-4910-4e61-8c5c-30d06b8d2068


[Bug]: Multiple fingers can touch the screen at the same time

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
It is possible to click multiple items at TopicsTabContent once (the same happens with People tab).
If we press with several fingers at once, all screens will open. Going back we will see all of them.
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@nntsl  I reproduced the bug on my android too. There is this stackoverflow answer for a similar question which uses a extension. I added the code and tested it on my system. It successfully killed the bug and the interests screen was registering one touch at a time.
I'll paste the link here. You can look it up yourself.
StackOverflow link:-  https://stackoverflow.com/a/72816456

hi @dturner i am new to this library. I have fixed this bug and created a pull request. Can you guide me on what i need to do next. Thank you it will help me out a lot.

Use launchSingleTop = true


info_style = InfoStyle.HIDDEN causes graphical glitch with reverse layout

If I show a Picker with info_style = InfoStyle.HIDDEN, fullscreen = False, layout = 'reverse', selecting or typing an option causes the entire widget to be redrawn one line above its original place, eventually overwriting my terminal history.
Footage:
Capture vidéo du 2023-03-01 10-28-35.webm

Fixed in the new version 0.0.22, please check if it work correctly now.

thanks!


New Clarius app update in Jan/Feb timeframe has broken interface via Mobileapi

MIT Lincoln Laboratory has written an app that uses the Mobileapi interface.   A new version of the Clarius app that was pushed to the probe in the Jan/Feb time frame is now sending a message that was not set before.
The onScanAreaChanged() method is being called.   Once this occurs the onNewProcessedImage() method stops being called.
Is there a way to turn off the some feature so the onScanAreaChanged() method will not be called or is there something I should do when I receive this message to allow the app to continue.  Right now I just log that the method has been entered.
We no longer can run our app so I would appreciate any help you can give us.
Thank you,
Nancy DeLosa
MIT Lincoln Laboratory

we can look into this, in the meantime you can obtain previous releases of the App here: https://github.com/clariusdev/mobileapi/releases

Thank you we well try to install an older version.
From: Kris Dickie @.>
Sent: Thursday, May 2, 2024 12:13 PM
To: clariusdev/mobileapi @.>
Cc: DeLosa, Nancy - 0224 - MITLL @.>; Author @.>
Subject: [EXT] Re: [clariusdev/mobileapi] New Clarius app update in Jan/Feb timeframe has broken interface via Mobileapi (Issue #36)
we can look into this, in the meantime you can obtain previous releases of the App here: https: //github. com/clariusdev/mobileapi/releases — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside the Laboratory.
ZjQcmQRYFpfptBannerEnd
we can look into this, in the meantime you can obtain previous releases of the App here: https://github.com/clariusdev/mobileapi/releases
—
Reply to this email directly, view it on GitHub https://github.com/clariusdev/mobileapi/issues/36#issuecomment-2090930039 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKJLVB2HPATFLSRV2O45TDZAJQYXAVCNFSM6AAAAABHEAORG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQHEZTAMBTHE .
You are receiving this because you authored the thread.Message ID: @.***>

Is there a way to download an older version of the scanner to to scanner so it works with the older app?

yes, all App releases will also update the scanner software: https://github.com/clariusdev/mobileapi/releases

Is there a special way to update the app on the phone?   I personally did not update the app, but when running the older version the use was told to update app to 11.2 to connect to the scanner.   We must be doing something incorrectly.

The Android APKs can be installed manually, you should delete any previous versions of the App beforehand


Can't get stream information

I've set up the bot and configured the file with my Client ID and bot ID. I have a handful of channels I'm monitoring but no matter who goes online or at what point I always get

[TwitchMonitor]` Did not receive a response from the server with stream info.

I'm just getting into node development so I'm not sure how to debug it to see if it's a problem with my twitch client ID (I had a lot of 401 errors when trying to write a simple test app to fetch stream data) or somewhere else.
Here's how my config file is set up, not sure about the limitation on how many channels can be checked but I manage a fairly large community of streamers and I need a tool that would let me send notifications for 25+ live channels throughout the day. Timbot is the only tool I could see myself using since I rather have full control of the code.
{
  "bot_token": "NzEzMDc2NTEwNjY3MzA5****.******.****htYzhez1XpGHuehpinFBA48",

  "discord_announce_channel": "anouncements",
  "discord_fooduse_channel": "",
  "discord_mentions": {
    "channel_sample_1": "here",
    "channel_sample_2": ""
  },

  "twitch_client_id": "800fe***m0r3***utp***c1biqvccm",
  "twitch_client_secret":"1xck5k9***my2iy***2iaq9****bj9",
  "twitch_check_interval_ms": 60000,
  "twitch_channels":"messengerofdunk,shanhearts,slamdunkingbenedetto,heliiux,secretsleepoversociety,nerdyjane,khaztaroth315,leprechaunkoala,misbac,juststevenyaffe,ionicart,jacuzzitubbs,trendzilla_,shalaemon,annaikonline,nathansothershow,geektomplays,zacoyama,wickerfiend95,ancarrowart,cheshiretaurus,wibbledibbles,itsbremily,deamagicka,ArkaeicOne",
  "voice_enabled": false,
  "voiced_replies": true,

  "twitter_names": [],
  "twitter_api_key": "",
  "twitter_api_secret": "",
  "twitter_access_token": "",
  "twitter_access_token_secret": ""
}

Twitch has dropped support for the old API, so stream info wasn't working anymore.
I updated the bot today (106ae7112ee843bb8cfb1e93eff42ecad841a4c8) so it now integrates with the new Twitch API (Helix). This complicates set up somewhat, so I've updated the README file as well.
This whole update needs more testing, but stream notifications should work again.

This is working perfectly now, I do have one quick question, is there any way I could implement using the user profile picture instead of a thumbnail from the stream?

The API endpoint that I'm currently using (/helix/streams) doesn't have that information, so the way to implement this would be to request channel information separately by hitting /helix/users which gives you the profile_image_url.


Samples File Creation Tool for metaQuantome

Looking to add another module to the metaquantome branch.
@caleb-easterly With this tool, we might need to remove the MAKE_SAMPS_TSV token in the macros.xml, unless we are thinking of incorporating this in each of the other modules.

@caleb-easterly Let me know if you want me to update the version in the macros.xml file. Currently, it is 0.99.2.g1.

Thanks @jraysajulga! I'm doing some tweaking but I'll merge it for now

@caleb-easterly please note that every merge will trigger a TS upload.
We should minimize the TS version and only merge if we really want to have a upload.
I will stop the upload ok? And then wait for your changes?

@bgruening I assumed that was only true for merges into master. Is that true for merges into any branch?
But yes, I wasn't intending to upload to toolshed, so if that is happening stopping it would be great. Thanks!

Uh, my fault. Sorry you are completely correct.


Bump native iOS Sentry dependency

Includes a security update https://github.com/getsentry/sentry-cocoa/releases/tag/3.10.0

Hey, thank you for submitting the PR.
I already did it (https://github.com/getsentry/react-native-sentry/pull/310) and will make a release today, closing this one.


feat: Add Emoji flag to the language selector

Preview: https://excalidraw-git-emoji.excalidraw.vercel.app/

[ ] Test on all supported browsers

[x] macOS
[x] Windows
[ ] Linux
[x] Android
[x] iPhone

[ ] Fallback?!

:+1:
Win7 doesn't display the flag, but to hell with Win7 (and it also has a textual fallback):

Win7 doesn't display the flag, but to hell with Win7 (and it also has a textual fallback):

It's around ~1% of our userbase on Analytics..

looks cool ❤


Add a jenkinsfile to build the clickhouse custom image

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Adding a Jenkinsfile to build a custom image including zlib compression.

My bad. Wrong place for this PR


new package: gnupg2 2.2.19

Description of package
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

I get this warning:
gpg: NOTE: THIS IS A DEVELOPMENT VERSION! gpg: It is only intended for test purposes and should NOT be gpg: used in a production environment or with production keys!

Can't seem to figure it out.
On another note we can replace the 'mv's at the end of the script with --enable-gpg-is-gpg2

i've been using this package heavily for two weeks without issue (signing git commits, encrypt/decrypt files) I too can't figure out what the warning is about. Our gpg version here is the same as Arch Linux at present. I'm not worried about it.

Can't seem to figure it out.
On another note we can replace the 'mv's at the end of the script with --enable-gpg-is-gpg2

nice catch thanks

should be good now


New interface to implement DROOLS-995. Exposes rule properties for ru…

…ntime rule inspection.
Initial idea which implements DROOLS-995. Exposes most rule properties for runtime rule inspection.
Note that I couldn't expose the getTimer() method via this interface, as it returns a Timer, which is a Drools internal class.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@DuncanDoyle Test? If only to show use and enforce backwards compatibility? Thanks.

@mrietveld: I looked at that (before I created the PR), and the kie-internal project doesn't really contain tests (other than the KieMetaTest). This PR is actually part of another on: https://github.com/droolsjbpm/drools/pull/579
That PR changes the interface of RuleImpl from Rule to InternalRule (the interface added in this PR). Other than that I didn't change much, I'm just exposing the already existing methods via this interface so we can do more runtime rule inspection, and not having to depend on the Impl class (and I added two small methods to expose the Salience of a rule without the need of the Salience class in kie-internal).
I've tested the other PR using the standard Maven build (mvn clean install), and the new intermediate interface seems to work fine (well, no test-failures AFAICT).
So, long story short, I'm not entirely sure how to write a test for the interface in this PR. Any suggestions?

Add or extend a test in drools-core (as part of droolsjbpm/drools#579) that uses the 2 new methods (getSalienceValue, isSalienceDynamic).
Would that be possible?

OK, will do that. Will add a comment here when I've added those tests.

Unit-tests for 'getSalienceValue' and 'isSalienceDynamic' added to this PR: https://github.com/droolsjbpm/drools/pull/579

Merged by https://github.com/droolsjbpm/droolsjbpm-knowledge/commit/044c3a0b8a0f7c93100339f142397988c16d7dde


fix: .map is not a function

Resolves #573
Current bug page
Preview of fix

This issue is fixed by @Megha-Dev-19 her PR #571


pkg/wait: make id checking stricter

/cc @heyitsanthony Let's try to catch duplicate id earlier...

lgtm


Logging capabilities for Auth and Access

The structurizr.log isnt currently logging either.  This is a security issue that I need to rectify.

I've added some success/failure logging for the file system and LDAP based authentication methods.


Update sp-add-job-transact-sql.md

Fix markdown formatting

Looks good; thanks, @0x7FFFFFFFFFFFFFFF

Due to the upcoming conference, all merging and publishing are on hold until the morning of 5/23.
This PR is ready for merge on 5/23.
#label: "event-triaged-to-10AM"
#label: "missed-content-complete"


Make syslog available

In the light of issue #1363 jason is going to make syslog available somewhere, probably in S3 so we can get it at, will help #1244.

Currently testing syslog on -dev. We should be able to deploy this to stage and prod during our next push.

Enabled on -dev, stage and prod for the last few days. Logs are being synced to S3 and can be accessed using https://mana.mozilla.org/wiki/display/SVCOPS/AMO+Dev+Resources#AMODevResources-Syslog


mps2_an521_ns: fail to handle user_string_alloc_copy() with null parameter

Describe the bug
When I push this PR #40830 to validate string_alloc_copy() API with null parameter,
CI got blocked. Test stucks at arch_user_string_nlen().
It works fine on other platforms.
To Reproduce
see #40830
Expected behavior
CI should be running smoothly.
Impact
Showstopper
Logs and console output
[1;34m[Sec Thread] Secure image initializing![0m
[1;34mBooting TFM v1.4.1[0m
[1;34m[Crypto] Dummy Entropy NV Seed is not suitable for production![0m
*** Booting Zephyr OS build v2.7.99-2075-g75ac3364c2e9  ***
Running test suite syscalls
===================================================================
START - test_string_nlen
 PASS - test_string_nlen in 0.1 seconds
===================================================================
START - test_string_nlen
E: syscall z_vrfy_string_nlen failed check: Memory region 0x281008f0 (size 24) read access denied
 PASS - test_string_nlen in 0.2 seconds
===================================================================
START - test_to_copy
E: syscall user_copy failed check: Memory region 0x281008d0 (size 32) write access denied
 PASS - test_to_copy in 0.2 seconds
===================================================================
START - test_user_string_copy
E: string too long 0x10e1e7 (32)
E: syscall user_copy failed check: Memory region 0x281008f0 (size 24) read access denied
 PASS - test_user_string_copy in 0.3 seconds
===================================================================
START - test_user_string_alloc_copy
E: string too long 0x10e1e7 (32)
E: syscall z_user_alloc_from_copy failed check: Memory region 0x281008f0 (size 24) read access denied

Environment (please complete the following information):

OS: Linux
Toolchain zephyr-sdk-0.13.2
Commit ce99227ad4fbfd08e5d2df4200684f818bc426bf

Reproduced while connected with GDB. I'll post what I find.

It looks to me like this test case is generating a secure falt, which is handled by tf-m, instead of the normal zephyr fault handling on the invalid address 0xffff_ffff. Since the tf-m secure fault handler just spins, we get stuck and timeout the test.


$this->at(0) does not work

Is there any reason why this does not work?
$timeMock = $this->getFunctionMock(__NAMESPACE__, "time");

$timeMock->expects($this->at(0))
    ->willReturn(1);

$this->assertEquals(1, time());

$timeMock->expects($this->at(1))
    ->willReturn(4);

$this->assertEquals(4, time());

Wrong order of the setup.


Added git implementation and integration tests.

What?
Added git implementation and integration tests.
Type of change?

[x] [feat]: A new feature

How has this been tested?

[x] Unit tests
[x] Integration tests

Before submitting a PR please make sure to check if:

[x] The code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] The changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

@ebbauer Yeah, I need to commit this backup file once it restores GitLab backup to the container during this project CI.


WIP: Adding in fsync-like capabilities to HasBlockIO abstractions

Description
Adds "file synchronization" capabilities to the blockio-api and blockio-sim packages. This includes fsync and fdatasync on POSIX systems (includes MacOS).
The new function added to the HasBlockIO type-class for "flushing" buffered data to the storage medium is hSynchronize.
I'm handing this PR off to @jorisdral.
Next steps:

[ ] Bikshedding whether to use American or British English, potentially renaming to hSynchronise.
[ ] Ensure that hSynchronise works on Linux.
[X] Ensure that hSynchronise works on MacOSs.
[ ] Ensure that hSynchronise works on Windows.
[ ] Ensure that there is no other missing call sites/hooks that need to be added.

Superseded by #482


Seems broken after upgrade?

I've updated c5 and Community Store to latest versions (8.4.3 and 1.4.2) and Stripe payments have stopped working.
Error on screen: Something went wrong with this transaction.
In the Stripe Logs:
The request POST body looks like this:
{
"amount": "100",
"currency": "GBP"
}
And the RESPONSE body:
{
"error": {
"code": "parameter_missing",
"doc_url": "https://stripe.com/docs/error-codes/parameter-missing",
"message": "Must provide source or customer.",
"type": "invalid_request_error"
}
}
Looks as if we no longer send the customer data through?

I just tested on a 8.4.3 site, with the latest community_store_stripe from master, both the button and the form worked correctly for me.
In terms of customer data, it doesn't send that through as such, I think it's referring to the 'source' being missing, which in this case is the token that comes from the form.
Are you using the button or the form in this case?
Are there any javascript errors on submit of the CC form?

You're right it is a js error.
It's related to another problem I had when switch URLs to have trailing slashes in config.
The URL https://www.zoejenkinsart.co.uk/packages/community_store_stripe/js/jquery.payment.min.js/
Does not load with the trailing slash in place.

It's a bit hacky, but what if you tried replacing line 2 in elements/strip/stripe_form.php with this:
<script src="<?= str_replace('/index.php/', '/', rtrim(URL::to('packages/community_store_stripe/js/jquery.payment.min.js'), '/')); ?>"></script>

That works - thank you

Great, I've pushed up that as a fix to the master branch. I can't think of a better way to handle it.


Stop heartbeat when there is an issue connecting to the server

It's not a super common case, but I noticed this would indefinitely spam the log message instead of properly disconnecting if I closed my laptop case while SSHed into a machine.
cc @docker/machine-maintainers for review
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

LGTM


Depend on target generated by rosidl_typesupport_cpp

The target generated by rosidl_typesupport_cpp depends on the target generated by rosidl_generator_cpp, and adds a library implementing things necessary to use C++ generated messages

CI (build: --packages-above-and-dependencies rmw_dds_common test: --packages-select rmw_dds_common)

Linux
Linux-aarch64
Windows

CI LGTM - the Windows CMake warning is also in the nightly: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2256/cmake/new/


Add a property hint range to Auto Refresh Interval editor setting

This prevents using zero or negative values, which are invalid and will cause various issues in the editor (such as the inspector never updating until the editor is closed and reopened).

Thanks!


Connection to factorio headless server dropping after 12 hours

I don't know what is happening, but it breaks.
I launch with the following code, which is supposed to auto reconnect,
client.on('authenticated', function () {
		console.log('Clusterio | Authenticated!');
		instanceManagement(); // start using rcons
	}).on('connected', function () {
		console.log('Clusterio | Connected!');
		// getID();
	}).on('disconnected', function () {
		console.log('Clusterio | Disconnected!');
		// now reconnect
		client.connect();
	});

I think a timeout event should be added to gracefully recover from connection timeouts. Let me look into this and reproduce a flaky server.

the problem could be due to this. when the timeout event occurs, we call end on our side (send FIN packet to remote server)
i need to research/experiment with net.Socket a bit semantics to confirm my theory. will report back soon!

also, on the note of adding a timeout event, we would do it on the same line mentioned in my previous comment

so i kind of misread everything here... sorry about that.
@Danielv123 we can add an auto-reconnect option so that you don't have to use the pattern you've shown above.
the option would apply when timeout or disconnect occur, but not when calling close. then, regardless of the side from which the connection is dropped, it's just always re-established.

Been looking around and we have more or less found the cause of the issue. Somehow, multiple commands get bunched up in the same packet triggering the length limit of 10k characters.
Each command sent to rcon.exec() is checked to be below 3000 characters.
I managed to capture the following package with wireshark package
You can find the start of each package by searching for lent-command. At the end of the package there is an unix timestamp, but its the same for all the commands meaning its the exact same command that the library has duplicated 4 times.
Symptoms: Rcon server dies, stops responding. No error is sent, so connection does not reset.


[web] Transparent image is rendered incorrectly, showing artifacts

Steps to Reproduce

Execute flutter run on the code sample using stable (Flutter version 3.0.4 and Dart version 2.17.5) or beta (Flutter version 3.1.0 and Dart version 2.18.0-44.1.beta)
Run it using DartPad: https://dartpad.dev/?id=b1be851627092bd10bb4ddc520bbaa44

Expected results:

Actual results:

Code sample

import 'package:flutter/material.dart';

const Color darkBlue = Color.fromARGB(255, 18, 32, 47);

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.dark().copyWith(
        scaffoldBackgroundColor: darkBlue,
      ),
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: MyWidget(),
        ),
      ),
    );
  }
}

class MyWidget extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: [
        Image.network(
        "https://storageeditor2.blob.core.windows.net/assets/Bottle-Regular.png")
      ],
    );
  }
}

Logs

Hi @pietervp, it would appear that this issue has been fixed on the master channel. See the screenshots below.
I'll be closing this as it has been fixed on the master channel. If you do run into this issue on the master channel and any versions beyond that, kindly leave a comment below and I will reopen this issue.
Thank you

screenshots

stable
master

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.4, on macOS 12.4 21F79 darwin-arm, locale en-GB)
    • Flutter version 3.0.4 at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 85684f9300 (5 days ago), 2022-06-30 13:22:47 -0700
    • Engine revision 6ba2af10bb
    • Dart version 2.17.5
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8609683/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 2021.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8609683/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • iPhone 13 Pro Max (mobile) • FD5949EA-E739-4960-9E9D-16F3DE69816E • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1507, on macOS 12.4 21F79 darwin-arm, locale en-GB)
    • Flutter version 3.1.0-0.0.pre.1507 on channel master at /Users/nexus/dev/sdks/flutters
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 86639977ba (3 hours ago), 2022-07-06 01:14:08 -0400
    • Engine revision d7b6d9bbc0
    • Dart version 2.18.0 (build 2.18.0-257.0.dev)
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-32, build-tools 31.0.0
    • Java binary at: /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8609683/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] Android Studio (version 2021.2)
    • Android Studio at /Users/nexus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/212.5712.43.2112.8609683/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.68.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • iPhone 13 Pro Max (mobile) • FD5949EA-E739-4960-9E9D-16F3DE69816E • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-5 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 12.4 21F79 darwin-arm
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@danagbemava-nc thanks for checking this! Any insights as to when / if this fix will land in a stable release?


How to add a new module?

Hi, I am a bit new to browserify and gulp. If I wanted to add an external module, for example: socket.io how would I go about doing it in the correct way?

You should be able to do this via npm and Browserify:
npm install --save-dev socket.io
import io from 'socket.io';

// can now use socketio

https://www.npmjs.com/package/socket.io

Thanks!


add codecov to CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6cf26e9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage        ?   92.49%
=======================================
  Files           ?       15
  Lines           ?      653
  Branches        ?        0
=======================================
  Hits            ?      604
  Misses          ?       49
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf26e9...dc4957b. Read the comment docs.


inconsistent default values in array

For a column of type : Array(Nullable(Float64)) the default value is considered 0 and not NULL
For example if you do:
SELECT array_field[4]  from table

where that element on that index is not existing you receive 0 instead NULL.
From documentation doesn't seems to be a bug but it's not a consistent behavior.
What I mean is the default for Nullable(Float64) fields is NULL, for Float64 is 0 and for Array(Nullable(Float64)) it's also 0 not NULL as you are expecting.

Fixed in master.


Update documentation link

As agreed, I updated the link to contains the current version instead of latest.


Update gemmlowp version for cmake build

The gemmlowp has been updated in bazel, though
cmake version was not updated. This fix updates
gemmlowp in cmake so that cmake and bazel versions
are synced.
The fix has been tested on Linux:
tensorflow/tools/ci_build/ci_build.sh CMAKE tensorflow/tools/ci_build/builds/cmake.sh

Signed-off-by: Yong Tang<EMAIL_ADDRESS>

Looks like the Windows make build is failing, closing for now.


docs(snap): update snap/README and README

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Could you please review this? Thank you! @farshidtz @siggiskulason

todo: simplify snap section and add docker section too


Update CocoaLumberjack dependency version to 3.x

Not tested yet

Looks like it can be compiled with CocoaLumberjack 3.0.0 without any warnings and errors.

Why not to merge?

Or it should have a new major version too? 3.0.0?

I should have time to look at this and publish to trunk this afternoon.  Thanks for the PR

I updated the repo to depend on CocoaLumberjack 3.0 and revved the version of this library to 3.0.
I'm running into some issues pushing to Trunk right now, so in the meantime, you can add :git => git@github.com:TechSmith/CrashlyticsLumberjack.git  to the CrashlyticsLumberjack line of your podfile to pull straight from here.


Documentation for integration to chirpstack

FEATURE REQUEST
I am running the docker services, there is a link to "Admin > Lora Server", but none of the users are able to login.
Please could you point / provide a HowTo for mainflux <=> chirpstack / lora server

Official doc: https://mainflux.readthedocs.io/en/latest/lora/
Blog (tutorial): https://medium.com/mainflux-iot-platform/mainflux-lorawan-tutorial-c54632ffee99

@dcolley By default our lora-adapter is configured to subscribe to the Chirpspack MQTT broker demo located at tcp://lora.mqtt.mainflux.io:1883. You can configure it here: https://github.com/mainflux/mainflux/blob/master/.env#L130
On the UI side you can configure the Admin / Lora Server page here: https://github.com/mainflux/ui/blob/master/src/environments/environment.prod.ts#L28

thanks guys!


[enhancement]: (fix) Clean right-click functionality

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Fix for the right-click functionality, so that it doesn't sometimes open the browser context menu instead of the invokeai context menu.
Insert this into <head> of .venv\Lib\site-packages\invokeai\frontend\web\dist\index.html:
<script type="text/javascript">'use strict';!function(){ window.oncontextmenu = () => false; }();</script>

This completely eliminates the browser's right click, atleast for me.
Alternatives
No response
Additional Content
No response

We definitely want to allow the browser's right-click functionality in some places, so we aren't going to do a blanket no-op like this.
Where are the specific issues with right-click?

@psychedelicious I use keyboard shortcuts for most operations but I understand people who don't.
It happened on Firefox in the right gallery pane, I've added that JS locally some days ago so I am not really sure where precisely.
Was just occasionally and always when I didn't need it to, so I mostly clicked something random each time because I was expecting the InvokeAI context menu. I did had a feelling that it's an event-timing thing - perhaps a fast/short-click with slight mouse-move could've possibly triggered it instead of ivokeai's, I didn't do any explicitly testing of it so I don't know the reason. Once I saw it triggered both of them, the browser's context overlaying the InvokeAI's context from one right-click, I disabled it.
You can use event in oncontextmenu and disable it for just the targeted event.srcElement element/s if you want.

Maybe you were right-clicking between the images, but if you are getting the native context menu on top of the app context menu then I think there's more to the issue.
Can you please undo the change you made so you can recreate the issue and upload a screen recording?

I tried testing it & I figured out that my PC needs to use more resources and start lagging so that JS starts running slower than the browser and the browser-context triggers before the onmousedown/onclick event, this is it.
The recording wont be needed, I found the state in which it happens, when JS is Invoking and I have high CPU+RAM usage when I fast click around (which makes sense).
But I want to isolate the context menu from ever appearing, I use shift+right-click to force-open the browser's context menu, because this issue is not specific to your web UI, I ran across similar issues on different websites that have custom context menus like web-mails or web-IDEs, but it happens rarely.
I recently upgraded my PC so I'll need to observe if it even happens at low-resource usage.

Thanks for digging into the issue. I don't think we want to make any changes to the app, because generally the context menu works as intended.

Yes it works great, I reverted my changes since then.


Mo tro162 gown page

There needs to be a component made for the Mobile page button...or I need to make it from scratch.  I am sure some fine tuning can be done, but I think this is close enough for an initial code review.

@mdrisco4 Looks like you have some merge conflicts!

All taken care of!


[Breaking Change] Update Firestore Queries and fix Conformance tests

cc @schmidt-sebastian
This change should bring PHP into line with the latest requirements for Queries.

[Feature] Query position methods (i.e. startAt, startAfter, endBefore, endAt) now accept either an array of values or a single DocumentSnapshot.
[Breaking] Query::select() now overwrites previous selects rather than merging/appending.
[Bugfix] Query::documents() now correctly handles setting maxRetries to zero.

Closes #851.

Friendly ping here. Would like for the first review to be touched on before I delve in too deep.

I'll be moving back to this once the other priorities are out the door. There are several other things beyond the restructure and review which need to be resolved. I'll give you a heads up when it's ready for your review!

I'm working to decompose those into several pull requests. The first can be found at #1161. Another is forthcoming for snapshot cursors, and another in a few days for conformance.


Add a Doctrine 2 Events tab

Like Z-Ray ZF2 Events tab we can also add a Doctrine 2 Events tab. Maybe we can add some more information, e.g. which entities are used by this event.
Any further suggestions?

done


pkg-linux-debug tests failing on newly added bot

pkg/analysis_server/test/src/plugin/plugin_manager_test is new and failed (RuntimeError, expected Pass)
pkg/dartfix/test/src/driver_test is new and failed (RuntimeError, expected Pass)
pkg/vm/test/kernel_front_end_test is new and failed (RuntimeError, expected Pass)

@athomas - how should we triage / label these?


🐞 Search Results are in lowercased letters

Description
When conducting a search, I observed that the search results are displaying text in lowercase, deviating from the original case of the text.
To Reproduce

Go to search
Search something 🫣

Expected Behavior
The search results should accurately reflect the original case of the entered text.
Version Information
CodeEdit: [e.g. 0.0.x-alpha.y]
macOS: [e.g. 13.2.1]
Xcode: [e.g. 14.2]
Additional Context
No response
Screenshots

I think I'll fix this one with one of the later UI PR regarding the whole search area.


MSID: 88049 Version: 1 DOI: 2<IP_ADDRESS>0833

"msas": "Biochemistry and Chemical Biology"
"msid": "88049"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>0833"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."
"Reviewed Preprint posted": "2023-05-11"
"Sent for peer review": "2023-03-21"
"Posted to bioRxiv": "2023-04-15" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>0833v2")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=88049)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[x] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/88049/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews
Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0833)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/88049)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/689
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/88049

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/88049

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/88049/v1/88049-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/88049)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Affiliations are somewhat broken. Needs reimport following https://github.com/elifesciences/enhanced-preprints-biorxiv-xslt/pull/29.

@QueenKraken, there's an issue with this one that I raised via the EPP engagement form. I'm not going to let is hold up publication, but it stems from Encoda and would be great if the fix could be prioritised.
Basically the content of nested lists are duplicated, and this article is affected by this:

Encoda ticket created: https://github.com/elifesciences/enhanced-preprints-issues/issues/647

Thanks


replace current how to cite in the footer

Perhaps add https://www.ncbi.nlm.nih.gov/pubmed/30275573 ?

... also update the docs.


customizing docker daemon to listen on internal addresses

Thank you so much for writing this repo.
An interactive shell would be invaluable to me, but I cannot figure out what you mean by "customizing docker daemon to listen on internal addresses."
I see the comand iptables --insert INPUT 1 --in-interface docker+ --protocol tcp --destination-port MYDOCKERPORT --jump DROP here. should I run my docker command with a -p MYDOCKERPORT option? Should I run the iptables command on my laptop. Would this allow me to interactively exec into a container in ecs?
Thank you.
-Daniel Vizzini

@dvizzini The command is a security enhancement for the containers.
To allow you to execute commands into a container, the container instances need to listen on a port to allow communicating with the docker daemon API on the container instances from your computer.

Thanks.


Unknown column 'Tagged.fk_table' in 'on clause'

I'm trying to accomplish a search on several fields, including tags.
When trying to use matching or innerJoinWith Tags, I'm getting that error. Following on the query that is generated by CakePHP, I get the following (fragment of query)
...
INNER JOIN tags_tags Tags ON Tagged.fk_table = 'projects'
INNER JOIN tags_tagged Tagged ON (Projects.id = (Tagged.fk_id) AND Tags.id = (Tagged.tag_id))
...
Resulting in a crash error:
Unknown column 'Tagged.fk_table' in 'on clause'
Thanks!

What does your behavior configuration looks like?

Same as default one, haven't changed it. After following the instructions and include the behavior in the models, tag saving is working great, just found this bug when using Tags with matching and innerJoinWith like this:
    $projects
                ->where(['LOWER(Projects.name) LIKE' => '%'.$search.'%'])
                ->orWhere(['LOWER(Projects.objectives) LIKE' => '%'.$search.'%'])
                ->orWhere(['LOWER(Users.full_name) LIKE' => '%'.$search.'%'])
                ->orWhere(['LOWER(Tags.label) LIKE' => '%'.$search.'%'])
                ->orWhere(['LOWER(Products.name) LIKE' => '%'.$search.'%'])
                ->matching(['Tags'])
                ->group(['Projects.id']);

If I include the like sentence in the matching/innerJoinWith query as a closure is the same result, trying to extract it as a custom finder. I've given a good 4hs going around and the only solution I found is to customize behavior configuration just for that query. But I was wondering if there's some other workaround that would avoid doing that (because I personally think that's a pretty ugly solution)
Thanks!


Allow comments to be sent in sseClient

The sseClient spec allows comment blocks to be sent, which can be useful when implementing a keepalive.
To guard against sending 'other' data, ensured multiline comments passed in should be split and all sent as comment.
I'm planning on using this in teku to implement  a keepalive function so that sse clients aren't having to reconnect quite as often as they seem to need to currently.
I really don't know kotlin at all, so happy to take feedback on what I've done and clean it up... My theory is this is a really small change so I didn't end up creating a separate issue, but can if that helps workflow.

I'm basically working from https://html.spec.whatwg.org/multipage/server-sent-events.html#authoring-notes
Technically a comment line is a line starting with ':', so could potentially just go ':comment'. if we were putting it into a constant, that would probably be the 'correct' thing, I could not put the space separator in, just looks easier on the eyes if you're actually debugging a stream, but I'm happy to take guidance on that...

I'm happy with the update to put the comment prefix into a const, ship it :) thanks!


Restoring some media from web.archive.org

My Twitter archive is missing 26 images for which https://pbs.twimg.com/media/ replied with 404 errors.
(From 118,049 tweets, not bad.)
For example, I RTed this tweet from @beep:
https://twitter.nicolas-hoizey.com/1042801550681362433/
The image is missing. Or hidden in Ethan's now private account, maybe?
But I could find it on web.archive.org:

Should I wait for @beep's authorization to use it in my archive, as it's not public anymore?
I have anyway yet to find how to tell tweetback that I have it, it doesn't need to continue asking Twitter for it.
There's probably something to change in the database.
This could be documented, if other people want to try adding missing medias.

I would also love to know about this! I'm considering saving the image and naming it with the filename that comes after /media/ in the original image URL and putting it in the img folder, to see what happens. I will update this when I've attempted, to let you know what happened.

cross-referencing against #35 and timhutton/twitter-archive-parser#153


{RDBMS} Fix firewall rule validator bug

Related command

Description

Fixing bug where firewall rules are treated as string. The IP addresses should be converted into integers instead
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

RDBMS


[Java] Find a proper way to test VM options (share system property between Main/Test code)

Describe the enhancement requested
Java Test code and Java Main code cannot share system property variables.
The current workaround is to use reflection on unit testing code to override main code system properties.
We need a complete solution that covers JDK17+ Java versions without reflection access to test for example System.getProperty(DEBUG_ALLOCATOR) at https://github.com/apache/arrow/blob/main/java/memory/memory-core/src/main/java/org/apache/arrow/memory/BaseAllocator.java#L52
Component(s)
Java

@danepitkin @davisusanibar I am moving this to 14.0.0


Address race condition in ScriptMenu.

List.copyOf seems adequate to address the frequent ConcurrentModificationExceptions, but it most likely just makes the underlying data race less frequent.
Replacing these with synchronized lists is insufficient, as even synchronizedList requires explicit synchronization when using an Iterator.

Walk me through, please.
The Concurrent Modification exception comes from iterating over a list.  copyOf makes it so that iteration is over a copy of the list and thus no exception should be possible.  However that is not acceptable if the list can change while it is being copied.
The list has possible sources.
One source is now a Collections.synchronizedList which in practice means it won't be changed while it is being copied.
The other source (scriptMRU) is now a ConcurrentLinkedDeque which in practice also means it won't be changed while it is being copied.
Not using the same object type in both cases kind of makes sense since the scriptMRU adds to the head and deletes from the tail.  Adding and removing from scriptMRU are already synchronized so this change in object may mean the synchronization can be removed.
What actually gets used in the ScriptMenu.init if the MRU is used is a new list that is created from a synchronized copy and reformat of scriptMRU.  This suggests to me that the race condition is not caused by the scriptMRU getting updated since the iteration is over a copy.  Nevertheless the object change may make it so the ScriptMenu operations do not need to be synchronized which sucked up a lot of wall clock time.
Anyway, I think this will at least reduce the frequency of occurrence.

The previous ConcurrentModificationException as we saw in tests came from

iterating over KoLConstants.scripts in ScriptMenu.init() while
GenericFrame.compileScripts() rewrote the same list, element-by-element.

Java Iterators in particular are rather fickle, and backing them by a synchronized collection is insufficient as they aren't atomic -- if you modify a list, any extant Iterators would enter into an inconsistent state, so they detect this failure mode and throw an exception.
By using copyOf, no other thread has access to the resulting object, and so we can iterate over it without fear of data races.
You're correct that I made the switch to thread-safe collections specifically so copyOf would be safe (even though that wasn't a failure mode I personally saw in testing). We theoretically could have both structures as ConcurrentLinkedDeques, but certain methods have different performance characteristics (e.g. size() isn't a constant-time operation).
I'm not sure whether we can drop synchronization of ScriptMRUList entirely, since we would lose atomicity of various operations, and concurrent accesses could expose intermediate inconsistent states. If the class is appropriately synchronized, then we could probably revert the ScriptMRUList changes I had here.

Thank you.  I think we should try this as is.  Synchronization of ScriptMRUList can be dealt with later.  There are also issues with building the menu as noted at https://kolmafia.us/threads/scriptmenu-init.28535/#post-171054 so it may be that dealing with that will change the race condition.


Player not starting...

So, long story short. Upgraded system, moved files over to nvme, and have been working on getting things set back up. Got spotify_player working again a couple of days ago. Get a message from Spotify this morning that they noticed "sus" activity and changed my password for me. Got my password updated. Now spotify player will not start even after re-registering with my account.
Error:
Error: initialize new Spotify session

Caused by:
    0: new streaming connection
    1: initialize spirc
    2: Permission denied { Login failed with reason: Bad credentials }

I have been working on trying to figure this out. going so far as to create a new app on spotify to get a new client ID.
I also tried using the ID form the docs, but nothing. Looked around for a bit but didn't find anything that helped.
OS: Xubuntu 24.04
Version: 0.20.1

try to re-authenticate the application with spotify_player authenticate or delete the cached credentials.json in ~/.cache/spotify_player then re-run the app

I've done this and I still see there error. I also do not have a ~/.cache/spotify_player folder.

@aome510 Just wanted to touch base. I haven't had a chance to try this out myself. Been traveling for work this week. But I installed player in my worklaptops wsl term, and it loads just fine. Except for there is no spotify deamom for it to connect to, but I was just testing the launching and connecting it to my account. Should get back home tonight to see if this works for me.

@aome510 That fixed it!! Thank you. Done on my end. Not sure if you want to leave this open for evolutionxobx's issue or not.

I think it might be something unrelated. Will close this for now

@aome510 I'll create a new ticket if I can, because no matter how many times I run spotify_player authenticate (and follow the link) no credentials.json is created.


Scroll spy on body breaks page when no scrollbar present

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
The issue
When adding scrollspy to the body element with something like  the page will break when there is no scroll bar and be fine if there is a scrollbar. This becomes a problem when you don't know if the viewport will be able to fit the full page or if it needs a scrollbar. The error in console:
Uncaught TypeError: i is null
    _activate scrollspy.js:224
    _process scrollspy.js:191
    An scrollspy.js:80
    <anonymous> scrollspy.js:283
    <anonymous> scrollspy.js:283
    i event-handler.js:102
    N event-handler.js:207
    on event-handler.js:241
    <anonymous> scrollspy.js:281
    <anonymous> bootstrap.bundle.min.js:6
    <anonymous> bootstrap.bundle.min.js:6

What is expected to happen
The page should behave the same way if the page is fully displayed and if the page has a scrollbar.
What exactly breaks
Not sure, something in scrollspy but the main issue for me is that it inexplicably deletes active class from nav-link items in an unrelated (nothing points to it)
 masthead with nav.
Sharing initial findings

Missing element of data-bs-target is not the root issue. The correct nav and nav-link targets can exist on the page, but IF (the nav-link element target, e.g. the element with
id="about"
 targeted by , does not exist ) && ( the html fits in the viewport) THEN scrollspy breaks. It basically breaks when both: no nav-link item is present, declared or undeclared, and when the page does not have a scroll bar.

I could avoid this being an issue if I only enabled scrollspy in  on pages that actually utilize it but with my current suboptimal but simple php templating structure which has a "top.php" (html, body, header) and "bottom.php" (footer, /body, /html) structures it is a bit much to change the entire structure and flow of this site to address this unique bug. I would expect it to work on my pages that utilize it and on my pages that do not utilize it.
Why should this be fixed, a potential valid use case separate from mine:
Lets say someone has a scrollspy activated on body because they will utilize it on the page, but the page is not fully populated yet so for now viewport fits the entire page (X). But upon further user input the page shows new content and the scrollspy is refreshed by the page as specified and the scrollspy is engaged. Problem is the page already broke where I marked the (X).
Reduced test cases
Reduced test case: https://codepen.io/avwon/pen/GRONdbd (reload page when resizing to show a scrollbar or when to show the entire page)
How to test:

NO BREAK (browser resized for scrollbar to show)

BROKEN (browser resized for no scrollbar)

What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
v5.1.3

I slightly misdiagnosed the cause of the issue. Its not that there does or doesn't need to be a scroll bar for it to break. Its that when you reach the end of the page and don't have any targets it will break.
So it comes down to, should we be able to enable the scrollspy  without actually utilizing it on the page and have it not break itself?

Thank you @GeoSot,
Tried it on my project, replaced:

with:

The uncaught type error is no longer triggered when reaching the end of page on pages not utilizing it.
But, the Scrollspy no longer functions as it did before on pages utilizing it, it is now simply stuck (active nav-link) on my second item no matter where I am on the page as soon as the page is loaded in.

Can you provide me a demo to help me debug it?

https://codepen.io/avwon/pen/GROWEMb
Sorry, was busy. So, I basically copied and pasted 80% of my site. You can see that when your preview script is enabled the second item is active right out of the get go but starts functioning properly once you start scrolling. If you go down to the bottom and swap it to 5.1.3 release it will not be active on page load and behave as expected.
However, I was not able to replicate the other bug with this that I am experiencing on my project where for me it does not get unstuck at all even tho its almost the exact same page layout. The only difference is that I have a script which populates part of the document after the page is loaded. Perhaps there is an additional bug that happens after you make element additions to the document which makes scrollspy stop tracking all together. It works as expected if I used 5.1.3 release.

Thank you for this demo.
If you use scrollspy.refresh() in both cases, it should re-calculate everything
As for the preview version, you helped me debug,  the problem is caused because IntersectionObserver  scans  whole body (observable) , and body is not restricted in vh. So it pick ups the latest item in view. I 'll try to hack it a bit.

I will try refreshing scrollspy in a bit, thanks!
Small correction to what I said earlier, on my personal project my scripts that generates additional DOM elements are executed before the bootstrap bundle is executed since scripts are executed in order they are encountered in the page. So I am still not sure why there is a different behavior between the codepen (gets stuck on item 2, unstuck when scrolling) and my personal project (gets stuck on item 2, remains stuck when scrolling), but hopefully one is just the byproduct of the other and the current fix you are working on fixes both.

If you achieve to replicate the issue on your codepen demo, I could give it a look. Thanks again for your help

To be honest, I do not want to get involved with the existing scrolspy implementation, as I am trying to get approval for the IntresectionObserver implementation (the last 6 months :P), and it is so close.
As for the difference, I think is the IntresectionObserver that picks the first element, but I cannot figure out a solution, yet

Oh okay, got it. If I have the the time I will see if I can reproduce the perma stuck situation with another codepen eventually and then we can leave it at that until you get the opportunity/approval to implement what you need.


 I think I will revisit again and future and see if I can clean it some.

good... for now :fearful: :fearful:

@newoga Thanks!


Question: How openebs_actual_used metric is calculated

Hi. I am using openebs with jiva backend storage. I've added a huge file to that volume and then removed it but this metrics (openebs_actual_used) didn't decreased. I also executed fstrim command on that volume and ls -rlth shows right (decreased) size in total section. My question is how openebs_actual_used metric is calculated?
In below image actual used is about 6 Gig and openebs_size_of_volume is 50 Gig but openebs_actual_used returns about 49 Gig.

Hi bbkgh. In this case a couple of things are happening:

data is written into ext4
ext4 is mounted without unmap - which is what really recovers the deleted data. (Jiva doesn't yet support unmap feature).
So as data is written and deleted, you will notice the following:
du -h ( from within the application pod - will show the correct usage. kube-state metrics of used will reflect this size)
as ext4 doesn't reclaim the deleted blocks, jiva will continue to show them as used.
thanks for reporting the issue, this is a limitation with jiva.

I have created an issue to track it.

@utkarshmani1997 @payes  Is this a documentation update?


dfd

Value: $500.00Closes: Friday, February 23, 2018Location: Victoria Some in-person work requiredOpportunity DescriptionzzAcceptance CriteriazzxzHow to ApplyGo to the Opportunity Page, click the Apply button above and submit your proposal by 16:00 PST on Friday, February 23, 2018.We plan to assign this opportunity by Friday, February 23, 2018 with work to start on Thursday, February 22, 2018.Proposal Evaluation Criteriaadada

Test issue, closing