github: Introduce a feature graduation tracker template

/cc @xpivarc
/cc @vladikr
/cc @EdDev
What this PR does
As discussed at the unconference for v1.5.0 [1] we need to track existing and new FGs through the various graduation phases to GA moving forward.  This commit introduces a simple GitHub template to help folks start this process.
[1] https://unconference.kubevirt.io/D62SngbSRXO1uhTAc8Ikqg#xpivarc-Feature-lifecycleFuture-of-proposals---1-1-1-1

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

@xpivarc @vladikr would appreciate your thoughts on this if you have time as I'd like to start creating issues for the existing FGs sooner rather than later.

Thanks!
BTW, this is partially resolving kubevirt/community#286 . We still need to add a recommended section in the proposal template.

@EdDev  I did post https://github.com/kubevirt/community/pull/343 for that but closed it assuming folks wanted to focus on the new enhancements template instead. I can reopen it if you still think it would be useful in the short term.

@EdDev I did post kubevirt/community#343 for that but closed it assuming folks wanted to focus on the new enhancements template instead. I can reopen it if you still think it would be useful in the short term.

Ohhm I missed that one.
I think it will be useful to have it there because then at design time, both the author and reviewers need to think about it. I mean, questions like:

Does this feature requires release stages or can it be GA directly?
If stages are planned, is there a known plan per versions?

If you re-open it, I will ack.

Thanks a lot @lyarwood! Very cool!
Here are some more fields that exist in Kubernetes' tracking issue (here's an example: kubernetes/enhancements#2400) that we can consider to adopt:
One-line enhancement description: Primary contact (assignee): Responsible SIGs: Design proposal link: Important PRs (optional):
I think these would be valuable. WDYT?

@iholder101  I've added a few of these to the latest revision but to be clear I'm not attempting to codify the new enhancements approach with this tracker. Instead this is a stop gap to hopefully let us clean up the existing FGs in v1.5.0 while the new enhancements approach is discussed and agreed on.
IMHO a new issue tracker template will likely be created for that process in v1.6.0.

@EdDev I did post kubevirt/community#343 for that but closed it assuming folks wanted to focus on the new enhancements template instead. I can reopen it if you still think it would be useful in the short term.

Ohhm I missed that one. I think it will be useful to have it there because then at design time, both the author and reviewers need to think about it. I mean, questions like:

Does this feature requires release stages or can it be GA directly?
If stages are planned, is there a known plan per versions?

If you re-open it, I will ack.

@EdDev ACK, I'll reopen and update that now thanks.

@xpivarc @vladikr @iholder101 any more thoughts on landing this so we can at least move some of the existing FGs forward in v1.5.0 ahead of a potentially new process for tracking stuff in v1.6.0?

@iholder101 I've added a few of these to the latest revision but to be clear I'm not attempting to codify the new enhancements approach with this tracker. Instead this is a stop gap to hopefully let us clean up the existing FGs in v1.5.0 while the new enhancements approach is discussed and agreed on.
IMHO a new issue tracker template will likely be created for that process in v1.6.0.

I think that once the new proposal approach will be merged, its new feature tracker will serve as a replacement for the tracker proposed here. Since the discussion is already ongoing [1], I'm not sure we should invest in this just to replace it with the enhancement tracker in the very near future TBH.
There's always the alternative of simply documenting the feature gates in-code:
https://github.com/kubevirt/kubevirt/blob/e2e64962d9db7dc3724f751eb6c897215b5842a2/pkg/virt-config/deprecation/feature-gates.go#L50-L56
Is there a reason you think this is necessary albeit what's written above? Am I missing something here?
[1] https://github.com/kubevirt/community/pull/362

@lyarwood Thank you very much!
It looks good to me. Seems like this template mimics the Kubernetes one.
My only reservation is that from my perspective this template needs to live in the (not yet existing) kubevirt/enhancements project and not in kubevirt/kubevirt.

I suggest to hold this effort, wait until #362 merges, and use what's suggested here as a VEP template.
WDYT?

/hold


Fixed whitespaces to display correctly @ docs.microsoft.com

Hi @FabianGosebrink, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

:warning: Validation status: warnings

File
Status
Preview URL
Details

entity-framework/core/get-started/netcore/new-db-sqlite.md
:warning:Warning

Details

entity-framework/core/get-started/netcore/new-db-sqlite.md

Line Unspecified: [Warning] internal error: the updated_at is missing

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Hey @bradygaster ,
thanks for looking into this. How can I fix the issue?
Thanks
Fabian

I think that warning is unrelated to this change, I have seen it pop up from time to time - usually when something else fails. I can take a look at this and merge it.

@FabianGosebrink can you make this PR against master branch, rather than live, and I will merge it.

@rowanmiller just switches to master branch. If I can do anything else please let me know.
Thank you
Fabian

Thanks for the contribution!


Allow for mapping error codes to classification for flake8

In #815 it was suggested to change the F category for flake8 from "error" to "warning". The problem is that flake8 doesn't carefully separate out what F and E error codes represent in terms of "definite errors at runtime" from "you might want to fix this", e.g. E111 complains that the number of spaces in indentation is a multiple of 4 while E999 means a syntax error (F is no better).
That suggests that instead of classifying only at that E, F, and W, what really should be supported is a mapping of error codes to classification. The keys could be E or E999 for flexibility. Underlying this could be a trie for fast look-ups while allowing users to be as specific as they choose with their classifications. It also automatically provides precedence for tighter specifications.

Decided it would be better to convince flake8 to have more stringent classification.


libsdl2-dev not available in Ubuntu 18.04

How to fix the missing dependencies? Or how to use the latest libsdl2-2.0-0 which comes with default bionic repositories?
apt-get install -f  didn't solve, several StackOverflow suggestions failed as well.
sudo apt-get install libsdl2-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libsdl2-dev : Depends: libasound2-dev but it is not going to be installed
               Depends: libegl1-mesa-dev but it is not going to be installed
               Depends: libgl1-mesa-dev but it is not going to be installed
               Depends: libgles2-mesa-dev but it is not going to be installed
               Depends: libglu1-mesa-dev but it is not going to be installed
               Depends: libpulse-dev but it is not going to be installed
               Depends: libsdl2-2.0-0 (= 2.0.8+dfsg1-1ubuntu1) but 2.0.8+dfsg1-1ubuntu<IP_ADDRESS> is to be installed
               Depends: libudev-dev but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

I've fixed using aptitude instead of apt
https://askubuntu.com/a/451078/309816
I had to downgrade several dependencies, maybe updating the package to depend on libsdl2-2.0-0 will fix the issue. Thanks

Thank you so much!!!!!!


Pond - outline an assemblyQC annotation workflow (including concepts and tools)

Please provide an outline (slides/bullet points/ whatever is appropriate) of important annotation concepts, tools, and workflows. Please present to the team, and can be incorporated into the June FDA meeting.
Previous notes from Stephen:
We have utilized a tool called SnpEff to annotate variants as frameshifts, deletions, and others for SARS-CoV-2. I am going to look into the possibility of annotating stop codons... if it does not work out of the box, it should be a minor effort to extend.
Though SnpEff is meant for VCFs, with a slight hack minimap2 can map an entire genome FASTA to a reference FASTA and give a BAM, then ivar variants can be used to produce a VCF that shows where the genomes differ.
I have a proof of concept of this for Sudanese Ebola, but it needs to be further cleaned up as the SARS-CoV-2 example. It actually required https://github.com/pcingola/SnpEff/issues/388.
I plan to utilize this and reintegrate with previous reassembly and assemblyQC work this month.

Meeting on 6/5 with Stephen and Jingyue:

[ ] @stephenshank will prepare slide(s) per annotation concepts/workflows he is building in Galaxy and show on Wednesday 6/7 to team

Closed. At end of paper, see if we need it.


do we need a deploy list command

the chat-bot has deploy and destroy commands
a "deploy list" would be helpful in:

getting url of old deployed (and dates)
checking old deploys and destroying them if not needed

This has been planned for dockup : https://github.com/code-mancers/dockup/issues/13


duphold use with gVCF files

Hello @brentp,
Thanks for this awesome tool!
It would be great, if duphold could be used  to compute (B Allele freq /DHGT field) from gVCF files(where non-variant sites are represented as blocks to save space) directly, rather than be limited to regular VCF files.
Thanks and let us know if you have plans to implement such a feature.

Hi @brentp, just following up on this. Do you think it will be possible to implement such a feature in the near future?

you mean to still send a CRAM/BAM, but to evaluate every site in a GVCF?
I suppose that's possible, but duphold is for larger events and most gvcfs don't contain large SVs, do they?

Hi @brentp , CRAM/BAM file is used for coverage-based QC (DHFC, DHBFC, DHFFC) while bcf(multisample/ single -sample) file is used for snp/indel annotation  i.e. compute DHGT. Therefore, In the context of snp/indel annotation, I would suggest, duphold has a feature to use gVCF file i.e a file of the following format ---

where 1 14605-14609, 1-14611-14652 is represented as a single block (saves disk space) of non-variant sites. This is followed by variant only site 1-14653.  Presently, 1) If I use these non-variant sites information for DHGTing a SV overlapping here, then I have to convert these gvcf files to a regular vcf files(which takes up lot of space). Secondly, 2) just using a variant-sites only vcf file(single /multisample) may not be sufficient estimator of Quality of a SV deletion---i.e. reject a SV del if we find N number of het calls within it. 3) If we use a stretch of non-variant sites from a gvcf file to accurately compute no. of Homozygous ref, then that would complete snp/indel based filtering of SV Dels.
Ofcourse, we can infer the number of non-variant sites from a regular variant sites only whole genome vcf file overlapping with a DEL SV of interest, but in our pipeline we generate these gVCF files and if would help us to use duphold directly with them.
Please let me know what you think?

Since DHGT is not the primary feature of duphold (primary is depth annotation of SVs), I'm less inclined to work on this.
It's also not clear to me what genotype information would be in non-variant blocks. If there's a variant, it will appear in a final, jointly-called VCF.
I guess with the GVCF, you can have a block where there is no variant in any sample in the population (including the current sample of interest) and you get extra info that way because you know there is a block of hom-ref with decent coverage. Is that the benefit you see?
All that said, I would look into this if you have evidence that DHGT is valuable. I always found that depth was more reliable than DHGT.


Use git submodule for blst

seems that in order to be able to pull in updates it should be switchted to be a git submodule, or am I missing sth?

I miss a lot of context. I wonder why this module copies so much and is not just depending on https://github.com/supranational/blst directly. The bindings could depend on their corresponding bindings.

I've more context now. I think having blst as a Git submodule makes sense, deeper changes not.


Better documentation for Contributing

@StrikerRUS @jameslamb @Laurae2
I think we should have a page for contributors too.
like https://github.com/dmlc/xgboost/blob/master/CONTRIBUTORS.md
BTW, I plan to create a Roadma to make the development more smoothly.

Thanks @StrikerRUS , we may need another re-organization round for feature request page: https://github.com/microsoft/LightGBM/issues/2302
And could you help to create a Contributors page?

@guolinke

And could you help to create a Contributors page?

To be honest, I don't see any point of creating list of all contributors. GitHub already tracks all contributors for us: https://github.com/microsoft/LightGBM/graphs/contributors. For "Project Management Committee(PMC)" we already have a list of core team members in our FAQ: https://github.com/microsoft/LightGBM/blob/master/docs/FAQ.rst#critical-issues.

Okay, I forgot that we have that page.

I agree with @StrikerRUS that we don't need to explicitly list out all contributors, since we get that from GitHub already.
I am excited  for the Roadmap idea, makes sense.


Build my profile section

In this feature branch, the following implementations were added:

built the My Profile section, displaying all the missions and rockets booked;

Congratulations 👏
Go ahead and merge.


Popup.close crashes browser

To reproduce:

Enable popup blocking in chrome
load your application (expect authentication error)
refresh page (expect application crash)

Crash occurs with warning browser warning Scripts may close only the windows that were opened by it. caused by https://github.com/Vestorly/torii/blob/f47b231594445a26b6247fd1eb0c1a14cc20a4bd/lib/torii/redirect-handler.js#L29.
I'm not sure if the browser warning can be captured, so there might not be a good solution here.

Closely related to #249

Any chances to have some update on in ?

anyone ?


virtcontainers: Replace glog by logrus logger

Glog causes some data race with project using our library and glog at the same time. For that reason, it is safer to move to logrus logger, which is more flexible and which does not cause such issues.

Coverage decreased (-0.03%) to 66.33% when pulling<PHONE_NUMBER>f4d3c040c793540cc8e5ae938240db on sboeuf/replace_glog_by_logrus into 970f5166202f14d105d5c6624ce97f77db1960a5 on master.

@sameo @dlespiau please take a look because we need this to avoid go test -race to fail in the proxy.

LGTM, except for the qemu logger renaming.

Coverage increased (+0.3%) to 66.709% when pulling 208bb0d95de19ab67ea19e0d584ab71ff73b4800 on sboeuf/replace_glog_by_logrus into a99a7cfbc99336942710a7c643402ff85f691006 on master.

side notes:

we should promote more structured logging in virtcontainers instead of just free form messages
it may be interesting to delegate the actual logging to the user of the virtcontainers library. Something like gokit's logging interface would help a log there.


Add projected token to hypershift-operator for Role based access

Currently, the aws-private-creds passed to hypershift-operator must be IAM user creds because there is no token projected into the hypershift-operator pod.
This PR adds that token.
This isn't the best from UX because the aws-private-creds will need to specify the web_identity_token_file to be the bespoke path of the projected token at /var/run/secrets/openshift/serviceaccount/token.  But it does allow for Role-based creds for AWS private cluster functions i.e. creating the Endpoint Services.

/lgtm


Update circe-generic, circe-literal, ... to 0.14.2

Updates

io.circe:circe-generic
io.circe:circe-literal
io.circe:circe-parser

from 0.14.1 to 0.14.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "io.circe" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #654.

Superseded by #686.


Add DiCom Connectors

we need to figure out the best mode DICOM and PAC connectors for image processing.
https://github.com/pixmeo/osirix
https://medevel.com/10-open-source-pacs-dicom/

@tedtanne connect with BH re: WHI DICOM toolkit:
https://www.ibm.com/products/merge-dicom-toolkit

You've also got an HL7 toolkit - https://www.ibm.com/products/merge-hl7-toolkit

@tedtanne if this work is covered by the Orthanc DICOM PACS server we've discussed, I'm going to make this an epic and add 2 issues to it.

yea move it and close it.


FR: Mem-style note aware prompts

Would it be possible to do a mem-style feature by utilizing search first within the graph then sending the relevant results as part of the prompt to gpt3?
This might even be more useful or effective than fine tuning since fine tuning doesn't teach facts well.

Could this be helpful?
https://openai.com/blog/new-and-improved-embedding-model/

This is a really good idea. I've been thinking about something where you can provide a logseq query or search that would inject the text from the results/pages into the prompt

Also https://github.com/openai/openai-cookbook/blob/main/examples/Question_answering_using_embeddings.ipynb


Fix double speed when cursor is on edges.

If cursor is on top (H) or bottom (L). The speed for <c-d> and <c-u> are
doubled because of bad counting for lines behind and lines before.

Thank you for reporting this. The counting of lines behind was correct. It was the fact that I moved the cursor before the screen (and not the other way around) that caused this. I just pushed a fix.


How to implement multi tap and hold

For example, you can configure the Caps Lock key to act as an Escape button when pressed once and released, a Ctrl modifier when held-down, and a button to jump to a layer when pressed twice quickly in succession.
Can you give examples for this? I am looking for a similar behavior but unable to get it working with multi tap and taphold next release.

On Wed, Oct 28 2020 19:10, prabhu-madanagopal wrote:

For example, you can configure the Caps Lock key to act as an Escape
button when pressed once and released,

This can, for example, be achieved by:
(defalias
  ecn (tap-next esc lctl))

(defalias
  ecn (tap-hold 200 esc lctl))

a Ctrl modifier when held-down, and a button to jump to a layer when
pressed twice quickly in succession.

If I understood you correctly, this behaviour is achievable with the
following:
(defalias
  mt (multi-tap 200 lctl (layer-switch my-layer)))

@slotThe My understanding is we can combine the 2 into 1 button.
Multi-Use and Multi-Tap Buttons
One of the distinguishing features of KMonad is the vast capabilities with Multi-Use Buttons. You can use have a single button do different things based on whether it is pressed quickly in succession, or pressed once, or held. For example, you can configure the Caps Lock key to act as an Escape button when pressed once and released, a Ctrl modifier when held-down, and a button to jump to a layer when pressed twice quickly in succession. You can make the left and right Shift keys to act like left and right parentheses (like the Space Cadet Shift keys) when tapped once, and regular Shift keys when held down. The possibilities are infinite!

Also described in this issue:
https://github.com/david-janssen/kmonad/issues/114
But when I try with this(ses), the single tap also emits lsft, instead of esc.
  sym (layer-switch symbols)
  sec (tap-hold-next-release 150 esc lsft)
  ses (multi-tap 300 @sec @sym)

On Thu, Oct 29 2020 09:30, prabhu-madanagopal wrote:

@slotThe My understanding is we can combine the 2 into 1 button.

Aaaah, now I understand what you mean.

But when I try with this(ses), the single tap also emits lsft, instead of esc.
  sym (layer-switch symbols)
  sec (tap-hold-next-release 150 esc lsft)
  ses (multi-tap 300 @sec @sym)

As far as I can tell, the problem here is that you actually only have a
very small window to (you have to hold down the key for 300ms to
activate the @sec macro and then you have to release it within 150ms).
The following works semi okay:
(defalias
  sym (layer-switch symbols)
  sec (tap-next esc lsft)
  mt  (multi-tap 100 @sec @sym))

This way delay 1 is only 100ms and there's no delay at all for the
esc-lsft stuff.

Thx @slotThe it works, but it is not usable. The problem is one still needs to release the first tap after the first timeout for the first tap to work and double tap within the first timeout for second tap to work. That doesnt work.
It looks like a variant of multi-tap that presses the button the same way for both timeout and release within timeout is needed to get this case working. Not sure if there is any other function that can emulate the press or pause that can be used. @david-janssen any magic?

or a tap-hold that emits tap on timeout?

@prabhu-madanagopal did you manage to get this working? If I understand you correctly I have the same use case where I would like to:

single-tap s                   - > s
double-tap s                 - > S
tap-hold-next-release - > shift

Also interested. @prabhu-madanagopal Did you manage to make this work?
cc @AckslD

I have switched back to qmk using custom functions till kmonad adds this improvement.

The same here, I would like to have such behavior:
- single-tap n => n
- double-tap n => ń
- hold n       => ctrl

See my comment on https://github.com/kmonad/kmonad/issues/203 for some ideas on how to get this working.


Fix i18n issue with Sort Icons

Sort icons for alphabetic and numeric are using A-Z and 1-9. This doesn't translate so we need to add an alternative for non english languages.

I've created https://github.com/patternfly/patternfly-design/issues/337 to come up with a solution to this problem.


BlockState command element

Since BlockStates are given ids (e.g. minecraft:dirt[snowy=false,variant=grassless]) by Sponge, it would be nice to have a BlockState-specific CommandElement.
The command element could also support tab-completion of the properties of the BlockState. In the example above, a user would be able to tab complete the property names (e.g. snowy) and the property value, if the type has a fixed number of values (boolean or Enum).

Pinging @zml2008 for feedback.

@Aaron1011 This is un-needed as BlockState is a CatalogType and that element already exists.

I think it was more a issue to create one specific to blockstate that had handling for tab completion of traits.

Yes, @ryantheleach is correct.

Just a bit of feedback. tab-completing traits is going to be a PITA if you really want to do it. MC client replaces everything connected to the current string, which means your tab completion is going to look really ugly really fast.

Even if tab completion won't work out, it would be nice to have something which at least parses a string like minecraft:dirt[snowy=false,variant=grassless]

I will agree with that.
It would also be really nice to be able to look at a block, and have tab completion insert that block state.

This is un-needed as BlockState is a CatalogType and that element already exists.

There was talk in a different issue that BlockState's Shouldn't be a CatalogType? Just because of the sheer number of them?

Pretty sure the fuzzy matching to auto completion on block state properties is the end goal, but seeing as 1.13’s auto completion already handles this, it will be exposed.
@ryantheleach they shouldn’t be cataloged as fields, because there’s over 7 Thousand last I counted. But BlockState will always be a first class citizen of CatalogType.

Yeah that makes sense and removes my confusion, thanks.

Fixed by https://github.com/SpongePowered/SpongeAPI/commit/e086c46c6cddbbcd7f0444a7718caaf9b8f82eb3


Support KerasModel just on Keras backend

Type of Change
bug fix
API not changed
Description
ILITV-2398: During studying this issue, I found current design would convert SavedModel to KerasModel on Tensorflow backend, it will cause the quantization fail. We should support KerasModel just on Keras backend.
Expected Behavior & Potential Risk
TFHub saved model can be quantized successfully on stock tensorflow.
How has this PR been tested?
Pre-CI and TFHub saved model test.
Dependency Change?
None.

extension test pass, but accuracy still not normal, please check may need to fix in another PR.


Refresh file without reloading the whole window

VSCode has 'Reload window' command which does more than just refreshing a single file.
I would like to have 'Refresh file' command which just reloads current file.

I don’t talk Abo extensions.
I want a button to read the file once again and show update file without reloading whole window.

Is this button what you need?

@psychelzh that button should do the trick for refreshing the explroer
@NN--- each file should react automatically to file events and you should not manually refersh it. If that is not the case please file a new issue with reproducable steps on how you got into that state

The file is not updated automatically for me.
I’ll create a new issue.
Ok


Could not start new session. Possible causes are invalid address of the remote server or browser start-up failure.

Microsoft edge documentey Provided edge in ie mode code but not working so have get another selenium code but facing issues.it works fine untill RDP session active but once session inactive get above mentioned error .
Below code is used ,
System.setProperty("webdriver.ie.driver", "IE Driver Path"); InternetExplorerOptions ieOptions = new InternetExplorerOptions();
ieOptions.attachToEdgeChrome ();
ieOptions.ignore ZoomSettings ();
ieOptions.withEdgeExecutable Path ("C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe");
driver = new InternetExplorerDriver (ieOptions);
driver.manage().deleteAllCookies();
driver.manage () .window () .maximize();
driver.get("https://www.finacle.com");
If any alternative solutions to resolve this problem please share .

This is a known issue: #15
As a workaround, you will need to ensure the RDP session remains active while running IE Mode tests.


Feature/maps

Base branch to be changed after the commit

@furkanarabaci Hey ✋🏻,
I removed the global.lang things. Could you check it again?


🍊 Jupyter Notebook + 🕸 Replicate

Thanks for the project ❤ I made a jupyter notebook and replicate demo 🥳 I hope you like it.
https://github.com/camenduru/InstantMesh-jupyter
https://replicate.com/camenduru/instantmesh

@camenduru Wow, we are so grateful for your contribution! We will add it into our README file.


Have not managed to make the API work

Dear Yoav,
I followed all instructions to install the API on a Mac running OSX 10.11.4
All components (boottlenose, lxml, dateutil and the API itself were properly installed.
Yet, when attempting to follow one example I get the following response:

I am certain the access, secret and associate keys are correct.
My reading of the error messages is that the arguments are not flowing correctly across the code. But have not been able to figure out a solution.

I had the same problem. After a bit of looking around, I found that I didn't sign up for Advertising API access. Fixed once signed up


typo: Double word "the"

@nschonni : Thanks for your contribution! The author, @anosov1960, has been notified to review your proposed change.


New posts

See https://trello.com/c/aTdBNblP/18-news-migration under Petr checklist.

I've removed all the 'Dear All' and 'Regards' bits so they don't read like emails any more and the old community page links can be updated as internal page links to ({{ site.baseurl }}/support/)

@hflynn

I've removed all the 'Dear All' and 'Regards' bits

This means I do not have to do this in this PR because it was done by you somwhere else ?
Or not ?

@pwalczysko removed from the ones that have been merged
so you will need to do it on your PR

https://www.openmicroscopy.org/site/support/bio-formats5.1/about/whats-new.html is an old community page link ? And should be replaced by [OME Forums or mailing lists]({{ site.baseurl }}/support/bio-formats5.1/about/whats-new//) ??

I'm going to have to grep and sort out the old website links anyway so I'll just merge this as is, thanks @pwalczysko


Update README.md to include repology status

Closes #680

CI fails are surprising considering it is only a readme change (?)


Revert "build(deps): bump github.com/consensys/gnark"

This reverts commit 874ed1ac2e38da24c1a4b1559ff8050ca8e2bc6f. We can't allow this gnark update since minimum required Go version for NeoGo and all examples is 1.20. It will be done as a part of #3089.

Goland constantly modifies the example's go.mod, it's irritating, and the current version doesn't work for Go 1.20, thus reverting.


Error Code 3: API Usage Error

[E] 3: [executionContext.cpp::nvinfer1::rt::ExecutionContext::validateInputBindings::2045] Error Code 3: API Usage Error (Parameter check failed at: runtime/api/executionContext.cpp::nvinfer1::rt::ExecutionContext::validateInputBindings::2045, condition: profileMaxDims.d[i] >= dimensions.d[i]. Supplied binding dimension [1,231,768] for bindings[2] exceed min ~ max range at index 1, maximum dimension in profile is 154, minimum dimension in profile is 77, but supplied dimension is 231.
i get that error for every step of an image being generated
the image generation itself is fine.

Doubling that request, getting exactly same error.
Here are my TRT profiles, they are built specifically for the resolutions I use.
Profile 0
| Min | Opt | Max
-- | -- | -- | --
Height | 512 | 512 | 768
Width | 512 | 512 | 768
Batch Size | 1 | 1 | 4
Text-length | 75 | 75 | 150
Profile 1
| Min | Opt | Max
-- | -- | -- | --
Height | 768 | 1024 | 1024
Width | 768 | 1024 | 1024
Batch Size | 1 | 1 | 4
Text-length | 75 | 75 | 150

Either the negative or positive prompts that you have are going above the 154 word limit. Lower the amount of words and it should stop popping up.

Either the negative or positive prompts that you have are going above the 154 word limit. Lower the amount of words and it should stop popping up. You could also create a custom engine with a higher text limit.

So as I understand it, this limit is for positive prompt + negative prompt, not for both prompts separately?

im having the same problem, but i have an engine with 400 token. It seems its always choosing Profile 0

I have the same problem - I can't get an image larger than 768 on one side

Same for me. Solved after a change in the negative prompt (shorter...)


Example request / responses - including source tag

Only a minor enhancement however in each request / response adoc file I often put
[source,json]
which ascii doctor uses to recognise the request / response as JSON and format / highlight accordingly
It maybe nice to include this default value in the request / response examples when building to avoid having to include in each file

Thats not possible, since the API could also provide many other Media types

Sorry I should have clarified I meant provide this default through a configurable value eg example.initialmarkup

Won't implement


Replace assert with log.error in onlyChecked.

As discussed over the weekend and in yesterday's call, components that process the CPG shall be a bit more liberal about slight deviations from the spec, and when possible, return results even for slightly broken CPGs, ensuring that these results are in themselves consistent so as to not cause crashes further downstream.
This PR: replacing assert with log.error in onlyChecked for two reasons:

if assertions do survive compilation, then they lead to a hard stop, which is not desired
whether or not assertions show up depend on the compiler settings, and I'm worried we won't even see them during development.

Overall, I'd propose to stay away from assertions and use the logger instead. In particular, utility methods such as onlyChecked should not decide to terminate the program.

Afaiu assertion failure is just an ordinary exception, just like the NoSuchElement-style exceptions we throw otherwise. This is not a panic and should not pull down the process. But it is an error condition: From this moment, we know that all analyses depending on this onlyChecked() are incorrect -- i.e. everything in the surrounding try-catch block.
I'm fine with the change, but I think we're better off relying on the already existing try-catch-log around major operations (e.g. loader passes, dataflow queries) than shot-gun logging. A comparison could be made to the NoSuchElement exception: We sure could return an element and log the condition instead, but that would be sully.

I do not see any exception handling for this in callers. Just like the NoSuchElement exception, this is unhandled, and it effectively means that when this assertion is triggered, somebody needs to get up in the middle of the night - just because the input CPG had one edge too many. I would prefer if we report this invalid CPG via our logging infrastructure and look into it the next day. That's what this change does.


External deployment is not enabled

Upload and deploy extension from menu on BC sandbox message : External deployment is not enabled. Please contact you system administrator.
How to enable external deployment ?

External deployment is by design not allowed a Sandbox tenant in BC by design.
Deployment of extensions on a sandbox is meant to be done via VS Code to allow you to test out/develop your extension in a BC-like environment.
The external deployment feature is not meant to be used as a method of 'trying out' your extension, but rather as a means of deploying a 'final' product to a live tenant. Once you have finished with the development cycle for your extension, you will need to log into the live production tenant and upload your package from there.
Note: the upload process runs the same 'validation' as can be run from the compiler locally by setting up the PerTenantExtensionCop AL Code Analyzer.
E.g. adding the following to your settings:
"al.codeAnalyzers": [
        "${PerTenantExtensionCop}"
    ]

I am using object numbers in the 50250 to 50300 series in my app.  I ran into this "External deployment not allowed" error message when I tried to upload the app from within the docker image in my azure account.
When I try to deploy the app from within VS Code by using Ctrl-F5, I get the following error message:
The request for path /nav/dev/apps?SchemaUpdateMode=recreate failed with code 422. Reason: Your program license does not allow you to publish 'PBSI TT Activation Code Info'.
The same thing happens if I don't specify a "SchemaUpdateMode" (meaning I go with the default of "synchronize".
O.K., so I can't upload the extension from within the docker NAV, and I can't use the upload process from within VS Code.  Between "External deployment is not enabled" and "Your program license does not allow" it seems like you folks at Microsoft have created a real mess.
I sincerely hope I'm missing something here, but I'm basically stuck.  Any ideas?

You can deploy code in the range you mentioned in multiple ways:

Online Sandbox by using Ctrl + F5 from VS Code
Docker sandbox by uploading your partner license and then using Ctrl + F5 from VS Code
Online Production tenant by using Upload functionality on Extension Mgmt page

What is the future / planed behavior for the PROD On-Prem Installation?
How can we enable the "External Deplyment"?

I use docker sandbox-master with our partner License.

For On-Prem things will work as they used to. You should use the Publish-NavApp powershell cmdlet.

Publish-NavApp powershell is useful only if you want install own app. if you want to install other app, D365 login is mandate.


Update to introduction on website

[!NOTE]
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description
Provide a summary of the changes made and/or reference the issue being addressed.
Fixes #210
It adds a bit more info for those who did not see the GitHub jet.
Type of change
Please check the relevant option(s):

[x] Bug fix (non-breaking change that resolves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[ ] New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[ ] Testing performed (I have tested my changes, ensuring everything works as expected)
[ ] Documentation updated (I have updated any relevant documentation)

Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here:

Related PR #

not a fan of this, maybe we can put it somewhere else? the header needs to be something clean and tidy, not this chunk of text that gets thrown in your face as soon as you enter

Basically, I don't care. The other @community-scripts/contributor are welcome to say something about it.

In my defence; If you visit the site now, and don't know the project at all, it's not clear what we offer.
Also not after going to the scripts.

It's adding just two sensises in 3 lines. (done this way so everything should be about the same width), and let a new commer know, what they are about to see.
I do agree to keep it clean, but this page does nothing right now, it just adds a anoying click here to get to the real stuff step.
Hands I use a /scripts bookmark.

Can we see how the new landing page would look? I must admit I have also thought the extra button click is annoying compared to tteck's original page where you get directly to the scripts.

The idea for this homepage was to, in the future, add more information about what this project is and how to use it. It would also explain the steps the scripts take to complete an installation, since people have mentioned that it just looks like scripts are being piped into the terminal without explaining what each one does. I just haven’t had the time. Maybe that’s something @havardthom could work on. or i could but it would take a little longer

That sounds good, and there are higher priorities now I think, so meanwhile this is better than nothing, and it allows you plenty of time to enhance it at your own pace.

merging for now, will revert back to the old homepage in the future when better homepage has been made.


error using Genie julia (1.0.0)

when i type using Genie shows error here is error trace : -
WARNING: could not import Base.reload into Util
ERROR: LoadError: LoadError: MethodError: no method matching parse(::String)
Closest candidates are:
parse(::Type{LibGit2.GitCredential}, ::AbstractString) at /home/mksmmi/julia/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:71
parse(::Type{LibGit2.GitCredentialHelper}, ::AbstractString) at /home/mksmmi/julia/usr/share/julia/stdlib/v1.0/LibGit2/src/gitcredential.jl:158
parse(::Type{Sockets.IPv4}, ::AbstractString) at /home/mksmmi/julia/usr/share/julia/stdlib/v1.0/Sockets/src/IPAddr.jl:166
...
Stacktrace:
[1] top-level scope at none:0
[2] include at ./boot.jl:317 [inlined]
[3] include_relative(::Module, ::String) at ./loading.jl:1038
[4] include at ./sysimg.jl:29 [inlined]
[5] include(::String) at /home/mksmmi/.julia/dev/Genie/src/Genie.jl:4
[6] top-level scope at none:0
[7] include at ./boot.jl:317 [inlined]
[8] include_relative(::Module, ::String) at ./loading.jl:1038
[9] include(::Module, ::String) at ./sysimg.jl:29
[10] top-level scope at none:2
[11] eval at ./boot.jl:319 [inlined]
[12] eval(::Expr) at ./client.jl:389
[13] top-level scope at ./none:3
in expression starting at /home/mksmmi/.julia/dev/Genie/src/Sessions.jl:16
in expression starting at /home/mksmmi/.julia/dev/Genie/src/Genie.jl:32
ERROR: Failed to precompile Genie [c43c736e-a2d1-11e8-161f-af95117fbd1e] to /home/mksmmi/.julia/compiled/v1.0/Genie/8eazC.ji.
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] macro expansion at ./logging.jl:313 [inlined]
[3] compilecache(::Base.PkgId, ::String) at ./loading.jl:1184
[4] _require(::Base.PkgId) at ./logging.jl:311
[5] require(::Base.PkgId) at ./loading.jl:852
[6] macro expansion at ./logging.jl:311 [inlined]
[7] require(::Module, ::Symbol) at ./loading.jl:834

Thanks - update and try now.
However, it's probably too early to run on v1.0 -- might be safer to stay on 0.7 until all the dependencies are updated.


Support running Hologram on servers

We've got developer workstations covered but what about servers not running in EC2?

Is there anything preventing this? It seems like I should just be able to run the agent on any machine, if it's configured appropriately.

That's a good point, I don't really think there's anything preventing this. We even build debian packages for the agent already.
I'm going to leave this issue open for a bit to do some testing and ensure there aren't any gotchas around.

What we don't really have is support for running a hologram server in a non-EC2 host, but that's a fairly trivial change (just allow AWS keys to be passed through config/env). I'm not sure how much of an edge case this is, but it would at least help us with our testing.


AttributeError: 'module' object has no attribute 'rnn_cell' with tf0.12

mldl@mldlUB1604:/media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow$ sudo python dmn_train.py -b 2
2017-02-02 23:52:48: I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcublas.so.8.0 locally
2017-02-02 23:52:48: I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcudnn.so.5 locally
2017-02-02 23:52:48: I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcufft.so.8.0 locally
2017-02-02 23:52:48: I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcuda.so.1 locally
2017-02-02 23:52:48: I tensorflow/stream_executor/dso_loader.cc:125] successfully opened CUDA library libcurand.so.8.0 locally
Training DMN plus on babi task 2
==> Loading test from /media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow/data/en-10k/qa2_two-supporting-facts_train.txt
==> Loading test from /media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow/data/en-10k/qa2_two-supporting-facts_test.txt
==> get train inputs
==> get test inputs
Traceback (most recent call last):
File "dmn_train.py", line 48, in
model = DMN_PLUS(config)
File "/media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow/dmn_plus.py", line 399, in init
self.add_reused_variables()
File "/media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow/dmn_plus.py", line 125, in add_reused_variables
gru_cell = tf.nn.rnn_cell.GRUCell(self.config.hidden_size)
AttributeError: 'module' object has no attribute 'rnn_cell'
mldl@mldlUB1604:/media/mldl/data1t/os_prj/Dynamic-Memory-Networks-in-TensorFlow$

It seems that the stable release (0.12.1) and the current head (0.12.head) use a different interface to the rnn_cell module.
Temporarily, replacing "tf.nn.rnn_cell" with "tf.contrib.rnn_cell" should fix the problem in 0.12.head but I'll probably wait until 1.0 becomes stable to update the repo's syntax.


Move atomic output to debug

Do not show atomic logs in stdout/stderr, but save it to the debug log.

@jpopelka Thanks for the review, can you approve it once again, please?


Xnero: Watch vyomoverseas.com

Xnero requests the watch of the watch_keyword vyomoverseas\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vyomoverseas\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


cleanup/metrics: Remove deprecated metrics in 1.9

This commit is to clean up all deprecated metrics and labels in 1.9.
Signed-off-by: Tam Mach<EMAIL_ADDRESS>TODO:

[x] Update docs (release note)

cleanup/metrics: Cleanup deprecated metrics

test-me-please

test-me-please

test failed due to docker limit, I will re-run later (maybe morning my time)
21:58:58   > [builder 1/4] FROM docker.io/library/golang:1.15.4:
21:58:58  ------
21:58:58  failed to solve with frontend dockerfile.v0: failed to solve with frontend gateway.v0: rpc error: code = Unknown desc = failed to build LLB: failed to load cache key: failed to copy: httpReaderSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/golang/manifests/sha256:ef9a25dc0bf0a4b5e28c27cf0e8f0cd2d29fb12b4cc9cc5089471328dd0d808c: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
21:58:58  Makefile.docker:98: recipe for target 'docker-plugin-image' failed
21:58:58  make: *** [docker-plugin-image] Error 1

test-me-please

retest-4.9

test-me-please

retest-runtime

Nice. Should we also update grafana dashboards, or have they already been updated to not use deprecated metrics?

Yes, it's already done as part of https://github.com/cilium/cilium/pull/12826, so grafana dashboards in 1.9 stopped using deprecated metrics/label.

Great! Since 1.9 is now released, shouldn't this target 1.10 instead? I see multiple 1.10 references in removed TODOs

Not sure if I understand correctly. As 1.9 is released, master branch will be for 1.10 only, this change will not be backported to earlier version. Feel free to let me know otherwise.

Great! Since 1.9 is now released, shouldn't this target 1.10 instead? I see multiple 1.10 references in removed TODOs eyes

I think you might be confused by the PR title slightly. It should read Remove deprecated metrics _from_ 1.9.
Merging.

It should read Remove deprecated metrics _from_ 1.9.

Gotcha, thanks!


Enhance CSS Quality

Review the HTML code. No element should have a style attribute and use direct styling. Styling has to be centralized and uniform using CSS files. There should likely never be any single element styling by necessary.

Closing based on full bootstrap restyle


Not able to use JDK 11 in Scala Play Framework App

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I want to use JDK 11 in my Scala Play App.
I am using the last version of Play Framework with JDK 11 (Play Framework 2.8.16 is not compatible with Java 19).
I tried a lot of things:

Puting env variables tell raiway and Nixpacks to use jdk 11

The build log says the following:

#8 84.95 error: collision between /nix/store/sr0ncsr0f1ph3p7hn8y5gypqwrf33r8i-openjdk-11.0.15+10/include/jni.h' and /nix/store/lnqmv17pbjpyldjnk07kr0k1ngfx5gw4-openjdk-19.0.1+10/include/jni.h'
I see that the scala provider ( https://github.com/railwayapp/nixpacks/blob/main/src/providers/scala.rs#L79 ) is different that the Java one in how It uses JDK variables but I do not know If this is a problem or not.

To reproduce
Just use the env variable NIXPACKS_PKGS with value jdk11 in railway.
The build will fail.
Expected behavior
Build and Run Scala project with jdk11
Environment
I am building with railway.app

Pinging @yzia2000 - any guidance on what we can do to add this to the provider?

Yeah we could certainly do something about this. Let me send a PR

Basically, we can make sure that the sbt package is compiled with the right jdk version


underline links

we need to underline “normal” (currently red) links

moved to https://github.com/NYPL/design-toolkit/issues/10


[HUDI-7754] Remove AvroWriteSupport and ParquetReaderIterator from hudi-common

Change Logs
These classes need to be removed from hudi common because they have hadoop deps.
Impact
remove hadoop from hudi-common
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI passing


[WIP] Cuckoo Cycle PoW as separate OS process, and configurable

@akorosmezey @velzevur For our early review.
The idea is to split sequential smaller PRs from this branch, rebased on current master from time to time:

The first such PR ~is~ was #338 (now merged);
The second such PR is #346;
The third PR shall contain the rest - with any updates from @akorosmezey if any.

This branch aims at finishing the following PT stories:

PT-152518745 - miner as separate OS process
PT-152519020 - miner death handling
PT-152519057 - configurable 16 vs. 30
PT-152519288 - configurable mean vs. lean

Known issues:

CI job of release of testing script on OSX (newly introduced job, under review) fails as no block gets mined (see sample log from old build). Issue may be in the fragile sed command execution at the beginning of the script. It passes (extremely quickly) on Ubuntu (see sample log from old build).

I pushed branch rebased on recent master as https://github.com/aeternity/epoch/tree/PT-152518745-cuckoo-pow-in-separate-os-process-2

I am preparing PR rebased on master.


New version: MLJ v0.5.3

Registering package: MLJ
Repository: https://github.com/alan-turing-institute/MLJ.jl
Created by: @tlienart
Version: v0.5.3
Commit: f251001a915731f28799567e054007d61e077d8c
Reviewed by: @tlienart
Reference: https://github.com/alan-turing-institute/MLJ.jl/commit/f251001a915731f28799567e054007d61e077d8c#commitcomment-35932572

[noblock]
@tlienart @ablaom For some reason, the GitHub Action job never triggered on this pull request.
I manually re-triggered it, and now your PR will be automerged in the next cron job. Sorry for the delay!
[noblock]


Fix build with Xcode 10.2 beta

Hi, @ChristopherRogers
Thanks for it.
But there is already a branch "swift5.0" as well as a related PR https://github.com/onevcat/Kingfisher/pull/1098 for it. I guess it is ready to be merged and released soon (with some other fixes). Before that, you can try that branch instead to use Kingfisher in Xcode 10.2.

OK, I'll close this then. Thanks.


Errors in Interactive Playground

VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T14:02:52.799Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

python
donjayamanne
0.6.0

Untabify
ilich8086
0.0.2

cpptools
ms-vscode
0.10.5

Steps to Reproduce:
I worked through the Interactive Playground and noticed:

In section 'Multi-Cursor Editing' , Ctrl+Alt+UpArrow or Ctrl+Alt+DownArrow flips the monitor screen vertically, rather than add a new cursor.
In section 'Formatting' it's not clear to me what to try and what to expect in the embedded editor
In section 'Snippets' Intellisense does nothing when I type 'try' in the embedded editor.

@DavidA2014 This appears to be a display driver adding these shortcuts. Can you confirm? (Reported as #20304.)
@seanmcbreen FYI, maybe the format section can be rephrased to be clearer about what steps to take?
@DavidA2014 Does IntelliSense not open at all? Does it open if you hit Ctrl + Space after having typed try?

Keeping this GitHub issue to track issue number 3. (We prefer one GitHub issue per product issue.)

Closing after no additional info was provided.


Logged Out Due To Outdated Client

I Got This Message When Trying To Spawn Player From Console
[13:28:54] [Server thread/CRITICAL]: "Could not pass event 'pocketmine\event\player\PlayerQuitEvent' to 'SanteRia-Core v1.7.2': Call to a member function toString() on null on SimpleAuth\EventListener
[13:28:54] [Server thread/CRITICAL]: Error: "Call to a member function toString() on null" (EXCEPTION) in "/SimpleAuth CODE/src/SimpleAuth/task/ShowMessageTask" at line 46
[13:28:54] [Server thread/INFO]: chaos[/SPECTER:19133] logged out due to Outdated client!
[13:28:54] [Server thread/INFO]: Session started.

This is caused by your Specter version being outdated. Also, try updating SimpleAuth. That might help.

What specter version are you running? The latest build does not support the latest MCPE, you have to use the GitHub source directly.

@Falkirks Off topic, but when I use icu to control a fake person, whenever I chat, it just shows stuff like [{< | <> (I forgot what it really looks like, just using what I remember). I do use the CustomRanks plugin (not PurePerms/Chat)


[Table] Bad divider color in dark theme

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Dividers should be light in the dark theme.

Current Behavior
Dividers are very dark. It doesn't look cool.

Dividers should be light in the dark theme.

@Krijovnick Why?

@oliviertassinari Because it does not correspond to the guidelines .

@Krijovnick It's a theme, not the official spec.

@oliviertassinari  Ok, what about the fact that dark dividers are poorly visible on a dark background?

Following the Gestalt theory, you don't need to see the border to perceive the order, symetry is often enough. But maybe we can slightly change it, waiting for the specification to fill the gap. @mbrookes what do you think?

Hard to say, since the "expected" example has a vertical divider that is not present in the current implementation, so it isn't comparing like with like. I wouldn't say the dark dividers are "poorly visible", but the light divider looks a little better from a design perspective IMO. I'd be interested to see a working example of the proposed change to be able to compare properly.

@ Krijovnick Do you want to submit a pull request going in the direction of a light diviser?

#13395 @oliviertassinari


Unable to configure line length

First of all, thanks for the great plugin! This is a huge time saver compared to manually formatting KDoc.
However, I am unable to successfully configure the line length when using the IntelliJ plugin. I have the following .editorconfig file in the root of my project:
root = true

[*.kt]
max_line_length=120

With this setting under "Code Style" enabled:

But whenever I format, it uses the default line length of 72, which is too short for my preferences.

Am I doing anything wrong to configure the max line length?
Could a setting be added to the plugin preferences to specify the line length?

Version: 1.5.1
Thanks!

Try adding this to your .editorconfig:
[*.md]
max_line_length = 72

Note that kdoc-formatter has two separate concepts:

the maximum  line length
the maximum comment width

When you have deeply nested code, this distinction doesn't matter; the comments will break at the maximum line length. But for really wide code lines, the comments will not use the full line width. This is intentional, because for readability, you don't want really long lines -- those are harder to read (it's why books are typically in portrait orientation, not landscape). And for comments, readability is the primary concern, whereas for code, structure is the main concern.
I recently (in 1.5.1) changed the default from matching the line width to being 72. This is typically the default for markdown files, as well as git commit messages. Kdoc formatter will also initialize this value from the line-width configured for markdown files (hence the above [*.md] rule). Maybe this is a bit controversial, though I do think it makes for much nicer comments. At a minimum I should make sure it's easy to configure this for non-.editorconfig projects in IntelliJ.

Thank you for the reply @tnorbye.
I tried making your suggested change, but it's still not working (still defaulting to 72). I even tried changing the file mask to [*], which also does not seem to be detected. Perhaps I'm doing something wrong?
In my project root, I have a file named .editorconfig, with the following contents:
root = true

[*]
max_line_length = 120

FWIW, I'm only trying to auto-format class-level and function-level KDoc. I'm not trying to format standalone markdown files (but I could see that being valuable as well).
I don't have a strong preference on the default behavior, as long as it's configurable, but I will add my $0.02: ~72 is a very practical width for commit messages, but I think the vast majority of codebases will consider it too short for function-level documentation.

I've attempted to fix this, in IDE plugin version 1.5.2. I haven't submitted it to JetBrains yet; can you try installing it to see if it works for you?
With this there's a new setting at the bottom of the KDoc Formatting Options panel.

You can find the plugin zip to install (go to the Plugins settings page, click on the settings icon and then install plugin from disk). You can find the plugin zip on the 1.5.2 release page: https://github.com/tnorbye/kdoc-formatter/releases/tag/v1.5.2

I uploaded 1.5.2 to the plugin center and it's been approved and is public now.

Thanks @tnorbye for this quick fix! Just tested 1.5.2 and it works for my use case. Here's some feedback from testing it:

I'm a little bit confused by the wording "72 characters (or the configured Markdown line length)". If I configure my Markdown line length to be 120, it still appears to use 72:

Unchecking the new option allows me to use my configured line length, BUT, if I change the line length, I have to restart the IDE for the plugin to recognize the new value.
This new option satisfies my personal needs out of this plugin, but I think it may still be more convenient to allow the line width to be specified directly in the plugin settings.

Thanks again!

Thanks for the note about the "collapse short comments" thing not working -- that was an embarassing copy paste error. It's been fixed in 1.5.5, just released. Also in 1.5.3 or 4 I added a new IDE setting which lets you manually configure override line lengths (and comment widths) in the IDE plugin which will override whatever the inferred .editorconfig settings are, which I think gives you what you need -- see the last two text fields here: https://github.com/tnorbye/kdoc-formatter/blob/main/screenshot-settings.png
(I've also done some preliminary work on block and line comments. From the command line you can format whole files with it; from the IDE only interactively the comment under the caret using the dedicated format kdoc action.)
If there are other bugs or remaining things I missed here, please file new separate issues. Thanks again.

Thanks @tnorbye! Love the built-in line width option.
FWIW, I'm still a little confused on "line width" vs "comment width". I thought the plugin only formats KDoc (comments)? Or is it supposed to refer to //-style comments?
Regardless, I'm happy with the current behavior, where the below configuration will correctly only auto-format KDoc to 100 width:

@tnorbye It looks like something broke between version 1.5.4 and 1.5.5 where the above config is no longer working. In 1.5.4 this would correctly format to 100 width. Now it's formatting to 72 again.

Ugh, I see it. Embarrassing. I really should try to write a UI test for this; the formatting machinery is well covered with unit tests but not the plugin UI code.  https://github.com/tnorbye/kdoc-formatter/pull/74

This is available in 1.5.6 now. I've uploaded it to plugins.jetbrains.com; approvals usually take around a day but you can install it manually from https://github.com/tnorbye/kdoc-formatter/releases/tag/v1.5.6


allow empty "" path in Controller ?

https://github.com/starlite-api/starlite/blob/965d97620774991bd302a3a227bd3ebe6236ae96/starlite/controller.py#L27-L28
Context
In some of our project (built with FastAPI) we use Factory classes that helps us creating bunch of endpoints for given user inputs and dependencies (https://developmentseed.org/titiler/advanced/tiler_factories/ https://developmentseed.org/titiler/api/titiler/core/factory/#tilerfactory). This is why I was really interested in the Controller class to replace our Factories.
One problem I'm facing right now is that Controller Path has to be non null.
from starlite import get, Starlite
from starlite.controller import Controller
from starlette.requests import Request

class Endpoints(Controller):
    """TileMatrixSets endpoints."""

    path = "/"

    @get(path="/yo")
    def hey(self, request: Request) -> str:
        return "yipi"

    @get(path="ye")
    def hey2(self, request: Request) -> str:
        return "what"

app = Starlite(route_handlers=[Endpoints])

schema

{
  "openapi": "3.1.0",
  "info": {
    "title": "Starlite API",
    "version": "1.0.0"
  },
  "servers": [
    {
      "url": "/"
    }
  ],
  "paths": {
    "//yo": {
      "get": {
        "operationId": "hey",
        "responses": {
          "200": {
            "description": "Request fulfilled, document follows",
            "headers": {},
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        },
        "deprecated": false
      }
    },
    "//ye": {
      "get": {
        "operationId": "hey2",
        "responses": {
          "200": {
            "description": "Request fulfilled, document follows",
            "headers": {},
            "content": {
              "application/json": {
                "schema": {
                  "type": "string"
                }
              }
            }
          }
        },
        "deprecated": false
      }
    }
  }
}

as we can see in the schema ☝, both endpoints are // prefixed because Starlite is normalizing path (I think).  I can agree that I want to use the Controller class for something it wasn't designed for, but it could be nice if the path could be set to "".
Potential fix
By allowing path to be all but not None it seem to fix my issue, but I'm not quite sure what it means for the rest of the application.
class Endpoints(Controller):
    """TileMatrixSets endpoints."""

    path = ""

    def __init__(self, owner: "Router"):
        if not hasattr(self, "path") or self.path is None:
            raise ImproperlyConfiguredException("Controller subclasses must set a path attribute")

        for key in ["dependencies", "response_headers", "response_class", "guards"]:
            if not hasattr(self, key):
                setattr(self, key, None)

        self.path = self.path
        self.owner = owner
        for route_handler in self.get_route_handlers():
            route_handler.owner = self

    @get(path="/yo")
    def hey(self, request: Request) -> str:
        print(request)
        return "yipi"

    @get(path="/ye")
    def hey2(self, request: Request) -> str:
        print(request)
        return "what"

again, I will understand that I want to use the Controller class outside of its scope 🙏

Hiya.
How about this solution:

We move the validation to a method that is called by Controller.__init__.
You can then override it in your subclass.

@adriangb , you wanna take a look at this?

If I understand you correctly you would.in effect like to use a controller on the root level, correct?

Yes.

If this results in //, we need to fix it.

It does (see schema)

In either case, would you like to add a PR with a fix (and changelog update)?

I can try, later today or tomorrow 😄

@Goldziher I'm not quite sure of the solution here.
Case 1: path = ""
This is quite straight forward, meaning that routes won't have any prefix. This also ensure the user set "" as the path and that we will only raise is path is not set at all. We could just add a note in the documentation (or a warning in the code) that "" path will append routes at the root.
Case 2: path = "/"
This could cause some misunderstanding. To me all routes should be prefixed with / (I believe //yo is a valid path 🤷.

Sure, path 1 is good. Just add a note on the docs as well.
Maybe raise an informative error if the path is set to "/" by the user, or also allow that case.


Added Reverse Link List in C++

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Resolve errors and modify the code.
Added in both the recursive and iterative methods.
Checklist

[x]  I've read the contribution guidelines.

[x]   I've checked the issue list before deciding what to submit.

[x]  I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

Output of both recursive and iterative apporch be like this.


DAF-4690: Fix leak plan's video frame when rotating device

Description
Problem

Plan's video frame was leaked when rotating device

Reason:
The self._betterPlayerView = playerView; is trigger after adding cover view and seems the parent view of cover view is removed
https://github.com/dwango-nfc/betterplayer/blob/a534b15727a14d1060d7c86267d551dc34eaac7f/ios/Classes/BetterPlayer.m#L43-L48
Solution

Check to add cover view continuously
Add condition to only add cover view if needed

What was done (Please be a little bit specific)

Remove condition if (player.isPremiumBannerDisplay != isDisplay) { to add cover view continuously
Add condition to only add cover view if needed (prevent to add multi times)

Reference
JIRA
https://dw-ml-nfc.atlassian.net/browse/DAF-4690
Screenshot or Video (Before/After)
(For a new design, a screenshot should be required. But for new functionality, a video is a great help.)

updated video at: https://github.com/dwango-nfc/dwango-app-ch/pull/1912

Ready for review checklist
Basically, you must check all. (When you ignore any checks, please write each reason.)

[x] All sections above are properly filled in
[x] The PR only deals with one functionality/bug
[x] Includes code refactoring? If yes, the following sub checks are required.

[x] The changes were tested. So there is no degradation.
[ ] The change is not too big. (Reviewers can review it.)

[ ] Includes change of spec? If yes, the sub check is required.

[ ] Updated the document.

[x] Builds and runs on iOS (No new warnings nor new errors)
[ ] Builds and runs on Android (No new warnings nor new errors)

@noboru-i
Please review this PR 🙏


Style1 to patternfly conversion in Virtual Machines

Parent issue: #3139

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

Before:

After:

@epwinchell Please review

@miq-bot add_label wip

@PanSpagetka please update your PR as is described in #4197

Updated, @epwinchell @skateman please review

@miq-bot remove_label wip

@dclarizio Looks good


Get a new laptop

Some good motivation to actually finish my thesis and defend
Looking at the framework 13 with nothing

Optane inside: boot partition + cache

External modules:

1 ssd just for /nix/store
1 sd card reader ?? I like the idea of siloed user vs os space- maybe I get another ssd
1 sd card drawer
1 USB c

tmpfs impermanence #318 - loads of memory

Disko #134

Help make this happen :wink: https://github.com/sponsors/dmadisetti

Almost there! :-)

You should still try snowflake out: https://snowflakeos.org/

I'll put it on my Thinkpad after I back it up! :-)

I think you should mark this as resolved.


Extend the flatDir documentation regarding meta-data and artifact overri...

...ding
This is largely based on the answers at
http://forums.gradle.org/gradle/topics/making_gradle_find_a_jar_in_a_flatdir_repo_when_it_is_missing_from_a_maven_repo#reply_7763289
and
http://forums.gradle.org/gradle/topics/flatdir_repositories_do_not_support_metadata_files-v6tae#reply_14429088

Thanks for the contribution @sschuberth, one of our engineers should be taking a look at it shortly.


Clearnup code using prettier

What does this PR do?
There is prettier configuration file in this project, so I am modifying the code by applying prettier to the editor.
However, some files have found that unnecessary code areas not related to commits have been modified by prettier.
It seems that some files have been modified without being applied.
I clean up code using prettier for  avoid including code changes unrelated to future commits.
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist

[ ] Added relevant tests
[x] Didn't break anything

This commit was applied by #78.


tutorial-part-6-defining-security does not link to part 7

http://apihandyman.io/writing-openapi-swagger-specification-tutorial-part-6-defining-security/ does not link to http://apihandyman.io/writing-openapi-swagger-specification-tutorial-part-7-documentation/ in the conclusion section. Cheers.

As per other issue.

Whoops! Thanks anyway. Cheers.


Deployment Issue

Does this occur consistently?
Repro steps:

Action: azureFunctions.deploy
Error type: 409
Error Message: There is a deployment currently in progress. Please try again when it completes.
Version: 1.0.1
OS: win32
OS Release: 10.0.18363
Product: Visual Studio Code
Product Version: 1.51.1
Language: en

Call Stack
new RestError extension.bundle.js:46:109835
extension.bundle.js:48:167633extension.bundle.js:48:167633
processTicksAndRejections task_queues.js:94:5

Hi @riteshakumar Does this happen consistently? If so, please provide detailed repro steps.


"bep" noise after EOS download complete

When updating from <IP_ADDRESS> to <IP_ADDRESS>, Embassy made a "bep" noise when the download completed. Everything appeared as expected in the UI, Embassy did not restart or lose connectivity. Are we intentionally playing a bep noise on download complete, or did some other process accidentally run?

we are intentionally doing so, though I personally think it is very odd. Very open to suggestions for alternatives.

I thought it was a triple bep, but yes this was a design choice, we can do something else instead. We can change it to whatever.

the triple bep is so fast it sounds like one

We can drop the tempo down substantially, or insert rests between them. But @MattDHill suggested a jingle. I might sub it out for a circle of fourths or circle of fifths voicing.


JSON.stringify(m.prop(x)) use x.toJSON method when possible

When JSON serializing m.prop, check if wrapped object does define toJSON method
and if so, return it's result.
I'm not sure how to properly test javascript code, so please check everything before.

I thought JSON.stringify did that recursively, but I may be wrong.

@husio As @isiahmeadows pointed out in #1179,  a null check on store is required, otherwise you'll get errors when serializing props that hold null and undefined.

@husio Could you add tests for store being null (serializes to null) and undefined (disappears)?


Missing information on personalizations when upgrading

Does personalization re-set when upgrading to a new version? (both On premise/In Cloud).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc9174f7-cad5-7550-b93b-036158d40e38
Version Independent ID: 8e4dabaa-c112-6a2e-dc18-933253579927
Content: Personalizing Pages - Business Central
Content Source: business-central/ui-personalization-user.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: jswymer

What was the result of this issue? It seems nothing was done? If so, why?


Text comparison lag/crash

Current behavior
When I copy text from field 'Old text' 'New text' s via 'CTRL + C' program lags for like 10-30 seconds or crash
How to reproduce it (as minimally and precisely as possible)

Open last DevToys release.
Goto 'Text' part.
Select 'Text comparison'
Input some text in any field
Select text via 'CTRL + A' or mouse
Press 'CTRL + C'

Expected behavior
Instant copy, no lag.
Screenshots
No response
Workaround
No response
Affected platforms
Windows
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
Версия <IP_ADDRESS> | X64 | RELEASE | 2706c6c2 | 2706c6c2
Relevant Assets/Logs
No response

Hello,
This got fixed in DevToys 2.0, which will be released in a few weeks.


fix: Add await to PyPI version check request

This pull request includes a small but important change to the get_lf_version_from_pypi function in the src/backend/base/langflow/services/store/utils.py file. The change ensures that the HTTP request to retrieve the version information from PyPI is awaited correctly.

src/backend/base/langflow/services/store/utils.py: Modified the get_lf_version_from_pypi function to await the HTTP request using await client.get to ensure proper asynchronous behavior.

I did it first hahah #4708


add openPrevImg and openNextImg action to advanced mode

Advanced mode speeds up annotation efficiently, but I got confused there is not a good way to switch to next/prev image. Is is function under development or just I didn't find it?

OS: Windows10
PyQt version: py2-qt4

I add the functionality by modifying here
self.actions.advanced = (
            changeSavedir, opendir, openNextImg, openPrevImg, save, None,
            createMode, editMode, None,
            hideAll, showAll)


Cannot compile x86 GRPC 1.8 or 1.10 on Windows 10 Platform

Hi. I am having issues compiling the new GRPC platform on my local machine. I am going to tag @jtattermusch since he helped me last time and was the one that setup all the Windows CMake stuff a year ago when it was not very well documented yet.
I am using Visual Studios Enterprise 2015. Version 14.0.25431.01 Update 3
I followed the instructions on both the 1.8.x and 1.10.x branches and have been getting this same pop up each time:

It freezes on this section of the compilation steps:
-- Found Threads: TRUE
-- Found Perl: C:/Perl64/bin/perl.exe (found version "5.24.3")
-- Check size of __int32
-- Check size of __int32 - done
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.10.1.windows.1")
-- git Version: v1.3.5-474c5950
-- Version: 1.3.5
-- Performing Test HAVE_STD_REGEX

As soon as I click "Ok" it spits out this information
-- Performing Test HAVE_STD_REGEX -- compiled but failed to run
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- failed to compile
CMake Error at third_party/benchmark/CMakeLists.txt:183 (message):
  Failed to determine the source files for the regular expression backend

-- Configuring incomplete, errors occurred!

I have attempted to use the old cmake build method with Ninja and the new Visual Studios solution file build instructions. I even upgraded Go/Perl/Ninja because I thought there might have been something new i needed in a more recent version.
I would like to note that I was able to compile x64 without any issues when using Ninja. I only have been having issues when trying to build x86 or trying to build for both (the Visual Studios approach).
Below are two gists for my cmake logs which are labeled.
CMakeOutput.log: https://gist.github.com/mastergberry/464b1630acf9694a34a8f1cdc3e82e4d
CMakeError.log: https://gist.github.com/mastergberry/6f15b6be7211c3d658381b3563494394
Happy to provide any other information or logs that might be useful. Thanks.

@mastergberry   does the x86 build work well with VS only build (= not using Ninja)?   We have a continuous test for x86 build on Visual Studio (which is passing consistently), but we are not testing testing with Ninja directly.

@jtattermusch Hey, if you mean these steps from the INSTALL.md file:
> @rem Run from grpc directory after cloning the repo with --recursive or updating submodules.
> md .build
> cd .build
> cmake .. -G "Visual Studio 14 2015" -DCMAKE_BUILD_TYPE=Release
> cmake --build .

Then yes I tried using this too and it did not work for me. It was crashing on the same spot as the ninja build was.

Here are the logs from using the Visual Studio build approach:
CMakeError.log: https://gist.github.com/mastergberry/698c426b005a23f57e595c62a1cf7104
CMakeOutput.log: https://gist.github.com/mastergberry/2da412bcc0a474a6124c44cd6ef9b8dc

@mastergberry   from what you're saying it looks more like the "Performing Test HAVE_STD_REGEX" fails for some reason - which would point to a cmake issue. Which cmake version are you using?

@jtattermusch
cmake version 3.7.2

CMake suite maintained and supported by Kitware (kitware.com/cmake)

Is there a recommended version of cmake? I would have imagined that the cmake files would have complained earlier on about outdated versions (I thought it checks for this in the Makefiles)

I also have cmake 3.7.2 (anything >2.8.x should work I believe)

@mastergberry   if you could do git bisect to see which commit introduced this problem, it would be great.

@jtattermusch I'm not familiar with this command. I looked it up briefly and it looks like I need to

type git bisect start on the current version
type git bisect bad on the current version
type git bisect good [hash of working build]

and then it will do some kind of binary search between the number of commits to find the bad commit by checking out random commits and me building each one right?

@mastergberry   yes, it allows you to find out which commit introduced a suspected breakage (=> you're saying that the build worked for you earlier and then got broken). in a reasonable (logarithmic) number of steps.

@jtattermusch  After all of my testing I realized later on that this command call "%VS140COMNTOOLS%..\..\VC\vcvarsall.bat" x86 was giving the following output instead of nothing
The input line is too long.
The syntax of the command is incorrect.

The last command i typed was git bisect good and I got this output
commit 438c0b5771d748df299a75a844fa70c8e8539b5a
Author: Jan Tattermusch<EMAIL_ADDRESS>Date:   Mon Jan 23 11:24:53 2017 +0100

    add convenience cmake targets

:100644 100644 1b66ee7894c60cd09725790fa5e68ff3d218059c 41d677d4d24827b88ce5635096ba1c4b1fa93b9c M  CMakeLists.txt
:040000 040000 17a453fd172cc9d19f59c0a6e66d6b355f667937 e2aee457f5b5121f1e9e59f93f5017adb2819f3e M  templates

Just noting it was not always saying
The input line is too long.
The syntax of the command is incorrect.

Just on some of the older builds when i got far enough in the git bisect

@mastergberry   I think the The input line is too long. error is unrelated - it happens when you the vcvarsall.bat is called multiple times and keeps appending to the env variables until they grow too large.

@jtattermusch ok do u need anything else from me atm?

I do not have an explanation, but this should at least narrow it down:
grpc includes the google/benchmark library. This has a couple of regex tests. It is one of those regex tests that is failing for @mastergberry .
Here is the console output when the configuration succeeds with VS2015:
-- Performing Test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX -- success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- failed to compile

The error message that @mastergberry provides a screenshot of, and the message -- Performing Test HAVE_STD_REGEX -- compiled but failed to run indicates that CMake compiles a small test program, but the OS then fails to run it.
The failing feature detection step is invoked from this CMakeLists.txt file.
It has a couple of lines which attempt to compile and run a small test program.
The source file for the test program is quite short.
Then this line prints an error under the unusual condition that the test program compiled, but the OS was unable to start the application. This is normally only something that people run into when they cross-compile, because then they will compile for a different OS/CPU architecture than they are currently on -- and the compiled result will naturally not be executable under their host OS.
So... It appears that the small example program that is being built by CMake is not startable on @mastergberry 's machine. There are some tips on how to debug try_compile & try_run problems.
It so happens that for google/benchmark, launching cmake multiple times will re-run the regex dection steps (and only those steps). Therefore, when I cmake with this command line: cmake .. -G "Visual Studio 14 2015" -DCMAKE_BUILD_TYPE=Release --debug-trycompile , I get just the relevant files in Release\CMakeFiles\CMakeTmp. A bit of free-text searching allows me to pinpoint which exact files/folders are relevant to this particular problem.
@mastergberry If you do a debug run, you will be able to find Visual Studio solution files, log files from the compilation/link steps, and the final test executables, all in that directory. If you inspect those, perhaps you can find out why one of the test executables is not possible to launch on your machine.

So...I reformatted my machine (it was a mess...it needed to be done) and now I am having no issues getting the first cmake command to run. When I try to run the second cmake command though I am getting some errors related to vsyasm.exe returning 1 on boringssl stuff.
I remember I had a similar issue a while back...this thing was weird to install. I tried copying it into the locations from the readme but doesn't seem to help. Any stupid/easy thing I am doing wrong?

After a complete re-install of VS2015 I managed to get this to build......so yeah just kinda picky still for the installation process :(
Closing since it was something corrupt on my original installation.


Name conflicts when importing

When importing from http://localhost:3000/visualization-types/preview/?path=path/to/viz (http://localhost:3000/visualization-types/preview/?path=lightning-default-visualizations/map for example), if there already exists a visualization with the name I choose, it silently shits itself with a
POST http://localhost:3000/visualizations/types/ 500 (Internal Server Error)
fake_1eae9067.js:72 Uncaught TypeError: Cannot read property 'id' of null

thanks for reporting! added some more informative error handling in 670cc631746e02ea557d2a8a10a8a671eb503101


server-center的文档太少了，配置文件中的各个配置项应该再详细说明一下，要不知道不知道怎么自定义配置

服务中心相关文档可以参考以下开发指南，针对配置文件说明，将会在最近的release中更新。

@asifdxtreme

@mawenyu， thanks for your kind attention, this issue will be closed before next Monday if there is no further question about it, because all unsolved issues will be moved to Apache JIRA in next Mondy. Anyway, you can still follow us or open an issue at Apache JIRA https://issues.apache.org/jira/projects/SCB/issues/SCB-21?filter=allopenissues Thanks again!


how to get settings for my service class in O2

now I only can borrow the idea from
var contentTypeDefinition = _contentDefinitionManager.GetTypeDefinition("Menu");
if (!contentTypeDefinition.Settings.ToObject().Draftable)
inside public class AdminController of namespace Orchard.Menu.Controllers.
but notice something like  "Menu" is hard code inside my service class.
in O1, I can use IWorkContextAccessor or IOrchardServices to get settings.
for example:
_orchardServices.WorkContext.CurrentSite.As<CloudMediaSettingsPart>().IsValid()

ISite is not a content item anymore in OC, but it's extensible as it's a JSon document.
Here is an example:
https://github.com/OrchardCMS/Orchard2/blob/8d78c6761297d2198c7a101b4179e28fe67f3651/src/OrchardCore.Modules/OrchardCore.Lucene/LuceneIndexingService.cs#L161
You'll find how to create a custom driver in the same module.


Store nested list?

Problem:
Having fun working from the nested example to develop a folders/files interface for a project. Now hitting a wall regarding how to store the entire nested structure? When using the store as I had on a normal unnested group, I'm only seeing the changes within a single level of the nesting. So I have two questions:
– Is it possible to get an overall structure of a single group? Some sort of tree? My plans would be to store this in localStorage, then dynamically rebuild the divs/folders/structure when recalling that storage.
– Is it possible to call a Sortable.create(...) with recursion? I've found that if I have div's within div's.. and tell the most parent div to be a Sortable, only the first children become sortable.. it would be helpful if it could have a boolean for recursion, then use filtering to avoid certain elements from becoming sortable.
JSBin/JSFiddle demonstrating the problem:
https://jsbin.com/homisukebi/edit?html,console,output

I managed to solve it by recursively traversing through the DOM elements and storing them as a JSON object. Still wondering if there's a function I missed that could export such a tree? I was hoping for something like the toHierarchy of nestedSortable + demo, however until now I haven't needed JQuery and this Sortable lib has been great to work with.
Slowly realising that allowing nesting of nesting quickly leads to fun recursive issues. So it would be awesome if the library could both allow a recursive initialisation (right now it's just childNodes, rather than nodes of nodes...) so one wouldn't have to loop through the items separately and having such an export for storing complex nesting.
Here's updated code for recursive nesting/storing incase there's an idea to plug this into the library:
JSBin – Recursive Sortable

@ffd8 Sortable does not have such a function, though I'm sure you could manage it by just using Sortable's events. You could also use a JavaScript framework and a biding like VueDraggable which will do it for you: https://sortablejs.github.io/Vue.Draggable/#/nested-example


Fix small copy and paste error

This PR corrects the error output in case of an parsing error in the gce_sd_config.

Thanks!


[Next] Use of custom sort order feature corrupts data in collection

Create a collection with "sortable entries" checked.
Create some entries in this collection
On the entries view, drag to reorder them. It displays a notification informing you that the entries have been reordered.
Refresh the page. Note that all entries are now completely blanked out with no data. Upon checking entries in database (MongoDB in this case) they no longer have data for the appropriate schema.

Yes I just reproduced again using latest from next branch

// result of /find call before reordering
{
    "entries": [
        {
            "_id": "5acbea32d8aa88f94f8b4569",
            "field1": "asgadg",
            "field2": "gadfg",
            "field3": "asd",
            "_mby": "57d07cfbd8aa887b468b4567",
            "_by": "57d07cfbd8aa887b468b4567",
            "_modified":<PHONE_NUMBER>,
            "_created":<PHONE_NUMBER>
        }
    ],
    "count": 1,
    "pages": 1,
    "page": 1
}

// result of /save call after reordering
{
    "result": [
        {
            "_id": "5acbea32d8aa88f94f8b4569",
            "_order": 0,
            "_modified":<PHONE_NUMBER>
        },
        {
            "_id": "5acbe8d5d8aa8812508b456d",
            "_order": 1,
            "_modified":<PHONE_NUMBER>
        }
    ]
}

//result of /find call after subsequent /find call
{
    "entries": [
        {
            "_id": "5acbea32d8aa88f94f8b4569",
            "_order": 0,
            "_modified":<PHONE_NUMBER>
        }
    ],
    "count": 1,
    "pages": 1,
    "page": 1
}

This may be a MongoDB-specific bug, have you tried it using a MongdoDB installation?

yes, I tried v3.6.3 🤔

We are on 2.6.11 maybe that's why

Which php mongodb driver version are you using? - https://github.com/mongodb/mongo-php-driver

php55u-pecl-mongo-1.6.14-1.ius.centos7.x86_64

so you're using the deprecated mongo lib instead of https://pecl.php.net/package/mongodb ?

Apparently so! Unfortunately CentOS / RHEL has all kinds of way outdated software as default. I can push devops guys to upgrade us if we are using unsupported software. I'll start with asking them to upgrade our mongodb driver and see if that addresses the issue.

Updating the mongo driver fixed it! Thanks for your help on this


AMBARI-21858 Not able to enable hive Interactive Query

What changes were proposed in this pull request?
AMBARI-21858 Not able to enable hive Interactive Query
app.js throws a javascript error when request_schedules exists in Database with no batch_requests.
How was this patch tested?
Tested in UI, works well in all Browsers.
[INFO] --- maven-install-plugin:2.4:install (default-install) @ ambari-web ---
[INFO] Installing /Users/asnaik/Documents/Work/code/forked_Ambari/ambari/ambari-web/pom.xml to /Users/asnaik/.m2/repository/org/apache/ambari/ambari-web/<IP_ADDRESS>.0/ambari-web-<IP_ADDRESS>.0.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:29 min
[INFO] Finished at: 2018-04-23T12:59:59+05:30
[INFO] Final Memory: 15M/220M
[INFO] ------------------------------------------------------------------------

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1944/
Test PASSed.


Migrate highlight file refernces to use @malloydata/syntax-highlight

Transfered to https://github.com/malloydata/malloydata.github.io/pull/100


Not working on UE5.0.2

Does not work on Unreal engine 5.0.2
-Crashes at startup

Odd. It works on 5.0.2 on my end. Part of me feels that it could just be something related to file path length, as Unreal doesn't seem to like long filepath names at all. As such, I was unable to reproduce your issue.

This is what I'm getting for the crash:
LoginId:9c557af6844086e4411e889ba367ceca
EpicAccountId:f676fdb1b6e346f88211354651eebc05
Assertion failed: IsValid(Platform) [File:/Users/build/Build/++UE5/Sync/Engine/Source/Runtime/RHI/Public/RHIDefinitions.h] [Line: 461]
PlatformCreateDynamicRHI() Address = 0x10730f726 (filename not found) [in UnrealEditor-RHI.dylib]
RHIInit(bool) Address = 0x107310ff8 (filename not found) [in UnrealEditor-RHI.dylib]
FEngineLoop::PreInitPreStartupScreen(char16_t const*) Address = 0x1068c77f6 (filename not found) [in UnrealEditor]
GuardedMain(char16_t const*) Address = 0x1068be604 (filename not found) [in UnrealEditor]
-[UEAppDelegate runGameThread:] Address = 0x1068da033 (filename not found) [in UnrealEditor]
-[FCocoaGameThread main] Address = 0x10926b561 (filename not found) [in UnrealEditor-Core.dylib]
Unknown() Address = 0x7ff801a7f964 (filename not found) [in Foundation]
_pthread_start Address = 0x7ff800b644e1 (filename not found) [in libsystem_pthread.dylib]

Doesn't happen on my end.


How do I initialize a datasheet with empty columns and rows which fills up my container?

I have looked around alot but could not find the solution even in the documentation

Sorry @nick318, this repo is not really maintained but for whoever finds this:
You need to initialize empty data matrix and pass it on to the data field
      <ReactDataSheet
        data={ [["",""],["",""]]} />


Unexpected bedtools intersect behavior

In the course of doing some debugging on an analysis pipeline I've written, I've found some unexpected behavior in bedtools intersect.
As we know, bed intervals are half-open, so the interval [a,b) contains the position a, but not the position b.  As a result, the intervals [a,b) and [b,c) do not overlap, and should not be output as intersecting by bedtools intersect. Indeed, this is indeed the case when c > b.
However, in the bed file I'm using for file B, some records are annotated with the same start and stop coordinate. In this instance, if you have an interval [a,b) in file A and an interval [b,b) in file B, bedtools intersect will report this as a valid intersection and return an intersection record, even though position b does not overlap the interval [a,b).
I’ve been able to reproduce this behavior in bedtools 2.25, 2.26, 2.27, and 2.28.
Is there a rational reason for this behavior?  It seems like it would be more reasonable for bedtools intersect to return nothing in this case.
Thank you very much,
Kyle

when start == end, bedtools interprets this as an insertion between the two flanking bases and thus intersections arise with the two flanking bases.


add newest example to dependabot.yml, automate file update process

see individual commit messages for further details.

now it's finally ready. that check took me ages to figure out... turns out that the default sorting on my machine was different than on the linux runner and you had to set LC_ALL in just the right way for it to work