Creating objects via Management API with many-references not working

Hey guys,
we are trying to populate an initial content-set via contentful_model.
Now we have classes like this:
class ContentfulPerson < ContentfulModel::Base
  self.content_type_id = 'person'

  has_one :organization, class_name: 'ContentfulOrganization'
  has_many :abilities, class_name: 'ContentfulAbility'
end

Now creating a person like so ContentfulPerson.create(name: 'some_name') is working.
But what is now working is something like this:
p = ContentfulPerson.create(name: 'some_name')
o = ContentfulOrganization.find_by(...).load.first
p.organization = o
p.save

Gives me
SystemStackError: stack level too deep
from /Users/tim/.rbenv/versions/2.2.3/gemsets/kplus-pipedrive-export/gems/activesupport-5.0.0/lib/active_support/core_ext/object/instance_variables.rb:13:in `map'

But I also tried
t = ContentfulAbility.find_by(...).load.first
p.abilities = [t]
p.save
=> #<Contentful::Management::UnprocessableEntity: Validation error>

Is this supposed to work already?
Sidenote: I did this successfully with just using classes and objects from contentful.rb and contentful-management.rb. In combination they support setting references like this.
Thanks for any help!

I investigated this further. The Validation-problem that occurs is this one:
"{
  "sys": {
    "type": "Error",
    "id": "InvalidEntry"
  },
  "message": "Validation error",
  "details": {
    "errors": [
      {
        "name": "type",
        "value": null,
        "type": "Object",
        "details": "The type of \\"value\\" is incorrect, expected type: Object",
        "path": [
          "fields",
          "abilities",
          "en-US",
          0
        ]
      },
      {
        "name": "type",
        "value": null,
        "type": "Object",
        "details": "The type of \\"value\\" is incorrect, expected type: Object",
        "path": [
          "fields",
          "abilities",
          "en-US",
          1
        ]
      },
      {
        "name": "type",
        "value": null,
        "type": "Object",
        "details": "The type of \\"value\\" is incorrect, expected type: Object",
        "path": [
          "fields",
          "abilities",
          "en-US",
          2
        ]
      },
      {
        "name": "type",
        "value": null,
        "type": "Object",
        "details": "The type of \\"value\\" is incorrect, expected type: Object",
        "path": [
          "fields",
          "abilities",
          "en-US",
          3
        ]
      }
    ]
  },
  "requestId": "..."
}

Seems like the API does not accept the creation of Links via the API in the format that is currently send. How is it supposed to be send? There isn't any documentation online.

Hey @toadle,
Looks like I totally overlooked this case, I forgot linked entries somehow 😅
I might be able to have a simple fix early next week.
Would that be ok for you?
Cheers

@dlitvakb Thanks for getting back!
A quick fix would be really great.
Also I have to revise my previous statement. I tried to replicate this with just using contentful.rb and content-management.rb.
Some time ago doing this:
space = Contentful::Management::Space.find(...)
content_type = space.content_types.find(...)
content_type.entries.create(@fields[default_locale])

in a Contentful::Entry worked. I added other Contentful::Entrys as properties there.
Sadly now it does not anymore.
Did the API change?

No, it did not. #selfanswer :-)
@dlitvakb But should be fixed by this: https://github.com/contentful/contentful-management.rb/pull/105

Hey @toadle,
Sounds good! Just made a few comments on that PR.
Cheers


Migrate existing apps/plugins with minimum supported iOS version from 8.0 to 9.0

Migrate existing apps and plugins with a minimum version of 8.0 to 9.0.
https://github.com/flutter/flutter/issues/60035 can update the templates.

If this turns out to be risky, we can also add documentation for how users can do this manually.

I would love to have a documentation on that, or know which flutter version to use, I'm currently changing manually every IPHONEOS_DEPLOYMENT_TARGET to get past that.

I would love to have a documentation on that, or know which flutter version to use, I'm currently changing manually every IPHONEOS_DEPLOYMENT_TARGET to get past that.

@danielFloat Where are you changing that?  In your app project, or in a plugin podspec, or...

@danielFloat Where are you changing that?  In your app project, or in a plugin podspec, or...

I'm changing it on the Pod project.pbxproj, my app project is pointing to 10.3 .
Just migrated from an old flutter version, 1.20.4, to the stable most recent one and I'm not able to build for the emulator for some reason, been facing this issue along with several others that seems like cache/old config/build system issues.

I'm changing it on the Pod project.pbxproj, my app project is pointing to 10.3 .
Just migrated from an old flutter version, 1.20.4, to the stable most recent one and I'm not able to build for the emulator for some reason, been facing this issue along with several others that seems like cache/old config/build system issues.

@danielFloat The Pod project files are regenerated.  You can update your preferred platform in ios/Podfile to
platform :ios, '10.3' to make it stick.

@danielFloat The Pod project files are regenerated.  You can update your preferred platform in ios/Podfile to
platform :ios, '10.3' to make it stick.

Just migrated from an old flutter version, 1.20.4, to the stable most recent one and I'm not able to build for the emulator for some reason, been facing this issue along with several others that seems like cache/old config/build system issues.

Please file a new issue and completely fill out the template, including flutter run --verbose logs.

Just migrated from an old flutter version, 1.20.4, to the stable most recent one and I'm not able to build for the emulator for some reason, been facing this issue along with several others that seems like cache/old config/build system issues.

Please file a new issue and completely fill out the template, including flutter run --verbose logs.

This can track plugins migration, https://github.com/flutter/flutter/issues/85173 will track app migration.

Updating 1p plugins is tracked with https://github.com/flutter/flutter/issues/84198.  This issue is tracking any tool work.


#4732: Clean up compute kernel apis

Got a green pipeline here: https://github.com/tenstorrent-metal/tt-metal/actions/runs/7891088363
will merge soon.


HBASE-27892 Report memstore on-heap and off-heap size as jmx metrics

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
2m 44s
master passed

+1 :green_heart:
checkstyle
0m 46s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 52s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 34s
the patch passed

+1 :green_heart:
compile
2m 41s
the patch passed

+1 :green_heart:
javac
2m 41s
the patch passed

+1 :green_heart:
checkstyle
0m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  2s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  4s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

34m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 85d64bb19c56 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / da171c341e

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 18s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
1m  0s
master passed

+1 :green_heart:
shadedjars
4m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
4m 37s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 43s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
216m 11s
hbase-server in the patch passed.

240m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b565cc5bc876 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / da171c341e

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/testReport/

Max. process+thread count
4671 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 58s
master passed

+1 :green_heart:
compile
0m 51s
master passed

+1 :green_heart:
shadedjars
5m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
5m 44s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 36s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
252m 19s
hbase-server in the patch failed.

278m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6c9c20944eb9 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / da171c341e

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/testReport/

Max. process+thread count
4605 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 48s
master passed

+1 :green_heart:
compile
2m 43s
master passed

+1 :green_heart:
checkstyle
0m 46s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
2m 40s
the patch passed

+1 :green_heart:
javac
2m 40s
the patch passed

+1 :green_heart:
checkstyle
0m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
9m  0s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 43s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m  8s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

38m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 0ed6b62c38b1 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66fd6db9c5

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 18s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 51s
master passed

+1 :green_heart:
compile
1m 33s
master passed

+1 :green_heart:
shadedjars
4m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 32s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
4m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 42s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
222m  2s
hbase-server in the patch failed.

249m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 853b2bb98ba6 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66fd6db9c5

Default Java
Eclipse Adoptium-11.0.17+8

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/testReport/

Max. process+thread count
4696 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 28s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
shadedjars
5m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
5m 54s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 36s
hbase-hadoop-compat in the patch passed.

-1 :x:
unit
248m 16s
hbase-server in the patch failed.

273m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5308

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 16d6c1ba90f2 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 66fd6db9c5

Default Java
Temurin-1.8.0_352-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/testReport/

Max. process+thread count
4656 (vs. ulimit of 30000)

modules
C: hbase-hadoop-compat hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5308/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I ran the tests locally and they passed in my local


Speedy improvements

When using the --save_png flag, the io.save_masks() method attempts to make a PNG of the original image/predicted outlines/predicted masks/cell pose. This takes a lot of time, especially for large images. I've added a default flag to disable the block in io.save_masks() that makes the matplotlib figure. I've exposed this flag to the CLI and API.
Alternatively, the image data could be reshaped manually, rather than letting matplotlib do the work. (@carsen-stringer)
Example CLI data after setting default behavior to skip matplotlib:

10 Mb image, 2600x1500

Base runtime: 98 seconds
With --save_png: 105 seconds
With --save_png and --save_mpl: 121 seconds

100 Mb image, 5700x6500

Base runtime:
With --save_png: 668 seconds
With --save_png and --save_mpl: 1562 seconds

This also is related to the OOM issues #735, since the memory spikes at the end of matplotlib figure creation.

Test initially not passing due to persistent GH actions weirdness. (Environment wasn't able to be created). Passing now. @carsen-stringer


Implement a Parser type for error messaging

Using a Parser type allows us to abstract the return type away from the decode
function. This shifts some naming to what Aeson uses for an easier comparison
to their technique. The old decode function is now fromJSON and the new
decode function is a global function with multiple implementations for
different return types. It also abstracts away the JSON.parse function. The
user can now just call decode on their JSON and get back the Optional decoded
type, or if they prefer they can get the Parser type directly and use it to
view errors.
With Parser, we also don't have dependence on the return type. Someone using a
Result framework like LlamaKit could implement a global decode function for
Result and everything internal would work as normal.

Fixes #67

I'm really happy with how this turned out. Fantastic work. I think we should do this. Any comments/concerns from @thoughtbot/ios (or anyone else watching this repo) here?

Also, a question on naming. I've used fromJSON in place of the old decode function but Aeson uses FromJSON as the protocol name and parseJSON as the function name. If our function is returning a Parser object then does parseJSON make more sense for us too?

I think it's cool to use Aeson as a model, but I think you should feel free to use what you think is intuitive and will generally make sense to the iOS community Argo is intended for. I'm guessing you'll have more users who have previously used Objective-C than have previously used Haskell. I'd pick names that will work for your audience.

I agree with you Joe, but I don't think any of these names would be confusing to iOS devs. I'm open to anything though, not just fromJSON or parseJSON.

Yeah, either would really work. I'd be interested in feedback from @thoughtbot/ios on this.

I really like this solution, but I think the name Parser is a bit confusing. It's just a value type and not doing much parsing, like the name suggests. Wouldn't it be better to call it Result or ParseResult?
Also, I think it would be nice to have a constructor for Parser that takes a T, or a global pure() function, so we can forget about the boxing if we create a Parser.

It's just a value type and not doing much parsing, like the name suggests. Wouldn't it be better to call it Result or ParseResult?

+1 for ParseResult.

I like ParseResult as well ... made those changes.   Does it make sense now to use parseJSON instead of fromJSON? I think I like func parseJSON(JSON) -> ParseResult<User> better than func fromJSON(JSON) -> ParseResult<User>

I like ParseResult as well ... made those changes.

Don't forget to rename Parser.swift to ParseResult.swift.

Does it make sense now to use parseJSON instead of fromJSON?

We're talking about the function that exists on JSON, right? If so, I'd argue that that function should just be called parse(). Following this line of reasoning, maybe JSONDecodable deserves a new name as well? JSONParsable? Just Parsable?

We're talking about the function that exists on JSON, right? If so, I'd argue that that function should just be called parse(). Following this line of reasoning, maybe JSONDecodable deserves a new name as well? JSONParsable? Just Parsable?

He's talking about the function on JSONDecodable instances.

On Mar 6, 2015, at 19:21, Mark Adams<EMAIL_ADDRESS>wrote:
I like ParseResult as well ... made those changes.
Don't forget to rename Parser.swift to ParseResult.swift.
Does it make sense now to use parseJSON instead of fromJSON?
We're talking about the function that exists on JSON, right? If so, I'd argue that that function should just be called parse(). Following this line of reasoning, maybe JSONDecodable deserves a new name as well? JSONParsable? Just Parsable?
—
Reply to this email directly or view it on GitHub.

I think I like func parseJSON(JSON) -> ParseResult<User> better than func fromJSON(JSON) -> ParseResult<User>

I also think the first one is better, but agree with @hyperspacemark that the protocol name JSONDecodable is weird in that case. On the other hand, I like JSONDecodable much better that JSONParsable
Just another suggestion: the name parsing is used convert from strings or AnyObject to structured data, wether it be to JSON or some model. the name decoding is used when converting JSON to some model. The result type can than be called DecodeResult and the global functions would then be called parse:
public func parse<T: JSONDecodable where T == T.DecodedType>(object: AnyObject) -> DecodeResult <T>

So the protocol would be
public protocol JSONDecodable {
  typealias DecodedType = Self
  static func decode(json: JSON) -> DecodeResult<DecodedType>
}

Tried to name things more like decode since the protocol is JSONDecodable. Take a look and leave feedback. I can always drop this commit if it's not as nice. @thoughtbot/ios @nvh

This is indeed exactly as I had it in mind.

I'm cool with this. Do we need to name parse and decode differently? Is there any real benefit there?

@thoughtbot/ios Any more feedback on this? I'm going to merge it in by end of day if not.

This is really great now. Big fan.


Spam Video ID Submission

Duplicate Links

[X] Yes, I checked that the ID is not currently in the list
[X] I read the wiki explaining each different categories and examples before submitting

(Required) Spam Comment Direct Link
https://www.youtube.com/watch?v=qGJLTDxnMs8&lc=UgzZ77edLIYLFLPQf-54AaABAg.9njH1YIz10f9njKIMPq0W7
https://www.youtube.com/watch?v=qGJLTDxnMs8&lc=UgzZ77edLIYLFLPQf-54AaABAg.9njH1YIz10f9njKVlr4VSS
https://www.youtube.com/watch?v=qGJLTDxnMs8&lc=UgzZ77edLIYLFLPQf-54AaABAg.9njH1YIz10f9njQ4Bi7bNx
https://www.youtube.com/watch?v=XUGnGg8uH34&lc=Ugza-wuQ2rxUDWSuzWx4AaABAg.9nCsDxeHhXR9nCtoKaOLB1
https://www.youtube.com/watch?v=LaI7EUsSiN8&lc=UgydDL_H-j73v2FqzqZ4AaABAg.9n5FeallmBU9n5JZhy5WRS
https://www.youtube.com/watch?v=LaI7EUsSiN8&lc=Ugyj4Skhmu8s7lf7Pe94AaABAg.9n5Fn7kIvwb9n7H2t0wYnR
https://www.youtube.com/watch?v=5Cortkj-0ZU&lc=UgwKmfSd3zpGiMTvLx14AaABAg.9n00y8i1UQ69n010P1Srwn
https://www.youtube.com/watch?v=HjBo--1n8lI&lc=UgxFnhkMLDSj0erS_L94AaABAg.9m3BWTmIEiT9m3VyxbusOq
(Optional) Screenshot of comments using the link

(Required) List of the spam video IDs / Links
https://youtu.be/TlBi_ZwmSWA
https://youtu.be/5MobqBo1HqY
https://youtu.be/-3DyBTUfPsc
https://youtu.be/DBrKDLcYhWM
https://youtu.be/hGA0eEfcnB4
https://youtu.be/I3j-RDMsz68
https://youtu.be/yBDBtIZNx3o
https://youtu.be/aOrr-IJfI3s

In fact, just to be safe, you might as well add all of these channels' videos to the registry:
https://www.youtube.com/@fec3195
https://www.youtube.com/@FieRcEOFF
https://www.youtube.com/@Memecious
https://www.youtube.com/@imy123
https://www.youtube.com/@onedervfx
https://www.youtube.com/@egycrafts
https://www.youtube.com/@choppahboi1

https://youtu.be/TlBi_ZwmSWA
https://youtu.be/5MobqBo1HqY
https://youtu.be/-3DyBTUfPsc
https://youtu.be/DBrKDLcYhWM
https://youtu.be/hGA0eEfcnB4
https://youtu.be/I3j-RDMsz68
https://youtu.be/yBDBtIZNx3o
https://youtu.be/aOrr-IJfI3s

Without even looking at the lists I know several of these are in them already. The top 3 I did last night for certain.
I will check the others shortly.

In fact, just to be safe, you might as well add all of these channels' videos to the registry:

Whilst they may spam videos with links I do not feel comfortable adding every video from all of those creators to the list without proof those are being spammed.

Go ahead and close the issue once you're done with it.


Substitute command cannot insert new lines

Make a new file with contents hello
Type :s/l/l\r/g and press Enter

Expected: File should become:
hel
l
o

Actual: File becomes helrlro

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


Improve relevance for doc search results

For instance, if I'm interested in searching for "as remaining" in the docs, the most relevant results which include the full string are not at the top of the search results box.

This was achieved by moving to the Starlight documentation framework with the Pagefind search engine that comes with it.

No, it's not fixed:


testing updating buildtools

Noticed deprecation warnings for old versions of codeql-actions and actions. Tried out if something breaks with upgrading, but seems to work fine. Should we do a sweep and update each service?

Yes, we should update all services. Maybe poc the workflow-repo as a part of this work?

Yeah thats probably a good way to go about it. Will close this PR for now as we POC the shared workflow-repo and see if that path is a good way forward. If it is we wont need this PR else we have to revisit it.


Exercise all routes.py in unit tests

for issue-cred, present-proof protocols
Signed-off-by: sklump<EMAIL_ADDRESS>

Codecov Report

Merging #266 into master will increase coverage by 1.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   74.98%   76.22%   +1.24%
==========================================
  Files         230      230
  Lines       10554    10554
==========================================
+ Hits         7914     8045     +131
+ Misses       2640     2509     -131


build error DCHECK

When I want to build Arrow C++ libraries follow the step from build steps.  I have got following errors:
In file included from /root/repos/arrow/cpp/src/arrow/json/chunker.h:26:0,
                 from /root/repos/arrow/cpp/src/arrow/json/chunker.cc:18:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘__m128i arrow::SSE4_cmpestrm(__m128i, int, __m128i, int)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:125:3: error: there are no arguments to ‘DCHECK’ that depend on a template parameter, so a declaration of ‘DCHECK’ must be available [-fpermissive]
   DCHECK(false) << "CPU doesn't support SSE 4.2";
   ^~~~~~
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:125:3: note: (if you use ‘-fpermissive’, G++ will accept your code, but allowing the use of an undeclared name is deprecated)
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘int arrow::SSE4_cmpestri(__m128i, int, __m128i, int)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:131:3: error: there are no arguments to ‘DCHECK’ that depend on a template parameter, so a declaration of ‘DCHECK’ must be available [-fpermissive]
   DCHECK(false) << "CPU doesn't support SSE 4.2";
   ^~~~~~
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘uint32_t arrow::SSE4_crc32_u8(uint32_t, uint8_t)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:136:3: error: ‘DCHECK’ was not declared in this scope
   DCHECK(false) << "SSE support is not enabled";
   ^~~~~~
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘uint32_t arrow::SSE4_crc32_u16(uint32_t, uint16_t)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:141:3: error: ‘DCHECK’ was not declared in this scope
   DCHECK(false) << "SSE support is not enabled";
   ^~~~~~
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘uint32_t arrow::SSE4_crc32_u32(uint32_t, uint32_t)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:146:3: error: ‘DCHECK’ was not declared in this scope
   DCHECK(false) << "SSE support is not enabled";
   ^~~~~~
/root/repos/arrow/cpp/src/arrow/util/sse-util.h: In function ‘uint32_t arrow::SSE4_crc32_u64(uint32_t, uint64_t)’:
/root/repos/arrow/cpp/src/arrow/util/sse-util.h:151:3: error: ‘DCHECK’ was not declared in this scope
   DCHECK(false) << "SSE support is not enabled";

How could I get through this? Thanks!

Wow, I encountered the same problem on my Redhat 7.4 ppc64le environment.
I built arrow successfully on the same platform, but there seems to be an unwelcome update on the latest release of arrow, I guess.
Any comment, pls ?

@dreamryx are you also compiling on ppc64?

@nasica88 I'd first try removing the specifics DCHECK in the sse-util.h file.

Can you please open a JIRA issue? We need help from developers with access to ppc64le to be able to support it

@fsaintjacques @nasica88 @wesm  Sorry for replying late.  Yes.  I do compile it on ppc64le.  When I add
#include "logging.h"  into sse-util.h,   the compilation passed. : )

@fsaintjacques  As you recommended, commenting our all DCHECK lines from the sse-util.h file also worked.  Still, including "logging.h" as @dreamryx did looks much more graceful.

I've opened the following issue https://issues.apache.org/jira/browse/ARROW-5007 , this one can be closed.

I experienced the same problem on ARM A57 (Jetson Nano dev board).
Applying @dreamryx solution fixed it for me as well.

Hi @anthonyp2018 if you have additional information could you add it to the JIRA referenced above?  Thanks.


NIFI-4667 Fix LDAP Sync Interval

Corrects time unit conversion for the Sync Interval config property
for LdapUserGroupProvider in authorizers.xml.
Also enforces a minimum value of 10 secs for the Sync Interval to help
catch unintentional misconfigurations, for example users upgrading
from previous versions, where tiny Sync Interval values could be set
as a workaround for NIFI-4667.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Will review...

Thanks @kevdoran! I've merged this to master and I also amended your to include the updated documentation in the admin guide too.


Fix issue149

This pull request addresses issue #149 by making mu-'s white, mu+'s silver and adding background colour options for visualizations. Now RayTracer is also black as OGLS's default.

Neutrons are already grey, so they will look like mu+s? You could change the neutron colour to cyan or something to fix this. You should also update the README with the new colours.


Convert PPM measurements from OpenAQ data based on CAMS air density

Description
From the last call with the mentors, they are keen to include PPM values from OpenAQ. We want to store the data in µg/m³ so all units are the same. The problem is we need a value for air density from that location to do the conversion.
The approach to take for now will be to query CAMS and use their surface temperature + pressure values (as we do already for forecast data) and when units are PPM we convert. The cams data should be queried with the lat/longs of the measurement stations themselves (rather than the city lat/long) for the best approximation.
While this is not likely to be 100% accurate, it should mean that more data can be used.
Formula:
ppb = ppm * 1000

Weights
no2 = 46.01 g/mol
so2 = 64.07 g/mol
o3 = 48 g/mol
https://www.apis.ac.uk/unit-conversion
https://www.breeze-technologies.de/blog/air-pollution-how-to-convert-between-mgm3-µgm3-ppm-ppb/
Acceptance Criteria

PPM measurements from OpenAQ are converted to ug/m3 using data from CAMS

Make calls in parallel for both
CAMS data fetched is cached similarly to forecast etl process

The structure of each pollutant in each document changes from numeric value to nested document with fields "value" and new field 'original_unit' value of µg/m³ or ppm

Test Checklist:

[x] Test Analysis & discussion with developer
[x] Write Test Cases / Charters
[x] Test Cases & Charters Reviewed
[x] Test Cases Executed
[x] Test Charters Executed
[x] Regression tests executed
[ ] Automation Tests added to project

forecast_api_seeded_data_tests.py, forecast_api_validation_tests.py, cams_known_grib_test.py, forecast_calibration_tests.py & open_aq_etl_tests.py tests all passed.
Executed manual test cases, had to make some changes to test assertions, but expected behaviour was observed

Test Analysis:

Manual test required to essentially by hand get ppm data from a grib and check that the data in the database has the correct original value and converted value
Automated integration tests using a known grib that assert that the process doesn't get broken and known values are stored

Elements to verify:

check that we are not converting values that are already in ug/m3
check that we are converting values that are ppm
check that conversion is correct
check the document structure in database

Looking good, we already have some code snippets that may expedite the process too! 😎

We have an automated test that verifies the values µg/m³ generated from ppm values using a specified estimated_surface_pressure_pa and estimated_temperature_k
A manual verification is needed to ensure that the estimated_surface_pressure_pa and estimated_temperature_k are correct. They are generated by interpolating data from a given GRIB file, for a given latitude, longitude and time. See Manual testing of interpolating surface temperature and pressure values from CAMS data to use in converting OpenAQ ppm to µg m³ for details - test passed


fix: 避免因tenantcache未缓存tenant导致创建云账号失败

这个 PR 实现什么功能/修复什么问题:
避免因tenantcache未缓存tenant导致创建云账号失败
是否需要 backport 到之前的 release 分支:

release/2.13

/area region
/cc @swordqiu

Codecov Report

Merging #5038 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #5038      +/-   ##
=========================================
+ Coverage    6.76%   6.76%   +<.01%
=========================================
  Files         544     544
  Lines       95131   95129       -2
=========================================
  Hits         6433    6433
+ Misses      88160   88158       -2
  Partials      538     538

Flag
Coverage Δ

#aFlag
6.76% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/cloudaccounts.go
0.78% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb24c8...3d68e95. Read the comment docs.

/lgtm

/approve


Proposal: Allow md-slide-toggle to be aligned start or end

Proposal:
Allow md-slide-toggle to be aligned start or end.
What is the expected behavior?
To be able to allow the toggle element to come after the label visually.

What is the current behavior?
Currently the toggle element only positions on the left of the label.

What is the use-case or motivation for changing an existing behavior?
Enhancement to existing component to allow flexibility of display easily.
Which versions of Angular, Material, OS, browsers are affected?
Version: 2.0.0-beta.1

I think that's a pretty good idea. We should just respect the current direction (RTL | LTR). Do you think this is something useful @jelbourn ?

@DevVersion yeah, it should be the same API / behavior as md-checkbox.


Align GEDI_L3 to VEDA notebook guidelines

EPIC
#240
Description
The GEDI L3 Tutorial notebook should be reviewed using the this guidance and includes the following components:

Style
Rendering Information
Notebook Sections

Acceptance Criteria (Tasks):

[x] Style should be consistent with guidance provided
[x] Rendering information should be complete and accurate. If there is no author/date information available, consult MAAP leads @wildintellect @abarciauskas-bgse for guidance
[ ] Ensure notebooks include the recommended standard sections

Brian has gotten me in touch with Kathryn. Once we figure out the format for the raw cell/rendering information, I'll create a PR and this will be ready for review.

Will be creating a new PR soon - got feedback from Kathryn on HLS

PR: https://github.com/MAAP-Project/maap-documentation/pull/254

Merged


fix: Show error message when label and value are both empty in radio group widget's properties

User description
Description:
In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed.
Bug: In Radio button widget->In property pane->if the options section(label or value) is kept empty the required error message should be displayed
Before:

After resolving bug:

Summary by CodeRabbit

New Features

Enhanced the KeyValueComponent to include error validation and messaging for empty Name and Value fields.
Implemented styled components for better layout and error message display.

Bug Fixes

Improved error handling in the RadioGroupWidget to validate empty labels and values and display appropriate error messages.

PR Type
Bug fix, Enhancement

Description

Added error message handling for empty name and value fields in key-value pairs in the KeyValueComponent.
Introduced ErrorMessageBox styled component for displaying error messages.
Implemented validatePairs function to validate key-value pairs and set appropriate error messages.
Updated the component structure to include error message display below each key-value pair.

Changes walkthrough 📝
Relevant filesEnhancement

KeyValueComponent.tsxAdd validation and error messages for empty key-value pairs

app/client/src/components/propertyControls/KeyValueComponent.tsx
Added ErrorMessageBox styled component for error display.  Introduced validatePairs function to validate key-value pairs.  Updated component to display error messages for empty name or value fields.  Modified component structure to include error message display.

+66/-34

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@PrasadMadine
Thanks for creating this PR.
Please also look at this issue https://github.com/appsmithorg/appsmith/issues/34308 for our guidelines on contributions.
The error message doesn't look appropriate as the size and positioning of text don't match the context.

Here is a screenshot of the expected design.

Hello @riodeuno , Made the suggested UI changes, please review this PR.

Thankyou

Hello @riodeuno Could you please review this PR

We need to show errors as per the conventions.
New component is not needed here.

Hello @riodeuno
Could you please review this PR?
Thank you!

@PrasadMadine Please see the PR #35800. There are some typescript issues in the code that fails the build. I've discussed your PR with the team and we'll be merging your PR once all the tests pass.


Update US19JanTaxR1.md

updating 2021

Docs Build status updates of commit 1c58eb4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1c98383:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


In addition to articles, can you get information from e-commerce sites?

My questions:
In addition to articles, can you get information from e-commerce sites?
I want to get temu.com, amazon.com
Thank you

use web scraper tools like Scrapy


Adding FFMpeg Audio Visual Post Processor

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Bug fix
[x] Improvement
[ ] New extractor
[x] New feature

Description of your pull request and other information
This fixes the issue I created https://github.com/rg3/youtube-dl/issues/13360
This allows the creation of a post processor for ffmpeg that will convert both audio and video. Currently the audio part is pretty bare. I saw the audio extractor does a lot more but I was unsure what I should copy. This works for me converting to mkv for video and aac for audio. The post processor accepts the following three options
preferedvformat: string
preferedaformat: string
preferredquality: int
I am happy to add more for the audio but would need some guidance as I am still a novice when it comes to using ffmpeg and all of its options.

Looks like all builds are failing. I don't believe this should be affecting other tests. Any chance I can get a review?


lnd panic and refuses to start (failed sending fundingLocked: shutting down unable to send)

version 0.4.2-beta commit=bc5bfeb479d5123ad3c9cfc8bf9636bb1535802e
first got a panic:
2018-07-16 14:54:45.359 [INF] LTND: Payment received: (*channeldb.Invoice)(0xc425fcb5c0)({
 Memo: ([]uint8) (len=7 cap=7) {
  00000000  64 65 70 6f 73 69 74                              |deposit|
 },
 Receipt: ([]uint8) {
 },
 PaymentRequest: ([]uint8) (len=205 cap=205) {
  00000000  6c 6e 62 63 31 30 75 31  70 64 35 65 76 76 77 70  |lnbc10u1pd5evvwp|
  00000010  70 35 6e 6c 6a 65 72 63  32 75 65 63 68 61 36 6e  |p5nljerc2uecha6n|
  00000020  39 77 37 38 73 72 68 6b  36 70 79 6e 32 65 34 61  |9w78srhk6pyn2e4a|
  00000030  35 6b 68 39 61 37 39 34  6d 74 6e 79 6c 79 35 7a  |5kh9a794mtnyly5z|
  00000040  34 30 67 34 6d 71 64 71  76 76 33 6a 68 71 6d 6d  |40g4mqdqvv3jhqmm|
  00000050  6e 64 39 36 71 63 71 7a  79 73 78 71 7a 66 76 64  |nd96qcqzysxqzfvd|
  00000060  33 67 79 32 36 6c 66 6b  70 64 75 73 77 68 30 6c  |3gy26lfkpduswh0l|
  00000070  33 73 74 36 66 67 34 33  35 32 74 63 72 65 79 32  |3st6fg4352tcrey2|
  00000080  6e 35 35 78 68 78 32 33  34 73 61 34 6d 67 35 34  |n55xhx234sa4mg54|
  00000090  61 6d 6e 70 71 70 33 6d  74 34 77 76 6a 6e 78 34  |amnpqp3mt4wvjnx4|
  000000a0  37 70 76 30 65 68 78 65  38 74 6b 67 61 30 35 34  |7pv0ehxe8tkga054|
  000000b0  61 63 6d 73 35 33 77 6e  70 38 71 64 70 72 61 68  |acms53wnp8qdprah|
  000000c0  6b 66 6b 74 6d 63 71 78  35 77 6a 35 79           |kfktmcqx5wj5y|
 },
 CreationDate: (time.Time) 2018-07-16 14:54:06.258222648 +0000 UTC,
 SettleDate: (time.Time) 2018-07-16 14:54:45.340523419 +0000 UTC m=+293298.304054393,
 Terms: (channeldb.ContractTerm) {
  PaymentPreimage: ([32]uint8) (len=32 cap=32) {
   00000000  18 65 e2 4a 31 25 bb 44  8c 44 82 74 63 d5 2c c8  |.e.J1%.D.D.tc.,.|
   00000010  36 2a cf 06 be 0d e5 2e  a1 fd 20 f2 12 73 0e a1  |6*........ ..s..|
  },
  Value: (lnwire.MilliSatoshi) 1000000 mSAT,
  Settled: (bool) true
 },
 AddIndex: (uint64) 5010,
 SettleIndex: (uint64) 2526,
 AmtPaid: (lnwire.MilliSatoshi) 1000000 mSAT
})

2018-07-16 14:54:45.370 [INF] HSWC: ChannelLink(531305:1438:1) settling 9fe591e15cce2fdd4caef1e03bdb4124d59af696b97be2d76b993e4a0aaf4576 as exit hop
2018-07-16 14:54:45.558 [INF] HSWC: Sent 0 satoshis and received 1000 satoshis in the last 10 seconds (0.300000 tx/sec)
2018-07-16 14:54:46.675 [INF] DISC: Broadcasting batch of 6 new announcements
2018-07-16 14:55:01.642 [INF] CRTR: Updated vertex data for node=033bdb9bf6b4ee1aedc87252d7748ac040507089544eb6ba072bb2e17c0d616ed1
2018-07-16 14:55:05.550 [INF] HSWC: Sent 0 satoshis and received 0 satoshis in the last 10 seconds (0.100000 tx/sec)
2018-07-16 14:55:06.127 [WRN] HSWC: Accepting duplicate payment for hash=9fe591e15cce2fdd4caef1e03bdb4124d59af696b97be2d76b993e4a0aaf4576
2018-07-16 14:55:06.137 [INF] LTND: Payment received: (*channeldb.Invoice)(<nil>)
2018-07-16 14:55:06.139 [INF] HSWC: ChannelLink(531305:1438:1) settling 9fe591e15cce2fdd4caef1e03bdb4124d59af696b97be2d76b993e4a0aaf4576 as exit hop
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xb0 pc=0xc8551e]
                                                                                goroutine 1570 [running]:
main.(*invoiceRegistry).invoiceEventNotifier(0xc420a164d0)
        /home/lnd/gocode/src/github.com/lightningnetwork/lnd/invoiceregistry.go:147 +0xae
created by main.(*invoiceRegistry).Start
        /home/lnd/gocode/src/github.com/lightningnetwork/lnd/invoiceregistry.go:76 +0x5c

then it was issues sweeping when starting up:
2018-07-17 06:37:55.349 [ERR] UTXN: Failed to re-register for kindergarten sweep transaction at height=531727: -22: TX rejected: transaction 725e7b9ebf2a123586e7849e0fee604be0b89810280b57603f99e1dc8eb3c7f8 has insufficient priority (3839.404011461318 <= 5.76e+07)
2018-07-17 06:37:55.363 [ERR] FNDG: failed to handle fundingconfirmation: failed sending fundingLocked: shutting down unable to send
full log when trying to start
http://paste.ubuntu.com/p/wS6xd5sy2T/
Background
Describe your issue here.
Your environment

version of lnd
which operating system (uname -a on *Nix)
version of btcd, bitcoind, or other backend
any other relevant environment details

Steps to reproduce
Tell us how to reproduce this issue. Please provide stacktraces and links to code in question.
Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead

emergency-patched it like this to make it start
index ff190fa..14cdd39 100644
--- a/utxonursery.go
+++ b/utxonursery.go
@@ -741,7 +741,8 @@ func (u *utxoNursery) regraduateClass(classHeight uint32) error {
                        utxnLog.Errorf("Failed to re-register for kindergarten "+
                                "sweep transaction at height=%d: %v",
                                classHeight, err)
-                       return err
+//                       return err
+                       return nil;
                }
        }```

probably should have another patch though... doesn't feel good, but the node runs fine


[bug][NeoForge] java.lang.IllegalAccessError when joining new world

Mod Version (e.g. Fabric 0.3.4):
NeoForge 21.0.145
Architectury 13.0.6
Scriptor 1.2.7-1.21
What you expect to happen:
Can create and join a new world.
What actually happens:
Server crashes when attempting to join newly created world.
crash-2024-07-29_19.30.02-server.txt

Thanks for the report! A version is being built that resolves this issue, and should be available on Releases, Modrinth, and CurseForge shortly.


Error Loading Ontologies

I recently downloaded Phenex to start annotating beetle matrices with ontology terms.
When trying to use it, it starts loading until I get this message:
"An error occurred while loading ontologies: Load Error, line 39521"

When I press OK, the program finishes loading and opens the expected window. The problem is that certain functions are not working. For example, View> Config> Ontology Sources doesn't do anything.
I was able to open a NexML matrix. When trying to annotate a phenotype for a character state it doesn't even load UBERON terms.
Am I doing something wrong?

The cause is Phenex's brittle old OBO parser, and this problem in Uberon: https://github.com/obophenotype/uberon/issues/2373
I will try to find a workaround. Usually you can open Ontology Sources and set different ontology locations, even when a loading error occurs.

If you are able to open Ontology Sources, you can set the Uberon location to http://purl.obolibrary.org/obo/uberon/releases/2021-11-28/ext.obo to avoid this error for now.

@JCGiron, feel free to get in touch with me if you would like a quick demo of Phenex, or need further help getting Phenex started! my email is wdahdul @gmail.com

You may also need to set the OBO relations source to: http://purl.obolibrary.org/obo/ro/releases/2021-10-27/ro.obo

If you are able to open Ontology Sources, you can set the Uberon location to http://purl.obolibrary.org/obo/uberon/releases/2021-11-28/ext.obo to avoid this error for now.

That is the issue, Ontology Sources does not open any options.

The problem was that I had only downloaded the Source code, but not the app. I just downloaded the app file, unzipped it and double cklicked the file. Now the options under View seem to be working properly, even though the ontology loading error is still showing up.
Perhaps it would be helpful for others to make the installation instrutions more clear?


Metadata Not Being Saved for Updated Functions

Prerequisites

[X] I checked the documentation and found no answer to my problem
[X] I checked the existing issues and made sure there are no similar bug reports

Category
Bug in DeltaV
Expected Behavior
When updating the function details via the API, including metadata such as location details, the metadata should be saved and retrievable when querying the function details.
Observed Behavior
After updating a function's details (including metadata), the API returns a 200 response. However, when retrieving the function details, the metadata field is returned as None.
To Reproduce
No response
Environment Details (Optional)
No response
Failure Logs (Optional)
None available as the API response is a 200, but the expected metadata is not present.

Additional Information (Optional)
No response

Docs PR has been merged. The issue was metadata field needs to be called metadata_properties.
cc @zmezei


[Branding] Changed occurrences of 'Franz' to 'Ferdi'

Description
Lots of occurrences (especially debug tags) were still referring to 'Franz' - changed these to 'Ferdi'
Motivation and Context
Rebanding
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

@vraravam Just a heads-up, this commit caused my install to spit out Could not load services and user information (no relevant errors in the console or in stdout as far as I can tell) and to not load my config. I haven't had the time to dig further.

@dpeukert - I am running the commit in my local (macos) without any issues. Looking at the code where the error Could not load services is present, it might be related to some network issues. Please try again. Tx for merging the PR

@vraravam Strange, I'm running on Linux and was able to reproduce this on two different machines on two different networks. Downgrading to the previous commit also worked with no network changes. I'm not using the online account though, so that might be a factor.

@dpeukert - we reverted a part of this PR related to headers. This might have caused your issue as well. Could you please re-verify?

@vraravam Thanks for the heads-up, d3f5184 indeed fixed the problem.


[WIP] New library management

This fixes #135
This is an unstable branch with work being in progress, it does not need any review for now

This is an unstable branch with work being in progress, it does not need any review for now

So, are ANY comments forbidden? :laughing:

The only purpose of this PR is to force me to finish it haha. Just psychological stuff here.

Ok @YurySolovyov, I'd like your thoughts on this.
The only "important" things here, is to be able to import folders when the importer is already running. I already have some ideas how to do that, but I would like to see your ideas to see If I'm wrong or missing something. (basically, do you have any experiences with queues and promises?) Is there a magic-library or do we have to do everything ourselves?

Is there a magic-library or do we have to do everything ourselves?

I don't think there is a lib that would do everything for us, and IMO bluebird is already pretty good.
The thing here would be to define and implement updating with clearly separated steps.
Pseudo impl:
try {
  const pathsToScan = await getPathsToScan(...);
  const mediaFileCandidates = await getFilesByPath(pathsToScan, ...);
  const flatFilesArray = await flattenArrays(mediaFileCandidates, ...);
  const supportedMediaFiles = filterSupported(flatFilesArray, ...);
  doSomethingWithSupportedFiles();
} catch (e) {
  // handle e
}

Not ready for the prime time :)

Well of course it isn't haha.

The thing here would be to define and implement updating with clearly separated steps.

Nope it's not the thing here.
Imagine I add the first half of my library in Museeks, the scan begins.
Now, during the scan, I want to add the other folders of music.
We do not want a new process to be created, we should "merge" the file queue that is being processed, and the new files list.

I'm not sure what you mean by a separate process, it would be just another closure with its own context and everything.
The point about merging is valid though, needs a bit more thinking, but I'm sure it is possible to achieve what I described with simpler approach.

I'm not sure what you mean by a separate process, it would be just another closure with its own context and everything.

We could typically fall in another ERR_FILE_OPEN error because we're opening too many files at the same time.
I'll think a bit about a way to achieve this. This cannot be merged as long as It's not solved

One possible way to do it would be to have a queue based on plain promises and enqueuing new work with .then.
The downside would be that this queue would be global (not yet sure if it is too bad).
It would work like this:

Initially we'll have it either null of undefined.
When user adds a folder, we assign this variable the result of calling main function that returns promise
Code in a function will run as usual using limited concurrency
If/When user adds more folders, we queue them up into existing promise, so they wait.

The other way might be to have a global (again) pool of files/folders to be processed and have a way to pick items from that pool and process them with a limited concurrency.
With this approach we don't batch anything and every items goes though the entire pipeline individually,
and it might not even end up in a database, because of filtering.
This might be slower because of the database pressure, but this will allow items to be added from multiple folders simultaneously.
In both ways we might need to find a way to say when All folders are added, but not sure.
That's at least 2 ways I can think of ATM, there are might be more.

I will play with Queue this afternoon and see how I can deal with those concurrency problems, then I will remove the WIP.

We should be good @YurySolovyov, I will check those build errors but the overall thing is doing what it's supposed to.

Can't provide any better review ATM, will file an issue or PR if I find anything.


[FR] Mobile

Also, the plugin can be useful on mobile version. Unfortunately, the path is from node. Node is unsupported on mobile.
https://marcus.se.net/obsidian-plugin-docs/reference/typescript/functions/normalizePath#parameters exists on Obsidian native, so you can use it.

Btw, you could use directly TFile in needToRename, with for example, sourceFile so you can get ride of path.posix to use native TFile/TFabstract (.ext…)
Ex :
    const oldNote = this.app.vault.getAbstractFileByPath(oldPath) as TFile;
    // generate old note path and name
    const oldNotePath = oldNote?.path as string;
    const oldNoteExtension = oldNote?.extension as string;
    const oldNoteName = oldNote?.basename as string;
    ```

Also, if file doesn't exists, I have some little function to get for example, the basename :
```ts
const basename = (name: string) => /([^/\\.]*)(\..*)?$/.exec(name)[1];

I have replaced the nodejs path library with a build in path lib.


fix display of screenshots on packagecontrol.io

The packagecontrol.io TypeScript page displays the screenshots immediately after the description in the bullet point, not on a new line:

with the first image displaying directly after the text instead of having each image at a uniform place and size. The second bullet text and image display fine because the text is longer, causing the image to wrap. Both lines display correctly on Github. This is because Github-flavored Markdown interprets a single newline in the .md source as a <p> in the HTML, whereas the original Markdown processor and derivatives require two newlines for a <p>. I haven't looked through wbond's source for page rendering, but it appears he doesn't have full GFM compliancy turned on.
At any rate, to make a short story long, I added newlines after each bullet point, so everything should line up nicely now both on Github and packagecontrol.io.

Hi @MattDMo, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks @MattDMo!


[SPARK-31558][UI] Code clean up in spark-sql-viz.js

What changes were proposed in this pull request?

Remove console.log(), which seems unnecessary in the releases.
Replace the double equals to triple equals
Reuse jquery selector.

Why are the changes needed?

For better code quality.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests + manual test.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26465/
Test PASSed.

Test build #121789 has started for PR 28333 at commit 2abcef1.

Test build #121789 has finished for PR 28333 at commit 2abcef1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121789/
Test PASSed.

Merging to master/3.0

+1, late LGTM.


Disable "Quit game" button to prevent unsaved world

A simple suggestion to avoid quitting the game too quickly with the "Quit game" button without giving it time to properly finish saving the world.
Maybe with a tooltip message "The world is not currently saved" when hovering with cursor.

Not sure how useful that would be tbh, since if you do quit it will just wait for the world to save anyway?

Quitting the game while the world is not saved will interrupt the process and potentially corrupt it. Like Alt+F4 the window during the saving process.

That is not the case, when you close the game (tested with Alt+F4, quit button, window X and crash) the mod has a failsave implemented and will wait for the saving world to finish before closing Minecraft

Indeed, I had not succeeded in triggering this process on the first try. So I close my exit :D. Excellent mod!


Failing gracefully on exception from controller construction

When a constructor of an HttpController throws, and the exception propagates through drogon::app().run() to main() and is caught there, it appears impossible to exit the program gracefully, since the assert on trantor/net/EventLoop.cc:115 in EventLoop::~Eventloop() triggers on exit. Looking at the source code, it appears that there is no easy workaround, since looping_ in the trantor event loop is not handled exception safely.
My use case for throwing in the constructor of a controller is that there are some settings (currently loaded from config.json) which, if misconfigured, may prevent the service from doing its work at all. In that case, I believe it's better for the service to exit on startup and let the admin know to fix the configuration, rather than running a non-functional service.
There should be a way to exit gracefully when exceptions are thrown in controller constructors.

This is probably related to https://github.com/an-tao/trantor/pull/198

@rbugajewski I think you're right. If I understood the code in https://github.com/an-tao/trantor/pull/198 correctly, that pull request would actually change the assert failure in to a hang in EventLoop::~EventLoop(), which is obviously even worse.
I think a minimal change to make this  work in Trantor would be to use a scope guard (for example, https://github.com/ricab/scope_guard seems reasonable, though I haven't tried it myself) to set _looping to false when the EventLoop::looping() scope is exited via any path.

PR 224 in trantor implements a partial fix (changes hang to exit via assert).


Improvements to BlockLinkCard and BlockLinkTile

Checklist

[x] Include a description of your pull request and instructions for the reviewer to verify your work.
[x] Link to the issue if this PR is issue-specific.
[x] Create/update the corresponding story if this includes a UI component.
[x] Create/update documentation. If not included, tell us why.
[x] List the environments / browsers in which you tested your changes.
[x] Tests, linting, or other required checks are passing.
[x] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".

[x] PR has been tagged with a SemVer label and a general category label, or skip-changelog.

These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description
Closes #58. Adds the following features to BlockLinkCard and BlockLinkTile templates and stories:

compact styles (boolean)
headingLevel
secondaryLabel

Also restores the hover effect on the image in BlockLinkCard, which was missing!
Migration / Release notes
Improvements have been made to BlockLinkCard and BlockLinkTile, including compact styles, and styles for a secondary label. Update your HTML templates as needed.
Instructions to test

npm run storybook
Check the BlockLinkCard and BlockLinkTile stories to try out the new features.

Tested in the following environments/browsers:
Operating System

[x] macOS
[ ] iOS
[ ] iPadOS
[ ] Windows

Browser

[x] Chrome
[x] Firefox ESR
[ ] Firefox
[x] Safari
[ ] Edge

I think this is good, but is it expected that on BlockLinkTile, turning on "Compact" mode actually makes it taller? (Because of the switch to a 1:1 aspect ratio.)

Yeah, I wasn't quite sure how to handle this. Compact is a bit of a misnomer, but the 1:1 ratio is intentional.


fix(plugin): overriding colorschemes

Commit 8ce0832a5c409644fa06f34337b74f11aaa871c7 via #972 broke my colorscheme and other colorschemes which provide nvim-cmp highlights (e.g. linking CmpItemKindText to Text doesn't work). Plugins in general should definitely use default = true to maintain compatability with colorschemes, otherwise they will clobber the groups set by the colorscheme (which is what is happening now).
I looked at #972, and it seems like that issue can be fixed by delaying the setup of highlight groups until they are first needed (e.g. when rendering the popup menu), which would give that user time to setup their highlight groups and still adhere to default = true. It seems setting everything up in plugin/cmp.lua doesn't guarantee the user's colorscheme is fully configured.

@Iron-E I want to check your colorscheme definition. If you orverride Cmp*Default colors. I think it's wrong. You should use Cmp* colors.

Thanks for following up @hrsh7th. I have been using the CmpDefault groups, for two reasons:

Currently each Cmp*Default group only has one inheritor (e.g. CmpItemKindVariable to CmpItemKindVariableDefault), however in the case that more are added in the future (e.g. hi def link CmpItemKindIdentifier CmpItemKindVariableDefault) I wanted the definitions to be forward-compatible
Other plugins or configurations may (potentially by mistake, as you mentioned) reference the Cmp*Default groups when deriving their own highlight groups, rather than the equivalent Cmp* highlight group (e.g. hi def link MyGroup CmpItemKindVariableDefault) which would cause mishighlighting. Defining the default groups in my colorscheme prevents any issues like this from ever arising

Admittedly this may be an unintended use of these highlight groups, although I think these are good reasons to prefer providing definitions for those groups (i.e. forward-compatibility, preventing a certain class of bug for users of my colorscheme)

The CmpItemKind%KIND_NAME% highlight definition is already care about your intention.
The inheritance is the following so I don't think you don't worry about forward-compatible.
CmpItemKind%KIND_NAME% -> CmpItemKind -> CmpItemKindDefault
The colorscheme can override CmpItemKind directly then CmpItemKind%KIND_NAME% will be followed.
We shouldn't care about second point. I think should fix the wrong definition.

Alright, good enough for me.


Add upstream proxy protocol and increase default connection limits

Changes:

Forces the use of upstream proxy protocol v2.
Disables some tests that were failing due to this change rather than updating a bunch of test input files/output files.
Increases the connection limits per cluster (defaults are 1024). I arbitrarily picked 32000 for max connections and max pending requests. Docs on these values can be found here. Note this is applied per cluster in envoy which basically mean per tenant. So if we run 3 replicas per region each tenant could theoretically have ~96000 connections per region.

Why are we skipping the existing tests instead of extending them to cover the new functionality? Seems like we want coverage here, and eventually, the ability to upstream?

@sclevine Take a look at the latest commits, I left some tests skipped but kept in tls route specific tests. This gives us coverage for our use case for the time being but avoids potentially having a lot of conflicts with upstream.


Low Volume

As seen on the xda forum....
Low Volume can be fixed by:
adb shell service call audio 10 i32 3 i32 15

Fixed with https://github.com/mt8695/android_device_amazon_sheldon/commit/decf41470f869ab51e48a2e29b982ab862d448a1.


unReadonly API proposal

What problem does this feature solve?
Unreadeonly API unpacks the readonly object. Return value of API is the copy / deepClone object of source object.
when export a store witch readonly wrap up, due to the exported store type is DeepReadonly, any other variable receiving its value also needs to be declared as Readonly type, which will make it impossible to modify other variables receiving its data value, Readonly types are contagious like a plague and cannot be blocked
What does the proposed API look like?
Type:
function unReadonly<T>(ref: T | DeepReadonly<T> | Readonly<T>): T

Example:
function useFooCopy(Foo: number | Readonly<number>) {
  const FooCopy: number = unReadonly(Foo)
  return FooCopy
}

there are lots of choices out there to make a deep copy of an object, including lodash.
Doing a proper deep clone while supporting all edge cases has a certain complexity to it, so I don't think we should move such a feature into core if there are well-tested, widely used alternatives out there.

@LinusBorg
I agree that.
But when make a deep copy of an readonly object, we still can't modify the new Obj cause the new Obj's type still Readonly.
This means that a read-write object cannot be created from a read-only object.
we need a unReadonly feature, not deepCopy feature.That's what I'm talking about.Just make an example, deep copy is only one of the paths to realize this feature.


Release Template-V2

Fix https://jira.corp.adobe.com/browse/MWPW-133170
Release wiki: https://wiki.corp.adobe.com/display/adobedotcom/Templates+v2+Release
All code changes should be backward-compatible. Namely, after code merged, old content should still display fine
Samples of potentially impacted pages to be verified:

https://www.adobe.com/express/templates/
https://www.adobe.com/express/templates/flyer/christmas
https://www.adobe.com/express/templates/search?tasks=banner&phformat=2:3&topics=hello&q=hello
https://www.adobe.com/express/templates/create/flyer
https://www.adobe.com/fr/express/
https://www.adobe.com/express/learn/students

Test URLs:

Before: https://main--express-website--adobe.hlx.live/express/templates/flyer/christmas?lighthouse=on
After: https://stage--express-website--adobe.hlx.page/express/templates/flyer/christmas?lighthouse=on

Switching back and forth between the filter for oldest to newest and newest to oldest is showing some of the same results at the top. That seems completely wrong to me
https://github.com/adobe/express-website/assets/115231412/e75aa68e-c8ca-4cbf-837a-c633465f6005

On mobile there probably shouldn't be a large space between the search field and content below

We shouldn't have default options that return nothing in the list. Additionally, the page title is not set here
Screen.Recording.2023-06-26.at.10.00.24.mov

This search suggestion list is likely not done being authored yet. And, If a templates/ link returns an empty page with no title like that, it's because the metadata sheet doesn't have a row for it. In prod environment, this type of pages will be properly handled and actually redirect to express/templates root page.

ok, if you're sure then we're good 👍


[NWPS-1849] Domain redirect support for requests with POST method

Things to validate before approving this PR:

Rules described in /content/urlrewriter/medical/specialtytrainingtomedicaltrainingredirects seem to be using temporary-redirect on prod, whereas the ones described in repo https://github.com/Health-Education-England/hee-cms-platform/blob/master/repository-data/application/src/main/resources/hcm-content/content/urlrewriter/medical/specialtytrainingtomedicaltrainingredirects.yaml seem to be using permanent-redirect. Is that intentional ?
The property hst:nochannelinfo on /hst:hee/hst:hosts/prd-live-redirect/uk/nhs/hee/specialtytraining/hst:root seems to have been set to true on prod, whereas the one in repo https://github.com/Health-Education-England/hee-cms-platform/blob/7391bf735ac91ec94b49f3a9ecdae8bda4ab3bb5/repository-data/site/src/main/resources/hcm-config/hst/hosts/prd-live-redirect/uk.yaml#L29 doesn't seem to have the property. Is that intentional ?

Thanks!

@sankar-shunmuga - As discussed, have sync'ed /content/urlrewriter/medical/specialtytrainingtomedicaltrainingredirects and /hst:hee/hst:hosts/prd-live-redirect/uk/nhs/hee/specialtytraining/hst:root based on prod content, thanks


The Js Fiddle Example for the Date Selector does not work

The JsFiddle Example here http://jsfiddle.net/NfPcH/23/ included in the documentation for the datetime picker does not work

That is because it is out of date.
@eugef do you know how to update the fiddle?

@ckosloski no, could you create a new fiddle and update link in the readme?

OK, I'll work on that for my next pull request.

This can be closed, the fiddle was updated in #583


Add a new tsconfig.json file to a folder doesn't get picked up by project search

It should :rose:

released 0.1.12 :rose:


Ian's changes

@Sean-BREI @sharissis-brei
Please review my changes at your own pace. Add comments next to the lines in the commits, or post them here in the thread.
If you're fine with my changes, please approve the review.
Thanks.

Looks good to me!

Approve the pull request then!!

There's no "Approve" button, only "Close and comment". Didn't seem like the same thing.

@sharissis-brei https://help.github.com/articles/approving-a-pull-request-with-required-reviews/

👀

🙏
🙌


pass down id properly in CapturedContext

In my last PR I introduced a bug. Upon further testing in User Account context I noticed I didn't pass the id properly.

Need to test it a bit more


[CWS] drop writes with no files attached sooner in the pipeline

What does this PR do?
We currently receive a lot of writes event that we cannot map to a given filename. As such those events are not usable in the downstream pipeline, so this PR drops them as early as possible freeing some CPU cycles and some space in the ETW notification channel.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


updater-contributors: Adding entries to the package.json "contributors" property.

This would be really handy for quickly adding people who contributed to the project, which encourages better citation for them I think.  By creating entries in the "contributors" property in the package.json, and perhaps managing a AUTHORS file, or some other citation method.
It would be cool if it could somehow scan the git commits for the authors as well? Not sure if something like that obtainable with this module alone, might need some deps.
Also, following All Contributors would be interesting as well (pretty much just discovered this on my home page).

Ohh, I see update-contributors is a module.  :smile:

Thanks for pointing out update-contributors. That's one that I did before we settled on some of the conventions (like naming) for updaters. I'm more than happy to turn that into a general use module that's used in a new updater-contributors module for update.
If you'd like to create that updater-contributors module and/or do a PR to update-contributors, I'll take a look at them.

If you'd like to create that updater-contributors module and/or do a PR to update-contributors, I'll take a look at them.

I created this module last week (sorry I mentioned this @doowb I think he forgot). I'll push it up in a few min and if you want I can add you to the repo so you can change it to whatever you need.

Sounds good.  :+1:

going to close this one so we can carry on the conversation on update/updater-contributors. (we can easily add tasks to the updater to do any or all of the things you mentioned in this issue @jamen) thanks for bringing this up

oh, @jamen I added you to update/updater-contributors, you should have received an invite.

also added you as an owner on npm just now

Thanks, got it.  :smile:


Supervise projection::Actors

If this kind of actor dies and is never restarted, we are royally screwed.

Motivated by encountering a bug with https://github.com/itchysats/itchysats/pull/2742 which completely killed the projection actor.

bors r+


Update CXCardContainerView.m

The method "touchesCancelled:" was not implemented and was causing some bugs.

@jchomali , Thx!


Unescape pathname from url when loading from local filesystem

When a path contains a space it will be escaped to ’%20’. When loading from local filesystem it has to be converted back to a space to get the correct path.

Thanks for your PR! I'm sorry it took me so long to review it. I'll merge it and let you know when I released a new version containing your fix!

I've just released version 1.6.3 which includes your fix!


Document common load balancer configuration

We should include basic config files and setup instructions for common load balancer setups starting with HAProxy, Nginx, and maybe ELB.

@gunnaraasen , i just go thought the solution you provided like HAProxy,Nginx,ELB, seems all of them doesnot support UDP forward.
for influxdb-relay, there is UDP protocal support right?
Do you have any idea on this point?

@zhiwzhao The purpose of the load balancer is to separate /query vs /write HTTP  requests. Since you cannot perform queries over UDP there is no need to load balance the UDP traffic. Configure the sources of the UDP traffic to send their data directly to the relay.

@zhiwzhao As of March 2016, Nginx [announced] (https://www.nginx.com/blog/announcing-udp-load-balancing/) support for UDP load balancing.

@nathanielc ,the solution you provided can work, but seems not perfect. we need to config source influxdb host and port in load balance and we also need config the relay host in load balance.
but seems there is no good way to do it without your solution.
i write a load balancer with nodejs and support all of /query, /write, http, udp. functions can work but lots of enhancement need to do. maybe need to adopt your solution.
@adithyabenny , the feature of nginx is not free, i thing. please check.

@zhiwzhao It's available in the free version as well, I'm using it.
The module required for TCP/UDP load balancing is not compiled in the default version of Nginx. You'll need to either compile from source using --with-stream or use the [mainline] (http://nginx.org/en/linux_packages.html) version.

great,do you have guidance to use it? i would have a try the solution

@zhiwzhao - [Here] (https://gist.github.com/adithyabenny/1b7751b7190f0727decb7f2f5588ff18) you go

@adithyabenny  thank you very much! i am already adopt nginx. now my consider is how to improve the performance of nginx ,as my test, the average time cost to write to nginx is more than direct to write to influxdb.

If you're using Relay and UDP, you can simply send UDP traffic to Relay directly, and then point Chronograf/Grafana directly at InfluxDB's HTTP(S) API for queries. There's no need for a load balancer at all, really.

ELB doesn't do path / route based load balancing, however the newfangled AWS Application Load balancer could come to the rescue. I have not tested this yet, will update if I find this approach useful.

I am trying to setup influxdb-relay in Google's GCP, but since influxdb-relay changed from a 200 to a 204 status code for healthcheck, it makes them incompatible. Googles load balancers require a 200 return and are not configurable for other status codes. influxdb-relay is not configurable to return a normal 200 status code.

@gamerscomplete i was going through the source myself... heres the unified diff:

@ishworgurung Just curious, what do you see as requiring fixing? Found any operational issues?


[prim_assert] Add static assertion macro for checks in pkgs

@tjaychen this can be used for the MUBI check also (instead of having to stick it into a module...).


GATING - open an issue on proper citation of data sources longer term

This is still an issue that we need to figure out going forward. There is an opportunity to automate this, but it's still ongoing until we have an answer.


koordlet: fix log error

Ⅰ. Describe what this PR does
fix some log format errors
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm


Incorrect nocapture attribute for modify accessor, causing miscompilation (runtime crash)

Description
We experienced a runtime crash attributed to a hoisted load for utf8ToString in the SwiftProtobuf library. Initially suspecting a loop optimizer issue, I reported it here: LLVM Project Issue #93110. Based on the feedback, it seems that $ss7UnicodeO4UTF8O13ForwardParserVs10_UTFParserssAGP7_buffers11_UIntBufferVy8Encoding_8CodeUnitQZGvMTW returns a nocapture pointer. This is demangled as protocol witness for Swift._UTFParser._buffer.modify : Swift._UIntBuffer<A.Encoding.CodeUnit> in conformance Swift.Unicode.UTF8.ForwardParser : Swift._UTFParser in Swift.
The relevant code can be found in the Swift repository: UTF8.swift Code.
Reproduction
To isolate the issue, I used the following simplified code snippet and generated similar problematic code:
public struct ForwardParser: Sendable {
  public var _buffer: _UIntBuffer<UInt8>
}

Command used:
$ swift-frontend -emit-ir repro.swift -o -

Generated IR snippet:
...
; Function Attrs: noinline
define swiftcc { ptr, ptr } @"$s5repro13ForwardParserV7_buffers11_UIntBufferVys5UInt8VGvM"(ptr noalias dereferenceable(32) %0, ptr nocapture swiftself dereferenceable(5) %1) #2 {
entry:
  %._buffer = getelementptr inbounds %T5repro13ForwardParserV, ptr %1, i32 0, i32 0
  %2 = insertvalue { ptr, ptr } poison, ptr @"$s5repro13ForwardParserV7_buffers11_UIntBufferVys5UInt8VGvM.resume.0", 0
  %3 = insertvalue { ptr, ptr } %2, ptr %._buffer, 1
  ret { ptr, ptr } %3
}

Stack dump
Can't provide a runtime crash trace on our app.

Expected behavior
The nocapture attribute on the passed argument %1 seems to be violated as it is saved to a struct and returned in %3, contradicting the nocapture semantics detailed here: LLVM Pointer Capture.
In the original issue reported LLVM Project Issue #93110, the problem likely occurs at the call site in the caller due to aggressive loop optimization, which misinterprets the nocapture attribute, leading to incorrect load hoisting.
It seems we may reconsider the nocapture annotation for the first property of the modify accessor, as its address might be aliased with the passed this pointer.
Environment
$ swift --version
Swift version 6.0-dev (LLVM e4f0051da337219, Swift c0af25c0699f886)
Target: x86_64-apple-macosx14.0
Additional information
No response

CC: @drexin @aschwaighofer

Ah, interesting. Yes, the nocapture attribute is not valid after Coro splitting. Coro splitting will take values "live across" a suspension point and store it into the coroutine frame. Coro splitting will split functions at suspension point into multiple functions. If the original parameter value is "live" in the second function it pass spilled to the coroutine frame and the attribute is no longer valid.
LLVM's Coro splitting pass should remove the attribute.

In both splitAsyncCoroutine and splitRetconCoroutine we should iterate over the function's parameter attributes and remove the nocapture attribute.
https://github.com/llvm/llvm-project/blob/799316ff26cc82d60f276dc62c4a69b5bba1aef3/llvm/lib/Transforms/Coroutines/CoroSplit.cpp#L1677
https://github.com/llvm/llvm-project/blob/799316ff26cc82d60f276dc62c4a69b5bba1aef3/llvm/lib/Transforms/Coroutines/CoroSplit.cpp#L1772

I'm not familiar with this pass. Do you think we should conservatively remove the nocapture attribute from each parameter? I believe we also need to update the attributes of the arguments in the call instructions to these functions. Since this is a function pass, it seems we might require a module pass although we could simply update the users (call instructions) of the functions in place.


Atom appears to open past monitor. JRE 8u112 update

Prerequisites
Checked, nothing related.
Description
I just updated to JRE 8u112, and Atom fails to open, the window looks to opening past my current screens, the atom window is visible as it expands to fill the screen, but carries on beyond the furthest right monitor.
Uninstalled and reinstalled, updated to latest atom.
System:
Windows 7 Pro
AMD FirePro W4300
2x Monitors
Steps to Reproduce

Installed JRE 8u112
Open Atom
Looked confused

Expected behavior
Opens to a current monitor
Actual behavior
Opens beyond furthest right monitor
Versions
Atom 1.11.2 - version that I was using
Atom 1.12.3 - version I am updated too after problem started.
JRE 8u102 - version that I was using
JRE 8u112 - update

As Atom does not depend on Java in any way, shape, or form, this does not have to do with your Java update but rather something else.  I don't even have Java installed at the moment.  Did you by any chance have an external monitor connected sometime before you updated Java?

Checked, nothing related.

What happened when you ran Atom in safe mode?

Still did the same thing. Moved off screen.
Just started atom, and it was still showing off screen. Hovered over the task bar icon, right clicked on the popup and choose Maximise, and it came back into view.
So I will close this, and hope this will help someone in the future.


Add MapBox Dark to useMapStyle

I would like to contribute by adding the dark map for those who have a MapBox key. Changes follow.
useMapStyles.js
    {
      id: 'mapboxStreetsDark',
      title: t('mapMapboxStreetsDark'),
      style: styleCustom({
        tiles: [`https://api.mapbox.com/styles/v1/mapbox/dark-v11/tiles/{z}/{x}/{y}?access_token=${mapboxAccessToken}`],
        maxZoom: 22,
      }),
      available: !!mapboxAccessToken,
      attribute: 'mapboxAccessToken',
    }

en.json
"mapMapboxStreetsDark": "Mapbox Streets Dark",

Do you want to send a PR?

Yes Anton, I will do it now. Thanks!


Can not resize vertically

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
I can't resize the query window vertically, is there any option for that? Previously I could see the query without scrolling, but now there is an empty space instead
.bru file to reproduce the bug
No response
Screenshots/Live demo link

Now resolved as of latest version(v1.25.0), textbox resizes to fit fill QueryPane correctly:

proper scroll bars, and resizes to fit window

Closing this issue is completed. Thank you, @IvanMoscovic, for taking the time to report this bug and for providing the helpful attached images. Also, thank you, @vayalildanie, for confirming this and all the other issues.


Invoking a python lambda via SAM results in timeout when Sentry lambda layer is referenced

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.9.3
Steps to Reproduce

Add Sentry layer to the cloudformation within a python SAM application
Invoke the lambda via sam invoke local

I have created a sample repo that is purely just the output of the sam init generator with the Sentry lambda layer added to the cloudformation to easily reproduce.
https://github.com/neville1355/sam-app-with-sentry-example
Expected Result
Lambda should execute normally
Actual Result
The lambda always times out no matter what

Note that the lambda doesn't timeout in AWS. It only times out when running via sam local invoke which is used for development purposes only.
This is a blocker for us fully adopting Sentry as we can't locally run our lambda code while the lambda layer is being referenced.

Hey @neville1355 !
Better late than never. I just ran your repro function with sam locally and it did hang.
The thing is that the template references arn:aws:lambda:us-east-1:943013980633:layer:SentryPythonServerlessSDK:33 (Sentry layer version 33).
If I update the later to the latest one (arn:aws:lambda:us-east-1:943013980633:layer:SentryPythonServerlessSDK:80) everything works as excepted.
FYI (or anyone that finds this issue): You can update the the used Sentry layer version of you Lambda functions by going to Sentry.io > Settings > Integrations > AWS Lambda and hit the "Update" button in the UI. See https://docs.sentry.io/product/integrations/cloud-monitoring/aws-lambda/#configure how this looks like.
As this issue has been resolved, I am closing it.


RFC: Remix Support

Summary
Official request for Remix support.
Proposed Solution
In theory Next.js API Routes are analogous to Resource Routes and Service Side Props to Loaders so a lot of the concepts already present should translate.

Hey,
That's a great suggestion 🙌 , I do think with Remix moving to vite this could become pretty convenient as we have already explored vite in #79. We can use import.meta.glob to add the schema-types declared in the types/ directory and create a way to initialise the resource route.
The exploration after that would be how it look on the client-side, I personally don't have too much experience with Remix so I'm going to have to do some reading at first before I can participate in discussing how this API surface looks.
For generating the client-side types I reckon that we can hook into the vite plugin lifecycle to boot the code-generator.

Yup, Remix moving to vite is a massive enabler for automatic generation (and also other non-remix projects). I've been using this vite graphql codegen plugin with Pothos in a side project and it works pretty well. So would love to drop all that glue for an opinionated solution! As a bonus, Remix is considering RSC so should align on that goal eventually too.


Bitrise logo

SVG: https://dl.dropboxusercontent.com/u/11377305/tmp/bitrise_logo_bg.svg

SVG with description: https://dl.dropboxusercontent.com/u/11377305/tmp/bitrise_logo_transparent.svg

Thanks :+1:

Nice!
Added 2edbd5fe52f7a4f640bcce979aa52e5856bc6656


docs: last major portion of guide updates

Mainly:

env vars guide
apify platform guide.

Would appreciate a feedback on both. For env vars - that I did not mess up anything in CRAWLEE_/APIFY_ part. For platform - I tried to make sure all previous platform related content is there (and not in the other guide). But still - order,  maybe I missed something etc.
There are several smaller things I need to take care for other guides (some examples, update gifs, you -> we), but I would probably do it in next PR and probably after API docs check as it's really non-important stuff I'd say and it's just a very few places.
Few random things I noticed while checking the examples etc:

APIFY_ vs CRAWLEE_ env vars -> if I set process.env.CRAWLEE_LOG_LEVEL locally to DEBUG - it would not show debug messages. With log.setLevel(log.LEVELS.DEBUG); it works. Is it expected to be this way?
If I am logged out of APIFY account locally and create a configuration with const sdk = new Actor({ token: 'xxx' }) with proper token and then try to sdk.createProxyConfiguration() it would fail - am I doing something wrong or is it a bug? I would expect that creating an instance while explicitly providing the token should then work with proxy (and maybe other places where the token is used).

Or I could actually quickly fix the last things I mentioned above during/after the review (as it's really just a very few places).

Re CRAWLEE_LOG_LEVEL - created https://github.com/apify/apify-ts/issues/171 not to forget.
As for the token/configuration: did not try it with v2 (and I doubt many people were using it without logging in to apify) as it was kinda intuitive to install Apify and be logged in, but I guess it would fail too (will check in a sec). With v3:
import { Actor } from 'apify';

const sdk = new Actor({ token: 'xxxxxx' });
const proxyConfiguration = await sdk.createProxyConfiguration();

fails with Error: Apify Proxy password must be provided using options.password or the "APIFY_PROXY_PASSWORD" environment variable. If you add the "APIFY_TOKEN" environment variable, the password will be automatically inferred
Starting with npm start.

Actually - with v2 it works as expected:
const { Apify } = require('apify');

const sdk = new Apify({ token: 'xxxxxx' });

sdk.main(async () => {
    const proxyConfiguration = await sdk.createProxyConfiguration({ groups: ['SHADER'] });
    console.log(proxyConfiguration.newUrl());
});

It correctly logs my proxy password and creates proxyUrl, while if I would not provide the token - it also fails. Also starting it with npm start.
I thought that the problem with v3 was that I don't do Actor.init(). Tried to add it, but it still fails.

@B4nan So - besides the review/comments:

need to update the links in apify_platform guide to the new repo (could do within this PR after actor SDK is moved there or separately later)
avoid_blocking guide - I guess will update after https://github.com/apify/apify-ts/pull/169 is merged. Wanna add an example for puppeteer (which would basically be the same as playwright, so super fast to do) + would change the text and mention that fingerprints are enabled by default, how to disable + keep the details about fingerprintGeneratorOptions, but this part would also be fast.
quick_start - wanted to update/add new gifs here (for cheerio/playwright/puppeteer). The question is - what's the top file size we want there? Currently we have a gif with ~900kb, 705x529 resolution there, ~10 sec duration. I tried to create one and it's either also a bit blurry, or becomes quite heavy. Should I take care of it or should I just keep the current gif and ditch playwright/cheerio?

Otherwise waiting for commments. Tomorrow will go through the API docs.

Please address the feedback in another PR, I need to merge this now as the website is live and the PR will only make things better even if incomplete :]


allow to run --collect-only without setting up databases

I'm using django_nose v1.4.3 in my project and so I made the change based from that tag
but it looks like it'll still apply cleanly against master

Coverage decreased (-0.06%) to 68.263% when pulling cbdff779a06244932a3005f76b4fe63a64d8ead8 on depop:feature/collect-only-1.4.3 into 3b9dad77d0440cace471aa43d77a4ba619f145bb on django-nose:master.