BUG: Fix VTK build using vtkExternalModuleMacros

Hi Bill,
This PR fixes the build broken when using VTK >= kitware/VTK@061eff0, it basically improves and simplifies the build system to use vtkExternalModuleMacros.
For more details, see https://gitlab.kitware.com/vtk/vtk/merge_requests/3451

BUG: Fix VTK build using vtkExternalModuleMacros
This commit fixes the build VTKWikiExamples as remote module broken
following the introduction of kitware/VTK@e33b90d (ExternalModule:
Improve target export to allow build against external module).
To ensure module information are exported into VTK_MODULES_DIR, use
vtk_module_export_info instead of vtk_module_impl.
To ensure that variables like VTK_LIBRARIES are set in the current scope
when the project is build as remote module or as standalone project, we
now use vtk_module_config.
For the remote module case, by
(1) removing:

the code checking if VTKConfig.cmake exists
the use of VTK_USE_FILE
the use of find_package

and
(2) using both vtk_module_export_info and vtk_module_config, we ensure
the first and follow-up configurations behave identically.

Thanks
Jc

Did you try building the VTKExamples stand-alone.
It is broken, I get:
-- VTKWikiExamples: Building VTKWikiExamples stand-alone
-- VTKWikiExamples: Building VTKWikiExamples stand-alone - yes
CMake Error at /Users/lorensen/ProjectsGIT/VTK/CMake/vtkModuleAPI.cmake:138 (message):
Requested modules not available:
WikiExamples

Call Stack (most recent call first):
/Users/lorensen/ProjectsGIT/VTK-clang/VTKConfig.cmake:127 (vtk_module_config)
CMakeLists.txt:16 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/lorensen/ProjectsGIT/VTKExamples/build/CMakeFiles/CMakeOutput.log".

Thanks for the feedback. I will ping you when it is ready. I still need to
publish a VTK topic too.
Jc
On Oct 19, 2017 6:46 PM, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

Did you try building the VTKExamples stand-alone.
It is broken, I get:
-- VTKWikiExamples: Building VTKWikiExamples stand-alone
-- VTKWikiExamples: Building VTKWikiExamples stand-alone - yes
CMake Error at /Users/lorensen/ProjectsGIT/VTK/CMake/vtkModuleAPI.cmake:138
(message):
Requested modules not available:
WikiExamples
Call Stack (most recent call first):
/Users/lorensen/ProjectsGIT/VTK-clang/VTKConfig.cmake:127
(vtk_module_config)
CMakeLists.txt:16 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/lorensen/ProjectsGIT/VTKExamples/build/CMakeFiles/
CMakeOutput.log".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338058867,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANXo0bjLY6fxzr6Xo5-Pw3Fyxl7fVL6ks5st9FGgaJpZM4P_37Y
.

I did  git bisect on the VTK build ND It looks like this commit by Brad
broke the examples config.
commit d7c5b388e9b894847a7a44207e2f4c72ff057c7b (refs/bisect/bad)
Merge: c4a3e2813f a8d1545ef8
Author: Brad King<EMAIL_ADDRESS>Date:   Wed Oct 18 11:33:06 2017 -0400
Merge topic 'developer-setup'

a8d1545e Merge branch 'upstream-GitSetup' into developer-setup

5cb9a477 GitSetup 2017-09-21 (e0a28f26)

3a0abe7b Revise GitSetup update script to get only files we need

94ffbc97 Merge branch 'upstream-GitSetup' into developer-setup

18a355af Add script to update GitSetup from upstream

d2566004 Tell Git not to export the GitSetup directory

051596ee GitSetup 2015-08-03 (5119521f)

Reviewed-by: Ben Boeckel<EMAIL_ADDRESS>
Merge-request: !3457

On Thu, Oct 19, 2017 at 4:40 PM, Jean-Christophe Fillion-Robin <
<EMAIL_ADDRESS>wrote:

Thanks for the feedback. I will ping you when it is ready. I still need to
publish a VTK topic too.
Jc
On Oct 19, 2017 6:46 PM, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

Did you try building the VTKExamples stand-alone.
It is broken, I get:
-- VTKWikiExamples: Building VTKWikiExamples stand-alone
-- VTKWikiExamples: Building VTKWikiExamples stand-alone - yes
CMake Error at /Users/lorensen/ProjectsGIT/VTK/CMake/vtkModuleAPI.cmake:
138
(message):
Requested modules not available:
WikiExamples
Call Stack (most recent call first):
/Users/lorensen/ProjectsGIT/VTK-clang/VTKConfig.cmake:127
(vtk_module_config)
CMakeLists.txt:16 (find_package)
-- Configuring incomplete, errors occurred!
See also "/Users/lorensen/ProjectsGIT/VTKExamples/build/CMakeFiles/
CMakeOutput.log".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338058867
,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANXo0bjLY6fxzr6Xo5-
Pw3Fyxl7fVL6ks5st9FGgaJpZM4P_37Y>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338067233,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDDTUqyi9HU9vjS9Efl_GDJsWi5frks5st93tgaJpZM4P_37Y
.

--
Unpaid intern in BillsBasement at noware dot com

Which option do you use to configure VTK ?

Just point to vtk build
On Oct 19, 2017 6:00 PM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Which option do you use to configure VTK ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338077718,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDNGliBSxF1eH7HWJwBrkcp38TzDjks5st_CQgaJpZM4P_37Y
.

Strange, using this branch, both standalone and remote build (after pointing to jcfr and the tip of this branch), it works.

I agree, something strange.  I'm a bit concerned. I need to dig deeper.
On Oct 19, 2017 6:08 PM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Strange, using this branch, both standalone and remote build (after
pointing to jcfr and the tip of this branch), it works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338078745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDP19Rj8Bei4tp5vPCK4Xooi-NNy4ks5st_KrgaJpZM4P_37Y
.

Can you share your vtk and vtkexamples. Config. What version of cmake are
you using.
On Oct 19, 2017 6:10 PM, "Bill Lorensen"<EMAIL_ADDRESS>wrote:

I agree, something strange.  I'm a bit concerned. I need to dig deeper.
On Oct 19, 2017 6:08 PM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Strange, using this branch, both standalone and remote build (after
pointing to jcfr and the tip of this branch), it works.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338078745,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDP19Rj8Bei4tp5vPCK4Xooi-NNy4ks5st_KrgaJpZM4P_37Y
.

You can checkout this version of VTK:
https://gitlab.kitware.com/vtk/vtk/merge_requests/3465/commits
And this version of WikiExamples:
https://github.com/lorensen/VTKExamples/pull/52/commits/0891d28fd04dff6f71a151824832989f70f86d63
(Since I created the topic https://github.com/jcfr/VTKExamples/tree/simplify-and-fix-build-system, I pushed once. you need to do the following to get the correct version:
cd WikiExamples
git fetch jcfr
git reset --hard jcfr/simplify-and-fix-build-system

For building VTK, I used these options (adapted from one of the failing build reported on https://open.cdash.org/viewConfigure.php?buildid=5106693).
Without my updates, the configuration is failing (with/without Module_WikiExamples enabled)
With my updates, it configure in both cases. I am now working on some link error of WikiExamples tests.
Qt5_DIR=/home/jcfr/Software/Qt5.9.1/5.9.1/gcc_64/lib/cmake/Qt5
Module_WikiExamples=ON
cmake
--no-warn-unused-cli
-DCTEST_USE_LAUNCHERS:BOOL=1
-DVTK_RENDERING_BACKEND:STRING=OpenGL2
-DVTK_USE_SYSTEM_LIBRARIES:BOOL=OFF
-DVTK_PYTHON_VERSION:STRING=3
-DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3.5
-DVTK_WRAP_PYTHON:BOOL=ON
-DVTK_QT_VERSION:STRING=5
-DVTK_LINKER_FATAL_WARNINGS:BOOL=ON
-DVTK_USE_64BIT_IDS:BOOL=OFF
-DVTK_Group_Web:BOOL=ON
-DQt5_DIR:PATH=${Qt5_DIR}
-DCMAKE_BUILD_TYPE:STRING=Release
-DBUILD_EXAMPLES:BOOL=ON
-DVTK_Group_Qt:STRING=OFF
-DBUILD_SHARED_LIBS:BOOL=ON
-DModule_vtkPythonInterpreter:BOOL=ON
-DVTK_ENABLE_KITS:BOOL=OFF
-DVTK_Group_MPI:BOOL=ON
-DModule_WikiExamples:BOOL=${Module_WikiExamples}
-DVTK_USE_LARGE_DATA:BOOL=ON
-DVTK_LEGACY_REMOVE:BOOL=ON
-DVTK_WRAP_JAVA:BOOL=OFF
-DVTK_DEBUG_LEAKS:BOOL=ON
-DBUILD_TESTING:BOOL=ON
-DCTEST_USE_LAUNCHERS:BOOL=TRUE
../VTK

For building WikiExamples, (after re-configuring VTK with `-DModule_WikiExamples:BOOL=0`), I simply do this:

cd WikiExamples-build
cmake -DVTK_DIR:PATH=/home/jcfr/Projects/VTK-Release ../VTK/Remote/WikiExamples

I'll have to wait until tomorrow.
On Oct 19, 2017 6:26 PM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

You can checkout this version of VTK:
https://gitlab.kitware.com/vtk/vtk/merge_requests/3465/commits
And this version of WikiExamples:
0891d28
https://github.com/lorensen/VTKExamples/commit/0891d28fd04dff6f71a151824832989f70f86d63
(Since I created the topic https://github.com/jcfr/
VTKExamples/tree/simplify-and-fix-build-system, I pushed once. you need
to do the following to get the correct version:
cd WikiExamples
git fetch jcfr
git reset --hard jcfr/simplify-and-fix-build-system
For building VTK, I used these options (adapted from one of the failing
build reported on https://open.cdash.org/viewConfigure.php?buildid=5106693
).
Without my updates, the configuration is failing (with/without
Module_WikiExamples enabled)
With my updates, it configure in both cases. I am now working on some link
error of WikiExamples tests.
Qt5_DIR=/home/jcfr/Software/Qt5.9.1/5.9.1/gcc_64/lib/cmake/Qt5
Module_WikiExamples=ON
cmake
--no-warn-unused-cli
-DCTEST_USE_LAUNCHERS:BOOL=1
-DVTK_RENDERING_BACKEND:STRING=OpenGL2
-DVTK_USE_SYSTEM_LIBRARIES:BOOL=OFF
-DVTK_PYTHON_VERSION:STRING=3
-DPYTHON_EXECUTABLE:FILEPATH=/usr/bin/python3.5
-DVTK_WRAP_PYTHON:BOOL=ON
-DVTK_QT_VERSION:STRING=5
-DVTK_LINKER_FATAL_WARNINGS:BOOL=ON
-DVTK_USE_64BIT_IDS:BOOL=OFF
-DVTK_Group_Web:BOOL=ON
-DQt5_DIR:PATH=${Qt5_DIR}
-DCMAKE_BUILD_TYPE:STRING=Release
-DBUILD_EXAMPLES:BOOL=ON
-DVTK_Group_Qt:STRING=OFF
-DBUILD_SHARED_LIBS:BOOL=ON
-DModule_vtkPythonInterpreter:BOOL=ON
-DVTK_ENABLE_KITS:BOOL=OFF
-DVTK_Group_MPI:BOOL=ON
-DModule_WikiExamples:BOOL=${Module_WikiExamples}
-DVTK_USE_LARGE_DATA:BOOL=ON
-DVTK_LEGACY_REMOVE:BOOL=ON
-DVTK_WRAP_JAVA:BOOL=OFF
-DVTK_DEBUG_LEAKS:BOOL=ON
-DBUILD_TESTING:BOOL=ON
-DCTEST_USE_LAUNCHERS:BOOL=TRUE
../VTK
For building WikiExamples, (after re-configuring VTK with -DModule_WikiExamples:BOOL=0), I simply do this:
cd WikiExamples-build
cmake -DVTK_DIR:PATH=/home/jcfr/Projects/VTK-Release
../VTK/Remote/WikiExamples
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338080957,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDCvjDC2JNUyGX9dVnE9_2nEC5RQcks5st_bXgaJpZM4P_37Y
.

Of course, it is already late.
I will work on this further and try to sort everyone :)

The current PR should address all issues.
see also https://gitlab.kitware.com/vtk/vtk/merge_requests/3465

I want the new CMakeLists.txt to work with older versions of VTK. Can you put the proper version tests in the CMakeLists.txt file?

new CMakeLists.txt to work with older versions of VTK.. Can you put the proper version tests in the CMakeLists.txt file?

Which versions of VTK do you want to support ?  7 and 8 , or older ?

Back to 6 if possible, 7 at least.
On Oct 20, 2017 9:14 AM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

new CMakeLists.txt to work with older versions of VTK.. Can you put the
proper version tests in the CMakeLists.txt file?
Which versions of VTK do you want to support ? 7 and 8 , or older ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338252515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDJ4C9umHDBJx3xfv3v1mtpMM6c7Lks5suMbUgaJpZM4P_37Y
.

Are you generating a different site for each one of them ?
Is the goal to create example if #idef and sometime more complex logic to support all version of VTK ?
Or is the goal to publish simpler example known to work with API of given version of VTK without the need to support all of them are the same time ?

We could for example have the following branches:

maintenance-vtk-6.x
maintenance-vtk-7.x
master

or something along those line.
Also without a testing infrastructure .. it also gonna be hard to support all of the versions moving forward.

I gave a macro that will skip an example if it uses classes in a newer
release
The overall goal is to keep the customer happy as long as possible.
On Oct 20, 2017 9:23 AM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Are you generating a different site for each one of them ?
Is the goal to create example if #idef and sometime more complex logic to
support all version of VTK ?
Or is the goal to publish simpler example known to work with API of given
version of VTK without the need to support all of them are the same time ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338254804,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDA1KmpEcaP6UToSSuriIq731MYNiks5suMjvgaJpZM4P_37Y
.

Just fix the cmake lists I'll handle the examples themselves. I've
beenjoyed dealing with vtk api.giithub.com changes for years.
On Oct 20, 2017 9:26 AM, "Bill Lorensen"<EMAIL_ADDRESS>wrote:
I gave a macro that will skip an example if it uses classes in a newer
release
The overall goal is to keep the customer happy as long as possible.
On Oct 20, 2017 9:23 AM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Are you generating a different site for each one of them ?
Is the goal to create example if #idef and sometime more complex logic to
support all version of VTK ?
Or is the goal to publish simpler example known to work with API of given
version of VTK without the need to support all of them are the same time ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338254804,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDA1KmpEcaP6UToSSuriIq731MYNiks5suMjvgaJpZM4P_37Y
.

Just fix the cmake lists I'll handle the examples themselves.

Great I will push something then.

@jcfr I successfully built with this pr and the VTK pr. But I had to add vtkViewsInfovis to module.cmake.

I successfully built with this pr and the VTK pr.

Great

But I had to add vtkViewsInfovis to module.cmake

A fix is coming to support building against VTK without that module enabled

I noticed that vtkInitializeBuildType.cmake uses Debug if no BUILD_TYPE  is specified. I think this is a big mistake since Debug builds are very slow and give the first time user a bad experience.

This is consistent with the default of VTK before my change:
https://github.com/Kitware/VTK/blob/b5bdeda61cf00693d9c10672a53e9c0a708856d0/CMakeLists.txt#L91-L98
I suggest you create a MR later to discuss and change this.
I would recommend RelWithDebInfo as the default

Will do. Thanks.
On Fri, Oct 20, 2017 at 11:33 AM, Jean-Christophe Fillion-Robin <
<EMAIL_ADDRESS>wrote:

This is consistent with the default of VTK before my change:
https://github.com/Kitware/VTK/blob/b5bdeda61cf00693d9c10672a53e9c
0a708856d0/CMakeLists.txt#L91-L98
I suggest you create a MR later to discuss and change this.
I would recommend RelWithDebInfo as the default
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338288213,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDKRQLdZ0Qbg9ROWg7YrWmuTID7pMks5suOd9gaJpZM4P_37Y
.

--
Unpaid intern in BillsBasement at noware dot com

To be consistent with other example, I  prefer using the macro Requires_Module,

To be consistent with other examples, I prefer using the macro Requires_Module.

Et voila, support for VTK < 8.1 has been re-introduced. Also fixed the build against Qt4.
Note that I am only doing a test on VTK_VERSION . This means that version of VTK > 8.0 but older than October 18 are not supported.

I'm unavailable until tomorrow.
On Oct 20, 2017 3:19 PM, "Jean-Christophe Fillion-Robin" <
<EMAIL_ADDRESS>wrote:

Et voila, support for VTK < 8.1 has been re-introduced. Also fixed the
build against Qt4.
Note that I am only doing a test on VTK_VERSION . This means that version
of VTK > 8.0 but older than October 18 are not supported.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/lorensen/VTKExamples/pull/52#issuecomment-338335483,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUFDMsuTd90NOvL0EJ5ldtYaunLXXCVks5suRxbgaJpZM4P_37Y
.

I wish you had not made cosmetic changes to so many files. This PR should concentrate pn the minimal changes required to use the new VTK module API. It makes it difficult for me to review.

The tests are failing because you removed
vtkRendering${VTK_RENDERING_BACKEND}
from module.cmake.

made cosmetic changes to so many files.

Ok, I will remove them from this PR

That fixed it.

Missing vtkRendering${VTK_RENDERING_BACKEND}

Good catch.
I am cleanup this topic.
I also created smaller topic implementing unrelated cosmetic changes

That fixed it.

Legacy
Adding vtkRendering${VTK_RENDERING_BACKEND} is required with the legacy way.
Indeed, since the project relied solely on find_package/VTK_USE_FILE, that was working.
New approach
With new approach, the use of  vtk_module_config takes care of setting the DEFINITION without having to explicitly add vtkRendering${VTK_RENDERING_BACKEND} as a dependency. Then, to ensure these definitions are used, we associate them the definition to the top level directory of the project using one of these approach:

direct call to set_property(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS ${VTK_DEFINITIONS})
or include of VTK_USE_FILE

Note on explicitly depending on a backend
Note that explicitly requesting a backend implementation defeat the purpose of having object factory overrides. Indeed, such system allows to switch the default backend for abstract interfaces like vtkImageResliceMapper or vtkRenderWindow. For example, with one option it is possible to reconfigure VTK so that the backend for vtkRenderWindow is vtkOpenVRRenderWindow instead of the OpenGL one.
This is a general remark, it is true for the case of the examples, this probably doesn't matter.
Transition toward modern CMake
Finally, also worth noting that the recommended way of including VTK is not:
find_package(VTK ...)
include(${VTK_USE_FILE})

but
find_package(VTK ...)
vtk_module_config(MyVTKA a1 a2)
vtk_module_config(MyVTKB b1 b2)

which sets variables like MyVTKA_DEFINITIONS, MyVTKA_LIBRARIES, ...
This allows to have well defined subset of dependencies for a given project/subproject and avoid a lot of headaches.
Indeed, quite often find_package(VTK ...)/include(${VTK_USE_FILE}) pair ended up being call as a side effect from an other find_package requesting its own dependencies .. and this ended up resetting VTK_* variables previously set.
Last, to quote Brad K. ...
Of course in the long run projects should be able to use the
VTK targets directly.

This is related to modern CMake that VTK should transition to in the near future.
Thanks for reading :)

@jcfr This has conflicts

Rebasing now

Et voila. Thanks for your patience, suggestion and time.
This last commit adding support for vtkExternalModuleMacros is now smaller and should be reviewable

Thanks @lorensen  🎆


PBE Access

Hi Folks - I'd like to get a list together of who needs PBE access.  For API developers, there are a few responsibilities (and benefits!) of having access.
What you'll do:

You'll be responsible for creating new schema files that describe each patch versions data, and helping to get them into this repository.  This will ensure each patch is clearly documented, prior to being released, and prior versions of the data format are documented.  (Once documented, they can even be transformed to look more like current data.. more on that if interested).
You'll be responsible for helping to spot data bugs (think, 2.4 patch) and reporting them prior to submission.  This will ensuring fewer data issues.

What you'll get:

Early access to data changes
Early knowledge of game changes (heros, etc.)
Closer access to the dev team.

We are looking for 4 or 5 teams to join up!

NOTE: We will try to be fair in who gets access.  This will take into account the popularity of the project you're maintaining, and your ability to contribute to the PBE program.

I'd certainly be interested in this -- how do we apply?

Sign me up! Im already in PBE btw so not sure if that makes a difference. Not sure if you know but we already have the number of community developers you wanted in PBE btw.
BTW Is this a 1 invite per person or 1 invite per team? I mean my team has 5 developers on it and we are bringing on another 4 soon do they all get invited or just the 1 person? How do invites work?

I think the invite will be based per API key. So if you team shares the same api key, then you will all have access.

As backend developer of VainSocial.com, I am interested. I would share the key or the data with the rest of our team (stormcaller/@kvahuja, Shiqan) as needed.

Developer of Halcyon Chats and I’m a PBE Tester for iOS.

@PierreAndreis If it was API Key how does that give closer access to Dev team or early knowledge of changes? This is only possible if you are in the PBE. API key would only provide early access to data from what I understood.

Count me in too please. Thanks!

This is working on the tech end now.  I am chatting with Nivmett on Tuesday about process stuff and how to get everyone enrolled.  Brian is rolling out Schema links today too, so that should tie this all up :)

What is the status? The changelog mentions "PBE data is now available to approved community developers", judo asked for our team's mail, but we haven't gotten any instructions on how to actually get the data.

@genexp Any update on this? 2.9 is coming next week.

@genexp What is the status?
You have promised this to be the workaround for schema and data breakages every update. There have been 3 updates now, each of them introducing breaking changes that I had to fix after the data was live.

correct me if i'm wrong, but all breaking changes has been communicated properly, days before the update @schneefux
But I do believe that we need PBE access, which in this case needs to be more regularized than just giving access (to avoid leaks etc)

Actually, if you want to be precise about it, NOTHING regarding API has EVER been communicated “properly” ... I would consider “proper” communication to be an official changelog posted by an SEMC employee who is part of the dev team responsible for the API  in an official channel, such as the SEMC Slack or the API web portal.
I am not belittling your efforts, Pierre — if it weren’t for you, we would have no information AT ALL. It’s just that it’s not your job, and by your own admission, you’re not part of the team responsible for the API, so the information isn’t first hand.
I think that’s a sad state of affairs, to be frank.

Changes that haven't been communicated at all, not even weeks after the release and that broke my logic:
#317:
Added fortress minion crit attack Oct 11
Baptiste "Tether" attacks, Flicker crit, Reim crit, Taka Legendary Talent Aug 25
Grace crit, Baptiste attacks Aug 20
#332:
Buff_Item_HitByStormguardBanner is now Buff_Item_StormguardBanner_Damage
Buff_Item_Spellfire_Damage has been added
Buff_Lorelai_FishFoodDamagePerSecond (Lorelei A) has been added
Buff_Lorelai_FishFoodDelay (Lorelei A) has been added
Buff_Reza_C_DamagePostTeleport (Reza C) has been added

@schneefux @cklugewicz you made a point, I totally agree with you both
Hopefully we can get this sorted out soon :/


Custom Frida snippets[feature]

It would be cool if you made it possible to add my own snippets.
To do this, you need to make a list of placeholders that will be replaced by jadx in the pasted code during the snippet generation call. something like this:
$CLASS_NAME
$METHOD_NAME
$ARG_TYPES[]
$ARGS[]
$ARGS_LEN
and so on
at example:
let a = Java.use($CLASS_NAME);
a[$METHOD_NAME].overload( '$ARG_TYPES[0]').implementation = function ($ARGS[0]) {
  console.log('$CLASS_NAME-$METHOD_NAME called' + ', ' + '$ARGS[0]: ' + $ARGS[0]);
   let ret = this[$METHOD_NAME]($ARGS[0]);
  return ret;
};

@gavriksobaken you can use jadx-next branch with gui_custom_frida script.


Solr is not set up

When uncommenting solr service from the docker-compose file, Solr starts up, but it's not set up for Drupal - it doesn't have default collection and Drupal settings. I've tried replacing it with wodby/solr-5-alpine - apachesolr module was able to connect. Would that be more suitable solution as that incorporates Drupal configuration?

Hi, @davidlukac.
We use the official Solr image, which doesn't include drupal-specific configs. The image wodby/solr-5-alpine isn't compatible with the docker4drupal. So, you can put Solr config manually.

D7: https://ftp.drupal.org/files/projects/search_api_solr-7.x-1.10.tar.gz
D8: https://ftp.drupal.org/files/projects/search_api_solr-8.x-1.0-alpha4.tar.gz

Also, we plan to create the drupal-solr5 image with built-in configs.

A new solr container has been added. See README file.


No factory has been set

Hi Callum,
Thanks for sharing your great work.
I am trying to run the umbraco 8 console but I am coming up with error No factory has been set.
Do I miss anything to set?

Hey @pragneshmpatel!
Thanks for giving the preview of Sidecar a try!
There could be a number of reasons why you are getting this error, and this rather unhelpful error message is coming straight from Umbraco rather than Sidecar. I am working to add something that makes errors a little more user friendly...
Some things to check / try in your config:

Is your connection string valid? Can you connect to the server and the database with the necessary permissions?

Do you have the Umbraco.Core.ConfigurationStatus app setting and is it set to a valid version number, e.g. 8.6.1? This version needs to be the same version as your database has been upgraded to.

Do you have the Umbraco.Core.Path app setting and is it set to ~/umbraco?

Finally, Sidecar currently needs to have the same version of Umbraco installed as you are running elsewhere. By default Sidecar ships with Umbraco 8.1.0, you might need to upgrade this dependency to match the version you are using elsewhere.
Hope this helps, let me know how you get on!
Callum

Hello!
I have the same error using 8.6.1

Looks like all the files on config folder should be set to Copy Always

Looks like all the files on config folder should be set to Copy Always

Thanks @gregorypilar  that worked.


C# JdbcConnectionStringBuilder Errors in Provided Example

DriverPath, DriverClass and JdbcUrl from the provided example generate  CS0103, name does do not exist in current context, compilation errors.

Got passed this error only to be confronted with the com plus 532462766 exception code when I go to create the connection.

I am trying to connect to an Oracle database

Would you be able to provide example code?

   static void Main(string[] args)
    {
        var Tbuilder = new JdbcConnectionStringBuilder { DriverClass = "oracle.jdbc.driver.OracleDriver", DriverPath = "C:\\Users\\DEV101\\ojdbc11.jar", JdbcUrl = "jdbc:oracle:thin:@ldap://oracleServer.corp:1510/DevDB,cn=oraclecontext,dc=world;UID='DEV101';PWD='qx3Wz>uc%xlz'" };
        var Tprops = new JdbcConnectionProperties{{ "User", "Dev101" }, { "Password", "qx3Wz>uc%xlz" } };
        using JdbcConnection Tconnection =new JdbcConnection(Tbuilder,Tprops);
        Tconnection.Open();
        Tconnection.Close();
    }

Fails on using JdbcConnection Tconnection =new JdbcConnection(Tbuilder,Tprops)


[86c064k7w][website] added example with pagination to data-table

Motivation and Context
I've added example with pagination to data-table

How has this been tested?
Manually

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[X] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Nice improve.

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly or it's not required.
[X] Unit tests are not broken.
[X] I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
[ ] I have added new unit tests on added of fixed functionality.

checked  - ok


Fixes #4

Fix README instructions
Make the main file executable for easier cli usage
Read the wpscan install dir from env instead of hardcoding it

Wonderful! Thanks! :)


Fixes #13774

Update tests for Add a box-shadow to a Card-like Element .
Closes #13774

It was for some tests(?) I forgot to remove it. Thanks for noticing.


Add Pause Menu

Example showing menu behavior.
https://user-images.githubusercontent.com/23508546/204418329-df48e5d0-1a24-452d-ad18-3b7a528053fe.mp4
This includes the following behavior:

Use escape to pause the game.
While the game is paused, escape will unpause.
Menu options can be chosen with directional keys.
Make a selection with any "ui_select" button
Choosing exit will exit the game.
Choosing Continue will unpause the game.

New Scene Hierarchy:

New hierarchy of the DynamicUI scene:

Closes #44


Add directories for extended queuejob

@scostache Can you review and add the /lgtm label once you review and approve?

/assign @k82cn


add ISO language model

New PR in lieu of #46
Signed-off-by: Peter Hunn<EMAIL_ADDRESS>

A couple of questions/comments:

Could we put the URL to the source for that list as comment in the model?
Should this use language codes rather than language names?

@peterhunn any progress on this?

@peterhunn should I close this PR, or are you still working on it?

Pinging @peterhunn about this model?

Pinging @peterhunn about this model?

Are the updates suitable to render it usable?

Pinging @peterhunn about this model?

Are the updates suitable to render it usable?

I think at the minimum, @dselman comments have to be addressed and the DCO needs to be signed before we can merge.

Pinging @peterhunn about this model?

Are the updates suitable to render it usable?

Maybe the comments have been addressed? I'll ask Dan for another review to make sure. The only other change might be to sign the commit for DCO signoff.

Closing, as stale.


Update Anthropic Client

Anthropic changed their python sdk - making this code line outdated.
https://github.com/nat/openplayground/blob/7f3f79035b3229aa471a9746d9af59035d5e71aa/server/lib/inference/__init__.py#L605
Anthropic changed their python sdk - making this code line outdated.
https://github.com/FranxYao/chain-of-thought-hub/blob/d8f0f8bd9189f24b5e4cc6b19eb8a7689db42651/gsm8k/run_gsm8k_claude_instant.py#L47C3-L47C50
Would love to know if this might help - https://github.com/BerriAI/litellm
~100 lines of code, that standardizes all the llm api calls to the OpenAI call
from litellm import completion

## set ENV variables
# ENV variables can be set in .env file, too. Example in .env.example
os.environ["OPENAI_API_KEY"] = "openai key"
os.environ["ANTHROPIC_API_KEY"] = "anthropic key"

messages = [{ "content": "Hello, how are you?","role": "user"}]

# openai call
response = completion(model="gpt-3.5-turbo", messages=messages)

# anthropic call
response = completion("claude-v-2", messages)

cc: @nat


WIP: try reporting results to snyk.io

Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

/retest

/retest

/retest

Yup, uploading the reports on PRs definitely does cause the PRs to overwrite each other's results
When #1252 uploads its report:

When this PR uploads its report:


Draft: Implement spelled out for Māori

Made some good progress tonight: at a7e63b8 the Māori test results were:
Test Summary: | Pass  Error  Total  Time
Māori         |   28     33     61  3.0s

Now (at e233741), they are:
Test Summary: | Pass  Fail  Error  Total  Time
Māori         |   43     1     17     61  7.6s

Since 7b8e491, doing better still:
Test Summary: | Pass  Fail  Error  Total  Time
Māori         |   52     6      3     61  4.1s

Still to do:

Implement evaluation strings for empty tests
Implement commas:

Māori: Test Failed at /Users/jakeireland/projects/SpelledOut.jl/test/runtests.jl:114
  Expression: spelled_out(1982, lang = :mi) == "kotahi mano, iwa rau, waru tekau mā rua"
   Evaluated: "kotahi mano waru tekau mā rua" == "kotahi mano, iwa rau, waru tekau mā rua"

Account for numbers ≥ 10,000

The primary questions I have had are:

How do you say 100?  (Kotahi or kotahi rau?)  What about 9,100?  (Iwa mano, kotahi, or iwa mano, kotahi rau?)
Are there modifiers for very large numbers?  For example, we have mano for thousand, miriona for one thousand thousand (one million), and piriona for one thousand million (one billion).  Are there words for one trillion (one thousand billion), or one quadrillion (one thousand trillion)?  What about higher?
When do we use kotahi vs. tahi to mean "one"?  (I have seen both.)
What do you say for negative numbers?  In English, you can write "negative one-hundred," or "minus one-hundred."
Where do I put commas in large numbers, or example, 1984?  I have seen this written without commas (kotahi mano iwa rau waru tekau mā whā), or with commas between each order of magnitude (kotahi mano, iwa rau, waru tekau mā whā). or with just one comma (kotahi mano, iwa rau waru tekau mā whā).

I have asked some people these questions, but I'm still trying to find kaumātua to provide me with assurance that I am doing this correctly.
Some important questions to ask:

What is the rationale as to why you would use numbers in te reo Māori?
How do numbers in any shape or form benefit our whānau?
Do the numbers tell a narrative or more so have a whakapapa?

The goal of the project as a whole (not te reo specific) is to provide a programmatic interface to writing out numbers in long form.  Specifically for te reo Māori, I am proud of our culture and language.  I think this functionality is useful in many contexts, from simply providing readable metrics in areas such as report writing or data science, to natural language processing and machine learning.  Providing this functionality for te reo Māori enables the use of this library throughout Aotearoa—I particularly see this as being useful in government, where language and accessibility is most important.  I think this benefits our whānau/Aotearoa, simply in providing visibility and accessibility to te reo Māori.  The numbers output from this programme do not tell a narrative, as it entirely depends on the use case.  This programme is a library, to be used in others' programmes.
That said, I'm curious to know how this is done in computer science.  My intentions with this library are good, and I genuinely think that the accessibility this would enable is beneficial, but you can't necessarily be sure that everyone who uses this library has good intentions, no?  Same can be said for any library.  I'd be interested to know how this is tackled in computer science.

TODO: move this to a new branch
This is a very old branch and seems very messy.  I can make the commit history much cleaner.

Other questions:

How did Māori write before Europeans?
Consider regional differences and Elsdon Best's article on vigesimal numeration.

Note also, regarding big numbers, that if you think of navigation by the many stars, I'm sure there would have been numbers or co-ordinates that map their geographical and spatial dimensions of time to land.  So I suspect there are numbers that are large, or in some way relevant in this area.  Still unsure about the modifiers question, though.
Maori Numeration.pdf


Remove deprecated role geerlingguy.docker_arm

What this PR does / why we need it:
Removes deprecated role geerlingguy.docker_arm (https://github.com/geerlingguy/ansible-role-docker_arm).
Ansible fails on ARM (M1 Apple silicone in my case) when this role is used.
Which issue (if any) this PR fixes:
Any other useful info:

This might fix your specific use case when running from a Mac, but breaks applying to a Raspberry Pi.
Can you provide more debug information please? What specifically fails? If you follow the guide when raising an issue, that would be a good start.

Sorry for the delay, I've added more details to issue #706.


Limit inference from apparent types to one level deep

Fixes the OOM in our fp-ts internal RWC test. There's no regression test for this because there was no bug. If you gave the process a handful of extra memory - 100MB more (roughly the overhead of our test harness itself) the build completes just fine with the original change (#27015) as-is (and, in fact, outside of the harness it does still build!). The change was simply enough to push a test already near the memory limit right over the edge.
Limiting inference from apparent types to one layer deep prevents us from using too many more resources, and isn't observably different in most cases (you'd need a type variable that simplifies to a union which contains a type variable which itself simplifies to something which you want to perform inference on to notice the difference - not something which happens at all in our harness!). In any case, this keeps #25274 fixed and the bug this limiter introduces should be difficult to reproduce in the wild (and would have also been a bug in 3.0, so isn't a regression yet).

@typescript-bot test this


Does not generate any files

I cannot get Zap to generate any files.
Ubuntu 20.04.6 LTS, zap version embedded in SSv5 (2023.9.22):
First try: [Generate] lets me select a directory to generate files in but it doesn't generate any files. No error or warning is shown.
When adding an endpoint what I select is:
endpoint 1, HA Home Gateway / energy management system 0x0050
network 0
profile id 260
version 1
On startup Zap shows a notification, and it's a warning:
/home/isj/SimplicityStudio_v5/developer/adapter_packs/zap/resources/app.asar/zcl-builtin/silabs/zcl.json
Warnings
Check type contradiction in XML metadata for ColorControlOptions with type BITMAP8
Check type contradiction in XML metadata for LevelControlOptions with type BITMAP8
Check type contradiction in XML metadata for BarrierControlBarrierPosition with type INT8U
Check type contradiction in XML metadata for GpPairingConfigurationAction with type BITMAP8
Check type contradiction in XML metadata for BillingPeriodDurationUnits with type INT24U
Is that what's preventing it from generating files?
On subsequent tries I sometimes get:
isj@ubuntu2004:~/SimplicityStudio_v5$ ./developer/adapter_packs/zap/zap
\U0001f527 Using state directory: /home/isj/.zap
[Error: SQLITE_ERROR: no such table: SETTING] {
errno: 1,
code: 'SQLITE_ERROR'
}
Deleting /home/isj/.zap seems to clear that error.
I also tried:
Windows 10, zap version embedded in SSv5: [Generate] lets me select a directory to generate files in but it doesn't generate any files.
Which results in the same warning and behaviour as in SSv5+ubuntu version.
So it seems it's a cross-platform bug, but I assume it does work for some people, which leaves me wondering what's special about my setups / selections.
I also tried:
OpenSuse 15.4, Zap v2023.11.13. [Generate] shows directory selection dialog, but selection cannot be made. Using default selection and [generate] does not produce any output files.
I'm not sure what else I can provide that will enable you to replicate this bug.

@isj4 can you try with the very latest? please

I tested that version now.
Downloaded ZIP file and unpacked on Ubuntu 20.04.6 LTS in a VM.
I started "zap" directly on the command line, created a minimal zigbee project "Zigbee HA gateway...", saved, and then pushed [generate]. Result:
A popup-notification appears with:
zap
"" is ready

But a file location picker window popped up in the background.
No location/directory seems selectable in that picker, except the "recent/home/desktop/documents/downloads/..." shortcuts.
I selected "Downloads" and pressed the green [Generate button]. Window closes. A sort-of progress-bar line flashes in the main window, and nothing has been generated. No warnings, no errors.
I'm wondering if Zap relies on some shared library but doesn't detect its non-presence and simply fails silently.

look up "gen-templates.json" in the SDK

Any luck with this issue? I am having the same problem

I haven't had time to try yet. I did locate the mentioned file in the Gecko SDK: ./protocol/zigbee/app/framework/gen-template/gen-templates.json

Ok I got it working!
run the zap tool with the following arguments
./zap --logToStdout --gen <path_to_template>/gen-templates.json --zcl <path_to_zcl.json>zcl.json
I'm not sure if this is documented anywhere but I could not find any documentation on how to run zap.
I had to look at the scripts from connectedhomeip repo that are using zap.
If anyone knows where this is documented, could you point me in the right direction.
Thanks!

@isj4 @SimpliPHYd seems like you have figured this out. @SimpliPHYd you are correct you need to pass the --gen and --zcl targets to zap in order to pick the correct meta data from your SDK. ZAP documentation related to this can be found in https://github.com/project-chip/zap -> Usage Documentation -> ZAP User's Guide -> Launching ZAP for Matter or Zigbee Applications or Generating Code for Matter, Zigbee or a Custom SDK

If you see [Error: SQLITE_ERROR: no such table: SETTING] { errno: 1, code: 'SQLITE_ERROR' } error it is likely that your database got corrupted at some point and deleting your .zap repo from your root directory gets you around this issue.
Closing this issue hoping that this answers all your questions. Please feel free to re-open if there is anything left over with respect to this issue.


Fix : Cross-Site Scripting (XSS) : Fixed by encoding the row values

📊 Metadata *
franciscop/drive-db. this package is vulnerable to Stored Cross-Site Scripting (XSS)
Bounty URL: https://www.huntr.dev/bounties/1-npm-drive-db
⚙ Description *
Cross-Site Scripting (XSS) attacks are a type of injection, in which malicious scripts are injected into otherwise benign and trusted websites. XSS attacks occur when an attacker uses a web application to send malicious code, generally in the form of a browser side script, to a different end user. Flaws that allow these attacks to succeed are quite widespread and occur anywhere a web application uses input from a user within the output it generates without validating or encoding it.
💻 Technical Description *
Cross-Site Scripting (XSS) attacks are mitigated by sanitizing the user inputs before rendering, thereby preventing malicious execution.
🐛 Proof of Concept (PoC) *

download https://github.com/franciscop/drive-db or use https://jsfiddle.net/v8uLpx59/1/
use this this for testing https://docs.google.com/spreadsheets/d/13Sxv7P6yv6shDx_QfHnGoZ_Rt4ZSYO_x-9H_908vJis/edit?usp=sharing
XSS payload get executed

🔥 Proof of Fix (PoF) *

👋 Hello, @franciscop - @ashishBharadwaj has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@franciscop & @ashishBharadwaj - thank you for your efforts in securing the world’s open source code! 🎉

👋 Hello, @franciscop - @ashishBharadwaj has opened a PR to us with a fix for a potential vulnerability in your repository. To view the vulnerability, please refer to the bounty URL in the first comment, above.
Ultimately, you get to decide if the fix is 👍 or 👎. If you are happy with the fix, please write a new comment (@huntr-helper - LGTM) and we will open a PR to your repository with the fix. All remaining PRs for this vulnerability will be automatically closed.
If you have any questions or need support, come and join us on our community Discord!
@franciscop & @ashishBharadwaj - thank you for your efforts in securing the world’s open source code! 🎉

The problem here is that you are writing raw invalidated text to the HTML. Please fix it with:
- document.body.innerHTML = `<pre>${JSON.stringify(db, null, 2)}</pre>`;
+ document.body.innerHTML = `<pre />`;
+ document.body.querySelector('pre').textContent = JSON.stringify(db, null, 2);

We do not know how the data is going to be used or where it comes from, so we should not be making indiscriminate conversions to the raw text input.

The problem here is that you are writing raw invalidated text to the HTML. Please fix it with:
- document.body.innerHTML = `<pre>${JSON.stringify(db, null, 2)}</pre>`;
+ document.body.innerHTML = `<pre />`;
+ document.body.querySelector('pre').textContent = JSON.stringify(db, null, 2);

We do not know how the data is going to be used or where it comes from, so we should not be making indiscriminate conversions to the raw text input.

Sorry, @ashishBharadwaj - it looks like the maintainer has not selected your fix this time...
We appreciate your effort and look forward to seeing more of your fixes in the future! 🛠
If you have any questions, feel free to join our community Discord and a member of our team will be happy to help! 🤗

I never claimed that the fix was wrong, I'm more like throwing an exception than claiming that this fix is not good.
But now that I read the fix, even if the original issue was good, this fix would need work since it's over-encoding the text :)


fix(vuetify): updated layout to be on par with Vuetify 2.x

Just a simple layout update to Vuetify version 2.x. Previously using outdated v-layout and v-flex (from Vuetify 1.x)

I'll close this in favor of your other equivalent PR 😋
https://github.com/nuxt/create-nuxt-app/pull/619/

I realized that I didn't create a branch when I did this PR. I created a branch on the other one. This can be closed.


Available code

Good work!
When will the code of the paper be released?
Thx.

Hi,
Code has been partially released.
We also released a timeline for following releases


Feature: Added support for creating alternate data streams

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #16337

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Confirmed the option is disabled in the root path
Confirmed the feature works for single and multiple items
Confirmed the menu option is only shown when the setting is enabled

@hishitetsu thank you for the review.


Support retries in listing package

Without aemSatisfy could intermittently fail (very rare edge case).
Extract method listPackages() in InstanceSync

implemented in #328

parameters named changed
packageRefreshing -> listRefresh / CMD: aem.satisfy.packageRefreshing -> aem.satisfy.listRefresh
new property
listRetry


Read and write dataframes from and to NDJSON files

NDJSON is an useful format to store multiple JSON documents in a single
file, separating them by new lines.
Closes https://github.com/elixir-nx/explorer/issues/139

@cigrainger thanks! :purple_heart:
I will fix the conflicts and the typo manually.


Update Ruby to version 2.3.0

Not sure if this is an option; are you hoping to support older Ruby versions? If not, the newest version has some interesting improvements around string freezing and null checking in particular.

I am kind of trying to stay in line with what the Digital Ocean rails image ships with, which I think is 2.2.1 right now, but i agree 2.3.0 is the preferred option.  What are some good rails/VPS hosts in the UK?

Great :) I think in that case we should remove the ruby declaration from the Gemfile altogether, and (using Travis to verify compatibility for us), support at least a small range of Ruby versions so people can use the latest if they want to. I'll make that tweak here as soon as #43 is merged! :)

Have investigated and read more about running builds against multiple Ruby versions on TravisCI. I think it's much simpler to just stick with the older version, not least because we'd need to fiddle about with the Gemfile and add complexity where it's not required.
You're right that 2.2.1 is the default on DigitalOcean so understand your argument for sticking to that.
There are a couple of other changes in this PR, so I'll rename it to be more appropriate!


Request: Inline validation for select box

Select one ...  (check one with "x")
[ ] bug
[x] feature request
[ ] enhancement
Expected behavior
Clarity has inline validation for input field, which is very handy and users can quickly locate the error. Select box should have similar behavior too. When user selects the wrong item from the list or they forget to make selection, the select box show have inline validation, maybe the line become red and an error icon is shown by its side.
Actual behavior
No inline validation available for select box now.
Example of input field showing error inline while for select box error we can only use error alert, which takes a few seconds to locate the error.

This is a duplicate of #46 – which is still in design phase.

Forgot to reply earlier. Thanks Scott!


chore(merge-back): 2.50.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: fd843158ffa11119803c2829154febca494a76f4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Thread safety of agentMemory between gateway and heartbeat

Dear authors,
Thanks for open-sourcing the Malcolm code!
I went through the code, and found there might be some thread safety issues of agentMemory between gateway threads and heartbeat threads. For example, gateway threads would call agentMemory->incrementServerMigratedTasks to increase the serverNumOfMigratedTasks counter, while heartbeat threads would call agentMemory->getServerMigratedTasks to retrieve the serverNumOfMigratedTasks counter. However, there seems no thread synchronization between these two.
I wonder if this would create some issues with load-balancing performance, or if such memory out-of-sync nearly does not nearly impact?
Best,
Yang

Hi Yang,
incrementServerMigratedTasks takes as input an index. This index is incremented in a thread-safe manner by the heartbeat-manager thread (search for policyAccessGuard.store in server.cpp). This way, we avoid data race by making sure that the gateway thread and the heartbeat-manger thread do not access the same memory location.

Thank you for the explanation!


[front] Delete group when deleting space

Description
When deleting a space, the associated group should also be deleted.
As in theory a space can have multiple groups and groups can have multiple spaces, we ensure the group is not associated with any other space before removing.
backfill script to remove groups that are still there.
Risk
Deploy Plan
deploy front
run script to clean dangling groups

Let me rephrase the motivation here. Since groups and spaces are tied together. As of today we create a new group for every space even if the data model allow for a disentanglement of both.
This leads to the fact that if we delete a Space we have "dangling" groups as they are not accessible in the UI and will never be interacted with anymore.
Hence the motivation to delete them


Endpoint that returns all users with a source

@jonuy looking at returning specific users in aurora (DoSomething/aurora/issues/66)
We were thinking about creating an enpdoint that returns all users from a given source
Does users?source=agg make sense as the endpoint

@angaither yea, I think that'd be fine. Do you think we'd also want to support querying against multiple sources? Something like /users?source=agg,bgg,cgg,?

yes! @jonuy great ideas!

This is something that'd be super useful for Aurora. We just need to add a MongoDB index on the source field, and then we can use this with existing ?filter[source]=agg,cgg functionality.

Adding to list of requestors for this feature:

There's a need to create MailChimp entries from mobileapp user registrations to ensure they're getting the "Weekly Do" email newsletter. This will be taken care of automagically once the quicksilver-api /user/register endpoint is in production. Until then, the plan is to create a daily batch job to collect mobileapp user registrations from Northstar and add them to MailChimp.

I think I'll need a functional GET /v1/users?filter[source]=mobileapp type endpoint on Northstar to make this happen.

It might also be helpful to also filter by a timeframe as suggested by @DFurnes :

I guess we’d also want to add a way to query by timeframe as well then?


Wait for SSH Connectability

A function that waits until a you can connect to the particular server would be nice.

Resolved in 48d9f038945b3cb5f852b19a7244eb0973b17c57


Windows install

cc @kohl-carmen I think this should fix your problem

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   67.61%   67.61%
=======================================
  Files          19       19
  Lines        1930     1930
=======================================
  Hits         1305     1305
  Misses        625      625

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf9602d...6fefa28. Read the comment docs.


Dark background in Expander Header in expanded state

This bug can be reproduced in Perspex ControlCatalog sample app.

Could you explain the issue?

So, I duplicate here new suggested style (from gitter):


GOBBLIN-2033 set unique writer output dir by appending taskAttemptId to writer output path

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-2033

Description

[ ] Here are some details about my PR, including screenshots (if applicable):
This PR allows appending taskAttemptId to writer output directory to make writer output directory unique for each task.
Context for this change is there is a chance that some corrupted files could be created when previous tasks were interrupted. To avoid moving orphan files from previous run, each task should have a unique writer output and perform a clean up upon starting.
Thus this PR is created to make sure taskOutput path is unique on for every task via appending taskAttemptId to the path.

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Unit test added:
KafkaStreamingExtractorTest.testWriteOutputDirUpdate
verified if config.WRITER_OUTPUT_DIR_UPDATE_ENABLED is set to false, there is no change to taskOutput dir
verified if config.WRITER_OUTPUT_DIR_UPDATE_ENABLED is set to true, taskAttemptId is appened to taskOutput

end to end test performed:

verified data is renamed into desired taskOutput path:

verified data is published into destination path:

verified in container log below log exists:

2024-04-02 10:01:30 PDT INFO  [StreamModelTaskRunner] org.apache.gobblin.writer.FsDataWriter  - Renaming /data/ci_parallel/tracking/streaming_parallel_test/MemberScrapingScoreEvent/.temp/taskStaging/KafkaHdfsStreamingTrackingOrcRongTest/job_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900/MemberScrapingScoreEvent/GobblinYarnTaskRunner_10/hourly/2024/04/02/09/part.task_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900_29_1712076989798_0.orc to /data/ci_parallel/tracking/streaming_parallel_test/MemberScrapingScoreEvent/.temp/taskStaging/KafkaHdfsStreamingTrackingOrcRongTest/job_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900/MemberScrapingScoreEvent/GobblinYarnTaskRunner_10/hourly/2024/04/02/09/part.task_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900_29_1712076989798_0.176316.orc
2024-04-02 10:01:30 PDT INFO  [StreamModelTaskRunner] org.apache.gobblin.writer.FsDataWriter  - Moving data from /data/ci_parallel/tracking/streaming_parallel_test/MemberScrapingScoreEvent/.temp/taskStaging/KafkaHdfsStreamingTrackingOrcRongTest/job_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900/MemberScrapingScoreEvent/GobblinYarnTaskRunner_10/hourly/2024/04/02/09/part.task_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900_29_1712076989798_0.176316.orc to /data/ci_parallel/tracking/streaming_parallel_test/MemberScrapingScoreEvent/.temp/taskOutput/KafkaHdfsStreamingTrackingOrcRongTest/job_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900/29/GobblinYarnTaskRunner_10/MemberScrapingScoreEvent/hourly/2024/04/02/09/part.task_KafkaHdfsStreamingTrackingOrcRongTest_1712076895900_29_1712076989798_0.176316.orc

Tested scenario where publisher enabled deleteOrphanFiles function, verified clean up directory is same as write output directory with helix attempt id from log:

2024-04-02 22:49:27 PDT INFO  [TaskStateModelFactory-task_thread-0] org.apache.gobblin.prototype.kafka.TimePartitionedStreamingDataPublisherWithAuditCounts  - Cleaning up garbage files in output directories from previous runs for each writer branch. numBranches=1
2024-04-02 22:49:27 PDT INFO  [TaskStateModelFactory-task_thread-0] org.apache.gobblin.prototype.kafka.TimePartitionedStreamingDataPublisherWithAuditCounts  - The writer output directory does not exist, so no clean up will be performed. writerOutputDir=/data/ci_parallel/tracking/streaming_parallel_test/MemberScrapingScoreEvent/.temp/taskOutput/KafkaHdfsStreamingTrackingOrcRongTest/job_KafkaHdfsStreamingTrackingOrcRongTest_1712123272053/31/GobblinYarnTaskRunner_10/MemberScrapingScoreEvent

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Two questions here:

Why do we try to use taskAttempId instead of one random UUID? It's still possible that same task get retried in the same container?
Why do we want to avoid removing orphan files from the previous run? Any concern related to that?

Two questions here:

Why do we try to use taskAttempId instead of one random UUID? It's still possible that same task get retried in the same container?
It is possible that same path could be reused, the orphan file removal function in the publisher will clean up the path before writing new data. This change is to fix the issue found while testing orphan file deletions that a container in the shutdown can still run even though the task has been reassigned by Helix.

Why do we want to avoid removing orphan files from the previous run? Any concern related to that?
Orphan file removal should be enabled together with this change. This change is prerequisite for orphan file removal because this change is to make sure taskOutput path is unique for each work unit.

Discussed with Zihan offline on above, we will append taskAttemptId + timestamp to the path. This way output path will be unique, and we will not require orphan file deletion.


Support progress display and a cache question

VapourSynth-RealSR-ncnn-Vulkan is great.
Hope to show progress as it is processed.
One problem is that if the path contains Chinese, the following error will be prompted, maybe the path does not support UTF-8?
Python exception: RealSR: can't open model file

Traceback (most recent call last):
  File "src\cython\vapoursynth.pyx", line 2832, in vapoursynth._vpy_evaluate
  File "src\cython\vapoursynth.pyx", line 2833, in vapoursynth._vpy_evaluate
  File "D:\CONAN\OUT\TEST\OVA7.vpy", line 15, in <module>
    video = core.rsnv.RealSR(video, tilesize_x=300, tilesize_y=300, gpu_thread=2)
  File "src\cython\vapoursynth.pyx", line 2580, in vapoursynth.Function.__call__
vapoursynth.Error: RealSR: can't open model file

By the way, are there caches generated during processing, and where are they all stored?

Maybe the path of model can't contain Chinese. Because in code std::ifstream is used to check if model exists. std::ifstream is not friendly to Chinese. (But I haven't tested it so far.)
To be honest, the cache mechanism depends on ncnn frame. Generally, VapourSynth plugins use the function filterFree() to free memory. Especially, in this plugin, we call ncnn::destroy_gpu_instance() in filterFree() to end ncnn and free cache.
Showing progress is a good idea. But I need to learn ncnn to figure out how to do it.

About the cache question, before, I am worried that there will be a lot of cache files in the system disk, but it seems to use memory to write, then there is no problem.
About the progress, thanks for your hard work.
As for the problem of Chinese paths, I tried to search the Internet for errors in reading Chinese paths with std::ifstream. There are many articles discussing this, and some solutions are also given, as follows, hope that helps, I can help with testing:
Use the _TEXT() macro to specify string constants as TCHAR* types
file.open(_TEXT("c://测试//测试文本.txt"));

Another method is to set the locale to the value of the user system first, and then restore it after using ifstream
locale::global(locale(""));
//open file
locale::global(locale("C"));

Finally, thank you again for your hard work again.


port the mv command

A port of the move command with the move_file and move_item methods pulled from nushell/nu-engine's filesystem module.  I'm not sure if there are plans to move similar functions into the engine crate at some point, but this is my first pr on the project and I didn't want to be presumptuous.

Looks good - I think the last thing is to run this through cargo clippy. Once the warnings are fixed it should be able to go green.

Okay i'm hoping i did that correctly.  This is only my second time contributing to an open source rust project and appreciate the help lol.

Looks good!


more type-safe types for zip for up to three lists.

more type-safe type TS definitions for zipping for up to three lists. I saw something similar is already done for zipWith. Anything is better than any, and the typescript compiler is smart enough to pick the most precise type definition.
I've confirmed the compiler does pick up the new type definitions in __tests/zip.ts line 28 the type of zipped, and by extracting variables in a couple other examples in that file, and all seems to work great.

Agreed, thanks for the help


New release

Could you make new release to npm? I want to have new changes about error if enableReinitialization is true.

@tomasztomys you can always install the package directly from github (master, specific branch, even specific commit).
more info:
https://stackoverflow.com/questions/17509669/how-to-install-nodejs-package-from-github-directly
https://docs.npmjs.com/cli/install

But version in package.json is still 6.3.2 so npm thinks that it's the same with local version

@tomasztomys installing things from GitHub will work even though the version key in package.json didn't change.

Does anyone know how arrayRemoveAll(form:String, field:String) works? I tried but not able to remove fieldarray. any help is appreciated

Let's just say you'll get what you want for Christmas. 🎅

a new release of redux form ;)

Look kids!! Santa came!!! v6.4.0

@erikras Hi, is there any kind of release 'schedule' ? For example, a planned release every other Friday. So that we know when we will get the fixes & features. I don't know if this will work in reality.


Using "expect.not.stringContaining" produces a "val.toAsymmetricMatcher is not a function" error

🐛 Bug Report
The example from the documentation for expectnotstringcontaingstring works when the substring isn't contained, but it gives a val.toAsymmetricMatcher is not a function error when the substring is contained. It's expected that the test should fail, but this does not seem like the expected error in this scenario.
To Reproduce
Create a file called string.test.js with the following contents.
describe('not.stringContaining', () => {
  const expected = 'are you?';

  it('matches if the actual string does not contain the expected substring', () => {
    expect('How are you?').toEqual(expect.not.stringContaining(expected));
  });
});

Then run the following.
jest

Expected behavior
The expected behavior is that this would produce an informative error about the substring being contained within the "How are you?" string when it is expected not to be.
Link to repl or repo (highly encouraged)
Here is a link to repl.it, but they're using version 22 and the error is different with that version. On v22 it is
TypeError: Cannot read property 'stringContaining' of undefined

and on v23 it is
TypeError: val.toAsymmetricMatcher is not a function

Run npx envinfo --preset jest
Paste the results here:
npx: installed 1 in 1.148s

  System:
    OS: Linux 4.9 Amazon Linux AMI 2017.09
    CPU: x64 Intel(R) Xeon(R) CPU E5-2676 v3 @ 2.40GHz
  Binaries:
    Node: 9.4.0 - ~/.nvm/versions/node/v9.4.0/bin/node
    Yarn: 1.7.0 - ~/.nvm/versions/node/v9.4.0/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v9.4.0/bin/npm
  npmPackages:
    jest: ^23.0.0 => 23.0.0

Thanks for the report! Opened up a PR for it: #6272

How to mitigate that error - TypeError: val.toAsymmetricMatcher is not a function in a custom (user defined)  matcher?


Too little information about Device Encryption

In my opinion there are very little information about the Device Encryption in general and the differences between Device Encryption and classical BitLocker encryption. It cost me a lot of time to gather all relevant information about it for a project of mine. I already made a suggestion in https://github.com/MicrosoftDocs/windows-itpro-docs/pull/4913 about which information could be relevant. Perhaps there is a way to place the information a little more centrally so that the differences between the two functions become clearer.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cde8beb2-6800-cf3c-c927-91ed2827eb6c
Version Independent ID: 7264f37a-e40a-3cd8-d28c-5b2b772eff15
Content: BitLocker (Windows 10)
Content Source: windows/security/information-protection/bitlocker/bitlocker-overview.md
Product: w10
Technology: windows
GitHub Login: @DulceMontemayor
Microsoft Alias: dolmont

New pull request regarding this topic: https://github.com/MicrosoftDocs/windows-itpro-docs/pull/6244


convert to romaji to values in pandas column

Dear Polm,
Thanks for sharing this cutlet code 👍
I would like to try it on a dataframe for some column values in Japanese. How do you insert pandas column values instead of only a text ?
Many thanks in advance !
`katsu.romaji('df['Column']`)
=> ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

Pythonely,
Morgane

Sorry but I'm going to close this. Your question has nothing to do with cutlet, it's a question about how to use pandas. I suggest you ask on Stack Overflow, though it looks like you can do something like this:
roma = [katsu.romaji(xx) for xx in df['something']]

Good luck with it.

Sorry but I'm going to close this. Your question has nothing to do with cutlet, it's a question about how to use pandas. I suggest you ask on Stack Overflow, though it looks like you can do something like this:
roma = [katsu.romaji(xx) for xx in df['something']]

Good luck with it.


Hiding Columns in Webclient causes List to be rendered incorrectly

Server Version:

Issue:

When a Column is removed from a List Page using the Column Chooser, the Data Columns are rendered incorrectly is displayed in the following animation:

Code:

This the page where the issue occurs:
`page 2013048 "NVT XD Parcel Log List"
{
PageType = List;
SourceTable = "NVT XD Parcel Log";
Caption = 'Cross Dock Parcel Log List';
ApplicationArea = All;
UsageCategory = History;
CardPageId = "NVT XD Parcel Log Card";
Editable = false;

layout
{
    area(content)
    {
        repeater(General)
        {
            field("Log No."; "Log No.")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Parcel No."; "Parcel No.")
            {
                ApplicationArea = All;
            }
            field("Action"; "Action")
            {
                ApplicationArea = All;
            }
            field("Log Datetime"; "Log Datetime")
            {
                ApplicationArea = All;
            }
            field("Log User"; "Log User")
            {
                ApplicationArea = All;
            }
            field("External Parcel Code"; "External Parcel Code")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Operational Status"; "Operational Status")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Parcel Status"; "Parcel Status")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Unit of Measure"; "Unit of Measure")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Gross Weight"; "Gross Weight")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Volume"; "Volume")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Length"; "Length")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Width"; "Width")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Height"; "Height")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Grouped on Transport Unit"; "Grouped on Transport Unit")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Ungrouped from Transport Unit"; "Ungrouped from Transport Unit")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Terminal"; "Terminal")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Placed In Type"; "Placed In Type")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Placed In"; "Placed In")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Taken From Type"; "Taken From Type")
            {
                ApplicationArea = All;
                Visible = false;
            }
            field("Taken From"; "Taken From")
            {
                ApplicationArea = All;
                Visible = false;
            }

        }
    }
}

}
`

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


'/' on the numeric pad acts like PgUp in code editor

Issue Type: Bug
I am using portable vscode install on my linux machine. I have configured some shortcuts, but even completely wiping out my keybinding.json doesn't fix the isue:
when I am in any other window than code editor and I press / on the numeric pad, it is interpreted as '/', however, when I am in the code editor, it acts as PgUp instead. The adjacent keys (numLock and *) work fine. / on the main key pad works too.
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:40:20.190Z)
OS version: Linux x64 3.10.0-693.11.6.el7.x86_64

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (16 x 3192)

GPU Status
2d_canvas: unavailable_softwareflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: unavailable_offnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarevpx_decode: unavailable_softwarewebgl: unavailable_offwebgl2: unavailable_off

Load (avg)
2, 2, 2

Memory (System)
31.26GB (11.07GB free)

Process Argv
/users/schernet/bin/VSCode-linux-x64/code training/training.code-workspace

Screen Reader
no

VM
100%

Extensions (2)

Extension
Author (truncated)
Version

cpptools
ms-
0.17.7

debug
web
0.22.0

@Serge1985
What does VS Code detect when you press the desired key combination? Please hover over the input box and take a screenshot:

This is something really weird - I even shot a video that shows my finger
typing on the keyboard: https://photos.app.goo.gl/mNHYqAeYsZ6JV5LZ6
When I type in search window, the same numpad / key is interpreted as '/',
however when I type it as keypress, it is taken as PgUp. I know it doesn't
sound sane, but that's what I see :)
Yours sincerely, Serge
On Tue, Aug 14, 2018 at 5:35 AM Alexandru Dima<EMAIL_ADDRESS>wrote:

@Serge1985 https://github.com/Serge1985
What does VS Code detect when you press the desired key combination?
Please hover over the input box and take a screenshot:
[image: keyboard-input]
https://cloud.githubusercontent.com/assets/5047891/25478333/fe31c830-2b40-11e7-865c-b2c3bb10dd75.gif
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/56269#issuecomment-412813232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoZI0ssjY3Xexp_BPoScov3izi7MLhuwks5uQpnQgaJpZM4V69vS
.

Am I seeing things correctly? You are actually on a Windows machine and use remote desktoping software to control a linux machine?
Did you take a look at https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings

Yes, you are quite right and thank you, it fixed the issue!
Yours sincerely, Serge
On Tue, Aug 14, 2018 at 9:45 AM Alexandru Dima<EMAIL_ADDRESS>wrote:

Am I seeing things correctly? You are actually on a Windows machine and
use remote desktoping software to control a linux machine?
Did you take a look at
https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/56269#issuecomment-412876032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AoZI0nF5BivELLn8AXI-XkRq5-nFHJRwks5uQtRPgaJpZM4V69vS
.


v0.2.0

After some feedback from the author, there are some improvements that can be made:

There is no need for a token to download a file, just the URL.

This is also set in the upload header response so can just get it from there
Only requires the x-password header if a password is set

As this will change the download args, this will be v0.2.0 because i'm a semver good boy.

Closed as of https://github.com/Tyrannican/waifu-vault-cli/pull/2


I don't understand the rarity selector

I don't understand this part:
// create required weights
// for each weight, call 'addRarity' with the id and from which to which element this rarity should be applied
let rarityWeights = [
addRarity('super_rare', 1, 6),
addRarity('rare', 6, 8),
addRarity('original', 8, 10)
];
Does the first 6 in this case where I tried to change it, become super rare then? But I would like to randomize which one o my total collection that is the rarest one - so it's not specifically the first mints that's gonna happen. How do I do that?

I also have this same question has anyone found a solution?

I fixed this by making the % for all rarities the same ie super rare 5% rare 15% original 80% that way regardless of what rarity is selected the outcome chance is the same this has spread the rarities out nicely across the 10k images so the last 3000 images are not stacked with rare and super rare layers
Hope that makes sense

What is the code so that you can do % instead of addRarity('super_rare', 1, 6),? Or are you putting these percentages in a different place?

One thing we are trying to do is randomize the creation of the different level of rarity for the entire picture not just the attributes. Our attributes are randomizing well, but the rarity for the entire picture goes in order based on this code section
let rarityWeights = [
addRarity('original', 1, 30),
addRarity('rare', 30, 45),
addRarity('super_rare', 45, 50)
];

What is the code so that you can do % instead of addRarity('super_rare', 1, 6),? Or are you putting these percentages in a different place?

Are you using main code if so they are at the bottom of the config.js file

I understand how to do the percentages there what i am currently stuck on is when you run the code it goes in order of rarity when creating the images. It goes from original, rare, and super_rare I was wondering if there is a way to randomize the output?

On Sep 14, 2021, at 11:38 PM, EvilShaggz @.***> wrote:
What is the code so that you can do % instead of addRarity('super_rare', 1, 6),? Or are you putting these percentages in a different place?
Are you using main code if so they are at the bottom of the config.js file
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/HashLips/generative-art-opensource/issues/101#issuecomment-919715427, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVTGJPUFQ4V3RUK7RQQSNZLUCAWL7ANCNFSM5DYDJASQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Do you have the string of code instead of the rarity 1, 6 type of setup. Because right now it stacks all rare and super rares at the end. Thank you in advance

If i have 10K
and write it like this
Superrare 1, 1000
rare 1001, 3000
original 3001, 10000
then it stacks all super rares and rares at the end of the 10K batch. Do you have the code change or code to add to have it spread out randomly when it creates a rare, super rare or original? :)

Anything for randomizing the rarity batches as @trazpz mentioned?

Same, all the rarest ones end up at the end.


Add java_home parameter for correct plugin execution #619

Pull request acceptance prerequisites:

[ ] Signed the CLA (if not already signed)
[ ] Rebased/up-to-date with base branch
[ ] Tests pass
[ ] Updated CHANGELOG.md with patch notes (if necessary)
[ ] Updated CONTRIBUTORS (if attribution is requested)

Hello, this is a contribution to being able to solve #619.
It is not the best solution, since I wanted somehow pass ALL the env variables, not just the JAVA_HOME (e.g. init_defaults hashmap).
But things start to become complex as init_defaults are merged for hiera support and a plugin is installed per node (and potentially, a different init_defaults per instance).
This is the simpler solution to let anyone using puppet agents with NO JAVA_HOME defined to run and install plugins.
I am proceeding asking for the CLA to my company.
Please review and suggest other fixes/changes on that.

Also note that in master I've yanked out buggy tests so if you merge/rebase onto master, Travis should give you a legitimate pass/fail response. 👍

I'll take a look next week!
Thanks.

Finished this in #902 👍


Bump ODC

Bumps ODC to version where deserialization issue is fixed (https://github.com/mlabs-haskell/ogmios-datum-cache/pull/109)

Do we need this for babbage as well?


Add tests

:+1: Please merge this pull request so that I can use your package on NixOS.

@RobertFischer Done! Let me know if you need me to upload to Hackage as well.


The terminal process command 'C:\Program Files\PowerShell\7-preview\pwsh.exe' failed to launch (exit code: {2})

Issue Type: Feature Request
The terminal process command 'C:\WINDOWS\system32\cmd.exe' failed to launch (exit code: {2}) I've reinstalled it multiple times along with Salesforce CLI Integration & Salesforce Extension Pack. However, it is giving the same error again & again.
System details: Windows 10
I've already tried multiple solutions that are given in GitHub repository but it hasn't fixed yet.
looking for your prompt help to fix the issue...
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T16:36:23.138Z)
OS version: Windows_NT x64 6.2.9200

Hello Tyiar> hope you are well there. Could you please help me to fix this issue on little priority, as my learning salesforce LWC and due to this issue can't proceed further in my learning path.

Hello Tyiar> hope you are well there. Could you please help me to fix this issue on little priority, as my learning for salesforce LWC has stopped due to this issue and can't proceed further on my learning path until this will not start working.

Does C:\Program Files\PowerShell\7-preview\pwsh.exe exist?
This error is normally due to some anti-virus software blocking the terminal from launching, see https://code.visualstudio.com/docs/editor/integrated-terminal#_how-do-i-fix-the-errors-connectnamedpipe-failed-windows-error-232-or-terminal-exited-with-code-x-on-windows

Yes, it is, I've downloaded this PowerShell 7 as my system was having PowerShell Version: 5.1.18362.752, so I thought maybe this older version of PowerShell creating trouble for this issue.
after uninstalling this VS code app, I have downloaded this latest version of PowerShell and thereafter I have re-installed it but still, the issue is persisted.
I was not sure how to exclude those files which are mentioned in that given link, so I have excluded the VS code file from the windows defender and checked with the issue but still, it didn't work.
now I have deleted all the created projects and tried again to run the terminal. It is opening now but I can't write anything on that, just getting dark curser and nothing happening.

Now again, I've created a project of VSCodeQuickstart and when trying to open the terminal, it is giving me the same error of "The terminal process command 'C:\Program Files\PowerShell\7-preview\pwsh.exe' failed to launch (exit code: {2})"

Can you try trace logging when opening a terminal and see what it says? https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging
Note that it prints your terminal environment which may contain sensitive information.

Sure, PFA created logs.

All those file watcher errors don't look good 😕, but they're likely unrelated to the terminal problem.
I'm expecting logs to look like this:
[2020-04-27 07:12:30.771] [renderer2] [trace] CommandService#executeCommand workbench.action.terminal.new
[2020-04-27 07:12:30.772] [renderer2] [trace] telemetry/workbenchActionExecuted {"id":"workbench.action.terminal.new","from":"keybinding"}
[2020-04-27 07:12:30.772] [renderer2] [trace] terminalInstance#ctor (id: 2) {}
[2020-04-27 07:12:30.854] [renderer2] [trace] IPty#spawn C:\Program Files\PowerShell\7\pwsh.exe [] {"name":"pwsh.exe","cwd":"E:\\GitHub\\microsoft\\vscode","env":{snip},"cols":212,"rows":22,"useConpty":true,"conptyInheritCursor":false}
[2020-04-27 07:12:31.362] [renderer2] [debug] Terminal process ready (shellProcessId: 8092)
[2020-04-27 07:12:31.364] [renderer2] [trace] IPty#resize 212 22

Hi, Tyriar> Not sure what to do and how to check these logs. However, I have good news, that I was checking about this issue and tried whatever was coming to my mind. So, I uninstalled it from Revo Uninstaller and re-installed it back, and thereafter, I excluded their folder from the windows defender. And, Same I did with Salesforce CLI (pasted below

screenshot for your reference)and you know what, it is working for me but not sure for how long it will work. Thanks for your help!

Good to hear 👍


[Suggestion] Add the ability to change the preserveAspectRatio attribute

it would be helpful in some scenarios to be able to control the preserveAspectRatio to do things like:
preserveAspectRatio="none"
It could be used as follow:
<div [inlineSVG]="'arrow.svg'" [preserveAspectRatio]="none"></div>

I think a better idea would be having a lifecycle hook so you can manipulate the SVG prior to its insertion. I'd rather not have something this specific.

Added [onSVGLoaded] in v6.2.0, which you can use to manipulate the SVG element prior to it being inserted.
(Note that it doesn't work with symbols currently)


Update WordPress.mdx to describe how to get smaller image sizes

What kind of changes does this PR include?

New or updated content

Description
Added a couple of sentences to the section on embeddable content with information on how get smaller sizes of the featured image (the code that is there gets the full size image which is often too large).

Hi @rickgregory , thanks for this contribution! I think this is a super helpful addition, but I have another idea for how to get that across:
What if we just update the code line itself to include the medium size, and then slip in a mention of that in the text:

The _embedded['wp:featuredmedia']['0'].media_details.sizes.medium.source_url property is returned, and can be used to display the featured image on each dinosuar page.

This reveals the pattern without needing to explicitly explain it. I think just having it in the URL is enough to signal to people, "Oh, I guess I could pick a different size if I wanted" and then they can read in Wordpress documentation about their sizes. We try to keep these guides as minimal on explanation as possible, and I like "showing" vs telling.
What do you think about that?

@sarah11918 - that's a good idea. I just tested to make sure that syntax allows the full image size and it do, so there's no downside to using this syntax. However, while I like show vs tell, I think noting that the size name is there is important. Otherwise we're asking the reader to infer that .medium.source_url is only one of several possible sizes. A quick "Replace .medium. with your desired image size" solves that and doesn't feel too verbose to me.  So...

The _embedded['wp:featuredmedia']['0'].media_details.sizes.medium.source_url property is returned, and can be used to display the featured image on each dinosuar page. Replace .medium. with your desired image size.

@rickgregory Sure thing! For syntax, I would use:
(Replace `medium` with your desired image size.)

But otherwise, go ahead and make that change!  :raised_hands:

All done, let me know if you need other edits.

Ooh, just a reminder to also update line 163 (GitHub won't let me suggest a change here) so that the text matches the code sample, then I think we're good! Thank you!

Doh. Done :)


[Loyalty QA] center log in button text in safari

closes: https://github.com/artsy/reaction-force/issues/103
By default, the flex-direction property is set to row which aligns the flex-items along the main (x) axis. It looks like that is what's causing the "LOG IN" text to sit to the left. I think we want to style it to haveflex-direction: column in this case.

I anticipate my last commit will fail the build because of the snap shot. How do I go about updating that?

@xtina-starr run yarn test -- -u to update snapshots.

Looks good! We can merge after updating the snapshot tests

tests are 💚  gonna go ahead and merge.


Fix behavior when no filename is given to :write.

Sorry for introducing a bug but this should fix it. (As it was if you did just ":w" the tab would be renamed to the parent directory rather than the filename.)

@lloeki I'm not sure about other purposes for it, but I know that when I used that saveAs rather than editor.saveAs Atom acted like the file wasn't saved (there was an asterisk next to the filename and you couldn't close the window without being prompted to save).

It seems '' was getting normalized to '.' which was confusing getFullPath.

So you were right @lloeki I ended up re-introducing most of the complexity you had originally, but at least now it works when no projects are open.

Don't take it bad, but I fixed the original code in 1a117bd. Thanks for your work though.


Changed get_instance() return val

When import_id_fields is empty, get_instance() should return None. Previously it would return an object if queryset contained a single object -- qs.get() with no args returns an obj for queryset of length=1.

Coverage decreased (-0.3%) to 92.196% when pulling 0648e2a554095af4d5f846f9e33acf1df50afe1f on akulakov:patch-1 into 54232db4a511cc5f0b085c6bb192c3619f27e452 on django-import-export:master.

Looks good to me. Failing test is related to https://github.com/django-import-export/django-import-export/issues/844

thanks @akulakov!


Project abandonned ?

Hi,
I was really interested about this project that seemed to be working as I wanted.
Since I installed it I encountered some issues that make it unusable for my app.

If the video is under 5 seconds, the player wont start, plus, if it's a recorded video, it crashes. I suspect this comes from the fade that is not really well made, too long, and not configurable.

The fullscreen icon, is not working, because no implementation exist yet, so this icon is just for the style but it's not suitable for app that requires to be perfect visually speaking.

Is this project still maintained ? If not could you update your readme to warn people that this product is delivered as user's own risk because no further debug or fix will be done.

I would be happy to take this on.

I've been a little bit disconnected from react native world. But this is not abandoned at all!
I'm happy to see that it is pretty popular.
Time to update the package :)


Maximum execution time of 30 seconds exceeded in streams\src\Stream.php on line 122

I am getting this error when I run this snippet. Even for 15 requests it is really slow takes around 24 secs. I see the output but it times out.
<?php
// index.php localhost
echo (empty($_GET['n']) ? 'Test' : $_GET['n']);

<?php
require '../vendor/autoload.php';
use GuzzleHttp\Pool;
use GuzzleHttp\Event\ErrorEvent;
use GuzzleHttp\Event\CompleteEvent;

function test()
{
    $client = new \GuzzleHttp\Client();

    $i = 1;
    $request = [];

    while ($i != 24) {
        $request[] = $client->createRequest('GET', 'http://localhost/?n='.$i);
        $i++;
    }

    return Pool::batch($client, $request);
}

$results = test();
foreach ($results as $result){
  echo $result->getBody() . '<br>';
}
//die(); // If I uncomment this out it works... Obviously not the right way to resolve.

You need to increase the maximum allowed execution time:

http://php.net/manual/en/function.set-time-limit.php
http://php.net/manual/en/info.configuration.php#ini.max-execution-time

I am aware that I can extend the execution time. But I think it is still bit slow than it should be normally. Also I did bit testing with sync and async mode via CLI.
ASYNC
<?php
require '../vendor/autoload.php';
use GuzzleHttp\Pool;
use GuzzleHttp\Event\ErrorEvent;
use GuzzleHttp\Event\CompleteEvent;

$time_start = microtime(true);
$client = new \GuzzleHttp\Client();
$request = $client->createRequest('GET', 'http://localhost/?n=1', ['future' => true]);
$client->send($request)->then(function ($response) use ($time_start) {
       $time_end = microtime(true);
       $time = $time_end - $time_start;
       echo "Process took $time seconds\n";
});

SYNC
<?php
require '../vendor/autoload.php';
use GuzzleHttp\Pool;
use GuzzleHttp\Event\ErrorEvent;
use GuzzleHttp\Event\CompleteEvent;

$time_start = microtime(true);

$client = new GuzzleHttp\Client();
$response = $client->get('http://localhost/?n=1');
$time_end = microtime(true);
$time = $time_end - $time_start;
echo "Process took $time seconds\n";

I noticed that SYNC is always faster. Not sure why? Anyway I do not think it is not a bug. You can close this one.

If you're using the curl handlers (they're used by default), then the curl_multi powered handler used for async requests might need you to turn off the Nagle algorithm when connecting to extremely low latency hosts (e..g., localhost). See http://curl.haxx.se/libcurl/c/CURLOPT_TCP_NODELAY.html
Here's my exchange on the cURL mailing list regarding a similar slowness I observed: http://comments.gmane.org/gmane.comp.web.curl.library/39947


iKey is not read from appsettings.json

If you are reporting bug/issue, please provide detailed Repro instructions.
Repro Steps

VS->New WebApp .net core

Add the following to appsettings.json
{
"Logging": {
"IncludeScopes": false,
"Debug": {
"LogLevel": {
"Default": "Warning"
}
},
"Console": {
"LogLevel": {
"Default": "Warning"
}
}
},
"ApplicationInsights": {
"InstrumentationKey": "11111111-2222-3333-4444-555555555555"
}
}

Enable AI either by using UseApplicationInsights() or AddApplicationInsightsTelemetry(). (Do not pass ikey as argument)

Start app (without VS Debugger), and put load.

Actual Behavior

Ikey is not read, and hency no telemetry sent.
(Running the same from VS Debugger - ikey is read from appsettings.json)

Expected Behavior
Ikey should be read from appsettings.json
Version Info
SDK Version : 2.2
.NET Version :
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) : VS
OS : Windows
Hosting Info (IIS/Azure WebApps/ etc) : Self

Originally reported here:
https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/585#issuecomment-362245016

set APPINSIGHTS_INSTRUMENTATIONKEY=ikey  - this approach still works though.

Closed with #670


Releases 1.11 and 1.11.1 don't include peview.exe.

Releases 1.11 and 1.11.1 don't include peview.exe.  Specifically:
1.11\Dependencies_x64_Debug.zip
1.11\Dependencies_x64_Release.zip
1.11\Dependencies_x86_Debug.zip
1.11\Dependencies_x86_Release.zip
1.11.1\Dependencies_x64_Debug.zip
1.11.1\Dependencies_x64_Release.zip
1.11.1\Dependencies_x86_Debug.zip
1.11.1\Dependencies_x86_Release.zip

I try to put the preview.exe get from an old version into the Dependencies' directory, and it works.

I got a newer peview.exe from https://systeminformer.sourceforge.io/downloads.php


Source organization

Following #34: splitting the acquisition file into a package to avoid further mixing of framework code and algorithm implementations.
This PR does not change any import paths.

Codecov Report

Merging #46 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   99.72%   99.73%   +<.01%
==========================================
  Files           9       14       +5
  Lines         728      752      +24
==========================================
+ Hits          726      750      +24
  Misses          2        2

Impacted Files
Coverage Δ

GPflowOpt/acquisition/__init__.py
100% <100%> (ø)

GPflowOpt/acquisition/poi.py
100% <100%> (ø)

GPflowOpt/acquisition/ei.py
100% <100%> (ø)

GPflowOpt/acquisition/pof.py
100% <100%> (ø)

GPflowOpt/acquisition/acquisition.py
100% <100%> (ø)

GPflowOpt/acquisition/lcb.py
100% <100%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0222231...3d10f0b. Read the comment docs.


Add a Query Rule to directus_roles

Describe the Improvement
Hey there, not sure if this was already considered in the past, but when using the extension I find my self needing to do a little tweak all the time, it's not a big deal since one have to modify the config file anyway, but I think it would be a good addition to the starter to exclude the "Administrator" Role from syncing, found myself often locked out of directus because it synced and lost the relation to the admin user because of that.

As far as I can see, it's located in the install/schema-sync folder of the project (not sure if i should open a pull request for that minor change, and if it's even wanted to be that way).
Thanks for considering, and thanks for the awesome extension, works really great!! :-)
Cheers

Hi, thanks for your input. We have actually considered this already and it turns out there are people on both sides of the isle on this one. So in the spirit of sitting on the fence I decided to just not include to much default filter rules, and let those that don't want it exclude it like you have done so yourself.
Once excluding the Admin role becomes 80% of the use cases we can change it, but as of now it is 50/50