Error code 1505 in pgp decryption

I have a file that I encrypted from the command line using "keybase pgp encrypt myname -i myfile.7z -o myfile.7z.pgp"
I try to decrypt with "keybase pgp decrypt -i myfile.7z.pgp -o myfile.7z" and I get:
- ERROR (code 1505)

This is on Windows. Most of my pgp encrypted files decrypt just fine, but I have a couple that are giving me this error message. What does this error code mean? How do I fix the file so that it will decrypt correctly?

Have you tried logging in again?
https://github.com/keybase/client/issues/11822
Also (as a habit) I would decrypt files after encrypting to verify it all worked in the first place.

I did test the file in the past. I have a suspicion the error has something to do with line ending format being changed as the file moved from one file system to another. I'd really like to know what "ERROR (code 1505)" indicates. Is there some definitive list of what the different error codes mean?

You may have found the issue then. How are you transferring the files? I'd open one of the files in a hex/text editor and have a look at it, see if you have a series of CRLF or just LF characters in the files that don't work, v.s. the ones that do work.


chore: refactor api error handling

:tada: This PR is included in version 1.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


More verbose debug messages?

Hi, I'm running the build and notarization routine of a mac electron app on a Go CI and not long ago it has started failing the notarization step (it worked previously)
The only debug message I get is
Error: Failed to upload app to Apples notarization servers

2019-07-22 14:37:30.213 go-agent[23269:316324] *** Error: Unable to validate your application. The application you have selected does not exist.

    at /go-agent-01/pipelines/app/node_modules/electron-notarize/src/index.ts:76:13

At the moment I'm not sure if it's some electron-notarize problem or go-agent problem.
Maybe more verbose error messages would help here?
What do you guys think?

Sorry, apparently this was some problem with apple id account.
But my question remains - is possible to display more verbose errors? Something beside Error: Failed to upload app to Apples notarization servers
Thanks!

I agree, it would be great if there was an option to configure electron-notarize to use the --verbose flag when notarizing

@sergek I'm running into the same bug as you above, what was the issue with your apple id account? I checked my contracts through https://appstoreconnect.apple.com/agreements/#/ and they're all signed. The only thing I don't have done is set up "Set Up Tax, Banking, and Contacts" but since we're not making a paid app, this shouldn't matter right? I have the forms signed for paid apps, just not the tax and banking section.

I think there's a delay between signing the contracts and being able to notarize it. I ran the exact same command  a while later without changing a thing in our code and I was able to notarize the app.

one thing you can do is add process.env.DEBUG = 'electron-notarize' before  const { notarize } = require('electron-notarize')

A lot of these error messages come from notarytool / altool.  More information is normally sent to you in an email, we have no control over this as it's all apples tooling we just shell out to


Update Scala to 2.12

Currently OpenWhisk uses Scala 2.11.11. We should switch to Scala 2.12.6 which is current latest stable release. See here for details on all changes.
This change would require some coordination as we would need to move all other modules to move to Scala 2.12 at same time
TODO

[x] - mesos-actor needs to have a version based on 2.12
[ ] - Create PR for all other modules which depend on core module

Scala 2.12.7 provides a 10% speed improvement

Scala 2.12.7 is now available, bringing another 10% improvement in compiler performance, markdown tables in Scaladoc, improved Java 11 support, and Spark 2.4 compatibility!

Following repos would need to be modified

[ ] incubator-openwhisk-runtime-java

[ ] incubator-openwhisk-runtime-swift

[ ] incubator-openwhisk-runtime-php

[ ] incubator-openwhisk-runtime-nodejs

[ ] incubator-openwhisk-runtime-python

[ ] incubator-openwhisk-runtime-docker

[ ] incubator-openwhisk-runtime-ruby

[ ] incubator-openwhisk-runtime-ballerina

[ ] incubator-openwhisk-catalog

[ ] incubator-openwhisk-cli

[ ] incubator-openwhisk-package-deploy

[ ] incubator-openwhisk-package-alarms

[ ] incubator-openwhisk-package-cloudant

[ ] incubator-openwhisk-package-kafka

All PRs now merged!


Name/Mac generation and libcontainer dep removal

Modified Mac address generation to match current standard
Moved GenerateRandomName from libcontainer and removed the dependancy.
Reduced entropy loop to 3 attempts.

Signed-off-by: Brent Salisbury<EMAIL_ADDRESS>

LGTM

LGTM


Negate some ifs to unindent the code

This PR fixes nothing

It seems like that For some reason Firefox (for playwright) failed to install on MacOS because some disconnection problem, If someone can rerun the tests it would be great

Thanks for your PR! I appreciate your effort. While I agree that the nesting should be reduced somehow in this code, I don't think your change makes the code more readable.
Early return usually indicates a happy path. In this case, the early returns you added would indicate an happy path in which both render data is set and line count > 0 is true. I'm not sure that this path is obviously a happy one and that it is obvious to a reader what an early return skips, especially as there are side effects.


When creating a post in a chat room, automatically update last read post id to new post

Do this on back-end or front-end, or maybe both? So handlePostVisible doesn't need to be called (and it's erroring our right now)

this is fixed I believe


[FAB-19742] Add channel info provider to enable ledger to query all channel configs

Signed-off-by: Wenjian Qiao<EMAIL_ADDRESS>Type of change

Improvement (improvement to code, performance, etc)

Description
Implement ChannelInfoProvider interface to enable ledger components to retrieve
all channel configs (current and previous channel configs). The interface will
be used for checkpoint snapshot support and removing channel-specific couch dbs.
Additional details
Currently the ChannelInfoProvider interface returns the organization MSPIDs for all the
channel configs so that we can get all MSPIDs and construct the implicit collection names. This is needed for creating checkpoint snapshots and removing channel-specific couch dbs. This interface will be used by privacyenabledstate.NewDBProvider to avoid circular dependency.
Related issues
https://jira.hyperledger.org/browse/FAB-17942
https://jira.hyperledger.org/browse/FAB-17787

@cendhu, @manish-sethi Thank you. I have addressed all the comments. Please review again.

Hit https://jira.hyperledger.org/browse/FAB-16233 flake.

/ci-run

Thanks @wenjianqiao - LGTM. I can merge this one now. However, I would suggest to add a test that covers the error paths as well. Some of them may be difficult, but good to cover that can be.


Update jar list to skip TLD

Fixes https://github.com/wso2/product-is/issues/11096

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Darshana Gunawardana seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Darshana Gunawardana seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Snyk] Upgrade html-snapshots from 0.17.2 to 0.17.8

Snyk has created this PR to upgrade html-snapshots from 0.17.2 to 0.17.8.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 2 versions ahead of your current version.
The recommended version was released a month ago, on 2021-02-11.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Command Injection SNYK-JS-LODASH-1040724
467/1000  Why? Proof of Concept exploit, CVSS 7.2
Proof of Concept

Regular Expression Denial of Service (ReDoS) SNYK-JS-LODASH-1018905
467/1000  Why? Proof of Concept exploit, CVSS 7.2
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Release notes

Package name: html-snapshots

0.17.8 - 2021-02-11security update dependency minimums

0.17.7 - 2021-02-11simplify async/exists, add vanilla html-snapshots test

0.17.2 - 2020-05-14update async-lock 1.2.4

    from html-snapshots GitHub release notes

Commit messages

Package name: html-snapshots

47bc2f4 @ 0.17.8, update dependency minimums
e641cfc @ 0.17.7, simplify async/exists, add vanilla html-snapshots test
8651c85 add a vanilla invocation as the first test
0046daf remove reference to node.fs.exists and simplify
96977a8 Undo last commit
accbab1 Stop deferring killSpawnedProcesses
bd5a48a @ 0.17.6, favor fs.access over fs.stat for file test
153c4f8 rename coverage script to standard test:cover
2e0e174 Merge branch 'master' of https://github.com/localnerve/html-snapshots
1ec4682 @ 0.17.4 - update deps, tests, workflow, copyright
1476e7c remove fs.exists from tests
c46a006 fix typo in lint command
a4551e8 copyright update
1c87f37 add github workflow action, update deps
600d489 rename license file for easier management
b7702c0 update examples

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Coverage remained the same at 98.02% when pulling 64af7be90753f4497399dfdcf95584ac2157d05c on snyk-upgrade-95c5241b943d6da5e8fafc1b79213d20 into 7221b01d3b54f3049632871581860210c896ee9c on master.

Coverage remained the same at 98.02% when pulling 64af7be90753f4497399dfdcf95584ac2157d05c on snyk-upgrade-95c5241b943d6da5e8fafc1b79213d20 into 7221b01d3b54f3049632871581860210c896ee9c on master.


Compiler event subscribers

In this PR we introduce the low-level API for Subscribers and Renderers.
A Subscriber listens to compiler events and produces CodeEnhancements. A Renderer applies CodeEnhancements from many subscribers to source code.

@armiol, PTAL again.


Wrong container image

Hi,
When running the ARM file the execution failed because of the wrong container image.
It should be mcr.microsoft.com/azuredocs/aci-helloworld rather than microsoft/aci-helloworld:latest
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7bde2eab-46e1-c7da-9efb-5c0cdd52603a
Version Independent ID: d2bffaed-46cb-9e6c-7893-67a2ebe3fc0d
Content: Mount gitRepo volume to container group - Azure Container Instances
Content Source: articles/container-instances/container-instances-volume-gitrepo.md
Service: container-instances
GitHub Login: @tomvcassidy
Microsoft Alias: tomcassidy

@anhquan99
Thanks for your feedback! We will investigate and update as appropriate.

@anhquan99
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Hi @anhquan99 ! Thanks for the feedback. The change has been merged as of PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/271623 and the changes will be published later today.
If you find any other issues in the docs, please let us know!
#please-close


docs: add Electron 30 blog post

This PR adds a new blog post for Electron 30. @electron/wg-releases, @electron/wg-outreach
Merge target: April 16th, after 30.0.0 releases.
⚠ Do not merge until the following are completed ⚠

[x]   update node, v8 and chromium versions from final chrome roll under Stack Changes section
[x]   edit link for M124 "New In Chrome" blog post
[x]   add a few bullets for New Features section
[x]   add any missing items in Breaking Changes section
[x]   update End of Support

Note: The "Check Blog links" job is going to fail until the Chrome 122 announcement blog comes out, a fail there is expected until about Tuesday

Changelog say, that BaseView is implemented in v29, but isn't truth.


React Content Query WebPart - With Metadata Field

Category

[ ] Question
[X] Bug
[ ] Enhancement

Hi...
I have one Environment with Sharepoint 2016 On-premises with latest CU.
In my site, i have one library with metadata fields... and if use React Content Query, occur this error...

This error An error occured while loading fields : Bad Request is beacause request a API /es/_api/web/lists/GetByTitle('Páginas')/Fields?$select=InternalName,Title,TypeAsString&$orderby=Title fails.

This error, only occur if i have a Metadata Field in Library... If delete field works.
In post in Postman its the same the Content Query Webpart.
I believe that problem is post use application/json;odata.metadata=minimal

If anyone can help me.. :-D
Thanks !!!

@marcelaopimenta sorry for the delay I just saw this issue. What do you mean when you say that the error only occurs when there's a "metadata" field, you mean a "Managed Metada" field as in a "Taxonomy" field? There must be something else with your list because the WebPart does support Taxonomy fields.
It looks weird because as you pointed out, the only thing the WebPart does it a request to the specified URL
/es/_api/web/lists/GetByTitle('Páginas')/Fields?$select=InternalName,Title,TypeAsString&$orderby=Title
And that request should work no matter what kind of field you have in your list...What happens if you put the URL directly in the browser, does it work or you get the same error?

Yes, is a Taxonomy field. I have one version older because some things customized.
But, one thing is certain, the problem is not from SPFX or the WebPart, the problem is from SharePoint 2016 OnPremises.
I created the same environment in a SharePoint Online and it worked correctly.

In Sharepoint 2016 On Premises dont work
/_api/web/lists(guid'{1}')/Fields
/_api/web/GetByID(guid'{1}')/Fields
/_api/web/GetByTitle('{1}')/Fields
if you have a Taxonomy Field and use the Accept application/json;odata.metadata=minimal

Yeah that's what I was scared of, because it is a simple REST request there is nothing fancy about it. Out of curiosity, could you use SharePoint Manager to extract the XML definition of the field and paste it here? I wonder if it's not a problem with the specific Taxonomy field that you added to the list, maybe in its name format or something like that.
Is it a field that you deployed or it's a regular field created by the UI?

In my project is an deployed field. But I got to create a new publishing site without data, went into the page library and added a new metadata field in a new TermSet, also created via interface.
I also created sites in English and Spanish... Same faults.

Interesting, what kind of "display name" did you specify when creating the field from the UI? Because when creating fields via the UI, SharePoint builds the internal name of the column using the specified display name, replacing spaces by encodings like x0020x and stuff like that. Did you try creating the column with a regular name without any space or special character at all?
Otherwise it does look like a bug in SharePoint 2016, I have no SP2016 tenant to test on, but if you find a successfull way to execute a GET request with Postman to the problematic endpoint that works for both SP2016 and SPOnline, let me know, I will add the workaround in the project 👍

Hi Simon!
The field calls Teste very simple name...
If i post with:
odata-version: 3.0
Accept: application/json;odata=verbose;charset=utf-8
Content-Type: application/json;odata=verbose;charset=utf-8
Works fine!

What changes is the return structure of json, does not use the json light format, because it is verbose now.
if you can create this workaround I will be grateful.
Thanks!

Can you make it work with a GET? Because there is no need to do a POST for getting information. Also, Im am not sure what is the difference between the actual code and the POST you just did, these should be the default settings used by SPFx
odata-version: 3.0
Accept: application/json;odata=verbose;charset=utf-8
Content-Type: application/json;odata=verbose;charset=utf-8

I messed up, it's a GET and not a POST.
Sharepoint Framework have two configurations in sp-http
ODATA V3
Content-Type: application/json;odata=verbose;charset=utf-8
Accept: application/json
ODATA V4
Content-Type: application/json;charset=utf-8
Accept: application/json;odata.metadata=minimal
Today, your component using V4... but even if we use V3, it does not work, because only works if using application/json;;odata=verbose;charset=utf-8

Oh I see, you can try specifying your own headers to the spHttpClient, since I don't have access to an SP2016 farm right now, let me know if you are able to specify the headers and make it work. If you do find a workaround with custom headers, I could test it for SPO and integrate it in the solution.
Thanks!

Hi Simon! Thanks for help! Its Works now!!!!! :-D
In listservice.ts on method getListFields I have added the following code in getlistfields method. I check if Environment is Onpremises and added custom headers.
let options: ISPHttpClientOptions;
if (Environment.type == EnvironmentType.ClassicSharePoint) {
    options = { headers: { 'odata-version': '3.0', 'Content-Type': 'application/json;odata=verbose;charset=utf-8', 'Accept': 'application/json;odata=verbose;charset=utf-8' } };
      }

Change the spHttpClient.Get call for use options
this.spHttpClient.get(endpoint, SPHttpClient.configurations.v1, options).then((response: SPHttpClientResponse) => {
				if(response.ok) {
					resolve(response.json());
				}
				else {
					reject(response);
				}
			})
			.catch((error) => { reject(error); });
        });

In methods getFilterFields, getViewFieldsChecklistItems, i changed this point:
   let fields: any[];
              if (Environment.type == EnvironmentType.ClassicSharePoint) {
                fields = data.d.results;
              }
              else {
                fields = data.value;
              }

In Method getOrderByOptions i changed this point:
let sortableFields: any[];
 if (Environment.type == EnvironmentType.ClassicSharePoint) {
       sortableFields = data.d.results;
 }
 else {
       sortableFields = data.value;
 }
 sortableFields.filter((field) => { return field.Sortable == true; });

Good job, I will make sure to implement this is the official version. Meanwhile, I strongly suggest you to append all your changes to the latest version because at least two problems have been fixed since then  :

Multiple filters loosing their orders in IE thus messing the query results
Some webs were not appearing when selecting a site based on tenant configurations

Thanks again!


I can't find the compare_methylation.py script and I can't download the sample data

--2023-07-25 20:11:51--  http://s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz
Resolving s3.climb.ac.uk (s3.climb.ac.uk)... <IP_ADDRESS>
Connecting to s3.climb.ac.uk (s3.climb.ac.uk)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz [following]
--2023-07-25 20:11:51--  https://s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz
Connecting to s3.climb.ac.uk (s3.climb.ac.uk)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2023-07-25 20:11:52 ERROR 404: Not Found.

The script and example data can be found in the following bundle:
warwick.s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz

Issue reference:
https://github.com/jts/nanopolish/issues/1069

There is only sample data in this bundle, and there is no script, please check it again, trouble

Hi @lanyunxin,
I just re-downloaded and unarchived the file and the script is in the directory:
$ ls -lah methylation_example/compare_methylation.py
-rwxr-x--x  1 user  staff   2.9K 14 May  2018 methylation_example/compare_methylation.py
$ tree -L 1 methylation_example
methylation_example
├── albacore_output.fastq
├── bisulfite.ENCFF835NTC.example.tsv
├── compare_methylation.py
├── fast5_files
└── reference.fasta

Note that I used both wget and curl to download the file.  Here are the specific commands I used to download and unarchive:
Using wget
$ wget warwick.s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz
$ tar xvfz methylation_example.tar.gz

Using curl:
$ curl -O warwick.s3.climb.ac.uk/nanopolish_tutorial/methylation_example.tar.gz
$ tar xvfz methylation_example.tar.gz

Can you send me the script directly as I really didn't find the script in the sample data

While the script should be in the root of the extracted methylation_example directory,
I have submitted a PR to include the compare_methylation.py script as part of nanpolish: https://github.com/jts/nanopolish/pull/1099


HttpContextExtensions.GetIdentityServerIssuerUri lower case the URL

This GetIdentityServerIssuerUri calls the ToLowerInvariant to return lower case URL
        public static string GetIdentityServerIssuerUri(this HttpContext context)
        {
            if (context == null) throw new ArgumentNullException(nameof(context));

            // if they've explicitly configured a URI then use it,
            // otherwise dynamically calculate it
            var options = context.RequestServices.GetRequiredService<IdentityServerOptions>();
            var uri = options.IssuerUri;
            if (uri.IsMissing())
            {
                uri = context.GetIdentityServerBaseUrl();
                if (uri.EndsWith("/")) uri = uri.Substring(0, uri.Length - 1);
                uri = uri.ToLowerInvariant();
            }

            return uri;
        }

I set up the IS4 service name with mixed case (e.g. MyIS)
When it browse the discovery end point, only the issuer field returns all lower case url.  The other URL shows the mixed case:
http://myserver/MyIS/.well-known/openid-configuration
{
issuer: "http://myserver/myis",
jwks_uri: "http://myserver/MyIS/.well-known/openid-configuration/jwks",
authorization_endpoint: "http://myserver/MyIS/connect/authorize",
token_endpoint: "http://myserver/MyIS/connect/token",
userinfo_endpoint: "http://myserver/MyIS/connect/userinfo",
end_session_endpoint: "http://myserver/MyIS/connect/endsession",
check_session_iframe: "http://myserver/MyIS/connect/checksession",
revocation_endpoint: "http://myserver/MyIS/connect/revocation",
introspection_endpoint: "http://myserver/MyIS/connect/introspect",
The ValidateIssuer function in the Microsoft.IdentityModel.Tokens.Validators validate the issuer case insensitively so my token is treated as invalid and I have to explicitly set the TokenValidationParameters.ValidIssuer to lower case to make them matched.
            if (string.Equals(validationParameters.ValidIssuer, issuer, StringComparison.Ordinal))
            {
                IdentityModelEventSource.Logger.WriteInformation(LogMessages.IDX10236, issuer);
                return issuer;
            }

Can you remove this line?  Don't know why the issuer URL need to be lower case?
 uri = uri.ToLowerInvariant();

I just double check my JWT token, its "iss" is really all lower case.    I think it is because the DefaultTokenService.cs is calling the same GetIdentityServerIssuerUri to create the Issuer.
My token validation fails because I don't set the Issuer value returned from the Discovery Endpoint to the TokenValidationParameters.ValidIssuer.  Instead, I set it by a config value.  I think I do it wrong.
According to the spec, the "iss" value is a case-sensitive string containing a StringOrURI value.   I still think it is not a good idea to force it to lower case when the comparison is case sensitive.
If the token creation and Discovey endpoint both calls that same GetIdentityServerIssuerUri, then the "Iss" in the JWT token and the one set to the TokenValidationParameters.ValidIssuer will be the same no matter if it is lower case or not.
If it is by design, you can close this issue.

It's by design - to minimize validation problems based on casing. IIS seems to be a bit special sometimes when it comes to that...

I just find out a real issue.
                var discoveryClient = new DiscoveryClient("http://myserver/MyIS/");
                var disco = await discoveryClient.GetAsync();

DiscoveryResponse will return this error:
                var isValid = ValidateIssuerName(Issuer.RemoveTrailingSlash(), policy.Authority.RemoveTrailingSlash());
                if (!isValid) return "Issuer name does not match authority: " + Issuer;

My workaround is to pass the ToLowerInvariant authority url to the DiscoveryClient constructor.
I think it can fix the DiscoveryClient.ParseUrl to lower case the Authority.  But it needs to check if it has similar mismatched Authority issues in other classes.
You may consider to change the "demo.identityserver.io" to mixed case site to see if the DiscoveryClient unit test pass.
Could you please explain what is the special cases of IIS you mean?

I think this is no good behavior. My identity service is running on http://localhost:19081/MyApp/IdentityService  and this URL is case sensitive, so i need to use exactly this url as authority. But Identity server in discovery document returns lowered issuer- "issuer":"http://localhost:19081/myapp/identityservice" and IdentityModel's DiscoveryClient fails validating it.
var disco = new DiscoveryClient("http://localhost:19081/MyApp/IdentityService"); var doc = await disco.GetAsync();  //Issuer name does not match authority: http://localhost:19081/myapp/identityservice
So either Identity Server should not lowercase issuer, either DiscoveryClient should do the same.
Or maybe only domain name should be lowered?

If this breaks because of the casing, I agree that this is not ideal. This is what we tried to work around with by lower-casing.
Why do you setup your vdirs in mixed case in the first place?

I'm developing azure service fabric application and identity server runs behind service fabric's reverse proxy. So idenity server's external url is based on my SF application name and serviCe type name that i given for identity serVer.
At this moment I was able to workaround this by turning of DiscoveryClient's issuer validation policy,
           var disco = new DiscoveryClient("http://localhost:19081/MyApp/IdentityService");             disco.Policy.RequireHttps = false;             disco.Policy.ValidateIssuerName = false;
but it would be nice to have method to specify correct endpoint on discoveryclient or control identityserver's "lowercasing" behavior.
I could add this and make PR if this solution is OK?

@Soarc , I think you can do this as workaround for the DiscoveryClient
var disco = new DiscoveryClient("http://localhost:19081/MyApp/IdentityService".ToLowerInvariant());
@leastprivilege , for your question why setup the vdirs in mixed case.
Firstly, the specification allows mixed case so we test this case.
Secondly, it is not just the vdirs, but the host name in the URL too.   We cannot control what our customer uses as their hostname.
Thirdly, if you assume that all authority URL is in lower case, then  that  uri = uri.ToLowerInvariant() is an unnecessary call.   If this assumption is wrong, then we need to support mixed case URL.
Could you please show some codes to explain what it is trying to solve?  So far, you just say it is trying to solve some special cases of IIS, but I still don't get what the special cases are.

@kevinlo This will not work, because reverse proxy is case sensitive and will return 404 for lowered
http://localhost:19081/MyApp/IdentityService/.well-known/openid-configuration url.

@Soarc , how are this?

 var disco = new DiscoveryClient("http://localhost:19081/MyApp/IdentityService");
disco.Authority = disco.Authority.ToLowerInvariant();
var disco = await discoveryClient.GetAsync();

From the DiscoveryClient.cs, the Policy.Authority is set at the GetAsync call and DiscoveryResponse uses that Policy.Authority to validate the issuer.  If it lower case the Authoity before the GetAsync call, it should work.    But I have not test it myself, just base on reading the codes:
        public async Task<DiscoveryResponse> GetAsync(CancellationToken cancellationToken = default(CancellationToken))
        {
            Policy.Authority = Authority;

@kevinlo this will not compile. DiscoveryClient's Authority property does not have public setter.
either setting disco.Policy.Authority will not work, because it's value will reset after disco.GetAsync() call.

@Soarc You are right both Authority and Url are read only.  I did not check that.  :(
The constructor of the DiscoveryClient has the HttpMessageHandler innerHandler parameter.
Do you think you can create a HttpClientHandler derived class, pass the lower case url to the DiscoveryClient for the Authority and override the SendAsync to correct the request url with the one with right case for the reverse proxy?
    public class HttpClientHandlerProxy : HttpClientHandler
    {
        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request,
            CancellationToken cancellationToken)
        {
            // Replace the request.RequestUri with the one with correct case
            return base.SendAsync(request, cancellationToken);
        }
    }

This may be ugly workaround and that is the only one I can think of.

It es required to send request to CORRECT url or 404 response will be received. So this will not work.
If You really want to check issuer You can do it manually.

            var authority = "http://localhost:19081/PigeonApplication/IdentityService";
            var disco = new DiscoveryClient(authority);

            disco.Policy.RequireHttps = false;
            disco.Policy.ValidateIssuerName = false;

            var doc = await disco.GetAsync();
            if (doc.Issuer != authority.ToLowerInvariant())
                throw new Exception("Issuer is not valid");

My question is about adding new behavior to IdetityServer4, not about workaround this. So i wont to know @leastprivilege 's opinion about adding configuration to allow controlling issuer name creation.

We'll discuss it.

We added an option in DiscoveryClient to ignore case. Will be published soon.

Generally speaking - when you configure the issuer name statically for validation - you need to use whatever issuer is set in the discovery document as the issuer and not the IIS vdir name (with its weird casing behavior).

This is great! Thank you.
Yes, but untill this moment we havn't way to set it :)

I published a new version of IdentityModel that includes DiscoveryClient. This allows you to set the comparison mode on the DiscoveryPolicy.

Add this DiscoveryClient issue for reference.


refactor: remove denom params from GetFXMetaData

Summary by CodeRabbit

Refactor

Simplified the metadata retrieval process across various functions by removing the denomination parameter, now using a default denomination.

Tests

Updated tests to align with the new metadata retrieval approach, ensuring consistency and reliability in test scenarios.

mg


REF: Method/Visualizer -> Action

Refactored qiime.sdk.Method and qiime.sdk.Visualizer, which previously contained a ton of duplicated code. The classes were also monolithic.
The new design removes Method and Visualizer classes in favor of a general Action class, which wraps a Method/VisualizerCallable. The Callable wraps an appropriate Signature type and is responsible for synchronous/asynchronous execution (including pickling). from_function/from_markdown now defer to the relevant components for processing these sources. Plugin method/visualizer registration acts as a factory that builds an appropriate Action and registers it with the framework.

Group-reviewed by @gregcaporaso, @ebolyen, @thermokarst, and @jakereps.

@ebolyen ready for final review/merge!

Added qiime.plugin.Plugin.actions property, which returns a read-only dict of all registered Actions.

Added qiime.core.callable.Results "namedtuple" class and extensive unit tests.

@ebolyen @thermokarst this is ready for final review. I've included a temporary commit with the changes I made to address review comments. Let me know if this is GTG and I'll squash commits.
Example of the new repr (includes a fixed width field column!):
Results (name = value)
------------------------------------------------------------------------------------------
a      = <artifact: SampleData[AlphaDiversity] uuid: 546f3da3-06a0-4f99-a8dd-c9929bf303ec>
bcdefg = <artifact: SampleData[AlphaDiversity] uuid: 546f3da3-06a0-4f99-a8dd-c9929bf303ec>
hi     = <artifact: SampleData[AlphaDiversity] uuid: 546f3da3-06a0-4f99-a8dd-c9929bf303ec>

@jairideout looks good to me!

Lovin' the new repr. Looks great to me! Thanks for all your hard work on this one.

🎉 🎉 🎉 🎉 🎉 🎉  HUZZAH!!! 🎉 🎉 🎉 🎉 🎉 🎉
Thanks @ebolyen, @thermokarst, @jakereps, and @gregcaporaso for reviewing this monster PR and for all your helpful comments!

Awesome! Nice work @jairideout!


new release

@chrzyki some new commends have been included into this repository, could you make a new release of this repository?

Ah, is it possible to have a zenodo doi, too?

Sure, I'll do this in the next hour.

@xrotwang Is it okay if I release this now (minor?) or should I wait for anything else? I'll also fix any buildbot warnings before that if that's okay.

sorry for confusion. Can you please give me some time, so I can add the information on the commands that we added there?
this is a general question:
We added commands, for our workflow paper, they are not releated to the repository. But we thought it would be useful. yet we should explain them in the NOTES.md
I would like to do that before having a minor release.

Sure, no problem. :) Just ping me when you're ready.

done now, will need a re-running of the cldfbench.

in the NOTES.md, the dots are missing. Can I edit it?

Yes, please do so.

I made some changes in the NOTES.md, the first command line is cldfbench chenhmongmien.check_structure
and the rest of the command lines are all correct.
The outputs are all in a workflow folder.

Okay, I'll go ahead and rebuild & release then?

Yes, fine by me!

Done: https://github.com/lexibank/chenhmongmien/releases/tag/v2.1.0
I've also updated the Zenodo record's metadata.

thank you!


Refactor the utils library into a common folder that can be used by both tests and benchmarks

Removes the sycl_blas dependency from clblas benchmarks (reduces compilation time of clblas benchmarks)
Make a common library of utilities that both tests and benchmarks can use

@ProGTX @CodeplayBen I had to move the concatenate_vectors functions to the common library because gcc was complaining (with reason) that the function was not available in the benchmarks and tests so I'm not sure how MSVC was able to build everything but now it builds on both. See 8d305ac7f01b42e357cc20acb5d766157726b1f4 for the changes


README: Update usage instructions

Update usage instructions to improve readability

Is there anyone that could review this PR for me and give feedback if needed?

@Vantadaga - we're moving away from the Rust compiler, so we may want to start from using the jakt (selfhost) instruction instead.


"Istioctl manifest generate --set" error messages lack context

Bug description
I am trying to install istio using istioctl. I want all the components of default installation plus sds and stackdriver apater to be installed. Using below command to generate the manifest using istioctl -
istioctl manifest generate
--set values.gateways.enabled=true
--set values.gateways.istio-ingressgateway.enabled=true
--set values.gateways.istio-ingressgateway.sds.enabled=true
--set values.global.mtls.enabled=ture
--set values.prometheus.enabled=true
--set components.citadel.enabled=true
--set components.galley.enabled=true
--set components.pilot.enabled=true
--set components.policy.enabled=true
--set components.sidecarInjector.enabled=true
--set components.telemetry.enabled=true
--set values.mixer.adapters.stackdriver.enabled=true > istio-new.yaml
Error: validation errors (use --force to override):
json: cannot unmarshal string into Go value of type bool
istioctl manifest generate --set values.mixer.adapters.stackdriver.enabled=true >  enable-telemetry-stackdriver-adapter.yaml works fine but few components like sidecarinjector, telemetry, policy, sds are missing.
[ ] Configuration Infrastructure
[ ] Docs
[X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Should generate yaml file.
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.10-gke.17", GitCommit:"bdceba0734835c6cb1acbd1c447caf17d8613b44", GitTreeState:"clean", BuildDate:"2020-01-17T23:10:13Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}
How was Istio installed?
not relevant
Environment where bug was observed (cloud vendor, OS, etc)

It is the --set values.global.mtls.enabled=ture.
true is mispelled.
Agreed the error message could be better!

I looked at improving the error message.
Istio calls https://godoc.org/github.com/golang/protobuf/jsonpb#Unmarshal passing in
  mtls:
    enabled: ture

The protobuf unmarshaler just returns "cannot unmarshal string into Go value of type bool".
I could output the context, in YAML or JSON, but it includes all of the parameters.
I couldn't find any way to get the protobuf unmarshaler to output which field it failed unmarshaling.
My hope is to produce a message "cannot unmarshal 'ture' into value of type bool at values.global/mts.enable" but I don't know how to make that happen.

It is the --set values.global.mtls.enabled=ture.
true is mispelled.
Agreed the error message could be better!

my bad. Thank you for pointing out.

My hope is to produce a message "cannot unmarshal 'ture' into value of type bool at values.global/mts.enable" but I don't know how to make that happen.

Hey @esnible,  I was able to achieve a sort of static validation for boolean values, although the work is still in progress (need lot of improvements), here is how it detects invalid bool values and output error messages.
$ istioctl manifest apply
   --set values.global.mtls.enabled=ture
   --set values.gateways.enabled=0
   --set values.gateways.istio-ingressgateway.enabled=1
   --set components.policy.enabled=true

Error: failed to apply manifests:
 Unsupported value: "ture", supported values for: "values.global.mtls.enabled" is [true false],
 Unsupported value: "0", supported values for: "values.gateways.enabled" is [true false],
 Unsupported value: "1", supported values for: "values.gateways.istio-ingressgateway.enabled" is [true false]

Note: This is a WIP for manifest apply.

@shamsher31 I like it.  The same logic will work with manifest generate and istioctl upgrade so it makes sense to add --set validation to those two commands or refactor it into yamlFromSetFlags().

@esnible The PR https://github.com/istio/istio/pull/22799 was open from a long time.


Change hi::task final_suspend to post the notification on the local loop.

By posting the notification on the loop, the task has a chance to complete before the callbacks are called. That way a callback will have access to the co_returned value of the co-routing.
But I do not know if this will work correctly with all functionality, for example hi::when_any().

This was proved to not be a problem.


\AppData\Roaming\npm\node_modules\reactql\cli\index.js

After installing and trying to create a new project there is an error on line 316 unexpected bracket after the comma .
I removed the comma and the new project was able to be created.
System:Windows 10
Install command:npm i -g reactql
Create new project command:reactql new

Which version of Node are you using @eavMarshall ?

http://node.green/#ES2017-features-trailing-commas-in-function-syntax
This works in the latest Node (8.4.0), but not the LTS version. Note that ReactQL will only work where async/await are available natively, which is Node 7.6+, so you'll need to bump your local Node installation anyway.
However, I'll fix this anyway so that the CLI runs successfully, and is able to quote the minimum required Node runtime when the version is < 7.6.

Fix released in 4.5.6 - upgrade with npm i -g reactql


bug fix - resource unit

@johanneskoester input.size is in bytes so disk_mb should be divided by 1024*1024. Not doing this caused tibanna ebs size estimates to be in thousands of terabytes.

Good catch! I have fixed this slightly differently in commit 43775a05.


Yolov5m6 tensorrt onnx error

Hi, I'm sorry to bother you, I don't know your email so I'm contacting you this way. I am interested in autoware tensorrt_yolo.I converted yolov5m6 to tensorrt onnx model, but the autoware program reported an error after starting it, does the current version of AUTOWARE not support Yolov5m6 model (size: 1280)?

I will reply on email.

OK，my email is<EMAIL_ADDRESS>

I will reply on email.

OK, my email is<EMAIL_ADDRESS>

I will reply on email.

OK, my email is<EMAIL_ADDRESS>@wep21


 You are running a 32-bit build of Go.

If you are on 10.10 you should be able to run 64bit versions of go.


Fixes #254

📥 Pull Request
📘 Description
Briefly describe the changes you've made.
🔄 Related Issue (if applicable)
#254
🎯 Goal
Closes #254
🔍 Additional Context
Any extra information or context to help us understand the change?
🧪 Testing
Describe the tests you performed to validate your changes.
Thank you for your contribution to Agentops!

please run black . to pass format tests


feat: clear selection in kitty after paste closes #76

:tada: This PR is included in version 2.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Doesn't work

I've gone back and followed the steps about 15 times. The shortcut has the necessary matching info. No errors, no notifications.
Why is showing a toast so complicated? It's a bit embarrassing that the creators of this API came up with... this.
Ultimately, do you have a sample I can download to test? The process is entirely too complex and error prone to try to slap together using code fragments.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14e9484a-4921-2ee3-c93e-787a7b104f61
Version Independent ID: 9e3db713-1558-7297-ef6d-53e5d87d4757
Content: Send a local toast notification from desktop C# apps - UWP applications
Content Source: windows-apps-src/design/shell/tiles-and-notifications/send-local-toast-desktop.md
Product: uwp
Technology: design
GitHub Login: @hickeys
Microsoft Alias: hickeys

Why was this closed?


symmetrize function

Summary:
Given how often users have to do this themselves, it seems like it'd be useful to have a function
/**
 * Return symmetric form of matrix with entries below the diagonal copied
 * into the above-diagonal positions.
 */
matrix symmetrize(matrix a) {
  if (rows(a) != cols(a)) reject("require square matrix");
  matrix[rows(a), cols(a)] b = a;
  for (i in 1:rows(a)) for (j in i + 1:cols(a)) a[i, j] = a[j, i];
}

An alternative would be to define the return as 0.5 * (x + x') but that's a whole lot more work for autodiff and it won't work in the situation where we fill in the below-diagonal then call this function to complete.
Current Version:
v2.14.0

Given the ambiguity as to which triangle gets copied into which,
I’d recommend making the naming explicit, a la symmetrize_ld
or symmetrize_up or the like.

On Jan 31, 2017, at 3:16 PM, Bob Carpenter<EMAIL_ADDRESS>wrote:
Summary:
Given how often users have to do this themselves, it seems like it'd be useful to have a function
/**

Return symmetric form of matrix with entries below the diagonal copied
into the above-diagonal positions.
*/
matrix symmetrize(matrix a) {
if (rows(a) != cols(a)) reject("require square matrix");
matrix[rows(a), cols(a)] b = a;
for (i in 1:rows(a)) for (j in i + 1:cols(a)) a[i, j] = a[j, i];
}
An alternative would be to define the return as 0.5 * (x + x') but that's a whole lot more work for autodiff.

Current Version:
v2.14.0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/stan-dev/math/issues/482, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdNliKYLPThFA0QjTDFOMDHVJhVkPe8ks5rX5aggaJpZM4LzH2z.

https://github.com/stan-dev/math/pull/2209 added symmetrize_from_lower_tri(). Do we leave the issue open for symmetrize_from_upper_tri() or is that a less common case that we dont need to add it?


Translation fails when from mbart50 fine-tuned preloaded model

🐛 Bug
I have used mbart50 pre-trained model to fine-tune a translation task for Si-En Languages. I now need to preload the model for translations. However during translation I get the following error
Traceback (most recent call last):
File "si_en_mbart50ft_checkpoint_preload.py", line 20, in
translation = si2en.sample(sentence_list, beam=5)
File "/userdirs/abc/fairseq-v0.10.2/fairseq/hub_utils.py", line 132, in sample
batched_hypos = self.generate(tokenized_sentences, beam, verbose, **kwargs)
File "/userdirs/abc/fairseq-v0.10.2/fairseq/models/bart/hub_interface.py", line 112, in generate
**kwargs
File "/userdirs/abc/fairseq-v0.10.2/fairseq/hub_utils.py", line 171, in generate
prefix_allowed_tokens_fn=prefix_allowed_tokens_fn,
TypeError: build_generator() got an unexpected keyword argument 'prefix_allowed_tokens_fn'
To Reproduce
Following is my code. Although the checkpoint can be preloaded, the translation fails owing to the above error.
It is further noted that, as the fine-tuning as a translation_multi_simple_epoch task results in this error.
According to the example, the fine-tuning had been conducted by setting the task as translation_multi_simple_epoch.

from fairseq.models.bart import BARTModel
BASEDIR = '/userdirs/abc/pretrained_models/mbart50.pretrained'
si2en = BARTModel.from_pretrained(
'/userdirs/abc/si_en_models/checkpoints',
checkpoint_file='checkpoint_93_75000.pt',
bpe='sentencepiece',
sentencepiece_model=f'{BASEDIR}/sentence.bpe.model',
lang_dict=f'{BASEDIR}/ML50_langs.txt',
source_lang = "si_LK",
target_lang = "en_XX"
)
si2en.eval()
sentence_list = ['දුම්කොළ බදු පනත යටතේ අය කරනු ලබන දඩ මුදලින් සියයට 25ක් තෑගි මුදල් ගෙවීමට හිමිකම් ලබයි .']
translation = si2en.sample(sentence_list, beam=5)
print(translation)
breakpoint()

Environment

fairseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0)
OS (e.g., Linux):
How you installed fairseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Additional context

hi @aloka2209 did you find solution to this?


Voice to text refuses to work for searches in app since it became Mihon

Steps to reproduce
Go to browse than search and use your keyboard to do voice to text and it will not work.
Expected behavior
It should type what you say you can see the microphone hears you but the text does not appear on the search field
Actual behavior
It should type what you voiced
Crash logs
No response
Mihon version
0.16.3
Android version
Android 11
Device
Oneplus 6T
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

This is a known issue in #425 but I invite you to add to that issue what keyboard you're using and your phone, model, and Android/OS version.
Closing as duplicate of #425


Controlpanel

Layout styles derived from MS Word. colors and button/input tags design derived form google docs.

Our new slider looks like as shown.

source: google docs

user can set values accurately (by directly inserting a value in it.)
It is looks clean.
And, above all, it consumes less  space in the menubar.
These sliders are written as a separate component (more clean and maintainable code😁)

Extra Feature: added a warning dialog box that tells about the min and max value allowed on an input tag.😁😁

This tooltip appeared when I clicked on minus to decrease X-axis adjustment below 5.
closes #403
-- DWoC and SWoC participant

This is the coolest issue I have ever solved. I learned about JavaScript promises and some new react lifecycle methods by cracking some bad bugs😁.
It feels nice to solve tough stuff!

This is the coolest issue I have ever solved. I learned about JavaScript promises and some new react lifecycle methods by cracking some bad bugs😁.
It feels nice to solve tough stuff!

@ashuvssut can you add the field for font color to this as @sanjay270899 has implemented that

@ashuvssut can you add the field for font color to this as @sanjay270899 has implemented that

Yeah it will be done today only

Yeah it will be done today only

@anushbhatia, i think the page bg change was not working before. am i right sir?

@anushbhatia, i think the page bg change was not working before. am i right sir?

sanjay's changes cant be merged with my changes (Dropdown item's onClick event has something that not working right). I am finding a way to fix it.

sanjay's changes cant be merged with my changes (Dropdown item's onClick event has something that not working right). I am finding a way to fix it.

Sanjay's changes are now added. You can review the PR to merge it

Sanjay's changes are now added. You can review the PR to merge it

i will fix this within 5 mins

i will fix this within 5 mins

looks like when adding sanjay's changes i forgot to test my own changes if they work on not XD

looks like when adding sanjay's changes i forgot to test my own changes if they work on not XD

@anushbhatia @smaranjitghose, can you please put the level tag for dwoc for this feature update PR

@anushbhatia @smaranjitghose, can you please put the level tag for dwoc for this feature update PR


Add github workflow and remove travis ci

Motivation

Changes

Release Notes

Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
QA Checklist

[ ] Tests were updated and provide good coverage of the changeset and other affected code
[ ] Manual testing was performed if needed

[ ] Steps from PR author:

[ ] Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed:

[ ] A Client Platform member has reviewed these changes
[ ] There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
[ ] For release PRs - Version metadata in Rosie comment is correct

Security Insights

(2) Vulnerable direct dependencies were detected
1 vulns in sockjs < 0.3.20 via package-lock.json
1 vulns in websocket-extensions < 0.1.4 via package-lock.json

Action Items

Review dependencies for available updates
See this Splunk dashboard for more CVE details
Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.


Wrong types for fluent API when used along with rejectOnNotFound

Hey,
I just want to report issue I just found out.
Schema:
datasource db {
  provider = "sqlite"
  url      = "file:./build.db"
}

generator client {
  provider = "prisma-client-js"
  output   = "./dist"
}

model Composer {
  id        String        @id @default(cuid())
  pieces    Piece[]
  createdAt DateTime      @default(now())
  updatedAt DateTime      @updatedAt
}

model Piece {
  id         String        @id @default(cuid()
  composer   Composer      @relation(fields: [composerId], references: [id])
  composerId String
  createdAt  DateTime      @default(now())
  updatedAt  DateTime      @updatedAt
}

See code below with comments:
// OK -> piece: Piece
const piece = await prisma.piece.findUnique({
  where: {
    id: parent.id,
  },
  rejectOnNotFound: true,
});

// OK -> piece: Piece | null
const piece = await prisma.piece.findUnique({
  where: {
    id: parent.id,
  },
});

// OK -> composer: Composer | null
const composer = await prisma.piece
  .findUnique({
    where: {
      id: parent.id,
    },
  })
  .composer();

// BAD -> composer: Composer | null, should be composer: Composer
const composer = await prisma.piece
  .findUnique({
    where: {
      id: parent.id,
    },
    rejectOnNotFound: true,
  })
  .composer();

// To fix this we need to do this:
// OK -> composer: Composer
const composer = await prisma.piece
  .findUnique({
    where: {
      id: parent.id,
    },
    select: { composer: true },
    rejectOnNotFound: true,
  }).then(piece=>piece.composer)

Thanks for the report. I can reproduce this in 2.18. We need to fix the types for fluent API with rejectOnNotFound. I have updated the issue title to reflect that.

Hey, I just want to add that the same thing happens if I initialize prisma client (new Prisma({rejectOnNotFound: true})) with this rejectOnNotFound  setting as well.

I think it can be wise to add rejectOnNotFound and select: { xxxxx: true } on this page : https://nexusjs.org/docs/plugins/prisma/removing-the-nexus-plugin-prisma#1-1-relations

Still happend with the new findUniqueOrThrow method from version 4.1.0


feat(integrations): Add message envelope to scope context

Related: https://github.com/getsentry/sentry-symfony/issues/703. With this PR the message envelope is added to the scope context. Let me know what you think.
Can you give me some pointers on the e2e test to add for this feature? Should I edit this somehow?

I'm not sure we should enable this automatically. The envelope could contain sensible information that should not be shared with Sentry.

I agree. Would you like to see is behind a config flag?

Overall, this is a valuable addition.

We need to guard the inclusion of the envelope with send_default_pii

I have this option set to false (I don't want/need everything it provides), but I would very much like to have messenger data available to me. Is it possible to differentiate? A new flag could be created, or maybe an example can be given how to enable the send-default-pii flag and remove everything but messenger.envelope context data.

There are some size concerns, as too big payloads are being dropped by Relay. Are there any size limits for an envelope enforced on the Symfony side?

If I'm correct; not on SF side but on message brokers side. I guess it's easier to add a check if the serialized envelope size does not supersede 8kB, else replace the data with a "skipped" value.

This data won't be searchable, so this will be just additional context that enriches an error event.

Is that a bad thing? I don't necessarily need it to be searchable.

Until we implement RFC #62 in the PHP SDK, you would likely need to remove all unwanted data inside before_send. Not a perfect solution, but we have to work with what we have today.
Enforcing a size limit in the SDK seems reasonable. We do similar things in our RequestIntegration.
Not being able to search this data was more of a heads-up to set expectations.

@cleptric I have done all the changes I would like, but I'm struggling with the tests. I would like to add a simple E2E test; capture a hard failure, fetch the last event, and see if the expected context is equal to the recorded context. How can I fetch the recorded context in that scenario?
(Or do you want me to create a unit test? I thought this was not preferable because then I have to mock Symfony\Component\Messenger\Transport\Serialization\SerializerInterface which is a black box from this libraries perspective.)

@darthf1 I'm currently not sure what the best way forward is to test this. I'll probably need some time to dig into the topic but I'm currently focusing on other topics. Maybe @Jean85 can provide some pointers in the meantime.

E2E tests involving the Messenger are already present in the current test suite.
All involved classes are here: https://github.com/getsentry/sentry-symfony/tree/master/tests/End2End/App/Messenger
Messages are dispatched here, in a controller: https://github.com/getsentry/sentry-symfony/blob/master/tests/End2End/App/Controller/MessengerController.php#L23-L35
Tests are here (and below): https://github.com/getsentry/sentry-symfony/blob/master/tests/End2End/End2EndTest.php#L218-L234


[Accessibility] A11y_.Net Editor_Screen Reader: When Narrator/NVDA is on user needs to press ESC key two times to close command palette

Environment Details
https://docs.microsoft.com/en-us/dotnet/csharp/quick-starts/hello-world?tutorial-step=4User
Browser: Edge (41.16299.402.0)
Chrome (67.0.3396.87)
Screen Reader: Narrator
NVDA
Additional Details:
MAS Violated: MAS1.3.2, MAS2.1.1
Repro steps:

Hit the URL https://docs.microsoft.com/en-us/dotnet/csharp/quick-starts/hello-world?tutorial-step=4User
Tab till “Enter focus mode” and press enter
Type any code and press F1 and on the Screen reader
Check whether user is able to close the Collaboration list on pressing Esc only once when screen reader is on

Actual Result:-
When screen reader is on user needs to press ESC key two time to close command palette
Expected Result:-
User should be able to close the list items on pressing the dropdown only once. Command to perform any operation should be changed when Screen reader is on.
User Impact:-
Screen Reader users find difficulty in using application if user needs to operate controls twice to perform an action.
MAS Reference:-
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={1ee227a7-e3c5-47b8-ab18-48ca8595077b}
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={8492c4eb-c179-40ae-8777-cd044ed725a2}
When screen reader is on user needs to press ESC key two time to close command palette.pptx

Update
Issue has been flagged and assigned to the Monaco repo.
https://github.com/Microsoft/monaco-editor/issues/1167

Update
Issue has been assigned on the Monaco repo
https://github.com/Microsoft/monaco-editor/issues/1167

Importance of experience (High or Low Impact).
Impact: Low we haven't received any customer complaints directly to the service. The .NET online editor is the service behind editor and we do not own or control the UI experience.
Describe scenario: Please the description above
Quality of Experience (High or Low Impact).
Link to AAT
Any alternate solutions or technologies evaluated
Not applicable
Ensure all evidence for hand-off to external team is provided in the bug
Issue has been flagged and assigned to the Monaco repo.
https://github.com/Microsoft/monaco-editor/issues/1167

This was discussed with Ryan and approved to close as this is non blocking scenario.


Manifest not copy to eject runtime folder

Describe the bug
currently manifest not copy to eject runtime folder before publish.
Version

Browser

[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

I've verified this, it works well, so close this.


Error running npx cap sync / npm install pushy-cordova after updating node, XCode, et al

I'm revisiting a Capacitor project I haven't updated in a while (at least a year), so I've updated everything including MacOS, XCode, NodeJS, Capacitor, etc. But when I run npx cap sync I get the following error:
[error] Analyzing dependencies
		[!] CocoaPods could not find compatible versions for pod "Pushy":
		In snapshot (Podfile.lock):
		Pushy (= 1.0.46, ~> 1.0.32)

		In Podfile:
		CordovaPluginsStatic (from `../capacitor-cordova-ios-plugins`) was
		resolved to 5.7.8, which depends on
		Pushy (~> 1.0.53)

		Specs satisfying the `Pushy (= 1.0.46, ~> 1.0.32), Pushy (~> 1.0.53)`
		dependency were found, but they required a higher minimum deployment
		target.

If I try to update Pushy by running npm install pushy-cordova I get this error:
npm error Cannot destructure property 'package' of 'node.target' as it is null.

Any ideas what's going wrong here?

Hi @webeditors,
Thanks for reaching out. We'd be glad to assist with your inquiry.
Based on the error Specs satisfying the Pushy (= 1.0.46, ~> 1.0.32), Pushy (~> 1.0.53) dependency were found, but they required a higher minimum deployment target., it appears that your Xcode project's minimum deployment target is set too low.
Please update your Podfile and set the platform :ios parameter to 9.0 as follows:
platform :ios, '9.0'

Then, save the file and run pod install again, and the error should be resolved.
Please let us know if there's anything else we can help with.

Hi @webeditors,
Try deleting your Podfile.lock, and then run pod install again.

Ok, still no change.
Just so I'm understanding, the dependancy is for v1.0.53 and I have v1.0.59, but you thing this is to do with deployment target and nothing to do with the version of pushy I have installed? In XCode 16, the default deployment targets appear to be 15 thru 18 - should I got through everything that has 13 as the target and update it to 15, or am I chasing a red herring?

Ah... fixed it.
The solution was to get into the App folder, then run pod update Pushy - now I can npx cap sync with no errors.

Glad to hear you managed to find a solution! 👍


Feat(chat): quick apps feature

Issues:

Issue #2160

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

Hey there and thank you for opening this pull request! 👋🏼
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
Unknown release type "Feat" found in pull request title "Feat(chat): quick apps feature".

Available types:
 - fix
 - hotfix
 - feat
 - feature
 - chore

/deploy-review

/deploy-review


Release version 29.0.1

I accidentally merged a change (https://github.com/alphagov/govuk_publishing_components/pull/2695) into a released version as the PR was created before 29.0.0 was released. Adds a new version to flag the changes.

Just holding off merging this until v29.0.0 has been sorted out.

Have had the go ahead from @andysellick to merge this now! 🚀


generate-kpt-pkg-docs's module is not correct

The module name of function generate-kpt-pkg-docs is inconsistent with its location and name.
https://github.com/GoogleContainerTools/kpt-functions-catalog/blob/master/functions/go/generate-kpt-pkg-docs/go.mod#L1
We also need to to change the affected import paths.

cc: @bharathkkb


Add url and hash to File object

Added URL (for URL-type files) and the hash, introduced in v0.22 of SampleDB to file objects.

Thanks!


Fixes #5475 : Don't try to get culture when using HttpContextPlaceholder

Prevents command line from throwing when CultureSelector is enabled.

I don't know what it fixes, but it looks so wrong ... I am going to look what it fixes ;)

This is a typical issue when using the placeholder that one of its properties is null or not implemented. In this case please add the missing implementation to the HttpContextPlaceholder class.

You are right, I proposed a new PR #5688


added possibility to config storage defined types via hiera

This is similar to https://github.com/voxpupuli/puppet-bareos/pull/54 and https://github.com/voxpupuli/puppet-bareos/pull/38
Since defined types cannot be configured via hiera, I added hashes to the main storage class which elements will be fed to the corresponding resources.

added working rspec tests for all hashes

thanks for the PR!

i'm not happy that this was merged with 5 commits four of which could have been squashed, and a block of commented out tests.


Add tab expansion support for git restore / switch

Fix #691

@pinkfloydx33 Updated.  Can you take another peek?

@pinkfloydx33 I'm going to merge this.  Can you pull master and try it out.  If you find any issues, we can fix them before the final release.


Initial commit for import FSM update from upstream.

This is a PR to import replacing tomb.v2 with Context from upstream.

Looks good to me.


Stripe Integration

Changes

Replace Paypal Subscriptions API with Stripe
New Billing Portal for users to manage their billing
Restrict access for non-pro members

Ready to merge! 👍


About the dataset

I am very interested in your article, but I have a question about the clipart_cycle_voc and voc_cycle_clipart dataset. And where I can download these two datasets?
I will appreciate it if you can provide the drive link.

I have uploaded the data to google drive, contact me via email, I will share the drive link with you.

Hello @kinredon can u pls pass me the link to the datasets as well? my email is<EMAIL_ADDRESS>

@kaiabco1996 Hi, I have sent you an email.


Add<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Hello @kilograham, modules you maintain (pico-sdk) have been updated in this PR. Please review the changes.

Hello @armandomontanez, modules you maintain (pico-sdk, picotool) have been updated in this PR. Please review the changes.


Use #batch_delete_item in #truncate

Hi! I thought I'd rewrite truncate method as was suggested in this comment https://github.com/Dynamoid/dynamoid/issues/217#issuecomment-568222683

Looks good 👍 Thank you


Fixed package to run with ros2 run

Fixed package to run with ros2 run rqt_action rqt_action. Related to this issue https://github.com/ros-visualization/rqt_console/issues/20
Signed-off-by: ahcorde<EMAIL_ADDRESS>

Can you elaborate on how this solves the problem? Does it end up installing the script twice?

I added an entrypoint and removed the script instalation otherwise this is not working on Windows

Running CI up to rqt_reconfigure

Linux
Linux-aarch64
macOS
Windows

With this change you can't invoke rqt_reconfigure anymore (without ros2 run) so this breaks existing use cases and documentation.

With this change you can't invoke rqt_reconfigure anymore (without ros2 run) so this breaks existing use cases and documentation.

In what ROS version was this possible? I don't see how lib/rqt_reconfigure was part of your PATH before this change.

In what ROS version was this possible? I don't see how lib/rqt_reconfigure was part of your PATH before this change.

You are right. This package only offered the executable in lib/rqt_reconfigure - so not a regression. Other packages offer the executable in both places for user convenience so I falsely assumed this package would do the same.


iDEAL select bank change dropdown icon

Hi! Love the work you've done. I was just wondering if there's any way to change the icon that is rendered inside the dropdown for iDEAL bank. I don't mean the images for the different banks, but rather the "dropdown icon" that is to the right, that today is made up by two arrows. Would it be possible to implement this?

Hello @johnhult. Thanks for the feedback! Issues in this repo are for react-stripe-elements specific issues. You can send a message to our support team via https://support.stripe.com if you'd like to request features for Stripe Elements, which this repo just wraps in a React-friendly wrapper.


peepmatic: rewrite type checking to use traditional unification

I originally punted on implementing this by hand and just gave all the type constraints to Z3, which was easy and is usually fast, but occasionally Z3 gets confused and hangs. Also the fuzzers have discovered inputs where Z3 hangs, which leads to noise in our fuzzing results.
We should rewrite Peepmatic's type checking to use the traditional approach to unifying type constraints via union-find.

When we do this, we should re-introduce the fuzz targets removed in https://github.com/bytecodealliance/wasmtime/pull/2696

@fitzgen this was probably fixed by mistake automatically by github because of the "when we fix" this issue text in that PR ? :)

Ah yes, thanks for the heads up!

Peepmatic was removed in https://github.com/bytecodealliance/wasmtime/pull/3543


fix types error: exclude tests folder from  build; include just src f…

…older;

this small bugfix resolves problems with types


my pain points / feedback

First of all, thanks to @oblomov-dev for a great tool.
Something I hope to see documented in the upcomming blog (Technical documentation):
abap2UI5 is stateless, but it creates a powerful illusion of state with it draft table magic. This works well most of the time, but the developer must actively help to maintain this illusion if the code has object references.
a) make sure all objects (including their attributes that are object reference) implement the IF_SERIALIZABLE_OBJECT tag interface
b) beware the comparison of objects, as two objects with the same attributes are equivalent. Comparisons like
IF oref1 = oref2.
    ...
ENDIF.

eventually fail after one object is serialized and deserialized and the other is not. This may happen if one of the object references is an attribute in another object. I am now using something like
IF oref2 IS BOUND AND oref1->key = oref2->key.
    ...
ENDIF.

to avoid the subtle errors in a legacy logic where I was using singletons created in class constructor once (singletons are global variables :( )
abap2UI5 is simple to use, I can easily created Popup to input. But while doing so I was tempted to simulate synchronous input , where the code awaits the result and the resume.  Like when you execute a dynpro with CALL SCREEN. This is not possible (yet ?). I have been mulling about using the ABAP promises https://github.com/abapify/promise to achieve this control flow.
That is all for now

Hi nomssi,
thanks for trying abap2UI5 out (you are one if the first 👏) and all the pull requests with the corrections during this time!
serialization
You summed up the situation very well i think. serialization can be very powerful and like magic but when you don't know what you do it also can end in very bad situations and problems which are hard to manage.
i had in mind just to use it for interim results like an input field or some edited entries in a table. it is very helpful that you don't have to create an extra db table for this. when you only use it to serialize your ui values and use the app class only for ui logic and do the other things in other (not serializable) class you will not run into problems.
But: of course you also have the possibility to serialize your whole logic and every class and try to simulate a session. abap2ui5 makes no restriction, but then it is up to the abap developer if it will work or end in the reference problems you talk about. serialization is nice but definitely more an abap expert topic. it is a good idea to clarify that in the "technical backgrounds" of the blog series, that no one has wrong expectations and is aware of this!
popups
abap2ui5 works all the time with a server roundtrip so the flow logic is: frontend -> server roundtrip -> frontend -> server roundtrip etc. you can not break out of this.
but i am not sure if i understand you right. can you give me more information or describe an example?
you want to do something asynchronously? or you want to do something on the frontend while you executed an action in the backend (and dont want to wait fo the result)?
Best regards

P.S.: made some bigger changes, flow logic is slightly different now, hope you can refactor your apps without too big effort. all examples are updated that you can see how it works. also needed to adjust the methods "set_app_client" and "trans_ref_tab_2_tab" where you did a lot of work, hope it is still running on your release!

Hi Oblomov,
about popups:  the concrete use case is implementing an input port. I am trying to implement a synchronous input/prompt where the code waits for the user to input data that will be processed. The current popups work well asynchronously, but I am trying to simulate a modal input dialog.
DATA my_variable TYPE string.
DO.
    CLEAR my_variable.
    prompt the user to input data (e.g. in a popup)
    wait for the user to confirm the entry, transfer the data to my_variable.
   use my_variable in my custom logic.
ENDDO.

Without the external DO / ENDDO loop, I would be able to simulate this with event handling.
With the loop, I am frankly not sure it this can be done in a REST environment.
Best regards
P.S. your nickname seems to mean a sloth. If then, how come an Oblomov can be so productive?

yes
do.
...
enddo.
structures are not possible with abap2UI5. After every request the sessions is terminated and this means also that the complete call stack is deleted. the program in a way restarts again with every request.
for your use case:
yes, simulating it with event handling is the only option. you can save in a variable if the popup is active or not. And if yes let the app display again and agin the popup till the user made the correct input. for better readability you can think of encapsulating the popup in an own app. i made some examples here: z2ui5_cl_app_demo_12
popups and a good control flow with it is not easy but an important topic, so let me know if you have further use cases that we can check how they are realizable with abap2UI5.
best regards.
P.S.: yes also good question, the idea was finding a "lazy" way to create ui5 apps with minimum effort, but i forgot that the framework author has then more work to do 😂 maybe i should rethink the animal again ;)


Parallax Mapping

Add support for Parallax Mapping

Initial investigations suggest that neither .obj nor the .glb file formats support height maps.
The next step is one of

Add support for a third format that supports height maps
Manually import the height map via stbi

The feature is not merged.
I seems that support for height maps is rather limited. I wasn't able to find a format that fulfilled all of the following

Supported Height Maps
Supported by Blender
Had the height maps recognized as such once imported by Assimp.

Therefore the final decision was to add a parallel texture importer to the engine.


chrome v.52 causing video elems to not render

Before updating to chrome v.52, everything worked as usual.
Now with chrome v.52, we're getting the 'your browser does not support webRTC' error.

Also, we're using React .. it could be related to this.

We were able to fix by removing the src attribute altogether from the video elem and using the element's srcObject to define the stream on:
var elem = document.getElementById('publisher');
elem.srcObject = this.props.stream.srcObject;


Default Canvas

In a previous discussion (https://github.com/pygfx/pygfx/pull/371#discussion_r1014485572) I learned that you often don't need to interact with the canvas object directly when using pygfx. There are, of course, exceptions when this can be advantageous, but in general this is not the case. Because of this, we have introduced renderer.request_draw which wraps canvas.request_draw.
Taking this thought and thinking it to its conclusion I think it would make sense to also see if we can avoid all calls to canvas by default so that we only have to instantiate it when needed. In particular, I was wondering if we could change
from wgpu.gui.auto import WgpuCanvas, run
import pygfx as gfx

renderer = gfx.renderers.WgpuRenderer(WgpuCanvas())

to
import pygfx as gfx, run

renderer = gfx.renderers.WgpuRenderer()

and make wgpu.gui.auto.WgpuCanvas the default canvas. We would, of course, keep the parameter and allow users to set it manually if needed. My angle here is to see if we can reduce boilerplate code.
On the same token, we could wrap run and avoid the import of wgpu for minimal examples. It's always nice to not have to import lower-level functionality when dealing with something on a more high level.

I'm OK with this proposal. Seems like a good improvement to me.
How would you propose ti wrap run?

On the one hand, I'm reluctant, because I feel it makes the renderer and canvas feel intertwined. On the other hand I can see how this simplifies the API and lowers the barrier for newcomers. I've tried to think of variations but they ain't prettier. In the end I'm also in favor.
A gfx.run()  could do something like:
def run():
    import wgpu
    try:
        run = wgpu.gui.auto.run
    except AttributeError:
        ...
    run()

I was thinking @FirefoxMetzger was probably expecting a method on the renderer... We can do both?

I would prefer creating only gfx.run(), since there is only one event loop. Putting it on the renderer might give the false impression that each renderer has its own loop or something.

I'm OK with that. We just need to pick a position on the spectrum from "full truth" to "full simplicity". :)

I was thinking @FirefoxMetzger was probably expecting a method on the renderer... We can do both?

Not per se. I was mainly thinking that it would be nice to not have to import wgpu while working with pygfx unless you have a specific need to customize something. So yes, something like gfx.run() seems intuitive.

If users have such an advanced use case (which is technically possible), they would have to integrate the event loops, and one would become the controller of the other, and they would end up calling only one of the two.

I agree with @Korijn. It's possible, but people doing that do/should use wgpu directly anyway.

There's a couple more use cases for interacting with the canvas widget to consider:

examples/offscreen.py when doing offscreen rendering, you would retrieve the final image as a numpy array with img = canvas.draw()
examples/scene_subplots1.py when you have multiple viewports in a single canvas, you need to query the size with w, h = canvas.get_logical_size()
examples/text_with_qt.py I'm overlooking this one since it will be deprecated when proper text rendering support is merged

I've been trying to come up with a good way to define gfx.run() and I don't think there is a smooth way to do so. The problem is that wgpu.gui.auto.run will only get us the correct event loop if we actually use the auto backend or explicitly use the backend that would be selected by the auto backend. This introduces a potential source of annoyance because something that is seemingly correct won't work:
import pygfx as gfx
import wgpu

renderer = gfx.renderers.WgpuRenderer(wgpu.gui.non-auto.WgpuCanvas())

#  starts the wrong event loop, because renderer doesn't use the `auto` canvas
gfx.run()

I have a few potential responses, but none of them area ideal:

We accept that gfx.run() only targets the auto backend and ask people to import run from wgpu otherwise
We introduce a renderer.run function that uses the renderer*s canvas to get the event loop
we introduce a gfx.gui_backend = wgpu.gui.auto singleton which users should use to control which canvas and run function gets used. Subsequently calling WgpuRenderer() will get a canvas from gfx.gui_backend and gfx.run will call the backend's run function.
we don't introduce gfx.run and just use a default canvas

None of these approaches are great. I think a gfx.gui_backend (with default value) comes closest to what we want, but prevents us from having more than one backend in the future.
I am starting to lean the opposite way and think that maybe it would be more consistent to deprecate renderer.request_draw and keep both the canvas and the renderer separate. What do you guys think? @Korijn @almarklein

examples/offscreen.py when doing offscreen rendering, you would retrieve the final image as a numpy array with img = canvas.draw()

I think this is a case where you'd want to interact with the canvas directly, so you would create it and pass it to the renderer explicitly.

examples/scene_subplots1.py when you have multiple viewports in a single canvas, you need to query the size with w, h = canvas.get_logical_size()

Same here. If you need to do things with the canvas you bring it in explicitly.
However, if you just want to create a scene and render it (like many other examples), there shouldn't be the need for you to drag along objects explicitly and my aim here is simply to reduce this boilerplate if possible.

Maybe this is a sign that we're trying to hide an abstraction that does not like to be hidden :)

I think so, yes; or at least we have the order wrong.
@almarklein I have a slightly off-topic rendering question again: Based on my current understanding, each world object in the scene comes with its own rendering pipeline. The pipeline might be re-used/shared, but it exists independently of the renderer. Did I get that right? If so, can I have multiple renderer objects draw to the same canvas?

Each world object in the scene comes with its own rendering pipeline. The pipeline might be re-used/shared, but it exists independently of the renderer. Did I get that right?

Yes, world objects are not bound to a renderer.

can I have multiple renderer objects draw the same scene to the same canvas?

I think that it could, but you probably should not :) This is in part because the clear operation can only operate on the full screen, and also because the renderer has its own intermediate texture, so it would be a waste of memory usage.
That said, there are still some open ends. E.g. this means that one cannot have subplots that use different blending methods. Somewhat related is the wish of some users to access to the depth value. At some point we might need to revisit this.

Hm, I see. In that case, we are indeed approaching this issue from the wrong angle and I am now fairly convinced that we should not add a default canvas inside the renderer.
I will need some time to come up with a more clear idea for an alternative. Currently, I'm thinking if it could make sense to add a new class (say Display) that could help streamline the process. Something like
import pygfx as gfx

scene = gfx.Scene()
... # populate the scene

display = gfx.default_display()
display.show(scene)  # calls the event loop

and if we want a custom animate:
import pygfx as gfx

scene = gfx.Scene()
... # populate the scene

display = gfx.default_display()

@display.draw_function
def animate():
    ...  # do awesome things

display.show(scene)

If we want a more functional style, we could also explore something like
import pygfx as gfx

def animate():
    ...  # awesome

(
    gfx.default_display()
    .add(
        Scene()
        .add(...)
    )
    .update(draw_function=animate)
    .run()
)

In any case, @Korijn @almarklein should we close this issue for now and make a new once once I have a more concrete suggestion?

Taking a step back, the point of this exercise was to see if we can make most examples simpler by removing boilerplate code related to canvas. Your last suggestion indeed looks a lot like the gfx.show() util. Perhaps we should simply make more use of that in the examples (it was added after most examples were written)! 😄
Now that I think of it, the guide should probably start with an example that uses gfx.show() and only expand on the renderer et al. later!
I also like the idea of a custom animate function to use with gfx.show(), so you can e.g. rotate some cubes 😉  - but perhaps that would be more of a hook (and still call renderer.render() from gfx.show())


AAP-31270: Option to disable cert verification of WCA endpoint

Jira Issue: https://issues.redhat.com/browse/AAP-31270

Description
Testing

Steps to test

Pull down the PR
...
...

Scenarios tested

Production deployment

[ ] This code change is ready for production on its own
[ ] This code change requires the following considerations before going to production:

Hi @manstis , Great comments! Thank you, fixed.


Rle related methods

Trying to add lastday flag to other methods that call rle in turn.
Testing is not working though, so I'll need to have a look at that and change tests accordingly.

I have now fixed all the tests and they pass locally. There's still a question on how to generalise the reference to time in rle . I had to modify some tests to replace a hardcoded "x" dimension to "time". We'll ask for advise in the main xclim repo.


@report=false does not appear to be working

I'm seeing details of called feature files tagged with @report=false in the HTML reports.  I'm also seeing details for Scenarios tagged as such, as well.  Sample project attached.
KarateTroubleshooting.zip

@staffier fixed, do confirm when possible from develop. much appreciated !

Yep, looks good to me - thanks, as always, Peter!

1.2.0 released


sigProfilerExtractor gpu solution can't work

Hello,
I follow example to execute sigProfilerExtractor with gpu = True. But program interrupted after matrix generation and output folder only job_metadata.txt and SBS96/All_solutions_stat.csv exist.
Below is command and result.
sig.sigProfilerExtractor("vcf",testgpu_output",data,startProcess=1,endProcess=3,totalIterations=1000,gpu = True).
************** Reported Current Memory Use: 0.15 GB *****************
Starting matrix generation for SNVs and DINUCs...Completed! Elapsed time: 7.81 seconds.
Matrices generated for 15 samples with 0 errors. Total of 93001 SNVs, 505 DINUCs, and 0 INDELs were successfully analyzed.
Extracting signature 1 for mutation type 96

What should i do to resolve this issue?
System information is below.
OS: Centos 7
PyTorch Version: 1.2
Python Version: 3.6.8
CUDA/cuDNN Version: 9.2/7.6
GPU Model: NVIDIA Tesla K80
Thanks,
Bruce

dear @brucewu1996 is the command you are using correct? there appears to be hanging ":
sig.sigProfilerExtractor("vcf",testgpu_output",data,startProcess=1,endProcess=3,totalIterations=1000,gpu = True).

Did the application throw any error or did it simply not run? Would it be possible to share your data with us?

Dear @vellamike
My data generate by  this command path_to_example_folder_containing_vcf_files = sig.importdata("vcf").
This program work successfully by sig.sigProfilerExtractor("vcf","testgpu_output",data,startProcess=1,endProcess=3,totalIterations=1000).
But add gpu = True ,the application break in decompose step without any error message.

Thank you @brucewu1996  - is it possible to share your vcf file with me? This will make it easier to solve the problem

@vellamike Thank for your response.
I recently retry GPU solution by following command.
path_to_example_vcf = sig.importdata("vcf") data = path_to_example_vcf sig.sigProfilerExtractor("vcf", "example_output", data,gpu = True)
This time i got an error message :
Traceback (most recent call last):   File "/usr/lib64/python3.6/multiprocessing/pool.py", line 119, in worker     result = (True, func(*args, **kwds))   File "/usr/lib64/python3.6/multiprocessing/pool.py", line 44, in mapstar     return list(map(*args))   File "/usr/lib/python3.6/site-packages/sigproextractor/subroutines.py", line 298, in pnmf     W, H = nmf_fn(bootstrapGenomes,totalProcesses)  #uses custom function nnmf   File "/usr/lib/python3.6/site-packages/sigproextractor/subroutines.py", line 218, in nnmf_gpu     gpu_id = identity % torch.cuda.device_count() NameError: name 'torch' is not defined
I confirm pytorch-GPU version have been installed in my system.
torch.cuda.is_available() True
What should i do to resolve this issue?
Thanks,
Bruce

Dear @brucewu1996 can you try on the latest version of sigprofilerextractor? It might be also worth trying in a conda or virtualenv environment, it looks like this multiprocessing pools are not able to import torch - this error seems to be related to your system's configuration.

Thank you @vellamike .
This bug be fixed by using virtual environment.
But another bug appear, i executed extractor with following command :
from sigproextractor import sigpro as sig
path_to_example_table = sig.importdata("vcf")
data = path_to_example_vcf
sig.sigProfilerExtractor("vcf", "example_output", data, startProcess=1, endProcess=10,totalIterations = 100,gpu = True)
And then application break in decompose step without any error message.
Below is JOB_MATADATA.txt context of this test.
THIS FILE CONTAINS THE METADATA ABOUT SYSTEM AND RUNTIME
-------System Info-------
Operating System Name: Linux
Nodename: deepvariant
Release: 3.10.0-862.el7.x86_64
Version: #1 SMP Fri Apr 20 16:44:24 UTC 2018
-------Python and Package Versions-------
Python Version: 3.7.4
Sigproextractor Version: <IP_ADDRESS>
SigprofilerPlotting Version: 1.0.10
SigprofilerMatrixGenerator Version: 1.0.22
Pandas version: 0.25.1
Numpy version: 1.17.2
Scipy version: 1.3.1
Scikit-learn version: 0.21.3
Nimfa version: 1.4.0
-------Vital Parameters Used for the execution -------
input_type: vcf
inputdata: vcftest
startProcess: 1
endProcess: 10
totalIterations: 100
cpu: -1
hierarchy: False
refgen: GRCh37
genome_build: GRCh37
mtype: ['default']
init: nndsvdar
-------Date and Time Data-------
Date and Clock time when the execution started: 2019-11-21 20:58:33.981886
Please give me some advise to solve this problem.
Thanks,
Bruce

Hi Bruce,
I will look at what is happening there. But for now, could you please update your scipy library and try to run the tool again?
Thanks,
Mishu

@mishugeb thanks for your prompt response.I already upgraded my scipy to version 1.3.2 ,but problem still exist.Maybe you can provide a list of installed package's version ?I can create another conda environment to test.
Thanks,
Bruce

Hi Bruce,
All the required packages should be installed automatically when you install this package. If there is any error, that will be detected by Travis CI and the build will not pass eventually. I will check that more, but it difficult to replicate an issue if Travis  CI cannot detect that. Sorry for the inconvenience. I will check that more thoroughly.
Regards,
Mishu

Hi Bruce,
Could you please install the most recent tool "pip3 install SigProfilerExtractor" and check if you get the error?
Thanks


Unary call mode with array of 1000 messages of JSON format consumes all CPU

Proto file(s)
DecisionServiceProto.proto definition:
message Decision {
string interactionId = 1;
string timestamp = 2;
string decisionTable = 3;
string decisionTableRule = 4;
string action = 5;
repeated com.avaya.ept.turing.configuration.commondata.RoutingPoint routingPoints = 6;
}
enum Channel {
Voice = 0;
};
message MakeDecisionRequest {
DecisionTableCommonRequest decisionTableRequestParameters = 1;
string interactionId = 2;
string from = 3;
string to = 4;
Channel channel = 5;
map<string, string> params = 6;
}
service DecisionService {
rpc MakeDecision (MakeDecisionRequest) returns (Decision) {
}
}
CommonMessagesProto.proto definition:
message DecisionTableCommonRequest {
string tenantId = 1;
string name = 2;
}
message Tenant {
string tenantId = 1;
}
message Report {
string status = 1;
string message = 2;
}
Command line arguments / config
./ghz --proto=./DecisionServicesProto.proto --call=com.avaya.ept.turing.bre.DecisionService.MakeDecision -D ./request_files/requests_1000_rand.json -c 28 -q 10 -z 1m --insecure <IP_ADDRESS>:50041
Describe the bug
I'm using ghz in unary call mode with array of request messages provided in JSON format to test performance of my gRPC server.
Total number of messages in array - 1000.
After running the command above I'm facing 100% CPU consumption on all the 4 cores of CPU. This affects real query per second results as well as response time so that such tests has no any sense because of client bottleneck (server processes request much faster than client able to generate them and shows CPU consumption under 10%). Server is running on a dedicated VM that ghz.
ghz is running on a dedicated VM (no any other resource consuming applications are running) with 4 vCPUs allocated for this VM running on Xeon(R) CPU X5670 @ 2.93GHz.
htop tool is used to monitor CPU consumption.
The following test summary appears after 1m of test duration:
Summary:
Count:        600
Total:        61.33 s
Slowest:      873.45 ms
Fastest:      2.06 ms
Average:      265.89 ms
Requests/sec: 9.78
As you may see requests/sec is about 10 but should be around 280
To Reproduce
Run htop on server VM.
Run htop on ghz client VM
Run ghz cli command above with 1000 messages in array of JSON format.
Expected behavior
Server side htop shows CPU consumption under 10% during test
Client side htop shows CPU consumption under 10% during test
Requests/sec in summary is close to specified qps (about 280)
Environment

OS: CentOS Linux release 7.4.1708 (Core) X64
ghz: 0.36.0

Screenshots
htop output is attached:

Additional context
There is no such issue with unary call mode using array of messages in binary format, CPU is consumed below 10%

Hello, can you give 0.37.0-pre.0 a try please. In my testing the same test run that before consumed 100% when I reproduced the issue now consumed no more than ~22%. A test with same params as above (ie -z 1m -c 28 -q 10) and 1000 JSON objects now consumes ~15-16 %. Give the prerelase a try and let me know if you see improvements. Thanks.

Hello @egick666, have you had a chance to test this?
Thanks,

Hi @bojand
Sorry, I haven't yet. I'll try to run this week and let you know results.
Thanks

Hello, thanks! No rush just wanted to ping you in case you didn't notice it originally, or forgot about it.

Hi @bojand
Sorry for such a long silence. I was able to test your RC version running 2500 json messages in array and it was consuming about 22% of CPU. I guess it's fine now.
Thanks for a great job and lightning fast response with this issue.

Hello, great! Thanks for confirming this improves the performance. This has been released in 0.37.0.


Check objects in arrays for snake case properties as well

@hjacobs

OK, it's getting serious :smirk: --- so what about top level array definitions with object items (they will still not be linted)?

You got me again. 😊  I fix it.


Feature/panda 3072

As a customer, I want enable/disable the notification, so that I can receive the notification via my preferred channel(s)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Configure java runtime cannot list all jdks

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.61.0
OS Version: win10 X64 10.0.19042

Steps to Reproduce:

Open a java file “configure java runtime” will auto open
Or ctrl+shift+p then input “java:Configure java runtime”

I have installed jdk 1.8/openjdk 11/open jdk 16.
The very first time it only show 1.8, after I manually download and install "JavaCodingPack-0.3.16.exe", it could list 16, but jdk 11 is still not available.
Is there a way to list all of them?

/extJava


Disable performance overlay for public store builds

When building for the public stores (play and app), we should disable/hide the performance overlay.

cc @HansMuller and @collinjackson have an idea for how to do this. Thanks!

Thanks!


Use codecov.io and enable source maps for coverage.

Once coverage has run successfully, Travis will push the lcov.info
file to codecov.io using the codecov.io npm package.

Make coverage use source maps

Use isparta instead of istanbul-instrumenter.
Load the source files with isparta, while loading
the test files normally using babel loader.

Current coverage is 98.10%

Branch #34 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

Sweet :cake: