HADOOP-17276. Extend CallerContext to make it include many items

JIRA: https://issues.apache.org/jira/browse/HADOOP-17276

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m  9s
trunk passed

+1 :green_heart:
compile
19m 28s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m  0s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 53s
trunk passed

+1 :green_heart:
mvnsite
1m 29s
trunk passed

+1 :green_heart:
shadedclient
16m 53s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 34s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 15s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s
the patch passed

+1 :green_heart:
compile
18m 43s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 43s
the patch passed

+1 :green_heart:
compile
16m 42s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 42s
the patch passed

+1 :green_heart:
checkstyle
0m 51s
the patch passed

+1 :green_heart:
mvnsite
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 20s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 36s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 54s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

188m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2327

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux bcc334057c52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6b5d9e2334b

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/1/testReport/

Max. process+thread count
1404 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 28s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
29m 24s

trunk passed

+1 :green_heart:
compile
19m 35s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
16m 58s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 56s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
shadedclient
16m 59s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
2m 15s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 13s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s

the patch passed

+1 :green_heart:
compile
18m 45s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 45s

the patch passed

+1 :green_heart:
compile
16m 57s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 57s

the patch passed

-0 :warning:
checkstyle
0m 52s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 117 unchanged - 0 fixed = 119 total (was 117)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  4s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
2m 21s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 33s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

160m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2327

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 8fb7534c2dca 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 18f9d77c46f

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/2/testReport/

Max. process+thread count
1522 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hi @aajisaka @liuml07, any idea for this?

The questions about the design were posted in the JIRA, see this link.

GitHub didn't push the building result. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/7/console Failed Tests pass locally

@liuml07 @goiri Thanks for review.

Add getContext and getSignature to Builder

make ":" constant

replace append instead of "+"

make StringBuilder sb final

@goiri Thanks for review! Will push the fix later

Push new commit

Add javadoc and change var name with @goiri suggestions

https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-2327/10/pipeline Failed tests passed locally. Will fix the checkstyle

The latest tests https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/11/Yetus_20Report/
@liuml07 @goiri @aajisaka Any review suggestions?  Thanks!

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/17/Yetus_20Report/ Failed tests passed locally except TestNameNodeRetryCacheMetrics#testRetryCacheMetrics, and there is already issue tracking this, see https://issues.apache.org/jira/browse/HDFS-15458, it's unrelated.
Fix the checkstyle

Latest test report. https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2327/18/Yetus_20Report/, Failed tests are unrelated and  pass locally

You can merge this. Thank you @ferhui !

@aajisaka Now i have no write access to repository and maybe in progress. So could you please help to merge this ? Thanks

Merged. Thank you @ferhui, @liuml07, and @goiri !


Set Right to left direction

it's great to use SnackBar in non Lollipop android version, and have lot of option for developer,
i want to use snakeBar with RightToLeft Direction like this :

try this code to set RTL direction, but it's not work !?
Snackbar snackbar=Snackbar.with(getApplicationContext())
      .duration(Snackbar.SnackbarDuration.LENGTH_INDEFINITE)
      .text("متاسفانه خطایی در ثبت مکان رخ داده است. ")
      .actionLabel("بستن");
snackbar.setLayoutDirection(SnackbarLayout.LAYOUT_DIRECTION_RTL);
snackbar.setTextAlignment(View.TEXT_ALIGNMENT_TEXT_START);
SnackbarManager.show(snackbar,GetActivity());

is there any solution to set Direction Like this ?

Are you suggesting another layout with the proper order for RTL and let the user specify it? What would happen if the user changes the phone language back to a LTR one? Would you specify again the orientation?

i think should first get current direction in runtime and then set different snackbar layout direction  , found this solution for support in all of the API level :
public static boolean isRTL(Locale locale) {
        final int directionality = Character.getDirectionality(locale.getDisplayName().charAt(0));
        return directionality == Character.DIRECTIONALITY_RIGHT_TO_LEFT ||
                directionality == Character.DIRECTIONALITY_RIGHT_TO_LEFT_ARABIC;
    }
//and get current locale by
Locale currentLocale = getResources().getConfiguration().locale;
if(isRTL(currentLocale)){
  //set RTL layout
}
else {
 //set default layout
}

so if user change Language to LTR one ,it's work as expected.

@atahani: salam jenab harani? khobid? I want to use snackbar in my app and my texts are in RTL format. can i use this library for my purpose? Thanks.

This library is deprecated, now you can use from android support design library
It's support RTL direction in API > 17 , And for lower API version should set custom layout.

Just use ViewCompat.setLayoutDirection(view, direction) using android.support.v4.view
Ex: ViewCompat.setLayoutDirection(findViewById(R.id.my_view), ViewCompat.LAYOUT_DIRECTION_RTL);


[BUG] Support for higher versions of python

Describe the bug
In higher versions of python (python 3.8.14+), I found that mars does not work as expected.
To Reproduce
To help us reproducing this bug, please provide information below:

Your Python version (3.8.14+)
The version of Mars you use (0.9.0)
Versions of crucial packages, such as numpy, scipy and pandas
Full stack of the error.
Minimized code to reproduce the error.

Install pymars 0.9.0 in python 3.8.14:
$ docker run -it python:3.8 /bin/bash
root@2cf33aa8d215:/# pip3 install pymars
root@2cf33aa8d215:/# python3
Python 3.8.14 (default, Oct  5 2022, 15:43:08)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import mars.dataframe
/usr/local/lib/python3.8/site-packages/mars/tensor/__init__.py:381: FutureWarning: In the future `np.object` will be defined as the corresponding NumPy scalar.  (This may have returned Python scalars in past versions.
  from numpy import object, int, bool, float
/usr/local/lib/python3.8/site-packages/mars/tensor/__init__.py:381: FutureWarning: In the future `np.bool` will be defined as the corresponding NumPy scalar.  (This may have returned Python scalars in past versions.
  from numpy import object, int, bool, float
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/mars/dataframe/__init__.py", line 39, in <module>
    from .datasource.date_range import date_range
  File "/usr/local/lib/python3.8/site-packages/mars/dataframe/datasource/date_range.py", line 303, in <module>
    closed=NoDefault.no_default,
  File "/usr/local/lib/python3.8/typing.py", line 759, in __getattr__
    return getattr(self.__origin__, attr)
AttributeError: '_SpecialForm' object has no attribute 'no_default'

Install pymars 0.9.0 in python 3.9.14:
$ docker run -it python:3.9 /bin/bash
root@2cf33aa8d215:/# pip3 install pymars
root@d6bbd3d171e9:/# python3
Python 3.9.14 (main, Sep 13 2022, 14:50:42)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import mars.dataframe
/usr/local/lib/python3.9/site-packages/mars/tensor/__init__.py:381: FutureWarning: In the future `np.object` will be defined as the corresponding NumPy scalar.  (This may have returned Python scalars in past versions.
  from numpy import object, int, bool, float
/usr/local/lib/python3.9/site-packages/mars/tensor/__init__.py:381: FutureWarning: In the future `np.bool` will be defined as the corresponding NumPy scalar.  (This may have returned Python scalars in past versions.
  from numpy import object, int, bool, float
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/mars/dataframe/__init__.py", line 39, in <module>
    from .datasource.date_range import date_range
  File "/usr/local/lib/python3.9/site-packages/mars/dataframe/datasource/date_range.py", line 303, in <module>
    closed=NoDefault.no_default,
  File "/usr/local/lib/python3.9/typing.py", line 710, in __getattr__
    return getattr(self.__origin__, attr)
AttributeError: '_LiteralSpecialForm' object has no attribute 'no_default'

For the lower version of python(3.7), it can work as expected.
$ docker run -it python:3.7 /bin/bash
root@2cf33aa8d215:/# pip3 install pymars
root@f8d6ffd9cbff:/# python3
Python 3.7.13 (default, May 28 2022, 14:49:57)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import mars.dataframe
>>>

Expected behavior
Support for higher versions of python.
Additional context
Add any other context about the problem here.

The upcoming release will address this issue.

Thanks

v0.10.0 has been released, you can try to update Mars to the newest version, I will close this issue first, feel free to reopen if you encounter any issue.


Custom oauth2 provider support

If I create an OAuth2 Identity Server, will this plugin allow me to specify the relevant information to authenticate and retrieve an access token from my own server?

Valid question.
Right now there is no generic provider as part of the library. If you want to use it with your own identity server you'd have to fork it and add your setup.
Best,

Hi There, is this still the case ?

hope have generic provider


Different queries

Hi! Thank you very much for the bot!
Can you help me — how to use several different queries?

how did you do the queries?
i tried https://twitter.com/search?f=tweets&q=from%3AItMeIRlNEW
and https://api.twitter.com/1.1/users/search.json?f=tweets&q=from%3AItMeIRlNEW
it doesn't work


Angular2SPA, Importing CSS from node_modules with @ on the name

In the Angular2SPA template, the Angular 2 style statement cannot use @ character on the style path, if it is referencing a css file located inside a node_module with @ character on its name.
Example will be Telerik Kendo UI.  One their website, their public npm is @progress.
http://www.telerik.com/kendo-angular-ui/getting-started
@Component({
selector: 'counter',
styles: [require('@progress/kendo-angular-buttons/dist/npm/css/main.css')], // load the button theme
template: require('./counter.component.html')
})
when the path is added the TSC generates the following error.
ERROR in ./ClientApp/app/components/app/app.component.css
Module parse failed: C:\workspace9\Angular2Spa\ClientApp\app\components\app\app.component.css Unexpected character '@' (1:0)
When the @ is removed, the TSC only complains the path cannot be found.

I agree this issue exist for ngprime too..

First, thanks for reporting this.
Second, are you sure the problem is really the @ on the package name? I don't think it is: I suspect the @ it's complaining about is really one inside the .css file (e.g., for a media query). It would complain about this if it was not loading via Webpack, and hence the require caused Node to try to parse it as JavaScript instead of CSS. I think this is happening because aspnet-webpack adds a nodeExternals entry to your config that causes all files under node_modules to be excluded from the bundle, which means any CSS file in a node_module would get loaded at runtime instead of being bundled correctly.
This issue with aspnet-webpack is a bug that I will fix.

Correct, in my case the issue is as you explained. It fails when loading the css because it has @ and other special characters. Also i tried to load the node_module css file via linking as stylesheet inside layout but node_modules is not available under the wwwroot and at runtime css files are not loaded
How to resolve this ?? Thax again for looking into this.

The aspnet-webpack NPM module has now been updated to include a fix for this. If you upgrade your copy (run npm install aspnet-webpack in your project directory), the problem should go away.
Note that since you're now loading .css files under node_modules/ via Webpack, you'll need to ensure that your Webpack configuration for .css files is allowed to match all files, not only those under ClientApp/. You have probably figured that out already (judging by your issue report), but just for anyone else's benefit, you need to remove the include restriction like I did in this commit: https://github.com/aspnet/JavaScriptServices/commit/f79936c10459c5982bf64ac4cc1532019f194596

@SteveSandersonMS now with new aspnet-webpack and changing the loaders in webpack.config i don't see any exception. Still components don;t show proper theme, also i checked vender.css but the primeng css are not added to that.
Are we missing something ? I was under assumption that all css will be compiled into vendor.css

I was under assumption that all css will be compiled into vendor.css

If you want the CSS to be bundled into vendor.css, then you don't need to do any of the stuff above. You just need to reference the desired CSS file from your webpack.config.vendor.js. Here's a trivial example: https://github.com/aspnet/JavaScriptServices/commit/135e264ae2c15f824e5f88a6a0e91d8dd4089cd3
Notice how it's not necessary to reference the styles from your Angular 2 components at all, because they are being loaded globally, not scoped to a particular component. (Having them scoped to particular components would be undesirable if what you're loading is really some large vendor-supplied CSS file, because you'd be duplicating all that CSS for each component it was scoped to, possibly adding hundreds of kilobytes to your page.)
Note that this example is based on latest template source code, so when making the same changes to your webpack.config.vendor.js file, be sure also to copy the changes to the loader config there too so it can match URLs with querystrings (see how those test regexes end with (\?|$) and not just $).


fix Fix recycler compilation issue with libhdfs3

This PR fix compilation error for cloud recycler when the USE_LIBHDFS3 flag is enabled.

run buildall


ci: check lockfiles

#558  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pepyakin and the rest of your teammates on  Graphite


MQ: Exchange: Key value of msg is stored in stack space

Please don't merge it until my PR is already. I will merge it later

exchange_client_test has failed, plz check it out.

@JaylinYu Your commits seems break the unit test of exchange

exchange_client_test has failed, plz check it out.

UT begin aio before sock_send, but aio begin in sock_send, fixed now


Hot Reloading?

Dismissed in early versions before Indigo only targeted Scala.js, but since games are now targeted at browsers, we could persist the game state every frame and reload the JS files on-change with a file watcher. You'd have to restart the engine (in case it was an asset change) but due to the way state is managed the pause would only be brief?

Late follow up comment: Tyrian does this.
A future Indigo improvement would be to replicate Tyrian's hot reloading approach into Indigo.
I think there are two workarounds though:

Tyrian natively supports Indigo games. So you could set up a Tyrian project, add hot reloading, integrate your game, and get the hot reloading events to propagate through to Indigo.
Tyrian's hot reloading is just a 'save to local storage (overwrite) every second' and when the site loads, load from local storage if it exists. It's horribly simple and very effective. It could just be implemented per game in a subsystem.


Example of using the new design library, but with ListView?

Is it possible to show an example (using the new design library) of how to handle ViewPager+tabs+fragments with ListView, where each (vertical) scrolling of ListView would show/hide the actionbar?
So far, I've seen it only for RecyclerView. I've tried to use ListView, but it just doesn't work.

If you care about new library, why don't you just use new RecyclerView :D

Sorry, I can't. I was told to still use the ListViews of the fragments, as they are very complex and converting to RecyclerView won't be easy at all.

I see. Well AFAIK, the latest Design Library won't support legacy items (like ListView or event ScrollView). So you may need some extensions ...

That's too bad. Do you know perhaps of such extensions?
Or, what will it take for me to make ListView work nicely with the scrolling of the actionBar ?
Isn't there maybe an interface that I can implement for a customized ListView , and then it will work just like it works for RecyclerView ?

@AndroidDeveloperLB The current working "scrolling components" are RecyclerView and NestedScrollView which respectively, implement ScrollingView and NestedScrollingChild interfaces. They enable their childs to be able to scroll and handling the scrolled mount.
Furthermore, new Design Library comes with the "Behavior" concept (CoordinatoorLayout's component) which takes care of scrolling behaviors. And if you decompile the source of that library, you can see that they implement some Subclasses of Behavior for those interface I remind above, to calculate the scroll of childs as well as limit the view which can be handled. So if you want to have that in your listview, I guess you must start from the abstract AbsListView and implement those interface propertly, or else You need to create your own subclass of Behavior to handle your listview (I consider this a better solution, but still not be able to do that). So please take a look at the (not public yet) source code and try. I'm creating the same thing though, but I don't have any good news for you, so please wait and see some update out there.

This seems like it will take a lot of time to work on, and sadly I don't have it (which is a part of the reason I was told not to convert the ListViews to RecyclerViews) . I think I will try to avoid using the new design library for that matter, but will use other components of it whenever possible.
Sorry, and good luck.
If you finish, please let me know.
I have some repos that might be useful for you, if you wish to check out.


Avoid moving DictionaryChunks

There was a regression in #2994 which wasn't caught by our test suite. On some datasets it was causing a segfault when copying rel tables.
DictionaryChunk now stores pointers in its internal cache which would be invalidated when moving and can't be easily updated (which is understandable, changing the hash function and equals functions in an unordered_set usually would be expected to break things, even if in this case it would be safe).

Do we have a minimal example to reproduce this? so we can add to our test suite.

@benjaminwinger I'm merging it so we can ship to for today's nightly build.

I'll see if I can come up with an example. It's caused by accessing strings after StringColumnChunk::finalize (where the move happens), which I think only occurs if we're copying multiple node groups, so maybe we don't have any tests where we copy multiple node groups of strings.


fix($location) : initialize locationPrototype.$$absUrl to empty string

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Initialize locationPrototype.$$absUrl to avoid a crash when base href and current location have different domains.
What is the current behavior? (You can also link to an open issue here)
#11091
What is the new behavior (if this is a feature change)?
Does not crash anymore.
Does this PR introduce a breaking change?
I don't think so...
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Closes #11091

Hi, I just signed the CLA.

Seems reasonable, but one can never be too sure with $location stuff :stuck_out_tongue:
/cc @petebacondarwin for the final LGTM
(The CLA thing doesn't seem to have worked btw...)

I signed the CLA with another account. My mistake.
I just signed it again with the right email.

This should also fix #13565.

LGTM


Update

@amitshekhariitbhu
thank-you to provide the code. please update the code with showing download progress on notification

@redragon14368 you can create your own solution by simply starting a ForegroundService or WorkManager with setForegroundAsync

@redragon14368 you can create your own solution by simply starting a ForegroundService or WorkManager with setForegroundAsync

sir can you give it's code, how to do it


[New Core]: Game and Watch

Core Author username
agg23
Core .yml snippet
display_name: Game and Watch
repository: fpga-gameandwatch

Needs a filter so it avoids the mister zip… just checking how those work…


Cython problem with PyPI installation on python 3.6 Linux

Hello team,
We've been using GPy (currently v1.9.9) on Ubuntu and Red Hat HPC linux systems for a a few years (currently sticking with python 3.6), and the pip installation has always served us well. Recently, we've been having problems with performance on our HPC setup. We can still compute, but it would be great to get back to cython:
warning in stationary: failed to import cython module: falling back to numpy
warning in coregionalize: failed to import cython module: falling back to numpy
warning in choleskies: failed to import cython module: falling back to numpy
We tried with both custom virtualenv (with Cython pre-installed) and with anaconda, but no luck. Cython appears to be recognized and the *so libraries compiled, but nothing. This issue appeared in an old thread that is now closed. Are we missing something, is there an easy way to fix this?
Many thanks and all the best, Milica.

Could you post the anaconda, cython and gcc version of your environment? Normally, it fails due to an incompatible cython version or gcc version.
One thing that you could try is to install gcc with anaconda:
conda install gcc

I've been encountering the same issue in my Docker containers (built on Python 3.7 slim). The Docker images don't haave conda, so my temporary work around has been to add build-essentials to the container and force the order of installation cat requirements.txt | xargs -L 1 pip install < requirements.txt, with the order being paramz followed by Gpy.

@zhenwendai @will-sim I have a similar issue but I wasn't able to resolve it.
Environment:

Docker
Docker image: jupyter/minimal-notebook:latest (with Python 3.7)
conda 4.8.2
conda virtual env with Python 3.6
gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
paramz             0.9.5
Cython             0.29.10
GPy                1.9.9
GPyOpt             1.2.5

@jakubigla I could not reproduce your error. Could you provide a doker file to reproduce the error? Do you install GPy via pip or from source code?
The following are what I tried:
docker run -it jupyter/minimal-notebook:latest /bin/bash
wget https://repo.anaconda.com/archive/Anaconda3-2020.02-Linux-x86_64.sh
bash Anaconda3-2020.02-Linux-x86_64.sh -b
pip install GPy

I did not get any warning messages regarding cython.

@zhenwendai
Dockerfile:
FROM jupyter/minimal-notebook

RUN wget https://repo.anaconda.com/archive/Anaconda3-2020.02-Linux-x86_64.sh

RUN bash Anaconda3-2020.02-Linux-x86_64.sh -b

RUN pip install GPy matplotlib

Python 3.7.6 | packaged by conda-forge | (default, Mar  5 2020, 15:27:18)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from GPy.util import choleskies_cython
warning in stationary: failed to import cython module: falling back to numpy
warning in coregionalize: failed to import cython module: falling back to numpy
warning in choleskies: failed to import cython module: falling back to numpy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'choleskies_cython' from 'GPy.util' (/opt/conda/lib/python3.7/site-packages/GPy/util/__init__.py)```

I see. cython needs to be manually installed due to a historical reason (cython was not available on windows).
The following docker file should work:
FROM jupyter/minimal-notebook

RUN wget https://repo.anaconda.com/archive/Anaconda3-2020.02-Linux-x86_64.sh

RUN bash Anaconda3-2020.02-Linux-x86_64.sh -b

RUN pip install cython matplotlib

RUN pip install GPy

Thank you @zhenwendai now everything works like a charm. I was experimenting with installing cython as well, but never got it working. Seems like a right order is super important. Much appreciated.

Hi @zhenwendai, thanks for helping out with this and sorry for the late response.
I am running GPy on an Intel-based supercomputer with access to many computational environments, including plenty of GNU/Intel, but little python.
My preferred setting is with intel compilers and basic gnu, no anaconda. Here I deliberately installed Cython first, then GPy, but still get the problem.
Python 3.6.8
Cython 0.29.15 (installed first)
gcc version 4.8.5
The alternative setting involves anaconda, and as much gnu as you like - any recommendation?
Anaconda 2019.3
Python 3.7.3
Cython 0.29.6
gcc version 4.8.5 -  have access to gcc 7.4.0/8.3.0/9.1.0
Quick question: seems Cython really facilitates GPy, but it’s not on the list of dependencies. Since I don’t develop with anaconda, it was easy to miss this - why not make it a dependency?

@milicasan That's intereting. Could you run pip install GPy -v and post the error messages here?
It was a historical reason for not including Cython in dependency. In the early versions, cython was not supported on Windows (cygwin) and we shipped the c files instead of the cython files for installation. We stopped doing that due to compatibility issues of the c files across python versions. I have recently included the cython dependency in the current devel branch.

Hi @zhenwendai, good to hear about Cython dependency. Here is the verbose output of the installation:
Non-user install because user site-packages disabled
Created temporary directory: /local_scratch/mtodorov/pip-ephem-wheel-cache-q_4e93dv
Created temporary directory: /local_scratch/mtodorov/pip-req-tracker-960a235v
Initialized build tracking at /local_scratch/mtodorov/pip-req-tracker-960a235v
Created build tracker: /local_scratch/mtodorov/pip-req-tracker-960a235v
Entered build tracker: /local_scratch/mtodorov/pip-req-tracker-960a235v
Created temporary directory: /local_scratch/mtodorov/pip-install-qjq842dj
Requirement already satisfied: GPy in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (1.9.9)
Requirement already satisfied: scipy>=0.16 in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (from GPy) (1.4.1)
Requirement already satisfied: paramz>=0.9.0 in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (from GPy) (0.9.5)
Requirement already satisfied: six in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (from GPy) (1.14.0)
Requirement already satisfied: numpy>=1.7 in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (from GPy) (1.18.2)
Requirement already satisfied: decorator>=4.0.10 in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (from paramz>=0.9.0->GPy) (4.4.2)
Cleaning up...
Removed build tracker: '/local_scratch/mtodorov/pip-req-tracker-960a235v'

Requirement already satisfied: GPy in /users/mtodorov/CODE/boss/lib/python3.6/site-packages (1.9.9)

@milicasan, thanks for sharing the error message. It seems that GPy has already installed in the system. It does not show how the GPy cython installation failed. Could you start a clean installation and post the error message?

Hi @zhenwendai, I thought you were asking for details of my previous GPy installation, where I had installed Cython first and was still getting error messages. Please see the install log for a clean installation attached, it does look strange. My pip is 20.0.2, python 3.6.8, OS is Red Hat Enterprise 7.7 for x86_64. Many thanks!
GPy_install.log

Hello @zhenwendai, we are still experiencing these problems. Any idea how to resolve this? Many thanks, Milica.

@milicasan Sorry for the long delay.
From the log, it seems that pip tries to install from wheel but maybe the compiler and libc library is not compitible with the wheel.
Could you try to install from the source code?
git clone https://github.com/SheffieldML/GPy.git
cd GPy
pip -v install -e .


Error when git cloning repo

Hi;
I git cloned this repo and received this error messages, please advise.
Alis-MacBook-Air:terraform-google-nomad aaktar$ terraform get
Get: git::ssh://git@github.com/hashicorp/terraform-google-consul.git?ref=v0.0.1
Error loading modules: error downloading 'ssh://git@github.com/hashicorp/terraform-google-consul.git?ref=v0.0.1': /usr/bin/git exited with 128: Cloning into '.terraform/modules/1216a0b2f43677d000c147c002a85f0c'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I'm afraid I can't reproduce this. Here's what I receive:
josh@pad-mac /p/tmp> git clone https://github.com/hashicorp/terraform-google-nomad
Cloning into 'terraform-google-nomad'...
remote: Counting objects: 137, done.
remote: Total 137 (delta 0), reused 0 (delta 0), pack-reused 137
Receiving objects: 100% (137/137), 1.34 MiB | 511.00 KiB/s, done.
Resolving deltas: 100% (63/63), done.
josh@pad-mac /p/tmp> cd terraform-google-nomad/
josh@pad-mac /p/t/terraform-google-nomad (master)> terraform get
Get: git::ssh://git@github.com/hashicorp/terraform-google-consul.git?ref=v0.0.1
Get: file:///private/tmp/terraform-google-nomad/modules/nomad-firewall-rules
Get: file:///private/tmp/terraform-google-nomad/modules/nomad-cluster
Get: file:///private/tmp/terraform-google-nomad/modules/nomad-firewall-rules
josh@pad-mac /p/t/terraform-google-nomad (master)>

This is definitely a public repo (hence your ability to submit this ticket!), so I'm assuming this is a local environment issue for you. The GitHub doc on Error: Permission denied (publickey) may help you resolve this.
I'm going to close this ticket since this issue is unrelated to this repo.


Profile

picture>

About me
Hi, I'm Mona. You might recognize me as GitHub's mascot.
How it looks

Rank
Languages

1
SQL

2
Python

3
Java


Add completed field to session model

Refs https://openscience.atlassian.net/browse/LEI-133
Companion to https://github.com/CenterForOpenScience/experimenter/pull/73
See companion PR for description.

Looks like this might overlap with https://github.com/CenterForOpenScience/exp-addons/pull/48/files#diff-72d131960eb0a03351e599cc7d33a059R20

Looks like this might overlap with https://github.com/CenterForOpenScience/exp-addons/pull/48/files#diff-72d131960eb0a03351e599cc7d33a059R20

Good catch. But while I like the way that other PR connects the attribute to a dirty exit check, I think this implementation has a few points to recommend it:

Nomenclature: Ember uses the pattern didVerb for various model events, so I tried to avoid it in choosing an attribute name (completed vs didComplete)
When to set a value: the other PR marks something as incomplete on exit, whereas this PR assumes something is incomplete until told otherwise. (seems a bit more fault-tolerant)
Connections to other pages (the value is used to filter various pages where sessions are displayed)

Separately, the companion PR attempts to fix the issue where the preview page fails to load. (server rejects values of null being sent for empty values) This might be a useful change in itself if the other PR does not also address it.
Thoughts on implementation preference, @samchrisinger  ?

I think the dirty check is nice, but maybe impractical. For the Lookit use case at the very least, if the user leaves the study at any point (dirty or not), that session has ended. If the study was resumable, it would make complete sense to only warn if the state is dirty, but since in our system leaving the study is final I think the behavior should be a bit different.

When to set a value: the other PR marks something as incomplete on exit, whereas this PR assumes something is incomplete until told otherwise. (seems a bit more fault-tolerant)

Can you please explain this thought ^ a bit more? Or maybe that's rolled into the first explanation? Maybe a little extra logic is needed to be sure experiments that exit normally don't get marked as incomplete?


On rednode deploy connection created but old not terminated

Hi i use this node now since a short time. And I was wondering why I had more and more sessions on the mongodb.
I could find the Issue must be on the connection on this node.
When a deployment of a changed flow happens the old / current connections get's not terminated and a new connecton pool is generated.
I could not find a way to stop from this behavior except complete restart of red-node. I use actual rednode 2.1.3.

Hi hubient,
which version of node-red-contrib-mongodb4 do you use? This issue should be fixed in the latest release v1.8.1.
In theory every configuration node creates a MongoClient instance with it's own connection pool. On configuration node close. On flow redeployment the client should be closed.

Hi steineey
Thanks for the reply, I have 1.8.0 installed.
And there seems no 1.8.1 version available.
Nodejs is in the version v14.18.1.
Am 18.11.2022 um 21:51 schrieb steineey:

Hi hubient,
which version of node-red-contrib-mongodb4 do you use? This issue
should be fixed in the latest release v1.8.1.
In theory every configuration node creates a MongoClient instance with
it's own connection pool. On configuration node close. On flow
redeployment the client should be closed.
—
Reply to this email directly, view it on GitHub
https://github.com/steineey/node-red-contrib-mongodb4/issues/14#issuecomment-1320509920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQMQSPIG5XYNO6ZS7MUBU4LWI7T4HANCNFSM6AAAAAASEYIUXA.
You are receiving this because you authored the thread.Message ID:
@.***>

Check out NPM for version 1.8.1 here
Go to your node-red directory and npm install --save<EMAIL_ADDRESS>


New package: YmSoft.Nalgaeset version 10.40.83

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Nalgaeset Hangul Input System
Nalgaeset is a Korean input method software for Microsoft Windows. It mainly consists of both a self-contained text editor and a universal IME for the operating system. The two programs share the common library, and support virtually every Windows platform from 95/NT4 to 10 of any languages, both 32- and 64-bit.

Microsoft Reviewers: Open in CodeFlow

@ItzLevvie Thank you for reviewing!  I adjusted points you addressed.

@wingetbot waivers Add Validation-Domain

@wingetbot waivers Add Policy-Test-1.2


Dockerize and clean up crud

This adds a simple Dockerfile, tested on my mac to work. I couldn't get it to run in non-dockerized form, so this was an easy workaround.
I also deleted some dbt doc artifacts, logs, and some other things to keep the repo light and clean.

Actually if its ok - I'll take on the legwork here. First thing is to update the github action (like this example) but then I think I need to separate how devcontainer behaves and where the project runs. Right now the project is installed inside the devcontainer but I think the way it should work is that the devcontainer only serves up the VS code environment and then the actual project executes inside of its own docker container. This might be a bit tricky but there should be some prior art here - this link suggests running it inside the devcontainer. I think I tend to prefer not requiring the devcontainer which means keeping them separated. Its not particularly lightweight though.
Contemplating forking this into its own thing - "MDS in a box in a container" vs the simpler "just run this directly on bare metal". Looking for some feedback here.

Pulled the image down and run locally. Interestingly getting the following error
                --env MDS_SCENARIOS=100 \
                --env MDS_INCLUDE_ACTUALS=true \
                --env MDS_LATEST_RATINGS=true \
                --env MDS_ENABLE_EXPORT=true \
                mdsbox make pipeline
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
meltano install
make: meltano: No such file or directory
make: *** [Makefile:2: build] Error 127
make: *** [docker-run] Error 2```

Closing this one so you can resubmit with just those two changes.


Links property

Would it be good to have a link construct comparable to what STAC has?
https://github.com/radiantearth/stac-spec/blob/master/item-spec/item-spec.md#link-object
cc @cholmes
Copied from an early draft of the spec:

Property Name
Data Type
Description

links
[Link Object]
A list of links to other resources.

Link Object
This object describes a relationship with another entity. Data providers are advised to be liberal with links.

Field Name
Type
Description

href
string
REQUIRED. The actual link in the format of an URL. Relative and absolute links are both allowed.

rel
string
REQUIRED. Relationship between the current document and the linked document. See chapter Relation Types for more information.

type
string
IANA media type of the referenced entity.

title
string
A human readable title to be used in rendered displays of the link.

Relation Types
Where possible it is recommended to use the official IANA Link Relation Types.

Type
Description

self
STRONGLY RECOMMENDED. Absolute URL to the location that the file can be found online, if available. This is particularly useful when in a download package that includes metadata, so that the downstream user can know where the data has come from.

license
The license URL(s) for the data SHOULD be specified if the license field is set to other. If there is no public license URL available, it is RECOMMENDED to put the license text in a separate file and link to this file.

Might be an extension in the future, see https://github.com/fiboa/extensions/issues/8


Support for Transaction Author Agreement

IDunion will enforce the transaction author agreement. We have to find out how we handle that.

Info: https://sovrin.org/preparing-for-the-sovrin-transaction-author-agreement/

ACA-Py provides two relevant routes
GET: /ledger/taa
POST: ledger/taa/accept

This will probably defeat various auto flags

For reference: https://github.com/hyperledger/indy-sdk/blob/master/docs/how-tos/transaction-author-agreement.md

Backend tasks:

Extend BPAState table to hold the TAA state as well.

Add a new config controller that has three endpoints

User Interaction
GET /api/config/taa
POST /api/config/taa
UI State
GET /api/config -> should contain {"webMode": true|false, "taaAccepted": true|false}

Reuse the AriesStartupTasks.registerProfileEndpoint() method to update the ledger endpoint. This needs to run once when the TAA is accepted and once on every startup as the endpoint might have been changed in the config.

UI Tasks

Get config, if TAA is not set block any other actions. Display the TAA and wait for the users approval.

remarks after call (sorry for german)
ablauf

bootstrap (startup action) läuft durch

is taa required? dann merken , dass required (noch nicht accepted) --> TAAState

Endpunkte können dann evtl. nicht geschrieben werden erstmal

BPAState zustand speichern (TAA nicht persitent, immer vom acapy abfragen)

passiert dann wenn user akzeptiert hat
else:
über RegisterEndpointService entpoints schreiben

ui kommt hoch

frägt user geg. nach taa acc
setzt taa acc
triggert impl. endpoint creation an ( --> RegisterEndpointService)

controller is über manager (REST controller)
manager klassen --> keine abh- untereinander nur nach untern
service klassen --> werden von mehreren managern / controllern benutzt
Config controller
GET /api/userconfig/  --> bool webmode, bool taarequired, bool taaaccepted
POST  /api/userconfig/taa --> bool taaaccepted
GET /api/userconfig/taa --> taa text +?

Remark: currently only the endpoint creation ( 2 endpoints web + aries)  requires ledger write --> TAA relevant

@vi-fu this is the story about TAA we talked about... maybe you can think about it
Basic Workflow in the Frontend could be:
When the Frontend is launched or on browser reload, the backend should be asked if TAA is required.
If TAA required, TAA text is queried to from backend and shown to the user.
Frontend is blocked if user does not accept TAA.
Open point:
How to cache the "TAA acceptance state"  in the frontend?
Several ideas:
1a) TAA state could be cached in the vuex store ( But this works only if the store is used by all or most pages)
1b) state is cached via session cookie
2) TAA state is not cached at all
2a) but checked before each call to the backend ( in the backend the state is cached anyway) or
2b) error from BAckend in handled if TAA is not accepted ( difficult because we need a well defined error in that case)

I don't think its necessary to block the frontend. I'd say its enough to highlight this in the Dashboard and maybe add a red notification marker in the Menu at the Dashboard slot.
The only thing that is not possible is to add something to the public profile. All the rest works without having accepted the TAA.

We could just handle this in App.vue or main.js

@domwoe ideally you check the TAA state before each API call (if you get the state from backend or cache it yourself we can later decide). But for that we would need something like a api utility class in  the frontend I assume --> otherwise you have to add that to all api calls

I just talked to a frontend guy here.
He also would do something like  the TAA acceptance handling in app.vue ( wenn app is  loaded)
If we do not need this info in the rest of the user session, there is probably no need to store it in a vuex store.
(like for  other data , e.g. "expertMode" )
Let's talk about that on monday...

taa changed sollte der user auch mitkiegen (im unterschied zum ersten mal)

@domwoe @vi-fu
If we only write the endpoints to the ledger as the only action which requires TAA, I recommend we the following Acceptance Mechanism List (AML):
For Session: The agreement was reviewed by the user and accepted at some point in the user’s session prior to submission. When starting the software session, the user is given the opportunity to review and accept the agreement as the Transaction Author. This acceptance is then stored and reused for any other writes during the current session.

See https://github.com/sovrin-foundation/sovrin/blob/master/TAA/AML.md
In this case there is no need to store the users acceptance state. we'll ask whenever  new endpoint(s) are written

@frank-bee I'm not sure if I understand, but the AML is defined by the network and not by us. We can only decide to use a an acceptance mechanism that is in the AML on the ledger. In case of the IDunion network, it'll most probably start with an AML that supports all mechanisms

correct. But for our usecase the "session AML" makes sense I think.
Because like this the use has to explicitly accept the TAA again, when a new endpoint is written ( no matter if TAA text changed or not). It anyway won't happen very often.

Maybe even "At Submission" is even better, if we only do one transaction ( setting 2 endpoints is probably too transactions)
At Submission: The agreement was reviewed by the user and accepted at the time of submission of this transaction. At the time of preparing and submitting the transaction, the agreement was displayed to the user and the user was prompted to review it and agree as the Transaction Author. The acceptance date will be the date the transaction was submitted.
For Session: The agreement was reviewed by the user and accepted at some point in the user’s session prior to submission. When starting the software session, the user is given the opportunity to review and accept the agreement as the Transaction Author. This acceptance is then stored and reused for any other writes during the current session.

I have drawn a little plan UML
https://hackmd.io/h_3WU3-4SxK-dsvTKYwwQw?both

@vi-fu I have updated the document https://hackmd.io/h_3WU3-4SxK-dsvTKYwwQw?view
--> see REST calls at the bottom
I have pushed the code to master , so you can test the frontend code against it.

one thing... currently TAA is not enabled on our test ledger.
so maybe you have to "blindly"  programm against it, and I will test on my local test ledger.

Ok, we'll do so.

@vi-fu
Text in the dialog / component could be:
To allow other companies to communicate with this agent, some configuration has to be written to the ledger - the endpoint configuration.
In order to do so, the transaction author has to accept the Transaction Author Agreement for this session which is the following:
...
...
[  ] As transaction author I reviewed and accept the above Transaction Author Agreement for this session.

@vi-fu
I forgot to check how such a TAA actually looks like.
It is probably pretty long and the String will support markdown.
See example here:
https://sovrin.org/wp-content/uploads/Transaction-Author-Agreement-V1.1.pdf
(markdown version not yet available , see bottom here
A textfield with scrollbar , ideally markdown support would be good, not?

something like this might be useful
https://github.com/miaolz123/vue-markdown
(but seems to be not active this component/repo)

something like this might be useful
https://github.com/miaolz123/vue-markdown
(but seems to be not active this component/repo)

Had it installed, but used dependency package is not save --> cross site scripting
Found something else:
https://www.npmjs.com/package/vuetify-markdown-editor

@vi-fu  What about https://github.com/cloudacy/vue-markdown-render ?
Editor seems to be a bit too much

@domwoe good point. Changed!

great work @vi-fu , great collaboration! fixed


multimc: unstable -> 0.6.12

Motivation for this change
upstream release
Changelog
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 117376 run on x86_64-linux 1

1 package built:

multimc


[Q] How to delete team in wandb

Is there a way that I can delete a Team or rename a Team in wandb? I searched in the doc and Google but did not find a way. Any help is appreciated!!  -- Jie

Are there any updates on this?

Also wondering about the progress of this. And possibly renaming teams?

Thank you for your patience! We now have the ability to delete teams :) You can do this at the wandb.ai/teams/<team_name> page.


Remove as many grid lines as possible, especially vertical ones

the pr for #14 slightly addresses this

the highcharts chart has a lot less lines closing for now


Convert top ~20 largest images (by file size) to WebP

Following up on https://github.com/stride3d/stride-website/issues/126, I've converted 22 of the largest images by file size to WebP and updated references to the images on the site accordingly. This should help reduce the footprint of parts of the site without sacrificing the overall quality of the images.
With this in mind, I was unable to identify where the following files are used on the site, so they were skipped:

\images\og\ogp.jpg
\images\showcase\sengokurun.jpg
\images\blog\release-1.0-alpha\XenkoStudio_1_0_0_alpha07.jpg
\images\blog\release-2.0\light_probes.jpg
\images\external\script-editor.png
\images\showcase\JumpyJet2D.jpg
\images\features\graphics\vr.jpg

I can go back and convert these too, if we know where the references need to be updated.

One last thing. There is one new file which shouldn't be there and we don't need it. Could you remove package-locks.json. Note that s at the end. Maybe some backup file on your side 🤣.

Whoops! Was doing some quick and dirty debugging and that slipped through heh. Removed the file.

Thank you @parhamgholami


Bluetooth: HCI: Disconnecting when ISO data path isn't set when there is a TX

Describe the bug
This was uncovered by https://github.com/zephyrproject-rtos/zephyr/pull/75549 and discussed in Discord.
TL;DR: There is a bug in the HCI controller when using e.g. the nRF52840 board (or any board using a synchronous HCI driver) where a TX may return an error. This error triggers a disconnect issue, when it really shouldn't as that is not how an HCI driver should behave.
Below is the discussion from Discord:
[1:41 PM]Emil Gydesen (Thalley): @jhedberg @jori-nordic @alwa-nordic @cvinayak
I encountered a race condition / TX issue with the changes from https://github.com/zephyrproject-rtos/zephyr/pull/75549
This PR effectively makes setting up and removing the ISO data paths an API, so that the upper layers have better control of them.
Initially this looked like a race condition, but after looking further into it, it looks like a HCI driver issue.
First I'll explain the initial issue that I saw which is I though was a race condition:
The race condition happens when

App connects CIS
App setups TX data path for CIS
App sends some ISO data that is then enqueued
App removes the data path
bt_conn_tx_processor is then called but fails due to:

d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_ctlr_hci: hci_iso_handle: Input data path not set for HCI
d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_conn: send_buf: Unable to send to driver (err -22)
d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_conn: bt_conn_tx_processor: Fatal error (-5). Disconnecting 0x8258240
d_00: @00:00:15.694387  [00:00:15.694,366] <wrn> bt_conn: bt_conn_tx_processor: conn 0x8258240: not connected

This triggers a disconnection of the CIS.
At first it looked like it would be possible and make sense to simply clear all pending data for the CIS when removing the data path, but that does not prevent applications from sending new data.
In fact the issue is as simple as:

App connects CIS
App sends some ISO data (without setting up the data path).

And if that happens, the CIS is then immediately disconnected, which seems a bit drastic for a simple rejection.
When we send ISO data over HCI on async driver (e.g. IPC) then the controller can actually not reject the data at all, it can at best ignore it and send a command complete event, but if we send it over a synchronous driver like we have in this case, then it triggers a disconnect
[1:45 PM]Emil Gydesen (Thalley): That is a huge difference in behavior based on the type of driver.
We could, in the host, keep track of the ISO data paths to ensure that we never attempt to send anything to the controller, as well as clearing all data when removing the data path, but that's a significant change, and the state of the ISO data paths in the controller is non-trivial as it depends on what type of ISO channel it is (different behavior for Central CIS, Peripheral CIS, Broadcast source BIS and sync receiver BIS).
The current driver and TX path seems to assume that all connections are equal, and that the data path is always there, which is an assumption that isn't true for ISO channels.
I'm not sure what the right solution is, but IMO it makes sense to have similar behavior regardless of the driver and definitely not disconnecting the channel when removing the data path.
Please share your thoughts
[2:28 PM]Aleksander Wasaznik: I agree, the integrated Controller's HCI driver has to behave the same as a normal HCI driver. It is not OK for bt_send to return any error value from the Controller. It's only for transport errors. Errors from the Controller have to come though a Command Status event or similar. As you say, for ACL/ISO data there is no error response available, so errors must be ignored.
[2:41 PM]Emil Gydesen (Thalley): @alwa-nordic will you or @jori-nordic take a look at fixing this? Would be nice if we can get that fixed before the 3.7 release if we consider it a bug
[8:22 AM]Aleksander Wasaznik: @Vinayak Kariappa Chettimada Do you agree the driver is at fault here?
[10:14 AM]Aleksander Wasaznik: The error is generated here in the Controller:
https://github.com/zephyrproject-rtos/zephyr/blob/9b305d5d72d1be6a648a82cc491f9806f34e6848/subsys/bluetooth/controller/hci/hci.c#L5882-L5885
I think we cannot just ignore/remove the error, since the Host is expecting a NumComplete back. Will it be generated despite the early return at the above-linked code site?
[10:25 AM]Vinayak Kariappa Chettimada: What does the spec say about num completes for non-existent data path? why is ISO data supplied without data path?
[10:37 AM]Aleksander Wasaznik: I think even if the Host violates some rule here, the Controller must do something to free the Controller buffer for the Host, in a way that works over HCI. The only options for this are a normal NumComplete, DisconnectionComplete, or HardwareError. Otherwise the buffer leaks.
[10:40 AM]Emil Gydesen (Thalley): I don't think a missing data path should be considered different than any other invalid data from the host (e.g. if sending ISO data with bad sequence number or flags)
[10:43 AM]Aleksander Wasaznik:
What does the spec say about num completes for non-existent data path?
This is a good question. I can't find anything after looking for a few minutes. Still I think HCI buffer management should be a separate concern anyway, and the configured data path should not affect this.
As to the contents of the buffer, I suspect it's not specified, in which case it's up to us if we accept the data and send it despite no (or even otherwise configured) data path or discard it.
[1:37 PM]Aleksander Wasaznik:
why is ISO data supplied without data path?
Using our Host API, the application can queue ISO data, and then de-configure the data path. The Host treats the two operations asynchronously, and can serialize them in opposite order onto HCI. It arguable whether this is OK; maybe the Host should not let this happen. But we think this uncovered a flaw in ZLL's HCI implementation.
[1:44 PM]Emil Gydesen (Thalley): Regardless of whether the host should allow it or not, shouldn't really matter here. It's not disallowed by the core spec as far as I can tell, nor should the result of such behavior be to disconnect the ISO channel.
There's also the case that this is driver dependent. If we are using e.g. the IPC driver then it's a non-issue, and IMO drivers shouldn't really be in charge of this.
[8:01 AM]Aleksander Wasaznik: Fixing this in the Controller will be hard for me and @jori-nordic , since I'm not familiar with its code. @cvinayak , do you have capacity to look into this this week?
@Thalley , do you think this bug can be triggered in Zephyr 3.7 (i.e. without your API change)?
[8:56 AM]Emil Gydesen (Thalley):
@Thalley , do you think this bug can be triggered in Zephyr 3.7 (i.e. without your API change)?
If someone sends the HCI commands directly without the host API, then yes, otherwise no.
@cvinayak , do you have capacity to look into this this week?
Isn't the hard freeze tomorrow, which means that any PR should have been created yesterday at the latest?
[9:14 AM]Aleksander Wasaznik: Ok, let's target next release for a fix.
[9:48 AM]Emil Gydesen (Thalley): We probably should create a GH issue for this, as we agree there's an issue here
[9:44 AM]Emil Gydesen (Thalley): @alwa-nordic  we didn't create a GH issue or applied a fix yet, right?
[11:01 AM]Aleksander Wasaznik: That's right
To Reproduce
Steps to reproduce the behavior:

checkout https://github.com/zephyrproject-rtos/zephyr/pull/75549
Build and run https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/bsim/bluetooth/audio/test_scripts/bap_unicast_audio.sh
See error

Expected behavior
Expect that TX on a ISO channel without a TX path set is just ignored by the controller and treated as any other invalid TX (num complete packets event sent to host).
Impact
Prevents a feature from being merged. May cause other issues when using the integrated HCI driver
Logs and console output
d_00: @00:00:15.595215  Disabling streams
d_00: @00:00:15.595215  [00:00:15.595,214] <dbg> bt_bap_stream: bt_bap_stream_disable: stream 0x84b0200
d_00: @00:00:15.595215  [00:00:15.595,214] <dbg> bt_bap_unicast_client: bt_bap_unicast_client_disable: stream 0x84b0200
d_00: @00:00:15.595215  [00:00:15.595,214] <dbg> bt_bap_unicast_client: unicast_client_ep_disable: ep 0x852031c buf 0x8520cfc
d_00: @00:00:15.595215  [00:00:15.595,214] <dbg> bt_bap_unicast_client: unicast_client_ep_disable: id 0x01
d_00: @00:00:15.595215  [00:00:15.595,214] <dbg> bt_bap_unicast_client: bt_bap_unicast_client_ep_send: conn 0x84e2e40 ep 0x852031c buf 0x8520cfc len 3
d_00: @00:00:15.595664  [100]: Incoming audio on stream 0x84b0244 len 40 and ts 15587581
d_01: @00:00:15.605294  [100]: Incoming audio on stream 0x84b02e4 len 40 and ts 15600335
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_cp_write: conn 0x84e2e40 attr 0x8423248 buf 0x8586cec len 3 op Disable (0x05)
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_disable: num_ases 1
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_disable: ase 0x01
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ase_disable: ase 0x8516e28
d_01: @00:00:15.643685  Disable: stream 0x84b02e4
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_cp_rsp_add: id 0x01 code Success (0x00) reason None (0x00)
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_ep_get_status: ep 0x8516e2c id 0x01 state qos-configured
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: ascs_ep_get_status_qos: dir sink codec id 0x06 interval 10000 framing 0x00 phy 0x02 rtn 2 latency 10 pd 40000
d_01: @00:00:15.643685  [00:00:15.643,676] <dbg> bt_ascs: state_transition_work_handler: ase 0x8516e28 ep 0x8516e2c id 0x01 streaming -> qos-configured
d_01: @00:00:15.643685  [00:00:15.643,676] <wrn> bt_ascs: ase_exit_state_streaming: No callback for disabled set
d_01: @00:00:15.643685  [00:00:15.643,676] <wrn> bt_ascs: ase_exit_state_streaming: No callback for stopped set
d_00: @00:00:15.693887  [00:00:15.693,878] <dbg> bt_bap_unicast_client: unicast_client_cp_notify: conn 0x84e2e40 len 5
d_00: @00:00:15.693887  [00:00:15.693,878] <dbg> bt_bap_unicast_client: unicast_client_cp_notify: op Disable (0x05) id 0x01 code Success (0x00) reason None (0x00)
d_00: @00:00:15.693887  stream 0x84b0200 disable operation rsp_code 0 reason 0
d_00: @00:00:15.694387  [00:00:15.694,366] <dbg> bt_bap_unicast_client: unicast_client_ep_notify: conn 0x84e2e40 ep 0x852031c len 17
d_00: @00:00:15.694387  Stopped stream 0x84b0200 with reason 0x13
d_00: @00:00:15.694387  [00:00:15.694,366] <dbg> bt_bap_unicast_client: unicast_client_ep_set_status: ep 0x852031c handle 0x0015 id 0x01 dir sink state streaming -> qos-configured
d_00: @00:00:15.694387  Disabled stream 0x84b0200
d_00: @00:00:15.694387  [00:00:15.694,366] <dbg> bt_bap_unicast_client: unicast_client_ep_qos_update: ep 0x852031c dir sink bap_iso 0x851ed20
d_00: @00:00:15.694387  [00:00:15.694,366] <dbg> bt_bap_unicast_client: unicast_client_ep_qos_state: dir sink cig 0x00 cis 0x00 codec 0x06 interval 10000 framing 0x00 phy 0x02 rtn 2 latency 10 pd 40000
d_00: @00:00:15.694387  QoS set stream 0x84b0200
d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_ctlr_hci: hci_iso_handle: Input data path not set for HCI
d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_conn: send_buf: Unable to send to driver (err -22)
d_00: @00:00:15.694387  [00:00:15.694,366] <err> bt_conn: bt_conn_tx_processor: Fatal error (-5). Disconnecting 0x84f5020
d_00: @00:00:15.694387  [00:00:15.694,366] <wrn> bt_conn: bt_conn_tx_processor: conn 0x84f5020: not connected
d_00: @00:00:15.694825  [00:00:15.694,824] <dbg> bt_bap_stream: bt_bap_stream_disable: stream 0x84b0244
d_00: @00:00:15.694825  [00:00:15.694,824] <dbg> bt_bap_unicast_client: bt_bap_unicast_client_disable: stream 0x84b0244
d_00: @00:00:15.694825  [00:00:15.694,824] <dbg> bt_bap_unicast_client: unicast_client_ep_disable: ep 0x85206c4 buf 0x8520cfc
d_00: @00:00:15.694825  [00:00:15.694,824] <dbg> bt_bap_unicast_client: unicast_client_ep_disable: id 0x03
d_00: @00:00:15.694825  [00:00:15.694,824] <dbg> bt_bap_unicast_client: bt_bap_unicast_client_ep_send: conn 0x84e2e40 ep 0x85206c4 buf 0x8520cfc len 3
d_00: @00:00:15.741608  [00:00:15.741,607] <dbg> bt_iso: bt_iso_disconnected: 0x84f5020
d_00: @00:00:15.741608  [00:00:15.741,607] <dbg> bt_iso: bt_iso_chan_disconnected: 0x851ed20, reason 0x16
d_00: @00:00:15.741608  [00:00:15.741,607] <dbg> bt_iso: bt_iso_chan_set_state_debug: chan 0x851ed20 iso 0x84f5020 connected -> disconnected
d_00: @00:00:15.741608  [00:00:15.741,607] <dbg> bt_bap_unicast_client: unicast_client_ep_iso_disconnected: stream 0x84b0244 ep 0x85206c4 reason 0x16
d_00: @00:00:15.741608  Disconnected stream 0x84b0244 with reason 22
d_00: @00:00:15.741608  [00:00:15.741,607] <dbg> bt_bap_unicast_client: unicast_client_ep_iso_disconnected: stream 0x84b0200 ep 0x852031c reason 0x16
d_00: @00:00:15.741608  Disconnected stream 0x84b0200 with reason 22

Environment (please complete the following information):

Commit SHA or Version used: 34206f5505b582942ae4c393d7133a5ea6c849bd

Additional context
See also https://discordapp.com/channels/720317445772017664/1259836843374149784

WG:

@alwa-nordic : All drivers should behave the same way. Since it's impossible for e.g. a UART-based HCI driver to return this error, the integrated drivers should also not raise it.
@alwa-nordic : Fragmentation will make this situation worse. E.g. send a first fragment, data path is torn down, what do we do with the other fragments?
@Thalley : What about changing the datapath when fragmenting. What happens then?
@jori-nordic : We could test this situation
@alwa-nordic : On -EIO (ie transport error), we should reset the driver, not just disconnect the link
@alwa-nordic : On boot, the controller should send a HW error HCI event for synchronization


/node_modules/better-sqlite3-multiple-ciphers/build/Release/better_sqlite3.node' was compiled against a different Node.js version using

Hi, I'm getting a similar issue as #55
Error: The module '/myproject/node_modules/better-sqlite3-multiple-ciphers/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 119. This version of Node.js requires
NODE_MODULE_VERSION 108. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

better-sqlite3-multiple-ciphers runs in an electron 28.2.2 for my application - which is based on node 18.18.2.
I also have some tests to test my electron code that run in node 18.18.2.  Both node and electron are at 108.
The error says the modules were compiled for 119 which seems to be the newest node 20 - which makes me think it's trying to load prebuilt binaries.  I don't have node 20 installed.
I've tried npm rebuild, electron-rebuild, and electron-builder install-app-deps, but I get the same error.  I tried reinstalling node.
The only way I can get the tests to work is uninstalling and reinstalling better-sqlite3-multiple-ciphers with no package-lock.json
The README says there are prebuild binaries for node LTS releases, but is the node 18 version of the module downloading a prebuilt binary made in node 20?
I don't have node 20 to make such a module it's complaining about.  What am I missing?  Thank you!

It seems like you're trying to run your tests on Node instead of Electron's embedded Node which has a different module version.
Module version 108 is the Node's module version for Node v18 but that same version of Node embedded in Electron has the module version 119. Electron always reserves its own module versions upon every Node release.
So the solution to your problem is running your tests using Electron's embedded Node runtime. You can do that by setting the ELECTRON_RUN_AS_NODE environment variable to 1.
To make things easier, I suggest using cross-env. Install it as a dev dependency on your project by running the following command.
npm install -D cross-env

Once it's installed, you can add a script to your package.json like the following. Make sure to adjust it to your project structure.
{
    "test": "cross-env ELECTRON_RUN_AS_NODE=1 electron test.js",
}

Now, running npm run test would run the tests perfectly since the native modules are already compiled against that version.

Thank you Mahesh, I will try that.


ssl错误

报错信息： at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at Host.HttpHelper.GetAsync(String url, Dictionary2 headers) in /src/Host/Common/HttpHelper.cs:line 106    at Host.HttpJob.NextExecute(IJobExecutionContext context) in /src/Host/IJobs/HttpJob.cs:line 41    at Host.IJobs.JobBase1.Execute(IJobExecutionContext context) in /src/Host/IJobs/JobBase.cs:line 55
2022-07-20 17:20:59.030 +08:00 [Error] {"Url":"https://szhaeapp113.apac.bosch.com:447/api/Job/RunEcuFPYData","RequestType":"Get","Parameters":null,"JobName":"default.Test","Result":null,"ErrorMsg":"The SSL connection could not be established, see inner exception."}
System.Net.Http.HttpRequestException: The SSL connection could not be established, see inner exception.
---> System.Security.Authentication.AuthenticationException: The remote certificate is invalid because of errors in the certificate chain: PartialChain
at System.Net.Security.SslStream.SendAuthResetSignal(ProtocolToken message, ExceptionDispatchInfo exception)
at System.Net.Security.SslStream.CompleteHandshake(SslAuthenticationOptions sslAuthenticationOptions)
at System.Net.Security.SslStream.ForceAuthenticationAsync[TIOAdapter](TIOAdapter adapter, Boolean receiveFirst, Byte[] reAuthenticationData, Boolean isApm)
我的URL：https://szhaeapp113.apac.bosch.com:447/api/Job/RunEcuFPYData
证书是自签名的，quartzui是容器跑的。 看日志是quartzui向url发起get,post之类的请求报不信任证书。请问这个如何解决？

已解决，导入证书在/usr/local/share/ca-certificates   update下即可


Balance tx integration tests

adp-1142
Three tests are pending:

On will be unpended when adp-1143 lands
The second will be unpended when coin selection with external inputs is integrated
The last one is proof the whole integration works

Comments

Issue Number

bors r+


How to pass parameters to ‘contentUrl’

// tpl/insuranceCard_mamanger.html   ng-controller="insuranceCardMamangerCtrl"
$scope.id = '123456';
$ngConfirm({
            title: 'card',
            contentUrl: 'tpl/insuranceCard_detail.html',
            buttons: {
            }
})

// tpl/insuranceCard_detail.html   ng-controller="InsuranceCardDetailCtrl"
$http.get('url', params: { id : $scope.id}).then(// do something);

how to pass '123456' to insuranceCard_detail.html?

You cannot pass parametesr to contentUrl, its just to fetch the template.
only way is to append 'tpl/insuranceCard_detail.html?id=123456'.
If you want to pass data to the model inside angular-confirm
$scope.id = '123456';
$ngConfirm({
            title: 'card',
            contentUrl: 'tpl/insuranceCard_detail.html',
            buttons: {
            },
            scope: $scope, // give it a scope, and use it in the template.
})


Trying to use oxi::api::call_function() but I'm not sure how to map into a dictionary

Specifically, I'm trying to get vim.fn.wordcount() which returns a table, but I'm not how to get this table. I'm trying to debug, but nothing is happening. Any tips?

I came back to this, and it seems I was using the 0.1.0 release. Works in 0.2.2. Thanks!


Add documentation on monitoring Docker via TCP

This change adds documentation and an example on how to configuration the Docker Daemon to expose the TCP port and how to set up the monitoring in Uptime-Kuma.

Thanks!


Adding GUIALLOWED condition to dialog window calls in Codeunit 5870 "Calculate BOM Tree"

We want to use the BOM Tree calculation to the BOM Buffer in a webservice background task. So it would be necessary to suppress the dialog window calls if no gui allowed.
So please add the guiallowed conditon to every dialog window command in the "Calculate BOM Tree" codeunit.
Kind regards,
Carsten Heu.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


create-react-app cannot create production build when react-metrics-graphics is being used

Steps to reproduce

Clone this repo
yarn
yarn build

Result
create-react-app is unable to create a production build because MetricsGraphics.js is unable to be minfied.
Here's the output of yarn build:
yarn run v1.3.2
$ react-scripts build
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

 	./node_modules/react-metrics-graphics/build/MetricsGraphics.js:1:2669

Read more here: http://bit.ly/2tRViJ9

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Grump. :/ will try to find some time to look into this soon

Digging into this, it looks like the problem is with this chunk of code: class n extends f.a.Component.
Do we need to enable a babel rule?

Apparently we need to compile things down to es5 for them to work with create-react-app:
https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md#npm-run-build-fails-to-minify
@eliperelman showed me a viable workaround:
https://github.com/eliperelman/react-fout-stager/blob/master/.neutrinorc.js#L13


Add a blog section in navbar-->blog.html

on clicking blog it will take to a new blog.html
currently leave that page as blank
will decide further

I can do this for you, please assign me this issue.

Hey akshitgupta i did it. I send you a PR

@Arghya-Banerjee u are already working on an issue so lets give others a chance

Can I work on this under Hacktoberfest'22?

Yes @zugzwang03

@akshitagupta15june I have sent a PR, pls review it

This issue is assigned to @zugzwang03


Descriptive error handling additions

Added better error handling (descriptions) to avoid using 'unknown' in errors which could be vague for users, especially those getting the error when the client wasn't connected to the server.

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   71.96%   71.96%
=======================================
  Files           2        2
  Lines         132      132
=======================================
  Hits           95       95
  Misses         37       37

Flag
Coverage Δ

#KituraKit
71.96% <0%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

Sources/KituraKit/Client.swift
76.03% <0%> (ø)
:arrow_up:

Sources/KituraKit/RequestErrorExtension.swift
27.27% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce52cd...1a2dc66. Read the comment docs.

These are a definite improvement!
Can we guide the user a bit more about how they might handle the errors if they see them?

Nice.


Patreon Usage Question

What is the purpose of your issue?
Question
I'm a paying Patreon user. I'm having problems using youtube-dl with Patreon - mostly I just don't know how. I see some people reference the hid, and I've looked over this file and am not sure what to do with it: https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/patreon.py
Could someone explain how to grab all the videos of a particular creator?

put Patreon in the title of this issue if can

@ubone done.


Einsone

Hello @shilpi1958! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/einsteinpy/metric/kerr.py:

Line 127:13: W503 line break before binary operator
Line 128:13: W503 line break before binary operator
Line 129:13: W503 line break before binary operator
Line 133:13: W503 line break before binary operator
Line 134:13: W503 line break before binary operator
Line 135:13: W503 line break before binary operator
Line 136:13: W503 line break before binary operator
Line 137:13: W503 line break before binary operator
Line 141:13: W503 line break before binary operator
Line 142:13: W503 line break before binary operator
Line 143:13: W503 line break before binary operator
Line 144:13: W503 line break before binary operator
Line 145:13: W503 line break before binary operator
Line 149:13: W503 line break before binary operator
Line 150:13: W503 line break before binary operator
Line 151:13: W503 line break before binary operator
Line 198:81: E501 line too long (83 > 80 characters)
Line 272:81: E501 line too long (83 > 80 characters)
Line 288:81: E501 line too long (81 > 80 characters)

In the file src/einsteinpy/metric/kerrnewman.py:

Line 152:13: W503 line break before binary operator
Line 153:13: W503 line break before binary operator
Line 154:13: W503 line break before binary operator
Line 158:13: W503 line break before binary operator
Line 159:13: W503 line break before binary operator
Line 160:13: W503 line break before binary operator
Line 161:13: W503 line break before binary operator
Line 162:13: W503 line break before binary operator
Line 166:13: W503 line break before binary operator
Line 167:13: W503 line break before binary operator
Line 168:13: W503 line break before binary operator
Line 169:13: W503 line break before binary operator
Line 170:13: W503 line break before binary operator
Line 174:13: W503 line break before binary operator
Line 175:13: W503 line break before binary operator
Line 176:13: W503 line break before binary operator
Line 229:13: W503 line break before binary operator
Line 306:13: W503 line break before binary operator
Line 322:81: E501 line too long (81 > 80 characters)

In the file src/einsteinpy/utils/kerrnewman_utils.py:

Line 148:81: E501 line too long (120 > 80 characters)
Line 158:81: E501 line too long (105 > 80 characters)
Line 163:81: E501 line too long (90 > 80 characters)
Line 164:1: W293 blank line contains whitespace
Line 168:81: E501 line too long (88 > 80 characters)


KWASM: performance regression on memory-concrete-type-spec.k

As @hjorthjort found out, there has been a performance regression on KWasm proofs.
Commit 1cfb1d5f - Simplify sort injections during matching (#1316) from kframework/kore#1316 was responsible.
Timing data:
* e7009b8 - !!! (e74f6300) deps/k: e74f63002 - !!! (1cfb1d5f) haskell-backend/src/main/native/haskell-backend: 1cfb1d5f - Simplify sort injections during matching (#1316) - Everett Hildenbrandt
| testset: profile-memory-proof - Sat Jan 11 04:10:50 UTC 2020
| 0  0.32s    0.00s     0.31s     3320KB     rm    -rf                                             deps    .build
| 0  2.05s    0.64s     0.30s     27896KB    git   submodule                                       update  --init                --recursive
| 0  298.86s  2548.68s  1857.59s  2583648KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  145.05s  1309.02s  32.80s    4579360KB  make  build                                           -j4
| 0  244.58s  385.63s   7.52s     4479028KB  make  tests/proofs/memory-concrete-type-spec.k.prove
|
* 4bdc0d6 - !!! (2a272a82) deps/k: 2a272a82e - !!! (a04dd9db) haskell-backend/src/main/native/haskell-backend: a04dd9db - Fix smt solver log changes (#1344) - Everett Hildenbrandt
| testset: profile-memory-proof - Sat Jan 11 03:59:19 UTC 2020
| 0  0.32s    0.00s     0.31s     3300KB     rm    -rf                                             deps    .build
| 0  0.76s    0.53s     0.25s     27820KB    git   submodule                                       update  --init                --recursive
| 0  297.04s  2313.28s  2001.93s  2575876KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  138.04s  1303.52s  33.58s    4750284KB  make  build                                           -j4
| 0  51.04s   179.91s   5.34s     4876088KB  make  tests/proofs/memory-concrete-type-spec.k.prove

Summary:

Commit a04dd9db: 51.04s and 4.8GB RAM.
Commit 1cfb1d5f: 244.58s and 4.5GB RAM.

Updated performance numbers with Z3 version 4.8.6 on the last 13 commits of KWasm:
* 4d3c1ae  48.84s   149.12s  6.57s  5964268KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 4b4336a  47.39s   148.24s  5.97s  4786992KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 342f86d  49.86s   166.16s  6.63s  6124288KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 031f337  49.19s   153.22s  6.49s  5471548KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 5c2613c  45.66s   149.45s  5.23s  5222528KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 41f0003  61.55s   152.21s  5.12s  5406180KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* a372f26  63.34s   153.48s  5.23s  5781676KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* dae94b3  34.98s   141.12s  4.82s  5151700KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* ff4d7bc  32.29s   84.07s   3.51s  3462716KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 840390f  33.20s   96.56s   3.36s  3064872KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 7651726  25.17s   80.98s   3.09s  2983108KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* 6c2c85d  25.52s   81.09s   3.39s  3323652KB  make  tests/proofs/memory-concrete-type-spec.k.prove
* b286800  25.30s   81.75s   3.17s  3616052KB  make  tests/proofs/memory-concrete-type-spec.k.prove

So we went from 25s up to 33s up to 63s down to 47s.
Given that there has been a performance improvement since the performance regression, do you think we should still investigate the performance regression?

Ok, more detailed analysis after making sure I'm using the correct Z3.
The first jump from ~25s to ~33s:
* 9c4d8cb - Update dependencies (#267)                                                       - rv-jenkins
| testset: profile-memory-proof - Mon Jan 13 23:09:49 UTC 2020
| 0  0.30s    0.01s     0.28s     3268KB     rm    -rf                                             deps    .build
| 0  0.72s    0.51s     0.22s     27392KB    git   submodule                                       update  --init                --recursive
| 0  267.36s  1900.51s  1811.50s  2546024KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  53.34s   859.22s   29.79s    4652936KB  make  build                                           -j4
| 0  31.78s   82.66s    3.01s     3147004KB  make  tests/proofs/memory-concrete-type-spec.k.prove
|
* 5be251a - !!! (40214a3c) deps/k: 40214a3ce - Add and improve #fun examples (#919)          - Everett Hildenbrandt
| testset: profile-memory-proof - Mon Jan 13 23:03:55 UTC 2020
| 0  0.31s    0.01s     0.29s     3268KB     rm    -rf                                             deps    .build
| 0  0.71s    0.49s     0.24s     27480KB    git   submodule                                       update  --init                --recursive
| 0  268.69s  1930.35s  1847.42s  2585848KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  52.72s   842.54s   29.41s    4665424KB  make  build                                           -j4
| 0  25.42s   85.48s    3.07s     2927480KB  make  tests/proofs/memory-concrete-type-spec.k.prove

is caused by the following commit to the frontend:
commit 50598f61edc9b225ae6137ec7480933827d5c730 (tag: v5.0.0-50598f61e)
Author: Thomas Tuegel<EMAIL_ADDRESS>Date:   Tue Dec 3 08:41:15 2019 -0600

    Use BYTES-HOOKED with Haskell backend (#850)
    * Add bytes-haskell regression test
    * domains.k: Default rule for .Bytes
    * regression-new/bytes-haskell: Remove tests for unsupported hooks
    * domains.k: Use BYTES hooks for Haskell backend
    * fixup! domains.k: Default rule for .Bytes
    * BYTES.empty: Remove impure attribute
    * domains.k: Add token attribute to Bytes sort
    * bytes-haskell: int2bytes and bytes2int tests
    * regression-new/bytes-haskell: Do not duplicate test inputs and outputs

This doesn't actually do much other than change module import structure. My guess is that because I'm measuring total kprove runtime, this is actually just changing frontend time (because the frontend for kprove needs to call kompile, and the changed import structure is probably affecting kompile).
The second jump, from ~33s to ~60s:
* e15c6ac - !!! (f041eae8) deps/k: f041eae8e - new MINT module and polymorphic sort support (#839) - Everett Hildenbrandt
| testset: profile-memory-proof - Mon Jan 13 23:34:39 UTC 2020
| 0  0.31s    0.00s     0.30s     3284KB     rm    -rf                                             deps    .build
| 0  0.73s    0.50s     0.24s     27620KB    git   submodule                                       update  --init                --recursive
| 0  271.10s  1932.08s  1909.85s  2555932KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  72.92s   999.85s   29.20s    4616508KB  make  build                                           -j4
| 0  63.93s   176.49s   5.01s     4860204KB  make  tests/proofs/memory-concrete-type-spec.k.prove
|
* 38f2c0d - !!! (45a4243a) deps/k: 45a4243af - haskell-backend/src/main/native/haskell-backend: update submodule (#943) - Everett Hildenbrandt
| testset: profile-memory-proof - Mon Jan 13 23:27:49 UTC 2020
| 0  0.31s    0.00s     0.29s     3288KB     rm    -rf                                             deps    .build
| 0  0.72s    0.52s     0.21s     27336KB    git   submodule                                       update  --init                --recursive
| 0  270.96s  2068.99s  1786.43s  2533744KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  53.05s   840.71s   29.39s    4850968KB  make  build                                           -j4
| 0  34.92s   160.11s   4.77s     4514080KB  make  tests/proofs/memory-concrete-type-spec.k.prove

Is caused by f041eae8e - new MINT module and polymorphic sort support, which means that it's a parse-time (or unparse-time) frontend performance regression. Not much we can do about that here.
Then, finally, the dip from ~60s to ~50s:
* 2640a1d - Update dependencies (#271)                                                       - rv-jenkins
| testset: profile-memory-proof - Tue Jan 14 01:36:50 UTC 2020
| 0  0.31s    0.00s     0.30s     3340KB     rm    -rf                                             deps    .build
| 0  0.73s    0.52s     0.22s     27912KB    git   submodule                                       update  --init                --recursive
| 0  277.42s  2055.42s  1825.89s  2579412KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  65.83s   922.80s   29.15s    4771716KB  make  build                                           -j4
| 0  44.24s   146.38s   4.83s     5530992KB  make  tests/proofs/memory-concrete-type-spec.k.prove
|
* 0ebbac5 - !!! (6c9a33f5) deps/k: 6c9a33f5d - Update dependencies (#955)                    - Everett Hildenbrandt
| testset: profile-memory-proof - Tue Jan 14 01:30:21 UTC 2020
| 0  0.31s    0.00s     0.30s     3160KB     rm    -rf                                             deps    .build
| 0  0.72s    0.51s     0.22s     27896KB    git   submodule                                       update  --init                --recursive
| 0  276.18s  2125.01s  1745.38s  2631988KB  make  deps                                            -B      K_BUILD_TYPE=Release
| 0  75.49s   973.82s   26.96s    4332728KB  make  build                                           -j4
| 0  62.52s   165.35s   5.90s     6105180KB  make  tests/proofs/memory-concrete-type-spec.k.prove

is caused by an update to the Haskell backend:
commit 9c4bbbc1eb32b57371b11cccca602f83e0d66a58
Author: rv-jenkins<EMAIL_ADDRESS>Date:   Thu Dec 19 08:15:42 2019 -0600

    Update dependencies (#982)
    * haskell-backend/src/main/native/haskell-backend: update submodule
    * haskell-backend/src/main/native/haskell-backend: update submodule
    * haskell-backend/src/main/native/haskell-backend: update submodule
    * haskell-backend/src/main/native/haskell-backend: update submodule

diff --git a/haskell-backend/src/main/native/haskell-backend b/haskell-backend/src/main/native/haskell-backend
index 8bb13a9a8..983803600 160000
--- a/haskell-backend/src/main/native/haskell-backend
+++ b/haskell-backend/src/main/native/haskell-backend
@@ -1 +1 @@
-Subproject commit 8bb13a9a8f98e02ecab1c789904862b0b689b315
+Subproject commit<PHONE_NUMBER>0ab9e839d736b136f2f85d4131f3cf

Given that it appears it was mostly due to frontend changes that we have performance worsen, I think we should close this issue. @ttuegel feel free to do so if you agree.

Also, in case it's confusing, the diagrams of timing numbers i post are in reverse chronological order, so the newer commit is towards the top.


fix compiling mariadb-connector-c failure due to openssl relocation o…

fix compiling mariadb-connector-c failure due to openssl relocation of symbol OPENSSL_armcap_P

When compile third-party libraries under ARM platform, it failed on mariadb-connector-c component with following error message:
thirdparty/installed/lib/libcrypto.a(sha1-armv8.o): relocation R_AARCH64_PREL64 against symbol `OPENSSL_armcap_P' which may bind externally can not be used when making a shared object; recompile with -fPIC

While after checking compilation process and found that openssl-1.0.2k compilation was compiled with the -fPIC flag.

This is a bug of openssl which has been fixed by https://github.com/openssl/openssl/pull/13056 and merged to v1.1.1.

For a workaround solution, just disable the asm part of openssl-1.0.2k.

To fix this issue completely, maybe upgrade openssl from 1.0.2k to 1.1.1i+ is a better choice, this fix is just a workaround.

@rzuo Could you mind to push this change to main branch?

imay:
Sure, I'll close this PR and commit the fix to main branch.

The fix has been committed to main branch, so track this issue there, close this PR.
https://github.com/StarRocks/starrocks/pull/2733


Transaction list: transactions are displayed incorrectly

When there are some transactions in the transactions list transactions are doubled. After opening a doubled transction the transactions details are displyed for other one (it may be even deleted transaction)

Checked


Update all Unit and Integration Test to have a more readable name (from TestWithoutMappings to TestInsertWithoutClassMappings)

Done with the updates on the document.


Document for resizing by inode usage

What
We implemented resizing by inode usage (#59 #65), but we have no document to use the feature.
let's write a document!
How
Describe how to address the issue.
Checklist

[x] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

closed via #105


Removed some uses of m_model_selection_parameters [WIP]

This PR is part of the Parameter.cpp project.
In this PR we removed m_model_selection_parameters from SGObject. Also, in the future m_parameters and m_gradient_parameters will be removed. These store models' (hyper)parameters which are estimated during the training phase.
The aim is to use the AnyParameter properties to store the value and properties of these parameters. PRs #4412 and #4426 include code with the first steps towards this aim.

The errors I get is mostly complains from the compiler that the m_model_selection_parameters cannot be found.

OK! I think the idea is to now use CSGObject::get_parameter instead, and from there you can extract (maybe cast?) the value of the parameter. But I guess we'll discuss that tomorrow!

this has already been done


Support Policy Management for Attestation Providers

Service Package Request

The Azure Go SDK currently offers an interface for attestation of confidential entities through the armattestation package. Unfortunately, the SDK does not provide a way to interact with attestation policies when updating an attestation provider yet.
The Azure Python SDK supports this. (Added in this commit, I believe)
To support this, I assume regenerating the code would be sufficient.

This seems to be handled in the attestation package. Thank you!


Enough of dreaming, let's go to the forest! :)

It seems that most of our outlined dreams have already become
true. It's time to forget about dreams and put together a nice
guide which would help new users to walk through the features
which are eagerly waiting for them. What about a couple of
bite-size kind-of stories which will demonstrate essential
features on tangible examples?
In addition to writing The First Steps section and removal of the
dreams pages I've moved the only unfulfilled dream to the stories
and fixed a trivial typo in the README.

Great! Thanks for the quick review.

Great! Thanks for the quick review.

nice, I like it! just too late to the review party :balloon:

nice, I like it! just too late to the review party :balloon:


Undoing section is perhaps confusing and too early?

Perhaps we don't need to show how to undo stuff? Perhaps it is too early and we should show more "doing" and show "undoing" later? My feeling was that throwing all the resets and checkouts at people can confuse them and the important part is to record work IMO.

I believe this is now better and solved. Closing.


Revert "fix Fix incorrect _max_thread_num in scanner context"

Reverts apache/doris#40569
We need more test to avoid performance issue

run buildall

run buildall


Add feature: new component(DataTable)

Bug, feature request, or proposal:
Feature: DataTable
What is the expected behavior?
Data tables display sets of raw data. They usually appear in desktop enterprise products.
https://material.google.com/components/data-tables.html
What is the current behavior?
Nothing.

https://github.com/angular/material2/issues/581
You can see status of various components here https://github.com/angular/material2/blob/master/README.md#feature-status

See #581

Hi. I was just going through the specs and I just want to add one thing. When you have inline editing, and inline dropdown selection, is it possible to have a inline autocomplete instead of a regular dropdown. So, in that case, even if the amout of data is huge, we can easily filter instead of having a big dropdown list


Add a server info panel

I made this since #335 got stale and outdated.
This doesn't update server info when connecting to servers with commands but I'm confident the average user won't do that.
@GeckoEidechse this pr adds two vanilla files

resource/ui/menus/ingame_mp.menu
scripts/vscripts/ui/menu_ingame.nut

The menu that gets replaced is the one that shows challenges needed to complete to earn extra merits, right?
Also should we maybe add server region as well? ^^

updated

@Jan200101 said you should update this PR :>

@uniboi is this PR stale?

Kinda forgot about it.
Basically I'm waiting for the server name and description convars to get networked but that needs a version gate

Networked convar stuff is still basically waiting on us doing a version gate. The thing with server info panel is that now with progression we kinda make use of that HUD element now that would get replaced...

Heads up that this will conflict entirely with #756 since it's the same menu and panels being used.