No routes?

Im trying to integrate your great ticket system into an existing app I am working on and I do not see any route information. Am I missing something?

Ah, I guess its in the config/ticketit.php file. Hmm. Your package seems to have a completely different file layout than what im using with the https://github.com/rappasoft/laravel-5-boilerplate solution. They are both made for laravel 5.1 and it seems to meet all your minimum requirements. Any suggestions on how to get your system to work with it?

Let me expand a bit more. Right now with zero config changes, when I go to /tickets, im getting:
FatalErrorException in Agent.php line 9: Class 'App\User' not found
which I am pretty sure is a result of this different file structure.

More info and I apologize if this is to much, but my config/auth.php has the following model set:
'model' => 'App\Models\Access\User\User',

You need to follow the laravel instructions for enabling the auth system its installed by default but not enabled. You need to open your app\http\routes.php file and add the auth routes to initiate the functionality.
// Authentication routes...
Route::get('auth/login', 'Auth\AuthController@getLogin');
Route::post('auth/login', 'Auth\AuthController@postLogin');
Route::get('auth/logout', 'Auth\AuthController@getLogout');

// Registration routes...
Route::get('auth/register', 'Auth\AuthController@getRegister');
Route::post('auth/register', 'Auth\AuthController@postRegister');

[Activate Laravel 5.1 Authentication!]http://laravel.com/docs/5.1/authentication#authentication-quickstart

I do not have a User.php in the app folder and I already have a working auth system as I mentioned. My app folder pretty much looks like so: https://github.com/rappasoft/laravel-5-boilerplate/tree/master/app

MACscr - Does replacing App\User with App\Models\User\User fix the issue? If so I can probably fix that.

IIRC - App\User is hard-coded right now and we can use app()->make(config('ticketit.model')); to fix.

ticketit.model is not implemented to my knowledge in config, but it should be an easy update. I'll submit something after my current PR is pulled. I'm not smart enough for branches.

Yes, changing that path in the Agent.php seems to solve that particular error. I will open a new ticket for the next error that came up after I troubleshoot it a bit. Thanks for the help!

You're welcome. I knew that may come up.

Had to update src/Models/Comment.php and src/Models/Ticket.php with the correct user path too.

Please be aware that all changes you do are backed up, as any new version update will replace them.
While Ticketit integrates by default with Laravel default Auth and User system, but we may add in future somehow a compatibility to boilerplate. I guess It won't be that hard

I tried turning Agent into a trait but it is far too much work. I didn't realize how much touched the Agent class. I gave up after I couldn't even get an error log to be produced.
This will have to be for way later, Kordy was right.

I'd rather have a Wiki article on this subject, since you only have to change App\User in a few spots it would be easy to document.


fix Fix crash at bthread_setspecific in brpc::Socket::CheckHealth()

Proposed changes
Issue Number: close #xxx

Only switch to bthread local when modifying the mem tracker in the thread context. No longer switches to bthread local by default when bthread starts
mem tracker increases brpc IOBufBlockMemory memory
remove thread mem tracker metrics

core stack:
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007f9220937859 in __GI_abort () at abort.c:79
#2  0x000056079b8365e9 in ?? ()
#3  0x000056079b82bbfd in google::LogMessage::Fail() ()
#4  0x000056079b82e139 in google::LogMessage::SendToLog() ()
#5  0x000056079b82b766 in google::LogMessage::Flush() ()
#6  0x000056079b82e7a9 in google::LogMessageFatal::~LogMessageFatal() ()
#7  0x000056079bff62af in bthread_setspecific ()
#8  0x00005607950e15db in doris::pthread_attach_bthread ()
    at doris_master/doris/be/src/runtime/thread_context.h:219
#9  doris::thread_context ()
    at doris_master/doris/be/src/runtime/thread_context.h:228
#10 0x00005607950e131c in doris_malloc (size=30504)
    at doris_master/doris/be/src/runtime/memory/jemalloc_hook.cpp:44
#11 0x000056079e4b5ef8 in operator new (sz=30504) at ../../../../libstdc+-v3/libsupc+/new_op.cc:50
#12 0x000056079b82ade0 in google::LogMessage::Init(char const*, int, int, void (google::LogMessage::*)()) ()
#13 0x000056079c1a6e60 in brpc::Socket::CheckHealth() ()
#14 0x000056079c1ae55b in brpc::HealthCheckTask::OnTriggeringTask(timespec*) ()
-Type <RET> for more, q to quit, c to continue without paging-
#15 0x000056079c1af61b in ?? ()
#16 0x000056079c009daf in bthread::TaskGroup::task_runner(long) ()
#17 0x000056079bff53e1 in bthread_make_fcontext ()
#18 0x0000000000000000 in ?? ()

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


EXCEL DOWNLOAD BUTTON IN ACCOUNTS SECTION

AS ACCOUNTS HAS TO BE DONE THROUGH ACCOUNTING SOFTWARE , THERE SHOULD BE EXCEL DOWNLOAD BUTTON TO GIVE CASH BOOK, BANK BOOK AND ADJUSTMENT BOOK TO ACCOUNTANT FOR SPECIFIED PERIOD.
ACCORDINGLY ACCOUNTS AND VOCHERS SHOULD ALSO BE MADE DOWNLOADABE.

Try to do this with Export Module


Remove duplicate definition of GetUtilityExpressionTimeout from upstream-with-swift

It looks like something happened in the merge and now we have the same function twice. Should be as easy as removing one of the definitions.
cc @compnerd @adrian-prantl

@swift-ci please test and merge

@swift-ci please test Linux platform

@swift-ci please test macOS platform

@swift-ci please test macOS platform

@swift-ci please clean test Linux platform


CEP-15: Convert AccordStateCache cache from write-through to write-back

patch by Aleksey Yeschenko; reviewed by Blake Eggleston for CASSANDRA-18563

Merged manually, cheers.


Suggestion: configure which contracts should be deployed.

It would be nice to choose which contracts should be deployed in certain environment
eg.
contracts:
  - hello.sol/Hello
  - hello.sol/World
  - my_contract.sol/Contract
  - all.sol/*

By default all contracts should be deployed (same as now).

This feature is coming in embark 0.4.0

added deploy: false field to 0.9.0


Skip as default Transform

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/944
Originally created by @derek-knox on 2019-08-30 16:08:35

[x] as recommended by Yannis, set the default to "Skip" for transforms as a safeguard until we can infer (also updated order as suggested by Danielle)

View 3 previous comments from the original issue on GitLab


add functional module to nn, add gini and bro functions

Adding functional module and functions from our paper as we discussed here.
Thanks @tuanle618 for pointers on a more efficient formulation for BRO.

Codecov Report

Merging #2608 (5cfbc31) into master (ae783c0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
+ Coverage   83.58%   83.62%   +0.03%
==========================================
  Files         202      205       +3
  Lines        9206     9227      +21
==========================================
+ Hits         7695     7716      +21
  Misses       1511     1511

Impacted Files
Coverage Δ

torch_geometric/nn/__init__.py
100.00% <100.00%> (ø)

torch_geometric/nn/functional/__init__.py
100.00% <100.00%> (ø)

torch_geometric/nn/functional/bro.py
100.00% <100.00%> (ø)

torch_geometric/nn/functional/gini.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae783c0...5cfbc31. Read the comment docs.

Super :) Thanks a lot!


Updated ActiveNet plugin

Enhanced ActiveNet plugin to enable retrieving a network adapter's operational status.

Looks great, thanks!

Ah oops, I didn't actually check before merging! I don't know if you meant to place the docs files in the root folder instead of the ActiveNet folder. I'll just go ahead and move those. Thanks again!

OOPS!  Sorry about that!  I used the "upload files" feature and didn't notice it messed up the file locations (I could not figure out how to commit from TortoiseGit with 2FA enabled, so I just uploaded directly).


Missing documentation, possibly due to package renaming

Crate name:
constellation-rs
Build failure link:
https://docs.rs/crate/constellation-rs/0.1.8
"constellation-rs-0.1.8 doesn't have any documentation."
Additional details:
The crate is substantially unchanged since v0.1.6 which built documentation correctly in September: https://docs.rs/crate/constellation-rs/0.1.6
My other crates crates are building fine; the only out of the ordinary thing about this crate is probably this in the Cargo.toml:
[lib]
name = "constellation"

From a cursory glance this might be the issue:
https://github.com/rust-lang/docs.rs/blob/d9d7a33fc4405c2385aff0200b049181f6dbf83f/src/docbuilder/rustwide_builder.rs#L284-L289
Perhaps instead of the crate name it should test if any of the package names exist as directories?

Build log: https://docs.rs/crate/constellation-rs/0.1.8/builds/198779
This doesn't appear to be a sandboxing issue, there's no errors in the build.

Ah I missed where you said that the lib name differed from the crate name, that's probably it.

I think my crate encounters the same problem:
https://crates.io/crates/metropolis
Do you have any solution to this problem?

Opened a PR to fix the underlying issue: https://github.com/rust-lang/docs.rs/pull/487

@alecmocatta @GuyL99 scheduled a rebuild of constellation-rs 0.1.8 and metropolis 0.3.2. Please let me know if you need to build more crates.

@pietroalbini I didn't bother mention my crate as I assumed that everything that missed docs would be rebuilt automagically. I've got serpent-cipher 0.1.2 suffering from the same problem.

@zao just queued a rebuild.

@zao rebuilding automagically is #464


Update install_guide.md on pytorch3d

Installing pytorch3d from conda worked but doing so from github/source failed for me.(https://github.com/mapillary/inplace_abn/issues/104). Perhaps there is a reason for using source but did not seem necessary for me to get the example to work.

That's for windows users as we cant install direct from conda

Ah that makes sense, worth clarifying that in the comment then perhaps.
On Mon, Feb 12, 2024 at 7:40 PM Inferencer @.***> wrote:

That's for windows users as we cant install direct from conda
—
Reply to this email directly, view it on GitHub
https://github.com/yerfor/Real3DPortrait/pull/11#issuecomment-1939427967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE5OV6DI45PL5LTLYPQTTLYTJV2ZAVCNFSM6AAAAABDFIIA4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGQZDOOJWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Display version number

Is your feature request related to a problem? Please describe.
Desktop apps of FN doesn't auto update so better to display version #
Describe the solution you'd like
Display version number at the bottom / top of the drawer or in settings

最好是在官网上的下载页面上,也显示最新的MacOS上显示最新的版本号, 对比版本号,确定是否下载

最好是在官网上的下载页面上,也显示最新的MacOS上显示最新的版本号, 对比版本号,确定是否下载.
当然也可以在设置页面显示 当前的版本和最新的版本号, 然后可以官网下载

translation: "It would be best if the latest version number is also displayed on the download page of the official website for MacOS, to compare the version numbers and determine whether to download.
Of course, you can also display the current version and the latest version number on the settings page, and then download from the official website."


CosmosDiagnostics: Adds Serialization APIs

CosmosDiagnostics: Adds Serialization APIs
Description
This PR adds the ability for the user to pick how they want Cosmos Diagnostics serialized for whatever is get for their use case.
For now we have:

Text
Json
Binary

Closing this PR as this directly conflicts with plans to automate diagnostic analysis.  Having JSON as the output allows us to build tools to iterate and analysis the diagnostics. This can not be done inside the SDK:

It's add to much over head
The logic can not be updated. If a new scenario is detected or if a bug is found in the analysis customer have to upgrade.
Doesn't know about regression later found after the release.


docs: remove server side code generators that aren't built

@minaelee want to confirm you got a notification to review!

@minaelee want to confirm you got a notification to review!

Got it :)


ui: shorten addresses in JarDetailsOverlay

    could you shorten the address? "bc1x xxxx ... xxxx" there are examples in Figma. what do you think?

Originally posted by @editwentyone in https://github.com/joinmarket-webui/jam/issues/495#issuecomment-1264432605

Implementation tip: utilility function shortenStringMiddle can be used.


Implementation

I've added
forwarder: "|/usr/local/bin/postforward<EMAIL_ADDRESS>and commented sender_canonical_maps and leave only recipient_canonical
#sender_canonical_maps = hash:/etc/postfix/pfix-no-srs.cf, tcp:<IP_ADDRESS>:10001
#sender_canonical_classes = envelope_sender

recipient_canonical_maps = tcp:localhost:10002
recipient_canonical_classes= envelope_recipient,header_recipient

In main.cnf
alias_maps = hash:/etc/aliases
alias_database = hash:/etc/aliases
and SRS doesn't work
Can You help me with this issue? What logs You need to debug this

Just to rule out the obvious, did you run newaliases after updating /etc/aliases? That's needed to make changes to that file active.
If that is not the issue, all of the standard logs postfix generates when you send a message to the forwarder recipient would be a good place to start.

I'm closing this for now, please let me know if this is still an issue.


Features to allow organization by feeds either by folders or tags or both

Feature request

https://trello.com/c/47XtIFPP/901-ability-to-organize-feeds-by-folder-tags-or-both


Update docs to display support up to Python 3.12 and Django 5.0?

Hey all (and @justquick), I've been doing some local work on django-activity-stream because I honestly didn't trust the doc's assertion that this is only supported up to Python 3.9 and Django 4.1 😅
I've managed to get tox and pytest passing for all environments now (a few minor tweaks to the tox.ini) with the exception of this specific text for Django 5.0. Commenting out that line allows for the rest of the tests to succeed with Django 5.0, and I've opened a thread in the Django Discord to see if there was an undocumented breaking change here that causes the translated text to no longer be stored in the database as LANGUAGE_CODE.
Once I get that sorted, do you have any concerns with me submitted a PR with the updated tox.ini changes, any changes I might need to do to resolve that specific test, and a docs update to reflect the changed support?

Alrighty, problem identified, https://forum.djangoproject.com/t/new-5-0-behavior-storing-translated-string-in-database-solved/29483/5, and a PR is on it's way. Thankfully, this repo supports all the way up to 3.12 without any changes, but just needs a minor change to account for changes in Django 5.0 🎉

Just wanted to add that the docs don't seem to be updated as well. https://django-activity-stream.readthedocs.io/en/latest/changelog.html
Is this supporting Django 4.2?


Remove unneccessary abstraction

Currently we have the following type hierarchy:
classDiagram
    IRenderedFragmentBase <|-- IRenderedComponentBase
    IRenderedFragmentBase <|-- IRenderedFragment
    IRenderedComponentBase <|-- IRenderedComponent
    IRenderedFragment <|-- RenderedFragment
    RenderedFragment <|-- RenderedComponent
    IRenderedComponent <|-- RenderedComponent

note for IRenderedComponent "Has no own methods.\nVirtually the same as IRenderedComponentBase"

Let's subtract the nonpublic implementation classes for now - that leaves us still with the 4 interfaces we expose.
With #1014 I started to remove one of them (the easy one).
History
The split was to anticipate things like Blazor mobile binding so that we have core types and types that are specific for the specific scenario - like mobile bindings or web.
Usage
How are those types currently used? Basically, we are offering those two types to the user depending on what he is calling

IRenderComponent<TComponent> when we call things like RenderComponent so that a user has a strongly typed object that wraps his component under test
IRenderedFragment that allows wrapping an "arbitrary" RenderFragment that doesn't necessarily bag a "pre-defined" user component

There are two options we can go from here:

Leave those two basic types - as they deem a good separator between those two worlds
Morph them into something like IRenderedComponent<TComponent?> where TComponent : IComponent (Please note that TComponent? obviously isn't a real constraint it is more about showing that the Instance behind that TComponent might be null)

Personally, I am leaning towards the second case where we abolish literally everything and have one base type representing a component under test, independent of its content.
For that to work, all interfaces have to be merged towards bunit.core. I am leaning out of the window and also questioning whether or not we need bunit.core and bunit.web. I do see the benefit for 3rd party maintainers to built upon bunit.core but I don't have any feeling if people really do that. (Besides they are still able even if we would merge).

Good summary. Thoughts:

I know of at least a few that does depend on bUnit.core. Doing so does simplify their dependency graph because it does not include AngleSharp and friends that bUnit.web has a dependency on, that's a big plus, as far as I can tell, since bUnit.core only depends on Microsoft framework packages. IRenderedFragmentBase does not include the Nodes property, which would require a reference to AngleSharp.

I am debating whether there is value in having an abstraction or just a base class, e.g. should we have an IRenderedFragment or a RenderedFragment. Perhaps IRenderedFragment keeps existing in bunit.core and RenderedFragment with a pointer to the DOM tree is what will exist in bUnit.web.

Since I only want to keep the Render methods around (and not the generic RenderComponent methods), always have the Render methods return a RenderedFragment. We do want folks to primarily focus on testing the externally visible things, e.g. the rendered markup, and not focus on the component instance itself, so I think it's okay to do. And we will keep the FindComponent/FindComponents methods around, which should return RenderedComponent.

At the end of the day, whenever a user calls Render, even if they are using the Render<TComponent>(parameter builder) variant, it is a RenderFragment that is being rendered, wrapped inside a BunitRootComponent, so the instance of a RenderedFragment returned from a Render() call will always point to the BunitRootComponent.
public class RenderedFragment
{
  private IEnumerable<RenderedFragment> children;
  private IComponent instance;

  // ... other properties

  // never liked the name `Nodes` but perhaps one of those things that we just have to stick with now
  public IEnumerable<INode> Nodes { get; }

  public string RawMarkup => Markup.ToHtml();

  public RenderedComponent<TComponent>? FindComponent<TComponent>()
    => // do depth/breath first search through children;

  public IEnumerable<RenderedComponent<TComponent>> FindComponents<TComponent>()
    => // do depth/breath first search through children;

  public IElement? Find(string cssSelector)
    => Markup.QuerySelector(cssSelector);

  public IElement? FindAll(string cssSelector)
    => Markup.QuerySelectorAll(cssSelector);
}

public RenderedComponent<TComponent> : RenderedFragment
{
  public TComponent Instance { get; }
}

I quickly checked those projects which seemingly only depend on bunit.core (nuget as well as GitHub). All except for one are including bunit.web alongside bunit.core - I guess for them it would be easier to add the meta package :D. But sure, if we "close" that door, we are closing it completely. I am fine with keeping the separation.
Just to level with you why I do think it makes sense to put them together - Blazor, at the end of the day, produces HTML - so where web might be a weird name if one would merge bunit.core and bunit.web, the "outcome" is always the same. We don't have a "JSON" output or whatnot.
That said - if we keep this abstraction, it makes sense to have the interface in bunit.core and a "something" in `bunit.web.
Still, I would prefer an interface over an (abstract) class for a multitude of reasons:

It makes us more flexible
The user can not bind himself to the internals of the (abstract) class
When would a user inherit from said (abstract) class?

Related: Do we still need an ITestRenderer abstraction? My guess is that can be removed too.

Good question. We are also exposing BunitJSInterop without any interface. But to be honest, I do still believe yes.For the same reasons as above. It does not tie us to some specifics.
We could also merge WebTestRenderer and TestRenderer - WebTestRender does only have DI as an additional dependency.

Good points all around.
Can we reduce the whole thing down to whether we want to keep a core and web separation going, or just move to a unified bUnit?
I think that's the case.
Seeing as we have not needed the separation during the first three years of bUnits life, it may be that the answer is just to drop the web and core project and move the files to the bunit project.

Sorry for the late answer: Yes it is all about the abstraction of bunit.core and bunit.web and my direction would be to merge them both together:

Current usage / Third-party vendors: We saw that in the majority of cases those two assemblies are used together in almost all cases (we found one example that uses only the bunit.core) and maybe it is worth investing whether or not the project is still active and what are there future plans (even though I don't want to make our plans dependent on someone else's)
Codebase size and complexity: I do see we can gain here quite a bit!
Potential future use cases: I don't see anything where we strongly would need core and web. Even with .net8

On a side note: Related to remove unnecessary abstraction but not the merge topic:
We have quite some extension methods that are defined on top of our own types. What was the motivation for that instead of having them on the defining type.
Like TestContextBaseRenderExtensions.

I think the initial step for v2 is to just move all files from core and web into bUnit and remove the web and core projects.
Also combine the relevant test projects.
The extension methods were in some cases there because of the separation of projects (core, web).
When combining the two projects, some of the design decisions becomes redundant, so there will be a need to go through the code and probably clean up and rethink some things.


Feature request: "expand" query parameter when subscribe to collections or records.

It would be awesome if we could add an option to expand when subscribed to a collection or a record. This would save the extra api calls when we have a multiple relationships in the record.
Cheers

Is there any technical difficulty in implementing this feature? If so can you provide an alternative solution to work with.

Is there any technical difficulty in implementing this feature?
I have some performance concerns and will have to research it a little more. Eventually this will be handled together with https://github.com/pocketbase/pocketbase/issues/527 to allow providing a ?filter like support to the realtime api, but other tasks for now are with higher priority (if you haven't already, you can check the current tasks priority and roadmap in https://github.com/orgs/pocketbase/projects/2).

If so can you provide an alternative solution to work with.

On realtime change event you can send a regular getOne(e.record.id, { expand: "..." }) request.

@ganigeorgiev Are you suggesting using getOne() (or similar async record method) inside the callback passed to subscribe()? If so, it seems like the type for the callback should be broadened to include async functions, as it currently only expects a function of this type: (data: RecordSubscription<T>) => void

@ZedLove @ganigeorgiev I'm also trying to fetch data from the database on a realtime change event, but I get "Cannot use keyword 'await' outside an async function". Here is my SvelteKit code:
	onMount(async () => {
		pb.collection('boards').subscribe('*', function (e) {
			let records = await pb.collection('cards').getFullList('', {
				filter: `board.project.id="${projectID}"`,
				expand: 'board'
			});

			let transformedData = transformKanbanData(serializeNonePOJOs(records));
			data = {
				tasks: transformedData
			};
		});
	});

How can I fix this issue? Thanks! :)

@YugoCode You can wrap it in a local async function.
Returning a Promise in the callback doesn't make much sense, although I agree that is not very convenient and I'll consider eventually changing the return types during the planned realtime refactoring in the near future.

@ZedLove @ganigeorgiev I'm also trying to fetch data from the database on a realtime change event, but I get "Cannot use keyword 'await' outside an async function". Here is my SvelteKit code:
	onMount(async () => {
		pb.collection('boards').subscribe('*', function (e) {
			let records = await pb.collection('cards').getFullList('', {
				filter: `board.project.id="${projectID}"`,
				expand: 'board'
			});

			let transformedData = transformKanbanData(serializeNonePOJOs(records));
			data = {
				tasks: transformedData
			};
		});
	});

How can I fix this issue? Thanks! :)

You should also use the cleanup function to avoid memory leaks.
// we need to scope the unsubscription variable outside the onMount, so we can reach it when un mounting the component / cleaning up.
var unsubscribe;
onMount( () => {
// wrap the async stuff
const subscribe = async () => {
unsubscribe = pb.collection('boards').subscribe('*', function (e) {
let records = await pb.collection('cards').getFullList('', {
filter: board.project.id="${projectID}",
expand: 'board'
});
let transformedData = transformKanbanData(serializeNonePOJOs(records));
data = {
tasks: transformedData
};
});
}
});
// not sure what the correct lifecycle method is (don't know too much Svelte), but something like
onUnMount(() => {
// clean up and unsubscribe to avoid memory leaks
unsubscribe && unsubscribe();
})

I hope this will be implemented aswell.

I am also pretty interested in the feature to filter in realtime 😎🤩

Experimental filter, expand, fields, custom query and headers parameters support for the realtime subscription was added in the develop branch. There are some minor polishing details that needs to be done, but if you are curious you can test it with the v0.20.0-rc prerelease.


Static IP does not work

First off, very nice project! Works flawlessly.
Due to issues with my router, I'd like to set a static IP address in the ESP itself.
It does not work however...
Using V2.0.0, and rebooting after unticking DHCP and modifying the IP does not make the ESP change IP, it keeps the old one.
If you need any info, please let me know.

Install this firmware file (you do not need the littlefs.bin file) and let me know if it persists your IP address.
https://github.com/rstrouse/ESPSomfy-RTS/blob/main/SomfyController.ino.esp32.bin

Works!
Good fix.


Include 0 period fetching

There seems to be a skill issue in fetching 0 periods. attached is code resolving this lack of skill

ok @ky28059 here


Accents for d, t, l are too large and therefore also kerning with subsequent character is off

Accented ď, ť, ľ breaks the flow, because a) accents are too big (should be around 75% of the size) and b) because of their size, the kerning is broken (with the letter ť even looking thicker than t)
The kerning pairs should share the same distance between accented and non accented versions of d, t, l
As a consequence, the longer text typeset in Roboto using the aforementioned characters looks uneven.

Just to add to the fact, that this indeed is an error, all other variants (Roboto Condens, Roboto Mono and Roboto Slab) do not have this issue.


[HTTP2] Fix inconsistencies in keepalive configuration

Noticed some inconsistencies in our keepalive configuration -

Earlier, even if keepalive pings were not disabled, we would be scheduling keepalive pings at an interval of INT_MAX ms.
We were not using g_default_client_keepalive_permit_without_calls / g_default_server_keepalive_permit_without_calls. They are both false by default but they can be overridden in grpc_chttp2_config_default_keepalive_args.

This seems like an ideal time to add tests around the expected configuration.

what kind of tests are you imagining?

a set of asserts that would trigger if, say, we disabled keep alives but scheduled at INT_MAX seconds regardless?
or something that verifies that g_default_client_keepalive_permit_without_calls is actually used?


API: Start/end time range ignored in aggregation queries

What did you do?
I created a singlestat panel in Grafana that shows the total number of 200-status responses (sample query: sum(http_request_duration_seconds_count{status=200})). The time period of the query result should reflect that specified by the time range for the entire dashboard.
What did you expect to see?
When a user selects a range of "last 1 hour", etc, they should see the total number of requests over their selected time period.
What did you see instead? Under which circumstances?
The results of my queries are always the total number of requests for all-time. While the start/end values in the query originating from Grafana appear correct (sample query below), it seems that the start/end values are simply ignored on the prometheus end.
query_range?query=sum(http_request_duration_seconds_count{status="200"})&start=1507224144&end=1507227744&step=120

Environment
Amazon Linux in AWS

System information:

Linux 4.9.51-10.52.amzn1.x86_64 x86_64

Prometheus version:

Note: Also tried on 1.7.1, same issue
prometheus, version 1.7.2 (branch: HEAD, revision: 22eadbe635528fa17b99a7635fed6b6018103042)
  build user:       root@05b1548df2cc
  build date:       20170926-16:41:43
  go version:       go1.8.3

Nevermind--ended up being some weird caching issue on my end unrelated to prometheus.


165 rework card component resolve overflow icon and image boolean issues implement new structure

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

Created ifx-card-image component
fixed the ifx-link icon
removed all the slots for the content components, and replaced them with a single default one. The img still needs a dedicated slot, though.
fixed ifx-link overflow bug
removed Props used as internal States
Added a React component for the Card

📦 Published PR as canary version: 19.0.0--canary.201.4c711a579731ae126c161509581c428caf586565.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Added the direction to the argsTable in the Card story so that the user can configure the card direction and then get the according code snippet right away. Besides that, looks good! You can merge it


Aborts: "loading libcrypto in an unsafe way"

I've never seen an error like this before:
In [2]: from twitter.account import Account
WARNING: /Users/reagle/.pyenv/versions/3.11.0/bin/python3 is loading libcrypto in an unsafe way
[1]    96622 abort      ipython

Interesting, this is likely due to the protonmail module I added, although I haven't gotten this error yet. What OS are you using?

OS: macOS 13.3.1 22E261 arm64

Same issue

@Ian-Bright, are you using an M1 or M2? Did you use pyenv? Here's what perplexity.ai has to say.

The root cause of this error is that the libcrypto library is being loaded dynamically at runtime, and the dynamic linker is unable to verify that the library has not been tampered with. This can happen if the library has been modified or if it is being loaded from an untrusted location
1
2
.

To fix this issue, one solution is to rebuild Python with a version of OpenSSL that is compatible with the macOS system. Another solution is to install a version of Python that has been built with a compatible version of OpenSSL, such as the version of Python that is installed using Homebrew
2
.

I found it does work if I install the pre-proton version: pip install git+https://github.com/trevorhobenshield/twitter-api-client@bf88a527e240a02763c944122244c774efcaa3fd

If this library is dependent on "proton-python-client", I can't even install that on macOS 13.3.1 22E261 arm64.

I've decided to temporarily remove the protonmail dependency until I can figure out a clean way to support more systems (not just arch/debian/fedora)
Try installing this new version
pip uninstall twitter-api-client -y
pip install twitter-api-client==0.8.5

Thanks @trevorhobenshield this worked


Worker pool

Overview
add worker pool to executor for local query processing

Pilosa previously spawned a goroutine for each remote node that a
query needed to be forwarded to, and then forwarded a single request
containing all the shards that the query should operate on. It then
spawned a goroutine *per local shard* to process the query
locally. This was fine if there weren't too many shards, or too many
queries coming in concurrently, but we found that it created issues
when there were 100s or 1000s of shards per node, and dozens of
queries arriving concurrently.

Specifically, the memberlist "hiccup" issue is highly correlated with
many goroutine scenarios, and after applying this patch, memberlist
complaints in the logs were much decreased, and nodeLeave events under
concurrent query load almost entirely eliminated.

This patch creates a fixed size pool of goroutines to do local shard
processing, and passes work to them through a channel, one job per
query per shard. Handling of remote requests (forwarding queries) is
unchanged.

We set the pool size to NumCPU()+8 somewhat arbitrarily, but this
seemed to work pretty well in our testing on 32 core machines. It's a
pretty big improvement over launching a goroutine per shard per query
which is what we were doing previously, so we can tune it more later
if necessary.

I think I still need to add some kind of executor.Close() method to make sure we aren't leaking goroutines in tests.
Naming is totally up for debate.
Capacity of channels and number of workers hasn't been super well scienced, but probably won't make much of a difference.
Fixes #1969 (probably)
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Add appropriate changelog label to PR (if applicable).

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.
[ ] Make sure PR title conforms to convention in CHANGELOG.md.
[ ] Make sure PR is tagged with appropriate changelog label.

The only thing that's concerning me (and we currently can't hit it) is that when we have cross-index queries, i think it becomes possible for all the workers to be blocked waiting for sub-queries that are in turn blocked waiting for workers. To fix that, I think: whenever a worker needs to make remote queries for some reason (for instance, cross-index queries, which I think would be the only case), it should probably do something where it launches them, then waits for them, but while waiting it runs other jobs from the work queue.
But I don't think we can or should fix that now, because we haven't got a way to verify the functionality until the cross-index queries are implemented and we can build a test case for it.
I would also suggest making the worker pool size configurable in some way.

I don't want to expose this config externally, but I did need to sort-of expose it to allow us to set it lower when creating test clusters. My thinking is that because we will likely need to revisit this as we implement Joins and other more complex queries, this will likely not be the right thing to expose, and changes to the config file seem like one more point of friction to avoid when doing upgrades, etc.


Feature Request: Trigger balloon via keyboard at cursor position

Hi,
I want to trigger the balloon text via keyboard at cursor position. I read the documentation and it looks like that at the moment the balloon textbox can be triggered only with the mouse, which is in my humble opinion not very Vim-like. Mouse is okay of course, but keyboard should have higher priority, or am I wrong?
It could be a function or a command that I can map (nmap/imap/vmap/xmap/smap) or use in Vimscript. Just the standard Vim solutions.
What do you think?
Thanks for your feedback
Have a great day
--marco

@marcotrosi this could be done by a plugin without integrating into core functionality.

@eirnym thanks for your feedback. maybe you can give me a hint how you would do it?
But besides that if Bram will implement popup window in a way that it can be triggered via keyboard, then my issue can probably be closed in the future.

Hi @marcotrosi, I think this feature request should probably go to https://github.com/vim/vim instead of MacVim (and as you mentioned there are already discussions on this in Vim). MacVim aims to be a nice GUI port of Vim with additional support for native macOS features but cross-platform basic functionality like this should be done in Vim instead (benefits everyone and decreases divergence from core Vim codebase).

Hello @ychin, you are absolutely right. I will close this issue here. Thank you.

@marcotrosi There's balloon_show() function and a few plugins like w0rp/ale.

I know that function, and I don't think that is how balloon_show() works. I tried to use it in the passed but the manual says clearly it's for asynch fetches. The trigger is still the mouse hover. But if you have a working example then this would be helpful.

I have no working examples for you here. I use YCM to fetch docs and go to the declaration. It's more convenient for me personally
The Vim todo help file has quite usable information for you


chore: added error check to some functions

Hi, added error check to some functions.

Thank you @ponkio-o!


WIP: Importing Tripleo-IPA content

So far without test coverage or any verification of basic function.

On hold until it's clear we want this.


Fix the bug of JSONType annotation

Fix the bug of the serialzeFilters attribute of JSONType annotation does not work in specific sistuation.(#2629 )
@wenshao PTAL, thk!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhuzhuman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhuzhuman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #2630 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2630      +/-   ##
============================================
- Coverage     81.25%   81.23%   -0.02%
+ Complexity     7029     7026       -3
============================================
  Files           143      143
  Lines         26246    26240       -6
  Branches       6274     6272       -2
============================================
- Hits          21327    21317      -10
- Misses         3106     3108       +2
- Partials       1813     1815       +2

Impacted Files
Coverage Δ
Complexity Δ

...libaba/fastjson/serializer/JavaBeanSerializer.java
83.13% <ø> (-0.01%)
180 <0> (-2)

...com/alibaba/fastjson/serializer/SerialContext.java
72.91% <0%> (-4.17%)
19% <0%> (ø)

...ava/com/alibaba/fastjson/serializer/DateCodec.java
87.58% <0%> (-1.97%)
37% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ccd8b...26cdf1c. Read the comment docs.


[HOLD] [$250] Android - Workspace settings - Placeholder "Name" in the field flickers when saving the changes after coming out from offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to the app and login
Create a New Workspace if it doesn't exist yet
Go to Settings / Workspace settings
Disable the internet connection on the device
Change the workspace currency and name
Save the changes
Go back online

Expected Result:
Placeholder "name" in the name field doesn't flicker or move
Actual Result:
Placeholder "name" in the name field flickers and can see a jerk
Workaround:
Unknown
Platform:

Where is this issue occurring?

Android

Version Number: v1.1.84-11
Reproducible in staging?:  Y
Reproducible in production?:  Y
Email or phone of affected tester (no customers):
<EMAIL_ADDRESS>/ Yulia1986Gerets
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/179226246-d6b1268e-6aff-445c-b5c1-2da220817313.mp4

Expensify/Expensify Issue URL:
Issue reported by:
Applause internal team
Slack conversation:
View all open jobs on GitHub

Upwork job here

@kavimurut he issue is reproducing across the app not only for general settings

The issue happens from this component
label width is 0 (initial state value) before onLayout callback and it flickers when render with active label scale.
2nd parameter of textInputLabelTransformation is 0 before width is set from onLayout callback.
In summary, flicker happens when label view scaled to 0.8668(ACTIVE_LABEL_SCALE) and width = 0
Label goes back to correct place when width set correctly(nativeEvent.layout.width) after onLayout callback
My suggestion to fix: hide label until width state value is set (update this code)
before: {this.props.label}
after: {this.state.width > 0 && this.props.label}
I tested and confirmed this fix on both platforms (iOS, android)

I like that solution! 👍 🟢

@errahsoufiane Do you have any other suggestions apart from the other? Although it is doable but does not give the best UI.

I already tried to show label even if width is not set yet. But based on current transform implementation of this component, it's impossible to set x coordinate correctly without knowing the width when view scaled to ACTIVE_LABEL_SCALE.
But this is very rare case and in very short time, when app becomes a little heavy due to some background tasks. Mostly not happen so I think it doesn't affect user experience much.

I did some testing and you might be correct as it will be hardly visible. When the lag is visible, onLayout takes about 300ms to fire after mounting (On Dev). Looking at a different perspective, do you think we can get away from this transform implementation so we don't have to deal with this issue at all.
The next thing would be to get some videos in and test the whole app to see if the hiding labels do not have a bad effect on any page. This video will be used to verify the UI by the designer team.

https://user-images.githubusercontent.com/108141252/180061013-a0159aa6-3a7c-4f54-bd79-daf9712420f4.mp4
https://user-images.githubusercontent.com/108141252/180061700-785eb616-db33-40eb-95dd-23863e73f5bf.mp4

@parasharrajat it's a little unclear above - are you 👍 for this proposal, or are we still ironing out the details?

Bump @parasharrajat

Should we pause on this one while we finish up offline improvements?

Should we pause on this one while we finish up offline improvements?

This happens not only when offline/online switch but also when app becomes heavy due to many background tasks (I confirmed)

Hm, it's possible that the offline refactorings could have an effect on this (because it might decrease the number of background tasks). It feels like this issue is such an edge case and low value, that I don't mind putting a HOLD on it for a couple of weeks to re-evaluate it later.

Issue not reproducible during KI retests. (First week)

OK, given @tgolen's comment:

this issue is such an edge case and low value, that I don't mind putting a HOLD on it for a couple of weeks to re-evaluate it later.

And the fact it was not reproducible during the KI test, I agree with putting this on HOLD and seeing whether it still occurs after offline first is finished in a few weeks. Doing that now - let me know if anyone disagrees with that approach

Gonna drop this down to monthly for the time being then.

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week)
@tgolen ok to Close?

Yes, thank you for testing it again! I'll go ahead and close it out.


ImportError: cannot import name 'Batch' from 'torchtext.data' (/usr/local/lib/python3.7/dist-packages/torchtext/data/init.py)

Not able to import PyTorch lightning to google colab

I'm also seeing this.
Did you find any workaround?

The reason of this bug is because the new released torchtext 0.9 has moved torchtext.data.Batch  to torchtext.legacy.data.Batch. Just see https://github.com/pytorch/text/releases/tag/v0.9.0-rc5.

Thanks. Here is my short term solution for this issue.
!sed -i -e 's/from torchtext.data/from torchtext.legacy.data/' /usr/local/lib/python3.7/dist-packages/pytorch_lightning/utilities/apply_func.py

Hey guys, Similar Issue #6415.
The solution is either

You could install from master pip install git+https://github.com/PyTorchLightning/pytorch-lightning.
Or, downgrade the pytorch-lightning version.


Changes TimestampSigner to sign with UTC timestamp

References #137
Get UTC timestamp according to Python's documentation
(https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow)

This looks correct, but I must be doing something wrong, time.time() and datetime.now(tz=timezone.utc).timestamp() both return the same value on my machine, even though it's in the America/Los_Angeles timezone. And this doesn't change the use of datetime.utcfromtimestamp(ts) in the next method.
@pganssle Is this the correct way to get/compare UTC timestamps as of Python 3.6?

I would definitely not use utcfromtimestamp.
I don't think it matters if you use time.time() or datetime.now().timestamp(), the latter is probably slower.
For datetime.now() it won't matter what time zone you represent it in, because .timestamp() returns a Unix time, which is inherently timezone-aware (it is the number is seconds since 1970-01-01 in UTC, not in the local time zone), as is datetime.now() (since it represents a moment in time and if it generates a naive datetime, the same time zone used to choose the datetime will be used to calculate the time stamp). It's maybe marginally safer to apply a specific time zone, because "local time" might change between the call to "now()" and "timestamp()", but it doesn't really matter much.

@davidism @pganssle Thanks for the discussion, even though this is a relatively minimal impact (I hope!) change.
@pganssle illustrated some key points, and prompted me to re-look at what time.time() does. Based on the docs, time.time() from all Python versions since 2.7 similarly return seconds since epoch, which involves UTC in its definition.
For what it's worth, I'm okay if this change of mine here is reverted / not moved forward. It's not "fixing" anything at this point, especially since 2.7.

Closing this as it's not needed. Thanks for looking at it!


Bug: song info

Bug Type
Function
Bugged function
$songinfo[userID]

Version of aoi.js
v5.5.5 (Default)
Version of Node.js
v16.6.0
Excepted Output
In $songinfo[userID]
Unidentified
Relevant log output
No log

Code of Conduct

[X] I agree to follow this project's Code of Conduct

user.id

Resolved.


information about CRAN package authors is not very current in depsy (EOM)

What is actually the refresh interval on depsy for CRAN projects ?
Is it possible to manually trigger the refresh ?
It would also be nice if the page showed the version number of date when the report has been actually generated.


refactor: use native utils

Summary
Buffer.from and mkdir with recursive flag are both supported in node 10.
Test plan
Tests should pass
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 94.397%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
1023

Relevant Lines:
1049

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 94.397%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
1023

Relevant Lines:
1049

💛  - Coveralls


⚠ Bofrost.de has degraded performance

In f77c572, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1294 ms

Resolved: Bofrost.de performance has improved in 234de08 after 6 minutes.


feat(readme): adds a bunch of docs

:tada: This PR is included in version 1.39.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


don't change AEBaseMenu#lockPlayerInventorySlot in a mixin, it is public

I probably won't bother to do this, https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/5840 will make this onsolete anyways


Add Historic USD token prices

Add USD prices to token transactions, on the day of the transaction.
We'll need a discussion on where historic data is available. CoinGecko?

Historic Prices Coingecko: https://docs.coingecko.com/reference/coins-id-history

Public Coingecko API is daily price data: https://docs.coingecko.com/v3.0.1/reference/coins-id-history


Avalanche Ledger Nano S - Connection issues

Description
When you connect with the ledger Nano S it ask for your public key in the device, once you accept it connects but then it keeps asking for the public key over and over in the device.
Tried it in dev in the rinkeby network and it worked fine, so is not the device itself
Environment

Browser: chrome
Wallet: Ledger nano S
Network: Avalance
Environment:
https://safe-team.dev.gnosisdev.com/app/open

Steps to reproduce Connection issues
You need to install avalanche app in the leger first
1 - Connect to the gnosis app with the native ledger connection
2 - Accept in the ledger the request for the public key
Expected result
The modal closes and the public key is not being asked anymore
Obtained result
The device keeps asking for the public key no matter how many times you accept the request
Screenshots
It remains with that loading icon for ever

I saw that @liliya-soroka requested Ledger functionality to be disabled on Avalanche.
How do we want to approach this error? Is it still deemed valid? @katspaugh @johannesmoormann


Fixed minor typo in the req.pod docs

Fixes #7927.
CLA: Trivial.

Checklist

[x] documentation is added or updated

I think this should be cherry-picked back to 1.1.1

IIRC, I edited the file directly from my browser on an iPad and couldn’t find a way to add a second commit to the first PR.

Ahh, that's no problem.
Ping @openssl/committers for a second review!

Merged to master (005247af76aa8d623fadbf3a82aa7b8ef449989f) and cherry-picked to 1.1.1 (30e35ee1d54a7ad55ba724da795c513f07653252)


Suddenly it stopped working

I haven't played for a while and then everything stopped running. They don't even start. Only in the task manager there is a process that does not load the CPU. I've tried different games, x32 and x64, different versions of DXVK (also dxvk-gplasync), reinstalled drivers using DDU, different driver versions, deleted RSS and MSI Afterburner. It remains only to reinstall Windows, but I really don't want to. It's very strange because recently everything worked perfectly. With apitrace game runs but using DX11 api (test game is thronefall) and has 1 fps.
System information

GPU: Intel Arc A730M
Driver: ANY but first faced on <IP_ADDRESS>19
Wine version: -
DXVK version: from 1.10.3 to 2.5.1
Windows 11 24H2 (26100.2454)

Apitrace file
https://mega.nz/file/PwZWCACa#8N-2yaDXgOc5nt62C_Ahy1JGVJwtcaRSPZ0YN_aR6Fg
Log file with 2.5.1 version is empty, but with 1.10.3:
https://pastebin.com/Azivs8ZM

Please check to see if you have Dozen installed and if so remove it (more details here).

Please check to see if you have Dozen installed and if so remove it (more details here).

you're goddam right, and I'm blind, I don't remember when and why I installed it

you're goddam right, and I'm blind, I don't remember when and why I installed it. thanks a lot

I don't think it was you, Windows just auto-installs it sometimes for whatever reason. It's not the first time we've seen it happen for sure, that's why we have a Wiki entry for it.


Standardize format of data in all ground truth files to be json

Type of Issue
Data format update requested
Select the type of issue:

[ ] Bug report (to report a bug)
[x] Feature request (to request an additional feature)
[ ] Tracker (I am just using this as a tracker)
[ ] Documentation Ask

Description
Currently the high_pri_commands.txt file under ground_truth has json.dumps for the dictionaries. I suggest we update the data format for all files under ground truth to have json format instead of string so we can get rid of ast.literal_eval altogether and use json.loads.

Agree, thanks for creating issue


TOC extension marker '[//]: # (TOC)' problem

Disclaimer: no idea what I'm doing :)
I'm trying to hide the [TOC] marker tag in the raw Markdown file using this recipe: https://stackoverflow.com/a/20885980/150649 (which I do confirm gets hidden when viewing via Github, etc.)
Using pdb I can confirm the self.marker is getting set properly to [//]: # (TOC) when passed in, but it's simply being... skipped? in the output. I tried to break it down into the simplest form:
>>> import markdown
>>> text = '''
... [//]: # (TOC)
... # 111
... ## 222'''
>>> md = markdown.Markdown(extensions=['toc(marker=[//]: # (TOC)'])
>>> print(md.convert(text))

111

222

Am I doing it wrong, or is this just a sequence of marker too complicated for the extension to handle maybe? I tried tracing the code but this isn't my forte, got lost a bit trying to figure out where the strip was happening... thanks.

If you don’t want to include the marker, then just leave it out. Or am I miss understanding what you are trying to do?

If you leave out the marker, then no TOC is generated so I'm not following your response? When you write a Markdown file and commit it to GitLab / GitHub / etc., the tag shows up in the output as raw [TOC] in your document when it's rendered (well, this isn't rendered - just raw text) and looks janky. it's undesirable and easy to see if you just make any random MD file here on Github.
The recipe I linked to above is how to use valid Markdown syntax to "hide" a comment (as you might do in HTML with ) so that it is not rendered, by using the footnote reference elements in a creative way. If you create a new MD file on Github, type in some content (and markdown) and include [//]: # (TOC) it does not get parsed or displayed in the output while in the git repository. It's an internal source comment only, nifty!
So the effort here is to set the Python-Markdown TOC marker tag to this special recipe, so that when passed through a generator to create HTML, it will still be found as a TOC and generate the content; however, that special recipe is hidden to Git repo views, as they all parse it into nothing visible. The problem is that the extension is just not properly parsing my tag - it sees it but strips it somehow as shown in my example. I would like the TOC extension to properly recognize this tag as the TOC marker and do the right thing. :) This way the content can be viewed cleanly on Git view, as well as generating HTML output by a renderer w/TOC.
I understand this is a complex example of a TOC marker tag and may be too much for this extension to handle right now, but according to people who know way more than me (the Internet) this is pretty much the only way to hide comments in Markdown in a compatible way. I'm just lost in the Markdown TOC code trying to figure out why it isn't working correctly to help figure out what's broken - I can determine that the self.marker is set correctly, the TOC marker makes it into the class attribute unmolested - then it just sort of... doesn't work.

OK I'm getting somewhere, I was looking in the wrong place - the problem appears to be the ReferencePreprocessor which runs before the TOC extension runs, right here:

https://github.com/Python-Markdown/markdown/blob/master/markdown/core.py#L231

(Pdb) print(self.lines)
['[//]: # (TOC)', '# 111', '## 222', '', '', '']
(Pdb) n
-> self.lines = prep.run(self.lines)
(Pdb) print(prep)
<markdown.preprocessors.ReferencePreprocessor object at 0x7f74343199b0>
(Pdb) n
-> for prep in self.preprocessors.values():
(Pdb) print(self.lines)
['', '# 111', '## 222', '', '', '']

...one step closer, this makes sense as I'm using a reference marker. So the marker element to replace is getting stripped out of the source before the TOC extension can replace it (verified that inside the TOC extension code).

@troyengel, that's how it is supposed to work.  Those are references that can be used later, but if they are not used, they don't make it to the output.  This is how it should be, and that won't change. Don't believe me, check out how other parsers handle un-linked references here.
Comments are for the person reading the source, not for the result/output. Even in coding languages, comments don't make it the binary, because they are worthless to the binary.  Now references are not comments, they are just used in this hacky way by some people.  But un-linked references are also worthless in the output.
Personally, if you want to comment, just use HTML comments. Just remember that it is HTML and does take up space and is parsed as HTML, so put some empty lines around it.

If you want to output a table of contents, but not show it (which sounds like what you really want), commenting with a reference hack is not the answer.  You should just output the TOC and hide it via CSS by targeting the .toc class.

Yeah, that's it - the ReferencePreprocessor is stripping out my reference tag before the TOC extension can see it by design, which sort of leaves me wondering if there's any way to solve this other than skipping this routine entirely. Inside it... (abbreviated output):

https://github.com/Python-Markdown/markdown/blob/master/markdown/preprocessors.py#L323

 ... ... ...
-> line = lines.pop(0)

(Pdb) print(line)
[//]: # (TOC)

(Pdb) print(self.RE)
re.compile('^[ ]{0,3}\\[([^\\]]*)\\]:\\s*([^ ]*)[ ]*([ ]*(\\"(.*)\\"|\\\'(.*)\\\'|\\((.*)\\))[ ]*)?$', re.DOTALL)

-> m = self.RE.match(line)
-> if m:
-> id = m.group(1).strip().lower()
-> link = m.group(2).lstrip('<').rstrip('>')
-> t = m.group(5) or m.group(6) or m.group(7)
-> if not t:
-> self.markdown.references[id] = (link, t)

(Pdb) print(self.markdown.references['//'])
('#', 'TOC')

-> return new_text  # + "\n"
(Pdb) print(new_text)
['', '# 111', '## 222', '', '', '']

Please see my previous comment as I believe it answers your question.

@facelessuser that's not what I want at all - I've discovered the problem as outlined above, it's an order of operations. The reference preprocessor is stripping and stashing my reference tag before it's passed to the TOC extension processor to see it. Nobody is saying this is improper or not as designed (not sure why you're getting all aggro), it's just how Python-Markdown is designed in code flow now that I have debugged it. Now that I understand why it doesn't work how I want it to, I can develop a workaround.

I'm not sure what you mean by aggro, aggressive maybe? but what I was doing was laying out that fundamentally, this is how all Markdown processors work.  I don't think I was being aggressive, but instead was trying to be informative. Maybe I was too direct? Anyways, I also wanted to be clear that changing this behavior isn't going to happen (if there was intention for it to be officially changed).
I also pointed out the most sensible way to hide the toc and still output it (withing the existing default options and features).

If you want to output a table of contents, but not show it (which sounds like what you really want), commenting with a reference hack is not the answer. You should just output the TOC and hide it via CSS by targeting the .toc class.

If this approach is not to your liking, and you are really set on using this reference approach, then feel free to continue, but there will be more issues as well.
Even if you changed the "flow" and toc is expanded in the references, un-linked references are still thrown away, which is what I was also illustrating. Modifying references to allow TOC expansion will not solve your problem.
You may just want to write your own commenting extension, or your own custom reference extension (and in this case replace the official one when it loads). I guess you are also free to fork the official repo and modify it to your liking as well. Another option is to just write a post processor that looks for TOC and hides it, if that is your desire.
Maybe I've also misunderstood what you are trying to accomplish?

Yep, you've misunderstood and have it backwards. Also, the HTML comment doesn't work because there's a regex substitution in the TOC extension itself which strips out all HTML entities before processing the comment (see stashedHTML2text(text, md)) so that's a red herring as well, that ws the first thing I tried. Closing, this will go nowhere now that I have debugged why it won't work with this code.


Round 2 US payroll

Docs Build status updates of commit 6c61b5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fix Issues #322

fix Issues #322

Thank you very much for your contribution. But can you please add a unit test?

a unit test has added


WhitespacyLinesFixer - fix bug cases

fixes #1506
replaces #1551

ping @JanisE  @SpacePossum

This will be the last one to v1.10.x

lgtm :+1:  thanks

:+1:

:+1:

Thank you @SpacePossum.