gotham_restful 0.1.0 is not available on docs.rs

Crate name: gotham_restful
Build failure link: Not available, the build is missing
Additional details:
Version 0.1.0 has been published to crates.io on the 2nd October, yet docs.rs cannot find that version and claims the latest version was 0.1.0-rc0 and the latest stable was 0.0.4 (https://docs.rs/crate/gotham_restful)

It was in the queue with attempt = 5, so this is another case of https://github.com/rust-lang/docs.rs/issues/797. Checking now to see exactly what the error is.

It's working now :shrug: It will be hard to find what's going wrong here until we fix https://github.com/rust-lang/docs.rs/issues/797, so I'm going to close this as 'can't reproduce' - feel free to re-open if you're still having trouble:


Enum value names

I have the following enum:
namespace WebApi.Logic.CustomPages.Dtos
{
    public enum CustomPageFieldType
    {
        Text = 1,
        Numeric,
        Date,
        Numeric_Function,
        Dropdown_List,
        Checkbox
    }
}

However, when a class includes this as a property it is shown as type (integer, optional) = ['1', '2', '3', '4', '5', '6']integerEnum:1, 2, 3, 4, 5, 6,, and when exported using NSwag as a Typescript enum it has the following definition:
export enum CustomPageFieldResponseDtoType {
    _1 = 1,
    _2 = 2,
    _3 = 3,
    _4 = 4,
    _5 = 5,
    _6 = 6,
}

How can i get it so that the enum is exported as:
export enum CustomPageFieldResponseDtoType {
    Text = 1,
    Numeric = 2,
    Date = 3,
    Numeric_Function = 4,
    Dropdown_List = 5,
    Checkbox = 6,
}

Thanks

This goes beyond a "class includes this as a property" ...
Here is a test controller I created:
http://swashbuckletest.azurewebsites.net/swagger/ui/index#!/TestEnum/TestEnum_Get
That takes an enum as a parameter and returns it:
    public class TestEnumController : ApiController
    {
        public enum CustomEnum
        {
            Text = 1,
            Numeric = 2,
            Date = 4,
            Numeric_Function = 8,
            Dropdown_List = 16,
            Checkbox = 32
        }

        public CustomEnum Get(CustomEnum value)
        {
            return value;
        }

What I find interesting/weird is that the response changes when we change the Response Content Type, with JSON it give us the numeric value, but with XML it show the name.

@stuartbloom  maybe what you need is to enable:
c.DescribeAllEnumsAsStrings();
that is on the ...App_Start\SwaggerConfig.cs file.
Try it out and let me know.

@heldersepu
Thanks, I did try that, but then my enums are set as strings.  I was hoping to keep the values going between api and client as integers/numbers, but in my ts reference them as MyEnum.Enumeration rather than MyEnum._0

@stuartbloom
there is nothing wrong with enums set as strings is it?

no, I guess not; i suppose it will make it easier for other consumers to make sense of what is going on :)  Thanks

I do see your point ...
and I think we are limited by the swagger definitions of enums:
http://swagger.io/docs/specification/enums/
there is no place for the actual value of the MyEnum.Enumeration
In my CustomEnum the values are not sequential, if I wanted to inform that to the final consumer I will have to create an SDK or point them to my code.

Yes, this is an issue.
The data coming from the API has the enumeration, however, the swagger does not document it as an integer if you call DescribeAllEnumsAsStrings().
Surely there is a way to have the enumeration to contain the Name with its actual value rather than its name and the string representation of the name?

I mentioned on my previous comment...
This is not a Swashbuckle issue, we are limited by the swagger definitions of enums:
http://swagger.io/docs/specification/enums/
You should open an issue with them:
https://github.com/OAI/OpenAPI-Specification

@heldersepu my apologies, thanks :)


#19 Add application auto complete

Uses https://github.com/cartesi/rollups-explorer/pull/28 as base. On page load, we get all applications and then FE-driven search is performed, Instead of making requests each time the user changes the search value. Here's how it looks:
https://github.com/cartesi/rollups-explorer/assets/6005179/1cdd5aa2-7adb-42f0-ab16-33ebd55c004d

Hi @nevendyulgerov open the PR against the base branch you used instead of against main. That makes the PR smaller and also will not  merge code from a Branch that may change (the base branch still to be reviewed)

Please rebase

Closing this one in favor of https://github.com/cartesi/rollups-explorer/pull/35.


JSON Documentation Discovery

How do I find the URI that identifies the JSON rendition of the OpenAPI documentation for each API produced by your solution? Ideally, you would have an icon placed somewhere in the HTML-based interaction console [1] combined with other discovery techniques such as the  script or @rel in HTML and HTTP respectively.
[1] https://osdb.openlinksw.com/osdb/api/console

JSON representation of http://grlc.io/api/albertmeronyo/lodapi/ can be found here http://grlc.io/api/albertmeronyo/lodapi/spec -- is this what you are referring to?
Yes, other discovery techniques would be nice. Grlc is using a relatively old version of swagger-ui, as pointed out by issue #105 -- so it is definitely an improvement which should be implemented. Pull requests on this direction would be very welcome!

@c-martinez ,
This relates to bug at: https://github.com/CLARIAH/grlc/issues/64 .

@kidehen -- #123 has now been merged (although not yet deployed at grlc.io). Do you have a local grlc instance where you could check if this meets requirements for JSON discovery ? If not, we might need to wait until it is deployed and we can then check and see if we can close this issue.

@c-martinez ,
I don't have a local instance, so just notify me when its deployed publicly and I can then repeat my tests.

Hi @kidehen @c-martinez thanks for looking into this.
I deployed but rolled back, since I spotted a number of bugs I did not catch before the merge. Hopefully we can re-deploy soon.

@kidehen -- we now have a dev.grlc.io version deployed, which uses a more recent version of SwaggerUI. When you load, for instance http://dev.grlc.io/api/albertmeronyo/lodapi, this version provides already a link to /api/albertmeronyo/lodapi/spec at the top.
Could you check it out and let us know if this already what you expected? We can then close this issue.

Closing issue -- please re-open if the solution does not really solve the issue.


fix: The translate directive inside html tags is sometimes not dete…

:tada: This PR is included in version 1.11.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add quickstart guidance in readme

Looking good.
There is one addition I would like to see: passing third argument to -RegisterNewNode is now kind of black box:

When auto-expiration happens?
What triggers auto-expiration?
Does it just allow re-register SHIR with same node name when HA is used?


Refactor BPF recorder to enable simultaneous profile recording

What type of PR is this?
/kind bug
/kind cleanup
/kind feature
What this PR does / why we need it:
This PR:

Separates the BPF recorder from Seccomp and AppArmor logic and puts those parts into bpfrecorder_seccomp.go and bpfrecorder_apparmor.go respectively.
Updates the BPF recorder to use LSM and tracepoint/sched hooks instead of hooking syscalls. This increases recorder coverage (for example, we previously missed some lockfiles, which caused incomplete profiles) and enables us to use bpf_d_path() to get absolute file paths in all cases. It also fixes tracking of child-child-processes. This makes the AppArmor recorder work flawlessly with several real-world workloads.
Adds --type all for the recorder to simultaneously record AppArmor and Seccomp profiles.

Which issue(s) this PR fixes:
Fixes #2255
Does this PR have test?
Yes.
Special notes for your reviewer:
The good news is that we remove significantly more lines than we add, the bad news is that this PR is still quite large. This thing emerged from a rather iterative integration hell, let me know if we need to split it up further. :)
Does this PR introduce a user-facing change?
`spoc` can now record Seccomp and AppArmor profiles simultaneously.
The AppArmor recorder is now significantly more robust

/ok-to-test

Codecov Report
Attention: Patch coverage is 55.85831% with 162 lines in your changes are missing coverage. Please review.

Project coverage is 41.92%. Comparing base (11d77f4) to head (fd40519).
Report is 206 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2260      +/-   ##
==========================================
- Coverage   45.50%   41.92%   -3.58%
==========================================
  Files          79      109      +30
  Lines        7782    15521    +7739
==========================================
+ Hits         3541     6507    +2966
- Misses       4099     8542    +4443
- Partials      142      472     +330

Thank you for the super quick review, @ccojocar - you folks are fantastic! 😃 🍰
CI has unfortunately uncovered a new issue I wasn't aware of before: Modern kernels all have BPF LSM support, but Debian/Ubuntu has not enabled it by default (see https://github.com/lockc-project/lockc/issues/159 and  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2054810). This means the AppArmor recorder won't work on these systems properly as these hooks are silently ignored (Exhibit A: test / e2e-spoc fails in CI). Unfortunately there are no good workarounds. We do really want bpf_d_path to get absolute paths, the previous implementation was pretty broken. But the non-LSM hooks allowlisted to use bpf_d_path are not comprehensive enough to cover our needs. So we have to use LSM hooks for recording.
I've updated AppArmorRecorder.Load to error at runtime if we detect that LSM hooks are disabled. This unfortunately means we cannot run all the spoc tests in CI currently, but I've made it so that we still cover the AppArmor parts that do not rely on file paths.

/retest

I've updated AppArmorRecorder.Load to error at runtime if we detect that LSM hooks are disabled. This unfortunately means we cannot run all the spoc tests in CI currently, but I've made it so that we still cover the AppArmor parts that do not rely on file paths.

Isn't possible to enable it into the integration tests for Ubuntu? Does it require to recompile the kernel with the LSM hook flag enabled? Not sure what kernel version is used by the integration tests, but it would be great to have a test for this to avoid future breakage. Maybe you can deploy a dedicated VM image.

The profile merging test seems to fail now:
TestSuite/TestSecurityProfilesOperator/cluster-wide:_profile_merging

Isn't possible to enable it into the integration tests for Ubuntu? Does it require to recompile the kernel with the LSM hook flag enabled? Not sure what kernel version is used by the integration tests, but it would be great to have a test for this to avoid future breakage. Maybe you can deploy a dedicated VM image.

My understanding is that it requires a recent Kernel (which we have in CI), but also boot-time configuration which is not set on the GitHub-hosted runners. The libbpf are running custom kernels via QEMU - that would be an alternative, but also comes with quite a lot of CI infrastructure that we would need to maintained (the libbpf folks have their own repo just for the GitHub Actions - https://github.com/libbpf/ci/tree/main).
I have updated test/spoc/e2e_spoc_test.go so that we always test AppArmor socket and capability recording, even if BPF LSM support is missing on the host. This ensures that the AppArmor subsystem is working, which I think should cover most things that could possibly break. I feel it's probably ok to accept the risk for now. Eventually https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2054810 should be fixed and we get this fully covered in CI again without spending any effort on it.
Will take a look at the remaining CI failures later today. :)

CI failures fixed in 8d28fc6. 😃

I have GHA tests passing for the same code at https://github.com/mhils/security-profiles-operator/pull/4, so I assume the previous failures were just flaky tests. :)

My understanding is that it requires a recent Kernel (which we have in CI), but also boot-time configuration which is not set on the GitHub-hosted runners. The libbpf folks are running custom kernels via QEMU to work around this. That would be an alternative, but also comes with quite a lot of CI infrastructure that we would need to maintained (they have their own repo just for the GitHub Actions - https://github.com/libbpf/ci/tree/main).

We use the ubuntu-22.04 as an action image and on top of it runs vagrant with different images such as ubunut, fedora and flatcar where we run the e2e tests. This provides us some flexibility since the LSM needs to be enabled on vagrant image. I think we can add a dedicated e2e job for debian with LSM enabled (LSM should be enabled by default in Debian as I understand from ubuntu bug, or a custom ubuntu image with LSM enabled.
In case the e2e tests are taking too long, we can think to phase out the flatcar e2e test. I am not sure how much is used these days.
I would add this e2e test as a follow up pull request. I guess you can follow the same approach we have for fedora..
@saschagrunert What do you think?


Rename mint and burn functions name in the UtilityTokenInterface.

[Discuss with team, this is not yet finalized.]

Rename the functions in the UtilityTokenInterface from Mint to increaseSupply and burn to decreaseSupply.
EIP20 CoGateway should be updated accordingly.
We may also think to re-introduce UtilityTokenAbstract (Discuss this with the team).

ref: https://github.com/ethereum/EIPs/pull/621

@deepesh-kn:

Considering that we will use OpenST-contracts utility token, we may not need utility token abstract.


Display input for KubeRay parameter and check for existence

Issue link

What changes have been made

Display KubeRay parameter in release workflow and check for the existence of the chosen KubeRay release.
Previously the KubeRay parameter was not displayed

Verification steps

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] Testing is not required for this change

@ChristianZaccaria Thinking about usage of Check if KubeRay release exists.
Should it be just informative or should it be considered as a prerequisite of the release?

@ChristianZaccaria Thinking about usage of Check if KubeRay release exists. Should it be just informative or should it be considered as a prerequisite of the release?

I think in this case we will always want to specify an existing version of KubeRay to ensure the compatibility matrix is updated to the correct version we have tested. Inputting a non existing version in the matrix could cause confusion. What do you think?

In such case it may be good to fail whole pipeline in case KubeRay version is not valid.
Can you adjust other steps to require this new step to pass first before being triggered?

I added that check now. I think we don't really require the check-kuberay-version to be triggered for instascale or codeflare-operator as the other components will need to pass first. Should I keep the check or remove them from instascale and CFO?

You can remove it from InstaScale and operator

Updated, I think it's good to go. Thanks Karel

One nitpick above,otherwise looks fine.

Thanks good catch!


add OSX docker support

This resolves #16
In the case when executing serverspec on OSX vagrant-serverspec will now proxy ssh commands through the boot2docker host vagrant creates to the container. It only does this on OSX so linux functionality where docker is running on the same machine as vagrant should be unaffected.

+1

Hi @joshughes  thank you for your PR, may also add some little instruction to Readme for OSX users?
Also do you have possibility to test it under linux docker to be sure?

@vvchik Sorry I missed your comment. Basically the serverspec plugin already works for linux because there is not jumphost to ssh proxy through. OSX docker MUST run in an VM. Vagrant handles this by spinning up an VM in virtualbox that has the docker client installed. Basically my patch finds that host and ssh's into that host before sshing into the actual docker container.
There is not special configuration needed for OSX or Linux for my patch to work... If the users have followed the instructions on how to use the Vagrant Docker provider, with my patch the serverspec plugin will simply just work, like it does for AWS, Virtualbox and others. So Docker on OSX and Windows is a special case since the Docker host is on a VM so we have to use an SSH proxy host.
I can write up an explanation in the README if you like... but the idea of the patch was that serverspec would just work, like it does for most providers at the moment. Just let me know what information you would like included.

Hi @joshughes,
It would be great if we can add a note about this to the README.

@jvoorhis I added a note to the readme with the basic explanation on why the ssh proxy is needed, and a reference to this pull request in case anyone in the future wants to look at the exact code that handles the ssh proxy.

@jvoorhis ANything else I can do to get this merged?

@jvoorhis do you have any time to merge this PR?

I may merge it, but it will not update it on rubygems.

Any reason why you don't want to do a release to rubygems? @vvchik

+1, this would definitely help.

@joshughes I don't have rights to do it :)

@vvchik who has the rights?

@vvchik can you confirm your rubygems.org handle in the thread? I'd be happy to add you as a project owner.

Vvchik,  same as here :)

Great, I've added you as an owner of the rubygem.
On Mon, Aug 10, 2015 at 12:38 PM, Volodymyr Babchynskyy <
<EMAIL_ADDRESS>wrote:

Vvchik, same as here :)
—
Reply to this email directly or view it on GitHub
https://github.com/jvoorhis/vagrant-serverspec/pull/17#issuecomment-129578507
.

--
Jeremy Voorhis

I`ve added latest version to rubygems
so @joshugnes, you may use it in standard way via vagrant plugin install


Port from nix to rustix

Currently blocked on https://github.com/Smithay/wayland-rs/pull/640

Closing, since this was implemented in https://github.com/Smithay/wayland-rs/pull/658.


[Feature] Fix license lookup [OSF-8856]

Purpose
Fix js error on search results page which makes loading appear infinite.
The main issue occurs because elastic search returns (depending on the query)
AFL3 as part of the license aggregates. AFL3 is removed from licenses gathered
from license list. https://github.com/CenterForOpenScience/osf.io/blob/45451c06bbd22cb64c139a8e2590ecce9925c99f/website/static/js/licenses.js#L4
With no AFL3 key in the initial licenseCounts list (built from licenses list), the filter returns empty array which upon indexing causes error and the loading binding to stay true.
https://github.com/CenterForOpenScience/osf.io/blob/45451c06bbd22cb64c139a8e2590ecce9925c99f/website/static/js/search.js#L395-L402
Changes
For now, just prevent JS error from happening using a simpler loop.
Ticket
(OSF-8856)[https://openscience.atlassian.net/browse/OSF-8856]

closed in favor of hotfix https://github.com/CenterForOpenScience/osf.io/pull/7856


Button for assets summary search

Add an icon/link to each assetsSummary field on the DLP that will perform a dandiset search using the value of the field as the search keyword.

@satra I think this captures what you described earlier today, if not feel free to add additional context.

yes. thank you.


Secant, Cosecant, Arcsecant, Arccosecant

By which release we want to see them?

By 1.2 🦆

[x] Secant
[x] Cosecant
[ ] Arcsecant
[ ] Arccosecant


Add ability to preview docs on PR to devel

This will help spot weird formatting issues that tend to creep in over time.

Note that the pkgdown workflow takes 15+ minutes per run. This will be costly to DX and productivity, and of course compute resources. I'd advise against this, but it's up to you, @bms63 & @thomas-neitmann.

Artifact resulting from this run can be found here: https://github.com/pharmaverse/admiral/actions/runs/2450586082
Needs to be downloaded and rendered locally.

Note that the pkgdown workflow takes 15+ minutes per run. This will be costly to DX and productivity, and of course compute resources. I'd advise against this, but it's up to you, @bms63 & @thomas-neitmann.

How about going forward we have a pre-release branch which we use for the final adjustment prior to a new release? Then we could trigger this workflow only on changes to pre-release.

pre-release branch makes more sense to me to save resources and take in your advice @dinakar29 .  Also will help with timing  of release of the website with the actual release to CRAN.
We also ask our developers to build the pkgdown site as part of the pull request checklist, but I've found some people don't really follow through with this task.  :(  When enough people forgo this item it just cascades issues into our website.

@thomas-neitmann So if we do create a pre-release branch - what does final release management strategy look like?
Something like this?
graph TD
  devel --> pre-release
  pre-release --> main
  main --> tag/release

Hi @bms63 - there is a way to do that, but I don't have access to that S3 bucket or any other hosting service, so we're limited by GH pages for now.

@thomas-neitmann So if we do create a pre-release branch - what does final release management strategy look like?
Something like this?

That's exactly what I had in mind.

Hi @bms63 - there is a way to do that, but I don't have access to that S3 bucket or any other hosting service, so we're limited by GH pages for now.

@epijim Can we get access to that S3 bucket?

/roxygenize

@epijim Any chance we can get access to the S3 bucket to host a private preview version of our website before it goes live?

All - barring the S3 bucket, I can think of another way to host the devel and pre-release version of the docs on gh-pages without any additional infrastructure needs. Watch this space for updates. Coming soon.

Looking forward to your updates @dinakar29!

Closing in favor of https://github.com/pharmaverse/admiral/pull/1245


chore: update codeowners to @basis-theory/engineers [ci skip]

Description

Update CODEOWNERS to allow all Basis Theory engineers to approve pull requests

Testing required outside of automated testing?

[X] Not Applicable

Screenshots (if appropriate):

[X] Not Applicable

Rollback / Rollforward Procedure

[X] Roll Forward
[ ] Roll Back

Documentation
N/A
Reviewer Checklist

[ ] Description of Change
[ ] Description of Business Impact.
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

v1.3.0
GitHub release

Your semantic-release bot :package::rocket:


TD_frac for UraniumOxide and MOX doesn't do anything

There are no tests for either the uraniumOxide or mox modules. That's pretty crazy, but that's just how it is right now. I don't know how many people use those classes, but I use them a lot. So I started writing some tests. Turns out there is at least one major problem -- the TD_frac material modification doesn't do anything for either of those classes. To confirm for yourself, try running the following:
"""
Tests for Uranium Oxide.
"""

import unittest

from armi.materials.uraniumOxide import UO2
from armi.materials.tests.test_materials import _Material_Test

class UraniumOxide_TestCase(_Material_Test, unittest.TestCase):
    MAT_CLASS = UO2

    def setUp(self):
        _Material_Test.setUp(self)

    def test_applyInputParams(self):
        self.UO2_TD = UO2()
        original = self.UO2_TD.density(500)
        self.UO2_TD.applyInputParams(TD_frac=0.1)
        new = self.UO2_TD.density(500)
        ratio = new / original
        self.assertEqual(0.1, self.UO2_TD.getTD())
        self.assertEqual(ratio, 0.1)

if __name__ == "__main__":
    unittest.main()

You'll see that the test fails. This is a big problem!
This could be a problem for other material classes as well. The only other one I've looked at is B4C, which appears to be fine.

I am working on a fix.

Tests for MOX:
https://github.com/terrapower/armi/blob/e5aa9d2e37a3cd99abeccac46f22946676cda496/armi/materials/tests/test_materials.py#L194-L213
Tests for UraniumOxide:
https://github.com/terrapower/armi/blob/e5aa9d2e37a3cd99abeccac46f22946676cda496/armi/materials/tests/test_materials.py#L432

The UraniumOxide module has 86% code coverage.
The MOX modules has 63% code coverage, though that could be better.

Ah, okay, that is right, I completely forgot those tests are hidden in there. Thanks for pointing that out!
I do believe, though, that the problem with TD_frac that I point out is still an issue. Are you able to confirm/deny this?

To the best of my knowledge theoreticalDensityFrac is entirely unused in ARMI, except for one use case, in B4C:
https://github.com/terrapower/armi/blob/e5aa9d2e37a3cd99abeccac46f22946676cda496/armi/materials/b4c.py#L168-L178
I think it's also possible this is entirely unused downstream plugins/repos.


tests: Refactor tests in test_realm.

First commit is to improve the tests for video_chat_provider and jitsi_server_url settings.
Second commit is to remove set_up_db calls.

Fixes:  https://github.com/zulip/zulip/pull/14639#issuecomment-621529750

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Was going through my old PRs, and saw this was pending, so just decided to complete it.

Added one more commit for this.

This is great, merged, thanks @sahil839!


Change all security keys

Change all security keys, that was compromised (was loaded to GitHub with Web.config.Release file).

Done


bro how install this

i am on windows peole tell to install thim

i am on windows peole tell to install thim

literally find the config file and change it you dumbass

Neofetch does not support Windows.

youre welcome

Oh right, it's on Cygwin.


Adjust the configureTaskUsingProjectProperty sample for configuration cache

Fixes #21825
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks @bamboo . PR updated.

This is looking good, @SidB3 👍
Please add your full name and github handle to the list of contributors in the release notes as described here.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge

OK, I've already triggered a build for you.


How to parse application/csp-report

https://helmetjs.github.io/docs/csp/
part: CSP violations
type: ['json', 'application/csp-report'] not work

koa-body does not currently support parsing application/csp-report.


Enabling k8s Deployment ability to control Replica Set's life cycle with selectors.

Before:
Every time you update specs of the Deployment, new Replica Set is created by Deployment without deleting an old one.
After:
Deployment is able to delete old Replica Set.

/lgtm
we just need a CLA, ty

kubernetes is supposed to default spec.selector for extensions/v1beta1 deployments. I think in the near future we will want to update all yamls to apps/v1 but until then..


google colab always disconnect

i try to train but google colab always disconnect and the running does not finish.
i try to add script to browser to connect every 1 minute, it does not help me..
TNX

Hello @refaeldimri,
I think you should check if you are on a GPU or not because this a kind of problem that normally occurs when trying to train a deep learning model using just the CPU on google colab. To set you your runtime such that it is using a GPU click on runtime on colabs menu. Then a  drop-down menu would show up and in that click change runtime type. After doing all that just restart your notebook. Voila, everything starts to work properly.

TNX @AbimbolaOO . i think u right, i forget to do it.

i did it. it is better, but still disconnect and can not connect GPU always. if i mount my drive, is the data saved? how can i run from the point it stopped?

You might want to post this issue in the Colab Tools repo.
https://github.com/googlecolab/colabtools/issues


Added hx-disable-elt attribute

This feature was added in the following PR: https://github.com/bigskysoftware/htmx/commit/af0dc9c3521a4a5298a8ec080e60a4e05e17c269.

Nice, thanks!

Released in https://github.com/maragudk/gomponents-htmx/releases/tag/v0.4.1


pyenv problem

I have installed it under pyenv.
Then I can't import module:
psrv:~/python/ph$ python
Python 3.10.12 (main, Sep 11 2024, 15:47:36) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

from pornhub_api import PornhubApi
Traceback (most recent call last):
File "", line 1, in
File "/home/ps/python/ph/lib/python3.10/site-packages/pornhub_api/init.py", line 1, in
from pornhub_api.api import PornhubApi
File "/home/ps/python/ph/lib/python3.10/site-packages/pornhub_api/api.py", line 2, in
from pornhub_api.modules.video import Video
File "/home/ps/python/ph/lib/python3.10/site-packages/pornhub_api/modules/video.py", line 6, in
from pornhub_api.schemas.video import VideoResult, IsVideoActiveResult
File "/home/ps/python/ph/lib/python3.10/site-packages/pornhub_api/schemas/video.py", line 41, in
class VideoResult(BaseModel):
File "/home/ps/python/ph/lib/python3.10/site-packages/pydantic/_internal/_model_construction.py", line 115, in new
private_attributes = inspect_namespace(
File "/home/ps/python/ph/lib/python3.10/site-packages/pydantic/_internal/_model_construction.py", line 371, in inspect_namespace
raise TypeError("To define root models, use pydantic.RootModel rather than a field called 'root'")
TypeError: To define root models, use pydantic.RootModel rather than a field called 'root'

@piotrszymanek thank you for reporting, this is related to incorrect pydantic pinning
should be fixed in version 0.4.0

Thank you, I confirm that now it is working.


Windows sync issue 7.4.18

/case/447400 - 2nd occurrence in 2 months despite newest version, logs included

@nicktoggl This is caused by a large amount of unsynced entries. Current fix is to export data from local database and import csv.
This fix is next on my list so in few weeks we should get this issue fixed.

This is fixed with converting to api v9 #2047

Updated version will be in beta today.

Beta release will be next week as some scenarios still need testing.


Add selected prop to seed selected items

Hey,
thanks for a multi-select ink component. Building a cli which needs to seed the selected items based on previous inputs. Would be fantastic if we could seed the selected state property.

close this issue as fixed in https://github.com/karaggeorge/ink-multi-select/pull/4


Allow using an alternate suite repo

... and also optionally look for tasks and suite definitions in a subdirectory of that repo
This still needs to be tested but is ready for feedback

Note to self: repos on-disk need to be named to avoid collisions

@liewegas I believe this does what we want now!

Testing new worker code with new suite features:
http://pulpito.ceph.com/zack-2016-12-02_09:49:30-smoke-master---basic-mira/596203/
Testing new worker code without new suite features:
http://pulpito.ceph.com/zack-2016-12-02_09:50:46-smoke-master---basic-mira/596205/
Both are doing what I would expect.

I'm going to push some unit-test-only changes

Do you want to wait for those unit test changes?

@dmick I pushed them Friday morning

so confused; gh doesn't show any new commits after your comment.  sigh.

It was a force push on top of an existing commit
On Mon, Dec 5, 2016 at 2:25 PM, Dan Mick<EMAIL_ADDRESS>wrote:

so confused; gh doesn't show any new commits after your comment. sigh.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ceph/teuthology/pull/990#issuecomment-264981807, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADjw2XxtUDcku32_tW2_RKI_YRP8L7Yks5rFIEwgaJpZM4LAwVQ
.

a shallow clone also seems safe to me.  +1


sensu_gem can now optionally specify gem_package

Signed-off-by: Ben Abrams<EMAIL_ADDRESS>
Description

Allow setting package_name in sensu_gem so that you can install multiple versions of the same gem by allowing the name of the resource and the package can differ.
Motivation and Context

This is helpful when you need multiple versions of the same plugin (or any gemfor that matter) by allowing the resource name and package name to differ.
How Has This Been Tested?

integration test
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

released: https://supermarket.chef.io/cookbooks/sensu/versions/5.4.0


hyperf除了支持mysql数据库，3.0支持oracle以及别的数据库了吗

Before you submit this issue, you has been search all existed issues and search the documentation

[] I've been search all existed issues
[] I've been read all documentation

Describe your question

3.1 会支持

@limingxinleo 请问现在 3.1 支持 oracle 了吗？没找到相关文档


Google drive app can't login to stackedit

I connected stackedit with google drive using the google drive ui. When clicking on it I'm asked to login, I do and nothing happens in the stackedit window.
The following error is available in the console:
googleHelper.js:238 Uncaught (in promise) Error: Google account ID not expected.
    at googleHelper.js:238

I tried this again and it now works. The solution was 1/2:

I was logged in on the wrong google apps account (my private one)
I logged in on stackedit.io and setup authentication there.

Got the same behavior today - I too had multiple Google accounts logged in, which may have confused StackEdit.
Steps:
1 . logged in to 2 Google accounts
2.  tried to use StackEdit for the first time to open a .md file in Drive under account 1 (account 0 is the one you are redirected to when you go to a URL such as https://drive.google.com (which will redirect you to https://drive.google.com/drive/u/0/my-drive)
3. when authorizing StackEdit, I get the error "Google account ID not expected'

Opened #1470.

I tried this again and it now works. The solution was 1/2:

I was logged in on the wrong google apps account (my private one)
I logged in on stackedit.io and setup authentication there.

Solved.Thanks a lot.


IB/RoCE v1 support

When performing RDMA communication testing on an IB protocol machine, the following error occurred：

Currently only RoCE v2 protocol communication is supported？(I found that when doing gidx acquisition in the code, IBV_GID_TYPE_ROCE_V2 was hardcoded). How can I solve this problem?

current my test env is only RoCE v2,  can you help with this?

current my test env is only RoCE v2, can you help with this?

By making some hard-coded changes to the code and recompiling the .so , it was able to establish a link on the IB/RoCE V1 protocol. However, when testing RDMA writes, the following error occurred:

As shown in the figure, the status of ibv_wc is 12 (IBV_WC_RETRY_EXC_ERR) , and I also found that the libirdma-rdmav25.so is missing. I am not very familiar with RDMA programming and hope to get some help. (The service and client are deployed in two containers)

current my test env is only RoCE v2, can you help with this?

By making some hard-coded changes to the code and recompiling the .so , it was able to establish a link on the IB/RoCE V1 protocol. However, when testing RDMA writes, the following error occurred:

As shown in the figure, the status of ibv_wc is 12 (IBV_WC_RETRY_EXC_ERR) , and I also found that the libirdma-rdmav25.so is missing. I am not very familiar with RDMA programming and hope to get some help. (The service and client are deployed in two containers)

can you try the latest the version? it should support IB now. Starting the server with --link-type IB

current my test env is only RoCE v2, can you help with this?

By making some hard-coded changes to the code and recompiling the .so , it was able to establish a link on the IB/RoCE V1 protocol. However, when testing RDMA writes, the following error occurred:

As shown in the figure, the status of ibv_wc is 12 (IBV_WC_RETRY_EXC_ERR) , and I also found that the libirdma-rdmav25.so is missing. I am not very familiar with RDMA programming and hope to get some help. (The service and client are deployed in two containers)

can you try the latest the version? it should support IB now. Starting the server with --link-type IB

I have tested the IB communication function and encountered the following error when destroying the connection.

current my test env is only RoCE v2, can you help with this?

By making some hard-coded changes to the code and recompiling the .so , it was able to establish a link on the IB/RoCE V1 protocol. However, when testing RDMA writes, the following error occurred:

As shown in the figure, the status of ibv_wc is 12 (IBV_WC_RETRY_EXC_ERR) , and I also found that the libirdma-rdmav25.so is missing. I am not very familiar with RDMA programming and hope to get some help. (The service and client are deployed in two containers)

can you try the latest the version? it should support IB now. Starting the server with --link-type IB

I have tested the IB communication function and encountered the following error when destroying the connection.

I have solved this problem by updating the following packages (I think this problem is caused by the old version of the package I used before)

libuv1-dev
libgtest-dev
libmsgpack-dev
libspdlog-dev
libfmt-dev
ibverbs-utils
libibverbs-dev


[Identity] Update the identity - beta 1 version

Packages impacted by this PR
Identity
TODO:

[x] uPDATE CHANGELOG
[x] the string in the identityClient.ts

/check-enforcer evaluate


bug error path

Fix error message if str path does not exist

Looks good to me but I'd add a test that would have failed before and now works just to check that everything is actually solved


demo: Added mDNS services broadcasting for CoAP and Http

Hi,
Leshan could announce its services via mDNS broadcasting for automatic discovery, especially on IPv6 networks.
Use-case :
Each leshan clients can automatically discover leshans instances on the same local network.

I checked for IP issue. The version 3.4.1 are approved by eclipse.
If needed I can ask for the 3.5.1 version or we just use the 3.4.1 version.
So step 1) is ok.

I've changed pom.xml to fetch jmdns dependency from maven central

Ok sounds good, I need to open IP issue for jmdns 3.5.1.
You need to accept Eclipse Contributor Agreement and ideally signed-off your commit. (see contributon guide for more details)
Sry about all this paperworks ...

Ok, great !
I've signed the ECA, so a GPG signed commit will suffice ?

No need to GPG signed commit, the "Signed-off-by:" is enough.
If you could squash all your commits in one, then rebase it on master this will be perfect :)

I create the CQ : https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13821

The CQ was approved.
So I integrated this PR in master (squashed commit : 8c653036fcb43793ec3fdf68a2cc22d89665745d)


In app web views added

Motivation
Based on feedback from the sprint review, we have changed the links to open in app, along with the alert service, it now links to documentation in app.
Verify

Remove the service objects
Start App
On the home page click the aerogear link (link should open in app)
On any of the under construction, pages click the aerogear link (link should open in app)
Navigate to Authentication a dialog will be shown click on Show Documentation
Navigate to Push Messages a dialog will be shown click on Show Documentation

@wei-lee mind having another look when you get a chance.

@ciaranRoche Do we need to update some of these https://github.com/aerogear/cordova-showcase-template/blob/master/src/app/app.component.ts#L51 for the documentation buttons in the navmenu to work?


Java Troubleshooting Tutorial: OutOfMemoryError

Write a short tutorial on Java's OutOfMemoryError error message, following the "How to troubleshoot Python ZeroDivisionError" example tutorial.
The tutorial should be organized as follows:
---
title: How to troubleshoot Java OutOfMemoryError
author: your name
tags: [tutorial, Java, troubleshooting]
publicationDate: today's date
description: Learn how to error handle the Java OutOfMemoryError
image: https://storage.googleapis.com/sourcegraph-assets/learn/headers/sourcegraph-learn-header.png
imageAlt: Sourcegraph Learn
browserTitle: OutOfMemoryError in Java error handling
type: posts
---

Introduction with the error message

## Reproducing the error

Show how the error can be created.

## Solution 1

Provide a possible solution.

## Solution 2

Provide another solution.

## (optional) Solution 3

Optionally provide a third solution.

## Learn more

Search across open source Java repositories that have the `OutOfMemoryError` to understand the message more.

<SourcegraphSearch query="OutOfMemoryError lang:java" patternType="literal"/>

Check out more Sourcegraph Learn tutorials on [Java](https://learn.sourcegraph.com/tags/java).

If this seems like a tutorial that you can write effectively for the developer community, please follow our Hacktoberfest 2021 contributor guidelines to proceed.

Hi! I think maybe I could do this one, if that's ok? :)


Update flowser linux support

Description
Updates Flowser to v3.1.2: https://pkg.go.dev/github.com/onflowser/flowser/v3/pkg/flowser
Also updated some code to enable Linux support, since Flowser can now be run on Linux systems.

For contributor use:

[x] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[ ] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9c67ee) 41.19% compared to head (0fedaa5) 41.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1272   +/-   ##
=======================================
  Coverage   41.19%   41.19%
=======================================
  Files          39       39
  Lines        2068     2068
=======================================
  Hits          852      852
  Misses       1123     1123
  Partials       93       93

Flag
Coverage Δ

unittests
41.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fixed incorrect type display of void returned function in GDScript editor tooltips

Fix #63019

Needs rebase to fix CI due to a temporary godot-cpp issue.

Needs rebase to fix CI due to a temporary godot-cpp issue.

Rebased to fix CI issue

Thanks!


[1.9.0-rc1] Cancelling a build leaves artifacts in /tmp

When cancelling a build in progress, /tmp is littered with trusted-dockerfile-465530198
I've also seen it with build-context though I can't seem to reproduce that right now.
I assume this is the client dropping the file there.
This does not seem to happen on the OSX client for some reason... unless it's writing to a different tmp dir (which should be /private/tmp, which is what /tmp is pointing to).

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I can reproduce and can confirm this is drop by client since the client doesn't deal with ctrl-c when cancel the build

We decided with @tiborvass that this is not critical for 1.9. I removed it from the milestone.

Temp files in /tmp are ok and will be removed by the host, it's fine to have these in there.


Updates to allow insert at cursor position

Insert Content at Cursor position
import MonacoEditor and also supply at providers (eg: on app.module.ts):
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';

import { AppComponent } from './app.component';
import { MonacoEditorModule, MonacoEditor } from 'ngx-monaco-editor';

@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    MonacoEditorModule
  ],
  providers: [MonacoEditor],
  bootstrap: [AppComponent]
})
export class AppModule {
}

import MonacoEditor and define at constructor (eg: on app.component.ts):
import { Component } from '@angular/core';
import { MonacoEditor } from 'ngx-monaco-editor';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html'
})
export class AppComponent {
  editorOptions = {theme: 'vs-dark', language: 'javascript'};
  code: string= 'function x() {\nconsole.log("Hello world!");\n}';

  onInsertContentClick() {
    this.monacoEditor.insert('
This is the default content
');
  }

  constructor(
    private monacoEditor: MonacoEditor
  ) { }
}

I Have looked at your solution but not sure will it work with multiple editors in same page. As you have expose editor instance to an variable outside class. it will overridden by the last initialised editor and all further operations will be performed on that editor instance only. We need to test it with multiple editors before merging.
Alternatively i have exposed editor instance you can check if that solves your purpose that will help us to keep the custom code out of this module as this is just an wrapper for monaco-editor. Hope that will help.

sure thing. exposed editor instance worked with charm.! 👍


E2E: go push main SLSA3 config-noldflags

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2388540746
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Thu May 26 03:53:27 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2394468881
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Fri May 27 03:54:38 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2399837628
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Sat May 28 03:52:13 UTC 2022
Tests are passing now. Closing this issue.


Semver Range Support?

What's a "semver range?"

A version range is a set of comparators which specify versions that satisfy the range.
https://github.com/npm/node-semver#ranges
https://gist.github.com/FichteFoll/a93e064468a6d9b14ea2

Already thought about that a while ago. There may be some interesting use cases and we could also build a command line utility like node-semver does. Sadly, i don't have time for this right now, maybe in 1-2 month

@blang I will play with it little bit over weekend and send pull if it will result in something useful.
I would appreciate if you could send me some pointers or links to similar implementations.

I would take a look at the node.js implementation (linked above) but i would not make a cli out of it.
The scenario: Your app get "2.0.1" as a string and you need to check if its >=2.0.0 and <3.0.0.
Node's implementation has a bnf grammar which describes the possible comparators: https://github.com/npm/node-semver/blob/master/range.bnf
They use regex all over but i would love to stick to a manual parser which might be not that trivial.

Implemented in https://github.com/blang/semver/commit/aea32c919a18e5ef4537bbd283ff29594b1b0165

Thank you!


Rule: trailing blankline

@bhirsz What's the difference between this and #86 ?

It appears to be mistake on my part. I could have some extra thoughs and it was designed to check something else but I don't remember know - I will remove this issue


feat: empty portfolio allow to receive without an asset selected

Description

Needed a way to receive an asset without one selected
Added empty account list
Fixed some key warnings

Notice
Before submitting a pull request, please make sure you have answered the following:

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Do all new and existing tests pass? Does the linter pass?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
If applicable, please link to the github issue and put closes #XXXX in your comment to auto-close the issue that your PR fixes.
Testing
Please outline all testing steps

Pull branch locally and run yarn to install new deps
etc...

Screenshots (if applicable

)

tested and this look fuckin rad we should merge today


When a version is selected, show even servers for older versions with a comment about the latest supported version

Currently, if MP version is selected, only servers that support it are available for selection. To show all MP implementations, it's necessary to select the oldest MP version. Even then it's not visible which latest version of MP these servers support.
I suggest that all servers are available for selection, with the following conditions

servers that don't support the latest version are sorted after those that do, descending by the latest supported version, which is lower than the selected version
servers that don't support the latest version have the latest supported version, which is lower than the selected one, in brackets
when a server doesn't support the latest version is selected, the MP version field is set to the version in brackets (the latest version it supports, which is lower than the selected version)

It would look like this for v2.1:

In case of version 1.4 selected, the options in the select box would be:

OpenLIberty
KumuluzEE
TomEE _- here, TomEE supports 1.4, so displayed equal to all others that support it
Payara Micro
Thorntail V2 (MP 1.3)  _- here, Thorntail supports 2.0 but not 1.4, so only 1.3 displayed _
WildFly Swarm (MP 1.2)
Helidon (MP 1.2)

This solvers 2 issues

gives visibility to all implementations immediately, without forcing people to know which MP versions their favorite server implements
enables to select the latest MP version by default in the version field so that it's easier to use the starter
the form can show the list of all servers immediately, not only after an MP version field is selected (currently, the server field is disabled until a version is selected) - easily gives an overview of possible servers and there's less magic in choosing a server that matches a specific version

This also works well with #76

Isn't that overly complicating the UI?
Is the starter the appropriate place to be guiding people as to all the MP versions and which implementations support which?
Isn't it easier to just link out to https://wiki.eclipse.org/MicroProfile/Implementation ?

-1 on this one, it seems it clutters the UI to me
How about adding a link to the wiki directly next to the dropdown Selection UI element?
@rstjames WDYT from web frontend POV?

-1 The MP Version dropdown should act as filter. Thus no versions other than the selected should be visible.

Out of Date


Events not properly detached. Its eating lot of memory. I need the solution.

#Events not properly detached. Its eating lot of memory. I need the solution.Please check this

Any update

Duplicate of https://github.com/select2/select2/issues/4725.

@kevin-brown Did you ever find a solution or root cause the problem?


Keep some record the network.

Environment
All
Expected behavior
We should be able to trace network growth and flow
Actual behavior
All nodes in the network just pop up independently. We don't store who added who to the network.
Steps to reproduce the behavior
Share the bot, when the recipient starts using the bot there won't be a record who shared it with you.

Implementation plan

From #30

We shall add a ref to the bot link the ref value shall be the referrer's Rapidpro contact ID.
Basically we shall have the URL here https://github.com/goodbotai/karma/blob/master/karma.js#L389 be http://m.me/1504460956262236?ref=
When a user clicks this referral link we will store the ID of the user who referred them in their rapidpro contact.


Add a complete comment system for minima

Hello, developers!👋This is my first PR.
Problem.
Minima has less comment system.And disqus has been deprecated.
How to realize it?
I changed three places.

Added  /includes/comments.html,Delete /includes/disqus_comments.html.
Added comment settings in _config.yml.
Changed comment part in _layouts/post.html.

At last
After my changes.Now Giscus,Utterance and Disqus are available now.
I tested it successfully on my blog.
And that's all.Thanks😀

Hello @YURLAK,
First of all, welcome to the world of Open Source Softwares.
Regarding your pull request, I love the idea but would like to leave some feedback nevertheless:

I would prefer not to reserve a top-level config key for this to avoid conflicts on existing sites. Therefore, I'd prefer {{ site.minima.comments.[NEW_KEY] }} instead of the current {{ site.[NEW_KEY] }}.
We no longer build the demo site using the master branch. So, adding the config details to _config.yml is not only redundant but additional information to delete for users forking the repository. I suggest you move all the comment configuration to the README document.
For readability reasons, it's better that you wrap the attributes of the HTML script tags.
Lastly, I think you forgot to include the original Disqus code into the new include file.

Hello @YURLAK, First of all, welcome to the world of Open Source Softwares.
Regarding your pull request, I love the idea but would like to leave some feedback nevertheless:

I would prefer not to reserve a top-level config key for this to avoid conflicts on existing sites. Therefore, I'd prefer {{ site.minima.comments.[NEW_KEY] }} instead of the current {{ site.[NEW_KEY] }}.
We no longer build the demo site using the master branch. So, adding the config details to _config.yml is not only redundant but additional information to delete for users forking the repository. I suggest you comment out all the comment configuration or move it to the README document.
For readability reasons, it's better that you wrap the attributes of the HTML script tags.
Lastly, I think you forgot to include the original Disqus code into the new include file.

<EMAIL_ADDRESS>for your feedback!According to your feedback,I made some changes.

@YURLAK I thought about this bit more. Continuing from previous feedback:

Comments are not handled by Jekyll itself so no point in having it as a top-level config key.
Let's use {{ site.minima.comments }} instead.
Rendering comments during development is not desired as it creates unnecessary discussions on Disqus. Perhaps, the same is true for Giscus and Utterances. Either ways, render comments only in "production".
The script rendered is easily accessible on provider's website. Therefore, we can avoid performance issues on larger sites by recommending users to copy from provider site (or our README) and hardcode user details as needed. We just provide a means to render desired provider script.
Additionally, provide a means to disable comments entirely for desired posts (via page.comments).
No built-in comment support to reduce coupling to third-party code.

So, our _layouts/post.html will have something like:
{% if jekyll.environment == "production" %}
  {% unless page.comments == "disabled" %}
    {% assign comments_provider == site.minima.comments_provider %}
    {% if comments_provider %}
      {% capture provider_filepath %}comments/{{ comments_provider }}.html{% endcapture %}
      {% include {{ provider_filepath }} %}
    {% endif %}
  {% endunless %}
{% endif %}

Then, we document what users need to do, in our README along with the note that build will fail if user does not provide associated include file.


Feature/1.0

1.0 version update

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2f30f13). Click here to learn what that means.
The diff coverage is 94.78%.

@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage          ?   95.95%
=========================================
  Files             ?      101
  Lines             ?     3564
  Branches          ?        0
=========================================
  Hits              ?     3420
  Misses            ?      115
  Partials          ?       29

Impacted Files
Coverage Δ

...tLib/Debugger/WebLog/Protocol/WebConsoleOutputs.cs
100% <ø> (ø)

CatLib.VS/CatLib/Hashing/Hashing.cs
100% <100%> (ø)

CatLib.VS/CatLib/CatLib/Application.cs
95.57% <100%> (ø)

CatLib.VS/CatLib/Routing/Router.cs
99.29% <100%> (ø)

CatLib.VS/CatLib/Hashing/Checksum/Crc32.cs
100% <100%> (ø)

CatLib.VS/CatLib/FileSystem/FileSystemProvider.cs
95% <100%> (ø)

CatLib.VS/CatLib/Config/ConfigProvider.cs
92.85% <100%> (ø)

...atLib.VS/CatLib/Translation/TranslationProvider.cs
100% <100%> (ø)

CatLib.VS/CatLib/Routing/RoutingProvider.cs
97.43% <100%> (ø)

CatLib.VS/CatLib/Hashing/HashString/DjbHash.cs
100% <100%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f30f13...02b7977. Read the comment docs.