"SELECT 1;;" means (rc *SQLiteRows) Next() enters an infinite loop (SQLITE_MISUSE)

Spotted by https://github.com/rqlite/rqlite/issues/1250
Apply the diff below, execute time go test -run TestQueryer and it will never return. Without the diff the test it runs fine, and exits normally. From instrumenting my own code (rqlite) it seems rows.Next() never returns an error. Should the code be more robust against this, or am I doing something wrong?
$ git diff
diff --git a/sqlite3_test.go b/sqlite3_test.go
index 326361e..df317f2 100644
--- a/sqlite3_test.go
+++ b/sqlite3_test.go
@@ -1114,9 +1114,7 @@ func TestQueryer(t *testing.T) {
        if err != nil {
                t.Error("Failed to call db.Exec:", err)
        }
-       rows, err := db.Query(`
-               select id from foo order by id;
-       `)
+       rows, err := db.Query(`SELECT 1;;`)
        if err != nil {
                t.Error("Failed to call db.Query:", err)
        }

Digging into this I see rv := C._sqlite3_step_internal(rc.s.s) return (21) SQLITE_MISUSE which sends the code down the if rv != C.SQLITE_ROW branch. Then it calls rv = C.sqlite3_reset(rc.s.s) which returns (0) SQLITE_OK. And then nil is returned by Next().
According to the SQLite docs, getting (21) SQLITE_MISUSE is bad.

If SQLite ever returns SQLITE_MISUSE from any interface, that means that the application is incorrectly coded and needs to be fixed. Do not ship an application that sometimes returns SQLITE_MISUSE from a standard SQLite interface because that application contains potentially serious bugs.

Does db.Query(SELECT 1;;) violate the API for go-sqlite3? If so, how?

This is the same underlying issue as discussed in #950 and #1133. Namely, this library is not using sqlite3_prepare_v2 correctly.

Dupe of https://github.com/mattn/go-sqlite3/issues/950

OK, thanks. So is there a reason #950 isn't fixed? You seem to have identified the issue, but it's not clear if it's much more difficult to fix that it seems.

I can patch my copy of this fork, but it's just rather unfortunate that a simple string can bring down such an important library as this one.

Because I have not had the time to deal with it. Feel free to raise a PR and I'll take a look.

OK, let me see what I can do.

Currently is there a way to detect this? Encountered the same issue when executing malformed empty SQL


Separate Requirement Files

This should speed up lint workflows where dependencies are not needed and test workflows where linting is not required.

Can you keep all the files in the top-level dir?

Yes we could, but it will get messy if we think about future workflows.

Can you keep all the files in the top-level dir?

Yes we could, but it will get messy if we think about future workflows.

The idea is from here: https://github.com/pallets/flask/tree/main/requirements

Well I think so, but let me check again.

Well I think so, but let me check again.

https://github.com/dependabot/dependabot-core/issues/1200
I guess it will work


Added additional parameter to configure social sharing icons above and under posts

Added param socialsharing to enable and disable socialsharing icons.

How do you activate search? Any search form on the site?
I don't think that sidebar social icons have been fully implemented.

I thougt that I had read that Hugo has in memory indexing for search, but i can't find it in gohugo docs.
What is bmc and ko-fi?

If you have url in search-index.md and not type = page it will not be created.
I added this to the file:
´´´
draft = false
type = "page"
´´´
I don't understand the purpose of this file. I think it's better to have a lunr.js script and a search box somewhere.

I found the  showSearchInSidebar = true
The search-index.md file creates a index.json that contains the index.html file.
I removed the search-index.md and run npm run index which generated the lunr.json in /public. Then I renamed it to index.json.
This is the result:
https://screenshots.firefox.com/xqL9y9pBSE5cCJHh/localhost
Something strange going on..

I worked a little on the stuff after sending the pull request.
For search some stuff in config.toml needs set to generate json.
The box should show the search hits.
Let me finish the stuff and create documentation, hope I'm finished after your vacation.

When I forked the theme, flattr or any other social icons in the sidebar was not fully implemented.

The lunr.js error could be because the index.json contains the wrong content.

I use the theme on stoeps.de and search works.

The social icons I use are implemented, not sure about flattr in the moment.

I checked your site and your json file is a bit different. You have ref instead of uri.
I tried to change the uri to ref in index.json and it worked.
https://screenshots.firefox.com/Cm3odttxzNftXBnY/localhost
You should change the name of the json to lunr.json in the js script. Then it will not be overwritten and you only have to add the search flag in config then:
If you not have lunr:
npm init
npm install hugo-lunr
Add to package json in the script section:
"index": "hugo-lunr"
Then run:
Hugo
npm run index
Then you can check the result:
cd /public
python -m SimpleHTTPServer

It's probably better to change the js code to uri instead of ref, because the hugo-lunr script generates the josn with uri.

No changes needed! Or do you mean for lunrjs > 2.0?
Here the way I use it:
Added lunrjs search
Add to config.toml:
[outputs]
  home = [ "HTML", "RSS", "JSON" ]
  post = [ "HTML" ]

[params]
  showSearchInSidebar = true

Create search-index.md in your content folder.
---
date: 2016-07-15T13:55:09+02:00
type: "json"
url: "index.json"
----

Output of JSON is generated from layouts/json/single.html.
Now Hugo generates the index.json file used with your page.

Nope, npm is not necessary.
Just add the code above and hugo does the index generation.

But you have to install lunr localy?

Probably some documentation missing on gohugo about search.

No. Lunr is integrated through CDN in layouts/partials/base/imports.html

I mean for building the lunr.json file. There is nothing in the gohugo docs that indicates that Hugo builds a search index only that you can install lunr and generate a json.  I have read about it somewhere else but can't remeber where.

I read first of it here:
https://discourse.gohugo.io/t/search-index-json-file-for-lunr-js/6286/23
And one of the links showed most of the JS Code. I justed added the link a href= and repaired some typos.
I like the way Hugo builds the index, don't wanna have npm or other requirements on top.
Working on migrating to lunr 2.3...

I also added:
[outputs]
home = [ "HTML", "RSS", "JSON" ]
post = [ "HTML" ]
And put back the search-index.md. And it will build a index.json containing the html code for the index.html. Strange. I am using v0.44

I use 0.42.2, I had the html code in index.json too, but I thought it changed after adding the outputs section.
Do you have layouts/json/single.html in your theme folder?

Just checking

Yes:
´´´
{{- $.Scratch.Add "index" slice -}} {{- range where .Site.Pages "Type" "not in" (slice "page" "json") -}} {{- $.Scratch.Add "index" (dict "title" .Title "ref" .Permalink "tags" .Params.tags "content" .Plain) -}} {{- end -}} {{- $.Scratch.Get "index" | jsonify -}}
´´´

I just used this https://discourse.gohugo.io/t/search-index-json-file-for-lunr-js/6286/7

I updated to 0.44 and get a index.json with real json content.

Fix the search-index.md add info in the README and I will merge this PR. Maybe it works for most of the users. Could be some Hugo glitch on Ubuntu 16.04 maybe.

I replaced a lot now and I'm not sure if my changes fit for everyone. So ignore my pull request please.

Ok! Nice work anyway. I will checkout your repo at a later time!


changed dependencies to guzzle library

Also updated the FOSHTTPCacheBundle to the latest version
Fixes the error messages while doing a composer install or update.

@danrot ready for merge?

Yeah, it worked for me.


Online community

I came across this tutorial a few weeks ago and it has been very helpful.
My problem though is that I was wondering if there is an online community to complement this.

What did you have in mind? I don't think Ken and I were thinking of turning this into dev.to, or creating a large brand behind it. We were excited about creating approachable content and happy that people are coming across it and learning from it.

Okay. I actually thought it was sort of an online bootcamp.
I love it nonetheless.
Thank you.
On Sun, Apr 21, 2019, 4:00 AM msftbot[bot]<EMAIL_ADDRESS>wrote:

This issue has been automatically marked as stale because it has been
marked as requiring author feedback but has not had any activity for 4
days. It will be closed if no further activity occurs within 3 days of
this comment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/frontend-bootcamp/issues/122#issuecomment-485220543,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGAA3ETHXNANGLA5PSGYG2TPRPKFNANCNFSM4HEHF34Q
.


[error] Mounting XXXXXX failed while verifying session with: :invalid

Started getting this error after the Tesla network was down last night.  The message is showing every 10 seconds.

Hi,
I've got the same.

Nothing to worry about:

The session error can be resolved by reloading the browser tab with the TeslaMate web interface that was opened before restarting. (To never see that error again set both env vars SECRET_KEY_BASE and SIGNING_SALT)

(https://github.com/adriankumpf/teslamate/issues/130#issuecomment-527166057)


Display AOVs rework

This patch introduces the following changes when rendering in non-tiled mode. It requires this Cycles PR.

Aov's render buffers are now updated once a rendering pass has finished through the new callback
Blitting render buffers now does a single copy rather than 2 and is not tied to RenderPass::_Execute anymore.
Misc improvements to HdRenderBuffer.

Memory is actually deallocated on deallocate and shrunk on resize
Access is now synchronized with resize / delete operations
Better lifetime management with the renderparam through BPrim::Finalize

Picking and viewport overlays are also working now by slightly relaxing GetSourceName

One Issue is that on extremely simple scenes you can notice that the first frame displayed is lower resolution than typically. My intuition is that it is because  blitting to the HdRenderBuffer happens exclusively with rendering and at the same time requires locking access to the Cycles Render Buffers. This hypothesis is (just partly) sustained by one performance metric. The new blitting code path is substantially faster than the one going through the device tasks, even if not fully optimized (the old code path only blitted one):

Function
Time

copy_to_display_buffer (Old)
0.03 +- 0.001 s

on_display_cb               (New)
0.001 +- 0.0005 s

The tiled and adaptive code path could be further unified together, this is a first step.
Houdini grid overlay (closes #111)

Picking

Viewport AOVs

Thinking about it, the fact that we see a lower resolution frame earlier should mean that it's more responsive.

 It does get slower the more AOVs you load in but that's definitely to be expected, it feels fast enough with Houdini's default color+depth+normal loaded in though and we can be mindful of making custom viewport settings which don't load all AOVs at once in the default case...
My little patch tweak uses ccl::PASS_DEPTH instead of ccl::PASS_MIST and we discovered it wasn't quite what Hydra expects and has a weird default of the depth value set to 100.0f instead of 1.0f (which threw off the camera tumble code in the viewport, which must use depth for camera calculations).
Awesome work @dedoardo !

Just an update, the depth seems to work on windows but I am not sure why linux doesn't seem to work quite right yet...

Thanks for reviewing @skwerner, ran clang-format and changed the scoped lock.

Hey I've got a screenshot of the latest patch here side by side windows vs linux, not sure why the grid doesn't get culled on the linux side (visually the AOVs are being made when I toggle depth/normal so they do exist and are working):

After the discussion today I am merging this for now and keeping #111 alive, making it linux specific


Physx 3.4

PhysX 3.4 support

I tested this PR with the today's cmake change and the current PhysX 3.4 repo in VS2015 x64. The install projects copied all needed dlls. The engine built and executed without any problems.


Shared virtual environment cannot install

Current Behavior
When installing the root directory to provide the shared virtual environment, poetry complains because I don't have an actuall root module to install (the root directory doesn't have any actual code)

The Nx workspace is named ohm in my failure logs

I believe the missing piece would be to add --no-root as a flag to the install for the shared virtual environment. Perhaps this can be an optional config somehow
Expected Behavior
Install of virtual environment should work without error.
Steps to Reproduce
Set up a shared virtual environment without any [tool.poetry.packages] entry in the root pyproject.toml
Nx Report
>  NX   Report complete - copy this into the issue template

   Node   : 16.20.2
   OS     : linux-arm64
   npm    : 8.19.4

   nx                 : 16.7.4
   @nx/js             : 16.7.4
   @nx/jest           : 16.7.4
   @nx/linter         : 16.7.4
   @nx/workspace      : 16.7.4
   @nx/cypress        : 16.7.4
   @nx/devkit         : 16.7.4
   @nx/eslint-plugin  : 16.7.4
   @nx/plugin         : 16.7.4
   @nx/react          : 16.7.4
   @nx/storybook      : 16.7.4
   @nrwl/tao          : 16.7.4
   @nx/web            : 16.7.4
   @nx/webpack        : 16.7.4
   nx-cloud           : 16.3.0
   typescript         : 5.1.6
   ---------------------------------------
   Community plugins:
   @nxlv/python : 16.1.2
   nx-stylelint : 15.0.0
   ---------------------------------------
   Local workspace plugins:
         @ohm/nx-helpers

Failure Logs
UPDATE pyproject.toml
  Updating root poetry.lock...
Resolving dependencies... (5.1s)

Writing lock file
Running command: poetry install

Installing dependencies from lock file

No dependencies to install or update

Installing the current project: ohm (1.0.0)
The current project could not be installed: No file/folder found for package ohm
If you do not want to install the current project use --no-root

  poetry.lock updated.

Additional Information
No response

BTW I am able to generate successfully if I modify the poetry-project/generator:updateRootPoetryLock locally and add the --no-root flag to the install command

Hey @kylebjordahl sorry for the delay, I've been pretty busy lately, so, I tried to reproduce it locally using the Nx version you provided in the logs and it's working fine.
I'm using poetry version 1.5.1, which Poetry version are you using?

Hi @lucasvieirasilva, sorry for the huge delay, days after I opened this issue we my daughter was born and I have had zero time to follow up.
Just today I discovered that there is a poetry setting which can solve this, so this issue can be safely closed.

Hey @kylebjordahl no problems, this is much more important than this issue, congrats, I wish you all the best!

Thanks!


Suport new base36 format, Improve unwieldy logic

The 0.6.0 version of go-ipfs introduces base36 cids, so It'd be good if we can get ahead of any issues that might occur when (if) this becomes the default and support it right out of the gate. The logic with the existing single if statement was rapidly getting out of hand and foreseeably was going to get worse over time given the amount of format changes cids are undergoing,; So it required a small refactor to make it neater & easier to add new cases.
e.g. base36 cid k51qzi5uqu5dj16qyiq0tajolkojyl9qdkr254920wxv7ghtuwcz593tp69z9m

Sorry @phillmac it's taken so long to get to this. It look good to me :+1:
Thank you! 🙏

Should we publish a patch release on 0.24?

Sorry @phillmac it's taken so long to get to this. It look good to me
Np there was no rush :grin:

Should we publish a patch release on 0.24?
Only if someone needs base36 cids support urgently. I've not even heard a peep outta anyone needing this yet. I just remember we got blindsided with base32 cids last time and I thought It'd be good if we could jump on this before it turns into a problem.
In any case if we intend to publish 0.25 in the next few months I think that'll be fine.


[Task] Add support for Timestamp data type in Prepared Statement

SubTasks

Introduce missing data types for all databases

This has been fixed and merged into master.


/etc/hosts sometimes doesn't get cleaned up on reconfigure/destroy

investigation is needed on how to reproduce it

I would like to change the way we are doing this.
I'd basically like to add a header and a footer comment to the blob we are adding containing the entries like
###### CLAB-<deploymentname>-START ######
<HOSTS ENTRIES>
###### CLAB-<deploymentname>-END ######

On deletion I'd like to search for these comments and delete them along with the content inbetween.

I haven't seen this for a while now, will close this and reopen if this will surface again


Bump circe to 0.9.0-M1

so there are no conflicts regarding the cats version in github4s

Thanks! :+1:


⚠ ClamAV has degraded performance

In d08ccab, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 2df3048.


🐛 Local image dont display in reading view in mobile

In mobile, local image like [[image.jpg]] only display in live preview and not in reading view.
URL display in both modes in mobile.
Desktop version, both modes display correct.

thank you, I will take a look

I can't seem to reproduce your issue.
Can you make sure you're on the latest version of the plugin.  If you still have the issue can you create a sample vault that recreates the issue and share it please.
Feel free  to join the community and discuss the issue on our Discord as well:
https://discord.gg/sp8AQQhMJ7

I am only in mobile now and in a new vault the problem dont happen. Sorry for inconvenience.
Closing the issue.
Found the problem. The custom css i use for chance the background.
.homepage.markdown-preview-view{

    background-color: rgb(249, 250, 251);
}
.homepage.markdown-source-view{

    background-color: rgb(249, 250, 251);
}

The image is in a zindex behind probably.

@samaellain I am glad you were able to track down the issue.
Let me know if you have any other problems.
have a great day!


feature request: make hopper under stone_mortar transfer only processed items

sakura version: 1.0.7-1.12.2
The stone mortar outputs ingredients first, then outputs processed items.
I thought this should output only processed ones, like minecraft:furnace.
built structure:
*
\C

(* is sakura:stone_mortar, \ is minecraft:hopper that connecting C, and C is minecraft:chest)

1.18.2 version will do.

could it implemented also for 1.12.2 one?
I'm not sure whether 1.12.2  branch is still supported and accepts PRs if there's any.

no, I can't code for 1.12.2 now.
sorry.

@0999312

no, I can't code for 1.12.2 now.
sorry.

nvm

I'm not sure whether 1.12.2 branch is still supported

I'd like to confirm that 1.12.2 branch isn't in end-of-life because I'd like to submit a PR that backport it to 1.12.2 one. If you say "this mod for 1.12.2 will not update anymore," I will not submit it.

@0999312
well, so, can I submit PR to 1.12 branch to backport this behavior?

sure


Make pakage dnn-proxy-caffe for integration with crowdsource-video-experiments-on-desktop

Extract all lib-dependent code into separate package, which will be compiled into so-file (or dll) and will have well-known set of exported function - preparation model, parallel recognition etc. The app could find this proxy lib via CK, load and do real work through it. Such proxy-lib should be depend only on required things and hide any lib-specific stuff from the desktop app.

Please note that similar proxy libs will be required for CK-TensorFlow, CK-TensorRT, etc.

We decided not to use this method for now but use caffe-classification binaries directly. However, we are not removing this method completely but archived it because it can be very useful for realistic applications. But for trying different libs (caffe-cpu,caffe-opencl,caffe-cuda), it requires lots of API gluing ... But thanks a lot for the first version - it was very useful! I close this ticket!


Can't keep replacement of html comments

Hello!
How can I keep replacement of the html comments?
I have tried several options like <!-->, <!--...-->, <!--comment-->, comment but still doesn't work anything :(
Does the turndown supports it?
Thanks a lot.

HTML comments are currently removed, but it looks like the commonmark standard supports them, so this should be a feature. Thanks!

+1 for this

This would be especially useful when converting WordPress posts from HTML to Markdown, as the  tag is used to mark the place where post should be cut. One can work around it with string replacement before and after, but native handling would be awesome.


How do you start a project from scratch?

Are there docs for using zappa init without an existing python project?

error
i am in virtualenv
zappa init
Oh no! An error occurred! :(
==============
Traceback (most recent call last):
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\zappa\cli.py", line 2610, in handle
sys.exit(cli.handle())
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\zappa\cli.py", line 476, in handle
self.init()
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\zappa\cli.py", line 1504, in init
\u255a\u2550\u2550\u2550\u2550\u2550\u2550\u255d\u255a\u2550\u255d  \u255a\u2550\u255d\u255a\u2550\u255d     \u255a\u2550\u255d     \u255a\u2550\u255d  \u255a\u2550\u255d\n""", fg='green', bold=True))
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\click\utils.py", line 259, in echo
file.write(message)
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\colorama\ansitowin32.py", line 40, in write
self.__convertor.write(text)
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\colorama\ansitowin32.py", line 141, in write
self.write_and_convert(text)
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\colorama\ansitowin32.py", line 169, in write_and_convert
self.write_plain_text(text, cursor, len(text))
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\site-packages\colorama\ansitowin32.py", line 174, in write_plain_text
self.wrapped.write(text[start:end])
File "c:\users\toshiba.virtualenvs\lambda-hello-world-wti7vn7p\lib\encodings\cp1252.py", line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 2-9: character maps to

Maybe the cookie cutter examples from this repo would be helpful?

I don't understand why you wouldn't want zappa to work out of the box. It's not like it requires any effort. I've already written a pull request.
What would be the downside to making it easier to create a hello world app? Why arbitrarily restrict the functionality of Zappa, and reject working code that has already been written?

Hi. I don't consider it an arbitrary decision. We try to be careful about limiting the scope of Zappa, as every line of code adds cost (in this case, cost is time to maintain), and I think this kind of addition is out of scope.
Additionally, the pull request is not usable as-is:

there's an empty execution branch for django
the flask branch has a stray print
the other notification print line should probably be a click.echo to follow with the rest of how this code works
installing flask into the user's virtualenv is even further out of scope for Zappa
and there are a bunch of comments that should be discussion, not code

…so there is work required, even if we did want to include this, which I don't believe we do.
To me, this is no different from installing a django-related package and being surprised that it didn't run django-admin startproject … for you. This shouldn't be expected.
There is, however, some discussion around detecting that the app_function is incorrect, and better handling of broken deployments, so failing all else, this will at least report that your deployment failed.

Reopening for more discussion.
There is a use case for this that hasn't been considered: building a purely event driven application. More than once I've had the need to have functions execute in response to AWS events, and it is weird to write the event handler before the init.
I would like init to be able to handle this use case. However, handling this use case naturally opens the door to bootstrapping a web application as well.. :[

Could we point users to example cookie cutter projects as a solution here? It seems like zappa init is sort of providing the same functionality?


Poulating the MapElements list after layer creation

If you plan to add more elements to the MapElements property after it is attached to the layer use:
IList<MapElement> mapElements = new  ObservableCollection<MapElement>();
instead of:
new List<MapElements>();
like all the examples show. Otherwise the new elements won't be displayed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8cf1364d-ebfc-d0df-881f-b98e5ae1a1c0
Version Independent ID: fd32442f-502b-d2a3-80e6-086d7c65bf5b
Content: MapElementsLayer.MapElements Property (Windows.UI.Xaml.Controls.Maps) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.controls.maps.mapelementslayer.yml&version=GBlive&_a=contents
Product: uwp
Git Login: hickeys
Microsoft Alias: hickeys

This is true, however this is not the place for that specific piece of documentation. There are many places where IList<> is used, and mentioning the difference between List<> and ObservableCollection<> in all of these places is not feasible and distracts from the point of the API documentation, which is to provide a simple, technical explanation of the APIs. Understanding the behaviors of the various types of collections available in UWP is more appropriately done elsewhere, such as the articles regarding ObservableCollection<>, which already provides this information.


wave sensor (9dof): where to position it and how to fix breadboard?

Should the wave sensor (9dof) be placed right next to the antenna or rather on the opposite side of the box?
And how is the breadboard attached on the wall of the box? (glue? duct tape?) It is not visible on the pictures in the manual. Thank you!

Location and orientation of the 9dof should not play a role. I have it on the same side of the batteries as the antenna, but a bit apart from each other. Anyways, GPS/Iridium is never active at the same time as the 9dof as things are now, so it should not play a role. I personally wrap it in duct tape (no naked metal), tape it to the wall, and add a dot of glue after testing :) .
Does that sound reasonable? :)

Sounds good, we will also have the antenna and wave sensor on the same side. There is enough space for that in the big boxes

Updated the instructions.


Update composer.json

Laravel doesn't follow semver. So having ^5.x or >=5.x will mean that composer will install a future version even though that version breaks the package.

Oh, didn’t know that! Thanks for solving this 👏🏼


deactivate dependabot for web dependencies

As dependabot is spamming too much when it tries to upgrade the web dependencies, we spent to much by reviewing each PRs. So it doesn't worth it to keep it.
It would be far more interesting if it was able to open a single PR containing all the necessary update at once.
I'm looking at other options like suggested in the issue: https://github.com/dependabot/dependabot-core/issues/1190#issuecomment-954264074. Potentially the others tools can do the job in a better way.
I didn't deactivate it for the go dependencies as it was less time consumming from my point of view.
Signed-off-by: Augustin Husson<EMAIL_ADDRESS>

:+1:

so I take some look at depfu or renovate and it doesn't seem there is one that is able to create a single PR.
Depfu is maybe promising in a sense where it promises to reduce the number of PRs.
I'm not really sure if it's worth to try it.
WDYT @SuperQ @juliusv ?

@Nexucis Hmm, in what way does depfu reduce the number of PRs, if it cannot create single ones? If it's not significantly less than with the initial dependabot integration, then I would be for just updating npm deps manually, once in a while.

defpu reduces the number of PRs by not updating every dependencies each time a patch is released from what I understood.

I see... if it's only a reduction on that level, I think I still prefer the manual updates. That has the added benefit that when a human does it (and all at once), they will hopefully also more actively check afterwards that everything is still working.


Add reddit web scraper in python projects

Describe the project you want to add with tech stack

I'd add a reddit scraper class, which would scrape the reddit posts and user's data on query through function call. It would return the required data in the form of either a list or JSON.
Expected behavior

user makes an object of the scraper class.
User calls the required method(s) from the scraper class and passes in the input query paraeter.
The scraper fetches the results and returns it in form of a list of JSON as required by the user.
It can work on any project by just importing it into the project.

@TusharKesarwani @MohitGupta121 please assign me this


Lens Distortion Pass

Is your feature request related to a problem?
Is there any interest in adding a lens distortion pass to pmndrs/postprocessing?
Describe the solution you'd like
I made a custom pass that imitates a lens distortion as seen in camera lenses 🎥
Additional context

Hi,
what tasks would this pass perform? There's already the ChromaticAberrationEffect which supports color shifting near the screen edges and I think lens/perspective warping can be done by changing camera parameters :thinking:

I'm aware of all these parameters.
I made a simple demo to showcase what I mean: https://laens-1b1ohvvdz-eriksachse.vercel.app/
It'll add a barrel/fisheye and pincushion distortion. More info here: https://learnopencv.com/understanding-lens-distortion/
I'd have to tweak the parameters further to avoid the frustum culling glitch.

Feel free to send a PR.

That project seems unusable, its built into an app. But I've been testing this out for my purpose. But its applying the whole viewport for both WebXR cameras  https://github.com/ycw/three-lens-distortion
This is what I can come up with so far, I cant make it distort each webxr camera and sized for each viewport. Trying to rebuild a webxr polyfill solution for Iphone as the polyfill project is broken with three. People want it.

I have a working ported example. I'm not sure if it's correct.
https://danrossi.github.io/three-lens-distortion/example/postprocessing.html
Shader. Takes inputBuffer as input to manipulate uv of the texture.
https://github.com/danrossi/three-lens-distortion/blob/main/src/glsl/lens-distortion.frag

@danrossi Thanks for porting that effect. I think the mainUv function would be better suited in this case :thinking: Can you please check if the following works the same?
uniform vec2 distortion;
uniform vec2 principalPoint;
uniform vec2 focalLength;
uniform float skew;

float border(const in vec2 uv) {

	return float(uv.s >= 0.0 && uv.s <= 1.0 && uv.t >= 0.0 && uv.t <= 1.0);

}

void mainUv(inout vec2 uv) {

	vec2 xn = 2.0 * (uv.st - 0.5); // [-1, 1]
	vec3 xDistorted = vec3((1.0 + distortion * dot(xn, xn)) * xn, 1.0);

	mat3 kk = mat3(
		vec3(focalLength.x, 0.0, 0.0),
		vec3(skew * focalLength.x, focalLength.y, 0.0),
		vec3(principalPoint.x, principalPoint.y, 1.0)
	);

	uv = (kk * xDistorted).xy * 0.5 + 0.5;

}

void mainImage(const in vec4 inputColor, const in vec2 uv, out vec4 outputColor) {

	outputColor = vec4(border(uv) * inputcolor.rgb, inputcolor.a);

}

Yes that worked. I've got to get it working in XR now. It shows up doubling up over both cameras, in the html emulator and polyfill its not rendering a texture. Not sure if its a shader issue.
https://danrossi.github.io/three-lens-distortion/example/postprocessing.html

actually it doesn't cut around the texture. It's filled black in the canvas. Before it was showing the background color of the page.

actually it doesn't cut around the texture

It's probably working as intended now. Try setting the clear alpha to 0: renderer.setClearAlpha(0)

I've added it to this option.
https://danrossi.github.io/three-lens-distortion/example/postprocessing-uv.html
the original
https://danrossi.github.io/three-lens-distortion/example/postprocessing.html

Hm, what if you change this line to outputColor = border(uv) * inputcolor;

It worked. I added a new example with uniforms menu
https://danrossi.github.io/three-lens-distortion/example/postprocessing.html
https://danrossi.github.io/three-lens-distortion/example/postprocessing-video.html

Should I add that as a PR ? I prefer raw tests however all the demos in this project are difficult to pull apart the code and figure out usage. It took me a while.

Should I add that as a PR ?

Yes, that's fine. No need to add a demo for this. Here's the PR guide, just in case.
FYI: the new demos are here: https://github.com/pmndrs/postprocessing/tree/main/manual/assets/js/src/demos

I'll try my very best and see what I can do. I already made a fork but made changes to main for testing something. I'll set it up again to do changes in a branch.


BadPacketException thrown out by HexaCord (Bungeecord Fork)

What is the output link of /viaversion dump?
https://dump.viaversion.com/4a56744f64bf68f99c2d3bbdf22d263395899f55b7f172d14aafcdad019ed48e
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
HexaCord - Latest Version.
https://sfy.cx/ss/u/bf0f.png
How does this error happen? login? Using an item?
It happens on login.
NOTE: Players reach the lobby without being kicked (by that i mean that the players show joining message on the Lobby)
Is there an error in the console? Use pastebin.com. Is there a kick message?
https://pastebin.com/VH5DvDEX

Try to remove SkinsRestorer and try again

Didn't help. SkinsRestorer doesn't seem to be the issue. Protocol 25 seems to have something to do with PluginMessaging.
Bug persists in latest waterfall version.

Try latest dev build of viaversion. If the issue still persists, enable viaversion debug to eventually get more info

I've managed to fix the issue by updating the proxy server. Seems neither HexaCord / Waterfall were properly supporting 1.13 protocols.


fix: Revise secret flags for Salesforce (#587)

This marks: clientId and userName as non-secret component properties.

@jimmidyson @zregvart It seems that adding the jsons alone is not good enough as although there are checked in, they are autogenerated from somewhere. I.e. when I do a 'mvn install' this changes gets overwritten again.
Any idea where this comes from ? (before I start digging ...)

@rhuss it could be the combination of annotation processor (camel/tooling/apt) and camel-package-maven-plugin (camel/tooling/maven/camel-package-maven-plugin) that generate JSON files for Camel Catalog. This would mean that a new release of Camel would be needed see CAMEL-11478.

Agreed. Should we make the generation of the json somewhat optional in order to decrease the chances that the old version is checked in by accident ?. E.g. we could introduc a profile 'schema-regen' and configure the plugin only for this profile.


Support for custom plugins

In docs it says

--enable_alpha_plugins is disabled by default, so it uses only the built-in plugins.

Any particular reason for it?
Kustomize plugins system is very powerful and a lot of ppl are using it.
Ref to docs:  https://kubectl.docs.kubernetes.io/guides/extending_kustomize/execpluginguidedexample/

While executing random binaries on your local machine may be acceptable, inside a container with cluster admin access it becomes a major security concern. There is a PR that enables custom plugins here, you would have to place the binaries in Git, which I think it's also an issue but it could be somehow better than building your own kustomize-controller container image.

usually you can cover a lot with simple bash scripts that is fine to store in git. for more complex cases a sidecar approach with shared volume can do the job.
do you have any plans to merge that PR?

usually you can cover a lot with simple bash scripts that is fine to store in git.

There is no bash in kustomize-controller container.

yes, there is no bash shell, but there is sh :)

How about plugins unrelated to kustomize? They could be mounted in the pod. This is what Argo CD is doing: https://argoproj.github.io/argo-cd/user-guide/config-management-plugins/

How about plugins unrelated to kustomize? They could be mounted in the pod.

We had that in Flux v1 and it turned out to be a security nightmare. Flux v2 is multi-tenant by design, running arbitrary binaries and scripts inside a container with cluster admin access would break all security boundaries we've put in place. Imagine a tenant has a script that dumps all secrets from all namespaces and posts them to some external URL.

Imagine a tenant has a script that dumps all secrets

If you have a tenant you don't trust and they can mount something to a pod with with cluster admin access isn't that already the issue? If this pod has sh they can kubectl exec anyway. Do I miss something here?

Do I miss something here?

Yes, check out https://github.com/fluxcd/flux2-multi-tenancy a tenant can't exec into flux control plane nor can it run pods under cluster admin, but with a plugin they could elevate to admin.

So if the plugin was configured on the controller level (and IIUC the tenant doesn't have access to it) and only referenced from the CR, would that be ok security-wise?

@stefanprodan how about something like a empty-canvas-controller which would be designed to be configured with a user mounted binary/plugin? That binary/plugin should be generating manifests based on the tarball URL or path to unpacked repository files.

Here's a gist with my kustomize-controller Dockerfile, flux2 kustomization.yaml and flux2 gotk-patchs.yaml files to enable KRM config function functionality, in case anyone finds it useful. The build arguments to the Dockerfile are furnished externally, and at the time of this comment are set to:
DOCKER_IO_ALPINE_HELM: 3.6.3
DOCKER_IO_GOLANG: 1.17.0-alpine3.14
GHCR_IO_FLUXCD_KUSTOMIZE_CONTROLLER: v0.14.0
GITHUB_COM_FLUXCD_KUSTOMIZE_CONTROLLER: v0.14.0
PKGS_ALPINELINUX_ORG_PACKAGE_V3_14_COMMUNITY_DOCKER_CLI: 20.10.7-r1
PKGS_ALPINELINUX_ORG_PACKAGE_V3_14_MAIN_GIT: 2.32.0-r0

I think it's clear enough at this point that Flux will not change its position on support for outside binaries; if we want to add more features to Kustomize controller, they need to be available as go packages so that we can reference their logic without shelling out to a third-party. It's not the third-parties we distrust, it's the shelling out that's the dangerous part.
Closing, as this issue appears inactive and is unlikely to progress any further.

This is a big challenge for users of very widely deployed systems like SOPS and kustomize-sops for secrets management.

@ringerc Flux has native support for SOPS, please see the docs: https://fluxcd.io/docs/components/kustomize/kustomization/#secrets-decryption

I think its thinking of Flux users like idiots. People should know what plugins are they using and carefully decide themselves - and take the consequences. Best way there is to add a warning in the docs in my opinion :sunglasses:
For example I had to write a Kustomize plugin to migrate a specific project into ArgoCD, I would not be able to do the same thing with the FluxCD :wink:

No offense to any users intended but, if you treat the user like they are stupid when designing software, you are usually not disappointed. This decision constrains the users short-term choices somewhat in exchange for a great deal of predictability and stability within the ecosystem where we can say Flux only incorporates declarative primitives and works entirely within the Kubernetes API. You can still integrate third-party tooling with CI or custom operators. Flux v1 allowed certain types of shelling out for users, and it was fraught. The risk of compromise is significant, and easily mitigated by this design decision.

@keskad and @kingdonb I'm not sure if it has come to your attention that OCI repository support was recently added. It relegates the responsibility of manifest hydration to your CI tool, allowing the CD tool to be agnostic to the inordinate combination of rendering tools that one has at their disposal. Seems a reasonable tradeoff IMHO.

A common use-case for kustomize plugins is the reuse of off-the-shelf yaml/json asserts to construct K8S resources (typically grafana dashboards or prometheus rules.
I understand from https://github.com/kubernetes-sigs/kustomize/issues/4636 that this is not in scope for future Kustomize builtin support, and could only be supported by a custom transformer, typically a custom generator.
Major drawbacks of custom resources controllers (see https://github.com/prometheus-operator/prometheus-operator/issues/4495#issuecomment-1251026056) loading reusable yaml/json fragments from a ConfigMap (or Secret generated from Kustomize builtin generators) are:

the CR maintainers can't leverage CRD schema to perform input validation on the ConfigMap. Therefore, feedback on syntax errors on the ConfigMap content gets delayed later in the deployment workflow and most costly to diagnose/fix.
transformations to be brought to the reusable yaml/json assets can't be performed by authors using Kustomize patches.

You can still integrate third-party tooling with CI or custom operators.

My return on experience from these workarounds:

A preprocessing CI pipeline performing source templating and rendered K8S spec files into the source git repo, then deployed using Kustomize controller:

While this provides authoring flexibility, this increases length of feedback cycles, adds complexity to the overall authoring workflow.

A distinct operator supporting native yaml/json templating: carvel kapp controller with its builtin ytt yaml templating syntax:

This comes with higher syntaxic authoring complexity which makes it hard/challenging to generalize and replace current use-cases satisfied by fluxcd kustomize controller.
A functional overlap between fluxcd and carvel kapp controller are causing operational challenges:

duplicated tooling for listing/inspecting/pausing/resuming reconciliations
distinct assets inventories
duplicated maintenance of source controller configurations: between flux source controller and kapp fetch spec
required operational knowledge to support/troubleshoot both stack

A functional overlap between fluxcd and carvel kapp controller are causing authoring challenges:

Even when encapsulating complex ytt yaml templating in libraries, the basic syntax for deploying resources is distinct between KustomizeController and KappController, surfacing two distinct syntaxes to authors

Integration between the two controllers is challenging, e.g.:

Given a Kustomization includes a Kapp CR resource performing ytt yaml rendering of K8S resources (say a PrometheusRule from a remote url)
When pausing the Kustomization
The Kapp CR resource don't get paused

I'm not sure if it has come to your attention that OCI repository support was recently added. It relegates the responsibility of manifest hydration to your CI tool, allowing the CD tool to be agnostic to the inordinate combination of rendering tools that one has at their disposal. Seems a reasonable tradeoff IMHO.

The workflow detailed in https://github.com/fluxcd/kustomize-controller/pull/163#issuecomment-1162032488  seems similar to the preprocessing CI pipeline approach above, with the following benefits and challenges:

same authoring Kustomize syntax is used between preprocessing CI step and Flux-based CD steps
community shares Kustomize plugins for common use-cases instead of custom homemade preprocessing pipelines
additional challenges of traceability of changes across CI and CD (need detailed metadata in the OCI image produced by CI to track the authored changes to K8S clusters).

 This decision constrains the users short-term choices somewhat in exchange for a great deal of predictability and stability within the ecosystem ...

If the creators of operating systems were thinking like this, they would get nowhere and using computers today would be very unpleasant.


enhance Windows TUN mode

Fixes #60
implement #62 with minimal cost

Thanks for the work. As far as I can tell, this is not DHCP. Instead it configures the interface with IP layer along with DNS servers, just like when you manually configure them in the network adapter settings screen.
I agree this is useful in many scenarios, though I think it should be in a separate package than the one managing the interface itself.


engine: fix exclude path bug

If there was more than one exclude path, then every path would always be
included due to an uncaught logic bug.

I realized the way I wrote this made it hard to test (working directly with the os package). I'm going to revisit it after I get this together.


(v1.1.0, CPU)SSE,SSE2,etc warning messages on Windows 10

These are awkward messages since TensofFlow doesn't support windows build officially.

You'll need to compile it yourself if you want to get rid of them.


Added keepTooltip feature

Can some contributor review this pull request and merge.

@whoisandy, please take a look at this PR when you will have a chance.

+1 for this feature.

I really need this feature. Can you please merge this?

Please merge

merge would be appreciated :)

guys please please please merge this PR its a very helpful feature!!!

Please merge

Why is this not merged yet?
We need this...

Guys, relax. This repo seems dead. Just copy sources in libs folder. My project in production lives this way for two years, everything is fine.


Patch for #193 - Add matrix to M-series runner

Patches #193 for the M-series runner. See current logs for failing tests, as the noxfile requires a PYBAMM_VERSION.

Scheduled test running here: https://github.com/pybop-team/PyBOP/actions/runs/7940982485. Looks like I've missed filter for out the duplicates.
Still running into the pybamm==None issue though.

Scheduled test running here: https://github.com/pybop-team/PyBOP/actions/runs/7940982485. Looks like I've missed filter for out the duplicates.
Still running into the pybamm==None issue though.

What's the pybamm==None issue?

This should now be ready for review (no rush, as it's the weekend!).
Tests running here: https://github.com/pybop-team/PyBOP/actions/runs/7941250463 with the correct number of entries and the PYBAMM_VERSION env variable caught.


CredSSP and Failed Deployment

This doesn't seem to be working anymore.  Marketplace offering has been trying to deploy for almost 2 hours without success.
Looks to be hung up on the REPORTVM/configureRSServer extension.
Deployed the VM's directly from their gallery image reference without the extensions to see what might be going on and ran into the CredSSP issue.  I was connecting from a patched Windows 10 system, so it looks like the gallery images are not updated with the CredSSP patch, preventing me from logging in from a patched system.  I implemented the registry change to unsecure my system and was able to connect.
Has anyone deployed this recently with success?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d7c7b5d6-c9a4-3445-81c1-41dc41ae0929
Version Independent ID: a45e9b8a-185b-ff29-dc4a-b8912c13ed1b
Content: Tutorial: Explore Power BI Report Server in a VM - Power BI
Content Source: powerbi-docs/report-server/tutorial-explore-report-server-web-portal.md
Service: powerbi
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

I was having the same issue. When I tried to login, it just said "An authentication error has occurred. The function request is not supported. This could be due to CredSSP encryption oracle remediation."
The steps to fix this were detailed at https://support.microsoft.com/en-au/help/4295591/credssp-encryption-oracle-remediation-error-when-to-rdp-to-azure-vm
The most common scenario is that the client has the CredSSP update installed, and the Encryption Oracle Remediation policy setting does not allow an insecure RDP connection to a server that does not have the CredSSP update installed.
To work around this issue, follow these steps:
On the client has the CredSSP update installed, run gpedit.msc, and then browse to Computer Configuration > Administrative Templates > System > Credentials Delegation in the navigation pane.
Change the Encryption Oracle Remediation policy to Enabled, and then change Protection Level to Vulnerable.
Once I did these steps, I could login using the RDP connection, no problems.
It'd be great if it just worked instead of having to spend time figuring out all these issues!

Spoke too soon! I can connect to the VM, but the VM has nothing in it. The Desktop just has a recycle bin and a "SQL Server getting started" IE icon. It seems this VM needs updating as it doesn't work!!

The fix you mentioned is what I did as well.  But that means I have to change the registry to allow my computer to connect to insecure systems.  Which means the gallery image used in this deployment is not running the patch for this.
The reason the VM is empty, I believe, is because that final script that is kicked off by the last extension in the ARM template is failing.  The ARM template builds the VM from a SQL server image and then runs a script to finish the configuration.  So it has SQL but no configuration as the instructions suggest should be there.

For more reference, here is the error from the deployment:
{ "id": "/subscriptions/f91cf6ff-d439-414d-90cd-6e9e809d3f0b/resourceGroups/PowerBIReporting/providers/Microsoft.Resources/deployments/reportingservices.technical-preview-20190201144555/operations/B8BAB3356C173973", "operationId": "B8BAB3356C173973", "properties": { "provisioningOperation": "Create", "provisioningState": "Failed", "timestamp": "2019-02-01T23:45:42.9603153Z", "duration": "PT1H30M18.0501445S", "trackingId": "054143c8-4e83-43e5-aed4-c57a9d84080d", "statusCode": "Conflict", "statusMessage": { "status": "Failed", "error": { "code": "ResourceDeploymentFailure", "message": "The resource operation completed with terminal provisioning state 'Failed'.", "details": [ { "code": "VMExtensionProvisioningTimeout", "message": "Provisioning of VM extension 'configureRSServer' has timed out. Extension installation may be taking too long, or extension status could not be obtained." } ] } }, "targetResource": { "id": "/subscriptions/f91cf6ff-d439-414d-90cd-6e9e809d3f0b/resourceGroups/PowerBIReporting/providers/Microsoft.Compute/virtualMachines/REPORTVM/extensions/configureRSServer", "resourceType": "Microsoft.Compute/virtualMachines/extensions", "resourceName": "REPORTVM/configureRSServer" } }}
The total deployment attempt was 1 hour 59 minutes.  The configureRSServer extension was 1 hour 30 minutes before it finally failed.

Thanks for the info. Do you know if it's possible to manually kick off the extension that's failing?  Or is this something that MS needs to fix in their VM script? Thanks

Hi @mhaarbrink @Prezentter -- thanks for asking! I'm investigating and will reply back when I have an answer.
thanks again --

@maggiesMSFT We have an email conversation going on with Matt Goswell of Microsoft also.  You may ping him internally and see if he's come up with anything yet.  We sent him the link to this document and open issue.

Hi @mhaarbrink  and @Prezentter ,
So we tested against a new VM and we could log into it from a patched machine.
We pulled the logs- it goes through and installs the update too.
The extensions are what configure and domain join and set up the security patch so you can’t do this without the extensions, that is what caused you to have a non-patched machine.
The net time to deploy one machine from the image was 35 mins including the configureRSServer step. Another machine took 41 mins.
So the machine not deploying might be a one-off. Potentially you need to redeploy to fix it.
The other thing you mention about the VM not having anything, that’s because the extensions didn’t run as well. The PowerShell scripts install the server and configure it and upload the sample reports. Without this, you have a new blank VM.
Please let us know if you still face any issues. Thank you.

Sagar (MSFT)


not creating k8s secrets

I have deployed below Helm Charts as daemonSets in K8s Cluster.
1)secrets-store-csi-driver-1.4.4
2)secrets-store-csi-driver-provider-aws-0.3.9
Instead of Mounting the secrets into Pod, i would like to have k8s native secrets to get secrets from Aws Secrets Manager
When we deploy StorageProviderClass its not creating Secrets.
Pod stuck with Error: secret "mysecret-k8s" not found
IAM Role working fine and storageproviderClass Yaml also looks fine, as its working fine when i add Volume\volumeMounts to the POD,i am getting secrets from AWS.
Which provider are you using:
AWS Secrets Manager
Environment:
Secrets Store CSI Driver version: v1.4.4
Kubernetes version: v1.27
YAML file below..
apiVersion: secrets-store.csi.x-k8s.io/v1
kind: SecretProviderClass
metadata:
namespace: csi-provider
name: mysecret
spec:
provider: aws
secretObjects:

secretName: mysecret-k8s
type: Opaque
data:
objectName: "dataminds_svcs_database_dbpassword"
key: "dataminds_svcs_database_dbpassword"
objectName: "dataminds_svcs_idm_password"
key: "dataminds_svcs_idm_password"
parameters:
objects: |
objectName: "ci/apiplt/test"
objectType: "secretsmanager"

apiVersion: apps/v1
kind: Deployment
metadata:
name: nginx1
namespace: csi-provider
spec:
replicas: 1
selector:
matchLabels:
run: nginx1
template:
metadata:
annotations:
secrets-store.csi.k8s.io/used: "true"
labels:
run: nginx1
spec:
containers:

image: nginx:stable-alpine
name: nginx1
env:
name: dataminds_svcs_database_dbpassword
valueFrom:
secretKeyRef:
name: mysecret-k8s
key: dataminds_svcs_database_dbpassword
name: dataminds_svcs_idm_password
valueFrom:
secretKeyRef:
name: mysecret-k8s
key: dataminds_svcs_idm_password
serviceAccountName: csi-provider

Please look into it and let me know if i miss anyting

You are looking at the wrong project for native K8s secrets. If you are interested in native k8s secrets only, you'd use a project like ESO: https://external-secrets.io/latest/

I think https://secrets-store-csi-driver.sigs.k8s.io/topics/sync-as-kubernetes-secret is what you want.
If you have more questions about this, open an issue at https://github.com/kubernetes-sigs/secrets-store-csi-driver
This doesn't look like it is specific to our AWS provider.


How would I inject dependencies into controllers (or anything else)?

Is there a technique I'm unaware of for injecting dependencies into the controllers. Or with lotus/lotus I might want to inject dependencies into view classes as well, can't figure out how I would go about that either.
I was looking through endpoint_resolver.rb and it occurred to me that with the way it makes instances of the action class, I don't have a clear way to inject dependencies into them. Maybe you know a way? Please tell me.
Let's say I have an action, and I want it to be set with an instance of the redcarpet markdown parser and not have to make an instance of it in line. (Because injecting dependencies makes things easier to test and more loosely coupled).
require 'redcarpet'

module Blog
  module Controllers
    module Posts
      class Show
        include Lotus::Action
        expose :markup

        attr_writer :markdown

        def call(params)
          contents = File.open("posts/#{params[:slug]}.md") { |f| f.read }
          @markup = @markdown.render(contents)
        end
      end
  end
end

With that markdown as a settable, easily mocked dependency this class is easier to test and has the added benefit of not being coupled to the HTML renderer, it could have been set with any type. As you can see the action below only renders HTML, but the one above doesn't have that constraint.
def call(params)
  markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML);
  contents = File.open("posts/#{params[:slug]}.md") { |f| f.read }
  @markup = markdown.render(contents)
end

Something like this worked for me (dont like re-opening classes though):
module Lotus
  module Routing
    class ClassEndpoint
      def call(env)
        dependencies = __getobj__.instance_method(:initialize).parameters.collect { |p| p[1] if [:keyreq, :key].include?(p[0]) }
        instances = {}
        dependencies.each do |dependency|
          instances[dependency] = Common::Application::DependencyRegistry.instance(dependency)
        end
        __getobj__.new(**instances).call(env)
      end
    end
  end
end


fix #2281: passthru escapes when parsing regex

Make the InfluxQL parser check for '/' escape and pass all other
escapes through to the Go regexp parser unmodified.

@marcosnils regular expressions go through two parsers, InfluxQL and Go's regexp.  Both parsers use \ for escapes.  What this PR does is make the InfluxQL parser only recognize one escape (\/), which is the InfluxQL regular expression delimiter.  InfluxQL passes all other escape sequences through to Go's regexp parser.

@dgnorton thanks for clarifying :+1:

+1


Which plugin version should be used for Rabbit 3.7.17?

Please suggest the proper plugin version for the last RabbitMQ version 3.7.17.
Is v<IP_ADDRESS> compatible? Have a problem with installation.

Just checked - v<IP_ADDRESS> version of the plugin is compatible for RabbitMQ 3.7.17


Your website deskshell.org is offline...

I am not sure if you guys have noticed, but your website is offline. I'll come back later to try deskshell.

deskshell.org is now online again :-)

Great, you da man!

I downloaded Deskshell and I installed your experimental portable version in a none-"C:" partition and it worked flawlessly!
In case you are curious, I used portableapps.com bult-in installer in my in Win8.1 (Update 3) 64bit machine.
:) Now, I have a few questions, I am trying to get my head around what you guys did:
1- Is your windows portable version lacking any features of your other "full" installation?
2- Your demos seem quite adequate in terms of speed, what did you guys use as a server to serve the static files? Is it Node that is serving the static content?
3- I noticed in chrome://chrome/ you guys used Chrome "Version 30.0.1599.69", was this on purpose? Can I carefully replace the binaries in "X:\PortableApps\DeskshellPortable\App\bin\win\DeskshellChrome\App\Chrome-bin\30.0.1599.69" from the more recent version Chrome from portableapps.com?
4- Also there in chrome://chrome/ it says "Update failed (error: 1)". Is updating automatically by design and therefore out of the question?
5- What is actually running Deskhell, is it Chromium or Chrome?
6- I noticed your demos were running on port "61935", is this port number fixed?
7- I really thought I had read some where that php and node were good to go in Deskshell (which was the main reason that attracted me to Deskshell in the first place)... so how do we get php running in there?
8- Is there any performance gains by using your nsis compilation of apps into executables?
9- And my lastly... Is it me, or is your Deskshell running faster than my installed Chrome because it is not using Chrome's sandboxing?
I am very excited I am already thinking on certain php applications I would love to package...  :+1:

The "full" installation only adds some windows integration points, so it adds a start menu entry and globally registers *.desk files with deskshell.exe, so you are missing nothing.
The architecture is nodejs reads the .desk file and then runs portable chrome as a packaged app pointing to a port that nodejs has opened.
DeskshellChrome is the chrome portable application from PortableApps.com (http://portableapps.com/apps/internet/google_chrome_portable) the executable is renamed to DeskshellChrome.exe so that you can more easily see what is running in windows task manager. So yes you can just rename the directory and then install a new portable apps version of chrome and if the new version works ok then delete the old folder. Nodejs launches the chrome binary from the command line so there are no dependencies on the version of chrome you are using.
I think this was done by portable apps due to legal issues after repackaging chrome to be portable, basically since this will be running your own locally developed app you don't actually want it to be updated automatically -- what if chrome depreciates an api that your application relies on (remember google gears for example), well then your app would break, however you can have your own updater for the whole application (including your parts) and simply update the directory as needed.
Deskshell is "virtual" so it is the combination of having nodejs + chrome together. The exe is a very simple binary (built using NSIS Portable), all it does is start off nodejs with the deskshell.js script and suppresses the console window that nodejs wants to open.
Deskshell should find a free port and use that (if I remember correctly), I think there is an option to set a fixed port somewhere as well.
We have tried a couple of experiments with php running in deskshell and also with replacing nodejs with a php implementation. Can you file a separate issue for php and I will create a plugin to add that functionality and add it to the documentation as well.
performance will be slightly slower, the main reason for bundling into an app is so that all of the files are not exposed on disk enabling users to edit or rename or delete them hence breaking the app. The exe compilation is still experimental at this point and needs more work.
Deskshell launches chrome in the packaged apps mode, but pointing to a nodejs port instead of at the disk, therefore depending on your chrome profile/ installed extensions etc it could load faster.


Unable to update Primal via Obtanium

Describe the bug
Unable to update Primal via Obtanium
Steps to reproduce
Click update in Obtanium
Expected behavior
Downloads and installs
Additional context
Download successful but fails to install

How did you installed previous build which wont update?

I think it was through Obtanium as well but not sure. Sorry.
Unistalling and reinstalling through Obtanium worked.
Not even sure whether this is an Obtanium or a primal bug.
What is the second "crash report" apk for?

Google Play signs with its own certificate so updates wont work between apk and play releases.
And they are different builds. Play build has play libs while apk is aosp and can work without play services.
Crash reporting apk is the aosp build with Primal's very simple crash reporting tool which submits stacktraces in case of crashes. On other builds this is disabled.


test: compiling failure running a single test

Bug Report

What version of TiKV are you using?

Nightly with commit hash 6a906dae15f62be7df7c707c43550e25c0599a9a.
What operating system and CPU are you using?

Does not matter.
Steps to reproduce

After https://github.com/tikv/tikv/pull/13989 some test-only traits are introduced, and the test command
cargo test  --package tikv --lib server::engine_factory::tests::test_engine_factory -- --exact would encounter
compiling failures.
What did you expect?
running 1 test
test server::engine_factory::tests::test_engine_factory ... ok

What did happened?
error[E0407]: method `set_state_storage` is not a member of trait `TabletFactory`
   --> src/server/engine_factory.rs:241:5

The test command could not work as before, to resolve this the user may explicitly specify the test feature dependencies using
cargo test --features testexport  --package tikv --lib server::engine_factory::tests::test_engine_factory -- --exact

Or add the testexport feature to the default list in Cargo.toml
[features]
- default = ["test-engine-kv-rocksdb", "test-engine-raft-raft-engine", "cloud-aws", "cloud-gcp", "cloud-azure"]
+ default = ["test-engine-kv-rocksdb", "test-engine-raft-raft-engine", "cloud-aws", "cloud-gcp", "cloud-azure", "testexport"]

It is better to keep the test command valid to avoid fallback.

@BusyJay @SpadeA-Tang
Should we change the default feature configuration?

For TabletFactory, changing #[cfg(any(test, feature = "testexport"))] to #[cfg(feature = "testexport")] is ok. How to handle with RoleChange::new? @BusyJay

What's going wrong with RoleChange::new?

What's going wrong with RoleChange::new?

I think you can enable the feature in dev-dependencies.


Use-after-free push_stack in /src/cups/cups/raster-interpret.c

Description
Hello, while performing fuzzing based on the information registered in OSS-Fuzz, a UAF crash was discovered. I would like to share some basic analysis and crash data related to this. (Additionally, this issue does not have a significantly detrimental effect on the program.)
Crash Log
/out/FuzzCUPS -rss_limit_mb=2560 -timeout=25 FuzzCUPS_poc/cups--FuzzCUPS--crash-ec73921dbc52d3ce45efccb47567ba46-2023-07-27-16:03:10 # /tmp/FuzzCUPS_corpus < /dev/null
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed:<PHONE_NUMBER>
INFO: Loaded 1 modules   (10782 inline 8-bit counters): 10782 [0x724ea0, 0x7278be),
INFO: Loaded 1 PC tables (10782 PCs): 10782 [0x7278c0,0x751aa0),
/out/FuzzCUPS: Running 1 inputs 1 time(s) each.
Running: FuzzCUPS_poc/cups--FuzzCUPS--crash-ec73921dbc52d3ce45efccb47567ba46-2023-07-27-16:03:10
=================================================================
==12==ERROR: AddressSanitizer: heap-use-after-free on address 0x61d0000007d0 at pc 0x000000530bd1 bp 0x7ffc688612a0 sp 0x7ffc68860a70
READ of size 72 at 0x61d0000007d0 thread T0
SCARINESS: 54 (multi-byte-read-heap-use-after-free)
    #0 0x530bd0 in __asan_memcpy /src/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3
    #1 0x5778d7 in memcpy /usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10
    #2 0x5778d7 in push_stack /src/cups/cups/raster-interpret.c:955:3
    #3 0x5778d7 in copy_stack /src/cups/cups/raster-interpret.c:730:10
    #4 0x573196 in _cupsRasterExecPS /src/cups/cups/raster-interpret.c
    #5 0x56ee5c in LLVMFuzzerTestOneInput /src/cups/fuzzer/FuzzCUPS.c:45:5
    #6 0x4406b3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #7 0x42be12 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
    #8 0x4316bc in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:860:9
    #9 0x45abf2 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #10 0x7f677bc91082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)
    #11 0x421fdd in _start (/out/FuzzCUPS+0x421fdd)

DEDUP_TOKEN: __asan_memcpy--memcpy--push_stack
0x61d0000007d0 is located 1872 bytes inside of 2304-byte region [0x61d000000080,0x61d000000980)
freed by thread T0 here:
    #0 0x531c4c in __interceptor_realloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:85:3
    #1 0x577844 in push_stack /src/cups/cups/raster-interpret.c:944:17
    #2 0x577844 in copy_stack /src/cups/cups/raster-interpret.c:730:10
    #3 0x573196 in _cupsRasterExecPS /src/cups/cups/raster-interpret.c
    #4 0x56ee5c in LLVMFuzzerTestOneInput /src/cups/fuzzer/FuzzCUPS.c:45:5
    #5 0x4406b3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #6 0x42be12 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
    #7 0x4316bc in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:860:9
    #8 0x45abf2 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #9 0x7f677bc91082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)

DEDUP_TOKEN: __interceptor_realloc--push_stack--copy_stack
previously allocated by thread T0 here:
    #0 0x531a1e in __interceptor_calloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:77:3
    #1 0x570d1b in new_stack /src/cups/cups/raster-interpret.c:899:19
    #2 0x570d1b in _cupsRasterExecPS /src/cups/cups/raster-interpret.c:529:13
    #3 0x56ee5c in LLVMFuzzerTestOneInput /src/cups/fuzzer/FuzzCUPS.c:45:5
    #4 0x4406b3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #5 0x42be12 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:324:6
    #6 0x4316bc in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:860:9
    #7 0x45abf2 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #8 0x7f677bc91082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)

DEDUP_TOKEN: __interceptor_calloc--new_stack--_cupsRasterExecPS
SUMMARY: AddressSanitizer: heap-use-after-free /src/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:22:3 in __asan_memcpy
Shadow bytes around the buggy address:
  0x0c3a7fff80a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff80b0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff80c0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff80d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff80e0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
=>0x0c3a7fff80f0: fd fd fd fd fd fd fd fd fd fd[fd]fd fd fd fd fd
  0x0c3a7fff8100: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff8110: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff8120: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c3a7fff8130: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c3a7fff8140: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==12==ABORTING

Analyze
From the debugging results, the obj structure was in a freed state at memcpy(temp, obj, sizeof(_cups_ps_obj_t)); in the push_stack function below.
The point at which it is freed seems to be when temp = realloc(st->objs, (size_t)st->alloc_objs * sizeof(_cups_ps_obj_t))) == NULL, as the memory of the heap area pointed to by obj is freed by realloc.
static _cups_ps_obj_t	*		/* O - New object */
push_stack(_cups_ps_stack_t *st,	/* I - Stack */
           _cups_ps_obj_t   *obj)	/* I - Object */
{
  _cups_ps_obj_t	*temp;		/* New object */

  if (st->num_objs >= st->alloc_objs)
  {

    st->alloc_objs += 32;

    if ((temp = realloc(st->objs, (size_t)st->alloc_objs *
                                  sizeof(_cups_ps_obj_t))) == NULL)
      return (NULL);

    st->objs = temp;
    memset(temp + st->num_objs, 0, 32 * sizeof(_cups_ps_obj_t));
  }

  temp = st->objs + st->num_objs;
  st->num_objs ++;

  memcpy(temp, obj, sizeof(_cups_ps_obj_t));

  return (temp);
}

Here, obj is an argument at the call of push_stack in copy_stack, and it was pointing to the st structure that is freed in realloc.
static int				/* O - 0 on success, -1 on error */
copy_stack(_cups_ps_stack_t *st,	/* I - Stack */
           int              c)		/* I - Number of objects to copy */
{
  int	n;				/* Index */

  if (c < 0)
    return (-1);
  else if (c == 0)
    return (0);

  if ((n = st->num_objs - c) < 0)
    return (-1);

  while (c > 0)
  {
    if (!push_stack(st, st->objs + n))
      return (-1);

    n ++;
    c --;
  }

  return (0);
}

Simple enough fix - just need to make a temporary copy of the stack object before copying...
[master d2edfc664] Fix a bug in the copy stack code (Issue #768)
[2.4.x cd01b4d1a] Fix a bug in the copy stack code (Issue #768)


Print end of logs

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   87.12%   87.12%
=======================================
  Files          89       89
  Lines        5027     5027
=======================================
  Hits         4380     4380
  Misses        647      647

Flag
Coverage Δ

#ios
87.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163a677...4f629ba. Read the comment docs.


Recommend AES > 256

For OpenVPN 2.4, the standard and recommended cipher will be AES-256-CBC.
So I think the best way is to not give the choice of cipher less than AES 256.

No.

Of the currently supported ciphers, OpenVPN currently recommends using AES-256-CBC or AES-128-CBC. OpenVPN 2.4 and newer will also support GCM. For 2.4+, we recommend using AES-256-GCM or AES-128-GCM.

(https://community.openvpn.net/openvpn/wiki/SWEET32)
Please read the Readme and the OpenVPN wiki and search online before suggesting things like that. It took hours to write the readme and justify the choices I made regarding encryption, so please at least read what I've done....

Oh, I forgot to write my source, for information: https://github.com/Nyr/openvpn-install/commit/597d16d094319cd330ccd7996d1eb8a7ebe1f10f

https://github.com/Angristan/OpenVPN-install/blob/master/README.md

thanks :)


Setup Play Space Falling ONLY

Is there anyway to setup play space falling ONLY.  I like the falling, but the automatic "teleporting on top" of stuff doesnt feel good for my game.   Is there anyway to simply disable the HALF of the functionality?  Or maybe override the behavior in some other way?
Thanks

This is all being re-written soon to make it more customisable.

cool, cant wait.  In the meantime, Im in the middle of a couple week game jam.  Any pointers to where I can hack this in the code directly?  I just want to disable the auto teleport ontop of stuff...

You can turn that off in the HeightAdjustTeleport script. Play Space Falling is the option i think.

Just FYI for anyone looking for an easy tweak to disable auto teleporting onto things..
In the VRTK_HeightAdjustTeleport script inside the DropToNearestFloor sub just comment out one line of code ...
` private void DropToNearestFloor(bool withBlink, bool useGravityFall)
{
if (enableTeleport && eyeCamera.transform.position.y > transform.position.y)
{
Ray ray = new Ray(eyeCamera.transform.position, -transform.up);
RaycastHit rayCollidedWith;
bool rayHit = Physics.Raycast(ray, out rayCollidedWith);
float hitFloorY = eyeCamera.transform.position.y - rayCollidedWith.distance;
            if (ValidDrop(rayHit, rayCollidedWith, hitFloorY))
            {
                if (initialFloorDrop && hitFloorY < previousFloorY && ControllersStillOverPreviousFloor())
                {
                    return;
                }

                if (UsePhysicsFall(useGravityFall, hitFloorY))
                {
                   playerPresence.StartPhysicsFall(Vector3.zero);
                }
                else
                {
                    //comment out the next line of code to prevent auto teleporting up onto stuff.
                    //TeleportFall(withBlink, hitFloorY, rayCollidedWith);
                }
                initialFloorDrop = true;
            }
            previousFloorY = hitFloorY;
        }
    }`

Just to give you a heads up on this.
All that play space falling stuff is going to be removed from the teleporter code.
Teleporting will just be about moving your position from one location to another.
The player body physics (new version of player presence) will be responsible for things like dropping to nearest floor in the future.


add filenames option

I want to use react-flexbox-grid on meteor.
https://github.com/roylee0704/react-flexbox-grid
This package had been changed to use css-module.
and I can't change the target css file extension to 'm.css' or 'mss'.
because the 'flexboxgrid.css' is included by another npm package such
https://github.com/kristoferjoseph/flexboxgrid
so, I need to use your css-module compiler by specific filename (not only extension)
ex) package.json
  "cssModules": {
    "filenames": [ "flexboxgrid.css", "flexboxgrid.min.css"]
  },

regards.

thanks!


Harvested styleguide

This is the Tahi Styleguide!
It shows the current styles and elements used throughout the app.
To get the most recent styles, run rake styleguide:generate.  This will run spec/features/harvest_styleguide.rb which runs a series of specs that harvest both .pngs and html from various app states.  The rake task then runs populate_styleguide.rb which pulls specified html from the newly created harvest files and inserts it into app/views/kss/home/styleguide.html.erb.  Voila, a 'live' styleguide!
Visit /kss/styleguide in development or staging to check it out!
— RW + AJP

Looks good, merge it! :shipit:

resolving conflicts now, on its way to mergggg


Cargo test with minimal versions fails

proptest depends on rand, which currently fails to build with minimal versions: https://github.com/rust-random/rand/issues/741
Once that's resolved should try to change the minimal CI job from just building to actually running the tests.

Can't we just increment the MSRV? The issue is 4 years old, I doubt anyone is still on that stable version.

This isn't about MSRV, that policy isn't actually stated but my standard policy is to only guarantee support of the latest stable at time of a release. It's about using cargo update -Z minimal-versions and running the tests with that, to check that the dependency declarations are correct (it doesn't guarantee that it'll work with all valid dependency combinations, but testing the minimum and maximum boundaries go a long way towards it).
There's a job doing cargo minimal-versions check already, and running cargo minimal-versions test locally it looks like it is actually working now (the version of rand being chosen must be high enough to work). I just need to figure out some nice way to have an optional job to run the test now (I share my github-actions configuration between multiple repos and some others don't work still).


Fix MongoDb Health Check (2.x)

Provide a CancellationToken instead of its Source #310

That is so weird... thanks git for the merge "help" and thanks @terolaakso for the real help!


Validation error not bubbling up when dropped

I'm experiencing an issue using both the validate size and validate type plugins where they are simply rejecting the file on drop with no error bubbling up - no onerror event triggering. However, when adding the files through the file picker interface it functions as expected where the file is added to the dropzone and highlights red with an error label.
Is this known/expected? Based on how it looks like the plugin is coded, I'm confused as to how the experience could differ between the two interactions. I do plan to keep digging.

Maybe dropValidation is set to true?

My apologies -- you're absolutely right. This was a complete misunderstanding of what that flag did -- I assumed it meant "turn on validation for drops" but its more "use the validation to reject files on the drops". Documentation was pretty clear on what it did once I looked at it -- sorry for wasting your time!!!

@jmhellman no worries, glad it’s working 👍


Added cypress tests for Facility cover image button functionality

Proposed Changes

Fixes #9109
Added functions (verifyCoverImageModalClosed, clickDeleteCoverImage) and cypress Intercepts to api calls in pageobject/Facility/FacilityManage.ts.
Written tests using the already existing functions to test upload, edit and deletion of facility cover image in FacilityManage.cy.ts.
Added roles in the FacilityManage.cy.ts for testing the functionality across different user roles
Added id = "delete-cover-page" to the delete cover page button element.

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

We should consider making each test atomic i.e., 1 test shouldn't influence the other, as this is making debugging and developing harder. We should clean up after or during each test and create the necessary resources before or during the test. There is no need to refactor anything for now, maybe we should enforce this for newer tests.
@nihal467 thoughts?

Create a new test file under the facility_spec folder itself.
Dynamically select a new facility for each user in the test, making sure that the same set of code and logic runs for different users in different facilities.

@rohitlingarker look into the code rabbit review,

As per issue, the API verification is not done once the file upload is completed [Also it was flag by the AI review]

Remove the manually hardcoded password usage in the test file. Using the existing login function, try to implement a solution where the password is dynamically allocated. The screenshot is a solution provided by ChatGPT to handle this kind of situation, though I wouldn't say it's well optimized. Think of a better solution that can scale and avoid hardcoded values.

@rohitlingarker any update

@rohitlingarker Closing the PR due to inactivity and unassigning you from the issue. Feel free to reopen the PR and get reassigned if you are still working on it.


DOC-2462 debug zip incl repl reports

Addresses: DOC-2462
CRDB: #75239

Added entry to cockroach debug zip reference page under Files to indicate that Replication Reports are now also included in the resulting zip file.

cockroach-debug-zip.html

This change is


[Question] Make name writeable

Hi,
i want to make the name in the Generic Access writeable.
I found ble_svc_gap_device_name_write_access in ble_svc_gap.c but i'm not sure from where i should get ble_gatt_access_ctxt or how i need to set it up correctly - or if there is a much simpler way to make the device name writeable.
Hope someone can help me!

Hi @Nailik, in the default configuration this characteristic is not writable. You can change this by adding:
#define MYNEWT_VAL_BLE_SVC_GAP_DEVICE_NAME_WRITE_PERM 0 to the nimconfig.h file.
I have not tested this but I believe it should work.

Thanks, works like a charm. Yeah it's weird but i need the name to have the flag write because i pretend to be a specific device and the client just checks for all the characteristic settings.
Hope it's ok to ask another question ..
How can i add the Device Peripheral Properties to the Generic Access Service?
Because i can't find the Service and then use createCharacteristics .. when i try
pServer->getServiceByUUID(NimBLEUUID(0x1800), 0) it's returning a nullptr unless i create a Generic Access Service myself

Uff too easy - solution is almost the same, just define those:
#define MYNEWT_VAL_BLE_SVC_GAP_PPCP_MIN_CONN_INTERVAL
#define MYNEWT_VAL_BLE_SVC_GAP_PPCP_MAX_CONN_INTERVAL
#define MYNEWT_VAL_BLE_SVC_GAP_PPCP_SLAVE_LATENCY
#define MYNEWT_VAL_BLE_SVC_GAP_PPCP_SUPERVISION_TMO

And it works


Bug on Login screen

Seems to be an issue with line 140 in the backend theme.js

Had a similar issue.


The server doesn't work correctly with paths that start with a number

I'm working on an implementation of tightenco/jigsaw-docs-template#31 but I found that if you have source/1.x, source/2.x etc instead of source/docs, the server will return a 404, but if you append /index.html it works.

It's not actually the leading number that's the problem, it's the period; PHP's built-in web server (which jigsaw serve launches) has a bug that messes up PATH_INFO if the final component of a URL contains a . but is not a file (see https://www.php.net/manual/en/features.commandline.webserver.php#115907 and https://bugs.php.net/bug.php?id=61286).
So, unfortunately, nothing we can do about that. You might want to use Laravel Valet for local testing, which handles directories with . in them correctly.


Reserve chunk with the shuffled rows for shuffle exchange sink

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] others

Problem Summary：

At the first time of add_rows_selective for shuffle exchange sink, it will clone chunk reserving chunk->num_rows().
If the source chunk is shuffled to too many destination chunks, each destination chunk will only contain a little rows. Therefore, if there are only several source chunk,  it will waste too much memory, especially for the concurrency of lots of small queries.
Before this PR and #3684, the CPU usage is fluctuating when there are 64 clients sending the following query concurrently.

The driver worker threads block on TCMalloc releasing and acquiring too many memories sometimes.
The ResultSink node runs on driver worker thread for multiple times, but cost only little time each round. As a result, it is moved to the low-priority level queue quickly, which causes its waiting time in ready queue is too high.

SELECT s_nation, p_category, sum(lo_revenue - lo_supplycost) AS profit
FROM lineorder_flat
GROUP BY s_nation, s_city, p_category;

The CPU usages during the concurrent queries are as follows:

After this PR and #3684, the CPU usages are as follows:

I think this PR maybe has side-effect, if we should a lot of data.

I think this PR maybe has side-effect when we shuffle a lot of data.

@kangkaisen  Sounds reasonable. The columns maybe scales and copy data when we shuffle lots of data. The time of 64 concurrent query doesn't increase. Let me test on TPC-DS, SSB, and TPC-H.


Get OpenXR with OpenGL working on SteamVR

This finally gets OpenXR with OpenGL working on SteamVR in my testing (with a Quest 2 over Air Link)!
Without this PR, you'll get:
Couldn't find usable color swap chain format, using GL_RGBA8 instead.
OpenXR: Failed to get swapchain [ XR_ERROR_SWAPCHAIN_FORMAT_UNSUPPORTED ]

It's adding back GL_SRGB8_ALPHA8 as a possible color swapchain format, which was removed in PR #71224, but it's putting it at the end of the list (rather than the start) so GL_RGBA8 will be selected if a headset/runtime supports both options. This should mean that the color issue on Pico that PR #71224 fixed will stay fixed, but it'd probably be good for @rsjtdrjgfuzkfg to double check!
It also adds GL_DEPTH_COMPONENT24 as a depth swapchain format. This won't be needed for long, because SteamVR beta has support for GL_DEPTH_COMPONENT32F and it'll end up in the non-beta version soon. But it's still a good last choice fallback, since that's the normal non-XR depth format used by Godot, and I believe it's required by the OpenGL spec to be supported, so this should cover us for any future OpenXR headsets or runtimes.

Thanks!

@rsjtdrjgfuzkfg Awesome, thanks!


Channel is fixed to one channel

Webhooks are bound to one destination channel. I don't follow how the configuration in zabbix exposes a field for "channel" but no matter what #channel I put in there, it only goes to the one the webhook is for.

i.e. i need to have slack-channel1.sh and slack-channel2.sh, unless u expose the webhook url as a config option...

You can override the channel which a message is sent to by using the body of the POST request which is sent to the web-hook, as per the example at:
https://api.slack.com/incoming-webhooks#putting_it_all_together
Try it with the script directly, like my README says:
https://github.com/ericoc/zabbix-slack-alertscript#testing
with a command such as
$ bash slack.sh '#general' PROBLEM 'Oh no! Something is wrong!'

If you can get it to work from the script directly, but it is not working from the Zabbix web UI, you have probably configured your media type or action incorrectly from within the Zabbix web interface.


2x performance improvement from better GPU kernels

NVIDIA T4 performance (g4dn.2xlarge):
N=22
	LABS finished in 0.5839 on average, min: 0.5792, max: 0.5895
	MaxCut finished in 0.5835 on average, min: 0.5790, max: 0.5872
N=24
	LABS finished in 2.4353 on average, min: 2.4193, max: 2.4506
	MaxCut finished in 2.4457 on average, min: 2.4352, max: 2.4561
N=26
	LABS finished in 11.3791 on average, min: 11.2953, max: 11.4151
	MaxCut finished in 11.3921 on average, min: 11.3866, max: 11.4027

NVIDIA A10G performance (g5.2xlarge):
N=22
	LABS finished in 0.2757 on average, min: 0.2747, max: 0.2794
	MaxCut finished in 0.2754 on average, min: 0.2748, max: 0.2775
N=24
	LABS finished in 1.1030 on average, min: 1.1013, max: 1.1103
	MaxCut finished in 1.1063 on average, min: 1.1050, max: 1.1117
N=26
	LABS finished in 4.8657 on average, min: 4.8633, max: 4.8760
	MaxCut finished in 4.8745 on average, min: 4.8725, max: 4.8827

For MaxCut with p=6, I think we beat cuaoa:
N=22
	MaxCut finished in 0.0198 on average, min: 0.0192, max: 0.0218
N=23
	MaxCut finished in 0.0391 on average, min: 0.0379, max: 0.0439
N=24
	MaxCut finished in 0.0774 on average, min: 0.0758, max: 0.0836
N=25
	MaxCut finished in 0.1527 on average, min: 0.1513, max: 0.1580
N=26
	MaxCut finished in 0.3308 on average, min: 0.3289, max: 0.3383
N=27
	MaxCut finished in 0.6547 on average, min: 0.6533, max: 0.6660
N=28
	MaxCut finished in 1.3117 on average, min: 1.3094, max: 1.3210
N=29
	MaxCut finished in 2.6454 on average, min: 2.6424, max: 2.6523

Compare to Fig 1 in https://arxiv.org/pdf/2407.13012
Their data is for NVIDIA GeForce RTX 3090 GPU, which has FP32 40 TFLOPS, and ours is for A10G, which has 31.2 TFLOPS.

All tests pass now, merging


Fix possible multiplication overflow in UnsignedInteger::from_dec_str

Fix possible multiplication overflow in UnsignedInteger::from_dec_str
Description
The method UnsignedInteger::from_dec_str uses the Mul operation when constructing the resulting Unsignedinteger, this can cause a multiplication overflow if the number in the dec string is too large.
This pr changes the code to use the mul function instead, which returns a high and low part, and returns an error if the high part is not zero.
Type of change

[ ] New feature
[x] Bug fix
[ ] Optimization

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report

Merging #528 (4964ccf) into main (4b61d6f) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   94.52%   94.51%   -0.01%
==========================================
  Files          62       62
  Lines        8964     8967       +3
==========================================
+ Hits         8473     8475       +2
- Misses        491      492       +1

Files Changed
Coverage Δ

math/src/unsigned_integer/element.rs
98.23% <80.00%> (-0.04%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix typo

Similar to https://github.com/dotnet/docs/pull/17351

Right now, any change in this repo needs to be reflected in the docs repo (if the file exists)

Yep, I could only find two files on docs with this typo. So I just did the same change here.


Move sci to if/builtins

Sub of: #656
What
Move the sci plugin from if-plugins to if/builtins
Why
This is part of our migration of our core plugins into a standard library in if/builtins.
Context
This is a core feature we want to support, so it is migrating into if.
Prerequisites/resources
no
SoW (scope of work)

[x] move plugin code into builtins/sci
[x] fix any integration issues caused by the migration
[x] migrate and fix unit tests
[x] update README documentation updated

Acceptance criteria

[x] plugin code is migrated to if-builtins
Given (Setup): The migration has been completed.
When (Action): A user or developer navigates to if
Then (Assertion): they will find a folder if/builtins/sci containing the plugin source code and a README.

[x] plugin code and unit tests pass and maintain 100% coverage
Given (Setup): The migration has been completed and a user has downloaded if.
When (Action): they run npx jest --coverage
Then (Assertion): they will receive a report showing 100% coverage and 100% passing

@manushak to do second review

@manushak to do second review

done


jlog?

Jason (@jasonmf),
I had no idea how to contact you, but I am trying this code of your to parse some lua structures. I can not find out where to get the jlog package you using for logging. Thank you for you kind help.
-r- @

Jason, do you still have your jLog module? Do you plan to change its use for something else or remove it at all?

I don't. It was mostly for debug messages. I've already started a commit to update this package. I should have it up by tomorrow night.
If you don't want to wait you could just delete all the jlog references in a local copy and then use a replace in your go.mod to point to your local copy.

Jason, thank you very much. I hope this didn't use too much of your time. I really appreciate your help.
I am learning go so some of the things, especially those who changed between the books I use and current state, confuses me a bit. I am referring to .mod, packages and their use and build.

I didn't actually provide a way to set debug logging without modifying the source. This was pure laziness and not any kind of thoughtful design.
If this PR gives you the results that you're looking for, I'm happy to merge it. I do think it should include a unit test that verifies the new behavior:
func TestTableTrailingComma(t *testing.T) {
        t.Parallel()

        testLuaData = `
<literal lua table>
`
        table, err := ParseLua(testLuaData)
        if err != nil {
                t.Fatal("Unexpected error: ", err)
        }
        // verify the contents of the table are as expected.
}

I'm not sure anyone else has ever used this library, as indicated by this being issue #1. If you want, I'd be happy to just make your fork canonical and refer the poor souls who find this one to yours. I'm content either way.


Mull browser

Mull browser is a compiled from source build of Firefox for Android with proprietary blobs removed.
It also includes a modified arkenfox.js by default.
I've maintained it since 2017: https://divestos.org/misc/ffa-dates.txt
Source code: https://github.com/divested-mobile/mull-fenix
You can download it from either my repo or the official F-Droid repo:
https://divestos.org/fdroid/official/index-v1.json, https://divestos.org/fdroid/official/us.spotco.fennec_dos_2961121.apk
https://f-droid.org/packages/us.spotco.fennec_dos/, https://f-droid.org/repo/us.spotco.fennec_dos_2952020.apk
Anything I can do that'd make it easier to add, please let me know.
Thanks

Thank you for the suggestion! I will look into it.

Any updates on Mull? I am eagerly waiting for your tests on it.

@arthuredelstein
Thank you!
:rocket:

Would really love to see mull on the test site!


Fixed passing of CosmosClientOptions

Description
cosmosCLientOptions wasn't being passed when initializing the CosmosClient. Not it will be.
Specific Changes

this.client = new CosmosClient({
    endpoint: this.cosmosDbStorageOptions.cosmosDbEndpoint,
    key: this.cosmosDbStorageOptions.authKey,
-   ...this.cosmosDbStorageOptions,
+   ...this.cosmosDbStorageOptions.cosmosClientOptions,
});

And this is CosmosDbStorageOptions (no change):
export interface CosmosDbPartitionedStorageOptions {
    cosmosDbEndpoint: string;
    authKey: string;
    databaseId: string;
    containerId: string;
    cosmosClientOptions?: CosmosClientOptions;
    containerThroughput?: number;
}

Testing
Added one test

Pull Request Test Coverage Report for Build 86038

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.158%

Totals

Change from base Build 85987:
0.0%

Covered Lines:
4920

Relevant Lines:
5535

💛  - Coveralls

Not 100% sure why the new test is failing. Investigating.

@mdrichardson can you prepare a PR against the 4.6 branch?


Release 3.5.0

Please fast-forward merge and include the v3.5.0 tag from my repo; or otherwise generate a new gpg-signed tag.

@bastelfreak  your opinion on calling this v3.5.0 vs v4.0.0?
The changelog autogenerator said it was a "breaking change" based on your PR tags on https://github.com/voxpupuli/hiera-eyaml/pull/351
However under Semantic Versioning rules, I don't think it actually fits:
https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
The API did NOT change, only the dependency did, so it's a minor bump, not a major bump

@bastelfreak bump; re what version should this be called; it's not really breaking changes, but I can bump it to 4.0.0 if you want anyway.

next release hast to be 4.0.0 because there are backwards incompatible changes. I raised a new PR at https://github.com/voxpupuli/hiera-eyaml/pull/381


Add cron attribute to to loadFlow endpoint

It's nice to have returned also the cron schedule at /schedule?ajax=loadFlow endpoint.
Example response then:
{
"items": [
    {
        "cron": "0 */12 */2 ? * *",
        "projectname": "project_name",
        "period": 0,
        "stats": {
            "average": 0,
            "min": 0,
            "max": 0
        },
        "length": 3600000,
        "flowname": "agency_bill_counter_back",
        "time":<PHONE_NUMBER>725,
        "history": false,
        "scheduleid": 2
    },
    {
        "cron": null,
        "projectname": "ahoj",
        "period": 86400000,
        "stats": {
            "average": 0,
            "min": 0,
            "max": 0
        },
        "length": 3600000,
        "flowname": "wallet_deductor",
        "time":<PHONE_NUMBER>000,
        "history": false,
        "scheduleid": 3
    }
]

}

Sure, it's attached in the first comment :) .. it's just "cron": null, which is valid JSON

@jirislav Thanks a lot for contributing. Merging.