issue 1089

Description
Drawing random shapes
Fixes #1089

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ✔] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Documentation Update

Checklist:

[✔ ] My code follows the style guidelines(Clean Code) of this project
[✔ ] I have performed a self-review of my own code
[ ✔] I have commented my code, particularly in hard-to-understand areas
[ ✔] I have created a helpful and easy to understand README.md
[ ✔] My documentation follows Template for README.md
[ ✔] I have added the project meta data in the PR template.
[ ✔] I have created the requirements.txt file if needed.

Project Metadata
If there is no-file/nothing to fill the below fields with, then type: none
Example: If no requirements.txt needed/present, then type none in Requirments.
Category:

[ ] Calculators
[ ] AI/ML
[ ] Scrappers
[ ] Social_Media
[ ] PDF
[ ] Image_Processing
[ ] Video_Processing
[ ] Games
[ ] Networking
[ ] OS_Utilities
[ ] Automation
[ ] Cryptography
[ ] Computer_Vision
[✔ ] Fun
[ ✔] Others

Title: LineSketch.py
Folder: LineSketch
Requirements: <type the name of text file containing the required to install python packages, type None if no file required>
Script: LineSketch.py
Contributor: anumshka

PR template wrongly updated. Check approved PRs for better understanding


Theme inheritance not working?

Has anybody had success inheriting from this theme?  I have set things up accordingly but continually receive this error:
/var/www/vhosts/site.com/user/themes/mytheme/mytheme.php
<?php
namespace Grav\Theme;

class Mytheme extends Xcorporation
{
   // Some new methods, properties etc.
}
?>

Arguments
"Class 'Grav\Theme\Xcorporation' not found"

Wondering if the error has something to do with the hyphen in x-corporation?  Possibly related: https://github.com/getgrav/grav/issues/1353

Just to confirm I renamed the x-corporation files to just xcorporation and things now work as expected.  Seems to be a bug in Grav itself (likely the one referenced above).


[SPARK-9270] [PySpark] allow --name option in pyspark

This is continuation of #7512 which added --name option to spark-shell. This PR adds the same option to pyspark.
Note that --conf spark.app.name in command-line has no effect in spark-shell and pyspark. Instead, --name must be used. This is in fact inconsistency with spark-sql which doesn't accept --name option while it accepts --conf spark.app.name. I am not fixing this inconsistency in this PR. IMO, one of --name and --conf spark.app.name is needed not both. But since I cannot decide which to choose, I am not making any change here.

Merged build triggered.

Merged build started.

Test build #38189 has started for   PR 7610 at commit 190638b.

That seems fine if it still sets the app name as desired and improves consistency.

Test build #38189 has finished for   PR 7610 at commit 190638b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #38224 has started for   PR 7610 at commit 190638b.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

retest this please.

Merged build triggered.

Merged build started.

Test build #38232 has started for   PR 7610 at commit ccef949.

Note that --conf spark.app.name in command-line has no effect in spark-shell and pyspark. Instead, --name must be used.

This is not critical, but not great either; it points at some inconsistency in the code somewhere. From looking at SparkSubmit.scala, it should work, but I haven't explicitly tested it.

spark-sql which doesn't accept --name

Is that true? SparkSQLEnv has code to explicitly handle app names set by the user. It that doesn't work, it sounds like a bug.

Test build #38224 has finished for   PR 7610 at commit 190638b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@vanzin thank you for your comments!

As for spark-sql, sorry I was wrong. spark-sql works with both --name and --conf spark.app.name. So we're good here.

As to why --conf spark.app.name doesn't work in pyspark, if you look at context.py, line #135 overwrites spark.app.name in conf if appName is passed via a constructor parameter.

So if you run the following cmd-
pyspark --conf spark.app.name=MyName

It invokes the following cmd b/c --name PySparkShell is added by default-
spark-submit --name PySparkShell --conf spark.app.name=MyName

Since PySparkShell ends up being passed as a parameter to the SparkContext constructor, it overwrites spark.app.name. So when we get to line #153 later, spark.app.name is no longer MyName but PySparkShell.
In summary, --name always wins and is always added to the cmd. So --conf spark.app.name never takes effect.

So the Python part is OK but now does spark-sql need a similar treatment?

@srowen spark-sql actually already works with both --name and --conf spark.app.name. I was mistaken earlier.
In short, --name works with every one (spark-shell, spark-sql, pyspark) while  --conf spark.app.name only works with spark-sql.

Test build #38232 has finished for   PR 7610 at commit ccef949.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

Hmm, jenkins unstable?

Merged build triggered.

Merged build started.

Test build #38256 has started for   PR 7610 at commit 763e86d.

As to why --conf spark.app.name doesn't work in pyspark, if you look at context.py, line #135

Hmm, it may not work, but I don't think that's the cause. With your changes, that line should never be reached when starting the shell. What I think is happening is:

SparkSubmit sets the app name in SparkSubmit.scala, L470 (processing the option defined in L405).
In SparkSubmit.scala L555, the conf is read but at that point spark.app.name is already set, so it's not overwritten.

So it seems like an ordering issue in SparkSubmit.scala. In any case, it doesn't seem important enough to change just for this particular edge case. The change LGTM.

Test build #38256 has finished for   PR 7610 at commit 763e86d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged to master. Thanks!


code for dpo leading to a drop in activations for the toxic vectors

I didn't find the code for dpo that you research in your paper in this repo, could you please give me a link for that? I would be highly appreciate for that.

Are you referring to this? https://github.com/ajyl/dpo_toxic/blob/main/toxicity/figures/activation_drop.sync.ipynb

thank you very much. it's my negligence that I didn't look up this folder


Write Task List component guidance

What/Why
Write guidance for the new task list component. This issue also includes updating guidance for the tag component and deciding what to do with the existing Task List pattern guidance.
Who needs to work on this
Community members
Who needs to review this
Content designers
Done when

[ ] Draft Task List component guidance
[ ] Update Tag component guidance
[ ] Decide what to do with existing Task List pattern

Task list guidance PR: https://github.com/alphagov/govuk-design-system/pull/1994
Tag guidance PR: https://github.com/alphagov/govuk-design-system/pull/2733

Closed by https://github.com/alphagov/govuk-design-system/pull/1994 🙌


Error in example 2?

https://github.com/shuveb/io_uring-by-example/blob/8d069f07e8b00e352f22b54d2751e69678771ce4/02_cat_uring/main.c#L222
fi->iovecs->iov_base looks wrong to me. It's equivalent to fi->iovecs[0].iov_base, but shouldn't it be fi->iovecs[i].iov_base? Won't this corrupt any file longer than 4KB?

That was very sharp! Thanks for catching that @josephcsible. Fixed and pushed.


New Demo - Monkey BMI Data

New demo based on the Tensor Toolbox: https://gitlab.com/tensors/tensor_data_monkey_bmi.

Congrats - first PR! 🎉

Merging - great job @bakergg!


20190622.pdf of S03E04 does not display properly

@newip, please check it, thanks.

代码看不出问题，点击下载可以看。但直接窗口中是看不来。有什么可以尝试的方向？

@newip You can try to regenerate the pdf file using Adobe Acrobat DC and then try it out. I suspect the reason ViewerJS did not display correctly is the no standard content in the pdf file.

The download button is ok. But the content displays not ok. Right now, the 1st pdf viewer does not work either.

The URL link for the pdf causes the error, I fix it by reference to the seminar-3-1 file.

[x] Checked PDF display ok now


[WCT] Browser Version mistake, when LAUNCHPAD variables are set

If the environment variable e.g. LAUNCHPAD_CHROME is set (windows), it fails to look up the version number of chrome.
E.g.:
LAUNCHPAD_CHROME="C:\Program Files (x86)\Google\Chrome\Application\"

error: [cli.main]   cli runtime exception: TypeError: Cannot read property 'match' of undefined
error: [cli.main]   TypeError: Cannot read property 'match' of undefined
    at chrome (C:\Users\Knecht Ruprecht\AppData\Roaming\npm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:110:36)
    at Object.<anonymous> (C:\Users\Knecht Ruprecht\AppData\Roaming\npm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:84:38)
    at Generator.next (<anonymous>)
    at fulfilled (C:\Users\Knecht Ruprecht\AppData\Roaming\npm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

problems are caused by this function:
/**
 * @param browser A launchpad browser definition.
 * @return A selenium capabilities object.
 */
function chrome(browser, browserOptions) {
    return {
        'browserName': 'chrome',
        'version': browser.version.match(/\d+/)[0],
        'chromeOptions': {
            'binary': browser.binPath,
            'args': browserOptions || ['start-maximized']
        }
    };
}

The browser-Object does not contain a version entry.

A simular issue exists for firefox. Setting launchpad-envirnment-variables (espeacially the paths of the browsers) could speed up the initial load time for running tests, see: https://github.com/bitovi/launchpad/issues/51

Try using forward slashes instead?

@jsilvermist No, this is just an example in markdown and not how it actually looks like. Fixed the example:
LAUNCHPAD_CHROME="C:\Program Files (x86)\Google\Chrome\Application\"

I have the same issues... it's really hard to get a proper test setup with Polymer wct structure. Is there a fix for this already?


Provincial (ON) tax brackets incorrectly set

https://www.canada.ca/en/revenue-agency/services/tax/individuals/frequently-asked-questions-individuals/canadian-income-tax-rates-individuals-current-previous-years.html?wbdisable=true

From link above:
5.05% on the first $42,960 of taxable income, +9.15% on the next $42,963, +11.16% on the next $64,077, +12.16% on the next $70,000, +13.16 % on the amount over $220,000
5.05% - 0==>42,960
9.15% - 42,960==>85,923
11.16% - 85,923==> 150,000
12.16% - 150,000==>220,000
13.16% - 220,000==> Inf.

@kamalsaleh2 these numbers are for 2018

@JackNeto I thought we were using 2018 numbers because the Federal numbers we currently show are for 2018. We need to be consistent there.
2018 - Federal + Provincial: https://www.canada.ca/en/revenue-agency/services/tax/individuals/frequently-asked-questions-individuals/canadian-income-tax-rates-individuals-current-previous-years.html?wbdisable=true
2017-Federal: https://www.canada.ca/en/financial-consumer-agency/services/financial-toolkit/taxes/taxes-2/5.html

I think we currently have the 2016 numbers, but because for this year people are still filing taxes we still need the numbers for 2017 but I'll also add the 2018 ones and provide a way to change the Tax year

Federal is currently using 2018 numbers (unless I'm looking at the wrong place, or 2018=2016 fed. taxes


Playing an audio stream from a pipe does not close properly.

If an input stream piped to the audio player ends, the audio player does not end and no finish event is emitted. Probably need to call stream.end() when we're done.

Fixed in recent refactor by @scriptorian - good work!


Guard pages for fiber stacks

Our custom malloc for fiber stacks do not include guard pages, so a stack overflow may result in a corrupted program.

Related #61.

Fixed by #169.


Add missing error types to raise_error matcher

Resolve the following warning on bundle exec rspec spec/lib/danger/request_sources/bitbucket_cloud_api_spec.rb.
WARNING: Using the `raise_error` matcher without providing a specific error or
message risks false positives, since `raise_error` will match when Ruby raises a
`NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the
expectation to pass without even executing the method you are intending to call.
Actual error raised was #<WebMock::NetConnectNotAllowedError: Real HTTP
connections are disabled. Unregistered request: GET h... => 200, :body => "",
:headers => {})

============================================================>. Instead consider
providing a specific error class or message. This message can be suppressed by
setting: `RSpec::Expectations.configuration.on_potential_false_positives =
:nothing`. Called from
/Users/rito/Projects/danger/danger/spec/lib/danger/request_sources/bitbucket_cloud_api_spec.rb:104:in
`block (3 levels) in <top (required)>'.

Thanks!


Type-only imports and exports

Counterpart of https://github.com/microsoft/TypeScript/pull/35200. Do not merge until that one has been.
Warning: my RegExp-fu is middling at best. This produces correct results for the cases I tested, but experts should review with scrutiny 😁

@andrewbranch I pushed a change to this that matches type locally instead of having to do look behind..


Gcc 13

These are a couple of fixes to problems building on the latest fedora rawhide which just upgraded to gcc 13

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 65.508%

Files with Coverage Reduction
New Missed Lines
%

libraries/plugins/xfpga/open.c
1
74.68%

libraries/plugins/xfpga/mmio.c
6
82.87%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
13133

Relevant Lines:
20048

💛  - Coveralls


feat: add a regression test

Added a regression_test to test changes in ndt_omp.
The data for a standard regression test is currently shared internally. I plan to publish it someday.
Evaluation perspective
The speed is almost the same compared to previous results.

Accuracy must match the previous results completely or to some extent
elapsed_milliseconds_ratio_mean=0.969 (current / reference)
The scores are perfectly the same.
OK

Main files added

python script to build pcd and ekf_pose pair from rosbag
cpp code to execute align
python script to compare two results

The speed is almost the same compared to previous results.
What is "the speed"? Processing time? If so, could you let us know what to measure time from and to?

@Motsu-san
Speed means the average processing time of the align function.
https://github.com/tier4/ndt_omp/pull/33/files#diff-26c50a24f97f4a3d9417c081618754353b5cb41c783c13348a71005e63d6dc58R114-R117


help updating ncnn benchmark data on raspberrypi

hi
The raspberrypi 4 data in ncnn benchmark is very old[0], and the latest ncnn is faster than before.
I've tested ncnn on raspberrypi 3b+ and got new benchmark data [1]
But I have no other raspberrypi devices for updating info.
Could you please help updating them ?
[0] https://github.com/Tencent/ncnn/blob/master/benchmark/README.md#raspberry-pi-4-model-b-broadcom-bcm2711b0-cortex-a72-armv8-15ghz-x-4
[1] https://github.com/Tencent/ncnn/blob/master/benchmark/README.md#raspberry-pi-3-model-b-broadcom-bcm2837b0-cortex-a53-armv8-14ghz-x-4
step 0 install 64bit os on devices
step 1 shutdown graphics stack
on Linux (with root)
init 3

or
systemctl isolate multi-user.target

on Android (with root)
adb root
adb shell stop

step 2 set cpu performance mode
on Linux / Android (with root)
echo "performance" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
echo "performance" > /sys/devices/system/cpu/cpu1/cpufreq/scaling_governor
echo "performance" > /sys/devices/system/cpu/cpu2/cpufreq/scaling_governor
echo "performance" > /sys/devices/system/cpu/cpu3/cpufreq/scaling_governor

step 3 git clone the latest ncnn source, build benchncnn, and run
git clone https://github.com/Tencent/ncnn.git
cd ncnn
mkdir build && cd build
cmake ..
make -j4 benchncnn

benchmark with 4 threads
./benchncnn 8 4 0 -1 1

benchmark with 1 thread
./benchncnn 4 1 0 -1 1

step 4 (optional) restore graphics stack
on Linux (with root)
init 5

or
systemctl isolate graphical.target

on Android (with root)
adb root
adb shell start

step 5 collect benchmark data and open pull request to ncnn project :smile:
Thanks!

Halfway

Done. Sorry, wrong button. I didn't made a pull request but a issue.

Thanks !
I will investigate the jetson nano crash you mentioned

I have updated the ncnn benchmark data
btw, in https://github.com/nihui/ncnn-small-board too


Test for the forward-backward method based on analytical solution

Write a test function for both the forward and backward method(s) using the Halfar solution (see equation 39).

As discussed in the last weekly meeting, this should be the main goal for next week.

@facusapienza21: here's an example of continuous integration applied to a similar model: https://github.com/DJ4Earth/dJUICE/blob/main/.github/workflow/ci.yml


I wonder where I can use build_database.py?

Thanks for reading my quetion.
I want to make sqlite for my sentinel-1 image
so I'm trying follow your steps
but I can not find where is build_database.py

Sorry for the out of date instructions. The updated readme should help, you just have to install it and run opera-db create

Thank you sir
As you mentioned, If I downloaded the conda-forge package, I can use
"opera-db"??
but there isn't "opera-db" command
please let me know sir!
2024년 1월 19일 (금) 오전 9:09, Scott Staniewicz @.***>님이 작성:

Sorry for the out of date instructions. The updated readme should help,
you just have to install it and run opera-db create
—
Reply to this email directly, view it on GitHub
https://github.com/opera-adt/burst_db/issues/24#issuecomment-1899416328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBYKFJWGD3FHYSDOD5KPQO3YPG2ULAVCNFSM6AAAAABB73R43KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGQYTMMZSHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Just clarifying that this isn't on conda forge or pypi- it would have to be installed locally to make by cloning then running pip install .

Thank you sir!
Can I ask you one more question?
< I already questioned you like below on opera-adt compass >
I want to make a CSLC image in my interest region
so I try to make " s1_cslc_geo.yaml " ---picture 1
but I got a error. I guess the reason is due to burst_database_file missing
--picture 2
So I try to do " burst_db " that you gave us. I finished doing "
opera-db-create " --picture3
but I don't know how to use them files that I made after doing "
opera-db-create "
Could you answer me ① how to make a " burst_database_file "
and If my way is correct, ② how to make a "burst_database_file in "
burst_db in github "
2024년 1월 20일 (토) 오전 12:01, Scott Staniewicz @.***>님이 작성:

Just clarifying that this isn't on conda forge or pypi- it would have to
be installed locally to make by cloning then running pip install .
—
Reply to this email directly, view it on GitHub
https://github.com/opera-adt/burst_db/issues/24#issuecomment-1900583686,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BBYKFJSHXADIGRAIBQ7CS2DYPKDFHAVCNFSM6AAAAABB73R43KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBQGU4DGNRYGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


add release build

replaces patch in build script
relies on ifdef RELEASE to workaround the phobos-latest cloning

This is breaking the -prerelease DDoc build: http://dtest.dlang.io/artifact/website-a3969403905ee92ff9918dd70fae1e2f4ef25e9b-9cc12822dc7bea2dd875841e1f1f3a12/web/phobos-prerelease/ddmd_access.html
Looks like it's now using the default DDoc template.

Looks like it's now using the default DDoc template.

Fixed, oversight of an STD_DDOC_PRE in DDOC_HTML_VARS.

Thanks!
I believe this needs a corresponding tools PR to update the d-tags.json usage there. Should I make one or will you?

Here is the tools PR https://github.com/dlang/tools/pull/265, get's rid of another build script patch.

Removed the empty commit, rebased and force-pushed, s.t. we are sure that this is still passing on DAutoTest.


Suggestion: Support modded wood types

I'm currently using Terrestria, Traverse, Ecologics and Improved End and these have their wood types, with their respective Wooden Door and Trapdoors.
If help is needed for new textures, I can draw new textures for these if you plan to add support.

Hi there!
After considering your proposal, I have decided to try it out. If you could draw up the new textures, that would be much appreciated. Despite this, please do not start working on them yet, as I don't have a guarantee this will get done.
Why? I am not an actual mod developer, nor an at all experienced java developer, and without the help of other ReviversMC devs, I might not be able to pull it off, and they may not be available at the moment.
I will make sure to update you with any progress that is made.


⚠ Bofrost.be has degraded performance

In ec5bfa3, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1278 ms

Resolved: Bofrost.be performance has improved in 23e1735.


react/jsx-no-target-blank should allow noreferrer when allowReferrer is true

The spec says that noreferrer implies noopener, so it should always suffice to write just rel="noreferrer".
However, if you configure rule react/jsx-no-target-blank to allowReferrer, then links with rel="noreferrer" specified fail, even though it's equivalent to rel="noreferrer noopener".
Confusingly, the error message says Using target="_blank" without rel="noreferrer" is a security risk which makes it particularly tricky to figure out what's going on.  (In my case, I forgot that I'd turned on allowReferrer.)  I imagine it's not possible to configure the error message depending on the configuration?
Related discussion in #2054.

I think configuring the error message should be trivial; as for allowing noreferrer to exist alone, that was very intentionally disallowed, but was relaxed in #2043.


have some UI bugs in macOS 10.14.6 's Dark Mode

have some UI bugs in macOS 10.14.6 's Dark Mode
like this

Fixed by #17


Tighten up action button sizing/padding in compact grids

Fixes #1287

Hoist P/R Checklist
Review and check off the below. Items that do not apply should be checked to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

[x] Up to date with develop branch as of last change.
[x] Ready for review (or add wip label).
[NA] Added CHANGELOG entry (or N/A)
[NA] Checked for breaking changes (add breaking-change label + CHANGELOG if so, or N/A)
[NA] Updated doc comments / prop-types (or N/A)
[NA] Reviewed and tested on Mobile (or N/A)
[NA] Created Toolbox branch / PR (link provided here, or N/A)

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases.

Not promising this is as clean / dynamic as it could be, but wanted to get a fix in as I saw what you meant.  Take a look and let me know if you think this will work?

Styling looked good, but noticed it didn't update if compact was changed at runtime, presumably because it would require refreshing the cells via the ag-grid api to force a re-render. Changed things around to just use css to apply the new styling, and also added css to make the icons slightly smaller as well in compact mode which I think makes it look a little more consistent with the other grid text. Let me know what you think about the icon, and whether you think there are any issues with just doing this entirely in css?

Great catch thanks - didn't notice that somehow - the differences were pretty subtle but still definitely worth it.  Thanks for figuring out how to tweak the icon itself.  Merging now. 👍


Increment version for "Added created timestamp and last modified timestamp on Dashboard"

Summary of Changes
Increment version for "Added created timestamp and last modified timestamp on Dashboard"

@jinhyukchang I am currently testing https://github.com/lyft/amundsendatabuilder/pull/210 on tars airflow. Could we wait for my change as well assume we don't need to bump the version immediately?

@jinhyukchang I am currently testing #210 on tars airflow. Could we wait for my change as well assume we don't need to bump the version immediately?

Yep, no hurries.

assume this is not needed :)


interface mocking

Is your feature request related to a problem? Please describe.
A quick guide for interface mocking is needed
Describe the solution you'd like
type Fooer interface{
	Foo(string) string
}

type A struct{}

func (a A) Foo(in string) string { return in }

func UseFoo(f Fooer) string {
        // something
        return f.Foo("")
}

func TestMockXXX(t *testing.T) {
	PatchConvey("TestMockXXX", t, func() {
                Mock(Fooer.Foo).Return("c").Build() // something like this is needed

		So(UseFoo(A{}), ShouldEqual, "c") // assert `Fooer.Foo` is mocked
	})
}

Describe alternatives you've considered
func TestMockXXX(t *testing.T) {
	PatchConvey("TestMockXXX", t, func() {
                MockInterface(Fooer.Foo).Return("c").Build() // something like this is needed

		So(UseFoo(A{}), ShouldEqual, "c") // assert `Fooer.Foo` is mocked
	})
}

Additional context

for now GetNestedMethod seems to work, but not elegant.
I know I can do interface insertion, but this Mock func is just so good, I want to use it the same way.

Mock(Fooer.Foo).Return("c").Build() means 'mock every implements of the Fooer interface', right?

yes that will be expected.
In case there are same interface in a structure for example
type A struct {
   X Fooer
   Y Fooer
}

Mock(A.X.Foo) may be a neat way.

Is your feature request related to a problem? Please describe.
A quick guide for interface mocking is needed
Describe the solution you'd like
type Fooer interface{
	Foo(string) string
}

type A struct{}

func (a A) Foo(in string) string { return in }

func UseFoo(f Fooer) string {
        // something
        return f.Foo("")
}

func TestMockXXX(t *testing.T) {
	PatchConvey("TestMockXXX", t, func() {
                Mock(Fooer.Foo).Return("c").Build() // something like this is needed

		So(UseFoo(A{}), ShouldEqual, "c") // assert `Fooer.Foo` is mocked
	})
}

Describe alternatives you've considered
func TestMockXXX(t *testing.T) {
	PatchConvey("TestMockXXX", t, func() {
                MockInterface(Fooer.Foo).Return("c").Build() // something like this is needed

		So(UseFoo(A{}), ShouldEqual, "c") // assert `Fooer.Foo` is mocked
	})
}

Additional context

for now GetNestedMethod seems to work, but not elegant.
I know I can do interface insertion, but this Mock func is just so good, I want to use it the same way.

can't agree more! and how is the feature going? @ycydsxy

+1

+1

+1

+1

+1, we meet another problem related to interface mocking: If a public interface has a private struct to implement it, the method of the interface can not be mocked.
package packageA

type Fooer interface {
    Foo(string) string
}

type fooer struct {}

func (f *fooer) Foo(in string) string {
    return in
}

func GetFooer() Fooer {
    return &a{}
}

in another package:
package packageB
func TestFoo(t *testing.T) {
    PatchConvey("TestFoo", t, func(){
        // fooer is not an exported struct, can't mock like this
        // Mock((*fooer).Foo).Return("b").Mock()
        out := packageA.GetFooer().Foo("a")
        So(out, shouldEqual, "b")   // test failed
    })
}

@RicardoAGu
Here is a way to mock with signature:
target := GetMethod(GetFooer(), "Foo")
hook :=  reflect.MakeFunc(target, ... ).Interface() // build hook with MakeFunc, use reflect.Value as params
Mock(target).To(hook)

If you don't need the method's signature, you can just simply remove it like this:
Mock(GetMethod(GetFooer(), "Foo")).To(func (string) string {xxx} )


New vs. old icons

I just noticed that the latest version of the Materialize framework recommends using Google's CSS icons instead of the ones Materialize has used for a while. Even though Google seems to have more icons, and of course they are official, but they seem to have a lot of problems with Materialize.
For example, take a look at the old (first two) vs. new icons (third) on sideNav:

The latest version of the framework still seems to have the old icons, is it possible to add the list of old icons (and syntax) back to the website as an alternative to Google's icons? I could make a commit with the changes if needed.

They are trying to phase out the use of the old icons gradually. So, not
having them in the documentation is a step towards that direction.
On Sat, 27 Jun 2015 04:47 Corbin Davenport<EMAIL_ADDRESS>wrote:

I just noticed that the latest version of the Materialize framework
recommends using Google's CSS icons instead of the ones Materialize has
used for a while. Even though Google seems to have more icons, and of
course they are official, but they seem to have a lot of problems with
Materialize.
For example, take a look at the old (first two) vs. new icons (third) on
sideNav:
[image: capture]
https://cloud.githubusercontent.com/assets/3879063/8390346/5a0f8b28-1c5d-11e5-8351-5bed27132ca7.PNG
The latest version of the framework still seems to have the old icons, is
it possible to add the list of old icons (and syntax) back to the website
as an alternative to Google's icons? I could make a commit with the changes
if needed.
—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/1606.

The new icons should work the same way, try adding left to the icon class
On Sat, Jun 27, 2015 at 4:37 AM, Carlos<EMAIL_ADDRESS>wrote:

They are trying to phase out the use of the old icons gradually. So, not
having them in the documentation is a step towards that direction.
On Sat, 27 Jun 2015 04:47 Corbin Davenport<EMAIL_ADDRESS>wrote:

I just noticed that the latest version of the Materialize framework
recommends using Google's CSS icons instead of the ones Materialize has
used for a while. Even though Google seems to have more icons, and of
course they are official, but they seem to have a lot of problems with
Materialize.
For example, take a look at the old (first two) vs. new icons (third) on
sideNav:
[image: capture]
<
https://cloud.githubusercontent.com/assets/3879063/8390346/5a0f8b28-1c5d-11e5-8351-5bed27132ca7.PNG
The latest version of the framework still seems to have the old icons, is
it possible to add the list of old icons (and syntax) back to the website
as an alternative to Google's icons? I could make a commit with the
changes
if needed.
—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/1606.

—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/1606#issuecomment-116017123
.

--
Doggy sends his greetings from Mars.

Excuse me, just for clarification: So are the "old" Icons (delivered via embedded Material-Design-Icons fonts) are deprecated by now? Will they be removed in newer releases?
Thanks for short feedback
Tom

Hi, I came along with an additional question which was coming up during discussion at meteor package integration of materializecss
https://github.com/poetic/meteor-materialize-sass/issues/5
Instead of implementing the usage of offline Material-Icons font like described at:
https://google.github.io/material-design-icons/
wouldn't it be the correct way to directly implement those fonts to materializecss itself like the Roboto fonts as well?
If you reply with your suggestion I can create a PR for the project if you like.
Cheers
Tom

I moved my original comment from here to a new issue

The old icons are now removed from the repo and you should import the ones from google if you wish to use material icons.


[Bug] MessageFormatter makes the response body empty

Guzzle version(s) affected:  7.2.0
PHP version: 8.0.2
cURL version: 7.74.0
Description
When use the template {response} for the MessageFormatter with the built-in logger midleware Middleware::Log, the response body becomes empty.
How to reproduce
<?php

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Request;

$client   = new Client();
$request  = new Request('GET', 'https://jsonplaceholder.typicode.com/todos/1');
$response = $client->sendRequest($request);

$formatter = new \GuzzleHttp\MessageFormatter('{response}');
$message   = $formatter->format($request, $response);

if ($response->getBody()->getContents() === '') { // WTF???
    echo 'empty body' . \PHP_EOL;
    echo $message . \PHP_EOL;
}

Possible Solution
Rewind the stream at retrieving response content.

I know this is super weird, however, it is not wrong. getContents() says: "Print the rest of the stream". You are making an assumption that the stream pointer is at the beginning. There is no place where PSR7 or Guzzle promise the position of the pointer.
You should always use $response->getBody()->__toString()

Oh. Sory. Then I close the issue.

No worries. As I said: This is weird and super confusing.


[#152] Store blog home page on insert/update

Coverage increased (+0.9%) to 64.949% when pulling c9497ad69e214f58da8a9dea67815f0f0e194bc1 on cslysy:issues/#152 into 8ac8efd96602ab0227f271bd59fdf3487e143a92 on tdziurko:master.

Coverage increased (+1.1%) to 65.126% when pulling fba858832088dd4aab71c7277af4af8831faea76 on cslysy:issues/#152 into 8ac8efd96602ab0227f271bd59fdf3487e143a92 on tdziurko:master.


Unilever - Missing Location and Job type for the job "Area Sales Manager West Romania"

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro
Browser: Microsoft Edge
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in the browser
Run Scraper for "Unilever" Company
Check the location and job type for the "Area Sales Manager West Romania" job
Open "Vezi Postul" and check the location and job type for the "Area Sales Manager West Romania" job

EXPECTED RESULTS:
The Job type is "Remote" as on the company website
ACTUAL RESULTS:
Missing Location and Job Type for the job "Area Sales Manager West Romania"
On http://solr.peviitor.ro/ the city and county of the job is "false" instead of "Bucharest" as on the company's website

Deprecated....


Background is squeezed and zoomed in

The camera video capture does not scale to the screen's ratio correctly.

Fixed it!


Create Index Skeleton Page

Create the skeleton for the main page with placeholders for text segments.

Done!


save error: Cannot find module './dialog'

Since the latest upgrade I can't save any files.  I get the error Cannot find module './dialog' in the console log.  For some reason I don't get the atom error popup and there is nothing to indicate where the error really comes from.
ubuntu 14.0.4
v 1.8.12
atom 1.0.2

I don't see a reason in the latest commits as to why that would happen.
As far as I know, the dialog class or its usage haven't been changed in a while.
Did you get a stacktrace or any other info in the console?
I hate to ask, but have you tried reinstalling the package?

Did you get a stacktrace or any other info in the console?

No.  It looks like this and nothing can be expanded ...
[image: Inline image 1]

I hate to ask, but have you tried reinstalling the package?

Yes.
On Wed, Jul 15, 2015 at 5:38 PM, Sverre Aleksandersen <
<EMAIL_ADDRESS>wrote:

I don't see a reason in the latest commits as to why that would happen.
As far as I know, the dialog class or its usage haven't been changed in a
while.
Did you get a stacktrace or any other info in the console?
I hate to ask, but have you tried reinstalling the package?
—
Reply to this email directly or view it on GitHub
https://github.com/sveale/remote-edit/issues/97#issuecomment-121789962.

I've just published v1.8.13 that should fix the issue.
Can you try it out and let me know?

Save works now.
BTW, Is the dialog asking if you want to upload new?  Can I turn it off?  I
hit ctrl-s constantly (old muscle memory).
On Wed, Jul 15, 2015 at 5:54 PM, Sverre Aleksandersen <
<EMAIL_ADDRESS>wrote:

I've just published v1.8.13 that should fix the issue.
Can you try it out and let me know?
—
Reply to this email directly or view it on GitHub
https://github.com/sveale/remote-edit/issues/97#issuecomment-121792702.

Actually, after I published the change, I discovered that the Dialog class isn't actually used there (atom.confirm is). It's been there for a long while (> several months).
You can go to the settings page and check "Upload on save". When enabled this automatically pushes changes to remote. If it is disabled, you'll be queried each time you hit ctrl-s.


Adding participant visualization methods

This PR adds the following participant-level viz methods:

passive - shows the amount of data collected hour-by-hour over a customizable period of time
active - shows the number of activities collected day by day
cortex_tertiles - allows visualization of (some) cortex data sorted into tertiles

In addition, a set_graph method is added to useful_functions to make it easier to set graphs on participants and make them visible across LAMP.

Changed create_sample_window params to 'end_of_window' and 'sample_length', making the change in useful_functions.get_activity_names as well. Also made 'display_on_patient_portal' and 'set_on_parents' parameters default to false to allow this function to easily be used as a wrapper for LAMP.set_attachment() for other visualization graph code.


[$500] Assign Task - Task completion and reopening notification not translated in Share Somewhere section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on the plus sign and select "Assign Tasks".
Add a title, assignee, and share somewhere, then confirm the task.
Go to settings > preference > change language to Spanish.
Click on the plus sign again and select "Assign Tasks" > Title > Search for the email you assigned the task to in the Share Somewhere section

Expected Result:
The task completion and reopening notification should be translated in the Share Somewhere section as per user preference, just like in LHN and Assigned Task
Actual Result:
The task completion and reopening notification are not translated in the Share Somewhere section, causing inconsistency in language usage
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[x] MacOS / Desktop

Version Number: 1.3.56-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/46f8ab64-31e2-4a2a-9e94-8445a414f17e
https://github.com/Expensify/App/assets/78819774/f5288e6b-abf5-475b-bea3-223819d69865
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691775469383549
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016eac5381208cd4cb
Upwork Job ID:<PHONE_NUMBER>550611968
Last Price Increase: 2023-09-11

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task completion and reopening notification not translated in Share Somewhere section
What is the root cause of that problem?
The translation for complete task and re-open task work well in LHN because we have logic to update alternativeText in getOptionData for LHN options
https://github.com/Expensify/App/blob/08b75f39d32ab5ecfa1577ebdbb79c3fb24797fb/src/libs/SidebarUtils.js#L300-L304
But when creating option for share destination, we don't have any logic to update the translation like we did in LHN
What changes do you think we should make in order to solve the problem?
I suggest that when creating option for share destination, we should update translation if the last actionName is complete task or reopen task (It seems we miss translate cancelled task message in LHN)

we need to translate cancelled task in LHN

https://github.com/Expensify/App/blob/08b75f39d32ab5ecfa1577ebdbb79c3fb24797fb/src/libs/SidebarUtils.js#L300-L304
add condition:
else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED) {
                result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.canceled')}: ${report.reportName}`;
            }

Update complete task, reopen task and cancel task in share destination options
In here: https://github.com/Expensify/App/blob/08b75f39d32ab5ecfa1577ebdbb79c3fb24797fb/src/libs/OptionsListUtils.js#L505
we should add

if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport)) {
            const lastAction = visibleReportActionItems[report.reportID];
            if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
                const newName = lodashGet(lastAction, 'originalMessage.newName', '');
                result.alternateText = Localize.translate(preferredLocale, 'newRoomPage.roomRenamedTo', {newName});
            } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED) {
                result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.reopened')}: ${report.reportName}`;
            } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) {
                result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.completed')}: ${report.reportName}`;
            } else if (lodashGet(lastAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED) {
                result.alternateText = `${Localize.translate(preferredLocale, 'task.messages.canceled')}: ${report.reportName}`;
            }
}

With this approach, we need to define visibleReportActionItems as we did in SidebarUtils.
We also can consider to create utils function to update alternative text to avoid duplicated code
Result

Proposal
Please re-state the problem we are trying to fix
For task reports, actions like reopening and completing are not translated to Spanish in share options but are translated in LHN, therefore, an inconsistency.
Disclaimer: This proposal is a little lengthy because I went into a lot of detail for the explanation please be sure to ask about any part that might be doubtful, I will be happy to explain it further.
What is the root cause of the problem?
When creating the options to display in RHP, we are using the report.lastMessageText property which (for task actions like opening and reopening) is always in English. So, how are they translated in the LHN then? Well it's because we explicitly translate them in SideBarUtils.js:
https://github.com/Expensify/App/blob/aaa12f4e37c92b95c42a090889e1e4301b487e2c/src/libs/SidebarUtils.js#L297-L308
But this translation is not happening when we create options to share because that uses the method getLastMessageTextForReport, which in-turn returns the report.lastMessageText
https://github.com/Expensify/App/blob/38ed41f7c72fc52ed5e2effec9a2b510fd632d82/src/libs/OptionsListUtils.js#L490
What changes should we make in-order to solve this?
We should stop the differential use of the lastMessageText because even in sideBarUtils.js we are using getLastMessageTextForReport() and then the translations are made after that. But what we should be doing is making the translations in the getLastMessageTextForReport() function itself which would therefore mean moving the translation logic into getLastMessageTextForReport() and along the way, make some optimisations to the function as well.
So after moving that logic, this is how the getLastMessageTextForReport() function should look like:
function getLastMessageTextForReport(report) {
    const lastReportAction = _.find(
        allSortedReportActions[report.reportID],
        (reportAction, key) => ReportActionUtils.shouldReportActionBeVisible(reportAction, key) && reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
    );

    let lastMessageTextFromReport = report ? report.lastMessageText || '' : '';
    const lastNonWhisper = _.find(allSortedReportActions[report.reportID], (action) => !ReportActionUtils.isWhisperAction(action)) || {};

    if (ReportUtils.isReportMessageAttachment({text: report.lastMessageText, html: report.lastMessageHtml, translationKey: report.lastMessageTranslationKey})) {
        lastMessageTextFromReport = `[${Localize.translateLocal(report.lastMessageTranslationKey || 'common.attachment')}]`;
    } else if (ReportActionUtils.isReportPreviewAction(lastReportAction)) {
        const iouReport = ReportUtils.getReport(ReportActionUtils.getIOUReportIDFromReportActionPreview(lastReportAction));
        lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(iouReport, lastReportAction);
    } else if (ReportActionUtils.isModifiedExpenseAction(lastReportAction)) {
        lastMessageTextFromReport = ReportUtils.getModifiedExpenseMessage(lastReportAction);
    } else if (ReportActionUtils.isPendingRemove(lastNonWhisper)) {
        const latestVisibleAction =
            _.find(
                allSortedReportActions[report.reportID],
                (action) => ReportActionUtils.shouldReportActionBeVisibleAsLastAction(action) && !ReportActionUtils.isCreatedAction(action),
            ) || {};
        lastMessageTextFromReport = lodashGet(latestVisibleAction, 'message[0].text', '');
    } else if (ReportUtils.isChatRoom(report) || ReportUtils.isThread(report) || ReportUtils.isPolicyExpenseChat(report) || ReportUtils.isTaskReport(report)) {
        if (lodashGet(lastReportAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.RENAMED) {
            const newName = lodashGet(lastReportAction, 'originalMessage.newName', '');
            lastMessageTextFromReport = Localize.translate(preferredLocale, 'newRoomPage.roomRenamedTo', {newName});
        } else if (lodashGet(lastReportAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED) {
            lastMessageTextFromReport = `${Localize.translate(preferredLocale, 'task.messages.reopened')}: ${report.reportName}`;
        } else if (lodashGet(lastReportAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED) {
            lastMessageTextFromReport = `${Localize.translate(preferredLocale, 'task.messages.completed')}: ${report.reportName}`;
        } else if (lodashGet(lastReportAction, 'actionName', '') === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED) {
            lastMessageTextFromReport = `${Localize.translate(preferredLocale, 'task.messages.canceled')}: ${report.reportName}`;
        } else {
            lastMessageTextFromReport = lastMessageTextFromReport.length > 0 ? lastMessageTextFromReport : Localize.translate(preferredLocale, 'report.noActivityYet');
        }
    }
    return lastMessageTextFromReport;
}

This might look like a lot of changes, so here is a summary of them:

The default value of the lastMessageTextFromReport is moved from the else part to the top during the declaration of the variable itself.
https://github.com/Expensify/App/blob/2e8e699a8ba629cb9124778fc8d438d65a06367f/src/libs/OptionsListUtils.js#L390-L392
The whisper moderation logic mas been moved out of the else block since the default value of lastMessageTextFromReport is already set beforehand.
The translation logic from sideBarUtils.js has been added as the last condition.
A translation for CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED has also been added which was not present in the sideBarUtils.js before.

This function now looks much cleaner than before and all the translation logic is also now at once place. Now, in SideBarUtils.js, the else condition after the translation should still remain. Therefore, the if-else block can be removed and only the following code spared:
if (!lastMessageText) {
        // Here we get the beginning of chat history message and append the display name for each user, adding pronouns if there are any.
        // We also add a fullstop after the final name, the word "and" before the final name and commas between all previous names.
        lastMessageText =
            Localize.translate(preferredLocale, 'reportActionsView.beginningOfChatHistory') +
            _.map(displayNamesWithTooltips, ({displayName, pronouns}, index) => {
                const formattedText = _.isEmpty(pronouns) ? displayName : `${displayName} (${pronouns})`;

                if (index === displayNamesWithTooltips.length - 1) {
                    return `${formattedText}.`;
                }
                if (index === displayNamesWithTooltips.length - 2) {
                    return `${formattedText} ${Localize.translate(preferredLocale, 'common.and')}`;
                }
                if (index < displayNamesWithTooltips.length - 2) {
                    return `${formattedText},`;
                }
            }).join(' ');
    }

    result.alternateText = lastMessageText || formattedLogin;

This code makes sure that we have No activity Yet text and This is the beginning of your chat... in the appropriate places.

From what I can see in my tests, if the task was originally created in English, we leave it that way and don't update it.

Is that true?
If so, is the bug or feature request to change historical data in chats from English to Spanish?

cc @tewodrosGirmaA who reported the issue

@mallenexpensify
If report action is reopened task message, the actionName is TASKREOPENED
If report action is completed task message, the actionName is TASKCOMPLETED
If report action is cancelled task message, the actionName is TASKCANCELLED
If report action is created task message (like "Assigned a task ..."), the actionName is CREATED
As I see that if the last message is TASKREOPENED, TASKCOMPLETED we will translate it in LHN (It seems that we missed TASKCANCELLED) because we can realize it by actionName of last report action. And we don't translate if the last message is "Assigned a task ..." because there is no way to know if it is a created task message

Thanks @DylanDylann .  @Ollyws , can you please review @DylanDylann 's comment above https://github.com/Expensify/App/issues/25633#issuecomment-1698382159
Then, if you agree, can you please review their proposal above?  Thx
@slafortune  I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday?  Thx

It looks like we need some backend work done if this is something we will move forward with -

If we want to translate "Assigned a task ..." we need to introduce new actionName for created task message with the change from BE

Adding engineering

Removing myself since @mallenexpensify will be back next week and I'm out on sabbatical.

@Ollyws

Could we not for example check if the action is CREATED and that the current user is also the assignee then show the Assigned a task to you... message?

If user A creates a task in the chat between User A and User B and assigns to anyone. We will display "Created a task: ..." in the chat between User A and User B
If user A creates a task in the chat between User A and User B and assign to user C. We will display "Assigned a task to you ..." in the chat between user A and User C
From my view, we should support translate in 3 following cases in both LHN and Share Somewhere section:

the actionName is TASKREOPENED
the actionName is TASKCOMPLETED
the actionName is TASKCANCELLED

In case the message is "Created a task: ..." or "Assigned a task to you...", currently It seems that we don't support translation from BE.

@AndrewGable can you review the above to help decide if this can be external or not? It's not high priority.  Thx

@AndrewGable, when you have a minute, can you review the above? Need to know if this should stay external or if it needs a backend fix,

@marcochavezf or @thienlnam - I'd be curious for your thoughts on how we should best handle this and if any of the existing solutions make sense.
I think the current discussion on whether we should do this translation on the front end or back end has probably been discussed previously and you might have some examples that will help us come to the correct decision in this case. Thank you!

For more information, currently from the FE side, we only support translating 3 cases:
the actionName is TASKREOPENED
the actionName is TASKCOMPLETED
the actionName is TASKCANCELLED
From FE, We don't support translating:

Created a task:
Assigned a task to

There have been a few issues related to translation issues - we've largely decided to close them until we support localization in the backend as these are messages stored in the reportAction message itself

@thienlnam Currently, we are supporting translating 3 cases:
the actionName is TASKREOPENED
the actionName is TASKCOMPLETED
the actionName is TASKCANCELLED
in reportAction message, LHN. So I think we also should support translating these cases in share somewhere section for consistency.

we support localization in the backend

It means all task message will be translated from BE? and we will remove all translation for task message in FE, right?

Sounds like yes we should close this and when we move the translation to the backend we will remove the front end translation.
@thienlnam - Should we be linking this case to a larger tracking issue?

BE localization is a pretty far out project - I imagine when we start to support that we'll go through and address all existing cases we have now. I don't think there is a tracking issue though

I don't think this consistency is acceptable in the long time. It might confuse for user when with the same system message some places translate, some don't translate

@thienlnam I would ask you to once go through my proposal before deciding because in it, I have proposed to move the translation logic to getLastMessageTextForReport() and removing it from it's current place. Therefore, no new logic is being added and the getLastMessageTextForReport() is refactored to not include the "ugly" code as mentioned in a comment in that function.

I'm unsure what the next best step is here.  Should we put this on hold pending backend localization? (then link to the tracking issue once it's created?)

Sounds like @thienlnam is saying we should not do a work around and should handle this via the API/back end. There is a question of when this will happen, but we don't know for now. So I'd close this and we can circle back on this via the API at a later date.

@mallenexpensify  am I eligible for payment ?

@tewodrosGirmaA from CONTRIBUTING.md

If it's a valid bug that we choose to resolve by deploying it to production — either internally or via an external contributor — then we will compensate you $50 for identifying the bug

Since we didn't fix anything here yet, compensation is not due.
The other consideration is, if this is already something we had planned to address at some point, then compensation isn't due.  This can be a lil tricky though because we won't always have something to point to to show proof.  It's also rare and doesn't happen that often.

@mallenexpensify OK Thank you for Replying,  No problem , I understand 😊


Profile Photo Style Modification

Problem Statement
Profile photo style modification
Changes Made

Modified Style of sidebar photo
Added profile photo for mobile view

Hi @ThePhilosopher4097,
Made some style changes to Profile Photo and also added Profile photo on mobile view.
Please review the PR and let me know if any require.
Thanks!


Add Jeonju university domain

Homepage: https://www.jj.ac.kr
Department : https://www.jj.ac.kr/sw/

@IamMinkyu Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Upgrade com.google.api-client:google-api-client

Problem Description
Upgrade com.google.api-client:google-api-client to 1.30.10 or newer. This is to upgrade google-oauth-client to 1.31.0 or newer.

Fixed by PR #2482


Railway style - design considerations

Given discussions in #405 , #287, and forum https://forum.openhistoricalmap.org/t/what-should-a-rail-centric-ohm-layer-look-like/76, plus other discussions elsewhere, I've began work on considering what a rail-centric style could look like. This ticket can track the stylistic conversations and updates alongside data conversations
Rail drafting style
I created a rail Demo so that the style drafting can be viewed, alongside any data and data infrastructure changes and updates that occur.
At the moment, only some places across the globe have visible rail variance (same location as above link^ ):

However, I have created styling variance for different rail types as seen in the "Hocus Pocus" testing area:

These style choices are anything but final, but to at list provide a means of differenting more rail "usages" that we do have labels for atm - until data updates occur.
Besides the above, I removed other data from the map to make the map very rail focused. I visually removed land use/type, POI, and other informations and then adjusted reference information (labels, administrative lines) so that rail was the main focus, but still allowing the other data layers to be legible for use. More to come and these will change as more rail data exists and data updates/data infrastructure updates occur.
Some of the Design Inspo
Main line routes?
heavy black lines with white/clear circles (that represented towns) were common across many historical maps. This in itself isn't shocking: Make a clearly visible line, and showcase where the cities and towns are along the routes. The result is a visually distinct aesthetic, however. Given that this occurs often and also globally ( *historical research dependent on what I could find based on language I speak, so noting that I attempted to review globally but limits here). Given this, this aesthetic seems appropriate for "main" line routes.

Other route aesthetics
Obvious tracks, dashed lines, and other line aesthetics are ones we should use for the upcoming variety of rail that folx are considering adding as more distinguishable tags for a rail specific style, but I wanted to also review historically how some of these presented, as well as gather other options for inspiration.
Thick, dense rail dashes (millipede-esque):

classic dashed route:

mostly-one-sided dash (I think possible implentation via offset?):

one-sided dash:

thicker wide dashes:

Legend with line varieties (not just rail):

farther-apart track dashes:

"casing only" route (not the main routes that are bolder here):

And of course, the above isn't including basic line representation, color variances, and normal dashing lines as well (also pictured in these map examples)

Honorary mention - if we also want to have some fun with the style, we could consider adding pictorial symbology to this style. Some rail maps historically also were like "tourist maps" to encourage rail use:

https://retours.eu/en/46-pictorial-railway-maps/

I'm sorry to say this, but I feel like you have focused too much on a national level.
The map looks great when zoomed out, seeing clearly where the transport corridors are inbetween the cities without roads obstructing the view, and the railways look good as well when zoomed in, but you can't see anymore how the railroads interact with their surroundings at all. You can't even tell if a railroad has grade crossings, is street running or seperated what should be a basic question to answer.
Keep in mind we even show streetcar lines on the rail layer.
Instead of completely removing all roads and alike I would avocate to just showing them at a further zoomed in level similiar to how the buildings currently do.
This is the major benefit of the digital map we have, stuff can dissapear and appear considering the detail level you look at. We need to play more with that instead of just considering it static.
For comparsion some railroad issued rail station diagramms, they all show roads even if it is just for orientation:
1902:
https://upload.wikimedia.org/wikipedia/de/2/2f/Gleisplan_G-Brunn_1902.jpg
1943:
http://www.kuestenbahn.de/fehmarn/gleispl/gppt43.jpg
1960s(?):
https://upload.wikimedia.org/wikipedia/commons/f/f4/Gleisplan_leipzig_plagwitz_km10.84.jpg

@Bauer33333 no sorries needed at all! This is just a starting template to work together on as conversations continues on what to incorporate. thanks for these thoughts, they're important!

The rail demo style now has roads turned back on - grayscale: https://openhistoricalmap.github.io/mbgl-timeslider/railDemo/#13.284/51.50235/-0.06297/1982,-4000-2023

Since we deployed the rail style in #405, ewe'll use specific tickets and forum discussion ongoing here https://forum.openhistoricalmap.org/t/what-should-a-rail-centric-ohm-layer-look-like/76


Typescript Issue??

If you open api-gateway.service.ts and look at line 102
I get the error "Supplied parameters do not match any signature of call target"
I suspect this issue only came to light after the last commit?

@kiwiingenuity can you try with latest code now? I am not getting any error at line 102. But there was an issue with api.gateway service lacking import of Observable as you can see in change history.

I've included you the new import.
The error is still there.
I should mention that this error is only appearing in Visual Studio.
If you are not getting the same, I suspect we have different versions of typescript?
Now that you have blown away AspNetCoreSpa.xproj I'm a bit bewildered?

@kiwiingenuity using latest version of typescript and it is part of the project. It could be Visual studio's support for typescript as you said.
xproj was causing issue when deploying to azure. It only successfully deployed if there is only project.json file (not sure why but that issue was only happening recently).
Bear in mind that there are some new project structure changes since 1.1.1 .net, which I will be making at some point. I only use VS code and that doesn't support csproj yet, which is new project file for .net projects. I am sure Visual studio 2015 still support project.json based projects which don't have any xproj or solution files. Have you tried those?

@kiwiingenuity this is added back in again. Can you check if you are still having this issue?

Closing for now, if issue exist please let me know.


[URGENT] fix: twemojis breaking, feat: add april fools theme

slightly off topic: might be a good idea to have priority labels

slightly off topic: might be a good idea to have priority labels

for?


Fix Serde for Roaring bitmaps

Fix serde for roaring bitmaps. (Remove additional size being added in serialize method)
fix compression. (fix toBytes method to use compression)
remove getBitmap() from WrappedRoaringBitmap
Add test for serde.

@lemire regarding mutableBitmap to ImmutableRoaringBitmap, this method also does the compression if enabled when converting to bytes, if we directly use casting it wont do the compression optimization.

@nishantmonu51
That's a good point, but you could do something faster...
  MutableRoaringBitmap mrb = mutableRoaring.clone();
  mrb.runOptimize();
  return (ImmutableRoaringBitmap) mrb;

I am way from my desk and I cannot check, but I suspect that what I propose would twice as fast.
It comes down to whether this function needs to be fast.

@lemire modified the toImmutable conversion method as per your suggestion.
@xvrl,@lemire any more comments ?

@nishantmonu51  Great. Assuming that this method calls sees any use, it should now be much faster.


Bundle DSL related logic for JDL studio.

Hi @MathieuAA, @deepu105
Please review this, if you like this approach I will finish the required smoke testing.
Thing to note:

lodash is not bundled here instead users of this library will have to include lodash in their env.
Chevrotain is bundled because there will be a stronger coupling between a chevrotain version
and the DSL.
We need to consider if we want to run babel on the output, otherwise it won't work on IE11

But IE11 is not really a browser 😄

We may need babel anyhow due to different EcmaScript syntax levels supported in different browsers (even ever green ones). but maybe that is not needed as JHIpster-core targets a slightly older version of V8 (on node.js 8) so it "should'" also work on more modern JS runtimes.

Should and Will are different things though 😄

related to #234

What about using Babel to transpile to ES5?
does the JDL-Studio work under IE11?

@bd82 I never tested it in IE. I'm ok if it works only for modern browsers. Wouldn't want to complicate things just for IE

Removed automated node.js tests.
Added manual mocha html test runner.
Tested on chrome/firefox/safari.

@MathieuAA @deepu105   I think this can be merged now?


Keyboard Hides when sidemenu appears but after closing side menu keyboard appears again.

I have read the guidelines for contributing and I understand

[x] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
[x] My issue was not solved in the README.
[x] My issue can not be answered on stackoverflow.com.
[x] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
[x] My issue is reproducible in the demo project.

Describe the bug
The bug is Keyboard Hides when sidemenu appears but after closing side menu keyboard appears again. normally this thing does not cause any problem at all. but the only big problem occurs while going to other view from side menu. more explaination in "To Reproduce".
To Reproduce
Steps to reproduce the behavior:

click on search bar so keyboard will appear.
than go to side menu using screen edge pan gesture.
from there go to another view by clicking any button in side menu.
now on this new view controller you will find a black rectangle at the place of keyboard.

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Note:= if i do all this without opening keyboard in starting than it works fine.
Additional context
Add any other context about the problem here.

Did you find any solution. I am facing same issue and did not find any solution.

override func viewWillDisappear(_ animated: Bool) {
    super.viewWillDisappear(animated)
    textField.endEditing(true)
}

override func viewWillDisappear(_ animated: Bool) {
    super.viewWillDisappear(animated)
    textField.endEditing(true)
}

It was the very first thing i tried

@rehmanateeq No i have tried many things but cant find any way of doing this. So i have disabled the pan gesture and currently having sidemenu only from tapping the side menu button.
Note:- There are some delegate method of the sidemenu

So logically calling end editing in them should work fine but it is not working.
if someone has the solution of this problem please let me know.

Anyone find an update for this? I am experiencing the same thing :(

I was facing same issue.

For me issue occurred when: I clicked textField and then opened new ViewController by selecting another SideMenu option. Then there was black view at bottom.
Below solution worked for me.
self.dismiss(animated: true) { () -> Void in
self.customNavigationController.pushViewController(viewController, animated: true)
}
I found this on one of Issue:
"The problem is the presenting controller of Menu still live although SidMenu go away , so you should make it nil , to do that call self.dismiss(animated: false, completion: nil) method when you want go away from SideMenu."
I was not dismissing my SideMenu while pushing another ViewController. So when I did dismiss SideMenu and on its completion then I pushed my ViewController. It resolved the issue for me.
P.S.: I am using customNavigationController so that it will not push ViewController on SideMenuNavigationController.

I was facing the same issue.

For me issue occurred when: I clicked textField and then opened new ViewController by selecting another SideMenu option. Then there was black view at bottom.
Below solution worked for me.
self.dismiss(animated: true) { () -> Void in self.customNavigationController.pushViewController(viewController, animated: true) }
I found this on one of Issue:
"The problem is the presenting controller of Menu still live although SidMenu go away , so you should make it nil , to do that call self.dismiss(animated: false, completion: nil) method when you want go away from SideMenu."
I was not dismissing my SideMenu while pushing another ViewController. So when I did dismiss SideMenu and on its completion then I pushed my ViewController. It resolved the issue for me.
P.S.: I am using customNavigationController so that it will not push ViewController on SideMenuNavigationController.

This Fixed my issue. Thanks

Anyone find an update for this? I am experiencing the same thing :(

Just dismiss Side Menu before pushing/showing another controller

@rehmanateeq you cant dismiss side menu if the view controllers are using sidemenu navigation controller.

@aherpooja can you please provide a proper example with original code .

@Piyush-Sharma-Pandit When you select any menu option from Side menu before pushing/presenting another view controller first dismiss Side menu.
self.dismiss(animated: true) { () -> Void in
self.customNavigationController.pushViewController(viewController, animated: true)
}

@aherpooja   How did you create the sample customNavigationController? Can you please write?

I also ran into this problem. It appears that UIKit tries to remember if the keyboard is visible when a view controller is shown over another view controller and then closes the keyboard. When the front view controller goes away it restores the keyboard if it was showing. To avoid this problem you have to close the keyboard before showing the side menu. Once the side menu starts to become visible it's too late to prevent UIKit from this process of saving and restoring the keyboard state. I worked around this by closing the keyboard from a custom back button before showing the side menu. This code uses some other methods of mine but you get the idea.
    private func setupNavigationItem() {
        navigationItem.leftBarButtonItem = UIBarButtonItem.buttonWithBurgerMenu(action: #selector(self.openSideMenuSpecial), target: self)
    }
    @objc func openSideMenuSpecial() {
        // resignFirstResponder before opening the sideMenu
        // Otherwise there are crazy animations with the keyboard
        resignFirstResponderTextFields()
        openSideMenu()
    }

@phoney feel free to propose a more robust solution directly to the source code that alleviates this issue.

Any update

Any update

@objc func openMenu() {
self.view.endEditing(true)
let leftRootVC = UIStoryboard(name: "Main", bundle: nil).instantiateViewController(identifier: "LeftMenuViewController")
let leftMenuNavigationController = SideMenuNavigationController(rootViewController: leftRootVC)
leftMenuNavigationController.leftSide = true
self.present(leftMenuNavigationController, animated: true, completion: nil)
}


Translate State as a Snapshot

I have translated the State as a Snapshot page. Please review it

@arshadkazmi42 please review it

Thank you for working on this. I will get to it asap.

@arshadkazmi42 please review it


Fixes adopt form

https://github.com/akshitagupta15june/PetMe/assets/91741581/65154852-3d2c-47ed-929e-02b8f02c880e
Closes #1081

please synk with current changes

please synk with current changes

Okay I'm doing

@akshitagupta15june now you can merge this PR.
I've resolved the conflicts.


Feature/course pred prob

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

26 of 26 (100.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 69.914%

Totals

Change from base Build<PHONE_NUMBER>3:
0.1%

Covered Lines:
2835

Relevant Lines:
4055

💛  - Coveralls


Detect double fault

Currently if the first instruction after a fault causes a fault, the CPU goes into an infinite loop. Investigate how to detect this and trap it.

Research how other RISC processors handle this. It's possible this concept is an x86-ism.


[PE-D][Tester D] Wrong file name used for Quick Start portion of UG

The file name to run is tahub-contacts and not addressbook, since the archivefilename was already changed

Labels: severity.VeryLow type.DocumentationBug
original: gnoossk/ped#13

Fixed.


[WIP] Search

Hello!
I came across this project and as someone who's looking to contribute into open source I think it's a fantastic initiative – Also what better way to get started than contributing to this very project :bowtie:
The PR is for issue #16 and it is still a WIP since I'm not sure what kind of search we'd like to have – For the time being is a simple Project search over owner and name, also there's no front-end to speak of. Since there's already a search box-like element in the navbar I kept wondering where to put a search bar. Where do you think we could fit this? (sidebar comes to mind).
Finally I'd like to get some feedback on the code style/approach before continuing on.
Cheers!

Hi @gbonfant and welcome to the project, this is looking great!
I think it would be neat to have the current text box in the navbar to become a kind of combo search/add field, if someone puts in a full github url, i.e. https://github.com/andrew/contribulator or andrew/contribulator it should redirect the user to that project page, and download the information for it if it's not already in the database, otherwise it should do a search using what ever was entered.
Does that make sense?
It would also be good to search against project descriptions and allow filtering/faceting of search results by main_language, not sure how easy that is to do with pg_search?
Your coding style looks fine, I tend to use https://github.com/bbatsov/rubocop to make small suggestions like preferring ' over " for strings without interpolation but I'm not that fussy over it.
Give me a shout if you need anything and when this is ready for review and then we can roll it out to heroku :shipit:
Thanks again for getting involved!

Thank you!
Ah yes, I like the sound of a combo field, also filtering/faceting can be done with pg_search – I'll let you know once is ready for review.

Hey @andrew would you mind taking a look at the latest version? It adds both the combo search/add and filtering by language.
I didn't quite know what to do with the UI so I implemented a sort of placeholder filtering – It does the job but it's not great, any thoughts on that?

@gbonfant looks like that last commit broke the test suite, I'll pull this down and have a look later today, some nice refactoring in here too by the looks of things :+1:

Ha! Good to see the tests I wrote are working :) – I did a little of refactoring as the Project model was growing a bit unwieldily. I'd like to also clean up the create action but perhaps that's for another PR

@gbonfant is there a rake task I need to run to index the documents?

Hey @andrew, there shouldn't since the search is done against one AR instance – It should literally work out of the box, are you having any issues?

Ah ha, no you're right it does just work, I'm just so used to using elasticsearch and having to reindex it. It's looking good to me, I'll have another play tomorrow morning and merge it then!

Sorry for the delay @gbonfant, I'm going to :ship: it now!

:fireworks:


Formatter: add & to yielding methods without a block parameter

Resolves part of #8764.
This is not done to macros because they don't overload by block presence; all macros may be called with or without a block, regardless of whether the macro yields, whether the block parameter exists, and whether that parameter has a name.
0a4474a adds a total of 553 anonymous block parameters to the repository this way.

This change introduces a small issue with formatting a method with inlined comments
def foo # my foo method
  yield 42
end

formats to
def foo # my foo method(&)
  yield 42
end

Thanks for reporting. I created a new issue https://github.com/crystal-lang/crystal/issues/13091 to track this.


Support mock data api

What would you like to be added?
APIs:

[x] #668
[ ] #725

Why is this needed?
We must provide APIs for generate nodes, pods, and other resources,
here are some similar implementations I have found.

https://github.com/kubernetes/kubernetes/blob/f33498a8256b455b677ad4d30440869318b84204/test/integration/scheduler_perf/README.md
https://github.com/IntelAI/nodus/tree/master/examples/simple

/remove-lifecycle rotten
/reopen


Stopped working

Hello,
I have been using this for a long time and just recently it stopped providing the stream from my Google Hub Max video stream.  In go2rtc it just shows
"streams: exit status 22"
I have confirmed the entity through the Nest integration (camera.living_room) is still functional and showing live video, and it is.
Is this still working for everyone else using nest cams?

Maybe your Google Hub Max got upgraded and now it no longer provides an RTSP URL.
Try calling the script manually once and validating the result. Try playing the result in VLC.

Yep looks like it switched to WebRTC when migrated to the home app.
Thanks for the tip.

Now that it's migrated to WebRTC, you can import it directly in go2rtc. There's no more need for this integration.
https://github.com/AlexxIT/go2rtc#source-nest


upcoming: [M3-7878] - Linode Create UI Refactor - Part 3 - Details Section

Description 📝

Adds the details section to the new Linode Create flow 🎉
Adds the following new functionality ➕

Linode Label Input
Tags Selection
Placement Group Selection

Preview 📷

Before
After

How to test 🧪

Turn on the Linode Create v2 feature flag
Test the details section

You should be able to input a Linode Label
You should be able to select tags
You should be able to use placements groups (use dev or the MSW)

Check for basic field level error handling (for example, type in a super long Linode label)
Check the code for style, perf, and quality

As an Author I have considered 🤔

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[x] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

@abailly-akamai Placement groups should be hooked up, but I haven't been able to test it with dev probably because of the API changes? Let me know if I need to adjust anything!

@bnussman-akamai
Coming late to this but I just noticed we are no longer autofilling the label field based on the distro/region. Just confirming this was an intentional change?

I've noticed that as well and forgot to comment on the latest PR. We do need to add this back


tf.data.experimental.CsvDataset cause IOT instruction crash

Click to expand!
Issue Type
Bug
Source
binary
Tensorflow Version
tf 2.10, tf-nightly
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu 20.04
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Applying shuffle+repeat+batch on `tf.data.experimental.CsvDataset` causes check failed and IOT instruction (core dumped) crashes.

Standalone code to reproduce the issue
import tensorflow as tf

# The following code is from https://www.tensorflow.org/api_docs/python/tf/data/experimental/CsvDataset
with open('/tmp/my_file0.csv', 'w') as f:
  f.write('abcdefg,4.28E10,5.55E6,12\n')
  f.write('hijklmn,-5.3E14,,2\n')
dataset = tf.data.experimental.CsvDataset(
  "/tmp/my_file0.csv",
  [tf.float32,  # Required field, use dtype or empty tensor
   tf.constant([0.0], dtype=tf.float32),  # Optional field, default to 0.0
   tf.int32,  # Required field, use dtype or empty tensor
  ],
  select_cols=[1,2,3]  # Only parse last three columns
)

# The following operation is causing Check Fail
for e in range(10):
    dataset = dataset.shuffle(1000).repeat().batch(512)

Relevant log output
F tensorflow/core/framework/tensor_shape.cc:404] Check failed: 0 <= new_num_elements (0 vs. -9223372036854775808)
IOT instruction (core dumped)

hi @bhack
if you run the code example in the report directly, it would automatically generate /tmp/my_file0.csv for you! (which is also from doc)
with open('/tmp/my_file0.csv', 'w') as f:
  f.write('abcdefg,4.28E10,5.55E6,12\n')
  f.write('hijklmn,-5.3E14,,2\n')

Ok, probably It could be better "protected" instead of crashing but what is your use case about batching multiple time in the loop?
I suppose you want to use just a final batching or not?
for e in range(10):
  dataset = dataset.shuffle(1000).repeat()

dataset = dataset.batch(512)

@bhack yes you are right, indeed in this code example the batching multiple times is not necessary. However, I think it is still better to "protect" such an operation instead of crashing?

@creakseek Yes, but you are generating an overflow with your original loop
Let see if we could substitute CHECK_LE with something else:
https://github.com/tensorflow/tensorflow/blob/38af575aa32c5633395a538114fd85e5e7fe049b/tensorflow/core/framework/tensor_shape.cc#L418-L419

@mihaimaruseac Are these considered Security Issues? E.g. https://github.com/tensorflow/tensorflow/blob/master/tensorflow/security/advisory/tfsa-2022-069.md

Ok, It seems no more after https://github.com/tensorflow/tensorflow/commit/620ab3e167b0a64b6732dac16fd0edaf8284cb8e

I've tested the gist again with the last nightly and the code path of this example it seems to be different from the one fixed with the PR https://github.com/tensorflow/tensorflow/pull/58328:
https://colab.research.google.com/gist/bhack/9dc16546d360291eb943bbeb36a01c57/untitled192.ipynb
But I don't have enough cloud resources to recompile TF again a prepare a new PR /cc @mihaimaruseac

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


spec: don't use domain.dispose()

domain.dispose() has been emitting a runtime deprecation warning since 2013 (!) and is removed in Node 9. There is no reason to call it for these tests, so the call can safely be removed.

@kriskowal/@domenic this requires a version release and should be done to not cause Q to break on Node 9. Any chance either of you could do a release on NPM?

Released in v1.5.1

Nice, thank you both!


fixes #41 Responsive-chenges on  develop branch

@flyingsonu122 , I made the the same changes for develop branch as well .Now, you can merge it

PR Should be in develop branch

PR Should be in develop branch

Yes, @flyingsonu122  sir, you can see on the top , i made pr from develop branch

PR Should be in develop branch

Yes, @flyingsonu122 sir, you can see on the top , i made pr from develop branch

make pr to not from

PR Should be in develop branch

Yes, @flyingsonu122 sir, you can see on the top , i made pr from develop branch

make pr to not from

@flyingsonu122 sir, I have made the changes to developer branch.


added property to slider to be able to disable it

added a new property named 'disable' to SliderIOS
this property prevents the user from being able to slide the slider

One note before I forget. This PR is great for our fork, and I'll merge it in a sec.
But if you want to get this merged into github.com/facebook/react-native, you'll have to create another PR with a branch based off of master and then send them the PR.


How can I remove hover on mdl-navigation__link?

I want to remove the hover on mdl-navigation__link, so I don't know how.

Search for this ".mdl-navigation__link:hover{background-color:#e0e0e0}" and remove it from the mdl css or Override it via your custom styles.css.

Please use StackOverflow for support and integration assistance. This tracker is only for problems with the code provided by Material Design Lite.
As this is asking how to modify the core system for a custom look it is out of the scope for this issue tracker.
Thank you.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Returns NONE  instead False


⚠ ClamAV has degraded performance

In c1ce633, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 77 ms

Resolved: ClamAV performance has improved in 260d846.


how it start?

I think that nock is very great , but I don't know how it works, it can start a http server? can you help me ? thanks!

No, it doesn's start an HTTP server, it overrides Node.js http(s).request.
See here: https://github.com/pgte/nock#how-does-it-work

if I can't start web server, so the ajax request how to get mock datas in webpage?

Nock doesn't work on the browser

Okay, But still thank you very much!