Can't type in Terminus

I'm facing one issue which is popping every now and then , while im typing it doesn't reflect on Terminal. I have to close the session and and then relaunch it then it start working.

Please capture DevTools console logs at the time of the issue: https://github.com/Eugeny/terminus/wiki/Debug-logs

I too have this issue.

+1
/Applications/Terminus.app/Contents/Resources/app.asar/dist/[object%20Module]:1 Failed to load resource: net::ERR_FILE_NOT_FOUND /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-core/dist/index.js:7574 [ssh] Using user's default private key (16) xterm.js:1 Unable to preventDefault inside passive event listener invocation.   t._bubbleScroll | @ | xterm.js:1 ... /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:13825  Uncaught TypeError: Cannot read property 'runAsAdministrator' of undefined     at TerminalService.openTabWithOptions (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:13825)     at /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:15221     at ZoneDelegate.invoke (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:386)     at Object.onInvoke (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:28264)     at ZoneDelegate.invoke (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:385)     at Zone.run (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:143)     at NgZone.run (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:28159)     at click (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:15220)     at CallbacksRegistry.apply (/Applications/Terminus.app/Contents/Resources/app.asar/dist/electron/js2c/renderer_init.js:2549)     at /Applications/Terminus.app/Contents/Resources/app.asar/dist/electron/js2c/renderer_init.js:1469     at EventEmitter.<anonymous> (/Applications/Terminus.app/Contents/Resources/app.asar/dist/electron/js2c/renderer_init.js:1449)     at EventEmitter.emit (/Applications/Terminus.app/Contents/Resources/app.asar/dist/events.js:210)     at Object.onMessage (/Applications/Terminus.app/Contents/Resources/app.asar/dist/electron/js2c/renderer_init.js:2204) /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-core/dist/index.js:7475   [terminal] Starting profile bash    Object   name: "bash"   shell: "binbash"   icon: undefined   sessionOptions:   command: "/bin/bash"   args: ["-l"]   env: {}   __proto__: Object   isBuiltin: true   __proto__: Object /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-core/dist/index.js:7475   [terminal] Using session options:    Object   command: "/bin/bash"   args: ["-l"]   env: {}   pauseAfterExit: undefined   cwd: undefined   __proto__: Object

/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:4302 ERROR Error [ERR_STREAM_WRITE_AFTER_END]: write after end
    at writeAfterEnd (/Applications/Terminus.app/Contents/Resources/app.asar/dist/_stream_writable.js:253)
    at Channel.Writable.write (/Applications/Terminus.app/Contents/Resources/app.asar/dist/_stream_writable.js:302)
    at SSHSession.write (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-ssh/dist/index.js:2037)
    at SSHTabComponent.sendInput (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:9035)
    at SafeSubscriber._next (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:9234)
    at SafeSubscriber.__tryOrUnsub (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/rxjs/internal/Subscriber.js:205)
    at SafeSubscriber.next (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/rxjs/internal/Subscriber.js:143)
    at Subscriber._next (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/rxjs/internal/Subscriber.js:89)
    at Subscriber.next (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/rxjs/internal/Subscriber.js:66)
    at Subject.next (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/rxjs/internal/Subject.js:60)
    at /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:12456
    at e.fire (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400)
    at /Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400
    at e.fire (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400)
    at t.triggerDataEvent (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400)
    at t._keyDown (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400)
    at HTMLTextAreaElement.<anonymous> (/Applications/Terminus.app/Contents/Resources/builtin-plugins/terminus-terminal/dist/index.js:70400)
    at ZoneDelegate.invokeTask (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:421)
    at Object.onInvokeTask (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/@angular/core/bundles/core.umd.js:28252)
    at ZoneDelegate.invokeTask (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:420)
    at Zone.runTask (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:188)
    at ZoneTask.invokeTask [as invoke] (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:503)
    at invokeTask (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:1671)
    at HTMLTextAreaElement.globalZoneAwareCaptureCallback (/Applications/Terminus.app/Contents/Resources/app.asar/node_modules/zone.js/dist/zone.js:1729)
    at HTMLTextAreaElement.sentryWrapped (/Applications/Terminus.app/Contents/Resources/app.asar/dist/sentry.js:1118)

I have this issue when an SSH session closes (why does it close so much I don't know) and I have to reconnect. I think it happens more in split window.


Question about menubar shortcuts

I looked everywhere in the documentation but I can't find anything about this.
I want to add common shortcuts to my menu entries, for example ctrl+q should do the same as "File -> Exit". Ideally, it should be possible for end-users to customise this, but this is not currently very important.
How can I add a shortcut in nana?

The library supports keyboard accelerators, but that's not documented at the moment. Take a look at this old forum thread: http://nanapro.org/en-us/forum/index.php?u=/topic/335/ggdoes-the-library-provide-a-way-to-implement-hotkeys

Thanks @ErrorFlynn, it works for me on Gentoo :) I'm trying to improve the setup of shortcuts a little bit, see my PR #532 for more details. Also, unfortunately this doesn't show the shortcut keys next to the menu entry. I guess there's no way to do that yet?

Also, unfortunately this doesn't show the shortcut keys next to the menu entry. I guess there's no way to do that yet?

I'm not sure if that should be done by the library, it's not so hard to do it yourself. For example:
#include <nana/gui.hpp>
#include <nana/gui/widgets/menubar.hpp>

int main()
{
	nana::form fm;
	nana::menubar mb {fm};
	auto cb_exit = []
	{
		nana::API::exit();
	};
	mb.push_back("&File").append("E&xit\t\t\t\tCtrl+Q",
		[&](nana::menu::item_proxy&) { cb_exit(); });
	nana::accel_key acc_quit;
	acc_quit.key = 'q';
	acc_quit.ctrl = true;
	fm.keyboard_accelerator(acc_quit, cb_exit);
	fm.show();
	nana::exec();
}


Grammar error @ Structs-enums-lifetimes

Structs and Enums
Original:
since it contains a allocated
pointer to the data, and always has a fixed size.
New:
since it contains an allocated
pointer to the data, and always has a fixed size.

Thanks for the sharp eye

Thank you for this awesome repo.


Entries appearing more than once in a table

I have noticed that some entries in a table appear duplicated but when inspecting each entry, they turn out to be the same (for example, if I delete one, they both get deleted)
I have a main table which shows all of the work carried out, there are then sub tables which split the main table into sections depending on the stage of the job, as I update the job it then moves this to a different sub table
The tables are grouped by customer (ASC) and then further grouped by job date (ASC).
I notice that when the table gets to less than 20 entries, at the bottom it then duplicates the jobs from the bottom customer
IE
Customer A - Job A - 01/01/2021
Customer A - Job B - 02/01/2021
Customer A - Job C - 03/01/2021
Customer B - Job A - 01/01/2021
Customer B - Job B - 02/01/2021
Customer B - Job C - 03/01/2021
Customer B - Job A - 01/01/2021   <-Duplicated
Customer B - Job B - 02/01/2021    <-Duplicated
Also...
If there are more than 20 jobs for example - 21
It will sow the first 20 on page 1 then when I go to the next page, expecting to see only one job, it shows multiple, again duplicating jobs from page 1 onto page 2.

Could you specify what kind of sorting you have on the table(record list) that is duplicating records?
I'll try to reproduce this, so I need all the available information (if it's not sensitive of course)

Managed to reproduce it. Trying to fix

The exact query i am using is Customer DESC,  Job_date ASC
It tends to be that if page one shows
Cust A - Job A - 01/01/2021
Cust A - Job B - 01/01/2021
Cust A - Job B - 01/01/2021
Cust B - Job A - 01/01/2021
Cust B - Job B - 01/01/2021
Cust B - Job C - 01/01/2021
And  Page 2, should show
Cust B - Job D - 01/01/2021
It ends up showing
Cust B - Job A - 01/01/2021
Cust B - Job B - 01/01/2021
Cust B - Job C - 01/01/2021
Cust B - Job D - 01/01/2021
Essentially showing all of the other jobs linked to that customer

@PaulMcF1987 I was able to solve this for the cases that I managed to reproduce. Expect this patch to be released; probably in the next week or two. I don't have a timeline, so keep an eye out on our home page for updates.


C++ related issues in dwarf_extractor.cpp

when compiling a C++ module, in lldb_function_to_function_dbi,

function_args doesn't seem to include the "this" pointer. on the other hand, variable_list contains it. it causes the "function args number dismatch" message and then ParamType overrun, which likely involves a crash. a workaround: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3190
variable.GetName() seems to return NULL for unnamed arg. it causes a NULL dereference. a suggested fix: https://github.com/bytecodealliance/wasm-micro-runtime/pull/3189 merged
sometimes LLVMCountParams(func_ctx->func) doesn't match what's in variable_list. (variable_list has more.) usually it causes a crash in LLVMDIBuilderInsertDbgValueAtEnd. see the attached d.tgz for an example. (also, it seems that something similar happens with rust: https://github.com/bytecodealliance/wasm-micro-runtime/issues/3163) i guess we can investigate DW_AT_location (DW_OP_WASM_location) of variables to find the corresponding func_ctx->func's parameters. (locals) but i don't know how it can be done with the LLDB API.

note: clang omits empty class from low level function parameters: https://github.com/llvm/llvm-project/blob/cad6ad2759a782c48193f83886488dacc9f330e3/clang/lib/CodeGen/Targets/WebAssembly.cpp#L107-L109. (ie. it's a part of C++ ABI clang uses for this target.) in that case, in dwarf, the omitted parameter is represented as DW_TAG_formal_parameter without DW_AT_location.

d.tgz

btw, i wonder why dwarf_extractor.cpp uses the LLDB API, rather than, say, llvm/DebugInfo/DWARF/ api.
@wenyongh do you remember?

btw, i wonder why dwarf_extractor.cpp uses the LLDB API, rather than, say, llvm/DebugInfo/DWARF/ api. @wenyongh do you remember?

The source debugger feature was implemented by Ant group long time ago, I just cannot remember the details now. Maybe the LLDB API provides more capability?

a quick research on how other projects are reading the dwarf section in wasm:
binaryen: llvm DWARFContext https://github.com/WebAssembly/binaryen/blob/d6c5e4ab15df271521df7b35665c7463b2c490ca/src/wasm/wasm-debug.cpp#L96-L116
cranelift: https://github.com/gimli-rs/gimli (something written in rust)

It seems that AOT debugging now only has limited functionality. It was aimed to support C first It hardly covers any additional C++ features. Thus the current function-to-function debug symbol mapping only supports C styles function. And I think that's why it error when it comes to Cpp compiled wasm or Rust compiled wasm

It seems that AOT debugging now only has limited functionality. It was aimed to support C first It hardly covers any additional C++ features. Thus the current function-to-function debug symbol mapping only supports C styles function. And I think that's why it error when it comes to Cpp compiled wasm or Rust compiled wasm

i agree.
i tend to think a fix involves a major surgery like switching from lldb api to llvm api to read dwarf. how do you think?

I think it's feasible, but as you said it would be non-trivial changes. BTW, besides the extractor, will there also be some major modifications for code emission and file generation?

I think it's feasible, but as you said it would be non-trivial changes. BTW, besides the extractor, will there also be some major modifications for code emission and file generation?

i guess it will be mostly contained in dwarf_extractor.cpp.

i guess it will be mostly contained in dwarf_extractor.cpp.

Got it, thanks


Remove unused data files since the switch to Next.js.

Per conversation on discord at https://discord.com/channels/404106811252408320/750533049623773304/772861603733045278

Looks good 👍  thanks @philltran !


Incorporate ontology changes to OntoBuiltEnv

Updated OntoBuiltEnv TBox and also included instances as Abox as discussed. The latest MIRO board for comparison can be found here: https://miro.com/app/board/uXjVOIznYOU=/?share_link_id=626431683477 (I believe you still have the edit link)

After talking to Mei Qi and Srishti, I realized that the current range of hasOntoCityGMLRepresentation should actually not be a regular string. This relationship connects a (OntoBuiltEnv) building instance with its OntoCityGML "equivalent". The OntoCityGML "equivalent" is also an instance which is further connected to geometric information. As shown in the screenshot below, however, this instance has neither a rdf:type nor datatype associated with it. To still make it "resolvable" as IRI for any further queries in the KG, I changed string to anyURI. Please review whether that makes sense.


::facebook::gloginit::initialize() not called, is it a typo?

I'm using LOG(WARNING) << "The log message" on ReactCommon module, but can't get any log via adb logcat, after some investigation i found we should call ::facebook::gloginit::initialize() to redirect the glog message to adb logcat.
If it's a typo, i'll send a PR to fix it.

u should using  console.log('what u want to log')

cc @javache


Add instruction table 1-f x 1-f .

Need to show where all of the instructions are located on a 16x16 grid.

Need to add a section on CPU specifications.

Clock Speed.
32 Bit words.
4096 Word Memory.
Average Instructions per second.
Cache
Cores

Registers

Interrupt

IO Addresses


should the getting started application actually build without errors?

Greetings,
I am really interested in East -- I am hoping it will help with my zephyr development struggles.  But it seems like the zephyr example has moved on to use new features, and the getting started example no longer builds without errors.   And this sort of problem is one of my challenges -- I see interesting examples around on the internet, but it seems hard to match all of the pieces up such that I can actually build and test the example.
Perhaps you could fork the zephyr example app, and use your fork to showcase EAST?
thank you.

Hello @bvwelch, thank you for showing interest in the East :)
I have checked the example application repo. Current HEAD of the master is not compatible with any version of Zephyr. There were some changes in how the app versioning is done on their side and this does not yet seem to work, at least for me.
I have updated the docs in the dev branch, so now they specify specific versions (see c34a29dad4477b for relevant changes).
The example should build now, tell me if it does not.

sorry i did not intend to close this issue.

Yep, the issue is that it does not find the examplesensor0 node for the nrf52840dk_nrf52840 board. I had solved this issue in the Release section, however the instructions were wrong.
I have updated the docs in the 1b726f78d3d122f18ba82ae6caceb29f8b320f8b
commit, try giving this a try.
If you get stuck I would recommend you to run git clean -fd from example-application directory and going through project setup steps again (only those that do some modification on the project, you do not need to run west init/update and such).

Thank you that builds fine now!


Bump devtools protocol dependency

Bump DevTools protocol dependency to unlock deep serialization

The original is https://github.com/GoogleChromeLabs/chromium-bidi/pull/668

Approving to unblock

This may break puppeteer. c.f. #670 and cc @Lightning00Blade

Postponing till Puppeteer 114 version cut.

bump CI

As discussed offline, not blocked by Puppeteer release anymore


Make CMake build assume SWIFT_PATH_TO_SWIFT_SYNTAX_SOURCE location

Now we have to pass it explicitly which makes explicit cmake invocations, or using IDEs like CLion, VSCode which need invoke cmake to configure annoying. See: https://github.com/apple/swift/pull/62252
It would be better if the build can assume that swift syntax is located in the same directory as swift (i.e. <swift-project>/swift/../swift-syntax), that would make setup easier.

rdar://102752806


Add trim-clip extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks for your contribution 🔥
Would it make sense to add this to YAFW extension by @pablopunk

No, makes it more difficult to find in the store. An user doesn't need to know what ffmpeg is to trim a clip.

I gave it another spin 🙂

Can you handle this error gracefully?

Could we show a animated toast while it's working, it's not possible to see what's going on 🙂

The extension now shows a toast when there are no files selected and the loading spinner should show faster.

That's much better 🔥
I just tested it with a video and trimmed it, most of it is just black - the original video has content - do you have a clue why?
Uploading bug-auto-change-alias-Scene-001-Scene-001-Scene-001-trimmed-0-15.mp4…


How to pass Mixed / Categorical Data?

The paper mentions that the algorithm is for mixed, large datasets, though all the experiments shown are on datasets with numerical columns. Plus, the algorithm accepts only a numpy ndarray.
My question is, how do we input categorical / mixed data into the algorithm? Do we just do pd.get_dummies() on the pandas dataframe and then convert it to numpy, or is there any other way?
I tried using the get dummies method, but the clustering results I got were really bad - with a lot of points being marked as outliers.

The paper mentions that the algorithm is for mixed, large datasets, though all the experiments shown are on datasets with numerical columns. Plus, the algorithm accepts only a numpy ndarray.
My question is, how do we input categorical / mixed data into the algorithm? Do we just do pd.get_dummies() on the pandas dataframe and then convert it to numpy, or is there any other way?
I tried using the get dummies method, but the clustering results I got were really bad - with a lot of points being marked as outliers.

We are currently enhancing the package to support a distance matrix as input instead of a raw data matrix. This update will enable users to apply various distance calculation strategies tailored to different types of data. In our recent releast (version 3.0), we implemented the merge function, allowing users to merge similar clusters (but not outliers) into one.


Reject messages

Hi @jareddlc, do you have any news about testing https://github.com/jareddlc/OpenFit/pull/38? I have another update - quick SMS reply after rejecting phone call. You can write 6 reject messages and save it to the bracelet. You can find the edit option bellow Phone Calls checkbox.

I will try in the next few days. hopefully by thursday


feat(dataplane): implement value digests

Value digests is a new type of digests that summarizes the values of the field in the message.
Describe your changes

Implement configuration of value digests
Implement value digests logic

number: num null, num default, min, max, avg.
boolean: num null, num default, num true, num false.
string: num null, num default. min, max and avg length.
array: num null, num default.
obj: num null, num default.

Implement computation of digests in the collector (only value digests, struct digests still computed in the sampler)
Refactor event generation in the collector to avoid direct access to the registry

Fixes # (issue)
Checklist:

[X] My code follows the style guidelines of this project
[X] I have made the appropriate changes to the documentation
[X] New and existing unit tests pass locally with my changes
[X] If it is a major user facing functionality, I have added behavioural tests
[X] If it is a critical part of the code or of significant complexity, I have added thorough testing

I just ran the CPU profiler with events and digests enabled for all the samplers in the playground. I could not even see the digest CPU time, most of the time is spent in the gRPC


#5512 Reorganise gradle projects.

jitpack.yml needs to be at the root of the repository. I can't get Maven artifact from this PR.

@hadim jitpack moved

will have to be reconciled with master now.  shouldn't be a big deal.

Looks good except we need to update setupbase.py with new way to run gradle:
    running java
    > ./gradlew --no-daemon build
    /Users/spot/anaconda/envs/testx/lib/python3.5/site-packages/setuptools-27.2.0-py3.5.egg/setuptools/dist.py:331: UserWarning: Normalizing '0.1.0.dev' to '0.1.0.dev0'
    error: [Errno 2] No such file or directory: './gradlew'

@hadim jitpack.yaml will need to be updated, can you please provide PR?
btw we have switched from oracle jdk to open jdk, should fix that too.

I'll try to have a look later this week. Don't wait for me to merge this PR.


Detect validator-edit/emergency upgrades based on auction contract entries in the global state in sync-to-genesis.

When syncing back to genesis we need to detect immediate switch blocks after upgrades in which the validator set was changed by directly modifying the global state: Those get signed by the validators specified in their own header, rather than the previous switch block's header. So:
If we encounter a switch block in an era N whose protocol version is higher than its parent's, after synchronizing both blocks' global states, we load the validator maps from both states. They both contain the validator set for era N + 1, so we can compare that entry. If it has changed in block N, that must be because the validators were changed in that upgrade.
(Possibly slightly easier: We could avoid looking into block N's global state, because its header already contains the validator map for era N + 1. So we'd only need to look into its parent's.)

WIP: https://github.com/afck/casper-node/tree/validator_change_upgrades


Add Rashad Khalifa's translation

Can you please add it, English Quran translation by native arabic speaker.
https://www.quranalone.com/media/quran-english.pdf

Please see this

You should give the people the freedom to choose among the translations, if someone wishes to use the Rashad Khalifa's translation which is a very important one, that should be added.

2:256 No Compulsion in Religion

This is not impartial or equitable

Salam alaykum brother, I am not being impartial here.
After you have asked me the first time

You should give the people the freedom to choose

I saw this complete video and the channel is a pro rashad khalifa . I did this to avoid being unjust.
The issue I find in that video is that, he considered the quran to have mistakes and he had his own version of quran, in which he removed few words and verses because he considered those words/verses to be added later. He found the mistakes in quran using some mathematical formula.
I cannot add his translation because it may contain his personal opinions

Peace be upon you
I appreciate that you check it out and try to be just.
You have some misunderstandings. He never says quran has mistakes, those verses are not from the quran they were added.
And they are not his personal opinions, he is a messenger of God.
[21:27] They never speak on their own, and they strictly follow His commands.
You may agree or not agree with these but it would not be equitable to pick out translations according to your personal opinions.
I invite you to do the righteous.


bbcode autocomplete is not loaded when using /rpost

Not sure how many people use the /rpost page to create posts, but the JavaScript that supports the autocomplete must not be loading there.

works for me in myhub.com/rpost

I was running Version 2016-04-15.1367H+ce34c40, Tag: 1.4. Now I'm running Version 2016-04-26.1378H+563e82f and it works.


added git commands

added some git commands i.,e  git remote,git add remote upstream

Thanks for adding it but I am thinking to add it in some different way !!

Ok...


DT-486 Set libgweather Locations path

This MR sets a fixed path for libgweather, allowing it to be compiled in the Gnome SDK. The MR https://github.com/ubuntu/gnome-sdk/pull/62 requires this in order to work.

Question: I’m adding a soft link called libgweather  that points to libgweather-4, and use libgweather in the change in snapcraft-desktop-integration. The idea is to always use that folder for the data. But gweather-3 uses libgweather, so I’m not sure if we should remove that link and adjust the environment variable to point to the right folder based on what is compiled. I presume that it is possible to create different values for the same environment variable based on which SDK we are using…

I mean: if in a future Gnome-43 SDK we add libgweather-5, which puts the Location file at libgweather-5/Location.bin, is it possible to make that, when building Gnome42, LIBGWEATHER_LOCATIONS_PATH point to libgweather-4, and when building Gnome43, it points to libgweather-5?

@kenvandine This one is needed in order to make gweather work in the SDK.


General error and form validation

I want to use the general error (_error) for some errors returned by my server-side API.
However, setting such _error forces the prop 'valid' to be false.
My issue is that in some cases, there is an error but that does not mean the form is invalid (and so I want to let the user be able to click on the Submit button again).
For example, let's say there is a network error (server timeout), I want my users to be able to send the same form again.
Is there any way to do what I want within redux-form?

V6 offers SubmissionError for this http://redux-form.com/6.0.0-alpha.15/docs/api/SubmissionError.md/

@tyrsius is correct.


Update last two day two talks

This PR updates the last two talk titles on day 2.

How's this looking @karasowles? 🔎 https://deploy-preview-138--gh-maintainers.netlify.app/schedule

This looks great, thank you!

I'm pushing it through, apologies in advance if I wasn't supposed to


Format Code not working

From @johanneskopf on August 12, 2016 21:53

VSCode Version: 1.5.0-insider
OS Version: Windows 10, Build 14901

I work with Unity, but no matter if I open a whole solution or only a .cs file: the formatting of the code with (Shift+Alt+F), or by using the action in the command palette, isn't working.
Copied from original issue: Microsoft/vscode#10487

From @brandonmp on August 13, 2016 0:7
Will just add-on to this one though my circumstances are diff't:
VSCode v. 1.4.0
OS: Ubuntu 16.04
Has worked flawlessly for months, but just stopped yesterday. Uninstalled/reinstalled a few times, and tried in various projects/languages (namely: JS, JSX, and Python), still no formatting (either via shortcut or via command palette).
Admittedly I'm not sure how to -fully- uninstall the app, as every time I re-install, it remembers what files I had opened.  I imagine there are settings leftover somewhere, so I'll keep trying to find/delete those.
ETA: I was able to "fix" the problem finally:

Use synaptic package manager and mark the code package for 'Full Removal,' click apply.
Delete ~/.vscode
Delete ~/.config
Reinstall
Profit (Until it breaks again :( ... I can't go back to doing my own indentation! )

From @brandonmp on August 13, 2016 21:15
Does VSCode leave any windows registry keys?  Since it's a bug that starts spontaneously, I have to imagine there's some residual settings somewhere.
If you install logged in as a  diff't user, any luck?

From @johanneskopf on August 13, 2016 19:52
I tried to reinstall VS Code, deleting the extension folder and the VS Code Folder in APPDATA, but nothing changed.

Coincidentally today I saw that you have Developer Tools to enable.
When I enable them and press "Shift"+"Alt"+"F" to format my code, the warning "Ignoring commands" gets written. Maybe this has something to do why my format code is not working as expected?
So in cursor.ts, this if gets executed, therefore the warning gets written:
var loserCursorsMap = this._getLoserCursorMap(rawOperations); 		if (loserCursorsMap.hasOwnProperty('0')) { 			// These commands are very messed up 			console.warn('Ignoring commands'); 			return false; 		}

Is there some way I change the code of "cursor.ts" myself?
As it's path is somewhere in the internet, and therefore I can change this code and save it, but the new script doesn't get executed.
The path can be seen here:

Still happening with the latest 1.4 beta 8.
Any news here?

Hey @jrieken, based on @brandonmp's comments about this not working for him in JS, JSX and Python and @johanneskopf's investigation, I'm not sure this is a C# extension issue.

@johanneskopf: I see that the developer tools show the .NET CLI Tools message is appearing for you. I doubt it's related, but since you said you have 1.4.0-beta8 of the C# extension installed, you can disable that message (since you're not using the .NET CLI) by setting the following setting in VS Code:
csharp.suppressDotentInstallWarning: true

@DustinCampbell I made a fresh install of VS-Code and it's plugins and upgraded to the 1.4.0-beta9 today, and then set your mentioned settings. I don't know why, but this setting isn't working for me:

I tried it inside the user and the workspace settings, but nothing changed.

@gregg-miskelly, @chuckries: Isn't the "csharp.suppressDotentInstallWarning" supposed to be working?

Your string seems to have a typeo. It is suppressDotnetInstallWarning.

That was my typo. The screenshot that @johanneskopf provided above does not have the same typo.

Something is a little screwy with @johanneskopf's screenshot. In versions of the extension where this can be disabled, we show a button in the alert to navigate to the user settings in the editor.

It doesn't look like @johanneskopf's version of the extension has this button. The latest version of the extension may not actually be installed?

@chuchries
I already recognized that no beta features are working. That's why I asked "What's the preferred way to install the latest beta on Windows?" Can you give me any advice here?

Sorry, I misread your reply @johanneskopt. It sounds like you don't actually have the beta installed. Installing the beta VSIX doesn't require moving source files around. That would generally just break the extension. Installing the extension is as easy as just selecting File->Open from the VS Code menu and pointing it at the VSIX. Could you try that?

@DustinCampbell thank you! I was searching for an explanation like this. I don't know why I haven't tried that before.
The beta version is now working, but the warning that "Ignoring commands" persists. So format code is still not working.

OK. In that case, @jrieken, do you have any ideas? It's not clear to me how the C# Extension would contribute to this issue.

The formatting providers are spec'd to produce an array of text edits where a text edit is a range (of existing text) and new text. There are cases in which we cannot process them and drop them - that's usually when they overlap or selecting something non existent.
For a better I need exact step, esp current text and formatting options.

@jrieken, is the "Ignoring commands" message that @johanneskopf mentioned relevant? It seems rather ominous to me and I was guessing that Shift+Alt+F wasn't working because the editor was already in some sort of state where it would ignore it.

Got another weird behavior today. Currently I have 1.4.0 of the C# extension and the latest insider build of VS Code installed.
Step by step:

Created a new Unity Project
Imported the "VS Code" Asset from the asset store
Opened preferences - VSCode and pressed "Write Workspace Settings"
Created a new script called "Test.cs"
Opened it by double clicking it in Unity
Wrote in the Start() function "int h=0;" -> should be corrected to "int h = 0;"
Pressed Shift+Alt+F

Before using the formating command:

Afterwards:

@jrieken Anything else I can do to help you fix it?

Yes - please attach the project as zip here

Same behaviour here. Using latest VSCode1.5.0-inside on Mac OSX 10.11.6. Formatting either not working or just randomly scrambling letters (like shown above).
@jrieken Full project can be found here (file larger > 10MB - couldn't attach it here).

Ok, incidentally, I want to point out some other things that might come in handy when working out a solution for the bug:

Creating a new empty project with $ dotnet new and trying to format code doesn't work very well either.
I can say It's not Unity related.
Functionality doesn't seem to be very consistent. In my tests, code formatting would sometimes work fine, don't work at all of mess things up. See screenshot below:

Intuitively, it looks like a parsing issue. I managed to reproduce the "scrambling" problem following these steps:

Create a new project with $ dotnet new.
Open the directory as a project in VSCode.
Restore project dependencies and let it install and fire up Omnisharp.
Open Program.cs.
At the beginning of line 5, delete the tab space.
Move curly brace from line 4 to the line above and put a space between ConsoleApplication and the brace. File should look like this:

Finally, select Format code from the dropdown menu. Notice what it does to the code.

Thanks for the steps! This is actually a really bad regression from a change we made in August. Our intent was to fix the problem that many formatters basically replace the whole document text instead of producing 'true' and 'minimal' text edits. We added some post-processing that minimises the text edits and it seems that messes things up.
I have created https://github.com/Microsoft/vscode/issues/11593 to track the issue and will make sure we ship the fix soon. Sorry, for not thinking about this earlier.

Format Document just stopped working for me out of nowhere yesterday. Neither right-click > format document, nor Alt+Shift+F. Writing js and jsx on Win10.
Has this been solved?

@esuus: Are you asking about js and jsx file? This is the repo for C# for VS Code.


Set CSRF cookie to httponly

Also, set httponly on session cookie in base settings, though it is already
overridden in prod settings.

WIP, this breaks the project import form, which relied on access to the csrf token cookie.


Fix jsonrpc README example

Fixes #166

Hi @vjeux, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hi @vjeux, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

I just encountered the same issue with the example code, but found another fix that works:
let notification = { method: 'testNotification', numberOfParams: 1 };
Not sure which one is preferred.

Actually the right fix here is to use the new classes instead of object literals.
let notification = new NotificationType<string, void>('testNotification');

I will make the necessary changes.

What if you are using this with stock Node, not TypeScript?

If you use it with plain JS then there is no need to define a NotificationType. You can directly send a message using connection.sendNotification('testNotification', ....);


ARA for Mac

Testing ARA on Mac and Rhino 7 reveals following issues:

[x] server - no terminal window shows up
[x] open folder (explorer) doesn't work
[x] plotters in static mode  --> dropped support for static mode, no Bitmap+ available, no need for kaleido (#42)

Will not be investigated or fixed for now:

[ ] RhinoPythonEditor: no module named Grasshopper (sometimes)
[ ] plotters in interactive mode - hangs up (on some machines)
[ ] no Bitmap+ for mac (static mode display doesn't work)

TODO:

[ ] create new release
[ ] adjust documentation

Dropped support for plotters in static mode because no Bitmap+ available to display the content. Hence, also no need for kaleido on Mac (see also #42).


Added Ginkgo 1.4.x and Gomega 1.2.x

Alongside of out test package "testify" I've added Ginkgo and Gomega.
You can watch this youtube video to see what those libraries do: https://youtu.be/xn6Erpr2p0o?t=8m45s . From the video you can also immediately see that it is quite nice to look at the test output. It is far less cluttered than with golang's built-in testing + testify and the context is much better described if something fails.
I'm not against having both, the current and ginkgo, testing frameworks in place at least for a while.

@kwk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1588-1

How about rewriting some of the tests to demonstrate the value of it? :)
Personally, :+1: from me, but I'm only the observer.

How about rewriting some of the tests to demonstrate the value of it? :)
Personally,  from me, but I'm only the observer.

This is how the specific assertions with testify change when using ginkgo + gomega:
old:
// when
templ, err := spacetemplate.FromString(yaml)
// then
require.Nil(t, err)
require.NotNil(t, templ)
require.Equal(t, uuid.FromStringOrNil("038e4d23-4e52-45e7-b0d9-5d736109845f"), templ.ID)
require.Equal(t, "foo", templ.Name)
require.NotNil(t, templ.Description)
require.Equal(t, "bar", *templ.Description)
require.Equal(t, templ.Template, templ.String())
require.Nil(t, templ.Validate())

new:
// when
templ, err := spacetemplate.FromString(yaml)
// then
Ω(err).ShouldNot(HaveOccurred())
Ω(templ).NotTo(BeNil())
Ω(templ.ID).To(Equal(uuid.FromStringOrNil("038e4d23-4e52-45e7-b0d9-5d736109845f")))
Ω(templ.Name).To(Equal("foo"))
Ω(templ.Description).NotTo(BeNil())
Ω(*templ.Description).To(Equal("bar"))
Ω(templ.Template).To(Equal(templ.String()))
Ω(templ.Validate()).To(BeNil())

I know this is not an existing test but it at least shows an example of the gomega package. The logic is basically more human-readable. The subject under test appears in the beginning Ω(subject) and the requested properties come afterwards.
The tests themselves using Describe(), Conext(), and It() are also more grouped by context and allows for better TDD/BDD.

@kwk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1588-2

Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   55.98%   55.98%
=======================================
  Files         127      127
  Lines       15657    15657
=======================================
  Hits         8765     8765
  Misses       6248     6248
  Partials      644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8203eb3...2ad02de. Read the comment docs.

@kwk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1588-1

@kwk snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1588-2

Closing because we are using standard go sub-tests with nesting and have reduced our test output quite a bit (#1674).


Merging Set up and Bayesian CV + feature_names removal + xgboost_early renamed

[PR] Add Bayesian Search to Model Tuner with Support for Python 3.7 - 3.11
Overview
This pull request introduces support for Bayesian Search in model_tuner, along with updates to compatibility across Python versions 3.7 to 3.11. The update was initially contributed by @lshpaner, and we've now expanded it to also support scikit-optimize, allowing the use of BayesSearchCV for more efficient hyperparameter tuning.
Key Changes

Support for Python Versions 3.7 - 3.11: Fixed compatibility issues across these Python versions, ensuring stable use of the model tuner in a wider range of environments.

Integration with scikit-optimize: The update enables the use of BayesSearchCV from scikit-optimize, allowing more sophisticated hyperparameter tuning. Instead of defining a fixed grid, you can now define a search space, and Bayesian search will find the best parameters within this space.
Example:
estimator_name + "__max_depth": [0, 100]```

Enable Bayesian Search for Cross-Validation
To run the Bayesian search, set the bayesian and kfold variables in the model definition to True. This ensures that the Bayesian search operates within cross-validation.
Minor Bug Fixes
We have removed the unused variable feature_names and we have renamed xgboost_early to boost_early to make it a more general variable name.

Approved. The addition of Bayesian Search with compatibility updates across Python 3.7-3.11 and integration with scikit-optimize significantly enhances the functionality and flexibility of model_tuner. The inclusion of BayesSearchCV for hyperparameter tuning and minor bug fixes contribute to a more robust tool. Great work on expanding the feature set while ensuring cross-version stability.


Timeline improvement

Please do not update the README or Change Log, we will do this when we merge your PR.
This PR (delete as applicable)

Adds a new feature

Describe the changes below:

Do nothing in update() method if timeline.complete is true
Add COMPLETE event, fired when timeline.complete is true, after events execution loop.

However, it might not be a good idea that clear, or add new timeline events during events execution loop (i.e. change items of timeline.events), thus I add COMPLETE event fired after events execution loop.

A few things I need to fix in here, but I like the features, so merging :)


Add listener on NumberProgressBar

this is a not good design.

What do you mean by "bad design" ? (design pattern, format code...)

OnProgressBarListener  only has onProgressBarFinish  method, this can only solve the specific scene problem rather than the most.

A good idea is onProgressChange(int current, int total) method.

Thanks for your reply. I will work on it and make it better.

@daimajia have you got some news ?

@lelexxx So sorry for my late. Too many email everyday.
This is a better design, thanks for working on this project :-D


Improve rx-recompose example

I was playing with rx-recompose and got stuck when trying example. First, there was an error. Second, Counter was ignoring external props like <Counter style={{color: 'red'}}/>.
So, I had to patch it to:

fix ReferenceError: count is not defined
make mapPropsStream of example to actually pass props through

I'm just learning both Rx and recompose. Is my example correct? If not, I may re-submit PR tomorrow.
P.S.: Good job with rx-recompose :+1:

Current coverage is 99.54%

Merging #70 into master will not affect coverage as of 9cbe6f0

@@            master     #70   diff @@
======================================
  Files           40      40
  Stmts          219     219
  Branches         0       0
  Methods          0       0
======================================
  Hit            218     218
  Partial          0       0
  Missed           1       1

Review entire Coverage Diff as of 9cbe6f0

Powered by Codecov. Updated on successful CI builds.

Good catch!
Here's the actual, working example from the test suite: https://github.com/acdlite/recompose/blob/master/src/packages/rx-recompose/tests/observeProps-test.js#L31-L42
If you update the PR to match that, I'll merge it. Otherwise I will fix it myself :)

@acdlite sorry to waste your time, but after I've re-checked your test case (which is not passing as it seems) and the examples I've noticed we were discussing the wrong branch (master).
Branch rx-recompose is fine. Both tests and example are using combineLatest so they are OK. Actually, npm page is OK as well :laughing:, so it's just me who went to docs at GitHub instead of npm.


GH Pipeline Cleanup & Move to Distroless + GHCR

Fixes #903
Fixes #113
Related to #897

Change zarf agent build to distroless vs scratch
Push agent image to GHCR instead of Dockerhub
Implement composite components to make workflows more DRY
Add CodeQL scanning
Normalize workflow / job names
Disable logfile creation for zarf agent
Fix issue with --no-log-file not loading properly
Disable log file creation for cobra help commands, tools, version commands
Disable svelte unused css warning noise
Add CODEOWNERS

Happy to discuss the codeowner section, I did a combination of orgs + individual GH accounts. I like the transparency/version control benefit of using actual GH accounts over just org accounts.

unleash the bugs @jeff-mccoy hid in this!

...and there will be sooo many!


refactor [docker] service

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS


Including RIX equations

Adding these two measurements would make textstat more feature-full.
LIX: https://github.com/mmautner/readability/blob/master/readability.py#L73
RIX: https://github.com/mmautner/readability/blob/master/readability.py#L83
Reference: https://github.com/mmautner/readability

Hi Donald, Thanks for sharing.
LIX is already implemented. But sure we will add RIX.

Please edit the readme regarding LIX and RIX

Hello, first time contributor here. Can I work on implementing the RIX formula as stated in above comment?


should just check the top bit, not two bits

Description
While working on #559, I realized that the condiditon for mul and squaring are the same (potenitally a copy paste error?). Since we're using this optimisation (our method docs), we should probably change the condition to match gnark's.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[ ] Wrote unit tests
[ ] Updated relevant documentation in the code
[ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the GitHub PR explorer

Let me read the code a bit. The reason is that this no-carry implementation was originally for fields where the top two bits are zero (since, in arkworks-rs, previously, the top bit always must be zero). I need to think about whether this is intended.

We actually haven't implemented the squaring optimization; right now our squaring code only uses the flag when deciding which assembly routine to call.
Also, our code now supports 64 * k bit moduli, so we need to check if the top bit is zero still, I believe

@Pratyush we have now :) https://github.com/arkworks-rs/algebra/pull/559


Install without Core Data?

Hi Marty! I understand that there is no way to cache without Core Data, and I can't include another Core Data database in my app at this time, so I am planning on using 'fetch the info' only. Is there any way to install URLEmbeddedView without the repository creating a Core Data store at all? Like 'URLEmbeddedView Light'? : )

Hi, there is no way to install URLEmbeddedView without CoreData.
Although the deadline is not fixed, perhaps it may be implemented in the near future.

I just really need to be able to fetch the data for an individual url. I can try to extract the relevant files but the only reason I ask is that I don't know Swift. I will see if I can find a way to do it. I really like this repository.


App crashes on call to TrackPlayer.setupPlayer()

The app crashes when I call TrackPlayer.setupPlayer() on Android. However, on iOS, the player works fine. If I comment the TrackPlayer.setupPlayer() statement, the app runs as normal.
I am initializing the player in root component like:
App.js
class App extends Component {
componentDidMount() {
TrackPlayer.setupPlayer()
.then(() => {
console.log('player setup');
})
.catch(error => console.log('error occured while setting up player: ', error));
}
render() {
const store = createStore(reducers, {}, applyMiddleware(ReduxThunk));
TrackPlayer.registerEventHandler(createEventHandler(store));
return(
//other stuff
);
}}
Also, I have updated build.gradle file inside the react-native-track-player's android folder like:
compileSdkVersion 26    <-- changed from 23 to 26
 buildToolsVersion "27.0.3"   <--changed from 23.0.3 to 27.0.3
implementation 'com.android.support:appcompat-v7:27.1.1'  <--changed from 23.2.0 to 27.1.1
implementation "com.android.support:support-media-compat:26.+"  <--added
implementation 'com.android.support:design:27.1.1'   <--added

React Native is 57 and Android sdk 27 wasn't supported until release v1.0.0 which was just released. You can find the changelog here.


Update go version in the go integration container

There is one more missing place where Go version wasn't updated.
Addition to changes in PR #620

/uncc jjerger
/cc dorileo
/cc koln67

/assign dorileo

/cc ChaitanyaKulkarni28

/hold

as we talked in private, we must guarantee backward compatibility, I'll inspect the current tests and see if we have the proper guardrails and/or if this is one of them.


Change the config list values to use defineListAllowEmpty to stop them from being corrected into non-existance

Currently due to the use of the regular define method which isn't build for lists the config options get nuked when checked if the configs are correct.
Due to the list values being erased it'll remake the config every time you load the mod.
So currently when you boot up the mod the config will look like this (Pastebin)
After applying the fixes from this PR it looks like this (Pastebin)
(This issue is also in the 1.18.1 version)

Thanks! darkoDance


Remove boilerplate when using Presolve

Each service that needs to be asynchronously initialized during the registration needs to have this boilerplate:
  static NativeCommunicatorService? _initializedInstance;
  static Future<NativeCommunicatorService> getInitializedInstance() async {
    if (_initializedInstance == null) {
      _initializedInstance = NativeCommunicatorService();
      await _initializedInstance!.init();
    }
    return _initializedInstance!;
  }

  Future<void> init() async {
   ...
  }

I would suggest adding some abstract class InitializableDependency and each service would need to override the init(). It would be used like this:
class NativeCommunicatorService implements InitializableDependency {
  @override
  Future<void> init() async {
    ...
  }
}

It would be registered like this:
@StackedApp(dependencies: [
  InitializableSingleton(classType: NativeCommunicatorService),
])
class App {}

The generated code in app.locator.dart would look like this:
  final nativeCommunicatorService = NativeCommunicatorService();
  await nativeCommunicatorService.init();
  locator.registerSingleton(nativeCommunicatorService);

When generating the code we can even check if NativeCommunicatorService is indeed a subtype of InitializableDependency without reflection using this little trick
What do you guys think? Can I implement it this way?

That is a good idea @dvagala I like it.
Please implement and we can merge it into the code. Things to consider when creating a PR.

Please branch off the beta branch since that will be master soon
Add your changes to the change log
Write some notes on how to test the work
Update the example project to include this example with the generated code

@FilledStacks alright, I will come back to this In a few weeks, currently don't have time

Feature was added to the package, I'm closing this.


Create public interface and docs for small modules

This follows a similar pattern to https://github.com/QCoDeS/Qcodes/pull/4224 for the config, math_utils, monitor and station modules.
Note this does not yet update the example notebooks.
Since we only have docs for the master branch, I figured it was better to wait with updating the examples till this is in a release

bors merge


Adding Shubhal Gupta to Before I Die

I am adding Shubhal Gupta to Before I Die with images and text.

@XanderRubio please review this and comment if there is an issue.


Lags in forecasting with TimesFM

I've been working with TimesFM, and I was wondering if it's possible to generate a forecast with a lag, without calculating all the intermediate points. Specifically, if I have data points from 1 to 10 and want to forecast points from 15 to 20, can I do so directly? Or is it mandatory to forecast all points from 11 to 20?
If this functionality isn't currently available, are there any plans to implement it?

Hi @imontoyah, Currently that is not possible and it is not on our immediate roadmap. It is possible in principle but for that we need to retrain our model with corresponding masking.


Conversion and assimilation

pesgores
There are numerous issues with pops not converting from their religion to Secularism or from minority cultures to Primary culture when they should due to there being "No Valid Target" according to the tooltip. During the 350+ years of gameplay, you would think that cultural assimilation would happen when you have 200 extra years to witness the demographic evolution.

pesgores
Thank you for looking into the issues! Now, about Q4, I have a few exemples from my current Portugal save that I have seen occur in all my playthroughs, across many provinces and states all around the world.
Example 1: Religious pops not converting to Secularism

In the Mbanza province, state of North Angola, the Catholic Bakongo Workers can't convert to Secularism because there is "No Valid Target", which means, there is not a single Secular Bakongo Worker in the province for the pop to turn into. But this should happen and the pop should be created, right?

Example 2: Cultures not assimilating when they should be doing so

Still in the Mbanza province, Secular Hutu Labourers secure all the parameters to be assimilated into Secular Portuguese Labourers, but they can't because there is "No Valid Target", for the same reason above.

Example 3: Tooltip lying about assimilation that supposedly occurs

In the same state of North Angola, but in the province of Luanda, the tooltip indicates that a few hundreds of Secular Kimbundu Workers will assimilate into Secular Portuguese Workers every month. However, there isn't a single Portuguese Worker in the state of North Angola, Secular or Religious, or anywhere in my entire country outside of those provinces which had Portuguese Workers when the game begins. So the assimilation never occurs and Portuguese Workers never show up in a new place when they actually should.

All in all, the pop system isn't working as fluidly as one might expect. As the game progresses, provinces turn into a mosaic of rigid Pops who don't change much due to these technical issues.
Here you have the save file where you can find the examples I gave above:


Error

Every time I put in a sentence it comes back with an error code saying "An error has occurred: https://www.signingsavvy.com/https://www.signingsavvy.com/media2/mp4-id/24/24851.mp4"

I have the same issue


[4270] Skip funding rows without amounts

Context
We create a CSV from trainee summary data. The rows of that data sometimes have no associated amounts. We need to not error in that situation and also not display them in the export.
Changes proposed in this pull request

Skip the amount-less rows

Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 [S] Handle empty row amounts


updates for proxy support, pin rake version for errors

PR for #37

To get tests to pass, had to bump the ruby versions by a few (see https://travis-ci.org/flowdock/flowdock-api/jobs/213533082#L207) and seems there is a known issue with rake that needs pinning < v11 (https://travis-ci.org/flowdock/flowdock-api/jobs/231974189#L188)

Oh - and mock needed updates to NOT use token in URL, but passed with BASIC  in Authorization header (https://travis-ci.org/flowdock/flowdock-api/jobs/231977632#L196)

Any chance this is going to be merged in?    I'm running my own version of gem now for a while...  I'd like to push to general population...

hey thanks @pdaugavietis for your contribution!

Nice!


Move zipkin-lens over from https://github.com/line/zipkin-lens

Current Status
We have some steps left before we can merge into master. However, you can test now by checking out the zipkin-lens branch
Server packaged with Lens
The lens UI is bundled into the default zipkin server. If you want to try, you can build locally, then pass the argument --zipkin.ui.source-root=classpath:zipkin-lens to enable lens.
Ex.
$ ./mvnw -Dlicense.skip=true -DskipTests --also-make -pl zipkin-server clean install
$ java -jar ./zipkin-server/target/zipkin-server-*exec.jar --zipkin.ui.source-root=classpath:zipkin-lens

TODO

[x] Remove code of conduct, contributing details as they are inherited from the main project
[x] Clarify if we can replace the license headers with the normal ones (as they will later be rewritten with apache ones anyway)
[x] Integration with spring boot
[x] Add CI integration for zipkin-lens

all good. will merge on green which means people can try snapshot build


Ziti Edge lists the edge router to be offline after recovering from an internet fluctuation

When the Edge router has gained back connectivity to the ziti controller and ziti fabric after an internet fluctuation, the Ziti Edge still lists the edge router as offline.
However, ziti fabric lists the edge router to be online and the edge router continues to serve traffic.

ziti edge shows the router offline, ziti fabric shows the router online.

@shekahamed Would the internet fluctuation have caused multiple routers to reconnect at the same time, or was it a single router? I'm chasing down some leads and could use a better idea of how many routers were trying to reconnect, and/or if individual routers would have been disconnecting rapidly at the same time.

@plorenz It is a single instance of an edge router that is connected to the internet.


Dialogue Util

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] Code quality improvements

How to Test
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Please delete options that are not relevant.

[ ] I have tested this code
[ ] I have updated the documentation

Pull Request Test Coverage Report for Build 5307

6 of 241 (2.49%)  changed or added relevant lines in 14 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-1.3%) to 32.006%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/features/game/GameService.ts
0
3
0.0%

src/pages/academy/game/subcomponents/utils/effects.ts
0
4
0.0%

src/pages/academy/game/Game.tsx
0
5
0.0%

src/pages/academy/game/subcomponents/utils/spriteUtils.ts
0
7
0.0%

src/pages/academy/game/subcomponents/dialogue/DialoguePreloader.ts
0
12
0.0%

src/pages/academy/game/subcomponents/dialogue/DialogueHelper.ts
0
14
0.0%

src/pages/academy/game/subcomponents/scenes/Scratch.ts
0
14
0.0%

src/pages/academy/game/subcomponents/scenes/PlayGame.ts
0
18
0.0%

src/pages/academy/game/subcomponents/dialogue/DialogueManager.ts
0
25
0.0%

src/pages/academy/game/subcomponents/utils/styles.ts
0
29
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/pages/academy/game/Game.tsx
1
0%

Totals

Change from base Build 5268:
-1.3%

Covered Lines:
1734

Relevant Lines:
5050

💛  - Coveralls


Precondition tableExist is case insensitive

Search first

[X] I searched and no similar issues were found

Description
Hey everyone!
It seems that the precondition tableExist is case insensitive even using the QUOTE_ALL_OBJECTS strategy.
Context:
Due to some changes, we had to change a table from uppercase to lowercase.  We used a changeset similar to the following to drop the table:
    <changeSet author="feedzai" id="drop-users-table-uppercase">
        <preConditions onFail="MARK_RAN">
            <tableExists tableName="USERS"/>
        </preConditions>

        <dropTable tableName="USERS"/>
    </changeSet>

The problem is that this  <tableExists tableName="USERS"/> will return sucess for lowercase table as well.
Steps To Reproduce

Execute the following changelog

<?xml version="1.1" encoding="UTF-8" standalone="no"?>
<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
                   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd"
                   objectQuotingStrategy="QUOTE_ALL_OBJECTS">

    <changeSet author="liquibase" id="create-users-table-uppercase">
        <preConditions onFail="MARK_RAN">
            <not>
                <tableExists tableName="USERS"/>
            </not>
        </preConditions>

        <createTable tableName="USERS">
            <column name="uuid" type="VARCHAR(40)">
                <constraints nullable="false"/>
            </column>
            <column name="name" type="VARCHAR(120)">
                <constraints nullable="false"/>
            </column>
        </createTable>
    </changeSet>

    <changeSet author="liquibase" id="drop-users-table-uppercase">
        <preConditions onFail="MARK_RAN">
            <tableExists tableName="USERS"/>
        </preConditions>

        <dropTable tableName="USERS"/>
    </changeSet>

    <changeSet author="liquibase" id="recreate-users-table-lowercase">
        <preConditions onFail="MARK_RAN">
            <not>
                <tableExists tableName="USERS"/>
            </not>
        </preConditions>

        <createTable tableName="users">
            <column name="uuid" type="VARCHAR(40)">
                <constraints nullable="false"/>
            </column>
            <column name="name" type="VARCHAR(120)">
                <constraints nullable="false"/>
            </column>
        </createTable>
    </changeSet>
</databaseChangeLog>

Clean the databasechangelog from database
Execute the change again

Expected/Desired Behavior
The changelog will fail beucase it's trying to drop the USERS table that doesn't exist.
Liquibase Version
4.25
Database Vendor & Version
Postgres 14.4
Liquibase Integration
CLI
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
Ubuntu
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

Hi @modiboa, thank you for reporting this issue.
I have been able to verify it using Liquibase v4.25.0 and PostgreSQL v16.0
There are currently some known casing issues, so this is something we want to look into. I'll be forwarding this to the development team.
I'll describe my tests for the developers:

Create a changelog with the following changesets:

  <changeSet id="1" author="tati">
    <createTable tableName="USERS">
      <column name="uuid" type="VARCHAR(40)">
        <constraints nullable="false" />
      </column>
      <column name="name" type="VARCHAR(120)">
        <constraints nullable="false" />
      </column>
    </createTable>
  </changeSet>

  <changeSet id="2" author="tati">
    <preConditions>
      <tableExists tableName="users" />
    </preConditions>
    <insert tableName="USERS">
      <column name="uuid" value="Takes users as equal to USERS"/>
      <column name="name" value="changesets 1 and 2"/>
    </insert>
  </changeSet>

Run liquibase update

Both changesets will be run.
The expected behaviour is for users to be recognised as different from USERS and for the second changeset not to be run.
Thanks,
Tatiana

@hylkevds I was able to reproduce it without setting the objectQuotingStrategy, so it used the default value of LEGACY. What database and Liquibase version are you using?

I'm using a recent version of PostgreSQL, and didn't know the default was LEGACY. I was assuming the default would be QUOTE_ONLY_RESERVED_WORDS...
Regardless, a little debugging tracked it down to:
https://github.com/liquibase/liquibase/blob/53db8b6d12a9db371bbcd620f99aca954d3bbbfd/liquibase-standard/src/main/java/liquibase/diff/compare/core/DefaultDatabaseObjectComparator.java#L29
Which does a hard name.toLowerCase()... It doesn't even check accordingTo.isCaseSensitive() let alone accordingTo.getObjectQuotingStrategy().
Adding a check for accordingTo.isCaseSensitive():
        if (accordingTo.isCaseSensitive() || accordingTo.getObjectQuotingStrategy()== ObjectQuotingStrategy.QUOTE_ALL_OBJECTS) {
            return new String[] {name};
        }
        return new String[] {name.toLowerCase()};

This causes errors in one test. Specifically:
https://github.com/liquibase/liquibase/blob/53db8b6d12a9db371bbcd620f99aca954d3bbbfd/liquibase-standard/src/test/groovy/liquibase/diff/compare/core/TableComparatorTest.groovy#L29
and
https://github.com/liquibase/liquibase/blob/53db8b6d12a9db371bbcd620f99aca954d3bbbfd/liquibase-standard/src/test/groovy/liquibase/diff/compare/core/TableComparatorTest.groovy#L36
But those test just look wrong: They test with caseSensitive=true on names with different case, and expect them to be the same?? Even worse, the explanation for the second one claims to test for catalog/schema case, but those actually have the same case!
Fixing that test is easy, unfortunately, some H2 integration tests also break. I've not figured out why yet.

About the default value, LEGACY vs QUOTE_ONLY_RESERVED_WORDS only changes if you're using PostgreSQL, which is the case for you. The documentation page explains this a bit better:

QUOTE_ONLY_RESERVED_WORDS – The same logic as LEGACY, but without mixed-case objects in PostgreSQL databases.

Good catch with the database object comparator! We will keep it in mind when we implement the fix.
If you want to submit a PR, feel free to do so! Our devs would be available to provide guidance if necessary.
Thank you,
Tatiana

The DefaultDatabaseObjectComparator seems to be just the tip of a messy iceberg. Liquibase seems to depend on all the comparisons not being case sensitive when reading a database and comparing snapshots. It sets the ObjectQuotingStrategy to QUOTE_ALL_OBJECTS in many places, like SnapshotCommandStep. But if we now make the comparisons case sensitive, the snapshots made by SnapshotCommandStep are no longer compatible with changelogs that are using LEGACY or QUOTE_ONLY_RESERVED_WORDS . The StandardDiffGenerator even fails to see that two snapshots made on the same database are the same, and tests start to break.
The problem goes as far as the hashCode() method in the Table class that does a toUpperCase() on the name before generating the hashCode, meaning that two tables with names that only differ in case (as in both @modiboa and my use case) can not be stored in the same Set (though I don't know if Liquibase ever does this).
I suspect that, since the ObjectQuotingStrategy can be set on a per ChangeSet basis, the only way to solve this fundamental problem is to make creating snapshots always case sensitive, but make the case sensitivity configurable for each compare that is made to this snapshot.


[installer] Collect only the OAuth Discovery Endpoint and infer other URLs

Description
Collect only the OAuth Discovery Endpoint and infer other URLs during the setup wizard.
This will improve the overall UX of the installation process as well as avoid the confusion having to enter multiple URLs in the setup wizard.

Closing the issue as this repo is no longer maintained.


[L5.4] Sync Model with other ->Integrity constraint violation

Laravel Version: 5.4.10
PHP Version: 7.1
Database Driver & Version: MySQL 5.7.17

Description:
I have this issue "SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '21' for key 'PRIMARY'.
I understand the problem, but after inspection, I have found the variable "exists" in Model was not  "true" but "false" when i save my model and with a mutator who save this model before add sync with an other model.
It's a bug, or i do something bad ?
PS: i don't have this issue with Laravel 5.2.
Steps To Reproduce:
Controller
public function store(EstablishmentRequest $request)
    {
        $establishment = Establishment::create($request->all());
        return redirect(...);
    }

Model
Public function setCardsListAttribute($value)
    {
        if ($this->id == NULL)
            $this->save();
        return $this->cards()->sync($value);
    }

To solve this issue, I have found this option : (Illuminate\Database\Eloquent\Model - L500), but it's not a good solution, works only if there is an 'Id'
if ($this->exists || $this->id)

It's very odd that you're trying to save the model while mutating one of its attributes, mutators aren't meant to be used to set relationships as well.
Save the model and then save the relations, I can imagine your approach causing many issues, maybe duplicate model creation is one of the problems you'll face, because you save the model while in the middle of an operation that should actually save the model !!

Like @themsaid stated, you will indeed get very strange behavior using a mutator this way. A mutator is responsible for setting the value of an attribute on the model. Calling 'save' and performing a 'sync' operation inside a mutator, will definitely cause problems. Not sure exactly what you're trying to accomplish but if you need to make decisions and perform operations when 'saving', maybe hook into the 'saving' event? Or just save the model and then perform any sync operations.

Ok, I do something mal ;)
Thx for your comments.


Publish selendroid release artifacts to jcenter

Commit summary:
This commit would enable us to publish the release artifacts to jcenter using the command
gradle -PbintrayUser=<username> -PbintrayKey=<key> clean bintrayUpload.
( where <username> and <key> are bintray account's username and API key).
Also, the published artifacts can be automatically synced to maven central repository by using OSS credentials under bintray task of gradle script.

Also for use with CI systems, the environment variables BINTRAY_USER BINTRAY_KEY can be used to provide the credentials instead of command line arguments.


Access to underlying CBPeripheral

Let's say I already have an instance of RxBlueoothKit::Peripheral class available. How to get an access to underlying CBPeripheral instance? I have third-party library that performs Device Firmware Update (DFU) :
https://github.com/NordicSemiconductor/IOS-DFU-Library/tree/master/documentation
and it asks for reference to CBCentralManager and CBPeripheral, so would be great if I could just get it from already existing instance of RxBlueoothKit::Peripheral.
Thank you, your library is outstanding.

Hi there,
Basically, you have reference to RxBluetoothKit::Peripheral. This instance has access to the peripheral property which is RxPeripheralType instance. This is a protocol, which allows us to test our implementation. We've built on it Fake objects, aswell as real RxCBPeripheral object. This object has property let peripheral: CBPeripheral. Unfortunately, because thanks to this RxPeripheralType protocol, usage assumes that you shouldn't access RxCBPeripheral because it's implementation detail. It's class with internal access so it's not really possible as of now.
One solution that comes to my mind quickly is to fork library and add public scope to two places:
public class RxCBPeripheral: RxPeripheralType {

	public let peripheral: CBPeripheral
	[...]
}`
Then, assuming that your `Peripheral` instance is named `peripheral` you'd write it like:
`let cbPeripheral = (peripheral.peripheral as! RxCBPeripheral).peripheral`

Which looks ugly, but should work properly.
We'll talk about your problem internally, because it's interesting case and we should take such into consideration.
We'll let you know soon about our thoughts.

Thanks for help in improving library!

Hi,
Have you managed to deal with this problem somehow?
Thanks!

Hi all, I work with @mobiletoly now, and have gone through a few iterations of adding accessors for CBCentralManager and CBPeripheral to support our integration with Nordic's firmware update library.  Please see this branch in our fork of RxBluetoothKit for the current work, and its diff vs. master.
A significant challenge is providing access while avoiding a cascade of public properties and types within the library.  After a few iterations, the above has largely settled out.  The basic idea is to provide explicit accessors on Peripheral that let us obtain the wrapped CoreBluetooth objects.
FWIW, I view this as a starting point for discussion, not a definitive solution.  All feedback welcome!

Hi there,
We're planning development of 4.0 version of library which will consist major changes in API and internal structure design of objects in lib. We think of access
We want to achieve the same goal as you do, but without performing force casting, and rather to use swift protocols with associated types and be sure in compile time that the CoreBluetooth instance is there. You're welcome to take a look at the general idea in #79, you're feedback is welcome
Cheers,

Bummer - I in the same boat. No access to the underlying structures is a deal breaker :-(
Is there any progress on this? or the 4.0 version?

Hi @tcurdt,
We're working on 4.0, but we're partially blocked by the Swift lang functionalities. I will talk about this with my coworkers and try to develop temporary solution soon.
Thanks for patience,

@Kacper20 Thanks for the quick reply!
Could you elaborate on the blocking? Or are you planning to switch to Swift4?
If the API changes in 4.0 anyway - maybe merging from @jwhitley and making a new release could be an option?

Hi,
Yeah, of course. We're having entire new architecture for 4.0 that is somewhat similar in terms of interfaces but testing of implementation is based solely on protocols with associated types. It allows us to expose CBPeripheral object in a clean way, without any force casts in implementation classes.
It'll be only Swift 4.X, we'll be still maintaining the earlier versions of course. X is because our architecture right now is crashing the compiler when WMO is disabled, you can find the bug reported here: https://bugs.swift.org/browse/SR-5286. We're not sure when it'll be fixed.
Because right now it's impossible to access CBPeripheral and we don't want to keep it longer that way I think that we'll be implementing ugly forcecast to expose CBPeripheral. It's not ideal in terms of clean code, but works always and should be really useful for the users. I still have to talk with @Cierpliwy on this topic and we'll decide what path to take. It would be in 3.1 release of our lib.
Thanks,

@tcurdt We've decided to go with this and #129 will add this functionality. Should be merged soon to master.
Thanks for patience

It's now ready in 3.1 version of the library. Will be available in any future versions with more pure implementation.


Unit test for function to retrieve CloudWatch configuration

Description
Unit test for function to retrieve CloudWatch configuration
Fixes #748
Type of change

Unit tests (no changes in the code)

Testing steps
To be checked on CI.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1c32fc0) 70.23% compared to head (695747d) 70.28%.

:exclamation: Current head 695747d differs from pull request most recent head e44f69b. Consider uploading reports for the commit e44f69b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   70.23%   70.28%   +0.05%
==========================================
  Files          25       25
  Lines        3766     3766
==========================================
+ Hits         2645     2647       +2
+ Misses        854      852       -2
  Partials      267      267

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ISSUE-15] Ingest the new server files from bundle in app

Description
Ingests the new server defined files which moves us towards an index file to show all annotations on the map and individual files for each canyon. This allows us to get all of ropewiki in the app.
Issues:

Until we address https://github.com/bricepollock/canyoneer/issues/6 we will not be able to get all canyon TOPO lines on the map.
Need to perform a performance test now that we are up to 10k annotations on map instead of 1.6k as before. There was some slowness in simulator.

We shouldn't release another version until we've addressed these issues
WARNING: ID for canyons is changing, but this has no effect on the app. For example, the only persisted data is favorites and we store them as a collection to a static key that is remaining unchanged. This ID is currently only is ever used for in-memory changes. Might want to think about a more complex ID than just the INT in case we get data from other sources also with simple IDs...
NOTE: "Database" migration is being done for our persisted favorite data from old to new format.
Test Plan

Panned around the map
Launched a canyon and its detail-map with topo lines
Tests

Explore away! A few thoughts from past experience:

In the past I had to write these auto-gen automation by hand so would be more open to out of the box auto-generation if that exists these days. Even if we do that, we'll still have to write conversions to the internal object classes and migrations for persisted objects when things change.
We can host files elsewhere, but will still have to pull all them down regardless to run the app and build an archive. I don't "think" we'll have git issues outside of this PR since git only cares about changes.


Install with laravel 8

Hey i just required it with fresh laravel 8 project and i got these :
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - wyrihaximus/react-child-process-messenger[2.7.1, ..., 2.10.0] require doctrine/inflector ^1.0 -> found doctrine/inflector[v1.0, ..., 1.4.x-dev] but the package is fixed to 2.0.3 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

    - badfarm/zanzara 0.5.1 requires react/filesystem ^0.1.2 -> satisfiable by react/filesystem[v0.1.2, 0.1.x-dev].

    - react/filesystem[v0.1.2, ..., 0.1.x-dev] require wyrihaximus/react-child-process-pool ^1.3 -> satisfiable by wyrihaximus/react-child-process-pool[1.3.0, ..., 1.6.0].

    - wyrihaximus/react-child-process-pool 1.6.0 requires wyrihaximus/react-child-process-messenger ^2.10 -> satisfiable by wyrihaximus/react-child-process-messenger[2.10.0].

    - wyrihaximus/react-child-process-pool[1.5.0, ..., 1.5.1] require wyrihaximus/react-child-process-messenger ^2.9 -> satisfiable by wyrihaximus/react-child-process-messenger[2.9.0, ..., 2.10.0].

    - wyrihaximus/react-child-process-pool[1.3.0, ..., 1.4.2] require wyrihaximus/react-child-process-messenger ^2.7.1 -> satisfiable by wyrihaximus/react-child-process-messenger[2.7.1, ..., 2.10.0].

    - Root composer.json requires badfarm/zanzara ^0.5.1 -> satisfiable by badfarm/zanzara[0.5.1].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Can you help me ?

Have you tried the same solution at #3?

It would be nice  if this package work with laravel without any extra work on composer json

Yes I agree, we added the task on the project board.

Fixed in 0.6.0


run python with unbuffered stdout

@ngtuna I am merging this. We should build a new event-consumer runtime. I am hoping this is the issue.


compiler crashes with allowJs and dynamic import

TypeScript Version: 3.1.3 2.9.2
Code
tsjs-crash.zip
Minimal example is in the attached zip package. Extract it somewhere, go to main directory with tsconfig.json and
install
npm i
compile
node node_modules/typescript/bin tsc
Expected behavior:
everything works fine - preferred, because with TS 2.8.x there are no errors,
or some reasonable error message for problem solving
Actual behavior:
compiler crashes with
 E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:69365
                throw e;
                ^
TypeError: Cannot read property 'parent' of undefined
    at Object.getDeclarationOfExpando (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:7328:19)
    at getTypeOfFuncClassEnumModule (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:28883:40)
    at getTypeOfSymbol (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:28984:24)
    at checkImportCallExpression (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:40833:96)
    at checkExpressionWorker (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:42356:32)
    at checkExpression (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:42301:42)
    at checkAwaitExpression (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:41525:31)
    at checkExpressionWorker (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:42383:28)
    at checkExpression (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:42301:42)
    at checkExpressionCached (E:\projects\vscode-crash\node_modules\typescript\lib\tsc.js:42182:38)

Problem is with the imported javascript in TestComponent.tsx with
async exportToXlsx(exportSelected: boolean = false) {
    const xlsx = await import('./js-xlsx/xlsx');
}

Problem is only with Typescript 2.9, 3.x, Typescript 2.8 compiles without any errors.
I tried to exclude javascript with tsconfig.json and jsconfig.json - see exclude properties in these files, but nothing works. Javascript is always compiled. So another question - is it possible exclude javascripts in similar situations?

The immediate cause is the improved handling of module.exports in Typescript 2.9. The compiler is trying to figure out what the exports of ./js-xlsx/xlsx are, but somehow creates a defective export= symbol from the line module.exports = CFB.
Workaround
Any time you import a file, the compiler will read that file. Excludes will not help you. For a JS file that you do not want to compile, but nonetheless want to import, the easiest workaround is to put a d.ts file next to it. Here's the one I created:
// @Filename: components/js-xlsx/xlsx.d.ts
declare var dummy: any;
export = dummy;

This just exports a dummy variable with the type any so that the compiler doesn't spend any time analysing xlsx.js to figure out what it actually exports.

Here's a small repro:
// @Filename: mod1.js
exports.version = 1
module.exports = NotDefined
// @Filename: test.js
import('./test')

Thank you for analysis and workaround. I will try it.
I found another possible workaround. I made another node_modules directory and copy the whole directory js-xlsx inside it. So the directory tree is components/node_modules/js-xlsx`/xlsx.js.
Dynamic import will be import('js-xlsx/xlsx).
It seems that because of module resolution or something like that, the compiler ignores the node_modules even of dynamic import. Final app is build via webpack and babel and it seems it has no problem with it.
What do you think about that?
I definitely waiting for the final typescript fix, thank you.

Duplicating part of the source tree seems hackier than dropping a d.ts in beside the .js file.
Anyway, the fix is simple so it should be in typescript@next in the next day or two.


CSS file included in angular-cli.json results in empty  tag

Versions.
angular-cli: 1.0.0-beta.21
node: 6.9.1
os: win32 x64
Repro steps.
The following CSS dependency (https://github.com/HubSpot/offline/blob/master/themes/offline-language-english.css) when listed in angular-cli.json as a CSS dependency, generates an empty styles tag in my index.html when served - so it's not really included:
"styles": [
"styles.css",
"../node_modules/offline-js/themes/offline-language-english.css"
]
The log given by the failure.
None
Mention any other details that might be useful.
It's the only CSS file that behaves like this. Could it be characters in it or something?

Did you mean ../node_modules/? Or just simply node_modules?

Note that, as an error, we should probably check that the files exist, so I'll fix that.

My path is alright, other CSS files in node_modules  are included. My actual styles arrays looks like this and only that specific file is not included:
"styles": [
"styles.css",
"../node_modules/bootstrap/dist/css/bootstrap.min.css",
"../node_modules/angular2-toaster/lib/toaster.css",
"../node_modules/offline-js/themes/offline-language-english.css",
"../node_modules/offline-js/themes/offline-theme-default.css"
],

oh I see. That's strange. Let me investigate.

Thanks ;-)

Could you double check that the content of that file isn't in styles.bundle.js? When I include it locally I see it there. It's a really small style file so it might get included.

I can see the contents of my CSS file in styles.bundle.js. The result is not working though. As a temporary workaround I had to include the CSS stylesheet manually in my index.html.

When I serve the page I see the style tag being full. Sorry, without a project I can't really see what's wrong. Closing as non reproducible.

I can provide you with a package.json file if needed. There's still a bug somewhere.

If you can provide me with a project that repros it I'm willing to take a look.

I've the same problem when I import the flexboxgrid.css

@hansl  Unfortunately my client's project is not an open-source one and I can't share it.

https://github.com/mbakker96/overview-application here is my project

@mbakker96 just cloning that, npm install then ng serve, I get the CSS properly inserted in the page:

There's an empty tag (from a component), but it's not flexbox. That project works fine.

But why is the style then not applied to the links (left) midden (middle) and rechts (right). I use flexboxgrid to create columns but it is not applied to the html style.


feat: git integration (gitignore file filter and avoid overwriting uncommitted files)

Adds a basic git integration for filtering files and avoiding overwriting files accidentally, includes:

use gitignore to filter files from the edit list
Initially I used fnmatch since it's builtin but unfortunately it differs too much from the git implementation to be useful. Instead it will use git check-ignore.
give a warning if gptengineer is about to override uncommitted changes, letting the user stage them
It will check whether there is any overlap between the edited files and uncommitted files (whether they are tracked by git or not) and ask whether the files should be staged before being overwritten.
Add --yes CLI option
if not improve and git is installed we will initialize an empty git repo at the project root
Also fixed a trailing whitespace issue in ROADMAP that caused prechecks to fail

It will do a O(n^2) op when comparing file names against the gitignore. This might be unpractical if the user has a lot of ignored files, I'm not sure?

@similato87 would be great to have your feedback regarding the changes to FileSelector.

@similato87 would be great to have your feedback regarding the changes to FileSelector.

The enhancement to the FileSelector part is great! Thank @Styren for implementing these changes. Introducing the ability for users to stage changes before applying them is a significant improvement. Currently, the workflow involves applying changes directly, which necessitates users to recover modified files from their local git history if needed.
My concern revolves around the possibility of incorporating a parallel functionality, similar to "restore," to ensure the "improve" function maintains a streamlined workflow. What's your idea, @ATheorell ?

Thanks for feeback @similato87
I believe that, there is balance between on the one hand, make sure that the users consents to changes and on the other hand, don't make too many question dialogues. Getting this balance right may be hard in one shot, so I think its fair to go for one workflow and make small changes later in case we feel like we didn't strike a good balance.
For now, I would suggest: Show the user the diffs as they are streamed (already default). Ask the user to consent to apply the changes (do you agree?). Additionally, if the user has git, we will automatically stage unstaged changes. In this case the user has the more cumbersome option of going into git and reverting manually.
What do you think @Styren ?

From the UX POV, I'd agree with this - makes sense.
As for the more cumbersome option I think it's an okay option - still leaves them the ability and opportunity to revert manually if something's not to their liking.

For now, I would suggest: Show the user the diffs as they are streamed (already default). Ask the user to consent to apply the changes (do you agree?). Additionally, if the user has git, we will automatically stage unstaged changes. In this case the user has the more cumbersome option of going into git and reverting manually.

Thanks for feeback @similato87
I believe that, there is balance between on the one hand, make sure that the users consents to changes and on the other hand, don't make too many question dialogues. Getting this balance right may be hard in one shot, so I think its fair to go for one workflow and make small changes later in case we feel like we didn't strike a good balance.
For now, I would suggest: Show the user the diffs as they are streamed (already default). Ask the user to consent to apply the changes (do you agree?). Additionally, if the user has git, we will automatically stage unstaged changes. In this case the user has the more cumbersome option of going into git and reverting manually.
What do you think @Styren ?

Sounds good 👍
I've updated the PR to stage uncommitted files automatically (without consent) but ask for confirmation on improve prompts if there are any changes, irregardless of whether git is installed.

This seems great!
What's the next step to get this merged?

Fixed the last linting issues. Should be ready to merge unless you have any additional input @ATheorell ?


The specification describes the path of special url as a list

It says....

A URL’s path is either a URL path segment or a list of zero or more URL path segments, usually identifying a location. It is initially « ». A special URL’s path is always a list, i.e., it is never opaque. A URL has an opaque path if its path is a URL path segment.

Are we standard compliant ?

Note that if we store a path as a string with '/' delimiters, then it is not difficult to offer it as a list, if needed. You can simply have a list of string_view instances.

Yes, I made this optimization to improve path state. We’re spec compliant. It was wrong for the spec. to define the data structure of a component. (and slow too)

We can return a list of std::string_view when the path is not opaque and the user desires a list. It does not need to affect the parsing performance and it can be optional. We can partition the path "on demand".

Pathname getter always serializes and converts list to string by concatting the list items. There's no need to provide an API to get list entries.

The pathname getter steps are to return the result of URL path serializing this’s URL.

I'm closing this, since it does not apply to our case.


[Remove request]

Domain you want removed
personalfirewall.comodo.com
Why should this domain be removed?
This domain is owned by Comodo and contains no porn or drugs.
See https://github.com/arapurayil/aBL/issues/16 for more data

@AdroitAdorKhan any progress?

@AdroitAdorKhan any progress?

Please request for any further change at here block or here (energized.pro/issue).
I don't get to check the issues here that much.

@AdroitAdorKhan it seems this issue has already been resolved:

Thank you for fixing it!

I don't get to check the issues here that much

As a list maintainer, I can understand