rework transaction size estimation with grosser approximation

Issue Number

ADP-567 / ADP-569
Overview

[ ] I have reworked transaction size estimation with grosser approximation

Comments

The function for calculting the size of a transaction in Shelley had
grown out of hands and became a function really hard to reason about
and debug. We kept running into either performance issues or simply
incoherent fee calculations. This commit takes a simpler approach to
the problem which is very straightforward to follow, but comes at the
cost of slightly grosser approximations (in the sense that the
calculated size will tend to be bigger than the actual size). Yet,
there are several parts we could iterate on might it be necessary.

It "feels" that fee estimation is now faster also

I would definitely expect that. The fee calculation and size estimation are now just a bunch of additions. No more bytestring being generated or fake signatures, or fake serializations... Just adding numbers.

bors merge

bors retry

bors retry

bors r-

bors retry

bors r


Clean up VPN waitlist

Task/Issue URL: https://app.asana.com/0/488551667048375/1207044624863061/f
Description
Remove the code for VPN beta
Steps to test this PR
Smoke test PPro and VPN

#4440  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


No longer able to interact with the "add server" button

After adding the URL of the server, I'm not able to add it to the list. The button doesn't actually look clickable. I'm running the latest version of uProxy on a Nexus 5X.

Oh shazbat - all works when I build from master but not when I install via the Play Store. I think some assets must be missing in our release build. Investigating.

OK I believe I have a solution but it took a little longer than expected so will have to push an update tomorrow instead. Thanks again for the report!

I just uploaded a fixed APK to the store - last-minute emergency releases FTW!
Long-term fix to prevent this happening again under review here:
https://github.com/uProxy/uproxy/pull/2828


Add --shutdown-on-slot-synced test and ensure ExitSuccess

Fixes https://github.com/input-output-hk/cardano-node/issues/3646
This does 2 things:

Adds a test that starts a node with --shutdown-on-slot-synced x and checks that the exit code is 0 and that the chain tip is close to x.
Rethrows the ExceptionInLinkedThread _ ExitSuccess exception as an an unwrapped ExitSuccess exception. This means the process's exit code will be 0 rather than 1 (this is asserted by the new test).

Can you document how the test fails without the changes so it's easier to understand what this PR does to the behaviour of cardano-node?

I've removed one commit that is already in another PR: https://github.com/input-output-hk/cardano-node/pull/3641

I've increased the timeout of the test while checking for termination every second in hopes that the test will succeed on CI.

I've added a new commit "Allow tests to specify custom node CLI options for local testnet" and used this to greatly simplify the test added in this PR.

I had to increase the running time of the test as it seems that some times the test would finish without any log messages re. chain tip.


Expose viewports render target RID

This PR exposes the render target RID for our viewport. This is needed in some GDExternals that want access to our render target.

@clayjohn this is another small PR that exposes some info that we need in the tilt5 extension

Thanks! Merged.

Cherry-picked for 4.0.3.


fix: eliminate assumptions that "default" is the default kube namespace

Fixes #4764

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

will be released in 8.8.1


Is it possible to apply this strategy to reasonably big areas (regional scale)?

PGI multi-physics inversion utilising a dynamic Gaussian mixture model (GMM) technique was implemented on extremely small scale area (600 m 600 m) potential field data sets in this work (Astic et al., 2020). Is it possible to apply this strategy to reasonably big areas (regional scale)? If so, what assumptions should I think about?

It is a good and still open question.
There is no intrinsic limitation on the scale, given the necessary memory and CPU, and the PGI strategy can be applied to any problem that SimPEG can handle.
The question is indeed in terms of assumptions, and the design of your GMM: how many units (number of clusters)? Will it be better to specify or learn the petrophysical means? etc.
My guess: start with a small number of units (like 3 to start with, including the background), and add units as needed; surface geology information on the location of units (through the GMM proportions) could be a key to make it work at large scale.

@ramaarksuri , also, PGI now works with the main distribution of SimPEG, check out the tutorial: http://docs.simpeg.xyz/content/tutorials/13-pgi/index.html

thank you
On Sat, Jul 10, 2021 at 9:23 PM Thibaut Astic @.***>
wrote:

@ramaarksuri https://github.com/ramaarksuri , also, PGI now works with
the main distribution of SimPEG, check out the tutorial:
http://docs.simpeg.xyz/content/tutorials/13-pgi/index.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/simpeg-research/Astic-2020-JointInversion/issues/6#issuecomment-877659520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ45XTW3APLIL66A4W5B3LLTXBUH3ANCNFSM5AEH6M3Q
.

--
With Regards
Rama Chandrudu Arasada
SRF, AGP, IIT (ISM) Dhanbad.


Laravel version mismatch after Vue 2.4 fiasco

Version
2.4.1
Reproduction link
https://jsfiddle.net/50wL7mdz/46634/
Steps to reproduce

composer global require "laravel/installer"
laravel new my-app
cd my-app
yarn
yarn run dev

What is expected?
It to work.
What is actually happening?
Module build failed: Error:
Vue packages version mismatch:

<EMAIL_ADDRESS><EMAIL_ADDRESS>

Pls?

Please upgrade vue-template-compiler to v2.4.1.


FYI there is abx2xml tool in AOSP /system/bin

While there is no comment block in your blog post, use an issue instead.
If you only want to view the xml content in adb shell, just use abx commands.
abx2xml input.xml output.xml
or abx2xml -i 0.xml to overwrite the original xml file.

Might update to blog or README.md


[libpatialite] Fix host dependency

What does your PR fix?
Fixes a dependency which lacked "host": true.

Which triplets are supported/not supported? Have you updated the CI baseline?
unchanged, no

Does your PR follow the maintainer guide?
yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
yes

Affected by baseline regression, to be fixed by #26698.

Needs merge your PR #26698 first.


Parallel compose only works sequentially

I tried to implement a simple parallelFor using the underlying threadpool.
template <typename FuncType>
auto parallelFor(FuncType&& function, size_t size) {
  // Skipping bits similar to parallelMap
  ...
  for (size_t i = 0; i < size; ++i) {
    futures[i] = threadPool.get().enqueue(
      [size, i, &function, &eMutex, &eQueue]() -> OutType {
        try {
          return function(i);
        } catch (...) {
          .....
        }
      }
    );
  }
  ....
  }
  return out.value();
}

When using this method to perform the various for loops which according to the comments, should be independent on the iteration, I found that the code tends to fail. So far, my guess as to the source of the error is in the computeNodeAndArcPair function, although not sure.
An easy way to reproduce this error is to reverse the order in which the arcs are being processed. For instance on line 668
    for (int tid = totalArcs - 1; tid > 0; --tid) {

Again the same on line 491 and line 372

Were you running this on the GPU or the CPU? E.g. which compose function are you calling? Can you share the full code you ran?

The test in question is being run on the CPU, I haven't run this on the GPU to check.
There are two ways to reproduce the error, both of which are available on the following gist as patches
https://gist.github.com/ptigwe/d066f45df728c9326df74b51db17c030
And for each one of the two patches, running make build && ./test/parallel_compose_test is sufficient to reproduce the error.

I would recommend using the sequential compose and threading at the level of the full graph if you are doing CPU composition. This should work out of the box with our parallelMap.
Our CPU parallel compose is not well optimized or well tested as we have been prioritizing the CUDA implementation.


entrega 1 - grupo 02

Integrante 1 - Giacobbe, Juan Ignacio
Integrante 2 - Fernandez Boch, Valeria
Integrante 3 - Olaran, Sebastian
Integrante 4 - Friedenberger, Tania
Integrante 5 - Cusihuaman Altagracia, Luis Eduardo
12 casos de usos

Codecov Report

Merging #1 (1fd20a8) into release/entrega_01 (8b7531b) will decrease coverage by 20.17%.
The diff coverage is 79.83%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@                    Coverage Diff                    @@
##             release/entrega_01       #1       +/-   ##
=========================================================
- Coverage                100.00%   79.83%   -20.17%
- Complexity                    5       95       +90
=========================================================
  Files                         2       22       +20
  Lines                        10      243      +233
  Branches                      0       21       +21
=========================================================
+ Hits                         10      194      +184
- Misses                        0       43       +43
- Partials                      0        6        +6

Impacted Files
Coverage Δ

src/main/java/clases/ParcelaDePasarela.java
57.14% <57.14%> (ø)

src/main/java/clases/AlgoDefense.java
63.04% <63.04%> (ø)

src/main/java/clases/Mapa.java
68.96% <68.96%> (ø)

src/main/java/clases/ParcelaRocosa.java
71.42% <71.42%> (ø)

src/main/java/clases/ParcelaDeTierra.java
76.92% <76.92%> (ø)

src/main/java/clases/Hormiga.java
81.81% <81.81%> (ø)

src/main/java/clases/Arania.java
85.71% <85.71%> (ø)

src/main/java/clases/Defensa.java
85.71% <85.71%> (ø)

src/main/java/clases/TorreBlanca.java
85.71% <85.71%> (ø)

...c/main/java/Excepciones/CreditosInsuficientes.java
100.00% <100.00%> (ø)

... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


prezipped data not found

The instructions  for "Download the flight data" take you to https://www.transtats.bts.gov/DL_SelectFields.asp?gnoyr_VQ=FGJ . Clicking on "prezipped" then "download" takes you to https://transtats.bts.gov/PREZIP/_Reporting_Carrier_On_Time_Performance_1987_present_2021_1.zip which throws a 404 Not Found.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f345421f-01f3-d49e-24f4-d8e151d2b5d9
Version Independent ID: 6ad56353-e857-523b-4b6b-3ca4db981ee5
Content: Tutorial: Azure Data Lake Storage Gen2, Azure Synapse
Content Source: articles/storage/blobs/data-lake-storage-use-sql.md
Service: storage
Sub-service: data-lake-storage-gen2
GitHub Login: @jovanpop-msft
Microsoft Alias: jovanpop

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

@cataggar Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

#reassign: @normesta

Thanks for reporting this issue. Because this data was hosted on a third-party site, the link breaks from time to time. The data is now hosted here - https://github.com/Azure-Samples/AzureStorageSnippets/blob/master/blobs/tutorials/On_Time_Reporting_Carrier_On_Time_Performance_1987_present_2016_1.zip. I've updated the article to point to that new location. The article change will appear live later this morning.
#please-close

Hey @cataggar, I also noticed that the URL was broken and lead to a 404 error page. However, I was able to access the same location using a different link. Here's the working link
https://transtats.bts.gov/DL_SelectFields.aspx?gnoyr_VQ=FGJ&QO_fu146_anzr=b0-gvzr


Integration won't calculate since May 25th.

What happened?
Since May 25th integration won't calculate. Log shows error about asynchronous function, but if I add 'await' in line 1142 then it will throw another error:

TypeError: PyETO.init() missing 1 required positional argument: 'description'#033[0m

config_entry-smart_irrigation-5ae2f4e6574b1aa4c1258f4d54c0bc05.json
How to reproduce
Just click Calculate.
 I am not seeing that here... I'll recheck.

I have the same problem, last calculation 29 of May.

please install 2024.6.0 and verify this was fixed.

Bucket is calculating now, but it won't update ui because of localization. Looks like fallback to en doesn't work in this case.
si_log.txt

Weird, it worked fine in my tests but I am on English. I will check it again. Sorry for the inconvenience

I solved it by modifying
localize.py:19
if language in SUPPORTED_LANGUAGES:
and localize.py:30
# fallback to english in case string wasn't found
# if language == "en" or not isinstance(translated_string, str):
    else:
        language = "en"

in root dir and /calcmodules/

I install the latest and in settings service and service it shows the previous in the app.
Still got this error
async_update_zone_config
await self._async_calculate_all()
File "/config/custom_components/smart_irrigation/init.py", line 688, in _async_calculate_all
self.store.async_update_zone(zone.get(const.ZONE_ID), data)
File "/config/custom_components/smart_irrigation/store.py", line 505, in async_update_zone
if ATTR_NEW_MULTIPLIER_VALUE in changes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: argument of type 'coroutine' is not iterable
2024-06-04 07:29:34.844 WARNING (MainThread) [py.warnings] /usr/local/lib/python3.12/site-packages/aiohttp/web_protocol.py:466: RuntimeWarning: coroutine 'SmartIrrigationCoordinator.calculate_module' was never awaited
reset = await self.finish_response(request, resp, start_time)

@nybodha #388

@omenek159 what language are you on? I am struggling to reproduce this issue unfortunately.

should be fixed in next beta release

Yeah, I can confirm that everything is working as expected now :)

Yes, just install and without checked the log files it looks very good. Start up and when I press calculate all i got - 1.1 in the bucket.
Great nightly work 🌞

The benefit of timezones... For me it was the end of the day 😂. Tomorrow end of day I'll wrap up the official release and then it's on to big things to fix the biggest problem with this integration: the sampling of sensors is not enough for places that have big changes in weather in a day. Anyway thats for tomorrow and the days after. First need to give my other integrations some love. Oh, and getting some sleep...


Can't draw walls in editor

Describe the bug
Can't draw walls in editor
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#editor
2.Drag block set tilemap to
3.Draw a tilemap and then draw the wall by the wall button
Expect behavior
User can draw walls in editor
Actual behavior
Can't draw walls in editor

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.6.5
3.Microsoft MakeCode version: 7.2.8

I noticed the same. It's like the wall layer is rendering at 1/16th.  I think it's a widespread issue (and it's really dragging down my builds today!)
@shakao  @riknoll  @jwunderl   Feel free to reach out if you can't repro.


How to use this with v2.7.3?

I try to get this example to work with Woodpecker 2.7.3.
The documentation says:

Finally go to your repository settings, to the extensions tab and set the URL of this server as the URL for the extension you want to test.

How to achieve this?
Thanks for your help in advance.

Alright.
Thanks for the hint to PR!

I assume the global config still works, where you have to pass the extensionendpoint to the server as environment, see here:
https://woodpecker-ci.org/docs/administration/server-config#woodpecker_config_service_endpoint

Hm... the repo ID will not be included in the request...


[manila-csi-plugin]fix manila sanity test

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

@gman0 @zetaab please help review, thanks


Closing as noo any bug description is given @georgekald79  please create the issue with necessary information.

Closing as noo any bug description is given @georgekald79  please create the issue with necessary information.
Originally posted by @tlikhomanenko in https://github.com/flashlight/flashlight/issues/616#issuecomment-849841699

Hello

revolut-ipid-PurRetTic_CYP-gre.pdf.pdf
Greece is my sister and my family


Can't submit Gentx on agorictest-13

Command on which error occurs
ag-chain-cosmos gentx $myKey 50000000ubld --output-document=gentx.json \
  --chain-id=$chainName \
  --keyring-dir=$HOME/.ag-cosmos-helper \
  --moniker="$myMoniker" \
  --website=<your-node-website> \
  --details=<your-node-details> \
  --commission-rate="0.10" \
  --commission-max-rate="0.20" \
  --commission-max-change-rate="0.01" \
  --min-self-delegation="1"

Error
Facing
Error: failed to fetch <key-name> from the keyring: <key-name>.info: key not found
How to reproduce
Just try follow the instructions for creating gentx on agorictest-13 Instructions
Hack used to fix
Added the key in .ag-chain-comos folder as well, by recovering it from the mnemonic
ag-chain-cosmos keys add <key-name> --recover
Side note
Now both .ag-chain-cosmos and .ag-cosmos-helper have a file <key-name>.info
Earlier I think only .ag-cosmos-helper used to have it

Work-around: downgrade to agorictest-12 release
I've seen this work-around reported a number of times.

I can confirm that downgrading to agorictest-12 works for generating the gentx.
Another workaround which I can confirm is using the following on agorictest-13:
ag-chain-cosmos keys add <your-new-key-name> --recover
instead of
ag-cosmos-helper keys add <your-new-key-name> --recover
What would be good to know is whether this bug might interfere with the scheduled launch, hence my suggestion to sanity check the release by the Agoric team.

I had the same problem, and also solved it by recover

I've opened a PR against the Cosmos SDK to fix this: cosmos/cosmos-sdk#9574.
The relevant Agoric SDK PR is at Agoric/agoric-sdk#3401

Due to this current issue, I generated and submitted gentx.json via portal using the older release version agorictest-12

Due to this current issue, I generated and submitted gentx.json via portal using the older release version agorictest-12

That's fine.  You should be good to go.


@tanstack/react-table not building?

Describe the bug
I went to upgrade @tanstack/react-table to 8.7.1 and it said it didn't exist. Seems it stopped building to npm registry since eversion 8.7.0?
Your minimal, reproducible example
NA
Steps to reproduce
Upgrade package.json to 8.7.1 for @tanstack/react-table and run npm i
Expected behavior
@tanstack/react-table would be built when @tanstack/table is built
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
NA
react-table version
8.7.1
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

It's because it doesn't exist. Install v8.7.0 if you are using React. v8.7.1 was only for the Vue adapter


Failed prop type: Invalid prop tag of type function supplied to Sortable, expected string

Trying to use this library with Ant design. My implementation is as follows:
import { Row } from "antd"
<Sortable tag={Row} />

This works, but I get the error in the title `Failed prop type: Invalid prop 'tag' of type 'function' supplied to 'Sortable', expected 'string'.
I haven't had a chance to look at this libraries source code yet, but is it possible to relax the prop type for the tag?
I tried using a string of "Row" for the tag but I get even more errors that seem to come more from React's end.
 <Row /> is using incorrect casing. Use PascalCase for React components, or lowercase for HTML elements.
The tag <Row> is unrecognized in this browser. If you meant to render a React component, start its name with an uppercase letter.

thats weird, looks like the prop type schema allows functions,
    tag: PropTypes.oneOfType([
            PropTypes.string,
            PropTypes.func
        ]),

Looks this method no longer works in the latest release either. It appears only strings are valid tag values otherwise an error is thrown.

Hi @schester44,
This is a nice use case. This should be fixed in the next major version, which is a Typescript rewrite. We'll make it so any types can be added into this (or maybe Functions that are Components and/or keyof HTMLElements)
It looks like you're using it incorrectly (not sure if on purpose just for example). For reference, check this out:
<ReactSortable tag={'ul'}>

list item 1

list item 2

</ReactSortable>

// compiles into

 {/* a container which stuff can be dragged inside of*/}

list item 1
 {/*draggable item*/}

list item 2
 {/*draggable item*/}

@schester44, I looked at the source, it should work based on the current proptypes
static propTypes = {
        options: PropTypes.object,
        onChange: PropTypes.func,
        tag: PropTypes.oneOfType([
            PropTypes.string,
            PropTypes.func
        ]),
        style: PropTypes.object
    };

FWIW, this is how i'm using the lib...
import { Row, Col } from "antd"

    <Sortable tag={Row}>
        <Col data-id="myid">...</Col>
   </Sortable>

I get the errror
Uncaught Sortable: `el` must be an HTMLElement, not [object Object]

Try this:
I'd recommend wrapping a component in a forwardRef if it works. That way you can expose the ref of your UI component to the tag prop.
If it works let us know.

import { Row } from "antd"

<ReactSortable
  tag={forwardRef((myProps, myRef) => <Row innerRef={myRef} />)}
>
// ... your children
</ReactSortable>

If you use this package, the issue will be fixed: https://github.com/waynevanson/react-sortablejs-typescript
This new version of react-sortablejs will be merged with the official once it is complete.


digispark driver download before it sees it as a HID device

problem is a new pc won't see a HID keyboard but a digi spark (because of no driver). only when the driver is installed it will automatically switch to the HID driver for it to continue with process given.
need custom bootloader and pid/vid if u can make a guide and how to do so and upload the code for the bootloader or the process to burn over digispark bootloader but that will make it so we can change to code but i perosnally dont need that as they are 1dollar a peace and u can make it connect to a dns server and allways keep changing the ip adress (arduino would not see it)

Actually I kept the original bootloader with the 5 seconds lag so that I can re-program the DigiSpark for further testing. If you want to skip it and burn the code permanently, then you need a custom bootloader that can natively support HID emulation.
The current factory-provided bootloader is based on Micronucleus (https://github.com/micronucleus/micronucleus), we can try to reprogram it to remove the 5 second lag and to make it an auto-installing HID device without the need for a driver.


[NuGet] Contained dlls are not sent to output folder even when forced

Release Type: Latest github
Version: https://github.com/xenko3d/xenko/commit/964ef5e68c4fa555d890f94c648e871f7e1bb067
Platform(s): Any
Describe the bug
Some dlls, like Xenko.Games.dll, are not copied to the output folder on build when being forced. It works fine for a simple application locally as .Net pulls it from the GAC or god knows where.
To Reproduce
Steps to reproduce the behavior:

Create a new dot net framework project.
Import nuget package Xenko.Games (here beta02-0674)
Add <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> within a PropertyGroup of your csproj
Reference that package within your main, ex:

static void Main(string[] args)
{
	System.Console.WriteLine(Xenko.Core.Platform.IsWindowsDesktop);
}

Build and look at the output, you should have a couple of dlls like Xenko.Shaders.dll, Xenko.Core.Serialization and such but you won't have Xenko.Games.dll.

Expected behavior
Dll -> output folder
Screenshots
Log and callstacks
Additional context
Adding <file src="*PATH_TO_THE_NETSTANDARD_DLL*\Xenko.Games.dll" target="lib\netstandard2.0\Xenko.Games.dll" /> to the generated nuspec file resolves this issue.

did you specify a runtime identifier in the toplevel exe project? line 'win-x64'? https://docs.microsoft.com/en-us/dotnet/core/rid-catalog

Yes providing an rid does resolve the issue but I don't think it makes sense given those dlls are under standard.
Now that's just weird, after removing the rid the dlls still end up being included ? Perhaps a bug in nuget ?

This issue has been fixed on latest master-3.1


add debug log for label size exceeded

:tada: This PR is included in version 1.116.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix CallableChoiceIterator import on Django 5.0+

This was changed in django/django#16943. It's not enough to make our tests pass against Django's main branch though, as some fixes need to be done in the upstream django-filter package.

Hey @laymonage — I just spotted this too.
  File "/Users/carlton/Projects/Django/django-filter/.tox/py311-latest/lib/python3.11/site-packages/django/forms/fields.py", line 874, in __init__
    self.choices = choices
    ^^^^^^^^^^^^
  File "/Users/carlton/Projects/Django/django-filter/django_filters/fields.py", line 264, in _set_choices
    super()._set_choices(value)
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'super' object has no attribute '_set_choices'

I'm working towards a release there, so if you want to open a Issue/PR, with what you know that would be 🥰

Hey @carltongibson, good to see you here! I suspect the issue is around the refactoring of the _get_choices and _set_choices method into proper Python @property getter and setter. I briefly looked at django-filter code when I wrote this PR but it looks like it might need some clever handling of the choices property if you want to support both Django pre-5.0 and 5.0+. I can try looking into it on the weekend, but until then it's all yours 😉

Thanks @laymonage — https://github.com/carltongibson/django-filter/issues/1605 is the tracker for this my end. 👍

Oh, @laymonage, If you could comment your support matrix that would be handy... (I'll do a release here, but I'm looking to drop PY37 and Django <4.2... and I don't want to cause you issues.) Ta

@laymonage Preliminary compat here:

https://github.com/carltongibson/django-filter/pull/1606

A bit of tidying, and a release shortly.

@laymonage https://pypi.org/project/django-filter/23.3/ is out so this can proceed

Thank you for your great work @carltongibson! 🌟


Retrieving translations in PageServerLoad methods

I want to internationalize my error message which might have dynamic variables inside them. In the throw error() construct I can get the translation using t.get('key'). However, I am unsure how to propagate the dynamic variable I want to have in the text.

Anyway, locale-router example might help..


fix: Maintain focus on editor when Escape is pressed with autocomplete menu open

Description
When typing content in the editor, the autocomplete menu pops up to suggest possible matches. If we press escape, the autocomplete menu closes but the editor loses focus, and users have to click again to regain focus and type.
This PR fixes this issue and removes this defect.
Fixes #21999
Screen recording - https://www.loom.com/share/697f689f85b7426d88032f6487a9f7d9
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented on my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer-reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reviewing all Cypress test

/ok-to-test sha=429bb84

Note for QA - test in different browsers/platforms/incognito

/build-deploy-preview env=release

/ok-to-test sha=315e61b

/build-deploy-preview env=release

Tested on Chrome (w/ incognito), Canary & Firefox on property pane, editor and query pages - LGTM

/ok-to-test sha=7c15fe4

/ok-to-test sha=32f72c1


[3.x] Physics Interpolation 2D - fix light and light occluder resetting

It turns out NOTIFICATION_TRANSFORM_CHANGED is deferred for these nodes, which can mean the transform is not set in the VisualServer until after the reset has been sent, even if the transform is set before the reset in script. This prevented the reset from acting correctly.
Here we explicitly set the transform prior to each reset, to ensure the VisualServer is up to date.
Fixes bug mentioned here:
https://github.com/godotengine/godot/pull/88424#issuecomment-1986918150
Notes

I hadn't noticed this during development of 2D interpolation. There are already similar techniques in place for canvas items and CPUParticles to deal with this deferred notification.
This is probably the simplest way to fix this.
It would be possible to do more complex (bug prone) code to ensure the transform was only sent once (after this PR it will be sent twice on a reset tick, once during the reset, and once redundantly during the NOTIFICATION_TRANSFORM_CHANGED), but resetting should be a rare occurrence and this will have minimum impact.

Thanks!


Support custom Max Level and Team Length in tours

I tried my absolute best to keep code standards good, but truth is I'm just really not good at things like variable naming. Adjustments will most likely need to be made by someone who's actually good at those things
I do know however that this code does what it needs to (/tour rules Max Level:5 sets max level to 5, and /tour rules Team Length:3-1 sets the teamLength to set max team length to 3, and allow one of those to be picked into battle)
As far as I can tell the syntax I used does not interfere with anything already in place, and shouldn't interfere with anything that could be added in the future

I wonder if = might be a better choice than :.

In a very hacky fashion, I made it support both

Okay now I'm just making mistakes all over the place, I need to take a step back and figure out what I'm doing

Going to need someone to go over that failed Travis build and explain to me how to make it not fail. From what I can tell you're working on a copy of format so any changes you make are non-permanent and don't need to be read-only

I think your main problem is that format is immutable here.
When I tried to tackle a similar problem in the past, my solution was to shove these values (maxLevel and teamLength) inside the ruleTable. That might work for you?

That'd require some changes to battle.ts and team-validator.ts but seems possible. Gonna try getting that to work

Sorry got sick and couldn't update this for a while. I've implemented all I could as you suggested, from here it can either be merged or be taken over by someone more capable

I don't have the slightest clue what I'm doing wrong at this point

Will start fixing that later


formatDateTimes in gradle is private and thus cannot be set to 'true'

We are currently migrating our project from maven to gradle and noticed that the "formatDateTimes" property cannot be set in the gradle because it is private. We are using the latest 1.2.2 version. The property is in the README.md and is described as changeable.

Hi
Can you provide an example ?

Could not reproduce with following input:
test.json:
{
  "type": "object",
  "properties": {
    "defaultFormat" : {
      "type" : "string",
      "format" : "date-time"
    }
  }
}

build.gradle:
jsonSchema2Pojo {
    setSource(files("$projectDir/src/main/resources/json"))
    formatDateTimes = true
}

generates class:
...
@Generated("jsonschema2pojo")
public class Test {

    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd'T'HH:mm:ss.SSSXXX", timezone = "UTC")
    @JsonProperty("defaultFormat")
    private Date defaultFormat;
...

whereas with formatDateTimes = true in build.gradle generates:
@Generated("jsonschema2pojo")
public class Test {

    @JsonProperty("defaultFormat")
    private Date defaultFormat;

Hi!
Unfortunatelly I am unable to provide a screenshot due to some restrictions on my work pc, the configuration looks like this and I get this error only for the formatDateTimes property. If I remove it I get no errors.
I also tried to stop all gradle daemons, clean gradle caches, invalidate idea's caches.
The error message is: Cannot access 'formatDateTimes': it is private in 'JsonSchemaExtension'
And I cannot provide the json schema because it contains sensitive info. But it works fine with maven.
plugins {
    id("org.jsonschema2pojo") version "1.2.2"
}

jsonSchema2Pojo {
    sourceFiles = files("/example")
    targetPackage = "org.example"
    includeHashcodeAndEquals = false
    includeToString = false
    includeAdditionalProperties = false
    formatDateTimes = true   <--- here I get an error
    formatDates = true
    dateType = "java.time.LocalDate"
    dateTimeType = "java.time.OffsetDateTime"
    useLongIntegers = true
    useDoubleNumbers = false
}

Some questions:

are you using gradle kotlin dsl (*.kts) or groovy dsl
which gradle version is being used

It seems that gradle kotlin dsl behaves differently than groovy dsl.
For now as a workaround you could use
setFormatDateTimes(true)

instead of
formatDateTimes = true

It seems that gradle kotlin dsl behaves differently than groovy dsl.
For now as a workaround you could use
setFormatDateTimes(true)

instead of
formatDateTimes = true

I am using kotlin dsl, the gradle version is 7.4

thanks for the option with the setter, but I have already tried it and it cannot resolve the setter also, as the property is "private" :(
I've also just noticed the customDateTimePattern option in the docs, maybe it will do the trick without formatDateTimes = true

thanks for the option with the setter, but I have already tried it and it cannot resolve the setter also, as the property is "private" :( I've also just noticed the customDateTimePattern option in the docs, maybe it will do the trick without formatDateTimes = true

That's weird - checked with following combinations and it worked fine
jsonSchema2Pojo {
    sourceFiles = files("/src/main/resources/schema")
    targetPackage = "my.pkg"
    generateBuilders = false
    setFormatDateTimes(true)
}

jsonSchema2Pojo {
    sourceFiles = files("/src/main/resources/schema")
    targetPackage = "my.pkg"
    generateBuilders = false
    isFormatDateTimes = true
}


Error message for Uppercase Image name is misleading

Describe the bug
The error message when using uppercase letters in the image name is misleading
Command Name
az acr task create
Errors:
InvalidInputValue - Some of the properties of 'taskCreateParameters' are invalid.. InnerErrors: DockerBuildStep:Image name 'ARMoreTF:{{.Run.ID}}' is invalid.
The acceptable patterns are 'repository' or 'repository:tag'.The repository and tag names follow the standardized docker repository and tag naming conventions. Tag templates are supported within '{{' and '}}'.
Please refer to docs for more information on using image name and tag:  https://aka.ms/az/acr/az-acr-build

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
-Create Container registry
-az acr task create --image ARMoreTF:{{.Run.ID}} --name ARMoreTF_Task --registry ACR --context  --file Dockerfile --git-access-token  --platform linux
Expected Behavior
Error: Image name is lowercase only
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: cmd.exe

azure-cli 2.0.80 *

Extensions:
azure-devops 0.8.0
dev-spaces 1.0.4
interactive 0.4.3

Additional Context

acr

@northtyphoon, error improvement

When running the az acr build -t WithUppercase -r registryname today, it resulted in the same error message pointed out above. The issue was that the name I specified after -t included uppercase letters. Rerunning it with az acr build -t alllowercase-r registryname succeeded.


chore: add Node.js v12 to Travis CI test matrix

Potentially the failing Node.js 12.x tests are failing because of Jest compatability with Node.js 12.x
See https://github.com/facebook/jest/issues/8397


Numeric prop support

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Column prop cannot be a number.
What is the new behavior?
numeric column props now work.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
I added getter functions that are more efficient than the original deepValueGetter. deepValueGetter is only used if the prop string contains '.'
In my second commit, I cache the value getter function in DataTableBodyCellComponent, but this may be over-optimizing. However, this should improve performance if the value getter is called much more often than the column setter.
Items to Review
I would like to review the API for the getter functions. I'm not a fan of deepValueGetter's API as far as undefined values. Sometimes it returns '', other times it returns the object. To be consistent, I think all getters should return '' (the empty string) in undefined situations. This also lets you get rid of the undefined check in DataTableBodyCellComponent.

This is another issue, but I think the sorting code could be much more efficient if it avoided valueGetter lookups in the compare function. Other aspects of the compare function body should be simplified too.

As an alternative to baf9e82 (valueGetter caching in DataTableBodyCellComponent), the valueGetter function could just be stored in the column object. So the valueGetter would be looked up when columns are set. this.column.valueGetter
Would you prefer this approach?

There's a bug right now. zero-index prop=0 isn't working because code elsewhere doesn't render the column because of its falsey prop value. Working on it...

I'm confused at what functionality this actually brings. What advantage do you get by allowing a prop to be a number?

@deeg Support for array rows.
this.rows = [
['Foo', 123],
['Bar', 456]
];

this.columns = [
 { name: 'First column', prop: 0},
 { name: 'Second column', prop: 1}
];

@arlowhite, thanks for the info. I now understand the functionality it brings, but not sure it is something that has to be supported by this library.
What is the real life use case for this? You could very easily make that data work with this library currently my formatting the data before passing it into the table.
I'm not against the change, I just think it is adding a lot of code & logic for something that isn't a huge problem right now. I of course am just giving my opinion and will yield to the maintainers of the library and the community input.

I suppose the argument is just to reduce the amount of work users need to do to use the table.
Yes, conversion of rows isn't that difficult, but it does add complexity. There are a few other issues.

Users also need to convert back to their Array format (to be compatible with their code) when dealing with output such as from (contextmenu).
Users can no longer compare rows between their code and ngx-datatable by reference when their code holds a reference to the Array row form and ngx-datatable rows are different JSON objects.

Just FYI, I'll working on updating this branch and resolving conflicts next week. (March 6-10)

I just did a rebase onto master.

I'm finished working on this PR. I think it's good to go.

I just rebased onto master again.
I've just updated my project to Angular 4 and was able test ngx-datatable in my project.
Also, npm start and npm test looks good.

Merged!


Prevent OR’ing of filters containing nested paths.

A filter with nested paths will result in several matches chained together. Those matches are nessary to have the nodes holding the properties we want to filter on.
While at first it may seem trivial to think that adding a nested filter with its own match by an OR just doing an OPTIONAL MATCH, this is wrong, as the first part of the OR would need to be marked as OPTIONAL as well.
In the end trying to do so, would create very brittle Cypher statements.
Instead of, this commit improves the current checks into a single place and adds a couple of tests for it.
A query is not created when any of the filters in the chain is nested AND any other is to be chained with OR (when there is actually more than 1 filter).
This closes #796.

Codecov Report

Merging #799 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #799      +/-   ##
============================================
+ Coverage     80.33%   80.41%   +0.07%
- Complexity     3030     3039       +9
============================================
  Files           277      277
  Lines          9246     9253       +7
  Branches       1381     1381
============================================
+ Hits           7428     7441      +13
+ Misses         1307     1303       -4
+ Partials        511      509       -2

Impacted Files
Coverage Δ
Complexity Δ

...eo4j/ogm/session/request/FilteredQueryBuilder.java
92.68% <100.00%> (+3.79%)
28.00 <11.00> (+9.00)

...rg/neo4j/ogm/session/request/NodeQueryBuilder.java
93.58% <100.00%> (+2.23%)
22.00 <0.00> (-1.00)
:arrow_up:

...ore/src/main/java/org/neo4j/ogm/cypher/Filter.java
92.45% <0.00%> (+1.88%)
48.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c84bb...6c57992. Read the comment docs.


TB41

Key
Value

View
https://database.shabados.com/line/TB41

Source
Sri Dasam Granth

Page
6

ID
TB41

Line
cqR ck® kwly ]97]

c`qR c`k®
Nitnem Gutka - May 2017 - SGPC, Sri Amritsar

#95


API for creator settings that a user can obtain

To allow for the user interface to make certain improvements we have added a new commentron api settings.Get which will get the creator settings that are needed to make a better UI.
Request:
{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "setting.Get",
  "params": {
    "channel_name": "@LBRYBeamer",
    "channel_id": "05bb9e310c6e9f0e62f5f8892de23133633e4449"
  }
}

Result:
{
  "jsonrpc": "2.0",
  "result": {
    "comments_enabled": true,
    "min_tip_amount_comment": null,
    "min_tip_amount_super_chat": null,
    "slow_mode_min_gap": null,
    "curse_jar_amount": null
  },
  "id": 1
}

@infinite-persistence FYI

Incorporated as part of the "min tips" work.  Will be available when that gets merged.


Crash when mobcap is set to be shown while inside a custom dimension.

First of all, I am assuming this crash occurs on any custom dimension, as I have only tested it for Aroma1997's Dimensional World.
crash-2020-12-12_20.48.17-server.txt
ForgedCarpet version was built up to commit cf7be7e.

I think the fix is just to check for the dimension, and then incase it's not one of three vanilla dimensions, just to say whooops, invalid dimension.

I think the fix is just to check for the dimension, and then incase it's not one of three vanilla dimensions, just to say whooops, invalid dimension.

This would be more of a hackfix ig, the changes i made should allow users to view mobcaps in custom dimensions too


10/20 Publish

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-autogen/com.microsoft.azure.sdk.iot.deps.serializer._parser_utility.yml
:white_check_mark:Succeeded

docs-ref-autogen/com.microsoft.azure.sdk.iot.deps.serializer._twin_properties.yml
:white_check_mark:Succeeded

docs-ref-autogen/com.microsoft.azure.sdk.iot.deps.serializer._twin_property.yml
:white_check_mark:Succeeded

docs-ref-autogen/com.microsoft.azure.sdk.iot.deps.serializer._twin_tags.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Road to secp256r1 support

It has become clear that we want ECDSA secp256r1 signature verification support to allow app level signature verification using a popular industry standard curve. Now that if is answered, let' move on to when and how. Given that adding a new crypto API is something we cannot easily revert once contracts rely on it, we need to ensure that the new API is correct and behaves as desired.
Open Questions

[x] Should we accept low-S and high-S signatures? Yes, because this is how ECDSA works and secp256k1_verify behaves today. An app level protocol may further restrict which sigantures are valid. Those extra checks have to be implemented separately, for now in Wasm.
[x] Should we implement secp256r1_recover_pubkey? Why not, we have it for the other curve already
[x] Do we need a DER decoder for signatures (decoding DER in a way that does not allow malleability is pretty hard)?: I'd say no, since this is not trivial and needed for BTC only

Blockers

[x] CosmWasm/cosmwasm#2004 because we need to be able to add functions in a point release
[x] Release CosmWasm 2.0 (secp256r1 should not block 2.0 and we don't want to rush  secp256r1)
[x] Merge secp256k1 test from Project Wycheproof (https://github.com/CosmWasm/cosmwasm/pull/2000)
[x] Finalize the secp256r1 implementation (https://github.com/CosmWasm/cosmwasm/pull/1983)
[x] Add secp256r1 tests from Project Wycheproof (#2007)
[x] Use prehash directly and remove Identity256 (#2012)
[x] Get clarity on supported recover IDs (#2057)
[x] Add default implementations to trait Api using unimplemented!() (#2058)
[x] Add cosmwasm_2_1 feature (https://github.com/CosmWasm/cosmwasm/pull/2065)
[x] Ensure API is good to verify WebAuthn/FIDO for passkey support (#2071)

The API seems fine. Checking through webauthn-rs, the API is operating on prehashed data, so we don't even assume a message digest. As for the key, that requires a bit more conversion juggling. The EC key has to be converted from its COSE format into SEC1.
This involves:

Parsing the CBOR and COSE
Parsing the scalars out of the COSE
Constructing a non-zero scalar
Converting it into an p256 secret key
Encoding it into SEC1
Passing it to the API

But we can't cover that, really. Unless we want an API that accepts raw scalars (that'd be a big no from me) or implement COSE ourselves (is it worth it? Contracts can do that themselves.)
Otherwise the raw cryptography primitives seem totally usable.

But then again, I haven't implemented WebAuthn/FIDO myself yet, so I'm not 100% sure.

That sounds interesting. Can we try to implement all those conversions in an example contract? That way we can show contract developers what needs to be done without having to expose that functionality as part of our APIs.

Converting it into an p256 secret key

Public key, right? On chain we only do signature verification.

Public key, right? On chain we only do signature verification.

Ah, yes, public key. Not private key. Mixed them up in my head for a sec

Seems like the last checklist item is done now. Can we mark this as done? 🎉

It is, well done and thanks 🐎


quote route parameters

Closes #14
Ensures that it always produces valid typescript even if hyphens are in the path name.

Hmm, not sure how to best resolve this one. A bit to sketchy in the Github webeditor.
I don't have experience with merging from forks. Should I do something or should you? :)
...and this snapshot test will quickly become a pain I see 🤦

Also, I'll bump the patch version once this is merged and I have tested a bit on my own project. Still doing releases by hand here ;)

I think this is easiest:

Open terminal, check out this branch
merge main into this branch
there will be conflicts on that snapshot file - just rerun yarn test to regenerate the snapshot
make sure the snapshot makes sense
git commit, to complete the merge commit
push that, and you should be good to merge this into main

i just did the merge, so should be good now - the snapshot diff looked like this:

Thanks for fixing it :)

I think this is easiest:

Open terminal, check out this branch
merge main into this branch
there will be conflicts on that snapshot file - just rerun yarn test to regenerate the snapshot
make sure the snapshot makes sense
git commit, to complete the merge commit
push that, and you should be good to merge this into main

Thanks for taking the time to explain! But I do know how to resolve conflicts. The thing was, that I couldn't checkout this branch (osdiab:osdiab/quote-and-escape-routes) as it comes from your fork. Guess I would need access to your fork and resolve them there or have you do it as you did :9

Ah I figured there was some way for you to check it out since when I make the PRs it has a checkbox to allow edits from maintainers - lol maybe there is but idk. As more stuff comes up I'll try to deal with conflicts like that when they come :)


[BUG] Error on Mac restart

Latest stable version 1.0.0
Catalina 10.15.4

On mac restart I get this error.. It is the second time (second time restarted the mac) and I noticed this error. Just to mention, my wifi is set on the auto connect as disabled, so everytime I restart the mac I do manually connect to wifi, the error might be related to this scenario, and after I manually connect to wifi I open the Maestral app and it works.
BTW: Very nice that you launched the stable version. :)

Strange, I was initially able reproduce this myself. But after redirecting output from the startup process to the log files (to figure out what was going on), the problem vanished. And now, whatever I try, I cannot recreate the problem.
Could you try the following? Startup on login is handled by a file ~/Library/LaunchAgents/com.samschott.maestral.maestral.plist with the following content:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Label</key>
	<string>com.samschott.maestral.maestral</string>
	<key>ProcessType</key>
	<string>Interactive</string>
	<key>ProgramArguments</key>
	<array>
		<string>/Applications/Maestral.app/Contents/MacOS/main</string>
		<string>gui</string>
		<string>-c</string>
		<string>maestral</string>
	</array>
	<key>RunAtLoad</key>
	<true/>
</dict>
</plist>

Could you add the the following keys to it
<key>StandardOutPath</key>
<string>/Users/USERNAME/Desktop/maestral_out.log</string>
<key>StandardErrorPath</key>
<string>/Users/USERNAME/Desktop/maestral_err.log</string>

where USERNAME should be replaced by your user username and check the output printed to the log files on restart? This should be able to log any errors during startup before Maestral has set up its own logging facilities.

I have tried what you suggested:

Label
com.samschott.maestral.maestral
ProcessType
Interactive
ProgramArguments

/Applications/Maestral.app/Contents/MacOS/main -c 'maestral'

RunAtLoad

StandardOutPath
/Users/work/Desktop/maestral_out.log
StandardErrorPath
/Users/work/Desktop/maestral_err.log

On first restart, I got the same dialog popup error, and both files are 0kb, I have restarted, the same both files 0kb, but this time I got no dialog error, and I found the app in the statusbar running. Weird.
I will try to chmod both files and see the result on restart, and then back to original for plist to see if the issue still reproduce.
BTW: Maybe is related, my wifi is set to enable but will not connect to any network on restart, when I restart the mac, I have to manually connect to my wifi network, maybe this is related.

RE:
chmod 755 maestral* did not helped, 0kb on both files, and no error dialog.
I`ve changed StandardOutPath, StandardOutPath to other path and I will leave it there as it seems with those two settings the app starts at mac restart.

Thanks for checking, it does seem that the issue reproducibly vanishes after the first successful launch. The main change which could cause startup problem: the GUI now launches a separate daemon process instead of running the daemon "internally". This may be blocked somehow by macOS if the app or the launchd file is not trusted. It is possible that just manually modifying the launchd file is enough and setting the paths makes no difference. But its difficult to investigate without being able to reproduce the error.

BTW: Maybe is related, my wifi is set to enable but will not connect to any network on restart, when I restart the mac, I have to manually connect to my wifi network, maybe this is related.

This shouldn't cause any issues. The daemon will start regardless of available internet connections.

This should hopefully fixed in the latest release where the daemon is spawned instead of forked. There seems to be a long standing issue with forking processes that access macOS system frameworks.

Still having some issues, I use the 1.0.3 version, mac 10.15.5, and use the CLI version, on the System>users> the maestral is not there for login, on the GUI the "start maestral at login" is disabled, and I have the maestral cli running, when performing a mac restart or user logout/login, the GUI starts-up and the cli is not running, how I can make it to autostart the cli and the gui to be disabled at login? Maybe a setup in the gui to thick on when to start the cli at login will be nice.

Maybe a setup in the gui to thick on when to start the cli at login will be nice.

I will consider that. For now, the CLI command maestral autostart -Y should only trigger the daemon to start on login while the GUI checkbox starts the GUI. It is ok to have both activated at the same time, the GUI will attach itself to a running daemon if it finds one. As usual, you can check with maestral status if it’s actually running.

on the System>users> the maestral is not there for login

I’m not sure why those entries are missing but I have encountered the same issue. I suspect it’s because the way that the login items are registered does not quite conform to Apple’s guidelines. But doing it the official way is a bit complicated and involves writing a separate helper program which launches the actual daemon or GUI.
There should however be appropriate items at ~/Library/LaunchAgents and the app should start properly on login, even if the entries are not shown in the system preferences.

Hello
The issue still persists, maestral 1.0.3, enabled only CLI, and disabled on GUI autostart, and from System->Users the same removed it from there, and when I restart the mac 10.15.5, it starts the GUI instead of CLI, and I have to close the GUI and go to terminal and do 'maestral start' :(

Yes, I can reproduce this. The problem is an incorrect executable path in the startup item.
If you look at the file ~/Library/LaunchAgents/com.samschott.maestral-daemon.maestral.plist, its content will be:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>Label</key>
	<string>com.samschott.maestral-daemon.maestral</string>
	<key>ProcessType</key>
	<string>Interactive</string>
	<key>ProgramArguments</key>
	<array>
		<string>/Applications/Maestral.app/Contents/MacOS/main</string>
		<string>start</string>
		<string>-f</string>
		<string>-c</string>
		<string>maestral</string>
	</array>
	<key>RunAtLoad</key>
	<true/>
</dict>
</plist>

However, the first "program argument" should be the path of the command line tool /usr/local/bin/maestral instead of the app bundle. You can correct this manually for now, until I can provide an update. Just be aware that toggling the autostart option will recreate an incorrect startup item.

Ok, this should be finally fixed now in v1.1.0. This release also addresses an issue when the GUI tries to start syncing at the same time as the CLI, which would result in multiple watchdog threads.
You'll need to recreate both GUI and CLI startup items by turning "start on login" off and on again.
Sorry about all the trouble!

Does not work, after I updated to 1.1.0, I went to gui and ticked the auto login and unticked, and then cli maestral start, and also maestral autostart -Y and it returned success, today, I had to do a mac restart and I noticed that the files were not syncing, terminal:
192-168-0-103:~ work$ maestral status
Maestral daemon is not running.
192-168-0-103:~ work$

Damn. Could you paste the content of ~/Library/LaunchAgents/com.samschott.maestral-daemon.maestral.plist?

Yes,

Label
com.samschott.maestral-daemon.maestral
ProcessType
Interactive
ProgramArguments

/Applications/Maestral.app/Contents/MacOS/main
start
-f
-c
maestral

RunAtLoad

Last modified date on disk:
Wednesday, May 13, 2020 7:57:52 PM

I don`t remember to see the gui launched after the restart (not 100% sure, normally on restart I were closing the gui from the statusbar and then went to terminal).

That entry looks old and wrong. Can you delete it (manually or with maestral autostrat -N) and then recreate it?

Did not saw your last message. I did another mac restart ( bluescreen:| ), after restarted the gui did not launched and cli
192-168-0-103:~ work$ maestral status
Maestral daemon is not running.
192-168-0-103:~ work$

Deleted the plist
Ran:
192-168-0-103:~ work$ maestral autostart -Y
Enabled start on login.
192-168-0-103:~ work$ maestral start
Starting Maestral...        [OK]
192-168-0-103:~ work$
File recreated
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>Label</key>
    <string>com.samschott.maestral-daemon.maestral</string>
    <key>ProcessType</key>
    <string>Interactive</string>
    <key>ProgramArguments</key>
    <array>
		<string>/usr/local/bin/maestral</string>
		<string>start</string>
		<string>-f</string>
		<string>-c</string>
		<string>maestral</string>
    </array>
    <key>RunAtLoad</key>
    <true/>
</dict>
</plist>

Will ping you on next restart if anything ocurs. TNX

That looks much better!
The GUI should hopefully also work after deleting and recreating its plist ~/Library/LaunchAgents/com.samschott.maestral.maestral.plist by turning the “start on login” checkbox off and on again.
Ping me if it’s still causing issues, but I thought I had thoroughly tested the changes this time.


Update to Poetry to 1.1.0+

Upgrading to poetry 1.1.0 causes an issue.Particularly, gmpy=2.0.8 will fail on install. This seems to be related exclusively to the poetry version.
This can be tested locally by installing:
pip install poetry 1.1.0
and running make environment:
make environment
The expected resolution would be either waiting for a bug fix from poetry or figuring out exactly why gmpy2 won't install.

I pulled the repo real quick to take a crack at dealing with this, went into Dockerfile and Makefile and I see that the pip install lines have been changed to grab poetry=1.1.6. make environment also worked for me, so I suspect this issue has been resolved in the churn of time and upstream changes. During research, I noticed poetry's incremented to 1.1.10, so I did a quick bump and tried it out and that worked locally. Just going to register a trial azure account real quick so I can see if CI passes, but I feel like the difference between 1.1.6 and 1.1.10 isn't going to be huge. Also, I suspect once I get my azure credentials plugged in that CI on my repository is going to halt at the same step that all the builds since 7ce699217682de4a09eab86f7c584eccef97faff have been failing on, I could see what I can do there if that's not something anyone else is handling right now.


Check for Settings.bundle/Root.plist was in the wrong place

When FL_COMMIT_INCLUDE_SETTINGS is used, the exception gets thrown before the setting ever has a chance to be considered.

Hey @dmdeller! Thanks for the PR, this change seems great, but would be great to have a test or two added to confirm that this is not going to break anything or even just some repro steps so we can test this manually. Thanks! 🐙

Hey @dmdeller, just wanted to bump this up to see if you had a chance to write some tests or examples. Thanks! 🐫

Thanks for your reply! Unfortunately, it's been a while, so I need to refresh my memory before I can provide accurate info. I'll close this PR for now until I have time to resubmit.


Add logo to the documentation

Pull request details
Describe the changes made in this pull request
Add the Tulipa logo to the documentation
List of related issues or pull requests
Closes #383
Collaboration confirmation
As a contributor I confirm

[x] I read and followed the instructions in README.dev.md
[x] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[x] Tests are passing
[x] Lint is passing

@clizbe, you must build the documentation locally to see the changes properly. So, this is a screenshot of how it looks like with the logo.

@clizbe the last commit is to have the GitHub repo link in the top of the documentation, like this:


Fixes for MongoDB 4.0

MongoDB changed how they handle md5 hashes. So, now the md5 hashes have to be computed manually

This PR fixes the current testcases, but there are still issues with the QueuedMongoObserver not addressed in this PR (see #859).


suggest new app icon

I'd like to suggest a new app icon to replace the rather dated one.  If interested, let me know. You can use it freely for Aural.
If not interested I'll just upload it on deviantart for instance.

Hi @VisualisationExpo - Yes, I would love to use your icon. I will give you credit on the home page (contributors section) and on the app release page. Thanks !

Can I send it somehow as an ICNS in an e-mail? is that preferred?

macOS 'Aural' Big Sur Icon.icns.zip
I uploaded here instead.. enjoy. If there's anything that seems off to you then reach out.

Alternate icon on the left in the screenshot next to the already shared icon.

[macOS 'Aural' Big Sur Icon 3.icns.zip](https://github.com/kartik-venugopal/aural-player/files/12689838/macOS.Aural.Big.Sur.Icon.3.icns.zip)

Implemented and released in v3.22.0!
Provided you credits for the icon on the release page and on the main README page here.
Cheers!


How I can stop a note by fading the volume?

So when I turn off a note the sound stops completely, this is very abrupt and I will like it to stop it smoothly.
Is this possible?
I was thinking I could turn off the volume gradually until it reaches zero, is there something already built in for this on the library?
I tried to change the volume of a note by calling tsf_note_on with a lower velocity but it resets the note to the beginning.
Is it possible to have different notes with different volumes and fade them away after some time?

If the soundfont is designed with instruments that have a release envelope that fades out over time, TSF should use that when calling any one of tsf_note_off, tsf_bank_note_off, tsf_note_off_all, tsf_channel_note_offortsf_channel_note_off_all`.
I guess if you want to override that default behavior I don't think there's a nice built in way to do that.
If you're playing notes with the tsf_channel_ MIDI style interface there is tsf_channel_set_volume to set the volume of all voices currently playing that were started on a given channel.
But to do it to the default tsf_note_on you'd probably need to modify the library. For example you probably could copy the tsf_note_off to a new tsf_note_off_slow that takes a float release_time argument which then would do something like
...
v->ampenv.parameters.release = release_time; // time in seconds
v->modenv.parameters.release = release_time; // time in seconds
tsf_voice_end(f, v);
...

(note untested)
Or maybe you could pass an (optional) callback function to tsf_note_on like void (*voice_callback)(struct tsf_voice *voice) and then call if (voice_callback) voice_callback(voice); at the end of the "// Play all matching regions" for-loop. Then in your passed voice callback you could set the parameters.release values like in the example above. (also untested).

Ah! You are right, it was the font I was using. With the default piano preset the audio fades. Thank you 🙂


GEOMESA-2414 Support for specifying attributes used in each index

Supports customization of index attributes through 'geomesa.indices.enabled' user data

For example, to create two Z3 indices on different dates specify geomesa.indices.enabled='z3:geom:dtg,z3:geom:dtg2'

Index implementations are now in geomesa-index-api

All back-end specific code is contained in IndexAdapter immplementations

New index implentations can be SPI loaded through GeoMesaFeatureIndexFactory
New date-only option for AttributeIndex secondary index tiering

Enable with geomesa.indices.enabled='attr:foo:dtg'

The following features have been removed:

Accumulo table-sharing for new schemas (existing schemas still supported)
Accumulo pre-computed BIN values
Accumulo map-aggregating analytic scans
Z2/Z3 non-point support from geomesa-1.2.2 to geomesa-1.2.4 (use XZ instead)

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

This change also opens the door to having redundant index implementations bundled with geomesa, e.g. multiple spatial implementations using h3, hilbert, etc.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.199 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat: support testing statefulset

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Why developers opt out celery?

Hi,
Why the developers opt-out celery for distributed task/queue management? I heard celery is recommended way of doing it. I just curiously want to know the challenges/advantages?

This is a topic more suited for the HASS Community Forum.

didn't find replies there :|


fix bug of query failed when column not exist

in enable_doc_value_scan mode, when some fields does not been assigned, sql like select f1,f2.. will be failed.
so ,i resolved this bug by passing doc_value_mod to related class for customized processing.
more about the bug, see #3479

@wuyunfeng Please help to review this PR.

Can you  prefix [Doris On ES] on this PR title?


crashing upon launch

I add the mod through curseforge, and it crashes in the minecraft launcher. The only mods i have are cloth config and RealCamera.

I need more information. Can you show me your crash report or game log file?

I'm having the same issue, and it seems to only happen on the 1.19.2 forge version of the mod. The only mods I had were the two listed as well as optifine and lazyDFU.
Here is the crash report:
crash-2023-07-02_01.32.58-fml.txt

This mod is incompatible with Optifine and I'm not going to fix it.
I should have written this in a more visible place.


Unable to find path during copy

Hi,
I have just set up an agent phase to deploy a service, but I get an error to say that the service path does not exist. It looks, from the logs, as though it does exist.
2019-05-09T07:31:08.9403498Z Created artifacts directory: C:\agent_work\r15\a
2019-05-09T07:31:08.9403681Z Downloading artifact
2019-05-09T07:31:08.9504343Z Starting artifacts download...
2019-05-09T07:31:08.9529560Z Downloading linked artifact UCSFullBuild of type Build...
2019-05-09T07:31:08.9611144Z Ensuring artifact folder C:\agent_work\r15\a\UCSFullBuild exists and is clean.
2019-05-09T07:31:08.9972837Z Preparing to get the list of available artifacts from build
2019-05-09T07:31:12.7137093Z Preparing to download artifact: DataProduction
2019-05-09T07:31:12.7137347Z Artifact Type: ServerDrop
2019-05-09T07:31:12.7137584Z Downloading artifact from file container: #/21053/DataProduction to target: C:\agent_work\r15\a\UCSFullBuild\DataProduction
2019-05-09T07:31:12.7141221Z Parallel download limit: 4
2019-05-09T07:31:12.7141376Z Download buffer size: 8192
2019-05-09T07:31:12.8879541Z Caching items under 'DataProduction' in the file container...
2019-05-09T07:31:13.2098993Z Caching complete. (321 ms)
...
...
2019-05-09T07:31:15.2302885Z Downloading file C:\agent_work\r15\a\UCSFullBuild\DataProduction\DataDownloadService\DataDownloadService.exe.config
2019-05-09T07:31:15.2361468Z Downloading file C:\agent_work\r15\a\UCSFullBuild\DataProduction\DataDownloadService\DataDownloadService.exe
2019-05-09T07:31:15.2472566Z Downloading file C:\agent_work\r15\a\UCSFullBuild\DataProduction\DataDownloadService\DataDownloadService.pdb
...
...
2019-05-09T07:31:23.2807437Z Download complete.
2019-05-09T07:31:23.2814675Z 529 placed file(s): 529 downloaded, 0 empty
2019-05-09T07:31:23.2815434Z 162 MB downloaded at 16515 KB/sec. Download time: 00:00:10.0354580.
2019-05-09T07:31:25.2095564Z Downloaded linked artifact UCSFullBuild
2019-05-09T07:31:25.2095764Z Finished artifacts download
2019-05-09T07:31:25.2137976Z ##[section]Finishing: Download Artifacts
2019-05-09T07:31:25.2233846Z ##[section]Starting: Deploy Windows Service
2019-05-09T07:31:25.2441196Z ==============================================================================
2019-05-09T07:31:25.2441397Z Task         : Windows Service Manager
2019-05-09T07:31:25.2441626Z Description  : Deploys a Windows Service to an Agent or a Deployment Group Target using WinRM. More Information
2019-05-09T07:31:25.2441822Z Version      : 4.1.18
2019-05-09T07:31:25.2441980Z Author       : MDSolutions
2019-05-09T07:31:25.2442136Z Help         :
2019-05-09T07:31:25.2442290Z ==============================================================================
2019-05-09T07:31:27.1815497Z Begining deployment to [SERVER]
2019-05-09T07:31:30.3482879Z [SERVER]: Attempting to locate [DataDownloadService]
2019-05-09T07:31:30.6876280Z [SERVER]: Identified [DataDownloadService] installation directory [C:\Program Files (x86)\INSTALLDIR\DataDownloadService]
2019-05-09T07:31:30.6877249Z [SERVER]: Copying [C:\agent_work\r15\a\UCSFullBuild\DataProduction\DataDownloadService] to [C:\Program Files (x86)\INSTALLDIR\DataDownloadService]
2019-05-09T07:31:31.3018684Z ##[error]Cannot find path 'C:\agent_work\r15\a\UCSFullBuild\DataProduction\DataDownloadService' because it does not exist.
I'm sure that the answer is right in front of me, but TFS is a new venture for us, so I'm currently not even spotting things that should be obvious!
Any help appreciated.
Thanks

I think that this because it is looking for the artifact on the remote machine, is this correct?

Has this been resolved? If not can you please provide the release definition json or yaml.

Closing this due to inactivity, if you are still having issues please let me know.


fix(proto): minor semicolon proto fix

Description
Fix for some minor proto syntax which results in osmosis/telescope failure to genenerate. Won't break anything.
https://github.com/osmosis-labs/telescope

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Looks good - we have a signed commit requirement on this repository, so that might need to be fixed (or I can handle it by creating an identical PR)

@toteki
please go ahead with your pr, I will close this


kamel run simple.js --dev hangs after multiple kill/start

How to reproduce:
kamel run simple.js --dev
wait for the example to start successfully
CTRL+C
Repeat the 3 steps above 3 times (perhaps more), then it occurs that the example stay stuck with log:
Condition "Ready" is "True" for Integration simple
No integration pods looks to be running

can you check if there is any unsatisfied condition in the deployment ?

oc get deployment simple -o json output below status:
    "status": {
        "availableReplicas": 1,
        "conditions": [
            {
                "lastTransitionTime": "2020-06-10T09:18:39Z",
                "lastUpdateTime": "2020-06-10T09:18:39Z",
                "message": "Deployment has minimum availability.",
                "reason": "MinimumReplicasAvailable",
                "status": "True",
                "type": "Available"
            },
            {
                "lastTransitionTime": "2020-06-10T09:18:36Z",
                "lastUpdateTime": "2020-06-10T09:18:39Z",
                "message": "ReplicaSet \"simple-657f4555dd\" has successfully progressed.",
                "reason": "NewReplicaSetAvailable",
                "status": "True",
                "type": "Progressing"
            }
        ],
        "observedGeneration": 1,
        "readyReplicas": 1,
        "replicas": 1,
        "updatedReplicas": 1
    }

But, the status looks to be the same whether the example runs fine or hung up.
pod and integration statuses also remain equivalent.

I seem to reproduce the issue, too. I use Camel K 1.1.0-SNAPSHOT and minikube v1.11.0.
$ kamel run --dev examples/simple.js
...
Condition "DeploymentAvailable" is "True" for Integration simple: deployment name is simple
Condition "ServiceAvailable" is "False" for Integration simple: no http service required
Condition "ExposureAvailable" is "False" for Integration simple: no host or service defined
Condition "Ready" is "False" for Integration simple
Condition "Ready" is "True" for Integration simple

What hangs actually is the kamel run --dev session that's supposed to keep output logs. The deployment still runs fine as you can see running logs from another terminal with kamel log simple.

@aldettinger @lburgazzoli If no one is working on it yet, I can look into it.

Hey @tadayosi , sure you can :+1:

@tadayosi it seems I can't reproduce with Camel-K 1.0.1, maybe linked to #1558

@aldettinger Yes, thanks to #1558 now cleanup of terminating pods seems to get faster. I think that's the reason why the issue no longer happens as frequently as before (less concurrent reads/writes of the pipe to stdout). I still have a feeling that the root cause is some deadlock at the shared pipe to stdout in the SelectorScraper. But for now the issue becomes negligible so let's close it.


new PIO

Thanks! I will test this soon.

On the whole, this is a really nice abstraction. Nice work!
However, a few things need to be changed:

Replace IOPort with Port - this is to make it compile
Some kind of synchronised port (SynchronisedPort?). This could be hairy as many things lock the port themselves, when perhaps what is desired is to lock the port over many operations to prevent other concurrent access on them while the operation is busy. For example, if you wanted to write to a port and then immediately read from it, you might need to synchronise the port over that whole context. This gets difficult as you'd have to pass around the synchronised port in contexts where you use a helper function which assumes that it needs to lock the port. A 'smallest possible synchronisation scope' should be determined to minimise passing around the locked value too often -- i.e read and then write rather than a full data exchange consisting of related but separate logical operations (e.g change scancode and read byte would be synchronised separately instead of together).


make array test length, not truthy-ness

stickyHeaderIndices is an array, so the test is always true. This means new children are always mapped, which shouldn't be the case.
This "fixes" https://github.com/facebook/react-native/issues/2023 - but only when you don't have stickyHeaderIndices. The real problem is the re-mapping children breaks measurement, but that should be a separate fix (I think).

That diff and layout-node removal were reverted - thanks for catching this, though.


Use current slot instead of latest block's slot when validating delegation certificates

Background
This line is incorrect. The semantics of cvsLastSlot were recently refined such that it is now always the slot of the latest block on the chain, which need not be the current slot.
https://github.com/input-output-hk/cardano-ledger/blob/98048d95823b72e409b07481761b8a59c892c56c/cardano-ledger/src/Cardano/Chain/Byron/API.hs#L358
If I understand correctly, that code is only reached from a applyMempoolPayload call, and since that function is used within ouroboros-consensus to flush invalid transactions (including expired delegation certificate transactions) from the mempool, it must actually use the current slot.
Proposed Solution
It suffices to simply add a currentSlot argument to applyMempoolPayload, which will be provided by the recently-added tickedSlotNo in the call in the ouroboros-consensus repo/library.
Next Action

[ ] Establish a local repro? (My current repro is a test-consensus failure; I'm not sure how to distill it down for inclusion into this repo).
[ ] PR here to fix: just add that currentSlot argument. (Edit: I've opened #716 for this.)
[ ] Update ouroboros-consensus (Should this step be a separate ouroboros-consensus ticket?)

Actually, all uses of cvsLastSlot should be audited in the API module, now that applyChainTick does not modify this anymore.

https://github.com/input-output-hk/cardano-ledger/pull/716 addresses some uses of cvsLastSlot, but we should verify the other uses also before closing this ticket.

FYI: I see two direct uses of cvsLastSlot in ouroboros-consensus. (They seem accurate to me.)

I checked the other uses of cvsLastSlot in .API. I think they are all okay, except for
https://github.com/input-output-hk/cardano-ledger/blob/00d6cf3e82240f623863f4aec3aabb56f0c9ea5f/cardano-ledger/src/Cardano/Chain/Byron/API.hs#L370
which suffers from the same problem as the delegation environment.


What the Supported features (available APIs for each device) for ConnectSDK v2.0.0 ?

Hello guys, can anyone say what changes comes with v2.0 release? Interested in anything. Firstly about fundamental knowledges like increasing amount of devices with supported and implemented features of ConnectSDK.
In documentation page: https://connectsdk.com/en/latest/fundamentals/supported-feature.html,
there is info that System Controls & TV Controls not available for FireTV, is it still  like this?
If you have any information about it or where we can found it, please text it here!
Thanks for all answers!

Hi @b0r1ngx
i need one help for ConnectSDK for Swift project, i am setup LocalNetwork permission and other permission and devices also connect with same wifi but discovery manager not fetch any devices, can you please help me for this situations.
Thank You

Hello @HarshadTechmero, it's right to understand, that I'm not the maintainer of this project!
I'm just a regular user of this library that also meets some problems when using it, with things that it is not so well documentated.
I'll try to answer your question in the next week, I'm busy a bit now!

@b0r1ngx
Thank you for reply and valuable time,
Please try to help me for this if possible
Thanks

@b0r1ngx Just kind of information have you created app for TV Remote control? actually i am working on TV Remote Control so

Hi @b0r1ngx I need help for sending Pairing Code to Connectable device, I have code but device not show any pairing code
self.connectedDevice = obj   self.connectedDevice?.delegate = self   self.connectedDevice?.setPairingType(DeviceServicePairingTypeMixed)    self.connectedDevice?.connect()
Try with pairingType DeviceServicePairingTypeMixed, DeviceServicePairingTypePinCode and DeviceServicePairingTypeFirstScreen but no luck
Can you please help if possible


Bytecode concurrency

We need to investigate and make sure the compiled bytecode is re-usable by multiple VM instances and is concurrent safe as well.

Hello, is this direction abandoned, or you are waiting for volunteers?

It’s not abandoned, but there has been little time recently to work on major improvements so contributions would be welcome.

Hi, for testing bytecode concurrency if it is enough to run a fat tengo script with enabled race detector and spawning a lot of goroutines to run scripts concurrently for a long time, I can try to do that if you like.


Enable integrations targeted for dash'23 with python3.8

What does this PR do?
These integrations have to be functional with agent 7.46 which has python3.8

DCGM Exporter
Torchserve
Weaviate

Motivation
DASH 2023
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

No longer needed. Decision made to release this starting 7.47 and customers can wait for 30days post DASH


Arithmetic operations with decimals return incorrect results

Driver version
12.4.0.jre11
SQL Server version
Microsoft SQL Server 2019 (RTM-CU15) (KB5008996) - 15.0.4198.2 (X64)
Jan 12 2022 22:30:08
Copyright (C) 2019 Microsoft Corporation
Express Edition (64-bit) on Linux (Ubuntu 20.04.3 LTS) <X64>

Client Operating System
Ubuntu on Windows version 2004.2022.1.0
JAVA/JVM version
1.17
Table schema
CREATE TABLE dbo.df_test_all_types
(
    ID           INT PRIMARY KEY,
    COL_TINYINT  TINYINT,
    COL_SMALLINT SMALLINT,
    COL_INT      INT,
    COL_BIGINT   BIGINT,
    COL_FLOAT    FLOAT,
    COL_NUMERIC  NUMERIC,
    COL_DECIMAL  DECIMAL(19, 8),
    COL_BOOLEAN  BIT,
    COL_DATE     DATE,
    COL_TIME     TIME,
    COL_DATETIME DATETIME,
    COL_VARCHAR  VARCHAR(100),
    COL_NVARCHAR NVARCHAR(100),
    COL_TEXT     TEXT,
    COL_BLOB     VARBINARY(5000)
);

INSERT INTO dbo.df_test_all_types (ID, COL_INT, COL_BIGINT, COL_DECIMAL, COL_BOOLEAN,
                                   COL_VARCHAR, COL_NVARCHAR, COL_TEXT)
VALUES (1, 1, 1000, 48.9, 0, 'Some string', 'Some other string', 'Some Text');
INSERT INTO dbo.df_test_all_types (ID, COL_INT, COL_BIGINT, COL_DECIMAL, COL_BOOLEAN,
                                   COL_TEXT)
VALUES (2, 2, 2000, -48.999, 1, ' TrimText ');
INSERT INTO dbo.df_test_all_types (ID, COL_INT, COL_BIGINT, COL_DECIMAL, COL_BOOLEAN,
                                   COL_VARCHAR, COL_NVARCHAR, COL_TEXT)
VALUES (3, 3, 3000, 25, 1, '1234', '1234', '1234');
INSERT INTO dbo.df_test_all_types (ID, COL_INT, COL_BIGINT, COL_DECIMAL, COL_BOOLEAN,
                                   COL_VARCHAR, COL_NVARCHAR, COL_TEXT)
VALUES (4, 4, 4000, 12.34, 1, '2147483650', '2147483650', '2147483650');
INSERT INTO dbo.df_test_all_types (ID, COL_INT, COL_BIGINT, COL_DECIMAL)
VALUES (5, 5, 10, 2.5);
INSERT INTO dbo.df_test_all_types (ID, COL_TINYINT)
VALUES (6, 19);

Problem description
This new version of the driver introduces some changes on how arithmetic operations with decimals work.
For a better understanding consider the follwing examples.
Sum of 3 big decimals with different precision rounds the value to the closest integer:
Query: SELECT ?  + ?  + ? TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("4"), new BigDecimal("5") and new BigDecimal("3.14")
Expected Result: 5.86
Actual Result: 6
Multiplication followed by a Subtraction of 3 big decimals with different precision returns a decimal without precision:
Query: SELECT ? * ? - ? FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("4"), new BigDecimal("2") and new BigDecimal("1.00")
Expected Result: 7.00
Actual Result: 7
Subtraction of 2 big decimals rounds the result to the closest integer:
Query: SELECT ? - ? FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("4.0") and new BigDecimal("3.14")
Expected Result: 0.86
Actual Result: 1
Subtraction of 2 big decimals round the result to a decimal with the lowest precision:
Example 1
Query: SELECT ? - ? TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("4.0") and new BigDecimal("3.14")
Expected Result: 0.86
Actual Result: 0.9
Example 2
Query: SELECT ? - ? TABLE_EXAMPLE WHERE "ID" = 4]
Dynamic Parameters: new BigDecimal("1.23") and new BigDecimal("1.2")
Expected Result: 0.03
Actual Result: 0.0
Incorrect precision when using CAST
Example 1
Query: SELECT ? - CAST("COL_INT" AS DECIMAL(38, 2) FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("0.00")
Expected Result: 0.00
Actual Result: 0
Example 2
Query: SELECT ? - CAST("COL_BIGINT" AS DECIMAL(38, 2) FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("-3996.00")
Expected Result: -3996.00
Actual Result: -3996
Example 3
Query: SELECT ? - "COL_DECIMAL" FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("-3996.00")
Expected Result: -8.34000000
Actual Result: -8
Error message/stack trace
Not applicable. The driver returns no error. The result though is no the expected one.

Hi @OS-veracardoso,
For driver versions up until 12.2, and for version 12.4 onwards, BigDecimal precision and scaling values need to be set using setBigDecimal when using a prepared or callable statement. The behavior was "correct" from 12.2 through 12.4, where the driver calculated correct precision and scaling based on the input parameter, however this also introduced major performance problems. As a result, we have decided to roll back how BigDecimal values are handled to the pre-12.2 way, which means users need to use setBigDecimal to ensure proper results following mathematical operations.
This same information can be found in our docs here.
Please let us know if you have any further questions or concerns.

Hi Jeffery,
On all the use cases described, the dynamic parameter is being set using setBigDecimal on the preparedStatement. This is how it looks like:
   preparedStatement -> {
           preparedStatement.setBigDecimal(1, new BigDecimal(left));
           preparedStatement.setBigDecimal(2, new BigDecimal(right));
  }

What happens if you explicitly pass in precision and scale as below?
   preparedStatement -> {
           preparedStatement.setBigDecimal(1, new BigDecimal(left), left.precision, left.scale);
           preparedStatement.setBigDecimal(2, new BigDecimal(right), right.precision, right.scale);
  }

What happens if you explicitly pass in precision and scale as below?
   preparedStatement -> {
           preparedStatement.setBigDecimal(1, new BigDecimal(left), left.precision, left.scale);
           preparedStatement.setBigDecimal(2, new BigDecimal(right), right.precision, right.scale);
  }

Hi @Jeffery-Wasty,
That signature is not available (https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/sql/PreparedStatement.html).
Neverthless, the scale and precision are correctly set on the BigDecimal that is being set, as you can confirm in the follwing screenshot:

I confused PreparedStatement with the JDBC SQLServerPreparedStatement. Please either use SQLServerPreparedStatement or cast PreparedStatement to SQLServerPreparedStatement.

I confused PreparedStatement with the JDBC SQLServerPreparedStatement. Please either use SQLServerPreparedStatement or cast PreparedStatement to SQLServerPreparedStatement.
Even when precision and scale are correctly for the value, unless they are passed in with setBigDecimal the driver has no way of knowing what they are and will assume values that can cause truncation issues.

Hi @Jeffery-Wasty the application we use supports multiple drivers, so the prepared statement logic is kind of abstract and only uses the available signatures, so we cannot do the cast that you suggest.
As mentioned on my previous comment, we do use setBigDecimal to set the value on the prepared statement, so the scale and precision are defined on the value set, as displayed in the image on my previous comment.

As mentioned on my previous comment, we do use setBigDecimal to set the value on the prepared statement, so the scale and precision are defined on the value set, as displayed in the image on my previous comment.

Even when the precision and scale are set correctly in the BigDecimal being passed in, we still require it to be explicitly passed in. Attempting to parse the BigDecimal to get precision/scale leads to major performance impact with the JDBC driver.
If its not possible to use SQLServerPreparedStatement, another option is to use a version of the driver between 12.2 and 12.4. These versions of the driver do calculate precision and scale from BigDecimal, but you may experience additional performance impact that caused us to rollback these changes in 12.4.
We're investigating whether there is another way to proceed with this situation.

I've setup a MySQL DB + mysql-connector-j driver to compare, and it looks like MySQL is behaving correctly. The math operations come out correct despite not explicitly specifying the precision and scale for the prepared statement.
We'll need to do more research and compare the mssql-jdbc driver to MySQL's mysql-connector-j driver.

I've setup a MySQL DB + mysql-connector-j driver to compare, and it looks like MySQL is behaving correctly. The math operations come out correct despite not explicitly specifying the precision and scale for the prepared statement.
We'll need to do more research and compare the mssql-jdbc driver to MySQL's mysql-connector-j driver.

Yes, if you try with Oracle, it also returns the expected result.

@OS-veracardoso The mssql-jdbc driver's behaviour regarding precision and scale closely mirrors JTDS. And, from when I last checked, JTDS behaves similarily if precision and scale isn't explictily supplied. If this is working for you with other JDBC drivers, likely the mssql-jdbc might be wrong or missing some logic. What are the other drivers you are using in your application?

It works as expected using mysql and oracle JDBC drivers, for instance. This was also working with the previous version of mssql driver. We notice this regression while trying to upgrade to the latest version and our tests started to fail.

hi @OS-veracardoso
apologies for the delay in response we've been busy with getting ready for a hotfix release.
You are correct this had worked in a previous version of the driver however we backed out of the fix in #1928 when we discovered there was a performance issue with the fix. The issue is that there is no way for the driver to know what the underlying precision/scale is without contacting the server and that would impact performance. We will investigate further to see how this is accomplished by other drivers.

hi @OS-veracardoso
apologies for the delay in response we've been busy with getting ready for a hotfix release.
You are correct this had worked in a previous version of the driver however we backed out of the fix in #1928 when we discovered there was a performance issue with the fix. The issue is that there is no way for the driver to know what the underlying precision/scale is without contacting the server and that would impact performance. We will investigate further to see how this is accomplished by other drivers.

@lilgreenbird Thank you.

Hi @OS-veracardoso,
In addition to the testing we did previously with our own driver, we looked into jTDS and the MySQL Java connector.
For jTDS, it behaves the same as the JDBC driver, producing similar arithmetic errors. For the MySQL connector, they are using a similar approach to what we did in 12.2, being able to parse the BigDecimal to fetch precision and scale from there. We're not sure what kind of performance impact this introduces to the driver, but the same approach in the JDBC driver caused a noticeable performance impact. We tried to find a way that precision could be updated for the parameter type definition without recreating the whole execution plan (the reason for the performance impact) but were unable to do so.
For the time being, we ask that you consider using the 12.2 version of the driver, as that version has the BigDecimal fixes you are interested in. A potential enhancement to the driver could include a connection property to restore previous BigDecimal behavior, at the cost of performance. We'll keep this issue open while that option is still in consideration/development.

Hello,
I just tested the new version of the driver, and some operations are still not behaving like they used to in version 12.3.1.jre11.
Example1:
Query: SELECT TOP (1) ?  + ?  - ? TABLE_EXAMPLE
Dynamic Parameters: new BigDecimal("4"), new BigDecimal("5") and new BigDecimal("3.14")
Expected Result: 5.86
Actual Result: 6

Example 2:
Query: SELECT TOP (1) ?  * ?  - ? TABLE_EXAMPLE
Dynamic Parameters: new BigDecimal("4"), new BigDecimal("2") and new BigDecimal("1.00")
Expected Result: 7.00
Actual Result: 7

Example 3:
Query: SELECT TOP (1) ? - ? TABLE_EXAMPLE
Dynamic Parameters: new BigDecimal("4.0") and new BigDecimal("3.14")
Expected Result: 0.86
Actual Result: 0.9

Example 4:
Query: SELECT ? - "COL_DECIMAL" FROM TABLE_EXAMPLE WHERE "ID" = 4
Dynamic Parameters: new BigDecimal("4")
Expected Result: -8.34000000
Actual Result: -8

We also realized that the precision with decimal division changed. For isntance, the query SELECT ? / ? FROM TABLE_EXAMPLE with
ps.setInt(1, 3);
ps.setBigDecimal(2, new BigDecimal("2"));
``
used to return `1.5000000000000000000000000000` and now it returns `

@OS-veracardoso For the latest preview release 12.5.0, you'll need need to use the new boolean connection property calcBigDecimalScale. Setting this to true should apply the old 12.3.1 behaviour.

Hi @OS-veracardoso,
I will take another look, but the code is identical to 12.3.1 (with the added condition being that the connection property must be set). If you're able to confirm that the preview release, 12.5.0, is not working the same as the former version, 12.3.1, with the connection property enabled, that would be something we would need to resolve.

Hello, this is now happening again in version 12.6.0.jre11. Could you please take a look?

Hi @OS-veracardoso,
We changed the name to calcBigDecimalPrecision (it was improperly named before). Are you setting that to true in your connection properties?


Investigate use of CSS variables instead of SASS/SCSS for Bulma and Oruga libraries

We can get rid of all SCSS/SASS pre-processing and only use CSS customisation for Oruga and Bulma.
So it will possible to expose some of that customisation as part of the explorer runtime configuration.


Enforce per-user|device rules

It would be nice if Allowed IPs could be enforced by firewall rules on a per-user or per-device level so they can't be overridden by a user. Right now it's possibile to modify the client configuration and gain access to more IPs than intended.

Currently under development as part of #259 ! Will link this issue to the relevant PR when it's ready.
Thanks for the feedback!

@princemaple Any thoughts on taking a stab at this one? It's somewhat involved -- happy to get on a call or add more context as guidance.

If this is more than just comparing allowed_ips on device with allowed_ips on site, I'll need a call.

Hmm, let's table this for a bit. I'll be deep in this part of the codebase working on multi-interface support so I may just see how easy it is to add as I'm doing that work.
This one would essentially be adding a source modifier to the rule tuple in fz_wall that corresponds to either a user (list of devices' IPs) or a single device IP.

Per-user firewall rules should be coming in 0.5.0, due in a week or two.

Wow, this is great news. Thanks for the effort.
Jul 2, 2022 21:24:26 Jamil @.***>:

Per-user firewall rules should be coming in 0.5.0, due in a week or two.
—
Reply to this email directly, view it on GitHub[https://github.com/firezone/firezone/issues/423#issuecomment-1172948676], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AACKUCS37CE7H4XUZBL6XL3VSCJOFANCNFSM5NAMZR2Q].
You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/AACKUCRWCL2VN2JZICXUR6DVSCJOFA5CNFSM5NAMZR22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIXU4NRA.gif]