[animo/animate] A little on the Hefty Side

I love it. But it's a little chunky weighing in at 116KB minified (example). Thoughts on repackaging with a different bundler to see if we can slim this puppy down a little? (Please disregard how I'm loading it right now.)

Yes, good call. I've been considering switching to rollup so let me give it a shot and see what I can come up with. Thanks!

Solid.

Just wanted to give you a quick update. I've been experimenting and it looks like I might be able to shave at least 30kb off of the build. I have some more ideas and want to work on it a bit more but I'm hoping to publish something within the next couple of days

You can follow along here: https://github.com/ThrivingKings/animo/pull/18
Thanks for calling me out on this— the bundles were unnecessarily large. I still have some tinkering to do before I call it good, but right now I'm seeing bundles around 18kb total :)

Much appreciate the quick action. You need a PR reviewer feel free to ping.

sorry, this took longer than I thought it would, but all bundles are checking in around 18kb, so way better than before. it all checked out on my end but let me know if you have any issues with https://github.com/ThrivingKings/animo/releases/tag/v1.0.8

 thanks hoss


Fix #3033: Rehaul JSEnv API

This is a full rehaul of the JSEnv API. Highlights include:

No synchronous interface.
Proper stopping/closing semantics.
Proper message passing semantics.
Removal of JSConsole.
Reduce implementation inheritance.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4525/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6159/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4526/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6160/
Test FAILed.

Note to self: Stuff to do after this PR:

Change TestAdapter to take Input.
Change sbt plugin to use Input.
Reduce threads by passing on a special purpose thread pool.
Investigate better logging.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4527/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6161/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4528/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6162/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4529/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6163/
Test FAILed.

Jenkins, retest this please.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4530/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6165/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4531/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6166/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/4532/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/6170/
Test FAILed.

Rebased onto master.

Updated:

Removed the double close
Added an UnsupportedInputException.

TODO:

Figure out details about RunConfig (what to do with new options).

@sjrd WDYT about adding a verifier for RunConfig? I'm a bit split since it is some more code, but probably the most flexible option :S

What exactly do you have in mind? Are you talking about https://github.com/scala-js/scala-js/pull/3255/files#r161516032 or https://github.com/scala-js/scala-js/pull/3255/files#diff-cf497553966fa6b2293facc6a6d947eeR26? Or something else?

The second one. Basically it's about the semantics of RunOptions: I do not think we should make it optional for a JSEnv to adhere to them by default. So that leaves us with two ways of maintaining compatibility:

Restricting ourselves to only add options in the future that can reasonably made optional (n.b. they may not cause a change in behavior, but maybe efficiency).
Providing a forward compatible way for a JSEnv to determine if it handled all the set options.

The second option would be the validator framework where a JSEnv can tell the validator what options it supports and the validator checks this with the set options. Since the validator is provided by the base library, it will always know about all options.
Use of the validator would look something like this:
def start(input: Input, config: RunConfig): Unit = {
  config.validator()
    .supportsA()
    .supportsC()
    .validate()  // fails if B is non-default.
}

Right. Yes, I think it should be good to have a validator like that. It doesn't seem to be that much more code, is it?

Updated. Note the additional commit.

Summary of CI errors:

Scaladoc error in jsenvs-test-kit

[error] .../js-envs-test-kit/src/main/scala/org/scalajs/jsenv/test/JSEnvSuite.scala:13: Tag '@RunWith(classOf[JSEnvSuiteRunner])' is not recognised
[error] /** Conformance test suite for any [[JSEnv]] implementation.
[error] ^
[error] one error found
[error] (jsEnvsTestKit/compile:doc) Scaladoc generation failed

SourceMapTest failure in test-suite-ecma-script6 testSuite=testSuite (all Scala versions)

[info] Test org.scalajs.testsuite.compiler.SourceMapTest.workTest0 started
[error] Test org.scalajs.testsuite.compiler.SourceMapTest.workTest0 failed: java.lang.AssertionError: null, took 0.108999936 sec
[error]     at java.lang.AssertionError.fillInStackTrace(.../test-suite/js/target/scala-2.12/scalajs-test-suite-test-fastopt.js:262754)
[error]     at java.lang.AssertionError.this(.../test-suite/js/target/scala-2.12/scalajs-test-suite-test-fastopt.js:262801)
[error]     at java.lang.AssertionError.this(.../test-suite/js/target/scala-2.12/scalajs-test-suite-test-fastopt.js:309532)
[error]     ...

(same for all the other tests in that suite)

Rebased on top of #3306.

One question: why is the commit "Always assume test-inteface is present" necessary here? I thought I'd figure it out by the time I was done reviewing the whole PR, but I didn't ^^

One question: why is the commit "Always assume test-inteface is present" necessary here? I thought I'd figure it out by the time I was done reviewing the whole PR, but I didn't ^^

Because with the new interface, we do not expect a JSEnv to provide termination anymore. So if we bring up a JSEnv in which the test-interface is not loaded (and we hence silently do not call it), we will wait forever (or we would have to decide on a timeout, which is also not very nice). #3294 will turn this into a link time error, so I think this is acceptable.

Ah I see. OK.

Updated: I should have addressed all concerns (except for the public TestKit).

There's a Scaladoc error:
[info] Main Scala API documentation to .../nodejs-env/target/scala-2.11/api...
model contains 11 documentable templates
[error] .../nodejs-env/src/main/scala/org/scalajs/jsenv/nodejs/ComSupport.scala:195: Could not find any member to link for "VirtualJSFile".
[error]   /** Starts a [[JSComRun]] using the provided [[JSRun]] launcher.
[error]   ^
[error] one error found
[error] (nodeJSEnv/compile:doc) Scaladoc generation failed

Updated.

Updated, passes now.

in the community build I'm now seeing failures like
[scala-js] [info] Test org.scalajs.testsuite.compiler.SourceMapTest.workTest0 started
[scala-js] [error] Test org.scalajs.testsuite.compiler.SourceMapTest.workTest0 failed: java.lang.AssertionError: null, took 0.299000064 sec
[scala-js] [error]     at <jscode>.$c_jl_AssertionError.$c_jl_Throwable.fillInStackTrace__jl_Throwable(/Users/tisue/community.211-8/target-0.9.11/project-builds/scala-js-d0f50bf8b3014a5c1286c15f07cc86900faa7b37/test-suite/js/target/scala-2.11/scalajs-test-suite-test-fastopt.js:313660)
[scala-js] [error]     at <jscode>.$c_jl_AssertionError.$c_jl_Throwable.init___T__jl_Throwable(/Users/tisue/community.211-8/target-0.9.11/project-builds/scala-js-d0f50bf8b3014a5c1286c15f07cc86900faa7b37/test-suite/js/target/scala-2.11/scalajs-test-suite-test-fastopt.js:313707)
[scala-js] [error]     at java.lang.AssertionError.this(/Users/tisue/community.211-8/target-0.9.11/project-builds/scala-js-d0f50bf8b3014a5c1286c15f07cc86900faa7b37/test-suite/js/target/scala-2.11/scalajs-test-suite-test-fastopt.js:364376)
[scala-js] [error]     ...

?
let me know if you need more details (perhaps in a new ticket?)

@SethTisue A new ticket would be good. We forget closed PRs too easily.
Unless you manage to fix the issue on the community build side with this setting:
set wantSourceMaps in testSuite := false

?

set MyScalaJSPlugin.wantSourceMaps in testSuite := false did the trick 👍


Trivial theorem can't be proved automatically?

See the following code:
val pred: int -> prop
let pred x = x == 0

val pred2: int -> prop
let pred2 x =
  let _ = () in
  pred x /\ True

val pred2_eq: x:int -> Lemma
  (requires pred2 x)
  (ensures pred x)
[@@expect_failure]
let pred2_eq x = ()

val pred2_eq_workaround: x:int -> Lemma
  (requires pred2 x)
  (ensures pred x)
let pred2_eq_workaround x =
  assert_norm(pred2 x <==> pred x)

(looks somehow a bit familiar to #2694, with the /\ True and the workaround with assert_norm)


New image command line option (-i) saves with pending UI events that error later

I have a script that generate a DPRO image with various extra windows open (including an IdeaSpaceShell with a SystemBrowser). That script works fine and opening the saved image works fine. I have a second script that opens the DPRO image, saves it with a new name (-i JadeDev), and then exits (-x). That script finishes without error but subsequent attempts to open the second image almost always results in an error (that can be dismissed without further harm).
The error is the same each time a particular image is reopened, but will often change when the second script is rerun. The stack shows a UI event sent to an invalid widget (e.g., a null or 16r0 handle) or an attempt to call a function in a library (DLL) that doesn't exist (see below for a Canvas with a null handle). Since the error is the same each time the same image is reopened, I suspect that the pending event is in the queue at the time of the image save.
It seems that we should wait till the event queue is empty and the system is quiet before the save. We could also view this as a startup problem in which saved events should be treated with some skepticism.
2:11:05 PM, Monday, July 17, 2017: 'The specified procedure could not be found. (16r7F: The specified procedure could not be found.)'
UserLibrary(ExternalLibrary)>>invalidCall
UserLibrary>>endPaint:lpPaint:
[] in TabViewXP(View)>>basicPaint:wParam:lParam:
[] in Win32Error(Exception)>>_evaluateHandler:in:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
Win32Error(Exception)>>_evaluateHandler:in:
Win32Error(Exception)>>_propagateFrom:
Win32Error(Exception)>>_propagate
Win32Error(Exception)>>signal
Win32Error class(Exception class)>>signal
GDILibrary(ExternalLibrary)>>systemError
Canvas {16r0} >>textExtent:
TabViewXP>>paintVerticalLabel:on:in:
TabViewXP>>paintVerticalTabLabelsOn:
TabViewXP>>onPaintRequired:
[] in TabViewXP(View)>>basicPaint:wParam:lParam:
ExceptionHandler(ExceptionHandlerAbstract)>>markAndTry
[] in ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>on:do:
TabViewXP(View)>>basicPaint:wParam:lParam:
[] in TabViewXP>>wmPaint:wParam:lParam:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
TabViewXP(ControlView)>>withOldWndProc:
TabViewXP>>wmPaint:wParam:lParam:
TabViewXP(View)>>dispatchMessage:wParam:lParam:
[] in InputState>>wndProc:message:wParam:lParam:cookie:
BlockClosure>>ifCurtailed:
InputState>>wndProc:message:wParam:lParam:cookie:
InputState>>pumpMessage:
InputState>>loopWhile:
InputState>>mainLoop
[] in InputState>>forkMain
ExceptionHandler(ExceptionHandlerAbstract)>>markAndTry
[] in ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>ifCurtailed:
BlockClosure>>ensure:
ExceptionHandler(ExceptionHandlerAbstract)>>try:
BlockClosure>>on:do:
[] in BlockClosure>>newProcess

This looks to me like it is probably an issue with the way the image save command line option has been added to the development session manager. It isn't safe to directly save the image during the startup processing (as this is doing) as at this point the startup process (which is the old main process) may be running alongside a new main UI process. When the saved image restarts you now have another UI process already running, since the startup interrupt is sent back to the process that was running when the image was saved.
The simplest fix is probably to defer the image save so that it gets processed by the new main UI process after the startup process (the old main process) has killed itself, e.g. with ``InputState>>queueDeferredAction:". The quit command would need to be deferred as well, as otherwise it will run before the image save has occurred.

Unfortunately, any save (-d or -i) with a pending quit (-x) will resulting on an immediate quit each time the saved image is launched (because the deferred actions are processed). Should an image save clear the entire deferredActions queue and restore it after the save? Are there deferredActions that should happen on image startup? If so, wouldn't it be more reliable to have them associated with a startup event?
Also, should the -d be deferred? Should it do an automatic save or should we have a new option to save?
How about a file-in (-f)? Is it safe to do during a startup or should everything be deferred?

Hmm, yes, I can see that would be a problem. Clearing out the deferred actions doesn't seem like the right thing to do since it could be any arbitrary operation that somebody wanted to put there, and in general that will work fine over an image save. Perhaps the simplest thing to do is to make the save and exit a composite operation that can be deferred, either by always performing an exit after a save, or by assembling a composite operation in the command processing method, and then queuing that. It should be easy enough to do with blocks.
Another (perhaps easier) way would be to create a unique identifier for the session, stored in an instance variable of the SessionManager at some early stage of startup, e.g. from Guid newUnique. Then this can be "copied" into the exit block (i.e. assign it into a temp outside, and then reference that temp from the exit block, not the inst var). The exit block can then compare the current session guid against the one it has stored, and if they don't match, it can skip the exit.


Disprove execution

This PR offers a function to find which chunk is available when the operator did some malicious thing. This function re-runs chunker using the wrong proof to get a wrong-proof assigner, then checks the inconsistency between the wrong-proof assigner and the assigner recovered by assert transaction.
There are two cases a malicious operator can do.

Operator put a wrong proof to generate all intermediate values, say $$S$$. In this case, the final accumulator will be wrong, and the challenger can take collateral by executing the "accumulator verifier" chunk. This case is covered by unit test test_wrong_proof.
Operator put a wrong proof and modify some intermediate values to make some chunks pass, say $$S'$$. In this case, there must be a chunk whose parameter is the same as in $$S$$, but the result is different in $$S$$. The challenger can execute this chunk. This case is covered by unit test test_wrong_proof_and_modify_intermediates.

I think if we use OP_VERIFY in the script then we have to execute the actual script to check if the operator lied. Otherwise, they can provide a proof that has all correct bit commitments in the execution trace while failing an OP_VERIFY check for them.

Fix repeated variable name {}_loop_{}_piece_1 induced from https://github.com/BitVM/BitVM/pull/139
https://github.com/BitVM/BitVM/blob/c00a487360bbbf5d6e6510a611a43c897504e351/src/chunker/chunk_scalar_mul.rs#L73-L79


[DOC]:

📚 The doc issue
教程写得太差了！ 建议按部就班，从安装到使用，写的详细点。

Thanks for your advice, We will try to improve the quality of our tutorial documents.

Thanks for your advice, Can you tell me about more unsatisfactory details？ We will try our best to improve the quality of our tutorial documents.

Thanks for your advice, Can you tell me more about unsatisfactory details？ We will try our best to improve the quality of our tutorial documents.


Hotfix/<IP_ADDRESS> - fix missing char in RNIapModule.java

fix missing char in RNIapModule.java which causing build/run error on android

Would be good to get this into a release as soon as possible. This will cause failed purchases on some devices (we've seen it 20 times in the past 2 days.)

@lwansbrough I’ve already published this to 0.3.3 did you try this one?

I see that now, thanks!


WIP: Update vendoring

This is an experiment checking to see the effects of dep ensure -update.

@irfanurrehman @shashidharatd @font @pmorie @gyliu513
I was trying to add a dependency to k8s.io/kubectl and it changed other vendored code so I figured it was time to update deps.  The line count on this PR looks extreme, though.  Am I doing something dumb?

@marun when I was working on https://github.com/kubernetes-sigs/federation-v2/pull/148#issuecomment-405803396 , I also found that many dependency files need some update, I think it is ok to update those files.
Also do we need to update versions for other dependencies in Gopkg.toml as well? like update kubernetes to 1.12 or so?

This LGTM, its high time we update the vendor code. the huge code size is understandable.

@gyliu513 We weren't pinning so kubebuilder was updated to the latest (see Gopkg.lock).
It still seems crazy to me that we have so much vendoring.  Our pkg path takes ~2.2MB.  vendor takes 351MB.

@marun not sure if all vendors are used, we may need a cleanup about this. I can help on this after KubeCon if no one work for this.
But for now, I'd prefer that we merge your PR first to make sure the dep ensure works well with current Gopkg.toml.
Also not sure if we can follow the way as https://github.com/kubernetes/cluster-registry , currently, for this project, they are not committing vendor https://github.com/kubernetes/cluster-registry/blob/master/docs/development.md#run-all-tests

For cluster registry not committing the vendored tree is essential to enabling vendoring by projects like us.  I'm less clear on the value of federation not committing vendored code, since I think the priority is simplifying development rather than vendoring by 3rd parties.

Ah, I see, thanks @marun , then I think we need a task to do a clean up for the unused vendors similar as what we did for Istio https://github.com/istio/istio/pull/9050 , how about open an issue to trace this?

/lgtm


Components and exception handling

Add a service for analyzing a single observation
Add an exception for when an annotation is not mapped
Add utility method for getting LoincIds from Observation components

Good point, Aaron. I'll leave it as is for now, but you are right that it will morph as we start using components in our analysis. For now, I'm simply recording the information when gathering stats from sandboxes so that once we have access to real data we can get an idea of how often components are used and in which scenarios.


fixes jq error while running addSharedNode script

https://github.com/Shippable/admiral/issues/2126

This is complete.
Closing


Improving the home page UI completely and adding more relevant content to make GDSC-RCCIIT stand out from rest of the others.

Improving the home page UI completely and adding more relevant content to make GDSC-RCCIIT stand out from rest of the others.

@rishicds please assign me the issues and let me know your suggestions or concerns in case you have any.

assigned,


helper-cli: Fix compile error

The package renaming done by 5eab6e706ef was not reflected in that import
statement and thus broke the compilation. For not yet known reason this
slipped through CI.
Signed-off-by: Frank Viernau<EMAIL_ADDRESS>

Merge without checks as the fix is trivial, was tested locally and unbreaks compilation.


[bug] - import score doesn't work anymore

augustin is sad, a lot of people seems to used our metronome

fixed! Augustin should be happy now that he can imported into the web :)


Add support for the "windows menu" key for shortcuts

Add support for the "windows menu" key for shortcuts
#6635 introduced the commandPalette command.  I would really like to be able to bind this to the "windows menu key" however this does not seem to be possible.
Either it is possible and the keyname is not documented, or the documentation is correct and this is not possible.
As a user I expect to be able to use any key on my keyboard in order to bind commands (including keys that may be special for example some extended MS keyboards with a calculator button) by specifiying a keycode if required and the key does not have a common name.

Proposed technical implementation details (optional)

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #3184 for more discussion.
/dup #3184

@zadjii-msft is this a duplicate? on reading #3184   it seems to only be talking about the winkey and it appears there may be issues with that.  here I am talking about the win-menu (that by default does almost a right mouse click and is located in the UK layout on the right hand side of the soacebar) which is a different key.
happy if they are to be handled together that they are merged but it sounded like technically there may be issued to do so.

incorrect dupe - more likely 7144 now implemented?

Yes - you're right about that. My bad for not catching the difference earlier!


Remove dependency on silex.sile and other compatibility shims

Things to address
1. The only reason why this package depends on silex.sile is for silex.compat.
It was for:

SILE.typesetter:makeHbox = SILE 1702, introduced in 0.14.9
SILE.typesetter:computeLineRatio also returning the total width = SILE 1378 added in 0.13.x IIRC

I don't think there was other reasons...
We should probably stop trying to support these old SILE versions.
2. This module also provides a resilient-compat/hboxing.lua file which providing a workaround (for other modules) for an issue fixed in SILE 0.14.9 (see SILE 1702)
We should check which module were concerned, and remove this old compatibility layer... Probably no longer applies anywhere.
3. In the parbox framing code, we still have
  if not SILE.typesetters or not SILE.typesetters.base then
    -- Compatibility shim for SILE 0.14.0..0.14.5
    parboxTypesetter = SILE.defaultTypesetter()
  else
    -- Breaking change for SILE 0.14.6 and upper
    parboxTypesetter = SILE.typesetters.base()
  end

Again, I don't think it's worth still trying to support those old versions, and I no longer test them.
How?
Maybe enforce using a recent enough version of SILE (ex. > 0.14.13) and warn if it's older
Not sure.
Moreover, it doesn't seem SILE exposes its new "semver" logic for use with 3rd party pages, though... So we can't do e.g.
if SU.semver and SU.semver(SILE.version) <= SU.semver(0.14.13) then
   SU.error("Your version of SILE is too old")
end

But we then have to require("semver")... which means doing it a a pcall for earlier versions. Doh, it defeats the point of checking anything, no?

Regarding semver: SILE can't retro-actively provide features in old versions, no. But then again neither can this library, so anything you add at this point people would have to upgrade to get. If you write new features/code and make new releases I would strongly support expecting them to be used against an equivalently new SILE version. As long as your minimum supported version of SILE is v0.14.11 or newer you can assume require("semver") will work.
If you want to make make a little more effort at warning people when they may be on too old a SILE version if they install a new version of your module, you can add semver to your packages's rockspec dependencies. Then you can safely load it and assume it is there even if not transitively supplied by SILE's dependencies.

After a good night of sleep: I think I'll just remove all compat shims and update the README with a minimal requirement. On the long terms it doesn't seem I can properly handle the old compat shims without testing, and I can't afford the time.

I think that's fair. If there does become some reason to support old versions of SILE we do need to work out some way to test too. That probably means using Docker or Nix flakes and can be done, but personally I'd rather sink my time into helping people update to work with current SILE than in back porting stuff so they can stay behind.


Upload function of local symlink file uploads the symlink and not the file it points to

I'm having an issue using upload function to upload a .env file for Laravel.
I have it symlinked because I sync my files on all my workstations but upload function actually uploads the symlink, not the file it's pointing to.
Is there any way to make it follow that symlink?

It uses rsync

It uses rsync

Could you elaborate on this a bit? I know there's a -L flag on rsync but can i pass that through the upload function?

Hmmm,  maybe we should just add this flag to function?

I see no reason why not. I'm guessing right now there isn't a way to pass that flag to rsync?

I think there is not. But I may be wrong.

I am cleaning up on issues. Fill free to reopen if needed.
Also, we have a new section available: discussions.


Select widget options

I'm using the widget found at https://github.com/algolia/instantsearch.js/issues/1022 and slightly edited to
instantsearch.widgets.customSelectorWidget = function customSelectorWidget(options) {
  var container = options.container;
  var attributeName = options.attributeName;
  var limit = options.limit || 10;
  var title = options.title || 'All';
  var heading = options.heading;

  // container should be a CSS selector, so we convert it into a DOM element
  container = document.querySelector(container);
  // We'll internally keep track of the <select> element
  var selectElement = null;
  // We'll also need to keep track of the current selected value
  var currentlySelectedValue = null;

  return {
    // Method called at startup, to configure the Algolia settings
    getConfiguration: function getConfiguration() {
      // This is a copy-paste of the menu widget
      // We use a hierarchicalFacet and not a classical facet because we want to
      // keep the list of all possible values displayed at all times. With
      // a classical facet we would only have the list of possible values for
      // the current filters (which would not make any sense here)
      return {
        hierarchicalFacets: [{
          name: attributeName,
          attributes: [attributeName]
        }]
      };
    },

    // Called on the first instantsearch search
    init: function init(options) {
      var helper = options.helper;
      var tooltip = '';

      if($(container).attr('data-tooltip'))
      tooltip = getTemplate($(container).attr('data-tooltip'));
      // We add an (empty) <select> to the specified container
      container.innerHTML = '<label for="'+attributeName+'-select">'+heading+tooltip+'</label><select id="'+attributeName+'-select"></select>';
      selectElement = container.querySelector('select');

      // We listen to the change event on that <select>
      selectElement.addEventListener('change', function() {
        // Finding the newly selected value
        var selectedIndex = selectElement.selectedIndex;
        var selectedValue = selectElement.options[selectedIndex].value;

        // If we select the first, default value, it's like we "unchecked" the
        // currently selected value
        if (selectedValue === '__EMPTY__') {
          selectedValue = currentlySelectedValue;
        }
        // We toggle on/off on the selected value
        helper.toggleRefinement(attributeName, selectedValue);
        // And we actually start the search (to force a re-render of results)
        helper.search();

        // We keep track of what the currently selected value is
        currentlySelectedValue = selectedValue;
      });

      $('#'+attributeName+'-select').selectpicker();

    },

    // Called whenever we receive new results from Algolia
    render: function render(options) {
      var results = options.results;
      // We get the list of possible values for this search and sort them in the
      // same order everytime (most popular first)
      var sortBy = ['name:asc'];
      var facetValues = results.getFacetValues(attributeName, {sortBy: sortBy}).data;
      var innerOptions = ['<option value="__EMPTY__">' + title + '</option>'];

      if(facetValues != null)
      {
	      $(container).show();
      // We only keep the X first elements, as defined on instanciation
      facetValues = facetValues.slice(0, limit);

      // Then we add that to the <select>
      facetValues.forEach(function(facetValue) {
        // We mark the current one as selected
        var selected = facetValue.isRefined ? 'selected="selected"' : '';
        innerOptions.push('<option value="' + facetValue.name + '" ' + selected + '>' + facetValue.name + '</option>');
      });

      // Update the rendering
      selectElement.innerHTML = innerOptions.join('\n');
      }
      else{
	    $(container).hide();
      }

       $('#'+attributeName+'-select').selectpicker('refresh')
    }
  }
};

I want to extend this widget to work as a numericRefinementList so I can use it's options.options parameter. I need to make  >= filters in a select element with a custom label per option, is this possible?
Besides numeric values I want this same functionality for alpha characters, so when a value is ‘V’ it should get values with V & W & X etc. Or do I have to convert the character to a number first if we can fix the numeric widget?

@Maaark To ease the understanding of your requirement, could you do a mockup <select> element in a jsFiddle showing what you to to accomplish and explain what are the refinements you would want to do for the options of your select? Thanks

Sure, is http://codepen.io/Maaark123/pen/EyvVbZ clear enough?
About my alpha char question, skip that for now, I will transform them to numbers so I can use the same widget.

@vvo Forgot to mention that we want to use the 'end' option as well. Updated my select example. http://codepen.io/Maaark123/pen/EyvVbZ

@Maaark You should use this widget: https://community.algolia.com/instantsearch.js/documentation/#numericselector

That isn't completely what we want.
We want to auto hide the options when there are no records matching the value.
And we want to work with start and stop values.
We want to have more control over the template, like the above code for the select widget.

@vvo So basically https://github.com/algolia/instantsearch.js/blob/master/src/widgets/numeric-refinement-list/numeric-refinement-list.js in a select element and auto hide of non existent options in the initial state.

@Maaark I am sorry I won't have time to code this widget, I think given your level of understanding of the library you could give a try at doing it.
You could start with a simple:
var widget = {
  init: function() {
    // define the options you need
  },
  render: function() {
    // empty the select and update the options accordingly
  }
}

There's one thing though that will not be feasible I believe is that you will not be able to hide some options if they are not matching any record, because we do not compute that data in Algolia REST API.


adding StackFrameExtensions apis

@joperezr, @wtgodbe would you be the right reviewers for this class?
Internal review URL

This one in particular is not very well defined in terms of ownership that I'm aware of, but I can definitely help taking a look.

Left a couple of comments but looks good in general.

@mairaw Apologies for not responding earlier. When I was originally adding the APIs, I believe I copied the XML comments from the .NETStandard 2 docs; admittedly these were heavily geared towards CoreCLR execution model, thus all the mentions of JITted code.
It is true that on AOT runtimes (.NET Native, CoreRT) their semantics is slightly different - in particular, the "start of native module" corresponds to the load address of the AOT-compiled binary module containing the executing method and native IP offsets within methods correspond to the precompiled, not JITted, native code. Other than that, semantic differences should be minimal, at least I hope so.
As far as the documentation goes, it seems to me that it would be easiest to fix the bits mentioned by @jopererz (I have also spotted one) by minimum editation involving removal of the reference to JIT; we should typically end up with just a mention of a "native image" or "native module" as that is the common denominator of both JITted and AOT runtimes.
Thanks
Tomas

@mairaw, when you address the comments from @trylek, this will be ready to merge.

Thank you for your feedback @joperezr and @trylek. I believe I've addressed all your comments. Can you please take a look? (The PR looks a bit funky now because the content that was missing from MSDN was ported in bulk since I've created this).
Once it finishes building, you can see the built content here:
https://review.docs.microsoft.com/en-us/dotnet/api/system.diagnostics.stackframeextensions?branch=pr-en-us-3261
Apologies for the delay in addressing the feedback!

@joperezr @trylek does this look good now? Thanks!


Client Allocation Request for: Jingyi

Client Allocation Questions
Core Information

Name: Jingyi
Website / Social Media: https://www.jing-yi.com.cn/
Region: Greater China Region
DataCap Requested: 50TiB
Addresses to be Notarized: f1pj6n7u2e4opxgmovmsu4vyw6cimgds3razxeaxi
Notary Requested: 1475Notary

@Foster15 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Thanks for the request! Please answer the following questions giving as much detail as possible.

Please introduce yourself and the organization you represent, what is its name, nature, country of incorporation and date of establishment?
How many employees does the company currently have?
In which region do you plan to use DataCap?
How did you hear about the FIL+ project?
What kind of data do you plan to store? Can you share any kind of sample data?
Please provide the business license of your company.
Are you willing to store data outside of Greater China?

Thanks @1475Notary.

My name is Sam, working in the infomation vision of Jingyi. Our full company name is Jingyi Information Technology Co. It was founded in 2014 and has been engaged in high-end website design and production, network operation and promotion, HTML5 responsive website development, mobile website and app for 8 years.
Around 70.
Greater China.
From fellow technology business partner.
Most are images and videos. Maybe some code after we confirm the security of here.
We would like to send you in person.
Yes.

Thanks @1475Notary.

My name is Foster, working in the infomation vision of Jingyi. Our full company name is Jingyi Information Technology Co. It was founded in 2014 and has been engaged in high-end website design and production, network operation and promotion, HTML5 responsive website development, mobile website and app for 8 years.
Around 70.
Greater China.
From fellow technology business partner.
Most are images and videos. Maybe some code after we confirm the security of here.
We would like to send you in person.
Yes.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacec3dzcxygq7q4vdf2ujtorqkwecltj754y6qjyblkmbmkq32ebhx6

Address

f1pj6n7u2e4opxgmovmsu4vyw6cimgds3razxeaxi

Datacap Allocated

50.00TiB

Signer Address

f1ofq4mngy7ggcp755pfquq2gphjjnlydolf6awtq

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacec3dzcxygq7q4vdf2ujtorqkwecltj754y6qjyblkmbmkq32ebhx6


Expose module Cardano.Api.Script from cardano-api

I'm writing an indexer for the blockchain from script hash to script https://github.com/input-output-hk/plutus-apps/pull/629 and would like to use the conversion functions from ledger to cardano-api scripts in Cardano.Api.Script, would it be ok to export the module?

I would suggest to not expose this hidden module. Instead, add the function you want to export in the Cardano.Api module.

@eyeinsky fromShelleyBasedScript should be exported from Cardani.Api.Shelley

@Jimbo4350 done!

@Jimbo4350  Does this PR look good now? Here is the code we could get rid of and stop maintaining, if this is merged. :)

Closing this in favor of the new PR here https://github.com/input-output-hk/cardano-node/pull/4682


cant upload photo

using openfb image just cant be uploaded..
get
{"message":"This message contains content that has been blocked by our security systems.","type":"OAuthException","code":368}
now
if im using the fb sdk the same params work..
its just matter of login..
since i try login with fb sdk and then upload photos using openfb and it also worked
publishing posts work on openfb but only upload photo doesnt..i tried also adding method=post to qs..
url:
https://graph.facebook.com/v2.4/me/photos?method=post&url=http%3A%2F%2Ffbstatic-a.akamaihd.net%2Frsrc.php%2Fv2%2FyN%2Fr%2FrVqxq6UaFWH.png&access_token=[token]
login popup opened with url
https://www.facebook.com/login.php?skip_api_login=1&api_key=[key]&signed_next=1
&next=https%3A%2F%2Fwww.facebook.com%2Fv2.2%2Fdialog%2Foauth%3Fredirect_uri%3Dhttp%253A%252F%252Flocalhost%253A56628%252FBackOffice%252Fwww%252Foauthcallback.html%26display%3Dpopup%26scope%3Dpublic_profile%252Cpublish_actions%252Cemail%252Cuser_photos%26response_type%3Dtoken%26client_id%3D[key]%26ret%3Dlogin
&cancel_url=http%3A%2F%2Flocalhost%3A56628%2FBackOffice%2Fwww%2Foauthcallback.html%3Ferror%3Daccess_denied%26error_code%3D200%26error_description%3DPermissions%2Berror%26error_reason%3Duser_denied%23_%3D_
&display=popup

actualy upload photo works on cordova emulator.. so just browser isnt working.. i guess maybe something to do with the callback???

Hey @dev20152 , I'm actually having an issue uploading photos. I am continuously getting an error saying that I don't have a file to upload. Would you happen to have a copy of your implementation of the file upload?


bug

What version of Go are you using (1.22.1)?

$ go version
go version go1.22.1 linux/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/viarony/.cache/go-build'
GOENV='/home/viarony/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/viarony/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/viarony/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.1'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/viarony/Desktop/ascii-art-web-dockerize/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build228081878=/tmp/go-build -gno-record-gcc-switches'
uname -sr: Linux 6.8.0-40-generic
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.4 LTS
Release:	22.04
Codename:	jammy
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.35-0ubuntu3.8) stable release version 2.35.
gdb --version: GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1

What did you do?

What did you expect to see?
What did you see instead?

Related Issues and Documentation

Update funny #60279 (closed)
go bug #67882 (closed)
go version go1.21.5 linux/amd64 #67008 (closed)
s #48271 (closed)
go fix #51512 (closed)
go fix #42243 (closed)
. #66828 (closed)
some issues here ! #39105 (closed)
go bug  #34172 (closed)
rs_bug #44374 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


Add third column?

Details about an element of a analysis are shown on mouse over with ConceptDetails but this information can likely be overlooked. Maybe add a third column with readable notation and icons linking into Cocoda and K10plus.

As suggested by @stefandesu  the additional column could also be shown between analysis and label, e.g.
--0.904-------- T1--0901-0905 Zeitabschnitte

I would suggest using https://github.com/gbv/jskos-vue for this.

I don't like this -
1st: it's doubled ... mouseover & here
2nd: if really needed: caption first!  -> Zeitabschnitte (T1--0901-0905)
and what about the rules?

I think we can argue endless, it's a usability issue that can only be solved by feedback with actual users. Everything about rules is discussed in #22 so far.

if really needed: caption first! -> Zeitabschnitte (T1--0901-0905)

done, closing this.


Change "represent" to "present"

Hi @muhsinking, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Mo King). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


MINOR: Filter out quota configs for ConfigCommand using --bootstrap-server

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dajac @rondagostino @omkreddy Thanks for the review, merging to trunk, 2.6 and 2.5.


WIP First party self update implementation

@anfragment sure, no problem.

@AitakattaSora can we close this one?

@anfragment yes, sure


Add Compose#delete method

Add a simple #delete method:
compose = DockerCompose.load('docker-compose.yml')
compose.start
compose.stop
compose.delete

Other tiny fixes included in this PR:

Correct the Compose#kill documentation.
Compose#stop calls Container#stop instead of Container#kill.

Great improvement!
Thanks for contributing.
Merging...

@zuazo :
Gem version 1.0.3 was released.
It's already available in RubyGems.
Thanks for the support so far o/

@mauricioklein thanks!
It seems that inadvertently you have released the new gem with the old 1.0.2 code. The tag in GitHub is OK, but not the version uploaded to RubyGems:
diff -uNr ~/src/docker-compose-api/lib/docker-compose/models/compose_container.rb<EMAIL_ADDRESS>--- ~/src/docker-compose-api/lib/docker-compose/models/compose_container.rb     2015-12-28 14:59:11.896477068 +0100
+++<EMAIL_ADDRESS>  2015-12-28 16:23:50.775503014 +0100
@@ -15,7 +15,7 @@
       ports: prepare_ports(hash_attributes[:ports]),
       volumes: hash_attributes[:volumes],
       command: ComposeUtils.format_command(hash_attributes[:command]),
-      environment: prepare_environment(hash_attributes[:environment])
+      environment: hash_attributes[:environment]
     }.reject{ |key, value| value.nil? }

     # Docker client variables
@@ -101,8 +101,7 @@
     links = []

     @dependencies.each do |dependency|
-      link_name = @attributes[:links][dependency.attributes[:label]]
-      links << "#{dependency.stats['Id']}:#{link_name}"
+      links << "#{dependency.stats['Id']}:#{dependency.attributes[:label]}"
     end

     links
@@ -127,14 +126,6 @@
   end

   #
-  # Forces the environment structure to use the array format.
-  #
-  def prepare_environment(env_entries)
-    return env_entries unless env_entries.is_a?(Hash)
-    env_entries.to_a.map { |x| x.join('=') }
-  end
-
-  #
   # Check if a given image already exists in host
   #
   def image_exists(image_name)
@@ -165,7 +156,7 @@
   # Stop the container
   #
   def stop
-    @container.stop unless @container.nil?
+    @container.kill unless @container.nil?
   end

   #
@@ -204,11 +195,4 @@
   def running?
     @container.nil? ? false : self.stats['State']['Running']
   end
-
-  #
-  # Check if the container exists or not
-  #
-  def exist?
-<EMAIL_ADDRESS>-  end
 end
Binary files ~/src/docker-compose-api/lib/docker-compose/models/.compose_container.rb.swp and<EMAIL_ADDRESS>differ
diff -uNr ~/src/docker-compose-api/lib/docker-compose/models/compose.rb<EMAIL_ADDRESS>--- ~/src/docker-compose-api/lib/docker-compose/models/compose.rb       2015-12-28 14:59:11.896477068 +0100
+++<EMAIL_ADDRESS>   2015-12-28 16:23:50.775503014 +0100
@@ -58,27 +58,16 @@
   end

   #
-  # Kill a container
+  # Stop a container
   #
   # This method accepts an array of labels.
-  # If labels is informed, only those containers with label present in array will be killed.
-  # Otherwise, all containers are killed
+  # If labels is informed, only those containers with label present in array will be stopped.
+  # Otherwise, all containers are stopped
   #
   def kill(labels  = [])
     call_container_method(:kill, labels)
   end

-  #
-  # Delete a container
-  #
-  # This method accepts an array of labels.
-  # If labels is informed, only those containers with label present in array will be deleted.
-  # Otherwise, all containers are deleted
-  #
-  def delete(labels = [])
-    call_container_method(:delete, labels)
-  end
-
   private

   def call_container_method(method, labels = [])
diff -uNr ~/src/docker-compose-api/lib/docker-compose/utils/compose_utils.rb<EMAIL_ADDRESS>--- ~/src/docker-compose-api/lib/docker-compose/utils/compose_utils.rb  2015-12-28 14:59:11.896477068 +0100
+++<EMAIL_ADDRESS>16:23:50.775503014 +0100
@@ -62,8 +62,6 @@
   # Generate a pair key:hash with
   # format {service:label}
   #
-  # The label will be the conainer name if not specified.
-  #
   def self.format_links(links_array)
     links = {}

@@ -74,7 +72,7 @@

       case parts.length
         when 1
-          links[parts[0]] = parts[0]
+          links[parts[0]] = SecureRandom.hex

         when 2
           links[parts[0]] = parts[1]

Hello @zuazo !
Yes, it seems like that.
I've released a new version (1.0.4), with your PR's.
It's already available in RubyGems.
Thanks for the warning and sorry about the mistake.
PS: Please let me know if you face any other problem.

@mauricioklein thanks for your quick response!


Switch the testing framework to Kotest?

Currently kotlin.test is used for testing. Have you considered Kotest instead? Like Kotlin's test framework, it's built on JUnit on the JVM, but tests are written in a more idiomatic way. There's also an IntelliJ plugin that can display the tests being run in real time, rather than producing a report at the end.
Here's an example of one style it provides:
object ExampleTest : StringSpec({
    "Test string length should be 11" {
        test().shouldHaveLength(11)
    }
})

// ...

fun test() = "test string"

This is, in my opinion, way easier to read than:
class ExampleTest {
    @Test
    fun testStringLength() {
        assertEquals(
            test().length,
            11
        )
    }
}

// ...

fun test() = "test string"

Transitioning would take some effort, but I think it's worth considering. Thoughts?

@bishiboosh @petertrr what do you think about kotest?

Good idea, we can try it. But actually you should know, that several people in JetBrains do not like this framework :)

@akuleshov7 I would be interested to know why some people in Jetbrains do not like the framework? :)

I would be interested to know why some people in Jetbrains do not like the framework? :)

As do I. It's great

Unfortunately I am busy right now with the support for Custom deserialisers and Inline (VALUE) classes, so won't be able to make it in the nearest future... :(

Understandable :)

@bishiboosh @petertrr what do you think about kotest?

I haven't tried kotest myself just yet, but I've read about it. Indeed, API looks nice and more kotlin-idiomatic. I was a little bit concerned about multiplatform support and IDE support, though.
As they say in kotest docs, IDE support for multiplafrom is limited and tests can't be run from IDE directly (though, it usualy doesn't work with kotlin.test too :| ).
I think it's worth a shot, and their library for property-based testing can be useful for testing ktoml, where there are a lot of similar test scenarios for different input data.


refactor: Remove common_error::prelude

What type of enhancement is this?
Refactor
What does the enhancement do?
Remove prelude mod from common-error crate. Most re-exports in the prelude mod is seldom been used.
https://github.com/GreptimeTeam/greptimedb/blob/ed756288b3d30bd487961c26b72c54633ecfb0b3/src/common/error/src/lib.rs#L20-L30
Implementation challenges
Remove the prelude mod and replace usages of prelude by using items explicitly.
Before:
use common_error::prelude::*;

#[derive(Debug, Snafu)]
#[snafu(visibility(pub))]
pub enum Error {}

impl ErrorExt for Error {}

After:
use snafu::Snafu;
use common_error::ext::ErrorExt;

#[derive(Debug, Snafu)]
#[snafu(visibility(pub))]
pub enum Error {}

impl ErrorExt for Error {}

i want to have a try🤓

Thx


Crash with LagGoggles when using the spectator mode of Roots' Augment spell

General Information
Reproducing the issue report here  from the Divine Journey 2 repo
Describe the bug:

I selected the Augment Spell (which has the spectator augment) from my spell library and used it. I got into spectator mode, but when I exited spectator mode again, the game crashed and sent me back to the main menu. The screen informed me that Roots and LagGoggles were responsible for the crash. I rejoined the server and used the spell again. This time, I crashed immediately and the screen said that only Roots was responsible for the crash. After rejoining the server again, I was in spectator mode however. When the spell ended and I was set into survival mode again, the game crashed yet again saying that Roots and LagGoggles were responsible. From this point on, the game crashed every time I used the spell and when the spell ran out as described above.
To Reproduce:

Aquire a Roots Staff, aquire the Augment Spell and upgrade it with the Light Drifter Augment, aquire a Herb Pouch and put all the necessary herbs into it.
Use the Augment Spell in the Roots Staff
If it doesn't crash immediately, wait for the spectator timer to run out and observe the crash screen.

In my testing, I get the exit crash the first time I set the Augment spell to use Light Drifter and attempt to use it, and the following use upon reloading the world after the crash I get the enter crash.
Expected behavior:

The augment spell functions with the Light Drifter Augment, allowing you to enter/exit spectator mode without crashing.

Environment Versions

Mystic Mods Versions

MysticalLib: 1.13.0
MysticalWorld: 1.11.0
Roots: 3.1.5

Other Versions:

Conflicting mod (if regarding mod integration): LagGoggles 5.8-132
Other mods you think could cause issues:
Forge: <IP_ADDRESS>60
Minecraft: 1.12.2
Modpack (if available): Divine Journey 2 2.15.0

Logging Information
Please Use gist, paste.ee, pastebin or some other log sharing service
Crash Report (if available):

Exiting - crash-2022-07-27_16.39.43-client.txt
Entering - crash-2022-07-27_16.43.42-client.txt
Latest Log (if necessary):

Exiting - latest.log
Entering - latest.log

Additional Information
Screenshots (if available):

Additional context (optional):

This will be fixed in 3.1.6, please update when possible.


⚠ Avatar API Endpoint has degraded performance

In d983c50, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1773 ms

Resolved: Avatar API Endpoint performance has improved in 3e8f6f7 after 20 minutes.


Seperate ASP.NET Core from .Net Core

One of the very good ideas of .Net core, was separation of concerns at the very low level of the framework to be a modular/component framework.
but making ASP.NET Core integrated into .Net Core, did not adhere to the idea, and will make ASP.Net growth dependent on the .Net core growth, so there will not be a new version/fix for ASP.Net unless there is a new version of .Net Core, which will slow both.
And I did not see the EF 7 relation with .Net core, because if its the same as with ASP.Net core, then another non modular component is integrated into .Net core, and same issues apply.

It's already separate and modular. Can you be more specific?

I'm guessing the OP is referring to the release train. Yes all of the components are modular but with how things are today, fixes in one won't be seen until the whole release train is done. The only alternative is to get on nightly builds.

@smbecker, Thanks.
@davidfowl, Yes, I meant the release cycle.
As we understood that .Net Core is modular from the start, as if its Java 9, but years before it :).
So i thought that ASP.Net Core, and EF Core, will be separate nuget packages, that have different installation/releases than each other, so .Net Core is the main Package, and we can add to it EF or ASP.Net, or any new package like "XAML i hope very soon :)", but that doesn't look like that.
So when we install .Net core, we will have with it EF+ASP.NET weather we want or don't.
Which for me at least is not important, but the most important is the separation of the release, it would be very bad to couple their release too tight, that we can't see the new features of one of them, till all of them are ready to a new big release, and that was one of the very bad things of the behemoth .Net framework 1,2,3,4,.., and this is starting to have some of its bad properties.
I think that the release should be separated as you have almost done in Windows Server nano and the windows kernel.

So i thought that ASP.Net Core, and EF Core, will be separate nuget packages, that have different installation/releases than each other, so .Net Core is the main Package, and we can add to it EF or ASP.Net, or any new package like "XAML i hope very soon :)", but that doesn't look like that.

That's how it works now. ASP.NET and EF are separate nuget packages. What exactly are you talking about?

So when we install .Net core, we will have with it EF+ASP.NET weather we want or don't.

Are you talking about the project templates? The VS installer? Something else?

Which for me at least is not important, but the most important is the separation of the release, it would be very bad to couple their release too tight, that we can't see the new features of one of them, till all of them are ready to a new big release, and that was one of the very bad things of the behemoth .Net framework 1,2,3,4,.., and this is starting to have some of its bad properties.

Once we ship 1.0 I'm sure we'll move to a more independent release schedule.

@davidfowl, thanks for the clarification, then i misunderstood them.


Prevent halted VMs from causing diff on network and disk attachment attributes

This addresses #99.
Testing

[x] New test verifies new functionality
[ ] make testacc passes

[x] Fix issues with attach and disconnect vif and disk tests
[x] Fix race conditions for the TestAccXenorchestraDataSource_cloudConfig, TestAccXenorchestraDataSource_resourceSet, TestAccXenorchestraDataSource_user and TestAccXenorchestraDataSource_read tests

Most of the tests are passing, but the implementation seems to be causing failures for the existing attach and detach vif and disk VM tests.

TestAccXenorchestraVm_createWithShorterResourceTimeout seems to consistently fail, which seems to be a regression that exists in master. I'll open up a GitHub issue for this but it shouldn't block merging this change.


Web worker support

Hello!
I'm integrating the segment snippet through @segment/analytics-next package into a React app built with vitejs. It works perfectly when used from React code, but vite is not able to build the distribution files when analytics object is used in a web worker.
It's reporting this error "[vite:worker-import-meta-url] Invalid value "iife" for option "output.format" - UMD and IIFE output formats are not supported for code-splitting builds.". I don't understand 100% the message, but I guess is related with the way the analytics-next package is distributed.
We are using a wrapper to use the package, that is pretty simpler:
import { AnalyticsBrowser, EventProperties } from "@segment/analytics-next";

class Segment {
  private client: AnalyticsBrowser;

  constructor(apiKey: string) {
    this.client = AnalyticsBrowser.load({ writeKey: apiKey });
    this.client.page();
  }

  identify(id: string, email: string) {
    this.client.identify(id, { email });
  }

  track(event: string, properties?: EventProperties) {
    this.client.track(event, properties);
  }

  resetConnection() {
    this.client.reset();
  }
}

export default Segment;

Does the package support web workers?

This package does not support web workers; it makes heavy fairly heavy use of APIs on the window object; it also loads third party scripts ("device mode").
If you don't use any device mode destinations, you can use:
https://segment.com/docs/api/public-api/
I haven't actually tested it, but the new (beta) of "@segment/analytics-node" should also hypothetically support web workers.

I whipped up a partytown.io example that should work with cloud mode integrations and some (but not all) device mode integrations. See: https://github.com/segmentio/analytics-next/pull/773/files#diff-892d1f241b23ff9fb5abb2d6315ecc7e822783c53610490e32792a01f77f7f02

Thanks @silesky.
We tried with @segmentio/analytics-node and it worked. Is that also a way?

Thanks @silesky.
We tried with @segmentio/analytics-node and it worked. Is that also a way?

Yep! Make sure to set "maxEventsInBatch" to 1.
As long as you don't need device mode destinations, @segment/analytics-node was meant to be usable in any JS runtime that supports fetch.


Incorrect amount converting USD -> VND

I'm missing a few decimal places when converting from US dollars to Vietnamese Dong.
irb(main):001:0> usd = Money.new(50, 'USD')
=> #<Money fractional:50 currency:USD>
irb(main):002:0> vnd = usd.exchange_to('VND')
=> #<Money fractional:10902 currency:VND>
irb(main):003:0> vnd.to_i
=> 10902

The google finance converter shows 50 USD = 1090250 VND
Could this be a bug?

My guess, Google is using a different size subunit than is used in physical transactions, much this this ticket: https://github.com/RubyMoney/google_currency/issues/38
Perhaps you can research and submit a similar patch.


Create Server endpoints (v2) returning the checkpoins data

Depends on #187

This item depends on:

AbsaOSS/atum-service#187
By Dependent Issues.

This item depends on:

AbsaOSS/atum-service#187
By Dependent Issues.


Implement module linking proposal

It has already been a part of wasm (component but not core) spec tests, however WASMI has not supported it yet while both wasmer and wasmtime support it
wondering if this has a priority, or ur welcome others' PRs

Do you have a use case for the Wasm component-model for wasmi?
So far nobody has requested this feature. My employer (Parity Technologies) is not in need of this so it is rather low priority although we still want to implement all of the stabilized Wasm proposals in wasmi eventually to stay complete and up to date.
Another reason why I have not yet thought about implementing the Wasm module-linking is that I thought it was superseeded by Wasm component-model and wanted to wait for dust to settle and things to stabilize.

Do you have a use case for the Wasm module-linking for wasmi?

exactly, for example pallet contract, we can separate the dlmalloc-rs and ink logic to shared libraries to trim the size of contracts

I spoke with the rest of the smart contracts team at Parity and we came to the conclusion that indeed this Wasm proposal might be useful to us as well for delegate calling libraries.
That said the priority of implementing the Wasm module-linking proposal is still not high for us. Reasons are that there are more pressing things to be done, especially with the upcoming wasmi audit in August, the register-machine engine implementation and the planned lazy compilation strategy to significantly improve execution and startup times.
However, with the conclusion that this feature indeed is useful we might consider implementing it with medium-priority (instead of low-priority) even though it is unstable and so far we refrained from implementing unstable Wasm proposals at all.
What the @gear-tech team could do until then is as follows:

Fork wasmi and implement Wasm module-linking there with the chance of upstreaming it into mainline wasmi.
Try to find a work around that does not utilize Wasm module-linking proposal by providing tooling support (Due to missing knowledge about the big picture of the Wasm module-linking proposal I am uncertain if this is feasible.)
Wait for me (or another wasmi contributor) to do the job. 🙃

We're using Substrate at Entropy but had to rule out wasmi for our off-chain application environment because it's missing support for the components model (WIT stuff). We're using wasmtime currently, but would strongly consider wasmi, especially since it's audited.
Also, yes, module linking proposal has been superseded by the component model proposal, and that would be the proper implementation.

We're using Substrate at Entropy but had to rule out wasmi for our off-chain application environment because it's missing support for the components model (WIT stuff). We're using wasmtime currently, but would strongly consider wasmi, especially since it's audited.
Also, yes, module linking proposal has been superseded by the component model proposal, and that would be the proper implementation.

If you are primarily missing "WIT stuff" I would like to copy'n'paste this link for you again since it might be of interest to you until wasmi properly implements the Wasm module-linking proposal: https://github.com/paritytech/wasmi/discussions/703

I just renamed this to be about adding Wasm component-model support since module-linking has been superseeded by it.

Closed in favor of https://github.com/paritytech/wasmi/issues/897 since Wasm module-linking got deprecated and was superseeded by the newer Wasm component-model proposal.


change utcnow() to now(timezone.utc)

Fixes #2572

FYI: You can run ruff format . to reformat the long lines

@Mansur908 if you have any suggestions on how our developer docs could be better to improve this "first PR flow", please comment in #2578

Interesting, this leads to more code issues (serialization and deserialization), I believe:

datetime.strptime() returns naive datetimes (at least for the input we give it): these will then not be compatible with non-naive datetime.now() results...
serializing utc datetimes fails as our code expires.isoformat() + "Z" produces gibberish now...

I can have a look at this later but if you want to continue investigating:

strptime() is used in tuf/api/_payload.py and  tests/generated_data/generate_md.py
isoformat() is used in tuf/api/_payload.py

You seem to be allowing changes to your branch (thanks) so I'll push some code fixes on top: they should get this into a ready state

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 15 (86.67%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 97.544%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tuf/api/_payload.py
6
8
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
1466

Relevant Lines:
1493

💛  - Coveralls

It's a bit of a scary change (with the serialization code tweaks) but I feel pretty good about our test suite... so let's go with this. Thanks @Mansur908


awscli dependency for the docker image has been removed

AWS cli was removed in this commit https://github.com/opendatacube/odc-stats/commit/db360b0ff0c01bcbf9fc43876491cb030b1a8926

sorry that wasn't the right package. If you need awscli for debug purpose, it can be downloaded from aws.


README.md in the specified folder [MISSING]

README.md in the following folder

Click here

i Can work on this issue..could u please assign me..


RDK-35488:Issues in CMF-RPi Dunfell Builds when rdkshell in surfacemode

From: kchinn681<EMAIL_ADDRESS>Subject: issues in CMF-RPi Dunfell Builds when "RDKSHELL_COMPOSITOR_TYPE" is set to "surface"
Reason for change: to handle multiple rendering in surface mode
Test Procedure: to launch cnn app , run any video and see cnn app is exiting
Risks: Low
Signed-off-by: kathiravan chinnadurai<EMAIL_ADDRESS>Source: COMCAST
License: GPLV2
Upstream-Status: Pending

https://jenkins.code.rdkcentral.com/job/github-triggered/14040/ started

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/8911/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-rdk-next-platform/19489/ started.

https://jenkins.code.rdkcentral.com/job/build-component-rdk-next/47689/ started.

build-brcm-refboard Console Log uploaded to Gist URL: https://gist.github.com/c24f6658a1525d4ba902b4872c128975

build-rpi-mc-wpe-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/4f6054ad1b3512349d88d95d508339a5

build-rpi-hybrid-refapp2-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/bdb72f586a24c90b99252cc0c8f0240b

build-rpi-hybrid-wpe-rdk-next Console Log uploaded to Gist URL: https://gist.github.com/597a83288de5273ad4e48ae1d7882482


[recipes] move resources from default into configure recipe

to @yyuu
resolves #110 (additional context in the issue)
Changes

Split the resources defined in td-agent::default into their own recipe (this retains the previous behavior as well)
Update unit tests
Bump minor version

Testing

Locally with unit tests
Locally with Kitchen

@yyuu done! thanks for the review


fixed KeyValueLogger interface

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 2 (50.0%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 92.514%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

nillogger.go
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

logrotate/channelwriter.go
2
96.77%

packagelogger.go
2
98.11%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
655

Relevant Lines:
708

💛  - Coveralls


GO:0050405, EC number linked to this term has been transferred

The EC number (EC <IP_ADDRESS>) linked to this term has been transferred (and included) in EC <IP_ADDRESS>. The change will become public in release 2024_01 scheduled for January 17 2024.

Done as part of https://github.com/geneontology/go-ontology/issues/27410


Populate should allow empty relationship field

Steps to reproduce
The issue I am having is I have a model called Tags, which has a field called parent which references a tag item. But there will be tags which either have no parent field or the parent field is empty. Currently this throws an error.
{
  "name": "BadRequest",
  "message": "ParentField parent for category depth 1 is undefined. (populate)",
  "code": 400,
  "className": "bad-request",
  "errors": {}
}

Expected behavior
Should populate the items which have the related field.
Actual behavior
Throws an error as above.
System configuration
Module versions:
<EMAIL_ADDRESS>A fix
For now after chatting with eddystop on slack, he suggested that I populate the field with a null value before the populate hook is run, in the after hook event.
Could this be built into the populate hook to do itself?

I am not sure what impact this may have on other databases but within the populate.js if this is removed then this allows the items to be populated.
      if (parentVal === undefined) {
        throw new errors.BadRequest(
          `ParentField ${childSchema.parentField} for ${nameAs} depth ${depth} is undefined. (populate)`
        );
      }

With Mongoose the query runs fine and the ones which do not contain the field that is being referenced are still returned just without the relationship, which is exactly what I am looking for, and the behaviour I would expect.

Agreed, I'm also running into this where the field we want to populate on may or may not exist. @Mattchewone the behavior you described above is exactly how I would expect this to work and we're using MongoDB as well.
@eddyystop any thoughts on whether removing that check will cause issues with other DBs?

This change already has a scheduled tag.
The only issue I see is developers not finding the array of items they thought should be joined and taking to Slack or Stackoverflow.

Making the value null if missing works and prevents errors but does have some strange results as it returns an empty array even with asArray = false

I have a solution but it's not very elegant
exports.after = {
	all: [
		hooks.remove('_id'),

		// This is an ugly fix to allow to populate an field that maybe doesn't exists
		hook => {
			const results = hook.result.data

			if (results) {
				for (const result of results)
					if (result.to === undefined)
						result.to = null
			}
			else
				if (hook.result.to === undefined)
					hook.result.to = null
		},

		hooks.populate({
			schema: {
				include: [
					{
						service: 'users',
						nameAs: 'from',
						parentField: 'from',
						childField: '_id',
						query: {
							$select: ['_id', 'name'],
						},
					},
					{
						service: 'users',
						nameAs: 'to',
						parentField: 'to',
						childField: '_id',
						query: {
							$select: ['_id', 'name'],
						},
					},
				],
			},
		}),
	],
}

A proper fix is included in https://github.com/feathersjs/feathers-hooks-common/pull/170 . It will be published as v3.2.1.


fix(icons): fixed corner in map-pinned icon

What is the purpose of this pull request?

[x] Other: Icon update

Description
Fixed corner.
Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Still not perfect, but better than before

I think #2301 supersedes this by also arcifying the pin shape itself.


Redshift: remove structured event fields from atomic.events

Closing as Avro support will need its own RFC.


Missing localization files

Category
[x] Enhancement
[x] Bug
[ ] Question
Expected / Desired Behavior / Question
The FilePicker control doesn't work in many languages due to missing localization keys.
Observed Behavior
Exception is thrown due to undefined localization key which content needs to be replaced.

Fixed.


Add Constable Badge

There are a few ways to do this:

Would be update the README.md file and updating the badge with a static badge via Shields.io

Send data to a REST API to generate a dynamic Shields.io

Send data and create a badge image via a REST API

One idea is to use Firebase Realtime Database to store JSON that is publicly available, but only writeable via Constable.
https://firebase.google.com/docs/database/rest/save-data
https://stackoverflow.com/questions/46153828/access-url-without-token-in-firebase-storage

Another option is simply writing the badge as an .svg file


Add Travis badge to README

Badges are nice because they give a quick look into the status of a project! This task is to add a Travis badge to the the README (maybe under the header?)
Here's a link to our Travis profile: https://travis-ci.org/rubyforgood/playtime/
Let us know if you have any questions!

Can i try it?

@ramyaa Definitely! Let me know if you have any questions.

Yay! My first PR! <3 Thank you!


How can I set python3 as default on WSL?

This bug-tracker is monitored by developers and other technical types.  We like detail!  So please use this form and tell us, concisely but precisely, what's up.  Please fill out ALL THE FIELDS!
If you have a feature request, please post to the UserVoice.  If you're reporting a BSOD, don't post here!  Instead, e-mail<EMAIL_ADDRESS>and if possible attach the minidump from "C:\Windows\minidump".

Your Windows build number:  (Type ver at a Windows Command Prompt)

What you're doing and what's happening:  (Copy&paste specific commands and their output, or include screen shots)

What's wrong / what should be happening instead:

Strace of the failing command, if applicable:  (If <cmd> is failing, then run strace -o strace.txt -ff <cmd>, and post the strace.txt output here)

See our contributing instructions for assistance.

@andargachewm - This looks like ubuntu issue, not WSL :).

How to change from default to alternative Python version on Debian Linux
How do I change my Python version in Ubuntu 14.04?
How to make 'python' program command execute Python 3?
How to set python 3 as default interpreter in Ubuntu 14.04 [duplicate]

Thanks for reporting the issue, but I agree with @sunjoong that this is more of an Ubuntu question.  Please let us know if you hit any WSL specific issues, and I'll close this out as a discussion.


bring back admin PDA, put ID card inside admin PDA

For round timer and base health analyzer for deeper health debugging

https://github.com/RMC-14/RMC-14/pull/3124


[Bug 1198766] tester

This lets trigger rule writers test the trigger rule against recent feedback.
r?

To review:

read through the code
run the tests (or let travis run them--either is fine)
suggest fixes for the mediocre js code

@mythmon Can you look through this sometime this week?

Travis doesn't like this :bomb:.

It was a network failure on setup. I kicked it off again.

^^^ Everything passed.

Oh, I forgot that adding comments to commits instead of the diff here makes things annoying. Sorry about that.

I'm totally fine with adding comments to the individual commits. The notifications go to a different email address (yay github!), but it's fine by me.

Yes. It's a link to seeing a single day on the front page dashboard.

^^^ That redoes the api endpoint to use serializers, addresses your code comments so far and cleans up the JS.

^^^ And that switches to Array.map. I think that covers everything.

^^^ Nixes some dead code. Less to review now!

Ok. I think this is good now. Well, not good, but as good as it is going to be. I don't see any glaring issues, and it looks better than when it started. It might be good to handle the error from the ajax call (where you already have a TODO), but I'm not sure what you would do. Maybe alert("It broke. Sorry.").
r+

^^^ Fixes the comment and the adds a mediocre error "handler".
I'll wait for Travis to ok this, then land it.
Thank you so much!

Yay Travis!

Side note: Fixing the bundles and static files is covered in another bug. Right now it's a big mess. :(


ARROW-17631: [Java] Propagate table/columns comments into Arrow Schema

Allow user to provide comment in Arrow Schema from  JdbcToArrowConfig . It will be very useful metadata in real life (medium to large scale project) for documentation and maintenance topics. Apache Spark code use "comment" key for such metadata, so this looks like reasonable default name for metadata in Arrow schema too

Hello @lidavidm
Is code ok after rework?

Hi, sorry, it seems there's still a lint error - looks like the newly added files need the license header at top, something like this https://github.com/apache/arrow/blob/8bf60b5deaa15a6e301221b57b419c9599e313b0/java/adapter/jdbc/src/test/resources/h2/test1_all_datatypes_h2.yml#L1-L10

I'll take a second look when I can but it may be a few days

The path can be added here: https://github.com/apache/arrow/blob/master/dev/release/rat_exclude_files.txt

json as exception already here


Native image support

If this feature gets strong feedback from the community, I will consider implementing it.

It would be really cool!

Please implement it would be cool

native-image is supported starting from version <IP_ADDRESS>!
Please refer to native-image example.

native-image is supported for all modules starting from version <IP_ADDRESS>!


FR: command to jump to next or prev note that can be given hotkeys

Now that I have "next/prev" working for a bunch of my notes, would love to be able to assign a hotkey to a command that automatically navigated to the next or previous. I recognize that other folks might have multiple hierarchies with different next/prev labels, so this might be complicated. I'd be happy with an option that allowed me to assign the correct hierarchy to the command, or just automatically assigned it to the topmost hierarchy.
Thanks for considering!

That's a great idea!
For now, I've added a command to Jump to first {Direction}. It works for up, down, next, and prev.
It just jumps to the first one it can find.
Can you please add another FR to add an option to specify which fields to filter by :)


TF_HudNotifyCustom not showing up notification when HUD minmode enabled

I am aware this is probably not the place where I should have issued this but stocksoup respiratory does not have a section for issues and the attribute attr_sapper_recharge_time which belongs to here uses TF_HudNotifyCustom, I noticed that that its notifications do not show up when the client does not have cl_hud_minmode convar value as 0, which I believe cannot be changed because basically that is how the game was supposed to do when it is on. So I figured I would query the client's convar to decide what to do.
public Action OnClientWeaponCanSwitchTo(int client, int weapon) {
	if (weapon != GetPlayerWeaponSlot(client, view_as<int>(1))
			|| g_flClientSapLockTime[client] < GetGameTime()) {
		return Plugin_Continue;
	}

	EmitGameSoundToClient(client, "Player.DenyWeaponSelection");

	QueryClientConVar(client, "cl_hud_minmode", ConVar_minmode);

	// Alternatively we can just allow the weapon switch but also prevent attack
	SetEntPropFloat(weapon, Prop_Data, "m_flNextPrimaryAttack", g_flClientSapLockTime[client]);
	return Plugin_Handled;
}

// Queries whether the client has cl_hud_minmode enabled or not
public void ConVar_minmode(QueryCookie cookie, int client, ConVarQueryResult result,char [] cvarName,char [] cvarValue){
	if(result == ConVarQuery_Okay)
	{
		PrintToServer("Got into it");
		if(StrEqual(cvarValue,"0",false))
		{
			TF_HudNotifyCustom(client, "obj_status_sapper", TF2_GetClientTeam(client),
			"Sapper is disabled for another %d seconds.",
			RoundToCeil(g_flClientSapLockTime[client] - GetGameTime()));
		}else{
			PrintToChat(client,"Sapper is disabled for another %d seconds.", RoundToCeil(g_flClientSapLockTime[client] - GetGameTime()));
		}
	}else{
		PrintToServer("Something went wrong with telling the client about cl_hud_minmode");
	}
}

I do this for my other plugins that use TF_HudNotifyCustom, and reason why not just put the QueryClientConVar in the include file is because if it is inside of a quickly repeating function like think then the chat can get spammy, which will require one to put a timer, but not in this case.

It'd probably be better to use Custom Status HUD in this particular case, if not hint text or keyhints.
TF_HudNotifyCustom was used since it was originally written for a weapon demonstration video.

Interesting, I didn't know that was a thing I will check it out.

If you'd like, you're welcome to fork the repository, create a branch, patch attr_sapper_recharge_time with the status HUD change (likely as a countdown timer like the MvM sapper), and I'd be happy to merge the changes in.
You may also consider using arthurdead's hudnotifyfix for this purpose.

If you'd like, you're welcome to fork the repository, create a branch, patch attr_sapper_recharge_time with the status HUD change (likely as a countdown timer / meter like the MvM sapper), and I'd be happy to merge the changes in.
You may also consider using arthurdead's hudnotifyfix for this purpose.

Nice found, I find using this would be optimal if it worked properly. I tried it on my end and it does not show anything but I still find it fascinating unified solution that I would embrace instead of implementing a check for every future plugin that will use the status HUD. I will try looking into it more.


Extractor exception

com.yash.youtube_extractor.exceptions.ExtractionException: org.mozilla.javascript.EvaluatorException: missing ] after element list (script#7151)

Sorry for the late reply! Can you provide the video id.?


Update openai-speech sample code

Using open ai streaming api to get response token by token instead of whole message.
Buffer the token, and send the buffer to TTS when sentence end detected.

This will help reduce the TTS first byte latency.

@eric-urban
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

@niuzheng168 - Thanks for the suggestion. I would prefer to keep the current structure for teaching / user education and consistency with other samples. Does that make sense?

#please-close


How to visualize the output of the model?

May you release the utils code for visualization purpose? To see the correctness of object and static segmentation.

See the new commit. The utils.py function save_colored_res is added. In nuscenes_test.py , it is called. You can add the function wherever you want. Also there are some changes in make_labels in nuscenes to incorporate visible area mask.


Point to correct keybinding in smoketest

Fixes Microsoft/vscode-docs/issues/1234
We'll remove the /scripts folder after the next release. These keybindings will live in /build/keybindings.
FYI @gregvanl

@octref Can this be merged already today?

Yeah go ahead. Just want to inform you.


Date format malfunction in server mode

Date format is incorrect.

OS is macOS Ventura 13.1

@qasamppa sorry for the delay, no time lately, busy checking it out.

@qasamppa ok, i found a bug on the code, but i can't replicate the 120 instead of the 12.
What is you timezone?


Nose is not compatible with Python version 3.10

I am using Python 3.10 and trying to run hyperon test. During make check I got the following error
Traceback (most recent call last):
  File "/home/hedra/SNET/hyperon-experimental/venv/bin/nosetests", line 8, in <module>
    sys.exit(run_exit())
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/core.py", line 118, in __init__
    unittest.TestProgram.__init__(
  File "/usr/lib/python3.10/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/core.py", line 179, in parseArgs
    self.createTests()
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/core.py", line 193, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames)
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/loader.py", line 481, in loadTestsFromNames
    return unittest.TestLoader.loadTestsFromNames(self, names, module)
  File "/usr/lib/python3.10/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python3.10/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/loader.py", line 431, in loadTestsFromName
    return self.loadTestsFromModule(
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/loader.py", line 359, in loadTestsFromModule
    return self.suiteClass(ContextList(tests, context=module))
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/suite.py", line 461, in __call__
    return self.makeSuite(tests, context, **kw)
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/suite.py", line 511, in makeSuite
    suite = self.suiteClass(
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/suite.py", line 189, in __init__
    super(ContextSuite, self).__init__(tests)
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/suite.py", line 57, in __init__
    super(LazySuite, self).__init__()
  File "/usr/lib/python3.10/unittest/suite.py", line 22, in __init__
    self._tests = []
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/suite.py", line 109, in _set_tests
    if isinstance(tests, collections.Callable) and not is_suite:
AttributeError: module 'collections' has no attribute 'Callable'

Its due to the incompatibility issue of Nose and as a work around, I replaced collections.Callable by collections.abc.Callable and it works for now, but I don't think that's the right solution.
Do I have to use previous Python versions to work with Hyperon?

I have multiple python versions in my system and CMake keeps getting the older one and was unable to find hyperonpy module. So I created a virtual environment with Python 3.10 and that's what I used to build hyperon.
The output of the above command
NOSETESTS_EXECUTABLE:FILEPATH=/home/hedra/SNET/hyperon-experimental/venv/bin/nosetests
PYTHON_EXECUTABLE:FILEPATH=/home/hedra/SNET/hyperon-experimental/venv/bin/python
//ADVANCED property for variable: PYTHON_EXECUTABLE
PYTHON_EXECUTABLE-ADVANCED:INTERNAL=1

Versions are definitely ok, and CMake finds tools right. I did't know nose is outdated and replaced by nose2. I found nice analysis of the issue here: https://github.com/nose-devs/nose/issues/1099.
I am not sure why python -m pip install -e ./python[dev] works to me and others but doesn't work in your environment but it seems that PyPi version of nose is broken and should be built from sources to be compatible with Python 3.10. I can suggest trying pip install -U nose --no-binary :all: to rebuild nose from source as mentioned here as a workaround. Please write back if it work or not.
As a long term solution it is probably better to migrate to pytest or nose2. @noskill do you have any preferences here?

Try this one, to force reinstall package:
pip install -U --force-reinstall  nose --no-binary :all:

The force reinstall fixes the collections error. But got another error with the print statement
    from nose import main
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/__init__.py", line 1, in <module>
    from nose.core import collector, main, run, run_exit, runmodule
  File "/home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/nose/core.py", line 153
    print "%s version %s" % (os.path.basename(sys.argv[0]), __version__)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(...)?

Looks like it generated a module for a Python 2. Do you have pip installed in your environment? What does pip --version show?

Yes, it is 21.3.1

To me pip also prints a Python version:
$ pip --version
pip 20.0.2 from /home/vital/miniconda3/lib/python3.8/site-packages/pip (python 3.8)

I only send the version sorry,
pip 21.3.1 from /home/hedra/SNET/hyperon-experimental/venv/lib/python3.10/site-packages/pip (python 3.10)

Ok, it looks strange: your environment seems to be consistent but somehow it generates Python 2 code during installation of the nose module.

I am not sure how pip works here. Guys in nose issue thread mentioned that nose for a Python 3 is converted from Python 2 code. Looks like in your case this doesn't work. Could you please execute: pip install -v -U --force-reinstall  nose --no-binary :all: 2>&1 | tee /tmp/pip.log and attach the /tmp/pip.log file to the issue.

pip.log

Ok, log shows that nose is definitely installed as a Python 2 app. Python tries to compile it but cannot because of compatibility errors. As a last hope please try:
pip uninstall -y nose
pip install nose-py3

May be it will help.

It works. Thanks!
My nosetest version is now 1.4.

Unfortunately nose-py3 has an issue itself: https://github.com/atsb/nose-py3/issues/1#issue-1267095617 so I cannot recommend this workaround as a general solution.

Looks like it works when Nosetests is installed using a system package manager or using environment like Anaconda which also install packages from own repo not from PyPi.


Installation script for Windows

Just looking through the existing install shell script and noting these lines:
#elif [[ "$OSTYPE" == "win32" ]]; then
#        # I'm not sure this can happen.

I haven't been on Windows in a long time, but I know they do support Ubuntu shell now.  I'm just not sure how well the integration fits together, so you're probably right in the assumption what we wouldn't get that $OSTYPE.
What I'm thinking is that it might be best if a PowerShell script (.ps1) was provided for installing the CLI on Windows.  But, that would mean the Travis build would need to output a Windows executable.
I know you're already working on builds for other operating systems, so no rush to get an .exe built.  Just letting you know I'm happy to write the .ps1 file when the time comes.

Thanks! Would be really cool to see a powershell script for windows.
For now cloudstate-cli relies heavily on native system and docker tools, kubernetes, etc. to work properly, so a Windows version is a bit more complicated than Unix like versions. However, we need to add support for Windows as soon as possible.


PR: bulk compliance search action improve

disclaimer read-key instead of 3 seconds
add recoverable items size check before proceeding with deletion

Close #217


Splash page - page not read on iOS by 2-finger swipe up (build 58)

On splash page with VoiceOver on, when the user does 2-finger up to read all top to bottom, nothing happens. The focus stays on the main image. Swiping right does go to English and French buttons.
iOS 13.5.1 on iPhone 7

Adding Alt text for Canada watermark


linux/common-config: set idle timeout to 10s for sound cards

Description of changes
As per https://docs.kernel.org/sound/designs/powersave.html
We update our defaults for better power saving on laptops which does not perform powertop --auto-tune, TLP or manual tweaking, e.g. power-profiles-daemon.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Unrelated to sound, but for better power saving by default we might want to enable CONFIG_BT_HCIBTUSB_AUTOSUSPEND in the future as well.

This change causes a cracking sound on playback after the timeout. See the relevant information.

Devices that have this issue should have a quirk in the kernel to not suspend them.


Set Travis to fail if Hugo build fails

(Including test)

Travis Job fails on Hugo Error

HTMLTest error allows Travis Job to complete (and deploy if is on a publication branch)


Bump jsonrpsee version

Closes #4
Bumps jsonrpsee version to 0.22.5, however I did notice the dependency is not being used anywhere. It can be removed if requested.
Codebase got formatted on save, no changes other than an outdated jsonrpsee import

Is the jsonrpsee crate even being used here? I don't see any changes related to it aside from the version change. If you remove jsonrpsee, does the crate still compile?

Is the jsonrpsee crate even being used here? I don't see any changes related to it aside from the version change. If you remove jsonrpsee, does the crate still compile?

Yes it still compiles without it, mentioned in description. I can just remove it 👍


Traffic filters in 0.6.0: "provider produced inconsistent result after apply"

Readiness Checklist

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior
Planning of an ec_deployment with associated ec_deployment_traffic_filter_associations should be idempotent: after applying once no changes should remain in the plan, and subsequent applys should succeed regardless.
Current Behavior
A cluster with associated traffic filters has successfully been configured/applied, but a subsequent plan aims to remove the traffic filters. On applying this plan, the following error occurs (specifics have been replaced with pseudocode in angle brackets):
Error: Provider produced inconsistent result after apply

When applying changes to <ec_deployment resource>, provider "provider[\"registry.terraform.io/elastic/ec\"]" produced an unexpected new value: .traffic_filter: was null, but now cty.SetVal([]cty.Value{cty.StringVal("<filter id 1>"), cty.StringVal("<filter id 2>")}).

This is a bug in the provider, which should be reported in the provider's own issue tracker.

We are also seeing spurious config changes to the elasticsearch block in the deployment resource, but I think this is already being tracked in other issues on this repo.
Terraform resources
resource "ec_deployment" "cluster" {
  // name, alias etc config omitted for brevity
  elasticsearch = {
    autoscale = "false"
    hot = {
      size        = "1g"
      zone_count  = 1
      autoscaling = {}
    }
  }
}

resource "ec_deployment_traffic_filter_association" "cluster" {
  for_each = var.network_config.ec_traffic_filters // set of filter ids

  deployment_id     = ec_deployment.cluster.id
  traffic_filter_id = each.value
}

Steps to Reproduce

Apply a plan with ec_deployment_traffic_filter_associations
Plan again - see that filters are to be removed
Apply again - see error above.

Your Environment
Using the 0.6.0 provider

Related to https://github.com/elastic/terraform-provider-ec/issues/419

This got released with 0.8.0 yesterday.


[EXI] potential uncovered path in switch statements might lead to bugs

All switch cases in exi_program.c#L44 must contain a default case that returns error to cover wrong inputs. not adding this could lead to bugs / unknown behavior when the module is used by some other drivers, as It won't return anything in that case (wrong inputs)

There is one big if statement checks the input parameters, avoiding any wrong inputs.
From: Hossam @.>
Sent: Thursday, April 13, 2023 01:44 AM
To: @.>
Cc: Abdelrhman @.>; @.>
Subject: [AbdelrhmanWalaa/Moving-Car-Project] [EXI] potential uncovered path in switch statements might lead to bugs (Issue #1)
All switch cases in exi_program.c#L44https://github.com/AbdelrhmanWalaa/Moving-Car-Project/blob/ae7c51ad524108c32b1c776d09c9e061e557bf8d/Moving Car/MCAL/exi/exi_program.c#L44 must contain a default case that returns error to cover wrong inputs. not adding this could lead to bugs / unknown behavior when the module is used by some other drivers, as It won't return anything in that case (wrong inputs)
—
Reply to this email directly, view it on GitHubhttps://github.com/AbdelrhmanWalaa/Moving-Car-Project/issues/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKTDFLVBOFDLWNYXUTUDLMLXA4463ANCNFSM6AAAAAAW4KV6DE.
You are receiving this because you were assigned.Message ID: @.***>

@AbdelrhmanWalaa That's right, my bad thanks for clarifying 💯 , closing this issue.


Low Performance +10k Markers

Anyone tried loading more than 10k markers?
The whole map behaviour is clumsy and/or crashes. Initially I tought it was due to load time (6mb geojson), but after reduzing size to its tenth by gzip compressing im still experiencing clumsy behaviour.
Is it possible that the sidebar is responsible for the browser to crash when loading tons of markers? Often markers are visibly loaded and just as I move the map somewhere else, sidebar starts doing the sync. So I though it might be useful getting rid of the sidebar for testing.
Any insights?

You are definitely likely to run into performance issues trying to display that many features client-side! Marker clustering helps with the map, but loading that many DOM items in the sidebar is likely going to crash the browser. You may be better off trying to implement some server-side solution and somehow limiting the sidebar items.


[Suggestion] Regulaters

There should be a block that takes in gases, liquids, and power, then regulates how much goes out.  This would be useful to control how much power is going where or how much water is going where etc. It would be like the power relay in RF Tools, but it can work with more than just power.

Complementing... Another good modification on game is about thermoeletric boiler... with 5 superheating he is producting only 10mb of Steam..

So this would be advanced version of my suggestion #3256 [Suggestion] Valves and switches - except for the "Has only two states: on/open (green light) and off/closed (red light)" aspect.

Basically, yes. There could actualy be two versions. A basic version could limit one pipe, it would look like what you suggested. Then an advanced version could be a complete block, and it could limit more than 1 pipe.

I'm going to go ahead and merge this with #3256.  There's a few things that I'm planning on for the future:

Removing redstone sensitivity in transmitters, adding in some kind of "transmitter switch" to function as @EzerArch suggested
Colored transmitters in all types, not just item transport
"Transmission Mediator" block to configure input and output values for all transmission types on a side-by-side basis, as this issue suggested