Getting an exception

Django Version:	1.8.15
Exception Type:	TypeError
Exception Value:
init() got an unexpected keyword argument 'safe'
Exception Location:	/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/pymongo/collection.py in update, line 2241
Python Executable:	/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
Python Version:	2.7.6
Pymongo 3.3.0
mongoengine 0.10.6

commenting out line 85:
safe=safe,

fixed it for me.


Add PoleReluSystem.

The system approximates the dynamics of pole/end-effector system using ReLU networks

This change is

neural_network_lyapunov/examples/pole/pole_relu_system.py, line 17 at r1 (raw file):

    [ẋ_A[n+1] ẏ_A[n+1] ż_A[n+1] ẋ_AB[n+1] ẏ_AB[n+1]] =
    [ẋ_A[n] ẏ_A[n] ż_A[n] ẋ_AB[n] ẏ_AB[n]] +
    ϕ(x_AB[n], y_AB[n], ẋ_AB[n], ẏ_AB[n], u[n]) -

\phi is absorbing dt. Therefore, we have to train \phi for different dt.

neural_network_lyapunov/examples/pole/pole_relu_system.py, line 133 at r1 (raw file):

                               self.u_equilibrium))),
            sense=gurobipy.GRB.EQUAL,
            name="quadrotor_dynamics_output")

pole_dynamics_output

neural_network_lyapunov/examples/pole/pole_relu_system.py, line 17 at r1 (raw file):
Previously, hongkai-dai (Hongkai Dai) wrote…
Right and that is by intention. I think you are suggesting to represent the continuous dynamics xdot = f(x, u) using a network phi. But what we want is the discrete dynamics x[n+1]. If we use first-order explicit Euler integration as x[n+1] = x[n] + xdot[n] * dt then it is true we only need to learn xdot = f(x, u), and then multiplies dt. But first order explicit Euler integration has very bad accuracy, so it is more proper to use higher order integrations. Then it is not sufficient to just learn xdot = f(x, u), but to learn the discrete dynamics x[n+1] = F(x[n], u[n]) directly, which handles the time integration inside the dynamics update F(x[n], u[n]).

Is there advantage of learning residual dynamics over the entire forward dynamics?

neural_network_lyapunov/examples/pole/test/test_pole_relu_system.py, line 54 at r1 (raw file):

            x_next_i = dut.step_forward(x_samples[i], u_samples[i])
            np.testing.assert_allclose(x_next[i].detach().numpy(),
                                       x_next_i.detach().numpy())

I'm not quite seeing the purpose of checking that they are the same. It seems they are going through the same function with one in batch and another with single data point.


Different results with cli and maven starter

I have two different outputs when Im use the cli version and the maven version
cli
If i start the dependency check with:
.\dependency-check-1.2.8-release\bin\dependency-check.bat --app testProject --scan .\TestProject --out .\testproject-report\cmd
I get the following result (Showing All Dependencies) :

Dependency
CPE
GAV
Highest Severity
CVE Count
CPE Confidence
Evidence Count

test-project-1.0-SNAPSHOT.war

test-project:test-project:1.0-SNAPSHOT

0

3

test-project-1.0-SNAPSHOT.war: axis-1.2.jar
cpe:/a:apache:axis:1.2
axis:axis:1.2
Medium
2
HIGHEST
7

test-project-1.0-SNAPSHOT.war: commons-logging-1.1.1.jar

commons-logging:commons-logging:1.1.1

0

19

test-project-1.0-SNAPSHOT.war: spring-core-3.2.0.RELEASE.jar

org.springframework:spring-core:3.2.0.RELEASE

0

6

maven
and if i start it with maven Showing All Dependencies:
mvn --version
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00)
Maven home: C:\Users\a.kiyak\ws\apache-maven-3.2.5\bin..
Java version: 1.8.0_31, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_31\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 8", version: "6.2", arch: "amd64", family: "dos"
mvn clean package

Dependency
CPE
GAV
Highest Severity
CVE Count
CPE Confidence
Evidence Count

axis-1.2.jar
cpe:/a:apache:axis:1.2
axis:axis:1.2
Medium
2
HIGHEST
10

commons-logging-1.1.1.jar

commons-logging:commons-logging:1.1.1

0

19

spring-core-3.2.0.RELEASE.jar
cpe:/a:springsource:spring_framework:3.2.0
org.springframework:spring-core:3.2.0.RELEASE
Medium
5
HIGHEST
15

Result
As you can see, I get CVEs for spring-core-3.2.0.RELEASE.jar when maven is used.
My pom.xml
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>test-project</groupId>
    <artifactId>test-project</artifactId>
    <packaging>war</packaging>
    <version>1.0-SNAPSHOT</version>
    <properties>
        <spring.version>3.2.0.RELEASE</spring.version>
    </properties>
    <dependencies>
        <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-core</artifactId>
            <version>3.2.0.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>axis</groupId>
            <artifactId>axis</artifactId>
            <version>1.2</version>
        </dependency>

    </dependencies>
    <build>
        <plugins>
            <plugin>
                <groupId>org.owasp</groupId>
                <artifactId>dependency-check-maven</artifactId>
                <version>1.2.8</version>
				<configuration>
				    <logFile>target/dependency-check-log.txt</logFile>
				</configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>check</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </build>

</project>

Thanks for the bug report. I am working on a patch now.

This issue has been resolved by modifying the Central Analyzer to download the POM file for the given JAR file if it exists in Central and was not found previously by the JAR Analyzer. The issue with the given resolution is that offline use of the CLI may have less accurate results.  Warnings will be added to the documentation.
This issue is resolved in 1.2.9-SNAPSHOT and will be included in a full release soon.


Error

So I installed node and npm.
Then I installed raspivid and fs through npm.
When I run the example I get the following error:

child_process.js:921
throw new TypeError('Incorrect value for stdio stream: ' + stdio);
^
TypeError: Incorrect value for stdio stream: inherit
at child_process.js:921:13
at Array.reduce (native)
at ChildProcess.spawn (child_process.js:876:17)
at Object.exports.spawn (child_process.js:735:9)
at module.exports (/home/pi/CAM/node_modules/raspivid/index.js:22:29)
at Object. (/home/pi/CAM/video.js:3:13)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)

Any thoughts? Camera is working with both raspivid and motion.

@cmegens interesting - inherit seems to be a bad value for the stream
this page mentions node 0.12 - which version are you running?


Fix: fixed the missing Avatar image (#192)

Issue Title: Avatar is missing.
resolve issue: #192
Type of change ☑
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

How Has This Been Tested? ⚙

These changes has been tested on my local system in browsers such as Chrome and Firefox.

Screenshots :

Before changes :

After changes :

@Shubham-1068 You have only modified the package.json files, & the issue is still there in the deployed version of your commit.

check #281 it will solve the issue

@Shubham-1068 Any updates?


Wrong vote up / down tally

Hi,
It looks like the tally of the vote up/down button is not adding correctly.
You may be able to reproduce this by voting up, having a second person vote up from another IP address and then voting down. The tally should be +1 +1 -1 = +1 but it the widget displays 0 instead

Hi @dbd5,
When you're voting up/down right after you have voted (down/up), your value is actually changed.
The default time limit for guests is 1 hour (1 vote/hour per IP for the one vote item). After this time, new votes will be added (+1 or -1) and not replaced/changed.

Ok, thanks
Will review again


[22.05] xivlauncher: <IP_ADDRESS> -> 1.0.2

Description of changes

backport of #197431; this is a networked game, so it's important that backports of the launcher get done ("Services which require a client to be up-to-date regardless. (E.g. spotify, steam, or discord)")
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

22.05 is now deprecated and this still hasn't been merged so I'm closing this.


add ignore repeats

https://github.com/google/project-gameface/issues/39#issuecomment-1783927041
We used to have throttle time. I think we need a general Setting (or should be it on each item?) to avoid double presses rapidly
It in effect ignores repeated presses if within a set time threshold. should be 0-3seconds

@alex5105 - have a think before implementing this.  I'm not sure whats best

okay, got it.
On Thu, Sep 26, 2024 at 2:43 AM will wade @.***> wrote:

@alex5105 https://github.com/alex5105 - have a think before
implementing this.  I'm not sure whats best
—
Reply to this email directly, view it on GitHub
https://github.com/AceCentre/FaceCommander/issues/58#issuecomment-2375986491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASIH2DFKR422QB3UPFAB5ZDZYONG7AVCNFSM6AAAAABO2K4IMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZVHE4DMNBZGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


R2 - reports updated

PR is created to make final changes based on the feedback from the testing team and data providers.

Unrelated to this PR, but the workflow diagram for OCO-2 seems to be missing / broken link:

https://us-ghg-center.github.io/ghgc-docs/pr-preview/pr-83/data_workflow/oco2-mip-co2budget-yeargrid-v1_Data_Flow.html


re-org

Reorganized file strucuture for better maintainability moving foreward
need to look into cogs more.

Tested all, all features work!


google-api-python-client does not honor no_proxy environment variable

Environment details

OS: Ubuntu 18.04
Python version: 3.6.8
pip version: 19.1.1
google-api-python-client version: 1.7.9

Steps to reproduce
We have a squid proxy running; The squid is not able to talk to google apis/metadata server.
export no_proxy=metadata.google.internal,.googleapis.com
export http_proxy=http://squid:3128
export https_proxy=http://squid:3128

We expect the no_proxy env var is honored.
This is an issue with httplib2, we've already sent a PR to them here: https://github.com/httplib2/httplib2/pull/140

Hello. Sorry, the problem was caused by my bad code. Fix is merged in httplib2 master.

And now it's released as 0.13.1 on PyPI. Sorry for inconvenience.

@temoto Thank you for the quick fix!

Just to be clear: @MaT1g3R did all the work.

Thank you @MaT1g3R! :tada:


Introduce multi-thread writing to persistent store.

Upon looking more closely at supporting high availability / multiple write destinations, I'd like to experiment with pushing the multi-threaded approach down to the writer. Doing that will give us finer control. For example, we could use just 2 writing threads for a small influx db and 5 writing threads for a second, larger one.

How will you know the optimal number of threads? Are you planning to automatically measure it? I like things which are self-tuning :-)
BTW: is it number of threads or number of goroutines?


Question about auth middleware

Hey Jarrod, first of all, I wanted to say thank you for this amazing example. It covers a lot of important parts of a real application and I have been returning to it very often to learn how to resolve several issues.
However, I have doubts about why did you wrap the route with the wrap-authetication middleware, instead of defining it in the middlewares keyword like you did with the cors-mw. Here an example of what I am talking about:
    (wrap-authentication
     (DELETE* "/user/:id"  {:as request}
              :tags        ["User"]
              :path-params [id :- Long]
              :return      {:message String}
              :middlewares [cors-mw token-auth-mw]
              :summary     "Deletes the specified user. Requires token to have `admin` auth or self ID."
              :description "Authorization header expects the following format 'Token {token}'"
              (delete-user-response request id))
     token-backend)

Could be explained because you need to pass a parameter?
Also, in other cases, I saw that you repeated this along several routes instead of wrapping all of them through the context* macro, why is that?, can't it be done in that way?

Glad you are finding the project useful.
I have had reworking the middleware on my todo list for a while, but haven't made the time to do it.  I think that early on doing it that way was the path of least resistance and I never went back to refactor. I just pushed https://github.com/JarrodCTaylor/authenticated-compojure-api/commit/f81a5208d7c99371fa1ced62c9b86607fc4e9a6a  that refactors the handlers to  move the call to wrap-authentication inside the middlewares keyword. Thanks for pointing it out and motivating me to get it done.
I am unsure about your question related to the context* macro. As far as I know the context macro only provides a way of giving a common url prefix to a group of urls. https://github.com/weavejester/compojure/wiki/Nesting-routes so perhaps I misunderstanding what you are asking.

please keep up the good work. your work is helping me alot.

@JarrodCTaylor Glad you found motivation in my comment to keep working on this amazing tutorial!
Forget about my question about the context* macro, at that moment I wasn't aware of how it really works.
Anyway, thanks again for making this tutorial, which without doubts is one of the best tutorials available. Most of tutorials are focused in a specific part/module of an application and forget about code structure, testing, etc., but this one deals with all of that and more... it really resembles a real application.

Thanks for the kind words @yusup-a and @rcanepa.


valid json reported as invalid

The file below contains a valid json string. However, the boost json example program validate reports it is invalid, and the example program pretty reports caught exception: extra data.
valid_json_boost_json_issue.txt
Many small changes to the string makes it parse correctly, such as deleting an innocuous looking character from the string.
I've reproduced this on the tip of master (f47fbeb1a54b832221a35c17912febb7a2c3a317) with both clang and gcc.
Please let me know any additional information I can provide that would be helpful.

@bhendrickson It seems like we were forgetting to flush the buffer after parsing escape sequences, causing the parse to be incomplete.


The results of testing on the pre-trained model

Hello, we have tested using the pre-trained model provided in this paper, but the results seem to be incorrect. Where may there be a problem? We haven't changed the program code during this period. Thank you for your reply.

Hi, are you using Ditto_s2m.ckpt? Can you also provide the command you used to run this test?

Hi, thank you for pointing it out! I found I uploaded the wrong model. Now I updated the link for Ditto_s2m, and it should give performance close to the ones reported in the paper.

Hi, thank you very much for your reply. We have obtained the correct results through your latest pre-trained model. But when we test with our own training model, there seem to be some errors, such as cd_mobile. During the training, we changed the batch_size from 8 to 4 because of GPU. We are trying to find out the reason, but we also hope to get your help. Thank you very much.

Hmm, did you half the learning rate when changing the batch size?

Thank you very much for your reminder. I seem to know where the problem is!


No min-width on awardNumber in "Your Submissions", allows split words

If you resize the browser window on the Your Submissions page, it looks like most columns dont allow word breaks or have some min-width expect for the Award Number column.  This results in Award Number wrapping to a very narrow column and distorting the display.

verified in 7f2a26bd


Standardize error logging

Sometimes we are logging errors using a separate tag, like:
logger.Error("Something happened!", "err", err)

And sometimes we are using a format string, e.g.:
logger.Errorf("Something happened: %w", err)

I'd say the tag one seems better (my vote), and that's what we've been trying to follow, but either way we need to chose one standard and refactor the usages. Should be quick, just some manual work.

I prefer the tag one. Manually formatting strings is error prone (ex. why use %w here?)


Composite Type Support

Hey,
It will be great if we have native support for Composite Types in PHPCASSA. CQL also doesn't have a native support for Composite types.
Regards,
Tamil.s

I would like to vote for this feature also.

The composite type support is in branch composites branch now


Weird logs from doh-server

Hello,
Since latest release doh-server is making a lot of writings to syslog like below, despite verbose=false. Not very informative - at least for me. Can it be turned off?
Looks like number stations to me ;-)
Oct 28 08:15:08 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:15:17 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:15:23 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:15:38 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:15:53 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:00 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:08 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:10 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:24 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:39 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:16:54 warrior doh-server[24450]: [0 4 3 4]
Oct 28 08:17:09 warrior doh-server[24450]: [0 4 3 4]

Thank you for your report!
I am currently investigating the problem. Please stay tuned.

Would you please test commit 82317bd63ebe6386303700ef71152b5aff2b09ed?
I guess the logs are coming from that line of code.

It seems OK to me. Weird writes to syslog stoped now.
Thank you.
I really appreciate doh-server and doh-client...


markdown table

Hello,
I am using rss-to-readme to generate a table with all my blog posts. However markdown is not happy with comments in the middle of the generated table.
See this example to get a better picture: https://github.com/joaohf/beam_mignon/blob/master/README.md
Is there other way to create a table? Maybe we can add some sort of pre_template and post_template then the table header can be put in pre_template ?

Interesting! I think a (pre|post)_template input makes sense to me. PRs welcome, that'd go here:
https://github.com/JasonEtco/rss-to-readme/blob/9438455dc6d8c853d3eaf831939e3a13499bf9c1/src/index.ts#L25
We'd have to prepend and append the new strings there if they're present. We'd also have to update the docs and the action.yml file to document the new inputs!

Thanks @JasonEtco
I going to give a try and sending the PR.


updateImportsOnFileMove doesn't work after first use

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.90.0
OS Version: Darwin arm64 23.5.0

Steps to Reproduce:

Set "typescript.updateImportsOnFileMove.enabled": "always"
Create a project with the following tsconfig.json:

{
    "compilerOptions": {
        "paths": {
            "@/*": [
                "./src/*"
            ]
        },
    }
}

Create two .ts files inside a src/ directory (e.g. myModule.ts and myScript.ts), where one module exports some functionality (e.g. export default () => { return 'hello' }) and the other module imports it using the path configured in tsconfig.json (e.g. import myModule from '@/myModule')
Rename myModule.ts to myOtherModule.ts → in myScript.ts the import will be updated accordingly
Rename myOtherModule.ts to mySecondOtherModule.ts → ❌ in myScript.ts the import will not be updated again

The update import when renaming a file works fine only the first time, but it doesn't work when renaming the same file again. In order for it to work, I have to run Developer: Reload Window or restart VSCode - Restarting TS Server is not sufficient.
NOTE: When using relative imports (import myModule from './myModule') the rename works correctly even if repeated multiple times.

Experiencing same issue with:
Version: 1.90.1 (Universal)
Commit: 611f9bfce64f25108829dd295f54a6894e87339d
Date: 2024-06-11T21:02:41.372Z (5 days ago)
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin x64 22.6.0


TypeError: can't concat bytes to str

I am not sure how to reproduce, but I have enabled debug and this popped some time after:
:
2018-01-20 23:03:54,977 parso.python.diff diff parser start:
2018-01-20 23:03:54,978 parso.python.diff diff parser calculated:
2018-01-20 23:03:54,979 parso.python.diff diff: line_lengths old: 66, new: 66:
2018-01-20 23:03:54,979 parso.python.diff diff equal old[1:32] new[1:32]:
2018-01-20 23:03:54,980 parso.python.diff diff actually copy 1 to 7:
2018-01-20 23:03:55,013 parso.python.diff parse_part from 8 to 33 (to 33 in part parser):
2018-01-20 23:03:55,013 parso.python.diff diff replace old[33:33] new[33:33]:
2018-01-20 23:03:55,014 parso.python.diff diff equal old[34:66] new[34:66]:
2018-01-20 23:03:55,016 parso.python.diff parse_part from 34 to 34 (to 34 in part parser):
2018-01-20 23:03:55,017 parso.python.diff diff actually copy 35 to 65:
2018-01-20 23:03:55,018 parso.python.diff diff parser end:
2018-01-20 23:03:55,219 parso.cache pickle loaded: d:\user\dropbox\softwareversioning\pycodestyle\pycodestyle.py:
2018-01-20 23:03:55,289 pyls.config.config   finish pyls_hover --> [hook]:
Exception in thread Thread-112:
Traceback (most recent call last):
  File "./python3.3/threading.py", line 901, in _bootstrap_inner
  File "./python3.3/threading.py", line 858, in run
  File "F:\SublimeText\Data\Packages\LSP\plugin\core\rpc.py", line 164, in read_stderr
    server_log(decoded.strip())
  File "F:\SublimeText\Data\Packages\LSP\plugin\core\logging.py", line 18, in server_log
    printf(*args, prefix=binary)
  File "F:\SublimeText\Data\Packages\LSP\plugin\core\logging.py", line 23, in printf
    print(prefix + ":", *args)
TypeError: can't concat bytes to str

Perhaps use print(prefix + ":", str(*args)) so we can know what it was trying to print?

it happens with typescript-languageserver:
log:
LSP: starting ['typescript-language-server.cmd', '--stdio']
LSP:  --> initialize
LSP: window 2 added session typescript-language-server
Exception in thread Thread-5:
Traceback (most recent call last):
  File "./python3.3/threading.py", line 901, in _bootstrap_inner
  File "./python3.3/threading.py", line 858, in run
  File "C:\Users\Lehdhili\AppData\Roaming\Sublime Text 3\Packages\LSP\plugin\core\process.py", line 78, in log_stream
    server_log(decoded.strip())
  File "C:\Users\Lehdhili\AppData\Roaming\Sublime Text 3\Packages\LSP\plugin\core\logging.py", line 44, in server_log
    printf(*args, prefix=server_name)
  File "C:\Users\Lehdhili\AppData\Roaming\Sublime Text 3\Packages\LSP\plugin\core\logging.py", line 49, in printf
    print(prefix + ":", *args)
TypeError: can't concat bytes to str

@AmjadHD, can you wrap a try-catch around the print call with the same logging  as evandrocoan had? Is it a reliable repro?

I added this:
diff --git a/plugin/core/process.py b/plugin/core/process.py
index da0122c..c920d2f 100644
--- a/plugin/core/process.py
+++ b/plugin/core/process.py
@@ -72,8 +72,11 @@ def log_stream(process: 'subprocess.Popen', stream: 'IO[Any]') -> None:
                 break
             try:
                 decoded = content.decode("UTF-8")
-            except UnicodeDecodeError:
+            except UnicodeDecodeError as err:
                 # todo: do we still need this ?
+                print("==========START_ERROR=============")
+                print(err, "\ncontent:", content)
+                print("==========END_ERROR=============")
                 decoded = content  # type: ignore
             server_log(decoded.strip())
         except IOError as err:

and I got this:
==========START_ERROR=============
'utf-8' codec can't decode byte 0xff in position 11: invalid start byte
content: b'Information\xff: impossible de trouver des fichiers pour le(s) mod\x8ale(s) sp\x82cifi\x82(s).\r\n'
==========END_ERROR=============
It's a decoding error, my system's language is french, some of it's characters are not utf-8 (e.g é, è, ...)

@AmjadHD could you try changing UTF-8 to UTF-16 at the following lines and see if the error persists?
https://github.com/tomv564/LSP/blob/24ffd7f49130e41aecf76715ee78dd55696702df/plugin/core/transports.py#L143
https://github.com/tomv564/LSP/blob/24ffd7f49130e41aecf76715ee78dd55696702df/plugin/core/transports.py#L160
https://github.com/tomv564/LSP/blob/24ffd7f49130e41aecf76715ee78dd55696702df/plugin/core/transports.py#L213
https://github.com/tomv564/LSP/blob/24ffd7f49130e41aecf76715ee78dd55696702df/plugin/core/transports.py#L240

that fixed it

Hmm, after looking at the spec I think the ones in transport.py need to be UTF-8, but I'm not sure about the one in process.py.

So the one in process.py is just reading stderr. There's nothing in the specification about that. I guess it depends on the server what encoding it is using. I would expect any server to be using UTF-8.

It feels like the bytes are already un-decodable before we readline() them:
Detecting:
>>> import chardet
>>> chardet.detect(b'Information\xff: impossible de trouver des fichiers pour le(s) mod\x8ale(s) sp\x82cifi\x82(s).\r\n')
{'encoding': 'Windows-1252', 'confidence': 0.5334615384615384, 'language': ''}

Decoding:
>>> b'Information\xff: impossible de trouver des fichiers pour le(s) mod\x8ale(s) sp\x82cifi\x82(s).\r\n'.decode('windows-1252')
'Informationÿ: impossible de trouver des fichiers pour le(s) modŠle(s) sp‚cifi‚(s).\r\n'

One could  a batch file or node script that print the correct content and test how the output looks with subprocess.check_output.
But given that this is for debugging purposes, perhaps a lossy solution is acceptable.

@evandrocoan @AmjadHD undecodeable UTF-8 sequences should now be replaced by question marks (https://github.com/tomv564/LSP/pull/803).


update readme example to csproj

Would you be open to updating the readme example to csproj? I see your example project does this already, and if you only have time to reply here, I could probably make a pull request.

Apologies for a very late reply, I left my current job and starting a new company so you can probably imagine it's been quite crazy recently :D I am going to do this now.

Taken care of in https://github.com/PeterKottas/DotNetCore.WindowsService/releases/tag/v1.0.20 .


Navigation controller delegate

Hero isn't working for me in a navigation controller, because I've already got a navigation controller delegate set.
Is there any way to have hero set itself as the delegate, and forward methods on so I can continue to do custom logic?

Closing old issues, feel free to reopen.


Text doesn't have strike attribute when using 'light_grey' as color

Every other color seems to be working as intended
EDIT: It seems that the bold attribute on the first text is making the issue, otherwise it's fine without it

I think this depends on terminal support.
Running python -c "from termcolor import colored; print(colored('Test', 'grey', attrs=['strike']))" with iTerm on macOS, I get:

The grey doesn't really show up on dark background, if I highlight it I can see the strikethrough:

However, if I use Terminal, I don't see any strikethrough:

What OS, Python and terminal are you using?
You could try using the ANSI codes directly, for example:
print("\033[9m" + "hi" + "\033[0m")  # strike + hi + reset
print("\033[9m" + "\033[92m" + "hi" + "\033[0m")  # # strike + green + hi + reset

Do you get similar results?


Improve ergonomics and reduce boilerplate around creating text elements.

Objective
Creating UI elements is very boilerplate-y with lots of indentation.
This PR aims to reduce boilerplate around creating text elements.
Changelog

Renamed Text::with_section to from_section.
It no longer takes a TextAlignment as argument, as the vast majority of cases left it Default::default().
Added Text::from_sections which creates a Text from a list of TextSections.
Reduces line-count and reduces indentation by one level.
Added Text::with_alignment.
A builder style method for setting the TextAlignment of a Text.
Added TextSection::new.
Does not reduce line count, but reduces character count and made it easier to read. No more .to_string() calls!
Added TextSection::from_style which creates an empty TextSection with a style.
No more empty strings! Reduces indentation.
Added TextAlignment::CENTER and friends.

Note for reviewers.
Because of the nature of these changes I recommend viewing them in 'split diff view'.
Look for the book icon in the top-left of the Files changed tab.
Have fun reviewing :heart:
 >:D
Migration Guide
Text::with_section was renamed to from_section and no longer takes a TextAlignment as argument.
Use with_alignment to set the alignment instead.

The other related change I really want is a helper method for quickly getting the first section of text.

Ping @plof27 for review :)

@Weibye @TimJentzch, can I get your opinions on this?

bors r+

That new diff looks great!


Update use of paho-mqtt

Following the Python SDK directions, I installed pushy via requirements.txt.  It installs fine, but immediatly errors upon importing the pushy api with the following error:
>>> import pushy
Exception ignored in: <function Client.__del__ at 0xffff80635ea0>
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/paho/mqtt/client.py", line 874, in __del__
    self._reset_sockets()
  File "/usr/local/lib/python3.10/site-packages/paho/mqtt/client.py", line 1133, in _reset_sockets
    self._sock_close()
  File "/usr/local/lib/python3.10/site-packages/paho/mqtt/client.py", line 1119, in _sock_close
    if not self._sock:
AttributeError: 'Client' object has no attribute '_sock'
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.10/site-packages/pushy/__init__.py", line 2, in <module>
    import pushy.lib.mqtt as mqtt
  File "/usr/local/lib/python3.10/site-packages/pushy/lib/mqtt.py", line 10, in <module>
    client = mqtt.Client()
TypeError: Client.__init__() missing 1 required positional argument: 'callback_api_version'

It looks like version 2.0 is what you get when you install pushy via pip, which breaks the python pushy sdk.  Confirmed by installing paho-mqtt#1.6.1 and the pushy modules import properly.

Hi @ggoforth,
Thanks so much for reporting this, and for helping us resolve this issue!
Merged & published your PR #2 to PyPI as version 1.0.10. Please update to the latest version by running this command:
pip install --upgrade pushy-python


resave error

Hello, I edited the session and I got this error, precisely I edited the "resave" property, this is the session:
 app.use(     session({       secret: "secret",       resave: true,       saveUninitialized: false,       cookie: {         maxAge: 20 * 1000,       },       store: new PrismaSessionStore(new PrismaClient(), {         checkPeriod: 2 * 60 * 1000, //ms         dbRecordIdIsSessionId: true,         dbRecordIdFunction: undefined,       }),     }),   );
This is the error:
'(node:2280) UnhandledPromiseRejectionWarning: Error:
Invalid 'this.prisma[this.sessionModelName].update()' invocation in
C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@quixo3\prisma-session-store\dist\lib\prisma-session-store.js:483:81

  480     id: this.dbRecordIdIsSessionId ? sid : this.dbRecordIdFunction(sid),
  481 };
  482 if (!(existingSession !== null)) return [3 /*break*/, 4];
→ 483 return [4 /*yield*/, this.prisma[this.sessionModelName].update({
        data: {
          sid: 'BDTh4UWzc3-XHbGvqsroree_tky1gV68',
          expiresAt: new Date('2022-05-07T20:36:14.216Z'),
          data: '{"cookie":{"originalMaxAge":20000,"expires":"2022-05-07T20:36:14.216Z","httpOnly":true,"path":"/"},"passport":{"user":{"id":"625dea792235a00bc2a6da99","createdAt":"2022-04-18T22:47:21.021Z","updatedAt":"2022-04-18T22:47:21.023Z","email":"test1@t.co","firstName":null,"lastName":null,"verified":null}}}',
          id: 'BDTh4UWzc3-XHbGvqsroree_tky1gV68'
          ~~
        },
        where: {
          sid: 'BDTh4UWzc3-XHbGvqsroree_tky1gV68'
        }
      })

Unknown arg 'id' in data.id for type SessionUpdateInput. Did you mean 'sid'? Available args:
type SessionUpdateInput {
  sid?: String | StringFieldUpdateOperationsInput
  data?: String | StringFieldUpdateOperationsInput
  expiresAt?: DateTime | DateTimeFieldUpdateOperationsInput
}

    at Object.validate (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:44425:20)
    at PrismaClient._executeRequest (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:46509:17)
    at consumer (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:46453:23)
    at C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:46457:76
    at runInChildSpan (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:45702:12)
    at C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:46457:20
    at AsyncResource.runInAsyncScope (async_hooks.js:197:9)
    at PrismaClient._request (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:46456:86)
    at C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:43088:25
    at _callback (C:\Users\latta\Documents\GitHub\students-backend\parriot-backend\node_modules\@prisma\client\runtime\index.js:42852:52)
(Use 'node --trace-warnings ...' to show where the warning was created)
(node:2280) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag '--unhandled-rejections=strict' (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:2280) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Hi @decifris,
Thanks for posting this.
I've just posted a new release (3.1.4) that will prevent a crash in this circumstance, while still allowing the error to surface and be accessed via a callback function parameter (see notes for issue #82, here).
However, the underlying cause of the specific crash above remains unclear... From the log output, it looks like Prisma is complaining about an id parameter being supplied as part of update()'s data field, but id (I believe?) should be a legal parameter here.

Perhaps prisma's supplied "Unknown arg 'id' in data.id for type SessionUpdateInput." message is in error?

Perhaps type SessionUpdateInput is (somehow, somewhere - perhaps by a prisma generator?) being defined improperly in a way that is excluding id?

Perhaps the parameters supplied to update() are malformed in some way (bad json?) that is causing a parse error that is incorrectly suggesting that id is a problem?

Is this an issue you can reproduce reliably - or something that has happened once or intermittently?

I'm guessing the underlying issue is a prisma (or prisma generator?) issue, but - not certain.
Will leave this open for a bit, to see if new knowledge accumulates...

I don't have any particular new knowledge, but I can repro this issue. I always figured this was a purposeful thing (unable to edit the @id field of an object to prevent you from breaking things), I can provide more information if needed.

What I have found is that if you define your model in such a way that id and sid are unique, but neither are the table's primary key, the library performs as expected, at least in being able to bypass this error, will continue to monitor.
model Session {
  objId     String   @id @map("_id") @db.ObjectId @default(auto())
  id        String   @unique
  sid       String   @unique
  data      String
  expiresAt DateTime
}

@SunburntRock89 - thanks for the info.

It is possible that the outcome changes depending on which database provider you are using?

I've mainly used postgres - so not sure about this... Are you seeing this with a db other than postgres?

What I have found is that if you define your model in such a way that id and sid are unique, but neither are the table's primary key, the library performs as expected, at least in being able to bypass this error, will continue to monitor.

Good to know; thanks for this "clue".

Alright so after some minor digging I've discovered that this is specifically a Mongo issue.
_id is an immutable field and as such the generator does not allow you to edit it with .update
When attempting to modify _id in Studio 3T
Mongo Server error (MongoWriteException): Write operation error on server (my-atlas-instance). Write error: WriteError{code=66, message='After applying the update, the (immutable) field '_id' was found to have been altered to _id: 2', details={}}.

The big key here is the (immutable) field '_id'.
I'm not 100% on the architecture of this library, but does the id field absolutely need to be edited?

I'm not 100% on the architecture of this library, but does the id field absolutely need to be edited?

I'm 99.9% sure it shouldn't be - at least, it shouldn't be without also changing sid, so that dbRecordIdFunction() consistently maps one to the other.
Good idea (I think) to make id non-updateable.
I believe the fix (PR #96) addresses this bug; closing for now.


Connecting Dot Net Applications to  R

let's say I have a project like an MVC project ,I want to
*preform summary statistics using R on a Column (SQl DB).
*Display the summary on MVC page.
How Visual Studio 2017 may help me ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e11431a6-8401-2c63-b53c-e7f489b08ba7
Version Independent ID: 1f8a17a4-122f-b2ef-f866-87dfdeaf3332
Content
Content Source
Service: unspecified

What's presently available is the ability to embed R code within SQL stored procedures, which you should then be able to invoke from any other application through SQL queries.
See https://docs.microsoft.com/en-us/visualstudio/rtvs/integrating-sql-server-with-r#working-with-sql-server-stored-procedures.


Update Konserter “index”

Automatically generated by Netlify CMS

👷 Deploy Preview for xenodochial-jang-0ad7f2 processing.
🔨 Explore the source changes: 2841e1b2a1b44148381974370fd91c1b404c085c
🔍 Inspect the deploy log: https://app.netlify.com/sites/xenodochial-jang-0ad7f2/deploys/6142203d12875b000875c061


Illegal instruction (core dumped) on load/train model

Rasa version: 2.7.1
Python version**:3.8.10
Operating system (windows, osx, ...): ubuntu 20.4 lts (vm)
Issue: On loading / training a rasa model it exits with following error
Error (including full traceback): Illegal instruction (core dumped)
Command or request that led to error:

Thanks for the issue, @desmarchris will get back to you about it soon!
You may find help in the docs and the forum, too 🤗

@C4rb0ngit can you please post the full traceback?

Please provide more information and reopen the issue if this is still a problem


fix: green dot disappears in task LHN after reopen if reassign owned task

Details

Fix the appearance of the green dot indicator in the LHN when the task assignee is changes.
Fixed Issues

$ https://github.com/Expensify/App/issues/44209
PROPOSAL: https://github.com/Expensify/App/issues/44209#issuecomment-2198308463
Tests

Log in to two accounts
Using the first account, create a task without an assignee in a 1:1 conversation
Verify the green dot is not displayed in the task conversation in LHN for the first account
Assign the task to yourself using the first account
Verify there's a green dot in the Task conversation in LHN for the first account
Reassign the task to the second account participant using the first account
Verify the green dot is not displayed in the task conversation in LHN for the first account
Verify that a green dot is displayed in the task conversation in the LHN for the second account

[x] Verify that no errors appear in the JS console

Offline tests

Follow the same steps as above using one account, starting from step 2. Skip step 8
QA Steps

Log in to two accounts
Using the first account, create a task without an assignee in a 1:1 conversation
Verify the green dot is not displayed in the task conversation in LHN for the first account
Assign the task to yourself using the first account
Verify there's a green dot in the Task conversation in LHN for the first account
Reassign the task to the second account participant using the first account
Verify the green dot is not displayed in the task conversation in LHN for the first account
Verify that a green dot is displayed in the task conversation in the LHN for the second account

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: mWeb Chrome
https://github.com/user-attachments/assets/9502db2e-1fc5-4e9f-a349-0dbe44624354

iOS/Android: Native
https://github.com/user-attachments/assets/5cd4a661-0ea2-4056-8e55-8c74d2cb75ed

iOS: mWeb Safari
https://github.com/user-attachments/assets/d22a3321-12b5-4d9f-9b67-bf391d55e272

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/7aa2ed50-b9b5-4be7-93a6-3fcc4ef59dc2

MacOS: Desktop
https://github.com/user-attachments/assets/5842b3fd-26f3-41a3-b96c-e81b27467607

I have read the CLA Document and I hereby sign the CLA

Sorry for the delay!
@grogou Could you complete the recordings for all platforms? Also, merge the latest main. Thanks!

@mollfpr thank you for your review.
I have updated videos in PR for all platforms.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@grogou I had an issue when assigned the issue to myself that didn't show the green dot. It show the green dot if the task created by the other user.
https://github.com/user-attachments/assets/1df280be-4679-4676-9d69-974a9d0adc5d

@mollfpr In the old version, we didn't show a green dot for a report if it had a parent report access. The green dot appeared only in the parent report.
Your example is a case where the parent report, John Doe, task for test shows a green dot for the test report.
If you think the child report should also show a green dot, we can remove the report.hasParentAccess condition, and both parent and child reports will display a green dot.

Verify there's a green dot in the Task conversation in LHN for the first account

On step 5 it should be showing the green dot, and it does on the staging too.
https://github.com/user-attachments/assets/25f1665e-bd02-4008-a361-cc76b1a11aaf
Is this because of the changes on the ReportUtils. isWaitingForAssigneeToCompleteTask ?

Sorry, it's my bad. In step 5, I didn't mention that the report will have a green dot if it does not have parent access, otherwise, only the parent will have the green dot.
In your example in staging, the child also has a green dot because of the isUnreadWithMention function. It wasn't working correctly, and I've fixed it. Here is a description of what was wrong.
So we need to show green dot for child too?

@grogou The green dot shows inconsistently. In some other try it shows the green dot.
Green dot is showing
https://github.com/user-attachments/assets/173316fe-7490-42d8-88d0-77d3c1542dbf
Green dot is not showing
https://github.com/user-attachments/assets/e496edf3-44f2-49ba-a8b6-e492ffa9c168
This is because we have a different result from the comparison lastReadTime < lastMentionedTime.

@grogou Any update for the above issue?

You are correct. The issue lies in the comparison lastReadTime < lastMentionedTime. In the first video, the child report incorrectly shows a green dot because isUnreadWithMention returns true when lastReadTime is less than lastMentionedTime.
To fix this, we can also set lastMentionedTime to the current time
const additionalReport: NullishDeep<OnyxTypes.Report> = {};
if (report.reportID === currentReportID) {
    const now = Date.now();
    additionalReport.lastReadTime = DateUtils.getDBTimeWithSkew(now);
    additionalReport.lastMentionedTime = DateUtils.getDBTimeWithSkew(now);
}

@mollfpr sorry for late response.
I have updated code as we discussed.

Hey @mollfpr @grogou where are we at with this one?


METRON-2092: Config UI does not require you to set a grok timestamp field by default

Contributor Comments
Link to the original ASF Jira: https://issues.apache.org/jira/browse/METRON-2092
Issue

A Grok parser requires a timestampField attribute. Currently the UI allows the user to add a new Grok parser without any timestampField. When you start the parser, nothing happens and there are no error messages.

The UI should either default the timestampField attribute to timestamp or pop up an error message when the user tries to save a grok parser with no timestampField attribute.

Testing

Go to metron config
Try to add a new sensor which has a Grok parser
Make sure the TIMESTAMP field is there
It should have the default value timestamp
Try to remove it completely and save the sensor (you should not be able)
Try to save when it has a value timestamp or something else (it should work)

It should be the same in case of editing the sensor. If there's no timestamp field value, there should be an error message below the input field.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[X] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[X] Have you included steps or a guide to how the change may be verified and tested manually?

[X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[X] Have you written or updated unit tests and or integration tests to verify your changes?

[X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@ruffle1986 When testing, I'm not seeing the timestamp field when creating a new grok parser. What do I need to do to 'Make sure the TIMESTAMP field is there'?

@sardell weird. for me it's there. looks like a caching issue.

@ruffle1986 You were right, it must've been something weird with my cache (or maybe it was just user error :flushed:). It works as described for me now when testing locally on full dev. While I can verify that the UI works, I would like another committer who is more familiar with the timestampField to verify that an unformatted string value is correct. It just seems weird to me that a timestamp field wouldn't enforce timestamp formatting, and would default to a string value of "timestamp." Again, this probably stems from my own ignorance of that field and what it is used for on the backend.
+1 pending another committer verifying that this is indeed how the field should be.

@sardell This comes from the grok pattern used. The value is an indirection to another variable that references the actual timestamp the user wants to use. For example, in full dev:
YAF

"timestampField":"start_time"
"dateFormat":"yyyy-MM-dd HH:mm:ss.S" - need this in order for the parser to translate the non-timestamp-fromatted date/time into a proper numeric timestamp.
You can find the grok expressions loaded in HDFS at /patterns/yaf. They're also staged from the RPM installs on the local file system at $METRON_HOME/patterns. Anyhow, here's what YAF's Grok patterns file looks like:

YAF_TIME_FORMAT %{YEAR:UNWANTED}-%{MONTHNUM:UNWANTED}-%{MONTHDAY:UNWANTED}[T ]%{HOUR:UNWANTED}:%{MINUTE:UNWANTED}:%{SECOND:UNWANTED}
YAF_DELIMITED %{YAF_TIME_FORMAT:start_time}\|%{YAF_TIME_FORMAT:end_time}\|%{SPACE:UNWANTED}%{BASE10NUM:duration}\|%{SPACE:UNWANTED}%{BASE10NUM:rtt}\|%{SPACE:UNWANTED}%{INT:protocol}\|%{SPACE:UNWANTED}%{IP:ip_src_addr}\|%{SPACE:UNWANTED}%{INT:ip_src_port}\|%{SPACE:UNWANTED}%{IP:ip_dst_addr}\|%{SPACE:UNWANTED}%{INT:ip_dst_port}\|%{SPACE:UNWANTED}%{DATA:iflags}\|%{SPACE:UNWANTED}%{DATA:uflags}\|%{SPACE:UNWANTED}%{DATA:riflags}\|%{SPACE:UNWANTED}%{DATA:ruflags}\|%{SPACE:UNWANTED}%{WORD:isn}\|%{SPACE:UNWANTED}%{DATA:risn}\|%{SPACE:UNWANTED}%{DATA:tag}\|%{GREEDYDATA:rtag}\|%{SPACE:UNWANTED}%{INT:pkt}\|%{SPACE:UNWANTED}%{INT:oct}\|%{SPACE:UNWANTED}%{INT:rpkt}\|%{SPACE:UNWANTED}%{INT:roct}\|%{SPACE:UNWANTED}%{INT:app}\|%{GREEDYDATA:end_reason}

Notice the start_time field - %{YAF_TIME_FORMAT:start_time}
For an original message "original_string": "2019-06-03 20:38:27.000|2019-06-03 20:38:27.000| 0.000| 0.000| 6| <IP_ADDRESS>|49189| <IP_ADDRESS>| 80| A| 0| 0| 0|9dfb1927|00000000|000|000| 1| 40| 0| 0| 0|idle ",, this results in a Metron timestamp field published to the index as "timestamp":<PHONE_NUMBER>000
Squid

"timestampField": "timestamp"
No need for dateFormat bc the timestamp is in the right format for Metron OOTB.

SQUID_DELIMITED %{NUMBER:timestamp}[^0-9]*%{INT:elapsed} %{IP:ip_src_addr} %{WORD:action}/%{NUMBER:code} %{NUMBER:bytes} %{WORD:method} %{NOTSPACE:url}[^0-9]*(%{IP:ip_dst_addr})?

Does that answer your question?

@mmiklavc That makes sense. I figured the name of the field might have been misleading me, but I wanted to check before merging. You answered my question. Thanks!


How would you upload and overwrite a file without renaming it

I'm trying to upload a file with the same name for example file.png and I have the same file name on dropbox folder. When I use upload method it does rename the file to avoid conflict. When I set param option ['autorename' => false] it doesn't work and give me errors instead.
I would like to upload the same file and stays it as a revision for example. What would be the right approach to do this? Thanks in advance.

This is can be done by explicitly passing an update type to the mode param. The Dropbox documentation has it. See: https://www.dropbox.com/developers/documentation/http/documentation#files-upload
// Fetch the File Metadata
$file = $dropbox->getMetadata("MY-AWESOME-FILE");
// Get the file's revision hash
$revision = $file->getRev();

$params = [
        'mode' => [
            ".tag" => "update",
            'update' => "79304b4a4c9"
        ],
        'autorename' => false
    ];

$updatedFile = $dropbox->upload("path/to/MY-AWESOME-FILE", "/MY-AWESOME-FILE", $params);

Let me know if it doesn't work.


Fix missing files after folder renaming

This is a hotfix that just points SW to the missing files.
The old files aren't deleted (they should be) - haven't gotten around to that yet since my internet connection is unstable (large file uploads).
This should be included in the release.

Oh boy. I'm pretty useless for reviewing this, considering I don't have solidworks. If it works for you, then good enough for me on this.

meeeeeerge


Convert Query Factory to a singleton

Need to implement a getInstance method in QueryFactory similar to in BackendFactory
Currently a new instance is created every time a search is executed

Fixed in commit ID: 281f3d68f2e194100200d87450230f3c7ef32648


How to run caffeonspark in cluster mode

whether I need to build image by myself？
There is only standalone mode docker file in the docker dir.How can i run caffeOnSpark by cluster mode.Thank you for your answer

If you are using Yarn as the resource manager, here is the instruction.
https://github.com/yahoo/CaffeOnSpark/wiki/GetStarted_yarn


Fixed some bugs and added new toggles

Combined some changes. ;)

Cleaned up empty lines with spaces
For me its called night_time not night_mode (not sure if it is a bug or it is called differently on other models)
Fixed typo read -> rear
I think tv_remote should be a boolean (tested it, worked for me)
Added neuralx toggle
Added top and center setters

I've merged all of this other than the night_mode change


rsonpath: 0.6.1 -> 0.7.0

Diff: https://github.com/v0ldek/rsonpath/compare/v0.6.1...v0.7.0
Changelog: https://github.com/v0ldek/rsonpath/blob/v0.7.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

There is a hash mismatch, maybe upstream recreated the tag:
unpacking source archive /private/tmp/nix-build-source.drv-0/v0.7.0.tar.gz
error: hash mismatch in fixed-output derivation '/nix/store/9xdb6z3r72p6blxm4annqvqi0xpxrqz0-source.drv':
         specified: sha256-Nufkn7jQH4kk4igG3ppVlbrNtDMTZkwAq5OK13ETtTg=
            got:    sha256-j63pHun++3qYTj5oRThEO5PYI/x41ynAR9UqaWBcGlU=
error: 1 dependencies of derivation '/nix/store/s8g1c27ick1h12j2bhaqgzcrncgfw8s2-rsonpath-0.7.0-vendor.tar.gz.drv' failed to build


Somfy Tahoma Unsupported type io:DiscreteGarageOpenerIOComponent

Home Assistant release with the issue: 0.100.2

Last working Home Assistant release (if known): none
Operating environment (Hass.io/Docker/Windows/etc.): hassio on RPI3 (flash card)

Integration: https://www.home-assistant.io/integrations/tahoma

Description of problem:
I have at home a Somfy Connexoon device working with Home Assistant as part of the Tahoma integration. My window covers (Somfy IO) works well.
But I also have a Garage door Somfy Rollixo IO known from my Connexoon device and working with the android application Somfy Access. But on Home Assistant this garage door device is not known and the logs give the error "Unsupported type io:DiscreteGarageOpenerIOComponent" (see traceback below).
I have looked at the python code for the Tahoma integration and indeed there are no io:DiscreteGarageOpenerIOComponent Tahoma device class registered. But I don't know where to go from there to help more...
At first I thought of a workaround by using the Somfy API but unfortunately it only covers the cover domain (pun not intended) and not garage doors.
I have good technical knowledge as I work in IT but I don't really know how Home Assistant development works and less more about the tahoma integrations, but I'm willing to help and try code with this Somfy Rollixo IO if needed !
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
tahoma:
  username: !secret tahoma_username
  password: !secret tahoma_password
  exclude: [BridgeHUEComponent, HueLampHUEComponent, PodComponent, PodMiniComponent]

Traceback (if applicable):
Unsupported type io:DiscreteGarageOpenerIOComponent for Tahoma device garage

Additional information:
Could just adding the io:DiscreteGarageOpenerIOComponent into the list of Tahoma device class in the python code could do the trick ? I don't know what's the difference between normal "io:GarageOpenerIOComponent" and this "io:DiscreteGarageOpenerIOComponent"

Hi, I've tried overriding the Tahoma component and to add the "io:DiscreteGarageOpenerIOComponent" as a device garage door class but it didn't work.
By looking at the Tahoma component source code I can deduce this problem is more about the TahomaApi library than with the component.
As I don't know how this library works could we work together to create the issue with the right information about this ?

I've made some adjustements because I figured I only added "io:DiscreteGarageOpenerIOComponent" in the init of the Tahoma integrations but I found out I needed to add it in the cover.py too.
So now with those two modifications I can see my Garage door as a cover in Home Assistant, but remains two problems :

garage door is seen as open although it's closed
garage door is locked : what does it mean ?

The informations about my garage door are the following :
tahoma_device_id: io://XXXX-XXXX-XXXX/XXXXXXXX
rssi_level: 18
lock_start_ts: 2019-10-23T08:28:50.121427+00:00
lock_end_ts: 2019-10-23T10:36:20.121483+00:00
lock_level: comfortLevel1
lock_originator: localUser
friendly_name: garage
icon: mdi:lock-alert
supported_features: 11
device_class: garage


Suggest Reducing Work Section Info into single data set

I see in work.js data may be being rendered to duplicate variables within multiple templates.
Might consider unifying that dataset. Thoughts?

Acknowledged.  The template helpers can most certainly be simplified.


Recognize exponent suffix in parseWhole in ceylon.whole

I think there is also need to support reading string representations like
(a)  28e+123     // integral mantissa and nonnegative exponent
(b)  4.56789e11  // fractional mantissa, overall result is still integral

I suggest (b) be added too because it can be generated by formatting float values to convert from them if they are too big to be able to have integer to convert through.
As of the cases
(c)  28000e-2   // negative exponent but the value is integral
(d)  4.56789e3  // positive exponent but fractional part still exists

I believe (c) still isn’t needed to be accepted, and if (d) is understood as valid, then the parse result is a whole part of the actual number, that is any “invalid” digits are simply dropped.
What do you think?

IDK. This seems like it might be a job for ceylon.decimal to me. And once you have a float, you've given up exact precision anyway, so you can often just use float arithmetic. Would multiple rounding modes need to be supported?
An alternative is parseWhole(formatFloat(theFloat, 0, 0)).

And once you have a float, you've given up exact precision anyway, so you can often just use float arithmetic.

That’s so, but I’ve just thought about one specific case of converting floats to rational numbers (with Whole components) within a specified precision. In this case a conversion of at least “integral” floats could be necessary, and these may have value out of Integer’s bounds…

parseWhole(formatFloat(theFloat, 0, 0))

Ah, so I’ve still underinvestigated it. And that too:

This seems like it might be a job for ceylon.decimal

Yes, I agree if ceylon.decimal goes cross-platform, it’s a better place for the mentioned.
But I’d still be glad at least (a) to be allowed in parseWhole (and parseInteger too—I initially forgot). Maybe.


Wish list

First. I like the the app very much. It's simple and easy to use. But there are some things I would like to see if you consider it relevant and have time.

Change size of font on the buttons and, if possible, allow multiple lines of text. (list view like the Android layout would also work)
Drag and drop sounds into category.
Support for webp image format (Low priority, I can convert)
Smaller button size (small, medium, large) would be nice, where current size is large.

Thank you for the valuable feedback!

The list view is definitely on the list for the next major release
That's a good idea. I added that to the list.
I never used WebP before, but that's also added to the list
I think the button size is okay, at least for tablets and smaller devices, but for mouse input, that's true


update migration page with actual 0.8.9 migration steps

currently it's a link to the merged PR. Let's link to the README for the importer tool, plus the blog post.

@rkuchan can you make this happen soon, like end of the week?

Should be able to get this done by Friday!


createComponent & createContext should not log anything on their own

Provided that #3 is resolved, logging should be removed from both functions.
If the succeeds it could return true. When the function fails, just throw the error. The caller should be able to handle that error.

@antoniom thanks for the suggestion, I removed logging from these utils. They now return a result of the following CreateStatus type:
type CreateStatus = {
    status: 'OK' | 'ERR'
    msg: string
}

Thanks @grigorischristainas !


Add CONTRIBUTING.md

Closes https://github.com/sendgrid/docs/issues/3242
Added a contributing.md
@ksigler7

@divyam3897 thanks so much for your effort here!
We've decided to accept this for #3242: https://github.com/sendgrid/docs/pull/3247
Please check back often, as we are always adding new issues!


Utilize all lambci env vars

https://github.com/lambci/docker-lambda/blob/master/provided/run/init.go

also it does not take into acount client keys when using docker


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL: http://app.uploadfile.com/
JustList Name: UploadChain
JustList Contract : TCP7eM1PcBJag4rsPJfGWt4m9k5CUD9NGi
Link to the official homepage of the JustList manager: http://www2.uploadfile.com/

Sorry, your issue will be closed as you did not submit your information in the correct format.


GUI

How would I implement this into a personal GUI? I would just have on, off, and reset settings buttons.

How would I implement this into a personal GUI? I would just have on, off, and reset settings buttons.

Hello, by reading the environment table and its structure you will get all the answers you need, also it is recommended that you use Raw Main.lua because it allows for a better workplace for if you are implementing the script somewhere else. Here are some examples:
First of all, you will need to load the (raw) aimbot's environment into the script, by reading README.md > Script (paste the loadstring of the bullet that says Raw Main.lua at the top of your code and upon execution the getgenv().Aimbot environment will load).
Reset Settings (Button)
EVENT(function()
  getgenv().Aimbot.Functions:ResetSettings()
end)

-- You will also need to reset the GUI values / configurations to match with the default / new values.

FOV (Slider)
EVENT(function(FOV_ARG)
   getgenv().Aimbot.FOVSettings.Amount = FOV_ARG
end)

FOV Visual Color (RGB Color Picker)
EVENT(function(R, G, B)
   getgenv().Aimbot.FOVSettings.Color = Color3.fromRGB(R, G, B) -- <Color3> and not <string> because Raw Main.lua doesn't use Exunys Developer storing systems.
end)

These are some of the options & configurations, the other ones should be pretty much the same.
That should be pretty much all you need to implement this script into a GUI / UI Library.
Please make sure to credit me incase you do reuse my code (read LICENSE).


adding a change update to validation on password in SignUp

@googlebot I fixed it.

@googlebot I fixed it.


where can i find the plots for TestGPDelve?

nice looking project you have here.
I ran TestGPDelve, but I can't find these:
"DynaML also generates Javascript plots using Wisp in the browser."
Thanks.

Hi. Have a look at the Abott Power Plant example and its source code which shows how it generates a plot of the fit.

@amuseoffire : Also check out the gitter chat room of DynaML you can post common questions like this in the chat room instead of creating an issue. Issues should be reserved for bugs uncovered in the DynaML source code, unexpected behaviour or new feature requests.


[Bug] Low QPS for 1.2b model

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[x] 5. Please use English, otherwise it will be closed.

Describe the bug
I modified the config of llama to be a 1.2b model. The throughput becomes astonishingly low.
config that I used:
{
  "architectures": [
    "LlamaForCausalLM"
  ],
  "attention_dropout": 0.0,
  "bos_token_id": 1,
  "eos_token_id": 2,
  "hidden_act": "silu",
  "hidden_size": 2048,
  "initializer_range": 0.02,
  "intermediate_size": 5504,
  "max_position_embeddings": 32768,
  "model_type": "llama",
  "num_attention_heads": 16,
  "num_hidden_layers": 24,
  "num_key_value_heads": 16,
  "rms_norm_eps": 1e-05,
  "rope_theta": 1000000.0,
  "sliding_window": null,
  "tie_word_embeddings": false,
  "torch_dtype": "bfloat16",
  "transformers_version": "4.36.0",
  "use_cache": true,
  "vocab_size": 132000
}

logs from the server side:
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1871, #cached-token: 0, cache hit rate: 0.00%, #running-req: 380, #queue-req: 1549
[gpu=0] Decode batch. #running-req: 381, #token: 344397, token usage: 0.96, gen throughput (token/s): 93.97, #queue-req: 1549

Reproduction
command used for serving:
python3 -m sglang.launch_server --model-path /models/dummy-1b2 --disable-radix-cache
command used for benchmarking:
python3 -m sglang.bench_serving --backend sglang --dataset-name random --num-prompts 3000 --random-input 1024 --random-output 1024 --output-file offline.jsonl
benchmarking results:
============ Serving Benchmark Result ============
Backend:                                 sglang
Traffic request rate:                    inf
Successful requests:                     1000
Benchmark duration (s):                  585.78
Total input tokens:                      518832
Total generated tokens:                  487080
Total generated tokens (retokenized):    0
Request throughput (req/s):              1.71
Input token throughput (tok/s):          885.71
Output token throughput (tok/s):         831.51
----------------End-to-End Latency----------------
Mean E2E Latency (ms):                   286025.05
Median E2E Latency (ms):                 292304.70
---------------Time to First Token----------------
Mean TTFT (ms):                          0.00
Median TTFT (ms):                        0.00
P99 TTFT (ms):                           0.00
-----Time per Output Token (excl. 1st token)------
Mean TPOT (ms):                          1069.06
Median TPOT (ms):                        538.16
P99 TPOT (ms):                           10731.36
---------------Inter-token Latency----------------
Mean ITL (ms):                           0.00
Median ITL (ms):                         0.00
P99 ITL (ms):                            0.00
==================================================

Environment
Python: 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110]
CUDA available: True
GPU 0,1: NVIDIA H100 80GB HBM3
GPU 0,1 Compute Capability: 9.0
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.2, V12.2.140
CUDA Driver Version: 535.161.08
PyTorch: 2.4.0+cu121
sglang: 0.2.12
flashinfer: 0.1.4+cu121torch2.4
triton: 3.0.0
transformers: 4.44.0
requests: 2.32.3
tqdm: 4.66.5
numpy: 1.26.4
aiohttp: 3.10.3
fastapi: 0.112.0
hf_transfer: 0.1.8
huggingface_hub: 0.24.5
interegular: 0.3.3
packaging: 22.0
PIL: 10.3.0
psutil: 5.9.8
pydantic: 2.8.2
uvicorn: 0.30.5
uvloop: 0.19.0
zmq: 26.1.0
vllm: 0.5.4
multipart: 0.0.9
openai: 1.40.5
anthropic: 0.32.0
NVIDIA Topology:
        GPU0    GPU1    NIC0    NIC1    NIC2    NIC3    NIC4    NIC5    NIC6    NIC7    NIC8    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      NV18    SYS     SYS     SYS     SYS     NODE    NODE    NODE    NODE    SYS     48-95  1N/A
GPU1    NV18     X      SYS     SYS     SYS     SYS     NODE    NODE    NODE    NODE    SYS     48-95  1N/A
NIC0    SYS     SYS      X      NODE    NODE    NODE    SYS     SYS     SYS     SYS     NODE
NIC1    SYS     SYS     NODE     X      NODE    NODE    SYS     SYS     SYS     SYS     NODE
NIC2    SYS     SYS     NODE    NODE     X      NODE    SYS     SYS     SYS     SYS     NODE
NIC3    SYS     SYS     NODE    NODE    NODE     X      SYS     SYS     SYS     SYS     NODE
NIC4    NODE    NODE    SYS     SYS     SYS     SYS      X      NODE    NODE    NODE    SYS
NIC5    NODE    NODE    SYS     SYS     SYS     SYS     NODE     X      NODE    NODE    SYS
NIC6    NODE    NODE    SYS     SYS     SYS     SYS     NODE    NODE     X      NODE    SYS
NIC7    NODE    NODE    SYS     SYS     SYS     SYS     NODE    NODE    NODE     X      SYS
NIC8    SYS     SYS     NODE    NODE    NODE    NODE    SYS     SYS     SYS     SYS      X

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

NIC Legend:

  NIC0: mlx5_0
  NIC1: mlx5_1
  NIC2: mlx5_2
  NIC3: mlx5_3
  NIC4: mlx5_4
  NIC5: mlx5_5
  NIC6: mlx5_6
  NIC7: mlx5_7
  NIC8: mlx5_8

ulimit soft: 1024768

It seems that after a few handred of requests, the gpu utilization quickly goes down to zero and keeps at zero.
The serving log is also interesting:
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1074, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 40
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 232, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 39
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 967, #cached-token: 0, cache hit rate: 0.00%, #running-req: 392, #queue-req: 37
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 114, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 36
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1382, #cached-token: 0, cache hit rate: 0.00%, #running-req: 392, #queue-req: 34
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 136, #cached-token: 0, cache hit rate: 0.00%, #running-req: 394, #queue-req: 33
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 739, #cached-token: 0, cache hit rate: 0.00%, #running-req: 395, #queue-req: 32
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 889, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 31
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1046, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 29
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 389, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 28
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 97, #cached-token: 0, cache hit rate: 0.00%, #running-req: 392, #queue-req: 26
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 1001, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 25
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 1072, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 24
[gpu=0] Decode batch. #running-req: 393, #token: 345712, token usage: 0.96, gen throughput (token/s): 8926.85, #queue-req: 24
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 783, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 23
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 244, #cached-token: 0, cache hit rate: 0.00%, #running-req: 390, #queue-req: 22
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1723, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 20
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 303, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 19
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 729, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 18
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 1085, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 17
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 705, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 16
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 712, #cached-token: 0, cache hit rate: 0.00%, #running-req: 390, #queue-req: 15
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 1304, #cached-token: 0, cache hit rate: 0.00%, #running-req: 387, #queue-req: 13
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 52, #cached-token: 0, cache hit rate: 0.00%, #running-req: 389, #queue-req: 11
[gpu=0] Prefill batch. #new-seq: 2, #new-token: 836, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 9
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 142, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 8
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 733, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 7
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 1012, #cached-token: 0, cache hit rate: 0.00%, #running-req: 394, #queue-req: 6
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 424, #cached-token: 0, cache hit rate: 0.00%, #running-req: 392, #queue-req: 5
[gpu=0] Prefill batch. #new-seq: 3, #new-token: 2021, #cached-token: 0, cache hit rate: 0.00%, #running-req: 390, #queue-req: 2
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 502, #cached-token: 0, cache hit rate: 0.00%, #running-req: 393, #queue-req: 1
[gpu=0] Prefill batch. #new-seq: 1, #new-token: 772, #cached-token: 0, cache hit rate: 0.00%, #running-req: 391, #queue-req: 0
[gpu=0] Decode batch. #running-req: 374, #token: 326907, token usage: 0.91, gen throughput (token/s): 9258.00, #queue-req: 0
[gpu=0] Decode batch. #running-req: 336, #token: 297539, token usage: 0.83, gen throughput (token/s): 10505.69, #queue-req: 0
[gpu=0] Decode batch. #running-req: 304, #token: 268581, token usage: 0.75, gen throughput (token/s): 10310.75, #queue-req: 0
[gpu=0] Decode batch. #running-req: 280, #token: 253501, token usage: 0.71, gen throughput (token/s): 10056.35, #queue-req: 0
[gpu=0] Decode batch. #running-req: 265, #token: 249694, token usage: 0.70, gen throughput (token/s): 9440.14, #queue-req: 0
[gpu=0] Decode batch. #running-req: 241, #token: 234406, token usage: 0.65, gen throughput (token/s): 9304.63, #queue-req: 0
[gpu=0] Decode batch. #running-req: 216, #token: 216304, token usage: 0.60, gen throughput (token/s): 9083.91, #queue-req: 0
[gpu=0] Decode batch. #running-req: 190, #token: 196657, token usage: 0.55, gen throughput (token/s): 8537.66, #queue-req: 0
[gpu=0] Decode batch. #running-req: 173, #token: 185035, token usage: 0.52, gen throughput (token/s): 8205.73, #queue-req: 0
[gpu=0] Decode batch. #running-req: 155, #token: 169052, token usage: 0.47, gen throughput (token/s): 7852.29, #queue-req: 0
[gpu=0] Decode batch. #running-req: 139, #token: 157151, token usage: 0.44, gen throughput (token/s): 7421.50, #queue-req: 0
[gpu=0] Decode batch. #running-req: 117, #token: 136585, token usage: 0.38, gen throughput (token/s): 7286.93, #queue-req: 0
[gpu=0] Decode batch. #running-req: 99, #token: 119758, token usage: 0.33, gen throughput (token/s): 7097.40, #queue-req: 0
[gpu=0] Decode batch. #running-req: 89, #token: 110027, token usage: 0.31, gen throughput (token/s): 6768.98, #queue-req: 0
[gpu=0] Decode batch. #running-req: 70, #token: 88350, token usage: 0.25, gen throughput (token/s): 6335.63, #queue-req: 0
[gpu=0] Decode batch. #running-req: 64, #token: 82454, token usage: 0.23, gen throughput (token/s): 5995.88, #queue-req: 0
[gpu=0] Decode batch. #running-req: 45, #token: 58904, token usage: 0.16, gen throughput (token/s): 5474.93, #queue-req: 0
[gpu=0] Decode batch. #running-req: 38, #token: 50785, token usage: 0.14, gen throughput (token/s): 4698.11, #queue-req: 0
[gpu=0] Decode batch. #running-req: 29, #token: 38095, token usage: 0.11, gen throughput (token/s): 4384.86, #queue-req: 0
[gpu=0] Decode batch. #running-req: 18, #token: 23464, token usage: 0.07, gen throughput (token/s): 3659.66, #queue-req: 0
[gpu=0] Decode batch. #running-req: 11, #token: 15441, token usage: 0.04, gen throughput (token/s): 7.77, #queue-req: 0
[gpu=0] Decode batch. #running-req: 6, #token: 8363, token usage: 0.02, gen throughput (token/s): 2082.77, #queue-req: 0
[gpu=0] Decode batch. #running-req: 4, #token: 6515, token usage: 0.02, gen throughput (token/s): 1476.34, #queue-req: 0
[gpu=0] Decode batch. #running-req: 3, #token: 4768, token usage: 0.01, gen throughput (token/s): 961.51, #queue-req: 0
[gpu=0] Decode batch. #running-req: 1, #token: 1540, token usage: 0.00, gen throughput (token/s): 636.70, #queue-req: 0

Good catch. I'll take a look asap.

Do not look at [gpu=0] Decode batch. #running-req: 381, #token: 344397, token usage: 0.96, gen throughput (token/s): 93.97, #queue-req: 1549. This is temporary throughput
The gpu util goes to 0 because all requests have been processed.
Run a larger --num-prompts and  look at the final report.


Syntax highlighter

Added syntax highlighter in config editor (nginx mode)
Added added check for existence of a directory nginx config

Hey @foozzi, thanks for your PR. I was glad to see that you were able to implement the editor so quickly. The ACE-Editor looks really good too. I noticed three points that still need to be adjusted before I can confirm the PR.
Point 1:
I guess the color palette is a matter of taste. I would prefer something simpler that fits the color scheme of nginx-ui, like chrome theme. I think a feature in the future release will probably be a dark theme. hehe. Then Monokai fits great. But until then I would like to have something that matches the white background.
Point 2:
I checked the github project of ACE Editor and found the following in the LICENSE agreement:
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
* Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
* Neither the name of Ajax.org B.V. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
This has to be done before we can use the ACE editor in nginx ui.
Point 3:
The configuration pages of the domains have not yet implemented the code editor. This leads to a break in the design of the application. I would be happy if you use it there as well.
If the points are fulfilled I am ready to accept the PR. Would you still do it?
Best David

Hi @schenkd !
Thank you for response.
I was on vacation for some time, I think from tomorrow I will fulfill all points
Best regards Igor!

Point 2 resolved: https://github.com/ajaxorg/ace/issues/4337

@schenkd Hi! Look at the changes and https://github.com/ajaxorg/ace/issues/4337

safe to say Project dead?


Is there backdrop support in the library?

Hello, Its more of doubt.
Did this library provide backdrop close support out of the box?
If not, is there any workaround to achieve it with this lib?
Thanks

Look at the apple music example : https://github.com/osdnk/react-native-reanimated-bottom-sheet/blob/master/Example/src/screen/AppleMusic.tsx


fix: redundant yaml in config

fix #29

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d93537e). Click here to learn what that means.
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage        ?   58.60%
=======================================
  Files           ?       67
  Lines           ?     4827
  Branches        ?        0
=======================================
  Hits            ?     2829
  Misses          ?     1876
  Partials        ?      122

Flag
Coverage Δ

unittests
58.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ main has degraded performance

In a90a4d1, main ($MAIN_API_URL) experienced degraded performance:

HTTP code: 200
Response time: 21388 ms

Resolved: main performance has improved in e0ddcd1.


Some attribute properties should not be considered as "editing" in locks.

For example, adding a new option in a multiple choice field.

Addressed in 2.0


fix(drawer): drawer running inside the zone keydown event.

Currently, the drawer is listening to the event 'keydown' inside the zone. This makes the change detector be fired every time while we are pressing 'any' key, even it's is not the ESCAPE key.
With this code, we can escape it, and run only inside the zone when there is an escape event.
Do we really need this?
I'm sure most apps would not need that, but for example, in our app, we have a drawer that inside has a bunch of controls that are controlled by keyboard events... so this has an impact to our performance since change detector is fired while pressing. So I think it would be a good change, although it's is not much elegant, but it is functional.

Interesting, had not considered this, good catch!

Thanks! I have updated the comment @mmalerba , what do you think?

Thanks for the fix!

@mmalerba this one's missing a release target.

marked it patch for now. If it turns out to break a bunch of tests because people were relying on this to trigger change detection we can up it to major


Add GitHub Actions to run unit tests

Once #21 is done, this is for adding the tests to run on GitHub Actions

Closing this for now since scrutinizer for unit tests has been ok