Default vim sink doesn't respect working directory

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
The default 'sink' for fzf#run() (vim implementation) is a bit confusing. One might expect that it would give the same result as 'sink': 'e', but that's not the case. Using the example from the vim readme:
    command! -bang -complete=dir -nargs=* LS
        \ call fzf#run(fzf#wrap('ls', {'source': 'ls', 'dir': <q-args>}, <bang>0))

Open vim in directory A. Now open a file at some directory, B, with noautochdir. Then run :LS without arguments. Files are listed for A, but selecting one with Enter opens an empty buffer with the same name under directory B. Adding the explicit 'sink': 'e' solves this problem, but means losing <C-t>, <C-v> etc. actions for opening in splits/tabs.
Is there a reason why the default sink behaves differently to the 'e' command?
EDIT: It appears this only happens when relying on the default sink AND default directory detection. Running e.g. :LS ~ without specifying the sink also works correctly.

Slightly off-topic: I recommend changing the examples to use -nargs=? since specifying more than one directory argument doesn't make sense (and results in an error).

Thanks for the report. I can reproduce the problem.
cd /tmp
mkdir -p foo bar
touch foo/1 bar/2

cd foo
vim ../bar/2

#  :command! -bang -complete=dir -nargs=* LS call fzf#run(fzf#wrap('ls', {'source': 'ls', 'dir': <q-args>}, <bang>0))
#  :LS
#    Select 1, opens bar/1, not foo/1

This looks like a case where an empty dir entry is not properly ignored. This patch should fix the problem.
diff --git a/plugin/fzf.vim b/plugin/fzf.vim
index c94bb9e..763747c 100644
--- a/plugin/fzf.vim
+++ b/plugin/fzf.vim
@@ -424,10 +424,10 @@ try
     throw v:exception
   endtry

-  if !has_key(dict, 'dir')
+  if !s:present(dict, 'dir')
     let dict.dir = s:fzf_getcwd()
   endif
-  if has('win32unix') && has_key(dict, 'dir')
+  if has('win32unix') && s:present(dict, 'dir')
     let dict.dir = fnamemodify(dict.dir, ':p')
   endif

I recommend changing the examples to use -nargs=?

Good point. Will do.

Should be fixed now. Let me know if you still see the problem. Thanks.


feat: add replicate demo and api

Hello!
Awesome work on DeepSeek-VL
This PR makes it possible to run DeepSeek-VL on Replicate(https://replicate.com/lucataco/deepseek-vl-7b-base) and via API(https://replicate.com/lucataco/deepseek-vl-7b-base/api).
With your permission, we'd like to transfer the demo page to the Replicate deepseek-ai org so you can make any edits.
Thanks!

Hi @lucataco, sorry for closing your pr. Awesome web demo for DeepSeek-Vl, could please open up a new pr for this, thanks a lot. Sorry for the inconvenience.


Category menu is over post title in AMP

@orballo let me know once it's done and I'll push it to production

@luisherranz Issue fixed.

Awesome, thanks @orballo !


feat(atenlib): add op(chunk)

LGTM! I would wait for Rama to review the parts in the evaluator

@gramalingam pls help to review. The original implementation doesn't return valid output numbers and based on opset17(split).

Also cc @BowenBao for the logic

We can merge if there's no movement


Object2ObjectArrayMap(Map) works in a worst manner (put is used under the hood)

I use Object2ObjectArrayMap as a snapshot of map (for iteration).
I expect that new Object2ObjectArrayMap(Map) will be fast as new Object2ObjectArrayMap<>(Map.keySet().toArray(), Map.values().toArray())
but performance issue is that
	public Object2ObjectArrayMap(final Object2ObjectMap<K, V> m) {
		this(m.size());
		putAll(m);
	}

where putAll calls put and put does linear search.
I fully understand purpose of this map implementation, but still I do not see any reason why this constructor cannot be implemented in an efficient manner.

Please provide benchmarks.

I don't think that benchmark is needed here, as it is clear that put uses findKey and by design search is linear.  Nothing to measure :)

just put them into two parallel arrays and scan linearly to find an item.

If you

wonder what for in this case I use Object2ObjectArrayMap:
    List<Map.Entry<Node, Collection<Node>>> list;
    synchronized (map) {
      list = new ArrayList<>(map.entrySet());
      map.clear();
    }
    // use list

This code works for java, but not when map here is Object2ObjectOpenHashMap. Because opposite to java, clear clears not only map, but also returned entry set.
So, as solution, I returns iterator of entries (I cannot expose fastutil to clients).
public @NotNull Iterator<? extends Map.Entry<K, Collection<V>>> fastEntrySetSnapshot() {
    if (isEmpty()) {
      return Collections.emptyIterator();
    }
    else {
      // Object2ObjectArrayMap(map) calls linear put under the hood, so, use toArray.
      return new Object2ObjectArrayMap<K, Collection<V>>(myMap.keySet().toArray(), myMap.values().toArray()).object2ObjectEntrySet().fastIterator();
    }
  }

You're entirely talking nonsense.

@vigna Could you please explain? Just take a look on Object2ObjectArrayMap. Where I am wrong?

Oh God. ARRAY map. I didn't even see it.

You are right in that the copy constructors could iterate over the map entries and build two arrays. I do not think that anywhere in the Java specification the toArray() of keys and values has any constraint on the number of returned elements, so your first solution won't work. But iterating over the entries and filling will. Seems a decent thing to do, I'll implement it and you can test it.

How large is the map?

To clarify — I migrate IntelliJ ultimate/community project from Trove to fastutil.  In some cases I fully rework client code to suit a new API, in some cases preserve as is.
As commended above, the same code that works with java map, doesn't work with fastutil implementation:

This code works for java, but not when multiMap.map here is Object2ObjectOpenHashMap. Because opposite to java, clear clears not only map, but also returned entry set.

So, after migration to fastutil, tests started to fail because of NPE, as entry.getValue() started to returns null. As I don't think that it is a bug in fastutil, I decided to change client code.
Just return iterator of entries, where iterator it is fast iterator of some map.
As I want to reduce code on my side, I decided to just use Object2ObjectArrayMap, as I need only iterator from it.
So, map size doesn't matter. I just use Object2ObjectArrayMap as a convenient way to get fast iterator of entries.
One of the reason why we migrated from Trove to fasutil —  project is not dead . I can submit pull request, but first I want to understand that I don't overlooked something.

OK, I implemented better constructors. Please have a try. (Sorry, I didn't have time for unit tests—later this day).
The same think might be done for sets, but one needs additional constructors, because Collection instances might return the same element twice. This cannot happen with an instance of Map.

@develar Just FYI: map.clear() is required to clear the entrySet() aswell (i.e. var set = map.entrySet(); map.clear(); assert set.isEmpty(); has to hold, because entrySet() is a view on the map. However, the entries themselves are copied by the list construction. The problem rather is that I guess you used fastEntrySet(). new ArrayList<>(map.fastEntrySet()) doesn't make sense, since the "fast entries" are actually a single mutable object. Simply using map.entrySet() should be sufficient. I might be wrong though, then it would be interesting to see the code which went wrong.

However, the entries themselves are copied by the list construction. The problem rather is that I guess you used fastEntrySet()

Thanks for information, but please see implementation of Object2ObjectLinkedOpenHashMap.MapEntry class —
@Override
		public V getValue() {
			return value[index];
		}

So, even if new MapEntry(nextEntry()) a new instance of entry is created, still, on map clear all entries will returns null as value and key.


Bug/improve add close button

this done

@kodcuserkan  On hover, icon background/opacity decreasing, let's remove that hover color change?

also there is this warning/error on terminal.

Both of them fixed

@kodcuserkan in proposals page, check how we do it and it is perfectly centered.

But in this modal, it looks bit off, also maybe icon being set twice for some reason?

centered now


I can't create a new file, the file system is reported as read-only

Dockerfile FROM nvcr.io/nvidia/l4t-ml:r32.4.3-py3
Step 16/19 : RUN cd /usr/local/cuda/targets/aarch64-linux/lib && mkdir 123
---> Running in d0f4ef0fa4c4
mkdir: cannot create directory '123': Read-only file system

/usr/local/cuda is mounted from the host device in read-only mode, so you can't write to it from within the containers.
For more info, please see here:   https://github.com/NVIDIA/nvidia-docker/wiki/NVIDIA-Container-Runtime-on-Jetson#mount-plugins

Currently I have the following version environment
-Libraries:
* CUDA: 10.2.89
* cuDNN: <IP_ADDRESS>
* TensorRT: <IP_ADDRESS>
I hope to make a docker image of the following environment
-Libraries:
* CUDA: 10.0
* cuDNN: 7.5
* TensorRT: 5.1.6
If docker depends on the environment of the host, is it impossible to complete such a mirror

It is currently not supported to use a different version of CUDA/ect than what comes with JetPack-L4T.
However you could try making your own base image and install the CUDA packages inside your container.  What you should do is move/rename /etc/nvidia-container-runtime/host-files-for-container.d/cuda.csv on your host device first (and cudnn.csv, tensorrt.csv), so those CUDA files don't get mounted into your container.

Thanks for your reply, it does not seem easy. The production of nvcr.io/nvidia/l4t-base does not seem to be in this project. I am not sure if the host cuda driver works for the low version cuda calls in Docker.

I finally understand what you mean. After repeated attempts, I achieved the downgrade of CUDA.link


Improve accessibility

Suggestion / feature request
We want to improve the accessibility of the library.
Related

#297

Handled via [IX-155]


Add clarifying comment.

Thanks @jeff-davis . this got obsoleted by some other refactoring work I did, but I went ahead and adapted the comment to fit the new locations (and expanded upon it slightly). I kept you as the author on the resulting commit, see #22.


Frozen daq_scan during acquisition

This issue is random in time and doesn't happen for each scan,  It can happen:

after 60 points as well as after 500 points
with a time flow of 100 + 100ms (time step + time between) or with a time flow of 500 + 5500ms
in my "measurement" preset which contains 3 plugins (vna, lockin move V and lockin viewer) and in my "calibration" preset which contains two other plugins (lockin move H and lakeshore).

In the log there is no error or message when this occurs, the Daq_Scan is just stopped and seems to be waiting for the measurement. The move led is green because the step is finished and the detection led is red because the value is not detected by the daq_scan. Everything is frozen.
Two observations:

If I click on "probe's data acquisition" in the daq_scan, it takes the value of the point of the current scan then move the next step and waits again for the next acquisition.
If I click on "single grab" in the dashboard on the viewer plugin for the signal being acquired, the scan is running again and ends the remaining points normally.

By the way, I have also noticed that for each step of the move plugin, the program sends the "check_position" request three times to which the instrument returns three identical responses.

We found the origin of this issue and find a simple solution by the plugin way, even a solution in the PyMoDAQ structure will be better.
The issue appear with a dual detector scanning (2D scan). Sometimes the two answers comes at the same time from the two detectors make a mistakes between them and PyMoDAQ loose one of them.

With somme nice print() we are able to found that the values read at this time is a numpy.array with “None” inside .

The scan freeze and wait for the good value.
We can continue the scan with a simple clic on “snapshot” a single grab on the dashboard. With this value the Daq_scan become happy and continue with the next step.
The solution we found is to add a condition in our plugin in the “grab data” to say : if the measure is “None” do a single grab in both plugin of the concerned detectors :
from pymodaq.daq_viewer.daq_viewer_main import DAQ_Detector as daqdetector

For one the import of the DAQ_Detector is not possible at the top of one plugin (it will crached the dashboard init) so we import it when the wrong way appear.

Now when the mistakes comes the scan continue with the next step automatically and we can count the error of acquisition ^^. The long automatic acquisition is possible.

The way you did is wrong because DAQ_Detector is an object that must be instantiated. You could do it it self was an instance of DAQ_Detector, but it isn't. Self is an instance of your plugin.
The real issue must be the order in which the communication is made with the instrument. if multiple plugins want to access the hardware at the same time using serial com, maybe there is some ordering issues sometimes. You can ovoid it using the locker primitive of the thread module within the wrapper communicating with your instrument

and then when you need to talk with the instrument, you first acquire the lock (other thread cannot communicate anymore and are in a waiting state) and finally release it when done, so that other threads can communicate.

Thanks for this good way solution.


Revert encoding damage caused to 5e-SRD-Spells.json by 8dacafdf

There was damage caused to the Spells file by conversion between multiple codepages in 8dacafdfd2642f66e0c15c6edcc18cea2f3a0822 (ironically a "review" patch). This PR fixes the damage.

Awesome! Thanks!


Release 2.1.0

Requirements

[ ] Update screenshots and videos
[x] Disable the "Golden Asteroid"
[x] Code release

[x] Write release notes
[x] Tag and publish release on GitHub

[x] Release on Steam (Windows, macOS, Linux)

Also see https://github.com/MovingBlocks/DestinationSol/blob/develop/steam/SteamRelease.md
[x] Upload new build with steampipe
[x] Prepare release announcement
[x] Mark build as live

[x] Release on Google Play (Android)

[x] Write Android release notes
[x] Run release with Fastlane

[x] Release on F-Droid (Android)

[x] Send update merge request to the fdroiddata repository

Extras

[ ] Split warp into separate DLC on Steam

I forgot to close this for over a month. The release was done in April. Screenshots and videos are not important.


{bambootracker,bambootracker-qt6}: 0.6.1 -> 0.6.2

Description of changes
Disabling system RtAudio, requires #245075.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build bambootracker bambootracker-qt6

@ofborg build bambootracker bambootracker-qt6
(what's the commit format required for ofborg to properly pick this up? comma-separated, without the {}?)


Fix testing dimension of D in  EigenDecompositionTest#testDimensions()

Coverage increased (+0.002%) to 90.027% when pulling c1445cf8557ab49dda18825eea1088d0b4e231f1 on hadiidbouk:patch-2 into 34bd1707749c71302207fb2fc0559b6ca301d895 on apache:master.


GraphQL errors are ignored when using pollInterval

Describe the bug
GraphQL errors returned by the server after the first request are ignored when using pollInterval.
To Reproduce
Steps to reproduce the behavior:

Write a apollo query using pollInterval
The server should return a successful result the first time.
The server returns a graphql error the second time.
The error is ignored

Expected behavior
The graphql error should not be ignored. Network errors, if you stop the graphql server for example, are not ignored. If the error occurs for the first query, before it waits to poll, it's not ignored either.
Versions
vue: 2.6.12
vue-apollo: 3.0.5
apollo-client: 2.6.10

Could you please provide a runnable minimal reproduction of this so I can take a look when I have some time? Thanks! :pray:

Sure, I will hopefully get some time for that next year. 🙂

Hi, I ran into this problem as well. It seems that any error from a previous fetch is kept in cache, even if later calls to the GraphQL server don't return any errors anymore. The changes in #1120 seem to fix it for me... @fungiboletus Could you check if this solves it?

Could you check if this solves it?

I'm using the V3 and your change is for the V4. I checked and the code looks quite different. Actually my bug may not exist in the V4.

Oh sorry, my bad :see_no_evil:


Cannot choose bg image on A14

Choosing a background image does not work on Pixel 8, Android 14. The error is displayed: "An error has occurred when choosing media."

I suspect it's similar to the permission error with audio that has just fixed!

This still isn't working for me. I grant it permissions for all media and it opens a chooser, but no matter what image I select I get a blank background.

This still isn't working for me. I grant it permissions for all media and it opens a chooser, but no matter what image I select I get a blank background.

Click on ... -> Browse -> Recent -> Click on image and it should work. I am trying to find a fix until then.


Validation Bulk Fixes

Docs Build status updates of commit 0f14e3f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-services/latest/resourcemanager-eventgrid-readme.md
:bulb:Suggestion
View (azure-java-stable)
Details

docs-ref-services/latest/resourcemanager-eventgrid-readme.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@srnagar
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you


You can turn containment field generators into lamps

Description

AKA CFG lights persist even when off
Reproduction

Fire emitters at a CFG line
CFG line lightens
Turn off emitter
CFG line fades away
CFG is now a cool ass lamp

Screenshots

Additional context

wym this isn't an issue this is a feature:tm:

Kind of a funny unintentional bug but it could be interesting to keep as a feature.

we need better lighting options


increase width of input field

It is covered by buttons (for input value 1)

@iriman What browser are you seeing this in? Seems that different browsers have different behavior here.

I just changed the input to use a constant width so hopefully we don't have to worry about it anymore.

It's Windows 7 with classic theme and latest Firefox


FeatureGates is confusing

Only CreateDir is simulated, but all operations are affected.
We need to check features everywhere.

Maybe we need to extract features into another field instead of at the operation level.

How about removing all operation level features and use global feature instead:

VirtualDir
VirtualLink
VirtualObjectMetadata


My uploads are failing with a 400 Bad Request

Any thoughts on what could cause this?
My config:
bintray {
    user = project.bintrayUser
    key = project.bintrayKey
    publications = ['main']
    pkg {
        repo = 'libraries'
        name = 'grgit'
        desc = 'Groovy wrapper over JGit'
        licenses = ['Apache-2.0']
        labels = ['groovy', 'git']
    }
}

My output:
:bintrayUpload (Thread[main,5,main]) started.
:bintrayUpload
Executing task ':bintrayUpload' (up-to-date check took 0.0 secs) due to:
  Task has not declared any outputs.
Found 0 configuration(s) to publish.
Uploading to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT.jar...
Could not upload to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT.jar: HTTP/1.1 400 Bad Request
Uploading to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-sources.jar...
Could not upload to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-sources.jar: HTTP/1.1 400 Bad Request
Uploading to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-javadoc.jar...
Could not upload to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-javadoc.jar: HTTP/1.1 400 Bad Request
Uploading to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-groovydoc.jar...
Could not upload to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT-groovydoc.jar: HTTP/1.1 400 Bad Request
Uploading to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT.pom...
Could not upload to https://api.bintray.com/content/ajoberstar/libraries/grgit/0.1.0-SNAPSHOT/org/ajoberstar/grgit/0.1.0-SNAPSHOT/grgit-0.1.0-SNAPSHOT.pom: HTTP/1.1 400 Bad Request
:bintrayUpload (Thread[main,5,main]) completed. Took 4.291 secs.

I had the same issue, my case was quite silly:
I changed my bintray password (say, old was X and now is Y), and thought that GPG password is also the new one (Y). So I was getting 400: Bad request because the GPG password i had to use is the old one (X)
Hope it saves you time!


TypeScript Build Watch Mode does not work with compiled assets in public/

The command bin/console typescript:build --watch will watch for changes and (seemingly) compile them, but as long as there is a built source in public/assets, the changes won't reflect in browser.
Deleting public/assets worked for me, --watch now picks up on changes and they're reflected in browser.
I have caching disabled in my browser.

Hello @nitwhiz. This is the normal behavior of asset mapper (https://symfony.com/doc/current/frontend/asset_mapper.html#serving-assets-in-dev-vs-prod). In dev, if you wish to see your changes reflected automatically in the browser, you should not run asset-map:compile and make sure you don't have a public/assets. It seems like you figured out already how to work around this, and since it's not an issue with this bundle I'll close the issue.
Feel free to reopen if you think there really is an issue.


Good First Issues

We need to make this a list of things new people to the project could work on.

Help for the project plan and appropriate theme for the hackathon.
Ideas on getting more people engaged.

Here are some efforts suggested by the team in the most recent TSC.
release document, infrastructure, research on Izoda - spark tooling, what is it main features, automated build(Gradle, Groovy, Zowe CLI etc) - gvblib source for build, static scans, automatic scans, run assembley process for linkedit.  Hackathon ideas what problem, MTM content and what could they do.  Review pages for links and completeness – spelling. Watch training videos for creating test cases on JUnit.  There are examples there.
These issues will be separated into different separate issues to leave this issue open for new idea generation.

Adding - convert Virginia data so it can run as part of the demos we have.


Fix nested window render update

[x] Segments not found.
[x] Flickering.

Fixed initial segments not found error, now the comboxbox inside nested (settings) shows the error.

Accidentally merged the changelog for this already, will merge too, but there are more bugs.


Add support for the TECHBASE NPE X500 M3 board (CM3 based)

Related issue: #292

Can one of the admins verify this patch?

@resin-jenkins ok to test

Hi @adolfogc , thank you for the contribution.
Can you redo the PR as per the commit guidelines from https://github.com/balena-os/balena-raspberrypi#pull-requests ?
Also, can you try to split the changes more like 1 commit per changed file?
Also, can you mark the board as community in the respective .coffee file, like seen in https://github.com/balena-os/balena-jetson-tx2/blob/master/n510-tx2.coffee#L19?

@resin-ci retest

Hi @adolfogc there is one commit which has the commit header on more than 1 line. Can you redo it to only be in 1 line and no longer than 72 chars?

The header of each commit must not exceed 72 characters in length and must be in 1 line only.

Hi @floion, I've fixed the issue with the commit headers.

@resin-ci retest

Hi @adolfogc we still need some changes.

The header and the subject of each commit must be separated by an empty line.

Can you make sure all your commits follow this rule please?

Can you make sure all your commits follow this rule please?

Hi @floion, I just checked using git log, and there's an empty line separating the headers from the bodies, so I'm not sure why the CI check is failing with regards to this.

@adolfogc the problem is that there's a new line between Changelog-entry and Signed-off-by for the commits. Can you remove that empty line in between?

@floion I have rebased and corrected the issue of the blank space between those lines.

@resin-ci retest

@resin-ci retest

Thanks @adolfogc . Have you done other changes? The yocto build fails now (it worked before):

make[3]: *** No rule to make target 'arch/arm/boot/dts/overlays/npe-x500-m3.dtbo'.  Stop.
| arch/arm/Makefile:345: recipe for target 'overlays/npe-x500-m3.dtbo' failed
| make[2]: *** [overlays/npe-x500-m3.dtbo] Error 2
| Makefile:146: recipe for target 'sub-make' failed
| make[1]: *** [sub-make] Error 2
| Makefile:24: recipe for target '__sub-make' failed
| make: *** [__sub-make] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.

@floion No I haven't, I just amended the commit messages. Is there a way to re-run Jenkins?

@resin-jenkins test this please

@floion It worked. I think it was because of my force pushes; each too close to one another in time.

@adolfogc it failed in the same way


使用OpenFile或者OpenReader打开模板文件再修改样式，遇到列值01/03这种SetCellStyle不生效

场景为：导入数据生成错误文件，把第一列文字标红
代码：
conStyle,_:=file.NewStyle({
"alignment":{
"horizontal": "center",
"vertical": "center"
},
"font":{"bold":true,"family":"Times New Roman","color":"#FF0000"}
}) file.SetCellStyle(sheet,"A4","A4",conStyle)
excel中有一列（非第一列）存在：01、03，在file.Save保存后excel会提示此列错误：该数字是文本类型，可能出现计算错误
然后导致SetCellStyle设置的样式不生效。

go version:1.14
excelize:github.com/360EntSecGroup-Skylar/excelize/v2 v2.3.1

go version:1.14
excelize:github.com/360EntSecGroup-Skylar/excelize/v2 v2.3.1

Hi @yunduansing, thanks for your feedback, I have tested base v2.3.2 and it works well, could you provide a spreadsheet .xlsx attachment without confidential info?

Hi @yunduansing, thanks for your feedback, I have tested base v2.3.2 and it works well, could you provide a spreadsheet .xlsx attachment without confidential info?

Any column value exists 03 or 01  then SetCellStyle not work

Any column value exists 03 or 01  then SetCellStyle not work

Hi @yunduansing, note that SetCellStyle will overwrite the style for the cell with the style created by NewStyle, you haven't specified any number_format or custom_number_format when creating a new style.

Hi @yunduansing, note that SetCellStyle will overwrite the style for the cell with the style created by NewStyle, you haven't specified any number_format or custom_number_format when creating a new style.

Hi @yunduansing, note that SetCellStyle will overwrite the style for the cell with the style created by NewStyle, you haven't specified any number_format or custom_number_format when creating a new style.

is there any function for appending style instead of overwriting like SetCellStyle


remediation doesn't work with --query-path

I've create a my own query directory ./assets to stock my custom queries.
I run a scan on a query tests directory that I've write for a custom query.
 kics scan -q ./assets/queries/terraform/aws/cloudfront_min_ttl_is_zero -p ./assets/queries/terraform/aws/cloudfront_min_ttl_is_zero/test/ --report-formats json -o ./

A results file is created in the current directory with the following content :
{
	"kics_version": "v1.6.1",
	"files_scanned": 2,
	"lines_scanned": 56,
	"files_parsed": 2,
	"lines_parsed": 56,
	"files_failed_to_scan": 0,
	"queries_total": 1,
	"queries_failed_to_execute": 0,
	"queries_failed_to_compute_similarity_id": 0,
	"scan_id": "console",
	"severity_counters": {
		"HIGH": 1,
		"INFO": 0,
		"LOW": 0,
		"MEDIUM": 0,
		"TRACE": 0
	},
	"total_counter": 1,
	"total_bom_resources": 0,
	"start": "2022-10-10T21:16:11.970698074Z",
	"end": "2022-10-10T21:16:12.10788034Z",
	"paths": [
		"./assets/queries/terraform/aws/cloudfront_min_ttl_is_zero/test/"
	],
	"queries": [
		{
			"query_name": "Cloudfront cache policy should have a 'min_ttl' attribute set to 0",
			"query_id": "a5b23f6b-605e-42ed-bece-a818447ddd58",
			"query_url": "https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_cache_policy",
			"severity": "HIGH",
			"platform": "Terraform",
			"cloud_provider": "AWS",
			"category": "Sustainability",
			"description": "Cloudfront's cache policy should have a 'min_ttl' attribute set to 0 due to the precedence of this configuration on application response headers.",
			"description_id": "2b7ca79m",
			"files": [
				{
					"file_name": "assets/queries/terraform/aws/cloudfront_min_ttl_is_zero/test/positive1.tf",
					"similarity_id": "beeb99deacbb038db691aa577fe7f56930b6214569e78abf1d38fff224210468",
					"line": 6,
					"issue_type": "IncorrectValue",
					"search_key": "aws_cloudfront_cache_policy[{{positive1}}].min_ttl",
					"search_line": 0,
					"search_value": "",
					"expected_value": "aws_cloudfront_cache_policy[positive1].min_ttl should be set to 0",
					"actual_value": "aws_cloudfront_cache_policy[positive1].min_ttl is set to 10",
					"remediation": "{\"after\":\"0\",\"before\":\"10\"}",
					"remediation_type": "replacement"
				}
			]
		}
	]
}

So, I want to test the remediation command with this following results but kics remediate doesn't accept the --query-path so, here's the following error :
kics remediate --results results.json -v --log-level=TRACE
9:18PM DBG parser.NewBuilder()
9:18PM TRC terraform.tfvars not found on /tmp
9:18PM DBG Looking for queries in executable path and in current work directory
9:18PM DBG helpers.GetDefaultQueryPath()
9:18PM DBG helpers.GetExecutableDirectory()
9:18PM DBG Queries found in /app/bin/assets/queries
9:18PM DBG source.NewFilesystemSource()
9:18PM DBG engine.NewInspector()
9:18PM DBG Custom library common not provided. Loading embedded library instead
9:18PM ERR failed to get results of query a5b23f6b-605e-42ed-bece-a818447ddd58: unable to load querya5b23f6b-605e-42ed-bece-a818447ddd58

Selected remediation: 1
Remediation done: 0

Hello, @jycamier
Thank you so much for being always active 🚀
KICS remediate command does not support --query-path because we did kind of a PoC first:
Usage:
  kics remediate [flags]

Flags:
  -h, --help                  help for remediate
      --include-ids strings   which remediation (similarity ids) should be remediated
                              example "f6b7acac2d541d8c15c88d2be51b0e6abd576750b71c580f2e3a9346f7ed0e67,6af5fc5d7c0ad0077348a090f7c09949369d24d5608bbdbd14376a15de62afd1" (default [all])
      --results string        points to the JSON results file with remediation

Global Flags:
     (...)

However, custom query support makes total sense. Thank you so much for bringing up this matter. PR #5944 will support custom queries for the KICS remediate command 😊
Usage:
  kics remediate [flags]

Flags:
  -h, --help                  help for remediate
      --include-ids strings   which remediation (similarity ids) should be remediated
                              example "f6b7acac2d541d8c15c88d2be51b0e6abd576750b71c580f2e3a9346f7ed0e67,6af5fc5d7c0ad0077348a090f7c09949369d24d5608bbdbd14376a15de62afd1" (default [all])
      --queries strings     paths to directory with queries (default [./assets/queries])
      --results string        points to the JSON results file with remediation

Global Flags:
     (...)

Hi @rafaela-soares
Thank you !
As there's a results.json to make remediation, IMHO, the most consistant way to make the feature is to stock the absolute path of your query maybe.
What do you think about it ?

Hello @jycamier
Thank you so much for the suggestion. I will talk to the team about it.
At the moment, the JSON report does not provide any information regarding the query path.

Hello again @jycamier
We will discuss this question at the next KICS Community Meeting (3 November, 4 pm Lisbon). It would be great if you could attend 😊


[GH-426] - Chef 11 backward compatibility

Description
LWRP Chef-11 backward compatibility. Provides syntax is a Chef 12 feature.
Issues Resolved

https://github.com/chef-cookbooks/jenkins/issues/426

Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thank you for this submission, but I'm not going to pull this in. We are in the process of planning a rewrite for Jenkins 2 that will be Chef 12.5+ compatible. Please use an earlier version of the cookbook and pin your use to that version.

Hello Jennifer
Curious will the new rewrite support chef 11? or will be for 12.5 only.
Thank You
On Mon, Jun 13, 2016 at 10:16 PM, Jennifer Davis<EMAIL_ADDRESS>wrote:

Closed #486 https://github.com/chef-cookbooks/jenkins/pull/486.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chef-cookbooks/jenkins/pull/486#event-691255921, or mute
the thread
https://github.com/notifications/unsubscribe/AHPiEuALKS67Qg1v1RtXIf1NDEu4WoNxks5qLg7zgaJpZM4I0oNu
.


RoR group project: set up your Kanban board

Project link
Team Members: 2
@noelfoka
@Kccendana

Hi @Kccendana  @noelfoka 👋🏼👋🏼👋🏼,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights✅✅✅

[x] Link to the project has been provided👍🏼.
[x] Name of team members has been provided 👍🏼.
[x] The project board contains the appropriate columns as required👍🏼.

Required Changes ♻

[ ] Kindly ensure all cards (tasks) are assigned points. currently, one of your cards doesn't have any point assigned to it😉. Kindly fix that👍🏼. Kindly ensure all cards have points assigned to them👍🏼.

[ ] Kindly ensure all requirements are captured in your project board😉. you currently haven't captured the n+1 requirement😉. Kindly do well to make changes as regards that👍🏼.

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

It is done we are resolve them

Hi @Kccendana and @noelfoka,
APPROVED 🟢
Highlights
✔ All tasks are present
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete!  There is nothing else to say other than... it's time to merge it. :shipit:
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Use Maven central for the AEM as a cloud service SDK

The AEM SDK is now deployed on Maven Central, so there is no need to use an additional Maven repository anymore.

this is great - but on maven central there are not the latest versions?
https://repo1.maven.org/maven2/com/adobe/aem/aem-sdk-api/ -> 2020.5.3360
https://downloads.experiencecloud.adobe.com/content/maven/public/com/adobe/aem/aem-sdk-api/ -> 2020.5.3372

This is caused by an issue with the deployment pipeline - we were trying to deploy the aem-sdk-api and aem-sdk-deprecated-6.5-api together. Since the deprecated artifact had the same version the promotion to Maven Central was rejected, causing the full promotion to fail.
I expect to have a fix for this today and the two repos will be in sync (well, with a small delay of ~10 minutes for Maven Central due to how the deployment process works )

@stefanseifert - the two are now again in sync, and Maven Central will be lagging with at most 10 minutes, but I guess that is acceptable.

thanks! (and yes, 10min is definitely acceptable...)


V4 Roadmap

I have a few goals for v4, and I just wanted to write them down somewhere so everyone can see where we're headed and pitch in if they feel so inclined.

[x] Refactor the test suite. The whole describeSomething approach isn't great because we lose the ability to easily zero in on one test (i.e. use it.only) when that code runs for each type of history we want to test. The main idea behind this refactoring is to get all tests out of these big describe* methods and inline them.
[x] Easier imports. Right now we ask people to import createHistory from 'history/lib/createBrowserHistory' if that's all they need. Let's get rid of the lib so people can just use e.g. history/createBrowserHistory.
[x] Remove "middleware" API (i.e. all use* functions). It's an unnecessary abstraction that only creates complexity. In practical terms, there are only ever going to be a few middlewares, not all of which are applicable to all histories.
[x] Move path and query parsing out of core. Our location objects will be { path, state, key } and that's it. Any other parsing can be done outside core.
[x] Use strings for location.action (as opposed to constants that need to be imported)
[x] Switch to just using window.history.state for browser history. Session storage has too many caveats.
[x] Remove location.state from hash history locations. This is a hack that's just not worth maintaining for older browsers.
[x] Remove support for basename in memory history.
[x] Expose canGo functionality in memory history. Released in v3.2.0.

If you're interested in helping w any of this work please let me know. It's going to be my main focus over the coming week.

ok, this work is done and released in v4.0.0-0. If anyone's listening, please give it a shot.


Set --state-dir on containerd

I was trying to run an instance of the daemon with something like this:
dockerd \
    -g /tmp/dockerdev \
    --exec-root=/tmp/dockerdev \
   ...

and I got the following error
FATA[0000] open /run/containerd/events.log: permission denied

which was unexpected, because I was setting all the paths to /tmp/dockerdev.
What I did
Set the containerd --start-dir arg to the stateDir so that the events.log ends up in the path under the docker exec root. After I made this change I was able to run the second instance of the daemon.

ping @mlaventure @tonistiigi PTAL

LGTM

I dunno what's going on, but all CIs fail :(

Looking at the CI fail we probably need a special subdirectory for it to avoid collisions between libcontainerd/containerd data when they use same IDs.

Ok, I made it a subdir, and CI seems to be happy now

LGTM

LGTM
gcc is actually green, but couldn't notify
20:36:19 Finished: SUCCESS


Ionic Team there is lots of issues with ionic. I feel waste of time using iconic.

Ionic Team there is a lot of issue with ionic.
I feel waste of time using iconic.

There is no proper documentation

Base64 , InAppBrowser, InAppBrowserOptions , FileOpener and all file related library does not work.

It take days on forum to get a answer (Even the posted  answer is not correct)

No proper example are provided.

Issue are pending from months but no solution.

Cannot open PDF in android.

JavaScript functions are not working

Please reply, why there is so much issue on this platform.
If you cannot solve problems or give update please stop doing drama and tell us clear so we can move to other framework.

Ionic is an open source community that develops a collection of UI components to build applications, we don't give free courses of software development.

Github issues should be used by users to report legit issue reports.

Github is not the place for trolling

Any member of the community includes the Ionic Team needs to follow the Code of Conduct.

Be nice!

Closing issue for now following the CoC
https://github.com/ionic-team/ionic/blob/master/CODE_OF_CONDUCT.md
I encourage you to approach your questions with a nicer tone! check out the forum or our slack channel.


[file_selector] Import Linux implementation from FDE

Imports the existing Linux implementation from the flutter-desktop-embedding repository, with very minor changes for the move:

Updated the repo metadata (issue link, repository link).
Reordered pubspec.yaml to match repo conventions.
Updated the READMEs to match repo standards.

This change says it's endorsed even though it's not yet because as soon as this lands I'll do a follow-up to endorse it; doing it up-front avoids an extra PR to change it later (or forgetting to do so; see below).

Ran the autoformatter.
Added missing copyrights in generated code, and year-standardized the existing copyrights to match the repo.
Updated the LICENSE file to match repo standard.
Bumped the version to release the updated version.

This also opportunistically makes some minor non-code cleanups to the Windows and macOS implementations, noticed while I was making sure everything was consistent:

Updates their READMEs to indicate that they are endorsed, which I apparently never did.
Moves flutter_test to dev_dependencies, rather than accidentally being in dependencies. (In practice, not a big deal since it's from the SDK, but there's no reason for it to be in the non-dev section.)

Part of https://github.com/flutter/flutter/issues/70221
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

The first commit has zero changes from the already-reviewed FDE implementation, so you only need to review the deltas from that (unless you want to fully re-review the plugin).
Let me know if you want me to split out the non-Linux bits. They seemed minor enough to toss in, but I could easily make a new PR.


allow React 15 and update styles to comply with React 15

This repo uses semantic-release, would you mind amending your commit message to match it?

@gaearon ohh … done, let me know if (package, style) works. If not whats the convention? btw I probably add a contributors sections to the readme after this one :smile:

@gaearon can you make a new release on npm? see https://www.npmjs.com/package/redbox-react

Looks like semantic-release opted not to ship a release because the label is "chore" I think only feat and fix result in releases?

Sorry everyone, please see https://github.com/KeywordBrain/redbox-react/issues/50. It's now released.


[backport-1.21] - Send systemd notifications for both server and agent

#3430 needs to be backported to the release-1.21 branch.
Original RKE2 issue: https://github.com/rancher/rke2/issues/989

Validated using k3s version v1.21.2-rc1+k3s1


[F-Req] Support roles in ticket system

It would be a good idea to add multiple support roles in the ticket system as in that case staff would be able to help people out or you can just make a Ticket role which can be assigned to people
Something more would be the ability to add users into the tickets too in case people want to add multiple members inside that ticket

It would be a good idea to add multiple support roles in the ticket system as in that case staff would be able to help people out or you can just make a Ticket role which can be assigned to people
Something more would be the ability to add users into the tickets too in case people want to add multiple members inside that ticket

Hello friend! I'm finishing some personal projects. and I'm going to reinforce this project, add more features and change the name, I'll add your idea too! Thanks


Android 14 support

There are some changes introduced with Android 14 and streaming app doesn't work

Done


Clicks on mostly on left side of the blum app

App clicks mostly on the left side of the blum app, collecting around ~ 100-120 points per game, can we fix it somehow?

I collected around 190~200.  Maybe you could close other apps and size down your blum app window so it can move the mouse faster from one position to another, idk, try putting it in the center


Add optional timeout argument to probe

Popen.communicate() supports a timeout argument which is useful in case
there is a risk that the probe hangs indefinitely.

@magnusvmt couple of questions from an interested bystander -

I don't think python 2.7 has the equivalent parameter, so this appears to break Python 2 and PyPy compatibility, see the failing check above. What's the best way to resolve that?
ffprobe also takes a timeout parameter, does adding an argument for it here prevent it from being passed down?

What's the best way to resolve that?
Wait 2 months, then Python 2.7 will no longer be supported.

Maybe something like this:
communicate_kwargs = {}
if timeout is not None:
    communicate_kwargs['timeout'] = timeout
out, err = p.communicate(**communicate_kwargs)

Of course, if someone specifies timeout on Python 2, they'll get an error, but that's probably not worth worrying about so long as the tests pass.
Relatedly, there should be a test for use of this newly-added timeout param, at least for Python >= 3

@magnusvmt couple of questions from an interested bystander -

I don't think python 2.7 has the equivalent parameter, so this appears to break Python 2 and PyPy compatibility, see the failing check. What's the best way to resolve that?

Fixed with the code @kkroening provided, thanks!

ffprobe also takes a timeout parameter, does adding an argument for it here prevent it from being passed down?

Does it really? I couldn't find anything about it here https://ffmpeg.org/ffprobe.html

@magnusvmt it's not available on every source, but it's there for a few.
ffprobe -i https://svs.gsfc.nasa.gov/vis/a010000/a013400/a013425/13425.Mercury.transit2019V3_1YouTube4k.mp4 -timeout 10000

will actually time out as opposed to
ffprobe -i https://svs.gsfc.nasa.gov/vis/a010000/a013400/a013425/13425.Mercury.transit2019V3_1YouTube4k.mp4

Merged. This will be included in the next release. Thanks!

Was this ever released to pypi ?


Omniauth with multiple models

Hi I have look into this wiki
https://github.com/plataformatec/devise/wiki/OmniAuth-with-multiple-models
the thing is, it did not tell how do we know the outh for which model?
Let say I have User and Employee classes.
If both directed to this get "/auth/:provider/callback" => "autenthications#create"
How do we know whether a client/user register for User or Employee?
Hope there is a clear explanation about this.
Thanks

The wiki is maintained by the community. So if there aren't any up to date instructions, we recommend you to explore the solution yourself and hopefully contribute your findings back!


unix: remove 1.x-compat code from fallback barrier

This PR removes code that had the sole purpose of maintaining ABI compatibility with older v1.x versions.
fixes: #854

Please target it at master instead. v1.x must remain ABI compatible.

@saghul of course. The original PR has not landed on master however, so it makes little sense to rebase this onto master until it lands. I could cherry pick the other commits in to this PR, but I think it's cleaner to wait until v1.x is pulled into master again.

I think it's cleaner to wait until v1.x is pulled into master again.

Yep. Let's do that after the next release then.

Hey @kthelgason I just merged v1.x into master, feel free to send the PR targetting master.


Update Rust APIs

This is an early version of refactored NTT on CUDA and Rust sides. Some things I would like to note:

Twiddles. They are generated by InitDomain function from one element. The details of how they are created and stored are purposefully hidden (because their implementation will likely change in the near future with our new NTT version). Domain class which stores twiddles is also a singleton which can only be initialised once (I assume that twiddles of a curve don't change during program execution), though I guess the way it's implemented is not thread-safe, need to fix that. It's currently not possible to initialise default icicle twiddles, I thought that maybe it's more of an error-prone distraction than a convenience though let me know if you disagree.
As discussed offline, NTT is now out-of-place which helps caller manage data allocations and IMO makes for more intuitive calls when inputs/outputs are on different devices.

Everything is super raw for now and there are several obvious things to do (which are in progress rn) like creating more tests, merging in main and adding the rest of the curves to Rust. There are even several cases where NTT is still incorrect which I'll solve as tests are added for these cases. That said, there are several problems I want to solve but am not sure how:

Making Rust calls more safe. Using MSMs as an example, current call accepts slices which might be either device or host slices. And values like cfg.are_points_on_device and cfg.are_scalars_on_device and set independently which might lead to failures inside CUDA. I guess one solution would be to explicitly mark where a slice lives, something like

pub enum HostOrDevice<T> {
    Host(T),
    Device(T),
}

pub fn msm<'a>(
    scalars: &HostOrDevice<[ScalarField]>,
    ...
)

Using notation from the previous point, I guess it's more idiomatic for Rust to return the value wrapped into Result, so the return type should not be CudaResult<()> but rather CudaResult<HostOrDevice<[G1Projective]>>.
About errors: for now all the functions in Rust return Result<T, CudaError> where CudaError is simply a wrapper around cudaError_t. But we're not limited to just CUDA errors. What if for example the number of points and scalars in MSM aren't equal, of maybe the size of NTT is too large for a given curve? I don't think actual error handling is in the scope of this PR but at least modelling the types would be nice (I guess it needs to be done on CUDA side?).
I certainly don't like how currently functions like msm and ntt are just floating around in Rust unconnected to anything generic. We just won't be able to write anything that accepts curve as a generic parameter this way. But I'm not sure about the design, also I don't think this can be done in C++ and then somehow mapped onto Rust? I guess we need Rust-native code with traits and all that.
What do you think about tests in curve crates, how do we minimise the amount of copy-paste? I would go with some mix of generic functions and macros. Something like: first write a function (generic over field) that checks a number of, say, NTT-related conditions inside core crate, then unify all the NTT tests into one macro and then just invoke this macro from your curve crate. This way most of the logic would be outside of macros, plus generic tests would serve as tiny PoCs of viability of the generic design mentioned in the previous point.

@vhnatyk @jeremyfelder @ChickenLover wdyt?

@DmytroTym
Twiddles: for halo2 integrations it is a default to have 2 different omegas in a domain. So when we did the integrations, we had to create 2 sets of twiddles separately

@ChickenLover oh...
These are not domains of different size, not cosets, but two completely distinct subgroups?

@ChickenLover oh... These are not domains of different size, not cosets, but two completely distinct subgroups?

never mind. There are two subgroups, but one of them is itself a subgroup of a bigger one, so I guess it's ok

        let mut extended_omega = F::ROOT_OF_UNITY;

        // Get extended_omega, the 2^{extended_k}'th root of unity
        // The loop computes extended_omega = omega^{2 ^ (S - extended_k)}
        // Notice that extended_omega ^ {2 ^ extended_k} = omega ^ {2^S} = 1.
        for _ in extended_k..F::S {
            extended_omega = extended_omega.square();
        }
        let extended_omega = extended_omega;
        let mut extended_omega_inv = extended_omega; // Inversion computed later

        // Get omega, the 2^{k}'th root of unity (i.e. n'th root of unity)
        // The loop computes omega = extended_omega ^ {2 ^ (extended_k - k)}
        //           = (omega^{2 ^ (S - extended_k)})  ^ {2 ^ (extended_k - k)}
        //           = omega ^ {2 ^ (S - k)}.
        // Notice that omega ^ {2^k} = omega ^ {2^S} = 1.
        let mut omega = extended_omega;
        for _ in k..extended_k {
            omega = omega.square();
        }

This is how they are computed in the halo2 code

@ChickenLover yup, that's supported

@DmytroTym
Regarding HostOrDevice enum - I think this is a must. One should have explicit control over data movement and it should be visible in code. We can also detect some errors at the compilation phase if we do that.
Regarding return types - I think that hiding as much CUDA specific details is always better for us, despite situations like unexpected CUDA errors or CUDA related configuration. Following this logic, maybe it would be a good idea to have our own structs for the Result and Error type.
For the error handling - we definitely want to design error classes on the C++ side. We can do something as simple as error_code + string message and, if needed, wrap them with the wrapper language native structs.
Regarding floating msm and ntt functions: maybe we can define MSM and NTT as traits and implement them for different curves with macros?
Regarding tests - I really like what you described. If you'll make a draft PR that implements that idea - that would be nice


I suggest to change the name

Description
Changing the name of this crate from palette to omelete

Motivation
Palette is a name that can describe the crate functionality, that's the problem, names that describe functionality are bad, that's why we like a lot more names like McDonalds, McDonals could sell a lot of things, it could sell air bending machines!  Thanks for reading

Hi, thank you for the proposal and the great illustration that really shows the benefits of a name change, but I'm afraid I have to decline. I do agree, though, that omelettes have a lot of good properties and open up for a wide array of possibilities, not to mention other fun activities you can have with eggs.
However, I think you may be basing this proposal on a misunderstanding. The word "palette" is already ambiguous and doesn't say exactly what the library does. Not only can it refer to the painter's tool, but it may also have more figurative meanings. And even as a reference to the board on which a painter may choose to put dollops of paint, it is only relevant by a couple of steps of association. If you also include various homophones, such as "pallet" and "palate", the palette of possibilities grows even more.
That said, I'm not sure I see how "omelette" would be allow widening the possibilities, compared to "palette". It wouldn't include color management, would it? The same way "palette" wouldn't seem to include egg management. Otherwise I would argue that "palette" is an equally flexible name.
But for the sake of backwards compatibility (the lib has been around for a while) and due to the fact that I have grown pretty fond of it, I will keep it for now. The name "omelette" remains up for grabs for now. Maybe I decide to pivot completely some day and name it "pirouette" instead.

Yes, I guess leaving the name is good too :(


SilverStripe 4+ support

We should introduce SilverStripe 4 support, my thoughts on this is that we no longer provide a language plugin that includes the SilverStripe core modules but instead we add the vendor folder as the library path. That way we no longer need to supply the updated library but still function as normal. We'll need some kind of logic that looks outside the current project to attempt to find the vendor folder, for modules and themes it should only be two up. For the app/mysite project it should only be one up. Perhaps one way we find it is to A: limit the depth to look up the directory tree and B: look for the composer.lock as a verification step along with the vendor/silverstripe/framework folder existing. This should then be stored.

[x] New Language Library Lookup Style based on finding the vendor folder
[x] New Templates for SilverStripe 4
[x] Bump PDT version requirement to support DataObject::class and not throw errors

We should also have the tests view not work in SilverStripe 4+ projects as that UI is not available.

For module projects we'll need to come up with a way to include the vendor folder but not include the project itself.

done


Comparative slice finder: disallow non-numeric values as target metrics

I got this confusing result from the comparative slice finder:

This was due to human error where I selected "output" as the target metric, which doesn't make any sense because "output" is a string. It’s not shown in the non-comparative slice finder for some reason, so I don’t know where the consistency comes from.
It would be good to not allow non-numeric values as the "target metric" in the comparative slice finder to prevent this kind of error.

We calculate difference in the comparison view for non-numeric columns as a 1 or 0 same or different. So you can actually use it as a metric column and find slices where the models disagree the most for a given column.
Maybe we can change the name or tooltip to clarify this? Or does that make sense?

Ah, that's an interesting idea! But yeah, changing the name and tooltip would make sense. The tooltip right now specifically says the function is continuous :)


Missing few values in Terraform config of Monitor Groups

Hello,
When I do GET for monitor_groups in site24x7 it got json with user id values, notification profile id and health profile id ,...but same when I tried to create new monitor groups through Terraform why those values not mentioned in provder documentation to use and I see if I use also still it not accepting...Do we have any issue or any other way...and one more thing why Terraform import not supporting for monitor group. It will support or am I right it will not if that's the case of importing instead of recreating.

@kalyangitnew Thank you for raising this issue. We have fixed it in the latest version.

Can you give me the version you are talking about i didn't see any new version

One more thing in my issue how the import for pagerduty integration, slack integration, user groups and monitor groups not working.. it would be happy if we have feature I feel that I include in my issue

You want me to open new issue and I feel very happy all the resources which were allows importing...I see oauth providers webtoekn and few authentications are not by Terraform ?

Can you give me the version you are talking about i didn't see any new version

Please refer - https://registry.terraform.io/providers/site24x7/site24x7/latest

One more thing in my issue how the import for pagerduty integration, slack integration, user groups and monitor groups not working.. it would be happy if we have feature I feel that I include in my issue

Imports should work in the latest version. Please let us know if you face any issue.

One more thing in my issue how the import for pagerduty integration, slack integration, user groups and monitor groups not working.. it would be happy if we have feature I feel that I include in my issue

Imports should work in the latest version. Please let us know if you face any issue.

Ok

One more thing in my issue how the import for pagerduty integration, slack integration, user groups and monitor groups not working.. it would be happy if we have feature I feel that I include in my issue

Imports should work in the latest version. Please let us know if you face any issue.

It will be some what happy if we have all documentation how to use import in provider documentation..and want to check import works for all I raised above we need to look(pagerduty integration, slack integration, user groups and monitor groups)


Install error: failed to compile `robonomics v0.3.2

ens@ens-nuc-worker:~$ cargo install --force --git https://github.com/airalab/substrate-node-robonomics robonomics
Updating git repository https://github.com/airalab/substrate-node-robonomics
Installing robonomics v0.3.2 (https://github.com/airalab/substrate-node-robonomics#67c179fc)
Updating crates.io index
Updating git repository https://github.com/paritytech/substrate
error: failed to compile robonomics v0.3.2 (https://github.com/airalab/substrate-node-robonomics#67c179fc), intermediate artifacts can be found at /tmp/cargo-installinLvG1
Caused by:
no matching package named substrate-client found
location searched: https://github.com/paritytech/substrate#9edfc244
did you mean: substrate-cli, substrate-client-db
required by package robonomics v0.3.2 (https://github.com/airalab/substrate-node-robonomics#67c179fc)
ens@ens-nuc-worker:~$

Could you check v0.4.0 release?

Sure, I saw new commit, so I can just repeat quick start? If yes, then we have another problem :)
ens@ens-nuc-worker:~$ cargo install --force --git https://github.com/airalab/substrate-node-robonomics robonomics
Updating git repository https://github.com/airalab/substrate-node-robonomics
error: could not find robonomics in https://github.com/airalab/substrate-node-robonomics

Could you try to install latest rust via https://github.com/paritytech/substrate#61-hacking-on-substrate

Solved


Manual search provides duplicate results

It seems DocSearch is indexing duplicate results, result for v1.11.3 will show up before the one pointing to the latest version.

Also due to #1801 docs for versions before v1.12.1 doesn't provide a working edit link.

Well, looks like the issue has been resolved.


List the slsa/v2* formats in the in-toto set

Changes
By listing the slsa/v2* payload formats in the in-toto attestation set, the storage backends are able to handle them properly. For example, without this change, the OCI backend ignores the slsa/v2alpha1 format altogether.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

@chitrangpatel, your feedback here would be greatly appreciated! :pray:

/lgtm Thanks!

/lgtm


HTTP: Implement persistent connections (keep-alive) etc.

This PR implements feature request #14004.
The proposed semantics of the new feature implemented here is as follows.
Both at API and at CLI level (for the CMP app only, so far) there is a new parameter/option: keep_alive.

0 means that HTTP connections are not kept open after receiving a response, which is the default behavior for HTTP 1.0.
1 means that persistent connections are requested.
2 means that persistent connections are required, i.e., in case the server does not grant them an error occurs.

For the CMP app the default value is 1, which means preferring to keep the connection open.
For all other internal uses of the HTTP client (fetching an OCSP response, a cert, or a CRL) it does not matter because these operations just take one round trip.
If the client application requested or required a persistent connection and this was granted by the server,
it can keep the OSSL_HTTP_REQ_CTX * as long as it wants to send further requests and OSSL_HTTP_is_alive() returns nonzero,
else it should call OSSL_HTTP_REQ_CTX_free() or OSSL_HTTP_close().
In case the client application keeps the OSSL_HTTP_REQ_CTX * but the connection then dies for any reason at the server side, it will notice this obtaining an I/O error when trying to send the next request .
This feature addition requires extending the HTTP header parsing and rearranging the high-level HTTP client API.
In particular:

Split the monolithic OSSL_HTTP_transfer() into OSSL_HTTP_open(),
OSSL_HTTP_set_request(), a lean OSSL_HTTP_transfer(), and OSSL_HTTP_close().
Split the timeout functionality accordingly and improve default behavior.
Extract part of OSSL_HTTP_REQ_CTX_new() to OSSL_HTTP_REQ_CTX_set_expected().
Extend the local struct ossl_http_req_ctx_st accordingly.

Also extend related diagnostic output for debugging.
Use the new feature for the CMP client,
which requires extending related transaction management of CMP client and test server.
Related further more general improvements (in separate commits) included because they are related:

OSSL_HTTP_get(): Do not close connection if redirect to same server
OSSL_HTTP_REQ_CTX_add1_headers(): Fix use with host == NULL (relative URLs)
OSSL_HTTP_transfer(): Fix error reporting in case rctx->server == NULL.
Also improve doc of OSSL_parse_url() and OSSL_HTTP_parse_url()
Generalize API to arbitrary request and response contents
~Introducing OSSL_HTTP_i2d() and OSSL_HTTP_d2i() makes the API more clear and modular.~
Allow streaming of request data (for POST method).
Also clean up OSSL_HTTP_REQ_CTX_nbio() states and make it more efficient.
Allow streaming of response data (with possibly indefinite length).
Also clean up max_resp_len and add OSSL_HTTP_REQ_CTX_get_resp_len()
Rename maxline parameter to buf_size for clarity.
Rename internal fields and functions in http_client.c for consistency.

Checklist

[x] documentation is added or updated
[x] tests are added or updated

When submitting this PR some 2 days ago, I forgot to mention details about the proposed semantics of the new feature. Here they are:

If keep_alive is 0 then HTTP connections are not kept open after receiving a response, which is the default behavior for HTTP 1.0.
If the value is 1 or 2 then persistent connections are requested.
If the value is 2 then persistent connections are required,
i.e., in case the server does not grant them an error occurs.

For the CMP app the default value is 1, which means preferring to keep the connection open.
For all other internal uses of the HTTP client (fetching an OCSP response, a cert, or a CRL) it does not matter because these operations just take one round trip.
If the client application requested or required a persistent connection and this was granted by the server,
it can keep the OSSL_HTTP_REQ_CTX * as long as it wants to send further requests and OSSL_HTTP_REQ_CTX_is_alive() returns nonzero,
else it should call OSSL_HTTP_REQ_CTX_free() or OSSL_HTTP_close().
In case the client application keeps the OSSL_HTTP_REQ_CTX * but the connection then dies for any reason at the server side, it will notice this obtaining an I/O error when trying to send the next request .

@openssl/otc, is there already someone willing to review this?
This must get in before feature freeze, also due to the API changes.

BTW, I also have some HTTP client API streamlining and generalization in the pipeline to be submitted as follow-up;
would be good if this will make it into 3.0 as well...

I meanwhile found that specific tests for the new keep-alive feature can be added in a rather straightforward way, so done this as well.

Also added a couple of related small fixes of the HTTP client implementation,
mostly regarding the special case of relative URLs, which came up due to the new tests.

Added a fixup on the documentation of OSSL_HTTP_REQ_CTX_set_expected(),
more clearly explaining the default behavior if this new low-level HTTP client API function is not used.

Since so far I have not seen any reaction on this PR that would indicate that someone has started reviewing this,
I've used the time to further generalize and actually simplify the high-level HTTP client API by making the OSSL_HTTP_{get,transfer}_asn1() functions independent of the request and response content type.

On this occasion I've updated the NEWS.md and
extended the CHANGES.md entry on the HTTP client as follows:
   It supports arbitrary request and response content types, GET redirection,
   TLS, connections via HTTP(S) proxies, connections and exchange via
   user-defined BIOs (allowing implicit connections), persistent connections,
   and timeout checks.  See L<OSSL_HTTP_transfer(3)> etc. for details.
   The legacy OCSP-focused (and only partly documented) API
   is retained for backward compatibility, while most of it is deprecated.

@openssl/otc, I am getting more and more concerned about how to get this PR approved and merged before the public API / feature freeze, which is going to be in 16 days from now.
This PR, submitted 6 days ago, implements a feature discussed in #14004. It is critical for one of our customers in order to be able to make their product compliant with ERTMS/ECTS requirements by UNISIG.
Unfortunately, so far I did not receive any reaction on it, while OTOH the deadline for getting public API changes included into 3.0 is approaching rapidly.
How to solve this?
Would it make sense for instance if I carve out the pure API changes such that they are reviewed and approved hopefully quicker and are safely merged before the deadline,
and then add the internal feature implementation as well as the related tests and documentation later (hopefully already into beta1, otherwise during the beta phase)?

Rebased again to fix simple merge conflicts

great work

Pleased to hear!

Thanks @FdaSilvaYY for reporting those nits; fixed them.

Carved out an "API-only" PR: #15147 - does that help reviewing?

If it helps, once this PR has been rebased on #15147 (when that has been merged)
I could further split this PR into

the client-side changes
the changes to the test server and the new tests for the client

Rebased, which was not a good idea at the moment.
The new check_update CI failure is unrelated.

In order to get rid of the unrelated CI failure on check_update
I had to add an artificial commit for updating the FIPS checksums
since apparently this meanwhile required and someone forgot to do so.

Rebased; prepared for rebasing on meanwhile approved #15147 (which extracted the API changes).

@t8m, finally I've finished rebasing this PR on the meanwhile merged #15147,
which was much more work than expected due to many non-trivial conflicts.
So this PR is ready for review again.

BTW, the number of lines changed as reported above but GitHub: +1,480 −878 is misleading
because there are some intermediate changes among the included commits.
Yet git diff upstream/master --stat correctly reports
 NEWS.md                                                |   6 +-
 apps/cmp.c                                             |  73 +++++--
 apps/cmp_mock_srv.c                                    |   3 +-
 apps/include/apps.h                                    |   1 +
 apps/include/http_server.h                             |  23 ++-
 apps/lib/apps.c                                        |   7 +-
 apps/lib/http_server.c                                 | 126 +++++++++---
 apps/ocsp.c                                            |  14 +-
 crypto/cmp/cmp_ctx.c                                   |  17 +-
 crypto/cmp/cmp_http.c                                  |  37 +++-
 crypto/cmp/cmp_local.h                                 |   2 +
 crypto/cmp/cmp_server.c                                |  25 ++-
 crypto/err/openssl.txt                                 |   2 +
 crypto/http/http_client.c                              | 663 ++++++++++++++++++++++++++++++++++-------------------------
 crypto/http/http_err.c                                 |   4 +
 crypto/ocsp/ocsp_http.c                                |  24 ++-
 crypto/x509/x_all.c                                    |   2 +-
 doc/man3/OSSL_CMP_CTX_new.pod                          |  13 +-
 doc/man3/OSSL_CMP_SRV_CTX_new.pod                      |   4 +
 doc/man3/OSSL_HTTP_REQ_CTX.pod                         |   6 +-
 doc/man3/OSSL_HTTP_parse_url.pod                       |   8 +-
 doc/man3/OSSL_HTTP_transfer.pod                        |   3 +-
 include/openssl/http.h                                 |   4 +-
 test/http_test.c                                       | 187 +++++++++++++----
 test/recipes/80-test_cmp_http_data/test_connection.csv |  92 +++++----
 25 files changed, 883 insertions(+), 463 deletions(-)

@t8m, did you notice that #15221 comprises of four initial commits of this PR?
I thought that providing them could ease reviewing.

I could try further splitting up this PR to help reviewing,
but on the other hand this can cause quite some extra effort
and would certainly prolong the overall process,
and we are running out of time since the whole thing should be merged within a week from now :frowning_face:

Or not merged until later :)

Or not merged until later :)

I did not get what you mean by this?

BTW, what is the exact terms of the feature/API freeze planned for May 20th?
No changes to any file in include/openssl?
Can additions to implementations, apps, documentation, and tests still be done thereafter?

Can additions to implementations (including internal headers), apps, documentation, and tests still be done thereafter?

Missing/incorrect documentation is considered a bug so that is fine. Adding new tests is also fine. Changes to internal headers (e.g. to fix a bug) are ok.
New features are not ok. So adding new capabilities to apps etc would not be allowed.

New features are not ok. So adding new capabilities to apps etc would not be allowed.

Thanks for the clarification.
So most of this PR is urgent to handle before the deadline.

Would it help for now if I remove the test additions and minor bug fixes from this PR?
They make up roughly 20% of the total number of changed lines.

Thanks @FdaSilvaYY for your comments - handled all of them.

The new CI failure is unrelated.

Hmm, the fips checksum labeling does not work well if the branch is not freshly rebased.

Hmm, the fips checksum labeling does not work well if the branch is not freshly rebased.

Rebased (without squashing recent fixups).

Can I somehow rebase this PR already now (before merging to master in 24 hours) on 15221?

As the #15221 will be changed when merging due to the commit annotations, there is no point.

I see.
Is there anything else I can do now to ease reviewing this PR?

Just nits. Otherwise great work!

Nits fixed. Pleased to hear :tada:

This will require a rebase after #15251 is fixed. The approval holds assuming the rebase is clean and CI passes.

This will require a rebase after #15251 is fixed.

Done.

The approval holds assuming the rebase is clean and CI passes.

This went fine.

Merged - thanks a lot to all to contributed to being able to merge this PR in time!


Add a rename / cleanup that changes the source folder

Feature Request
If you have two or more data sources, the ability to transition from one source to a chosen one during a Rename/Cleanup would be a nice feature.
Example:
Two data sources:
\server\temp\movies
\server\movies
Performing a Rename/Cleanup on:
\server\temp\movies\empirestrikesback
Would result in:
\server\movies\The Empire Strikes Back (1981)

we've discussed that several times:
a datasource is some sort of sandbox for us - we will not support moving files in/out of a datasource


TimeProfiles are unique per region

before
Booting up an appliance in a region with replication enabled blows up when running seeds.
activerecord/lib/active_record/validations.rb:78:in `raise_validation_error'
activerecord/lib/active_record/validations.rb:50:in `save!'
activerecord/lib/active_record/attribute_methods/dirty.rb:30:in `save!'
activerecord/lib/active_record/transactions.rb:324:in `block in save!'
activerecord/lib/active_record/transactions.rb:395:in `block in with_transaction_returning_status'
activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:232:in `transaction'
activerecord/lib/active_record/transactions.rb:211:in `transaction'
activerecord/lib/active_record/transactions.rb:392:in `with_transaction_returning_status'
activerecord/lib/active_record/transactions.rb:324:in `save!'
activerecord/lib/active_record/suppressor.rb:45:in `save!'
activerecord/lib/active_record/persistence.rb:51:in `create!'
app/models/time_profile.rb:29:in `seed'
lib/evm_database.rb:71:in `block (2 levels) in seed'
lib/evm_database.rb:60:in `each'
lib/evm_database.rb:60:in `block in seed'
lib/extensions/ar_table_lock.rb:21:in `block (2 levels) in with_lock'
lib/extensions/ar_table_lock.rb:21:in `block in with_lock'
activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:234:in `block in transaction'
activerecord/lib/active_record/connection_adapters/abstract/transaction.rb:189:in `within_new_transaction'
activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb:234:in `transaction'
activerecord/lib/active_record/transactions.rb:211:in `transaction'
lib/extensions/ar_table_lock.rb:15:in `with_lock'
lib/evm_database.rb:59:in `seed'
lib/evm_database.rb:47:in `seed_last'
app/models/miq_server.rb:260:in `start'
lib/workers/evm_server.rb:65:in `start'
lib/workers/evm_server.rb:92:in `start'
lib/workers/bin/evm_server.rb:4:in `<main>'
activerecord/lib/active_record/validations.rb:78:in `raise_validation_error': Validation failed: Description has already been taken (ActiveRecord::RecordInvalid)

after:
A time profile is created in the local region, but the descriptions are only made unique per region.
/cc @Fryguy @jdeubel This is my take of the problem

Looks like the bug was somewhere deeper.
/cc @Fryguy I don't feel comfortable putting this in at this time. But the current logic of using a time profile from another region seems suspect.
closing for now.


Clean up and refactor input generation to avoid several issues with artifact

This PR refactors part of an input downloading and generation script and paves the road for an extensive library of higher order functions for input/build scripts, as well as a more automated tool a la Rattle for parallel + incremental bash build scripts.


Corrections and interpolations emerging from a rhythmite-marlpde comparison

The correct timeframe from the marlpde hdf5 file did not seem to be selected from the call to plotSpatialPDE, the complete Pandas dataframe was returned instead. Now only the selected time from that dataframe is returned.
The marlpde values are now interpolated to the rhythmite grid.
(As a next step, one might also want to include the marlpde support cells, using the ._datafull attribute, in which case all rhythmite nodes can be included in the interpolation. See this py-pde doc for background.)
The sign of the residuals should also be shown --> abs removed, but only for the rhythmite-marlpde differences.
No vertical limits on the plots --> ylim removed.

I am at a workshop in Brussels until Wednesday evening so I am not sure I will have time to look at it before my return, sorry for that :-(

Oh no! Forgot about this completely. Sorry. Here we go.


add page break

Codecov Report

Merging #259 (7687697) into master (dd5285c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage     80.43%   80.43%
  Complexity      988      988
=========================================
  Files           146      146
  Lines          2842     2842
  Branches        338      338
=========================================
  Hits           2286     2286
  Misses          478      478
  Partials         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5285c...7687697. Read the comment docs.


Something went wrong in the Aggregator service

This issue is a note to say that I'm aware of errors in the update_coordinator that ends up with all of the entities in the integration unavailable. You might see an error such as below:

Logger: custom_components.family_safety.coordinator
Source: helpers/update_coordinator.py:235
Integration: Microsoft Family Safety (documentation, issues)
First occurred: 16:13:46 (25 occurrences)
Last logged: 21:33:08

Error fetching Microsoft Family Safety data: Error communicating with API ('HTTP Error', 500, '{"error":{"code":"500","message":"Something went wrong in the Aggregator service"}}')

I've implemented some changes in the beta release which partially addresses this (the fact that entities are unavailable) but the error itself comes directly from the Microsoft API.
Whether this is because the endpoint becomes overloaded, or another service issue is present is unknown at the moment.

These errors should now be suppressed in 1.1.0


use of the default application credentials in a k8s deployment with workload identity

The Adapter requires you to specify a credentials file, but I would prefer not to create a file and have the adapter use the default credentials provided by GKE workload identity.

This should work if you set the GOOGLE_APPLICATION_CREDENTIALS environment variable:
export GOOGLE_APPLICATION_CREDENTIALS=

That still requires a json  key crendential to be generated and placed inside the container. I prefer to use the workload identity.

I want to use this but making service account keys is a non-starter (org policy enforced).
This tool needs to support the normal Application Default Credentials loading process common to every other Google Cloud client/sdk library.

@eriksw @mvanholsteijn The latest version should now pick up any default application credentials of the environment that it is running when no credentials have been specified in the startup parameters of PGAdapter: https://github.com/GoogleCloudPlatform/pgadapter/blob/20754db9266f51af3b44fbb41137d12b1e551b3c/src/main/java/com/google/cloud/spanner/pgadapter/metadata/OptionsMetadata.java#L191
Please let me know by reopening the issue if that does not solve your issue.

super nice!


Fix route rule some problem

fix condition query problem
The branch of 0.2.0 is master-0.2.0. If your PR is to solve the problem of 0.2.0, please submit the PR to it.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change

BaseDTO remove service
fix condition query problem

Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #712 (bd6f729) into develop (719f4d3) will decrease coverage by 14.27%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##             develop     #712       +/-   ##
==============================================
- Coverage      33.87%   19.60%   -14.28%
+ Complexity       501      275      -226
==============================================
  Files             97       98        +1
  Lines           3817     3831       +14
  Branches         591      595        +4
==============================================
- Hits            1293      751      -542
- Misses          2390     2987      +597
+ Partials         134       93       -41

Flag
Coverage Δ
Complexity Δ

integration
19.60% <0.00%> (-0.09%)
0.00 <0.00> (ø)

unit
?
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719f4d3...bd6f729. Read the comment docs.


Fix the level count in Milgram Experiment scripts

Hey, me and my colleagues are the people from EPFL Data Science Lab that contacted you about the codebase. While adapting code for our needs and current OpenAI API I noticed the deviation between final logged level and the length of logged disobedience list -- and these 2 should match.

I took a look at your Jupyter analysis and I think you accounted for this, but it still would be great to fix. This way if anyone else would like to use the code the logic will be correct and no one will overlook this error in their logs.
This change only needs two small modifications in the while loop.

@microsoft-github-policy-service agree
śr., 10 kwi 2024 o 19:16 microsoft-github-policy-service[bot] <
@.***> napisał(a):

@Laz4rz https://github.com/Laz4rz please read the following Contributor
License Agreement(CLA). If you agree with the CLA, please reply with the
following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.

@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the
party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its
affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is
effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable
or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic
mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf
of, the Project for the purpose of
discussing and improving that Project, but excluding communication
that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now
or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions
is entirely Your original work.
Should You wish to Submit materials that are not Your original work,
You may Submit them separately
to the Project if You (a) retain all copyright and license information
that was in the materials as You
received them, (b) in the description accompanying Your Submission,
include the phrase “Submission
containing materials of a third party:” followed by the names of the
third party and any licenses or other
restrictions of which You are aware, and (c) follow any other
instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a
contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You
must secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You
change employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly
display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all
of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the
Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or
the combination of the
Submission with the Project to which it was Submitted to make, have
made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the
Project.
Other Rights Reserved. Each party reserves all rights not
expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are
legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the
course of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless
You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED
UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO,
ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of
any facts or circumstances of which
You later become aware that would make Your representations in this
Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the
laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in
which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire
agreement between the parties, and
supersedes any and all prior agreements, understandings or
communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may
be assigned by Microsoft.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/turing-experiments/pull/6#issuecomment-2048085308,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO26KLGKUHGSLNLHJ54MLFLY4VXV3AVCNFSM6AAAAABGA24R46VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYGA4DKMZQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Invalid isConnected function

https://github.com/RobTillaart/AD5245/blob/ce6560581e2854851b8ccfbda1442f4f3b86846f/AD5245.cpp#L29
This line will always return false.
May be you want to do
 if ((_address != 0x2C) && (_address != 0x2D)) return false;

@tnicolas42
you're 100% right, I will create a PR (0.4.0)  asap.
I might include some minor edits too.
If there are other things need to fix or you would like to have, do not hesitate to share,
Thanks for finding this bug.

develop branch, PR created, build is running.


fix protocol on twemoji urls

SSIA!

📦 Published PR as canary version: 0.22.1--canary.139.65b6981.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.22.1 :rocket: