can not register

Problem encountered on https://dotnet.microsoft.com/learn/machinelearning-ai/ml-dotnet-get-started-tutorial/install
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant..

Moving to the ML repo. @Emmagrabergs - chances are they will need additional details on what you were doing and the errors you see.

Issue moved to dotnet/machinelearning #2823 via ZenHub


Bug in reading padded block shard tensors to host.

Padded Block Sharded Tensors are copied incorrectly to the host.
Example:  A Tensor of Dimension (240, 256) block sharded across (8,4) cores. Each shard is of size (30,64), which gets padded to (32,64).
When this tensor gets copied to the host, the padding value in each shard also gets copied. In the final tensor, (32,64) elements from the first shard gets copied to the host instead of (30,64), which pushes the data in the second shard to start from (32,0) instead of (30,0).
Every subsequent shard gets pushed out, and the last shard is truncated.

hey @sankarmanoj-tt can you provide a test with this failure?

@sankarmanoj-tt pls let the team know how to repro this.
In the meantime, I'm closing the bug due to lack of an actionable description in the opened issue. @sankarmanoj-tt if you still have this problem, please re-open the issue with an actionable description. Thank you.


ValueError: not enough image data

run then print  ValueError: not enough image data, i am confuse , and can not solve by myself

$ python3 pdf-watermark-removal.py --output=test.pdf 宪法暑假班讲义-pages-2-10.pdf
2020-10-26 17:44:51,769 - INFO - Processing page 1/9
Traceback (most recent call last):
File "pdf-watermark-removal.py", line 127, in
main()
File "pdf-watermark-removal.py", line 117, in main
process_page(pdf, i, i < args.skip)
File "pdf-watermark-removal.py", line 78, in process_page
img = Image.frombytes(mode, size, data)
File "/usr/local/lib/python3.8/site-packages/PIL/Image.py", line 2658, in frombytes
im.frombytes(data, decoder_name, args)
File "/usr/local/lib/python3.8/site-packages/PIL/Image.py", line 797, in frombytes
raise ValueError("not enough image data")
ValueError: not enough image data

same  here
2021-08-06 11:41:35,043 - INFO - Processing page 1/442
2021-08-06 11:42:11,336 - INFO - Processing page 2/442
2021-08-06 11:42:45,503 - INFO - Processing page 3/442
Traceback (most recent call last):
File "pdf-watermark-removal.py", line 127, in
main()
File "pdf-watermark-removal.py", line 117, in main
process_page(pdf, i, i < args.skip)
File "pdf-watermark-removal.py", line 78, in process_page
img = Image.frombytes(mode, size, data)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/PIL/Image.py", line 2735, in frombytes
im.frombytes(data, decoder_name, args)
File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/PIL/Image.py", line 810, in frombytes
raise ValueError("not enough image data")
ValueError: not enough image data

Same here.

same
(base) PS D:\downloads\Remove\src> python .\pdf-watermark-removal.py --output=output.pdf .\8.pdf
2023-12-27 16:40:36,363 - INFO - Processing page 1/9
Traceback (most recent call last):
File "D:\downloads\Remove\src\pdf-watermark-removal.py", line 127, in
main()
File "D:\downloads\Remove\src\pdf-watermark-removal.py", line 117, in main
process_page(pdf, i, i < args.skip)
File "D:\downloads\Remove\src\pdf-watermark-removal.py", line 78, in process_page
img = Image.frombytes(mode, size, data)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Anaconda3\Lib\site-packages\PIL\Image.py", line 2976, in frombytes
im.frombytes(data, decoder_name, args)
File "D:\Anaconda3\Lib\site-packages\PIL\Image.py", line 809, in frombytes
raise ValueError(msg)
ValueError: not enough image data


Fusion installer: if you specify a user and a group, the user is not created

In install_fusion.sh, if you specify a user name (-u) and a group name (-g), the user is not created (the group is created correctly).  This also causes fusion to fail when it is started since the required user does not exist.
Tested on Ubuntu 14.04.

@tst-lsavoie Does this still occur? Maybe it was a by-product of the part where we had the hard-coded group name (which got fixed as part of https://github.com/google/earthenterprise/commit/8be14628be44649e96fae992a01c4a2668d1e1cd )

I'm still seeing this behavior.

I'm not able to reproduce:
bradh@googleearth:~/earthenterprise/earth_enterprise/src/installer$ sudo ./install_fusion.sh  -u fusionuser -g fusiongroup

Welcome to the Google Earth Enterprise Fusion 5.1.3 installer.

RECOMMENDED:

It is strongly recommended that you use the default values for the fusion username and group.

Default Fusion User:                            gefusionuser
Default Fusion User Group:                      gegroup
----------------
Selected Fusion User:                           fusionuser
Selected Fusion User Group:                     fusiongroup
X (Exit) the installer and change the asset root location - C (Continue) to use the asset root that you have specified. C

You have chosen to install Google Earth Enterprise Fusion with the following settings:

# CPU's:                4
Operating System:       Ubuntu 14.04
64 bit OS:              YES
Backup Fusion:          YES
Install Location:       /opt/google
Asset Root:             /gevol/assets
Source Volume:          /gevol/src
Fusion User:            fusionuser
Fusion User Group:      fusiongroup
Disk Space:

Filesystem      Size  Used Avail Use% Mounted on
udev            5.4G  4.0K  5.4G   1% /dev
tmpfs           1.1G  896K  1.1G   1% /run
/dev/sda1       285G   42G  229G  16% /

X (Exit) the installer and cancel the installation - C (Continue) to install/upgrade. C

Proceeding with installation...

Copying files from source to target directories...Done
Copying Fusion Tutorial files... Not found - Skipping tutorial install
Setting up system links...DONE
Setting up the Fusion daemon...
 Removing any system startup links for /etc/init.d/gefusion ...
 Adding system startup for /etc/init.d/gefusion ...
   /etc/rc0.d/K10gefusion -> ../init.d/gefusion
   /etc/rc1.d/K10gefusion -> ../init.d/gefusion
   /etc/rc6.d/K10gefusion -> ../init.d/gefusion
   /etc/rc2.d/S90gefusion -> ../init.d/gefusion
   /etc/rc3.d/S90gefusion -> ../init.d/gefusion
   /etc/rc4.d/S90gefusion -> ../init.d/gefusion
   /etc/rc5.d/S90gefusion -> ../init.d/gefusion
Fusion daemon setup ... Done
Switching to (fusionuser, fusiongroup)
Setting up assetroot status object
Validating assetroot
Starting System Manager... Done
Starting Resource Provider... Done

Performing cleanup...Done

-------------------
Congratulations! Google Earth Enterprise Fusion 5.1.3 has been successfully installed
in [/opt/google].
bradh@googleearth:~/earthenterprise/earth_enterprise/src/installer$ grep fusion /etc/passwd
fusionuser:x:998:998::/opt/google/.users/fusionuser:
bradh@googleearth:~/earthenterprise/earth_enterprise/src/installer$ grep fusion /etc/group
fusiongroup:x:998:

Fusion started up OK after this.
Am I missing something about this ticket?

I think I was testing with an old build.  After updating, I'm not seeing the error any more.  I'll close the ticket.


use a URI type from a library instead of plain Strings

The D-Bus API makes use of URIs in several places, for example FileChooser. ashpd currently treats these URIs as std::string::Strings. It could be helpful to downstream developers to use a URI type from another crate for these URIs instead of simple Strings. I ran into an issue where I was not properly handling URI encoding which would have been easier to prevent if ashpd encoded more information about the data from the D-Bus API than treating it as a generic String.

I don't think it is useful to depend on an external crate for this. But yes, having some very basic in-tree URI type that can be used instead of plain String would be nice. Do you want to submit a patch for that? There are not that many that I can think of.
Only Account, Screenshot & FileChooser returns a URI.

This would be a breaking API change. Would you want to make a new major release just for this? Or maybe wait and do this together with other breaking changes?

This would be a breaking API change. Would you want to make a new major release just for this? Or maybe wait and do this together with other breaking changes?

I am planning to make a new major release yes so it is fine to do breaking changes

I am not sure this is the best idea. The user can always do
let uri = url::Url::parse("something")?;
some_ashd_portal(uri.into()).await?;

when verification is needed.

For my use case I am more concerned with properly handling URIs read from ashpd. I was making mistaken assumptions about the returned data which the compiler let me do because it was a String. If its type conveyed it was a URI, that couldn't be ignored.

There is no URI inputs, only outputs btw. So we could have just a pub struct URI(String) & return that.

Doesn't the uri portal require a url input

Doesn't the uri portal require a url input

Hmm yeah indeed.

there is also the wallpaper portal that takes a uri

I think the best thing to do is to accept arbitrary strings, but return early if, say, url::Url::parse(input) fails.

I disagree. It would be better to prevent passing invalid URLs by using a URL type as the input.


Add more topics

We need more topics to be added. Think of something like cities, countries etc. The list so created must be like the one created for the movie list.

Will look into it


Fix typos and improve reading flow

Summary
This fixes a few typos I found in the article and changes some sentences to make them more readable.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BurnhamG sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


fix: [CDE-540]: Adding check for media folder path during gitspace creation.

Description
This PR introduces two changes

Adding a check for user's name and email before cloning the code inside the gitspace container. This will non-block non-harness repos.
Adding an explicit check for the media folder's path during VSCode web setup.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: dhruv-harness:x: dhruv1397You have signed the CLA already but the status is still pending? Let us recheck it.


error: No supported distribution was found for input jdkFile

Description:
Follow the guide to install custom JDK dist.
https://github.com/actions/setup-java/blob/main/docs/advanced-usage.md#Installing-custom-Java-package-type
Task version:
v2
Platform:

[x] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[x] Hosted
[ ] Self-hosted

Check my workflow file: https://github.com/hantsy/cargotracker/blob/master/.github/workflows/it-with-arq-wildfly-managed.yml#L21
Check the run result: https://github.com/hantsy/cargotracker/runs/2339867024#step:4:2

Hello @hantsy. Thank you for report. We had the typo in our documentation, it was fixed in scope of this pull requests:

https://github.com/actions/setup-java/pull/163
https://github.com/actions/setup-java/pull/167

You should change distribution: 'jdkFile' to distribution: 'jdkfile'.


cmd/vet: vet is reporting lock value copying because of a Lock method unrelated to mutexes

go version go1.7.3 linux/amd64
A method named Lock() on a struct is enough to trigger the vet lock copy warning. See https://play.golang.org/p/V2v2w7DPAM
What did you expect to see?
$ go vet
$
What did you see instead?
$ go vet
main.go:11: assignment copies lock value to b: main.A
main.go:12: assignment copies lock value to _: main.A
exit status 1
$

vet checks for any (*T).Lock(). Perhaps we should limit it to a handful of known types (sync.Mutex, sync.RWMutex)?
/cc @robpike

This is related to #8005, which made the decision to embed a noCopy struct with a Lock method, which vet checks for. Russ' comment from Mar 1 explains the current status.

Ah, okay. Thanks for the context.
Where does vet check for noCopy? Couldn't find it with grep "noCopy" -r src/cmd/vet. It seems like vet doesn't.

It doesn't check for noCopy, I think it just checks for the Lock method, which the noLock struct has. The point being, we made Lock a special no-copy method. Personally, I think it is worth revisiting whether noCopy.Lock was the right approach or if we should expand "no copy" detection to be more general to things other than locks.
From this issue report, it seems that there are types with Lock methods that okay to copy. From #8005, it seems that there is a clear demand for declaring types (other than locks) as "no copy". Thus, it feels strange to me that having a Lock method == "no copy".

For history, this decision was from Rob's comment on the original copylocks vet CL.
This is the first complaint about this in three years, and having Lock == "no copy" was actually a really useful solution to #8005, so I think it is worth understanding a bit more before altering this.
@dlecorfec can you provide some context about what Lock means in your program?

I see. From what I understand,
Set A = all types that transitively embed sync.noCopy
Set B = all types with (*T).Lock()
cmd/vet should warn on A. But it uses B as a proxy for A, and ends up warning for types in B-A set too.
How difficult is it to determine whether type T transitively embeds type V. If not difficult, we should do that. Or else, leave it as is on the ground of this being non-frequent false-positive.

I'd like understand more about the original program first: what does the
original Lock method do? Why is it ok to copy? Without a concrete example,
this issue seems pretty hypothetical.
Perhaps the problem is not in cmd/vet but the design of the Lock method.

Context: a Job struct (for a video encoding job), with a Lock() method which inserts a SQL row in a video_encoding_lock table in order to prevent multiple workers (on multiple servers) from processing the same job.
Notwithstanding this possibly dubious architecture (legacy stuff, slightly older than Go itself), I can easily rename this method if this cmd/vet behaviour is intended.
Being new to this video code base, I was confused by the warning because the struct didn't contain a mutex and I didn't see its Lock method at first sight :)

Thanks, @dlecorfec. The lock is external, making it ok to copy; makes sense.
I think that we should take this as a data point, recommend renaming the Lock method for now, and wait to see whether this issue arises again.

Agree with @josharian. Good data point, but for now you need to rename your Lock method. Sorry.

Done, no problem, thanks all for your time!


TFLite on GPU does not support quantised models by default

URL(s) with the issue:
https://www.tensorflow.org/lite/performance/gpu_advanced
Description of issue (what needs changing):
The documentation reads: "Android APIs support quantized models by default. To disable, do the following:"
However, when I try running my int8 quantised model on mobile GPU, it silently defaults to running on CPU. I'm importing the nightly version as below in build.gradle:
dependencies {
    implementation "androidx.appcompat:appcompat:1.1.0"

    implementation "org.tensorflow:tensorflow-lite:0.0.0-nightly"
    implementation "org.tensorflow:tensorflow-lite-support:0.0.0-nightly"
    implementation "org.tensorflow:tensorflow-lite-gpu:0.0.0-nightly"
}

And when I do the below in my Android activity:
gpuOptions.setQuantizedModelsAllowed(true);

it successfully runs on GPU (confirmed by looking at GPU usage, also it runs much faster on GPU).
This suggests that the Android APIs actually DON'T support quantised models on GPU by default, and the flag needs to be set manually.

URL(s) with the issue:
https://www.tensorflow.org/lite/performance/gpu_advanced
Description of issue (what needs changing):
The documentation reads: "Android APIs support quantized models by default. To disable, do the following:"
However, when I try running my int8 quantised model on mobile GPU, it silently defaults to running on CPU. I'm importing the nightly version as below in build.gradle:
dependencies {
    implementation "androidx.appcompat:appcompat:1.1.0"

    implementation "org.tensorflow:tensorflow-lite:0.0.0-nightly"
    implementation "org.tensorflow:tensorflow-lite-support:0.0.0-nightly"
    implementation "org.tensorflow:tensorflow-lite-gpu:0.0.0-nightly"
}

And when I do the below in my Android activity:
gpuOptions.setQuantizedModelsAllowed(true);

it successfully runs on GPU (confirmed by looking at GPU usage, also it runs much faster on GPU).
This suggests that the Android APIs actually DON'T support quantised models on GPU by default, and the flag needs to be set manually.

According to the gpu delegate Java implementation, the support of quantized model is enabled by default in TfLite library.
As the tensorflow-lite-support lib is also used, it looks like you are using the tflite via the TfLite task library? If yes, could you detail how it's used? Anyway, to help us debugging, could you share a minimal code piece that we could use to reproduce the issue? Thx!

It seems only Support library is used (to use Task library, it requires the dependency to Task library specifically). Yeah, the code snippet will help us understand what is going here.

As a side note, running quantized model on GPU won't have performance benefit compared to running float16 model on GPU, as the weights are dequantized and the inference is being done in float16 (or float32). It also has extra quantize-dequantize between each layers, so the performance overall might even be slower than that of float16 model.

Apologies for the late reply, I've been called to do other work.
A couple of notes:

Indeed I was not using the Task Library. I loaded a custom model trained by myself.
I'm aware that running quantised models on GPU will just dequantise them. That's not a problem at the moment, we are not optimising for accuracy (yet) and using a single model for GPU and NPU is more convenient.

Below is a snippet from my main activity:
  private class RunBenchmarkTask extends AsyncTask<Void, Integer, Void> {
    private long totalTime = 0;
    private long maxTime = 0;
    private long minTime = 999999;
    private int numRuns = 100;
    private int numWarmupRuns = 5;

    protected void onPreExecute() {
      // Hide settings and button
      View l = findViewById(R.id.settingsLayout);
      l.setVisibility(View.GONE);

      settingsTextView.setText(String.format(
              "Model: %s \nDevice: %s \nOutput res: %d x %d \nWarmup runs: %d \nTimed runs: %d",
              modelPath, device, getOutputSize(inputHeight), getOutputSize(inputWidth), numWarmupRuns, numRuns));
      resultsTextView.setText("Benchmarking...");
    }

    protected Void doInBackground(Void... params) {

      // Load tflite model
      try {
        tfliteModel = FileUtil.loadMappedFile(MainActivity.this, modelPath);
        Log.i(TAG, String.format("Model loaded from %s", modelPath));
      } catch (IOException e) {
        Log.e(TAG, "Error loading model", e);
        finish();
      }

      // Initialise tflite
      tfliteOptions = new Interpreter.Options();
      try {
        switch (device) {
          case CPU:
            break;
          case GPU:
            GpuDelegate.Options gpuOptions = new GpuDelegate.Options();
            // TFLite on GPU documentation says that the below flag is True by default
            // but quantised models won't run on GPU by default
            // TODO github issue
            gpuOptions.setQuantizedModelsAllowed(true);
            gpuDelegate = new GpuDelegate(gpuOptions);
            tfliteOptions.addDelegate(gpuDelegate);
            break;
          case NPU:
            nnApiDelegate = new NnApiDelegate();
            tfliteOptions.addDelegate(nnApiDelegate);
            break;
        }
        tflite = new Interpreter(tfliteModel, tfliteOptions);

      } catch (Exception e) {
        Log.e(TAG, "Error initialising tflite interpreter", e);
        finish();
      }

      // Tell tflite to use this input size
      int[] inputShape = {batchSize, inputHeight, inputWidth, 3};
      DataType imageDataType = tflite.getInputTensor(0).dataType();
      Log.i(TAG, String.format("Input datatype: %s", imageDataType));
      inputImageBuffer = TensorBuffer.createFixedSize(inputShape, imageDataType);
      tflite.resizeInput(0, inputShape);

      // Initialise output
      int[] outputShape = {batchSize, getOutputSize(inputHeight), getOutputSize(inputWidth), 3};
      Log.d(TAG, String.format("Input shape: %s", Arrays.toString(inputShape)));
      Log.d(TAG, String.format("Calculated output shape: %s", Arrays.toString(outputShape)));
      outputTensorBuffer = TensorBuffer.createFixedSize(outputShape, imageDataType);

      // Do some warmup runs
      for (int i=0; i < numWarmupRuns; i++) {

        rerollInput(inputImageBuffer);
        tflite.run(inputImageBuffer.getBuffer(), outputTensorBuffer.getBuffer().rewind());
      }

      // Do some timed runs
      for (int i=0; i < numRuns; i++) {
        // Regenerate input tensor with different random values
        rerollInput(inputImageBuffer);

        // Start counting
        long startTime = SystemClock.uptimeMillis();

        // Run inference on the decoder
        tflite.run(inputImageBuffer.getBuffer(), outputTensorBuffer.getBuffer().rewind());

        // Stop counting
        lastProcessingTimeMs = (int) (SystemClock.uptimeMillis() - startTime);
        Log.i(TAG, String.format("Decoder inference time = %d ms", lastProcessingTimeMs));

        totalTime += lastProcessingTimeMs;
        maxTime = lastProcessingTimeMs > maxTime ? lastProcessingTimeMs : maxTime;
        minTime = lastProcessingTimeMs < minTime ? lastProcessingTimeMs : minTime;
        publishProgress(i, numRuns, lastProcessingTimeMs);
      }

      tflite.close();
      return null;
    }

    protected void onProgressUpdate(Integer... progressValues) {
      // progressValues contains current index and total number of iterations
      resultsTextView.setText(String.format(
              "Benchmarking %d/%d. Time (ms): %d",
              progressValues[0] + 1, progressValues[1], progressValues[2]));
    }

    protected void onPostExecute(Void result) {
      float avgTime = (float) totalTime / numRuns;
      Log.i(TAG, String.format(
              "Inference time (ms): mean = %f, max = %d, min = %d",
              avgTime, maxTime, minTime));

      // Show benchmark results on UI
      resultsTextView.setText(String.format(
              "Inference time (ms): \nmean = %.3f, max = %d, min = %d",
              avgTime, maxTime, minTime));

      // Unhide settings
      View l = findViewById(R.id.settingsLayout);
      l.setVisibility(View.VISIBLE);

      // Delete stuff
      tflite = null;
    }
  }

Please let me know if there's something I'm missing, or if you need more information.

From the source code, quantized models should be enabled as default. And @Cy-r0 is using the nightly build.
Looped in @srjoglekar246 to take a look.

We have GpuDelegateTest that unit-tests this behavior in our internal tooling, so I am surprised that you don't see the GPU delegate being enabled by default :-/. (Note that the test looks at the ops in the TFLite Interpreter to see if the whole graph has been delegated to GPU). I just re-ran these tests, and they pass.
To followup, what do you see in ADB logs from the TFLite runtime when you don't (vs do) set the flag to True explicitly?
Also, can you try logging the value of options.quantizedModelsAllowed through adb (before you explicitly set it to True) as well?

Hi @Cy-r0
I was checking if the issue still exists.
The code for GPU delegate test says that default behavior allows quantized models as well.
https://github.com/tensorflow/tensorflow/blob/5dcfc51118817f27fad5246812d83e5dccdc5f72/tensorflow/lite/java/src/test/java/org/tensorflow/lite/gpu/GpuDelegateTest.java#L79
As @srjoglekar246 asks, could you please provide the ADB logs to better understand the issue?
Thanks.

Apologies, I've moved on from this job. I'll check if I still have the code and if the issue is still present, but I can make no guarantees I'll find it.

Hi @Cy-r0
Can we consider the issue is resolved?
Thanks.

Yes, thank you.

Thanks for the confirmation.


Toolbox casts invisibility on prepared spells

Describe the bug
Prepared spellcasting slots disappear and are replaced by spellbook spells.
To Reproduce
Steps to reproduce the behavior:

Create a brand new npc
Use creature builder and give a spellcasting level of anything other that none
Add any prepared spellcasting type
Add a spell of any level
Close the character sheet
Open the character sheet

Expected behavior
Not hide all the prepared spells spells.
Screenshots

Version Information:

Firefox Developer Edition 90.0b12 64-bit
FoundryVTT [e.g. 0.8.8]
PF2E Toolbox [e.g. 1.7.5]
Activated Systems & Modules w/ Versions

too many

Additional context
Reported in base system as well may be base system related but is only reproduce able by using toolbox features.

@Trollderim Seems to be related to a update with PF2E.


overwriteBuildSettings not working

Hey folks,
Recently came across the need to update XUPorter, we have a project that requires completely automated builds, (from replace not append). I've added the necessary methods required to generate the entitlements file from a template, set the DevelopmentTeam and SystemCapabilities values in the project file, and add the newly generated entitlements file to the project. So far, all is good.
However the last step which is a crucial one, is telling the build configurations that this file is to be used for the CODE_SIGN_ENTITLEMENTS. I've currently tried this in two ways. The first was to use the overwriteBuildSettings method to push the value in. This doesn't seem to work, and having looked at the code I can see why. However I've moved over to the following snippet instead.
foreach (KeyValuePair<string, XCBuildConfiguration> buildConfig in buildConfigurations)
{
if(buildConfig.Value.data.ContainsKey("CODE_SIGN_ENTITLEMENTS"))
buildConfig.Value.data["CODE_SIGN_ENTITLEMENTS"] = path;
else
buildConfig.Value.data.Add("CODE_SIGN_ENTITLEMENTS", path);
}
This works, and puts the data into the xcode project file, however the path does not automatically get quotes put around it. I attempted to modify the path value by using the following.
path = """ + path + """;
This was intended add quotes to the path making it valid. However when I do this, the project file that gets exported then wraps this whole thing in quotes, causing double quotes at each end of the path, stopping the project form even opening.
Any Ideas?

There are still features using CODE_SIGN_ENTITLEMENTS - e.g. the new iOS 9 Associated Domains  feature, where the linked entitlements file looks like this:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>com.apple.developer.associated-domains</key>
	<array>
		<string>applinks:yourlink.com</string>
	</array>
</dict>
</plist>


Contributors style

@molant I've got other changes coming to the CSS. @qzhou1607 Is there anyway to get the contributors table element wrapped in a div with class="section contributors"?

@ststimac Yes it's possible. You can wrap the divs like below and drop it in the markdown:
{% raw %}
<div class="section contributors">
{% endraw %}

// the table

{% raw %}
<div">
{% endraw %}

Oh also, just found out with the new changes in this PR, some code the updater in the sonar site needs to be updated, otherwise the contributor page will break. I'm working on making the change. And will add the div tags here after I'm done.

@qzhou1607 thanks!

@ststimac looks like there are some conflicts here

@molant @qzhou1607 just mentioned there's some code that will make this page break.......could those be causing the conflict?

@ststimac The changes in updater is in the sonarlwhal.com repository (https://github.com/sonarwhal/sonarwhal.com/pull/144). So it shouldn't be causing the problem.

@qzhou1607 okay, thanks for letting me know. Trying to figure out what's failing here :)


deploy.sh fails on webpack

When running the deploy.sh script, I hit the following errors after the webpack --config web_app/frontend/config/webpack.aot.js command runs. Any ideas on how to proceed?
ERROR in shared/components/loan_management/loan_actions_card/loan_actions_card.ts(62,32): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
shared/components/loan_management/loan_actions_card/loan_actions_card.ts(63,31): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/shared/chrome_app_platform_location.ts(45,15): error TS2304: Cannot find name 'unknown'.
chrome_app/src/app/manage/app.ts(47,28): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/manage/shared/bottom_nav/bottom_nav_test.ts(66,35): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/manage/status/status_test.ts(110,47): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
chrome_app/src/app/manage/status/status_test.ts(113,49): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
chrome_app/src/app/manage/status/status_test.ts(115,49): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
chrome_app/src/app/manage/status/status_test.ts(118,49): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
chrome_app/src/app/manage/status/status_test.ts(121,47): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
shared/components/return_instructions/return_instructions.ts(34,34): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/offboarding/app.ts(88,35): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/offboarding/app.ts(90,42): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/offboarding/app.ts(99,32): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/offboarding/app.ts(100,41): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/offboarding/app.ts(104,28): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/welcome/welcome.ts(29,35): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(87,35): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(89,42): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(96,33): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(98,32): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(99,32): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(100,41): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/app.ts(104,28): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
chrome_app/src/app/onboarding/return/return_test.ts(101,47): error TS2304: Cannot find name 'AnyDuringJasmineTypesMigration'.
web_app/frontend/src/components/search_box/search_box.ts(67,28): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/search_box/search_box.ts(68,39): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/shelf_actions/shelf_actions.ts(43,35): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/views/shelf_actions_view/shelf_actions_view.ts(35,30): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/views/device_actions_view/device_actions_view.ts(41,39): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/device_action_box/device_action_box.ts(73,33): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/device_action_box/device_action_box.ts(74,31): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/device_action_box/device_action_box.ts(75,27): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/device_action_box/device_action_box.ts(76,29): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/device_list_table/device_list_table.ts(62,24): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.
web_app/frontend/src/components/shelf_list_table/shelf_list_table.ts(53,24): error TS2345: Argument of type '{ static: boolean; }' is not assignable to parameter of type '{ read?: any; }'.
Object literal may only specify known properties, and 'static' does not exist in type '{ read?: any; }'.

My environment is as follows
Ubuntu 18.04 running on Windows Subsystem for Linux
Bazel 0.28.1
Node v12.8.0
NPM 6.10.2

Downgrade your bazel version to 22.
On Thu, Aug 8, 2019, 10:35 PM carlosjourdan<EMAIL_ADDRESS>wrote:

My environment is as follows
Ubuntu 18.04 running on Windows Subsystem for Linux
Bazel 0.28.1
Node v12.8.0
NPM 6.10.2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/loaner/issues/60?email_source=notifications&email_token=AKYV7Z3GEURNQ4IHZZ6HQXDQDTJYPA5CNFSM4IKP5TJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35NKLQ#issuecomment-519755054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYV7ZYXM52DROJWWNQC33TQDTJYPANCNFSM4IKP5TJA
.

@githerbert if I do that I get the following error:
ERROR: The bazel version installed is lower than the minimum required version (0.28.0), please update bazel.

What version are you pulling from?  .71a or master?
On Thu, Aug 8, 2019, 10:53 PM carlosjourdan<EMAIL_ADDRESS>wrote:

@githerbert https://github.com/githerbert if I do that I get the
following error:
ERROR: The bazel version installed is lower than the minimum required
version (0.28.0), please update bazel.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/loaner/issues/60?email_source=notifications&email_token=AKYV7ZZLE5XPHW7NAIZMKNTQDTL2DA5CNFSM4IKP5TJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD35OAVI#issuecomment-519757909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYV7ZY42RKUOUF2UP7IQJLQDTL2DANCNFSM4IKP5TJA
.

I was pulling from master by mistake. Now I pulled from .71a and am able to build using bazel 22.
However, I still get the error below when running webpack:
Error: ENOENT: no such file or directory, open '/mnt/c/Users/carlo/Workspace/loaner0.7.1a/loaner/web_app/frontend/dist/assets/search_help.md'

I started from scratch and it worked. Thanks for the help.


feat: add mqtt-proxy plugin in ApisixRoute (#966)

Type of change:

[ ] Bugfix
[x] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Add mqtt-proxy plugin in ApisixRoute.Stream.
ref: issue
Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1056 (b7a0670) into master (df7a724) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
- Coverage   30.97%   30.93%   -0.04%
==========================================
  Files          75       75
  Lines        8792     8801       +9
==========================================
  Hits         2723     2723
- Misses       5775     5784       +9
  Partials      294      294

Impacted Files
Coverage Δ

pkg/kube/translation/apisix_route.go
20.31% <0.00%> (-0.30%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7a724...b7a0670. Read the comment docs.

Great! Thanks!
I will reivew this later. I'm working on an issue #1055  (high priority)
It blocked our CI jobs.

Could you please merge master latest code? #1055 has been merged. We can make test cases pass.

@tao12345666333 This PR also adds a feature for ApisixRoute Stream plugins. So may be we should update the doc about how to use stream plugin?
But the doc just for v2beta3 only, in origin issue, we dedciede add this feature to v2 APIversion only. Should I add this feature to other APIversion great than v2?

So may be we should update the doc about how to use stream plugin?

we should add apisix_route_v2 reference doc. And add stream plugin content.

Should I add this feature to other APIversion great than v2?

No, just keep this feature in v2 APIVersion.  We will mark v2beta3 as deprecated in the future. You can check #707 for more details

I have created one issue for track https://github.com/apache/apisix-ingress-controller/issues/1063

I have created one issue for track #1063

I can work on it after this PR is merged.
For now, could you please check CI test? It seems like CI test env has some problems. These errors do not occur when running the e2e-test on my computer.

Let me take a look.

@stillfox-lee  As I said in my previous comment https://github.com/apache/apisix-ingress-controller/issues/831#issuecomment-1148789741, we are addressing #954
The task is currently over, I can have time to advance this PR.
Can you merge the latest code and resolve conflicts? I think the previous e2e problem should have been solved.

@stillfox-lee Please replace suite-plugins/mqtt-proxy.go with suite-plugins/suite-plugins-other/mqtt-proxy.go. Because the secondary directory will not be started when there is a tertiary directory.

@stillfox-lee Please replace suite-plugins/mqtt-proxy.go with suite-plugins/suite-plugins-other/mqtt-proxy.go. Because the secondary directory will not be started when there is a tertiary directory.

Yes, I found that too. And test code needs to adapt V2 e2e-test, so I converted this PR to Draft. Maybe I can do some refactor work when I have time this weekend.

@stillfox-lee  hi, thanks for your contribution, we plan to enter v1.5 release window.
I have a few suggestions for this PR

I would like to put this PR into v1.6
Currently we have unified all resources to the v2 version of the API, I recommend implementing this feature only for the v2 version of ApisixRoute. Because when the v1.5 version is released, we will mark the v2beta3 version as deprecated. You can check https://github.com/apache/apisix-ingress-controller/issues/707 for more detail (I have explained before)

I will add a commit to help you fix CI

https://github.com/stillfox-lee/apisix-ingress-controller/pull/13/commits/ed5bd38d46da327d6f535f96893b6787694672ac this one

@tao12345666333 Thanks for your help. I think PR is ready for review now. Sorry for the delay, and this feature didn't catch v1.5 window.

the failed job due to https://github.com/apache/apisix-ingress-controller/issues/1199

please merge master branch latest code to fix CI job errors. Thanks

hi, there has one conflicting file, do you have time to resolve it? thanks

@tao12345666333 The issue cause CI failed. It's not related to this PR.

I re-runed it and the problem is gone


Consistent method for dealing with ref bias in ska map

Code now writes all mapped middle bases at the end
This ensures consistency with the ska nk output, but is not necessarily 'more correct'

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.43%. Comparing base (b99a298) to head (8b33279).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   92.42%   92.43%
=======================================
  Files          16       16
  Lines        2272     2273    +1
=======================================
+ Hits         2100     2101    +1
  Misses        172      172

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


okhttp cache is useless without network

[ ] Feature Request.
okhttp cache is useless without network under certain circumstances. For example, if the url of request is
"www.example.com?network=wifi&sign=123", but when without network,  your url will be "www.example.com?network=?&sign=345",(sign according to url params to generate). when matching cache data, it is not matched, so get cache data is null.

Maybe you need to add a function in Cache.java  to solve the issue that developer can customized cache url.

guys, how to set read_timeout per request?

@JuHonggang you’re probably better off storing those responses locally independent of OkHttp’s cache. We won't be able to build a sufficient, performant system to match arbitrary requests to one another.


F# does not seem to work with Visual Studio 2017 RC3 26127.3

Repro steps
Uncertain. Perhaps the installation of RC3 26127.3. The original installation of RC3 worked with the steps provided.
Expected behavior
Support for F# projects in Visual Studio 2017 RC3 26127.3
Actual behavior
F# projects will not load and going to Tools -> Options -> F# Tools has the following: An error occurred loading this property page
Related information
Attempted Fixes: Repair option in installer, refollow instructions from step 3 on. Uninstall/reinstall refollow instructions. All failed.
Activity.xml error:

LegacySitePackage failed for package [FSharpProjectPackage]Source: 'FSharp.ProjectSystem.FSharp' Description: Could not load file or assembly 'Microsoft.VisualStudio.LanguageServices, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.

System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.LanguageServices, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
File name: 'Microsoft.VisualStudio.LanguageServices, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35' at Microsoft.VisualStudio.FSharp.ProjectSystem.FSharpProjectPackage.Initialize() at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsPackage.SetSite(IServiceProvider sp)

Windows 10
Visual Studio 2017 RC3 Release
.NET 4.6

Interesting.  I'm running 26127.3 on my machine and having no problems.  I know you said that you followed the installation instructions, but did you perhaps not install a .NET workload (.NET Desktop, ASP.NET)?  Microsoft.VisualStudio.LanguageServices failing to load sounds like a different issue which is then affecting F#.  cc @brettfo

@chaotic-butter
@cartermp
Okay, I just reproed this on a clean VM.
As Phillip suggests this happens when VS is installed without first selecting the .Net Desktop Development workload.  It should be noted that the instructions for this are quite specific, because installing the VF# tools this way is not a supported scenario.  We have these instructions because we made a mistake inserting our code into the RC3 release.
So ... to fix your install ...
rerun vs setup and select the .Net Desktop Development workload
once it has completed installation everything should work as expected
(it takes quite a long time, with the progress on zero %)
I hope this helps.

To piggy-back on @KevinRansom's comment, in the next update we've fixed this so it is possible to install just F# (without the .NET Desktop workload) and get the appropriate dependencies.

Thanks for the detailed installation notes.  Visual Studio 2017 RC3 comes with the extension: Visual F# Tools <IP_ADDRESS>. The version installed from GitHub using those instructions is <IP_ADDRESS>12301.

Thank you all, installing the .NET Desktop workload did in fact clear the problem. I was installing just the F# component originally.

Updated the RC3 instructions to remove the bit about selecting F# from Individual Components.

Thought about creating another issue, but didn't. What is the status for supporting the update msbuild project files.  The notes in https://github.com/dotnet/netcorecli-fsc/wiki/.NET-Core-SDK-rc3 seem to indicate that it doesn't work. When I create a project and run it with dotnet it works.
dotnet new -l fsharp
dotnet restore
dotnet run

I then try to open it in Visual Studio 2017 RC3 with all of this installed and I get this error:
---------------------------
Microsoft Visual Studio
---------------------------
The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Sdks\FSharp.NET.Sdk\Sdk\Sdk.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.  C:\Users\camer\fs\testA\testA.fsproj
---------------------------
OK
---------------------------

Where testA.fsproj is:
<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp1.0</TargetFramework>
    <Version>1.0.0-alpha</Version>
    <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Program.fs" />
    <EmbeddedResource Include="**\*.resx" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="FSharp.NET.Sdk" Version="1.0.0-beta-*" PrivateAssets="All" />
    <PackageReference Include="Microsoft.FSharp.Core.netcore" Version="1.0.0-alpha-161023" />
  </ItemGroup>

  <ItemGroup>
    <DotNetCliToolReference Include="dotnet-compile-fsc">
      <Version>1.0.0-preview2-020000</Version>
    </DotNetCliToolReference>
  </ItemGroup>

</Project>

Thoughts? Hacks? Work-a-rounds?
Should I copy some files from the SDK there?
C:\dotnet\dotnet-dev-win-x<IP_ADDRESS>-rc3-004530\sdk\1.0.0-rc3-004530\Sdks\FSharp.NET.Sdk\Sdk

I tried out the hack by copying the missing files with:
mkdir "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Sdks\FSharp.NET.Sdk"
cp -r C:\dotnet\dotnet-dev-win-x<IP_ADDRESS>-rc3-004530\sdk\1.0.0-rc3-004530\Sdks\FSharp.NET.Sdk\Sdk "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Sdks\FSharp.NET.Sdk\"

But then Visual Studio 2017 RC3 can't find the targeting pack for .NETCoreApp,Version=v1.0 and I can't see how to install that. Does it not come with Community Edition?

I know I'm missing something. :-)

@ctaggart Looks like encountering two problems:

Lack of F# project system support for the .NET Core SDK and the new MSBuild.  This is a priority 0 issue we're addressing and targeting for a VS2017 microupdate.
Lack of the .NET Core SDK on your machine via your installation.

The latter can be addressed right now - there should be a checkbox for .NET Core support in the .NET Desktop workload.  Otherwise, you could install either the ASP.NET workload or the .NET Core/Docker workload.  Either way, it should get you the correct bits.  It's all available on the Community edition.
The former is something that you unfortunately can't address right now.  Just to clarify on the scenario, that means that the .NET CLI will ship with the ability to generate F# projects which cannot be opened in Visual Studio 2017 at this time.

Thanks @cartermp, looking forward to that microupdate!

@cartermp by "Visual Studio 2017" I'm assuming you mean Visual Studio 2017 RC3 and that the final release of Visual Studio 2017 will indeed include support for opening F# projects created through the .NET CLI tool. Is this correct?

@jpierson No, unfortunately this means that the release of VS 2017 will lack the ability to open an F# project created by the .NET CLI tool.  There is work we need to do in our project system to support the new flavor of MSBuild it uses, which will debut in release form for the first time in the release of VS 2017.

@cartermp that's unfortunate but thanks for making this clear. Where can I follow along for the progress of addressing the project file compatibility? I'm curious how or whether F# projects will be able to leverage the improved wildcard support for source files given the F# compiler's single-pass design.

@jpierson We don't have a tracking issue yet, but we'll create one soon.  It's a top priority issue for us.  In terms of wildcards, we won't be able to use those (or file globbing support).  File order will still have to exist in the project file.

@cartermp Any idea when this could be done? It's really frustrating to work with the old and new format side by side. The new C# projects don't understand the old F# format and VS doesn't know the new format.

@curdincaspar See #2461 for the tracking bug for what you've mentioned.  Referencing an F# .NET Framework project from the new C# projects works just fine, but the inverse is not true.  We're targeting the first update of VS 2017.

Closing old RC3 issue

I still have this problem...

When I try to hack it by copying
c:\Program Files\dotnet\sdk\1.0.3\Sdks\FSharp.NET.Sdk\ into
c:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\Sdks\
after trying to open the project I get...

Was that micro update already issued? Or is it still in the workings? Thanks

You're experiencing a different issue.  You're attempting to load a .NET Core project (likely created from the CLI?) into VS.  Our project system doesn't support that yet.  We have support in the new dotnet project system (dotnet/project-system on github), which is the one which supports those kinds of projects.  Release date is expected to be July, though there will be some previews available earlier.

Phew, not on mobile anymore.  Much easier to link.  @biosek if you're interesting in tracking it, here is the link.  You'll notice Milestones say "15.3".  That means the 3rd update of Visual Studio 2017 (and 15 is the technical version of Visual Studio).  3rd update is supposed to be out around July.


Should just the slides cover a 50 min lecture ?

The contribution guidelines says that each topic must have 30 slides. If the contents just for the slides is less than 50 mins , can we go through the jupyter notebook and explain ?

Hi, thanks for the message. The suggestion is that each slide deck should have at least 30 slides and cover a 50min lecture. Usually you need at least one additional hour to cover the Jupyter Notebook. These are just recommendations and not hard and fast rules. Obviously, you can adjust the times to suit your class schedule and program. Hope this clarification helps.
Andre de Waal
OpenDS4All Technical Steering Committee Chairperson


[improve][connector] Handle kafka sinks that return immutable maps as configs (#14780)

(cherry picked from commit b56d7318e73fb6915208dbe1223446e759c2ed0b)
Motivation
Some Kafka sinks return immutable map as config (e.g. ones written in Scala)
As result KCA sink fail to start/throws exception on attempt to modify such config.
Modifications
Handle this situation.
Verifying this change
Modified test connector to return Unmodifiable map, verified it breaks the sink tests, fixed.
Does this pull request potentially affect one of the following parts:
No
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@dlg99 we add the 'cherry picked' label only after committing to that branch


Remove np.random.seed from test modules

Context:
Currently different modules in the test suite use numpy seeds to make the tests in each particular module deterministic. However, using seeds in this manner breaks the possibility of running tests in random order (to check for no inter-test dependency).
Description of the Change:
This PR removes numpy seeds from test modules when possible (some specific test do requiere to set a seed), leaving pytest-randomly as the responsible of setting and configuring the state of the random number generator and the execution order of the tests.
Benefits:
Random number seeds are set by pytest-randomly and reproducibility is achieved by seeding pytest execution instead of each test module.
Possible Drawbacks:
None

Note: this PR is not removing the set seed from the CI test execution (i. e., --randomly-seed=42 pytest's option), only the unneeded np.random.seed spread across the test modules.


https://www.pombase.org/status/gene-coordinate-changes

This table is quite unwieldy as a web page and contents are often obscured by the menu as you scroll left and right.
I think it would be better if this page had some minimal information about gene structure alterations and a link to a config file or view only google sheet.
Column headings would be
systematic ID
standard name
old coordinates
new coordinates
description of comment
source
date
I'm mentioning this now because I have a large bunch of new ones, I'd like to change over format before these are added.
At present
old coordinates
new coordinates
description of comment
are munged into a single field.
We would not always have old and new coordinates, but this is fine. Somebody can dig these out later if necessary
(actually, since these are all changes since the last submission, they will be the coordinates in the current EMBL file, so easy to find)

I'd like to implement these gene structure updates in the main contig files once I finish chromosome I 5'UTRs
https://github.com/pombase/curation/issues/3024
@mah11  could you see if you can have a stab at arranging a tab delimited file for the existing ones next week ?
Although, if we have a format I can  make sure I compile them correctly.

Brilliant. I can check the ones from the curation ticket.
In fact, thankyou for adding these. I still need to actually implement the changes, but adding to the spreadsheet already will save a task. I haven't done the gene structure changes in the main contigs  yet (I'm working on the UTRS in a copy of the file so that I can import them all in one go).
I will be able to import chromosome 1 new UTRs shortly and adjust the gene structures in the contigs to match them.
I'm up to 4.97Mb....it is soooo boring...

I think we can go ahead and switch to display these files.
I'm not so worried about losing a few notes, most are  jut gloss if the change is recorded.

The dev PomBase now has these changes - the TSV files are turned into tables when the site is released
Before:

https://www.pombase.org/status/new-and-removed-genes
https://www.pombase.org/status/gene-coordinate-changes

After:

http://dev.pombase.kmr.nz/status/new-and-removed-genes
http://dev.pombase.kmr.nz/status/gene-coordinate-changes

Please let me know if you see any problems.  The change will be in the main site on Tuesday morning.

The new gene coordinates changes table is very short.
existing
https://www.pombase.org/status/gene-coordinate-changes

The table at http://dev.pombase.kmr.nz/status/gene-coordinate-changes is truncated. The first missing entry is also the first of several lines in which the Comments column contains a frameshift description that includes an arrow (e.g. Frameshifted by Chr_II:825012!G→A).
Coincidence? I suspect not ....

Thanks.  Fixed now and I've updated the main site.


[$250] [Group Chats] [Polish] Move "Leave" button into a row of the Report Details page

As discussed with @shawnborton and @JmillsExpensify we want to update the design of the Report Details page with the following changes:

Move the "Share" row into the ChatDetailsQuickActionsBar
Move the "Leave" button out of this component and into it's own row here.

Result:

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b00ddeb3014a078a
Upwork Job ID:<PHONE_NUMBER>229118464
Last Price Increase: 2024-04-15

Going to assign myself as part of the details revamp design doc.

@marcaaron @JmillsExpensify
https://github.com/Expensify/App/blob/c75c85f69d46a50258b0cb2870b7b5a4d04702cc/src/pages/ReportDetailsPage.tsx#L323
we only display ChatDetailsQuickActionsBar in the report detail If the report is a group chat. Could you help to confirm whether we should display the ChatDetailsQuickActionsBar for the room report as well?

@DylanDylann

whether the avatar should be displayed larger

I think we can ignore the avatar for the purposes of this issue. We're focusing on the "Leave" + "Share" actions in this ticket.

Do we also display the ChatDetailsQuickActionsBar for the room report

We did this largely to focus the introduction of this behavior and allow testing it for Group Chats in isolation. But I think ideally we would take this opportunity to standardize the UI for this. What do you think @JmillsExpensify?
Since the "Leave" action is the only one with a behavior specific to Group Chats - we should be able to show this for Rooms as well. But we can investigate as part of this issue to make sure that assumption is correct.

@dragnoir same as the other issue, but posting here for posterity:

Figma link

@dannymcclain It means that we still display ChatDetailsQuickActionsBar on both group and room detail pages.

In the group detail page we will display pin and share option
In the room detail page we will display leave and pin option

cc @marcaaron @JmillsExpensify

@dragnoir we should confirm requirements clearly before updating the proposal to save effort 😄

Yeah I was gonna say we may wanna confirm with @JmillsExpensify that those are the correct options/buttons before proceeding.

@DylanDylann re-assigned you if you can push this one forward.

@marcaaron Waiting for confirmation before processing as mentioned here

@dannymcclain @JmillsExpensify any update here?

My two cents: Doesn't seem like we would want that to be inconsistent between Rooms and Groups.

Sorry—missed this one. I think depending on different situations, different buttons show up in that little horizontal group of buttons. There's a Figma file that @shawnborton and @JmillsExpensify have been working on to accompany a bunch of these "detail screen" updates.
@JmillsExpensify mind weighing in here?

In the room detail page we will display leave and pin option

This is probably just a mistake from our Figma files. We want leave to always be a row at the bottom of the option rows, it would never be a button in the horizontal button stack.

Here is a better mockup to reference:

Thank you Shawn!

Thanks for your confirmation. In the scope of this issue, we need to move the "Share" button to ChatDetailsQuickActionsBar and move the "Leave" button into a row, also apply for the Room Detail page. @ZhenjaHorbach's proposal is enough for this and their proposal is first, let's go with them

Thanks for your confirmation. In the scope of this issue, we need to move the "Share" button to ChatDetailsQuickActionsBar and move the "Leave" button into a row, also apply for the Room Detail page. @ZhenjaHorbach's proposal is enough for this and their proposal is first, let's go with them
🎀👀🎀 C+ reviewed

@dragnoir I understand your viewpoint, but this issue doesn't focus on updating to the new UI (you can check the description and title of this issue again). Anyway, this is my decision, let's wait for @marcaaron to give the official assignment

Please

Anyway, this is my decision, let's wait for @marcaaron to give the official assignment

I think this conversation could be taking a bit of an unproductive turn. I have the following thoughts:

We will assign @ZhenjaHorbach here. It's the C+ who should recommend someone. I don't feel the need to go against that decision. C+ need to be able to operate with some autonomy here and should be following our rules.
I don't think this ticket is particularly complex and don't quite feel like anyone is more or less qualified to do it (at least not based on what I can see in this issue). My priority is always to have people work together to implement the best solution.
@dragnoir an option for you could be to prepare some kind of claim that says "I materially contributed x, y, z to this issue" and reach out to the contributor email. Compensation requests for contributors who go above and beyond are pretty typical around here. We have a history of retaining and rewarding people who help us out. We also have some pretty clear language in the contributing guidelines about all of this IIRC so please review them again at your leisure.

Still working through PR

Hmm I don't think I am following, can you rephrase your question? Perhaps @marcaaron knows the answer though.

Yep, so if we're removing the the "Share" code rows from views that have it those will need to have the "Pin" and "Share" buttons added otherwise there is no way to "share". @DylanDylann is asking if we want to only show the button UI for Group Chats and I believe the answer is "No". Let's make sure it shows up on pretty much all the chats where we currently show a "Share" code.

Ah, right. We do want to update that everywhere. But I guess I'd be curious to know from @JmillsExpensify - how are we managing these group-specific GHs (that have changes we want everywhere) with your Details clean up project?

@shawnborton As I understand, in this issue we will display the share button on the ChatDetailsQuickActionsBar in all chats. Do you know how about the pin/unpin button? Currently, we only display the pin/unpin button on the ChatDetailsQuickActionsBar if it is a group chat.

cc @marcaaron

The pin button will be similar in that we want to update it's location on all things that have the ability to be pinned. So on rooms/reports/expenses/etc, the pin button would move to the promoted actions area. At least that is my understanding!

@shawnborton For more understadnable,
This is staging

Expect

cc @marcaaron

I guess you can't Join groups or #announce rooms as a heads up.
But @DylanDylann I agree with your "Expect" screenshot, though I think when we have just one button, we use a max-width of 50% of the space or something like that.
So cc @grgia - just want to make sure you have visibility into what's happening on this issue.

Okay cool, that makes sense to me.

Ah, right. We do want to update that everywhere. But I guess I'd be curious to know from @JmillsExpensify - how are we managing these group-specific GHs (that have changes we want everywhere) with your Details clean up project?

@shawnborton good question. This one wasn't on my radar, though what we're doing here will definitely affect what we doing across the platform for the "details revamp." @grgia do you have any recommendations for how we handle this? I think what we're doing here is fine, as long as it's future-compatible with the broader changes we are making soon.

@Expensify/design @grgia  Summary: We always display Pin and Share button in the promoted area in every detail report like this

Please give a thump up if you agree
cc @ZhenjaHorbach

We should never have "Leave" as a button - if we do have the option to leave a room, it should show as a row at the bottom.
We've got some nice mockups in Figma here for you to see. Just request view access and we'll let you in.

Hi team - should this issue potentially be solved as part of the work that's being done here?

Looks kind of unrelated to me tbh. We could combine in into this ticket, but might add more confusion than it avoids.

Okay thanks Marc!

Working through PR.

This issue could be included in https://github.com/Expensify/App/issues/42071, I don't think we need to create a regression test for this issue

Yes, and in fact, we have a whole set of regression tests created for a related project, so I agree that we're covered on that front.

Payment summary:

Contributor: $250 @ZhenjaHorbach
Contributor+:$250 @DylanDylann

Both contributors paid via Upwork. Closing.


test: add a helper to join and normalise paths (NFC)

This ensures that all paths that are generated in lit are normalised
after being formed.  This is in preparation for supporting execution of
the tests on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Keyboard Manager Per-keyboard remapping.

Allow keys to be remapped on a per-keyboard level. This would allow you to use a second keyboard/numpad etc that is completely remapped.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

From https://github.com/microsoft/PowerToys/issues/1460#issuecomment-602807162
we tried to see if this was possible but doesn't look like we can tell the different between inputs from different keyboards


feat: update to track latest spec changes

Automated changes after Neon spec has been updated

:tada: This issue has been resolved in version 1.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.0.0-beta.3 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


🐛 Demo site: It is sometimes possible to add a color property twice

Describe the bug
Sometimes it is possible to add a color property twice (eg. two "ExcludingDaysLabel" colors. This shouldn't be allowed.
To Reproduce
Steps to reproduce the behavior:

Visit the demo site - https://streak-stats.demolab.com/demo/
Expand "Advanced Options"
Click the add property (+) button 11 times (until all properties are added)
Click the remove (−) button next to the "Dates" property
Click the add property (+) button while "ExcludingDaysLabel" is selected in the menu
"ExcludingDaysLabel" gets added again even though it's already added

Expected behavior
Properties already added should not appear in the dropdown.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
OS: Arch Linux
Browser: Brave
Version: 1.57.47
Smartphone (please complete the following information):

Device: Pixel 6
OS: Android 14 beta
Browser: Brave
Version: 1.57.60

Hey @DenverCoder1 Can I work on this? I don't know If I can solve this, still wanna take this as a challenge.

@sakibian Sounds great! Let me know if you have any questions.
It seems like what needs to be done is make sure that first available option (that is not disabled) gets selected in the select element when a property is removed.

Hey @DenverCoder1 this error is not only happening to the last option field, but it's also happening to other options as well,

I think we need to come up with some logic where the disabled option gets hidden when the length is 0 or deleted from the list, showing only those options that are not disabled.

I think the problem is that the disabled options are still able to be added when they are still selected.
If we can make it deselect the disabled option after an option is removed, that should fix it.
We have some code in the addProperty function to do this: https://github.com/DenverCoder1/github-readme-streak-stats/blob/1af2a506b6713eac10fd3ffd2dc7c124a398a05b/src/demo/js/script.js#L79-L82
If we get these couple lines to run when removeProperty is called, it might resolve it.

Is this issue is still exist? Can I take this issue?

@DenverCoder1 I've got a few issues I need to resolve first, you can unassign me and assign new contributors to this issue, and I'll track your issue list and contribute to other ones.

Can I work on this issue? @DenverCoder1

@Arzzam Sounds good to me. 👍
This is probably a 1-line fix.

Ok thank you


Added the Korean (kr) language support

Hi team,
Thank you for all your efforts for implementing this create viewer.
I want to add the the Korean locales to the viewer.
If you prefer letting me to work on the Locize, you can create the space for the Korean language and let me know too.
Thank you in advance for your support.

I'm closing this as not planned because it's related to v2-legacy. Keeping it open might suggest we support fixing issues in v2-legacy. If this problem persists in v3, please open an issue or, even better, provide a fix for v3.


Adding support to read json plans

Fix: #10
CC: @richtia
After CI Passes, I'll merge it, but then I still have to add a PR at DuckDB to support the latest version of substrait and to have functions in the Python and R API :-)

CC: @richtia
After CI Passes, I'll merge it, but then I still have to add a PR at DuckDB to support the latest version of substrait and to have functions in the Python and R API :-)

Awesome! Thanks @pdet !


rearrange for faster build time

On my computer, this decreased the single-thread build from 5 minutes to 3 minutes and the multi-threaded build from 27 to 16 seconds.

on github actions, the build time went from 2:49 to 1:38. But windows didn't work.... I'll look into this more later.

Pull Request Test Coverage Report for Build 301336417

1453 of 1748 (83.12%)  changed or added relevant lines in 17 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.006%) to 81.271%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

goalc/regalloc/LiveInfo.h
0
1
0.0%

goalc/regalloc/allocate.cpp
11
14
78.57%

game/kernel/Ptr.h
0
4
0.0%

goalc/emitter/CodeTester.cpp
8
12
66.67%

goalc/compiler/Compiler.cpp
15
23
65.22%

goalc/compiler/Val.cpp
2
10
20.0%

goalc/compiler/compilation/CompilerControl.cpp
4
12
33.33%

common/goos/Interpreter.cpp
243
278
87.41%

goalc/regalloc/Assignment.cpp
0
36
0.0%

goalc/compiler/FrontEnd.cpp
1149
1337
85.94%

Files with Coverage Reduction
New Missed Lines
%

goalc/compiler/Compiler.cpp
2
64.66%

Totals

Change from base Build 301140291:
-0.006%

Covered Lines:
14576

Relevant Lines:
17935

💛  - Coveralls

This turned out to be too hard to fix on windows, I'll revisit this later.


Using sc to register Hubble as a service on WIndows

We have observed that if Hubble process is terminated, Hubble service still shows as running.
This is due to the fact that we register Hubble service via nssm. Actual windows service monitors nssm process which in turn is responsible for monitoring Hubble process.
Switching to 'sc' to check if we can register Hubble as a service with all configuration options that we have with 'nssm'.

any update with regards to tests with using sc?

Created new PR as we still plan to use nssm but in a more efficient manner.


Model failed to load on ARM CPU

I am using a raspberry pi 4 with openvino 2022.1 on raspbian buster os, I tried following this link to build arm plugin:
https://github.com/openvinotoolkit/openvino_contrib/wiki/How-to-build-ARM-CPU-plugin
I tried the third , native compilation method.
I cloned 'releases/2022/1' branch of openvino_contrib and used it.
I used open model zoo's object detection demo:
I ran yolo model using the following command:
python3 object_detection_demo.py -i ~/Downloads/person-bicycle-car-detection.mp4 -m ~/Downloads/person-vehicle-bike-detection-crossroad-yolov3-1020.xml -at yolo -d CPU
Got this error:
Traceback (most recent call last):
File "object_detection_demo.py", line 298, in
sys.exit(main() or 0)
File "object_detection_demo.py", line 183, in main
detector_pipeline = AsyncPipeline(model)
File "/home/pi/.local/lib/python3.7/site-packages/openvino/model_zoo/model_api/pipelines/async_pipeline.py", line 86, in init
self.model.load()
File "/home/pi/.local/lib/python3.7/site-packages/openvino/model_zoo/model_api/models/model.py", line 173, in load
self.model_adapter.load_model()
File "/home/pi/.local/lib/python3.7/site-packages/openvino/model_zoo/model_api/adapters/openvino_adapter.py", line 66, in load_model
self.async_queue = AsyncInferQueue(self.compiled_model, self.max_num_requests)
RuntimeError: std::bad_alloc
Kindly help resolve this issue.
Or is there a model specific for object detection model to run on arm cpu.

It worked with releases/2022/3. Thanks!


Upload books

Hi,
Thanks for your work, I tried the demo and it seems pretty solid. The only thing I didn't find which I would love to have on this kind of an ebook server (hosted remotely) is a way to upload books (instead of having to transfer them to the server's folders). This is more of an enhancement request. Do you plan to add a way to upload books any time soon ?

Yes, it is planned. I actually have started working on it. I have already implemented refreshing the index dynamically. All I have left is to add the upload page and user management. I have been busy recently, so I cannot get to it right now, but I will be working on this more soon.

How would you be thinking of uploading books? WebDAV? An upload page?
Also, how would you want authentication to work? Single user? Password? Multiple users?

Hi, thanks for your answer, I was not even thinking about user management as I was imagining using this for myself, with an IP check of sorts, or htaccess password. An upload page would definetly do the job ^^

How about a HTTP header with an Authorization token. You would be able to pass it with htaccess, and it would still be secure without another reverse proxy. Does that sound good?
Also, where would the files be put? The books dir? Somewhere else?
Btw, what is @badaz and @badasve

If you want my opinion about authorization / authentication I'd say that the best system would be a user authentication system and a rights system for authorization, whatever the implementation, but then you need a db. So if such a system does not exist in the code maybe you should leave the decision to use a reverse proxy / htaccess to the dev installing your server on their machine instead of implementing a headers system, and add a way to disable uploading books for people who already use your solution on public servers for reading purposes only (using a config file of sorts). But this is just my opinion !
As for the files, I'd put them in the books dir yes.
About @badasve @badaz : I have two github accounts and I never know which one I'm using :)

#23


Master to Live

Docs Build status updates of commit 699f185:
:clock10: Full build: the average full build time is 18 min(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 699f185:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Get-MessageTrace.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Remove-BlockedSenderAddress.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOAppInfo.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantLogEntry.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOWebTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1304ee0:
:clock10: Full build: the average full build time is 17 min(s) 59 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1304ee0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Get-MessageTrace.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Remove-BlockedSenderAddress.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOAppInfo.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantLogEntry.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOWebTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOOrgAssetsLibrary.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 1b93f7e:
:clock10: Full build: the average full build time is 17 min(s) 59 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1b93f7e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

exchange/exchange-ps/exchange/Get-MessageTrace.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Remove-BlockedSenderAddress.md
:white_check_mark:Succeeded
View (exchange-ps)

sharepoint/sharepoint-ps/sharepoint-online/Add-SPOOrgAssetsLibrary.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOAppInfo.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOTenantLogEntry.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOWebTemplate.md
:white_check_mark:Succeeded
View (sharepoint-ps)

sharepoint/sharepoint-ps/sharepoint-online/Set-SPOOrgAssetsLibrary.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add test and output method for Pickers

WHAT
Towards https://github.com/google/horologist/issues/91
WHY
Needs test and example of getting a value out.
HOW
Add Compose test and verify that date is returned.
Checklist :clipboard:

[x] Add explicit visibility modifier and explicit return types for public declarations
[x] Run spotless check
[x] Run tests
[x] Update metalava's signature text files

cc @BowerSteve


datetimes in params of simulate_ methods.

If you place a datetime into the params dictionary, it becomes distorted in the req.params. The result is 2017-12-11T18:50:45 00:00 where it should be 2017-12-11T18:50:45+00:00. The missing '+' doesn't allow correct parsing by the dateutil parsing.

Hi @fyaretskiyso, the + character is often used instead of %20 to represent spaces in query string params, due to the historical conflation of form parameter encoding (application/x-www-form-urlencoded) and URI percent-encoding.  Therefore, Falcon, converts + to a space when decoding the query parameters.
RFC 3986 actually specifies + as a reserved character, and recommends percent-encoding any such characters when their literal value is desired (%2B in the case of +).
In your case, that would mean passing 2017-12-11T18:50:45%2B00:00 instead of 2017-12-11T18:50:45%2B00:00.

[Please reopen if escaping doesn't work out and we'll explore some other options.]


IMU traits

Modifies IMU trait to actually return the IMU data and adds FusedIMU trait to access quaternions
Removes feature level IMU selection

I made a few refactors in the code. I didn't want to proceed with my own implementation because you already worked hard on this and to submit my own code would be both redundant and also snub you of authorship. So I was wondering if you would be willing to rebase this PR on main and make the changes above.
Alternatively, I could proceed with my own implementation if that is more convenient for you.

Re: Concerns

I do want to support feature parity with legacy firmware at minimum, and hopefully beyond. Adding what I know we'll need in the future (consumed in #157 ) helps us see what the requirements are and merging it to main now "lets others build on it". I would not make any assumptions about microcontrollers including any branch predictors, but that being said I doubt this will be a performance issue. If it is, I just propose we upgrade our minimum spec to the level of the ENIAC, which should be able to handle the overhead for about 50 IMUs (5000 boolean comparisons/s)

For IMUs that produce fused data, there is the FusedImu trait. Calling this trait RawImu would imho be misleading as it does not output raw imu data. The data has been normalised to common metric units and possibly even ran through pre-fusion filters, like lowpass

I don't see why we should write code in an append-only manner. Luckily our version control system keeps track of file history and the function can be copy pasted back if the need arises

Changing one line in an .rs ending file is equally easy as changing one line in a .toml ending file, and former lets us run workflows on all IMUs at once instead of a matrix. This is good because it exposes issues like writing self::imu::ඞ::math, (only the bmi160 integration implements driver crate functionality in firmware). This change would not have been necessary if the pre-required architectural functionalities  were implemented first, but you suggested IMUs should be worked on first.

Re: Comments

We already require Rust nightly. If adding new nightly features is to be avoided, this can be replaced with async_trait crate until we move entirely off alloc

Adding an API with no consumers or implementors is pretty useless, for added commit history noise.

Speaking of that last point, I do hope you clarify the contribution guidelines. As you can tell, I have a lot of beef with how it is dealt with currently, and is actively making me not want to go through the hoops of PRing.
My current understanding of our collaboration policy:

PR even if the feature is incomplete
Do not PR incomplete features
You can PR code that is known to be broken to main (Pog section)
You can't PR code that might be broken to main
You can break main
You can't break main (comments/2)
We use continous integration workflow to avoid conflict pain
However, because of this approach I now have to rebase 6 PRs within 12 hours of opening them
Your time is wasted because of the contribution policy
You do not participate in the contribution policy
Don't force push
Do force push

I really do hope you have the time to work out the contribution guidelines. Because as it is, there is no way for me to work that is efficient, produces good code and is enjoyable. Jumping through these hoops takes a lot of energy and I dont have the same monetary motivators like you do. And when im very frustrated, I become very annoying, which surely saps your mood too

For IMUs that produce fused data, there is the FusedImu trait

Sorry let me clarify what I meant. I realize what I communicated was misleading. I meant that we should have two traits, a RawImu and a FusedImu. FusedImu currently exists on main.

I do want to support feature parity with legacy firmware at minimum, and hopefully beyond. Adding what I know we'll need in the future helps us see what the requirements are and merging it to main now "lets others build on it".

Yes I agree. But this PR removes all feature flags for imus, I'm not advocating not merging in imu support, I'm advocating not mixing those architectural changes in with other unrelated features like imu traits and fusion algos. You can merge sensor fusion and imu support just fine under the existing system without eliminating the imu feature flags.
But maybe your concern was that you don't want to have to add more CI jobs, as you say here:

Changing one line in an .rs ending file is equally easy as changing one line in a .toml ending file, and former lets us run workflows on all IMUs at once instead of a matrix.

I agree that the many ci jobs is silly, especially as its just building the code. In #161 I introduced a change that removes the feature gating of the modules and dependencies, while retaining the feature flags for easy testing. I desire to switch from feature flags to env vars soon, but I do not wish to need to directly edit the .rs file to choose the imu. #161 is my preferred stepping stone towards env vars, for now. Because the branching of the code is so minimal there, we can easily switch CI to only test imu-stubbed in a followup PR. I'll introduce that change shortly and we can rebase the other imu PRs on that so they don't need to worry about configuring feature flags in CI.

We already require Rust nightly. If adding new nightly features is to be avoided, this can be replaced with async_trait crate until we move entirely off alloc

I'm not willing to adopt the use of async_trait in embedded firmware. Its been a policy that I communicated in discord that I want to adopt rust features only after the esp32 branch gets them. Maybe I didn't make that clear though, or maybe the message got lost in the channel. I think I discussed this more with @ImUrX so thats probably why you didnt realize that is what I was going for. I'll also try to make that clear in contribution guidelines but for now know that I want esp32 builds green in CI, and we are day(s) away from that being possible now.
All of that being said, I said that I'm fine with the use of async fn in trait. Thats why it was in the "comments" and not "concerns" section. I was explaining my rationale on why I was accepting the change.

I don't see why we should write code in an append-only manner. Luckily our version control system keeps track of file history and the function can be copy pasted back if the need arises

Adding an API with no consumers or implementors is pretty useless, for added commit history noise.

We have beat this horse to death, There comes a point where discussion has hit a wall, and we hit that wall a while ago. I won't discuss it more. I'll clarify things in a soon-to-be-added md file that describes the review process.

I just propose we upgrade our minimum spec to the level of the ENIAC

If I was in a better mood, I would find this funny. Unfortunately, the response instead frustrates me, as it reads as "passive aggressive".

My current understanding of our collaboration policy:

While I understand you are frustrated, so am I. I have never seen a three person open source project need a contribution guideline. I already spent a lot of time making contribution guidelines mostly focused on tooling, which got out of date very quickly, so I have been hesitant to codify more stuff in READMEs. However, tooling is different from process, so since its important to you to have some clarity on process, I'll write that up in a .md file, submit a PR for it and request your review so you can leave any thoughts.
However, the tone of your message reads to me as very passive aggressive. I'm sure you are well intended and this is borne out of frustration, but please understand that when someone (me) is already quite frustrated with arguing constantly with someone (you), its not going to improve the situation to communicate like you are doing in your comment. I'm sure it took a decent amount of time to filter through discord messages, individually citing each scenario, which isn't really productive either for you or for me.

And when im very frustrated, I become very annoying, which surely saps your mood too

Yes, it does sap my mood. I am having a not good time ™. At least on github, please be considerate and communicate professionally. I'll also work on being more considerate. Hopefully the tone of my response here is professional and polite. If it reads any other way, this is not my intention, and I'll try to improve on that too.

Jumping through these hoops takes a lot of energy

Right now, no one else is having problems with the hoops. @ImUrX and @kitlith have been contributing successfully to the codebase fine. But I acknowledge that everyone is used to different processes. I'll reach out to them and try to figure out what revisions to the process are necessary to streamline things.

I dont have the same monetary motivators like you do

I have made 50 usd from 1 paypal donation by a person that wanted a specific feature. I've also sponsored @ImUrX with more than 50USD of donations, to cover his hardware expenses. My net operating cost on this project is negative, and I am not currently desgining boards for mass manufacturing (and ferrous_slime is really just for a couple of friends, and I won't be shipping the rust firmware on those boards to them unless we reach a lot more stability). Instead, there are numerous other individuals who will likely have a nrf52840 board production ready well before the firmware is even in a shippable state. Please don't make assumptions about finances and money, its uncouth.

Separately from my response btw: I still wanted to know your opinion on this:

So I was wondering if you would be willing to rebase this PR on main and make the changes above. Alternatively, I could proceed with my own implementation if that is more convenient for you.

I think a lot of parts have been discussed, but I'm interested on what I was lately been thinking about.

4. Changing one line in an .rs ending file is equally easy as changing one line in a .toml ending file, and former lets us run workflows on all IMUs at once instead of a matrix. This is good because it exposes issues like writing self::imu::ඞ::math, (only the bmi160 integration implements driver crate functionality in firmware). This change would not have been necessary if the pre-required architectural functionalities  were implemented first, but you suggested IMUs should be worked on first.

So, I'm kind of against this. But it seems like you trust that It is gonna be better than the toml/env idea, you know what, I want an actual branch trying to do this. I'm interested in seeing how it looks and how well it works. Can you please try implementing this? I will discuss it with you on the discord channel also :P

Technical:

I meant that we should have two traits, a RawImu and a FusedImu

My using of "this" was confusing. We do have both, but they mean different steps of the data processing pipeline. I intend them as I have implemented them in this PR.  FusedImu trait is a source of orientations, that have been somehow fused from IMU data. This can be either done in the firmware through a fusion algorithm like DCM or VQF, or by the chips own firmware. The other trait is Imu, which I was refering to with "this". Imu does not produce quaternions, but rather IMU data. However, the IMU data is not raw data, and thus isnt called RawImu (and ImuData is not called RawImuData). IMU data may be processed in any number of ways. Simplest processing that every Imu implementor  does is normalising the values to common metric units. Additionally, filters like lowpassing, throttling, outlier detection, significant motion detection can and should be done before the data is fused to an orientation. Such filtering is either done by our firmware or the IMU firmware

But this PR removes all feature flags for imus, I'm not advocating not merging in imu support, I'm advocating not mixing those architectural changes in with other unrelated features like imu traits

IMU traits (and moving to generics) is a change motivated by wanting to move away from the #[cfg] sus pattern.  One does not make sense without the other, and using both is technically impossible. In other words, this PR changed the feature flags because this PR was about getting rid of the feature flags.
Policy:
You are absolutely free to copy any changes you want from my PR to the code. The code is licensed under apache 2.0 and/or MIT, and my ego is not a factor in technical decisions.
Until you can provide me with a concrete target of how you want me to act, I will not be spending my time rebasing my PRs. Once you can clarify how you want contributions to work, in terms that are self-consistent and possible to follow, I will follow that way.
I am frustrated and unprofessional. Its incredibly frustrating to try and help with a project, when the maintainer gives conflicting requirements and fails to elaborate for weeks on end, or provide any technical or logical reasoning. I apologize for being so petty. I do it in hopes that you acknowledge the framework you make me work in

Superseded by #172 #171 #161 #167 #160


are_alive function feels like it should return a boolean or be renamed

Is it meant to be used to test for "truthiness" or are the strings it returns meant for use by the caller? If the latter, maybe get_alive_hosts or something would be a clearer name.

This should return back the list of hosts that are found to be 'alive' on the network.

ah ok, then what about get_alive_hosts? since “is” prepends the name of the
boolean-returning function.
On Thu, Nov 3, 2022 at 03:00 Heath Brown @.***> wrote:

This should return back the list of hosts that are found to be 'alive' on
the network.
—
Reply to this email directly, view it on GitHub
https://github.com/heathdbrown/pscanner/issues/2#issuecomment-1301561460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVVCNAABKA7UJMZDJ3SNWDWGMMFBANCNFSM6AAAAAARVD7XVU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Zev Averbach
Averbach Transcription
(802) 276-5934
avtranscription.com