fix(obstacle_stop_planner): fix the issues when use_predicted_objects true

Description

In obstacle_stop_planner, use_predicted_object option was added but it does not work as we wanted. Firstly, there are some bugs while checking the obstacle. For example, it uses the last collision footprint to set collision point.

Also, it checks only intersected points while checking collision, however, corner points also need to be checked.

Also I needed make some changes in adaptive_cruise_planner while using predicted objects, because perception side is estimating obstacle velocity, adaptive_cruise_control does not need to estimate the velocity.
Related links

Tests performed
For Z-Axis-Filtering:

Stop test:
https://user-images.githubusercontent.com/45468306/234703822-f77bb994-44c5-4cea-91b1-fb4b973e74b0.mp4
Vehicle following:
https://user-images.githubusercontent.com/45468306/234703863-45086564-16a7-4bf9-82fb-0c5840198111.mp4
Slow-down:
https://user-images.githubusercontent.com/45468306/234703885-1a831ab6-36a1-434f-bb34-e3e90ddc2538.mp4

Notes for reviewers

Interface changes

Effects on system behavior

There is no effect for system behavior, all things working as we wanted.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota @shmpwk @taikitanaka3 @tkimura4 also if it is not problem, I want to add myself as maintainer. I want to maintain this package.

@satoshi-ota @shmpwk @taikitanaka3 @tkimura4 also if it is not problem, I want to add myself as maintainer. I want to maintain this package.

@brkay54 OK. We TIER IV are glad you are maintaining this package. Then, please add your name in package.xml like that. I think it is better to create other PR for adding maintainer. I'll approve quickly if you done.
https://github.com/autowarefoundation/autoware.universe/blob/e7f8c1258afb559f5be6b3fe8110ca90db74ca0c/planning/obstacle_stop_planner/package.xml#L8

Thank you @satoshi-ota . I created PR for this: https://github.com/autowarefoundation/autoware.universe/pull/3559

@brkay54 I ran action and updated code owner in https://github.com/autowarefoundation/autoware.universe/pull/3557.

@brkay54 Sorry for late response. I would like to check this PR by scenario tests. Is this PR ready for review?

@satoshi-ota Yes all of the PRs ready for review.
FYI: Merge order should be like this:

https://github.com/autowarefoundation/autoware.universe/pull/3556
https://github.com/autowarefoundation/autoware.universe/pull/3558
https://github.com/autowarefoundation/autoware.universe/pull/3560

Scenarios test is running now...
Please wait a while.

@satoshi-ota Thank you for your review 🙏🏼 . Other PRs are rebased.

@brkay54 cc @mehmetdogru
We have a new obstacle_cruise_planner package to stop/cruise/slow down against predicted objects.
https://autowarefoundation.github.io/autoware.universe/main/planning/obstacle_cruise_planner/
We TIER IV will replace the obstacle_stop_planner with the obstacle_cruise_planner for the stop/cruise/slow down planner.
I heard that Ota-kun introduced this package to you, but do you have any reason not to use the obstacle_cruise_planner?

Hi, @takayuki5168 we are also planning to switch to obstacle_cruise_planner but currently using obstacle_stop_planner because the last time I asked in Discord, @mitsudome-r said it is only used in R&D vehicles to be tested.
While testing the obstacle_stop_planner, we saw some bugs and fixed those. After testing the latest obstacle_stop_planner enough, we will also switch to obstacle_cruise_planner. Thank you for your recommendation! 🙏🏼

Hi @brkay54
I found that you are NOT registered as CODEOWNER correctly.
Github says:

Unknown owner on line 51: make sure a user with the email address<EMAIL_ADDRESS>exists and has write access to the repository

in this file.
Have you registered your company email address with github? If you haven't, could you register it? (Or fix address in package.xml.)

@satoshi-ota Thank you for informing me! Sorry for that. I added the mail address as a secondary address. Can you check it again, please?


The plugin for class 'jsk_rviz_plugin/BoundingBox' failed to load.

Describe your issue here and explain how to reproduce it.
In rviz jsk bounding boz isa not working.
Your environment

OS Version:  Ubuntu 18.04
ROS Distro: Melodic
RViz, Qt, OGRE, OpenGl version as printed by rviz:paste your console output here

bhaskar@bhaskar:~$ rviz
[ INFO] [1632309468.929576303]: rviz version 1.13.18
[ INFO] [1632309468.929616904]: compiled against Qt version 5.9.5
[ INFO] [1632309468.929627362]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1632309468.935375665]: Forcing OpenGl version 0.
[ INFO] [1632309469.498149342]: Stereo is NOT SUPPORTED
[ INFO] [1632309469.498202934]: OpenGL device: NVIDIA GeForce RTX 3090/PCIe/SSE2
[ INFO] [1632309469.498216452]: OpenGl version: 4.6 (GLSL 4.6).
[ERROR] [1632309477.418149497]: PluginlibFactory: The plugin for class 'jsk_rviz_plugin/BoundingBox' failed to load.  Error: Failed to load library /opt/ros/melodic/lib//libjsk_rviz_plugins.so. Make sure that you are calling the PLUGINLIB_EXPORT_CLASS macro in the library code, and that names are consistent between this macro and your XML. Error string: Could not load library (Poco exception = /opt/ros/melodic/lib/libjsk_recognition_utils.so: undefined symbol: _ZNK3pcl6search6SearchINS_8PointXYZEE7getNameB5cxx11Ev)

This is an issue with libjsk_rviz_plugins.so, not of rviz.
Please report this issue over there: https://github.com/jsk-ros-pkg/jsk_visualization


force SCS in diffcp

Forces diffcp to use SCS, since the diffcp conic interface already assumes this.

The push/branch builds failed because they pulled diffcp 1.0.15, instead of the latest version. The PR builds succeeded (they got the latest version), so I'm merging this change.


token type is member

There is no such token type in the spec

vscode:

@backtolife2021 Hi just a quick question since I am trying to debug my own theme with this plugin: How did you extract the name of the token type at cursor position?

@kmoschcau Hi
plz see https://github.com/theHamsta/nvim-semantic-tokens/issues/15#issuecomment-1245333871
https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#scope-inspector

I'm not sure whether this still works: https://github.com/nvim-treesitter/playground/pull/57 probably not since a lot of things have changed since then (also the tree-sitter part has updated in this PR)

There is no such token type in the spec

The language servers can themselves decide what they return. They return mostly the standardized types but sometimes they return multiple tokens for the same thing. E.g. rust-analyzer has a dedicated token type for lifetimes. How did you print the token type with Neovim?

Sadly that only works with servers that support range tokens.

@I-Want-ToBelieve in vscode "member" is deprecated and refers to "method". So you see "method" in vscode.
https://github.com/microsoft/vscode/blob/1.73.0/src/vs/platform/theme/common/tokenClassificationRegistry.ts#L560

VsCode classification for nvim:
semantic_tokens.token_map.comment = "@comment"
semantic_tokens.token_map.string = "@string"
semantic_tokens.token_map.keyword = "@keyword"
semantic_tokens.token_map.number = "@number"
semantic_tokens.token_map.regexp =<EMAIL_ADDRESS>semantic_tokens.token_map.operator =<EMAIL_ADDRESS>semantic_tokens.token_map.namespace = "@namespace"
semantic_tokens.token_map.type = "@type"
semantic_tokens.token_map.class = "@type"
semantic_tokens.token_map.interface = "@type"
semantic_tokens.token_map.enum = "@type"
semantic_tokens.token_map.struct = "@structure"
semantic_tokens.token_map.typeParameter = "@type"
semantic_tokens.token_map["function"] = "@function"
semantic_tokens.token_map.member = "@method"
semantic_tokens.token_map.method = "@method"
semantic_tokens.token_map.macro =<EMAIL_ADDRESS>semantic_tokens.token_map.variable = "@variable"
semantic_tokens.token_map.parameter = "@parameter"
semantic_tokens.token_map.property = "@property"
semantic_tokens.token_map.enumMember = "@constant"
semantic_tokens.token_map.event = "@variable"
semantic_tokens.token_map.label = "@label"
semantic_tokens.token_map.decorator = "@attribute"
semantic_tokens.token_map.attribute = "@attribute"

semantic_tokens.modifiers_map.readonly = {
  variable = "@constant",
  property = "@constant",
}
semantic_tokens.modifiers_map.constant = {
  variable = "@constant",
  property = "@constant",
}

semantic_tokens.modifiers_map.defaultLibrary = {
  typeAlias =<EMAIL_ADDRESS>  type =<EMAIL_ADDRESS>  class =<EMAIL_ADDRESS>  interface =<EMAIL_ADDRESS>  variable =<EMAIL_ADDRESS>  property =<EMAIL_ADDRESS>  enum =<EMAIL_ADDRESS>  ["function"] =<EMAIL_ADDRESS>  method =<EMAIL_ADDRESS>}

Rust extension:
-- Rust: Style for builtin attributes
semantic_tokens.token_map.builtinAttribute = "@attribute"
-- Rust: Style for builtin types
semantic_tokens.token_map.builtinType =<EMAIL_ADDRESS>-- Rust: Style for char escapes in strings
semantic_tokens.token_map.escapeSequence =<EMAIL_ADDRESS>-- Rust: Style for {} placeholders in format strings
semantic_tokens.token_map.formatSpecifier = "@operator"
-- Rust: Style for the self keyword
semantic_tokens.token_map.selfKeyword = "@keyword"
-- Rust: Style for the self type keyword
semantic_tokens.token_map.selfTypeKeyword = "@keyword"

Same for nvim 0.9 (without this plugin)
https://gist.github.com/qRoC/288727caed4aa361ef5f15fa7852ca3e


Improve error handling in LW Agent

Right now the initial version doesn't have adequate error handling.  I am worried that messages might get lost if transport fails.
We need error handling, fault injection, and  such to test and make sure that exactly once delivery happens.

For reviewability reasons deferring this in the first review of the LW Agent.


Doc validation

Opening a new since #981 went sideways.  The conversation is still there, at least.

lgtm barring assuming Travis is green

merged


Remove bot from #pypa

This bot is creating a lot of noise in #pypa, we'd appreciate it if it were removed. Thanks!

Sorry that I seen that PR just now. I fixed it.
I am not used to watch PRs to my own repos, notification got lost between others.


create marts for MITx Online certificate and profile data

What are the relevant tickets?

https://github.com/mitodl/hq/issues/1716
https://github.com/mitodl/hq/issues/1748
Description (What does it do?)

This adds marts__mitxonline_course_certificates and marts__mitxonline_user_profiles for IRx.
How can this be tested?

Run dbt build --select tag:IRx

@blarghmatey These two marts are created for IRx. I didn't specifically create directories named IRx just to be consistent with the existing marts for micromasters. But let me know if you have trouble applying proper permission to these two marts

@KatelynGit @blarghmatey can you both review this?
Kate, I want to make sure you understand and agree with the SQL and the schema.
Tobias, you'll have to share this with Jon Daries so he can pull it regularly. You know the best what's needed for that.

At the mart level the affiliation with products is not as important as in staging or even intermediate layers. For the marts we should scope them by use case/consumer. In this case I'd argue for a layout like marts/irx/mitxonline_certificates with a schema that is just a combination of the two tables as a single flat representation. That eliminates the need for joins on the consumer side, as well as scoping the tables to an irx namespace. Similarly for when we start building the finance marts.

I've renamed marts to mitxonline per discussion with Tobias. @KatelynGit @blarghmatey This is ready to be reviewed

Looks like there are 6,515 users that are in the ol_warehouse_production_intermediate.int__mitxonline__users but not in the new mart user table. I'm assuming this might just be a timing thing or due to proper filtering but wanted to double check. Can you take a look?

@KatelynGit Yes, if you were looking at my schema, it's stale and has not been updated for a while. Since this mart is simply a select from intermediate, I didn't run all the upstream models as we have test in intermediate to ensure count match with staging, etc.


BUG!!!

On Purpur 1.20.4-2155, because of the ECO library, it writes to the console which block the player broke. Please correct it. And the players began to complain that they could not mine ore.
To Reproduce
Steps to reproduce the behavior:

Download Purpur 1.20.4-2155
Download library ECO
Place the ECO plugin in the plugins folder.
On server

That there will be blocks in the console that the player has destroyed. Also sometimes players cannot mine ore.
Screenshots
Yes...
Server Information (please complete the following information):

Version: git-Purpur-2155 (MC: 1.20.4)*
Version of plugin and eco: eco version 6.69.0

The console spam has been patched in today's update. The update should be available on all platforms now.


GOMAXPROCS usage instead of NumCPU for the pool size

What
runtime.GOMAXPROCS() is used instead of runtime.NumCPU() to detect a default pool size.
Why
We are running our services in the Kubernetes cluster and usually, each of them consumes (and is limited to) 2-3 CPUs.
But it's a logical restriction and runtime.NumCPU() will return all available CPUs on the node(64 in our case).
That's why we set the GOMAXPROCS env variable to improve system's performance.
In the current implementation, each of our services can create 5 * 64 connections to each Redis node, which in our case means ~300 * 5 * 64 = ~100k connections to the single node (if I'm not mistaken)
Thanks to the lazy connection initialization it happens rarely and completely unexpected. Once service or Redis node is busy the client starts generating a huge number of connections:

Pros and cons
The main benefit of the change will be the more reasonable defaults. Less unexpected behavior and fewer incidents in production :)
The main downside is that default behavior has changed in some cases. In most cases, GOMAXPROCS is equal to num CPU, but sometimes is not. But I do believe that it's more reasonable value and more aligned with the original purpose of using NumCPU() as a pool size

Thanks


Feat/remote-pointer-handling

Co-authored-by: Rémi Leroy<EMAIL_ADDRESS>

This definitely requires some docs in:

api.md to explain the new props
tutorial.md to explain how to support web pointers


演示

Uploading 演示.mp4…

Uploading ys.mp4…

https://github.com/user-attachments/assets/525e55a1-e4b4-49dd-838d-98468eafb8c8


[IOS][Layout] [Extra UIView in the container with only 1 ColumnSet element, and sometimes this cause extra space for the card]

Platform
IOS
Author or host
Host - Teams IOS
Version of SDK
Both SDK 1.2.7 and the latest master
Details
We want to show several items on one card. For the first item, it is one Container with only one ColumnSet element. The payload is shown below.
{
  "type": "Container",
  "items": [
    {
      "type": "ColumnSet",
      "columns": [
        {
          "type": "Column",
          "width": "stretch",
          "items": [
            {
              "type": "TextBlock",
              "size": "large",
              "text": "Backup2 on-call schedule for the [Cortana Experience\\Cortana on Android/iOS CoA/CoI Cortana Exp China DRI] team",
              "wrap": true,
              "maxLines": 2,
              "spacing": "medium"
            },
            {
              "type": "TextBlock",
              "isSubtle": true,
              "text": "Today, 9:00 AM - Tomorrow, 12:00 AM",
              "spacing": "none"
            }
          ]
        }
      ]
    }
  ]
}

But sometimes, for the same payload, the first item would have an extra space UIView like this.

After investigation, I find that every container would have an extra UIView. Attached the payload.
new_payload.txt
In most cases, the extra UI view's height would be zero and won't affect UI, but not sure why sometimes, it would extend height to 20.5px.

The UI view could also be found with the Adaptive card latest master branch.

@jwoo-msft thoughts on this one real quick?

@VikrantSingh01 is this something that you are aware of/tracking?

Any update on this issue, I suspect it is related to the below code to add extra UIView, but not sure why the height > 0 sometimes.
https://github.com/microsoft/AdaptiveCards/blob/main/source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRColumnRenderer.mm
if (columnElem->GetVerticalContentAlignment() == VerticalContentAlignment::Center || (columnElem->GetVerticalContentAlignment() == VerticalContentAlignment::Top && _fillAlignment)) {
      trailingBlankSpace = [column addPaddingSpace];
}


[bug] html2image for long page fail

It's not work(timeout) when the web page is a bit long.
But it is not really timeout, page is not very long, however, I run the project in GoLand with the same web page, it convert image successfull .
url: http://<IP_ADDRESS>:8080/convert/html2image?u=doctron&p=lampnick&url=https%3A%2F%2Fwww.cnblogs.com%2Fgrkin%2Farchive%2F2013%2F03%2F17%2F2964964.html
Originally posted by @TailendWong in https://github.com/lampnick/doctron/issues/37#issuecomment-1560375350

Can you try on your own linux server?

I meet the same issue, i build a docker image from Dockerfile that is in the project, then i run it on my own linux server.
I got response like this:
{"code":30000000,"message":"worker run process failed.job request timed out","data":null}
Actually, i try change config convertTimeout: 600, it is also return 30000000 like above. So, i think it may not be timeout.

You can increase the timeout time in the configuration file. convertTimeout: 20

You can increase the timeout time in the configuration file. convertTimeout: 20

Thanks for your reply


Create sweep transaction

The idea is to generate a fully signed transaction that sends all the wallet balance to an address that is controlled by the user.

It is in case user forgot the passphrase. And he sets the address himself + can update it.
OFC you can say "What if he forgot his other seed and also forgot the passphrase and also forgot to update his recovery address?"
Well in that case he is still fucked. It's simply an extra layer of protection.

A proper sweep would create a TX for each input address to a different output.
What's the use-case for this feature over doing a simple Send MAX?


error in demo.py

Dear community,
I'm using mx-net 0.11.1 under windows x64 with cuda 8. Executing the ssd example i encountered serveral problems. As i have seen in other related issues some will get fixed. I fixed a few myself but now i have a problem.
File "C:\local\Anaconda3-4.1.1-Windows-x86_64\envs\mxnet\lib\site-packages\mxnet\io.py", line 395,       in prefetch_func
self.next_batch[i] = self.iters[i].next()

File "D:/MachineLearning/MxNet/incubator-mxnet/example/ssd\dataset\iterator.py", line 215, in next
pad=self.getpad(), index=self.getindex())

File "C:\local\Anaconda3-4.1.1-Windows-x86_64\envs\mxnet\lib\site-packages\mxnet\io.py", line 156, in __init__
assert isinstance(data, (list, tuple)), "Data must be list of NDArrays"
AssertionError: Data must be list of NDArrays

I get those error's and i must admit i don't see the cause of this. The test images and models get loaded correctly. At least i'm thinking that after debugging. Does anyone know how to solve this issue?
I can reproduce this easily by typing:
demo.py --epoch 0 --images ./data/demo/dog.jpg --thresh 0.5

Best Regards

#8064
Will fix this once merged.

Thank you very much! I'm knew to mxnet and didn't see the cause right away.


IntoPy for #[pyclass(extends=...)] ?

Context
I am trying to wrap a few Rust objects in a Python API - basically an enum of a few different types.
enum Things {
    Obj1(String),
    Obj2(f64),
}

I want to represent this as, roughly, something like this:
class BaseThing:
    def as_obj1(self): ...
    def as_obj2(self): ...

class Obj1(BaseThing): ..
class Obj2(BaseThing): ...

So, I created a base pyclass,
#[pyclass(name="BaseThing", subclass)]
#[derive(Debug, Clone)]
pub struct PyBaseThing {
}

..and pyclass for each of the variants:
#[pyclass(name="Obj1", extends=MyBase)]
#[derive(Debug, Clone)]
pub struct PyObj1 {
}

#[pyclass(name="Obj2", extends=MyBase)]
#[derive(Debug, Clone)]
pub struct MyObj2 {
}

All good so far (this explanation is missing a bunch of detail and isn't an entirely correct summary of the actual code, but hopefully enough to give context for my question)
Problem
Problem is when I try to implement the fn as_obj1(&self, py: Python) -> PyResult<PyObj1> { Ok(PyObj1{}.into_py(py)) } , I can't get past the error:
method cannot be called on PyObj1 due to unsatisfied trait bounds because
    = note: the following trait bounds were not satisfied:
            `PyObj1 AsPyPointer`
            which is required by `&PyObj1: pyo3::IntoPy<pyo3::Py<pyo3::PyAny>>`

If I change #[pyclass(name="Obj1", extends=MyBase)] to #[pyclass(name="Obj1")] then all compiles and works, except the Obj1 is of course not a subclass of my BaseThing
After a bit of poking around and rereading the docs several times, I spotted the sentence

All types in PyO3 implement this trait, as does a #[pyclass] which doesn't use extends.

..however this a bit cryptic to me. Is there a reason the "pyclass-with-extends" cannot implement IntoPy? Is there another conversion trait I should instead?
Not urgent as in my case the subclass hierarchy is just a "nice to have" thing, and I can just drop the extends=... for now

Currently stuck on the same thing (https://github.com/PyO3/pyo3/discussions/2294). What is the correct way to create a Python instance of a class with inheritance then? Or can they only be instantiated from Python code?

With apologies this is still a very unpolished part of PyO3.
You can use .into_new_object method of PyClassInitializer to create a new Python object from the initializer. However that's really an internal API we use from macro code. If someone was interested in working on this area of PyO3, help would be welcome.


-playing doesn't do much

It only leaves an 👌 , and doesn't actually change the "game". Same for streaming

nvmd, had rotating games on.


Fix init script using incorrect houdini-svelte version

When running npx houdini init on a brand new svelte project, the init script would incorrectly assume the version for the houdini package is the same as the version for the houdini-svelte package.
This PR fixes it by altering the build script to fetch the package.json files for all the packages, and then either use houdini's version, or houdini-svelte's version
To help everyone out, please make sure your PR does the following:

[x] Update the first line to point to the ticket that this PR fixes
[x] Add a message that clearly describes the fix
[ ] If applicable, add a test that would fail without this fix
[x] Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
[x] Includes a changeset if your fix affects the user with pnpm changeset

Needed to tweak the github action to use the new sv cli tool since it replaces create-svelte


Message

This issue is opened for communication

Can we keep communication issues focused instead of general? So if you need information on a specific topic, open an issue about that topic. Then, we can close each issue when the topic is resolved.
Anyone see a problem with that?


Team fortress 2 and SDK detection doesn't work

When launching the latest build of oftoast2 on Windows 10 22H2 x64 with a shell (with or without --verbose argument), it doesn't check for Team Fortress 2 and Source SDK. This has worked in alpha5.
Alpha 5:
alpha5log.txt
Latest build:
latest log.txt

This is because I removed it when refactoring the OF path checking code and forgot to put it back in - fix impending


Unable to resolve module react-native-reanimated/src/derived/interpolate

Bug
I have tried to install the component and use it as a standalone, just as described in the docs and I end up with a series of errors in metro bundler. error: Error: Unable to resolve module react-native-reanimated/src/derived/interpolate from<EMAIL_ADDRESS>react-native-reanimated/src/derived/interpolate could not be found within the project or in these directories:
I have tried the suggestions given by the error but no luck so far.
Environment info

Library
Version

@gorhom/animated-tabbar
2.1.1

react-native
0.64.1

react-native-reanimated
2.0.0

react-native-gesture-handler
1.10.3

react-native-svg
12.1.1

Steps To Reproduce

install all the packages & dependencies as prescribed in the docs
try to create the tabs like so:

Reproducible sample code
import React from 'react'

import AnimatedTabBar from '@gorhom/animated-tabbar'
import { createBottomTabNavigator } from '@react-navigation/bottom-tabs'
import { NavigationContainer } from '@react-navigation/native'

import HomeTabNavigation from './HomeTabNavigation'
import ProfileTabNavigation from './ProfileTabNavigation'

const tabs = {
	Home: {
		// < Screen name
		labelStyle: {
			color: '#5B37B7'
		},
		icon: {
			component: null /* ICON COMPONENT */,
			activeColor: 'rgba(91,55,183,1)',
			inactiveColor: 'rgba(0,0,0,1)'
		},
		background: {
			activeColor: 'rgba(223,215,243,1)',
			inactiveColor: 'rgba(223,215,243,0)'
		}
	},
	Profile: {
		// < Screen name
		labelStyle: {
			color: '#1194AA'
		},
		icon: {
			component: null /* ICON COMPONENT */,
			activeColor: 'rgba(17,148,170,1)',
			inactiveColor: 'rgba(0,0,0,1)'
		},
		background: {
			activeColor: 'rgba(207,235,239,1)',
			inactiveColor: 'rgba(207,235,239,0)'
		}
	}
}

const TabNavigator = createBottomTabNavigator()

const MainTabNavigation = () => {
	return (
		<NavigationContainer>
			<TabNavigator.Navigator
				initialRouteName="Home"
				tabBar={props => <AnimatedTabBar tabs={tabs} {...props} />}
				backBehavior="none"
				lazy={false}
			>
				<TabNavigator.Screen
					name="Home"
					component={HomeTabNavigation}
				/>
				<TabNavigator.Screen
					name="Profile"
					component={ProfileTabNavigation}
				/>
			</TabNavigator.Navigator>
		</NavigationContainer>
	)
}  ```

Should I use some other packages versions?

I think it has to do with this: #107

the solution provided by @prabhatm6 also works.
What i did was install exactly 1.31.1, and not the latest or the 2.x version of react-native-reanimated.
so this also works: "react-native-reanimated": "^1.13.1". (a clean install was needed - with node_modules remove, and pod install)


Update README.md

Pull Request
Problem
When setting a default on an option with choices, the inferred type degrades back to string. I took me a few minutes to figure out this was because of the default parameter in the first place.
Solution
Adding this to the appropriate section of the readme might help someone with the same issue along in the future.
ChangeLog
Add note about type inference for option with choices and default.

I usually wait for a release to update even pure documentation, but in this case we probably won't do another minor version release before the major release. Are you ok with merging this to main now without a release @abetomo ?

I agree to merge into main.


Robot Stopped Communicating after a Few Moments in SLAM or Tele Modes

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[ ] Burger
[ ] Waffle
[x] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[x] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] etc (Please specify your SBC here)
[ ] Intel Joule 570x
[ ] Raspberry Pi 3B+
[x] Raspberry Pi 4

Which OS you installed on SBC?

[ ] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[x] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[x] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [1.15.9]
Firmware version: [1.2.6]

Specify the commands or instructions to reproduce the issue.

roslaunch turtlebot3_slam turtlebot3_slam.launch
roslaunch turtlebot3_teleop turtlebot3_teleop_key.launch

Copy and Paste the error messages on terminal.

No error message were shown.

Please describe the issue in detail.

When entering SLAM mode using teleop (https://emanual.robotis.com/docs/en/platform/turtlebot3/slam/#run-slam-node) or use teleop alone, the robot moves okay at the beginning. But after a few moments, the robot will stop moving without having any obstacles nearby, and when I check the dynamixel motors, I find them locked and the wheel cannot spin anymore. There is no battery shortage. Not sure if there are any operational mistakes from me, or it is a bug.
There is no updated topic values coming from the robot. I found out that this situations happens not only under SLAM teleop mode, but also normal teleop mode.
When this happens in SLAM mode, I killed the SLAM process and relaunch it, and find the map is empty and also I cannot make the robot move unless I reboot the robot.

Hi,
It is difficult for me to identify what causes your system stall.
You might find more useful information from Raspberry Pi forum.
Make sure that your RPi4 is still connected to the network when the symptom occurs.
I'd also check the system log and see what is happening.
Faulty SD card may also causes unexpected issues.

Thank you Will. I'm thinking about what I could have done wrong, there are some of my guesses:

The voltage of Raspberry Pi may be unstable? I use the battery in the package, I'm not sure if these similar situations happened before.
I use a virtual machine from my Mac as the remote PC. Does this cause problem?

Thanks,
Wei

Hi @LW-G38
The battery that comes with TurtleBot3 can provide enough power to run RPi4, but if you are heavily using RPi resource, you might want to add heat sink or a fan for active cooling.
Virtual machine is usually not recommended as there could be various issues. Issues occurred when using a virtual machine is difficult to debug.
Thank you.

Thanks Will. Is there any place I can check the log file of the turtlebot? Or should I use a monitor to connect to the Pi or use VNC to observe?

I may need to re-install the operating system of my Pi. In this case, do I need to set up OpenCR from scratch as well? Thank you.

Please find the Ubuntu system log for your Raspberry Pi and see if there's any issue with your system.
At this point I cannot assure that your issue is directly related to TurtleBot3 packages.
You don't need to setup the OpenCR again as you have already uploaded the Noetic firmware to OpenCR.
Thank you.

I'm also facing the same issue. When I use the Lithium-ion battery as a power supply, the motor stuck after a few moments. However, the system working completely fine with a direct 12V power supply.

@nullbyte91
Your case is related to the power source. Make sure to use the official TurtleBot3 3S Li-Po battery, and check if the battery is in a good condition.
If the battery had been fully depleted before, it may have a damaged cell and may not fully functional due to the damaged cell.

@ROBOTIS-Will I got the waffle pi a week before, and I fully charged my battery before I use.

@nullbyte91
Sorry about the delayed response.

the motor stuck after a few moments

Does this mean the wheels are locked up with torque on? or can you rotate them by hand?
What voltage do you read from the battery status message?

This issue will be closed due to prolonged inactivity.


[tuify][giti] Release it and publicize it on twir, r/rust

@nazmulidris Please do let me know about when to do this. Probably on Saturday I can write a spicy blog on tuify and refer giti as example in blog post and publish the link into TWiR.

@NadiaIdris @Harshil-Jani Maybe the two of you can coordinate on this and take care of creating the content & publicizing it.

@Harshil-Jani Yes, please, go for it 🙂! Let me know when it's ready for proof reading or if you want to share an early draft, that's cool too. If you need any help with it, let me know. We can publish it on developerlife.com.


how to convert mp3 music file in resourcepack?

in title

You can use a online format converter to convert mp3 to ogg format.


Update angular

Codecov Report

Merging #189 into rc-ng4-upgrade will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4294b9...4f62a32. Read the comment docs.


Highlight unconnected sub-expressions.

I's not always easy to tell that something is disconnected from the main equation - would it be possible to highlight unconnected terms with a different colour?

Partially addressed in 7c6eb5b. Glitches exist.

Closing as this now pertains to better selection of the candidate expression rather than merely highlighting.


update the fisuser-service to use Apicurito

Quoting Gary Gaughan:
The fis user service uses community and then dev studio. [1]
Using Apicutio standalone using the camel project generator button to generate the skeleton code, might be our best foot forward.
—gary

[1] https://github.com/rh-integration/IntegrationApp-Automation/tree/master/fisuser-service

I'm happy to add more detail if required?

Quick question: does the Camel code generation handle code update (when the API Contract is updated ?)

Its a stateless version of apicurito, while the window is open you can update and edit. Generating a new project will update and work. It will download a new fuse SB project to your local machine.

@gaughan if I am not wrong, you're pointing us to use the approach, somehow given in this article https://access.redhat.com/documentation/en-us/red_hat_fuse/7.2/html-single/designing_apis_with_apicurito/index

Yes

@gaughan Thanks for your input, I have changed the approach now using Apicutio to generate the skeleton code. https://github.com/rh-integration/IntegrationApp-Automation/tree/master/fuse-user-service#api-curio-setup

Awesome, thanks!

So the instructions mention, design and download your api and then rename it. You don't need this step. When you download the fuse project, the api defn is in the resources directory as openapi.json If you run mvn on this project the defn is available and published at endpoint/openapi.json

you're right, it gets generated with name openapi.json, and it's not necessary to change the name, but as in my case, I have the different project's so I want to make clear when user access like curl http://localhost:8080/cicd/userservice-spec.json he knows that, which project open API file he accessing.

So this is one part of a bigger walkthrough? If you run it as described from this set of instrustions alone, even with renaming, openapi.json is still our one source of truth and is available at http://localhost:8080/openapi.json


Individual Review Ticket-Week 1

5.3 Notes
5.4 Notes
InfoDB Loops & Lists
Fibonacci Loop
Comments and Documentation in Code

5.3 Notes -> 1/1
5.4 Notes -> 1/1
InfoDB -> 1/1
For Loop -> 1/1
While Loop -> 1/1
Recursive Loop -> 1/1
Fibonacci -> 1/1
Documentation/Comments -> 1/1


don't know how to use this library

don't know how to use this library into golang project with template.... any start up gudie?

how to use this??

Can it be used together with html/template?


add stop for roller shutter devices

Thanks for the PR @vectah0! I see you've added the command for stopping, but it seems there are other commands for shutter/blinds as well. We could add those as well. But maybe a better solution is to check if the payload is numeric and if not always call device.performCommand for it. Then we can prevent having to exclude all commands. What do you think about that?

as far as I know the commands for shutters are ON(DOWN/UP), STOP, OFF(DOWN/UP) and SWITCH_MULTILEVEL for taking control of the shutters using a slider for example, please correct me if I'm wrong. Which other commands did you mean?

The commands supported by Zway for shutters/blinds can be found at https://github.com/Z-Wave-Me/home-automation/blob/a3ad2baa7f8453f3df6adead9896498926eb8833/modules/ZWave/index.js#L2599
You mentioned the most important, but there are a few more apparently.


framework not found Reachability / linker command failed with exit code 1 (use -v to see invocation)

Ld /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Products/Debug-iphonesimulator/OpenEarsSampleAppSwift.app/OpenEarsSampleAppSwift normal x86_64
cd /Users/veeralbhateja/Documents/GitHub/cherrypickprice-sw/OpenEarsSampleAppSwift
export IPHONEOS_DEPLOYMENT_TARGET=10.0
export PATH="/Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode-beta.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin"
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.1.sdk -L/Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Products/Debug-iphonesimulator -F/Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Products/Debug-iphonesimulator -F/Users/veeralbhateja/Documents/GitHub/cherrypickprice-sw/OpenEarsSampleAppSwift/../Framework -F/Users/veeralbhateja/Documents/GitHub/cherrypickprice-sw/OpenEarsSampleAppSwift -filelist /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Intermediates.noindex/OpenEarsSampleAppSwift.build/Debug-iphonesimulator/OpenEarsSampleAppSwift.build/Objects-normal/x86_64/OpenEarsSampleAppSwift.LinkFileList -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -Xlinker -rpath -Xlinker @executable_path/Frameworks -mios-simulator-version-min=10.0 -dead_strip -Xlinker -object_path_lto -Xlinker /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Intermediates.noindex/OpenEarsSampleAppSwift.build/Debug-iphonesimulator/OpenEarsSampleAppSwift.build/Objects-normal/x86_64/OpenEarsSampleAppSwift_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -Xlinker -objc_abi_version -Xlinker 2 -fobjc-link-runtime -L/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator -Xlinker -add_ast_path -Xlinker /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Intermediates.noindex/OpenEarsSampleAppSwift.build/Debug-iphonesimulator/OpenEarsSampleAppSwift.build/Objects-normal/x86_64/OpenEarsSampleAppSwift.swiftmodule -lc++ -liconv -lz -framework AVFoundation -framework Accelerate -framework AssetsLibrary -framework AudioToolbox -framework CoreMedia -framework MicroBlink -framework Reachability -Xlinker -sectcreate -Xlinker __TEXT -Xlinker __entitlements -Xlinker /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Intermediates.noindex/OpenEarsSampleAppSwift.build/Debug-iphonesimulator/OpenEarsSampleAppSwift.build/OpenEarsSampleAppSwift.app.xcent -framework SystemConfiguration -framework UIKit -framework CoreGraphics -framework Foundation -lsqlite3.0 -framework MicroBlink -framework CoreMedia -framework AudioToolbox -framework AVFoundation -framework Accelerate -liconv -lz -lc++ -framework Slt -framework OpenEars -framework Pods_OpenEarsSampleAppSwift -Xlinker -dependency_info -Xlinker /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Intermediates.noindex/OpenEarsSampleAppSwift.build/Debug-iphonesimulator/OpenEarsSa
mpleAppSwift.build/Objects-normal/x86_64/OpenEarsSampleAppSwift_dependency_info.dat -o /Users/veeralbhateja/Library/Developer/Xcode/DerivedData/OpenEarsSampleAppSwift-dnkewgekjwisfufqooufocwtsrrk/Build/Products/Debug-iphonesimulator/OpenEarsSampleAppSwift.app/OpenEarsSampleAppSwift
ld: framework not found Reachability
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I installed it using Cocoapods and Manually as well. I am using Xcode Version 9.1 beta.
Cocoapods is giving the error as shown in screenshot above.

Hi. I have encountered the same issue. The problem is that the framework name was changed since the version 4.0, as it says on the site. So first you should check out this information. Moreover I had to delete the framework from pod file and from Targets->Build Settings-> Other Linker Flags. Then I reinstalled the pods.

Closing as stale - feel free to update with more info of your setup if the problem persists.

For me it worked!
Xcode-->Runner-->Build Setting-->Search(OTHER_LDFLAGS)-->Other Linker Flags  Clear all


Missing manifest.json on npm

We are missing the manifest.json file when installing the dependency using NPM. Can you release this fix in a 0.9.1? Thx!

It's intentionally not included in the npm. The manifest is meant only for the website.

Actually, the manifest was initially introduced to allow frontend applications to automatically discover the list of supported icons (see the file history). It would be nice to have it back!

@sindresorhus Why can't this be merged? It was extremely useful and I don't see any issue it may cause...

Awesome thanks!


Windows defender detects fps unlocker as a trojan :/

Newest version of the fps unlocker does this and is it possible to fix it or should i just ignore it?

ignore


Parallelize all the datasets and run them on a schedule

Only in sandbox, though. If the run works I'll get to work on the production credentials.

@zschira whee! Look at all the failures! I guess we need to add some more robust retrying logic + maybe fix some other bugs that I haven't dug into yet 😅
I wonder if we could run some sort of "subsetted" version of this on sandbox as integration test...?

Oh no! It looks like most of these are timeouts or rate limiting problems. We're definitely going to need to investigate to make this more robust. I did notice one error I had meant to address in my last round of fixes, but I guess I forgot to get it in there: #55

Glad you're getting this retry logic worked out, I can't wait to see this PR with all green checkmarks!

Closing in favor of #59 .


Yarn lockfile is outdated after creating release branch

After creating a release branch (i.e. after running the create-release-branch CLI, completing the release spec, and saving it without error), the lockfile remains stale. The user has to manually run yarn to update it.
The tool should automatically update the lockfile when applying the release spec.

Fixed by #145.


Department user interface

I'm submitting a...

[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

there is no user interface to add Department.
Expected behavior

there should be a user interface to add Department with Department name, company, manager, location, Image.

user interface added. now need to modification every page & and method accordingly snipe IT app


/Users/ashmithamohan/data-structures-and-algorithms/Dynamic Programmi…

Instead of using a regular for loop with an index, you can use a range-based for loop to iterate through the vector, which makes the code more concise and easier to read.

thanks @AshmithaMohan


Add faq commands

Description
Added a command /faq that allows the user to ask a FAQ related to KTANE modding. It takes in a category option. When selected, the bot will show a dropdown of questions related to that catgeory.

When the user selects a question from the dropdown, it will send a message to the answer to said question. The dropdown will reset in order for the question to be asked again.

Bugs/Future Implementations

I would prefer if the answers were sent with EPHEMERAL. However, some of the answers are sent in multiple messages to get around the character limit and have images send "in between" messages. Unless multiple messages can be replied to for one interaction, I don't think this is possible.

An alternative (which we can discuss about if it's a good idea) is to delete the messages after a certain time, maybe an hour or so.
Another possible feature to prevent spamming is to make it so a questions can't be asked if it's already in the channel. Though I know this isn't possible if all the messages are all EPHEMERAL

Notes
It's okay if you modify the question/category objects, though I ask that you don't change the ids. I want those to be consistent so it's easy to target the objects even if their other content changes.

Merged into Test


feat(tabs): Implement a couple of features and fix bugs of tabs

Checklist

[ ] Fix linting errors
[ ] Tests have been added / updated (or snapshots)

Change information

Task linked: CU-3tvnee Tab Component

:tada: This PR is included in version 1.0.0-alpha.43 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


split out core pubgrub resolver into separate package?

As someone looking to add transitive dependency resolution to an in house package management system, I am quite surprised by the dearth of generic libraries targeting this issue. Everyone seems to roll their own without regard to reusability. I assume that you faced the same issue when writing the elba package manager. Any chance you would consider splitting out the core pubgrub solver for general consumption?

There are definitely several parts of elba that would be good candidates for separating out into their own packages (not only the resolver, but also semantic versioning, etc.). I'll look into doing this once I get the next release out the door.

I’ll second the desire for this, a pubgrub crate would be extremely helpful. There is a standalone semver crate, though I haven’t had much of a look at it.
Happy to contribute to making this happen.

I've created repos for elba's semantic versioning constraints and implementation of pubgrub. The former has already been implemented, while the latter hasn't.
@yawpitch: the reason this crate exists is since semver's version constraints don't fit elba's needs well; the internal representation of version constraints is overly flexible and makes it hard to implement certain features that we need for Pubgrub (i.e. version unions and intersections).
Also, if you'd like to help out with separating the Pubgrub algorithm from elba proper, the relevant code can be found in the src/lib/resolve directory. And if you need any other info, feel free to ask!

Thanks David for creating the repos; I’ve got a bit of of time coming up and I’ll try and get you a PR together that splits out the solver. Michael
On Apr 3, 2019, 06:09 +0100, David Cao<EMAIL_ADDRESS>wrote:

I've created repos for elba's semantic versioning constraints and implementation of pubgrub. The former has already been implemented, while the latter hasn't.
@yawpitch: the reason this crate exists is since semver's version constraints don't fit elba's needs well; the internal representation of version constraints is overly flexible and makes it hard to implement certain features that we need for Pubgrub (i.e. version unions and intersections).
Also, if you'd like to help out with separating the Pubgrub algorithm from elba proper, the relevant code can be found in the src/lib/resolve directory. And if you need any other info, feel free to ask!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hey @dcao, having had a little time to skim the solver module, and I've got a few questions.
First, the implementation appears to be rather tightly bound to Elba's notion of an elba::package::PackageId, and therefore elba::package::Name and elba::remote::resolution::Resolution -- both of which seem to be very sensible , but not necessarily generic to other package management problems. Similarly there's elba.retrieve.Retriever, which might need to be swapped for something completely different in other contexts. It seems to me these could be described by traits representing just the generic subset of their functionality actually required by the resolver itself, but as I'm not all that familiar with either the PubGrub algorithm or your implementation I'm not entirely certain what that subset would be, or how best to refactor to keep the API ergonomic. Have you put any thought into this?
Also there's a few places where I'm just not sure how to disconnect the resolver from the CLI you've built for Elba. For instance there's a section starting on line 429 of src/lib/resolve/mod.rs where instead of using the slog logger used elsewhere there's a direct print to the shell. Seems to me that could be moved to slog as well, but I'm not clear on why it seems to have been special cased.
Lastly, could you describe briefly any modifications / deviations / simplifications you've made from the published pubgrub algorithm, if any?  For instance there's no explicit Term struct and you're passing (PackageId, Constraint) everywhere instead ... that seems perfectly workable, but was there a reason for eliding that detail of the published algorithm?
Thanks,
Michael

I think it'd make sense to represent the Retriever as a trait - we need a central source to get information about packages from. Pubgrub doesn't really care about package names or package ids, so we could represent the "identifier" of a package as an associated type of the trait.

This has been special cased since we want to report this information to the user - by default, we don't show slog logging to the user (this has to be explicitly enabled with --debug-log).

For the most part, this is a pretty faithful implementation of the Pubgrub algorithm (the implementation is derived from the Dart implementation of Pubgrub). There isn't any real difference between using a (PackageId, Constraint) tuple and an explicit Term struct - they'd both contain the same information, it'd just be different names for it.

haha.  Hows it coming Mike?

Hey John... I’m still ruminating on how best to approach decoupling it. A stand-alone implementation isn’t necessarily going to be run in the terminal as part of a CLI package manager, but may be on a server where stdout isn’t going to be sufficient. I also think that adding a Term struct will make the code cleaner and easier to follow, and will also enable it to include some behavior that would make the whole thing more ergonomic for a generalized case.
The main thing is time right now, I need to find a block of it where I can focus on this. Hopefully that will arrive in the next couple weeks.
M


nodeFunction problem when a for loop index is also a variable in the model

A user found this impossible to pin down and reported that it works in jags.
Here is a minimal reprex:
library(nimble)

mc <- nimbleCode({
  for(p in 1:3) {
    x[p] ~ dnorm(mu[p], sd = 1)
  }
  p ~ dunif(0,1)
})

model <- nimbleModel(mc, inits = list(x = 1:3, p = 0.5), constants = list(mu = 1:3))
Cmodel <- compileNimble(model)

I'm thinking we could either treat this as a bug and fix it or we could leave the behavior as is but give a helpful error message.

Let's error trap it. I think it's bad practice to overload the name to refer to index and variable.


docs/add-workflow-guide

Two small things before approving the change request:

Shouldn't it be named 'guides' ? Or does it have any meaning ~ if not, lets get that corrected soon.

What about naming this doc git-workflow.md - makes more sense for me, and i would love to take my tips and tricks from my comment, and straight put them into a new markdown-workflow.md PR. Sounds good ?

Let me know !