[Feature request] Design whole-repo versioning scheme

Is your feature request related to a problem? Please describe.
TileDB-SOMA is a monorepo containing three distinct components.  Of these only one (the Python package) currently has a well-defined, visible, and exported version number.
Describe the solution you'd like
All three components should have a version. Ideally the same version reflecting the same repository state and release tag.
As the C++ library is a required component of the Python package which already has a version, it is a natural candidate to be versioned next.  This should cover both internal use (have an accessor function returning the version number, say the triplet <1,2,4> if the version is 1.2.4) and external by installing versioned with a major.minor scheme.  We already follow a semantic versioning scheme so there is little extra needed to enable it as cmake is supporting this for other builds such as TileDB Core.
The R package can join the party once matured to release status '1.0'.
Describe alternatives you've considered
N/A
Additional context
N/A

@eddelbuettel This is a bit of a tangent, but, do I understand correctly from this r-universe FAQ that it's only possible to install the very latest build from r-universe?

(where the link describes a scheme that I think may, with the right setup, automate resolving an older version to the original git sources and trying to build them; but that's very unlikely to work well for a package like tiledbsoma with a complex build process)
If so, I'm wondering about our path to publishing the R package in a way that dependent packages like cellxgene.census can ensure an expected/compatible version. Is CRAN the answer to that? Another idea (since iteration time with CRAN is a concern) might be to create multiple r-universe packages, each set to build from a different branch of this repo, and maintain internally-stable lineages on those branches.
(We can break this off into a separate issue if it's too much of a diversion from the main point here!)
cc @pablo-gar @ebezzi @aaronwolen @mojaveazure

This is a bit of a tangent,

Yes and yes :grinning:   We have no control over r-universe other than option to participate or not (as well as which packages).  There is now how in the sense of 'one version, or five, or all' of a participating package.  The most recent one it iis.
Moreover the R community does not have that per se.  CRAN is very explicitly 'at HEAD' where everythiing is current and tested.  install.packages() has no version argument.  Neither does update.packages(): it just checks 'is there a newer one'.
Installng additional older version from somewhere else are add-on services from someone else such as using GitHub tags or releases, or fetching an older version from, say, the CRAN archive page. (I believe remotes does all three.)  Then there are MRAN (disappearing) and now PPM/RSPM offering download by date using add-on services.
So all that is a little off-topic for this issue which concerns itself chiefly with the fact that neither the C++ library has a version nor the R version.
But more than happy to help with the other issue!  Open for DM and chat, another issue, a call.  I may ideas.

Thanks @eddelbuettel -- taking this tangent over to https://github.com/single-cell-data/TileDB-SOMA/issues/1427


[BUG]

setuptools version
setuptools==60
Python version
Python-3.7
OS
Linux (Rocky Linux 8.5 aarch64)
Additional environment information
aarch64, not x86_64 related.
Description
Observed when building numexpr with setuptools==60.3.0, setuptools when launched from a custom build of python on aarch64 believes it deals with python2 when it is actually python3.
Expected behavior
Proper python3 detection.
How to Reproduce
pip install setuptools==60.3.0
pip install --no-binary :all: numexpr==2.7.3 --verbose
check numexpr/init.py file, it contains python2 syntax, same goes for "long" used in numexpr/expression.py
Output
###################################################################
#  Numexpr - Fast numerical array expression evaluator for NumPy.
#
#      License: MIT
#      Author:  See AUTHORS.txt
#
#  See LICENSE.txt and LICENSES/*.txt for details about copyright and
#  rights to use.
####################################################################

"""
Numexpr is a fast numerical expression evaluator for NumPy.  With it,
expressions that operate on arrays (like "3*a+4*b") are accelerated
and use less memory than doing the same calculation in Python.

See:

https://github.com/pydata/numexpr

for more info about it.

"""

from .__config__ import show as show_config, get_info

the .__config__ is expected, not __config__
Code of Conduct

[X] I agree to follow the PSF Code of Conduct

Hi @egaudry, thank you very much for reporting this.
Any chance this problem is the same described in #2979?
i.e., any chance numexpr==2.7.3 relies on the deprecated build_py_2to3 command?
This command used to be present in old versions of setuptools and distutils.
Depending on the version of Python you have installed in your machine, the stdlib version of distutils might still have this command available, but you will need to export the environment variable SETUPTOOLS_USE_DISTUTILS=stdlib to use it during the build.
Please notice the automatic 2to3 syntax conversion was deprecated and removed a while ago, so I personally would recommend using a more recent version of the package.

@abravalheri very likely indeed.
would you recommend closing this ticket and create another at numexpr instead then ?

check done with SETUPTOOLS_USE_DISTUTILS=stdlib, confirming what @abravalheri suggested, hence closing this bug report.
thanks


Error opening map

Is there a problem with the new desktop map, its saying error and will not open

what is the issue? it is working on my end.

says... sorry something went wrong
This apge didnt load maps correctly. see javascript console for technical details


qps recovery after 15min when one tikv io hang

Bug Report

What version of TiKV are you using?
./tikv-server -V
TiKV
Release Version:   6.2.0-alpha
Edition:           Community
Git Commit Hash:   b1854926ad92eeedb2cb38dff2dc4bb6b30d49f0
Git Commit Branch: heads/refs/tags/v6.3.0-alpha
UTC Build Time:    2022-09-22 11:03:33
Rust Version:      rustc 1.64.0-nightly (0f4bcadb4 2022-07-30)
Enable Features:   pprof-fp jemalloc mem-profiling portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine cloud-aws cloud-gcp cloud-azure
Profile:           dist_release
2022-09-23T14:03:46.213+0800	INFO	k8s/client.go:131	it should be noted that a long-running command will not be interrupted even the use case has ended. For more information, please refer to https://github.com/pingcap/test-infra/discussions/129
./pd-server -V
Release Version: v6.3.0-alpha
Edition: Community
Git Commit Hash: 3cc82517395deba65bf90fac664927954e8907f6
Git Branch: heads/refs/tags/v6.3.0-alpha
UTC Build Time:  2022-09-20 11:03:03
What operating system and CPU are you using?
8c、16G
Steps to reproduce
inject one tikv io hang
-   name: "one_tikv_io_delay"
    faultType: io_delay(volumeName:tikv,delay:60m)
    selector: "tikv(random)"
    warmUpTime: 10m
    faultDuration: 120m
    recoveryTime: 10m

What did you expect?
qps can recovery in 2min
What did happened?
qps recovery after 15min

/type bug
/severity major
/assign tonyxuqqi

/assign LykxSassinator

/cc LykxSassinator

it's fixed by polished slow score/slow trend


Disabled button can be pressed issue/bug

What does the pull request do?
Add IsEffectivelyEnabled condition to OnClick(from Button)
What is the updated/expected behavior with this PR?
If a controller is disabled(IsEnabled set to false), The Click event won't fire(work) unless the button is enabled.
Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/6957

I added the test in the sandbox. If I did the test in a wrong place, let me know.

Thanks.
For tests you need to create a new test method in tests project. You can add it in this file https://github.com/AvaloniaUI/Avalonia/blob/master/tests/Avalonia.Controls.UnitTests/ButtonTests.cs
I think you can copy and edit this specific method https://github.com/AvaloniaUI/Avalonia/blob/master/tests/Avalonia.Controls.UnitTests/ButtonTests.cs#L273-L284 it already does what you need to test (raises click on some event). You just need to disable button in your test method and check that event was not raised.
p.s. it seems like these tests "Button_Invokes_CanExecute_When_CommandParameter_Changed" and "Raises_Click_When_AccessKey_Raised" are mixed, probably somebody renamed incorrectly by mistake.

Also you can just push commits to the same branch, you don't need to recreate PR

oh my bad.
I made a mistake in the test the assert should have been 0 ; (
Let me fix that

Thanks!


React Native - Deleting output folder after release

Hi!
Today I migrated from code-push-cli to appcenter-cli, but I'm having a problem, I use the generated bundle and sourcemap to upload them for sentry:
https://docs.sentry.io/clients/react-native/codepush/
But, in the final of the release process the appcenter-cli delete the generated folder:
https://github.com/Microsoft/appcenter-cli/blob/master/src/commands/codepush/release-react.ts#L153
I want to propose a flag to avoid delete the output dir, so I could keep the files after a release.

Hi @renatoagds and thanks for submitting the issue. I've been fixed it here: #329 Do you have a chance to take a look at it and check whether it works for you or you have any more issues with that?

Please fix this :D It does not make sense that we are defining output directory and then it is deleted at the end :O We want also send our sourcemaps to Bugsnag

@ruslan-bikkinin hey! thanks for the quick response! I'll test today it and send the feedback. 👍

@ruslan-bikkinin tested your branch and worked like a charm, waiting for a new release. 🚀

Hi @christav, could you please merge this PR in addition to this one https://github.com/Microsoft/appcenter-cli/pull/331 and probably make a new CLI release?

I merged the PR, I'll do a new release on Monday.

Release 1.0.6 is out with this fix. I'm closing this, if 1.0.6 doesn't fix the issue please reopen this.


New toolbar has file and folder separate not together

What's the Problem?
Currently the right menu has the folder and file new options together but the toolbar one is on opposite ends. Also they don't have colored icons and look out of place
Solution/Idea

Alternatives
None
Priorities
No response
Files Version
1.9.28
Windows Version
10.0.19043.1165
Additional comment
No response

Merging with #7581


Breaking out of a Far Manager subprocess terminates entire session

Environment
Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.11.1333.0 (store version)
Other software: FAR Manager (https://www.farmanager.com/)

Steps to reproduce

Launch FAR manager in existing shell or by creating a profile
run sleep 20 inside FAR (here, sleep denotes sleep.exe from Git for Windows or some other program that runs for a while and can be cancelled with a keyboard interrupt)
Bress Ctrl+C to break out of the sleep command

Expected behavior
The sleep command is interrupted and the FAR manager session is continued.
Actual behavior
FAR Manager is terminated.

Far is supposed to intercept and reject Ctrl+C keypresses using SetConsoleCtrlEvent.

Which shell are you spawning it from?
Is the behavior exactly the same if you use a profile whose commandline is far.exe?

This happens regardless of whether I launch it from {{cmd}}, PowerShell, or by using my FAR manager profile:

I can't tell what shell that is inside far manager. CMD doesn't support sleep... so I have to presume you're using a third piece of software in there?

I simply configured the prompt in FAR manager to be a simple $. It is the normal FAR manager shell.

Would you mind sharing your FAR config file? With any personal info redacted as you desire, of course. :smile:

To make things a little more simple, I tried this with a vanilla FAR profile (i.e. I renamed my Far Manager folder in %APPDATA% which caused FAR to create a default profile). The problem persists. However, I can share my Windows Terminal config, maybe there is something in there, although I can't see what it would be:
{
    "$schema": "https://aka.ms/terminal-profiles-schema",
    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
    "copyOnSelect": false,
    "copyFormatting": false,
    "profiles":
    {
        "defaults":
        {
            "colorScheme": "red",
            "fontFace": "FixedSysEx"
        },
        "list":
        [
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44be}",
                "name": "FAR Manager",
                "commandline": "far.exe",
                "hidden": false
            },
            {
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": false
            },
            {
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt",
                "commandline": "cmd.exe",
                "hidden": false
            },
            {
                "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
                "hidden": false,
                "name": "Ubuntu",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": true,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },
    "schemes": [
        {
            "background" : "#0C0C0C",
            "foreground" : "#F2F2F2",
            "black" : "#000",
            "cursorColor": "#FFF",
            "brightBlack": "#F99",
            "brightCyan": "#4ff",
            "cyan": "#4aa",
            "brightPurple": "#f4f",
            "purple": "#a4a",
            "blue": "#222",
            "brightBlue": "#55f",
            "green" : "#13A10E",
            "brightGreen" : "#13A10E",
            "red" : "#C50F1F",
            "brightRed": "#f00",
            "white" : "#CCC",
            "brightWhite": "#EEE",
            "yellow" : "#C19C00",
            "brightYellow": "#C19C00",
            "name": "red"
        }
    ],
    "keybindings":
    [
        { "command": "paste", "keys": "ctrl+shift+v" },
        { "command": null, "keys": "alt+enter" },
        { "command": "toggleFullscreen", "keys": "alt+shift+enter" },
        { "command": null, "keys": "ctrl+," },
        { "command": null, "keys": "ctrl+." },
        { "command": null, "keys": "ctrl+shift+n" },
        { "command": "openSettings", "keys": "alt+p" },
        { "command": "find", "keys": "ctrl+shift+f" },
        { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
    ]
}

Hey sorry for the long silence here - we've had quite the busy month and got a little behind on triage.
Does this repro with any process at the Far prompt like that, or specifically the sleep.exe one?
How did you install Far & git for windows?
For my own future reference,<PHONE_NUMBER> is totally useless as an error code, ERROR_UNHANDLED_ERROR or something 😕

I am in no hurry, and happy to provide any details I can. This happens with every process at the FAR prompt. Both FAR and Git for Windows were installed with the free version of Chocolatey.

Well, I'm having extreme difficulty reproing this on my end 😖
Could you do something insane to try and help narrow this down?  That'll force far to be running in a ConPTY (similar to the Terminal) but not in a Windows Terminal window. I'm trying to see if we can narrow it down to a far+conpty interaction, rather than a far+WT interaction.

I still have the issue (this is @jhhcs' private account), still can't reproduce in a clean setup, just noticed that #6130 and #8942 seem related.

I am again trying to use FAR manager inside Windows Terminal, because it is becoming a very attractive alternative. This bug is the only real problem. A friend was recently able to reproduce it on their machine as well, and I am experiencing the bug both on my private machine and my work computer. The only place I cannot reproduce it is in a virtual environment. Today, I accidentally used Ctrl+C inside a FAR process inside Windows terminal and received a few additional lines of error messages that might help pin down the problem:
14:08:57.330     Main Warn QObject::~QObject: Timers cannot be stopped from another thread
14:08:57.333     Main Crit QEventDispatcherWin32::wakeUp: Failed to post a message (Invalid window handle.)

[process exited with code<PHONE_NUMBER>]

I would like to open this again in the hope that the above error can help figure out the root cause.

For some reason, I never looked into this. You are correct, the bug can be reproduced this way! In short:

I ran cmd.exe
Inside this terminal, I ran wsl
Inside WSL, I ran cmd.exe again
Inside that terminal,  I ran far.exe
When breaking out of a command inside this far.exe, it exited down to the terminal in step 3, i.e. the second cmd.exe.

Interestingly, something very similar just happened to me in a WSL terminal:

I mistyped ./update.sh as ./update., and the entire terminal died right after the bash error message.

I think I discovered a solution for this problem after a discussion in FarGroup/FarManager#442
To summarize: I have installed FAR using chocolatey, and chocolatey installs a command-line shim executable. It is only this shim executable that seems to incorrectly handle Ctrl-C.


lure: provide a fallback url if branch.io is blocked (or down)

Fixes LAND-1047
Apparently branch.io appears on many adblock lists. (see https://github.com/BranchMetrics/web-branch-deep-linking-attribution/issues/538)
We were only returning a lure link if we could successfully create a deep link. We should return the normal/non-branch lure link if we fail to contact branch.io.

The share URL is falling back to the original URL when the deep link one is undefined: https://github.com/tloncorp/landscape-apps/blob/develop/ui/src/state/lure/lure.ts#L273
Could be enough to just return undefined from the catch? Either way you'd get the same functionality in the end, so not a major issue. Just thought I'd mention it


Pass filename to PostCSS correctly

Closes #242

What:
Pass filename to PostCSS correctly so browserslist can read configs correctly.

Why:
#242

How:
For tagged template literals: don't objectify the root node before passing it to the prefixer so that source nodes remain.
For objects: create an Input object and set it on the root node before passing it to the prefixer. (it's pretty hacky)

Checklist:

[ ] Documentation N/A
[x] Tests
[x] Code complete

Codecov Report

Merging #243 into master will increase coverage by 0.03%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   90.26%   90.29%   +0.03%
==========================================
  Files          20       20
  Lines         966      969       +3
  Branches      261      261
==========================================
+ Hits          872      875       +3
  Misses         76       76
  Partials       18       18

Impacted Files
Coverage Δ

src/babel.js
97.74% <100%> (ø)
:arrow_up:

src/parser.js
95% <100%> (ø)
:arrow_up:

src/ast-object.js
89.36% <75%> (+0.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae09c36...eda432e. Read the comment docs.


Update secrets.yaml

It is weird to have password default set to "admin"
For some reason we do not have pmmserverkey by default in here.

Is it okay to have both pmmserverkey and pmmserver in a secret?

Test name
Status

recreate
passed

big-data
passed

scheduled-backup
passed

scaling
passed

upgrade-haproxy
passed

storage
passed

cross-site
passed

haproxy
passed

scaling-proxysql
passed

self-healing
passed

self-healing-chaos
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

self-healing-advanced
passed

self-healing-advanced-chaos
passed

init-deploy
passed

demand-backup
passed

smart-update
passed

operator-self-healing
passed

operator-self-healing-chaos
passed

limits
passed

monitoring-2-0
passed

pitr
failed

affinity
passed

one-pod
passed

upgrade-consistency
passed

auto-tuning
failed

demand-backup-encrypted-with-tls
passed

proxysql-sidecar-res-limits
passed

users
passed

tls-issue-self
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed

proxy-protocol
passed

We run 36 out of 36

commit: https://github.com/percona/percona-xtradb-cluster-operator/pull/1187/commits/cc8a59ccd68c6fae4f0fdaf6fadd4f9fe4f4b236
image: perconalab/percona-xtradb-cluster-operator:PR-1187-cc8a59cc


Concept page – data item title and description

Concept page displays data item title and description
As a researcher
I want see the name of the data item as it is dipsplayed in the NPD and a description of what it is
in order to understand what the data item pertains to
Scenarios
Given I am an anonymous user
And I am on the FSM6YP concept page
When review the content
Then I see the FSM6 data item title
And a description of what the item pertains to

This needs to wait until we've loaded concepts in and done some analysis of how different/how many data items there are within each one.
This needs some thought as to whether we need a "description" on each data item, or "notes" that explain subtle variations (and are potentially option).

The data item "name" needs to contain the table/column address, e.g. KS2_Pupil.FSM_6

Also, larger question of whether each data item should have its own description or whether the concept description is all that's needed (in theory, the latter is true but testing showed that usersd wanted to see a separate description - however, this maybe them not 'getting' the idea of a concept - we need to signpost this better.


angular2-justgage won't compile AOT in Angular 5

Hello.
This is a wonderful tool and we really love it.  But now we have a problem when we upgraded to Angular 5 in that it will not compile --aot.  Uninstalling angular2-justgage, removing code and tag references, my app compiles aot perfectly.
One other interesting note:  When angular2-justgage is installed, it takes the compiler twice as long to compile aot (9.5 minutes).   Uninstalling angular2-justgage, the app only takes 5 minutes to compile aot.
Workaround
Replace justgage with Angular Material 2 Progress Bar component (boo! hiss!)
Compile-Time Error using --aot switch
ERROR in ./node_modules/angular2-justgage/dist/justgage.component.ngfactory.ts
Module build failed: Error: C:\git-hcm\optimizer2\Presentation\node_modules\angular2-justgage\dist\justgage.component.ngfactory.ts is not part of the compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
at AngularCompilerPlugin.getCompiledFile (C:\git-hcm\optimizer2\Presentation\node_modules@ngtools\webpack\src\angular_compiler_plugin.js:620:23)
at plugin.done.then (C:\git-hcm\optimizer2\Presentation\node_modules@ngtools\webpack\src\loader.js:467:39)
at
@ ./src/app/_common/widgets/HcmRiskToleranceQuestionnaire/HcmRiskQuestionnaire.Component.ngfactory.js 17:0-102
@ ./src/app/areas/signup/client/SignupClient.Component.ngfactory.js
@ ./src/app/areas/signup/client/SignupClient.Module.ngfactory.js
@ ./src/$$_lazy_route_resource lazy
<EMAIL_ADDRESS>@ ./src/main.ts
@ multi ./src/main.ts
Environemnt
OS: Windows 10
IDE: VisualStudio Code
Shell Type: PowerShell
NPM Version: 5.3.0
NodeJS Version: 8.4.0
Webpack Version: 3.8.1
Build Command
ng build --prod --aot --sourcemaps=false
JustGage Module
    "angular2-justgage": "^0.2.1",
Angular Modules
  "@angular/animations": "^5.0.3",
   "@angular/cdk": "^5.0.0-rc.1",
   "@angular/common": "^5.0.3",
   "@angular/compiler": "^5.0.3",
   "@angular/forms": "^5.0.3",
   "@angular/http": "^5.0.3",
   "@angular/material": "^5.0.0-rc.1",
   "@angular/platform-browser": "^5.0.3",
   "@angular/platform-browser-dynamic": "^5.0.3",
   "@angular/platform-server": "^5.0.3",
   "@angular/router": "^5.0.3",
tsconfig.json
{     "compileOnSave": false,     "compilerOptions":      {         "outDir": "./dist/out-tsc",         "sourceMap": true,         "declaration": false,         "moduleResolution": "node",         "emitDecoratorMetadata": true,         "experimentalDecorators": true,         "target": "es5",         "typeRoots":          [             "node_modules/@types"         ],         "lib":          [             "es2017",             "dom"         ]     } }

I will try to upgrade this in few days. thanks.

v0.3.0 should fix this. please try again

Verified that component now compiles AOT without error in Angular 5.  Thank you so much, emn178!

It is interesting though that justgage seems causes our build to take twice as long to compile, though,

I can't reproduce. I only see build message once. I use an empty ng5 project and added justgage. It will add extra 4~5 seconds to build.


Rigid body physics

This change is

:tada: this is awesome!  Thanks!

Would it be possible split the solver systems in such a way that you could use the current frame physics state for rendering (another system) while the state for next is being calculated?

Reviewed 1 of 16 files at r1, 30 of 31 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Cargo.toml, line 22 at r3 (raw file):

[dependencies]
cgmath = "0.15"
collision = { git = "https://github.com/kvark/collision-rs/" }

Is there a pending release to collision-rs we should wait for?

src/ecs/physics/prelude2d.rs, line 43 at r3 (raw file):

/// Register required components and resources in world
pub fn world_physics_register_with_spatial<Y>(world: &mut World)

Can the name of the helper registration functions be changed to clarify their purpose for the end user?

src/ecs/physics/systems/impulse_solver.rs, line 83 at r3 (raw file):

/// - `O`: Internal type used for abstracting over cross products in 2D/3D,
///        usually `Scalar` or `Vector3`
pub struct ContactResolutionSystem<P, R, I, A, O>

Should this and the NextFrameSetupSystem be separated out into another module/file?

src/physics/util.rs, line 6 at r3 (raw file):

/// Cross product abstraction
pub trait Cross<RHS = Self> {

Name may be confusing when associated with mathematical types since its not a "true" cross product. I definitely get the requirement to unify an R^3 cross product with the R^2 analog but just calling this out.

Comments from Reviewable

Reviewed 9 of 16 files at r1, 7 of 7 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Cargo.toml, line 22 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Is there a pending release to collision-rs we should wait for?

Na, we can do that fix before we release

src/ecs/physics/prelude2d.rs, line 43 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Can the name of the helper registration functions be changed to clarify their purpose for the end user?

Possibly, I just dont know to what.

src/ecs/physics/systems/impulse_solver.rs, line 83 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Should this and the NextFrameSetupSystem be separated out into another module/file?

Possibly

src/physics/util.rs, line 6 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Name may be confusing when associated with mathematical types since its not a "true" cross product. I definitely get the requirement to unify an R^3 cross product with the R^2 analog but just calling this out.

Its a partial cross product for 2D, full for 3D. PartialCross better?

Comments from Reviewable

Reviewed 1 of 31 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/ecs/physics/prelude2d.rs, line 43 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
Possibly, I just dont know to what.

Perhaps change the helpers in the collide preludes to register_collision and register_collision_with_sorting and then the physics prelude ones to register_physics and register_physics_with_sorting or something to that effect? Is there any harm in unifying them and registering the sorting components by default?

src/physics/util.rs, line 6 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
Its a partial cross product for 2D, full for 3D. PartialCross better?

Actually, yeah that sounds great and is perfectly in line with things like PartialEq where the impl reflects behaviour that resembles the mathematical operation.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

Cargo.toml, line 22 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
Na, we can do that fix before we release

Will defer this until later, since we want to get this merged.

src/ecs/physics/prelude2d.rs, line 43 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Perhaps change the helpers in the collide preludes to register_collision and register_collision_with_sorting and then the physics prelude ones to register_physics and register_physics_with_sorting or something to that effect? Is there any harm in unifying them and registering the sorting components by default?

I'm removing the spatial specific version, and just registering the dbvt in the normal collision method.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions.

src/physics/util.rs, line 6 at r3 (raw file):
Previously, dkushner (Dave Kushner) wrote…
Actually, yeah that sounds great and is perfectly in line with things like PartialEq where the impl reflects behaviour that resembles the mathematical operation.

It's actually a real cross product for 2d also, it's just that it's easier to represent a 2d cross product result as a scalar, since the normal will always be parallel to the z axis for two vectors in the xy plane

Comments from Reviewable

Review status: 16 of 33 files reviewed at latest revision, 4 unresolved discussions.

src/ecs/physics/systems/impulse_solver.rs, line 83 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
Possibly

Done.

Comments from Reviewable

Review status: 16 of 33 files reviewed at latest revision, 3 unresolved discussions.

src/ecs/physics/prelude2d.rs, line 43 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
I'm removing the spatial specific version, and just registering the dbvt in the normal collision method.

Done.

src/physics/util.rs, line 6 at r3 (raw file):
Previously, Rhuagh (Simon Rönnberg) wrote…
It's actually a real cross product for 2d also, it's just that it's easier to represent a 2d cross product result as a scalar, since the normal will always be parallel to the z axis for two vectors in the xy plane

Done.

Comments from Reviewable

Reviewed 1 of 16 files at r1, 15 of 31 files at r3, 17 of 17 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 6 of 17 files at r4.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Saving Preselected Input fields in Request

Preselected values form Input fields are not sent in the request json. is it possible to save this?

Due to nature of async loads, you will still have missing data but randomly, it will create more confusion. It will be better to use pydatnic object as default value.


[ANCHOR-330] Attempt to fix the racing condition where the servers were not shutdown before the next test starts

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

We plan to run the action many times to increase the probability of the fix.
View List of GitHub Action Results.
What

Wait to make sure the servers are properly shutdown.
Mark watcher threads as daemon to avoid blocking shutdown

Why
Attempt to fix the racing condition where the servers were not shutdown before the next test starts.
The gradle tests were not stable because we are getting BindException indicating address alreay in useerror. It looks like we are trying to start the servers while the previous tests were properly shutdown.
Here is from the raw log.
2023-06-06T19:09:51.8496047Z JwtAuthIntegrationTest STANDARD_ERROR
2023-06-06T19:09:51.8497189Z     Exception in thread "DefaultDispatcher-worker-3 @coroutine#160" org.springframework.context.ApplicationContextException: Failed to start bean 'webServerStartStop'; nested exception is org.springframework.boot.web.server.PortInUseException: Port 8080 is already in use
2023-06-06T19:09:51.8498298Z     	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:181)
2023-06-06T19:09:51.8499141Z     	at org.springframework.context.support.DefaultLifecycleProcessor.access$200(DefaultLifecycleProcessor.java:54)
2023-06-06T19:09:51.8499991Z     	at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356)
2023-06-06T19:09:51.8500624Z     	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
2023-06-06T19:09:51.8501490Z     	at org.springframework.context.support.DefaultLifecycleProcessor.startBeans(DefaultLifecycleProcessor.java:155)
2023-06-06T19:09:51.8502347Z     	at org.springframework.context.support.DefaultLifecycleProcessor.onRefresh(DefaultLifecycleProcessor.java:123)
2023-06-06T19:09:51.8503252Z     	at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:935)
2023-06-06T19:09:51.8504153Z     	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:586)
2023-06-06T19:09:51.8505137Z     	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147)
2023-06-06T19:09:51.8505985Z     	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:731)
2023-06-06T19:09:51.8506641Z     	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408)
2023-06-06T19:09:51.8507283Z     	at org.springframework.boot.SpringApplication.run(SpringApplication.java:307)
2023-06-06T19:09:51.8507838Z     	at org.stellar.anchor.platform.SepServer.start(SepServer.java:43)
2023-06-06T19:09:51.8508407Z     	at org.stellar.anchor.platform.ServiceRunner.startSepServer(ServiceRunner.java:76)
2023-06-06T19:09:51.8509071Z     	at org.stellar.anchor.platform.TestProfileExecutor$startServers$1$4.invokeSuspend(TestProfileRunner.kt:99)
2023-06-06T19:09:51.8509760Z     	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
2023-06-06T19:09:51.8510344Z     	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
2023-06-06T19:09:51.8511148Z     	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570)
2023-06-06T19:09:51.8511833Z     	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
2023-06-06T19:09:51.8512496Z     	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677)
2023-06-06T19:09:51.8513129Z     	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664)
2023-06-06T19:09:51.8513887Z     	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [CoroutineId(160), "coroutine#160":StandaloneCoroutine{Cancelling}@59393b80, Dispatchers.Default]
2023-06-06T19:09:51.8514646Z     Caused by: org.springframework.boot.web.server.PortInUseException: Port 8080 is already in use
2023-06-06T19:09:51.8515392Z     	at org.springframework.boot.web.server.PortInUseException.lambda$throwIfPortBindingException$0(PortInUseException.java:70)
2023-06-06T19:09:51.8516388Z     	at org.springframework.boot.web.server.PortInUseException.lambda$ifPortBindingException$1(PortInUseException.java:85)
2023-06-06T19:09:51.8517185Z     	at org.springframework.boot.web.server.PortInUseException.ifCausedBy(PortInUseException.java:103)
2023-06-06T19:09:51.8518006Z     	at org.springframework.boot.web.server.PortInUseException.ifPortBindingException(PortInUseException.java:82)
2023-06-06T19:09:51.8518921Z     	at org.springframework.boot.web.server.PortInUseException.throwIfPortBindingException(PortInUseException.java:69)
2023-06-06T19:09:51.8519751Z     	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.start(TomcatWebServer.java:228)
2023-06-06T19:09:51.8520592Z     	at org.springframework.boot.web.servlet.context.WebServerStartStopLifecycle.start(WebServerStartStopLifecycle.java:43)
2023-06-06T19:09:51.8521538Z     	at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178)
2023-06-06T19:09:51.8522069Z     	... 20 more
2023-06-06T19:09:51.8522487Z     Caused by: java.lang.IllegalArgumentException: standardService.connector.startFailed
2023-06-06T19:09:51.8523104Z     	at org.apache.catalina.core.StandardService.addConnector(StandardService.java:238)
2023-06-06T19:09:51.8523942Z     	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.addPreviouslyRemovedConnectors(TomcatWebServer.java:282)
2023-06-06T19:09:51.8524951Z     	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.start(TomcatWebServer.java:213)
2023-06-06T19:09:51.8525427Z     	... 22 more
2023-06-06T19:09:51.8525823Z     Caused by: org.apache.catalina.LifecycleException: Protocol handler start failed
2023-06-06T19:09:51.8526394Z     	at org.apache.catalina.connector.Connector.startInternal(Connector.java:1076)
2023-06-06T19:09:51.8526955Z     	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
2023-06-06T19:09:51.8527552Z     	at org.apache.catalina.core.StandardService.addConnector(StandardService.java:234)
2023-06-06T19:09:51.8527976Z     	... 24 more
2023-06-06T19:09:51.8528291Z     Caused by: java.net.BindException: Address already in use
2023-06-06T19:09:51.8528682Z     	at java.base/sun.nio.ch.Net.bind0(Native Method)
2023-06-06T19:09:51.8529044Z     	at java.base/sun.nio.ch.Net.bind(Net.java:459)
2023-06-06T19:09:51.8529386Z     	at java.base/sun.nio.ch.Net.bind(Net.java:448)
2023-06-06T19:09:51.8529874Z     	at java.base/sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:227)
2023-06-06T19:09:51.8530485Z     	at org.apache.tomcat.util.net.NioEndpoint.initServerSocket(NioEndpoint.java:275)
2023-06-06T19:09:51.8531052Z     	at org.apache.tomcat.util.net.NioEndpoint.bind(NioEndpoint.java:230)
2023-06-06T19:09:51.8531649Z     	at org.apache.tomcat.util.net.AbstractEndpoint.bindWithCleanup(AbstractEndpoint.java:1227)
2023-06-06T19:09:51.8532287Z     	at org.apache.tomcat.util.net.AbstractEndpoint.start(AbstractEndpoint.java:1313)
2023-06-06T19:09:51.8532846Z     	at org.apache.coyote.AbstractProtocol.start(AbstractProtocol.java:615)
2023-06-06T19:09:51.8533426Z     	at org.apache.catalina.connector.Connector.startInternal(Connector.java:1073)
2023-06-06T19:09:51.8533822Z     	... 26 more

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr931.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr931.previews.kube001.services.stellar-ops.com/


[rubysrc2cpg] Added ast and dataflow tests for :x=>

@xavierpinho, tagging for review.

@karan-batavia seems like I failed the formatting while trying to resolve a merge request, could you fix that, please?


Handle org/repo#number style links

Closes #55

aeb3d2b removes a test for functionality removed in 881239ac75bb63bd620591d7f12357b48f2bc8fe

Looks great! Thanks for adding the test, too!

Sure! Happy to help! :)


Trigonometric functions

Adds basic functions
Closes part of https://github.com/Kyle-P/Mathematics/issues/34

Hi @mayokunthefirst! Thanks for tackling this one! The sine, cosine, and tangent functions look great. However, the sineh, cosh, tanh, arcsine, arccosine, and arctan functions don't seem to output the correct answers.
For sineh, cosh, and tanh, the programs seems to be returning values for sin, cos, and tan rather than the sineh, cosh, and tanh function calculations.
For the inverse functions (arcsine, arccosine, arctangent), remember that the input is not an angle, but rather a number that is the result of calculating sine, cosine, or tangent on an angle. These functions aren't returning the correct output in the program.
Feel free to make some edits yourself, or we could post this up in the repo for some more contributors to tackle. Whatever you're comfortable with.
Thanks so much for contributing to our repo! It's very appreciated.

@Kyle-P i'll take a look at it again but for now you can post it after which i will re-edit

Hi @mayokunthefirst. Alright. I'll merge it and raise an issue for this.

@Kyle-P ,i'll fix it right away


Flpath 328: assessment workflow options should be available to the user

The patch introduces a new API endpoint. The purpose of the new API is
to enable users to retrieve context parameters of an executed workflow,
specifically of type "assessment".
The patch adds a new controller method that maps to a new endpoint.
This new endpoint accepts the workflow execution ID and a list of context
parameters to retrieve. The method then retrieves the specified context
parameters from the workflow service and returns them as a JSON response.
An example of the request URL:
http://localhost:8080/api/v1/workflows/${workflowExecutionId}/context?param=WORKFLOW_OPTIONS

In the future, when additional parameters will be defined as 'public' visible, the URLcan be used as:
http://localhost:8080/api/v1/workflows/${workflowExecutionId}/context?param=WORKFLOW_OPTIONS,OTHER_PARAM

or a list of separate 'param's:
http://localhost:8080/api/v1/workflows/${workflowExecutionId}/context?param=WORKFLOW_OPTIONS&param=OTHER_PARAM

The response body includes the workflow execution ID and the retrieved
context parameters. An example of the response body:
{
  "workFlowExecutionId": "91811189-a70f-4bce-bd0b-6aa41e36986d",
  "workFlowOptions": {
    "newOptions": [
      {
        "identifier": "onboardingOption",
        "displayName": "Onboarding",
        "description": "An example of a complex WorkFlow",
        "details": [
          "An example workflow option of a complex workFlow with status checks"
        ],
        "workFlowName": "complexWorkFlow"
      }
    ]
  }
}

To retrieve context parameters, users will have to specify the parameters
they want to retrieve as defined in the WorkContextDelegate.Resource, for
resources that are defined as "public" visible. Currently, only the
WORKFLOW_OPTIONS context parameter is defined as "public" visible.
The schema change can be viewed in the generated openapi.json within the commit.

Integration tests will follow...


New theme & rearrangement of the docs

[ ] Closes #xxxx
[x] Passes pre-commit run --all-files
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

Cc @jhamman

Cc @jhamman

@pydata/xarray, does anyone know what's going on with readthedocs: https://readthedocs.org/projects/xray/builds/12928622/? I can't seem to figure out the error causing the build failures.

that's because of the headings in whats-new.rst. I think you have to be consistent with the style you use (-, =, +, ~).

Also, the build step also has a -W flag which turns warnings into Errors and causes a non 0 exit status. This is probably because the read the docs config file for xarray has a fail_on_warning set to true

that's because of the headings in whats-new.rst. I think you have to be consistent with the style you use (=, +, ~, -).

Ah okay... Is this issue connected to a specific sphinx version or readthedocs? I'm asking because I don't run into this issue locally

Also, the build step also has a -W flag which turns warnings into Errors and causes a non 0 exit status. This is probably because the read the docs config file for xarray has a fail_on_warning set to true

Thank you for the clarification....

the build step also has a -W flag which turns warnings into Errors and causes a non 0 exit status

this is intentional: these errors usually cause the page layout to break somehow, so failing the sphinx build (especially in PRs) is important. We also try to minimize the number of nitpicky errors, but we don't enforce that since it seems almost impossible to silence all of them (we inherit docstrings from other projects like numpy, pandas, and matplotlib), and they only result in broken links.

Anderson, this newest version looks really great.
I noticed that https://xray--4835.org.readthedocs.build/en/4835/index.html#see-also is really a list of tutorials and talks, which would be nice to highlight.
So I wonder if it makes sense to move "Getting Started" under "User Guide" and add a new top-level "Tutorials"

So I wonder if it makes sense to move "Getting Started" under "User Guide" and add a new top-level "Tutorials"

@dcherian, I should point out that I created a new section (gallery) and this is where I've been putting the examples/tutorials. Are you suggesting that we merge the gallery, getting-started-guide with the user-guide? Or should we just

merge the getting-started with the user-guide and
then move the https://xray--4835.org.readthedocs.build/en/4835/index.html#see-also to the gallery section?

The tutorial/video resources are a bit hidden right now. It would be good to emphasize them. For e.g. matplotlib has (https://matplotlib.org/)
Installation Documentation Examples Tutorials Contributing

in their top bar, so my suggestion was to add Tutorials in the top bar. That would make the top bar a bit crowded which is why I suggested merging getting-started with the user-guide.
Let's wait for some more opinions before making changes.

Thank you for the pointer to the matplolib's doc structure. I hadn't figured out the distinction between examples and tutorials until I looked at their examples (which seem to focus on a single feature) and tutorials (which seem to be a complete workflow with deep-dives) pages.
After looking at other projects, namely pymc3(https://docs.pymc.io/nb_tutorials/index.html, https://docs.pymc.io/nb_examples/index.html), scikit-learn (https://scikit-learn.org/stable/auto_examples/index.html, https://scikit-learn.org/stable/tutorial/index.html), I'm in favor of (1) having dedicated sections for both tutorials and examples and (2) merging the getting-started guide with user-guide.

@keewis,
I recall you mentioning that the xarray's sphinx build on RTD is configured to turn warnings into errors. Currently, I have an extension that warns that it's not safe for parallel reads. As a result, the entire build fails:

WARNING: the myst_nb extension is not safe for parallel reading
WARNING: doing serial read

Can you suggest any workaround for this issue?

I don't know any, unfortunately. We do want to keep the warnings-as-errors because those tend to result in broken page layouts, but RTD insists on the parallel build (which does make the builds faster) and myst-nb doesn't seem to support it. Is there a particular reason why we're moving away from nbsphinx?

unrelated to that: the internals page is a collection of mostly unrelated topics. It might be good to break it up into separate pages (e.g. "Variable", "duckarray integration", "accessors", "zarr spec", "custom backends", etc.)

Is there a particular reason why we're moving away from nbsphinx?

I got a bit carried away when I saw the Markdown design document in https://github.com/pydata/xarray/pull/4979 :). I figured with myst/myst-nb, it would be easier to support documentation source written in any format (.md, .rst, .ipynb) in the future. I will revert back to nbsphinx.

unrelated to that: the internals page is a collection of mostly unrelated topics. It might be good to break it up into separate pages (e.g. "Variable", "duckarray integration", "accessors", "zarr spec", "custom backends", etc.)

👍🏽. I am going to separate them into different pages

@pydata/xarray, this is ready for another round of reviews...

Anderson, I like the RTD-like sidebar. I think every pydata user is conditioned to look at the left sidebar to navigate the documentation :) so preserving it is nice.

Can we add another level of organization to API reference in the sidebar: "Top-Level Functions", "Dataset" etc.?
Another minor comment: How about renaming "external resources" to "Tutorials & Videos"? Similarly "Related projects" to "Ecosystem"?
It'd be nice to get the left sidebar to "pin" like the right one. Right now if you scroll enough ,it disappears

In general, this is very awesome. I think we should merge soon and iterate further.

@andersy005, the copy button feature is a great find, copying examples is so much easier than before.
The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden).

@dcherian,

Can we add another level of organization to API reference in the sidebar: "Top-Level Functions", "Dataset" etc.?

It'd be nice to get the left sidebar to "pin" like the right one. Right now if you scroll enough ,it disappears

I have yet to figure this out. If someone knows how to do this (whether with or without custom HTML template), please let me know :)

Another minor comment: How about renaming "external resources" to "Tutorials & Videos"? Similarly "Related projects" to "Ecosystem"?

Done!
@keewis,

The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden).

I will see if there's a remedy for this.

I will see if there's a remedy for this.

You could try to reduce the (quite big) margin on the left / right

It'd be nice to get the left sidebar to "pin" like the right one. Right now if you scroll enough ,it disappears

@dcherian, this is fixed. When you get a moment, take another look and let me know if I missed anything.

The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden).

@keewis, I fixed this issue.
@pydata/xarray, this PR is ready.  Unless there's any additional issue that needs to be addressed before merging, feel free to merge this.

I plan to merge this later today (unless there's any objection and/or necessary changes)

+1
On Mon, Mar 15, 2021 at 6:18 AM Anderson Banihirwe @.***>
wrote:

I plan to merge this later today (unless there's any objection and/or
necessary changes)
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pydata/xarray/pull/4835#issuecomment-799412180, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJJFVX555NNH4KALUDP22TTDYCK3ANCNFSM4WMDZXNA
.

Thank you @keewis, @dcherian, @shoyer!


issue when launching the script

Hi all I have an issue when i launch the programm on my raspberrypi
[0:41:12.724569968] [17237]  INFO Camera camera_manager.cpp:284 libcamera v0.1.0+118-563cd78e
Traceback (most recent call last):
File "/home/zakar/PySpectrometer2/src/PySpectrometer2-Picam2-v1.0.py", line 55, in
picam2 = Picamera2()
^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 242, in init
camera_num = self.global_camera_info()[camera_num]['Num']
~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
IndexError: list index out of range
Exception ignored in: <function Picamera2.del at 0x7ffeceae9f80>
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 404, in del
self.close()
File "/usr/lib/python3/dist-packages/picamera2/picamera2.py", line 604, in close
if self._preview:
^^^^^^^^^^^^^
AttributeError: 'Picamera2' object has no attribute '_preview'
can anyone help me
thank you for the help

Check your camera connection. I connected the cam wrong.

Thank you so much it seem to have worked , now when I launch the script I have
qt.qpa.xcb: could not connect to display
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.
Aborted
Should I get another rasbian image (I've read that it should fix the issue but which one should I get) when I try to install qt5 I have the same issue
Thank you again for your help
Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg

From: Norbert Schmidt @.>
Sent: Thursday, February 1, 2024 4:41:36 PM
To: leswright1977/PySpectrometer2 @.>
Cc: zakariagith @.>; Author @.>
Subject: Re: [leswright1977/PySpectrometer2] issue when launching the script (Issue #17)
Check your camera connection. I connected the cam wrong.
—
Reply to this email directly, view it on GitHubhttps://github.com/leswright1977/PySpectrometer2/issues/17#issuecomment-1921618479, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFVHMWMNGUI4UBNASCBFXBDYROZTBAVCNFSM6AAAAABCOHFYVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGYYTQNBXHE.
You are receiving this because you authored the thread.Message ID: @.***>

I've reinstalled raspbian entirely and it worked (with some modifications in numpy)

Thank you very it seems to work now,


Use protobuf in gardener components

How to categorize this issue?

/area performance cost
/kind enhancement
/priority normal
What would you like to be added:
Currently all gardener components are configured to accept and send requests with content type application/json.
We should switch to protobuf (application/vnd.kubernetes.protobuf) by default, where possible.
As we heavily make use of CRDs in our Seed clusters it might not be possible to switch the seed client connection settings to protobuf at all, as CRDs don't support protobuf. But at least for the garden client connection it should be possible.
A fallback to json can be defined for acceptContentTypes with application/vnd.kubernetes.protobuf;application/json.
Why is this needed:
Using protobuf should be more efficient and might safe some data transfer costs.

This can be partly addressed by #3109 (ref https://github.com/kubernetes-sigs/controller-runtime/pull/1149).

This can be partly addressed by #3109 (ref https://github.com/kubernetes-sigs/controller-runtime/pull/1149).

/assign

/assign


Fix Layer Normalize

Solves #2486.
Fixes Layer Norm, introduced in #2213.
For this PR, I've decided to not over do it and just fix the implementation. Maybe at some point I will check if it's worth to add dimensionality options.

Cool, thanks :D


Feature/aarch64

This adds support for aarch64 and removes the need for the int-test branch.  aarch64 stage failures shouldn't prevent the build from overall passing.  Note that the Jupyter version is also now set at the top of the Jenkinsfile to inform the FROM overrides.

Do we still need this feature/aarch64 branch?


Code Cleanup

Cleaned up the code based on messages from linter, and updated eslintrc file to comment out rules (no-dupe-class-members, prefer-arrow-callback, prefer-template) that are not supported by this version of the linter.  The version of the linter we use is based on eslint 1.1, and the previously mentioned rules are supported by eslint 1.2.

Will there be any major changes the to the settings?

Nope, just removed the settings that our version of the linter doesn't support so you will see less warnings when running meteor command.

Are we planning to upgrade our linter?  If yes, then we might have to chahe the settings

We are using the latest version of the linter meteor package but it is based on a previous version of the linter NPM package.  So we can't upgrade right now.

Great! Thanks as always!


Create Translation Recruitment Page

Docusaurus supports a "Help Translate" button which takes a user to a defined link:
https://docusaurus.io/docs/en/site-config#translationrecruitinglink-string

We should set up instruction page with possibly even a bounty for users who spend enormous efforts to help us keep docs up to date in different languages.

I couldn't find any more docs than what's linked above

translationRecruitingLink [string]
URL for the Help Translate tab of language selection when languages besides English are enabled. This can be included you are using translations but does not have to be.

Adding translationRecruitingLink: 'Help Translate', to the siteConfig does create the link as shown in the screenshot, but does not point to a reliable URL.
Consider these two examples.

page I'm on
Link points to

docs/en/overview/introduction
http://localhost:3000/docs/en/overview/Help Translate

http://localhost:3000/docs/en/runtime/macros/construct_runtime
http://localhost:3000/docs/en/runtime/macros/Help Translate

You put a fixed link like "https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/contribute.md"
And then they can read instructions on how to help contribute. The link wouldnt be specific per page (but we may be able to hack something together to do that).
Docusaurus links to: https://crowdin.com/project/docusaurus

The Crowdin provides a clear workflow for the translation work. An instruction document for translation work could be helpful. Instead of putting the doc link under Help Translate, another option is to put the doc under Docs, and leave Help Translate links to the Crowdin project.

You put a fixed link like "https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/contribute.md"

@shawntabrizi You mean that I should/must do that, not that I did do that correct? I definitely know how to create such a page, but I don't know how to get the "Help Translate" link to point to it.

leave Help Translate links to the Crowdin project.

@kaichaosun Yeah, I think it would be wise to point the help translate link directly to crowdin. But I'm saying I don't see any way to control where that link points. It seems to automatically point to the places I've shown in the table above.

@JoshOrndorff the confusion is that the setting in the config should look like:
translationRecruitingLink: 'myurl.com/mylink',

In this case, it can be a fixed URL with instructions or a direct link to crowdin

@JoshOrndorff the confusion is that the setting in the config should look like...

That makes perfect sense, and I now see that @kaichaosun did it in 4aca42b950de13b0666c807e4725150ccf601e1e


[Bug]: Select example does not update the actual <form>'s values

Describe the bug
The example for the select component in the docs does update React Hook Form's values but not the actual form element's. So form actions will fail because it won't send those values.
To fix, add name prop to <Select>:
<Select name={field.name} onValueChange={field.onChange} defaultValue={field.value}></Select>

Affected component/components
Select, more?
How to reproduce
Copy the form example in the docs
Codesandbox/StackBlitz link
https://github.com/shadcn-ui
Logs
No response
System Info
-

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues

Thank you for filing this issue and providing a workaround!  You've saved me a lot of frustration.

I happen to encounter this issue, Thank you! :)

Thank you so much that was driving me nuts

I'm glad this has helped everyone.
The underlying issue should be addressed @shadcn

@ahkhanjani I'm having the same problem with the day picker.  Do you know the fix in this situation?
Thanks!
<FormField
control={form.control}
name='startDate'
render={({ field }) => (
	<FormItem className='grid grid-cols-4 items-center gap-x-4 gap-y-0'>
		<FormLabel className='text-right'>Start Date</FormLabel>
		<Popover>
			<PopoverTrigger asChild>
				<FormControl>
					<Button
						variant={'outline'}
						className={cn(
							'w-[240px] pl-3 text-left font-normal',
							!field.value && 'text-muted-foreground',
						)}
					>
						{field.value ? (
							format(field.value, 'PPP')
						) : (
							Pick a start date
						)}
						<CalendarIcon className='ml-auto h-4 w-4 opacity-50' />
					</Button>
				</FormControl>
			</PopoverTrigger>
			<PopoverContent className='w-auto p-0' align='start'>
				<Calendar
					mode='single'
					selected={field.value}
					onSelect={field.onChange}
					initialFocus
				/>
			</PopoverContent>
		</Popover>
	</FormItem>
)}
/>```

Thank you it works! I can finally sleep. However, zod still returns {"foo": ["Required"]} error

@ahkhanjani I'm having the same problem with the day picker. Do you know the fix in this situation? Thanks!

@wilbsy I don't remember having issues with the date picker. Here's my calendar:
<Calendar
  mode="single"
  selected={field.value}
  onSelect={(e) => {
    field.onChange(e!);
    setOpen(false);
  }}
  disabled={(date) => {
    const now = new Date();
    return (
      date.getFullYear() <= now.getFullYear() &&
      date.getMonth() <= now.getMonth() &&
      date.getDate() < now.getDate()
    );
  }}
  initialFocus
/>


Test coverage

Coverage increased (+10.2%) to 100.0% when pulling 34bead0831045fdb690ed45a9080d791beedb5e3 on test-coverage into b78b8abda8c651a815a7ff1a342dd6801462587e on main.


[virtualbox 5.2] RTR3InitEx failed with rc=-1912 (rc=-1912)

When Win10 vm started,
RTR3InitEx failed with rc=-1912 (rc=-1912)

The VirtualBox kernel modules do not match this version of VirtualBox. The installation of VirtualBox was apparently not successful. Executing

'/sbin/vboxconfig'

may correct this. Make sure that you do not mix the OSE version and the PUEL version of VirtualBox.
where: supR3HardenedMainInitRuntime what: 4 VERR_VM_DRIVER_VERSION_MISMATCH (-1912) - The installed support driver doesn't match the version of the user.

Fixed by using .deb from official site.
sudo apt-get purge virtualbox-5.2
sudo apt-get autoremove
sudo apt-get purge virtualbox-guest-utils

Then download .deb manually from http://www.virtualbox.org/wiki/Downloads

Needs Extension Pack manually installed too for USB controller activation.


Remove trailing whitespace

Remove trailing whitespace in compiler source.
There is still some trailing whitespace in lib.

:+1:


Does not seem to work with punctuation

Hi
I'd like to replace .head)_ with .head(). However, it seems replacement is not triggered, possibly due to the use of punctuation? I tried on the settings page, other replacements work.
Thanks

Oh interesting, thanks for flagging, Toby. I'll try to check this out and find out why it's going wrong, maybe this weekend if I'm able to get to it!


Logging updates

Logging code now works, I checked and the bot was producing around 1.6MB of log files per day so now at the beginning of each week (Monday) the bot will zip the old log file and create a new one to save space.  Additionally the output.log file location has been changed to Logs/output.log as eventually there will be several files and also the zipped logs get their name changed so there isnt conflict with new zipped logs, tested working.

I forgot to add that therefore the log files will be reduced in size by approximately 90%.

Please create a new PR by adding your changes on a branch. for each PR you need to create a new branch.

@masterking32 thats what I have done, the branch for this is tboy1337:logging, this only has the logging changes for main.py.

@masterking32 look in Files changed


mariadb: fix musl, make Numa optional; pmdk: remove

MariaDB:

fix musl
remove pmdk support
make Numa optional
It's only used by large servers. Most users don't have hardware that require Numa. Whoever needs it can use from the flag. Should it be documented? Where (specifically)?

pmdk: remove

No further support or maintenance planned by upstream.
https://pmem.io/blog/2022/11/update-on-pmdk-and-our-long-term-support-strategy/
Alpine removed pmdk package:
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/43663
pmdk is broken for Musl: https://github.com/pmem/pmdk/issues/4157

References:

AUR: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=mariadb-git
Alpine: https://git.alpinelinux.org/aports/tree/main/mariadb/APKBUILD

Cherry-pick is merged to Haskell:

haskellPackages.hslua-core:

#214942

Should it be documented? Where (specifically)?

You could probably put it into the release notes? Idk if it's really worth mentioning though.

Do we have something like "notability guidelines" for the release notes? Something like "MariaDB is built without NUMA support by default now" is IMO enough, because people that would be affected by it understand it, but then again, I don't think "bloated" release notes that nobody reads through are useful, either.
Also, the people that this matters to, if they even exist, probably have monitoring and metrics in place that would alert them, if this actually negatively impacted performance for them.

@ajs124 Can I merge this as it is?

Yeah, should be fine. I ran nixpkgs review and a bunch of things (e.g. amarok) failed to build, but they all seem unrelated.


Using Google MDM plugin not displaying mobile device full detail

I am using Google MDM plugin and do a test on my device to enable Google Device Policy. Stethoscope seem can detect my device but its showing unknown device and it couldn't show all the device information.
Is there any specify configuration I need to configure at my Google Suite to enable Stethoscope to be able to retrieve data?
Thanks.
//CS

Is this an iOS device? See my comment in #20 for more information on Google's limitations.

Closing as there's been no response in over a week.


Add impsort:check to maven build

Resolves #67

@turing85 this only changes the workflow used in this build.
You need to change here if you want that to be valid for new extensions: https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/build.yml#L48

Closing as this project doesn't have any Java sources to check for imports


Added support for Trusted Signing

This PR adds support for Trusted Signing that was requested in #683 with the help of the Azure.CodeSigning.Sdk library.

The build is failing because if this error:
src\Sign.SignatureProviders.TrustedSigning\Sign.SignatureProviders.TrustedSigning.csproj(0,0): error NU1101: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Azure.CodeSigning.Sdk. No packages exist with this id in source(s): dotnet-8, dotnet-eng, dotnet-libraries, dotnet-public, dotnet-tools

I have this package in my local cache and that is why "it works" on my machine. Which source should I add to make this work?

Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

@dlemstra Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

The nuget.org feed is not included in the NuGet.Config file of this project. Wondering if I can add it?

@dlemstra Isn't the package publicly available in nuget? https://www.nuget.org/packages/Azure.CodeSigning.Sdk

The nuget.org feed is not included in the NuGet.Config file of this project. Wondering if I can add it?

No, see https://github.com/dotnet/arcade/blob/main/Documentation/MirroringPackages.md.  I followed those directions and mirrored the package.
I'm reviewing the rest of your PR.


API level

I'm trying to post my app to the Google Play Store, but I get the following error:

Upload failed
Currently your API's desired API level is 7. However, this level must be at least 26 for the app to use the latest APIs, which feature security and performance optimizations. Change the desired API level of your app to at least 26.

I'm using version 4.6 of the AI2U

Hi there, you are going to have to ask for help to the AI2U maintainers. That distribution is built from these same sources, but we have nothing to do with it. Closing this now. Best!


npm start fails

I'm submitting a bug report

Aurelia Skeleton Version
skeleton-typescript-webpack
probably other skeletons are also effekted

Framework Version:
1.1.1

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
6.9.1

NPM Version:
3.10.8

JSPM OR Webpack AND Version
<EMAIL_ADDRESS>

Browser:
all

Language:
TypeScript

Current behavior:
'npm install' ends with:
'npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.'
and 'npm start' fails with errors, see attachment in next comment
Expected/desired behavior:

What is the expected behavior?

mentioned warining in npm install isn't there and npm start works without errors

What is the motivation / use case for changing the behavior?

my current solution is to change line 133 in package.json to use a webpack version from 2.1.0-beta.25
' "webpack": "^2.1.0-beta.25",'

Sorry clicked wrong button when attaching the file.
Expected behavior is:
mentioned warining in npm install isn't there and npm start works without errors
my current solution is to change line 133 in package.json to use a webpack version from 2.1.0-beta.25 by changing it to '   "webpack": "^2.1.0-beta.25",
npm-debug.zip

Yes, this was already fixed but not released. Just pull the skeleton from GitHub (and yes, I know this is not what we recommend).
(@EisenbergEffect when's the next release round?)

Actually, I'll keep this open until we release.

Hi, I copied latest skeleton files into my project (package.json, tsconfig.json, tsconfig.tsnode.json and webpack.conf.js) did fresh npm install (no errors) and after npm start i get this error:
import { generateConfig, get, stripMetadata, EasyWebpackConfig } from '@easy-webpack/core';
^^^^^^
SyntaxError: Unexpected token import
    at Object.exports.runInThisContext (vm.js:76:16)
    at Module._compile (module.js:513:28)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)

@stefan-sopic you need the webpack.config to be called webpack.config.babel.js for it to get transpiled before start. Just see the skeleton.

@niieani this is the error in skeleton-typescript-webpack and there is no *.babel.js in that skeleton.

@stefan-sopic but there is: https://github.com/aurelia/skeleton-navigation/blob/master/skeleton-esnext-webpack/webpack.config.babel.js
TypeScript version uses webpack.config.ts.

After using the above fix of installing beta.25, I am still getting the Unexpected token import error. Any current fix for this? (ESNext already comes with webpack.config.babel.js)

@LachlanHogan please see if you have all the dependencies present in the last skeleton.

@niieani That was using the latest skeleton from master. Unsure of how to pull from a public repo if that is necessary

I'm also hitting this problem with the skeleton-esnext-webpack as of today with<EMAIL_ADDRESS>import { generateConfig, get, stripMetadata, EasyWebpackConfig } from '@easy-webpack/core';
^^^^^^
SyntaxError: Unexpected token import
at Object.exports.runInThisContext (vm.js:76:16)
at Module._compile (module.js:542:28)
at loader (/webpack-master/node_modules/babel-register/lib/node.js:144:5)
at Object.require.extensions.(anonymous function) [as .js] (/webpack-master/node_modules/babel-register/lib/node.js:154:7)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at requireConfig (/webpack-master/node_modules/webpack/bin/convert-argv.js:98:18)
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "webpack-dev-server" "--" "--inline" "--progress" "--profile" "--watch"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>webpack-dev-server: cross-env BABEL_ENV=node ./node_modules/.bin/webpack-dev-server "--inline" "--progress" "--profile" "--watch"
npm ERR! Exit status 1

I had an issue with versions and fixed by doing:
    "webpack": "2.1.0-beta.26",
    "webpack-dev-server": "2.1.0-beta.12"

+1
Had this same issue with the master branch for skeleton-esnext-webpack today.
Env:
MacOS 10.12
node v6.4.0
npm  v3.10.3
"webpack": "2.1.0-beta.27",
"webpack-dev-server": "2.1.0-beta.12"
Here's the error:
webpack.config.babel.js:5 import { generateConfig, get, stripMetadata, EasyWebpackConfig } from '@easy-webpack/core'; ^^^^^^ SyntaxError: Unexpected token import     at Object.exports.runInThisContext (vm.js:76:16)     at Module._compile (module.js:528:28)     at loader (node_modules/babel-register/lib/node.js:144:5)     at Object.require.extensions.(anonymous function) [as .js] (...node_modules/babel-register/lib/node.js:154:7)     at Module.load (module.js:473:32)     at tryModuleLoad (module.js:432:12)     at Function.Module._load (module.js:424:3)     at Module.require (module.js:483:17)     at require (internal/module.js:20:19)     at requireConfig (...node_modules/webpack/bin/convert-argv.js:98:18)

@niieani
Bazyli,
I have migrated our project from the original version of the skeleton-typescript-webpack, to the new one using tag 1.1.2.  I copied the tsconfig.json, webpack.config.ts, and tsconfig.tsnode.json, and updated my package.json with our project's packages.  I also modified the webpack.config.ts to incorporate the changes specific to our project.
When I run npm run build:dev, the build runs to completion with no errors, although a lot of warnings are displayed.  However, when I run npm start, it fails almost immediately with this error:
> cross-env ./node_modules/.bin/webpack-dev-server "--inline" "--progress" "--profile" "--watch"

keywords if/then/else require v5 option
SyntaxError: Unexpected reserved word
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Module.m._compile (/Users/donpeterkofsky/Documents/gc-2-dev/node_modules/ts-node/src/index.ts:406:23)
    at Module._extensions..js (module.js:416:10)
    at Object.require.extensions.(anonymous function) [as .ts] (/Users/donpeterkofsky/Documents/gc-2-dev/node_modules/ts-node/src/index.ts:409:12)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at requireConfig (/Users/donpeterkofsky/Documents/gc-2-dev/node_modules/webpack/bin/convert-argv.js:98:18)

Unfortunately the error isn't too specific about the cause, regarding Unexpected reserved word.  Do you have any ideas about this?  This is blocking our development, after the migration.
Here are the versions I'm using for critical packages:
    "@easy-webpack/config-env-development": "^2.1.1",
    "@easy-webpack/config-typescript": "^5.0.0",
    "ts-node": "^1.7.2",
    "typescript": "2.1",
    "webpack": "2.1.0-beta.28 || ^2.1.0",
    "webpack-dev-server": "2.1.0-beta.12 || ^2.1.0"

When I try the rc2 version of webpack I see different/more errors.
Thanks for your help,
Don

@don-bluelinegrid Could you paste line 98 of /Users/donpeterkofsky/Documents/gc-2-dev/node_modules/webpack/bin/convert-argv.js?
MDN lists reserved words.

I use to have that kind of errors in the past and it started again today after adding a new dependency. for some reason , looks like something triggered some update on some dependencies , and I have unable to recovert my projet.

aurelia>cross-env NODE_ENV=development node ./node_modules
/webpack-dev-server/bin/webpack-dev-server --port 4200 --host <IP_ADDRESS> --inline --progress
--profile --watch
keywords if/then/else require v5 option

aurelia\webpack.config.babel.js:5
import { generateConfig, get, stripMetadata, EasyWebpackConfig } from '@easy-webpack/core'
;
^^^^^^
SyntaxError: Unexpected token import
at Object.exports.runInThisContext (vm.js:76:16)
at Module._compile (module.js:542:28)

I am able to build using npm start but my site just displays a blank page with any kind of js errors in the console.
I dont know how to debug it and I guess I will reimport step by step all the controllers & services in the skeleton from github.

i'm not crazy ok ? but..
i'm do npm install at folder 'skeleton-esnext-webpack' ... with NAME
npm start  works..
another name.. don't ..
if rename folder (after npm install) works to...
why?

I'm with @filipemartinelli this is really buggy.  If I pull the latest skeletons (either via the zip or tar or git clone), I can run the esnext-webpack one in place with no trouble.  If I copy the same files to another location and do an npm install, then try and run it, I get errors.  Mine differs from the above, I get the following:
`><EMAIL_ADDRESS>start /Users/pvencill/workspace/node-aurelia/client

npm run server:dev

<EMAIL_ADDRESS>server:dev /Users/pvencill/workspace/node-aurelia/client
cross-env NODE_ENV=development npm run webpack-dev-server -- --inline --progress --profile --watch

module.js:471
throw err;
^
Error: Cannot find module '../dist'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object. (/Users/pvencill/workspace/node-aurelia/client/node_modules/.bin/cross-env:3:1)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
`

I think this is related to how NPM works and how it creates and depends on symbolic links. Nothing to do with Aurelia nor cross-env.

Removing cross-env from the mix fixed the problem, @niieani , so I'd have to disagree that it has nothing to do with it. Literally the only change I made to go from not working to working was to change the npm start script to no longer include the call to cross-env.

Fixed by https://github.com/aurelia/skeleton-navigation/pull/714 which uses nps.


fix ScenePlaybackDetector.IsPlaying is still false when disable Domain Reloading

fix #490
When I checked, ScenePlaybackDetector.IsPlaying is still false even though it was playing.

Any possibility to get this PR in?

This should be merged


where Self: Sized does not seem to be supported

I get compiler error:
error[E0038]: the trait `jobs::Job` cannot be made into an object
  --> src/jobs/mod.rs:24:14
   |
24 |     async fn revive(
   |              ^^^^^^ `jobs::Job` cannot be made into an object
   |
note: for a trait to be "object safe" it needs to allow building a vtable to allow the call to be resolvable dynamically; for more information visit <https://doc.rust-lang.org/reference/items/traits.html#object-safety>
  --> src/jobs/mod.rs:24:14
   |
20 | pub trait Job: Send + Sync + 'static {
   |           --- this trait cannot be made into an object...
...
24 |     async fn revive(
   |              ^^^^^^ ...because associated function `revive` has no `self` parameter
help: consider turning `revive` into a method by giving it a `&self` argument
   |
24 |     async fn revive(&self,
   |                     ^^^^^^
help: alternatively, consider constraining `revive` so it does not apply to trait objects
   |
24 |     async fn revive where Self: Sized(
   |                     ^^^^^^^^^^^^^^^^^

But when I try the last suggestion, I get:
error: expected one of `(` or `<`, found keyword `where`
  --> src/jobs/mod.rs:24:21
   |
20 | pub trait Job: Send + Sync + 'static {
   |                                      - while parsing this item list starting here
...
24 |     async fn revive where Self: Sized(
   |                     ^^^^^ expected one of `(` or `<`
...
32 | }
   | - the item list ends here

Seems the problem is the suggestion by rustc omits the inputs ((&self, ...)) and output (-> ...) of the function.
Try adding where Self: Sized after the output of the function without removing inputs and output of the functions.
Also, the object safety issue is explained in the documentation. See that for more.

Ah I see, thanks. Not a probem with async-trait then.


adds recursion to anything.js

adds recursion to anything.js
Usage:

recursiveFunction();

This should be a prototype of anything.

Previous comment fixed by #308


Add support for Comby group \n syntax

This allows matching the rest of the line, including the line separator
:[group\n]

Note that even though the syntax specifies \n, any line separator would be supported (including Windows \r\n and Mac \r)

Noticed Comby syntax must match a line terminator; though, it can match 0 characters followed by a line terminator. So, if wouldn't match the last line of the file (if there was no line terminator)
Essentially, it seems like it's the regex .*(?:\r?+\n|\r)
For now, don't think should implement, since would want a syntax to match the entire line including  a line terminator OR the end of the text (to handle the last line)

If do add support for :group[\r], then could have syntax to match entire line including a line terminator OR the end of the text with syntax
:[group\r$]

In this case the $ is a nod to the $ anchor in regex used to indicate the end of the file
The regex would be the following
.*+(?<\r\n|\v|$)

Closed as part of 0.10 release


Laravel 6 Support: Removed deprecated global helper array and str

Removed deprecated global helper array (array_get) and str (str_slug)
Replaced with \Illuminate\Support classes

hey @mpociot - can you have a look at this whenever you get a chance ?:)
Seems like a really simple PR and it does actually allow this to work with 6.0 (tested it myself)

@niladam @henryavila fix the failing checks and i will merge


Electron Documentation for PRs has broken link to Code Owners

I noticed on the Electron Documentation for Pull Requests
https://electronjs.org/docs/development/pull-requests#approval-and-request-changes-workflow

a broken link intending to provide a list of Code Owners that points to https://github.com/orgs/electron/teams/code-owners.

It wasn't immediately obvious where the link should point.

Looks like that link only works if you're a member of the Electron org.

Is that the desired behavior? If that info shouldn't be available to the public, is there something else it could redirect to rather than a 404 page? Some kind of join/login prompt?


uncaught exception when sending to contact

Hi Ivaylo, when trying to send a note to a contact, I get an uncaught exception: "Cannot push to this target."
My code:
$pb = new Pushbullet\Pushbullet("...");
print_r($pb->getContacts()); // shows [name]="John Doe", and<EMAIL_ADDRESS>$pb->contact("john@doe.com")->pushNote("title", "message"); // uncaught exception
$pb->contact("John Doe")->pushNote("title", "message"); // uncaught exception

When I use the Pushbullet app I can send a note to that contact.

thanks for the quick fix. It works now.