testing/quick: add support for shrinking

The testing/quick package automatically generates test cases to be checked against a property. However, it often generates complicated values which obscure the source of test failures. Shrinking is a feature from the original QuickCheck which eases this burden by "simplifying" a failed test case as much as possible.
Evan Shaw gave a presentation on testing/quick at Gopher Summerfest, and started work on adding shrinking to the package in the stdlib. I could't find any official activity related to it, though.
I think he got a good start on the problem, but I also think the interface definition for Shrinker would be significantly simpler like this:
// A Shrinker can produce simpler values with its same type.
type Shrinker interface {
    // Shrink returns a closure which successively yields simpler values of its type.
    Shrink() func() reflect.Value
}

Also, because testing/quick generates random values for its test cases, I believe the behavior of quick.Check() can be changed to support shrinking without breaking the Go compatibility guidelines.
I can work on this feature if the Go team decides it's a good idea.

testing/quick stands to benefit greatly from this functionality. As it stands, you can't use it for automatic generation of regression tests, as other quickcheck implementations allow for with shrinking. Without shrinking, it is so much more cumbersome to figure out what actually caused an issue.
Many people understand quickcheck's utility for testing things like decoder(encoder(val)) == val and for this, testing/quick is adequate, but when shrinking enters the equation, the testing library becomes far more powerful, and capable of testing complex interactions. You can do things like generate a slice of events/operations/requests to apply to a system, and if the property fails to hold, the shrinker can:

drop out individual elements of the slice
re-run the property test on the shrunken input
if the shrunken slice still fails, GOTO 1
if dropping more elements fails to cause the property to be violated, we have probably just found a concise, more easily debuggable sequence of events/operations/requests that will trip up your system.

I really like using other quickcheck implementations to generate a sequence of external requests and network connectivity issues that then get fed into a simulated distributed system with simulated network + clocks. When the generated input fails, the shrinker reduces it dramatically, and the (potentially quite complex) issue becomes far more understandable.
Further, shrinkers automatically generate regression tests for you! Turn the failing non-deterministic sequence found by quickcheck into a regression test for deterministically watching for similar failures in the future.
Does anyone NOT think that would make a great gophercon talk? :P

I'd like to volunteer to build this, since it's been a few years since (deleted OP) proposed and volunteered.
Seriously, this is so useful that sometimes I get away with only writing a single test for a low-impact interactive system, and after shrinking the testing library just tells me what I need to fix with reasonable thoroughness and clarity.
What does the team think?

Thanks for looking into this.

What does the team think?

I think I would like to see a specific API proposal.

@ianlancetaylor https://github.com/golang/go/issues/23135


Add React D3 Treemap component

Add React D3 Treemap component

Thanks for opening this PR 👍  We've moved to a new catalog, JS.coach. This package is now available there! https://js.coach/react/react-d3-treemap


Stuck on 'Initializing AR...' screen iphone 6s

I can enter the testbed fine and the app loads the JS bundle. It then comes up with the screen to choose AR or VR. I press AR and the app comes up with the 'Initializing AR...' screen - it never gets past this.

Hi @kjd35uk sorry to hear you are having issues. What iOS version are you running? ARKit does require iOS 11+ so if you are running an older iOS version that may be the issue.
Otherwise, you can try restarting your phone. That has helped some users in the past. Let us know if you continue to have issues.

IPhone 6 does not support ARKit.  ARKit supported devices are iPhone 6s and higher

Did the testbed app ask for camera permissions? If not, you can enable this in the apps setting. Setting App -> scroll down to Viro Media -> camera toggle to on
A couple more questions/suggestions

Are you trying Hello World or some other AR js file?
Does VR work?
Try a different AR app and see if that is initializing. Like IKEA or any AR app you already have on your phone.
Try deleting the testbed app and reinstalling

Hi Danny,
I'm trying Hello World, I've deleted and reinstalled the testbed, I can run Pokemon Go with AR on this phone and the VR option of the testbed also works...
Kind regards,Kirstie
On Saturday, 30 June 2018, 18:35:59 BST, Danny Moon<EMAIL_ADDRESS>wrote:
Did the testbed app ask for camera permissions? If not, you can enable this in the apps setting. Setting App -> scroll down to Viro Media -> camera toggle to on
A couple more questions/suggestions

Are you trying Hello World or some other AR js file?
Does VR work?
Try a different AR app and see if that is initializing. Like IKEA or any AR app you already have on your phone.
Try deleting the testbed app and reinstalling

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @kjd35uk, trying to repro this on our iphone 6s here but can't. Can you try another AR app that uses ARKit (I don't believe Pokemon Go uses ARKit). Figment AR is an AR app that uses ARKit. Trying to see if the issue is your device, a set up issue or something on the platform.
Lastly, are you trying in a room that has good lighting and recognizable plane surfaces? Sorry for the issues.

Closing this issue due to inactivity. If you are still having issues, please re-open and provide additional comments so we can investigate further. Thanks

same problem here the app will stuck when i will click AR button its showing initialization text and stuck on it but on VR button its working fine. please help


must be use python2.7?

can I use python3.7?

yes, I follow the author's envs, and I complement it successfully.

yes, I follow the author's envs, and I complete it successfully.

I use py3.6,and it works.

yes, I follow the author's envs, and I complete it successfully.
hello，I may need your help
When I perform：python run_basics.py
2019-11-05 20:30:13.850630: I tensorflow/core/platform/cpu_feature_guard.cc:137] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2019-11-05 20:30:13.989548: I tensorflow/stream_executor/cuda/cuda_gpu_executor.cc:895] successful NUMA node read from SysFS had negative value (-1), but there must be at least one NUMA node, so returning NUMA node zero
2019-11-05 20:30:13.990105: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1105] Found device 0 with properties:
name: Tesla P4 major: 6 minor: 1 memoryClockRate(GHz): 1.1135
pciBusID: 0000:00:07.0
totalMemory: 7.43GiB freeMemory: 7.32GiB
2019-11-05 20:30:13.990139: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1195] Creating TensorFlow device (/device:GPU:0) -> (device: 0, name: Tesla P4, pci bus id: 0000:00:07.0, compute capability: 6.1)
2019-11-05 20:30:17.550559: E tensorflow/stream_executor/cuda/cuda_dnn.cc:378] Loaded runtime CuDNN library: 7500 (compatibility version 7500) but source was compiled with 7004 (compatibility version 7000).  If using a binary install, upgrade your CuDNN library to match.  If building from sources, make sure the library loaded at runtime matches a compatible version specified during compile configuration.
2019-11-05 20:30:17.551302: F tensorflow/core/kernels/conv_ops.cc:717] Check failed: stream->parent()->GetConvolveAlgorithms( conv_parameters.ShouldIncludeWinogradNonfusedAlgo(), &algorithms) Aborted
What is my problem with the unprocessed images in the folder？


Parsing error occurs when POST response is empty gzip content type

Fixes https://github.com/Kong/unirest-java/issues/349

I have a couple other small things I'll cut a patch version later today


Add -link command to link ur osu profile to discord

will be very useful for ex to write -mapper and it will return info abt urself

Done via !osuset user

Done via !osuset user

ye i ve alr understood


Kernel not found problem

Execute http://mybinder.org/repo/BruceSherwood/vpython-jupyter and choose a demo program. You get "Kernel not found" and "I couldn't find a kernel matching VPython. Please select a kernel:" The pull-down menu in fact lists VPython, and after choosing "VPython" the program can run. This doesn't happen when running the same notebooks on one's own machine, which makes me believe that there's a bug in Binder. Presumably the notebook contains the information that the VPython kernel is needed.

My mistake. I've now experienced this problem running locally on some machines, so it's a Jupyter problem, not a binder problem.


Issue 24 catchall warning in OK.with else block

Added a conditional check, and associated function, when an else
block is present.

Added a test to ensure that the compiler warning is not produced.

Closes #24

I am closing this. After mulling it over, probably too long, I think the right behaviour is to have a user add there own catch all clause if they want want and raise an error if no clause matches


Added menu, switched to a fixed width layout, switched all pages to the same layout, removed more unused files

Preview: https://dpeukert.github.io/securitytxt.org/
The fixed width layout looks better in my opinion, but I can change it back if you want.

Thank you once again for the amazing contribution, @dpeukert!


Update Windows10SysPrepDebloater.ps1

Lin 29: & sc config InstallService start=disabled  -> Gave me an error, used power shell command and it worked without errors
re-run line 41 in order to avoid error or having to reboot.

With the SC command you MUST put a space after the equal sign
Lin 29: & sc config InstallService start=disabled
Lin 29: & sc config InstallService start= disabled  # note the space after the equal sign
Run SC /? The help states this near the end.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: xyipher<EMAIL_ADDRESS>Sent: Monday, October 8, 2018 1:37:19 PM
To: Sycnex/Windows10Debloater
Cc: Subscribed
Subject: [Sycnex/Windows10Debloater] Update Windows10SysPrepDebloater.ps1 (#53)
Lin 29: & sc config InstallService start=disabled -> Gave me an error, used power shell command and it worked without errors
re-run line 41 in order to avoid error or having to reboot.

You can view, comment on, or merge this pull request online at:
https://github.com/Sycnex/Windows10Debloater/pull/53https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=SqCbdxnI2eTPj9y7reb5FpCQ%2F7jgVm8p%2FjFE6MIZTS4%3D&reserved=0
Commit Summary

Update Windows10SysPrepDebloater.ps1

File Changes

M Windows10SysPrepDebloater.ps1https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53%2Ffiles%23diff-0&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=wF1F%2BNkbZvB0nMtA4CVktYGZ9X4VaUzW1E%2FxHcJrqOY%3D&reserved=0 (4)

Patch Links:

https://github.com/Sycnex/Windows10Debloater/pull/53.patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53.patch&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=%2BzaeKvd9VLjSODRBUWmjSrjEbSGFQkeejvMuKlDQ%2FQE%3D&reserved=0
https://github.com/Sycnex/Windows10Debloater/pull/53.diffhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53.diff&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=b5RF845yzsjaBDVZf6oJZHyoZy3xxwHNcqfCgBKYoVo%3D&reserved=0

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=SqCbdxnI2eTPj9y7reb5FpCQ%2F7jgVm8p%2FjFE6MIZTS4%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANfuP4LfiiQq6r9TZIBouH62Qi_TqzITks5ui5tfgaJpZM4XNdsv&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=uJ3R%2FFJ0tFCgKFo4rHRv0CMdaYJsk5CcC6ImlzAxyrw%3D&reserved=0.

With the SC command you MUST put a space after the equal sign Lin 29: & sc config InstallService start=disabled Lin 29: & sc config InstallService start= disabled # note the space after the equal sign Run SC /? The help states this near the end. Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
…
________________________________ From: xyipher<EMAIL_ADDRESS>Sent: Monday, October 8, 2018 1:37:19 PM To: Sycnex/Windows10Debloater Cc: Subscribed Subject: [Sycnex/Windows10Debloater] Update Windows10SysPrepDebloater.ps1 (#53) Lin 29: & sc config InstallService start=disabled -> Gave me an error, used power shell command and it worked without errors re-run line 41 in order to avoid error or having to reboot.
________________________________ You can view, comment on, or merge this pull request online at: #53https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=SqCbdxnI2eTPj9y7reb5FpCQ%2F7jgVm8p%2FjFE6MIZTS4%3D&reserved=0 Commit Summary * Update Windows10SysPrepDebloater.ps1 File Changes * M Windows10SysPrepDebloater.ps1https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53%2Ffiles%23diff-0&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=wF1F%2BNkbZvB0nMtA4CVktYGZ9X4VaUzW1E%2FxHcJrqOY%3D&reserved=0 (4) Patch Links: * #53.patchhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53.patch&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=%2BzaeKvd9VLjSODRBUWmjSrjEbSGFQkeejvMuKlDQ%2FQE%3D&reserved=0 * #53.diffhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53.diff&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=b5RF845yzsjaBDVZf6oJZHyoZy3xxwHNcqfCgBKYoVo%3D&reserved=0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSycnex%2FWindows10Debloater%2Fpull%2F53&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=SqCbdxnI2eTPj9y7reb5FpCQ%2F7jgVm8p%2FjFE6MIZTS4%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANfuP4LfiiQq6r9TZIBouH62Qi_TqzITks5ui5tfgaJpZM4XNdsv&data=02|01||697cbd57c2b94bf2a0b908d62d4d1530|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636746206417221605&sdata=uJ3R%2FFJ0tFCgKFo4rHRv0CMdaYJsk5CcC6ImlzAxyrw%3D&reserved=0.

I read that somewhere else and it did not work either.

You could use:  & sc.exe config InstallService start= disabled (.exe has to be added)
The problem is the use of old CMD tools with Powershell.
SC in powershell is an alias for the command I used. Set-Content

I spelled it out for better clarity instead of using the alias.
Powershell Version: 5.1.17134.228

Thank you!


Is it possible to make sure map zooms out so all markers are visible?

If I add the markers, they are not all visible on the map, how can I make sure the markers are all visible if that means zooming out or zooming into the map? also is there any auto center without specifying auto center if we have multiple items?

Hey @web-programmer-here there's currently no auto centering/zooming functionality. I'm afraid you'll have to do it manually. Have you seen this method in the native API? Should be useful:
https://developers.google.com/maps/documentation/javascript/reference/map#Map.fitBounds

Hi @web-programmer-here
I haven't used that API before but a quick search turned out this helpful result on Stack Overflow:
https://stackoverflow.com/q/19304574/10341614
So here's an example of what you probably can do:
https://stackblitz.com/edit/vitejs-vite-4tdpur?file=src/components/HelloWorld.vue

thank you, this helped a lot


Graph time mismatch

Steps to reproduce

Click the graph and check the number of queries in the graph
Graph from web panel is correct, but in this app it's not

Expected results
Accurate time is shown
Actual results
The time is 1 hour behind (9 am appears to be 8 am)
Screenshots or Video

App and OS details

App version: (eg: v2.16.3)
Device OS version: (eg: Android 14)

Fixed on v2.16.4.


perf: clear builder slices eagerly to help GC

Related to https://github.com/redis/rueidis/issues/312
Go 1.21 is not yet released. We can use the new clear function once it is released.

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (08a6c6c) 97.60% compared to head (982573b) 97.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   97.60%   97.61%
=======================================
  Files          73       73
  Lines       30143    30146    +3
=======================================
+ Hits        29421    29426    +5
  Misses        609      609
+ Partials      113      111    -2

Files Changed
Coverage Δ

internal/cmds/builder.go
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Collection of minor typo fixes

Ran Aspell over all of the relevant .md files which fixed a few typos I hadn't previously noticed.
May be worth setting up an action to check every new PR before it's merged?
Signed-off-by: Austin Bailey<EMAIL_ADDRESS>

Please don't merge until https://github.com/OpenLiberty/quick-labs/pull/57 has passed.


Leave full logs intact in terminal with --debug option

What are you trying to do?
When I start a dagger call with the --debug flag, it would be helpful to not automatically clean up the terminal but rather leave the full logs visible.
Why is this important to you?
Even with --debug enabled I did not find a simple way to observe a dagger call invocation in the terminal with greater detail.
How are you currently working around this?
Trying to spot lines before they are deleted or clicking through all command invocations in the dagger.cloud traces.

Thanks @marcosnils. I did update to 0.11.0 now indeed, after completing the run all log lines will be shown. Personally I would prefer, that the lines are already scrollable / reviewable during the run, but that's just because I'm so impatient ;-). Closing the ticket.


Add links to FHIR and DICOM service installs.

At the bottom of the page the next steps are to deploy a FHIR service but there is no link to that content
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1834aa06-4671-345e-cb64-ebde46345856
Version Independent ID: 3af33dcf-7266-a70f-e0ef-d603ebb3e03c
Content: Deploy workspace in the Azure portal - Azure Health Data Services
Content Source: articles/healthcare-apis/healthcare-apis-quickstart.md
Service: healthcare-apis
Sub-service: fhir
GitHub Login: @SteveWohl
Microsoft Alias: ginle

@daemel Thanks for the feedback! We are currently investigating and will update you shortly.

At the bottom of the page the next steps are to deploy a FHIR service but there is no link to that content
[I've updated the Next steps section by including links to the articles listed in the bullet points. The new changes are staged in PR 192798https://github.com/MicrosoftDocs/azure-docs-pr/pull/192798.]
From: SnehaAgrawal-MSFT @.>
Sent: Thursday, March 24, 2022 9:05 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Steve Wohl (Aquent) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Add links to FHIR and DICOM service installs. (Issue #90400)
@daemelhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdaemel&data=04|01|v-stevewohl%40microsoft.com|127c45fec3ab44d3334108da0db00f3a|72f988bf86f141af91ab2d7cd011db47|1|0|637837347069156955|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=3EcojIh7fWxmEeUo3Jyb4ah%2BVzDifX9EQrwU4T%2FrzPM%3D&reserved=0 Thanks for the feedback! We are currently investigating and will update you shortly.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F90400%23issuecomment-1077790287&data=04|01|v-stevewohl%40microsoft.com|127c45fec3ab44d3334108da0db00f3a|72f988bf86f141af91ab2d7cd011db47|1|0|637837347069156955|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=pFsFnBFq6rSuEteedFKxjKFdeD%2BmGoDXrsAS2fyYOk8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FATB2MKZYYAPXJVCE6FNSUTLVBSHDBANCNFSM5RRNMGOA&data=04|01|v-stevewohl%40microsoft.com|127c45fec3ab44d3334108da0db00f3a|72f988bf86f141af91ab2d7cd011db47|1|0|637837347069206942|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=4UFw4SPRQNcjcTqO3pQDSTFGnP5z1ipqk%2F8fr0pezpc%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@daemel Thanks for bringing this to our attention. As mentioned by Content author @SteveWohl the PR has been created, it will be visible soon.We will now close this issue. If there are further questions regarding this matter, please let us know


Block unrealistic interactions to avoid getting items from gui

Currently, if we use any interaction not including LEFT and RIGHT click, we can essentially get items from the inventory. This probably isn't an intended behavior, but it would be good to add that as a boolean nonetheless.
https://github.com/SamJakob/SpiGUI/blob/b57ffc09cdda54433c2dcf520655dc80ae88cfbd/src/main/java/com/samjakob/spigui/SpiGUI.java#L41
Such as: blockUnrealisticInteractions(?), which defaults to true, since 99% of interactions will be handled with either left or right click.
Than it's probably just a case of:
if(clickedGui.areUnrealisticInteractionsBlocked()){
    event.setCancelled(true);
}

You can already achieve the same behavior without that change, but it would be helpful nonetheless:
...
).withListener((InventoryClickEvent e) -> {
    if(e.getClick() == ClickType.LEFT){
        //left click stuff
    } else if (e.getClick() == ClickType.RIGHT) {
        //right click stuff
    } else {
        e.setCancelled(true);
    }
})

Would've made a PR but I would rather give that someone who actually knows what they're doing lmao

I think I must add that: you can put items into the gui by just shift-clicking them. (tested on paper version 1.8)
I didn't have time to make a pull request or sth (because im lazy and its 12:41 A.M. here)
I think something like if (shouldIgnoreInventoryEvent(event.getClickedInventory())) return;
and if (!event.isShiftClick()) return;
on InventoryClickEvent would work?
I dont know why I didn't create another issue...
I hope it helped. Have a good night 🌃

@Tuchan - is this in the case of setting setCancelled(false) in the event handler? By default, all InventoryClickEvent or InventoryDragEvent interactions should be blocked, so that shouldn't be possible, if I'm not mistaken?
Note that you needn't set blockDefaultInteraction false to just add click handlers.
@h00z3x - same as above, the event should be cancelled regardless of isShiftClick, so is this with default interactions blocked or allowed?

The idea is that blockDefaultInteraction should block unrealistic interactions but you could still manually enable them within the listener after you've checked that they should be enabled (which is expected to be rare, and something most plugins probably wouldn't do). Is there something I'm missing here?

@Tuchan - is this in the case of setting setCancelled(false) in the event handler? By default, all InventoryClickEvent or InventoryDragEvent interactions should be blocked, so that shouldn't be possible, if I'm not mistaken?
Note that you needn't set blockDefaultInteraction false to just add click handlers.
@h00z3x - same as above, the event should be cancelled regardless of isShiftClick, so is this with default interactions blocked or allowed?
The idea is that blockDefaultInteraction should block unrealistic interactions but you could still manually enable them within the listener after you've checked that they should be enabled (which is expected to be rare, and something most plugins probably wouldn't do). Is there something I'm missing here?

First of all, Thanks for your response I really appreciate it! Second, It looks like I didn't provide much Information. Also I thought It wasn't possible, when I saw your response... So I took a look at SGMenuListener.java:
It turns out the inventory given to shouldIgnoreInventoryEvent (at line 88) is the clicked inventory (which was the player's inventory in my case) it would ignore the event and return while the menu open is event.getinventory.
To fix it : just change the https://github.com/SamJakob/SpiGUI/blob/ed41ea1a99ede7df4ffffb3720c784d84f6eed51/src/main/java/com/samjakob/spigui/menu/SGMenuListener.java#L88
to  if (shouldIgnoreInventoryEvent(event.Inventory())) return;
and also i think you might want to change the line 91 https://github.com/SamJakob/SpiGUI/blob/ed41ea1a99ede7df4ffffb3720c784d84f6eed51/src/main/java/com/samjakob/spigui/menu/SGMenuListener.java#L91
to SGMenu clickedGui = (SGMenu) event.getInventory().getHolder();
Note: this would also mean that the player cant move items of his own when the GUI is open!

Tbh I don't remember much other than that I was able to get the items from the inventory. For example, instead of left clicking I did a shift click and the action obviously went through but the item stayed in my inventory. I think the item would disappear when you interacted with it (placing a block etc), but that was easily bypassed by just dropping and picking it back.
99% of the time an item inside a GUI will be used as a button and not as an item that you can grab and put in your inventory. So yeah, the last option is probably the best one.

Okay. It's probably a 'phantom/ghost item' in most cases (e.g., the client might make it look like the user obtained the item but the event was cancelled on the server so it's not actually there) but I guess there are some workarounds possible.
I'll try and find some time to just try and break it in every way I can think of and implement the above changes.


integration in warm start

pull integration into the constraint solving loop, so solving constraints also does integration for the involved bodies (when needed- an 'integration responsibility' mask is maintained for this, and on-demand conditions are often avoided by knowing ahead of time that an entire batch has no integration responsibilities at all)
so the bandwidth associated with integration just vanishes entirely, since all the data was being loaded by the solver anyway; measurements showed it was roughly free for any simulation with a lot of constraints (as expected due to the solver being bandwidth limited)
it's partially on-demand, but it operates on the bitmasks that are incrementally maintained for coloring (they represent the body handles that are referenced within a constraint batch; for a given bit, a 1 means the corresponding body is present in the batch)
the on-demand part scans through these and merges the bitmasks together; comparing the new merged mask against the previous mask tells you what bodies are first represented in that batch
https://github.com/bepu/bepuphysics2/blob/master/BepuPhysics/Solver_Solve.cs#L1126
(note that there's actually a bug there i need to fix; the clear should be on the merged handles not batch 0!)
the scalar fallback can still process 64 bodies at once, while the avx path can handle 256
typically takes microseconds
couldn't actually multithread the merge phase since the sync costs were way higher than just slamming through it on one thread

Currently integration is super fast. Not sure this is worth it.


Tests don't timeout in long sync ops

Take the following test:
var test = require('tap').test;
test('timeout test', { timeout: 1000 }, function (t) {
  var start = Date.now();
  while (true) {
    var diff = Date.now() - start;
    if (diff > 2000) {
      break;
    }
  }

  t.ok('did not timeout');
  t.end();
});

This succeeds (testing with tap@5.7.0), even though the test takes 2 seconds, and the timeout is 1 second.
It's because (roughly reading the code) because the timeout logic is based around the setTimeout firing, which in this sync op, it doesn't have time to, so the test appears to pass.
I've only roughly tried to fix this (which is why I don't have a PR), but I added the following directly after this line:
  if (this._timeout && final.time > this._timeout) {
    this._onTimeout();
  }

And the above test fails correctly.
However, the reason I didn't pull up a PR is because I wasn't 100% sure of the impact of this "tweak" - i.e. there's no validation, I wasn't sure if this is the time for all tests or a single test, etc.
Happy to help put together a PR if I can get some direction (or happy for someone else to, too :smile: ).

Good catch!
Your patch is on the right track, but has to happen in a different spot, or else it'll trigger "test after end()" failures in some cases.
Fixed on 0ca1678e93e82060fdaae9e5484ad7c326413cc3


maint/CICD ~ add 'Cargo.lock' format testing and protection

I don't see any way around requiring that Cargo.lock be in a format that MinSRV can decipher.
This adds a step to the MinSRV build which specifically checks for Cargo.lock compatibility. If/when an incompatible Cargo.lock file is found, an error message is generated which suggests the correct fix for the problem (for example, see build run #324516614).

Thanks, it has been a pain :)


Ghidra auto analysis is gray out

Ghidra imports a file successfully in project. Bit it does not show anything in listing and other windows. Also auto analysis option and most of other options are grayed out in code browser.
To Reproduce
Steps to reproduce the behavior on windows 10 :

Install compatible java version for example 22
Downloed latest ghidra version
Run as administrato ghidraRun.bat
Create a new project
Imoort a file in project
Click on code browser icon to ooen in in disassembler
I did not modify any default configuration

Expected behavior
I expect see data on code btowser windows
But there are anything there.
Environment (please complete the following information):

OS: windows 10
Java Version: 22
Ghidra Version: 11.2
Ghidra Origin: official GitHub distro

Additional context
I check that with other versions of ghidra with theire comoatible java versions on various windows 10 and 11 VM and physical system. I tried to clean caches. Re create projects. Test with various dll and exe file. But the problem esxits.

The problem was related to Code Browser button in tool Chest section. I double clicked on the dll itself and it worked.


WIP Enable conceptual versioning

/cc @sudeepku

Closing this PR for now until the feature is ready for us.


Add report waffle switch

Overview
Add a waffle switch around the public facing facility report UI so that these features can be reviewed and approved before being publicly accessible in production.
Connects #1245
Demo

Testing Instructions

On develop, ensure you have at least one closed facility.
On this branch, run ./scripts/update and ./scripts/server
Navigate to Switches in Admin

report_a_facility should be inactive

Navigate to facilities

You should not see any closure ribbons

Navigate to a facility which is closed

You should not see any status ribbon
You should not see a status list
You should not see the ‘report facility closure’ button

Navigate to Switches in Admin and set report_a_facility to active
Navigate to facilities

You should see closure ribbons

Navigate to a facility which is closed

You should see a status ribbon
You should see a status list
You should see the ‘report facility closure’ button

Checklist

[ ] fixup! commits have been squashed
[ ] CI passes after rebase
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

It was fairly straightforward! With the current implementation of the switches, I don't feel like we need to shy away from using them as needed. I do think that we should remove the FeatureFlag components for the following production release after we're certain the feature in question is good to go, to avoid having unnecessary components in the code.


Task Group: Saved Changes Revert Without Operation

Environment

Server - VSTS
Account name: msasg.visualstudio.com
Team project name: Bing_Ads
Task Group: https://msasg.visualstudio.com/DefaultCollection/Bing_Ads/_taskgroup/29da9933-9348-4a1b-9d89-79aa8cb008ba?view=tasks

Issue Description
I made changes to the task group and saved them:

But if I click any of the tasks after saving, the definition becomes:

@yiqzhou , it looks like there was some issue while saving your task group. On the server side, the task group that you are referring to does not have  UCM-DownloadSpecifiedBuildPartialDrop -> drop-folders-to-download set to $(drop-folder-to-dowload). So whenever the client is recomputing the list of parameters, this is getting excluded
I went and checked the history where you added this

Here the parameter is added, but I couldn't find a corresponding change in the task input. This image is from the same revision

I don't know clearly why the save operation misbehaved as such, but can you update the task group once again with the changes and save? I think that should resolve your problem

@yiqzhou would you follow suggestion of @sorosoro2 and see if that fixes the problem?

Resolving this issue because of no response.


In come cases uv index value in between 2.91 to 3.0 .

I'm using open-weather API  in my project suddenly u-v index value generate in between 2.9 to 3.0.

:ok: ccd88c2


Roadmap

v4 (Q4 2023)

[x] #881
[x] #361
[x] #797
[x] #887
[x] #889
[ ] #896

[ ] Update Gitea backend to work with editorial workflow
[x] Update demo site to have both simple and editorial workflow demos

[x] #897
[x] #901

Future

[ ] #95

Great project! Why remove the editorial workflow though, I always found this feature very useful!

Great project! Why remove the editorial workflow though, I always found this feature very useful!

Great question, that has a long answer.
So the idea of an editorial workflow is great, but the implementation as it was, was not great. It effectively split each backend implementation (or at least the ones that even had it implemented) into two completely different modules, with the editorial workflow side taking way more code to achieve. It also split the UI in many places into two separate setups.
All of that added up to a lot of complexity that slows down future enhancements to the project, as well as increasing the possibility of bugs.
I believe the editorial workflow can and should be handled outside of the core application. I am planning to creating a guide and some templates to show how to achieve a similar result without the extra bulk the previous setup brought. This approach will also allow for far greater customization of the editorial workflow.

Following along on this! Hoping for a supported CMS with this setup. Quick question - will there be CDN support for quick installation?

Following along on this! Hoping for a supported CMS with this setup. Quick question - will there be CDN support for quick installation?

Yes I am planning on supporting that still. From that front little will change at first.

Would love to contribute. thanks for making this fork! will look over the changes since the fork and pull in the changes i already proposed over in the original repo. cheers.

Would love to contribute. thanks for making this fork! will look over the changes since the fork and pull in the changes i already proposed over in the original repo. cheers.

That would be awesome! Right now the main branch is pretty much a modified version I am using in another project. I am working on a bigger upgrade / rewrite of the repo into TypeScript. There is still a lot to work to do on the rewrite (its very much broken at the moment), but you can see the progress in this branch: https://github.com/StaticJsCMS/static-cms/tree/feature/typescript-conversion

Would love to contribute. thanks for making this fork! will look over the changes since the fork and pull in the changes i already proposed over in the original repo. cheers.

That would be awesome! Right now the main branch is pretty much a modified version I am using in another project. I am working on a bigger upgrade / rewrite of the repo into TypeScript. There is still a lot to work to do on the rewrite (its very much broken at the moment), but you can see the progress in this branch: https://github.com/StaticJsCMS/static-cms/tree/feature/typescript-conversion

Very cool. Happy to wait for those changes to land, or add on top, whatever slows you down the least. :)

Thank you for taking things into your own hands and making this fork, I'm very much looking forward to the first stable version so that the newbie that I am can start helping out. 🙌

Thanks a lot for picking this up and cleaning up the code.
May I suggest to look for PRs of the original Netlify repo, I'm thinking in particular of https://github.com/netlify/netlify-cms/pull/4670 which improves the media library allowing to have subfolders. There is a specific implementation at GitHub GraphQL library but I don't see why it needs a specific backend implementation instead of using the existing backend features.

Great project! Why remove the editorial workflow though, I always found this feature very useful!

Great question, that has a long answer.
...
I believe the editorial workflow can and should be handled outside of the core application. I am planning to creating a guide and some templates to show how to achieve a similar result without the extra bulk the previous setup brought. This approach will also allow for far greater customization of the editorial workflow.

I might be ignorant, but without editorial workflow, how does stage a bunch of changes to various documents before publishing?

I guess you’d have to make a branch and edit the config file to push changes to that branch, check results on the deploy preview or branch deploy, then make a pull request to merge all changes (without forgetting to revert the config file change).

An editor workflow can be achieved outside of the editor itself. You can simply add a boolean Draft field that defaults to true to your documents, with your site setup to not publish draft content. Publishing it then is simply a matter of toggling the Draft flag.
I am planning on making a working example of this after the 1.0.0 release, but that is the gist of how it would be done.

@KaneFreeman I really like your approach to keep the CMS as simple as possible. Although it's really tough to make those hard decisions -- possible against a few people because it might be their currently used feature. But I think it's better to have a well maintained core than an overloaded CMS with no future.
So thank you very much for taking on this big task!

You can simply add a boolean Draft field that defaults to true to your documents, with your site setup to not publish draft content.

Sure but then you only have the editor preview to see the results, which is not as good as a build of the site to see the real results (the page and automatic menu entries and inter-language links etc).

You can simply add a boolean Draft field that defaults to true to your documents, with your site setup to not publish draft content.

Sure but then you only have the editor preview to see the results, which is not as good as a build of the site to see the real results (the page and automatic menu entries and inter-language links etc).

I agree with this. I think the big reason to use editorial workflow was that it gives you a built site - a real preview.
Overall I'm stoked about this project, but I think a deploy preview will be an essential feature missing from this project, and am wondering if @KaneFreeman has any ideas in mind regarding deploy previews?

Its my opinion that preview deployments are outside of the scope of this project (especially with me being the only maintainer at the moment and our community is still small). Netlify CMS partially supported this (not ever backend could do it) and it nearly DOUBLED the amount of code each backend had.
However, this doesn't mean you cannot have a preview site deployment, using Static CMS as it is today.
I've put together an example template, with posts being able to be marked as draft. Then there are two deployments:

production - Deploys only non-draft posts
staging - Deploys all posts

https://github.com/StaticJsCMS/static-cms-next-netlify-editoral-template

@KaneFreeman Seems a reasonable approach. I mostly use Hugo which also suports building with our without drafts.
hugo --buildDrafts    # or -D

Moving #516, #34 and #228 out of v2.0.0 to speed up the release.
Dropping #81 for now. May revisit in the future, but for now will focus on just the Markdown editor.

Is there an expected timeframe for when worked will be started for the multiple file uploads? The progress you are making is absolutely incredible, and I really appreciate the updates. This is the one issue that makes static-cms not usable yet for me in a real project.

The next release (hopefully today) has support for multi file/image uploads in a single widget.

I really appreciate keeping this CMS simple but providing options to extend it.
I believe using the draft flag and branches to implement an editorial workflow is a great solution.

draft to distinguish between preview and yes we are ready to go live
and merging through a pull request for a 4-eye editorial workflow which is essential for a CMS that works in an enterprise environment.

The first part is relatively easy to implement - as mentioned by simply running two preview instances (like two hugo servers)
The second part needs more attention to ensure easy usability. Executing a pull request with Github, Gitlab is very technical, and regular chief editors might shy away from that.
My suggestion is a page extension that handles a pull request that is easy to understand for a content editor.
https://www.staticcms.org/docs/additional-links
What do you think about this?

I am not intending on adding any pull request support to the app.

After much consideration, the Editorial Workflow will be returning in v4.0.0 coming to beta soon (hopefully next week)!

Custom themes will also be coming to v4.0.0

Open Authoring is now checked, with #897 not resolved yet. Was this intentional?
Or should it be moved to the future section, as an extension to the reinstated editorial workflow in a subsequent release?

Open authoring is completed. It currently only works with the GitHub backend and will remain as such for the v4 release.
The work for the editorial workflow on the GitHub backend is also ready.
Both are available in the mist recent beta version for v4


Fix requirements

┆Issue is synchronized with this Clickup task by Unito

I think we have talked about this.


text/html response Using Laravel

Hi there, thank you for your work!
I'm using Laravel, not sure how familiar you are with it but I've gotten the app to respond to a basic hello world command.. though, the app is sending back a text/html response so I was seeing the json string within Slack for a while..

For the time being, I've created a middleware that checks the headers on the way out but I'm not sure if this is the best way to solve this..
I really look forward to your docs on this.. I've just spent a couple hours looking through the source code and am pretty stoked about what you're putting together here.. seems like a lot of the OS Slack development died out there for a bit.
Keep rocking and rolling brother 👍
p.s. Laravel requires a couple extra composer packages to be installed in order to get the PSR implementation of their request/response system. I did go through all those steps and tried to tweak things around for a bit.. but ultimately the middleware is where I landed for the time being.

Hey, I'm sorry I didn't see this earlier. Yeah, you'll need to make sure to send an application/json Content-Type for Slack to parse it, otherwise it will treat it as simple message text content.
Development on these libraries has been really slow, unfortunately, but I'm still working on things. I will likely do a Laravel module as some point that implements its own AppServer using Laravel's native request/response objects.
Any feedback you have in the future, send it my way.


[VL] Remove file format check for pushed down filters

What changes were proposed in this pull request?
The check logic seems doing nothing actually.
How was this patch tested?
Existing tests.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4253_time.csv
log/native_master_01_02_2024_3660e312c_time.csv
difference
percentage

q1
32.25
35.26
3.010
109.33%

q2
25.02
25.20
0.175
100.70%

q3
37.74
38.24
0.502
101.33%

q4
38.92
39.14
0.224
100.58%

q5
71.04
71.45
0.411
100.58%

q6
7.16
7.09
-0.067
99.07%

q7
86.61
86.43
-0.181
99.79%

q8
88.78
85.68
-3.095
96.51%

q9
128.74
123.79
-4.951
96.15%

q10
44.99
43.72
-1.271
97.17%

q11
20.26
20.90
0.645
103.18%

q12
25.01
26.34
1.331
105.32%

q13
47.16
45.95
-1.216
97.42%

q14
18.86
14.28
-4.582
75.71%

q15
28.68
28.62
-0.067
99.77%

q16
15.37
15.25
-0.121
99.21%

q17
103.01
102.80
-0.208
99.80%

q18
153.44
149.26
-4.177
97.28%

q19
14.41
12.84
-1.567
89.12%

q20
28.17
27.65
-0.520
98.15%

q21
229.33
227.40
-1.930
99.16%

q22
14.07
14.05
-0.015
99.90%

total
1259.03
1241.36
-17.670
98.60%


pythonPackages.html5lib: revert the update

Issue description
Recently html5lib was bumped. This caused more packages to fail than I had noticed. PR's are now opened to use the older version of html5lib for certain libraries/applications, however, having multiple versions of a Python library in the same closure causes trouble, so this is something we really don't want.
Therefore, either all dependents have to be fixed in order to use the latest html5lib or we revert the html5lib bump. The former isn't going to work so I am planning to do the latter.
Technical details
This applies to both stable and unstable.
Related issues:
Original bump: https://github.com/NixOS/nixpkgs/pull/21299
Additional fixes:
Calibre issue: https://github.com/NixOS/nixpkgs/issues/21504
Bleach issue: https://github.com/NixOS/nixpkgs/pull/21450
Flexget issue: https://github.com/NixOS/nixpkgs/pull/21543
cc @phanimahesh @mdorman @spacekitteh @grahamc @tari

From a security perspective, the reported CVEs seem slightly contrived.
It is probably fixed in 0.99999999 which is older than our 0.999999999.
Are there other known broken applications? Seems all the ones people have had issues with have been fixed with an update. Could we revert on stable and leave unstable?

I'm OK with a revert.

So far each each issue has been solved with using an older version of html5lib. This is fine along as it is only applications that use this version. As soon as a Python library needs an older version we'll run into trouble (e.g. bleach).

Having two versions of html5lib is not a good idea, especially with their versioning scheme. I can't even read those version numbers without a finger.
Upstream code changes are significant, not sure if we can backport them as patches.
Revert seems like the lesser evil. What will be the full impact of a revert?
Short of checking everything reverse-depending on html5lib, is there any simpler heuristic to see what else broke with the update?

It seems there are no more issues. Some applications use the older version of html5lib which is ok. As long as libraries don't depend on it.

I haven't seen anymore issues so there doesn't seem to be any need to revert the upgrade. Closing.


03_live_EMG

Hi Niklas.
I know I am not an early bird, but I have begun working on MYO Armband recently. I am trying to acquire and store live data from individual sensors as preliminary to my future work. I am sure that your example code having worked properly at the time of writing, but now it only gets EMG stream in the beginning. It acquires stream and plots initially then pauses.
Is it possible to help me to modify the code? Thanks for all your contribution.

from matplotlib import pyplot as plt
from collections import deque
from threading import Lock, Thread
import myo
import numpy as np
class EmgCollector(myo.DeviceListener):
"""
Collects EMG data in a queue with n maximum number of elements.
"""
def init(self, n):
self.n = n
self.lock = Lock()
self.emg_data_queue = deque(maxlen=n)
def get_emg_data(self):
with self.lock:
return list(self.emg_data_queue)
myo.DeviceListener
def on_connected(self, event):
event.device.stream_emg(True)
def on_emg(self, event):
with self.lock:
self.emg_data_queue.append((event.timestamp, event.emg))
class Plot(object):
def init(self, listener):
self.n = listener.n
self.listener = listener
self.fig = plt.figure()
self.axes = [self.fig.add_subplot('81' + str(i)) for i in range(1, 9)]
[(ax.set_ylim([-100, 100])) for ax in self.axes]
self.graphs = [ax.plot(np.arange(self.n), np.zeros(self.n))[0] for ax in self.axes]
plt.ion()
def update_plot(self):
emg_data = self.listener.get_emg_data()
emg_data = np.array([x[1] for x in emg_data]).T
for g, data in zip(self.graphs, emg_data):
if len(data) < self.n:
# Fill the left side with zeroes.
data = np.concatenate([np.zeros(self.n - len(data)), data])
g.set_ydata(data)
plt.draw()
def main(self):
while True:
self.update_plot()
plt.pause(1.0 / 30)
def main():
myo.init()
hub = myo.Hub()
listener = EmgCollector(512)
with hub.run_in_background(listener.on_event):
Plot(listener).main()
if name == 'main':
main()

Hey @Hakkiguclu , sorry that it isn't working for you. Unfortunately I can't locate my old Myo right now so I can't test it. 😞

Hi @Hakkiguclu , i just tested your code with the latest python-myo library and myo-sdk-win-0.9.0 and get get the results lives as there are displayed on http://diagnostics.myo.com/.
i just indicate the sdk path in the init fonction.
myo.init(sdk_path='./myo-sdk-win-0.9.0/')

Thank you for your message @stevelaclasse, I had already copied the content of SDK folder to the same directory, tried what you said by indicating the path but the result has not changed. It plots initially then pauses. Datastream continues but the plot is not updated. I can plot individual sensor data with plt.plot().

what did you get from this website , could you show it here.

Thanks for your concern @stevelaclasse. I attached the file below.

I can also plot the data that sensors produce If I use plt.plot().

Closing due to inactivity. Feel free to reopen if necessary.


[uni_links] I hope that the flutter team will launch a new plugin to support  App/Deep Links (Android) and Universal Links and Custom URL schemes (iOS).

Steps to Reproduce

I hope that the flutter team will launch a new plugin to support  App/Deep Links (Android) and Universal Links and Custom URL schemes (iOS).
The community version update and support are not timely

Hi @realkimmy flutter already supports deep linking on iOS, Android, and web browsers. Please check documentation here => https://flutter.dev/docs/development/ui/navigation/deep-linking
Closing this as it is not an issue, if you disagree please write in the comments and I will reopen it.
Thank you


Feat/dataset scaling

This generates the following error:

Is this caused by old dataset in the database?


qemu added

Have you tried adding a QEMU based job to CircleCI?

Yes. PR in liboqs coming up next when this is in the base image. Thanks for the quick review.


chore(typescript): Upgrade to 2.0 & Types

Upgraded all Project Templates to TS2.0beta, @types, removed all remnants of tsd, typings folders, etc.
Left Universal specific custom types in types/custom-types.d.ts for the ng2 template.
Note: TypeScript2 is still in beta, Visual Studio / VSCode / etc need to be setup to realize they're using a beta/nightly build of TypeScript to take advantage of 2.0 features.

Thanks for this! I'll merge it as soon as TypeScript 2.0 ships. It will be great to get all those .d.ts files out of the project 👍

Glad to help 😄
Sounds like a plan!
Doing some finishes touches on the PR at the moment. Almost finished testing & fixing all the templates.

Just fixed the merged conflicts, @SteveSandersonMS
Can we merge this before merging the Angular2 final + Universal updates?

If it helps: "error TS2686: Identifier 'Redux' must be imported from a module" seems to be related with TypeScript #10638. Using<EMAIL_ADDRESS>these errors vanish.
"(12,39): error TS2346: Supplied parameters do not match any signature of call target" can be fixed by changing windowIfDefined.devToolsExtension to
windowIfDefined.devToolsExtension as () => (a: any) => any

Thank you @stephtr I'll take a look! I wasn't sure if we would want to use typescript@next since it cold e very unstable though?
One of the other main problems is that the store API in the one project is very outdated model (based on an old tsd commit).  Hoping I can spend some time with Steve to look through the ReactRedux changes needed.
Other than that, I was able to get all the other projects running without errors luckily.

Maybe you can take a look at @types if you're updating to Typescript 2 :)
On Sun, Sep 18, 2016, 12:56 Mark Pieszak<EMAIL_ADDRESS>wrote:

Thank you @stephtr https://github.com/stephtr I'll take a look! I
wasn't sure if we would want to use typescript@next since it cold e very
unstable though?
One of the other main problems is that the store API in the one project is
very outdated model (based on an old tsd commit). Hoping I can spend some
time with Steve to look through the ReactRedux changes needed.
Other than that, I was able to get all the other projects running without
errors luckily.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/aspnet/JavaScriptServices/pull/258#issuecomment-247855809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9FXMArS5aaCZmpDCayWTDxSYbfUrks5qrV8-gaJpZM4JjbwR
.

Course! Already have them in here 😃

One change made in Redux 3.6 is Improve typings for compose function, therefore a type definition is needed for devToolsExtension.
Using only a few changes ReactReduxSpa runs using TypeScript 2.0 (typescript@next not necessary) and @types.
While experimenting I noticed that TypeScript seems to use the typing included in the redux-package and not from @types/redux.
types/custom-types.d.ts is not needed when including<EMAIL_ADDRESS>either via tsconfig.json -> types (not working for me) or by referencing it in<EMAIL_ADDRESS>(see (DefinitelyTyped #10978)[https://github.com/DefinitelyTyped/DefinitelyTyped/issues/10978]).

Hoping to get back to this one later today so we can get this merged in there since TS2 finally shipped :)
@SteveSandersonMS maybe we can link up later to figure out those ReactRedux issues? Seems the API has changed quite a bit for compose and a few other things.

Which issues are still left (except redux-typed)? Because in my fork it is working (stephtr/JavaScriptServices).

Closed in favor of #362


Target branch config changed

OPS Build status updates of commit 88480c7:
:clock10: Full build: the average full build time is 10 min(s) 45 sec(s), this is based on the last 1 build(s) for this repository.
:warning: This is a FULL build due to the 'master-config-changed' branch being a new branch in Open Publishing service and is still building. No action is required on your part. For more detailed info, please click here.

OPS Build status updates of commit 88480c7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

tester/1/index - Copy (10).md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Large attachments - crashing difficult recovery

I put a 100mb audio file in a note. Ok - your area doing to way "what possessed you?" but...
The vault in question is synced between 2 people and 2 devices each via couchdb.
After a while, I sat the more on other devices but now I get the app crashing when it tries the sync.
It's an unhandled exception, so it should not really occur - it should be handled.
So - recommendations:

First thing to do is to add a max note size option to the config. Default that to something comfortable (20mb) but let people change it with a warning. The sync process would silently/visible log a warning that it has not synced a note because of this (another option). Dead easy to implement and would allow me get out of a problem situation early or prevent it occurring on the first place.

Speaking of problems, I can't get rid of this now. I have stopped the syncing and file change detection (I can do that if I and quick, before it crashes) and then feels the note and verify & repair. I thought that would get rid of it but no, whatever I try, up it pops again and crashes the app. I think I will have to delete the contents of the couchdb database. That has to work right?

And if it does encounter a problem, it needs to tell the error and handle it.

What's quite important in this plugin is that all devices have the same settings. You have the setup URL but that is clunky and things can get out of sync. I don't know what you don't just store a special note in the vault which is the config for the plugin (you could have things as common or per device in the as appropriate. Then you don't need that cumbersome URL initially and try to remember to have the required settings on an ongoing basis. A new device just sets up a new Vault, you send them the md file for this special plugin which you put on the vault and, voila, the plugin picks up the config. Job done and the sync will sync the settings themselves. What could be simpler than using the datastore you have to store the config for a plugin? You could allow a used to be notified the config but had changed and all whether they want to import changes now, or wait (still they can check the more first perhaps).

What do you think?

Thanks to your report, I have also found this issue. Especially in iOS devices, larger file operations seem to fail in some cases.
The final and ideal fix is handling larger files smoothly. However, the workaround that you have proposed might be helpful for us.

It sounds easier but possibly difficult. It is very smart behaviour if the file is originally over 20MB. However, if it got over 20MB gradually, and decreased in different devices again, it might be very unstable. (And unfortunately, Self-hosted LiveSync can have different thresholds in each device).  We have to think about it more in deep, e.g., automatically generates dot-ignore files and forcely synchronises them.
So, let me think about it a bit more.

As you mentioned, we could not operate the UI in some cases. We can reset all databases by following the instructions. (It should be performed at the most reliable vault).

Stop the Obsidian.
Delete the file which causes the trouble.
Place redflag2.md in the root directory of the vault.
Lauhcn Obsidian.

By this operation, the local database and the remote database will be erased and rebuilt by local files.
If the remote files are already fine, use redflag3.md in the same method for retrieving the files again.

I think that it is a very essential topic. In the original design, I thought each device should use a different configuration in some cases. However, as you pointed out, Today, it not be required always. Of course, especially in rescuing misconfiguration, we have to prepare the local configuration and have the chance to decide accept or reject remote changes.
Of course, we should not store the passphrase, password and credentials of the database. And some device-specific things also still be. Therefore, we probably still need the configuration URI, but it would be shortened. Thank you for the excellent proposal! I will address it later.


A keras model works bad with fp16 weights, but right when a lambda layer added.

I predicted a bert model with fp16 weights, part of the code as follows,  but there is a puzzled phenomenon, if the Lambda is deleted, the final results goes bad.
'''
x = self.apply(
inputs=xi,
layer=Embedding,
input_dim=self.vocab_size,
output_dim=self.embedding_size,
embeddings_initializer=self.initializer,
mask_zero=True,
name='Embedding-Token',
dtype='float16'
)
x = Lambda( lambda x: x, name='Embedding-apply')(x)
'''

@venuswu In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

Closing this issue due to lack of recent activity .Please feel free to reopen if you still have concern.Thanks!


A tool for visualizing VPR tile grid

I wrote a tool which allows to visualize the VPR grid thus allows to verify which tiles are there and where they are. Each tile type can be assigned a different color. The resulting drawing can be stored either as SVG or a PDF (uses cairosvg to convert SVG to PDF internally).
Possible grid definition sources are:

prjxray database (reads directly from tilegrid.json and/or tileconn.json)
SQL connection database (reads tile grid from a table)
Architecture definition file (arch.xml)
Routing graph file (rr_graph.xml)

It is possible also to visualize tile connections but only when using the tileconn.json file.

This is pretty cool. Could you attach some pictures to the pull request?

This is an example render of the tile grid read from the prjxray database. It is a screenshot of a fragment. The SVG file is about 5MB

@mkurc-ant Need a better default color scheme :-P -- Can you use the ones from https://symbiflow.github.io/prjxray-db/artix7/ ?

Or https://symbiflow.github.io/prjtrellis-db/ECP5/LFE5U-25F/index.html would be another option.

@mithro Yes I can. I'll work on it.

Like that? Took these colors directly from the web page.

Much nicer looking!

@mkurc-ant Looks like this pull request has conflicts, can you rebase?

@mithro I checked and the script works on iCE40 arch. I'll clean up the color maps but I need a script to generate them which I have somewhere on my home computer. Will do it soon.


Cannot delete tags via az tag delete

[Enter feedback here]
I am trying to remove all tags from a resource (disk for the matter) by running:
az tag delete --yes --resource-id /subscriptions/...
The command ends with no errors, but when verifying it by running:
az tag list --resource-id /subscriptions/...
I see that no tag actually removed.
{
"id": "/subscriptions/...",
"name": "default",
"properties": {
"tags": {
"auto_fix": "yes",
"contact_dl"<EMAIL_ADDRESS>"env": "dev"
}
},
"resourceGroup": "myrg",
"type": "Microsoft.Resources/tags"
}
Any idea how to overcome it and manage to remove all the tags to that resource, please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9984dc8-c276-354c-6c40-db77fad8e7cc
Version Independent ID: f785cf84-06f2-946e-c8c6-c2a227394335
Content: az tag
Content Source: latest/docs-ref-autogen/tag.yml
Service: azure-resource-manager
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

ARM

@yargolan Thank you for reaching out to us. We are looking into it.

I will test your recommendations and report.

Well. since the tag contains a white space, I cannot delete it from CLI.
Will do it manually from the portal.
You may close the ticket.
Thanks.

Regex would be nice


Default UI filter to open workflows with the last 30 days range.

Ideally the default range should be configurable by users, but for now showing open workflows for a large range (which is still limited by pagination) would give a better user experience.

#10 should address this, as I'll save the user's last choice in local storage, per domain. We can update the default now though.

Fixed in 2.0.0


Share the app

Would be could if there would be a share button to distribute the app via iMessage, Mail, ...

As @Ein-Tim pointed out, you should have a button on the main screen to share the app. In English the button is called Share the Corona-Warn-App.
@stritti can you confirm that you have the button?

Yes. It's there. And offers sharing via all mentioned methods.

Oh sorry, yes there it is! The tree in forrest. I looked for the typical share icon.


app: boards: add support for the candlelightFD board

Add support for the candlelightFD board from Linux Automation.
The board optionally supports a second CAN channel, but only provides two LEDs (RX/TX) in total. To work around this limitation, the "dual" configuration uses the RX LED for channel 0 state/activity, and the TX LED  for channel 1 state/activity.
Since this board has no activity LEDs in its dual configuration, add a small change to the LED initialisation code to support this.

The build failures are resolved in https://github.com/zephyrproject-rtos/zephyr/pull/83410


Video delay on Android

Video works fine iOS but on Android video took 1-2 seconds to play. Is there anything that I am missing?

+1

same here!

+1

hi (sorry for my English).
this is buffering delay because just happened on remote files:
in my case:

onLoadStart called.
onBuffering called with isBuffering = true.
1-2 second delay and then onBuffering called with isBuffering = false.
onLoad called and ...

this is normal on first play of a remote file, but why buffering took 1-2 seconds on playing this remote file again? does react-native-video cache remote videos or no?

Video is also not working on lower android devices.

switch to MediaPlayer for old devices.

Buffering performance on ExoPlayer is significantly better than Android MediaPlayer, you should switch to it.

I switched from MediaPlayer to ExoPlayer but still it show 1 sec delay for every video while swipping.


How to send messages one by one ?

Imagine a have array of strings which I'd like to send to user saving it's order (consequently):
const messages = ['one','two','three','four','five'];

What I tried to do is:
messages.map(message => msg.reply.text(message));

But messages could be sent in random order, like this:
two
one
five
three
four

How can I achieve it?

Try using setImmediate() to chain your messages.
Like :
setImmediate(() => Promise.delay(1000)         .then(() => bot.sendMessage(msg.from.id, messages[0]))         .then(() => bot.sendMessage(msg.from.id, messages[1]))         .then(() => bot.sendMessage(msg.from.id, messages[2]))         .then(() => bot.sendMessage(msg.from.id, messages[3]))         .then(() => bot.sendMessage(msg.from.id, messages[5])));

it looks like .then works fine


IO lose connection after a FMU warm reboot

Recently I met the problem that px4io would fail after a warm reboot sometimes,turned out that the pwm setting would fail to load, but not very often, about once in 300 to 400 reboots.
The problem happened with Pixhawk2.1 and firmware v1.8.2. I assume that the reboot causes some problem, but I can only find the px4io driver sending a reboot-into-bootloader procedure, but not any with normal reboot. I want to know how the normal reboot command was sent and how px4io firmware deal with a normal reboot, so I can find some clue about the problem.

Interesting, I have heard something similar recently.
I'm not sure what you mean with the reboot in bootloader or not, I don't understand why it would matter for the problem you're seeing.
Do you have any console output for the case when it happens? And how did you make it happen? Did you try it 300 times :smile: ?

I'm not sure what you mean with the reboot in bootloader or not, I don't understand why it would matter for the problem you're seeing.

https://github.com/PX4/Firmware/blob/master/src/modules/px4iofirmware/registers.c#L648
I mean this part. The command indicates that it's used when a px4io firmware update is needed. But how it would process when we only asked for a reboot? Or the reboot doesn't care about whether the firmware updated is applied, and processed with the same command?

Did you try it 300 times 😄 ?

Yes, with mavlink command. It's just an estimated average, sometime happend after around 200 reboots and sometime after around 400 reboots,not sure.

https://github.com/PX4/Firmware/blob/master/src/modules/px4iofirmware/registers.c#L648
I mean this part. The command indicates that it's used when a px4io firmware update is needed.

Interesting. I'd have to check.

Yes, with mavlink command.

Nice, ok.

Ok, and how did you verify that px4io was ok? Just trying to reproduce your setup...

Ok, and how did you verify that px4io was ok? Just trying to reproduce your setup...

When it was not ok, it would generate logs like this

and no px4io in device list:

during the boot, the buzzer would play px4io programming tune （tune 18） and then error tune（tune 20）

So one thing to note is that the px4io firmware does not reboot when you reboot fmu.
However, the fact that sometimes the driver doesn't correctly reconnect to the IO board is odd, and it's something I have heard from someone else as well.

So one thing to note is that the px4io firmware does not reboot when you reboot fmu.
However, the fact that sometimes the driver doesn't correctly reconnect to the IO board is odd, and it's something I have heard from someone else as well.

Yep. Now that the problem always happen after warm reboot, I think it necessary to figure out how the  reboot process, and there might be some step with uncertainty which can cause the problem.

I saw px4io led blinking when fmu reboots previously, thought it rebooting, but turned out to be just a signal of losing fum input.
But once the problem happened, the following reboots won't make any change to the px4io led, which just keep constantly on. So the px4io firmware still works, and the status page keeps unchanged even if the fum is rebooting. Should be something wrong with the conn.

I saw px4io led blinking when fmu reboots previously, thought it rebooting, but turned out to be just a signal of losing fum input.

Correct.

So the px4io firmware might still work, and the status page keeps unchanged even if the fum is rebooting.

Maybe the px4io firmware crashes in that case. Just a guess.

@KeyneZzz did you get to the bottom of this?

It looks like we reproduce this issue on 1.9 version and Cube 2.1
~1200 reboots and 8 problems with restart with similar symptoms
Will try to get more info soon.


Custom Transforms

Hello,
It's not clear in the docs how to use custom transforms,
I'm using quill and I want to add tags right in the text. Or lets say I want to change the design of hashtags and instead of the link appearance I want them bold, color white with a dark background-color  myTagWithoutHash and also the # to be removed.
How should I go about this ?

The easiest thing would be for you to just modify and customize the hashtag-format to present it any way you like.
Take a look at https://github.com/Weavy/quill-autoformat/blob/master/src/formats/hashtag.js
You'll find Parchment docs on how to work with format blots (link example) at https://github.com/quilljs/parchment/#example


Update to return a collection bundle

Summary
This PR and its accompanying PRs update the BaseFHIRExtractor to return a 'collection' bundle instead of a 'searchset' bundle like before.
New behavior
Changes as described above.
Code changes
Small changes to the BaseFHIRExtractor, updating the return value.
Testing guidance
Run the lints and tests of this and the other PRs, and run this linked with the other repos, and make sure it works! There should be no functional change at all.

One review here is sufficient.


Fix OSX builders on CI

Looks like Travis has moved on from our old images, so we're forced to
update.

@alexcrichton: no appropriate reviewer found, use r? to override

@bors: r+

:pushpin: Commit e6bc44b54085597114fef872b982aca93cf9192a has been approved by alexcrichton

:hourglass: Testing commit e6bc44b54085597114fef872b982aca93cf9192a with merge ca0daf26b22c051e2f78ce91e4f521db5a4a0725...


HOF error

The compiler cannot determine that a function has been passed in as a parameter; obviously to truly do this correctly we'd need to track the types for the params, but I believe at this point we should be ok just to check the parameter exists in the environment spaghetti stack.
this code will not currently work:
iter = fn f l {
    case l
        | (List.DCons _ _) { f (_0 l); iter f (_1 l); }
        | _ {
            ()
        }
    esac
}

The compiler complains that f is not a known function.

The code issues here are around line 503 and 204 in carpet/cg/compiler.py

What we can do here eventually:

in the compiler we can check if the parameter is a function[...]
the type checker & inferencer can ensure that we actually pass in a function

Similar to #4, I probably will have to mark this as won't fix, since I'd honestly prefer to fix the self-hosted compiler and make that work really well than to try to fix everything going on in here...


Enabling Change Analysis at Scale

It would be good to have an Azure Policy to enable change analysis at scale. Running a script on each subscription manually is a tactical solution, not at scale.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7303812-25be-548c-4f02-1ccd98f122e0
Version Independent ID: 03d6952c-dda5-449f-b8a6-f342dbc876cf
Content: Use Application Change Analysis in Azure Monitor to find web-app issues - Azure Monitor
Content Source: articles/azure-monitor/app/change-analysis.md
Service: azure-monitor
Sub-service: application-insights
GitHub Login: @CawaMS
Microsoft Alias: cawa

@patpicos Thanks a lot for your valuable feedback, our team will look into it and get back to you at the earliest.


Start/Close HTML in wrapper?

One thing that confuses me is why the HTML tag is opened in the header template, but closed in the wrapper? Why not just open/close the HTML tag in the wrapper? It's a small thing but it's always nicer when a tag opens and closes in the same file.

was thinking we could probably just get rid of head.php

Not sure how I feel about getting rid of head.php all-together (in case there are projects with lots of base-*.php files but it's a great idea to move the opening <html> tag into base.php.

@JulienMelissas The issue here is that you're either trying to anticipate people with a lot of base template or head templates. My guess, though, is that there wouldn't be many with a unique combination of both, and since the base idea is generally liked, I'd be open for simply having having a more complete base.php.
People can always make room for a head template if they'd like
What do you think?

i'm pretty confident that there should never be a case where there are lots of base.php files.
moving head.php directly into base.php also seems like a safe change to make

I don't think that there would ever be more than one head template, and I do get that there really should be minimal base.php templates. But I've been in projects where there were 3+ base.php templates, and in that case, yes, I could have made a head.php and just linked to that so that there was only one partial for that code.
guess that's a :+1: to this one

@JasonTheAdams you trying to make a PR or you want one of us to do it?

Beat me to it. :)

lol sorry we were just talking about it a bit internally and realized we wanted to keep the head.php partial and I figured it would be quicker for me to submit a PR than to explain it :wink:
thanks again for pointing this out!!!

Certainly! Cheers!


Questionnaries lack use cases

The README.md file explain the syntax of the questionnaires, but due to the complexity of the questionnaires it could be extremely beneficial to explicitly define a list of use cases and all the possible configurations.

I think that the deep documentation of the use cases should be part of the teachers' documentation and not hidden in the a-plus-rst-tools README. If we had time to write good documentation, the teachers' documentation would be in one place and they would not look for any GitHub projects and READMEs. READMEs would be preserved for technical documentation for developers, not end users.

I was thinking more about a doc folder. Of course, we can also create documentation in the teacher documentation, but we should take into account that such a information should be available for developers who need to test the questionnaires.


Modal blur backdrop not working in Firefox

Steps to reproduce

Open Firefox
Go to modaldocumentation
Open modal with blured background
No blur

Expected behaviour
A modal with a blured background. Works fine in Opera at least.
Screenshots
No blur
Environment / Context

Desktop
Windows 10 64 Bits
Firefox 97.0 (64-bit)

Additional info
@nextui-org/react: 1.0.2-beta.3
react: 17.0.2

Hey @bruxo00 the Modal component blur is based on the backdrop-filter css property which unfortunately is not supported by Firefox until now
Offical docs:
https://developer.mozilla.org/en-US/docs/Web/CSS/backdrop-filter#browser_compatibility


Update 0500-12-06-remote-mapping_en.md

Original hyperlink is a 404.
Searched for a replacement, this is i think comes closest.

Thank you for spotting the dead link - I found a suitable replacement on the HOT website and will adapt the link after merging.


Use buffered stream when broadcasting transactions

Component
Forge
Describe the feature you would like
#1816 indicates that we're experiencing some congestion when transmitting many transactions concurrently.
this is likely due to how tx are broadcasted and waited for
https://github.com/foundry-rs/foundry/blob/0342bc24b7d248d3049ca7cf78caf6df59a81e52/cli/src/cmd/forge/script/receipts.rs#L53
instead of join_all, let's do a buffered stream here https://docs.rs/futures/latest/futures/stream/trait.StreamExt.html#method.buffered
something like  futures::stream::iter(tasks).buffered(<some reasonable limit>), perhaps 10-20 is reasonable.
even better would be to make this a to step process that first sends all, then waits for receipts, ideally, we can turn this whole process in a custom Stream type, but let's do the buffered stream fix first
Additional context
No response

fixed in #1824


Auto-complete suggestor implementation

This PR tries to solve the #29 task: improve auto-complete suggestor.
Major changes:

Attribute parent added to the type command to indicate each command's previous stage. https://github.com/Soptq/smrepl/blob/fc69336dd63b2771f2d84c1eafabc80e361fab6d/repl/repl.go#27
commands' name changed. for example wallet-info changed to wallet info. https://github.com/Soptq/smrepl/blob/fc69336dd63b2771f2d84c1eafabc80e361fab6d/repl/repl.go#114

I've reviewed the PR - the suggestor changes are good but all commands seems to be broken.
Try status node, state glboal, etc...
To test this you want to run a local node on a spacemesh devnet.
To do so, get the node from this release: https://github.com/spacemeshos/go-spacemesh/releases/tag/untagged-ec134df89a3c250755af
And download this config file to use with it: https://storage.googleapis.com/spacecraft-data/mininet-archive/config.json
Start it with ./go-spacemesh -c config.json and start smrepl - it should auto connect to your locally running devnet node.

I see, really appreciate your reviewing. I have fixed the issues in my latest commit.
Changes:

Fix executor does not execute
use automaton to parse, now it should support multi-stage commands (previously it will only support two-stage command)
remove invalid function, replace it with nil which is more understandable for me.

All commands are now tested, it should be working now.

Any problems, possible improvements or suggestions are appreciated. Thanks for your time.

LGTM


Fix circleci pipeline to use scheduled pipelines

Description
It turns out that we haven't been running the nuking routines due to the CircleCI triggers changing it's permissions model to no longer support scheduled workflows. Instead, we need to migrate to using scheduled pipelines. This PR updates the CCI config to start supporting scheduled pipelines.

TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

(no functional changes)

We won't know if the config works until the schedule tries to run.

Yup unfortunately, but I think we can iterate on it quickly once Jim creates the initial workflow.

Ok triggers are created now, so going to merge in!


setup command requires more scopes than necessary

Orb version: 1.0.5
What happened:
step: - github-cli/setup
GH CLI installed
/usr/bin/gh

Authenticating GH CLI
github.com
  X github.com: the token in GITHUB_TOKEN is missing required scopes 'repo', 'read:org'

Exited with code exit status 1
CircleCI received exit code 1

https://app.circleci.com/pipelines/github/pgahq/coach-tools-backend/8091/workflows/8d041e01-362d-4155-9da8-54a0fd74466f/jobs/40666?invite=true#step-103-102
Expected behavior:
It should be possible to install the github-cli with this orb, without having specific scopes. We only use the github cli to create and report github Deployments. Per the principle of least privelege, we only provide repo_deployment scope to our circle contexts. This scope is sufficient to create Deployment records and to set their status accordingly. Unfortunately, this scope is not sufficient for gh auth status and so the setup command fails.
Additional Information:
It is admirable that this orb's setup command reports auth status and does some default configuration. However, it should be possible for users to only install the cli, if they so choose. Installation itself does not require any scopes. Our usage is known to work with the repo_deployment scope, we just need to install the cli.

This may be closed, but on the latest version, I still had this problem.


Setting the 'New line after (' property to correctly match the code styleguide

This PR fixes the issue of the property 'New line after (' in the 'Method declaration parameters' section for Java not being set to true when importing the intellij-java-google-style.xml. See screenshot below.

When the property isn't set the code is formatted in a way that doesn't pass the formatting check by fmt-maven-plugin.
Please also be aware that there seems to be a bug in IDEA currently which doesn't apply this property correctly if its imported with the same code style schema name multiple times so please use a new name when testing. For some reason IDEA keeps the latest saved state of the property in that code style schema.

@shicks could you have a look at this PR? I noticed you have approved similar PR:s before.


Add GetRehydrationToken to Operation for rehydration purpose

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core


Make _.sample more efficient by exiting early

This makes _.sample more efficient by re-implementing _.shuffle's  logic and exiting early when enough elements are found. The speedup to the previous method of shuffling the whole input is especially large when the input is a long array and only a few sample elements are required.
It is safe to exit a Fisher-Yates shuffle early: http://en.wikipedia.org/wiki/Fisher–Yates_shuffle#Comparison_with_other_shuffling_algorithms
There are two alternatives to the way I implemented it which would require either factoring the main _.shuffle logic out into a private function and using it in both _.sample and _.shuffle or adding an internal parameter to _.shuffle that limits the result to a certain number, thus making _.shuffle even more similar to _.sample. Please let me know if any of those two options are preferred over the one I have here.

I think I made have made a mistake here, please give me a second while I investigate.

Turns out you can't just take the loop from _.shuffle and exit early, it's not the type of fisher-yates I remember (not even sure it's one, but I'm no expert).
Anyway, I've rewritten the function and added a test to check it's actually sampling from the whole range rather than just from the first n elements.

If this is done shuffle should probably be implemented via sample

Thanks for the review. I've changed the bits mentioned and made shuffle call through to sample. I've also did a few minor changes to the test for shuffle to make it look a bit cleaner and to test for one naive failure case.
I wasn't sure what your policy on git commits is, so I squashed the whole thing together into one commit.

Have you done any profiling yet @marekventur?

Good call. This is how long 1M operations on a 1000 elements array take on my machine:
Master
input = _.range(1000);
1000000x _.shuffle(input):      15321ms
1000000x _.sample(input, 1000): 32637ms
1000000x _.sample(input, 500):  25765ms
1000000x _.sample(input, 2):    16937ms

My version (before https://github.com/jashkenas/underscore/pull/2158#discussion_r29190358)
input = _.range(1000);
1000000x _.shuffle(input):      15931ms
1000000x _.sample(input, 1000): 15326ms
1000000x _.sample(input, 500):   8331ms
1000000x _.sample(input, 2):     1127ms

After https://github.com/jashkenas/underscore/pull/2158#discussion_r29190358:
input = _.range(1000);
1000000x _.shuffle(input):      15896ms
1000000x _.sample(input, 1000): 15310ms
1000000x _.sample(input, 500):  17067ms
1000000x _.sample(input, 2):    10645ms

profiling code is here: https://gist.github.com/marekventur/455c7bffb00d9759ec7e
In lights of those numbers I'm going to revert back to my code pre the changes @jridgewell suggested, it might be more efficient in terms of memory usage, but it's slower.

I don't believe 92a9d2c is a proper shuffle, that's why my suggestions run slower.
// Let's return predictable results
_.random = function (min, max) {
  if (max == null) {
    max = min;
    min = 0;
  }
  return min + Math.floor(Math.min(Math.random(), .1) * (max - min + 1));
}

var array = _.range(10);

// master
_.shuffle(array); // => [8, 9, 1, 2, 3, 4, 5, 6, 7, 0];

// Yours
_.shuffle(array); // => [9, 2, 3, 4, 5, 6, 7, 8, 0, 1];

// Mine
_.shuffle(array); // => [8, 9, 1, 2, 3, 4, 5, 6, 7, 0];

It's not definitive proof, but it feels fishy to me.

In lights of those numbers I'm going to revert back to my code pre the changes @jridgewell suggested, it might be more efficient in terms of memory usage, but it's slower.

I think it should be comparable if it is implemented like this https://github.com/megawac/lodash/commit/d7d1a3d3eea811c0211f3bc3a9fcb1c5365ebdf9

I think it should be comparable/better if it is implemented like this megawac/lodash@d7d1a3d

Putting an if in the hot loop will make it slower, no? http://jsperf.com/samples-clone-vs-for v http://jsperf.com/samples-clone-vs-for/5.
His is so much faster because it only runs n iterations (with length space), whereas ours does the opposite.

Like @jridgewell says, megawac/lodash@d7d1a3d still runs input.length iterations, right? Avoiding that is the whole point of this PR :)

Right, my bad I misread earlier comments

Like @jridgewell says, megawac/lodash@d7d1a3d still runs input.length iterations, right? Avoiding that is the whole point of this PR :)

Well, before we were running length iterations and using length space, the worst of both worlds. I think yours is good enough since it's no worse space-wise and so much faster.

Is there anything else that needs doing before it can be merged? I'm happy to do it, I just don't know what it is :)

Thanks for contributing!


Pin number 16 invalid

Im trying to convert this python https://gist.github.com/gsdevme/3ac674eb105b13d0139d
I have repo setup here https://github.com/gsdevme/energenie-pi-remote-control however running it on the Pi I get pin number 16 invalid
https://github.com/gsdevme/energenie-pi-remote-control/blob/master/test.php
# set the pins numbering mode
GPIO.setmode(GPIO.BOARD)

The python has this call unsure if its a problem, any ideas exactly?

Seems it was Physical vs BCM pin numbers


rime-ls: 0.4.0 -> 0.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/wlh320/rime-ls/releases.
meta.description for rime-ls is: Language server for Rime input method engine
meta.homepage for rime-ls is: https://github.com/wlh320/rime-ls
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.1 with grep in /nix/store/sh5za2p6ssynz1qz4wiqax3nhq44cjjp-rime-ls-0.4.1
found 0.4.1 in filename of file in /nix/store/sh5za2p6ssynz1qz4wiqax3nhq44cjjp-rime-ls-0.4.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

rime-ls

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/sh5za2p6ssynz1qz4wiqax3nhq44cjjp-rime-ls-0.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A rime-ls https://github.com/r-ryantm/nixpkgs/archive/8b08bf23b7102da44d77adcef5c2463bd90ccde3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8b08bf23b7102da44d77adcef5c2463bd90ccde3#rime-ls

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sh5za2p6ssynz1qz4wiqax3nhq44cjjp-rime-ls-0.4.1
ls -la /nix/store/sh5za2p6ssynz1qz4wiqax3nhq44cjjp-rime-ls-0.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

rime-ls

Maintainer pings
cc @definfo for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge