ui fixes

Hi @ragnarokatz ,
Your note app looks cool with quill editor. I suggest re-positioning the buttons and setting a max height for the div. If that height is reached, then the element becomes scrollable.

@sukhbeersingh approved, please proceed.


ERROR: Unable to download webpage: HTTP Error 403: Unauthorized (I can not download my udemy courses. I could download it a week ago.)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.11. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.02.11

Before submitting an issue make sure you have:

[x ] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[x ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

C:\Users\****\Downloads>youtube-dl.exe --version
2018.02.11

C:\Users\*****\Downloads>youtube-dl.exe --verbose --username<EMAIL_ADDRESS>--password ********** -o "%(autonumber)s-%(title)s.%(ext)s" --all-subs https://www.udemy.com/pratik-yol-ile-ingilizce/learn/v4/content
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--username', 'PRIVATE', '--password',
'PRIVATE', '-o', '%(autonumber)s-%(title)s.%(ext)s', '--all-subs', 'https://www.
udemy.com/pratik-yol-ile-ingilizce/learn/v4/content']
[debug] Encodings: locale cp1254, fs mbcs, out cp857, pref cp1254
[debug] youtube-dl version 2018.02.11
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[udemy:course] Downloading login popup
ERROR: Unable to download webpage: HTTP Error 403: Unauthorized (caused by HTTPE
rror()); please report this issue on https://yt-dl.org/bug . Make sure you are u
sing the latest version; type  youtube-dl -U  to update. Be sure to call youtube
-dl with the --verbose flag and include its complete output.
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpy028tx8p\bu
ild\youtube_dl\extractor\common.py", line 519, in _request_webpage
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpy028tx8p\bu
ild\youtube_dl\YoutubeDL.py", line 2199, in urlopen
  File "C:\Python\Python34\lib\urllib\request.py", line 470, in open
  File "C:\Python\Python34\lib\urllib\request.py", line 580, in http_response
  File "C:\Python\Python34\lib\urllib\request.py", line 508, in error
  File "C:\Python\Python34\lib\urllib\request.py", line 442, in _call_chain
  File "C:\Python\Python34\lib\urllib\request.py", line 588, in http_error_default

...
<end of log>

I can not download my udemy courses. I could download it a week ago.

i do not understand why the issue is closed. we have done all the things you mentioned in last closed issue. Even that we are unable to download.

Hi,
I am also getting the same problem. Can anyone post any updates about this issue?

@dstftw  what do you think about this problem? Can you explain to us?

No solution yet. Stop posting duplicates.


Use service discovery to configure OAuth server location

Hi,
As the title says, I would like to configure the location of my oauth server in client apps using service discovery, preferably using consul.
Something like this:
security:
  oauth2:
    client:
      access-token-uri: http://<service-id>/oauth/token

I couldn't find this in any tutorial, usually it's just something like http://localhost:8080. Is it actually possible?
Thanks in advance

@kmejka A service discovery feature is more suited for a Spring Cloud project. Have you seen Spring Cloud Consul?
As an FYI, this project is in maintenance mode as our efforts are focused in building the new OAuth support in Spring Security 5. Please see this blog for more details.

@jgrandja Of course it's a service discovery feature, but I wanted to know if the spring oauth project does actually use it. That's why I asked here. But ok, I'll ask in the Spring cloud consul project.
Thanks for the info about the future of this project.


fix contact page card overlap with the navbar

Describe the bug
fix contact page card overlap with the navbar
To Reproduce
Steps to reproduce the behavior:

Go to https://www.dzcode.io/Contact-Us/
See card overlap

Expected behavior
a clean separation between the navbar and contact card component
Desktop (please complete the following information):

OS: windows 10

Additional context
-Browser: Google Chrome Version 85.0.4183.83 (Official Build) (64-bit)

Adding position: relative to the contact class should fix  this issue.


Update release.yaml

Pull Request Description
$GITHUB_REF is null so trying to use
$ {{ github.event.release.tag_name }}

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

No linked issues found. Please add the corresponding issues in the pull request description.  Use GitHub automation to close the issue when a PR is merged


Request support for Tuya-Local Bluetooth Lock via BLE/Zigbee hub

Please delete

Information is too vague for implementation

Ok


Atom freezes frequently when a network/UNC file is open on Windows

Prerequisites

[x] Can you reproduce the problem in safe mode?
[x] Are you running the latest version of Atom?

Yes: Version 1.5.4 on Windows.

[x] Did you check the debugging guide?

Yes, but I couldn't find how to profile Atom on startup. (I have a UNC/network file open in the project workspace, and every time I open Atom, it freezes before I can do anything.)

[x] Did you check the FAQs on Discuss?

I skimmed it, but couldn't see anything relevant other than the debugging guide.

[ ] Are you reporting to the correct repository?

Probably not, but I didn't know which repository was most relevant.

[x] Did you perform a cursory search to see if your bug or enhancement is already reported?

Yes. I found some that sound similar, such as #2456 and #1766, but neither of them involve Atom completely freezing. They only report Atom performing poorly. In this case, Atom actually freezes/hangs. I've tried leaving it for multiple hours, only to find it still frozen.

Description
When I leave a network/UNC file (e.g. "\host\share\folder\file") open, Atom eventually freezes. If I leave UNC file open in my project workspace, opening that project again results in Atom freezing as soon as I open it.
I am running Atom on Windows.
Steps to Reproduce

Open a network/UNC file in Atom.
Edit it and save the file. (Possibly not necessary.)
Leave Atom open for some time.
Return to Atom. Atom will likely have frozen.

Alternatively, close Atom and try re-opening the same Atom project later.

Expected behavior: Atom is responsive to user input.
Actual behavior: Atom is not responsive to user input. It is frozen/hung.
Please let me know if I can help profile or investigate this in some way.
Versions
> atom --version

1.5.4

> apm --version
apm  1.6.0
npm  2.13.3
node 0.10.40
python
git 1.9.5.msysgit.0
visual studio 2013

In trying to investigate and reproduce this more, I found that the freeze may actually be caused by the spell-check package checking the spelling of a large (2MB) text file in the work space upon starting Atom. I'll reopen this issue if it turns out I'm wrong.

@mlalkaka If it is in fact spell-check causing the performance problems, you might want to try the 1.6.0 betas, which I believe massively improved spell-check performance.


Performance test storage uploads and downloads

See https://github.com/GoogleCloudPlatform/gcloud-node/issues/397

For reference, we had previously had reports from @mwitkow-io of 100x slowdowns for downloads (vs. just using signed download URLs).
The downloads were for 2GB zip files (to a GCE instance in EU, using the chunked download) doing 1MB/s).

See also #2222, #2927.

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.
As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.
My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.
Thank you!


Why not integrate yolo into the code warehouse, too

emmm. Why not integrate yolo into the code warehouse, too?

We have limited developers and are seeking for community contributors. You may refer to #3083.


Is there a date picker component?

I really need a date picker component in the form. Is there a way to make one work or one you would recommend?
Thanks

Did you find one?

No, not yet.

I'm using this but the problem is that it doesn't connect to redux with the rest of the form.


Fix truncate with option breakWord set to false

There are three instances where this.conf was referenced, that cause the component to break when the option breakWord is set to false.  This PR replaces conf for props, which works and is what is being used elsewhere.

👍

@jariz Can you merge it please?


Broken productpage css and glyphicons fonts

Expose /static in the bookinfo-gateway.yaml VirtualService
Add missing bootstrap fonts (glyphicons)
Maintain the bootstrap directory structure
Update index.html to use the local static assets as well
Update Flask version to get fix for a known issue with serving static files

Fixes #13244

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rvennam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vadimeisenbergibm
If they are not already assigned, you can assign the PR to them by writing /assign @vadimeisenbergibm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cc: @yubingjiaocn

@rvennam: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bce396436ef0a3b6c9aac061201c823a5e55f7d2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu - can you please review and approve this PR? We are seeing this defect on productpage where glyph icon is not displaying and this PR seems to fix this defect. Thanks.

@rvennam To get this to pass the e2e tests, you need to rebuild the bookinfo images, push them to dockerhub, and update the yamls to use the newly pushed version of the images.

@frankbu I was thinking I would rebuild the images and update yamls in another PR. Do you want it to be part of this one?
Feels wrong to update docker hub images with code changes that haven’t been merged into the src repo

@rvenum, I think there's no choice or the e2e is broken because of the incompatibilities between the config files here and the images that are running. Right?

@rvennam please see comment I added in #13316

/retest

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bce396436ef0a3b6c9aac061201c823a5e55f7d2
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bce396436ef0a3b6c9aac061201c823a5e55f7d2
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
bce396436ef0a3b6c9aac061201c823a5e55f7d2
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu @vadimeisenbergibm
New bookinfo images are built, pushed to docker hub and image tags in the yamls are updated in this PR

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4f16aa6002786489047915970c516b5f51fc93e6
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-trustdomain

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hmm, any idea why the bookinfo tests are failing? Is there some kind of output format change happening?

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-pilot-multicluster-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-trustdomain

prow/istio-integ-k8s-tests.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rvennam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: nmittler, venilnoronha
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler @venilnoronha in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/e2e-bookInfoTests-trustdomain.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test e2e-bookInfoTests-trustdomain

prow/istio-integ-k8s-tests.sh
cc7d74a7145d787b17b5cccb8a809a48f9bc3222
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: frankbu, rvennam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [frankbu]
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu, rshriram, rvennam
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

samples/OWNERS [frankbu,rshriram]
tests/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvennam: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
48b3b7548fa87a59e81cd75911ddee83ea9f0285
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


The HUD

This Branch is going to merge the planet tracker and side planet display into one HUD. The Intention is to have a menu appear when the player is looking at a planet. This Menu is going to have all the information displayed such as the Planet Name, distance from the planet , the planet distance from the black hole, Whether it has been rescued and if the player can land on it.
Later on the types of animals available on the planet can also be shown here.
The Side planet display has been reworked to no longer have icons and they now disappear from the side once rescued or destroyed.
In order to tell when the planet is currently looked at by the player I have started refactoring FindingPlanets.cs
the arrow still tracks the closest planet but I have also added a raycast that starts from the center of the screen and returns information about an object that was hit. I believe this to be a much more efficient method. At this point the only objects that the raycast will return are those with the Planet tag this is to avoid it hitting the player's ship or the black hole.
To Do List (Sprint 1)

[x] Check that Everything is functioning in the build
[x] Remove Unused variables and methods
[x]  Black hole distance for planets
[x] Black Hole info panel
[x] Comments on Ray Casting

Started testing a new raycast where planets find their distance to the blackhole. Need to trial some changes in order to get the distance of the destroy Collider not the warning area. Seems this has something to do with layers need to do some research

Added a layer mask so the raycast hits the distortion hitbox. It returns a length which can be an estimate distance from a planet to the black hole. There are three different "levels" or colors for the text.

Normal (Blue) Normal color means the planet is relativiely safe from the black hole at this point
Orange: The Planet is within the warning sphere. still time to rescue
Red: About half way -> extreme danger 3/4 into the warning sphere. est 150 units from hitbox

Added a panel for the black hole that shows approx distance, number seems to be accurate based on planet distances but it changes quite quickly when mouse moves.

Re worked the distances so one ray cast tests when the player is looking at a target and the other gets the distance between the player and the hit object.  This has removed the issue of changing the distance when moving the look slightly and made the distances seem more realistic in comparison.

Another thing I just noticed is that the game UI now breaks again on any aspect ratio other than full HD.

The post processing effects from getting too close to the black hole are gone. Not totally sure the of the cause?
After rescuing a planet it still shows up as "Ready to Land". It does say that the planet has been rescued but keeping the landing text there given you can't actually land there again feels odd.
As for the general design I like it but it feels like it takes up a lot of the screen space? Especially when in full screen mode. Could the info panel be a bit smaller?
The circle in the middle looks good. Possibly also a touch large but I'm not sure about that? I think eventually having it be a little animated would look amazing but that's well out of scope. Should the + in the middle be removed since we have the circle now? Might make it look a bit cleaner.
Do you intend to keep the arrow and tick mark? Does the planet info screen show enough information? Or I guess this could be added to the middle in a later sprint with a small ring around it pointing to the closest? Unsure.
Very impressive coding overall. The functionality is great. The only other thing is just to check over the added files for unneeded ones to keep the game size as low as possibly

I believe I know what broke the distortion effect, I will undo what I did and try find another solution.
I will make the circle slightly smaller as that has been mentioned already,
I think the arrow should have its own focus as there's other elements that need to be factored in too.
I have removed all the files I don't need and I will change the ready to land on the panel as well.
I will also try and fix the UI scaling not sure what happened there and I will make the panel smaller

Another thing I just noticed is that the game UI now breaks again on any aspect ratio other than full HD.

Is this when you play the game or in the editor? my script from last semester scales stuff once the game starts

My bad. Tested it some more and the scaling is still fine. The only other thing is that on lower resolutions the panel is noticeably very fuzzy. Obviously just a side effect of lower pixel count but is there any way to scale it so it looks a little better?

I still think the crosshair is a little too big, could you please make it a fraction smaller?
I'm not sure what the cause or solution is, but sometimes the HUD won't show up when the crosshair is over a planet, whether it's far away or close. Often I've seen this happen to planets that are intersecting the black hole, and upon further testing, I do believe that to be the case! Which is very obnoxious when the planet is clearly in view. I'm also not sure if it would make sense if you could detect a planet that is directly behind the centre of the black hole, realistically I would feel like it would have some distortion (metaphorically, not an actual mechanic), but from seeing the planet behind/in the outer parts of the black hole, I'd like for the HUD to show up.
I think it would be good to have how many animals saved for the planet, just so the player can keep track! Maybe in the future we could have the native species listed on there as well!
This is probably for another issue but I want to write it down anyway because it's somewhat related, but I was keeping an eye on the closest planet to the black hole and watching the black hole distance number tick down, and it started to speed up, (even though I'm pretty sure the growth of the black hole remains at a constant rate), and the planet was nowhere near close to the black hole delete trigger area! When the number went down to 0... It went back to 400ish units! Then like I mentioned previously about the raycast, I couldn't see the HUD easily anymore but within about a second of seeing the distance go back to 400, it got deleted! Before the HUD disappeared, the units were dropping at about half a second each, so I doubt it suddenly shot back down to 0.

Here's an example of this - was looking at the closest planet to the black hole and got deleted at 464. There was also another planet (it's seen in this screenshot currently getting sucked) that was stuck at a distance of 600.

Seems like when the planets spawn too close, they disregard the colour change.
Also I tested it again, and the HUD disappears even when the planets aren't intersecting the blackhole. Maybe the black hole was invisibly disrupting the raycast, but I had to fly really close to see it again, and I was just staying still watching it when it suddenly disappeared!
Best to see if you can recreate these yourself to see what I'm talking about, but I'm happy to recreate it for you at some point.

Yeah ray casts have turned out to be a major pain. The ray is likely hitting the black hole first and causing those issues. I will try and re create it
Not sure why the counter would reset like that I will have a look at that.
I purposely left out the animal information for now because of the rework going into the planets currently there will likely be a change to how points work and just thought it was far down the line.
I will shrink the circle again

I still think the crosshair is a little too big, could you please make it a fraction smaller?
I'm not sure what the cause or solution is, but sometimes the HUD won't show up when the crosshair is over a planet, whether it's far away or close. Often I've seen this happen to planets that are intersecting the black hole, and upon further testing, I do believe that to be the case! Which is very obnoxious when the planet is clearly in view. I'm also not sure if it would make sense if you could detect a planet that is directly behind the centre of the black hole, realistically I would feel like it would have some distortion (metaphorically, not an actual mechanic), but from seeing the planet behind/in the outer parts of the black hole, I'd like for the HUD to show up.
I think it would be good to have how many animals saved for the planet, just so the player can keep track! Maybe in the future we could have the native species listed on there as well!
This is probably for another issue but I want to write it down anyway because it's somewhat related, but I was keeping an eye on the closest planet to the black hole and watching the black hole distance number tick down, and it started to speed up, (even though I'm pretty sure the growth of the black hole remains at a constant rate), and the planet was nowhere near close to the black hole delete trigger area! When the number went down to 0... It went back to 400ish units! Then like I mentioned previously about the raycast, I couldn't see the HUD easily anymore but within about a second of seeing the distance go back to 400, it got deleted! Before the HUD disappeared, the units were dropping at about half a second each, so I doubt it suddenly shot back down to 0.

Here's an example of this - was looking at the closest planet to the black hole and got deleted at 464. There was also another planet (it's seen in this screenshot currently getting sucked) that was stuck at a distance of 600.

Seems like when the planets spawn too close, they disregard the colour change.
Also I tested it again, and the HUD disappears even when the planets aren't intersecting the blackhole. Maybe the black hole was invisibly disrupting the raycast, but I had to fly really close to see it again, and I was just staying still watching it when it suddenly disappeared!
Best to see if you can recreate these yourself to see what I'm talking about, but I'm happy to recreate it for you at some point.

Yeah ray casts have turned out to be a major pain. The ray is likely hitting the black hole first and causing those issues. I will try and re create it
Not sure why the counter would reset like that I will have a look at that.
I purposely left out the animal information for now because of the rework going into the planets currently there will likely be a change to how points work and just thought it was far down the line.
I will shrink the circle again

For the animals that's so true!

https://forum.unity.com/threads/having-issues-with-raycasts-reporting-incorrect-distances.142955/
https://stackoverflow.com/questions/63634733/avoid-raycast-hitting-player-without-layermask
For future reference

Changes

[x] Addressed post processing issue
[x] Reduced size of new crosshair circle
[x] Reduced size of panel and moved it down slightly
[x] Addressed black hole interfering with planet ray-casts

Outstanding

There is still a weird issue where the distance can reach 0 and then it jumps back to a different number. I believe this could be solved with the new collisions in the gravity feature.
Distances are better but the ray is still fired from the center of the planet not an edge, which seems to cause some inconsistencies
It is likely some of the functionality of this will break because of changes to the blackhole , I will look into the feature so it is easier to fix this after merging.


⚠ ClamAV has degraded performance

In 24523f1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 227 ms

Resolved: ClamAV performance has improved in 5aa0749.


Initial package structure

This is a suggestion for a structure of the package. Feel free to comment, cheer, disagree, and suggest changes 😄
Have a look at structuralcodes.code. This is where we collect our design codes. Currently this is set up as a factory. With this setup we can signal to contributors what is the expected content of a design code, and we arrange for all design codes being defined in a similar manner.
The code that has som implementation is fib Model Code 2010. Have a look at structuralcodes.code.mc2010. The main class of this design code, MC2010, inherits from structuralcodes.core.base.DesignCode. Having the DesignCode abstract base class opens for defining a common interface for all design codes in the future. Furthermore, there is a builder, MC2010Builder, and this builder is registered in the code_factory in structuralcodes.code._code_factory.
Have a look at the implementation of MC2010. I have suggested to implement all methods in separate modules, as is shown in the _concrete_material_properties module. The functions are imported in a regular manner, and set as attributes in the constructor of the design code.
I think this opens for a good code structure, where the design code class implementation is rather short, and the implementation of the functions can be put in separate modules with different topics. One drawback is that the intellisense in e.g. VS Code is not working properly in this case. This means that if you instantiate the design code, code = MC2010() and start typing code.fcm(), VS Code will not show a popup with code hints. It would be nice if we could find a way to fix this. However, the method works as expected, and typing help(code.fcm) prints the docstring as expected.
The function set_design_code() defined in structuralcodes.code calls the code factory and sets a global design code that will act as the default code for subsequent calls. There is also a set_national_annex() which is not yet implemented, and a get_design_codes() which lists the available codes that are registered at the code factory.
Let us go back to structuralcodes.core and look at the concrete module. This module contains the Concrete class which inherits from structuralcodes.core.base.Material. The constructor takes an optional design code, and if this is not given, it will use the global. Furthermore, the module defines a tuple with methods that are required to be implemented in the design code, and these are set as attributes on the Concrete class by the constructor. Again, perhaps a nice code structure, but the intellisense is still broken.
One thing to discuss is whether the fcm and fctm methods should be methods or properties of the Concrete class. I do not have a strong opinion here. Implementing e.g. the Young's modulus as a property could however be challenging, unless we provide e.g. the aggregate type to the constructor.
In the future, we could implement other materials, and even sections, in a similar manner.
To start testing, try typing something like:
import structuralcodes

structuralcodes.set_design_code('mc2010')
concrete = structuralcodes.Concrete()

fcm = concrete.fcm(45)

Note that I have set up a github action that runs Black, flake8 and pylint to make sure that we have some objective guidance on our code. We should not merge changes that do not pass these tests. In the future we should also add testing to this pipeline.

I just found that if you import the _concrete_material_properties functions inside the MC2010() class, then autocomplete works perfectly. Otherwise, adding the attributes dynamically with setattrs() only will resolve method names at runtime, so we will be only able to use autocomplete in other environments such as Notebooks, once the variable is initialized (or we could explore stub generation). MC2010() would look as the following lines:
from structuralcodes.core.base import ConcreteDesignCode

class MC2010(ConcreteDesignCode):
    from ._concrete_material_properties import fcm, fctm, fctkmin, fctkmax, Gf, fcd

With this modification, Pylint will show some warnings because imports are not being used at the top level, so it may be a good idea to add to the .pylintrc file the following attribute:
disable = disable-outside-toplevel

Also, to make it work, in _concrete_material_properties.py it is necessary to add a first argument to all functions so it refers to the instance of the current MC2010() class. As an example:
def fcm(self, fck: float, delta_f: float = 8.0) -> float:
    return fck + delta_f

We cannot set the type of the self variable to self : MC2010 because it would create a circular dependency.
I do not know if this looks pythonic or not, but it works.
¿What do you think about this?
I can propose a draft for review if you grant me write access to this repository. Otherwise, I can just create a fork.

Hi @DanielGMorenaFhecor, good to have you on board. Thanks for your comment, and thanks for looking into this 😄 I wanted to respond earlier, but had to digest this and other options a bit.
Importing the functions inside MC2010 kind of solves it, and disabling the necessary checks in Pylint to have it pass our pipeline is fine. However, I am a bit worried about forcing all contributors to add a self in the function signature. So, you solved it, but I don't think we should do it this way 😐 By the way, I like your idea of stub generation. However, it also adds another layer of stuff to manage. I hope you do not find this too stubborn and reluctant, but realize that I appreciate the options that we investigate 😏
With this said, I think we might have over-complicated stuff slightly in the present draft. Perhaps a cleaner structure could be to collect all the functions from the design codes in sub-packages, and expand from there. Let's explore this idea briefly.
In this structure, and for Model Code 2010 specifically, code.mc2010.__init__.py would import all available functions from _concrete_material_properties.py and other modules. Functions are implemented and documented once, i.e. in these modules.
This sub-package, code.mc2010, could serve as basis for the design code specific higher level classes for material, section and element that we have discussed earlier. The sub-package could also be the main entry point for the end-users that do not wish to use the higher level classes, but instead e.g. work with validation of code functions, or use the functions for their own programs or higher level classes.
Now, Sphinx is happy, because we can autodocument all our basic functions, intellisense is happy, because we did not implement it too fancy, and our contributors are happy, so the PRs keep pouring in 🚀
I do not have a clear idea of how to incorporate the national annexes in this structure, but I do not see it as a deal-breaker at all.
The material class, e.g. Concrete MC2010, could behave like advanced dataclasses. Pretty much like in your example repo, only using the handy @property decorator.
I expect that the design code sub-package and the related material class will have an API which is slightly dictated by the design code. And this API will therefore be different for the various design codes that will be implemented in the long run. Which I think is a good approach. However, in the case of the higher level classes for sections and elements, the public API should not vary that much, and designing common interfaces for these using ABCs sounds very promising. E.g. all ReinforcedConcreteRectangular should have a moment_curvature method, irrespective of which design code it is based on, however the implementation of course changes.
We could even implement factories for the higher level classes similar to the SimpleConcreteFactory in your example repo, or the DesignCodeFactory in the present example.
@talledodiego and @DanielGMorenaFhecor, do you see any immediate issues with this structure?

Hi @mortenengen amd @talledodiego! I have been checking your new proposed changes.
So, as a recap, our idea is to use mc2010.__init__.py to import all function definitions from the desired modules. Just as an example, at the beginning of this file, we would write from ._concrete_material_properties import * . For me, it is OK, as they are going to be stateless functions that do not need to keep track of any object!
Just as a note, using the wildcard character * for the import statements is not usually a recommended practice, but in this case, I do not see any problems. Let me know if you think the opposite.
I have been thinking about how to deal with national annexes. One possible approach could be to create a new sub_module under de mc2010 root that takes care of the national annex (e.g. mc2010._national_annex.py) that contains the next definitions:
import typing as t

_NATIONAL_ANNEX: t.Optional[str] = None

def set_national_annex(national_annex='default') -> None:
    global _NATIONAL_ANNEX
    _NATIONAL_ANNEX = national_annex

def get_national_annex() -> str:
    return _NATIONAL_ANNEX

This way, we have a variable _NATIONAL_ANNEX we can point to through imports in other local modules. If we also import this file in the mc2010.__init__.py file, we allow the user to externally set up the desired national annex as stands in the following workflow, which I find pretty intuitive:
import structuralcodes.code.mc2010 as mc2010

mc2010.set_national_annex('ES')
fck = mc2010.fcm(fck=25, delta_f=8)
print(f'fck={fck}')

annex = mc2010.get_national_annex()
print(f'National Annex={annex}')

With respect to using the material, section, and element base classes, let me know if I understood properly: the idea is to use the structure from code.mc2010 (e.g. symbols, properties, ...) to define the main properties of these abstract entities (ABC) that have not any implementation yet and then define different advanced subclasses like MC2010Concrete or ECRectangularSection  which currently call to their respective code functions.
This way, I find it quite useful and straightforward for new contributors!
Anyway, I will communicate these updates to Alejandro, Carlos, and Javier so that they can keep track of the process. In addition, we internally discussed if it would be better to use Eurocode symbols and definitions for the main abstract classes Concrete, Section, and Element, but I think that they can offer more light in this area than I, that I am more code-focused! So we may chat about it later.
Thank you for your time!

Thanks for the checking, @DanielGMorenaFhecor 😃
Your recap of the idea behind the design code sub-packages is correct. As a remark, I think we should avoid the wildcard import, and rather import all the functions explicitly. A little bit more typing, but it makes the code so much easier to read afterwards 😃
I like your idea related to the national annexes, i.e. storing the label of the national annex in a global variable. However, the function set_national_annex could perhaps live in a module near the root of the main package, and furthermore live in the root namespace? In this way, the global variable that is set by set_national_annex could be the same for all the design codes that the user might want to include in the calculations. On the other hand, the details of the specific national annex of each design code should live in a sub-module under the respective design code, and from there, each design code should implement its own get_national_annex function. Does this make sense?
Your workflow would now look like this:
import structuralcodes.code.mc2010 as mc2010

from structuralcodes import set_national_annex

set_national_annex('ES')
fck = mc2010.fcm(fck=25, delta_f=8)
print(f'fck={fck}')

annex = mc2010.get_national_annex()
print(f'National Annex={annex}')

I think you got the idea of the materials, sections and elements.
Just let me emphasize that the materials, e.g. ConcreteMC2010, will have property names that correspond to the nomenclature in Model Code 2010. Other concretes might have other property names if their nomenclature is different.
On the other hand, on the section and element level, we might implement most of the interface in ABCs, since the methods of the sections and elements will most likely have the same names, irrespective of the code they are related to.
Summing up, the ABCs for the materials, e.g. Concrete, Reinforcement etc. will have just a very limited number of abstract stuff implemented, if anything at all. On the other hand, the ABCs for sections, e.g. RectangularSection and CircularSection will have most of the interface implemented as abstract methods. Any thoughts on this?

Closed with ca0ff0e.


createActions is converting constant names to camel case

I am not sure if this is intended but it cause as quiet a bug which was hard to find. We used the reducer name stored in a constant to create actions..and later on in the app we built upon the constant..one of my colleagues changed the constant from partnerCrud to partnerCRUD..since we were expecting the actions created to be partnerCRUDAction we were created a quiet big bug in the application..which took really long to debug
I would suggest that the createdActions will keep whatever name was passed to it

This is intended, based on the Redux naming conventions for actions. See https://decembersoft.com/posts/a-simple-naming-convention-for-action-creators-in-redux-js/.


python310Packages.flux-led: 0.28.32 -> 0.28.34

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 201899 run on x86_64-linux 1

6 packages built:

home-assistant-component-tests.flux_led
home-assistant-component-tests.led_ble
python310Packages.flux-led
python310Packages.led-ble
python39Packages.flux-led
python39Packages.led-ble


[Warning] Critical dependency: the request of a dependency is an expression

Hi!
This line causes a npm warning!
https://github.com/wooorm/remark-github/blob/7c63f620f7020fa33ba74400a00a0ea499a7b70e/lib/index.js#L47
WARNING in ...Storybook_mono/node_modules/remark-github/lib/index.js
47:13-73 Critical dependency: the request of a dependency is an expression

Thanks @UsulPro! 🎉


Clasp commands execute but never return to the prompt

Expected Behavior
clasp commands, such as "clasp status", should execute and return to the command prompt
Actual Behavior
clasp commands execute, but seem to hang indefinitely after executing, requiring a crtrl+c to get back to the command prompt
Steps to Reproduce the Problem

clasp login
execute any command

Specifications

Node version (node -v):  Win10 Powershell - v12.13.1, Win10 WSL Ubunutu v8.10.0
Version (clasp -v): 2.3.0
OS (Mac/Linux/Windows):  Win10 Powershell, Win10 WSL Ubunutu

I too am having this problem.
@swvajanyatek Are you able to run clasp apis list or clasp list without errors? See #719.

clasp apis list - prompts for a 'GCP projectId'
clasp list - returns the list of files, but never returns to the prompt

Yeah. Must be a bug. Now hopefully the devs see it.

@imthenachoman are you also experiencing this issue on a Windows platform? Please detail your environment.

@PopGoesTheWza
Yes

Node version: v10.16.3
Clasp version: 2.3.0
OS: Windows 10
Enterprise G-Suite

I personally have no Windows environment to attempt reproducing the issue.

@PopGoesTheWza Is there anything I can do to help debug? Is there some command we can run to increase verbosity to see what it’s trying to do?

We can try opening a PR with Travis CI scope extended to test Windows platform...

I am not sure what that means. Is there anything I can do to get that done? The delay in returning to the prompt is a real productivity killer. :(

@imthenachoman can you test the following:

uninstall claspboth locally and globally
invoke clasp via npx (i.e. npx clasp apis list)

From a quick review of the issue, it might be necessary that every clasp command explicitly terminates after execution with process.exit()
Also try.. catch... for failing promises/async functions is lacking in some places.

@swvajanyatek & @imthenachoman if you can try to build clasp from PR #721  (https://github.com/PopGoesTheWza/clasp/tree/issue-717) and test it... Travis currently fails because of exhausted quotas, thus requiring to wait 24 hours to run again.
Since I do not have a Windows system to use, I cannot test it myself.

@imthenachoman can you test the following:

uninstall claspboth locally and globally
invoke clasp via npx (i.e. npx clasp apis list)

npm uninstall -g @google/clasp and npm uninstall @google/clasp
npx clasp clone ....

(long wait, almost a minute)
{ Error: Command failed: clasp -v
'clasp' is not recognized as an internal or external command,
operable program or batch file.
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:198:13)
at maybeClose (internal/child_process.js:982:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5) killed: false, code: 1, signal: null, cmd: 'clasp -v' }

Warning: files in subfolder are not accounted for unless you set a '.claspignore' file.
Cloned 10 files.
└─ main.js
└─ appsscript.json
Not ignored files:
└─ appsscript.json
└─ main.js
Ignored files:
└─ .clasp.json
(long wait, almost a minute)

From a quick review of the issue, it might be necessary that every clasp command explicitly terminates after execution with process.exit()
Also try.. catch... for failing promises/async functions is lacking in some places.

Do I need to do anything here? Not sure where/how I would add process.exit()?

@swvajanyatek & @imthenachoman if you can try to build clasp from PR #721 (https://github.com/PopGoesTheWza/clasp/tree/issue-717) and test it... Travis currently fails because of exhausted quotas, thus requiring to wait 24 hours to run again.
Since I do not have a Windows system to use, I cannot test it myself.

Uh, I will have to see how build clasp. I have never done that before. Any documentation/information on how to build clasp?

@swvajanyatek & @imthenachoman if you can try to build clasp from PR #721 (https://github.com/PopGoesTheWza/clasp/tree/issue-717) and test it... Travis currently fails because of exhausted quotas, thus requiring to wait 24 hours to run again.
Since I do not have a Windows system to use, I cannot test it myself.

I now realize Travis CI is a product name. I thought it was a person's name.
I followed the instructions at https://github.com/google/clasp/blob/master/docs/develop.md:

tsc: npm install -g typescript
npm uninstall -g @google/clasp
npm install
npm run build;

Then, in the same directory, I ran clasp clone ..... It cloned the project fine but, after it was done, it still sat at the prompt for a bit.

@imthenachoman develop.md is quite outdated it seems... :)
did you test with a copy of this branch? : https://github.com/PopGoesTheWza/clasp/tree/issue-717

@imthenachoman develop.md is quite outdated it seems... :)

Did I do something wrong?

did you test with a copy of this branch? : https://github.com/PopGoesTheWza/clasp/tree/issue-717

Yes. I downloaded a ZIP from that URL and then extracted locally. Can't git clone for various reasons.

Odd. I bumped the PR to check that Travis CI now completes with node 8, 10 and 12 on Linux, MacOS and Windows.
Can you try and:

download again from https://github.com/PopGoesTheWza/clasp/tree/issue-717
check in package.json that version is 2.3.717
re-install with the commands npm uninstall -g clasp, npm install and npm run build

Test and report for as many clasp commands as possible (status, login, etc.)
TIA

Here is what I did:

downloaded https://github.com/PopGoesTheWza/clasp/archive/issue-717.zip
extracted
confirmed package.json shows "version": "2.3.717"
npm uninstall -g clasp

up to date in 0.039s

npm uninstall -g @google/clasp

up to date in 0.037s

npm install

[...]
added 461 packages from 836 contributors in 14.917s

npm run build

><EMAIL_ADDRESS>build C:\Users\userid\Documents\VBG PS\clasp\clasp-issue-717
> npm run build-local && npm i -g --loglevel=error

><EMAIL_ADDRESS>build-local C:\Users\userid\Documents\VBG PS\clasp\clasp-issue-717
> tsc --project tsconfig.json

C:\Users\userid\AppData\Roaming\npm\clasp -><EMAIL_ADDRESS>+<EMAIL_ADDRESS>added 1 package from 1 contributor in 0.93s

renamed ~/.clasprc.json to ~/.clasprc.jsonx
clasp login -> opens a Chrome window with an error:

400. That’s an error.

Error: invalid_request

Invalid parameter value for redirect_uri: Missing scheme: http%3A%2F%2Flocalhost%3A54620

Learn more

Request Details
  access_type=offline
  scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.deployments%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.projects%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fscript.webapp.deploy%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.metadata.readonly%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive.file%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fservice.management%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Flogging.read%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile%20https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform
  response_type=code
  client_id=[redacted].apps.googleusercontent.com
  redirect_uri=http%3A%2F%2Flocalhost%3A54620

That’s all we know.

clasp login --no-localhost worked but sat at prompt for a while
clasp clone .... worked but sat at prompt for a while

Do you need me to run more commands? Is there anyway to get more verbose debug output? And/or if you can tell me where to look in the code, maybe I can add dummy marker output (i.e. 1, 2, 3, etc...) so I can see exactly at what step its getting "stuck" at?
Also, should I do npm uninstall clasp and npm uninstall @google/clasp in the same folder too?

@imthenachoman
step 4: npm uninstall -g clasp should be unnecessary (step 5 is correct)
steps 10 & 11: "worked but sat at prompt for a while" do you mean that it eventually returned correctly to the prompt? If so, this would mean that PR #721 fixes the issue. FYI, on MacOS too @google/clasp sometimes takes some times before returning to the prompt.

steps 10 & 11: "worked but sat at prompt for a while" do you mean that it eventually returned correctly to the prompt? If so, this would mean that PR #721 fixes the issue. FYI, on MacOS too @google/clasp sometimes takes some times before returning to the prompt.

For me, it always eventually returned -- even before PR #721. I run the clasp command, like clasp push, it does its thing, and then, from what I can tell, just sits there waiting (or doing something in the background) before the process gracefully finishes.
And, while it is waiting, the actual command finished. For example, if I type clasp push, it'll push the files and then wait. While it is waiting, before it gracefully finishes, I checked and the code was updated. So I'm not sure what it is doing after it finishes the push but before finishing.

I am having a similar issue, just instead of hanging indefinitely, it hangs for about a minute or two.
I'm running Ubuntu MATE 20.04 with node version v10.19.0 and clasp version 2.3.0.

Can you try by building from PR #778 if there is any improvement?

Can you test with the #791 unofficial release?
npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more

Can you test with the #791 unofficial release?

I just tested it - there's no change in regard to this issue. However, it feels slower to perform any command.
It also ignores all files by default, which is not the current behavior.

While I have not looked at the latest unofficial release, I can confirm the behavior observed.
Time output is as follows:
real	1m22.860s
user	0m1.031s
sys	0m0.247s

Running Mac with node v13.11.0 and clasp 2.3.0

Just checking on this. Is there anything we can do to help debug. Is there a way I can see on what line in the code-base clasp is getting hung at?

I haven't been using clasp or Google Apps Script for a while, but I just had to come back to an old project and (without updating node or clasp) it now returns to the prompt immediately, without hanging.

@plonibarploni What version are they? I am still having issues and I am using the latest everything.

@imthenachoman I posted them earlier: node version v10.19.0 and clasp version 2.3.0.

There seem to be multiple issues for the same thing. I am sure there are more but I can't find all of them. Not sure which one we want to be primary so I am posting this in all of them. Any resolution or idea what is wrong?

https://github.com/google/clasp/issues/805
https://github.com/google/clasp/issues/717 (this one)
https://github.com/google/clasp/issues/257

There seem to be multiple issues for the same thing. I am sure there are more but I can't find all of them. Not sure which one we want to be primary so I am posting this in all of them. Any resolution or idea what is wrong?

https://github.com/google/clasp/issues/805
https://github.com/google/clasp/issues/717 (this one)
https://github.com/google/clasp/issues/257

Try replacing @google/clasp 2.3.0 with forked-clasp which is more advanced. This issue is fixed.
npm uninstall -g @google/clasp
npm install -g forked-clasp

Fixed in https://github.com/google/clasp/releases/tag/v2.3.1


Checking Data Connector manually by installing generated ARM template

Describe the bug
I've created a new Data Connector Solution (Varonis SaaS). And I would like to check how it will look like on the customer side. I took a generated ARM template for my solution and see two issues.

Data Connector page shows that there is not any workbook associated with my connector, but I can find it in workbooks section in Workbook templates
Data Connector page shows that there are two Sample Queries associated with the Data Connector, but I can't find them anywhere

Not sure that it's a bug, and will it change after solution will be in Content Hub.
To Reproduce
Steps to reproduce the behavior:

Install Data Connector Solution using mainTemplate.json
Open Data Connector page
Check Workbooks amount and Queries amount
Open Workbooks section
Open Templates Tab
Check that workbook exists
Open Log section
Open queries and search for "List all Varonis Alerts"
There is no query with this name

Expected behavior

Number of workbooks associated with Data Connector should be 1
Sample Queries associated with Data Connector should be in Log Analytics Queries

Screenshots

Hi @vkorenkov-varonis,Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 15-06-2024 Thanks!

Hi @vkorenkov-varonis,
Please refer below points.

Workbook count not visible on dataconnector page because workbook metadata do not present in WorkbooksMetadata.json file, need to add workbook metadata in it, please raise the PR for same. Once PR merged into master and solution published after that workbook count will be visible.
File Path : https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V2/WorkbookMetadata/WorkbooksMetadata.json

Due to the current design, count of sample queries is showing on data connector page, but these queries not visible anywhere. We have notified this issue to the respective team, and they will work on it.

Workbook count not visible on dataconnector page because workbook metadata do not present in WorkbooksMetadata.json file, need to add workbook metadata in it, please raise the PR for same. Once PR merged into master and solution published after that workbook count will be visible.

it's presented.

I've seen that workbook (VaronisSaaS.json) is not presented in global Workbooks folder, where WorkbooksMetadata.json  located. So, I copied it from Solution, then regenerate mainTemplate.json. It hasn't been changed.

Once PR merged into master and solution published after that workbook count will be visible.
As I understand it will be visible only publishing Solution, am I right?

Hi @vkorenkov-varonis,
It is not required to add this workbook into path, remove it from file: https://github.com/Azure/Azure-Sentinel/tree/master/Workbooks
Only add meta data into file: https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V2/WorkbookMetadata/WorkbooksMetadata.json
Thanks

Hi @v-rusraut,
I use V3 tool for creating solution and there is no WorkbooksMetadata.json in the tool folder. I'll try version V2, but just for you to know about V3

Hi @vkorenkov-varonis,
Please package the solution using V3 tool, no need to add workbook metadata in WorkbooksMetadata.json file.
Thanks

@v-rusraut
I did what you said,

then package it with v2 tool, and have got the same result:

Hi @vkorenkov-varonis,
Currently we need to create package using v3 tool only, don't create package using v2.
Create package using v3 and raise the PR, once PR merge, we can publish the solution.
Thanks

@v-rusraut,
What's about queries? Can I see the progress of the bug, or how can I know that it's going to work?


Message boxes show up always on first Monitor

If more than one monitor is attached to a Windows PC and kinematic is actually not running on the first one, the message boxes still show up on the first screen.

I don't believe this is a kitematic issue but more of a mirror setting within the control panel. Did you try to tweak some of the settings?

No, I didn't tweak anything.
Do message boxes in kitematic use "center screen" or "center app" when messagebox.show is called?
As windows developer, I often had to do with similar issues :-)

@thomasvogel we actually use the electron app type messages - Do you get a similar message with the Atom editor?

Closing this issue due to the lack of activity in more than 15 days


Example app: Setting a recurrence end, then setting the recurrence end to be indefinitely will incorrectly save the event

When editing or creating a calendar event, if you set recurring to end:

then select end to be indefinitely:

the event end will not be set to indefinitely:

Here, in the calendar view, I only see only one event was created rather than multiple events since it should end indefinitely (there should be several events shown).
This was the recurring event value saved:
I/flutter (10340): RECURRING: {totalOccurrences: 1, interval: 1, recurrenceFrequency: 0}

This is the intended recurranceRule for an indefinite event:
I/flutter (10340): RECURRING: {interval: 1, recurrenceFrequency: 0}

I am not able to replicate this issue following these steps. Could it be, that this issue is fixed!? Can you take a look and check if issue still remains?

@andzejsw This is still an issue in the https://github.com/builttoroam/device_calendar develop branch. I updated the original issue comment to include clicking save as a step.


Create dataset loader for Khmer ALT POS

Dataloader name: khmer_alt_pos/khmer_alt_pos.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?khmer_alt_pos

Dataset
khmer_alt_pos

Description
The data contains 20,000-sentence Khmer corpus with manual tokenization and POS-tagging annotation.

Subsets
-

Languages
khm

Tasks
POS Tagging

License
Creative Commons Attribution Share Alike 4.0 (cc-by-sa-4.0)

Homepage
https://www2.nict.go.jp/astrec-att/member/mutiyama/ALT/km-nova-181101.zip

HF URL
-

Paper URL
https://dl.acm.org/doi/10.1145/3464378

#self-assign


Remove support for exceptions.nonBlocking

This fields is deprecated and will soon be removed from the EnterpriseContractPolicy custom resource.

For ec-policies. https://github.com/hacbs-contract/ec-policies/pull/399


Request for pretrained model checkpoints

I'm wondering if there's any plan of making pre-trained models available. Thanks! 😀

Hi! Yes, we are planning on releasing in the next few weeks pre-training / fine-tuning code as well as the checkpoints after raven pre-training.


Implement disabling of caching private responses

I implemented the simple disabling of caching private responses that was suggested in #224 in order to support creating a shared cache.
I didn't implement any special handling for the case where a server specifies that only some headers are supposed to be private. Instead, any response with private in the Cache-Control is considered not cacheable.

Actually, I think this behavior also deserves a mention in the docs. Let me add that.

Looks very good, thanks! Can we also have a changelog entry for this feature?

Certainly! I added a line to the changelog.


docs(examples): add missing key props

Somehow, several examples were missing their key props.  I'm not sure how this got by CI, since, tests are failing for it.  This PR adds missing keys where they are needed.

Current coverage is 95.89% (diff: 100%)

No coverage report found for master at f95a519.

Powered by Codecov. Last update f95a519...542b916


Resolve substituted project dependencies when performing dependnecy mapping

If attempting to resolve a module dependency substituted for a project dependency using variant coordinate mapping, we would fail since the project dependency resolver was not cross-build. We update the project dependency resolver to be a build tree scoped service so that it can resolve publications from all projects in the build tree and not just the current build.
Furthermore, we failed to resolve these substituted dependencies when using component dependency mapping, as the component coordinate mapping implementation only looked at resolved local components when resolving module dependencies. A proper implementation would look at requested vs selected components, so we update the existing variant mapping implementation that performs this logic to also implement the component mapping interface.
While updating the project dependency resolver, we also update the project publication registry to not hold onto Project instances but instead operate solely on ProjectIdentity references.
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)


This has to become vim.utf8

I will love to see this on neovim, and I think @tjdevries will agree.

I've done a draft PR.


Popper is not correctly placed

CodeSandbox demo
https://codesandbox.io/s/elated-sid-sgwqg ( refresh codesandbox embedded browser )
Steps to reproduce the problem
No steps required, popper is not correctly placed

What is the expected behavior?
Popper should be correctly placed
What went wrong?
Looks like in flex box container, if element before has some non integer width ( as in this example using content editable aaas has width of 27.531 ) popperjs fails to correctly place the popper
Any other comments?
Looks like it's connected with #713

I found that it happens if getBoundingClientRect returns not integer left value for the trigger element (e.g. 31.5 px). In this case popper position is less by 1px from proper one. In my case it happens only when fixed strategy is used.

Thinking on it, why we need the rounding at all ? Looking on modern browser all would handle it 🤔 Maybe given option to opt out from rounding would be not that bad idea? WDYT?

So something like this https://github.com/popperjs/popper-core/compare/master...piecyk:feat/round-option With round: false user can opt out from rounding.
{
  name: 'popperOffsets',
  options: {
    round: false,
  },
},

Tested on firefox, safari, edge and looks great with pixel perfect position of popper. On chrome looks like there is a bug setting position with translate3d/translate makes it not correctly placed, but using left/top it is. IMHO there should be no difference. Need to check if someone reported a bug. Till then we need to fallback to left/top with disabling gpuAcceleration on computeStyles

Example of those inaccuracies in chrome/edge between position left/top vs translate3d/translate what i was writing above  https://codesandbox.io/s/cool-chandrasekhar-mcbp1


Simplify outputs

Summary of changes:

<OUTPUT_PATH> replaced by <OUTPUT_NAME>
<OUTPUT_NAME>_epsg_4326.geojson writes to <INPUT_PATH> directory
Changes to README on run commands (not changed Docker section yet)

@fredshone Switched to pathlib. Noted on the Docker image - thanks for checking. I think its an issue with spatial packages on the M1 so I've created a separate issue for that.


Profiles required on HDD when packaging, despite their existence in .forceignore

I had some automatically created profiles surf down into my IDE from a SO, I didn't want these in a package, so very early on in the project I added this to my .forceignore:
force-app/main/default/profiles/Admin.profile
force-app/main/default/profiles/Custom%3A Marketing Profile.profile
force-app/main/default/profiles/Custom%3A Sales Profile.profile
force-app/main/default/profiles/Custom%3A Support Profile.profile
force-app/main/default/profiles/authtest Profile.profile

I was tired of seeing the files on my hard drive, so this morning I deleted them, knowing they were not packaged anyway.
Verified by examining all existing versions of package, none include the profiles
well, after I cleaned up my drive, I tried to make a new version, and I got this:

"message": "We couldn't create this package version because new components were added or existing components were deleted. Add components {Profile=[Custom%3A Support Profile, Custom%3A Marketing Profile, Admin, Custom%3A Sales Profile, authtest Profile]} back into the package version, and create the package version again.",

so I went back through my local history and grabbed the profiles, put them back and I ran the exact same command

"Status": "Success",

examine package after this, still does not contain profiles, as expected

This strategy works through 7.200.4. It appears that even though these profiles are included in the .forceignore file, they are still included in the package.xml sent to Salesforce but not actually packaged.
However starting with 7.200.5, my builds fail because they are now not included in the package.xml sent to Salesforce.

I believe this issue is now fixed and is similar to several newer issues such as:
https://github.com/forcedotcom/cli/issues/620
https://github.com/forcedotcom/cli/issues/2336
Profiles are searched within all package directories defined in sfdx-project.json.  .forceignore does not apply in this search, which is by design.  Only aspects of the profiles that are relevant to the metadata being packaged are used.


fixed improper capitalization of Params.Social

index.html and social.html refer to social parameters by Params.Social, but config.toml in the exampleSite has Params.Social as Params.social (lower case "s"), this prevents URIs from being assembled correctly.
Also it seems like I don't have push permissions to the original repo.

Hey, @timateus!
Thank you for your contribution!
Site params are case insensitive, it should work in any case: .Site.Params.social == .Site.Params.Social. Closing it for now.
Cheers!


Feature: Add timer countdown to waits

First off, thank you so much for making this tool -- it's phenomenal and I have been using it for ages now!
feat: Add Timer Countdown
This PR adds a configurable timer to the Waits training mode.
The goal is to mimic both real life scenarios which are time pressured, especially online matches, as well as tests material with time restraints like maru-jan.
Notes:

Please feel free to reject / edit this as you see fit -- though this is a feature that has been on my wish list, I completely understand if the interest otherwise isn't there.
I am unsure if the translations to eo/es are correct in context (auto translated and cross referenced to my best ability).
If manual testing isn't enough, I can add automated tests if needed.

Changes:

Adds a timer preference with the options of [Off, 10, 30, 60] (seconds) -- these values are not based on any rigorous requirements so if others are preferred (such as 24 to mimic online), it's an easy update.
Adds a countdown below it that displays remaining duration.
When the timer is enabled:

each new hand resets the timer
an expiring timer triggers a ConfirmSelected message
changing the timer duration triggers a GenerateTiles message

Adds translations for new labels

Testing:

Manually tested the timer functionality with different timer durations, ensuring it starts, updates, and stops correctly.
Verified that the timer resets when generating a new hand.
Confirmed that the timer does not start when the timer duration is set to Off.
Checked both light / dark mode visibility.

Screenshots:
Default Off:

Timer running and hand submitted:

Timer expires:

That's great @JustinHallquist! Give me some time to review it, I've been very busy lately.

No rush and thank you for taking the time!

@JustinHallquist wonderful job! :medal_sports:   I'll merge this and fix some translations, thanks for the pull request.
I'd like to hear your feedback, what are the things you like the most about this tool?

Hey @djuretic, thanks for the review! (and sorry for making work for you on the translations)
On review as to why I enjoy this wait trainer, I believe it hits pretty hard on some of the golden rules for good feature dev:

Does one thing well
Design is clean, responsive, simplistic, and obvious
Fast
The skill settings (block count + min wait count) and animation really helped me when I was new. I started at 4 tiles and incremented the # of waits until I was comfortable adding another block, rinse repeat.
Now I use it as a timed 13 tile chiniisou trainer -- just leave the tab on the side and hammer a few out during breaks in the day.
I've used some other tools before finding this one and they were much clunkier or more of an afterthought as part of a larger suite of mahjong training tools.
So overall, it's just great at what it does.
Again, thank you so much for this!

Thanks a lot for your feedback @JustinHallquist !


Update version

fix #33

Pull Request Test Coverage Report for Build 144

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 31.648%

Totals

Change from base Build 142:
0.02%

Covered Lines:
1089

Relevant Lines:
3441

💛  - Coveralls


Add documentation for aggregates returning NULL for non-NULL columns

Figured this might be a good starting point. Feel free to suggest or directly make any edits.
Fixes #53.

That fits in perfectly. I love it!


Without this, env variables for rbenv or rvm aren't properly set which causes
issues with gem loading

http://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my


test-branch7

Can one of the admins approve running tests for this PR?

aswdefawf@nuci launch!

as@nuci approved!

a


Unable to calculate Confidence between 2 images in elastic search

when input image and database image are same then max score is outputting 1.00 but it should be 0.0 as both the images are same.
I'm using same code as you did in elastic search. using facenet model.
i tried 100 - max_score but still unable to calculate Confidence in (%).
thanks

try (1 - max score) * 100

try (1 - max score) * 100

I tried (1 - max score) * 100 but now as i increase size in query i.e size = 50. now the last image has highest confidence... why? but in fact 1st image is more similar so it must have high confidence... something is wrong

I tried (1 - max score) * 100 but now as i increase size in query i.e size = 50. now the last image has highest confidence... why? but in fact 1st image is more similar so it must have high confidence... something is wrong

I tried to increase query size to 100 as I have 500 images.. now the 1st result has 92.37 % and last image at 100th position has  92.95% why?

I tried to increase query size to 100 as I have 500 images.. now the 1st result has 92.37 % and last image at 100th position has  92.95% why?


Request: Beaker icon

@chuglydude of course you could make it, if you want

This can be closed, there is now a proper beaker icon: https://github.com/driftyco/ionicons/commit/5b7e2fce4d2b6bddf29086eecd3e418bb0cdabb5

right

:sunglasses: :sunglasses: :sunglasses: :sunglasses:


Include SDE build steps in the dockerfile itself & do some cleanup

The steps starting at https://github.com/ipdk-io/ipdk/blob/5e737af4c302013d5a50a5fd287ed43ec8366ef4/build/IPDK_Container/README#L53 are done from within the container. This adds manual steps and also means the changes are ephemeral - if you lose the container you'd have to redo everything, and it is fairly time-consuming. (It took nearly a full day to completely build and modify the container - I have slowish downlink)  In my case I did a docker commit of the running container to a new image to preserve it.
Could those steps 4-5, (possibly #6) be moved into the dockerfile to reduce effort and result in a more complete, durable image?
Also, I think the image could benefit from some cleanup after all the installing is done. The docker commit following SDE install produced a 13GB image! See below - the first image is the committed container after SDE install.
$ docker images
REPOSITORY         TAG       IMAGE ID       CREATED       SIZE
ipdk               latest    b801f17e5efd   11 days ago   13.3GB
ipdk/p4-ovs-fc33   1e7b540   96137ba4f7bf   11 days ago   1.67GB
fedora             33        a5465556eeb2   6 weeks ago   172MB

I agree that this container build process and resulting container isn't as optimal as it should be for other then hard-core development. A lot need to be done to streamline the creation of (a) container(s) without all the build artefacts and libraries that are not needed any more when doing testing (or later in production). For me the total build process is 35 minutes and not really a problem (at the moment), but the resulting ultra large image is a pain in the ass... ;-)

I Agree. With current Container approach, need to repeat the entire process again when we loose the container. Build process consumes considerable amount of time based on the type of server environment used for build procedure.
Definitely couple of optimizations needed for reducing the Docker image size.
Soon we are gong to commit the following changes to reduce the Docker size and address the dependent libraries, source code persistence with base container image.
Docker file modified to

Clone all required repositories, build and install all required modules.
Remove all dependent module source code.
Remove all build artifacts in source directories once after installing the modules either in standard path or custom user specified path.
Remove redundant standard packages

There is some room to optimize the amount of memory using for standard packages too.
We will be addressing this in next immediate commits.
Another major contributor for Docker image size is source code. We are working on approach which helps to reduce the image size without loosing the flexibility for development environment.
Idea is to install all the libraries and binaries required to run the scenarios by default and provide utility scripts to pull the source code on demand basics.

Sounds good... I will wait for the commits then before working on them myself!

Suggest to provide a build option (e.g. env variable) to retain the source, so a subsequent step isn't required to pull it in. Pulling it in afterwards is not a bad idea either.

I have been experimenting this weekend with variants of the scripts that do all cloning and compiling in the base Linux system itself, with no Docker involved.  I have nothing against Docker, other than my current ignorance in debugging issues specific to that :-)   You can't get any more persistent than storing changes in the Linux system's base file system, though.

Note that I've taken a step in this direction with #25 and will merge that today, we should build off of this in terms of the Docker images. I may take a pass at slimming things down a bit.

I've build the a new docker image after #29 was pulled to main and it build to a 'nice' 6.63 GByte. A lot better then old process steps :-) If I find some obvious 'low hanging fruit' to slim it down further I will report it...

With latest commits,

The complete build procedure is part of the docker build procedure.
Cleanup logic added to remove build artifacts once module libraries and binaries are installed.
To reduce the image size, added an additional user configurable option which indicates whether to keep all module source code or not. By default, source code is removed once after installing all the binaries.

With latest improvements, overall image size is
< 5.6 GB when source code is part of the image
< 3.5 GB when source code is not part of the image.

Excellent progress, thanks!

@chrispsommers, Can I close this issue as most of the key image size contributors optimization have already taken care?

Sure, thanks for following up. I wasn't sure about the "close issue" protocol on this project. Be my guest!

@chrispsommers, Thanks. Closing issue.


Fix unmount failure for paths with symlinks

Root mountpoint directories that contain a symbolic link are not handled correctly.
For example, /var/log/ -> /var/volatile/log, in this case when we mount something to /var/log/... the kernel records the mountpoint as /var/volatile/log/..., so when we try to unmount /var/log/... it fails.
This problem is fixed by fully expanding the mountpoint path (with canonicalize) before checking and unmounting the mountpoint.
Also make some improvements to the log messages and fix some typos.

@majorz Would you be able to review this? (particularly the Rust modifications) - Thanks

@balena-ci retest

@majorz would you mind adding a README.md file to this PR with some basic project info? Thanks.


Add non electric cars to the integration

Is your feature request related to a problem? Please describe.
Please add non electric cars to the integration.
Describe the solution you'd like
Please add combustion engine cars.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
I have a VW Touran with diesel engine. I have installed the Volkswagen app and I added my car to it. I have We connect and We Connect Plus services activated. I try to add it to HA with your integration and it gives an "Unexpected error".
See below several error messages from the log:
Logger: homeassistant.config_entries
Source: config_entries.py:402
First occurred: 12:02:52 (5 occurrences)
Last logged: 12:10:39

Error setting up entry Volkswagen We Connect ID for number
Error setting up entry Volkswagen We Connect ID for device_tracker
Error setting up entry Volkswagen We Connect ID for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 402, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/number/__init__.py", line 114, in async_setup_entry
    return await component.async_setup_entry(entry)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 195, in async_setup_entry
    return await self._platforms[key].async_setup_entry(config_entry)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 293, in async_setup_entry
    return await self._async_setup_platform(async_create_setup_task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform
    await asyncio.shield(task)
asyncio.exceptions.CancelledError: aiohttp connection lost

Logger: homeassistant.config_entries
Source: config_entries.py:402
First occurred: 12:02:53 (2 occurrences)
Last logged: 12:10:39

Error setting up entry Volkswagen We Connect ID for volkswagen_we_connect_id
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 402, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/volkswagen_we_connect_id/__init__.py", line 81, in async_setup_entry
    await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1398, in async_forward_entry_setups
    await asyncio.gather(
asyncio.exceptions.CancelledError

Logger: weconnect
Source: /usr/local/lib/python3.11/site-packages/weconnect/elements/generic_status.py:81
First occurred: 12:02:04 (14 occurrences)
Last logged: 12:11:39

/vehicles/WVGZZZ1T7XXXXXXXX/domains/measurements/rangeStatus: Unknown attribute totalRange_km with value 660

Logger: weconnect
Source: /usr/local/lib/python3.11/site-packages/weconnect/elements/vehicle.py:356
First occurred: 12:02:04 (14 occurrences)
Last logged: 12:11:39

/vehicles/WVGZZZ1T7XXXXXXXX: Unknown attribute fuelLevelStatus with value {'value': {'carCapturedTimestamp': '2023-11-20T18:18:37Z', 'currentFuelLevel_pct': 80, 'primaryEngineType': 'diesel', 'carType': 'diesel'}} in domain measurements
/vehicles/WVGZZZ1T7XXXXXXXX: Unknown attribute fuelLevelStatus with value {'value': {'carCapturedTimestamp': '2023-11-21T11:09:07Z', 'currentFuelLevel_pct': 80, 'primaryEngineType': 'diesel', 'carType': 'diesel'}} in domain measurements

I get the same error although I do have an electric car (e-Golf).
Source: /usr/local/lib/python3.11/site-packages/weconnect/elements/vehicle.py:348

/vehicles/******: Unknown attribute fuelLevelStatus with value {'value': {'carCapturedTimestamp': '2023-11-21T07:56:18Z', 'currentSOC_pct': 72, 'primaryEngineType': 'electric', 'carType': 'electric'}} in domain measurements

@mitch-dc  Hi! Could you please reply to my request?
Thank you.


App crashed in production

When I call to number app crashes in production, but working in debug mode

@Dinesh-Sowndar Hey you need to add Android proguard rules.
# Preserve Twilio Voice SDK classes
-keep class com.twilio.voice.** { *; }
-keep class tvo.webrtc.** { *; }
-dontwarn com.twilio.**
-dontwarn tvo.webrtc.**

It works. Thank you


Amend Polkadart

Hello, updating the payment method to Ethereum USDC and adding @pastre as our new core contributor!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @Lohann did you submit a new invoice with this address as well?


Invalid CSS file when SVG images have conflicting file names

After a successful integration of extract-svg-sprite-webpack-plugin to our project  I carefully checked the resulting CSS file one last time.
I found a few items resolved like this:
background: url(/___b5f499a2d2cab88d293d5e0c335ef204___)
I investigated the issue and the problem is that when you use two SVG images with the same file name (no matter the directory), one of them gets resolved properly and the second one ends this way.
What I find the most dangerous is that the compilation process does not throw any errors so you won't know until someone notices. (In our case we use extract-svg-sprite-webpack-plugin in production only so we would see it too late.)
Shouldn't that throw an error?

Okay so the core of problem seems to be not in conflicting file names but in conflicting symbol ids. Since the default to symbolId parameter is "[name]", in this default case the conflicts happen when file names are the same.
Fortunately that also brings us to the resolution: when you use a different symbolId parameter like
"[name]-[hash]", things get much better. However, this won't save you when you have two copies of the same file with the same file name in two different directories.
So we ended up with symbolId set to custom callback calculating sha1 hash from the SVG file's path. No more conflicts.

@vchrm added warning about several symbols with duplicating ids in<EMAIL_ADDRESS>


Rename "generated" files

We should rename some *.generated.cs files and correct comments (See https://github.com/PowerShell/PowerShell/issues/3222#issuecomment-283120200):

GetEvent_Types_Ps1Xml.generated.cs
TypesV3_Ps1Xml.generated.cs
Types_Ps1Xml.generated.cs

PR #3231 renamed Types_Ps1Xml.generated.cs to Types_Ps1Xml.cs. Two to go 😄


[FLINK-15051][state-backends] Fix typo in RocksDBStateBackend.getNumberOfTransferingThreads

What is the purpose of the change
This fixes a simple typo in the RocksDBStateBackend.getNumberOfTransferingThreads() changing to RocksDBStateBackend.getNumberOfTransferThreads().
The original method is retained and deprecated.

Will address the comment and merge this...


Polar coordinates

Hi again @grantmcdermott! Really enjoying tinyplot!
I think this is a feature request (maybe I've missed an existing feature), but I've got no idea if it's hard to implement - so no worries if it's outside the scope. It would be great to be able to support polar coordinate systems, so it becomes possible to plot circular data.

Thanks, added to our master list of plot types here. I'm not sure about implementation difficulty and we'd also need to think about the interface, since the standard x and y arguments are probably confusing in the polar (radian + theta) context.
(Great to hear that you're liking the package!)

Sounds good! I actually wouldn't think it is that confusing. Once one ventures into circular plots, my gut feeling is that people have an expectation of what will happen. Just my guess though! :P In ggplot, it just transforms the x and y values, so I'd expect the same syntax.


Improve InnerLoop workflow

Currently when using the InnerArea.props file, essentially one has to manually figure out the dependency chain. Few examples:

ItemsRepeater tests have a dependency on the LayoutPanel, Scroller and ScrollBar
If you want to use the NavigationView, you need the ItemsRepeater to be compiled too.

By the time one has figured out all of that, it might have been faster to just use the full loop.
I would like to work on this. The ways we could solve this are:

Different InnerLoop files for every control

Drawback: You would need to copy files all the time, which is to much work

A script doing all the magic

A lot of work and logic to put into a single script, can become messy to write

Conditional compile in FeatureAreas.props

Already done to detect InnerLoop area

Unless there seem to be better options, I would implement this using the last option as it provides the best clarity.

Yes. The last option seems like the best to me.

One thing that might not be common knowledge is that apart from 'True' and 'False' you can also use 'ProductOnly' to include a dependency but not its associated tests, which can break the set of dependencies you have to compile.

I would create a PR in the next few days, where I would update the props files to be include the needed dependencies for every control (which getting there is an tedious process as it involves compiling a lot). In that PR, I would also update the documentation regarding the inner loop.


Automated cherry pick of #8512: fix: avoid sync project panic

Cherry pick of #8512 on release/3.5.
#8512: fix: avoid sync project panic

Codecov Report

Merging #8513 into release/3.5 will decrease coverage by 2.62%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.5   #8513      +/-   ##
==============================================
- Coverage         6.14%   3.51%   -2.63%
==============================================
  Files              761     305     -456
  Lines           118373   62784   -55589
==============================================
- Hits              7269    2205    -5064
+ Misses          110445   60425   -50020
+ Partials           659     154     -505

Flag
Coverage Δ

#aFlag
3.51% <0.00%> (-2.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/cachedimages.go
1.66% <0.00%> (-0.10%)
:arrow_down:

pkg/compute/models/cloudregions.go
1.54% <0.00%> (-0.04%)
:arrow_down:

pkg/compute/models/cloudsync.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstance_secgroups.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancejoints.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstancenetworks.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstances.go
0.75% <0.00%> (+<0.01%)
:arrow_up:

pkg/compute/models/elasticcache_instances.go
0.88% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/elasticips.go
1.09% <0.00%> (+0.01%)
:arrow_up:

pkg/compute/models/guest_actions.go
0.00% <0.00%> (ø)

... and 457 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e20018...23dfe41. Read the comment docs.

/lgtm

/approve