Homebrew Cask support?

As titled.
Reference: https://caskroom.github.io/

Hi, thanks for the suggestion. I think that seems like a reasonable thing to do.
git-annex-turtle depends on git-annex being installed. Does it seem reasonable to have the git-annex-turtle cask depend on the git-annex brew formula?  BTW it appears that git-annex was once available as cask, but now it is just a formula.
In related news, it looks like we will bundle git-annex-turtle with the git-annex.dmg. I think that this will just be for the .dmg file though. I don't think it makes sense to include git-annex-turtle in the git-annex brew formula.
Andrew

I am not sure whether a cask formula can depend on a brew formula. But the way Homebrew works is it links binaries and libraries to their proper locations in /usr/local so they should be present in PATH. I thought the WebApp was not included in the brew formula but https://github.com/caskroom/homebrew-cask/issues/24214 told me and I confirmed that git annex webapp works.
I was a bit confused when git-annex-turtle didn't work for me, so I removed it. Now that you mentioned it, it might be because I installed git-annex through Homebrew but not git-annex.dmg. Now that I got git-annex.app too it works. So there's that.
On another note, the way most according to the spirit of an App Bundle is probably bundling git-annex within it directly, despite the possible duplication. Or as TortoiseGit does, an option to download a PortableGit to be embedded after installation.

v0.1 of git-annex-turtle performed a search for git and git-annex binaries on launch and failing to find them exited… v0.2 performs a more extensive search for these binaries including brew locations, so you should be able to delete your /Applications/git-annex now if you kept the brew version around. v0.2 now exposes these locations in the Preferences menu so you can see what it found. TODO is to actually let the user know if it found nothing…
Most likely, in the future git-annex-turtle will be bundled with the git-annex dmg, so this might all become less relevant. Yes, I could probably offer to download git-annex for a user if it is missing.


Implement get_replied_user

These are the following changes made

Added it as a separate module in /src/builtins/mod.rs.

Implemented it (/src/builtins/get_replied_user.rs):

Implemented the function which checks if the user replied to a message (if yes it returns the replied message author) otherwise it returns None which needs to be handled (for example the way in: /examples/get_replied_user/main.rs).

Added an example usage (/examples/get_replied_user/main.rs)

It's quite similar to the /age example but the function's return value needs to be stored prematurely so it can be taken as a reference in order for unwrap_or() is applicable to it.

I don't see why this should be in poise, instead of in a utility module in your own bot? It isn't that complicated and doesn't rely on anything internal to poise.

Hmm, is this functionality worth yet another function to keep around? If anything, it should be a method on Context instead of a free standing function.
Even then, the function essentially only does ctx.msg.referenced_message?.author plus some required boilerplate. How does this utility function help you in your bot codebase(s)?

I agree with the function not being complicated to implement, however I think it'll help out to add it in a more concise way for the sake of simplicity. It may be just my code base but I happen to use this pattern a lot with the way I retrieve a user.

Hmm, is this functionality worth yet another function to keep around? If anything, it should be a method on Context instead of a free standing function.

The method idea does sound like a very way to work around it. The boilerplate can just be shortened to another method because the context needs to be matched to a message context first (because ? only works on Result types) so the ctx.msg.referenced_message?.author needs to be extended to something like:
match ctx {
    poise::Context::Prefix(msg_ctx) => msg_ctx
        .msg
        .referenced_message
        .as_ref()
        .map(|x| x.author.clone()),
    _ => None,
}

It'd be even better if the author doesn't need to be cloned but I don't know how to do it without the clone.
My main motivation is that I've also seen a lot of bots which also use the message replies as a way to select a user for an interaction so a native library method which can shorten the boiler plate would be a helpful feature.
The way I did the implementation doesn't seem to be that good so if there's nothing more to reply on feel free to close this PR. Perhaps a poise::Context method along the lines of ctx.get_replied_msg_author() (returning an Option<User>) would be a better implementation for the same feature.
Thank you both for the feedback and I wish you have a nice day/evening!

Okay, I understand your point but I don't feel like this is a worthwhile addition, especially seeing that prefix commands are definitely in the minority of usages (I have statistics on this if you want to see) adding boilerplate for a prefix-only mechanism doesn't seem worthwhile to contain in the library.
This is not to say I would be against kanga merging this, but I'm not going to.

Okay, I understand your point but I don't feel like this is a worthwhile addition, especially seeing that prefix commands are definitely in the minority of usages (I have statistics on this if you want to see) adding boilerplate for a prefix-only mechanism doesn't seem worthwhile to contain in the library.
This is not to say I would be against kanga merging this, but I'm not going to.

Sure, I want to check out those statistics out of pure curiosity

Take a look in the serenity discord server, I'll send them there.

Hmm, is this functionality worth yet another function to keep around? If anything, it should be a method on Context instead of a free standing function.
Even then, the function essentially only does ctx.msg.referenced_message?.author plus some required boilerplate. How does this utility function help you in your bot codebase(s)?

Alright, I changed the PR to match a method implementation for the context struct instead of a separate function, I'm leaving the merge (or closing of the PR) up to you now.

Alright, I'm dumdum and I found out that this can be done without cloning by just returning a &User with the following utility:
pub async fn get_replied_user(ctx: Context<'_>) -> &poise::serenity_prelude::User {
    let poise::Context::Prefix(msg_ctx) = ctx else {
        return ctx.author();
    };
    let ref_msg = msg_ctx.msg.referenced_message.as_deref();
    ref_msg.map_or(ctx.author(), |x| &x.author)
}

Yeah, this PR isn't necessary since it can be done like that so I'm going to close it.
I'm sorry for the unneeded inconvenience.


⚠ Aither has degraded performance

In 735dd67, Aither ($AIH) experienced degraded performance:

HTTP code: 200
Response time: 1780 ms

Resolved: Aither performance has improved in fbe1712 after 8 minutes.


docs: fix a few simple typos

There are small typos in:

docs/source/articles/creatingagameengineplugin.rst
docs/source/articles/whatsinareplay.rst
docs/source/tutorials/prettyprinter.rst
examples/sc2autosave.py
sc2reader/engine/engine.py
sc2reader/events/game.py
sc2reader/objects.py
sc2reader/resources.py

Fixes:

Should read aggregated rather than aggrated.
Should read account rather than acount.
Should read versatile rather than versitile.
Should read unnecessary rather than unncessary.
Should read targeting rather than targetting.
Should read substitution rather than substition.
Should read requirements rather than requirments.

Closes #145

This fix ideally should be against https://github.com/ggtracker/sc2reader/ upstream branch


Slim3: RouteInterface missing middleware relevant methods

Slim\App->map()'s docblock says it returns a RouteInterface (actual object returned is of class Slim\Route). However, though Slim\Route has the MiddlewareAwareTrait (and hence has the "addMiddleware" method) and also has the "add" method, neither of these are detailed in the RouteInterface meaning that IDE autocompletion does not suggest ->add() or ->addMiddleware() being valid calls after a ->map (or ->get, or ->post etc etc).
Is there a reason those calls aren't listed the RouteInterface?

A PR has been accepted with that fix recently. #1618

Ah - thanks. Didn't see that. Cheers!

@rbairwell thanks for testing, contributing PRs and providing feedback.


How to store processed log to Kafka or Cassandra with Manual Commit?

Sorry I can't find a proper place to ask so I just open up an issue here (Close it if you think it's improper).
I'm currently doing a PoC based on this awesome reactive kafka module with the manual commit feature.
And I'm struggling adding a Sink to store log into some permanent storage system such as Kafka or Cassandra.
From your sample code messages are being processed on-the-fly in processMessage function, if I need to store data into Kafka, then I need to replace offsetCommitSink to another Kafka Sink, but in that way I can use offsetCommitSink to stream back for commit.
Another approach is to use a saveToKafka function to store processed log into Kafka(Shown in below), which is the current implementation of my PoC.
Source(consumerWithOffsetSink.publisher)
.map(processMessage()) // your message processing
.map(saveToKafka())
.to(consumerWithOffsetSink.offsetCommitSink) // stream back for commit
.run()
Do you think this is the best practice to achieve my goal?

@evans-ye Have you considered using Broadcast from Akka Streams' DSL?
Example: http://doc.akka.io/docs/akka-stream-and-http-experimental/1.0-M2/scala/stream-quickstart.html

Yeah, thanks for your prompt response.
CMIIW, my thought is when using broadcast, there's no guarantee that commit will be executed after data has been saved to my topic, hence there's a chance to lost data.
Let's say the stream saving data to my topic is slower, and the committing stream is faster.
When failure happened at the point that offsets get committed back, but the other stream saving data to my topic is still under processing, the data under processing is lost because when next time we start to fetch offset, the offset has been set to latter.

You definitely can do this (and I do) by using a broadcast and some flow stages so you'll commit only after the persist to Cassandra future completes. As a side benefit, this pseudo flow only sends the message itself to your persist method.
Source(publisher) ~> broadcast ~> Flow.map(.message).mapAsync(1)(persist) ~ zip.in0
broadcast ~> zip.in1
zip.out ~> Flow.map(.2) ~> commitSink

OKAY! I got your point. This looks perfect to me.
Thank you so much for the great help and the great module!
I only have one more question, which I think is the benefit using your module:
Comparing the reactive kafka with akka streams + akka persistence, which both provide at-least-once message guarantee, reactive kafka is way much efficient since we only write back offsets, while akka streams + akka persistence needs to persist every log down to disk. Am I correct?

Looks like we done with this


Displaced shading pattern

Attach (recommended) or Link to PDF file here:
shading_pattern.pdf
Configuration:

Web browser and its version: Firefox 57.0
Operating system and its version: Debian GNU/Linux 9 64-bit
PDF.js version: tried with Firefox's 1.9.583 and with online viewer 2.0.185
Is a browser extension: no

Steps to reproduce the problem:

Open the attached file with the online viewer https://mozilla.github.io/pdf.js/web/viewer.html

What is the expected behavior? (add screenshot)

(Image captured from Adobe Reader CS.) The shading needs to be inside the letters.
What went wrong? (add screenshot)

The shading seems to be displaced and upside-down, for it does not cover all the characters of the word.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Closing as duplicate of issue #8111; see also https://github.com/mozilla/pdf.js/blob/f299473697dab586946bbbe4e1aa288aaffc0ec6/src/display/canvas.js#L1463-L1464.


replace on completion (#55)

needs #143 to be merged first

@lhein requires rebase to solve conflicts

applied simplification of the completion logic

there is currently no test checking for the text edit afair


Recipe Crafting

Description
Craft recipes from components, if you have them.

A recipe with a single ingredient option shows only the one option
A recipe with a single result option shows only one option
A recipe with multiple ingredient options shows a selection carousel
A recipe with multiple result options shows a selection carousel
Results and ingredients appear on different tabs
When a selection needs to be made by the user the tab indicates this with an icon and/or colour
The preview for any Ingredient option shows which ingredients are present in the required quantities and which are not
Ingredients that are not present in the required quantity show how many additional ingredients are needed
A crafting button can be pressed in the header from either tab

Benefit(s)
It implements a core crafting feature for the "MVP".
Potential Implementation(s)
Crafting will be performed from a Recipe Crafting App, accessible from the top bar of the Item Sheet, if the Item is also a Fabricate Recipe (similar to Component salvage).
Additional Context
N/A

Implemented in 0.81 (Patron pre-release)


Release v0.17.0-rc2

I've started updating the CHANGELOG for the v0.17.0-rc2 release.
📖 Rendered CHANGELOG.md

[ ] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[x] Updated CHANGELOG.md

Codecov Report

Merging #668 (61a245d) into master (7ab136c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #668   +/-   ##
======================================
  Coverage    39.5%   39.5%
======================================
  Files         183     183
  Lines       12871   12871
  Branches     2943    2943
======================================
  Hits         5095    5095
  Misses       7528    7528
  Partials      248     248

Impacted Files
Coverage Δ

light-client/src/lib.rs
100.0% <ø> (ø)

light-node/src/lib.rs
100.0% <ø> (ø)

proto/src/lib.rs
100.0% <ø> (ø)

rpc/src/lib.rs
100.0% <ø> (ø)

tendermint/src/lib.rs
100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ab136c...61a245d. Read the comment docs.


Struggling to get this running in SRC mode on OSX

Thanks for this image and info
I am trying to run a simple test on my dev machine (OSX)
My meteor project is located in /Users/myusername/Documents/development/proj1
docker run --rm -e ROOT_URL=https://somengrokXYZ123.ngrok.io -p 80:80 -v /Users/myusername/Documents/development/proj1   ulexus/meteor
I get error Unable to locate server directory in ; hold on: we're likely to fail Failed to locate main.js in ; cannot start application.
Seems similar to https://github.com/CyCoreSystems/docker-meteor/issues/19
I have tried with settings file etc etc.. still get same issue.
Any help appreciated.
thanks

You need to specify both sides of that volume.  That is, mount the source to /home/meteor/src in the container with something like -v /Users/myusername/Documents/development/proj1:/home/meteor/src.


add Cache-Control header to S3 put_object if present in the request

Should fix #303, or at least the Cache-Control part specifically mentioned.

Looks like that'll do it!
It's a bit loose with available options.  Per AWS docs this must follow the specs at https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.9 .  It'll be up to the crate users to write the correct string that AWS supports until this is locked down into its own class that provides convenience methods.
I'm not able to write a test for this at the moment, so we'll yolomerge it and hope it works. 😄


In function.rs spread arguments are added to the symbol table but never declared in the function

This seems surprising, but adding a declaration for them seems to break regressions.

Looks like they're actually function params, but this is still not the right place to add them. Track for a fix.


Add test for species transport model

Test the following features of the species transport model:

Turning on the species transport model
Checking the mixtures object command list
Creating a custom mixture with custom species (using the TUI)
Copying an existing mixture
Reassigning a cellzone material to a different mixture
Deleting an existing mixture

Currently, the species transport model cannot be used without resorting to TUI commands due to the following open issues with the settings API:

Creating/copying mixtures: https://github.com/ansys/pyfluent/issues/2275
Listing mixtures, species, and properties: https://github.com/ansys/pyfluent/issues/2277
Deleting a species from a mixture: https://github.com/ansys/pyfluent/issues/2259
Creating a mixture from an empty dictionary: https://github.com/ansys/pyfluent/issues/2274

@dnwillia-work @raph-luc For your consideration in the latest commit. I've renamed the file to test_species_model.py and split it up into multiple tests. I created a fixture such that only one solver instance would be used across all tests, ensuring that we only start and shut down Fluent once for all six tests.
The tests are:

Activate the species transport model
Check the command list
Create a custom mixture from custom species
Duplicate a mixture
Change the mixture assigned to a cellzone
Delete a mixture

The problem is that if one of these tests fails, all the following tests will fail as well, like dominoes. I'm not sure if this is acceptable. If it isn't, a potential solution is to implement recognizing an incremental test marker in our conftests.py file that would skip all remaining tests in the class if one fails: https://docs.pytest.org/en/latest/example/simple.html#incremental-testing-test-steps

@raph-luc @dnwillia-work I've recombined everything into one test in the latest commit. Hopefully the name and comments are sufficiently descriptive.

@dnwillia-work @raph-luc The unit testing check for 23R2 is stalling (timing out after 6 hours) consistently on the test test_meshing_workflow.py::test_watertight_workflow_children, which seems completely unrelated to this PR. It seems to fail when I run it locally on 23R2. Any insight?

@ansjsia I believe it wasn't test_watertight_workflow_children that stalled (as the logs say that it passed, and it should pass if you try it locally as well), it was the test after that one: test_watertight_workflow_dynamic_interface.
The team is aware of these tests that have been randomly stalling, we aren't sure of what is going on yet.
I set the failed test to re-run, let's see if it hangs again or if it passes. Changes in main branch are set to skip this test, we can merge them here if it fails again


Infer indices

Once a variable c is defined, indices like c[i] should magically create the corresponding variable; these can be sparse, indexed by non-integers, etc.

This will probably require modifying the behaviour of Symbolics.jl, or using our own variable type.


feat: Automatically reset connection when the DNS record changes.

When a connection is configured using a DNS domain name, the connector will poll the DNS TXT record every 30 seconds. If the value of the DNS record changes, the connector will close all connections to the old instance, and direct new connections to the updated instance.
Part of https://github.com/GoogleCloudPlatform/cloud-sql-go-connector/issues/842

This supersedes #844 and #865.

Based on our discussion, I have updated Dialer.cache to use a cache key that identifies an entry either by "project:region:instance" or by "domainName", not the combination "project:region:instance" + "domainName". I also simplified the logic in Dialer.connectionInfoCache() so that it no longer checks if a domain name value is stale before returning existing cache entries.


Add api endpoints

Currently ATLauncher uses webhooks to send messages to Discuss channels. These have low rate limits and constantly have issues.
We also have a need to automate onboarding of new pack developers to give them the role on discord automatically.
Adding in an API endpoint (using Koa is preferred) with a simple api key to allow posting in channels, giving roles, etc.

This also needs an endpoint to send webhook json format to post to a channel

API has been developed and is as expected


Lab 26 resources

Couldn't start the starter SQL warehouse. It requires 8 cores while the quota of each region is 3.

If you're using your own subscription, you may need to increase your regional quota.
If you're using a lab environment provided by a Microsoft Authorized Lab Hoster, reach out to their support team.


Notify serverless-offline when watched files trigger rebuild

This is my first time contributing. Please let me know what you'd like to see in terms of tests, documentation, etc - thanks!
Background

With a default serverless-offline + serverless-esbuild setup, watching for changes does not work
See https://github.com/floydspace/serverless-esbuild/issues/108

Problem

The --reloadHandler solution proposed in the above issue drastically hurts local dev performance on a large project

Proposal

Leverage https://github.com/dherault/serverless-offline/pull/1093 to tell serverless-offline when it needs to clear the cache

Alternatives

If https://github.com/floydspace/serverless-esbuild/issues/158 was built, this may not be necessary
For example with serverless-webpack, which already supports lifecycle hooks, I use a custom plugin to solve this exact same problem:

class OfflineInvalidate {
  constructor(serverless) {
    this.hooks = {
      'after:webpack:compile:watch:compile': () =>
        serverless.pluginManager.spawn('offline:functionsUpdated'),
    };
  }
}
module.exports = OfflineInvalidate;

I'd still prefer this proposed PR, so that watching "just works" with a default setup

Hi could you please provide a simple example for making hot reload work when utilizing serverless-offline + serverless-build? I am unable to get this to work. What should the watch pattern be? I see in examples that the pattern is an array but my IDE complains that the pattern must be a string. What should be done for serverless offline?
I have the following in my serverless.yml file:
`
plugins:

serverless-domain-manager
serverless-esbuild
serverless-newrelic-lambda-layers
serverless-prune-plugin
serverless-offline

custom:
esbuild:
external:
- deasync
- newrelic
watch:
pattern: "src/**/*.(js|ts)"
bundle: true
minify: true
sourcemap: true
`
But when I have my application running by sls offline, when I update anything in my code, the changes don't trigger a rebuild. Thank you so much for your help.

@pslm93 any chance you can link to an example repo? I have a similar configuration, and it's working for me after this PR.
To debug, I think the first step is to determine if the problem is with esbuild, or with serverless-offline. Add keepOutputDirectory: true under esbuild in your serverless.yml so you can see the .esbuild directory. Change a source file, and you should see the JS output update accordingly automatically. If it doesn't update, the problem is with esbuild and your watch config. If it does update, the problem is with serverless-offline.


us-co-delta

delta county
http://www.deltacounty.com/13/GIS-and-Mapping

This has been added and can be closed.


Added Container Progress component

Usage: <ContainerProgress pBar1={20} pBar2={70} pBar3={100} pBar4={20} />

LGTM

Changes Unknown when pulling 2ccee4a5055f99029ca40bb2dde23ed5882bb344 on container-progress-ui into ** on master**.


ugarit: fix build by using chicken-4.x

Ugarit only works with CHICKEN 4, not CHICKEN 5 (which is the version in nixpkgs since 69ef070296e), so use the egg tools from chicken-4 for ugarit and ugarit-manifest-maker.
Motivation for this change
The ugarit and ugarit-manifest-maker packages are broken since they're building with the wrong version of the CHICKEN compiler and libraries.
Things done
Pass the CHICKEN 4 versions of eggDerivation and fetchegg to those two packages explicitly so that they build and install with the right compiler/runtime/dependency sources.
Store size check isn't really applicable since the build was broken before, but here's the after:
/nix/store/v35vaww3312p6i5zgrdmn77hx2xaspsi-chicken-ugarit-2.0    243735720
/nix/store/hh96kdqy99w80j1x0vq62vd8glbkmgi8-chicken-ugarit-manifest-maker-0.1     241374104

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Rebased and simplified slightly, still tests OK. Any thoughts on this?

Just tested this and it fixes the build for release-19.09 and master. I also noticed that while building the sql-de-lite egg it complained about how sqlite is missing. This can be fixed by adding the missing input to sql-de-lite in pkgs/tools/backup/ugarit/eggs.nix

Anyone know of a reason not to merge this?

@GrahamcOfBorg build ugarit


When I tried to install this extension in yii2 it gives error!

Gives following error, let me know what to do?
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package yii2mod/yii2-c3-chart could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Fixed, please try again.

If you get an error again, try to change the following keys in your composer.json:
"minimum-stability": "dev",
"prefer-stable": true


What did happened?

/severity critical

/assign @bufferflies

Changing the memtable of lockcf to 2MB greatly mitigate this problem. Downgrade it to major.

This delete skip happened in lock cf. In dynamic regions, every region store the cf data and compact it, so the frequence of compaction is less than v1. User can downsize the lockcf write-buffer-size to speed up the frequence of the flush and compaction. Here is the test result of modify the write-buffer-size:

We're doing the benchmark on different workloads on the reduced lock-cf size.  If there's a sweet spot size, then this issue can be closed.

It should be greatly mitigated by the new 4MB lock-cf size. Changing it as moderate.

ref #https://github.com/tikv/tikv/pull/15453

close #15132


TS2823 import attributes error when using node16 module

🔎 Search Terms
TS2823 import attributes node16 module
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about 5.6.3 and dev

⏯ Playground Link
https://www.typescriptlang.org/play/?target=99&moduleResolution=99&module=100&ts=5.8.0-dev.20241115#code/JYWwDg9gTgLgBGAhgYwNaIOYFMBSBnCAOzgDMoIQ4ByAOgHok1MsaArAwquAd2BgAs4AbzgwAnmCwAuauyJcAvkA
💻 Code
import packageJson from './package.json' with { type: 'json' }

🙁 Actual behavior
We get the following error:
TS2823: Import attributes are only supported when the --module option is set to esnext, nodenext, or preserve

🙂 Expected behavior
The docs state the following:

nodenext: Currently identical to node16, but will be a moving target reflecting the latest Node.js versions as Node.js’s module system evolves.

Either the syntax should be supported on node16 or the documentation needs to be updated.
Additional information about the issue
No response

This is working as intended, hence the documentation mentions:

will be a moving target reflecting the latest Node.js versions as Node.js’s module system evolves.

One could bike-shed and argument it should be reworded from "will be" to "is".

This is working as intended, hence the documentation mentions:

will be a moving target reflecting the latest Node.js versions as Node.js’s module system evolves.

One could bike-shed and argument it should be reworded from "will be" to "is".

But the docs state "Currently identical to node16", maybe remove that part to reflect the current state? I think this is more clear:

nodenext: A moving target reflecting the latest Node.js versions as Node.js’s module system evolves.

Import attributes only work on node 18 and above, but typescript has no node18 target unfortunately. So I think the best course of action would be to add such a target and alias nodenext to it.
nodenext should always be an alias to the latest node target, imho. Not have special behaviour as it does now.

https://github.com/microsoft/TypeScript/issues/60707 , https://github.com/microsoft/TypeScript/issues/60705


Update connect-server-to-github.md

as changes suggested in #5269 from amplication repository

@MoFoGo please review

@EugeneTseitlin please review

@Chirag8023  please share your email with me on discord.

ok ! sent.


Make dependencies optional?

I'm hoping to use the Zarr store without installing anything else, such as napari. Would you be willing to make most of the dependencies optional?

yes! feel free to make a pr


Update nord.reg

Comment is put after the line containing version, in order to fix "Not a registry script" error
(because the first line shall be Windows Registry Editor Version X)

Can confirm this works.


mount: permission denied (are you root?)

while trying to run cmd   docker run -it --name qemu multiarch/qemu-user-static
getting  an error
mount: permission denied (are you root?)
mount: permission denied (are you root?)
used su cmd to become root user and then used sudo too but still getting the same error

I have the same problem when running rootless docker. Any idea how to fix it?


PDF JIS Z 8301: static or dynamic text on the cover page

Source: https://github.com/metanorma/metanorma-jis/issues/9
On the cover page there are texts:

(translation: Japan Industrial Standards Survey Council deliberations)

(translation: (Issued by the Japan Standards Association))
@ronaldtse is it static text or should be set in the document attributes?

I've checked another documents in https://github.com/metanorma/mn-samples-jis/tree/main/reference-docs.
It's dynamic text. I'll analyze all cover pages.

These 3 texts should be encoded in document attributes.

The cover page text encoded in these attributes:
:publishing-organization-abbr: JSA
:publishing-organization-name-ja: 日本規格協会
:publishing-organization-name-en: Japanese Standards Association
:investigation-organization-name-ja: 日本産業標準調査会
:investigation-organization-name-en: Japanese Industrial Standards Committee
:investigation-committee-name: 日本産業標準調査会 標準第一部会

but looks like metanorma-jis doesn't support them yet.
On hold.

Just implemented, but I have changed the attribute names to make them consistent with Metanorma.

Just implemented, but I have changed the attribute names to make them consistent with Metanorma.

So what are the attribute names now? Thanks.

Because we need to update all the sample documents. Ping @opoudjis @metanorma/editors

@opoudjis informs that:

I've renamed them "investigative" in the implementation

So they should now be:
:publishing-organization-abbr: JSA
:publishing-organization-name-ja: 日本規格協会
:publishing-organization-name-en: Japanese Standards Association
:investigative-organization-name-ja: 日本産業標準調査会
:investigative-organization-name-en: Japanese Industrial Standards Committee
:investigative-committee-name: 日本産業標準調査会 標準第一部会

From https://github.com/metanorma/metanorma-jis/issues/103#issuecomment-1679096421:

This needs isodoc and metanorma-iso
Input:
= A
:publisher-abbr: JSA
:publisher-ja: 日本規格協会
:publisher-en: Japanese Standards Association
:investigation-organization-ja: 日本産業標準調査会
:investigation-organization-en: Japanese Industrial Standards Committee
:investigation-committee: 日本産業標準調査会 標準第一部会
:docnumber: 1

Output:
<bibdata type="standard">
	<docidentifier type="JIS">1:2023</docidentifier>
	<docnumber>1</docnumber>
	<contributor>
		<role type="author"/>
		<organization>
			<name>
				<variant language="ja">日本規格協会</variant>
				<variant language="en">Japanese Standards Association</variant>
			</name>
			<abbreviation>JSA</abbreviation>
		</organization>
	</contributor>
	<contributor>
		<role type="publisher"/>
		<organization>
			<name>
				<variant language="ja">日本規格協会</variant>
				<variant language="en">Japanese Standards Association</variant>
			</name>
			<abbreviation>JSA</abbreviation>
		</organization>
	</contributor>
	<contributor>
		<role type="authorizer">
			<description>Investigative organization</description>
		</role>
		<organization>
			<name>
				<variant language="ja">日本産業標準調査会</variant>
				<variant language="en">Japanese Industrial Standards Committee</variant>
			</name>
		</organization>
	</contributor>
	<contributor>
		<role type="authorizer">
			<description>Investigative committee</description>
		</role>
		<organization>
			<name>日本産業標準調査会 標準第一部会</name>
		</organization>
	</contributor>

FYI @Intelligent2013 : <variant> is the Metanorma way of differentiating the same string content in different languages, but you haven't seen it until now, because I normalise it in Presentation XML to "variant1/variant2". I've just stopped doing that normalisation within bibdata, but I'm pretty sure this is the only place I am using it in bibdata. (I did not use it for titles, because I devised variant later.)

Tasks for me:

[ ] update document,adoc for JIS Z 8301
[ ] update JIS XSLT for variant titles

@ronaldtse I'm confused. What is the option correct?

So they should now be:
:publishing-organization-abbr: JSA
:publishing-organization-name-ja: 日本規格協会
:publishing-organization-name-en: Japanese Standards Association
:investigative-organization-name-ja: 日本産業標準調査会
:investigative-organization-name-en: Japanese Industrial Standards Committee
:investigative-committee-name: 日本産業標準調査会 標準第一部会

From https://github.com/metanorma/metanorma-jis/issues/103#issuecomment-1679096421:

:publisher-abbr: JSA
:publisher-ja: 日本規格協会
:publisher-en: Japanese Standards Association
:investigation-organization-ja: 日本産業標準調査会
:investigation-organization-en: Japanese Industrial Standards Committee
:investigation-committee: 日本産業標準調査会 標準第一部会

@opoudjis please answer @Intelligent2013 , thanks!

The currently working variant is 2nd:
:publisher-abbr: JSA
:publisher-ja: 日本規格協会
:publisher-en: Japanese Standards Association
:investigation-organization-ja: 日本産業標準調査会
:investigation-organization-en: Japanese Industrial Standards Committee
:investigation-committee: 日本産業標準調査会 標準第一部会

@Intelligent2013 I believe @opoudjis has already changed investigation to investigative.
@opoudjis can you please confirm?

Yes, I changed it because I saw that he instructed you to use investigative: https://github.com/metanorma/metanorma-jis/pull/112/files
I just hadn't gotten around to merging the PR.

@opoudjis  thank you!
@ronaldtse do you know why these fields were introduced into document.adoc ?
:investigation-committee-representative-name: 酒井 信介
:investigation-committee-representative-role: 部会長

I've found these data on the inner cover page only:

But it encoded in the 00-preface.adoc in the contributors table as text:
[.preface,type=contributors]
== {blank}

.日本産業標準調査会標準第一部会 構成表
[cols="25a,32a,105a",options="header,unnumbered"]
|===
| | 氏名 | 所属

| (部会長) | span:surname[酒井] span:givenname[信介] | 横浜国立大学
...

Can I remove it from document.adoc?

[ ] update document.adoc for JIS Z 8301

Will be done in https://github.com/metanorma/mn-samples-jis/issues/12.


Added Redis as a state store backend

Description
Added Redis backend to store Luigi's tasks state
Motivation and Context
We run our infrastructure inside containers hence are required to have centralized state store location
Have you tested this? If so, how?
I ran my jobs with this code and it works for me. If community finds this PR useful I will add test.

This seems like a reasonable contribution. I'm not sure what the adoption rate would be. But i'm not immediately opposed to such a configurable Redis state store.

Closing PR because there is no reason to store dumped state, because it could be obsolete or corrupted (due to pickle)


merge from arlac77/template-github,arlac77/template-kronos-module

.github/workflows/ci.yml

chore(github): merge from template .github/workflows/ci.yml

Codecov Report

Merging #1018 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1018   +/-   ##
=======================================
  Coverage   89.61%   89.61%
=======================================
  Files           7        7
  Lines         684      684
  Branches       73       73
=======================================
  Hits          613      613
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50fee70...3038e3a. Read the comment docs.


EQC test should cover partial binds.

EQC should cover the partial bind scenario.

"Partial binds" are now just processes; no longer required.


Missing AppConfig.default_auto_field definition

When using django-defender with Django 3.2, I am seeing the following warning being thrown:
$ ./manage.py check
System check identified some issues:

WARNINGS:
defender.AccessAttempt: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
	HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
...

A possible work around as mentioned in the warning is to define the DEFAULT_AUTO_FIELD setting.
Since this is a library for Django, it would be nice if it does not throw warnings when used with a supported Django version. The fix would be, as mentioned in the warning, to create an AppConfig and set the default_auto_field attribute.
This is the related section in the release notes for Django 3.2: https://docs.djangoproject.com/en/3.2/releases/3.2/#customizing-type-of-auto-created-primary-keys

@tbrlpld Thanks for the heads up. Feel free to submit a PR with your proposed changes and we can review. If they look good and all tests pass, we can merge and push out a new release. Thanks!


1.0.0?

This module looks really stable.  Can it be bumped to 1.0.0?

@jonschlinkert I'm noticing that this needs your updaters run against it. Can you or @doowb run them and I can finish up the release?

done. I just pushed up

looks like this is done!

Just needs to be published once the CI finishes.  I'll post once I've done that.

I just made sure you're added on npm if you want to go ahead and publish

This has been published.


Update BankAccount: Bad request. One or several required parameters are missing or incorrect.

Hello,
I get an error when i tried to update a user bank account, here is the full updated BankAccount object:

here is the error i got in postman:
Error: Bad request. One or several required parameters are missing or incorrect.
An incorrect resource ID also raises this kind of error

here is the code which i wrote in PHP:
$userId = "85498898";
$bankAccount // is set as a bank account object with the precedent image parameters
$this->api->Users->UpdateBankAccount($userId, $bankAccount)

thanks.

Hi @sohaieb
In this case the method is calling the 'deactivate' endpoint
https://docs.mangopay.com/endpoints/v2.01/bank-accounts#e306_deactivate-a-bank-account
We will update the language so it's clearer.
As a reminder, bank accounts cannot be changed, they can only be deactivate.
The change a bank account you would need to deactivated the current and create a new one
max

Hi @sohaieb
In this case the method is calling the 'deactivate' endpoint
https://docs.mangopay.com/endpoints/v2.01/bank-accounts#e306_deactivate-a-bank-account
We will update the language so it's clearer.
As a reminder, bank accounts cannot be changed, they can only be deactivate.
The change a bank account you would need to deactivated the current and create a new one
max

thank you a lot for your answer ,
it would be nice if you mention this point in the API documentation.
thanks.


Bypass request

Link
https://shrinkme.info/1epaq
Version
Manifest-v2
What browser(s) are you using?
Chrome browsers (includes brave, edge, opera, etc)
What platform are you using?
Computer (Windows, Linux, MacOS)
(Optional) Anything else?
No response

Dupe #1226


Promote v3.10 as latest

Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 59fc6eee5ed23435886f95c09e205d8bc2a10662
https://deploy-preview-2949--calico.netlify.com

Deploy preview for calico ready!
Built with commit 1f4d378e9f63446749e7546067efda95ace9f4a6
https://deploy-preview-2949--calico.netlify.com

Deploy preview for calico ready!
Built with commit b0b4258360b4089fb05b1da48505b1a1dec98f62
https://deploy-preview-2949--calico.netlify.com


Got empty object in evaluate to invoke window.performance.

Tell us about your environment:

Puppeteer version:1.3.0
Platform / OS version:Mac OS X 10.12.6
URLs (if applicable):
Node.js version:9.8.0

What steps will reproduce the problem?
            const puppeteer = require('puppeteer')

            const browser = await puppeteer.launch()
            const page = await browser.newPage()
            await page.setViewport({
                width: screenWidth,
                height: screenHeight
            })
            await page.goto(url)
            await page._client.send('Performance.enable');

            const performanceTiming = await page.evaluate(() => window.performance);
            console.log(performanceTiming)

What is the expected result?
the performance object.
What happens instead?
got empty object {}

This seems to work:
await page.evaluate(() => JSON.stringify(window.performance));

Thanks @vsemozhetbyt
It seems to be cause babel-runtime, it's work for me like this:
await page.evaluate(() => window.JSON.stringify(window.performance));


Checkboxs and TextFields

-Added Checkboxs and TextFields.
-Added A OnKeyPressed and a OnKeyReleased function to widget, for key inout. also added necessary functions to Panel.
-Added two function to Input:
-IsLetterFunction: Checks to see if a certain key code is a letter or symbol.
-GetChar: Return a character based on key code
-Added a few extra key code to Input
-Added a GetClipboardContent and a SetClipboatrdContent function in Window and Win32Window
-Added a DrawTexture function, in Renderer2D and BatchRenderer2D, that draws a textured quad

Wont this be a problem with different style of keyboards?
On a azerty keyboard the shiftkeys aren't at the same position as those on a qwerty.

Yes it will be but I couldn't find another way to do it, I am not that good with c++. But another, not that good way of doing it, could be to have a different shift key map for each different type of keyboard.


ValueError encountered

https://dpaste.de/t0kx
More info available if needed.

@antlong Can you provide your code, please? Can you also tell us what version of Requests you're using, and where you got it from?

https://dpaste.de/zUtN
Requests 1.2.3 from pip.
Note: The urls in the file contain special characters.

So Requests 1.2.3 is ancient: I'm almost certain that we fixed this in the last two years. Please upgrade your Requests. =)

Ahhhh forgot i was on an older centos dev box running this. Thanks!


所以到底什么时候放出来？

Thank you all for your interest in MT-Bench-101! We are currently organizing the code and data. In the meantime, you can contact<EMAIL_ADDRESS>to obtain the beta version, which can be run on an OpenCompass-based code branch. Thank you!


[Bug] Fix the buttons for small screens #235

Issue that this pull request solves
button font size
Closes: # (235)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

Screenshots

Other information
Any other information that is important to this pull request

@mohit355 check

@mohit355 check


[6.0] Ignore precise line number in unit test expectation

Explanation: A unit test failed under certain circumstances because it tested for a precise line in an expected error message.
Scope: One unit test change
Issue: rdar://126504994
Risk: Low.
Testing: Existing tests pass.
Reviewer: @QuietMisdreavus
Original PR: https://github.com/apple/swift-docc/pull/887

@swift-ci please test


Freshservice: New app - Initial commit

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[ ] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[ ] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[x] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[x] If you are exposing any endpoints using a REST handler,
please document them in the manual_readme_content.md.
[x] If this is a new connector or you are adding new actions

[x] Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Thanks for contributing!

Hello @dan3hr,
We have made some changes in the Python code in this PR (mostly linting) without changing the functionality. Still, could you please test the code from your end and let us know?
Optionally, we would suggest clearing the commented code and reducing code repetition.
Thanks.

Hi @dan3hr, Can you please test the functionality and let us know your feedback?


chore: lets cleanup secrets created as part of the GSM BDD test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
88c91a01df58ed57ff4a75e7bb977624fa3bbb4a
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test vault

@rawlingsj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
88c91a01df58ed57ff4a75e7bb977624fa3bbb4a
link
/test vault

gsm
88c91a01df58ed57ff4a75e7bb977624fa3bbb4a
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gsm


fix formatting of summary in cli workflow

Affected Packages
pkg:cli
Problem
The summarization of a changeset in the CLI is a nice idea, but right now the formatting seems broken:

Proposed solution

I think if you open the editor to write the changeset (instead of doing it directly in the terminal) the summary step should be eliminated. Because you've already just seen the entire changeset file and have saved and closed it.

The formatting should be fixed and simplified. Potentially something like this:

🦋  === Summary of changeset ===
🦋  minor: slate, slate-react
🦋  patch: slate-history
🦋
🦋  Note: all dependents of these packages that are incompatible with the new version
🦋  will be patch bumped when this changeset is applied.
🦋
🦋  Is this your desired changeset? (Y/n) · true

Which includes things like:

Reduce noise around the "note", using just simply red+bold on the word "Note:" will get the job done, and right now it's so noisey that it makes other pieces hard to read.
Reduce noise on major/minor/patch. Again color will get the job done. (And the formatting I've used mimics how they are formatted in the questions already, which is good.)
Collapse packages onto a single line since the majority case is have either all in one type (and a long list), or just a few packages changing, so no need to make it verbose.
Collapse header into a single line, since it was unnecessary to have two before.

I think if you open the editor to write the changeset (instead of doing it directly in the terminal) the summary step should be eliminated. Because you've already just seen the entire changeset file and have saved and closed it.

https://github.com/atlassian/changesets/pull/562

Reduce noise around the "note", using just simply red+bold on the word "Note:" will get the job done, and right now it's so noisey that it makes other pieces hard to read.

I've looked into why this box was wrongly formatted - we are using boxen@^1 which doesn't handle text-wrapping. This has been implemented though so I've wanted to bump this dependency first, but I've been stopped by https://github.com/sindresorhus/boxen/pull/52 . Even if that would get resolved there is still no way (from what I can tell) to "offset" the box by the length of our prefix: https://github.com/sindresorhus/boxen/issues/53 . So either way - I think we should drop this dependency. I also agree with you that this is somewhat noisy.

Reduce noise on major/minor/patch. Again color will get the job done. (And the formatting I've used mimics how they are formatted in the questions already, which is good.)

As to colors - do you just propose to color major/minor/patch "labels"?
Not sure if I understand the latter part - I mean, not sure exactly how the proposed formatting mimics how packages are formatted in questions. A visual would be helpful for this.

Collapse packages onto a single line since the majority case is have either all in one type (and a long list), or just a few packages changing, so no need to make it verbose.

Agreed, not completely sure how we should treat major CLI output revamps in relation to semver. I'm inclined to say that we can be liberal about this though.

Collapse header into a single line, since it was unnecessary to have two before.

+1 on merging "Summary" and "Realising..." headers

This all sounds good to me.

As to colors - do you just propose to color major/minor/patch "labels"?
Not sure if I understand the latter part - I mean, not sure exactly how the proposed formatting mimics how packages are formatted in questions. A visual would be helpful for this.

@Andarist I just meant that currently the two places that display the "minor" concept in that screenshot are using two different types of formatting. (1) is using lowercase, color, bold. (2) is using uppercase, square brackets, non-bold, color. My suggestion is to unify on (1).


Question about small angle coverage?

Thanks for your excellent work!!! I'm encounting a problem with the reconstruction. Hope your could give me some advice.
My dataset is a sparse input with small viewing angle coverage, with is shown below:

Using your project, the point cloud result:

I noticed that the buildings in the centre do not have matching 3D points, can this be improved by modifying some parameters?
Any advice would be of great help to me!

Hi, for automatic driving scenes, the camera is forward-moving. The default COLMAP parameter setting may not be suitable for this scenario, because COLMAP has parameters to control minimal triangulation angle for stable reconstruction, where points on the building in the image center cannot satisfy these criteria when the camera is forward moving.

You can try to relax these parameters that control the triangulation angle.

Hi, for automatic driving scenes, the camera is forward-moving. The default COLMAP parameter setting may not be suitable for this scenario, because COLMAP has parameters to control minimal triangulation angle for stable reconstruction, where points on the building in the image center cannot satisfy these criteria when the camera is forward moving.  You can try to relax these parameters that control the triangulation angle.

Thanks! It works well!


Update montage.py and _ieeg_locate_gui.py

1、The mne.channels.read_dig_dat() function does not support the dat file of neuroscan 64 channels. I have solved the problem.  The modified dat file can be downloaded here：https://pan.baidu.com/s/1HMupnlm3EiAOKljHcylaog  password：v1bj
2、Fixed bugs in _ieeg_locate_gui.py and added shaft method to locate the contacts.
@alexrockhill Can you help me finish this pull request？

I think all that's missing now is a unit test

@leosunpsy do you need guidance to add a unit test?

@alexrockhill Can you help me finish this pull request？

@ hoechenberger @larsoner  I have uploaded the dat file.

@alexrockhill can you look? It seems like most of the changes here are related to the GUI. The montage changes are smaller and look okay.
@hoechenberger can you look into the unit test issue?

In general, I like the ideas I see about making the GUI design cleaner but I'll have to run things locally to review this better, and I really like renaming cursor and cursor2 to cursorv and cursorh and cleaning up variable names.
But I'm really not sure that the tip and entry functionality is necessary. Is the idea to save 6 clicks if there are 8 contacts on an electrode for instance? I think since this method requires such precision, I would like to channel users to doing all those clicks by hand, I don't think it really takes much if any more time. I think a more automated method would be great to implement in the future but I would rather put a lot of time and effort into it and really speed things up localization-wise. I'm open to considering it but I think the tradeoff is that it's more functionality that takes explaining in the GUI which I would really like to make as clean and simple as possible so that it's not too hard to maintain and doesn't need a lot of extra explanation.
Also, it looks like you need to run make flake locally to fix pep8 changes.

@alexrockhill  Hi Alex. In my practice, CT images sometimes have the insufficient resolution or different contacts are connected together, in which case manual marking contact one by one is easy to introduce more errors. Of course, it's up to you, I just gave the user another way to do it.

That is an important point about dealing with bridged electrodes in the CT. My approach is to rely heavily on the 3D viewer to make sure that the contacts are in a line but not to go exclusively off of that but also to consider the slice images because the contacts may not be exactly in a line. I think it is a tradeoff between errors from individual clicks of the contacts and errors from misaligning the tip and the origin, and I think the individual clicks will be less biased toward any one direction (i.e. uniform random distribution around the ground truth) compared to the interpolation which is more likely to be biased in one direction (i.e. you picked slightly anteriorly on the tip and the origin so all the contacts will be biased in that direction. I think in general you do want to give users more options but you are implicitly recommending that the user use the option when you add it to MNE, and you wouldn't want to recommend something that is suboptimal. Let me give it a try on some of my data and have a more informed opinion. The idea behind including the sliders for the minimum and maximum of the CT is to be able to change the bounds of the image in order to better visualize fused contacts so you might want to try that. I don't think this is a bad idea, I think it's a nice feature if used properly, it's just that my long-term ideal for this GUI would be to have a feature that uses a more precise algorithm to find lines of contacts that form electrodes without any manual intervention (i.e. seeding) which would should be the most accurate. I think this could be added until that is ready but again, I think it's a balance between complexity of instructions for the user and whether it is worth it to explain such nuance as this paragraph. My inclination is to stick with recommending the simpler approach but again let me give it a try and have a more informed opinion.

Thinking about it more, I think the other issue is the snap to center feature; if you interpolate, there is no way to determine which contacts are snapped to the center or if none of them are. This is intricately linked later in the workflow as Dipy currently requires an image to apply the symmetric diffeomorphic registration (SDR) to warp to a template. Thus, the way we do this currently is to take all the voxels that decrease monotonically from the peak and are within some threshold of the peak. This works really well with the snap to center feature which I have on ~95% of the time. The other 5% is in this case of the bridged electrode contacts where I am usually able to use it on some of the contacts but not all of them. When the warp is done, the ones that were not snapped to the center are probably a bit under-represented spatially because other contacts overlap with them but those ambiguous voxels are handled by the algorithm by which contact they are closer to. Once Dipy allows for warping individual points, this will be less of an issue but I think it's important to assess whether snap to center works for each contact on case-by-case basis to determine the best positions and whether they will work well for the warp to a template.

@alexrockhill Hi Alex, because I have been busy recently, I have not had time to check the specific calculation process of warp_Montage_volume function until now, so I can understand your concerns above.  I have a question, I personally think the position after manual locating is the most accurate.  Why do we need to find the location beyond a certain threshold as the final location through the center-mass algorithm?  In addition, I found an error in line 1929 of the warp_montage_volume function source code, which makes the center-mass algorithm you mentioned above not work.

@leosunpsy, I fixed the channel sizing in https://github.com/mne-tools/mne-python/pull/10155. I think that the main thing from this PR. Sorry to do it instead of you but it was part of the review for the paper on this software https://github.com/openjournals/joss-reviews/issues/3897.
I think you might get this PR merged right away if you remove the GUI stuff and just do the montage changes. I'm happy to iterate on how to make the GUI better on https://mne.discourse.group/ but I think we should do that first before jumping into coding changes as far as the automation of contact location. Thanks for doing this, I really appreciate the help making the GUI better!

@agramfort I made a full request here.

@leosunpsy, I fixed the channel list sizing in #10155. I think that's the main thing from this PR for the GUI besides the automation. Sorry to do it instead of you but it was part of the review for the paper on this software openjournals/joss-reviews#3897.
I think you might get this PR merged right away if you remove the GUI stuff and just do the montage changes. I'm happy to iterate on how to make the GUI better on https://mne.discourse.group/ but I think we should do that first before jumping into coding changes as far as the automation of contact location. Thanks for doing this, I really appreciate the help making the GUI better!

OK

@leosunpsy you cannot remove such a file. You need to revert the changes to this file but not remove it from the repo.
you can use git checkout to recover this file.

@leosunpsy you cannot remove such a file. You need to revert the changes to this file but not remove it from the repo.
you can use git checkout to recover this file.

@agramfort Hi, thank you very much for your contribution to the development of MNE.  I wanted to contribute to making MNE better, but the process was frustrating.  The main reason is that I am not familiar with github's operation.  I wonder if you can help me recover it ?

it's hard for me to help at this point. What I can suggest is that you close this pull request and open a new one.
But before this make sure you create a new branch first. Here you opened a PR from main branch which should be really avoided.


False-positive 1-time payment success msg

Steps to reproduce
Wallet setup

Successfully created a USD sender test wallet account in rafiki.money.
Successfully connected the wallet address to the extension.

Visited websites

Visited radu.sh and the WM icon was green

Successfully made a one-time payment to radu.sh (so far, so good :smiley: )

Visited google.com (a non-WMized website) and the WM icon remained red

I opened the WM ext, entered an amount, and attempted to make a 1-time payment to google.com.

The ext said "This website is not monetized."   (still going well :smiley: )

While I still had google.com open, with the WM ext open, and a value on the page for sending a 1-time payment

I used a keyboard shortcut to open the browser dev tools (note: the Web browser window remained open on the side, with the extension pop-up also still open) and I clicked around in the dev tools window

I then moved the mouse back to the Web browser, and clicked "Send Money" on the extension

The extension showed the message "payment successful"   (this can't be 👎🏾 )

Expected result
No payments can happen, and no payment success messages can be valid when attempting to pay a non-monetized website with the extension.
Actual result
The extension indicated that a one-time payment to google.com had succeeded.
Screenshots or videos
Link to video: on loom
Was able to replicate behaviour on dev.to:

Additional context
We also noticed that there are instances where a website has multiple valid wallet addresses, and a one-time payment only succeeds in that some of the wallet addresses receive payment, and others do not (for example, if the sending wallet exceeds the authorized amount after successfully making 1 of 2 payments).
No response
Operating system
Windows
Operating system version
10
Browsers
Chrome
Browser version
125.0.6422.78
Extension version
alpha 1 (the ext shows v1.0.1)

To do: @tselit to log a separate ticket (using the same video attached to this ticket, re. concatenated text on the "Send now" button.
So this is ready for review.

Closed by #333.


Added params to Get Subtasks

Added documentation of a couple of missing parameters in Get Subtasks

specs?

Working on them. What font do you want them to be written with?


Catch IllegalArgumentException when external storage directory not exists

Thank you for making a pull request ! Just a gentle reminder :)

If the PR is offering a feature please make the request to our "Feature Branch" 0.11.0
Bug fix request to "Bug Fix Branch" 0.10.9
Correct README.md can directly to master

FYI
react-native-fetch-blob has a new maintained location. Check out the README.
Please consider submitting your PR there, this repository is unmaintained.


[Feature Request] Option to run instead of walk

Describe the feature you'd like to see added
I know that there is option to toggle run but since you are running most of the time I think it would be easier if controls are swapped: you run by "W" and walk by holding "SHIFT" key like in RE6.

I actually never thought about this before,
but it definitely makes sense.


remove link to itself

This link probably shouldn't be list in the page itself

@He-Pin are you happy to have this merged?


How to execute then block after async when block

test('Get Container failure with invalid container id', ({
given,
when,
then,
}) => {
let error;
given('Container does not exist with given container id', () => {
mockContainersService.getContainerById = jest
.fn()
.mockRejectedValue(new NotFoundException());
});
when('I call get container by id method', () => {
controller
.getContainerById(containersIdentifierDTO, mockRequest)
.catch((err) => {
error = err;
});
});
then('I should be getting container not found with given id', () => {
expect(error.message).toBe('NOT FOUND');
});
});
//==================================
I want to execute then block after result of when block
in above example i am testing error scenario in jest. i am mocking method in given block and and calling in when block and its result is stored in error variable which i am validating in then block but the issue is that then block is getting executed before when block async method executes.

@bencompton

I think the simplest way is to return the Promise in the when method. The test runner will await this before executing the next step, in this case the then method.

@robinelvin Thanks a lot its working
when('I call get container by id method', async () => {
return await controller
.getContainerById(containersIdentifierDTO, mockRequest)
.catch((err) => {
error = err;
});
});

when('I call get container by id method', async () => {       return await controller         .getContainerById(containersIdentifierDTO, mockRequest)         .catch((err) => {           error = err;         });     });

@robinelvin Thanks a lot its working
when('I call get container by id method', async () => { return await controller .getContainerById(containersIdentifierDTO, mockRequest) .catch((err) => { error = err; }); });

Glad you got it sorted. I'm surprised this works as I thought promise rejections caused the test step to fail but I haven't checked this.

Check solution above


make clean now deletes build/ (#262)

https://github.com/GoogleCloudPlatform/open-match/issues/262

/gcbrun


Cannot read property 'FacebookAuthProvider' of undefined - 2.0.0-beta.5

Hello,
Since I have updated my angularfire2 to the 2.0.0-beta.5 version, I have got an error about the FacebookAuthProvider.
I do not use this provider and it seems that the problem come form my loaded angularfire2.umd.js file.
Do you guys encounter the same issue ?

@mquentin I don't get this error, infact I am able to get FacebookAuthProvider.
Snippet from my code:
constructor(public af: AngularFire, public auth: FirebaseAuth) {
this.authState = auth.getAuth();
auth.subscribe((state: FirebaseAuthState) => {
this.authState = state;
console.log("Display Name "+this.authState.facebook.displayName);
console.log("photo URL "+this.authState.facebook.photoURL);
});
}

Snippet of my package.json
"dependencies": {
"@angular/common": "2.0.0",
"@angular/compiler": "2.0.0",
"@angular/core": "2.0.0",
"@angular/forms": "2.0.0",
"@angular/http": "2.0.0",
"@angular/platform-browser": "2.0.0",
"@angular/platform-browser-dynamic": "2.0.0",
"@angular/router": "3.0.0",
"angularfire2": "^2.0.0-beta.5",
"core-js": "^2.4.1",
"firebase": "^3.4.0",
"rxjs": "5.0.0-beta.12",
"ts-helpers": "^1.1.1",
"zone.js": "^0.6.23"
},

Hello @mukesh51, my package.json sets up theses dependencies (I will repeat myself, but this issues didn't occur when I was using 2.0.0-beta.4) :
"dependencies": {
"angularfire2": "^2.0.0-beta.5",
"body-parser": "~1.13.2",
"cookie-parser": "~1.3.5",
"debug": "^2.2.0",
"express": "^4.13.4",
"express-jwt": "^3.3.0",
"firebase": "^3.4.0",
"forever": "^0.15.2",
"jsonwebtoken": "^5.7.0",
"serve-favicon": "~2.3.0",
"typescript": "^2.0.2",
"typings": "^1.3.2"
},
"devDependencies": {
"@angular/common": "^2.0.0",
"@angular/compiler": "^2.0.0",
"@angular/core": "^2.0.0",
"@angular/forms": "^2.0.0",
"@angular/http": "^2.0.0",
"@angular/platform-browser": "^2.0.0",
"@angular/platform-browser-dynamic": "^2.0.0",
"@angular/router": "3.0.0",
"@angular/upgrade": "2.0.0",
"angular2-in-memory-web-api": "0.0.20",
"concurrently": "^2.2.0",
"core-js": "^2.4.1",
"nodemon": "^1.9.1",
"reflect-metadata": "^0.1.4",
"rxjs": "^5.0.0-beta.12",
"systemjs": "^0.19.27",
"systemjs-builder": "^0.15.26",
"yargs": "^4.8.1",
"traceur": "0.0.96",
"zone.js": "^0.6.23"
}
So far, I do not get what could be wrong...

Do you want to share your code or may be plnkr.

Hello mukesh51, I tried to create a plunker but it was definitely hard to set up the same conf. Fortunately, I fixed the issue by forcing the version of firebase to 3.4.0.
From
"firebase": "^3.4.0",
To
"firebase": "3.4.0"

Hi
I'm still getting this, even when trying with @mquentin 's solution.
Regards

@Znow Can you provide a repro? A github repo or a plnkr would be excellent.

@davideast - https://github.com/Znow/ZnowBlog - based on angular2-webpack, and then added stuff for angularfire2.
Thanks

I'm also getting this on the plunker from the angularfire2 readme:
http://plnkr.co/edit/7uJzav4tj2MuwT7b7fiX?p=preview

Yep, that's the official AngularFire2 plunker template. There seems to be an incompatibility between Firebase 3.4.1 and AngularFire2 2.0.0-beta.5. Changing the Firebase version to a strict 3.4.0<EMAIL_ADDRESS>in systemjs.config.js on that plunker) is a workaround until they fix it.

@Auxilinaut - Angular2-webpack isn't using systemjs, as I see.
Regards

I found the cause of this issue. angularfire2.umd.js line 340 "var _a = firebase.auth;" causes this issue. I updated "var _a = firebase.firebase.auth;", then it is working. "firebase" doesn't have "auth".

I have the same problem. And if I do what @mcchae7 suggests I receive this error:

zone.js:1382 GET http://localhost:8000/traceur 404 (Not Found).

repro:
https://github.com/Judahh/judahh

Hello,
I encountered the same error (Cannot read property 'FacebookAuthProvider' of undefined) using the 2.0.0-beta.6.
As mentioned by @mcchae7, in angularFire2.umd.js, at line 5, the retreived firebase object does not seems to be the good one (or Am I doing something wrong?)
The one actually retreived owns the following properties:

__awaiter
__decorate
__extends
__metadata
__param
firebase

If, at the beginning of this function, I added the following instruction and it worked.
firebase = firebase.firebase;
I first thought that changes related to the issue #525 could be somehow related but as they are tagged as 2.0.0-beta.6 and that @mquentin encountered the problem in 2.0.0-beta.5, I am not so sure anymore.
My package.json file looks like this:
{
  "name": "angular-quickstart",
  "version": "1.0.0",
  "scripts": {
    "start": "tsc && concurrently \"tsc -w\" \"lite-server\" ",
    "lite": "lite-server",
    "tsc": "tsc",
    "tsc:w": "tsc -w"
  },
  "licenses": [
    {
      "type": "MIT",
      "url": "https://github.com/angular/angular.io/blob/master/LICENSE"
    }
  ],
  "dependencies": {
    "@angular/common": "~2.2.0",
    "@angular/compiler": "~2.2.0",
    "@angular/core": "~2.2.0",
    "@angular/forms": "~2.2.0",
    "@angular/http": "~2.2.0",
    "@angular/material": "^2.0.0-alpha.10",
    "@angular/platform-browser": "~2.2.0",
    "@angular/platform-browser-dynamic": "~2.2.0",
    "@angular/router": "~3.2.0",
    "@angular/upgrade": "~2.2.0",
    "angular-in-memory-web-api": "~0.1.15",
    "angularfire2": "^2.0.0-beta.6",
    "core-js": "^2.4.1",
    "firebase": "^3.6.1",
    "reflect-metadata": "^0.1.8",
    "rxjs": "5.0.0-beta.12",
    "systemjs": "0.19.39",
    "zone.js": "^0.6.25"
  },
  "devDependencies": {
    "@types/core-js": "^0.9.34",
    "@types/node": "^6.0.45",
    "@types/jasmine": "^2.5.36",
    "concurrently": "^3.0.0",
    "lite-server": "^2.2.2",
    "typescript": "^2.0.3"
  }
}

My systemjs.config.js file looks like this:
(function (global) {
  System.config({
    paths: {
      'npm:': 'node_modules/'
    },
    map: {
      app: 'app',
      // angular bundles
      ...
      'firebase':'npm:firebase/firebase.js',
      'angularfire2': 'npm:angularfire2',
    },
    packages: {
      app: {
        main: './main.js',
        defaultExtension: 'js'
      },
      angularfire2: {
        main: 'bundles/angularFire2.umd.js',
        defaultExtension: 'js'
      }
      ...
    }
  });
})(this);

and My app.module.ts looks like this
import { NgModule } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import { MaterialModule } from '@angular/material';

import { AngularFireModule } from 'angularfire2';

import { AppComponent } from './app.component';
import { EventsComponent } from './events.component';

// Must export the config
export const firebaseConfig = {
    apiKey: "<my-api-key>",
    authDomain: "<my-project-name>.firebaseapp.com",
    databaseURL: "https://<my-project-name>.firebaseio.com",
    storageBucket: "<my-project-name>.appspot.com",
};

@NgModule({
    imports: [
        BrowserModule,
        AngularFireModule.initializeApp(firebaseConfig),
        ...
    ],
    declarations: [
        AppComponent,
        ...
    ],
    bootstrap: [AppComponent]
})
export class AppModule { }

Concerning @Judahh issue, have a look here
I hope this will help,
Have a good day,

I got the same issue. Solved by adding firebase = firebase.firebase; right before var _a = firebase.auth; in angularfire2.udm.js file as @mcchae7 suggested.
My configuration files are similar to @AnthonySoler's.
Thanks for the help!

This is still an isse

I solved my issue, because for some reason I can't import * as 'firebase' from 'firebase I can only import firebase from 'firebase'. Not particularly sure why, but it's an ionic 2 app...

I see a typo in the syntax. It should be
import * as firebase from 'firebase'
What error you get when you import firebase. Ionic 2 App works fine. Have a look at issue #691

I am using ionic2 and I had this issue too. I had to add a custom rollup.config.js script (not sure every option here is actually needed):
plugins: [
  ...
  commonjs({
      include: [
        'node_modules/rxjs/**',
        'node_modules/angularfire2/**',
        'node_modules/moment/**',
        'node_modules/@ionic/storage/**'
      ],
      namedExports: {
        'node_modules/firebase/firebase.js': ['initializeApp', 'auth', 'database'],
        'node_modules/angularfire2/node_modules/firebase/firebase-browser.js': ['initializeApp', 'auth', 'database']
      }
  }),
...

from here https://forum.ionicframework.com/t/ionic-2-rc-0-and-firebase-not-angularfire/65018/7
Also have useStrict: false or else I get navigator undefined...
Note that you set where your custom config is in package.json with:
...
  "config": {
    "ionic_rollup": "./scripts/rollup.config.js"
  }
}

Hope this helps someone save some time and maybe make it easier to find a proper solution

I went down the config route but I really don't think that's the best way to go. In the end, whatbworked for me was updating all the angular versions to 2.2.1. Then it worked

@Rambatino how did you update all angular versions?

@isaquesuzuki Change version of angular packages in package.json and run npm update

Thanks @samedii. Is there any problem if npm warns me about<EMAIL_ADDRESS>requiring a peer of<EMAIL_ADDRESS>

@isaquesuzuki Try and see if it works. I think I maybe got it to work by using version 2.1.1 and not 2.2.1

I have two projects, ones is working, the other one, it isn't, the one that is working is showing more files loaded when I pause the execution just before var _a = firebase.auth;, the one that it's not working it's only showing firebase.js. The one that it's working shows app.js, auth.js, database.js, storage.js and firebase.js. Is this ok?

@arielcessario this works for me too as a workaround.  Any word on the official solution to this issue?

I added and updated wiki pages for that for Angular2 seed.
this.addPackageBundles({
      name: 'firebase',
      path: 'node_modules/firebase/',
      packageMeta: {
        main: 'firebase-browser.js',
        defaultExtension: 'js'
      }
    });

https://github.com/mgechev/angular-seed/wiki/Integration-with-Firebase
https://github.com/mgechev/angular-seed/wiki/Integration-with-AngularFire2

@xmcchae7 I updated the project.config.ts as above, but still get  'Uncaught TypeError: Cannot read property 'FacebookAuthProvider' of undefined' after a prod.build.  Would you have any other ideas on this fix for this?

@stuartdrennan I used Firebase only, you can see my example here ->
Full Source: https://github.com/GoEngin/GoEnginO
firebase.initializeApp: https://github.com/GoEngin/GoEnginO/blob/master/src/client/app/app.component.ts
using firebase: https://github.com/GoEngin/GoEnginO/blob/master/src/client/app/shared/util/dataaccess.ts

@mcchae7 thanks, sorry.  That doesn't help with my project for some reason though.  I'm using angularfire2.
"angularfire2": "^2.0.0-beta.6"
"firebase": "^3.6.4"

I've tried all the suggestions I can see here; changing project.config.ts, changing angularfire2.umd.js, trying to for version.  Its find in development, but only errors on prod.build version.
Any thoughts would be much appreciated? :)

For a test, I cloned the latest angular2-seed and installed only angularfire2 with the same result.  Fine in development, errors on production build.  The https://github.com/mgechev/angular-seed/wiki/Integration-with-AngularFire2 intructions say to use<EMAIL_ADDRESS>&<EMAIL_ADDRESS>but<EMAIL_ADDRESS>doesn't contains 'firebase-browser.js' so the build is not happy with that version.

firebase = firebase.firebase; dont work when
packageMeta: {
        main: 'firebase-browser.js',
        defaultExtension: 'js'
      }

to solve this use
packageMeta: {
        main: 'firebase.js',
        defaultExtension: 'js'
      }

This is still an issue with 2.0.0-beta.7.1-pre I still get Uncaught TypeError: Cannot read property 'FacebookAuthProvider' of undefined even though I am not using any auth providers. I have tried every approach mentioned here with no success, also tried downgrading to firebase 3.4.0
Any ideas?

Making the change in the packagemeta object fix the issue with the build process, but it seems other things get broken. In my case, I am using storage API and now the app is throwing an error related with it: firebase.storage is not a function.
Any suggestion?
thanks!!

I've faced with the same issue.  Resolved with change angularfire2.udm.js file as  @AnthonySoler and @evellynsc saggested. But I not sure that's best aproach, because it might be a reason of another issues in future.

Has there been any update on this? I've tried adding the firebase = firebase.firebase; bit to angularfire2.umd.js file and am still getting errors.

Thanks @arielcessario , I have fixed it..


Minor bugs with native course detail screen

Only show overlay message if tapping "Enroll now" not "View Course".
Hide back text for course catalog

JIRA: https://openedx.atlassian.net/browse/MA-1699

@mikekatz please review

:+1:


Memory leak at Transitions

Describe the bug
Memory leak at Transitions, it takes more than 9 GB.
I don't use any transitions.
To Reproduce
when I leave the program works for a long time without touching it.
Expected behavior
low memory.
Screenshots

Environment

OS: Windows X64
Avalonia-Version: 11.0.6

Should be fixed by https://github.com/AvaloniaUI/Avalonia/pull/12861 afaik. Please try nightly if that fixes the issue.

Yes, it was fixed


AbstractProfileService::convertAttributesToProfile sets profile id with username instead of id

AbstractProfileService::convertAttributesToProfile sets profile id with username instead of id

https://github.com/pac4j/pac4j/pull/1351

Please do not create an issue only to then follow up with a pull request for said issue. Just submit the pull request; Less paperwork that way :)


DbContext inside of parallel tasks failed.

Describe what is not working as expected.
I am trying to using DbContext inside of a parallel tasks.
If you are seeing an exception, include the full exceptions details (message and stack trace).
Cannot access a disposed object. A common cause of this error is disposing a context that was resolved from dependency injection and then later trying to use the same context instance elsewhere in your application. This may occur if you are calling Dispose() on the context, or wrapping the context in a using statement. If you are using dependency injection, you should let the dependency injection container take care of disposing context instances.
Object name: 'AppDbContext'.

at Microsoft.EntityFrameworkCore.DbContext.CheckDisposed()
   at Microsoft.EntityFrameworkCore.DbContext.Microsoft.EntityFrameworkCore.Internal.IDbSetCache.GetOrAddSet(IDbSetSource source, Type type)
   at Microsoft.EntityFrameworkCore.DbContext.Set[TEntity]()

Steps to reproduce
//  I've added my DbContext to the service collection like this
services.AddDbContextPool<AppDbContext>(o =>  {...});

//  injected in the controller like this
private readonly AppDbContext _context;

public UserController(AppDbContext  context){
   _context = context;
}

Task.Run( () => {

// var _context = new AppDbContext(...);

foreach(var user in Users){

       email.Send(user.email);

      _context.log.add(...);
      _context.SaveChanges();
      // more operations using DbContext

    }

});

Further technical details
EF Core version: 2.0.0
Database Provider: 2.0.0
Operating system: Windows 10
IDE: Visual Studio 2017

@irowbin Is the code really using new to create a new context instance inside each thread? If it is instead resolved from the D.I. container, then make sure thread creates a new scope before obtaining the context, otherwise the same context instance with be used by multiple threads.

No i am not creating a new instance in each thread. I am accessing from the DI and i am keep seeing that exception. What do you mean?

make sure thread creates a new scope before obtaining the context

Do i have to change from services.AddDbContextPool<AppDbContext>() to services.AddScoped<AppDbContext>() ? Thanks

@irowbin DbContext is not thread-safe. You'll need to make sure that each thread has it's own instance of DbContext (or carefully add locking if you need to use the same instance.) Typically, DbContext is registered as scoped, so creating a new scope for each thread will ensure each thread gets a new instance.

@ajcvickers So how can i configure that? If i have 100 iteration then i have to create new instance for each  thread? Does above code works with that if i change the DI to services.AddScoped<AppDbContext>()?

@ajcvickers This is how i done the job. Please let me know whether this approach is good practice.

foreach(var user in Users){

    Task.Run( async() => {
      var builder = new DbContextOptionsBuilder<AppDbContext>();
          builder.UseSqlServer(_config["data:connectionString"]);

       var _context = new AppDbContext(builder.Options);

      await  email.SendAsync(user.email);

      await _context.log.addAsync(...);
      await _context.SaveChangesAsync();

      // more operations using DbContext
  });
}

@irowbin The context should be disposed, but other than that it looks safe. Whether or not it makes sense to create multiple threads to do this is something I can't answer--it depends on your needs and environment.


Counting individual camos towards Orion progress

Hey Emil,
I used your tracker for Damascus back in the day and I'm enjoying it a lot also with the Orion grind. At the moment I'm only levelling up the guns while focusing on the first 2-3 camos so I don't finish all of them before moving on to the next gun. I noticed that the Orion progress bar doesn't update by just finishing regular camos but only when finishing the gold/plat/poly camo. Is it intended?
It would feel more satisfying to see the progress go up by smaller increments whenever a camo is unlocked, what do you think? 😄
Thank you for your work on this! (and the other contributors!)

Hey!
Glad to hear that you enjoy my trackers! 😄
It's currently intended to be counted that way. I haven't figured out a way to count individual camouflages towards the progress without encountering false positives issues. Right now, before DLC weapons are added, it's fairly easy to count the individual progress, but let me paint you a picture of the dilemma I've been faced with ever since Call of Duty Cold War (2020) - when they began counting DLC weapons towards the mastery camouflage progress 😅:
Let's say we need 8 Gold camouflages for the Assault Rifles category, with there being 10 weapons in total (8 base game and 2 DLC weapons). You would need to complete 32 (8 * 4) base camouflages to be considered completed with this category, right? But since there's 40 camouflages in total, counting the base game rifles and DLC rifles, you could potentially finish 2 camouflages on 1 rifle and 2 on another, which in the calculation would sum up to one completed rifle, when both are just half-completed. This could then down the road potentially make the Orion progress 100%, when in reality you still have a few weapons left. It's a bit hard to explain, but I hope my point, and dilemma, was clear enough 😄
The Damascus grind was so much easier to calculate, since DLC weapons did not count.
I've spent a lot of hours trying to fix this issue but haven't come up with a viable solution yet 🤔 I'll leave this issue open and try my hand at it again sometime when I have the time. But anyone that's willing is very much free to try and find a solution to this 😄

I see, thanks for the explanation!
I'm not very familiar with how to implement this but in terms of raw ideas, since we know how many guns are need per category (let's say n) to complete the Orion challenge, can't we group them, sort by how many camos are unlocked on a gun and take the first n guns?
Doing this for every category, you would always end up with the 51 guns with the most progress and starting a DLC gun would not count towards the progress until you unlock more camos than any existing one.

sort by how many camos are unlocked on a gun and take the first n guns?

100% agree, this is how I would implement it as well 😄


Add focusSettingsFile option to configure output location of generated settings file

This allows for potentially checking in these files on-demand for caching purposes

Let me know how you want me to set up a test for this

Strangely running ./gradlew apiDump in the plugin dir doesn't appear to actually update anything?

Thanks, I think this is a reasonable start, though it'll also need some docs and tests, but I think that can wait for another time.


New PR to test SignCLA at 2017-11-08 10:37:25.159475188 -0800 PST m=+65.472534105

Body of PR

unsigned-fail-fork-staging: test succeeded


Pie chart doesn't show negative values

Codepen
https://codepen.io/lulztop/pen/WWNpZx
Explanation

What is the behavior you expect?
All values to be displayed
What is happening instead?
If a series value is negative, it won't be shown. Pie chart only displays positive values?

It changed my data with Math.abs() and solve the problem.


Metron 146 topology workers

This allows you to configure the number of workers in the enrichment topology. The variable name is pretty long, for the sake of being verbose (storm.topology.enrichment.workers, or in Ansible it is storm_topology_enrichment_workers).
I tested this using the vagrant/quick-dev-platform image. After starting, I ran the ./run_enrichment_role.sh script to start the enrichment topology. I verified that the file has the configured value and the topology started correctly. You can see in the ansible output that it tried to replaced the variable here but the default value is the same since as the original value. I can only run this on my laptop:
'''
TASK [metron_streaming : Configure Metron Solr topology] ***********************

ok: [node1] => (item={u'regexp': u'storm.topology.enrichment.workers=', u'line': u'storm.topology.enrichment.workers=1'})
'''
If someone could test changing the value on a real cluster that would be great. I don't have the hardware for it.

Ah, ok, so this is failing the integration tests because you're not setting the topology.workers property.  You can either set it

In this block of code
In this and this file

The first will just fix it for the integration test.  The second will provide a default for the deployed properties.  That being said, it should be being set via ansible, so providing a default isn't strictly required.
I don't have a strong opinion either way.

I had set the value in those files. The problem was that I set it as String in the Integration test rather than as an integer.
I also had merged with master, but the build failed on something that I think is totally unrelated to my changes, so I reverted the merge. Here is the failed build.

@jjonez Are you good with closing this PR?  It has been a good amount of time since its been touched.  Thanks

Yes. Please close it. Thanks

On Sep 21, 2016, at 1:20 PM, Nick Allen<EMAIL_ADDRESS>wrote:
@jjonez Are you good with closing this PR? It has been a good amount of time since its been touched. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I am unable to.  You should be able to close it though.  Thanks.

Sorry. I'll take care of it.

On Sep 21, 2016, at 1:24 PM, Nick Allen<EMAIL_ADDRESS>wrote:
I am unable to. You should be able to close it though. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Active connection even though the vpn is off

After the automatic switch from mobile data to the trusted wifi (auto tunneling on) , the vpn is disabled as expected.
But even if the vpn is off, there is still a active wireguard Negotiation between the android device and the router. Therefore the router thinks the client is still connected via vpn even though the switch in the app is off.
With the official wireguard app, this problem is not existient. After switching the button to off (in the official app), the connection and Negotiation both are disconnected.
My device is a Pixel 5 with Android 13.

Yes, the issue occurs in about 98% of the time on three different devices. With manual switching and auto tunneling disabled the issue does not occur.

Yes, the issue occurs in about 98% of the time on three different devices. With manual switching and auto tunneling disabled the issue does not occur.

Thank you for the additional info! I'll take a look.

Yes, the issue occurs in about 98% of the time on three different devices. With manual switching and auto tunneling disabled the issue does not occur.

So I just did a few hours of testing and I see what you are talking about where I am still seeing traffic on my WireGuard server despite the VPN being disconnected on my phone.  However, I uninstalled the WG Tunnel app and performed the same test with the official WireGuard app and I am seeing the same behavior. Can you confirm?

When the button is disabled manually, the negotiation between my devices and my router on both the official and your app is stopped. The negotiation is kept alive on your app with auto tunneling enabled only.

When the button is disabled manually, the negotiation between my devices and my router on both the official and your app is stopped. The negotiation is kept alive on your app with auto tunneling enabled only. (after the switch from mobile data to the trusted wifi network )

I understand that you are seeing this issue only when auto tunneling is controlling when the tunnel is up or down. During my testing to get to the bottom of this, I was testing to see if I could see this same issue even while auto tunneling was disabled. Even while manually controlling the tunnel I was seeing continued negotiation with the wireguard server. Additionally, I was seeing the same behavior when I uninstalled WG Tunnel and installed the official wireguard app. Are you not seeing the same thing?

I understand what you mean. No, I see a different behavior on my device. If I stop the VPN manually, following entry is created in my log: "The WireGuard connection to remote station xxx has been disconnected."
After that the device on my firewall is set to the status "inactive" and loses its domain (assigned port on the firewall gets shut down). Moreover the time for the last negotiation stays unchanged.
When I have auto tunneling active and my network switches from LTE to Wifi, the "Button" in your app switches to off and the vpn connection on my android device disconnects. But the connection from the app is still active in the background and still negotiatiates through the assigned open wireguard port in my firewall even though the VPN is off.

But this happens not every single time, in about 2% of the time it disconnects as intended. Btw what firewall do you have?

But this happens not every single time, in about 2% of the time it disconnects as intended. Btw what firewall do you have?

I have a Firewalla Purple. How about you?

I have a Fritzbox. But you are right, chatting on Discord is much easier 🙃. I will join the server shortly.

@bcsti I wanted to follow up on this one and see if you are okay with closing this one out. It is hard for me to determine if it something specific with the Fritzbox. Currently, I am still unable to reproduce this behavior.

Yes, you can close this issue. Even though the issue still appears, I can't find the cause... If I should ever find a solution, I will comment on this issue.


Use Guzzle Parser instead of our own

We could possibly implement the URITemplate logic using guzzle3/parser. We currently use our own Google_URITemplate class, and it works great, but consolidating them would mean less code in the universe, which is a good thing.

Guzzle 3 code is basically unmaintained at this point (I'm the author). If you want to use this code, it might be better to fork it or vendor it. Alternatively, the PSR-7 stuff newer versions of Guzzle uses has the parser as well:

https://github.com/guzzle/psr7/blob/master/src/functions.php#L440
https://github.com/guzzle/psr7/blob/master/src/functions.php#L468


[QoI] Improve diagnostics for non-representable-in-objc types

If the property doesn't have TypeRepr, use the location of the name.
On:
import Foundation
struct SwiftStruct {}
class C {
  @objc let foo = SwiftStruct()
}

Previously:
test.swift:4:13: error: property cannot be marked @objc because its type cannot be represented in Objective-C
  @objc let foo = SwiftStruct()
            ^
<unknown>:0: note: Swift structs cannot be represented in Objective-C

Now:
test.swift:4:13: error: property cannot be marked @objc because its type cannot be represented in Objective-C
  @objc let foo = SwiftStruct()
            ^~~
test.swift:4:13: note: Swift structs cannot be represented in Objective-C
  @objc let foo = SwiftStruct()
            ^~~

It's better than <unknown>:0.

@swift-ci Please smoke test


Add helper method for edge effect colour fade.

I didn't go down the path of making FadeEdgeEffectTo(EdgeEffect newEffect) for now because it's quite complex to construct the TransformTo function for that at the moment.

might want to mention the flush logic (ie. you can't use Alpha and Colour fades at the same time)

oh wait, they are overrides of the same function. never mind


chore: add github templates

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff          @@
##           master    #3   +/-   ##
====================================
  Coverage      92%   92%
====================================
  Files           6     6
  Lines         125   125
  Branches        4     4
====================================
  Hits          115   115
  Misses         10    10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0011b9a...c5ddf88. Read the comment docs.