PolygonHitbox is not working properly

Current bug behavior
When a hitbox is defined, the onHoverEnter will not be fired based on the coordinates of the polygon
HoverEnter is fired but it does not follow the path of the polygon hitbox.
Test sample below on web or macOS app and it will be visible when you hover the polygon.
Expected behavior

When the mousepointer enters the rendered shape, onHoverEnter should be fired
Steps to reproduce
import 'dart:async';

import 'package:flame/collisions.dart';
import 'package:flame/components.dart';
import 'package:flame/events.dart';
import 'package:flame/game.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(
    GameWidget(
      game: MyGame(),
    ),
  );
}

class MyGame extends FlameGame {
  @override
  FutureOr<void> onLoad() {
    add(HoverablePolygon());
    return super.onLoad();
  }
}

class HoverablePolygon extends PositionComponent with HoverCallbacks, GestureHitboxes {
  late ShapeHitbox hitbox;
  @override
  Future<void> onLoad() async {
    super.onLoad();

    final points = [
      Vector2(0.9, 0.1),
      Vector2(0.2, -0.8),
      Vector2(-0.7, 0.2),
      Vector2(0.1, 0.6),
    ];
    hitbox = PolygonHitbox.relative(points, parentSize: Vector2(300, 300));
    hitbox.paint.color = Colors.red;
    hitbox.renderShape = true;
    add(hitbox);
  }

  @override
  void onHoverEnter() {
    hitbox.paint.color = Colors.green;
  }

  @override
  void onHoverExit() {
    hitbox.paint.color = Colors.red;
  }
}

Flutter doctor output
[✓] Flutter (Channel stable, 3.13.6, on macOS 14.0 23A344 darwin-arm64, locale en-NL)
    • Flutter version 3.13.6 on channel stable at /Users/wilkothomassen/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (4 weeks ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/wilkothomassen/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A240d
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554             • android-arm64  • Android 13 (API 33) (emulator)
    • Wilko’s iPhone (mobile)     • 00008130-00024C8C2E40001C • ios            • iOS 17.0.3 21A360
    • macOS (desktop)             • macos                     • darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)                • chrome                    • web-javascript • Google Chrome 118.0.5993.88

[✓] Network resources
    • All expected network resources are available.

• No issues found!

More environment information

Flame version: 1.10.0

More information

This was working properly in version 1.7.3 as long as I took the comment reference in consideration:
NOTE: Always define your shape in a counter-clockwise fashion (in the screen coordinate system)

Duplicate of https://github.com/flame-engine/flame/issues/2758, thanks for the well written issue though!
Hopefully I'll have time to look into it after the Flutter LatAm conference.

I'm sorry and thank you!


Integrate experimental string processing modules and enable end-to-end regex.

Checkout apple/swift-experimental-string-processing.
Build _MatchingEngine as part of libswift (ExperimentalRegex) using sources from the package.
Parse regex literals using the parser from _MatchingEngine.
Build both _MatchingEngine and _StringProcessing as part of core libs using sources from the package.
Use Regex<DynamicCaptures> as the default regex type until we finalize apple/swift-experimental-string-processing#68.

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 71c0778d4da23f34812809aaaaa367a4bcd97fa1

Build failed
Swift Test Linux Platform
Git Sha - 71c0778d4da23f34812809aaaaa367a4bcd97fa1

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

@swift-ci please test macOS

@milseman It might better to just drop Regex.swift altogether (though not in this PR) and define all compiler interfaces in the package.

@swift-ci please test windows platform

Build failed
Swift Test Linux Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

@swift-ci please clean test Linux

Build failed
Swift Test OS X Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

@swift-ci please clean test macos

@swift-ci please clean test windows

Build failed
Swift Test Linux Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

Build failed
Swift Test OS X Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

Couldn’t repro these failures. Here’s another try…
@swift-ci please clean test

Build failed
Swift Test OS X Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

Build failed
Swift Test Linux Platform
Git Sha - d2bed9579a953f19130f9f9d1d5ad2e16c3ff05e

@swift-ci please test

@swift-ci please test linux platform

@swift-ci please test macOS platform

Build failed
Swift Test Linux Platform
Git Sha - bb386798dcb74926c65e09ce0533af60727dd950

Build failed
Swift Test OS X Platform
Git Sha - bb386798dcb74926c65e09ce0533af60727dd950

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 79beb2568fb4abdd231564fcf85ad5bd16a950b3

Build failed
Swift Test OS X Platform
Git Sha - 79beb2568fb4abdd231564fcf85ad5bd16a950b3

apple/swift-experimental-string-processing#74
@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 79beb2568fb4abdd231564fcf85ad5bd16a950b3

/Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift/include/swift/SIL/SILBridging.h:18:10: error: 'string' file not found

One fix is to find string.h, but we don't need it (at least for _MatchingEngine, which will interface with the lexer more directly via UnsafeRawPointer.
That being said, I'm not sure how changes in this PR would surface any error there. We shouldn't have anything to do with SILBridging.h.

@swift-ci please test macOS platform

Windows does not support building libswift yet

@eeckstein - we do build _MatchingEngine in CI, we do not build libswift for the compiler, from https://ci-external.swift.org/job/swift-PR-windows/19226/consoleText
[1146/1181] Linking CXX shared library bin\swift_MatchingEngine.dll
[1147/1181] Generating ../../../lib/swift/windows/swift_MatchingEngine.dll

@milseman: this indicates that there is a bug in MatchingEngine (there are no public interfaces).

Windows does not support building libswift yet.

Err, so what's our integration story here? Should we disable the feature on Windows?

This indicates that there is a bug in MatchingEngine (there are no public interfaces).

Can you elaborate? The module clearly has public interfaces and when it is built on Darwin or Linux, it has public symbols. Do we need to do something to build it correctly here?

The issue with Windows CI seems to have nothing to do with enabling libswift, but because it couldn't find the string processing package source, causing _MatchingEngine to be empty:
-- Using Experimental String Processing library for _MatchingEngine ().
-- Using Experimental String Processing library for _StringProcessing ().

Perhaps a clean test will make it check out?

Build failed
Swift Test OS X Platform
Git Sha - 6fccee924349abe016bbc76ea6ba141bbab80930

@swift-ci please clean test windows

@swift-ci please test linux

@swift-ci please test macos

Build failed
Swift Test OS X Platform
Git Sha - 6fccee924349abe016bbc76ea6ba141bbab80930

@swift-ci please test macos

@rxwei - the CI does use update-checkout to get the other repositories, but it may be that you need to change the Jenkins config.  From https://ci-external.swift.org/job/swift-PR-windows/19245/consoleText:
swift-ci@EC2AMAZ-JCVOGM7 C:\Users\swift-ci\jenkins\workspace\swift-PR-windows>call "C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\swift\utils\update-checkout.cmd" --scheme main --skip-repository swift --skip-repository llbuild --skip-repository indexstore-db --skip-repository ninja --skip-repository sourcekit-lsp --skip-repository swift-argument-parser --skip-repository swift-corelibs-foundation --skip-repository swift-corelibs-xctest --skip-repository swift-driver --skip-repository swift-format --skip-repository swift-integration-tests --skip-repository swiftpm --skip-repository swift-stress-tester --skip-repository swift-syntax --skip-repository swift-tools-support-core --skip-repository swift-xcode-playground-support --skip-repository tensorflow-swift-apis --skip-repository yams --clone --skip-history --skip-tags --github-comment "@swift-ci please clean test windows"  1>NUL 2>NUL

Interesting. It does contain --clone and does not say -skip-repository swift-experimental-string-processing, so I think it should work as expected. Let me try that again.
@swift-ci please clean test windows

@swift-ci please test windows platform

@swift-ci please test

FWIW, the package itself builds and passes tests (with a small change)

@swift-ci please test Windows platform

@swift-ci please test macOS platform

@swift-ci please test Linux platform

@swift-ci please test

@compnerd suggested that we add cmake support to the string processing package itself so that we can avoid globbing in this repo. We plan to do this as a follow-up patch.

I've added conditional import of ExperimentalRegex in libswift based on SWIFT_ENABLE_EXPERIMENTAL_STRING_PROCESSING. Also, I verified that when I delete the string processing repo and set --swift-enable-experimental-string-processing to false, it builds successfully without producing string processing related targets.

@swift-ci please test

@swift-ci please test

This has been merged along with #40595.
300cbaba319340159bfbd7c9697b307bc6ea9eb4

This looks like it broke the incremental builder: https://ci.swift.org/job/oss-swift-incremental-RA-macos/14501/
20:58:28 -- Configuring done
20:58:28 CMake Error at stdlib/cmake/modules/AddSwiftStdlib.cmake:923 (add_library):
20:58:31   No SOURCES given to target: swift_MatchingEngine-watchos-armv7k
20:58:31 Call Stack (most recent call first):
20:58:31   stdlib/cmake/modules/AddSwiftStdlib.cmake:2045 (add_swift_target_library_single)
20:58:31   stdlib/public/MatchingEngine/CMakeLists.txt:25 (add_swift_target_library)


intellij-colors-solarized needs to be updated

The IntelliJ IDEA version of Solarized at https://github.com/jkaving/intellij-colors-solarized has been updated quite a bit compared to the version in the main repo.
It would be nice to have the subtree in the main repo updated

Yes. I tried the included version in PhpStorm, and it was quite broken. The bugs are already fixed in the original repo.

There has been quite a few corrections in the IntelliJ-specific repo.
Unfortunately the main Solarized repo doesn't seem to be updated much anymore (the latest commit was in May).


Calling setData twice produces IE11 console errors

Describe the bug
creating the RTE on IE11 throws a console bug: SCRIPT70 permission denied.
To Reproduce
dynamically create an RTE on IE11
Additional context
I found the reason why this happens: The second call to "setData" in the create() method is the reason why.
Question: Why is setData called twice?
this.instance.setData(this.value);         this.instance.on('instanceReady', () => {           this.instance.setData(this.value);         });
Thanks!

Thank you @vitality82
I will investigate and fix soon.


Requirements up-to-date?

Creating a new environment in a new computer, I get this test failures after pip install -e .
======================================================================
ERROR: Failure: ImportError (No module named 'httpretty')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jc/anaconda/envs/tst/lib/python3.5/site-packages/nose/failure.py", line 39, in runTest
    raise self.exc_val.with_traceback(self.tb)
  File "/home/jc/anaconda/envs/tst/lib/python3.5/site-packages/nose/loader.py", line 418, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/jc/anaconda/envs/tst/lib/python3.5/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/jc/anaconda/envs/tst/lib/python3.5/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/jc/anaconda/envs/tst/lib/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/home/jc/anaconda/envs/tst/lib/python3.5/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 693, in _load
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 662, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/home/jc/bipy/skbio/io/tests/test_util.py", line 18, in <module>
    import httpretty
ImportError: No module named 'httpretty'

Ah, it is in extras_require in setup.py, but I don't know how to install it directly (i.e., doing something like pip install skbio[test]` for developers). Of course, the steps in contributing.md work using the requirements file work, so I'll close this!


Fix typo in workflow description

The description of the workflow had a typo in it (the word "Job" was misspelled "Jpb").

I have fixed the commit message to follow the conventional commits rules

/gcbrun


Fetch Helpers for Common Tasks

I've been upgrading from pre-beta to beta1, I was a bit upset migrating aurelia-http-client to the new aurelia-fetch-client primarily because I feel the raw fetch API a step backwards from the simplicity we got to know in the original aurelia-http-client.
For example, take a look at how much setup is required to fire-off a JSON POST:
this.http.fetch(`${baseUrl}/ExternalLogins`, {
    method: "POST",
    headers: {
        "Content-Type": "application/json; charset=utf-8"
    },
    body: JSON.stringify({
        returnUrl: "/app",
        generateState: false
    })
})

Explicitly define the method: POST
Explicitly define the Content-Type
Explicitly jsonify the body paypload.

Now, compare this to aurelia-http-client:
this.http
  .createRequest(`${baseUrl}/ExternalLogins`)
  .asGet()
  .withParams({ returnUrl: "/app", generateState: false })
  .send();

I really think we need some helpers to help common use cases like POSTing JSON. Something that helps set content-type, method, and auto-body json encoding if it encounters a POJO.

There is a helper function called json that does exactly that. https://github.com/aurelia/fetch-client/tree/master/doc#helpers
import { HttpClient, json } from 'aurelia-fetch-client';
...
this.http.fetch(`${baseUrl}/ExternalLogins`, {
    method: "POST",
    body: json({ returnUrl: "/app", generateState: false })
})

Ah, thank you; that does alleviate most of the issues.


[Issue-1053] - adds the ability to generate/regenerate dnssec keys for a cdn

fixes #1053
depends on PR #1221

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/315/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/274/


Viruss?

Cross opening issues threads now ? How dumb are you fr

Bro I'm new how do I fvk I know if it is  safe.
On Sat, Sep 28, 2024, 12:59 AM Tr3yWay996 @.***> wrote:

Cross opening issues threads now ?
You are receiving this because you authored the thread.Message ID:
@.***>

That's why it has a forum so that people can ask and answers them nicely
On Mon, Sep 30, 2024, 10:14 PM Khetel Lloren @.***>
wrote:

Bro I'm new how do I fvk I know if it is  safe.
On Sat, Sep 28, 2024, 12:59 AM Tr3yWay996 @.***>
wrote:

Cross opening issues threads now ?
You are receiving this because you authored the thread.Message ID:
@.***>

That's why it has a forum so that people can ask and answers them nicely On Mon, Sep 30, 2024, 10:14 PM Khetel Lloren @.> wrote:
…
Bro I'm new how do I fvk I know if it is safe. On Sat, Sep 28, 2024, 12:59 AM Tr3yWay996 @.> wrote: > Cross opening issues threads now ? How dumb are you fr > > — > Reply to this email directly, view it on GitHub > <#240 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/BLL5LQIOKUKDG3EAXVWTW6LZYWFG3AVCNFSM6AAAAABOMUWYAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZG4YDEMJVGI > . > You are receiving this because you authored the thread.Message ID: > @.***> >

No no it's NOT a forum for people to ask these questions, its an ISSUE report system
Ive caped the important words maybe it'll help ya understand idk

This code is open-source, decently popular, and signed by microsoft-approved process to run in the kernel. It has no virus. I would guess that virus websites sometimes think any driver is a virus.

This code is open-source, decently popular, and signed by microsoft-approved process to run in the kernel. It has no virus. I would guess that virus websites sometimes think any driver is a virus.

Very well said, Glory to RawAccel


Update: Host it on Vercel or Netlify

@JasonDsouza212 can you host it on Vercel or Netlify? it would be great if you host it on any one of these. You can track the visitors also. Now it's ok but it would be more professional if you do it. ✌

Ya Ill do that

@JasonDsouza212 are you working on this?

Ya Ill do it tomorrow, Just have some problem with it

Ya Ill do it tomorrow, Just have some problem with it

okkk. Take your time ❤

You can also host it on render.com It is very simple and free.
For a static website like this one it is the best I think as Heroku is not free anymore.
You just need to provide access to the GitHub repo. and You can add any additional envs and custom name also.

Ya Ill do it tomorrow, Just have some problem with it

okkk. Take your time heart

Just deployed it on versel. Have a look at it.

Completed


Unit tests: QueryBuilder tests broken on Windows

https://monacotools.visualstudio.com/Monaco/_build/index?buildId=38974&_a=summary
Might be from https://github.com/Microsoft/vscode/commit/64420af8f6cbc2a7ec677fa0f5de501ed40df9a5
2018-05-02T11:01:57.1064142Z   1) QueryBuilder parseSearchPaths includes with tilde:
2018-05-02T11:01:57.1064554Z
2018-05-02T11:01:57.1065336Z       AssertionError: 'file:///c%3A/Users/VssAdministrator/foo/bar' == 'file:///c%3A/C%3A/Users/VssAdministrator/foo/bar'
2018-05-02T11:01:57.1065763Z       + expected - actual
2018-05-02T11:01:57.1066053Z
2018-05-02T11:01:57.1066759Z       -file:///c%3A/Users/VssAdministrator/foo/bar
2018-05-02T11:01:57.1067143Z       +file:///c%3A/C%3A/Users/VssAdministrator/foo/bar
2018-05-02T11:01:57.1067458Z
2018-05-02T11:01:57.1067835Z       at file:///D:/a/1/s/out/vs/workbench/parts/search/test/common/queryBuilder.test.js:621:24
2018-05-02T11:01:57.1068225Z       at Array.forEach (native)
2018-05-02T11:01:57.1068644Z       at assertEqualSearchPathResults (file:///D:/a/1/s/out/vs/workbench/parts/search/test/common/queryBuilder.test.js:618:32)
2018-05-02T11:01:57.1069117Z       at testIncludes (file:///D:/a/1/s/out/vs/workbench/parts/search/test/common/queryBuilder.test.js:228:17)
2018-05-02T11:01:57.1069623Z       at testIncludesDataItem (file:///D:/a/1/s/out/vs/workbench/parts/search/test/common/queryBuilder.test.js:232:17)
2018-05-02T11:01:57.1070388Z       at Array.forEach (native)
2018-05-02T11:01:57.1070815Z       at Context.<anonymous> (file:///D:/a/1/s/out/vs/workbench/parts/search/test/common/queryBuilder.test.js:325:23)

@roblourens I commented out the broken test, so I could get some green builds.


Update seed for 1.0.0. TrainResult and EvalResult are deprecated and throws an error

In my own project using this seed, I updated to 1.0.0rc2 to discover that TrainResult and EvalResult are deprecated.
For example, I got the error: AttributeError: module 'pytorch_lightning' has no attribute 'EvalResult'
It would be great if this repo can be used with the upcoming 1.0.0 release.

Solved with this commit: https://github.com/PyTorchLightning/deep-learning-project-template/commit/faef5bbf4f3c392b9e4d71e606edaab5ce4d0aaf


Models & Code for trained detection methods

Hi,
Thank you very much for your interesting work and for publicly releasing your dataset.
Do you have any plans to release the checkpoints of trained Yolo-V4 & Fater-RCNN detection methods?
Thanks

Greetings,
you can find a repository for YOLO-V5 trained with LOCO here: https://github.com/mayershoc/loco_yolov5.
We will check if we are able to release the checkpoints for V4 and Faster-RCNN.
Kind regards,
Dimitrij

Thank you very much for the reply.
Sincerely,
Javad


Add Dream On by Pegboard Nerds

Song Name
Dream On
Artist Name
Pegboard Nerds
Source
Youtube
Youtube Link
pMx36VC8R-Q
Direct File Link
No response
Song ID
10006751
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 109017533

accept


Save complicated code by using anomaly stream

Anomaly streams 24/7 at https://www.twitch.tv/anomaly. Using this page directly would mean that a lot of complicated code could be scrapped and would make the program less error-prone.

'The selection is random to give fairness, but we give a higher ‘weight’ to those of you who have more hours watched of VALORANT streams. This weight gives you a higher chance at being selected but it’s still not guaranteed.'
Source: https://beta.playvalorant.com/en-us/news/announcements/day-1-closed-beta-in-eu-na-and-moving-forward/

I just maxed out the environmental variables. :-D

I you want write a lightweight version. 🙂

Good cooding 🤗!

Can I close this issue?


Resolved crash in Samsung S6 and S7. See CB-11206.

Platforms affected
Android
What does this PR do?
Fixes crash on Samsung S6, S7 possible on other Samsung models.  See JIRA issue here
What testing has been done on this change?
Samsung S5, S6, S7, Nexus 5, 9, Samsung GT-S630T, Vodafone VF695 and at least 5 other relevant emulators.
We are looking forward to this pull request being merged back to develop. It's working pretty well on a couple of apps where we use this Cordova plugin.

Cordova CI Build has completed successfully.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android Mac
Link
Link
Link

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

It seems that there is been some configuration changes in Jenkins that made the iOS build to fail. This has not been provoked by my pull request because it only changes a line from the Android side.

Hey, @proverbface, we did some manual testing of this, and it does seem to cause problems on devices, other than you mentioned. In particular, on Samsung Galaxy Note 2 this throws java.lang.NumberFormatException: Invalid int: "null" though the original code is working just fine.
Perhaps it would be better to check if cursor.getString(cursor.getColumnIndex(CommonDataKinds.Im.PROTOCOL)) can be turned into integer first, and if not - fall back to CUSTOM_PROTOCOL.

Pushed the correct fix for the issue, so closing this PR and the JIRA issue.
@proverbface please check if your problem is fixed in current master version of the plugin and if not, please reopen.


treewide (darwin): fix or enable darwin build for many packages (6)

Motivation for this change
See #114976 for details.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116600 run on x86_64-darwin 1

13 packages built:

apparix
bbe
bcunit
catcli
cdi2iso
cpcfs
dejsonlz4
epstool
git-fire
idsk
ministat
mpd-mpris
zdelta

Result of nixpkgs-review pr 116600 at 2d0392f5 run on x86_64-linux 1

4 packages built successfully:

cdi2iso
dejsonlz4
epstool
zdelta

9 suggestions:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/tools/compression/zdelta/default.nix:19:3:
   |
19 |   meta = with lib; {
   |   ^

warning: missing-patch-comment
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/graphics/epstool/default.nix:22:15:
   |
22 |   patches = [ ./gcc43.patch ];
   |               ^

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.
Near pkgs/tools/compression/dejsonlz4/default.nix:12:5:
   |
12 |     buildPhase = ''
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/cd-dvd/cdi2iso/default.nix:16:3:
   |
16 |   installPhase = ''
   |   ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/compression/dejsonlz4/default.nix:16:5:
   |
16 |     installPhase = ''
   |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/compression/zdelta/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/graphics/epstool/default.nix:18:3:
   |
18 |   installPhase = ''
   |   ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/cd-dvd/cdi2iso/default.nix:24:5:
   |
24 |     license = licenses.gpl2;
   |     ^

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/graphics/epstool/default.nix:27:5:
   |
27 |     license = licenses.gpl2;
   |     ^

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116600 run on x86_64-darwin 1

13 packages built:

apparix
bbe
bcunit
catcli
cdi2iso
cpcfs
dejsonlz4
epstool
git-fire
idsk
ministat
mpd-mpris
zdelta

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

apparix:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/tools/misc/apparix/default.nix:17:5:
   |
17 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

Result of nixpkgs-review pr 116600 run on x86_64-darwin 1

21 packages built:

altermime
apparix
bash_unit
bbe
bcunit
catcli
cdi2iso
cpcfs
dejsonlz4
dhcping
epstool
git-fire
httperf
idsk
imgurbash2
ministat
mpd-mpris
sfeed
spirv-cross
vimer
zdelta

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116600 run on x86_64-linux 1

5 packages built:

altermime
cdi2iso
dejsonlz4
epstool
zdelta

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116600 run on x86_64-darwin 1

21 packages built:

altermime
apparix
bash_unit
bbe
bcunit
catcli
cdi2iso
cpcfs
dejsonlz4
dhcping
epstool
git-fire
httperf
idsk
imgurbash2
ministat
mpd-mpris
sfeed
spirv-cross
vimer
zdelta


Move audit 1

@0o-de-lally Any idea about the CI error? Seems like a connection error.
...
.Sep 20 08:16:58.931  INFO ureq::unit: sending request POST http://localhost:39501/
.Timeout waiting for response

@simsekgokhan I wonder if you need to pull from main again, since the upgrade integration tests is failing. As you observed it looks like the swarm nodes are failing and cannot be reached by json-rpc. This indicates the upgrade payload is not compatible.
maybe @jamesmeijers  can help on this, since he last looked at the tests.

maybe @jamesmeijers can help on this, since he last looked at the tests.

Haven't seen that error before...has this been recurring or has it only been tested once? Could be a one-off.

Ok I patched the integration test on main. It was using hard coded values for what branch to test the upgrade against.


Show workspace resources even if workspace isn't open

Instead of not displaying resources if no workspace is opened, show resources and also add a tree item that prompts users to open a folder/workspace.

This more closely mirrors the current behavior, and fixes https://github.com/microsoft/vscode-azurestorage/issues/1214

Have we explored other solutions? I thought I remember Phillip suggestion to have a "getting started" view if there were no tree items. For example:

Have we explored other solutions? I thought I remember Phillip suggestion to have a "getting started" view if there were no tree items.

Yes Phillip actually implemented 3 different welcome views for the workspace view. The PR removes the "no workspace" welcome view. The "no workspace resources" and "no workspace resource providers" welcome views remain.

I think we should consider improving these views with some buttons to get users started, but I won't block for that.

Yeah, I wasn't quite sure what to put in terms of buttons. It'd be nice to have a button that took them to the extensions view but only showed extensions that contribute workspace resource providers.


Local Docker environment vars not all working

Describe the bug
Some of passed variables seem to be not working. RUN_LOCAL is working, because otherwise it would be working at all.
But IGNORE_GITIGNORED_FILES and CREATE_LOG_FILE are not working, because there is always a log file being created.
Expected behavior
Working flags and in this case no log file.
Steps to Reproduce
Run:
docker pull github/super-linter:v4.9.0
docker run --rm \
-e RUN_LOCAL='true' \
-e USE_FIND_ALGORITHM='true' \
-e IGNORE_GITIGNORED_FILES='true' \
-e LOG_LEVEL='WARN' \
-e CREATE_LOG_FILE='false' \
-v ./:/tmp/lint \
github/super-linter:v4.9.0

We should probably verify that this is still an issue in the latest version of the super linter (v5.2.1)

Okay, yeah, then I know what the issue is.
I can't use the latest Version because of this: https://github.com/super-linter/super-linter/issues/4445#issue-1788167778
But with the latest version my issue doesn't exist, so maybe it was fixed previously.


Can't work with local repository from WSL2

Hi, I encountered the following issue when trying to choose a folder from WSL2.

Duplicate of #92. Unfortunately, this issue cannot be solved on the CMS side.


Resolve vcgencmd path errors

Update discover to try and resolve a path to vcgencmd instead of trying a hard-coded one

There is already this PR https://github.com/OpenVoiceOS/ovos-gui-plugin-shell-companion/pull/14/files

There is already this PR https://github.com/OpenVoiceOS/ovos-gui-plugin-shell-companion/pull/14/files

Whoops, totally missed that. I had these changes in my local branch for too long.


System buttons alignment

Setup or portable version of the app?
Portable
Steps to reproduce

Open yomikiru.
Open settings, cycle through themes and obsersve the top buttons.
Click on home icon and observe the top buttons.

https://user-images.githubusercontent.com/116664905/234582253-cf0295de-ad43-4ba0-91ad-d94e68932402.mp4
✔ Expected Behavior
Alignment / sticking with top bar.
❌ Actual Behavior
Misplaced alignment and glitching.

I'm unable to reproduce this bug, have you tried restarting pc, it might be system related.

Will be fixed in next version.

The issue was not visible to me because of device pixel ratio, display scale on laptop screen is usually higher than 125%.


How to disable legend in multichart ?

Help me in disabling legends from Multichart.
PS: showLegend = false isn't working.

Can we disable legends only for a selected series in multi-line charts?


[kube_proxy] metrics don't match up with latest provided by the endpoint

Output of the info page
    kube_proxy (3.4.0)
    ------------------
      Instance ID: kube_proxy:419cfe475dd508f1 [OK]
      Configuration Source: file:/etc/datadog-agent/conf.d/kube_proxy.d/conf.yaml
      Total Runs: 113
      Metric Samples: Last Run: 6, Total: 678
      Events: Last Run: 0, Total: 0
      Service Checks: Last Run: 1, Total: 113
      Average Execution Time : 5ms
      Last Execution Date : 2021-03-13 00:21:07.000000 UTC
      Last Successful Execution Date : 2021-03-13 00:21:07.000000 UTC

Additional environment details (Operating System, Cloud provider, etc):
Kubernetes v1.20
The expected kubeproxy_sync_proxy_rules_latency_microseconds is missing, in its place is kubeproxy_sync_proxy_rules_duration_seconds and kubeproxy_network_programming_duration_seconds. The integration probably needs updating for the latest metric names.

There's a bunch of other metrics missing:

kubeproxy_sync_proxy_rules_endpoint_changes_pending
kubeproxy_sync_proxy_rules_endpoint_changes_total
kubeproxy_sync_proxy_rules_iptables_restore_failures_total
kubeproxy_sync_proxy_rules_iptables_total
kubeproxy_sync_proxy_rules_service_changes_pending
kubeproxy_sync_proxy_rules_service_changes_total
rest_client_request_duration_seconds histogram
rest_client_requests_total counter

Hi @adammw and @therc
Thanks for opening the issue. This is acknowledged and we'll be working on adding new metrics and handling the deprecated ones in the coming agent releases. Thanks!


Mark new chunks ready before triggering OnChunkLoaded events.

Because the OnChunkLoaded event is created in world generation threads, rather than the main thread, it usually executes after processReadyChunk is finished, but occasionally it doesn't. The chunk only becomes readable (i.e. getChunk and getBlock will start working inside its bounds) when chunk.markReady is called, which used to happen at the end of processReadyChunk. This meant that occasionally, the event handler for OnChunkLoaded would not actually be able to read that chunk. This led to issues like that NullPointerException in VoxelWorldSystem and some chunks being invisible, both of which should now be fixed. (A similar issue sometimes still happens sometimes when a world is unloaded: a chunk's OnChunkLoaded event may not run until after the chunk has been unloaded, but that matters less because it's being unloaded anyway.)
Moving the entirety of processReadyChunk to the main thread would likely make this area less error prone, but I'm a lot less confident that that change wouldn't break anything else. The small change that I have made has the virtue that what happens with the change is pretty much what used to happen already most of the time, so we can be very confident that it makes things more correct.

Seems good. I'll merge once the CI checks agree.


[v7.21.0] includeExternalHelpers option breaking with latest @babel

I cleared node_modules and ran npm install with version 7.21.0 and when I run ember serve I get the following error:
Error: Could not find module @babel/runtime/helpers/initializerDefineProperty/_index.mjs imported from @babel/runtime/helpers/esm/initializerDefineProperty
    at missingModule (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:247:1)
    at findModule (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:258:1)
    at Module.findDeps (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:168:1)
    at findModule (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:262:1)
    at Module.findDeps (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:168:1)
    at findModule (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:262:1)
    at requireModule (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/vendor/loader/loader.js:24:1)
    at Class._extractDefaultExport (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/addon-tree-output/ember-resolver/resolvers/classic/index.js:445:1)
    at Class.resolveOther (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/addon-tree-output/ember-resolver/resolvers/classic/index.js:105:1)
    at Class.resolve (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/addon-tree-output/ember-resolver/resolvers/classic/index.js:168:1)
    at resolve (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/@ember/-internals/container/index.js:1223:1)
    at Registry.resolve (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/@ember/-internals/container/index.js:763:1)
    at Class.resolveRegistration (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/@ember/-internals/runtime/lib/mixins/registry_proxy.js:32:1)
    at setupSessionRestoration (/var/folders/9r/gp7xyl_j0l3flcwp78j7mjcr0000gn/T/broccoli-276094EuqwRsv8Chf/out-559-broccoli_merge_trees/assets/addon-tree-output/ember-simple-auth/initializers/setup-session-restoration.js:10:1)

...
I tried using npm-force-resolutions and set @babel/runtime: 7.12.0 but then I get a different error when running ember server:
Class constructor Plugin cannot be invoked without 'new'

I'm not sure if something is messed up with upstream babel or otherwise? really stuck
possibly related:
https://github.com/ConnectedHomes/ember-cli-babel/pull/1
https://github.com/babel/babel/issues/12881
Update
I figured out that removing the following previously working config clears the error and loads the app:
    'ember-cli-babel': {
      includeExternalHelpers: true,
    },

Unsure why that would suddenly break? (ember-cli-babel 7.21.0)

FWIW we're having having a similar issue with the Qonto.com apps. we're also using includeExternalHelpers for those.

Can one of y'all make a reproduction?

@rwjblue

clone https://github.com/Turbo87/crates.io/commits/external-helpers
yarn
yarn start:live
visit http://localhost:4200

Thank you, will try to review the demo this afternoon and see what we can do to mitigate...

I can confirm. Works well on the crates.io codebase too 👍
thank you @rwjblue 🤗

looks like we're still having similar issues on some other apps though:

Could not find module @babel/runtime/helpers/esm/arrayWithHoles.js imported from @babel/runtime/helpers/esm/slicedToArray

@Turbo87 And you can confirm you only have "good" Babel runtime versions (e.g. with yarn why)?

looks like it, yes

Basically babel is including the extension in the import paths for the helpers, and our transpilation doesn't support modules at runtime including the extension.


Coil logger support

Ability to view the log information while processing the image. Currently it doesnot support it.
I had implemented ImageLoaderFactor in the Application Class  with the following snippets:
 return ImageLoader.Builder(this)             .availableMemoryPercentage(0.25) // Use 25% of the application's available memory.             .crossfade(true) // Show a short crossfade when loading images from network or disk.             .componentRegistry {                 add(StorageReferenceFetcher())             }             .apply {                 if (BuildConfig.DEBUG) {                     logger(DebugLogger(Log.VERBOSE))                 }             }             .build()
Ok, never mind. just found out that you can have your own imager loader by using
    FireCoil.setDefaultImageLoader(newImageLoader())

@blacpythoz glad you figured it out :)
I'll close this, since it has been solved.


Think about how best to test whether a model could be used for preference-based RLHF-style training

If we are to believe the RL-VLM-F paper, if we get to actual training, we might want to use the VLM to train a proxy reward function instead of using the VLM directly as a reward.
The reward is then based on querying the VLM for preferences over a pair of images (videos, in our case).
This fact (us caring about VLM preferences more than the actual numbers we get from it) might influence how we generate the trajectories #3 and visualize the results #5, hence I created this issue.

My thoughts:
Fix a task T.

For each trajectory we obtain a score from the model (e.g. similarity to the description of T)
We report the raw scores (this is what we're doing now)
We find a principled way to use the raw scores of two videos to generate a preference label for the pair (-1, 0, 1)
We report the statistics of the preferences, too.

It seems that 4, 5 are (very) nice to have, but depend on 1, 2, 3, so we should focus on those first anyway. However, rather than spending a lot of time on making 3 as nice as possible, for example, we could do 4, 5 instead.

I think there is no sense in creating preference pairs from raw scores of individually evaluated videos -- the whole point of using pairs is that humans (and supposedly VLMs) are often more consistent at comparing two images/videos, rather than assigning a score from 0 to 1. If we compute scores individually, we lose this effect.
Also, I think that if our data collection procedure is "gather pairs (trajectory, its thorough text description)", then we can easily pivot to comparison-based approach later.

I'm not sure I agree with the first part, though we probably do agree on all the practical issues (second part) which is what matters. Let's focus on 1, 2, 3 from my original comment and see about 4,5 later.
As to why I don't agree — even for feeding the model single examples I can see a model being bad for getting out raw numbers, e.g. because it is noisy, but being good at producing an ordering, esp. if we train another function on top of it (which presumably gets rid of some of the noise in the orderings, too).


Implement PHPREDIS instead of PREDIS.

predis was last updated in 2017, and laravel has also recommended phpredis, I personally think it should be replaced by phpredis

@wilbur-oo Thanks for the recommendation! :) I'll work on getting that updated. :)

The concern I have is with the configuration changes needed to make Phrpredis work with Laravel, while PREDIS works out of the box with no changes. That being said, PREDIS is struggling from a maintenance point of view.
On the other hand, PHPREDIS requires the PECL extension to be installed, which may or may not be easy to do. Further, it's not installed in Homestead or on forge servers by default. For that reason I'm holding off for now until this becomes easier to manage in the future.

Yes, I agree with your concerns.
But for me personally, the laravel-model-caching package is to improve production performance, so in order to achieve high performance, installing an extension should not be a big problem.
Of course, this is just my personal opinion. I respect your ideas. After all, the change of an extension package ’s dependencies will affect too many users.
Or I think it is possible to adapt two methods, that is, the willingness to use predis or phpredis is up to the user to decide.

Good points! Is there something in the package that is preventing you from using PHPREDIS? Since it's all on the configuration end, and this package doesn't configure the REDIS provider for you, you should be able to.
Would love to hear the steps you need to take to get PHPREDIS to work with the package, and if it throws any errors.

I'm also having an issue getting PHP Redis working with this package. I decided on that instead of predis because of the warning in this section of the docs: https://laravel.com/docs/7.x/redis#introduction
I had used Predis before but if support is going to be removed from Laravel potentially I didn't want to waste time using it. Is that the only option for this library though? If so I might go back and use Predis until this package works with PHP Redis as well.

@wolfpack4417 Could you provide the stack trace of the errors you are getting?

Sorry I think this was on my end although I haven't figured it out yet. I think it has something to do with PHP Redis not being enabled on my docker container. I'm getting '1' when I run extension_loaded('redis') in the browser but not when I run php artisan modelCache:clear. I'll post back if I discover it wasn't an issue with my PHP Redis installation.

Thanks, that would be great! Ideally this package should be decoupled from your choice of caching driver. :)

Sorry for the delay on this. Please try release 0.10.0 and let me know how it works.

This is now easy, as Laravel Forge servers ship with PHPRedis already installed.


[CPU] Fix FusionOfTensorOps nullptr

This PR fixes a compilation crash of an internal models. I'm not familiar with the pass so happy to change the fix or incorporate a test if you can think of an example to exercise this fix.

The Nvidia GPU failure doesn't seem to be related?

The Nvidia GPU failure doesn't seem to be related?

Yeah, that's runtime only code so this couldn't have affected it. Weird though, I've seen some of those CTS tests timeout, but a segfault is a bit different...

Let's rerun...


Fine mapping with parameter estimation

I'm trying to estimate parameters for finemapping and for some reason I the first iteration estimates the gene prior to be zero:
 ctwas::ctwas_rss(
          z_gene = z_gene_subset,
          z_snp = z_snp_subset,
          ld_exprvarfs = ordered_ld_exprvarfs,
          ld_R_dir = ld_R_dir,
          ld_regions_custom = regions_file,
          outputdir = outputdir,
          outname = outname,
          estimate_group_prior = T,
          estimate_group_prior_var = T)
   ...
2024-04-18 13:22:30.132874 INFO::Adding R matrix info for chrom 20
2024-04-18 13:22:30.141519 INFO::Adding R matrix info for chrom 21
2024-04-18 13:22:30.14914 INFO::Adding R matrix info for chrom 22
2024-04-18 13:22:30.177372 INFO::Run susie iteratively, getting rough estimate ...
2024-04-18 13:22:30.179785 INFO::run iteration 1
starting worker pid=3144 on localhost:11502 at 13:22:31.111
Loading required package: ctwas
loaded ctwas and set parent environment
2024-04-18 13:22:57.624383 INFO::After iteration 1, gene prior 0:, SNP prior:0.000186636804777902
2024-04-18 13:22:57.658267 INFO::run iteration 2
starting worker pid=4189 on localhost:11502 at 13:22:58.565

This seems to result in an error in the second iteration specifically here as prior_variance is never assigned a variable. Unclear on what I may have done incorrectly or if this is a potential bug, but I'd greatly appreciate any thoughts on what might be going on!

@jgockley62 Hi, did you use the example data (one region) to estimate parameters? This will cause an error. We suggest using genome-wide data (all regions) to estimate parameters.

Ahhhh ok I will try estimating genome-wide. Thanks!

2024-04-22 22:14:52.18408 INFO::Adding R matrix info, as genotype is not given 2024-04-22 22:14:52.537894 INFO::Adding R matrix info for chrom 1 2024-04-22 22:27:55.469278 INFO::Adding R matrix info for chrom 2 Error in (function (cond)  :    error in evaluating the argument 'y' in selecting a method for function 'crossprod': subscript out of bounds Calls: system.time ... sapply -> lapply -> FUN -> crossprod -> <Anonymous>
@sq-96 Hello, what's wrong with me? I'm estimating parameters with genome-wide data. And I use ld downloaded from your site. And I use my own gwas summary statistics. Please.

@HackerLZH Could you attach your code here?

@sq-96
It's in fact R format, but can't be uploaded, so I reformated.
run_ctwas.txt
Thanks, please.

Hi @sq-96 Apologies to un fork this back. I've switched to the multigroup fork for parallel processing, it seems to run into resource issues randomly. For example when running impute_expr_z() it will throw an error on say chromosome  3, but when I re-run it, it will run fine. I'm not sure if its just an issue handling the cluster build every chromosome or not, but wondering if you had any advice. Should I switch to the multigroup_dev branch?
Lost warning messages Error: no more error handlers available (recursive errors?); invoking 'abort' restart Lost warning messages Error: no more error handlers available (recursive errors?); invoking 'abort' restart Error in [.data.frame(z_snp, z.idx, ) :    INTEGER() can only be applied to a 'integer', not a 'unknown type #29' In addition: Warning message: In [.data.frame(z_snp, z.idx, ) : type 29 is unimplemented in 'type2char'

@jgockley62 Hi, did you use the example data (one region) to estimate parameters? This will cause an error. We suggest using genome-wide data (all regions) to estimate parameters.

Hi, I have a similar problem. When performing cTWAS at a single locus, it's necessary to provide the estimated prior inclusion probabilities for genes and variants (group_prior) as well as the estimated effect sizes for genes and variants (group_prior_var). Is it possible to estimate these two parameters in the single locus model? This approach is preferred because we specifically aim to conduct fine-mapping analysis within a region around each top SNP. Performing cTWAS genome-wide for parameter estimates consumes considerable resources and time.

@HackerLZH @jgockley62 @fengx25 Hi All, we are going to release a new version very soon, with improved speed and memory usage. I believe it would solve problems you posted. I will notify you once it is ready. Thanks for your patience!

@HackerLZH @jgockley62 @fengx25 We have updated the software: https://xinhe-lab.github.io/multigroup_ctwas/index.html


🐛 Mass amount of Unresolved reference when update to v3

What were you trying to do?
Updated from 2.15.4 to 3.0.0-rc.5
Reproduceable Code
"react-native": "0.71.8",
"react-native-worklets": "github:chrfalch/react-native-worklets#d62d76c",
//tried to use react-native-worklet-core but the package is not linked in cMake and build.gradle yet (still use the old name)
"react-native-vision-camera": "3.0.0-rc.5",
"@shopify/react-native-skia": "^0.1.202",

What happened instead?
Build fail
Build.gradle
buildToolsVersion = "33.0.0"
        minSdkVersion = 28 // or higher
        compileSdkVersion = 33
        targetSdkVersion = 33
        androidXCore = "1.0.2"
        playServicesVersion = "17.0.0"
        RNNKotlinVersion = "1.7.20"
        RNNKotlinStdlib = "kotlin-stdlib-jdk8"
        kotlinVersion = "1.7.20"
        ndkVersion = "21.4.7075529"

Relevant log output
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
.../android/src/main/java/com/mrousavy/camera/extensions/MediaFormat.setDynamicRangeProfile.kt: (3, 40): Unresolved reference: DynamicRangeProfiles

../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/MediaFormat.setDynamicRangeProfile.kt: (34, 54): Unresolved reference: TIRAMISU

react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/MediaFormat.setDynamicRangeProfile.kt: (35, 63): Unresolved reference: FEATURE_HdrEditing
../node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/Size+Extensions.kt: (12, 10): Unresolved reference: minBy

../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/Size+Extensions.kt: (12, 22): Unresolved reference: it

../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/parsers/VideoStabilizationMode.kt: (5, 48): Unresolved reference: CONTROL_VIDEO_STABILIZATION_MODE_PREVIEW_STABILIZATION

../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/utils/CameraDeviceDetails.kt: (68, 54): Unresolved reference: TIRAMISU

../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/utils/CameraDeviceDetails.kt: (69, 48): Unresolved reference: REQUEST_AVAILABLE_CAPABILITIES_DYNAMIC_RANGE_TEN_BIT
../react-native-vision-camera/android/src/main/java/com/mrousavy/camera/utils/CameraDeviceDetails.kt: (70, 49): Not enough information to infer type variable T

FAILURE: Build completed with 2 failures.
1: Task failed with an exception.

What went wrong:
Execution failed for task ':react-native-vision-camera:compileDebugKotlin'.

A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
Compilation error. See log for more details

Device
Android
VisionCamera Version
3.0.0-rc05
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

and progress on this ?

Same for me
node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/Size+Extensions.kt: (12, 10): Unresolved reference: minBy

To fix this need to update kotlinVersion = '1.7.20'

To fix this need to update kotlinVersion = '1.7.20'

my build gradle (check above) is already declared kotlinVerson = 1.7.20

@mrousavy Hi! Do you have time to look into this?

Hi! No, why?

node_modules/react-native-vision-camera/android/src/main/java/com/mrousavy/camera/extensions/Size+Extensions.kt: (12, 10):
Unresolved reference: minBy
This error😅
 "react-native-vision-camera": "^3.0.0",

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖

It's not fixed


Inconsistent date and location order

Hi,
It seems like the order of the date and location is inconsistent for the different sections. I personally would prefer the order and text style used for the education section, do you have any thoughts on this?

See #5 , if you'd like you can reorder  it using the generic component, pretty much the same thing there :smile:


Download links need to be updated to the 0.2.1 release

Outdated. Issue in release-tools still has to be fixed.


Running tasks with no parameters fails

When running a task that has no required parameters, the command fails.
# mco tasks run myapp::task -I /foo/
Could not parse input from --input as YAML or JSON

Can you share the plan? or at least the parameters part of it?
plan acme::simple (
) {
  notice("hello world")
}

% mco playbook run acme::simple
Notice: Scope(<module>/acme/plans/simple.pp, 3): hello world

Plan acme::simple ran in 0.02 seconds: OK

Playbooks are fine. It's when i'm running a puppet task.

ah wow, i need more coffee lol sorry about that

https://github.com/choria-io/mcollective-choria/blob/97b4424c467c95ceb8208417d461183de207eb1e/lib/mcollective/util/tasks_support/cli.rb#L161-L163
This should just return {} instead of failing

I tried running the task without the unless result.empty? and it works fine with no parameters.


How do I remove the Debug toolbar?

I can't find how to remove the debug toolbar.  I never use it

You can just remove it. Main menu->Window->Customize Perspective:

Note: this toolbar shouldn't be visible by default. Perhaps you did try to debug at least once.

Thank you. I would never have found it ))


add mimetype support

for instances where you cant control the URL, it should support defining a mimetype in the source like every other player does

I agree we should receive the MIME but I don't know if we should check for it inside the method. It seems that RTMP doesn't have a mime (I assume it's because it's actually a protocol not a format?).

@flavioribeiro Doesn't have one, but seems most people have accepted rtmp/mp4 as the defacto "mimetype".
Really just trying to make this possible:
new Player({ source: 'something.com/anything', mimeType: 'rtmp/mp4' })


Add umd build; fixes #354

May I send a PR to github.com/cdnjs/cdnjs ?

I'll get this out as a 4.0.3 soon.

Thank you, @timdorr for merging it! I'll send a PR to cdnjs withing a few days. Redux and react-router are already there.

I'll send a PR to cdnjs withing a few days. Redux and react-router are already there.

Done—https://cdnjs.com/libraries/react-router-redux


Manage milestones

This is more an idea than a feature request:
The bot could manage the milestones of the project automatically. Whenever a new tag is released (e.g. 2.7.2), a milestone for the next version is created (e.g. 2.7.3). Likewise, when a new minor version is released (e.g. 2.7.0), a new milestone for the next version should be created (e.g. 2.8.0).
This feature really becomes useful when we set PR milestones automatically based on their base branch. For example, a PR based on branch 2.7 would be assigned to the latest 2.7 milestone (here: 2.7.3).
When a version is released and the corresponding milestone still contains open tickets, these tickets should be moved to the next milestone (e.g. 2.7.2 -> 2.7.3).
As a result, we could work on next versions more efficiently by checking which PRs and issues are assigned to particular milestones before doing a release.
Not sure if the work in this is warranted, but I think it could be useful. :)

given that we regularly switch the branch on merge, this could create weird things where PRs in the 2.7.2 milestone are merged into the next 2.3 version

@stof True, but do you think that's a big deal?

Well, what would be the benefit of these milestones then ?

The benefit is to chunk down the PRs into more digestible parts. You are right that this view is not perfect, because a ticket that should belong to some 2.3.x milestone may actually be targeted at some 2.7.x milestone. But:

I don't think we need perfect. PRs eventually get merged anyway (or not).
Whether or not the branch/milestone is correct should turn up during review. The milestone can then be corrected from the UI. We could actually support milestone changes similarly to status changes.

@webmozart do we need a 2.7.3 milestone then ? I think milestones per version (2.3, 2.7, 2.8) would be enough to see what is pending for each version.

Maybe. Usually, a milestone is something that can be reached and completed. If we have a 2.3 milestone, that milestone is never complete until we don't maintain 2.3 anymore.
But maybe that solution is sufficient :) It sure is simpler.

well, if the milestone is only used for triaging, this is enough.

👍 on this now that we use milestones for triaging

This is fixed in #87


[Feature Request] Integrate PupPackScreenTweaker (Replacement for Pup Pack Screens Editor)

One of the most difficult things to do is to create or modify a pup pack. The popper editor for it is wonky (nicest way I could describe it) with testing and does not help at all with coordinate/positioning of video windows.  An app that was addressing this halted development 5 yrs ago.. https://github.com/matiou11/PupPackScreenTweaker ... it did things that eliminated guess work positioning DMD's and more.
Would be great to integrate, or replicate, this code!

That looks like it could be pretty useful.

And amazingly small: 123kb.


[Tutorial] Style placement correction

Moves the first <style> inside the HTML, to avoid the formatter issue.
Moves imports to the top of a sample

Dan's got style in all the right places! 💅


Extensbility

Override / Add New / Remove Element Renderer

Extend custom renderer registration to all renderers.

renderer enumeration type

c++ object model vs wrapper.

Closing this. Split it to smaller tasks


Update dependency.rb

libgdbm3 to libgdbm5 in ubuntu 18.04.

Could you branch it using platform_version?

Thanks :+1:


NodeRed User and Password

Hi.
I want to run Wallpanel on a tablet to show NodeRed dashboard. I've configured NodeRed's dashboard access with an user and password protection, and an ssl certificate.... so I enter on Chrome this url: https://my_pi_ip:1880/ui and then I type user and password.
So, how to do that with wallpanel ?, I've not found any way to access an url with user and password and dismiss any ssl error...
thanks

Have exactly the same problem. Any clue how to pro idę credentials?


[SPARK-22162] Executors and the driver should use consistent JobIDs in the RDD commit protocol.

What changes were proposed in this pull request?
In this PR, I have modified SparkHadoopWriter so that executors and the driver always use consistent JobIds during the rdd commit. To avoid confusions, the variable name stageId is also changed to rddId to demonstrate the use of rdd.Id instead of stageId as it was in the old code before PR 15769. sparkStageId is also changed to sparkRddId for the same purpose.
(Please fill in changes proposed in this fix)
How was this patch tested?
In addition to the existing unit tests, a test has been added to check whether executors and the driver are using the same JobId. The test failed before this change and passed after applying this fix.
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

ok to test

Test build #82300 has started for PR 19388 at commit 2df1831.

Test build #82300 has finished for PR 19388 at commit 2df1831.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82300/
Test FAILed.

Test build #82304 has started for PR 19388 at commit 2450333.

Test build #82304 has finished for PR 19388 at commit 2450333.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82304/
Test FAILed.

Test build #82325 has started for PR 19388 at commit 4c0985e.

retest this please

cc @jiangxb1987

Test build #82331 has started for PR 19388 at commit 4c0985e.

Test build #82325 has finished for PR 19388 at commit 4c0985e.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82325/
Test FAILed.

Test build #82331 has finished for PR 19388 at commit 4c0985e.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82331/
Test FAILed.

Sorry for the delay. It seems that to be able to commit the same rdd in different stages we need to use stageId. So the jobId and other configurations in the write method of SparkHadoopWriter should be based on the stageId of the rdd and not the rddId. I have a hacky solution for this, but I am working on a better one and will update this PR ASAP.

@rezasafi and I talked about this for a while offline.  Its a lot trickier than this seems at first.  Here's whats going on:

SparkHadoopWriter is pretending rddId is stageId, but clearly its not.  In the simple test cases they're the same, but they can be arbitrarily different.  That is not new -- it was in the old RDD commit protocol (https://github.com/apache/spark/blob/branch-2.0/core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala#L1084).  However, SPARK-18191 changed it so that on the executors, it was using the real stageId, which resulted in an inconsistency.

We really want the stageId.  Reza had initially made a change to just use the rddId consistently, since that is what was being used before.  However, this leads to an inconsistency, because the OutputCommitCoordinator actually expects the stageId.  Previously, this seemed to work because PairRDDFunctions.saveAsNewAPIHadoopDataset didn't go through the OutputCommitCoordinator (!!! can this be right?)  and PairRDDFunctions.saveAsHadoopDataset, which did go through the OutputCommitCoordinator, always used the actual stageId (it didn't do any setup before the stageId was available).  e.g here's the code in 2.0: https://github.com/apache/spark/blob/branch-2.0/core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala#L1161
The RDD alone is not a good unique identifier -- the same RDD can get saved to hadoop multiple times, and those could even be run in parallel.  We need to make sure those tasks don't get mixed up with each other.

Its actually quite hard to get the right stageId.  Its not exposed at all to the user before the job starts.  In fact, we can't expose the stageId before your call to sc.runJob(), because there could other threads racing to submit jobs, and the stageId isn't known until its inside the DAGScheduler's eventLoop here: https://github.com/apache/spark/blob/4f8dc6b01ea787243a38678ea8199fbb0814cffc/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L866

One way to do this would be to add another version of sc.runJob() which let you pass in yet another function, which is run inside the DAGScheduler after it has the stageId.  I don't even think we should expose that function publicly, we just need it inside inside PairRDDFunctions.
Another possibility would be to forget about the actual stageId, and instead just get some unique id from the OutputCommitCoordinator, which is then passed along inside the closures.  But then you'd have to figure out how to replicate OutputCommitCoordinator.stageStart() / stageEnd(), which probably boils down to the same thing -- another version of runJob, this one which pushes the given ID down into the scheduler.
Any other ideas?
@tgravescs @markhamstra you may be interested in this as well.  I know you've told me you've had success w/ speculation lately, but seems like it would be pretty broken given the rddId vs. stageId (or maybe it doesn't matter b/c in most cases the Hadoop output committer ignores the jobContext passed in on setupJob?)

I haven't seen any issues with speculation, most people aren't on 2.2 yet though either.   Unfortunately won't have time to look at this today in detail, will try to early next week.

also @mridulm I think you worked on the committer protocol before, both in spark and MR, so would be great to get your thoughts.

Test build #83976 has started for PR 19388 at commit 500c73c.

High level question: do you need to create the commit id based on the rdd + stage ids, or could it be something else (like a monotonically increasing value, or a uuid)? That would probably simplify the code.

Test build #83976 has finished for PR 19388 at commit 500c73c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StageInfo extends Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83976/
Test FAILed.

Retest this please.

Test build #84002 has started for PR 19388 at commit 500c73c.

Test build #84002 has finished for PR 19388 at commit 500c73c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class StageInfo extends Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84002/
Test FAILed.

Test build #84006 has started for PR 19388 at commit 66192fd.

Thank you very much, @dongjoon-hyun. I forgot to pushed the fix for streaming failure.
@vanzin My understanding based on reading the code before this change is that the logic behind it avoids multiple committing of a single stage. So I think based on that logic it should use stageId somehow.

Test build #84006 has finished for PR 19388 at commit 66192fd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84006/
Test FAILed.

Jenkins, retest this please

Test build #84033 has started for PR 19388 at commit 66192fd.

Test build #84033 has finished for PR 19388 at commit 66192fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84033/
Test PASSed.

I agree with @vanzin - this looks very complicated for a enforcing a fairly simple constraint.
It would be easier to depend on a AtomicInteger in driver for the id - and propagate that to executors via Configuration (so that driver and executors use the same id).
Will that not be simpler @rezasafi  ?

Thank you very much, @mridulm for the comment. Yeah, I agree that the provided solution is complex. The complexity came form the fact that in this solution both executors and the driver use a jobId that is based on the stageId. I tried a simpler solution in October that uses rddId as a unified Id between drivers and executors, but that solution failed since committer was expecting a stageId as the jobId. Let me discuss this with more details.
In the current code there is a call to commitTask (the taskContext here is created by using stageID as the jobId):
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/io/SparkHadoopWriter.scala#L134
That call will ended up reaching here:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala#L172
This will follows to the following point:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/mapred/SparkHadoopMapRedUtil.scala#L73
Which will call canCommit and canCommit will check whether the jobId is an actual stageID:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala#L89
If we want to use a simpler solution for creating the jobId based on a monotonically increasing value then we need to make some changes in other parts of the code to remove the need for using a stageId. I need to check whether this will actually create a simpler fix (especially with regards to SPARK-4879).
I will update here as soon as I finished investigating this. Thank you again.

Internally, spark can continue to use stageId for its commit protocol - which is independent of what we expose as jobId to mapred/mapreduce committer.
As an implementation detail, we were making using of stageId in executor and rddId at driver.
Spark does not really care about what is presented to hadoop committer, and hadoop committer does not really care about what spark is using internally; as long as both are used consistently.
Will not that help make things simpler ? Or am I missing something here ?

@mridulm thank you very much for the comment. I was thinking about something similar, but more like sending both stageID and a monotonically increasing jobId to the commit method and then let try the canCommit use the stageId while we use the jobID for hadoop commits. I am testing this right now.

I am closing this PR in favor of another one with a simpler approach that I will open shortly. Thank you everyone for the comments, here.

The new PR is here:
https://github.com/apache/spark/pull/19848


[Draft] Fix target group leaking issue

Changed model_build_targetgroup and model_build_service, make sure target group deletion request model triggered by httproute deletion could pass to target_group_synthesizer correctly

Changed lattice resource creation and deletion order. move delete latticeSerivce and delete Targetgroup logic in the in the corresponding PostSynthesize() - New LatticeResource creation order when receive httproute creation request: TargetGroup -> Targets -> LatticeService -> Listener -> Rule

New LatticeResource deletion order when receive httproute deletion request: LatticeService (vpc lattice backend will asynchronous delete its listeners and rules ) ->  TargetGroup(target_group_manager.go layer would check and deregister targets for this target group)

What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

83 of 111 (74.77%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 32.836%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/deploy/lattice/target_group_synthesizer.go
58
69
84.06%

pkg/deploy/lattice/target_group_manager.go
2
19
10.53%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
3347

Relevant Lines:
10193

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

82 of 104 (78.85%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 32.836%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/deploy/lattice/target_group_manager.go
4
15
26.67%

pkg/deploy/lattice/target_group_synthesizer.go
54
65
83.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
3344

Relevant Lines:
10184

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

82 of 104 (78.85%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 32.836%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/deploy/lattice/target_group_manager.go
4
15
26.67%

pkg/deploy/lattice/target_group_synthesizer.go
54
65
83.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
3344

Relevant Lines:
10184

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

91 of 104 (87.5%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 32.924%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/deploy/lattice/target_group_manager.go
13
15
86.67%

pkg/deploy/lattice/target_group_synthesizer.go
54
65
83.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
3353

Relevant Lines:
10184

💛  - Coveralls


Does not bump release and reports incorrect exit status code when deploying against an overloaded VM

Describe the bug
Given a VM whose resources are overloaded (for us, 100% memory and swap that climbs to 100%), a deploy of a new release will

Not update the VMs to use the newest release
Update the bosh releases result to claim that the deployment uses the "newly deployed" release
Claim the deploy Succeeded

To Reproduce

Have a current deployment that has over-utilized its VM resources (something that leaks memory is a good replicator here). This src code should log out its SHA in the job logs for future proof.
Change something in the release and commit to update the git SHA
bosh -e <env> ur <broken-thing> --rebase and see new SHA listing under bosh releases but not astrisk - still unused
Deploy with new version listed in manifest
The deploy will "succeed"
See bosh releases will have updated the deployment's reference to be using the new version with your different SHA.
bosh -e <env> -d <broken> ssh whatever/0 and check the logs - they will report that the VM is still running the old release (see step 1 and logging of real release SHA).

Expected behavior
That the director will inform us if there are not enough resources on the box to deploy the latest code. It will throw a real error exit code if unable to update the version running.
Versions (please complete the following information):

Infrastructure: AWS
BOSH version: 268.6.0
BOSH CLI version: 5.4.0
Stemcell version: bosh-aws-xen-hvm-ubuntu-xenial-go_agent/250.38

Deployment info:
Can be contacted for shared environment info.
/cc @toddboom

Update: working on getting an example release I can drop here for replication. But in the meantime - this was a version update that only rolled 2 vms on a 6 vm deployment and reported Succeeded.

We ssh'd onto the boxes and looked at logs where we were reporting the sha of the code we were using and they were out of sync.

Where all 6 instances part of the same instance group? The director compares the new manifest against the instance state recorded in its database to determine which instances need to be updated - the deployment should try to update all instances that need that release (and log that it's Updating instance for all 6, before potentially failing on a unresponsive vm.
The debug task log should have entries for detected package changes on each instance. Can you search for entries like:
@logger.debug("#{method_sym} changed FROM: #{old_state_msg} TO: #{new_state_msg} on instance #{instance}")
@logger.debug("Need to update instance '#{instance_plan.instance}', changes: #{changes.to_a.join(', ').inspect}")
@logger.info("Found #{instance_plans.size} instances to update")


PROD-528: Mystery box improvements

Adds a scrollbar so the content is accessible on small screens.
Add space between the button and total winnings.
Fixes the background of the treasure chest image.

I merged in PROD-538. Please re-review.

Behavior looks good to me. To continue the Linear convo, can you clarify why the chest still has some weird specs and rough edges? Are they really part of the image in Figma? I didn't see when I pasted into gimp.

No they are not part of the image; I did a second export (as PNG) which still has the artifacts. I also removed the margin which might have also introduced noise. Anyway, the solution is using the source SVG.

Anyway, the solution is using the source SVG.

Should that be part of this PR? Or maybe it's moot because of the animation work that is in flight? I haven't fully looked at that yet.

I left it out since the other PR is in flight (seems like it needs more work though...)


feat: Add GitHub covid finder to OSS-PORT projects

CHANGES
Add project to list

Thank you so much for adding Github Covid Finder, @luisFilipePT
This looks wonderful! The Map is also so thoughtfully laid out.
Welcome aboard!

Thanks, I added a plain map and next I will update it and make it look prettier :)

Ah! Disregard my last comment, please. Sounds great! Looking forward. Do give me a shout if I can help with that!


{1.19.2} EMI Fill recipe does not accept Gregtech tools unless they are full durability

When trying to craft a part that requires GT tools (bolts need a steel file for example), pressing fill recipe will put the steel rod required but the tool will not be placed in the crafting GUI unless it is full durability.

I know this is a bit of a band aid fix, but a third party mod called GregTechCEu Modern, fixes this issue and a bunch of others! <3

Heya! Are you by any chance using "Tom's Simple Storage Mod"? I've tested AE2 and Vanilla crafting guis and they work as intended, however Tom's STM does NOT work as intended and instead acts as you describe.

Yeah, as far as my testing goes, catalysts work correctly in EMI for standard recipe handlers, this would be something going wrong with an implementation.

It was indeed Tom's Simple Storage, thank you for the reply!
On Sat, Aug 31, 2024 at 9:02 PM Emily Rose Ploszaj @.***>
wrote:

Yeah, as far as my testing goes, catalysts work correctly in EMI for
standard recipe handlers, this would be something going wrong with an
implementation.
—
Reply to this email directly, view it on GitHub
https://github.com/emilyploszaj/emi/issues/670#issuecomment-2322995990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3OEH76PB2F7YTTDWOGGXITZUIAKHAVCNFSM6AAAAABMWIFQQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHE4TKOJZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Convert All sections tree to use TreeBuilder

Convert all_sections_tree to use TreeBuilder.
Compute -> Infrastructure -> Virtual Machines -> select two or more -> Configuration -> Compare Selected Items
Before/After: Should be same.
@miq-bot add_label wip, technical debt, ui

@miq-bot remove_label wip

Verified in UI.


Coerce cell id to str

When running the script to_zarr.py for the xenium datasets one can run into an error which is due to a string accessor being used while the column cell_id is of type int. This PR fixes the issue by coercing to str.

Codecov Report

Merging #64 (f3780ee) into main (f259441) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   41.96%   41.96%
=======================================
  Files          16       16
  Lines         853      853
=======================================
  Hits          358      358
  Misses        495      495

Impacted Files
Coverage Δ

src/spatialdata_io/readers/xenium.py
33.33% <0.00%> (ø)

Thanks for the fix!


[whisper.cpp] some repeated sentences were shown in real-time English subtitle for English online-tv

I'll upload a short video to illustrate this issue.

I have no Google Pixel phone. it'll very helpful if anyone could help to temporally provide a Google Pixel phone for purpose of software development activity,

PR from real/hardcore AI expert is greatly welcomed because source code of whisper.cpp and JNI layer are both open-sourced in this project.


[GLUTEN-4108][VL] Fix build & runtime error when vcpkg is on in debug mode

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4434_time.csv
log/native_master_02_04_2024_d1b29e1bc_time.csv
difference
percentage

q1
32.12
33.68
1.560
104.86%

q2
24.56
24.23
-0.333
98.64%

q3
37.85
37.37
-0.478
98.74%

q4
37.76
35.96
-1.796
95.24%

q5
70.00
70.39
0.392
100.56%

q6
7.20
6.99
-0.210
97.09%

q7
82.84
84.51
1.667
102.01%

q8
85.89
84.14
-1.755
97.96%

q9
123.23
121.28
-1.945
98.42%

q10
42.57
43.47
0.899
102.11%

q11
20.10
20.46
0.362
101.80%

q12
29.01
26.23
-2.779
90.42%

q13
45.42
45.25
-0.176
99.61%

q14
20.51
15.93
-4.589
77.63%

q15
27.49
26.74
-0.754
97.26%

q16
14.38
14.11
-0.268
98.14%

q17
102.58
102.75
0.177
100.17%

q18
149.17
148.66
-0.511
99.66%

q19
12.36
13.50
1.133
109.16%

q20
27.47
26.71
-0.764
97.22%

q21
222.57
221.36
-1.207
99.46%

q22
14.93
13.64
-1.291
91.35%

total
1230.04
1217.37
-12.666
98.97%


add a conditional to early return if the swiper controller is destroyed

Fixes to address this issue #6552
I did some debugging to fix this bug and found a solution.
Check if the swiper controller is destroyed before the setTranslate, setTransition functions run.
In other PR, the above two functions are executed and checked for destruction within the setControlledTranslate and setControlledTransition functions, but I think it would be nice to check for this in advance to avoid running unnecessary logic.
This is my first open source PR. Feedback is always welcome.

Merged, thank you!

Thanks!


[Samples][25.message-reaction] Migrate Properties folder

Fixes #
Description

Specific Changes

Testing

Be careful, you are pointing to the wrong branch


Windows client defaulting to FIPS mode

Description
The Windows client appears to be defaulting to FIPS mode on.
Chef Version
12.19.36
Platform Version
Windows Server 2012R2 64-bit
Replication Case

Install Chef Client for Windows Server 2012R2 x86_64
Ensure there is nothing mentioning FIPS in C:\chef\client.rb or C:\chef\client.d\* (findstr /I fips C:\chef\client.rb)
Run: C:\opscode\chef\bin\chef-client

As a side note, the fips-enabled-by-default situation causes an openssl exception if you happen to be running the x86 chef client on an x86_64 box and chef-client won't even run. In the case here, where the x86_64 client is being run on an x86_64 box, FIPS mode is attempted and works, but should not be the default as far as I can tell.
Client Output
...
OpenSSL FIPS 140 mode enabled
...

per #5507 does the System\CurrentControlSet\Control\Lsa\FIPSAlgorithmPolicy registry key exist, and if it does, is Enabled=1 in there? We definitely don't default to FIPS mode on, and we run extensive tests to ensure that the chef client runs correctly.

Thanks. Yes, it turns out that key is set to 1. Off to find out who did this. Closing.


Remove the panic()'s

There are a few places in Gorgonia where we panic on errors instead of returning meaningful errors. for most (all?) these cases, we can probably return meaningful errors instead. This is a non-trivial amount of work, as the signature of the panic-ing functions will change, so some work needs to be done for to adjust those functions and all places where those functions are called.

Which functions do you have in mind? I don't mind changing the function signatures if it means better error reporting to the user. I do think that NewNode() and exported functions that directly creates new nodes (that is to say, not part of operations.go) should panic if they fail.

I can go about making a list of all the functions which panic. Some times it does make sense to panic, so I think it would require some consideration for which functions would need to return an error and which would actually must panic.

Agreed.

Is there still appetite for this? I wouldn't want to change function signatures at this point, but it would be great to not have to worry about panics when using gorgonia in a larger app


Qcodes driver fix

qua_program replaced by a field
numpy import fix

Hey @yomach, this relates to this issue, is it what you had in mind?

I'm not sure. Since we didn't reproduce the issue locally I don't know if this fixed it. We can try to ask the author of that issue in the ticket. I'll ping him

Here we are waiting for the response from the guy who asked for the PR.
I won't merge until he approves and I just rebased it on the new version, sorry for the useless notification...
Envoyé à partir de Outlook pour Androidhttps://aka.ms/AAb9ysg

From: Yoav Romach @.>
Sent: Thursday, April 18, 2024 7:08:10 PM
To: qua-platform/py-qua-tools @.>
Cc: Theo Laudat @.>; Author @.>
Subject: Re: [qua-platform/py-qua-tools] Qcodes driver fix (PR #190)
@yomach commented on this pull request.
Changelog?
—
Reply to this email directly, view it on GitHubhttps://github.com/qua-platform/py-qua-tools/pull/190#pullrequestreview-2009450646, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXR3HVT7QHPXUWQMO3KXHE3Y574XVAVCNFSM6AAAAABE5EIYI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBZGQ2TANRUGY.
You are receiving this because you authored the thread.Message ID: @.***>


Add native support for Silent Authentication

Adds Silent Authentication support. In addition to adding an auth0-silent-auth authenticator, this also adds a few flags to enable automatic token renewal in various ways.
This is all opt-in via environment.js, so here's an example configuration hash with all the various options enabled:
// config/environment.js
module.exports = function(environment) {
  let ENV = {
    'ember-simple-auth': {
      // ...

      auth0: {
        // ...

        silentAuth: {

          // automatically renew token every 30 minutes:
          renewSeconds: 1800,

          // automatically renew token when trying to restore an expired session (on app load):
          onSessionRestore: true,

          // automatically renew token when token expiration time is hit (during app use):
          onSessionExpire: true,

          // options to pass to checkSession when doing automatic silent auth.
          // The redirectUri parameter is automatically set to window.location.origin
          // if not specified.
          options: {
            responseType: 'token id_token',
            scope: 'openid profile email',
            timeout: 5000
          }
        }
      }
    }
  };

  return ENV;
};

I'm not super-attached to the renewSeconds name, so feel free to suggest alternatives. Or any in general -- naming things is hard!

@XaserAcheron sry for disturbing, I tried to make the change as described in your comment but it seems not to work atm in my application. I set the JWT token to be expired in 30s in the dashboard to make it easier to test, but it keeps logout after the token is expired. Here is the configuration in my environment.js:
'ember-simple-auth': {
      authenticationRoute: 'login',
      auth0: {
        clientID: AUTH_CONFIG.clientId,
        domain: AUTH_CONFIG.domain,
        logoutReturnToURL: '/logout',
        enableImpersonation: false,
        silentAuth: {
          renewSeconds: 30,
          onSessionRestore: true,
          onSessionExpire: true,
          options: {
            responseType: AUTH_CONFIG.responseType,
            scope: AUTH_CONFIG.scope,
            timeout: 5000,
            redirectUrl: AUTH_CONFIG.redirectUrl,
            redirect: AUTH_CONFIG.redirect,
          },
        },
      },
    },

any pro tips ? thanks

Which version of the addon are you using? The Silent Auth feature is currently only available in the 4.2.0-alpha releases, so that might be it.

The current version that I am using is 4.2.0-beta.4, I will try to change it into 4.2.0-alpha. Thanks for the response @XaserAcheron

Sorry, typo -- I should've said beta -- that's the correct version.
I'm not sure what else to suggest offhand -- sorry.

I made the changes in environment.js as described in your first comment @XaserAcheron but it did not run. Please consider to check on this issue #160 for more detail.


username color

I am sure this has been asked before but i am having trouble figuring it out.  I am new to coding and just playing around trying to figure things out but i got everything connected got the user name and message.  But i wanna get the username color that is applied from twitch and apply it to the chat box to help sort out whose messages are who instead of seeing all one color.  I know i could set it to random a color per user but  was not sure if i could pull the one they had set through twitch itself.
Any examples or leads on this i would extremely appreciate!

I think the ChatMessage object actually has a System.Drawing.Color object associated with it.
So to set the background color of the textbox, it'd be something like
Actually there's an example of it being done in the Example project:
https://github.com/swiftyspiffy/TwitchLib/blob/master/TwitchLibExample/TwitchLibExample/Form1.cs#L272

I actually just figured this out... I got it to connect to each chat line and update.
        chat.SelectionColor = e.ChatMessage.Color;
        chat.AppendText(e.ChatMessage.Message);
        chat.AppendText(Environment.NewLine);

not sure if this is proper code but it works to what i am looking for.
Thanks for the help @swiftyspiffy

Looks fine to me! I haven't worked a lot with the SelectionColor property, but it seems correct!
No problem. Shall I close this?

I am noticing some colors are not showing up but i am gonna find a workaround..

Yup, because some users don't have an assigned color for one reason or another, the e.ChatMessage.Color property can be null, representing a lack of color specified.
What I would do is something like this:
if(e.ChatMessage.Color != null) {
    // Assign the color that Twitch says is their chat color
    chat.SelectionColor = e.ChatMessage.Color;
} else  {
    // Assign a random color since Twitch didn't specify a color.
    Random ran = new Random();
    chat.SelectionColor = Color.FromArgb(ran.Next(256), ran.Next(256), ran.Next(256));
}
chat.AppendText($"{e.ChatMessage.Message}\n");

I actually just did something similar to this. But since i don't know code i am just doing little statements to find out what does what lol.  I am trying to figure out now how to strip it out of the whole code and just do the names and not the message.
Other bug i see i have is if i highlight a message the next message i receive while highlighting another message will update all messages to that color. -_-
This is fun though learning as i play around with what does what.

Gotcha, ya I don't know a ton about the (I assume you're using) RichTextBox, you may actually need to create your own UI component to accomplish what you're trying to do, maybe not.
Anyways, good luck and of course have fun! (I'll close this issue, but feel free to keep commenting on it)

So been playing around with the code a bit and i put it in run by line mode cause it didn't feel like it was working and for some reason even if the color is not null it still only ran the first if and not else..

I'm not quite sure I understand what you mean by "run by line mode".

oh they are called "breakpoints" lol my bad -_-


8/12/20 Patch Releases

Bump to the new upstream patches and release.
Summary:
Task covering 8/12 Patch releases work.
List of required releases:
To release as soon as able:
v1.16.14-rc1+k3s1 (just for typical testing)
v1.17.10-rc1+k3s1 (RC needed for KDM testing in Rancher)
v1.18.7-rc1+k3s1 (RC needed for KDM testing in Rancher)
To release once have approval from QA:
v1.16.14+k3s1
v1.17.10+k3s1
v1.18.7+k3s1
Prep work:

[x] EIO team notified of 8/12 releases
[ ] PM and QA review changes and understand testing efforts
[ ] Prep PR for rancher/k3s (update stable channel) PR TBD
[x] FORK rancher/kontainer-driver-metadata (and bump v1.17 and v1.18 RC versions for QA to test KDM) data.json
[ ] Prep PR for rancher/kontainer-driver-metadata (bump v1.17 and v1.18 release versions)
[ ] Release Notes prepared

Vendor and release work:

[ ] Vendor in new patch versions into the appropriate branches and release
[ ] PM needs to provide release notes
[ ] Merge PR for rancher/kontainer-driver-metadata into the dev branches

Post-Release work:

[ ] Merge in channel server change (to mark v1.18.7+k3s1 as stable)
[ ] Merge in rancher/kontainter-driver-metadata change to release branch (so new v1.17 and v1.18 patch versions are shown in Rancher UI)

We've decided to NOT fix the arm64 airgap problem today. Here is why: the images that we would need to repush are also used by RKE. To safely ensure we dont break production, we need to have a more methodical and thorough approach that encompasses testing both RKE and K3s. Please refer to https://github.com/rancher/k3s/issues/1285#issuecomment-672977890 which talks about this in more detail. That issue is being used to track the airgap image issue with ARM and AMR64.

Note, due to a late start in upstream k8s releases and v1.16 lagging behind (still not started) we will likely pick this up tomorrow and plan to release by 8/13 end of day.

Updated my comment above to point to new v1.17 and v1.18 release issues.
There were technical issues with getting upstream v1.17.10 and v1.18.7 out. As such, the sig-release team has made a call to just tag new versions for v1.17 and v1.18. We'll instead be releasing with v1.17.11 and v1.18.8

All release efforts done!
This issue will stay open for a while as we assess the state of the patch releases from the community. When we are comfortable, we'll mark v1.18.8+k3s1 as stable in the channel server for K3s.