Merging from main to dev

Changes snuck through to main

I don't think this is needed, no changes and the Network Graph looks like it's including all changes in both branches.

main is a commit ahead of dev

The only commit it's behind is a merge from "dev" (what used to be "development") to main.

I'm guessing you created dev from development at it's latest commit, so essentially you just re-named the branch. So this is only adding a reciprocal commit back to itself. It won't cause any issues, but it's not needed.

I understand that it is trivial. I'm just unsure why you would want main a commit ahead of dev unless hot fixing

After every sprint, when we merge to main from dev, main will always be a commit ahead, the merge commit. That's just how the branching works the way we've set it up. The only time we should be merging from main to dev is when there is a hot fix.


require spec in managed types

Description of your changes
https://github.com/cncf/crossplane-conformance/pull/22#pullrequestreview-684673410
The spec field is required in managed types by the Crossplane Provider Conformance tests.
This change updates the provider to match that expectation.

Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[x] Updated any relevant documentation, examples, or release notes.

Is there any chance folks were somehow using these resources successfully without a spec? Usually I find the answer to this is "no" because the resources in question aren't functional without some field or the other under spec.forProvider.

Thanks. In this case each of the resource types requires at least one piece of the spec to be meaningful.
The Crossplane documentation on importing existing resources says that both the external-name and any required spec fields must be provided to import the resource, so I assume this change is safe even for import use-cases.


Reviewer's note cannot be applied to an item list

If a reviewer's note applies to an item list, it doesn't get rendered properly:

Bullets get mixed up when setting anchors like in the example below.

[[c1]]Data can be classified as one of the following:

. Unclassified;
. Restricted;
. Confidential.[[d1]]

[reviewer=rev,from=c1,to=d1]
****
comment
****

Comment doesn't get shown when setting anchors like in the example below.

[[c3]]
Data can be classified as one of the following:

. Unclassified;
. Restricted;
. Confidential.
[[d3]]

[reviewer=rev,from=c3,to=d3]
****
comment
****

 is meant to be converted within Word processing to
. The present of the review comment introduces a  wrapper, which is disrupting that conversion: we are ending up with

a)
Unclassified;

instead of

a) Unclassified;

My apologies for taking so long to get to the second issue.
The second case is simply not legal markup at the moment: the standalone line [[d3]] at the end of the list is attached to the next meaningful element, which is the comment itself, so the comment ends up recursive and confused.
If there is any intervening text between the comment end anchor and the comment, things are fine:
[[c3]]
Data can be classified as one of the following:

. Unclassified;
. Restricted;
. Confidential.

[[d3]] text

You are trying to get the anchor to apply up to the end of the list. For that, just put the end anchor at the end of the previous line. It's the standalone line at the end of the list that is the problem. (And that is an issue internal to Asciidoctor's own parsing—including having it attach to the next block. The bookmark is never even seen by Metanorma.)
[[c3]]
Data can be classified as one of the following:

. Unclassified;
. Restricted;
.


Swagger ingest api doc

I suggest we either review when we can or once we update to the latest springfox version (3.0.0, currently 2.9.2) to address the issue mentioned in the doc https://docs.google.com/document/d/1x6qOQ_u6GoMzTYyK7u5hffmOiHkY9fOLYuMq7BiHOQw.

This PR will have to be re-merged due to issues on master.
#88


server listener

TO DO

[ ] stop function
[x] uncomment:

	for {
		//conn, err := l.Accept()
		_, err := l.Accept()
		if err != nil {
			log.Fatal(err)
		}

Lot of things, don't close this PR until something useful appears
Now it does something :+1:

Stop function unimplemented but ready for develop


Refactor

In this PR, we did the following:-

Made sure that YAGNI, KISS, and DRY rules and Ruby style guide are respected.
Followed SOLID principles.
refactored main. rb to only start the app and ask the user for the initial choice of options (or to quit).
Extracted some pieces of logic into separate option class

@rotimiazeez  Thank you for reviewing our PR and providing valuable feedback 👍

@Olamarx  Thank you for reviewing and approving my PR


Support Apache Tika for RAG text extraction

Currently, document attachments for RAG are parsed using by selecting from a grab-bag of document loaders from the LangChain community set. While this avoids the need for external services, the supported file type set is small, the results are not always high quality in terms of output order and spacing, and it doesn't support valuable features such as OCR.
It would be great if Open WebUI optionally allowed use of Apache Tika as an alternative way of parsing attachments.
Tika has mature support for parsing hundreds of different document formats, which would greatly expand the set of documents that could be passed in to Open WebUI. It also has integrated support for applying OCR to embedded images, so for instance text extraction from a PDF that is made up of scans of pages "just works".
Importantly, useful installations of Tika are available as completely self-contained Docker images with a REST interface, including versions with bundled Tesseract OCR, making deployment as part of a docker-compose.yml very easy.
Supporting Tika would involve providing a configuration option to let the admin set a Tika service URL and then fixing up backend/apps/rag/main.py to offload most of the text extraction work to Tika if this variable is set.

I believe the new Filter function should enable this use case. I'd love to collaborate on this if you're interested!


feat: wrap TxDeposit into Sealed in OpTxEnvelope

Motivation
ref https://t.me/paradigm_reth/36099
Makes envelope more consistend as with this change all variants hold a hash
Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

blocked by https://github.com/alloy-rs/core/pull/805


Add args to joinMonster function similar to context

There are instances where we would like to change the args passed in before calling joinMonster so the where clause gets the correct args. Stuff like changing an argument to match something in context, pre-esacping/trimming args etc.
joinMonster(resolveInfo, args, context, sql => { return knex.raw(sql) }
This would allow for better separation of duties. Currently we have to perform these things in the where clause itself or attach the cleaned up args in context, which really isn't a smooth way.

Perhaps wrap joinMonster like described here?

We ended up righting a function similar to combineResolvers from https://github.com/lucasconstantino/graphql-resolvers so we can just wrap any resolver and change the args before continuing. Similar to what's described there just a little more plug and play.
// Alters function arguments by passing them down each time
// It's like piping but for arguments instead of results
// Each function should have the same argument list and return array of arguments for the next
const alterArguments = (...funcs) => (...args) => funcs.reduce(
  (prevPromise, resolver) => prevPromise.then(
    nextArgs => {
      return resolver(...nextArgs)
    }
  ), Promise.resolve(args)
)

You can use it like:
function cleanupWhereUsers (table, args, context) {
  const newArgs = { ...args }
  newArgs.search = newArgs.search.trim()

  return [table, newArgs, context]
}

const metadata = {
  Query: {
    fields: {
      users: {
        where: alterArguments(
          cleanupWhereUser,
          (table, args, context) => { ... }
       )
    }
  }
}


Add CompareConverter

Documentation added for .NET MAUI Community Toolkit proposals:

[Proposal] CompareConverter  https://github.com/CommunityToolkit/Maui/issues/55

Docs Build status updates of commit 49f8e95:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/compare-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit 75a1c07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/compare-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.

Docs Build status updates of commit f9a4120:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/compare-converter.md
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.


Refactor Pathway class

This PR refactors the Pathway class.  It changes the following:

Add .dims attribute to Pathway. This simplifies a bunch of site transformations that before depended on passing a volume
Add method to calculate Pathway total length
Move frac_sites / wrap to methods that return sites instead of in-place updates
Pathway.path_over_structure returns list of PeriodicSite which simplifies return statement and gives more options to user
Move some plots to methods of Pathway
Streamlines creation of Pathways object from Volume
Path plots no longer needs Volume because Pathway now has dims
Rename path functions to hopefully make them a bit more consistent

Todo

[x] https://github.com/GEMDAT-repos/gemdat-notebooks/pull/11

Hi @SCiarella could you review this pr please? It may seem like a bit much, but I think it is easiest to start with the Pathway refactor, most of the other changes follow from there. And then Volume next. Changes to both classes enabled a bunch of other small changes and corrections that I included (e.g. plots).


How to install with "googleads/googleads-php-lib": "^40.0"?

I have another package installed which uses "googleads/googleads-php-lib": "^40.0". How do I install Edujugon/laravel-google-ads with  "googleads/googleads-php-lib": "^40.0" instead of [37.0.0, 40.0.0]?
PS: I really like your package.

Hi @imkevinabraham ,
I will try to get some time this weekend to upgrade the "googleads/googleads-php-lib" dependency to the latest version. after that, you shouldn't have conflicts.

thanks @Edujugon. That would be awesome! I really like your package and want to use it in my app

Hey @imkevinabraham ,
Could you paste here the error you get when trying to install the package?

Hey @Edujugon
$ composer require edujugon/laravel-google-ads
Using version ^1.6 for edujugon/laravel-google-ads
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install edujugon/laravel-google-ads 1.6.2
    - Conclusion: don't install edujugon/laravel-google-ads 1.6.1
    - Conclusion: remove googleads/googleads-php-lib 40.0.0
    - Installation request for edujugon/laravel-google-ads ^1.6 -> satisfiable by edujugon/laravel-google-ads[1.6.0, 1.6.1, 1.6.2].
    - Conclusion: don't install googleads/googleads-php-lib 40.0.0
    - edujugon/laravel-google-ads 1.6.0 requires googleads/googleads-php-lib ^37.0 -> satisfiable by googleads/googleads-php-lib[37.0.0, 37.1.0].
    - Can only install one of: googleads/googleads-php-lib[37.0.0, 40.0.0].
    - Can only install one of: googleads/googleads-php-lib[37.1.0, 40.0.0].
    - Installation request for googleads/googleads-php-lib (locked at 40.0.0) -> satisfiable by googleads/googleads-php-lib[40.0.0].

Installation failed, reverting ./composer.json to its original content.

Hey @imkevinabraham ,
I've created a new branch that will bypass that error. My idea for the future is to remove googleads as package dependency and make the user to install it as their own dependency.
I still have to update the read me and think about how to make it as smooth as possible for future releases. So until I manage to do so I suggest you to install this package as the following:
composer require edujugon/laravel-google-ads:"dev-feature/googleads-dev-dependency"
Make sure you have googleads/googleads-php-lib installed as dependency or this package will fail...Anyway you don't have that problem since you already have it installed via laravel-adwords-targeting-idea-service package...
I will update you after the release so that you can then point to that in the future.
Let me know if that worked for you

@Edujugon thank you very much! this fixed the install problem.
Sounds like a great idea for a future release

Glad that helped 😊


[T2A5][T11-A3]Tan Te Juin Lester

Add sort method to sort ALL_PERSONS
Make search case-insensitive

Ready for review

Nice way of implementing case insensitivity for search! Remember to update the test and user guide as well. Good use of lambda expression for sorting:) The method can still be refactored as discussed in class and sort doesn't seem to be a command that users can use though...


libz blitz: turn references to other semver items into links

Rebase pull request #143 on master

Hey!
I was looking through the documentation on lib.rs, and I would really like to turn all references to the semver spec (or the spec) into links as well. Sections 7 and 8 are mentioned.
I also note that you are using rustfmt which introduces quite a bit of changes outside of documentation. I don't think it's unusual to hook rustfmt into your editor, so I've opened #147 to try to address this.

@muzikmoe it's in conflict again. Do you mind if I rebase your change without reformatting?

@opilar that's ok, do whatever you want to do.

I've merged in the rebased version. Thanks so much!


Does the XPath value support pulling the thumbprint from the Certificate tag?

Hi engineer,
According to this document, we can see the supported XPath values to expose role configuration settings as an environment variable.
https://docs.microsoft.com/en-us/azure/cloud-services/cloud-services-role-config-xpath
May I know is that all the supported values? Since we cannot pull the thumbprint from the Certificate as follows:

Any advice and comment would be highly appreciated!
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2885416c-371d-f65e-4369-b839c4555365
Version Independent ID: 4efa8b23-8f05-cf96-6002-11c81926d113
Content: Cloud Services Role config XPath cheat sheet
Content Source: articles/cloud-services/cloud-services-role-config-xpath.md
Service: cloud-services
GitHub Login: @tgore03
Microsoft Alias: tagore

RoleInstanceValue xpath="/RoleEnvironment/CurrentInstance/Certificates/Certificate[@name='Default']/@thumbprint" />

@xuwenjian1995 -
Thanks for brining this to our attention. We will investigate it further and update you shortly.

Thanks @MonikaReddy-MSFT, I really appreciate your investigation and I am looking forward to your response.

@xuwenjian1995 - I have reached out to Product team and waiting their response. Will get back to you as soon as I hear back from them. Thank you for your patience.

@MonikaReddy-MSFT -Thanks for your update. awaiting your good news!

@xuwenjian1995 - I'm going to assign this to the document author so they can provide the details accordingly.

Hey @tanmaygore, do you know the answer to this? I've assigned myself to it so it doesn't get lost.

Hi @xuwenjian1995,
Yes the values listed in the doc you've linked are the supported values. The xpath-visible values are prefaced with \RoleEnvironment and that wrapper doesn't support any path to the certificate config info. Thanks for the issue, I'll now close this issue.


Revert "soc: intel: renamed soc from ace30_ptl to ace30"

This reverts commit a654bfbdfa002ac5ab32d8593d762f5ef3dc4868.
This commit broke Zephyr CI, as both the platform name and SOC kconfigs are used in the SOF module which would also need an update. Doing such an update is out of scope for a hotfix.
Fixes #78931

For some reason GH won't let me add the original author of those, @gbernatxintel as a reviewer...

For some reason GH won't let me add the original author of those, @gbernatxintel as a reviewer...

It's because of the 15-reviewer limit.

we have a proper fix: https://github.com/zephyrproject-rtos/zephyr/pull/78932

Closing as not needed


connector/oidc: fix hosted domain support.

fixes #999

May also fix the example:
https://github.com/coreos/dex/pull/974#discussion_r128779469
:)

So quick thought on this.
The hosted domain concept is Google specific, not related to OpenID Connect. There are a ton of features that have been requested that apply to Google and aren't applicable to general oidc providers (e.g. groups support). Why arent we just split this into a unique "google" connector instead of pushing Google features into the oidc connector?

Created a new issue for this (https://github.com/coreos/dex/issues/1001). Closing out this PR

But... This feature is still broken... Better remove it then, I believe. :)
@ericchiang
@rithujohn191

New plan....going to fix this feature for now and then in the next release pull it out into its own Google connector :)

@ericchiang if this looks ok could you approve the PR? Thanks

@rithujohn191 I was just wondering how soon a release could be cut with this in it? I have a need to restrict logins to a certain gsuite domain. Thanks!

@rubbish this won't help you. Notice this sentence from the Google oidc documentation:

Don't rely on this UI optimization to control who can access your app, as client-side requests can be modified. Be sure to validate that the returned ID token has an hd claim value that matches what you expect (e.g. mycolledge.edu). Unlike the request parameter, the ID token claim is contained within a security token from Google, so the value can be trusted.

It may be worthwhile to emphasize this in dex as well.

@alonl This PR does check the hd claim in the id token: https://github.com/coreos/dex/pull/1000/files#diff-dbaa70d509cfdb00b729984f27415946R201 So it would validate for those configured hosted domains.

Oh, you're right. That's just the issue I reported myself. Sorry for the confusion.


add ability to start at construct method

added ability to start at the construct method
fixes #50
(Whenever the manimgl command starts supporting starting the scene on any of these lines, this PR can be reverted.)

How I tested this PR:
from manimlib import *

class MyScene(Scene):
    def construct(self):

        ## Test 1
        circle = Circle()
        self.play(ShowCreation(circle))

put cursor on line 5  (at any position: in the middle or at the end of line)
run the "manim notebook: start scene at cursor" command
a comment # should appear right after the def construct( line, and manim notebook should start
(it runs the manimgl command with the line where this commend is)

also, the same works when we start while the cursor is on line 6, or 7, or 8
(which can be with or without arbitrary indents)

https://github.com/Manim-Notebook/manim-notebook/pull/82#discussion_r1830718287


Add limited implementation inheritance via traits

 Issue by brson
Thursday Oct 17, 2013 at 18:48 GMT
For earlier discussion, see https://github.com/rust-lang/rust/issues/9912
This issue was labelled with: A-grammar, A-traits, A-typesystem, B-RFC, P-high in the Rust repository

Not sure if 'implementation inheritance' is the right name for this.
Servo people are complaining a lot about not being able to inherit the memory layout of supertypes, since the DOM is a classic OO hierarchy. Seems like we just have to do it. The basic idea is to let traits specify struct fields.
Needs a complete design, something simple.

dup of https://github.com/rust-lang/rfcs/issues/349


Moderation Commands (Discord bot, DSharpPlus)

We need way more commands for moderation. Creating a single command is good enough for a PR to be accepted ;)

Are you using microsoft bot framework? What are the things I should be aware of before I can begin? I'm kinda new to bots but would like to try and get better.

@DesmondANIMUS
This is a Discord bot and I believe there is no Microsoft Bot FX required.
This is the library that the bot is built upon: https://github.com/NaamloosDT/DSharpPlus
Documentation: https://dsharpplus.emzi0767.com

Hey, when I pull the solution and build it, I get these errors: "Unable to find package DSharpPlus.CommandsNext with version (>= 3.1.3-beta-00273)"
Any idea?

Could you give some more information on how to test this bot?

If you run the bot with no arguments it'll create a settings.json file with sample data, then you replace the token with a Discord bot token. Follow the instructions on the application page to add your instance of the bot to your own guild, and then use +help to show available commands.

I get a nullreference when I  start up on this line t.Namespace.StartsWith("ModCore") in the AsyncListenerHandler

@Vetsoo Where is that line at exactly?
@DesmondANIMUS The Microsoft Bot Framework isn't used in this project. as @Yucked said, this project uses DSharpPlus. It is a library for writing aps with the Discord API.
Sorry for being inactive, I was at work c:

public static void InstallListeners(DiscordClient client, Bot bot)
{
// find all methods from ModCore with AsyncListener attr
ListenerMethods =
from a in AppDomain.CurrentDomain.GetAssemblies()
from t in a.GetTypes()
where t.Namespace.StartsWith("ModCore")
from m in t.GetMethods()
let attribute = m.GetCustomAttribute(typeof(AsyncListenerAttribute), true)
where attribute != null
select new ListenerMethod { Method = m, Attribute = attribute as AsyncListenerAttribute };
        foreach (var listener in ListenerMethods)
        {
            listener.Attribute.Register(bot, client, listener.Method);
        }
    }

Do you have a token setup in settings.json?

Yes I do. My bot is also added in my server. Do I need anything else?

I'm taking a look at it. Errors for me as well.

@Vetsoo The latest commit fixes it. Please pull the new version off of GitHub c;

No more responses. Guess it's time to close this one.


Add staging branch

Signed-off-by: Moti Asayag<EMAIL_ADDRESS>rh-pre-commit.version: 2.3.0
rh-pre-commit.check-secrets: ENABLED

probably it would be better to push images with a prefix staging- for the image tag
any opinions on a better option?

probably it would be better to push images with a prefix staging- for the image tag

I would do suffix instead of prefix but that a technicality
So now the process would be to first push to stagging for in progress work and then to main? Or that all PR will be merged to stagging and when we want to release we push to main?

probably it would be better to push images with a prefix staging- for the image tag any opinions on a better option?

Can you add the reason for having a stagihng branch?
To the point of nameing, I think the staging should be expressed in the repository name, not the image name or tag.

I would do suffix instead of prefix but that a technicality

my bad - meant for a suffix.

Can you add the reason for having a stagihng branch?

The idea for this branch is to enable an early testing of the pre-GA components (RHDH and Sonataflow), without affecting the upstream chart. This chart is designed for internal testing to identify any potential issues with the next versions of RHDH and Soantaflow. This chart pulls the pre-GA components differently than the GA, therefore not a good candidate to be merged to the upstream branch.

To the point of naming, I think the staging should be expressed in the repository name, not the image name or tag.

I was thinking of mta-0.02-rc1 or mta-0.02-staging or something that will not be visible when listing the charts without the --version flag or not being installed automatically if the version is omitted.


Sync code clean for wd and qm

Signed-off-by: wenkai lin<EMAIL_ADDRESS>

Don't use dash in the title. Please help to use colon instead.
Don't leave the comment area as blank.

this patch for:
1.make fall through effective
2.some clean for size_t
3.tmp use directly in next ,add intercept

For the title, we always write it as the format "{category}: {operation}". For example, "wd: clean for size_t". If it's related to rsa algorithm, we could write "wd: rsa: clean for size_t" or "wd/rsa: clean for size_t".
It's good that you fill the comment in the pull request. But I really hope you could move it to the comment area in the commit. It would help others to check comments in git tree. If the comments are only in the pull request, others couldn't find it from the git tree.
To your patch, it's better to split it since it covers both wd common layer and hisi vendor driver. If a change is related to any interface, we have to make the changes on both wd layer and vendor driver into one commit. Otherwise, we'll suffer build error. If a change is NOT related to any interface, we could split the patch. The rule is to only change a small part at a time. It would be easier to review in the community.
Thanks.

For the title, we always write it as the format "{category}: {operation}". For example, "wd: clean for size_t". If it's related to rsa algorithm, we could write "wd: rsa: clean for size_t" or "wd/rsa: clean for size_t".
It's good that you fill the comment in the pull request. But I really hope you could move it to the comment area in the commit. It would help others to check comments in git tree. If the comments are only in the pull request, others couldn't find it from the git tree.
To your patch, it's better to split it since it covers both wd common layer and hisi vendor driver. If a change is related to any interface, we have to make the changes on both wd layer and vendor driver into one commit. Otherwise, we'll suffer build error. If a change is NOT related to any interface, we could split the patch. The rule is to only change a small part at a time. It would be easier to review in the community.
Thanks.

Thanks for all your advices, I will send another pr and close this later.

Close since the patches are migrated into another pull request #205.


error on startup: Cannot find module 'autosize'

v1.4.13

Thanks for reporting.
We've just corrected the binaries, can you download 1.4.1 release again?
ps. by the way, can you give some feedback on the error window?

was it helpful?
to much text?
is there something that could be added?

it's something new :)

The new binaries for the 1.4.1 release work!  Thanks for the quick response.
I found the error page helpful; I appreciated the links to the Inspector and the GitHub issues page, which made it easy to submit the issue.


Rerun benchmarks

Results are scratch, and will be redone, there was an unexpected background noise on benchmarks machine.

For some reason, sandboxed go-jsonnet and jsonnet now refuse to load files by absolute path, despite jrsonnet/rsjsonnet/sjsonnet being fine with this setup.
New alternative Rust implementation looks good, I like that it implements proper TCO (Despite my hybrid TCO in https://github.com/CertainLach/jrsonnet/pull/121), I need to borrow stacktrace building idea from it.
Benchmarks are in progress, right now jrsonnet looks a bit faster, but it is mostly due to more builtins implemented in jsonnet, will evaluate rsjsonnet later.

Preliminary benchmarking run for rsjsonnet, comparing it to jrsonnet and other implementations (only quick runs are performed, so some implementations are excluded here)
https://gist.github.com/CertainLach/7d0bbd0d0272bdc5091e5071e20327ee


Update

Added resize work item behavior

This messed up changes I had made earlier.  Going to submit Monica's one change as a separate pull request - closing this one.


PyLance reports syntax error when an integer is next to the else keyword

Environment data

Language Server version: v2022.11.30
OS and version: macOS Monterey v12.5.1
Python version (& distribution if applicable, e.g. Anaconda): Python 3.9.7

Code Snippet

print("Yay")if 1==1else print("Nay")

Repro Steps

Paste the code and let PyLance do the work

Expected behavior
There should be no syntax errors, as this is valid Python.
Actual behavior

Logs
No logs

If you run this code in the Python 3.10 or 3.11 interpreter, you will receive a warning indicating: SyntaxWarning: invalid decimal literal. So, while this may not result in an exception in the current version of Python, it is deprecated and will result in an exception in the future. As such, it makes sense for pylance to emit an error here. You can obviously avoid the error by inserting a space.

Oh ok makes sense then, thanks for clarifying.


Add labels for tests

Will allow targets for grouping them by label

Add target for all VTKmofo tests

N.B. target names like RUN_UNIT_TESTS may clash with parent
projects, so only top level project should declare them unless
super builds etc. are used

Should be safe to merge

gah I lied, PLEASE DON'T MERGE YET!

Ok, we should be good to go now.

Yup, this is ready to merge. 👍


Improve the UI of the calculators

Hey @ritika728
I want to improve the UI of the calculators page by changing the background. Please assign this issue to me under JWOC

@krittika2004 assigned


Dereference page attribute values

For the included PDF file, the MediaBox attribute references a Reference instead of the array of numbers. Dereferencing it returns the array of numbers.
Should fix #253.
The included PDF demonstrating the issue for the test suite is 5MB, but I'm not sure how to reduce the PDF to demonstrate the issue and nothing else.

Thanks for this. I spent some time looking into this, and managed to reproduce a smaller test file, but on reflection I'm not sure it's something we should merge.
It'd be nice to abstract the low-level PDF structure away completely, but pdf-reader isn't really aiming to do that. The attributes hash can be a complex object with many levels of nesting and although this will fix the case of top-level values pointing to an indirect object, but there's always a chance that nested objects will be indirect.
For example, it's legal to have a MediaBox that looks like this:
/MediaBox [1 0 R 2 0 R 3 0 R 4 0 R]
I think a diff like this should replace all the indirect objects recusively:
diff --git a/lib/pdf/reader/page.rb b/lib/pdf/reader/page.rb
index cd1a48d..a16e02d 100644
--- a/lib/pdf/reader/page.rb
+++ b/lib/pdf/reader/page.rb
@@ -58,7 +58,7 @@ module PDF
       def attributes
         @attributes ||= {}.tap { |hash|
           page_with_ancestors.reverse.each do |obj|
-            hash.merge!(@objects.deref(obj))
+            hash.merge!(@objects.deref!(obj))
           end
         }

.. but pdf-reader has never promised to completely remove the indirect objects and I'm not convinved that needs to change for now. Sorry!
A consequence is that calling code needs to manually deref objects, just in case they're indirect (eg lib/pdf/reader/page_text_receiver.rb:45).

Understood, thanks for the feedback. I moved my fix into the application level as suggested.
Thanks for all your work on pdf-reader!


feat(table): add initial model parameter for skeletonModel function

Closes #1036
Add additional optional initialModel parameter to skeletonModel function to create a skeleton model based on a given model.
Changelog
Changed

Enabling skeleton state when data is already present will no longer hide the data and put a loading animation. A loading animation will only be present if there is no data in a table cell and skeleton is set to true. This is to follow the guidelines  in https://www.carbondesignsystem.com/patterns/loading-pattern.

lol, how did this happen

The issue this solves has been closed by a different PR ... I'm going to close this unless there's an obvious reason we need this


Configurable fizzbuzz

Use reduce function to make FizzBuzz configurable.  By changing, removing, adding the keys to operators the  functionality of the fizzbuzz can be altered without changing the fizzbuzz function

Such function. So pure. 👍


Show workflow activity details in a compact modal window

Show json details in workflow history modal view

I'm missing before/after this change. Could you attach screenshots?

I'm missing before/after this change. Could you attach screenshots?

updated the description


Simplify tutorial and README

replace @repl blocks by @example blocks to reduce visual noise (fewer julia>, ; and newlines)
this is me being opinionated, but I opted for using ADTypes instead of import ADTypes
use several backends in README example to make the point of this package overly obvious
minor additions to tutorial

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.00%. Comparing base (c1dbc01) to head (aaafe01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   96.05%   95.00%   -1.06%
==========================================
  Files          69       15      -54
  Lines        3779     1760    -2019
==========================================
- Hits         3630     1672    -1958
+ Misses        149       88      -61

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I will make some more changes to this once #217 is merged.

it is merged, you can track all the places where ADTypes is used and remove them

@gdalle A test on coloring currently fails:
Coloring: Test Failed at /home/runner/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/coloring.jl:11
  Expression: maximum(row_colors) < size(A, 1) ÷ 2
   Evaluated: 51 < 50

Stacktrace:
  [1] macro expansion
    @ /opt/hostedtoolcache/julia/1.10.2/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
  [2] top-level scope
    @ ~/work/DifferentiationInterface.jl/DifferentiationInterface.jl/DifferentiationInterface/test/coloring.jl:508

It's a randomized test, should nearly never fail. Fix the seed and call it a day for now


Current char hex code in statusline

Can you add current character under cursor hex as a component (like 0x2014)? I would gladly write this myself but I dont yet understand how to do it in Lua.

I dont yet understand how to do it in Lua
You don't need to just use '%B'.

https://github.com/shadmansaleh/lualine.nvim#vims-statusline-items-as-lualine-component

Note of this sections = {lualine_c = {'%=', '%t%m', '%3p'}} or this sections = {lualine_c = {"os.data('%a')", 'data'}} output anything on on my system.

Did you install shadmansaleh/lualine.nvim ?

What's your entire config ?

require('lualine').setup({ sections = {
		lualine_a = { {'mode', lower = false} },
		lualine_b = { 'branch' },
		lualine_c = { vim.fn.getcwd, {'filename', color = "PmenuSelBold"} },
	},
})

getcwd expects different arguments then what's given to lualines function components.
Lualines function conponents get somthing like
function(self, is_active) so when lualine calls getcwd with those it errors out . You should wrap it witha  function to ignore the args or pass it as a function name
lualine_c = {function() return vim.fn.getcwd() end}

or
lualine_c = {'getcwd'}

Try:
require('lualine').setup({ sections = {
lualine_a = { {'mode', lower = false} },
lualine_b = { 'branch' },
lualine_c = { 'getcwd', {'filename', color = "PmenuSelBold"}, '%B' },
},
})

'%B' is not shown anyway.

Is your cursor on a char ?

Error executing lua [string ":lua"]:1: attempt to call field 'get_config' (a nil value). There's no such function?

You have hoob3rt/lualine.nvim installed not shadmansaleh/lualine.nvim .

Your fork didn't load, so I had to revert to original:
Error detected while processing C:\NvimLua\nvim\init.lua: E5113: Error while calling lua chunk: ...ata\site\pack\user\start\lualine.nvim\lua\lualine.lua:256: attempt to index field 'config_module' (a number value)

Use this and try to reproduce the crash without any other plugins influence.

I'm on Windows so I cannot use bash script. I've created an isolated installation by creating separate nvim and nvim-data... directories and setting the XDG_* variables. Strangely enough, now your plugin works (it still cannot do stuff like 0x%B for 0x2014 for example, but anyway…). And I only had a few plugins installed to get this problem. Will try finding out what plugin is intervening with yours.

Yes. Renaming it doesn't seem to help.

What did you rename it to ?

Sorry, renamed the wrong one. Now its working. Thanks for your efforts! 👍
I found that 'mode` separator tends to disappear when lualine elements are colored via highlight groups.


[MINOR][PYTHON][DOC] Fixed instructions for building python docs

Adding python packages to README and requirements.txt to fix issues with building python documentation
There are currently two ways to install python packages for building python documentation:

running sudo pip install from the README.md

$ sudo pip install 'sphinx<3.1.0' mkdocs numpy pydata_sphinx_theme ipython nbsphinx numpydoc sphinx-plotly-directive 'jinja2<3.0.0'

running the requirements.txt file, from $SPARK_HOME

pip install -r dev/requirements.txt

What changes were proposed in this pull request?

Adding 'markupsafe==2.0.1' to both /docs/README.md and /dev/requirements.txt
Syncing both files to contain the same packages
Adding pyarrow to /docs/README.md

Why are the changes needed?

markupsafe==2.1.1 would run into errors when building python documentation (using 'make html')

Similar stack overflow issue
Downgrading to markupsafe==2.0.1 fixes missing 'soft_unicode' module issues
Adding missing packages from requirements.txt (Under Documentation-Python) to README.md, this fixes some additional bugs when trying to build docs from the README command.
Finally, running the README command runs into one last error:

This is because 'pyarrow' module has been added to requirements.txt (Under PySpark Optional Dependencies) but is still missing from the README command

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Documentation changes only.

Thanks for taking a look for this @Transurgeon

Thanks for looking into my pull request @HyukjinKwon,
Initially I wanted to work on SPARK-33247, I was wondering if this is still required. If so, do you have any templates I can base out of for the structure of the examples/scenarios?

That's awesome. We don't have any templates for now. Basic idea is to have Parameters and Examples that are self-contained (just like pyspark.pandas packages). feel free to create a subtask and start working on them

Can one of the admins verify this patch?

Merged to master.


Support for multi language

Signed-off-by: Amit Padmani<EMAIL_ADDRESS>Summary of Changes

Implemented the localization features, Added two new language French or Hindi
Added title for each screen to remove screen name dependency
User can easily change the app language from settings screen
Refactored Proof Request class name

Related Issues
#90
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

[x] All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
[x] Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components.
[x] Run prettier: npm run style-format
[x] Updated documentation for changed code and new or modified features.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template adapted from the Python attrs project.

@nbAmit I like the work here. Are you able to resolve the conflicts before I do a review. Also, I'm in line with @amanji's comment in that I don't think we should use snake_case; JavaScript tends to favour camel case or Caps on the first letter for things like Types, Constants, Classes, etc.


Test pr437 4

test e2e for the .repo templates

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-cosmos-sql -b pr/34

View Changes | Compare Changes

Project: todo-csharp-mongo
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-mongo -b pr/34

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-sql -b pr/34

View Changes | Compare Changes

Project: todo-csharp-cosmos-sql
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-cosmos-sql -b pr/34

View Changes | Compare Changes

Project: todo-csharp-mongo
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-mongo -b pr/34

View Changes | Compare Changes

Project: todo-csharp-sql
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-csharp-sql -b pr/34

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo-aca -b pr/34

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo-swa-func -b pr/34

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-aca -b pr/34

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/34
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-swa-func -b pr/34

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/35
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo-swa-func -b pr/35

View Changes | Compare Changes

Project: todo-nodejs-mongo
Remote: azure-samples-staging
Branch: pr/35
You can initialize this project with:
azd init -t kaizentm/todo-nodejs-mongo -b pr/35

View Changes | Compare Changes

Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/35
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo-aca -b pr/35

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/35
You can initialize this project with:
azd init -t kaizentm/todo-python-mongo -b pr/35

View Changes | Compare Changes


Feature/enable draft update

Description
Added option for user to update saved templates.
Related issues
Closes #488
Type of change

[x] New feature (non-breaking change which adds functionality)

Changes Made

Template menu action for edit functionality
Simplified templates list rendering (previous version caused nested  tags with form dialog)
Option for rendering WizardFillObjectDetailsForm component in a dialog
Form actions for template -typed object
Reset draftStatus and currentObject redux state objects on form component unmount
Handle template replace both into backend and redux state
Prevent re-render of app by moving status message handling rendering logic to message handler from app root
Serialize status message details
Updated status message handler tests
Added test for template edit

Testing

[x] Integration Tests

Changes to status message handling had to be made since re-rendering whole app when status message state changes would unmount certain elements, eg. dialogs.

I've actually encountered this error from Console when updating a template

I've actually encountered this error from Console when updating a template

Good call. This error was caused because I typed response as optional property for StatusDetails type. Actions need to be serialized and this caused problems when response has nested unserialized data.
Fixed by stringifying response.

could be a tad wider
isn't clear form + update the same as delete. my question would be what would be the use case for clear form ? - we could also omit it

Good points. I think we could change the width once we're doing whole design overhaul.
Not sure if "Clear form" button is needed. Could there be some use cases where user would want to use the template id but re-fill the form?
May be we could prevent updating empty form?

Good points. I think we could change the width once we're doing whole design overhaul.

ok

Not sure if "Clear form" button is needed. Could there be some use cases where user would want to use the template id but re-fill the form?
May be we could prevent updating empty form?

let us remove clear form, I don't see a use case for it, and if we find one we will add it back
And yes we should prevent empty form, it there is the case, but do you mean prevent in front-end or back-end ?

let us remove clear form, I don't see a use case for it, and if we find one we will add it back And yes we should prevent empty form, it there is the case, but do you mean prevent in front-end or back-end ?

I mean preventing empty form in front-end which is in the matter of fact implemented already.


[QUESTION] REDIST for mssql-jdbc_auth_LICENSE?

Question
The file https://github.com/microsoft/mssql-jdbc/blob/dev/mssql-jdbc_auth_LICENSE mentions under 2.a.i. that there would be a "REDIST list in the software" or a list "at REDIST" that describes which code can be copied and distributed in object code form. Could you help me locate this list?
I assume the intention is to allow redistribution of the mssql-jdbc driver including the auth part, as the JDBC driver FAQ says that the current driver is "redistributable", but it's not very easy to make that interpretation from this license. Could you confirm that is the case?

Looks like the copy of the license there is not quite up-to-date (I'll update it). If you download the ZIP file (https://aka.ms/downloadmssqljdbc), it contains the official version that states:

DISTRIBUTABLE CODE. The software may contain code you are permitted to distribute (i.e. make available for third parties) in applications you develop, as described in this Section.
a) Distribution Rights. The code and test files described below are distributable if included with the software.
i. REDIST.TXT Files. You may copy and distribute the object code form of code listed on the REDIST list in the software, if any, or listed at REDIST (https://aka.ms/jdbceularedist);

The ZIP (and tar.gz) file also contains a redist.txt file that states:

Distributable Code for the Microsoft JDBC Driver for SQL Server
The entire package may be redistributed.
For the latest version of this REDIST file, please visit https://aka.ms/jdbceularedist

Regards,
David


Add missing closing brace in docs

Cherry-pick of https://github.com/facebook/react-native/commit/6152fffcbd836276e53f95c79ca88c99208e4fff
Fixes https://github.com/facebook/react-native/issues/11150 in 0.39-stable
@janicduplessis

I cherry picked it manually, it's going through CI now and should be updated on the website soon.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain thumbmunkeys.com has exceeded the max emails per hour (71/60 (118%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from filter01.reliabledns.org ([<IP_ADDRESS>]:52856)
by en02-ams.stablehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1cHc8k-0008nx-Me
for<EMAIL_ADDRESS>Thu, 15 Dec 2016 19:56:34 +0000
Received: from github-smtp2-ext5.iad.github.net ([<IP_ADDRESS>] helo=github-smtp2a-ext-cp1-prd.iad.github.net)
by filter01.reliabledns.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.86)
(envelope-from<EMAIL_ADDRESS>id 1cHc8j-0007nd-7m
for<EMAIL_ADDRESS>Thu, 15 Dec 2016 12:56:30 -0700
Date: Thu, 15 Dec 2016 11:56:28 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1481831788;
bh=hyGuge4bOBSdazY1hPqbT2f2a8f46x33vDaPiSrvefM=;
h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=TRVtz+7rBhH4GzohZhdEn91Nk+AUWm51ipRaiQCpHuEoTRyPWI+1DdZcioiVHAn70
ocrsb4L8Qplr/bCJole9JpZf1cxMGiYhZEKwum/M1ro6sRKwLLNOO+TrnohOSacOMf
+DvWZHZYHatF/H39VxSB6aPy3Dt9PS6OWVkwXdX0=
From: Janic Duplessis<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [facebook/react-native] Add missing closing brace in docs
(#11493)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5852f56c40bf_59973fde0c0051341463cd";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janicduplessis
X-GitHub-Recipient: bunnyboy1
X-GitHub-Reason: subscribed
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARoNgxcZxgH-scnREECNpeaJMEsWpqQxks5rIZtsgaJpZM4LObWR
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>Received-SPF: pass (filter01.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS><EMAIL_ADDRESS>helo=github-smtp2a-ext-cp1-prd.iad.github.net;
X-SPF-Result: filter01.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender
Authentication-Results: filter01.reliabledns.org; dmarc=pass header.from=github.com
X-Filter-ID: s0sct1PQhAABKnZB5plbIamwIYzgudGL4tMY9zS3pea7KY6rzXjgC+rgKYUjsj8D0JuF70A4EJMc
Wn6O/bsgoWSYW6KbZfj8apx6ohl75uUU/+/bMkPgJ5dk+Qj/Ds3FlNsjl/D0CRowqxU8xqCxBoIf
AusLrPYiqQ5mfm+IvLi0ni+vukgSibitVtxew+gw5Y/XbpxSxum3fEpWPEU2S6VkPzVC8jNjkDwf
+ib4NAK670Jmrmc/r6M7WGhCIzRVjdj1CJXkYsBolpmPWfkcrJz3A1ed2ITkOuMtrwds5D6IoQN5
gTI01Ez0QnVWwqvRJq/4FZbX1lzD9O+fyiIjB8wTNR/tjjZvmBdM/4lPZO2sASVdHfbtk3LlI8pB
wr4jGeKz8vlEl/GSEiCnxc6Ard0BaVp3jhK5GOBJIv+LCtD+V9//iYPXcUPDr8DL9oJhN0JkcMmQ
sV7j9toT40ga/BqOpbstZb+O7wPE59JQ50/mihMhLJ08fl4IxNFCDhk/M2Pa7DNq6GdC+PlD6FUL
eh5hjsTbVRmo7nFMDV0g9AuSw65FNOBzbhOHsMsHCJitnRX4bob8BvefLIQAPNSOdPG0+kalGE1+
o9UxnI9bW8IamUdylUIKhf3z2GAHxH7In/S0lUS7o5wiHEkvDt5axSEgHpnfjN1+qTsv4FA5NlU=
X-Report-Abuse-To<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; spf=pass<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; dkim=pass header.i=github.com
X-SpamExperts-Class: ham
X-SpamExperts-Evidence: dnswl/se-reputation (trusted ham)
X-Classification: not-spam/dnswl
X-Recommended-Action: accept
X-Spam-Status: No, score=1.0
X-Spam-Score: 10
X-Spam-Bar: +
X-Ham-Report: Spam detection software, running on the system "en02-ams.stablehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  I cherry picked it manually, it's going through CI now and
should be updated on the website soon. -- You are receiving this because
you are subscribed to this thread. Reply to this email directly or view it
on GitHub: https://github.com/facebook/react-native/pull/11493#issuecomment-267427108
[...]
Content analysis details:   (1.0 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
trust
[<IP_ADDRESS> listed in list.dnswl.org]
1.5 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
0.0 HTML_MESSAGE           BODY: HTML included in message
1.5 HTML_IMAGE_ONLY_20     BODY: HTML: images with 1600-2000 bytes of words
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
X-Spam-Flag: NO
----==_mimepart_5852f56c40bf_59973fde0c0051341463cd
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
I cherry picked it manually, it's going through CI now and should be updated on the website soon.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/pull/11493#issuecomment-267427108
----==_mimepart_5852f56c40bf_59973fde0c0051341463cd
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
I cherry picked it manually, it's going through CI now and should be updated on the website soon.
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5852f56c40bf_59973fde0c0051341463cd--

@janicduplessis 👍


github: require reef job to pass in mergify config

It does what it says on the tin.
This is a change to the mergify configuration and thus will require a manual merge upon approval.

Request to add missing check for quincy job in mergify configuration.

Thank you for the reminder. PR Updated.

So reef build is failing there's yet another nfs ganesha packaging related issue. I'm not sure how long this one will last. We can try to wait it out or we can manually merge before the nfs ganesha issue is fixed. We have to manually merge this PR at some time because it changes the mergify config.
Opinions? - @anoopcs9 @ansiwen

I noticed the failure and initiated a discussion with Kaleb as there was an update pushed yesterday for nfs-ganesha from CentOS Storage SIG. Is that OK if I give it a day or two for fixing the installation issues?

I noticed the failure and initiated a discussion with Kaleb as there was an update pushed yesterday for nfs-ganesha from CentOS Storage SIG. Is that OK if I give it a day or two for fixing the installation issues?

Fine by me.

So reef build is failing there's yet another nfs ganesha packaging related issue.

Current installation issue with nfs-ganesha is due to the fact that we execute a yum update -y prior to installing the required Ceph packages.
Reef is configured to build images with nfs-ganesha v5 packages. They do have a set of clean up instructions within the Dockerfile where /etc/selinux is removed. With updated packages for nfs-ganesha-5.x/nfs-ganesha-selinux-5.x, an update fails to find /etc/selinux/config resulting in an installation error as seen in the GitHub CI logs.
#6 35.42 /var/tmp/rpm-tmp.tz17GR: line 2: /etc/selinux/config: No such file or directory
#6 35.42 error: %prein(nfs-ganesha-selinux-5.5-2.el8s.noarch) scriptlet failed, exit status 1
#6 35.42
#6 35.43 Error in PREIN scriptlet in rpm package nfs-ganesha-selinux
#6 35.43   Running scriptlet: nfs-ganesha-5.5-2.el8s.x86_64                         2/12
#6 35.43 error: nfs-ganesha-selinux-5.5-2.el8s.noarch: install failed
. . .
#6 36.30 Error in POSTTRANS scriptlet in rpm package nfs-ganesha
#6 36.30 error: nfs-ganesha-selinux-5.4-1.el8s.noarch: erase skipped
#6 36.30 /var/tmp/rpm-tmp.QHy4Za: line 2: /etc/selinux/config: No such file or directory
#6 36.30 warning: %posttrans(nfs-ganesha-5.5-2.el8s.x86_64) scriptlet failed, exit status 1

I'm not sure how long this one will last.

Issue will be fixed once the Reef image gets rebuilt with latest nfs-ganesha-5.x packages. But if I understand correctly this rebuild will only happen with next update to v18.2.
In this context I would like to rethink on the need for yum update -y in our Dockerfile.

AFAIR we update the packages because the RPM repository doesn't necessarily have the same packages that are in the container image any more. Since the point is to get the devel packages we ended up failing the install because the matching dev/non-dev packages were not present.
Hypothetical example:
  foo-5.6.7 is installed in the container
  foo-5.6.12 and foo-devel-5.6.12 is in the repo
  foo-devel-5.6.7 is not in the repo

So the yum/dnf update prevents failing the devel package install in this case.
I'm not inclined to remove this step, which has been working for years at this point because of a bug we know will be fixed. I'd be willing to try and put in an nfs-ganesha specific workaround if we can. However, I'm willing to continue the discussion too. :-)

AFAIR we update the packages because the RPM repository doesn't necessarily have the same packages that are in the container image any more. Since the point is to get the devel packages we ended up failing the install because the matching dev/non-dev packages were not present. Hypothetical example:
  foo-5.6.7 is installed in the container
  foo-5.6.12 and foo-devel-5.6.12 is in the repo
  foo-devel-5.6.7 is not in the repo

Are you talking about Ceph related packages or in general? In any case I think DNF is capable of detecting updates in such situations.  In any case I think DNF is capable of detecting updates in such situations.

It was this fix: https://github.com/ceph/go-ceph/pull/510
It was definitely an issue, so we need an alternative solution, we can't just remove the update.

Are you talking about Ceph related packages or in general? In any case I think DNF is capable of detecting updates in such situations.

It was this fix: #510
It was definitely an issue. Some additional ceph packages couldn't be installed, because some other installed ceph packages were not matching. It did not always happen, but in certain times around releases IIRC. So we would need an alternative solution, we can't just remove the update.

Hm.. I'm not convinced completely but I am good to go with #913 for now.

@Mergifyio rebase


Can you help me about a export problem? System.DllNotFoundException: steam_api assembly: type: member:(null)

platform: macos
My game can run in editor but cannot run after exported. I inspect the main pck and there is a libsteam_api.dylib and the bundle.
And I tried copy the dylib and/or the bundle file into xxx.app/Contents/MacOS/, the xxx.app/Contents/Frameworks and xxx.app/Contents/Resouces/, no one is the right path, mono always says no dll found.

Thanks for everything.

I use traced the system calls to find what paths dose mono try open. Then I found it try Contents/Libraries and Contents/lib instead of Frameworks, so I put the dylibs into Contents/Libraries and it works.
Thanks for reply, have a nice day. I'm struggling with the  load path of pck files...


PERF: Faster transform direction if already passed an Enum

Currently, Enum.create() adds quite a bit of overhead to the transform calls, so we probably don't want to call it when unnecessary. Here I added isinstance() checks to handle it in a completely backwards compatible way.
In [1]: from pyproj import Transformer

In [2]: transformer = Transformer.from_crs(2263, 4326, always_xy=True)

In [3]: %timeit transformer.transform(1, 2, direction="forward")
7.96 µs ± 32 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [4]: %timeit transformer.transform(1, 2, direction="FORWARD")
4.18 µs ± 33.9 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

In [5]: %timeit transformer.transform(1, 2)
3.26 µs ± 21.6 ns per loop (mean ± std. dev. of 7 runs, 100,000 loops each)

I think it might be even nicer to remove Enum.create() entirely and move over to a StrEnum / BaseEnum(str, Enum) and then the dictionary lookup could be either "FORWARD" or TransformDirection.FORWARD with the caveat that you'd lose the case insensitive conversion, but the code would be a bit cleaner everywhere then.

StrEnum looks nice, but is Python 3.11+.

I wonder if it would be simpler to add the change there: https://github.com/pyproj4/pyproj/blob/e345729e4283535acf43da40e3679a4e8fae6152/pyproj/enums.py#L14
if isinstance(item, cls):
    return item

Adding the change directly to Enums would be cleaner, but does add a bit of a speed hit still... (I assume going from Cython -> Python -> Cython adds some overhead?)

StrEnum looks nice, but is Python 3.11+.

I think we could get away with just subclassing string here and defining:
class TransformDirection(str, BaseEnum)
there isn't much more to the stdlib implementation:
https://github.com/python/cpython/blob/1cf3d78c92eb07dc09d15cc2e773b0b1b9436825/Lib/enum.py#L1263
I think the question if you want to go this route is whether losing case sensitivity is a deal breaker or not?

To make the code simpler, thoughts about adding this function:
cdef PJ_DIRECTION get_pj_direction(object direction) except *:
    if not isinstance(direction, TransformDirection):
        direction = TransformDirection.create(direction)
    return _PJ_DIRECTION_MAP[direction]

and doing this:
cdef PJ_DIRECTION pj_direction = get_pj_direction(direction)

I think we could get away with just subclassing string

Have you tested the performance of this implementation?

To make the code simpler, thoughts about adding this function:

:+1: That seems like it would be nice!
However, I think we should decide on the next comment first.

I think we could get away with just subclassing string

Have you tested the performance of this implementation?

Yes, it is actually faster because you don't need an isinstance check. You can go right into your dictionary with both TransformDirection.FORWARD and the string "FORWARD" because "FORWARD" == TransformDirection.FORWARD and both versions will match the key. (thus negating the need for the lookup above)
Downsides are that "forward" != TransformDirection.Forward so random cased strings won't work (probably good for Enums actually) and the nice error message of valid options are no longer there.

I am wondering if this would be faster and still allow the error message and support case insensitive input:
cdef PJ_DIRECTION get_pj_direction(object direction) except *:
    try:
         return _PJ_DIRECTION_MAP[direction]
    except KeyError:
        direction = TransformDirection.create(direction)
        return _PJ_DIRECTION_MAP[direction]

I like your most recent suggestion of the try/except inside a helper function. We can add StrEnum later too if desired.

Thanks @greglucas :+1:


Trying to add genre and tag to movie does nothing.

Version: 2.9.11
Build: 2018-05-05 08:12
OS: Windows 10 10.0
JDK: 1.8.0_161 x86 Oracle Corporation
What is the actual behaviour?
Nothing happens
What is the expected behaviour?
Update Tags and Genre
Steps to reproduce:
Editing a movie.  Clicked the details 2, then the + to add Genres, nothing happens.  Tried same with Tags, nothing happens
tmm_logs.zip
Additional
Have you attached the logfile from the day it happened?

did you enter/choose a genre/tag from the dropdown below the list?
works here..

Completely missed the dropdown :(   Thanks!


Feature/1115 support flux controlnet v2

This is a draft for nunchaku to support flux ControlNet.

Thanks for your PR. I will take a look at your code next week.

I am free and will review your PR this weekend.

A quick question, do you want to support the FLUX's official controlnet in FLUX tools?

A quick question, do you want to support the FLUX's official controlnet in FLUX tools?

Yes, i want to support it.


Enabled aggregate API for nested controller

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #166
This is a follow up for https://github.com/kubernetes-sigs/cluster-api-provider-nested/issues/166 to fix the issue in nested controller.
/cc @chrishenzie @Fei-Guo

/uncc
I lack context on this part of the codebase. Did you mean to CC @christopherhein ? (included in the linked PR #166)


Recognize K8s commands?

Hi guys,
Have a Possibility of implementation to recognize K8s commands in future?

The kubectl command?

The kubectl command?

Yeah, or recognize similar parameters together.

Hi, i'm here just to write it tells me there are no fucks given for kubectl! Unacceptable! I installed thefuck mainly for kubectl as i make mistakes all the time.  ;-)

Hello, can I give a try to work on the feature?

@konstunn have you made any progress? Thinking about picking this up

No progress. I was waiting for approval from repo owner, but there was no reply.

No progress. I was waiting for approval from repo owner, but there was no reply.

Maybe, supposing that this project is abandoned?


Remove reference to 'black' and 'white' in description.

Would resolve #380.

This is such a delightfully simple change... and kind of obvious in hindsight. Merging!

...where credit's due: @rbasso gently suggested two courses of action.  I took the lazy path. :)

:heart: @rbasso :-)


fix(sbb-header): header action animation on hover

Preflight Checklist

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the pull request tracker for a Pull Request (PR) that matches the one I want to submit, without success.

Issue
This PR Closes the bug reported by Florian, about missing animation on hover of header action elements
https://github.com/lyne-design-system/lyne-components/issues/1569
Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:

added translation to text and icon, when header action is hovered

Browsers
I tested the build on the following browsers:

[x] Firefox Desktop
[x] Chrome Desktop
[ ] Edge Desktop
[x] Safari Desktop
[ ] Chrome Mobile
[ ] Safari Mobile

Screen readers
I tested the build on the following browsers:

[ ] JAWS Firefox Desktop
[ ] JAWS Chrome Desktop
[ ] NVDA Firefox Desktop
[ ] NVDA Chrome Desktop
[ ] VoiceOver Safari Desktop
[ ] VoiceOver Chrome Desktop
[ ] VoiceOver Safari Mobile
[ ] Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report

Merging #1585 (ec67cc0) into master (ab917b0) will decrease coverage by 2.78%.
The diff coverage is 59.18%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1585      +/-   ##
==========================================
- Coverage   54.85%   52.07%   -2.78%
==========================================
  Files          49       84      +35
  Lines        1659     3687    +2028
  Branches      406      992     +586
==========================================
+ Hits          910     1920    +1010
- Misses        671     1631     +960
- Partials       78      136      +58

Impacted Files
Coverage Δ

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

src/components/sbb-clock/sbb-clock.tsx
0.00% <0.00%> (ø)

...mponents/sbb-journey-header/sbb-journey-header.tsx
88.23% <ø> (+1.27%)
:arrow_up:

...onents/sbb-journey-summary/sbb-journey-summary.tsx
81.63% <ø> (ø)

src/components/sbb-link-list/sbb-link-list.tsx
84.00% <ø> (-4.24%)
:arrow_down:

src/components/sbb-link/sbb-link.tsx
58.00% <ø> (-33.43%)
:arrow_down:

src/components/sbb-logo/sbb-logo.tsx
0.00% <ø> (ø)

src/components/sbb-menu-action/sbb-menu-action.tsx
60.00% <ø> (ø)

src/components/sbb-menu/sbb-menu.tsx
26.54% <ø> (ø)

...mponents/sbb-checkbox-group/sbb-checkbox-group.tsx
32.00% <32.00%> (ø)

... and 82 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

I asked Florian for a UX review. It can be that on active, the shift should be reset. But wait for the answer.

@federicoisepponfincons after discussion with florian: on active state, the shift should be reset.

@jeripeierSBB allright, the shifting should be only on the hover state and not on the active one

@jeripeierSBB added the high contrast effect (as seen in the button component) and fixed the hover / active animation


Add SBE initiated mpipl testcase

This commit adds testcase which would test SBE initiated
MPIPL boot.
Signed-off-by: Srikanth Aithal<EMAIL_ADDRESS>

success_case.log

Failed_case.log

@stewart-ibm @sammj
Idea behind this patch is to test SBE and hostboot part of MPIPL code. That way we can avoid any regression in SBE and hostboot side of the code. This patch trigger SBE S0/S1 interrupt directly to initiate MPIPL. SBE will initiate MPIPL flow and eventually system boots back.
-Vasant

Failed_case.log

Actually its not test case failure. System failed to boot after MPIPL for some reason.

24.31668|ISTEP 16. 2 - host_activate_slave_cores

If we hit this continuously we should ask hostboot/SBE guys to debug.
-Vasant

Failed_case.log

Actually its not test case failure. System failed to boot after MPIPL for some reason.

24.31668|ISTEP 16. 2 - host_activate_slave_cores

If we hit this continuously we should ask hostboot/SBE guys to debug.
-Vasant

By Failed I did not mean testcase failure. I have been able to recreate this issue twice. Will retry few more runs with suggested changes and see if we hit same issue again... will keep you posted.

@hegdevasant done with changes. Attaching run result log.

success_case_02.log

Failed_case.log

Actually its not test case failure. System failed to boot after MPIPL for some reason.

24.31668|ISTEP 16. 2 - host_activate_slave_cores

If we hit this continuously we should ask hostboot/SBE guys to debug.
-Vasant

By Failed I did not mean testcase failure. I have been able to recreate this issue twice. Will retry few more runs with suggested changes and see if we hit same issue again... will keep you posted.

Its not recreatable always.. but if we run this testcase for 4-5 times we will hit this said BUG.


chore: bump remote-controller version in lagoon-remote

closing, already done

My PR didn't actually bump any versions!


handle quota issues during scaleset resize

Information

Onefuzz version: 1.0.0
OS: NA

Provide detailed reproduction steps (if any)

Create scaleset
Let stablize
onefuzz scaleset update $ID --size 99999

Expected result
Resize attempt is rejected
Actual result
Eventually an exception about quotas is generated in the service.
AB#39994767

It's straight forwards how to deal with quota issues when creating scalesets.  We fail the scaleset creation, and give the Azure error to the user as scaleset.error.
When we're resizing scalesets, this would potentially stop work that is already running on the scaleset.

We autoscale now and get quota manually now.


arcgis-egdb Register Connection

On testing the new arcgis-egdb cookbook it creates the enterprise GDB fine, however it doesn't register this within ArcGIS Server manager as a Data Store.
Is it expected that the enterprise GDB is registered as a Data Store in ArcGIS Server?
The sample seems to suggest so:
"data_items": [{
"database": "egdb",
"data_item_path": "/enterpriseDatabases/registeredDatabase",
"connection_file": "C:\chef\misc_scripts\connection_files\RDS_egdb.sde",
"is_managed": true,
"connection_type": "shared"
}]
Are there any pre-requisites required for this to work? Through testing i have found one - the security groups of the instance running the Chef script and the RDS need to be open too each other on the postgres port and within the same VPC (if running under no public access).

try to use double slash instead:
"connection_file": "C:\\chef\\msic_scripts\\connection_files\\RDS_egdb.sde",

@drobinson13 Can you remove all the sensitive info and share the chef run log and the JSON file?

Found the issue.
In the "server": { "private_url" parameter, it wasn't possible to use any of the following [localhost:6443/arcgis, internalIP:6443/arcgis, privateDNS:6443/arcgis]. I think this is for one of two reasons:

External access is required - hence internal facing DNS won't work
It needs to match the webContextURL - usually the external DNS in AWS - e.g. https://mydomain.com/server


Kibana 8.4.2 support

Hi!
Is Kibana 8.4.2 supported?
I have downloaded the compiled plugin for Kibana 8.4.1, and renamed the version in kibana.json and archived the folder back in .zip. Then successfully installed the plugin. But it doesn't appear in the sidebar :(
Is there any solution?

Please read: https://github.com/Karql/elastalert-kibana-plugin/issues/30#issuecomment-1219447280

The issue was because I didn't restart Kibana, I guess. Now everything works!

https://github.com/Karql/elastalert-kibana-plugin/releases/download/1.5.0/elastalertKibanaPlugin-1.5.0-8.4.2.zip


[Coverity CID :197623]Incorrect expression in /tests/kernel/interrupt/src/nested_irq.c

Static code scan issues seen in File: /tests/kernel/interrupt/src/nested_irq.c
Category: Incorrect expression
Function: offload_function
Component: Tests
CID: 197623
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

*** CID 197623:  Incorrect expression  (ASSERT_SIDE_EFFECT)
/tests/kernel/interrupt/src/nested_irq.c: 115 in offload_function()
109     ARG_UNUSED(param);
110
111     zassert_true(z_is_in_isr(), "Not in IRQ context!");
112     k_timer_init(&timer, timer_handler, NULL);
113     k_busy_wait(MS_TO_US(1));
114     k_timer_start(&timer, DURATION, 0);

CID 197623:  Incorrect expression  (ASSERT_SIDE_EFFECT)
Argument "check_lock_new" of z_zassert() has a side effect because the variable is volatile.  The containing function might work differently in a non-debug build.

115     zassert_not_equal(check_lock_new, check_lock_old,
116     "Interrupt locking didn't work properly");
117     }
118
119     void test_prevent_interruption(void)
120     {
121     irq_offload(offload_function, NULL);
122     k_timer_stop(&timer);


View() dows not show row names

View now support 2d data structures. ty very much. unfortunately, it does not show row names and instead just shows a row ordinal.  This is particularly horrible if the rownames contain useful information.
Example:

The viewer does support row names:

The problem is that the data structure that is returned by quantmod::getSymbols doesn't actually have named rows in the usual meaning of the term - as in, it doesn't have rownames():

The reason why those names are printed out in the REPL, is because the zoo class customizes print to output that data.
It appears that the equivalent of rownames for zoo objects (of which this is an example) is the zoo::index() function. So far as I can tell, the reason why it uses it instead of rownames is to be able to associate values of types other than character with rows (since rownames is always a char vector).
It looks like we could query rownames(x) first, and if that returns NULL, then try format(zoo::index(x)) (handling the error if zoo package is not installed).

The change then sounds package specific... What about other packages that might be doing something similar?

FYI, R open does seem to handle this

@MikhailArkhipov, it is indeed package specific, but the zoo package is intended to be a generic package for indexed datasets, for other domain-specific packages to build on. It's also very popular, especially if you count all the indirect uses by other packages (like quantmod in this example). So I think it would be reasonable for us to support it if it's installed.

@ebs238, thanks for pointing this out - I'll take a look at how it works there. One possibility is that they coerce the data to a data.frame before displaying - the object in question specializes this operation as well, and the resulting data frame does have named rows. Unfortunately, doing so also means that the entirety of the data is copied, which is infeasible on very large datasets; and it can cause name loss with other types.

Yep, they do use as.data.frame.

So ... what should we do in this case? I get that there is a copy operation involved here - should this be a configuration option that calls as.data.frame by default with an option to turn it off?

One of my comments above describes the solution in detail - we should just special-case zoo::index as an alternative to rownames. I think it's okay to special case it even though it's not a stock package, because it is a de facto standard package for anything that needs data other than strings associated with rows as "names".

OK, lets do it then.

@MikhailArkhipov You asked for additional packages that might do something similar.
In addition to zoo, I would like to see View() updated for stat::ts. There are no row.names for mts and ts objects, but it is difficult to determine where you are in the time series when the calendar information is not shown in View().
I believe a quick solution would be to use .preformat.ts() for ts objects with frequency equal to 4 or 12.
ts.qtr = ts(c(1,2,3,4,5,6), start=2000, frequency = 4)
View(.preformat.ts(ts.qtr))

mts.qtr = ts(matrix(c(1,2,3,4,5,6), ncol=2), start=2000, frequency = 4)
View(.preformat.ts(mts.qtr))

Non-quarterly or monthly time series look nicer when not run through .preformat.ts(). It losses a nice column header.

It seems that there's a bunch of separate items here that pertain to time series.
In the code snippet above, ts.qtr is actually a dimensionless object. When View() is applied directly, it is therefore shown as a single column of values, with no names. This is the same behavior as in RStudio.
The pretty printer for it, however (the one that handles print) formats it as a table, but only for ts objects that have a frequency of 4 and 12:
> ts.qtr
     Qtr1 Qtr2 Qtr3 Qtr4
2000    1    2    3    4
2001    5    6

This behavior appears to be hardcoded in the .preformat.ts function, which produces a matrix with the corresponding dimensions and rownames out of the time series.
For things that have a different frequency, however, the function doesn't do anything useful. The resulting matrix doesn't even have rownames corresponding to individual time points. Although this can be overridden by passing an explicit calendar=TRUE parameter to .preformat.ts.
The way .preformat.ts is implemented, it uses time() to compute time points for data in the time series, and then makes that the rownames of the generated matrix. We could do that as well. The question is whether we do it just for frequency=4 and frequency=12, or whether this should really be a separate configurable item in the grid (just for time series)? We could make a "calendar view" checkbox that toggles between the two modes.
Also, if calendar view is not used, we should still use time() to label rows. Effectively, for time series objects, time() is the logical equivalent of names().

Thanks for looking into this. I thought the .preformat.ts would make for a simple enhancement, butI did have a concern with View() representing the data as a matrix. While mts.qtr is also of class matrix, ts.qtr is not and representing it as a matrix through View() might be confusing. It might be better to keep the data as a vector with row names corresponding to the calendar.

Pinging this bug. I've been doing quite a bit of time series work with zoo, tts, and quantmod. Right now I need to get folks to use head instead of variable explorer / table viewer. We really do need to fix this.

The better workaround right now is to do View(as.data.frame(...)). This should get you the same behavior as RGui and RS (but at the cost of not having data virtualization).
Let's do time() and zoo::index() support for row labels for Wave2, and skip the calendar stuff for now, since it's not clear whether it's a good thing or a bad thing (if we do it, it might get into the way of future features like editable grid).


Create ClearDotTax.md

Project Abstract
Calculating and filing taxes for Polkadot/Kusama and its parachains is a strenuous and time-consuming process. Existing solutions don't fully solve it, and offer a poor user experience. ClearDotTax aims to give users their Polkadot tax report for their jurisdiction in one click.
Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
[x] I understand that 30% of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
[x] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

I have read and hereby sign the Contributor License Agreement.

Hey @semuelle thanks for the review. Answering inline:

Thanks for the application, @rajgoesout. If I'm understanding correctly, you are planning to run the project as a service and charging for subscriptions, correct?

Yes.

First, as you know, the grants program expects all deliverables to be open source, including dependencies. How are you ensuring that people will pay for your service?

The way we were thinking was: launch a PoC which is open source with the help of this grant; and later on add support for more protocols/features via new modules, which could be closed source. This is based on our experience with YieldScan, which despite being completely open source, had paid users; given people don't want the hassle of running their own infra or updating the integrations when protocols update their APIs/code.

Second, have you considered applying for a Decentralized Futures grant? This is exactly the kind of project the program is built for. And applications up to 50k USD can be fast-tracked.

We weren't aware of this program before. What we can do now:

apply for the Decentralized Futures grant with an updated scope
apply for both, this open source w3f grant and the Decentralized Futures program with separate deliverables

Happy to follow whichever course of action the foundation thinks would be more beneficial for the ecosystem.

What we can do now:
* apply for the Decentralized Futures grant with an updated scope

* apply for both, this open source w3f grant and the Decentralized Futures program with separate deliverables

@rajgoesout, please apply for a DF grant first, as the program ends in June. We can always come back to the grants program if needed.

@semuelle Thank you for the advice. Just submitted the DF application with a revised scope.

Thanks, @rajgoesout. I'll close this PR for now then.


Settings can not show up in search when they are not included in settingsLayout.ts

Add a setting, excluded from settingsLayout.ts, e.g. timeline.showView
It shows up when I search time but not timel
Make sure that there is no bad underlying bug...

@roblourens are there still cases when we want a setting to not show up in settingsLayout but have it included in a search?

No clue, I think from

Make sure that there is no bad underlying bug...

I just wanted to understand why the difference, and make sure there wasn't some more severe issue behind this? I think that every setting should be included in settingsLayout so I'm not sure if there's a real case where this matters.

This

It shows up when I search time but not timel

is strange

Unable to repro.


Added solution of Nqueen problem algo using backtracking

Description
The given code gives the coordinates of cell in chess board where the N queens can be placed without any collision. The approach used to solve given problem is backtracking
Fixes #(issue_no)
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

DS ALGO PROJECTS ARE NOT COUNTED FOR HACKTOBERFEST21 so i will close this PR


DATABASE_URL??

I followed the tutorial. It seems to work ok. What is the database url for an orm like prisma? Nothing I tried seems to work

Hi @webface.
The port for the database is currently closed on the Firewall. To connect to the database you'll need to add the following to the digitalocean_firewall resource block found within the network.tf file:
  inbound_rule {
    protocol         = "tcp"
    port_range       = "5432"
    source_addresses = ["<IP_ADDRESS>/0", "::/0"] # All IPs allowed, suggest to reduce to smaller CIDR or your own IP
  }

Once this is done you can set the DATABASE_URL to the following (changing the password and domain with your values):
DATABASE_URL="postgres://postgres:[YOUR-PASSWORD]@[YOUR-SUPABASE-DOMAIN]:5432/postgres"

I'll create a fix for this to allow people to open the port should they wish to connect to the database directly.


[backport] Fix color argument

Please see #103.

Is it for v2 branch?

Oh sorrry, I fixed

LGTM


fix gzeof logic error, fix gzoffset bug

the original gzeof code whill always return 0 if mode is 'r'
rewrite gzoffset throughly, too many bugs in the original code


Incorrect spacing and border radius on receipt thumbnail

DESIGN UPDATES

So this is what I'm thinking we should do for the preview cards. As an outline, here is what we have (Figma file so you can inspect):

I'm thinking of this preview component as two parts:

upper receipt area
lower information area

When a receipt is present, I have it so that the upper receipt area and the lower info area overlap by -4px, which basically accounts for that inner border stroke (4px) of the receipt area not adding to the height of the lower info area.

The upper receipt area has a border radius of 16px:

And that means the inner receipt area there has a border radius of 12px (16px minus the 4px border):

For the bottom info area, the whole thing has a padding of 16px (vertically and horizontally):

The eyebrow part (XXXX owes:) should use our label font size, with a line height of 16px. It's in our text supporting color.

The amount is good as it is, which is our h2 size. The merchant/description line below should use our normal text size and use our text supporting color. It should have a line height of 20px.
In terms of spacing, I'm thinking it goes:

Eyebrow/top line
8px gap
Amount
4px gap
Merchant/description
16px gap
Button

ORIGINAL ISSUE

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.22-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1704274831152639
Action Performed:
Create a receipt request in a workspace
Expected Result:
The receipt image in the request preview should have a border radius that is exactly 4px less than the outer border radius of the request preview card
Actual Result:
It looks like the receipt has the same border radius as the outer preview card.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0175c678ba62df22b2
Upwork Job ID:<PHONE_NUMBER>809223680
Last Price Increase: 2024-01-04

Issue OwnerCurrent Issue Owner: @grgia

So this is what I'm thinking we should do for the preview cards. As an outline, here is what we have (Figma file so you can inspect):

I'm thinking of this preview component as two parts:

upper receipt area
lower information area

When a receipt is present, I have it so that the upper receipt area and the lower info area overlap by -4px, which basically accounts for that inner border stroke (4px) of the receipt area not adding to the height of the lower info area.

The upper receipt area has a border radius of 16px:

And that means the inner receipt area there has a border radius of 12px (16px minus the 4px border):

For the bottom info area, the whole thing has a padding of 16px (vertically and horizontally):

The eyebrow part (XXXX owes:) should use our label font size, with a line height of 16px. It's in our text supporting color.

The amount is good as it is, which is our h2 size. The merchant/description line below should use our normal text size and use our text supporting color. It should have a line height of 20px.
In terms of spacing, I'm thinking it goes:

Eyebrow/top line
8px gap
Amount
4px gap
Merchant/description
16px gap
Button

Let me know how all of that sounds! cc @Expensify/design for eyes too.

@shawnborton if you haven't already, can you please put these screens someplace where we can reference them when building out the legit preview component? I don't want these details to get lost in the void! 💚

can you please put these screens someplace where we can reference them when building out the legit preview component? I don't want these details to get lost in the void!

This is brilliant. I'll use this for my Preview Card Figma component.

@dannymcclain totally!  I should be able to get to this one this week

Looking at this, I was trying to see if there's an easy way to get this component in storybook without tons of fake onyx data so we can prevent future regressions as well

I have a draft for this

@grgia another thing to add to the list here... for preview cards, we used to change some colors around on hover because the row hover was the same color as the card BG. But now that we have a separate color value for row hovers that doesn't collide with the card BG, we can remove the changing colors that happen when you hover on a preview card, for example the small counter in the bottom right

Not Hovered
Hovered

I think @dubielzyk-expensify brought up one more change that needs to be made for this component, mind adding that as a comment as well? I can then resummarize everything so I know we're all on the same page

Yup, I actually already covered that in my big comment above:

Should be able to jump back into this

Here's a first pass of the Report Preview:

@shawnborton do we need to make any updates to the money request preview as well or is it okay?

The money request preview basically be using the same exact component. Gotta ask though - how did you get those two little avatars to show up for the money request preview?

@shawnborton I hardcoded the split avatars to show up for testing. But these are actually two different components in the app. I'm thinking I can consolidate them, but I'd probably need to see all the cases in figma to be sure

Okay cool, I love the idea of consolidating if possible!

@shawnborton, what would you name this component if you were referring to it in Figma?

Merchant/description line

If report: "Merchant || Description", if one expense on the report. "N requests", if multiple expense on the report. "N requests, n scanning" if multiple expense on the report and it has SmartScanning receipts added to it.
If expense: Show merchant if one exists, if not, show description

Sweet, thanks for clearing that up! Also cc @dubielzyk-expensify since you are working on the preview component, this logic should help guide the designs!

PR in progress!

@grgia do you want to link the PR to this?

@abekkala I was working on a wave-related doc, but that's done so I'll get the PR merged and ready for final review before EOW!

@grgia ah ok! I misinterpreted your post above! sorry about that.

Updating PR now

PAYMENT SUMMARY FOR MAR 13

Fix: Internal
PR Review: @situchan [$500]  Offer Link
please complete checklist above

No regression. This is design inconsistency fix. I don't think regression test is needed here.

@situchan can you accept the offer in Upwork so I can release payment today? thanks!

sorry I thought I accepted offer. Just did now


Bug in masking entries below the horizon

I think the GSMObserver does not mask entries below the horizon correctly. In line 68 of base_observer.py, self._phi is used to mask entries, but this should be self._theta.

Thanks @christophwelling, interesting! It's been a while since I looked at that code, will revisit it when I get a chance. (pull requests welcome of course).

I'll be happy do make a pull request. Can you please give me permission to push a new branch into the repo?

sure thing, invite waiting!

@telegraphic If this is still an open problem, I think I've come up with a solution which creates the horizon mask by computing the haversine distance between zenith and all points on the sky and then masking all points that are > 90 deg away. I'll submit a pull request if you can give me permission to push to the repo

Thanks @cdilullo, this looks to work and makes sense! Closing 🥇


Far Gaussians vanishing progressively during zoom in

I'm experiencing an issue with Meta Quest where Gaussian objects from the back to front progressively disappear during zoom operations.
Could you please advise which component needs modification to resolve this?
Thank you!

Hard to say what is going on without pictures or videos.
That said, I myself have exactly zero VR devices around, and can't advise on anything VR related. If it works, great, if it does not, you're on your own.


cloned product image is not showing

in item page cloned product image is not showing

it is not a bug hence closes


Suppress unnecessary GCC truncation warnings using compiler directives

Had to make a new PR for #191 since the branch got renamed. Fixed an issue that would've most likely caused the CI/CD lint check to fail. Thanks for the insight and feedback @RobMeades

Excellent, thanks again!

Thanks for the prompt responses and merging