Feature request: exclude ^toc annotated section from TOC

If it is not possible already, it would be nice to exclude the ^toc annotated section from the TOC.
If it is possible, it might be helpful to have that information available from the plugin documentation.
Thanks!

+1


Magic number is reported for default parameter value

I have a constructor with a default parameter value like this
class Foo(val x: Int = 42) {...}

When running scalastyle with MagicNumberChecker enabled, it reports the default value as magic number.
It would be great if this could be enhanced, e.g. that default parameter values are not reported at all or that only magic numbers are reported that occur more often than a given number of times.

Same for method.
def foo(x: Int = 42) {...}

I have method for generating substring like:
  def getSubstring(line: String, beginIndex:Int, endIndex: Int): String =
    line.substring(beginIndex, endIndex)

case 1
getSubstring(line, 2, 45)
case 2
getSubstring(line, beginIndex = 2, endIndex = 45)
case 1 is warning. I agree. But case 2 should not be warning.(Correct me if i am wrong)
@matthewfarwell Could please help me out why case 2 is waning ?

This should be the default behavior, since using named parameters gives a description to the magic number.

Agreed with @satendrakumar06 case2 should not be a warning still want this implemented.

A PR would be great...

Would love this as well.  We use a lot of default parameters and without this I can't use this check.

Again, a PR would be great...


[Dashboard] Better Logging

Currently, logs get overwritten in console by the CLI. Either make these logs persist, or write them to file.

Implemented as of bd4fec24693666ec34d5d7155443411b629bb144.


myPages is not in output

The sample definitions used all have an output targetName of "mypages" yet none of the sample outputs that contain mypages elements.  should "mypages" be "textItems in this case?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 178aaaa0-cd80-43d6-3781-5ced561e7d53
Version Independent ID: 0c403890-a632-6812-93e0-06e576396d2f
Content: Text split skill - Azure AI Search
Content Source: articles/search/cognitive-search-skill-textsplit.md
Service: cognitive-search
GitHub Login: @Careyjmac
Microsoft Alias: chalton

@mscherotter
Thanks again for the feedback! I have submitted a PR to update the doc, the change is merged internally and will go-live in the public docs shortly.

So mypages is the example targetName. The sample output is still correct, as the name of the output is textItems and forever will be, and if you don't provide targetName then it defaults to textItems. However, you can change targetName to whatever you want, and targetName is the value you should use to select the output from the SplitSkill to pass it to later skills, indexer output field mappings, the knowledge store or index projections. So with this example, to select the output from the SplitSkill later on, you would use /document/mypages/*.
The main reason we allow configuring targetName is in case you need multiple different SplitSkills, that way you don't overwrite the data from the first SplitSkill with the second one, and can define your own unique names for each output based on what you are splitting.

@mscherotter and @Careyjmac, good question and explanation. I updated the docs to include the details from this exchange.
I'm closing the issue because I think it's addressed, but feel free to reopen if you disagree.
#please-close


[PRINTER] Fix the repeatitive cast in scripr printing

cc @Beya2019 @MasterJH5574 @junrushao1994 Followup of https://github.com/apache/tvm/pull/8499

looks like there is no space on the ci machine @tqchen


Start of basic auth sql template

Work in progress.
A sql script which will set up tables functions and triggers to support http basic auth and user management.

@calebmer maybe a better place to start would just be to run this on my local db and see how it interacts with postgrest. https://github.com/robconery/pg-auth
There may be some changes to make, such as integrating it tighter with the actual role info and storing its tables in a schema other than public.

I don't think we need pg-auth any more. I'm adapting it to take advantage of the http verbs postgrest offers, and to tie in with the postgres roles.

This requires the jwt encoding for procs which is part of v3. Closing this PR against master and reopening one against v3.


date_trunc does not support timezone

What type of bug is this?
Unexpected error
What subsystems are affected?
Query Engine
Minimal reproduce step
Our docs says it supports https://docs.greptime.com/reference/sql/functions#date-trunc.
SELECT
    ts,
    COUNT(1) RANGE '1h' as times
FROM
    (
        SELECT ts
        FROM keyboard_monitor
        WHERE date_trunc('day', ts, 'Asia/Shanghai') = '2024-03-11'
    )
    ALIGN '1h'
ORDER BY ts DESC LIMIT 10;

throws:
ERROR 1815 (HY000): DataFusion error: Error during planning: Coercion from [Utf8, Timestamp(Millisecond, None), Utf8] to the signature OneOf([Exact([Utf8, Timestamp(Nanosecond, None)]), Exact([Utf8, Timestamp(Nanosecond, Some("+TZ"))]), Exact([Utf8, Timestamp(Microsecond, None)]), Exact([Utf8, Timestamp(Microsecond, Some("+TZ"))]), Exact([Utf8, Timestamp(Millisecond, None)]), Exact([Utf8, Timestamp(Millisecond, Some("+TZ"))]), Exact([Utf8, Timestamp(Second, None)]), Exact([Utf8, Timestamp(Second, Some("+TZ"))])]) failed.

More minimal:
SELECT date_trunc('day', '2001-02-16 20:38:40+00', 'Australia/Sydney');

throws:
ERROR 1815 (HY000): Failed to plan SQL: Error during planning: No function matches the given name and argument types 'date_trunc(Utf8, Utf8, Utf8)'. You might need to add explicit type casts.
	Candidate functions:
	date_trunc(Utf8, Timestamp(Nanosecond, None))
	date_trunc(Utf8, Timestamp(Nanosecond, Some("+TZ")))
	date_trunc(Utf8, Timestamp(Microsecond, None))
	date_trunc(Utf8, Timestamp(Microsecond, Some("+TZ")))
	date_trunc(Utf8, Timestamp(Millisecond, None))
	date_trunc(Utf8, Timestamp(Millisecond, Some("+TZ")))
	date_trun

What did you expect to see?
Successfully truncate date with timezone.
What did you see instead?
throws
What operating system did you use?
GreptimeCloud
What version of GreptimeDB did you use?
GreptimeCloud
Relevant log output and stack trace
No response

I can work it around with application's help:
SELECT
    ts,
    COUNT(1) RANGE '1h' as times
FROM keyboard_monitor
WHERE date_trunc('day', ts + INTERVAL '8 hours') = '2024-03-07'
ALIGN '1h'
ORDER BY ts ASC
LIMIT 10;

local_tz = tzlocal.get_localzone()
hours = int(local_tz.utcoffset(datetime.datetime.now()).total_seconds() / 3600)
if hours > 0:
    offset = f" + INTERVAL '{hours} hours'"
elif hours < 0:
    offset = f" - INTERVAL '{hours} hours'"
else:
    offset = ''
d = # get date
query = f"""
SELECT
    ts,
    COUNT(1) RANGE '1h' as times
FROM keyboard_monitor
WHERE date_trunc('day', ts{offset}) = '{d}'
ALIGN '1h'
ORDER BY ts ASC
LIMIT 10;
"""
...
df['ts'] = df['ts'].dt.tz_localize(pytz.utc).dt.tz_convert(local_tz)

It's true. The third parameter is not supported now. I'll submit a patch to update the doc.

@waynexia how much effort we get it supported? It seems the underneath DataFusion's fn doesn't support the third parameter also?

It seems the underneath DataFusion's fn doesn't support the third parameter also?

Yes.
It won't be too burden for this single function. But the problem is many functions are not aware of timezone.

Shall we contribute to DataFusion first to get it supported or work around in our repo? If the former is preferred, does DataFusin community have some related issues so far?

I'm preparing a proposal to enhance the timezone support for DF. The specific point related here is to enhance some functions.

Closed for now. Open a new issue once DataFusion supports it.


[fix][client] Avert extensive time consumption during table view construction

Reopen https://github.com/apache/pulsar/pull/21170
Motivation
If a topic persistently experiences a substantial quantity of data inputs,  the act of reading all the messages present in this topic to build a TableView can take an excessive amount of time.
Modification
In the process of constructing the TableView, initially, the last message ID of the current topic is procured. Consequently, once this last message ID has been reached, the creation ensues to its completion.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

/pulsarbot run-failure-checks


Save Editor Broken

When I download the edited save, the next time I boot up the game, it loads the tutorial mission . I have no idea why it keeps wiping my progress.

Seconded

yup same


"rustup target add" fails for required components

If you rustup target add for the host toolchain's standard library it returns an error, but for scripting it'd be nice if it just said "OK" instead perhaps?

Yep.

Adding rustup output for easier search: (I almost overlooked this issue)
$ rustup target add aarch64-unknown-linux-gnu
info: component 'rust-std' for target 'aarch64-unknown-linux-gnu' is up to date

$ rustup target add x86_64-unknown-linux-gnu
error: component 'rust-std' for target 'x86_64-unknown-linux-gnu' was automatically added because it is required for toolchain 'stable-x86_64-unknown-linux-gnu'

2 years later, and I just encountered a CI error for this. Did this issue get lost?

The same error on travis-ci:
$ if [[ $TRAVIS_OS_NAME = linux && $HOST != $TARGET ]]; then rustup target add $TARGET; fi
error: component 'rust-std' for target 'x86_64-unknown-linux-gnu' was automatically added because it is required for toolchain 'stable-x86_64-unknown-linux-gnu'

Ditto. I'm seeing this error on our Windows build nodes:
+ rustup.exe target add x86_64-pc-windows-msvc
error: component 'rust-std' for target 'x86_64-pc-windows-msvc' was automatically added because it is required for toolchain 'stable-x86_64-pc-windows-msvc'

Very confusing error message IMHO; I'm really not sure why this command would fail with an error that sounds like a success message.


changelogs: Add CVE info to changelogs

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/docs

it was half wrong - updated


Map navigation not migrated

Please update map navigation as it is missed out from the documentation

The tree component- It should highlight on hover but is not currently

Duplicated issue https://github.com/siemens/ix/issues/65

@danielleroux  - I have also included another issue tree view not getting highlighted

@supreethaPavank  please open separate issues for the problems. Add try to fillout the predefined issue template


✨ Clicking on a rule's code in the tooltip open the rule's documentationUrl in the browser

Fixes #235
Allow to "click to know more" on a problem's rule code, using the rule/ruleset documentationUrl.
This allow the user to access a richer documentation and to not be restricted to just the error message/error code.
Checklist

[x] Tests added / updated
[ ] Docs added / updated (I'm not sure there are docs that need to be updated)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

The error-code becomes clickable (in the Problems view but also in the tooltip).
The link is constructed following the rules defined here:

if the rule has it's own documentationUrl, we use it
otherwise we use the ruleset's documentationUrl (if it exists), with #the-rule-code appended
the implementation also work for extended rulesets has we access each rule's "owner" (i.e. owning ruleset)

Additional context
🚨This feature requires Diagnostic.codeDescription, with is available in https://www.npmjs.com/package/vscode-languageserver-types > 3.16, which required upgrading some other vscode-languageserver and client dependencies.
I'm using a basic ruleset to test it locally, but I've not pushed it:
formats: ["oas3"]
documentationUrl: https://example.com
extends: spectral:oas
rules:
  with-direct-documentation: #should have the doc https://example.com/direct
    documentationUrl: https://example.com/direct
    severity: error
    given: $.tags[*]
    then:
      field: description
      function: falsy
  without-direct-documentation: #should have the doc https://example.com#without-direct-documentation
    severity: error
    given: $.tags[*]
    then:
      field: description
      function: truthy

@ouvreboite Would you mind fixing the conflicts? I'd love to get this merged 🙏🏼

@mnaumanali94 this should be good now :)

@ouvreboite Thanks for the quick turnaround and your contribution. I'll work on getting this out.

@ouvreboite e2e tests are failing. Do you want to take a look? Otherwise i'll give it a go later 🙏🏼

I'll have a quick look

@mnaumanali94

I've pushed updated snapshots for the E2E tests
On my machine, I also had to upgrade the VSCode dependencies (targeting the latest VSCode version). I don't understand why this would be needed, so I've not pushed yet. Do you want me to push it?
I've noted that the generated documentation url for the base rule set look like this (as expected): https://meta.stoplight.io/docs/spectral/docs/reference/openapi-rules.md#oas3-api-servers

But, if you follow the link, there is a redirection to https://meta.stoplight.io/docs/spectral/4dec24461f3af-open-api-rules (I suppose there is some kind of URL versioning happening). So, this get you to the ruleset's doc, but the #oas3-api-servers is lost during the redirection.

I've pushed updated snapshots for the E2E tests
On my machine, I also had to upgrade the VSCode dependencies (targeting the latest VSCode version). I don't understand why this would be needed, so I've not pushed yet. Do you want me to push it?

Yes push away. I can take a look

I've noted that the generated documentation url for the base rule set look like this (as expected): https://meta.stoplight.io/docs/spectral/docs/reference/openapi-rules.md#oas3-api-servers
But, if you follow the link, there is a redirection to https://meta.stoplight.io/docs/spectral/4dec24461f3af-open-api-rules (I suppose there is some kind of URL versioning happening). So, this get you to the ruleset's doc, but the #oas3-api-servers is lost during the redirection 😞.

We can fix the links in the ruleset separate from this feature.

@mnaumanali94 I've pushed a new commit with the VSCode upgrade


Fix errors when doing identify transform when no OCIO is present.

Well, sometimes you (and by "you" I mean some script you wrote) ask
oiiotool to do a 'colortransform sRGB sRGB' or some other color
transform that is just identity. Fine. But if $OCIO environment variable
is not defined so no OCIO config is found, that was an error!
Simple fix -- detect that case and return a do-nothing color processor.

Fixes #1550


Enable cache ops for beam search

This patch enables the swap_blocks and copy_blocks functions, enabling beam search serving.

LGTM


[Feature Request] - After I used the tokio async method to package, I couldn't build successfully.

After I used the tokio async method to package, I couldn't build successfully.
pub unsafe fn extend_lifetime<'a, T: ?Sized>(r: &'a T) -> &'static T {
    std::mem::transmute::<&'a T, &'static T>(r)
}

#[async_recursion::async_recursion(? Send)]
pub async fn remote_to_local(client: &mut SftpFs, src: &Path, dst: &Path, dir_mode: u32) -> Result<(), std::io::Error> {
    let mut client = unsafe { extend_lifetime(client) };
    let dst = unsafe { extend_lifetime(dst) };
    let src = unsafe { extend_lifetime(src) };

    let file = client.stat(src).unwrap();
    let meta = file.metadata();
    if meta.is_dir() {
        std::fs::create_dir_all(dst.parent().unwrap());
        let entries = client.list_dir(src).unwrap();
        for entry in entries {
            let mut dst_file = PathBuf::from(dst);
            dst_file.push(entry.name());
            remote_to_local(&mut client, &entry.path(), &dst_file, dir_mode).await.unwrap();
        }
    } else if meta.is_file() {
        let h = tokio::task::spawn_blocking(move || -> Result<(), std::io::Error> {
            std::fs::create_dir_all(dst.parent().unwrap());
            let mut writer = std::fs::OpenOptions::new().create_new(true).write(true).open(dst).unwrap();
            client.open_file(src, Box::new(writer)).ok().unwrap();
            Ok(())
        });
        h.await.unwrap()?;
    }
    Ok(())
}

error[E0277]: `(dyn SshKeyStorage + 'static)` cannot be shared between threads safely
   --> src/bin/sftp.rs:88:45
    |
88  |           let h = tokio::task::spawn_blocking(move || -> Result<(), std::io::Error> {
    |  _________________---------------------------_^
    | |                 |
    | |                 required by a bound introduced by this call
89  | |             std::fs::create_dir_all(dst.parent().unwrap());
90  | |             let mut writer = std::fs::OpenOptions::new().create_new(true).write(true).open(dst).unwrap();
91  | |             client.open_file(src, Box::new(writer)).ok().unwrap();
92  | |             info!("接收文件");
93  | |             Ok(())
94  | |         });
    | |_________^ `(dyn SshKeyStorage + 'static)` cannot be shared between threads safely
    |
    = help: the trait `Sync` is not implemented for `(dyn SshKeyStorage + 'static)`
    = note: required for `Unique<(dyn SshKeyStorage + 'static)>` to implement `Sync`
    = note: required because it appears within the type `Box<(dyn SshKeyStorage + 'static)>`
    = note: required because it appears within the type `Option<Box<(dyn SshKeyStorage + 'static)>>`
    = note: required because it appears within the type `SshOpts`
    = note: required because it appears within the type `SftpFs`
    = note: required for `&SftpFs` to implement `Send`
note: required because it's used within this closure
   --> src/bin/sftp.rs:88:45
    |
88  |         let h = tokio::task::spawn_blocking(move || -> Result<(), std::io::Error> {
    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: required by a bound in `spawn_blocking`
   --> /root/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/tokio-1.21.1/src/task/blocking.rs:205:28
    |
205 |         F: FnOnce() -> R + Send + 'static,
    |                            ^^^^ required by this bound in `spawn_blocking`

It should be fixed with 0.4.0


CrName + Role Naming Scheme

Addressing Issue: https://github.com/bluek8s/kubedirector/issues/309

Plz add some PR description here about how the new scheme generates names for the various components, any validation and failure-case issues, or whatever else might be interesting/useful for docs and for code review.


Crash with visuals

Forge version: 2805
Installed mods:

VanillaFix version: 1.1.1-134 (latest untagged)
Visuals: 2r (GitLab: https://gitlab.com/DragonForge/visuals/tree/1.12.2)
HammerCore: <IP_ADDRESS>, a library Visuals depends on (GitLab: https://gitlab.com/DragonForge/HammerCore)

Finally the crash report: https://paste.imirhil.fr/?e3a1e1c0d248cb93#FilfNpXuHvaNcUAyZvB3IsLbtu4Fp9xKGALLSqYLDTw=

Closing this since the crash report is gone,, please don't use temporary pastes.


colorized point clouds?

Is there a mechanism to get a stream of colorized point clouds with the calibration applied, perhaps as pointcloud2 rosmessages? I was working on implementing such a feature but realized I hadn't asked if it already existed. Thanks!

Hi,
yes this feature exists already. Just run it with the provided launch file and then XYZRGBA point clouds are published.


Saving the output

Is there a way to save the generated output, as a .gif or any other format? @SjoerdTilmans

@Bullish0407 , currently recording is not part of the package, I always use OBSstudio to record my screen


upgrading to Spark 2.0.2

Current coverage is 80.88% (diff: 100%)

Merging #610 into master will not change coverage

@@             master       #610   diff @@
==========================================
  Files            79         79
  Lines          8008       8008
  Methods        1333       1333
  Messages          0          0
  Branches        991        991
==========================================
  Hits           6477       6477
  Misses         1169       1169
  Partials        362        362

Powered by Codecov. Last update b95520e...8aad6b4


this value in new Function()

Continuing from https://github.com/Agoric/realms-shim/pull/17
As also revealed in test262, the this value in functions created in sloppy mode don't point to the global object. This is a current limitation of the shim.
Edit: the shim documents that all code executes in strict mode. However, as with the post above, it comes as a surprise, because using Function() in the shim creates a function in strict mode, not a function in sloppy mode as expected. Outside of the shim, strict mode is not transitive, and code executing in sloppy mode can evaluate code in sloppy mode. Developers might not be aware of that situation when using Function() or eval(). The PR above was created to fix the this binding, but strict mode has many other impacts on the behavior of Function() that can cause surprises, for example:
Function('a,a', 'return a')(1,2); // throws in strict mode, returns 2 in sloppy mode

We should document clearly along those lines:
eval('(foo')) /* behave like */ (0, eval)('"use strict"; (foo)')
Function('return foo') /* behave like */ Function('"use strict"; return foo')

However, point to note, the shim actually uses:
Function('return foo') /* behave like */ (0, eval)('"use strict"; (function anonymous() { return foo})')

I am not aware of a difference in behavior, but we should also add this to the documentation.

Closing this requirement for two reasons:

All code in SES is strict mode. All code in strict mode has the this value of Function set to undefined, this is according to specs. In plain language:

That means, among other things, that in browsers it's no longer possible to reference the window object through this inside a strict mode function.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode

SES 2.0 supports globalThis and can be used everwhere, and a this value bound to the global object is a duplication.


wordpress: remove bundled plugins and themes

Description of changes
Wordpress bundles some non-essential plugins and themes, then pesters users to upgrade them. As we make the whole webroot readonly, it is not possible to trivially delete them. Instead we should have users explicitly install plugins via the existing nixos module.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thia seems to be a breaking change, so I think it needs a release notes entry

yep, happily; feel free to make suggestions for how to do that different, as I have not before.

Good idea to remove the default plugins and themes from the core package. We should at least include the default theme package in the module as a default so that there is at least a minimal functionality given

agreed, I was hesitant to do too much work in this one change, lest it get shot down, but I think that having services.wordpress.sites.<name>.themes default to just pkgs.wordpressPackages.themes.twentythree, and then we can bump that as needed or at major version bumps. (pr inbound)

There seems to be a merge conflict now

Result of nixpkgs-review pr 210873 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

1 package built:

wordpress (wordpress6_1)

Result of nixpkgs-review pr 210873 run on x86_64-linux 1

1 test built:

nixosTests.wordpress

When trying to open the Wordpress site I get the error message The theme directory "twentytwentythree" does not exist.

yep, missed that one; converted it over to a draft; my local testing involves a bodge, thus it was occluded:
plugins = builtins.map (pkg: pkg.overrideAttrs (_: {name = pkg.wpName;})) [pkgs.wordpressPackages.themes.twentytwentythree];

Please rebase on master :)

Oh looks like there got something deleted while rebasing

thanks, that should be everything; but if not I am happy to make it better

Result of nixpkgs-review pr 210873 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

1 package built:

wordpress (wordpress6_1)

Works as expected, really cool improvement! Thank you!

Default theme is activated and running if no other is specified

Result of nixpkgs-review pr 210873 run on x86_64-linux 1

1 test built:

nixosTests.wordpress


Intructions for first time user

fixes #148 . Added a section for the first time user with complete commands which are required to successfully build a application using corral

@rhagenson @EpicEric If either of you has time, do you care to weigh-in? I think getting a perspective other than mine would be good.
@adeel41 has some good stuff going on here.

Overall looks good to me. I had minor comments, but not major issue taken with the example driven approach of starting a new corral project.
One overall concern I have and I pose it as a personal preference more than a necessary rule: Do we want to keep the capitalization of corral consistent so it is always "corral does this and that" rather than "Corral does this and that"? Or is it corral the command and Corral the program?
As I was writing I thought of another concern, I remember having to add some corral directories to .gitignore, do we want to mention _repos/ and _corral/ in this section as a parenthetical aside of "(Running corral fetch will generate two directories _repos/ and _corral/ in your project which you may want to add to .gitignore.)" ?

I think corral is the command and Corral is the program.

I'll have another look at this in the evening.

@rhagenson thank you for your assistance in reviewing.


Hey you, make it work in vim

I don't know what to say here, but yeah whatever

We see through your disguise, Prime!

@NotJuba May I ask why you closed this issue?
You no longer need it?


clean install php7.1 raises database issues

recreation traceback,
OS: debian stretch
mysql database
php7.1 with pdo_mysql active
php app/console doctrine:database:create exits succesfull
php app/console version:install fails

posible solution is to manualy insert the table with the modification issue_label_id INT NOT NULL
after that convert the alter the table ver_user  set locked , expired, credentials_expired to a default 0 instead of none


Drop and open in same window

Currently opens a new window

This is perhaps a BIG one that undermines the foundation of Atom...but I find it quite irritating after coming from Sublime: I would like to be able to drag random files into a project/Atom instance so I can reference code side–by–side. Currently if I drag a random file from the finder into an Atom instance it automatically opens a new instance with the folder containing that file as the project root. Since I like to code in fullscreen, this means switching between a number of fullscreen Atom instances to look at or copy snippets of code. This isn't a particularly desirable workflow.

Can this issue please be reopened? I'm using Atom 1.2.4 and when you drag 3 files into the atom window or highlight them in explorer->right click->Open with Atom, Atom will still open each file in a new window. This is extremely annoying. People kept reporting that this wasn't fixed in #1722 as indicated, but as a result of all the feedback which indicated that clearly people thought the issue hadn't been fixed, the issue was simply locked (not at all helpful).
It's fine to close duplicate issues, but in this case it seems like the fix for #1722 clearly didn't address this issue.


why in the "/home/sjtu/code/MICCAI2015-code-master/demo/class/bindata/predictions"  three blank images

right now after I run the "/home/sjtu/code/MICCAI2015-code-master/demo/class/run.sh" I found that in the "/home/sjtu/code/MICCAI2015-code-master/demo/class/bindata/predictions" there are just three blank image like this:

and the  in the command window it reads like this:
Analyzing image ./bindata/predictions/BM_GRAZ_HE_0008_01.png (66.6667%)
=== INDIVIDUAL IMAGE STATISTICS ===
image_conf_mtrx =
<PHONE_NUMBER>
       0           0

Total detections: 1440000, total valid ground truth: 364
Ground truth out of bounds: 0 (0.000000%)
Image accuracy: 0.000253, distance error mean (SD): 9.998339 (0.015778)
Recall: 1.000000, Precision: 0.000253, F1: 0.000505
1.Have I got something wrong? Is it that when the optimazation is done, the three blank images will turn into  the cell detection result images?
2. What is the difference between "class" folder files and "regr"  folder files? Run the "run.sh"  in the two different folders will generate different results?

The class method implements a binary Random Forest classifier that predicts, for each pixel, the probability of being a cell center. The regr method is the proximity score regression.
The three images should not be white. It seems that the classifier predicts a cell center for each pixel, which is weird. What's your system config?

@pkainz   Ubuntu14.04, Matlab 2015a Did you mean this environment?

@brisker Yes, and I also mean the versions of the Random Forest dependencies.

@pkainz    Opencv3.0.0 ，libblitz 0.0.0,  libconfig++ 9.1.3, libboost1.55.0, cmake 2.8,

@brisker Looks good, does the code compile without problems? I haven't tested with OpenCV 3 yet, I used OpenCV 2.4.8 and 2.4.9. Can you attach class/bindata/trees/tree_0.txt here?

@pkainz   I just compile it again(class) and it reads like this:
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
Linking CXX executable icgrf-celldet-class
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Built target icgrf-celldet-class
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
I think there is no problem in compilaton. But I do not quite understand what do you mean "attach class/bindata/trees/tree_0.txt"?

@pkainz   I just compile it again(class) and it reads like this:
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
Linking CXX executable icgrf-celldet-class
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Built target icgrf-celldet-class
/usr/bin/cmake: /home/sjtu/anaconda2/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
I think there is no problem in compilaton. But I do not quite understand what do you mean "attach class/bindata/trees/tree_0.txt"?

@brisker A sibling directory of predictions (you showed me in your screenshot) should be trees. Attach the file tree_0.txt to your next post in this forum so that I can examine the structure of one of the trees.

tree_0.txt

The tree look reasonable, so training works properly. There must be some issue when writing out the images. Can you try with OpenCV 2.4.9?

@pkainz   If I need to reinstall opencv, can you give some advice to avoid possible problems? just download opencv2.4.9 and install? Or do something in advance?

@pkainz  after try with opencv2.4.9, the images looks like this:

but why the recall, precision all 0 or NaN?
I attached a log.txt and could you please take a look?(after run the run.sh in the class folder
log.txt
)

@pkainz   Besides, I have run the run.sh in the regr folder, it seemed that the training process is really slow. So is it naturally a lot slower than the "class" method?

@pkainz

@brisker These values you mentioned are for a confidence (class) or score (regr) threshold of 255 (in the 8bit range). The important values are the ones with the prefix best_*, which are non-zero and non-NaN's in your case.
The way these post-processing (evaluation) scripts work is as follows:

smooth with a Gaussian
remove low scores/confidences using a threshold (which we also vary in the 8-bit grey value range, i.e. at each possible grey value, to determine the precision-recall curves)
perform non-maximum suppression to determine local maxima

Therefore you get a perf_data matrix, where - for each threshold - the performance measures are recorded. Btw,  you should also see a file best_results.txt in your results folder, which holds the best threshold and the corresponding performance values.
For the other problem with the white images, I will have to update the code for OpenCV >= 3.0.0 compatibility.

i attach a log.txt and could you please take a look？ the reason I attached it is that i found something wrong but i can not figure out where is wrong.
发自我的 iPhone

在 2016年8月31日，02:08，Philipp Kainz<EMAIL_ADDRESS>写道：
@brisker These values you mentioned are for a confidence (class) or score (regr) threshold of 255 (in the 8bit range). The important values are the ones with the prefix best_*, which are non-zero and non-NaN's in your case.
The way these post-processing (evaluation) scripts work is as follows:
smooth with a Gaussian
remove low scores/confidences using a threshold (which we also vary in the 8-bit grey value range, i.e. at each possible grey value, to determine the precision-recall curves)
perform non-maximum suppression to determine local maxima
Therefore you get a perf_data matrix, where - for each threshold - the performance measures are recorded. Btw, you should also see a file best_results.txt in your results folder, which holds the best threshold and the corresponding performance values.
For the other problem with the white images, I will have to update the code for OpenCV >= 3.0.0 compatibility.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@brisker sorry, can't view the attachment...

@pkainz   i got error when running run.sh and i can not save the figures， the error is in the log.txt I have attached in my previous message…

@pkainz  the log.txt is attached in the message 2  days ago

@brisker Nothing's wrong, there are simply no peaks in the prediction map above the threshold of 249. Therefore, you don't find any true positives, or false positives. Hence, you miss all ground truth cells and according to the definitions of the metrics you end up with precision being NaN (division by zero) and recall being zero.
Check the log for a threshold around 150. I ignored all these values, since they don't contribute anything to the performance, but were just in the evaluated range. If you want to dig deeper, examine the computeDetectionPerformance function.

@brisker Regarding the error in the log: the savefig API seems to have changed in Matlab >2013b. Check the documentation for a substitute and replace the call in the evaluate.m script.

@pkainz    The bug reads like this:
error using savefig (line 128)
No file name specified.
error saveasfig (line 6)
savefig(h, name);
error saveas (line 140)
feval( ['saveas' format], h, name )
error evaluate (line 284)
saveas(prPlot, strcat(path_figures, method_str_short, '_pr-curve'),
'fig');
error run (line 96)
evalin('caller', [script ';']);
and I do not quite understand you by saying "replace the call in evaluate.m" since  the bug line in evaluate.m reads like this:
saveas(prPlot, strcat(path_figures, method_str_short, '_pr-curve'), 'fig');
Did you mean replace saveas?

@brisker Yes, either adapt this line to work with your Matlab version and you will be fine having figures, or otherwise turn off the plotting of this figure, e.g. see here for the class method. If none of this works, just comment these lines and check again.

@pkainz   The problem is the savefig.m has the same name with the /home/sjtu/disk1/MICCAI2015-code-master/code/toolbox/external/other/savefig.m , I rename it, and it went well.

@brisker Alright, I'll close this issue then.


Add in the Bar tab the variant list selection

The target is to show only one variant "Bar - tab demo" with a customization bottom sheet to allow:

"Navigation item count" - step counter from 2 to 5

The demo example should show the bar adapting to the 2 to 5 navigation display in the center of the page.
But as a dev would uses a default OS behavior to build the normal app that we cannot use in this example page, the code page in this example page should include a comment with something like this:

// The code used in this page should not be used as bottom menu implementation. Instead the current app's menu implementation should be used

Based on today's design review the proposed integration of the tab bar is ok.
The badge>text option should only show a "?"
All badge options should only see one item highlighted with a badge


About the negative results

The output of the run.py is:
Epoch 1 finished. LB: -193.587364299, time: 23.8140439987
Epoch 2 finished. LB: -143.980627603, time: 22.0817909241
Epoch 3 finished. LB: -131.137932297, time: 23.4465258121
Epoch 4 finished. LB: -124.642257157, time: 23.8417210579
Epoch 5 finished. LB: -121.252833853, time: 23.6574602127
Epoch 6 finished. LB: -119.15968416, time: 23.1084840298
Epoch 7 finished. LB: -117.709356011, time: 22.3512649536
Epoch 8 finished. LB: -116.877082335, time: 21.8744499683
Epoch 9 finished. LB: -116.22289723, time: 22.3257608414
Epoch 10 finished. LB: -115.719955582, time: 20.7604548931
Epoch 11 finished. LB: -115.54030943, time: 22.0784511566
Epoch 12 finished. LB: -115.27684112, time: 20.8639421463
Epoch 13 finished. LB: -115.157892119, time: 21.7074420452
Epoch 14 finished. LB: -115.048720333, time: 21.4428908825
Epoch 15 finished. LB: -115.139338243, time: 20.6817419529
Epoch 16 finished. LB: -115.10803394, time: 21.5580871105
Epoch 17 finished. LB: -115.356428941, time: 20.9895000458
Epoch 18 finished. LB: -115.450786987, time: 21.0134358406
Epoch 19 finished. LB: -115.609509225, time: 23.0492949486
Epoch 20 finished. LB: -115.79125576, time: 21.424300909
Epoch 21 finished. LB: -116.165480415, time: 20.8156960011
Epoch 22 finished. LB: -116.473525505, time: 19.812361002
Epoch 23 finished. LB: -116.976544561, time: 22.5618448257
Epoch 24 finished. LB: -117.463427192, time: 24.1021668911
Epoch 25 finished. LB: -117.812150993, time: 23.7749929428
Epoch 26 finished. LB: -118.468181399, time: 26.9134569168
Epoch 27 finished. LB: -119.240615465, time: 20.8871181011
Epoch 28 finished. LB: -120.083818429, time: 19.5136089325
Epoch 29 finished. LB: -121.050806927, time: 20.6999001503
Epoch 30 finished. LB: -122.010075855, time: 19.4959599972
Epoch 31 finished. LB: -124.140169278, time: 20.1035561562
Epoch 32 finished. LB: -125.953139953, time: 22.9646589756
Epoch 33 finished. LB: -127.621502075, time: 23.1584570408
Epoch 34 finished. LB: -132.044642884, time: 23.0254461765
Epoch 35 finished. LB: -133.090569264, time: 24.1230459213
Epoch 36 finished. LB: -138.949246144, time: 23.9465181828
Epoch 37 finished. LB: -150.077173919, time: 23.2902860641
Epoch 38 finished. LB: -150.10251959, time: 23.6436150074
Epoch 39 finished. LB: -183.881277206, time: 22.448307991
Epoch 40 finished. LB: -182.635050123, time: 24.3606519699
LB on validation set: -195.678884337

I'm not sure it is the right result. Since according to your ipython notebook on your blog, the results are positive and decrease.

Thanks for making an issue. I made an embarrassing mistake forgetting to flip b1 and b2 of adam.
It's fixed now, please let me know if you find anything else.


[T3A3][T09-A2] Zachary

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


Disable ripple effect

Can anyone tell me how to disable how to disable ripple effect??
thanks

same issue .

anyone figure out this?


Hard to find the selectors

Where for example is the "hello-app" selector. From: selector: 'hello-app',

It's making it really hard for me to follow through.


Implement "CREATE TABLE AS"

…with column constraints then inserts the subquery results
Summary of the changes / Why this improves CrateDB
This is regarding #9999
documentation remaining
Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Can one of the admins verify this patch?

ok to test

I have followed your suggestion and now it handles more sub-types of analyzedRelations and the sub-types of symbols from outputs method. Also added a few test cases. (Currently it does 'new' instead of using variants of 'is', will look into it. )
Once I figure out, i will add more test cases and expand on the extractor logic. ( it probably does not handle all cases yet)
Lastly, please help on the jenkins pr_test issue. Not sure how to handle this myself without looking into the error messages. Thank you.

Dear @jeeminso,
thanks a bunch for following up on this. While @mfussenegger will have to take a look at the amendments again, I can share the output of the Jenkins job with you in the meanwhile. It is just the Checkstyle plugin which reported some violations.
Errors
> Task :libs:sql-parser:checkstyleMain

[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/AstVisitor.java:283:64: '{' at column 64 should have line break after. [LeftCurly]
[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/AstVisitor.java:283:104: '}' at column 104 should be alone on a line. [RightCurlyAlone]
[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/CreateTableAs.java:1: Line does not match expected header line of '^/\*'. [RegexpHeader]
[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/CreateTableAs.java:5:51: WhitespaceAround: '{' is not preceded with whitespace. [WhitespaceAround]
[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/CreateTableAs.java:19:26: '{' at column 26 should have line break after. [LeftCurly]
[ant:checkstyle] [ERROR] /var/lib/jenkins/workspace/CrateDB/crate_on_pr/libs/sql-parser/src/main/java/io/crate/sql/tree/CreateTableAs.java:19:47: '}' at column 47 should be alone on a line. [RightCurlyAlone]

> Task :libs:sql-parser:checkstyleMain FAILED

Warnings
Might not be related to your change.
> Task :server:compileTestJava

/var/lib/jenkins/workspace/CrateDB/crate_on_pr/server/src/test/java/org/elasticsearch/test/disruption/LongGCDisruption.java:249: warning: [removal] suspend() in Thread has been deprecated and marked for removal
                        thread.suspend();
                              ^

/var/lib/jenkins/workspace/CrateDB/crate_on_pr/server/src/test/java/org/elasticsearch/test/disruption/LongGCDisruption.java:270: warning: [removal] resume() in Thread has been deprecated and marked for removal
                            thread.resume();
                                  ^

/var/lib/jenkins/workspace/CrateDB/crate_on_pr/server/src/test/java/org/elasticsearch/test/disruption/LongGCDisruption.java:317: warning: [removal] resume() in Thread has been deprecated and marked for removal
            thread.resume();
                  ^

You might be able to run that task on your own behalf?
With kind regards,
Andreas.

thank you Andreas @amotl, i will fix this

Thanks, @jeeminso. As pointed out by GitHub (This branch is out-of-date with the base branch), you might also want to rebase on top of current master while being at it.

Dear @jeeminso,
thanks again for updating this PR. With your recent improvements, the test harness outcome went green. Cheers!
I will leave just a minor comment about the grammar and humbly ask @mfussenegger or @seut to have a look at the overall patch again.
Apart from that, we should add respective documentation and maybe another integration test case which covers the full "CREATE TABLE AS" statement beyond the ColumnDefinitionExtractorTest.
So, I am humbly asking if you still feel like you want to add these improvements to this PR or would you like us to take over?
With kind regards,
Andreas.

@amotl @mfussenegger Thank you for your help. If you do not mind, I would like to try to complete it myself.

Dear @jeeminso,
thanks again for updating this PR. With your recent improvements, the test harness outcome went green. Cheers!
I will leave just a minor comment about the grammar and humbly ask @mfussenegger or @seut to have a look at the overall patch again.
Apart from that, we should add respective documentation and maybe another integration test case which covers the full "CREATE TABLE AS" statement beyond the ColumnDefinitionExtractorTest.
So, I am humbly asking if you still feel like you want to add these improvements to this PR or would you like us to take over?
With kind regards,
Andreas.

Thank you for your help. If you do not mind, I would like to try to complete it myself.

Sure, please go ahead!

I am currently in the process of writing unit tests, please help clarify a behaviour.
create table tbl (col object(strict) as (nested_col text));
create table cpy as select col['nested_col'] from tbl;
cr> select * from cpy;

From the above sql, should I get a column with the name, "nested_col" or "col['nested_col']" ?
I have opened more detailed feature request #10834 regarding this. Thank you!!

along with the question above, I have a new changeset commited:

removed the Extractor
fixed the grammar for brackets
refactored CreateTableAsAnalyzer and created SymbolToColDefConverter and its unittests.
written just a single test case written for CreateTableAsAnalyzer since it does not have much new logic.

Will look into plannerTest and IntegrationTest. Thank you.

From the above sql, should I get a column with the name, "nested_col" or "col['nested_col']" ?

col['nested_col'] would currently be the right behavior

@mfussenegger Thank you for your response. I have made the change but now there is an exception thrown
cr> create table cpy as select col['nested_col'] from tbl;
InvalidColumnNameException["col['nested_col']" conflicts with subscript pattern]

commented code removed
unnecessary wrapper method removed
merged to the shared version of DataTypeToColumnType()

I didn't think any further testing is required, please advise.
If so, documentation should be the only task remaining by now.

commented code removed
unnecessary wrapper method removed
merged to the shared version of DataTypeToColumnType()

I didn't think any further testing is required, please advise.
If so, documentation should be the only task remaining by now.

reverted the indentations and deleted resolve.conf, thanks for catching them
I changed "VARCHAR" to "varchar", because it caused SQLParseException[Cannot find data type: VARCHAR]. When the re-created ColumnDefinitions goes through TableElementsAnalysis, TYPES_BY_NAME_OR_ALIAS (a Map in DataType class) is referenced with "varchar" as the key. I could not find elsewhere to make it lowercase.
included a few integration tests
started on documentation

I have updated the docs, let me know if it needs further details.
Also, please help clarify what is the purpose of sql_features table. I am not sure what modification it requires regarding this feature. Thank you

the documentation build is failing, sorry will look into it, having trouble setting up my local env

@jeeminso I saw that the documentation tests now pass. Is there anything else missing from your side or is this ready for another round of review?

@mfussenegger it is ready for review. thank you

@mfussenegger @amotl thank you for your help!

should I squash all into a single commit from my end?

should I squash all into a single commit from my end?

No need, I rebased, squashed and merged.
Thank you again for the contribution :+1:


Add support for Gradle 5.x

The plugin should work on the last two Gradle major versions, so it should support Gradle 5.x. Furthermore this support should be backed by cross version tests. See e.g. https://github.com/marcphilipp/nexus-publish-plugin for how to set this up.

Gradle 7.0 is already out, so I won't add support for Gradle 5.

Actually it turned out, that the plugin supports Gradle 5.4 upwards...


Simplified web

Looks great, thank you so much for this! The only change I'm requesting: rendering a review item should render the game name as a link to the Steam page.
The HR tags are admittedly hideous, if you have any better ideas (CSS box/border?) feel free to update that too.


feat(kebernetes-incluster): fix lock file name

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area pkg
What this PR does / why we need it:
Fix lockfile name.
Which issue(s) this PR fixes:
None

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Lowaiz
Once this PR has been reviewed and has the lgtm label, please assign leodido for approval by writing /assign @leodido in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I forgot to update the lockfile name, causing the driverkit pods to instant quit when the compilation was successful

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, Lowaiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: cfa60abe20cbda9ab91229a660826a1eec87053f


Output File Naming Issue on Windows Leads to OSError

When attempting to run wayback-google-analytics with the --output json option on Windows, the program fails during the output file generation phase, raising an OSError related to an invalid argument in the file path. This issue appears to be caused by the inclusion of characters in the automatically generated file name that are not allowed in Windows file paths (e.g., :).
Steps to Reproduce:
Execute the command with the following parameters:
wayback-google-analytics --urls https://someurl.com https://otherurl.org --output json --start_date 01/10/2012 --end_date 25/10/2012 --frequency hourly
The command fails after processing with an OSError regarding an invalid file name argument.
The execution fails with the following error:
OSError: [Errno 22] Invalid argument: './output\\16-02-2024(15:38:18).json'
Additional Information:

Operating System: Windows
Python Version: 3.11.8
Tool Version: 0.2.2

Ciao!

Thanks for finding this issue, @martyna1221 ! Extra thanks for being so clear in your issue writeup.
This is an oversight on my part - some of the file paths generated in output.py aren't very inclusive of Windows users.
I'll take some time this evening to look through the code and hopefully get a fix out soon.

Hi!
Replacing ln. 29 with this file_name = datetime.now().strftime("%d-%m-%Y_%H-%M-%S") helped.
Thanks!


Self-relations required 1-to-1 disallowed in one case but still possible

Bug description

Given the following schema
datasource db {
  provider = "mysql"
  url      = "mysql://root@localhost:3306/prisma_test2"
}

model User {
  id           String  @default(cuid()) @id
  bestFriendId String  @unique
  bestFriend   User    @relation("BestFriend", fields: [bestFriendId], references: [id])
  user         User    @relation("BestFriend")

  @@index([bestFriendId], name: "BestFriend")
}

If you try to migrate a schema with both back- and forward-relations required, you'll get the following error:
error: Error validating field `user` in model `User`: The relation fields `user` and `bestFriend` on Model `User` are both required. This is not allowed for a self relation because it would not be possible to create a record.

The means you can either apply an optional ? to user, bestFriend and/or bestFriendId. Enumerating the options
1. Apply to bestFriend
datasource db {
  provider = "mysql"
  url      = "mysql://root@localhost:3306/prisma_test2"
}

model User {
  id           String  @default(cuid()) @id
  bestFriendId String  @unique
  bestFriend   User?    @relation("BestFriend", fields: [bestFriendId], references: [id])
  user         User    @relation("BestFriend")

  @@index([bestFriendId], name: "BestFriend")
}

Error: error: Error validating: The relation field `bestFriend` uses the scalar fields bestFriendId. At least one of those fields is required. Hence the relation field must be required as well.

This looks good.
2. Apply to bestFriend & bestFriendId
datasource db {
  provider = "mysql"
  url      = "mysql://root@localhost:3306/prisma_test2"
}

model User {
  id           String  @default(cuid()) @id
  bestFriendId String?  @unique
  bestFriend   User?    @relation("BestFriend", fields: [bestFriendId], references: [id])
  user         User    @relation("BestFriend")

  @@index([bestFriendId], name: "BestFriend")
}

This migrates as expected. The field bestFriendId is now optional, so I can create a record without an attached bestFriend.
3. Apply to user
datasource db {
  provider = "mysql"
  url      = "mysql://root@localhost:3306/prisma_test2"
}

model User {
  id           String  @default(cuid()) @id
  bestFriendId String  @unique
  bestFriend   User    @relation("BestFriend", fields: [bestFriendId], references: [id])
  user         User?    @relation("BestFriend")

  @@index([bestFriendId], name: "BestFriend")
}

This migrates, where we end up with the following SQL:
CREATE TABLE `User` (
  `bestFriendId` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL,
  `id` varchar(191) COLLATE utf8mb4_unicode_ci NOT NULL,
  PRIMARY KEY (`id`),
  UNIQUE KEY `User.bestFriendId` (`bestFriendId`),
  KEY `BestFriend` (`bestFriendId`),
  CONSTRAINT `user_ibfk_1` FOREIGN KEY (`bestFriendId`) REFERENCES `user` (`id`) ON DELETE CASCADE ON UPDATE CASCADE
)

You'll notice that bestFriendId is no longer optional. This means you cannot create the first User.
Possible Solution
Two possible solutions:

Fix 3
Relax restriction (if you can create 2 records in a transaction).

Environment & setup

@prisma/cli          : 2.0.0
Current platform     : darwin
Query Engine         : query-engine de2bc1cbdb5561ad73d2f08463fa2eec48993f56 (at @prisma/cli/query-engine-darwin)
Migration Engine     : migration-engine-cli de2bc1cbdb5561ad73d2f08463fa2eec48993f56 (at @prisma/cli/migration-engine-darwin)
Introspection Engine : introspection-core de2bc1cbdb5561ad73d2f08463fa2eec48993f56 (at @prisma/cli/introspection-engine-darwin)
Format Binary        : prisma-fmt de2bc1cbdb5561ad73d2f08463fa2eec48993f56 (at @prisma/cli/prisma-fmt-darwin)

Since 2.12.0, the virtual side is enforced as optional. @matthewmueller can you confirm this fixes the problems raised in this issue?

I also tried the above and it seems to work fine now.

Is this still a problem or can this be closed?

This can be closed now.


Add index on api_review_id column in rule_violations table.

Fixes #1235

Codecov Report

Merging #1294 (47ec99e) into master (3f829a9) will increase coverage by 10.24%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #1294       +/-   ##
=============================================
+ Coverage     76.02%   86.27%   +10.24%
+ Complexity     1017       85      -932
=============================================
  Files           187       20      -167
  Lines          2937      255     -2682
  Branches        508       16      -492
=============================================
- Hits           2233      220     -2013
+ Misses          435       25      -410
+ Partials        269       10      -259

Impacted Files
Coverage Δ

cli/zally/utils/formatters/factories.go

cli/zally/domain/error.go

web-ui/src/client/app/components/editor.jsx

cli/zally/utils/formatters/markdown_formatter.go

.../kotlin/org/zalando/zally/dto/ViolationsCounter.kt

web-ui/src/client/app/services/oauth-firewall.js

...do/zally/ruleset/zalando/SecureAllEndpointsRule.kt

...do/zally/ruleset/zalando/ProprietaryHeadersRule.kt

...g/zalando/zally/ruleset/zalando/ApiAudienceRule.kt

...o/zally/ruleset/zalando/model/ZallyOpenApiModel.kt

... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f829a9...47ec99e. Read the comment docs.

:+

👍

:+1:

👍

👍

:+1:


scripts to display hunter-module dependencies

I've added two scripts to the modules directory
modules2dot.sh creates an overview over all hunter modules and how they are connected

module_dependencies2dot.sh creates an overview over the (recursive) dependencies of a specified hunter module

both scripts ignore the following modules to keep the graph simple
	hunter_status_print
	hunter_status_debug
	hunter_user_error
	hunter_internal_error
	hunter_fatal_error
	hunter_wiki
	hunter_test_string_not_empty

the dependencies are determined by lines starting with include(hunter_

Thanks, looks cool. Can you move them to maintenance directory. May be even maintenance/graphs (?)

where should the *.dot and *.png files go? maybe subfolders where the scripts are called? maintenance/graphs/dot and maintenance/graphs/png?

Very helpful.  I'm sure I'll be using this.  Thanks.

where should the *.dot and *.png files go? maybe subfolders where the scripts are called? maintenance/graphs/dot and maintenance/graphs/png?

Usually I'm using _ for temporary folders. So I think maintenance/graphs/_dot and maintenance/graphs/_png. You can add them to .gitignore too.

updated
both scripts are now in maintenance/graphs and create the dot-files and png-files in <working_dir>/_dot and <working_dir>/_png.
modules2dot.sh expects the path to the modules directory
module_dependencies2dot.sh expects a path to a hunter-module file

squashed


MathJax/ KateX rendering

Hello,
I have no clue whether it is something trivial or extremely complex to implement, but I would love to see latex rendering in joplin-webview.
I mainly use it for math stuff, and it works great on Joplin desktop :

However, Latex is not rendered in joplin-vewview:

I mainly use webvue to show my notes on computers on which Joplin is not installed (or on which I am not willing to put my synchronization credentials), and it is a bit of a bummer to miss this essential (to me) feature.
Anyway, this project really fills a gap for me and love it <3, keep it up and let me know if I can be of any help.

Hello.
Thanks for feedback.
I'll have a look (after the ascension week end).
It should be quite straightforward.
Could you please give me some text you would like to test, block, inline... otherwise I'll use some samples from the web

Hello @DouisLavid
I give a first try this morning:

I still have some things to fix:

TOC disappeared
the latex are rendered in code blocks or inline code (they shouldn't)
in the sum sign (sigma), the range are not on top and bottom of sigma sign, they are exposant and indice just after the sigma sign... I'll have to search the html render options I think.

Could you send me some your sample (you wrote as comment of this issue) so I can try with \begin \ end, aligned ...

Second try this evening with KaTex: easier and we are almost there (still some adjustments to not make latex in some cases, if I can):

Fix in 2.2.0.
Cf. this release for details.
I close the ticket, please test and comment (even if it works, it's a pleasure)


google around about different ML infra approaches from existing blogs

india to share kostas's work
output: list of approaches in google sheets document

Added an "ML infra" tab in job_quality_literature_review


typo: Double word "see"

@nschonni : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

Merging typo fixes


weights

Hi, the folder of model_weights contains the files of celeba.h5, shoes.h5, and svhn.h5.
How to generate this files?
Does this code contain to generate this file?
The paper says
[trained on thousands of image examples, the weights of the untrained generator are learned on one blurred image y only in the deblurring process itself],
but I still don't know how to generate these weights file when I use different data.
Thanks.

If you are using your own dataset, you have to train the GAN model by yourself and save the weights of the generator in folder model_weights.


ROPC remediation - configuration/index.md, use-http-context.md, new include file

Fixes #33757

Internal previews

📄 File
🔗 Preview link

aspnetcore/fundamentals/configuration/index.md
Configuration in ASP.NET Core

aspnetcore/fundamentals/use-http-context.md
Use HttpContext in ASP.NET Core

Fix avoid the use of passwords in production apps

Fixed. I forgot it was also in the 6 and 7 includes.


Add constructor test

Some JS contexts (such  as Cloudflare Workers) have a global EventTarget, but won't allow constructing new instances.
This PR adds a condition that checks if the constructor throws and overwrites the implementation in that case.

Thanks for pointing this out.
Closed by #6


imx477 camera / firmware issues with Orin/Forge

Almost have orin/forge setup working!  Having issues getting the camera to work.  The nvidia recommended way to get data from the imx477 camera is like so:
gst-launch-1.0 nvarguscamerasrc ! 'video/x-raw(memory:NVMM),width=(int)4056, height=(int)3040, format=(string)NV12, framerate=(fraction)30/1' ! nvv4l2h264enc bitrate=80000000 ! h264parse ! qtmux ! filesink location=test.mp4 -e
However, nvarguscamerasrc has been blacklisted. To get a better picture, I deleted ~/.cache/gstreamer-1.0/registry.aarch64.bin and re-ran gst-inspect-1.0, this produces this output in the syslog
[  246.719916] nvgpu: 17000000.ga10b               gp10b_priv_ring_isr:217  [ERR]  ringmaster intr status0: 0x00000000, status1: 0x00000003
[  246.719934] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:684  [ERR]  GPC0 write error: ADR 0x004199b0 WRDAT 0x00000000 master 0x0000000b
[  246.719936] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:688  [ERR]  INFO 0x1840820b: (subid 0x00000018 priv_level 0 local_ordering 1)
[  246.719938] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:694  [ERR]  CODE 0xbadf5040
[  246.719942] nvgpu: 17000000.ga10b nvgpu_cic_mon_report_err_safety_services:92   [ERR]  Error reporting is not supported in this platform
[  246.719945] nvgpu: 17000000.ga10b ga10b_priv_ring_decode_error_code:542  [ERR]  [Error Type]: client error
[  246.719947] nvgpu: 17000000.ga10b    decode_pri_client_badf50_error:353  [ERR]  [Extra Info]: no such address, value(0x40)
[  246.719953] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:684  [ERR]  GPC1 write error: ADR 0x004199b0 WRDAT 0x00000000 master 0x0000000b
[  246.719954] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:688  [ERR]  INFO 0x1840820b: (subid 0x00000018 priv_level 0 local_ordering 1)
[  246.719955] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:694  [ERR]  CODE 0xbadf5040

I'm not sure how to proceed, there's similar issues over on the nvidia developer's site, but the help stops for non-jetpack configurations.   Not sure if gp10b_priv_ring_isr is a cause or a symptom.  I've gone as far as overwriting all of the firmware with the firmware included with the latest JetPack, this didn't produce a change in behavior.  I checked and the md5sums for the for the firmware placed by the yocto build and what's jetpack and I think is being used is the same.

Hey @gsally-sarcos
Did you try with L4T stock ? if so, is it working properly ?

I've been able to get this to work for our board.  (8GB NX + Seeed j401 + imx477)  https://github.com/frc971/meta-frc971/tree/main is what I needed to do.
Your error sounds suspiciously like you are missing camera_overrides.isp

Almost have orin/forge setup working! Having issues getting the camera to work. The nvidia recommended way to get data from the imx477 camera is like so:
gst-launch-1.0 nvarguscamerasrc ! 'video/x-raw(memory:NVMM),width=(int)4056, height=(int)3040, format=(string)NV12, framerate=(fraction)30/1' ! nvv4l2h264enc bitrate=80000000 ! h264parse ! qtmux ! filesink location=test.mp4 -e
However, nvarguscamerasrc has been blacklisted. To get a better picture, I deleted ~/.cache/gstreamer-1.0/registry.aarch64.bin and re-ran gst-inspect-1.0, this produces this output in the syslog
[  246.719916] nvgpu: 17000000.ga10b               gp10b_priv_ring_isr:217  [ERR]  ringmaster intr status0: 0x00000000, status1: 0x00000003
[  246.719934] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:684  [ERR]  GPC0 write error: ADR 0x004199b0 WRDAT 0x00000000 master 0x0000000b
[  246.719936] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:688  [ERR]  INFO 0x1840820b: (subid 0x00000018 priv_level 0 local_ordering 1)
[  246.719938] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:694  [ERR]  CODE 0xbadf5040
[  246.719942] nvgpu: 17000000.ga10b nvgpu_cic_mon_report_err_safety_services:92   [ERR]  Error reporting is not supported in this platform
[  246.719945] nvgpu: 17000000.ga10b ga10b_priv_ring_decode_error_code:542  [ERR]  [Error Type]: client error
[  246.719947] nvgpu: 17000000.ga10b    decode_pri_client_badf50_error:353  [ERR]  [Extra Info]: no such address, value(0x40)
[  246.719953] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:684  [ERR]  GPC1 write error: ADR 0x004199b0 WRDAT 0x00000000 master 0x0000000b
[  246.719954] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:688  [ERR]  INFO 0x1840820b: (subid 0x00000018 priv_level 0 local_ordering 1)
[  246.719955] nvgpu: 17000000.ga10b      ga10b_priv_ring_isr_handle_1:694  [ERR]  CODE 0xbadf5040

I'm not sure how to proceed, there's similar issues over on the nvidia developer's site, but the help stops for non-jetpack configurations. Not sure if gp10b_priv_ring_isr is a cause or a symptom. I've gone as far as overwriting all of the firmware with the firmware included with the latest JetPack, this didn't produce a change in behavior. I checked and the md5sums for the for the firmware placed by the yocto build and what's jetpack and I think is being used is the same.

Hello, do you find a solution ? Was it the camera_overrides.isp file ?
About the CTI Forge board, do you have specific meta configuration ? Eventually can you share it ?

@AustinSchuh, let me give that a try.  Thanks for the pipelines for moving the data across the network!  I was using netcat to move data from the device.  It seems the the folks at Nvidia just don't understand (or maybe just don't care, who knows) the typical use case for their devices will be w/o a monitor; from their perspective, the jetson is essentially an ARM-based desktop replacement instead of an embedded system.  /soapbox :)
I found that when I copied the firmware from R35.3.1 (literally, everything), the gstreamer pipeline worked, but the captured images approximated white noise.  I will track down what is different between the two and report back.

This is the set of firmware I found required to get the camera in some state of working:
71aeb0f904c96faf47e9c5b50d1429bf  ./ga10b/acr-gsp.text.encrypt.bin.prod
f1173654b0b93793deb423926e08a289  ./ga10b/NETA_img.bin
74ee8d5f7c5e46460855edbcfa1c4f34  ./ga10b/NETC_img.bin
a63061b2a611edfc2156da95067be2db  ./ga10b/gpccs.bin
70381c0996cafc5c3a95048e7e80fda4  ./ga10b/acr-gsp.data.encrypt.bin.prod
faacccf6bd3d2406c955a088dbe92637  ./ga10b/gpmu_ucode_next_prod_image.bin
aa3b084a0e58b8be685ed5da70d20b3e  ./ga10b/gpmu_ucode_next_prod_desc.bin
057aae9c8b07ca45ba0f82c273803ac7  ./ga10b/acr-gsp.manifest.encrypt.bin.out.bin.prod
a81e07cbab124cae94a306be84851d77  ./ga10b/fecs.bin
b80198d40ca24294e78997171ab32d1c  ./ga10b/gpccs_pkc_sig.bin
88fe14b4c9858cf76868e880a4837e18  ./ga10b/fecs_pkc_sig.bin
0d7173de548b4336d599c53a4d5f54b5  ./ga10b/NETD_img.bin
d0a6011ae4bb38aa362a04bd17d55fc9  ./ga10b/NETB_img.bin
3073b4593b5448934e02f7365dd174e4  ./ga10b/pmu_pkc_prod_sig.bin
9c8df15b09e8aedf12389be56af71cf6  ./tegra23x/nvhost_nvjpg013.fw
e69a2bb8925060a55771cecb2750e09c  ./tegra23x/nvhost_nvenc080.fw
ea65bb723f52fbd2b636fd8702e44990  ./tegra23x/nvhost_nvdec050_desc_prod.bin
a06f613fd43a149eec0b311e3a5fdb89  ./nvhost_vic042.fw

These files are from the R35.3.1 jetpack /lib/firmware directory distributed with the RFS.
I'm using the camera_overrides.isp  from @AustinSchuh  https://github.com/frc971/meta-frc971/tree/main project.  The result is an out-of-focus image when I use this gstreamer pipeline:
gst-launch-1.0 nvarguscamerasrc sensor-id=0 num-buffers=10 do-timestamp=true ! \
	'video/x-raw(memory:NVMM), width=(int)4056,height=(int)3040, framerate=40/1' ! \
	nvvidconv ! \
	nvjpegenc ! \
	filesink location="./test-file.jpg"

I also discovered that "nvidia, tegra-camera-platform"  the space after the comma is very important!  When missing, this driver won't initialize, but if you have a camera depending on this driver, it will still initialize and appear to be running, but the code in drivers/video/tegra/camera/tegra_camera_platform.c is in some undefined state, leading to a kernel panic with no feedback.  I'll have to see if I can submit a patch to the file to add "nvidia,tegra-camera-platform" to of_device_id.


Refactores MRT_TabelBodyRow to CSS module

Added typescript module support (let me know if it's not necessary, I was getting typing errors otherwise)
Refactored MRT_TabelBodyRow to CSS Modules, used clsx to allow the classnames to be overwritten. Same as above, let me know if that's not required an I'll remove it

I think this is mostly the right idea, but I don't think I want to be changing the folder structure of the MRT components

Cool, should I just move the CSS file and the component code up a folder then?


MM-48432_Invite People - Invite as Guest

Summary
Adding the functionality to invite users as Guests
WIP

Privileges check for feature access and channels allowed
Reposition of selection autocomplete list after scrolling
e2e

Ticket Link
https://mattermost.atlassian.net/browse/MM-48432
UX Design: https://www.figma.com/file/mvJXgiirM4ucPW8bHAvM4G/MM-39720-Invite-People?node-id=1439%3A296925&t=J9QDbVYtfOHJG6q3-0
Checklist

[ x] Added or updated unit tests (required for all new features)
[ x] Has UI changes
[ x] Includes text changes and localization file updates
[x ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:

iPhone 14, iOS 16.2
Pixel 4, Android 12

Screenshots

Release Note
- Adding functionality to invite users by email or invite users from other teams on the server as guests.

Building app in separate branch.

Artifact links:
https://output.circle-artifacts.com/output/job/f92967d1-89f6-4889-81a0-0e465bf8b7fb/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/5ed27637-3912-45c5-bb4b-b4ba75d465bc/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

Hi @julmondragon On first pass this looks great! Everything worked as expected on the mobile app which is good.
However, the custom messages don't arrive with the invite email and after following the link to create an account I'm seeing this when I sign in. 🤔

That said, I'm going to keep testing it as I can see in the channel that 2 of my attempts were added to the channel but 2 others were not which makes no sense.

Hi @stevemudie thanks for the quick check!
The sign in issue seems to be caused by this issue https://mattermost.atlassian.net/browse/MM-50355 that was recently reported.
For other behaviors please be aware that, as mentioned in the description, there is still a WIP regarding privilege checks and channels allowed for invite, which will be added to the PR soon.

Building app in separate branch.

@stevemudie the PR is now complete with privileges and allowed channels checks.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/28061
https://circleci.com/gh/mattermost/mattermost-mobile/28060

Artifact links:
https://output.circle-artifacts.com/output/job/b693f5ce-eaa3-4abc-954c-15c0021d7089/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/8ef70a46-a6dd-4336-b501-06a5ff7dd6f6/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

From @matthewbirtch comments

For both 'invite as guest' and 'set custom message', we should make it so the entire row is tapable to toggle the switch. If I tap the text label right now, nothing happens.

I don't think this should be the case and only tapping on the switch should make it change as that is how it works on most apps, including the settings app on the OS

From @matthewbirtch comments

For both 'invite as guest' and 'set custom message', we should make it so the entire row is tapable to toggle the switch. If I tap the text label right now, nothing happens.

I don't think this should be the case and only tapping on the switch should make it change as that is how it works on most apps, including the settings app on the OS

Actually, that's my mistake. I was thinking of the behavior for radio buttons and checkboxes and somehow was expecting the label to be tappablr for switches too. You're right @elias, it's not standard for the label or entire row to be tappable for switches. Ignore that point @julmondragon.

@enahum @larkox given the development is complete here, are we okay to review this and merge assuming there are no major blocking dev concerns?

Also this branch has conflicts that needs to be resolved

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/28329
https://circleci.com/gh/mattermost/mattermost-mobile/28328

Artifact links:
https://output.circle-artifacts.com/output/job/2c837e7b-ab25-4e5c-9819-c846ff10bf55/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa
https://output.circle-artifacts.com/output/job/f51f8da8-eb31-402f-ac58-fb4ba15622a3/artifacts/0/tmp/artifacts/Mattermost_Beta.apk

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@enahum is going to help take over this PR

Thanks for the review @larkox but imho this needs a full refactor but now is lower on my priority list


Fixes broken tests

Hi!
I was able to fix almost all of the tests that were broken because of my previous change which added persistence. None of the tests use TestFSMRef or TestActorRef anymore so all of them are event based now. However, I commented few tests that are broken due to the issues in log compaction and snapshotting . I hope to fix the logic and repair these tests as well soon.

Skimmed the work and looks good, thanks for your help :)
Looking forward to yiur other PR then. Would be nice to be back on a passing suite

Thanks! Yeah, thats the goal. Decided to make a PR now cause next changes will be more about protocol fixes and not tests per se but it will lead to a passing tests as well. Tests are not 100 % reliable still but its actually impossible to make them fully reliable in distributed environment however most of the time they work fine.


Tests not passing??

Just wanted to check if you run the spec tests, do they pass. Locally and on Travis I am getting lots of test failures. Just want to rule out my environment setup. Looks like the tests are not inline with what the code is doing??
Here is a sample of what I see
https://travis-ci.org/peterabbott/puppet-nexus/jobs/155485350

You are right, I had the same trouble as you. I have fixed them into the pull request#76.

should be fixed now: https://github.com/hubspotdevops/puppet-nexus/pull/76

In the #76 I have created the configuration for Travis. Could you create an account on Travis and link this repository? Once done you can add a   build status into the readme.md. see https://docs.travis-ci.com/user/status-images/ for detail. Thanks to that you will see if your tests and syntax are OK after each new push.

Added


timerender: Revert extra changes to time in recent conversations.

Previously after merging #25012, users have reported unneccessary changes to the time in recent conversations. These changes builds on top of the previous changes and removes the unneccessary changes to the time in recent conversastions and makes sure the changes only applies to popovers.
Note:

This PR introduces a new function in web/src/timerender.ts called last_event_from date which is similar to last_seen_status_from_date and is used in call sites that were affect by the previous changes.
I have posted general screenshots of these changes. I'm not exactly sure how to change one's time so I'm relying on the testcases to check for the accuracy of these string text.

Screenshots and screen captures:

Before:

After:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[x] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

I fixed the unnecessary translation tags, rewrote the commit message to a more professional style, and also renamed the new function and reordered it to sit before the last_seen_status_from_date function, which is now correctly framed as a variant of the new method with the word "active" appended.
I think this should make it a lot easier to avoid future mistakes of this form in refactoring. That said, I hope you've learned the lesson from this that one should always do a grep like git grep last_seen_status_from_date and read all the code using a function when changing its behavior -- certainly the name suggested it was supposed to be exclusive for the buddy list, but that wasn't true, and the only way to make major changes to an existing function correctly is to actually audit its callers :).

@timabbott there was some failing testcases after the removal of translation tags on the lone variable only strings. I've updated the testcases to not mark those for translation as well. Should be good now.

Thanks, merged!


Transaction errors are not returned

Describe the bug
In case an operation within a transaction encounters an error, resulting in the transaction API response to be HTTP 400 + errors payload, the client handles it as a bulk error returningBulk operation failed but does not return the errors array. The client cannot process the error response payload.
The same appears to occur with bulk errors.

For reference:
try {
    const result = await xata.transactions.run([    {...}    ]);
} catch (error) {
    console.log(error.status);
    console.log(error.errors);
}

docs example will be added.


firefox can't build like pan package

Describe the bug
Firefox can't be easily built like the pan package in a way matching the Nix manual.
https://nixos.org/manual/nix/stable/introduction.html#managing-build-environments says:

For example, the following command gets all dependencies of the Pan newsreader, as described by its Nix expression:

`$ nix-shell '<nixpkgs>' -A pan`
<various output followed by >
unpacking source archive /nix/store/17md5j18x30jnbqxx7x2kwk2hzayhha7-pan-0.146.tar.bz2
<more output>

If you then replace pan by firefox:
`$ nix-shell '<nixpkgs>' -A firefox`, we have:

[nix-shell:~]$ unpackPhase
variable $src or $srcs should point to the source
exit

Expected behavior
Running unpackPhase should unpack firefox source code (and running the other phases would eventually result in a working build of firefox). In fact, if you wanted to write a test for this functionality, it could do this for every package in all-packages.nix, because the expectation of the nix-shell functionality within the context of nixpkgs is exactly that one can easily get a development environment going for a given package and for example not have to hunt for the sources yourself such that unpackPhase will get you a build directory with the source code.
Additional information
This bug belongs in nixpkgs (and not in nix), because apparently it does work for pan.
Notify maintainers
@eelco @lovesegfault @hexa
Metadata
21.11 stable

Try using firefox-unwrapped?

That works (didn't wait for the whole thing to complete, but at least it started to download llvm, etc.), but I think it's still a  undesirable.
I doubt there is an actually good reason for breaking this property.
How is a user supposed to know whether they should use the unwrapped version? In the case of pan, there is no unwrapped version.
Here is someone else with the same question, so it does generate confusion:
https://discourse.nixos.org/t/how-to-tell-the-difference-between-wrapped-and-unwrapped-package/6823

Given a Nix expression that describes the dependencies of your package

I suppose the author here is talking about a derivation, but doesn't want to use technical language on purpose.
I suppose this is the root cause of my misunderstanding here. In the case of pan, it probably is just an expression describing a derivation, but in the case of firefox it is not. Having some tool, which would find the "Nix expression that describes the dependencies" of a given query would then be useful, which probably also already exists.
As a user, I would like to just be able to run nix develop -A firefox # or something similar and have it figure out something useful it can do to get a shell in which unpackPhase unpacks firefox, etc.

firefox is the unwrapped firefox wrapped with wrapFirefox
Many other packages reuse the same wrapper
  firefox-unwrapped = firefoxPackages.firefox;
  firefox-esr-91-unwrapped = firefoxPackages.firefox-esr-91;
  firefox = wrapFirefox firefox-unwrapped { };
  firefox-wayland = wrapFirefox firefox-unwrapped { forceWayland = true; };
  firefox-esr-91 = wrapFirefox firefox-esr-91-unwrapped { };

  firefox-esr = firefox-esr-91;
  firefox-esr-unwrapped = firefoxPackages.firefox-esr-91;
  firefox-esr-wayland = wrapFirefox firefox-esr-91-unwrapped { forceWayland = true; };

  firefox-bin-unwrapped = callPackage ../applications/networking/browsers/firefox-bin {
    inherit (gnome) adwaita-icon-theme;
    channel = "release";
    generated = import ../applications/networking/browsers/firefox-bin/release_sources.nix;
  };

  firefox-bin = wrapFirefox firefox-bin-unwrapped {
    pname = "firefox-bin";
  };

  firefox-beta-bin-unwrapped = firefox-bin-unwrapped.override {
    inherit (gnome) adwaita-icon-theme;
    channel = "beta";
    generated = import ../applications/networking/browsers/firefox-bin/beta_sources.nix;
  };

  firefox-beta-bin = res.wrapFirefox firefox-beta-bin-unwrapped {
    pname = "firefox-beta-bin";
    desktopName = "Firefox Beta";
  };

  firefox-devedition-bin-unwrapped = callPackage ../applications/networking/browsers/firefox-bin {
    inherit (gnome) adwaita-icon-theme;
    channel = "devedition";
    generated = import ../applications/networking/browsers/firefox-bin/devedition_sources.nix;
  };

  firefox-devedition-bin = res.wrapFirefox firefox-devedition-bin-unwrapped {
    nameSuffix = "-devedition";
    pname = "firefox-devedition-bin";
    desktopName = "Firefox DevEdition";
  };

  librewolf-unwrapped = firefoxPackages.librewolf;

  librewolf = wrapFirefox librewolf-unwrapped {
    inherit (librewolf-unwrapped) extraPrefsFiles extraPoliciesFiles;
    libName = "librewolf";
  };

There are more wrapThing wrappers in nixpkgs as they allow us to reuse code.
Theres probably no way to transparently open the nix shell in the unwrapped drv when the wrapped drv is passed
To find the unwrapped drv for a wrapped firefox
firefox.unwrapped can be used
https://github.com/NixOS/nixpkgs/blob/0a6fa5ec69dbe8eff77cf3dc6311f3de065be724/pkgs/applications/networking/browsers/firefox/wrapper.nix#L347

Also it allows us to change wrapper settings without recompiling the browser

As Artturin said, wrappers are very common in nixpkgs. I'm closing this as solved :)

As a sidenote, if there's wrappers in nixpkgs which don't have the unwrapped drv in it's passthru then that should be added.


[gdl] New port

The GNOME docking library (https://gitlab.gnome.org/GNOME)

Withdrawing this request: I will first attempt to get changes merged upstream.


exp/clients/horizon: fix horizon url

Handle cases when HorizonURL is inputted with/without slash /

closed in #1042


Fix initial size of some inline PODArray's.

A non-significant change.
A template parameter of PODArray named INITIAL_SIZE didn't make its
units clear, which made some callers to erroneously assume that it
specifies the number of elements and not the number of bytes.
Rename it, fix the wrong usages and, where possible, use the
PODArrayWithStackMemory typedef for arrays with inline memory.

The performance test failure seems to be not related to the changes. I restarted the tests: https://nda.ya.ru/3UxsBF


SCI & criteria support

The search now respects SCI.
From the included spec:
class MyDoc
  include Mongoid::Document
  include Mongoid::FullTextSearch

  field :title
  fulltext_search_in :title
end

class MyInheritedDoc < MyDoc
end

MyDoc.fulltext_search(…) # => will return both MyDoc as well as MyInheritedDoc documents
MyInheritedDoc.fulltext_search(…) # => will return only MyInheritedDoc documents

It is also possible to pre-empt the search with Monogid criteria:
MyDoc.where(value: 10).fulltext_search(…)

Please note that this will obviously not work in case an index is shared by multiple classes (that are not connected through inheritance), since a criteria applies only to one class.

builds upon #35 , will rebased once that one is merged

For rubocop take the habit of just doing rubocop -a ; rubocop --auto-gen-config

Needs a rebase

@dblock will do. I think we need to also allow longer modules so we pass RuboCop – until we refactor …

I generally now disable all Metrics in .rubocop.yml

ok, i am not familiar with rubocop, do you have a toggle i could pull?

Do this:

Upgrade rubocop to 0.55.0
Run rubocop -a ; rubocop --auto-gen-config
Commit and PR separately.

Great, thanks. PS do you use this in production?

We used to. Haven't used it in production for a while, switched to ElasticSearch. But it works well for small self-contained problems.

@dblock here we keep failing miserably on Mongoid 3 (but not 3.1). No idea why, again …

I can reproduce this locally and it looks like a clear bug.
With Mongoid 3.
Both ExternalArtist and ExternalArtwork are using the same index, mongoid_fulltext.artworks_and_artists.
I am supposed to get back 2 objects, an external artist and artwork via ExternalArtwork.fulltext_search. The correct result is:
[#<ExternalArtist _id: 5af21a8f9b0b58e214000001, _type: nil, full_name: "Pablo Picasso">,
 #<ExternalArtwork _id: 5af21a8f9b0b58e214000002, _type: nil, title: "Portrait of Picasso">]

In Mongoid 3 the query is {"ngram"=>"picasso", "class"=>{"$in"=>["ExternalArtwork"]}} which is incorrect.
The code in document_type_filters does return {} unless fields['_type'].present?, in Mongoid 3 fields['_type'] returns #<Mongoid::Fields::Standard:...>", and in Mongoid > 3.1 that's nil. I am not sure what that means ;)

I tried fields['_type'].default_val.call instead, and that passed all tests, which tells me you're missing a test here for a descendant type, that is never not nil in the entire test suite.

This is simpler and works for all versions:
return {} if descendants.none?

@tomasc Got a moment to wrap this up?


Inventory notification

Your tool/software has been inventoried on Rawsec's CyberSecurity Inventory:

https://inventory.rawsec.ml/tools.html#Jaeles

What is Rawsec's CyberSecurity Inventory?
An inventory of tools and resources about CyberSecurity. This inventory aims to help people to find everything related to CyberSecurity.

More details about features here.
Note: the inventory is a FLOSS (Free, Libre and Open-Source Software) project.
Why should you care about being inventoried?
Mainly because this is giving visibility to your tool and improve its referencing.
Badges
The badge shows to your community that your are inventoried. It looks good but also shows you care about your project, that your tool is referenced.
Feel free to claim your badge here: http://inventory.rawsec.ml/features.html#badges, it looks like that , but there are several styles available.
Want to thank us?
If you want to thank us, you can help make our open project better known by tweeting about it! For example:
So what?
That's all, this message is just to notify you if you care. Else you can close this issue.

Thank you for your kind words.


CF Service Broker API use cases

WIP: spell out details of working with the Service Broker API

@duglin @slack PTAL

Yeah - same grey area for me.
On Thursday, October 6, 2016, Jason Hansen<EMAIL_ADDRESS>wrote:

@slack commented on this pull request.
In docs/v1/use-cases.md
https://github.com/kubernetes-incubator/service-catalog/pull/12:

+One of the attributes of a Service is a set of plans that differentiate the
+tiers of that service.  Services and plans both have an id attribute that
+is to uniquely identify instances of those resources in the catalog.
+
+#### Updating a service broker
+
+Broker authors make changes to the services their brokers offer.  To refresh the
+services a broker offers, the catalog should re-list the /v2/catalog endpoint.
+The catalog should apply the result of re-listing the broker to its internal
+representation of that broker's services:
+
+1.  New service present in the re-list results are added
+2.  Existing services are updated if a diff is present
+3.  Existing services missing from the re-list are deleted
+
The CF Cloud Controller docs are explicit that delete/purge will orphan
service instances.
Update is pretty vague on this point and I don't have any personal CF
operational experience.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/12, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAWXmFlKt0C3h7T-OSmpx3ItCnwLTup1ks5qxW8MgaJpZM4KOa5Y
.

@duglin @slack any remaining nits (that won't be addressed in a follow-up) on this?

LGTM

@MHBauer PTAL, happy now?

@pmorie lgtm assuming everyone else is fine with their nits.

@krancour PTAL

still LGTM

I'm late to the party, but this does LGTM. 👍


Feature #237 set FloatingMenu background color programmatically

Create function in FloatingMenu to support background color of menu button

hi, is there any problem with this pull request ?

It would be really great to have such a feature

Please, tell me if something's wrong with my PR ?
thanks

It would be really great! I really need it.

I need it


build: Update Vulkan-Headers and -Tools to 1.3.235

CI Vulkan-ExtensionLayer build queued with queue ID 40051.

CI Vulkan-ExtensionLayer build # 227 running.

CI Vulkan-ExtensionLayer build # 227 failed.

Yep it needs script changes from the VVL VK_EXT_descriptor_buffer PR.

CI Vulkan-ExtensionLayer build queued with queue ID 40117.

CI Vulkan-ExtensionLayer build # 228 passed.


Support for #[serde(crate = "path")]

I'm using rocket that exposes serde via the path rocket::serde.
To implement (de)serialize I'm using the attribute #[serde(crate = "rocket::serde")] to specifiy the path to serde.

I would prefer not to build this workaround into this crate.
Eventually https://github.com/rust-lang/rust/issues/54363#issuecomment-1237544924 will give a more robust way to make re-exported derive macros work without needing this kind of workaround.
In the meantime, it would be fine for someone else to maintain a more fully featured repr serde derive library that can handle this use case with an attribute.


Introduce new Api version 2019-08-01

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[X] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[x] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[X] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

@tjprescott Can you help figure out why SDK javascript and SDK python failed? SDK Java is still in progress, so not sure if it will fail too.

@tjprescott Nevermind. I believe I figured out all the issues. Please review.


What does "grouping triples" mean?

The README says:

Resource Object Fragmentation Strategy
A fragmentation strategy that groups triples by (subject) resources, and places quads into the document identified by the given predicate value.

I don't understand what "groups triples" means in this sentence. It seems to mean something different than "placed in separate files", but it also does not seem to mean "grouped in the output" (if the subject with a given subject are separated in the input, they are still separated in the output).
So this sentence should probably be rephrased to be more explicit about what exactly this strategy does.

For all triples that match the given predicate, files will be created for all matching object values.
But it will go one step further, and also include all triples into that file that share the same subject of that matched triple.

Ah... got it!
May I suggest then to rephrase to:

A fragmentation strategy that groups triples/quads by (subject) resources, and places each group into the document identified by the given predicate value for this group.