Update any lingering non-functional color usage

Primer::Classify

[x] bg
[x] color
[x] border
[x] box-shadow

We should remap the current uses to the correct functional classes like bg: :green to color-bg-success-inverse
https://primer-css-git-mkt-color-modes-docs-primer.vercel.app/css/support/v16-migration#text

Everything has been merged!


Split adds 'false' in the middle of the array

Phony.split('4234760987')
=> ["423", false, "476", "09", "87"].
I don't think there should be a false in there, should there?
According to Wikipedia, this a normalised Lichtenstein phone number, (dialed internationally as +423 xxx xx xx)
Thanks
André

Hi André,
In the current version of Phony, this is expected. You want to know if a country has an NDC or not – Liechtenstein does not.
See also e.g. Denmark, https://github.com/floere/phony/blob/master/spec/lib/phony/countries_spec.rb#L180-L182.
Cheers,
Florian

Thanks to you I've added a note to the README (see referencing commit above). Cheers!


Add compatibility to CAF benchmark suite

Existing scripts which uses savina are not effected by this pull request.
CLI Arguments are now handled by the class CliArgumentParser, which generalises and simplifies parsing of arguments.
And a new CLI arg for the benchmark runner is added (--no_evaluation) which deactivates performance calculations and output.

I'm going to fix the conflicts tomorrow.
Besides, for some reason I had problems with lambda functions you proposed in the file CliArgumentParser.java
So, I used the old school class based version to imitate lambdas.
Not that beautiful but it works.


Distribution module is not setup correctly for the community pool proposal

Bug description

I was trying to test all proposal types and came across the following for community pool proposal

Steps to reproduce

Run in cli
desmos tx gov submit-proposal community-pool-spend ~/proposals/pool.json --from your-key --chain-id morpheus-apollo-1 --gas auto --gas-adjustment 1.3 --gas-prices 0.0001udaric

pool.json
{
  "title": "Community Pool Spend",
  "description": "Pay me some Atoms!",
  "recipient": "desmos124xa66ghhq5hrgv28slhmszgvcqa0skcfwphh3",
  "amount": "100000000udaric",
  "deposit": "1000udaric"
}

Expected behavior

To work.

Missing the community pool spend proposal handler in x/gov. https://github.com/cosmos/gaia/blob/830c0ca8d23b6447e276771c1ecf556880dc1d51/app/app.go#L278


Typo "Azure File Storage"→"Azure Files Storage"

https://learn.microsoft.com/en-us/azure/search/search-file-storage-integration
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/search/search-file-storage-integration.md
#PingMSFTDocs

Docs Build status updates of commit 0cba22f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/search/search-file-storage-integration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@mattmsft
Can you review the proposed changes? I suggested also removing "Storage" per the Azure Files entry in the Microsoft Cloud + AI Style Guide.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 - Thanks!

Docs Build status updates of commit a0dbd22:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/search/search-file-storage-integration.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add args for verify and side_effect actions

This feature allows to provide alternative location for
tests or side effects playbook in test sequence like this:
  test_sequence:
    - create
    - converge
    - verify
    - side_effect side_effect1.yml
    - verify tests_for_effect1/
    - side_effect side_effect2.yml
    - verify tests_for_effect2/

This allows to create more comprehensive tests for
resulting system, allowing, in particular, to check
if it's works as intended, f.e.:

after server reboot
after applying system changes and reverting them back
after introducing external stress

Classic approach with one-side-effect per scenario can create
high overhead for both converge operations (if they are long),
and maintenance (because each scenario directory need to be
kept up-to-date).
This patch keep original behavior intact. If no arguments
are provided to verify and side_effect actions, they uses
values from molecule.yml. If there is action argument, they

replace side effect playbook with list of playbooks after
side_effect action (in molecule.yml), relative to molecule.yml file.
replace tests (and additional_files_or_dirs) with list of
locations (relative to molecule.yml), while keeping
all other test settings intact. This is supported for both
verifiers (testinfra and ansible).

I have no permissions to set tags on PR. It's ready for review, tests are green.

wow, I really like this!

This is not in the docs, right?

@nkakouros unfortunately, it would not be the first time updating the doc is forgotten. If you have time, a PR with a doc update would be nice or at least, please open a bug report to make sure that it's not forgotten / lost ?


Dropdown accessibility broken when highlightFirstItemOnOpen prop is set

Bug Report
Focus gets stuck inside the input field of the <Dropdown> component when highlightFirstItemOnOpen prop is set.
Steps
See this codepen for repro.

Press tab to navigate to buttons
ENTER to open the popup
When highlightFirstItemOnOpen is set pressing TAB does not switch to the button in the popup

Expected Result

Pressing TAB when focus is in the input field should switch focus to other elements in the popup.

Version
0.25.1

fixed


Remote tests failing

Description
While working on #428 I'm running into an issue where two tests of the harvesting suite are failing. The tests and a diff of expected vs result are:

Harvest-zzz-post-GetRecords-filter-wfs-iso

--- Harvest-zzz-post-GetRecords-filter-wfs-iso/expected.xml	2016-11-16 16:49:08.005763367 +0000
+++ Harvest-zzz-post-GetRecords-filter-wfs-iso/response.xml	2016-11-16 16:51:15.607320617 +0000
@@ -703,26 +703,6 @@
           <srv:containsOperations>
             <srv:SV_OperationMetadata>
               <srv:operationName>
-                <gco:CharacterString>DefaultMaxFeatures</gco:CharacterString>
-              </srv:operationName>
-              <srv:DCP>
-                <srv:DCPList codeList="http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#DCPList" codeListValue="HTTPGet">HTTPGet</srv:DCPList>
-              </srv:DCP>
-              <srv:DCP>
-                <srv:DCPList codeList="http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#DCPList" codeListValue="HTTPPost">HTTPPost</srv:DCPList>
-              </srv:DCP>
-              <srv:connectPoint>
-                <gmd:CI_OnlineResource>
-                  <gmd:linkage>
-                    <gmd:URL>http://maps.cera.govt.nz/arcgis/services/CERA/CERA_TechClasses_WGS84/MapServer/WFSServer</gmd:URL>
-                  </gmd:linkage>
-                </gmd:CI_OnlineResource>
-              </srv:connectPoint>
-            </srv:SV_OperationMetadata>
-          </srv:containsOperations>
-          <srv:containsOperations>
-            <srv:SV_OperationMetadata>
-              <srv:operationName>
                 <gco:CharacterString>ImplementsSimpleWFS</gco:CharacterString>
               </srv:operationName>
               <srv:DCP>

Harvest-zzz-post-GetRecords-filter-wms-iso

--- expected.xml	2016-11-16 17:05:23.287145828 +0000
+++ response.xml	2016-11-16 17:06:47.897533902 +0000
@@ -1103,7 +1103,7 @@
               </gmd:address>
               <gmd:onlineResource>
                 <gmd:linkage>
-                  <gmd:URL>http://mesonet.agron.iastate.edu/cgi-bin/wms/nexrad/n0r-t.cgi?</gmd:URL>
+                  <gmd:URL>https://mesonet.agron.iastate.edu/cgi-bin/wms/nexrad/n0r-t.cgi?</gmd:URL>
                 </gmd:linkage>
               </gmd:onlineResource>
             </gmd:CI_Contact>

It seems like the remote servers have made some changes to the records being harvested. If so, perhaps we should update the expected files to reflect this. I am not sure of this assumption though.
Environment

operating system:
Python version:
pycsw version:
source/distribution
[x] git clone
[ ] DebianGIS/UbuntuGIS
[ ] PyPI
[ ] zip/tar.gz
[ ] other (please specify):
web server
[x] Apache/mod_wsgi
[ ] CGI
[ ] other (please specify):

Steps to Reproduce

Clone the latest pycsw master and install dev dependencies.
Run the remote tests with

paver test -r

There should be two failing tests
Additional Information
I am attaching the full results and responses here:
failing_harvesting_tests.zip

@ricardogsilva agree.  This usually happens from time to time given the nature of testing remotes.  Feel free to update (in master) the expected result.

OK, I'll do that then.


Missing file/directory upon initial installation of Amplify cLi

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
Unable to complete - npm install -g @aws-amplify/cli
If applicable, what version of Node.js are you using?
15.7.0
Amplify CLI Version
...
What operating system are you using?
Mac Big Sur 11.2
Amplify Categories
Not applicable
Amplify Commands
Not applicable
Describe the bug
Upon installation with command npm install -g @aws-amplify/cli I get the following errors:
`npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path /Users/adamnowland/.nvm/versions/node/v15.7.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-cdk/bin/cdk
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/Users/adamnowland/.nvm/versions/node/v15.7.0/lib/node_modules/@aws-amplify/cli/node_modules/aws-cdk/bin/cdk'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      /Users/adamnowland/.npm/_logs/2021-06-03T22_03_10_118Z-debug.log`
Expected behavior
Complete installation
Reproduction steps

utilizing npm install -g @aws-amplify/cli`
utilizing sudo npm install -g @aws-amplify/cli`

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

@acnowland Does the installation fail use a different version of Node in NVM? Also could you try updating NPM to latest version and see if the issue still persists?


Log Export UI and Integration

A manage page for user to export the log should be implemented. Task status should be updated in time.

Closed by #81


Add contribute.json file.

Add a contribute.json file à la http://contribute.paas.allizom.org/.

@willkg r?

We've already got one:
https://github.com/mozilla/fjord/blob/master/fjord/base/templates/contribute.json

Hmm. So http://contribute.paas.allizom.org/ suggests putting it at the root of the repo (since not all projects are websites). Would a symlink in place of that template and moving that file to the repo root be an acceptable compromise?

I'm loathe to do symlinks. You mentioned doing a lib at one point, I'd be game for that. Or fixing the view to look at a different file.

@Osmose Do you want to keep working on this or should we close it out?

Updated to move the contribute.json file to the root of the repo.

Looks good to me! r+


Save Previous Panel URL for after Login

This is WIP but was originally intended for sending the user back to the panel of the login page they used.

This has expanded to include Social SPA authentication as well.
More documentation to follow.


[SPARK-41705][CONNECT] Move generate_protos.sh to dev/

What changes were proposed in this pull request?
This PR moves generate_protos.sh from connector/connect/dev to dev directory.
Why are the changes needed?
connector/connect/dev only contains one script. Moving generate_protos.sh to dev follows practice for other scripts.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test suite.

cc @HyukjinKwon

KubernetesSuite.scala failure may not be related to the PR.
pushd /__w/connector/connect/common/src/main
/__w/spark/spark/dev/generate_protos.sh: line 39: pushd: /__w/connector/connect/common/src/main: No such file or directory

I tried to account for SPARK_HOME:
pushd ${SPARK_HOME}/connector/connect/common/src/main

Though the above doesn't seem to work.

I don't think it's worth moving it atm. It has a clear relationship to the contained code in the connect package.

Actually maybe now it's time to consider moving these (including README.md) together since we're going to package them together (https://github.com/apache/spark/pull/38477). The reason is that all dev related scripts are located there e.g., dev/reformat-python, etc.

Let's also fix dev/check-codegen-python.py script together to fix up the linter.

Should also better file a JIRA.

the code gen checker failed:
Traceback (most recent call last):
  File "./dev/check-codegen-python.py", line 84, in <module>
    check_connect_protos()
  File "./dev/check-codegen-python.py", line 49, in check_connect_protos
    run_cmd(f"{SPARK_HOME}/dev/generate_protos.sh {tmp}")
  File "./dev/check-codegen-python.py", line 43, in run_cmd
    return subprocess.check_output(cmd.split(" ")).decode("utf-8")
  File "/usr/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/__w/spark/spark/dev/generate_protos.sh', '/tmp/tmpdk4qg3nj']' returned non-zero exit status 1.

will take this over with moving related README.md together.

https://github.com/apache/spark/pull/39338. I will add you as a co-author there.


Add lib es2020.sharedmemory

Fixes #39491

Cool, checked the spec and this looks right to me

Thanks!


[FIX] handle datasets with fMRIPrep data in subfolders

fixes #168
fixes #172
fixes #171

Codecov Report
Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3f4e5d1) 67.74% compared to head (d2bdd3a) 67.73%.

Files
Patch %
Lines

cohort_creator/main.py
63.15%
14 Missing :warning:

cohort_creator/_cli.py
0.00%
9 Missing :warning:

cohort_creator/data/_update.py
0.00%
3 Missing :warning:

cohort_creator/_utils.py
95.23%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   67.74%   67.73%   -0.01%
==========================================
  Files          10       10
  Lines        1426     1463      +37
==========================================
+ Hits          966      991      +25
- Misses        460      472      +12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@all-contributors please add @Remi-Gau for test, maintenance, doc, bug, code


How can I not display the "none fields?"

I have data that I bring from a query, the null fields are shown as "none". How can I visualize them empty?

Thanks

Are you sure you're not doing this somewhere in your code? If a field is changed to null in a codesandbox I don't see this:
https://codesandbox.io/s/wy2rl1nyzl
However, setting this aside, one solution would be to use the customBodyRender method. That allows you to control exactly what is displayed in a table cell.

customBodyRender it was the solution, thanks


MAINT: Remove blobs from history

I got the gh-pages branch covered, it's not back to 1 commit, and I removed the large files from the last commit of the main branch. I'm not very confident in editing the git history (I'm rarely using git CLI..), could you have a look at simplifying the history? There are 2 points which could help to clean-up this repo:

[ ] Remove large files from the history
[ ] Squash together all commits prior to the tags 0.6.x (which basically correspond to the 2 projects on which this one is based). Ideally, while preserving the authorship for dnastars (Arnaud) and dbdq (Kyuhwa), maybe on the first commit?

could you have a look at simplifying the history? There are 2 points which could help to clean-up this repo:

Yes but to be safe the way I'd approach the problem is to create a new branch clean-main with a different/blob-less history. Then you can examine the blame on GitHub easily, do a diff between it and main (and see there are no changes), etc. I started working on this and saw the following when I looked for large files in history:
git fetch uptsream
$ git checkout main
$ git clean -xdf
$ git reset --hard upstream/main
$ git checkout -b clean-main
$ git rev-list --objects --all |
  git cat-file --batch-check='%(objecttype) %(objectname) %(objectsize) %(rest)' |
  sed -n 's/^blob //p' |
  sort --numeric-sort --key=2 |
  cut -c 1-12,41- |
  $(command -v gnumfmt || echo numfmt) --field=2 --to=iec-i --suffix=B --padding=7 --round=nearest
...
d1b37407f3ed   15MiB dev/.doctrees/environment.pickle
ed30123a0406   16MiB dev/_sources/generated/tutorials/20_stream_receiver_filtered_buffer.rst.txt
13ddbac8308b   16MiB dev/generated/tutorials/20_stream_receiver_filtered_buffer.html
2296feabf4e1   21MiB doc/_static/stream_viewer/stream_viewer.gif
1c03d1004ea5   30MiB dev/.doctrees/generated/tutorials/20_stream_receiver_filtered_buffer.doctree
8a5ab8fad80d   38MiB doc/_static/stream_viewer/stream_viewer.mov
af623416d969   40MiB datasets/sample/sample-ant-raw.fif
e3964ca961e4   40MiB datasets/sample/sample-ant-raw.fif
37c3da0c0853   45MiB dev/.doctrees/environment.pickle

Clearly we can get rid of the environment.pickles and the other stuff you mention above, but it would be good to set up some testing infrastructure to get rid of sample-ant-raw.fif as well.
Can we just use MNE-Python's mne-testing-data? It's overkill but sharing the infrastructure for determining version, downloading it, and caching it with GH actions means lower maintenance burden at the mne-lsl end because if stuff breaks the fix is almost always already in MNE-Python itself.

Thanks, and thanks for sharing the git commands you are using!
For the datasets, that's already done in #151. Using MNE-Python infrastructure was a bit too overkill. Instead, I used a very lightweight version with a 3-line function to generate a registry (checksum) for the files to download, and another 3-line function to download the files with pooch.

.. downloaded from https://github.com/mscheltienne/mne-lsl-datasets.

... also I'd recommend pushing main as-is before we overwrite it with something like git push origin main:main-bak or whatever you want to call it

I'd recommend pushing main as-is before we overwrite it with something like git push origin main:main-bak

So just making a backup main branch? Done, main-backup.

Following https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository it looked like https://rtyley.github.io/bfg-repo-cleaner/ would make this trivial but it needed java so instead I just went the manual way by passing the following paths one by one (iterating with the above file-size command) to git filter-repo --invert-paths --force --path:

Files
dev/.doctrees
datasets
doc/_static/stream_viewer
doc/_static/stream_player
doc/_static/stream_recorder
dev/_static/stream_viewer
stable/_static/stream_viewer/stream_viewer.mov
dev/generated
dev/
stable/
Protocols/cv2.pyd
sample/
doc/_static/icon-with-name/
doc/_static/acronym/
examples/sample/mi_left_right-raw.fif
libLSL/
neurodecode/hci/glass/bgi-cnbi/.gradle/2.2.1/taskArtifacts/fileSnapshots.bin
mne_lsl/lsl/lib/
bsl/lsl/lib/
pycnbi/pylsl/liblsl64.dll
doc/_static/icon-with-acronym
neurodecode/glass/bgi-cnbi/
bsl/externals/pylsl/lib/
docs/sphinx/build/
docs/sphinx/_build/
bsl/triggers/lpt_libs
neurodecode/triggers/lpt/libs/
neurodecode/triggers/libs/
neurodecode/triggers/LptControl_Desktop32.dll
neurodecode/hci/glass/bgi-cnbi/.gradle
pycnbi/glass/bgi-cnbi
neurodecode/hci/glass/bgi-cnbi/.gradle
neurodecode/triggers/LptControl_Desktop64.dll
neurodecode/triggers/inpout32.dll
neurodecode/triggers/inpoutx32.dll
pycnbi/triggers/inpout32.dll
pycnbi/triggers/inpoutx64.dll
Triggers/inpout32.dll
Triggers/inpoutx64.dll
pycnbi/triggers/LptControl_Desktop32.dll
pycnbi/triggers/LptControl_Desktop64.dll
Triggers/LptControl_Desktop32.dll
Triggers/LptControl_Desktop64.dll
Glass/bgi-cnbi/build/intermediates/model_data.bin

With this the biggest files are now:
6a62a71fe603   56KiB bsl/externals/pylsl/pylsl.py
bb59ec379891   61KiB doc/_static/logging/flowchart-dark.png
c513a72db843   64KiB doc/_static/install/Advanced_system_settings.png
00ef7182b433  120KiB doc/CNBI Arduino Trigger.pdf
38963b805281  136KiB neurodecode/layout/biosemi_128ch.jpg
cad0e5c1a262  145KiB neurodecode/layout/biosemi_064ch.jpg
5e57d4f11eee  181KiB doc/_static/cli/stream_viewer_backend.png
a662e02c5080  188KiB doc/_static/cli/stream_recorder.png
a17d4ab0950a  303KiB doc/_static/cli/stream_player.png
f29b203a3865  594KiB doc/_static/icon/icon.pdf
0067886ece76  600KiB doc/_static/icon/icon.ai
10d18cc67040  694KiB doc/_static/icon/icon.png
450702b383d1  2.1MiB doc/_static/icon/icon.jpg
7e704112c604  4.8MiB doc/_static/icon/icon.eps
6e067c1c7566  6.3MiB doc/_static/icon/icon.psd

Can you look at the file list above and the branch here to see if it makes sense? If it does I can locally do git push upstream --force clean-main:main 🤞

https://github.com/larsoner/mne-lsl/tree/clean-main

That looks great, thank you!
And thanks for the detailed instructions since I'll be doing it again for the icons when I change them on main (and probably a couple of remaining old files in that list).

Okay, force-pushed clean-main:main

@larsoner Could you have a second look to confirm that it seems in order?
I'm struggling a bit.. I removed a couple more files after I changed the icons/logos.
git rev-list --objects --all |
  git cat-file --batch-check='%(objecttype) %(objectname) %(objectsize) %(rest)' |
  sed -n 's/^blob //p' |
  sort --numeric-sort --key=2 |
  cut -c 1-12,41- |
  $(command -v gnumfmt || echo numfmt) --field=2 --to=iec-i --suffix=B --padding=7 --round=nearest

The command above is giving me 2 different outputs when ran in 2 different terminals, in the same repository.. and I am not figuring out what is going on :disappointed:
Also, the main branch does clone faster; but it seems like the gh-pages branch still holds the blobs in its history and is still taking a long time to retrieve. IIRC, it was created as a new branch from main and not as an empty new branch.

I should be able to look tomorrow!

Thanks, no hurry :)

I only see one commit in https://github.com/mne-tools/mne-lsl/tree/gh-pages so I think that's good. I think that the rev-list stuff should ideally be run on a clean clone because it processes all branches at once, and I didn't do that the first time. I just redid it, can you check https://github.com/larsoner/mne-lsl/tree/clean-main and see if it's okay and I'll force-push it to mne-tools:main?

Thanks! But I'm still lost..
I re-forked the repository to get to a clean state, cloned it (which still required about 110 MiB), and ran again:
git rev-list --objects --all |
  git cat-file --batch-check='%(objecttype) %(objectname) %(objectsize) %(rest)' |
  sed -n 's/^blob //p' |
  sort --numeric-sort --key=2 |
  cut -c 1-12,41- |
  $(command -v gnumfmt || echo numfmt) --field=2 --to=iec-i --suffix=B --padding=7 --round=nearest

I'm still getting:
a103c0537dd8  4.0MiB doc/_static/stream_recorder/stream_recorder_cli.mov
4c2c92ee6e50  4.0MiB doc/_static/icon-with-name/icon-with-name.eps
a94028888490  4.2MiB doc/_static/stream_player/stream_player_cli.mov
47b68132f888  4.4MiB doc/_static/icon-with-acronym/icon-with-acronym.eps
80b3d1b29247  4.4MiB doc/_static/icon-with-acronym/icon-with-acronym.psd
7e704112c604  4.8MiB doc/_static/icon/bsl-icon.eps
13fd71d6a874  4.8MiB doc/_static/icon-with-name/icon-with-name.psd
364be804568a  5.1MiB libLSL/liblsl32-debug.dll
6e067c1c7566  6.3MiB doc/_static/icon/bsl-icon.psd
443f16464fe2  7.0MiB libLSL/liblsl64-debug.dll
10884859b78b  7.4MiB examples/sample/mi_left_right-raw.fif
a09427b159b4  7.4MiB sample/mi_left_right.fif
a68291046bc1  7.4MiB sample/mi_left_right.fif
2adf8579ef11  7.4MiB sample/mi_left_right-raw.fif
32bba913b292   11MiB dev/.doctrees/environment.pickle
c5bc58c3b2f5   13MiB Protocols/cv2.pyd
2296feabf4e1   21MiB doc/_static/stream_viewer/stream_viewer.gif
8a5ab8fad80d   38MiB doc/_static/stream_viewer/stream_viewer.mov

Any many other files above 1 MiB, despite your 2 passes and despite my own with git filter-repo and with bfg-repo-cleaner. Do you see the same on your side?

Looks good, diff is empty and tests are passing. And it did clone your fork way faster! 🤞
I'll remove that environment file!
Thanks for looking (agian) (again) into this!

Hah!
$ git remote remove origin  # was larsoner
$ git remote add origin git@github.com:/mne-tools/mne-lsl.git
$ git push origin --force --all
Everything up-to-date
$ git push origin --force --tags
Enumerating objects: 10500, done.
...
 + 194c9a2...3588455 0.6.4 -> 0.6.4 (forced update)

The "Everything up-to-date" when I force-pushed the branches suggests it was just the tags that needed to be updated, which is cool. Mystery solved!


RLM-54 Fix ES upgrade log in leapfrog

ES container has been removed from leapfrog's container destroy list,
and ES (re)deployment also would be avoided in leap ugprade as well.
Every ES ugprade operation is supposed to be performed after all leap
done. (Next to-do: automate ES upgrade operation into current leap)
Issue: RLM-54

recheck_cit_trusty_swift_deploy

@Frank-ZhangXin  Is --host also still needed from here?
https://rpc-openstack.atlassian.net/browse/RLM-54?focusedCommentId=170522&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-170522

@claco yes, the old error you linked is caused by missing '--host' arg.

Update:
We're about to move this upgrade along with all leapfrog update in to RPC upgrade soon.

@antonym @cloudnull fixed the miss-spell.

Close this PR since we move all these stuff into RPC-upgrades repo: https://github.com/rcbops/rpc-upgrades


[KYUUBI #5797][FOLLOWUP] Desc engine command support show engine registered attributes

:mag: Description
desc engine command support show engine registered attributes.
Issue References 🔗

This pull request fixes #5797
Describe Your Solution 🔧
https://github.com/apache/kyuubi/pull/5931#discussion_r1440679545
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

ENGINE_NAMESPACE is a duplicate of ENGINE_NAME, delete  ENGINE_NAMESPACE

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (db6576b) 61.20% compared to head (9fcc2c6) 61.25%.

Files
Patch %
Lines

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
66.66%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5948      +/-   ##
============================================
+ Coverage     61.20%   61.25%   +0.04%
  Complexity       23       23
============================================
  Files           622      622
  Lines         36882    36897      +15
  Branches       5014     5014
============================================
+ Hits          22573    22600      +27
+ Misses        11871    11865       -6
+ Partials       2438     2432       -6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@pan3793 @turboFei cc

thanks @Kwafoor
merged to 1.9


RasterSource does not end Tile transition

When using a TileSource like in the "Color Manipulation" example inside a RasterSource/ImageLayer the transition state of the loaded Tiles will never end (in contrast to directly using a TileLayer). This causes multiple effects:

rendering loop although nothing changes
wrong tile is rendered

To Reproduce
Steps to reproduce the behavior:

Go to 'https://openlayers.org/en/latest/examples/color-manipulation.html'
Zoom into the map (wait to load the tiles with a higher zoom level)
Zoom out of the map
You will see some tiles rendered with the wrong zoom level (one zoom level higher because of transition rendering mode) like in this screenshot:

Expected behavior
RasterSource should correctly end Tiles transition and FrameState animation mode.
My analysis
I debugged the code but unfortunately could not find a working solution.
The issue seems to be connected with impl. of RasterSource.updateFrameState_ where frameState.time = Infinity is used.
This will cause Tile.getAlpha never to return 1 in CanvasTileLayerRenderer.renderFrame leading to rendering childTileRange (wrong tiles over the already loaded correct tiles) and to never stop transition.
This will also lead to RasterSource.getImage to call requestAnimationFrame (after zooming/loading additional tiles) forever (consuming cpu resources).

I created a PR with a possible fix for the issue: https://github.com/openlayers/openlayers/pull/12597


Window System

Created window struct for window system
Holds position, scale, and elements for the window
Created windel struct
Holds position, scaling, color, a name, and element specific information
Created text, sprite, and button structs that hold information specific to each type of windel

Freeing Bug

Window frees successfully, but a phantom window is created in the process with a _inuse value of 221
The phantom causes a crash while the game is exiting
NEEDS TO BE FIXED


⚠ Turnos 24x7 has degraded performance

In 9abe451, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 4279 ms

Resolved: Turnos 24x7 performance has improved in da710da.


Missing exception in logs after addHeader, audit, or txn.rollback error

Describe the bug
Under certain circumstances, the server will return a 500 error and there will be no exception details in the server logs.
To Reproduce

Implement a fake AuditLogger and configure the FHIR Server to use it.
Have it throw an exception when you call the logX methods
Issue a request and note the 500 error response
Check the logs and note there is no stacktrace

Expected behavior
All 500 errors should result in an exception in the server logs.
Additional context
We always had this issue, but since we weren't doing much of anything in the finally block, we never hit it.  We recently moved audit logging to the finally block at the end of the interactions and this has widened
I suggest we move the log statement to the REST interaction methods (create, update, read, etc. instead of the doCreate, doUpdate, doRead variants).

While performing some related cleanup/refactoring, I noticed that I broke the test on accident, by following the spec instead of the current behavior.
from https://www.hl7.org/fhir/http.html#concurrency
If the version id given in the If-Match header does not match, the server returns a 412 Precondition Failed status code instead of updating the resource.
so i think it was a bug in our current impl and I'm HOPING fixing that doesn't break our touchstone results.


Update dotenv-support.md

I noticed that you must have .env in addition to a deployment target specific file so figured it might be worth mentioning since it tripped me up for a few minutes.

@skaterdav85 the .env file should not be required actually
maybe you're exposing a bug here or there's a problem with your setup
can you please share the error you're getting?

Turns out it was because I called an environment variable USER which uses the system's username, not the one I defined in the environment file.


tag for 1.0.1 ?

Hi - I'd like to use the latest version of tcell in my versioned go project, in particular including some of the commits that are beyond the v1.0.0 tag. Would you mind adding a v1.0.1 tag somewhere around HEAD? Then I can add
github.com/gdamore/tcell v1.0.1
to my go.mod file.
Thanks!
Graham

I just tagged 1.1.0.  (Its a minor release, as the database files are different.  We still support reading the old ones, but the new database cannot be used with the old code.)


Newsletter for recently added media

Is your feature request related to a problem? Please describe.
Some of my users want to be kept updated on what's new on the server. Instead of relying on a lot of separate notifications:
Describe the solution you'd like
I'd like to be able to send a periodic newsletter from Jellystat, like Tautulli does.
Describe alternatives you've considered
Writing something myself with Webhooks
Additional context
None

This feels more appropriate to be a function of either Jellyfin itself or Jellyseer.  I would wholly disagree that Tautilli, Jellystat or the like is the right place for this feature and I would recommend making this feature request on Jellyseer instead.  Also, I'm just some guy with an opinion, I am not affiliated with Jellystat at all.

@alvitali this is what you might be looking for https://github.com/Cloud9Developer/Jellyfin-Newsletter-Plugin


LDAP authentication

Hello,
I'm having problems logging into Kviklet using LDAP. I added all my LDAP information to the Docker-compose-yml file, but it still gives an error.
Checking the logs generated by Docker shows this error below:
2024-09-12T18:33:42.741Z DEBUG 8 --- [nio-8081-exec-4] o.s.s.l.a.BindAuthenticator : Failed to bind with any user DNs [ ]
Can you help me with what might be causing this error?
Thank you!

Hey Eduardo,
I am not an LDAP expert either sadly (heavily prefer OIDC based SSO) but I just checked and my setup it still works.
My config is the one from the readme:
LDAP_ENABLED=true
LDAP_URL=ldap://localhost:389
LDAP_BASE=dc=kviklet,dc=dev
LDAP_PRINCIPAL=cn=admin,dc=kviklet,dc=dev
LDAP_PASSWORD=admin
LDAP_UNIQUE_IDENTIFIER_ATTRIBUTE=uid
LDAP_EMAIL_ATTRIBUTE=mail
LDAP_FULL_NAME_ATTRIBUTE=cn
LDAP_USER_OU=people

And my LDIF export looks like this:
# Entry 1: cn=Jascha Beste,ou=people,dc=kviklet,dc=dev
dn: cn=Jascha Beste,ou=people,dc=kviklet,dc=dev
cn: Jascha Beste
gidnumber: 500
givenname: Jascha
homedirectory: /home/users/jbeste
mail<EMAIL_ADDRESS>objectclass: inetOrgPerson
objectclass: posixAccount
objectclass: top
sn: Beste
uid: jbeste
uidnumber: 1000
userpassword: {MD5}somehash

Could you give me this info so I can try to help you?

Just as additional info, the error message basically means that the LDAP connection couldn't find any entry for your userid. Which probably means you've either configured the LDAP_UNIQUE_IDENTIFIER_ATTRIBUTE wrong or the user youre trying to login with is not part of the organizational unit that you have configured.

Hello @Askir! Hope you are doing well.
Just for context, we use FreeIPA over here, and it does not have directly the same concept of OUs as OpenLDAP or Active Directory. Our issue is that on the function that performs the user search, you have configured it to expect specifically the string "ou=", followed by the env variable. This code is from SecurityConfig.kt.
        val userSearch = FilterBasedLdapUserSearch(
            "ou=${ldapProperties.userOu}",
            "(${ldapProperties.uniqueIdentifierAttribute}={0})",
            contextSource,
        )

        val authenticator = BindAuthenticator(contextSource).apply {
            setUserSearch(userSearch)
        }

And since our LDAP does not use it, the search was a dead end. I have built a custom docker image, only changing this first string from:
"ou=${ldapProperties.userOu}"
to
"cn=${ldapProperties.userOu}"
With this change, applying a valid cn and keeping the other variables as we were testing, it worked as expected!
I wanted to ask you if there's a chance you could change this piece of code so there's a possibility to edit which parameter to use, other than just "OU". Or if I just continue with my custom image for now, since maybe it's an isolated case.
In any way, we are thrilled to start using Kviklet. Let me know if you want some feedback later.

Hi Bruno,
Thank you very much for the detailed analysis. I wasn't aware that there are LDAP implementations out there without organizational units are a core construct.
I didn't quite go with your approach but I have added an environment variable LDAP_SEARCH_BASE that allows you to override the search base for all users altogether in #238. So in your case you can set this to e.g. cn=users, the userOu is then ignored. I hope this helps.
Again, thank you very much for raising this. Always happy about any further feedback you might have!


WIP: USHIFT-1120: migrate greenboot tests to RF

this test covering 3 use-cases:

adding user workload  and making sure greenboot runs it.
simulates service failure and making sure greenboot reports a failure.
simulates pod failure and making sure greenboot reports a failure.

it covers both regular and ostree based deployments.

It's not entirely clear how this test is different from some of the other greenboot test scenarios we have. Maybe @pmtk or @pacevedom can help explain that?

@dhellmann, other tests expect greenboot to be successful at all times. This test simulates service and pod failure to verify that greenboot script actually reports errors.

/approve

/lgtm


Case characters switcher

Description of the new feature / enhancement
A shortcut to switch case of characters on selected text (all uppercase | all lowercase | capital case)
Scenario when this would be used?
The user write a text in a textbox / textarea, select the text to upper/lower/capital and press a combo shortcut to activate the feature
Supporting information
No response

/dup #907


use custom emojis as svg or font family?

I was wondering if something like that is achievable, i would like to be able to change colors of the emojis and all of the font.

You can change the font by changing css

i would like to be able to change colors of the emojis

not sure what you mean.. plugin uses emojione images from cdn

well like flat emojis not colored ones, so an emoji of a single color  that i can change the colors with css. or make the emojis look something completely different you know... because designers 😛

You could get a Premium license from EmojiOne which lets you download their Emoji's in SVG format
From there you could use CSS to style the various SVG elements
But the idea of EmojiOne is to make Emojis consistent across all platforms. If you really need to do this, probably EmojiOne (and EmojiOneArea) is not the solution for you

@mike3run If you really need different emojis, you can build your own emoji library replacing all emojione  images, and setup emojione to load the images from your image library. Mind that you'll get stuck to a emojione version, or you'll need to create your image for every new emoji image added to emojione.

hey guys in this case I ended up using some custom made svg emojis but not with this library or any library i did a custom one for the ocassion, but I really appreciated reading some of the source code from here to learn how you guys dealt with the hell that his contenteditable haha


ENH: Add K-nearest neighbor classifier

closes #96. can be cleaned up a bit once we can use rulinalg 0.4.1(?).

I know this is still WIP but I thought I should chime in to say that I like the current approach!
We should probably have a discussion at some point about modifying the Model traits to better cater to clustering algorithms. KNN works well with a predict function but the others, like hierarchical clustering, don't have the natural notion of a prediction.
Oh and one more thing - I think you meant brute-force not brute-forth ?

Thx, correct the spelling.
Though it has a room for improvements after rulinalg 0.4.1 is released, it is once ready for review under current rulinalg.

@sinhrks Despite the delay, please know that your expertise is greatly valued. :sparkling_heart:
By the power vested in me as Acting Deputy Lieutenant-Maintainer (junior grade) of the rusty-machine crate, I do merge this pull request.


Item does not exist it may have been deleted by another user

Category

[ ] Question
[ ] Typo
[X] Bug
[ ] Additional article idea

Expected or Desired Behavior
Document to be uploaded successfully
Observed Behavior
The first time the document is uploaded fine, however after name change by code and trying to same document again we receive the following error (Check screen shot)
Steps to Reproduce
Upload a document, have its name changed and update some other properties. Upload the same document again. An error popup: Item does not exist

Submission Guidelines
Thanks for your contribution! Sharing is caring.

Can you provide some context? Are you doing this with the web UX or with an API (I see M.S.Client.Rest in the screenshot). If with code, please share the code that's failing.


Allow more than one positional argument in tgpu-cli/tgpu-gen.

npx tgpu-gen file1.wgsl file2.wgsl file3.wgsl (args)
# same as
npx tgpu-gen file1.wgsl (args)
npx tgpu-gen file2.wgsl (args)
npx tgpu-gen file3.wgsl (args)

Closing for now, it generates too many problems and adds too much complexity, as of now.

when there are multiple inputs should there be multiple outputs also and how
watch mode - what if one file is matched by more than one input pattern?


python312Packages.nocasedict: 2.0.3 -> 2.0.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.nocasedict is: Case-insensitive ordered dictionary for Python
meta.homepage for python312Packages.nocasedict is: https://github.com/pywbem/nocasedict
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.0.4 with grep in /nix/store/d4v9vq2yvpzbr48a1vil4v6a94q61y4b-python3.12-nocasedict-2.0.4
found 2.0.4 in filename of file in /nix/store/d4v9vq2yvpzbr48a1vil4v6a94q61y4b-python3.12-nocasedict-2.0.4

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath

check-esxi-hardware
python311Packages.nocasedict
python311Packages.pywbem
python312Packages.nocasedict
python312Packages.pywbem

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/d4v9vq2yvpzbr48a1vil4v6a94q61y4b-python3.12-nocasedict-2.0.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.nocasedict https://github.com/r-ryantm/nixpkgs/archive/2deca045328c80d807a97fd69db5cddd7642c735.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2deca045328c80d807a97fd69db5cddd7642c735#python312Packages.nocasedict

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/d4v9vq2yvpzbr48a1vil4v6a94q61y4b-python3.12-nocasedict-2.0.4
ls -la /nix/store/d4v9vq2yvpzbr48a1vil4v6a94q61y4b-python3.12-nocasedict-2.0.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

9 packages built:

check-esxi-hardware
python311Packages.nocasedict
python311Packages.nocasedict.dist
python311Packages.pywbem
python311Packages.pywbem.dist
python312Packages.nocasedict
python312Packages.nocasedict.dist
python312Packages.pywbem
python312Packages.pywbem.dist

Maintainer pings
cc @freezeboy for testing.

Add a :+1: reaction to pull requests you find important.

Done in #339276.


Notes tutorial: dotnet_bot PNG or SVG?

Minor, but confusing:
On the step 2 page of the Notes tutorial, the XAML breakdown says:

<Image> displays an image, in this case it's using the dotnet_bot.png image that comes with every .NET MAUI project.

The XAML also references the PNG filename, but the solution template only includes an SVG file.
I expected a crash, but it works... Is there some on-the-fly conversion that should be mentioned?

Also, should each step link to Github issues? I had to jump ahead to the Conclusion page, so I guess the details below may be incorrect (or maybe not, I haven't really looked at the doc structure).

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 720bf7f0-db92-f738-b864-ee149a02377b
Version Independent ID: 720bf7f0-db92-f738-b864-ee149a02377b
Content: Tutorial: Create a .NET MAUI app - .NET MAUI
Content Source: docs/tutorials/notes-app/index.yml
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @adegeo
Microsoft Alias: adegeo

Associated WorkItem - 147524

@adegeo changing the XAML to .svg does not work.
Thought it was interesting the csproj can reference svg, but I suppose that's a build thing as well:
<!-- App Icon -->
<MauiIcon Include="Resources\AppIcon\appicon.svg" ForegroundFile="Resources\AppIcon\appiconfg.svg" Color="#512BD4" />

<!-- Splash Screen -->
<MauiSplashScreen Include="Resources\Splash\splash.svg" Color="#512BD4" BaseSize="128,128" />

<!-- Images -->
<MauiImage Include="Resources\Images\*" />
<MauiImage Update="Resources\Images\dotnet_bot.svg" BaseSize="168,208" />

OK. So my assumption that it's transformed to .png during build is correct. Really just the reference to the project item needs to be fixed and perhaps a note added that says images are transformed to .png files, so the XAML uses .png.
Thanks for spotting this!

For what it's worth, I stumbled across a mention of this in Change a .NET MAUI app icon:

Important .NET MAUI converts SVG files to Portable Network Graphic (PNG) files. Therefore, when adding an SVG file to your .NET MAUI app project, it should be referenced from XAML or C# with a .png extension. The only reference to the SVG file should be in your project file.


Rename repo into dashboard_automation

Since decidim_metabase is too close from decidim-module_metabase, another repo of ours, we should rename it dashboard_automation (or maybe metabase_automation) since it's purpose is to automate the creation of models, and then the creation of questions and dashboards.

To me it's better metabase_automation because it is more precise

LGTM

Done ✅


fix(docs): fix README links to docs

The links in the README did not point to the corret location in the docs page

Thanks 🙏🏾👍🏾 for your contribution! ❤


Fix for https mixed content when requesting cached embed

Kind of urgent fix
@javisantana or @Kartones please review

Kartones reviewed it on my desk and says ok

looks ok

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Containing block

Issue #84: root must be containing block ancestor of target.
Issue #81: OK to create one observer per target.
Issue #52: percent rootMargins not allowed in the cross-origin case.

(for the record, lgtm'ed by slightlyoff)

Clarified in discussion that the effect of this is only to prevent generation/delivery of records in the case when  roots aren't containing blocks (although perhaps we should add a non-normative note suggesting that devtools warn in these cases). LGTM++


"Made Podfiles use symlinks to local pods" not working

Steps to Reproduce
set -x

mkdir -p Made_Podfiles_use_symlinks_to_local_pods_NOT_WORKING/
pushd  Made_Podfiles_use_symlinks_to_local_pods_NOT_WORKING/

flutter create -t plugin -i swift --org com.failed failed > /dev/null
pushd failed/example
flutter build ios --debug
popd

flutter create -t plugin -i swift --org com.success success > /dev/null
pushd success/example
wget -q https://raw.githubusercontent.com/mravn-google/flutter/3723ec0383f79420486bb4ee5acf06ebd190b5cf/packages/flutter_tools/templates/cocoapods/Podfile-swift
cp Podfile-swift ios/Podfile
flutter build ios --debug
popd

popd

Flutter Doctor
➜  ~ flutter doctor -v
[✓] Flutter (Channel master, v0.1.8-pre.43, on Mac OS X 10.13.3 17D102, locale en-KR)
• Flutter version 0.1.8-pre.43 at /Users/?????/flutter
• Framework revision fe334e1652 (3 hours ago), 2018-03-02 17:54:51 -0800
• Engine revision 97b22348c8
• Dart version 2.0.0-dev.32.0.flutter-ee15c8eb68
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
• Android SDK at /Users/?????/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-27, build-tools 27.0.3
• ANDROID_HOME = /Users/?????/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 9.2, Build version 9C40b
• ios-deploy 1.9.2
• CocoaPods version 1.3.1
[✓] Android Studio (version 3.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b08)
[✓] IntelliJ IDEA Community Edition (version 2017.3.4)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
• Flutter plugin version 22.1.2
• Dart plugin version 173.4548.30
[✓] VS Code
• VS Code at /Applications/Visual Studio Code.app/Contents
• Dart Code extension version 2.8.0
[✓] Connected devices (1 available)
• ????????????????????????????????????? • ios • iOS 11.2.6
• No issues found!

Can you describe the failure mode? Does flutter build ios throw an error?

Can you describe the failure mode? Does flutter build ios throw an error?

When using some plugins like barcode_scan it can't find the plugin header:
/volumes/data/code/example_app/ios/Runner/GeneratedPluginRegistrant.m:6:9: fatal error:
'barcode_scan/BarcodeScanPlugin.h' file not found
#import <barcode_scan/BarcodeScanPlugin.h>

Using the 3723ec03 version of Podspec file fixes the problem.

I can reproduce. This seems to be a problem with Swift projects. I cannot reproduce without the -i swift option.

There is a workaround described here

See #15031 for a more lengthy post about this. In particular the part about the pull request I made to cocoapods to fix their issue and the relevant issue. The issue should be reproducible for any project using use_frameworks!.

I too have experienced this issue and verified that it's only with Swift. I must state that we could not replicate issue with ObjC. I'm trying to write wrappers for existing frameworks in order for me to justify going full Flutter for all future development. I'm still committed, but not putting it forward until I can make plugins for existing Swift projects (think Couchbase-Lite, which is my first attempt). We don't want to touch ObjC.

To apply the fix in #15437 to a Swift-based Flutter project, add these lines to ios/Podfile.

@mravn-google 👍 #15437 WORKS!!!!


apply does not seem to read in plan file

The usage examples seem to suggest that the plan file is passed through via attaching a workspace between plan and apply jobs but I don't see how it works:
https://github.com/CircleCI-Public/terraform-orb/blob/0d0e0587128d868e0f10443b35d0381db358ae9c/src/scripts/apply.sh#L66
does not read in the plan file (plan.out)  from https://github.com/CircleCI-Public/terraform-orb/blob/0d0e0587128d868e0f10443b35d0381db358ae9c/src/scripts/plan.sh#L69

Hello @naseemkullah.
I have opened a PR #74 which should have a backwards compatible change. If you are able, I'd love your feedback. The orb can also be tested here:

You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:0cadaa0d00d2b4b54dd67f498057802e9c327329

Terraform Orb 3.1.0 is live: https://github.com/CircleCI-Public/terraform-orb/releases/tag/v3.1.0
Please try the latest version of the orb and let us know what you think!
Version 4.0.0 progress will begin soon with improved support for Terraform cloud and some new sensible defaults.


Swiper doesn't work in IE11 since release 5.3.0

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.3.1

Platform/Target and Browser Versions: Windows

Swiper doesn't work in IE11 since 5.3.0. The browser shows a problem with "startsWith" method (or property).
To resolve an error we can use next polyfill:
if (!String.prototype.startsWith) {
        String.prototype.startsWith = function (searchString, position) {
            position = position || 0;
            return this.indexOf(searchString, position) === position;
        };
    }

IE 11 is not supported by v5

Thanks! It helped me

@Gachegov59 @nolimits4web is the library still not supported in V5+?

Just for the record, we're compiling TypeScript with webpack and we have a loader.js with the following:
// Typescript loader
const ts = {
  test: /\.(tsx?|jsx?)$/,
  exclude: [
    /node_modules\/(?!(swiper|ssr-window|dom7)\/).*/,
    /.out/,
    /.storybook/,
  ],
  use: [
    {
      loader: 'babel-loader',
      options: {
        configFile: `${__dirname}/babel.config.json`,
      },
    },
  ],
};

This now transpiles the swiper, ssr-window and dom7 modules and swiper is now working in IE11, with the polyfills working too.
We're using the following versions:
    "swiper": "^5.4.2",
    "babel-loader": "^8.0.6",
    "webpack": "^4.42.1",

Note: it took me a while to notice that the 'test' line needed to include .js files as well as .ts files now that we are including certain node_modules, as the rest of our code is .ts files.
  test: /\.(tsx?|jsx?)$/,


Show the raw stderr when compile fails & it cannot be parsed as JSON

When the compile fails and the stderr cannot be parsed as JSON, the raw stderr is much more useful than a generic error message, for example:

This PR changes the error message to include the raw stderr output.

Thanks!


Add "sameAs" to JSON-LD context so that object is a URI not a literal

TL;DR
The @context for the JSON-LD output needs an entry for sameAs, e.g.
    "sameAs": {
      "@id": "sameAs",
      "@type": "@id"
    }

Longer version
My understanding is that sameAs statements should connect two URIs. For example:
<https://bionomia.net/0000-0003-3522-9342> <http://schema.org/sameAs> <https://orcid.org/0000-0003-3522-9342> .

says that the person with URL https://bionomia.net/0000-0003-3522-9342 is the same as the person with the ORCID https://orcid.org/0000-0003-3522-9342.
At the moment Bionomia JSON-LD statements such as "sameAs": "https://orcid.org/0000-0003-3522-9342" yield triples like:
<https://bionomia.net/0000-0003-3522-9342> <http://schema.org/sameAs> "https://orcid.org/0000-0003-3522-9342" .

Note that now ORCID id is a literal not a URI. This means anyone doing SPARQL queries will have to cast "https://orcid.org/0000-0003-3522-9342" to  <https://orcid.org/0000-0003-3522-9342> before they can link it to, for example, the RDF from ORCID.
The solution is to add sameAs to the @context (see above) so that when the JSON-LD is processed the object of the sameAs is treated as a URI. Alternatively you could use this uglier syntax each time you have a sameAs statement:
"sameAs" : { "@id" : "https://orcid.org/0000-0003-3522-9342" },

Putting it in the @context means you can still write nice simple URLs that are correctly interpreted.
This is one of several "gotchas" that have tripped me up over the last couple of years as I try to get my head around JSON-LD.
Hope this makes sense. For now, when I process Bionomia JSON-LD I add the sameAs fragment so that my triples treat the ORCID as a URI.

Fair point. If you don't want to mess with the @context (which I confess I often do, mostly when I need to enforce a constraint that something is always an array, etc.) then doing it on each statement might be the way to go. For example, the current schema.org schema https://schema.org/version/latest/schemaorg-current-http.jsonld has items like this:
    {
      "@id": "schema:Thursday",
      "@type": "schema:DayOfWeek",
      "rdfs:comment": "The day of the week between Wednesday and Friday.",
      "rdfs:label": "Thursday",
      "schema:sameAs": {
        "@id": "http://www.wikidata.org/entity/Q129"
      }
    },

This makes it explicit that http://www.wikidata.org/entity/Q129 is a URI. Slightly uglier, but less ambiguous. Of course, clients that don't care about RDF but just want JSON may go "huh?" when they see something like { "@id": "http://www.wikidata.org/entity/Q129" } but this is the challenge. The cleanest JSON syntax has implications for the corresponding RDF, which in turn has implications for triple stores.
So I guess the options are:

leave it as it is and I monkey patch things at my end
you patch the context at your end
you write sameAs statements with @id


Great Success requirement rework

refering to wikia (as of today) http://kancolle.wikia.com/wiki/Great_Success

The primary requirement for Great Success is that all ships in the expedition fleet should be sparkled (morale ≥ 50).
Great Success rate is increased by ~19% for every sparkled ship.

for dealing with this problem,

"RecommendSparkledCount" will be removed, instead we'll have a new requriement for non-overdrumming expeds for checking whether all ships have been sparkled.
introduce another "RecommendShipCount" requirement, so having ships all sparkled together with an extra check on ship count should do the trick, there shouldn't be many exped that need this requirement, as many of them require having all 6 ships to just be successful.

related discussion:
https://github.com/KC3Kai/KC3Kai/issues/1690
https://github.com/KC3Kai/KC3Kai/issues/1951

we can do a really quick fix for this:

define a new requirement "AllSparkled", apply it to all non-overdrum expeditions
allow recommended sparkled ships to take a range of 3~6, it was 4~6, but after a second thought 3 looks fine (there ate experiments confirming GS rate is around 69.71%, which sounds decent actually)

this should fix all the problems, but there are increased verbosity due to having more requirement to display on UI, which we'll be worrying about later.

maybe it's a bad idea to determine whether to add "AllSparkled" depending on runtime info. so #3 is opened as an alternative for solving verbosity problem. rework is now done.


SubscriberClientImpl.DisposeAsync throws exception

Environment details

OS: Mac
.NET version: .NET 8
Package name and version: 3.18.0

Steps to reproduce

Create DI container
Register a pubsub subscription
Throw an exception in a class which is instantiated via DI injection.

result:
Unhandled exception. System.InvalidOperationException: Can only stop a started instance.
at Google.Api.Gax.GaxPreconditions.CheckState(Boolean condition, String message)
at Google.Cloud.PubSub.V1.SubscriberClientImpl.StopAsync(CancellationToken hardStopToken)
at Google.Cloud.PubSub.V1.SubscriberClient.StopAsync(TimeSpan timeout)
at Google.Cloud.PubSub.V1.SubscriberClientImpl.DisposeAsync()
at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.DisposeAsync()
--- End of stack trace from previous location ---
at Microsoft.Extensions.Hosting.Internal.Host.g__DisposeAsync|21_0(Object o)
at Microsoft.Extensions.Hosting.Internal.Host.DisposeAsync()
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
at WebApplication.Program.Main(String[] args)
Expected result:
DisposeAsync does not throw an exception if it hasn't been started yet. The constructor exception will be caught in DI container and logged.

Thanks for reporting this. We'll look into it.

Thanks for the fix. Which release will this be in?

We've now released version 3.19.0 which contains this fix.


react build issue

hey guys,
we are using your library in 1 project,
however we faced an issue when trying to deploy to production,
in create-react-app project we are not able to build it,
it's saying it's app.js line 43, but I cannot figure out what's wrong there,
would be great if you can fix it,
thanks,
Greg

Hi @gregdymek! Happy to hear you're using our library. But the issue presented here is not actionable, please present exact steps to reproduce and me, @akebrissman, @vtepliuk or someone might maybe possibly have a look at it when we have time to spare.


chore: update shouldCloseOnOverlayClick doc

Changes proposed:

updated documentation of the shouldCloseOnOverlayClick prop

Upgrade Path (for changed or removed APIs):
Acceptance Checklist:

[x] The commit message follows the guidelines in CONTRIBUTING.md.
[ ] Documentation (README.md) and examples have been updated as needed.
[ ] If this is a code change, a spec testing the functionality has been added.
[ ] If the commit message has [changed] or [removed], there is an upgrade path above.

Thanks, @jamesbechet for the PR. 🎉


"unable to get disk metrics" when deployed to kubernetes

Describe what happened:
I have the same issue as #1730, with the container deployed to kubernetes. The "solution" to issue #1730 does not apply to a Kubernetes deployment. The issue appears to happen on a subset of my Kubernetes nodes.
[ AGENT ] 2018-07-09 00:39:31 UTC | WARN | (datadog_agent.go:135 in LogMessage) | (disk.py:105) | Unable to get disk metrics for /host/proc/sys/fs/binfmt_misc: [Errno 40] Too many levels of symbolic links: '/host/proc/sys/fs/binfmt_misc'
Describe what you expected:
No errors.
Steps to reproduce the issue:
Currently its happening on 2 out of 7 nodes. So direct reproduction steps are uncertain.
Additional environment details (Operating System, Cloud provider, etc):
Kops deployed Kubernetes on AWS. Running latest DataDog container deployed via a DaemonSet

I was also encountering the same issue with datadog/agent:latest (6.3.2)
Downgrading to datadog/agent:6.3.1 seems to have fixed it for me so there might be a bug somewhere in 6.3.2.
It possible that your other nodes are running a different version of the dd-agent?
Hope this helps!

I'm seeing this with 6.3.0 so I don't think it is version-related (unless it was fixed in 6.3.1 and then regressed in 6.3.2).

I had this issue with 6.3.0 and updated the image to 6.3.1 and the issue went away.
I then updated to 6.3.1 and the newest version of the chart, and the issue is still gone.  Either the redeployment fixed something, or there is a change in the chart that fixed it.

I'm having this issue as well with agent 6.3.2 on k8s 1.9.8 deployed on AWS via kops.  I have only three nodes in this cluster, and the host nodes are running the kope.io/k8s-1.9-debian-stretch-amd64-hvm-ebs-2018-03-11AMI.

Not sure if it matters, but this is not the standard AMI, but one which supports hvm, and rootVolumeOptimization.

Tuning the disk check solves this for me. In the conf.d/disk.d/conf.yaml file, make sure the autofs and binfmt_misc filesystems are blacklisted.
Linux OSes using systemd usually have an automount enabled for /proc/sys/fs/binfmt_misc. Blacklisting this prevents the agent from considering this endpoint.

For the record: To fix this in a Kubernetes deployment I followed this guide: https://docs.datadoghq.com/agent/kubernetes/integrations/#configmap
Leading to these changes in the DaemonSet:
        volumeMounts:
          - name: datadog-agent-config
            mountPath: /conf.d
[...]
      volumes:
        - name: datadog-agent-config
          configMap:
            name: datadog-agent
            items:
            - key: disk-config
              path: disk_check.yaml

Along with this new ConfigMap:
kind: ConfigMap
apiVersion: v1
metadata:
  name: datadog-agent
  namespace: monitoring
data:
  disk-config: |-
    init_config:

    instances:
      - use_mount: false
        excluded_filesystems:
          - autofs
          - binfmt_misc

This seems to get rid of the warnings...

Superseded by https://github.com/DataDog/integrations-core/issues/2492

This fix works, but it is a workaround.
The /proc/sys/fs/binfmt_misc should be excluded in datadog agent by default
Is there a version in which this is fixed by default?

I recently found this issue in our Agents as well. Using the container agent: 7.17.0 and still encountering the same issue. Will be putting in the workaround

Please comment here instead: https://github.com/DataDog/integrations-core/issues/2492

For anyone else who finds this issue and is looking to disable these locations from the disk check, the option names have been renamed in this PR.

for anyone using the helm chart seeing this issue, I use a values.yaml like this:
datadog:
  apiKey: ...
  appKey: ....
  confd:
    disk.yaml: |-
      init_config:

      instances:
        - use_mount: false
          excluded_filesystems:
            - autofs
            - /proc/sys/fs/binfmt_misc
            - /host/proc/sys/fs/binfmt_misc

Turns out it's called disk.yaml now (6.6.0 / 6.7.0)

This is the configuration I used in my Helm values file:
  confd:
    disk.yaml: |-
      init_config:

      instances:
        - use_mount: false
          file_system_exclude:
            - autofs$
          mount_point_exclude:
            - /proc/sys/fs/binfmt_misc
            - /host/proc/sys/fs/binfmt_misc

In my case, the problem was solved by monitoring only the device that is mounted to the root / :
  disk.yaml: |-
    init_config:

    instances:
        ## Instruct the check to collect using mount points instead of volumes.
      - use_mount: true

        ## Collect data from root mountpoint (regex)
        mount_point_include:
          - ^/$

I took the idea of here.

Ran into this as well on EKS. Deploying a new cluster with the datadog agent on the hosts in the EKS node group and the helmchart resulted in my logs from the host agent being spammed constantly with the following error:
# journalctl -fu proc-sys-fs-binfmt_misc.automount
Dec 09 18:36:59 ip-5-5-5-5.us-west-2.compute.internal systemd[1]: proc-sys-fs-binfmt_misc.automount: Got au
tomount request for /proc/sys/fs/binfmt_misc, triggered by 3349533 (agent)
Dec 09 18:36:59 ip-5-5-5-5.us-west-2.compute.internal systemd[1]: proc-sys-fs-binfmt_misc.automount: Automo
unt point already active?
Dec 09 18:36:59 ip-5-5-5-5.us-west-2.compute.internal systemd[1]: proc-sys-fs-binfmt_misc.automount: Got au
tomount request for /proc/sys/fs/binfmt_misc, triggered by 3349533 (agent)
Dec 09 18:36:59 ip-5-5-5-5.us-west-2.compute.internal systemd[1]: proc-sys-fs-binfmt_misc.automount: Automo
unt point already active?
...

Incorporating the following changes into my helmchart removed the automount requests on the hosts in the EKS node group: https://github.com/DataDog/datadog-agent/issues/1961#issuecomment-1054843247
There have been attempts to ignore this already in the agent: https://github.com/DataDog/integrations-core/pull/7650 but they dont seem to be working in this case.
Config

 helmchart config
helmchart pre fix:
datadog:
  apiKeyExistingSecret: datadog
  logs:
    enabled: true
    containerCollectAll: true
  apm:
    portEnabled: true
  clusterAgent:
    replicas: 2
    createPodDisruptionBudget: true

helmchart post fix:
datadog:
  apiKeyExistingSecret: datadog
  logs:
    enabled: true
    containerCollectAll: true
  apm:
    portEnabled: true
  clusterAgent:
    replicas: 2
    createPodDisruptionBudget: true
  confd:
    disk.yaml: |-
      init_config:

      instances:
        - use_mount: false
          file_system_exclude:
            - autofs$
          mount_point_exclude:
            - /proc/sys/fs/binfmt_misc
            - /host/proc/sys/fs/binfmt_misc

Version info

version details
kube version:
$  kubectl version
Client Version: v1.31.0
Kustomize Version: v5.4.2
Server Version: v1.31.2-eks-7f9249a

helmchart version:
helm repo: https://helm.datadoghq.com
chart: datadog/datadog
version: 3.77.2

datadog-agent version in pod:
# agent version
Agent 7.58.0 - Commit: cf39839 - Serialization version: v5.0.130 - Go version: go1.22.7

datadog-agent version on EKS host in node group:
# datadog-agent version
Agent 7.59.1 - Commit: 3638fcd32d - Serialization version: v5.0.132 - Go version: go1.22.8


Update Docsy Theme to 0.8.0

Related issue #1020

Proposed Changes

Upgrade docsy from v0.7.0 to v0.8.0
Use docsy dedicated custom scripts file.  We were overriding the scripts.html file directly, which exposed the website to breaking changes when upgrading.
Fixes #1020
Consolidate all params to params.toml file
Renames a js script that result in name conflicts after the 0.8.0 theme upgrade.

Checklist

[x] I have read the contributing guidelines.
[x] I have inspected the website preview for accuracy.
[x] I have signed off my issue.

@chipzoller,
I have resolved #1020, but need to cleanup one file. Everything else works well. Please test in the meantime.

Code blocks appear to be off now. See here.

@onweru, thanks again. Do you mind resolving the conflict created after we cut the 1.11 docs?

@onweru, thanks again. Do you mind resolving the conflict created after we cut the 1.11 docs?

@chipzoller, it's done.

There appears to be some duplication of anchor links in the preview, @onweru.

After going through the PR, I think those are the only two things!

Just realized that the hamburger menu on mobile doesn't work 🤦♂

Gentle bump on this, @onweru!

Search doesn't work.

Build is failing here.

Much appreciated, as always, @onweru!

/cherry-pick release-1-11-0

/cherry-pick release-1-11-0


Allow new prefabs to be easily registered

Currently when you create a new model you have to manually tag it and add it to the folder where all your prefabs are.
This should be streamlined to allow the user to press a key or use a plugin button to quickly register the prefab. Registering would be a simple TextBox prompt to give it a name for the tag, and off it goes.

With #9 being integrated, this comes with a change to how the folders are laid out. Everything is retroactively created in ServerStorage, and prefabs are required to be put in a subfolder. This makes adding prefabs a bit trickier, so having a way to automatically add them there and get them tagged is really important.

We now have public API under _G for doing this. _G.prefabs.register(model, name) and _G.prefabs.registerSelection(name). The latter is the same thing as the former, but implicitly passes in the first selection as the model.
This allows us to easily register a prefab, which will be tagged and cloned to ServerStorage. The original model gets to stick around as well, so you don't have to clone anything back into the workspace to use your newly setup prefab.


Vesting

Summary
This PR runs through the vesting flow using the core cosmos-sdk vesting module. We do not alter the vesting module code in this PR, only discuss which vesting module and vesting accounts to use and show instructions on how to kick off vesting.
Details

added a csv file containing addresses to vest to and amounts of tokens to vest, see scripts-local/vesting/vesting_accts.csv
added a script that kicks off DelayedVesting to these accounts, with CLIFF and DURATION paramaterized. See scripts-local/vesting/add_vesting_accts.sh
Within scripts-local/init_stride.sh, run the vesting script to start vesting

Testing
To vest tokens linearly with a cliff to a few accounts, run the standard local init process with make init-local build=s.
You should see this output in the shell
VESTING ACCOUNTS:
Vesting  100000000ustrd to stride1ze3jp6ut8ce9qrxtthh9r5cy632mn9rqchp8qy, with a 00D:02M:00.00S cliff, then linearly over 00D:05M:00.00S.
Vesting<PHONE_NUMBER>0ustrd to stride1qj0jws6fycdhxcja27tfwazdp26pq8mwpyt829, with a 00D:02M:00.00S cliff, then linearly over 00D:05M:00.00S.
Vesting  350000000ustrd to stride1qcrp9lefnnmtgx60nrm5quc6x88xp0u9ha7wp2, with a 00D:02M:00.00S cliff, then linearly over 00D:05M:00.00S.

The check the vesting accounts on the block explorer e.g. http://localhost:8080/stride/account/stride1ze3jp6ut8ce9qrxtthh9r5cy632mn9rqchp8qy.
See x/vesting/README.md for detailed testing instructions. Copied below:
Note that the amount vested is taken out of the total amount genesis'd to the account, it is NOT additional to the amount genesis'd (in this case, that means stride1ze3jp6ut8ce9qrxtthh9r5cy632mn9rqchp8qy will have 100000000ustrd total tokens, al of which will be vesting)
A simple way to check how much has vested is to look at the account on the block explorer (with our local ping.pub, setup from https://github.com/Stride-Labs/explorer, that's http://localhost:8080/stride/account/stride1ze3jp6ut8ce9qrxtthh9r5cy632mn9rqchp8qy).
Another way is to attempt to bank send the full acct balance to another addr before the vest has completed. Inspecting that failed tx will show you how much is available to send (which tells you how much has vested thus far). To test vesting via the bank send approach, swap out an address in the vesting csv for one you control, then during vesting
strided-local='build/strided --home ./scripts-local/state/stride'
strided-local tx bank send val1 stride1ft20pydau82pgesyl9huhhux307s9h3078692y <TOTAL_BALANCE>ustrd --chain-id STRIDE --keyring-backend test -y
strided-local q tx <TX_HASH_FROM_PREV_TX>

Once vesting completes 7 min from genesis, bank sending the full account balance should succeed!
Open questions

Should we switch to using Osmosis' [version of the vesting module](https://github.com/osmosis-labs/cosmos-sdk/tree/osmosis-main/x/auth/vesting
https://docs.evmos.org/modules/vesting/ )? Need to look through it to see what (if anything) they added
Do we want/need clawbacks?

For mainnet
We want delayed vesting for all vesting accounts. We simply need to, for each acct

calc the amount to vest
have the recipient set up an addr on testnet, save their seed phrase and send us the address
set up vesting for that account with the following paramsVESTING_START_TIME=1685592000 # June 1st 2023
VESTING_END_TIME=1780286400 # June 1st 2026
VESTING_AMT='XXXustrd'
VESTER_ADDR='YYY'
$STRIDE_CMD add-genesis-account $VESTER_ADDR $VESTING_AMT --vesting-start-time $VESTING_START_TIME --vesting-end-time $VESTING_END_TIME --vesting-amount $VESTING_AMT

Sorry for the delay - will review this tomorrow!

I think the params might be off
VESTING_START_TIME=1685592000 # June 1st 2023
VESTING_END_TIME=1780286400 # June 1st 2026
VESTING_AMT='XXXustrd'
VESTER_ADDR='YYY'
$STRIDE_CMD add-genesis-account $VESTER_ADDR $VESTING_AMT --vesting-start-time $VESTING_START_TIME --vesting-end-time $VESTING_END_TIME --vesting-amount $VESTING_AMT

otherwise this lgtm!

this looks great to me! very thorough README as well
only question from my end, do we need to add all the vesting accounts at genesis, or is it possible to add any after chain is launched? totally fine if it's genesis, just means we should be more meticulous about it before launch

Genesis afaiu!


Website | Contribution section

@reb-dev Unfortunately, I got locked out earlier than I expected, so I won't be able to push my changes. There was not much, just a short intro and a mermaid diagram of containers, the components they support, and their relationship to the core classes.


Reduce short lived string allocations by 25% in unmarshal_response

With prime_ems for a small vsphere:
All allocations:
Before:
216,588 T_STRING:String
85,766  T_STRING:VimString
After:
163,864 T_STRING:String
85,766  T_STRING:VimString
FYI, without freezing:
180,272 T_STRING:String
85,766  T_STRING:VimString

Note, this won't drop memory usage, it might raise it slightly since we're freezing strings but it should decrease some work done by the garbage collector.
cc @Fryguy @roliveri

@jrafanie Another approach is converting the strings to symbols.  Would that be a better/worse approach than freezing all these strings that are hash keys?

Yes, @chessbyte, but we'd have to change all the consumers of this code to expect symbols instead of strings as keys.

I understand that my suggested approach may be done in the future and not make it into Capablanca release.  My question is would using symbols be more performant?

I don't think it's a good idea to create symbols based on external data. I don't think symbols are ever GC'd, so doing so could be an avenue of attack. Are frozen strings GC'd?

We already create symbols here.  I changed that years ago

Both symbols and frozen strings are GCed once they are no longer used.

@Fryguy if we are already creating symbols, what is this PR doing freezing strings?

Was that always the case for symbols? I recall reading an article about it once.

@roliveri In some version of Ruby 2.x, they started garbage-collecting symbols

These strings are used as the key into the Hash.  When you put a string into a key, Ruby will dup and freeze under the covers, doubling the allocations.  If you freeze it yourself beforehand, you avoid the dup.
If you're talking about using Symbols here in the Hash keys, yeah we can probably investigate that, but then again it might not make sense, depending on the contents of "name", and who the callers are.

I am +1 on this PR as it seems to be an improvement.  In the future (separate PR), I would still like to investigate memory usage with using Symbols exclusively for the Hash keys.


Add nil check for C.calloc returned pointer

This issue is pointed out in https://github.com/fluent/fluent-bit-go/pull/52#pullrequestreview-913264420.
C.calloc has a possibility to return nil when allocation failure is occurred.
Signed-off-by: Hiroshi Hatake<EMAIL_ADDRESS>

Using C.CBytes is better. I'll send another PR.

This implementation is also likely acceptable for us.
Valgrind output is:
==428284==
==428284== HEAP SUMMARY:
==428284==     in use at exit: 127,974 bytes in 4,341 blocks
==428284==   total heap usage: 12,538 allocs, 8,197 frees, 61,833,807 bytes allocated
==428284==
==428284== Thread 1:
==428284== 16 bytes in 1 blocks are definitely lost in loss record 9 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x1885A4: flb_calloc (flb_mem.h:64)
==428284==    by 0x188DF3: flb_input_new (flb_input.c:204)
==428284==    by 0x16EA73: service_configure_plugin (fluent-bit.c:738)
==428284==    by 0x16EFFC: service_configure (fluent-bit.c:875)
==428284==    by 0x16F85C: flb_main (fluent-bit.c:1169)
==428284==    by 0x16F9FB: main (fluent-bit.c:1244)
==428284==
==428284== 17 bytes in 2 blocks are definitely lost in loss record 10 of 560
==428284==    at 0x483B7F3: malloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x58C6317: _cgo_093bc2b2a8ef_Cfunc__Cmalloc (_cgo_export.c:30)
==428284==    by 0x5747527: runtime.asmcgocall.abi0 (asm_amd64.s:765)
==428284==    by 0x1FFEFFD5CF: ???
==428284==    by 0x572154C: runtime.park_m (proc.go:3516)
==428284==    by 0x57455A4: runtime.mcall (asm_amd64.s:307)
==428284==    by 0x1FFEFFD5E7: ???
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 497 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5BC7: x_cgo_sys_thread_create (gcc_libinit.c:27)
==428284==    by 0x574531B: _rt0_amd64_lib (asm_amd64.s:53)
==428284==    by 0x2: ???
==428284==    by 0x4011B89: call_init.part.0 (dl-init.c:72)
==428284==    by 0x4011C90: call_init (dl-init.c:30)
==428284==    by 0x4011C90: _dl_init (dl-init.c:119)
==428284==    by 0x4FBD894: _dl_catch_exception (dl-error-skeleton.c:182)
==428284==    by 0x40160BE: dl_open_worker (dl-open.c:758)
==428284==    by 0x4FBD837: _dl_catch_exception (dl-error-skeleton.c:208)
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 498 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5DB6: strconv.small (gcc_linux_amd64.c:73)
==428284==    by 0x58C5DB6: _cgo_sys_thread_start (itoa.go:16)
==428284==    by 0x5747566: runtime.asmcgocall.abi0 (asm_amd64.s:795)
==428284==    by 0x632EA97: ???
==428284==    by 0x571E686: runtime.newm (proc.go:2230)
==428284==    by 0x5741348: runtime.main.func1 (proc.go:175)
==428284==    by 0x5745625: runtime.systemstack.abi0 (asm_amd64.s:383)
==428284==    by 0x5749E0A: runtime.newproc.abi0 (<autogenerated>:1)
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 499 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5DB6: strconv.small (gcc_linux_amd64.c:73)
==428284==    by 0x58C5DB6: _cgo_sys_thread_start (itoa.go:16)
==428284==    by 0x5747566: runtime.asmcgocall.abi0 (asm_amd64.s:795)
==428284==    by 0x56F2266: runtime.newobject (malloc.go:1228)
==428284==    by 0x632EA3F: ???
==428284==    by 0x571E686: runtime.newm (proc.go:2230)
==428284==    by 0x571ED6E: runtime.startm (proc.go:2485)
==428284==    by 0x571F299: runtime.wakep (proc.go:2584)
==428284==    by 0x5723037: runtime.newproc.func1 (proc.go:4261)
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 500 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5DB6: strconv.small (gcc_linux_amd64.c:73)
==428284==    by 0x58C5DB6: _cgo_sys_thread_start (itoa.go:16)
==428284==    by 0x5747566: runtime.asmcgocall.abi0 (asm_amd64.s:795)
==428284==    by 0x56F2266: runtime.newobject (malloc.go:1228)
==428284==    by 0x632E99F: ???
==428284==    by 0x571E686: runtime.newm (proc.go:2230)
==428284==    by 0x571ED6E: runtime.startm (proc.go:2485)
==428284==    by 0x571F20B: runtime.handoffp (proc.go:2519)
==428284==    by 0x571F314: runtime.stoplockedm (proc.go:2598)
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 501 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5DB6: strconv.small (gcc_linux_amd64.c:73)
==428284==    by 0x58C5DB6: _cgo_sys_thread_start (itoa.go:16)
==428284==    by 0x5747527: runtime.asmcgocall.abi0 (asm_amd64.s:765)
==428284==    by 0x7FFF: ???
==428284==    by 0x3: ???
==428284==    by 0xC00006116F: ???
==428284==    by 0x632EB47: ???
==428284==    by 0x5722F04: runtime.malg.func1 (proc.go:4224)
==428284==    by 0x5745625: runtime.systemstack.abi0 (asm_amd64.s:383)
==428284==
==428284== 320 bytes in 1 blocks are possibly lost in loss record 502 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==428284==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==428284==    by 0x4897322: allocate_stack (allocatestack.c:622)
==428284==    by 0x4897322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==428284==    by 0x58C5B30: _cgo_try_pthread_create (gcc_libinit.c:100)
==428284==    by 0x58C5DB6: strconv.small (gcc_linux_amd64.c:73)
==428284==    by 0x58C5DB6: _cgo_sys_thread_start (itoa.go:16)
==428284==    by 0x5747566: runtime.asmcgocall.abi0 (asm_amd64.s:795)
==428284==    by 0x2DF81987: ???
==428284==    by 0x571E686: runtime.newm (proc.go:2230)
==428284==    by 0x571ED6E: runtime.startm (proc.go:2485)
==428284==    by 0x571F299: runtime.wakep (proc.go:2584)
==428284==    by 0x5720A64: runtime.resetspinning (proc.go:3216)
==428284==    by 0x572101D: runtime.schedule (proc.go:3374)
==428284==
==428284== LEAK SUMMARY:
==428284==    definitely lost: 33 bytes in 3 blocks
==428284==    indirectly lost: 0 bytes in 0 blocks
==428284==      possibly lost: 1,920 bytes in 6 blocks
==428284==    still reachable: 126,021 bytes in 4,332 blocks
==428284==         suppressed: 0 bytes in 0 blocks
==428284== Reachable blocks (those to which a pointer was found) are not shown.
==428284== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==428284==
==428284== Use --track-origins=yes to see where uninitialised values come from
==428284== For lists of detected and suppressed errors, rerun with: -s
==428284== RROR SUMMARY: 77 errors from 10 contexts (suppressed: 0 from 0)

This implementation is hard to read and understand. But valgrind does not complains memory leaks except for:
==428284== Thread 1:
==428284== 16 bytes in 1 blocks are definitely lost in loss record 9 of 560
==428284==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==428284==    by 0x1885A4: flb_calloc (flb_mem.h:64)
==428284==    by 0x188DF3: flb_input_new (flb_input.c:204)
==428284==    by 0x16EA73: service_configure_plugin (fluent-bit.c:738)
==428284==    by 0x16EFFC: service_configure (fluent-bit.c:875)
==428284==    by 0x16F85C: flb_main (fluent-bit.c:1169)
==428284==    by 0x16F9FB: main (fluent-bit.c:1244)

But, in short, memory consumption is slightly increasing when running Fluent Bit with in_gdummy.
Golang's GC mechanism is not non-deterministic for freeing memory.
I'd like to choice the easy to read and understandable implementation, #3.


Spider: PA Department of Environmental Protection

Agency Name: PA Department of Environmental Protection
Spider Name: pa_energy
Website:
http://www.ahs.dep.pa.gov/CalendarOfEvents/Default.aspx?list=true
Scraping Notes:
A list of dates, plaintext

I'll start on this one.

I'm going to start working on this.

Hey I started trying to scrape the site using the scrapy shell and have encountered this error:
2019-09-07 14:38:05 [scrapy.downloadermiddlewares.robotstxt] DEBUG: Forbidden by robots.txt: <GET http://www.ahs.dep.pa.gov/CalendarOfEvents/Default.aspx?list=true>
So the website is telling people it doesn't want to be scraped.  Where do we want to go from here?  Is there maybe another place that could be scraped with similar information that you know of?

Here's the verdict:

Ignore robots.txt files for government sites. The Wayback Machine has started ignoring them generally, and it's really just an internet courtesy thing that shouldn't apply to public information. We left ROBOTSTXT_OBEY as true in the scrapy settings because it's the default, and that way we can more easily keep track of where sites are blocking scrapers by enabling it on a per-spider basis like here https://github.com/City-Bureau/city-scrapers/blob/c23f1fd17b1ced1c01dff295c8cdf1ca191f0244/city_scrapers/spiders/chi_ssa_34.py

So when you run into this, set ROBOTSTXT_OBEY as False

I am interested in giving this issue a shot and debugging if anyone has made progress or is still giving this a go.

Hey I'm just about finished at this point.  Just waiting for the code to be reviewed


trigger LOAD action on container initialisation

A possible fix for #154
Trigger collection.LOAD when the CollectionPageComponent is initialised. This would guarantee that the collection.LOAD action is properly triggered.

This will be fixed in the V4 example


⚠ Jenkins Plugins Artifactory has degraded performance

In 120b036, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1303 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 71c37f2 after 18 minutes.


Restore VT hack for Windows

restore VT enable hack;  this is restoring 2 lines of code that were removed in a previous commit of mine (https://github.com/junegunn/fzf/pull/2430/commits/281f9982acef2d3dfcb68545cee2383f0d29ad3f)
resolves an issue reported in kelleyma49/PSFzf#84

Thanks.
@rashil2000 Can you confirm if this fixes your problem?

Yes, I'm currently using fzf built from @kelleyma49's fork and it solves the problem.

Merged, thanks!


Support select spec attribute boxes

:tada: This PR is included in version 1.0.0 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


IE support

While Angular2 itself is said to support IE (9,10,11), I'm having difficulty running this project on IE. I'm getting the following errors:
SCRIPT28: Out of stack space
es6-shim.js (245, 7)

SCRIPT2343: Stack overflow at line: 245

SCRIPT5022: reflect-metadata shim is required when using class decorators
angular2.js (6998, 6)

It's probably an issue with es6-shim.js/webpack but I can't figure it out. I can get ng2-play to start up fine in IE, so it must be something to do with the way this particular project is set up. Any ideas @gdi2290 ?

can you try this repo (it's a little bit outdated) https://github.com/angular/universal-starter and see if it runs?

Universal-starter does seem to start up fine (when I add es6-shim).

it might be my version of es6-shim

I updated the es6-shim script tag to latest, but that wasn't it.
Ah, but this issue may be the cause (https://github.com/angular/angular/issues/5306), which I just stumbled upon.

Ah ha. For those encountering this problem, inserting
import 'reflect-metadata';

to the first line in bootstrap.ts seems to have fixed this for me, as mentioned [here] (http://stackoverflow.com/questions/30911861/angular2-jspm-io-reflect-metadata-shim-is-required-when-using-class-decorato).


[Extensibility Bug]  codeunit 457 "Environment Information" - IsOnPrem

/// <summary>
/// Checks the deployment type is OnPremises.
/// </summary>
/// <returns>True if the deployment type is OnPremises, false otherwise.</returns>
procedure IsOnPrem(): Boolean
begin
    exit(EnvironmentInformationImpl.IsOnPrem());
end;

In our Pipelines with Sandbox Dockers the procedure IsOnPrem returns true.
I would expect that we receive false for Sandbox Dockers and true for OnPrem Dockers.
as an alternative it might be helpful to know the difference if it is real OnPrem or only a docker for testing.

@freddydk, here's another issue related to Docker deployments. The assumption seems to be, that Sandbox Docker containers emulate that they're SaaS. In reality they aren't - they also don't have entitlements enabled etc. There seems to be some confusion / missing functionality we must address.

For testing whether you are running on Saas or not you should use IsSaasInfrastructure.

In that case, I will close this issue. @pri-kise, please reopen if you disagree.