WIP: Cleaning Code

WIP: Cleaning code!

Codecov Report

Merging #481 (7040b24) into main (a05d119) will increase coverage by 0.08%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   20.06%   20.15%   +0.08%
==========================================
  Files         163      163
  Lines       23326    23352      +26
==========================================
+ Hits         4681     4707      +26
+ Misses      17888    17887       -1
- Partials      757      758       +1

Impacted Files
Coverage Δ

app/app.go
86.13% <ø> (+1.49%)
:arrow_up:

x/gamm/keeper/pool.go
81.08% <0.00%> (+1.35%)
:arrow_up:

x/pool-incentives/keeper/distr.go
84.69% <ø> (-1.03%)
:arrow_down:

x/pool-incentives/types/genesis.go
32.00% <0.00%> (-2.79%)
:arrow_down:

x/claim/keeper/claim.go
65.54% <33.33%> (-1.13%)
:arrow_down:

x/pool-incentives/genesis.go
100.00% <100.00%> (ø)

x/pool-incentives/module.go
58.06% <100.00%> (ø)

x/lockup/keeper/store.go
94.73% <0.00%> (+0.14%)
:arrow_up:

x/lockup/keeper/lock.go
76.73% <0.00%> (+1.27%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05d119...7040b24. Read the comment docs.

LGTM other than claims parameter and simulation log line!


First Shard Group Save and Load Checkpoint for HSDP

Based on my understanding, current strategy:
1.	All ranks currently read and load the checkpoint.
2.	All ranks also save and write the checkpoint.
I have a question regarding the HSDP case:
If different shard groups write data to storage, could this lead to data corruption?
Ideally, should only the first shard group read the data, broadcast it, and handle writing to ensure consistency?

maye @tianyu-l @fegin know ?

If different shard groups write data to storage, could this lead to data corruption?
Why would this lead to data corruption?

Ideally, should only the first shard group read the data, broadcast it, and handle writing to ensure consistency?
DCP will only save one copy of the data if the data is replicated across ranks. It is not necessary the first rank/first group will save the replicated data. DCP will decide this during the planning phase.

@fegin
Thank you for your explanation.
Why would this lead to data corruption?

When multiple processes write to the same file, isn’t it common to encounter data corruption without proper file locks or scheduling mechanisms?
DCP will only save one copy of the data if the data is replicated across ranks.

Interesting—thank you for clarifying. If there’s a planner coordinating the writes, the file system corruption issue should not occur.
In the meantime, I’ve been exploring the DCP implementation and APIs. However, there is no detailed documentation explaining the coordinator or planner components.
I’d like to share what I’ve found so far. Please correct me if I’m mistaken, and hopefully, this will help others as well:
•	dcp.save has an argument called process_group.
•	The _DistWrapper class accepts the process_group.
•	In this code snippet, central_plan: SavePlan = distW.reduce_scatter("plan", local_step, global_step) seems to coordinate the saving process.
•	If we pass process_group=None, this code handles deduplication.
Based on this logic, it seems that setting process_group=None might be the best approach. Could you confirm if this should always be the case?
Additionally, I have another question:
Does the logic of dcp.load work similarly to dcp.save, or do all ranks operate independently without synchronization? For replicated groups, do they read the same data? It seems there are no deduplication and broadcast states.

When multiple processes write to the same file, isn’t it common to encounter data corruption without proper file locks or scheduling mechanisms?

Yes, but even if DCP's planner decides to save multiple copies, it still won't cause data corruption because different ranks write to different files.
What your understanding is mostly correct. As for world PG, there may be case where users would like to save among only a subset of ranks, this is not common but some advanced users may have their own infra architectures design that is not common as well.
As for the loading, there is again a planning phase which will coordinate all the ranks to load the data correct without loading redundant data. And DCP assumes a distributed file system such that each rank can access the required files. If such a file system does not exist, users will need to ensure the required files can be accessed.


Disabling global access to service plans has no effect when a tile has the option enabled.

If a tile is deployed with Service Access enabled and that the operator disables global access for service then the service remains globally accessible.
When global access to plan is disabled, the deploy-all errand should disable-service-access.

Won't fix. This option is for when a tile is not deployed and is not supposed to track changes made after.


Discussion - Metrics in sarama

I have been fighting with go-metrics model of doing stats. There is definitely a gap between go-metrics and prometheus etc. Then I came across https://github.com/rcrowley/go-metrics/pull/242#issuecomment-455613410.
That makes me wonder if we should think about doing stats in sarama in a different way. thoughts?
@bai - Please feel free to add more folks here.

@bai have you looked at https://opencensus.io. May be we should use that in place of go-metrics?

I'm just flying from KubeCon right now and the news is that OpenCensus and OpenTracing are merging into OpenTelemetry. I think it makes sense to explore using OpenTelemetry instead of go-metrics, I'll take a look and will follow up here over the next few weeks.

Oh man, I hope they keep the api same, otherwise it's gonna be a big headache for us. Yeah, let's look at them as they look great for our use case.

OpenCensus look still stable for our, OpenTelemetry has a long milestone to stable - (12/2019)

To be honest, given this is a breaking change and it kind of paves the way for Sarama 2.0, I don't think it's going to take less than a few months to go over, incorporate, and stabilize this list.

Yeah, let do that. Also should we add metrics change to above list?

yep, waiting for Sarama@v2.


Save "type of measurement" along with topography

Feature request: Consider adding a field like "type of measurement"
which contains radio buttons for "Scanning probe microscopy" and
"Stylus profilometry" and "Optical profilometry" and "Electron
microscopy" and maybe a few others.
o I can imagine that it would be useful for a user to filter by
type of tool (using protected fields) or analyze all
measurements of a certain type.
o It would also be useful to be able to color-code plots by
instrument type (similar to how we do this in the ACS AMI paper.)

Yes… We should discuss this. We could of course easily add this field
but it may be superseded by something more complete. I was thinking
about adding instruments, such that one can define the instrument that
was used for a certain measurement. An instrument would then have the
property stylus, optical, etc.

I would also like to implement sth more generic like the instruments.

I'm setting this to wontfix for now since #620 is a more practical suggestion.

Since #620 is implemented now and will be released with version 0.15, I'm closing this.
In #620 it's implemented that every measurement saves an instrument type.

Awesome, thank you!

Von: Michael Röttger @.***>
Gesendet: Mittwoch, 4. August 2021 17:52
An: ContactEngineering/TopoBank
Cc: Lars Pastewka; Comment
Betreff: Re: [ContactEngineering/TopoBank] Save "type of measurement" along with topography (#546)


Duplicate Food Item Added to Cart

When a user adds the same food item to the cart more than once, it shows up multiple times in the cart. This shouldn't happen. The cart should either increase the quantity of the item or not allow adding it again.

may be user want more than one time

we can increase the count of quantity instead of multiple entries please check the image

sure , i will assigned it to you,

make sure star ⭐  repo

Hi @mohitahlawat2001, I have implemented this can I raise PR for this now ?


Auto generate placeholder

If I want use placeholder with same label attribute need use code
<?= $form->field($model, 'customer_name')->textInput(['placeholder' => $model->getAttributeLabel('customer_name')])->label(false); ?>

Why no options to auto generate placeholder from AttributeLabel?

Ups, @vladis84 it seems we did the same work :) I believe that this feature should be applied to all types of Html::activeInput like, for example, password field.

You're right about that

Resolved by #15405


Merge crypto implementation into SDK

Issue: #94
Merged all crypto implementations into the SDK
Dragon Milestone / 2: https://github.com/nemtech/nem2-sdk-typescript-javascript/milestone/2

Pull Request Test Coverage Report for Build 453

1224 of 1293 (94.66%)  changed or added relevant lines in 34 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.8%) to 83.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/core/crypto/KeyPair.ts
16
17
94.12%

src/core/format/RawUInt64.ts
33
34
97.06%

src/core/crypto/SHA3Hasher.ts
15
18
83.33%

src/core/format/Convert.ts
57
63
90.48%

src/core/format/RawAddress.ts
37
44
84.09%

src/core/crypto/Utilities.ts
107
120
89.17%

src/core/crypto/nacl_catapult.ts
675
688
98.11%

src/core/crypto/Crypto.ts
77
102
75.49%

Totals

Change from base Build 442:
4.8%

Covered Lines:
2882

Relevant Lines:
3289

💛  - Coveralls

Pull Request Test Coverage Report for Build 453

1224 of 1293 (94.66%)  changed or added relevant lines in 34 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.8%) to 83.577%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/core/crypto/KeyPair.ts
16
17
94.12%

src/core/format/RawUInt64.ts
33
34
97.06%

src/core/crypto/SHA3Hasher.ts
15
18
83.33%

src/core/format/Convert.ts
57
63
90.48%

src/core/format/RawAddress.ts
37
44
84.09%

src/core/crypto/Utilities.ts
107
120
89.17%

src/core/crypto/nacl_catapult.ts
675
688
98.11%

src/core/crypto/Crypto.ts
77
102
75.49%

Totals

Change from base Build 442:
4.8%

Covered Lines:
2882

Relevant Lines:
3289

💛  - Coveralls


Error running image after building dockerfile

Hi Jonathan, thanks for making this repository. I can tell you put a lot of thought into it.
I'm having trouble running a container after building the Dockerfile myself. For example, I ran the following command to build on Ubuntu 20.04:
docker build -t babelfish:2.2.1 . --build-arg BABELFISH_VERSION=BABEL_2_2_1__PG_14_5

And then try to run with:
docker run babelfish:2.2.1

However, I get the following error:
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/start.sh": permission denied: unknown.

I'm not sure if your warning about CRLF vs LF in the start.sh script applies to me, since this is on Linux, but I checked anyways, and it seems like the script has LF:
cat -A start.sh

#!/bin/sh$
BABELFISH_HOME=/opt/babelfish$
BABELFISH_DATA=/data/babelfish$
$
cd ${BABELFISH_HOME}/bin$
$
# Set default argument values$

Do you have any guidance on how to overcome this error?

UPDATE.
I spent half an hour debugging, got frustrated, wrote this issue, then tried one last thing, and it worked.
On Ubuntu host:
chmod +x start.sh

BEFORE building. Now it runs.

Thanks for letting me know the resolution. I updated the readme with your guidance.


PopupMenu rework and enhancements.

Initially inspired by this reddit post, which never got it's own issue submitted. This PR resolves a few existing issues with PopupMenu's which did have issue tickets, but also a few others which I found when making this PR.

Popup menu size can now be limited, and content will scroll. Previously, if the popup menu had a lot of items, it would take up the entire window height and then scroll from there. Now, the size of popup menus can be limited by using get_popup()->set_max_size() (in C++) or get_popup().max_size (in GDScript). Of course, this works both in editor and in projects.
This can be selectively used around the editor to help resolve ui issues such as #22404. Examples in-editor shown below.

Added margin container which improves consistency of look, as well as makes item positioning code simpler and easier to understand.
Now uses a scroll container so users know it can be scrolled. This also allows the user to scroll without a scroll wheel by clicking and dragging the scrollbar. Previously users needed a scroll wheel to be able to scroll. (Closes #29111)

Changing item selection with arrow keys now scrolls to follow selected item, whereas previously it did not. (resolves this comment by @KoBeWi, which did not have a separate issue: https://github.com/godotengine/godot/issues/29111#issuecomment-495631414)
Scrolling with arrow keys stops at first or last item when scrolling up and down, respectively. Previously it looped around and kept on going.

Fixed submenu autohide areas to match exactly the hover area.  Also fixed selection of which item was hovered, as that was also slightly off. Previously the darker area which represented which item was hovered did not accurately represent the size of the actual item. As you can see, submenu's are correctly placed when scrolling is used. Note: I am not recommending that the project menu is made to scroll, this was only for submenu testing purposes.

When search is enabled, selected item from search query will be scrolled to and highlighted. In the below case I type "obj" and then "res".

Reduced code duplication by moving query of item icon size to a member function in the Item struct.
General code clean up - comments where needed, and rewording variables to be more clear about what they are.

Bugsquad edit: Also fixes #41564.

Would be cool if you added hysteresis too 🙃
I have an unfinished PR that attempted to implement it: #35487

@KoBeWi That's a good feature, I'll see if I can add it in this PR.

It looks great ! :) I'll have a look to the code.

@KoBeWi I have made some progress on adding that, but I think I would put it in a separate PR so it can be reviewed separately from this PR, and not too many features/changes get muddled up in one PR.

Hmm yeah it looks like the height of the contents  is calculated with an extra very small value, so the contents has to scroll a tiny bit. Will investigate in the morning

Looks like there are a number of issues to resolve...

(This existed before this PR) Popups have height set to 100px even if they do not need it. See File -> Convert To.... The weird thing is that this doesn't seem to apply to all menus... See File -> Open Recent (when the list is empty), which does not have the same issue.

The issue Kobewi pointed out above, plus: the scroll bars do not focus automatically on what seems to be only these popup menus. When you hover the bar it does not highlight. Additionally, when you do click on the scrollbar then is highlights and you can click and scroll.

When a max size is not set, and the popup menu minimum size returns something higher than the screen height, no scrollbar is visible and you cannot scroll.

@KoBeWi ok, all done. I found some more stuff as in my previous comment which is now resolves.
The issue you found was really weird... It seems like the setting of the margin was not occurring properly on the margin container. So, the margins were 10px, but the content thought it was only 8px (which is what it should be). Therefore there was a 4px scroll (10px2 - 8px2). Anyway, moving the setting of the margins away from notification enter tree is what worked.
@groud if you care to re-review, the changes of the most recent commit (which were squashed into one) were:
popup.cpp

Added check which ensures popup is not larger than parent, and also does an early exit is max size is not set (Lines 129 to 141). This is part of what solved #3 above

popup_menu.cpp

Limited PopupMenu height to usable parent rect height. (lines 104 to 108) - this fixed #3 above
Used set_as_minsize() to 'shrink' the borders of the submenu (line 200) - this is what fixed #1 above. Also did this in the PopupMenu::Popup() method, in case it is not a submenu.
Moved setting of margin overrides for the margin container from ENTER_TREE to VISIBILITY_CHANGED (and after is_visible() check) - fixed Kobewi's issue and #2 above

As a bonus, this PR also fixes the issue where popup menus were going off screen:

After:

Thanks! Amazing work :)

Awesome, thanks a lot !

will this be backported to the v3 branch?

Is this obselete?

Is this obselete?

This pull request was merged in the master branch (for 4.0.alpha), but it won't be cherry-picked to 3.x as it introduces compatibility-breaking changes.

I'm interested in backporting these changes, but what are the mentioned "breaking changes"? And what features should I avoid backporting?

I'm not too sure. @Calinou is it breaking change because of the fact that it changes the way the popup looks?
I don't think there was any breaking api changes by looking at the code, only the addition of the Max_size property. If you like, you can try backporting it and see how you go. Working through it will probably make any breaking changes more obvious.


How to deal with different licenses?

Should all data within a collection be required to have the same license?

It would be quite confusing for the user if they have to check every response for a license link in the case that some response superseeds the license in collection as a whole.
I would much prefer a rule like:
"A collection SHALL have a license (public domain or CC by 4). All data delivered as part of this collection is assumed to be under this license". @mrauhala @Teddy-1000 Is it possible to setup RODEO so that its one license pr. collection? Which would probably mean more than one collection for e-soh? If not, how should we advice the user how to handle this?

I think we can advise the implementer to split data in to several collection if the data in a collection have incompatible licenses, if all licenses are a form of free use, having the most restrictive one should suffice. We could also specify a data query dimension where you can select a list of licenses.
For this profile, it is for RODEO, I suggest we assume most, if not all, data will be free to use.

I have another question related to this. Say we set a license of CC by 4 for the rodeo open data collections . This will then in some cases (like E-SOH) include data from many countries. How do we practically fulfill the requirements of attribution?  Asking people to attribute "Rodeo" does not make a lot of sense I think? Or do we need to list all institutes who supply data to the collection?
This would be a lot easier if we release the data to the public domain (CC0), but I assume that is not really an option here.

In E-SOH all observations are required to provide the naming_authority, and can provide creator_name, institution. This metadata is attached to every observation. We could require this property to be included in all data replies.

Sounds doable. And in the end, it might be enough with an attribution to EUMETNET members or something like that. I will close this.


Support more diagnostic in ECC constants for percentile extraction

Add more diagnostics for ECC to support.

Corrected the upper bound to 100 km

This enables us to use the new diagnostics added to the suite, and the numbers now seem sensible. Merging.


Some delegate methods don't get called

popoverControllerDidPresentPopover gets called correctly but popoverControllerDidDismissPopover never gets called.

I believe your issue is a duplicate of #42, so I'm closing it.
Feel free to reopen it if you have a different problem, but add more details.
Thanks.


Browser context extensions json body

Adds an extension to the BrowserContext so that you can serialize a model object and send it as the requests body.

Slap some tests on that puppy and Bob's your uncle!

Is that single test enought? I'm not really sure how else to test it

Pretty sure I posted my comment before that last commit was pushed :-)


Fix leaky styles

https://rally1.rallydev.com/#/87829734000/detail/defect/92940705544

Haha I'm guessing this impacted tables inside tables?

Correct. See the defect


[epoch processing] Implement process_rewards_and_penalties

https://github.com/lambdaclass/lambda_ethereum_consensus/blob/66059de3653c17ae620ce2aca2db61c558057f6a/docs/specs/beacon-chain.md?plain=1#L2423-L2435
See Spec tests format: https://github.com/ethereum/consensus-specs/tree/dev/tests/formats/epoch_processing
Acceptance criteria:
Run corresponding spec tests by removing
https://github.com/lambdaclass/lambda_ethereum_consensus/blob/66059de3653c17ae620ce2aca2db61c558057f6a/test/spec/runners/epoch_processing.ex#L13

i will take this one

I'll work on this


Show dynamic offsets in event browser

Description

It'd be pretty useful if RenderDoc showed dynamic offsets of vkCmdBindDescriptorSets
(Because right now it just looks like a reduant DescriptorSet set)
Environment

RenderDoc version: 1.19
Operating System: Windows 11 x64
Graphics API: Vulkan

This is already possible if you want to see every parameter exhaustively to a function call. Click on 'settings and help' on the event filter, and enable the 'show all parameters' checkbox. For more information see the documentation for the event browser.


No doc

All these members says they should only be used by platform renderers.  Please provide more information here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5d898bf0-ba79-9f30-7bcc-77095d5319cf
Version Independent ID: 83607085-94c4-49c8-e834-ff9818f9bdb9
Content: IVisualElementController Interface (Xamarin.Forms)
Content Source: docs/Xamarin.Forms/IVisualElementController.xml
Product: xamarin
Technology: xamarin-forms
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and its API docs are built from /// in the dotnet/maui repository. Therefore, any issues with the .NET MAUI API docs should be opened in that repository.


Testing fails only on Windows

For some reason there's a segfault on Windows when running the tests but not on linux.
Working on this in fix-windows-test-segfault.

The primary cause for this was not at all what I expected.
There was a race condition in the way streams were being handled.
This root cause is now diagnosed and resolved.


Duplicate output in parallel-ssh

All functions that use parallel-ssh have duplicate output.
See https://github.com/pkittenis/parallel-ssh/issues/27 for more details.

Not important to functionality. May be dealt with in future versions for logging.


feature: import DMN 1.3

As a new user, I want to import my existing DMN 1.3 XML (Camunda BPM 7 variant) that I have invested into a long time ago, so that I don't need to manually recreate my hundreds of decision tables/DRDs.
This would be very valuable for onboarding.

GoRules was built to solve limitations, usability, and slow innovation speed of DMN. We have a lot of experience working with DMN (we have customised one of the non Java engines few years ago).
We didn't plan to support importing of DMN 1.3 standard in short term, but it is not yet excluded from the roadmap.

@ivanmiletic Thank you for the feedback. Looking forward to any news in this regard.
In the meantime, do you know of any tool that can generate a CSV from a DMN which I then can import into GoRules as a workaround? I understand that I'll probably need to still do a lot of manual work for replacing expressions and creating the graphs in the first place, but at least that would help in filling the decision tables.

[...] we have customised one of the non Java engines few years ago

May I ask which one?


[v3] input[type=date] placeholder is not centered vertically in latest Mozilla Firefox

Example: https://codepen.io/dartui/pen/drJPjQ
Code which generates bug: https://github.com/twbs/bootstrap/blob/v3.4.1/less/forms.less#L186-L202
And screenshot:

This is not causing any errors in Google Chrome.
Browser: Mozilla Firefox 65.0.1 (64 bit)
OS: Ubuntu 18.04.2 LTS

Thanks for reporting, but v3 development has ceased save for some recent security fixes. It'll soon be EOL (end of life) entirely, so closing this as a won't fix.


Prettier isn't formatting typescript correctly

Notice the diamond is formatted oddly:

How to fix?

This issue belongs in prettier. see https://github.com/prettier/prettier/issues/1825


Refactor project pay form

The Pay input was getting out of hand and impossible to maintain.
This PR:

adds a new context, PayProjectFormContext.
adds v1 and v2v3-specific PayProjectFormContext providers.
Uses these version-specific contexts in the respective project pages.
adds a new hook, usePayProjectForm.
Uses the new hook where appropriate

Other minor changes:

remove isSingleColumnLayout prop for project page. We can compute this internally using isPreviewMode.
rename weightedRate => weightAmountPerbicent
rename weightedAmount => weightAmountPermyriad
Minor NFT rewards cleanup

@johnnyd-eth can you pls review this one instead? It affects NFT rewards, so want to make sure nothings broken. Cheers.

Awesome cleanup @tomquirk. Code is great.
Noticed a regression in the NFT rewards no longer being linked to the pay input:

Clicking NFTs doesn't fill the pay input
Filling pay input doesn't select the appropriate NFT

https://user-images.githubusercontent.com/96150256/193432802-c79d68a0-992a-4573-8e37-1444a0879f60.mp4

Other than that, all looking good

ah shiet, thanks @johnnyd-eth . Realized the problem. Fixed it 🏓

@johnnyd-eth tested v1, v2 and nft rewards pay, all looking gucci. gonna merge


PMM-7 Fix Test T878

how is that a fix? :trollface: you removing annotation assertion from the annotation test
Method:
dashboardPage.verifyAnnotationsLoaded(annotationName, 1);
contains:
I.waitForVisible(this.annotationText(title), 30)
then we are testing it again with:
I.seeElement(dashboardPage.annotationText(annotationName), 10);


Update storage-files-identity-ad-ds-update-password.md

Added the Test-AzStorageAccountADObjectPasswordIsKerbKey so users can test their authentication is correct

@khdownie
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Requested changes have not been made. So I am going to make this change in the private repo.
#please-close


Since this golang module is v2 the go.mod needs to reflect that.

The go.mod file needs to have the right version, and since this grafana data source is v2.10.0, the module needs to be /v2.
invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We don't use these data sources as golang libraries, so there is no need to follow this convention.
(Thanks @andresmgot)


Can't add additional providers to LogstashAccessEncoder

Unlike with LogstashEncoder, you can't add a <provider> element to a LogstashAccessEncoder to add some additional fields. That means if you want to add additional fields (that aren't possible with customFields), you need to either

use AccessEventCompositeJsonEncoder and and rebuild the default behaviour of LogstashAccessEncoder or
subclass LogstashAccessEncoder and copy the addProvider method from LogstashEncoder.

LogstashAccessEncoder should support <provider> just like LogstashEncoder.

Fixed for next release

Excellent, thank you!


Azure Easy Deployment Based On AKS-Engine

Coverage remained the same at 34.607% when pulling 734c79932a748398ea4493de34abb31a91a0a978 on aks-engine-example into 2a3b5187760d1ca0109aa44f0ff236f44f8fc5e8 on master.

rename contrib/azure to contrib/aks-engine?

Done


chore(deps): update WPF to Caliburn.Micro 3.0.1

NOTE: could not update other platforms, we don't have them available at the moment

@brendankowitz Regarding this pending PR and another one ( #2 ), would you consider adding someone as a contributor, so to look after those?
Thank you
(Apologies for crossposting with Twitter, not sure how we can get in contact with you)

Thanks for the PR, since this nuget contains autofac integration for a number of platforms we should have a consistent package.
I will add you as a collaborator as it would be good to get everything up to date

Thanks for adding me/my team.
Only issue with this particular change was that on dev machine I could not open Windows Phone related projects, no WP8 SDK installed.
Let me see how it goes as soon as I manage to download & install SDK.

Perhaps it would be better to just remove the WP8 project. I would be ok this since WP10 is released.

I see (and that would be an easy start with project 😺 ). So looking at current projects:

Caliburn.Micro.Autofac.Packaging
Caliburn.Micro.Autofac.UniversalApps
Caliburn.Micro.Autofac.WinPhoneUniversal
Caliburn.Micro.Autofac.WP8
Caliburn.Micro.Autofac.WPF
samples\Sample-Win81
samples\Sample-WP7
samples\Sample-WP81
samples\Sample-WPF

are you suggesting to remove the following WP7/ WP8/ WP81 related ones?

Caliburn.Micro.Autofac.WP8
samples\Sample-Win81
samples\Sample-WP7
samples\Sample-WP81

Please, regarding removing WP8 projects, have a look at PR #3

Closing this PR as related work is happening now on branch caliburn-micro-3.0.1


Don't attempt to lookup class in internal bundles if a bundle was explicitly specified

I guess this PR depends on https://git.ouryahoo.com/vespa/vespa-yahoo/pull/10542?


Generate signals on the fly

Given we have an analytical model for Sine Gaussians that we can (most likely) implement in torch, we should probably just be generating these on GPU during training. I imagine sampling random parameters with bilby may bottleneck us, so it might also be necessary to implement some of these priors in torch

The only distribution not supported by ml4gw currently is LogUniform which is easy to do

Being worked on here: https://github.com/ML4GW/ml4gw/tree/dev


Repeated line in Inference.jl: @eval getspace(::Type{<:$alg{space}}) where {space} = space

I'm new to Turing, just tried to install and compile it in Julia 1.2 RC3 and got the following warning:
WARNING: Method definition getspace(Type{#s362} where #s362<:(Turing.Inference.SMC{space, F} where F)) where {space} in module Inference at /Users/gong/.julia/packages/Turing/eIa7P/src/inference/Inference.jl:92 overwritten at /Users/gong/.julia/packages/Turing/eIa7P/src/inference/Inference.jl:93.
  ** incremental compilation may be fatally broken for this module **

I looked at Inference.jl and saw that line 93 is an exact repeat of line 92:
@eval getspace(::Type{<:$alg{space}}) where {space} = space

I want to make sure that repeated line is not by mistake which may have caused the warning issued. Thanks.

Good catch, thanks! I believe this will be addressed when #793 goes through.

Is this fixed now?

I believe so, this was fixed with #793.

Please reopen this if you notice the issue come up again.


Sharing homework

I have been watching this course on youtube, and it's really really great. However, I can't find any homeworks on the site. Is it possible for you to share homework assignments?
Thanks

We are not planning to release homeworks outside the Stanford community.


kie-issues#41 DMN\BMPN Editors: The file is kept "dirty" after undoin…

…g one copy/paste operation
This PR closes: https://github.com/kiegroup/kie-issues/issues/41
Editor operations are implemented as commands, that are stored in a registry to have an option of undo an redo. The situation is quite complicated for complex operations, that are internally implemented as multiple commands, but for the end user is visible as single operation. For such, we must compose multiple commands into single one. In copy and paste scenario, we must go one level further and compose two already composed commands into single command.

Manual checks
Open file, copy and pase [one of below] then undo:

[ ] DMN single node
[ ] DMN Multiple nodes connected with edge
[ ] BPMN single node
[ ] BPMN Multiple nodes connected with edge

Open file, do some changes, copy and pase [one of below] then undo:

[ ] DMN single node
[ ] DMN Multiple nodes connected with edge
[ ] BPMN single node
[ ] BPMN Multiple nodes connected with edge

Open file, do some changes, save file, copy and pase [one of below] then undo:

[ ] DMN single node
[ ] DMN Multiple nodes connected with edge
[ ] BPMN single node
[ ] BPMN Multiple nodes connected with edge

The (build) kie-tools-stunner-editors check has failed. Please check the logs.

The (build) kie-tools-stunner-editors check has failed. Please check the logs.


Button in flex box (.d-flex) is stretched if not within a div

Not sure if I need to place elements in divs before putting them in a flex box, so it's possible this is working as intended. But just in case, if you place a button in a flex box (.d-flex) it's stretched to its height.
Look at the following code.

Headline

I'm fine

Headline

        I'm stretched

https://jsfiddle.net/oraoe2z7/
Edit: Adding .alingn-items-center removes the stretched look: https://jsfiddle.net/oraoe2z7/2/

I believe that this is normal flexbox behaveour. :)
The flex property is set to strech so the button streches..

@morloderex makes sense 🤦♂


sphinx_internal_class_name greatly increases search time

We rolled out TS3 in production today and immediately noticed the CPU on our searchd box spiked to over 100% and search page time about doubled.  All the sphinx queries were taking quite a bit longer.  The culprit turned out to be removing the line that adds @sphinx_internal_class_name SomeClass to every search query.  It appears that sphinx has to work a lot harder to do that field search and in our case it having the class name appended to every search was unnecessary since the indices were specified.
I'm not sure why sphinx_internal_class_name was added to TS3 (support for polymorphism?), but it seems like it'd be good to only add that to the search if it's needed.

@pat I hate to bring back an old ghost, but if we are not using STI, can we safely remove sphinx_internal_class_name from our sphinx.conf file? Or do we need it as an attr for any reason?

Hi Chris
I'd expect sphinx_internal_class_name to not appear in SQL-backed indices unless the model's inheritance column is present (and thus, inheritance of some sort is in play).
However, I'm not sure if this behaviour is matched with real-time indices. Can you confirm what type of indices you're using and which version of Thinking Sphinx?

I'd expect sphinx_internal_class_name to not appear in SQL-backed indices unless the model's inheritance column is present (and thus, inheritance of some sort is in play).

That's what I'd expect too... Though we haven't removed it because we don't want to break anything.

However, I'm not sure if this behaviour is matched with real-time indices. Can you confirm what type of indices you're using and which version of Thinking Sphinx?

ThinkingSphinx version is 3.1.4. I'm not a Sphinx expert... I know we're using the real-time, and I'm pretty sure on-disk as well, but I'd have to check.

So I've pushed a fix for this to the develop branch (48921d6b28ef8fcd59be460404af90937473e55e) - the automatic removal of the sphinx_internal_class_name field wasn't happening for real-time indices. So, to use this change, you can modify your Gemfile to include the following:
gem "thinking-sphinx", "~> 3.3.0",
  :git    => "git://github.com/pat/thinking-sphinx.git",
  :branch => "develop",
  :ref    => "48921d6b28"

Granted, this means you'll need to step through upgrading from 3.1.4 to 3.3.0 (the release notes listed in the README should cover all the relevant changes).
The only commit that may cause headaches that is more recent than 3.3.0 is 839d480f72dc811d57be396846b86bed564b1c72 - I'd hope that'll actually be fine, but to be on the safe side (and for future upgrading friendliness), any filters should be cast to their appropriate types.


Override batch numbers in MergeFiles()

Fixes #867

Codecov Report

Merging #870 (51ab35d) into master (790ab40) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #870   +/-   ##
=======================================
  Coverage   92.27%   92.27%
=======================================
  Files          66       66
  Lines        5126     5129    +3
=======================================
+ Hits         4730     4733    +3
  Misses        233      233
  Partials      163      163


Why layout in SmemLayoutAtomVtransposed has to be kBlockN?

Hello, amazing performance of flash2~ I am reading the source code and I found that layout in SmemLayoutAtomVtransposed has been set as Layout<Shape<Int, Int>. However, the reference layout in cutlass 3.0 default_gemm_configuration.hpp is Layout<Shape<Int, Int<8>>. I have verified the kernel result after replacing kBlockN with 8 and get wrong result. It is so strange and I would like to ask you for the reason of this phenomenon.

I don't know tbh. It was trial-and-error. I think it has to do with V being transposed.

I see, thank you~


Improve documentation about data/values and output directory flag

I happened to find this tool and tried it, but stumbled upon some unexpected behavior.
Hope the following improvements would help new users.

Document that at least one YAML document with @data/values annotation should be included in the input when --data-value option is given.
Document that --output-directory option will empty the target directory.

Document that --output-directory option will empty the target directory.

any ideas where to place this note in the docs?

maybe a separate section on outputs?

updated https://github.com/k14s/ytt/blob/master/docs/ytt-data-values.md and added https://github.com/k14s/ytt/blob/master/docs/outputs.md. thanks for letting us know!


Why ef core 2.1 generates multiple select for include

I have an ef command which is:
var project = await _context.Set<Project>().Include(p => p.Controllers).FirstOrDefaultAsync(p => p.Id == pid);

and in execution process it generates two select in form of sql:
SELECT TOP(1) [p].[Id], [p].[AppKey], [p].[CreateDate], [p].[Name], [p].[Title]
FROM [Project] AS [p]
WHERE [p].[Id] = @__pid_0
ORDER BY [p].[Id]

SELECT [p.Controllers].[Id], [p.Controllers].[CommandTimeout], [p.Controllers].[ContentType], [p.Controllers].[CreateDate], [p.Controllers].[IsActive], [p.Controllers].[IsJsonSerialize], [p.Controllers].[IsTested], [p.Controllers].[Method], [p.Controllers].[Name], [p.Controllers].[ProjectId], [p.Controllers].[Query], [p.Controllers].[Title]
FROM [Controller] AS [p.Controllers]
INNER JOIN (
    SELECT TOP(1) [p0].[Id]
    FROM [Project] AS [p0]
    WHERE [p0].[Id] = @__pid_0
    ORDER BY [p0].[Id]
) AS [t] ON [p.Controllers].[ProjectId] = [t].[Id]
ORDER BY [t].[Id]

The question is why two independent SQL commands are being generated while the first one could be skipped?? is there any reason behind that? for me, it seems like a bug!
You can find the same question here also, One person commented that

It's not a bug, but EF Core design decision. Instead of doing single monster union query, they do one query per each collection. It's debatable which approach is better - EF6 uses the former, EF Core - the later. As of why - only EF Core team members can answer that.

What if there are no controllers for a project? You would get no project results (something that could be overcome by left joining controllers into projects). What if there are multiple controllers? Each record would then bring in a copy of the same project. Either case has its up and downs. Also check this post: https://stackoverflow.com/questions/34724196/entity-framework-code-is-slow-when-using-include-many-times/34732579#34732579

Duplicate of #12098

Especially I would suggest reading this comment https://github.com/aspnet/EntityFrameworkCore/issues/12098#issuecomment-391095895 which elaborates in detail why EF Core is using split query instead of one large query like EF 6.
As @kbekkenutte said, either case has its up and downs and it is entirely dependent on the cardinality of one to many relationship. (More projects each Controller have better the performance with split queries).

there are 2 independent queries which means the second query does nothing with the first query, so still I don't understand how running 2 queries prevents data duplication!


Adding informatory text

Related Issuse
Adding informatory text at the top of some sections
Closes: #150
Describe the changes you've made
https://user-images.githubusercontent.com/55352601/119692598-282fd900-be69-11eb-8fcc-0acb1861eb90.mp4
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot

this message will show only when user make get request at login.html it will not affect other error / success msg

https://user-images.githubusercontent.com/55352601/119693293-c58b0d00-be69-11eb-9d19-ff1c8b6b8122.mp4

@khannakshat7 kindly review this PR


Release v0.7.0

@Urigo Do we want to publish a new version with only AoT or we wait for NativeScript support or UMD bundle with tree-shaking support?

yes, before


Add option with address in SDRUC to sync options?

Description
Add option with address in SDRUC to sync options, because they will not be included with the unlockableByAddress filter anymore
Motivation
Still have a way to sync such outputs
Open questions (optional)
Do we/Firefly really need it? For the wallet itself it's not required, AFAIK Firefly only wanted it to improve the UX because they then can show where the funds are and coming from (to differentiate between amounts they get because of a storage deposit return or a normal transfer).
Are you planning to do it yourself in a pull request?
No.

We decided not to add it at the moment because it is not necessary for the wallet to work in any way. If later someone has good reasons to have the outputs anyway, it can be reconsidered.


AltGr not working in integrated terminal (french keyboard)

VSCode Version: 1.2.0-insider (https://github.com/Microsoft/vscode/commit/7ccb21d7)
OS Version: Windows 10 14342

When I try to write the backward slash ("") in the integrated terminal using a french keyboard (AltGr-8), I get "8" instead of "". However, Ctrl-Alt-8 works.
This also happens for all AltGr combinations.

I believe this will be solved with the same fix as https://github.com/Microsoft/vscode/issues/7045

Yes, it works!

@andresiraola good to hear, I haven't actually done the fix yet. I was testing this last night and could not reproduce even on older versions so I'm not sure what is going on. AltGr seemed to function just fine :confused:

I was testing on Ubuntu so I was thinking maybe it's Windows only, now I'm kinda confused.

It's been fixed in the insider build for some time now.  I only tested it on Windows.
When the may release came out, it wasn't working and I opened this issue. A week later (or so), I switched to the insider build and I noticed it had been fixed so I thought that somebody had taken care of it.
So .. perhaps somebody fixed another issue that was somehow related to this. :)

Great, one less thing to worry about :smiley:


Could not fully ban all SHA256 usage in TLS

For this test command:
#openssl ciphers -v 'HIGH:!SHA256:!DH:!DSS:!ECDSA:!CAMELLIA:!3DES:!SHA' | grep SHA256

TLS_CHACHA20_POLY1305_SHA256 TLSv1.3 Kx=any      Au=any  Enc=CHACHA20/POLY1305(256) Mac=AEAD
TLS_AES_128_GCM_SHA256  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(128) Mac=AEAD
ECDHE-RSA-AES128-GCM-SHA256 TLSv1.2 Kx=ECDH     Au=RSA  Enc=AESGCM(128) Mac=AEAD
ECDHE-ARIA128-GCM-SHA256 TLSv1.2 Kx=ECDH     Au=RSA  Enc=ARIAGCM(128) Mac=AEAD
RSA-PSK-AES128-GCM-SHA256 TLSv1.2 Kx=RSAPSK   Au=RSA  Enc=AESGCM(128) Mac=AEAD
DHE-PSK-AES128-GCM-SHA256 TLSv1.2 Kx=DHEPSK   Au=PSK  Enc=AESGCM(128) Mac=AEAD
RSA-PSK-ARIA128-GCM-SHA256 TLSv1.2 Kx=RSAPSK   Au=RSA  Enc=ARIAGCM(128) Mac=AEAD
DHE-PSK-ARIA128-GCM-SHA256 TLSv1.2 Kx=DHEPSK   Au=PSK  Enc=ARIAGCM(128) Mac=AEAD
AES128-GCM-SHA256       TLSv1.2 Kx=RSA      Au=RSA  Enc=AESGCM(128) Mac=AEAD
ARIA128-GCM-SHA256      TLSv1.2 Kx=RSA      Au=RSA  Enc=ARIAGCM(128) Mac=AEAD
PSK-AES128-GCM-SHA256   TLSv1.2 Kx=PSK      Au=PSK  Enc=AESGCM(128) Mac=AEAD
PSK-ARIA128-GCM-SHA256  TLSv1.2 Kx=PSK      Au=PSK  Enc=ARIAGCM(128) Mac=AEAD

We still could see some SHA256 cipher suits available, should all the cipher suits with SHA256 be banned when it is disabled in the cipher list?

SHA256 only matches ciphers that use HMAC-SHA256 as the MAC, which is the legacy CBC-mode ciphers. It doesn't match the ciphers that only use SHA256 as the PRF function.

I understand that, but if I want to fully banned the SHA256 even in PRF part, could it be done?

This is arguably a bug in the implementation of the SHA256 cipher group. However changing it to include ciphersuites that use SHA256 in the PRF function could be considered a breaking change. Alternatively we could treat this as a documentation bug.

Marking as inactive, to be closed at the end of 3.4 dev barring further input


Reapply "feat(vault): Migrate smp secrets to vault (#30229)" (#30751)

This reverts commit 4f5aa29f905df537122eff839a49531128fbd07e.

What does this PR do?
Re-apply the smp vault migration with a change in the api_url name saved in the vault.
Motivation
ACIX-444
#incident-32112
Describe how to test/QA your changes
The SMP job looks fine
Possible Drawbacks / Trade-offs
Additional Notes

/merge


crash on negative page index

when using a negative page index khoji will crash
How to reproduce:
make GET request on api/v1/identities/-1
error
2022/03/22 00:13:21 Failed to get identities info from DB: rethinkdb: Cannot use a negative left index on a stream. in:
r.DB("vrsctest").Table("identities").OrderBy("blockheight").Slice(-10, 0)
panic: Failed to get identities info from DB: rethinkdb: Cannot use a negative left index on a stream. in:
r.DB("vrsctest").Table("identities").OrderBy("blockheight").Slice(-10, 0)

goroutine 11 [running]:
log.Panicf({0x92c446?, 0x5?}, {0xc0000d17e0?, 0x0?, 0x0?})
        /usr/lib/go-1.18/src/log/log.go:392 +0x67
github.com/Meshbits/khoji/http.getIdentitiesSlice(0xc000284000)
        /root/khoji/http/http_routes.go:314 +0x4f8
github.com/Meshbits/khoji/http.setResponseHeader.func1(0xc000284000)
        /root/khoji/http/http_routes.go:58 +0x5b
github.com/fasthttp/router.(*Router).Handler(0xc00012bc70, 0xc000284000)
        /root/go/pkg/mod/github.com/fasthttp/router@v1.4.6/router.go:414 +0x46a
github.com/valyala/fasthttp.(*Server).serveConn(0xc0000e0fc0, {0x9e47d8?, 0xc000010430})
        /root/go/pkg/mod/github.com/valyala/fasthttp@v1.33.0/server.go:2328 +0x12c8
github.com/valyala/fasthttp.(*workerPool).workerFunc(0xc0000bd2c0, 0xc000062960)
        /root/go/pkg/mod/github.com/valyala/fasthttp@v1.33.0/workerpool.go:223 +0xa9
github.com/valyala/fasthttp.(*workerPool).getCh.func1()
        /root/go/pkg/mod/github.com/valyala/fasthttp@v1.33.0/workerpool.go:195 +0x38
created by github.com/valyala/fasthttp.(*workerPool).getCh
        /root/go/pkg/mod/github.com/valyala/fasthttp@v1.33.0/workerpool.go:194 +0x1b0

thanks for reporting 👍
will fix it soon

@devdudeio pushed fix


Assure conservation for SSP scheme

This PR corrects the implementation of the SSPRK33 method. It mimics the implementation of OrdinaryDiffEq.jl to guarantee conservation.
Before, the convex combination of the third stage of SSP33 looked like:
@. integrator.u = 1/3 * integrator.r0 + 2/3 * integrator.u
This led to problems with conservation in machine precision. The errors in conservation grow slightly over time:

Now, with using @. integrator.u = (1 * integrator.r0 + 2 * integrator.u) / 3 the errors level off.

These are results of a blast wave simulation with 64x64 elements using positivity subcell limiting for density.

I can't believe that it was this, that this was the straw that broke the camel's back 😱 Great catch!

Yes, I felt the same way. Thanks to you for sending me the working code (even I checked it before). It animated me again to just copy their complete code.

One thing I forgot to say: What's missing in the code right now is a comment explaining why you did have to implement it the way you did, with a reference to this PR. You can either do it here (if the PR hasn't automerged by then), or in any of your subsequent PRs.


Method Zanzara::onMessage() do not work right for me

Zanzara::onMessage() work only for system messages (user added to chat/ user deleted out of chat) and for commands (messages that starts with "/")
If it's not a system message and if a message doesn't start with "/", the method doesn't work.

BotFather's private settings


add 3rd tutorial: Simulating back propagating action potential in a dendritic tree

Changes

TUTORIAL: Adds the 3rd tutorial showcasing how bluecellulab can be used in simulating back propagating action potentials
FIX: Cell set a default value for rng_settings, not None
This bug was occuring when instantiating Cell without SSim and applying a rng required stimulus to that cell. Now it is fixed by providing a default rng_settings  value instead of None.
FIX: update default parameter in SectionDistance to prevent type errors such as TypeError: unsupported operand type(s) for *: 'float' and 'NoneType
DOC: add Noise and Hyperpolarizing annotations in injector to clarify that not any stimulus but only the stimuli of type Noise or Hyperpolarizing are required in relevant places

Tutorial link:
https://github.com/BlueBrain/BlueCelluLab/blob/f1a3aba7d236a492e60b5e999df208f8df0f4c37/examples/3-bpap/bpap.ipynb

Codecov Report

Merging #61 (f1a3aba) into main (3b1fd4d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   80.62%   80.63%   +0.01%
==========================================
  Files          73       73
  Lines        4970     4973       +3
==========================================
+ Hits         4007     4010       +3
  Misses        963      963

Files Changed
Coverage Δ

bluecellulab/cell/core.py
65.53% <100.00%> (+0.21%)
:arrow_up:

bluecellulab/cell/injector.py
95.21% <100.00%> (ø)

bluecellulab/cell/section_distance.py
100.00% <100.00%> (ø)


Version 1.3.3 release

Pre-release

[x] Check that all plugin files in dist/bin/ are up to date
[x] Create release branch (version-X.Y.Z)
[x] Apply and push version changes
[x] Run all the tests
[x] Tag the release

Distribution

[x] Build the release ZIP
[x] Copy the ZIP to the server
[x] Update ceylon/ceylon-debian-repo
[x] Build DEB package
[x] Copy DEB to the server
[x] Create APT repo
[x] Copy APT repo to the server
[x] Update ceylon/ceylon-rpm-repo
[x] Build RPM package
[x] Copy RPM to the server
[x] Create YUM repo
[x] Copy YUM repo to the server

Docker

[x] Update the ceylon/ceylon images
[x] Update the ceylon/source-runner images
[x] Update the ceylon/s2i-ceylon images

The Herd

[x] Upload Ceylon to the Herd
[x] Upload the SDK to the Herd
[x] Publish the Herd upload

IDEs

[x] Update ceylon-ide-common
[x] Build ceylon-ide-common
[x] Update ceylon.formatter
[x] Build ceylon.formatter
[x] Update ceylon.tool.converter.java2ceylon
[x] Build ceylon.tool.converter.java2ceylon
[x] Update ceylon-ide-eclipse
[x] Build ceylon-ide-eclipse
[x] Deploy ceylon-ide-eclipse to DEV
[x] Build ceylon-ide-eclipse to PROD
[x] Update ceylon-ide-intellij
[x] Build ceylon-ide-intellij
[ ] Deploy ceylon-ide-intellij

OSGi repos

[x] Deploy distribution OSGi repo
[x] Deploy SDK OSGi repo

Website

[x] Update the website
[ ] Remember to update spec including ePub (using pandoc)
[x] Write blog
[x] Publish the website

GitHub Release Notes

[ ] Created Release Notes

Brew formula

[x] Update Brew formula
[x] Made Pull Request
[ ] Brew formula accepted

SDKMAN

[x] Update the SDKMAN candidate
[x] Announce the SDKMAN candidate

ArchLinux

[x] Ask Alex Szczuczko for a package
[ ] Package published

Openshift

[x] Update ceylon/openshift-cartridge
[x] Update ceylon/ceylon.openshift
[x] Publish ceylon/ceylon.openshift

Ceylon Swarm

[x] Update Ceylon Swarm
[x] Publish Ceylon Swarm

Web IDE

[ ] Update the Web IDE

Maven support

[x] Maven repository
[x] Maven plugin

Release announcements

[ ] Announce on Twitter
[ ] Announce on G+
[ ] Announce on Facebook

Post-release

[ ] Change the milestone for all remaining open issues
[ ] Close the milestones on every project

I will work on the release notes.

@FroMage please check that all the binary-compatibility stuff is correctly set up for both JVM and JS, because there was some mistake made there last time around.

Well it's tested for the JVM. Who knows what the JS tests do.

Notably absent from this document are the IDE releases :(

To fix for next release:

Add instructions to upload OSGi repo
ceylon-sdk/build.properties still has 1.3.3-SNAPSHOT which fucked up the OSGi repo exported
Change OSGi versions advertised in website

Looks like the Atom feed for the blog is choking on the ampersand in the author name for the move to Eclipse:
https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fceylon-lang.org%2Fblog%2Fblog.atom

Looks like the Atom feed

Should be fixed now

Yep, looks good now! Thanks!


fix(ffe-datepicker-react):fixes #97-datepicker-click-error

fixed eventing issue where calendar with invalid date in input field would close before it could run onClick handler, making clicking on dates useless.
Makes the date stick to the last valid date if an invalid date is typed to the input field.

TODO: after removing a character from the input field, making the date invalid, clicking on the datepicker date creates a validation error, then it changes the input field. It's cosmetic, but can be improved, only problem is that the onBlur eventing is tricky to implement after the focus has been lost to the datepicker.

fixes #97

TODO: a mechanism for closing the datepicker after the events had been executed should be implemented, there is an issue with test:
343 |                 openCalendarAndBlurDateInput(wrapper);
> 344 |                 expect(wrapper.find(Calendar).exists()).toBe(false);

Please run your changes through prettier to ensure consistent formatting.
Also, would be great to see some tests that verify the behavior you're trying to fix!

@selbekk prettiefied and added tests.
Changed the order of elements to change the clicking area while the error message is displayed. Focus switching between input field and calendar should be now be correct when error pops up as well as when the input field is changed multiple times.
Open for suggestions about renaming or re-factoring, the element behaviour seems to be good though.

Looks good to me @ksawerysb1 👍 Thanks!


use delta

Seems fine, better to use real delta instead of a fixed value if you want to rotate smoothly. Thanks!


Error : Cannot setup 2 different CrossHairTool at the same time

Hello, I was trying to setup 2 Crosshair on different viewports but when I try to activate both at the same time I got the following error :

However, when I try to activate only one of them, it works perfectly.
Knowing that I have 2 rows of 3 viewports with an unique RenderingEngineID, viewportIDs and toolgroupID for each row. Both aren't linked.
You can run a simple build here : https://github.com/Pixilib/Dat_Scan_Viewer/tree/crosshairs-sync-minimal
You only need to install cornerstone's packages and to do :
->  cd datscan
-> npm start
And then you can drag and drop the files to load the viewer.

Update : we succed to sync crosshair by displaying the two studies in the same rendering engine.
However it might still be a bug that we can set 2 cross hair on 2 rendering engine (they should not see each other, isn't it ? )

Crosshairs require a full revamp which is on my todo list


Inaccuracy in the README?

The README states "The problem is that one cannot write an observation equation for 2D feature observations in image space for a localization kalman filter." Maybe I'm interpreting it wrong, but it's actually very common for observation functions to take the state to a lower dimension. For example a filter for estimating position and velocity may only take positions as measurements.

Here is a video of my tracking algorithm which jointly estimates 6dof pose of april tags + camera locations which uses the pixel detections as features.
https://drive.google.com/file/d/18C2Fomho4vIGgm2tEyjRmiZRj2ePxtm1/view?usp=sharing

I understand your confusion, I will think about rewording it.
It is true that you can write an observation function for a lower dimensionality than the state. In this case the problem is that the 2D feature observation depends on both the position of the camera and the position of the feature. For the observation to be correct both those would have to be in the state, since both are unknowns. This is a possible solution, but not very practical as the state would need to be large enough to contain the positions of all features being tracked and the features need to be constantly replaced when new features come into view.
MSCKF provides an alternative that does not require the feature positions to be in the state. https://www-users.cs.umn.edu/~stergios/papers/ICRA07-MSCKF.pdf

Oh interesting paper, thanks for the reference. Instead of incorporating the measurements into the state, the feature observations are projected onto a subspace where errors in the feature positions will lead to no changes in the residual.


Webpack Support

Still a work in progress, looking for input.

Adds support for webpack, replacing entire gulp stack.
Run the samples with npm start
Supports ES6

Coverage remained the same at 86.154% when pulling 795ebb66b4754543c5e62ad767be71cab134d454 on d/webpack into fdd14f71582460fbc06c40e4b941495cd186e084 on master.

Coverage remained the same at 86.154% when pulling 1bd15435765dab6063b38b62375466e5b4f96507 on d/webpack into fdd14f71582460fbc06c40e4b941495cd186e084 on master.

Coverage remained the same at 86.154% when pulling 4ffc6baebb9d993bb6c8efb902a22b52686649e0 on d/webpack into fdd14f71582460fbc06c40e4b941495cd186e084 on master.

Coverage decreased (-78.5%) to 7.692% when pulling 0b02b3c5ea7497079171f16fb594b68efd917189 on d/webpack into fdd14f71582460fbc06c40e4b941495cd186e084 on master.

Coverage remained the same at 86.154% when pulling a54e0ba333088590b5fc50a2f88e0fb7f6dec869 on d/webpack into fdd14f71582460fbc06c40e4b941495cd186e084 on master.


docs: fix inconsistent comments for download

New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[x] I have added the required tests to prove the fix/feature I am adding
[x] I have updated the documentation (if necessary)
[x] I have run the tests and they pass

This merge request fixes / refers to the following issues: #856 . The assertion in the code is now consistent with the comments thus the docs for download API.
Details: param savePath takes either a String or String Function(Headers) but not String Function(HttpHeaders).

Thanks, I have already fixed it.


Tool to create SDM files

Hi
The Statistical registration needs a binary SDM file in order to work. Given that, I think it would be good to add the tool that creates such files from mirtk::Matrix and mirtk::Vector files. I also have MATLAB scripts that create such mirtk::Matrix and mirtk::Vector files from MATLAB matrices and vectors (although some updating might be necessary to work with the new MIRTK), but I do not really know where to put them.

Before even looking into more details into this PR, can you reset your changes create a new commit that does not add all those build tree files such as those in the CMakeFiles directory and CMake/Config files ? See last commit 3399c8d. I suggest you use a separate build directory to avoid such mistake.
Would also be nice not to have all those merge commits if anyhow possible. See git rebase command or git pull with rebase/fast-forward.

Please consider rebasing. Just checkout your feature branch and run a git rebase develop and fix potential conflicts. Then (force) push to your remote and this PR should be automatically updated.

Further, regarding the create-sdm tool itself, I think this should be part of init-dof rather. For a statistical FFD, it would take a trained mean vector and covariance matrix as input and write a corresponding statistical FFD .dof[.gz] file with zero coefficient vector. No need for yet another command.

Please note that Applications directory changes of PR #168 which require rebasing your branch and resolving the conflicts.

Since the requested changes to this PR are way beyond its initial intended scope, I opted to close it. Will create another branch in my repository and create a new PR with the changes in the future.

Thanks for clarifying, though I thought already that's why. When you get back to this, it is probably a good idea to discuss the specifics how to incorporate the statistical registration tools best in the current set of tools in the thread of the original feature request issue #66.


fix(ffe-icons): fixed color bug on pose-trettien icon

Coverage remained the same at 81.719% when pulling 209eacd00003106e3ce4dee339677d3d9d35819d on bugfix/pose-trettien-ikon into d12342d68182ec28650bfbdd047bbb876b31a0fa on develop.


Registration calls from generic type result in compile-time error

public static void RegisterService<TConcrete>()
{
    SplatRegistrations.Register<TConcrete>();
}

The above method results in a SPLATDI001 error (TConcrete has more than one constructor and one hasn't been marked with DependencyInjectionConstructorAttribute) that is not related to the type being used. The error appears even if the method is not called.

The scenario won't work. It can definitely have a better error message though
The splat registrations calls need concrete types not generics due to the way source generators work
So calling within another generic method is unsupported


Switch, checkbox and radio theme data are not encoded and/or decoded properly

Encoding Issue
The encoder doesn't seem to encode any of the SwitchThemeData, CheckboxThemeData and RadioThemeData. For example encoding the following ThemeData doesn't output these theme data in the json:
final color = MaterialStateProperty.resolveWith((states) {
  if (states.contains(MaterialState.selected)) {
    return Colors.red;
  }
  if (states.contains(MaterialState.disabled)) {
    return Colors.green;
  }
  return Colors.blue;
});

ThemeEncoder.encodeThemeData(
  ThemeData(
      switchTheme: SwitchThemeData(thumbColor: color),
      checkboxTheme: CheckboxThemeData(checkColor: color),
      radioTheme: RadioThemeData(fillColor: color),
  ),
);

There's also no specific encode methods for these themes, e.g. ThemeEncoder.encodeSwitchThemeData, so I’m guessing the encoder for these themes are missing?
Decoding Issue
The decoder for SwitchThemeData doesn't seem to work. If I decode the following json, it will throw an exception.
Decoder code
final theme = ThemeDecoder.decodeSwitchThemeData({
  "thumbColor": {
    "disabled": "#ff9e9e9e",
    "dragged": "#fff44336",
    "empty": "#fff44336",
    "error": "#fff44336",
    "focused": "#fff44336",
    "hovered": "#fff44336",
    "pressed": "#fff44336",
    "selected": "#ff2196f3"
  }
});

Exception
The following _Exception was thrown:
Exception: Value:
{"thumbColor":{"disabled":"#ff9e9e9e","dragged":"#fff44336","empty":"#fff44336","error":"#fff44336","focused":"#fff44336","hovered":"#fff44336","pressed":"#fff44336","selected":"#ff2196f3"}}

Schema Error:
https://peiffer-innovations.github.io/flutter_json_schemas/schemas/json_theme/switch_theme_data.json
 * [https://peiffer-innovations.github.io/flutter_json_schemas/schemas/json_theme/color.json/]:
type: wanted [string] got {disabled: #ff9e9e9e, dragged: #fff44336, empty: #fff44336, error:
#fff44336, focused: #fff44336, hovered: #fff44336, pressed: #fff44336, selected: #ff2196f3}

Thanks for the detailed report.  This is fixed with version 3.2.3+1.
I'm going to go ahead and close the issue.  Feel free to re-open it or to open a separate issue if you still have problems.


Getting GRAPHQL_PARSE_FAILED  when object key has a dash

It doesn't seem to support dashes, do you know how to fix this?
For example: { myKey: true, my-key: false } (ERROR on my-key)
I get a 400 Bad Request and GRAPHQL_PARSE_FAILED:
{"errors":[{"message":"Syntax Error: Invalid number, expected digit but got: \"w\".","locations":[{"line":1,"column":260}],"extensions":{"code":"GRAPHQL_PARSE_FAILED"}}]}

I'm using apollo-server-micro.

Right, that's just not valid GraphQL. You can use a variable if you need to pass in such a value.

Thanks, using variables worked.


Virtualized ComboBox miscalculates height of options

Describe the bug (actual behavior)
The bottom of the options list shows a gap below the last option when using a virtualized combobox where the second option has a sublabel and a sufficient number of options without sublabels.
Expected behavior
The bottom of the options list stops at the last option.
Reproduction
Link to a minimal repro: https://codesandbox.io/s/gracious-pond-ur3c5g?file=/src/App.tsx
Steps to reproduce

Open the combobox
Observe gap below the last option

Additional information
This occurs in both scrollable and unscrollable option lists.
It appears the gap is the result of the scrollable distance being calculated as if every option has a sublabel, accumulating all the height differences from all options without sublabels at the bottom.
Testing seems to suggest this only occurs when the second option has a sublabel.

Comment for developer who takes this issue:
Height calculations are done in VirtualScroll.tsx line 421. This function assumes that all middle children heights are the same.

This issue has been finally fixed in 3.13.0 🚀


js: Convert _.each to for…of

The sequel to #13830.
Things we need to watch out for are that _.each accepted plain JS objects (iterating over its properties) and undefined (doing nothing), while for…of does not.

The first 10 commits manually convert uses of _.each on plain JS objects to use Object.entries and Object.values. This should be equivalent to what _.each does: it iterates over _.keys which delegates to Object.keys.
The next 2 commits convert some not-quite-arrays (sub_row_data, arguments) to arrays.
The next commit makes a _.each entirely unnecessary with Object.assign.
The next 3 commits convert some undefined values to [], mostly in test suite mocks.
The next 2 commits bring check-openapi into linter compliance (so we can lint --fix it in the final commit).
The final commit is the automated conversion. See its commit message for the script. It’s pretty large and probably wants some burn-in time on CZO before going to master.

Testing Plan: test-js-with-node --coverage (every commit), test-js-with-casper, lint -g frontend (every commit), run-dev.
Cc @showell

LGTM.

small note--I am cherrypicking the presence commit on to my presence branch, since I'm about to clean up some of the complicated loop-through-clients logic there.

This is great, merged, thanks @andersk!
We only have a handful of loops that are performance-sensitive in handling 10Ks of elements of data.  I think it probably makes sense to do some profiling now that this is integrated of cases like "loading the app with 50K unread messages" and "10K users of presence data" to make sure that we haven't created something that dominates the performance of that sort of operation that could be fixed by using whatever the fastest way to write a basic loop is in JavaScript.
(Since I'm guessing for..of doesn't end up being that after being transpiled).

Just wanted to say that I appreciate the rewrite script in that final commit, and enjoyed reading it. Thanks for doing this migration!


"Duplicate export 'default'" when only module.exports.default is defined

Not very familiar with JS tooling so apologies if this is obvious. I think I'm still seeing a variant of #158.
Test case:
// test/function/duplicate-default-exports-only-default/x.js

module.exports.default = 42;

// test/function/duplicate-default-exports-only-default/main.js

import x from './x';

$ yarn test
[...]
  61 passing (537ms)
  1 failing

  1) rollup-plugin-commonjs function duplicate-default-exports-only-default:
     Error: Duplicate export 'default'
      at error (node_modules/rollup/src/utils/error.js:2:14)
      at Module.error$1 [as error] (node_modules/rollup/src/Module.js:303:2)
      at tryParse (node_modules/rollup/src/Module.js:27:10)
      at new Module (node_modules/rollup/src/Module.js:53:15)
      at node_modules/rollup/src/Bundle.js:301:20
      at <anonymous>
[...]

In the wild: cheerio 1.0.0-rc.2 at lib/options.js

I'm having this issue as well. Did you find any solution?

No, I didn't pursue this any further; just opted not to use Rollup for this project.

Any update for this? that is very common error when using rollup, with this issue, and cannot be resolved?

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer:


What can I do with the hash returned by put

At the documentation there's the following:
const hash = await db.put({ _id: 'QmAwesomeIpfsHash', name: 'shamb0t', followers: 500 })

So a hash is returned when I insert a new document, let's say if I want to find the inserted documented by its hash how could I do it? When I try to find it using cat nothing is returned.
I want that to store that hash on ethereum and be able to access it
Thanks is advance.

Hi @marciok. I'm not sure of the timing, but we'v e recently switched to IPLD so if you try the ipfs.dag.get command, you might have better luck.

@aphelionz Thanks for the reply, I'll try later..
Best


#1087 Sort order

Reused the template and the css kindly provided from @kruchy8  (thanks)
Configure the attributes to sort with:
    "sortByAttributes": [
      "updated_at",
      "price"
    ]

Ouch! :D just added


Release 0.12.1

I'm cutting this release in order to get out the non-breaking changes that have been merged, before making PRs for breaking changes to the Field trait.


Bankai sheetify transform

I tried using a transform with sheetify, but I think the documentation on how to configure them is wrong. The following gist does not load sheetify-nested, and checking the options.use property in sheetify reveals that it is indeed empty.
https://gist.github.com/emilbayes/5e7519883dd1212f69c60c5afb815fdc
I'm happy to help, but I'm not sure where this should be set. Merged with .use here? https://github.com/stackcss/sheetify/blob/2b5722aa7d77b8cb78644177d6308c848cc27991/index.js#L85

maybe it should be a goal to incorporate module-deps into sheetify so all this stuff is the same as browserify (I say this barely knowing anything about sheetify internals)

This sounds like a good idea

@emilbayes we use style-deps to do the same thing as module-deps does, but being able to track .css files and the .style key in package.json — I'm not sure what's going wrong right now, but any fix would be much appreciated!

@emilbayes ping; any updates on this? If not, can we close?

Using nested css breaks my app unless I modify the sheetify module like so:
function applyTransforms (filename, src, options, done) { options.use = 'sheetify-nested'
Here's what I think should work in package.json but doesn't:
"sheetify": {
"transform": [
"sheetify-nested"
]
},

I think sheetify still uses the use terminology atm. there is a PR https://github.com/stackcss/sheetify/pull/135 to switch to transform.
does doing
"sheetify": {
  "use": ["sheetify-nested"]
}

work as expected?

Still breaks with "use".

Think this is fixed in recent sheetify versions; please reopen if not. Thanks!


[ci] Move CW305 bitstream build to machine without license

The CW305 uses an Artix-7 FPGA which does not require an enterprise Vivado license to synthesise for. We limit the number of machines on the -bitstream label to match our number of licenses, however CW305s are taking up these spots unnecessarily.
This commit moves them to the -vivado machines which have access to Vivado Standard edition only.

Ah, thanks for the clarification


Support for record type

Hi,
Does the library support option to read EBCDIC data based on record type instead of copy book option?

I'm not sure I understand the question. Could you elaborate on it please?

Sure. Here i mean is ability to record mainframe file without cobol copybook but based on record type. Means my ebcdic file has multiple record layouts but need to read specific fields based on record layout. For example.
IF RECTYPE = '01' THEN DO;
INPUT @ 349       D                                 $1.
@ 121       X                            $1.
@   7       V                                $1.
@   8       EE                                PD4.

Cobrix doesn't support this, but you can workaround maybe by creating a synthetic copybook:
01 RECORD.
  02 RECTYPE PIC X(2).
  02 D   PIC 9(4)V9.
  02 X   PIC X(5) REDEFINES D.

and use RECTYPE as a segment and redefine_segment_id_map to map values depending on the value in the first field.
Hope this is of some help. I've never encountered a use case like this so not sure if the workaround it even close to the solution that you need.


fix(kvm): error message for user consent less alarming

closed #362

Codecov Report

Merging #363 (ee0ffaa) into master (a81c99b) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   55.45%   55.14%   -0.31%
==========================================
  Files          39       39
  Lines         972      972
  Branches       92       92
==========================================
- Hits          539      536       -3
- Misses        399      401       +2
- Partials       34       35       +1

Impacted Files
Coverage Δ

src/app/authorize.interceptor.ts
14.28% <0.00%> (ø)

src/app/devices/kvm/kvm.component.ts
61.76% <0.00%> (ø)

src/app/shared/config/snackBarDefault.ts
100.00% <ø> (ø)

src/app/shared/add-device/add-device.component.ts
86.36% <0.00%> (-6.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81c99b...ee0ffaa. Read the comment docs.


Typo causes crash.

lib/Client/InternalClient.js:1147
InternalClient::updateDetails();
if(!email) used instead of if(!this.email) for checking if token was used.

https://github.com/hydrabolt/discord.js/blob/indev/src/Client/InternalClient.js#L1006
Already fixed in indev: 8d59498

Duplicate of 8d59498 #176 #187 #203 #207
Yes, NPM/master don't have this patch released yet. However, that still doesn't mean it isn't already fixed in development (indev branch).

Apologies.


MSID: 102900 Version: 1 DOI: 10.1101/2<IP_ADDRESS>3629

MSID: 102900
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3629
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=102900
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3629

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/102900v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3629
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/102900/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Reviews have been posted to the v1, but should be on the v2. Moving over.
If the workflow doesn't automatically re-run, it'll require pinging Graham to ask if he can re-run.

(Ready to check)

asking author for biorender citation urls


lmtp_client not starting

I'm trying to start the lmtp_client.py script as shown in the documentation with
python src/lmql/models/lmtp/lmtp_client.py
However, I get an error message:
from .errors import LMTPStreamError
ImportError: attempted relative import with no known parent package
Is there something I missed when installing the package?
Greetings!

Hi there, running lmtp_client.py directly is only useful for debugging purposes. What are your trying to achieve? Are you look to just [serve a model(https://lmql.ai/docs/models/hf.html), or are you really trying to use LMTP separately from LMQL?

Hi, I'm just trying to verify my installation using the client. It seemed
to be the most simple way.
Luca Beurer-Kellner @.***> schrieb am So., 29. Okt.
2023, 11:42:

Hi there, running lmtp_client.py directly is only useful for debugging
purposes. What are your trying to achieve? Are you looking to just [serve a
model(https://lmql.ai/docs/models/hf.html), or are you really trying to
use LMTP separately from LMQL?
—
Reply to this email directly, view it on GitHub
https://github.com/eth-sri/lmql/issues/259#issuecomment-1784062345, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACO5DS4NCXOU7JEX5WHIRMDYBYQHDAVCNFSM6AAAAAA6TY677OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA3DEMZUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

I just pushed a fix for the relative import issue in https://github.com/eth-sri/lmql/commit/797a95df085647866ba689d4c88c191d76b2b6d9. Thanks again for reporting this.


Jit compilation, increase the GPU usage until exhausting the VRAM

Description
Goodafternoon, I am new to JAX framework, I have started working with it Since November. I have an issue when I JIT compiled a function within a for loop. The for-loop is composed as a nested for-loop and, when the function is executing the usage of VRAM progressively increse until, the computation stop and the process is killed.
What jax/jaxlib version are you using?
jax v0.3.25
Which accelerator(s) are you using?
No response
Additional system info
No response
NVIDIA GPU info
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 515.65.01    Driver Version: 515.65.01    CUDA Version: 11.7     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA TITAN V      Off  | 00000000:01:00.0 Off |                  N/A |
| 62%   85C    P2   232W / 250W |   9015MiB / 12288MiB |    100%      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

Hi @iacopo97
Are you still encountering this issue with the latest version 0.4.35 of JAX? If so, please share a minimal reproducible code snippet that replicates the problem to efficiently troubleshoot the issue.
Thank you.


C::Mat link back to Video Grabber

Im trying to use the C::mat for as a source for a video grabber as I want to detect objects such as ArCuo. Can this be done on the pi using the native camera??

If :

by C::mat you mean cv::Mat (OpenCV 2+ matrix image format)
by ArCuo you mean ArUco
by native camera you mean the PiCamera module (as opposed to a USB Camera)

Then the answer is yes :)
Have a look at example-ofxCvPiCamSimple
It should be possible to simply grab the frame from the ofxCvPiCam instance and pass it to ArUco:

//in update
cv::Mat frame = cam.grab();
if(!frame.empty()){
//pass the frame to ArUco here
}

Hi,
by the same logic,
would you be possible to pass an ofxAruco object using ofxCvPiCam. How do I get the pixels from ofxCvPiCam?

Hi @owenplanchart
It would be possible, but bare in my mind my basic addon fetches PiCamera data in cv::Mat format
while ofxAruco::detectBoards takes ofPixels & pixels as an argument. You can use ofxCv to easily wrap cv::Mat to ofPixels (for example using toOf(cv::Mat mat, ofPixels_<T>& pixels))
Hope this helps,
George

Thank you,
I will give this a try

Is this the right implementation?
void ofApp::update(){
    cv::Mat frame = cam.grab();
    ofPixels arPixels;
    toOf(frame, arPixels);
    if(!frame.empty()){
       aruco.detectBoards(arPixels);
    }
}

@owenplanchart That looks good !
You should test it when you get a chance.
The other thing I'd recommend is maybe holding on two the frame and arPixels references and maybe doing the the empty() check before attempting to convert toOf(), something along these lines:
// in your ofApp.h for example
cv::Mat frame;
ofPixels arPixels
// in your ofApp.cpp:
void ofApp::update(){
    frame = cam.grab();
    if(!frame.empty()){
       toOf(frame, arPixels);
       aruco.detectBoards(arPixels);
    }
}

It's really strange because now I'm getting this error when I try to compile:
obj/linuxarmv6l/Release/src/ofApp.o: file not recognized: file truncated
collect2: error: ld returned 1 exit status
make[1]: *** [/home/pi/openFrameworks/libs/openFrameworksCompiled/project/makefileCommon/compile.project.mk:405: bin/cvPiCamChand] Error 1
make[1]: Leaving directory '/home/pi/openFrameworks/apps/myApps/cvPiCamChand'
make: *** [/home/pi/openFrameworks/libs/openFrameworksCompiled/project/makefileCommon/compile.project.mk:129: Release] Error 2

@orgicus Not sure what happened there, so I re-downloaded the addon and wrote the sketch from scratch and managed to get the aruco markers working (yay!). This was on the RP3b (buster) with the Pi cam v2.1. Does this addon work with the pI4? Thanks so much for your work and help on this.


New .book file format

In order to have a hook to insert required LaTeX elements into rendered document, change the .book file format to include a marker where the \begin{document} should be emitted, allowing us to prepend other commands.
This is version 2 of the .book file format, and the major API version of the package has been bumped accordingly.
Closes #28

@lynnju Could I ask you to have a look at https://github.com/oprdyn/publish/blob/35c6316ee9c82135b35ad1378721eae7a7217062/tests/Example.book and tell me what you think? I've made the change that uses this format in this branch, but I'm not entirely convinced. Looking at it from the outside it seems all very sensible, but typing % publish v2 is a bit tedious. For example, does it really need the v2? I think yes and I think this is minimally sufficient, but maybe you'd care to comment.

@afcowie in re: format, it seems quiet reasonable. Perhaps you might infer the format from the extension if the % publish v2 is not present (for example Example.publish-v2.book or something like that), or default to the latest version if no version is specified, ala % publish? There's a lot of syntactic sugar one could add to avoid verbosity, but, when it comes down to it - I think your format is quite good as is.


SpriteFrames individual frame duration is not honored in resulting animation

Context
I need to add some lag at the beginning of my attack animation for telegraphing, but since I'm using a spritesheet made by someone else, I cannot just draw my own extra sprites, so I'm just extending the duration of the first frames.
To do this, there are three ways:
a. on the SpriteFrames, increase the Frame Duration setting of individual sprites (what we are interested in here)
b. on the SpriteFrames, add copies of the same sprites after itself
c. on the resulting AnimationPlayer animation, move the sprite keys after the sprite to extend later in the timeline
Issue
With method a., I noticed that the resulting animation still gives the same duration to every sprite frame, ignoring the Frame Duration setting.
Sprite Frames setup:

Resulting animation:

Request
When pressing Import, we should multiply the duration of a sprite frame in the resulting animation by Frame Duration.
Workaround
As a fallback, I tried method b., which works, but has two disadvantages:

There is no "Duplicate after" button so it's cumbersome to add extra copies of the same frame: you must copy-paste it but the pasted frame is added to the end of the SpriteFrames, so you must then move it left repeatedly until it reaches the same place as the original frame.
You can only multiply the total duration of the sprite by an integer number this way, equal to the number of identical sprites. Whereas Frame Duration allows fractions like x2.5.

As a second fallback, I tried method c., which works, but next time I press the Import button, it will replace my adjusted animation and all sprites will revert to having the same duration. Plus, the old "don't replace" mode from Godot 3 version has been removed, so I don't have a way to prevent overwriting my custom changes while still adding new animations (it would be useful to combine the old and new behavior with a hybrid mode "don't replace existing tracks" for these situations; but that would be the topic of another issue for proposal).

Ah, thanks for the notice. I haven't been using AnimatedSprite recently, so I didn't know about the frame duration setting. I'm a bit busy at the moment so I'll have to take a look into it later, a PR would be welcomed in the meantime.
I also like the idea for the hybrid "don't replace existing tracks". The main reason I removed the option was that initially it was meant to prevent none sprite-related tracks from being replaced. I hadn't thought about the use case where we wouldn't want the sprite tracks themselves from being replaced, so an option might be needed.

OK, I need this today so I'll try some PR.


JSON API for queries

It would be interesting to have a REST JSON API for the queries (using these concepts). It could list the queries when going on /query/, then a description of the query ABC on /query/ABC (the arguments, results, etc.), then another url (which one?) for running the query

see http://buda1.bdrc.io/queries for a json list of the query templates
and (for instance)
see http://buda1.bdrc.io/queries/Topic_byAllNames.arq  for a json description of the templates, including the demo link
Note the actual usage of the query template using GET/POST/POST JSON is already implemented in the main query template service. Ex:
http://buda1.bdrc.io/resource/templates?searchType=Topic_byAllNames&L_NAME=rgyud (GET)
curl --data "searchType=Res_byName&L_NAME=("mkhan chen" AND ("'od zer" OR "ye shes"))&LG_NAME=bo-x-ewts&I_LIM=100" http://localhost:8080/resource/templates (POST)
curl -H "Content-Type: application/json" -X POST -d @test.json http://localhost:8080/resource/templates (POST JSON)

(as a general observation, it tends to be perceived as rude to close an item opened by someone else, the usual protocol is to ask the person who opened the issue if it's ok to be closed)
Looks good! A few remarks:

instead of name, maybe id could be used? Also, maybe it could include the public/ part?
the .arq part of the name/id is not used consistently and should never appear (I think)
the different return variables and their meaning should be described (in your example it should be clear that it gives 1 column, named "?ID" which is the ID of the resource and which is a url
queryParams should make clear that there are in fact two params, L_NAME and LT_NAME
what is the point of the queryString field? It seems quite gratuitous...

I think it's all done now (since commit 23bd0f1)

Ok, I'll open a separate issue for the remaining issues


fix(cherow): fixes escaped yield & await identifiers

@fkleuver Any thoughts?

Coverage decreased (-0.01%) to 90.552% when pulling e5a9079923c0a0e825f600174a1d071f87a0bb21 on tweaks into 2f4d5565bd5f74328bb150cc1ea9912bda464f8c on master.

Coverage decreased (-0.01%) to 90.552% when pulling e5a9079923c0a0e825f600174a1d071f87a0bb21 on tweaks into 2f4d5565bd5f74328bb150cc1ea9912bda464f8c on master.

This PR should be a bug fix, so I changed the commit message.

Merging this because I added a few other things. This can be fixed later if needed.


Added COOL New Badges for ReadMe

CHANGELOG :memo:

Added badges to the readme file with colors based on the purpose of the badge.

PRINTS(OPTIONAL) :framed_picture:
LABELS

Example: enhancement, wip etc

Hello @dalegacusan
Thank you for your contribuition!
As I say in this request, this infos are easier finded in the project, therefore, I think it's not necessary to have badges for this kind of information.
I'll close your request, but you can open another if you have another way to collaborate in this issue or feel free to find another challenge here


Error when calling the GetLedger client method

Version: 3.0.2202
Description: The GetLedger client method throws an error when trying to return data from the Bitpay API.
When calling the method, the following error is thrown :
error: LedgerQueryException {   message: "failed to deserialize BitPay server response (Ledger) : Cannot read properties of undefined (reading 'data')",   name: 'BITPAY-LEDGER-GET',   code: 132,   apiCode: '000000' }
After digging a little, it seems the Bitpay API /ledger/{currency} endpoint has a different response structure, and does not contain a 'data' property :
ledger endpoint documentation
As the RESTCli get method systematically tries to read the 'data' property, this could be why the bug happens.

Same response here
I'm not getting my ledger entries
Getting this error only
Is there any way to pass token along with it?


slack: 4.25.0 -> 4.25.1, linux only

Description of changes
Linux only release. Adding myself mostly to get pinged for future bumps.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

What do you mean by linux only here? Darwin would also receive a bump with this patch.

What do you mean by linux only here? Darwin would also receive a bump with this patch.

It didn't :woman_shrugging:
https://slack.com/release-notes/mac
https://slack.com/release-notes/linux


confuse about sampler and dataloader

Hi, thanks for sharing your nice code. But I feel confused about your sampler and the getitem function in roibatchLoader.py
for sampler in trainval_net.py:
def iter(self):
rand_num = torch.randperm(self.num_per_batch).view(-1, 1) * self.batch_size
self.rand_num = rand_num.expand(self.num_per_batch, self.batch_size) + self.range
self.rand_num_view = self.rand_num.view(-1)
I don't get the point what is the difference of the above three lines from directly use torch.randperm(train_size)
for the getitem function in roibatchLoader.py for  lines 165 and line 175:
padding_data = torch.FloatTensor(int(np.ceil(data_width / ratio)),
data_width, 3).zero_()
padding_data = torch.FloatTensor(data_height,
int(np.ceil(data_height * ratio)), 3).zero_()
It seems that, nothing change to the padding_data, because data_width / ratio=data_height and data_height * ratio = data_width, which means the padding_data has the completely same size as data.
More than that, I try to print index in the getitem function. I find that, the function is called 3*batch_size times. Take batch_size as example:
index 37198 size torch.Size([1, 600, 732, 3])
padding_datasize torch.Size([3, 600, 732])
index 37199 size torch.Size([1, 600, 732, 3])
padding_datasize torch.Size([3, 600, 732])
image index tensor([37198, 37199])
index 135064 size torch.Size([1, 600, 1095, 3])
padding_datasize torch.Size([3, 600, 1095])
index 135065 size torch.Size([1, 600, 1095, 3])
padding_datasize torch.Size([3, 600, 1095])
index 490 size torch.Size([1, 1064, 600, 3])
padding_datasize torch.Size([3, 1064, 600])
index 491 size torch.Size([1, 1064, 600, 3])
padding_datasize torch.Size([3, 1064, 600])
It shows the confusion I have said above. Could you or anyone has any idea about that? Thanks

@jwyang Hi, I have the same question. Anyone has any idea about that? Thanks


Fix compiler warning C4702 for MSVC-14

Justification
MSVC-14 shows a warning C4702 when the code is compiled.
Details on the warning: cxxopts.hpp(562) : warning C4702: unreachable code.
The unreachable line is return t; in line 562.
Implementation
To get rid of the unreachable code, now checked_negate receives by reference the value and updates it instead of returning.
Testing:

Code compiles and warning C4702 is gone.
All tests pass.

This change is

Hi, any follow-up on this PR? @jarro2783

Sorry I lost this one. It looks good to me.


Pre-processing enhancement

The pre-processing function of the tool.py file does some image segmentation to each region for Tesseract to identify the region's number. But when the input image has a grid, and fragments of this grid appears on a region, Tesseract generates an error.

This trouble forces the user to be carefoul when drawing the first rectangle and setting the offset --- it can be very upsetting.
It seems that the grid could be removed from each regions with some elementary image segmentation using OpenCV.
At the time, I can think of using a clear border function (like imclearborder in MatLab) or trying to detect the grid's lines and remove them.

I tested the clear border function idea : it turns out that Nitish9711 implemented this function for his projet, and it does a great job !

The only problem is that it does not work when the number is inside a full grid:


'black_reformat' is not defined error when formatting

Using Black 19.3b0, Jupyter notebook 5.7.8, and Python 3.7.3, I get the following error when I try to format a cell.
[jupyter-black]
 Error: NameError
name 'black_reformat' is not defined

I just had the same error message. I checked and the cause seems to be that I ran reset -f in the notebook.

black: 19.10b0
python: 3.8.2
jupyter: 1.0.0