Problems connecting to multiple PX4s in SITL

I want to write a DroneCore program to control a swarm of SITL PX4s simultaneously, through offboard mode. Right now, I'm using a swarm of 4 drones, which is a modification of the scripts here:https://dev.px4.io/en/simulation/multi-vehicle-simulation.html. I've been using the takeoff_land example program from DroneCore as a base, When I run the example program, the first drone with a sysid of 1 takes off, which is as expected. Now if I have to control all the 4 drones, I have to add the 4 UDP ports of the drones, which I did, as below.
DroneCore::ConnectionResult connection_result = dc.add_udp_connection(14540);
dc.add_udp_connection(14541);
dc.add_udp_connection(14542);
dc.add_udp_connection(14543);

Of all these, I just want to add device for one drone, for the sake of testing.
 Device &device = dc.device(1/2/3/4(mavlink sys ids));
Now here comes the problem. It seems that all the PX4 SITL drones have the same UUID, so even differentiating between the MAVLink sys id 's is useless, because DroneCore won't even consider them. So I had to comment out this part of code from device_impl.cpp, so that it forces use of sys id.
// if (_target_uuid == 0 && autopilot_version.uid != 0) {

// // This is the best case. The device has a UUID and we were able to get it.
// _target_uuid = autopilot_version.uid;

// }

Even after doing all this, I start getting the following stream of errors, when I use any sys id other than 1 to connect.
This is the error beginning
Waiting to discover device...
[06:21:42|Info ] New device on: <IP_ADDRESS>:14553 (udp_connection.cpp:211)
[06:21:42|Error] Remote IP unknown (udp_connection.cpp:140)
[06:21:42|Error] send fail (dronecore_impl.cpp:104)
[06:21:42|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Info ] New device on: <IP_ADDRESS>:14555 (udp_connection.cpp:211)
[06:21:42|Error] Remote IP unknown (udp_connection.cpp:140)
[06:21:42|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[06:21:42|Error] send fail (dronecore_impl.cpp:104)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Info ] New device on: <IP_ADDRESS>:14557 (udp_connection.cpp:211)
[06:21:42|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[06:21:42|Error] Remote IP unknown (udp_connection.cpp:140)
[06:21:42|Error] send fail (dronecore_impl.cpp:104)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Info ] New device on: <IP_ADDRESS>:14559 (udp_connection.cpp:211)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 lost (device_impl.cpp:246)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 lost (device_impl.cpp:246)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 lost (device_impl.cpp:246)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 lost (device_impl.cpp:246)
[06:21:42|Debug] MAVLink: info: data link #0 regained (device_impl.cpp:246)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 regained (device_impl.cpp:246)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 regained (device_impl.cpp:246)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] MAVLink: info: data link #0 regained (device_impl.cpp:246)
[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)

This is the error end
[06:20:22|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:20:22|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:20:22|Error] Retrying failed (511) (mavlink_commands.cpp:215)
[06:20:22|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:20:22|Error] Error: set param busy timeout: NAV_FT_RS (mavlink_parameters.cpp:413)
[06:20:22|Error] Failed to set NAV_FT_RS: 0.5 (follow_me_impl.cpp:266)
Setting rate failed:Timeout

DroneCore is able to detect the presence of other devices, but something amiss happens. What could the problem be? I've uploaded the cpp program for reference.
Keyboard_test.txt
Thanks!

@varunvp Are you using latest develop or master ?

so even differentiating between the MAVLink sys id 's is useless, because DroneCore won't even consider them.

Why ? If UUID is not available, then DroneCore uses sysid to differentiate vehicles. I'm not sure, but can you disable providing UUID?

[06:21:42|Debug] sysid: 2 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 3 (dronecore_impl.cpp:90)
[06:21:42|Debug] sysid: 4 (dronecore_impl.cpp:90)

It is receiving heartbeats from 4 vehicles, hence it is printing their sysid's. (It doesn't print the first one).

[06:21:42|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[06:20:22|Error] Error: set param busy timeout: NAV_FT_RS (mavlink_parameters.cpp:413)
[06:20:22|Error] Failed to set NAV_FT_RS: 0.5 (follow_me_impl.cpp:266)

Are you using Follow Me plugin ? It is failing to set Follow Me param. Can you take fresh master and try ? OR You can give it a try on latest develop as well.

At the time of writing, I was using the latest master branch.

Why ? If UUID is not available, then DroneCore uses sysid to differentiate vehicles. I'm not sure, but can you disable providing UUID?

I am not aware of any methods of disabling UUID. We went searching for it in the PX4 source, and found it to be '#define'd as a constant. Didn't want to mess with it.

Are you using Follow Me plugin ? It is failing to set Follow Me param. Can you take fresh master and try ? OR You can give it a try on latest develop as well.

It automatically uses the FollowMe plugin, I don't know why.
I tried taking the fresh master after I had modified that file device_impl.cpp, but even after replacing the file with the original file, and building it, it seemed as if was still using the same file with the comment active. That's why I've downloaded it fresh, and I've got to try it now.

This is what I get when I switch to develop from master(just for your information)
varun@varun-5577:~/DroneCore/DroneCore$ git checkout develop
warning: unable to rmdir curl-android-ios: Directory not empty
warning: unable to rmdir libs/gtest: Directory not empty
warning: unable to rmdir libs/include/mavlink/v2.0: Directory not empty
warning: unable to rmdir libs/tinyxml2: Directory not empty
Switched to branch 'develop'
Your branch is up-to-date with 'origin/develop'.
varun@varun-5577:~/DroneCore/DroneCore$ git submodule update --init --recursive
Submodule 'dronecore-proto' (https://github.com/dronecore/DroneCore-Proto.git) registered for path 'backend/proto'
Submodule 'tinyxml2' (https://github.com/leethomason/tinyxml2.git) registered for path 'core/third_party/tinyxml2'
Submodule 'json11' (https://github.com/dropbox/json11) registered for path 'plugins/mission/third_party/json11'
Submodule 'gtest' (https://github.com/google/googletest) registered for path 'third_party/gtest'
Submodule 'mavlink_v2' (https://github.com/mavlink/c_library_v2.git) registered for path 'third_party/mavlink/include/mavlink/v2.0'
Submodule 'zlib' (https://github.com/madler/zlib) registered for path 'third_party/zlib'
Cloning into 'backend/proto'...
remote: Counting objects: 106, done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 106 (delta 29), reused 45 (delta 24), pack-reused 54
Receiving objects: 100% (106/106), 13.66 KiB | 0 bytes/s, done.
Resolving deltas: 100% (31/31), done.
Checking connectivity... done.
Submodule path 'backend/proto': checked out '57ecd082bfc94d4b6cef7c58448091782b8e5d32'
fatal: reference is not a tree: 9dfcd9073f84bdb53064b2318db1f26801c67826
Cloning into 'core/third_party/tinyxml2'...
remote: Counting objects: 3500, done.
remote: Compressing objects: 100% (29/29), done.
remote: Total 3500 (delta 27), reused 43 (delta 25), pack-reused 3446
Receiving objects: 100% (3500/3500), 2.65 MiB | 139.00 KiB/s, done.
Resolving deltas: 100% (2260/2260), done.
Checking connectivity... done.
Submodule path 'core/third_party/tinyxml2': checked out '37bc3aca429f0164adf68c23444540b4a24b5778'
Cloning into 'plugins/mission/third_party/json11'...
remote: Counting objects: 296, done.
remote: Total 296 (delta 0), reused 0 (delta 0), pack-reused 296
Receiving objects: 100% (296/296), 82.31 KiB | 33.00 KiB/s, done.
Resolving deltas: 100% (163/163), done.
Checking connectivity... done.
Submodule path 'plugins/mission/third_party/json11': checked out 'ec4e45219af1d7cde3d58b49ed762376fccf1ace'
Cloning into 'third_party/gtest'...
remote: Counting objects: 11103, done.
remote: Compressing objects: 100% (70/70), done.
remote: Total 11103 (delta 110), reused 163 (delta 108), pack-reused 10912
Receiving objects: 100% (11103/11103), 3.48 MiB | 183.00 KiB/s, done.
Resolving deltas: 100% (8149/8149), done.
Checking connectivity... done.
Submodule path 'third_party/gtest': checked out '0fe96607d85cf3a25ac40da369db62bbee2939a5'
Cloning into 'third_party/mavlink/include/mavlink/v2.0'...
remote: Counting objects: 12233, done.
remote: Compressing objects: 100% (99/99), done.
remote: Total 12233 (delta 288), reused 276 (delta 245), pack-reused 11889
Receiving objects: 100% (12233/12233), 5.66 MiB | 326.00 KiB/s, done.
Resolving deltas: 100% (11130/11130), done.
Checking connectivity... done.
Submodule path 'third_party/mavlink/include/mavlink/v2.0': checked out '0773d299bd2ebfb59a496803606783b04372774c'
Cloning into 'third_party/zlib'...
remote: Counting objects: 5045, done.
remote: Total 5045 (delta 0), reused 0 (delta 0), pack-reused 5045
Receiving objects: 100% (5045/5045), 2.52 MiB | 59.00 KiB/s, done.
Resolving deltas: 100% (3574/3574), done.
Checking connectivity... done.
Submodule path 'third_party/zlib': checked out 'cacf7f1d4e3d44d871b605da3b647f07d718623f'
Unable to checkout '9dfcd9073f84bdb53064b2318db1f26801c67826' in submodule path 'core/third_party/curl-android-ios'

When I execute with
DroneCore::ConnectionResult connection_result = dc.add_udp_connection(14540);
...
Device &device = dc.device(2);

I get this
Waiting to discover device...
[01:07:41|Info ] New device on: <IP_ADDRESS>:14557 (udp_connection.cpp:211)
[01:07:41|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[01:07:41|Debug] MAVLink: info: data link #0 lost (device_impl.cpp:244)
[01:07:41|Debug] MAVLink: info: data link #0 regained (device_impl.cpp:244)
[01:07:41|Debug] Discovered<PHONE_NUMBER> (dronecore_impl.cpp:234)
Discovered device with UUID:<PHONE_NUMBER>
[01:07:43|Error] device with UUID: 2 not found (dronecore_impl.cpp:178)
[01:07:43|Info ] Applying default FollowMe configuration FollowMe to the device... (follow_me_impl.cpp:178)
[01:07:43|Error] Error: more than one device found: (dronecore_impl.cpp:145)
[01:07:43|Warn ] strange: 0: 0, 0x2458c00 (dronecore_impl.cpp:149)
[01:07:43|Warn ] strange: 1: 1, 0x7fbbb0000e40 (dronecore_impl.cpp:149)
[01:07:43|Error] Error: set param busy timeout: NAV_MIN_FT_HT (mavlink_parameters.cpp:413)
[01:07:43|Error] Failed to set NAV_MIN_FT_HT: 8m (follow_me_impl.cpp:227)
[01:07:43|Info ] sending again, retries to do: 3  (511). (mavlink_commands.cpp:197)
[01:07:44|Info ] sending again, retries to do: 2  (511). (mavlink_commands.cpp:197)
[01:07:44|Error] Error: set param busy timeout: NAV_FT_DST (mavlink_parameters.cpp:413)
[01:07:44|Error] Failed to set NAV_FT_DST: 8m (follow_me_impl.cpp:236)
[01:07:44|Error] Error: set param busy timeout: NAV_FT_FS (mavlink_parameters.cpp:413)
[01:07:44|Error] Failed to set NAV_FT_FS: Behind (follow_me_impl.cpp:257)
[01:07:44|Info ] sending again, retries to do: 1  (511). (mavlink_commands.cpp:197)
[01:07:45|Error] Retrying failed (511) (mavlink_commands.cpp:215)
Setting rate failed:Timeout
[01:07:45|Error] Error: set param busy timeout: NAV_FT_RS (mavlink_parameters.cpp:413)
[01:07:45|Error] Failed to set NAV_FT_RS: 0.5 (follow_me_impl.cpp:266)

After you switch to develop, you've to:
git submodule update --init --recursive
make clean
make default
sudo make default install
sudo ldconfig

Goto example and re-build.

[01:07:43|Error] device with UUID: 2 not found (dronecore_impl.cpp:178)

If UUID exists, you've to pass UUID.

@varunvp when you have troubles checking out git submodules, also do:
git submodule sync --recursive

The fact that different vehicles in SITL have the same UUID is for sure a problem but I'd say that it should be fixed on the firmware side.

The fact that different vehicles in SITL have the same UUID is for sure a problem but I'd say that it should be fixed on the firmware side.

This is the problem. All the vehicles start with same UUID. Any work around for this, for now? We do have the seperate system id's...
@shakthi-prashanth-m I did all that. I'm modifying my script for the new syntax.

OK. I've been able to control all of the drones individually, by changing the UDP ports. Now, I have to see how I should connect to multiple drones and control them.

I could control all 4 drones simultaneously! I had to create 4 seperate DroneCore objects, and assign each object one UDP port. Then it worked. So now I have 4 times of some variables required for each drone. Have to put them in an array,I guess. Is this an elegant solution? My worry is tthat 4 DroneCore objects could take a lot of memory, especially if we're running this code on an OffBoard computer.
On a side note, it would be nice if we had a 'Swarm' type, to which we could add drones, and iterate through them to control them individually, or as a swarm.

@varunvp if you want to get this to work with one DroneCore instance, I think you need dive into the Firmware code first and fix it.

My worry is tthat 4 DroneCore objects could take a lot of memory, especially if we're running this code on an OffBoard computer.

It always makes sense to profile something like that before optimizing. It could well be that it is absolutely not a problem and any kind of optimization would be a waste.
This said, I initially planned DroneCore to be able to handle this case, so multiple vehicles with one DroneCore instance.

if you want to get this to work with one DroneCore instance, I think you need dive into the Firmware code first and fix it.
Sure! Tell me what to change and where ;-) Jokes aside, fixing a professionally maintained repo is out of my skillset for now. I'm a C++ newbie, have a lot to learn. I'll try raising a feature request in PX4 for the time being.

Since this problem has been "solved", I'm going to close it.

Sure, thanks @varunvp!

@julianoes

This said, I initially planned DroneCore to be able to handle this case, so multiple vehicles with one DroneCore instance.

Have we/can we have a test case for this? It should work, but if it doesn't we need to know for sure.

@varunvp could I have your mail-ID, need to contact you. Or can you ping me on<EMAIL_ADDRESS>Thanks in advance.

This said, I initially planned DroneCore to be able to handle this case, so multiple vehicles with one DroneCore instance.

Have we/can we have a test case for this? It should work, but if it doesn't we need to know for sure.

Yes, at some point we should tackle that.

Thanks @hamishwillee for the issue. I agree it is a good selling point but not something immediately required for the projects that I'm working at.


217 vision deblur

This notebook demonstrates Single Image Motion Deblurring with DeblurGAN-v2 in OpenVINO, by first downloading and converting the VITA-Group/DeblurGANv2 model to OpenVINO's Intermediate Representation (IR) format.

Oh wow!   It is indeed a very interesting topic and it is worth reading some of the recent sota approaches that use either transformers or global statistics aggregation.


NVM Restore to SmartStick G8 800 Series not successful

Checklist

[ ]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Home Assistant Add-on
Z-Wave JS UI version
zwave-js-ui: 9.21.1
ZwaveJS version
zwave-js: 13.4.0
Describe the bug
I tried to integrate my new G8 stick into Home Assistant and transfer the old configuration via NVM Restore. Unfortunately, the restore is aborted with the error “error while calling restore VM: The NVM File ID must be set before serializing”.
To Reproduce
trying another restore prozess
Expected behavior
Is there a solution for that error? And then yes, what is the solution for that?
Additional context
No response

Please make a driver log, loglevel debug and attach it here as a file (drag & drop into the text field).
cc @AlCalzone

Update to the latest version.

I also have the same problem. If I have understood correctly, this should be fixed in https://github.com/zwave-js/node-zwave-js/issues/7219.  When is the next release planned?

It's out now

The restore has now worked perfectly, thank you very much for the quick fix!

I can also confirm that it is now working. Thank you very much for the quick implementation.


Rearrange Columns

Forgive me if this feature already exists somewhere, are there any plans to allow the user to dynamically rearrange columns?

Animated rearranging is not yet supported, but if you rearrange your column
definitions, your columns should update instantly.
On Sat, Mar 25, 2017 at 4:00 PM James Cuénod<EMAIL_ADDRESS>wrote:

Forgive me if this feature already exists somewhere, are there any plans
to allow the user to dynamically rearrange columns?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-table/issues/142, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFUmCbzewQ2co6PY8Q_9Gy9hH2iT-cW3ks5rpY6HgaJpZM4MpO0j
.


fix: Take previously connected git applications accessibility to accurately calculate private repo count

Description

When we are connecting a application to git-repo we are not taking into account the fact that users can change the accessibility for the previously connected application from the remote repo, this leads to the incorrect number of currently connected private repo count. This PR makes sure to check the accessibility for all the private repo in an org and update the application git data if user alters the accessibility from remote.

Fixes https://github.com/appsmithorg/appsmith/issues/10684
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Junit TC
Manual test

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=dad623e

/ok-to-test sha=2720706


M33 breakpoint fixes

This update allows Cortex-M33 breakpoints to be set.  It now allows probe-run and defmt to be used with a Cortex-M33 device.

bors r+


feat: improve seeding interface for Cycle

At the moment, the seeding of the SimpleCycle needs a lot of manual work to set up. The initial experiment, data, and theory all potentially need manual initialization.
The cycle with the StateMachine as its steering element makes this easier, but it turned out to be somewhat complicated to implement.
Is there a better way?

Done! Already part of the workflow module


Write a program to make isolated building of package more efficient

Building Debian packages is a mess. There a countless of scripts and ways to build a debian package.
One of the more "modern" approaches is a isolated rootfs which is decompressed and extracted from a tarball for every single package being build. As this is inefficient and (once again) based on messy bash scripts, we need something better!
Why not use OverlayFS (which is used by Docker) to mount a mutable temporary directory over an immutable base rootfs.
This way we achieve isolation and efficiency by reusing the immutable layer.

On the other hand, we are building without a sandbox in CI, so this is not as important.


First integration of an AMSI check

Description:
This PR implements a check regarding the Exchange Server AMSI Integration. This first attempt performs testings by retrieving overrides via Get-SettingOverride. We show a yellow warning if AMSI is disabled on server or organizational level. We assume that Exchange Server AMSI Integration is enabled and working if no override exists or if it's set to Enabled=True.
I think there is more room for optimizations but I think it's a good start to build an useful check.

@tweekerz feel free to have a look and comment on this (since you wrote the AMSI blog post: https://techcommunity.microsoft.com/t5/exchange-team-blog/more-about-amsi-integration-with-exchange-server/ba-p/2572371)

There are some test failures.
Starting discovery in 1 files.
Discovery found 31 tests in 152ms.
Running tests.
##[error] [-] Testing Health Checker by Mock Data Imports.Basic Exchange 2019 CU11 Testing HyperV.Display Results - Security Settings 114ms (111ms|3ms)
##[error]  Expected 71, but got 73.
##[error]  at $Script:ActiveGrouping.Count | Should -Be 71, D:\a\1\s\Diagnostics\HealthChecker\Tests\HealthChecker.Tests.ps1:127
##[error]  at <ScriptBlock>, D:\a\1\s\Diagnostics\HealthChecker\Tests\HealthChecker.Tests.ps1:127
##[error] [-] Testing Health Checker by Mock Data Imports.Mocked Calls.Testing Standard Mock Calls 830ms (829ms|1ms)
##[error]  Expected Invoke-CatchActions to be called 1 times exactly but was called 2 times
##[error]  at Should -Invoke @__params__p, C:\Program Files\WindowsPowerShell\Modules\Pester\5.3.1\Pester.psm1:14586
Tests completed in 16.49s
Tests Passed: 29, Failed: 2, Skipped: 0 NotRun: 0

Will make some more adjustments here by adding Pester unit test.


Added process identifier to command_extended_result

The command extended result struct contains information about the spawned subprocesses. It should also contain the process identifier of the spawned child process.
I chose to take int32 as the type and use -1 for the case that the process creation has failed.
rdar://39798231

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

I didn't came up with a satisfying solution for the llbuild_pid_t typedef but at least with a working one ;) It's now defined twice: in CrossPlatformCompatibility.h and in the C-API-Header file as well which is used for bridging to Swift.


[bal-button-group] wrong alignment

Tablet: the buttons are aligned correct, but when a button text exceeds the width of the button, the text is aligned to the left.

Mobile: buttons are aligned to the left, instead of being expanded

will be done in #477

@hirsch88 @mladenplaninicic on mobile, the buttons are still aligned to the left, instead of being expanded


fix: Handle standby connection issue

Fixes #91
(pending more testing)

Further: Some time after a long standby the websocket will receive a close event. It is not possible to distinguish between this and other close events. Will maybe handle it heuristically with timestamps.

Further: Some time after a long standby the websocket will receive a close event. It is not possible to distinguish between this and other close events. Will maybe handle it heuristically with timestamps.

Any reason not just to try to reconnect?

Maybe I’m missing something, but I think https://github.com/flix/vscode-flix/pull/92/commits/e9dcb55f75e5f9caaeb59945f73fd2fb535ed676 solves the issue. Before these changes the socket connection would disconnect (and not reconnect as intended) shortly after the system had been either on standby or in hibernate mode. After these changes my system seems to reconnected/restart the flix session as soon as it disconnects. This only leaves a short interval where the connection is down (when reconnecting). I don’t know if we had a reason to not merge this or if it was simply never tested?
(The longest standby test I have made is around 1 hour)
To recreate this bug (on my system):

Open a flix project (and let flix start/load) - Now the connection should be established like on the image below:

Put the computer in standby or hibernate mode (the time doesn’t seem to have an affect for me)
Open the computer (and flix project) again - The socket connection should now be in the middle of disconnecting (TIME_WAIT) and soon be disconnected like on the image below:

I just think it was never tested. Or maybe it did not work 100%. No idea if @plougsgaard remembers?

If you seem satisfied with the fix (both code and testing) then we can merge it in.

Maybe you can test, on Linux, by enabling a firewall rule that REJECTs the packages going to VSCode/Flix?
https://serverfault.com/questions/604226/block-an-outbound-destination-ip-to-prevent-connections-waiting-timeout-duration
And then dropping the firewall rule.

If you seem satisfied with the fix (both code and testing) then we can merge it in.

The code looks to me like it should work and I have been testing it for a while now, trying to get the same error and haven’t been able to. I think we should try to merge.

Maybe you can test, on Linux, by enabling a firewall rule that REJECTs the packages going to VSCode/Flix?
https://serverfault.com/questions/604226/block-an-outbound-destination-ip-to-prevent-connections-waiting-timeout-duration
And then dropping the firewall rule.

Maybe I don’t completely understand this. I’m not on a Linux system. If you mean that this is a way to reproduce the bug, I think you could be right. I tried producing the bug in a similar way using windows defender, but I’m not always good friends with that program, so there might also be a way to get it to work on windows (I wasn't able to when i tried)

@mR4smussen Does this PR restart the extension, the Flix compiler, or both?
I would say it should not be necessary to restart the Flix compiler (which can be slow). But I am also not sure if that is what is happening.

From what I can see and understand this only restarts the extension. For instance, I can run a flix program as soon as the extension has restarted, without the compiler needing to start up again.

Does it display a notification that it has reconnected?

It doesn’t necessarily indicate that the connection was lost and it had to reconnect, it simply shows the “starting flix extension” label and then the “ready” label when the extension is ready.

(no message is displayed in the console)

Ok

@mR4smussen It seems that this PR has broken the action "Restart Flix Compiler". Can you confirm?

That is correct :(. I'm not sure why yet, But I could imagine that since we now start a new compiler when a compiler is closed, a restart could result in two compilers being started at once. In my experience it does work after starting a couple of times, but this is obviously not optimal. I will look for a fix to this tomorrow or in the weekend

That is correct :(. I'm not sure why yet, But I could imagine that since we now start a new compiler when a compiler is closed, a restart could result in two compilers being started at once. In my experience it does work after starting a couple of times, but this is obviously not optimal. I will look for a fix to this tomorrow or in the weekend

Sounds good.


[3591] Map Primary General (with Maths) initiative to specialist teaching

Context
We have decided to map initiatives which are like "Primary General/Specialist Teaching" to "Specialist Teaching, Primary with Maths" course subject in register.
Changes proposed in this pull request
When this initiative is encountered, override the course subject one to match "Specialist Teaching"
Important business

~Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?~
~Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?~

 Map Primary General (with Maths) initiative to course subject "specialist teaching (primary with mathematics)"


Allow just the files and directories that need to survive a docker restart to be mounted for easy upgrade

I mount the following paths when running gocd-server as a docker container
/var/log/go-server
/var/lib/go-server/pipelines/flyweight
/var/lib/go-server/plugins
/var/lib/go-server/artifacts
/var/lib/go-server/db
/etc/go
/var/go/.ssh

To be able to kill and restart the docker container without losing database and configuration and not having to check out all flyweights again.
The first time the docker container runs it creates files in the host directories these volumes are mounted to and it skips it the next time, so they're not overwritten. So that works fine. But it's in the way of doing a quick update from one to the next version by just running a newer docker image.
For example I'd rather just mount /var/lib/go-server/db/h2db instead of /var/lib/go-server/db, but then all the other directories in /var/lib/go-server/db/ aren't created and Go doesn't start properly.
And when mounting the whole /var/lib/go-server/db/ directory as I do now it will not update to the latest h2deltas when running a newer image.
All in all there seems to be quite some work around making the docker image easy to use for upgrading versions and for controlling the full configuration through environment variables.

+1

do you have your full docker run? i'm trying to do the same thing (setting up those volumes) and it doesn't create files in the directories...it errors out with permission denied when it trie to validate files in those dirs.


Initial Load Time of Agent List Screen Is too high

@malave I will send you credentials so you can log in to this instance, but 5 seconds to load a simple list seems excessive. Also, the network summary report loading swagger.json 3 times.

Same as #403

Mostly fixed with https://github.com/samtecspg/articulate/commit/3a2be8b2ac3b05a63ece9fece3888b96de245927


Desciption of the different branches

Please add a description of the many branches somewhere. Where should we contribute?
See:

https://github.com/tripleblindmarket/private-kit/blob/develop/CONTRIBUTING.md

So the standard is to contribute on the main branch, which is develop. You can see examples of people doing that under "Pull requests".


ascii art in radio button block options causes incorrect selection

Reproducible in:
slack-sdk==3.19.5
Python 3.10.4
ProductName:            macOS
ProductVersion:         13.3.1
ProductVersionExtra:    (a)
BuildVersion:           22E772610a
This only happens on desktop, not on mobile!
Steps to reproduce:
Calling the following method to send as DM:
client.chat_postMessage(channel=slack_id, blocks=message,
                                         text="New Question!",
                                         metadata={"event_type": "question_asked",
                                                   "event_payload": { "expert_id": expert_id,
                                                                     "task_id": task_id}})

where the blocks come from json as such:
[
  {
    "type": "section",
    "text": {
      "type": "mrkdwn",
      "text": null
    },
    "accessory": {
      "type": "radio_buttons",
      "options": [
        {
          "text": {
            "type": "plain_text",
            "text": "Matching concepts",
            "emoji": true
          },
          "value": "value-0"
        },
        {
          "text": {
            "type": "plain_text",
            "text": "Closely related concepts",
            "emoji": true
          },
          "value": "value-1"
        },
        {
          "text": {
            "type": "plain_text",
            "text": "Concept 1 is more general than 2",
            "emoji": true
          },
          "value": "value-2"
        },
        {
          "text": {
            "type": "plain_text",
            "text": "Concept 1 is more specific than 2",
            "emoji": true
          },
          "value": "value-3"
        },
        {
          "text": {
            "type": "plain_text",
            "text": "Unrelated concepts",
            "emoji": true
          },
          "value": "value-4"
        },
        {
          "text": {
            "type": "plain_text",
            "text": "\u00af\\_(\u30c4)_/\u00af",
            "emoji": true
          },
          "value": "value-5"
        }
      ],
      "action_id": "radio_buttons-action"
    }
  }
]

Notice the "\u00af\\_(\u30c4)_/\u00af", value which is shrug ascii art.
Expected result:
When clicked, all options are selected as per the cursor.
Actual result:
When I use the ascii art, the bottom 3 options all default to the bottom shrug. The ascii art seems to interfere with the other options. Whicever I click of the bottom 3 options, it always selects the shrug. When I change this to :shrug: emoji it works as expected.

Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @henrieglesorotos! 👋  Thanks for sharing snippets for replicating the problem!
When testing this myself, I found that all of these selections seem to behave as expected when clicked – causing a radio_buttons-action block action payload to be sent with information about the selection for both desktop and mobile.

I'm not noticing anything strange in your snippets, but feel free to compare what you have with this example! I did have to change the null text to a placeholder value and replace true with True to satisfy mrkdwn and Python types, but I don't think either of these would effect the selection behavior you're experiencing...
Let me know if incorrect selections are still happening after checking this! I'd be happy to explore this further if needed 😁

Thanks for the reply @zimeg - really appreciate it. It's a weird one, I did have multiple people across my org reporting this, but not quite sure what was causing it. I have changed the options so it's no longer a problem - it's now an emoji shrug.


Issue from website page 起步:安装Flutter

From URL: https://www.flutterchina.club/get-started/install.md

Got socket error trying to find package cupertino_icons at https://pub.dartlang.org.


HP Chromebook won't boot after firmware

I run the ChromeOS Firmware Utility Script on an HP Chromebook 14-ak040nr to use it with Linux Mint but now is not booting.

I turned it off, plug in a USB drive to install Linux Mint, but the same situation: is not booting.
The screen shows that is powered but stays blank.
I have used the script before on an Acer Chromebook CB5-571-C4G4 and now is working perfectly with Linux Mint, the only thing I did differently this time was not to clear the UEFI NVRAM before rebooting.
I have tried to manually clear the NVRAM by holding Refresh and turning it on, but nothing happens.
I will really appreciate any help regarding restoring the Chrome firmware to try the procedure again or instructions on how to make the computer boot with a USB drive to install Linux.
The attached picture is before removing the write protection screw, wanted to see if that particular Chromebook did not need to remove such screw.
Thank you in advance for any help

the only thing I did differently this time was not to clear the UEFI NVRAM before rebooting.

why would you clear the NVRAM before rebooting? what park of my documentation ever mentions needing to do that?

I have tried to manually clear the NVRAM by holding Refresh and turning it on, but nothing happens.

that doesn't clear the NVRAM, there's no way to do so.

The attached picture is before removing the write protection screw, wanted to see if that particular Chromebook did not need to remove such screw.

my site tells you what write protection method is needed for each device

Thank you in advance for any help

https://wiki.mrchromebox.tech/Unbricking

the only thing I did differently this time was not to clear the UEFI NVRAM before rebooting.

why would you clear the NVRAM before rebooting? what park of my documentation ever mentions needing to do that?

I have tried to manually clear the NVRAM by holding Refresh and turning it on, but nothing happens.

that doesn't clear the NVRAM, there's no way to do so.

The attached picture is before removing the write protection screw, wanted to see if that particular Chromebook did not need to remove such screw.

my site tells you what write protection method is needed for each device

Thank you in advance for any help

https://wiki.mrchromebox.tech/Unbricking


More examples of Singleton, Transient and Scoped Injection Dependency

Type of issue
Thank you
Description
I need to use two types of constructors: one for the application and another for the tester. So, I need to master the subject of dependency injection to avoid the aggregation error, which indicates circular references. I tried to implement the example given, but it didn't work. And there's just one example... What changes should be made to the classes to be able to do dependency injection? What should be added? what should be removed? Help me, because I'm using Moq and I can't remove the constructor with injection! I could give two examples: normal mode and using transient, scoped and singleton and teach how the student can migrate the modes to make it work. Thanks
Page URL
https://learn.microsoft.com/en-us/dotnet/core/extensions/dependency-injection
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/extensions/dependency-injection.md
Document Version Independent Id
cc5f00d0-fb50-1229-8fa2-e66b1f45b284
Article author
@IEvangelist
Metadata

ID: 8fd55089-b683-2202-6641-c7b61a132f14
Service: dotnet-fundamentals

Show me what you're trying to do? If you could provide the code that you have, I might be able to help.

Hello again! I am facing a runtime issue when trying to instantiate an
implementation for the 'API.Application.Interfaces.IContatoAppService'
interface. The specific error is as follows:
System.ArgumentException: 'Cannot instantiate implementation type
'API.Application.Interfaces.IContatoAppService' for service type
'API.Application.Interfaces.IContatoAppService'.' In the Builder I called:
builder.Services.AddScoped<IContatoAppService, IContatoAppService>() and I
tried other ways too: they all threw an exception.
I'm finding it difficult to solve this problem, as it's not clear where
exactly the error is (Sorry for the inconvenience, but I've got a project
in progress, and from what I know, dependency injection works with Scoped,
Singleton and others - but there is another way, which I couldn't identify,
but which generates the error ) It would be nice if you could provide more
detailed error messages or suggestions about what could be causing this
problem, as the error is pointed out in the builder (very generic). Thank
you in advance for your assistance!
Em qua., 29 de mai. de 2024 às 16:24, David Pine @.***>
escreveu:

Show me what you're trying to do? If you could provide the code that you
have, I might be able to help.
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/41082#issuecomment-2138110417, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ7OS2J6SBPMZV2FREP2MCLZEYTP7AVCNFSM6AAAAABIKCHCPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGEYTANBRG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Got it, thank you for the added context, that's very helpful! Ok, I see the issue. When you call:
builder.Services.AddScoped<IContatoAppService, IContatoAppService>();

That's registering a scoped IContatoAppService type with a corresponding implementation of the interface. That's not going to work, since it cannot instantiate an interface, nothing can. Instead, you need to register (or map) the corresponding implementation.
Consider this:
builder.Services.AddScoped<IContatoAppService, DefaultContatoAppService>();

In this example, the implemenation is the DefaultContatoAppService. It has to be defined somewhere:
public class DefaultContatoAppService : IContatoAppService
{
    // TODO: Implement members.
}

Does that make more sense now? Then for unit tests, you could mock the interface and use that.

Thank you for responding.
I think you'd better see my project to get an idea. I put AddScoped on (and
tried the others) but it was the same thing as nothing. I don't know...
I've been trying for weeks. It might help me know where I'm going wrong!
https://github.com/zabpetrus/bazartemtudo/tree/main/BazarTemTudo
Actually... trying to make dependency injection work. Until now, I'm forced
to use new()...
Thanks!
Em qua., 29 de mai. de 2024 às 20:09, David Pine @.***>
escreveu:

Got it, thank you for the added context, that's very helpful! Ok, I see
the issue. When you call:
builder.Services.AddScoped<IContatoAppService, IContatoAppService>();
That's registering a scoped IContatoAppService type with a corresponding
implementation of the interface. That's not going to work, since it cannot
instantiate an interface, nothing can. Instead, you need to register (or
map) the corresponding implementation.
Consider this:
builder.Services.AddScoped<IContatoAppService, DefaultContatoAppService>();
In this example, the implemenation is the DefaultContatoAppService. It
has to be defined somewhere:
public class DefaultContatoAppService : IContatoAppService{
// TODO: Implement members.}
Does that make more sense now? Then for unit tests, you could mock the
interface and use that.
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/41082#issuecomment-2138396705, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ7OS2NGGTQK724LKJTOWGLZEZNZBAVCNFSM6AAAAABIKCHCPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGM4TMNZQGU
.
You are receiving this because you authored the thread.Message ID:
@.***>


isOutsideRange to handle disable dates if user clicked on endDate first

I've this requirement where I need to restrict the user to select only max 10 days, I used isOutsideRange and it worked.
isOutsideRange = day => {
    const { startDate, endDate } = this.state
    const todayDate = moment()

    // disable all dates before today
    if (!isInclusivelyAfterDay(day, startDate || todayDate)) {
      return true
    }

    // disable 10 days after startDate
    if (
      startDate &&
      !endDate &&
      isInclusivelyAfterDay(day, startDate.clone().add(10, 'days'))
    ) {
      return true
    }

    return false
  }

but if the user clicked on the endDate first, then above function need more handling. I'm ok to just make the endDate not clickable, but it seems that there's no option for that.

It seems like this is a duplicate of #1542 (your other issue) - I'm going to close it in favor of that one.


Not returning information or documented status when device in low-power state

I'm getting status = ERROR_FILE_NOT_FOUND when issuing this IOCTL to a port that is in a low-power state. This IOCTL returns registry information, why would this fail if the device is in low-power?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: da5865a6-fe9e-7436-d8f4-fe51a149b2c8
Version Independent ID: c56fc34b-a7aa-11a0-7fd2-11633ac55936
Content: IOCTL_USB_GET_NODE_CONNECTION_DRIVERKEY_NAME (usbioctl.h) - Windows drivers
Content Source: wdk-ddi-src/content/usbioctl/ni-usbioctl-ioctl_usb_get_node_connection_driverkey_name.md
Product: windows-hardware
GitHub Login: @duncanmacmichael
Microsoft Alias: dumacmic

Hi @BrianCatlin, good question. Let me see what I can find out for you to make sure the doc is as accurate as possible.

Following up on emails behind the scenes with the USB team, I'm closing this issue as the documentation is accurate.


x/tools/gopls: unreported method syntax error

What version of Go are you using (go version)?

$ go version
go version go1.14.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/m/Library/Caches/go-build"
GOENV="/Users/m/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/m/Go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4f/tcxcr6_55v9bp38d8g4hjlf80000gn/T/go-build860054194=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I created a broken Go program 😬
https://play.golang.org/p/AGtHpgFoOts
What did you expect to see?
Proper syntax highlighting where I made my mistake.
In this case, func (*u Up) Run should be func (u *Up) Run
What did you see instead?
Nada. Nothing. Formatting fails, but that's about it.

If I go into the gopls logs on VSCode, I see the following:
[Error - 3:35:20 PM] Request textDocument/codeAction failed.
  Message: computing fix edits: /Users/m/Code/app/commands/migrate/migrate.go:20:7: expected identifier (and 1 more errors)
  Code: 0
[Error - 3:35:20 PM] Request textDocument/formatting failed.
  Message: 20:7: expected identifier (and 1 more errors)
  Code: 0

I'm not able to reproduce this - this is the error I see:

What directory did you have open when you saw this? It's possible that if the file wasn't in the directory at the root of your workspace, then gopls didn't report diagnostics for it (something we will be fixing in gopls/v0.5.0).
If you still have the full logs for this, those would be helpful to see.

Hey @stamblerre, thanks for the quick response!
I'm not quite up on the lingo for what a VSCode Workspace means, but here's my projects directory structure. I opened it with code .:
.
├── commands
│   ├── migrate
│   └── web
├── controllers
│   ├── pages
│   └── users
├── go.mod
├── go.sum
├── internal
│   ├── env
│   └── log
├── main.go
├── migrate
│   └── migrate.go
└── views
    └── pages

I'm sadly not able to reproduce this issue reliably. If I open VSCode fresh, it does properly show the error:

What I can say is that over time, as I'm adding and deleting files, it eventually fails stops reporting.
It sounds like 0.5.0 might provide a solution for this issue though? 😬🙏

Ah, ok so then it looks like your workspace is configured correctly and the diagnostics should be propagating. In the future when this happens, I'd suggest capturing detailed gopls logs (https://github.com/golang/tools/blob/master/gopls/doc/troubleshooting.md#capturing-logs) so that we can see what sequence of edits led to this state.
The process of cache invalidations after adding and deleting files is not perfect yet, so it's likely that that was the cause. I will be adding more integration tests soon, so I'll retitle this issue to make sure I add a few cases for adding and deleting files.

Okay sounds good. Do I also need to enable trace logs or is the default log output detailed enough?

You'll want to add the -rpc.trace flag to go.languageServerFlags.

Another case to add a regression test for: https://github.com/microsoft/vscode-go/issues/3179#issuecomment-614896921.

Closing since I this appears to be addressed 🙌


Adding Cursor Animation

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #205 Adding Cursor Animation[New Feature]: #205
I have added cursor animation which makes website look more attractive and professional.It will enhance user experience.

Mark the task you have completed ✅

[ ✅] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[✅ ] I have performed a self-review of my own code or work.
[✅ ] I have commented my code, particularly in hard-to-understand areas.
[ ✅] My changes generates no new warnings.
[✅ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ✅] I have added screenshot for review.

## Add your screenshots(Optional) 📸
![image](https://github.com/ChromeGaming/Physi-c-Tech/assets/169483518/abe55150-557e-4dab-8c87-2c8f218e256e)
https://github.com/ChromeGaming/Physi-c-Tech/assets/169483518/ac4c1276-369c-4696-856e-766516946682

Thank you soo much for contributing to our repository 💗

@thevirengarg I have commited require changes with the comment "cursor design changes" . It's look now :
https://github.com/ChromeGaming/Physi-c-Tech/assets/169483518/9036d76d-05e8-4bf7-921c-25f1751e0210
if you are satisfied with it.then  please label level and merge the pr .


Dataset for stock analysis production

Description

This dataset would help to analyze the stock market trends.
Related Issues

Changes Made

Screenshots (if applicable)

Checklist
Please review and check the following before submitting your pull request:

[1] I have followed the project's coding conventions and guidelines
[1] I have tested my changes thoroughly
[1] I have added/updated relevant documentation
[1] My code follows best practices and is easy to understand
[1] I have added necessary test cases (if applicable)
[1] All existing tests are passing
[1] My changes do not introduce any new warnings or errors

Additional Notes

@Ayushlion8 The dataset is just 50 lines can you add more? such that people can use it for their projects

ya sure:)

I've added a larger dataset please review it:)


rats-tls: fix the error "This is not a self-signed cert"

The peers are both openssl 1.1.1g.

Cannot be reproduced any more.


feat(kafka): add consumer settings for controlling the behavior of the poll loop

Adds ability to configure max.poll.interval.ms and max.poll.records for Kafka consumers/listeners. These essentially control how many max.poll.records must be processed within max.poll.interval.ms, otherwise the consumer might be considered as failed and the group will rebalance in order to reassign the partitions to other members.
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

The environment variables SPRING_KAFKA_CONSUMER_PROPERTIES_MAX_POLL_INTERVAL_MS and SPRING_KAFKA_CONSUMER_PROPERTIES_MAX_POLL_RECORDS can be used instead.


Please consider a less generic name and add a license file

I'd like to add this to awesome-zsh-plugins, but the name is awfully generic. Please consider renaming it to heapbytes to match the plugin file
Also, please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!.
Thanks!

Heyy, do you want me to change the repo name to heapbytes?
Thanks for consideration btw ^^


Add Camel K to upstream community operators

@anik120 thanks for your help. I've updated the PR.

/lgtm

Let us know if there is anything else required.


[FEATURE] Instead of "Inactive" for jobs in queue say "In Queue" or similar to not confuse users

Inactive might imply it's not running for another reason than just being in a queue

This was fixed a while ago, where do you see "inactive"? We can't change it in the girder client, but it's already fixed in the dive client.

duplicate of #561

Yeah I was looking in girder not front end doesn't matter then


Is there any way to add company logo instead of allure logo?

Hi! Yes, you can.
You need to implement a report plugin. But imho there is no reason to implement it for 1.4.* because 2.0 is coming soon (and plugin api is broken in 1.4.24.RC*)

Any concrete dates about 2.0 version?

You can try out a first beta release https://github.com/allurefw/allure-report/releases/tag/2.0-BETA1
An example plugin to change the logo: https://github.com/allurefw/allure-report/tree/master/plugins/custom-logo-plugin

Is there a place to modify the logo title as well?


Feature/anti spam protection

Anti spam, what u think?

Maybe a small optimization could be hashing message.content cause not using the message in anyway other then comparing

Maybe a small optimization could be hashing message.content cause not using the message in anyway other then comparing

Created a new issue for this. Might be good for zorakathon


Can't delete node from Uchiwa interface

When I try to delete a node from the clients screen, I get a message saying:
Error The client was not deleted! 400
Am I missing some credentials or something somewhere that will allow this?

How to delete checks from Uchiwa UI. I have implemented few checks for particulat server but now i want to remove some of them. There are no options to delete checks.

Hi @KwanzooDev
You can't delete checks from Uchiwa, you can only silence them or resolve an event associated to them. Removing a particular check must be done at the sensu-client level. Then, you can delete the client within Uchiwa in order to remove the checks history of this particular client.

1> I have 1 server and 2 client. In one client i have tomcat install and other i have httpd installed, written ruby scripts for both tomcat and httpd in each server . But In Uchiwa UI i an getting error as "sh: /etc/sensu/plugins/check-httpd.rb: No such file or directory". for the client which has only tomcat and vice versa.
Is there a way to make services to particular client instead of global?


be able to open links in a new tab

a lot of the links on the site are not actual links but html objects with onclicks. convert them to actual links.
this includes:

[ ] menu items
[ ] profile name icon
[ ] recipe photo in card
[ ] recidex logo
[ ] everything in the hamburger manu


[site, usability] remove target="_blank" from links

Need to remove target="_blank" attribute from all links on lib.haxe.org.
That site for developers. Please do not impose on opening links in a new window.
E.g.: in http://lib.haxe.org/p/gm2d link to Github ("Website") have target="_blank".

I agree this is a bit 1998.

:+1:
This issue continues to annoy me. I like being able to determine whether I want to open a given link in a new tab or not.

plz! :warning:

FYI haxelib does not have a maintainer atm, @andyli will start working on various issues as soon as he's done with handling haxe packages for Linux.

Okay, excuse me.

Okay, excuse me. Can I help? I have a free one day per week.

I've fixed this issue.  I've always preferred links to external sites to open in new tabs but I guess I am in the minority on this one.
@fzzr- I'll send you an email - I'm sure help would be appreciated but the Haxelib project is pretty overwhelming.

@jasononeil :+1: Thank you. I wrote email to you.

This issue seem to have re-appeared :(

Thanks!


Pull request meyergm/computerscience into microsoft/computerscience

Updated filepath for housing_data.csv in Student_Notebook-section_5.ipynb.

Pull in updates for Notebooks 3 and 4

Aaron Daniel Kaatz


[Bug]: argocd app create command fails due to incorrect kustomization

Installation method
Workshop Studio
What happened?
In the automation lab for argocd. The app creation is failing because of incorrect kustomization.yaml.
Creating the argocd application fails with following error.
$ argocd app create argocd-demo --repo https://github.com/aws-samples/eks-workshop-v2.git --path environment/workspace/modules/automation/gitops/argocd --dest-server https://kubernetes.default.svc --dest-namespace argocd-demo
FATA[0000] rpc error: code = InvalidArgument desc = application spec for argocd-demo is invalid: InvalidSpecError: Unable to generate manifests in environment/workspace/modules/automation/gitops/argocd: rpc error: code = Unknown desc = Manifest generation error (cached): `kustomize build .environment/workspace/modules/automation/gitops/argocd` failed exit status 1: Error: accumulating resources: accumulation err='accumulating resources from 'ui': evalsymlink failure on '.environment/workspace/modules/automation/gitops/argocd/ui' : lstat .environment/workspace/modules/automation/gitops/argocd/ui: no such file or directory': must build at directory: not a valid directory: evalsymlink failure on '.environment/workspace/modules/automation/gitops/argocd/ui' : lstat .environment/workspace/modules/automation/gitops/argocd/ui: no such file or directory

What did you expect to happen?
The application should be created.
How can we reproduce it?
Run the following command to create argocd as mentioned in the workshop document
$ argocd app create argocd-demo --repo https://github.com/aws-samples/eks-workshop-v2.git --path environment/workspace/modules/automation/gitops/argocd --dest-server https://kubernetes.default.svc --dest-namespace argocd-demo

Anything else we need to know?
This is due to the incorrect kustomization.yaml in environment/workspace/modules/automation/gitops/argocd/
environment/workspace/modules/automation/gitops/argocd/kustomization.yaml
--
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ui

There is no directory named ui in the environment/workspace/modules/automation/gitops/argocd.  As per the workshop documentation, it looks like the application being deployed is not ui but catalog. Thus, the kustomization.yaml should be as below.
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: argocd-demo
resources:
- ../../../../manifests/catalog/

EKS version
1.23

Looks like the kustomization.yaml was changed in PR #377

Hi @cparik . This shouldn't not happen since we updated the command currently reads:
argocd app create argocd-demo --repo https://github.com/aws-samples/eks-workshop-v2.git --path environment/workspace/modules/automation/gitops/argocd --dest-server https://kubernetes.default.svc --dest-namespace argocd-demo --revision stable

Specifically it should have --revision at the end to avoid this problem you are having. Can you please confirm the command you are seeing?

It works with --revision at the end. This was not present in the workshop earlier.  Closing this ticket.


istiod-default-validator validating webhook not purged affecting reinstall on different namespace

Bug Description
If you uninstall istio using istioctl x uninstall --purge  it won't remove the istiod-default-validator validatingwebhookconfiguration. The issue affected me when I installed istio in a different namespace then purge and tried to install in a different one.
The problem causes validation fail on istiod
This will install the Istio 1.13.2 default profile with ["Istio core" "Istiod" "Ingress gateways"] components into the cluster. Proceed? (y/N) y
✔ Istio core installed
  Processing resources for Istiod.                                                                                2022-05-12T16:38:24.868222Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.11: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
2022-05-12T16:38:25.083211Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.12: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
2022-05-12T16:38:25.287560Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.13: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
2022-05-12T16:38:25.491593Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.11: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
2022-05-12T16:38:25.903756Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.12: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
2022-05-12T16:38:26.105974Z     error   installer       failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.13: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
✘ Istiod encountered an error: failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.11: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.12: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
failed to update resource with server-side apply for obj EnvoyFilter/istio-system/stats-filter-1.13: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.11: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.12: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found
failed to update resource with server-side apply for obj EnvoyFilter/istio-system/tcp-stats-filter-1.13: Internal error occurred: failed calling webhook "validation.istio.io": Post "https://istiod.l1-mesh-istio.svc:443/validate?timeout=10s": service "istiod" not found

When I run kubectl get validatingwebhookconfiguration I noticed an old istio-default-validator from my previous install.
kubectl get validatingwebhookconfiguration
NAME                                                         WEBHOOKS   AGE
istio-validator-istio-system                                 1          71s
istiod-default-validator                                     1          5d18h

Version
$ istioctl version
client version: 1.13.2
control plane version: 1.13.3
data plane version: 1.13.3 (1 proxies)
$ kubectl version --short
Client Version: v1.22.5
Server Version: v1.22.8

Additional Information
No response

@litong01 It happened a couple time ago, but I believe that the problem is related to installing istio on different namespace then, after uninstalling it, reinstall on istio-system.

@lucasmellos understood that, please add details to recreate this issue. That will help to debug the issue.

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: demo

$ istioctl install -f
$ istioctl x purge
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
namespace: istio-system
name: istio-system
spec:
profile: demo
$ istioctl install -f

@lucasmellos using your command wont produce errors (after correcting some errors, which I can tell that cannot be the exact steps that you took), there were few similar issues open in the past regarding the webhook not being cleaned, these old webhooks probably play some bad roles when installing new instances of Istiod. however, using your reproducing steps wont produce the error. Since I do not see the old webhook that you referring to in your issue. Here are the steps that I used for trying to recreate your issue, which does not reproduce the error. I used Istio 1.13.2. and deployed onto two different namespaces, and did a purge, then run again, no issues.
cat << EOF | istioctl install -y -f -
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: demo
EOF

cat << EOF | istioctl install -y -f -
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system2
  name: example-istiocontrolplane
spec:
  profile: demo
EOF

istioctl x uninstall --purge -y

cat << EOF | istioctl install -y -f -
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
  name: example-istiocontrolplane
spec:
  profile: demo
EOF


Bug: Need to remove ANTIALIAS

In extractor.py:
    filters = {
        n: getattr(PIL.Image, n)
        for n in ["BILINEAR", "BICUBIC", "ANTIALIAS", "LANCZOS"]
    }

The "ANTIALIAS" option has been deprecated for a while and is now removed and is causing build problems.

Thanks, could you please submit a PR that removes it?


Added analytics for cask info

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

This PR contains that add analytics info to the brew cask info command.
Fixes #7566

@MikeMcQuaid I am just thinking we should need to refractor the can run be run with a url twice
in cask tests.Since it is using a real cask, the test will fail if analytics data changes.

@tharun208 yea seems like those live analytics numbers will break the test when they change.  The equivalent brew info test just creates a formula for testing on the fly, but it also uses --json which doesn't include the analytics info anyway.
One minimal/cleanish approach could be to change the tests so that on the Analytics portion they don't check for an exact string match and just check that an Analytics section exists instead.  Though that'll still probably be more code than the new feature itself.
(I'm just a rando watching from the sidelines so don't put too much weight on my opinions.  I filed that #7566 issue and was too slow to get started on the PR! Psyched this feature is on the way)

I would suggest mocking the cask_api_json call e.g. expect(...).to receive(:...).and_return(...) so that it returns the data you specify.

@tharun208 yea seems like those live analytics numbers will break the test when they change. The equivalent brew info test just creates a formula for testing on the fly, but it also uses --json which doesn't include the analytics info anyway.
One minimal/cleanish approach could be to change the tests so that on the Analytics portion they don't check for an exact string match and just check that an Analytics section exists instead. Though that'll still probably be more code than the new feature itself.
(I'm just a rando watching from the sidelines so don't put too much weight on my opinions. I filed that #7566 issue and was too slow to get started on the PR! Psyched this feature is on the way)

@varenc , that is what I am checking with mike and I thought of mocking the cask api

I would suggest mocking the cask_api_json call e.g. expect(...).to receive(:...).and_return(...) so that it returns the data you specify.

@MikeMcQuaid , sure will make the changes

I would suggest mocking the cask_api_json call e.g. expect(...).to receive(:...).and_return(...) so that it returns the data you specify.

@MikeMcQuaid , sure will make the changes, And can you help me by adding the mock and I got one issue - all the tests are always passing in my local. Even though, there is a failing test.

@tharun208 It sounds like you need to use brew tests --online and/or edit the files in brew --repo rather than your local checkout.

@MikeMcQuaid , Can you help me with mocking the cask API  to get analytics. I tried different steps, but not working

@tharun208 I can but you need to ask more specific questions and/or push what you've tried to this PR.

@tharun208 I can but you need to ask more specific questions and/or push what you've tried to this PR.

Basically, I am reusing the formulae API endpoint to get the cask's analytics and showing that result in the info command.

@tharun208 I can but you need to ask more specific questions and/or push what you've tried to this PR.

Basically, I am reusing the formulae API endpoint to get the cask's analytics and showing that result in the info command. I already have done the implementation. but I am trying to fix the tests with mocking the analytics data.

Basically, I am reusing the formulae API endpoint to get the cask's analytics and showing that result in the info command.

Sorry to be pedantic but that's still not an actual question I can help you with.
If you want a maintainer to help you with something you need to explain:

What you were trying to do (and why)
What happened
What you expected to happen
Step-by-step reproduction instructions (with as minimal input data as possible)

In this case probably the best thing is to push whatever code you tried locally and we can talk about that code. I can't help fix code I can't see.

Since I am adding analytics data to the info command. I am refactoring the test in cask info tests by mocking the analytics data why because it is analytics data and will change frequently.
So, I tried using mocking the formulae_api_json to return static analytics data. But mocking is not working as expected. I explicitly tried to fail the test by giving wrong arguments to the function, But is throwing ArgumentError:        wrong number of arguments (given 0, expected 1).

Thanks so much for your first contribution!  You rock, @tharun208!

@MikeMcQuaid, Thanks for helping :) and would like to contribute more

@tharun208 I send you my thanks as well! I've been wanting this feature for awhile. I even made an alias for quickly fetching cask analytics using the HTTP API and jq...very happy I can toss that out and just have that in directly in homebrew now. Cheers!


basic auth: add exception for specified endpoints

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
It would be useful to add whitelisting for entryPoints.http.auth.basic. Like:
[entryPoints.http.auth.basic]
usersFile = "/etc/traefik/.htpasswd"
whiteList = [ "/something", "/.well-known" ]

Such feature would be used in projects where acme and authentication are used together.

Hello,
The v1 of Traefik is in maintenance mode: only bug fixes, no new features.
The v2 of Traefik has a new way to configure this.

The v2 of Traefik has a new way to configure this.

Can you provide more details? I don't see it in docs.


Javascript group capstone project

project link: https://github.com/stevenmukama/javascript-group-capstone/projects/1
In this group we are two people.

STATUS: APPROVED ♻♻
Hi team,
To highlight 👍🏽

You have the complete number of cards on your board
You assigned a task to each member of the group

Your project is complete!  There is nothing else to say other than... it's time to merge it 🚀
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.

I think it would be more professional if you can include the names and titles ( eg Student A and Student B) of each member of your group in the group information above.
I suggest that you close all issues with Student C and remove all duplicate issues so that only the ones you would be working on would remain.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


Set request method: GET

Solves issue when uses with Msw library caused by this: link
Request headers are not sent when using the Msw library. Example:
const http = require('http')
const parse = require('url').parse // DEPRECATED !!
const setupServer = require('msw/node').setupServer

const server = setupServer()

beforeAll(() => {
  server.listen()
})

afterAll(() => {
  server.close()
})

it.only('test', async () => {
  const url = parse('/')
  url.protocol = 'http:'
  url.host = '<IP_ADDRESS>'
  url.hostname = '<IP_ADDRESS>'
  url.port = '3000'
  url.headers = {test: 'test'}
  url.href = 'http://<IP_ADDRESS>:3000/'
  // url.method = 'GET' // resolves the issue

  const req = http.request(url, res => {
    console.log(`STATUS: ${res.statusCode}`)
  })

  req.end()
})

Also it is sending hash parameter to null because it is using url.parse which by the way is deprecated: link:

eventsource@^3 has a completely new implementation which means this should not be necessary - thank you for raising though!


build: auto label prs

Based on feedback from https://github.com/gitify-app/gitify/pull/1342#issuecomment-2215554048 - thanks @afonsojramos 😄

We could probably remove the Validate PR Title step from validator.yml and rely on the Semantic Pull Request check that this action creates.
Note: I haven't mapped these types to a label: chore, perf, revert, style

Note: I haven't mapped these types to a label: chore, perf, revert, style

Is it okay for those PRs to not have a label? Is there a "misc" section for those cases in the release notes?

We see so few of them that I was thinking we're just handle them ad-hoc


[network] Decrease Healthchecker logs

Justification / Why we must have it for V1 launch

This removes health checker logs, which are roughly a quarter of all logs, but don't serve any usable purpose.  This should decrease pressure on the logging system.

Breaking nature

No breaking changes, decreased health check logs, but they're never used

Who does this affect?

Logging in all (validator/full) nodes with healthchecking

Workarounds if we don't push the PR
We could accomplish the same thing by filtering logs in logstash, but that would just stop the logs from being stored, but continue put pressure on the log throughput.
Related PRs

Original PR https://github.com/libra/libra/pull/6672

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Chaning JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

this looks pretty safe....

/land


Ice closes on startup

I have an issue where Ice closes on startup, I am using Retroarch for my emulators, I can't seem to locate the issue. Saw a topic where someone had the same issue and fixed it by changing a slight error in the txt files, apparently a # was missing, however I can't seem to find the problem in my txt files.
I don't know if this will help, but prior to this issue Ice could not find any of my emulators, and only downloaded grid images, once I switched to retroarch it closes by itself the moment I open it up
here is my txt. files
p.s it creates ROMs file at C:\Users\Firas\ROMs even though I have given it another directory.

config.txt
[Storage]
The path to place your ROMs Directory. This can be in any drive or anywhere,
as long as the full path is specified. Use ~ to represent your home folder
(for example, C:\Users\Scott)

Set a directory where the ROMs are stored.
If no directory is provided, "~/ROMs" is used.
Example:
~\ROMs                     => C:\Users<YOUR USERNAME>\ROMs
ROMs Directory=D:\Games\Emulation\ROMs
[Grid Images]
The website listed should provide the grid images used by Ice. This URL will
most likely need to be provided by the website itself, as it is fairly specific.

The default is ConsoleGrid (consolegrid.com/api/top_picture)

If this field is left blank, Ice will not attempt to download images
Source=consolegrid.com/api/top_picture

emulators.txt
[Retroarch_Nintendo64]
location=D:\Games\Emulation\RetroArch\RetroArch\retroarch.exe
command=%l -fullscreen -L cores\mupen64plus_libretro.dll %r

consoles.txt
[Nintendo 64]
nickname=N64
emulator=Retroarch_Nintendo64
extensions=sfc
nickname=N64
emulator=
[Nintendo Wii]
nickname=Wii
emulator=
[Playstation 1]
nickname=PS1
emulator=
[Playstation 2]
nickname=PS2
emulator=

log
[11/15/16 19:24:32] =========================Starting Ice
[11/15/16 19:25:07] =========================Starting Ice
[11/15/16 19:26:01] =========================Starting Ice
[11/15/16 19:41:13] =========================Starting Ice
[11/15/16 19:46:41] =========================Starting Ice
[11/15/16 19:46:41] Creating ROMs directory at C:\Users\Firas\ROMs
[11/15/16 19:53:43] =========================Starting Ice
[11/15/16 19:58:51] =========================Starting Ice
[11/15/16 19:59:00] =========================Starting Ice
[11/15/16 19:59:09] =========================Starting Ice


Create a function that takes a fully geocoded cohort table and imports to gaiaDB

Takes the output of geocodeCohort #162 and imports the table to the cohort schema of gaiaDB

There is one schema for all cohort tables, "cohort".
Should there be one table for all cohorts? I am thinking one table for each cohort, defined by cohort_definition_id:
cohort.cohort_1234


Use topology from database when initialize te manager

Resolves: https://github.com/atlanticwave-sdx/sdx-controller/issues/308
When initializing TE manager, we read from DB, if topology already exists, then use the one from DB. Also did some updates to use domain_name as key when saving to DB (in earlier case, we used LC-X for easy iteration of domains).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

3 of 9 (33.33%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 58.396%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sdx_controller/handlers/lc_message_handler.py
0
2
0.0%

sdx_controller/messaging/rpc_queue_consumer.py
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

sdx_controller/handlers/lc_message_handler.py
1
24.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.1%

Covered Lines:
1086

Relevant Lines:
1917

💛  - Coveralls


Question: Compatibility with 1.2.0 version please?

Thank you a lot for your mods collection!

I can't seem to be able to reach  60 fps no more so yeah I don't think the fps unlocker mods are 1.2.0 compatible yet

confirmed, look at the latest comments
https://www.reddit.com/user/ChucksFeedAndSeed/comments/14p6hq0/beta4_totk_dynamic_fps_v154beta4_config_toggles/

There will be several mods compatible with 1.2.0 on the next release, but it will take a while.
We will try to release next weekend but no promises!

Mods Collection v2.3 released! Added about 100 mods compatible with TOTK 1.2.0, modders are really quick this time! Thanks you all!


Add installation-check to README.md

I am a new user of draw.io. After following the installation steps (added at https://github.com/ariel-bentu/tam-drawio/issues/11), I am still not sure whether the plugin works.
After installation, the dialog for new diagrams does not show anything related to "Block Diagrams"

However, the plugin is listed in "Plugins"

The current README.md guides well through the installation steps. I wish it had a "checkup" to show whether the plugin was installed well...

ok, added to the readme


Package Request: Microsoft To Do

Description of the new feature/enhancement
Microsoft To Do currently is a great integrated solution for quick reminders that blend in well with the Windows 10 environment.

Proposed technical implementation details (optional)
To Do is currently only available for installation via the Windows Store, which is not always a viable solution; adding this package would provide a simplified alternative.

I had to close my PR for now, because the download link expired. I'll create a new PR with a static link.

This looks like it's blocked by https://github.com/microsoft/winget-cli/issues/117


Transfer repo

Hi - you mention in the README creating an issue about transferring ownership of this account - I'd love to take it over!

Sorry, I don't know why this didn't ping me. I'm happy to transfer it to you if you still want it @coderholic

I'll keep a closer eye on this issue. Confirm you want it and I'll transfer the organization to you :)

@electricjones yeah still interested!

Okay, I invited you as an owner. Once you are in, I may stay on for a bit just to answer question or whatever.
I'm curious, are you intending to continue with the project in some way or do you want the organization name for something else?
(Either way it's yours. I'm not using it and hate squatters)

Thanks @electricjones!
Org name for another spider project.


Added a note

ATP doesn't need any specific diagnostic level.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/4824

Hello @JohanFreelancer9 and @nenonix, just waiting for the revision from @joinimran. But please do a copy review. Thank you.

Suggestions applied.

Hello @mjcaparas, this pull request is ready for your review and approval. The suggested change is based on your feedback as regards to the diagnostic level. Please approve and merge if there are no issues. Thank you.

Thank you for approving and merging this PR @mjcaparas!


Scan for vcs repos and save, ignore feature

Allow scanning for repos with a find/ag.
$ vcspull scan [path]  # prompt to merge into config (creating backup first) or create new

Should allow ignore dirs/patterns. Be fast, leverage https://github.com/ggreer/the_silver_searcher if in PATH.

This would be awesome! In the meantime, I made this:
https://gist.github.com/pirhoo/9f1f42ed73c929e1e19101356482daeb


Add boxed Montgomery zeroizing support

As a follow-up to #706, this PR (mostly) adds boxed Montgomery Zeroize support. Specifically, it implements it for BoxedMontgomeryParams. It also zeroizes the value for BoxedMontgomeryForm, but leaves the parameters alone since they're wrapped in an Arc. This caveat is carefully documented.

This seems like a potential footgun in that if someone does zeroize Arc<BoxedMontyParams> it would impact other BoxedMontyForm values

This seems like a potential footgun in that if someone does zeroize Arc<BoxedMontyParams> it would impact other BoxedMontyForm values

This is a good point, but in theory applies to any use of a zeroizable type in a reference-counted wrapper, no?

It could be relevant for use cases like the Paillier-related case referenced by @fjarri. While that case was specific to MontyParams, it seemed prudent to attempt to unify the behavior as feasible.
That being said, if the footgun isn't worth it, sticking to at least zeroizing the value of MontyForm seems beneficial.

Are there actual practical use cases for heap-allocated secret moduli

I imagine they're the same cases as for the stack-allocated ones, since the boxed and the stack form are supposed to be interchangeable.
In my case, I need to do some operations in the RNS with moduli p and q which are secret primes (namely, square root and fast sampling of non-quadratic residues), so I need to make sure the corresponding Montgomery parameters don't leak secret stuff.

Note: I'm potentially okay with adding it, but...

since the boxed and the stack form are supposed to be interchangeable.

I'm not sure how they can be in this case, namely they'll need different zeroization patterns:

Stack allocated types need to be zeroized in-place to be effective, since trying to move the params out makes a copy
Heap-allocated types rely on obtaining an exclusive reference to the params first, then zeroizing it, which involves dropping all of the BoxedMontyForm values that reference it

I don't think there's going to be a way for generic code to be able to leverage it.

I'm not sure how they can be in this case, namely they'll need different zeroization patterns

They only need different zeroization patterns because of an optimization that is invisible to the user. From the outside perspective, there is no expectation of them being zeroized differently.
That said, I don't know exactly how to resolve this while keeping the Arc. In #704 I proposed an option of including a "zeroized on drop" flag in the params, but that would involve making another set of constructors.

That said, I don't know exactly how to resolve this while keeping the Arc. In https://github.com/RustCrypto/crypto-bigint/issues/704 I proposed an option of including a "zeroized on drop" flag in the params, but that would involve making another set of constructors.

A flag to zeroize the params on drop might make sense for BoxedMontyParams due to the Arc. I'm not sure what else would even work, other than hanging on to a copy of the Arc and trying to drop everything else that references it, with a potential runtime error if you can't get exclusive access.
If you're looking for a way to make them consistent, I'd worry adding drop glue to MontyParams might impact performance, as right now they're constantly copied and dropped.

For now, would it make the most sense to remove Zeroize from BoxedMontyParams and just merge the (partial) addition of it in BoxedMontyForm to handle only the value?


Fix libcasa_python, again

When updating for 3.3.0 I forgot that our clang-link patch was important for ensuring that python-casacore Python modules can load properly on macOS. Fix this again, and add a build-time test try to ensure that we don't mess this up again.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Add Intercom app integration

to: @airbnb/streamalert-maintainers
cc: @patrickod
Background
Intercom recently made V1.2 of our API stable. V1.2 introduces a new Activity Logs endpoint. This endpoint makes it possible to get a log of activities taken by all admins in an app via a GET request.
We (@catpham on behalf of Intercom Security team) are opening this PR to add an Intercom app integration to Streamalert. We think this would be a useful integration for customers who want to automate and further facilitate their Intercom app activity auditing and alarming.
Changes
This PR has 3 commits:

Adding the Intercom app integration
Adding unit tests for the Intercom app integration
Updating the README to include instructions on how to use the Intercom app integration

Testing
We've added unit tests. We've also been using the Activity Logs endpoint with the Intercom app integration in our private fork of Airbnb's Streamalert for the past 6 weeks.

Is there an auto fix option for the linter?

Coverage decreased (-0.07%) to 96.768% when pulling 0d4464d45970590492b4e608d450d6c77e9d79f4 on catpham:joanne/intercom-app into 2085a69bce434e26edad6e96a05dc647eaf20b62 on airbnb:master.

hi @catpham thanks for the contribution 😄 😄
I apologize for just seeing your question now - sadly there is not an 'auto fix' option, but we do suggest using yapf to help with formatting/linting issues.
To format in place, you can use:
yapf --style google -i path/to/file.py

@ryandeivert thanks for the helpful review! Just pushed up a commit to address the comments and left a follow-up question re token validation 🙇🏻♀

@catpham FYI I just changed the branch to merge this into to release-2-3-0 instead of master (which would be for bug fixes only)

hi @catpham, it appears that few unit tests are now failing. can you PTAL :)

@ryandeivert yes, on it!

this will be included in release v2.3.0

💃 thanks! any idea when v2.3.0 will be released?

probably not for a month or so, but you can always work off of this feature branch if you need it!


[Instant Submit for Control] Submitters cannot edit expenses when a vacation delegate approver is assigned for first level approval

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @HaleyJacobson
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727963381780969
Action Performed:

Create a new workspace
Invite Submitter, Approver A and Approver B
Enable approvals and set Approver A as the approver
As Approver A, go to OldDot and set Approver B as your vacation delegate
As Submitter, create an expense in your workspace chat

Expected Result:
Since the report is awaiting the first level of approver, the submitter should be able to edit expenses on it.
Actual Result:
The submitter is unable to edit the expense even though the report is still awaiting the first level of approval. Note that this is because to allow editing at the first level of approval, we check whether the manager of the approver matches the first-level approver.
One way to fix it would be to add a check to see if the first-level approver has a vacation delegate set. If they do, instead of checking for the first-level approver when confirming whether it matches the report managerID, we should check for the first-level approver's vacation delegate.
Workaround:
No
Platforms:
All
Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

cc @youssef-lr since we were discussing how to fix this.

Auth PR is merged, waiting for that to deploy before moving on to Web

Seems @youssef-lr has a couple of failing tests on the web PR, but nearly there

PR is deployed, we can close this.

PR was reverted. Please see https://expensify.slack.com/archives/C03SSAQ7P/p1730164864383419

New PR is up.

PR is still being worked on!

On staging. Awaiting deploy to prod

This was deployed!