.extension list incorrectly feed lines to the paginator

Description

Instead of putting each line as a separate entry in the lines parameter, .extension list will create a line with newline characters in it, like so
https://github.com/python-discord/sir-lancebot/blob/b0bddb905b8b7e311aad103570c8245f7c0a0683/bot/exts/utils/extensions.py#L164-L168
While this can seem harmless, this will cause the line length check to fail, and raise a RuntimeError
https://github.com/python-discord/sir-lancebot/blob/b0bddb905b8b7e311aad103570c8245f7c0a0683/bot/utils/pagination.py#L58-L59
Steps to Reproduce

It seems like that with the current cogs we have, running .extension list will unconditionally raise an exception
Solution

The paginator of the Python bot should be ported over to this bot.
Would you like to implement a fix?

[ ] I'd like to implement the bug fix
[x] Anyone can implement the bug fix

Closing this since :

the bot paginator has been ported to botcore and used here
running the command doesn't raise any exceptions.


SEO basics

sets up simple SEO stuff, will be transparent for the end user, just makes it nicer for the bots :)

63% => 77%
https://freetools.seobility.net/en/seocheck/stockholm.ai


PR #27 Counter metrics documentation

Related to PR #27

So.. Does anybody know how to get this pr merged?)


Highlight candidate application edits on manage

Context
Providers will want to be aware when a candidate has updated their submitted application.

Show notification banner on the candidates application page in the provider interface
Add notification text informing provider that applications can be edited
Show list of changes that have occurred on the application in the Timeline
Show notification line on updated cards on the applications index

The ticket outlined an implementation where the data that was changed is shown in the Timeline. I have not implemented this in this PR as it would require consideration about how and what could be shared between the history component and the timeline component.
As a stopgap, the link to "View Application" in the Timeline brings the user to the specific section of the application that has been changed.
Screenshots

Notification Banner
Notification text

Index card notifications
Timeline updates

Changes proposed in this pull request
Guidance to review

Link to Trello card
Trello Ticket

 CA: Highlight candidate application edits on Manage


go/types, types2: stack overflow while type-checking generic code

What version of Go are you using (go version)?

$  gotip version
go version devel go1.18-fe8347b Fri Sep 24 10:51:48 2021 +0000 linux/amd64

What did you do?
Trying to compile this sample: https://go2goplay.golang.org/p/MAplKhfhuKs
What did you expect to see?
The sample is incomplete (I tried to minimize it), so I don't expect it to compile. At the very least, there are calls to functions that don't exist.
The code is also incorrect. In the signature of quickSort_gen_func, a, b should be int, not Elem. Fixing this, the compiler produces an expected error message instead of going into infinite recursion.
What did you see instead?
runtime: goroutine stack exceeds<PHONE_NUMBER>-byte limit
runtime: sp=0xc0205e0318 stack=[0xc0205e0000, 0xc0405e0000]
fatal error: stack overflow

runtime stack:
runtime.throw(0x6aa2fc, 0xe)
	/usr/local/go-faketime/src/runtime/panic.go:1126 +0x74
runtime.newstack()
	/usr/local/go-faketime/src/runtime/stack.go:1069 +0x7de
runtime.morestack()
	/usr/local/go-faketime/src/runtime/asm_amd64.s:436 +0x8b

goroutine 1 [running]:
go/types.(*unifier).nifyEq(0xc00058a140, 0x6f32a0, 0xc0000105a0, 0x6f30e8, 0x817000, 0x0, 0x0)
	/usr/local/go-faketime/src/go/types/unify.go:197 +0xb8 fp=0xc0205e0328 sp=0xc0205e0320 pc=0x5a6c18
go/types.(*unifier).nify(0xc00058a140, 0x6f32a0, 0xc0000105a0, 0x6f30e8, 0x817000, 0x0, 0x0)
	/usr/local/go-faketime/src/go/types/unify.go:238 +0x10f6 fp=0xc0205e0488 sp=0xc0205e0328 pc=0x5a7d16
go/types.(*unifier).nifyEq(0xc00058a140, 0x6f32a0, 0xc0000105a0, 0x6f30e8, 0x817000, 0x0, 0x0)
	/usr/local/go-faketime/src/go/types/unify.go:198 +0x70 fp=0xc0205e04d0 sp=0xc0205e0488 pc=0x5a6bd0
go/types.(*unifier).nify(0xc00058a140, 0x6f32a0, 0xc0000105a0, 0x6f30e8, 0x817000, 0x0, 0x0)
	/usr/local/go-faketime/src/go/types/unify.go:238 +0x10f6 fp=0xc0205e0630 sp=0xc0205e04d0 pc=0x5a7d16
...
<SNIP>

Smaller reproducer:
package p

func f[P any](a, _ P) {
	var x int
	f(a, x)
}

Compiling leads to an infinite recursion in type inference.

Any update on this? Thanks.
(checking in as this is a release blocker.)

I de-duped #50273 to this issue. Once this is fixed we should confirm that it also resolves the repro there.

With the above CL this doesn't crash anymore. Still needs a proper fix but not a release blocker anymore.

This produces an ok error message and doesn't crash. Leaving for 1.19.

The type inference algorithm doesn't run into endless recursions anymore since 1.18, and for 1.19 we have disabled the catch-all in case of an infinite recursion and haven't seen any problems so far.
For the simple reproducer
package p

func f[P any](a, _ P) {
	f(a, int(0))
}

the error message is:
testdata/manual.go:4:7: type int of int(0) does not match inferred type P for P

which is exactly right (barring more information, the 2nd argument's type must be P) , and at the correct location.
There's nothing else to do here for now. Closing.


Inconsistent output of Poseidon CRH between native and constraints

I was helping @mfaghihi debugging the code, and found that the native code and constraints of Poseidon CRH in crypto-primitives seem to return different results.
Here are the tests I wrote: https://github.com/tsunrise/Poseidon/blob/debug/src/test.rs (the test failed)
Is there a bug in the Poseidon CRH implementations, or the Poseidon parameter is not correct?
(Could someone add unit tests for the CRH implementations if they have time? Thanks)
(btw, @mfaghihi 's implementation is using 0.2 release, but I have not changed the implementation of Poseidon CRH since then so I'd assume same problem will happen in 0.3 release)
cc: @drewstone @weikengchen

Let me first refer @mfaghihi to the ark-sponge implementation of the Poseidon hash function, which I think would also do the work for his project.
I would not have time this time to do a pass this week. But the Poseidon CRH has not been extensively tested.
At this moment, I think instead of adding more unit tests to Poseidon CRH, we may better just reconcile Poseidon CRH with the ark-sponge implementations.
Later, we may need to refactor the TwoToOneCRH trait again. The current TwoToOneCRH requires left and right to be [u8], but it is much better if TwoToOneCRH requires the left and right to be TwoToOneCRH::Output as well.

make sense to me 🆗

The current Poseidon CRH implementation has a few nice works that reduce the SBOX cost for common alpha. Our ark-sponge currently uses the generic pow_by_constant.
Later we may go back to this. pow_by_constant could be improved via finding the NAF of the number. There are many works ahead to bring ark-sponge in without losing the efficiency of a specialized implementation.

Let me first refer @mfaghihi to the ark-sponge implementation of the Poseidon hash function, which I think would also do the work for his project.
I would not have time to do a pass this week. But the Poseidon CRH has not been extensively tested.
At this moment, I think instead of adding more unit tests to Poseidon CRH, we may better just reconcile Poseidon CRH with the ark-sponge implementations.
Later, we may need to refactor the TwoToOneCRH trait again. The current TwoToOneCRH requires left and right to be [u8], but it is much better if TwoToOneCRH requires the left and right to be TwoToOneCRH::Output as well.

Thank you!
I was going to use the  ark-sponge implementation sine it may be enough for my task. Using permutation-based Poseidon is interesting to do and may be more efficient for some applications

I suppose this may also be fixed in the current PR open for updating the Poseidon implementation.


Accessing a destroyed database from python should result in an exception, not SEGFAULT

Description
Ref. https://github.com/The-OpenROAD-Project/OpenROAD/pull/4802, producing a clear exception instead of a SEGFAULT when accessing a destroyed database from Python is the idiomatic way to handle things in Python.
Tasks:

[ ] Add a well defined exception for accessing closed databases
[ ] Extend unit-tests to check that the exception is thrown

Suggested Solution
Throw exception instead of SEGFAULT, which is congruent with an idiomatic Python interface.
Additional Context
No response

Adding checking onto every single API call would be prohibitive in runtime and hard to do in practice. I don't see any practical solution to this. I think this is the nature of calling into c++ directly from Python - you have to play by c++ rules.

Runtime I dont believe will be affected materiallym
Hard to do, I can believe, though maybe smartptr can fix that? It is idomatic Python interface not to SEGFAULT.

I agree it is a good goal but I see no practical implementation.  I'm open to suggestions.

I agree it is a good goal but I see no practical implementation. I'm open to suggestions.

I tried to find the code, can you give some pointers to how this fits together?

Its generated by swig from odb/src/swig/...

I have never used SWIG, so I'm have trouble navigating it.
Maybe this is easier than it looks. I tried to create a simple test, it throws an exception, doesn't SEGFAULT, there is a check on None(null pointer) somewhere....
from openroad import Design
db = Design.createDetachedDb()
db.destroy(db)
db.getChip().getBlock().getNets()

$ openroad -python test.py
OpenROAD v2.0-12722-g25e88dd66
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[WARNING ORD-0039] .openroad ignored with -python
Traceback (most recent call last):
  File "/home/oyvind/OpenROAD-flow-scripts/tools/OpenROAD/test.py", line 4, in <module>
    db.getChip().getBlock().getNets()
    ^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'getBlock'
>>>

Try
from openroad import Design
import odb
db = Design.createDetachedDb()
odb.dbChip.create(db)
db.destroy(db)
db.getChip().getBlock().getNets()

oyvind@corona:~/OpenROAD-flow-scripts/tools/OpenROAD$ cat test/no-crash.py
from openroad import Design
import odb
db = Design.createDetachedDb()
odb.dbChip.create(db)
db.destroy(db)
db.getChip().getBlock().getNets()
oyvind@corona:~/OpenROAD-flow-scripts/tools/OpenROAD$ openroad -python test/no-crash.py
OpenROAD v2.0-12733-g09ba2a36a
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[WARNING ORD-0039] .openroad ignored with -python
Signal 11 received
Stack trace:
 0# 0x00005E9E23989703 in openroad
 1# 0x00007B7098E42990 in /lib/x86_64-linux-gnu/libc.so.6
 2# odb::dbDatabase::getChip() in openroad
 3# 0x00005E9E255347E8 in openroad
 4# 0x00007B70997C7B46 in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
 5# PyObject_Vectorcall in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
 6# _PyEval_EvalFrameDefault in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
 7# 0x00007B70999CF0FC in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
 8# PyEval_EvalCode in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
 9# 0x00007B70998B4F99 in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
10# _PyRun_SimpleFileObject in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
11# _PyRun_AnyFileObject in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
12# Py_RunMain in /lib/x86_64-linux-gnu/libpython3.11.so.1.0
13# main in openroad
14# 0x00007B7098E28150 in /lib/x86_64-linux-gnu/libc.so.6
15# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
16# _start in openroad
Segmentation fault (core dumped)

Just an info comment here... Exceptions raised in C++ get passed up to Python by SWIG. ( see src/Exception-py.i ) so the C++ code here is segfaulting which is hard to recover from.  When you delete an object in C++ and the Python wrapper does not know about it, bad things will happen. Another way to do this that would be safer is to use del db  in Python rather than db.destroy(db) The Python db object includes a method swig_destroy which calls delete_dbDatabase, so maybe the better approach is to use Python to delete these Python objects and trust (and verify) that the correct cleanup code is triggered in C++

@macd that would handle the db object itself but all the other object handles you might have would still remain invalid (eg a dbInst).  Do you see a way to invalidate all references into the destroyed db?

I don't immediately see how to do that (but let me ponder). It occurs to me that this must(?) also happen with the tcl interface. If so, what is done there? If not, maybe an approach we can copy?

I expect it is the same in tcl

Similar question https://stackoverflow.com/questions/10068576/delete-an-object-and-all-references-to-it-in-python
My two thoughts are either 1) have a callback on destroy() which will go into the SWIG interface and invalidate any related objects, or 2) remove destroy() from the user view and force using python mechanisms to delete the object.
Or I guess there is also 3) which is force destroy() to invalidate all python objects before calling the the underlying C++ (similar to 1).

@rovinski do you know how to do (1)?
I'm not clear how (2) would help as it is the other objects that are affected in ways that python doesn't understand.

After further reading, I think the best solution is to simply disable calling destroy() from Python. As @macd says, del db is the safer way to do it.
In this case, it will be up to the user to del, or otherwise allow to go out of scope, all references to the db or db objects.
So in an example (Assume there is debug code that says when the db is deleted):
>>> from openroad import Design
>>> import odb
>>>
>>> db = Design.createDetachedDb()
>>> odb.dbChip.create(db)
>>> del db
Deleted db object
>>> db.getChip().getBlock()
Traceback (most recent call last):
  File "<stdin>", line 7, in <module>
NameError: name 'db' is not defined

In another example:
>>> from openroad import Design
>>> import odb
>>>
>>> db1 = Design.createDetachedDb()
>>> # Second reference
>>> db2 = db1
>>> odb.dbChip.create(db)
>>> del db1
>>> db2.getChip().getBlock()
<odb.dbBlock object at 0x7fc9a9e36d60>
>>> # Remove last reference
>>> del db2
Deleted db object
>>> db2.getChip().getBlock()
Traceback (most recent call last):
  File "<stdin>", line 12, in <module>
NameError: name 'db2' is not defined

I think the only question is if a reference to a child object counts as a reference to the db, and if not, how to make it count as one.

The weakref package also looks interesting: https://docs.python.org/3/library/weakref.html

The solution assumes all calls come through db.  You can still fail with
block = db.getChip().getBlock()
del db
block.getName()

I believe that block = db.getChip().getBlock() is supposed to add a reference count to db. Therefore, del db will not actually delete the db. You would have to do del block in order for the db to actually be deleted.

Alternatively, block could be a weakref, meaning that del db would in fact invalidate block.


Addition of nasirhm in maintainers

Motivation for this change
Add nasirhm in maintainers.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Please format your commit message as maintainers: add nasirhm
If you plan to take maintainership of some packages, you should consider adding yourself to the maintainer list for those in separate commits as well.
Additionally, note that you don't need to be in the maintainer list to contribute - PRs are welcome regardless, the maintainerlist is just a way for the CI tools and other contributors to know who to request reviews from for package updates and questions

Please format your commit message as maintainers: add nasirhm

Done, Thanks :D

If you plan to take maintainership of some packages, you should consider adding yourself to the maintainer list for those in separate commits as well.

I added myself as a maintainer for brave browser (As I use it myself and have previously version bumped it).

Additionally, note that you don't need to be in the maintainer list to contribute - PRs are welcome regardless, the maintainerlist is just a way for the CI tools and other contributors to know who to request reviews from for package updates and questions

Hmm, Thanks for the review @RaghavSood


Use span-based APIs rather than byte arrays to verify signatures

SymmetricSignatureProvider.Verify is using the byte[]-based keyedHashAlgorithm.ComputeHash(input). Rather than allocating a byte[] just to compare it, you can stackalloc a span, use the span-based APIs to store into that, and then compare the spans.  Yet another reason to change the (Utility.AreEqual)[#2153] to be span-based.  In general, try to use the span-based APIs to write into existing arrays or stack space (for known small-ish sizes) whenever possible rather than using APIs that create new byte[]s/strings.

https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/7.0.0-preview2


Support smooth scrolling

Instead of maintaining state to enable/disable smooth scrolling per-editor, when IdeaVim is enabled/disabled, this PR means IdeaVim supports smooth scrolling. All scrolling such as <C-F>  will be handled correctly, and the page is animated, as when IdeaVim is disabled. The "Enable smooth scrolling" option in Preferences | Editor | General is now correctly respected by IdeaVim.

Yep, I like how does it work. Merged :)

@AlexPl292 will IdeaVim have soon a point stable release in order for users to benefits from this change as soon as possible ?

Hi! We don't have any plans for the stable release at the moment. You can join EAP, and you'll get this change in about a week.
https://github.com/JetBrains/ideavim#get-early-access

@AlexPI292 thanks, just to be clear:
Is it recommended to be on Idea EAP in order to have ideavim EAP or does Ideavim EAP has the same "stability guarantee" with stable IntelliJ Idea?

@LifeIsStrange you can use IdeaVim EAP with the stable version of IJ. As described in "Get Early Access" section, EAP versions don't guarantee your stability of the plugin, but practically the quality of EAP builds is quite high and it can be used on a daily basis.


API signup is broken for a week

I know this subject does not fit here, but the API signup portal has been broken for over a week now, and none of the support channels are reachable. When creating a new account and trying to sign up, it gives
Fatal error 00100 occurred during registration. Please try again or contact DeepL Support.

and when accessing the next time it gives
Something went wrong. Please try again or contact [DeepL Support](https://support.deepl.com/hc/requests/new).

clearing the cache or creating a new account does not change anything.

Confirmed that API signup works.

DeepL got it fixed this morning! Huge thanks.


feat(implementations/c): Add CMocka unit test framework to Vault tests

Add CMocka as a submodule
Modify Azure Pipelines to pick up the resulting XML files
Remove custom compare and print functions for CMocka asserts
Addresses Issue #89

looks good, I'll merge after @robinbudd has had a chance to review.
I assume you'll undo the STATIC build type in a separate isssue

merged https://github.com/ockam-network/ockam/commit/7e73885a58c9c6a194f21f542d8a21189c6e57db


Update submission deadline (moved by a week)

As discussed, we decided to move the submission deadline by a week (from March 28 to April 04). All other deadlines are unaffected.
@priyakasimbeg I suggest to merge to main directly to have it visible as soon as possible.

Ack, I will sync dev w main separately.


Exclusion of a data catalog, database, or directory from a dbt_constraint build

Description
The Please Note section of the dbt_constraints README.md explains that "When you add this package, dbt will automatically begin to create ... not null constraints for not_null tests." The Disabling automatic constraint generation subsection details how not null constraints can (only) be disabled for sources.
There is no functionality to disable constraint creation for other upstream model types like snapshots. Currently, my organization's dbt project has not null tests defined for most snapshots. Constraints should be created for production data through development with the option to enable and disable creating constraints for raw/source and snapshot data.

This was addressed with version 1.0.0


Newtonsoft.Json 11.0.1-beta1 is broken for netstandard1.6 with NU1605

Expected behavior

Build successful.
Actual behavior

Build failed with NU1605
error NU1605: Detected package downgrade: NETStandard.Library from 2.0.0 to 1.6.1. Reference the package directly from the project to select a different version.
error NU1605:  x1 -> Newtonsoft.Json 11.0.1-beta1 -> NETStandard.Library (>= 2.0.0)
error NU1605:  x1 -> NETStandard.Library (>= 1.6.1)

Steps to reproduce

dotnet new classlib (already with dotnet sdk >=2.0.0)
modify TargetFramework to netstandard1.6, and add an reference to Newtonsoft.Json 11.0.1-beta1

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>netstandard1.6</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Newtonsoft.Json" Version="11.0.1-beta1" />
  </ItemGroup>

</Project>

dotnet build and failure.

May relate to this. Is there any reason for not just let dotnet-sdk choose the best version?
https://github.com/JamesNK/Newtonsoft.Json/blob/ab3315f1d5e57c70203c904be79d8e951bf09794/Src/Newtonsoft.Json/Newtonsoft.Json.csproj#L27

See https://github.com/dotnet/standard/issues/606 and https://github.com/dotnet/standard/issues/601.

Fixed https://github.com/JamesNK/Newtonsoft.Json/commit/fde0fef06fdb5853a34ee1b108a2a66eaf243e29


Document Snapshot name requirements.

I had a tough time figuring out why my snapshots would not transfer.  The hint came when it printed a totally off the wall date of the unix epoch.  Snapshot names must be formatted at dates.  Old snapshots can be converted by listing the snapshots that aren't dates:
zfs list -r -t snapshot -o name,creation <volume> | grep -v "@[0-9]"
Followed by a zfs rename for each snapshot listed to the date listed converted to UTC:
zfs rename <volume>@backup-foo-2 2018-09-16-1200
A more robust way to do it would be if Perl's Date::Time(snapshot name) returns -1, we could treat the snapshot as if it were named the date of it's creation time locally and remotely.  So we would have @backup-foo-2 locally and @2018-09-16-1200 remotely.  That would let legacy snapshots transparently translate.  It would always translate to the same thing, and it would never change (As long as the timezone was UTC?).

Sending
From:openzfs on osx v 1.7.2, El Cap. Perl 5.28, as the latest one segfaulted.  Time::Date 2.30
To: Debian zfsonlinux 0.7.9-3.


ts-pattern matching tuple where one value is an option is not working

Hey and thanks for a great library.
I just stumbled across what I think is a bug. I'm not 100% sure if this belongs here or at ts-pattern's repo but my repro suggests that it could be here (if I'm not entirely mistaken and the error is on my end.. :)
I want to pattern match on a tuple where one of the values is an Option. Below is an example that highlights the problem:
const withOption = match(Option.Some("foo")).with(
  Option.P.Some(P.select()),
  (val) => val // val: string
);

const withoutOptionTuple = match([{ type: "a" }, { type: "baz" }]).with(
  [{ type: "a" }, { type: "baz" }],
  ([a, b]) => [a, b] // a: { type: string }, b: { type: string }
);

const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.select())],
  ([a, b]) => [a, b] // a: string, b: string
);

The last example says the parameter to the callback function is a string even if I don't destructure:
const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.select())],
  (val) => val // val: string
);

Which kind of leads me to believe this might be a TS issue unrelated to your library.. but idk 🤷
Do you see anything weird here too?
sandbox: https://codesandbox.io/s/late-haze-4rt5pg?file=/src/index.ts

@momentiris Hi 👋
That's actually normal. As you are using P.select(), you ask ts-pattern: "If this branch match, extract the value that's here".
If you want to get the whole tuple, use this instead:
const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.string)],
  ([a, b]) => [a, b.get()] // value is [{ type: string }, Some<string>], you can use b.get() directly
);

@momentiris Hi 👋
That's actually normal. As you are using P.select(), you ask ts-pattern: "If this branch match, extract the value that's here".
If you want to get the whole tuple, use this instead:
const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.string)], // we don't use P.select() but P.string here - it would also work with P.any
  ([a, b]) => [a, b.get()] // value is [{ type: string }, Some<string>]: you can use b.get() directly
);

Ahh I see! So it's not "selecting" the value into whatever position in the arbitrary data structure that I match on, but rather just "overriding" and selecting the value into the callback?
Thanks for that!

@momentiris Exactly! You can also select multiple values and name it if you want 🙂!
import { Option } from "@swan-io/boxed";
import { match, P } from "ts-pattern";

const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [
    { type: P.select("type", P.string) }, // select "type" if it's a string
    Option.P.Some(P.select("value")) // select "value" if it's a Some<*>
  ],
  ({ type, value }) => ({ type, value }) // { type: string, value: string }
);

Do you know why my first examples resulted in the first tuple argument 'resolved' to string too?

Do you know why my incorrect approach resulted in the first tuple value 'resolved' to string, while also 'resolving' to string when not destructured?
const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.select())],
  ([a, b]) => [a, b] // a: string, b: string
);

vs
const withOptionTuple = match([{ type: "a" }, Option.Some("bar")]).with(
  [{ type: "a" }, Option.P.Some(P.select())],
  (val) => val // val: string
);

@momentiris Yeah, because it resolves to string (the Some value), and in JS string are destructurables:
const [a, b] = "test"; // a: string, b: string

Haha, yeah of course. Now I understand. Thanks for pointing me in the right direction and also giving me a valuable lesson! :heart: 🙈

@momentiris No problem, enjoy using boxed! :)


Rename serde_item to serde_internals

Fixes #399.

I'm still not quite sold on the name serde_internals, since that sounds like it's an internal library for the serde crate, rather than the serde_codegen crate. It's wordy, but serde_codegen_internals might be more appropriate. Or something else that ties it to the plugin side of serde.

Erick and I discussed in IRC. I don't want to see people using serde_codegen_internals::Field etc in their code so let's move everything out of the top level into ::ast. Then encourage use serde_codegen_internals::ast as serde_ast.

If possible can I please get a ping when serde_codegen_internals shows up on crates.io and serde_item is unlisted?

@KodrAus don't worry about it, I will make a PR in elasticsearch-rs.


internal: Make CompletionItem label and lookup fields SmolStrs

This replaces a bunch of String clones with SmolStr clones, though also makes a few parts a bit more expensive(mainly things involving format!ted strings as labels).

bors r+

Just wondering, did this end up having a measurable effect?

Not really no, but I imagine that is because some of the code paths require an extra clone of the data again now that should be possible to be removed as well though.
Merged it now neverthless as I don't think this added any real complexity after all.


Gradle Build Failure: facebook-android-sdk

Log includes this:
      > Could not find com.android.support:support-v4:25.0.0.

Which points to this:
http://stackoverflow.com/questions/40355174/error-of-25-0-0-while-compiling-the-project
Which makes sense given this:
https://github.com/cbaggers/Fuse.Firebase/blob/master/src/Firebase.Authentication.Facebook/AndroidImpl.uno#L60
So we need to pick a version and stick with it for now

Fixed here https://github.com/cbaggers/Fuse.Firebase/commit/9622b2bbfaed90cbd21fac3b0d99176122fe8643


How do I let the scanner stay fixed on one location?

The scanner keeps going wider and wider, so I have to manually reset the search everytime. How do I keep it fixed to one areA?

On the login screen, set your radius to 1. But I would suggest 3.

thank you very much :)


drivers: i2c_ll_stm32_v1: improve NACK handling

According to the reference manual, the transmitter which receives a NACK must
reset the communication:
– If Slave: lines are released by hardware
– If Master: a Stop or repeated Start condition must be generated by software
In polling mode, if a NACK is received during address transmission the driver
waits forever the ADDR flag. We need to check AF flag and stop the transmission
if it is set.

@avisconti Could you also check it?

Codecov Report

Merging #9301 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9301   +/-   ##
=======================================
  Coverage   52.46%   52.46%
=======================================
  Files         201      201
  Lines       25290    25290
  Branches     5286     5286
=======================================
  Hits        13268    13268
  Misses       9938     9938
  Partials     2084     2084

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a500e7e...b53480c. Read the comment docs.


Missing ServiceAccountName configuration for secret-splunk-validation-hook pod

Describe the issue you're reporting
Hi, I believe we're missing the ServiceAccountName configuration for the  secret-splunk-validation-hook pod. Is there a reason it hasn't been added to the pod?
Since the  imagePullSecrets are added to the ServiceAccount, it would be helpful to use it on the hook pod when pulling the image from a private registry.

Sorry I didn't notice automation closed this ticket.
Updates:

Verified in the latest version of OpenShift using the default service account works with the validation hook pod, I was concerned it wouldn't since they have higher security standards.
Created the potential solution I was thinking of (link above) for this issue. While this solution would work I did find some drawbacks and don't think this is the way to go at this time. We might need it in the future.
After more research, I do think we can go forward with the following fix.

Remove the service account in the validation hook
If the user provided imagePullSecrets, add them to the validation hook pod spec.
@omrozowicz-splunk feel free to tackle this if you have time.


imx: fix missing "do_mender_tar_src" task

Hi @drewmoseley ,
I'm really new on Mender architecture.
I tried to add a new board using meta-mender-imx layer for testing and I got this the following error:
"do_mender_tar_src" is missing.
it looks like the u-boot-imx_% is missing u-boot-mender.inc
Could you review it, thanks for your help :)

Hmm, not sure this is needed.
My understanding is that the default configuration for all boards in meta-mender-imx is using the U-Boot/GRUB configuration, in which case you do not integrate directly with U-Boot so it should not be executing do_mender_tar_src.
Do you change the configuration in e.g local.conf ?  e.g do you have something like this:
MENDER_FEATURES_ENABLE_append = " mender-uboot mender-image-sd"
MENDER_FEATURES_DISABLE_append = " mender-grub mender-image-uefi"

If you do, you only need to apply it for the board you are trying to integrate instead of applying it for all.

@mirzak :
Yes indeed, the board I'm integrating use the u-boot-imx bootloader without grub as 2nd stage...
Using GRUB as 2nd stage is only required to support UEFI booting ?

If this doesn't break the UBoot/GRUB config can this be apply ?

Yes, indeed. And looking at it again, it should not break the U-Boot/GRUB config but might need to test to verify.

hi @drewmoseley @mirzak
Sorry I didn't test this patch properly I was on zeus branch instead of patch-1...
Now the error is back. It's look like mender_feature_is_enabled function in my build.
This my machine-conf-mender.inc that I include
`INHERIT += "mender-full"
IMAGE_CLASSES += "mender-setup-imx"
Force to use u-boot-imx for easy intregation with meta-community-imx
PREFERRED_PROVIDER_virtual/bootloader_mx8 = "u-boot-imx"
Specify BOOTSIZE and ENV_OFFSET
BOOTENV_SIZE_imx8qm-board = "0x2000"
MENDER_UBOOT_ENV_STORAGE_DEVICE_OFFSET_1_imx8qm-board = "0x400000"
MENDER_UBOOT_ENV_STORAGE_DEVICE_OFFSET_2_imx8qm-board = "0x800000"
Specify RootFS Storage on eMMC 0
MENDER_STORAGE_DEVICE_imx8qm-iwg27m = "/dev/mmcblk0"
MENDER_STORAGE_TOTAL_SIZE_MB_imx8qm-board = "2048"
MENDER_UBOOT_STORAGE_DEVICE_imx8qm-board = "0"
Specify the bootloader file
MENDER_IMAGE_BOOTLOADER_FILE_imx8qm-board = "imx-boot"
IMAGE_BOOT_FILES_remove_imx8qm-board = " ${KERNEL_IMAGETYPE} ${@make_dtb_boot_files(d)} "
Use mender with U-boot without GRUB nor UEFI support
MENDER_FEATURES_ENABLE_append = " mender-uboot mender-image-sd"
MENDER_FEATURES_DISABLE_append = " mender-grub mender-image-uefi"
`

Okay I found the issue


Use CPUID for querying sticker frequency

Signed-off-by: Lowren Lawson<EMAIL_ADDRESS>
Relates to #2336 bug report from github issues
Fixes #2336 change request from github issues.

Removes throw on lscpu parsing error in favor of falling back to cpuid calls and parsing.
It may be preferable to have the entire function throw if the end result is NAN (not implemented in this PR)

Latest changes LGTM, tested on system with known lscpu sticker freq issues.


Where it saved unfinished stream fragments?

I cannot find where stream fragments being saved during live stream

Found it in the directory you issued download command from  *.part file, it just windows10 shows it size as 0 unless you check properties.


Exec: option to hide process window

Typing code is sometimes interrupted when windows are opened so that new literals can be established for Exec. To avoid this, it would be helpful if there was an option for Exec to not show a process window.

Good call, I think this should even be the default.

I found it hard to work with this feature turned on all the time, so I used this simple workaround: conditional compilation directives to distinguish between development builds and production builds; use default values for development builds (#if ... #else ...).


Partly fix constructor coverage and junit classpath issues

Bumping the version of the junit dependencies, and making the classpath construction coherent partly fixes issue #42 (only for JUnit4 tests).

Ready for review

Rebased, ready on green


Overriding parent devfile's commands no longer works

/kind bug
/area devfile

What versions of software are you using?
Operating System:
macOS
Output of odo version:
master
How did you run odo exactly?
odo create --devfile devfile.yaml where devfile.yaml was a child devfile that overrode a command in the parent devfile
Actual behavior
Johns-MacBook-Pro-3:nodejs johncollier$ odo create --devfile devfile.yaml
Validation
 ✓  Creating a devfile component from devfile path: /Users/johncollier/ododev/overridecomop/nodejs/devfile.yaml [78443ns]
 ✓  Validating devfile component [89276ns]
 ✗  command install already exists in the devfile

Expected behavior
The child devfile's install command properly overrides the install command in the parent devfile
Any logs, error output, etc?
Sample devfile:
schemaVersion: 2.0.0
metadata:
  name: nodejs
  version: 1.0.0
parent:
  uri: https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/devfile.yaml
commands:
  - id: install
    exec:
      component: runtime
      commandLine: touch blah.js
      workingDir: ${PROJECTS_ROOT}
      group:
        kind: build
        isDefault: false

Looks like the cause is this section here:
https://github.com/openshift/odo/blob/master/pkg/devfile/parser/data/2.0.0/components.go#L157-159
With https://github.com/openshift/odo/pull/4001, I'm wondering if we even need this check any more?

For overriding the command, it should be mentioned in the parent's command section. The above devfile tries to append it in the parent commands which should throw an error. The correct devfile is :
schemaVersion: 2.0.0
metadata:
  name: nodejs
  version: 1.0.0
parent:
  uri: https://raw.githubusercontent.com/odo-devfiles/registry/master/devfiles/nodejs/devfile.yaml
  commands:
    - id: install
      exec:
        component: runtime
        commandLine: touch blah.js
        workingDir: ${PROJECTS_ROOT}

@mik-dass My bad, that all makes sense to me. Thanks!


NUTCH-2739 : Upgrade ES and migrate to REST client

Updated the Transport Client to rest client.
The test cases will only pass when there is a elastic server set up in local.

Thank you @balashashanka for this PR.
I would be in favor of deprecating indexer-elastic-rest in favor of this approach. Reasons being that this would enable us to close (mark as will not fix) both NUTCH-2304 and NUTCH-2677.
We can also then cleanup ivy.xml by removing the unnecessary dependencies associated with JEST.

Is anyone aware of any tradeoff's between indexer-elastic and indexer-elastic-rest?

This will mock the client itself. But we need to mock the server with requests and response. So can we go ahead and not do the tests at all?

Well, the previous non-REST test implemented a client which did not send anything to the server but just returned a successful response or (if clusterSaturated was set to true) a temporary failure.
But I'm ok to remove the Test class if it's too much work to rewrite it for the REST client.
I've tested the PR but the initial rounds failed for about 50% of the pages/documents:
[2019-11-18T12:56:46,803][DEBUG][o.e.a.b.TransportShardBulkAction] [vagran] [nutch][0] failed to execute bulk item (index) index {[nutch][_doc][http://nutch.apache.org/apidocs/apidocs-2.2.1/index.html], source[{"{date=Mon Jun 09 15:03:28 CEST 2014, type=[text/html, text, html], title=apache-nutch 2.2.1 API, url=http://nutch.apache.org/apidocs/apidocs-2.2.1/index.html, content=apache-nutch 2.2.1 API\n
 Frame Alert

 This document is designed to be viewed using the frames feature. If you see this message, you are using a non-frame-capable web client.
 Link toNon-frame version.\n, search=apache-nutch 2.2.1 API, tstamp=Thu Jul 26 16:50:11 CEST 2018, segment=20180726164932, digest=8b8785f9cec87c0376a7fa940e0e3a6c, host=nutch.apache.org, boost=1.0, id=http://nutch.apache.org/apidocs/apidocs-2.2.1/index.html, lastModified=Mon Jun 09 15:03:28 CEST 2014}":"doc"}]}

I got it fixed by using XContentBuilder to pass document as JSON to ES client, you'll find the necessary changes in this branch. Also:

updated the description how to upgrade the dependencies in the plugin.xml and added few exclusions of dependencies already provided by Nutch core.
changed the default properties in index-writers.xml.template so that the indexer-elastic plugin works out-of-the-box with default settings

So far, I didn't run any tests at scale. Should be to make sure we are able to index millions of documents with the given settings.
Please have a look at my changes. Can you integrate them into your branch?

Thanks, @balashashanka! I'll run another round of tests, and will merge soon.

Rebased and merged into master in c23afa8. Thanks, @balashashanka!


Checkboxes issues in elements editors forms in dev branch (+ possible fix)

In the dev branch

Open an element editor that have a checkbox option.
Check the option (if not already done) and save.
Re-open the editor, uncheck the option and save.
Re-open the editor, the option is still checked.

In 1.9.x, there is this PR #6301 that solves a same kind of issue #5593 due to an option that is initially checked... But in the dev branch it concerns all checkboxes (defined through the forms api), whether initially checked or not...
The problem is that if a checkbox is not checked, no value is posted on submission. So, here, the beginning of a possible solution in the dev branch by modifying FormsElementDriver.cs.
    private void UpdateElementProperty(dynamic formElementShape, ElementEditorContext context) {
        var name = (string)formElementShape.Name;
        if (name != null) {
            var value = context.ValueProvider.GetValue(context.Prefix + name);
            if (value != null) {
                context.Element.Data[name] = value.AttemptedValue;
            }

            // Added code...
            else if(formElementShape.Metadata.Type == "Checkbox") {
                if (formElementShape.Value == "true")
                    context.Element.Data[name] = "false";
                else if (formElementShape.Default != null)
                    context.Element.Data[name] = formElementShape.Default;
            }
        }
    }

Here, if nothing is posted, the mainly used "true" value of the shape.Value property is tested, then "false" is assigned... To implement other cases a shape.Default property can be simply added through the DescribeForm().
Best

I don't think this is an issue with the Forms API, unless you can reproduce this issue with the Workflows module for example (which also uses the Forms API). Instead, I suspect this has been introduced when refactoring the way form values are assigned to element data, somewhere in the ElementController.

@sfmskywalker
You're right, that's why i first modified ElementController.Update() where the element could be activated with some previous data values, because when a checkbox is unchecked no new value is posted . Before, the Request.Form was used, so, with only the posted values.
I could fix it in the Update() action where i've used the removeNonExistingItems option to true with the ElementDataDictionary Combine() extension:
var data = elementData.Combine(ElementDataHelper.Deserialize(sessionState.ElementEditorData), true);
But, as in the 1.9.x branch, this doesn't fix the issue where you can't define through DescribeForm() a checkbox that is initially checked.
That's why, in my previous comment, i've proposed another fix that works, so if it can help. This fix doesn't modify the Forms API, only the FormsElementDriver.UpdateElementProperty() in the Orchard.Layouts module.
Best

Ah I see. Sorry, small screen size ;) But yes, if you could fix that as proposed then that'd be awesome. Please test if all standard operations still behave as expected. I'll make a note of adding some automated tests to protect these things from regressions. Thanks man, really appreciate the time and effort you're spending on this (and other aspects) :)

@sfmskywalker thanks.
Just tried with the workflows editor through the create user form, it works as before without the 1st issue. But, here also, we could have the 2nd issue if we define a checkbox that is initially checked.
So:

With the little fix in ElementController, it's as before, but only the 1st issue is fixed, and you can't use a checkbox that is initially checked (and the related element property with a default value of true).

If we apply the first proposed fix, the 2 issues seems to be fixed but only for the layout elements.

Try to find a general solution (see below) to always post a value with a "boolean" checkbox (whose value attribute = "true"). (This give me the idea to implement a 2 values checkbox element...).

In asp source code, i've seen a checkbox helper that add an hidden field to post a "false" value. I could do it but it was not enough, maybe ok with a regular mvc pattern, but i also needed to remove the hidden field when the checkbox is checked, this not to post 2 values...
So, i've found a solution with a few lines of code in EditorShapes.cs, but i also needed to add a few lines of jquery code in base.js. Seems to work but needs more tests, i will propose a PR soon.
Best

@sfmskywalker
For infos I've proposed this PR #6308 with some jquery code. @sebastienros already asked me some questions. Not sure it's a good fix but it's the only way i've found to be more general with existing implementations (see my previous comment above).
Best

I remember this issue. As per @jtkech 's earlier comment, this was originally fixed by simply removing non-posted items from the element's data dictionary. However, the way this should be fixed is the same way the Checkbox HTML helper is implemented, by generating a hidden input with the same name as the checkbox field that posts "false" as its value. This way, when the checkbox is not checked, "false" will be posted. If the checkbox is checked, "false,true" will be posted (or the other way around), and "true" will be used. If that doesn't work as per @jtkech 's comments in PR #6308, then that is what we need to fix, since it should work with the modelbinder. Perhaps the order of the values matter, or perhaps it has to do with the underlying value provider. For example, NameValueCollection can store multiple values per entry in the form of a Values array, but a Dictionary probably just returns the posted string value ("true,false"). That should be fixable.
To summarize, I think we need to include the hidden input field by updating the Checkbox form shape (Orchard.Forms).

Just re-tried #6308, it works but with a little jquery code where i add an hidden field only if needed. Notice that #6339 also solves the issue through UpdateElementProperty() without an hidden field, but more specifically for layout element editors (maybe sufficient?).
But maybe using some jquery code is not the best solution, and its better to see around model binding as you said. But as i remember, modules that use Orchard.Forms checkboxes don't use model binding in the same way, e.g workflows editors.
So, here we would need to solve things step by step as needed. E.g right now this is not needed for workflows because the issue is only when a checkbox is initially checked, and currently this is not the case. So, maybe #6339 would be the first step.
Best


Support configuring the JLINK command

A humble try to add support for custom JLINK options.
I didn't add tests and also I don't familiar with Kotlin or Gradle Plugin development, please do check this.

Thank you for your suggestion in #3  and the proposed change here! I will definitely use this as a starting point, but I cannot accept changes without tests and am not available to finish this myself. I agree with the spirit of your change and a future release of this plugin will enable users to better utilize this plugin. There are several improvements to be made to this plugin, all of which need to be weighed against each other.
I maintain this plugin in my free time and without tests added for each changeset I won't be able to keep up regular maintenance like dependency updates, Gradle build tool updates, and bug fixes. I'm also a bit unsure if I want to expose the options in this fashion, as it could make future changes more difficult.

I see. It does make sense so for the meantime I'm closing this PR


ctc.train error

Hi Marco,
Thanks a lot for this super cool package. I'm an R user but the documentation helped a lot. I  used another package written in R (MLWIC), and I want to know if I get better result with your code, and see if it's faster, as the other one is super slow.
So as a background. I'm using the docker version with labels (only cpu). I created my csv file, and the image column has the path to my images (/data/train/images/*.JPG). I have around 38000 images with labels. The json file was created. and when I looked at it everything made sense. Then I ran the code to create the tfr files ( test and validation are around 1800, and the rest are the training).  So it created 7 train *.tfrecodr, and one for each validation and test. When I opened the label_mapping.json, everything looked legit:
{"count": {"1": 0}, "species": {"buffalo": 1, "waterbuck": 17, "darkness": 2, "jackal": 11, "giraffe": 5, "hartebeest": 8, "hare": 7, "impala": 10, "vegetation": 16, "eland": 3, "grantgazelle": 6, "humanactivities": 9, "lion": 12, "spottedhyena": 14, "baboon": 0, "elephant": 4, "zebra": 18, "servalcat": 13, "unknown": 15}}.
Then to train the model, I followed your documentaion, and just changed the -label, and added the weight_loss parameter:
sudo docker exec ctc ctc.train -train_tfr_path /data/tfr_files/ -val_tfr_path /data/tfr_files/ -test_tfr_path /data/tfr_files/ -class_mapping_json /data/tfr_files/label_mapping.json -run_outputs_dir /data/run1/ -model_save_dir /data/save1/ -model small_cnn -labels species count  -labels_loss_weights 1 0.5 -batch_size 16 -n_cpus 4 -n_gpus 0 -buffer_size 16 -max_epochs 70 -color_augmentation full_randomized
but I get bunch of errors:
Traceback (most recent call last):   File "/usr/local/bin/ctc.train", line 11, in <module>     sys.exit(main())   File "/usr/local/lib/python3.5/dist-packages/camera_trap_classifier/train.py", line 489, in main     output_loss_weights=args['labels_loss_weights'])   File "/usr/local/lib/python3.5/dist-packages/camera_trap_classifier/training/prepare_model.py", line 322, in create_model     metrics=[accuracy, top_k_accuracy])   File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/training/checkpointable/base.py", line 474, in _method_wrapper     method(self, *args, **kwargs)   File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/keras/engine/training.py", line 617, in compile     output_loss = weighted_loss(y_true, y_pred, sample_weight, mask)   File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/keras/engine/training_utils.py", line 598, in weighted     score_array = fn(y_true, y_pred)   File "/usr/local/lib/python3.5/dist-packages/camera_trap_classifier/training/utils.py", line 93, in masked_loss_function     return loss_function(y_true * mask, y_pred * mask)   File "/usr/local/lib/python3.5/dist-packages/tensorflow/python/keras/backend.py", line 3630, in sparse_categorical_crossentropy     logits = array_ops.reshape(output, [-1, int(output_shape[-1])]) TypeError: int returned non-int (type NoneType)
I would be grateful if you can let me know what the issue is, and how I can resolve it. I don't know much about python, so sorry in advance if I said something that didn't make sense.

Hi mehrnoushmalek
Thanks for your interest in this repository. I'm not entirely sure what goes wrong but one thing I noticed is the 'count' label you are using. According to the label_mapping.json you only provide the model with one count category ("1"). Presumably because you don't record the number of individuals? This might cause an issue because the number of distinct categories per label (species / count) should be at least 2--otherwise there is nothing for the model to learn. Does that make sense? You could verify that by trying to run the model with:
-labels species -labels_loss_weights 1.0

Let me know if that solves the issue.
Additionally, please note that the model architecture "small_cnn" is more of a toy model that won't produce very good results (but maybe still good enough). The smallest 'serious' model is "ResNet18".
For a use case with a larger model and the settings used to train it, please refer to: https://github.com/marco-willi/camera-trap-classifier/blob/master/docs/trained_models.md

Thanks a lot for getting back to me. So for counts I need to go through all images and add how many animals are in the picture, and update the count? When I ran this (with and without Docker):
ctc.train -train_tfr_path ~/Projects/OPC/tfr_files/ -val_tfr_path ~/data/tfr_files/ -test_tfr_path ~/data/tfr_files/ -class_mapping_json ~/data/tfr_files/label_mapping.json -run_outputs_dir ~/data/run1/ -model_save_dir ~/Projects/OPC/save1/ -model ResNet18 -labels species -labels_loss_weights 1.0  -batch_size 128 -n_cpus 10 -n_gpus 1 -buffer_size 512 -max_epochs 70
I get this:
Shape must be rank 0 but is rank 1 for 'metrics/top_k_accuracy/cond/Switch' (op: 'Switch') with input shapes: [?], [?].
Is this the error you were referring when only one counts is provided?
regarding the previous error, Is it possible that ids or counts become non-integer when the csv is read in the code? When I open the csv file, it says it's a number, but when I open the json file in R, this is what I get:
`$labels[[1]]$count
[1] "1"
$labels[[1]]$species
[1] "baboon"
$images
$images[[1]]
[1] "/data/images/BABOON__2019-01-09__08-43-37(1)_flipped.JPG.`

Sorry for my late reply. Whether you want the model to be able to count animals is up to you. If you want that capability you need to label the images with correct counts. If you don't want that capability you don't need to and you can train the model without count labels.
At the moment I can't tell what goes wrong. It seems like the input shape of you data is unkonwn / can't be determined, that's why I thought something with the labels output might be wrong. Can you verify that the tfrecords files have been created correctly? Does the size of the files make sense? Additionally, can you provide / paste the log files that are being generated by the code when generating the tfrecord files and when you start the training?
Also, it seems like the error is now different? Not sure, but maybe it helps to create the tfrecord files without the counts (although that is not supposed to be necessary) and then train the model with only the species labels.


Test case bug in 'Decimal Numbers in JS' challenge

Create Decimal Numbers with JavaScript

https://www.freecodecamp.com/challenges/create-decimal-numbers-with-javascript
Issue Description

Defining myDecimal without the var keyword passes the test. The variable is not previously defined in this code snippet, so it should fail (even though the var keyword is not required to get expected output when using my browser's devtools).
Your Code

var ourDecimal = 5.7;

// Only change code below this line

myDecimal = 5.7;

This is not a bug , it just the usual beahavior of Javascript.
That why es6 come with 'const' and 'let' , so var is not used anymore in serious project.

@MatthewDiana this is not a bug.
In javaScript, if a variable is assigned a value before being declared, it is declared in the global scope of the window/app by default.
Whilst it is bad practice, it is also a feature of the language


Extend VocabularlyManager to include ui-concerto label creation logic

Feature Request 🛍

The new VocabularlyManager introduced in https://github.com/accordproject/concerto/pull/361 includes a missing term generator, https://github.com/accordproject/concerto/blob/master/packages/concerto-vocabulary/lib/vocabularymanager.js#L59-L62.
Similarly the ui-concerto package in web-components includes some logic to automatically generate terms from model field names. https://github.com/accordproject/web-components/blob/master/packages/ui-concerto/src/utilities.js#L20-L25
These two features should be combined in this package, and ui-concerto refactored to use the common implementation.

Hey, @mttrbrts I would like to work on this issue since I'm very overwhelmed don't know from where to start. Can you please assign this to me as I have to get started :)

Welcome @Jeevan-Kiran-Lenka!
In summary, you will need to make changes in two places:

Move the logic from ui-concerto to concerto-vocabulary (line links above).
Refactor ui-concerto to import concerto-vocabulary and then call the missing term generator function.

Thanks for the tip @mttrbts !! Now it is easy to fix this :)

Hey!!, @mttrbrts I had some of the following doubts while working on this issue, I would really appreciate it if you can help me solve that.

 export const normalizeLabel = (labelName = '') => labelName
 .replace(/([a-z])([A-Z])/g, '$1 $2')
 .replace(/([A-Z])([a-z])/g, ' $1$2')
 .replace(/ +/g, ' ')
 .replace(/^./, str => str.toUpperCase())
 .trim();

The above function takes one argument labelName, and returns it after applying some modifications on that string

 static englishMissingTermGenerator(namespace, locale, declarationName, propertyName) {
     const firstPart = propertyName ? propertyName + ' of the' : '';
     return camelCaseToSentence(firstPart + declarationName);
 }

The above function takes 4 arguments, and then returns firstPart  + declarationName to make it in camel case in a sentence, so in a way, both the function are doing the same thing, which causes us more overhead therefore there is a need for combining the normalizeLabel logic in englishMissingTermGenerator, but my questions/doubts here are:-
Do I need to make changes in englishMissingTermGenerator or in camelCaseToSentence since it is the function that takes one argument like normalizeLabel and apply some regex functionalities, and then returns it.
The second question is also in the same path  that is englishMissingTermGenerator return something on the condition of whether or not propertyName is present, but that is not the case with normalizeLabel, so do I need to combine both the things inside englishMissingTermGenerator on the condition of if propertyName is present or not something like below:

static englishMissingTermGenerator(namespace, locale, declarationName, propertyName) {
    if(propertyName){
      const firstPart = propertyName ? propertyName + ' of the' : '';
      return camelCaseToSentence(firstPart + declarationName);
   }
   else{
      logic of `normalizeLabel` function
          }
  }

Also import { englishMissingTermGenerator } from '@accordproject/concerto-vocabulary'; is it the correct way of importing englishMissingTermGenerator functionalities in ui-concerto

Please let me know if I have not understood anything correctly or any suggestions, your help would be greatly appreciated :):

In my understanding both normalizeLabel and camelCaseToSentence are trying to do the same thing, except that normalizeLabel properly handles sequential capital letters, e.g. compare the output of f("customerSSN").
I say, that replacing the implementation of camelCaseToSentence with that from normalizeLabel and then exposing camelCaseToSentence in the VocabularyManager API would solve the problem.
Does that make sense?

camelCaseToSentence results Customer S S N whereas normalizeLabel produces  Customer SSN for the input of f("customerSSN")


Admin Separation and authentication

Is your feature request related to a problem? Please describe.
Admin Separation and authentication requested

Completed


Requires two clicks to focus on input after using uib-dropdown

When dropdown has focus iit requires two clicks to focus on a textbox.
Reproduction steps:

Open https://plnkr.co/edit/sxREBmeGwoFBQ4ZnOLIV?p=preview
Click on "dropdown 1"
Click on "common input"

Expectation:
The textbox has focus and you can start typing.
Actual:
The dropdown still has focus.
Angular: 1.5.8
UIBS: 2.2.0 & 2.4.0
Bootstrap: 3.3.7
Windows 10
Chrome 55
Also reported by other users here: https://github.com/angular-ui/bootstrap/issues/6364#issuecomment-271913855

Can you give more details as to how to reproduce it (steps of reproduction) and other info such as what browser/OS? I'm not seeing this in the Plunker, but I suspect it's because I don't understand the exact steps.

While I might not quite understand this, it sounds like #6414 might possibly be a fix for this.

Thanks @wesleycho for looking into this. I've now updated post number the reproduction steps and added expected and actual behaviour so hope that's clearer. No #6414 did not fix the issue. Undoing this commit fixes the issue for me https://github.com/yanhao1991/bootstrap/commit/cce00970f1efdcc7c7e741afca12a722024d9e16

see https://github.com/angular-ui/bootstrap/issues/6459


[T4A6][F09-B4] Chua Jun Wen

Ready for Review.

@JunWen991 Some comments added. Please close the PR after reading comments. Good job! :)


Errors in training

I'm trying to run the training on TF 1.3.0 and Python 3.5.2. Everything was normal up until this error at Epoch 280. After this error, the next Loss result is a NaN error. Every subsequent epoch returns "Loss nan"

INFO:root:Epoch 000280 | Loss 1.147085
/usr/local/lib/python3.5/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python3.5/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
return umr_maximum(a, axis, None, out, keepdims)
INFO:root:Epoch 000290 | Loss nan

I thought the model might still work so I let it run all the way through training, and tried to test an image against the model. I got the same error:

/usr/local/lib/python3.5/dist-packages/numpy/core/_methods.py:29: RuntimeWarning: invalid value encountered in reduce
return umr_minimum(a, axis, None, out, keepdims)
/usr/local/lib/python3.5/dist-packages/numpy/core/_methods.py:26: RuntimeWarning: invalid value encountered in reduce
return umr_maximum(a, axis, None, out, keepdims)

Any thoughts?

For reference the style and content images I used are here: https://imgur.com/a/4vz5fn6

Hey! Sorry this is so late. I haven't had my computer set up to run any these since I moved to Austin. Getting to it ASAP. I hypothesize this may have to do with the size of the images. Can you try running this with images around ~(512x512)px ? Thanks! Sorry again for the delay.

Oh, no worries. Thank you for getting back to me. As it happens I'm moving and my computer than do the stuff is in storage. Once I get a chance I will re-run these.
I will say that with the benefit of a couple month's additional experience since I submitted the support request I think you may be right.... but I'll get back to you in case there is a real bug here. Thank you!


Fix for Google module activating before latin-ext characters load

Added test string for latin-ext subset to fix issue with 'active' function firing before latin-ext characters were loaded.

This looks good. Thanks!


Add Next.js' App Router "Themes" installation example

This adds an example for installing "Themes" with Next.js' App Router
This pull request:

[ ] Fixes a bug
[ ] Adds additional features/functionality
[x] Updates documentation or example code
[ ] Other

Thanks for this @bennettdams , we just merged a change to recommend nesting within body which should also cover this.


switch to ProtVer 7

Builtins.serialiseData in PlutusTx drops \"Forbidden builtin function: (builtin serialiseData)\". After change ProtVer to 7 like in this PR it starts to work. Can we update protocol parameters?

@sadMaxim If you rebase I think I can bors it

rebased branch on master

bors r+

bors r+

bors r+

bors r+


[#1115] improvement: Unregister shuffle explicitly when application i…

What changes were proposed in this pull request?
For MR/Tez, as applications is stopped, we should unregister shuffle explicitly. There are no need to wait timeout.
Why are the changes needed?
Fix: #1115
Does this PR introduce any user-facing change?
No.
How was this patch tested?
test in yarn cluster

Codecov Report

Merging #1131 (7fb0f91) into master (0bde6ba) will increase coverage by 0.89%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1131      +/-   ##
============================================
+ Coverage     54.27%   55.17%   +0.89%
+ Complexity     2561     2093     -468
============================================
  Files           388      316      -72
  Lines         21985    14090    -7895
  Branches       1825     1266     -559
============================================
- Hits          11933     7774    -4159
+ Misses         9348     5898    -3450
+ Partials        704      418     -286

Files Changed
Coverage Δ

...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java
0.00% <0.00%> (ø)

... and 78 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Could we add UT for this pr?

Could we add UT for this pr?

I am confused about UT. This PR make effect in main. For now, I did not find a good way to construct UT yet.
I think if integration test pass, there will be no any problem.

Could we add UT for this pr?

I am confused about UT. This PR make effect in main. For now, I did not find a good way to construct UT yet. I think if integration test pass, there will be no any problem.

OK.


Add Types for CldUploadWidget options

Discussed in https://github.com/colbyfayock/next-cloudinary/discussions/139

@ruben00001 added a bunch here, hows this look? https://github.com/colbyfayock/next-cloudinary/pull/141

@ruben00001 added a bunch here, hows this look? #141

Looks great, nice one. There are of course lots more parameters as listed on the reference page but it'd be ridiculous to have to type them all out. It's a shame Cloudinary doesn't provide types!

I did type them all out 😬😂


Create codeql-analysis.yml

Let's take some time to check whether this is something we really need.

Sir, either we convert repo to private or we use all possible tools at disposal to check it's security.
No risk

I'm thinking to convert into private, if it's possible.

Making repo private will make the forks unlinked. Just talk to all before doing


Change load() to accept a model instead of a string path

In platforms other than web, simply passing a string path to the model won't work. Instead, we should rely on the developer consuming NSFWjs to require the model and pass it in to load().

right now it takes a PathIO object as well.  Maybe @mlaco who added this might be able to join in.
OR maybe it should handle a string to a local file path?

How can I load the model from the src folder instead of public folder in a react project?

That makes sense.  From what I've read, importing from src simply gives you the string value anyway though.
So the code below pulls from source, but gives the rendered string of the dynamic object.
import React from 'react';
import logo from './logo.png'; // Tell webpack this JS file uses this image

console.log(logo); // /logo.84287d09.png

Shouldn't that work?

@GantMan But the problem is that the load method accepts the folder path instead of the file path.
https://stackblitz.com/edit/react-c4416f?file=src%2FApp.js
I will submit a PR for this.

Can you test against master and if everything is OK I'll push a new minor version release?

k.  Sounds good.  I think I need to do some significant upgrades to dependencies to get CRA 5 working.  I need to add polyfills.  I started looking into this at one point but it's a complex upgrade.

Any ETA when we can expect the update on NPM for the file path?

Ping @GantMan.

yarn test is failing for some reason - which is stopping the release.  I'll look into it.


Explore a relational data warehouse lab script has an error and wont continue

Module: 00
Lab/Demo: 00
Task: 00
Step: 5
Description of issue
Repro steps:
just followed the steps here and I got stuck when I got the script error
https://microsoftlearning.github.io/dp-203-azure-data-engineer/Instructions/Labs/08-Explore-data-warehouse.html

don't know what happened but it worked on the 5th try


[Feature request] zero_increase to easily compute increase in new counters

Proposal
increase does report 0 for counters that are created during the time window, whatever their first value is. It's how it's designed and it's not a bug. However, it would be nice to have an alternative to increase, like zero_increase, that uses zero when the counter doesn't exist yet, so you could compute an increase from zero when a new counter is created.
An example is a metric with an error code as a label. For a given error code, it doesn't exist until the first error occurs. Unless you initialize all your metrics with all possible labels of course.
increase will return 0 even if the first value of the counter is higher than zero. If errors with the same label do not occur again in following time windows, you could notice that a new error code label is there, but the line chart would only show zero errors for it. If you want to see a spike in the chart when the error happens, you cannot use increase and have to rely on complex queries. zero_increase would easily offer this feature.
It's related to #1673, which has been locked by a bot.

This is a dupe of #1673, your proposal has the exact same issues as discussed there.

#1673 is a bug, closed, and locked. Mine is feature request.

What you're requesting is essentially identical to #1673.

Yes, that's why I link the feature request to the issue #1673. I understand now that you don't want to have this feature request and prefer to keep the conversation on #1673. But it's closed and locked.
Usually I put a 👍 on issues and move on, but since it's locked and you closed the issue after you got interesting suggestions, I thought I could help by making a feature request with a summary. I was wrong, that's fine.


VS Error List doesn't show errors from build failure

Build output lists a couple of errors:

Error List doesn't show these errors (just other unrelated warnings):

Restarting Visual Studio to see if it's helpful... fixes the problem.

@ardalis few quick questions:

Do you have Full solution analysis enabled? https://msdn.microsoft.com/en-us/library/mt709421.aspx
If not, then we will only display intellisense diagnostics for open files. Do you recall if you had ValueObject.cs open when you didn't see the errors in the error list?
Can you try change the error list combo box from "Build + Intellisense" to "Build" and verify you can see the errors?

No it isn't. I just checked. This was a new install of VS2017.
Yes, the file was open. I didn't show it in my first 2 screenshots but the same files were open before and after the VS restart.
I've since fixed the errors. Causing them to reappear (by commenting out this line in my project file:

)
seems to work as expected. I'm not immediately able to repro the behavior where the errors aren't shown in the Error List window.

Tagging @heejaechang.
Heejae, seems like a race condition in our intellisense diagnostics no getting updated. @ardalis is using the latest D15Rel build, so all your latest RC.3 Roslyn fixes should be in the build.

I am moving this issue to https://github.com/dotnet/roslyn/issues/16545 as this is an issue with Roslyn diagnostic service.


Fix#462 Adding Bouncy Number Calculator

Fixes Issue🛠

Closes # #462
Description👨💻

Adding Bouncy Number Calculator
Type of change📄

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷

https://github.com/Rakesh9100/CalcDiverse/assets/125949765/74fa06cc-0dff-4ae6-a130-7a25f4b30d10
closed
#462

check this PR


Support Next v14

npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/next-typesafe-url
npm ERR!   dev next-typesafe-url@"*" from the root project

I'll fix this today
Thanks


transaction locks: replace mutex with rocksdb transaction

there's a test failure because database opened in optimistic transaction mode doesn't support delete_range operation
and latter is required by the pruning job. Is it ok to replace delete_range in pruning with explicit get keys and delete of individually listed keys?


Publish rustc-demangle-capi on crates.io

Right now, rustc-demangle-capi only exists as a subdirectory of this repository. In Android, we've been using crates.io as our primary source of third party packages, and it would be nice for rustc-demangle to not be an exception.
I could upload it myself, but I figured that Crichton should probably own the package.
For other users, making this crate available would also make it easier to pull into their builds, whether through a rules_rust style build in Bazel or by invoking cargo to build the .a or .so they need from crates.io or a cargo vendor directory. It also makes sense given https://github.com/rust-lang/rfcs/pull/3028 which makes these possibly useful artifacts to a Cargo build.

Sure thing! Published now

Hi!
I am a bit confused with regards to two points:

What does this change add/provides?
What is now the preferred way to package the C API of rustc-demangle? I'm packaging it for the AUR and I'm not sure whether or not I should switch to this new crate.

Thanks

This published the crate on crates.io. You can use it if you'd like, you also don't have to use it. I don't know enough about packaging to advise how to package this.

Thanks for the answer. :)


Running DEIS in a standalone network

Many organizations runs a standalone network outside the internet, or connected behind firewalls etc. DEIS gets many things from outside the system (docker registry, installation in build-packs, github ...), so it isn't possible to deploy in such places. is there any way to install DEIS in a "standalone mode"? is that something you consider?
Thanks

After installing deis, everything except for the build process can be run in a standalone network. You can use deis pull to fetch images from a registry within your network. You can also reference images stored inside your internal network in your Dockerfile, so essentially the only workflow that won't work in an isolated environment is buildpacks.
Makes sense?

Then again, you can also use deis config:set BUILDPACK_URL=git://myinternalgithost.com/mybuildpack in a firewall environment so installing deis internally is technically possible.

Although this raises the question of how Deis components themselves get installed on such a network.  Public registries such as Docker Hub and quay.io are the only available distribution mechanisms.  "Deis on a stick," for instance, is not currently possible.

an organization can deploy a registry proxy and configure all the docker daemons to go to that proxy for fetching images from public registries.

@aespinosa I was interpreting it as a case where there was a prohibition against use of any public registry (proxied or otherwise).  I probably read into that too much.

ping @udragon. Did the following comments answer your question?

Yes, thank you. You may close the issue.


Error when quantizing GPT2-XL

When running examples/quantization/basic_usage_gpt_xl.py an error occurs during the model packing:
2023-05-22 04:08:34 INFO [auto_gptq.quantization.gptq] duration: 0.16880011558532715
2023-05-22 04:08:34 INFO [auto_gptq.quantization.gptq] avg loss:<PHONE_NUMBER>5390625
2023-05-22 04:08:34 INFO [auto_gptq.modeling._base] Quantizing attn.c_proj in layer 48/48...
2023-05-22 04:08:34 INFO [auto_gptq.quantization.gptq] duration: 0.16850876808166504
2023-05-22 04:08:34 INFO [auto_gptq.quantization.gptq] avg loss: 18.650110244750977
2023-05-22 04:08:35 INFO [auto_gptq.modeling._base] Quantizing mlp.c_fc in layer 48/48...
2023-05-22 04:08:35 INFO [auto_gptq.quantization.gptq] duration: 0.16927051544189453
2023-05-22 04:08:35 INFO [auto_gptq.quantization.gptq] avg loss:<PHONE_NUMBER>
2023-05-22 04:08:35 INFO [auto_gptq.modeling._base] Quantizing mlp.c_proj in layer 48/48...
2023-05-22 04:08:36 INFO [auto_gptq.quantization.gptq] duration: 0.6983904838562012
2023-05-22 04:08:36 INFO [auto_gptq.quantization.gptq] avg loss: 1028.072509765625
2023-05-22 04:08:36 INFO [auto_gptq.modeling._utils] Packing model...
2023-05-22 04:08:36 INFO [auto_gptq.modeling._utils] transformer.h.0.attn.c_attn
Traceback (most recent call last):
  File "/AutoGPTQ/examples/quantization/basic_usage_gpt_xl.py", line 93, in <module>
    main()
  File "/AutoGPTQ/examples/quantization/basic_usage_gpt_xl.py", line 67, in main
    model.quantize(traindataset, use_triton=False)
  File "/home/user/miniconda3/envs/pytorch2/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/user/miniconda3/envs/pytorch2/lib/python3.10/site-packages/auto_gptq/modeling/_base.py", line 350, in quantize
    pack_model(
  File "/home/user/miniconda3/envs/pytorch2/lib/python3.10/site-packages/auto_gptq/modeling/_utils.py", line 110, in pack_model
    qlayers[name].pack(layers[name], scale, zero, g_idx)
  File "/home/user/miniconda3/envs/pytorch2/lib/python3.10/site-packages/auto_gptq/nn_modules/qlinear_old.py", line 96, in pack
    (linear.weight.data[:, idx] + scale_zeros[g_idx]) / self.scales[g_idx]
RuntimeError: The size of tensor a (1600) must match the size of tensor b (4800) at non-singleton dimension 0

The error doesn't occur when desc_act=False is changed to True. Note that the error occurs with desc_act=False even when group_size=-1
The version of AutoGPTQ is the lastest one d4011d29c623e739e91b842a87fce62a38c6e538
Environment: Ubuntu 22.04, pytorch 2.0.0, CUDA 11.8, transformers 4.29.2, GPU: 4090

I meet the same problem when I try to use AutoGPTQ to quantize my model. Is there any solution to solve it now?


Fix screenshots on /api/api-keys

These show a super-ancient version of the UI:

(There's probably other cleanup that would be valuable on this page)

@zulipbot force claim.

@zulipbot claim --force

@zulipbot claim --force

@zulipbot claim

Still working

Fixed via #9368.


Updating registration documentation.

Adding an overview of the registration framework and link to it from
all the examples.
Change-Id: I2c681cdf10937fcc35ec82ba9a53287a9bc06cf2

I'm going to take a pass at this document today...

I have not gotten a change to make a pass at this. This is clearly an improvement, so I am going to merge.


Support gifs

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
It would be great to be able to have gifs in blog posts. At present, using CleanShotX to generate the gif, only a 7s gif with the lowest resolution is supported. This is a regression from previously being able to upload gifs.
Affected area/feature

Blogs

A few notes..

this isnt a regression, you can upload gifs if you insist they will eventually break the build as they did last time since hugo has a limit on the amount of data it can process
the gif file format is intended for short animations and low-qualify video
i do not believe the gif file format is best to support your needs of long high-quality video
i highly recommend mp4, or mov, or various other video formats
our current flow for videos is to upload to youtube and then use their embed code

if we step back from the request to support gifs, you can describe your need abstracted from the file format, then im sure folks can suggest the best file format for your needs.

Closing as this is technically supported, and we're generally using MP4s as well now.


fatal: Unable to find remote helper for 'keybase'

How exactly does one git push or git clone with Keybase encrypted repository?
I am using latest OSX and Keybase and git 2.14.2.

Hi @ericjarvies.  The latest Keybase comes with a binary installed in /usr/local/bin/git-remote-keybase.  As long as /usr/local/bin is in your $PATH, then git on the command line should find it and use it for keybase remote URLs.
Are you using git from the command line?  Is /usr/local/bin in your $PATH?

Hmm... it's not in my /usr/local/bin folder.  Do I need to download and [re]install the latest version of Keybase in order for git-remote-keybase to install?

What version are you running?  Did you disable auto-updates?  Maybe try keybase update check?

NeedUpdate:false
My default OSK installation of git is in /usr/bin, but I upgraded git using Homebrew, and all of my brew installations are installed in my home folder (e.g.- ~/homebrew/bin/), and I renamed /usr/bin/git to /usr/bin/git-apple and created a git alias in /usr/bin/ that points to ~/homebrew/bin/, and of course /usr/bin/ and /usr/local/bin/ are in my path.

Where might I grab git-remote-keybase?

It's in the latest OSX package.  You can try downloading it manually from our website I guess.  Or you can do a keybase log send and we can see what version you're running.

It seems Keybase is not creating aliases in /usr/bin/ or /usr/local/bin/ to the Keybase.app/SharedSupport/bin/ folder for the various other files, e.g.- git-remote-keybase, kbfs, kbnm, and updater, assuming all of them need aliases like keybase does.

Hmm, I'm not actually an expert on the layout of the OSX installed files.
@cjb: any ideas here?  Is there supposed to be a symlink to the git helper in /usr/local/bin?

Logs: a25a940c7939c2bca91fdf1c

Something like this;
sudo ln -s /Applications/Keybase.app/Contents/SharedSupport/bin/git-remote-keybase /usr/local/bin/git-remote-keybase?

Yup, that did the trick;
git clone keybase://private/ericjarvies/password_list
Cloning into password_list...
Initializing Keybase... done.
Syncing with Keybase... done.
Syncing encrypted data to Keybase: (100.00%) 2.97/2.97 KB... done.
warning: You appear to have cloned an empty repository.

So, a symbolic link needs to be created when Keybase performs the upgrade?  e,g,-
sudo ln -s /Applications/Keybase.app/Contents/SharedSupport/bin/git-remote-keybase /usr/local/bin/git-remote-keybase
and what about these;
kbfs
kbnm
updater
?

I can confirm I ran into this too using a fresh install of keybase and having similar homebrew setup.
I was able to originally clone a repo, but calling git pull showed the error from the OP.
I also did the ln -s /Applications/Keybase.app/Contents/SharedSupport/bin/git-remote-keybase /usr/local/bin/git-remote-keybase but did not need to include sudo when running the command.
After that git pull worked again.

In my case it was because of 2 things:

No symlinks for Keybase utils in /usr/local/bin;
No symlink for /usr/bin/git in /usr/local/bin/.


docs.rs failed to build 0.3.0

See https://docs.rs/crate/jemallocator/ for docs.rs error.

Probably incorrect Cargo.toml:
rustdoc-args = [ "--cfg jemallocator_docs" ]

might need to be updated to something else.


Update live website url in readme.md

Update live website URL to alphabyte.info in the readme.md

@NeelParihar Can I work on the issue?

@NeelParihar Can I work on the issue?

Yes you can

Yes you can

@NeelParihar I have created a PR- #16 Updated live url in README.md
Could you please review it.

@NeelParihar I have created a PR- #16 Updated live url in README.md
Could you please review it.


x/pkgsite: expect search for x509 to find the stdlib package

What is the URL of the page with the issue?
https://pkg.go.dev/search?q=x509
What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0
What did you do?

Search for "x509" in the search box.
What did you expect to see?
The crypto/x509 package (https://pkg.go.dev/crypto/x509) at the top or at least near the top
What did you see instead?
The 10 first results don't contain crypto/x509:
github.com/google/certificate-transparency-go/x509

Package x509 parses X.509-encoded keys and certificates.
Version: v1.1.1 | Published: Oct 6, 2020 | Imported by: 373 | License: Apache-2.0
k8s.io/apiserver/pkg/authentication/request/x509

Package x509 provides a request authenticator that validates and extracts user information from client certificates
Version: v0.22.0 | Published: today | Imported by: 132 | License: Apache-2.0
github.com/google/certificate-transparency-go/x509util

Package x509util includes utility code for working with X.509 certificates from the x509 package.
Version: v1.1.1 | Published: Oct 6, 2020 | Imported by: 122 | License: Apache-2.0
github.com/zmap/zcrypto/x509

Version: v0.0.0-...-3c30cdc | Published: 2 days ago | Imported by: 97 | Licenses: Apache-2.0, ISC, MIT
github.com/Cloud-Foundations/Dominator/lib/srpc

Package srpc is similar to the net/rpc package in the Go standard library, except that it provides streaming RPC access, TLS support and authentication and authorisation using X509 client certificates.
Version: v0.0.0-...-a725685 | Published: May 24, 2021 | Imported by: 258 | License: Apache-2.0
github.com/google/certificate-transparency-go/x509/pkix

Package pkix contains shared, low level structures used for ASN.1 parsing and serialization of X.509 certificates, CRL and OCSP.
Version: v1.1.1 | Published: Oct 6, 2020 | Imported by: 63 | License: Apache-2.0
github.com/cetcxinlian/cryptogm/x509

Package x509 parses X.509-encoded keys and certificates.
Version: v0.0.0-...-f3ca35d | Published: Aug 6, 2020 | Imported by: 25 | License: Apache-2.0
github.com/Hyperledger-TWGC/tjfoc-gm/x509

crypto/x509 add sm2 support
Version: v1.4.0 | Published: Jan 4, 2021 | Imported by: 47 | License: Apache-2.0
github.com/fabric-creed/cryptogm/x509

Package x509 parses X.509-encoded keys and certificates.
Version: v0.0.0-...-9b28f0c | Published: Jun 21, 2021 | Imported by: 15 | License: Apache-2.0
github.com/zmap/zcrypto/x509/pkix

Package pkix contains shared, low level structures used for ASN.1 parsing and serialization of X.509 certificates, CRL and OCSP.
Version: v0.0.0-...-3c30cdc | Published: 2 days ago | Imported by: 27 | Licenses: Apache-2.0, ISC, MIT

Duplicate of #47555.


WIP: Add doc for vSphere CSI Migration

This PR adds a doc for the vSphere CSI Migration.

The following PR that implements this feature needs to get merged first:
https://github.com/kubernetes/kubernetes/pull/90911
/hold

/milestone 1.19

kubernetes/kubernetes#90911 is merged.
/hold cancel

/assign @msau42

Updated feature state to Beta.

Hi @xing-yang 👋 , Friendly reminder that docs should be reviewed and ready to be merged by July 16th. Thanks!

/lgtm

lgtm cc @misterikkit @gnufied for anything else to be added

Page preview:
https://deploy-preview-21444--kubernetes-io-vnext-staging.netlify.app/docs/concepts/storage/volumes/

Comments are addressed.

Hi everyone, 👋 1.19 docs shadow here, can we get another quick look as content has changed based on feedback and get a lgtm from both tech/docs?
@msau42 @misterikkit @gnufied @divyenpatel @kbhawkey @sftim

from docs
/lgtm

@msau42 can we get a tech lgtm on this PR? Thanks :)

/lgtm

Hi @savitharaghunathan, this PR gets merged into dev-1.19 branch, but it is not in the master branch yet:
https://github.com/kubernetes/website/blob/master/content/en/docs/reference/command-line-tools-reference/feature-gates.md
Will this get ported to the master branch automatically?  Thanks.

Hello @xing-yang . This change will become available on the master branch once v1.19.0 is released.

Thanks @kbhawkey!

Hi @kbhawkey, another question: we forgot to add a description of the new feature gate to the doc PR which is merged in dev-1.19.  I believe we have passed the deadline to submit anything to dev-1.19?  Should I submit a PR to master after 1.19 release?
https://github.com/kubernetes/website/blob/dev-1.19/content/en/docs/reference/command-line-tools-reference/feature-gates.md#list-of-feature-gates-feature-gates

@savitharaghunathan I believe there's no actual deadline for contributions; is that right?

@savitharaghunathan I believe there's no actual deadline for contributions; is that right?

@sftim 👋 It's tricky. This release has so much time between docs final deadline and release. During the usual timelines, my understanding is that everything gets merged into master after release.
However, under given circumstances, I feel all the critical bug fixes related to features in 1.19 should go into dev-1.19. Hope it answers your question :)

Thanks @savitharaghunathan @sftim!  Will submit a PR to dev-1.19.


The download training set is inconsistent to paper description

Hi, I have downloaded the training set from the link you provide. The training set includes 6642 fire images and 8456 nofire images. However, they are smaller than the training set for full-frame binary fire detection problem described in your publication. Could you tell me where I can download other images? Thanks a lot.

Hello, I can't get the flame dataset from the link you gave. Is the display empty?thank you very much

嗨，我已从您提供的链接下载了培训集。训练集包括6642个火图像和8456个nofire图像。但是，它们小于您的出版物中描述的全帧二进制火灾探测问题的训练集。你能告诉我在哪里可以下载其他图片吗？非常感谢。

你好，原链接不用下载了。您能把下载的数据集分享一份给我吗？

Hi, I have downloaded the training set from the link you provide. The training set includes 6642 fire images and 8456 nofire images. However, they are smaller than the training set for full-frame binary fire detection problem described in your publication. Could you tell me where I can download other images? Thanks a lot.

Hello, the original link does not need to be downloaded. Can you share a copy of the downloaded data set with me?

Sorry for the delay on fixing this.
Please download the full dataset from https://durhamuniversity.box.com/s/bxp9bvfcz3anb3lk2f4f3z3rtqyug5b1
This is a temporary solution. No login required, we have updated the record at: https://collections.durham.ac.uk/files/r2d217qp536#.XH0m3JzgrOG to say "Please download this dataset from DU Box as follows:  https://durhamuniversity.box.com/s/bxp9bvfcz3anb3lk2f4f3z3rtqyug5b1 Note: Login is not required."
This dataset contains all of the images we used for the work including the full images and the superpixels images. It is 10.5Gb.

@tobybreckon
Hi, the link of DU Box can not be opened. Is there any other link to get the full training dataset? Thanks a lot.

Just tested this from firefox, link works for me.


Cannot successfully register user and domain when using nvm

Expected Behaviour
Running sudo certme user:register $(whoami) in the setup steps should update the certme's config.json and should return Registering user <username> on the system
Actual Behaviour
Running the command throws an error.
/usr/bin/node: not found
Steps to Reproduce

Remove any node versions from your Linux PC.
Install nvm.
Install a node version using nvm.
Install certme.
Follow steps in README.md in the Getting Started section.

Hey @LynchEntrostat thanks for reporting this! I'm thinking it might be time to look at something that builds a binary file, maybe golang? That way, we don't need to depend on the user having node installed to run the cli. I'll draw up a roadmap, let me know if you're keen to contribute :smile:!

Hey @LynchEntrostat thanks for reporting this! I'm thinking it might be time to look at something that builds a binary file, maybe golang? That way, we don't need to depend on the user having node installed to run the cli. I'll draw up a roadmap, let me know if you're keen to contribute smile!

Hello @Kerren-Entrostat I will be keen to learn how to do that. 😅

Hey @LynchEntrostat I've pushed a fix for short term, if you check the releases there is a .deb file there. Could you try install that and see if it resolves your issues please :)?

I'm going to close this for now, I've done some tests on my side and it seems all good. Let me know if there are any issues, thanks again for reporting @LynchEntrostat :smile:

Hello @Kerren-Entrostat I will test it out and update you. Thank you!


spotifyd: new package at 0.2.20

Description of package
Spotifyd allows third party Spotify clients to be able to stream music without relying on the official client
Checklist

[x] Latest upstream version.
[x] I agree to maintain this package (required).
[x] I agree to notify KISS if I can no longer maintain this package (required).

Thanks. :+1: