BULK VALIDATION, description, column headers, html to markdown

Category

[x] Content fix
[ ] New article

Related issues
no issue number - part of the Validation clean-up efforts.
What's in this Pull Request?
This PR fixes 15 issues across 8 files.

I'm following up on this PR. Have you had a chance to review? cc: @v-emilypr


Add HarvestCraft compatibility?

See the following image: http://imgur.com/a/zDFvZ
They just float in the air. Any chance you can add compatibility for HarvestCraft?
https://minecraft.curseforge.com/projects/pams-harvestcraft

Hello,
yes I will look into it.

Done.

Wow, will update. Thanks! <3


Why CULane dataset replication is not successful？

When reproducing the CULane dataset, the evaluation metrics Normal, Crowded, Crowded, Crowded, Crowded, Arrow, Curve, Cross, and Night could not be successfully reproduced

When reproducing the CULane dataset, the evaluation metrics Normal, Crowded, Crowded, Crowded, Crowded, Arrow, Curve, Cross, and Night could not be successfully reproduced

Could you provide some detail in your setting?

When reproducing the CULane dataset, the evaluation metrics Normal, Crowded, Crowded, Crowded, Crowded, Arrow, Curve, Cross, and Night could not be successfully reproduced

Could you provide more details about your setting?

I have the same issue. Whether it's training or testing, when loading the annotations for the CULane dataset, the following error is reported.

Can you check whether variant 'predictions' and 'annontation' is properly loaded before this line?

为什么叫起点生成单元，而不叫锚生成单元。这里最终生成的是锚呀。

Hello author, may I ask why this error keeps being reported? I checked the permission issue and it should be fine

 Hello author, may I ask why this error keeps being reported? I checked the permission issue and it should be fine

it looks like the error is related to your operation system, we haven't tested our code on Windows yet, but it works fine on Linux.


First commit to nodeProxy

Investigating nodeProxy as potential conformance endpoint tests

@spiffxp said that if we explore proxy and write a good parameterised test for all proxy, we would cover A-LOT of endpoints.
I'll take this on myself.
/assign @hh

addressed by Stephen in Q3


typos

[ ] replace 'timeseries' with 'time series'
[ ] replace 'the processor cores within the machine' with 'the machine's processor cores'


Using SqlQuerySpec with CosmosClient

Currently, we can use SqlQuerySpec with the DocumentClient. But with sdk version 3, we are recommended to use CosmosClient.
Is there any way to use SqlQuerySpec with the CosmosClient?
The problem of using DocumentClient is that it returns IQueryable instead of IQueryable which we expect from CosmosClient.
Please let me know if we can use SqlQuerySpec with CosmosClient. And if not, why isn't it supported?

Is QueryDefinition what you're after ? If not, can you share the code you're trying to port.
(also if you put tick marks around IQueryable<T> it doesnt drop the <T> bit - if it's about Document support, probably best to have a second question - Do as I say, not as I do :) )

If that doesn't answer your question please re-open the issue with a sample of what you are trying to do.


I will kindly give my respects to you.


Update the holopin.yaml to use the runtime badge

Update the .github/holopin.yaml file with the following info to set the default Holopin badge for this repo:
organization: dapr
defaultSticker: clrqh1xny39170fl75cawk0h5
stickers:
  -
    id: clrqh1xny39170fl75cawk0h5
    alias: runtime-badge

Once this is in place, maintainers can award contributors via the Holopin Bot by mentioning the contributors' username in a PR comment when the PR is accepted: @holopin-bot @username

Please label this as a good first issue.

@marcduiker I would like to work on this. Feel free ro assign it to me.

/assign


Digital Twins - Core Samples issue

Section link:

Reason:
listIncomingRelationships(java.lang.String, com.azure.core.util.Context) is not public in com.azure.digitaltwins.core.DigitalTwinsAsyncClient. Cannot be accessed from outside package.
Suggestion:
Change to listIncomingRelationships(twinId)
@josefree, @johngallardo and @sjiherzig for notification.

Investigating.

https://github.com/Azure/azure-sdk-for-java/pull/30382


"Encountered a point with a larger stamp than the last point in the cloud"

Hey, i am getting this fatal error when launching the pure localization mode live, with VLP-16.
Its happen sometimes and shutting down the node.
[FATAL] [1604575697.682604927]: F1105 13:28:17.000000 10916 msg_conversion.cc:273] Check failed: point.time <= 0.f (1.27498e-06 vs. 0) Encountered a point with a larger stamp than the last point in the cloud.
Thanks!

Have you solved the problem?why?

I “Filtered” the frames that contained this problem and it is work great.
I don’t understand why the original code kills the node on this scenario when they could just throw this specific pointcloud frame sample.

Redownload and catkin_make

Thank's but I've already fixed it, I think there is a deeper problem that whenever one sensor sample does not meet a particular requirement it kills the node instead of throwing away this specific sample.
I will try to fix it in the original code and pull request it.

Hi，this problem reappeared. Can you share your code to fix this problem?

We'v met same problem, is there any option that we can use to let cartographer ignore the topic instead of throw crashing?

Me, too. I also get this fatal error! Could some know how to solve it for now?

@Oburshan Do you have any way to solve this problem?

@patcmorneau the method which is given by Nova555 👍 Modify " {Eigen::Vector3f{point.x, point.y, point.z}, point.time}); " to " {Eigen::Vector3f{point.x, point.y, point.z}, 0.f}); " with msg_conversion.cc is work for me.

Although cartograher is very good at code style and software architecture. for this timestamp processing, it is bad

removed all topics but imu and lidar from my bag and the error is gone now ... will see if i can generate a map now


frontends: add GTK frontend

I understand that yet another frontend might be undesirable from a maintenance POV but I think it is very relevant. Depending on your desktop environment or setup, Qt might feel out of touch. There are some drawback from the lack of system-wide configuration, for eg. I have a HiDpi display and Qt honestly does kind of a bad job dealing with it, it also completely breaks the look and feel of my applications but :man_shrugging:. I find GTK quite easy to work with, all things considered, and I do not think it would be that much of a maintenance burden. With that said, I would available to maintain this frontend if you want, I don't want to put extra burden on you :blush:.
Right now only the data streaming is implemented, the packet details and hex view are missing. You can merge as is or wait until I add the missing components.

Okay, I think it's finished :grin:

@Qyriad friendly ping :slightly_smiling_face:

Thank you for the poke. And, this looks pretty awesome; thank you! I have 0 knowledge of GTK programming, so I doubt this will be maintained by me, meaning that officially this will be Unsupported, but I'm not against having it in the repo.
That being said, I haven't used a high DPI display in a while, but I thought Qt did actually have reasonable DPI/scaling options/handling, just with environment variables, which if I recall correctly is how you do that with GTK too. I don't think that's a reason to not merge this, but I'm curious what your DPI issues are, since I thought Qt5 handled that well—well, at least about as well as DPI handling gets on Linux—and I'd like to know if I should open an issue for it and look into possible ways to get the Qt UI to handle it better.
I also personally haven't really noticed ViewSB feeling particularly out of place style-wise, even though I use a GTK-centric environment (Gnome)—or at least not any more out of place than most modern applications like Chromium, Firefox, Telegram, et cetera, or even my terminal emulator (Alacritty).
Anyways, back to this particular PR. In my preliminary testing, I found that this UI crashed no matter what backend I used, albeit with different error messages. For example, running it with the usbmon backend and then plugging in a new device crashes with:
Process GtkFrontend process:
Traceback (most recent call last):
  File "/usr/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/qyriad/code/gsg/viewsb/viewsb/ipc.py", line 92, in _subordinate_process_entry
    task.run()
  File "/home/qyriad/code/gsg/viewsb/viewsb/frontends/gtk/__init__.py", line 158, in run
    self.handle_communications()
  File "/home/qyriad/code/gsg/viewsb/viewsb/frontend.py", line 225, in handle_communications
    self.handle_incoming_packet(packet)
  File "/home/qyriad/code/gsg/viewsb/viewsb/frontends/gtk/__init__.py", line 146, in handle_incoming_packet
    len(packet.data),
TypeError: object of type 'NoneType' has no len()

If you look at the Qt frontend in _create_item_for_packet(), I have length = len(viewsb_packet.data) if viewsb_packet.data is not None else '' precisely to solve this problem, since dataless ViewSBPackets (which can represent e.g. dataless transactions or Setup Transfers without a data stage) exist. And there is a difference between a length of 0 and No Length.
I'm curious what backend you tested this on, since that might help me figure out what additions need to be made to handle the quirks of other backends. Unfortunately, such quirks are a natural consequence, since different backends are capable of producing different levels of detail of analysis.
The other thing is that, unless I'm mistaken, this doesn't show the subordinate packets (the transactions that make up a transfer, and the packets that make up those transactions), which I think is one of the more useful things a USB analyzer should offer, since the nested structure of USB requests/transfers/transactions/packets is one of the more unclear aspects of USB, since e.g. libusb doesn't go any further down than the transfer level.

Sorry for the delay! I probably messed it up when commiting.
I think I am going to close this for now. I would definitely like to have an alternative graphical backend to Qt but I feel like we could probably do a bit better than GTK. I will assess and figure out what I think might be better.


NPE fix for currentActivityReference

currentActivityReference is initialized only on Activity starts or when
init session called internally. This crash is caused by application
calling branch feature such as “userActionComplete” before initsession
happens
@aaustin @Sarkar

:+1:

:+1:


Support parsing of concatenated PCAPs

This PR equips the pcap parser with the capability to parse a stream of concatenated PCAPS.
This means that you can now do the following:
cat *.pcap | tenzir 'read pcap'

I know it's still in draft, but some very early testing, some compilation error on my side
$ docker build . -f Dockerfile --target tenzir-node-de
[...]
FAILED: libtenzir/CMakeFiles/libtenzir_builtins.dir/builtins/formats/pcap.cpp.o
/usr/bin/g++-12 -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DFMT_SHARED -DSIMDJSON_T
HREADS_ENABLED=1 -DSPDLOG_COMPILED_LIB -DSPDLOG_FMT_EXTERNAL -DSPDLOG_SHARED_LIB -DTENZIR_ENABLE_BUILTINS -DXXH_ACCEPT_NULL_INPUT_POINTER=1 -
DXXH_INLINE_ALL=1 -I/tmp/tenzir/build/libtenzir/include -I/tmp/tenzir/libtenzir/include -isystem /tmp/tenzir/libtenzir/aux/caf/libcaf_core -i
system /tmp/tenzir/build/libtenzir/aux/caf/libcaf_core -isystem /tmp/tenzir/libtenzir/aux/caf/libcaf_io -isystem /tmp/tenzir/build/libtenzir/
aux/caf/libcaf_io -isystem /tmp/tenzir/libtenzir/aux/caf/libcaf_openssl -isystem /tmp/tenzir/build/libtenzir/aux/caf/libcaf_openssl -isystem
/tmp/tenzir/build/libtenzir/libtenzir-fbs/include -isystem /tmp/tenzir/libtenzir/aux/simdjson/include -O3 -DNDEBUG -ftemplate-backtrace-limit
=0 -fno-omit-frame-pointer -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -Wno-unknown-warning -Wall -Wextra -pedantic -Werror=switch -Werror=
odr -Wundef -Wno-redundant-move -Wno-error=bool-compare -fdebug-prefix-map=/tmp/tenzir=. -std=gnu++20 -MD -MT libtenzir/CMakeFiles/libtenzir_
builtins.dir/builtins/formats/pcap.cpp.o -MF libtenzir/CMakeFiles/libtenzir_builtins.dir/builtins/formats/pcap.cpp.o.d -o libtenzir/CMakeFile
s/libtenzir_builtins.dir/builtins/formats/pcap.cpp.o -c /tmp/tenzir/libtenzir/builtins/formats/pcap.cpp
In file included from /tmp/tenzir/libtenzir/include/tenzir/detail/logger.hpp:19,
                 from /tmp/tenzir/libtenzir/include/tenzir/logger.hpp:42,
                 from /tmp/tenzir/libtenzir/include/tenzir/pattern.hpp:13,
                 from /tmp/tenzir/libtenzir/include/tenzir/data.hpp:20,
                 from /tmp/tenzir/libtenzir/include/tenzir/concept/convertible/data.hpp:16,
                 from /tmp/tenzir/libtenzir/include/tenzir/argument_parser.hpp:11,
                 from /tmp/tenzir/libtenzir/builtins/formats/pcap.cpp:9:
/tmp/tenzir/libtenzir/builtins/formats/pcap.cpp: In instantiation of 'tenzir::plugins::pcap::{anonymous}::pcap_parser::instantiate(tenzir::ge
nerator<caf::intrusive_ptr<tenzir::chunk> >, tenzir::operator_control_plane&) const::<lambda(auto:161&, tenzir::generator<caf::intrusive_ptr<
tenzir::chunk> >, bool)> [with auto:161 = tenzir::operator_control_plane]':
/tmp/tenzir/libtenzir/builtins/formats/pcap.cpp:319:16:   required from here
/tmp/tenzir/libtenzir/builtins/formats/pcap.cpp:267:38: error: cannot bind packed field 'packet.tenzir::pcap::packet_record::header.tenzir::p
cap::packet_header::captured_packet_length' to 'unsigned int&'
  267 |                        packet.header.captured_packet_length);
      |                        ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
/tmp/tenzir/libtenzir/builtins/formats/pcap.cpp:266:11: note: in expansion of macro 'TENZIR_DEBUG'
  266 |           TENZIR_DEBUG("reading packet data of size {}",
      |           ^~~~~~~~~~~~
cc1plus: note: unrecognized command-line option '-Wno-unknown-warning' may have been intended to silence earlier diagnostics

@netantho fixed now. Turns out GCC treats packed structs differently.

@netantho fixed now. Turns out GCC treats packed structs differently.

Thanks, indeed fixed. Still crunching the numbers but early results suggest a nice performance boost, thanks so much @mavam and team! :pray:

@dominiklohmann this is ready from a functional perspective. I'm still getting hangs in the executor (which you already know). Here's what causes the hang for me:
cat tenzir/integration/data/pcap/vlan-* > /tmp/concatenated-trace.pcap
tenzir 'read pcap -e' < /tmp/concatenated-trace.pcap

Other than that, it looks like @netantho got this working already.

This works flawlessly now after c3d4064.

Code looks good to me and this works well in practice now.

Confirming that it works, even another ~30% perf contained with this afternoon's commits. Command tested:
cat *.pcap | /usr/bin/docker run --network=host --mount type=bind,source=`pwd`,target=/mnt -i $1 --config=/mnt/tenzir.yaml "read pcap | extend provenance_provider=\"$provider\", provenance_region=\"$region\", provenance_sensor=\"$sensor\" | import"

I'm seeing the number of events increased with:
/usr/bin/docker run --network=host --mount type=bind,source=`pwd`,target=/mnt -i 206b21c05cbd "export | summarize count(.)"

Also seeing expected output with:
/usr/bin/docker run --network=host --mount type=bind,source=`pwd`,target=/mnt -i 206b21c05cbd "export | head"

That was a great perf improvement PR: Seeing 2x improvement on a set of 2-15MB pcap files, and fewer stuck pipelines (maybe even disappeared)

fewer stuck pcap import pipelines (maybe even disappeared at one import thread at a time)

That should be gone entirely as of https://github.com/tenzir/tenzir/pull/3513/commits/c3d406415736c1bfae17b209bac70d0ed2aec33d which I pushed onto this PR.


Unable to provide ImageToDeploy and AcrName for docker token authentication.

It is no longer possible to provide ImageToDeploy and AcrName arguments for a pre built image that requires authentication to access.
According to the documentation, if ImageToDeploy requires authentication, then ArcName can be provided to authenticate to the registry using token authentication (if AcrUserName and AcrPassword  are not provided).
This is also in the code:
CA_ADO_TASK_ACR_ACCESS_TOKEN=$(az acr login --name $(acrName)--output json --expose-token --only-show-errors | jq -r '.accessToken');
 docker login acrName.azurecr.io -u 00000000-0000-0000-0000-000000000000 -p $CA_ADO_TASK_ACR_ACCESS_TOKEN > /dev/null 2>&1'.

With the new changes made, both appSourcePath and acrName are now required together. When these 2 are provided, the tasks attempts to builds the image from source and deploys to the registry.
This does not seem like an intended change. It should be that if appSourcePath is provided, then acrName is required, but if acrName is provided, appSourcePath is not required.

Hi my existing code also breaks, this was working yesterday perfectly when an existing image is pull fronm the ACR and add it to the ACA

task: AzureContainerAppsRC@0
displayName: Build and deploy Container App
inputs:
azureSubscription: ''
acrName: ''
containerAppName: ''
resourceGroup: ''
imageToDeploy: ''
targetPort: 80

Reported wrongly at; https://github.com/microsoft/azure-pipelines-tasks/issues/17687
We have the issue that we do not even specify acrName, only imageToDeploy, and still get that error message.

As a work around we could at least use target the previous version of this task like this<EMAIL_ADDRESS>

As a work around we could at least target the previous version of this task like this<EMAIL_ADDRESS>
@Guillaume-R-FLOSS Did you have to do anything else to get this to work. I get the exception 'Invalid step task reference<EMAIL_ADDRESS>

I'm facing the same problem.
I want to set only the Azure Container Registry Name value in my release pipeline, since my image has already been built and pushed to the container registry by the build pipeline that i have.
With version 0.1.7 this was possible, but now i'm getting the error:
the arguments appSourcePath and acrName must either be provided together or not at all.
if i try to delete the "Azure Container Registry Name" and leave it blank the error changes because some values become undefined in this commad:
[command]/usr/bin/bash -c CA_ADO_TASK_ACR_ACCESS_TOKEN=$(az acr login --name undefined --output json --expose-token --only-show-errors | jq -r '.accessToken'); docker login undefined.azurecr.io -u 00000000-0000-0000-0000-000000000000 -p $CA_ADO_TASK_ACR_ACCESS_TOKEN > /dev/null 2>&1
As can be seen  --name undefined and  docker login undefined.azurecr.io
in version 0.1.7  with only acrName filled in it would generate correctly  replacing the "undefined" with the filled in value in acrName.

Hey folks, apologies for this issue -- there was a misunderstanding with the argument validation when it came to when acrName should be provided along with appSourcePath. I just merged a PR that fixes this so that acrName is only required when appSourcePath is provided, not the other way around, so acrName can now be used with the imageToDeploy argument as outlined in this issue.
The 0.1.9 version of the AzureContainerAppsRC task has been released with this fix -- please let me know if this issue still persists or if there are any other issues you're facing with the latest set of releases.

I was about to send you a Pull Request where i extracted the acrName from the imageToDeploy using the regex /(.*?)\..*/
But 0.1.9 fixed the issue. Thanks!!!

As a work around we could at least target the previous version of this task like this<EMAIL_ADDRESS>
@Guillaume-R-FLOSS Did you have to do anything else to get this to work. I get the exception 'Invalid step task reference<EMAIL_ADDRESS>
Nope we didn't had to do extra thing to target this specific version. As a side note we use Azure Hosted Agent with ubuntu-latest image.


Coverage cleanOnRerun: false causes crash

Describe the bug
When setting coverage.cleanOnRerun to false, saving a file will cause the CLI to crash with Error: ENOENT: no such file or directory, open '/path/to/repo/coverage/.tmp/coverage-[num].json'.
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-7cu7ag?file=vite.config.ts

Press "Fork" so you can edit
Wait for the coverage to be outputted in the CLI
Make any change to src/basic.ts. The CLI will crash with the error above.

If it doesn't crash, just wait for the coverage output again and try making another change.
System Info
System:
    OS: macOS 14.4.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 177.73 MB / 16.00 GB
    Shell: 3.7.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 20.11.1 - ~/.local/share/nvm/v20.11.1/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 10.2.4 - ~/.local/share/nvm/v20.11.1/bin/npm
  Browsers:
    Chrome: 123.0.6312.122
    Safari: 17.4.1
  npmPackages:
    @vitejs/plugin-react: ^4.2.1 => 4.2.1
    @vitest/coverage-istanbul: ^1.4.0 => 1.4.0
    @vitest/ui: ^1.4.0 => 1.4.0
    vitest: ^1.4.0 => 1.4.0

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

For now we can add a fix that prevents the crash. But I'm starting to think that we should remove whole cleanOnRerun option as it doesn't make much sense. If results of previous run are preserved should we merge the next results with them? That would cause incorrect reports.

That was what I was trying to do. In some cases, the coverage outputted only shows the file you most recently changed. I wanted it to preserve the coverage of the other files too.

Showing coverage results from earlier test runs will be difficult and Vitest is unable to do that reliably. The reports from earlier runs can be completely off if some of those files or their test files were changed in between.

If new lines were added in the source file, the old results will now point to incorrect lines.
If a test file is removed, the source files that it was earlier covering are still incorrectly covered.

The cleanOnRerun option will cause bugs and shouldn't be used.

If the source file or test is changed, shouldn't it be able to just re-generate the relevant coverage files? It should be able to just leave the coverage records for files that are unrelated to the change.

Yep, that's exactly how it works. It re-generates the relevant coverage files and leaves the other ones as is. The re-generated parts will be merged with old ones. Lines that should show 1x hits will show 2x and so on.

Is there another option that regenerates relevant files but replaces the old results? So it'll still leave results for unchanged files but won't have duplicate results for the changed ones.

Got it. That is what I was expecting to happen with cleanOnRerun: false, so if you were to implement an option for that, that would be a good replacement. I agree that, at least with how it's implemented now, this option should probably be deprecated in the future.


aruco: the nScales == 1 is already handled inside parallel_for_

This is right, however it is done this way in purpose.
The use of parallel_for for a single scale reduces the performance, so I decided to handle this case separately without using paralel_for

this is strange, as nothing in the code would suggest a slowdown. Which compiler do you use? And do you have a performance test for this?

I performed a performance evaluation on my machine:

i7-4770K
64bit Ubuntu 14.04
Release Build

there was no measurable performance difference to one another. As parallel_for is the natural place for this kind of optimizations I would suggest merging my changes.

Finally I have found some time to get a look at this.
I have done a thorough test and you are right. I am having an average difference of only 0.2 ms on my machine.
So yes, I also suggest merging this PR.

:+1:


Browsersync doesn't work sometimes

When I add tw classes it doesn't update the webpage although the page reloads, I have to type npm run dev command, again and again, to make it work.

Yes, I reproduced and checked the issue. It was just updating HTML files on gulp watch since we used PurgeCSS to remove unused CSS classes from style.css when HTML was updated but styles were not. Fixed it now. Here is the commit link


Modify harbor log files name to align with latest change

Remove the notary-db and clair-db logs files, and change the mysql.log to postgresql.log. There changes are align with the Harbor DB migration, otherwise, the nightly will fail by collecting logs in the tear down phase.

Coverage increased (+0.02%) to 64.436% when pulling e7a16acc16ae9caa331636dfc828fed0bf1e318c on wy65701436:fix-nightly-logs into 042ac05dfe4aa9f7d4a0f7ad10ec2bc929786240 on vmware:master.


[Feature Request]: Extract and Paramaterize HealthCheck Timeouts

Feature description
Paramterize the default values introduced in: https://github.com/opendatahub-io/data-science-pipelines-operator/pull/324
This includes both health check timeouts, and the worker reconcile values. These should be passed into the DSPO via args, and will require updates to the deployment yaml as well.

Can be easily combined with: https://github.com/opendatahub-io/data-science-pipelines-operator/issues/316

Should this not be a DSPA CRD item instead of a DSPO parameter?  It would allow better customizablity, keeps the controller constructor cleaner, etc.


defaultHeadersForTokenRequests not working for updateToken()

Hello,
@groenlid - @RWOverdijk suggested I should pin you to this issue.
Setting the defaultHeadersForTokenRequests seems to work for the login() method, but not for updateToken(). All the parameters are missing from the updateToken request, which also happens for the initial token request made by login() if I remove the defaultHeadersForTokenRequests: {'Content-Type': 'application/x-www-form-urlencoded'} line.
Here is my set up:
foo
  .plugin('aurelia-api', configure => {
    configure
      .registerEndpoint('auth', environment.apiEndpoint, {headers: {'Content-Type': 'application/x-www-form-urlencoded'}})
      .registerEndpoint('protected-api', environment.apiEndpoint)
      .setDefaultEndpoint('protected-api')
  })
  .plugin('aurelia-authentication', baseConfig => {
    baseConfig.configure({
      endpoint                      : 'auth',
      configureEndpoints            : ['auth', 'protected-api'],
      defaultHeadersForTokenRequests: {'Content-Type': 'application/x-www-form-urlencoded'},
      loginUrl                      : 'token',
      authHeader                    : 'Authorization',
      authTokenType                 : 'Bearer',
      httpInterceptor               : true,
      accessTokenProp               : 'access_token',
      useRefreshToken               : true,
      clientId                      : 'XXXXXXXX',
      refreshTokenUrl               : 'token',
      refreshTokenProp              : 'refresh_token',
      refreshTokenSubmitProp        : 'refresh_token',
      autoUpdateToken               : true,
      storage                       : 'localStorage',
      loginRedirect                 : '#/home',
      logoutRedirect                : '#/home',
      getExpirationDateFromResponse : (response => {
        if (response && response.expires_in) {
          return (new Date().getTime() + response.expires_in * 1000) / 1000
        }
      })
    })
  })

If you login and refresh the page, updpateToken() is called, but since it doesn't attach any parameters to the token request, authentication fails and the user gets logged out.
Am I missing something? Please let me know if more details are needed!
Thank you!

I've slightly changed your description (removed some typos and made the code snippet prettier).
@groenlid you worked on this, correct? Do you have any input on this issue? :)

Thank you, @RWOverdijk!
I have been trying to find a work around this week, but I haven't got anywhere with it yet.
Any input will be much appreciated! :)
Thank you again!

I think @groenlid is mia. I'll pin this to my own inbox and see if I can find time to tackle this.

Thank you @RWOverdijk !

If you find the solution in the meantime, that'd be even better obviously :D

Hi @RWOverdijk,
Good news - defaultHeadersForTokenRequests works!  Since the token endpoint was working outside the Aurelia App & removing defaultHeadersForTokenRequests broke the initial login (which was only due the default format being JSON), I had assumed it was the front end that was causing the error.  Turned out I had to make adjustments in the token generation for it to accept requests from the App and everything works now.
Thank you for responding to my comment and the issue!

Oh I'm glad you solved it :)


fix: nr1 catalog ga prep

Issue #36
Issue #40
Issue #41

:tada: This PR is included in version 0.8.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Various soundcard fixes, cleanup and enhancement

Fixed the EEPROM/registers array size for Adlib Gold
SB DSP code style normalization
Fix for SB Pro v2 being mono instead of stereo
Fixed the amplitude in mode 1 of the PC Speaker
Make WSS base address customizable
Cleanup in AudioPCI.c
Fixed direction of AudioPCI sample counters.

Thanks!


Remove version: OpenJS.NodeJS.LTS version 14.21.0

Replaced by another Pull Request
Microsoft Reviewers: Open in CodeFlow

https://www.github.com/microsoft/winget-pkgs/pull/143386#issuecomment-1986949152 [Policy] Needs-Author-Feedback

Close with reason: See discussion in above linked issue;


Fix and extend release version checker

Summary
Fixes problems with globbing and adds additional check of next-version in project.yml
Please check the relevant options

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[ ] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[ ] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

@michalvavrik do you want from me some examples of new added checks?

@michalvavrik I made some examples
Main scenario: project.yml next-version must follow current-version
Latest pre-release 1.6.0.Beta1
[main] success
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995462717
[main] failure
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995472851/job/27627684518
Latest released 1.5.1 (has “latest” tag)
[1.5.z as latest LTS]
Success   https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995636331/job/27628237024
Failure
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995646444/job/27628269444
Beta tag failure
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995659518/job/27628309994
Latest release 1.6.0
Latest published 1.5.1 (no tag)
[1.5.z as oldest LTS (1.3.z)]
Success
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995743522/job/27628587111
Failure
https://github.com/gtroitsk/quarkus-test-framework/actions/runs/9995757571/job/27628631130

Plan for 1.3.z branch during backports
It requires to release 1.3.0, so probably change https://github.com/quarkus-qe/quarkus-test-framework/releases/tag/v1.3.0.Beta31
After, the latest version should be 1.3.1 as a blank release or changed https://github.com/quarkus-qe/quarkus-test-framework/releases/tag/1.3.1.Final
What strategy do you prefer?

Let's go with the easiest way, if we need 1.3.0 to have this check passing, it's better to do extra release than to invest more time into this task.


closes #99 eth_gasLimit missing

This feels really foolish, but what am I supposed to do to make the test work? I thought I should use a call similar to this: https://github.com/ethereum/pyethapp/blob/develop/pyethapp/rpc_client.py#L101
And yet when I dogenesis_block_info = client.call('eth_getBlockByNumber', 'earliest', False), it just returns a string "earliest". Is there something different about the testing environment that I'm missing?

@4gn3s It returns the 'earliest' because the 'call' method is redefined on line 6 https://github.com/ethereum/pyethapp/pull/103/commits/75a2572f85a74a8d4c704a4430abfef919e0edaf#diff-e92b78f8db16a62992c87795ab883c44L4

@4gn3s There is nothing wrong with your code, It's all about the incorrect tests. You need starting the RPC Server before trying to connect to it.

Coverage increased (+0.4%) to 51.631% when pulling 02397d1aaf55fcb6671799810653a6f54713d7ad on 4gn3s:fix_eth_gasLimit_missing into 97c78c66189e4c80a54c14139e04fe243a8aa227 on ethereum:develop.

Thanks @RomanZacharia, I've fixed the tests


No, it's german for "The Bootstrap, the"

(joke context)
The core of the buildkite agent (one of its cores, anyway) is a component currently called "The Bootstrap". This is the part of the agent that's actually responsible for running jobs, streaming their logs back to the buildkite mothership, and doing all the business of running hooks, finding plugins, doing git things, etc.
Were it only that simple.
What we call "the bootstrap" is actually three separate components from this repo's point of view:

A CLI command, buildkite-agent bootstrap, which is what the agent calls when it gets a new job to run
A go package called bootstrap that contains most of the code that gets run to run a job
A go struct, bootstrap.Bootstrap which holds the logic for job execution (though there are other peripheral job execution-related bits and bobs hanging around in the bootstrap package mentioned above)

These three things being named the same thing makes talking about them separately a pain; when talking about "the bootstrap", there's a variety of things that could be the subject of discussion.
Furthermore...
"Bootstrap" is a kind of a crappy name for what this thing does
There was a time, long ago, when this name probably fit. Fun fact, prior to v3 of the agent, the bootstrap used to be a bash script that the agent ran. At this point, the bootstrap was mostly responsible for standing up (bootstrapping, one might say) an environment in which a job (at the time a bash script and nothing more).
Times have changed however, and the bootstrap is now a (very) complex piece of go code responsible for orchestrating all of the various tasks that need to happen before, during and after a job run.
Okay, but why change it?
Simply put, the name is confusing and it means that when we talk about the bootstrap (which we usually mean as "the job execution thingy") to our colleagues and to our customers, there's context that's lost in translation.
The bootstrap is an incredibly important part - maybe the most important part - of a job's execution lifecycle, and we fairly regularly have need to talk to customers about it. Knowing what the bootstrap actually is requires knowledge of the agent's history though, and it makes talking about these things, and intuiting how the agent actually works, a lot harder.
Consider: If you were a buildkite customer and a bikkie said "oh that's a bootstrap error", what would you think the problem is? How about if they said (foreshadowing) "I think there's an error in the job executor"?
Cool. What have you done about it?
This PR is basically a big fancy find-and-replace. The gist of it is:

The buildkite-agent bootstrap command is deprecated (but not removed) and replaced with buildkite-agent exec-job. This new command is functionally identical to the existing one, with the only change being that it doesn't have a deprecation notice
The bootstrap package has been renamed to job. This makes a lot of names clearer IMO - consider bootstrap.Shell vs job.Shell
The boostrap.Bootstrap struct has been renamed to job.Executor. This is more in line with what it actually does - it executes a job

None of these names are final - i'd love some feedback on them.  Two hard things and all that.
Open Questions

[ ] Is job.Executor too similar semantically to agent.JobRunner? My opinion is no, but it's not particularly strongly held
[ ] Should we bother scrubbing all mention of the bootstrap from the repo or is it okay to leave some of them in there?

Still to do

[x] Update agent/job_runner.go to:

[x] Use the new nomenclature
[x] Add a hook called pre-exec, identical to pre-bootstrap but with the shiny new name
[x] Add a deprecation warning to the pre-bootstrap hook??? should we just continue to allow it?

[x] Another round of seek-and-destroy on instances of the text bootstrap. They're pervasive!
[x] Local smoke testing to ensure that:

[x] The agent uses buildkite-agent exec-job as its job executor by default
[x] buildkite-agent bootstrap still works okay, but outputs a deprecation warning
[x] The agent's bootstrap can be overridden using both --bootstrap-script and --job-executor-script.

Naming bike-shedding: I wonder if run-job would match our other terminology closer than exec-job.
e.g. Job state will be running as a result of this not-bootstrap thing happening.
And when you look at it in Test Analytics, it'll be called a Run (I think).
Also, “exec” feels quite low-level syscall-ish, whereas the not-bootstrap does quite a lot of higher-level coordination before executing one-or-more processes/hooks/plugins/containers/things.
Apologies, I haven't looked/thought deeper about the PR more broadly, I only have this bike-shed right now 😅

Also: I was totally baited into looking at this by the excellent PR title 🤡

@pda

I wonder if run-job would match our other terminology closer than exec-job

i think i agree with you here - it's terser while also holding more information. how would you feel about renaming the command to run-job while keeping the struct in the job package job.Executor? There's a slight mismatch in naming there, but i think it nicely delineates between the internals and the externals (porcelain and plumbing, it git terms, i guess)

Also: I was totally baited into looking at this by the excellent PR title 🤡

my cunning plan has worked then

how would you feel about renaming the command to run-job while keeping the struct in the job package job.Executor? There's a slight mismatch in naming there, but i think it nicely delineates between the internals and the externals (porcelain and plumbing in git terms, i guess)

Interesting question.
I'm a proponent of ubiquitous language; it'd be a shame to have two names for one thing.
One arguable argument against “runner” is that other platforms call their entire agent a “runner” (GitHub Actions, GitLab), and a subset of our customers will confuse it with that.
The other that you touched on is that we already have a component called JobRunner which lives in the agent outside the ~bootstrap~ executor/runner/thing.
I don't have the answers 🤷♂
I wonder…

buildkite-agent start   (some people think of this as the “Buildkite self-hosted runner”)

loop: get jobs (specifically: Command Step jobs, aka Command Jobs)

internal JobRunner prepares & orchestrates running the Command Job

buildkite-agent bootstrap (rename to run-job?) subprocess

do the lifecycle of the Command Job; command, plugins, hooks etc

Maybe JobRunner becomes JobOrchestrator and boostrap.Bootstrap becomes job.Runner? I don't love it.
Taking a step back from specifics…

the main process gets a job and wants to run it, but doesn't know how or isn't capable of doing so directly; it delegates to another layer in a subprocess to actually run the job.
that subprocess exists to run jobs, and knows how to run jobs.

Through that lens, the subprocess has a much stronger claim to “run job” or “job runner” naming, and the main process should find a different name that means ”knows that a job needs running and knows how to ask a subprocess to run the job”.

Possible alternative names for agent.JobRunner (i.e. the bit that doesn't actually execute the job, it just kicks it off elsewhere)

agent.JobManager
~agent.JobForker~
agent.JobOrchestrator
agent.JobStarter
agent.JobSupervisor
agent.JobInvoker

None of those feel great. What does it actually do?

Starts the subprocess to run the job

Collates the correct env to pass to that process

Streams stdout / stderr / header times to the API
Experimentally knows how to run jobs in k8s/etc instead of as a subprocess

The “k8s/etc” bit means it's not a JobForker.
I'd call it JobDispatcher except that means something different server-side, and the log streaming etc goes a bit beyond just “dispatching”.
agent.JobManager is okayish, to the extent that “manager” is ever a good name for a software component 😬
Maybe it's a JobInvoker but that's just adding yet another synonym for “run” / “execute”.
The fact that it's learning run jobs in different ways (subprocess / k8s / …) feels important here. Again, “dispatcher” kind of suits that. So does “strategy”.

@pda very interesting thoughts 🤔 i agree with you that there remains some confusion about the role of the agent.JobRunner vs job.Executor, but how would you feel about making that change at a later date? my take is that the current setup makes things clearer, though maybe not as clear as they possibly could be, but it's a step in the right direction.
the good thing is that those names (job.Executor and agent.JobRunner) are both completely internal, and can be pretty easily changed

I quite like agent.JobSupervisor for the current agent.JobRunner. Prior art from supervisord.
I'd always imagine that we'd add "Executors" which where strategies for executing the bootstrap, what we do now is a LocalShellExecutor or similar. We've built a DockerExecutor at CashApp, I've built an AmazonECSExecutor in the past.
Finding the right name for the bootstrap is a real challenge. The architecture we've built at CashApp where we run the buildkite-agent bootstrap in a docker container (the logical extension of https://github.com/buildkite/docker-bootstrap-example) has really exposed the confusing-ness of the name. The bootstrap is almost not even part of the agent anymore, it could even be running on a totally different host depending on the executor.
What if you actually decoupled it from the buildkite-agent binary? What if it was a buildkite-agent-job-runtime? That also plays into the bk cli and wanting to run a job locally (which actually doesn't need an agent).
The other aspect here of what the bootstrap does is it manages phases (I wish I'd called this stages), hooks and plugins. I've frequently wanted more granular access to these things, for instance being able to call buildkite-agent bootstrap default-checkout-phase directly.
If I was pushed to pick a name for a straight sub-command rename, I'd actually aim to extract it out of the job subcommand to leave room for job commands that operate on the active job (the bootstrap does not in the same way that the other commands do). What about buildkite-agent job-runtime or buildkite-agent job-kernel execute? 😅


[Typo/Mistranslation] 06-design-report-in-power-bi-desktop

On Practice 1, task 6 step 7, the column and table names need to stay in English so it will align with the lab environment. It is very confusing for the learners to see the column/table names in Korean on the instruction and then have to match it with the corresponding English names on the lab environment.
Current:
판매
판매
목표
목표
목표
분산
목표
분산 여백
To be:
Sales
Sales
Targets
Target
Targets
Variance
Targets
Variance Margin

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Locfile is currently at PHO with HO disabled on the Project - Need the locfile to be at HB to make the fix - will discuss with the PM

Discussed with the PM - update made to the older HB locfiles and this will seed the TM when handedback


Develop Website

Get a basic site ready, which asks the user for discord authentication first, and then depending on what server is chosen, download GitCord into that.

Closed as of #52.


make usage of kms.destroyBucketKey on bucket deletion

fix #328

@rahulreddy and @ploki we recreate the deleted flag bucket on an object put (and on an acl bucket change) so we should definitely only delete the key at the end.  https://github.com/scality/S3/blob/master/lib/api/objectPut.js#L176

Ok, thanks for the explanation. Code has been modified to delete the bucket encryption key as a last step

@ironman-machine would you mind if I ask for an end to end test ?

Hello @ploki
Starting end to end procedure using the following payload:
{"REPO_NAME": "S3", "SCALITY_S3_BRANCH": "ft/destroyBucketKey", "DEFAULT_BRANCH": "rel/6.2.1"}
Please follow http://ci.ironmann.io/gh/scality/Integration/5867 for CI status.


Let users manually switch the column type

Sometimes user wants to switch the column to a different type (other than the predefined one), e.g., to try different filters. The use case often appears, when users are uploading a CSV file on https://lineup.js.org/app_develop/ and some columns are not detected correctly. At the moment the user does not have the option to change it in the UI. The only option to change it is to open a codepen or similar and edit the column type. This is usually a lot of work for users that "just" want to analyze their data.
In the following are some switches users were requesting:

String to date
Date to string
String to categorical
Categorical to string
Number to categorical
String to link
Link to string
Boolean to categorical
Categorical to boolean

Of course not all switches are possible and useful. We must find a way how we can allow and on the other side restrict this functionality.
Suggestion

Every column has a new menu point Switch column type ...
On click a dialog opens
The dialog provides possible column types (the list needs to be defined)
When the user confirms the dialog the column is replaced with the new column type

Open questions

Is a live preview and reset button possible?

Idea: We could place a preview of the new column next to original one. If the user confirms the dialog the original column is removed. Otherwise (on cancel/reset) the preview column is removed
If not we should hide the reset button and/or give the user a warning that this action cannot easily be undone.

Which column types can switched into one another?
What happens to categories, min/max values, ...?
Can we keep sorting/grouping/group sorting for the column?

Alternative option
In case this feature request is too complicated, we should think how to improve the importer of the LineUp demo instead so that the user starts with the correct column type after uploading a dataset.

Moreover, isn't that similar to the whole taggle-fusion idea?

Actually, you are right. I digged in some old issues and I found exactly the idea and a sketch. 😄
https://github.com/Caleydo/lineup_app/issues/7
We started some implementation with https://github.com/Caleydo/lineup/issues/25 (and https://github.com/Caleydo/lineupjs/pull/525), but we never made it to the implementation of this feature, as the focus of the BSc thesis was shifted to the canvas renderer. But I will have a look again what the status of the taggle-fusion branch is.
Would you continue with the taggle-fusion branch or implement it from scratch again?

That's funny. I still thought that this feature would be very useful but I didn't remember that we discussed that two years ago already :-)

@mstreit Looks like it is still important to us/our users. Maybe we should really implement it. 😉

Would you continue with the taggle-fusion branch or implement it from scratch again?

as far as I remember the original implementation was based on lineupjs-v2 so most likely no
if this feature should be implemented it needs more specification, since it is not a small bugfix but a rather big enhancement / epic

OK, then let's specify it and estimate the effort. Then we can decide if it's worth to be implemented.

@thinkh can you specify the ticket in more detail, please.
The main difficulties are that this feature is the first one that changes the description within the data provider. Moreover, when replacing a column there are numerous corner cases, e.g. what if the column is being sorted, grouped, part of a composite, filtered, has multiple instances, ...

@sgratzl I will specify this later this week or early next week. Unfortunately, until now I did not have time, due a lot of other tasks. When working on this I will try to think of possible corner cases.

@sgratzl I will specify this later this week or early next week. Unfortunately, until now I did not have time, due a lot of other tasks. When working on this I will try to think of possible corner cases.

ping

Excuse my late reply. I try to go through some corner cases you mentioned and write down my ideas. I assume that we will find a lot more once we are in the implementation phase.

The main difficulties are that this feature is the first one that changes the description within the data provider.

Since the loaded data itself does not change when switching the column type, an idea would be to create an additional column with the new type while still keeping the existing one. With both column types at hand we are more flexible and could probably handle some of the following corner cases easier and allow features like reset/undo.

corner case ... if the column has multiple instances, ...

In my opinion we have two contrary use cases here:

Users are focusing on the current column instance and want to change the type of this particular column only
Users are thinking globally and want to switch all instances of this column

I would guess, that the first use case is the most common one, but I cannot exclude the second one. So we might have have to find a solution for both. I suggest the following dialog:

If multiple instances are available, a separate section is shown in the dialog where the user can select the different column instances. Column instances that are used in composite columns are disabled and show a hint (see next point).

corner case ... if the column is part of a composite, ...

Since the new column type might be incompatible with the composite column, we should not switch them and keep the original column type. However, we must inform the user that a switch of a column within a composite column is not possible. Furthermore, the menu item should be hidden in this case.

corner case ... if the column is being sorted, grouped, filtered, ...

I agree that these settings cannot be converted to the new column type or the visual result might be confusing for the user when automatically applied. Hence, I would warn the user that some actions will be removed and must be applied manually again.
@sgratzl Could you maybe provide a list of properties that can or cannot be converted? And also which might require further configuration (e.g., number to categorical requires binning)? Maybe it is also worth to create spreadsheet with possible combinations and add the limitations.
As for these required configurations we could configure them in an additional dialog behind the cogs icon. Alternatively, if the configuration is not too complex and detailed, we could try a similar solution as we have it for the color mapping.

@sgratzl Please let me know what do you think about this? Are there any open issues and questions?
A general remark for the upcoming the implementation: Please implement this feature in a way that we can re-use / integrate it also in tdp_core.

lets start a document since this one is getting too big to keep up:
https://docs.google.com/document/d/1pphg0NTyGKXADCJGahxFdYW9iyTr4xFNC1-HJjVJVfc/edit?usp=sharing

Good idea! I left some comments in the document. Let's continue over there for now.

@thinkh so what is the plan?


models/issue: Don't get issue repo until added

Wait until we're done adding a new issue to the database to attempt to
search the `repository' table for the issue's repository id. Otherwise,
on SQLite, retrieving the repository will fail, probably for the same
reason as #2700 (and ea802742) -- the SQLite driver for xorm can't
retrieve objects after something was updated.
Fixes #3291.

Oops, I forgot to add loadAttributes() to models/pull.go too, so I've amended my previous commit. Sorry if that messes up anything anyone's fetched already.
Having loadAttributes() outside of newIssue() in two different places kinda sucks, but I'm too lazy to find a better solution.
(If anyone's wondering, I moved the initialization for the Action in NewPullRequest() down a bit just in case someone updates it to use pull.Repo in the future, although I doubt they will. Plus, I'm not sure why it was up there in the first place.)

Thanks your PR!
Closed by https://github.com/gogits/gogs/commit/5761342f3263b909448b515ab7700d1a8ec36ded


CB-14097: (android) Fix crash when selecting some files with getPicture

Handles both urls:
content://com.android.providers.downloads.documents/document/1111
content://com.android.providers.downloads.documents/document/raw%3A%2Fstorage%2Femulated%2F0%2FDownload%2Ffilename.pdf

Platforms affected
Android
What does this PR do?
Fixes crash of certain URLs
What testing has been done on this change?
manual testing
Checklist

[ x ] Reported an issue in the JIRA database
[ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ? ] Added automated test coverage as appropriate for this change.

Happened to me when selecting a photo from the Downloads folder.
Please merge this fix.
+1

I have implemented the suggestions of the review.
Must be better now.

Thanks, merged!

Is there a timeline for the next release? We're on 4.0.3 but this hasn't been merged in yet apparently.

It’s merged, but not released

Is there a timeline for the next release?

This is very important, The camera is not working on a lot of android devices, When this will be released ?

I need this fix. Please let me know how I can get around this problem. Is there a way I can manually apply this fix to my version of the plugin?

I'm also facing this issue.
We need this fix released!
There hasn't been a release in more than one year! We need it badly!

I'm also facing this issue.
Is there a timeline for the next release?
Thanks

@claudiozam probably no timeline.
I'm considering to use this repo directly to pull this fix to my code.....

Actually we just got a release!!!! @claudiozam
Thanks to @janpio :heart: :tada:

Just a tag for now, release is in vote but will follow soon-ish. Watch for the rel/x.y.z tag that is made after it has been published to npm.

@janpio isnt a tag a release?
At least for me it is.... if I add the plugin it will add it like<EMAIL_ADDRESS>......

No, a tag is just a tag - but of course that can also be installed with the CLI. But doing cordova plugin add cordova-plugin-camera will only install tags that are also published to npm - and there it will take a few days until I can do that after a successful vote.

Maybe its because I used ionic but cordova plugin add cordova-plugin-camera installs 4.1.0 directly from here

Oh wait! I was wrong!
Seems it installs ^4.0.3 .... I dont know why but I thought it was installing 4.1.0.
Can we see the vote status? Where?
Thanks!

<EMAIL_ADDRESS>

I solved it by editing the method "getRealPathFromURI_API11_And_Above" in this way:
@SuppressLint("NewApi")
public static String getRealPathFromURI_API11_And_Above(final Context context, final Uri uri) {
final boolean isKitKat = Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT;
// DocumentProvider
if (isKitKat && DocumentsContract.isDocumentUri(context, uri)) {
        // ExternalStorageProvider
        if (isExternalStorageDocument(uri)) {
            final String docId = DocumentsContract.getDocumentId(uri);
            final String[] split = docId.split(":");
            final String type = split[0];

            if ("primary".equalsIgnoreCase(type)) {
                return Environment.getExternalStorageDirectory() + "/" + split[1];
            }

            // TODO handle non-primary volumes
        }
       /* // DownloadsProvider
        else if (isDownloadsDocument(uri)) {

            final String id = DocumentsContract.getDocumentId(uri);
            if (id != null && id.length() > 0) {
                if (id.startsWith("raw:")) {
                    return id.replaceFirst("raw:", "");
                }
                try {
                    final Uri contentUri = ContentUris.withAppendedId(
                            Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));

                    return getDataColumn(context, contentUri, null, null);
                } catch (NumberFormatException e) {
                    return null;
                }
            } else {
                return null;
            }
        }*/
        // MediaProvider
        else if (isMediaDocument(uri) || isDownloadsDocument(uri)) {
            String docId = DocumentsContract.getDocumentId(uri);
            docId = docId.replace("msf:", "video:");
            final String[] split = docId.split(":");
            final String type = split[0];

            Uri contentUri = null;
            if ("image".equals(type)) {
                contentUri = MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
            } else if ("video".equals(type)) {
                contentUri = MediaStore.Video.Media.EXTERNAL_CONTENT_URI;
            } else if ("audio".equals(type)) {
                contentUri = MediaStore.Audio.Media.EXTERNAL_CONTENT_URI;
            }

            final String selection = "_id=?";
            final String[] selectionArgs = new String[]{
                    split[1]
            };

            return getDataColumn(context, contentUri, selection, selectionArgs);
        }
    }
    // MediaStore (and general)
    else if ("content".equalsIgnoreCase(uri.getScheme())) {

        // Return the remote address
        if (isGooglePhotosUri(uri))
            return uri.getLastPathSegment();

        return getDataColumn(context, uri, null, null);
    }
    // File
    else if ("file".equalsIgnoreCase(uri.getScheme())) {
        return uri.getPath();
    }

    return null;
}

Hi @giuseeFG, your snipped helped me, thank you.
One question did you create pull request with it? If not I want to do it.


Baseline - Refactor AWS cost controls

[x] Create README.md
[x] Add outputs.tf
[x] Add variables.tf
[x] Add providers.tf
[x] Add smart_folder.tf
[ ] Categories polices
[x] Add guardrail (category) links
[x] Add mod links
[ ] Refactor to be in sync with baselines

Updated the scripts according to the requirement. And the terraform apply output as below.
krishna@turbotindias-MacBook-Pro aws_check_cost_controls % terraform apply --var-file=demo.tfvars
var.turbot_profile
  Enter profile matching your turbot cli credentials.

  Enter a value: punisher

turbot_smart_folder.aws_cost_controls: Refreshing state... [id=215478446218537]
turbot_policy_setting.aws_ec2_instance_schedule_tag: Refreshing state... [id=215478451926392]
turbot_policy_setting.aws_ec2_volume_active_attached: Refreshing state... [id=215478449613120]
turbot_policy_setting.set_resource_active_policies["aws-lambda-function"]: Refreshing state... [id=215478449611070]
turbot_policy_setting.ec2_instance_schedule: Refreshing state... [id=215478449864025]
turbot_policy_setting.aws_ec2_volume_active: Refreshing state... [id=215478449889640]
turbot_policy_setting.set_resource_active_policies["aws-ec2-snapshot"]: Refreshing state... [id=215478449864024]
turbot_policy_setting.set_resource_active_policies["aws-ec2-instance"]: Refreshing state... [id=215478451338611]
turbot_policy_setting.set_resource_age_policies["aws-ec2-instance"]: Refreshing state... [id=215478451319151]
turbot_policy_setting.set_resource_active_policies["aws-s3-bucket"]: Refreshing state... [id=215478449866074]
turbot_policy_setting.set_resource_age_policies["aws-ec2-ami"]: Refreshing state... [id=215478449619269]
turbot_policy_setting.set_resource_age_policies["aws-ec2-snapshot"]: Refreshing state... [id=215478451962237]
turbot_policy_setting.set_resource_age_policies["aws-lambda-function"]: Refreshing state... [id=215478449620294]
turbot_policy_setting.set_resource_age_policies["aws-s3-bucket"]: Refreshing state... [id=215478449624394]
turbot_policy_setting.set_resource_active_policies["aws-ec2-ami"]: Refreshing state... [id=215478449864023]

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # turbot_policy_setting.aws_ec2_instance_schedule_tag will be created
  + resource "turbot_policy_setting" "aws_ec2_instance_schedule_tag" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/instanceScheduleTag"
      + value                        = "Skip"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.aws_ec2_volume_active will be created
  + resource "turbot_policy_setting" "aws_ec2_volume_active" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/volumeActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.aws_ec2_volume_active_attached will be created
  + resource "turbot_policy_setting" "aws_ec2_volume_active_attached" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/volumeActiveAttached"
      + value                        = "Force inactive if unattached"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.ec2_instance_schedule will be created
  + resource "turbot_policy_setting" "ec2_instance_schedule" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/instanceSchedule"
      + value                        = "Skip"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_active_policies["aws-ec2-ami"] will be created
  + resource "turbot_policy_setting" "set_resource_active_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/amiActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_active_policies["aws-ec2-instance"] will be created
  + resource "turbot_policy_setting" "set_resource_active_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/instanceActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_active_policies["aws-ec2-snapshot"] will be created
  + resource "turbot_policy_setting" "set_resource_active_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/snapshotActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_active_policies["aws-lambda-function"] will be created
  + resource "turbot_policy_setting" "set_resource_active_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-lambda#/policy/types/functionActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_active_policies["aws-s3-bucket"] will be created
  + resource "turbot_policy_setting" "set_resource_active_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-s3#/policy/types/bucketActive"
      + value                        = "Check: Active"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_age_policies["aws-ec2-ami"] will be created
  + resource "turbot_policy_setting" "set_resource_age_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/amiActiveAge"
      + value                        = "Force inactive if age > 60 days"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_age_policies["aws-ec2-instance"] will be created
  + resource "turbot_policy_setting" "set_resource_age_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/instanceActiveAge"
      + value                        = "Force inactive if age > 60 days"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_age_policies["aws-ec2-snapshot"] will be created
  + resource "turbot_policy_setting" "set_resource_age_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-ec2#/policy/types/snapshotActiveAge"
      + value                        = "Force inactive if age > 60 days"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_age_policies["aws-lambda-function"] will be created
  + resource "turbot_policy_setting" "set_resource_age_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-lambda#/policy/types/functionActiveAge"
      + value                        = "Force inactive if age > 60 days"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_policy_setting.set_resource_age_policies["aws-s3-bucket"] will be created
  + resource "turbot_policy_setting" "set_resource_age_policies" {
      + id                           = (known after apply)
      + precedence                   = "REQUIRED"
      + resource                     = (known after apply)
      + resource_akas                = (known after apply)
      + type                         = "tmod:@turbot/aws-s3#/policy/types/bucketActiveAge"
      + value                        = "Force inactive if age > 60 days"
      + value_key_fingerprint        = (known after apply)
      + value_source                 = (known after apply)
      + value_source_key_fingerprint = (known after apply)
      + value_source_used            = (known after apply)
    }

  # turbot_smart_folder.aws_cost_controls will be created
  + resource "turbot_smart_folder" "aws_cost_controls" {
      + description = "Defines sets of policies for the AWS check regions baseline"
      + id          = (known after apply)
      + parent      = "tmod:@turbot/turbot#/"
      + parent_akas = (known after apply)
      + title       = "AWS Check Cost Control Policies"
    }

Plan: 15 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

   Resources: 15 added, 0 changed, 0 destroyed.

Outputs:

resource_active = {
  "aws-ec2-ami" = "Check: Active"
  "aws-ec2-instance" = "Check: Active"
  "aws-ec2-snapshot" = "Check: Active"
  "aws-lambda-function" = "Check: Active"
  "aws-s3-bucket" = "Check: Active"
}
smart_folder_description = Defines sets of policies for the AWS check regions baseline
smart_folder_name = AWS Check Cost Control Policies
smart_folder_parent_resource = tmod:@turbot/turbot#/
turbot_profile = punisher

https://punisher-turbot.cloud.turbot-dev.com/apollo/smart-folders/215478767823323


Add list of system contract addresses to the documentation

Ideally, there is a clever way that this list of system contract addresses is always up to date, potentially via a github action

Issue in zksync-docs: https://github.com/matter-labs/zksync-docs/issues/140


Readme and gitignore additions

Why:

No need to have package-lock.json or yarn.lock in the repo
Adding jsx after the triple backticks will color the code in the readme

Checklist:

[x] Tests
[x] Ready to be merged

Thanks for contributing to the project. Well done @Hamza-Jd !
I appreciate it if you check the below issue and change your PR a bit.

I believe that package-lock.json needs to be there. (more info)

@moh3n9595 agree with keeping the lock files 👍 , I've updated the PR.


Godot 4 support?

Any chance we will see GoDot 4 support soon?

As I understand it, only stable releases are planned to be supported by godot-ci. As a result, Godot 4 will only be supported once 4.0 stable is released.

Yes, as Calinou mentioned, we do not see value in supporting non-stable releases, as that would add unnecessary overhead to the contributors.
However I have personally made images off of betas and alphas before, so it is very possible and easy (just change the download path).
Let me know if you have difficulty with this.

Any updates? Godot 4 is stable now.
https://godotengine.org/article/godot-4-0-sets-sail/

No headless binary for now, which is needed for this image to work afaik.

No headless binary for now, which is needed for this image to work afaik.

There's no headless binary anymore for Godot 4. The Windows, Mac, and Linux binaries now have a headless mode that's activated when ran with the --headless argument.

PRs welcome for anyone who wants to contribute to this 🎉

Hold on @realkotob, the current release of Godot CI 4.0 is broken! It even failed the action for the tag: https://github.com/abarichello/godot-ci/actions/runs/4309001784 . The fact is that the dedicated Linux binary is gone and needs to be adjusted in the Dockerfile, maybe PR #104 is still relevant?

I'll try to remake PR #104 later today while also updating the example workflow files.

This PR has been merged so things should be fixed now
https://github.com/abarichello/godot-ci/pull/104

But there is no Docker image because the action didn't run as the release tag already exists ?

I put together a PR for helping complete the support for Godot 4 (#105).
Hoping this can help. Let me know if there is anything I can do to help further. Thanks~

Seems like there still isn't a Godot 4 image available. Any updates?

See https://github.com/abarichello/godot-ci/pull/107.
It seems that not even 3.5.2 is listed on https://hub.docker.com/r/barichello/godot-ci, so I guess the automated deployment that was merged in https://github.com/abarichello/godot-ci/pull/79 isn't working. cc @TheOrioli

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow:
https://github.com/abarichello/godot-ci/actions/runs/4613295096
To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.
Unfortunately, I currently do not have the capacity to take a look at it.
What I can suggest for Godot 4 CI builds is https://github.com/chickensoft-games/setup-godot I've been using it successfully on our latest project.

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow: https://github.com/abarichello/godot-ci/actions/runs/4613295096

I believe https://github.com/abarichello/godot-ci/pull/107 has those fixes you're referring to - it was merged 2 weeks after that failed run which 404'd looking for a bad URL (the -headless bit in particular). Correct me if I'm wrong though

To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.

I'm one of those people looking for 3.5.2 support 🥲 Anyone that could help?

I'm one of those people looking for 3.5.2 support smiling_face_with_tear Anyone that could help?

I've triggered a workflow run – check back https://github.com/abarichello/godot-ci/actions/workflows/manual_build.yml.

The check releases is working correctly, but it seems that the current Dockerfile is incorrect, see workflow: https://github.com/abarichello/godot-ci/actions/runs/4613295096

I believe #107 has those fixes you're referring to - it was merged 2 weeks after that failed run which 404'd looking for a bad URL (the -headless bit in particular). Correct me if I'm wrong though

To fix 3.5.2 missing, someone with maintainer access to the repository needs to run the Manual Workflow, but first the issue with the Dockerfile should be fixed.

I'm one of those people looking for 3.5.2 support 🥲 Anyone that could help?

Seems the build worked🎊 Can you confirm your CI stuff is now operational?

Can confirm my CI stuff is "working"! (It is able to pull down and use the 3.5.2 build 🥳 but it's failing for other reasons specific to my project, might open a discussion while debugging that later 😄)
Thank you @Calinou @TheOrioli for the quick build and replies!

What I can suggest for Godot 4 CI builds is https://github.com/chickensoft-games/setup-godot I've been using it successfully on our latest project.

Does this mean 4 will never be supported and instead should use the link provided?


Add bundlesize config

Related issues
#1293, #1294, #1966
Short description and why it's useful
There's been a few issues targeted at improving the bundle size, integrating bundlesize in the CI checks should help keep track of how the bundles are changing across commits and PRs so it's easier to see how big or small they get. You can check this dummy PR in my fork that adds an extra library that makes the bundle size bigger than the set maximum.
I'm just adding the app, vendor and manifest files to the check with some sensible maximum file sizes but this can be tweaked.
Screenshots of visual changes before/after (if there are any)
PR Screen

Bundle Size Details

Screenshot of passed e2e tests (if you are using our standard setup as a backend)
TBA
Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[x] I read and followed contribution rules
[x] I read the TypeScript Action Plan and adjusted my PR according to it
[x] I read about Vue Storefront Modules and I am aware that every new feature should be a module

Great addition, thank you! ;)

Thanks! Keep in mind that to make the check show in PRs someone with admin rights needs to authorise bundlesize with travis as shown in their readme:
https://github.com/siddharthkp/bundlesize#2-build-status


Cloud mapping

Hi,
As we talked at the open house, I would like to move forward and contribute something towards cloud mapping.
One of the discussion issue is how to communicate between robots and cloud, or what portion of cartographer should run on the robots or cloud.
I feel like that pure localization should run on the robot due to tight loop, on the back end life long mapping could run on the cloud. One thought is like robots could send insertion_result which local_trajectory_builder makes on the robots to the cloud where global optimization runs, and then at some point, the cloud pushes updated map to the robots.
I wonder if we should just send raw sensor data or internal state like insertion_result via grpc to the cloud.
Any thoughts?

Christoph is writing an rfc right now, we will have something to discuss soon I think. @cschuet right?

As Holger mentioned I am currently looking into cloud-based mapping designs. I think eventually we will end up with a number of different ways how people go about "cloud-based mapping" as anyone understands something else by that (does the robot run full-blown global SLAM and upstream those "local" views of the global problem?).
With this disclaimer I agree that running pure localization on the agents and upstreaming the local SLAM results to the cloud to solve the global problem is what made most sense to me. So I am currently writing an RFC that describes exactly that. I am hoping to post a high-level strawman RFC before the end of the week.

That sounds exciting. I look forward to seeing the RFC.
Thanks.
Yutaka

You can find a first draft for the RFC here.

Closing this issue. Since the RFC is now merged. We will use the corresponding project entry for progress tracking.

Thank you for letting me know.
I am in the Thanksgiving holiday now, so I can't make it to join the open house, but I will catch you up next week.


Create map

Thanks

@Waseem-Mosam I am sorry, I have to close this request without merging, because you requested to add a non-existent domain to this repository:
$ host map.bw
Host map.bw not found: 3(NXDOMAIN)

Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


Registered timer with 0 period value doesn't work properly

As an example, please try something like:
registerTimer(() -> tick(), 1000, 0, TimeUnit.MILLISECONDS);

Unfortunately, there will be no Exception (good old java Threads). A main discrepancy here is that Runtime interface doc said:
...
* @param period       the period of subsequent ticks (if ZERO then will only tick once)
...

But we are unable to register Timer with 0 period value due to this precondition check:
if (period <= 0)
            throw new IllegalArgumentException("Non-positive period.");

We have to use Timer.schedule(TimerTask task, long delay); method instead. I think, scheduling some task just once is very useful. Please, could you provide this ability? I would say, that overloaded registerTimer() will be the best.

I agree that this behavior is desirable. We'll get this added shortly.

Please, could you add some precondition check or at least corresponding comment for the current method? Because the temptation of setting 0 value is great, but as a result nothing happens and without any exception.

I've made it so the behavior of the timer now matches the documentation. Your example will now work as you expect.
Exceptions from the timer system are correctly thrown, but you'll need to catch them on your call to registerTimer otherwise it will just cause the wrapping task to fail exceptionally (which may or may not get logged depending on who is waiting on that task).
Hopefully that resolves your issue. Thanks for reporting it, let me know if you have any further problems.

Thanks a lot, Joe! I will.


[Improve] Add auxiliary functions to get vertex chunk num or edge chunk num with infos

Proposed changes
These changes add some auxiliary functions to get vertex chunk num or edge chunk num with vertex info, edge info and directory path to check.
if the directory not exist, it would raise an ArrowError
Types of changes
What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments
Fixed issues #90

closed for duplicated with #95


Finalize class naming and adding in-code documentation.

Please review naming adjustments - these are aligned with what all of you mentioned during our different conversation. I would like to avoid braking interface again in the future.


scale.txt being overwritten

Scale.txt is being overwritten when rerunning extract, even when tiles are already extracted. This could cause potential bugs.

I do not fully see how this bug works, scale.txt is not computed inside of extract. Can you make a reproducible bug for this?

scale.txt is kept inside of the extracted and filtered tile directory

Tested this on Dante, the scale.txt is not overwriten when found in the tiles directory. This is working as expected

Okay I see. Kenneth had an issue with this, but it must have been for another reason!


R3 causing problems

Describe the bug
When loading the plugin, will say version unsupported however I can see R3 package inside the lib.
NPCLib JAR name
npclib-plugin-2.8-SNAPSHOT.jar
Server version

To Reproduce
Steps to reproduce the behavior:

Start the server with lib registered

Expected behavior
Run the plugin
Screenshots

Can you provide your usage option?
To me it seems that you're using the API file instead of the Plugin file, as the implementation can't be found.

I do not use this lib any longer, switched to other which works fine


Fix typo

'everythign' => 'everything'

This is already fixed in the docblock used to generate this: https://github.com/facebook/react-native/blob/master/Libraries/Components/ScrollView/ScrollView.js#L57-L61
See https://github.com/facebook/react-native/issues/13369
Thanks though :)


Use namespaced and weak dependency features in Cargo.toml

This feature was rolled out in Rust 1.60:

https://blog.rust-lang.org/2022/04/07/Rust-1.60.0.html#new-syntax-for-cargo-features

This PR intentionally skips spinoso-random because the features in that crate need a lot of work.


Added coverage configurations.

Changes Unknown when pulling 986c9b3982755af91b18f98d8b9b5ed34e63757a on tmatsuo:coverage into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling b383833b50c7fbb75cda5b879e5e9884b1c5ca2f on tmatsuo:coverage into ** on GoogleCloudPlatform:master**.

@amygdala can you take a look?
This CL is adding a coverall configuration (test coverage).

LGTM. This will serve as a good example for setting up better testing.

Thanks!


[Bug] Ilex Forest Grass doesn't get recognized as grass with moveToGrass()

Title

^ needs "BattleArea" detection
getMapName = getBattleArea normal / headbutt n dig / surfing
normal pulls battle area grass and map (for caves)
headbutt n dig (if any active on map clear them if possible)
Surfing (to finish off the map battle areas)
Pro's: will help script writers as theyd just need to define "normal or Surfing" in their leveling location. and could allow changing battling spots on map.
cons: rectangle wouldnt work/players would be nearly everywhere in leveling map
(ilex forest acts close enough to a cave which would map the whole map a battling area


Ensure is active exists in chipdevicectrl.py

The propertly of isActive was never set in the constructor, so if code fails early given that shutdown is called on finalize, I got odd errors like:
...
[1699641297.730103][956550:956550] CHIP:DL: BLE shutdown
[1699641297.730115][956550:956550] CHIP:DL: System Layer shutdown
ERROR:root:Final result: FAIL !
Exception ignored in: <function ChipDeviceControllerBase.__del__ at 0x7f278d98ee80>
Traceback (most recent call last):
  File "/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/venv/lib/python3.11/site-packages/chip/ChipDeviceCtrl.py", line 414, in __del__
    self.Shutdown()
  File "/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/venv/lib/python3.11/site-packages/chip/ChipDeviceCtrl.py", line 378, in Shutdown
    if (self._isActive):
        ^^^^^^^^^^^^^^
AttributeError: 'ChipDeviceController' object has no attribute '_isActive'

Set isactive in the constructor and a minor cleanup while I am at it.

fast track test tooling change


feat: port Analysis.Convex.Independent

Relatively easy file
I changed each fun x => x : foo → E into (↑) : foo → E.

bors merge


Document automatic base64 encoding of lambda ZipFile

Lambda already updated their docs for ZipFile in create_function so we don't need that here.

Resolves boto/boto3#201
cc @jamesls @kyleknap

:shipit:


Change search source config request

Description
Changes the search source config request type to take in a searchSourceBuilder so that the search request can be built in the service layer
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Request
POST _plugins/_security_analytics/threat_intel/source/_search
{
    "query": {
        "match_all": {}
    }
}

Response
{
    "took": 15,
    "timed_out": false,
    "_shards": {
        "total": 1,
        "successful": 1,
        "skipped": 0,
        "failed": 0
    },
    "hits": {
        "total": {
            "value": 1,
            "relation": "eq"
        },
        "max_score": 0.05715841,
        "hits": [
            {
                "_index": ".opensearch-sap--job",
                "_id": "byzUNpABxKcgMID9ZDxA",
                "_version": 8,
                "_seq_no": 7,
                "_primary_term": 1,
                "_score": 0.05715841,
                "_source": {
                    "source_config": {
                        "version": 8,
                        "name": "my_custom_feed",
                        "format": "STIX2",
                        "type": "S3_CUSTOM",
                        "description": null,
                        "created_by_user": null,
                        "source": {
                            "s3": {
                                "bucket_name": "threat-intel-s3-test-bucket",
                                "object_key": "bd",
                                "region": "us-west-2",
                                "role_arn": "arn:aws:iam::540654354201:role/threat_intel_s3_test_role"
                            }
                        },
                        "created_at":<PHONE_NUMBER>360,
                        "enabled_time":<PHONE_NUMBER>360,
                        "last_update_time":<PHONE_NUMBER>379,
                        "schedule": {
                            "interval": {
                                "start_time":<PHONE_NUMBER>,
                                "period": 1,
                                "unit": "Minutes"
                            }
                        },
                        "state": "AVAILABLE",
                        "refresh_type": "FULL",
                        "last_refreshed_time":<PHONE_NUMBER>677,
                        "last_refreshed_user": null,
                        "enabled": true,
                        "ioc_types": [
                            "ip"
                        ]
                    }
                }
            }
        ]
    }
}


Unable to upgrade to WinUIEx 2.0 with .Net 7.0 in Maui project

Nuget update failed:
NU1202: Package WinUIEx 2.0.0 is not compatible with net7.0-android33.0 (.NETCoreApp,Version=v7.0). Package WinUIEx 2.0.0 supports: net6.0-windows10.0.18362 (.NETCoreApp,Version=v6.0)

WinUIEx is only compatible with Windows and that has always been the case. Make sure you only include the package reference for the windows target framework.


How can I have it read the device's state?

hello, I recently started using this fork and would love to know how can I have it read the device's state? cause there is a tiny chance that my device won't switch to fan

Can you please try out the branch here: https://github.com/andersonshatch/midea-ac-py/tree/optional-fan-only-workaround
... and let me know how it works?
I cannot test myself, but this version does not have the fan_only workaround on by default, and does read state like the older versions

If it works, then I can merge into master :)

well I tried it, and I am not sure if there is something I need to do, but it's the same as the other version it still doesn't update when I use the remote for example. still uses HA's data

Can you share your home assistant logs?

On 3 Aug 2019, at 14:11, AlTracker<EMAIL_ADDRESS>wrote:
well I tried it, and I am not sure if there is something I need to do, but it's the same as the other version it still doesn't update when I use the remote for example. still uses HA's data
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

well apart from this, the log is just some info about other things (or do i enable it to debug your code?)

Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 625, in _on_handshake_complete
raise handshake_exc
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:54:27 ERROR (MainThread) [homeassistant.core] Error doing job: SSL error in data received
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 526, in data_received
ssldata, appdata = self._sslpipe.feed_ssldata(data)
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:54:27 ERROR (MainThread) [homeassistant.core] Error doing job: SSL handshake failed
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 625, in _on_handshake_complete
raise handshake_exc
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:54:27 ERROR (MainThread) [homeassistant.core] Error doing job: SSL error in data received
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 526, in data_received
ssldata, appdata = self._sslpipe.feed_ssldata(data)
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:54:27 ERROR (MainThread) [homeassistant.core] Error doing job: SSL handshake failed
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 625, in _on_handshake_complete
raise handshake_exc
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:54:27 ERROR (MainThread) [homeassistant.core] Error doing job: SSL error in data received
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 526, in data_received
ssldata, appdata = self._sslpipe.feed_ssldata(data)
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:56:14 ERROR (MainThread) [homeassistant.core] Error doing job: SSL handshake failed
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 625, in _on_handshake_complete
raise handshake_exc
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)
2019-08-03 14:56:14 ERROR (MainThread) [homeassistant.core] Error doing job: SSL error in data received
Traceback (most recent call last):
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 526, in data_received
ssldata, appdata = self._sslpipe.feed_ssldata(data)
File "/usr/local/lib/python3.7/asyncio/sslproto.py", line 189, in feed_ssldata
self._sslobj.do_handshake()
File "/usr/local/lib/python3.7/ssl.py", line 763, in do_handshake
self._sslobj.do_handshake()
ssl.SSLError: [SSL: HTTP_REQUEST] http request (_ssl.c:1056)

sorry I think that branch was missing a commit where there was a duplicate should_poll method, so it wasn't polling for updates as it was supposed to.
I thought I had pushed this a few days back, but it's definitely there now, pull again and see if that changes things.

By the way polling is set to once a minute and I don't think it will poll until 1 minute after startup, so initial state may be wrong.

Alright, So I haven't tested it for awhile, but I think it's perfect, it polls fairly quickly, it sends commands quickly, didn't switch to fan only, I have to say thank you very much man!

🎉  woohoo! Will merge to master once docs are updated