feat(cloud): support for aws ha clusters

Tasks description

closes #17

Solution

[ ] TODO

Note to reviewers

[x] Ran Tests locally
[x] Checked Contribution's guidelines

will review the code later
By that time here are the pointers for you to resolve

Resolve the resume when the vm creation fails but when trying out ksctl delete it fails due to dependency

create a dependency graph of what all resources the aws ksctl provider creates so that it will be easier to maintain

also some of the resources are now removed from the state file when deleted

here the logs does tell what is currently doing it feels like ksctl got stuck in creating the network interface but it should display the created and creating vm

mention about this error so that when in future we know why we had added the time.Sleep

@Horiodino can you rebase all the 14 commands?

also I am seeing that you have not committed with signoff-by !
if any question in setup I can help :)

@Horiodino please fix these!!
diff --git a/internal/cloudproviders/aws/vm.go b/internal/cloudproviders/aws/vm.go
index 84df6d2..4349427 100644
--- a/internal/cloudproviders/aws/vm.go
+++ b/internal/cloudproviders/aws/vm.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"sort"
 	"strconv"
+	"strings"

 	"github.com/aws/aws-sdk-go-v2/aws"
 	"github.com/aws/aws-sdk-go-v2/service/ec2"
@@ -450,6 +451,10 @@ func getLatestUbuntuAMI(client *ec2.Client) (string, error) {
 				Name:   aws.String("architecture"),
 				Values: []string{"x86_64"},
 			},
+			{
+				Name:   aws.String("owner-alias"),
+				Values: []string{"amazon"},
+			},
 		},
 	}

@@ -463,11 +468,41 @@ func getLatestUbuntuAMI(client *ec2.Client) (string, error) {
 		return "", fmt.Errorf("no images found")
 	}

-	sort.Slice(resp.Images, func(i, j int) bool {
-		return *resp.Images[i].CreationDate > *resp.Images[j].CreationDate
+	var savedImages []types.Image
+
+	for _, i := range resp.Images {
+		if trustedSource(*i.OwnerId) && *i.Public {
+			savedImages = append(savedImages, i)
+		}
+	}
+
+	sort.Slice(savedImages, func(i, j int) bool {
+		return *savedImages[i].CreationDate > *savedImages[j].CreationDate
 	})

-	return *resp.Images[0].ImageId, nil
+	for x := 0; x < 2; x++ {
+		i := savedImages[x]
+		if i.ImageOwnerAlias != nil {
+			log.Debug("ownerAlias", *i.ImageOwnerAlias)
+		}
+		log.Debug("Printing amis", "creationdate", *i.CreationDate, "public", *i.Public, "ownerid", *i.OwnerId, "architecture", i.Architecture.Values(), "name", *i.Name, "imageid", *i.ImageId)
+	}
+
+	selectedAMI := *savedImages[0].ImageId
+
+	log.Print("Selected ami image", "imageId", selectedAMI)
+
+	return selectedAMI, nil
+}
+
+// trustedSource: helper recieved from https://ubuntu.com/tutorials/search-and-launch-ubuntu-22-04-in-aws-using-cli#2-search-for-the-right-ami
+func trustedSource(id string) bool {
+	//<PHONE_NUMBER>41
+	//<PHONE_NUMBER>77
+	if strings.Compare(id, "679593333241") != 0 && strings.Compare(id, "099720109477") != 0 {
+		return false
+	}
+	return true
 }

 func (obj *AwsProvider) DeleteNetworkInterface(ctx context.Context, storage resources.StorageFactory, index int, role consts.KsctlRole) error {
diff --git a/test/e2e/args.go b/test/e2e/args.go
index 35ce144..f65696f 100644
--- a/test/e2e/args.go
+++ b/test/e2e/args.go
@@ -36,7 +36,7 @@ func GetReqPayload(l resources.LoggerFactory) (Operation, resources.Metadata) {
 		os.Exit(1)
 	}

-	payload.LogVerbosity = 0
+	payload.LogVerbosity = -1
 	payload.LogWritter = os.Stdout

 	return Operation(*arg1), payload

also if the vm fails we should be able to remove the created network interface before returning

also check with the kubernetes client why its failing

Also what I am thinking is in this PR make the necessayry changes and the subsequent PRs you can add the test cases and other jenkins things so that its much easier to review

Also what I am thinking is in this PR make the necessayry changes and the subsequent PRs you can add the test cases and other jenkins things so that its much easier to review

cc @Horiodino

@Horiodino the mock tests are failing for aws ha

if you can fix that?

if not then comment it so that the CI passes

Okay I will be commenting it out


Auto URL Sync While Scroll

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Normally, when we scroll through the documentation, the corresponding section link on the right sidebar is highlighted so that the user knows where they are. It would be great if, in addition to the highlighting, the address bar is also automatically updated. For example, when I’m on the page https://getbootstrap.com/docs/5.3/getting-started/introduction, the address bar should change to https://getbootstrap.com/docs/5.3/getting-started/introduction/#cdn-links when I scroll down to the "CDN links" section. This would allow the URL to update not only when I click on the link in the right sidebar but also while I scroll through the document.
Motivation and context
Provides more user experience

Thanks for the suggestion, @MohamadSalman11, but we'll pass on this. Automatically updating the URL while scrolling isn't standard web behavior, as URLs usually reflect deliberate user actions. We prefer to keep navigation predictable for consistency across the documentation.


No Observables out if piping debounceTime and switchMap/ mergeMap returning empty observable

Bug Report
Current Behavior
No result would be output if I piped debounceTime with siwtchMap/ mergeMap returning empty.
Reproduction

REPL or Repo link:

import { fromEvent, timer, empty } from 'rxjs';
import { debounceTime, map, switchMap } from 'rxjs/operators';

const input = document.getElementById('example');

//  for every keyup, map to current input value
const example = fromEvent(input, 'keyup').pipe(map(i => i.currentTarget.value));

// wait .5s between keyups to emit current value
//throw away all other values
const debouncedInput = example.pipe(debounceTime(500), switchMap(() => empty()));

// log values
const subscribe = debouncedInput.subscribe(val => {
  console.log(`Debounced Input: ${val}`);
});

Expected behavior
empty observables are emitted.
Environment

Runtime: any
RxJS version: v6.2.0

You're returning empty() in switchMap(() => empty()) so it never emits any next notifications which is correct behavior.

I thought emit would emit a complete notification.

Both mergeMap and switchMap ignore its inner Observable complete notification. They only merge next values and propagate errors. So switchMap(() => empty()) is effectively equal to ignoreElements().
Also, to clarify: here debounceTime doesn't affect the resulting output. The issue is particularly in switchMap(() => empty()).

Closing because it's the expected behaviour.


Null check operator used on a null value

Bug report
Describe the bug
When I query from a table "servers", it returns 500. I think this is coming from the SupabaseClient
{data: null, status: 500, error: {message: Null check operator used on a null value, details: null, hint: null, code: _CastError}, count: null}

To Reproduce
Steps to reproduce the behavior, please provide code snippets or a repository:

Create a Flutter project and a Supabase project
Configure the Flutter project that will interact with the Supabase project (Setup SUPBASE_URL and SUPABASE_SECRET)
Read records from any table of your Supabase project
{data: null, status: 500, error: {message: Null check operator used on a null value, details: null, hint: null, code: _CastError}, count: null}

Expected behavior
It should return me an array of JSON objects. And status code of 200 and not 500.
Screenshots
This is my supabase client setup

This is my query from an abstract class, then my ServerService class extends from it.

Then here is where I trigger the call to Supabase API

Tap and call method

System information

OS: Windows
Version of supabase-dart: 0.0.1-dev.11
Version of Node.js: [e.g. 10.10.0]

Flutter doctor

Additional context
In case you might need to see it for yourself, here is my repository link. https://github.com/carlomigueldy/flutter-web-discord-clone
I love supabase since it is a serverless and uses Postgres, I love relational databases :) So thanks for creating that decision instead of going NoSQL.

I cloned your project and I'm getting the same error message. It looks like an exception is thrown in the postgrest package on this line.
And indeed, method on this line is a String? that is never initialised, which throws when calling method!. This could be solved by making method as required in PostgrestBuilder's constructor or by putting a default value (like "get" for example), not sure what's best.

Actually the issue is that you called .execute() directly on from("servers"). There is no query to execute. Try replacing
final response = await Supabase.client.from("public").execute();

with
final response = await Supabase.client.from("public").select().execute();

Still this is a bit confusing. It should either not be possible to call execute() directly, or it should return a more explicit error.

I implemented a fix here

Thank you @thalkz @phamhieu! Will take a look now.

Will close the issue now.
If this https://github.com/supabase/postgrest-dart/commit/5f6e140c53a2f61de5a7cba2fdbb6326ae3ee93a gets merged then would also be great


Handle Objects with a toString method implemented

Looks like TS has a bug or can be improved here -
I am using an event emitter (NodeJS) like so:
const EE = require('events');

const ee = new EE();

const obj = {
  foo: 'bar',
  toString: function(){
       return 'all dogs go to heaven';
  }
}

ee.emit(obj);   // in the node.js core codebase for EventEmitter, toString() will be called on obj

What's happening is it's saying ee.emit doesn't take an object like this - but with the toString method defined, ee.emit should actually accept it. Sometimes TS can do inference sometimes it can't.
I am 99% certain this is a bug or deficiency. I am not sure which party would be responsible for updating a d.ts somewhere, but would be happy to help out if this an actual bug or whatever. Not sure if it's possible to inspect objects like this to see if they have a toString method implemented, so might be asking too much, especially considering the object is not typed with TS.
Maybe the answer is that I should type it with TS.
In the image below, you can see that events.NODE_VERSION is being passed to ee.emit. In this case, events.NODE_VERSION has the same signature as obj above.

The function should be declared with a signature like this:
declare function log(x: string | { toString(): string }): void;


ADD encode / decode node

Proposed changes
This PR adds encode / decode node.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.
[ ] Maintain repository

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[X] I have updated the change log (CHANGELOG.md)
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

62 of 62 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
552

Relevant Lines:
552

💛  - Coveralls


Bug: Migration status not working with different namespaces

PHP Version
7.4
CodeIgniter4 Version
4.1.7
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Windows, Linux
Which server did you use?
apache
Database
MySQL 8.0.27-0ubuntu<IP_ADDRESS>
What happened?
On the command php spark migrate:status
The migrated details for columns "Group", "Migrated On", "Batch" are missing on all namespaces besides App namespace.
Please refer to the image below:

Steps to Reproduce
Do migration on multiple namespaces and check php spark migrate:status
You will see that data for columns "Group", "Migrated On", "Batch" missing for all namespaces besides App namespace,
Expected Output
php spark migrate:status
"Group", "Migrated On", "Batch" data on all namespaces.
Anything else?
No response

@demirkaric The screenshot was deleted.
You can upload it to GitHub by dragging it into the text area.

I've confirmed this bug.
$ php spark migrate:status

CodeIgniter v4.1.7 Command Line Tool - Server Time: 2022-01-20 02:49:14 UTC-06:00

+-----------+-------------------+-----------------------+---------+---------------------+-------+
| Namespace | Version           | Filename              | Group   | Migrated On         | Batch |
+-----------+-------------------+-----------------------+---------+---------------------+-------+
| App       | 2022-01-20-084314 | CreateCiSessionsTable | default | 2022-01-20 02:47:08 | 1     |
| Myth\Auth | 2017-11-20-223112 | create_auth_tables    | ---     | ---                 | ---   |
+-----------+-------------------+-----------------------+---------+---------------------+-------+

SELECT * FROM `migrations`

id	version	class	group	namespace	time	batch
1	2022-01-20-084314	App\Database\Migrations\CreateCiSessionsTable	default	App<PHONE_NUMBER>	1
2	2017-11-20-223112	Myth\Auth\Database\Migrations\CreateAuthTables	default	Myth\Auth<PHONE_NUMBER>	2

@demirkaric Try this:
--- a/system/Commands/Database/MigrateStatus.php
+++ b/system/Commands/Database/MigrateStatus.php
@@ -108,6 +108,7 @@ class MigrateStatus extends BaseCommand
                 continue;
             }

+            $runner->setNamespace(null);
             $history = $runner->getHistory((string) $group);
             ksort($migrations);

@demirkaric Try #5605 if you can.


Add infrastructure team

r? @alexcrichton

Not necessarily in this PR, but might be nice to get https://github.com/rust-lang/rust-www/blob/556acef2216ee02449b60dc18e12c65e51939fd7/en-US/community.md#the-rust-team updated too

@frewsxcv done thanks!

🎊


Provide a code that uses Dependency Injection with MSTEST sample for DOTNET CORE

The samples provided in MSTEST is extremely high level.  Common usage usually based on Dependency Injection and would like to see a full sample that covers it.
Reference https://github.com/dotnet/docs/blob/master/docs/core/testing/unit-testing-with-mstest.md

@ghogen Should this move to your repository, covering MS Test in detail? We can provide links to any content that's already available there.

@erickson-doug @alexhomer1 As the owners of test scenarios for VS, what do you think about where the MS Test content should go?

This is covered... closing


[FEA] Provide ability to use a custom requirements.txt file in App Packager

Currently, the requirements.txt file for App packaging is created from @env(pip_packages=...) decorators of Operators&Application class.
When many operators are involved, it might be simpler to provide a way to use an external requirements.txt file.
Example) -r, --requirement <file> option can be added.
python examples/apps/simple_imaging_app/app.py -i examples/apps/simple_imaging_app/brain_mr_input.jpg -o output -r requirements-examples.txt

/cc @KarthikMasi
Discussions from https://projectmonai.slack.com/archives/C01PAL02V8D/p1630005652048800

Handled by #110
closing this.


Timber Navigation Slidedown

Hi I am having trouble implementing the slideDown function to the timber menu how can I achieve this:
function showDropdown ($el) {
$el.slideDown(1000);
setTimeout(function() {
timber.cache.$body.on('touchstart', function() {
hideDropdown($el);
});
}, 250);
}

The current set adds a class to .site-nav--has-dropdown. Using slideDown on that won't do anything because it's already visible. You want to set it on the child inside of that. Do that with $el.find('.site-nav__dropdown').slideDown(1000);
You'll have to do the same in the hideDropdown method.

And here I was doing this with CSS :P

CSS is my preferred method too, though depending on how much the dropdown heights will vary it can be challenging. Lately I've found an opacity and translateY have been great in all situations.

You da man thanks!


Loader does not launch on Mac OS; only the title screen music is heard or an undecorated and unusable frame is created

do it. @hYdos

this is a problem with upstream loader. create an issue there.

Until legacy floader gets merged into upstream loader this is our issue.
Thanks for reporting it. This is being pinned

the loader wont be getting merged upstream due to its disliked guava hacks.

concern

stop

this shows up in my github feed. ill always know when you open it

The issue is on our side, this is not resolved, please do not close an issue just because it bothers you in your feed, closing it does not mean that the issue is resolved.

this is a upstream issue and it is not our priority to fix things for them

here's a workaround
https://gist.github.com/BoogieMonster1O1/33da454fc697413d7807569957351192


does etcd supports adding new node(peer) dynamically into the etcd cluster with tls?

Hi,
I am new to etcd.Its a query related to etcd cluster with tls. does etcd supports adding new node dynamically into the etcd cluster? in that case are we using dynamic reconfiguration or how we are updating the peer info which we are using while bringing up a node?
do we need to re generate the certificates?(https://github.com/coreos/etcd/blob/master/Documentation/security.md             mentioned  as  "If you need your certificate to be signed for your member's FQDN in its Subject Name then you could use Subject Alternative Names (short IP SANs) to add your IP address. The etcd-ca tool provides --domain= option for its new-cert command, and openssl can make it too.")

does etcd supports adding new node dynamically into the etcd cluster? in that case are we using dynamic reconfiguration or how we are updating the peer info which we are using while bringing up a node?

Yes. Doc is here: https://github.com/coreos/etcd/blob/master/Documentation/runtime-configuration.md
You can read more about its design here: https://github.com/coreos/etcd/blob/master/Documentation/runtime-reconf-design.md.

do we need to re generate the certificates?

You do not have to re-generate existing certs.

@SrinivasChilveri I think your question is answered. Closing this due to low activity.


Unable to add input values in Workflow.

Describe the bug

Unable to add input values Whenever i click on input ,the popper hides.

To Reproduce
Steps to reproduce the behavior:

Go to workflow library, and try adding a workflow
Select Text field,interval,email,number and see it opens n hides the popups suddendly

Expected behavior

User should be able to add input values
On opening a new popup ,previous popup's should close,

Screenshots
https://github.com/sourcefuse/workflows-creator/assets/109737499/a5a851ae-6d2d-403a-850d-051ca746a121
Additional context
Add any other context about the problem here.

Got it fixed, It was some css bug when web-component was rendered at the same time, a modal is rendered.


RMF fleet adapter nav2 for Ionic demo

This PR adds the RMF fleet adapter that works with nav2 to the Ionic demo world, including the following:

Fleet adapter that subscribes to /tf and sends out commands using the nav2_simple_commander package
RMF building map for the Ionic demo
Dispenser for coke can pickup working

Let's try to get this in. Looks like it's working reliably? Do you plan to make more changes?

nice! I was able to run the whole OpenRMF demo with some minor changes. I'll get this PR in first to get the dashboard docker image uploaded. I'll create a separate PR with my changes


Onchain contract calls in the tracker package / indexes.json

We should have a way to grab on-chain events for transformation.
E.G.: Ampleforth price on Uniswap and volume - then do the daily VWAP or TWAP

see https://github.com/tellor-io/telliot/pull/316

things to be careful of:  how do we make mainnet calls when syncing a rinkeby database?
how do we minimize contract calls?


Define smart contracts primitives

What is a primitive? Why do we need primitives? Which primitives do we want?

[ ] All POD(Plain Old Data) from Michelson

We have the core Zinc operations:
  | Grab
  | Return
  | PushRetAddr of 'a zinc
  | Apply
  | Access of int
  | Closure of 'a zinc
  | EndLet

We have Plain Old Data:
  | Bool of bool
  | String of string
  | Num of Z.t
  | Eq
  | Key of string
  | Hash of string
  | Add
  | Bytes of bytes
  | Mutez of Z.t

We have some ADT operations:
  | MakeRecord of label list
  | RecordAccess of label
  | MakeVariant of label
  | MatchVariant of (label * 'a zinc) list

And we have operations on data:
  | HashKey
  | Address of address
  | ChainID
  | Contract_opt
  | MakeTransaction
  (* Adding this to make contracts easier to interpret even though I think it's technically unecessary  *)

We have failwith for early failures:
  | Failwith

And we have some special "extension" primitives that are similar to Plain Old Data but can't be written in code directly
  | Contract of contract
  | Operation of operation


Only handle special native key bindings on OS X

Our current approach relies on menu.sendActionToFirstResponder, which is only defined on OS X. It would be good to actually make this work elsewhere, but this will at least prevent the exception for the undefined method.

I know this one, I know this one! Start here: https://github.com/atom/electron/blob/master/docs/api/browser-window.md#webcontentsundo

@paulcbetts Thanks for that. Check out the amended PR. I would actually like to always handle these commands if they bubble to the root of the document without the default being prevented or propagation being stopped, but changing the behavior now might introduce unintended consequences. I'm just going to fix the exception for now.

@nathansobo Seems Legit™


Style compiling issue

both of the images have the same sass styles, same html template, component used in routing so it appears under router-outlet,
the left one is built with angular-2-meteor and the right side is built with angular2 project created with angular cli.
Spent almost the whole day trying to fix the damn resizing when I knew that it should be working,
I can upload the sass,html and ts file for testing.
@Urigo @barbatus

Hi @ayazhussei, can you share a repository with your code?
Note that there are differences in files loading between Angular 2 project and Angular2-Meteor project, because we are using Meteor build process.

invitation sent.
@dotansimha

@dotansimha
I noticed something wrong with the width of the body, it doesn't get below 980px and the height is just going crazy..  if that helps..

@ayazhussein Could you add me also?

@ayazhussein I've created a PR, check it and tell me if it fixed the problem.

seems that it was fixed. rookie mistake. sorry


New Resource SqlServerSecureConnection

Pull Request (PR) description
Additional resource to setup an encryptedconnection in SQL
This Pull Request (PR) fixes the following issues
None
Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

Codecov Report

Merging #1212 into dev will decrease coverage by <1%.
The diff coverage is 54%.

@@         Coverage Diff          @@
##            dev   #1212   +/-   ##
====================================
- Coverage    97%     97%   -1%
====================================
  Files        33      34    +1
  Lines      4044    4118   +74
====================================
+ Hits       3957    3997   +40
- Misses       87     121   +34

@mcollera I'm gonna merge 3 other PR's today, I suggest you wait to rebase until those are merged, to minimize the times you need to rebase. 🙂

This is how it looks on the AppVeyor build worker (when RDP into it).

So I guess the FQDN is $env:COMPUTERNAME for the AppVeyor build worker? Will that work?
The first item in the list of the property SuffixSearchList is the primary DNS suffix, if configured. So for the build worker it is not configured, but we could the first item if it is not $null and suffix that to the computer name, so it will work in another test environment, with an actual domain?
Running this
New-SelfSignedCertificate -DnsName $env:COMPUTERNAME, $env:COMPUTERNAME -CertStoreLocation "cert:\LocalMachine\My"

Gives

That we could run Export-PfxCertificate on, and then Import-PfxCertificate into the trusted store?
If you think this can work, then it would be great to get an integration test. But you have the best knowledge of this, I guess the FQDN part is the most difficult.

Tested this code manual on the build worker. Got a few gotchas. I think it will be very good if we can test this in an integration test.
Also test with another resource so they can work together, connect with encryption enabled. If they don't then we must add a backlog issues to get that support.
Installed the certificate into the personal store, and imported into the root store.
PS > New-SelfSignedCertificate -DnsName $env:COMPUTERNAME, $env:COMPUTERNAME -CertStoreLocation "cert:\LocalMachine\My"

   PSParentPath: Microsoft.PowerShell.Security\Certificate::LocalMachine\My

Thumbprint                                Subject
----------                                -------
5FD0BF853C5BB369A1227211A43E7C094AA648A8  CN=APPVYR-WIN

PS > $mypwd = ConvertTo-SecureString -String "1234" -Force -AsPlainText
PS > Get-ChildItem -Path cert:\localMachine\my\5FD0BF853C5BB369A1227211A43E7C094AA648A8 | Export-PfxCertificate -FilePath C:\mypfx.pfx -Password $mypwd
PS > Import-PfxCertificate -FilePath C:\mypfx.pfx -CertStoreLocation Cert:\LocalMachine\Root -Password $mypwd

   PSParentPath: Microsoft.PowerShell.Security\Certificate::LocalMachine\Root

Thumbprint                                Subject
----------                                -------
5FD0BF853C5BB369A1227211A43E7C094AA648A8  CN=APPVYR-WIN

After that integration tests for SqlSetup ran finiished (made a stripped down debug branch for testing), I manually ran this
Set-TargetResource -InstanceName DSCSQL2016 -Thumbprint 5FD0BF853C5BB369A1227211A43E7C094AA648A8 -ForceEncryption $true -Ensure Present -ServiceAccount "svc-SqlPrimary"
# Maybe it should be
# -ServiceAccount "$($env:COMPUTERNAME)\svc-SqlPrimary"
# but tested with the above.

When debugging row by row, it first failed on this
            $superSocketNetLib.SetValue('Certificate', $Thumbprint)
            $superSocketNetLib.SetValue('ForceEncryption', [int]$ForceEncryption)

with the errors
Exception calling "SetValue" with "2" argument(s): "Cannot write to the registry key."
At C:\Users\appveyor\Desktop\Untitled1.ps1:296 char:13
+             $superSocketNetLib.SetValue('Certificate', $Thumbprint)
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : UnauthorizedAccessException

[DBG]: PS C:\Users\appveyor>>
Exception calling "SetValue" with "2" argument(s): "Cannot write to the registry key."
At C:\Users\appveyor\Desktop\Untitled1.ps1:297 char:13
+             $superSocketNetLib.SetValue('ForceEncryption', [int]$Forc ...
+             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : UnauthorizedAccessException

I went in an set the values manually in the registry to continue testing.
It went in to Set-CertificatePermission, but here the $cert.PrivateKey.CspKeyContainerInfo.UniqueKeyContainerName doesn't return a value, so the path end up wrong, but the permission is set on the root folder, and then the Test-CertificatePermission will return $true since it also look at the wrong path.
[DBG]: PS C:\Users\appveyor>> $keyName = $cert.PrivateKey.CspKeyContainerInfo.UniqueKeyContainerName

[DBG]: PS C:\Users\appveyor>> $keyFullPath = $keyPath + $keyName

[DBG]: PS C:\Users\appveyor>> $keyFullPath
C:\ProgramData\Microsoft\Crypto\RSA\MachineKeys\

I continued, but then it failed on
Restart-SqlService -SQLServer localhost -SQLInstanceName $InstanceName

This error is most likely because the 'appveyor' account wasn't allowed to connect.
VERBOSE: Found PowerShell module Sqlps already imported in the session.
System.InvalidOperationException: Failed to connect to SQL instance 'localhost\DSCSQL2016'.
At C:\projects\sqlserverdsc\DscResources\CommonResourceHelper.psm1:89 char:5
+     throw $errorRecordToThrow
+     ~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], Exception
    + FullyQualifiedErrorId : MachineStateIncorrect

After this I tried to manually restart the SQL Server service. But it failed to start. So I went into the Manage Private Keys on the certificate in certlm.msc, and added the account for read on the primary key.

After that I could start the service again.
The appveyor build worker terminates after 60 minutes so couldn't test to connect with an accurate account to the instance after the certificate was in place.

I see these issues

The $superSocketNetLib.SetValue() give errors.
The $cert.PrivateKey.CspKeyContainerInfo.UniqueKeyContainerName doesn't return a value for all accepted certificates (?).
Restart-SqlServer should be able to connect to the instance when force encryption is enabled. Maybe this do work already.

What account are you logged in with? And are you running elevated? I wonder if it’s a permission issue I’m powershell
Get Outlook for iOShttps://aka.ms/o0ukef

From: Johan Ljunggren<EMAIL_ADDRESS>Sent: Friday, September 7, 2018 11:47:27 AM
To: PowerShell/SqlServerDsc
Cc: mcollera; Mention
Subject: Re: [PowerShell/SqlServerDsc] New Resource SqlServerSecureConnection (#1212)
I see these issues

The $superSocketNetLib.SetValue() give errors.
The $cert.PrivateKey.CspKeyContainerInfo.UniqueKeyContainerName doesn't return a value for all accepted certificates (?).
Restart-SqlServer should be able to connect to the instance when force encryption is enabled. Maybe this do work already.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SqlServerDsc/pull/1212#issuecomment-419481994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdeNDOe0NtDsZbjRlaO4hOBU96X67uJuks5uYpUPgaJpZM4WZhCx.

I think the AppVeyor build worker is always running elevated, but not certain now. If you think it’s a permission error, then it will work when the new integration test runs.

Yeah because then it will run as system. I think it is just because you were able to set everything manually when logged in.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Johan Ljunggren<EMAIL_ADDRESS>Sent: Friday, September 7, 2018 11:54:52 AM
To: PowerShell/SqlServerDsc
Cc: mcollera; Mention
Subject: Re: [PowerShell/SqlServerDsc] New Resource SqlServerSecureConnection (#1212)
I think the AppVeyor build worker is always running elevated, but not certain now. If you think it’s a permission error, then it will work when the new integration test runs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SqlServerDsc/pull/1212#issuecomment-419484204, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdeNDP_72iwtJC0FjZzdZzHIRsuTROZwks5uYpbMgaJpZM4WZhCx.

I was logged in with the default account “appveyor”.
You can test this manually your self too. You can connect your fork to AppVeyor (it’s free), and then when you push branches to your fork you can see the test runs. You can add settings in the AppVeyor.yml file that says it should enable RDP and it will give you the username and password. See link in previous comment how to enable it.  Important to use the “on_finished” so it breaks when the test run is done (and not terminate the build worked directly).

Yes precisely, it will run as system by default. But it can also be run using PsDscRunAsCredential, running it as a user, so if that is a problem then a requirement will be that it must run as system. But it should be able to be run as a local admin user too right?

Yes it should. And dsc will be elevated.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Johan Ljunggren<EMAIL_ADDRESS>Sent: Friday, September 7, 2018 12:01:08 PM
To: PowerShell/SqlServerDsc
Cc: mcollera; Mention
Subject: Re: [PowerShell/SqlServerDsc] New Resource SqlServerSecureConnection (#1212)
Yes precisely, it will run as system by default. But it can also be run using PsDscRunAsCredential, running it as a user, so if that is a problem then a requirement will be that it must run as system. But it should be able to be run as a local admin user too right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SqlServerDsc/pull/1212#issuecomment-419486123, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdeNDPawwpg67i69fi6_tGbvm_KlGrqXks5uYphEgaJpZM4WZhCx.

Then it just probably the certificate problem, that it didn’t have a RSA private key on disk. It should support all accepted certificates.

You have to have a private key though for this to work.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Johan Ljunggren<EMAIL_ADDRESS>Sent: Friday, September 7, 2018 12:05:03 PM
To: PowerShell/SqlServerDsc
Cc: mcollera; Mention
Subject: Re: [PowerShell/SqlServerDsc] New Resource SqlServerSecureConnection (#1212)
Then it just probably the certificate problem, that it didn’t have a RSA private key on disk. It should support all accepted certificates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SqlServerDsc/pull/1212#issuecomment-419487257, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdeNDJjw8XCtcNvwIKu7b3SZXZxxOQx-ks5uYpkvgaJpZM4WZhCx.

But it has a private key on the certificate in the cert store. That isn't enough? See screen shot on the certificate, and I manually added permission to the private key (in the cert store) for the SQL Server service account to access it. Then the service started correctly. It did not start when the permission was not there.

I run the tests again, and by default the 'appveyor' account is elevated, but run with 'Run as administrator' anyway just in case, and the 'appveyor' account is local admin. Still fails.

Is it possible for me to remote in?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Johan Ljunggren<EMAIL_ADDRESS>Sent: Friday, September 7, 2018 12:29:30 PM
To: PowerShell/SqlServerDsc
Cc: mcollera; Mention
Subject: Re: [PowerShell/SqlServerDsc] New Resource SqlServerSecureConnection (#1212)
I run the tests again, and by default the 'appveyor' account is elevated, but run with 'Run as administrator' anyway just in case, and the 'appveyor' account is local admin. Still fails.
[image]https://user-images.githubusercontent.com/7189721/45231297-debf8a00-b2cb-11e8-97e1-07acce11ebe6.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/SqlServerDsc/pull/1212#issuecomment-419494248, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdeNDFKDXswjfCVImgE6FtpkvwkCrpPxks5uYp7qgaJpZM4WZhCx.

Sure, the RPD information is in line 7; https://ci.appveyor.com/project/johlju/sqlserverdsc?fullLog=true
30 minutes left, after that the build worker terminates.

I have not forgotten about this one, but haven't had time to get back to this yet. Hopefully tomorrow. 🙂

@mcollera Just want to say that I think you do an awesome job with this new resource! 😃

@mcollera This is now merged. Thank you for your awesome work on this one! 😃

@mcollera I missed (again) that the entry in the CHANGELOG.md merged into the wrong place (because of the last release that modified the change log). I will fix it in the PR #1221.


Is site["scale"] double counted at non-reparameterized sites?

The Problem
Consider the surrogate elbo at a nonreparameterized site (as computed in Trace_ELBO)
log_p = model_site["log_pdf"]
log_q = guide_site["log_pdf"]
surrogate_elbo = log_p + (log_p - log_q).detach() * log_q

Now suppose this site occurs in an irange where we're subsampling 1% of the data, so that a ScalePoutine sets site["scale"] = 100. Then Trace.log_pdf() will scale both log_p and log_q by 100. Therefore the surrogate_elbo's first term log_p will be scaled by 100, but the second term (log_p - log_q).detach() * log_q will be scaled by 100 * 100.
Scope
This should only affect models in one of the following scenarios:

The model has both global and local sites, and the local sites are non-reparameterized and subsampled.
The model has local sites that are non-reparameterized and subsampled and includes model parameters at that site (not only guide parameters).

Possible Solutions

Handle site["scale"] separately, outside of Trace.log_pdf(). This scale is already wired through Trace_ELBO and TraceGraph_ELBO as weight.
Pros: Avoids being too clever. Plays well with scale that varies across a batch (as in BranchPoutine).
Cons: May require special treatment of site["scale"] in many places outside of Trace_ELBO and TraceGraph_ELBO.
Keep the existing logic of Trace.log_pdf(), and remove a factor of site["scale"] from the (log_p - log_q).detach() * log_q term.
Pros: Minimally invasive.
Cons: Seems like a hack. Does not play well with scales that vary across a batch.

but the second term (log_p - log_q).detach() * log_q will be scaled by 100 * 100.

Is this really a bug?
log_p_scaled is a good estimate of log_p_true, similarly for log_q. If you want to compute an estimate of (log_p_true - log_q_true) * log_q_true then (log_p_scaled - log_q_scaled) * log_q_scaled gives you that.
If you get lucky and log_p_scaled = log_p_true (likewise for q) then you'll compute the exact thing. This wouldn't be the case if you pulled an extra scaling factor as proposed here?

@null-a Yes I think you're right that this works as intended in Trace_ELBO. Thanks for explaining!
I'm still a little confused about TraceGraph_ELBO, which for an entirely local model computes surrogate_elbo independently for each datum in a minibatch. I would expect the surrogate_elbo values to be scaled by scale = size/subsample_size, whereas in practice it is the log_p and log_q that are scaled, so that surrogate_elbo is scaled twice. Do you think it's possible that Trace_ELBO is correct, but TraceGraph_ELBO is incorrect?

i'm afraid @fritzo is right. there's an implicit rao-blackwellization that happens when you subsample which makes it a bit confusing. we'll fix it.


[BUG] Notification Sound Plays Regardless of Runelite Global Settings

Describe the bug
The idle notification sound continues to play regardless of the Runelite application Global Notification Settings. I do not think a plugin should be able to ignore the core notification settings and other idle notifiers are able to respect the global notification settings.
To Reproduce
Steps to reproduce the behavior:

While using the runelite-plugin-action-progress
Click on Configuration -> search Runelite
Scroll down to Notification Settings
Turn off Sound, Volume, timeout, disable tray icons and notifications
Fill inventory with chisel and gems, begin to chisel gems, and listen for notification sound which will play regardless of the notification settings within Runelite

Expected behavior
The sound should not play if the global settings have indicated that the user does not want notifications. This is actually a pretty annoying bug because nothing indicates where the sound is coming from so it's hard to even narrow down the issue to your app but it is reproducible
Screenshots
If applicable, add screenshots to help explain your problem.

I think this is a Runelite issue. Runelite shouldn't allow notifications if they are turned off


[Internal] MicroBenchmark: Adds Include auth into micro benchmark

Including auth into the performance benchmark
Auth token generation is NO-OP in micro benchmark.
Change includes auth implementation.

 Lets just focus on allocations and GC's
Surprisingly allocations are more higher with the new implementation.
 Also thoughts on how to measure the impact of these changes?

Hey Kiran - I am unable to reproduce the same difference - can we chat and figure out what the differences might be with what i'm seeing?


refactor(internal)!: Pretty print build result

Prerequisite checklist

[x] Read the contribution guidelines regarding submitting new changes to the project;
[x] Tested your changes against relevant architectures and platforms;
[x] Ran make fmt on your commit series before opening this PR;
[ ] Updated relevant documentation.

Description of changes

This PR ultimately reworks the kraft build such that it outputs useful information to the user after a successful build.  In order to make this possible, a number of maintenance changes are included.  The way in which the output is presented is also represented on kraft cloud deploy, and the same mechanics to show this information are utilized via the introduction of a new internal package fancymap.

Hey @nderjung can you integrate #854 also in this
Previously this was partially-blocked on no clean way of showing results

Hey @nderjung can you integrate #854 also in this
Previously this was partially-blocked on no clean way of showing results

i just had a proper look at #854. In the end, Printloc just calls:
$(shell $(OBJDUMP) -dl "$(1)" | grep '^/' | grep -v '^/[/*]' | $(SED) -e 's/ [(]discriminator .*[)]//g' | sort -u | wc -l)

on the debug image.
I think a). we should probably get this in first so that #854 can be rebased on top of this, and b). that the Printloc method in the application is simplified to just call this, it seems like an unnecessary set of indirection.
Additionally, i can see us dumping a new file, e.g. .unikraft/build/stats.json which include all the statistics which are gathered during the build, e.g. number of build files, build time, etc. This will make the look up faster. Finally, a kraft build stats could be used to display it using the new fancymap package.


vncdotool capture screen bug

vncdotool cannot work without vnc client when capture the screen

Seems logical...

Suggest to close this

unclear what the issue is


Tabs in the editor ... #2892

What you mean with duplicate? I cannot put my tabs in my desired order because after that the Spyder just put in its own order, this is it ..., if you know how please just answer this email and show me how ...

The issue is a duplicate as it has already been reported. A quick search in github will give you more informations (I'm on my phone right now)

The issue is a duplicate as it has already been reported. A quick search in github will give you more informations (I'm on my phone right now)


Publish on itch.io

itch.io would be a good platform for a casual game like this. Inform about publishing requirements and do it.
WASM is already there, so it should be simple.

🥳 Done! https://mlange-42.itch.io/tiny-world


Increase CCF version

Feature Suggestion
Is your feature request related to a problem? Please describe.
Because I needed to improve the Azure region support, I contributed to https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/823. Now I would like to know how to integrate these changes in this plugin?
© 2022 Thoughtworks, Inc.

@4upz any thought about this ?

Hi @LvffY, we made a new release late last week for both CCF and the backstage plugin which should include your contributions for the Azure region support. Have you tried updating your plugin version to see if these changes are reflected? Or doing a fresh install or for the plugin?
Let us know if either of those work!

@4upz I think I tried this last week, may be a bit ealy tho.
I'll try to test it again :)

I think I've found another issue.
I've done the following steps.
yarn --cwd packages/backend add @cloud-carbon-footprint/backstage-plugin-backend
yarn --cwd packages/app add @cloud-carbon-footprint/backstage-plugin-frontend

Then followed the steps described in the README.
My baskstage instance is running.
Once on the /cloud-carbon-footprint page, I have the following error

Looking at the logs, I have the following lines :

From my understanding, this is related to my use case where I use some Azure DevOps builds. I don't know which use cases are supported through CCF ?
Is there any configuration that could, temporaly, ignore some VM type or so ?

I just found another error lines :

@4upz It's probably not linked to this particular backstage version, we should probably update the issue title.
But how can we move forward this problem?

@4upz No problem :)
For now I have seen 3 distincts errors :

Unexpected usage type for storage service: Basic User
Unexpected usage type for storage service: Standard Nodes
Unexpected usage type for storage service: Microsoft-hosted CI

I tried to look into the page you linked but I'm stuck on where to put these values. I actually don't really want to ignore these usages (because they are a big part of my context) so I don't see where to put these values.
Could you help me on this ? (TBH, I could ignore the Basic User but I would really want to see the CCF of my CI/CD on Azure DevOps).
One more case : could this be a good idea to have an option to ignore these errors and still have our CCF in our backstage ?
For now I just created https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/861 with a fix for a dead link in the doc

@LvffY No worries, you wouldn't be ignoring them. You would instead be adding them as supported usage types for that respective service. So for example, inside of the ConsumptionTypes.ts, you would add Microsoft-hosted CI to the Storage_Usage_Types constant. The warning gives away which service you should be adding the usage type to. For the example that I chose, it should look like this:
export const STORAGE_USAGE_TYPES: string[] = [
   ...
  'Pay-as-you-go Data at Rest',
  'Standard Instances',
  'Node',
  'Basic User'
]

As for the error, the unsupported usage types are just logged warnings from the api and aren't actually errors that would break the app. They should only be skipping those services from being included in the estimates. That error may actually be caused by something else -- especially since you seem to still have estimates included in the filters from your screenshot. Would you mind clicking that drop down or providing a screenshot of the inspector error log to see if it shows more details pertaining to that error?

@4upz Thanks for your help !
I think I have a working PR in https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/pull/861 if you want to take a look.
For my error (for the first time --') I click on the arrow on the right of the error and I get the following lines

I'm not sure where to look to find this. May be something related to my configuration ?

Closing because the remaining issue will likely be solved with https://github.com/cloud-carbon-footprint/cloud-carbon-footprint/issues/864


Update README.md

change the version for Xcode9

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Is this true @shahmishal?

About Xcode 9 beta 4 document
https://download.developer.apple.com/Developer_Tools/Xcode_9_beta_4/Xcode_9_beta_4_Release_Notes.pdf

@ZhengShouDong this repository does not necessarily track the latest and greatest Xcode as a build requirement.  We periodically update the SDKs/Xcode install on the bots and only then do we update the README.

We don't currently support building Swift compiler with Xcode 9 beta 4 yet.

And in fact we require patches to build with it, although those patches are quite minor.


WalletConnect confirmation not available on Huawei

User reported that WalletConnect does not work on Huawei device.
The exact issue is that:

WalletConnect connection successful
Initiating transaction leads to:  pending screen and no transaction confirmation screen in Wallet:

Device: Huawei, P20
Version: 3.21.1 (140)

User got it working on un-install/re-install


Realm: App: log_in_with_credentials failed: 401 message: invalid id token: 'aud' must be a string containing the client_id

What happened?
I implemented authorization through Google. Authorization works through Google on the Android platform, but does not work on the iOS platform. Error: Realm: App: log_in_with_credentials failed: 401 message: invalid id token: 'aud' must be a string containing the client_id
I think it doesn't work because each platform has a different client_id, and in mongodb atlas only set one client_id for google provider.
How can this be fixed? I need to authorize through google on two platforms. I may need to do this on other platforms as well in the future.
Translated with www.DeepL.com/Translator (free version)
Repro steps
logging in through google on the ios platform
Version
Flutter 3.7.7, Realm 1.0.2
What Atlas Services are you using?
Both Atlas Device Sync and Atlas App Services
What type of application is this?
Flutter Application
Client OS and version
Android 11
Code snippets
final AppConfiguration appConfig = AppConfiguration(Config.mongoAppID);
_app = App(appConfig);
_googleSignIn = GoogleSignIn(
serverClientId: Platform.isAndroid
? "104871183495*-pbs13p6rk8jahhdbc45ag50rst2c****.apps.googleusercontent.com"
: "104871183495*-n83avo1avbddc4i3njt88016v0ng****.apps.googleusercontent.com",
scopes: [
'email',
'profile',
"openid",
'https://www.googleapis.com/auth/userinfo.email',
'https://www.googleapis.com/auth/userinfo.profile',
],
);
GoogleSignInAccount? signRes = await _googleSignIn.signIn();

if (googleSign != null) {
  GoogleSignInAuthentication auth = await googleSign.authentication;

  if (auth.idToken != null) {
    user = await _app.logIn(Credentials.googleIdToken(auth.idToken!));
  }
}

Stacktrace of the exception/crash you're getting
Realm: App: log_in_with_credentials failed: 401 message: invalid id token: 'aud' must be a string containing the client_id

Relevant log output
No response

I wrote wrong "Client OS and version". I used iOS 16.2

I see your point 🤔
Would using Firebase Authentication be an option? There the aud is taken from the project name, and is stable between iOS and Android. You would then use the jwt credentials instead:
final app = App(AppConfiguration(...));
final user = app.currentUser;
if (user != null) return user;

// trigger firebase authentication

final firebaseUser = FirebaseAuth.instance.currentUser;
if (firebaseUser != null) {
  final jwt = await firebaseUser.getIdToken();
  final user = await app.logIn(Credentials.jwt(jwt));
  return user;
}
...

You can use the suite of firebase_ui_* packages to integrate with various providers:
  firebase_ui_auth: ^1.1.16
  firebase_ui_oauth_apple: ^1.0.23
  firebase_ui_oauth_facebook: ^1.0.23
  firebase_ui_oauth_google: ^1.0.23


Infra: Create mistralrs-bench

I think it should be mostly a copy of https://github.com/ggerganov/llama.cpp/blob/master/examples/llama-bench/README.md
Makes it easy to compare the 2 projects
Our current --prompt setup is good enough for profiling but not for benchmarking.
Refs https://github.com/EricLBuehler/mistral.rs/pull/162#issuecomment-2060055590

Thanks for bringing this up. If you want to start this, that would be great although I can also implement it tomorrow.

I'll start it.

Sounds good.


Security compliance merge

Merge Security compliance

Changes were made in the security compliance branch that need to be merged back into the main branch.

Codecov Report
Patch has no changes to coverable lines.
:loudspeaker: Thoughts on this report? Let us know!.

Closing this PR as moving to a new release strategy and we will be moving away from utilizing an SC branch.


[BUG] The download of data set could fail, and retry is not supported

Describe the bug
The download of data set could fail: https://github.com/alibaba/GraphScope/runs/5640280386?check_suite_focus=true
We need at least add support for "retry" in the download part, and add an optional graphscope.set_option(dataset_download_retries) to allow users to configure the behaviour.
The default value could be 3.
Additional context
Add any other context about the problem here.

ref: https://github.com/urllib3/urllib3/blob/main/src/urllib3/util/retry.py


Add zgtf to conda

Add zgtf to conda

Fixed via https://github.com/bioconda/bioconda-recipes/pull/28457


Fix Microphone access (on macOS)

This so far only requests permission when saving a VM with HDA card, needs to be extended to cover AC97 as well. Preferably it should be determined by the VM Config if microphone access is needed, and not in the UTMData.
Also just giving access does not seem to fix the guest mic access issue (recording still contains silence).

Silence in recording was fixed in 4.0.0


Fix broken module tests

Fix for the error causing the PHPUnit tests not to run, and for the failing module tests. Closes #862.

Note that at this stage, the errors have not been addressed - just the failures. These will be addressed shortly and an update pushed.

Looks like I got all the tests running and passing now, so marked ready for review. 😄
Let me know if any changes are required.


[Suggestion] Move all Prisma packages to the @prisma scope

Hi,
just thought I'd voice a suggestion to move all of Prisma's packages to the @prisma scope. Currently there is both nexus and @prisma/nexus with the docs for nexus-prisma referencing @prisma/nexus but depending on nexus itself.
When Babel made the change to scoped packages about a year or two ago, that made finding any and all official packages so much easier. I think the same could be said for Prisma. Having an umbrella to search under will make finding/discovering packages made by the organization so much easier. It will also allow the organization to release community "owned" (i.e. not a repo by the prisma user) under the umbrella if they deem it fit and then the package will have a 'Seal of Approval'.
Just a thought, but I think it would be a nice change.

That's a great point, I also like that. We'll discuss it internally!

Related: https://github.com/prisma/photonjs/issues/88

We agree, but not important enough to tackle right now. @jasonkuhrt will look into this soon.

Thanks for raising the issue. Yep we want to make sure we get this right. We'll have to think carefully about what a namespace means for us and where to draw lines. For example nexus is agnostic to prisma and vice-versa. Nexus has or will have its own plugin ecosystem. Prisma 2 has generators. When binds nexus to prisma is nexus-prisma. Should nexus become its own namespace? Should nexus-prisma live under it? Or under prisma? How about FLUID (current its own gh org)? A proper audit will take place later this year, taking stock of our/community situation/needs and looking at anything we can learn from amongst existing lay of the land.

@jasonkuhrt Can you please recreate this in a prisma-labs repo or make a note on your list? Thanks.

All Nexus-related packages will most likely be published under the @nexus NPM namespace in the future.
We're also planning to publish all JS-based Prisma tools under the @prisma NPM namespace.

@schickling I think that's a really good plan. Namespacing makes it easy to associate packages with a product as opposed to prefixing it with a package name + hyphen (looking at you eslint...).


Update plyr

Please create releases more often, to match the plyr releases

Package has been updated to the latest version of plyr. Thanks for reporting


Added identification details to community.json

Hackathon Git Labs Project PR 🎉🎉
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
PR contains:

The requested identification information associated with formally becoming a contributor to this repository to the community.json file. These are as follows;
"name": "beratzorlu",
"course_start": "2022",
"course_stage": "Student",
"favorite_language": "Python",
"currently_learning": "CSS"

This is my first collaborative software development experience ever. It was definitely daunting at first to consider taking part in such a process as I did not believe I had what it takes to make meaningful contributions. Hence, the reason why I am so late with my first PR. Nonetheless, I decided to go with it anyway for the sake of experiencing a Hackaton.
Hacktoberfest 2022:
-Yes
Breaking changes
None.
Screenshots
None.

Thank you very much for the feedback! Just fixed the indentation problem there. Cheers!


Switch back to official mina

Due to mina currently not enforcing host key checking (mina-deploy/mina#361)
we use our own hosted version at https://github.com/Samfundet/mina with the PR merged in.
Once mina gets their things together, we should switch back to the official one.

It looks like things have been fixed, so will try to use the official mina and deploy to www-beta to verify.

Closed by #482


Adding 6.0 ServiceFabric specification

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@samedder,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jianghaolu This will need to be merged for Ignite, is there any way we can get this checked in Monday?

@samedder and @vipulM-MSFT
We have another PR with the same  content, please close one of them.
@samedder, it seems that you've added a new version based on 5.6 if that's the case: to move this PR faster, split it into two commits one that contains the copy and paste of the 5.6 then another one with the changes on top of  it so that we can focus on reviewing those

@salameer I have closed 1738. This is a new version and 5.6 is not modified.

I'm working on this.

@jianghaolu Can you take a look at the SDK generation for Python? It keeps failing but it doesn't seem related to errors in the spec.

@lmazuel Can you help take a look at the python generation issue? I can't find the SwaggerToSdkNewCLI.py file.

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-node


Enable graft validation checks for debug

Closes https://github.com/graphprotocol/graph-node/issues/5197
Fix graft validation checks

Removed the conditional compilation for reorg threshold checks in debug builds

This will be good to go as we have reorg_threshold set to 0 on debug builds.
https://github.com/graphprotocol/graph-node/blob/b0c89526fd932393f3e43350ee664404eb858040/graph/src/env/mod.rs#L238-L241

@lutter @incrypto32 would appreciate a review of this PR.

Interesting. This used to fail CI; do you have any idea where the reorg threshold is set to 0 when we run tests?

Yep, this used to fail before. The reason for the change in behavior is that at the time the issue was opened, the cfg!(debug_assertions) macro wasn't being used to set the reorg threshold.
And now, while running tests (which are typically in debug mode), the cfg!(debug_assertions) macro is being applied, and the reorg threshold is set to 0 by default. unless explicitly set by "ETHEREUM_REORG_THRESHOLD" env var


[WFRP4e System] Found solution to #1648

As I described in #1648 there is issue with character sheet when using Windows Scale option for screen.
Found solution for you:
in .app.window-app.sheet.wfrp4e.actor .window-content selector you need to change border-image-width from 106 to 106px and in .app.window-app.sheet.wfrp4e.actor .window-content form selector you need to change the same parameter from 250 to 250px
Cheers!
From<EMAIL_ADDRESS>11.302wfrp4e: 6.5.9wfrp4e-archives1: 3.0.2wfrp4e-archives2: 3.0.6wfrp4e-core: 3.1.4wfrp4e-rnhd: 3.0.7wfrp4e-up-in-arms: 3.0.6wfrp4e-wom: 3.0.5wfrp4e-zoo: 3.0.2Active Modules: ATL, darkraven-games-soundscapes-free, dice-so-nice, forien-armoury, forien-quest-log, foundryvtt-simple-calendar, fxmaster, lib-wrapper, michaelghelfi, polyglot, popout, tabletop-rpg-music, token-action-hud, tomcartos-ostenwold, wfrp4e-actor-sheet-print, wfrp4e-gm-toolkit, wfrp4e-random-treasure

For general discussion and troubleshooting I recommend you email me or use the Discord


“三.使用自定义下载加密查看demo OfficeDetailedActivity实例“ 链接出错。

日志提供一下

链接出错，还有什么日志？
On Thu, 25 Apr 2019, 14:51 yangchaojiang<EMAIL_ADDRESS>wrote:

Closed #245 https://github.com/yangchaojiang/yjPlay/issues/245.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/yangchaojiang/yjPlay/issues/245#event-2299258455, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKO56EZ6NCEQCXCIUJ57GTDPSFIGZANCNFSM4G66SZPA
.


Logical Short-Circuiting supporting?

when I use scriban, without Logical Short-Circuiting  i always need to write:
{{ if x.array.size > 0
if x.array[0].value == 3 }}
{{# some thing goes here }}
{{ end
end }}
so with Logical Short-Circuiting, it could be simpler.

can i make a pr for this?

Not sure to follow, do you have an example of what you would like to write?

Not sure to follow, do you have an example of what you would like to write?

what I want to write is:
{{ if x.array.size > 0 && x.array[0].value == 3 }}
{{# without Short-Circuiting,   ^^^ will raise an exception because of array.size == 0 }}
{{# some thing goes here }}
{{ end }}

As part of 1.2.8 by PR #93 , you should be able to setup EnableRelaxedMemberAccess  = true on template context to achieve that.
https://github.com/lunet-io/scriban/blob/686a1ed1099aeb72b51d0bca5059bfd478236c8d/src/Scriban.Tests/TestRuntime.cs#L452-L468


Split maintainers into current-maintainers & previous-maintainers

Description
It's apparent that the "Thanks To" section doesn't accurately represent the "maintainer" status of the userstyle itself. We should update this to mention current and previous maintainers.
I also think it would be nice if you could look at the YAML and actually see if any ports are unmaintained. I think we should allow current-maintainers to be empty so that we're not shying away from the reality of open-source software going unmaintained. Interested to hear @isabelroses' (and anyone else!) thoughts on that.
Acceptance Criteria

[ ] userstyles.yml is updated to include previous/current maintainers

[ ] userstyles.schema.json is updated accordingly

[ ] README.md only includes previous/current maintainers and the thanks to section is removed.

E.g.
userstyles.yml
- maintainers: [ *isabelroses, *nekowinston ]
+ current-maintainers: [ *isabelroses ]
+ previous-maintainers: [ *nekowinston ]

README.md
- # Thanks To
- 	- Isabel
-   - Winston
+ # Current Maintainer(s)
+  - Isabel
+ # Previous Maintainer(s)
+  - Winston

I do think this is the best course of action.
However, this does mean that we would lose the "thanks to" section that we previously had, like in catppuccin/discord, which contains a large amount of names. My suggestion is a general thanks file. I'm unsure how this would be managed, but this could be a good addition, because of course each contribution means a lot.

I feel like "Previous Maintainers" has a negative outlook on what people have done. I would suggest something like "Other contributors". This means that we can group "people who have submitted small changes" and "people not currently maintaining the port" in the same way, which provides clarity on the purpose of the category.
As it stands, it would be possible to conflate the "small changes" group of people with "people who have maintained it in the past", which goes against the goal(s) laid out here.
In general though, I think this recategorization of maintenance status is a great idea! One thing I might add is people linking their discord (if applicable) in the maintainer area, so that it is easier to initiate off platform discussion. This does not need to exist in the YAML, only in the README.

I personally don't see a problem with "Previous Maintainers" but interesting perspective, thanks for that.
I suppose I wanted some separation between "general contributors" and people in the past that have actively maintained the port as it feels odd to group them under one category. I wonder if the following is nicer? @isabelroses @nullishamy
userstyles.yml
- maintainers: [ *isabelroses, *nekowinston ]
+ current-maintainers: [ *isabelroses ] (speaks for itself)
+ past-maintainers: [ *nekowinston ] (giving some special recognition to a maintainer in the past)
+ other-contributors: [ *nullishamy ] (the maintainer would decide who goes in here? meant to represent general contributions?)

The goal of the YAML is to standardise the information and fully auto-generate the READMEs, so if people wanted to add extra information (e.g. discord tags) - it would need to be included in the YAML. I'm unsure if that's beneficial because I'd rather the first port of call is an issue for maximum visibility here and if the maintainer wishes to do so, they could tell them a way to initiate off-platform discussion.

The new layout seems fine to me. I was mostly concerned about lumping a large group of people together. As for the Discord stuff, it's gonna be easier to just omit, as you described. I had forgotten about the generated README goals. As for the question in the codeblock, I think it would be fine to just have people self include themselves in the other-contributors section, as we did(?) with the "Thanks" section previously.

To surmise my opinion of this is that it is creating a certain amount of extra work, to an extent I understand the benefits of having the previous maintainers section as it allows anyone to keep track of who they should no longer contact weather they previously thought that way or not. But I see no point in over extending the General Thanks section this seems to add unnecessary complexity to something that doesn't need to be there or be auto generated. A better alternative to this would be a simple markdown or text file where people who have contributed generally to the project could mark down their name, but beyond this there is not much benefit to having a autogen script for this. However, I totally support the idea for the maintainers list since this would simplify the locations a single person would have to edit to correct, step down or take on a maintainership of a given userstyle.

After having implemented it, I'm inclined to agree with you that we don't really need a other-contributors section as the commit/PR history should speak for itself.
I'll remove the other-contributors field in #43 @isabelroses


COAR NotifyService IT failures: github pipeline failures

check issue https://github.com/DSpace/DSpace/issues/9457

the solution has been found on dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/patch/operation/ldn/NotifyServiceInboundPatternsRemoveOperation.java class.
Opened a new cleaned pr at https://github.com/4Science/DSpace/pull/451


add test in CICD for gem install

Observation
While performing validation of the ruby / rust gem I noticed a failure to install the gem in the test server.
🎫 https://linear.app/eppo/issue/FF-2758/ruby-gem-fails-to-install
Description
Augments CICD to attempt to install the gem locally so we have a repeatable process to validate its function.

We need to publish eppo_core to crates.io for gem install to work


#11 included query chargeback and visa checkout clients.

Please review.
Waiting for test data...

All good!


show_headnode test suite failure

___________________________________________________________________________ TestQuery.test_show_headnode ___________________________________________________________________________
self = <api.TestQuery instance at 0x7f727cf78560>, db = <sqlalchemy.orm.session.Session object at 0x7f727cf51c10>

    def test_show_headnode(self, db):
        api.project_create('anvil-nextgen')
        network_create_simple('spiderwebs', 'anvil-nextgen')
        api.headnode_create('BGH', 'anvil-nextgen', 'base-headnode')
        api.headnode_create_hnic('BGH', 'eth0')
        api.headnode_create_hnic('BGH', 'wlan0')
        api.headnode_connect_network('BGH', 'eth0', 'spiderwebs')

        result = json.loads(api.show_headnode('BGH'))
        # For the lists to be equal, the ordering must be the same:
        result['hnics'].sort()
>       assert result == {
            'name': 'BGH',
            'project': 'anvil-nextgen',
            'hnics': [
                'eth0',
                'wlan0',
            ],
            'vncport': None
        }
E       assert {'base_imgs':...nextgen', ...} == {'hnics': ['et...ncport': None}
E         Omitting 4 identical items, use -v to show
E         Left contains more items:
E         {u'base_imgs': u'base-headnode',
E          u'uuid': u'bce1ed76-b948-11e5-b2b0-001e65327848'}

tests/unit/api.py:1335: AssertionError

This looks like it was due to a recent change. About that CI...
Also, what was the reasoning behind putting the uuid in the output? It was originally just there as an implementation detail, to make sure that the libvirt names were unique; exposing it as part of the API doesn't make a lot of sense to me.

Thanks for your report! We are working on getting CI (#90).
RE: show the uuid, the idea was that folks were wanting to do operations on the VMs (snapshot, clone, etc), but had to go digging in the DB to find out which corresponded to their head node.

Fair enough. my take on that though would be to change things such that the names were more self-identifying -- you have no lookup step that way, and you keep the API simpler. Maybe just do some escaping of the label and use that (I think the reasoning for UUIDs was that it was simpler than properly escaping the names, but it's not that hard). Having something in there that only exists so you can do stuff behind the curtains seems a bit ugly to me. Just my $0.02.

Let's continue the unit test discussion in #517


Fix belgian vat validation regex pattern

1. Why is this change necessary?
VAT numbers for new companies in belgium can start with BE1, whereas current validation only passes for numbers that start with BE0.
2. What does this change do, exactly?
This change updates the Regex used for validating BE VAT numbers, so that BE1 VAT numbers can also pass the validation.
3. Describe each step to reproduce the issue or behaviour.

In Admin, create a customer group with a custom signup form and make sure Company signup form is enabled
Create a commercial customer with this customer group and log in as the customer in Storefront
Go to the user profile and edit the profile

Change the VAT number to a BE number starting with 1 instead of 0, example BE1123456789

Before the change this should not pass validation.

4. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

hey @yannick-meteor
I guess we already fixed that 🤔
https://github.com/shopware/shopware/commit/1e767f7bb735730860500f31676d69741dc5b1ab

@mitelg
You're right, seems that I overlooked it, thanks for checking!
I'll close the PR


Is it possible to do this without specifying the issuer in the validate-jwt policy?

Hi, I went through this document setting up OAuth 2.0, but I wasn't able to set it up without including the issuer in the validate-jwt policy, so I'm wondering if that was left out, or if I did something wrong.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 823eb96f-e5f1-0832-b175-0b31009be92f
Version Independent ID: 330085ae-dcf6-e930-86a8-0e4a60ab1314
Content: Protect API backend in API Management using OAuth 2.0 and Azure AD - Azure API Management
Content Source: articles/api-management/api-management-howto-protect-backend-with-aad.md
Service: api-management
GitHub Login: @miaojiang
Microsoft Alias: apimpm

Hello @ronarieke, Thank you for your feedback! We will review and update as appropriate.

@ronarieke the policy sample includes the openid-config which add in an issuer when parsed but if you don't include that or not user OpenID, then you will have to add the issuer.

@ronarieke Just following up here... Hope my previous comment clears things up.

Hi Pramod,
I think I may have updated the issuer ID and open ID config in the same
step... Thanks!
Regards,
Ron
On Mon, Dec 21, 2020, 3:06 AM Pramod Valavala<EMAIL_ADDRESS>wrote:

@ronarieke https://github.com/ronarieke Just following up here... Hope
my previous comment clears things up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/67734#issuecomment-748860304,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMJ7EEVSGPJAAGOZDQIXHDSV4FY5ANCNFSM4U5D3YUA
.

@ronarieke Glad I could help clear things up!
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


No libreadline7 on Ubuntu 20

Steps to reproduce the issue
I have upgraded a previous Ubuntu 18 machine where I had a working tool chain using yosys for ecp5 built locally
After the upgrade the tool chain ceased to work I have tried to rebuild yosys, prjtrellis and nextpnr.
But running yosys-abc fails with this error:
error while loading shared libraries: libreadline.so.7: cannot open shared object file: No such file or directory
And after some attempt to find out how this can be resolved it seems like there is not installation candidate for libreadline7 on
Ubuntu 20.
Nor can I find out why this shared library is used. The yosys-abs binary is rebuilt but somehow it depends on this non present library. It it possible to change to a version that is available like 6 or 8?

Have you tried a full clean rebuild?

I ran into the same issue on a system I upgraded from Ubuntu 18.04 to 20.04. I can confirm a full rebuild fixes this.

I did not if a clean build requires other methods than; make clean all;sudo make install. What is the correct method to make a clean build?
So my problem is that after my chosen method of a clean build the make processes still somehow uses libreadline7. I have not been able to reconfigure the build system to properly detect the installed version of libreadline. A 'configure'  is how I would have guessed it should work. Ok, to be fair I can see my self from the source code that GNU automake tools are not used so I hoped the version of readline could be manually defined.

@jakobwenzel Which version of readline does your build link in?

Thinking about it, I don't think that make clean cleans abc which is the problem (if that's what you mean by 'yosys-abs'). Try doing rm -rf abc and then make which will freshly clone and build abc.

@oloftangrot
$ ldd yosys
	linux-vdso.so.1 (0x00007ffd5fd5b000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fec5116d000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fec5101e000)
	libreadline.so.8 => /lib/x86_64-linux-gnu/libreadline.so.8 (0x00007fec50fce000)
	libffi.so.7 => /lib/x86_64-linux-gnu/libffi.so.7 (0x00007fec50fc2000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fec50fbc000)
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fec50fa0000)
	libtcl8.6.so => /lib/x86_64-linux-gnu/libtcl8.6.so (0x00007fec50de2000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fec50dc7000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fec50bd5000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fec51ad3000)
	libtinfo.so.6 => /lib/x86_64-linux-gnu/libtinfo.so.6 (0x00007fec50ba5000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fec50b82000)

@davesha1 IIRC make clean did not do it for me, so I used git clean -dfx.

gti clean -dfx did not work for me. The build still links to libreadline.so.7 which is not found.  I did a small test program that used and linked libreadline and the compiler, g++, apparently used libreadline.8.0. I don't claim that this provides evidence for the yosys build system to be faulty but at least my machine seems configured to provide a linkable readline library that the compiler is aware of.

rm -rf abc
resolved the issue.

Excuse me, I'm using yosys-abc inside OpenRoad-flow-script. I also meet such kind of problem:


Proposed chart works fine with helm2

I have tested proposed chart and it work  without problems with my helm2.

Awesome, thank you very much!


Fixed get_send_to error - TOOL-564

get_send_to does not return email addresses, as its documentation would suggest. Therefore, the original implementation of just changing which email addresses it returned, had to be changed.
Now, the custom mailer overrides the functions that dictate which email addresses receive notifications (notify_about_activity and _build_message), leaving get_send_to untouched.

@gregwjacobs


The formatting issue in http://www.windowsazure.com/en-us/manage/services/hdinsight/

The first letter in the titles needs to be capitalized:
Guidance: What version of Hadoop is in Windows Azure HDInsight?
Tutorial: Simple recommendation engine using Apache Mahout
Tutorial: Using HDInsight to process Blob Storage data and write the results to a SQL Database

@mumian Thank you for raising this issue.  We're closing old issues.  If you feel this issue should remain open, please comment to let us know that the issue should be reopened.


Segfault on close

This has been present in all versions I use. Upon closing, we see this in the console:

Also, the "Failed to connect to server" popup occurs.
However, functionality is not affected in any way.
This is on Ubuntu Budgie 18.10.
$ gcc --version
gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0
$ qmake --version
QMake version 3.1
Using Qt version 5.11.1 in /usr/lib/x86_64-linux-gnu

Yes, the current shutdown and clean-up of the MQTT library is still rather messy. The code will be refactored to prevent this issue from occurring. Please standby :)

A new release (v0.3-alpha) has been made available. As the crashes and stability issues originated in the libmosquitto library, it's expected that by swapping it with NymphMQTT such crashes and stability issues should be much reduced.
Feel free to try the new code and let me know if you need any assistance with the new dependencies (NymphMQTT and its dependencies).


Add ELLIO: IP Feed (Community version) and correct path in GenerateTa…

…bleStatistics(\ -> /)

Thanks, great addition! Merged.


Add BUILD_TYPE=no_tf_lite_static_memory and -Wswitch.

This fixes #43076.
Manually tested this change on PR #42452 and confirmed that the following command results in an error:
make -f tensorflow/lite/micro/tools/make/Makefile -j8 BUILD_TYPE=no_tf_lite_static_memory

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.


[base-ui][Button] Maintain the disabled prop in SSR

Description
Update button component to maintain button disabled prop across Next.js SSR
closes https://github.com/mui/material-ui/issues/38943

[x] I have followed (at least) the PR section of the contributing guide.

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

I have not tested this, but one problem I ran into when making my local patch fix is hydration mismatching (i.e. the server adding the disabled prop, but the client-side code omitting during hydration). I strongly suggest that these changes be tested thoroughly against the full matrix of options (button tag, a tag, and custom component, each with focusableWhenDisabled true and false) to make sure no such issues are being introduced.

nit on the title: I think the issue applies to all SSR, not just Next.js 😬

Thanks for the feedback @simon-abbott, the implementation has been updated

I thought this would still cause some hydration mismatch errors (Next.js 😪 ) but I tested it a bunch and it seems to work ok!
CC @DiegoAndai for a quick review as well 🙏

thought this would still cause some hydration mismatch errors

I have the same thought: how is it not causing errors? 😅 For example, shouldn't this be an immediate hydration mismatch if passing a href prop so the tag would become 'A' client-side? Maybe I'm missing something.


mirth_messages_queued - metric not functional

I tried to setup Mirth Channel 4.2 with mirth channel exporter 1.3.0 Version. Everything is working except "mirth_messages_queued" metric.

This is now fixed in version 1.4.1. Pull the latest code/docker image and you should be good!


Revert "STOR-1065: Rework sidecar bindings to bind common ClusterRoles"

This reverts commit cb05b3b6883fd966a3aaf8bf250309f163ca2374.
Testing revert based on failures in https://amd64.ocp.releases.ci.openshift.org/releasestream/4.14.0-0.ci/release/4.14.0-0.ci-2023-07-20-162349. If validated will update further.

/payload-job periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade

/payload-job periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade

Rerunning the /payload-job above as it didn't pass the first time.

definitely strange since the PR this is reverting introduced names like openshift-csi-main-attacher-role, openshift-csi-main-provisioner-role, and openshift-csi-main-resizer-role and they show up in the pathological test failure of the job run in /payload-job.

Looks like https://github.com/openshift/azure-disk-csi-driver-operator/pull/84/files is paired up with the changes we are trying to revert here and both will need to be reverted in tandem.

/lgtm

Based on feedback from @jsafrane we believe it's best to revert all changes related to this jira that went into the affected payloads.
/label approved

/label jira/valid-bug

Note the test failures for https://prow.ci.openshift.org/job-history/gs/origin-ci-test/logs/openshift-azure-file-csi-driver-operator-63-ci-4.14-upgrade-from-stable-4.13-e2e-azure-sdn-upgrade are related to the other revert for azure-disk-csi-driver-operator.  We likely need to override ci/prow/e2e-azure-file-csi
event happened 246 times, something is wrong: ns/openshift-cluster-csi-drivers deployment/azure-disk-csi-driver-operator hmsg/e18fd3d884 - pathological/true reason/ClusterRoleBindingUpdateFailed Failed to update ClusterRoleBinding.rbac.authorization.k8s.io/azure-disk-csi-attacher-binding: ClusterRoleBinding.rbac.authorization.k8s.io "azure-disk-csi-attacher-binding" is invalid: roleRef: Invalid value: rbac.RoleRef{APIGroup:"rbac.authorization.k8s.io", Kind:"ClusterRole", Name:"openshift-csi-main-attacher-role"}: cannot change roleRef From: 02:06:41Z To: 02:06:42Z result=reject


Provide latest build number for CLI "fastlane pilot distribute"

Question Subject
fastlane pilot distribute -q <itc_team_id> --distribute_external "true" --notify_external_testers "true" --demo_account_required "true" -a <bundle_id> -g <tester_groups> -w <changelog>

Question Description
I use the command above to notify testers about already uploaded builds.
The command figures out the latest version - build number - combination and adds the specified tester groups to this build.
BUT figuring out the build number takes very long and I already have it locally. Can I provide it myself to the command? This would bring us a massive speed boost. I sadly didn't find any documentation related to this... :(

Is there anybody who can help me on this topic?

This is still an issue and it would be nice I could get an answer. I could tray to implement it myself and file a PR... Would that be an option?

You can add --build_number
https://github.com/fastlane/fastlane/pull/16221

This is amazing! Thanks man. This saves sooo much time for us, since we batch-distribute 15 apps and counting 👍


[ALLUXIO-2813] Move session logic to netty

https://alluxio.atlassian.net/browse/ALLUXIO-2813
Changes the session heartbeat logic to use netty instead of thrift. Now we assume the entirety of read or write operations (including any metadata operations) are concluded before InternalRequest#close is called. InternalRequest#close will clean up any lingering temporary state.
This currently won't work for reads w/ caching since the cache logic is outside of the netty data path.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15150/
Test PASSed.


add postgres support

Enables postgresql connection.

@DGKSK8LIFE please check out this pull request and leave feedback

I'm in the process of doing so @hyperxpizza. Also working on a proper contributor's guide. If you don't mind, please change the PR to merge into DGKSK8LIFE:unstable instead of master. Trying to maintain a steady release schedule.

If you use discord, join the redisql server. Ty


manual "Archive this Resource" -> "Internet Archive" overwrites existing content in "extra" field

Environment:

Zotero standalone 5.0.84
macOS Mojave 10.14.6 (18G3020)
Zotero addons installed:

Zotero Libreoffice Integration
Zotero Memento
Zotero Word for Mac Integration
Zutilo Utility for Zotero

Steps to reproduce:

Install Zotero Memento using downloaded xpi from GitHub Release and restart Zotero standalone.
In Zotero standalone interface:
a.  Navigate to a group library in which you have full permissions.
b. Select an item that has valid content in the URL field, an "extra" field that contains text.
c. Using the context menu on that item, select "Archive this Resource" -> "Internet Archive".
__d. Observe that the "extra" field gets overwritten with an Internet Archive link, destroying the pre-existing content.

Suggested alternative behavior:
If the "extra" field has non-whitespace content, append the Internet Archive link to the existing content after inserting a delimiter like ";". Alternatively,  omit writing the Internet Archive link to a non-empty extra field and just rely on the "note" attachment mechanism, but see issue #3.

NB: overwrite of non-empty "extra" field occurs in both personal and group libraries.

now retains the extra field; working on the group library issue.


Adding an option --serve tcp:localhost:port

Hi everyone,
Following this posts: #1073 and #1159  and suggested by  @rom1v , I worked on an option --serve. This option would allow forwarding the video stream to any client connected. It could be a C# Unity App, Java App or C# UWP App or whatever.
The command is like below :
--serve tcp:[localhost|IP]:[port]
# For example
--serve tcp:localhost:27115

It could be a great solution for people like me, who wants to display the video stream inside a desktop application without redeveloping and rebuilding the scrcpy client in the desired language.

Thank you for the PR.
However, it seems there's a rebase issue, your commit https://github.com/Genymobile/scrcpy/pull/1419/commits/17947e175c2fc79c8a6e1746d9e684af852f4155 contains a lot of code which already exists on master (and which is not related to the feature you implement).

Hey @Darkroll76,
first of all big thanks for your pull request and added features. (My usecase is similar to yours, as I want to feed the stream in realtime to Unity) I checked out your latest commit and managed to build it for windows. In general the serving feature works, however I noticed a very noticable lag as well as a lot of artifacts when testing the tcp stream in the vlc player (all on the same host machine).
I tested multiple downgrades in terms of bitrate and resolution without any improvements.
Is this an issue with vlc or just the nature of the tcp stream?

Hi @overvox ,
Thanks! Apparently it's due to VLC buffering. See this post
Since I'm working on a big project, I didn't find the time to remove all the code which already exists to have a clean commit.

@overvox I understood that I was doing the wrong thing. When you use the --serve command, it waits for the client to connect to start the stream. But during this time, scrcpy is already receiving packets from the scrcpy server and apparently, it keeps the frames until it can send them. I used the same behaviour as the decoder and the recorder, but I should rather look for the same thing as the display window.
This is why there is a time lag between the action we perform on our device and the frame received and displayed. Because it sends the frames it kept since the start of scrcpy.

hi @Darkroll76 I have a question. Will be able to use it in webrtc after --serve update?
thanks

I'm trying to remove the time lag between the action we perform on our device and the frame displayed. Is ScrCpy keep each frame since the server is started? How could I clean the pending frames?

IMO, the server should not be started until a client connects to the socket.

Any updates on this feature. Rly looking forward to it.

Hi @Maciejszuchta, I'm trying to fix the rebase issue on commit 17947e1 like @rom1v said :

it contains a lot of code which already exists on master (and which is not related to the feature you implement).

But I'm a bit lost in how to do it properly without breaking anything

This feature would be great.

where is this serve repo?
i wanna use it

Hi, Any update on this serve repo? I also would like to use the --serve command but I somehow can't even find the branch on SourceTree. Am I just noob?

Hi,
A quick follow up.
Despite I initially suggested this feature, I'm finally not convinced a --serve argument is a good idea now.
Firstly, it adds complexity:

it impacts scrcpy starting
it is limited to video, and could possibly constrain what can be done about audio in the future (if there is a real solution, which is not the case for now)

But above all, the same feature (receive the video stream for another app) can now be achieved differently (it was not the case when this PR was created):

on Linux, via V4L2
using scrcpy-server directly

For using scrcpy-server, recent changes (in particular 04e5537f8ce21dbae365dcd980efda911188c945 and cabcbc2b151255b49a442a1c43e7db44432eb58e) facilitates reusing the server for receiving the raw video.
Here is a sample script which starts the server:
adb forward tcp:1234 localabstract:scrcpy
adb push scrcpy-server /data/local/tmp/scrcpy-server.jar
adb shell CLASSPATH=/data/local/tmp/scrcpy-server.jar \
    app_process / com.genymobile.scrcpy.Server 1.21 \
    send_frame_meta=false tunnel_forward=true control=false max_size=1920

From another terminal:
# skip the 69 first bytes (1 zero-byte, 64-bytes device name string, and 4 bytes for the device size)
nc localhost 1234 | tail -c+70 | vlc --demux h264 -

This will not be real time at all because VLC will add buffering, but this is to illustrate that it is possible to get the raw H.264 stream.
Instead of running nc and vlc, you probably use your own client.
Moreover, that way, the client can decide if it wants to receive the "frame meta" in front of each Annex B H.264 packet or not, to avoid an additional 1-frame latency (see #646).

See #2971.

Hello, is there a possibility to dynamically take a screenshot (encode it to png or jpg) of a live stream from the device? What I need is to take a screenshot of a device screen as fast as it is possible.

Hello, is there a possibility to dynamically take a screenshot (encode it to png or jpg)

Currently, no: #684 #2040.
But you could record the video stream and extract frames later:
scrcpy --record file.mp4

For using scrcpy-server, recent changes (in particular 04e5537 and cabcbc2) facilitate reusing the server for receiving the raw video.
Here is a sample script which starts the server:
adb forward tcp:1234 localabstract:scrcpy
adb push scrcpy-server /data/local/tmp/scrcpy-server.jar
adb shell CLASSPATH=/data/local/tmp/scrcpy-server.jar \
    app_process / com.genymobile.scrcpy.Server 1.21 \
    send_frame_meta=false tunnel_forward=true control=false max_size=1920

I am unable to run these commands. It seems that my phone needs to be rooted in order for me to be able to push the scrcpy server to the data folder. I found a workaround by drag-and-dropping my file to a folder I had access to and changing the path in the third command. However, that command fails as well, saying that app_process cannot be found, even though it is in the folder it should be in, and included in the PATH as well. I'm wondering if it has to do with the phone not being rooted again? Or does the scrcpy-server absolutely have to be in the data/local/temp folder?

I am unable to run these commands.

What is the exact output for each one?

For the adb push command, I was getting something like push: permission denied. I tried again just now and can't reproduce the error, the push command now somehow works even though I still don't have root access. For the adb shell command, I realized I hadn't deleted the \ from the command, which gave me /system/bin/sh: app_process: inaccessible or not found. But now that this 3rd command runs, it simply outputs "Aborted".
I'm sorry for bothering you with this, this is something I'm fairly new at and I don't quite understand everything.

For the adb push command, I was getting something like push: permission denied. I tried again just now and can't reproduce the error, the push command now somehow works even though I still don't have root access. For the adb shell command, I realized I hadn't deleted the \ from the command, which gave me /system/bin/sh: app_process: inaccessible or not found. But now that this 3rd command runs, it simply outputs "Aborted".
I'm sorry for bothering you with this, this is something I'm fairly new at and I don't quite understand everything.

Hi @Darkroll76
I guess you are using Xiaomi or Realme device please cofirm.


Startup time (creating an IExtendedXmlSerializer) is incredibly slow

I've noticed that serializing doesn't take too long, but the configuration, even just for trivial cases takes waaaay too long. Running this:
var sw = Stopwatch.StartNew();
IExtendedXmlSerializer serializer = new ConfigurationContainer().Create();
var elapsed = sw.ElapsedMilliseconds;
Console.WriteLine($"{elapsed} ms");

Yields around 1.5 seconds, which is very annoying, when my app used to start up in less than a hundredth of this. Why does this take so long?
Does this mean I have to cache my serializer and not even attempt to construct one as I need?

Yikes!  That does sound bad, @LPeter1997.  Thank you for reporting it.  When we first created v2 performance was a focus but it has not been one for some time now.  We have indeed focused on runtime but not configuration/startup time.
I will poke around and see if there is anything obvious that we can tackle and update here. 👍

OK I have created a simple test that emits startup times.  Locally I get:
net452: 340 ms
net471: 313 ms
netcoreapp2.1: 260 ms

This is not outstanding but not a concern either and seems within expected range.
In our build (search for ExtendedXmlSerializer.Tests.ReportedIssues.Issue392Tests.Verify) these also appear to be nominal however I think that at this point the domain has already initialized and any assembly/domain-based initialization issues have already been attended.
Have you attempted to try this in a new console project altogether to see if you get the same results?  It may be due to your referenced assemblies and/or projects, I am thinking.  Please let me know of your findings and I will see if I can help you towards resolving this. 👍

I've tried to add the library with NuGet in a new console app, even tried to clone the source and reference directly that. No difference here, still around one and a half seconds just to create a serializer in a .NET Core project.

Boo.  I am stumped for ideas, then.  Do you have an older computer?  Maybe another computer to try things out on to see how it fares?  I myself am on a Ryzen 2700x system, so not exactly new but not old either, around 4Ghz.  We are basically seeing a 6x difference between environments so this would imply that you have a processor that is 6x slower, so want to verify if possible as a basic sanity check.
The other consideration that comes to mind is the .NET Core runtime installed in your environment.  I am running 3.1 here,  That shouldn't make any difference, but again exploring considerations.
I would also be interested in seeing what your results are in .NET Framework if you have any installed.  It should be slower, but again, offering considerations to further diagnose this.

There hasn't been any activity on this issue for nearly a month now.  Please feel free to comment/reply and we can take it from there.  Closing for now.