ValidationError thrown with Nested Optional BaseModel if key and class name are the same

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Validation error when:

Nesting BaseModel classes in combination with not required Optional[] = None fields
Using a BaseModel class name as the type for the Optional field identical to the key of field itself
Providing a Record with the field inside

Expected result:

No validation error since a "Not required, can be None, is None by default" field can be provided with the format specified by the BaseModel subclass used as type in the Optional field.

It's way easier to show an example rather than to describe this, but in short:
class Fails(BaseModel):
    not_important: int

class Element(BaseModel):
    Fails: Optional[Fails] = None  # doesn't fail if we rename the field key

This will fail as long as the field key "Fails" equals the class name "Fails" and is used in the Optional[Fails] = None notation for not required fields.
Example Code
from pydantic import BaseModel
from typing import Optional

class TEST1(BaseModel):
    a: int

class TEST2(BaseModel):
    b: int

class OVER(BaseModel):
    c: Optional[TEST1] = None
    d: Optional[TEST2] = None

ok = b'{"c":{"a":0},"d":{"b":0}}'
OVER.model_validate_json(ok)
# OK -> Out[19]: OVER(c=TEST1(a=0), d=TEST2(b=0))

class OVER2(BaseModel):
    TEST1: Optional[TEST1] = None
    d: Optional[TEST2] = None

not_ok = b'{"TEST1":{"a":0},"d":{"b":0}}'
OVER2.model_validate_json(not_ok)
# VALIDATION ERROR

Python, Pydantic & OS Version
pydantic version: 2.10.2
        pydantic-core version: 2.27.1
          pydantic-core build: profile=release pgo=false
                 install path: /home/kb/.pyenv/versions/3.11.0/lib/python3.11/site-packages/pydantic
               python version: 3.11.0 (main, Oct 27 2023, 12:18:15) [GCC 12.2.0]
                     platform: Linux-6.1.0-26-amd64-x86_64-with-glibc2.36
             related packages: typing_extensions-4.12.2
                       commit: unknown

See the warning in https://docs.pydantic.dev/latest/concepts/models/#basic-model-usage.


Move env variables to internal config

Why
@pellared, you may find the solution from https://github.com/signalfx/signalfx-dotnet-tracing/pull/668 more acceptable when the new variable description is moved to the internal config.
What
Move new variable from https://github.com/signalfx/signalfx-dotnet-tracing/pull/668 to internal config. Document undocumented variable.

@pellared please review and close or merge.

@theletterf if this is merged we shall not document the new variable in official docs.


Issue-1: Linux support

[WIP] TAP LinuxSDK
The first pass at making linux bluetooth system connect and talk to TAP.
This Linux SDK, like the macOS SDK, uses bleak under the hood. Most of the Linux SDK is copy/paste from the macOS SDK.
The version of the bleak framework in the Linux SDK (v0.6.4) is slightly newer than the macOS SDK (v0.5.1), but I don't see any reason why they cannot be brought in sync.
TODO Items

The Linux SDK needs the mac address of the TAP device to connect to it. It should discover the device by its service UUID.
The Linux SDK assumes there is only one TAP device.
Rebase this PR on top of #2

Thanks for your effort.
Please describe what are the differences of this from #2?

@ilouzl
I have to take a through look at #2 to list all the differences, but I think one the main differences is that this PR (#3) usese bt-device from the bluez package to discover the available TAP device.

@matanster It is not merged to the upstream repo, but if you check out my fork, yes.
Linux support on my fork is now at par with Windows and Mac.

Thanks @meisam!


Switch to SVG for coverage badge.

(It felt left out, since all its friends were clearly upgraded.)

Thanks Craig! Long time no see!


Avoid deadlock in hackney - always use hackney's with_body option OR release the connection reference

https://github.com/benoitc/hackney/issues/420#issuecomment-351108735
Are we sure that we are always reading the hackney's body in https://github.com/teamon/tesla/blob/master/lib/tesla/adapter/hackney.ex , thus clearing the request's connection from hackney's pool ? We managed to get some deadlocks in our hackney.
Way to repeat it:

do a lot of requests
get a lot of timeout errors
do more requests - they instantly get timeout errors, and even using hackney directly by :hackney.get "http://google.com" stops working

Nevermind. That's definitely a hackney's issue.


Console error when initializing Skype object: 'No package definition found for this config'

Hi,
When using the Skype for business Online Web SDK I'm unable to initialize the Skype object.
The following code gives me a console error "{"message":"No package definition found for this config","code":0}".
Can anyone point me in the right direction?
<html>
<head>
    <script src="//swx.cdn.skype.com/shared/v/1.2.36/SkypeBootstrap.min.js"></script>
    <title>Skype For Business Test Website</title>
</head>
<body>
    <script>
        if (!location.hash) {
            location.assign('https://login.microsoftonline.com/common/oauth2/authorize?response_type=token' +
                '&client_id=xxxxxx-xxxxxx-xxxxxx-xxxxxx-xxxxxx' +
                '&redirect_uri=' + location.href +
                '&resource=https://webdir.online.lync.com');
        }

        if (/^#access_token=/.test(location.hash)) {
             Skype.initialize({
                    apiKey: "xxxxxxxxxxxxxxxxxxxxxxxxxx",
                    correlationIds: {
                        sessionId: 'session12345',
                    }
                }, function (api) {
                    console.log('success!');
                }, function (err) {
                    console.log(err);
                });
        }
    </script>
</body>
</html>

@JonasVDB-awingu Did you find any solution for this ... i am also facing the same issue

No, we switched to using the main UCWA (Unified Communications Web API) instead of using the Web SDK.


"Always run as administrator" option resets on reboot

Microsoft PowerToys version
0.65.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
General
Steps to reproduce
I had been using the "Always run as administrator" option on. If I try to turn it off, on restart it keeps on asking me for admin authentication. I tried uninstalling it, rebooting, installing it from GitHub and from MS Store, but the "off" option doesn't seem to stick.
✔ Expected Behavior
Turning off should not prompt for admin authentication on restart.
❌ Actual Behavior
It asks for admin authentication.
Other Software
No response

To add to this: I have two accounts, an admin and a personal account. I went into the admin account and turned the option off, made sure it was off in my personal account, but it still prompts for admin authentication on restart.

@stefansjfw / @jaimecbernardo multi-user settings issue?

/reportbug as maybe the logs could be helpful

@stefansjfw / @jaimecbernardo multi-user settings issue?

sounds like that, yes. This should be fixed in the next PowerToys release

Can we link to that tracked issue?

Hi! I'm afraid this bug is still present, at least for me!
Like I say, I'm still having this issue. I thought maybe it was some residual from a previous install, so I uninstalled using Revo uninstall, manually removing registry and files, and reinstalled using Microsoft Store (0.68). Right away it asked for admin credentials.
Despite having "Always run as administrator" off, it still asks for it.

When you run or when you install?  Was the app installed under a different user?

/reportbug

PowerToysReport_2023-03-04-19-46-31.zip
So to give you more context: I have an admin and a personal profile on Windows. When I installed PowerToys from MS Store, it already prompted admin credentials. As a matter of fact, even though I'm in my personal profile, when I created the bug report, it saved it on the admin desktop and not the pers profile desktop where I would've expected it.

Is this issue still relevant in v0.73? /needinfo

Is this issue still relevant in v0.73? /needinfo

This thread was mentioned here and was resolved: https://github.com/microsoft/PowerToys/issues/25452


Unknown DisconnectReason: 405|close using WA v2.2326.10, isLatest: true

İts give this error

#78


New version: BrettMayson.HEMTT version 1.10.1

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Executable-Error


FSDP+QLoRA get ValueError: Must flatten tensors with uniform dtype but got torch.float32 and torch.bfloat16

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
work out
Current behaviour
Traceback (most recent call last):
File "/root/miniconda3/envs/python-app/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/root/miniconda3/envs/python-app/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/src/axolotl/cli/train.py", line 59, in
fire.Fire(do_cli)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/fire/core.py", line 143, in Fire
component_trace = _Fire(component, args, parsed_flag_args, context, name)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/fire/core.py", line 477, in _Fire
component, remaining_args = _CallAndUpdateTrace(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
component = fn(*varargs, **kwargs)
File "/src/axolotl/cli/train.py", line 35, in do_cli
return do_train(parsed_cfg, parsed_cli_args)
File "/src/axolotl/cli/train.py", line 55, in do_train
return train(cfg=cfg, cli_args=cli_args, dataset_meta=dataset_meta)
File "/src/axolotl/train.py", line 160, in train
trainer.train(resume_from_checkpoint=resume_from_checkpoint)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/transformers/trainer.py", line 1848, in train
return inner_training_loop(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/transformers/trainer.py", line 1991, in _inner_training_loop
self.model = self.accelerator.prepare(self.model)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/accelerate/accelerator.py", line 1263, in prepare
result = tuple(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/accelerate/accelerator.py", line 1264, in
self._prepare_one(obj, first_pass=True, device_placement=d) for obj, d in zip(args, device_placement)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/accelerate/accelerator.py", line 1140, in _prepare_one
return self.prepare_model(obj, device_placement=device_placement)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/accelerate/accelerator.py", line 1422, in prepare_model
model = FSDP(model, **kwargs)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 477, in init
_auto_wrap(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_wrap_utils.py", line 101, in _auto_wrap
_recursive_wrap(**recursive_wrap_kwargs, **root_kwargs)  # type: ignore[arg-type]
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
wrapped_child, num_wrapped_params = _recursive_wrap(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
wrapped_child, num_wrapped_params = _recursive_wrap(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/wrap.py", line 543, in _recursive_wrap
wrapped_child, num_wrapped_params = _recursive_wrap(
[Previous line repeated 2 more times]
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/wrap.py", line 561, in _recursive_wrap
return _wrap(module, wrapper_cls, **kwargs), nonwrapped_numel
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/wrap.py", line 490, in _wrap
return wrapper_cls(module, **kwargs)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 503, in init
_init_param_handle_from_module(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_init_utils.py", line 590, in _init_param_handle_from_module
_init_param_handle_from_params(state, managed_params, fully_sharded_module)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_init_utils.py", line 602, in _init_param_handle_from_params
handle = FlatParamHandle(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_flat_param.py", line 573, in init
self._init_flat_param_and_metadata(
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_flat_param.py", line 623, in _init_flat_param_and_metadata
) = self._validate_tensors_to_flatten(params)
File "/root/miniconda3/envs/python-app/lib/python3.10/site-packages/torch/distributed/fsdp/_flat_param.py", line 761, in _validate_tensors_to_flatten
raise ValueError(
ValueError: Must flatten tensors with uniform dtype but got torch.float32 and torch.bfloat16
Steps to reproduce
just run accelerate launch -m axolotl.cli.train examples/llama-2/qlora-fsdp.yml
Config yaml
examples/llama-2/qlora-fsdp.yml

Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main/4d6490b
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Seems like same issue this unresolved bug report too. https://github.com/OpenAccess-AI-Collective/axolotl/issues/1426

I'm looking into this today.

same issue:
ValueError: Must flatten tensors with uniform dtype but got torch.float32 and torch.uint8
[2024-04-10 01:54:11,740] torch.distributed.elastic.multiprocessing.api: [ERROR] failed (exitcode: 1) local_rank: 0

There were some fixes for FSDP in #1462 , so check out the FSDP + QLORA examples provided in that PR. We probably need to update the appropriate YAML files for other model architectures.

There were some fixes for FSDP in #1462 , so check out the FSDP + QLORA examples provided in that PR. We probably need to update the appropriate YAML files for other model architectures.

it worked, many thanks!!!

Hey this is still happening for Mixtral-8x22B for DPO

Hey this is still happening for Mixtral-8x22B for DPO

@0-hero Would you mind opening a separate issue please to track for DPO and a reference YAML pls?


Expose new API EventLoop#supportsIoHandler

Motivation:
The EventLoopGroup can be

new MultithreadEventLoopGroup(NioHandler.newFactory())
new MultithreadEventLoopGroup(EpollHandler.newFactory())
...

A Bootstrap can be created like this
new Bootstrap().group(group)
               .channelFactory(eventLoop -> <new channel>)

The channel that will be returned by the channel factory may need to satisfy

NioHandler#cast
EpollHandler#cast
...

It will be helpful if one can check what IoHandler is supported by the event loop (if any is supported at all).
Modifications:

Expose new API EventLoop#supportsIoHandler
Add junit tests

Result:
It is possible to provide a channel based on the IoHandler supported by the event loop.

We may not want this on EventLoop level but on SingleThreadEventLoop.

I like the idea but I think there is a better way to archive something like that ... gimme a few minutes and I will show you what I have in mind

@violetagg https://github.com/netty/netty/pull/12572 PTAL

Close this in favour of #12572


Edit link on new site broken

Example:
https://docs.abapgit.org/user-guide/

Points to https://github.com/abapGit/docs.abapgit.org/edit/main/user-guide/README.md
But page is at https://github.com/abapGit/docs.abapgit.org/edit/main/src/user-guide/README.md
Missing /src in the path.
@stockbal, can you please have a look?

worked. Thank you!


Adding Bootstrap and jQuery JS files in Zend\View layout

I wonder if it is a bug or done by intention. When the Bootstrap and jQuery JS files are added to the Zend\View layout the headScript() view helper is used.
https://github.com/zendframework/zend-expressive-skeleton/blob/master/src/ExpressiveInstaller/Resources/templates/zend-view-layout.phtml#L73
I think the inlineScript() view helper might be a better choice.

@RalfEggert Sounds good; feel free to submit a pull request!

I'm not sure why I used headScript(). I think I copied it from somewhere. The reason it's at the bottom is to speed up page loading.

@weierophinney PR is there

Close with #45.


ENH update tag line

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-admin rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Note that merging this PR will remove python 2.7 from the build matrix and result in no python 2.7 versions going forward. cc @esheldon
Old versions already shipped will remain.

python 2.7 is still supported, and is run in travis on  the main repo. I did remove it temporarily while testing but it is back in there.

I won't remove 2.7 until version 2.0 of ngmix is released

Conda forge deprecated aupport. If you want 1.3.8 on py27, we’ll have to push a special build

OK, its fine to drop 2.7.  Thanks.


Thread named HTreeMap expirator Use a lot of CPU

When I use this code to create a HTreeMap instance.
HTreeMap<Object, Object> cache=DBMaker.newMemoryDirectDB().transactionDisable().cacheLRUEnable().make().createHashMap("testCache").expireMaxSize(10000).makeOrGet();
It creates a thread named HTreeMap expirator, But When the map size is 10015,the thread has been running use a lot of CPU and not sleep.
The following code if there is a problem ?
In ExpireRunnable Class
Method:expirePurge
code:removePerSegment=1+(size-expireMaxSize)/16;
Method:expirePurgeSegment
code:final boolean remove = ++counter < removePerSegment || ((expire!=0 || expireAccess!=0) &&  n.time+expireTimeStart<System.currentTimeMillis());
When map size is 10015 ,the removePerSegment greater than 0 and the remove are all false.

I will have a look at that.
But all expiration sizes and times are approximate.
10015 entries does not necessary mean the
expiration will kick in. Map size 11000 would
definitely mean bug.

I will have a look at that.
But all expiration sizes and times are approximate.
10015 entries does not necessary mean the
expiration will kick in. Map size 11000 would
definitely mean bug.

Thank you very much for your reply.
The main problem is not the map's size larger than my set, but when the map's size is greater than the set value and determine whether to remove non-stop without the problem of high cpu usage due to really delete. Note that the main problem is that the thread will occupy 100% of the cpu, when I have multiple instances of the map, the entire machine cpu are full.

When running the test code posted along with Issue 425 https://github.com/jankotek/MapDB/issues/425 I see that cache size routinely growing over configured 10,000, up to 15,000/20,000 (then drops and goes up) before it crashes with OOM.

@jankotek, any update with such issue ? we have some similar use cases.

No update

Should be solved in 2.0 branch


feat: always use package imports instead of relative imports

Description
As a developer I want my imports to use package imports instead of relative imports.
Desired Solution
Get the working directory and save that into a variable for the template to use.
Requirements

[x] Update this for model brick
[x] Update this for service brick
[x] Update this for service_package brick
[x] Update this for feature_brick

Additional Context
N/A

Done in feature_brick 0.4.0 🎉
https://brickhub.dev/bricks/feature_brick/0.4.0


Added AutoMapper and AutoMapperProfile

Included Automapper in depencies list.
Added Automapper in depency injection container.
Created test dto and automapper profile

Once again good job)


config.eager_load is set to nil

I'm attempting to run bundle exec unicorn -c /var/www/skateboxes/current/config/unicorn/production.rb -E deployment which is what  cap production unicorn:start runs. I get the following output:
INFO -- : Refreshing Gem list
config.eager_load is set to nil. Please update your config/environments/*.rb files accordingly:

  * development - set it to false
  * test - set it to false (unless you use a tool that preloads your test environment)
  * production - set it to true

I, [2013-10-25T00:57:12.607520 #7233]  INFO -- : unlinking existing socket=/tmp/unicorn.skateboxes.sock
I, [2013-10-25T00:57:12.607950 #7233]  INFO -- : listening on addr=/tmp/unicorn.skateboxes.sock fd=10
E, [2013-10-25T00:57:12.851888 #7233] ERROR -- : database configuration does not specify adapter (ActiveRecord::AdapterNotSpecified)
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/connection_adapters/connection_specification.rb:52:in `resolve_hash_connection'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/connection_adapters/connection_specification.rb:46:in `resolve_string_connection'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/connection_adapters/connection_specification.rb:30:in `spec'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/connection_handling.rb:39:in `establish_connection'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/railtie.rb:175:in `block (2 levels) in <class:Railtie>'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activesupport-4.0.0/lib/active_support/lazy_load_hooks.rb:38:in `instance_eval'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activesupport-4.0.0/lib/active_support/lazy_load_hooks.rb:38:in `execute_hook'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activesupport-4.0.0/lib/active_support/lazy_load_hooks.rb:45:in `block in run_load_hooks'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activesupport-4.0.0/lib/active_support/lazy_load_hooks.rb:44:in `each'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activesupport-4.0.0/lib/active_support/lazy_load_hooks.rb:44:in `run_load_hooks'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/base.rb:322:in `<module:ActiveRecord>'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/activerecord-4.0.0/lib/active_record/base.rb:22:in `<top (required)>'
/var/www/skateboxes/current/config/unicorn/production.rb:28:in `block in reload'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:495:in `call'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:495:in `spawn_missing_workers'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/unicorn-4.6.3/lib/unicorn/http_server.rb:142:in `start'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/gems/unicorn-4.6.3/bin/unicorn:126:in `<top (required)>'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/bin/unicorn:23:in `load'
/var/www/skateboxes/shared/bundle/ruby/2.0.0/bin/unicorn:23:in `<main>'

My production config definitely has this set to true. I fee like this has something to do w/ the -E flag. If I sent this to production then the error disappears and my app starts.

Any solution to this error?

+1

+1

+1 Running into the same issue running Rails 4.2 on Ruby 2.2 on heroku.

+1
4.2, 2.2, Jruby, heroku, incorrect server shutdown sequence. haven;t been able to fix yet.

I got the same issue when set up Redmine3.0.3 with Ruby2.1.5/Rails4.2.1/Unicorn4.9.0


feat(kdn): Derivation Test Runner for kona-derive

Description
Introduces a derivation test runner for kona-derive called kdn.
This is similar to revme, running the kona-derive pipeline over derivation test fixtures checked out in the op-test-vectors git submodule.

#414  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.0%. Comparing base (501416c) to head (59923ea).

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Developer > setting > preference request

in Developer Tools;
In the Sources panel the files are shown as tabs. When using large filenames the start of the filename and the extension is shown
Example: the filename is: iamalargefilename.js
Now the tab shows: iamalar.....js
I need to see the end part of the filename like: i.....filename.js
I would like to have a preferences that I can choose what part of the filename is shown in the tab.

@TimoPot please file a feature request at https://crbug.com


Fix for missing or improperly cached refresh tokens

The previous implementation was checking for presence of the
refresh_token key in the dependent token response object. It turns
out that doing an in check always returns true, so this changes to
checking for the value of None rather than doing an in check. In the
previous mode, we could attempt to create a RefreshTokenAuthorizer
with a None refresh_token which will always fail. This, in turn,
would not show up until an AP attempted to use the authorizer via an
SDK client, like TransferClient, which could make it hard to trace
back to the root cause.
We also change the dependent token cache to a TTLCache with timeout
of 47 hours instead of a basic LRUCache so that we don't keep tokens
around longer than the expected expiration any way. Thus, the
expectation is that in the common case, prior to any tokens expiring
and attempting a refresh, we will, instead, no retain the tokens which
are due to expire and cause a new dependent grant. This is somewhat
non-optimal assuming dependent grants are more expensive, particularly
for Auth, than refresh operations, but it also makes handling missing
refresh tokens in some way automatic since we don't use them as often.
To that last, the source for a lot of this is that the dependent
grants do not seem to be returning refresh tokens at all in some
cases. That led to the whole path of building this additional
robustness that we didn't expect to need for missing refresh
tokens. This robustness here is the right thing, but why refresh
tokens are not coming in some cases is still an unsolved issue.

@kurtmckee Thanks for the review, updated as suggested.

@kurtmckee @urimandujano @rudyardrichter I had pushed one revision that cleaned things up, but I wasn't too satisfied with the behavior in all cases (particularly where we have an expired access token, but no refresh token).
So, I've updated the logic in deciding how / when to return a refresh authorizer vs attempting another dependent grant. The logic is more convoluted, but I hope that the robustness makes it worth it.
Sorry to make such an extensive change after requesting review.

@jimPruyne I was thinking about this this afternoon and trying things out and I learned that the dependent_token_cache_id stays constant across different access tokens. So even if we send fresh tokens, its dependent_token_cache_id would be the same, which would cause a cache hit, which would get us an old dependent token grant response. Using the old LRUCache meant that we were never updating our dependent tokens. I feel pretty sure that switching to a TTLCache like you've done here will make things better!
I'm building on this PR with one that adds a bit more logging around cache activities.

A squash prior to merging would be excellent


Add CustomHandler extension to orchestrate

With the CustomHandler extension, users will be able to add their custom logic to the VM without having to implement a new VM.

Love it. Has this been run through grammarly?

Love it. Has this been run through grammarly?

Quickly doing that


Manifest Lectern Should Function Like an ME Terminal

Title. It should let you take items out and place them into the system, maybe increase the crafting cost to compensate for the balance shift.

Please see previous issues on this topic; this isn't the intent of the lectern.

To further elaborate, the manifest and lectern are intended for very early game use. They're a major improvement over vanilla sorting, but don't have the complete convenience of a full I/O system.
An upcoming device much later in ArcArc's internal progression is intended to allow for actual one stop I/O.


Add batch signing via hash merklization

Support batch signing with simple merklization of the hash. Still supports single signatures easily by just using empty arrays as the btes32[] proof field. Gives us forwards compatibility to add batch signing on the web-side as needed. Note that the frontend is trusted to prepare hashes honestly for users to sign for existing features like userOp preparation and even existing spend permissions too, so the trust model seems untouched.
Note that recurring allowances still have individualized state for approvals and revocations and permit flows still need to be done per-permission. This just adds batch signing as a new capability offchain.
Something feels a bit too flexible about this merklization, so I would be open to adding some kind of specific hash prefix just for "SpendPermissions" on the final root calculation. Need to consider security risks of this approach and generally it just places more risk on the frontend to prepare hashes correctly.

I'm not totally groking how a spendpermission-specific hash prefix for the final root calculation would provide better security but would love to be enlightened


Remove compatibility with PHP<7 and upgrade deps

@gauntface just FYI, you haven't published a npm version for your latest fix of web-push-testing-service.


Preprocessing notebook

A notebook for the generation of clean, consistent tables for use in downstream analyses. Rather than spending half a notebook trying to get data in a desired format, this centralizes the process.
Notebook can be viewed here.
This relies on files in #125.

Bumping this, since the tables are being distributed. @wasade, @ElDeveloper , @cuttlefishh:
Could you review this?
The

few comments below:
beta diversity likely includes archaea as well
boolian -> boolean
I don't think pandas was described as a requirement for the notebook
beta diversity hyperlink in "beta diversity parameters" doesn't work
ag is picked against Greengenes 13_8
greengenes -> Greengenes
in split directories and files, why are the underscores escaped? eg split_raw_dir. this happens in multiple places when describing variables, like file pattern fill-in, etc
why does the notebook download the preprocessed data if the point is to produce the preprocessed data?
the hyperlinks for the references don't work, look like they're formatted incorrectly

I only listed the requirements that were not superseded by QIIME or are
ambitious in QIIME. (You need the newest IPython, but the version of
pandas, matplotlib, etc. work fine with the QIIME dependencies.) Would it
clarify things to explicitly list these packages?
I think the issue is mixing markdown and HTML. It worked in my Safari and
Chrome, but it seems to be a problem in NBViewer. I will correct the issue.
The escapes are there because it explicitly forces the underscores to be
displayed, rather than italicizing the remaining text. So, I've put them in
explicitly to maintain the formatting.
I can't set up an explicit way to download the FTP as a hyperlink in an
IPython notebook.
Before the data was FTP, I had an in-text link to the HTML. I can assume
that if people want to download the data, they can run other notebooks, but
I sort of imagined that people looking at the notebook would want to get
the data for other things.
On Mon, Mar 30, 2015 at 8:17 AM, Daniel McDonald<EMAIL_ADDRESS>wrote:

few comments below:
beta diversity likely includes archaea as well
boolian -> boolean
I don't think pandas was described as a requirement for the notebook
beta diversity hyperlink in "beta diversity parameters" doesn't work
ag is picked against Greengenes 13_8
greengenes -> Greengenes
in split directories and files, why are the underscores escaped? eg
split_raw_dir. this happens in multiple places when describing variables,
like file pattern fill-in, etc
why does the notebook download the preprocessed data if the point is to
produce the preprocessed data?
the hyperlinks for the references don't work, look like they're formatted
incorrectly
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/American-Gut/pull/126#issuecomment-87719926.

Hyperlinks work with ftp, just use: ftp://ftp.microbio.me/foo/bar.
Pandas is not a dep of any of those IIRC, but might be wrong
On Mar 30, 2015 11:37 AM, "J W Debelius"<EMAIL_ADDRESS>wrote:

I only listed the requirements that were not superseded by QIIME or are
ambitious in QIIME. (You need the newest IPython, but the version of
pandas, matplotlib, etc. work fine with the QIIME dependencies.) Would it
clarify things to explicitly list these packages?
I think the issue is mixing markdown and HTML. It worked in my Safari and
Chrome, but it seems to be a problem in NBViewer. I will correct the issue.
The escapes are there because it explicitly forces the underscores to be
displayed, rather than italicizing the remaining text. So, I've put them in
explicitly to maintain the formatting.
I can't set up an explicit way to download the FTP as a hyperlink in an
IPython notebook.
Before the data was FTP, I had an in-text link to the HTML. I can assume
that if people want to download the data, they can run other notebooks, but
I sort of imagined that people looking at the notebook would want to get
the data for other things.
On Mon, Mar 30, 2015 at 8:17 AM, Daniel McDonald<EMAIL_ADDRESS>
wrote:

few comments below:
beta diversity likely includes archaea as well
boolian -> boolean
I don't think pandas was described as a requirement for the notebook
beta diversity hyperlink in "beta diversity parameters" doesn't work
ag is picked against Greengenes 13_8
greengenes -> Greengenes
in split directories and files, why are the underscores escaped? eg
split_raw_dir. this happens in multiple places when describing variables,
like file pattern fill-in, etc
why does the notebook download the preprocessed data if the point is to
produce the preprocessed data?
the hyperlinks for the references don't work, look like they're formatted
incorrectly
—
Reply to this email directly or view it on GitHub
<https://github.com/biocore/American-Gut/pull/126#issuecomment-87719926
.

—
Reply to this email directly or view it on GitHub
https://github.com/biocore/American-Gut/pull/126#issuecomment-87765751.

When I tried to make them in IPython, the hyperlink hover-over is a curser, not the little link-click hand. I looked over what I could find in StackOverflow, python and IPython documentation, but I couldn't find a satisfactory solution for linking to an ftp in the markdown cells.
Pandas is a scikit-bio dependency AFAIK.

Ah yeah, this is a known problem with Markdown.
On (Mar-30-15|10:58), J W Debelius wrote:

When I tried to make them in IPython, the hyperlink hover-over is a curser, not the little link-click hand. I looked over what I could find in StackOverflow, python and IPython documentation, but I couldn't find a satisfactory solution for linking to an ftp in the markdown cells.
Pandas is a scikit-bio dependency AFAIK.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/American-Gut/pull/126#issuecomment-87773239

With that in mind, how would you prefer to handle this?
The solutions I can come up with include something like the current
implementation, where a flag gets set to allow download or dataset
generation; removing a reference to the pre-generated dataset; or including
a link somewhere, with the note that it needs to be copied into the browser.
I think all three have advantages and drawbacks.
On Mon, Mar 30, 2015 at 11:00 AM, Yoshiki Vázquez Baeza <
<EMAIL_ADDRESS>wrote:

Ah yeah, this is a known problem with Markdown.
On (Mar-30-15|10:58), J W Debelius wrote:

When I tried to make them in IPython, the hyperlink hover-over is a
curser, not the little link-click hand. I looked over what I could find in
StackOverflow, python and IPython documentation, but I couldn't find a
satisfactory solution for linking to an ftp in the markdown cells.
Pandas is a scikit-bio dependency AFAIK.

Reply to this email directly or view it on GitHub:
https://github.com/biocore/American-Gut/pull/126#issuecomment-87773239

—
Reply to this email directly or view it on GitHub
https://github.com/biocore/American-Gut/pull/126#issuecomment-87774165.

This fixes the markdown issues with appearance and the links.
The download flag is still included in the notebook.
I'd like to get this merged sooner because it reflects tables we're sending out with the manuscript. It can live in my repo indefinitely, but it would be better to have it in master.

That notebook is :star2: amazing :star2:!

@ElDeveloper, merge?

@ElDeveloper: Any update on review?
Thank you for your help!

@JWDebelius and I are going through the notebook, we hope to have a final version around 4:00 pm PDT today.

Running a little behind.
Thank you for all the awesome help today, @ElDeveloper.
I had one question: you suggested applying the scipy.spatial.distance.euclidean function when calculating the best rarefaction. When I try to apply the function, it requires a 1D array. My understanding is that performance wise, it's better to operate on 2D numpy arrays than to do a list comprehension and then cast to an array, but I'm happy to do which ever?

My main suggestion for using the euclidian distance function in scipy,
was to improve the readability of those few lines of code, not really to
improve performance. However, if you think this is not ideal and cannot
be easily adapted, then it's find to leave as is.
On (Apr-13-15|20:20), J W Debelius wrote:

Running a little behind.
Thank you for all the awesome help today, @ElDeveloper.
I had one question: you suggested applying the scipy.spatial.distance.euclidean function when calculating the best rarefaction. When I try to apply the function, it requires a 1D array. My understanding is that performance wise, it's better to operate on 2D numpy arrays than to do a list comprehension and then cast to an array, but I'm happy to do which ever?

Reply to this email directly or view it on GitHub:
https://github.com/biocore/American-Gut/pull/126#issuecomment-92579202

Thanks @JWDebelius


Cannot Login

Starting Python process...
Bot path: /Users/stream/PokemonGo-Bot-Desktop/gofbot
python ./pokecli.py
Python: Traceback (most recent call last):
File "./pokecli.py", line 38, in
from pgoapi.exceptions import NotLoggedInException, ServerSideRequestThrottlingException, ServerBusyOrOfflineException
ImportError: No module named pgoapi.exceptions
Bot exited
This appears and I don't know how to fix it!
Im on a Mac and Ive set up everything!

FIxed it but now its says this when i get to the bot screen "2016-08-09 12:11:04,330 [PokemonGoBot] [ERROR] encrypt.so is not found! Please place it in the bots root directory or set libencrypt_location in config.
2016-08-09 12:11:04,330 [PokemonGoBot] [INFO] Platform: darwin Encrypt.so directory: /Users/stream/PokemonGo-Bot-Desktop/gofbot"

You need encrypt.so

Download and use it
http://www.mediafire.com/download/engnf5fvj65duxa/encrypt.so

How did you solve the first error?

@OscarToV most likely with:
pip install -r requirements.txt orpip install --upgrade -r requirements.txt

@Outpox  thanks!

having the same issue on windows
pip install requirements all went well with no error
encrypt.dll is present in root as well as under gofbot dir

@Outpox
I run sudo pip install --upgrade -r requirements.txt or pip install -r requirements.txt
and get:
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-YwdSHF/protobuf-to-dict/

https://github.com/PokemonGoF/PokemonGo-Bot-Desktop/issues/138


Orchestrator: Datasets and Data Sets

The orchestrator refers to Datasets and Data Sets.
Can it please be updated to refer just to Data Sets for consistency?

Could this be done please when the Orchestrator is updated to add the Broken Link Checker, see #310
Also, Class and Attribute could be updated to use a capital to match other items.

I've checked the latest test environment and the wording looks to be fixed now.


cmd/gofmt: puts else if comments in wrong place

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
play.golang.org
What operating system and processor architecture are you using (go env)?
play.golang.org
What did you do?
Ran this: https://play.golang.org/p/xJ0-Cq8ZYi and clicked format
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
here it is: https://play.golang.org/p/xJ0-Cq8ZYi
What did you expect to see?
I expected the B and C branch comments to be aligned the same way the A branch comment is..
What did you see instead?
Instead they were indented as if they were part of the previous block.
I get how this is a tricky issue, but if there is a blank line and the comment is right before the next block, I think it should be indented for that block.
Thanks!

It's not clear to me that this is wrong. The B and C comments are within the "{" and "}" of the first if block, so it makes sense to associate the comment at that indentation level.
\cc @griesemer

@dsnet If the comments didn't have a space after the previous if statements contents, and if they weren't right against the following line, I'd agree. Where else would you put the comment that should precede the else if?
I've amazingly found an edge case which just wasn't considered previously.
Thanks for looking into it.

I agree with dsnet.

Where else would you put the comment that should precede the else if?

If a comment is about branch B, I'd definitely put it inside the branch it refers to. Like this:
if A {
    // comment about A goes here, at the top of the A branch scope

    do stuff...

} else if B {
    // comment about B goes here, at the top of the B branch scope

     do stuff...

} else {
   // comment about else goes here, at the top of the 'else' branch scope

     do stuff...

}

IMHO putting a comment about B before its if (so in the scope of the previous, different branch) would be confusing even with the right indentation.

I think this is effectively a dup of #9910. As Russ says there:

Sometimes you want one or the other. Gofmt preserves what you've done.

@josharian Nice find! I'm okay with the fix in #9910 about leaving them untouched. It would be better than them always getting moved incorrectly in my case! Thanks for the comment!

Cool. Closing this as a dup, then.

@josharian Sorry if I wasn't clear, but this issue isn't fixed, the other one took the right approach which I think we should too!

OK, reopening, but I'm confused. I clicked on your original playground link, hit format, and nothing moved, which seems like exactly the proposed resolution--when there's ambiguity, don't move things. What am I missing?

@josharian Click format on this link:
https://play.golang.org/p/Odchgkj1Tg
I would expect either nothing to move, but unfortunately it does.
On the earlier link, I would expect things to move to look like this link, or if we agree with the solution in #9910 for nothing to move.

Found a workaround until this is fixed. You can do comments like this:
https://play.golang.org/p/NzdCwIZYF-
It's a bit awkward, but at least it's gofmt legal, and the comments are at the right indentation level.

Full code for those who hate link following:
package main

import (
	"fmt"
)

func main() {
	fmt.Println("Hello, sane comment indenting")

	if false {
		// bad indentation
		fmt.Println("if")
	} else
	// do something else...
	if true {
		fmt.Println("elseif")
	} else

	// otherwise...
	{
		fmt.Println("else")
	}
}

It's a bit awkward, but at least it's gofmt legal

I disagree completely. The bug in gofmt is that it this awkward workaround is legal. I would hate to this type of style in production, especially since gofmt doesn't fix it.
Removing the strategically-placed comments fixes it, but it requires the comments to be removed/replaced.
https://play.golang.org/p/OotrW-1T-K
It would be nice if gofmt was less lenient with this.

On Sat, Jun 24, 2017 at 4:55 AM, as<EMAIL_ADDRESS>wrote:

It would be nice if gofmt was less lenient with this.

The fix to "leave comments as they were" when nested above an else if would
be great!


Can you please add support for this website?

Domain
work.ink
Link
https://work.ink/en/l/1n8/DarkHubKey1
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Windows
(Optional) Anything else?
No response

A few days ago I opened the same link they should add support for work.ink cus it starting to be used a-lot now and it's annoying

Closed because it's a duplicate issue of #284.


feat!: insert latest semver into unversioned deps

Apparently snapshot testing won't work for us

Getting better

Closing this and fixing the remaining problem in another issue: https://github.com/hasundue/molt/issues/65


Decrease minSdkVersion to 14

Fix #83

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Azure Monitor Alerts Task is now Failing for creating alerts

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name: https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/AzureMonitorAlertsV0/task.json
Environment

Server - Azure Pipelines or TFS on-premises?
Azure Pipelines

Issue Description
Failed to update Azure metric alert rule 'Availability_PartsUnlimited-CD' Resource. Error: BadRequest - As part of classic alerts retirement, starting Sep 01, 2019, no new classic alerts can be created except on a few metrics listed here https://aka.ms/classic-aler.... All classic alerts including the exceptions listed will stop working after June 2020. It is strongly recommended to use new metric alerts. See https://aka.ms/create-metri.... (CODE: 400)

Trying this as part of this lab - https://azuredevopslabs.com/labs/vstsextend/releasegates/

Thanks for reporting. We will update the APIs and hotfix ASAP.

Thanks for reporting. Facing the same issue.

Hello @SumiranAgg and guys, I am facing the same issue and I'd like to know when will be available.

Error: Failed to update Azure metric alert rule 'Availability_Insights - Test' Resource. Error: BadRequest - As part of classic alerts retirement, starting Sep 01, 2019, no new classic alerts can be created except on a few metrics listed here https://aka.ms/classic-alerts-exceptions. All classic alerts including the exceptions listed will stop working after June 2020. It is strongly recommended to use new metric alerts. See https://aka.ms/create-metric-alerts.  (CODE: 400)

The Alert rules is a field required and whatever option shows the previous error, so I had to disable the Azure Monitor Alerts in the pipeline release.

We too have this issue, are pipelines are designed to not progress unless gates pass

@blueelvis We have marked this task deprecated . Use az Cli task to configure new alerts.


Alternatives - AAEQ damage

A menu item reading "Calculate Average Annual Equivalent Damage" must be added to the alternative child tree node. Using the period of analysis and discount rate defined in the study properties, the average annual equivalent damage should be calculated and be provided according to the reports found in the bottom image below. Users will be able to calculate average annual equivalent damage distributions (using the IDistribution interface in the Statistics.dll) by discounting the future year impact area scenario expected annual damages (defined in the Model.dll IMetric interface) at the user specified discount rate. The average annual equivalent dam age routine should make use of the IFunction interface that allows the user to specify the method of interpolation between future expected annual damage values associated with each impact area scenario (ICondition) element.A menu item reading "Calculate Average Annual Equivalent Damage" must be added to the alternative child tree node. Using the period of analysis and discount rate defined in the study properties, the average annual equivalent damage should be calculated and be provided according to the reports found in the bottom image below. Users will be able to calculate average annual equivalent damage distributions (using the IDistribution interface in the Statistics.dll) by discounting the future year impact area scenario expected annual damages (defined in the Model.dll IMetric interface) at the user specified discount rate. The interpolation of EAD between analysis years will be linear.

This is completed.


Update free-courses-en.md

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Add Docker list two resource

For youtube, we prefer "playlist" links and the name of the producer/creator. https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md#platforms-and-access-notes
Pleas close the other PR

For youtube, we prefer "playlist" links and the name of the producer/creator. https://github.com/EbookFoundation/free-programming-books/blob/master/CONTRIBUTING.md#platforms-and-access-notes

Both are 3h lvideos with chapters integrated in timeline, so it's ok for me :wink:

Pleas close the other PR

PR #6862 closed as duplicated

Thanks, and welcome to free-programming-books!


Add recipe for testing intents

I'm using a test helper for Presenter intents on my current project that I really like. I thought I'd make a recipe for it.

Coverage remained the same at 100.0% when pulling c5e9068ccfbd51950555c658844182328d4286d9 on nh-testing-recipe into 959e4731d66a81502e0e4dcedd5ba3e7c33403a8 on master.

Coverage remained the same at 100.0% when pulling deaf7efed251995cc9ecad4938d898b47d3bd4a1 on nh-testing-recipe into 959e4731d66a81502e0e4dcedd5ba3e7c33403a8 on master.

:+1:


Move image data extraction into entrypoint_lookup.go

Image data extraction (pulling entrypoint and digest) isn't specific to
the real implementation of fetching image metadata using K8s
imagePullSecrets, so having this only implemented and tested in that
context didn't make sense.
This change also adds cache population (Set) moved into the
EntrypointCache interface, rather than having it be a side effect of
Get. This means that entrypoint_lookup.go must call cache.Set after it
extracts digest.
The result is a cleaner separation of concerns between generic
entrypoint lookup logic and K8s-specific implementation, which is now
more narrowly scoped.
More iteration on #1605
Ideally this separation and testing would have helped catch #1674
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.

/lgtm


Areas and volumes

None of the connectors currently seem to reliably populate object areas or volumes. This is particularly important for volumes of built elements / display meshes in order to do calculations.
Will require properly converting square / cubic units which I don't think we currently do.
EDIT: Revit attaches them as a param so nvm. We still prob would want some sort of reliable vol or are coming from Rhino

Closing, we can reopen when we tackle this back


Doesn't work with bun test

Would be great if this worked with bun test, but I'm not managing to figure it out...

Nevermind.
Need to then add the preload again under the [test] in the bunfig


Fixed inline-code rendering issue.

Fix of issue #8575 (https://github.com/atom/atom/issues/8575)

It seems the issue only happens in Markdown Preview (because the background is white).
How about scoping it to only .markdown-preview like:
.markdown-preview code {
  text-shadow: none;
}

You're right about it. I will close this pull request.

I looked at the code of other atom themes and I saw a markdown-preview.less file. What do you think about that?

I looked at other atom themes and I saw a markdown-preview.less file. What do you think about that?

Ya, that would be a cleaner separation. Although an extra file for just a single rule might be a bit excessive?
I think keeping it in text.less for now is fine. And then in case there are more overriding needed, it could be split up.
Anyways, thanks for fixing this. :+1:


Segoe UI Regular EastEuropean, in 2015?

Why does a font named Segoe UI Regular EastEuropean exist in 2015? I thought we are all embracing Unicode out there…

This font exists for a couple of reasons:

It's the font that Microsoft uses for 'East European' text (not only used in Fabric.)  We also have subsets for Vietnamese, Thai, Cyrillic, etc.
It exists for keeping font downloads small.  We could create one giant font which has all the smaller subsets included, but the time it takes for the font download would be noticeable.

The way many products/websites work at Microsoft is to identify the users' language and then supply the localized text with the correct font and font stack.
If one were to use the Segoe UI Regular West European font to show a character specific to the East European character set, the resulting character may be shown in a fallback font rather than in a Segoe variant.
Hope this helps.


Add support for Azure SQL short term retention period.

Implements: https://github.com/pivotal/cloud-service-broker/issues/100
Upgrades to Azure RM provider version 2.31.0, and switches from azurerm_sql_database to newer azurerm_mssql_database resource type which is required to support the new short_term_retention_policy configuration block.

fixes #100

Thanks Michael!


'react-scripts-kotlin' is not recognized as an internal or external command, operable program or batch file.

Hi!
I'm trying to run the example.
I've cloned the repo. Then npm start and this error has been occurred:
'react-scripts-kotlin' is not recognized as an internal or external command,
operable program or batch file.

Can you try
npm i react-scripts-kotlin --save

now it compiles, but web app generates html with this message:
./node_modules/.cache/kotlin-webpack/kotlinApp.js
Module not found: Can't resolve 'axios' in 'C:\dev\git\my-kotlin-app\node_modules.cache\kotlin-webpack'

never mind, i've done npm install and now it works.
thanks for help!


GST was imported without specifying a version first

I pretty much just egt this whenever i try to run playmusiccl
<playmusiccl
/usr/lib64/python2.7/site-packages/playmusiccl-0.6.2-py2.7.egg/playmusiccl/playmusiccl.py:11: PyGIWarning: Gst was imported without specifying a version first. Use gi.require_version('Gst', '1.0') before import to ensure that the right version gets loaded.
from gi.repository import Gst
Can't find ~/.playmusicclrc

the Gst error can just be ignored. The important part is "Can't find ~/.playmusicclrc". Copy the example.playmusicclrc from the source folder into your home folder (and rename it to .playmusicclrc) and you should be able to run the program.  Side note, you also have to edit this file to log in to your google account.  read the README, this is all in there.


Vue loading fix

Fixed for workflow problem with assignment in "retrieve data" task for camunda 7.14 (docker container)
..Caused by: org.camunda.spin.xml.SpinXmlDataFormatException: SPIN/DOM-XML-01030 Cannot create context
Added missing :key property in tasklist.vue

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.maatini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Whats new/2023 04 april

Hello contributors to this month's visual studio code April 2023 update
Please see merge request
https://github.com/rokucommunity/rokucommunity.github.io/pull/31 merging into
https://github.com/rokucommunity/rokucommunity.github.io/pull/30
and draft document with the April 2023 changes listed on it.
https://github.com/philanderson888/rokucommunity.github.io/blob/whats-new/2023-04-April/src/pages/whats-new/2023-04-April.mdx
please feel free to add/suggest any amendments
also if you want to contribute images of the issue or solution that would be helpful.
Thanks
Phil
Thank you
@triwav (Brian Leighty)
@TwitchBronBron (Bronley Plumb)
@cewert (Charles Ewert)
@jean-guyrivard (Jean-Guy Rivard)
@sethmaclean (sethmaclean)
@taschmidt (Tim Schmidt)


pin glint version to ~> 0.16

cc @tynanbe in case you hadn't had a chance to see this :D

Thank you~


Feature Request: Generate a new module without a component

OS?
Mac OSX Sierra
Versions.
angular-cli: 1.0.0-beta.21
node: 6.9.1
os: darwin x64
Option 1
ng g m foo --no-component
This would generate the module without the component ts, css, spec, html
Option 2
ng g m foo
Or ideally the default would be to not generate a component at all. It can easily be created after by doing ng g c bar.
Why?

It is easy to add a component when needed.

It is distracting to generate a module and have 4 extra files created when you do not want them.

Avoids having to delete 4 files with rm bar.component.*

Details
use case ...
https://github.com/johnpapa/event-view/blob/master/src/app/core/core.module.ts
Notice this one … common use case for a module that contains mostly reusable services and only one component. And in this case, the component is not named the same as the module (and shouldnt be).
Option 2 above is my preference.

I agree that the default behavior of ng g m <name> should be to create an empty module file and pass a component flag, maybe something like ng g m foo --component=true.  I have added this option to my local copy of the cli, { name: 'component', type: Boolean, default: false }, and added a conditional in the afterInstall method to create a component if the flag is true.

After having a few conversations about this and thinking about it some more, I think we should have the modules just generate modules with one exception... routing modules. Routing modules can be created at two times: new app creation and module creation.
So what I'm suggesting on your PR, @baruchvlz, is to completely remove the --component option and only generate the module.
Thoughts?

I personally think it makes sense. Especially with component generation adding the declaration to the closest module up the tree.

@Brocco : Reading what @deebloo  said, it would make sense to have the command only generate the module unless the --routing flag is passed.
One questions though, should the spec file be generated by default as well just to match the other generate command of components, directives, etc... or are unit tests for modules not necessarily required?

I would leave it as is, it will pick up the default from here if it is not specified in angular-cli.json or passed in as an argument.

Oh, interesting thanks for pointing that out. I will make the changes to the PR.

PR has been updated.

PR merged, closing


⚠ Bofrost.nl has degraded performance

In e4abd96, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1610 ms

Resolved: Bofrost.nl performance has improved in a7ebb1e after 40 minutes.


Decrease the major version of Spring Cloud Azure to 5.0

Description
Address comments of API review.
We do not skip the major version 5.0, because Spring Boot 2.x will not produce new breaking changes, and Spring Cloud Azure should not produce the new breaking changes for  Spring Boot 2 support.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run java - spring - tests


🚀 Feature: Hide Support button if it's not configured

🔖 Feature description
When support is not configured in the app config, the support button should be hidden at least in production
🎤 Context
Having support button without any user interaction possibility as it is in the hands of the app owner is not good UX.
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Makes sense to me, it's not terribly useful at this point without config. What do you think @backstage/techdocs-core?

Totally agree, is this something you would like to work on @drodil?

I'm a fan of this change for usability, but without the empty search button in the UI to prompt implementation, is there sufficient documentation to nudge and direct adopters toward adding it back?

@efenner-cambia great call out - maybe its something we can add to the documentation of App configuration in the getting started guide . What do you think?

@efenner-cambia yep very good point. There's definitely part of me that thinks we can't really do this yet, i.e. there are some patterns and tools that we need to find in the frontend system before we're able to do this kind of configuration in a homogenous way.

I think there are multiple places in the documentation where we could better highlight "here's an example of a best practice that you can modify as needed". In this case it has been self documenting because you see it in the UI, but if we take that away then I just think it's worth making sure that the documentation will point users/adopters in the right direction.

Hi to all, are there any plans on this issue to be fixed?

@moley we would like to fix it, but it's not part of our backlog right now - We're happy to review contributions though in this area if someone would like to pick this up :pray:

This seems to have been solved in #27144 but the issue was not closed (yet).


Tweaking type specs

I pulled geo into a library of mine and had some dialyzer issues. I ran dialyzer against geo and uncovered a few incorrect specs. This PR addresses them.

Map.t() isn't a valid type. Changed it to map().
The Geo.WKT.encode!/1 spec had a typo (missing the !)
All the structs that make up the Geo.geometry() type could return nil under the srid key. Technically, you'd only need to change one of the struct specs, but it felt like the right thing to change them all.
A few different WKT and WKB functions related to encoding were spec'd to accept binary as their first argument. Should be Geo.geometry() instead.

I didn't include pulling dialyzer into the project as part of this PR. I know not everyone buys into dialyzer.
But let me know if you're interested in pulling it in. I'd be happy to open another PR to add it/integrate it into your Travis setup.

Thanks! Looks good to me!


plugin-iter8 seems to load an expensive yaml on preload

in this line: https://github.com/IBM/kui/blob/master/plugins/plugin-iter8/src/models/metrics.tsx#L37
we are fetching the metrics on initial page load. did we intend it to be content: getMetricsYaml() or could it be instead content: getMetricsYaml, i.e. defer fetching the yaml until the model is rendered?
as it stands, this slows down initial page load quite a bit

Fixed by #5447


[Demo Site] Removes caching of markdown files for server demo app

Pull Request
📖 Description
Fixes issue where markdown content of WhatsNew page would not render when navigated to the second time.
🎫 Issues
Size limits on JavaScript interop calls
An exception is thrown because the size of the markdown being sent back is exceeds the size limit.
👩💻 Reviewer Notes
I created two separate extensions to add the services required for the demo site, AddFluentUIDemoClientServices and AddFluentUIDemoServerServices,  and removed AddFluentUIDemoServices.
📑 Test Plan
✅ Checklist
General

[ ] I have added tests for my changes.
[X] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[X] I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

As for adding caching to the server side, if that is still desirable I can. I did some preliminary work based on Caching in .NET. The improvement was marginal and could be barely perceived from the user perspective.
It can still be added. Should I?

As for adding caching to the server side, if that is still desirable I can. I did some preliminary work based on Caching in .NET. The improvement was marginal and could be barely perceived from the user perspective.
It can still be added. Should I?

No, think we can leave it out of the server variant. Normally we are ony running that locally anyway.


Create documentation for custom Twig filters

From #763. Custom filters should be documented. Is this best handled in straight markdown? In PHPDoc? I'll leave that to @lggorman to determine

[ ] Filter reference outputs to Slate documentation

#787 contains edits to extending Timber and custom Twig filter functions.

@jarednova is this okay now?


Remove loop from elapsed slots calculation

Problem
A loop that calculates the number of elapsed slots between two epochs depend on the difference between the start and the end epoch:
https://github.com/anza-xyz/agave/blob/bb70670048f589264f83111a4fdb4972eea18a41/sdk/src/rent_collector.rs#L93
This loop can get quite slow (>20 minutes) if the difference between them is too large.
Summary of Changes
Remove the loop and perform a constant calculation.
I wrote a big comment explaining where I got the expressions from. The math behind it is quite involved, so I included a sanity and a fuzzy test.

This loop can get quite slow (>20 minutes) if the difference between them is too large.

What constitutes as "too large"?

The input my fuzzer generated has zero for the account_rent_epoch and<PHONE_NUMBER>604 (this is around 2^40). A loop with these conditions causes a timeout.

This loop can get quite slow (>20 minutes)

Do you know what specifically causes the slowness?

Running 2^40 iterations takes a long time.

Math on a paper is different from math on a computer, because on a paper nothing overflows. I found out I wasn't handling u64::MAX cases correctly due to saturating_ operations. I have to revise the PR, so I'm marking it as a draft again.

Closing in favor of #2411.


HTTP sender for jaeger.thrift

HTTP sender for jaeger.thrift.
resolves: https://github.com/uber/jaeger-client-java/issues/186

I get 200 from HttpClient but traces are not stored :/

There is a crossdock module that is used for end-to-end testing of spans collection. I would recommend adding an env var to that module that would control whether the client should use a UDP sender or HTTP sender. Then we can have both modes tested via end to end test.

+1 I haven't worked on tests yet.
When I'm using THttpClient(url, new DefaultHttpClient()) I cannnot see any traces being stored, however server returns 200. When I create a direct http request with thrift converted to byte[] it's stored fine.

I cannnot see any traces being stored, however server returns 200.

@vprithvi do we have logging if we cannot parse the HTTP request?

Codecov Report

Merging #194 into master will increase coverage by 0.07%.
The diff coverage is 76.19%.

@@             Coverage Diff              @@
##             master     #194      +/-   ##
============================================
+ Coverage     81.26%   81.33%   +0.07%
- Complexity      464      468       +4
============================================
  Files            77       79       +2
  Lines          1804     1822      +18
  Branches        211      211
============================================
+ Hits           1466     1482      +16
- Misses          249      250       +1
- Partials         89       90       +1

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/com/uber/jaeger/senders/UdpSender.java
71.42% <100%> (+0.51%)
4 <3> (-7)
:arrow_down:

.../main/java/com/uber/jaeger/senders/HttpSender.java
66.66% <66.66%> (ø)
2 <2> (?)

...ain/java/com/uber/jaeger/senders/ThriftSender.java
76.59% <76.59%> (ø)
9 <9> (?)

...jaeger/reporters/protocols/ThriftUdpTransport.java
77.96% <0%> (-5.09%)
14% <0%> (-2%)

.../uber/jaeger/samplers/RemoteControlledSampler.java
92.95% <0%> (+1.4%)
19% <0%> (+1%)
:arrow_up:

...java/com/uber/jaeger/reporters/RemoteReporter.java
90% <0%> (+2.85%)
9% <0%> (ø)
:arrow_down:

...in/java/com/uber/jaeger/samplers/ConstSampler.java
66.66% <0%> (+6.66%)
4% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97081c...76d9de5. Read the comment docs.

hmm when I print fmt.Println(req.GetBatches()) after tdes.Read(&req, bodyBytes); it shows []

@vprithvi do we have logging if we cannot parse the HTTP request?

We do, but it might also mean that the thrift deserializer is failing silently.

Now the HttpSender is directly using http client. I think the problem is that Collector.Client#send_submitBatches() calls TServiceClient#sendBase() which adds TMessage to the body and on the server side it fails to deserialize.

@yurishkuro I have a question about crossdock.. Do you mean add another axis (AXIS_SENDER=udp,tcp) ? It also requires to add it to the jaeger-client-go and other services in order to propagate that value. It also means that tracer will be changed for the the lifetime of crossdock test which I guess can cause problems.

Do you mean add another axis (AXIS_SENDER=udp,tcp) ?

Not quite. We define the test with BEHAVIOR_ENDTOEND=testdriver,services, which means the "services" axis must be enumerated. That axis is currently defined as AXIS_SERVICES=java, where java refers to Java server using the UDP sender.
    java:
        build: .
        ports:
            - "8080-8082"

We can add another type of server
    java_http:
        build: .
        ports:
            - "8080-8082"
        environment:
            - SENDER=http

Then we change the crossdock java server to look at that env var when instantiating the tracer with different sender. Then if we change the axis to AXIS_SERVICES=java, java_http the end-to-end test will be run twice, against both servers.
We can also rename java -> java_udp and give it SENDER=udp to be explicit and not have any default for sender type when creating the tracer.
Side note: "services" is not a good name for the axis, e2eserver / AXIS_E2ESERVER would be better (e2e_server even better, but not sure if crossdock will recognize AXIS_E2E_SERVER).

I have made some progress. Currently this is failing:
[endtoend] test_driver→ (services=java-http testdriver=test_driver) ⇒ Fail: could not retrieve traces from query service
✗ [endtoend] test_driver→ (services=java-udp testdriver=test_driver) ⇒ Fail: could not retrieve traces from query service

I'm not sure what should I change to make it work. Probably tracer's service name? When I change it here https://github.com/pavolloffay/jaeger-client-java/blob/dd026c7a12ca48dca5f2e0983a1b315a2ecdda7c/jaeger-crossdock/src/main/java/com/uber/jaeger/crossdock/resources/behavior/EndToEndBehavior.java#L46-L46 it fails.

Yeah, need to be careful with service names. I opened https://github.com/uber/jaeger/issues/205 to clarify this.

Side note: "services" is not a good name for the axis, e2eserver / AXIS_E2ESERVER would be better (e2e_server even better, but not sure if crossdock will recognize AXIS_E2E_SERVER).

This requires changes in test-driver:
https://github.com/pavolloffay/jaeger/blob/bb790e790a3850c66c7f8a4bf049379bce8c320f/crossdock/services/tracehandler.go#L41-L41

it's ready for review :octocat: .
https://github.com/uber/jaeger/issues/205 should go first, then I will adjust this.

I little bit refactored xdock to make it more consistent.

PR updated and HTTP sender sends a single Batch.
Could this make it to 0.20.0 release?

PR updated.

do we need to make any configuration changes so that users can configure the client to use the HttpSender?

Configuration by default uses UDP sender, however RemoteReporter accepts Sender interface so users can use HTTP impl.

Can you cover the code that you wrote?

I have added only HTTP sender, which is tested in xdock. Do we want to add other integration test for it?

Configuration by default uses UDP sender, however RemoteReporter accepts Sender interface so users can use HTTP impl.

Right, but won't it make sense to add String senderType to ReporterConfiguration so that the configuration can take care of initializing the correct Sender rather than have the user manually create the reporter?

I have added only HTTP sender, which is tested in xdock. Do we want to add other integration test for it?

Looking at codecov, it looks like code coverage dropped for this PR by 1%. Whatever new code was added should be covered.

Right, but won't it make sense to add String senderType to ReporterConfiguration so that the configuration can take care of initializing the correct Sender rather than have the user manually create the reporter?

Why string senderType? Actually is there any requirement to have string sampler type? Configuration what we have right now is not the nicest thing, there are two ugly things: constructors like Foo(0,0,0,0) for default values and these string types things (currently only for sampler) .

Looking at codecov, it looks like code coverage dropped for this PR by 1%. Whatever new code was added should be covered.

From the report it's not clear to me what should be covered. As I said this adds only HttpSender for which integration test has been added in crossdock. If you have something specific in mind let me know please.

PR rebased and squashed. Could somebody review?
@black-adder about the tests for HttpSender do you want to create integration test which would start http server and check if it works, btw the same is doing xdock test proposed by @yurishkuro.

Integration tests would be nice but looking at the coverage, it looks like we don't have any unit tests for httpsender and udpsender after the refactor.

@black-adder I don't know where are you looking at coverage but there are unit tests for udpSender.

https://codecov.io/gh/uber/jaeger-client-java/compare/1d9715841e4a7235a1dd0be727bb360da5e23286...d8f122efddf4614976c06ab1fef57e2040c8f526/diff

It seems that jacoco does not work properly with inheritance..?


AWS Lambda Support

Does anyone know how to make sanic run in a serverless infrastructure like AWS Lambda?

Right now you would have to follow this: http://docs.aws.amazon.com/lambda/latest/dg/lambda-python-how-to-create-deployment-package.html

Seriously? Does sanic have a handle function that accepts 2 parameters?

No I was just kidding.

Thank goodness. I thought somebody has been able to make it work with Zappa

https://github.com/Miserlou/Zappa/issues/798

I think that Sanic isn't WSGI?
You may need this: https://github.com/ashleysommer/sanic-dispatcher

@Miserlou You would be correct in assuming that Sanic does not have WSGI compatibility
And sanic-dispatcher does look awesome!

If anybody wants to try it,
I think
https://github.com/fifthecho/zappa-sanic
plus
https://github.com/Miserlou/Zappa/issues/798#issuecomment-299952245
should work

I would like to point out that using Sanic with lambda is kinda pointless as it will invoke a new server for each request defeating Sanic's purpose.
I've found that using Flask with Zappa's beautiful async decorator https://blog.zappa.io/posts/zappa-introduces-seamless-asynchronous-task-execution is more than enough (it will simply call a new lambda instance)

Just a note, that's not how AWS Lambda works. AWS Lambda uses something like docker and pauses the instance when there are no pending requests or response. So it is indeed possible to have a long-lived server in AWS Lambda.

Just a note, that's not how AWS Lambda works. AWS Lambda uses something like docker and pauses the instance when there are no pending requests or response. So it is indeed possible to have a long-lived server in AWS Lambda.

It pauses but effectively dies, it won't route two requests to the same instance


Update setup.py

I need this in order to do pip install. Thank you!

Thank you for sending the patch to this project.
However, the file README.md is encoded by utf8 not cp950. Does changing the encoding from cp950 to utf-8 works for you?

Hi~ I ran into a UnicodeDecodeError while using pip install
After looking at the error and doing some research, I though that maybe it would work if I changed that line of code?
Here is a snapshot of the error.
Thank you so much!


More details needed for adding MDX support

Hi,
I would like to work on adding MDX support if it is not taken by someone else yet. I have few questions for this.

After adding MDX support will .md files coexist with .mdx files ? Meaning we can either write in .md or .mdx.
Are we going to use MDX parsing for .md files ?
Will .mdx files treated directly as pages or it will follow same structure as .md files ?

Hey there @pandaa880. I have plans to work add mdx support, but sure, you can work on it.
For your questions

After adding MDX support, will .md files coexist with .mdx files? Meaning we can either write in .md or .mdx
We could have them co-exist if possible. But what's the use case for using mdx and md together since mdx is a superset of md?

Are we going to use MDX parsing for .md files?
I really don't know how this would work. peacock currently uses remark for parsing .md file. But you can try anything.

Will .mdx files treated directly as pages or it will follow the same structure as .md files?
You can try as much as possible to follow the current structure. Basically limiting mdx support to just content pages.

I really don't know how to go about this too. But I'm open-minded and will learn a lot from your implementation. Maybe you should just send a pull request if possible, we could discuss further improvements after then.
Thanks

I also don't see a case to keep both .md and .mdx files together. I was just not sure if we would replace the current flow of .md files with .mdx. Anyway, we will only use .mdx files.
I agree with you for the improvement part. Let's create a basic implementation first and then we can discuss further.

Great. Great.


Tailwind css config issue (The system cannot find the file specified.)

After installing tailwind css with this command
curl -sLO https://github.com/tailwindlabs/tailwindcss/releases/latest/download/tailwindcss-
Command tailwindcss -h its working
Output:
C:\Users\ayusha>tailwindcss -h
tailwindcss v3.4.10
Usage:
tailwindcss [--input input.css] [--output output.css] [--watch] [options...]
tailwindcss init [--full] [--postcss] [options...]
index.html
<html>
    <head>
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width, initial-scale=1.0">
        <meta name="scaffolded-by" content="https://github.com/schultek/jaspr">

        <title>student_management_system</title>
        <link rel="stylesheet" href="styles.css"/>
        <!--
            Loads and runs the compiled 'main.dart' file,
            can be changed to any other .dart file inside /web.
        -->
        <script defer src="main.dart.js"></script>
    </head>
    <body>
        <!-- Your app component will be inserted here. -->
    </body>
</html>

File architecture:
web < styles.tw.css
@tailwind base;
@tailwind components;
@tailwind utilities;

Where i am doing wrong here ??
This is my pubspec.yaml
description: A new jaspr project.
version: 0.0.1

environment:
  sdk: '>=3.0.0 <4.0.0'

dependencies:
  flutter:
     sdk: flutter
  jaspr: ^0.15.0
  jaspr_flutter_embed: ^0.3.4
  jaspr_router: ^0.5.1

dev_dependencies:
  build_runner: ^2.4.0
  jaspr_web_compilers: ^4.0.10
  jaspr_builder: ^0.15.0
  flutter_test:
    sdk: flutter
  flutter_lints: ^3.0.0
  jaspr_tailwind: ^0.3.0

jaspr:
  mode: client

flutter:
  uses-material-design: true

Error
[BUILDER] [ERROR] ProcessException: The system cannot find the file specified.
[BUILDER] [ERROR]
[BUILDER] [ERROR] Command: tailwindcss --input C:\Users\ayusha\AppData\Local\Temp\scratch_space6a2d55f2\web\styles.tw.css --output C:/Users/ayusha/AppData/s[BUILDER] [ERROR] Failed after 2m 47s
[CLI] [ERROR] Failed building web assets. There is probably more output above.
[BUILDER] [ERROR] ProcessException: The system cannot find the file specified.
[BUILDER] [ERROR]
[BUILDER] [ERROR] Command: tailwindcss --input C:\Users\ayusha\AppData\Local\Temp\scratch_space6a2d55f2\web\styles.tw.css --output C:/Users/ayusha/AppData/Local/Temp/scratch_space6a2d55f2/web/styles.css --confs
[BUILDER] [ERROR] Failed after 2.4s
[CLI] [ERROR] Failed building web assets. There is probably more output above.

Hey @schultek I will add my voice to this issue as I have been having the exact same issue.
Everything is installed as specified in the docs but have an issue similar to the original author.
I have just resorted to using the tailwind cdn link directly as an alternative to bypass this.
Also mentioned it in a different issue before seen here.
Do wonder if there are gotchas or something we aren't doing right to get this working properly.
Thanks.

Hey @schultek I have figured out that while using server-side rendering, both Tailwind and the @Css annotation are working, but in client-side rendering, neither the CSS annotation is working nor Tailwind is correctly configured.

Hi @schultek, I guess I know what the issue is. It is just that dart doesn't detect environment variables sometimes, I don't know the exact issue, but I know how to fix it.
If the parameter runInShell is set to true in jaspr_tailwind at line 55, it seems to work on my pc.
Let me know if this was the issue and if I can open a PR with this change?

Can also confirm that forking jaspr_tailwind and setting runInShell: true solves this issue for me.

@ShivanshuKGupta Thanks for investigating, a PR would be much appreciated.

Merged and fixed in jaspr_tailwind v0.3.1


introduce testscript, fix return bug, add map keys sorting, non color mode bug fix

[x] Introduce testscript
[x] Failing test
[x] Fixed bug reset color code being printed in non color mode
[x] Sort object keys by type then content
[x] Adding test of sample.gr's output
[x] Fix bug #46

LGTM, even if I'm reviewing once merged


Revert removal of diagnostic.open_float

This kickstart has been a great way to get into a minimalistic pre-configuration. However, after going through it my self, I have noticed that the diagnostic key does not exist in the LSP.
I didn't know why at the time, and it is a very useful function that I use it all the time in my previous setup. It was hard to believe that it was NEVER included, so I had to dig through history to find out why and where was it removed. Then I found out that it was removed due nvim 0.10 release and the introduction of d default hotkey. I didn't even know this hotkey existed if I weren't going through this.
This was a brief explanation of my personal experience, and personally I feel that it is removed way too soon. Not many people going to be familiar with the d hotkey right away, especially that 0.10 is a newish release and many people haven't caught up yet. I think adding this Code Diagnostic command in the LSP can be helpful, with the comment introduction of the d hotkey as well for those who prefer to opt out of it.
In the future, when many people are familiar with the new default hotkey, it can be removed.

Thank you for your contribution, however given the excellent online help available I think people should update their workflow to the current actual workflow so I'm very hesitant to merge this.
I'm going to close it, but if others feel differently please chime in.

Thanks @Mclilzee I am using this as well.
@Mclilzee what is the new default hotkey? I am not familiar with d hotkey.


Add new production assets hostname

We're going to be moving assets to this hostname at some point.
I've left the old one in because there's no reason to remove it now.

Could you add this domain to the docs about images too?

Have done, thanks! How does that sound?

👍


svd2rust: 0.33.1 -> 0.33.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rust-embedded/svd2rust/releases.
meta.description for svd2rust is: Generate Rust register maps (structs) from SVD files
meta.homepage for svd2rust is: https://github.com/rust-embedded/svd2rust
meta.changelog for svd2rust is: https://github.com/rust-embedded/svd2rust/blob/v0.33.2/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.33.2 with grep in /nix/store/y8wqpxxvzq6zhz3f3w9n4nqmd2zjnj2q-svd2rust-0.33.2
found 0.33.2 in filename of file in /nix/store/y8wqpxxvzq6zhz3f3w9n4nqmd2zjnj2q-svd2rust-0.33.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

svd2rust

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/y8wqpxxvzq6zhz3f3w9n4nqmd2zjnj2q-svd2rust-0.33.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A svd2rust https://github.com/r-ryantm/nixpkgs/archive/be0140e44e6ecf9d431f6c2ba4486b43b8f8b6a4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/be0140e44e6ecf9d431f6c2ba4486b43b8f8b6a4#svd2rust

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/y8wqpxxvzq6zhz3f3w9n4nqmd2zjnj2q-svd2rust-0.33.2
ls -la /nix/store/y8wqpxxvzq6zhz3f3w9n4nqmd2zjnj2q-svd2rust-0.33.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

svd2rust

Maintainer pings
cc @newAM for testing.

Result of nixpkgs-review pr 309860 run on x86_64-linux 1

1 package built:

svd2rust


Satisfiability Assertions

Adding support for assertions about the satisfiability (or unsatisfiability) for assertions. These take the form:
assert <predicatename> is sat
assert <predicatename> is unsat
assert <predicatename> is forge_error

@sidprasad Looks good. I made some minor revisions; if they look OK to you, go ahead and merge in.
I believe the answer to the comment I deleted is "yes", assuming it meant that both options were valid (not that they might be valid together).


add indices to thread names

Problem
No detailed metrics per thread (only summary because thread name can be same)
Summary of Changes
Add index to thread name

@alexpyattaev might be interesting to you

This fixes immediate problem. Thread manager will also give threads unique numbers if spawned from same pool, using pretty much the same logic. I see no reason not to merge this now though.


Use exact same arrow as GS uses

Uses the same svg as Groundspeak uses for their dropdown menu.

Manual merge, there are some conflicts..


pudb ui when using wandb

Describe the bug
I use pudb to debug my code. Currently, when I use wandb, it will affect the pudb UI.
Usually pudb should fill the whole terminal window, whereas now it becomes fixed sized and very small.
Also reported here: https://github.com/CompVis/taming-transformers/blob/master/main.py#L441
Any clue why that happens?
To Reproduce
Expected behavior
Using wandb should not affect pudb?
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hey @ruotianluo
Would you be able to attach some screenshots of what is happening here?