ChaikinMoneyFlowIndicator

Tried to use ChaikinMoneyFlowIndicator(14) on WTI futures data from Quandl and found out gaps:

OHLCV (2009-03-20,51.556,52.602,50.86,51.868,163397.4) = 0.21483617272294842
OHLCV (2009-03-23,52.13,54.05,51.62,53.8,229890.0) = 0.220560912295664
OHLCV (2009-03-24,53.83,54.2,52.45,53.98,212790.0) = 0.19622175756695917
OHLCV (2009-03-25,53.73,54.18,51.86,52.77,283727.0) = 0.20621706970653647
OHLCV (2009-03-26,52.84,54.66,52.76,54.34,196916.0) = 0.21041174980358116
OHLCV (2009-03-27,54.0,54.28,51.64,52.38,181165.0) = 0.1888587339287318
OHLCV (2009-03-30,52.25,52.25,48.11,48.41,222171.0) = 0.2009217137558275
OHLCV (2009-03-31,48.64,50.0,47.77,49.66,240254.0) = 0.35813238062169545
OHLCV (2009-04-01,48.96,48.96,47.26,48.39,234224.0) = 0.2965932845899256
OHLCV (2009-04-02,48.45,52.87,48.45,52.64,270270.0) = 0.40674044855541536
OHLCV (2009-04-03,52.36,53.9,51.02,52.51,212172.0) = 0.3444921018656213
OHLCV (2009-04-06,52.4,53.6,49.81,51.05,228983.0) = 0.2743862311177961
OHLCV (2009-04-07,51.39,51.82,48.4,49.15,254031.0) = 0.17441382122286686
OHLCV (2009-04-08,48.47,51.3,47.37,49.38,352611.0) = 0.13629812241059033
OHLCV (2009-04-09,49.96,52.45,49.72,52.24,294835.0) = 0.19659626697649885
OHLCV (2009-04-13,52.0,52.15,48.84,50.05,290456.0) = 0.11814331435094565
OHLCV (2009-04-14,49.96,51.12,48.85,49.41,284710.0) = 0.03016374982900696
OHLCV (2009-04-15,49.16,50.79,48.91,49.25,228056.0) = 0.006461712129088827
OHLCV (2009-04-16,50.202,50.984,49.608,50.416,187772.6) = -0.0216211167819643
OHLCV (2009-04-17,50.758,52.106,50.302,51.186,147673.0) = 3.994585025716414E-4
OHLCV (2009-04-20,51.42,51.57,47.09,47.458,189016.8) = 0.009776004395794612
OHLCV (2009-04-21,47.644,48.872,46.142,48.142,248319.0) = -0.005284241769906233
OHLCV (2009-04-22,48.68,49.09,47.7,48.85,238729.0) = 0.017809782775359016
OHLCV (2009-04-23,48.49,49.92,48.37,49.62,227296.0) = -0.012345840436732312
OHLCV (2009-04-24,49.65,51.75,49.06,51.55,230865.0) = 0.043304956636592666
OHLCV (2009-04-27,51.45,51.45,48.01,50.14,265293.0) = 0.08424303302229079
OHLCV (2009-04-28,50.1,50.19,48.55,49.92,186823.0) = 0.1653660658891755
OHLCV (2009-04-29,49.25,51.42,49.12,50.97,234826.0) = 0.21278719529737736
OHLCV (2009-04-30,50.79,51.94,50.21,51.12,208296.0) = 0.14327455764464483
OHLCV (2009-05-01,50.95,53.65,50.43,53.2,248750.0) = 0.22749132874470507
OHLCV (2009-05-04,52.62,54.64,52.56,54.47,229782.0) = 0.341101539870671
OHLCV (2009-05-05,54.46,54.83,53.5,53.84,234306.0) = 0.35049975228487285
OHLCV (2009-05-06,54.12,56.47,53.57,56.34,334302.0) = 0.41880050836932375
OHLCV (2009-05-07,56.3,58.57,55.46,56.71,377826.0) = 0.37029796459876113
OHLCV (2009-05-08,56.5,58.75,56.15,58.63,291819.0) = 0.4784659041996046
OHLCV (2009-05-11,58.49,58.63,56.78,58.5,290030.0) = 0.5100844580526647
OHLCV (2009-05-12,58.1,60.08,57.81,58.85,305957.0) = 0.45111533133656867
OHLCV (2009-05-13,59.29,59.9,57.41,58.02,311802.0) = 0.361407807609118
OHLCV (2009-05-14,57.884,59.084,56.94,58.78,235719.6) = 0.3535749939990562
OHLCV (2009-05-15,58.564,58.768,56.442,56.604,195036.6) = 0.29760453824486094
OHLCV (2009-05-18,57.928,59.486,57.638,59.366,187260.2) = 0.3077796324942861
OHLCV (2009-05-19,59.592,60.176,59.47,60.01,229110.0) = 0.3023969070784397
OHLCV (2009-05-20,60.8,62.04,60.8,62.04,270022.0) = 0.36667747487822916
OHLCV (2009-05-21,60.1,61.05,60.1,61.05,237412.0) = 0.38339044063202565
OHLCV (2009-05-22,61.67,61.67,61.67,61.67,186302.0) = NaN
OHLCV (2009-05-26,59.8,62.45,59.8,62.45,267127.0) = NaN
OHLCV (2009-05-27,63.0,63.45,62.85,63.45,261888.0) = NaN
OHLCV (2009-05-28,63.56,65.35,63.56,65.08,281439.0) = NaN
OHLCV (2009-05-29,65.68,66.31,65.4,66.31,261370.0) = NaN
OHLCV (2009-06-01,67.73,68.58,67.73,68.58,234080.0) = NaN
OHLCV (2009-06-02,68.55,68.65,68.35,68.55,266861.0) = NaN
OHLCV (2009-06-03,67.8,67.8,65.45,66.12,322365.0) = NaN
OHLCV (2009-06-04,67.65,69.25,67.65,68.81,304674.0) = NaN
OHLCV (2009-06-05,68.49,69.05,68.02,68.44,329259.0) = NaN
OHLCV (2009-06-08,67.95,68.88,67.95,68.09,289278.0) = NaN
OHLCV (2009-06-09,69.67,70.01,69.1,70.01,316884.0) = NaN
OHLCV (2009-06-10,70.9,71.55,70.55,71.33,346248.0) = NaN
OHLCV (2009-06-11,72.14,72.92,72.14,72.68,314790.0) = NaN
OHLCV (2009-06-12,71.9,72.04,71.9,72.04,224601.0) = 0.4730439853072078
OHLCV (2009-06-15,70.0,70.62,69.76,70.62,242211.0) = 0.46975824783963177
OHLCV (2009-06-16,72.75,72.75,70.47,70.47,266350.0) = 0.3371883209316747
OHLCV (2009-06-17,69.84,71.222,69.58,71.164,242088.6) = 0.34772060311844577
OHLCV (2009-06-18,71.018,71.802,70.748,71.586,167492.2) = 0.31413435971406983
OHLCV (2009-06-19,71.068,71.65,69.46,69.832,208920.8) = 0.21936094599380054
OHLCV (2009-06-22,69.52,69.69,66.686,67.386,245916.8) = 0.1629193495696546
OHLCV (2009-06-23,67.15,69.68,66.37,69.24,279901.0) = 0.2557980517708237
OHLCV (2009-06-24,68.55,69.86,68.06,68.67,242855.0) = 0.20211110467242885
OHLCV (2009-06-25,68.29,70.93,68.11,70.23,254942.0) = 0.2581532867478829
OHLCV (2009-06-26,70.34,71.29,68.81,69.16,254942.0) = 0.2659315094490548
OHLCV (2009-06-29,69.25,71.92,68.36,71.49,229882.0) = 0.23202240461763549
OHLCV (2009-06-30,71.6,73.38,68.9,69.89,331550.0) = 0.12493227937606308
OHLCV (2009-07-01,70.45,71.85,68.52,69.31,331550.0) = 0.04051903933245649
OHLCV (2009-07-02,69.22,69.74,66.26,66.73,243250.0) = -0.07323536035647343
OHLCV (2009-07-06,65.54,65.65,63.4,64.05,256986.0) = -0.17154035734764853
OHLCV (2009-07-07,64.19,64.91,62.21,62.93,262358.0) = -0.13122338086390598
OHLCV (2009-07-08,62.31,62.68,60.01,60.14,334958.0) = -0.2725316541076109
OHLCV (2009-07-09,60.38,61.62,59.25,60.41,314800.0) = -0.2897584410523704
OHLCV (2009-07-10,60.45,60.89,58.72,59.89,50.0) = -0.26815462264201256
OHLCV (2009-07-13,59.86,60.67,58.32,59.69,301907.0) = -0.2141903624232025
OHLCV (2009-07-14,60.14,61.46,59.15,59.52,305947.0) = -0.325441860939894
OHLCV (2009-07-15,59.79,62.0,59.65,61.54,279729.0) = -0.25509830855323284
OHLCV (2009-07-16,62.196,62.446,60.522,62.228,231697.0) = -0.24289943486943366
OHLCV (2009-07-17,62.584,64.394,61.46,63.968,188528.2) = -0.15969531974853035
OHLCV (2009-07-20,63.974,65.5,63.796,64.766,202881.0) = -0.20167916571306657
OHLCV (2009-07-21,65.128,66.45,64.398,65.432,248696.8) = -0.15308375951644654
OHLCV (2009-07-22,65.03,65.77,63.76,65.4,319989.0) = -0.045788737204932387
OHLCV (2009-07-23,65.4,67.49,64.4,67.16,321627.0) = 0.07579237525116406
OHLCV (2009-07-24,66.62,68.2,66.46,68.05,217270.0) = 0.15831047219774366
OHLCV (2009-07-27,68.05,68.99,67.6,68.38,245180.0) = 0.2024686710757698
OHLCV (2009-07-28,68.26,68.86,66.48,67.23,253558.0) = 0.2680508274142101
OHLCV (2009-07-29,66.68,67.01,62.7,63.35,342411.0) = 0.1987074563522279
OHLCV (2009-07-30,62.86,67.29,62.76,66.94,344216.0) = 0.2572392305859707
OHLCV (2009-07-31,66.69,69.74,64.96,69.45,400836.0) = 0.32812768220463523
OHLCV (2009-08-03,69.3,71.95,69.09,71.58,323455.0) = 0.44086968427470064
OHLCV (2009-08-04,71.34,71.95,70.16,71.42,285877.0) = 0.4265195457287551
OHLCV (2009-08-05,71.82,72.1,69.71,71.97,307551.0) = 0.44214855846816575
OHLCV (2009-08-06,71.83,72.42,70.18,71.94,328670.0) = 0.44023319901655555
OHLCV (2009-08-07,71.81,72.84,70.38,70.93,367023.0) = 0.36981030393084097
OHLCV (2009-08-10,70.67,71.57,70.09,70.6,304092.0) = 0.3430000055154837
OHLCV (2009-08-11,70.76,71.25,68.71,69.45,389079.0) = 0.2553752914846883
OHLCV (2009-08-12,69.67,71.13,68.84,70.16,342269.0) = 0.20912342738951795
OHLCV (2009-08-13,70.54,72.21,70.05,70.52,322969.0) = 0.12478816693493407
OHLCV (2009-08-14,70.9,71.6,67.12,67.51,320144.0) = 0.05921487890049628
OHLCV (2009-08-17,68.092,68.108,65.668,67.162,240473.0) = 0.09137187062876645
OHLCV (2009-08-18,67.604,70.966,66.842,69.95,203825.2) = 0.1706468170171508
OHLCV (2009-08-19,71.24,73.706,69.088,73.266,276795.4) = 0.15807704379183338
OHLCV (2009-08-20,73.27,73.832,72.354,72.836,218518.0) = 0.06367936080775419
OHLCV (2009-08-21,72.88,74.72,72.03,73.89,246228.0) = 0.029836815910027837
OHLCV (2009-08-24,73.75,74.81,73.57,74.37,208702.0) = 0.016664909630323244
OHLCV (2009-08-25,73.97,75.0,71.11,72.05,324399.0) = -0.09131804630877267
OHLCV (2009-08-26,71.35,72.64,70.67,71.43,255501.0) = -0.15421733592646605
OHLCV (2009-08-27,71.36,72.95,69.83,72.49,272730.0) = -0.05724797018992386
OHLCV (2009-08-28,72.86,73.52,71.78,72.74,239217.0) = -0.027319918804055918
OHLCV (2009-08-31,71.0,73.36,69.13,69.96,276967.0) = -0.02971187021316551
OHLCV (2009-09-01,69.85,71.37,68.0,68.05,336835.0) = -0.13104300625576917
OHLCV (2009-09-02,67.7,68.8,67.05,68.05,269497.0) = -0.07307013949296379
OHLCV (2009-09-03,68.15,69.4,67.66,67.96,231967.0) = -0.04364389804917693
OHLCV (2009-09-04,68.19,69.7,67.12,68.02,229782.0) = -0.07815926995381965
OHLCV (2009-09-08,67.87,71.79,67.54,71.1,374237.0) = -0.03491870905524156
OHLCV (2009-09-09,71.33,72.52,70.66,71.31,331984.0) = -0.1193073608314838
OHLCV (2009-09-10,71.64,72.44,70.86,71.94,345551.0) = -0.06402858563910101
OHLCV (2009-09-11,72.05,72.9,68.82,69.29,374693.0) = -0.15597754147030543
OHLCV (2009-09-14,69.15,69.51,68.02,68.86,255720.0) = -0.16099044740486634
OHLCV (2009-09-15,68.78,71.19,68.48,70.93,288040.0) = -0.06435466718150126
OHLCV (2009-09-16,70.4,72.56,70.14,72.51,291946.0) = 0.018329714593047497
OHLCV (2009-09-17,72.39,73.244,71.754,72.564,218096.4) = -0.02405637934557706
OHLCV (2009-09-18,72.588,72.844,71.446,72.22,150988.4) = -0.02673941749135954
OHLCV (2009-09-21,72.038,72.47,69.146,69.842,230410.4) = -0.018314011385064156
OHLCV (2009-09-22,69.75,71.994,69.714,71.718,203204.2) = 0.10770951461483665
OHLCV (2009-09-23,71.63,71.81,68.04,68.97,307578.0) = 0.05595685854020825
OHLCV (2009-09-24,68.33,68.77,65.6,65.89,357456.0) = 0.018808071518345366
OHLCV (2009-09-25,65.92,67.09,65.05,66.02,315319.0) = 0.03176245544810096
OHLCV (2009-09-28,66.15,67.54,65.41,66.84,231410.0) = -0.011511974070428305
OHLCV (2009-09-29,67.11,67.33,65.82,66.71,247345.0) = 0.02599828305730066
OHLCV (2009-09-30,66.71,70.72,66.22,70.61,247345.0) = 0.05582928088157199
OHLCV (2009-10-01,70.4,71.39,69.13,70.82,312014.0) = 0.17792607653258943
OHLCV (2009-10-02,70.35,70.69,68.32,69.95,334690.0) = 0.19907950136491115
OHLCV (2009-10-05,69.81,71.0,68.05,70.41,346922.0) = 0.18950322454683916
OHLCV (2009-10-06,70.26,71.97,70.06,70.88,346922.0) = 0.10135569628253552
OHLCV (2009-10-07,71.16,71.76,68.88,69.57,346922.0) = 0.047875011471094436
OHLCV (2009-10-08,69.8,72.55,69.17,71.69,405214.0) = 0.08818895297813964
OHLCV (2009-10-09,71.42,72.35,70.62,71.77,322276.0) = 0.14183595255442472
OHLCV (2009-10-12,72.24,73.84,72.05,73.27,260226.0) = 0.12640801334189591
OHLCV (2009-10-13,73.17,74.55,72.83,74.15,361151.0) = 0.20357013684551375
OHLCV (2009-10-14,74.4,75.53,74.4,75.18,296006.0) = 0.298957767007501
OHLCV (2009-10-15,75.444,78.066,74.886,77.68,333149.4) = 0.35870782447838956
OHLCV (2009-10-16,77.96,78.934,77.024,78.726,228763.0) = 0.3816240694953711
OHLCV (2009-10-19,78.896,79.906,78.29,79.82,206086.4) = 0.41742919799823125
OHLCV (2009-10-20,79.906,80.33,78.266,79.114,282864.4) = 0.3488692018862402
OHLCV (2009-10-21,78.69,82.0,77.64,81.37,395742.0) = 0.37070513245476655
OHLCV (2009-10-22,81.04,81.5,79.86,81.19,295407.0) = 0.3871034158965728
OHLCV (2009-10-23,80.55,80.55,80.5,80.5,293751.0) = 0.2770739947385201
OHLCV (2009-10-26,79.65,81.58,77.97,78.68,363907.0) = 0.23689872515571944
OHLCV (2009-10-27,78.68,79.89,77.81,79.55,375672.0) = 0.3334401462984261
OHLCV (2009-10-28,79.47,79.83,77.06,77.46,359438.0) = 0.23299845739935804
OHLCV (2009-10-29,78.75,80.46,77.03,79.87,360575.0) = 0.2605146513585216
OHLCV (2009-10-30,79.98,80.21,76.85,77.0,412394.0) = 0.1488561521168257
OHLCV (2009-11-02,77.02,78.66,76.56,78.13,371006.0) = 0.1464725384508522
OHLCV (2009-11-03,78.09,79.77,76.55,79.6,373992.0) = 0.19170171032153083
OHLCV (2009-11-04,79.47,81.06,79.12,80.4,366103.0) = 0.16148490840310584
OHLCV (2009-11-05,80.29,80.52,79.34,79.62,257603.0) = 0.09383332871383991
OHLCV (2009-11-06,79.8,80.34,76.71,77.43,379374.0) = 0.006004929778111053
OHLCV (2009-11-09,79.2,80.19,77.77,79.43,327402.0) = 0.04086179498571751
OHLCV (2009-11-10,79.24,80.51,77.89,79.05,371088.0) = -0.024924416253529445
OHLCV (2009-11-11,78.88,80.1,78.57,79.28,297815.0) = -0.06669126958008954
OHLCV (2009-11-12,79.25,79.69,76.52,76.94,412833.0) = -0.06703844927129654
OHLCV (2009-11-13,76.78,77.67,75.57,76.35,335366.0) = -0.04051931299979889
OHLCV (2009-11-16,76.58,79.43,76.35,78.9,361387.0) = -0.0438125705247634
OHLCV (2009-11-17,79.04,79.85,78.262,79.256,284090.6) = 0.02213845512138068
OHLCV (2009-11-18,79.576,80.55,78.894,79.788,227374.8) = -0.022956480723686137
OHLCV (2009-11-19,79.948,80.188,77.39,77.814,256538.4) = 0.01884533032404186
OHLCV (2009-11-20,78.246,78.486,76.648,77.32,245480.6) = -0.03616446626118428
OHLCV (2009-11-23,77.8,79.92,77.15,77.56,382888.0) = -0.1701659135785275
OHLCV (2009-11-24,77.45,77.8,75.6,76.02,413033.0) = -0.2502018785264089
OHLCV (2009-11-25,75.83,78.09,75.5,77.96,337389.0) = -0.15114590142246725
OHLCV (2009-11-27,77.29,77.94,72.39,76.05,301347.0) = -0.08237381118991073
OHLCV (2009-11-30,76.05,78.0,75.13,77.28,358538.0) = -0.06940851073485638
OHLCV (2009-12-01,77.35,79.04,77.01,78.37,310483.0) = -0.03762243384726115
OHLCV (2009-12-02,77.9,78.59,76.22,76.6,340897.0) = -0.08327996954884716
OHLCV (2009-12-03,76.51,77.5,75.54,76.46,351788.0) = -0.02185519800618399
OHLCV (2009-12-04,75.83,77.9,74.85,75.47,411579.0) = -0.05597090074835923
OHLCV (2009-12-07,75.8,76.1,73.7,73.93,359248.0) = -0.1711341629610336
OHLCV (2009-12-08,74.0,74.39,72.51,72.62,424771.0) = -0.2606313297294129
OHLCV (2009-12-09,73.12,73.87,70.13,70.67,526968.0) = -0.32333584820418504
OHLCV (2009-12-10,70.8,71.39,69.81,70.54,407657.0) = -0.2853067271206263
OHLCV (2009-12-11,70.57,71.2,69.46,69.87,407657.0) = -0.30467120751900023
OHLCV (2009-12-14,69.63,70.22,68.59,69.51,268931.0) = -0.2530513864565499
OHLCV (2009-12-15,69.57,71.15,69.31,70.69,262945.0) = -0.1842528869859971
OHLCV (2009-12-16,70.78,73.55,70.59,72.66,298377.0) = -0.2223672241951744
OHLCV (2009-12-17,73.094,73.498,71.55,72.936,181961.4) = -0.23166796967695447
OHLCV (2009-12-18,73.072,75.074,72.95,73.784,185160.6) = -0.28623514377774434
OHLCV (2009-12-21,73.574,74.224,72.802,73.22,162567.2) = -0.3330416415738343
OHLCV (2009-12-22,73.214,74.468,72.626,74.03,182012.2) = -0.2711868192700353
OHLCV (2009-12-23,74.52,77.0,74.25,76.67,196830.0) = -0.24099827474082605
OHLCV (2009-12-24,76.59,78.25,76.19,78.05,102484.0) = -0.17739728171088276
OHLCV (2009-12-28,77.92,79.12,77.76,78.77,108895.0) = -0.0970074785758427
OHLCV (2009-12-29,78.66,79.39,78.02,78.87,137090.0) = 0.013846669687822978
OHLCV (2009-12-30,78.8,79.8,78.46,79.28,137090.0) = 0.1490216816445053
OHLCV (2009-12-31,79.28,80.0,79.16,79.36,120372.0) = 0.15291686129042834
OHLCV (2010-01-04,79.63,81.79,79.63,81.51,263542.0) = 0.3188501358860866
OHLCV (2010-01-05,81.77,81.77,81.77,81.77,258887.0) = NaN
OHLCV (2010-01-06,81.43,83.52,80.85,83.18,370059.0) = NaN
OHLCV (2010-01-07,83.2,83.36,82.26,82.66,246632.0) = NaN
OHLCV (2010-01-08,82.65,83.47,81.8,82.75,310377.0) = NaN
OHLCV (2010-01-11,82.88,83.95,81.96,82.52,296304.0) = NaN
OHLCV (2010-01-12,82.07,82.34,79.91,80.79,333866.0) = NaN
OHLCV (2010-01-13,80.06,80.67,78.37,79.65,401627.0) = NaN
OHLCV (2010-01-14,79.698,80.438,79.0,79.488,364670.6) = NaN
OHLCV (2010-01-15,79.2,79.31,77.7,78.0,200555.0) = NaN
OHLCV (2010-01-19,78.066,79.342,76.94,79.2,285417.6) = NaN
OHLCV (2010-01-20,79.112,79.294,77.208,77.716,280382.8) = NaN
OHLCV (2010-01-21,77.56,78.36,75.66,76.08,327417.0) = NaN
OHLCV (2010-01-22,75.84,76.5,74.01,74.54,348819.0) = NaN
OHLCV (2010-01-25,74.24,75.42,74.06,75.26,280559.0) = NaN
OHLCV (2010-01-26,75.28,75.39,73.82,74.71,256207.0) = -0.05509931939336778
OHLCV (2010-01-27,74.69,75.09,72.65,73.67,356179.0) = -0.13319806672710813
OHLCV (2010-01-28,73.75,74.49,72.93,73.64,292911.0) = -0.12232436746026415
OHLCV (2010-01-29,73.89,74.82,72.43,72.89,335270.0) = -0.178724177217225
OHLCV (2010-02-01,72.84,74.99,72.49,74.43,277411.0) = -0.11438983255247308
OHLCV (2010-02-02,74.94,77.41,74.4,77.23,366269.0) = -0.018767503358198875

Explanation with this sequence:

OHLCV (2009-05-22,61.67,61.67,61.67,61.67,186302.0) = NaN
OHLCV (2009-05-26,59.8,62.45,59.8,62.45,267127.0) = NaN
OHLCV (2009-05-27,63.0,63.45,62.85,63.45,261888.0) = NaN
OHLCV (2009-05-28,63.56,65.35,63.56,65.08,281439.0) = NaN
OHLCV (2009-05-29,65.68,66.31,65.4,66.31,261370.0) = NaN
OHLCV (2009-06-01,67.73,68.58,67.73,68.58,234080.0) = NaN
OHLCV (2009-06-02,68.55,68.65,68.35,68.55,266861.0) = NaN
OHLCV (2009-06-03,67.8,67.8,65.45,66.12,322365.0) = NaN
OHLCV (2009-06-04,67.65,69.25,67.65,68.81,304674.0) = NaN
OHLCV (2009-06-05,68.49,69.05,68.02,68.44,329259.0) = NaN
OHLCV (2009-06-08,67.95,68.88,67.95,68.09,289278.0) = NaN
OHLCV (2009-06-09,69.67,70.01,69.1,70.01,316884.0) = NaN
OHLCV (2009-06-10,70.9,71.55,70.55,71.33,346248.0) = NaN
OHLCV (2009-06-11,72.14,72.92,72.14,72.68,314790.0) = NaN

On first tick (2009-05-22) you have the max price which is equal to the min price. The CloseLocationValueIndicator formula has a division by (maxPrice-minPrice). It gives (61.67 - 61.67) == 0, which turns into a division by zero.
=> Here comes a first NaN.
Then all derived calculations return NaN (because NaN + XXX - YYY * ZZZ / ... == NaN). And specifically:

The current Chaikin calculation
The next 13 Chaikin calculation (because you asked for Chaikin(14), which means that Chaikin(n) needs Chaikin(n-13), Chaikin(n-12), Chaikin(n-11), ... to be calculated)

Same explanation for the other NaN sequence.


Beetroot seed recipe conflicts with vanilla red dye recipe

Should the beetroot seed recipe be rolled back so as to not conflict with the vanilla recipe? Or override vanilla, since there are other materials that can be used to make red dye.

I'd like to replace the vanilla recipe while providing an alternate route from beetroot to red dye. I haven't decided on that alternate dye recipe but I'm open to ideas.

Smelting beetroot? Works for cactus.

I don't see why not. I'll get on it after my finals.


DataVirtualHardDisk: support source_media_link and init args

Hi, I needed DataVirtualHardDisk source_media_link for testing and this seemed to work for my purposes. Did NOT run tests...

Rebased and fixed the backward-compatibility breaking change (lun/logical_disk_size_in_gb now default to 0). Is None ok as a default for the other values, or do they need to be explicitly u''?

Oops, could have used immutable 0 directly as the default arg values. Can change that still, let me know if you want it that way. (Too paranoid about default values other than None after screwing it up with mutable [] and {})

Yeah, I've been lucky enough to be warned early on to never use [] and {} as default parameter values, so I never experienced that pain :)
There's a difference between u'' and None when it comes to serializing to xml.  None means the xml element won't appear at all, u'' means it will appear and be empty.  As far as deserializing, there's no difference.
It may be that None is more convenient for the user (opt in), otherwise you have to explicitly set the values you don't want to None, which isn't as obvious.
Changing that default from u'' to None has potential to break existing code though.  I would prefer you don't change any of them from what they used to be.  For the new one you are introducing, you can make that one None, in fact I think you have to, to avoid breaking existing code that doesn't know about that new field.

Default values now exactly same as before.


Trying to convert: RuntTimeError: MetaGraphDef associated with tags {'serve'} could not be found in SavedModel.

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): anaconda installation
TensorFlow version (or github SHA if from source): 1.15

The output from the converter invocation
MetaGraphDef associated with tags {'serve'} could not be found in SavedModel.

Also, please include a link to the saved model or GraphDef
https://drive.google.com/open?id=1fI36hxl9vbIY9KL4Tjvv7HIIBJvYIfW5

Any other info / logs
When I try to convert this is the error I get, so I cannot successfully convert to Lite.

@csongornagy, Can you please share a standalone code to reproduce the issue? Thanks!

@csongornagy, Can you please share a standalone code to reproduce the issue? Thanks!
Yeah, so this is the code I am using, the official code from the tensorflow website:
https://www.tensorflow.org/lite/guide/get_started
(I have also tried the quntized version of the code, still the same error)

import tensorflow as tf

converter = tf.lite.TFLiteConverter.from_saved_model(saved_model_dir)
tflite_model = converter.convert()
open("converted_model.tflite", "wb").write(tflite_model)

I am also getting the same error during TFlite conversion. Any update on this ?

@raghavgurbaxani No unfortunately I have not been able to resolve issue, and have not received any further updates from tensorflow either.
@jvishnuvardhan Any response?

@csongornagy Is this a frozen graph file? If it is frozen graph, then you need to provide 'input_arrays' and 'output_arrays'. Do you have access to model creation code? Can you provide 'input_arrays' and 'output_arrays'. Thanks!

@jvishnuvardhan
using the frozen .pb file from here - https://github.com/argman/EAST/issues/296
but I get the following error. -
RuntimeError: MetaGraphDef associated with tags {'serve'} could not be found in SavedModel. To inspect available tag-sets in the SavedModel, please use the SavedModel CLI: `saved_model_cli`
available_tags: [set()]

looks like the tag set is empty.

@csongornagy Is this a frozen graph file? If it is frozen graph, then you need to provide 'input_arrays' and 'output_arrays'. Do you have access to model creation code? Can you provide 'input_arrays' and 'output_arrays'. Thanks!

@jvishnuvardhan
Thanks for the reply! Yes it is a frozen graph model! I don't know how I can acquire the input and output arrays as you said. Where could I get these from? or How? This the code use to export the model:
import re
import numpy as np

output_directory = './fine_tuned_model'

lst = os.listdir(model_dir)
lst = [l for l in lst if 'model.ckpt-' in l and '.meta' in l]
steps=np.array([int(re.findall('\d+', l)[0]) for l in lst])
last_model = lst[steps.argmax()].replace('.meta', '')

last_model_path = os.path.join(model_dir, last_model)
print(last_model_path)
!python /content/models/research/object_detection/export_inference_graph.py \
    --input_type=image_tensor \
    --pipeline_config_path={pipeline_fname} \
    --output_directory={output_directory} \
    --trained_checkpoint_prefix={last_model_path}

Any updates on this issue?

Any updates on this issue?

Hi There,
We are checking to see if you still need help on this, as you are using an older version of tensorflow which is officially considered end of life . We recommend that you upgrade to the latest 2.x version and let us know if the issue still persists in newer versions. Please open a new issue for any help you need against 2.x, and we will get you the right help.
This issue will be closed automatically 7 days from now. If you still need help with this issue, please provide us with more information.


Add automerge bot

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/libblitz-feedstock#14.


Ammonite REPL embedded in SBT should not alter how tests are run

Currently the instructions for using Ammonite with SBT instructs the user to add Ammonite to the libraryDependencies scoped to the test configuration.  Since this changes the test environment it can alter how tests are run, possibly introducing false positives such as the failures due to https://github.com/lihaoyi/Ammonite/issues/644, but possibly also introducing false positives where code that will fail in production can pass tests.
Would it be better to have the user create a new custom SBT configuration that extends the test configuration and only depend on Ammonite in that config?
Maybe the Ammonite dependency for SBT could be just a very thin front-end and the internal dependencies are resolved internally instead of through SBT's dependency management?
If SBT keeps the dependencies of it's plugins separate from the dependencies used for configurations, maybe this is additional rationale to pursue https://github.com/lihaoyi/Ammonite/issues/24.

That's roughly what sbt-ammonite does. I don't use it much (I tend to use in-browser notebooks now...), so I tend to only update it when I receive PRs. There was some discussion to add it to the repo of Ammonite.

Duplicate of https://github.com/lihaoyi/Ammonite/issues/24


Re-deploy PROD VPVC  Pilot invitation to use CANdy PROD

Register new agent
Update genesis transaction

I think Wade Barnes might be working on this currently


[Snyk] Upgrade org.apache.pdfbox:pdfbox from 2.0.28 to 2.0.29

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade org.apache.pdfbox:pdfbox from 2.0.28 to 2.0.29.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2023-06-28.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Utdatert


[mnist]:Delete the unused domain names

Delete the unused domain names of ps and worker.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please.

LGTM.

Merged. Thanks.


Get-FabricInfo should report the timestamp from the packets

This was not closed with 8710191. This is still open

This was not closed with 8710191. This is still open


[bug] no img | and long space bug on /blog

Hi @Mehmetali345Dev,
There is 2 bugs on your /blog page.
I Just Wanted to Let You Know!
https://i.imgur.com/AZPXPXl.png
See ya!

Fixed with last 2 commits.


README: Proofreading, markup [ci skip]

This PR is a documentation polishing change.
Language, markup, formatting.

This PR is a documentation polishing change by olleolleolle.
Language, markup, formatting.

Oh, did you change your mind about merging the changes?

No !  I'be probably made a mistake....

Much better now :-)


Unable to Capture Event Data after few minutes later

Library Version: TikTokLive 5.0.8
Issue:  After approximately 10-20 minutes of using the TikTok Live package, I encounter an issue where I am unable to capture event data using the await start() function. This behavior is unexpected and affects the functionality of the library.
Would appreciate if a prompt response is received.
Thanks in advance.

Duplicate of https://github.com/isaackogan/TikTokLive/issues/137


Member self onboarding

Originally created by Tom Smyth at 2016-05-22 18:07, migrated from redmine-#4565

Priority changed from ? to 3

By Tom Smyth at 2017-01-19 18:16

Tags set to people

By Tom Smyth at 2017-04-28 13:17


Using utility functions

G'day! I had a peek through the code and notice a number of places which might benefit from util functions, and a number of places which might benefit from adding a util function upstream to IfcOpenShell :)
Have you seen https://github.com/IfcOpenShell/IfcOpenShell/blob/v0.8.0/src/ifcopenshell-python/ifcopenshell/util/geolocation.py ? In particular there are quite a few goodies in the latest version.
Some you might enjoy:

get_true_north
get_helmert_transformation_parameters
auto_local2global or auto_xyz2enh

These take into account the IFC2X3 fallback, as well as the new coordinate operations in IFC4X3. They also handle a few more situations that might be problematic (e.g. I saw a few instances of by_type("IfcGeometricRepresentationContext")[0] which might get a subcontext or non-Model/Plan context).

Hi Dion,
Thanks for recommending the libraries. I'll take a look at them.


Support for voip notification

Doe this support Pushkit for iOS?

No it doesn't. See https://stackoverflow.com/questions/37326450/does-firebase-cloud-messaging-support-voip-pushkit-services for a related discussion.

Any updates?

It's not something we are actively working on. If you have a specific use case, please file a feature request with Firebase Support.

@hiranya911 It's really important thing, I don't know why FCM still does not support APNS VOIP messages.

It's a product decision, and this repo is not the right place to have those discussions. I suggest you reach out to Firebase Support and file a feature request with them: https://firebase.google.com/support

This is crucial requirement in order to implement custom notification handling, such as:
custom notification view, decision whether to show notifications to the user, save the notification content into some local db and enjoy fast app loading (with all the data already prepared, instead of fetching it from the server on login), etc.
For example, whatsapp/telegram are using the voip notifications to handle their push notifications customization (as explained above).
https://stackoverflow.com/questions/60815763/how-does-the-whatsapp-web-client-still-work-with-the-latest-ios-update-sdk-vers
With the remote notifications the above is not possible and with background notifications it is not guaranteed to be received...

notice however, that it seems that whatsapp/telegram are using some special entitlement for that:
com.apple.developer.pushkit.unrestricted-voip

Any update about that???

Any update? any plans in supporting PushKit in Firebase?

Any update? It would've been very cool to use a single SDK for both types of pushes, rather than using FCM and APNs through SNS or OneSignal for example


Fix NamespaceId and MosaicId hash algorithm resolution

Added

Added networkType parameter for NamespaceId and MosaicId constructors
Added keccak unit tests

Fixed

Fixed IdGenerator with mosaicId and namespaceId static method now resolving hash algorithm from networkType parameters, defaulted to NetworkType.MIJIN_TEST
Fixed IdGenerator.generateNamespacePath to forward networkType parameter

Changed

generateNamespaceId method now added to IdGenerator.

Pull Request Test Coverage Report for Build 826

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 821:
0.0%

Covered Lines:
10

Relevant Lines:
10

💛  - Coveralls

default networkType removed; PR should be good to fix namespaceId hash and mosaicId hash generation on keccak using network type to resolve signature schema.

@evias @rg911
So finally NamespaceId name resolution depends on the hash algorithm/network type?
I have this PR on hold:
https://github.com/nemtech/nem2-sdk-java/pull/165
Should I pick it up?

closed not merged.


Duplication glitch

Enigmatic 6 developer build mod version:- 1.9.5
Block:- Crafting Terminal
Steps to reproduce:

Place a recipe in and request request items,
Ask another player to also enter the terminal.
Both players take out the item at around the same time(Seems to be quite lenient)
Profit, you have two of the items for free!

This issue is already fixed in the 1.18 version of the mod. The 1.16 version is not supported anymore, unfortunately.

This is a pretty bad dupe bug tbf, could you please make an exception and backport the fix?

For anyone who is still in 1.16, please try to reproduce this issue using this build. Thanks!

Hello,
The provided build sadly still has this issue.
PrettyPipes-<IP_ADDRESS> with Forge forge-1.16.5-36.2.23.

What aboooout this build?

This build has fixed the issue. Thank you so much!

Yay! I shall release this version soon.

Thanks a bunch Ell <3


feat: introduce structured data to opportunity and suggestions

Introduce the new opportunity and suggestions data model for the structured data audit

:tada: This PR is included in version 1.44.0 :tada:
The release is available on:

v1.44.0
GitHub release

Your semantic-release bot :package::rocket:


Last explicit nullable param (PHP 8.4 compatibility)

I forgot another one when I did #903

Thanks!

All good, my PHP 8.4 tests run successfully.


feat: redesign number input for input range

Fixes Issue
My PR closes #509
👨💻 Changes proposed(What did you do ?)
Updated style.css to make the number inputs for the input range match the design of the rest of the page.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

not complete, you missed for focus according to the issue description:

not complete, you missed for focus according to the issue description:

Fixed it, thanks for pointing it out.

lol just realized you were never assigned


Django 1.8 compatible

Thanks!

So fast! Would you like to release a new tag?

Good suggestion!
Done!

Thank you!


Hide properties from Project browse object

We should hide the majority of these browse objects, and bring it back to what legacy csproj is showing:

We need to add Visible=False on the rules.

Grouping some of them into categories would also be helpful

We're going to cut them back to the same as existing project system - then be very deliberate about what's exposed.

Related https://github.com/dotnet/roslyn-project-system/issues/59

Validate #841 and #814 , when fixing this issue

blocked by CPS bug : 369757


remove xfail after package manager fixed

Pull Request Description
Remove recently added xfail after the package manager was fixed
https://github.com/apple/swift-package-manager/pull/5855
The project is currently upass'ing

@swift-ci test

Closing in favor of https://github.com/apple/swift-source-compat-suite/pull/733. Did not realize that was open


mysensors.py Prevent sensor name mixup

Description:
Change the sensor name schema so nodes are not mixed up. The dot that was present before was ignored by home-assistant.
Before name:  "skeatchname" "node_id""child_id"  eg. wall 107
New name   :  "skeatchname" "node_id" "child_id"  eg. wall 10 7
This will result in a Home Assistant Entity ID of: sensor.wall_10_7
Note. This will brake mysensor sensor name backwards compatibility for thaw’s that already have set up Home Assistant. Fix is to update names in yaml configuration file.
Testing:
Tested OK on deployed platform, Home-Assistant 1.6 (raspberry pi) + MySensors 1.5 (Arduino + NRF24L01)
Not tested using tox
Related issue (if applicable): #
Example entry for configuration.yaml (if applicable):

Checklist:
If code communicates with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

@MartinHjelmare could you review this PR ?

Yes, I'll do it tonight.

I think this is a good fix. I was reflecting if we should clarify the numbers even more by adding "node" and "child" in the name. But I think it's better to have it short and that the sketch name plus node and child numbers should be enough.
As @oeysteinhansen pointed out, this will BREAK existing configs for mysensors entity IDs.

Alrighty, let's merge this 🐬 . When I put up the release notes, please make sure that I don't forget to mention this in the breaking changes!


Bizzare Bazaar

Adds 2 new forms of shopsanity: Gear Shopsanity and Potion Shopsanity. When enabled, you can buy a randomized item (on time only) and then you can buy the vanilla item repeatedly.
All of Rupin's items are available to purchase immediately. Luv's items require a bottle and a pouch (this check had to be added in). For the stamina potion and air potion items, you also need to have raised LMF or obtained the water scale.
The shopsanity patches are now always enabled (except for the potion shop specific ones).
Tests Needed:

Test I didn't break anything with Beedle. I haven't come across anything but 🤷♀
Make sure you can only get each item once and that you can repeatedly get the vanilla item afterwards
Test different combos of shops on and off to make sure they don't interact weirdly

Tested with a full seed playthrough, no issues found

Tested this today on beta-features with full Bazaar as well as full Beedle.  Didn't have any issues with it, no errors that I could see.

One suggestion: it would be very helpful to put the prices into the check names for both the randomizer and the tracker.  Right now, it's impossible to know what the prices are for every check.

I am not currently interested in updating this. If anyone is interested in picking this up is welcome to do so.
Please note that #463 has not been resolved


Ning clients are actually play clients on apidoc.me

the header says ning but the contents are play.

hmm, maybe I was diff'ing the wrong versions as ning is actually in use from what I can see with that client now.  it does use play-json for marshalling, which would have been inconvenient... however the "commons" targets that just popped up seem to null the issue.


Issue With "Context.Position.Seconds"

There seems to be an issue where "Context.Position.Seconds" resets to 0 and starts counting up again after getting to the 60 second mark of playback time.
Using your SimplePlayer.Avalonia project sample, changing the Slider xaml to:
<Slider
    Grid.Column="1"
    IsEnabled="{Binding Context.IsSeekable}"
    Maximum="{Binding Context.Duration.TotalSeconds}"
    Minimum="0"
    Value="{Binding Context.Position.Seconds}" />
the slider resets to 0 and progresses until it hits 60 seconds, then it resets back to 0 again.
The TextBlock code showing the StringFormat "Context.Position" is working properly; it's counting past 60 seconds, adding 1 minute to the formatted "Context.Position".

You have to change
Context.Position.Seconds
to
Context.Position.TotalSeconds
Context.Position is Timepan. Please read the difference between:
Timspan.Seconds
https://learn.microsoft.com/en-us/dotnet/api/system.timespan.seconds?view=net-7.0
AND
Teamspan.TotalSeconds
https://learn.microsoft.com/en-us/dotnet/api/system.timespan.totalseconds?view=net-7.0

I figured it out. Instead of "Context.Position.Seconds", I should be using "Context.Position.TotalSeconds".
Thank you for finding a different way to use MPV in a project.
Using your 'OpenGlVideoView' solves the Airspace issue with MPV that similar projects have where components can't be placed over the MPV video.


Generate URL button broken?

When i try to compare two instances and click generate url, it just generates http://www.ec2instances.info.

AFAIK that button only builds a URL which includes info about the filters applied via dropdowns.
I'd love to clean up this system so that;

It includes information about all the filters and selected rows
The address field in your browser updates automatically using window.history.pushState()

+1 for this feature. I just ran into this too expecting to be able to give my manager a sweet link which would show them the 5 ec2 types i was comparing, but alas the cake was a lie.

Might take a look at this over the weekend. Ideally the URL should update automatically as you change the filters and then you can just copy/paste it.

The highlighted rows are now stored in the URL, but the state of the 'compare' button is not. Started to add it but it got pretty hacky. Would love to rewrite chunks of this in a react.js-based style...
Hope that helps a bit for now!

Nice, ya thats better then nothing, now i can just say hey here's the URL click compare.  Thanks a ton!

So, i'm not sure the purpose of the generate url button? For example this link just takes me to the US East default pricing, it doesn't load the US West data?
http://www.ec2instances.info/?region=us-west-2

Hmm, I may have just broken this... will take a look in a few days.

Just fixed the storing of region, cost rate, and reservation term in the URL.
Compare button state still isn't part of the URL but I don't think it's necessary right now so will close this issue.
Thanks all


Better warnings / info in describe on non-compliant GeoParquet

The new describe is awesome, but if I put in non-compliant geoparquet there's little messaging that I have a file that's not quite right:
 gpq describe taxi.parquet
╭────────────┬────────┬─────────────────────────────────┬────────────┬─────────────╮
│ COLUMN     │ TYPE   │ ANNOTATION                      │ REPETITION │ COMPRESSION │
├────────────┼────────┼─────────────────────────────────┼────────────┼─────────────┤
│ OBJECTID   │ int32  │ int(bitwidth=32, issigned=true) │ 0..1       │ snappy      │
│ Shape_Leng │ double │                                 │ 0..1       │ snappy      │
│ Shape_Area │ double │                                 │ 0..1       │ snappy      │
│ zone       │ binary │ string                          │ 0..1       │ snappy      │
│ LocationID │ int32  │ int(bitwidth=32, issigned=true) │ 0..1       │ snappy      │
│ borough    │ binary │ string                          │ 0..1       │ snappy      │
│ geom       │ binary │                                 │ 0..1       │ snappy      │
├────────────┼────────┼─────────────────────────────────┴────────────┴─────────────┤
│ ROWS       │ 262    │                                                            │
╰────────────┴────────┴────────────────────────────────────────────────────────────╯

If I convert it then I get an additional row:
├──────────┼────────┼────────────┴────────────┴─────────────┴──────────┴────────────────┴────────┴────────┤
│ ROWS     │ 3233   │                                                                                │
│ VERSION  │ 1.0.0  │                                                                                │
╰──────────┴────────┴─────────────────────────────────────────────────────────────────────────────────────╯

I think it'd be nice to try to always put something about the compliance. Like maybe always have VERSION, but if it's not compliant than say non-compliant (might also be nice to call it 'geoparquet version' or something). It could also be nice to say if it's a 'compatible parquet' file, like it's geom and data looks like 4326, and recommend people use gpq convert.

Thanks for reporting these issues.  If you can link to the invalid files, I can see about improving the output.
I did update the table output so it says "GeoParquet Version" now instead of "VERSION".  But this only shows up if the geo metadata is valid.  The describe output also now includes some error messages after the table if the geo metadata is invalid.  See details here https://github.com/planetlabs/gpq/issues/86#issuecomment-1747406665.
The describe command doesn't repeat all of the logic in the validate command, and I'd like to avoid munging the two things together.  I'll make another change to describe that suggests running validate if it looks like you are trying to describe GeoParquet (if there is a "geo" key in the file key/value metadata) but it is not valid.

I added some additional detail to the describe output in #87.  This covers two cases where the input file is not valid GeoParquet: 1) if it is missing the "geo" metadata key and 2) if the command fails to parse the "geo" metadata value.
This doesn't cover all cases of invalid GeoParquet.  For example, the "geo" metadata can match the JSON schema, but the data might be missing the geometry column.  Or the geometry column may not be of the correct physical type.  Or the geometry column could be a group or repeated.  Or the metadata might have a list of geometry types but one of the geometry values might not be in that list.  Or the metadata might have a bbox but one of the geometry values might fall outside that bbox.  These are examples of things that the validate command checks.  The describe command doesn't validate, so it isn't going to catch all these and other cases of invalid GeoParquet.  Hope this makes sense.

Cool, that file I used is:
taxi.parquet.zip (just zipped it so I could upload to github).
And yeah, makes a lot of sense for describe to not repeat the logic as validate. Will try out the new version - I think the one thing I was thinking that I don't immediately see is for describe to just check if there's just not a geo key in the metadata.... And as I was editing this I think you edited your comment to make that clear - pretty sure we're on the same page, will try it out.

With the latest changes, here is the describe output on that file:
# gpq describe taxi.parquet
╭────────────┬────────┬─────────────────────────────────┬────────────┬─────────────╮
│ COLUMN     │ TYPE   │ ANNOTATION                      │ REPETITION │ COMPRESSION │
├────────────┼────────┼─────────────────────────────────┼────────────┼─────────────┤
│ OBJECTID   │ int32  │ int(bitwidth=32, issigned=true) │ 0..1       │ snappy      │
│ Shape_Leng │ double │                                 │ 0..1       │ snappy      │
│ Shape_Area │ double │                                 │ 0..1       │ snappy      │
│ zone       │ binary │ string                          │ 0..1       │ snappy      │
│ LocationID │ int32  │ int(bitwidth=32, issigned=true) │ 0..1       │ snappy      │
│ borough    │ binary │ string                          │ 0..1       │ snappy      │
│ geom       │ binary │                                 │ 0..1       │ snappy      │
├────────────┼────────┴─────────────────────────────────┴────────────┴─────────────┤
│ Rows       │ 262                                                                 │
│ Row Groups │ 1                                                                   │
╰────────────┴─────────────────────────────────────────────────────────────────────╯
 ⚠  Not a valid GeoParquet file (missing the "geo" metadata key). Run convert to try to convert it to GeoParquet.

Then, if you try to run convert on it (but forget the --input-primary-column flag):
# gpq convert taxi.parquet taxi-geo.parquet
gpq: error: expected a geometry column named "geometry", use the --input-primary-column to supply a different primary geometry

When you do include detail about the primary column (convert taxi.parquet taxi-geo.parquet --input-primary-column geom), it appears to succeed.
However, if you then try to validate it:
# gpq validate taxi-geo.parquet

Summary: Passed 16 checks, failed 1 check, 3 checks not run.

 ✓ file must include a "geo" metadata key
 ✓ metadata must be a JSON object
 ✓ metadata must include a "version" string
 ✓ metadata must include a "primary_column" string
 ✓ metadata must include a "columns" object
 ✓ column metadata must include the "primary_column" name
 ✓ column metadata must include a valid "encoding" string
 ✓ column metadata must include a "geometry_types" list
 ✓ optional "crs" must be null or a PROJJSON object
 ✓ optional "orientation" must be a valid string
 ✓ optional "edges" must be a valid string
 ✓ optional "bbox" must be an array of 4 or 6 numbers
 ✓ optional "epoch" must be a number
 ✓ geometry columns must not be grouped
 ✓ geometry columns must be stored using the BYTE_ARRAY parquet type
 ✓ geometry columns must be required or optional, not repeated
 ✗ all geometry values match the "encoding" metadata
   ↳ invalid geometry in column "geom": wkb: invalid data
 ! all geometry types must be included in the "geometry_types" metadata (if not empty)
   ↳ not checked
 ! all polygon geometries must follow the "orientation" metadata (if present)
   ↳ not checked
 ! all geometries must fall within the "bbox" metadata (if present)
   ↳ not checked

The geom column is a byte array, but it looks like it might not be valid WKB.
DuckDB reports this using the original taxi.parquet:
select ST_GeomFromWKB(geom) from 'taxi.parquet';
Error: Invalid Error: Not implemented Error: Geometry type not supported

So convert succeeds because the column is of the expected type (a byte array).  The command tries to be efficient in copying the input column to the output if it decides it doesn't need to do any transform (like reading WKT and writing WKB).  So it doesn't validate the geometry bytes on the way through.
Still stuff to work on, but I'm going to cut a release with the current changes because I think they improve things.

The geom column is a byte array, but it looks like it might not be valid WKB.
DuckDB reports this using the original taxi.parquet:

Ah, interesting. So I made this one with a duckdb call: copy (select * from 'taxi_zones/taxi.fgb') TO 'taxi.parquet' with (format parquet); So I think the binary it wrote out was actually the DuckDB geometry directly into parquet. I think that's new for 0.9.0 in DuckDB - I believe in 0.8.1 it'd put everything in WKB when you read it in, so if you just wrote it out then it'd be WKB. So I was expecting that behavior - was used to writing out geometries 'with (format parquet)' and getting 'compatible' parquets. I also missed that the fgb named it 'geom' instead of 'geometry'.
So this particular wonky file should be 'solved' when DuckDB gets actual GeoParquet output directly.


XGBoostClassifier vectorized output

I was wondering if it is possible to get vectors from XGBoostClassifier estimators. For example if we have trained Classifier with 3 estimators and each has 4 leaf nodes, then each would produce vector of size 4 on a given recod:
[0 0 1 0] + [0 1 0 0] + [1 0 0 1]
Where 1 is the leaf node that the train record falls in.

Hi, you can get the index of each leaf node of all trees used for a prediction. Just use the predict method of the booster object (http://xgboost.readthedocs.io/en/latest/python/python_api.html, class xgboost.Booster) with pred_leaf=True.
from sklearn.datasets import load_breast_cancer
from xgboost import XGBClassifier, DMatrix

X = load_breast_cancer().data
y = load_breast_cancer().target

clf = XGBClassifier(n_estimators=3, max_depth=2)
clf.fit(X, y)

booster = clf.booster()
print booster.predict(DMatrix(X[:5]), pred_leaf=True)
>> array([[5, 6, 6],
>>           [6, 6, 6],
>>           [6, 6, 6],
>>           [4, 4, 6],
>>           [5, 6, 6]], dtype=int32)

If you are interested in the leaf node value as well you can use get_dump() and parse the output:
import re
reg_ex = r"(\d+):leaf=([-+]?\d*\.\d+|\d+)"
print ['Tree {}: {}'.format(i, re.findall(reg_ex, tree_str)) for i, tree_str in enumerate(booster.get_dump())]
>> ["Tree 0: [('3', '0.191691'), ('4', '-0.04'), ('5', '0.00952381'), ('6', '-0.19096')]",
>> "Tree 1: [('3', '0.165413'), ('4', '-0.130044'), ('5', '-0.00545294'), ('6', '-0.176956')]",
>> "Tree 2: [('3', '0.154973'), ('4', '-0.106707'), ('5', '0.0589427'), ('6', '-0.158889')]"]


[IOTDB-3029] The prefix path generated by the select into target sequence contains * and ** currently unchecked

See IOTDB-3029 for more detail.

Coverage increased (+0.1%) to 53.843% when pulling 4c87877883deb3232728264e35ab82e39200df8b on iotdb-3029 into eadc582377ea7c71d90e0b807b0329a5accd1bfa on master.


Do not reveal sensitive Data

Allow Passwords to be of Puppet-Datatype Sensitive.
Return Sensitive, if Passwords were provided as Sensitive.

Can be closed, as this is merged by 8d6ee4476e3859e8234548a4c5faf6f3b3c61770


unable to set request headers

I need to use some custom headers when connecting to Kafka. Is there a way i could set them in the ruby kafka client?

@alexandrapersea no. It is a Kafka v<IP_ADDRESS> feature that is not yet implemented.

Thank you!

@alexandrapersea  Now that a bit of time has passed is there any chance you guys might reconsider this ?

It is ready https://github.com/zendesk/ruby-kafka/blob/master/CHANGELOG.md#070

Support record headers (#604).

https://github.com/zendesk/ruby-kafka/pull/604


Text Extractor - Return option to have current keyboard determine what language is selected

Description of the new feature / enhancement
While I appreciate having the option to have the language of the text you are extracting be selected in options, I switch between selecting two languages (English and Japanese) and would prefer some way of having to select a language that didn't involve going to settings every time.
The option for Preferred language could have an extra option, to have it be selected by the current keyboard, in addition to being able to select a single preferred language.
Scenario when this would be used?
This would be useful to those who need to switch between selecting two languages, particularly those with different scripts, without needing to spend the extra time to open the options menu.
I use English text extracting as a copying tool, while as someone with little Japanese experience being able to select Kana and Kanji in order to translate or research is helpful.
Supporting information
No response

You can easily change the language by clicking the right mouse button after turning on the Text Extractor tool; that is, you press Shift + Win + A and then the right mouse button anywhere on the screen, and you have a context menu with a selection of installed languages. I myself thought until recently that it was impossible to quickly change the language.


tmt test import tracebacks

$ cd /tmp/
$ git clone https://src.fedoraproject.org/tests/selinux
Cloning into 'selinux'...
remote: Enumerating objects: 821, done.
remote: Counting objects: 100% (821/821), done.
remote: Compressing objects: 100% (238/238), done.
remote: Total 2820 (delta 707), reused 600 (delta 583), pack-reused 1999
Receiving objects: 100% (2820/2820), 633.92 KiB | 198.00 KiB/s, done.
Resolving deltas: 100% (1647/1647), done.
$ cd selinux/policycoreutils/restorecond_pointer_abuse/
$ tmt test import --nitrate --purpose --makefile -v
Checking the '/tmp/selinux/policycoreutils/restorecond_pointer_abuse' directory.
Makefile found in '/tmp/selinux/policycoreutils/restorecond_pointer_abuse/Makefile'.
task: /CoreOS/policycoreutils/Regression/restorecond_pointer_abuse
summary: Is restorecond flooding logs with blob data messages?
test: ./runtest.sh
framework: beakerlib
contact: Vit Mojzis<EMAIL_ADDRESS>component: policycoreutils
duration: 10m
recommend: git /usr/sbin/restorecond /usr/bin/chcon /usr/sbin/sestatus /usr/bin/systemctl /usr/bin/journalctl
relates: https://bugzilla.redhat.com/show_bug.cgi?id=1626468
Traceback (most recent call last):
  File "/usr/bin/tmt", line 8, in <module>
    tmt.cli.main()
  File "/usr/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/lib/python3.9/site-packages/tmt/cli.py", line 508, in import_
    common, individual = tmt.convert.read(
  File "/usr/lib/python3.9/site-packages/tmt/convert.py", line 349, in read
    build_target_list = target_content("build")
  File "/usr/lib/python3.9/site-packages/tmt/convert.py", line 337, in target_content
    target = re.search(regexp, makefile, re.M).group(1)
AttributeError: 'NoneType' object has no attribute 'group'
$

Following TMT packages are installed on my machine:
tmt-1.9.0-1.20211206173159577165.master.3.g745dcb9.fc33.noarch
tmt-test-convert-1.9.0-1.20211206173159577165.master.3.g745dcb9.fc33.noarch

Makefile is missing build section. AFAIK it is not compulsory to have it there so tmt should cope with that.


Use XML-RPC instead of python pickle/dill

Starting point : https://docs.python.org/3/library/xmlrpc.html
Reasons

Standard for many programming languages
dill/pickle has limitation when import call function from modules, it dumps functions call as reference which can't be called on server.

Not implemented


extend PinotFS impls with listFilesWithMetadata and some bugfix

This PR continues on #9466, adding listFilesWithMetadata for other PinotFS impls, and fix bugs.

Codecov Report

Merging #9478 (bda483a) into master (9f92392) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9478      +/-   ##
============================================
- Coverage     69.90%   69.83%   -0.08%
  Complexity     4750     4750
============================================
  Files          1911     1911
  Lines        101895   101895
  Branches      15456    15456
============================================
- Hits          71228    71155      -73
- Misses        25638    25718      +80
+ Partials       5029     5022       -7

Flag
Coverage Δ

integration1
25.98% <0.00%> (-0.16%)
:arrow_down:

integration2
24.67% <0.00%> (-0.03%)
:arrow_down:

unittests1
67.10% <100.00%> (-0.01%)
:arrow_down:

unittests2
15.54% <0.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pinot/spi/filesystem/FileMetadata.java
90.47% <100.00%> (ø)

.../org/apache/pinot/spi/filesystem/LocalPinotFS.java
82.25% <100.00%> (ø)

...data/manager/realtime/DefaultSegmentCommitter.java
0.00% <0.00%> (-80.00%)
:arrow_down:

...er/api/resources/LLCSegmentCompletionHandlers.java
43.56% <0.00%> (-18.82%)
:arrow_down:

...edicate/BaseDictionaryBasedPredicateEvaluator.java
29.62% <0.00%> (-18.52%)
:arrow_down:

...ache/pinot/core/operator/docidsets/OrDocIdSet.java
86.36% <0.00%> (-13.64%)
:arrow_down:

...data/manager/realtime/SegmentCommitterFactory.java
88.23% <0.00%> (-11.77%)
:arrow_down:

...altime/ServerSegmentCompletionProtocolHandler.java
51.88% <0.00%> (-6.61%)
:arrow_down:

.../filter/predicate/InPredicateEvaluatorFactory.java
77.60% <0.00%> (-4.81%)
:arrow_down:

...lter/predicate/NotInPredicateEvaluatorFactory.java
78.35% <0.00%> (-3.74%)
:arrow_down:

... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Ability to see backlink's descendants when viewing backlinks

Is your feature request related to a problem? Please describe.
if i'm looking at backlinks for foo, i'd like a way to see all descendants like foo.bar, foo.bar.buzz, etc references as well.
Describe the solution you'd like
When viewing the backlinks panel (or #237/window), an ability to see foo (exact backlinks) AND foo.** (exact backlinks + all descendants)
Describe alternatives you've considered
n/a
Additional context
Discord convo: https://discord.com/channels/717965437182410783/749641193322971238/777213399049437255

Is this asking for the same thing as #212?

 I'm triaging issue's this week so will be merging this as a
dup and pushing this back up the prioritization list
On Sat, Nov 14, 2020 at 11:57 PM Daria Vasyukova<EMAIL_ADDRESS>wrote:

Is this asking for the same thing as #212
https://github.com/dendronhq/dendron/issues/212?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dendronhq/dendron/issues/345#issuecomment-727530949,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABPIPULQX6CJ44RG4WKCWDSP6CVDANCNFSM4TVVDNEA
.

closing in favor of #212


how to enable traffic from pod to another pod's port?

/kind feature
Description
I need a bit guidance. I don't get traffic from one pod to another on the same host. How to enable pod to pod traffic within podman?
Steps to reproduce the issue:

I start pod for mqtt, it listens to 1883/tcp:

sudo podman run --name mosquitto \
  --rm -p "9001:9001" -p "1883:1883" \
  -v "/var/lib/containers/exported_volumes/mosquitto-config/mosquitto.conf:/mosquitto/config/mosquitto.conf:Z" \
 -v "/var/lib/containers/exported_volumes/mosquitto-data:/mosquitto/data:Z" \
 -v "/var/lib/containers/exported_volumes/mosquitto-log:/mosquitto/log:Z" \
  --conmon-pidfile  /%t/%n-pid --cidfile /%t/%n-cid \
  eclipse-mosquitto:latest

I start another pod as mqtt client for sending traffic to mqtt broker:

podman run \
   -it \
   -v /home/redhatter/data:/app/data:Z \
   --device=/dev/ttyACM0 \
   -e TZ=Europe/Helsinki \
   -v /run/udev:/run/udev:ro \
   --privileged=true \
   --name z2m
   koenkk/zigbee2mqtt

Describe the results you received:
I've tried both setting the bridge ip for mqtt client and also the host public ip. In either case I don't get connection:
zigbee2mqtt:info  2020-02-24 20:50:42: Connecting to MQTT server at mqtt://<IP_ADDRESS>
zigbee2mqtt:error 2020-02-24 20:51:22: Not connected to MQTT server!

I also tried allowing internal traffic for public ip:
firewall-cmd --permanent --zone=public --add-rich-rule=' rule family="ipv4" source address="<IP_ADDRESS>/16" port protocol="tcp" accept'

here are the relevant network device settings:
    link/ether 00:0d:b9:4b:31:08 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic noprefixroute enp1s0
       valid_lft 84409sec preferred_lft 84409sec
    inet6 fe80::e7bd:5bae:a01e:bfa4/64 scope link noprefixroute
       valid_lft forever preferred_lft forever
5: cni-podman0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether d2:20:02:52:ca:ac brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global cni-podman0
       valid_lft forever preferred_lft forever
    inet6 fe80::d020:2ff:fe52:caac/64 scope link
       valid_lft forever preferred_lft forever
9: vethfb218ddb@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master cni-podman0 state UP group default
    link/ether 2e:e3:bc:ce:91:0c brd ff:ff:ff:ff:ff:ff link-netns cni-041d8968-3756-8188-e622-96223e850187
    inet6 fe80::2ce3:bcff:fece:910c/64 scope link
       valid_lft forever preferred_lft forever

I also got instructed at #podman@freenode to drop the firewall section, and add default gw to bridge config:
{
    "cniVersion": "0.4.0",
    "name": "podman",
    "plugins": [
        {
            "type": "bridge",
            "bridge": "cni-podman0",
            "isGateway": true,
            "isDefaultGateway": true,
            "ipMasq": true,
            "ipam": {
                "type": "host-local",
                "routes": [
                    {
                        "dst": "<IP_ADDRESS>/0"
                    }
                ],
                "ranges": [
                    [
                        {
                            "subnet": "<IP_ADDRESS>/16",
                            "gateway": "<IP_ADDRESS>"
                        }
                    ]
                ]
            }
        },
        {
            "type": "portmap",
            "capabilities": {
                "portMappings": true
            }
        }
    ]
}

Describe the results you expected:
MQTT client to connect to MQTT broker
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
Version:            1.6.4
RemoteAPI Version:  1
Go Version:         go1.12.12
OS/Arch:            linux/amd64

Output of podman info --debug:
debug:                                                                                [7/335]
  compiler: gc
  git commit: ""
  go version: go1.12.12
  podman version: 1.6.4
host:
  BuildahVersion: 1.12.0-dev
  CgroupVersion: v1
  Conmon:
    package: conmon-2.0.6-1.module+el8.1.1+5259+bcdd613a.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.0.6, commit: 6ffbb2ec70dbe5ba56e4bfde946fb04f19dd8bbf'
  Distribution:
    distribution: '"rhel"'
    version: "8.1"
  MemFree:<PHONE_NUMBER>
  MemTotal:<PHONE_NUMBER>
  OCIRuntime:
    name: runc
    package: runc-1.0.0-64.rc9.module+el8.1.1+5259+bcdd613a.x86_64
    path: /usr/bin/runc
    version: 'runc version spec: 1.0.1-dev'
  SwapFree:<PHONE_NUMBER>
  SwapTotal:<PHONE_NUMBER>
  arch: amd64
  cpus: 4
  eventlogger: journald
  hostname: apu.konttikoulu.fi
  kernel: 4.18.0-147.5.1.el8_1.x86_64
  os: linux
  rootless: false
  uptime: 37m 27.94s
registries:
  blocked: null
  insecure: null
  search:
  - registry.access.redhat.com
  - registry.fedoraproject.org
  - registry.centos.org
  - docker.io
store:
  ConfigFile: /etc/containers/storage.conf
  ContainerStore:
    number: 2
  GraphDriverName: overlay
  GraphOptions: {}
  GraphRoot: /var/lib/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 4
  RunRoot: /var/run/containers/storage
  VolumePath: /var/lib/containers/storage/volumes

Package info (e.g. output of rpm -q podman or apt list podman):
podman-1.6.4-2.module+el8.1.1+5363+bf8ff1af.x86_64

Additional environment details (AWS, VirtualBox, physical, etc.):
physical rhel8.1

The request here seems to be to access another pod via ports forwarded to the host with PortMap (that is, hit another pod via the host's IP and a forwarded port).
@mccv1r0 PTAL

On Fedora 30 (my laptop) a quick test for me works fine.  I can connect to the port specified via -p using either the IP address assigned to the LOM device which gets dhcp address from corp network as well as the podman0 Linux bridge.
What is your iptables FORWARD policy?  Actually, to save a few round trips, what are your iptables rules for filter and nat tables?
The value of these sysctl variables will be helpful too:
net.bridge.bridge-nf-call-arptables
net.bridge.bridge-nf-call-ip6tables
net.bridge.bridge-nf-call-iptables

Make sure br_netfilter module is loaded as well

@ikke-t : if possible can you try to insert a rule into firewalld FORWARD chain at the beginning:
sudo iptables -I FORWARD -s <IP_ADDRESS>/16 -j ACCEPT
If the last rule is a REJECT that matches everything, setting the default policy to ACCEPT isn't going to help.

Thanks a lot guys, now it works!
The magic there was that by default, RHEL doesn't load the br_netfilter. Also, one needs to put the bridge ip or host public ip instead of localhost.
I believe localhost is the <IP_ADDRESS> in the pod net namespace, instead the host one. I also removed the above mentioned trial of adding firewalld rich rule for bridge ip range, it is not needed once br_netfilter is loaded.
So all in all, perhaps podman should load br_netfilter to make sure the firewall rules work?
While debugging, I went throught the firewall rules, and otherwise they looked fine. I didn't have the default reject there.

I propose you add br_netfilter loading to podman rpm. As otherwise people will fail a lot with this. I fixed it like this on my system:
echo br_netfilter > /etc/modules-load.d/podman.conf

Seems like a packaging issue as opposed to an upstream issue.
@lsm5 WDYT?

@lsm5 Reping

@lsm5 Reping

I'll add this..

added to rawhide https://koji.fedoraproject.org/koji/taskinfo?taskID=42876942

Can you add it to F32 as well?

Can you add it to F32 as well?

yup, will do

Can you add it to F32 as well?

https://koji.fedoraproject.org/koji/taskinfo?taskID=42891689

I believe this is fixed in the package now.


Fixes #209

Legger inn flow

Flow.org

Coverage decreased (-0.08%) to 40.62% when pulling c202713869bc6b543435b78fe8e97bbdf187e7b7 on bjornreppen:flow into 88f2ab78b650d2e253f9a31548ab4d0f924303a2 on Artsdatabanken:master.


The default output format should be JSON and JUnitXML support can be removed

Initial design required our junitxml be the default output format for test cases, but this requirement has changed and JSON is now the preferred output format. Schema definition is TBD, but we can use our placeholder/generic implementation for now.

In addition, we can remove JUnitXML support.


php8 compatible

Allow mdanter/ecc to be 1.0.0 - 0.5.0 does not allow php8

If you want to use bitwaps with php>8.0 you will run into issues signing a transaction with SplFixedArray as some functions are deprecated now. This PR fixes the issue and allow to sign BTC transactions >php8.0

For information we maintain a fork to be PHP 8 compatible (https://github.com/ProtonMail/bitcoin-php)

@doxadoxa @afk11
Approved, please merge.

I know it's been a while since I've been active, but I'm glad and thankful to see this PR. I'll try review and tag in the coming days so you can keep working.

@afk11 it would be great to have more contributors for this project if you don't have time, or to officially archive it and link a fork


TLS request.remote_addr() returns null

Bug Report
Version
tonic v0.3.1
Platform
Windows 64 bits
Crates
tonic v0.3.1
Description
When using TLS the Request passed to the implementation returns a None object.
Expected behavior: return the remote address.

I can confirm that the error also occurs on Mac OS and Linux with tonic v0.3.1.
This is most likeley due to the fact, that the ConnectionInfo is created at a moment ("transport/server/mod.rs" , line 590) when the state of the TlsStream is not updated and still in the initial Handshaking case. The way the remote_addr function for the TlsStream works at the moment is, that if its state is in the Handshaking case it will return None:
rust impl<T: Connected> Connected for TlsStream<T> { fn remote_addr(&self) -> Option<SocketAddr> {      if let Some((inner, _)) = self.get_ref() {            inner.remote_addr()         } else {             None         }      }
I see no other code where the connection info in the extensions is updated.
A quick and dirty workaround is to save the remote_addr before the handshake ist accepted and pass it to the creation of the TlsStream (Disclaimer I am no expert and don't know if this has any negative impact on security!):
`rust
#[cfg_attr(not(feature = "tls"), allow(unused_variables))]
pub(crate) fn tcp_incoming<IO, IE>(
incoming: impl Stream<Item = Result<IO, IE>>,
server: Server,
) -> impl Stream<Item = Result<ServerIo, crate::Error>>
where
IO: AsyncRead + AsyncWrite + Connected + Unpin + Send + 'static,
IE: Intocrate::Error,
{
async_stream::try_stream! {
futures_util::pin_mut!(incoming);
    while let Some(stream) = incoming.try_next().await? {
        #[cfg(feature = "tls")]
        {
            if let Some(tls) = &server.tls {
                let remote_addr = stream.remote_addr();    // <----------- here
                let io = tls.accept(stream, remote_addr);
                yield ServerIo::new(io);
                continue;
            }
        }

        yield ServerIo::new(stream);
    }
}

}
`

The peer_certs are also in the same situation. You can check it in the "tls-client-auth-server" example. The unary_echo method will never print any peer certs.

I had a little bit more time to look at this. remote_addr and peer_certs can both be fixed if we await the Accept-Future from rustls before we create the connection-info. The accept method could be made async:
    pub(crate) async fn accept<IO>(&self, io: IO) -> Option<TlsStream<IO>>
    where
        IO: AsyncRead + AsyncWrite + Connected + Unpin + Send + 'static,
    {
        let acceptor = RustlsAcceptor::from(self.inner.clone());
        let stream = acceptor.accept(io).await.ok()?;

        Some(TlsStream::new(stream))
    }

and then awaited while incomming:
pub(crate) fn tcp_incoming<IO, IE>(
    incoming: impl Stream<Item = Result<IO, IE>>,
    server: Server,
) -> impl Stream<Item = Result<ServerIo, crate::Error>>
where
    IO: AsyncRead + AsyncWrite + Connected + Unpin + Send + 'static,
    IE: Into<crate::Error>,
{
    async_stream::try_stream! {
        futures_util::pin_mut!(incoming);

        while let Some(stream) = incoming.try_next().await? {
            #[cfg(feature = "tls")]
            {
                if let Some(tls) = &server.tls {
                    if let Some(io) = tls.accept(stream).await {
                        yield ServerIo::new(io);
                    }
                    continue;
                }
            }

            yield ServerIo::new(stream);
        }
    }
}

We then would not need the Handshaking state for the TlsStream.
Is there a reason why the evaluation of the Accept-Future is delayed? When the Tls-Connection can not be validated we dont have to bother to continue, right?

https://github.com/hyperium/hyper/issues/2321

duplicate of https://github.com/hyperium/tonic/issues/325

I will try and get an example out of how to work around this but @thienpow is correct, a lot of this work will depend on what we figure out in hyper. Closing this since its a duplicate.


Loading controller not working properly in the latest nightly

Ionic version:  (check one with "x")
[ ] 1.x
[ x ] 2.x
I'm submitting a ...  (check one with "x")
[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

When you create and dismiss two loading components one after another, the second one is never dismissed, no matter if you use .dismiss() or .dismissAll()
Expected behavior:

The loading component is dismissed properly.
Steps to reproduce:

npm install ionic-angular@nightly

Related code:
    let loading = this.loadingCtrl.create({});

    loading.present();

    loading.dismiss();

    let loading2 = this.loadingCtrl.create({});

    loading2.present();

    loading2.dismiss();

This was working ok on stable 2.1.0
Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
Your system information:

Cordova CLI: 6.4.0
Ionic Framework Version: 2.1.0-201703032024
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v7.7.1
Xcode version: Xcode 8.2.1 Build version 8C1002

Regression introduced by this change:
https://github.com/driftyco/ionic/commit/5a4c6093a72059577544dafe372e06018ee1ed19#diff-4fbdcb4f2c1fdfa3a66827a1377c351bL223


Rename the default branch of this repo from master to main

See https://github.com/ampproject/amphtml/issues/32195 for more details

Thanks for creating this issue, @rsimha ! One of us will take care of it....

No hurry, next week is good. Will leave this to you. 👍

It's next week, and I'm now taking a look at this!
Unfortunately I think I lack the permissions to change the default branch. Looks like I'd do this under the "Settings" menu - which doesn't appear for me.

Is that right? If so, do you have the power to grant me the privileges I'd need?
In any case I was proud to notice that I was the person with the most commits in this subrepo! (Though not, I will note, the most lines of code.)

It's possible you need repo-wide admin access for this. I'm not sure who normally grants this, but I just took care of the branch renaming.

Looks like there's no other CI config to update, so I think this issue can be closed.

Thanks! That was quick ⚡⚡⚡


PhantomJS / Jasmine-Rails doesn't exit when run from command line with bundle exec rake spec:javascript

If I run bundle exec rake spec:javascript RAILS_ENV=test from my command line, phantomJS will never exit if all of the tests pass. The last thing that is printed to the console is "ConsoleReporter finished" from assets\javascripts\jasmine-console-reporter.js. From the code comments, it looks like that was printed as a hook of some sort for PhantomJS to see and subsequently exit.
    /* Print something that signals that testing is over so that headless browsers
     like PhantomJs know when to terminate. */
    this.log("");
    this.log("ConsoleReporter finished");

However, I couldn't find any code that would actually cause PhantomJS to exit. I saw this piece of code in assets\javascripts\jasmine-runner.js that looks like it is waiting for a Phantom call:
  // listen for event from parent page
    page.onCallback = function(data) {
      if (data.event === 'exit') {
        phantom.exit(data.exitCode);
      } else if (data.event === 'writeFile') {
        var fs = require("fs");
        fs.write(data.filename, data.text, 'w');
      } else {
        console.log('unknown event callback: ' + data);
      }
    };

My workaround will be to add this piece of code in the jasmine-console-reporter.js. It seems to work. I will also make a pull request for this, unless you identify something I'm overlooking.
    /* Print something that signals that testing is over so that headless browsers
       like PhantomJs know when to terminate. */
    this.log("");
    this.log("ConsoleReporter finished");
    if (this.status == "success") {
      window.callPhantom({
        event: 'exit',
        exitCode: 0
      });
    } else if (this.status == "fail") {
      window.callPhantom({
        event: 'exit',
        exitCode: 1
      });
    };

Make sure you run as RAILS_ENV=test bundle exec rake spec:javascript. Does that work?

I couldn't run it with RAILS_ENV=test as the first argument so I put it after spec:javascript, but besides that yes that is what I was running.

What version of phantomjs are you on?

I had the same issue after upgrading to phantomjs >2. I fixed it to 1.9.8 for now.
Unfortunately I don't have time right now to check what exact version of phantomjs 2 introduces this problem.

Sorry for the late reply. I am currently on 2.0.0, but I was on 1.9.7 when I first saw this issue. However, for me, this was due to a spec error. Please see #156 for my issue description and 'fix'.
This can probably be closed @searls. I didn't realize it was still open - sorry about that.


Bluetooth: controller: Periodic Advertising Report generation

Added implementation for LE Periodic Advertising Report
event generation.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

@kruithofa please re-review your request should be addressed now.


fixed ui and started authentication

PR includes

Fixed UI
Github Auth Integration
User Profile image and username using GitHub api
Added test cases

The rest of the PR looks good to me but there are a few things to iterate over which are suggested please get them resolved. Some more changes are also needed where at a lot of places we are using any which shall be changed to respective types.

Done in the recent commit.


Question

Hello!!
I am wondering if there is a GUI version of the tool available. If not, are there any plans to release a GUI version in the future?

Nope and nope. As far as I know, nobody has bothered to make a GUI for SabreTools despite many people saying that they would. I have no intent in making a UI for SabreTools myself as a part of this project as I prefer that SabreTools is a scriptable CLI executable instead.


ipywidgets 5.0 breaks AMD/require.js

Offshoot from https://github.com/jupyter-incubator/dashboards_server/issues/194.
If building jupyter-js-widgets as an AMD module to be used by require.js, loading of widgets is broken. See issue referenced above for history. Basically, this change in utils.js seems to introduce a timing issue, such that loading modules aren't handled at the correct time and model changes aren't correctly handled.
I rewrote the web3 example to build jupyter-js-widgets as an AMD module. When reloading the page, the widgets fail to render roughly 50% of the time. Compare to web3 on master, where they render 100% of the time.
I spent some time debugging https://github.com/jupyter-incubator/dashboards_server/issues/194 but was not able to find out where the timing issue lay.
cc @SylvainCorlay @parente

There is a deeper nefarious timing issue going on within ipywidgets. We've run into another issue (https://github.com/jupyter-incubator/dashboards_server/issues/240) where ipywidgets fail to load correctly.  And @SylvainCorlay has seen similar issues.
I was able to reproduce this issue with minimal changes to the web3 example. See this commit: https://github.com/jhpedemonte/ipywidgets/commit/73320ab779945969a581ff3375a26ec3318132ad -- reloading web3 fails to properly render the widgets roughly 50% of the time.

Here's what we know:

There seems to be a timing issue deep in ipywidgets. In the simple case, where require.js isn't used, utils.loadClass() directly loads jupyter-js-widgets code synchronously. In certain situations where require.js is used and jupyter-js-widgets has already been required (i.e. by 3rd party widgets), then it goes down the path of calling window.require (yes, even for jupyter-js-widgets) which means that it is now loaded asynchronously. This seems to result in a timing issue where widgets aren't rendered correctly.

There is nothing inherently wrong with the loadClass() code -- it correctly uses Promises. So the timing issue must be elsewhere, where it expects/assumes that loadClass will return synchronously.

That being said, this line:
if (module_name !== 'jupyter-js-widgets' || window.requirejs.defined('jupyter-js-widgets')) {

is strange and doesn't make sense to me. This means that when jupyter-js-widgets is defined in require.js, it will always call window.require to load it, when going down the else path works just as well (and makes more sense in this case).  Why was that or clause added to this code? What is the purpose?  Removing the 2nd part of the or would alleviate this problem, although it wouldn't be a fix for the timing issue.

Added some logging around comm messages:
Success case:
Starting WebSocket: ws://<IP_ADDRESS>:9500/api/kernels/d71f358d-8bd9-4469-b133-af5dd0032954
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "16c4a8d3149147b4b921a53823c326cb"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 16c4a8d3149147b4b921a53823c326cb
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "80c64f9ff45b438c987b8d86c78293ac"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 80c64f9ff45b438c987b8d86c78293ac
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "d80358493ec94c348ca736f528493336"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id d80358493ec94c348ca736f528493336
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "a9d0b332e98145fcb34d22f8b0426793"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id a9d0b332e98145fcb34d22f8b0426793
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id bbe9c69c24da4200bae0e4ecf6871de9
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "fa1d0a65945f465292719bf7a4a7c334"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id fa1d0a65945f465292719bf7a4a7c334
comm_msg Object {data: Object, comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- handling comm_msg
comm_msg Object {data: Object, comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- handling comm_msg
comm_msg Object {data: Object, comm_id: "fa1d0a65945f465292719bf7a4a7c334"}
-- handling comm_msg
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets

Failure case:
Starting WebSocket: ws://<IP_ADDRESS>:9500/api/kernels/db8f9e6b-0d26-4dd5-a7ab-96b5308c669d
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "03e277ee19a84444894e3e28233d082d"}
-- async -- window.require of jupyter-js-widgets
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "0df5a65659ba4c9a919205aa42d09686"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 03e277ee19a84444894e3e28233d082d
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "3ddd27ee2cd54be19cd5a7ce58f83119"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 0df5a65659ba4c9a919205aa42d09686
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "096e0ab299ae4dcaad82b35f34ec3ba7"}
-- async -- window.require of jupyter-js-widgets
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "7cb420941ee24271a2e840eac496b2a9"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 3ddd27ee2cd54be19cd5a7ce58f83119
comm_open Object {target_module: null, data: Object, target_name: "jupyter.widget", comm_id: "f6c31741c06e4c5f9891ab2fb7c4c1a7"}
-- async -- window.require of jupyter-js-widgets
comm_msg Object {data: Object, comm_id: "7cb420941ee24271a2e840eac496b2a9"}
new_model:  MODEL CREATED for comm_id 096e0ab299ae4dcaad82b35f34ec3ba7
comm_msg Object {data: Object, comm_id: "7cb420941ee24271a2e840eac496b2a9"}
new_model:  MODEL CREATED for comm_id 7cb420941ee24271a2e840eac496b2a9
comm_msg Object {data: Object, comm_id: "f6c31741c06e4c5f9891ab2fb7c4c1a7"}
new_model:  MODEL CREATED for comm_id f6c31741c06e4c5f9891ab2fb7c4c1a7

Notice in the failure case that comm_msg arrive for some IDs before the model has been created. Therefore, those messages aren't handled (notice no instances of handling comm_msg).
We probably need to use promises from comm_open in order to chain incoming comm_msg (for same ID). That way, the comm_open will handle finish being handled (i.e. model created) before any comm_msgs are handled.

Thanks for looking into this! I agree about the promises chaining although
the thing you were pointing to in loadClass looks ok to me.
On May 19, 2016 12:10 PM, "Javier Pedemonte"<EMAIL_ADDRESS>wrote:
Added some logging around comm messages:
Success case:
Starting WebSocket:
ws://<IP_ADDRESS>:9500/api/kernels/d71f358d-8bd9-4469-b133-af5dd0032954
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "16c4a8d3149147b4b921a53823c326cb"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 16c4a8d3149147b4b921a53823c326cb
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "80c64f9ff45b438c987b8d86c78293ac"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 80c64f9ff45b438c987b8d86c78293ac
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "d80358493ec94c348ca736f528493336"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id d80358493ec94c348ca736f528493336
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "a9d0b332e98145fcb34d22f8b0426793"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id a9d0b332e98145fcb34d22f8b0426793
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id bbe9c69c24da4200bae0e4ecf6871de9
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "fa1d0a65945f465292719bf7a4a7c334"}
-- sync -- require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id fa1d0a65945f465292719bf7a4a7c334
comm_msg Object {data: Object, comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- handling comm_msg
comm_msg Object {data: Object, comm_id: "bbe9c69c24da4200bae0e4ecf6871de9"}
-- handling comm_msg
comm_msg Object {data: Object, comm_id: "fa1d0a65945f465292719bf7a4a7c334"}
-- handling comm_msg
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets
-- sync -- require of jupyter-js-widgets
Failure case:
Starting WebSocket:
ws://<IP_ADDRESS>:9500/api/kernels/db8f9e6b-0d26-4dd5-a7ab-96b5308c669d
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "03e277ee19a84444894e3e28233d082d"}
-- async -- window.require of jupyter-js-widgets
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "0df5a65659ba4c9a919205aa42d09686"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 03e277ee19a84444894e3e28233d082d
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "3ddd27ee2cd54be19cd5a7ce58f83119"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 0df5a65659ba4c9a919205aa42d09686
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "096e0ab299ae4dcaad82b35f34ec3ba7"}
-- async -- window.require of jupyter-js-widgets
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "7cb420941ee24271a2e840eac496b2a9"}
-- async -- window.require of jupyter-js-widgets
new_model:  MODEL CREATED for comm_id 3ddd27ee2cd54be19cd5a7ce58f83119
comm_open Object {target_module: null, data: Object, target_name:
"jupyter.widget", comm_id: "f6c31741c06e4c5f9891ab2fb7c4c1a7"}
-- async -- window.require of jupyter-js-widgets
comm_msg Object {data: Object, comm_id: "7cb420941ee24271a2e840eac496b2a9"}
new_model:  MODEL CREATED for comm_id 096e0ab299ae4dcaad82b35f34ec3ba7
comm_msg Object {data: Object, comm_id: "7cb420941ee24271a2e840eac496b2a9"}
new_model:  MODEL CREATED for comm_id 7cb420941ee24271a2e840eac496b2a9
comm_msg Object {data: Object, comm_id: "f6c31741c06e4c5f9891ab2fb7c4c1a7"}
new_model:  MODEL CREATED for comm_id f6c31741c06e4c5f9891ab2fb7c4c1a7
Notice in the failure case that comm_msg arrive for some IDs before the
model has been created. Therefore, those messages aren't handled (notice no
instances of handling comm_msg).
We probably need to use promises from comm_open in order to chain incoming
comm_msg (for same ID). That way, the comm_open will handle finish being
handled (i.e. model created) before any comm_msgs are handled.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/561#issuecomment-220373688

Actually, looks like Kernel in jupyter-js-services is trying to do promise chaining -- see _commPromises. I see a promise being stored in _handleCommOpen for a given ID, but then it is not found when querying in _handleCommMsg. Therefore, the comm msg is handled before model is created.

CommManager.prototype.register_target in the shim calls ManagerBase.prototype.handle_comm_open which creates the model async and returns a promise. However, register_target doesn't do anything with the promise. Neither does Kernel.prototype._handleCommOpen, which is what called register_target.  _handleCommOpen, though, immediately deletes the promise it had and later there is no promise chaining in _handleCommMsg (so msg is handled before model is created).
Not sure how to fix this.

Notebook does things a bit differently: https://github.com/jupyter/notebook/blob/master/notebook/static/services/kernels/comm.js#L78
Notice that the response is actually handled by this line:
return Promise.resolve(response).then(function() {return comm;});

ensuring that promises are chained here and in the comm_msg handler.

Did some surgery on the built index.js from web3. This seems to fix things for me:
--- index.built.js.orig	2016-05-19 12:03:28.000000000 -0500
+++ index.built.js	2016-05-19 12:01:48.000000000 -0500
@@ -37418,30 +37418,31 @@
 	 */
 	CommManager.prototype.register_target = function (target_name, f) {
 	    var handle = this.jsServicesKernel.registerCommTarget(target_name, function(jsServicesComm, msg) {
 	        // Create the comm.
 	        var comm = new Comm(jsServicesComm);

 	        // Call the callback for the comm.
 	        try {
 	            var response = f(comm, msg);
 	        } catch (e) {
 	            comm.close();
 	            var wrapped_error = new utils.WrappedError("Exception opening new comm", e);
 	            console.error(wrapped_error);
 	            return;
 	        }
+	        return response;
 	    });
 	    this.targets[target_name] = handle;
 	};

 	/**
 	 * Unregisters a comm target
 	 * @param  {string} target_name
 	 */
 	CommManager.prototype.unregister_target = function (target_name, f) {
 	    var handle = this.targets[target_name];
 	    handle.dispose();
 	    delete this.targets[target_name];
 	};

@@ -49964,33 +49965,35 @@
 	            console.error('Invalid comm message');
 	            return;
 	        }
 	        var content = msg.content;
 	        var targetName = content.target_name;
 	        var promise = utils.loadClass(content.target_name, content.target_module, this._targetRegistry).then(function (target) {
 	            var comm = new Comm(content.target_name, content.comm_id, _this._sendCommMessage.bind(_this), function () { _this._unregisterComm(content.comm_id); });
 	            try {
 	                var response = target(comm, msg);
 	            }
 	            catch (e) {
 	                comm.close();
 	                console.error("Exception opening new comm");
 	                throw (e);
 	            }
-	            _this._commPromises.delete(comm.commId);
-	            _this._comms.set(comm.commId, comm);
-	            return comm;
+	            return Promise.resolve(response).then(function() {
+		            _this._commPromises.delete(comm.commId);
+		            _this._comms.set(comm.commId, comm);
+		            return comm;
+		        });
 	        });
 	        this._commPromises.set(content.comm_id, promise);
 	    };
 	    /**
 	     * Handle 'comm_close' kernel message.
 	     */
 	    Kernel.prototype._handleCommClose = function (msg) {
 	        var _this = this;
 	        if (!validate.validateCommMessage(msg)) {
 	            console.error('Invalid comm message');
 	            return;
 	        }
 	        var content = msg.content;
 	        var promise = this._commPromises.get(content.comm_id);
 	        if (!promise) {

The first patch is to services-shim.js, to have it pass back the promise.  The 2nd part is to make the handlers in jupyter-js-services be more like those in the Notebook and actually take into account the response.

Created 2 PRs (see links above) which fix both scenarios I created (one & two).

These PRs also fix jupyter-incubator/dashboards_server#240.


Keys not getting deleted from AWS redis which is creating memory issue

Hello,
I'm using Redisson with two Tomcat, each one in a virtual instance behind a Load Balancer on AWS.
Everything works great, both Tomcat can create and store session on Redis (I can easily see keys/values serialized on Redis) and both can retrieve the stored session correctly.
My issue/question is: should Tomcat be able to delete keys automatically from Redis when the session invalidated? I'm sure that Tomcat is destroying/invalidating the session internally, but keys keep staying on Redis. Why are keys from redis are not getting deleted and freeing the memory ?
Because of this behaviour, we are getting memory issue/alert from Redis.
Can you tell me what can I do to remove/delete expired session keys from Redis?
Thanks.
Moksha

Did you set session-timeout in tomcat configuration?


Improve Java OSSRH pipeline with sonarqube publish and optional ws clean

Description
This patch adds some improvements and fixes from the build gradle plugin pipeline. I fixed the default values for platform in the same way we fixed it for buildGradlePlugin in commit d88125bc. I also copied the setup for the sonarqube publish. As a last improvement I also added a new parameter CLEAN_WORKSPACE for both buildGradlePlugin, buildJavaLibraryOSSRHandbuildWDKAutoSwitch`
The idea is to make the cleanup controlable during invocation of the pipeline. The default value is true.
Changes

 config.platform default value lookup
 sonarqube publish setup in buildJavaLibraryOSSRH
 cleanup workspace with pipeline parameter

@Joaquimmnetto how would I setup a test for these changes? Can this already be tested?

@Joaquimmnetto how would I setup a test for these changes? Can this already be tested?
Yeah, it is quite possible. You can mock the clearWs function and see if it is running or not when passing the CLEAN_WORKSPACE variable.

I'll salvage this and adapt to the new code struture.

Closing this PR as it is redundant given the last months refactor and new features.


Feature/convert

Status
READY
Description
Added:

DEG (degrees) Math.toDegrees(double angRad)
RAD (radians) Math.toRadians(double angDeg)
ABS (absolute) Math.abs(double a)

Todos
TESTS

[x] DEG
[x] RAD
[x] ABS

Steps to Test
javac CalculateAction.java
java Calculate deg/rad/abs <number_to_test>

Okay, seems all good for me here.

Also in your documentation, README.md... It lacks this
Requirements

JDK 8

Yes, I agree with @stevenJhonGil. Your README.md is missing the requirements specs. Please update it and this branch is ready to merge.


Black

Use  Black Code style

Codecov Report
Base: 94.22% // Head: 94.41% // Increases project coverage by +0.19% :tada:

Coverage data is based on head (e277cb9) compared to base (6a463a8).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   94.22%   94.41%   +0.19%
==========================================
  Files          21       23       +2
  Lines         762      896     +134
==========================================
+ Hits          718      846     +128
- Misses         44       50       +6

Impacted Files
Coverage Δ

qualle/interface/cli.py
54.73% <58.82%> (+1.65%)
:arrow_up:

qualle/models.py
97.22% <94.73%> (-2.78%)
:arrow_down:

qualle/interface/config.py
100.00% <100.00%> (ø)

qualle/interface/data/annif.py
100.00% <100.00%> (ø)

qualle/interface/data/tsv.py
100.00% <100.00%> (ø)

qualle/interface/internal.py
100.00% <100.00%> (ø)

qualle/utils.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Doc: data and bodies are now in resources dir

According to https://gatling.io/docs/current/migration_guides/2.3-to-3.0/
and https://gatling.io/docs/current/session/feeder/

Thanks!
cherry-picked