math/rand NewSource Method memory overflow

Go version
go version go1.19.1 darwin/amd64
Output of go env in your module/workspace:
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/xxx/Library/Caches/go-build"
GOENV="/Users/xxx/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/xxx/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/xxx/go"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.19.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/v2/70nz7fqs4bsf1nmqtbk8111h0000gp/T/go-

What did you do?
develop
What did you see happen?
Variable rng memory is not released and continues to grow
Type: inuse_space
Time: Apr 17, 2024 at 10:32am (CST)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top
Showing nodes accounting for 2098.23MB, 93.58% of 2242.26MB total
Dropped 130 nodes (cum <= 11.21MB)
Showing top 10 nodes out of 30
      flat  flat%   sum%        cum   cum%
  848.84MB 37.86% 37.86%   848.84MB 37.86%  math/rand.NewSource (inline)
  377.14MB 16.82% 54.68%   388.64MB 17.33%  github.com/IBM/sarama.(*asyncProducer).newPartitionProducer
  345.61MB 15.41% 70.09%  1221.45MB 54.47%  github.com/IBM/sarama.(*asyncProducer).newTopicProducer
  298.12MB 13.30% 83.38%   298.12MB 13.30%  runtime.malg
   56.51MB  2.52% 85.91%    61.51MB  2.74%  github.com/IBM/sarama.(*brokerProducer).run
   49.50MB  2.21% 88.11%    49.50MB  2.21%  github.com/IBM/sarama.(*asyncProducer).newBrokerProducer
      42MB  1.87% 89.99%    74.51MB  3.32%  github.com/IBM/sarama.newAsyncProducer
      27MB  1.20% 91.19%    76.51MB  3.41%  github.com/IBM/sarama.(*asyncProducer).getBrokerProducer
      27MB  1.20% 92.39%   415.64MB 18.54%  github.com/IBM/sarama.(*topicProducer).dispatch
   26.50MB  1.18% 93.58%    26.50MB  1.18%  github.com/IBM/sarama.newTransactionManager
(pprof) list NewSource
Total: 2.19GB
ROUTINE ======================== math/rand.NewSource in /usr/local/go/src/math/rand/rand.go
  848.84MB   848.84MB (flat, cum) 37.86% of Total
         .          .     39:
         .          .     40:// NewSource returns a new pseudo-random Source seeded with the given value.
         .          .     41:// Unlike the default Source used by top-level functions, this source is not
         .          .     42:// safe for concurrent use by multiple goroutines.
         .          .     43:func NewSource(seed int64) Source {
  848.84MB   848.84MB     44:   var rng rngSource
         .          .     45:   rng.Seed(seed)
         .          .     46:   return &rng
         .          .     47:}
         .          .     48:
         .          .     49:// A Rand is a source of random numbers.
(pprof)

What did you expect to see?
none

do you have a reproducer for this issue?
does this reproduce with the latest release?
there's now a math/rand/v2 package, does it reproduce with that?

It looks to me like you have a loop that is calling NewSource and storing the result in some other structure that is also not being freed. The traceback implies it's the caller of NewSource that's the problem, not NewSource itself.
Also, as @seankhliao wrote, there is a rand/v2. It was created because the old rand's Source is far too large. The new one should reduce the footprint enormously. However, I still believe the real problem lies in the code calling NewSource itself.


Quit quest" event

What does your feature do?
When a player leaves the quest, it would be nice if the plugin took some action.
Personally I try to exploit the full potential of your plugin by creating a story and therefore some npc are moved, if a player leaves the quest then the npc stays put, and I find that a shame.
however the function "ignore the commands" does not suit me, if the quest is too long for the player he must be able to leave it if he wishes it without penalizing the others
The ideal would be to add it in the basic menu

Once a player quits a quest, the plugin is no longer involved. Anything you wish to do after a quest should be handled with a separate plugin or the API. Consider hiring a developer and have them utilize the QuestQuitEvent in their solution.

Once a player quits a quest, the plugin is no longer involved. Anything you wish to do after a quest should be handled with a separate plugin or the API. Consider hiring a developer and have them utilize the QuestQuitEvent in their solution.


ovs-appctl: register unixctl commands in the beginning

Some commands of ovs-appctl were lazily registered when first
bridg or bfd was added. Before that, calling these commands raised a
error("xxx is not a valid command"). The problem commangs included
"bfd/...", "upcall/...","dpif/...","fdb/..." and so on.
Fix this by moving the register into the "bridge_init" and
"bridge_init_ofproto". All commands are registered at the moment
ovs-vswitchd starts.
Signed-off-by: Huanle Han<EMAIL_ADDRESS>

The way to reproduce bug:

delete all bridges
restart ovs
call command: "ovs-appctl dpif/show" or "ovs-appctl fdb/show" or "ovs-appctl upcall/show" ....
The cmds reports error "XXX is not a valid com".

I'm not sure this is a 'bug'.
Since these appctl sub-commands either require 'bridge' to be provided as argument or query the 'bridge' related property (e.g. bfd/cfm can only be enabled on iface, and iface is part of a bridge)
Could you explain more on how you bothered by the error message?
Thanks,
Alex Wang,

Case 1:

start ovs with some bridges in ovsdb, then delete all bridges
2.1 execute "ovs-appctl dpif/show"
==> it outputs nothing.
2.2 execute "ovs-appctl fdb/show"
==> it outputs:"fdb/show" command requires at least 1 arguments\rovs-appctl: ovs-vswitchd: server returned an error
2.3 execute "ovs-appctl fdb/show abc"
==> it outputs:no such bridge\r ovs-appctl: ovs-vswitchd: server returned an error

Case 2:

start ovs without any bridge in ovsdb
2.1 execute "ovs-appctl dpif/show"
2.2 execute "ovs-appctl fdb/show"
2.3 execute "ovs-appctl fdb/show abc"
==> they all output: "xxxx" is not a valid command\r   ovs-appctl: ovs-vswitchd: server returned an error

The outputs in case 1 are all reasonable. Because we do have no bridge and pass wrong argument. However, the output of case 2 report incorrect error message.
I think there should be no difference for the cmds between such 2 cases.
In addition, "cfm" has a different implement from "bfd". it registers its commands in
bridge_init() -> cfm_init().

I think that giving different errors in case 1 and case 2 is likely to surprise users.
I applied this patch to master and branch-2.4
Thank you!


Feat: Add the pattern option to the mkdist builder

Add the optional pattern option to the entry configuration of the mkdist builder.
Related PRs:

https://github.com/unjs/mkdist/pull/21
https://github.com/unjs/mkdist/pull/41

Waiting for this one!

Very need this


US21-RecoverPassword

Coverage increased (+0.7%) to 93.651% when pulling cdfde63376337a5b159d4d0ac4a22c875ab2f543 on devel into 72fc49343b11867957dc3fb0fa3aa4587f167628 on master.


how to do swipe up whole word animation for text?

this https://lottiefiles.com/24773-swipe-up-white-text kind of whole text jumping is possible?

@LOG-TAG You can use CollectionSlideTransition for this.
CollectionSlideTransition(               children: <Widget>[                 Icon(Icons.android),                 Icon(Icons.apps),                 Icon(Icons.announcement),               ],             ),


Fix: allow for binaries from $PATH to pass validity check

Tackles https://github.com/rust-analyzer/rust-analyzer/pull/5229#issuecomment-654151387
cc @matklad @lnicola
Apparently fs.existsSync() works only with real paths and not with $PATH env var

Bit late now, but should this be uplifted for the release?

No, I think that the original PR shouldnt' be in release, as it was merged today, and we promote nightly for the release


initialScrollY not working

initialScrollY is not working. Great if anybody can share a sample code which uses this. @ankeetmaini

initialScrollY is not working. Great if anybody can share a sample code which uses this. @ankeetmaini

Anyone can test the prop just by adding the prop to the sandbox code provided in npm page.
https://codesandbox.io/s/exciting-hodgkin-dhoxv?file=/src/index.js


Gijgo Grid DropDown Problem

I have added dropdown list in grid.It is working fine for hardcoded values but,when i try to get values dynamically it is not  binding in dropdown.
Here is my code,
function edit($container, currentValue) {
var ddlSupplier = "";
$.ajax({
type: "GET",
url: "/Master/AllSupplier",
datatype: "Json",
success: function (data) {
$.each(data, function (index, value) {
ddlSupplier = ddlSupplier + "" + value.Name + "";
});
$container.append('' + ddlSupplier + '');
}
});
}
Please help.

You can see a working example at http://gijgo.com/Temp/92ec1eb5-df5b-49db-8be3-a218a5d96c5e.html.
You can see all changes when you click on the "Get Changes" button

Hi Atatanasov,
I am trying to figure out the JSON returned from the GET method within the example you shared. Could you please fix the example as this isn't working anymore. I would like to have different controls inside the grid and dropdown is one important input control among these.
Many Thanks, :+1:
Prith

Hi Prithiraj,
This is a link to the fixed demo -> http://gijgo.com/Temp/2ee6e09e-3cd7-48e3-85a1-8e931c081c91.html
The path to the dataSource is changed. That's why the old demo doesn't work.

Hi Atatanasov,
Thank you for the reply. I have successfully implemented the dropdown in edit. On cellDataBound event I populated the column with a returned text.
Now once I go for editing, the currentvalue stays undefined. When I click on the cell a dropdown element is built within and it shows the top element. When clicked the user would expect to see that value selected in the dropdown.
Question is once we click the field, how to get the item stay selected in the dropdown?
Regards,
Prith

FYI, the above query is for custom dropdown columns. Means, it's a field where the values are added inside cellDataBound event.

Can you share the code? I can't help you without looking at the code.

`     var grid;
 function edit($container, currentValue) {
$container.append('<input type="text" value="' + currentValue + '"/>');
 }
 grid = $('#grid').grid({
     primaryKey: 'ID',
     dataSource: 'GetPlayers.json',
 columns: [ { field: 'ID' }, { field: 'Name', editor: true }, { field: 'PlaceOfBirth', editor: edit }, { field: 'UniqueKey', editor: edit } ]

 });
 grid.on('rowDataBound', function (e, $row, id, record) {
console.log(record.Name);
if (record.Name === 'Hristo Stoichkov') {
    	$row.css('background-color',  '#AAAAAA');
	}
 });
 grid.on('cellDataBound', function (e, $displayEl, id, column, record) {
if ('UniqueKey' === column.field) {
	recId=record.ID;
	recName=record.Name;
	recBirth=record.PlaceOfBirth;
	$displayEl.text(recId+recName.substring(0,3)+recBirth.substring(0,3));
     }
 });`

Once you click on the custom field for editing, the value inside sets to "undefined". This wouldn't exist when the field value is from the server directly. But still I thought if this might be improved. Personally, not important right now, as I removed the custom field and placed the default field instead.

We fixed that issue in the new development version. You can find the builds at https://github.com/atatanasov/gijgo/tree/master/dist
You are having this issue with the current version, because this is not part of the dataSource that is received in the grid from the backend. You can resolve this if you build the UniqueKey column values on the server and not use javascript to assemble them. This is the only work arround if you don't want to upgrade to new version.


[FEATURE] paganiation support in search results

Describe the feature/change you'd like
currently, the cli retrieves only the content available in the 1st page, and the fzf selection in search result works only in that page.
this issue is to requesting the implementation of the paganiation to the cli, I have also added a project below which I have been using recently and which has paganiation for results.
Additional context
reference: https://github.com/mps-youtube/yewtube

alright exists in v4 scrapers :+1:


bower-expected-output: Upgrade the shadycss dependency to version 1.7.0

Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

This change is

Merging despite the unrelated Travis failure about "connecting to bitbucket.org using legacy security technology (TLS 1.0)".


pool worker in error

Describe the bug
After restarting a node the pool worker on the node is in error.
To Reproduce
Get a cluster running with 3 pool workers, reboot one node.
Expected behavior
The restarted node rejoin the pool and data is updated in case of multiple replicas
Screenshots
~ kubectl mayastor get nodes
ID               GRPC ENDPOINT        STATUS
talos-worker-03  <IP_ADDRESS>:10124  Online
talos-worker-04  <IP_ADDRESS>:10124  Online
talos-worker-05  <IP_ADDRESS>:10124  Online
➜  ~ kubectl -n mayastor get msp
NAME             NODE              STATUS   CAPACITY      USED          AVAILABLE
pool-worker-03   talos-worker-03   Error    0             0             0
pool-worker-04   talos-worker-04   Online<PHONE_NUMBER>8<PHONE_NUMBER>4<PHONE_NUMBER>4
pool-worker-05   talos-worker-05   Online<PHONE_NUMBER>8<PHONE_NUMBER>4<PHONE_NUMBER>4
** OS info (please complete the following information):**
Talos Linux 1.0
Kernel: 5.15.32
Kubernetes: 1.23.5
MayaStor: v1.0.1
Additional context
I have previously had trouble with getting all etcd nodes to run, but all pods are now runnning.
The msp-operator has this error in the log:
msp-operator   May 15 17:32:55.777  INFO msp_operator: CRD present                                                                        │
│ msp-operator     at control-plane/msp-operator/src/main.rs:807                                                                            │
│ msp-operator                                                                                │
│ msp-operator   May 15 17:32:55.785  INFO msp_operator: Starting Mayastor Pool Operator (MSP) in namespace mayastor                        │
│ msp-operator     at control-plane/msp-operator/src/main.rs:923                                                                            │
│ msp-operator                                                                                │
│ msp-operator   May 15 17:32:56.022 ERROR msp_operator: entered error as final state, pool: "pool-worker-03"                               │
│ msp-operator     at control-plane/msp-operator/src/main.rs:880                                                                            │
│ msp-operator     in msp_operator::reconcile with name: talos-worker-03, status: Some(MayastorPoolStatus { state: Error, capacity: 0, used │
│ msp-operator     in kube_runtime::controller::reconciling object with object.ref: MayastorPool.v1alpha1.openebs.io/pool-worker-03.mayasto │
│ msp-operator
How would I go about getting that error sorted?

@simcax How did you end up resolving this issue? I'm seeing the same problem. Thanks!

Do you have a pool in error state @hiattp? You can try to delete it and recreate it, if that doesn't work then we'll probably need to collect some logs/etc.

Hey @tiagolobocastro yeah I did, I was updating from talos linux 1.2.4 to 1.3.0 which involved several node restarts. After the series of updates and restarts all of my pools were in an error state and pods on related PVCs wouldn’t initialize (volume not found errors or something to that effect). To be fair in production presumably we would have only upgraded one node at a time, then ensured the mayastor replicas survived or would have restored them before losing the other replicas. Instead I bulk updated all nodes simultaneously and they were all rebooting (and erroring out) at the same time.
Does deleting and recreating the pool wipe the volume? Since all replicas were erroring out I was reluctant to do that. This is just a test setup (I’m evaluating mayastor) so I ended up just killing all storage classes/volumes/pools and uninstalling mayastor, I’m going to try installing mayastor v2 (this was on v1) and then will see if I can reproduce. But curious to know what troubleshooting/recovery would have looked like, particularly whether the only way to resolve was deleting and reinitializing the pools and whether that loses data. Disaster recovery is one of the things I’m trying to evaluate. Thanks!

Does deleting and recreating the pool wipe the volume

No it doesn't, the control-plane will not delete pools that have replicas. If you remove the finaliser and delete the CR, the actual pool will be untouched if it has any replicas.
Conversely creating the pool again will not delete the existing data, rather it would either fail (if the pool name is different) or it will simply be an "import".
The issue you're probably hitting is probably that the pool operator is too eager to reconcile the CR's into a sticky error state. The actual pool might be fine, which you can query by using the kubectl-plugin, example: kubectl-mayastor get pools.
On the current develop that behaviour is a bit better but there is still one case where pool CR's go into error and don't recover, we hope to fix that soon.
kubectl-mayastor get nodes, kubectl-mayastor get pools, kubectl-mayastor get volumes is probably the first starting point to start troubleshooting.
On develop we also have a kubectl-mayastor dump system to collect a support-bundle with all sorts of information.

Ok that all sounds great, thanks! I’ll give it a try on v2 and resurface here if I hit an unresolvable error. Appreciate the responsiveness!

@simcax How did you end up resolving this issue? I'm seeing the same problem. Thanks!

@hiattp - I ended up abondoning mayastor, as I unfortunately couldn't get it to work. The issue at the time was most likely number of CPU cores available. I now have a new homelab server, which is spec'ed a lot better, but haven't had time to get back to this project yet.


Await unfinished on_event tasks

on_event is called in fire-and-forget mode with asyncio.create_task. If the event loop finished earlier, it may become a problem

I assume this is done by aiohttp


Will it work in Purpur1.19.3 if I join from 1.19

no the patched the dupe in 1.19.1

and if the server has any plugin clinets like spigot the mod wont work

No, it doesn't work on anything spigot based or on versions above 1.19.0.


/en-US/docs/Learn/HTML/Forms/Sending_and_retrieving_form_data

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details
Typo in second paragraph of conclusion
"If you've worked your way these tutorials in order, you now now how to markup, style, and sumbit a form..."
Expected:
"If you've worked your way these tutorials in order, you now know how to markup, style, and sumbit a form..."

Fixed; thanks for reporting!


Allow AccuCor files to load peak data even if tracer contains multiple labeled elements

BUG DESCRIPTION
Problem
This may not be a "bug" technically,  but this template seemed useful.
When attempting to load an Accucor file that contains samples taken from animal that was infused with a tracer that contained more than one labeled element (e.g. 13C and 15N), an exception is thrown.
Steps to reproduce

Attempt to load the attached study issue-multilabled-tracer-accucor-load.zip

Base conditions

Tracer contains multiple labels
Loading an AccuCor file
AccuCor file contains data for only a single labeled element in every row (should be the case for unaltered AccuCor output)

Cases

Detected compound contains more than one of the labeled elements
Detected compound contains only one of the labeled elements

Current behavior
Exception:
InvalidNumberOfLabeledElements: This code only supports a single labeled element in the original data sheet. Row 1 has 2.

Expected behavior

Case 1 - Warning
Case 2 - No warning

Alternative behavior

Case 1 and Case 2 generate a Warning

Suggested Change
Comment

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

[ ] 1. List of numbered conditions to be met for the feature
[ ] 2. E.g. Every column/row must display a value, i.e. cannot be empty
[ ] 3. Numbers for reference & checkboxes for progress tracking

Limitations

A list of things this work will specifically not do
E.g. This feature will only handle the most frequent use case X

Affected Components
A list of repository items, dependencies, etc, labeled with add, delete, or
change.  One item per line.  (Mostly, this will be a list of files.)

change: File path or DB table ...
add: Environment variable or server setting
delete: External executable or cron job

DESIGN
GUI Change description
Describe changes the user will see.
Code Change Description
Describe code changes planned for the feature. (Pseudocode encouraged)
Tests

[ ] 1. A description of at least one test for each requirement above.
[ ] 2. E.g. Test for req 2 that there's an exception when display value is ''
[ ] 3. Numbers for reference & checkboxes for progress tracking

This code is behaving as it was originally designed.  The outcome is intentional.  It is because I had noted during the isocorr refactor that (as indicated in this comment above where the exception is raised):
# Ensuing code assumes a single labeled element in the tracer(s), so raise an exception if
# that's not true

That assumption was inherent in the code of the first version of the accucor loader.  I believe it only grabbed the first and did not look at or parse the second (though I would have to dig into the code to confirm that's the assumption the code was making).
I definitely noted that the behavior would have not been as expected in this case, which is why I both decided to implement a separate code block(s) and added the check and the exception to the original accucor code.  I could have called it a bug at that point, but instead just decided to implement a known limitation of the code.
Point being, that makes this issue a feature request.  But I'll leave it as a bug, since that was my initial interpretation when I added the exception.  I probably should have created an issue, but I didn't know that having more than 1 labeled elements in an accucor file could have been intentional/correct.


Use Bash features instead of dirname and basename

Description
Reduce subshells and external commands by using Bash's string processing features instead of dirname and basename.
Motivation and Context
This is part of a set of patches to reduce usage of subshells and external binaries in Bash It.
How Has This Been Tested?
Tested locally.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the code style of this project.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[x] I have added tests to cover my changes, and all the new and existing tests pass.

Hi All!
In theory, the idea is nice - you avoid the subshell (but lose some explicitness)
In practice, the two approaches are not completely identical.  For a short discussion on the matter:

https://stackoverflow.com/questions/22401091/bash-variable-substitution-vs-dirname-and-basename

stolen and reformatted table of mismatches
file        basename $file  ${file##*/}  dirname $file  ${file%/*}
/aaa/bbb/   bbb             ''           /aaa           /aaa/bbb
/           /               ''           /              ''
/aaa        aaa             aaa          /              ''
aaa         aaa             aaa          .              aaa
aaa/        aaa             ''           .              aaa
aaa//       aaa             ''           .              aaa/

note: '' => empty string (quotes not really generated)

We'd have to be very sure that the format of the variable we were using didn't match any of these patterns, ie. Don't compute basename from a directory with tailing / or don't compute dirname on a directory off of root.
I think we might be better off just biting the bullet on the subshells for dirname and basename.

@davidpfarrell - great feedback!
Very interesting. After seeing this difference I also agree with David here. I am all in for avoiding subshell, but not at the cost of unexplained behaviours and possible bugs!
Let us know what you think @gaelicWizard !

Thanks for the link to examples! You may have noticed, my whole brainworm is about edge cases so I'm grateful for the specific examples. Give me a few to look through these 😃

Hi @gaelicWizard, as discussed, I currently prefer to not merge this PR, but focus on the other (great!) PRs that you did. I still want to hear what you think about this- so I am currently waiting for you

My apologies for the radio silence! I had intended to dun the statistics linked in @davidpfarrell's comment but just haven't found time. Hopefully this weekend 😃

The table of behavior differences between dirname/basename and the shell version boils down to two cases:

trailing slash / no file name, and
no slash / no directory / not a path (just a file).

Therefore I've now split this PR in to three commits:

Uses of dirname which don't hit either edge case,
Uses of basename which don't hit either edge case, and
Uses of dirname which may hit the "blank" edge case.

In the first two commits, the parameter is specified with a full path within the immediately preceding lines so we simply never hit the case where a (possibly user-supplied) unexpected string is provided that may have too many or too few slashes.
The third commit ("dirname (2 of 2)") has cases of directory walking or accepting user-specified path specifiers. These may or may not hit the two identified edge cases and definitely need something more/other than just string truncation. (Unrelated to dirname, the directory walking bothers me, so I may look in to some alternative.)
Reducing subshells and external binaries is a valuable goal IMO; I normally expect my shell to start in under a couple of seconds. I've seen comments in other issues and PRs indicating that some folks have shells that take tens of seconds to start, which is just bananas to me. So, I'd like to submit the first two commits under a separate PR, which I hope will result in an uncontroversial merge, and leave the third commit out. (I'd like to close this PR with all three for reference.) Let me know if this sounds reasonable?


Transact resolve() to group undo operation

Currently multiple undo operation is necessary to revert "Use Me" or other resolving commands.
This PR wraps them into single transaction and groups undo operation for resolving.

oh.. sorry for intermittent PRs.

oh.. sorry for intermittent PRs.

No worries at all, thanks for the help! By the way, I've made you a contributor - feel free to self-merge and apm publish when I'm not around. :smile:
The only thing I'd ask is to try to keep the CHANGELOG up to date as you work (although I'm guilty of forgetting it myself pretty often).

Thats great! Thank you!!! :D


generate migration files

It could be useful to add a command to generate migration files.
Something like:
flyway g add create_user_table
And it will create a file named
V20180821094220__create_user_table.sql

Duplicate of #400


Principles and comparison in README

Defining principles and an outline of why the Hoot project exists through comparison. This edit summarizes discussions via the keybase group.

I like the graph but I think there's too much emphasis on the anti-censorship piece. While it is a very valid point, the goal of the project is to make an awesome federated link aggregator that's super fast, scales well, looks great, and puts as much control as possible as close to the user as possible. The vast majority of uses will probably have both human and automated moderation and curation, the difference is who defines what moderation means and what is or is not acceptable.

I made a few changes to the overall readme, feel free to take a look and tell me what you think.

Well said! Love the update.


Update scalafmt-core to 3.7.16

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.15 to 3.7.16
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #2775 (8ab66b0) into main (d46cc5e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
- Coverage   78.84%   78.84%   -0.01%
==========================================
  Files         466      466
  Lines       15903    15903
  Branches     2604     2570      -34
==========================================
- Hits        12539    12538       -1
- Misses       3364     3365       +1

see 3 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Superseded by #2779.


Add git tags

Hi @Juriv,
We are cdnjs team.we're going to host this library.
The git auto-update in cdnjs relies on git tags so that it can recognized the correct version and automatically update this repo.
Could you please add git tags for the repo? Thank you.
https://github.com/cdnjs/cdnjs/issues/10310

done, thanks


[Feature] Add Ads

There's 5-number of views/month, at least to compensate our open source model we need to add ads.
https://www.carbonads.net or Google AdSense, need to think. Most likely Google AdSense first to give it a shoot.

Google AdSense: not possible to add ads to subdomains https://support.google.com/adsense/thread/293591180

Applied today for https://www.carbonads.net

Integrate somehow Google AdSense via Google Analytics as of September 14, 2024.


Enhance CustomAuthenticationFailureHandler

Current situation
Currently, the CustomAuthenticationFailureHandler returns to the login page if the user could not successfully authenticate. URL parameters such as ?disabled or ?badCredentials display error messages to the user in the login form.
Target
The CustomAuthenticationFailureHandler should now additionally log the date and time of the failed authentication attempt to the database.

Moved to trello.


USB Audio: support sampling frequency select

These commit adds support for the host to select different sampling frequencies.
There is a new callback for changed sampling frequencies, I kept is separate from features because it's not a feature from the perspective of the USB Audio 1.0 standard. But from an API perspective it could make sense.
Writing the frequencies to the format descriptor was surprisingly hard and in fix_format_descriptors() I had to loop over all devices to find the mapping between the interface descriptor and device data.

@Jojjec1 thanks for the PR. Please format your commits as described in the guidelines, including a signed-off-by line:
https://docs.zephyrproject.org/latest/contribute/index.html#commit-guidelines

Writing the frequencies to the format descriptor was surprisingly hard and in fix_format_descriptors() I had to loop over all devices to find the mapping between the interface descriptor and device data.

You might be interested in the topic-usb branch which is trying to rework the interface between the core and the classes:
https://github.com/zephyrproject-rtos/zephyr/pulls?q=is%3Apr+is%3Aopen+base%3Atopic-usb

You might be interested in the topic-usb branch which is trying to rework the interface between the core and the classes:
https://github.com/zephyrproject-rtos/zephyr/pulls?q=is%3Apr+is%3Aopen+base%3Atopic-usb

I've already talked a bit with @Jojjec1. I will take into consideration such problems as we have right now when reworking the core-class interface. This PR just proves we need to do something about that.

I've reformatted the commits now. a rework sounds promising, that the class iterated over each struct is painful and is prone to bugs.

Thank you for your initial feedback on this. It seems like most of the design issues I ran into will be addressed the the USB rework.
The things I see as temporary that I hope the USB core change will help with are the class handler change in usb_device.c and hopefully also the fix_format_descriptors function.
Additional work to be done would be to fix how the two logical units are identified and the callback API for notifying the application that the frequency has been changed.

One more thing we need rethink is EP_SIZE which is fixed on build time. Right now it is fixed to support 48kHz sampling frequency. If user specifies less, eg. 44.1kHz this should return proper value and save memory for used net_bufs.

One more thing we need rethink is EP_SIZE which is fixed on build time. Right now it is fixed to support 48kHz sampling frequency. If user specifies less, eg. 44.1kHz this should return proper value and save memory for used net_bufs.

True, should be calculated based on the highest frequency. When running asynchronous it should actually have room for one additional sample so that the device can send one extra sample if it gets too many of them. That so the device and host will keep in sync with its samples.

One more thing we need rethink is EP_SIZE which is fixed on build time. Right now it is fixed to support 48kHz sampling frequency. If user specifies less, eg. 44.1kHz this should return proper value and save memory for used net_bufs.

True, should be calculated based on the highest frequency. When running asynchronous it should actually have room for one additional sample so that the device can send one extra sample if it gets too many of them. That so the device and host will keep in sync with its samples.

Is it possible to extract the last entry form frequencies table so that we can make a macro for this?
This potential macro must be used here instead of fixed 48.

There are some great features in this PR. @te-johan, are you still working on this? :)

@koffes, at the moment no. I think we should wait for the rewritten usb core.
The way class requests are handled breaks the ability to use composite. also the way it has to loop over all devices in fix_format_descriptors is not a good solution.


skip HMR update chunks

Fixes #22

Hey, thanks for the PR @ju1ius! I just ran into this issue yesterday myself.
Is it possible to get the *.hot-update.js pattern from output.hotUpdateChunkFilename instead of hard-coding it? It should be more resilient to changes that way.
// The default value is defined in webpack/lib/WebpackOptionsDefaulter.js:35
this.set("output.hotUpdateChunkFilename", "[id].[hash].hot-update.js");

I'm not sure how to properly parse webpack's filename pattern into an actual filename though. I'm guessing  there's a method for that somewhere in webpack.

Hey, thanks for the PR

@raquo

Is it possible to get the *.hot-update.js pattern from output.hotUpdateChunkFilename instead of hard-coding it? It should be more resilient to changes that way.

PR #24 handles it.


Dashboard navigation improvements

Fleet APIs table on API select ( click ) :

Select the corresponding API from APIs list
Switch menu tab to APIs list

Fleet Static Routes table on Static Route select ( click ) :

Select the corresponding Static Route from Static Routes list
Switch menu tab to Static Routes list

PR - https://github.com/kubeshop/kusk-gateway-dashboard/pull/86


chore(deps): update dependency org.jasig.portlet.utils:portlet-form-resources to v1.1.3

This PR contains the following updates:

Package
Update
Change

org.jasig.portlet.utils:portlet-form-resources
minor
1.0.0-M1 -> 1.1.3

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

PR has been edited
:construction_worker: This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.


Create codes

this code is a simple application in c language that contains the features of an automaton

this code is a simple application in c language that contains the features of an automaton


Redux Dev Tools shows previous state

In Redux Dev Tools the previous state is shown.
Here is an  example
Here is a stackoverflow question with a more detailed explanation of the problem.

Fixed. Planning to release in next few days.

I updated ngxs to 1.5.1 in the example and changed imports in AppModule as shown in documentation:
NgxsModule.forRoot([AppStore]),
ReduxDevtoolsPluginModule.forRoot({
    disabled: false // Set to true for prod mode
})

I get the following error:
Error in /turbo_modules/<EMAIL_ADDRESS>(509:34)
Unexpected value '[object Object]' imported by the module 'AppModule'. Please add a @NgModule annotation.
Evaluating main.ts
Booting application

Ok, i fixed this ( not released yet ) but noticed the latest changes to plugins broke this plugin @deebloo  :(

Closing since we are tracking that issue on #58


mat-datepicker - unable to set date display format as dd-mm-yyyy

Bug, feature request, or proposal:
I would like to know how to set the date display format as dd-mm-yyyy using mat-datepicker
What is the expected behavior?
Date to be displayed as dd-mm-yyyy
What is the current behavior?
Date is currently displayed as d-m-yyyy
What are the steps to reproduce?
https://stackblitz.com/angular/nqbgnmoyrod?file=app%2Fdatepicker-formats-example.html
What is the use-case or motivation for changing an existing behavior?
We need to display the dates in dd-mm-yyyy across our application
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 1.7.3
Node: 8.9.4
OS: win32 x64
Angular: 5.2.9
Is there anything else we should know?
There is no proper example or documentation or easier way to do this.

+1

@jayakrishna-v  Any updates or alternate solution?

following. any solutions?

bug detected

Bump.

Why did you close it? I still see only d-m-yyyy format and don't see easy way to chenge date format

Seriously, why is there no reaction here and why did the thread closed? I have set the local like:
    {
      provide: MAT_DATE_LOCALE, useValue: 'de'
    },

And there seems no way to change the format from d-m-yyy to dd-mm-yyyy event though the latter is "more german".

UPDATE
I had to admit that the solution to this is (also if not very straightforward) pretty well documented on https://material.angular.io/components/datepicker/overview#choosing-a-date-implementation-and-date-format-settings (see headline Customizing the parse and display formats).
If you are using Moment.js it's easy to use MatMomentDateModule and if you want to do something completely customized just subclass NativeDateAdapter. As I vastly prefer Day.js over Moment.js because of its tiny size I wrote a custom DateAdapter utilizing it to display my dates as DD.MM.YYYY.
Feel free to use or modify this for your needs: https://gist.github.com/wottpal/4211f4c01c41b16be181110273cff5a9

Anyway it is not easy to just change date format, especially if I don't want to use extra library only for that (Momen has big size).  The best way, just to have attribute for component for setting date format. Wottpal, thank you for your answer with detailes and example


⚠ Bofrost.be has degraded performance

In 4a5326e, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1695 ms

Resolved: Bofrost.be performance has improved in ba9f894 after 6 minutes.


Rename development data concept to avoid db/seeds confusion

Using db/seeds for data which must be loaded in a production environment
is a standard Rails convention.  We cause confusion by using the word
"seed" elsewhere in a Rails app, where that is not the context.
The dev:prime task is actually providing local fake/sample data for
developers to see the app in use, but not production-required data to
actually run the application.

Thanks for this! :+1:

:+1:

Ref: https://github.com/rails/rails/pull/20881


⚠ Bofrost.at has degraded performance

In adf4520, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1226 ms

Resolved: Bofrost.at performance has improved in ddc47e8 after 7 minutes.


Wrapped dependency repository rules with the _maybe macro

My organization uses Artifactory to proxy/cache all of our build dependencies, and it's hard rule that everything must be sourced this way. To accomplish this with Bazel, we need to be able to override each  repository rule with an equivalent rule that points to Artifactory instead of the upstream source.
While we could simply omit the rules_pkg_dependencies() call and manually override these dependencies, we actually have a tool that will inspect all repo rules and automatically generate the equivalent Artifactory rules. The use of _maybe allows that to work.

Gah I always forget to set my CLA-approved email for a new repo

Looks fine, I'll leave it to @aiuto to merge this, as he's maintaining the repository.

My bad. I was away for the last 2 weeks and totally missed this.
I made the same change in https://github.com/bazelbuild/rules_pkg/commit/55afe43d430dba09270eeedcf2e0ce3374c02897#diff-b1ec5372e7a6138f4df358e8a2b164d8
So I don't think there is any need for this one.

No worries! Glad the change got made either way


[V1.3][WIP]Comment field test support

Pull Request Test Coverage Report for Build 718

30 of 34 (88.24%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 80.838%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/commands/EditCommand.java
4
5
80.0%

src/main/java/seedu/address/model/event/Event.java
5
6
83.33%

src/main/java/seedu/address/storage/XmlAdaptedEvent.java
10
12
83.33%

Totals

Change from base Build 713:
0.2%

Covered Lines:
1911

Relevant Lines:
2364

💛  - Coveralls


DOCS: Describe how to install Membrane with the tanuki Wrapper on Linux

Think Membrane contains already a wrapper.conf

Add Group at web site.
1.) init.d / systemd Startup Script
2.) Tanuki Service Wrapper
See...

Done


[OB3] - Receive event notification even if the tpp is not subscribed to the particular event type

Description:
TPP receives event notification even if the tpp is not subscribed to the particular event type.

Create a subscription with only "Acount-Access-Consent-Linked-Account-Update" event type.

Send an event creation for the "Consent-Authorization-Revoked".

TPP receives the notification and acknowledged it.

But according to the expected behaviour, tpp should not receive any notifications.
Suggested Labels:
Suggested Assignees:
Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:
[Any related issues such as sub tasks, issues reported in other repositories (e.g component repositories), similar problems, etc. ]

Verified as FIxed


Implement Filters

Use SDS ComplexFilter to build the filters in the left panel
The filter options depend on organism and tissues
When a new organism is selected, we will destroy all options and populate new values as new tissue(s) are selected
Maybe the Filters component has a callback prop onFilterChange that will pass selected filters to frontend/src/views/WheresMyGene/index.tsx, which will make a new API call to /query to get updated expressions?

Nongoals:

The filter options don't need to narrow down when a user selects more filter values. E.g., if a user selects just one dataset and that dataset only contains female data. The sex filter doesn't need to update options from "male" and "female" to just "female." We'll revisit this feature in Q2

https://github.com/chanzuckerberg/single-cell-data-portal/pull/1986


Attempted to load class "Kernel" from namespace "App"

Recently i encounter this error in fresh symfony 3.4 install:
PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Kernel" from namespace "App".
More specificaly on this line :
vendor/borsaco/telegram-bot-api-bundle/DependencyInjection/Configuration.php on line 16

witch version of the bundle do you use?

Version 1.0.3

Sorry, I have no time to check and test. Please use dev-master instead of this version if worked tell me to change the version and new release.
thanks


feat: deal hotkey full/half release different

Hotkey full-release switch to the window that was focused on last full-release.
Hotkey half-release cycle windows
close #18

re:,

Hotkey full-release switch to the window that was focused on last full-release.
Hotkey half-release cycle windows

I'm curious, but do not understand what full or half-release means here.  Or "last full-release" means.

This is a technical statement.
Keep alt pressed, only release `  is called half-release. alt and `  both released  is called full-release。
The final effect is as follows:
Press and hold the alt key, tap ` to cycle through windows, press alt + to switch back to the last focus window.


Fix issue where utility tabs don't show/hide correctly

What
I'm not sure why yet but view.superview isn't self. In any case, the check is extraneous, so I'm removing it.
Testing Plan

[X] Tested this change locally
[X] Checked that existing features work

cc @outdooricon

so much ❤


Update flux-e2e.md with info on what extensions are supported by kustomize controller

Thanks for adding this. I'm looking for a bit of code or other backup that can verify this – are you sure kustomize controller will only pull these in? (Can we say something about where that decision is made?)
This is good detail to include, but I was always wary about adding fine details like this because they can be changed, and this risks making the doc "less evergreen."
It has been a good amount of time since this doc was broadly refreshed now, it may be time to check if other details are missing or out of date now too.
Anyway, about this detail in particular... if you named a json file in kustomization.yaml, I am pretty sure it will get included too, but the kustomize create --autodetect command that is mentioned in this FAQ will not pick it up if you didn't write your own kustomization.yaml. I would love to find a piece of source code in either project that says "only .yml and *.yaml extensions" so we can include a link there in the reference, so it's easy to see if this ever changes out from underneath the docs.
I don't want to make the sentence you added much longer than it is, but it should get some minor adjustment to account for this, and like I said if you know what code filters the list down to only these two extensions, it would be great to include a link to that code directly in the passage! 👍


(v3) Chore - fix and tidy the build

description:
So, I was doing some minor webpack cleanup when, much to my chagrin, I discovered that the production artifact on app-3-0 wasn't actually capable of running. Seeing as we need to run our app, I expanded the scope of my cleanup and now:
:tada: Production app runs
:tada: Only one webpack config
:tada: App README accurately describes the project
:tada: Makefile uses more standard GNU targets (all, install, uninstall, clean)
:tada: Electron bundle only includes what's actually needed to run
:tada: index.html doesn't have weird build logic anymore because it's a template
:zap: Python API no longer bundled in the app
:zap: Makefile is now where all build / dev scripts live
checklist

[x] Are there breaking changes in the API and how are they being communicated?

No API changes, but...
If you're working on the app, you'll need to re-install your dependencies
Once you're on this branch, $ make uninstall install will do the trick!

[x] Who is reviewing your code?

@OpenTrons/js

Having some problems getting it to run...

After make dev-app,

...
node_modules/.bin/cross-env NODE_ENV=development PORT=8090 electron shell/main.js
...
    Error: spawn electron ENOENT

The command electron doesn't exist, so the Makefile isn't picking up the aliases from node_modules/.bin.

If while the server is running, I do ./node_modules/.bin/electron shell/main.js, then the app launches, but it's just Electron with a white screen and menubar.

If I go to http://localhost:8090/, it's a white screen with the Intercom widget there. In the JS console, there is the error ReferenceError: require is not defined
@mcous

@IanLondon my bad, that line in the makefile should've read $(bin)/electron. I just pushed the fix

If I go to http://localhost:8090/, it's a white screen with the Intercom widget there. In the JS console, there is the error ReferenceError: require is not defined

Forgot to follow up on this: right now our webpack job is building the ui bundle for an electron-renderer environment, which means it won't work in browser. I can explore changing that target to web if we'd be interested in debugging via a browser (I think it would still work in electron as a web target)


Stage 0.7.2

What about integrating java scripting platform ?

@BurakDev JPHP has support of this https://github.com/jphp-compiler/jphp/tree/master/jphp-scripting

Oh okay ! Any docs/examples ?

@BurakDev Documentation for this does not exist yet, but it's JSR-223 standard and you can read about it here: http://www.drdobbs.com/jvm/jsr-223-scripting-for-the-java-platform/215801163.


https://intelstack.com link does not work

https://intelstack.com has become unavailable. Also the link from capitalone does not work.

Thank you the heads up. I'm not sure if Critical Stack Intel is/will be open sourced by Capital One, but https://github.com/criticalstack seems to be somewhat alive, so I'll keep this issue open for now, so that I can check this in the (near) future.

The link was removed in #271. I think it has been long enough, so I'll close this issue too. Thanks 🙂


How useful ReSwift for OSX application?

Currently, ReSwift use in iOS. will it be useful for OSX application?

@steve21124 ReSwift itself is entirely platform agnostic. It should work very well for OS X applications as well. Actually @DivineDominion is working on an OS X example right now. It's still WIP but you can see it here: https://github.com/ReSwift/ReSwift-Todo-Example
We will aim to have good example for both OS X and iOS.

Thanks Ben.
Thanks for the link, pretty useful link to see how it is useful for OSX type application. I still try to see what type of OSX application will be useful using ReSwift

"Apps built upon MVC often end up with a lot of complexity around state management and propagation. We need to use callbacks, delegations, Key-Value-Observation and notifications to pass information around in our apps and to ensure that all the relevant views have the latest state."

"Want to collaborate with a co-worker on fixing an app crash? Use ReSwift Recorder to record the actions that lead up to the crash and send them the JSON file so that they can replay the actions and reproduce the issue right away."

This is attractive feature

there is RxSwift which state "It frees you from tangled webs of callbacks, and thereby makes your code more readable and less prone to bugs.". Is ReSwift try to tackle the same problem as RxSwift?

RxSwift chooses another implementation paradigm, but the goal's the same. ReSwift is currently less aimed at being a declarative approach where you use callbacks/ signals to model one piece of information flow. I'd say when RxSwift uses lots of runctional reactive programming techniques, ReSwift is your good old object-oriented programming applied properly and with care.

@steve21124 I would actually come up with a slightly different answer here.
RxSwift and ReSwift both try to tackle the problem of updating state in your applications. Both try to make this as declarative as possible; this means you describe how State A relates to State B.
RxSwift does this on a lower level. It doesn't require a specific architecture, it simply gives you the tools to update state automatically through bindings and observers (which makes it more declarative) instead of relying on manually calling callbacks or delegate methods.
ReSwift tackles the same problem, but on the level of an application architecture. If you follow the ReSwift architecture you will always use Actions to update your application state and therefore will always us ReSwift's automatic state update flow instead of manually calling callbacks or delegate methods.
ReSwift and RxSwift also work really well together. Instead of implementing the newState method on your subscriber; you can wrap the Store into an Rx Observable and then use the RxSwift mechanics to get state updates (we will hopefully soon have an example for this).
TL;DR: Both tackle similar problems, both work well together. RxSwift provides a toolset, ReSwift suggests an architecture.

I'd say when RxSwift uses lots of functional reactive programming techniques, ReSwift is your good old object-oriented programming applied properly and with care.

ReSwift is based on Redux and therefore base on a lot of functional programming ideas (reducers as pure functions, declarative programming through actions, etc.).
However, IMO, neither RxSwift nor ReSwift impose an object oriented or a functional architecture onto the developer. It is really up to you how you use both of these libraries.

Thanks all for above comments. This will be super useful information. I think above comments can be put on ReadMe page. As most still new with swift way of state management and functional programming, there will be a lot of research in comparing state management framework or architecture design.
The next question is, will ReSwift be used in conjunction with MVC? from readme page, seems like it is either ReSwift or MVC?

Sounds like a good idea.  Here's another interesting way of describing difference between FRP and Redux:
@andrestaltz @dan_abramov reactive programming optimizes "when does stuff change", redux optimizes "what state is there".— Ryan Florence (@ryanflorence) February 12, 2016

Seems like this question is resolved.

Is there any example in the meantime for what you stated with:
ReSwift and RxSwift also work really well together. Instead of implementing the newState method on your subscriber; you can wrap the Store into an Rx Observable and then use the RxSwift mechanics to get state updates (we will hopefully soon have an example for this).
I have an idea about it, but I would love to see more input.

For example: https://medium.com/littlebigsnippets/using-rxswift-with-reswift-in-swift-redux-architecture-d342963c5ffe#.qbbv7gtfe


Wrong Mac Command

Description
The tutorial has a wrong Mac command on Get started with ASP.NET Core MVC>Run the app:
Instead of:

It should be:

Page URL
https://learn.microsoft.com/en-us/aspnet/core/tutorials/first-mvc-app/start-mvc?view=aspnetcore-8.0&tabs=visual-studio-code#run-the-app
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/tutorials/first-mvc-app/start-mvc.md
Document ID
46a7c2e0-4871-491f-02c2-54f7df2237b1
Article author
@wadepickett

@chiarapaskulin thanks very much for letting us know.  Will fix.

There are other problems with the tutorial @wadepickett . From Add View onwards. The code doesn't compile/throws error and is way different than the samples provided in Github. It's really confusing

@chiarapaskulin, thanks for letting me know what you are experiencing.  I will test through the tutorial series to see what is going on.
Do you mind telling me what the compile error is you are receiving?  I see that from where you filed this issue in the tutorial it looks like you were using VS Code on macOS correct?
There are three different versions (Visual Studio, Visual Studio Code, Visual Studio for Mac) of this 10 tutorial series.   The series builds the app sample up along with the appropriate database over the course of those tutorials so there are 10 different states of progress building towards the final sample.  Depending on the IDE chosen there are different packages, and it will use either SQL Server Express or SQLite depending on which path is chosen.  So there are a lot of variations.


FIX parsing of @property Tags in DocBlocks

Replaces #223, closes #114, Hopefully, I got it right this time.

I'm having trouble with the PHP 7 Travis build failing. Can't reproduce that, although I'm using the same PHP and PHPUnit versions:

https://github.com/FriendsOfPHP/Sami/pull/224#issuecomment-231035036

You're using same PHP and PHPUnit versions locally and not getting these warnings?

You're using same PHP and PHPUnit versions locally and not getting these warnings?

No the screenshot is from my local machine. I do get the warnings (do you want me to take care of them and change the old tests?), but I do not get the errors that Travis shows, although the versions match. o.O

If no errors on Travis, then you shouldn't take care of that as part of this PR. I guess Travis is using slightly different PHPUnit version where that method isn't deprecated.
What you can do is open an issue about that warning so that can be fixed in separate PR.

Still, I'm getting errors in Travis, too. And my versions of PHP and PHPunit are exactly the same (compare my screenshot and the build summary from Travis CI, PHP 7.0.8 and PHPUnit 5.4.6). I'm a bit lost now, how can I make that build pass?

You can send a separate PR with a fix for getMock method calls. Then once it's merged you'll rebase your PR on top of master branch (of origin repo) and this PR should also pass the build.

I'm not talking about the warnings right now. The Travis build does not fail because of the warnings (I think).
There are errors in the Travis PHP 7 build. Errors that I can not reproduce locally, although my PHP and PHPUnit versions are the same that Travis uses. So I don't know how to fix those errors, since I don't get them locally.

I think there's something wrong with Travis. For example, the first error:

It says that argument 2 passed to phpDocumentor\Reflection\DocBlock::__construct() must be an instance of phpDocumentor\Reflection\DocBlock\Description. But here is phpDocumentor\Reflection\DocBlock::__construct():

Clearly, the second argument is of type phpDocumentor\Reflection\DocBlock\Context. That's strange...

Maybe because you've removed $context->getDocBlockParser()->willReturn(new DocBlockParser())->shouldBeCalled(); line, that set DocBlockParser to the mocked class?

Hmm... I removed that because it doesn't get called anymore in the context of PropertyClassVisitorTest::testAddsProperties(), since it got called out of PropertyClassVisitor::parseProperty(), and that method doesn't exist anymore, because it is no longer needed. Because the parsing now happens when a new ClassReflection object is instantiated, not inside the visitor. (This is how all other tags get parsed, only properties were special up to now, that's why the behavior in #114 occurred).
Keeping that in would result in PHPUnit complaining that a method doesn't get called, although it is supposed to not get called.
The problem is this:
My local machine: PHP 7.0.8, PHPUnit 5.4.6, a specific set of unit tests => no errors
Travis CI build: Same PHP version, same PHPUnit version, same set of tests => errors
Also, the errors complain about types being wrong which are clearly not wrong when you look at the code. There's got to be something wrong here, but I just can't get the hang of it... :(

Keeping that in would result in PHPUnit complaining that a method doesn't get called, although it is supposed to not get called.

I thought, that removing that causes the error you're getting.

There's got to be something wrong here, but I just can't get the hang of it... :(

I recommend to use xDebug to debug test suite and see what's happening inside.

I thought, that removing that causes the error you're getting.

No, keeping that in would result in an error because of the reason I mentioned above.

I recommend to use xDebug to debug test suite and see what's happening inside.

That's the point I'm trying to make. I would love to debug, but I can't, because on my machine, there are no errors. Although my versions of PHP and PHPUnit are the same that Travis uses.

I'm out of Ideas here. My code works, I'm sure. All tests are green (or at least yellow), I'm also sure. The errors that the Travis build yields are no errors, I checked, you can see it in the screenshot above. There is no type error.
I don't want to load you up with work, but could you maybe check out my branch, run the tests with PHP 7.0.8 and PHPUnit 5.4.6 and tell me if you get any errors?
Maybe, but just maybe, this could also be a result of the deprecated method being used? Next thing I'll do is what you told me earlier: fix #225 in another branch, rebase this branch on top of that and see what happens.

I have PHP 7.0.1 locally and not getting that error with same PHPUnit version. Probably something strange happening in PHP 7.0.8 only.

Installed PHP 7.0.8 locally and still not getting those Fatal Errors about wrong context given.

Just like me... getting the warnings, but not the errors. That's really strange. I will try and do as you suggested and fix #225. Maybe this is some kind of weird, unforeseeable followup-error of this. Won't make it today though, I'm on customer support duty today... :-/. I'll see to it ASAP.

You can contact Travis CI support and see if they can help.

Just a heads up: Contacted Travis CI support, currently waiting for reply.

Travis CI support got in touch with me, telling me how to trigger a debug build and debug it via SSH. Will definitely try and see what I can find, might just take a few days since I've got a bunch of tasks to do at work. Not giving up on this!

Travis CI support got in touch with me, telling me how to trigger a debug build and debug it via SSH.

Is this feature documented? It could save me some time, while figuring out why PHP 7 tests for some of my projects are passing locally, but end up on Segmentation fault on same PHP 7 version Travis.

Not giving up on this!

👍

Is this feature documented?

I think not, because it's also not fully integrated in the UI yet. But I could forward you the email with the instructions to the email address in your profile if you like.

But I could forward you the email with the instructions to the email address in your profile if you like.

Please do. The only stuff I could find was using Vagrant boxes, that no longer work.

Just for your information, the problem was PHPUnit uses phpdocumentor/docblock as a dependency like Sami, but with different versions that are incompatible. I've now included a script that creates a phpunit that does not exhibit this problem. So, after rebasing on current master, you can just run ./phpunit instead of the regular one and things will work as expected.

Thank you @Christoph-Harms.


support klusterletconfig with proxyconfig

The related issue: https://issues.redhat.com/browse/ACM-6325

/hold

We may need to upgrade crd yaml used in e2e in this PR as well: cd9b187cca82

@elgnay We may need to upgrade crd yaml used in e2e in this PR as well: https://github.com/stolostron/managedcluster-import-controller/blob/main/deploy/base/config.open-cluster-management.io_klusterletconfig.crd.yaml

Upgraded.

/lgtm

/unhold


feat(stepper): allow for orientation to be changed dynamically

Turns the MatStepper into a proper component that allows consumers to switch between horizontal and vertical dynamically, allowing for use cases like having a different layout depending on the screen size.
Combines the mat-vertical-stepper and mat-horizontal-stepper templates into a single file to avoid all the code duplication.

Relates to #7700.

I prefer this approach, but @jelbourn is the one who pushed for separate horizontal and vertical components, so I'd like to hear what he thinks

@jelbourn is still the idea to wait until angular v7?

It's not set in stone, but there are potential features on the Angular roadmap that would make this a lot easier to do (and in such a way that it can be optimized better).

reasonable enough, we wait. thanks.

What about change the horizontal to work like in guidelines on mobile?
https://material.io/guidelines/components/steppers.html#steppers-types-of-steps
Is that the right approach?

Hi! Any news? This would be really useful,since using *ngIf to switch between horizontal and vertical make duplicates of the components in the steps.

come on guys. This has been a problem for a super long time and is still not adressed? its like you dont want people to use angular material.... will this be addressed in 8.0 beta at least?
wouldnt it be possible to just let us use templateoutet and templateref? those would suffice to fix the stepper issues...

I literally just finished writing this and, yes, it is a bit hacky.  This has not been tested at all.  Use at own risk.
import { Directionality } from '@angular/cdk/bidi';
import { CdkStep, StepperSelectionEvent } from '@angular/cdk/stepper';
import { ChangeDetectionStrategy, ChangeDetectorRef, Component, ContentChildren, ElementRef, EventEmitter, forwardRef, Inject, Input, Optional, Output, QueryList, ViewChildren } from '@angular/core';
import { MatStep, MatStepper } from '@angular/material';
import { DOCUMENT } from '@angular/platform-browser';

const MAT_STEPPER_PROXY_FACTORY_PROVIDER = {
    provide: MatStepper,
    deps: [forwardRef(() => StepperComponent), [new Optional(), Directionality], ChangeDetectorRef, [new Inject(DOCUMENT)]],
    useFactory: MAT_STEPPER_PROXY_FACTORY
};

export function MAT_STEPPER_PROXY_FACTORY(component: StepperComponent, directionality: Directionality,
    changeDetectorRef: ChangeDetectorRef, docuement: Document) {
    // We create a fake stepper primarily so we can generate a proxy from it.  The fake one, however, is used until
    // our view is initialized.  The reason we need a proxy is so we can toggle between our 2 steppers
    // (vertical and horizontal) depending on  our "orientation" property.  Probably a good idea to include a polyfill
    // for the Proxy class: https://github.com/GoogleChrome/proxy-polyfill.

    const elementRef = new ElementRef(document.createElement('mat-horizontal-stepper'));
    const stepper = new MatStepper(directionality, changeDetectorRef, elementRef, document);
    return new Proxy(stepper, {
        get: (target, property) => Reflect.get(component.stepper || target, property),
        set: (target, property, value) => Reflect.set(component.stepper || target, property, value)
    });
}

@Component({
    selector: 'app-stepper',
    // templateUrl: './stepper.component.html',
    // styleUrls: ['./stepper.component.scss'],
    changeDetection: ChangeDetectionStrategy.OnPush,
    providers: [MAT_STEPPER_PROXY_FACTORY_PROVIDER],
    template: `
<ng-container [ngSwitch]="orientation">
    <mat-horizontal-stepper *ngSwitchCase="'horizontal'"
                            [labelPosition]="labelPosition"
                            [linear]="linear"
                            [selected]="selected"
                            [selectedIndex]="selectedIndex"
                            (animationDone)="animationDone.emit($event)"
                            (selectionChange)="selectionChange.emit($event)">
    </mat-horizontal-stepper>

    <mat-vertical-stepper *ngSwitchDefault
                            [linear]="linear"
                            [selected]="selected"
                            [selectedIndex]="selectedIndex"
                            (animationDone)="animationDone.emit($event)"
                            (selectionChange)="selectionChange.emit($event)">
    </mat-vertical-stepper>
</ng-container>
`
})
export class StepperComponent {
    // public properties
    @Input() labelPosition?: 'bottom' | 'end';
    @Input() linear?: boolean;
    @Input() orientation?: 'horizontal' | 'vertical';
    @Input() selected?: CdkStep;
    @Input() selectedIndex?: number;

    // public events
    @Output() animationDone = new EventEmitter<void>();
    @Output() selectionChange = new EventEmitter<StepperSelectionEvent>();

    // internal properties
    @ViewChildren(MatStepper) stepperList!: QueryList<MatStepper>;
    @ContentChildren(MatStep) steps!: QueryList<MatStep>;
    get stepper(): MatStepper { return this.stepperList && this.stepperList.first; }

    // private properties
    private lastSelectedIndex?: number;
    private needsFocus = false;

    // public methods
    constructor(private changeDetectorRef: ChangeDetectorRef) { }
    ngAfterViewInit() {
        this.reset();
        this.stepperList.changes.subscribe(() => this.reset());
        this.selectionChange.subscribe((e: StepperSelectionEvent) => this.lastSelectedIndex = e.selectedIndex);
    }
    ngAfterViewChecked() {
        if (this.needsFocus) {
            this.needsFocus = false;
            const { _elementRef, _keyManager, selectedIndex } = <any>this.stepper;
            _elementRef.nativeElement.focus();
            _keyManager.setActiveItem(selectedIndex);
        }
    }

    // private properties
    private reset() {
        const { stepper, steps, changeDetectorRef, lastSelectedIndex } = this;
        stepper.steps.reset(steps.toArray());
        stepper.steps.notifyOnChanges();
        if (lastSelectedIndex) {
            stepper.selectedIndex = lastSelectedIndex;
        }

        Promise.resolve().then(() => {
            this.needsFocus = true;
            changeDetectorRef.markForCheck();
        });
    }
}

We're on Angular 8 now. I think it's time to revisit this functionality.
Right now, people are wanting different stepper layouts depending on device orientation or screen size. But the child component data gets lost during the transition with a simple switch between the two.
Frankly, I think it's odd that you went this direction in the first place. It may have been a complex component, but to think that this wouldn't be a desired behavior for the component on mobile devices is shortsighted. Optimization should have been secondary to functionality expectations.

@grant77, currently we receive this error when using it:
No provider for CdkStepper!.
Do we need some provider declaration?
And now DOCUMENT is now: import { DOCUMENT } from '@angular/common';

@davideas, Try this:
const MAT_STEPPER_PROXY_FACTORY_PROVIDER = {
  provide: MatStepper,
  deps: [forwardRef(() => StepperComponent), [new Optional(), Directionality], ChangeDetectorRef, [new Inject(DOCUMENT)]],
  useFactory: MAT_STEPPER_PROXY_FACTORY
};

const CDK_STEPPER_PROXY_FACTORY_PROVIDER = { ...MAT_STEPPER_PROXY_FACTORY_PROVIDER, provide: CdkStepper }

export function MAT_STEPPER_PROXY_FACTORY(component: StepperComponent, directionality: Directionality,
  changeDetectorRef: ChangeDetectorRef, docuement: Document) {
  // We create a fake stepper primarily so we can generate a proxy from it.  The fake one, however, is used until
  // our view is initialized.  The reason we need a proxy is so we can toggle between our 2 steppers
  // (vertical and horizontal) depending on  our "orientation" property.  Probably a good idea to include a polyfill
  // for the Proxy class: https://github.com/GoogleChrome/proxy-polyfill.

  const elementRef = new ElementRef(document.createElement('mat-horizontal-stepper'));
  const stepper = new MatStepper(directionality, changeDetectorRef, elementRef, document);
  return new Proxy(stepper, {
    get: (target, property) => Reflect.get(component.stepper || target, property),
    set: (target, property, value) => Reflect.set(component.stepper || target, property, value)
  });
}

@Component({
  selector: 'app-stepper',
  // templateUrl: './stepper.component.html',
  // styleUrls: ['./stepper.component.scss'],
  changeDetection: ChangeDetectionStrategy.OnPush,
  providers: [
    MAT_STEPPER_PROXY_FACTORY_PROVIDER,
    CDK_STEPPER_PROXY_FACTORY_PROVIDER
  ],
...

@grant77 Thank you, it works really great! I created a gist with some more fixes and a nice feature:
Angular 8.x Responsive Stepper with headers disable feature
responsive-stepper.component.ts

Hi, it's v10 now. I'm just wondering what the status of this feature is in the pipeline? It'll be nice to know if it will be supported or not at all as it'll provide some closure rather than waiting for updates to this issue endlessly.

My soul longs for it, updates?

Any solution?

Any solution?

We've decided to revisit this feature, however rebasing this PR is going to take a while and there are better ways of achieving the same result now. I'm closing it in favor of https://github.com/angular/components/pull/22139.


[rust] automatically pickup open ai if there

@baxen maybe this can help as a pattern to auto detect?

cc @jsibbison-square is this no longer needed? (last I looked was for running goosed)

@michaelneale the cli does not go through the server atm so this is irrelevant to cli I think.

@jsibbison-square oh I was more meaning the inverse: does the server need this?


Proposed change to remove whitespace for issue #39370

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #39370
Description:
Issue #39370: whitespace fails the 3rd test with test comparing to a no whitespace example.
Proposed: remove all whitespace before comparing it with the no whitespace example

The linter seems to think the testline should end with a ;. Which, in my understanding, is unnecessary for testStrings enclosed in quotes? @ojeytonwilliams Could you clarify?

The linting issue has to do with...

The two single quotes are for escaping what is in them I believe. But in this case, we want to use them as single quotes in the replace method. When I remove const getValue = firstValue.replace(' ', ''); - it passes. Trying to figure out how to escape those so the method recognizes them as the value.

Trying to figure out how to escape those so the method recognizes them as the value.

We could just wrap the test in double quotes, and use single quotes for in-between.

Or just:
    testString: |
      async () => {
        const waitForIt = (fn) => new Promise((resolve, reject) => setTimeout(() => resolve(fn()), 250));
        const mockedComponent = Enzyme.mount(React.createElement(MyComponent));
        const first = () => {
          mockedComponent.setState({
            name: ''
            TestName ''
          });
          return waitForIt(() => mockedComponent.html())
       };
       const firstValue = await first();
       const getValue = firstValue.replace(' ', '');
       assert(getValue === '

TestName

');
      };

I have added @Sky020's suggested change and a fix to the linting issue.

Congrats on your first pull request (PR), @CheongJY ! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Reset Password does not work from the Admin Panel

Describe the bug
When I am logged in as admin and try to reset a password for another eperson, it will throw an error:
Error when trying to reset password
An error occured when attempting to reset the password for the account associated with the following email address<EMAIL_ADDRESS>The same behavior encountered also in the DSpace 7.5 DEMO website.
To Reproduce
Steps to reproduce the behavior:

Log in as Admin
Go to Access Control -> People -> Edit a Person -> Reset Password

Related:
The Bug was first described in #https://github.com/DSpace/DSpace/issues/8670
However, the angular fix (#2107) did not resolve the problem. In the Network Tab, I see how the request is sent properly (with the correct parameter =forgot), but the Backend responds with 403 Forbidden.
Maybe is something in the backend that should be changed as well?

This bug is only reproducible when Google Recaptcha is enabled.  It doesn't occur if that feature is disabled (which is the default setting).
I'm going to update the title/description to clarify this bug.


ADD_BII_TARGETS() ramp bug? Related to bii_tests?

When porting @pfultz2's Tick to biicode, using Fit CMakeLists.txt file as reference, I changed INIT_BIICODE_BLOCK() and ADD_BIICODE_TARGETS() deprecated calls by ADD_BII_TARGETS().
Now bii configure call fails with
CMake Error: CMake can not determine linker language for target: manu343726_tick_test_test
CMake Error: Cannot determine link language for target "manu343726_tick_test_test".

Note with old deprecated macros it works perfectly.
Here's my fork CMakeLists.txt file.

With new ADD_BII_TARGETS there is not more dummy.cpp. the test that fails is a header with a main() :( so, there is not cpp or c to link. Main in a header? Why?
https://github.com/Manu343726/Tick/blob/master/test/test.h

It's a common main() function included in all test files

Arf. Soooo triky. Just exclude these files from mains in biicode.conf . i think that if you want to launch the tests a cpp is needed.

Ok, worked. Thanks lasote. Have a good weekend.

Oh! I see it now. Tests cpp include test.h
So i think exclude test.h from mains should be enought

ACtually it seems a bug in https://github.com/biicode/client/blob/develop/dev/mains.py#L38:
    for main_cell in cells_with_main:
        # filtering out headers
        if BiiType.isCppHeader(main_cell.name.extension):
            output.info("skipping main function in header file %s" % main_cell.name)
        mains[main_cell.name] = _compute_main_info(main_cell, cells, settings)

C++ Headers cannot define an entry point, so that code intended to skip it, but actually fails to do so.
Should we open an issue with this?


added -s3-force-path-style flag

Added a flag to force path-style addressing during file upload from Selenoid to S3 (i.e. http://s3.amazonaws.com/BUCKET/KEY instead of http://BUCKET.s3.amazonaws.com/KEY), disabled by default.

@nebehr thank you for contribution!


feat: add Angel Vault and Tokemak opportunities

Description

Add oneFOX Angel Vault row to opportunities (note: contract data not yet correct, a different Angel Vault contract has been used as a placeholder - awaiting URL / listing)
Add Fox Tokemak row to opportunities (as discussed on Discord, APR & deposits data not yet available from Tokemak)
Refactor existing component name for consistency in naming convention (MintoneFOX -> MintOneFox)
Add GenericStakingRow component to reduce duplicate code and allow future opportunities to be added faster

Issue
https://github.com/shapeshift/foxfarm/issues/82
Screenshots

@0xApotheosis can we make the 'View APR' CTA you have in the screenshot say "Get started" and then make the 0.00% in the APR column a text link "View APR" ? 🙏

Roger that @willyogo, addressed in https://github.com/shapeshift/foxfarm/pull/83/commits/857c978055cb0c3ea492e93caa0d3a2a5fc651fb + improved UX when no deposit data available.


GH-41199: [C#] Fix accessing values of a sliced decimal array

Rationale for this change
Fixes a bug where getting values from a sliced Decimal128Array or Decimal256Array would return the wrong values.
What changes are included in this PR?
Updates the various Get* methods in Decimal128Array and Decimal256Array to account for the array offset.
Are these changes tested?
Yes, I've added new unit tests.
Are there any user-facing changes?
Yes, this is a user-facing bug fix.

GitHub Issue: #41199

Thanks! Apparently I botched slicing on nearly all the changes I made :/.

To be fair it looks like slicing wasn't considered in a lot of the existing code either so that's understandable


Replace RazorError with RazorDiagnostic in public API

As part of the MVC migration, I had to make RazorError public and use it in a few places in MVC. We need to make it internal again and use RazorDiagnostic in all public API.

There's a WIP commit here https://github.com/aspnet/Razor/tree/rynowak/diagnostics
We should make sure we do this throughout the public API, and then make RazorError and ErrorSink internal again.
This will require a reaction PR is MVC and possibly also entropy.

ed9068cef4b4a73fe01814025476d066ee0ef1b7 and aspnet/Mvc@0f5d5ff3b5f74d0b475c8a6edfcd81bdacad6fe7


LICENSE copyright

LICENCE copyright is still default value, so fix it please.

https://github.com/unitycontainer/unity/blob/1f56087c79b1cd16a2be340741c8f723b5975c16/LICENSE#L189

Do you want to create a PR and help with this one? Perhaps even for other projects as well?


analyzer API: Element.metadata missing for static final fields

Example:
abstract class Foo {
  @Injector()
  static final field = null;

  @Injector()
  static get getter => null;
}

This happened when processing the code using resolved LibraryElement.
Expected Element.metadata corresponding to the FieldElement.getter of field and getter to return 1 ElementAnnotation.
Actually getting 1 ElementAnnotation for getter and 0 for field.
/cc @matanlurey @stereotype441

I believe this is working as intended.  The language spec says that for each final field, a synthetic getter is created, so in a sense the code as equivalent to the following pseudocode:
abstract class Foo {
  @Injector()
  static final field = null;

  static get field => ...; // synthetic getter which gets the value of the field

  @Injector()
  static get getter => null;
}

So FieldElement.getter of field refers to the synthetic getter, which indeed has no annotations.
Putting on my psychic debugging hat, I'm guessing this arose because you are analyzing some code which refers to the field, and since the reference actually resolves to the synthetic getter, you aren't seeing the annotation you expect.  If that's the case, the solution is to check whether the getter you're looking at is synthetic, and if so, look at the corresponding PropertyInducingElement.  (Note: most people probably want to do this, so maybe we should make a convenience method that does this automatically.  What do you think, @bwilkerson ?)

I'd be fine with adding a convenience getter.


Unable to run tests

Expected Behavior
I can clone the repo, install the dependencies and run tests as it is described here.
Current Behavior
Tests can't be run.
Failure Information (for bugs)
Error: Cannot find module<EMAIL_ADDRESS>Please verify that the package.json has a valid "main" entry

Steps to Reproduce

git clone git@github.com:oliver-moran/jimp.git
yarn
yarn test

Context

Jimp Version: current master
Operating System: Mint 19.3
Node version: v12.16.2
yarn version: 1.22.4

Failure Logs

Test run fine now


Update http4s-circe, http4s-dsl to 1.0.0-M35

Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl

from 1.0.0-M34 to 1.0.0-M35.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #201


Fix ignored extraFields option

Thanks. I fixed slightly differently, adding the extend in a different place in https://github.com/aldeed/meteor-tabular/commit/d91296e9b78705e15e3b10f712d254a2e2bab711
The extra fields were already being published from the server, so only the find call needed fixing. There's no need to send the extra fields over the wire since they're already defined in the server code.
Thanks for the PR, though.


font color of "Sonnige Grüße" on energy postcard

not readable in mobile (depending on the data)

resolved by #228


Upgrading to PHP 7.1.4

I've seen several projects today being held up by this same error https://travis-ci.org/realpage/php/jobs/231662421#L1048.  I suspect someone borked something on a dependency.  It doesn't appear to be urgent so I'm going to let it sit till Monday and will investigate deeper at that time if it's not resolved by then.


(PDB-3911) adding pk to resource_events table

This will allow this table to be cleaned with pg_repack instead of relying
on a VACUUM FULL, which avoids locks on the table.

Closing in favor of #2800


Add day interval support to sequence function

Added

[x]  sequence(date, date, interval day to second)

Followup

[ ] [Optimization] Add fast path when step is constant
[ ] sequence(date, date, interval year to month)
[ ] sequence(timestamp, timestamp, interval day to second)
[ ] sequence(timestamp, timestamp, interval year to month)

Followup PR: https://github.com/facebookincubator/velox/pull/4739


arrow keys does not work with vim for navigation

PSReadline (Windows mode - I didn't try Emacs) is conflicting with vim for the arrow keys handling.
To reproduce, install git-for-windows (that's the one I'm using), in powershell with PSReadline enabled, open a file using vim (C:\Program Files\Git\usr\bin\vim.exe), and try to  navigate with the arrow keys: it doesn't work.
Try the same with a powershell without PSReadline: it works.
For what I can see, the problem affects Windows 8.1 (and probably lower), but not Windows 10.

Strange.  I normally use gvim, but do occasionally use vim, so I feel like I should have seen this before if the repro was simple.
What version of PSReadline do you have?
Also worth asking, are you using ConEmu?

I'm using the version PsGet is giving me, <IP_ADDRESS> it seems, according to the changes.txt.
And you are right, I'm using ConEmu. I've tried without it, and I don't see the problem anymore.

OK, closing as this only happens in ConEmu, so unless I hear otherwise, I'll assume it's ConEmu's fault.


Improved SAMD20/SAMD21/SAMR21 clocking mechanism

Signed-off-by: Ionut Catalin Pavel<EMAIL_ADDRESS>There are some issues with the current version of the code, mainly the improper use of the internal OSC8M as a source for the DFLL48m  without division. The DFLL48M is designed to accept a maximum of ~33KHz at it's input, as higher values will bring the multiplier down, leading to instability.
Since there were also some missing features, I've added the following:

Support for external HF oscillator (XOSC) with user selectable frequency
Support for choosing between crystal/external oscillators on XOSC32K/XOSC
Automatic dividers/multiplier computation based on DT cpu frequency
Support for user configurable NVM wait states
Added option to skip clock (re)initialization. Useful in case of chain loading from a bootloader

Tests were performed on a custom SAMD20G18 board using different clock sources and cpu frequencies.
According to the datasheet, architecture is identical on D21/R21.
Clocks were routed to GPIO and observed on a scope.
Due to the nature of the internal architecture and the fact that DFLL48M is not really meant to output anything other than 48MHZ some combinations of requested DT cpu frequency and source frequency will not result in a perfect match.
Mostly insipred by the SAML21 implementation.
First PR on zephyr. Hope I didn't miss anything.

Thanks for the contribution. Please take a look at the Contribution Guidelines and update the commit title and description accordingly.

Thanks for the contribution. Please take a look at the Contribution Guidelines and update the commit title and description accordingly.

Yes, I see now that there are some issues.
Will address them and update the branch.

Seems there still was a TRAILING_WHITESPACE issue left.
Fixed it. Checks should pass now.


PLAT-16501 moon.Input provides validator to prevent inputting invalid number

Issue
This is new UX requirement in 2017 TV.
User can input the invalid value out of correct range. So moon.input provides validator to prevent inputting invalid number.
Fix
I added published variables(min, max) to make range from default values.
Also I implemented change handler to make it dynamically.
If moon.input has number type, min and max value, contexturePopup is shown by validity when user input the wrong number.
Enyo-DCO-1.1-Signed-off-by: Sangwook Lee<EMAIL_ADDRESS>

I would like to have a property of validityCheck to enable or disable this feature. Do validity check only when the value is true and type is number.
The code is in both of Enyo input and Moonstone inputDecorator. But, the code looks like can not use this feature without inputDecorator. So, if you want moonstone specific implementation then it would be better in moonstone only. If you want to move some of code to enyo then the code should not know about moonstone.


Hang in execute_command when connecting to server

Hello,
I am currently loving the library for dealing with Kusto. Recently I have found an issue when using "execute_command" with await where the client just hangs and never comes back causing my application to permanently sit in a blocking state. Are there any timeouts I can set to prevent this?I have tested "server_timeout" with "ClientRequestProperties" and that does no appear to work. Any thoughts on how to solve this ?
Note: I am using execute_command over execute_query to update table data.
Thank you in advance

I was able tor trigger an error message after adjusting some server settings (some info sanitized)
Failed to execute query: AzureError(Error { context: Full(Custom { kind: Io, error: Error { context: Full(Custom { kind: Io, error: reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("place.net")), port: None, path: "/v1/rest/mgmt", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("dns error", Os { code: 11001, kind: Uncategorized, message: "No such host is known." })) } }, "failed to execute reqwest request") } }, "retry policy expired and the request will no longer be retried") })

Hey, I merged in the updated version of the azure library that solves the issue @krishanjmistry mentioned.
Can you try again with the latest master?

I am still testing some things, it now looks like its honoring the client query timeout, but I am still doing more testing and will update this thread when I can confirm more.

I'm closing for now - feel free to reopen if you still encounter the issue.


Release

[x] CLI
[x] docs
[ ] website

Hi, just out of curiosity, sketches are compiled remotely right? Why not compile locally?

@weiway Hello! Thanks for your question.
I realise the README was a little brief in how it explained "why compile remotely?". This tool is aimed for other tool authors to have the ability to compile sketches (should they need to) without needing to give their tool users additional instructions of how to do so. It's intended for magic background work to be done if a sketch needs compiling as part of a flow on another human's machine.
An example of this is would be a typical NodeJS robotics library, that asks a user some questions about their intended robot setup before rolling a bespoke C++ sketch file to flash to their Arduino. This eliminates the clunky step of instructing the user to do the following:

Download the Arduino IDE
Install
Open the IDE
Open the custom sketch produced, or even something like StandardFirmata
Choose the correct Arduino board choice
Click 'upload'
Close the IDE and never open it ever again (likely)
Feel confused and a little frustrated at this weird tangent when they just wanted to start writing cool Nodebots stuff.
Realise you've asked the user to use 140MB+ of their data limit for a tiny step (data limits and internet speeds are still a common issue outside of the US).

We have tools such as avrdude and avrgirl-arduino to take care of the "flashing to the board" stuff, so this project is addressing a gap in the nice magic flow we can provide to a first time robotics user (or other use cases, whatever rocks your boat).

As an aside, it was in the plan to allow a 'local override' for avr-pizza, so that a local installation of the Arduino IDE could be used if preferred (no internet connection, faster, etc). This has been soft released as of today in v0.1.0, and I have also expanded the "what is this" section in the README to provide more info on why remote compilation can be useful.
Hope this helps, and thanks again for reaching out! 🍕
-- @noopkat


Add support for Yi models.

Adds support for 01-ai/Yi models.
Quantization/inference tested with 01-ai/Yi-6B
Set transformers=>4.34.0 even though the model is not supported by it yet, this was the req in their repo.
Use trust_remote_code=True
Since the model is actually very close to Llama, FusedLlamaAttentionForQuantizedModel and FusedLlamaMLPForQuantizedModel are added. I tested them and if they actually were used(no errors, same output) then they should be working. I'm not 100% since it seems triton isn't working and I had to make my own fix which seemed to work.(not in this PR. Added **kwargs to qlinear_triton init)
@TheBloke would be great if you could do a bit of a sanity check.

Confirming this seems to work great!
Only slightly odd thing is I had a report that my Yi 34B 200K GPTQ made with this PR wouldn't then load in ExLlama, which added Yi specific support recently.  But I've not confirmed that yet and it may well be an ExLlama issue
As to making a Yi quant with AutoGPTQ and then loading that Yi quant with AutoGPTQ, this PR works great.  Thank you!


[Agent v9 core] Add support for Java Extension Class Loader.

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.
[x] Update the documentation to include this new feature.
[x] Tests(including UT, IT, E2E) are added to verify the new feature.
[ ] If it's UI related, attach the screenshots below.
[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #https://github.com/apache/skywalking/issues/3661.
[x] Update the CHANGES log.

To @apache/skywalking-committers
I am planning to bump up the version of Java agent after this gets merged. 9.0.0 would be the next major version to indicate we added Extension ClassLoader support in the core level.
First and most importantly, this credit and contribution belongs to @daimingzhi. I am just finishing this PR with a little conflict resolving, polishing, and fix a little error in the plugin test.
Extension ClassLoader
Extension ClassLoader: The Extension ClassLoader is a child of Bootstrap ClassLoader and loads the extensions of core java classes from the respective JDK Extension library.
It loads files from jre/lib/ext directory or any other directory pointed by the system property java.ext.dirs.
User decides which parts of the service should be loaded by the extension classloader, so, we open plugin.plugins_in_ext_class_loader=${SW_PLUGINS_IN_EXT_CLASS_LOADER:} in the agent.config file.
Through this setting, users declare plugins are for excClassloader. Multiple values should be separated by ",".
Also support wildcard(\*),like ehcache\*.

This PR originally started at https://github.com/apache/skywalking-java/pull/19, @daimingzhi and I have a long discussion about this topic there.

To reviewers(@apache/skywalking-committers), when you merge this, please make sure we have @daimingzhi listed as a co-author of this PR. Because of squash and merge policy, this PR will belong to my account I am afraid. Let's keep the track correctly and respect our contributor.

I noticed precious plugin test codes didn't verify this feature. Because Spring classloader includes target jars in the Spring fatjar, which means the httpclient jars are not loaded through ext-classloader.
Let me fix this test case.

An update, -Djava.ext.dirs is obsolete

@daimingzhi According to JDK 11 is widely used and recommended to use. JDK8 would be the only LTS JDK.
JDK8 EOF update

After January of 2019, only customers who have signed a support contract with Oracle will still receive security updates for Oracle JDK 8.
Maintenance for OpenJDK 8 is planned for at least another 4 years, until September 2023. 2 years left for EOL.

So, generally, according to the roadmap of JDK, java.ext.dirs should be replaced by cp or classpath. I will close this PR with original one as well. But I will add a FAQ doc to say what is going on, if user wants to try this draft feature, feel free to download and try.

Same as this reason, I would NOT bump up agent version to v9. Let's stay in v8 for longer.


[Candidate 3v3 Philippine Highlands] Oil derrick clips into terrain

Issue Description
One oil derrick clips into terrain.
Expected behavior
No oil derrick clips into terrain.
Screenshots

I'll work on this one as well


Correct windows.mutablePackageDirectories example

@riverar : Thanks for your contribution! The author(s) have been notified to review your proposed change.