[P1] Compatibility with tooling that expects a HF transformer model

I'm raising the issue that in terms of "production readyness" (statet goal) pyreft, designed as a very thoughtful  library, will need to work together with tooling that expects a loadable vanilla transformer model. A real world reproducible example is loading a pyvene trained model with https://github.com/outlines-dev/outlines in order to create structured json/ schema following outputs.
While the model can be accessed via pyref_model.model - it is not loadable, and in any case one tool would miss the other's functionality when loaded this way. What would be a advisable strategy to integrate with other tooling? May I suggest also different backend engines (e.g. vllm, ollama, llama.cpp)  will need to have have interfaces to pyreft. Maybe I'm overseeing some documentation here but I'm unsure how to proceed.
Is merging a pyvene intervention into the base model possible or is pyvene/pyreft more of an active component that will require code changes in any case?

Hey! So:

We got similar questions on Twitter about accelerating inference with different backends (vllm, mlx, etc.) Currently, pyvene is a major dependency for which no alternative exists: it manages the torch hooks that are used to intervene on hidden representations at the token-level in pyreft. To enable support for non-HF and/or non-torch models, we would need to replicate some pyvene functionality. We have thought about how to do this simply without needing to port pyvene entirely[^thoughts], but it's a long-term software engineering task that we don't immediately have the time/resources/people for. Maybe in the summer once pyreft is known to be stable for a variety of models + tasks, we will invest time into this.
The LoReFT intervention can't be merged into the base model for two reasons. (1) It is a complex function applied directly to the hidden state, so it operates differently than existing model components (which add to the hidden state via residuals) and so can't be folded into them as far as we can tell. (2) It operates only on some tokens, not all, but model weights are the same for every token.

So overall, using LoReFT in a model requires either torch-style hooking functionality or code changes to the model to support token-level interventions.
[^thoughts]: E.g. we could just load pyvene for the KV-cache population when processing the prompt, and then use the efficient backend for generation. But in the future, we want to support intervention on decoding steps as well which is messier.

assigning with P1 since there is no blocker.


fix main branch build

Signed-off-by: Florin Coras<EMAIL_ADDRESS>Additional Description: main branch build broken
Risk Level: low
Docs Changes: n/a
Release Notes: n/a

/retest


Track the progress of the user by counting how many tasks the user checked off as done.

Track the progess of the user by counting how many tasks the user checked off as done.

Duplicate of #117


(Feature Request) - Accessibility Testing support

Bug Report or Feature Request (mark with an x)
- [x ] feature request

Desired functionality.
Accessibility testing
Is it possible to include tools like axe or pa11y
for accessibility testing into the CLI?

Is there anything that stops you from adding them to a project right now? We try not to add extra tooling dependencies if possible, but if there's something that breaks usage of those tools maybe we can fix it.

No there is nothing stopping me from adding it currently. I just think that accessibility testing should be taken seriously and having it baked in into the CLI would reduce the friction to getting started, but I also understand that it might not a priority at the moment.

Maybe we could add something as a flag e.g ng e2e --accessibility.

I agree with @sfabriece , this is also something I would like to see as well.

@filipesilva that would be definitely welcome. Not to mix issues but maybe adding something like Lighthouse that supports customization would be useful as well. Then accessibility would be added as part of it. Just a thought, but not sure if the added functionality is needed.


discard unneeded keys

At some point, we should stop accepting crypto packets (some time after the handshake completes).
There's probably also a sophisticated way to stop accepting initial packets when moving to handshake encryption level.

See https://github.com/quicwg/base-drafts/pull/2045.


[Slider] Remove not needed mark in range Sliders

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Whenever both the start and the end points have been dragged to the end of the slider an extra mark has been added at the end of the slider which is visible when both the drag points aren't at the end.
Expected behavior 🤔
The extra mark in the slider must be removed and retain the required marks that has been provided in the props.
Steps to reproduce 🕹
Steps:

Add marks to the range slider for both range start and end as follows.

Drag both the range points to the end of the slider.

Now drag both the range points from the end to another position.

Now we will be able to get three marks where the third one isn't a required one and must have been removed.

Context 🔦
We have been using the range slider for a requirement in our project, where the user needs to choose certain range and the user needs to be provided with the labels of their selections. Since the marks might overwrite one another we needed to keep the marks to the minimal amount, In this case its getting added up by one.
Your environment 🌎

`npx @mui/5.5.2`
  Chrome latest version
  Output from `npx @mui/5.5.2` goes here.

Hi @SooriyanDSRC, could you please provide a codesandbox showing the problem? It may be that a certain combination of props causes the problem.

I face the same issue. @michaldudak here is a codesandbox link in case it helps.
https://codesandbox.io/s/material-demo-forked-tlu40e?file=/demo.js

Right, definitely a bug. Would you like to contribute to the project and look for a fix?

@michaldudak Sure, I would be happy to work on the fix. The issue seems to be arising due to both marks having the same key as shown in the below image.

How does this look?
diff --git a/packages/mui-base/src/SliderUnstyled/SliderUnstyled.js b/packages/mui-base/src/SliderUnstyled/SliderUnstyled.js
index 4536cbe2c1..5559e274d4 100644
--- a/packages/mui-base/src/SliderUnstyled/SliderUnstyled.js
+++ b/packages/mui-base/src/SliderUnstyled/SliderUnstyled.js
@@ -210,7 +210,7 @@ const SliderUnstyled = React.forwardRef(function SliderUnstyled(props, ref) {
           }

           return (
-            <React.Fragment key={mark.value}>
+            <React.Fragment key={index}>
               <Mark
                 data-index={index}
                 {...markProps}

Looks good to me. Please create a PR with this change.

@michaldudak Created the PR #33526


Sensors and mass properties

Objective
I was surprised to find that a sensor added as a child of a dynamic body affected the parent's behavior. Even with the density set to zero the difference was noticeable.
Solution

Make the default mass and density zero for sensors.

and/or:

Ignore sensors when updating parents' mass properties.

Maybe instead of adding a special case for sensors (which would be a breaking change), a note should be added to the sensor documentation indicating you need to set the mass properties to zero if you don't want to affect any parents?

Changelog
tbd
Migration Guide
tbd

Hi, I do agree we should change this. I looked into it a bit, and it seems like the sensor equivalents in Godot (Area2D/Area3D) and Unity (trigger property) also don't contribute to the mass properties of the rigid body.
I think the semantics we should go for are that sensors don't affect physics at all, and are only for detecting intersections. The way I would do this is slightly different from this PR though:

Don't run update_collider_mass_properties for sensors. This PR already does this :)
When Sensor is added to a collider, remove the collider's mass properties (if any) from the rigid body's mass properties.
When Sensor is removed from a collider, update the collider's mass properties and add them to the rigid body's mass properties.

I think this could be implemented robustly in Bevy 0.14 using component lifecycle hooks. Notably different from this PR, I would not make the default ColliderDensity zero, because it is rather implicit, and if I later removed the Sensor component from the collider, I would expect that it would have mass properties again like a default collider.
Do you mind if I adopt this and implement it for the upcoming Bevy 0.14 update with lifecycle hooks? I can still add you as a co-author :)

All that sounds good. Thanks for taking a look.

Closing in favor of #381 :)


Scroll lag

Fragment(idk what it is in flutter, container?) starts lagging when scrolling up too far in the message history.
To reproduce, scroll up a little bit, and then hit the scroll to bottom button. You'll see it's still smooth. Scroll up 100 or so messages, and it massively stutters when you hit scroll to bottom.

Any idea if you have a lot of hyperlinks? Or is it just normal messages?

It's mostly normal messages.


269

specific file missing error when IntendedFor file din fieldmap json is checked. Also added test for the same.

Closes #269.

Hey @ntraut,
with process.nextTick(cb);, validators skipped checking for IntendedFor field completely(or didn't give any errors) even when files listed in IntendedFor in the json didn't exist.
I have made following  two changes. Wanted you to take a look:
i) Changed async.eachOfLimit() to 'async.forEachOf()' . Here.
As per @chrisfilo suggestion i tried both eachOfLimit and forEachOf. They both work fine but only with explicit call back cb(). Can you share more on switching to using async.eachOfLimit() method?
ii) process.nextTick(cb) to cb()

Hello, here is the reasons why I made those changes:
i) async.eachOfLimit()
It prevents Node from opening too many iterations in parallel. The risk is that is too many files are opened in the same time and the system limitations are exceeded.
ii) process.nextTick(cb)
With a direct call to cb(), each call add itself to the stack and if there is too many iterations the call stack limit can be exceeded.
Normally the way of functioning of async.eachOfLimit() is that each time an iteration is over it free the place for the next ones, so I do not see why it would prevent some iterations or code to be executed...

It is possible that async.eachOfLimit() also solves the problem that process.nextTick(cb) is supposed to settle, but async.eachOfLimit() is mandatory for data sets with a large number of files.

Thank you @ntraut! I have made changes to use async.eachOfLimit() and cb().
Closes #269

One remaining thing is to add a test with a correct IntendedFor information.

@ntraut @chrisfilo
My bad. Previously i tried  this PR edits only on smaller dataset hence confirmed that its working but apparently it doesn't.

When i use async.eachOfLimit() and cb(), it does throw error where intended files are missing but doesn't work for large datasets.

Keeping async.eachOfLimit() as it is and changing cb() to process.nextTick(cb) doesn't throw error about IntendedFor missing files at all..

@suyashdb
I'm sorry. With process.nextTick, do you get the bug even with small datasets?
Can you provide an example dataset with which you get the bug?
If I can help...

@ntraut
can you clarify what you mean by bug given we are talking about two issues here:

validator not throwing error regrading missing intendedfor files
validator not able to handle large dataset..

Looks like we don't have large published dataset with fieldmap images that can help you as a test dataset. I am working on one but its still unpublished.

If I understand correctly the bug 1. is when process.nextTick is used and happens with all sizes of dataset. I just wanted to be sure and was asking if there were an avaible dataset with which I could reproduce this bug.

@ntraut - yes your understanding is correct. Can you try using ds000223. For first 5 subjects they have fmap data and hence IntendedFor in jsons. Try deleting the files in IntendedFor field.
With current master(which uses process.nextTick), validator shouldn't raise any error that IntendedFor file is missing.

OK, I saw the problem: if the file linked by the IntendedFor field is missing, the test is done and an issue is raised even with process.nextTick. But because it is raised in a async loop, the issues variable of the function NIFTI is already returned at this time.
I guess the reason it works with hard cb() calls is that with them the code is not really executed asynchronously.
Two solutions would be possible:

give up async.eachOf and come back to an old for loop.
rethink the architecture of the code for a proper asynchronous management.


Split websocket and http into two modules

Description:
At the moment both protocols are in the same module. But ideally it should be in two different modules.

The task is completed via https://github.com/ballerina-platform/module-ballerina-websocket/pull/1


element-{web,desktop}: 1.10.9 -> 1.10.10

Description of changes
ChangeLog: https://github.com/vector-im/element-web/releases/tag/v1.10.10

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 168754 run on x86_64-linux 1

2 packages built:

element-desktop
element-desktop-wayland

Tested and works for me. Thanks!


Track sort descriptor in url

Coming hot off #1097, this PR stores the column sort descriptor in a URL param 😄

I'm starting to think about some alternatives to this...
The real problem I'm trying to solve is that I'd love to apply a default sort to my collection of posts, e.g. reverse chronological by publishDate. Having sort params persisted in the URL is nice, but still doesn't totally solve that problem.
Perhaps adding a sort callable function option or defaultSortBy + defaultSortDir options to the collection definition would be a better approach?

OK, I PRed this alternate approach here, and I think I like it better than simply tracking params in the URL https://github.com/Thinkmill/keystatic/pull/1110


Some problem on bios H0059and 15.2

Hi bro !
Thank you for your contribution for HAC-mini.Rescently l use your method(the third one,update from clover,l installing 15.2 by clover).by the way,lm the new one on hack mac,know very few about the macOs,and Clover .but know well about XML(lm a developer of JAVA in China)
First,the BooterMenu,Showing as you say,if l didnt choose that selection,My HVK window
is directly black.But l chosse that ,it we display a menu for me to chose which boot you wanna?(1.efi,2lulu(MACOD),3.recovery partition and so on). l dont know it just my problem or not?
Second.the safari s TAG have version peoblem,Truddy; Third,the hac every call me regist my icloud count everyDay,and after ever registion l will find a new mac in my icloud.l know the problem is my hacs device uuid.just copy the OC`s fullsimple.plist can correct this problem?

Clover is no longer supported and the config.plist is outdated and not expected to work.

sir you means that?l need modify my .plist by my self?Almost all the parameters?

sir you means that?l need modify my .plist by my self?Almost all the parameters?

There’re documents about how to use opencore. If you use hades canyon, you can simply use releases of HaC Mini.

3Q verymuch


fix: Make sure engine works with minio object storage

Refactor code and update configs to support local minio object storage in engine.
There is one thing I couldn't fix since I didn't have much time. Webapp formats dataset minio path and sends it to graphql
in the form s3a://localhost:9000/22735870-552d-4a56-9f03-75f6192b033a while it should be
s3a://<BUCKET_NAME>/22735870-552d-4a56-9f03-75f6192b033a.
I guess it's caused by the webapp's util.getS3Bucket function that picks bucket name from the host name.

@intsco thanks very much for this! Do you like the design of the util functions? Would you prefer to do this another way?

@richardgoater No, I don't have any preferences for the webapp code. What I meant is that getS3Bucket should be fixed/updated to support extraction of bucket name from minio object paths.

@intsco I meant your preference on the Python code :) I can work on the bucket "parsing", though I feel like the name of the bucket should be in the response separately.

@richardgoater Based on the quick discussion during the sprint meeting, I have added support for moldb imports using minio object paths. It mostly works, I tested it locally but a small webapp fix is needed here too (see the updated PR description).


Exceptions are thrown when references outlive BinaryView

Version and Platform (required):

Binary Ninja Version: 3.5.4304-dev
OS: Arch Linux
CPU Architecture: x64

Bug Description:
Running the following script:
import binaryninja

with binaryninja.open_view('/bin/cat') as bv:
    meow = bv.functions

Yields the following output:
Exception ignored in: <function FunctionList.__del__ at 0x7fb2597e5800>
Traceback (most recent call last):
  File "/home/maya/binaryninja/python/binaryninja/binaryview.py", line 1884, in __del__
AttributeError: 'NoneType' object has no attribute 'BNFreeFunctionList'

Fixed in 3.5.4323


Mac: Investigate hangs during shutdown when virtualization root is attached

Sometimes when our kext is loaded and a provider is running, even if we're not actively triggering I/O in the virtualization root, if you shutdown or reboot the machine the shutdown will 'hang' on a black screen.  My theory is that something about the state our kext is in makes it impossible to be unloaded (or we're in a deadlock).
Partial repro steps (doesn't repro 100% of the time, but will frequently):

Load kext and mount a provider
Run some I/O through the provider (or get lucky with some background I/O like a crawler interacting with our kext).
'sudo reboot'
The reboot won't finish and the machine will hang on a black screen

Running applications/daemons will be terminated (sshd, agent.listener, screensharingd) so we can't remotely connect to investigate. However, the machine can still be pinged by IP address so some services are still running on the machine.

I have a strong suspicion this is because we're not flushing outstanding messages (s_outstandingMessages) when a provider disconnects. When you disconnect a provider manually, your system is usually in a steady state, so chances are there aren't any outstanding messages. On reboot, a lot is going on in the system, and the provider will be violently disconnected, so it can easily happen that there are outstanding messages waiting for the provider that has just died.
The solution is of course to flush any such messages in ActiveProvider_Disconnect(). Preferably, the list of outstanding messages should be per virtualisation root, which would make this a lot easier. Additionally, it'll make the search handling a reply message easier too. (and prevent providers from replying to other providers' messages)
I'm doing some work in this area anyway (#284) so I'd be happy to sort this out.

To answer your question about debugging this, connecting with a kernel debugger should work, yes. You'll want to enable break-to-KDP with an NMI (debug bit 0x4 in boot-args, and by my personal preference, I also enable bit 0x8000 so I don't have to press that ridiculous key combo). If it's late enough in the reboot process that networking has been torn down, you probably will struggle with ethernet kdp, but it should still work with firewire, although that's only really an option on a real Mac.
For hangs like this, a core dump should of course also work instead of a kdp session.

@nickgra Now that disconnecting providers no longer causes indefinite waits in threads that had pending messages at time of disconnect, can you still repro this issue?

I have just encountered an instance of this bug, or a variation on it. (Hang on the shutdown activity spinner, not a black screen.) Luckily this was on my test Mac Mini with a Firewire cable attached, so I could attach a kernel debugger and get stack traces of the stuck thread(s). For example:
  thread                   thread_id  processor            base   pri    sched_mode      io_policy       state    ast          waitq                            wait_event           wmesg                thread_name
  0xffffff8029a06000  [WQ] 0x4ab8     0xffffff800a9e13b8   37     46     timeshare                       WU       QAI          0xffffff81c4f54e40               0xffffff80475a489c   vnode_drain
    kernel_stack = 0xffffff91fff38000
    stacktop = 0xffffff91fff3b990
    0xffffff91fff3b990 0xffffff800a18460d machine_switch_context((thread_t) old = 0xffffff8029a06000, (thread_continue_t) continuation = 0x0000000000000000, (thread_t) new = 0xffffff802761d780)
    0xffffff91fff3ba10 0xffffff800a08967a thread_invoke((thread_t) self = 0xffffff8029a06000, (thread_t) thread = 0xffffff802761d780, (ast_t) reason = 0)
    0xffffff91fff3ba60 0xffffff800a08863f thread_block_reason((thread_continue_t) continuation = <>, , (void *) parameter = <>, , (ast_t) reason = <>, )
    0xffffff91fff3baa0 0xffffff800a07d4fe thread_block [inlined]((thread_continue_t) continuation = <>, )
    0xffffff91fff3baa0 0xffffff800a07d4f3 lck_mtx_sleep((lck_mtx_t *) lck = 0xffffff80475a4838, (lck_sleep_action_t) lck_sleep_action = 0, (event_t) event = 0xffffff80475a489c, (wait_interrupt_t) interruptible = <>, )
    0xffffff91fff3bb20 0xffffff800a52faa6 _sleep((caddr_t) chan = 0xffffff80475a489c "\x02", (int) pri = 20, (const char *) wmsg = <>, , (u_int64_t) abstime = 0, (int (*)(int)) continuation = 0x0000000000000000, (lck_mtx_t *) mtx = 0xffffff80475a4838)
    0xffffff91fff3bb60 0xffffff800a29ab28 msleep [inlined]((int) pri = 20, (const char *) wmsg = 0xffffff800a787882 "vnode_drain")
    0xffffff91fff3bb60 0xffffff800a29ab0f vnode_drain [inlined](void)
    0xffffff91fff3bb60 0xffffff800a29aadf vnode_reclaim_internal((vnode *) vp = 0xffffff80475a4838, (int) locked = 1, (int) reuse = 1, (int) flags = 0)
    0xffffff91fff3bbd0 0xffffff800a29ee4f vflush((mount *) mp = 0xffffff8027d91cc0, (vnode *) skipvp = <>, , (int) flags = 27)
    0xffffff91fff3bc70 0xffffff800a2a9cc5 dounmount((mount *) mp = 0xffffff8027d91cc0, (int) flags = 524288, (int) withref = <>, , (vfs_context_t) ctx = 0xffffff803611db30)
    0xffffff91fff3bca0 0xffffff800a2a0112 unmount_callback((mount_t) mp = 0xffffff8027d91cc0, (void *) arg = 0xffffff91fff3bd20)
    0xffffff91fff3bd10 0xffffff800a29a1c8 vfs_iterate((int) flags = <>, , (int (*)(mount_t, void *)) callout = 0xffffff800a2a0060 (kernel`unmount_callback at vfs_subr.c:3039), (void *) arg = 0xffffff91fff3bd20)
    0xffffff91fff3bd30 0xffffff800a29fdb3 vfs_unmountall(void)
    0xffffff91fff3bdf0 0xffffff800a529554 reboot_kernel((int) howto = <>, , (char *) message = 0xffffff91fff3be10 "")
    0xffffff91fff3bf40 0xffffff800a5407ef reboot((proc *) p = 0xffffff8027fea240, (reboot_args *) uap = 0xffffff803611d9d8, (int32_t *) retval = <>, )
    0xffffff91fff3bfa0 0xffffff800a6041e8 unix_syscall64((x86_saved_state_t *) state = <>, )
    0x0000000000000000 0xffffff800a0209c6 kernel`hndl_unix_scall64 + 0x16
    stackbottom = 0xffffff91fff3bfa0

Inspection with the kernel debugger showed that this is stuck waiting for the iocount on one or more virtualisation root vnodes to drop to 0:
(lldb) showvnode 0xffffff80475a4838
vnode                usecount  iocount v_data               vtype  parent               mapped cs_version name
0xffffff80475a4838          0        2 0xffffff80475a7a48   VDIR   0xffffff80475a3ba0   -      -      src

Evidently we're leaking iocounts on roots. I think this may be related to unloading the kext while active providers are attached, so I'm going to test that hypothesis and if correct, I should be able to come up with a fix fairly quickly.


Title does not dim anymore in Obsidian, v1.0 update

With the new update to Obsidian to version 1.0, the ability to dim the title doesn't work anymore. The reason for this is, they changed the way in which the implemented the title.

This was resolved in 1.3.1 which is now live through the app.


Allow using Google Groups for auth approval

I'm not sure if https://github.com/thomseddon/traefik-forward-auth/issues/162 is the same thing and if it is I'm sorry please close me.
Basically allowing us to put users inside a specific group and allowing only those users within the group to be returned with a valid oauth token. Currently I'm using different tld for each service and having many different accounts within different tld can get confusing for the end users.
Thanks!

Thanks - I'd also like to see this, I've dug into 162 a little more as my intention was to use that to track group support. I'll open another issue if that's doesn't fit the authors intention

Thanks - I'd also like to see this, I've dug into 162 a little more as my intention was to use that to track group support. I'll open another issue if that's doesn't fit the authors intention


feat: Make it possible during tests to access internal state for components

Feature Request
Describe the Feature Request
When testing contracts that include components, it is currently impossible to use Contract::contract_state_for_testing to access state variables that defined inside the component itself.
It would be great if it were possible to access internal state of components inside tests.
Describe Preferred Solution

Describe Alternatives

Related Code

working example using Contracts (without components):

#[starknet::interface]
pub trait ICounter<TContractState> {
    fn increment(ref self: TContractState);
}

#[starknet::contract]
pub mod Counter {
    #[storage]
    struct Storage {
        value: u32
    }

    #[abi(embed_v0)]
    impl Counter of super::ICounter<ContractState> {
        fn increment(ref self: ContractState) {
            self.value.write(self.value.read() + 1);
        }
    }
}

#[cfg(test)]
mod tests {
    use core::starknet::storage::StorageMemberAccessTrait;
    use starknet::syscalls::deploy_syscall;
    use starknet::SyscallResultTrait;
    use super::Counter;
    use super::{ICounterDispatcher, ICounterDispatcherTrait};
    use starknet::{ContractAddress, testing::set_contract_address};

    fn setup_counter() -> ICounterDispatcher {
        let (address, _) = deploy_syscall(
            Counter::TEST_CLASS_HASH.try_into().unwrap(), 0, array![].span(), false
        )
            .unwrap_syscall();
        ICounterDispatcher { contract_address: address }
    }

    #[test]
    fn test_increment_event_contract() {
        let counter = setup_counter();
        set_contract_address(counter.contract_address);
        let mut state = Counter::contract_state_for_testing();
        assert_eq!(state.value.read(), 0);
        counter.increment();
        assert_eq!(state.value.read(), 1);
    }
}

the same example refactored to use a component, which should work the same way as the previous example:

#[starknet::interface]
pub trait ICounter<TContractState> {
    fn increment(ref self: TContractState);
}

#[starknet::component]
pub mod countable_component {
    #[storage]
    struct Storage {
        value: u32
    }

    #[embeddable_as(CounterImpl)]
    impl Counter<
        TContractState, +HasComponent<TContractState>
    > of super::ICounter<ComponentState<TContractState>> {
        fn increment(ref self: ComponentState<TContractState>) {
            self.value.write(self.value.read() + 1);
        }
    }
}

#[starknet::contract]
mod Counter {
    use super::countable_component;

    component!(path: countable_component, storage: countable, event: CountableEvent);
    #[storage]
    struct Storage {
        #[substorage(v0)]
        countable: countable_component::Storage,
    }

    #[event]
    #[derive(Drop, starknet::Event)]
    enum Event {
        CountableEvent: countable_component::Event
    }

    #[abi(embed_v0)]
    impl CounterImpl = countable_component::CounterImpl<ContractState>;
}

#[cfg(test)]
mod tests {
    use core::starknet::storage::StorageMemberAccessTrait;
    use starknet::syscalls::deploy_syscall;
    use starknet::SyscallResultTrait;
    use super::Counter;
    use super::{ICounterDispatcher, ICounterDispatcherTrait};
    use starknet::{ContractAddress, testing::set_contract_address};

    fn setup_counter() -> ICounterDispatcher {
        let (address, _) = deploy_syscall(
            Counter::TEST_CLASS_HASH.try_into().unwrap(), 0, array![].span(), false
        )
            .unwrap_syscall();
        ICounterDispatcher { contract_address: address }
    }

    #[test]
    fn test_increment_event_contract() {
        let counter = setup_counter();
        set_contract_address(counter.contract_address);
        let mut state = Counter::contract_state_for_testing();
        assert_eq!(state.value.read(), 0);
        counter.increment();
        assert_eq!(state.value.read(), 1);
    }
}

Additional Context
https://github.com/starkware-libs/cairo/issues/5044
If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[x] No

Don't know enough Rust.

have you tried using state.countable.value? - as .value is not a member of the contract state.

have you tried using state.countable.value? - as .value is not a member of the contract state.

That solved the issue, thanks!
For some reason I didn't realize that you could access the countable substorage, I guess this is an issue with autocomplete dialog (see https://github.com/starkware-libs/cairo/issues/5660#issuecomment-2183565469).
Closing the issue.


We are getting the error "pdflib:17785 Uncaught (in promise) TypeError: fontkit.create is not a function"

What were you trying to do?
We are using the Salesforce LWC components, where using the custom fonts with the download functionality, but we are getting the  "pdflib:17785 Uncaught (in promise) TypeError: fontkit.create is not a function" once downloading the custom fonts with the Fontkit library.
Could you please share the correct Fontkit library, so we can use it here.
How did you attempt to do it?
We are using the Salesforce LWC components, where using the custom fonts with the download functionality, but we are getting the  "pdflib:17785 Uncaught (in promise) TypeError: fontkit.create is not a function" once downloading the custom fonts with the Fontkit library.
Could you please share the correct Fontkit library, so we can use here.
What actually happened?
We are using below 2 lines to import the static pdfLib and Fontkit library in our salesforce database.
import pdflib from "@salesforce/resourceUrl/pdflib";
import fontkit from "@salesforce/resourceUrl/fontkit";
While we ar using the below code, we are getting the error after  pdfDoc.embedFont() function.
const pdfDoc = await PDFLib.PDFDocument.create();
pdfDoc.registerFontkit(fontkit);
const timesRomanFont = await pdfDoc.embedFont(
fontBytes
);
What did you expect to happen?
It should download the PDF file with the custom fonts
How can we reproduce the issue?
async createPdf() {
//const fontkit = pdflib;
loadScript(this, fontkit).then(() => {
console.log('fontkit loded');
});
console.log('fontkit : '+fontkit);
///LightningMemberPortal/resource/OLDENGL/OldEnglishFive-axyVg.ttf
//const url = specFontsOLDENGL+'/OldEnglishFive-axyVg.ttf';
    const url = specFonts+'/oldenglishfivefont/OldEnglishFive.ttf';
    console.log('url : '+url);
    const fontBytes = await fetch(url).then(res => res.arrayBuffer());

    console.log('fontBytes : '+fontBytes);
    console.log(fontBytes);

    const pdfDoc = await PDFLib.PDFDocument.create();

    pdfDoc.registerFontkit(fontkit);
    debugger;

    const timesRomanFont = await pdfDoc.embedFont(
        fontBytes
    );

    const page = pdfDoc.addPage();
    const { width, height } = page.getSize();
    const fontSize = 30;
    page.drawText('View certificate for the AKA', {
      x: 50,
      y: height - 4 * fontSize,
      size: fontSize,
      font: timesRomanFont,
      color: PDFLib.rgb(0, 0.53, 0.71),
    })

    const pdfBytes = await pdfDoc.save();
    this.saveByteArray("AKA Certificate", pdfBytes);

  }

Version
We are using the latest version of pdf-lib
What environment are you running pdf-lib in?
Other
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

I am also getting this issue in Salesforce. Do we have a workaround while we wait for the fix?


Benny/jwt middleware

Changes:

Added jwt middleware function that will add a value to context including whether the user is authenticated with a jwt and if so their user address (what is this address that is being stored in the jwt claims?)
Added the middleware to the functions that were verifying jwt's and used context to determine the cases where the authentication information was needed
Changed auth db to no longer store jwts and no longer handle anything related to jwts and http
Changed the verify jwt func to also return the address from the claims it parses

Considerations:

Middlewares currently require a parameter hell to create because gf_core.http_handler is private meaning that instead of func middleware(gf_core.http_handler, pRuntime) gf_core.http_handler we have func middleware(midd func(pCtx context.Context, pResp http.ResponseWriter, pReq *http.Request) (map[string]interface{}, *gf_core.Gf_error), pRuntime *glry_core.Runtime) func(context.Context, http.ResponseWriter, *http.Request) (map[string]interface{}, *gf_core.Gf_error). Do we want to adjust the way we handle http, possibly write different http wrappers, use another library, etc.?
Previously, the secret signing key that was being used to sign the jwts was a randomly generated string that was stored with the jwt in the database. Because we are trying to move to stateless jwt, this is harder to do. Option one (currently implemented) is using an env variable as a secret for all jwt's. Less secure but as long as we don't accidentally commit the key to the repo we should be find, and if we do mess up, pushing a new key to production would just force everyone to log out which is not the end of the world. Option two is store a random key in the redis with the blacklisted jwts seeing as we are going to have to check the redis every time someone uses a jwt anyway. More secure but almost as stateful as the previous solution; only difference being redis instead of mongo. Option three is anything else we can come up with. I vote for option one.
Currently I am attaching a key value pair of string to struct to the context of the middleware which will be accessible to all further funcs using that context. For example, in the currently implemented jwt middleware it will attach a key value pair of "auth": {Authenticated: bool, UserAddress: string}. In this implementation the value struct has very explicit fields. We could also, however, store the value as a map and retrieve items with pCtx.Value("auth").(map[string]interface{})["authenticated"]. The final solution I can think of is have the key value pair be "authenticated" => bool and attach another key, value pair for "user_address" => string. This could get really messy in code, though, because a new context has to be created for every key value pair that basically copies the last context and adds a new key value pair, and if there are a lot of fields to be added in a middleware we want down the line it would require a lot more lines of code and way more memory allocations.

what is this address that is being stored in the jwt claims?

this is the user's wallet address. may need to be updated when a user can have multiple addressses

Do we want to adjust the way we handle http, possibly write different http wrappers, use another library, etc.?

agreed on parameter hell. i would defer to you in terms of migrating to a different wrapper or library: whatever would make you most comfortable, and coding most enjoyable!

Secret signing key

i also vote for option one, and this is common practice in the industry. in the future we can upgrade this and have regular key rotation. we'll also move over to using cookies over auth headers

string struct vs. context

thank you so much for doing this thorough analysis. if there will be a lot of overhead using context, let's stick to your solution


Update New-SPConfigurationDatabase.md

Local Server Role documentation has invalid role of WebFrontEndWithDistributedCache, it should be WebApplicationWithDistributedCache

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/New-SPConfigurationDatabase.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fails to install and run on M1 Macs because of pg_query version

Hi,
Unfortunately, I'm not savvy with ruby to understand how to update the pg_query version used in this linter myself.
Since we updated to M1 macbooks we had trouble running the linter
Could not find pg_query-1.2.0 in any of the sources
Run `bundle install` to install missing gems.

When trying to install we get a lot of errors.
 Building native extensions. This could take a while...
ERROR:  Error installing pg_query:
        ERROR: Failed to build gem native extension.

    current directory: /Library/Ruby/Gems/2.6.0/gems/pg_query-1.2.0/ext/pg_query
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby -I /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0 -r ./siteconf20220822-64024-sb0a0l.rb extconf.rb
compiling src/pg_query.c
compiling src/pg_query_fingerprint.c
compiling src/pg_query_json.c
compiling src/pg_query_json_plpgsql.c
In file included from src/pg_query_json_plpgsql.c:2:
In file included from src/pg_query_json_plpgsql.h:5:
In file included from ./src/postgres/include/plpgsql.h:21:
In file included from ./src/postgres/include/commands/trigger.h:17:
In file included from ./src/postgres/include/nodes/execnodes.h:17:
In file included from ./src/postgres/include/access/genam.h:19:
In file included from ./src/postgres/include/nodes/tidbitmap.h:26:
In file included from ./src/postgres/include/utils/dsa.h:17:
./src/postgres/include/port/atomics.h:68:10: fatal error: 'port/atomics/arch-arm.h' file not found
#include "port/atomics/arch-arm.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make: *** [src/pg_query_json_plpgsql.o] Err

Turns out M1 Macs are compatible with pg_query 1.3.0 or later.
https://github.com/pganalyze/pg_query/issues/210
Is there a way to update the pg_query version that this linter uses?
Thanks

(And it's working fine for me on Apple Silicon machines.)

I am facing the same error on my MacOS 13.0
Any help?
gem 'pg_query', '2.0'
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
current directory<EMAIL_ADDRESS>
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/bin/ruby -I /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0 -r ./siteconf20230106-52828-6mluz1.rb extconf.rb
creating Makefile
current directory<EMAIL_ADDRESS>make DESTDIR= clean
current directory<EMAIL_ADDRESS>make DESTDIR=
compiling<EMAIL_ADDRESS>compiling<EMAIL_ADDRESS>/Users/arththakkar/.rvm/gems/ruby-3.0.4@nirvasa/gems/pg_query-2.0.0/ext/pg_query/pg_query.c:1:10: fatal error: 'pg_query.h' file not found
#include "pg_query.h"
^~~~~~~~~~~~
1 error generated.
make: ***<EMAIL_ADDRESS>Error 1
make failed, exit code 2
Gem files will remain installed in<EMAIL_ADDRESS>for inspection.
Results logged to<EMAIL_ADDRESS>/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:93:in run'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:44:in block in make'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:36:in each'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:36:in make'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/ext_conf_builder.rb:63:in block in build'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/tempfile.rb:317:in open'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/ext_conf_builder.rb:26:in build'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:159:in build_extension'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:193:in block in build_extensions'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:190:in each'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/ext/builder.rb:190:in build_extensions'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/rubygems/installer.rb:837:in build_extensions'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/rubygems_gem_installer.rb:71:in build_extensions'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/rubygems_gem_installer.rb:28:in install'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/source/rubygems.rb:204:in install'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/installer/gem_installer.rb:54:in install'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/installer/gem_installer.rb:16:in install_from_spec'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/installer/parallel_installer.rb:186:in do_install'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/installer/parallel_installer.rb:177:in block in worker_pool'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/worker.rb:62:in apply_func'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/worker.rb:57:in block in process_queue'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/worker.rb:54:in loop'
/Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/worker.rb:54:in process_queue'   /Users/arththakkar/.rvm/rubies/ruby-3.0.4/lib/ruby/3.0.0/bundler/worker.rb:91:in block (2 levels) in create_threads'
An error occurred while installing pg_query (2.0.0), and Bundler cannot continue.


v1.2 broke Plots.jl CI

Plots.jl CI started erroring with the following logs since the new release: https://github.com/JuliaPlots/Plots.jl/actions/runs/3859523069/jobs/6579133683#step:10:62. My initial suspicion came from a new environment variable PRECOMPILATION_CACHE_PATH appearing in CI logs, so maybe that has something to with the failures. Just downgrading the cache version to v1.1.7 did not fix the issue, probably because it was still using old cache files. For now, removing the caching step seems to work around the issue. (Ref https://github.com/JuliaPlots/Plots.jl/pull/4624)

Repo maintainers can cleanup CI cache at https://github.com/JuliaPlots/Plots.jl/actions/caches, but being sensitive to an environment variable called <WHATEVER>_PATH sounds like a problem in Plots CI

I'm not familiar enough with Plots CI, but IIUC v1.2 only added a new option that's turned off by default, so it seems odd the new version broke this

Duplicate of https://github.com/julia-actions/cache/issues/10.
Sounds like a Conda.jl bug since it is also an issue if you would move the Julia directory from one system to the next.

FYI, we don't use Conda.jl but CondaPkg.jl in Plots (since the pyplot -> pythonplot transition). Looks like cleaning up the actions cache files fixed Plots CI.

I'll close it since it doesn't look like we can do anything on the side of this action and it appears to be a duplicate of #10.
Feel free to reopen if you have a suggestion for something we can do, though.

I'm not familiar with how this works here, but if there's any chance that the cached precompile files might get out-of-sync with the settings used for precompilation in the rest of the project, that could be a concern. ENV variables can cause subtle problems, see see https://github.com/MakieOrg/Makie.jl/issues/2585#issuecomment-1381567065.

The precompiled files aren't cached by default and the env vars shouldn't be accessed during compile time but we can take two precautions:

Actually test that compiled isn't cached (#49)
Use outputs instead of environment variables inside the action; that removes any potential interference even if it shouldn't matter (#48)


Fixing missed saving of "interpolation" parameter in UpSampling2D layer

Bug description: UpSampling2D layers in a model restored by "tf.keras.models.load_model" are initialized with interpolation="nearest" even if in original model UpSampling2D layers have interpolation="bilinear".

I signed it!


Packages that add a popup at the bottom of the editor can hide my cursor

The simplest way to observe this is to write things near the bottom of a file and trigger Project Find: Show. The find form appears at the bottom, hiding the part of the file you're working on. This is not particularly bothersome for find, but it's really annoying when the linter package, linting on every keystroke, shows errors that hide the part of the file you're working on (making it difficult to fix the linting errors without scrolling down.
Have a look at this issue for a better description of why this is annoying.

Thanks for the report! I think this is a duplicate of https://github.com/atom/atom/issues/8068 and https://github.com/atom-community/linter/issues/758 though - please subscribe there for updates.


Bump sbt to 1.3.0

To validate this pull request against other sbt modules, please visit this link.


Source Code controllet Frameworks process by the Secret Socket *

Describe the bug

To Reproduce

Expected behavior

Screenshots

Toolkit Logs

Development System (please complete the following information):

Windows Version:
Visual Studio Version:
AWS Toolkit for Visual Studio Version:

Additional context

Hi, I am unable to assist with this issue as-is. If you are able to share more details about your problem, please re-open it and provide a full description of your experience.


Inconsistent getters in Config

The Config interface currently has 2 major getters for config attributes.
<T> Optional<T> getPropertyValue()
and
Optional<String> getString()
This feels inconsistent. I don't have a final answer, but either it should be something like

getPropertyValue(), getPropertyString() or just
getValue(), getString()
or similar. Having one called "getProperty*" while the other just says "get*" feels inconsistent.

created a PR to update to getValue()


bug(Datepicker): Tabbing from Input To Datepicker Button Triggers Error Validation

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Premature error validation occurs when tabbing from the form field text entry section to the datepicker button. From an A11Y and usability perspective, this should not occur until the user has left the containing form field and button since the datepicker button is a valid way of filling out the form field.
Reproduction
StackBlitz link: https://components-issue-zzukvj.stackblitz.io
Steps to reproduce:

Add Datepicker to app from angular material code example
Add required validator to form control
Tab from the form field section to the datepicker button
Error shows, despite not having left the control

Expected Behavior
Required validation does not occur when tabbing from the text entry section of the datepicker to the calendar pop-out button.
It should only occur when tabbing out of the containing form field and button.
Actual Behavior
Required error validation occurs when tabbing from the text entry section of the datepicker to the open calendar button
Environment

Angular: 15.2.4
CDK/Material: 15.2.5
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): macOS, Windows

I am unable to open the stackblitz it seems, can you check the link on your end?

Hey @amysorto, it opens for me! I double checked the privacy settings and the url and it seems to be okay.

I can reproduce the reported behavior on the stackblitz link.

Version 116.0.5845.96 (Official Build) (arm64)
macOS 13.5 (22G74)

Hello folks,
Thank you for reporting this issue. Unfortunately we are not able to take action if we cannot reproduce it. This might have already been fixed. If the issue persists, please provide reproduction steps or file a new issue report.
-Zach

Hello folks, Thank you for reporting this issue. Unfortunately we are not able to take action if we cannot reproduce it. This might have already been fixed. If the issue persists, please provide reproduction steps or file a new issue report. -Zach

Hi, I've replicated the issue using Angular 17. Can this be re-opened @zarend ?
https://stackblitz.com/edit/stackblitz-starters-b6hqgj?file=src%2Findex.html

Hello folks, Thank you for reporting this issue. Unfortunately we are not able to take action if we cannot reproduce it. This might have already been fixed. If the issue persists, please provide reproduction steps or file a new issue report. -Zach

Also, I'm confused because even you said you could reproduce this back in August, and are now saying you can't.

Hello folks, Let's reopen this and take a look at https://stackblitz.com/edit/stackblitz-starters-b6hqgj?file=src%2Findex.html.
-Zach

Hello folks, I can reproduce without Datepicker, only need Formfield . I don't think Datepicker is related and this may happen with any form field with "required" validator.
https://stackblitz.com/edit/stackblitz-starters-dxpwt7?file=src%2Fmain.ts

Chrome Version 122.0.6261.94 (Official Build) (arm64)
macOS 14.3.1 (23D60)

-Zach

Hello, I updated the title to clarify that the root cause is in form field, which affects multiple components. That way this issue can get more attention.
-Zach

Thanks for re-opening this Zach, I realize could've done a better job describing the issue to get this more traction.
Looking forward to what comes next!


jobsteal single thread faster than serial

That number seems suspect -- I think it's because jobsteal busy-waits at the end of scopes until all jobs submitted are completed, so the scope you spawn on the main thread is actually doing work as well. This actually applies to all the examples -- work is being done on N+1 threads. You could probably alleviate this by creating jobsteal thread pools with "num_threads - 1". I don't know how much this problem applies to the other thread pools, however.
(This may be one reason why jobsteal is being outperformed at 24 threads: assuming that 24 is the number of cores on your machine, jobsteal is attempting to balance work between 25 threads and paying the price for context switches between them, while thread pools like rayon internally will be using 24)

Yes, thanks for pointing that out! I makes sense and I'll try "num_threads -1 "

Yeah, I think that might be an odd thing about jobsteal. When you call make_pool(N), it creates N additional threads on top of the main thread which will exist solely for the purpose of working. The main thread will also do work, but it's a little different than the others since it can only perform work when given the opportunity to via calls to synchronize, scope boundaries, and the destructor.

I've finished the benchmark and jobsteal now uses num_threads - 1. Looks more reasonable now, if you agree I would close the issue.

Seems fine, although it is also valid to create a jobsteal pool with "0" threads. It'll just only do work in the main thread, so I don't think it needs to be special-cased for num_threads > 1 as in this code:
    // Jobsteal uses n + 1 threads (1 main thread + n sub-threads)
    if mandel_config.num_threads > 1 {
        do_run("job_steal", &job_steal, &mandel_config, &mut image, &time_now);
        do_run("job_steal_join", &job_steal_join, &mandel_config, &mut image, &time_now);
    }

I think this misunderstanding is a result of my poor explanations above :).
What I meant by the main thread is the thread which creates the pool. Scopes need to be waited on such that all jobs submitted within them are executed before returning execution to the scope creator. The waiting thread will run jobs in a loop to reduce the time waited. So when you write code like this:
let mut pool = make_pool(1);
pool.scope(|scope| { ... });

The pool only spawns one additional thread, but both that thread and the main thread will do work while the main thread waits for the scope to finish.
If you call make_pool(24), it will only spawn 24 threads, but the main thread will also do work when waiting for scopes to conclude or in the pool's destructor. This leads to work being run on 25 threads (the 24 we spawned and the thread that owns the pool) which is more cores than the server has. In practice, I haven't seen this to affect performance very much.

Thank you for your detailed explanation!
In Rayon for ex. a pool of zero threads is not allowed, thus I was adding the if block for jobsteal.
I'll remove the special-case in the next release and add a comment to the code that points it out.
(And probably a link to this issue)
Thanks again :-)


Added beaconlight_explorer role that installs light-beaconchain-explorer

Added new role ethpandaops.general.beaconlight_explorer, which installs my lightweight beaconchain explorer using docker images (defaults to the latest stable release).
Structure is mostly copied from the blockscout role, so it should hopefully be conform with the repository standards ;)
Works on my side in a test-playbook which deploys the explorer for ephemery on a test vm.

fixed linting issues 🙄

Is this updated and ready to merge @pk910 ? We'd like to test it with devnet-8 if possible. cc @skylenet

yes, this should be fine :)
just marked it as draft due to the breaking config change, but I've updated the PR in meantime and also made a explorer release so the stable docker image has the latest changes.

@pk910 if you are bored 😂 : https://github.com/ethpandaops/ethereum-helm-charts/issues/207


<var>s were only used once reported when the variable name wraps

Test case:

Title: Spec
Shortname: spec
Status: DREAM
Level: 1
Group: group
URL: spec
Editor: You
Abstract: Spec

Intro {#intro}
==============

I want to tell you about a lengthy concept.

First, we need to define a <dfn>a lengthy concept</dfn>.

1.  Let <var>a lengthy concept</var> be something exciting like writing
    specifications.

1.  If your audience does not find specifications exciting, let <var>a lengthy
    concept</var> be something more stimulating like, "Why does pineapple juice
    require a different tin to other juices?".

    Issue: That's not such a lengthy concept after all. It turns out its just the
    acidity of the juice that's to blame.

1.  Return <var>a lengthy concept</var>.

STR:

Save above test case as yer.bs
Run bikeshed

Output:
WARNING: The following <var>s were only used once in the document:
  'a lengthy concept'
If these are not typos, please add an ignore='' attribute to the <var>.
 ✔  Successfully generated, with warnings

This seems to be a recent regression and is producing about a dozen false positives in the Web Animations spec.

Relatively recent - I refactored the var checking a little while ago and ended up not moving the "fold whitespace" part sufficiently early in the new code. Sorry about that, fixed.

@tabatkins Thanks for looking into this so quickly! However, I think you might have left some console debugging in that changeset.


[BUG] JavaScript error

Describe the bug
JS error message window.
To Reproduce
Steps to reproduce the behavior:

Load the gameSettings.xml configuration file or folder
Click on 'Scan'
Wait a few seconds (Process: Reading)
See error

Expected behavior
Loading and checking for errors in the log
Screenshots

Desktop (please complete the following information):

OS: Windows 10 (20H2 build 19042.1052)
ModChecker v1.9.18

Additional context
The problem only occurs in 1 case, with my mod folder in which I have a lot of unpacked mod files (some may be duplicated under, one as a different folder with the same name as the ZIP archive) and the mod testing program from Giantsa (TestRunner) but I checked and without it the problem still appears, other folders with mods (in 99% only ZIP archives) load in the program without any problem.
Here is the contents of my folder where this error occurs:

Working on a fix right now.  It almost has to be a zipped mod with a CRC error on the modDesc.xml file - that seems to be the sole place in the entire tree that "Invalid CRC" exists as an error string.
That said, I do wish node modules had better documentation.  Also, if you re-run the program on 1.9.19, and it picks up a crc error (It'll be in the debug log CTRL+ALT+D), I would love to have a copy of the offending file if possible.  Mostly because it's a great test, and I want to see how FS actually handles that.

The LOG from the program is empty, it displays nothing, and the folder has been loaded correctly.

1.) the log.  I bet it doesn't auto update that window, ever.  It probably should. Note for 1.9.20
2.) I found a copy of that file, complete with CRC errors.  Excellent :)


Use spelling extension to spellcheck Sphinx docs

This uses https://sphinxcontrib-spelling.readthedocs.io to spell check our rendered documentation. This includes:

any text in .rst files in docs
doc strings for functions/classes/modules
text in notebooks

There's numerous examples of misspelled words, which this PR fixes. There are also many words that are correctly spelled but aren't recognised as correct (e.g. "GCN", names, and en-au spellings). This PR includes a whitelist of words in docs/spelling_wordlist.txt (the default path for the spelling extension), this whitelist includes the above, and can be expanded as necessary.
This is checked on CI, and includes an annotation containing the misspelled words, as well as guidance for how to add things to the whitelist. For example: https://buildkite.com/stellar/stellargraph-public/builds/4677

(https://github.com/sphinx-contrib/spelling/pull/44 will make the display even more helpful by providing more context around a misspelled word).
See: #1368

Sorry about this one; it's a bit annoying to review. The sub-line highlighting seems to help, most of the updates were done automatically with sed, and I did a pass over the diff here myself & found & fixed a few incorrect changes (so hopefully there's fewer remaining).

Yeah, I considered that, but decided we'd end up including the en_US versions anyway. But maybe that's a better default given the origin of this project!

Yeah, I considered that, but decided we'd end up including the en_US versions anyway.

Ah you mean we have both versions of spelling peppered throughout?

But maybe that's a better default given the origin of this project!

Yeah, there's a few. For instance, the "added" words in https://github.com/stellargraph/stellargraph/pull/1583/commits/4df82bcc28db30e259b94bf03351cce6ec050c36#diff-6ff8a5a167c079bdae3db3c19510f369

Yeah up to you if you want to change it now, or just change it if it ever gets annoying to frequently run into spelling errors on CI from having aussie brains that produce aussie spelling by default

Changed it now 😄


UI Logic Documentation

After investigation of SOPA Paper and SimuBridge documenting the logic of UI extensions to the developers with necessary visualisation and explanation.

UI Documentation 21-01-2024 at 11.05.36 2 06-02-2024 at 12.21.23.pdf


Fix error when <rect> dimensions are negative

Description

When the waveform SVG is loading, the dimensions of the waveform are 0. Since the width of the focus rectangles are computed by subtracting from these dimensions, you get negative values and give errors in the console.
This PR prevents these errors by only rendering them after the dimensions of the SVG become non-zero.
Testing Instructions

Check out the PR and run the Storybook.
Render the Waveform stories over and over again.
Never see the errors in the console.

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Can you reproduce these 2 bugs on the Global Audio PR? I think I fixed these problems there.


Easier way to create a GraphAPI client with app access token

I find it a little bothersome to import and call a function to instantiate a GraphAPI client with an app access token.
What do you think about adding an alternate constructor in the form of a class method GraphAPI.with_app_token(app_id, app_secret_key)?

When will be implemented?


Deprecate VECTOR<FLOAT> syntax when creating table

We are already using VECTOR when creating a table through https://github.com/pingcap/tidb-vector-python/pull/41. However, TiDB still returns VECTOR<FLOAT> in the results of "show create table" and "INFORMATION_SCHEMA.COLUMNS". As a result, we need to keep the test cases with the old syntax for now. We should update the tests once TiDB starts returning the new syntax.

https://github.com/pingcap/tidb-vector-python/pull/41


vstest.console.exe failed with return code:<PHONE_NUMBER>

I'm getting the following error intermittently (approx 10-20% of CI build/tests) with the Visual Studio test runner (version 2.0.30):
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe failed with return code:<PHONE_NUMBER>
My solution is VS2017 with .Net Core and Xunit test projects. I'm using the Hosted VS2017 agent.
Not only is it intermittent, but when it does fail, it is not in the same test project. Never are there failed tests.
What is return code<PHONE_NUMBER>?
6_Test Assemblies .Tests.dll.txt

I also experience this lately, nothing to note with debug logging on, it just quits.
I also have it with some msbuild tasks (same idea, .net core in solution, xunit, hosted vs2017 agent).
Started happening since Tuesday

Same here. Just randomly started happening. It is a major blocker/annoyance for us.

@AbhitejJohn can you check

Tagging @smadala . Can someone share the diagnostic log too please(with System.Debug "true")?

Two attached, both debug set to true, same project, failed at different location with no 'reason'. Couldn't find anything significant.
logs_failed_msbuild.zip
logs_failed_vstest.zip

@janpieterz, @daniefvh To run .net core unit tests choose vstest.console.exe from "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe".
in vstest task (Execution options -> Specific location). In "Other console options" pass /diag:log.txt for diag information. please attach log.txt and log.*.host.txt.
@marcwmiller Please enable /diag:log.txt and attach log.txt and log.*.host.txt.

Seems for vstest to have something to do with code coverage. Where do I get those log.txt files from?
Also any thoughts about the msbuild one?
logs_639.zip

Seems for vstest to have something to do with code coverage.

/EnableCodeCoverage yet to support in .net core. Tracking here.
Pass /Framework:FrameworkCore10 arg in "Other console options" for running .net core tests.
log.txt is relative path from current working directory, you can pass absolute path too.
No vstest task or tests running in msbuild one. It was failing in Build solution, @acesiddhu Can you please tag Build solution task folks?

We are adding respective folks to investigate into this issue. Seems like both msbuild and vstest are failing with same error code.

@smadala - I have enabled /diag:log.txt as requested and will attach log files after next failure.

@smadala - As luck would have it (I guess) I got the error first time running CI build after enabling diagnostic logs. Please find log files attached.
6_Test Assemblies .Tests.dll.txt
log.host.17-05-08_12-07-31_43223_4.txt
log.host.17-05-08_12-07-55_11017_4.txt
log.host.17-05-08_12-07-57_53449_4.txt
log.host.17-05-08_12-08-02_33688_4.txt
log.host.17-05-08_12-08-07_38614_9.txt

@marcwmiller

DefaultEngineInvoker: ParentProcess '1244' Exited in log.host.17-05-08_12-08-07_38614_9.txt

Looks vstest.console.exe exiting abnormally,   Can please share log.txt which will be in current directory of vs test task command runs.
vstest.console.exe full dump by following instructions here.

@smadala - I think I've correctly updated the Copy Files task to capture the log.txt file (we'll have to wait for another failure).
But I'm not sure about your last request for logs - I'm using the Hosted VS2017 agent and cannot perform instructions provided in the link. Please advise.

This seems widespread, we have this error in approx. every 3rd build or so for several projects. Sometimes consecutive test runs have this, then it works for a couple of builds without any apparent change on our side. This happens only in VSO i haven't been able to repro locally.
Solution is VS 2017 .Net 4.6, Nunit 3.7, Hosted VS2017 agent

@marcwmiller are you able to get log.txt file?
@nigurr Is there a way we can get dmp from Hosted server?

@smadala - just got error moments ago. Please find attached log files.
6_Test Assemblies .Tests.dll.txt
log.host.17-05-08_18-17-32_22127_4.txt
log.host.17-05-08_18-17-58_32720_4.txt
log.host.17-05-08_18-18-00_77082_4.txt
log.host.17-05-08_18-18-06_21002_4.txt
log.host.17-05-08_18-18-10_73618_4.txt
log.host.17-05-08_18-18-16_22168_4.txt
log.txt

Just a note that we are not running .NET core.  I will try getting logs for you.

@marcwmiller can you please send your VSTS account and build details to devops_tools at microsoft dot com
I will be investigating into this asap.

FYI, we have the same problem with .net 4.6, VS2017, 2017 host, MsTest v2. And it happens to the build step as well, about as frequent.

Hi,
We have created a Live Site Incident for the same and actively working on this.

@nigurr  - I am unable to email the information requested. My email is returned with the following error:
The groups only accept messages from people in their organization or on their allowed senders list, and your email address isn't on the lists

@marcwmiller replied to you

does everyone on this thread have .NET Core projects in their solution?  Also can you all post your account URLs?

@chrisrpatterson - My solution contains .NET Core projects. I have shared account URL with @nigurr and can email to you if you'd like.

@marcwmiller can you simply ping your account and tell me what it resolves to.

Jup, contains .NET core, account url is intreba.visualstudio.com, one of affected projects Arke.
@nigurr has access to this already.

@chrisrpatterson tfsprodcus1.app.visualstudio.com [<IP_ADDRESS>]

Another question, what about TypeScript?

@chrisrpatterson - nope.

Jup, all failing builds have TypeScript projects

Typescript compile should be disable though, at least on the msbuild
failing projec
Met vriendelijke groet,
Jan-Pieter Zoutewelle

@janpieterz did you recently change or update the typescript version?

@chrisrpatterson wouldn't say recently, moved to 2.2.2 the 9th and 19th of April, but to be honest the history seems to stop after a bit (probably a setting) and I can't trace back when these started.
Maybe something that changed is that I've added GitVersionTask to both solutions recently, though I haven't found anything in the logs suggesting that fails (though neither anything else).

@janpieterz  How are you referencing TypeScript?  If you are using NuGet can see check your project files to see if you happen to be importing targets from both the MSBuildExtensions location
<Import Project="$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\TypeScript\Microsoft.TypeScript.targets"
and the NuGet
<Import Project="..\packages\Microsoft.TypeScript.MSBuild.2.3.1\build\Microsoft.TypeScript.MSBuild.targets"
And remove the one from MSBuildExtensions.

I'm using npm, no reference to typescript in csproj or in packages. Only references in csproj to Typescript are:
<TypeScriptEnabled>false</TypeScriptEnabled>
<TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>

@janpieterz  sorry I am working on a couple of issues at the moment.  Are you also seeing random failures in MSBuild with a return code of -1 or are you only seeing the vstest.console failure?

No worries! I am seeing both, so msbuild sometimes fails with -1, sometimes vstest.console fails with some number.

@janpieterz which version of the GitVersion task are you using?

4.0.0-beta0011
Test projects don't reference this though

but the build projects do.  This feels like some sort of assembly mismatch error that is not bubbling through to me.  I am just to exactly sure where, Thanks for the information.

Interesting, I did have some issue with System.Runtime being assembly redirect, on runtime, which was caused by GitVersionTask. Test project doesn't reference this, but who knows.
I'm more than happy to give you access and you can kick off as many builds as you want (it's night time here). If so, you might want to disable the npm/webpack tasks when doing since they slow it down a lot.

sure is your account MSA or AAD backed? if MSA backed you can add<EMAIL_ADDRESS> If AAD you will probably need to invite me to your tenant so it would be<EMAIL_ADDRESS>The System.Runtime redirect I have seen before.  In that case it seemed adding some Roslyn analyzers caused it.

@janpieterz can you make me a PCA so I could register an agent on a debug pool please

AAD backed, invited you but doesn't seem to want to add you as a PCA as of yet

Just a quick note that we partially resolved this problem by not using GitVersion during MSBuild but rather moving it to an extra Build Task in VSTS. The Build passes more regularly now, but we are still seeing occasional failures.
If I had to place a bet on it, I'd say the Agent is running out of resources during the build.

@daniefvh It is not the agent that is failing, it is MSBuild.  The machines have 7GB of memory so resources seem  unlikely but possible.  There is an option on the task to switch to 64bit MSBuild. Which version of GitVersion where you using?

@janpieterz thanks I will see what I can figure out.

@chrisrpatterson we tried upgrading to the latest version and that still failed.

@chrisrpatterson Should I look into the (new) TF209010 error and/or create an issue with GitVersion or here? Seems that is unrelated to what's going on here (though also pretty weird).
Any thoughts about the msbuild/vstest failures?

@janpieterz take a look at the clone of your definition in the project.  I made a small change and it potentially points to a logger we hook up.  For now you could potentially unblock yourself by adding a similar change.  Now we have not changed that logger in a couple of years so it appears their might be some new interaction with MSBuild we need to look into.

@janpieterz while I am working through debugging this issue I am going to temporarily increase the number of hosted agents in your account so I don't block your normal work

@chrisrpatterson I see, interesting. I'll wait for you to finish, only need to build correctly once for this security advisory.

@janpieterz you have 5 agents right now so you should be able to build.

Jup, I noticed when both ran at the same time. Cheers!

We don't have any .NET Core / TypeScript stuff.
We went back to the non-2017 host and all is well. We can't open it up for experimenting with builds since we have external dependencies (database for end2end tests).
Like I said in a previous post, we see builds failing on either the build step or the test step (not both).

@janpieterz  thank you for your patience.  We are working with the MSBuild team to figure out what additional diagnostics we can gather.  It seems the failure rate is about 20% and the MSBuild failure happens at a different place in the project every time.

@chrisrpatterson no worries, happy to help! If you want to speed up your build test, you could disable webpack and npm, they shouldn't bother the msbuild and test!
If you'd like me to add any other MS employee just send me an email or ping me here, besides that I'm enjoying the notifications for the builds in our Slack 😄

@janpieterz we have a repro from a basic solution https://github.com/sgrebnov/Windows-appsample-coloringbook now.  You can remove me from your account if you want.  For a temporary work around if you add a second vsbuild task right after the first one and set the first to continue on error it seems to complete successfully 100% of the time.

@chrisrpatterson Great to hear, just removed you. In case you need to get back in just let me know, otherwise good luck hinting, and cheers for that temp workaround!

What do I do with those agents btw?

@janpieterz the extra hosted agents should disappear.  You can also delete the agent in the default pool.

we are also seeing about 50% of builds fail on running tests with error
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe failed with return code:<PHONE_NUMBER>
similar to @nvankesteren we are using the Hosted VS2017 agent, due to this we also needed to change the build to use the Version 2.* preview version of the Visual Studio Test step
The current situation is intolerable, but not sure what to do, is the error we are seeing the same issue? is this a known issue that is being fixed or do we back out and stop using the Hosted VS2017 agent? we started using the VS2017 agent because the default one started giving us c# compilation errors randomly due to new c# language features.

We are actively working very hard on it.  We apologize for the inconvenience this is causing.  What we know is the process does not crash - both msbuild and vstest simply exits with -1 or maxint.  It only happens on the first run on a fresh OS (that is the hosted build scenario since every build is a new machine reimage).  For example, you can put a second task of build or test in the same job with the first being continue on error and it will always succeed.
The workaround is to use a private agent (your own VM / machine).

A new image which fixes/mitigates the issue should be rolling across scale units throughout the day.   Chime in throughout the weekend and early in the week if it's addressed for you.  We will be keeping an eye on it.

@bryanmacfarlane - sweet. Thanks to all involved with issue resolution.

got another failure just now
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe failed with return code:<PHONE_NUMBER>

@cob999, can you please send your VSTS account and build details to devops_tools at microsoft dot com
and send your build log?

@nigurr I've sent that on, got a bounce message saying Couldn't deliver to the following groups: but i'm hoping the original email got to you

@nigurr - I've received the error twice today :-(
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe failed with return code:<PHONE_NUMBER>
Vstest exited with return code: 1.

we're copying a new image with gflags to figure out what's wacking the process (it's not crashing, it's not exiting).  the previous mitigation appears to reduce the likelyhood but still hapenning ... we're on it.

A new image is closed to being rolled out with additional logging enabled to determine more information. When msbuild.exe/vstest.console.exe exits, info will be written to the application event log with the exit code and if another process killed it, the name of the process that killed msbuild.exe/vstest.console.exe.
To be ready when the new image finishes rolling out, you can go ahead and add the below inline powershell to grab the info from the application event log once it starts getting published. Please make sure you select "Always Run" in the task so that any previous errors in the build will still continue to execute this and dumps the logs.
Get-EventLog -LogName Application -After ([datetime]::now.addhours(-1)) -Source 'Process Exit Monitor' | % { "EventID: $($_.EventID)" ; "TimeGenerated: $($_.TimeGenerated)" ; "Message: $($_.Message)" ; "" }

Can MS repro this without outside projects? My team no longer has the resources to keep testing this and have stepped back a version. I'm watching this space to see if the issue is resolved.

We finally got a repro which captured the offending process from the event log line above.  We know exactly what is killing msbuild/vstest now.  We're following up right now with an image update.  It takes awhile to rollout but good news.
This one was especially tough because the size, length and volatility of our tool would protect it from repro'ing.  Sorry for the inconvenience.

@bryanmacfarlane - when do you anticipate the roll out to be complete? I'm still receiving error:
Ran for 3.7 minutes (Hosted VS2017), completed at Fri 05/26/2017 05:43 PM
Request Summary
Request 309	Marc Miller	Completed
Summary
| Build
2 error(s), 3 warning(s)
Build - 2 error(s), 3 warning(s)
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe failed with return code:<PHONE_NUMBER>
Vstest exited with return code: 1.

@thechrisjohnson should this have deployed everywhere by now?

@marcwmiller please send ersciple the name of your account (at microsoft com).

@ericsciple - done.


SNOW-1458135 Implement DataFrame and Series initialization with lazy Index objects

Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-1458135

Fill out the following pre-review checklist:

[x] I am adding a new automated test(s) to verify correctness of my new code

[ ] If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing

[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency
[ ] If this is a new feature/behavior, I'm adding the Local Testing parity changes.

Please describe how your code solves the related issue.

Implemented functionality to enable creating Series and DataFrame objects with a lazy Index object as the data, index, and/or columns.
This also covers creating Series and DataFrames with rows/columns that don't exist in the given data.
A special case is when the data is a Series or DataFrame object, the new Series or DataFrame object is creating by filtering the data with provided index and columns.
In case some values in index don't exist in data's index, these values are added as new rows and their corresponding data values are NaN.
In case some values in columns don't exist in data's columns, these values are added as new NaN columns.
I use a right outer join to add the new index values, and create and append the new NaN columns in the logic.

All of the join counts in the tests have increased because during DataFrame/Series creation with a non-Snowpark pandas object as data and a Snowpark pandas Index as index, a join is performed instead of converting the index to pandas (which results in an extra query).
In some cases the join count is a lot higher in tests but this is because of the way they are written - some tests call to_pandas() multiple times which results in this.

Jenkins build ran successfully: https://ci-dev-142.int.snowflakecomputing.com/job/SnowparkPythonSnowPandasDailyRegressRunner/758/

Almost all extra joins are from Series/DataFrame creation - giving a single Index as the index during construction results in one join. If a MultiIndex is provided, the number of joins performed is equal to the number of columns in the MultiIndex.
During some of the operations performed, a Series/DataFrame might be referred to lazily which results in more joins appearing in the final query (from the one join performed for Series/DataFrame creation).
I don't think the query counts have increased though.

@sfc-gh-yzou I prefer not making the refactor changes in a new PR since I think this one is very close to merging and it will take a lot more work to separate the index changes from this

@sfc-gh-yzou I prefer not making the refactor changes in a new PR since I think this one is very close to merging and it will take a lot more work to separate the index changes from this

I kind agree with @sfc-gh-yun this PR is becoming too big. Can we use this as the PoC draft PR, and we can review smaller PRs one by one. You can either start with refactoring pieces first or fix the lazy index first. Try to make sure refactoring PR only do refactoring and no test changes.

@sfc-gh-azhan @sfc-gh-yzou I can try to separate this PR into two other PRs - one for the lazy index change and the other for the refactor. It is impossible to avoid test changes in the refactor PR since I introduced functionality to allow passing non-existent columns or index values to the constructor. The constructors should be able to handle any kind of inputs and I added tests for this.
However, that requires me to make a non-trivial amount of redundant code changes, for example, the same set of tests are changed in both PRs where the query count will likely be different due to the refactor. I was hoping to work on IR tickets from Monday, so I still prefer merging this PR as is, please let me know if you both feel strongly about this.
In the future, I'd really appreciate if the feedback about splitting PRs is brought up earlier.

@sfc-gh-azhan @sfc-gh-yzou I can try to separate this PR into two other PRs - one for the lazy index change and the other for the refactor. It is impossible to avoid test changes in the refactor PR since I introduced functionality to allow passing non-existent columns or index values to the constructor. The constructors should be able to handle any kind of inputs and I added tests for this.
However, that requires me to make a non-trivial amount of redundant code changes, for example, the same set of tests are changed in both PRs where the query count will likely be different due to the refactor. I was hoping to work on IR tickets from Monday, so I still prefer merging this PR as is, please let me know if you both feel strongly about this.
In the future, I'd really appreciate if the feedback about splitting PRs is brought up earlier.

Then, I'm okay to keep working on this PR.


wsl2 can not excute "systemctl daemon-reload" command

In order to update the docker image source in wsl2, I ran the following command
systemctl daemon-reload

but an error was reported, the error message is as follows
System has not been booted with systemd as init System (PID 1). Can't operate.

Try service daemon-reload, it won't work either
wsl version
NAME            STATE           VERSION
Ubuntu-18.04    Running         2

System Information
  Time of this report: 3/18/2022, 16:57:10
         Machine name: PC
     Operating System: Windows 10  64-bit (10.0, Build 19043) (19041.vb_release.191206-1406)
  System Manufacturer: LENOVO
         System Model: 81Q5
                 BIOS: BHCN35WW (type: UEFI)
            Processor: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 CPUs), ~2.6GHz
               Memory: 16384MB RAM
  Available OS Memory: 16304MB RAM
            Page File: 22187MB used, 3155MB available

@remainfox systemd is not supported on WSL at this time. There are hacks to enable it, but YMMV.

ok

Is there a way to run the daemon reload service on WSL?
I successfully installed the Daemon-reload service but on running the below in the terminal, i get "unrecognized service"
           $ sudo service daemon-reload


Question about length of date/time datatype variable.

I have a question about length of date/time datatype variable.
According to the define.xml, the length attribute must be empty when datatype is not integer, float, or text. (Rule ID: DD0068)
But, according to the "CDISC_COSA_webinar_20231005_dataset-json_SAS" slide, the length of ISO8601 formatted data in json file has string datatype and is assigned length.
Is j-son more similar to dataset than define.xml?
I want to know why the length should be assigned in json file.
As you know, it is taken from dataset and it requires more work.

Hi,
length is an optional attribute. Dataset-JSON does not need it.

Hi,
As length attribute is optional requirement, I understand I can drop the attribute.
Thank you for the reply.


Fix the wrong parameter in the log.

Motivation
Bad parameters in the log will always print "null", which can confuse users.
Modifications

Correct exception parameter.

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[x] no-need-doc
(Please explain why)

/pulsarbot rerun-failure-checks


[website] "Information" is partially hidden

Pertaining to this URL: https://reactrouter.com/web/guides/server-rendering
The heading text Adding app specific context information is hidden under the right side pane.
Steps to reproduce
Simply go to this page in a PC or a MAC browser
Expected Behavior
Should look like this:

Actual Behavior
Looks like heading text is partially hidden:

I can raise a fix PR if the issue is approved.

You can always open a PR. No need to get approval from anyone.


Add eportfoliot.redu.fi/eportfoliot/juusokekonen/ to _data/sites.yml

This PR is:

[X] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

[X] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[X] The domain is in the correct alphabetical order
[X] This site is not an ultra lightweight site
[X] The following information is filled identical to the data file

I confirm that I have read the FAQ section, particularly the two red items around minimal pages and inappropriate content and I attest that this site is neither of these things.

[X] Check to confirm

- domain: eportfoliot.redu.fi/eportfoliot/juusokekonen/
  url: https://eportfoliot.redu.fi/eportfoliot/juusokekonen/
  size: 317
  last_checked: 2022-08-29

GTMetrix Report: https://gtmetrix.com/reports/eportfoliot.redu.fi/Wm03W1xo/

@kevquirk do you have feelings towards non-rootpath sites?

@kevquirk do you have feelings towards non-rootpath sites?

It was a school project and I was required to put it under eportfoliot/juusokekonen. If the length is a problem, and don't want to put it on 512kb.club, no problem, I won't mind.

Is this still maintained? The URL is less of a problem, but if this was just a short term project that's no longer maintained, I'd rather not add it.

Is this still maintained? The URL is less of a problem, but if this was just a short term project that's no longer maintained, I'd rather not add it.

I plan to maintain it for as long as I study (the site gets removed after I graduate). It is an online CV, and I will be using it to find a job for work apprenticeship, so keeping the information as up to date as possible is important

Fine by me then. I'd appreciate it if you could create another PR once you graduate so we can remove it.

Fine by me then. I'd appreciate it if you could create another PR once you graduate so we can remove it.

Will do! Thank you


Rack version mismatch

Hi,
The gemspec file (of version 0.12.0) specifies that the rack version requirement is ">=1.3.0". However, spec/grape/integration/rack_spec.rb checks whether the Rack version is 1.5.3 or 1.6.1. This induces ambiguity. Please fix it.
I am packaging grape for Debian (as part of GitLab packaging. Grape is a member of the dependency chain), where the rack version is still 1.5.2. But all the tests (other than the one mentioned above) seems to run perfectly with Rack v1.5.2. So, is it necessary for grape to require the above mentioned exact rack versions? If not, can you remove that spec I mentioned above?
Thanks.

I think we should make it >= 1.5.2 in gemspec. Would appreciate a PR.

I'll send a PR ASAP.
BTW, Rack 1.5.2 sets it's release as "1.5", not "1.5.2" ( as seen here ). So, the split on period to Rack.release will assign nil to the variable 'release' which will cause the mentioned test to fail.
If Rack versions >= 1.5.2 work succesfully, can we disable the mentioned test? All the tests run fine with 1.5.2 (and 1.6.4 - I checked). So, is that test really needed?

I am fine with anything that makes the test match what's in Gemspec or removes any unnecessary tests. Make a call.

I think we should make it >= 1.5.2

rails 3 locked on rack ~> 1.4.5, do you wanna drop support of rails 3?)

I would be open to dropping support for Rails 3 en general, but only if there's a good reason.

The mentioned test is fixed in #1104.

but only if there's a good reason.
The reason above(updating old dependencies) is not good one?) Anyway it's another issue and can be fixed later, I agree.


Delete .cuda() or .to() calls

There are a number of calls to .to() in decoder.py, e.g.,
https://github.com/prob-ml/bliss/blob/68657fb8f417c75c41b24f4a5f806b67368c3936/bliss/models/decoder.py#L149
These may be problematic, at least for multi-GPU training, but perhaps just for getting everything on the right device. See
https://pytorch-lightning.readthedocs.io/en/stable/multi_gpu.html#delete-cuda-or-to-calls

This may be a bit harder than I thought. The call to decoder.py happens in __iter__ in SmilulatedDataset(). Pytorch-lightning at least, normally generates data batch on cpu and then transfer the batch to gpu before each training step. I searched a bit and couldn't find much information on generating data on gpu natively supported by pl. There are some workaround for this but only for some simple data generation and single gpu training. Ours is fairly complicated. I posted a question on their Slack and I'll keep looking around but this would probably take longer.

This may be a bit harder than I thought. The call to decoder.py happens in __iter__ in SmilulatedDataset(). Pytorch-lightning at least, normally generates data batch on cpu and then transfer the batch to gpu before each training step. I searched a bit and couldn't find much information on generating data on gpu natively supported by pl. There are some workaround for this but only for some simple data generation and single gpu training. Ours is fairly complicated. I posted a question on their Slack and I'll keep looking around but this would probably take longer.

One option might be to get rid of the SimulatedDataset class, and move data generation to the beginning of the forward method of the SleepPhase class. SimulatedDataset was never much like a real dataset---it doesn't have to be loaded from disk or transferred to the GPU.
The only thing ugly about this solution is that SleepPhase still needs a dataloader to satisfy pytorch-lightning. If we got rid of SimulatedDataset, I think we'd have to create some sort of dummy dataset and dataloader. e.g. torch.TensorDataset(torch.zeros(50000)).

One option might be to get rid of the SimulatedDataset class, and move data generation to the beginning of the forward method of the SleepPhase class. SimulatedDataset was never much like a real dataset---it doesn't have to be loaded from disk or transferred to the GPU.
The only thing ugly about this solution is that SleepPhase still needs a dataloader to satisfy pytorch-lightning. If we got rid of SimulatedDataset, I think we'd have to create some sort of dummy dataset and dataloader. e.g. torch.TensorDataset(torch.zeros(50000)).


Archive sooner

Still testing this, but one of the concerns I had with the default behavior was waiting to archive the data until it was time to delete.  If the data is already segmented by day, anything older than a day should always be archived.

FWIW I find the inconsistent nomenclature (snapshot, archive, backup) hard to follow.


Input reads not recognised

Hi,
I tried using Ratatosk (v0.9.0), however it does not accept the input reads.
My command:
Ratatosk correct -s Illumina_reads.fq -i ONT_reads.fa -o ONT_reads_corrected.fasta
The errors:
Ratatosk::Ratatosk(): Insert size of short reads cannot be less than or equal to 0
Ratatosk::Ratatosk(): Missing input long read files.
The files themselves should be fine as they are accepted by other tools.
Any idea? Thanks in advance!

Sorry I am stupid, it is supposed to be -l not -i for the long reads.


CLOUDP-253914: Remove volumes

Proposed changes
Jira ticket: CLOUDP-253914#
Remove all volumes in setup.
Verified that everything still works (reasons why volumes were introduced):

Close laptop lid
Let laptop go in standby by not using it
Restart laptop (we could also force push off)

After testing, it seems like everything seems to work perfectly in these situations.

LGTM