Downstream issues emerging after forge config output changes

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (9d74675 2024-10-31T00:20:54.778420069Z)
What command(s) is the bug in?
forge config --json
Operating System
Linux
Describe the bug
I'm using a typescript library which runs forge config --json to acquire the forge config.
This library started crashing out of the blue recently when my build system was executing hardhat compile. The error looked like this:
An unexpected error occurred:
SyntaxError: Unexpected non-whitespace character after JSON at position 5069 (line 186 column 1)
    at JSON.parse (<anonymous>)

I wrote the buffer to file and inspected it
❯ hexdump dump.json -C | tail -n 5
000013c0  73 65 2c 0a 20 20 22 74  72 61 6e 73 61 63 74 69  |se,.  "transacti|
000013d0  6f 6e 5f 74 69 6d 65 6f  75 74 22 3a 20 31 32 30  |on_timeout": 120|
000013e0  2c 0a 20 20 22 65 6f 66  22 3a 20 66 61 6c 73 65  |,.  "eof": false|
000013f0  0a 7d 0a 1b 5b 30 6d                              |.}..[0m|
000013f7

and you can see an ANSI control code at the end of the output.
Given the nature of my setup I found the best workaround was to set NO_COLOR=1 prior to running hardhat
This line might be the culprit?
I'd suggest perhaps checking if the output is a tty before writing ANSI codes.

Hi @GlacierWalrus thanks for flagging this
I think the most practical way to fix this would be to ensure --json is always ran in a NoColor mode.
Related: https://github.com/foundry-rs/foundry/issues/8794 which plans to add a global --json flag which would make this easy to enforce https://github.com/foundry-rs/foundry/blob/6b0c27ed4ccfdb5a4805e9f53d487cca51c5e116/crates/cli/src/opts/shell.rs#L37
cc @DaniPopes

That makes more sense, thank you for explaining your codebase to me.

https://github.com/foundry-rs/foundry/blame/17e0981a071fbd3b5a0a59affb4d638a28dfec89/crates/common/src/io/shell.rs#L493-L500
This function should maybe check stderr().is_tty()


Please put a license file

Can you please put a license on this project so we know what kind of use cases are allowed with/without attribution?

This library is distrubuted under the MIT License, as shown in https://crates.io/crates/kd-tree .

I have just put the lincense file at https://github.com/u1roh/kd-tree/blob/main/LICENSE .


Handle JSX attribute indentation in jsx-indent

Resolves #2035

This looks great, but since it will introduce new warnings, it’s a breaking change. Can we hide this new behavior behind an option?

This looks great, but since it will introduce new warnings, it’s a breaking change. Can we hide this new behavior behind an option?

Updated


Add missing swift build --clean shorthand "-k" & change 'artefact' to US spelling

I don't think '-k' is a good shorthand here (e.g. It has a completely different meaning to make or Ninja)... I'm also not really sure we need one.

I see, I'll just go ahead and close this one then 👍

@runhum @ddunbar  then we should remove -k flag in usage
print("  --clean[=<mode>]               Delete artifacts (build|dist)")

LGTM. @ddunbar agree to merge it ?


[CA-1359] A11y: Accessible Tab Bars with keyboard navigation

This functionality was extracted from #2501, where it was already reviewed. I'm splitting that PR up into smaller components to try to figure out what's causing the integration tests to fail.
In this PR I've re-implemented the keyboard navigation using native DOM elements rather than React, in response to PR comments from @zarsky-broad. This seems to be working well, and it lets me convert the helper functions into actual React components without opaque children. Thanks @zarsky-broad !
From the original PR:
Tab Search Filters
The SimpleTabBar component is used on the Workspaces List page to render search filters for the workspaces table. Semantically, these are tabs: only one may be active at a time, and they cause only a portion of the page to redrawn when selected. I updated the semantic markup to make them function properly as tabs according to the ARIA specs.
In particular, I created a new reusable utility allowing a collection of Interactive elements to accept focus navigation using the arrow keys as well as Home/End, in either a vertical or horizontal orientation, by passing refs down into each child element. This seems to work like a charm! And it can be used in other places now too!
I also added PropTypes to the SimpleTabBar component to enforce that it has a label property for compliance with ARIA.
Tab Navigation Bar
The TabBar component is used on each Workspace and Workflow page to render a navigation section at the top, pointing to different subpages within the workflow or workspace. Semantically, these are actually menu items: only one can be active at a time, and they cause the entire page to refresh with a different URL. It's essentially a submenu for the page, even though they visually appear to be tabs.
I previously added Tab semantic markup to them and updated the integration test. However, I concluded that they in fact encode menu items more accurately, so I essentially reverted them. They now support keyboard navigation just like SimpleTabBar, though.
I also added PropTypes to the TabBar component to enforce that it has a label property for compliance with ARIA. And I added labels to all other pages that use this component.

@andy7i Yes! #2529 adds the vertical keyboard nav component to the popup menus.
And of course it's available as a component now to add anywhere else you want it. :) It should work with any kind of focusable children, although I only tested it in these two specific configurations.


Fixed some dead_code warnings. WiP.

Codecov Report

Merging #165 (47f3c95) into master (7862ee0) will increase coverage by 0.00%.
The diff coverage is 14.28%.

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   70.50%   70.51%
=======================================
  Files          88       88
  Lines        8002     8001    -1
=======================================
  Hits         5642     5642
+ Misses       2360     2359    -1

Impacted Files
Coverage Δ

src/dds/no_key/wrappers.rs
22.22% <ø> (+2.22%)
:arrow_up:

src/dds/pubsub.rs
62.50% <0.00%> (-0.33%)
:arrow_down:

src/discovery/data_types/topic_data.rs
82.03% <ø> (ø)

src/discovery/discovery.rs
70.24% <ø> (ø)

src/messages/protocol_version.rs
81.81% <ø> (ø)

src/serialization/cdr_serializer.rs
79.83% <ø> (ø)

src/network/udp_listener.rs
82.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7862ee0...47f3c95. Read the comment docs.

Started at 108 dead code warnings, 78 left.

66 left

very strange that clippy-check is unable to comment on this PR. have you perhaps added stricter-than-default permissions to this repo?


Upgrade Couchmove to 2.0

Add Full Text Search Option (see https://github.com/jhipster/generator-jhipster/pull/11421)

@tchlyah Maybe you can review couchbase-client version?

This seems to cause a compilation failure in couchbase + elasticsearch + oauth: https://github.com/jhipster/generator-jhipster/pull/11623/checks?check_run_id=618427010#step:14:53

Might be related: org.apache.commons.codec.binary.Base64 is no longer available. https://github.com/jhipster/generator-jhipster/pull/11623/checks?check_run_id=618427114#step:14:185

I've confirmed that changing the webflux-couchbase project to use v1.1 fixes compilation:
<dependency>
    <groupId>com.github.differentway</groupId>
    <artifactId>couchmove</artifactId>
    <version>1.1</version>
</dependency>

Therefore, I'm reverting this change.

sorry @mraible I didn't saw your message soon enough. This update is meant for the Couchbase Full Text Search option, and https://github.com/jhipster/generator-jhipster/pull/11421 fixes the issue.
I don't think that reverting this is a good solution since we are using here a transitive dependency and we shouldn't rely on it, it's better to add directly the dependency as we do for cassandra. This what I did here https://github.com/jhipster/generator-jhipster/pull/11421/commits/a730bd20dbe58f3f2367612309faf66fa9d4c929.
I can separate the fix from the FTS PR if you don't want to wait for its review.

I can separate the fix from the FTS PR if you don't want to wait for its review.

Yes, please do so, because currently master is broken.

Done in https://github.com/jhipster/generator-jhipster/pull/11640, it should be ok

@tchlyah Maybe you can review couchbase-client version?

Done in https://github.com/jhipster/jhipster/pull/680


Set up for semantic release

Current coverage is 53.18% (diff: 100%)

Merging #197 into dev will not change coverage

@@                dev       #197   diff @@
==========================================
  Files           155        155
  Lines          3238       3238
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1722       1722
  Misses         1516       1516
  Partials          0          0

Powered by Codecov. Last update f975ac0...6d6bb4e


Broken when I tried to make more than 17 concurrent calls

Hi,
I have a web application that could make calls between browser to softphone. When I tried to make concurrent calls, it failed after 17th call. Please find the error message below. Any thoughts to solve this? Thanks in advance.
Error Message:
sip.invitecontext.mediahandler | unable to acquire streams
c.print @ sip-0.7.8.min.js:36
sip-0.7.8.min.js:36 DOMException: Could not start source
c.print @ sip-0.7.8.min.js:3

Please upgrade to the latest version of SIP.js. We are no longer supporting the media handler (0.7.X)

Thanks @egreenmachine. I'm upgrading to sip 0.9.1 and will update the status soon

Hi, I have upgraded to sip.js 9.1 but still the call is broken after 17 concurrent calls. Please find the error attached below. Any thoughts how to resolve this issue.
Error Message:
sip-0.9.1.js:807 Fri Mar 02 2018 10:48:48 GMT+1100 (AUS Eastern Summer Time) | sip.invitecontext.sessionDescriptionHandler | unable to acquire streams
DOMException: Could not start source

I have answered this on our mailing list. Let's continue the discussion there.


Which model generated the answer?

Feature request
TL;DR: /generate endpoint doesn't inform which model generated the text.
When there are multiple TGIS servers initiated with different models and a load balancer is placed infront of them then it becomes difficult to understand which model generated the text.
Below is a usecase where a gradio app is designed to gather feedback from users about the answer they got for their question.

Note: i am aware of the /info endpoint which can give me the model_id but it doesnt help when multiple TGIS are behind a loadbalance because the same instance/server which got the /generate request may not get the /info request.
Motivation
The motivation behind this is to gather feedback from users about different model's reply and eventually retrain accordingly.
Your contribution
Yes i can help. i have already modified the router code and the text_generation client code to facilitate my usecase and i will create a PR with the same.

Why is the load balancer not adding a header to track the request instead?

if i understand correctly the LB should set a Header like X-Backend-Server to a request/response. Consequently, then the app should parse the header and if it is from server-1 it would determine it is from model-1, is that a correct understanding?

if that is what you mean then problem is the app has to have the hard coded knowledge of the relationship between which server has which model populated. Which can help in my application surely but having hard coded knowledge is not very appreciated therefore, i still feel the /generate and consequently, /generate_stream should give users an important information which is "Which model generated the answer?"


escape single quote for generating JavaScript string literal

https://github.com/fnando/i18n-js/pull/605 will generate like JSON.parse('{"a":"Test's"}'), it is broken JS because JSON includes single quote. This PR fixes JS will be like JSON.parse('{"a":"Test\'s"}').

@PikachuEXE I created a failing case and fix it. from https://github.com/fnando/i18n-js/pull/605

Thanks for submitting the fix quickly!

Will release this Friday
Let me know if anything still not fixed 😅

Thanks. I have no known issue now.

I try to use in our application and I find a problem and fix it 🙇 https://github.com/fnando/i18n-js/pull/607


SCIM2 filtering does not work when the filter value used is "OR" or "AND"

Describe the issue:
SCIM2 filtering does not work when the filter value used is "OR" or "AND", Imagine a user having the last name "OR" or "AND", it would not be possible to filter the user.
How to reproduce:
Create a user having Lastname "OR" or "AND".
Try to filter the user from the last name.
Example:
curl -v -k --location --request GET 'https://localhost:9443/scim2/Users?filter=name.familyName+Eq+OR' --header 'Content-Type: application/scim+json' --header 'Authorization: Basic YWRtaW46YWRtaW4='

Example:
curl -v -k --location --request GET 'https://localhost:9443/scim2/Users?filter=name.givenName+Eq+testuser+and+name.familyName+Eq+OR' --header 'Content-Type: application/scim+json' --header 'Authorization: Basic YWRtaW46YWRtaW4='

Expected behavior:
When "OR" or "AND" are added as values, it should return the results.
Environment information :

Product Version: [IS 5.7.0]

OR and NOT is not really needed for any practical use case

Proper fix for this issue is to integrate a parser to validate the syntax.
Issue created to track this: wso2/product-is#12868


Fix verification embed

Currently it's set to 3 months, need to make it correspond with what is set in the json file

I see that this is already checked with verification_requirement_join variable and there's a corresponding field in the JSON file as well. Is this issue resolved?

Hi vcidst, line 122 specifies that the account age is over 3 months so it has automatically been verified. It's just a matter of changing the value in the embed to a variable

Got it, I'll make some formatting changes and fix this


Bump run-script-os to ^1.1.5 to support NPM >=7.1.0

<EMAIL_ADDRESS>does not work in<EMAIL_ADDRESS>(charlesguse/run-script-os#34). This means that when a developer upgrades npm version to latest, running npm install is not able to run postinstall:lerna:*. The current workaround is to run npm i && npm run postinstall:lerna:default but that's kinda annoying after a while.

FYI, @ksbrar who also ran into this problem as well.


< without matching > removes all text after it

For example:
4 is <5 right? will give 4 is
Is this intentional?

Yes, because that string has a tag called 5. Theoretically, someone could write <5 onfocus=alert("xss")>, or cause onfocus=alert("xss")  to be appended to the string <5, so it's safest to remove all tags, even if they're unfinished.


Wrong cast

Version and Platform (required):

Binary Ninja Version: 3.6.4706-dev Personal
OS: Windows
OS Version: Windows 11
CPU Architecture: x64

Bug Description:
Wrong cast
Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

Open "challenge" file
Goto 0xdbf
Change windows to Pseudo C

Expected Behavior:
read_long() should be casted to (int32_t) instead of (int64_t)
Screenshots:

challenge.zip

Am I missing something? This seems correct to me:

After the call to read_long (which is typed as returning a uint64_t), there is a cdqe instruction that will sign-extend eax. This is why the cast is shown: It's casting an unsigned value to a signed value. It's possible we got the type of read_long incorrect (its return value appears to come from a strtoul, which we've typed as uint64_t) because that cdqe suggests it should be 32-bit. But, regardless, I'm pretty sure rax_8 is the value after the cdqe, which really is int64_t.
If I'm wrong or if I've missed something important in my reading of what's going on, please let me know. Otherwise, I believe we're doing the right things here.

Hi @fuzyll
Sorry for that I am not native English speaker so explaining something technical in English is bit hard. But both IDA and ghidra cast it correctly

Also here is well explaination about cdeq instruction I found on Internet
https://stackoverflow.com/questions/54618685/what-is-the-meaning-use-of-the-movzx-cdqe-instructions-in-this-code-output-by-a

No problem! I think your English is good enough. 🙂
Your second screenshot shows Ghidra casting the value to a long, which is (as far as I know) equivalent to int64_t. So, as far as I can tell, it's just IDA that thinks it's a 32-bit value.
What do Ghidra and IDA say the return type of the read_long function is? Binary Ninja thinks it's uint64_t. If you change it to uint32_t, the cast (and type of rax_8) will change, too, if that's what you want.

I think ghidra cast it correctly. read_long returns uint64_t type, after cdeq instruction, the returned value cast to int32_t before assigned to 64 bit variable. That why ghidra show (long)(int)uVar1 instead of (long)uVar1. What I mean here is binary ninja should cast it to 32 bit type, then assign to 64 bit variable instead of cast it to 64 bit type then assign to 64 bit variable.

Hi @fuzyll any progress on this? Or still you think this is intended?

Hey, sorry, this was about a week before I went on my holiday break and I must've missed responding earlier.
So, looking at this further, I see your point: Because the return value from read_long is treated as a 32-bit value (because we're doing cdqe), we should have two casts to show that the value is being truncated and then extended.
In HLIL, at that location, we emit int64_t rax_8 = sx.q(read_long()), which correctly understands that we have eax and are setting rax due to the cdqe:

This is actually a little confusing because read_long returns a 64-bit value. According to our own documentation, I would expect us to show a .d somewhere (like read_long().d maybe?). We don't, but it does appear we get the rest of this right.
So, I would guess the problem here is that we don't emit some necessary token in this case that shows the .d (in HLIL) or (int32_t) (in Pseudo-C.
TL;DR: I agree this is an issue. Just not sure what to do with it yet. Thanks for poking me to look at it again.

Rusty thinks this is possibly due to the partial access resolver and is very concerned that a fix here might have big problems for floating point support. Not entirely sure what the right path forward is, but I've done my best to complete triage of the issue now.

Ahhhh thank you for not forgeting this


how to finetune clip?

If I want to finetune clip on my own dataset, what should I do? Is there any sample code?

You can refer to this issue.

Thanks @bwanglzu , have u tried it ?


update release-branch.go1.18 with changes for Go 1.18

The release-branch.go1.18 branch as of this moment points to commit golang/go@cb5a598d7f2ebd276686403d141a97c026d33458, from when the Go 1.18 RC 1 release was made. Before the final Go 1.18 release, the branch needs to be updated to include all changes that are meant for Go 1.18, both those that landed while the tree was frozen, and a number of additional fixes that landed after the tree reopened for 1.19.
This is the tracking umbrella issue to collect the remaining CLs that need to land on the release branch, and sort them all. CLs that need to submitted first are on top of the list:

[x] https://go.dev/cl/389554: [release-branch.go1.18] all: merge master (acc5f55) into release-branch.go1.18
⤷ #51209
⤷ #51324
⤷ everything else up to "internal/goversion: update Version to 1.19"
[ ] https://go.dev/cl/388918: [release-branch.go1.18] cmd/compile: use AutogeneratedPos for method value wrapper
[ ] https://go.dev/cl/387977: go/types, types2: correctly consider ~ (tilde) in constraint type inference
[ ] https://go.dev/cl/388294: go/types, types2: clarify a comment and add an extra test
[ ] https://go.dev/cl/389474: cmd/compile: don't include instantiating types in type hash
⤷ #51250
[ ] https://go.dev/cl/389575: [release-branch.go1.18] cmd/go: ignore the workspace when running a package at a specified version
⤷ #51390
[ ] https://go.dev/cl/389594: go/types, types2: fix scoping for iteration variables declared by range clause
[ ] https://go.dev/cl/388995: [release-branch.go1.18] runtime: count spill slot for frame size at finalizer call
⤷ #51457
[ ] https://go.dev/cl/389298: [release-branch.go1.18] cmd/go: make paths consistent between 'go work init' and 'go work use'
⤷ #51448
[ ] https://go.dev/cl/389299: [release-branch.go1.18] cmd/go: error out of 'go work use' if no directories are given
⤷ #51448
[ ] https://go.dev/cl/389914: [release-branch.go1.18] cmd/go: add links to workspaces reference and tutorial to go help work
⤷ #51301
[ ] https://go.dev/cl/390022: [release-branch.go1.18] syscall: remove TestRlimit
⤷ #51479
[ ] https://go.dev/cl/390095: [release-branch.go1.18] internal/fuzz: handle Inf/NaN float values
⤷ #51258

(The boxes can be checked after the corresponding CLs are submitted to release-branch.go1.18.)
CC @golang/release, @randall77, @griesemer.

CL 389474 to fix #51250

Thanks, added it to the list.

By now, CL 389554 landed, so release-branch.go1.18 has all "for 1.18" CLs that landed while the tree was still frozen for 1.18 development. Next up are the fixes since then.
I reviewed all open release-blocking issues in Go 1.18 milestone, as well as open CLs targeting the Go 1.18 release branch and made sure everything in those 2 lists is included above. Then confirmed their order. Based on that, preparing the following stack that will check off all the boxes present at the time of this comment:
$ git switch release-branch.go1.18 && git pull --ff-only
$ git codereview change release-118-work

$ git show --oneline --no-decorate HEAD
9f2f0ee6ce [release-branch.go1.18] all: merge master (acc5f55) into release-branch.go1.18

git cherry-pick b0db2f00a0d540c3d3f5d14433da2e3e1ad41f9f  # cmd/compile: use AutogeneratedPos for method value wrapper
git cherry-pick 0807986fe6bf6040bafa9c415ab72e4cc8e519a4  # go/types, types2: correctly consider ~ (tilde) in constraint type inference
git cherry-pick 6da16b6ad5787a043fc9978d2d009934e3b2e165  # go/types, types2: clarify a comment and add an extra test
git cherry-pick d3672054fb58d5eaa241f15fa9d7fb9d61e9ac05  # cmd/compile: don't include instantiating types in type hash
git cherry-pick 86b5f6a7be707b9d84108df6f459c7e84bf9dbac  # cmd/go: ignore the workspace when running a package at a specified version
git cherry-pick d3fe4e193e387f250ba53a80f669eac465b1641d  # go/types, types2: fix scoping for iteration variables declared by range clause
git cherry-pick 58804ea67a28c1d8e37ed548b685bc0c09638886  # runtime: count spill slot for frame size at finalizer call
git cherry-pick 87a345ca3849a68de13f29bdc7628f2943734946  # cmd/go: make paths consistent between 'go work init' and 'go work use'
git cherry-pick 4f8094386c3c015f6b6f3efc3a002d188433d388  # cmd/go: error out of 'go work use' if no directories are given
git cherry-pick 1eb1f621da20d7c93ac0312e59c08afbde4d9f56  # cmd/go: add links to workspaces reference and tutorial to go help work

Mailed out the stack (10 commits) with https://go.dev/cl/389914 at the top.

CL 390020 should be backported to the 1.18 branch for #51479.  I can do the backport if you like.

Thanks Ian. It is probably better if I add it to the top of the existing stack for better visibility, and it's very easy for me to do since there aren't any conflicts. It's sent as CL 390022.

CL 388354  has just landed and should be backported, thanks!

Thanks! Added and mailed https://go.dev/cl/390095.

CL 390025 needs to be backported once it has landed.

CL 390314 needs to be backported once it has landed.

CL 390214 has landed and should be backported, thanks!

I just merged CL 390424, and it should have a backport too.

https://go.dev/cl/390914 should be cherry-picked too.

https://go.dev/cl/388194, although if it doesn't make the boat it can probably wait for 1.18.1.

CL 391135 needs to be cherry-picked once it has landed.

CL 391154 should also be cherry-picked once it has landed.

CL 391275 needs to be cherry-picked once it has landed.

CL 391615 needs to be cherry-picked.
Background: The fix simply removes an incorrect assertion (it was always incorrect). The rest of the changes is tests and the port to go/types. This CL will change the relevant issue #51593 from a release-blocker (crash) to a bug for Go 1.19.

CL 391454 and CL 391614 should be backported (and with that, I think I'm done with 1.18... 🤞.)

CL 391994 needs to be cherry-picked.
Background: for generic code, the compiler was using the wrong dict param for getting the dictionary type, causing mis-compile code when disable inlining. Debuggers (like devel) will have issues debugging generic code.

Thanks @cuonglm.
At this point we are very close to the release and so the bar for fixes is very high. Per go.dev/s/release, "We may prefer to issue a release with a known but very rare crash than to issue a release with a new but not production-tested fix."
I will make a backport for CL 391994, make sure it passes tests, and then generate a CL for resolving #51532, at which point we will need to aim to stop changing release-branch.go1.18 for anything but the most critical issues that must block the final release. For everything else, we'll need to consider backports to minor releases, or waiting for Go 1.19. Thanks.

@dmitshur Thanks for clarifying, I made https://go-review.googlesource.com/c/go/+/392614 for backport CL 391994.
IMHO, that's a critical issue, which make compiler generate invalid code and can cause runtime crashes/wrong behavior. We were able to catch that bug with inlining disable does not mean we have enough coverage test case for making sure the bug won't happen with inlining enable.
How do you think @randall77 @mdempsky ?

@cuonglm @randall77 Thanks.
CL 392674 is the last CL needed resolve a release-blocking issue in 1.18 milestone, so after it's in, I will tentatively close this issue.

Ok, as of this writing we are down to just 3 release-blocking issues in the Go1.18 milestone:

#47694

all that's left is to submit CL 390375 in x/website on the day of the release

#11811

an umbrella tracking issue, doesn't need CLs in the main repository

(this issue)

I'll mark this closed since the release-branch.go1.18 should have all the intended CLs that are needed for Go 1.18 final. (Everything to be cherry-picked for 1.18.1 will happen later—it's outside of scope of this issue.) Thanks to everyone's help here.


Add references to the website/installer localization docs

The README.md refers to the LOCALIZATION.md as the documentation to the app/website/installer localization:

Anyone can still contribute to the localization of the app/website/installer

But that file currently contains info only about the "app" part.
This PR adds links to the website/installer localization wiki pages to that file.

Thanks!


[WIP] Add useContentElementLifecycle hook

REDMINE-17591

Coverage remained the same at ?% when pulling 7c562d136017f600cc424ccf9e55a2bbf786f8e0 on tf:content-elements-lifecycle into 8dd0ba7ef0aa475a2328a77d4b6b75daf68f4ed4 on codevise:master.


Sharing is Caring Power App Sample - GeorgiaGit

Pull Request Body:
Category

[x] New Sample

What's in this Pull Request?
Power Apps Calendar Component

Thanks for your pull request, @GeorgiaGit! You rock!!!.
Can't wait to see what you'll do next!


chore: add golden file for update form with hasOne relationship

Issue #, if available:
Description of changes:
Adds golden file for an Update form that uses a hasOne relationship
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #766 (1b2e0dc) into tagged-release/cms-support (dafe587) will not change coverage.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##           tagged-release/cms-support     #766   +/-   ##
===========================================================
  Coverage                       92.04%   92.04%
===========================================================
  Files                             115      115
  Lines                            4351     4351
  Branches                         1210     1210
===========================================================
  Hits                             4005     4005
  Misses                            325      325
  Partials                           21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafe587...1b2e0dc. Read the comment docs.


Ability to store past prompts and answers from ChatGPT

Is it possible to store past prompts and answers from ChatGPT?

@ahlag The prompt store is already available. Please confirm if this meets your needs.

Yes, checked.


Sandbox BGS does not accept events with missing prev field

IIUC, as of repo v3, the prev field is optional. I got rid of it while updating picopds to repo v3. However, I couldn't get the sandbox BGS to accept my commit events until I added dummy prev fields (set to null) to my commit objects and firehose events (I'm not sure if both were strictly needed, but I changed both at once and it started working after that).

Thanks for the report, will take a look!

hrm... the prev field on the generated struct probably wants to be omitempty, but i dont think thats actually going to cause an issue.

I see some signature validation failures on retroid repos

Do you have timestamps for those validation failures? I might be able to figure out what I was doing at the time.
At one point I'd forgotten to update my _atproto DNS record, although I don't think that would manifest itself as signature validation errors

yeah i saw the bad dns record one.
I'm 90% sure whats going on here is that you're signing over the 'commit' with the 'prev' field entirely missing, where when i check the signature i'm computing the bytes to have 'prev=null'.
Since i'm properly validating the signatures on the typescript code, i can assume that they are doing the same thing here. Actually removing the prev field is going to be tricky, missing field != null will be fun...

:eyes:
yeah, prev is both optional and nullable per the v3 spec. it was nullable previously and we want to allow just not including it at all, but also wanted to be as compatible as possible during the transition.
some languages should be able to validate whatever is in the commit. golang will have a bit of trouble... I guess trying both variations shouldn't be too bad performance-wise as long as it is really clear which is expected and 99.99% of signature validations are happy path?
this could be a major problem for, eg, label signing and validation though (several fields, with no-value-provided common for several), will want to ensure there is no ambiguity in that case.
cc: @dholms


[master] Upgrade to latest dependencies

Cron. -knative-prow-robot
/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers
Produced via:
./hack/update-deps.sh --upgrade --release v0.22
./hack/update-codegen.sh

Details:
bumping knative.dev/hack 8368e1f...f99a255:
  > f99a255 Schema tool for reflective schema generation. (# 51)

/lgtm
/approve
/retest


remove privileged flag from the Docker command line, and use device mapping

Remove privileged flag from the Docker cmd, and use device mapping

@dmitsh -- I used a similar approach in June when I got OE running inside a Docker container (shared my email to you folks).
@johnkord / @dmitsh - Does the container start out in root mode? If so, that isn't ok and there is a way out of that. If not, we are good to go.

@anitagov I saw your email! Really awesome.
Thanks to everyone for putting our brains together and getting this perfect

bors r+


Generics with slots don't work with Vue 2.7

It looks like a generic can be defined, but type argument doesn't appear in the slot. Instead it appears as the generic type.
Example of this working correctly with Vue 3:
https://github.com/vuejs/language-tools/blob/24968e16eb2952cec6bcd247d6d6dc1eed13bf74/packages/vue-test-workspace/vue-tsc/%232639/Bar.vue#L2-L6
Here, Foo has a generic T extends { index: number }:
https://github.com/vuejs/language-tools/blob/24968e16eb2952cec6bcd247d6d6dc1eed13bf74/packages/vue-test-workspace/vue-tsc/%232639/Foo.vue#L7
However, trying this with Vue 2.7 fails:

Reproduction

starting from cloning this repo @ develop, pnpm install --frozen-lockfile and pnpm build
from within packages/vue-test-workspace...

edit tsconfig.json to only target the failing test

{
        // ...
	"include": [
		"vue-tsc/#2639/*"
	]
}

confirm the test is good so far with vue 3: node ../vue-tsc/bin/vue-tsc.js --noEmit
edit packages/vue-test-workspace/package.json to use vue 2.7 and pnpm install
running vue-tsc.js again produces this error:

vue-tsc/#2639/Bar.vue:4:17 - error TS2339: Property 'name' does not exist on type '{ index: number; }'.

4    <div>{{ item.name }}</div>
                  ~~~~

Found 1 error in vue-tsc/#2639/Bar.vue:4

Some extra thoughts...
I'd really like to help with this project more, but it's difficult to know where to begin and it's challenging learning how all the packages in this repo work together to perform type checking.
I'm super thankful for this extension, IMO there aren't any viable alternatives for Vue 2.7 anymore. Volar seems to be the way to go, but maybe it'd be helpful to create another test package just like vue-test-workspace, but have it use vue 2.7 instead of vue 3. I'd imagine it'd have a subset of the tests from vue-test-workspace, for covering the stuff that should be possible with vue 2.7 and vue 3.
I tried creating this setup and could make a PR for it, but I could use some guidance figuring out which tests should apply to both 2 and 3. However, I wanted to know if that's even desirable for this repo before putting more effort into it. Any thoughts?

Agreed. I'd like to contribute to this awesome project too but the lack of documentation made me abandon the idea

Should work now


Added HPA metrics to kube-state-metrics in garden ns.

What this PR does / why we need it:
Added HPA metrics to kube-state-metrics in garden ns. These can help in analysing HPA behaviour and in analysing the benefits and impact of reducing HPA scale down stabilization period (currently 24h) to a lower value.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For the time being, I have not added any aggregate rules. If I find something useful as an aggregate metrics, I will file a separate PR later.
Release note:

Added HPA metrics to kube-state-metrics in garden ns. These can help in analysing HPA behaviour and in analysing the benefits and impact of reducing HPA scale down stabilization period (currently `24h`) to a lower value.

cc @ggaurav10 @wyb1

@mvladev Can you please check the test step? It was again failing although the test unrelated to @amshuman-kr's changes.

#2061 should solve the problem. Golang has no guaranteed ordering...

Thanks martin!

@amshuman-kr
#2061 is merged, can you please rebase onto it to get the test fix in?

#2061 is merged, can you please rebase onto it to get the test fix in?

@tim-ebert Done.


Update RAT version in workflow

DRAT currently explodes because it pulls RAT 0.12 but references 0.11

Explosion ceased thanks @buggtb


About Page

I reopened this ticket because worked a bit on the composition. We still need copy. @xavier506 @tetogomez
Desktop and Mobile: https://zpl.io/bzxB3gl
Illustration: https://zpl.io/29dAmLl


list index out of range

I am trying to run the main script, but get the following error.
Traceback (most recent call last):
File "main.py", line 554, in <module>
train(data)
File "main.py", line 394, in train
print("Shuffle: first input word list:", data.train_Ids[0][0])
IndexError: list index out of range

The data summary says that there are no data instances.
Seed num: 42
MODEL: train
Training model...
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
DATA SUMMARY START:
 I/O:
     Start   Sequence   Laebling   task...
     Tag          scheme: BIO
     Split         token:  |||
     MAX SENTENCE LENGTH: 250
     MAX   WORD   LENGTH: -1
     Number   normalized: True
     Word  alphabet size: 54397
     Char  alphabet size: 93
     Label alphabet size: 4
     Word embedding  dir: None
     Char embedding  dir: None
     Word embedding size: 50
     Char embedding size: 30
     Norm   word     emb: False
     Norm   char     emb: False
     Train  file directory: sample_data/train_wout.bmes
     Dev    file directory: sample_data/valid_wout.bmes
     Test   file directory: sample_data/test_wout.bmes
     Raw    file directory: None
     Dset   file directory:
     Model  file directory:
     Loadmodel   directory: None
     Decode file directory: None
     Train instance number: 0
     Dev   instance number: 0
     Test  instance number: 0
     Raw   instance number: 0
     FEATURE num: 0
 ++++++++++++++++++++++++++++++++++++++++
 Model Network:
     Model        use_crf: True
     Model word extractor: LSTM
     Model       use_char: True
     Model char extractor: CNN
     Model char_hidden_dim: 50
 ++++++++++++++++++++++++++++++++++++++++
 Training:
     Optimizer: SGD
     Iteration: 1
     BatchSize: 10
     Average  batch   loss: False
 ++++++++++++++++++++++++++++++++++++++++
 Hyperparameters:
     Hyper              lr: 0.015
     Hyper        lr_decay: 0.05
     Hyper         HP_clip: None
     Hyper        momentum: 0.0
     Hyper              l2: 1e-08
     Hyper      hidden_dim: 200
     Hyper         dropout: 0.5
     Hyper      lstm_layer: 1
     Hyper          bilstm: True
     Hyper             GPU: False
DATA SUMMARY END.
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
build sequence labeling network...
use_char:  True
char feature extractor:  CNN
word feature extractor:  LSTM
use crf:  True
build word sequence feature extractor: LSTM...
build word representation...
build char sequence feature extractor: CNN ...
build CRF...
Epoch: 0/1
 Learning rate is set as: 0.015

I have tried to make my data as similar as possible to the data in sample_data. Here is an example, using a BIO scheme.
udviser B-ORG
empati I-ORG
over I-ORG
for I-ORG
patienter I-ORG
og I-ORG
pårørende I-ORG
. I-ORG
Vagtforpligtigelse O
overlægen O
indgår O

So I am not sue why my data is not getting recognized at all. Any ideas?

Train instance number: 0
This means the model can’t load the input file. There must exist data format error for your input data.

Any idea on what that could be with the above format? I tried with plain text, calling them bmes, using crlf and lf line endings.

They are utf-8 encoded.

Check the demo data in this code.
Notice there is a newline between sentences to split the sentences


Adding libabigail checks

This PR will add libabigail checks for a few system libraries and libabigail.so.
We do not have a release yet, so for now we are just running to compare latest with pr. Ping me when there is a release and we can uncomment the sections to do that! Here is the example run to inspect: https://github.com/vsoch/libabigail/runs/5856291790?check_suite_focus=true
Signed-off-by: vsoch<EMAIL_ADDRESS>

oh nice it's running here this time!

okay we could pull the previous build this time, so let's see if that saves any build time!

@woodard are there tests you want to run after the build in the container? Might as well do that if we build it in the PR.


Add ability to make a combined query in all sites

I think it would be great if there's a ability to make a combined query with all torrent sites at once . Unless a very specific reason , most people would anyways use it this way
Even all torrent aggregator sites typically have option to make a combined query or search in a torrent site specially

yeah sure will add that option too.

Done @xd003


Don't pass null-kinded template arguments to Sema [phab:D1252]

Created by zarko at 2017-01-11 22:04:50:
Also don't spam the log if we hit #1632.

fromberger accepted this revision at 2017-01-11 22:12:03

zarko closed via commit 4526428d66007a3c0e977091cd71c63d910d49d3 at 2017-01-11 22:39:44


DarkPlaces only supports one alphaFunc operation, GE128

DarkPlaces only supports one alphaFunc operation:
https://gitlab.com/xonotic/darkplaces/blob/324a5329d33ef90df59e6488abce6433d90ac04c/model_shared.c#L1875-1876
Which is GE128:
https://gitlab.com/xonotic/darkplaces/blob/0ea8f691e05ea968bb8940942197fa627966ff99/render.h#L95
Because of that people may silently introduce regressions in their textures
designed for GT0 by compressing them using a lossy picture format like Jpg.
Xonotic texture known to trigger this bug:
models/desertfactory/textures/shaders/grass01

Using GE128 instead would hide Jpeg artifacts while not breaking that much
non-Darkplaces GT0.
No one operation other than GT0 an GE128 was found in whole Xonotic corpus,
so if there is other operations used in third party maps, they were broken
on Darkplaces and will work there.
Xonotic assets were fixed to make sure any idTech 3 renderers display the Xonotic
textures the same way Darkplaces displays them by telling renderer to use GE128
operator:

https://gitlab.com/xonotic/xonotic-maps.pk3dir/merge_requests/140
https://gitlab.com/xonotic/xonotic-data.pk3dir/merge_requests/753
https://gitlab.com/xonotic/xonotic-nexcompat.pk3dir/merge_requests/2

But there is thousands of third party maps around there, so the workaround
is required.
Hopefully in case of legit GT0, a GE128 is not that bad, for example with
the grass texture quoted above, it would just be thinner.
Things may be less good in some case, when only the dark frame is expected
to be discarded but there is some dark pixels to keep (typically a road sign).

Before:

After:


AcrylicBlur does not work on Windows11 10.0.22631

Describe the bug
Windows 11 professional edition
10.0.22631 build 22631
screenshot:

To Reproduce
code:
AcrylicBlurIssueWin11.zip
Expected behavior
No response
Avalonia version
11.2.2
OS
Windows
Additional context
The issue likely isn't specific to Avaloniaui, as I've encountered a similar problem in my WPF application.
Here is my code about AcrylicBlur in wpf.
var accent = new AccentPolicy
{
    AccentState = AccentState.ACCENT_ENABLE_ACRYLICBLURBEHIND,
    GradientColor = _blurColor
};
var accentPolicySize = Marshal.SizeOf(accent);
var accentPtr = Marshal.AllocHGlobal(accentPolicySize);
Marshal.StructureToPtr(accent, accentPtr, false);
try
{
    var data = new WindowCompositionAttributeData
    {
        Attribute = WindowCompositionAttribute.WCA_ACCENT_POLICY,
        SizeOfData = accentPolicySize,
        Data = accentPtr,
    };
    SetWindowCompositionAttribute(handle, ref data);
}
finally
{
    Marshal.FreeHGlobal(accentPtr);
}

https://github.com/AvaloniaUI/Avalonia/issues/6465


Updating Dockerfile to fix image tests

What type of PR is this?
(bug)
What this PR does / why we need it?
This PR would fix the image test failure by updating the Dockerfile
Which Jira/Github issue(s) this PR fixes?
Fixes # https://github.com/openshift/release/pull/25019
Special notes for your reviewer:
Dockerfile referred from MUO
Pre-checks (if applicable):

[x] Tested latest changes against a cluster
[x] Ran make generate command locally to validate code changes

/lgtm


Add a default title on the Iframe

When I analyze with Lighthouse my website which use github-buttons, it alerts me about an accessibility issue (https://dequeuniversity.com/rules/axe/2.2/frame-title).
Can you add a default title on the iframe HTML tag to avoid that flag?

The justification for adding it was documented in WCAG 2.0 H64:

This provides a label for the frame so users can determine which frame to enter and explore in detail.

In the old days when web page layouts were constructed by <frame> elements, the title attribute was quite useful because screen reader users would use that to skip through frames which might have tons of irrelevant content.
However, we are not in the old days any more. The use case of <iframe> today has changed dramatically. Modern browsers consider <iframe> as a seamless part of the parent page, such that a title attribute for screen readers would become irrelevant, because it breaks the seamless integration. Browsers do not render the tooltip for title attribute when hovering <iframe>, and newer version of screen readers won't read out title on <iframe> as well. Although title attribute on <iframe> was intended for humans, only bots will see those nowadays.
It might be useful for old browsers / screen readers, but HTML is an evolving standard. Nowadays we put aria-label on the elements within the <iframe> to provide an explicit accessible version for screen readers.
I don't feel that we should add title just to bypass a linter warning.

@thedaviddias Now if you add a title attribute on the button's <a>, the title will be copied to <iframe>.

Thanks @ntkme, I'll try it.


update purescript-generics dependencies in examples to version 0.7.0+

fixes compilation errors with psc <IP_ADDRESS>

Thanks! I'd been meaning to get around to this. I'll merge once Travis completes.

Ah, I think the failures are because the behaviour of bower link changed recently to not also trigger a bower install, so the scripts in package.json will need updating.
Could you make that change too please (just update the bower link purescript-halogen part to bower link purescript-halogen && bower install in each of the build scripts), and bump the compiler dependency to ^0.7.6 while you're at it. Thanks!

Sure, I'll do that.

Thanks! :+1:


chore: migrate to using Flakebox

Flakebox was explicitly created based on our dev env in Fedimint, generalizing to make it usable and customizable in any Rust project.
Moving all our building scripts, Nix cross-compilation system etc. out into a dedicate project has multiple benefits:
Fedimint module authors will have easier time re-using our setup. Possibly other Bitcoin-related projects as well.
Projects not related to Fedimint can use it, so it will get better coverage, features and testing.
The outside repo is smaller and allows focusing on core features of Nix dev shell and Rust support. E.g. in Flakebox there are Nix unit-tests making sure cross-compilation works well. This would be harder and confusing to build inside Fedimint repo itself.
Some of the things in Flakebox are already better than what we were doing in Fedimint. There's a chance for some minor things being broken in this migration, but it should be easy to fix with time.
Overall diff is mostly red color. It would look even more red if the lines of things that are auto-generated where not being counted in.
We return to the source.

@elsirion @justinmoon This changes the naming of the toolchains from the full triplet to the shorter "systems" strings, so will need admin override. Sorry for trouble.


Adding Homebridge UI X setting?

First of all, I would like to say thank youuuuuuuuuu for this plugin! I have been using the Homebridge Ambi Climate and Thermostats for ages and it kinda slow my Homebridge down drastically. I was so sad that both plugin are abandoned. Thanks for reviving the plugin for Ambi Climate once again and this time is even better than what we've got.
Do you also planing to make the plugin verified? Can you please consider adding backend configuration in Homebridge UI for an easy usage? I don't mind having to edit json file myself but it would be very convenient to be able to config it with human language on Homebridge UI.
Anyway, thanks so much for this plugin!

Ohhh, my bad. The UI Config is already there. lollll.
I guess I was too hype seeing plugin for Ambi Climate in 2021 so I jumped in here requesting things to fast lolll.

Ohhh, my bad. The UI Config is already there. lollll.
I guess I was too hype seeing plugin for Ambi Climate in 2021 so I jumped in here requesting things to fast lolll.

Yes it already has UI config. I will try to apply for the verification, thanks for your feedback!

Yes it already has UI config. I will try to apply for the verification, thanks for your feedback!


Added test fix for nightly build run

Packages impacted by this PR
NA
Issues associated with this PR
The nightly build runs fail due to a previous change with the @azure/core-http dependency. In order to make it work, a test assertion needs to be modified.
Describe the problem that is addressed by this PR
The test assertion originally was modified to work against 2.2.6 version within the builds. However, 2.2.6 is an unreleased version that should not be specified with the package.json. Since the tests need to be compatible with <= 2.2.6, this change is to allow it work against all environments for the nightly build.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
NA
Are there test cases added in this PR? (If not, why?)
NA
Provide a list of related PRs (if any)
https://github.com/Azure/azure-sdk-for-js/pull/22644
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-digital-twins-core


Number of columns if Grid?

Is there any way to set the number of columns using the grid? I have the same number of items like in the example. It doesnt look good having 4 icons on the first row and then 2 icons on the bottom row. Is there any settings I could change to set number of columns?
Thanks

Its modeled after the design guidelines found here where it shows tablets having 4 icons in a row. However, I will update it to alter the logic to evenly distribute them based on the number of icons present

Thank you.. really looking forward to that.

The way column count will work for grids is as followed:
You can set the number of columns via the builder by calling the setColumnCount(int count) method, or you can set it via a style by specifying the  <attr name="bottom_sheet_column_count" format="integer" /> attribute
If the column count isn't specified, it will be obtained based on the number of items to display. If there are 7 or more items or exactly 4 items, 4 columns will be shown. If 1,2,3 or 5 items are to be displayed, 3 columns will be shown.
These values are only used if using the Grid style. The list style still follows the same logic as before

Wow! That was quick... thank you very much sir Kenny!


Compilation errors on some environments

HEAD = 2258c712c8726609aaff62470317e36513db7093
Applied a workaround for #526 :
diff --git a/script/bootstrap b/script/bootstrap
index 26c1e91..3022ab0 100755
--- a/script/bootstrap
+++ b/script/bootstrap
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash

 # script/bootstrap: Resolve all dependencies that the application
 #                   requires to run.
diff --git a/script/server b/script/server
index e7048d2..42effa6 100755
--- a/script/server
+++ b/script/server
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash

 # script/server: Launch the application and any extra required
 #                processes locally.
diff --git a/script/setup b/script/setup
index 256b36f..0a11ded 100755
--- a/script/setup
+++ b/script/setup
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash

 # script/setup: Set up application for the first time after cloning,
 #               or set it back to the initial first unused state.

Used instructions in the README:
root@5b3a1a257769:/src/tessera# ./script/setup
==> Installing Javascript dependencies...
npm WARN package.json<EMAIL_ADDRESS>No README data
npm WARN package.json<EMAIL_ADDRESS>No README data
==> Installing Python dependencies...
Downloading/unpacking flask==0.10.1 (from -r requirements.txt (line 1))
  Downloading Flask-0.10.1.tar.gz (544kB): 544kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/flask/setup.py) egg_info for package flask

    warning: no files found matching '*' under directory 'tests'
    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
    warning: no previously-included files matching '*.pyc' found under directory 'examples'
    warning: no previously-included files matching '*.pyo' found under directory 'examples'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
Downloading/unpacking flask-sqlalchemy==1.0 (from -r requirements.txt (line 2))
  Downloading Flask-SQLAlchemy-1.0.tar.gz (92kB): 92kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/flask-sqlalchemy/setup.py) egg_info for package flask-sqlalchemy

    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
Downloading/unpacking flask-migrate==1.2 (from -r requirements.txt (line 3))
  Downloading Flask-Migrate-1.2.0.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/flask-migrate/setup.py) egg_info for package flask-migrate

Downloading/unpacking flask-cors==2.0.1 (from -r requirements.txt (line 4))
  Downloading Flask-Cors-2.0.1.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/flask-cors/setup.py) egg_info for package flask-cors

    no previously-included directories found matching 'docs/_build'
Downloading/unpacking sqlalchemy==0.9.4 (from -r requirements.txt (line 5))
  Downloading SQLAlchemy-0.9.4.tar.gz (4.5MB): 4.5MB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/sqlalchemy/setup.py) egg_info for package sqlalchemy

    warning: no files found matching '*.jpg' under directory 'doc'
    warning: no files found matching 'distribute_setup.py'
    warning: no files found matching 'sa2to3.py'
    warning: no files found matching 'ez_setup.py'
    no previously-included directories found matching 'doc/build/output'
Downloading/unpacking requests==2.4.3 (from -r requirements.txt (line 6))
  Downloading requests-2.4.3-py2.py3-none-any.whl (459kB): 459kB downloaded
Downloading/unpacking inflection==0.2.0 (from -r requirements.txt (line 7))
  Downloading inflection-0.2.0.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/inflection/setup.py) egg_info for package inflection

Downloading/unpacking tessera-client==0.4.5 (from -r requirements.txt (line 8))
  Downloading tessera-client-0.4.5.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/tessera-client/setup.py) egg_info for package tessera-client

Downloading/unpacking Werkzeug>=0.7 (from flask==0.10.1->-r requirements.txt (line 1))
  Downloading Werkzeug-0.10.4-py2.py3-none-any.whl (293kB): 293kB downloaded
Downloading/unpacking Jinja2>=2.4 (from flask==0.10.1->-r requirements.txt (line 1))
  Downloading Jinja2-2.8-py2.py3-none-any.whl (263kB): 263kB downloaded
Downloading/unpacking itsdangerous>=0.21 (from flask==0.10.1->-r requirements.txt (line 1))
  Downloading itsdangerous-0.24.tar.gz (46kB): 46kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/itsdangerous/setup.py) egg_info for package itsdangerous

    warning: no previously-included files matching '*' found under directory 'docs/_build'
Requirement already satisfied (use --upgrade to upgrade): setuptools in ./env/lib/python2.7/site-packages (from flask-sqlalchemy==1.0->-r requirements.txt (line 2))
Downloading/unpacking alembic>=0.6 (from flask-migrate==1.2->-r requirements.txt (line 3))
  Downloading alembic-0.8.2.tar.gz (931kB): 931kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/alembic/setup.py) egg_info for package alembic

    warning: no files found matching '*.jpg' under directory 'docs'
    warning: no files found matching '*.sty' under directory 'docs'
    warning: no files found matching '*.dat' under directory 'tests'
    no previously-included directories found matching 'docs/build/output'
Downloading/unpacking Flask-Script>=0.6 (from flask-migrate==1.2->-r requirements.txt (line 3))
  Downloading Flask-Script-2.0.5.tar.gz (42kB): 42kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/Flask-Script/setup.py) egg_info for package Flask-Script

    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
Downloading/unpacking Six (from flask-cors==2.0.1->-r requirements.txt (line 4))
  Downloading six-1.10.0-py2.py3-none-any.whl
Downloading/unpacking MarkupSafe (from Jinja2>=2.4->flask==0.10.1->-r requirements.txt (line 1))
  Downloading MarkupSafe-0.23.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/MarkupSafe/setup.py) egg_info for package MarkupSafe

Downloading/unpacking Mako (from alembic>=0.6->flask-migrate==1.2->-r requirements.txt (line 3))
  Downloading Mako-1.0.2.tar.gz (564kB): 564kB downloaded
  Running setup.py (path:/tmp/pip-build-yBawGx/Mako/setup.py) egg_info for package Mako

    warning: no files found matching '*.xml' under directory 'examples'
    warning: no files found matching '*.mako' under directory 'examples'
    warning: no files found matching 'distribute_setup.py'
    warning: no files found matching 'ez_setup.py'
    no previously-included directories found matching 'doc/build/output'
Downloading/unpacking python-editor>=0.3 (from alembic>=0.6->flask-migrate==1.2->-r requirements.txt (line 3))
  Downloading python-editor-0.4.tar.gz
  Running setup.py (path:/tmp/pip-build-yBawGx/python-editor/setup.py) egg_info for package python-editor

Installing collected packages: flask, flask-sqlalchemy, flask-migrate, flask-cors, sqlalchemy, requests, inflection, tessera-client, Werkzeug, Jinja2, itsdangerous, alembic, Flask-Script, Six, MarkupSafe, Mako, python-editor
  Running setup.py install for flask

    warning: no files found matching '*' under directory 'tests'
    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
    warning: no previously-included files matching '*.pyc' found under directory 'examples'
    warning: no previously-included files matching '*.pyo' found under directory 'examples'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
  Running setup.py install for flask-sqlalchemy

    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
  Running setup.py install for flask-migrate

  Running setup.py install for flask-cors

    no previously-included directories found matching 'docs/_build'
  Running setup.py install for sqlalchemy
    building 'sqlalchemy.cprocessors' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c lib/sqlalchemy/cextension/processors.c -o build/temp.linux-x86_64-2.7/lib/sqlalchemy/cextension/processors.o
    lib/sqlalchemy/cextension/processors.c:10:20: fatal error: Python.h: No such file or directory
     #include <Python.h>
                        ^
    compilation terminated.
    ***************************************************************************
    command 'x86_64-linux-gnu-gcc' failed with exit status 1
    WARNING: The C extension could not be compiled, speedups are not enabled.
    Failure information, if any, is above.
    Retrying the build without the C extension now.
    ***************************************************************************

    warning: no files found matching '*.jpg' under directory 'doc'
    warning: no files found matching 'distribute_setup.py'
    warning: no files found matching 'sa2to3.py'
    warning: no files found matching 'ez_setup.py'
    no previously-included directories found matching 'doc/build/output'
    ***************************************************************************
    WARNING: The C extension could not be compiled, speedups are not enabled.
    Plain-Python build succeeded.
    ***************************************************************************
  Running setup.py install for inflection

  Running setup.py install for tessera-client

  Running setup.py install for itsdangerous

    warning: no previously-included files matching '*' found under directory 'docs/_build'
  Running setup.py install for alembic

    warning: no files found matching '*.jpg' under directory 'docs'
    warning: no files found matching '*.sty' under directory 'docs'
    warning: no files found matching '*.dat' under directory 'tests'
    no previously-included directories found matching 'docs/build/output'
    Installing alembic script to /src/tessera/tessera-server/env/bin
  Running setup.py install for Flask-Script

    warning: no previously-included files matching '*.pyc' found under directory 'docs'
    warning: no previously-included files matching '*.pyo' found under directory 'docs'
    no previously-included directories found matching 'docs/_build'
    no previously-included directories found matching 'docs/_themes/.git'
  Running setup.py install for MarkupSafe

    building 'markupsafe._speedups' extension
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c markupsafe/_speedups.c -o build/temp.linux-x86_64-2.7/markupsafe/_speedups.o
    markupsafe/_speedups.c:12:20: fatal error: Python.h: No such file or directory
     #include <Python.h>
                        ^
    compilation terminated.
    ==========================================================================
    WARNING: The C extension could not be compiled, speedups are not enabled.
    Failure information, if any, is above.
    Retrying the build without the C extension now.

    ==========================================================================
    WARNING: The C extension could not be compiled, speedups are not enabled.
    Plain-Python installation succeeded.
    ==========================================================================
  Running setup.py install for Mako

    warning: no files found matching '*.xml' under directory 'examples'
    warning: no files found matching '*.mako' under directory 'examples'
    warning: no files found matching 'distribute_setup.py'
    warning: no files found matching 'ez_setup.py'
    no previously-included directories found matching 'doc/build/output'
    Installing mako-render script to /src/tessera/tessera-server/env/bin
  Running setup.py install for python-editor

Successfully installed flask flask-sqlalchemy flask-migrate flask-cors sqlalchemy requests inflection tessera-client Werkzeug Jinja2 itsdangerous alembic Flask-Script Six MarkupSafe Mako python-editor
Cleaning up...
Downloading/unpacking invoke==0.8.2 (from -r dev-requirements.txt (line 1))
  Downloading invoke-0.8.2.tar.gz (116kB): 116kB downloaded
  Running setup.py (path:/tmp/pip-build-DTmr4O/invoke/setup.py) egg_info for package invoke

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
Downloading/unpacking invocations==0.6.1 (from -r dev-requirements.txt (line 2))
  Downloading invocations-0.6.1.tar.gz
  Running setup.py (path:/tmp/pip-build-DTmr4O/invocations/setup.py) egg_info for package invocations
    /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'requirements'
      warnings.warn(msg)

Downloading/unpacking spec==0.11.1 (from -r dev-requirements.txt (line 3))
  Downloading spec-0.11.1.tar.gz
  Running setup.py (path:/tmp/pip-build-DTmr4O/spec/setup.py) egg_info for package spec

Downloading/unpacking nose==1.3.0 (from -r dev-requirements.txt (line 4))
  Downloading nose-1.3.0.tar.gz (404kB): 404kB downloaded
  Running setup.py (path:/tmp/pip-build-DTmr4O/nose/setup.py) egg_info for package nose

    no previously-included directories found matching 'doc/.build'
Requirement already satisfied (use --upgrade to upgrade): six in ./env/lib/python2.7/site-packages (from spec==0.11.1->-r dev-requirements.txt (line 3))
Installing collected packages: invoke, invocations, spec, nose
  Running setup.py install for invoke

    warning: no previously-included files matching '*' found under directory 'docs/_build'
    warning: no previously-included files matching '*.pyc' found under directory 'tests'
    warning: no previously-included files matching '*.pyo' found under directory 'tests'
    Installing inv script to /src/tessera/tessera-server/env/bin
    Installing invoke script to /src/tessera/tessera-server/env/bin
  Running setup.py install for invocations
    /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'requirements'
      warnings.warn(msg)

  Running setup.py install for spec

    Installing spec script to /src/tessera/tessera-server/env/bin
  Running setup.py install for nose

    no previously-included directories found matching 'doc/.build'
    Installing nosetests script to /src/tessera/tessera-server/env/bin
    Installing nosetests-2.7 script to /src/tessera/tessera-server/env/bin
Successfully installed invoke invocations spec nose
Cleaning up...
==> Compiling frontend...

root@5b3a1a257769:/src/tessera# ./script/server
2015-10-16 17:31:07,378 INFO     [werkzeug]  * Running on http://<IP_ADDRESS>:5000/ (Press CTRL+C to quit)
2015-10-16 17:31:07,380 INFO     [werkzeug]  * Restarting with stat

When navigating to the front page, get a lot of 404 errors, the page doesn't display correctly:
2015-10-16 17:31:18,741 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /dashboards/create/ HTTP/1.1" 200 -
2015-10-16 17:31:18,896 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/css/bundle.css HTTP/1.1" 404 -
2015-10-16 17:31:18,902 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/themes/bootstrap-light.css HTTP/1.1" 404 -
2015-10-16 17:31:18,904 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/tessera-typography.css HTTP/1.1" 404 -
2015-10-16 17:31:18,908 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/themes/tessera-light.css HTTP/1.1" 404 -
2015-10-16 17:31:18,911 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/tessera.css HTTP/1.1" 404 -
2015-10-16 17:31:18,916 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/bundle.js HTTP/1.1" 404 -
2015-10-16 17:31:18,919 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:18] "GET /static/tessera.js HTTP/1.1" 404 -
2015-10-16 17:31:22,058 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /dashboards/create/ HTTP/1.1" 200 -
2015-10-16 17:31:22,172 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/css/bundle.css HTTP/1.1" 404 -
2015-10-16 17:31:22,173 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/themes/bootstrap-light.css HTTP/1.1" 404 -
2015-10-16 17:31:22,175 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/tessera-typography.css HTTP/1.1" 404 -
2015-10-16 17:31:22,178 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/themes/tessera-light.css HTTP/1.1" 404 -
2015-10-16 17:31:22,181 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/tessera.css HTTP/1.1" 404 -
2015-10-16 17:31:22,184 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/bundle.js HTTP/1.1" 404 -
2015-10-16 17:31:22,188 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:22] "GET /static/tessera.js HTTP/1.1" 404 -
2015-10-16 17:31:29,356 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET / HTTP/1.1" 200 -
2015-10-16 17:31:29,473 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/css/bundle.css HTTP/1.1" 404 -
2015-10-16 17:31:29,478 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/themes/bootstrap-light.css HTTP/1.1" 404 -
2015-10-16 17:31:29,480 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/tessera-typography.css HTTP/1.1" 404 -
2015-10-16 17:31:29,483 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/themes/tessera-light.css HTTP/1.1" 404 -
2015-10-16 17:31:29,485 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/tessera.css HTTP/1.1" 404 -
2015-10-16 17:31:29,487 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/bundle.js HTTP/1.1" 404 -
2015-10-16 17:31:29,490 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:29] "GET /static/tessera.js HTTP/1.1" 404 -
2015-10-16 17:31:31,698 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:31] "GET /static/css/bundle.css HTTP/1.1" 404 -
2015-10-16 17:31:31,700 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:31] "GET /static/themes/bootstrap-light.css HTTP/1.1" 404 -
2015-10-16 17:31:31,704 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:31] "GET /static/tessera-typography.css HTTP/1.1" 404 -
2015-10-16 17:31:31,707 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:31] "GET /static/themes/tessera-light.css HTTP/1.1" 404 -
2015-10-16 17:31:31,711 INFO     [werkzeug] <IP_ADDRESS> - - [16/Oct/2015 17:31:31] "GET /static/tessera.css HTTP/1.1" 404 -

@tgrabiec The 404s are because something went wrong compiling the front end code on your system.
There should be a lot more output after this in your log:
==> Compiling frontend...

What happens if you run grunt in tessera-frontend?

@aalpern Initially when I typed grunt, I got bash: grunt: command not found. Then I installed it with npm install -g grunt-cli but then I get no output when running it, regardless of where I run it:
root@417ec6a19d84:/src/tessera# cd tessera-frontend/
root@417ec6a19d84:/src/tessera/tessera-frontend# grunt
root@417ec6a19d84:/src/tessera/tessera-frontend#
root@f7e6449fe60c:/src/tessera# grunt asdasd
root@f7e6449fe60c:/src/tessera#

# nodejs --version
v0.10.29

I'm running current debian image inside docker.

I'm afraid you're going to need to debug your grunt and/or node.js installation on debian - that grunt failure is what's going wrong.

So, I was able to sort of reproduce an issue somewhat like this, using the current debian docker image -- basically, Node JS 0.10 is what ships out of the box on debian, and is positively ancient and unsupported. Most of the packages Tessera uses require a much more recent  version (like 4.0 at least)
Doing something like:
curl -sL https://deb.nodesource.com/setup_6.x | bash -
apt-get install -y nodejs

on debian will install NodeJS 6.0, and everything should be fine after that (assuming python and python-pip are also installed)


System-store Hacks (DO NOT MERGE)

This PR is here so runtime folks can see the hacking I did to make a recipe-with-custom-store into a serializable Arc.
Essentially just a convenient diff.

Old, taking off the radar.


Postprocessing bug

When I ran my tests/small.ini configuration, it failed on some error with lambda wanting two arguments, but just one was given. I solved this in my branch by removing the second (unused) argument of the lambda on line 36 in learning_utils, but I'm not sure whether this does not break anything else. Can you have a look at this, @jindrahelcl?

Here is the traceback:
Traceback (most recent call last):

  File "/opt/python/2.7.10/lib/python2.7/runpy.py", line 162, in _run_module_as_main

    "__main__", fname, loader, pkg_name)

  File "/opt/python/2.7.10/lib/python2.7/runpy.py", line 72, in _run_code

    exec code in run_globals

  File "/home/travis/build/ufal/neuralmonkey/neuralmonkey/train.py", line 149, in <module>

    main()

  File "/home/travis/build/ufal/neuralmonkey/neuralmonkey/train.py", line 142, in main

    minimize_metric=args.minimize)

  File "neuralmonkey/learning_utils.py", line 194, in training_loop

    val_tgt_sentences = postprocess(val_raw_tgt_sentences)

TypeError: <lambda>() takes exactly 2 arguments (1 given)

Yeah, that's OK. I was removing the second argument which was the whole dataset and which was unused everywhere else, but I did not try that without a postprocessor.


Updated Makefile

Signed-off-by: Soumya Ghosh Dastidar<EMAIL_ADDRESS>What this PR does / why we need it:

Added linting and depcheck for frontend
Throws error for all linting and dependency failures

Checklist

[ ] Does this PR have a corresponding GitHub issue?
[ ] Have you included relevant README for the chaoslib/experiment with details?
[ ] Have you added debug messages where necessary?
[ ] Have you added task comments where necessary?
[ ] Have you tested the changes for possible failure conditions?
[ ] Have you provided the positive & negative test logs for the litmusbook execution?
[ ] Does the litmusbook ensure idempotency of cluster state?, i.e., is cluster restored to original state?
[ ] Have you used non-shell/command modules for Kubernetes tasks?
[ ] Have you (jinja) templatized custom scripts that is run by the litmusbook, if any?
[ ] Have you (jinja) templatized Kubernetes deployment manifests used by the litmusbook, if any?
[ ] Have you reused/created util functions instead of repeating tasks in the litmusbook?
[ ] Do the artifacts follow the appropriate directory structure?
[ ] Have you isolated storage (eg: OpenEBS) specific implementations, checks?
[ ] Have you isolated platform (eg: baremetal kubeadm/openshift/aws/gcloud) specific implementations, checks?
[ ] Are the ansible facts well defined? Is the scope explicitly set for playbook & included utils?
[ ] Have you ensured minimum/careful usage of shell utilities (awk, grep, sed, cut, xargs etc.,)?
[ ] Can the limtusbook be executed both from within & outside a container (configurable paths, no hardcode)?
[ ] Can you suggest the minimal resource requirements for the litmusbook execution?
[ ] Does the litmusbook job artifact carry comments/default options/range for the ENV tunables?
[ ] Has the litmusbooks been linted?

Depcheck should not be in frontend code. It should in circleci

Depcheck should not be in frontend code. It should in circleci

It is in circleci, it is added to npm scripts, just like npm run lint.


ignition-files: always relabel /var on first boot

This is in spirit a backport of [1]. But it's as relevant on the spec2x
branch.
[1] https://github.com/coreos/ignition-dracut/blob/85f2e6558c5e1651e2934849b8ad1d74a5c7ad74/dracut/30ignition/coreos-populate-var.sh#L36

(Still testing this)

RHCOS will need this to enable mounting + relabeling additional disks under /var
Thanks @jlebon for shepherding this change!

OK, this is updated and tested now! :heavy_check_mark:
One note I'll make is that I couldn't actually reproduce the issue in https://bugzilla.redhat.com/show_bug.cgi?id=1699107 on RHCOS even without this patch. Since the policy is correct right from boot, systemd creates the directory for the mount point with the right label.
That said, we still need this patch for Ignition configs that want to drop files in filesystems that are mounted under /var. E.g. without this patch, the config below will leave /var/lib/containers/barbaz unlabeled:
"storage": {
    "disks": [
        {
            "device": "/dev/vdb",
            "wipeTable": true,
            "partitions": [
                {
                    "label": "CNTNR",
                    "sizeMiB": "0",
                    "startMiB": "0"
                }
            ]
        }
    ],
    "filesystems": [
        {
            "name": "containers",
            "mount": {
                "device": "/dev/vdb1",
                "format": "xfs",
                "label": "CNTNR",
                "wipeFilesystem": true
            }
        }
    ],
    "directories": [
        {
            "filesystem": "containers",
            "path": "/barbaz"
        }
    ]
}


When inserting a token in front of the previous token's trivia, only override its trailing trivia if the previous trivia is not empty

Otherwise, we might be dropping spaces that are necessary to form valid Swift source.

@swift-ci Please test


schedule: fix hot write and read cases

What have you changed? (required)
This PR fixes the hot_write and hot_read cases. The current if statement might lead to value to be nil when the region exists in writeFlow.

What are the type of the changes (required)?

Bug fix (non-breaking change which fixes an issue)

How has this PR been tested (required)?

Manual test

Does this PR affect documentation (docs/docs-cn) update? (optional)

Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

PTAL @nolouch

LGTM.


⚠ Samsung has degraded performance

In f0452a1, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2470 ms

Resolved: Samsung performance has improved in 2b931b9.


[PDI-18132] Null Pointer exception is thrown in Oracle Bulk Loader wh…

…en the data have Trailing Nulls.
@pentaho-lmartins @ppatricio @ssamora @bcostahitachivantara

:warning: Build finished in 35m 29s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.orabulkloader.OraBulkLoaderTest.testGetControlFileContents (click to expand)
The Expected Control File Contents do not match Actual Contents expected:<...',' ENCLOSED BY '"'
[](null,
null CHAR)> but was:<...',' ENCLOSED BY '"'
[TRAILING NULLCOLS
](null,
null CHAR)>

Tests run: 3677, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 34m 59s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3677, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


runtime: Add DataBroker

It would be great if some unit tests ala databroker_test.cpp were supplied so that all intended usage scenarios are tested and also serve as exemplary usage.

As discussed: Postponed.

Squashed and rebased on master.


Support custom search key list when searching

In this PR, I added another option keys in search method to be able to specify a list of key when performing index search:
fuse.search('od man', { keys: ['title'] }) // returns 1 item

fuse.search('od man', { keys: ['tags'] }) // returns an empty list

It's quite useful in such scenarios:

When there is a lot of noise in the all-keys results, and there is a key filter in the search bar so users could specify which keys to search
When we only care about one or few keys, especially we hope the ordering should be based on those specified keys rather than all

@krisk hopefully you could help take a look at this PR in the near future.


feat: support topologyspreadconstraints in deployments

Add support for configuring https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/

@fjogeleit shall i bump the charts or is it something that you normally handle?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.374%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3892

Relevant Lines:
4124

💛  - Coveralls

@Kostavro I will bump the versions when I prepare the release, thanks for your contribution


Duplicate values in enum extensions are not diagnosed until publish, with weird error if used

Given this code:
enumextension 50100 Test extends "Workflow Approver Type"
{
    value(51045; Test)
    {
        Caption = 'Test';
    }

    value(51045; Test)
    {
        Caption = 'Test';
    }
}

No diagnostic is emitted in the PROBLEMS tab, despite the obvious duplicate value!
Only upon publishing are we told the following:

The request for path /BC/dev/apps?tenant=default&SchemaUpdateMode=synchronize&DependencyPublishingOption=default failed with code UnprocessableEntity. Reason: An error occurred while applying changes from the object of type 'EnumExtension' with ID '50100' in the 'ALProject1 by Default publisher <IP_ADDRESS>' app to the application object of type 'Enum' with the ID '460'. Failing delta: Type: EnumValueAddDelta; TargetKind: Other; OrdinalValue: 51045 The error was: InvalidOperationException - Metadata delta application failed due to the following error(s): The enum 'Workflow Approver Type' already has a value with the ordinal value: '51045'.; The enum 'Workflow Approver Type' already has a value with the name: 'Test'.

If we then use said value(s)... we instead (not also) get a much more confusing error - which (assuming then enumextension is in another file, far away, forgotten about, etc.) leaves us chasing red herrings until we reduce down the code and find that we had simply duped a value.
codeunit 50100 Test
{
    trigger OnRun()
    var
        WorkflowApproverType: Enum "Workflow Approver Type";
    begin
        if WorkflowApproverType = WorkflowApproverType::Test then
            ;
    end;
}

...which gives...

The request for path /BC/dev/apps?tenant=default&SchemaUpdateMode=synchronize&DependencyPublishingOption=default failed with code UnprocessableEntity. Reason: One or more errors occurred.
Failure while emitting method. Object:'Codeunit Test' Method:'ApprovalsMgmtOnCreateApprovalRequestsOnElseCase(Record "Workflow Step Argument", var Record "Approval Entry")'
Unexpected value 'NoConversion' of type 'Microsoft.Dynamics.Nav.CodeAnalysis.ConversionKind'

Please revise so an error is given in the PROBLEMS tab, stopping the build before deployment with a clear explanation of the problem, rather than not erroring during compilation and then potentially confusing devs a lot during release (as per scenario 2).

Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 7.2.475273
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Sorry, the 2nd error quoted refers to my original code, which was an event subscriber, but running the simpler code given will give the same error, just for a different method.

To confirm, there is no diagnostic for this obviously wrong code:

This has separately been fixed, by emitting CodeCop diagnostic AL0486:

by this update:

Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 10.3.731181
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Thanks! Closing accordingly.


Fix falco driver loader to follow redirects

What type of PR is this?
/kind bug
/kind feature
/area build
/area integrations
What this PR does / why we need it:
This PR fix a curl execution into falco-driver-loader. The command need -L to follow redirects, the URL "https://dl.bintray.com/falcosecurity/driver/XXXXX" it's a CDN, and the exact behaviour (whether you get redirected or not) might depend on your location, so to fix this we need to set the -L to curl cuz curl does not follow redirects by default.
Which issue(s) this PR fixes:
This PR fix a curl execution into falco-driver-loader. The command need -L to follow redirects, the URL "https://dl.bintray.com/falcosecurity/driver/XXXXX" it's a CDN, and the exact behaviour (whether you get redirected or not) might depend on your location, so to fix this we need to set the -L to curl cuz curl does not follow redirects by default.
Does this PR introduce a user-facing change?:
No.

NONE

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

6cc0240 fix rule naming following naming conventionSigned-off-by: Stuxend<EMAIL_ADDRESS>cd0731e Merge branch 'fix-falco-driver-loader-to-follow-redirects' of https://github.com/Stuxend/falco into fix-falco-driver-loader-to-follow-redirects

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Stuxend: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign mstemm
You can assign the PR to them by writing /assign @mstemm in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.2.346

from: https://github.com/jenkins-x/jx

/retest


Jest + Supertest + Restify not working

node 5.4.1
jest-cli ^12.0.2
restify ^4.0.4
supertest ^1.2.0
I want to use Jest to do backend nodejs REST API testing also. I do not want to install another test tool like mocha etc.
'use strict';
var request = require('supertest')(require('../appServer'));
describe('Test', function () {
    it('works', function () {
        request
            .get('/api')
            .expect(200)
            .end(function (err, res) {
                expect(err).toEqual(null);
            });
    });
});

In above code appServer returns a restify server instance. I am using supertest because I want to do code coverage as well. But I get below error.
Error: Cannot find module '_http_common' from 'stream.js'
    at Runtime._resolveNodeModule (/Users/me/Documents/workspace/node_modules/jest-cli/src/Runtime/Runtime.js:451:11)
    at Object.<anonymous> (/Users/me/Documents/workspace/node_modules/spdy/lib/spdy/stream.js:13:20)
    at Object.<anonymous> (/Users/me/Documents/workspace/node_modules/spdy/lib/spdy.js:19:15)

Thank you for reporting this issue.  If you'd like to test your modules/components "supertest" and "appServer" you'll have to unmock them first:
jest.unmock('supertest').unmock('../appServer');

Oops, wrong button, reopening :)
If you can't figure it out, can you provide a repository that points this issue out so I can take a closer look? Thank you :)

Below is my jest config in package.json

"jest": {
"automock": false,
"bail": true,
"collectCoverage": true,
"moduleFileExtensions": [
"js"
],
"scriptPreprocessor": "./node_modules/babel-jest",
"testFileExtensions": [
"js"
],
"testPathDirs": [
"./client/src"
],
"testPathIgnorePatterns": [
"/node_modules/",
"/server/"
]
}

Have you reopened? It still says closed.

I boarded a long distance flight and my internet was cut-off before I could reopen this issue.

@cpojer Any updates?

No, you haven't provided a full repository that highlights this problem so there is no way for me to confirm your issue.

Below is the code. I did not want to create a repo for two files. Please try and let me know
./package.json
{
  "name": "jest-restify-supertest",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "jest"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "jest-cli": "^12.0.2",
    "supertest": "^1.2.0"
  },
  "jest": {
    "automock": false,
    "bail": true,
    "collectCoverage": true,
    "moduleFileExtensions": [
      "js"
    ],
    "testFileExtensions": [
      "js"
    ],
    "testPathIgnorePatterns": [
      "/node_modules/",
      "/coverage/"
    ]
  },
  "dependencies": {
    "restify": "^4.0.4"
  }
}

./tests/index-test.js
'use strict';

jest.disableAutomock();
jest.unmock('supertest').unmock('restify');
var restify = require('restify');
var app = restify.createServer();

app.get('/user', function(req, res) {
  res.status(200).json({ name: 'tobi' });
});

var request = require('supertest')(app);
request(app)
  .get('/user')
  .expect('Content-Type', /json/)
  .expect('Content-Length', '15')
  .expect(200)
  .end(function(err, res) {
    if (err) throw err;
  });

Error Message
My-MacBook-Pro:jest-restify-supertest me$ npm test

><EMAIL_ADDRESS>test /Users/me/Documents/workspace/self/jest-restify-supertest
> jest

Using Jest CLI v12.0.2, jasmine2
Running 1 test suite...[SECURITY] node-uuid: crypto not usable, falling back to insecure Math.random()
 FAIL  __tests__/index-test.js
● Runtime Error
Error: Cannot find module '_http_common' from 'stream.js'
    at Runtime._resolveNodeModule (/Users/me/Documents/workspace/self/jest-restify-supertest/node_modules/jest-cli/src/Runtime/Runtime.js:451:11)
    at Object.<anonymous> (/Users/me/Documents/workspace/self/jest-restify-supertest/node_modules/spdy/lib/spdy/stream.js:13:20)
    at Object.<anonymous> (/Users/me/Documents/workspace/self/jest-restify-supertest/node_modules/spdy/lib/spdy.js:19:15)
----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
----------|----------|----------|----------|----------|----------------|
All files |      100 |      100 |      100 |      100 |                |
----------|----------|----------|----------|----------|----------------|

npm ERR! Test failed.  See above for more details.

I think this should be fixed by setting the "testEnvironment" config option to "node". jsdom doesn't deal well with this stuff.

I ran over this issue today and here is how I deal with it.
package.json:
...
"jest": {
    "testEnvironment": "node",
    "testPathIgnorePatterns": [
      "/node_modules/",
      "/dist/"
    ]
  }
...

__tests__/index.test.js:
import server from '../src/index.js';
import request from 'supertest';

afterEach(() => {
    server.close();
});

describe('Restify', () => {
    test('index route should return 200', (done) => {
        request(server)
            .get('/')
            .expect(200, done)
    });
});

I think the key is to pass done to the callback


Please add the ability to show the first task (top of the list) on the top left corner of the screen!

Description
It'd be really cool if the mod showed me in a minimalist and non-intrusive way what my next thing to do is, or the next few (2-5 maybe)
Reproduction
No response

You can show your currently active task in the top-left by enabling the "show active task" option in the settings, which should do what you're looking for. I don't have plans to make an alternative GUI at this time. Thanks for using the mod!


Captcha Page Fails To Load

Describe the bug

Run the program, it logs out and then gives a URL for the captcha page (https://epic.exmaple.com/?targetID=<Random numbers/letters"
Clicking on the link in the terminal window or the discord notification (as I have those on) both give a page that says site can't be reached.  See screenshot below
Screenshots or Logs

Configuration (please complete the following information):

Browser: Chrome

me too

I understand that I have missed some information. I need to use reverse proxy or intranet penetration or DDNS to access the 3000 port of the host. The domain name is filled in config“ https://epic.xxx.com ”。

How did you resolve it?
Thanks!

就像我说的，使用内网穿透或者反向代理或者DDNS，我使用的是DDNS，购买域名并将3000端口转发到外部端口上。事实上还有个办法可以解决，将“targetID=<Random numbers/letters>"拷贝到内网IP和端口后面，就像这样:http://<IP_ADDRESS>?targetID=<Random numbers/letters>也可以解决，需要每次验证过期后手动执行。

As I said, I use intranet penetration or reverse proxy or DDNS. I use DDNS to purchase domain names and forward 3000 ports to external ports. In fact, there is another way to solve this problem. Copy "targetID=<Random numbers/letters>" to the back of the intranet IP and port, as follows: http://<IP_ADDRESS>?targetID= <Random numbers/letters>can also be solved. It needs to be executed manually after each validation expires.

You mentioned that and I went back through and I didn't add in the "localtunnel": true statement.  I did that, the captcha now appears and I enter it then it says

Login returned error: Sorry the credentials you are using are invalid.

Then it just re-enters info then asks for captcha again.  I double-checked password and email that was correct.  I reset password and 2FA and returned in all the information with the same result.  Not sure what else is causing it to fail.

Regarding the original comment, the reason you get a "This site can't be reached" is because https://epic.exmaple.com is an example URL (with a typo). You need to replace it in your config file with the base URL of your server, i.e. the address at which your program will listen.

No longer relevant in latest version


Plugin not working in Godot 4.0

I can't enable the plugin on Godot 4.0 as it throws this error:
Unable to load addon script from path: 'res://addons/godot-lua-pluginscript/plugin/plugin.gd'. This might be due to a code error in that script. Disabling the addon at 'res://addons/godot-lua-pluginscript/plugin/plugin.cfg' to prevent further errors.

Fedora Linux 37
Godot version 4.0 stable
Latest luapluginscript release

Hi @mkukiro.
This plugin relies on GDNative/PluginScript, a Godot 3.X only technology, and does not/will not support Godot 4.
For now, the only "use Lua from Godot" plugin I know that supports Godot 4 is WeaselGames/godot_luaAPI. There is also Fumohouse/godot-luau-script for using Luau, a variant of Lua, in Godot.
I'm already planning on a port of a Lua PluginScript-like addon for Godot 4, but since it needs a complete rewrite, it will take some time (maybe a lot of time, I'm not sure).

I've added a WARNING in the README about that, since you are not the first one to come here with an issue about Lua PluginScript not working with Godot 4. I also submitted an edit to the Asset Library adding "(Godot 3.X)" to the asset's name, to make it clear that this does not support Godot 4.


Refactor to f-strings

Refactor .format() and string concatenation to f-strings, since we now have f-string support (Python 3.6!) on the bot host.

Closed in #28.


Create lean forward and backward movement.

For now we are using flows to figure out movements. If/when we decide we want  canned movements we can revisit this issue.


Missing address and phone format for India

Description
I see that the address and phone format for India is missing in the address_formats and phone_formats files. However, I would be more than happy to add the same.
While addressing in India district names are commonly used, so I believe it should be present as one of the fields. Some more details about the address format in India can be found here.
Below is the address format based on my understanding-
{
    "countryCodes": ["in"],
    "format": [
      ["housenumber", "street"],
      ["city", "postcode"],
      ["district"]
    ]
  }

Also, the phone number format used in India is +91 xxxx-nnnnnn, the details for which are here.
I am new here so it would be great if you could clarify on above before I raise a PR.
Screenshots
No response

Done in #9482


Feature request: Download Station API

I'd like to see the Download Station API included in this, please.

I came here wondering if it supported this...question answered!

Hi Richard, saw a question asked four years ago, in the docs there is... the api doc and in link. I can provide support the best I can. Code was all tested for api at the time so should do what the spec said.


Support basic CRUD operations for TNS entries

I have a use case where I would need to modify the entries in the tnsnames.ora file. Currently, it seems like the only way to do this is by hacking serialize and unserialize.
In addition, I need to be able to do so across multiple processes without contention issues. This should be fairly easy to implement. I'm thinking:

<tnsfile>.lock being created at the start of each transaction
When the transaction is finished, delete the lock file
Any transaction which updates the file should usleep until the lock file is removed (with a timeout, upon which a TransactionTimeoutException is thrown)

I'd be willing to take a stab at this, as I need this ASAP for one of my own projects. I can also create tests for it.
What are your thoughts?

I'm absolutely up for a feature like this, seems like it could definitely be useful!  I personally do not have time to do these changes in the near future, so if you want to have a go at it I'm all for it!

Still fleshing out some more tests, and will start once a few more are in place.

As an FYI I am moving on to another company and will no longer require this. If anyone wants to take it up, please feel free. I have not started on it.