[Event Extension Request] Codeunit 6620 "Copy Document Mgt." - new parameter in OnAfterCopyFieldsFromOldSalesHeader

Please add new parameter to the Event OnAfterCopyFieldsFromOldSalesHeader
[IntegrationEvent(false, false)]
local procedure OnAfterCopyFieldsFromOldSalesHeader(var ToSalesHeader: Record "Sales Header"; OldSalesHeader: Record "Sales Header"; MoveNegLines: Boolean; IncludeHeader: Boolean; FromDocType: Enum "Sales Document Type From"; RecalculateLines: Boolean)
begin
end;

CopyShiptoCodeFromInvToCrMemo(ToSalesHeader, FromSalesInvHeader, FromDocType);
CopyFieldsFromOldSalesHeader(ToSalesHeader, OldSalesHeader);
OnAfterCopyFieldsFromOldSalesHeader(ToSalesHeader, OldSalesHeader, MoveNegLines, IncludeHeader, FromDocType, RecalculateLines);
if RecalculateLines then begin
    if IncludeHeader then
        SavedDimSetId := ToSalesHeader."Dimension Set ID";
    CreateDimFromDefaultDim(0);
    if IncludeHeader then
        ToSalesHeader."Dimension Set ID" := SavedDimSetId;
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52831.


Intel SGX SDK v2.9.1 upgrade

Intel released Intel SGX SDK v2.9.1. We're preparing for an upgrade to v1.1.2.

rustc started supporting async in no_std since 03-25. our plan now is to use 04-07. please feel free to comment.


Implement  rank broadcast utilities in ShapeHelper and TosaBuilder

TOSA can only broadcast, if the rank of the operands match. This PR includes a small utility in the ShapeHelper if this is the case as well as infrastructure in the ONNX to TOSA conversion to make handling such cases easy. This is achieved by the TosaBuilder

@jenkins-droid test this please

Jenkins Linux amd64 Build #11498 [push] Implement  rank broadcas... started at 15:31

Jenkins Linux amd64 Build #11498 [push] Implement  rank broadcas... passed after 1 hr 14 min

Jenkins Linux s390x Build #11507 [push] Implement  rank broadcas... passed after 1 hr 32 min

Jenkins Linux ppc64le Build #10556 [push] Implement  rank broadcas... passed after 2 hr 0 min


Build failing

Found the problem: comment is currently in form //, but need #.

Closing because PR above fixed this issue


postgres appliance state machine

First, I'd like to apologize for the size of this. You're not reading the diff wrong, there are indeed over 4k lines of new code here. Most of that is the tests and the simulator supporting the tests, the state machine itself weighs in at 1k lines. I couldn't come up with an incremental way to deliver this, as it is a direct translation that doesn't make much sense in a partial state.

This adds a Go translation of the manatee-state-machine project from Joyent. It is translated verbatim with the following minor differences:

A few extra tests were added for completeness
Changes were made to translate from the Node.js async model to a more
straightforward single-threaded model that uses channels for coordination.
The term 'one-node-write-mode' (abbreviated as ONWM) was replaced
with 'singleton' as they are used interchangeably upstream.
Assertions were translated into panics wrapped in if statements.
Discoverd is used instead of Zookeeper.

The state machine provides a fault-tolerant system for running Postgres clusters that automatically fail over with minimal downtime and no possibility for data loss or split brain during failovers. The README linked above has a good overview and some diagrams. I expect we'll change this a bit to fit containers better, but this is a really good starting point.
A simulator is used for testing and is also available in an interactive REPL for experimenting with various scenarios.
Test coverage is at 87.9% with only assertions, a few error paths, and very rare cases not covered.

ping @lmars for review

Comments addressed.

LGTM pending last comment


Standaridization of gke installation docs

Notes for Reviewers
This PR fixes #9096
Signed commits

[ ✓] Yes, I signed my commits.

🚀 Preview for commit 95d8cc828076ca7e22f7c838fded065abc736cd6 at: https://65374a741878581aee12b91a--meshery-docs-preview.netlify.app


Need help regarding styling

I am using following style to add a line after each node as shown in image.
.tree .node-wrapper:after {
content: "";
position: absolute;
left: 0;
top: 0;
width: 100%;
height: 1px;
background-color: #d4d6da;
}

But I want the line to start from beginning, not with corresponding node location as shown in image. Please help me out.

Hi,
You can use the following option (10 is an example):
{
  levelPadding: 10
}

And then you can style the entire row, because the padding is achieved on a per node basis, and not for the entire children

thanks a lot


Are there any optimization tips?

I started to analyze webpack build and got next results (on dev machine, Intel(R) Core(TM) i7-1185G7):
General output time took 1 min, 12.42 secs,
ForkTsCheckerWebpackPlugin took 57.37 secs
This looks like the best place to start some optimizations, but I was not able to find anything surfing over the internet or reading through your readme files.
While it doesn't look very bad for local development, I often need to run this for 20+ packages in ci job with limited resources. It may take an hour to bundle everything. So reducing typecheck step for each package for 10 seconds would make a difference.
I'm using node 12, webpack 4, fork-ts-checker-webpack-plugin 5.2.1. Tried 6.5.0 and it appeared to be 15 seconds slower.
So, do you have any tips on how to speed up typechecking in a CI job? I

The plugin overhead is negligible and you should look for tips to optimize TypeScript :)
I can recommend this page: https://github.com/microsoft/TypeScript/wiki/Performance


Update github actions

Basic github actions to build and publish container images to ghcr.
Fixes https://github.com/deinstapel/eks-rolling-update/issues/3

Changelog needs to be removed


[examples] Improve Next.js setup

[ ] I have followed (at least) the PR section of the contributing guide.

@yordis thanks for the effort 🙏 , but this is not a direction we would like to take. I am closing the PR.


switching scene breaks because of NPC

When leaving main scene, switching breaks. This is because of the stats panel.
When the NPC is destroyed it should unwear all apps with it -- currently not happening.

This issue was fixed by https://github.com/webaverse/app/pull/3346


Can't report new issues when authentication providers are disabled

VS Code Version:
OS Version:

Steps to Reproduce:

Disable "GitHub authentication" and "Microsoft account" for performance and privacy reasons
Help > report an issue
I now get a message "No authentication provider 'github' is currently registered."

Does this issue occur when all extensions are disabled?: Yes/No

It's not a duplicate.


UI conflict with Tidy UI

Hello.
The new big buttons at the top of the window cause the bottom buttons of the module window to vanish (window needs to be scrolled) when MC is used in combination with Tidy UI.

Screenshot:
https://i.imgur.com/H3yk1mR.png

I will look into patching this but given that both of these modules do the same thing on this screen, my patch is most likely going to just disable TidyUI on the module management window.
As my import export does everything TidyUI does and more, it even supports TidyUI exports when importing. Does that sound like an acceptable patch, or do you have another suggestion? I am curious as I don't want to basically just disable a modules features.

Thanks for the quick reply. As long as Tidy UI's settings improvements keep working I can live with that. :)
Maybe consider making the (overly large) extra spacing and upper buttons font size optional? Leads to lots of scrolling and the upper buttons don't seem important (used often) enough to make them take up so much vertical space.

"Settings improvements" meaning the "Configure Settings" being collapsible thanks to Tidy UI. Modules being handled by MC is perfect and TUI's buttons being removed from the top is perfect.
Although, I just notice: TidyUI increases the Module Management window to full browser screen height and then keeps the buttons at the bottom fixed (no need to scroll to get to them). I like that very much, because having to do so much scrolling is something I don't like as UI experience (why use a large display to have small fixed sized windows?).

So I am not sure what you mean by the heading being larger, yes its bigger then default but still smaller the TidyUI's design. I thought I did a good job at hitting a good middle ground.

Now to be fair, my module does show only 15 modules at a time where the default screen is around 20 and TidyUI had a full length view, showing a lot more. Would a good compromise to do something similar to what TidyUI does, and make the module management window the full height? I would actually like that feature and will add that.
I actually plan to redo the "configure settings" window as well, which at that point would make it a choice over my module or TidyUI cause at that point the major features of both will exist in both modules and there would be no reason to support both.

TL;DR Would a good temporary compromise on the heading space be to just make the module window full height similar to TidyUI?

Larger was more about the combination of both modules. These are all minor things anyway. Having the window full height would be nice, because I personally like to have modules accessible as fast as possible if I go to that list. I don't know if others like that, though. And I can just use the Popout module for my personal preference.
Same with the spacing. Personally I even use the Compact Compendium module to get more entries on screen without scrolling. Even more so because all these lists are just headers anyway, not full journals that you read line by line. Cannot make everyone happy (unless there is an option) and the benefits of your module far outweigh the small drawbacks.
Love the new features and made sure that my own module makes good use of your buttons. Incidentally my module also was one of the "author field as array breaks stuff" ones, because I edited authors to author when I created the original manifest.
Not sure if we need the extra URL button instead of just clicking the version button, but both ways are fine.

I will look into a small patch to make my module and TidyUI work better together until I can add my own settings page. Cause I do agree with you, its a little annoying to have to scroll down cause of a header that my module basically makes obsolete anyways.
As for the spacing, I think this might be a, I use a 4k monitor issue and I enjoy the look of the extra spacing its easier on the eyes. However, I am not opposed to a "compact" setting that will help reduce the spacing and sizing for those who prefer things closer together.
Yeah, the authors field is kinda a headache, I've had 3 people this week reach out to me asking why their module authors don't show up right...
The URL button being seperate was the cause of foundry's recent change to the tags, it broke mine a little bit, so instead of modifying their tags, I just add my one. However, I am pretty sure I am going to merge the URL back into version, cause I kinda hate it personally. I just realized before I pushed out this update that I never added that tag back in for the 1.0.0 release.

I think the only time where the spacing even matters is when people go through modules for initial setup or troubleshooting. There is lots to try around and click then.  I use a 2k display, mostly with browser zoom set to 110% in Foundry (with browsers not adhering to Windows DPI settings, so it's real 100%).
Currently you are using 6 pixels above the version button and 9 pixels below. Without MC Foundry uses 4+4. Maybe make MC use 6+6 or 7+7 instead to give it a more symmetric appearance and cause just a bit less empty space?

Assuming you are referring to the content here:

I am only getting 7 and 8, not 6 and 9? If you are using TidyUI, the size might be different as it applies it stylings along with mine. As for the 1 pixel difference for me I assume its an issue with flex not being able to justify-content: center at a 0.5 value.

Ah, yes, sorry. Without other modules it is 7+8, with the same total of 15. Foundry uses 4+6 and Tidy UI uses 4+4.

What about this:

5+5 for 10...

Looks good, but only if this isn't too compressed for your own preference. The right ^ button looks a bit squished between the divider lines now. Maybe that button should shrink?
I also just notice that the text in version buttons is aligned towards the top of the box, while the content in the other buttons is more vertically centered.

Last nitpick, the uppermost button row is 35 px and the content slightly misaligned. The + and disk symbol are 11+9 with the dark lines starting at 12 even. The second row below is 34 px and the bottom buttons (Save Module settings) are also 34 px with pseudo 3D border and 30 px without.
So maybe the 1st row can lose a pixel on top just for symmetric perfectionism while we are already counting pixels.  ;)
Thanks again for the quick changes and being open for discussion. I do have a bit unhealthy relationship with free space and scrolling in modern UIs. Antivirus UIs are the worst, large text and icons in fixed sized windows that need lots of scrolling while I sit in front of a 30" display.

I think any smaller then that and it would bother me.
As for the sizing on the tags. I think I can fix it... But version specifically will be interesting because its actually the font awesome icon that is making the text look so weirdly placed. So I think for version I will have to add padding to the left to account for the size of the icon, then absolutely position it inside of that space. Its a little weird, but I can fix that too.
Any other bugs I can work on? I love the feedback and want to keep improving the module

Don't worry about being nitpicky, I spent the last week working on getting the export/import functionality working correctly and just wanted to push the update. I am a little OCD about UI/UX design, so I am all for cleaning up these per pixel issues.
Trust me in a week when I wouldn't be working on anything, I would be look at all of these issue and they would start eating at the back of my head. lol

The mouseover tooltip of the author(s) button looks a bit weird saying "author authors-1".
Other than that I cannot think of anything at this moment. Once I find time I will give the new presets feature a test-ride. I had another module for this installed once, but it broke with v9 (or maybe wasn't reliable to begin with).

 For one author, it shows one person, for two it shows two and 3+ it shows 3 people.
I need to localize that and it will fix that, but for now, jank code. lol

Then go and publish! ;)

Is this both more minimal for you and also big enough for you all at once?!?!?! lol

This will be out in update a little later today.

Made the header inputs a max of 30px tall reducing the header size by at least 10 pixels in tall.
Reduced the list size from 35px to 25px and fixed weird formatting of tags
Increased button footer size to 50px, to make it easier to see and click.

Yes, looks good to me. 35 modules on your screen (Tidy UI on my screen displays 43). I will happily test it.
I assume the "taskbar" at the lower edge is some kind of Foundry module, not the OS taskbar that the module window now hangs over?

You might want to recount that (Also thats at 2k cause you said you were using 2k yesterday). I count 39 modules on screen and have 40 with TidyUI... Almost the same amount. lol
Yeah its Taskbar by Ripper with some UI/UX work I did.

Side by Side

Looks good except for a small graphical glitch with the last ^ arrow button (lower right) on top of the double line.
https://i.imgur.com/6llfDsB.png

Its where the row just perfectly meets the footer border of the bottoms

@Weissrolf Figured I'd show you this before hand to see if I can get your feedback?

Looks very nice. Also more pleasant buttons compared to the up arrow buttons in the module configuration.
Having them on the right side might lead to easier misclicks, though, because the button is so far away from the name, even with the rows being slightly colored. Or can the whole row be clicked to expand the settings (which would safe us from aiming at the button)?

... Those buttons may or may not match these ones now...
Yeah, but button is just there, the whole row is clickable.

I like the alternating row colors. And I don't care if the icons are on the right or the left. At least with Tidy UI, the whole row is clickable for it to be collapsible/uncollapsible, so as long as it still does that the icon positioning is insignificant

@dmrickey Its actually a setting called Big Picture Mode

All of this has been included in the latest release 1.1.5


version-02

Remove the sentence "which cannot be represented using jCard" in the following:
JSContact ([draft-ietf-jmap-jscontact]) provides a simpler and more
efficient representation for contact information.  In addition, it
provides a means to represent internationalised and unstructured
contact information which cannot be represented using jCard.  Support
for internationalised contact information has been recognised being
necessary to facilitate the future internationalisation of
registration data directory services.

Done


Create view/endpoint for Pybot to hit in order to get authenticated URL to initiate form

Feature request
We want to create a slash command in Slack that takes users to a survey. We need an end point for that command to hit which returns a link to the survey form so each user can only submit once and we can store the responses.
Proposed solution
Create view/endpoint for Pybot to hit in order to get authenticated URL to initiate form.
Additional context
This is going to be related to an OperationCode-Pybot repo issue.

Also interested in this one as well.

setting this up with /remind


Incorrect link to ARM limits for web service calls

[Enter feedback here]
At https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#azure-resource-manager-limits-for-web-service-calls
I don't think the link there is correct. It takes you to https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#resource-group-limits.
but this takes you to resource group limits. We used to have another page with ARM limits. I think it should link to https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/request-limits-and-throttling, but please double check.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 36f49a06-90b1-cbe1-3853-2c38277b79f8
Version Independent ID: 02ff6f6c-3ef6-b48f-060d-b290419e0aba
Content: Azure subscription limits and quotas - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-subscription-service-limits.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@lunar87 - Thanks again for bringing this to our attention. We have updated the doc and it will be live once it's merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Specify node-sass binary location via file path and not HTTP

Hi,
I'm just wondering why the only option to fetch the node sass binaries is through HTTP with the option to give an alternative HTTP url for them.  How come I just can't download the ones for my project and put something in .npmrc to specify where they are on the file system?
I thought sass_binary_path or sass_binary_dir would solve this but it seems those two options just allow you to determine where the binaries will store after their download.
Thanks,
Andre

SASS_BINARY_DIR should do what you're after. Make sure it's an absolute path, and that the binary name is unchanged.

Interesting.  I did try that and I get the following error:

My npmrc looks like this:

Try using an environment variable. I don't believe we supply .npmrc
On Fri., 20 Jul. 2018, 9:44 am Andre<EMAIL_ADDRESS>wrote:

Interesting. I did try that and I get the following error:
[image: node-sass-binary-issue]
https://user-images.githubusercontent.com/2465008/42975678-150d7448-8b83-11e8-8668-5f5ce262b10a.png
My npmrc looks like this:
[image: npmrc]
https://user-images.githubusercontent.com/2465008/42975744-8ba89542-8b83-11e8-9c32-b50d3d4d52e3.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2455#issuecomment-406446521,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWLitchTN6BdZzubFUwfTe-kcNSfXks5uIRmTgaJpZM4VWzs0
.

Thanks @xzyfer, I'll give it a try.  However, it seems documented here as an .npmrc value:
https://github.com/sass/node-sass#binary-configuration-parameters

Can you supply the value you set and an annonimized gist for the log. It's hard do go off screenshots

Hi @xzyfer.  I created an environmental variable as you advised but ran into a different error.   I believe we might have a bug on our hands?  Hopefully, you can reproduce?

It also seems like the value you might want to set is SASS_BINARY_PATH not DIR

I've tried path too but it always wants to download for the first time.

Thanks @nschonni  and @xzyfer, if I set both path and dir (.npmrc), using the same absolute path, it seems to work but feels wrong?  Shouldn't it just be one config value and done?

sass_binary_path = C:\gitprojects\mySecrectPath\nodeSass\win32-x64-57_binding.node
sass_binary_dir = C:\gitprojects\mySecrectPath\nodeSass\win32-x64-57_binding.node

Maybe, I've never really used those variables. For my offline machines I actually just stuff the binary in the NPM cache on any offline machines so the install just picks it up after I do that once for the Node/Node-Sass combo.
I'm taking a look at the docs now though

SASS_BINARY_DIR is exactly that, a directory. The binary name will be appended to the resolved directly.
If you want alter the binary name for some reason use SASS_BINARY_NAME (don't do this).

I have using these options all week so I'm certain they work :)

yeah, it's not working.  Even when I just give the path, I get a maximum call stack exceeded.  @nschonni, I've thought about going the npm-cache route too.  However, it does work if I give both the path and dir with absolute path to file so at least that counts for something but seems pretty wonky.  Should just be one simple option.

I have to say this thing with configuring binaries is extremely annoying when stuck behind a firewall.  I don't understand why they just can't be part of the project unless it's related to versioning and file size?

SASS_BINARY_PATH is the absolute path of the binary file i.e.
SASS_BINARY_PATH=/tmp/test/darwin-x64-57_binding.node npm install node-sass

SASS_BINARY_DIRECTORY is the absolute path to alternate location for the binaries instead to node-sass/vendor
SASS_BINARY_PATH=/tmp/test npm install node-sass

The binary path is a directory that is expected to mirror the layout of vendor i.e.
$ ls test
darwin-x64-57
$ ls test/darwin-x64-57
binding.node

I don't understand why they just can't be part of the project unless it's related to versioning and file size?

Because no one wants to install 100s of mbs of binaries - https://github.com/sass/node-sass/releases/tag/v4.9.2
If you can do bette we welcome your PR.

That great it works for you in OSX @xzyfer.  I doesn't in windows and I would not considered this closed.

Please read my previous comment. It's clear from your screen shot above you've setting SASS_BINARY_DIR incorrectly.
If you're using SASS_BINARY_DIR it's expected that inside that directly there is win32-x64-57/binding.node. The SASS_BINARY_DIR must not include the win32-x64-57/binding.node.
Alternatively user SASS_BINARY_PATH to the full path to the .node file.

I've tried SASS_BINARY_PATH stand alone and it always tries to download.  I think there is something wrong with your code.  What I require only works when both SASS_BINARY_DIR and SASS_BINARY_PATH are included.   I think there's a malfunction in the code related to when it has to choose to download or not and saving that binary to a location for use later.

I've struggeled with this too for too long until I found a solution using the "cache_dir"-config:
In project_root/.npmrc:
sass_binary_cache=../../myNpmCacheDir/node-sass/vendor
in project_root/myNpmCacheDir/node-sass/vendor I put the cached binary(ies) in the following structure:
node-sass/4.10.0/win32-x64-64_binding.node
Complete path:
project_root/myNpmCacheDir/node-sass/vendor/node-sass/4.10.0/win32-x64-64_binding.node which will only then be used by the package.json-install-script
I wasn't very well documented so it's probably better and easier to write example configs instead of trying to explain the structure in docs.

This took me a while to get right as well. It's not stated in the documentation, but as said above SASS_BINARY_DIR expects a specific directory structure.
For example, with node-sass 4.10.0 you'd download the binary:
v4.10.0/linux-x64-57_binding.node
Rename the file to binding.node and place it in a new folder linux-x64-57.
If using /opt/lib the full binary path would be /opt/lib/node-sass/linux-x64-57/binding.node
Used with the environment variable:
SASS_BINARY_PATH=/opt/lib/node-sass

For those having the same issue and looking for the official documentation of these variables, see https://github.com/sass/node-sass/tree/master#binary-configuration-parameters


Should support spread operator in propTypes objects

Hi,
I believe this plugin should support using spread operators in the propTypes object.
There is a test fixture for this case: https://github.com/layershifter/babel-plugin-transform-react-handled-props/tree/master/test/fixtures/spread
But the expected result seem wrong to me. I believe handledProps should include the active prop meaning:
Example.handledProps = ["children", "className", "active"]`
Thank you,
Patrick

@patricklafrance hey 👋
It's also what I expect 😺 But, it's to hard to do it without runtime execution especially if propTypes will come from other files.

Hi @layershifter
Maybe a first step would be to support the spread operator for local variables?
Something like this seems to do it: https://github.com/reactjs/react-docgen/pull/415/files#diff-b35f78065f9458034d34daff3f3a3a11R113
Patrick

I ended up rewriting my code to hooks and I don't need the plugin anymore. Feel free to close this issue if you feel it doesn't worth investing time in this.


Filter tags?

Hey Javier,
is there a way to sort out hashtags? Like, I would like to see "#green" but I would like to exclude those pics, that have also been tagged with "#ecological"?

Duplicate of #22


⚠ ClamAV has degraded performance

In 8aed98f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 601 ms

Resolved: ClamAV performance has improved in 0c6fe87.


Adds support for prettifying rules file

Signed-off-by: Harkishen-Singh<EMAIL_ADDRESS>This comment adds support for prettifying rules file
accepted from promtool prettify rules <files>.
It also adds support for prettifying a single PromQL expression via
promtool prettify query <promql-expr>.

Hello @Harkishen-Singh, we have looked at this during the bug scrub. I will review this, in the meantime, are you willing to rebase the pull request? Thanks!

Looking at this during the bug scrub again.
@Harkishen-Singh doesn't seem to be able to come back to this. @roidelapluie how should we proceed here? Since you wanted to review this anyway, could you just take it over, do the rebase and any changes you feel necessary, and then we review it among ourselves?

Apologies for delay. I'll prioritize this PR and aim to provide an update within a week. Thank you.

We came back around to this at the bug-scrub; since there was no update in 9 months we will close.
Feel free to re-open if you do come back to it.


MotionCollector & Camera

Hi @degtiarev ,
First of all, thanks for sharing your work. I tried your app and it works perfectly.
Do you think it is possible to integrate the camera in the sensor acquisition loop?
Thanks in advance,
Pm

Hi @pmd2245 ,
I'm glad to hear, my app helped somebody.
There should be no problem. I suppose it would be better to store photos as files in /Documents inside the app and photo_id in Core Data. To export data, you need to archive all pictures into one archive-file (to not to export by hands a lot of generated files).

@degtiarev, many thanks for your reactivity and your advices .
To be honest, I am not very familiar with oriented object programming. I would really appreciate if you could provide me some references about the camera stuff.

https://developer.apple.com/documentation/avfoundation/cameras_and_media_capture/
https://hackernoon.com/swift-access-ios-camera-and-photo-library-dc1dbe0cdd76


react-hamburger hides the heading in the generate profile route in the pc version.

is this issue happening only with me or someone else is also facing the issue.

is this issue happening only with me or someone else is also facing the issue.
I think You should provide proper padding top in the page.

I believe the issue is that the Nav element has been put in fixed mode. It shouldn't be fixed @nayakswadhin

I believe the issue is that the Nav element has been put in fixed mode. It shouldn't be fixed @nayakswadhin
@khairalanam Yup its true but if we use relative or some other positional property then the content is of the page is also going down/up depending on the navbar. So if it's ok then we can change otherwise one more solution is we can give add padding top on every page or add in global CSS.

https://github.com/khairalanam/GPRG/assets/114871538/5f14ffd6-e142-4639-a4c1-fba146e02d17

The navbar doesn't have to be sticky or fixed since there's not much content in any of the pages except the form page but I doubt many of them would scroll up and then go to some nav link in the midst of filling a form.
If the fixed property is necessary, try putting it in only in mobile and/or tablet view but when it comes to lg breakpoint, you can change from fixed to normal or relative mode.

@khairalanam If we put navbar fixed only for mobile/tablet view then that view will have the same issue. So i guess our only solution here will be to convert the fixed property to normal/relative for both mobile or laptop view, right??

That's also fine. Either way, navbar in its sticky or fixed mode is not at all necessary.

@khairalanam I have raised a pr on this issue. Kindly review it.


Update entity.py remove_classification method

There was a typo in the remove_classification method where it was written formart instead of format

@pareshD-1991 @mneethiraj @rkundam @chaitali Could you please review this PR? It is just a little typo. Thank you in advance

Thanks @itsjoaoduque  for the fix.

@mneethiraj thank you for the approval. Could you prepare a new version including this fix? We need to apply it to our services asap. Thank you again in advance !

@asik03  - updated Python client library is now published - https://pypi.org/project/apache-atlas/0.0.15/. Thank you for the fix.


unminified js version

Hi
is it possible to get the unminified js version 4.6.4 of the script?
js & css
Thank you

Test that Grunt's CLI is installed by running grunt --version. If the command isn't found, run npm install -g grunt-cli. For more information about installing Grunt, see the getting started guide.

Fork and clone the repo.
Run npm install to install all dependencies (including Grunt).
Run grunt to grunt this project.

Get files from out/futurama.dev.*

Good news, everyone! I have discovered what appears to be a typo in the previous comment!


Frame timestamp discrepancy

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>7

Operating System & Version
Win10

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC

SDK Version
{ legacy / 2.. }

Language
python

Segment
other

Issue Description
I am trying to extract latest frame using wait_for_frames/poll_for_frames but the frame timestamp that I am getting using get_frame_timestamp has a lower value when compared to the timestamp at the time of calling wait_for_frames/poll_for_frames.
I am using the following code for the same.
pipeline=rs.pipeline()
config=rs.config()
config.enable_stream(rs.stream.depth, 640, 480, rs.format.z16, 6)
profile=pipeline.start(config)
d_sensor=profile.get_device().first_depth_sensor()
d_sensor.set_option(rs.option.visual_preset, 3)
depth_scale = d_sensor.get_depth_scale()
d_sensor.set_option(rs.option.global_time_enabled,1)
c=0
try:
    while c<5:
        t1=time.time()
        print(t1)
        frames = pipeline.wait_for_frames()
        depth_frame = frames.get_depth_frame()
        if not depth_frame:
            continue
        d_time = depth_frame.get_timestamp()/1000
        print("Depth frame timestamp:"+str(d_time))
        depth_image = np.asanyarray(depth_frame.get_data())/depth_scale
        c+=1
finally:
    pipeline.stop()

Output:
1609860437.379545
Depth frame timestamp:1609860437.3582704
1609860437.5453537
Depth frame timestamp:1609860437.5248868
1609860437.7119782
Depth frame timestamp:1609860437.6915023
1609860437.8788202
Depth frame timestamp:1609860437.858115
1609860438.045043
Depth frame timestamp:1609860438.0247257

Hi @jasdeep06   Do you get more satisfactory timestamp results if you set rs.option.global_time_enabled to '0' (false) instead of '1' (enabled) please?
I ask this because I recall a recent case where drift between timestamps was significantly reduced when global time was made false.
https://github.com/IntelRealSense/librealsense/issues/8003

Hi @jasdeep06   Do you get more satisfactory timestamp results if you set rs.option.global_time_enabled to '0' (false) instead of '1' (enabled) please?
I ask this because I recall a recent case where drift between timestamps was significantly reduced when global time was made false.
https://github.com/IntelRealSense/librealsense/issues/8003

@jasdeep06 hello, this is a possible and even a plausible scenario as the frame's timestamp designates either (a) the time point the frame was generated in Hardware or (b) the time it was acquired by the SDK.
In first case it should occur 100% of the time, while in the latter - it depends on the timestamp type and the propagation latency, still for most cases the timestamp should be lower than the time wait_for_frames call was made.
Please see the documentation on timestamp types

@jasdeep06 hello, this is a possible and even a plausible scenario as the frame's timestamp designates either (a) the time point the frame was generated in Hardware or (b) the time it was acquired by the SDK.
In first case it should occur 100% of the time, while in the latter - it depends on the timestamp type and the propagation latency, still for most cases the timestamp should be lower than the time wait_for_frames call was made.
Please see the documentation on timestamp types

Hi @jasdeep06   Do you require further assistance with this case, please?  Thanks!

Hi @jasdeep06   Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.

Case closed due to no further comments received.


Updating FAQ page to reflect changes in FAQ document

Trello card
https://trello.com/c/J52B5Z55/2807-comparing-qa-on-call-to-arms-page
Context
Changes proposed in this pull request
Guidance to review

Looks good and happy for this to be merged
However, it has failed build - linting errors (white spaces I think?) - @peteryates are you able to help?


[Channel Tabs] Issue: Crashes when adding a favorite

Describe the bug
Adding anything as a favorite crashes discord
To Reproduce
Steps to reproduce the behavior:

Add anything to a favorite
Crash

Expected behavior

Favorite gets added
No crash

Screenshots

Information (please complete the following information):

OS: Windows 11
Plugin Version: 2.6.7
Discord version: Stable
Compact Mode enabled? Crashes with or without

Additional context
It started this morning before the Channel Tabs update. I hoped the update would solve it but even after clearing my config it persists.

It also happens if I get a notification in any tab other than the active one. Turning off all badges prevents that crash at least.


Add detail on aws s3 and AWS_DEFAULT_REGION to readme

What
Improve readme to add things I forgot and that our scripts sometimes assume one knows.
How to review
Check the ./README.md file still makes sense
Who can review
Anyone but @benhyland

Comments addressed, thanks for improvements


del and ins tag are not recognized by Swing components

Hello,
When using diff_prettyHtml it appears that the generated html is not recognized by Swing components.
I fixed it by replacing del and ins tag by span and adding the style attibutes text-decoration:underline when adding and text-decoration:line-through when deleting.
Here is the complete code:
case INSERT:
        html.append("")
            .append(text)
            .append("");
        break;
case DELETE:
        html.append("")
            .append(text)
            .append("");
        break;

I hope this will help people using your awesome project.

Yes, that's exactly what one is supposed to do.  As the documentation says, "This function is mainly intended as an example from which to write ones own display functions."


Discord Invite Link is Invalid

The current Discord invite link in README.md is invalid, may have been deleted or expired.

Good to go now!


Enable doctest within tests/SCsub

DOCTEST_CONFIG_IMPLEMENT is not added to the entire build anymore. The engine is still rebuilt on switching the tests=yes/no option , but at least it's more self-contained now.

Akien: Yeah if tests=yes changes the base env, everything builds, that's normal.

Haha you beat me to it but I have a better version of this PR incoming ;P

Superseded by #40726.


Angular 4 ?

Angular 4 got released, can we expect to see that added into the yeoman project generator?

https://github.com/aspnet/JavaScriptServices/issues/800


Speed up compositing by 5x

According to the profile for the flow manual test, we're spending the vast
majority of our time recording timeline traces. This patch removes the timeline
traces, which greatly improves performance.
Also, optimize TransformLayer to avoid one matrix memcpy. I filed
https://github.com/google/vector_math.dart/issues/166 about an API that would
make this even faster.

@Hixie @eseidelGoogle

I filed https://github.com/dart-lang/sdk/issues/26465 about Timeline.* never taking any time in --release builds.  FYI @johnmccutchan

Last week I landed a change so that all Timeline.* calls are no-ops in product mode. I have a CL out for review which will dramatically speedup Timeline.* calls during development with the timeline disabled.


Granular max in flight

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

An explanation of the use cases your change solves

Links to any other associated PRs

[ ] I have reviewed the contributing guide

[ ] I have viewed, signed, and submitted the Contributor License Agreement

[ ] I have made this pull request to the main branch

[ ] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

squashed and cherry-picked onto https://github.com/cloudfoundry/cloud_controller_ng/pull/4124


Link to the blag

elementaryos.tumblr.com
Down with the Journal. Long live the Blog.

When we roll this out, do we want it to be blog.elementaryos.org or something on a subdomain? I feel like that looks a bit more professional and lets people know they're for sure on an official elementary site.
It's easy to set up in Tumblr. :)

Yeah, I think blog.elementaryos.org would make sense and I'd much rather share that link than a tumblr link :p


fix: cwv add error prevention logic

Overview

Adding in logic checks for object passed to the CWV callbacks to prevent accessing properties of undefined.
Related Issue(s)

https://issues.newrelic.com/browse/NEWRELIC-8039
Testing

Integration tests should pass.

Codecov Report

Merging #486 (0624e89) into main (4f562a7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   12.49%   12.48%   -0.01%
==========================================
  Files         121      121
  Lines        3969     3972       +3
  Branches      989      990       +1
==========================================
  Hits          496      496
- Misses       2729     2731       +2
- Partials      744      745       +1

Impacted Files
Coverage Δ

src/features/page_view_timing/aggregate/index.js
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Bug: Files (Source) list allows resizing rows

The game list in the Files (Source) tab allows resizing rows, which makes it somewhat more difficult to click on a game

I'll turn that off for the next incremental. Probably within the hour.


Update bank-tag-generation (plugin takeover)

Takeover of plugin with inactive author.
Main repo for the plugin has had open comments and PRs for well over 6 months.
We have attempted to reach out via Discord and Github with no response.
We also put the time into fix the plugin and have it in a working state.
Open PRs: https://github.com/MitchBarnett/wiki-bank-tag-integration/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen
Open Issues: https://github.com/MitchBarnett/wiki-bank-tag-integration/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen
Long Thead of multiple users trying to reach out for months: https://github.com/MitchBarnett/wiki-bank-tag-integration/issues/19

Can you follow this procedure? https://github.com/runelite/runelite/wiki/Plugin-takeover-policy

Can you follow this procedure? https://github.com/runelite/runelite/wiki/Plugin-takeover-policy

That's what I followed.
Am I missing something?

Well, I was mostly thinking of Try to contact the author via opening an issue on the repository asking to be granted collaborator access.
The plugin has been broken for quite a while though, so I understand why you did this. It might be nice if you still opened an issue with that request and note within it that the plugin will otherwise be transferred.
It was also somewhat remarkable that you are submitting a plugin of another repo that's owned by someone that's not you, assuming I saw that correctly. Are you a collaborator on that repo? If so, the owner of that repo probably needs to confirm it here. Additionally, both you and him should be added to the pluginhub file as authors then.
@MitchBarnett Could you add these people as collaborators to your repo? If you fail to respond, we will transfer the plugin.
@gbarnh Is OP a collaborator on your repo? Is it ok that they can submit plugin updates?

I will review the comments tomorrow to do what I can to be able to get the project moving again.

@gbarnh Is OP a collaborator on your repo? Is it ok that they can submit plugin updates?

Yes the OP is a collaborator on my repo. It is ok for them to submit maintenance updates for this plugin.

I will review the comments tomorrow to do what I can to be able to get the project moving again.

It looks like the original author is responding again though, so we can wait to see if they want to continue maintaining it or not.
Thanks everyone!

I will review the comments tomorrow to do what I can to be able to get the project moving again.

Please add one of us as a contributor to this project at the very least that way you do not have to continue to support it if you do not want to.

I will review the comments tomorrow to do what I can to be able to get the project moving again.

Not to be rude, but how come you noticed this takeover request but not the other forms of communication we tried for a long time?

It was also somewhat remarkable that you are submitting a plugin of another repo that's owned by someone that's not you, assuming I saw that correctly. Are you a collaborator on that repo? If so, the owner of that repo probably needs to confirm it here. Additionally, both you and him should be added to the pluginhub file as authors then.

It's just the repo we chose to work on. I just took up the task of opening this PR.
Yes, I'm a collab on that repo, not sure why thats so remarkable.

@YvesW As it's been 24 hours since his comment, and no progress has been made. (Exact same thing happened here)
When can we start the takeover timer (assuming nothing is done)?

I am trying to review what is going on I cant seem to run the plugin through intellij though I am getting the error unable to verify jar entry: ac.class I am not sure if any of the proposed changes are related to this or if this is a configuration issue my end.

I am trying to review what is going on I cant seem to run the plugin through intellij though I am getting the error unable to verify jar entry: ac.class I am not sure if any of the proposed changes are related to this or if this is a configuration issue my end.

We have already fixed the plugin, please add one of us as a collab.

It is the changes I am testing, thanks

We have already fixed the plugin, please add one of us as a collab. (Running and working in game on latest RL build)

This PR does not build so that seems very unlikely

We have already fixed the plugin, please add one of us as a collab. (Running and working in game on latest RL build)

This PR does not build so that seems very unlikely

The build error was happening before and there's an open PR for it. We have it working in game again.

It is the changes I am testing, thanks

are you using the correct JDK? i have it fully working in my test build
https://github.com/user-attachments/assets/5e134eaf-431d-4fd4-9451-622690a8f3fa

Since this was a takeover request initially we did not update the commit per the takeover instructions. that is why it is not building here.

Yeah I think I have submitted a PR with fixes here #6791

Closing in favor of #6791
@MitchBarnett if you are short on time to maintain the plugin, consider granting collaborator status to another contributor to help out

@kulcris  Yeah I think it was a JDK issue. I have submitted a PR with fixes here #6791

Please grant kulcris collab so we don't have to force your hand again.

@kulcris  Yeah I think it was a JDK issue. I have submitted a PR with fixes here #6791

Please grant kulcris collab so we don't have to force your hand again.

Please don't threaten authors of plugins.

@kulcris  Yeah I think it was a JDK issue. I have submitted a PR with fixes here #6791

Please grant kulcris collab so we don't have to force your hand again.

Please don't threaten authors of plugins.

That's not a threat? It's just what we had to do to finally get a response. After trying to contact him for months.


xerces-c: 3.1.1 -> 3.1.3

Xerces has had many bugfixes between 3.1.1 and 3.1.3, including a recent buffer overflow. This update is binary compatible with 3.1.1, and should be backported to 15.09.
http://seclists.org/oss-sec/2016/q1/4392
Things done:

[X] Tested via nix.useChroot.
[X] Built on platform(s): linux x86 64.
[ ] Tested compilation of all pkgs that depend on this change.
[ ] Tested execution of binary products.
[X] Fits CONTRIBUTING.md.

I'm currently running nox-review pr 13454 on my own machine, does that satisfy the Tested compilation of all pkgs that depend on this change.? Not sure how to effectively satisfy `Tested execution of binary products.'.

@grahamc this is the right way (nox-review)! You can do it by yourself or just wait after travis will finish.

I decided to run it because of how many packages would be building, and worrying it would be over the time limit for Travis. It failed once, but on a re-run seems to have been transient.

cc @vcunat this can be merged right away, right? Bugfix release only

I ran nox-review pr 13454 and it passed just fine. It did take nearly 6 hours though, so I'd be impressed if Travis will pass.

This PR took about 6+hours to build on a really capable machine, and I think it should be merged fairly soon and backported to 15.09. Who should review that to make it happen?

Also builds for me and on our hydra. Merging & backporting.

Thank you, @fpletz!


0.19.x cannot created projects with version 2 as well.

The goal here is just tracking the need to backport https://github.com/operator-framework/operator-sdk/pull/3697 for 0.19.x

Closed by #3716


when will be added TensorFlow Lite 1 notebook??

Hello :)
Thank you for sharing nice Colab notebook for Tensorflow v2 !
https://github.com/EdjeElectronics/TensorFlow-Lite-Object-Detection-on-Android-and-Raspberry-Pi/blob/master/Train_TFLite2_Object_Detction_Model.ipynb
I'm having problem in less accuracy with quantized tflite.
and notebook said quantized with tensor flow v1 is better then v2.
but as far as I know, Colab is not supporting tensor flow v1 anymore....so....how can I use ssd-mobilenet-v1-quantized model  ?
Thank you

Thanks for trying out the notebook, and good question! I'll work on getting the TFLite v1 notebook added to the repository some time next week. It's been a couple months since I last used it, so there's a chance it won't work anymore. I'll test it out and post an update here when it's ready!

Hi @kotran88 , I just uploaded the TensorFlow 1 notebook. You can train the ssd-mobilenet-v2-quantized model, and it should have better performance than the equivalent version from TensorFlow 2. I still haven't fully fleshed out the comments and text, but all the code is there.
Try it out and let me know if it works for you!
https://colab.research.google.com/github/EdjeElectronics/TensorFlow-Lite-Object-Detection-on-Android-and-Raspberry-Pi/blob/master/Train_TFLite1_Object_Detection_Model.ipynb

Google colab has python starting from 3.8. So tf==1.15 is not supported. I alternatively installed python 3.7 in the colab and the tensorflow is installed successfully, but the pycocotools cannot be installed. Can you please help?

Google colab has python starting from 3.8. So tf==1.15 is not supported. I alternatively installed python 3.7 in the colab and the tensorflow is installed successfully, but the pycocotools cannot be installed. Can you please help?

using this command !pip install pycocotools?


[Bug] V1.9.4 escape "\n" in message type text

What did I do
I have send a message type text with one character \n ex: "send new message with \n in text"
What happened
Auto escape \n in text, it send :  "send new message with n in text" --> replace "" to ""
Expected
What is the expected result.
Environment

Ubuntu 22.04
MQTTX version, e.g. v1.9.4

More detail
not bug in v1.9.3

Hello @ThuanDoHung , I appreciate your feedback. I have addressed the bug you reported in the PR: fix text processing error, and it will be included in the upcoming version (1.9.5) of MQTTX. Thank you for bringing this to my attention.

Thanks for your feedback!
Welcome to try the new MQTTX release at https://github.com/emqx/MQTTX/releases/tag/v1.9.5. If problems persist, please let us know, and we will quickly address them.


MINOR: Upgrade to gradle 8.5

The highlight is full support for Java 21, full release notes below:

https://docs.gradle.org/8.4/release-notes.html
https://docs.gradle.org/8.5/release-notes.html

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@satishd Do you have cycles to review this?

There are some unrelated intermittent test failures in Jenkins jobs, merging it to trunk.


Disable modal animationIn and animationOut

Hi,
I have a very small and simple question: How can I remove animations from my modal?
I wish I could have a modal that opens and closes without animation, is that possible?
Thanks

@vikjovanov
Set animationInTiming and animationOutTiming to 1.
example
<Modal                 animationInTiming={1}               animationOutTiming={1} </Modal>

@vikjovanov
Set animationInTiming and animationOutTiming to 1.
example
<Modal animationInTiming={1} animationOutTiming={1} > </Modal>

Thank you but it doesn't work for me :(

Hi!
I'm closing this issue because it's a question and not a bug report. Please don't take it personally, I'm just trying to make it easier to maintain this project by separating questions from bug reports 🙏.
If you're still looking for feedback/answers, could you please ask your question in a new discussion?
Thank you!


Hope to provide gonb Docker images!

As the Title,Hope to provide gonb Docker images!

That's a good point @sirliu . I'm working this weekend on a new version (0.5) that will have some improved error reporting/handling.
Just a heads up that there is going to be a new release soon.

I'm so glad to hear about that~!

That's a good point @sirliu . I'm working this weekend on a new version (0.5) that will have some improved error reporting/handling.
Just a heads up that there is going to be a new release soon.

Thank you for your response. I'm so glad to hear this , I hope it will be released soon, and I hope gonb will become more and more popular with richer and richer functions. Thank you again for your hard work.

v0.5.0 released. Check it out!
Btw, do you intend to create a Dockerfile as well ?

With @AnotherCodeArtist help  in #16 , GoNB now has a official docker image -- and a Dockerfile.


Interface to Peter Corke's Robotics toolbox

[ ]  OclVariable/OclTensor have to have behavior like Matlab sym to pass through rne function

[ ] testing

[ ] documentation

I did some basic tests at https://github.com/jkoendev/openocl_models (i guess the examples are outdated by now)

https://groups.google.com/forum/#!topic/robotics-tool-box/tnkYS47qgC8


fix webpack build

the built dist/main file generates this error
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

might have something to do with https://webpack.js.org/configuration/output/#module-definition-systems


Resolve Grant Feed Anomalies

Several types of anomalies have been observed in the Grant feed process.

Some grants seem to lack user links.
Some Aggie Enterprise grant titles indicate the record has been deprecated, replaced, or has other issues.
At least one (and presumably more) grant appears to be replicated in Dimensions and so a UCD Grant(pre 2024) grant type.

Was this grant https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4542319&cid=2 previously uploaded to the UCPMS as a "ucd grant (pre-2024)" item type?
That was imported, but as a “UCD Grant” type, which is the type we use for current grant imports. The other grant apparently came from Dimensions, but shows “UCD grant (pre-2024)” as its type which is what we use for our set of “archived” grants.
Roger Kunkel
UC Davis Library
Online Strategy
Ticket ID: [#138662]
Hello Roger Kunkel,
Thanks for your message. I'm looping in Symplectic Support as they may need to assist with the investigation.
My understanding is that this grant https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4522184&cid=2 is from Dimensions (Grants). My expectation is that Dimensions Grants would always import as the default item type "grant", and that they may group with existing "ucd grant (pre-2024)" item types if there is relevant matching metadata.
Was this grant https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4542319&cid=2 previously uploaded to the UCPMS as a "ucd grant (pre-2024)" item type?
Warm regards,
Alainna Wrigley
On Wed, May 22 at 3:51 PM , Roger Kunkel<EMAIL_ADDRESS>wrote:
Hi,
We have a mysterious problem with Grants appearing in our set of grants of the custom type UCD Grant (PRE-2024)
This is the Dimensions grant that masquerades as our pre-2024 grant:
https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4522184&cid=2.
And this is our actual record:
https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4542319&cid=2
We aren’t expecting to see grants sourced from Dimensions and especially not with our custom type. Can you investigate this for us?
Thanks!
Roger Kunkel
UC Davis Library
Online Strategy

A third version of this grant?
https://oapolicy.universityofcalifornia.edu/viewobject.html?cid=2&id=4518593

A third version of the grant?
https://oapolicy.universityofcalifornia.edu/viewobject.html?cid=2&id=4518593

A third version of this grant? https://oapolicy.universityofcalifornia.edu/viewobject.html?cid=2&id=4518593

That one is from 2016 though.

@rakunkel-ucd  reading Lucian's notes, I'm still not exactly sure what the dimensions sync tool does, whether it simply joins grants that were already in the grant Grant type, or if it fetches more from somewhere else.
However, with this query:
 with grc as (
    select gr.[Grant ID],count(*) as record_cnt
    from [Grant Record] gr
    group by gr.[Grant ID]
    )
select g.[Records Imported From],gt.[Identifier name],grc.record_cnt, COUNT(*) as cnt
from  [Grant] g
join [Grant Type] gt on gt.[ID] = g.[Type ID]
JOIN grc on grc.[Grant ID]=g.ID
WHERE gt.[Identifier name] like 'c-ucd%'
group by g.[Records Imported From],gt.[Identifier name],grc.record_cnt
order by [Identifier name],record_cnt

We can see there are about about 116 grant records from dimensions in c-ucdavis-pre-ae
So my main question is whether we can simply remove these our our own delete tool, using the Dimensions Data Source Proprietary ID as in:
with grc as (
    select gr.[Grant ID],count(*) as record_cnt
    from [Grant Record] gr
    group by gr.[Grant ID]
    )
select gr.[Grant ID],gr.Id,gr.[Data Source Proprietary ID],gr.[Data Source]
from  [Grant] g
join [Grant Type] gt on gt.[ID] = g.[Type ID]
JOIN grc on grc.[Grant ID]=g.ID
JOIN [Grant Record] gr on g.ID=gr.[Grant ID]
WHERE gt.[Identifier name] in ('c-ucdavis-pre-ae','c-ucd-enterprise')
and record_cnt=1 and gr.[Data Source] != 'Institutional Grants System'

@rakunkel-ucd However, I'll note these don't look like they synced with the new records in c-ucd-enterprise
with grc as (
    select gr.[Grant ID],count(*) as record_cnt
    from [Grant Record] gr
    group by gr.[Grant ID]
    ),
orphans as (
select gr.[Data Source Proprietary ID]
from  [Grant] g
join [Grant Type] gt on gt.[ID] = g.[Type ID]
JOIN grc on grc.[Grant ID]=g.ID
JOIN [Grant Record] gr on g.ID=gr.[Grant ID]
WHERE gt.[Identifier name] in ('c-ucdavis-pre-ae','c-ucd-enterprise')
and record_cnt=1 and gr.[Data Source] != 'Institutional Grants System'
)
select orphans.[Data Source Proprietary ID],count(*) as cnt
from orphans join [Grant Record] gr on orphans.[Data Source Proprietary ID]=gr.[Data Source Proprietary ID]
group by orphans.[Data Source Proprietary ID]
having count(*) > 1
order by cnt desc;

Also we can verify no grants have wander out of our two identifiers
with ucd_records as (
    select distinct gr.[Grant ID]
    from [Grant Record] gr
    where gr.[Data Source Proprietary ID] like 'ark:/87287/%'
    ),
grc as (
    select gr.[Grant ID],count(*) as record_cnt
    from [Grant Record] gr
    group by gr.[Grant ID]
    )
select g.[Records Imported From],gt.[Identifier name],grc.record_cnt, COUNT(*) as cnt
from ucd_records join [Grant] g on ucd_records.[Grant ID] = g.ID
join [Grant Type] gt on gt.[ID] = g.[Type ID]
JOIN grc on grc.[Grant ID]=g.ID
group by g.[Records Imported From],gt.[Identifier name],grc.record_cnt
order by [Identifier name],record_cnt

Records Imported From
Identifier name
record_cnt
cnt

Institutional Grants System
c-ucdavis-pre-ae
1
33544

Dimensions Grants, Institutional Grants System
c-ucdavis-pre-ae
2
1480

Dimensions Grants, Dimensions Grants, Institutional Grants System
c-ucdavis-pre-ae
3
4

Institutional Grants System
c-ucd-enterprise
1
7369

Dimensions Grants, Institutional Grants System
c-ucd-enterprise
2
382

And another question would be how do we stop them from coming back?

@rakunkel-ucd presumably, these are all from grants that have been moved, so I'm okay with us periodically having to check, as longs as we can easily get the list as above, and we can delete them.

June 18 email:
Subject: Re: Re: Dimensions Grants replicating UCD Grants - Ticket ID: [#138662] [480444]
Hello Roger,
About this "I believe we have about 700 records in this state, so I assume we’ll want to design a bulk update to correct that" from your last message, how do you intent to do it?
You can utilize the API to bulk update the type of the problematic objects.
Alternatively, you can give us with a list of these grants and we will update them. This is chargeable work according to our SLA and we will need approximately 1 support hour.

Kind regards,
Lucian B.
Ticket: https://support.symplectic.co.uk/support/tickets/480444
On Fri, 14 Jun at 7:51 AM , Lucian Bitiusca<EMAIL_ADDRESS>wrote:
Hi Roger,
When you are saying to opt-out the Dimensions synchronization are you referring to a list of users to be excluded from Dimensions grants search or do you intent to exclude all users?
Kind regards,
Ticket: https://support.symplectic.co.uk/support/tickets/480444
On Thu, 13 Jun at 5:12 PM , Roger Kunkel<EMAIL_ADDRESS>wrote:
Thank you for this analysis, Lucian. Our unusual workflow with grants moving from one source to another combined with the Dimensions synchronizer results in some unexpected problems. How can we learn more about the Dimensions synchronization process and what options are available to affect it? Can we opt-out of it? I believe we have about 700 records in this state, so I assume we’ll want to design a bulk update to correct that.
Roger Kunkel
UC Davis Library
Online Strategy
From: Lucian Bitiusca<EMAIL_ADDRESS>Date: Thursday, June 13, 2024 at 12:56 AM
To<EMAIL_ADDRESS><EMAIL_ADDRESS>Cc: Roger Kunkel<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: Re: Dimensions Grants replicating UCD Grants - Ticket ID: [#138662] [480444]
Hi Alainna, Roger,
Below you can see the steps which explains why this object with a Dimensions record has the "UCD Grant (pre-2024)" type.

On 22-Mar at 14:48:40 (FTP server is 3 hours ahead) this record was imported: "ark:/87287/d7gt0q/grant/K388D41-131124" using this data found in the backup data file:
ark:/87287/d7gt0q/grant/K388D41-131124,grant,c-ucdavis-pre-ae,"SC-Links - Linking the Sickle Cell Community, Providers and Systems to Improve Sickle Cell Disease Care","WUN, THEODORE","NATIONAL HEART, LUNG AND BLOOD INSTITUTE",U01HL134007,2021-08-15,2023-06-30,108997,USD,Research,http://rems.ucop.edu/sponsor/3435,,TRUE

You can see the log file on the FTP server in the "\PROD\Logs\UCDavis_Grants_Feed_logs\2024-03-22_(13_04)" folder:
2024-03-22 17:48:40:    Import(39bbee85-621d-4a66-971e-8dfcc503e760) :: PUT Request made to [https://oapolicy.universityofcalifornia.edu:8002/elements-secure-api/v5.5/grant/records/source-3/ark%3A%2F87287%2Fd7gt0q%2Fgrant%2FK388D41-131124?update-reporting-dates=true&update-object-type=true] to import [grant(source-source-3,pid-ark:/87287/d7gt0q/grant/K388D41-131124)] :: content size = 1018
2024-03-22 17:48:40:    Import(39bbee85-621d-4a66-971e-8dfcc503e760) :: 201(Created) response received
This created the object in Elements "https://oapolicy.universityofcalifornia.edu/viewobject.html?id=4522184&cid=2" and the object type was set at this moment: "UCD Grant (pre-2024)" based on the input data from the file.
Image removed by sender.

On 23-Mar the Dimensions grant search returned one result and it was injected in our existing object. This actions won't change the object type. The object type is set when the object is created and it can be changed only manually after or using the API.
2024-03-23 22:05:53 [Dimensions Grants synchroniser]: Processing priority 15 object search for Grant 4522184...
2024-03-23 22:05:55 [Dimensions Grants synchroniser]: Executing query against Dimensions Grants:
extract_grants (funder_name="NATIONAL HEART, LUNG AND BLOOD INSTITUTE", grant_number="U01HL134007")
2024-03-23 22:05:55 [Dimensions Grants synchroniser]: Search returned 1 result.
2024-03-23 22:05:55 [Dimensions Grants synchroniser]: Result Dimensions Grants grant.5503426 record awaiting retrieval and injection into Grant 4522184.
2024-03-23 22:05:58 [Dimensions Grants synchroniser]: Processing priority 20 fetch for a batch of 1 records...
2024-03-23 22:06:00 [Dimensions Grants synchroniser]: Executing query against Dimensions Grants:
search grants
where id in ["grant.5503426"]
return grants[abstract+category_for_2020+category_hrcs_hc+category_hrcs_rac+category_rcdc+category_sdg+date_inserted+end_date+funding_aud+funding_cad+funding_chf+funding_currency+funding_eur+funding_gbp+funding_jpy+funding_nzd+funding_org_name+funding_usd+grant_number+id+investigators+linkout+research_orgs+start_date+title]
sort by id
limit 25 skip 0
2024-03-23 22:06:07 [Dimensions Grants synchroniser]: Grant record 14603321 (Dimensions Grants grant.5503426): Injected into Grant 4522184.

On 04-Apr the imported record was deleted and the object remained with a single record from Dimensons.
4/4/2024 2:06:33 PM,DELETE,https://oapolicy.universityofcalifornia.edu:8002/elements-secure-api/v5.5/grant/records/source-3/ark:%2F87287%2Fd7gt0q%2Fgrant%2FK388D41-131124,204,NoContent,147

There are two scenarios that can lead to this result:
the one listed above where the imported record is created first, and then the Dimensions record is merged, followed by the deletion of the imported record
the Dimensions record comes first creating an object of type "grant", then a record is imported and merged into existing object changing the type to "UCD Grant (pre-2024)", followed by the deletion of the imported record
You can identify similar cases where there is an object with a single Dimensions record where the type is not "grant" using this SQL query:
select g.[Records Imported From], g.[ID] [Grant ID], g.[Date Created In Elements] [Grant Created In Elements], gr.[Created When] [Dimensions record Created In Elements], g.*
from [Grant] g join [Grant Type] gt on gt.[ID] = g.[Type ID]
join [Grant Record] gr on g.[ID] = gr.[Grant ID]
where gt.[Identifier name] != 'grant'
and g.[Records Imported From] = 'Dimensions Grants'
I hope this will help!
Please, let us know if you need further assistance or we can close this ticket.
Thank you!
Kind regards,
Lucian B.
Ticket: https://support.symplectic.co.uk/support/tickets/480444
On Thu, 13 Jun at 12:44 AM , Roger Kunkel<EMAIL_ADDRESS>wrote:
I see this grant which we imported from the UCD KFS Financial system. Grants from KFS (the old accounting system) we import with UCD Grant(pre 2024) type. However, these older grants sometimes find their way to the new UCD accounting system and appear in a weekly feed from there. When that happens we delete the old version of type UCD Grant(pre 2024) and import the the new version as a UCD Grant type grant.
So, I believe this grant first came to us via KFS as:
131124,"tedwun","WUN, THEODORE","SC-Links - Linking the Sickle Cell Community, Providers and Systems to Improve Sickle Cell Disease Care",108997,108997,0,"3435","","668982","RESEARCH","U01HL134007","2021-08-15","2023-06-30","S","049227","049014","K388D41","MED:Int Med HEM/ONC","MED:Internal Medicine"
And then from Aggie Enterprise as:
ark:/87287/d7c08j/grant/K388D41,grant,c-ucd-enterprise,SC Links Linking the Sickle Cell Community Providers and Systems to Improve Sickle Cell Disease Care K388D41,Theodore Wun,REGENTS OF THE UNIVERSITY OF CALIFORNIA SAN FRANCISCO,13289sc,2021-08-15,2023-06-30,108997,USD,Research,http://rems.ucop.edu/sponsor/6762,,TRUE
But the funder reference has changed.
Roger Kunkel
UC Davis Library
Online Strategy
480444:261055
480444:261055

Hello Roger,
Checking if the Dimensions records were deleted based on your last "Prod_UCD_grants_to_delete.csv" file, we saw that the records were not deleted because the tool was configured to delete by default grants with source "Institutional Grants System" (source-3) and the grants to delete from the input file are with source Dimensions.
We configured the tool to use from the input file two columns:
a "data-source" column for the source of the grant record
and the "id" column as before
Starting from now the input file needs to have two columns:
a "data-source" column
and an "id" column
When you will need to delete grant records with "Institutional Grants System" source , the "data-source" column can be empty. The input file will look like this:
data-source,id
,ark:/87287/d7gt0q/grant/K320961-1248
When you will need to delete grant records with Dimensions source, the value in the "data-source" column must be "dimensions-grants". The input file will look like this:
data-source,id
dimensions-grants,grant.8382802
We updated the tool to use the new configuration on both systems (QA and PROD).
Please, test it also in your side and let us know your comments.
Kind regards,
Lucian B.

Using the format above to successfully delete grants now.
data-source,id
dimensions-grants,grant.8382802


Feature: Add new language filter in Search Movie Page

Languages

English
Spanish
French
Hindi
etc.

@sid0000007 : please assign me this one

@mehul-m-prajapati go ahead ⭐


[FLINK-10252] Handle oversized metric messges

What is the purpose of the change
This pull request handles oversized metric messges
Brief change log

Handle oversized metric messges

Verifying this change
This change is already covered by existing tests, such as MetricQueryServiceTest#testHandleOversizedMetricMessage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zentol What about this change?

@zentol What do you think of this change? It may cause the last serialized metric to exceed the specified size (overflow). Do you think we need to retrace? If you need to retire the last serialized metric, we may need to introduce a "pre-calculated size mechanism".

@zentol About the MetricRegistryConfiguration I have reverted, please review.

Hi @zentol I have not add test for the new implementation, but can you review it firstly so that it can match your requirement? Thanks.

In fact, Travis has been built successfully.

@zentol If you can give a review suggestion as soon as possible, then I can refactor it quickly so that it catches up with 1.7.0.

@zentol

@zentol

@zentol Can you give a final check about this PR? thanks.

@zentol

@zentol

Will merge this today or tomorrow depending on how much time I need for cleaning up various smaller things.


竖屏切换横屏幕后，进行Toast会变成多行限制，宽度明显减小

Environment

[ ] Autosize Version:
[ ] Target Android Version:
[ ] Device Model:
[x] Device Resolution:
[ ] Design Size On AndroidManifest:

Bug Description:

Log:

Screenshot

Related Code:

Others:

https://github.com/JessYanCoding/AndroidAutoSize/blob/master/demo/src/main/java/me/jessyan/autosize/demo/BaseApplication.java#L86
https://github.com/JessYanCoding/AndroidAutoSize/issues/248


Balance to Zero button doesn't appear in Budget Inspector when Enabled in Settings

Defective ToolKit Feature Name: Balance to Zero Button
Expected Behavior
When this option is enabled in Toolkit for YNAB settings, there should be a button in the YNAB Budget Inspector to set the category/subcategory balance to zero when clicked.
Actual Behavior
Button does not appear in inspector
Steps to Reproduce the Behavior

Launch YNAB
Got to Budget page
Button does not display in inspector

Export of Toolkit Settings (Bottom Left of Settings Page)
[{"key":"accountsClearSelection","value":false},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":false},{"key":"accountsRowHeight","value":"0"},{"key":"accountsSelectedTotal","value":false},{"key":"accountsStripedRows","value":true},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"0"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":true},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"0"},{"key":"changeEnterBehavior","value":false},{"key":"checkCreditBalances","value":false},{"key":"checkNumbers","value":true},{"key":"collapseExpandBudgetGroups","value":false},{"key":"collapseSideMenu","value":true},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":false},{"key":"currentMonthIndicator","value":true},{"key":"daysOfBuffering","value":false},{"key":"daysOfBufferingHistoryLookup","value":"0"},{"key":"editButtonPosition","value":"0"},{"key":"enableRetroCalculator","value":false},{"key":"enlargeCategoriesDropdown","value":true},{"key":"enterInRegisterNow","value":true},{"key":"goalIndicator","value":false},{"key":"goalIndicatorWarningColor","value":false},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":false},{"key":"hideHelp","value":true},{"key":"highlightNegativesNegative","value":false},{"key":"importNotification","value":false},{"key":"incomeFromLastMonth","value":"0"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":true},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":false},{"key":"printingImprovements","value":true},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":false},{"key":"removeZeroCategories","value":false},{"key":"reports","value":true},{"key":"resizeInspector","value":false},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":false},{"key":"seamlessBudgetHeader","value":false},{"key":"showIntercom","value":true},{"key":"splitKeyboardShortcut","value":true},{"key":"splitTransactionAutoAdjust","value":true},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":true},{"key":"swapClearedFlagged","value":true},{"key":"toBeBudgetedWarning","value":false},{"key":"toggleSplits","value":true},{"key":"toggleTransactionFilters","value":"0"},{"key":"warnOnQuickBudget","value":false}]

### System Settings

ToolKit Version:
Operating System (Mac/Windows/Etc): MacOS Sierra, Windows 7
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 55.0.2883.87 m
Other Extensions: Mail this Link

An additional comment to clarify this issue: It looks like there is no button when no categories are selected (when the inspector is showing data for the entire budget as a whole). I'm having a hard time telling if this is an actual bug, or if this feature currently only works for individual categories.

I have this problem. I think it's related to this:
https://forum.youneedabudget.com/discussion/53472/0-7-8-many-tools-not-available-without-refreshing-browser
If I refresh the page, then the Balance to Zero button shows up (along with other features like Check Credit Balances).
@falkencreative Even when a category is selected, the button doesn't appear until I refresh the page.
e.g.

Go to budget page (no button)
Select a category (no button)
Refresh Page (no button)
Re-select category (button appears)

I think the button is not supposed to appear until a category is selected, but it's not doing that unless the page is refreshed.

This feature (budget to zero) works at the sub-category level only.

David,
A sub-category is selected but there is no button for balance to zero.
Peterr
On Jan 18, 2017, at 02:01 PM, David Baldon<EMAIL_ADDRESS>wrote:
This feature (budget to zero) works at the sub-category level only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

yes, i was unfamiliar with the terminology. i meant sub-category in my response above.

I can confirm the button appears after doing a browser refresh (F5).
On Jan 18, 2017, at 02:01 PM, David Baldon<EMAIL_ADDRESS>wrote:
This feature (budget to zero) works at the sub-category level only.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I think it is related to the comment by ScooterYou in the forum link provided earlier in this thread. IOW, if you enter the app without the "budget id' as part of the URL, some of the features are not active. What's odd is I can see the link to the script in the  but when you look at the Sources tab of the Developer Tools, you don't see all the features listed (there should be a folder for each active feature). Budget to zero is one of the missing features. PF5 reloads the page which at that point includes the 'budget id' as part of the URL. I'll look into this some more this evening.

@dbaldon I am ScooterYou on the forum. Sorry for any confusion.
Here's a quick screen recording of the bug.
https://drive.google.com/open?id=0B57T5ClKR-IKNkVaWkpTdEJaeVk

I've determined why the feature isn't working as it should. Should have a code fix ready to go shortly.

PR #670 created.

Your PR fixes seems to fix this issue for me. Thanks.
There are other features, like Check Credit Balances, that have the same problem (not loading except on refresh).

I think some of this is also related to several features that throw uncaught errors during startup. I've submitted PRs for a couple of them (PR #657 PR #656). My comment earlier in this Issue described a discrepancy I observed between the scripts loaded and the features loaded (as seen in the Developers Tools Sources tab). Last night I switched to the branch that fixed the problem in accounts-row-height and with no startup errors thrown, all the features loaded as expected. Maybe I'll try and step through the "load" code to prove it.

@datvance any feature that has this;
budgetView: ynab.YNABSharedLib.getBudgetViewModel_AllBudgetMonthsViewModel()._result,
needs the following in the function invoked by invoke();
// After using Budget Quick Switch, budgetView needs to be reset to the new budget.
if (ynabToolKit.budgetBalanceToZero.budgetView.categoriesViewModel === null) {
  ynabToolKit.budgetBalanceToZero.budgetView = ynab.YNABSharedLib.
  getBudgetViewModel_AllBudgetMonthsViewModel()._result;
}

For the check-credit-balances it should go in getDebtAccounts()

I thought so too, but I have my own clean build of the toolkit with no
errors, and I still have some features not loading until refresh. Seems
like there is something else going on with the load code.
On Jan 19, 2017 7:18 AM, "David Baldon"<EMAIL_ADDRESS>wrote:

I think some of this is also related to several features that throw
uncaught errors during startup. I've submitted PRs for a couple of them (PR
#657 https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/657 PR
#656 https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/656). My
comment earlier in this Issue described a discrepancy I observed between
the scripts loaded and the features loaded (as seen in the Developers Tools
Sources tab). Last night I switched to the branch that fixed the problem in
accounts-row-height and with no startup errors thrown, all the features
loaded as expected. Maybe I'll try and step through the "load" code to
prove it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/665#issuecomment-273787446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvXfDCpLsyv9oC5vKI_5Krbc6Ns16COks5rT3DIgaJpZM4LnAWY
.

Setting a breakpoint on invoke() and seeing what happens (if anything) during a load should help track them down. That's how I found the issue with budgetView not being valued.

@dbaldon Your suggestion above to check and set budgetView if null worked in check-credit-balances, and I added it to my existing PR for the feature.

@pdvachon can you verify this is resolved and close the Issue if it is? Thanks.

Dear David,
Yes, it appears to be working now. Thanks!
Peter

On Jan 25, 2017, at 5:47 PM, David Baldon<EMAIL_ADDRESS>wrote:
@pdvachon https://github.com/pdvachon can you verify this is resolved and close the Issue if it is? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/665#issuecomment-275257355, or mute the thread https://github.com/notifications/unsubscribe-auth/AYBW-9FbKUWEe7_uBuavMjDAHqQHEUeCks5rV9D1gaJpZM4LnAWY.

@pdvachon Thanks


Marketplace Demo "Basic Listview with Images" bad link

@lonerzzz commented on Sun May 19 2019
Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
current online state of Marketplace
Describe the bug
I have raised the bug here as I saw no other means of providing input.
In the marketplace, the demo "Basic Listview with Images" has a bad link. It links to a Hispanic restaurant viewing application instead of the stated listview demo. Additionally, the replacement application is broken. I have fixed it here:
https://play.nativescript.org/?template=play-ng&id=2OkUP6&v=29
To Reproduce
Look for the demo as titled above and follow the playground link to it.
Expected behavior
I was looking for the multicolumn listview demo, but it was unavailable and i had to fix the existing demo to confirm what I was getting instead.
Sample project
Not applicable.
Additional context

The link in the Marketplace has been fixed here


Add customizable 'before_cache' stage

Often users want to perform cleanup tasks before the new cache
is uploaded; for example, deleting a new marker file which
fools casher into thinking that the entire cache is new.
Also, after_result stage is renamed to cache, which correctly
describes the purpose of this stage.
Note that this is now a non-critical stage, since failure to update
cache should not fail the entire job.

Tested in staging: https://staging.travis-ci.org/BanzaiMan/travis_staging_test/builds/429632#L97


chore(contracts): Replacing an Attestation should revoke first and create the new attestation later

What does this PR do?
Related ticket
Fixes #840
Type of change

[X] Chore
[ ] Bug fix
[ ] New feature
[ ] Documentation update

Check list

[ ] Unit tests for any smart contract change
[ ] Contracts and functions are documented

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.59%. Comparing base (251a440) to head (f2e52ee).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #841   +/-   ##
=======================================
  Coverage   48.59%   48.59%
=======================================
  Files          18       18
  Lines         391      391
  Branches       63       63
=======================================
  Hits          190      190
  Misses        198      198
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Rule: no-unlayered-styles

Rule details
Flag any CSS rules that are outside a @layer block.
What type of rule is this?
Warns about a potential problem
Example code
This will be flagged:
/* ❌ */

p {
  color: red;
}

@media (width > 500px) {
  .box {
    padding: 12px;
  }
}

This is fine:
/* ✅ */

@layer foo {
  p {
    color: red;
  }
}

@media (width > 500px) {
  @layer bar {
    .box {
      @layer baz {
        padding: 12px;
      }
    }
  }
}

Note: Nested layers can used as @layer foo.bar {…} and anonymous layers can be used as @layer {…}. Both of these are fine and should not be flagged.
Some CSS, like @import, is fine to keep outside a @layer, because the contents of the file would still be using @layer.
@import "foo.css";
@import "bootstrap.css" layer(thirdparty);

@layer foo {…}

Participation

[ ] I am willing to submit a pull request to implement this rule.

Additional comments
When working with cascade layers, unlayered styles are usually a mistake. It is easy to forget to wrap the styles in @layer, which is exactly the kind of thing a linter should help with.
This rule probably should be opt-in, because cascade layers aren't being widely used yet.

I'm not familiar with cascade layers. Are you saying that if there's one @layer in a file then everything should be contained in an @layer? More detail would be appreciated.

Thanks for considering this feature. Happy to explain in more detail.
The main problem here is that unlayered styles will take precedence over layered styles. When using layers in a codebase, we usually want everything to be in some layer. (The file doesn't matter, it's more about the overall codebase)
Here's an example scenario:
0. You might decide that your project will be set up using three cascade layers: @layer globals, components, utilities. So, within your CSS files, you will want to use one of these layers.

Let's say one day you are adding a new component to the project and writing some CSS for it. This CSS should go in @layer components.
If you forget to wrap the component CSS in @layer components, then it will incorrectly take precedence over the utilities layer. Eslint can help prevent this situation and maintain code discipline.

A related problem that should probably be a separate issue is that it's too easy to misspell a layer name, e.g. @layer utilitiies, which can break everything and cause confusion. Maybe that needs a custom eslint plugin though.

Got it, thanks. ESLint doesn't work across files, so we only know what's happening in the current file.
I can see how this would be valuable, as you probably don't want to mix layered and unlayered styles. And I agree, this shouldn't be enabled by default.
So it sounds like we'd just need to flag any rule that isn't inside of a layer?

I've seen a few different conventions for layers, including intentionally mixing layered and unlayered styles. Perhaps no-restricted-syntax is a good fit for users to enforce their preferred ones?
For example, to enforce that:

all styles are authored as unlayered
all imports are put into layers

rules: {
  "no-restricted-syntax": [
    "error",
    {
      selector: "Atrule[name=layer]",
      message: "The `@layer` at-rule is disallowed. Author unlayered styles instead.",
    },
    {
      selector: "Atrule[name=import]:not(:has(Layer))",
      message: "Imports must be put into a layer.",
    },
  }
}

Which would enforce this convention:
/* button.css */
.button {
  color: red;
}

/* styles.css */
@import "bootstrap.css" layer(vendor);
@import "defaults.css" layer(defaults);
@import "button.css" layer(components);
@import "slider.css" layer(components);

Or, to enforce the original use case that rules must be within a @layer:
{
  selector:
    ":matches(StyleSheet > Rule, StyleSheet > Atrule[name!=layer]:has(Rule):not(:has(Atrule[name=layer] Rule)))",
  message: "StyleSheet cannot contain unlayered rules",
},

(i.e. flag top-level rules and non-layer at-rules which contain rules outside of @layer. There may be a more concise selector...)
Which would enforce:
@layer foo {
  p {
    color: red;
  }
}

@media (width > 500px) {
  @layer bar {
    .box {
      @layer baz {
        padding: 12px;
      }
    }
  }
}

People can enforce other @layer conventions, too. Such as:
Disallowing anonymous layers:
{
  selector: "Atrule[name=layer]:not(:has(> AtRulePrelude))",
  message: "Anonymous layers are disallowed.",
},

layer {
  body {}
}

And restricting the name of layers:
{
  selector: "Layer[name!=/\\b(utilities|components)\\b/]",
  message: "Only `utilities` and `components` layers are allowed.",
},

layer unknown {
  body {}
}

There are likely more cascading layer conventions people would want to enforce. I'm unfamiliar with ESLint's conventions; when do things become rules, and when are they left to no-restricted-syntax?

@jeddy3 there are downsides of using no-restricted-syntax, the biggest being that it's not easy to modify just one entry in a config that is inheriting from another. For instance, imagine there's a base config that looks like this:
export default [{
rules: {
  "no-restricted-syntax": [
    "error",
    {
      selector: "Atrule[name=layer]",
      message: "The `@layer` at-rule is disallowed. Author unlayered styles instead.",
    },
    {
      selector: "Atrule[name=import]:not(:has(Layer))",
      message: "Imports must be put into a layer.",
    },
  }
}
}];

And you'd like to add a custom warning in your config file that inherits from that base config. You'll now need to pull out this definition of no-restricted-syntax using JavaScript, create a copy of the array, then push your new check onto the end of that array, before inserting into your new config.
Also note that the esquery syntax, while handy, does come with parsing overhead. The longer your selector, the slower the match will be. For any sufficiently long esquery string, it's really a good idea to just create a rule and implement that check in JavaScript.
So no-restricted-syntax is really a utility to use when you just want to add a quick rule without the overhead of another file.
When there are well-established patterns that would benefit multiple people, we generally look to creating a new rule with configurable options to cover 80-90% of cases. This has the benefit of a rule explicitly saying what it does (no-invalid-properties vs no-restricted-syntax). I think this use case, defining that layers are preferred in some way, definitely speaks to having its own rule.
A while back I created a utility to easily create new rules using no-restricted-syntax-style configuration:
https://github.com/humanwhocodes/eslint-simple-rule

Let me now if this sounds like a fairly cohesive description for this rule:

Expect all rules to occur in named layers
By default, don't require @import statements to have layer.
Option: requireImportLayer: true to enable checking that @import statements have layer.
Option: allowAnonymousLayers: true to allow layers without names.
Option: layerNamesPattern that accepts a regex string that layer names must match (allowAnonymousLayers must be false for this).

Of course, if people want to mix layered and non-layered rules, they wouldn't enable this rule.

It looks good, except maybe for this parenthetical at the end:

layerNamesPattern that accepts a regex string that layer names must match (allowAnonymousLayersmust befalse` for this).

Sometimes it's fine to have an anonymous layer inside a named layer, so layerNamesPattern and allowAnonymousLayers don't need to be mutually exclusive. layerNamesPattern should only be concerned with disallowing unknown names.

Sometimes it's fine to have an anonymous layer inside a named layer, so layerNamesPattern and allowAnonymousLayers don't need to be mutually exclusive. layerNamesPattern should only be concerned with disallowing unknown names.

Good call out, I agree. :+1:
I think I'd also probably call this use-layers because we actually want to enforce the use of layers rather than disallowing something.

Thank you for explaining the downsides of no-restricted-syntax and the ESLint conventions around rules. The eslint-simple-rule utility looks very useful!

Expect all rules to occur in named layers

If someone uses cascade layers via @import with layer(), I think they'd expect all rules to occur outside of @layer.
For example:
/* defaults.css */
a {
 color: pink;
}

button {
  color: red;

  &:hover {
    color: orange;
  }
}

/* primary-button.css */
.primary-button {
  color: blue;
}

/* secondary-button.css */
.seconday-button {
  color: green;
}

/* styles.css */
@import "defaults.css" layer(defaults);
@import "primary-button.css" layer(components);
@import "secondary-button.css" layer(components);

I think people take this approach so that:

the orchestration of layers occurs in one place
a developer working on a component doesn't need to know about the layering system (other than knowing their styles will take precedence over any defaults regardless of specificity)

Can the use-layers rule support this use case, too?
I'm not sure the requireImportLayer: true option makes sense if someone uses cascade layers via @layer. I suspect people would want to enforce cascade layers via @layer or via @import with layer(), but not both.
Would moving the requireImportLayer option to be a primary one that switches modes resolve this?
For example, "use-layers": [error, "via-at-layer"] would:

Expect all rules to occur in named layers

And something like "use-layers": [error, "via-at-import"] would:

Expect all rules to occur outside of named layers
Expect all @import statements to use the layer() function

The allowAnonymousLayers and layerNamesPattern options would apply to both modes.

That's fascinating. I did wonder if people used both approaches to nest their layers.
Is there a way to wrangle the options so that the rule supports both use cases?:

only using @import (via the layer() function) to layer styles
using @layer to layer styles (and optionally nest layers using @import)

I wonder if there are more use cases, too. It feels like there aren't established patterns around cascade layers yet.

Keep in mind that ESLint functions on only one file at a time. If you're using the pattern where all of your files don't contain layers except for your top-level file that imports everything into layers, then you'd only enable use-layer for that one file that's importing everything. There's no reason to enable it for other files. So you might do something like this:
import css from "@eslint/css";

export default [
    {
        plugins: {
            css
        },
        files: ["styles/*.css"],
        ...css.configs.recommended
    },
    {
        plugins: {
            css
        },
        files: ["styles/index.css"],
        rules: {
            "css/use-layers": "error"
        }
    }

];

I forgot about overrides, sorry 😅
Would it make sense to tweak the description to:

By default, require all rules to occur in named layers (e.g. @layer foo {})
By default, require @import statements to have named layers (e.g. @import "bar.css" layer(foo);)
Option: allowAnonymousLayers: true to allow layers without names (either @layer {} or @import "foo.css" layer;)
Option: layerNamesPattern that accepts a regex string that layer names must match

So that @mayank99's use case is enabled without options:
import css from "@eslint/css";

export default [
    {
        plugins: {
            css
        },
        files: ["styles/*.css"],
        ...css.configs.recommended
    },
    {
        rules: {
            "css/use-layers": "error"
        }
    }
];

i.e. use cascade layers everywhere (both to wrap rules and when importing).
So is the @import-only use case:
import css from "@eslint/css";

export default [
    {
        plugins: {
            css
        },
        files: ["styles/*.css"],
        ...css.configs.recommended
    },
    {
        plugins: {
            css
        },
        files: ["styles/index.css"],
        rules: {
            "css/use-layers": "error"
        }
    }
];

And the same for an @layer but no @import use case:
import css from "@eslint/css";

export default [
    {
        plugins: {
            css
        },
        files: ["styles/*.css"],
        ...css.configs.recommended
    },
    {
        plugins: {
            css
        },
        files: ["styles/components/**/.css"],
        rules: {
            "css/use-layers": "error"
        }
    }
];


Fixed convert function monotonic failure when string data type

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category:

Bug Fix

Short description:
Query is failure when use toUInt64 function with primary key of string data type in where expression,
Because toUInt64 did the wrong monotonic optimization

Let's also retain the old test,
and add your test in a new file.

Old tests are kept in:

https://github.com/yandex/ClickHouse/pull/3870/files#diff-a485106b9dfd012a710477225331f6daR27
https://github.com/yandex/ClickHouse/pull/3870/files#diff-a485106b9dfd012a710477225331f6daR36
https://github.com/yandex/ClickHouse/pull/3870/files#diff-a485106b9dfd012a710477225331f6daR49

Should I restore the original SQL file ?

Yes. Just in case, it's reasonable to also keep the existing case separate.
Because if both tests will be broken, the old test may be simpler for investigation.

The test fails constantly in debug build.

The business logic is broken.
SELECT toInt8(CounterID)
FROM test.hits
WHERE CounterID = 23192098

┌─toInt8(CounterID)─┐
│                34 │
│                34 │
│                34 │
└───────────────────┘

SELECT CounterID
FROM test.hits
WHERE (CounterID = 23192098) AND (toInt8(CounterID) = 34)

Ok.

0 rows in set.

You are reading uninitialized data.

The business logic is broken.

Might the be added to the test case?

You are reading uninitialized data.

Into a Null value when convert RNP?  the logic here is not very clear to me.

Into a Null value when convert RNP? the logic here is not very clear to me.

It's about field.get<Int64>() when field can be NULL.
Probably this error was already present.
I've rewriting it.

Might the be added to the test case?

This was found by a test case in internal ("stateful") part of tests.

#3921


Update Dogs.json

Added info about golden retriever

Hey @Arijit0918 I am sorry but this is a very minimal contribution kindly add more to it then, I'll happily merge your request
Sorry for the trouble

Hey @GeekGuy-29 about how many dogs should I contribute for getting my request merged ?

@Arijit0918  Buddy you can refer the previous commit history, and ya please try to add info of those dogs, who haven't been added yet <3