Color support

Changes extracted from #138 by @B3zaleel.
Closes #165.
TODO:

[x] leave only the original commands (\color and \colorbox)
[x] fix the failing unit tests
[x] think about the accepted color formats

[x] check if any existing TeX distributions have something like that

[x] write the documentation for the new color input
[x] add tests for the new input
[x] fix the implementation according to the tests
[x] make sure it's robust enough so the new color parsers could be added easily
[x] review all the comments below
[x] add tests for double/integer parse errors in the color parsers (all should throw TexParseExceptions)
[x] add tests for negative / too big values for all the numbered models (should also throw TexParseExceptions)
[x] make sure the corresponding infrastructure and helper classes are public
[x] review all the code one final time

Alright, I'm going to finalize this task based on @B3zaleel's contributions. Stay tuned.

Thanks, everyone! Now this is (finally!) ready for merge.


Project structure

Structure the project so that the three repositories are contained within one folder and fix the config variables and relative paths to work without requiring /home/user location

Remove SUDO from pip installs

older than required versions of cmake are downloaded in the script

Start script throws error E: Unable to locate package libgdal30

Done. Now repositories can be located in any folder, as specified in pipeline configuration file: config.inc.sh


spfx doctor: add gulp-cli checks

Add gulp-cli checks to spfx doctor. Closes #3541
Closes #3541
Added method to check for gulp-cli
Updated method that checks gulp to just check if it is present, which triggers failure and fix (updated below)
Updated the prerequisites section as follows:

Added section for gulp-cli to each SPFx version
--  Any version of gulp-cli is valid since all versions of SPFx use gulp ^3 || ^4
-- Fix for missing gulp-cli is to install latest "npm i -g gulp-cli"
Updated the gulp section for each version of SPFx
-- I left the version information the same, even though we don't compare versions
-- changed the fix to uninstall gulp "npm un -g gulp"

I'm not sure where lines 3, 4 & 6 came from. I did not intentionally add them. They are not needed for the changes I made.

Gulp's getting started documentation says "If you've previously installed gulp globally, run npm rm --global gulp before following these instructions."
So, if we're recommending the installation of gulp-cli then we should pass along gulp's recommendation to remove gulp first.

It seems that we've got some broken tests. Would you mind having a look before we process the PR @DonKirkham?

I ran "npm test" and it reported an error with tabs vs spaces. I fixed that. It is also showing a code coverage error, but it looks like that is not in the files I worked with.  Not sure if I fixed everything needed, but I gave it a shot.

I updated the tests, changing references for gulp to gulp-cli. I see three issues:

Lint reports that there are 3 import statements in spfx-doctor.ts that are not used. I have tried to delete them, but when I save, they come back. I think it is a merge issue, but can't find a fix.
The cov test reports less than 100% coverage in spfx-doctor.ts. The reported outage is that there is no test to cover what happens when gulp is found, lines 630-632. I am not sure how to write this new test, so I need some guidance.
The cov test is reporting the following error, which is in an area I have not touched.

 1) utils/md
       converts code fences:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(cliCompletionClinkUpdateHelpPlain.includes('  cli completion clink update > m365.lua'))

      + expected - actual

      -false
      +true

Thanks for the help getting this finished.

Merged manually. Thank you and welcome to the team! 👏 🎉

Merged manually. Thank you and welcome to the team! 👏 🎉

Thanks. Sorry about the weird spacing issues. Something in my VS Code settings causes this, but I thought I had fixed them all. Since this is merged, can I delete my branch?

No problem, and yes, you're all good to delete your branch.


Error when fetching a member profile

I tried to fetch a user profile:
user = await self.fetch_profile_by_display_name('Luc1412')
and got this error:
File "C:\Users\luc14\AppData\Local\Programs\Python\Python38-32\lib\site-packages\fortnitepy\client.py", line 1043, in fetch_profile_by_display_name
    account = max(epic_accounts, key=lambda d: d['externalAuths'])
TypeError: '>' not supported between instances of 'dict' and 'dict'

This is a silly mistake by me. It will be fixed in the next version :)

Didn't mean to close. Oops.

The issue should now be resolved :)


Include a way to inject endpoint_url to boto3.

While using localstack, it would be nice to provide a way to inject en endpoint_url for the S3 and SNS clients so they can used in localstack.

Hi @dmarkey I'm not too familiar with the interworkings of LocalStack, but are you asking for a way to inject LocalStack's S3 and SNS endpoints into this project? We welcome PRs, so maybe a PR submission will better explain the functionality you're asking for.

https://github.com/upsidetravel/bucket-antivirus-function/pull/167 Here's the gist.

Great thanks for that, I agree this functionality makes sense. Go ahead and tag me on that PR when you verified that it's working as expected. And verify it's also working as expected if those env variables aren't specified 😃


Cannot provide my own id

The structure you use to save the resources automatically generates an incremental ID, in which case you want to save this:
{
    id: 100,
    fname: "Joel",
    lname: "Jaime"
}

I simply omit the ID field since I would try to replace the one generated by lowdb-api.
One suggestion would be that instead of an incremental ID you generate a kind of {_id: guid_format} (or any unique data) or have the identifier inside protected object:
{
    core: {
        id : AUTOGENERATED_ID
    },
    fname: "Joel",
    lname: "Jaime"
}

Related with the PR #3

@jblandino Do you think it is common to provide an ID on creation? If that's the case I'm open to consider allowing users to provide id on creation.
As you mentioned, I think it would be also good to allow user to provide a function for id generation. That way, user can opt-in for any kind of identity generator.
What are your thoughts?

Hi @rmariuzzo.
Well if you knew that when I implemented it in a project that I currently have, the first thing I did was send some session data to see how I could store them temporarily but send these fields:
{ id: Number, _token: String, date: DateTime }

The ID is a value that I generate in my own application and for me that field is mandatory, it happens that when I save it I realize that lowdb replaces it with its own identifier automatically.
This need was that it led me to think that it would be good to leave the resource identifier outside the object where the user's data is stored

@jblandino in that case I'm willing to allow user to provide their id. The flow will be:

user post data.
if the posted data contains id use it, otherwise use generator.
persist posted data.

What do you think? I'm open to suggestions.

Perfect @rmariuzzo , if the user passes his own ID he could use it and in case he does not pass it then the autogenerate is used, I see it well.


Add pagination to universerpc calls

Description
This PR enables pagination for some of the universe rpc calls, specifically AssetRoots and AssetLeafKeys.
Closes #590

@GeorgeTsagk is attempting to make the batch mint itests with pagination being enabled
But the batch mint itests is also failing on main branch
The linter may not be running on this itests so there could be some rot

Pushed an itest that covers pagination


Seamless SSL transfer

This feature is needed to reach more than a few Node.js developers. The transfer from https.Server to µWS should be as seamless as in other implementations.
While adding SSL support is pretty straight-forward, making sure to properly transfer an existing SSL connection from Node.js to us is not as trouble-free. It seems to be possible though, being passed a tls.TLSSocket should make it possible to get the underlying TLSWrap which exposes the ssl() function returning the SSL pointer which is reference counted.

tls.TLSSocket.ssl._external should give the SSL pointer, but this feature seems broken in Node.js for the time being.
https://github.com/nodejs/node/issues/6338

This issue was a duplicate and was fixed already. Should land in the next Node updates (4.x, 5.x). Should probably be part of 6.x also.

I seem to have a working seamless SSL transfer now. It works in Node 5.x and seems Valgrind clean. I can send messages over SSL connections established by the Node.js HTTPS server.
https.createServer(options, (req, res) => {

  /* SSL, FD, secKey */
  addon.transfer(req.socket.ssl._external, req.socket._handle.fd);
  res.socket.destroy();
  addon.write();
  setTimeout(() => {
    console.log('Ending SSL connection now');
    addon.end();
  }, 1000);

}).listen(8000);

/* part of the WebSocket */
SSL *ssl;

void transfer(const FunctionCallbackInfo<Value> &args)
{
    /* get FD, SSL * */
    int fd = args[1]->IntegerValue();
    ssl = (SSL *) args[0].As<External>()->Value();

    /* Node.js DestroySSL calls SSL_free */
    ssl->references++;
    /* Node.js want to delete its own BIO's */
    SSL_get_rbio(ssl)->references++;
    SSL_get_wbio(ssl)->references++;

    /* dup the fd, set new BIO */
    SSL_set_fd(ssl, dup(fd));
}

void write(const FunctionCallbackInfo<Value> &args) {
    SSL_write(ssl, "The quick brown fox jumps over the lazy dog", 43);
}

void end(const FunctionCallbackInfo<Value> &args) {
    SSL_shutdown(ssl);
}

Good news. I have a working port of engine.io to uws. I'll put it up. It still has a few issues passing the all socket.io tests but in time.

Nice, keep running these tests and report issues :)


Update to FOS 6.4.5

Will use FOS 6.4.5 in the deployment template, upgrading from 6.4.3

resolved.


readOnly and writeOnly required properties incorrectly validated in examples

Version: 0.88.3
When defining a readOnly or writeOnly property on a component, the linter does not take that into consideration when validating examples for request bodies or response bodies.
For example, if I defined a component with an id property that was defined as readOnly, I would expect that:

In a requestBody, the id field is disallowed in the examples, because it is "read only"
In a response, the id field is required to be present in examples, because it is "required"

What I actually see is that the property is required in both the request body and the response, with the following error:
  Message :   "example" property must have required property "id"
  Rule    :   oas3-valid-media-example
  Path    :   components.requestBodies.ReplaceEntityRequest.content.application/json.example

@rliebz I think you're correct, I would expect the same behavior you've described above. I hadn't noticed this before. Unfortunately, the rule oas3-valid-media-example is coming from Spectral's own ruleset, which we import into ours. You might want to open up an issue against their repo for their awareness

Looks like a known issue: https://github.com/stoplightio/spectral/issues/1274

Closing this issue since the problem is occurring in the spectral ruleset which we inherit.


[REQUEST] Compatibility with upcoming Chipped update

Is your feature request related to a problem? Please describe.
It is not a problem per se but it'd would be a great enhancement to your mod. The Chipped team, basically a mod like Chisel but maintained, a much nicer style and using ingame workbenches to convert the textures of a block, is currently overhauling their alternative block textures and adding some for doors too. Seeing as your mod is so great on compat (seriously, much respect, I love it) with other popular mods this might be a really good one to add to the collection.
Describe the solution you'd like
Obviously there is the option of replicating the mod's style and adding them yourself.
Describe alternatives you've considered
The Chipped devs also talked about making the next update, after the texture overhaul, about mod compatibility. Perhaps getting in contact with them about it could be useful, especially if you want to implement the doors via the workbench system of the main mod.
Additional context
Here is an image of W.I.P door textures the Chipped devs released a while back:

Here we go again and I did Macaw's Doors support recently. It's going to take a long time but it's a possibility.

It's definitively a big project, I will ngl lmao. I asked about it on their discord as they were taking suggestions as well on what compat they should add, perhaps something will come of that in the future (have not received an answer so far). If not, I will be trying my hand at making some of the textures myself once their update comes out to ease the load but I am kind of new-ish with pixel art so that could get interesting lol
It's also not tragic if it doesn't happen but something about mods working seamlessly together with compat like this just makes me really happy and probably a lot of mod-pack makers as well

That sounds good! Once the textures are settled, work can start. I've even got the data-gen for producing model JSON files.

Update: Work has started. I've coded in the functionality alongside data JSON files. Now only textures remain, they're currently placeholder.

Another update: Chipped support has been added to both Forge and Fabric version of Dramatic Doors! Starting in Forge mod version 2.1.4 and Fabric mod version 1.3.4.


[testlib] Add GROMACS benchmark tests

This is a continuation of the work on the test library. This PR work has been done with GROMACS tests. A new file base_check.py has been added, introducing the main class for the GROMACS test, as well as the CSCS tests inherited from it.

Hello @hurricane642, Thank you for submitting the Pull Request!

In the file hpctestlib/apps/gromacs/base_check.py:

Line 64:5: E303 too many blank lines (3)
Line 99:15: E271 multiple spaces after keyword

Do see the ReFrame Coding Style Guide

Can I test this patch?

Codecov Report

Merging #2186 (9bc222e) into master (eda1667) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.02%
==========================================
  Files          53       53
  Lines        9571     9557      -14
==========================================
- Hits         8259     8249      -10
+ Misses       1312     1308       -4

Impacted Files
Coverage Δ

reframe/utility/osext.py
84.71% <0.00%> (ø)

reframe/frontend/autodetect.py
62.41% <0.00%> (+0.54%)
:arrow_up:

reframe/core/systems.py
89.38% <0.00%> (+0.62%)
:arrow_up:

reframe/utility/jsonext.py
86.04% <0.00%> (+1.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda1667...9bc222e. Read the comment docs.

ok to test

@victorusu We will also need to document the test properly. I will address the PR comments, but can you expand a bit on what the actual tests. An important thing is to point to the input files.

@jenkins-cscs retry daint


Feature request: expose DATCOM + add force coefficient file writing

The MissileDATCOM methods that are in tudat::input_output should be exposed to Python.
In addition, a function could be added to MissileDatcomData to save the force coefficients in the same format as the files that have to be inputs of aerodynamic_coefficients.tabulated_force_only_from_files.
This is quite low-priority, but I am still working on it right now since I will personally use this feature for my thesis.

A new function has been added to tudat::input_output::MissileDatcomData, to save not all the coefficients, but only the force and moment coefficients.
These are saved in files as a function of angle of attack, and Mach number, in the format that can be used as input of environment_setup.aerodynamic_coefficients.tabulated_from_files.
This was pushed in 01babec.

tudatpy.io.missile_DATCOM_data is now exposed. This was pushed in 065e23089754b053fe8aa7309486c10b911999d2.

A unit test has to be added for this, as well as API documentation.

The docstrings have been added to these new Missile DATCOM methods with a036e67.


Error when I use 1-channel image file

Hi,
I am using SRGAN "test_image.py" for a 1-channel image file. I see the following error:
"RuntimeError: Given groups=1, weight of size [64, 3, 9, 9], expected input[1, 1, 128, 128] to have 3 channels, but got 1 channels instead"

Please let me know how I can use SRGAN for 1-channel image.
If I train network from scratch with a dataset containing only 1-channel images, can I use this new model for 1-channel images?

@mohammad-saber  you should change input channel of model to 1 and change data loader code to load 1 channel image


mcp: use correct superchain config proxy

Description
Generated using https://github.com/ethereum-optimism/optimism/pull/9865

Does this need a markdown edit too?

This PR LGTM and is now ready for review. Mark and I spent some time improving and cleaning up the validation file, so this is ready for final review

I have addressed the outstanding comments on this PR


fix: better error message for multiple workflow controllers running

Motivation
Per various GitHub issues and personal experience, the "expected < 2 pods, got 2 - this is a bug" error message mostly happens these days when users accidentally have multiple workflow controllers running. This is usually caused by a bad install, e.g. installing a cluster-wide Argo Workflows alongside a namespace-scoped one, and having both controllers reconciling Workflows.
Modifications
Improve the error message to advise users to check for this.
Verification
I didn't verify this, since it's just a text change.

who can merge? This is my first contribution :)

Thanks Greg!


TypeError: new(): invalid data type 'str'

When I train the model by running python train.py I got error:

Please help!

I preprocess all text to int before training model because I want to reduce time for convert text to int

I have no idea. Can you show me how to fix this error?

As you can see, torch tensor requires int, not str, because before I trained the model, I calculate all word ids, error ids,... . You can read my code in dataloader

Hi sir, thank you for your answer. When I training I have another problem: ValueError: Expected input batch_size (3072) to match target batch_size (3200).

This error happens after training about 3 epochs, may be something wrong when I preprocess the data.
Can you show me why this happen and how to fix this? Thank you very much and have a nice day!


Add reasonable defaults to vulncheck evaluator

Please describe the enhancement
The idea is to be able to call the vulncheck evaluator without much configuration, and do the right thing if nothing is passed. That is, add reasonable defaults. Currently, we have to instantiate the pr_vulnerability_check rule as follows:
pull_request:
  - type: pr_vulnerability_check
    def:
      action: review
      ecosystem_config:
        - name: npm
          vulnerability_database_type: osv
          vulnerability_database_endpoint: https://api.osv.dev/v1/query
          package_repository:
            url: https://registry.npmjs.org/
        - name: go
          vulnerability_database_type: osv
          vulnerability_database_endpoint: https://api.osv.dev/v1/query
          package_repository:
            url: https://proxy.golang.org/
          sum_repository:
            url: https://sum.golang.org/
        - name: pypi
          vulnerability_database_type: osv
          vulnerability_database_endpoint: https://api.osv.dev/v1/query
          package_repository:
            url: https://pypi.org/pypi

In the rule definition, this simply calls the vulncheck evaluator to do the heavy lifting. Having to add all of this configuration is tedious and error prone.
It would be better if it could just do the right thing.
Solution Proposal
If no configuration profile configuration is passed, the vulncheck evaluator should just use reasonable defaults that can be updated from minder's side.
Describe alternatives you've considered
No response
Additional context
No response
Acceptance Criteria
No response

Done in 9187f9644e775cec9f6fe63a4919d8db15808440


Timer issues on ppc

It seems on ppc systems the following is not compatible.
 73 double ibprof_timestamp(void)
 74 {
 75 #if defined(CONF_TIMESTAMP) && (CONF_TIMESTAMP == 1)
 76     return ((double)sys_rdtsc() / __get_cpu_clocks_per_sec());
 77 #else
 78     struct timeval tv;
 79
 80     sys_time(&tv);
 81
 82     return ((tv.tv_sec) + (tv.tv_usec) * 1.0e-6);
 83 #endif
 84 }

I had to disable the CONF_TIMESTAMP define and rely solely on sys_time to get correct timing data.

@janjust thank you for sharing your observation. Do you see issue with sys_rdtsc() or __get_cpu_clocks_per_sec()?

@igor-ivanov I think sys_rdtsc, that's intel specific.

@janjust @igor-ivanov
I'm not completely sure how it stable or not on PPC but I would propose following:
    timespec time;
    int result = clock_gettime(CLOCK_MONOTONIC, &time);
    return time.tv_sec * 1E9 + time.tv_nsec;

It shows good, stable results at least on modern Intel architectures.


server,config,cli: offer a separate port for SQL clients

PR: https://github.com/cockroachdb/cockroach/pull/39305
From release notes:

cockroach start now accepts a --sql-addr flag, which makes it possible to accept connections by clients on a separate TCP address and/or port number from the one used for intra-cluster (node-node) connections. This is aimed to enable firewalling client traffic from server traffic. [#39305][#39305] {% comment %}doc{% endcomment %}

Closing in favor of https://github.com/cockroachdb/docs/issues/4771.


fix: correct configuration of central publishing plugin

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@3dbf199). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage        ?   51.79%
  Complexity      ?      243
=======================================
  Files           ?       97
  Lines           ?     1334
  Branches        ?      122
=======================================
  Hits            ?      691
  Misses          ?      594
  Partials        ?       49

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:tada: This PR is included in version 0.4.1 :tada:
The release is available on:

v0.4.1
GitHub release

Your semantic-release bot :package::rocket:


Update css-modules.md

React Boilerplate
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, expecially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:

[x] You have followed our contributing guidelines
[x] Pull request has tests (we are going for 100% coverage!)
[x] Code is well-commented, linted and follows project conventions
[x] Documentation is updated (if necessary)
[x] Internal code generators and templates are updated (if necessary)
[x] Description explains the issue/use-case resolved and auto-closes related issues

Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.
Was just following the guide to integrate React-Bootstrap; realised that one of the steps is incorrect.
The section:
// Import the CSS reset, which HtmlWebpackPlugin transfers to the build folder
import 'sanitize.css/sanitize.css';

is located in app/app.js but in the step, it references app/Containers/App/index.js.

Coverage remained the same at 98.447% when pulling 943a2c597ce5b1b622d7b3b400a047cb77a150a0 on bt:patch-1 into f92cad7161de3ed8b4fff410b61ba319bd8b90eb on mxstbr:master.

Thanks!

Not sure why this was merged, or maybe I am missing something, but the instructions were correct.
File where sanitize.css is referenced: https://github.com/mxstbr/react-boilerplate/blob/master/app/containers/App/index.js#L13

Well isn't that awkward. I must have had an older version of React-Boilerplate at the time I made the PR.
I can see 'sanitize.css' was moved since this commit: https://github.com/mxstbr/react-boilerplate/commit/c47b3a1a68d1e3363500686fcb25fef48dd2ebd6
@mxstbr sorry, shall we revert this PR or would it be easier to make another PR?


Election id approval

We need to store a new piece of information called the "election-id". It uniquely identifies an election across all imports. This election-id can be tagged "approved" which we store in the database in a table called election_approvals. We reference that table from the results table by election-id.
Pivotal Card

I wouldn't mind seeing some tests that exercise the database some more, especially since there's some complexity in the interplay of the save-election-id! function, but if that's not something we've been doing I can understand. Otherwise, LGTM


Support HELM without NGINX

Describe the solution you'd like
Many xDM customers want to use K8 with their own load balancer (ex AWS ALB). Please have a HELM chart without NGINX where the active and passive services are exposed as NodePorts.

We can remove the cert-manager from this chart also.


update to go1.18.9

Includes security fixes for net/http (CVE-2022-41717, CVE-2022-41720), and os (CVE-2022-41720).
These minor releases include 2 security fixes following the security policy:

os, net/http: avoid escapes from os.DirFS and http.Dir on Windows
The os.DirFS function and http.Dir type provide access to a tree of files rooted at a given directory. These functions permitted access to Windows device files under that root. For example, os.DirFS("C:/tmp").Open("COM1") would open the COM1 device. Both os.DirFS and http.Dir only provide read-only filesystem access.
In addition, on Windows, an os.DirFS for the directory (the root of the current drive) can permit a maliciously crafted path to escape from the drive and access any path on the system.
The behavior of os.DirFS("") has changed. Previously, an empty root was treated equivalently to "/", so os.DirFS("").Open("tmp") would open the path "/tmp". This now returns an error.
This is CVE-2022-41720 and Go issue https://go.dev/issue/56694.

net/http: limit canonical header cache by bytes, not entries
An attacker can cause excessive memory growth in a Go server accepting HTTP/2 requests.
HTTP/2 server connections contain a cache of HTTP header keys sent by the client. While the total number of entries in this cache is capped, an attacker sending very large keys can cause the server to allocate approximately 64 MiB per open connection.
This issue is also fixed in golang.org/x/net/http2 vX.Y.Z, for users manually configuring HTTP/2.
Thanks to Josselin Costanzi for reporting this issue.
This is CVE-2022-41717 and Go issue https://go.dev/issue/56350.

View the release notes for more information:
https://go.dev/doc/devel/release#go1.18.9
And the milestone on the issue tracker:
https://github.com/golang/go/issues?q=milestone%3AGo1.18.9+label%3ACherryPickApproved
Full diff: https://github.com/golang/go/issues?q=milestone%3AGo1.18.9+label%3ACherryPickApproved
The golang.org/x/net fix is in https://github.com/golang/net/commit/1e63c2f08a10a150fa02c50ece89b340ae64efe4

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ff3d0ad). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3102   +/-   ##
=========================================
  Coverage          ?   62.15%
=========================================
  Files             ?      153
  Lines             ?    24176
  Branches          ?        0
=========================================
  Hits              ?    15027
  Misses            ?     7602
  Partials          ?     1547

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thx!


Exclusion grounds at lot level

Hello,
It seems that we have fields for exclusion grounds only at procedure level, BT-67(a)-Procedure and BT-67(b)-Procedure at /*/cac:TenderingTerms/cac:TendererQualificationRequest/cac:SpecificTendererRequirement/cbc:TendererRequirementTypeCode[@listName='exclusion-ground']
But we need to express some of the exclusion grounds, more specific category C from ESPD at LOT level. I have made an example that is validated OK by the CVS. But I didn't find any fields for this, something like  BT-67(a)-Lot and BT-67(b)-Lot in Fields.json
It will be valid for production such an approach?
Please see the form and the response.
Thank you
Alex Mohora

Exemple_Exclusion_Grounds_Lot.zip

Hi,
Exclusion grounds apply to the whole procedure.
If there are some specific conditions for some lots, you may need to check whether these are exclusion grounds and not award criteria. In case these are still exclusion grounds, you may consider having the specific lots in a separate notice/procedure.
Regarding CVS, rules to prevent unexpected fields aren't yet in place and it the use of such elements is neither expected, nor recommended.
KR


-Muhammad- Pagination items hidden

Environment Details

Spartacus:  beta + develop branch (d4da767d7f304bec7daf004bd8ad5c54ef48d1a9)
Browser: Chrome v75
OS: Windows 10
Device: Laptop
SAP Commerce: 1905 + Spartacus Sample Data Addon
Other environment details: Angular 8, yarn 1.16, node 10.16.0

Steps to Reproduce

Open the storefront
Type 'test' into the search bar
90 results found
Result 1: Pagination shows the following items "1", "2", "3", "...", "9"
Select a filter (for example Stores:Chiba)
51 results found
Result 2: Pagination shows the following items "1", "2", "3"
Select pagination item "3"
Result 3: Pagination shows the following items "1", "2", "3", "...", "6"
Remove the filter
Result 4: Pagination shows the following items "1", "2", "3", "...", "5"
Select pagination item "5"
Result 5: Pagination shows the following items "1", "...", "4", "5", "6", "...", "9"

Observed Results
The pagination items seems to be built correctly at the initial page load and after an pagination item has been clicked, but selecting or removing a filter seems to break the visible pagination items.
Expected Results

Results 1 and 5 seems ok
The other results (2 - 4) seems to be broken
-- Result 2 should also show "..." and "6"
-- Result 3 should also show "4" (in my opinion)
-- Result 4 should be "1", "2", "3", "...", "9" instead of "1", "2", "3", "...", "5"

Repository Used
https://github.com/SAP/cloud-commerce-spartacus-storefront.git

possibly fixed with #2857, repo first

The issue mentioned here has been resolved, however, improvement is still possibility as it concerns usability. Opened an improvement item #4632 to address this separately.

can't repro now, likely fixed in a previous release


pwalarmd: Init at 0.1.0

Description of changes
This patch adds pwalarmd, a daemon which provides alarm clock services with custom notification support and live command-line configuration editing (achieved through pwalarmctl, which will be requested for addition separately).
This patch does not add a service file, as pwalarmd is meant to be run in user mode. Home-Manager support will be added separately later for running pwalarmd under systemd/with declarative configuration.
Package homepage/repository: https://github.com/amyipdev/pwalarmd
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin N/A
[ ] aarch64-darwin N/A

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual) N/A

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable: N/A

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage N/A
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking N/A
[ ] (Module updates) Added a release notes entry if the change is significant N/A
[ ] (Module addition) Added a release notes entry if adding a new NixOS module N/A

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This will become a ready PR once #314794 is merged (maintainers list)

Will reopen post-merge.


Change errors to use thiserror

[ ] Change the error implementation to use thiserror crate

related: https://github.com/0xPolygonMiden/miden-node/issues/62

The main reason for why we are not using this currently is that thiserror requires std. Would would be the strategy for handling no-std context if we do switch to thiserror?

We can't do thiserror for no_std crates unfortunately. I believe the next best alternative is to use displaydoc (as explained in this thiserror thread).

Humm, I didn't know thiserror didn't support no-std. Maybe lets move everything to displaydoc?

For the future: thiserror will support no_std when std::error::Error is moved to core. nightly supports this with the feature flag #![feature(error_in_core)], and here is the tracking issue to stabilize the feature.


Events for the new signup/login flow

We should add events on the following buttons and actions -

[x] Signup (create new wallet) button
[x] Already have a wallet
[x] signed up via passwordless
[x] dont have social account?
[x] Login passwordless
[ ] Inserting the Code from the login passwordless
[x] Signup  passwordless
[ ] Inserting the Code from the signup passwordless
[ ] Back button from signup to welcome to good dollar
[ ] Back button from login to  welcome to good dollar

@Esfir-E
its not possible to catch the event of entering code when using passwordless as it is on auth0 app not ours
we dont have specific event for backbutton from screen X but we have the GOTO_WELCOME event
so you should be able to select users that did SIGNUP_SELECTED->GOTO_WELCOME which should give you users that did back button from signup
the only event that was missing is "already has wallet"

@sirpy @Esfir-E
Signup (create new wallet) button  --> GOTO_AUTH
Already has a wallet --> SIGNUP_EXISTS
signed up via passwordless  --> SIGNUP_METHOD_SELECTED
dont have social account?  --> SIGNUP_METHOD_SELECTED
Login passwordless  --> SIGNIN_METHOD_SELECTED
Inserting the Code from the login passwordless  --> it's not possible to catch
Signup passwordless  --> SIGNUP_METHOD_SELECTED
Inserting the Code from the signup passwordless  --> it's not possible to catch
Back button from signup to welcome to good dollar  -->  GOTO_WELCOME
Back button from login to welcome to good dollar  -->  GOTO_WELCOME
user tries to log in but he doesn't have a wallet  --> SIGIN_NOEXISTS_SIGNUP


Upgrade ansible to <IP_ADDRESS>

The ec2_elb_facts ansible module is broken in <IP_ADDRESS> and fixed in
<IP_ADDRESS>. Bump the ansible version.

LGTM. Since it is a patch version I'm merging it now. Remember to push new k2-tools and k2 images to quay...

@davidewatson k2-tools gets auto-built by quay.  do need to do a manual run of the k2 postcommit job for the k2 image


Missing test_data_dirs value from config

The last commit: 2e9f503 enforces the presence of an existing paths argument for the VALLEDatset class constructor.
However, I think that the constructor throws the following error at the start of training due to a missing path variable from cfg.test_data_dirs.
Traceback (most recent call last):
  File "/home/xxxxxx/miniconda3/envs/valle/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/home/xxxxxx/miniconda3/envs/valle/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/home/xxxxxx/dev/repos/vall-e/vall_e/train.py", line 130, in <module>
    main()
  File "/home/xxxxxx/dev/repos/vall-e/vall_e/train.py", line 33, in main
    train_dl, train_for_val_dl, val_dl, test_dl = create_train_val_dataloader()
  File "/home/xxxxxx/dev/repos/vall-e/vall_e/data.py", line 283, in create_train_val_dataloader
    train_dataset, val_dataset, test_dataset = create_datasets()
  File "/home/xxxxxx/dev/repos/vall-e/vall_e/data.py", line 272, in create_datasets
    test_dataset = VALLEDatset(
  File "/home/xxxxxx/dev/repos/vall-e/vall_e/data.py", line 109, in __init__
    raise ValueError("No valid path is found. ")
ValueError: No valid path is found.

What does the test_data_dirs represent in the config class?
Is this another argument we should be passing in the cli?

I have the excact same problem lol

do you know if it works with a version of the library before 2e9f503 ?

I forked this repo and removed the new code, everything is working now

Fixed https://github.com/enhuiz/vall-e/commit/d80ef1d97071b21d1a6cfe95322c3112697a99d4

In train.py, the test dataset is being evaluated with the input data. So I am thinking that there is a reason it's there.  Just not clear on why.
    def eval_fn(engines):
        run_eval(engines, "train_for_val", train_for_val_dl)
        run_eval(engines, "val", val_dl)
        run_eval(engines, "test", test_dl)

Fixed d80ef1d

Ha! Ok, thanks for the quick response!

Thank you 🙏


Running a Stacks API Node page outdated

https://docs.hiro.so/get-started/running-api-node
This page references very old docker images:
docker pull blockstack/stacks-blockchain-api && docker pull blockstack/stacks-blockchain && docker pull postgres:alpine

closing for now: we've been de-prioritizing and removing outdated content around building and running your own nodes/apis


Remove extra whitespace from  tags in DOCX

This caused extra spaces to appear within the link text in <a href> tags, resulting in display like this: __________Link_Text________
Fixes DMPRoadmap/roadmap#1185

Hi @vyruss what's the downside of having these extra spaces? If there're any, would you be so kind to add a test case that proves this?

Hi @lukelex, for us it resulted in DOCX files which exhibited this formatting for hyperlinks:

whereas removing the whitespace results in the following proper display in the exported file:

It just added the whitespaces (10 spaces before and a newline and 8 spaces after) as part of the link text. Please let me know if I can better explain this somehow.

I get your point. Can you please add a test case that covers this to avoid regretions?

@lukelex OK I believe I found what's happening here: The test case removes all whitespace with the function remove_whitespace from the test html and the generated wordml, which is why it matches - but in the real world scenario this whitespace is not removed and ends up in the wordml and therefore the exported file
https://github.com/karnov/htmltoword/blob/900892b5c48ed33ee94b819096f0a5d416034b9d/spec/spec_helper.rb#L19

You're welcome to have a simpler test case that doesn't remove whitespaces on comparisons 😉

@lukelex sorry for the delay, I just found the time to add one (see commit above)

@lukelex is this OK to merge? We'd rather switch our Gemfile to the main repo rather than my fork. Thanks!

I’ll follow up with an oficia release in the coming days.

Many thanks.


Add string cuid2() validation

cuid has been deprecated in favour of cuid2. Now it's not yet widely used but I believe it will catch up with cuid soon. This PR adds validation for cuid2.
It's my first time contributing here so please tell if I did something wrong. I did update the README with the additional method but feel free to revert the change there.

Looks great, thanks!

Great news, I've been waiting for this! Is a npm release far away?

@ciscoheat Of course I don't know when a new version will be released but if you need it immediately you can use the regex directly
const cuid2Regex = /^[a-z][a-z0-9]*$/;

Yep, I'll do that in the meantime. It's kind of amusing that a one-char id is technically possible with this one...!


Support '/' as an escaped character

According to the 1.2 spec escaped ASCII slashes are supported for JSON compatibility.

pls rebase to master and add unittests


Problem when pod install

The Podfile contains framework targets, for which the Podfile does not contain host targets (targets which embed the framework).
If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).

I downloaded the project, run pod install, got this message.  Any suggestions ?

I cannot replicate this.
Have you tried the latest version
pod 'NMessenger', '~> 1.0.79'

@mbalex99
I don't. All i did is pod 'NMessenger'

Just making sure we are on the right version

Are you using Swift 3?
Are you using the latest pod. (try 1.0.79) and then make sure you run pod repo update before you rerun pod install

@mbalex99
Yes, I am using Swift 3 and latest XCode including latest version of Cocoa
Yes, I have the latest pod version as well.

I mean I guess we can ignore it for now. I am not seeing this warning on my end...


on player unequips armor not working as expected

When using the following script, the item is not broken, however, when the players attempts to take the item off, it is removed from their inventory.
No Break:
  type: world
  events:
    on player unequips armor:
      - if <context.reason> == "BREAK" determine CANCELLED

SHOCKINGLY,
@Morphan1 's broken experimental event is broken.
@Morphan1 fixpls

It'll probably be fixed when I convert it to a ScriptEvent... One of these days 😿

@Morphan1 should do that then

https://github.com/DenizenScript/Denizen-For-Bukkit/issues/1530
https://github.com/DenizenScript/Denizen-For-Bukkit/issues/1550


environment.yml dependency

https://github.com/huge-success/sanic/blob/5cc12fd945bf4c5e0d03c0003ad1178567c70e8c/environment.yml#L21
We need to check if this dependency is still needed or if docutils already works nicely with conda et al.

This should be fixed with #1478


Clientside WASM

WASM that runs on the client, so that you can draw / render things, have clientside-only effects, etc.

This is dependent on #1, which enables code-sharing for our WIT bindings.


Ask for help

May I ask could you provide this model's paper address to me? Thank you!

You can find it in README.md now.


Add Center property to FORMS_Window

Make the window centred the next time layout() is called then set to true (and reset to false afterwards).

Implemented in fbbdbe9b81662357c66f6c4740029fe7ff8fd0a0


Group subscriver v2 configuration

I'm trying to use the group_subscriber_v2 as described in https://github.com/klarna/brod/blob/master/src/brod_group_subscriber_v2.erl#L133-L169 but couldn't do it
I'm using elixir so I basically created a map with the configurations tried to start it.
My module looks like this:
defmodule BrodSample.Consumer do
  def start() do
    group_config = [
      offset_commit_policy: :commit_to_kafka_v2,
      offset_commit_interval_seconds: 5,
      rejoin_delay_seconds: 2,
      reconnect_cool_down_seconds: 10
    ]

    config = [
      client: :kafka_client,
      group_id: "consumer_group",
      topics: ["reviews.reviews"],
      cb_module: __MODULE__,
      group_config: group_config,
      consumer_config: [begin_offset: :earliest]
    ]

    {:ok, _pid} = :brod.start_link_group_subscriber_v2(config)
  end

  def init(_arg, _arg2) do
    {:ok, []}
  end

  def handle_message(message, state) do
    IO.inspect(message, label: "message")
    IO.inspect(state, label: "state")

    {:ok, :ack, state}
  end
end

I'm also auto-starting the :kafka_client on my config file
any thoughts?

Hi! Unfortunately, I am not very familiar with Elixir, but it looks like you are creating a proplist, rather than a map (in Erlang terms). What you probably want to use is this: https://hexdocs.pm/elixir/Map.html

Hi! Unfortunately, I am not very familiar with Elixir, but it looks like you are creating a proplist, rather than a map (in Erlang terms). What you probably want to use to define config term is this: https://hexdocs.pm/elixir/Map.html

Youre right, solved the issue thanks a lot @k32