Remove accuracy from foward train

Since metric logic has been moved to dataset.evaluate, the computation of accuracy in the train forward pass is no longer needed.train

It is currently used as a metric to be logged during training, just like losses.

It is currently used as a metric to be logged during training, just like losses.

If that use case is still relevant, then maybe we should rename the metric computed on the validation dataset by EvalHook, as it is being logged with the same name ("top-N/train") messing up some mmcv logger hooks.
I personally find it confusing to compute per-batch training metrics inside the model  (unless for debugging¿?), as it is inconsistent with the behavior of other mm repositories where metrics on the validation set are computed only by the EvalHook and logged with the suffix "/train" (i.e. mIoU/train in mmsegmentation or bbox_mAP/train in mmdetection)

I understand now, it is an issue with the logger hook incorrectly handling the runner.mode


made coef.squeeze in fracridge less eager

Fixes issue https://github.com/nrdg/fracridge/issues/39

Thanks for doing this! Would you please add a test for this functionality?

OK - I see that we have thought about this before, which is why have the failing test in place: https://github.com/nrdg/fracridge/runs/5379314227?check_suite_focus=true#step:6:34. I think that the issue is that if you do fitting followed by prediction, you want to end up with the same shape of y as the one that you originally put in, and this change would break that.

test_FracRidge_singleton_frac seems to fail because of an unrelated problem:
X in test_FracRidge_singleton_frac has the shape (2,1). This triggers the unnecessary expansion of FracRidgeRegressor.coef_ from (1,) to (1,1) in FracRidgeRegressor.predict() (the second condition below):
https://github.com/nrdg/fracridge/blob/1ac49cae092cca3efa083451808c26989d17a3b5/fracridge/fracridge.py#L322
What case X.shape[-1] == 1 is supposed to catch?

Oh - I think it's related to this use-case: #25

I believe this can be merged (and I can cut a new release after we merge). Do you want to add one more test to address the use-case you explained in #39, so that we make sure that we covered that and also don't break it in the future?

I can try. What's the logic of this test?
https://github.com/nrdg/fracridge/blob/1ac49cae092cca3efa083451808c26989d17a3b5/fracridge/tests/test_fracridge.py#L157
Why does the last column match the OLS prediction? Isn't it related to the biggest ridge penalty?

Fractions and ridge penalty are inversely related. This is the column associated with a fraction of 1.0, which is the smallest ridge penalty (and should be identical to OLS).

there are actually still some problems even with my pull request. If we allow for squeezing both f and b, (fraction and target number), it becomes difficult down the road to discriminate between a (p,b) and a (p,f) coef_. Perhaps the best design choice is to leave coef_ always shaped as (p,f,b), and adapt .predict to the dimensionality of X?

So perhaps coef_ should be either (p,f) or (p,f,b), depending on whether the original y was a vector or a matrix.

Yes: I think that would be fine. We'd need to store the information about the original dimensionality of y and then b is either y.shape[-1] or is eliminated, right?
BTW: IIUC, this all doesn't apply to the Matlab implementation, because you can't have a true 1-dimensional vector in Matlab, that doesn't carry a singleton dimension. I would really hesitate to require that all y inputs be 2-dimensional here, because that would look quite unusual to most sklearn/numpy users.

It depends. Can you explain what is going here?
https://github.com/nrdg/fracridge/blob/1ac49cae092cca3efa083451808c26989d17a3b5/fracridge/fracridge.py#L334-L342
Why do we have this condition? len(self.coef_.shape) <= 2
And why a singleton first dimension is treated differently? (X_offset.shape[0] == 1)

Thanks for your work on this @Tal-Golan !


identify: check shebang of all text files

There are cases where shell scripts (and other scripts) may not be executable but still need to be checked.

Remove early os.access() check which will return (never get to shebang check) for shell scripts that are not executable
Check that a file is text first and then attempt to parse the shebang

Signed-off-by: Matthew Weber<EMAIL_ADDRESS>

in the future please search existing issues and start with an issue

I didn't see an existing issue that matched this.  Are you suggesting I open a ticket and describe the issue/reference my patch?

yes, but don't bother because this patch will not be accepted -- shebangs only have an effect if a file is executable and the implementation is intentional to that -- it should have been fairly obvious when you had a failing test demonstrating exactly that behaviour


Snapshot-test extendr macros expansions

Test generated code
Visualize expansion for reference
???

Blocked by https://github.com/dtolnay/install/issues/12. If it will not be resolved by the author/us, I will switch to just cargo install cmd.

Dayum, snapshot tests are disabled by default on CRAN so they were not executed here >_<. I was debugging unreachable code on CI

Wait, what's wrong with nzchar? I did not get it

nchar takes a character vector as an argument and returns a vector whose elements contain the sizes of the corresponding elements of x.
but it returns boolean/logical.

Ah, but there are two functions. nchar counts characters, and nzchar (I read it as non-zero characters) just tells us if string is not empty.


Added --without-hashes to poetry export in Dockerfile.

docker build wouldn't work, it said:
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==.
poetry export --without-hashes removed the error.
See discussion here:
Poetry fails in CI/CD with ERROR

Pawel suggested this as an alternative:
rm poetry.lock
poetry lock
poetry install

and then push to master


Disable SSL Mode for lookup table Postgres

I am getting this error when using a lookup table:
level=info msg="sink result for rule ruleLookup: {"error":"pq: SSL is not enabled on the server"}"
How can I disable SSLMode for the postgresql source?

Just in case someone runs into this, this is how I solved this
postgres://:******@postgresql:5432/database?sslmode=disable

Solved


Pull To Refresh UIRefreshControl not push the content while updating

Expected Behavior
While the scrollview refreshing the content should be stay under the UIRefreshControl view
Actual Behavior
The content go back to the original place and the loading screen is on the content
Specifications

Xcode version: 9.2
iOS version: iOS10
Dependency manager + version: CocoaPods

The SpreadSheetView has the public scrollView variable which is an UIScrollView and it has a built-in UIRefreshControl.
let refreshControl = UIRefreshControl()
    let title = NSLocalizedString(R.string.localizable.mainCheckingforupdate(), comment: R.string.localizable.mainCheckingforupdate())
    refreshControl.attributedTitle = NSAttributedString(string: title)
    refreshControl.addTarget(self,
                             action: #selector(self.refreshOptions(sender:)),
                             for: .valueChanged)
    view.spreadSheetView.scrollView.refreshControl = refreshControl

The Pull to Refresh feature works perfectly with it but the UIRefreshControl view not push out the content like this:

Thank you for your help!


[MXNET-627] Fix Installation instructions for R bindings on Linux systems.

Fix for https://github.com/apache/incubator-mxnet/issues/8240 https://github.com/apache/incubator-mxnet/issues/10147 https://github.com/apache/incubator-mxnet/issues/8869
Preview of the website -  http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-11590/$BUILD_NUM/index.html
@hetong007 @aaronmarkham @ankkhedia

Follow these directions to setup a test server and build the docs. Test the selector to make sure content shows up when you click on the different install options.
https://github.com/apache/incubator-mxnet/blob/master/docs/build_version_doc/README.md#setting-up-a-docs-dev-server

@aaronmarkham It does show here correctly - http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/install/index.html?platform=Linux&language=R&processor=CPU

So it looks like we have duplicated information on the install.md page and each of the $OS_setup.md pages. Also, when you use the install page's selector, you get instructions, but no link to the $OS_setup page.
Wouldn't it be better to provide the minimum info needed on the install page, and leave the detail for the OS specific pages?

@aaronmarkham you have been added as a collaborator to my repo. Please make the required changes and push to this branch. Thanks!

I went ahead and resolved an issue with using the CI scripts as part of the installation instructions for Ubuntu and made a new script for core and python deps. I also made an R installation script.
The instructions are generally simplified now by having access to the two new shell scripts.
install_mxnet_ubuntu_python.sh

It checks for nvidia-smi and sets the make flags accordingly, so now we don't have doubled up instructions.
I moved the pip installs to a central requirements.txt so that's not duplicated anymore.
It uses sudo in the pip upgrade step - I didn't find a way around this.

install_mxnet_ubuntu_r.sh

The R deps are now in alignment - I updated CI for R to match.

@hetong007 I updated the install page for OSX and Windows to point to the detailed instructions pages. OSX should be good to go now. Windows is being worked on in a separate PR by @ankkhedia. Please revisit your change request since further updates on Windows instructions is out of scope for this PR.


catimages: Clean up code

Remove dead code
Remove invalid comments
Use simpler functions
Use pywikibot core's generator
General clean up

Do we really need to clean this up so well ?

Got the JPEG branch of catimages working (Without the jseg part) on the ajk/archive branch
https://github.com/AbdealiJK/file-metadata/tree/ajk/archive

Closing as this is cleaned and large parts are working (atleast locally for me)


Migrate 0.7.2 to cosmos-sdk goz-phase-3

Resolves #127
Reviewer note
The --validate-signatures is not supported anymore in cli_test.go so I replaced failing tests with the matching ones from https://github.com/cosmos/cosmos-sdk/blob/goz-phase-3/x/auth/client/cli/cli_test.go

For admin use:

[ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
[ ] Reviewers assigned
[ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Codecov Report

Merging #132 into update-gaia will increase coverage by 0.05%.
The diff coverage is 93.75%.

@@               Coverage Diff               @@
##           update-gaia     #132      +/-   ##
===============================================
+ Coverage        30.88%   30.93%   +0.05%
===============================================
  Files               20       21       +1
  Lines             2678     2686       +8
===============================================
+ Hits               827      831       +4
- Misses            1776     1780       +4
  Partials            75       75

Impacted Files
Coverage Δ

app/genesis.go
0.00% <0.00%> (ø)

lcd_test/helpers.go
74.45% <ø> (-1.46%)
:arrow_down:

x/wasm/types/codec.go
100.00% <ø> (ø)

app/app.go
93.22% <100.00%> (-0.04%)
:arrow_down:

app/codec.go
100.00% <100.00%> (ø)

x/wasm/keeper/test_common.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015802e...20bd2c9. Read the comment docs.

One note... this seems to close #128 not #127
(you are updating the sdk, not merging v0.8 into this)


Checkbox style error when disabled and checked

Should not have black border when checked and disabled

how do you get it working ? can you paste the full code please

@TanTan-TT perhaps changing this line to
fill: 'transparent',

addresses this issue. Please test, and if you could, submit a PR :)

@mbrookes if this was fixed with #3432 can you close it?

Thanks!


[Flaky Test] tests/python/contrib/test_ethosu/cascader/test_scheduler.py::test_compute_cycles_annotation

These tests were found to be flaky (intermittently failing on main or failed in a PR with unrelated changes). See the docs for details.
Tests(s)

tests/python/contrib/test_ethosu/cascader/test_scheduler.py::test_compute_cycles_annotation

Jenkins Links

https://ci.tlcpack.ai/job/tvm/job/PR-11298/11/display/redirect

This is disabled in https://github.com/apache/tvm/pull/11478

Thanks for reporting @shingjan, cc @ekalda @manupa-arm @NicolaLancellotti for visibility


Renaming a folder prevents saving already opened files

One small issue: after renaming a folder, its contained files opened before the renaming cannot be saved. One way around it is to copy the file content somewhere, close the file and "discard changes", and re-open that file and paste the changed content back.
Steps to Reproduce

Have some files opened in the editor.
In the workspace browser, right-click on the folder these files are contained it, and choose to rename it.
After renaming the folder, make changes in the opened files and try to save them.

Environment

Info
Details

Light Table version
0.8.1 (binary version: (0.34.5)

Operating system
Ubuntu 16.04

Error Messages
Invalid behavior: :lt.objs.editor.file/file-save

@tomtau Thanks for the report. Unfortunately, this is not likely to be fixed anytime soon, if ever; at least not given current and recent levels of activity. That said, this may not be hard to 'fix' so if anyone's interested in working on it just ping me here or on Gitter and I'll be glad to help however I can.
I'm going to close this for now. When or if someone wants to work on it, I'll re-open.

@kenny-evitt It shouldn't be too difficult to fix, I can give it a go.

@tomtau Great! Ping me here or in the Gitter room if you have any questions or need any other help.

@kenny-evitt https://github.com/LightTable/LightTable/pull/2233


AFK feature

A user should be able to set an AFK message eg:
"!afk Out on a walk, DM if important"
If a user is tagged in a channel while marked as AFK, Horace should post their AFK message.
If the user posts a message while AFK, they should be prompted by the bot if they want to remove their AFK status (should be confirmed by reacting to the bots message either a confirm (check mark) or deny (cross) emoji.
It would be preferable that the bot automatically reacts to its "remove afk" confirmation message with the two emojis, so the user will only have to click one of them to confirm.
After a user reacts to a confirmation message, the message from the bot should be removed.
Example from the previous version:

Update on this: I have started work and I am able to successfully mark someone as AFK, as well as remove that status.
I can see I have not been assigned to this issue yet. Is that a possible?


feat: added redirects and fixes with server

Added and handled redirects
Integrated with server and checked server with frontend
Modified configuration to pass bearer token as header

Codecov Report

Merging #31 (cea5596) into main (9a2b297) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            2         2
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a2b297...cea5596. Read the comment docs.


Rendering components in the iframe doesn't work

I tried to render components in the iframe resizer, but it did not work. Basically I'm trying to get "HELLO" to appear in the frame
import React, { Component } from "react";
import { createPortal } from "react-dom";
import IframeResizer from "iframe-resizer-react";
export class IFrame extends Component {
  constructor(props) {
    super(props);
    this.state = {
      mountNode: null,
    };
    this.setContentRef = (contentRef) => {
      this.setState({
        mountNode: contentRef?.contentWindow?.document?.body,
      });
    };
  }

  render() {
    const { children, ...props } = this.props;
    const { mountNode } = this.state;
    return (
      <IframeResizer
        {...props}
        ref={this.setContentRef}
        log
        style={{ width: "1px", minWidth: "100%" }}
      >
        {mountNode && createPortal(children, mountNode)}
      </IframeResizer>
    );
  }
}

In another component I rendered "HELLO" in that IFrame

        <ThemeProvider theme={theme}>
          <Provider store={store}>
            <PersistGate loading={null} persistor={persistor}>
              <AllApp />

HELLO

            </PersistGate>
          </Provider>
        </ThemeProvider>

Didn't work! I didn't see HELLO

`

It expects the iframe to be in a different file and linked via src.


Qtum Address is not valid osx Qt wallet

I use the mac os Qtum qt wallet. (qtum-0.14.3-osx-unsigned)
After i try to change coins with changelly i get the message Address is not valid.
i use some qt wallet generated address, but it dosent work.
same on shapeshift.
someone can try QN36yx7Tar1aRBPKuRMncctMhpnzv7QHDi

Same here

Works for me
validateaddress QN36yx7Tar1aRBPKuRMncctMhpnzv7QHDi
{
  "isvalid": true,
  "address": "QN36yx7Tar1aRBPKuRMncctMhpnzv7QHDi",
  "scriptPubKey": "76a9140fb8432b6411b2a9aa4c02a3e669dfdc23da2a4d88ac",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false
}

Could anyone try mine, too?
QT6n1wsko3fhZWq7yuGudpyTAsKRC5oakU


ERR_PACKAGE_PATH_NOT_EXPORTED

I ran yarn start after running yarn like here https://www.carbondesignsystem.com/developing/react-tutorial/step-1 and I get this error code:
 % yarn start
node:internal/modules/cjs/loader:488
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/tokenize' is not defined by "exports" in /Users/v3g4/WebstormProjects/carbon-tutorial/node_modules/postcss-safe-parser/node_modules/postcss/package.json
    at new NodeError (node:internal/errors:371:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:429:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:683:3)
    at resolveExports (node:internal/modules/cjs/loader:482:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:522:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/v3g4/WebstormProjects/carbon-tutorial/node_modules/postcss-safe-parser/lib/safe-parser.js:1:17) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

Node.js v17.3.1

Downgrade  node to version 16
sudo npm install -g n
sudo n stable


Call Home function issue

Hi,
In netopeer2-server i have enable the call Home function and set the client IP and default port is 4334.
SERVER="<netconf-server xmlns=\"urn:ietf:params:xml:ns:yang:ietf-netconf-server\">
    <call-home>
        <netconf-client>
            <name>default-client</name>
            <endpoints>
                <endpoint>
                    <name>default-ssh</name>
                    <ssh>
                        <tcp-client-parameters>
                            <remote-address><IP_ADDRESS></remote-address>
                            <keepalives>
                                <idle-time>1</idle-time>
                                <max-probes>10</max-probes>
                                <probe-interval>5</probe-interval>
                            </keepalives>
                        </tcp-client-parameters>
                        <ssh-server-parameters>
                            <server-identity>
                                <host-key>
                                    <name>default-key</name>
                                    <public-key>
                                        <keystore-reference>genkey</keystore-reference>
                                    </public-key>
                                </host-key>
                            </server-identity>
                            <client-authentication>
                                <supported-authentication-methods>
                                    <publickey/>
                                    <passsword/>
                                    <other>interactive</other>
                                </supported-authentication-methods>
                                <users/>
                            </client-authentication>
                        </ssh-server-parameters>
                    </ssh>
                </endpoint>
            </endpoints>
            <connection-type>
                <persistent/>
            </connection-type>
        </netconf-client>
    </call-home>
</netconf-server>"

After starting the netopeer2-server, it try to connect the Client IP : 4334 .
In client setup :: I need to fill this filled ::  name, IP ,Port ,userid ,password.
Here client and server are in different IP and also login credentials are different.
Now i need to connect the client to server.
In client i have give name :: Test ,IP :: client IP , port :: 4334 , userid and password ::  Client setup
when i disable call home and enable SSH only i am able to connect successfully the client with server on port 830.
when i enable call home and disable SSH ,i am try to connect now but the connection is getting refused on port 4334.
1)Client port is different that 4334.while making connection i need to set client port on server instead of 4334?
2)For call home function i need to set any authentication key of client or credentials on server for connecting or validation ?

Hi,
I am somewhat confused as to what exactly is the issue and what is your setup. I do not know what client are you using but you must set it up to listen instead of connect when using Call Home so that the server can connect to it. And whatever port the client will listen on, that is the port that needs to be set in the server Call Home configuration. As for authentication, that will occur in the standard way meaning you do not have to do any additional steps for Call Home authentication.
Regards,
Michal

Hi,
Is there any software that it can covert the yang model into the xml struture .
Can you please provide the link.

Hi,
pyang should be able to do this, the feature
Generate a skeleton XML instance document from the data model.

Regards,
Michal

Hi,
Once we perform some edit-config operation and set some parameter values into the yang model from netopeer-cli. where this parameter will be store in the server in which path ?
After connecting the server and client through hello message capability will get exchange.
we need to keep the yang model of both in server and client ?
How client will know that this yang model is have which attributes inside it like different container , leaf , leaf list etc ?

Hi,
I do not really understand the first question, are you asking where the server stores its data? If so, then in binary files either as shared memory files (/dev/shm) or standard files (repository/data).
As for client-side YANG modules, by default they are retrieved from the server so you do not have to worry about that at all. If that is not supported/fails, they are loaded locally from specific directories as configured.
Regards,
Michal


Getting error for SortedMulti while parsing descriptor

While parsing descriptor which uses SortedMulti function as shown ->

  let a=Descriptor::<DescriptorPublicKey>::parse_descriptor(&secp, "sortedmulti(2,03acd484e2f0c7f65309ad178a9f559abde09796974c57e714c35f110dfc27ccbe,022f01e5e15cca351daff3843fb70f3c2f0a1bdd05e5af888a67784ef3e10a2a01)").unwrap();

I am getting this error->
called `Result::unwrap()` on an `Err` value: Unexpected("sortedmulti(3 args) while parsing Miniscript")

After some search -> I found that this error is comming from
https://github.com/rust-bitcoin/rust-miniscript/blob/9e1b3cdf7e38563f4f2e7c2832a994f4c91a5e36/src/miniscript/astelem.rs#L317

Well, I guess sortedmulti_a is not yet supported in miniscript?

sortedmulti needs to be wrapped in a top-level descriptor type like wsh.
And no, looks like we don't have sortedmulti_a support yet.


Added top 1m Alexa domains

Added the top alexa domains. replaced periods with dashes for easy AWS bucket hunting.

Thank you!


Do not snappy encode if record is too large

Snappy cannot encode records larger than ~3.7 GB and will panic if an
encoding is attempted. Check to make sure that the record is smaller
than this before encoding.
In the future, we could improve this behavior to still compress large
records (or break them up into smaller records), but this avoids the
panic for users with very large single scrape targets.
Fixes: #8762

Yes we can, the compression is toggled in the header of each record.


metadata.json changed to contain absolute path to training_data.json

Rasa version: 1.0.9
Python version: 3.7.3
Operating system (windows, osx, ...): osx
Issue:
After training, metadata.json has an absolute path to training_data.json in the training_data attribute, e.g. /Users/gthb/git/rasaproject/.../training_data.json.
This path used to be relative to the model directory, matching what's described in https://github.com/RasaHQ/rasa/blob/master/docs/nlu/old-nlu-migration-guide.rst “All paths are now relative with respect to the path specified in the configuration during training and loading”.
The regression happened in https://github.com/RasaHQ/rasa/commit/194d449bbaca8f7bbbca2e561309b064e6d6d3dd because data_file is always an absolute path, coming out of data_file = os.path.join(dir_name, filename), and that dir_name comes from https://github.com/RasaHQ/rasa/blob/6c9a3202c04b18440e47cb952b588637e5d0edf1/rasa/nlu/model.py#L222
        path = os.path.abspath(path)
        dir_name = os.path.join(path, model_name)

Error (including full traceback):
N/A
Command or request that led to error:
$ rasa init --no-prompt
$ tar -xOzf models/*.tar.gz nlu/metadata.json | grep training_data

Before commit 194d449bba that yields:
    "training_data": "training_data.json",

whereas at and after that commit, it yields something like:
    "training_data": "/var/folders/_g/f_zc9wdj6vqcbsk1h62bwxmd9xsbxj/T/tmptz08li2n/nlu/training_data.json",

In a real usage scenario (not rasa init), that path will be a real absolute path into somebody's project directory, with username etc.

Do you mind creating a PR changing the path before we add it to the metadata?

Do you mind creating a PR changing the path before we add it to the metadata?

Done ⬆  (and just got the go-ahead for the CLA, so we're good.)


Remove Column, make it a mixin, add IColumn

Needs array redirects from mixin (work in progress at the time of writing this), this should make updates easier and make sponge compatibility easier.

[x] Make the column mixin and remove Column class
[x] (mostly untested) Get lighting working again
[ ] Fix minor bugs

[x] Issues with loading and saving entities entities
[x] Investigate possible issues related to using isChunkLoaded flag from Chunk instead of Cube Fixed

[ ] Test to find more issues, clean up the code

Closed by ccfd8af20c757bc53315c03d21c3107d7075b3cf


restore lost argument "NoProfile" in encoded command

Issue
The NoProfile argument is lost in the encoded pwsh command.
If there is a system profile on the computer "C:\Program Files\PowerShell\7\profile.ps1", it is read and executed

Hey @sawfriendship
Thanks so much for your interest in contributing! Please note, this github repository is a read-only clone of our repository at https://gitlab.com/gitlab-org/gitlab-runner. It would be great if you could open up a Merge request there 😁
I'm going to close this PR, we look forward to seeing you on gitlab.com


[BUG]: https://local.drizzle.studio/ in frozen state,

What version of drizzle-orm are you using?
0.30.2
What version of drizzle-kit are you using?
0.20.14
Describe the Bug
https://local.drizzle.studio/ does not oped the and display anything, on firefox its just a black screen, on brave (chrome-based) , it just shows the 'Welcome to Drizzle studio , Connecting to the Drizzle Kit on localhost:4983'
here are some stacks copied from web, this could be a problem on my end but the app is running smooth ,
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://static.cloudflareinsights.com/beacon.min.js/v84a3a4012de94ce1a686ba8c167c359c1696973893317. (Reason: CORS request did not succeed). Status code: (null).
None of the “sha512” hashes in the integrity attribute match the content of the subresource. The computed hash is “z4PhNX7vuL3xVChQ1m2AB9Yg5AULVxXcg/SpIdNs6c5H0NE8XYXysP+DGNKHfuwvY7kxvUdBeoGlODJ6+SfaPg==”. local.drizzle.studio
Error: Parse error: Unexpected "{
" at line 2 column 17
createParseError https://local.drizzle.studio/index.js:297
tokenize https://local.drizzle.studio/index.js:297
tokenize https://local.drizzle.studio/index.js:297
r https://local.drizzle.studio/index.js:308
reset https://local.drizzle.studio/index.js:308
feed https://local.drizzle.studio/index.js:305
parse https://local.drizzle.studio/index.js:308
parse https://local.drizzle.studio/index.js:314
format https://local.drizzle.studio/index.js:314
XAn https://local.drizzle.studio/index.js:315
yCe https://local.drizzle.studio/index.js:315
Ift https://local.drizzle.studio/index.js:322
Oee https://local.drizzle.studio/index.js:72
IM https://local.drizzle.studio/index.js:72
hGt https://local.drizzle.studio/index.js:72
I4 https://local.drizzle.studio/index.js:72
PJe https://local.drizzle.studio/index.js:72
Ik https://local.drizzle.studio/index.js:70
ob https://local.drizzle.studio/index.js:72
ob https://local.drizzle.studio/index.js:72
y2 https://local.drizzle.studio/index.js:72
qGe https://local.drizzle.studio/index.js:70
Ge https://local.drizzle.studio/index.js:70
s https://local.drizzle.studio/index.js:88
s https://local.drizzle.studio/index.js:88
I https://local.drizzle.studio/index.js:72
setState https://local.drizzle.studio/index.js:72
setCurrentSchema https://local.drizzle.studio/index.js:88
setQueryEngineCreation https://local.drizzle.studio/index.js:88
index.js:22:193
QUt https://local.drizzle.studio/index.js:22
B1e https://local.drizzle.studio/index.js:72
callback https://local.drizzle.studio/index.js:72
OGe https://local.drizzle.studio/index.js:70
wJe https://local.drizzle.studio/index.js:72
NJe https://local.drizzle.studio/index.js:72
dGt https://local.drizzle.studio/index.js:72
hGt https://local.drizzle.studio/index.js:72
I4 https://local.drizzle.studio/index.js:72
PJe https://local.drizzle.studio/index.js:72
Ik https://local.drizzle.studio/index.js:70
ob https://local.drizzle.studio/index.js:72
(Async: VoidFunction)
ob https://local.drizzle.studio/index.js:72
y2 https://local.drizzle.studio/index.js:72
qGe https://local.drizzle.studio/index.js:70
Ge https://local.drizzle.studio/index.js:70
s https://local.drizzle.studio/index.js:88
s https://local.drizzle.studio/index.js:88
I https://local.drizzle.studio/index.js:72
setState https://local.drizzle.studio/index.js:72
setCurrentSchema https://local.drizzle.studio/index.js:88
setQueryEngineCreation https://local.drizzle.studio/index.js:88
Uncaught Error: Parse error: Unexpected "{
" at line 2 column 17
createParseError https://local.drizzle.studio/index.js:297
tokenize https://local.drizzle.studio/index.js:297
tokenize https://local.drizzle.studio/index.js:297
r https://local.drizzle.studio/index.js:308
reset https://local.drizzle.studio/index.js:308
feed https://local.drizzle.studio/index.js:305
parse https://local.drizzle.studio/index.js:308
parse https://local.drizzle.studio/index.js:314
format https://local.drizzle.studio/index.js:314
XAn https://local.drizzle.studio/index.js:315
yCe https://local.drizzle.studio/index.js:315
Ift https://local.drizzle.studio/index.js:322
Oee https://local.drizzle.studio/index.js:72
IM https://local.drizzle.studio/index.js:72
hGt https://local.drizzle.studio/index.js:72
I4 https://local.drizzle.studio/index.js:72
PJe https://local.drizzle.studio/index.js:72
Ik https://local.drizzle.studio/index.js:70
ob https://local.drizzle.studio/index.js:72
ob https://local.drizzle.studio/index.js:72
y2 https://local.drizzle.studio/index.js:72
qGe https://local.drizzle.studio/index.js:70
Ge https://local.drizzle.studio/index.js:70
s https://local.drizzle.studio/index.js:88
s https://local.drizzle.studio/index.js:88
I https://local.drizzle.studio/index.js:72
setState https://local.drizzle.studio/index.js:72
setCurrentSchema https://local.drizzle.studio/index.js:88
setQueryEngineCreation https://local.drizzle.studio/index.js:88
index.js:297:2338
Expected behavior
No response
Environment & setup
on mac softw up to date

Same problem, not sure what it is
https://local.drizzle.studio/ does not oped the and display anything, on firefox its just a black screen, on brave (chrome-based) , it just shows the 'Welcome  to Drizzle studio , Connecting to the Drizzle Kit on localhost:4983'


Clamp return value of SceneTreeTimer::get_time_left to 0.0

This changes alters SceneTreeTimer::get_time_left to clamp to zero when negative, to match the behavior of Timer::get_time_left. Timer sets time_left to negative in certain circumstances (i.e. stopping the timer), but get_time_left always returns positive values (or zero). This fix assumes that the SceneTreeTimer and Timer APIs are intended to be orthogonal.
Fixes #73607

Thanks!


Register Time

@JuliaRegistrator register

Error while trying to register: "Tag with name v0.1.0 already exists and points to a different commit"

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/89999
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.1 -m "<description of version>" 5001ab0e2f3a0c37de2058200ccb1dddc73c5051
git push origin v0.1.1

Also, note the warning: This looks like a new registration that registers version 0.1.1.
Ideally, you should register an initial release with 0.0.1, 0.1.0 or 1.0.0 version numbers
This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

@JuliaRegistrator register(

Registration pull request created: JuliaRegistries/General/90038
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" bfb40675d210e5e73faf3335965680987a8f254e
git push origin v0.1.0

Docs changes
@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/90038
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" f1461605e9097a5c34a294e5d14e3e8e5ed6b233
git push origin v0.1.0

Package is registered!
] add PrefectInterfaces

Resolving/


Add separate page for request template variables and add the new ticket message id variable

see https://github.com/SuperOfficeDocs/superoffice-docs/issues/671
Not sure how to handle that ticket message id is only available starting in 10.2.5?

This is a very nice suggestion! 👍

@acdavidh Where did your thoughts about  come from? I don't find that in the TemplateVariable source anywhere...

@acdavidh Where did your thoughts about come from? I don't find that in the TemplateVariable source anywhere...

I got the miid variable from a comment on my wish
https://community.superoffice.com/nl/product-releases/bugs-wishes/product-issue/?bid=38924&azure=1

@acdavidh OK, thanks! After a bit of digging, looks like it's only going to be available in web panel URLs (via SCIL) and not the standard TemplateVariable parsing routines... :-(
I'll annotate that in the docs.

@acdavidh OK, thanks! After a bit of digging, looks like it's only going to be available in web panel URLs (via SCIL) and not the standard TemplateVariable parsing routines... :-(
I'll annotate that in the docs.

Thanks for the clarification, that's a shame! hopefully now the the merging of service and crm additionele template variables will be made available for request/ticket and ticket message


Touch support

This PR adds generic touch support for modal, toolbar and structureboard drag and drop
touch support is not good enough everywhere yet, mostly because some things are very heavily hover based, but that will change soon.
Also fixes few bugs with drag n drop to empty placeholder and general jumping of the structureboard.
Also fixes annoying scrolling bug when you start dragging a plugin on a long page and it immediately scrolls all the way to the bottom
PR also contains style changes, at the moment it looks like this

Keep in mind that this PR is pointing to preview branch and not components are completely ready yet.

thanks for the updates :+1:


Blog post on history of Service Weaver's core API.

Thanks Sanjay! We'll release this blog post in a couple of weeks, closer to Robert's GopherCon talk.


[Tracking Issue] Add script function support to the Diem Framework

Now that we have script functions we want to support them in the Diem Framework, and use them to define the set of allowed transactions in the system. The conversion over to this can be broken up (roughly) into the following steps:

[x] Add support for ABI generation and documentation generation with script functions Merged: #7844
[x] Add support for script functions in the transaction builder code generation. Tracking issue: #7876, PR: #7885 Merged
[x] Convert the current set of transaction scripts over to script functions PR: #7948 Merged
[x] Add support for script functions to json-rpc Addressed in #7885 as well
[ ] Add backwards compatibility mapping from the current set of transaction scripts to the new script functions defined in (3).

@tzakian Is this done now?

Yep! Closing now


fix(version): update fabric8-stack-analysis-ui to 0.0.11

There were the following issues with your Pull Request

Commit: 6a67c9ddde6ef7ad64b27cb5039036a814227ebf
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com


missing prior selection criteria for semiologies in database

SS, CS and ET - missing values need inserting, otherwise these data are not utilised in queries

needs a test


ci: Work around msedgedriver 115+ bug

Specify the explicit path to microsoft-edge on Linux if found, to work around https://github.com/MicrosoftEdge/EdgeWebDriver/issues/102#issuecomment-1710724173
This also incorporates
https://github.com/shaka-project/webdriver-installer/pull/35 and https://github.com/shaka-project/karma-local-wd-launcher/pull/60 to revert earlier workarounds and apply new ones for local test runs.

Oops, this isn't working yet.  I seem to have a platform-specific exception in karma-local-wd-launcher.

Fix in https://github.com/shaka-project/karma-local-wd-launcher/pull/62


common_sensors: 0.1.0-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository common_sensors to 0.1.0-0:

upstream repository: https://github.com/JenniferBuehler/common-sensors.git
release repository: https://github.com/JenniferBuehler/common-sensors-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: null

common_sensors
* Added sources to repository
* Contributors: Jennifer Buehler

This package looks like a great resource and the cleanup will be valuable to the community. However the name choice is too generic for our naming convention, falling into the catchall category. http://wiki.ros.org/ROS/Patterns/Conventions and http://www.ros.org/reps/rep-0144.html
For the meshes etc I would suggest that according to the REP each sensor should get a package <SENSOR_NAME>_description. And although it's a bit more of a pain, coupling these sensors into a single repository is probably not the best idea since the repository is the unit of release and consequently you're tying the releases of updates for any specific sensor to all the other sensors.
And for the laser filters if they're generic and useful I'd suggest submitting them to be reviewed and added to the laser_filters package http://wiki.ros.org/laser_filters

Hi Tully,
thanks for the feedback! It's great to see that packages submitted to ROS get a proper review.
I agree about the naming. I was pondering about which name to choose for a while. Because this package essentially aims at collecting the most commonly used sensors, I stuck to "common sensors" in the end. But the problem with this over time is also: which sensor classifies as "common" to make it into such a package? So I've kept thinking and the only other idea I had so far is "sensors_collection".
As to the separation into several packages: My original aim of creating this package was that I didn't want to always end up having many external package dependencies (to urdf, gazebo, filters, etc.) just because of a couple of very common sensors I am using. I just wanted one package with all common sensors (which we had in the lab and are very common). I'm sure there are other people who would like that. However I agree that it would be nicer to have individual packages, e.g. hokuyo_description, xtion_description, etc. But it would still be nice if only one package would need installing, which could then be a meta package which includes all the commonly sensors. What do you think about that?
I see what you mean with the issue of having all of the packages in the same repository. On the other hand, I wouldn't expect updates on any of the packages to happen super frequently. And the packages are not that big, so does it still make sense to have a dedicated repository for just a couple of URDF files?
Yes, I'll see if it's possible to get the laser filters into the ROS package you mentioned. However because it's largely based on code from uni Texas, it should maybe be them to do it. I just wanted to add the code here for convenience (and for not needing yet another package dependency).
I can email them and ask what they think about that.
Long story short: this package is not of high priority for my other packages which I'll be submitting in the next few days (from my git repos). It's only an optional runtime dependency (when using certain launch files). I wanted to use this package as a "practise run" for submitting a package with bloom. So I can start working on all the changes you suggested over time and then re-submit this PR.

Hi Jennifer,
We do our best to review package submissions. Naming is something that we have the most visibility into.
If you'd like to create a metapackage to bring in all the resources you'd like to have for your project that would be fine. Just use an appropriate prefix so that others would understand the scope.
As a test run, this looks like a success. Obviously we didn't try building it yet, but you made it all the way through the release process and submitted a well formed pull request.
I'll close this now and you can open new pull request for your upcoming package releases.


Remove race condition between removing runner and GitHub assigning work to the runner.

Enhancement Proposal
This can only happen when the number of runner is reduced via configuration, so this should be rare.
The way to resolve this will involve the GitHub runner binary having an atomic operation that checking if the runner is currently busy and remove/unregister from GitHub if not busy.
There is two way to remove/unregister a runner, one method is executing the runner binary, the other is calling a RESTful API on GitHub. From the documentation is it unclear how these two method interacts with the runner being busy.

I think this is issue is no longer valid, can you check @yhaliaw and close, please?


Partial migration to single quotes

This PR performs a partial migration of the src and extras folders to standardize on single quotes (in preference to double quotes). This represents 344 occurrences of double quotes. This PR excludes src/framework, src/graphics, src/resources and src/scene for now. Instead, this migration will be done in phases to minimize the impact of anyone working on PRs in those folders.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

What do you think about doing this for JSDoc types aswell? For example:
    /**
     * Add Attribute.
     *
     * @param {string} name - Name of an attribute.
     * @param {object} args - Object with Arguments for an attribute.
     * @param {("boolean"|"number"|"string"|"json"|"asset"|"entity"|"rgb"|"rgba"|"vec2"|"vec3"|"vec4"|"curve")} args.type - Type
     */

Could be:
    /**
     * Add Attribute.
     *
     * @param {string} name - Name of an attribute.
     * @param {object} args - Object with Arguments for an attribute.
     * @param {'boolean'|'number'|'string'|'json'|'asset'|'entity'|'rgb'|'rgba'|'vec2'|'vec3'|'vec4'|'curve'} args.type - Type
     */

I also don't know the reason for the extra brackets around the unions, imo it would look way cleaner without them.
Simple query to find all cases in any IDE using file search: "|"


No card type configured

Not sure what's going on here, but I can't get this card to load. I have other custom cards loaded without issue.

home-assistant-frontend==20190626.0
homeassistant==0.95.4
<EMAIL_ADDRESS>Firefox 68 and latest Chrome

The manual card I added:
      - type: custom:roku-card
        entity: media_player.tv
        name: TV
        tv: true
        power:
          service: switch.turn_on
          service_data:
            entity_id: switch.tv

In the ui-lovelace.yaml, along with other custom module script resources:
  - type: module
    url: /local/roku-card.js?v=0

I have verified that https://<my domain>/local/roku-card.js is accessible and is returning the JS. In the FF console, I can also see that the element has been loaded:
> customElements.get("roku-card")
function RokuCard()

No other errors are shown. Same problem in Chrome and Firefox on different devices, with cache being cleared.
When editing the card through the UI, I do get an error:
get-card-element-tag.ts:4
Uncaught (in promise) TypeError: Cannot read property 'startsWith' of undefined
    at h (get-card-element-tag.ts:4)
    at HTMLElement.value (hui-edit-card.ts:336)
    at HTMLElement.value (hui-edit-card.ts:123)
    at HTMLElement.performUpdate (updating-element.ts:716)
    at HTMLElement._enqueueUpdate (updating-element.ts:649)

I'm not sure exactly what the error was, but I readded it a few times and now it's loading. Sorry!


Upgrade to 4.0.0-pre.9

Hi.
This is little update, that would help to newbies start work with freshest near-sdk version.
If you like it, you can quickly merge it to your awesome example.

Please check actual example of cross contract counter https://github.com/near-examples/cross-contract-rust-counter
This repo is a codebase for a video tutorial


Touch pressure support on ios and android

Implemented touch pressure on android and ios, modified multitouch test to use it.
Could use some feedback!
#5241

Any idea why does the pr check fails?

Awesome! Really need this one!

This is very expected!!! Could you, please, merge it?


nuxt.config.js ignores settings for the vite.server.hmr

Environment

Operating System: Linux
Node Version:     v20.10.0
Nuxt Version:     3.10.0
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      ssr, srcDir, app, typescript, runtimeConfig, vite, hooks, modules, experimental
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
I'm sorry, but I have no way to create a reproduction.
Describe the bug
nuxt.config.js ignores settings for the vite.server.hmr and hot reload not working. In my case I'm using a docker image and nginx reverse proxy with self signed certificates, so I want hmr to work on localhost, but settings for vite.server.hmr are ignored. If I check hmr using the vite:configResolved hook hmr is false and values like port, protocol are undefined. After testing, this behavior started to happen since version 3.7.0.
In the browser, the error is shown like this:

WebSocket connection to wss://localhost.test/_nuxt/ failed
Uncaught (in promise) DOMException: Failed to construct 'WebSocket': the URL wss://localhost.test:undefined/_nuxt/ is invalid.

The only way to achieve functionality is to override vite config in hook vite:extendConfig.
hooks: {
    'vite:extendConfig'(viteInlineConfig) {
        viteInlineConfig.server = {
	    ...viteInlineConfig.server,
	    hmr: {
		protocol: 'wss',
		port: 24_678,
	    },
	};
    },
},

Additional context
If I log config values via hook vite:configResolved, the values for hmr as port and protocol are undefined
{
  https: false,
  hmr: {
     protocol: undefined,
     port: undefined,
     host: undefined,
  }
}

Logs
No response

Thank you for your reply.


Add print styles to dashboard

Fix #1007
Hide header and side navigation on print, add print button to order details page

Codecov Report

Merging #1013 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   63.69%   63.69%
=======================================
  Files         116      116
  Lines        6112     6112
  Branches      744      744
=======================================
  Hits         3893     3893
  Misses       2066     2066
  Partials      153      153

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c890251...c892799. Read the comment docs.


Fix labeler.yml

See https://github.com/dart-lang/native/pull/873

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew , can you take a look. I am not experienced enough in this area.

@mosuem , can you fix failure of 'Pull Request Labeler / label (pull_request_target)'?

The failure for the Pull Request Labeler / label bit won't be fixed until this PR lands. I believe it won't use the new config until it's on master.

The failure for the Pull Request Labeler / label bit won't be fixed until this PR lands. I believe it won't use the new config until it's on master.

Ok, merging in spite of failures.


add typedoc, test doc generation

This should close #586
In order for this documentation to be useful, it would be nice to know expectations for this (what things do we think are necessary to make this useful?).
For now I:

set up a plugin to render it as markdown
commit doc files so they can be viewed directly here

What if we could build these to digidem.github.io/mapeo-core-next using CI, rather than committing them to the doc/ folder?

What if we could build these to digidem.github.io/mapeo-core-next using CI, rather than committing them to the doc/ folder?

Yeah, that could be an option. I really don't have a strong opinion on this.
Do you see a disadvantage on committing docs to the repo?
Having a dedicated page for typedoc kinda makes sense. But I also like having documentation in markdown directly on the repo.
A middle ground could be:

commit docs on the repo as markdown
have that same documentation published as gh-pages (this may make sense to set up using CI, since we need to generate docs as html, not md)

keen on other's opinion @achou11 @gmaclennan

I was writing a decently long response to answer the questsions here but we just discussed this over a call, so will document what was agreed instead:

Stick to committing the generated docs to the repo and deploying the directory using repo-specific github pages feature. we want to avoid touching the org-specific github pages because there's a preexisting site there (repo).
Adjust the configuration for the generator so that it only generates documentation for exported APIs. Having all of the internal stuff is not as useful in the short-term for us
Figure out whether we want docs to be updated per PR/commit or if there's some kind of automation we use to update the docs after PRs are merged in. Would be nice to set up a workflow that can do provide a "preview" url (similar to Netlify, Vercel, etc) for a PR.

Following andrews proposal I've basically set up documentation so that only public things gets docgenerated and commited to the repo. On the other hand I've set up a workflow so that we can publish an html version of documentation to ghpages.
This is now deployed here. This is a custom domain set up for the repo. I think the idea is not to hosted there, but on the default url (so, smth like mapeo-core-next.githab.pages.io ? ).
But I can't seem to find a way to ignore a custom domain for a specific page.
I'm wondering if we can delete the custom domain setup for this repo (I think so since I don't think is being use for anything else in this repo) so it can be deployed to the default url.
Regarding WHEN to generate the docs. For now is set up so that only updates on the main branch deploy the docs (which I think it makes sense?). After merging this PR I need to remove a protection rule so that this branch can also deploy the page.
The thing that I may need some help setting up is the preview of the page. What I'm thinking is that this preview should be accessible on a PR that is going to be merged to main. For that I may need to generate a token (gonna look at this a little bit more but that seems to be the case...)

Also, along side MapeoManager (which is kinda the the thing we want to generate docs for) there are some other stuff exported mostly related to fastify. We can explicitly ignore those classes (ussing a @hidden tag in the jsdoc) or just leave them there...

This is looking good!

I'm wondering if we can delete the custom domain setup for this repo (I think so since I don't think is being use for anything else in this repo) so it can be deployed to the default url.

Let me know if you want me to do this.

Regarding WHEN to generate the docs. For now is set up so that only updates on the main branch deploy the docs (which I think it makes sense?). After merging this PR I need to remove a protection rule so that this branch can also deploy the page.

I think it makes sense to generate every time main changes.

After merging this PR I need to remove a protection rule so that this branch can also deploy the page.

I wonder if we can disable the branch protection only for the GitHub Actions bot. I see this in the settings:

The thing that I may need some help setting up is the preview of the page.

I think this can be done in a followup PR.

Also, along side MapeoManager (which is kinda the the thing we want to generate docs for) there are some other stuff exported mostly related to fastify. We can explicitly ignore those classes (ussing a @hidden tag in the jsdoc) or just leave them there...

I also think we should do this in a followup.

not sure if disabling the custom domain for this repo will be trivial/possible based on what's described here:
https://docs.github.com/en/pages/configuring-a-custom-domain-for-your-github-pages-site/about-custom-domains-and-github-pages#using-a-custom-domain-across-multiple-repositories
we have the custom domain set up on our org , which means that all of the projects are subject to it. in order to override it, we need to point to a new custom domain, but I don't think we can "revert" it to the project-specific default of digidem.github.io/mapeo-core-next

Gregor mentioned that he's set up https://core.comapeo.app/ to point to GH pages so can use that for this project

I wonder if we can disable the branch protection only for the GitHub Actions bot. I see this in the settings:

doesn't seeems like it, it won't find the Github actions bot...

How does docs/api/md/ get automatically updated? How do we make sure the docs stay up-to-date?

There are a lot of links to source code. For example:
https://github.com/digidem/mapeo-core-next/blob/518de6dcd6dbaf2011bdcd13651f82d1f74ab5cc/docs/api/md/classes/MapeoManager.md?plain=1#L69
These links reference a Git commit ID. This means that every commit will update all these links. Maybe we could just have these update when releasing a new version of the module?

I think an interesting thing to see is the possibility of, when merging something to main or when publishing a new version, a flow is run that updates the repo markdown documentation.

3. Is there a way to prevent all the internal files from being included?

Currently I'm using a plugin typedoc-plugin-missing-exports that basically includes files that are referenced by a public file. This makes documentation more useful (i.e., you can see MapeoProject documentation now). The plugin doesn't have any options the allow smth like defining how deep in the dep chain it goes, so it kinda includes everything that is referenced...

4. A bunch of files seem to reference `/home/szgy/src/dd/`. When I run them on my machine, they reference _my_ working directory. Is there a way to normalize this?

Haven't found a way of fixing this yet. The files that reference an absolute path are kinda random from what I've seen

I think an interesting thing to see is the possibility of, when merging something to main or when publishing a new version, a flow is run that updates the repo markdown documentation.

I think it'd be cool to do this when we publish a new version, probably as part of our existing release script (see .github/workflows/release.yml).

Do you think having links to the source code makes sense? Because we can also disable them...

I think it's probably fine to disable them for now.

Currently I'm using a plugin typedoc-plugin-missing-exports that basically includes files that are referenced by a public file. This makes documentation more useful (i.e., you can see MapeoProject documentation now). The plugin doesn't have any options the allow smth like defining how deep in the dep chain it goes, so it kinda includes everything that is referenced...

:thumbsup: Would be cool to fix this somehow in the future, not sure how.

I think it'd be cool to do this when we publish a new version, probably as part of our existing release script (see .github/workflows/release.yml).
I've added a flow to release.yml to basically do this by using git and commiting the files. I've also added it to the docs.yml flow so that we can test without needing to do a release (will probably remove that step before merging though...)

Currently I'm using a plugin typedoc-plugin-missing-exports that basically includes files that are referenced by a public file. This makes documentation more useful (i.e., you can see MapeoProject documentation now). The plugin doesn't have any options the allow smth like defining how deep in the dep chain it goes, so it kinda includes everything that is referenced...

👍 Would be cool to fix this somehow in the future, not sure how.
Yeah, me neither, same with all the internal files that are named with an absolute path...

Things to pay attention to:

Security implications of giving gh-action permission to write the repo (can this be avoided by setting a different git user - like one of us - in the action itself?)
improving the flow by using additional parameters (see)

I'll plan to review tomorrow.


[SPARK-39667][SQL] Add another workaround when there is not enough memory to build and broadcast the table

What changes were proposed in this pull request?
This PR adds ANALYZE TABLE tbl COMPUTE STATISTICS; as a workaround when there is not enough memory to build and broadcast the table.
Why are the changes needed?
The current workaround has the following disadvantages:

Setting spark.sql.autoBroadcastJoinThreshold to -1 will disable all broadcast joins.
We don't know the specific value of spark.driver.memory should be set.

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual testing:
Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting spark.sql.autoBroadcastJoinThreshold to -1 or increase the spark driver memory by setting spark.driver.memory to a higher value or analyze these tables through: ANALYZE TABLE `tpds5t`.`item` COMPUTE STATISTICS;."

cc @HyukjinKwon @cloud-fan


Fix infinite resize issue in Mac with scrollbar set to "always"

Issue: in reversed list with small number of items at some breakpoint infinite resize can happen.
Precondition: show scrollbar set to "always" in system setting.
The issue happens in Chrome and Edge, and doesn't happen in Safari
Video:
https://github.com/user-attachments/assets/5f7c955a-6b9b-44cd-82ba-e6d8ea07a81a
I couldn't fully understand how it works, but it depends on the styles of the element that wraps the virtual list component. In Codesandbox you can find 2 examples - where the issue happens and where it doesn't.
Experimentally I found out that setting overflow-y: hidden to virtual list items wrapper element fixes the issue. It looks like it's safe to add this style (Or it isn't? 😁  I see that some e2e tests are failed. Is is because of my changes?).
Note:  I haven't tested horizontal scroll and don't know if it requires different styles

Thanks. I confirmed the issue. I'll merge the PR after I check why it happens,.

Just a note, it can be reproduced on windows too


Tellduslive inresponsive in HA versions above 0.110.1

I am a total beginner so please excuse if this is the wrong forum for this.
I did a fresh install of HA (OS 4.11 and HA 0.112.4) and after that I did not get the tellduslive integration to work I just got “timeout generating authorize url”. It was working before the upgrade so I installed an older version of the HA 0.110.0 and then it worked fine meaning i could intall the integration. I then again upgraded to 0.112.4 and it still worked, however now very slow meaning 3-5 seconds before the powerplug responded to the new command. I reviewed the release notes and noted that there was something changed in 0.110.2 so I installed 0.110.1 and now it is very responsive again, could that change be the cause to this.
I have a tellstick net firmware 17

Well, the tellduslive version was updated in 0.110.2. I'm not sure why the integration is slow to respond.
I would suggest that you start using https://github.com/quazzie/tellstick-plugin-mqtt-hass as that is instant.

Thanks for the response.
Unfortunately i needed to do a freash install a week ago, (HA 0.114.4 and OS 4.12). This time however I do not get Tellduslive integration to work at all. Last time I got it to work if I downgraded to 0.110.0, this time I only get the response  “timeout generating authorize url”. The link you mentioned above do not work for me as I do not have a znet, only a tellstick net.  Any tips that what could cause the message is highly appreciated.


Cannot destroy category search with namespace

[Category Search ]Should be Destroyed after calling Destroy
Steps

Create a category search with a namespace, for example $('#withspace').search({source: content, type: "category", namespace:"mynamespace", minCharacters: 0});
Destroy it

Expected Result
I expect it to be empty.
Actual Result
All the entries are still there.
Version
2.4.2
Testcase
https://jsfiddle.net/c0skzr6g/

Problem still occurs. Tried to increase the semantic UI version but it seems that development has ceased after 2.4.2.
I don't use it anymore myself, just reporting in case this is relevant for other developers.

Hey @KonradHoeffner, I think this project has been abandoned and there's an active fork at https://github.com/fomantic/Fomantic-UI

Thanks! In this case a note on top of the readme and archival of the project may be a good solution, so that others don't go through the same troubles.


tab tool-tips wrong after browsing to different page

tab tool-tips wrong after browsing to different page.  They continue to show the URL of the original page when tab was created.

This web-browser package is no longer supported.  Use the atom package browser-plus instead.


in catch plugins this iv culculate is not right.

elif status is 1:
log('{} has been caught! (CP {}, IV {})'.format(pokemon_name, combat_power, pokemon_potential), 'green')
xp = pokemon_catch_response.xp
stardust = pokemon_catch_response.stardust
candy = pokemon_catch_response.candy
log("Rewards: {} XP, {} Stardust, {} Candy".format(xp, stardust, candy), "green")
return False

Need more information.

Seems fine to me...
https://github.com/OpenPoGo/OpenPoGoBot/blob/master/api/pokemon.py#L27


Update sv pipeline

This PR updates the single sample SV pipeline:

Adding CNVnator caller
Adding filtering for SV/CNV callers
Switch to AnnotSV for SV annotation and TSV generation
Also required the snps detect variants to finish before starting the sv detect variants as the snps vcf is used in the annotation step. Maybe future optimizations can be done to have a detect variants cwl which runs the snp and sv detect variants(or better naming ideas?) at once
remove tools/filter_sv_vcf.cwl
which filtered by pop allele freq and geneated vcf files for input interval lists. AnnotSV generates a TSV with population allele frequency
compress merged output vcf file
compress and index filtered sv vcf files
compress and index raw vcfs from cnvnator and cnvkit. smoove and manta already are compressed and indexed

This PR will also close issues #704 and #715


Cropping images Dynamically

Title - Cropping Images using mouse with the help of OpenCV library in python
what will change -  There is no code for this currently
Assignees -
Type of Issue
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Python

[x] Issue assigned to @Pranjalmishra30

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding

Okk thanks a lot !

Core operations


Missing filter tags on website

The filter tags seem to have disappeared on https://themes.gohugo.io/.  Only All remains:

That's odd ... thanks for the heads up, I'll have a look.

I attempted to deploy this website with Hugo version 0.118.2.
This issue persists in `0.118.2.

Thank you. 👍


Allow remove user when 'AllowDuplicate' is enabled

If 'AllowDuplicates' is enabled and a user clicks on the 'x' near a duplicate entry's name, all instances of that entry are removed.

Hi @OmarStewey, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hey Omar, will have a look at this PR today

Good change...merged :)


Add attachment support

I have not had time for a full review yet, but would you consider rebaseing? 8 commits is a little much for this and I don't like having imports to other repo's in the commit history. And also look in to the failing travis build.

Yeah, I am sorry. I was in a hurry as I had a lot of work to do. Also, I am quite new to go, and so it would be great if you could help me to change from net/HTTP to gorilla mux or something else. I don´t like net/HTTP as you do not have any parameters in the handler.
PS: it is important for the organization feature.

That's not a problem using net/HTTP
Just do:
func HandleFoo(foo string) func(w http.ResponseWriter, r *http.Request) {
	return func(w http.ResponseWriter, r *http.Request) {
        }
})

http.HandleFunc("/foo", HandleFoo("bla"))

But I can't see why you need it.


The checkpoint weights

do you know where I can find the checkpoint weights for the trained PyMT5 and JupyT5? Thanks.

Hi, the PyMT5 and JupyT5 model is provided by the authors in the paper of PyMT5: multi-mode translation of natural language and Python code with transformers and Training and Evaluating a Jupyter Notebook Data Science Assistant. I'm not sure whether they released the checkpoint weights, but you can contact the authors of the above two papers to obtain the checkpoint weights.

Thanks!


[Feature]:  Importing commands to index.js needs to be changed

Is your feature request related to a problem? Please describe.
So if a command is added we'll have to use const command = require( 'commands/command' )
This is will be bad once the code starts growing
Describe the solution you'd like
there is a better way to add commands, like this we'll have to add every single command with const ... = require(...)
instead what we can do is
const commandFiles = fs
    .readdirSync('./commands/')
    .filter(file => file.endsWith('.js'));
for (const file of commandFiles) {
    const command = require(`./commands/${file}`);

    client.commands.set(command.name, command);
}

then use
client.on( 'message',  msg => {
    if (
        !message.content.startsWith(prefix) ||
        message.author.bot ||
        message.channel.type == 'dm' // this solves one of the issue that i have raised
    )
        return;

  const args = message.content.slice(prefix.length)
  const command = args.shift().toLowerCase();

  else if ( command == "/command/" ) client.get(/command/).execute(msg, args, Discord)
  // same for other commands
})

Describe alternatives you've considered
No response
Additional context
No response

Hey, @Tan-Shadow Nice thought. Would you like to go ahead with this issue?

yes but i would love to, but i will need a bit of help

Is this already fixed or still being worked on it?

Fixed by #76


Test run for OCI registry change for ODO

What does this PR do?
What issues does this PR fix or reference?
Is your PR tested? Consider putting some instruction how to test your changes

Closing this issue as tests with new OCI registry was added in Odo repository.


Replace synchronised with locks

Due to the use of synchronised we are effectively making two
separate workers single threaded even though we have dozens of
threads for each. This is affecting our ability to update
equivalent schedules in a streaming fashion and forcing us to do
scheduled bootstraps to ensure data consistency
This commit replaces the use of synchronised with a group lock. The
lock is the concatenation of the channelId, source and date for each
schedule day that we are updating.

lgtm


Will this repo be better than email-verifier?

Hi, I am not very familiar with the principle of email address verification.
We have a new Go backend service that needs to verify the email addresses of newly registered users, and I found two repos: this one and AfterShip/email-verifier.
Compared to email-verifier, I found that this repo only provides verification of format, domain and user But it is simple and efficient enough, and the other one seems to have an outgoing smtp 25 port limit while providing multiple dimensions to check（including disposable and free domain）.
My question is, is it possible to use this library to accurately and efficiently verify the validity of user addresses for new user mailboxes？

Thanks @Dean103 ,
I am the author of email-verfier. As you mentioned above, the two repositories actually have some overlapping features.
checkmail is actually a very good project, simple and elegant enough, and has been maintained for more than 4 years. And email-verifier is like a child, because it's only been open sourced for a few months.
But it's actually more accurate to say that email-verifier has been running for a lot longer internally. Because for us, we have a lot of email campaigns every day, checking email addresses and blocking one-time email registrations is a very important thing for us, based on this purpose, we developed email-verifier, which has worked well since it came online and greatly reduced the problems of our emails not being sent out.
Finally, we are glad to have your approval of our project.

@lryong OK. Already using email-verifier to check addresses and verify disposable domains, overall, great project!


feat(plonky2): Print more plonky2 calls with '--show-plonky2'

This adds '--show-plonky2' support for the following plonky2 calls:
register_public_inputs
add_many
le_sum
range_check

Take a look at this, which is what I had in mind for a test: 46045df
As mentioned in the commit message,

The problem with this approach is that a test that exercises each
operation (e.g., add_virtual_target) needs to be added before the
feature is added. This might be too much of an overhead, compared to
just adding the feature.

This is the reason I'm not pushing for including such tests, but I am still leaning towards suggesting them.
WDYT?

I think that the tests should be more flexible than that, because comparing against a fixed output depends on too many unrelated things in the code generator and in the PLONKY2 library. For example, if a new version of the PLONKY2 library allocates targets in a different way (i.e. different rows and columns numbers or different virtual numbers), this shouldn't break any tests. Also, changing things in the code generator (for example, using several 'add' instructions instead of one 'add_many' in certain cases, for optimization purposes or something like that) shouldn't break tests. Instead, I'm thinking about doing some sort of validation of the PLONKY2 output, by parsing it and checking for invalid instructions, wrong number of parameters, reading from registers, that weren't initialized (this means we forgot to print some instructions), etc. Each instruction will be described as its name and parameter types and direction (input, output) e.g.
add in,in,out
le_sum (in),out
zero out
one out
two out
constant const,out
etc. Some parameters will probably be "passive" (i.e. neither input, nor output), for example for register_public_inputs. So, something like that. :)

generator

Ok, thanks for the detailed explanation.


Error opening plain text file

Can't open a plain todo.txt file, getting a "Cannot open binary file" . I sync text notes to Atom editor on a Mac using Dropbox and it's worked fine before.  Using Pixel 6 Pro, Android 13. Acode 1.6.0 (239). I've noticed this issue with some .txt files while many others still open fine.

Another note - I am able to open the problem todo.txt file in another Android text editor quickedit on the same device without issue.

#536


Add docker images for armv7 and arm64

Right now only amd64 exists, it would be nice to have armv7 and arm64 docker images.

Yes, I currently do not have an ARM testing environment here. If you have an ARM environment, you can try creating an ARM image and let me know.


It would be helpful to integrate with GitHub

Would it be possible to integrate GodBolt and GitHub? i.e. I should be able to compile my repo on GitHub with GodBolt. This avoids copying code from GitHub into GodBolt.

I had never thought of that, that could be really cool.
It probably wouldn't be realistic for bigger projects, but for single header we could have something of a conformance testing facility.
You could probably already do it if you could get https://github.com/ethanhs/cce to run through travis.
But maybe we can do more.

I think it makes a lot of sense to do it for bigger projects. With small projects, it is easier with the current Godbolt interface to experiment. With bigger projects, everyone ends up spending time on extracting the relevant code which consumes time.
Thank you for your consideration,
Honnappa
From: Patrick Quist<EMAIL_ADDRESS>Sent: Sunday, October 6, 2019 5:12 AM
To: mattgodbolt/compiler-explorer<EMAIL_ADDRESS>Cc: Honnappa Nagarahalli<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mattgodbolt/compiler-explorer] It would be helpful to integrate with GitHub (#1615)
I had never thought of that, that could be really cool.
It probably wouldn't be realistic for bigger projects, but for single header we could have something of a conformance testing facility.
You could probably already do it if you could get https://github.com/ethanhs/cce to run through travis.
But maybe we can do more.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/mattgodbolt/compiler-explorer/issues/1615?email_source=notifications&email_token=AG4P7SLIY7QJWVDVQPIGWRLQNG2XVA5CNFSM4I52NQSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOGC7A#issuecomment-538730876, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG4P7SITKTHI3R7YPB5LRZLQNG2XVANCNFSM4I52NQSA.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

thanks both for your thoughts on this. I'm mildly against this as "bigger projects" tend to take longer to compile anyway. Do you have an example @nagarahalli of the kind of project you're thinking of? Or have you got an example of what kind of thing you'd want to view: would you just want to be able to #include <some-github.h> and play with it? or more than that?


Log data/window in Homebridge

Plugin appears to be showing a huge amount of data in the logs window in Homebridge. Is this expected behaviour? Just seems like a lot and I don't recall it doing that recently:

You must be running the beta version. Revert back to V0.5.8 to reduce the extra log output it it’s bothering you.

It was, in fact the "beta" version but that's what installed. Evidently it just updated to 0.5.9 not-beta. IDK.
Thanks.


Proposal: importModuleSpecifierPreference: project-relative

Fixes #36624
People often want to use paths aliases to refer to “external” code (cross-project/package/some other conceptual boundary), but use relative paths elsewhere. Auto-imports cannot help you do this today.
The problem is that the conceptual boundaries within which people want to use relative imports and across which they want to use paths aliases can’t always be inferred. Suppose I have a monorepo structure with a base tsconfig defining paths like
"paths": {
  "*": "./packages/*"
}

Because we are familiar with common monorepo patterns, it’s clear that the package boundaries are the direct subdirectories of packages. So within ./packages/foo I’d use relative imports to import anything in that package, and "bar" to import ./packages/bar.
However, it’s also common for webpack-bundled apps to have a convenience alias for the project root:
"paths": {
  "@/*": "./src/*"
}

This is structurally identical, but serves a different purpose—I needn’t treat ./src/utils and ./src/routes as separate, siloed directory trees.
My original hope was to be able to split module specifier suggestion behavior based on how paths is defined, but I think that is too hand-wavy. Instead, this PR introduces two more conservative heuristics:

If the path from an importing file to the imported file goes outside the directory of the importing file’s tsconfig.json (or inferred/unconfigured project root) and a non-relative path is available, use it.
If the nearest package.json file to the importing file and the nearest package.json file to the imported file are not the same file, and a non-relative path is available, use it.

For everything else, use a relative path.
This should cover basically all monorepo / project references configurations. I can imagine scenarios where I want to conceptually silo directories within a single project where these heuristics wouldn’t help you, but I haven’t heard user feedback from anyone with a setup like that.
I am proposing renaming importModuleSpecifierPreference: 'auto' to 'shortest' to be more descriptive, leaving it as the default (which means that clients sending 'auto' will continue to work), and giving this new setting a brief but descriptive name. Right now it’s 'external-non-relative', which is terrible.

@andrewbranch should the improved behavior for same-package-imports already be present in 4.1-beta or is this PR required?
Currently, I'm getting this

instead of auto-importing ./SerialAPICommandMachine (with typescript.preferences.importModuleSpecifier: auto).

@AlCalzone that’s probably a case of #40713

Let's bikeshed this name somewhere

Renamed to “project-relative.” How do we feel about this going into 4.1?

Since this hasn’t gotten much attention and we’re now quite close to the RC, I think I’d prefer to wait for 4.2 for this. To get user feedback on it, I might see if there’s any interest in running a VS Code Insiders experiment setting project-relative as the default.

How can one participate in that experiment?

@typescript-bot pack this
You can try it out now by installing the tarball that @typescript-bot will post shortly, and adding to .vscode/settings.json:
{
  "typescript.tsserver.importModuleSpecifierPreference": "project-relative"
}

After this is properly merged, I’ll add a corresponding option to VS Code’s preferences UI.

@andrewbranch Do I need to configure project references or the project-specific tsconfig.json in some specific way? My first test with "project-relative" just yielded an import that is relative to the root tsconfig's baseUrl (like it did before).

Oops, apparently the TypeScript language support extension in VS Code filters out values it doesn’t recognize. I guess I’ll have to make an update there first.

@andrewbranch please let me know when there's something I can test. Not sure how long the process to update the extension takes.

@AlCalzone you can use the TypeScript nightly and VS Code Insiders now:

@andrewbranch I must be missing a puzzle piece...
I've updated the branch I mentioned above, current VSCode insiders, today's TS nightly. The setting in .vscode/settings.json is no longer greyed out:

but the repro above is unchanged:

Restarted TSServer and VSCode, no dice.

Ah, it’s because you have this package symlinked through node_modules... and node_modules dependencies get priority. I didn’t notice that before. I’ll have a separate fix up for that.

Wait, this is only allowed to happen because zwave-js is in the dependencies of the root package.json. I guess you could reasonably argue it’s still a bug for any package to import from itself through node_modules, but the reason I’ve never seen this before is because normally packages cannot look up at a package.json and see themselves listed as a dependency. This is also the first time I’ve noticed that you’re using lerna—lerna tends to work perfectly with project references without paths at all, and also without these file: dependencies in package.json files. But one thing at a time, what are these dependencies for in the root package.json?

But one thing at a time, what are these dependencies for in the root package.json?

lerna adds them when I run lerna bootstrap.

lerna tends to work perfectly with project references without paths at all

That would be great news, I've always thought TypeScript needs paths to understand the prefixed packages before they are actually being compiled.

@andrewbranch FYI I just tried to migrate the project to npm@7 workspaces. Without the root package dependences, without paths and without baseUrl it works like a charm:
https://github.com/zwave-js/node-zwave-js/tree/workspaces
==>
So I guess if you don't want to support lerna's quirks, this is a documentation issue in the end.

Huh, I guess I haven’t been using lerna link convert. lerna bootstrap already handles symlinking, and I already install common devDependencies in the root. Thanks for the tip... one more monorepo configuration edge case to consider.

@andrewbranch How can I prevent import specifier suggestion from suggesting non-entry modules in other "packages(folder)" in same repo?
For example I have:
libs
  lib-a/
    index.ts
    internal-a.ts
  lib-b/
    index.ts
    interal-b.ts

I hope the specifier suggestion only suggest exports of lib-a/index.ts when triggered in lib-b/*.

Exports available from the package index have the highest priority, but you can’t prevent exports in other files from showing up.


bump the version of the k8s go client and generated code

Bump the version In prep for https://github.com/openservicemesh/osm/pull/4673

Needs to be rebased.

Codecov Report

Merging #4680 (2cfae97) into main (966405b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4680   +/-   ##
=======================================
  Coverage   69.75%   69.75%
=======================================
  Files         217      217
  Lines       15233    15233
=======================================
  Hits        10626    10626
  Misses       4557     4557
  Partials       50       50

Flag
Coverage Δ

unittests
69.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966405b...2cfae97. Read the comment docs.

https://dl.k8s.io/release/v1.22.2/bin

done!


Content-Length header missing from request headers on 1.10.1

Bug description
This may not be a bug to be honest, but as i'm unsure of the implications of the change, I thought i'd point it out so someone wiser that me can tell me if it's an issue or not.
In summary, on 1.10.1, you no longer get a Content-Length: 0 header on the incoming request where the content-length is 0.
So, 1.9.5:
[atcloud@istio-test-app-1-59dc67588c-v5zgp app]$ curl -s http://app.istio-test-app-2/echoheaders | jq .
{
  "delayWas": 0,
  "hostname": "istio-test-app-2-6bf4fd4bb5-jqtlk",
  "message": {
    "headers": {
      "host": "app.istio-test-app-2",
      "user-agent": "curl/7.61.1",
      "accept": "*/*",
      "x-forwarded-proto": "http",
      "x-request-id": "9d2c7700-1cef-4e75-a5d8-cb45c71142a0",
      "x-envoy-attempt-count": "1",
      "content-length": "0",
      "x-forwarded-client-cert": "By=spiffe://cluster.local/ns/istio-test-app-2/sa/default;Hash=49b9aae42738b5891b2ace393b46f35038ecdc5f6b3c0179f4aa750ca6046b8f;Subject=\"\";URI=spiffe://cluster.local/ns/istio-test-app-1/sa/default",
      "x-b3-traceid": "1ffdd54e806141f46ad2ca3c9dcfdcf7",
      "x-b3-spanid": "0fff39a294747d2e",
      "x-b3-parentspanid": "6ad2ca3c9dcfdcf7",
      "x-b3-sampled": "0"
    }
  },
  "timestamp":<PHONE_NUMBER>936,
  "x-b3-parentspanid": "6ad2ca3c9dcfdcf7",
  "x-b3-traceid": "1ffdd54e806141f46ad2ca3c9dcfdcf7",
  "x-b3-spanid": "0fff39a294747d2e"
}

And on 1.10.1:
[atcloud@istio-test-app-1-56c6866dc8-clwrm app]$ curl -s http://app.istio-test-app-2/echoheaders | jq .
{
  "delayWas": 0,
  "hostname": "istio-test-app-2-6f4bccc7bc-q88p4",
  "message": {
    "headers": {
      "host": "app.istio-test-app-2",
      "user-agent": "curl/7.61.1",
      "accept": "*/*",
      "x-forwarded-proto": "http",
      "x-request-id": "ad04d5c8-f3ef-4f0c-a576-af989c6bd9d6",
      "x-envoy-attempt-count": "1",
      "x-forwarded-client-cert": "By=spiffe://cluster.local/ns/istio-test-app-2/sa/default;Hash=9674f43f8786f720ed9d8a282f04e573e770b99cc6c6747415b936da6767d579;Subject=\"\";URI=spiffe://cluster.local/ns/istio-test-app-1/sa/default",
      "x-b3-traceid": "822e083a49baf0f5075d02a7845836a4",
      "x-b3-spanid": "93ace9825ffeedc5",
      "x-b3-parentspanid": "075d02a7845836a4",
      "x-b3-sampled": "0"
    }
  },
  "timestamp":<PHONE_NUMBER>988,
  "x-b3-parentspanid": "075d02a7845836a4",
  "x-b3-traceid": "822e083a49baf0f5075d02a7845836a4",
  "x-b3-spanid": "93ace9825ffeedc5"
}

I think it's fine, from reading the spec (https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13) the header was only mandatory on http1.0, and when performing a request with a body the header is set correctly:
[atcloud@istio-test-app-1-b699c5dd-x7wdz app]$ curl -s -d '{}' http://app.istio-test-app-2/echoheaders | jq .
{
  "delayWas": 0,
  "hostname": "istio-test-app-2-6f4bccc7bc-q88p4",
  "message": {
    "headers": {
      "host": "app.istio-test-app-2",
      "user-agent": "curl/7.61.1",
      "accept": "*/*",
      "content-length": "2",
      "content-type": "application/x-www-form-urlencoded",
      "x-forwarded-proto": "http",
      "x-request-id": "4a61b7cc-2141-4eae-b712-097aaf75b28b",
      "x-envoy-attempt-count": "1",
      "x-forwarded-client-cert": "By=spiffe://cluster.local/ns/istio-test-app-2/sa/default;Hash=8ff403231459f5a5cdcbac3375af7bd123869503074c44e937bb0f864a955c7d;Subject=\"\";URI=spiffe://cluster.local/ns/istio-test-app-1/sa/default",
      "x-b3-traceid": "8f4cf5d0e3aca7c8241b5deaecca1907",
      "x-b3-spanid": "cb344264db15b22b",
      "x-b3-parentspanid": "241b5deaecca1907",
      "x-b3-sampled": "0"
    }
  },
  "timestamp":<PHONE_NUMBER>071,
  "x-b3-parentspanid": "241b5deaecca1907",
  "x-b3-traceid": "8f4cf5d0e3aca7c8241b5deaecca1907",
  "x-b3-spanid": "cb344264db15b22b"
}

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

This was intentional: https://github.com/istio/istio/issues/30146. So hopefully it is not causing any issues...

Could this issue be related? #33534


null uriToProblem in validation issue

Hi,
In certain syntax issue  'uriToProblem' is null, right now we need additionally to fill the 'URI' value into Issues, otherwise can't resolve file the syntax errors report to. it would be great that yang-lsp can fix that.
use below test model can reproduce the problem, the syntax error is because of unbalanced brace in 'when' statement.
leaf key-id {
        type string;

        when "/ctxsr6k:contexts/ctxr6k:context/ctxr6k:context-"
             + "name='local'" {
                  description
                  "";
         }
         }
}

@RimShao
Would resource URI as uriToProblem work for you?

Fixed


Disable in_app_purchase for master

It depends on the old version shared_preferences, which ultimately means
an indirect dependency on old win32, which no longer works on master.
This will be resolved when in_app_purchase is migrated to NNBD.

Ah, this won't help because it only disable it from build-all; it will still fail on building the individual example.
I think since I just approved the IAP migration PR we can probably just wait for that to land rather than expand the workaround.