Rsx parser with recovery after errors, and unquoted text

Hi.
Original author of syn-rsx is absent for a while.
I tried to reach him through the e-mail but have no luck with that.
I have created a fork of https://github.com/rs-tml/rstml
With aim to better IDE support.
Fork contain few refactors which breaks the API, but during refactor all types became to be self-describing (every type contain all tokens that was parsed), which, i hope, will reduce future breaking changes.
In this PR i move from syn-rsx to rstml fork.
Which also bump minimum syn version to 2.0 (it was already in dependencies before)
In summary, this pr introduce or changes :

Add support of unquoted text support.
Introduce recovery of parser after invalid closing tags, unclosed tags or invalid expression ( can be checked by semantic syntax highlight)
Simplified Node::Text ( no expressions, or other literals except string)
Attribute refactoring - not a node anymore, seperated Block and key=value attributes.
As part of 2. NodeBlock::Invalid was introduced, which represent block with invalid syn::Block syntax.

To discuss:

Component macro refactor.
Currently if inside fn body any invalid expression was found, then macro will fail to expand.
To fix this, we can omit parsing of fn body.

#[allow(unused_braces)], vec![] and other macro usage inside expansion.
I have removed this macro usage, because with them rust-analyzer failed to give completion for invalid expression inside braces <div> {v.<COMPLETION>} </div>. Probably i can return it for NodeBlock::Valid, and keep it removed only for InvalidBlock.

I have fixed fmt, regenerate test stderr for macro ui.
Also for value_to_string, added conversion for primitive Node::Block - now it should explicitly convert
{"string literal"} to "string literal" and use it view::SsrElementChunks::String or in block_to_tokens.
I'm not sure if this pr can move forward on https://github.com/leptos-rs/leptos/issues/766 - because the syntax that was declared in the first post can significantly complicate attribute parsing logic. I also left comment in #766 , with imaginary syntax that could be a bit easier to implement (at least on parsing level), but also solve same problem.
I also could mention, that my fork is also closes https://github.com/stoically/syn-rsx/issues/51
But i am not sure how you bind close_tag with name (you should probably emit some dummy tokens?), so if you can share artifacts of your previous work on it, i can update it.

Agreed, #766 should be entirely separate from this PR. I just meant that having you maintaining rstml more actively than syn-rsx is maintained would mean we might have some more syntactic flexibility! (I see your issue list for example includes a few things Leptos is shipping workarounds for right now)
Re: https://github.com/stoically/syn-rsx/issues/51, I essentially added this to leptos_dom/src/html.rs after HtmlElement::with_view_marker
#[cfg(debug_assertions)]
    /// Marks the closing of this HTML element.
    #[inline(always)]
    pub fn closing_tag(self) -> Self {
        self
    }

and then added a call to closing_tag(), spanned to the closing tag, in element_to_tokens, for elements that had closing tags. This caused the syntax highlighting for the open and closing tags to match, but didn't do anything more interesting like try to link them to one another somehow. I'm not sure if there's a way to indicate to rust-analyzer that two different spans refer to the same thing. Conceptually, for elements and components both the opening and closing tags are linked to the name variable in element_to_tokens, but at present only the opening tag name token is connected to the element/component function invocation from rust-analyzer's perspective.

I'm not sure if there's a way to indicate to rust-analyzer that two different spans

I didn't find a way either.

and then added a call to closing_tag(), spanned to the closing tag, in element_to_tokens, for elements that had closing tags

Theoretically macro also can emit dummy token before dom builder, example that i use in html-to-string-macro:
enum x {}; // for each html, head, body (open and close tag)
let _ = crate::docs::element; // for rest tags

I done this as an example, how one can colorize its output, and add output.
I think some hack way to keep close tag colorized and linked to the valid documentation would be emiting tokens inside if fasle, so rust will not execute it, but it still be possible to bould span to valid component Type.
{
if false {
  let _ = leptos::leptos_dom::html::dom; // for close dom tag
  let _ = Option::<Component>::Some; // for close component
}

leptos::leptos_dom::html::section().child(..)

}

I think some hacky way to keep close tag colorized and linked to the valid documentation would be emiting tokens inside if fasle, so rust will not execute it, but it still be possible to bould span to valid component Type.
{
if false {
  let _ = leptos::leptos_dom::html::dom; // for close dom tag
  let _ = Option::<Component>::Some; // for close component
}

leptos::leptos_dom::html::section().child(..)

}

Oh I think this is very clever.
I think I'll merge this, for now, and then add the closing tag piece in a separate PR. Does that sound good to you? I think this is complete otherwise, right?

I think some hacky way to keep close tag colorized and linked to the valid documentation would be emiting tokens inside if fasle, so rust will not execute it, but it still be possible to bould span to valid component Type.

{

if false {

let _ = leptos::leptos_dom::html::dom; // for close dom tag

let _ = Option::::Some; // for close component

}

leptos::leptos_dom::html::section().child(..)

}

Oh I think this is very clever.
I think I'll merge this, for now, and then add the closing tag piece in a separate PR. Does that sound good to you? I think this is complete otherwise, right?

Yes, thanks. I will open separate PR.
This pr was simple refactoring, but for closing tags I want to understand more about view and template macro.


Flaky TestNetTest/PingPong

Your environment.

Version: https://github.com/pion/dtls/commit/d29c6f07a304a0e030e0871174461b13fe29b017
Test Run: https://github.com/pion/dtls/actions/runs/5813144460/job/15760060217

What did you do?

Merged to master.
What did you expect?
For all tests to pass successfully.
What happened?
CI ran and produced the following error:
❌ TestNetTest/PingPong (1m0.07s)
      conntest.go:57: test timed out; terminating pipe
      conntest.go:131: unexpected Close error: dtls fatal: conn is closed

Re-running the test passed.

No master fails in last ~15 commits. Going to resolve


FileSystem.dest saves an image as a UTF-8 string

I'm trying to test a gulp task that deals with an image.
If we use a simple task:
gulp.src('image.jpg').pipe(gulp.dest('dest'));

and mock our filesystem with vinyl-fs-mock:
mockGulp = createFS({'image.jpg': fs.readFileSync('image.jpg')}); // an existing image

then we have a Buffer image.jpg in mocked FS, and after running a task a String dest/image.jpg, so that the following test passes:
expect(
    mockGulp.openFolder('dest/image.jpg')
).toEqual(
    mockGulp.openFolder('image.jpg').toString('utf8')
);

And mockGulp.entryType('dest/image.jpg') returns file.text.
Is it an intended behaviour?

I found the reason of this bug.
If I change an encoding to hex, the saved string could be read an image without a problem.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/app/managed-environment
Module Details

To be migrated from CARML: https://github.com/Azure/ResourceModules/tree/main/modules/app/managed-environment
Requested by the AZD team: #261
Needs module owner.
CC: @jongio

Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Working on the migration of the module from CARML to AVM. This module will need a long term owner.

@matebarabas - Created new teams

I've just requested the -owners- team to be added to the -technical-reviewers- team. Please approve.

@matebarabas - Done

[x] PR merged; Module published. https://github.com/Azure/bicep-registry-modules/pull/737
[ ] GitHub teams are available and assigned to their parents. --> @arnoldna, can you please create the required GH teams and assign them to their corresponding parents? Thank you!
[x] CODEOWNERS file updated.

Since this module was migrated from CARML without an owner, an orphaned module request was also created: https://github.com/Azure/Azure-Verified-Modules/issues/472

[x] GitHub teams are available and assigned to their parents. Thanks @arnoldna!

I'm closing this issue now.


Added include to ts loader so it won't process node_modules.

Closing since pull request #5 has this fix in it.


[Component Request] {Component}

is it possible to provide various javascript functions to customize the implementation? right now on load they are all binding to the elements. is there any way we can bind the events explicitly?

The request is kinda vague. Needless to say in V2 developers will be binding most events themselves other than what is needed for components to function (like on blur/focus/active for form elements.)
I am looking into adding events to let developers handle custom logic for different situations. However, directly modifying the bound listeners is a no-no. If you want to do that, then you should be building your own custom implementation.
Once V2 stuff lands in master (after 1.1 is out which may still be a bit.) Take a peek and file specific bugs against that for what you would like to see improved along these lines.


Allow adding external formatter (in addition to SpinFormatter)

Hello, I need to present text as a money format, something like $1,234,567. It could be achieved by adding ability to override current default formatting implemented at _formatText

PR created: https://github.com/jpnurmi/flutter_spinbox/pull/94


Inverse and Pseudo-Inverse of operator using Qiskit-terra operator class.

Information about system
•	Qiskit Version:- 0.20.0
•	Qiskit Terra version:- 0.15.1
•	Qiskit Terra API Reference:- Qiskit information
•	Python:- 3.7.6
•	Operating System:- Windows  10
Issue Description:
On solving some linear combinational problems using qiskit terra operators, I faced an issue while working on the inverse of a matrix.
Even though we can achieve an inverse using a mathematical inverse formula, it will be a multistep process. I also tried the NumPy linear algebra function “pinv” & "inv", but the end result was in shape instead of dimensions.
Expected behavior:-
Inverse/pseudo-inverse of an Operator using function and return operator with dimension.
Suggested solution:-
I have come up with a solution, where we can add inverse function in an operator class. I did some modifications in the operator code and the solution matches with the classical solution.
If you find this issue relevant, then I will be happy to help and be a part of qiskit community.

Do you mind adding some code on the current behaviour and your expected output?


update node-hid to 0.7.7 to add support for nodejs 10.x and 11.x

ethereumjs-ledger 2.1.5 work perfectly with nodejs 8.x
while using nodejs 10.x or 11.x and when precompiled binary of node-hid are not present, it crash at build time in node-hid.
Node-hid  solved that issue in version 0.7.7, in fact even earlier since dec 2017 commit
https://github.com/node-hid/node-hid/commit/a994903cb6b3788014c8f542c8a8f6a32a577874#diff-cfaa1c786f0d3247b8a65921909b1e93R208

Note: I think this library isn't of much use anymore since Ledger released their improved JS libraries.  None the less, I'll merge this once CI passes.

It appears this update broke something and CI is not able to build anymore.  I previously had problems with node-hid not working properly in a CI environment, but that should have been fixed in in 0.6.0.  I'm not sure what the issue is here, and unfortunately I don't have the available time to troubleshoot.
If you can figure out what is causing CI to fail, I'll be happy to merge!

i push a fix in .travis.yml

@MicahZoltu can you please make a new release on NPM containing this patch?


System.MissingMethodException: Method not found: Plugin.BluetoothLE.IAdvertisementData

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[] iOS
[] Android
[] tvOS
[] macOS
[] .NET Standard
UWP IS NOT SUPPORTED DURING THE BETA PERIOD - ONLY PRs ARE WELCOME FOR NOW

Version of OS(s) listed above with issue
iOS
Android
Version of Library
6.2.3
Expected Behaviour
                 CrossBleAdapter.Current.Scan().Subscribe((x) =>
                    {
                        if (x.AdvertisementData != null)
                        {
                            if (x.AdvertisementData.IsConnectable)
                            {
                                callback(x);
                            }
                        }

                    });

Expecting to return the AdvertisementData but throwing exception here see the video in action
http://somup.com/cqhOc3n5ZM
Actual Behavior
Unhandled Exception:
System.MissingMethodException: Method not found: Plugin.BluetoothLE.IAdvertisementData Plugin.BluetoothLE.ScanResult.get_AdvertisementData() occurred

Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
If you have a complaint about the docs, FIX IT - DO NOT FILE IT HERE!  I won't guarantee everything is always 100% up-to-date since I am just 1 person.
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

What platform?
Are you using packages.config?
If android - are you targeting android 8.1+
Please provide a reproducible sample

Issue Resolved, having Conflict with other BLE plugins. I have clean my project with useless references and all good now.
Thank you for your time looking forward to have Serial style communication in this plugin. Rather than RX.

This plugin will always be RX so you’ll likely need to look elsewhere


[Suggestion] feature(store): Support passing a selector function to Store.select()

This is more of a suggestion than a complete PR.
Allows you to pass in a selector function instead of a key string, giving you type checking on your selector. Just a little productive sugar over state.map(selectorFunction).distinctUntilChanged();

interesting idea. let me think on it, but in principle it sounds like a good idea to me.

@MikeRyan52 would you mind adding a distinct test for this scenario instead of changing the original? other than that, lgtm, and i'll merge it.

Added distinct tests and expanded key types to support all valid key types (numbers, strings, and symbols)

groovy, merged.


Update orgs.js

Remove abandoned, deprecated, or irrelevant repos per #49
@rmg @sam-github @chandadharap @raymondfeng @ritch

Personally, I don't think any of them should be removed unless the repos themselves have been deleted. I consider ibm.github.io an inventory of open source repositories, not a tool for promoting specific repositories.

Well, I'm not sure what the point is of listing repos that haven't been touched in several years, or have no meaningful content, or are based on long-outdated and abandoned project ideas.  Including useless repos like that detracts from the repos that are current.   The number of repos is long enough already that the home page crashes Chrome, so there is clearly a nonzero cost to adding a repo to the list.

@rmg I added those repos back.

@rmg We already have had a discussion about removing old deprecated repos form github. I don't see why we need to list those here?

@christo4ferris I believe this can be merged, based on the @chandadharap comment above.  She is the engineering director for StrongLoop.

Does orgs.js have a concept of "old, archived, unmaintained"?  If not, perhaps now is a good time to add that.

Why is there a list at all? github APIs allows introspection to find all repos in an org.


Bump mysql2 gem version to 0.3.21

Rationale: Incompatibility of old gem version with newer mysql version

Thanks. I expect I should update my local version.

mysql  Ver 14.14 Distrib 5.6.10, for osx10.8 (x86_64)


Change DC for prow CI Conformance jobs

This PR is to change DC for k8s conformance jobs from tokyo to osaka to comply with the new guidelines for PowerVS infra usage.
https://github.ibm.com/powercloud/container-dev/issues/1463

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Rajalakshmi-Girish
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @mkumatag

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Rajalakshmi-Girish, sudeeshjohn
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, Rajalakshmi-Girish, sudeeshjohn
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

key test-kubernetes-periodics.yaml using file config/jobs/periodic/kubernetes/test-kubernetes-periodics.yaml
key kubernetes-postsubmit.yaml using file config/jobs/ppc64le-cloud/builds/kubernetes-postsubmit.yaml

In response to this:

This PR is to change DC for k8s conformance jobs from tokyo to osaka to comply with the new guidelines for PowerVS infra usage.
https://github.ibm.com/powercloud/container-dev/issues/1463

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR parameter cannot be set

Provider Version
0.67.0
Terraform Version
1.4.0
Describe the bug
ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR is a valid user parameter that can be also set at the account level per https://docs.snowflake.com/en/sql-reference/parameters#enable-unredacted-query-syntax-error .
No matter if I use snowflake_account_parameter or snowflake_object_parameter I get:
Error: expected key to be one of [...], got ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR

Expected behavior
Terraform should apply the parameter with no issues.
Code samples and commands
resource "snowflake_account_parameter" "p1" {
  key        = "ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR"
  value      = "TRUE"
}

or:
resource "snowflake_object_parameter" "p2" {
  key         = "ENABLE_UNREDACTED_QUERY_SYNTAX_ERROR"
  value       = "TRUE"
  object_type = "USER"
  object_identifier {
    name = "TESTUSER"
  }
}

Additional context
It is not included in parameters.go though a similar user level parameter (PREVENT_UNLOAD_TO_INTERNAL_STAGES) is.

Going to close this issue since it was resolved by a merged PR which has since been released. Thanks for your contribution!


Fix alignment of timestamps on Material

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #nightly-bugs.

Confirmed this is still an issue. The timestamps seemed to be pinned to the relative "top" for incoming messages and the wayyy bottom for outgoing messages


Docs: Note about Function Templates

People are going to want to bind function templates and will get all super confused when they can't.  So, might as well drop something in the docs.

We can't expect everyone to know the most basic of C++'s mechanics

Function templates and their interplay with compilation is not something every person trying to make a quick game do know perfectly, no, and it gives me a place to forward people so I can close future issues about it quicker.


Can you provide a normal Android project with Gradle

compile failed with bazel project，there are too many error case

Sorry to hear you've encountered errors building with bazel. Currently we have no Gradle support, but feel free to report the errors you are encountering.

bazel compile fail:
external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64/lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin/ld: cannot find Foundation: No such file or directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Target //android_example:lyra_android_example failed to build
INFO: Elapsed time: 485.357s, Critical Path: 96.67s
INFO: 715 processes: 17 internal, 658 darwin-sandbox, 40 worker.
FAILED: Build did NOT complete successfully

bazel do not support chinese! Do not put source under chinse directory.

OS: Ubuntu 20.04.2 LTS 64Bit

It's hard for Android developers to compile. Better to provide gradle library.
m@m-pc:~/dev/lyra-main$ bazel build -c opt :encoder_main
INFO: SHA256 (https://github.com/bazelbuild/gmaven_rules/archive/20180625-1.tar.gz) = c166ae9f06069025eab59ad74c102db23badc93abb6582ca69c42a0f441c52b5
DEBUG: Rule 'com_google_protobuf' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "fd8aabf32d1d1ae3319e280fed07aa6eb24d150d", shallow_since = "1614800268 -0800" and dropping ["tag"]
DEBUG: Repository com_google_protobuf instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:27:15: in <toplevel>
Repository rule git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in <toplevel>
DEBUG: Rule 'gmaven_rules' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "c166ae9f06069025eab59ad74c102db23badc93abb6582ca69c42a0f441c52b5"
DEBUG: Repository gmaven_rules instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:140:13: in <toplevel>
Repository rule http_archive defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31: in <toplevel>
DEBUG: Rule 'gulrak_filesystem' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "7e37433f318488ae4bc80f80e12df12a01579874", shallow_since = "1602313866 +0200" and dropping ["tag"]
DEBUG: Repository gulrak_filesystem instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:54:19: in <toplevel>
Repository rule new_git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:186:37: in <toplevel>
DEBUG: Rule 'com_google_glog' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "8d40d7564d4a06d77d707d7c4a50c8b5dc45dd80", shallow_since = "1618423177 +0200" and dropping ["branch"]
DEBUG: Repository com_google_glog instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:94:15: in <toplevel>
Repository rule git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in <toplevel>
DEBUG: Rule 'com_google_absl' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "6f9d96a1f41439ac172ee2ef7ccd8edf0e5d068c", shallow_since = "1611082155 -0500" and dropping ["branch"]
DEBUG: Repository com_google_absl instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:37:15: in <toplevel>
Repository rule git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in <toplevel>
DEBUG: Rule 'com_github_gflags_gflags' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "59fb6443a82b84c6b5971b2f45403c78727b7604", shallow_since = "1614883768 -0800" and dropping ["branch"]
DEBUG: Repository com_github_gflags_gflags instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:100:15: in <toplevel>
Repository rule git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in <toplevel>
DEBUG: Rule 'com_google_audio_dsp' indicated that a canonical reproducible form can be obtained by modifying arguments commit = "b73ca8f6c0a6331c3b36a76c211c7f837312a095", shallow_since = "1611434935 -0800" and dropping ["branch"]
DEBUG: Repository com_google_audio_dsp instantiated at:
  /home/m/dev/lyra-main/WORKSPACE:62:15: in <toplevel>
Repository rule git_repository defined at:
  /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in <toplevel>
WARNING: /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/com_google_audio_dsp/third_party/fft2d/BUILD:3:11: in linkstatic attribute of cc_library rule @com_google_audio_dsp//third_party/fft2d:fft2d: setting 'linkstatic=1' is recommended if there are no object files
INFO: Analyzed target //:encoder_main (54 packages loaded, 1593 targets configured).
INFO: Found 1 target...
ERROR: /home/m/.cache/bazel/_bazel_m/c527f4412d4b5cf28fe5c5dd05e80820/external/com_google_glog/BUILD.bazel:5:13: Compiling src/demangle.cc failed: undeclared inclusion(s) in rule '@com_google_glog//:glog':
this rule is missing dependency declarations for the following files included by 'src/demangle.cc':
  '/usr/local/lib/clang/13.0.0/include/stddef.h'
  '/usr/local/lib/clang/13.0.0/include/stdarg.h'
  '/usr/local/lib/clang/13.0.0/include/__stddef_max_align_t.h'
  '/usr/local/lib/clang/13.0.0/include/stdint.h'
  '/usr/local/lib/clang/13.0.0/include/limits.h'
Target //:encoder_main failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 132.057s, Critical Path: 8.04s
INFO: 213 processes: 29 internal, 184 linux-sandbox.
FAILED: Build did NOT complete successfully

@aluebs If move source from dev to 下载, then run bazel build:
m@m-pc:~/下载/lyra-main$ bazel build -c opt :encoder_main

bazel error: can not find ~/??/lyra-main

That seems to be problem of bazel not recognizing chinese characters. But that folder is not part of our repository, rather the path where you cloned it into. It should be as easy as moving the Lyra folder into a path with no chinese characters.

Since it has been mentioned in this thread, the new Lyra 1.2.0 release now has experimental Mac support.


Add {AAR}: {AAE token}

[x] I understand that token listing is not required to use the Polygon Wallet with a token.

Please provide the following information for your token.
Token Name:
Token Symbol:
Decimals:
Polygon Address:
Ethereum Address:
Logo URI (svg):
Project Name:
Project Summary:
Project Contact:
Project Website:
Mainnet/Testnet:
Additonal Notes:

.


use binary save string comparison

can you explain what this change is for? What problem are you trying to solve?

I want to check for dirty attributes and some of my attributes are gzcompressed.  It tells me the data is changed, although its the same.

can you provide a unit test for this? Or some example PHP code to reproduce the issue?

I just realised it causes issues.  It also needs to check that the attribute is in fact a string.
I'll make some tweaks, and provide a unit test.

there are some caveats as you can see at php.net
http://php.net/manual/en/function.strcmp.php#108563

While creating the test to prove my point I found that the !== operator works fine and the issue was somewhere else in my code.
Sorry for being hasty about this and not providing tests to begin with.


how to check for errors in returned reverse proxy? example given.

fasthttp
  ProxyClient = &fasthttp.HostClient{}

  if err := ProxyClient.Do(&ctx.Request, &ctx.Response); err != nil {
	  //how to do the same in hertz?
  } else {
  }

hertz
  h2client, _ := client.NewClient()
  c.SetClientFactory(factory.NewClientFactory(
	  config.WithDialer(standard.NewDialer()),
	  config.WithTLSConfig(&tls.Config{InsecureSkipVerify: true})))

  proxy, err := reverseproxy.NewSingleHostReverseProxy("https://<IP_ADDRESS>:8080/proxy")
  if err != nil {
	  panic(err) //this is only check if the connection is ok?
  }
  proxy.SetClient(h2client)
  proxy.ServeHTTP(cc, ctx) //how to know if returning error?

Just use SetErrorHandler to customize ur error handler.
See, https://github.com/cloudwego/hertz-examples/blob/main/reverseproxy/customize_error/main.go.

In addition, I wrote an article to briefly introduce the use of reverse proxy in Hertz, you can refer to it.
See, https://dev.to/llance_24/golang-reverse-proxy-practices-36od

ok thx


update cobra and pflag

to use @shomron's fork via dep source magic
this will allow us to keep the imports as spf13 rather than using forks for a bunch of dependent packages.
also blocks #756
Signed-off-by: Derek Wilson<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 1304

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.54%

Totals

Change from base Build 1302:
0.0%

Covered Lines:
12300

Relevant Lines:
17437

💛  - Coveralls

@underrun can you verify if you're using the latest dep release? It looks like there are differences in the lock file that may be related to that.

:shipit:


Front-End Event Emission Attempt with m00npapi

Updated App.jsx file with emitted event listener and other necessary components to show event logs on frontpage of UI. Unfortunately not working after a lot of troubleshooting! Think it could be actually in the DEX.jsx file but leaving for now! Can use commented-out code blobs to trial and error later within App.jsx, see comments within the file.

Thanks for the review! Merging now!


Improve Collateral Management

Currently, Nami does not even find collateral UTxOs created by itself on another device or before restoring a wallet.
This leads to prompts to create a new collateral UTxO, whenever a wallet is restored or another instance of Nami is spending the collateral, because its collateral UTxO is another one. This leads to transaction fees and fragmentation of the wallet.
Please implement a functionality like ccvault, where an existing UTxO in a sensible amount range can be taken as collateral.

Hey, yes I added that in the most recent version 3.1.2. So if you haven't set collateral explicitely, it looks also for utxos now in the range of 5-50 ADA.

That's good to know, but it still does not look for a fitting UTxO, when going to the “Collateral” menu item, but offers to create a new one.
I suppose, a lot of people will do that, which at least needlessly costs transaction fees.
It also means that this instance of Nami will probably take away the collateral UTxO of other instances of Nami (or other wallet apps) in “normal” transactions, which means that I can only use Nami for transactions that are guaranteed to require a collateral if I don't want that UTxO to be spent, so that I have to create yet another one.
It really should be possible to choose a specific UTxO in setting collateral in all wallet apps that are supposed to nicely cooperate.

Yes there was a proposed CIP to do that, however after the next hard fork (Babbage), collateral utxos can also contain multi assets, which makes the coin selection much easier. This whole Collateral thing on the user side was only meant as a temporary solution in Nami and I will get rid of it very soon.

Okay then. Closed for me.


Parallel copy-assets

Description of the change
This parallelizes copy-assets by using asynchronous copying.
Benefits
This results in a much faster copying assets step.
The copy step now only takes 13 seconds
2020-10-01T11:48:06.2868680Z Copying assets to /Users/runner/work/1/s/out/app
2020-10-01T11:48:19.1717360Z Transpiling packages with custom transpiler configurations in /Users/runner/work/1/s/out/app

Verification
The CI passes.
Requires #21401. Only the last commit is for this feature.

@aminya This PR now has conflicts. Could you please resolve them? Thank you

@aminya This PR now has conflicts. Could you please resolve them? Thank you

Thanks for the PR!
That would definitely be a useful addition to our build process. However, it is not something that is within the scope that we have envisioned for Atom. We are not planning to make any major improvements to our build process for the time being. We are focused on fixing user-facing bugs. For that reason, I'm going to close this.
Thanks again for contributing to Atom :+1:


[C++] Avoid producing run-end encoded arrays with runs that have a length longer than INT_MAX

Hypothesis
Limiting the length of runs (not the length of logical arrays) is going to prevent multi-language integration pains at a very low storage/memory cost — compresssing ~2B elements into a single run already yields a great compression factor. If we need to produce longer runs we can simply append multiple < INT_MAX-sized runs.
The spec on array lengths
https://arrow.apache.org/docs/dev/format/Columnar.html#array-lengths

Array lengths are represented in the Arrow metadata as a 64-bit signed integer. An implementation of Arrow is considered valid even if it only supports lengths up to the maximum 32-bit signed integer, though. If using Arrow in a multi-language environment, we recommend limiting lengths to 2 31 - 1 elements or less. Larger data sets can be represented using multiple array chunks.

The solution proposed by the spec for languages that don't support 64-bit integers is to use multiple array chunks. Chunking the physical arrays of a run-end encoded logical array is much easier when we don't have to split in the middle of a run. So limiting the runs at INT_MAX means we only have to worry about the regular split of logical length.
Component(s)
C++

@westonpace sure, updating the reference docs is part of of fixing this issue if people participating in the discussion are in favor of this. :wink:


Error: /tmp/aria2c-stdout: No such file or directory

Hi. I just found your project, and it looks super cool. I've been hoping for something like this since I found the abandoned project called winepak.
However, I'm hitting the following error.
user@machine:~/Games/GameImage$ ./GameImage-x86_64.AppImage --platform=yuzu --name="game" --dir=./game-dir
[*] Package type: flatimage
[*] Selected rom: /home/user/Games/GameImage/build/game-dir/rom/game.nsp
[*] Selected icon: /home/user/Games/GameImage/build/game-dir/icon/cover.png
[*] Selected bios: /home/user/Games/GameImage/build/game-dir/bios/Firmware 17.0.1.zip
[*] Selected keys: /home/user/Games/GameImage/build/game-dir/keys/Keys <IP_ADDRESS>z
[*] build dir: /home/user/Games/GameImage/build/game-dir/build
[*] AppDir from previous run found, remove it? [y/N]:
[*] Fetch https://api.github.com/repos/flatimage/flatimage-yuzu/releases/latest
cat: /tmp/aria2c-stdout: No such file or directory
[*] yuzu:
[*] Download ./AppDir/usr/bin/yuzu:

At this point, the program just exits. Same error happen when uisng the GUI.
I do have aria2c installed, and the -v flag output aria2 version 1.36.0.
Am I missing something obvious or is this a bug?

Also, entirely unrelated to this bug/issue, but is there any way to use Yuzu-EA? Maybe an .AppImage from https://github.com/pineappleEA/pineapple-src?

Hi @ak-42 , thanks for reporting this issue! GameImage uses its own aria2c binary, so there is no need to install it on your machine, from what I've tested this issue happens when there is no internet connection. Try to verify if you can access the mentioned link https://api.github.com/repos/flatimage/flatimage-yuzu/releases/latest through your browser. Yes it is possible to use yuzu EA, I'll include it as a configuration option in the next release :smile:

Yes, I can access the URL. I get structured JSON, which I imagine is what is expected. I even tried downloading the yuzu-arch.fim manually and putting it in the /bin/ folder referenced above, but it didn't recognise it.
Excellent news on Yuzu EA, thank you.

Ah, this instructions are out of date, I'll update them. I switched from AppImage to makeself. Sorry about the confusion, and I'm glad it works.

To configure the emulator inside the flatimage you can use the config flag: my-game.flatimage --config. Just to confirm, is the command you're using on the cli something like this? ~/Downloads/gameimage.run --platform=yuzu --name=my_game --dir=/path/to/my/game. You can try to remove the temporary files directory to see if that is causing this problem with rm -rf /tmp/gameimage. What is you distro? I'll try to replicate on it if possible.

I get this
user@machine:~/Games/GameImage$ ./gameimage.run --platform=yuzu --name="The Game" --dir=./game-dir
Verifying archive integrity...  100%   MD5 checksums are OK. All good.
Uncompressing Gameimage  100%
[*] Package type: flatimage
[*] Invalid src dir /tmp/selfgz1170634080/game-dir
Terminated

I did remove /tmp/gamimage, it did not help. I can see that the directory selfgz1170634080 is created, but it is deleted the moment the program terminates.
I'm running Nobara 39 (which is basically Fedora 39).
I'm happy to help you debug this? Can I perhaps turn on debug level logging or something?

Sorry for the delay in getting back to you on this. If you use the absolute path it should work, e.g.:  -dir="$(pwd)/game-dir". I'll test the config issue, probably has to do with an early exit or something.


The package 'Acr.UserDialogs' tried to add a framework reference to 'System.Collections' which was not found in the GAC.

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[] iOS
[] Android
[] UWP
[] NET Standard 2.0

Version of OS(s) listed above with issue (if android - please include version of Xamarin.Android.Support.* you are using)
Version of ACR UserDialogs Library
Expected Behaviour
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
Code of Conduct

No Library Update Requests - THIS ESPECIALLY MEANS ANDROID SUPPORT LIBRARIES
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

Fix:

Update Visual Studio to 15.8.0
Right click in References -> Migrate packages.config to PackageReference...
Then update Acr.UserDialogs to 7.0.1


Intermittent x509: certificate signed by unknown authority error

Hi there
I'm occasionally receiving the following error when running helm repo update - probably 1/5 times? It's a big issue for us as we're automating the installation/upgrade of a number of charts.
I have also seen x509 cert errors when running helm install occasionally. This doesn't seem to be specific to the GCS bucket from stable, although I'll try and find some command outputs to post here showing this.
I'm unsure what's causing the issue here - does helm repo update run client-side, or on tiller?
➜  gke-infra-dm git:(master) ✗ helm --debug repo update
Hang tight while we grab the latest from your chart repositories...
...Unable to get an update from the "stable" chart repository (https://kubernetes-charts.storage.googleapis.com/):
	Get https://kubernetes-charts.storage.googleapis.com/index.yaml: x509: certificate signed by unknown authority
Update Complete. ⎈ Happy Helming!⎈

I have seen this happen on rare occasion, too. It seems that perhaps one of the Google certs is signed with the wrong CA. @viglesiasce Is this something you can check on?

Is this still happening? I'm hoping the bad server got fixed or flushed from rotation.

Oddly I am also getting this error with kubectl when doing a simple get pods. It seems to be with googles accounts.google.com URL.
It's intermittent and performing the same command straight after returns fine.

FWIW, I'm running:

Mac OS X 10.12.1
kubectl:
Client Version: version.Info{Major:"1", Minor:"5", GitVersion:"v1.5.1", GitCommit:"82450d03cb057bab0950214ef122b67c83fb11df", GitTreeState:"clean", BuildDate:"2016-12-22T13:56:59Z", GoVersion:"go1.7.4", Compiler:"gc", Platform:"darwin/amd64"}
helm: Client: &version.Version{SemVer:"v2.1.0", GitCommit:"b7b648456ba15d3d190bb84b36a4bc9c41067cf3", GitTreeState:"clean"}

All of the examples I've posted are run against a GKE cluster.

@viglesiasce Any insight into this?

I think I have a lead on this one. It started to happen to me for kubectl today as well after upgrading gcloud.  As it turns out, it turns out that the issue only happens with the version shipped by Google with gcloud, not with the one from Brew.
$ which kubectl
/Users/mvip/google-cloud-sdk/bin/kubectl
$ kubectl get pods
Unable to connect to the server: Post https://accounts.google.com/o/oauth2/token: x509: certificate signed by unknown authority

Now, let's instead use the version from brew:
$ /usr/local/bin/kubectl get pods
[...]

Voila.
This leads me to believe that it has something to do with Go and/or how it is compiled on macOS.

This sounds extremely similar to:
golang/go#18141
golang/go#18203
The upstream fix to go1.7.4 was patched into the go1.7.4 distributed with Homebrew here, and then kubectl was recompiled from source using that version here with the release of Kubernetes 1.5.2.
I'm going to bump the revision number of helm in Homebrew, and that may resolve this intermittent problem.

@munnerz vpetersson --
I'm not sure if you're already using the version of kubectl/helm from Homebrew or not, but you may wish to try it as it's been compiled with a version of go1.7.4 with the upstream fix. If this fixes the issue, then we have likely identified root cause.
brew install kubernetes-cli kubernetes-helm

@cblecker I'm actually using the brew version of Helm right now. This is likely what solved my issue a few days (ran a brew upgrade to fix something else).
As of right now, I'm unable to reproduce the issue with either helm or kubectl.

@vpetersson
excellent - I am in fact using the gcloud version (and was until recently using the Helm version too!).
I've just switched back to the Homebrew version and hopefully all shall be resolved.

I'd like to add another confirmation that using the Homebrew build of kubectl fixes this problem over the Google SDK version.
] kubectl get pods
Unable to connect to the server: Post https://accounts.google.com/o/oauth2/token: x509: certificate signed by unknown authority

] /usr/local/bin/kubectl get pods
NAME                           READY     STATUS    RESTARTS   AGE
...

Which must write new credentials because after running the Homebrew version, the Google SDK version now works again.

It looks like this was fixed in upstream Go. I'm marking this as closed.


Add/Enable FS-iSCSITarget-Server

Tool information

Tool name: FS-iSCSITarget-Server (feature of Windows)
Add or update? Add (more like, enable out-of-the-box)
Desired version: The one that comes as part of respective Windows version
Approximate size:
If this is an add request:

Brief description of tool: Allows for putting a directory in a RAMdisk
URL for tool's homepage: It's an optional feature of Windows

Area for Triage: Packages / Scripting and command line (I guess?)
Question, Bug, or Feature?: Feature
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[ ] Ubuntu 18.04 LTS
[x] Windows Server 2016 R2
[x] Windows Server 2019

Can this tool be installed during the build?
Yes, it can be installed during the build; adds 30 seconds to every build.
Are you willing to submit a PR?
I don't know enough about Windows, to be able to file a PR... but I am willing to do so if I could get pointers, about what would need to be done.
See https://github.com/microsoft/azure-pipelines-image-generation/issues/1353 for original upstream request that @vtbassmatt filed based on our feedback + request in pypa/pip#7263.

Hello @pradyunsg ,
Did you consider enabling this feature in runtime? As I know, enabling of this feature doesn't require reboot so it can be enabled in runtime using the following command (you should add PowerShell step at the begin of your pipeline with the following code):
Install-WindowsFeature -Name FS-iSCSITarget-Server -IncludeAllSubFeature -IncludeManagementTools

Could you please try and confirm that it works for you?

@maxim-lobanov  o/
We do that already -- it was added to our pypa/pip#7263. This issue is a request for it to be enabled by default. There's more context on why we requested this in https://github.com/microsoft/azure-pipelines-image-generation/issues/1353#issuecomment-578533816.
This issue is a follow up on https://github.com/pypa/pip/pull/7263#issuecomment-546973933, which resulted in a filing of microsoft/azure-pipelines-image-generation#1353 which was closed when the repository moved.

@pradyunsg , thank you for context!
I believe that makes sense to enable it by default

@maxim-lobanov Thank you! What would be the next step to enable this by default?

сс @alepauly to take a look and approve for work when you have a chance

Hello, @pradyunsg
The FS-iSCSITarget-Server feature is now pre-installed on Windows images. Feel free to open the thread if you have any concerns.


PTX-13775 New test script Having multiple pools and resize only one pool

What this PR does / why we need it:
Test script for pool expand scenario when multiple pools are present and IOs running
Which issue(s) this PR fixes (optional)
Closes # PTX-13775
Special notes for your reviewer:
INFO[2023-01-10 20:49:49] Verifying : Description : Validate cleanup operation successful?
INFO[2023-01-10 20:49:49] Actual:true, Expected: true
INFO[2023-01-10 20:49:49] Verifying : Description : Test completed successfully ?
INFO[2023-01-10 20:49:49] Actual:PASS, Expected: PASS
INFO[2023-01-10 20:49:50] --------Test End------
INFO[2023-01-10 20:49:50] #Test: System check
INFO[2023-01-10 20:49:50] #Description: validating system check and clean up
INFO[2023-01-10 20:49:50] ------------------------
INFO[2023-01-10 20:49:50] Verifying : Description : Test completed successfully ?
INFO[2023-01-10 20:49:50] Actual:PASS, Expected: PASS
INFO[2023-01-10 20:49:50] --------Test End------
INFO[2023-01-10 20:49:50] #Test: System check
INFO[2023-01-10 20:49:50] #Description: validating system check and clean up
INFO[2023-01-10 20:49:50] ------------------------
INFO[2023-01-10 20:49:51] Dashboard URL : http://aetos.pwx.purestorage.com/resultSet/testSetID/65120
Failed to create JUnit directory: /testresults/junit_basic.xml
mkdir /testresults: read-only file systemFailed to create JUnit report file: /testresults/junit_basic.xml
open /testresults/junit_basic.xml: no such file or directory
Failed to generate JUnit report data:
invalid argument
Ran 1 of 111 Specs in 3988.150 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 110 Skipped

INFO[2023-01-12 15:04:25] Actual:true, Expected: true
INFO[2023-01-12 15:04:26] Verifying : Description : Test completed successfully ?
INFO[2023-01-12 15:04:26] Actual:PASS, Expected: PASS
INFO[2023-01-12 15:04:26] --------Test End------
INFO[2023-01-12 15:04:26] #Test: System check
INFO[2023-01-12 15:04:26] #Description: validating system check and clean up
INFO[2023-01-12 15:04:26] ------------------------
INFO[2023-01-12 15:04:27] Dashboard URL : http://aetos.pwx.purestorage.com/resultSet/testSetID/67319
Failed to create JUnit directory: /testresults/junit_basic.xml
mkdir /testresults: read-only file systemFailed to create JUnit report file: /testresults/junit_basic.xml
open /testresults/junit_basic.xml: no such file or directory
Failed to generate JUnit report data:
invalid argumentRan 1 of 112 Specs in 4121.842 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 111 Skipped
PASS

INFO[2023-01-19 00:04:44] Verifying : Description : Validate cleanup operation successful?
INFO[2023-01-19 00:04:44] Actual:true, Expected: true
INFO[2023-01-19 00:04:45] Verifying : Description : Test completed successfully ?
INFO[2023-01-19 00:04:45] Actual:PASS, Expected: PASS
INFO[2023-01-19 00:04:45] --------Test End------
INFO[2023-01-19 00:04:45] #Test: System check
INFO[2023-01-19 00:04:45] #Description: validating system check and clean up
INFO[2023-01-19 00:04:45] ------------------------
INFO[2023-01-19 00:04:45] Dashboard URL : http://aetos.pwx.purestorage.com/resultSet/testSetID/73129
Failed to create JUnit directory: /testresults/junit_basic.xml
mkdir /testresults: read-only file system
Ran 1 of 115 Specs in 2997.969 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 114 Skipped
PASS
Failed to create JUnit report file: /testresults/junit_basic.xml
open /testresults/junit_basic.xml: no such file or directory
Failed to generate JUnit report data:
invalid argument

closing the pull request and reopening the new one as there is some problem with the localbranch created


datadog: time_util portion of new tracing library

This is part of the initiative described in https://github.com/envoyproxy/envoy/pull/23958.
This revision introduces a new library dependency for Datadog tracing, and adds a small component that will be used in the future when more of the new library is integrated into the Datadog tracing extension.

/assign @jmarantz

/assign

/retest

Code coverage for source/extensions/tracers is lower than limit of 95.4 (95.3)

https://storage.googleapis.com/envoy-pr/3629d09/coverage/source/extensions/tracers/datadog/time_util.cc.gcov.html
I could write a test for that overload. Will do this tomorrow.

/wait

/retest

Thanks @yanavlasov @jmarantz


Eliminate OFFSET 0 in the logical plan optimization

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
❯ create view v as select 1 as a, 2 as b, 3 as c;
0 rows in set. Query took 0.010 seconds.
❯ explain select * from v offset 0 limit 2;
+---------------+-------------------------------------------------------+
| plan_type     | plan                                                  |
+---------------+-------------------------------------------------------+
| logical_plan  | Limit: skip=0, fetch=2                                |
|               |   Projection: #v.a, #v.b, #v.c                        |
|               |     TableScan: v projection=[a, b, c], fetch=2        |
| physical_plan | GlobalLimitExec: skip=0, fetch=2                      |
|               |   ProjectionExec: expr=[a@0 as a, b@1 as b, c@2 as c] |
|               |     ProjectionExec: expr=[1 as a, 2 as b, 3 as c]     |
|               |       EmptyExec: produce_one_row=true                 |
|               |                                                       |
+---------------+-------------------------------------------------------+
❯ explain select * from v limit 2;
+---------------+-------------------------------------------------------+
| plan_type     | plan                                                  |
+---------------+-------------------------------------------------------+
| logical_plan  | Limit: skip=None, fetch=2                             |
|               |   Projection: #v.a, #v.b, #v.c                        |
|               |     TableScan: v projection=[a, b, c], fetch=2        |
| physical_plan | GlobalLimitExec: skip=None, fetch=2                   |
|               |   ProjectionExec: expr=[a@0 as a, b@1 as b, c@2 as c] |
|               |     ProjectionExec: expr=[1 as a, 2 as b, 3 as c]     |
|               |       EmptyExec: produce_one_row=true                 |
|               |                                                       |
+---------------+-------------------------------------------------------+

I'd like explain select * from v offset 0 limit 2 and explain select * from v limit 2; to have same logical plan.
Also, in eliminate_limit.rs, we should eliminate the Limit plan when fetch = None and skip = 0 or skip = None.
https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/src/eliminate_limit.rs#L75-L91
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
We could not do this.
Additional context
Add any other context or screenshots about the feature request here.

I will file a PR this week.

Oh, I would close this issue as skip = 0 and skip = None are equivalent.


⚠ Jenkins Plugins Artifactory has degraded performance

In 32088ec, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1133 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 7b621d1 after 25 minutes.


#announce workspace appears to the user without any notification and as read.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to settings then workspaces and create a new workspace
Click members > then click invite > choose User B to invite
Click Next > then Invite
Login as user B and find the #announce workspace he was just invited to inside the LHN.

Expected Result:
#announce room should appear for user B as unread and he got Notified that something new has been added to his LHN, and he is now a member of a new workspace. Just like what happens if he is added as a new chat or added as a group member.
Another scenario: is not to add  #announce workspace to user B LHN unless it had some messages inside it. I suggest this scenario because once the #announce has some messages inside it, it appears unread as expected.
Actual Result:
#announce workspace appears for user B as read and he doesn't get anything to notify him that something added to his LHN and that he has been invited to a workspace.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.43-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screencast from 18-07-23 01_00_37.webm
https://github.com/Expensify/App/assets/43996225/b0211775-19f2-4bb4-a9a6-9d23645317e7
Expensify/Expensify Issue URL:
Issue reported by: @Ahmed-Abdella
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689634166791039
View all open jobs on GitHub

This could be a regression from my PR:

https://github.com/Expensify/App/pull/21406

looking into it!

Taking my comment back, this issue is more of a feature request than a bug / regression

Hmm maybe we should close this since it's a feature request. This started as a bug and we need to propose a feature it seems.


Optimize generated reference docs for launch

Right now our generated reference docs (https://act-now-packages.web.app/docs/index.html) aren't the best.

I disabled typedoc's monorepo support in https://github.com/covid-projections/act-now-packages/pull/399 because it was contributing to out-of-memory crashes.  This made it format less nicely (looks like all the code lives in one big package).
The formatting is very plain.  We'll want to theme it to make it match Act Now branding.
Maybe more. I haven't looked that closely at the usability of the docs.

Ideally we'd have very approachable docs, like e.g. Material-UI. https://mui.com/material-ui/api/grid/
We should:

Look around to see if there are other tools we could use besides TypeDoc.  E.g. what does Material-UI use?  Note that it'd be nice to keep using a tool that is TypeScript-aware.
See if TypeDoc's monorepo support works better now and could be reenabled.
Investigate theming ability, etc. with TypeDoc to see what's possible for improving docs.

I'd try not to spend more than 1-2 days investigating this initially, especially if we find out there are other tools we should be considering.  We can discuss options / recommendations at standup.

https://api-extractor.com/ is another option for generating docs (from Microsoft) but it seems much more strict / opinionated and less widely used.  I played with it a little and had trouble getting it to run. The builtin documentation generator just generates markdown. I think it'd probably require a lot of work / customization to use.

I'm not very happy with the options that I've found...

I think TypeDoc and API Extractor are the only real options for API Documentation for typescript projects.

API Extractor is part of rushstack, created by Microsoft. I had trouble getting it to run on our codebase (it works completely differently than TypeDoc, running on the generated .d.ts files) and I think it might require a fair amount of work / customization to use. That said, I do like the formatting of the rushstack docs [generated by api-extractor I assume] better than TypeDoc. Though I think the out-of-the-box support only does markdown, so not sure how much custom work would be needed.
TypeDoc is okay, but the (default) output isn't very friendly / usable IMHO, and it has a number of quirks.  The output for react components is pretty poor (though not sure API Extractor would be any better).

I think we will probably want to use one tool for generating our "normal" API reference docs (regions, metrics, etc.) and another tool for documenting our react components (everything in ui-components), so that we can get nice clean documentation of the properties for each component, without having to navigate intermediate interfaces (MetricCompareTableProps or whatever).
For documenting react components I've found:

Storybook has a "Docs" page for each component that shows the props table, but it has 2 problems: 1) It's a separate page that you have to click on. There's no way to just browse all the component docs directly. You can't even link directly to a docs page AFAICT. 2) By default it is interactive, so you can change the prop values. In theory this could be useful, but in practice it is super messy since many of our components take complex props (like a list of regions that aren't conducive to storybook's UI).
React Styleguidist is similar to Storybook and also supports including component documentation, but it wasn't trivial to set up (you need to setup webpack) and I don't think we really want to switch away from Storybook. Using both seems odd.
react-docgen-typescript is an underlying module built for react styleguidist but it is also used by Storybook for extracting React component docs from TypeScript and it seems pretty easy to use. We could probably build something on top of that if we wanted, but that would be more custom work.

I feel like to have good docs we're probably going to need to do some deeper investment / custom work that could include:

Playing with react-docgen-typescript to generate our own docs for our react components.
Playing with typedocs plugin / theming infrastructure to see if we can improve the output.  Perhaps even integrate with react-docgen-typescript to create decent docs for react components.
Trying harder to get api-extractor working to see if we can generate better docs with it than with typedoc.


clear rewardable topics each block after rewards paid

Purpose of Changes and their Description
Rewards are not being cleared each block.
This was causing issue when there was error in at least 1 epoch per topic after the migration, as was expected and did occur (for just 1 epoch).
This error meant that rewards would "bug out" before the topic could be removed from the rewardable set.
We fix this by clearing out the whole rewardable set after rewards calculation of each block.
I set a hard bound of MaxActiveTopicsPerBlock + 1 because one less than that many should ever be part of the rewardable set per block. If there are errors, then the +1 ensure that they automatically, eventually get cleared off.
Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?

[x] If tested, please describe how. If not, why tests are not needed.

Unit tests

[ ] If documented, please describe where. If not, describe why docs are not needed.
[ ] Added to Unreleased section of CHANGELOG.md?

Still Left Todo

Closed in favor of:
https://github.com/allora-network/allora-chain/pull/592


Layout editor bug on non trivial multiple monitor setup

Microsoft PowerToys version
0.66.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
FancyZones Editor
Steps to reproduce
I have the following monitor setup:

When trying to setup a custum layout in canvas mode, new zones are created on the top left corner of the bounding box containing the 2 monitors (above the lower monitor, to the left of the upper monitor).
This means the newly created zones are unreachable and the user can't edit them.
✔ Expected Behavior
new zones should appear inside monitors area.
❌ Actual Behavior
new zones should appear outside monitors area.
Other Software
No response

Are you still experiencing this issue? /needinfo


Add meisdata.io as sponsor

@ewingson does this look OK to you?

Digita
O Team
GraphMetrix
Interition
Ontola

Understory
Startin'blox
Muze
Ponder Source
Me Is Data

@michielbdejong
I dunno quite how to say, make it look like "Meisdata" instead of "Me Is Data"

done in #16


Fix conflicts at #1352 fix memory leaks and lint warnings (they happened due to hiding keyboard)

Description
Fixes conflicts at #1352 , so that I can merge.
Tests performed
Tested on API 25, betaDebug

Codecov Report

Merging #1471 into master will increase coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1471      +/-   ##
=========================================
+ Coverage    3.21%   3.25%   +0.03%
=========================================
  Files         132     132
  Lines        7088    7196     +108
  Branches      680     707      +27
=========================================
+ Hits          228     234       +6
- Misses       6845    6947     +102
  Partials       15      15

Impacted Files
Coverage Δ

...n/java/fr/free/nrw/commons/auth/LoginActivity.java
0% <0%> (ø)
:arrow_up:

...e/nrw/commons/category/CategorizationFragment.java
0% <0%> (ø)
:arrow_up:

...free/nrw/commons/upload/MultipleShareActivity.java
0% <0%> (ø)
:arrow_up:

...nrw/commons/upload/MultipleUploadListFragment.java
0% <0%> (ø)
:arrow_up:

.../free/nrw/commons/upload/SingleUploadFragment.java
0% <0%> (ø)
:arrow_up:

...fr/free/nrw/commons/settings/SettingsFragment.java
25.51% <0%> (-4.49%)
:arrow_down:

.../fr/free/nrw/commons/utils/StringSortingUtils.java
73.91% <0%> (-1.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2cc26...d1fa26f. Read the comment docs.


Issue 2863 report breaking changes

Description of your changes:
Introducing a new target testBreakingChanges that will run the main.go file inside the cmd/testBreakingChanges directory.
expected output: ----Target successful,this file inside cmd/testBreakingChanges runs successfully----
I have:

[x] Read and followed Crossplane's [contribution process].
[x] Run make reviewable test to ensure this PR is ready for review.

@muvaf


Replace PyInquirer with its defacto successor inquirer

Codecov Report

Merging #21 (dd52178) into master (c2e8b80) will decrease coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   96.54%   95.88%   -0.66%
==========================================
  Files          28       28
  Lines         925      923       -2
  Branches      166      166
==========================================
- Hits          893      885       -8
- Misses         19       22       +3
- Partials       13       16       +3

Impacted Files
Coverage Δ

stapy/cli/cli.py
92.55% <100.00%> (-0.08%)
:arrow_down:

stapy/sta/query.py
93.49% <0.00%> (-3.57%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e8b80...dd52178. Read the comment docs.


Pull Request for first UI rework

Pull request for adding brewery UI cards, navbar, dependencies (added axios for querying), CSS, and decoupling the app structure.

Should be fine, I'll take a look here! I assume just going into main is fine but will let you know.

From: davis-anderson @.>
Sent: Monday, November 29, 2021 7:04 PM
To: melo-velo/dabbler @.>
Cc: Subscribed @.***>
Subject: [melo-velo/dabbler] Pull Request for first UI rework (PR #1)
You don't often get email from @.*** Learn why this is importanthttp://aka.ms/LearnAboutSenderIdentification
Pull request for adding brewery UI cards, navbar, dependencies (added axios for querying), CSS, and decoupling the app structure.

You can view, comment on, or merge this pull request online at:
https://github.com/melo-velo/dabbler/pull/1
Commit Summary

36e2a65https://github.com/melo-velo/dabbler/pull/1/commits/36e2a6514bfcf8a8e5b3b3aad5125bcc5999f897 Adds Davis to end of README
ca827c4https://github.com/melo-velo/dabbler/pull/1/commits/ca827c42a05009fd09e5c7070c74eba975a52ccf Adds test message
87bc5ebhttps://github.com/melo-velo/dabbler/pull/1/commits/87bc5eb30d2123dac52d2cd5643afdfdf7e81d0a Removes test message
27cf2f0https://github.com/melo-velo/dabbler/pull/1/commits/27cf2f0489229191b5673cf7f691df7476a503b1 Restructures query to clean up App.js, queries list of breweries through map
03fa586https://github.com/melo-velo/dabbler/pull/1/commits/03fa586a45a3005e72e9779962e5e28160e4e890 Adds navbar, also creates clickable card components.
b62ece9https://github.com/melo-velo/dabbler/pull/1/commits/b62ece9c01ad83bcc4863d79f897f7044c07bf81 Updates dependencies after installing axios and UI changes

File Changes
(8 fileshttps://github.com/melo-velo/dabbler/pull/1/files)

M README.mdhttps://github.com/melo-velo/dabbler/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (4)
M src/frontend/package-lock.jsonhttps://github.com/melo-velo/dabbler/pull/1/files#diff-9eaa8c31e85b60ae25c139f2d6363cc9dcb6926125b5bf1d0cac092547e8cfcb (81)
M src/frontend/package.jsonhttps://github.com/melo-velo/dabbler/pull/1/files#diff-12ee508ecc1901fe1a1d71ed459dba8454f3160983ee18b2c51b76ade45235d3 (1)
M src/frontend/src/App.csshttps://github.com/melo-velo/dabbler/pull/1/files#diff-3e7904848c381eb53375a14db869438235df15b6e439845f23d09b12382c0d47 (107)
M src/frontend/src/App.jshttps://github.com/melo-velo/dabbler/pull/1/files#diff-55c6252ff3d724bca26874021d8db2ccde304b37f2584aac6217afa7ffed696c (195)
A src/frontend/src/components/Brewery.jshttps://github.com/melo-velo/dabbler/pull/1/files#diff-261a30cb8bb20db7c3e74cb4cd214ec22d98516241df1bce17738465c620802b (44)
A src/frontend/src/components/Navbar.jshttps://github.com/melo-velo/dabbler/pull/1/files#diff-464ba8a0bcfc73ba0e3ca0ecf898ec59ed3a87ba04976e0632f3493f7e3a0bf9 (19)
M src/main/java/com/project/dabbler/brewery/BreweryService.javahttps://github.com/melo-velo/dabbler/pull/1/files#diff-f5e83b0cdf735470b2367020669babc642e12cc7f9ac458fa7ff56e80e473caf (19)

Patch Links:

https://github.com/melo-velo/dabbler/pull/1.patch
https://github.com/melo-velo/dabbler/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/melo-velo/dabbler/pull/1, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ART6KW7T2WXNRV7IJPD3UB3UOQPLBANCNFSM5JAP5YGQ.

It looks like there are some merge conflicts in that src/frontend/src/App.js file, to resolve those it should be as easy as pulling down what's in Main (in my repo) and then resolving whatever is causing the issue. Then if you commit and push it should get rid of that error!

Fixed the conflicts in App.js


Quick way to get the FUN page from a JupyterBook page and the other way around?

Very often we want to navigate between the two, having a quick way to do it (even super hacky with a list of correspondence URLs in a Python dictionary) could help.
Also it would be great as a way to semi-automatically compare side-by-side content between the two and identify content drift e.g. quizzes.
Maybe over-engineering not sure ...
I am not sure how stable the FUN URLs are, I am guessing they don't change within one session otherwise 💔

This would be great. !
For information, FUN URLs are very stable within one session. And with a new session, we just have to change the course id in the URL.
For exemple, the url for quiz M1.01 is : https://lms.fun-mooc.fr/courses/course-v1:inria+41026+session01/jump_to_id/88e9be65c2cb45c88a84e49069abd71b
For the next session, it will be :  https://lms.fun-mooc.fr/courses/course-v1:inria+xxx+sessionyy/jump_to_id/88e9be65c2cb45c88a84e49069abd71b


.playSegments. Load 2 animations. Change object color in the .json file.

Hi. I just wodering how to make playable the second part of animation buy click, like in your example here: https://codepen.io/airnan/pen/RawvLB
I've made 2 files of animation for my button:
a. The 1st animation is when we hover on button;
b. The 2nd animation is when we click on button.
Question 1: (load 2 animations)
Scenario:
a. When we hover to button works 1st animation;
b. When we click to button:
b.1. We're waiting for finish the first animation;
b.2. We run the 2nd animation;
b.3. After the finish of the 2nd, we return the 1st animation.
How can I make that after finishing the first animation (hover) runs the 2nd (when we clicked to button)?
motionbutton.zip
*click.js it's the 2nd animation;
*hover.js it's the 1st animation.
*I copied a code from .json and pasted to .js with 'var btnhover=' and 'var btnclick='.
Question 2: (.playSegments)
I saw that you used playSegments. How can I find the right time from the generated .json file, if I want to run 2nd part of animation like in your example above. Can you explain, please, what does these numbers mean in your project (link above).
Question 3:
How can I find the color of the object in the .json file? It's very interesting to me and for other users too, I guess, because re-render composition takes a lot of time :(

Hi, regarding question 1 and 2, is it possible in your case that you export a single animation with both states?
I think it will be easier for you to handle when states change.
segments in playSegments are frames in After Effects, so if you do playSegments([10,20]), you'll be playing frame 10 to 20 of your AE project.
regarding question 3, it depends what color you want to manipulate. If it is a shape color, you can find it in the shapes array on objects of "ty" "fl" and "st"

Hey! Wow, thank you so much for your quick answer! You made the best plugin I've ever seen!

Yes, I can export it in a single animation, but I'm a newbie in JavaScript, so could you help me to run my 'Scenario'? What should I do?

Ok, thank you, but I have another question. (sorry, maybe it will stupid question, but anyway) How much frames in 1 second? If I want to run my animation from 3sec to 5sec? ...I think I got it. If my composition 60fps, so 1sec = 60 frames, is that right?

Ok, thx. But I didn't see the code similar to #000dss (for example) near "ty", "fl", "st". What code should I put?

1- if you have a link to where you got to, I can help you from there
2- yes
3- it's an array with the three color components.


How to delete lost worker in alluxio

Alluxio Version:
2.0
Describe the bug
Create alluxio cluster with Kubernetes. I notice there are some workers are lost when using fsadmin report, and I think they're safe to remove. I'm wondering how to delete them.

check the status, there are 12 lost workers

/opt/alluxio/bin/alluxio fsadmin report summary
Alluxio cluster summary:
    Master Address: alluxio-master:19998
    Web Port: 19999
    Rpc Port: 19998
    Started: 06-30-2019 09:38:27:895
    Uptime: 12 day(s), 13 hour(s), 42 minute(s), and 38 second(s)
    Version: 2.0.0
    Safe Mode: false
    Zookeeper Enabled: false
    Live Workers: 4
    Lost Workers: 12
    Total Capacity: 2400.00GB
        Tier: MEM  Size: 400.00GB
        Tier: SSD  Size: 2000.00GB
    Used Capacity: 143.67GB
        Tier: MEM  Size: 143.67GB
        Tier: SSD  Size: 0B
    Free Capacity: 2256.33GB

And I notice the lost workers can be deleted. But how to do it? As you know I run the workers in kubernetes, and have no chance to run stopworker script.

 /opt/alluxio/bin/alluxio fsadmin report capacity
Capacity information for all workers:
    Total Capacity: 9.38TB
        Tier: MEM  Size: 1600.00GB
        Tier: SSD  Size: 7.81TB
    Used Capacity: 143.67GB
        Tier: MEM  Size: 143.67GB
        Tier: SSD  Size: 0B
    Used Percentage: 1%
    Free Percentage: 99%

Worker Name                  Last Heartbeat   Storage       Total            MEM           SSD
<IP_ADDRESS>                0                capacity      600.00GB         100.00GB      500.00GB
                                              used          32.07GB (5%)     0B            0B
<IP_ADDRESS>                0                capacity      600.00GB         100.00GB      500.00GB
                                              used          39.50GB (6%)     0B            0B
<IP_ADDRESS>                0                capacity      600.00GB         100.00GB      500.00GB
                                              used          37.40GB (6%)     0B            0B
<IP_ADDRESS>                0                capacity      600.00GB         100.00GB      500.00GB
                                              used          34.70GB (5%)     0B            0B
<IP_ADDRESS>                55894            capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                55895            capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                55895            capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                55896            capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                169506           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                169506           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                169507           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
<IP_ADDRESS>                169507           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
iZhp3bku0ru8vuxq08loruZ      173968           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
iZhp3bku0ru8vuxq08lorvZ      173968           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
iZhp3bku0ru8vuxq08lorxZ      173968           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B
iZhp3bku0ru8vuxq08lorwZ      173968           capacity      600.00GB         100.00GB      500.00GB
                                              used          0B (0%)          0B            0B

To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Expected behavior
A clear and concise description of what you expected to happen.
Urgency
Describe the impact and urgency of the bug.
Additional context
Add any other context about the problem here.

Looks to me a feature request on graceful remove workers. If my understanding is correct, then yes, we should support this in near releases.

Thank you, @apc999

This becomes an issue especially on k8s env where workers are expected to change IPs a lot. One way to solve this is to add a property key to retire lost workers from Master.

/assign @xichen01

@apc999 whether to provide a command to delete lost workers? such as using the command alluxio fsadmin deleteLostWoker workerAddress1 to delete the workerAddress1 of the worker or just add a property key to retire lost workers from Master.

This becomes an issue especially on k8s env where workers are expected to change IPs a lot. One way to solve this is to add a property key to retire lost workers from Master.

@apc999 @cheyang Compared to deleting those "lost workers" from master metadata, I would consider this more like a "how to identify workers in k8s" problem. Manually deleting those workers don't really help anything. The master will periodically identify and delete lost workers (no heartbeat in alluxio.master.worker.timeout) from its memory and I don't think you need to manually do that. However, deleting those MasterWorkerInfo objects and create new ones will be more expensive in master memory.
Could you elaborate on the use case?

The lost workers (and workers lost in other ways you won't notice) are handled by
https://github.com/Alluxio/alluxio/commit/8183d1b976eaa0423014fb0d20985084029416f4
https://github.com/Alluxio/alluxio/pull/16692
And the function to manually remove live workers will be added by
https://github.com/Alluxio/alluxio/pull/14000
https://github.com/Alluxio/alluxio/pull/16134

@jiacheliu3 So this one is already handled right? Sounds like the lost worker will get cleaned up in the master at some time after it's lost?
I'll close this issue on Apr 11 unless any objection raised.


add a flag to force output to stdout

In older versions (e.g. 2.0.10), etcd writes the output both on stdout and the journal. In newer version, it only writes to the journal:
sudo systemd-run -t $HOME/go/bin/etcd-v2.0.10

--> output on stdout and journald (visible with journalctl)
sudo systemd-run -t $HOME/go/bin/etcd-master

--> output on journald only
Could we have a flag to force output to stdout as well?
Initially reported in https://github.com/coreos/etcd/issues/4993
See also https://github.com/coreos/rkt/issues/2417#issuecomment-215411922
/cc @jonboulle @iaguis

Introduced by https://github.com/coreos/pkg/pull/28
also see https://github.com/coreos/pkg/issues/38#issuecomment-143907184 :-(

I think etcd just needs to make capnslog formatter configurable as capnslog.SetFormatter(capnslog.NewPrettyFormatter(os.Stdout, false)).

https://github.com/coreos/pkg/blob/master/capnslog/init.go#L41

Maybe add --log-output=[stdout,stderr,journald]  flag to etcd?

Maybe add --log-output=[stdout,stderr,journald] flag to etcd?

Is the intent here that a user choose one? i.e.
--log-output=[stdout|stderr|journald]
etcd ... --log-output=journald
Or is it that the user could choose many? i.e.
--log-output=[stdout,stderr,journald]
etcd ... --log-output=journald,stdout
Also, seeing as how there is conditional logic to behave differently if etcd is running under init / systemd, should there be a documented default?

@jlamillan We can overwrite that logic by calling capnslog.SetFormatter. And I think we should make user choose one, since rkt team wants to

have a flag to force output to stdout as well?

@alban Sorry, I think I mis-read the issue:

Could we have a flag to force output to stdout as well

Do you mean forwarding logs to journald and stdout at the same time?
I don't think we should do that, since it's another write overhead? etcd will only log to stderr or journald when systemd is detected and this is handled by capnslog package. etcd doesn't provide any log configuration.

@jonboulle @alban I think it is fine for us to add a flag to force writing log to stdout by default. When set it to false, we will still let the logging pkg to decide where to log. Adding a flag to support logging to multiple sinks seems to be over-kill.

I like the idea of defaulting to stdout based entirely on the number of times I've personally had etcd drop out from under me and leave no trace of output on my terminal.

If the setup outside of a container is the default, I would stay with journal but offer at least an option to be able to switch either entirely or in addtion to stdout. Currently I always need to test stuffs manually after errors with the containers, because they drop away and I can not read the logs anymore.

Can we just dump journal support? It seems like it adds little value and causes confusion.

+1, I'm reaching a similar conclusion
On 14 September 2016 at 21:42, Brandon Philips<EMAIL_ADDRESS>wrote:

Can we just dump journal support? It seems like it adds little value and
causes confusion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/issues/5449#issuecomment-247130386, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN3Zgmu5FHDwrWG92YkUFdpcBcm-pks5qqE4ZgaJpZM4ImhQU
.

Keep in mind that if you drop journal support, you lose the ability to look at the full logs when run under systemd. We depend on the syslog identifier for filtering logs since there is a race on service termination.

Oh damn, I thought that was fixed.
Alex Crawford<EMAIL_ADDRESS>schrieb am Fr., 16. Sep. 2016,
19:25:

Keep in mind that if you drop journal support, you lose the ability to
look at the full logs when run under systemd. We depend on the syslog
identifier for filtering logs since there is a race on service termination.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/issues/5449#issuecomment-247658434, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACewN2IXFf3U35Mh6fBtc8Fizp-7sJeMks5qqtEUgaJpZM4ImhQU
.

@crawford @jonboulle @heyitsanthony
Well... How should we move this forward?
Breaking journald == tons of github issues without necessary logging information.

If you are pid 1, log to stdout. If not, use the journal.

@crawford
The logging lib we use only write to journald when the ppid is 1 (pid 1's ppid is not 1): https://github.com/coreos/pkg/blob/master/capnslog/init.go#L41
So if the pid is 1, we will not log to journal now since its ppid is not1. The current behavior is what you just describe.
I guess it wont make a difference?

Was that added recently? The earlier comments in this report imply that this is not how it behaves.

@crawford No. It added quite a while ago.

Sounds like it isn't working properly then, otherwise I don't think this issue would have come up. Can you double check it?

Docker added optional support to run the contained program as not PID 1 recently, so that might complicate that proposal: https://github.com/docker/docker/pull/26061

I talked to @xiang90 offline. The plan is to leave the existing logic in place (detects the PPID of etcd to determine whether it should use the journal or stdout) and add a flag to override the behavior. Within rkt, the PPID of etcd is 1, so it logs to the journal. The rkt team would like to be able to override this so that it logs to stdout instead, allowing rkt to capture the logs.

@jonboulle @philips @gyuho
Can we add a flag to make etcd log force to stdout only? This is not beautiful, but it does resolve the rkt issue.

I am fine with it.  Maybe this https://github.com/coreos/etcd/issues/5449#issuecomment-225687991?

I think etcd just needs to make capnslog formatter configurable as capnslog.SetFormatter(capnslog.NewPrettyFormatter(os.Stdout, false)).
Maybe add --log-output=[stdout,stderr,journald] flag to etcd?

@gyuho Can you just have a flag --log-to-stdout? /cc @heyitsanthony

--log-output with a comma separated list would have the best future-proofing

@heyitsanthony
Why do we want etcd to log to N places?

@xiang90 the issue is asking logging to two places but I don't have a strong opinion on it. Multi-logging can be added later so long as there's --log-output=<somestring> in the first place.

the issue is asking logging to two places

Yes, I know (https://github.com/coreos/etcd/issues/5449#issuecomment-229721613). But I do not see why it is needed. All I can see is they want a way to force logging to stdout.


[nomad-security-group-rules] allow empty list of allowed inbound CIDRs

https://github.com/hashicorp/terraform-aws-nomad/issues/59
The error is caused by trying to create a SG rule
Error produced in terraform:
Error: One of ['cidr_blocks', 'ipv6_cidr_blocks', 'self', 'source_security_group_id', 'prefix_list_ids'] must be set to create an AWS Security Group Rule

This pull request brings the nomad module inline with how the Vault and Consul modules handle this.  There should be no backwards compatibility issues or downtime.

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

Tests passed. Merging now.

https://github.com/hashicorp/terraform-aws-nomad/releases/tag/v0.5.2


Added support for the AbortRequest action

Background of the AbortRequest action

An AbortRequest action causes the URL Rewrite Module to drop the HTTP connection for the current request. The action does not have any parameters. Use of this action implies that no subsequent rules are evaluated for the current URL after this action is performed.

I also added an example to the sample.
@Tratcher @natemcmaster

Is there an issue tracking this feature work?

@Tratcher It's listed in the check list in https://github.com/aspnet/BasicMiddleware/issues/67 but no dedicated issue for just this feature. Should I open one?

Yeah, there's few enough left on that list that we can open a bug for each (that we think are even possible) and triage them appropriately. There's already a bug for maps.
No fixing bugs that aren't assigned to the current milestone :-)

Implementation looks good to me. I'll let Chris do final sign off.

@muratg for triage.

Agreed with @Tratcher that we should file a bug for each remaining item and close #67. As of this one, this can wait till later. We'll triage once we ship preview1.

Rebased on dev. Can we check this in? @muratg  @Tratcher

https://github.com/aspnet/BasicMiddleware/issues/136 triaged in 1.1.


Add regression test for wrong pci address in VM

What this PR does / why we need it:
This tests introduces regression test, where VM creation is blocked due to wrong PCI address.
Explanation:
For PCI address "0000:YY:XX.0" where XX > 0 and YY > 0.
if XX is (0,1,2) - kubevirt will block it (Bugzilla 1645069 ).
Ff XX > 0 then libvirt will block it ( as seen in the error msg in Bug 1645069)
and then allow only one slot , only 0 when YY is > 0.
Release note:

NONE

This change is

/cc @kbidarkar

Hi @gszasz thanks for pointing this out. I have fixed it.

/retest

/retest

/retest

/test pull-kubevirt-e2e-k8s-multus-1.13.3

/test pull-kubevirt-e2e-k8s-1.13.3


ODIS Quota take cEUR balance into account

Add a new method for cEUR balance and use for quota measurement (add config for minEuroBalance).
https://github.com/celo-org/celo-monorepo/blob/fe6e010e35b92c1e930efe2ea7ad982af344155a/packages/phone-number-privacy/signer/src/signing/query-quota.ts#L222


Added support for carriage return line endings.

Added an or check for CR endings (works for CRLF endings too)

@jst-cyr  - can you double check this locally? I don't have a PC (well that's a lie, I literally JUST got one, but I have nothing setup on it yet). Thanks!


Range is not supported?

But it is for Cortana https://docs.microsoft.com/en-us/cortana/skills/speech-synthesis-markup-language#prosody-element

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aae85d9f-b4f4-fc4d-cb0f-0fc4a1d4e7c9
Version Independent ID: dbd55a99-dbde-a3f3-47a5-ded8309e2748
Content: Speech Synthesis Markup Language - Speech Services - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/speech-synthesis-markup.md
Service: cognitive-services
GitHub Login: @erhopf
Microsoft Alias: erhopf

should we close this one as the SSML doc is updated already? https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/speech-synthesis-markup#adjust-prosody

#please-close
@vitaly-zdanevich We've updated the specification. Range is now supported among other features and attributes. Please let us know if you have any other questions!


[Bug] Jobs limit wrong calculation

*Detailed description of the issue:
I'm using a third-party plugin called EcoEnchants (by auxilor), this plugin adds customs enchantments. One of them is called lumberjack, it's a common feature, but in short, when you break a log, it cut down the entire tree.
My problem is that jobs limit is incorrectly calculated, the amout of income is perfectly calculated, when you break a tree of 5 blocks, you earn five blocks of xp/points/income. But only the broken block is added to the limit.
So, in short : is it possible to count all broken blocks in the limit instead of only broken block, like it works for income ?
Other details
I've tested it with points limit (limit: 1000), the action "break" and oak_log as block.
The enchantment is an "effect" called "mine_vein".
Steps to reproduce :

Break 5 block with an unenchanted axe,
Do /jobs limit -> 5 blocks counted
Break a 5 blocks tree with an enchanted axe with "lumberjack" enchant
Do /jobs limit -> 1 block counted

Jobs: <IP_ADDRESS> MySQL
CMILib: <IP_ADDRESS>
Server: Paper(170) 1.20.1-R0.1-SNAPSHOT
Economy: CMIEconomy Vault: 1.7.3-CMI
Relevant plugins :  EcoEnchants - 10.35.2 + eco -  6.65.3
Thank you in advance for your support, have a nice day. I can provide more information if needed.

Hard to say here exactly what's going on as EcoEnchants is premium plugin, can't really properly test it out. But Jobs can handle quick block breaks if those trigger BlockBreakEvent, what my suspicion here is that EcoEnchants directly modifies income you will get from those actions while not properly updating payment limits, so it's more up to EcoEnchants to add extra line into code for this to be properly recorded as it should be.

Hi, i'm back,
I contacted eco dev and he says that :
"When mining blocks our plugins use built-in spigot methods to break blocks as a player
Which includes calling the block break event"
I've searched a bit where and how they do that thing (i don't code with java so a bit hard, but...)
There is the method i've found : https://github.com/Auxilor/libreforge/blob/master/core/src/main/kotlin/com/willfp/libreforge/effects/templates/MineBlockEffect.kt
There is its method to breakBlocks :
    protected fun Player.breakBlocksSafely(blocks: Collection<Block>) {
        if (plugin.configYml.getBool("effects.use-setblock-break")) {
            blocks.forEach { it.type = Material.AIR }
        } else {
            this.runExempted {
                for (block in blocks) {
                    block.setMetadata("block-ignore", plugin.createMetadataValue(true))
                    this.breakBlock(block)
                    block.removeMetadata("block-ignore", plugin)
                }
            }
        }
    }

I don't have "use-setblock-break" toggled on, i've tested with it, but there is no payment at all.
Fortunately, eco plugins are open source !
I'm sorry, I don't know who can solve my issue, so i'm posting this a bit further here, along i'm discussing with eco dev.
Have a good day, thank you !


Tools GUI windows - disable click through UI background

Closes #934
Closes #749
Additional changes:
Hotfix for What's New panel version check - throws NullReferenceException if working with default values in GlobalConfig (can compare Version with null but not the other way around)

Code looks good, will test in game tonight.


Update spec to require diffSide for changes

Two notes:

I still think that making this a required field is not quite correct given that the vast majority of cases are going to be covered by "right", which suggests a reasonable default
While this does ultimately control which side of the diff is used to present this comment, that feels like a platform implementation detail. It might make more sense to call this "changeType" and make the values "add", "update", and "remove". Making codemodder differentiate between "add" and "update" seems needlessly complicated, though.

While this does ultimately control which side of the diff is used to present this comment, that feels like a platform implementation detail. It might make more sense to call this "changeType" and make the values "add", "update", and "remove". Making codemodder differentiate between "add" and "update" seems needlessly complicated, though.

This tracks closely with "the other" solution that we previously listed as a solution candidate in CodeTF May Describe Comments on Original and Added Code. I felt like we had consensus around the "add diffSide to CodeTF" solution, so I removed it from the ticket, but if we're going to revisit that, then now is the time.
The "other solution" I'm talking about is the one wherein Pixeebot infers the diff side based on the actual diff. This solution differs from the changeType that you've proposed only that it assumes consumers of the CodeTF can figure out the change type themselves by looking at the diff.

all added lines? --> additive, diff side right
changed lines? --> modification, diff side right
all removed lines? --> removal, diff side left

Regardless of whether codemodder explicitly tells the platform the changeType or the platform infers it from the diff, this is a very leaky abstraction, because codemodder must be aware of this behavior so that it can send the correct lineNumber. That is, it must send a lineNumber value corresponding to the new file when the change type is either add or update, and it must send a lineNumber value corresponding to the original file for the remove change type.
In theory, the changeType abstraction gives the platform flexibility to handle this data differently, but because this abstraction is leaky, that's actually not the case. Consider the scenario where the platform decides it wants to move comments for updated changes from the original file to the new file (from left to right). The platform cannot simply decide that comments with changeType == update should now go on the right instead of the left (or vice versa), because the lineNumber is specific to a side.
Because the lineNumber is specific to a side, I think it makes sense to include the side in CodeTF, so that there's no guessing about codemodder's intentions for what that lineNumber field means.

Because the lineNumber is specific to a side, I think it makes sense to include the side in CodeTF, so that there's no guessing about codemodder's intentions for what that lineNumber field means.

After reading through your description, I agree. The idea about automatically identifying which side is really clever and is no doubt possible in principle. However, given that codemodder already necessarily has all of the relevant information (since otherwise it couldn't have generated the change at all), it also seems needlessly complex.
That leaves the issue of whether diffSide should be required. I think we have differing opinions on this but mine is not too strongly held. I mostly feel like making it optional allows for backwards compatibility, and it also seems justified given that there is a reasonable default for the majority of cases.