BigQuery Dataset does not appear to have :name

Hi team,
I was following the example provided at
google-cloud-bigquery-0.26.0/lib/google/cloud/bigquery/dataset/list.rb:80
And it resulted in an Argument Error as seen in the below block.
require "google/cloud/bigquery"
keyfile = 'mykeyfile-token.json'
project = 'my-analytics'

bigquery = Google::Cloud::Bigquery.new(
  project: project,
  keyfile: keyfile
)

bigquery.datasets.all(request_limit: 5) do |dataset|
  puts dataset.name
end

=> ArgumentError: Symbol or String expected, but NilClass given.

When I inspect what a dataset is, I can see it does not have a :name method on it. Is this an error in documentation, or are there situations where there is no name method?
[1] pry(#<MyController>)> dataset.class
=> Google::Cloud::Bigquery::Dataset
[2] pry(#<MyController>)> dataset.methods - Object.methods
=> [:delete,
 :name=,
 :description,
 :description=,
 :location,
 :query,
 :service,
 :table,
 :tables,
 :create_table,
 :created_at,
 :modified_at,
 :etag,
 :project_id,
 :service=,
 :query_job,
 :ensure_service!,
 :gapi,
 :dataset_id,
 :default_expiration,
 :default_expiration=,
 :access,
 :dataset_ref,
 :patch_gapi!,
 :ensure_full_data!,
 :api_url,
 :create_view,
 :gapi=,
 :reload_gapi!,
 :data_complete?]

Appears in documentation at:
http://googlecloudplatform.github.io/google-cloud-ruby/#/docs/google-cloud-bigquery/v0.27.1/google/cloud/bigquery
That dataset.dataset_id is the replacement for name. Maybe just old docs. Shall I PR new docs in here?

Hi Greg, thanks for opening the issue. Apologies for the troubles you are having.
Dataset has both dataset_id and name. So I think you are running into a different problem. (BTW, name can be nil.)
Your pry example is not showing Dataset#name because of Object#name, but it does show Dataset#name=.
Can you post the backtrace of the error? I'm curious where that NilClass is being given as an argument.

The error came from another gem, coderay. I misdiagnosed this as an issue with calling name.
gems/coderay-1.1.1/lib/coderay/helpers/plugin_host.rb:215:in `validate_id'

I had placed a pry (the first ruby section) inside another pry (next to the puts in the second ruby section) and coderay is a dependency of pry. This was my mistake in nesting my debuggers.
Sorry for wasting your time on a rookie mistake!

No problem, glad you got it figured out.


Add server down status

Whenever the backend is down let the user know with a modal.

Hi bro @dev2919 can I work on this enhancement?

Hi, @eldelasfranelas  I see that you are eager to invest your time to help. You can find the link for the backend here
Public Room
Private Room
Send us a PR we will review it and merge it.
Regards ,
Prajeesh Javkar
(Team Vegh)


Use current target list to compute quorum

Do it by calling out into a function which has access to the list, rather than pushing updates in as suggested in #1721.
Fixes #1721 and #1881
The fix for #1881 is racy - if we decide to go for consensus before hearing back that the address refers to ourselves then we will still count ourself.

Note the third commit requires a change to Mesh - https://github.com/weaveworks/mesh/pull/26

How confident are you that this cannot deadlock? determineQuorum is called from the ipam.Allocator actor and requires the mesh.ConnectionMaker actor to respond.

@bboreham this PR updates the mesh dependency to point to a commit which is not in the master repository on github - did you mean to push a branch with a change there also?

I don't have write access to weaveworks/mesh.  However I got the green light to merge.

I updated the dependency and rebased.

Should we make paxos.Propose() assert that quorum > 0 for safety now you don't have to specify it as an argument to NewNode?

Looking good. Did you see @rade's comment above (now marked as obsolete) about GetQuroum?

How confident are you that this cannot deadlock? determineQuorum is called from the ipam.Allocator actor and requires the mesh.ConnectionMaker actor to respond.

The ipam and mesh actors are quite separate, connected only by gossip and by the call-out functors isKnownPeer and quorum.  So as long as incoming gossip is on a separate goroutine the risk seems low.

Rebased to pick up test fix.

re deadlock potential...
The allocator actor thread calls determineQuorum while holding no locks. That in turn calls cm.Targets, which requires the cm actor thread to respond.
The cm actor thread can take RLock on Peers. That is the only code which has the potential to stall that thread.
So logically this is no different from the allocator thread attempting to take an RLock on Peers directly.
Such an attempt can stall if and only if another thread has requested, or actually holds, a WLock on Peers. The former can be stalled by any thread holding a Peers RLock.
So the question is whether any thread calls into the allocator (requiring its actor loop to respond) while holding a Peers RLock or WLock. Note that this doesn't have to be a direct call; it could
happen indirectly via some other thread. That is rather difficult to determine.


VM, NIC and disk hydration

This PR is part of the VM, NIC and disk hydration feature that spans the whole HCI stack:

Design:

https://microsoft-my.sharepoint.com/:w:/p/ndixit/EXvBh8LSdEFLkSbKHmNZiCIBqEJtgiMlkHeoNBiybXH4FA?e=jsqS2J

ADO feature

https://msazure.visualstudio.com/One/_workitems/edit/28572249

Testing

Testing has been executed iteratively as part of the Trailblazer scrum feature delivery. We are tracking testing at https://microsoft-my.sharepoint.com/:w:/p/ndixit/EcEmFhNIOQZOui-qnJu_kxIBMrPD6K8nTg-5Upu0bEm7CQ?e=0F6u6C

These changes include the protobuf changes required to create a new operation HYDRATE

@damanMSFT can you please review this PR? I have already addressed the previous review comments.

/azp run

/azp run


Remove console.log(...) from 'withInputBindings'

Currently withInputBindings logs each slice of inputs values to console and it cannot be disabled.
I suggest making this logging optional or disabling it at all.

Will submit PR shortly


Adopt OCM Placement API (not PlacementRule)

Phase out legacy PlacementRule API and start using OCM's Placement API
See: https://github.com/open-cluster-management-io/placement

Done


stdImage improvements

Tracker

[ ] CreateFromBinary(ByRef b() As Byte, ByVal format as stdImgFormat) As stdImage
[ ] CreateFromDataURL(ByVal sURL as string) as stdImage
[X] CreateFromFile(ByVal sPath As String, Optional ByVal format as stdImgFormat = stdImgFormatDefault, optional byval transparentColor as Long = 0) As stdImage

[X] BMP, GIF, JPEG, PNG, TIFF, WMF, EMF
[ ] WEBP

[X] CreateFromUrl(ByVal sURL As String, Optional ByVal format as stdImgFormat = stdImgFormatDefault) As stdImage

[ ] AutoProxy?
[ ] Possibly remove? stdHTTP should really be used...

[X] CreateFromHBitmap(ByVal hBitmap As LongPtr) As stdImage
[X] CreateFromClipboard() As stdImage
[X] CreateFromIPictureDisp(ByVal picture As stdole.IPictureDisp) As stdImage

[ ] Need an example

[X] CreateFromStdPicture(ByVal picture As stdole.stdPicture) As stdImage
[ ] CreateFromIPicture(ByVal picture As stdole.IPicture) As stdImage

[ ] Need an example

[X] CreateFromExcelIPicture(ByVal picture As Excel.IPicture) As stdImage

[ ] Need an example

[X] CreateFromShape(ByVal shp As Object) As stdImage
[X] CreateFromChart(ByVal chart As Object) As stdImage
[ ] CreateFromHICON(ByVal hicon as LongPtr) as stdImage
[X] Get HBitmap() as LongPtr
[X] Get HICON() as LongPtr
[X] ToBinary(Optional ByVal eFormat As stdImgFormat = stdImgFormatDefault) As Byte()

[ ] Remove hack

[X] ToFile(ByVal FileName As String, Optional format As stdImgFormat = stdImgFormatDefault, Optional ByVal Quality As Byte = 80, Optional ByVal TIFF_ColorDepth As Long = 24, Optional ByVal TIFF_Compression As Long = 6)
[X] ToClipboard()

[ ] Remove hack

[X] ToTempFile(Optional ByVal eFormat As stdImgFormat = stdImgFormatDefault) as string
[X] ToSheet(ByVal ws as Worksheet, Optional ByVal Top as Double = 0 , Optional ByVal Left as Double = 0, optional ByVal compress as MsoPictureCompress) as Object
[X] ToUIControl(Byval oControl as object)
[ ] ToDataUrl(Optional ByVal eFormat As stdImgFormat = stdImgFormatDefault) as string
[X] ToShapeFill(ByVal shp As Object)
[X] ToStdPicture() as stdole.StdPicture

Resources
https://stackoverflow.com/questions/1507385/how-do-i-convert-a-stdole-stdpicture-to-a-different-type

Some examples functional now:
Private Sub UserForm_Initialize()
  With stdWindow.CreateFromIUnknown(Me)
    Call .setOwnerHandle(0)
    .HICON = stdWindow.CreateFromHwnd(Application.VBE.MainWindow.hWnd).HICON
'    .HICON = stdImage.CreateFromStdPicture(Image1.picture).HICON
'    .HICON = stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).HICON
'    .HICON = stdImage.CreateFromFile("C:\Users\sancarn\Pictures\yuumi.png").HICON

    Image1.PictureSizeMode = fmPictureSizeModeStretch
    Set Image1.picture = stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).ToStdPicture
'    Set Image1.picture = stdImage.CreateFromFile("C:\Users\sancarn\Pictures\yuumi.png").ToStdPicture

    Call stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).ToFile("C:\Temp\poop.png")
    Call stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).ToFile("C:\Temp\poop.bmp")
    Call stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).ToFile("C:\Temp\poop.jpeg")
    Call stdImage.CreateFromShape(Sheet1.Shapes("Picture 2")).ToFile("C:\Temp\poop.tiff")
  End With
End Sub


Update logs-ingestion-api-overview.md

We need to make it more explicit that the naming convention (alphanumeric characters and the characters _ and -, and they must start with a letter) also applies to column names of custom tables

Thanks for this @josecons-msft 🥇


Catalog filter

@NEsfandiari
Details:

Added search functionality to homepage sidenav
Combined search with filtering on the catalog page
Fixed noncritical errors on the homepage (children not having key, link not having to, etc)

https://5c115082138e930009af686b--determined-benz-390e9b.netlify.com/

Installed gatsby-plugin-netlify-cache


Handle both cases with Async and Sync calls

exception: "java.lang.Exception: Batch: GHcGGy - Error when reading from Cognite Data Fusion.
	at com.cognite.beam.io.fn.read.RetrieveItemsBaseFn.processElement(RetrieveItemsBaseFn.java:93)
Caused by: java.util.concurrent.CompletionException: com.google.cloud.storage.StorageException: Read timed out
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:331)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:346)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:632)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
	at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:2088)
	at com.cognite.client.servicesV1.executor.FileBinaryRequestExecutor.lambda$downloadBinaryAsync$0(FileBinaryRequestExecutor.java:245)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: com.google.cloud.storage.StorageException: Read timed out
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.translate(HttpStorageRpc.java:233)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.getCurrentUploadOffset(HttpStorageRpc.java:809)

I think my approach here is to be as much as possible on the safe side of things. So even if we should not have it now, but one day later we switch to use threads, that code will capture either of it


Int b 20983 filter columns to be more user friendly duty location

[Agility ticket](B-20983-Latent: Filter columns to be more user friendly - Duty Location)
Summary
SC/TOO & TIO queues do not allow users to search by any match filter for Origin duty location column, Users had to enter the full/exact location in order to find the a match. These changes are to use "ILIKE" & wildcards for querying the results that match the partial string the user would enter.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the MilMov application
Login as a SC/TOO/TIO .
3.Navigate the queue pages: SC has Counseling Queue and PPM Closeout Queue. TOO has Task Order Queue . TIO has Payment requests.
Enter a search criteria in the "Origin Duty Location" field (note: try with any part of the address, i.e. City, State, Zip)
Search results should display matching any of the search criteria provided in the field.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots
https://github.com/user-attachments/assets/cd0ae790-fc8d-4b2b-8195-39ad82b7ed57
https://github.com/user-attachments/assets/3714b3b4-2b46-4651-ac99-2ef182d11827

Had to recreate  a new branch for this pr, test added and ready for review.

@samaysofo There are tests failing related to your changes.

@samaysofo There are tests failing related to your changes.

ok, let i will take a look at it.


Export scaling doesn't work after Sketch 41

It seems that scaling in export dialog is broken after Sketch 41 update.
Problem was caused MSExportRequest command and I guess it's changed in Sketch 41 API.
var scaleSlice = [MSExportRequest requestWithRect:utils.artboardRect scale:scaleValue];
utils.doc.saveArtboardOrSlice_toFile_(scaleSlice, fileName);

I disabled it for fast fix for 41+ versions until I found how it works now. Anyone have idea how it should be now?

Looks like they now define the export scaling options when exporting pages or artboards
function onExportArtboards(context) {
    var sketch = context.api()
    var options = { "scales" : "1, 2, 3", "formats" : "png, jpg" }
    sketch.selectedDocument.selectedPage.exportArtboards(options)
};

...I guess you would have to amend how you export things to achieve this.
see http://developer.sketchapp.com/examples/plugins/exporting/

Thanks @alpower for pointing this one!

No problem!  A lot of people use things like InvisionApp at 2X for prototyping on retina screens, so being able to export at 2X sure would be handy, for doing things like GIFs for more complex transitions.
...Love the tool so far otherwise - really great!


Using of m2m_changed signal

Hello,
I'm using DAL in version 2.3.3 (due to an old Django version)
I tried to use m2m_changed signal from Django to look what data were added or removed. But it seams that django-autocomplete-light remove all links then reconnect the new values even if they are same.

So, is there an another way, from your module to know which data are added only (for example) ?
Did you change this behavior on a more recent DAL version ?

Thank you in advance.

Not that I know of but PR welcome.

Ok, we implemented a short fix for that, I'll try to prepare a PR for you.


[CosmosDB] Apis to redistribute throughput among physical partitions

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[x] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@ravgill, adding new operations to the exsiting API version is considered as breaking change.  Could you follow the steps in 'Breaking Change Review Checklist'  to get it reviewed?

@lirenhe got the approval for breaking change. Please take another look

@ravgill, I left some comments and please ping ARM team to review this PR. Thanks

@ravgill, I saw some open comments in the PR, please let me know it is ready to merge.


OpenVINO vs Torch Inference

Hello,
considering using a GPU for inferencing, will the inference using a openvino IR outperform the torch cuda inferencing in terms of speed?
Thanks, Alex

Hi @alexriedel1, depends on the model. The use of GPU is advantageous in many cases.
OpenVINO accelerates the CPU inference, though.
Here is an example that I ran some time ago using NVIDIA 3090 GPU and i9-10980XE CPU. Please note that these stats are not official and experimental only.

Thanks @samet-akcay !
Though these stats are only experimental, I'd be highly interested to see more of these 😄

We plan to add some jupyter notebooks to show this sort of experimentation

Meanwhile, you could use the following benchmarking script to reproduce the throughput results for gpu and cpu
https://github.com/openvinotoolkit/anomalib/blob/development/tools/benchmarking/benchmark.py


Dependency Gradle Sync Issue

We get the following error:
Failed to resolve: com.littlemango:stacklayoutmanager:1.0.5 Show in Project Structure dialog Affected Modules: app

same issue here, i thought it might be due to ide itself so i repaired it still not fixed

use jcenter() in settings.gradle.kts file

dependencyResolutionManagement {
   //....
    repositories {
        google()
        jcenter()
        mavenCentral()
    }
}

also enable in gradle.properties

android.enableJetifier=true


Release 2.1.1 is missing the git tag 2.1.1

This would be what is stopping the latest automatic update on cdnjs.

Tag is added; give them a few minutes to update.


i18n

As a Visitor, I want to switch languages to EN, DE, UK, and RU so that I can understand what the page says in different languages. Currently, only the home page. See https://trello.com/c/qVcr45X5/317-i18n-integration-2
Acceptance Criteria

[x] localization is not part of this story, translation will be done later by translators
[x] all text on the home page is internationalized
[x] translation files for EN, DE, UK, and RU is present
[x] when I change value in language selector language of the page changes
[x] auto-detection of browser language

Demo
https://deploy-preview-41--wehelpvip.netlify.app/

@allend13 here is internationalization half way integrated

@razbakov I looked into the translation issue. The general implementation seems right, if i use a translation in the template with {{ $t("exchange") }} it works. The menu items are not translated though. The reason seems to be, that the useI18n() returns an object which is not reactive, so it doesnt get updated when the language changes.
I got it to work with { name: computed(() => t('exchange')), to: '/exchange' }, but this adds quotation marks in the string. I need to look into it in more detail to find a better solution, but maybe this info helps you to build up on.

@VOlekh See last comment, it should solve the issue. Can you please take it over?

@amanuela97

this branch has conflicts that must be resolved
auto-detection of browser language

@amanuela97 This branch has conflicts that must be resolved


Unexpected item 'parameters › type_coverage'.

I am trying to set it up but ran into the following error
Unexpected item 'parameters › type_coverage'.

phpstan/phpdoc-parser        1.14.0 PHPDoc parser with support for nullable, intersection and generic types
phpstan/phpstan              1.9.14 PHPStan - PHP Static Analysis Tool
phpstan/phpstan-doctrine     1.3.23 Doctrine extensions for PHPStan
phpstan/phpstan-phpunit      1.2.2  PHPUnit extensions and rules for PHPStan
phpstan/phpstan-strict-rules 1.4.4  Extra strict and opinionated rules for PHPStan
phpstan/phpstan-symfony      1.2.16 Symfony Framework extensions and rules for PHPStan
tomasvotruba/type-coverage 0.0.9 Measure type coverage of your project

php 8.1.14

parameters:
    level: 8
    paths:
        - src
        - tests
    excludePaths:
        - tests/bootstrap.php
        - config/bootstrap.php
    symfony:
        container_xml_path: 'var/cache/dev/App_KernelDevDebugContainer.xml'
    scanDirectories:
        - var/cache/dev/Symfony/Config
    type_coverage:
        return_type: 50
        param_type: 30
        property_type: 70
        print_suggestions: false

includes:
    - vendor/phpstan/phpstan-doctrine/extension.neon
    - vendor/phpstan/phpstan-symfony/extension.neon
    - vendor/phpstan/phpstan-symfony/rules.neon
    - vendor/phpstan/phpstan-strict-rules/rules.neon
    - vendor/phpstan/phpstan-phpunit/extension.neon

I just ran the composer command + added the config in the readme to phpstan.neon. Did I miss something when installing / configuring it? :thinking:

Hi, do you have phpstan extension installer installed?

Hey @TomasVotruba. I don't know how I miss that something like https://github.com/phpstan/extension-installer exists in the first place but I guess that also explains why the line where you mention it in the readme didn't trigger me :see_no_evil:
In case somebody else stumbles upon this: You can alternatively also solve this by adding the following line to your includes section in your phpstan.neon file:
includes:
    - vendor/tomasvotruba/type-coverage/config/extension.neon

Thank you Tomas :pray:

Even if I have installed phpstan/extension-installer before this extension I still need to include that file.
Instead if I install PHPStan, PHPStan Extension installer and then this extension globally the issue does not arise.

Sometimes I have similar glitches. Running composer install helps, as only composer install triggers the extensions in some cases.

Thanks Tomas. It's a subtle issue of https://github.com/phpstan/extension-installer as referenced here https://github.com/phpstan/extension-installer/issues/76#issuecomment-1657099451
It seems that if you have the installer installed globally and locally, the second one does not find the extensions locally. Very strange.

I see. I had similar issues with other dev packages, so I stopped using global scope. It also makes the project vendor locked to your local setup.
Also this leads to version conflicts.


Convert drivers from lvgl_esp32_drivers to a generic format

This project has a few drivers that can be used in any microcontroller, only by writing a configuration file.
There is also the lvgl_esp32_drivers repository which has a lot more drivers, but they are only for ESP32 MCUs.
Are there any plans to bring those drivers to this repository, changing esp32-specific functions to the generic ones? Also, are contributions to convert those drivers being accepted?
Thank you!

We will move all driver directly into the lvgl repo in the next major version (v9). I'm a little bit busy with some projects now but I hope I can back to its development soon.


view timelines: add separate facet_size argument if possible

msp.view_timelines  - the function has size as input parameter, but it is irrelevant for facet grid (only relevant for single chart), so passing any size vector for multiple charts  is not changing size of separate charts – the charts come out in pre- fixed sized (looks like optimized for 3 columns). Not sure if you want to look at this, just mentioning it
Looks like aspect  is changing the length of the charts, and height also stretches the charts. However if I change aspect and height, the font becomes very small. Anyway aspect/height  does not seem most natural way to change the size of separate files.

To be closed by #684


Port logging articles - adapt to .NET docs

Summary

Add code samples that correspond to using the .NET logging
Add Microsoft Extensions logging articles
Update TOC entry to add logging overview, providers, implement custom provider, and logger message

Contributes to: #4567
Preview
✔ Logging in .NET
✔ Logging providers in .NET
✔ Implement a custom logging provider in .NET
✔ High-performance logging in .NET

The updates look good, but I still don't see non-host content.

Ah, yes... I forgot that bit. I'll add it, thanks.

There were some warnings introduced here. Can you fix them @IEvangelist ?

There were some warnings introduced here. Can you fix them @IEvangelist David Pine FTE ?

Good catch, thank you - see https://github.com/dotnet/docs/pull/20875


intermittent hanging in rush cover (on linux)

Describe the bug
rush cover hangs intermittently, confirmed on linux, don't know if it's been seen anywhere else
To Reproduce
git clone https://github.com/itwin/itwinjs-core.git
cd itwinjs-core
rush install
rush build
rush webpack:test
# run enough times to catch it
for i in {1..200}; do rush cover; done

Expected behavior
rush cover ends in a reasonable amount of time, e.g. ever
Desktop:

OS: ubuntu linux
Version 21.04
iTwin.js Version: 3.4.0-dev.3 (3f85b180d67e3183ee9f0194d6dd8c49ed319970)

Additional context
Main thread:
(gdb) bt
#0  lll_mutex_unlock_optimized (mutex=0x4d7b4c0) at pthread_mutex_unlock.c:44
#1  __GI___pthread_mutex_unlock_usercnt (decr=1, mutex=0x4d7b4c0) at pthread_mutex_unlock.c:69
#2  ___pthread_mutex_unlock (mutex=0x4d7b4c0) at pthread_mutex_unlock.c:369
#3  0x0000000001571bf9 in uv_mutex_unlock (mutex=<optimized out>) at ../deps/uv/src/unix/thread.c:351
#4  0x0000000000b7970d in node::NodePlatform::DrainTasks(v8::Isolate*) ()
#5  0x0000000000a4656a in node::FreeEnvironment(node::Environment*) ()
#6  0x0000000000b4b93f in node::NodeMainInstance::Run(node::EnvSerializeInfo const*) ()
#7  0x0000000000acd3f2 in node::Start(int, char**) ()
#8  0x00007f5a6dedffd0 in __libc_start_call_main (main=main@entry=0xa3d930 <main>, argc=argc@entry=7, argv=argv@entry=0x7ffdab890888)
    at ../sysdeps/nptl/libc_start_call_main.h:58
#9  0x00007f5a6dee007d in __libc_start_main_impl (main=0xa3d930 <main>, argc=7, argv=0x7ffdab890888, init=<optimized out>, fini=<optimized out>,
    rtld_fini=<optimized out>, stack_end=0x7ffdab890878) at ../csu/libc-start.c:409
#10 0x0000000000a400ec in _start ()

all threads:

Thread 11 (Thread 0x7f5a5d7fa640 (LWP 1309712) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4972c28 <cond+40>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4972bc0 <mutex>, cond=0x4972c00 <cond>) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at ../deps/uv/src/unix/thread.c:780
#6  0x000000000155e4f4 in worker (arg=0x0) at ../deps/uv/src/threadpool.c:76
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 10 (Thread 0x7f5a5dffb640 (LWP 1309711) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4972c28 <cond+40>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4972bc0 <mutex>, cond=0x4972c00 <cond>) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at ../deps/uv/src/unix/thread.c:780
#6  0x000000000155e4f4 in worker (arg=0x0) at ../deps/uv/src/threadpool.c:76
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 9 (Thread 0x7f5a5e7fc640 (LWP 1309710) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4972c28 <cond+40>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4972bc0 <mutex>, cond=0x4972c00 <cond>) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at ../deps/uv/src/unix/thread.c:780
#6  0x000000000155e4f4 in worker (arg=0x0) at ../deps/uv/src/threadpool.c:76
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 8 (Thread 0x7f5a5effd640 (LWP 1309709) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4972c28 <cond+40>) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4972c28 <cond+40>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4972bc0 <mutex>, cond=0x4972c00 <cond>) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=cond@entry=0x4972c00 <cond>, mutex=mutex@entry=0x4972bc0 <mutex>) at ../deps/uv/src/unix/thread.c:780
#6  0x000000000155e4f4 in worker (arg=0x0) at ../deps/uv/src/threadpool.c:76
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 7 (Thread 0x7f5a6e423640 (LWP 1308522) "node"):
#0  __futex_abstimed_wait_common64 (private=<optimized out>, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=<optimized out>, abstime=0x0, clockid=0, expected=0, futex_word=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=<optimized out>) at futex-internal.c:139
#3  0x00007f5a6df52a3f in do_futex_wait (sem=sem@entry=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>, abstime=0x0, clockid=0) at sem_waitcommon.c:112
#4  0x00007f5a6df52ad8 in __new_sem_wait_slow64 (sem=sem@entry=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>, abstime=0x0, clockid=0) at sem_waitcommon.c:184
#5  0x00007f5a6df52b51 in __new_sem_wait (sem=sem@entry=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>) at sem_wait.c:43
#6  0x0000000001572012 in uv__sem_wait (sem=<optimized out>) at ../deps/uv/src/unix/thread.c:626
#7  uv_sem_wait (sem=0x4967180 <node::inspector::(anonymous namespace)::start_io_thread_semaphore>) at ../deps/uv/src/unix/thread.c:682
#8  0x0000000000c13bd5 in node::inspector::(anonymous namespace)::StartIoThreadMain(void*) ()
#9  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#10 0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 6 (Thread 0x7f5a677fe640 (LWP 1308516) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4d7b514) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4d7b514) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4d7b514, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4d7b4c0, cond=0x4d7b4e8) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=0x4d7b4e8, mutex=0x4d7b4c0) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=<optimized out>, mutex=<optimized out>) at ../deps/uv/src/unix/thread.c:780
#6  0x0000000000b75eeb in node::(anonymous namespace)::PlatformWorkerThread(void*) ()
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 5 (Thread 0x7f5a67fff640 (LWP 1308515) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4d7b514) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4d7b514) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4d7b514, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4d7b4c0, cond=0x4d7b4e8) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=0x4d7b4e8, mutex=0x4d7b4c0) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=<optimized out>, mutex=<optimized out>) at ../deps/uv/src/unix/thread.c:780
#6  0x0000000000b75eeb in node::(anonymous namespace)::PlatformWorkerThread(void*) ()
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 4 (Thread 0x7f5a6ceae640 (LWP 1308514) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4d7b514) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4d7b514) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4d7b514, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4d7b4c0, cond=0x4d7b4e8) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=0x4d7b4e8, mutex=0x4d7b4c0) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=<optimized out>, mutex=<optimized out>) at ../deps/uv/src/unix/thread.c:780
#6  0x0000000000b75eeb in node::(anonymous namespace)::PlatformWorkerThread(void*) ()
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 3 (Thread 0x7f5a6d6af640 (LWP 1308513) "node"):
#0  __futex_abstimed_wait_common64 (private=0, cancel=true, abstime=0x0, op=393, expected=0, futex_word=0x4d7b514) at futex-internal.c:57
#1  __futex_abstimed_wait_common (cancel=true, private=0, abstime=0x0, clockid=0, expected=0, futex_word=0x4d7b514) at futex-internal.c:87
#2  __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x4d7b514, expected=expected@entry=0, clockid=clockid@entry=0, abstime=abstime@entry=0x0, private=private@entry=0) at futex-internal.c:139
#3  0x00007f5a6df49940 in __pthread_cond_wait_common (abstime=0x0, clockid=0, mutex=0x4d7b4c0, cond=0x4d7b4e8) at pthread_cond_wait.c:504
#4  ___pthread_cond_wait (cond=0x4d7b4e8, mutex=0x4d7b4c0) at pthread_cond_wait.c:628
#5  0x00000000015721d9 in uv_cond_wait (cond=<optimized out>, mutex=<optimized out>) at ../deps/uv/src/unix/thread.c:780
#6  0x0000000000b75eeb in node::(anonymous namespace)::PlatformWorkerThread(void*) ()
#7  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#8  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 2 (Thread 0x7f5a6deb0640 (LWP 1308512) "node"):
#0  0x00007f5a6dfdad8e in epoll_wait (epfd=9, events=events@entry=0x7f5a6deacce0, maxevents=maxevents@entry=1024, timeout=timeout@entry=-1) at ../sysdeps/unix/sysv/linux/epoll_wait.c:30
#1  0x0000000001575c07 in uv__io_poll (loop=loop@entry=0x4d7b938, timeout=<optimized out>) at ../deps/uv/src/unix/epoll.c:236
#2  0x0000000001563c88 in uv_run (loop=0x4d7b938, mode=UV_RUN_DEFAULT) at ../deps/uv/src/unix/core.c:389
#3  0x0000000000b7b02b in node::WorkerThreadsTaskRunner::DelayedTaskScheduler::Start()::{lambda(void*)#1}::_FUN(void*) ()
#4  0x00007f5a6df4a947 in start_thread (arg=<optimized out>) at pthread_create.c:435
#5  0x00007f5a6dfdaa44 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:100

Thread 1 (Thread 0x7f5a6deb17c0 (LWP 1308473) "node"):
#0  0x0000000000b79716 in node::NodePlatform::DrainTasks(v8::Isolate*) ()
#1  0x0000000000a4656a in node::FreeEnvironment(node::Environment*) ()
#2  0x0000000000b4b93f in node::NodeMainInstance::Run(node::EnvSerializeInfo const*) ()
#3  0x0000000000acd3f2 in node::Start(int, char**) ()
#4  0x00007f5a6dedffd0 in __libc_start_call_main (main=main@entry=0xa3d930 <main>, argc=argc@entry=7, argv=argv@entry=0x7ffdab890888) at ../sysdeps/nptl/libc_start_call_main.h:58
#5  0x00007f5a6dee007d in __libc_start_main_impl (main=0xa3d930 <main>, argc=7, argv=0x7ffdab890888, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffdab890878) at ../csu/libc-start.c:409
#6  0x0000000000a400ec in _start ()

It hangs while running the @itwin/appui-react tests.

I am going to try rerunning with a debug build of node overnight tonight to get a more detailed callstack on how node is using libuv

I don't seem to get output on cover, not sure what I have misconfigured. I just have:
Rush Multi-Project Build Tool 5.58.0 - https://rushjs.io
Node.js version is 16.14.0 (LTS)

Starting "rush cover"

Executing a maximum of 12 simultaneous processes...

==[ @itwin/appui-react ]==========================================[ 1 of 28 ]==
WARNING: 4 tests skipped in @itwin/appui-react

Add -v for "verbose".

I'll restart the loop until I get it then

I have not been able to reproduce the hang after 200 or so runs, about half of rush cover and half of just core-backend tests.
I have only reproduced:
  1) ECSqlStatement
       should restart query:

      AssertionError: expected +0 to be at least 1
      + expected - actual

      -0
      +1

      at /home/mike/work/itwinjs2/core/backend/src/test/ecdb/ECSqlStatement.test.ts:238:14

Which I will look for/make a separate issue for

In reality I have a core dump from when I first saw the hang running rush cover where I got the posted stacks, so I'll look at that again but I wasn't able to see anything in it the first time I looked, I don't know enough about the functions I see there.

I can no longer reproduce this on master. Need to check if people are still seeing this in rush cover then close.

I can tell you that previously this was affecting probably one of every two PRs and now appears to have ceased completely.

closing until there's evidence it's still around


Make access to device data and config consistent across drivers

Is your enhancement proposal related to a problem? Please describe.
Drivers usually need to access data and config fields from struct device. If one looks at drivers/, there seems to be a few different ways of accessing those fields. I think they can be classified in 3 groups:

Some drivers access dev->config and dev->data directly (I think this is the majority of drivers). In this case void * is not explicitly cast to its type.

https://github.com/zephyrproject-rtos/zephyr/blob/0f949caee12441dd4996017210d2d05971b3cf23/drivers/pwm/pwm_stm32.c#L266-L267

Some drivers provide helper macros like DEV_CFG or DEV_DATA. These macros usually perform an explicit cast to the actual config/data type.

https://github.com/zephyrproject-rtos/zephyr/blob/0f949caee12441dd4996017210d2d05971b3cf23/drivers/serial/uart_stm32.c#L45-L60

Some drivers provide helper inline functions like get_dev_config or get_dev_data. The return type of these functions is the actual config/data type, but in most (if not all) cases no cast is performed inside.

https://github.com/zephyrproject-rtos/zephyr/blob/0f949caee12441dd4996017210d2d05971b3cf23/drivers/serial/uart_nrfx_uarte.c#L175-L183
Describe the solution you'd like
I'd like to have consistency across drivers, that is, agree on a pattern, document it and convert all drivers. I think case (1) is the simplest and most common one, so I'd vote for that option.
Describe alternatives you've considered
N/A
Additional context
Any of the current solution (including explicit cast) violates MISRA 11.5 rule "A conversion should not be performed from pointer to void into pointer to object" (advisory category, though).

API meeting:

Approach 1. selected as the preferred approach, due to it being the most natural given the current variable names
The documentation needs updating: doc/reference/drivers/index.rst


NdisMQueueDpcEx return value clarification

NdisMQueueDpcEx documentation states:

If the driver requested a DPC for a CPU, and NDIS indicates that it did not schedule that DPC, the DPC was not scheduled because a DPC was already scheduled for that CPU.

Why would a CPU with already scheduled DPC prevent another DPC from being scheduled to it?
Could someone clarify the meaining here?

Hi @I-gor-C , good question. I'll ask the NDIS team to see what the original intention behind that sentence is, and update it if need be.

After some discussion, the NDIS team agrees that the wording here is a bit vague. Saying "a DPC was already scheduled" makes it sound like NDIS couldn't schedule the DPC due to some other random DPC being there already.
The true meaning is that NDIS has one DPC object for this interrupt/processor pair, so if that DPC is already scheduled then NDIS won't schedule it. Does this wording make more sense?
"If the driver requested a DPC for a CPU, and NDIS indicates that it did not schedule that DPC, then the DPC was not scheduled because the DPC that maps to this interrupt/processor pair was already scheduled for that CPU."

Makes perfect sense, thanks!

Great! You're very welcome. I'll go ahead and update the page, then. Thanks for pointing this out!


AccessionViolationException occurred

When I played this image, an exception occurred, but it played well in Edge:
System.AccessViolationException:“Attempted to read or write protected memory. This is often an indication that other memory is corrupt.”

I converted the format using ffmpeg, it played successfully, but there were ghosts image.

I'll look into it

Should be fixed in v1.4.1

Thank you, it’s playing well now


Update overview of search typo

Update overview of search document tiny typo

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Fixes #1322 Feature/tclune/#1332 toggle timers on off

Description

Added switches to activate global profiling.    Much cleanup ensued.
Related Issue

#1322
Motivation and Context

How Has This Been Tested?

C12 GEOSgcm
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[X] I have tested this change with a run of GEOSgcm (if non-trivial)
[X] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[X] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

Hmm.  Build and test worked on my laptop and discover with ifort ...  investigating.

Ah - there are obsolete unit tests.   Fixing.

Argh.  Bits of the ADAS use some of the MAPL interfaces that I thought maybe were not used externally ... had to reintroduce some files (and unit tests).

@tclune The CHANGELOG conflict was a bit crazy. Can you take a look and make sure the CHANGELOG here looks good?

I only spotted a duplicate entry which is now removed. (Forcing CI to run again.)

Okay. I tested this and it works, but there is also some weird output. I think something isn't quite right with the SetServices.
Is this the expected output?

I need to look into it, but I think that is pretty much the way we expect it now.  Set services of children are now registered and called after the parent set services completes.  So it flattens everything in that sense.   There is still a nesting of calls to the generic setservices though, so I'm a bit confused.   It may just be the timers are not where the would be best located.


Adjust to change in signature of Query::par_for_each

Fix for changes in Bevy from commit bevyengine/bevy@c5e89894f45e694f882a0e2831af1d2452bac257 , which removed the task_pool parameter from Query::par_for_each

Thanks!


du-dust: 0.6.2 -> 0.7.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/bootandy/dust/releases.
meta.description for du-dust is: "du + rust = dust. Like du but more intuitive"
meta.homepage for du-dust is: "https://github.com/bootandy/dust"
meta.changelog for du-dust is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5/bin/dust passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 0.7.5 with grep in /nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5

found 0.7.5 in filename of file in /nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5

directory tree listing: https://gist.github.com/12f26007c8f9719891d79034354300aa

du listing: https://gist.github.com/fc2bbfc7a6aa6c02f82a2df4d7636b78

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
du-dust

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A du-dust https://github.com/r-ryantm/nixpkgs/archive/add1980208df72b706901d1f6331131b37b2badc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5
ls -la /nix/store/2fddnd0xpqzkbca2pfifgcn2pv26w0zy-du-dust-0.7.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

du-dust

Maintainer pings
cc @infinisil @SuperSandro2000 for testing.

Result of nixpkgs-review pr 138896 run on x86_64-linux 1

1 package built:

du-dust


Docs user access

Signed-off-by: prmellor<EMAIL_ADDRESS>DOCUMENTATION UPDATE
Adds a new procedure to the Managing account access in OpenShift Streams for Apache Kafka guide.
The procedure describes how an org admin can grant access for users to view other users.
Once set, the user can view and assign other users to Kafka instances.

LGTM

LGTM


Support for extent

Hi!
I need support for extent but I fail to get it to work :/

extent
composite image on background color canvas image.
gm("img.png").extent([width, height, options])

I tried to add:

if ( "extent" in this.options ) {
  const extentArgs = this.options.extent.match(cropSpec);
  const extentWidth = extentArgs[1];
  const extentHeight = extentArgs[2];
  img = img.extent(extentWidth, extentHeight);
}

to "lib/ImageResizer.js" just before the check for croping. And in the config i added:
"extent": "3000x3000",
Then I did:
make clean
make
npm run update

It compiles and I can run the script but the extent does not seem to be applied.
So I guess I am missing some important step?

Guess something just went wrong when updating, as it seems to work with this code.


7.1 broke Crashpad

Hello,
since today's update to 7.1 crashpad and/or REST do not work correctly. Shaders using normals and motion vectors stopped working. Immerse RTGI stopped applying GI either.
Using ReShade 6.3.3.
Here I have test images with MXAO only, with crashpad normals and finished image with all my shaders applied.

I doubt they updated DLSS since there was no reason to (I think of Square Enix of being rather conservative with DLLs).

I managed to fix the motion vectors but the shader seems to change after some time again.

Exactly this yeah. Well in any case, hopefully the crashpad gets updated for 7.1 !

Thanks for the heads up, I'll take a look over the weekend or so

Should be good now (see<PHONE_NUMBER>04e022fb54f0519859da552b071151)


feature: Add a rake for contract owner

When the cellars collect fees a configurable % should go to the contract owner as a fee.

Delivered with https://github.com/VolumeFi/cellars/commit/c1168765f623e3c417b76c4840769503231b11ab


first pass at en-stability

This PR implements & tests EN_stability. A few concerns:

the text describing the test was a bit hard to follow; I assumed that the test for density spikes proceeded if and only if the first threshold failed (delta rho < -0.03 kg/m3) - otherwise, the subsequent spike check would always flag every level.
McDougall refers to salinity measured in psu, but the WOD definition document reports salinities as unitless; is there a unit conversion that needs to be done?

In other news - this completes all outstanding qc tests save the track check. The one clear result coming from our early machine learning study, is that we don't have enough qc tests implemented yet to make a final qc decision. With our current set of qc tests, about half of the profiles that should be flagged in quota never are. Let me know what other tests should be introduced, so we can get as many of them implemented as possible before Hamburg.

Hi Bill, thanks for implementing this. Salinity is unitless but PSU is often put as the unit (e.g. https://en.wikipedia.org/wiki/Salinity#Seawater).

Hi Bill, just to let you know that there is a converter to potential temperature in util/obs_utils.py. I will merge the pull request for now, though, as the test shouldn't be that sensitive to the way this conversion is done.


Not all quest touch controller buttons working

When using the ARVRController in GDScript and querying the button state with
is_button_pressed not all buttons from the Oculus Touch Controller work; I tested the following ids that seem not to work even though they are set probably correctly set inside ovr_mobile_controller.cpp:
is_button_pressed(14)  # ovrButton_LThumb / ovrButton_RThumb
is_button_pressed(10)  # ovrTouch_ThumbUp
is_button_pressed(12)  # ovrTouch_IndexPointing

Button 11 is_button_pressed(11) # ovrTouch_IndexTrigger is toggled; but I'm not sure if it is the correct gesture reported for 11 or not.
Inside the oculus_quest_mobile plugin as far as I can tell everything seems to be set correctly; maybe the issue is somewhere in arvr_api->godot_arvr_set_controller_button

I started looking a bit deeper into this issue. Here are my findings so far (I hope my analysis is correct):
The problem starts in godot/main/input_default.cpp at this line:
https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/main/input_default.cpp#L762
there it is checked if the pressed button id (p_button) has an assigned mapping (which it has not for several of the button ids used). The comment there says that unmapped buttons are ignored because at this point it is not known if it is a button or an axis.
Changing line https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/main/input_default.cpp#L765
to
return _button_event(p_device, p_button, p_pressed);
seems to solve the issue for the buttons (because now all unmapped buttons are just passed through).
But not doing this has probably a good reason. So looking further where the button mappings come from I found several .txt files in the same folder like this one here:
https://github.com/godotengine/godot/blob/master/main/gamecontrollerdb.txt
From all these txt files a .cpp file is autogenerated at compiletime (godot/godot/main/default_controller_mappings.gen.cpp) that contains the strings used in input_main.cpp to parse and set up all the known controller mappings.
Each of these files has a section for Android controllers; but so far they do not contain the Oculus touch controllers.
What happens instead is that in the code here https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/main/input_default.cpp#L209
the fallback_mapping is chosen which on android is this mapping:
https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/main/godotcontrollerdb.txt#L20
and it only has the buttons (0,1,2,3,4, 6,7,8,9,10) mapped.
So I tried to add a new entry for an Oculus touch controller like this one here:
4f63756c757320546f75636820526967,Oculus Touch Right Controller,pressy:b1,griptrigger:b2,enter:b3,touchy:b6,touchx:b7,thumbup:b10,touchindextrigger:b11,indexpointing:b12,lthumb:b14,indextrigger:b15,joyx:a0,joyy:a1,analogindextrigger:a2,analoggriptrigger:a3,platform:Android,
But this alone did not work. The controller was detected correctly but no buttons were detected because I chose arbitrary button names. In godot this function here
https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/main/input_default.cpp#L959
checks only for known button names which are at the moment
"a", "b", "x", "y", "leftshoulder", "rightshoulder", "lefttrigger", "righttrigger", "leftstick", "rightstick", "back", "start", "dpup", "dpdown", "dpleft", "dpright", "guide"
I'm not sure what the right solution here would be.
Add meaningful names for VR controllers here?, or map all vr controller buttons to only the known names?
Maybe there is also a much simpler solution to this problem (like adding at runtime a new controller mapping to InputDefaults from the plugin; but I could not find a way to do this)
Also in https://github.com/godotengine/godot/blob/master/core/os/input_event.h and https://github.com/godotengine/godot/blob/6d6d4371467a94c01418e9d475e994fe61b7b4d0/core/global_constants.cpp#L472 are constants defined that need to be considered I think.

I just tested it and it works great; now all controller button presses and button touches are recognized!


[Driver][Tests] Disable failing tests as they're affecting PR testing.

rdar://103867585

@swift-ci Please smoke test and merge

@swift-ci Please smoke test and merge


onedatastore safe_dirs shouldn't be an array

...should be a space separated list
This fixes an issue where modifying safe_dirs results in an error from the provider:
Error: /Stage[main]/Main/Onedatastore[cephds]: Could not evaluate: Execution of '/usr/bin/onedatastore update cephds /tmp/onedatastore-cephds20161208-13878-9oyenf --append' returned 255: [DatastoreUpdateTemplate] Cannot update template. Parse error: syntax error, unexpected VARIABLE, expecting EQUAL or EQUAL_EMPTY at line 6, columns 90:94
.. which is caused by this line in the nebula datastore template:
SAFE_DIRS = "["/tmp/dir1 /tmp/dir1"]"
should be
SAFE_DIRS = "/tmp/dir1 /tmp/dir2"
This is fixed by making safe_dirs no longer an array, and specifying as a space separated list (similar to ceph_host and bridge_list)

I would recommend to keep the array in the type and do data munging on provider level.
This would keep the type declaration as is.

I considered that, but decided to make it a space separated list to be the same as ceph_host and bridge_list; this way all the onedatastore parameters that can take multiple values are specified the same way.
(Note also that specifying safe_dirs on a onedatastore doesn't work as it is currently (either passing an array or a string to the type causes the provider to fail with the error above) so I don't think changing safe_dirs from array to space separated string would be breaking any config for anyone.)
If we want to make safe_dirs an array I think we'd need to make ceph_host and bridge_list also arrays, which would be a breaking change for current onedatastore configs. (This would bring this in line with the other types, though -- onecluster uses arrays for hosts/vnets/etc and onetemplate uses arrays for disks/nics/etc.)
Let me know what you think--

I'm all in favor of unifying parameter types and since we've just done a new major version which hasn't yet been pushed to the forge, this would be the time to make a BC-breaking change if we want to.


[docu-2649] Merge linux docs

Signed-off-by: angel<EMAIL_ADDRESS><Explain your change!>
docu-2649
I opted to use bullets over a table here. I wrote the urls so they wouldn't depend on the front matter of the individual linux docs.
This also contains {{site.mesh_product_name}} in place of mesh/kuma.

Closing this PR (but keeping the branch) until we start working on the Kuma 2.1 IA rework.


Improve failure message on test failure.

These tests are failing for me on my machine after downloading robotframework and running:
python utest/run.py -q running
The failure message was just:
AssertionError: FAIL != PASS
With this PR it is:
(py311_tests) λ python utest/run.py -q running
======================================================================
FAIL: test_create (test_imports.TestImports.test_create)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 33, in run_and_check_pass
    assert_suite(result, 'Suite', 'PASS')
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 16, in assert_suite
    assert_equal(suite.status, status)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 181, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 230, in _report_inequality
    raise AssertionError(msg)
AssertionError: FAIL != PASS

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 52, in test_create
    self.run_and_check_pass(suite)
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 41, in run_and_check_pass
    raise AssertionError('\n'.join(full_msg)) from e
AssertionError: No keyword with name 'My Test Keyword' found.

======================================================================
FAIL: test_resource (test_imports.TestImports.test_resource)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 33, in run_and_check_pass
    assert_suite(result, 'Suite', 'PASS')
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 16, in assert_suite
    assert_equal(suite.status, status)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 181, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 230, in _report_inequality
    raise AssertionError(msg)
AssertionError: FAIL != PASS

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 67, in test_resource
    self.run_and_check_pass(suite)
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 41, in run_and_check_pass
    raise AssertionError('\n'.join(full_msg)) from e
AssertionError: No keyword with name 'My Test Keyword' found.

======================================================================
FAIL: test_variables (test_imports.TestImports.test_variables)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 33, in run_and_check_pass
    assert_suite(result, 'Suite', 'PASS')
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 16, in assert_suite
    assert_equal(suite.status, status)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 181, in assert_equal
    _report_inequality(first, second, '!=', msg, values, formatter)
  File "X:\robocorpws\robotframework\utest\..\src\robot\utils\asserts.py", line 230, in _report_inequality
    raise AssertionError(msg)
AssertionError: FAIL != PASS

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 76, in test_variables
    self.run_and_check_pass(suite)
  File "X:\robocorpws\robotframework\utest\running\test_imports.py", line 41, in run_and_check_pass
    raise AssertionError('\n'.join(full_msg)) from e
AssertionError: Variable '${MY_VARIABLE}' not found.

----------------------------------------------------------------------
Ran 296 tests in 2.281s

FAILED (failures=3)

@pekkaklarck @yanne any reason not to merge this?


PDCL-6554: guard against spreading non iterable values

Description
If currentViewDecisions is undefined, trying to spread it will throw an exception.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (non-breaking change which does not add functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA or I'm an Adobe employee.
[ ] I have made any necessary test changes and all tests pass.
[ ] I have run the Sandbox successfully.

@jfkhoury looks good to me, but I would fix the cause. The cause is because we returned in viewCache viewStorage[viewName] which means if there are no decisions for a specific view we would get undefined. I propose to return a empty array. Here is the PR: https://github.com/adobe/alloy/pull/750


Deploy cycle slurm ndv4 (Added config file with pyxis+enroot)

-Added a config file (config_pyxis_enroot.json) to do complete deployment including SLURM pyxis+enroot container support).
-Updated config.json

Updated readme file

Depending on the fate of #637, the lists of projects files might require some changes.

yes, I like #637

included common_functions.sh in the configuration files.


x/build: run makemac under systemd

The x/build/cmd/makemac "daemon" is currently running in a screen session in a Linux VM on MacStadium keeping the OS X VMs happy.
That machine has never lost power, but we shouldn't be assuming that.
This is a TODO to run it under systemd instead of screen.

Reopening to deploy it.
I've fixed this machine to have our shared ssh key.
@jessfraz, want to deploy?
http://go/go-builders-ssh for the ssh key to:
$ ssh -i that/key<EMAIL_ADDRESS>
Then the sudo to root password is in http://go/go-builders-macstadium

omg yes eek im nervous
On Wed, Jun 21, 2017 at 2:21 PM, Brad Fitzpatrick<EMAIL_ADDRESS>wrote:

Reopening to deploy it.
I've fixed this machine to have our shared ssh key.
@jessfraz https://github.com/jessfraz, want to deploy?
http://go/go-builders-ssh for the ssh key to:
$ ssh -i that/key<EMAIL_ADDRESS>Then the sudo to root password is in http://go/go-builders-macstadium
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/20224#issuecomment-310163513, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABYNbDRh5U-_gUzyavYuzFpVu8VqyaX-ks5sGV8vgaJpZM4NP8RF
.

--
Jessie Frazelle
4096R / D4C4 DD60 0D66 F65A 8EFC  511E 18F3 685C 0022 BFF3
pgp.mit.edu http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3

It's all running in systemd now, just had to make a modification which is opened in https://go-review.googlesource.com/c/46332/


torch.tensor error

TypeError: can't convert np.ndarray of type numpy.object_. The only supported types are: float64, float32, float16, complex64, complex128, int64, int32, int16, int8, uint8, and bool.
line no 91:
self.cross_entropy = torch.nn.CrossEntropyLoss(weight=torch.tensor(np.array(self.cw_dict.values())).float().to(self.device))

You can try this fix:
weights = [float(value) for value in self.cw_dict.values()]
# Now convert the list of floats to a numpy array, then to a PyTorch tensor
weights_array = np.array(weights).astype(np.float32)  # Ensuring the correct dtype
weights_tensor = torch.tensor(weights_array).to(self.device)
self.cross_entropy = torch.nn.CrossEntropyLoss(weight=weights_tensor)

I updated the trainer.py accordingly.


Wrong nginx root directory

Root directory was changed on commit #4  to /usr/local/share/janus/html/demos/ and this causes some resources used by the pages to be unavailable  (e.g., css folder located on /usr/local/share/janus/html/). Setting the root dir to /usr/local/share/janus/html/ fixes this issue.

Ok, have updated it, I will rebuild 1.2.3

Everything working as expected. Thanks!


Improved docs, fixed clippy warnings, fixed cargo fmt

When reading the code I made some minor improvements I wanted to share. Notably, I tried to make the usecase for Bech32 more clear and fix all clippy warnings and "incorrect" formatting.
Have you thought about introducing a CI (e.g., via GitHub actions) which checks against cargo audit, cargo clippy and cargo fmt?

Interesting. I'll circle back after #41 is merged. We'll probably need a rebase then as well.

The changes look good, some transformations from index to iterator loops might even make the code faster.
The only problem I don't have a good solution for right now is how to handle the rustfmt::skip attribute in older rust versions (before macros were scoped). Currently it makes our tests fail for rust 1.22. Maybe we can make the attribute conditional and only run rustfmt with more recent rust versions. But I fear the error occurs when parsing the AST, so even disabling the code with cfg won't help. What we could do in that case is removing the attribute using sed when running the 1.22 test since it isn't needed there anyway, but that's an ugly hack.
If we accept rustfmt changes we should definitely add a rustfmt check to our already existing CI pipeline otherwise non-conforming code will be checked in again. Clippy is a bit of a problem since not all fixes are compatible with older rust versions. cargo audit seems most useful as a cron job and not for every PR, we could activate weekly builds in travis and only run it on master.

Needs rebase.

Is there a reason to support Rust 1.22? Maybe it could be edition = '2018'? :-)

The rationale for older rust versions is given in rust-bitcoin/rust-bitcoin#338, although I can't remember why it's exactly 1.22. 1.24 seems to be the version we really want to support, but I fear that won't help with our problem.

Hm... okay, so I don't see any easy way of supporting rustfmt's skip. #[rustfmt::skip] does not work in 1.22.0, Clippy lints on #[cfg_attr(rustfmt, rustfmt_skip)] and I think also don't think that #[warn(clippy::deprecated_cfg_attr)] will work in 1.22 either nor should it be used. I just bypassed the formatting so that not to generate too much hassle with this PR.

Regarding cargo audit: having it run on every PR prevents pulling in already vulnerable dependencies -- who knows? :-)

I would be glad if you could do it :-)

Oh, I just noticed that there are merge conflicts now. I'll try to rebase.

Thank you @sgeisler! The CI should catch everything now. Having cargo audit run on every push might still be a good (and easy to implement) idea. But it could be added at a later time and issue.

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  Oh yeah, I totally forgot about that. Will amend the last commit tomorrow.                                                                                From<EMAIL_ADDRESS>January 11, 2020 23:46To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [rust-bitcoin/rust-bech32] Improved docs, fixed clippy warnings, fixed cargo fmt (#42)  Thank you @sgeisler! The CI should catch everything now. Having cargo audit run on every push might still be a good (and easy to implement) idea. But it could be added at a later time and issue.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

I though about cargo audit again and it doesn't make much sense for us anyway since we don't have any dependencies.

You don't have dependencies now ;-)


Remove sudo requirement from travis configuration

This will speed up builds. The offender is the libmysqlclient-dev apt package.

Resolved in #256


Add an experimental feature to do validation of the Swift Swift parser.

Add the experimental feature ParserValidation. When enabled, the new Swift Swift parser will be run on each source file. When the C++ Swift parser produces no diagnostics, this will also check that the Swift Swift parser produces no diagnostics. This helps us ensure that we are getting valid parses for well-formed code.
Note that this can be combined with ParserRoundTrip.
Depends on https://github.com/apple/swift-syntax/pull/733

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test macOS


Is it possible to drag a FAB without activating its click event?

<div class="fab-add" ngDraggable>
     <button mat-mini-fab color="primary" (click)="runStuff()" >
          <mat-icon>add</mat-icon>
     </button>
</div>

Just some parting thoughts, but haven't tried any of this code out myself.

Could you get away with something like an $event.stopPropogation() in the containing div
Have you tried adding ngDraggable to the button directly? Will that work for you?
Can you use different events than click, such as mouseup?
https://stackoverflow.com/questions/6042202/how-to-distinguish-mouse-click-and-drag

You can check if the FAB moved or it was only clicked.
  <div ngDraggable (endOffset)="onMoveEnd($event)">
      <button (click)="runStuff()">Add</button>
  </div>

  lastPos = { x: 0, y: 0 };
  offset = { x: 0, y: 0 }

  runStuff() {
    if (this.offset.x === 0 && this.offset.x === 0) {
      console.log('clicked')
    }
  }

  onMoveEnd(event) {
    this.offset = { x: event.x - this.lastPos.x, y: event.y - this.lastPos.y };
    this.lastPos = event;
  }


Add changes to incubator superset

Changes in chart description styles for dashboards
Update port in entrypoint

Can we see the before/after on the margins?

@mistercrunch yes of course, the change it's in the view but I want to apply the recomendation of @hughhhh, In some time I will add some images for apreciate the change.

Previous margin 5px to all sides

New possible change margin just for top and bottom

Codecov Report

Merging #6397 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6397   +/-   ##
=======================================
  Coverage   77.31%   77.31%
=======================================
  Files          67       67
  Lines        9581     9581
=======================================
  Hits         7408     7408
  Misses       2173     2173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66b046...58e7a53. Read the comment docs.

Please update the PR title to be a bit more specific.

I guess, this PR is superseded by 6504 with respect the changes to docker-entrypoint.sh.

@phoenix24 I think that you have the reason about PR is superseded in de docker-entrypoint.sh. I will close this PR and add just another for the changes in views thanks !.


vault-bin: 1.11.0 -> 1.11.1

Description of changes
https://nvd.nist.gov/vuln/detail/CVE-2022-36129
https://discuss.hashicorp.com/t/hcsec-2022-15-vault-enterprise-does-not-verify-existing-voter-status-when-joining-an-integrated-storage-ha-node/42420
vault (non-bin) addressed in #182375
Separately bumping 22.05.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

1.11.2 was just released, could you update to that https://github.com/hashicorp/vault/releases/tag/v1.11.2

That would require me to run all the tests again and spin up a machine to test darwin. I'm just interested in addressing CVE-2022-36129 - the actual maintainers are free to do further bumps thereafter.

@risicle fair enough.


Make smtp_user and smtp_password optional

Not all SMTP servers require authentication (e.g. those on localhost) so make this optional.

A better approach would be to set defaults to None in airflow/configuration.py

Ah, of course.  I hadn't realised (until looking earlier) that there was a Python default as well.  I'll close this PR and raise a new one with a clean branch (BTW I had to use an empty string rather than None)

raised #773


Multigraph rules fixes: bialgebra

I have covered the three implementations of bialgebra in rules.py, basicrules.py and editor_actions.py. Let me know if that looks alright to you.

I don't claim to fully understand what is going on here, but if you say that this indeed correctly implements the bialgebra rule and deals with all the weird edge cases you can have when you work with a multi-graph, then I'm happy to merge it.

I have tested with the weird cases and I believe it is correct. I can't guarantee that I haven't missed anything but previously the bialgebra rule was completely broken so this is at least an improvement.
Few comments:

The bialgebra in editor_actions.py is the one previously in basicrules.py modified to work with multiple edges and self-loops. Whenever there are no multi-edges, its behavior should match the one previously.
I have made the basicrules.py version use the bialgebra from editor_actions.py so there is less duplication.
The rules.py version of bialgebra is supposed to be used with automated rewrite strategies and it expects the number of vertices to always decrease. Whenever we have multiple edges between two nodes or self-loops, the number of vertices either stays the same or increases. So I have simply added a condition in the matcher that doesn't match any time there are multiple edges between those nodes or self-loops.


[5.1] Add query builder resolver

People may want to extend Query\Builder in order to add methods, etc.
Currently, although not impossible, it is incredibly heavy and hacky to do so, as the class is hardcoded.
The attached commit is simply a POC. Usage example:
DB::setQueryBuilderResolver(function ($connection, $grammar, $processor) {
    return new CustomQueryBuilder($connection, $grammar, $processor);
});

On a related note, $grammar and $processor parameters of  Query\Builder::__construct() may be made optional, as we can get them from $connection. This would let simplifying the above code.
Personally, I'd even add the possibility to pass a class name:
DB::setQueryBuilderResolver(CustomQueryBuilder::class);

Additional notes:

Inspired by, for instance, 7584d0f813edd9762d7558e218be3cebdb502d09.
Similar work may be done for Schema\Builder, mainly for consistency.

Why not just make the query builder macroable?

Hacky? How's it any hackier than any other class using the Macroable trait?

Like, take for example the string class. That's stateless by design, so I don't think the macro stuff there is hacky.

Macroable seems fine too. Rather, wonderful. Both techniques seem acceptable to me. Your pick.
Do you agree on the following points?

Many people may wish to extend the query builder, so anyway, we should provide a convenient way to do so (as I said, currently it's very heavy and dirty in order to extend it).
Having to pass grammar and processor to Query\Builder::__construct() is redundant most (if not all) of the time. We could make these parameters optional. For instance, Schema\Builder::__construct() infers grammar from the connection.

The two things aren't even really mutually exclusive. However, the query builder already has a __call method, I'm not sure how to make it jive with Macroable... I assume you can override it and combine them?

I don't know why I hadn't spotted it in my tests, but it seems that, unlike regular methods, the class __call() has precedence over the trait __call():
trait Sometrait {
    public function __call($method, $params) { return 'Sometrait::__call()'; }
}
class Someclass {
    use Sometrait;
    public function __call($method, $params) { return 'Someclass::__call()'; }
}
(new Someclass)->blahblah(); // 'Someclass::__call()'

As a result, the query builder triggers its own __call() and the macro never gets triggered…
I'm unaware of a way to call the trait __call() from inside the class__call(), is it possible?

@taylorotwell https://github.com/laravel/framework/blob/5.1/src/Illuminate/Cache/Repository.php#L16-L18

Looks like this is possible, see this answer. (thanks ircmaxell!)
I have implemented it successfully. Good thing, if the method doesn't exist we get a BadMethodCallException too, only with a different message (the one from Macroable instead of the one from Builder, who becomes unreachable).
Though, I haven't examined the situation about where*() calls.
Another possibility would be to lookup $this->macros from inside the Builder class.

@vlakoff you're overthinking this a little. After aliasing Macroable@__call, all you need is to add these 3 lines the the beginning of Builder's __call method:
public function __call($method, $parameters)
{
    if (static::hasMacro($method)) {
        return $this->macroCall($method, $parameters);
    }

    if (Str::startsWith($method, 'where')) {
        return $this->dynamicWhere($method, $parameters);
    }

    $className = get_class($this);

    throw new BadMethodCallException("Call to undefined method {$className}::{$method}()");
}

Indeed. This solution looks really great. :+1:

Query macros have been added to 5.1.

For reference, implemented in https://github.com/laravel/framework/commit/60ecc104741e083e37d01fcde824abf853537a5a.


Change the docker-tag usage text to be clearer

- What I did
Changed the tag command usage text to be clearer regarding the order of the images.
Closes #28204
- How I did it
Changed the Use field at cobra.Command in cli/command/image/tag.go
- How to verify it
Run
$ docker tag --help

and expect to get:
Usage:  docker tag SOURCE_IMAGE[:TAG] TARGET_IMAGE[:TAG]

Create a tag in the TARGET_IMAGE repository that refers to SOURCE_IMAGE

Options:
      --help   Print usage

this is not actually clearer. please extend the command description to describe which is the new tag being created.

@glensc are you suggesting adding the following line below "Tag an image ...":

For example, docker tag httpd repo/httpd:v2 will tag the local image httpd into the repo repository with v2.

Thanks

@ripcurld00d yes, add example. but your message assumes that tagging needs remote, i.e you're mixing tagging and pushing commands. the tagging is always "local".

For example, docker tag httpd repo/httpd:v2 will create tag named httpd referencing to repo/httpd:v2

perhaps add more examples, for example tagging with commit hash as well.

I am afraid adding more examples will make it too much detailed.
I believe that if we are going to add an example, it has to be the most common use case.

/cc @aaronlehmann @stevvooe for suggestions on making this clearer

Maybe we should take a cue from traditional unix utilities.
Usage: mv [-fin] SOURCE DEST
or: mv [-fin] SOURCE... DIRECTORY

Rename SOURCE to DEST, or move SOURCE(s) to DIRECTORY

In that vein, I'd suggest something like:
Usage:  docker tag SOURCE_IMAGE[:TAG] TARGET_IMAGE[:TAG]

Create a tag in the TARGET_IMAGE repository that refers to SOURCE_IMAGE.

Good suggestion!
Do we need additional clarification that "repository" is local here? (So tagging does nothing remote, only push does?) I can see there's some confusion about that; https://github.com/docker/docker/pull/28354#issuecomment-260188760

is there need to use word repository? adds only confusion (what is repository?), it's image that is being tagged, so i propose:
Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE.

@thaJeztah can you re-run the windowsRS1 job?
Thanks.

@ripcurld00d yes. looks good!
but can you include doc change in this PR as well? it also has that unhelpful docker tag IMAGE[:TAG] IMAGE[:TAG] as example.
https://docs.docker.com/engine/reference/commandline/tag/

but can you include doc change in this PR as well?

oh! I was so focussed on the change, I missed that. Yes docs changes should be included, also the man-page;

https://github.com/docker/docker/blob/master/docs/reference/commandline/tag.md
https://github.com/docker/docker/blob/master/man/docker-tag.1.md

@thaJeztah I thought we have a script that generates this...
n/m it should not be a problem :grinning:

@thaJeztah done :)
Thanks for your review.


:1049: ImportWarning: ConfigurationImporter.find_spec() not found; falling back to find_module()

I'm upgrading my project to python 3.11.3 and one of the things I am seeing is this deprecation warning --
Is this something the team is already aware of?  Am I right to assume its a warning with your project and not mine?
This may have been introduced with 3.10?

Starting in this release, there will be a concerted effort to begin cleaning up old import semantics that were kept for Python 2.7 compatibility. Specifically, find_loader()/find_module() (superseded by find_spec()), load_module() (superseded by exec_module()), module_repr() (which the import system takes care of for you), the package attribute (superseded by spec.parent), the loader attribute (superseded by spec.loader), and the cached attribute (superseded by spec.cached) will slowly be removed (as well as other classes and methods in importlib). ImportWarning and/or DeprecationWarning will be raised as appropriate to help identify code which needs updating during this transition.

See also:

https://github.com/jazzband/django-configurations/issues/190
https://github.com/jazzband/django-configurations/issues/358

This is just awaiting a release to PyPI and was resolved in #365

@rrauenza version 2.5 has been released. Can you confirm that this issue can be closed?

yes, thank you!!


Navigation Issue

Specific page navigation is not working when app is killed.

Yes, I am having the same issue. The specific navigation works when clicking on the notification when the app is live, but when the app is killed it doesn't. Any thoughts and guidance would be hugely appreciated :-)

Guys, what version are you using? Have you tried the last beta version available?

@rafaelsetragni sorry I was not using the beta, I have switched and it works a treat! Thank you. @amdarshini if you implement the beta, it will work!

@reachcodemed can you please share your approach? I used the example like in readme of the latest beta version, but clicking the notification when the app has been killed just show the home route, not my desired route.

I guess this is because youre running that code inside another isolate, not the main one. You can only have access to an valid context inside the main isolate (which runs your app). You need to use isolate ports to send the message to be processed in the main isolate.

@rafaelsetragni sorry I was not using the beta, I have switched and it works a treat! Thank you. @amdarshini if you implement the beta, it will work!

Doesn't work even when using beta :(

Hi! Sorry for taking so long to respond to your issue on GitHub. I was focused on releasing the new 0.7.0 version of awesome_notifications and awesome_notifications_fcm and i didn't had time enough to do both. But now I can answer all your questions.
So now i'm asking you to recreate this topic using the new issue template. There's a lot of missing informations that i need to understand your problem, and all the instructions are already in the new issue template. Also, remember to check beforehand if your issue was posted by another user.
So I will automatically close all previous issues so far.
Sorry for the inconvenience and i will be waiting for your new issue request.
Thank you so much for your support!


How to download file in Amazon S3 with download progress in Xamarin?

Hi,
I need to download a file in Amazon S3 in Xamarin android and Xamarin iOS. please help

Hi @sridharsaminathan this version the SDK has been deprecated and rolled into the .NET SDK. Check out these resources:
GitHub: https://github.com/aws/aws-sdk-net
Installation: https://docs.aws.amazon.com/sdk-for-net/v3/developer-guide/net-dg-install-assemblies.html
Official Forums: http://forums.aws.amazon.com/forum.jspa?forumID=61
Documentation: https://docs.aws.amazon.com/sdk-for-net/v3/developer-guide/
Thanks,
TEW

Hi,
Thanks @tawalke. i have added AWSSDK.S3 from nuget packages
I have added the following code for downloading file Amazon S3. For S3Client i have used identity pool id with region. i am not getting response here var response = await S3Client.GetObjectAsync(request) .
Please find the code and help me to fix.
var S3Client = S3Utils.S3Client;
bool responseBody = false;
var request = new GetObjectRequest
{
BucketName = Constants.AWS.BUCKET_NAME.ToLowerInvariant(),
Key = string.Format("{0}/{1}", Constants.AWS.FOLDER_NAME.ToLowerInvariant(), filename)
};
try
{
using (var response = await S3Client.GetObjectAsync(request))
{
string avatarFilepath = System.IO.Path.Combine(App.PersonalFolderPath, filename);
await response.WriteResponseStreamToFileAsync(avatarFilepath, true);
responseBody = true;
}
}
catch (AmazonS3Exception s3Exception)
{
responseBody = false;
}
return responseBody;
Thanks,
Sridhar

i have got network issue it is resolved now


Confusing filter specification in EEG, MEG, iEEG

Intro to the issue
We are currently having two temporal filter related fields in the electrophysiology specification:

SoftwareFilters
HardwareFilters

both fields have a description as follows (with slight adjustments), please focus on the specification of filters:

list of temporal software filters applied. Ideally key:value pairs of pre-applied software filters and their parameter values: e.g., {"Anti-aliasing filter": {"half-amplitude cutoff (Hz)": 500, "Roll-off": "6dB/Octave"}}. Write n/a if no software filters applied.

So we can always use a string "n/a".
Beyond that, the information is a bit confusing, as identified by @effigies in https://github.com/bids-standard/bids-specification/pull/322/files#r321275320.
We are asking for a list, which brings to mind an array of the following form:
{
    "myKey": ["val1", "val2", 45455.3, {"obj": 1}]
}

However, in the validator and our examples (e.g., starter kit), we are requiring an "object of objects" in the form:
{
    "HardwareFilters": {"HighpassFilter": {"CutoffFrequency": 0.1}}
}

questions
Should we:

stay with our current way to specify filters and simply clarify the language in the specification to drop the word "list", and use "object of objects" or similar?
change the way we specify filters to be a "list of objects" --> this would allow the benefit to intuitively specify the order of how filters were applied to the data
allow both and change validator and spec text accordingly

I am not a signal processing expert ... but as long as the order in which filters are applied is irrelevant (e.g., because they are linear operations), I am in favor of option 1.

Related: #322

I think either 1 or 2 is fine. I think having too much flexibility is a validation nightmare so I would recommend against 3. You already have the ability to have a string or an object with one entry. The question is whether multiple entries involve an object with multiple entries or a list of objects with one entry each.
I don't really have a dog in this fight, as I don't ever try to use *EG data. My inclination is that ordering is good to specify even when it isn't critically important. (Also that linear filters are mathematically exchangeable on real numbers, but floating point numbers are not reals, and error accumulates.)

given https://github.com/bids-standard/bids-specification/issues/322 is this one resolved? ie use of a list

I don't think so. #322 punted on the issue, improving the docs, but not actually addressing whether we use a list of objects or a multi-entry object.

I vote list of objects @sappelhoff @jasmainak @robertoostenveld any pref?

I vote list of objects.

Agreed! But please also update the validator.
On Fri 11 Oct 2019 at 09:45, Robert Oostenveld<EMAIL_ADDRESS>wrote:

I vote list of objects.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/issues/339?email_source=notifications&email_token=ADY6FIVNV2QTEV4WLVNDYBDQOB7RJA5CNFSM4IZI2CQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBABNDY#issuecomment-541070991,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADY6FIULYKRDQVAN6QATXQTQOB7RJANCNFSM4IZI2CQQ
.

--
Sent from my iPhone

For being pragmatic, I vote "object of objects" ... if the order is important, it can be specified with a custom key value pair inside the object. This would mean only a specification clarification within the text.
going the "list of objects" way will require:

changing spec
adjusting validator
fixing existing bids-examples
fixing examples on bids-starter kit
fixing openneuro datasets
acknowledging that several user datasets will now suddenly be invalid although they were valid before

On second thoughts, I agree with @sappelhoff . Backwards compatibility is important.

Wow, yeh if that breaks so many things, and even if that's not as elegant, let's go object of objects then
--
Dr Cyril Pernet,
Senior Academic Fellow
Neuroimaging Sciences
Centre for Clinical Brain Sciences
Chancellor's Building, Room GU426D
The University of Edinburgh
49 Little France Crescent
Edinburgh BioQuarter EH16 4SB
<EMAIL_ADDRESS>tel:  +44 (0)131 465 9530
http://www.sbirc.ed.ac.uk/cyril
http://www.ed.ac.uk/edinburgh-imaging

From: Stefan Appelhoff<EMAIL_ADDRESS>Sent: 15 October 2019 09:29:33
To: bids-standard/bids-specification<EMAIL_ADDRESS>Cc: PERNET Cyril<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [bids-standard/bids-specification] Confusing filter specification in EEG, MEG, iEEG (#339)
For being pragmatic, I vote "object of objects" ... if the order is important, it can be specified with a custom key value pair inside the object. This would mean only a specification clarification within the text.
going the "list of objects" way will require:

changing spec
adjusting validator
fixing existing bids-examples
fixing examples on bids-starter kit
fixing openneuro datasets
acknowledging that several user datasets will now suddenly be invalid although they were valid before

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/bids-standard/bids-specification/issues/339?email_source=notifications&email_token=ABENIDUUFQUUMBGLDTOO53TQOV5O3A5CNFSM4IZI2CQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBH4ZDI#issuecomment-542100621, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABENIDWOAMHZMO2ZEHGRQCDQOV5O3ANCNFSM4IZI2CQQ.
The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.


Integrated proposed code to center MapAnnotations properly

@pauljohanneskraft
Hi! Are you planning to merge this PR? I've tested it and it work correctly