[5.1] Improvements to Redis cache tagging

Use SETs rather than LISTs for storing cache key references.

Needs actual description of how this is an improvement, what bugs it fixes, etc.

@taylorotwell it prevents multiple child tagged cache key references being stored against the tag key type (standard or forever). When a cache tag is flushed this is how the child keys are referenced and we know which ones to flush.
Currently it can store multiple, and although it works fine with duplicates, is inefficient/extra overhead.
There is no functional change to the end user, just a cache flush required to change from using SET storage to LIST.

Thanks

This PR actually broke https://github.com/tymondesigns/jwt-auth refresh token code.

There is no functional change to the end user, just a cache flush required to change from using SET storage to LIST.

The code was run on a vagrant instance with no existing cache, and it still getting the same error code. Furthermore, saying that it would work if you flush the cache on a patch release is still a breaking change!

Sigh. I'll revert it in the morning. I've gotta learn to stop merging things that try to fix something that isn't broken in the first place.

Hi short for time at the moment but... the old method was broken. Leaving stray and duplicate keys in the tag reference store. When you're storing lots of tags it becomes more problematic. Also before 5.2.14 tagging on standard keys didn't work at all...
The reason for these errors are people are not flushing the cache after a composer update (something you should do in my opinion).
I see no way to make these changes like this without doing so. Should an artisan cache clear not run as part of the composer deployment ? It works fine as soon as this is followed and all tests run as they should.
I don't see how else these changes could be handled. Without try/catches throughout the tagging code...
:(

Clearing the cache used for JWT authentication is not wise in my opinion, this would mean that on every deployment the cache would be cleared and users accessing the mobile app would need to be re-authenticated (login in by key-in the username and password).
BUT MOST IMPORTANTLY, as I said before this also happen on a newly up Vagrant instance with NO EXISTING cache.

Hi short for time at the moment (vacation) but... the old method (there from 5.1) was broken. Leaving stray and duplicate keys in the tag reference store... Not detrimental but not how it should have been. When you're storing lots of tags it becomes more problematic. In terms of overall, before my previous fix tagging on standard keys didn't work at all...
The reason for these errors are people are not flushing the cache after a composer update (something you should do in my opinion).
I see no way to make these changes like this without doing so. Should an artisan cache clear not run as part of the composer deployment ? It works fine as soon as this is followed and all tests run as they should.
I don't see how else these changes could be handled. Without try/catches throughout the tagging code...
:(

@crynobone which method are you receiving errors on? Tried on a vm and all ok. Using a shared cache store?

Did you even read/look at the error screenshot that I posted?

This should be reverted, and moved to 5.3 imo.

Yeah I saw the screenshot. I asked which php method... A flush or a push?
As for 4. I am not saying it was, I mentioned what needed to happen in the commit message. I applied the patch to the correct branch in 5.1 and up to the repo owner what happens.
I am at a loss as to how a change like this would be introduced in a different way...
Caching was never tested fully in 5.2,  if it had been cache tags would have flushed from launch, forever or standard ones (only forever used to). No need for the tone... just trying to help and fix a long running bug, alongside a full time job :)

Should be moved to 5.3.

Also it would be a fair assumption to flush cache after a framework upgrade.

The assumption that everyone would flush cache on every single patch releases is just like saying "I guess this code would work fine, it works for my use case".
I agree that It would be fair, for a major release but not on patch release (as you might be deploying code on a daily basis). But again, it up to developer to choose how they want to proceed during the upgrade as noted on the upgrade note for 5.3. Adding the changes in the middle of patch release without any upgrade note (there shouldn't be any) is bad. I had to revert our planned deployment to production last monday because it suddenly throwing errors where it shouldn't happen, and had to look through commit history to find the cause of this error not only on tymon/jwt-auth repository but also laravel/framework. So yes I'm deeply frustrated with the numbers of PRs that took breaking changes very lightly.

just a question related to this.
is there a way to make tests capture this kind of bugs between patch updates?

@crynobone I see what you're saying, but in principal (not saying in just Laravel's case) cache should never be treated as portable between versions for a framework. If you updated your system from 5.2.23 to 5.2.24 you would always check after the update and run any tests/cache clears, these are then run the same on live too.
Many apps (such as Facebook) change the way in which cache is stored between revisions, it's just these are run as part of the upgrade. The problem with the composer deployment of Laravel is these are bypassed. I did mention in the pull request what needed to be done, but I'm not in control on the release notes. Perhaps it could have been highlighted then by someone reviewing.
Yes, this should probably have been merged into 5.3, I followed the contribution guidelines and plugged it from where the issue became present.
@boynet I looked at this when making changes now (and previously), currently the cache tag tests are very minimal and use mockery to test the method calls receive the correct data. I guess perhaps some kind of actual simulation of data would help for third party services, although how you'd check between revisions in a test would be interesting. To be honest I think the CachedTag methods could do with a little re-factoring. I also see no reason why tagging could not be present in file based and database back-ends too... I'll try to look should I get time.

If you updated your system from 5.2.23 to 5.2.24 you would always check after the update and run any tests/cache clears

We have tests on our application that test our code, and we trust Laravel and all the others packages (that we carefully pick) to respect the non-breaking changes. Now, do you know exactly what has changed between v5.2.23 to v5.2.24 without having to manually read https://github.com/laravel/framework/compare/v5.2.23...v5.2.24 or https://laraver.xyz/versions/v5.2.24
Laravel doesn't provide any CHANGELOG between patch release. (I don't mind this as Laravel promise no breaking changes on patch release).

I did mention in the pull request what needed to be done, but I'm not in control on the release notes. Perhaps it could have been highlighted then by someone reviewing.

It were mention only once asked by @taylorotwell, don't you think it should be mention on the first description? wouldn't that means anyone who come across the PR would notice it more? And furthermore what's with the PR title Improvements to Redis cache tagging, that doesn't even sound like fixing a bug at all.


Add support for ERN 3.4.1, 3.7.1, 3.8.1, 3.8.3, and DdexC

This draft pull request represents our efforts to include additional versions covered by the dedex repo. Please feel free to provide any feedback on our implementation of this. We would like to get this merged into the miqwit/dedex repo so we don't end up duplicating efforts and diverging too much.

Wow, that's quite an improvement, thanks! I will review that in detail, but it seems that you have followed the same path I have, generating classes from the XSD (and "struggling" with the dates).
I will need some tests with at least one file for each version, with some version specific in it, and without confidential or copyrighted values in it. Can you provide this?
Thank you very much for this huge and valuable addition to the lib.

I'll work on getting those tests added with any confidential or copyrighted values mocked out. I'll also work on adding any of the tests that are missing.

I am also just wondering how you heard of this package? And what type of
company you are working for? Were you at the DDEX meeting this week? The
history of the commits shows very limited information from two users with
no other activity.

Hello @HeathNaylorSI , any progress on the XML testing? Let me know if I can help. If you give me some initial material (XMLs for each version) I can try to contribute to the testing.

Hello @HeathNaylorSI or @nwilging maybe, any news about this about adding XML samples?

Hello @HeathNaylorSI or @nwilging, any update on this?

@miqwit i worked for a company last year that utilized the ddex spec. They needed support for more versions that this package supported, so I worked on adding support for these additional versions — most of which are similar to the schemas you’ve already setup in this package.
I no longer work for that company, and my current work does not make use of ddex at all, so I have no horse in this race. I’m also not really sure what this PR is. The work I did around ERN versions happened last fall, and I left that company in November.
Anyway, here is the forked package that the company ended up using: https://github.com/SauceIndustries/dedex-fork
As long as they leave that public, you could browse the changes for adding additional version support.
I cannot comment on the accuracy of the parsing, but at the time it was tested out, it was passing business logic QA. I’m not personally in the audio sector, so I don’t know all of the ins and outs of the ddex spec.

Thank you @nwilging for these details. I'll try to make progress on this. I see some other developer is active on that PR now. If you feel like helping me on this, let me know, will be glad to collaborate!

Hey @miqwit. Let me catch up here, been busy in other repositories.
I came onto the package after the DDEX package was discovered and used, but I imagine it was just out of the team searching for a package that already did what we were looking to do. The company we work for basically provides music playlists curated for businesses. We did have one of our team members at the DDEX seminar that happened, I was on the Zoom conference as well. I believe the commits are from Github accounts specifically created for use inside of our organization and not our personal GitHubs (mine is @HeathNaylor).
As for the XML testing, I have not started that endeavor yet, we can look at getting that started. We are implementing different versions of ERN that our partners utilize.


New web view features

What's new:

audio signal when image is ready (customizable)
generation skipping
now you can resize your image!
settings modal
info tooltips on hover
some bugs have been removed, some bugs have appeared.

I merged #71 before this one, so there are minor conflicts in the web readme. Can you check it ?

Done, no conflicts


Feature/2.7rc/11727 stdin support for puppet parser validate

The acceptance test is broken, please resubmit.


Open telemetry enabled requires SQS and SNS dependency for native build

Hi, I opened similar issue for this here: https://github.com/quarkusio/quarkus/issues/40220 but I thought that here might be a better place to post this issue
I am testing my SNS messages by subscribing it using SQS and reading from this SQS in tests. I have problem executing native tests, because I am getting Discovered unresolved type during parsing: software.amazon.awssdk.services.sqs.model.MessageAttributeValue. This error is reported at image build time because class io.opentelemetry.instrumentation.awssdk.v2_2.SqsParentContext$MessageAttributeValueMapGetter is registered for linking at image build time by command line and command line.
If I remove quarkus.sns.telemetry.enabled=true or if I add  io.quarkiverse.amazonservices:quarkus-amazon-sqs:2.13.1 like implementation and not testImplementation It also works.
My question is why? I don't understand why it have to be as implementation if I only use SQS in my tests?
Here is reporoducer: https://github.com/DawidStuzynski/native-microservice-xray code is on main branch
To run integration tests I run ./gradlew clean quarkusIntTest -Dquarkus.package.type=native -Dquarkus.native.container-build=true -Dquarkus.test.integration-test-profile=test

@DawidStuzynski Could you test with the PR ? It should compile, but if you can check telemetry is still working.

@scrocquesel how Can I test it with PR? Is this released somewhere?

@scrocquesel how can I test it with PR? Is this released somewhere?

You can checkout it (git fetch origin pull/1242/head:otel && git switch otel), run mvn install -DskipTests and use 999-SNAPSHOT for the version in your project.

Okay, thanks for answer. I will check it


Allowing flexible folder names and trimming test words from image names

Hi,
As discussed in #8 I took the liberty to try an implementation that would keep the current behaviour while adding two different possibilities:

Allow the folderName to be set, which will impact the folder in which the images will be saved.
Allow trimming the test prefix of the images names.

This also impacts the Failure folder.
Before                            After

In my opinion this makes up for better readability, and also helps referencing custom views.
You can also create subfolders using folderName = "folder/subfolder" which allows you to have:

Note:
I have almost no experience with objective-C, so if there's anything that might not be in the best way, accept my apologies and please let me know.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@alanzeino @dzenbot thanks for your comments. Will work on them. 👍

Updated the code based on latest comments.

Renamed testName to folderNamewhich I think it's more explicit on its intension
Updated properties comment information
Renamed trimTestFromImageNameto tripTestPrefixFromImageName to also be more explicit.

Great, thanks!
I noticed that if a identifier contains a slash "/", then a new folder will be created to put the images inside, the problem is that the failure images are not created correctly because prefix are appended to the union of selector and identifier.
Maybe would be great to avoid having slash in the identifier or bad things will happen.
Two things could be done:

Sanitise identifiers to remove the slash from them
Throw an error message if identifier contains slash

I had that issue and implemented something similar to this pull request before I found it...

Hi @alexissan I just tested your usecase (using the code in this PR) and didn't find any problems.
Maybe I did something wrong?

Set folderName = "MyCustomView/InnerFolder"
Created a snapshot using recordMode = true
This creates the image at "MyCustomView/InnerFolder"
Set recordMode = false and ran tests
Failing images were created at "FailureDiffs/MyCustomView/InnerFolder" as expected.

@nunogoncalves what I mean is pass and identifier like this one:
let identifier = "myIdentifier/somethingElse"
FBSnapshotVerifyView(view, identifier: identifier)

a new folder will be created. can you give a try?

@alexissan  what about this:

If you really want subfolders, I think you can just ignore identifier from now on.

@nunogoncalves yes, is totally fine.
I was just saying that using an identifier can introduce problems (unrelated to your fixes).
I like your changes and I hope you can merge very soon.
Thanks so much!!!

Hi @alanzeino. Did you get the chance to see the last updates? Do we need any more changes? :)

Okay so I've looked at this again. Part of me is concerned that the PR has evolved beyond the original scope into features that I don't see a use for (but I'm willing to be convinced).
For example, getting the module name out of the folder name; makes a lot of sense. Happy to merge that in. But trimming the test prefix, I have less idea what this solves. Same thing with completely custom folder names. I don't know what this helps you with.
In the PR it says these changes help for 'better readability' but I don't see how completely ignoring the class name by overriding it with a different folder name helps — if anything, things get a little more confusing. Same thing with omitting test as a prefix. If I'm looking at a bunch of failed snapshots in the IMAGE_DIFF_DIR, I would lose the context of what test class generated those snapshots.
Happy to change my mind but for now I would only merge in the change that omits the module name from the folder structure, since I think that is redundant information.
Sorry for not bringing this up earlier.
P.S., as someone who does massive regenerations of snapshots, not being able to match them with a<EMAIL_ADDRESS>regex would be annoying. I know this is opt in, but if someone does opt in they'll basically lose the ability to find snapshot PNGs using a simple regex (they'll have to write a more sophisticated script that looks for ReferenceImages_foo and considers only PNGs under that dir as snapshot images, for example).

Let me try to sell you my fish. Hopefully not rotten. :)
Let's say we have a project called MyAwesomeProject. Now let's imagine we have a view called ColorfullView that we can and want to test. Naturally the name testcase file and class name would be ColorfullViewSnapshots.
With the current implementation, the folder in which the images are going to be saved, will be called MyAwesomeProject.ColorfullViewSnapshots. The first thing that comes to mind is the existence of MyAwesomeProject. in the folder name. This is exactly what triggered the first pull request #8.
Now, when I started implementing this update, I didn't simply want to set a flag like tripModuleName because that is actually an implementation detail, and as far as I can tell, not a problem in Objective-C. Instead, and this made/makes much more sense in my head, we can actually define the name of the testcase. This gives us the power to choose what fits best for a given test.
At first the user can simply set the name of the folder to the name of the class and it's done. He can simply define a FBSnapshotTestCase subclass that will be a super class of all test cases, and set  the name there in setUp() most likely with type(of: object) method. For the most basic usage that's it.
After some getting use to snapshot tests we noticed an interesting thing. It can also work as documentation reference for our views. This is amazing as it is already automatic. If we test a given custom view, we get the benefit of documenting it visually as well. In that context, it makes a lot of sense to call the folder the same name of the view being tested.
So, now we have the power to move from MyAwesomeProject.ColorfullViewSnapshots to ColorfullView which improves the experience while glancing at the list of custom views.
Of course one can name the folder "ClarkKent", but with great power comes great responsability. The user needs to be responsible for what he does. :) I would never expect to find a<EMAIL_ADDRESS>inside a ClarkKent folder.
Subfolders only came into play after some discussion here. I think this fits the ClarkKent category, but if it makes sense to someone...
Considering this documentation scenario, removing the test from the image name also helps a lot.
Now under ColorfullView we could see<EMAIL_ADDRESS>where before we'd read<EMAIL_ADDRESS>When you say it prevents people from using regex to find specific cases, you're right, but you also said it's an opt-in feature. It's better to have that option than not having. The lib will allow the user to have that decision rather than preventing him to have the liberty to choose. I could argue that your regex case  is probably far from most people's experiences. But this is not really an argument.

Totally understand the use case you've presented. But I don't think all these changes are worth promoting as features for this repository (more on that later).
There's the issue of stopping people setting folderName in individual tests — since folderName is something you have described should only be set in -setUp, there's nothing stopping someone from having a different name each time. I think that's a little too dangerous to allow, considering the most useful feature we've honed in on is that these features help for documentation, which is not a goal of the project. If I can ever set the folder name, one test class could throw its snapshot files across more than one folder. But if you can solve this, I'll accept the folderName change.
However, I think removing test as a prefix is a change we don't want. Again, using the images as documentation is not a goal of the project. In this case, if you wanted to take your snapshots and make them into documentation there's nothing to stop you from removing test from all the file names and creating some nice HTML which you host internally at your company that can serve as this documentation. I just don't think this library specifically should focus on constructing documentation itself.
I should apologize that the project doesn't define what its goals are and how we take contributions. At the moment, my goal is to take obviously useful contributions that have minimal risk but large impact. I don't want to merge in changes that can confuse users or which don't meet the goal of making unit testing better by providing a mechanism for UIView comparison testing. I'll improve the documentation to outline this better for future contributors.
In the meantime, I'm totally happy to merge a pull request that removes the swift module name from a folder, and the folderName change (if you can make it work so that it can only be set once per test class).
For the swift module change, I think it is valid to just match a . (period), split on that and return the second part. The only research to be done is if Swift or Objective-C allows a period in a class name (I think they don't).
P.S. about the 'this repository' comment above. I want people to understand that even though we might not accept all changes into the repo, there's a very easy way to keep a fork with changes you want and use it in CocoaPods. Simplest way is to use :path in your Podfile and point to a local directory in your repository with the fork. Second most simplest way is to overwrite the :git directory and use a specific :commit or :branch for your changes.

Ok @alanzeino thanks for your explanation. We're gonna have to live with that. :)
I think I found a way to set the folder name and make it only possible on init time. I'll update the PR when I have the time.
I'll also remove the `trimTestFromImageName´ flag from the PR.
Also, concerning your last paragraph, that's what we are already doing. Anyway, your HTML idea was food for thought and we'll look into it. One window closed, but a door opened. Thanks again.

@alanzeino can you please check the updated code? I have removed the trimTestFromImageName and added the possibility to set the folderName, at init time only.
My objc skills are very low, and apologise for any rookie mistakes.
Thank you.

So just reverted the code on FBSnapshotTestController.m/h
The changes get to be on the interface only.

Note: the module name is not redundant information in the folder name, if you are using a statically defined folder location to store snapshots that are taken from the same tests being are run against two separate test targets. In these cases, the current module name inclusion automatically ensures unique folder paths, whereas if this was removed you would have collisions in both folder paths and actual filenames.
For some users, this might be a 'feature'. You could now have the same reference images used when tests are run against two test targets.
For other users, this would definitely be a significant regression. I would be in the latter camp.

Yes, what you described is correct. I missed this because at Uber every test bundle has its own reference images directory — to have that collision in our codebase you'd need to have the same test class name used twice in one test bundle.
But I think the norm is to have one giant reference images directory used for many test bundles, so this would probably break in that scenario you described.

any update on this Pull Request ?
here I'm having this general class which will check some stuff to record or validate, then if it is recording it will snapshot all screens based on this generic class name. but I wanna define it somewhere in my test case.

I don't know why, but I have signed the license agreement twice and it's still pending.

To be honest after @babbage's comment I felt less confident about this change. I'm still not 100% sure this is a good change to make, but I'll think about it a bit more this week and make a decision.

I really sold all my arguments.
There were a few people here who said this is something they'd like to have. It is not a forced feature, it's an opt in. Either way we can always use this fork and that's what I'm doing.
Thanks for the discussion and keep the good work. :)

@alexissan my own.
The fork with the original implementation of this PR: working-flexible-names
The current pull request lives in another branch: flexible-names

Okay I'm going to merge this feature. But on second look at the API, the current implementation also doesn't work well. In its current state, this requires overriding a getter in your subclass of FBSnapshotTestCase, but that override is called in the initializer of the superclass, which to me results in a side effect of the initialization chain and probably would surprise most users of this library.
The simplest change would be to have the property exposed, and allow it to be set after [super setUp]; by the subclass (the headerdoc should mention this).
Also make sure that in the implementation of -setUp in FBSnapshotTestCase.m that folderName is reset to NSStringFromClass([self class]). This ensures that an overridden folderName doesn't leak into the second test case — I noticed that in testing initWithInvocation: is called for each test in a test class but I don't want to rely on this underlying implementation detail.
If anything, there's no need to even set _folderName in the initializer — it can be set in -setUp in FBSnapshotTestCase.m, and then subclasses can override that again by setting the property.
Sorry for all the churn on this change. If you like I can make these changes for you — otherwise I'll wait for your update. Thanks!

Thank you Alan.
I’ll gladdly do it, when I get the chance. I came all the way here, won’t stop now. 🙂

Hi @alanzeino
I was trying to look into this and I think there's a problem. The fact that the the controller is instantiated in the setUp method makes this hard and unexpectedly to accomplish.
Maybe I'm missing something.
Here's the current implementation of setUp:
- (void)setUp
{
  [super setUp];
  _snapshotController = [[FBSnapshotTestController alloc] initWithTestName:NSStringFromClass([self class])];
}

Considering what you were saying we have the options of setting the folderName before or after instantiating the controller:
- (void)setUp
{
  [super setUp];
  self.folderName =  NSStringFromClass([self class])]
  _snapshotController = [[FBSnapshotTestController alloc] initWithTestName: self.folderName;
}

Before, obviously fails because we're overriding anything the subclass might have setup.
Next:
- (void)setUp
{
  [super setUp];
  _snapshotController = [[FBSnapshotTestController alloc] initWithTestName:folderName;
  self.folderName =  NSStringFromClass([self class])]
}

Since we call [super setUp] and then set the folderName property, it won't get the desired effect unless on the subclass sets up folderName before calling the setUp do:
override func setUp() {

    self.folderName = String(describing: type(of: component))
    super.setUp()
}

It kinda feels strange to me.
What's your take in this?
Maybe I'm missing something?

Yes you're correct. I guess there's no particularly perfect way to implement this; all the different ways have their individual tradeoffs.
I think the option that works the best would be;

FBSnapshotTestCase exposes the folderName property.
FBSnapshotTestController no longer takes a testName in its initializer and exposes a folderName property as well.
Whenever the folderName on FBSnapshotTestCase is set, it updates the folderName in FBSnapshotTestController as well.

So basically FBSnapshotTestCase acts as a intermediary. Making this change will also improve the naming used in FBSnapshotTestController; which right now calls the 'folder part' of the full path the testName when really the test name is what it calls the fileName.

@alanzeino could you please re check this? :)

Slight problem with this change at the moment, it changes the file paths for existing tests.
Before:
<EMAIL_ADDRESS>After:
<EMAIL_ADDRESS>When you do stringByAppendingPathComponent: you need to append both the folderName and the testName. In the current version, the testClass passed in via the default initializer isn't used anywhere.

Yeah I was just looking at why the tests failed and noticed it. My tests were performed on my implementation so that worked. I'll fix it. :)

Hi @alanzeino
Have you had the time to recheck this?

You renamed the initializer in FBSnapshotTestController.h, which was a public header in the library.
Breaking changes can be very tricky and difficult to spot in Objective-C.

Ah damn! :/ I didn’t think of that as I dont use it. And since the instance was not available through the testcase I didn’t realize that. I’m very sorry.


Update the browser mob proxy version to the latest which is 2.1.1

Closing this PR as we are removing this feature.


cli: allow flags in commit message-driven execution

currently, the keyword that allows to specify what workflows to run (in a commit message) has the form:
popper:whitelist[...]

Now that there are multiple ways in which we can control the execution of a workflow, we can generalize this so that we can take all the same flags that can be given to popper run. For example:
popper:[--on-failure cleanup --wfile path/to/main.workflow]

we can take more than one of this.

we can also take this opportunity to deprecate the --wfile flag, and instead take it as an argument, something like:
popper run <options> [action|wfile]

popper:[--on-failure cleanup --wfile path/to/main.workflow]

Does this arrangement apply to only those options which take a workflow/action as value ?

the idea is to allow passing any flag that can be passed to the popper run command. We could instantiate another click context by calling the make_context() method of the cmd_run command, so that we don't need to parse this ourselves

@ivotron Now that we deprecated the popper:whitelist and popper:skip, so if an user want to whitelist 1 workflow he would ideally pass it as an argument to popper run by doing popper run /path/to/workflow. But if they want to whitelist more than 1 workflow, what should they do ?  For this case, we can allow skip to take workflow inputs as well, so that the workflows not required can be skipped. What do you think ?

yeah, that's a good idea


Pinned tabs don't show separators

When setting any one of the Style.Separators-Saturation- keys to true, separators are shown in the tab bar but only for unpinned tabs. See the screenshot below:

I didn't add separators to the pinned tabs as they don't need them, Imho. Icons are clearly visible and do not require special markers, unlike text. I can add separators, but as an option.

Done. Check


volshow and plot_isosurface differ by a transpose

Just a small note. It seems like consistency would be desirable. Perhaps there's some convention or reason for the difference that I'm not aware of.
The only difference between the following two plots is that in the second, f is transposed in ipv.volshow.
Without transpose
import numpy as np
import ipyvolume as ipv

t = np.linspace(0, 1, 21)
x, y, z = np.meshgrid(t,t,t)
f = x**2 - y + np.sin(2*np.pi*z)

ipv.figure()
ipv.volshow(f)
ipv.plot_isosurface(f, color='gray')
ipv.show()

With Transpose
import numpy as np
import ipyvolume as ipv

t = np.linspace(0, 1, 21)
x, y, z = np.meshgrid(t,t,t)
f = x**2 - y + np.sin(2*np.pi*z)

ipv.figure()
ipv.volshow(f.T)
ipv.plot_isosurface(f, color='gray')
ipv.show()

Clearly, the transpose is necessary for agreement between the two. Should one function or the other be modified so that they agree automatically?

Just dropping a note that I've experienced the same confusion when overlaying an isosurface on a volshow.

This confused me as well, I expected the different volume plots to behave the same. In any case, it would be helpful if the documentation stated the axis order.


refactor: using rewrite phase and add lru cache for multiple origin

using rewrite phase to prevent be run after auth plugins. as mentioned #1528
add lru cache for multiple origin case, it helps performance.

@ShiningRush please add some test cases

many thx @ShiningRush , merged


Wrong open and close prices from bitfinex

I'm submitting a ...
[X] bug report
[ ] question about the decisions made in the repository
Action taken
Compared a candles close prices on bitfinex exchange with prices in Gekko history
Expected result
Prices must be the same
Actual result
Some candles has a significant difference with open and close prices.

Other information
I noticed it on many other pairs.
Exchange: Bitfinex
Cryptocurrency on the screenshot: IOTA.
Time: 2019-05-12 12:00 - 2019-05-12 12:10
Candle Size: 1 minute

the same question

I checked prices from Binance, its semm all fine. That mean the problem actual only for bitfinex. I think the problem may be with their API Version 1.1. Maybe if gekko will use API 2.0, the problem will be solved.

@TeoWay  Why should the v1 api return incorrect data? The 2.0 is actually still in beta, so it wouldn't be good to integrate it yet as minor changes can still occur.
I think there must be some other reason why the data could be off. I'll have to look into it more.

@TeoWay Gekko It appears that gekko is using the v2 API for bitfinex, /exchange/package.json speceifies<EMAIL_ADDRESS>and the main package.json specifies<EMAIL_ADDRESS>both of which use v2 endpoints.
There must be another reason why the data is incorrect.


Can not Run Code MIL-ElECTION-CLASSIFICATION

I followed all the steps in ReadME.text. But I got the error for running the Election classification part.
Traceback (most recent call last):
File "d:/mil_code/mil_code/mil_election_classification/run_trials.py", line 12, in
run_deepset(num_neib=0, r=0, alg_name='vanilla')
File "d:\mil_code\mil_code\mil_election_classification\deepset_main.py", line 193, in run_deepset
acc_all = get_performance_test(i)
File "d:\mil_code\mil_code\mil_election_classification\deepset_main.py", line 165, in get_performance_test
value = train(epoch)
File "d:\mil_code\mil_code\mil_election_classification\deepset_main.py", line 130, in train
loss_train = bce(output[idx_train], labels[idx_train])

File "d:\mil_code\mil_code\mil_election_classification\deepset_main.py", line 130, in train
loss_train = bce(output[idx_train], labels[idx_train])
IndexError: index 279 is out of bounds for dimension 0 with size 222


Wrapping parent component in Radium causes to broken data flow

Hello,
in situation like this:
let Demo = React.createClass({
  displayName: 'Demo',
  render: function () {
    return (
      <ReactGridLayout className="layout" cols={12} rowHeight={30}>

1

2

3

      </ReactGridLayout>
    )
  }
});

export default Radium(Demo);

we are getting following results with children array:

If Radium is breaking the children of its children, that's a Radium bug, not an RGL bug.


Forked to keep up to date

I all, I have forked this repo to keep it up to date, https://hub.docker.com/r/doudou34/tor-server/.
Thanks @chriswayg for your amazing taff!

@DarkIsDude  Can you open up issues on your repository? How often are you updating your Tor version on your image?

@dmp1ce I try every two month. Done for issue, I will update it now

If you will use, I can update it every month ;). Let me know

@DarkIsDude nice to see, that you updated my previous version to be functional again! The more Tor servers the better!
I finally updated my Tor server to Debian 9 stretch, which should auto-update on Docker Hub more reliably, as it is not built from source, but using the Tor repositories with recent builds.

The latest Tor-Server Docker builds are working and ready for action!
https://hub.docker.com/r/chriswayg/tor-server/

Thanks a lot for your work. I can close this issue.


add cleanup scripts to the release bundle

currently only the istio.VERSION and *.yaml files are getting added to the release.  This will copy all current and future cleanup* scripts

This change is

resolves https://github.com/istio/istio/issues/289

Jenkins job istio/presubmit passed

@sebastienvas

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed


Exit Codes?

While working on modifying the logic for the Alfred Wrapper, I realized that it would be much cleaner to
simply call TOD to run in the background, and then return the status based on the exit code (instead of parsing the CLI output, as I am currently doing)
@alanvardy can you confirm if there are any other exit codes I should be aware of?
It appears that 0 is return for successful (expected) and 2 is returned for missing parameters; are there any others?
I have tested a modified version that monitors for the 0 exit code on task creation and acts on that and it works really well, without any need to handle spinners or config modification.

Hi @stacksjb I also return an error code 1 for errors that are handled manually, all successful things will indeed return a 0 :+1:

Link to code where I return exit code 1: https://github.com/alanvardy/tod/blob/4384072939b7f503078c64aefdc4d0cfee2bd971/src/main.rs#L143

Perfect, thx. I'll add handling logic!
I've updated wrapper and it appears to work really well. Thanks!


Stream Enrich: bump amazon-kinesis-client to 2.2.12

Project: Stream Enrich
Version: 1.1.0
Expected behavior: Use enhanced fan out
Actual behavior: KCL v1 missing it.
We had this requirement to use the enhance fan out feature from Kinesis to make sure our throughput is consistent. However, KCL v1 is not supporting this feature and we have to upgrade the KCL to version 2. This could be similar topic to https://github.com/snowplow/snowplow-elasticsearch-loader/issues/151.

Migrated to https://github.com/snowplow/enrich/issues/260


New Partner Pool list filter (including CoW)

Add a new Button Group to filter core partner pools.

All pools will display all pools on the Balancer protocol
Initial Partner pools will be CoW, Gyro and Xave.

Logic around Pool types within main filters button

Option 1: Remove FX, CoW AMM and Gyro CLP.

This logic is probably easiest, but one disadvantage is that users can't see both 'CoW' and 'Gyro' pools at the same time.

Option 2: Alternatively, keep these filters but apply some logic where if any of these filters are selected, the ButtonGroup toggle must switch to the 'All pools' option. This would allow a user to filter by a couple of items like 'FX' and 'CoW AMM' concurrently.

Partner icons:

Desktop design:

Mobile design:

Instead of a partner toggle here, I'd suggest we move the version toggle out of the filter dropdown. So be able to quickly toggle between v2/v3/cow. Maybe other partners could be included in this toggle, but for now I think we should just move the current toggle. wdyt @uiuxxx?


Allowing sprites in StringTable

I was considering allowing a single sprite in StringTable instead of just text. This would allow using the ore symbols in the Smelter StructureInspector instead of just the text.

I was thinking about the recently, I suspected this sort of issue might come up soon.
I think what we really want, is a grid layout control. The cells would be containers for arbitrary UI elements. With the current implementation, it's like a grid layout where all cells are filled specifically with Label controls.
This relates to the idea of developing more general layout containers.

I would be ok abstracting a grid layout. Perhaps it replaces StringTable altogether or perhaps there is a child of Grid that simplifies setup for tables only containing strings.
Image doesn't inherit from control though. So to be a generic control grid that could handle images, it would require adding an image control.
Another option would be to add a ScreenObject class that represents the following:

Position on screen
rectangle size
virtual draw function
virtual update function

Yes, I've been thinking about how screen position and size should relate to the control objects. In regards to object size, some objects have a natural size, such as images and labels (updated when text changes), while many do not. Some also have a minimum size. That got me thinking maybe size should be part of the object itself, so the object can have more control over it. Meanwhile position seems largely controlled by the container. Not sure I would want to split size and position between different objects though. Plus, if the container holds the object position, it becomes harder to determine position given a control. I'm leaning towards size and position being members of the control itself, and high up in the Control hierarchy.
In terms of the update and draw functions, I think the draw function should be marked as const.
I think you're right about needing an Control form of Image. I've noticed the Sprite class as implemented is more like a Control than a resource. We should probably split that object into two. Generic resources can be thought of as cached common data, without associated screen position (though may have a natural concept of size). A Control may reference such resources, and will have associated position and state data.
Another thing I noted, is that we've added a Label control, but we don't really use it. A lot of text is manually positioned, and that position is calculated when it is drawn. If we split update and draw, then Label positioning would probably be associated more with update, or more likely actual changes to Label text data. The draw function would then be using pre-calculated coordinates. I suppose technically that would inflate the sizes of objects though, since they would necessarily contain pre-calculate position/size state data, rather than calculating on the fly. Or at least that's true if the objects themselves contain the position and size, rather than the container (which might calculate things on the fly).
Related, the base Control class has methods for text fields, but not every Control contains text. Maybe the text related methods need to be moved elsewhere. Not sure if we should have a generic TextControl intermediate or not. Possibly not. Also not sure how much we should break down subclasses. For the Button control, should we have separate classes for text buttons versus image buttons? The current design combines them, with an optional Image. If we start splitting things too much, we may end up with multiple inheritance issues, where controls have base classes for different orthogonal concerns (text control, image control, text and image control etc.).
The ideas still feel pretty incoherent so far. There doesn't seem to be a clear and obvious best design.

I was working on this last week and designed a prototype ImageControl, which I didn't get far enough in to actually test outside of compiling.
I was realizing that Sprite is for an animated sprite and Image is for an unanimated Sprite. I was hoping to see Image and Sprite be organized a little closer than they are in calling convetions.
To convert StringTable into a more generic UIGrid, it would be helpful to provide an abstract TextControl. This would provide unified access to setting the font, font color, and maybe a few other text related activities. This would facilitate applying StringTable::SetColumnFont and other functions to all controls in a range that are primarily designed to show text.

I agree with your assessments. These are things I'd like to work on, and could probably use a bit of help and feedback with.

The current Sprite class design mixes elements of both Control and resource. The Image class doesn't have a position on screen, and so is unlike a Control, while Sprite does have a position. On the other hand, the generic animation info is loaded into the Sprite class, much like generic Image info is loaded into the Image class. This leads to a lot of duplicated data in similar Sprite instances. I was thinking these should be split, so generic animation information exists in a resource class, while a Control like class can reference that data and supply an associated on-screen position.
In the nas2d-tests repository, I had noticed the zombie shooter sample was parsing the zombie sprite data 5 times, once for each zombie shown on screen. I think it may have been updated to not reparse the XML data multiple times, though the class structure still needs update.
I feel like we may need to rework some of the terminology. I think of a sprite as an image with transparency. An animated sprite seems like a further specialization. I'm not sure an animated image which is not a sprite would be very common, so perhaps we can assume that any animated objects will refer to sprites. Of course, the Image object has support for alpha channels, so there doesn't seem to be a need to differentiate between images and images with transparency at the class level.
In terms of interface, I would like to be able to draw objects, passing a Renderer reference, and I would like that to be possible on const objects. Whether such a draw method goes on the resource objects themselves (in which case, a position would also need to be passed), or if the method goes on a Control version of the resource, I haven't really decided. Maybe have one method delegate to the other. I believe change to object state should be handled separately by an update method, which would not be const. For an Image class, there isn't anything to update. For a Sprite class (or whatever Control form of it might exist after splitting or renaming), such an update method could be used to iterate through the frames.

I was also thinking we should have some kind of TextControl base class. In particular, there are some text methods in Control, which doesn't seem like an appropriate place.
One concern I have here, is a layout class might work with arbitrary Control objects, while the text based methods would only apply to TextControl objects. I suppose we could use dynamic_cast to check for Control classes of the correct type, and only set text or Font properties if they apply. Normally I like to avoid dynamic_cast, though I'm not sure how to avoid it in this case, and still maintain a sane API. On the plus side though, people should only be calling methods that might use dynamic_cast in cases where dynamic_cast would actually apply and be useful. If you have a grid layout of images, with no text based controls, you shouldn't be calling methods that set text, text color, or font.

Looks like this issue will wonder quite a bit off topic. I think there is a lot more pre-work to completing this than I thought...
I would consider 2D graphics drawn to screen as sprites. Maybe rename Image to Sprite. The current Sprite class could be renamed AnimatedSprite. That would make the terminology more consistent.
If there is a desire to have a resource behind a Sprite that doesn't understand screen coordinates, I would consider maybe Texture or Texture2D if possibility exists for 3 dimensional support in future. A sprite would have 1 texture at a time and an AnimatedSprite could contain multiple textures.
Assuming above naming convention, I like the idea of a void Sprite::draw(Renderer& renderer) const and void AnimatedSprite::draw(Renderer& renderer const.
I'm not sure how to define the control class. I suspect there is room to have a basic Sprite class that allows only drawing to screen and then a SpriteControl that adds control functionality on top of it. I think the Control interface maybe should add concepts like in focus, hovered over, etc? I haven't really fleshed out what Control should be.
In C# it seems more acceptable to use dynamic_cast as a discriminator to only select items within a certain class hierarchy (I don't know that it is a one for one comparison to dynamic_cast). I've used it with others in C# projects who thought it was normal practice. I have no issue with using dynamic_cast in this method. I like the idea of preserving some of the text helper functions understanding they would not apply to all cells based on grid contents. Although it also wouldn't be wrong to just remove those fields either, but would require a lot more manual entries to affect rows or columns of text.

I kind of like the idea of naming things Sprite and AnimatedSprite. It's reasonably clear and accurate. My one concern is that people might naturally go looking for an Image class, so not having one might be confusing.
We are currently using the name "texture" internally for the associated OpenGL handle. From what a gather of how the API works, Image is basically the raw data in main memory, while "texture" is when it's loaded into graphics memory, which may convert it to a hardware specific optimized format.
It terms of the Resource/Control difference, the main aspect is position. You can have multiple controls all referencing the same resource, at different positions on screen. The actual image data itself doesn't need to be duplicated, it just gets drawn at different positions, using the coordinates of each corresponding Control.
A Resource may have a natural concept of size, but it lacks position. I suppose it's a little like the difference between a class and an object.
In terms of Control attributes, I think the most basic are position and size. Things like text features only apply to certain controls. Similarly the ability to accept focus only applies to certain controls. Take the Label control for instance, which doesn't accept focus. Mind you, maybe a "Control" is something that accepts focus, while merely having a position and size is for some yet unnamed base class of Control.
I like that we're thinking about focus though, because that's an issue that's crossed my mind from time to time. The current controls seem a bit ad hoc about focus.
I think you're right about these ideas needing a bit of pre-work to handle them smoothly. I've tried tinkering with a few ideas before, though they often started to cascade into rather large change sets, which I generally backed out of.

When we say 'sprite' are we talking about the actual NAS2D::Sprite class or are we speaking of just images or image slices?

I think the discussion is more conceptual, and extends to arbitrary UI elements, not just NAS2D::Sprite. I think we should be able to put arbitrary Control instances in the table cells.
Yes, there was some side discussion about the design of NAS2D::Sprite, which kind of relates, though is a bit off topic.

In terms of NAS2D::Sprite, there was discussion about splitting the static shared resource portion of it from the more control specific position and animation state portion. Think how the Zombie sample game used to parse the sprite XML file 5 times, once per each zombie displayed in the game, even though the resources were identical and could be shared between them. There is now some splitting internally along those lines, though it isn't exposed well. Basically, the design of NAS2D::Sprite is unlike the design of NAS2D::Image, and the discussion was about splitting the control to resolve those differences.
I don't plan to split between animated and non-animated sprites. We already have Image versus Sprite that basically handles that. I think we were looking more at potentially renaming things if it might add clarity. The name Sprite implies transparency, though doesn't imply animation, so we were looking at names that might be more descriptive. In addition, if we split the NAS2D::Sprite class so the resource data is stored separately form the control data, then we'd have an extra class to name. Similar to if we added an image control, which currently doesn't exist (only NAS2D::Image resources, which have no associated screen position).

What's confusing me is why Sprite is being considered or thought of as a UI Control? It's not at all part of that concept. Sprite is defined as an image that's not part of a background and may or may not be animated. That's effectively what the sprite is so treating it as a Control makes no sense to me.

In game libraries, I'm used to seeing a Sprite class that is a static image with a screen position and ability to render itself. Which is why I was thinking maybe the NAS2D::Sprite could be renamed to AnimatedSprite. That way Sprite could be repurposed to be a static image with associated position and ability to draw itself.
Sometimes, it would be nice to have a sprite control so you can treat a sprite as a layout object within a control grid. It would have more features than just drawing to screen.

Sprite doesn't derive from Control, but it contains state similar to Control derived classes, and is responsible for drawing itself using an update method. Effectively it could be made to derive from Control and would naturally fit in. (Not a suggestion, just an observation).
Looking back at it now, I see Sprite does not actually contain a position (it's a parameter to update), but it does contain other instance specific state variables such as:

mCurrentAction
mCurrentFrame
mTimer
mAnimationCompleteCallback
mColor (this could be considered either a specific or generic field)
mRotationAngle

In contrast, there are generic fields for the static resource data:

mSpriteName
mActions (and the associated frame lists)

The generic data in mActions is the proper "Resource" data. This data needs to be stored separately from the instance specific data above to avoid duplication and wasted space. Currently that's done with an internal private cache for the mActions data. It's mainly the mActions data structure that should form the "Resource" class, perhaps using a name such as "Animation". The other instance specific fields could be split into a new class, perhaps retaining the "Sprite" name or maybe "AnimatedSprite". The sprite class would contain a const reference to the static animation data. That is now currently true, in that mActions is a pointer to const data, though it's done using private internal caches, which is a bit of a rigid design. There is no way to construct animations from alternate data sources, such as building one up in memory. The only access to the private internal cache is through the file loading mechanism. By splitting the current Sprite class into those two components, we'd gain more control in how animations could be loaded or created, and how they are cached.
If the class was split, (and this is an observation, not a suggestion), the instance specific portion could potentially be moved to OPHD and made to inherit from Control, and would basically just work. The one change might be to add position as a member variables, which might as well be done since mCurrentFrame and mRotationAngle are already pretty instance specific, much like position would be. What I'm saying is this portion of the existing Sprite class is very similar to how Control derived classes work.
In contrast to NAS2D::Sprite, the NAS2D::Image class has no instance specific data. It is a pure "Resource" class.
You could of course build an "image" Control as well, which might be done by combining a const reference to a NAS2D::Image along with instance specific data, such as position, and maybe rotation angle. Such a new class would be used very similar to how Sprite is currently used now.


PyTest Fails to Discover if VSCode believes code is bad even if its not

Environment data

VS Code version: 1.33.1 (user setup)
Extension version (available under the Extensions sidebar): XXX
OS and version: Windows_NT x64 10.0.17134
Python version (& distribution if applicable, e.g. Anaconda): 3.6.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
Relevant/affected Python packages and their versions: PyTest 4.1

Expected behaviour
Expected:  Find all unit tests and run them regardless of if VSCode thinks they work or not.
Actual:  Test discovery fails if VS Code beleives there is a problem in any test file be it a real problem or not or if it is 1 test of 1,000 or 999 of 1,000.
Definition of "doesn't work":  The code actually works when executed.  The primary issue I'm encountering that the testing seems to not like is around imports.  If I separate my test code from my app code (great practice, maybe even a best), I need to import the packages I wish to test.

See file structure above for a simplified project.  Additionally a git repo is available with the code in it here for your convenience https://github.com/drcrook1/PythonDevOps
Traditionally (if pytest did not import side by side modules as root level packages), you would need to add code similar to below to be able to import a module:

This sys.path.append tricks up VSCode and causes test discovery to fail.
Additionally, since in some scenarios, pytest loads packages of this nature at the root level, you do not need to add the tested module to the root because the tests are copied to the top level directory:  Reference: https://docs.pytest.org/en/latest/goodpractices.html#goodpractices (Section: Tests Outside Application Code - about 15% down the page)
From VSCode's perspective that scenario with no imports would still throw an issue as below:

This additionally causes Test Discovery to Fail across ALL tests.
Below is an example where I have a single super simple test where I don't do anything useful and the tests are discovered.  Notice there are no imports.

Lets add an additional test (without modifying the file shown in the above).  In the new test, I add prerequisite code to import Module.some_class.  This causes Test Discovery to holistically fail even though if it actually ran the test, it would work.  The image is below:

I Forgot to include the output view's logs for the failure.  Here they are:
Test Discovery failed:
Error: Traceback (most recent call last):
File "C:\Users\DrCrook.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\run_adapter.py", line 16, in
main(tool, cmd, subargs, toolargs)
File "C:\Users\DrCrook.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\adapter_main_.py", line 90, in main
parents, result = run(toolargs, **subargs)
File "C:\Users\DrCrook.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\adapter\pytest.py", line 43, in discover
raise Exception('pytest discovery failed (exit code {})'.format(ec))
Exception: pytest discovery failed (exit code 2)

or not bad code - I have good code, no problems, and tests were running fine before this release, but now "Test Discovery Failed" and same exact python test log traceback as above:
Test Discovery failed:
Error: Traceback (most recent call last):
  File "C:\Users\mikm\.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\run_adapter.py", line 16, in <module>
    main(tool, cmd, subargs, toolargs)
  File "C:\Users\mikm\.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\adapter\__main__.py", line 90, in main
    parents, result = run(toolargs, **subargs)
  File "C:\Users\mikm\.vscode\extensions\ms-python.python-2019.4.11987\pythonFiles\testing_tools\adapter\pytest.py", line 43, in discover
    raise Exception('pytest discovery failed (exit code {})'.format(ec))
Exception: pytest discovery failed (exit code 2)

OK well, that fixed it. You need to have an EDITABLE install in the virtuelenv for it to work.
My recommendation would be to make the project on the PYTHONPATH by default.

OK, another discovery, if you have a pytest.ini file, then pytests also work fine, even without an editable install, or modifying the PYTHONPATH.
For an example see pvfree which works fine in a virtualenv using MS Visual Studio Python 3.6.6 64-bits from vscode and in the vscode cmd terminal using pytest

And the final piece of the puzzle - Update your version of pytest in your virtualenv. I don't know which version is required, but in PVMismatch neither trick worked (neither editable install nor pytest.ini) until I updated from pytest-3.2.1 to the latest: v4.4.1)
so in conclusion:

update pytest
add pytest.ini
do editable install of project (assuming your project has a setup.py)

Thanks for your help @drcrook1, I'm facing the same issue today. I've not tested your solution but it is the first time I encountered this problem, never had problem with pytest auto-discovery in VS code.

This has been fixed in our master branch, fix will be available in the next release.

validated


Is there any offical way of freezing graph to pb in Tensorflow2

This template is for miscellaneous issues not covered by the other issue categories.
For questions on how to work with TensorFlow, or support for problems that are not verified bugs in TensorFlow, please go to StackOverflow.
If you are reporting a vulnerability, please use the dedicated reporting process.
For high-level discussions about TensorFlow, please post to<EMAIL_ADDRESS>for questions about the development or internal workings of TensorFlow, or if you would like to know how to contribute to TensorFlow, please post to<EMAIL_ADDRESS>To some reason I have to get a pb model. In TF1 I used following code to build a pd file.
from tensorflow.python.framework import graph_util
constant_graph = graph_util.convert_variables_to_constants(sess,sess.graph_def,FLAG.output_op)
with tf.gfile.GFile(FLAG.save_path + '\\PBModel.pb',mode='wb') as f:
    f.write(constant_graph.SerializeToString())

I tried every thing of savedModel to pb or .h5 to pb but failed. So is there any offical way of freezing graph to pb in Tensorflow2 ?

@Zhuxinpei ,
Can you please refer to this link for similiar issue.
Thanks!

I have tried all ways from that link but the pb from .h5 was not simillar to the pb in TF1 especially when I built custom model.

@Zhuxinpei ,
In order to reproduce the issue reported here, could you please provide Tensorflow version,the complete code and the dataset you are using. Thanks!

Tensorflow-2.3.0. Sorry for no code and data cause the issue was asked for the code of freezing graph to pb.

@Zhuxinpei Can you please check whether this resource is helpful to you or not.
Some of the TF1 functionality you can access through tf.compat.v1.graph_util.convert_variables_to_constants. Thanks!

Thanks for your reply but the resource may not helpful. What I need is converting a saved_model from TF2 to a raw .pb file in TF1. The resource documents as

"TensorFlow 2.x saved_models work in TensorFlow 1.x if all the ops are supported"

Thus I thought there should be a way of using tf.compat.v1.graph_util.convert_variables_to_constants to convert a saved_model. Actually I tried many ideas in stackoverflow but no one works. Such as the link and code:
import logging
import tensorflow as tf
from tensorflow.compat.v1 import graph_util
from tensorflow.python.keras import backend as K
from tensorflow import keras

tf.compat.v1.disable_eager_execution()

saved_model_path = 'XXX'
model = keras.models.load_model(saved_model_path)
with K.get_session() as sess:
    output_names = [out.op.name for out in model.outputs]
    input_graph_def = sess.graph.as_graph_def()
    for node in input_graph_def.node:
        node.device = ""
    graph = graph_util.remove_training_nodes(input_graph_def)
    graph_frozen = graph_util.convert_variables_to_constants(sess, graph, output_names)
    tf.io.write_graph(graph_frozen, '/path/to/pb/model.pb', as_text=False)
logging.info("save pb successfully！")

If you have any idea please help.

Freezing is not an operation the TF team has plans to support going forward.
It is used as an implementation detail of a few transformations, or was at some point (e.g. TF-Lite, XLA compilation to some extent). But not as a standalone operation.
If there's something you could do in TF1 that still requires a frozen graph and it's maintained by the TF team, please do file a bug about that. Endpoints should generally consume SavedModels, and we'd really rather not have a separate format for frozen models floating around that are supported spottily.


Padding macaddr's octets

Fixes #4

Thanks for the pull request. I'm guessing it's failing due to the old Elixir version in the travis config.
I'll look at this over the next day or so and get it merged.
Cheers.

Merged and released in v0.5.0.
Thanks for contributing!


ExecuteSql missing for Attaching New SQLite files use case

Hello! My team have been experimenting with SQLite libraries for React Native and stumbled upon this library. Thank you for you great work!
Our use case requires us to use multiple SQLite files at once and we notice that you have an 'attach' feature that allows you to attach multiple sqlite files for the same DB connection.
However, currently the db connection object does not return a 'executeSql' function that can be used as seen in the example. Is the example deprecated and if so, is there an updated example on how to use multiple SQLite files?

Hi @igezt.
The connection object provides an 'execute' method. This is an error on the docs. I will submit a fix for it.
But you can use execute or executeAsync to run querys on your attached database.
The example on docs is still valid, only replace 'executeSql' with 'execute' following the pattern with the new database alias and it will work (I use it in production here).

Thank you for the swift response! Much appreciated.


Issue #SB-14066 fix: Checks added for editing uploaded contents.

Issue #SB-14066 fix: Checks added for editing uploaded contents.

Code coverage

CC: @rajeevsathish


System scripts for running on Windows

I'm not sure that this is the correct place for these scripts as they aren't caddyfile examples, but an example of how to run a production caddy on  windows .
There are 2 scripts - one to start caddy in a loop each time it is shutdown, and a second script to shut it down forcing a reload on a regular basis.
If there is another more appropriate place to put this (caddyserver.com?) let me know.

Hey, thanks for contributing this and #48, Toby! Don't you think these would make a good blog post? It would probably bring some traffic to your blog (if you have one). This repository is traditionally for Caddyfile examples... haven't really considered opening it up to tutorials for system integration... so would probably have to consider that...

Your probably right.  I'll do a post and you might share it!
However, I think this is a good place for #47, if you were happy to merge that in.  I know its not strictly caddy, but it does show the best way of running caddy with php fastcgi on windows.

@tobya Sounds good, thank you!


Consider Marionette uiBindings

uiBindings are currently not supported so I added a few lines of code to make it work.
Parsing of the @ui-sytax is taken from the original Marionette source

Closing for the same reasons as #295.

Alright.
If anyone is interested in supporting Marionette.bindings use:
var addBindingFn = Backbone.View.prototype.addBinding;

_.extend(Backbone.View.prototype, {
    addBinding: function (optionalModel, selector, binding) {
        if(_.isString(selector) && selector.charAt(0) === '@' && this.ui) {
            selector = this.ui[selector.substr(4)].selector;
        }

        return addBindingFn.call(this, optionalModel, selector, binding);
    }
});

Awesome. Thanks for that.


Not published on npm

https://www.npmjs.com/org/rdfjs does not include @rdfjs/express-handler

@berezovskyi sorry, i missed the error message when I tried to publish it last time. Now it's available in the rdfjs org at npm.


[BUG] DeepSpeed errors when running BLOOM

Describe the bug
I am facing issues getting the BLOOM model to run with DeepSpeed using TOT upstream pytorch.
The first slough of errors observed are resolved with @rraminen's workaround in the transformer_inference branch.
This occurs both in 5.4.2 and 5.5.
Log snippet:
deepspeed_error.txt
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/include/ATen/ATen.h:4:2: error: #error C++17 or later compatible compiler is required to use ATen.
    4 | #error C++17 or later compatible compiler is required to use ATen.
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/include/ATen/core/ivalue_inl.h: In lambda function:
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/include/ATen/core/ivalue_inl.h:1061:30: error: ‘is_convertible_v’ is not a member of ‘std’; did you mean ‘is_convertible’?
1061 |         if constexpr (::std::is_convertible_v<typename c10::invoke_result_t<T &&, Future&>, IValueWithStorages>) {

To Reproduce
Docker image: rocm/pytorch-private:BLOOM_DeepSpeed_tranformer_inference_enabled_tot_issue
Steps to reproduce the behavior:

git clone https://github.com/huggingface/transformers-bloom-inference
deepspeed --num_gpus 1 transformers-bloom-inference/bloom-inference-scripts/bloom-ds-inference.py --name bigscience/bloom-560m

ds_report output
DeepSpeed general environment info:
torch install path ............... ['/opt/conda/lib/python3.8/site-packages/torch']
torch version .................... 2.1.0a0+gitfde024b
deepspeed install path ........... ['/opt/conda/lib/python3.8/site-packages/deepspeed']
deepspeed info ................... 0.9.3+44c0bbfe, 44c0bbfe, transformer_inference
torch cuda version ............... None
torch hip version ................ 5.5.30201-c1741e9b
nvcc version ..................... None
deepspeed wheel compiled w. ...... torch 2.0, hip 5.5

cc: @jithunnair-amd @dllehr-amd


docs: add devops-adc.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Jmeter Master e Slave

As I work with master and slave on jmeter dsl, I didn't see anything in the documentation, I needs to do a high load of data in several machines???

Sorry, I didn't see that you implemented the feature, thanks, I will test it here.

Do you have any examples using git actions? The host changes all the time, the machines can be different every time you run it.

What are you trying to achieve? create the agents/testing infra and destroy it in each github action run? If that is the case I don't have any examples. If that is the case and you are using AWS to spin up the instances, you can assign static ips to the instances, or with aws cli find the IP addresses of created instances and parameterize the test accordingly (eg: storing IPS list in an environment variable and using Sytem.getenv to retrieve it in jmeter DSL test).


[Feature Request] Microsoft Office365 Teams Support / OneDrive for Business

I just tried using draw.io with Microsoft Office 365 Teams, which uses sharepoint 4 business in background. It seems not to be supported? I guess it would be really helpful to integrate drawio with teams to be able ...

to save/open files from drawio to/from teams
open files from teams automatically in drawio (teams application)
collaborate in realtime on drawio charts on teams storage

I guess more and more companies will move to office365 in the cloud and therefore this will be an great enhancement.

Are you guys reaching out to MS for the necessary changes? Is there any chance we can expect support for OneDrive for Business using team sites?

What is "team sites"?

Sharepoint sites (see image 1). From draw.io I can access my ODB which lists my personal files. I can also browse through the company (sharepoint) team sites. But when trying to save in that location I get the error "The resource cannot be found". The goal is to store documents in a location that is accessible for all users from our company.

And is that a self-hosted sharepoint, or Microsoft hosted one?

Microsoft hosted as part of our Office 365 subscription

Sharepoint integration fixed in 9.2.9


prepend instead of append role instructions to prompt

Often, one gives instructions and code to the AIChat buffer and only then runs the AIChat /role command;
these are mostly understood to come before the specific instructions.
However, they are appended to the existing instructions
>>> user
What is the best Vim plug-in?

:
What is the best Vim plug-in?

I suggest that the latter variant would be more natural.
For now, it requires jumping back to the beginning of the prompt.
However, if I recall correctly, there was some reluctance to label roles as such, so maybe these role prompts are meant to expect the instructions before them?

For what it's worth, maybe there's no need to paste the whole prompt into the aichat buffer, and a
>>> user (vim-wizard)

would do as well, but again, I faintly remember that, maybe for technical reasons, this was not such a good idea?

Just re-tested it and it had always been working as you suggested, it generates prompt like this:
>>> user

Your ar an all-knowing Vim wizard...:
what is the best vim plugin?


Personal Relic State + Number of Captured Relics

Split up this info a bit:
[ Annexed / Sovereign ]
[ Conquests: # (icon) ]

adjusted in #391


add pyxhook and sphinxcontrib-bibtex for osx as well

follow-up of #16288 and #16305

but note that it's not strictly required unless people using the key want to support macOS.

:+1: I just figured that it's easy enough when it's pip to just add the entry for the 4 distros to avoid needing a follow up PR to add them when someone face the issue. Is it preferred to make this opt-in and for mac users to submit follow-up PRs if they want to ?

I would say opt-in is fine. If we're going to use it in desktop-full then I'd say we should require it for mac, otherwise opt-in is fine imo.

Sounds good, thanks for clarifying


Ambassador dashboard updates

Add swr getter for the beneficiaries,
Add shimmer effect component,
Add graphql queries for comunity beneficiaries,
Templating
Add loading effects to community cards and claims map

This PR fixes #231 #217
Tests

[ ] Tested on mobile
[ ] Tested on dektop

This PR should be manually tested by @obernardovieira @psoaresbj @hugomarquesdev , included on reviewers.

"view all" and "my communities" is confusing. view all says 119 beneficiaries. Is this from all communities? It should show only the ambassador communities and nothing else
reported suspicious activity is not opening. I also think the number is not correct
remove "inactive beneficiaries" and "suspicious activities" cards. They don't have any info at this point
with ambassador 3, I'm ambassador of "Larpers" but can't see the beneficiary list
should it have shimmer on community page? I just see the loading. But see the shimmer on ambassador dashboard, looks perfect 👌

1 - Then we need to remove the View all option right? Right now, in the view all we see all beneficiaries from all communities and in my communities, all beneficiaries from all my communities.
2- yeah the url is missing, will update this. I'm using the api endpoint we have for the reports also i believe we don't have yet an endpoint to get the reports per community and that is why the number is always the same
3 - Will do
4 - I'm guessing here but i think only managers can access the beneficiaries page, will need to check on the code but i think that is the reason why you can't see the list
5 - We can add it, we'll need to replace the component loading because right now that loading is showing until the request is completed, so if we just add the shimmer it won't be visible.
@obernardovieira

It's the ambassador dashboard, should have only information related to the user. So yes, remove the view all.
ask @dev-jotape
.
that's the goal with #231. but if in a community, the ambassador should be able to use the "view all" on ambassadors card and jump the the beneficiary list, the same that the manager has
that's the goal with #217. To have shimmer loading effect, and totally remove the current loading in the middle of the screen

I change the community, but the number of reports don't change. And if I select to "view" with a community selected, shows from all communities
With a community select, I select to see all beneficiaries, first it jumps to beneficiaries list with no beneficiaries and then it starts loading but never loads anything.

Yes @obernardovieira, all of that is happening because i'm implementing new backend endpoints that aren't merged yet (they will need to be merge in sync, otherwise it will break the current live implementation) to fully test these changes is only possible locally, using the backend branch (list-beneficiaries) with the new endpoints.


Update hyperlinks

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

This updates a few links I found slightly out-dated while finalising #577. Merging this will probably create a few minor conflicts there, but I'll deal with them.

Thanks for the updates @katrinleinweber! Would you mind applying them to the translations too?

@katrinleinweber This repo attracts a lot of spam, it's worth just ignoring people who aren't maintainers here.


Email commands restrictions

At the moment the only restriction is on domain, so any user with an account in the domain can issue any command.
Somehow make certain commands limitited to specfic emails/users.

Implemented


Animation support?

Ryan, stoked to see you built this plugin. It is great! 😁
Any chance animation support will be added at some point?

I could definitely add support for this! I'd probably only add support for the basic CSS powered animations though, less-likely to support JS powered ones (via plugins).

Perfect 👍


⚠ Guya.moe Proxied has degraded performance

In b9ed40c, Guya.moe Proxied (https://ice.guya.moe/) experienced degraded performance:

HTTP code: 200
Response time: 12990 ms

Resolved: Guya.moe Proxied performance has improved in dc5fefc after 1 hour.


Add debug symbols upload

Resolves #47
Resolves #57
Resolves #60
It will also make sense to automate Sentry CLI update in a way similar to other plugin dependencies (#60)

@tustanivsky for Android, we need to update the UPL file - how can we reference the ProjectDir and the Sentry.PropertiesFilePath here? https://github.com/getsentry/sentry-unreal/blob/3a0d8a143a8140b8de2b3b4b615ce70a26552fc4/plugin-dev/Source/Sentry/Sentry_Android_UPL.xml#L15

@tustanivsky for Android, we need to update the UPL file - how can we reference the ProjectDir and the Sentry.PropertiesFilePath here?
https://github.com/getsentry/sentry-unreal/blob/3a0d8a143a8140b8de2b3b4b615ce70a26552fc4/plugin-dev/Source/Sentry/Sentry_Android_UPL.xml#L15

$S(ProjectDir) should give us the path to the project directory and the sentry.properties file can be referenced via $S(PropertiesFilePath) variable which is defined above.
It actually looks like something went wrong during recent merges - src should be $S(PropertiesFilePath)

It actually looks like something went wrong during recent merges - src should be $S(PropertiesFilePath)

fixed
please have a look at my changes and feel free to merge.


feat(opentelemetry-instrumentation-runtime): initial version

Which problem is this PR solving?
Prepares a module for runtime instrumentation, runtime metrics.

#1106

Short description of the changes
I have created a new module for runtime instrumentation and added initial example of "event loop lag" metrics.
I would refrain from adding more metrics in this PR to not block it for too long and add new metrics in subsequent PR.
The "event loop lag" metrics are inspired by https://github.com/marcbachmann/opentelemetry-node-metrics which is inspired by https://github.com/siimon/prom-client.

@Ugzuzg thanks for the review! Im a bit busy these days, but i'll try to make some time and fix the mentioned issues.
Are there any comments on the overall structure that i should address?

great! We really really need this! :) Is there an ETA as to when it'll be available?

+1
This feature will be greatly appreciated.

@mentos1386 any update on this PR? are you still interested in finishing it?


Fix wording in documentation of Durable Object blockConcurrencyWhile

@vy-ton @Frederik-Baetens

@kodster28 thanks for reviewing! Any chance you can also merge this? I don't have the ability to do so.


Unable to configure all DoS network vectors

Environment

Application Services Version: 3.48.0
BIG-IP Version: <IP_ADDRESS>

Summary
When enabling denial-of-service network vectors, it seems impossible to enable three:

TCP Flags Uncommon
TCP ACK Flood
Flood

Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration:

{
    "schemaVersion": "3.14.0",
    "class": "ADC",
    "Tenant": {
        "class": "Tenant",
        "Application": {
            "template": "generic",
            "dos-policy": {
              "class": "DOS_Profile",
              "network": {
              "vectors": [
                {
                  "type": "flood",
                  "state": "detect-only",
                  "thresholdMode": "manual",
                  "rateThreshold": 40000,
                  "rateIncreaseThreshold": 500,
                  "rateLimit": 1000000
                }
              ]
            }
          }
        }
    }
}

Observe the following error response:

{
  "code": 422,
  "errors": [
    "/dos-policy/A1/dos-policy/network/vectors/0/type: should be equal to one of the allowed values ["ext-hdr-too-large","hop-cnt-low","host-unreachable","icmpv4-flood","icmpv6-flood","icmp-frag","ip-frag-flood","ip-low-ttl","ip-opt-frames","ipv6-ext-hdr-frames","ipv6-frag-flood","non-tcp-connection","opt-present-with-illegal-len","sweep","tcp-half-open","tcp-opt-overruns-tcp-hdr","tcp-psh-flood","tcp-rst-flood","tcp-syn-flood","tcp-synack-flood","tcp-syn-oversize","tcp-bad-urg","tcp-window-size","tidcmp","too-many-ext-hdrs","udp-flood","unk-tcp-opt-type"]"
  ],
  "declarationFullId": "",
  "message": "declaration is invalid"
}

Expected Behavior
If AS3 can enable 26 of the network vectors, it would be great if it could cover the remaining three.

Jira AUTOTOOL-4241 for prioritization


Close button of confirmation prompt is not working.

On click close instead of close the dialog, it is closing whole app.

This has been fixed in the "2023.5.1" release.


Upgrade regex crate in filecheck

Currently in lib/filecheck/Cargo.toml we have regex = "0.1.71", the plan is:

replace it by regex = "0.2.2"
cargo build and follow-fix compiler errors
cargo test to make sure tests pass

This is a tedious task but suitable for starters as it doesn't require deep knowledge about the project (I think). Also https://github.com/rust-lang/regex/blob/master/CHANGELOG.md can help you.

Sounds good to me! Our use of regular expressions is pretty limited, so this shouldn't be too big a task.


Add NSKeyedUnarchiver+SwiftUtilities.m to .podspec

Hi @Ewg777, thanks for your contribution!
You're right that I forgot to include the NSKeyedUnarchiver+SwiftUtilities files in the podspec, even though it's also true that the 0.3 podspec is not published yet.
I just added them now


Request Extractors: Status code on failure

Hi @ndortega, I hope you are doing well,
The last features you added are really nice, good job man.
I have just a small question, if the extractor or the validator fails currently it returns a 500 status code (Internal Server Error), wouldn't it be better to return a 400 status code (Bad request)?
Let me know your thoughts,
Abraham JA

Hi @AbrJA,
Absolutely, that makes a lot more sense to throw a 400 in that case.


removing update stiffness option from NewtonSolver. Really if we want…

… a QuasiNewton solver we should create a seperate solver interface to avoid confusion or making methods overly complicated.

Addresses issue #36


Add vueTemplateCompiler option to Mix

Hey @JeffreyWay,
I am submitting a pull request that addresses the installation of vue-template-compiler as a dependency in non-Vue JavaScript apps. By default, I have set it to true by default, therefore it is not a breaking change for old projects.
The issue has been referenced in issue #1877 as well as causing unwanted behavior in the Laravel presets (see the pull request here).
Additionally, it gives the Laravel Mix extension developers control over installing the vue-template-compiler dependency in their extensions. As an extension author, I would very much like to have this control in my mix.svelte() extension.
Hope you find the changes reasonable and would be willing to merge them into master.
Kind regards,
g

This will be resolved in a different way along with the webpack 5 release.


remove .travis.yml from root

We aren't using Travis are we? It's 5 years old.

Yes, that file is very old and can be removed.


Optimize performance with PureRenderMixin analogs

Check #sync-baobab-refactor-frontend
Yeah, this is even visually faster. Much faster.


Fixed Typo in Atom Command

connnect -> connect
Also getting practice at pull requests, I guess I could have just mentioned this on Slack >.>

LGTM, thanks! :)


libplacebo: 4.157.0 -> 4.192.0

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

nixpkgs-review:
27 packages updated:
anki ankisyncd celluloid celluloid curseradio haruna jellyfin-media-player jellyfin-mpv-shim jftui libplacebo (4.157.0 → 4.192.0) minitube mnemosyne mpc-qt mpv mpv-mpris mpv-with-scripts mpv-with-scripts plex-media-player plex-mpv-shim python3.10-mpv python3.9-hydrus python3.9-mpv qimgv somafm-cli stremio-shell sublime-music ytfzf

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/michael/.cache/nixpkgs-review/rev-270a1294a6bc3658a1415a2b54e0be5d44fd33f6/build.nix
error: builder for '/nix/store/y2jvb7a2si51602n7fphvvbgdcfwvrx3-anki-2.1.15.drv' failed with exit code 1;
       last 10 log lines:
       > tests/test_addons.py::test_missingManifest
       > tests/test_addons.py::test_ignoreExtraKeys
       > tests/test_addons.py::test_conflictsMustBeStrings
       >   /build/anki-2.1.15/tests/test_addons.py:83: DeprecationWarning: Please use assertEqual instead.
       >     assert_equals(adm.readManifestFile(zfile), expectedManifest)
       >
       > -- Docs: https://docs.pytest.org/en/stable/warnings.html
       > =========================== short test summary info ============================
       > FAILED tests/test_collection.py::test_create_open - AssertionError
       > ================= 1 failed, 130 passed, 10 warnings in 24.28s ==================
       For full logs, run 'nix log /nix/store/y2jvb7a2si51602n7fphvvbgdcfwvrx3-anki-2.1.15.drv'.
error: 1 dependencies of derivation '/nix/store/lf0z4gg061825krmwv7bvnq66ki0lsvx-ankisyncd-2.2.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/pj37rrkcj41866dhn0qaa0hhg0ckav9n-mnemosyne-2.7.2.drv' failed to build
error: 3 dependencies of derivation '/nix/store/0jlx2adqxp6s28fx2b3mxr2pah28i0vz-review-shell.drv' failed to build
3 packages failed to build:
anki ankisyncd mnemosyne

22 packages built:
celluloid curseradio haruna hydrus jellyfin-media-player jellyfin-mpv-shim jftui libplacebo minitube mpc-qt mpv mpv-unwrapped mpvScripts.mpris plex-media-player plex-mpv-shim python310Packages.mpv python39Packages.mpv qimgv somafm-cli stremio sublime-music ytfzf

Anki is already broken on Hydra so this isn't a regression (the other two packages depend on it).


jsonio reader: preserve JSON attributes

Preserve json attributes when translating JSON to ZSON:

Parse numbers as float64s.
Maintain column ordering of the original JSON.
Do not convert primitive values to records.

This changed also required some changes to zson.Unmarshal allowing
json parsed numbers to be appropriately cast to the correct go type
destination.
Closes #2122

Closing in favor of another (faster) approach from @nwt


Increase core node pool machine memory

Upgrade the core node pool machine type to increase the available memory so that mino can pass around larger climate data artifacts more effectively in fan-out and fan-in workflow steps.
This is needed to test more efficient regridding in the downscaling step of the workflow. Right now, downscaling to 1/4 degree creates larger artifacts (annual NetCDF files, now ~+2.5 GiB) than we previously have dealt with.

I'm not convinced we need this for the moment. Marking "invalid" and closing.


Update iohk-logging dependency.

Update iohk-monitoring dependency, because of the latest changes related to structured logging.

bors r+


refactor: rm deprecated package os-homedir

The os-homedir package is deprecated as the behavior is identical to os.homedir() on node 4 and above:

This is not needed anymore. Use require('os').homedir() instead.

This PR removes the package and uses the os package instead.

🍰  Good catch.


Change tab names

change HEBREW translation

https://github.com/EMMAapp/EMMA/blob/c301b1ff43e992a3eb0bbe46a0e242915ae5ffeb/utils/translations/he.js#L107
Is this issue still relevant?

Yes, thank you for contacting me.
On Sun, 5 Jun 2022 at 11:35 AssafHizki @.***> wrote:

https://github.com/EMMAapp/EMMA/blob/c301b1ff43e992a3eb0bbe46a0e242915ae5ffeb/utils/translations/he.js#L107
Is this issue still relevant?
—
Reply to this email directly, view it on GitHub
https://github.com/EMMAapp/EMMA/issues/82#issuecomment-1146765098, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKAWWOM6XMTQPQOFUFJFY6LVNRRGZANCNFSM467X3ZAA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

To what test would you like to change?
'navbar': {
'journey': 'מסע',
'results': 'תוצאות',
'edit': 'הוספה',
'tips': 'טיפים',
'profile': 'פרופיל'
},

מסע ל ׳יומן׳
הוספה ל ׳אירוע חדש׳
תודה!
On Sun, 5 Jun 2022 at 11:43 AssafHizki @.***> wrote:

To what test would you like to change?
'navbar': {
'journey': 'מסע',
'results': 'תוצאות',
'edit': 'הוספה',
'tips': 'טיפים',
'profile': 'פרופיל'
},
—
Reply to this email directly, view it on GitHub
https://github.com/EMMAapp/EMMA/issues/82#issuecomment-1146766048, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKAWWOJNZ4HMAUXPODT3B3TVNRSDPANCNFSM467X3ZAA
.
You are receiving this because you commented.Message ID:
@.***>


Reporting -> Insight not working properly

Version 18.1.7, just updated.
I noticed a strange behaviour on the reporting section named "Insight".
I go on "Totals" tab then I go down to "Top usage ports/sources.
By default WAN is selected.
On the right of the graph I see several ip addresses (public ones) and if I go on the pie chart and select one of them, system takes me to the "Details" tab and put the ip address I select inside the "(src) Address" field as expected.
If I go back to the "Totals" tab, select "LAN" as the interface, choose and click on a IP adrress (private one this time) on the pie chart, system takes me to the "Details" tab but on the "src Address" put another IP address (public one) and NOT the one I chose before.
Beside if "WAN" is selected a small pop-up showing the ip address comes up when I go over the pie chart with the mouse but if I select LAN or another interface more often than not no IP is being shown.
I tried with Google Chrome and Mozilla Firefox and the behaviour is the same.
Is there a way to fix this "issue"?
Thanks a lot and cheers.
Michele.

@AdSchellevis can you take a look at this when you have a moment?

I'll have a look as soon as I can find a bit of time..

There was a bug reported in nv3d with  tooltips on pie charts, is that why it's there? I cannot make my mind up whether the bug is fixed or not after looking on Github.
I've commented out both instances of the *remove from the volt file and all seems to work OK.

Yes... I ended up here, which appears to be a fork.
https://github.com/krispo/angular-nvd3/pull/616

there seems to be a newer version then we're using, but the patch in the angular repo doesn't appear to have a relation with the original code. let me upgrade nvd3 and revert https://github.com/opnsense/core/commit/7d98ae11e62d96922d85995c4d494a7c94a019db maybe we're lucky...

I'll try and give it a hammering over the coming weekend and see if I can break it.

Hi.
I applied patches 3ac6a8 and fc0507.
Tooltips now show correctly but  if I go on "Totals" tab and go down to "Top usage ports/sources", select "LAN" or "DMZ" as the interface, choose and click on a IP address (private one) on pie chart (the one on the right), system takes me to the "Details" tab, put "LAN" in the interface filed but on the "src Address" put another IP address (a public one) and NOT the one I chose before. This is the same behaviour as before the patches.
Thanks.

ok, found the culprit, but can't find a very nice fix, https://github.com/opnsense/core/commit/08df2d02cb5537dd67146925c435f2ed892240a1 does the trick on my end, but the issue actually seems to be that the event won't reattach in https://github.com/opnsense/core/blob/08df2d02cb5537dd67146925c435f2ed892240a1/src/opnsense/mvc/app/views/OPNsense/Diagnostics/networkinsight.volt#L365

Hello, any news on this front?
Thanks.

New fix in 18.1.9 along with newer nvd3 library tomorrow.

Oh wow, very good to know!
Thanks a lot and cheers!

Be sure to check when out and close / report back if needed. Thanks!

Sorry but I don't undestand what I should check.

Once you have 18.1.9 installed, please recheck the page to confirm the reported errors are no longer there.

Ah ok sorry.
Yes of course I'll report it back.

Updated opnsense late this morning.
Made several tests. Insight behaviour seems to be regular and correct now.
Thanks to all the team for the good job made.
Cheers,
Michele.

@myksto71 thanks, closing then :)


Jesse: Watch tagoreedu.in

Jesse requests the watch of the watch_keyword tagoreedu\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tagoreedu\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Docker image 0.6.2 needs a re-release as the jar file is empty

The docker image at quay.io/pires/hazelcast-kubernetes:0.6.2 was apparently created before the release was available:
docker run --rm -i --entrypoint du quay.io/pires/hazelcast-kubernetes:0.6.2  -sh /bootstrapper.jar
...
4.0K	/bootstrapper.jar

versus
 docker run --rm -i --entrypoint du quay.io/pires/hazelcast-kubernetes:0.6.1  -sh /bootstrapper.jar
...
14.4M	/bootstrapper.jar

The file contents of the jar file:
docker run --rm -it --entrypoint cat quay.io/pires/hazelcast-kubernetes:0.6.2  /bootstrapper.jar
{"error":"Not Found"}

@nostra good catch.

@nostra can you try it now, please?

The jar file is correct now. Closing the issue.
Thanks!

Thank you 👍


Redirect URI is wrong documented under Create the ProxyIdentityExperienceFramework application

Redirect URI is wrong documented under Create the ProxyIdentityExperienceFramework application section.
Select App registrations.
Select New application registration.
For Name, use ProxyIdentityExperienceFramework.
For Application type, use Native.
For Redirect URI, use https://login.microsoftonline.com/yourtenant.onmicrosoft.com, where yourtenant is your Azure AD B2C tenant.
Redirect URI for native client can not start with http/https

@mchudinov Just checking back in here again. Please let us know of the URL of the particular documentation you were providing this feedback to so we can ensure your feedback is addressed by the right team.

Hello, this is my mistake. Documentation is correct. I just tried to use this instruction in wrong context in Azure. Issue can be closed.


Check that Zebra is only using one version of tokio

Motivation
Duplicate tokio dependencies might result in hard-to-diagnose bugs in Zebra.
This happens because code expects a single instance of some structs, but there are multiple instances running.
If we add duplicate dependencies, Zebra compiles slower, and its binaries will be larger.
This slows down CI, and can fill up CI disks.
Scheduling
This is unexpected work in Sprint 21, to make sure that tokio is upgraded correctly.
It should be merged with the tokio roll-up PR.
Solution

Require a single tokio version in deny.toml
Ban tokio git sources in deny.toml

Review
@jvff should review this PR.
It is based on PR #2986.
Reviewer Checklist

[ ] CI passes when combined with the tokio upgrades
[ ] deny.toml changes makes sense

Nice catch! I didn't know about that file :sweat:

Would it make sense to merge this PR into #2986 and merge this after the Tokio upgrade? That would help to avoid feature creep in the rollup PR. IMHO, we could upgrade to Tokio first, and then fix any bugs that this PR finds afterwards.

Would it make sense to merge this PR into #2986 and merge this after the Tokio upgrade? That would help to avoid feature creep in the rollup PR. IMHO, we could upgrade to Tokio first, and then fix any bugs that this PR finds afterwards.

This PR tests that the dependencies are correct in the rollup PR.
Duplicate crates can cause weird runtime errors and test failures.
The duplicate checks might also reveal missed dependency updates, which could require extra code updates.
So I think it's helpful to include it in the rollup, to avoid a half-broken main branch.

Merged through #2994.