execute function does not recognize ScheduleBlock

Information

Qiskit Terra version: main
Python version: N/A
Operating system: N/A

What is the current behavior?
When pulse.build produces a ScheduleBlock and it is submitted to be executed by the backend via execute(schedule_block, backend) an error AttributeError: 'ScheduleBlock' object has no attribute 'calibrations' . is raised.
Steps to reproduce the problem
# Importing standard Qiskit libraries
from qiskit import QuantumCircuit, transpile, Aer, IBMQ, pulse, execute

provider = IBMQ.load_account()
backend = provider.get_backend("ibmq_armonk")

with pulse.build() as sched_block:
    pulse.play(pulse.Constant(160, 1.0), pulse.DriveChannel(0))

execute(sched_block, backend)

What is the expected behavior?
Execute should accept a ScheduleBlock as well as execute and this should be submitted to backend.run.
Suggested solutions
Within execute when matching on Schedule instead match on a Union[Schedule, ScheduleBlock].

@taalexander can I look at this?

go for it @TheGupta2012, I've assigned to you 😄 You can check out qiskit/execute_function.py for how Schedules are handled, and adapt to handle ScheduleBlocks as well

@taalexander would you be able to give an advice on how I could make a test independent of the aer module? This is because in the unit test I was trying to execute the ScheduleBlock instruction on the FakeArmonk and then trying to assert the value of the returned results.
This is my current test :
    def test_execute_block(self):
        """Test executing a ScheduleBlock on a Pulse backend"""

        # building the pulse
        with pulse.build(name="test_block") as sched_block:
            pulse.play(pulse.Constant(160, 1.0), pulse.DriveChannel(0))
            pulse.acquire(50, pulse.MeasureChannel(0), pulse.MemorySlot(0))

        # execute..
        test_job = execute(sched_block, self.backend)
        test_result = test_job.result().results[0]

        h_true = "QobjExperimentHeader(memory_slots=1, metadata={}, name='test_block', ode_t=0.0)"
        d_true = "ExperimentResultData(counts={'0x0': 1024},"
        d_true += " statevector=[[1.0, 0.0], [0.0, 0.0], [0.0, 0.0]])"
        self.assertEqual(test_result.header, h_true)
        self.assertEqual(test_result.data, d_true)

This is the traceback that I get :
      File "D:\QUANTUM\qiskit-terra\test\python\pulse\test_block.py", line 441, in test_execute_block
    test_job = execute(sched_block, self.backend)

      File "D:\QUANTUM\qiskit-terra\qiskit\execute_function.py", line 394, in execute
    job = backend.run(experiments, **run_kwargs)

      File "D:\QUANTUM\qiskit-terra\qiskit\test\mock\fake_backend.py", line 155, in run
    raise QiskitError("Unable to run pulse schedules without qiskit-aer installed")

    qiskit.exceptions.QiskitError: 'Unable to run pulse schedules without qiskit-aer installed'

Hey @taalexander , I have a small doubt. I have added a small unit test for the updated code but the thing is that it is dependent on backend.run or execute function. Since aer-simulator is not installed in terra, the test fails. Is there any kind of workaround for this so that I can correctly add a test for the added functionality? Here's the test I added in test/python/pulse/test_block.py :
    def test_execute_block(self):
        """Test executing a ScheduleBlock on a Pulse backend"""

        with pulse.build(name="test_block") as sched_block:
            pulse.play(pulse.Constant(160, 1.0), pulse.DriveChannel(0))
            pulse.acquire(50, pulse.MeasureChannel(0), pulse.MemorySlot(0))

        test_job = self.backend.run(sched_block)
        test_result = test_job.result().results[0]

        h_true = "QobjExperimentHeader(memory_slots=1, metadata={}, name='test_block', ode_t=0.0)"
        d_true = "ExperimentResultData(counts={'0x0': 1024},"
        d_true += " statevector=[[1.0, 0.0], [0.0, 0.0], [0.0, 0.0]])"

        self.assertEqual(str(test_result.header), h_true)
        self.assertEqual(str(test_result.data), d_true)

Error message :
 Traceback (most recent call last):

      File "D:\QUANTUM\qiskit-terra\test\python\pulse\test_block.py", line 439, in test_execute_block
    test_job = self.backend.run(sched_block)

      File "D:\QUANTUM\qiskit-terra\qiskit\test\mock\fake_backend.py", line 155, in run
    raise QiskitError("Unable to run pulse schedules without qiskit-aer installed")

    qiskit.exceptions.QiskitError: 'Unable to run pulse schedules without qiskit-aer installed'

Thanks!

Hi @TheGupta2012 can you push your test code to your branch please? I'm not seeing your error when I try your test, maybe double check you have all the requirements installed (make sure you've followed the steps here)

@TheGupta2012: Terra's CI pipelines install Aer, so it'll be available on CI.  Locally, you need to ensure that you've installed Aer yourself to run the tests.  If you are writing a test that absolutely requires Aer, then make sure you also put in a unittest.skipIf decorator that checks if Aer is available.  There are some examples of those in the tests if you search for the string "qiskit-aer doesn't appear to be installed" in the tests folder.

Thanks a lot @jakelishman, I did not know that the testing suite contains aer too! I've added the decorator but I wanted to know does the CI pipelines then install all of the qiskit components i.e. terra, aer, aqua and ignis ? Is that necessary to install them from source locally too? Thank you!

If you look in the azure-pipelines.yml file in the repo root, you can see the whole set up procedure.  If I remember correctly, Terra's CI for most of the tests only installs Aer (since Terra and Aer have some co-dependence), and we only install Ignis for the tutorials.

We also only install aer on a subset of ci jobs and only from a release on pypi. We do this very specifically to avoid adding an accidental bidirectional dependency between aer and terra (where aer depends on aer and aer depends on terra, even if just for testing) because the dependency should only be in a single direction (and aer depends on terra).

We also only install aer on a subset of ci jobs and only from a release on pypi. We do this very specifically to avoid adding an accidental bidirectional dependency between aer and terra (where aer depends on aer and aer depends on terra, even if just for testing) because the dependency should only be in a single direction (and aer depends on terra).

I had initially thought that the tox environment I had locally was almost similar to what the pipelines used (for Windows). Thanks a lot for all these insights!

Apparently, when I pushed my test to the PR, I am getting this error: qiskit.providers.aer.aererror.AerError: 'PulseSimulator requires a system model to run.' Would anyone be able to highlight what is missing when I try to run the circuit on the fake backend?
Full traceback : traceback

Taking a look at your code I think It's failing because of line 141 in fake_backend.py where system_model is not being set because it looks like PulseSystemModel (imported on line 139) doesn't seem to exist? Not sure if it used to exist and got removed or something, maybe @mtreinish has a better idea?

I think this is a bug in Terra's FakeBackend caller - #7059.  Abby: PulseSystemModel is in Aer (qiskit-aer/qiskit/providers/aer/pulse/system_models/pulse_system_mode.py), so it doesn't appear in the Terra repo.


Consider using envoy route check tool

https://www.envoyproxy.io/docs/envoy/latest/install/tools/route_table_check_tool
It would be pretty interesting to directly use the envoy check tool mentioned above. That should allow much richer/lower maintenance test cases as you can cover all of Istio api surface.
I would imagine this looks like translating the istio config to envoy config then running through the envoy tool

We have considered translating Istio config into Envoy but was afraid it wasn't fit into a hackday project as we wanted to delivery something concrete to add to our pipeline before applying the virtualservices.
This indeed looks a promising approach moving forward tho. Highly appreciate the input.

I think the biggest problem is also the fact that the envoy tool is based on routes, so you need a way to translate the request from the test to which route will be used. Normally that is handled by listeners/filter chain matching - hopefully we would not re-implement that logic. The actual part of running the istio -> envoy offline isn't super clean but we are working on improving it. https://github.com/istio/istio/blob/bdac0787e932c747154e996cfb2aabef6c820b88/pilot/pkg/xds/bench_test.go#L58 is a good example of doing it (and other stuff, so its a bit messier)

Thanks, this reference will be quite useful and already gives me a direction, I will get more familiar with the tool and codebase and try to come up with a proof of concept after my vacation. Do you think this would be valuable for upstream istioctl? like istioctl analyze today. I haven't look at the code/dependencies, etc. to see how much work would be, just something I thought.

My main concern there is that it needs to call out to an external binary (the envoy tool). Might be easiest to ship it as a docker image of something that contains the go binary doing the logic and the envoy binary we call out to. That go binary may or may not be istioctl itself. Probably short term it would be it's own thing then possibly in the future it can be merged in

yeah right, it makes sense. Let's start with that.

An update on this old issue. I've built a prototype and we have been running internally in parallel with existing tooling.
To make it work with our existing tests I forked Istio proxy to build and patch the envoy router tool to work around runtime configuration issues. I've opened an issue https://github.com/envoyproxy/envoy/issues/35174 to find a way forward without patching the tool.


Add Jaml Schema Validation

User Story
Autocomplete and value validation for YAML files, can be good for console and core.

Acceptance Criteria

Link to feature: https://jinaai.productboard.com/feature-board/planning/features/7100561


remove Generic types for imports

remove Generic types variable part when read imports declarations
fix issue "Base class properties not found" #174

Thanks for the contribution. I'm currently totally swamped by work and too burnt to do much in the evenings. So you're help is appreciated. 👍
Published to 0.9.25

it is nothing, thanks for building this repo.


ionic framework resolver

ionic framework resolver

@antfu  ionic-framework has 48k starts, I think we can have it.


Add Documation n how to properly mount NFS share on Windows clients

I have been struggling to find decent and consistent documentation on how a Windows client should be configured to mount and access an NFS share. There are a number of articles out on the Internet, although they seem to suggest Registry edits and the use of the old mount command via Cmd.exe. It would be good for Microsoft to document how this can be achieved in various OS.
Further, on this page, you make reference to the client and server versions supported (https://learn.microsoft.com/en-us/windows-server/storage/nfs/nfs-overview?source=recommendations#windows-and-windows-server-versions). There is no reference of a Windows 11 client and the NFS version supported. It seems odd that Windows Servers back to 2012 supported service NFS v4.1, but the clients on all Windows OS only support up to v3. Is this correct?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 20741e00-6d40-c122-88b2-562b38d39b1e
Version Independent ID: e556fb83-dc86-94ed-d0e0-616a6499c1e8
Content: Network File System overview
Content Source: WindowsServerDocs/storage/nfs/nfs-overview.md
Product: windows-server
Technology: storage
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

#assign:xelu86

Hey @swinster,
Thanks again for contacting Microsoft. We value your feedback.
-This article was recently updated to include Windows 11 as a supported OS.
-Yes, NFSv3 is still the latest version for all clients on Windows OS.
We do have an article on Mounting NFS and it is suggested to use the command line to perform certain actions (mount/unmount). Depending on the action needed, it can be performed using the native interface and not the CLI. The TOC to the left has more articles surrounding NFS that may be beneficial depending on your needs. Hopefully this helps.
We will now be closing this thread. Thank you and have a most pleasant day. #please-close


descheduler: allow annotated pod pass non-retrievable filter

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

one more ut for this？

/lgtm
/approve

/lgtm

/approve


Feat: Added demo translation for a sample jenkins pipeline by leveraging the builtin JSON export API

Codecov Report
Attention: Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (6092f76) to head (cc92cb0).
Report is 23 commits behind head on main.

Files with missing lines
Patch %
Lines

orbiter_translations/jenkins/json_demo.py
87.27%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   90.95%   90.64%   -0.31%
==========================================
  Files          13       17       +4
  Lines         431      588     +157
==========================================
+ Hits          392      533     +141
- Misses         39       55      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[WIP] Use containers/image lib instead of docker

This will use github.com/containers/image to pull images instead of the local docker deamon.
Also adding a flag to use the docker daemon (--use-docker)
Fixes #35

TODO:

[ ] fix output
[ ] unified image interface
[ ] rebase on master (?) to add dependencies to godeps

@pweil- @simon3z Please take a look.
I will continue working on this in a few days.

@enoodle maybe you can get some help/review here from @ilackarms

@enoodle @simon3z what is the current status of this? containers/image seems reasonable here as we don't need to deal with mounting the docker socket into image-scanner container so we can de-escalate privileges for that container (although we will still need access to clam socket or openscap ;-)

@mfojtik it would be nice to make this happen for 2.2 (I think it's fully backward-compatible).
@enoodle / @ilackarms do you have time to work on this?

although we will still need access to clam socket or openscap ;-)

@mfojtik can we make Pods/Services out of those?

This is mostly working (need to fix those 3 points listed above) but I am encountering one problem that I couldn't solve so far: passing openshift docker registry certificates.
I have added an option to add specific certificates to the pod for the registry but when using from ManageIQ there is no way to get the "registry-certificates" secret from "default" namespace. Any suggestions?

I have added an option to add specific certificates to the pod for the registry but when using from ManageIQ there is no way to get the "registry-certificates" secret from "default" namespace. Any suggestions?

cc @mfojtik @pweil-

@enoodle how do you connect to registry in CF? are you using insecure transport? if you are connecting from inside kube, the CA is in /var/run/secrets/kubernetes...

@mfojtik CF/ManageIQ is not connecting to the registry, it gives image-inspector the image reference and expect it to handle these matters.
When using the docker client it knows to handle the openshift docker registry on its own somehow, but when using this library we need to pass it the certificates to verify the registry.
I have seen that the registry is getting the certificates through a secret volume ("registry-certificates") but its in a different namespace than the one we use to start the image-inspector pods so I can't attach it.

@enoodle see https://github.com/ilackarms/image-inspector/blob/65631449b0312cfe25908c5b9205eda7224800b1/kubernetes/image-inspector-app.yaml for example of how to configure authentication to the private registry. as long as the serviceAccount specified has read access to the registry, the changes you've made will work to authenticate
note: the foo username is ignored by the registry, but it's still necessary to supply something

I have the feeling that @enoodle is busy on several other fronts. @ilackarms have you talked to him to check if you could pick it up?

yes @simon3z; I had talked to him about opening a PR to his branch which he could then use to update this PR. however if it would be faster, I can just open a new PR based on my branch

however if it would be faster, I can just open a new PR based on my branch

@ilackarms OK for me.


Update sbt-release to 1.0.11

Updates com.github.gseitz:sbt-release from 1.0.10 to 1.0.11.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #40   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          84     84
  Branches        5      5
=====================================
  Hits           84     84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ab50d...fed0999. Read the comment docs.


Add means of controlling the content disposition filename

As per http://stackoverflow.com/questions/93551/how-to-encode-the-filename-parameter-of-content-disposition-header-in-http
https://github.com/slamdata/slamdata/issues/1369
I blindly tried adding the appropriate headers to the request-headers query param, crossing my fingers that it would magically work, to no avail 😆
Right now the UI lets you type a filename, but its an obnoxious noop.

When using mitmproxy to intercept a request and update the request-headers query param to {"Accept":"application/ldjson;disposition=\"attachment; filename=random_file\""} the response contains Content-Disposition:  attachment; filename="random_file" and Chrome downloads the file as the specified filename. @natefaubion Is that workable/reasonable?

That should be workable as long as I can do the UTF-8 encoding as in the linked stackoverflow post. Specific test case would be Content-Disposition: attachment; filename*=UTF-8''Na%C3%AFve%20file.txt.

Currently quotes are being added to the filename* value and that appears to throw off at least Chrome. I'll look into it further.

The behavior stems from Http4s supporting RFC 2616 and not RFC 5987.


Consider deprecating in favor of upstream's images

Upstream maintains their own set of images at https://hub.docker.com/r/percona/, and we should seriously consider deprecating this one (similar to ownCloud; https://github.com/docker-library/docs/pull/1251) in favor of theirs. :+1:

@EvgeniyPatlan @vadimtk sorry for the cold-ping, but I'd love to have your opinions on this if you're willing to share (or willing to redirect this to someone who can opine on this better), since you appear to be maintaining https://github.com/percona/percona-docker :pray: :heart:
(Alternatively, we'd love to work with y'all to have you take over this image officially, but it's totally understandable if that's not something that's interesting to Percona ATM. :heart:)

I am fine if upsteam uses our images, but it is out of our hands.
My preference would be to have more descriptive names though, like percona-server, percona-xtradb-cluster, percona-server-mongodb, as we have multiple products starting with percona-

@vadimtk you mean if we use your images for https://hub.docker.com//percona/?  We're discussing either deprecating that image entirely (like https://hub.docker.com//owncloud/, for example) or having you folks be more involved, but it sounds like your preference would be for deprecation?
(Thanks so much for engaging in discussion with us! :heart:)

@tianon , no we do not want to deprecate that! my preference would be to redirect that to https://hub.docker.com//percona-server/ and use our images.
If that is not possible, than we can use our images for https://hub.docker.com//percona/

Unfortunately, Docker Hub doesn't support redirection like that, so our best bet is likely to be consuming your Dockerfile directly from https://github.com/percona/percona-docker, which is going to involve updating https://github.com/docker-library/official-images/blob/master/library/percona and reviewing the actual source bits to see what the delta is.  Taking a cursory look over the contents of the entrypoint script in the percona-server, it would need at least some minor initial changes just to be compatible with the guidelines/requirements in https://github.com/docker-library/official-images#readme.
Is that work you folks are willing to take on in order to take over this image properly?  How can we help to support that work?
There are also likely some docs updates we'll need to make over at https://github.com/docker-library/docs/tree/master/percona (where to file issues, who the image maintainer is, potentially any usage changes, etc).

@tianon let us look into that.

Hey @vadimtk, any update? :pray: :heart:

@tianon We are still looking into this, sorry been busy with our releases.

Hi @tianon,
Sorry for a very long response!
We (@percona) are interested in maintaining https://hub.docker.com/_/percona/ images.
Our current release procedure looks like this:

automatically build a docker image to perconalab/percona-server Docker Hub repo
run automatic and manual testing on the image
during the product release, we run docker tag perconalab/pmm-server:version percona/pmm-server:version and docker push percona/pmm-server:version

So the best case for us would be to have docker push percona:version rights.
In such a case, we can deliver a QA verified/tested image.
Is it possible to get docker push percona:version rights?
Another thing: we have a lot of products and worry that end users may not fully understand what product is hidden under the general percona name.
Is it possible to get official Docker Hub images for percona-server, percona-xtradb-cluster, pmm-server, percona-server-mongodb?
Anyway, we are fully open to collaboration and can make any needed changes to
https://github.com/percona/percona-docker repository.
Just let me know what is required, and I will prepare PR.

Is it possible to get docker push percona:version rights?

Unfortunately, no -- see https://github.com/docker-library/official-images#readme for information about the top-level images.  All of those (and all changes to them) are peer-reviewed via that repository.  It would be possible to get more repos there, but it might also make sense to simply place those as tags of this existing percona image, especially if the way they are run / parameters to them is similar?  For example, percona:server-5.7.x, percona:server-mongodb-5.7.x, etc.
That readme I've linked above also outlines the requirements the image is expected to meet in order to qualify for the program (see especially https://github.com/docker-library/official-images#review-guidelines and the following contents).
It's likely also worth comparing the functionality of this repository's docker-entrypoint.sh script to the functionality of the scripts you've got for those upstream images to ensure that usage is roughly equivalent -- there might be a few bits where the usage differs, but I don't think it'll be too drastic.  The entrypoint script here in this repository is probably also a good example for how to make sure the image follows the larger official-images guidelines, at least for the runtime aspects.

Hi @tianon,
Thanks for the clarification, we are ok to have one single repo for many products.
So, if I understood correctly the next step is to read guidelines carefully and prepare PR to https://github.com/docker-library/docs/tree/master/percona repo.
We can train with percona:8.0.12.alpha release.
It is public available alpha release, and I can make changes into 8.0-alpha images more freely.
When all Docker Hub recommendations satisfied and PR ready for a merge (approved from your side) I can ask our QA run all needed tests on the modified image.
If everything OK from QA side - we can merge PR.
If the process works fine from both sides - we can start to rework 5.x images.
What do you think?

Hi all,
Just wondering will this move affect current docker-library/percona users? How do you plan to publish the reworked images, are they going to be published under a new tag?
Best regards,
Vladimir

Hi @jelovac,
I think the following tags will be replaced - percona:latest, percona:5 percona:5.7 percona:5.6, percona:5.5.
I believe tags with exact version (like percona:5.5.61-stretch) shouldn't be changed or removed.

Hi @tianon,
could you please review?

additional mysql image tests https://github.com/docker-library/official-images/pull/4944
new entry points from original mysql image https://github.com/docker-library/percona/pull/71

the two images entrypoint are different. shouldn't be just replaced. last time i looked percona images lacked initdb.d support.

Hi @glensc,
please check the current version of entrypoint - https://github.com/percona/percona-docker/blob/master/percona-server.57/ps-entry.sh
if you expect any kind of regression, please show me which functionality doesn't exist in upstream percona images.

@delgod as i guessed, my information is not current :)
however, i have questions:
what about user/group id? library/percona uses fixed uid/gid based on top level image (which results uid=999, gid=999 at this moment): https://github.com/docker-library/percona/blob/0f4b22adef232551c763308367d3b54d586a4a38/5.7/Dockerfile#L4-L5
but percona hardcodes 1001:1001:

https://github.com/percona/percona-docker/blob/f176d725d49b6c241263ea796eddb58f17e415f2/percona-server.57/Dockerfile#L5

and i don't see any ocurrence of chown/chmod to mitigate migration pain:

https://github.com/percona/percona-docker/blob/f176d725d49b6c241263ea796eddb58f17e415f2/percona-server.57/ps-entry.sh

i found PR in library/mysql repo:

https://github.com/docker-library/mysql/pull/161

second question is about files being owned by root group:
but later uses 1001:0, which is super odd:

https://github.com/percona/percona-docker/blob/f176d725d49b6c241263ea796eddb58f17e415f2/percona-server.57/Dockerfile#L33

i.e the extra writable to root group behavior

Hi @glensc,
thanks for the report, I have added compatibility logic in this PR -
https://github.com/percona/percona-docker/pull/51
is it enough?
about root group, the answer is simple - in OpenShift you get random EUID, you cannot predict EUID.
So simples workaround, provide write permission for root group, in such case mysqld always have enough permissions for write.

This is done now: https://github.com/docker-library/official-images/pull/4977 :tada:


Basic Data Structures: Modify an Array Stored in an Object does not allow a new array to be returned

Describe your problem and - if possible - how to reproduce it
In the challenge Basic Data Structures: Modify an Array Stored in an Object, the following function passes the challenge.
function addFriend(userObj, friend) {
  // change code below this line
  userObj.data.friends.push(friend);
  return userObj.data.friends;
  // change code above this line
}

The instructions state the following:

Finish writing it so that it takes a user object and adds the name of the friend argument to the array stored in user.data.friends and returns that array.

Notice I emphasized the word that above.  My question is should it matter if the original array is mutated which this function does or should the function be allowed to return a new array with the correct elements?  For example, the following code returns an new array with the same elements, but does not mutate the original array.  I guess my secondary question is, should, we be teaching not to mutate the global object?
function addFriend(userObj, friend) {
  // change code below this line
  return [...userObj.data.friends, friend];
  // change code above this line
}

Currently, this code passes the 1st and 3rd test, but fails the 2nd test, because the test is checking if the global object's friends array length is the same as the length of the array returned by the function.  Since my solution above does not mutate the original object's friends array, the length will be different.
Add a Link to the page with the problem
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/modify-an-array-stored-in-an-object
Tell us about your browser and operating system

Browser Name: Chrome
Browser Version: latest
Operating System: Windows 8.1

If possible, add a screenshot here

the following code returns an new array with the same elements, but does not mutate the original array.

But the name of the challenge is : Modify an Array Stored in an Object.
So if you didn't modify the original Array, it seems like it should fail the test.


ci: Split out linting from testing

Changes the makefile.yml workflow to have two separate jobs: lint and test.
The lint job can take minutes on its own and is an easy way to speed up the PR checking process by passing off the test portion to another runner.

The CI is failing because of #744.  This needs to be merged.


[Enhancement] Add crc32c checksum to persistent index's l0 & persistent index compression (backport #30841) (backport #32112)

Backport #30841 #32112
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

https://github.com/Mergifyio backport branch-3.0

https://github.com/Mergifyio backport branch-3.1-cs


Cannot use apollo in Typescript @Component decorator with 'components' key

In my vue typescript application, I'm trying to use vue apollo with the vue-property-decorator library.
I have the following code:
import { Component, Prop, Vue } from 'vue-property-decorator'
import HeaderPrimary from<EMAIL_ADDRESS>import query from<EMAIL_ADDRESS>
@Component({
	components: {           // Error from here
		HeaderPrimary,  // ...
	},                      // to here.
	apollo: {
		users: query,
	},
})
export default class TheHeader extends Vue {
	users: any = null
}

I'm receiving the following error:
Argument of type '{ components: { HeaderPrimary: {}; }; apollo: { users: DocumentNode; }; }' is not assignable to parameter of type 'VueClass<Vue>'.
  Object literal may only specify known properties, but 'components' does not exist in type 'VueClass<Vue>'. Did you mean to write 'component'?

When I remove the apollo part of the @Component, the error goes away.
The app still runs fine and queries correctly, but unfortunately I'm not sure how to get past this TypeScript error.

I have exactly the same issue and unfortunately @Kresten suggestion didn't work for me. Any help would be much appreciated :)

any solution to this?

@Acidic9 @jurgisrudaks @gdpaulmil
I suggest this is not gonna be happened if vue-apollo module is imported correct.
If it's not loaded, it could be like as @Acidic9 said.
like below

but if you import vue-apollo module somewhere on your codebase, it should be work.
As you can see error has disapieared.

That doesn't work for me. I've imported vue-apollo as shown and in multiple other places. The only situation that works for a DocumentNode is assigning with a function:
import { SomeDocument } from 'documents'

apollo: {
  thing: () => SomeDocument
}

@bbugh
Can you share us whole of your example?
This code is working for me..
<script lang="ts">
import { Vue, Component } from "vue-property-decorator";
import gqlTranslations from "./test.graphql";
import Logo from "~/components/Logo.vue";
import "vue-apollo";

@Component({
  components: {
    Logo
  },
  apollo: {
    translations: () => gqlTranslations
  }
})
export default class IndexPage extends Vue {
  private translations = {};
}
</script>

And it gets off from the subject but what is this function use case?
This looks undocumented(https://vue-apollo.netlify.com/api/smart-query.html#options) and also I have not been able to sure this gets to work from code base of vue-apollo.
Also I think you can write it like this.
Does this make sence for you?
@Component({
  components: {
    Logo
  },
  apollo: {
    translations: {
      query: () => gqlTranslations
    },
  },
})

Using a function works but it's not ideal. When will this be fixed ?

It will be fixed by using the composition function. I'm almost giving up fixing all of those typing issues, which is both frustrating and taking way too much of my time (still open to PRs :smile_cat: ).

@Akryum
By mentioned about composition function, Do you mean Vue Composition API?
Could you help to explain how to use the composition function to fix this?
Is it like
setup() {
    const apollo = {};
    apollo.addSmartQuery('todoList', ...);

    // expose to template
    return {
      apollo
    }
  }

or like this?
setup() {
    const apollo = {
      todoList: {
         query: getTodoList
      }
    };

    // expose to template
    return {
      apollo
    }
  }

See https://v4.apollo.vuejs.org/guide-composable/

Just add "vue-apollo" in tsconfig.json :
{
  "compilerOptions": {
    "types": [..., "vue-apollo"]
  }
}

@Akryum the purpose of the composition API for vue 2 is to let developers experiment the composition API in Vue 3. But it is not something to be used in production, as stated on the repo in bold:

We do not recommend using this package for production yet at this stage

So using the composition API in Vue 2 seems not to be a viable solution, is it ? I think there should be both:

a vue-apollo release for Vue 2 without using the composition API
optionally a vue-apollo release for Vue 3 using exclusively the composition API

Don't you think solutions built around the composition API for Vue 2 will be compromised at Vue 3 release ?

thanks ,  i got it that how to use vue-apollo in typescript!

Just add "vue-apollo" in tsconfig.json :
{
  "compilerOptions": {
    "types": [..., "vue-apollo"]
  }
}

Worked for me. Thanks


upgraded cdk to 2.85.0 and fixed log bucket policy issue

Issue #3 , if available:
Description of changes:
Upgrade CDK to 2.85.0 and removed code to grant policy permissions to logging bucket.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

merged request after review.


Getting and using bash command response data

Describe the solution you'd like
I wanted to auto lower volume of a particular app's volume while TTS is playing for announcements that I setup. I was able to get this working using "pactl set-sink-input-volume <Sink Input #> 50%". I then followed it up after the TTS with 100% to turn it back up. It has worked great so far, except the Sink Input # keeps changing often for some reason for my web browser.
I tried using name of it which stays the same, but nothing I used worked, so I had to use the number, so unless I am missing something with the name, I was going to see about how I could get the number from the response to "pactl list sink-inputs" which is how I learn it each time it changes. Below is the response to this command. You can see the data I want is in multiple places, starting at the beginning.
Edit:
"pactl list short sink-inputs" returns something shorter, first thing is also what I am looking for, perhaps a bit easier.
1804387 47      1804386 PipeWire        float32le 2ch 48000Hz
Sink Input #1804387
        Driver: PipeWire
        Owner Module: n/a
        Client: 1804386
        Sink: 47
        Sample Specification: float32le 2ch 48000Hz
        Channel Map: front-left,front-right
        Format: pcm, format.sample_format = "\"float32le\""  format.rate = "48000"  format.channels = "2"  format.channel_map = "\"front-left,front-right\""
        Corked: no
        Mute: no
        Volume: front-left: 65536 / 100% / 0.00 dB,   front-right: 65536 / 100% / 0.00 dB
                balance 0.00
        Buffer Latency: 0 usec
        Sink Latency: 0 usec
        Resample method: PipeWire
        Properties:
                client.api = "pipewire-pulse"
                pulse.server.type = "unix"
                application.name = "Chromium"
                application.process.id = "3794856"
                application.process.user = "iceman"
                application.process.host = "iceman-linux"
                application.process.binary = "vivaldi-bin"
                application.language = "en_US.UTF-8"
                window.x11.display = ":0"
                application.process.machine_id = "ce0311944aa84849940ccd5d3d4a4432"
                application.process.session_id = "2"
                application.icon_name = "chromium-browser"
                media.name = "Playback"
                node.rate = "1/48000"
                node.latency = "1024/48000"
                stream.is-live = "true"
                node.name = "Chromium"
                node.autoconnect = "true"
                node.want-driver = "true"
                media.class = "Stream/Output/Audio"
                adapt.follower.spa-node = ""
                object.register = "false"
                factory.id = "6"
                clock.quantum-limit = "8192"
                factory.mode = "split"
                audio.adapt.follower = ""
                library.name = "audioconvert/libspa-audioconvert"
                client.id = "73"
                object.id = "61"
                object.serial = "1804387"
                pulse.attr.maxlength = "4194304"
                pulse.attr.tlength = "16384"
                pulse.attr.prebuf = "12296"
                pulse.attr.minreq = "4096"
                module-stream-restore.id = "sink-input-by-application-name:Chromium"

Additional context
No response

"pactl list short sink-inputs" returns something shorter, first thing is also what I am looking for, perhaps a bit easier.
1804387 47      1804386 PipeWire        float32le 2ch 48000Hz

I don't fully understand what you want to do, but it's a good idea to return the result of the bash command to a new MQTT topic.
You could create an automation that subscribes to that topic and get the result you want from that.
I'll try to implement it for the next release.

Okay, thanks. I just want to be able to read data from a bash command result since what am looking for keeps changing and that is the only way I see to accomplish what I want.

I've just added the option for the bash command to publish the results on a new topic.
You can use MQTT explorer to find the exact topic you will have to subscribe to get the data.
For now you can only use it if you install lnxlink as a development platform.

This should work fine on the latest release 2023.8.0.


Fix problem with brightness

Description:
Related issue (if applicable): fixes #
https://community.home-assistant.io/t/tradfri-update-needs-change-in-ha/31180/23?u=dvd77

Where is the limitation to max brightness 254, in home assistant or pytradfri? I had thought both supported max 255.

@MartinHjelmare the gateway reports back 254 when having set max brightness in the app.


Synchronized output stream

Currently, this only is used for std::cout but could be used for other output streams. PrintingFailureLogger and ContextEventLogger both use the sync_ostream_wrapper for outputting to std::cout.

Note that you need to rebase this PR since some CI stuff has been updated. Otherwise this should be good to go :)


Error

What happened?

What environment are you seeing this error in? The following would be helpful:

Type of OS
Are you running in a container
Python3 Version

I run it in a container.
I use docker to run it.

However, I get this problem

However, I get this problem

Very strange, and you followed the exact instructions as above? I'm curious about what your docker host OS is. I ran that on OS X,  so perhaps there is something unusual going on when running it on a Linux docker host.

closing this for now as i have not been able to replicate it.


Release for Python 3.11

[x] Start from the release branch
git checkout release
[x] Make a new branch for the release cycle
git checkout -b releases/{version}
[x] Merge the current master with the release
git pull origin master
[x] Start a release
bumpversion release
[x] Edit doc/CHANGELOG.rst
[x] Send the release to be evaluated
git push
[ ] Verify CI on azure
[ ] Manually trigger a jpype.release on azure
If successful, download the artifacts for publication.
[ ] Advance the release pointer
git checkout release
git merge releases/<version>
[ ] Publish the release

Add draft release on github
Attach the artifacts to the release.

[ ] Start master on a new cycle

Use a PR to pull release back to master
git checkout master
git checkout -b cycle
git merge release
bumpversion patch
Use PR to insert the cycle in master

@marscher  Not sure how many tries I will have to take for this release.  There appears to be a problem with some of the the pinned versions not working with Python3.11.   Hopefully unpinning them will work.   If not I will have to come up with a new testing solution.

Looks like the release will clear.   I should be able to release tomorrow morning.

It appears that the linux image does not have 3.11 available.   I can distribute the rest and then try to get those built later.

@marscher It seems like we need to change to manylinux2014 image to get Python 3.11.   I can change to this for all future builds.  But for now I am just updating the release script for a one off run.   I am not sure if I need to split the build so that pre 3.11 goes with the manylinux2010 image.  If you have some insight I can get it setup for our future releases.
Assuming everything looks good, the ball is in your court to push this to PyPi.  Given the level of changes required for 3.11, I don't think one day after the release is too bad given that we have to wait for the azure image to be updated before we can release.

Thanks! PyPI push of wheels and source dist has been done.

Conda-forge support for 3.11 will be added by their bot soon. It has to pick up the PyPI push first.


Automatically generate API documents

What would you like to be added:
protoc-gen-doc can can easily generate documents  based on proto
https://github.com/pseudomuto/protoc-gen-doc
Why is this needed:
But there are problems with the generated in some places, as shown below, so the proto files need to be modified is in some places, such as remove empty lines from comments

I will modify the proto file and generate API documents.


Pattern: rich overview, visual design specs

Wonil-Suh1 created the following on Sep 08:
User story
As a user of IBM.com, I need a way to understand the benefits and value of the product / solution / offering presented on the page quickly through text and media such as video so that I can make a decision on whether I should continue with the page or not.
Notes
This is a pattern that is not clearly defined from our past work.
Acceptance criteria

[ ] Specs have been produced for all responsive break points

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1610

This is old work and no longer relevant as per new pattern ontology. Closing.


Loosen httpx constraint

This loosens the httpx constraint to allow any version <1. I have pinned httpx as a dev dependency to the latest version of httpx (0.27.0) so tests don't just start breaking one day.
Pinning dependencies in a library forces downstream consumers to follow the requirements of the library. In the case of Home Assistant, this is not compatible as Home Assistant aggressively follows the latest version of httpx.
Unblocks https://github.com/home-assistant/core/pull/113962
Replaces #42

@mxyng sorry for the ping. We're preparing a new Home Assistant release this Wednesday and would like to include an Ollama integration (https://github.com/home-assistant/core/pull/113962), but it depends on this PR. Would you have time today or tomorrow to take a look? Thanks!

Setting this kind of constraint on a project pre-1.0 is risky since semantic versions are undefined at that stage. It's entirely possible (though unlikely) httpx==0.28.0 includes a breaking change. It would be better to keep httpx (and any other runtime dependencies) up to date than to have such a broad version requirement

The risk can be avoided by the user to pin httpx to the version that they want and/or need for their application. This shouldn't be determined by one of their dependencies. What if another dependency had another opinion!
For anyone interested in this feature, we are maintaining a fork with the loosened httpx constraint.


Preliminary tniASM syntax support

Preliminary tniASM syntax support. It is not completely functional yet!
This pull request is a little/bit rough around the edges because Dialect cannot contain entire definition of a dialect (some parts of tniASM syntax support ended up in ExpresisonParser and PreProcessor/SourceMacro...)
At the moment, lib/msx/cartridge.asm cannot be parsed. But I have been unable to understand the exact cause of problem... so I guess I'll make the pull request now and investigate further later O:-)
ERROR: File lib/msx/cartridge.asm ended while inside a macro definition of "if" at #12:
        org     $4000, $4000 + (CFG_INIT_ROM_SIZE * $0400) - 1
ERROR: Problem expanding macros after loading all the source code!

Nice! Thanks a lot for the initial tniasm support theNestruo!!! I see a couple of things that might be the cause of the problem,  let me merge and check it out! I see the parseLine method of the tniasm dialect class does something different from what the code actually expects. So, will do a couple of fixes after I merge :)

Ok, I figured out what was happening. The bug was not on your side, but on the preProcessor. I just fixed it and it works. Sorry for the bug!!! cartridge.asm is properly parsed now :)

Btw, when defining a dialect, you only need to worry about the keywords that are not already parsed by MDL. No need for "org", "db", "dw", etc. as those will never be passed to the dialect. You only need to add support for the dialect specific keywords.
About spilling into the ExpressionPaser, (for XOR, AND, etc.). It's totally ok! If we have a similar issue with some other dialect, we can generalize and add a "synonym" hashMap like in the LineParser and PreProcessor classes that the Dialect classes can fill in. But for now, I think it's ok :)


Update CMake deps for iree::samples

With #184, #185, #186 and #187 merged, this enables the build toolchain to compile the examples. Together with the other PRs this nearly enables the compilation of the examples :)

Thanks for the review. Due to #190, this is unfortunately not enough to build the samples (enabled by setting IREE_BUILD_SAMPLES to ON). Waiting until #185 was merged is a good idea anyway, because iree-tblgen was involved in prior build steps.


Document proxy.config.http.cache.post_method.

This option allows people to cache responses to POST requests.
Signed-off-by: David Calavera<EMAIL_ADDRESS>

link https://github.com/apache/trafficserver/issues/2767

Cherry-picked to v9.0.x branch.


Add support for group chats, improve usability for large conversations

Group chat support:

Additional SQL file uses the new date format. I haven't updated the other SQL files to use the same because it will probably break functionality for older backups.

Usability:

The group chat I tested it on is huge, with ~ 20GB of photos and videos: when I tried to open it, it ran out of memory
It now splits up the messages into a new file (e.g.messages 10.html) every 1000 messages

Videos:

MP4s (and MOVs, although they can't actually be played on browsers at this point in time) now use the video tag instead of as an image

.PLUGINPAYLOAD files are still rendered as images though. I have no idea what they are

Bug fixes:

If attachments have the same name, the attachment name is changed (e.g. FullSizeRender.jpg becomes FullSizeRender (10).jpg) instead of being overwritten

Other:

Added a script which converts HEIC and MOV files into JPG and MP4
files that can be viewed on browsers, and updates the URLs in the
generated HTML files. Linux only unfortunately

Hey! Thank you for this! Sorry for my delay, hoping to look at this soon.


Add a wizard/autodetection for default config

My Linux machine was configured by default (in .nscale/config/config.json) as using boot2docker, so I had to change some settings using wording like analyser which I never ever heard about before ;).
 (If we do that, we should tell users not to rely on this if they use the client in scripts in production and always ship their own config).

This was fixed long ago :).


Bluetooth is not available

hello,
i build it using my raspberry pi 4, the wifi is available but the bluetooth is not even discovered. so im reflashing using your release instead of building. but got the same result instead

Bluetooth is only available when Android Auto is attempted from the head unit. Also, it is discoverable for around 3 minutes by default. You can have a look if your headunit is starting the Android Auto connection via usb or not. If not, we may have to find another approach on how to make it work.

yes, i look into autostart script. im testing on hyundai ioniq 5 and it's
not working although it's working on mercedes head unit.
for ioniq im gonna debug it further
thanks
Pada Min, 22 Okt 2023 20.32, Nisarg Jhaveri @.***>
menulis:

Bluetooth is only available when Android Auto is attempted from the head
unit. Also, it is discoverable for around 3 minutes by default. You can
have a look if your headunit is starting the Android Auto connection via
usb or not. If not, we may have to find another approach on how to make it
work.
—
Reply to this email directly, view it on GitHub
https://github.com/nisargjhaveri/AAWirelessDongle/issues/5#issuecomment-1774097014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDK7IG3Z6BT4CBBI7XJ65FTYAUN5VAVCNFSM6AAAAAA6IJG7UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGA4TOMBRGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

need further test


.Net: Enable the possibility to select another service using IPromptRenderFilter.

Describe the bug
The current PromptRenderFiltering happens after the service was selected in the Kernel, even changing the context.Arguments.ExecutionSettings.First().Value.ServiceId won't be effective.
Expected behavior
Since prompt rendering happens before calling the connector, seems to be an error not be able to override that configuration and select a new connector serviceId from the filter context settings.

In my opinion, we should clearly define the responsibility of each filter. IPromptRenderFilter is related to prompt rendering operation only, I'm not sure it should have an ability to pick AI service. If it's important to select another service in the middle of the execution, it's possible to use IFunctionInvocationFilter, we have an example how to do it:
https://github.com/microsoft/semantic-kernel/blob/a53b96a1ae066160872b3cad65387442995a788d/dotnet/samples/Concepts/Filtering/RetryWithFilters.cs#L49-L70
There is a clear use-case for IFunctionInvocationFilter, when function invocation fails and user wants to try the same function with different model. I'm wondering, what could possibly happen during prompt rendering operation that it will be necessary to change AI service inside IPromptRenderFilter. If there is some use-case, it would be great to discuss it further.


Pointer is not being grabbed

For some reason the pointer is not grabbed by wslock.

Apparently, my interpretation is not precise: I really mean hiding the cursor. From what I can see XGrabPointer() does so, while xcb_grab_pointer() doesn't.


How to get the visible data in the FlexTable?

I want to get a list of all records that are visible in the table. I want to do this onScroll.
The only documented public methods are measureAllRows and recomputeRowHeights. Is there another way?

Never mind. I just realised that there is an event onRowsRendered, which:

Callback invoked with information about the slice of rows that were just rendered: ({ overscanStartIndex: number, overscanStopIndex: number, startIndex: number, stopIndex: number }): void

This is not ideal though. It requires storing startIndex, stopIndex in the state, which triggers an update (, which can be prevented using custom shouldComponentUpdate logic).

Is there a functional way to get the current slice?, i.e. using a ref to the FlexTable and calling a method to retrieve the data.

Looking at the current source code (https://github.com/bvaughn/react-virtualized/blob/master/source/FlexTable/FlexTable.js) - no, there is not. It would be a useful addition.

This is not ideal though. It requires storing startIndex, stopIndex in the state, which triggers an update (, which can be prevented using custom shouldComponentUpdate logic).

Is there a functional way to get the current slice?, i.e. using a ref to the FlexTable and calling a method to retrieve the data.

Looking at the current source code (https://github.com/bvaughn/react-virtualized/blob/master/source/FlexTable/FlexTable.js) - no, there is not. It would be a useful addition.

Event approach does not work, because onScroll is called before onRowsRendered. Even if we use onRowsRendered to get save current {startIndex, stopIndex} in the state, this will not represent the current rows when onScroll fires.

Never mind. I just realised that there is an event onRowsRendered
This is not ideal though. It requires storing startIndex, stopIndex in the state, which triggers an update (, which can be prevented using custom shouldComponentUpdate logic).

The indices only need to be stored in state if you want them to trigger a re-render. If you don't- (it sounds like you don't)- then just store them as a "private" instance variables. eg
<Grid
  {...otherGridProps}
  onRowsRendered={({ startIndex, stopIndex }) => {
    // Store for later use without triggering a re-render
    this._startIndex = startIndex
    this._stopIndex = stopIndex

    // If the changed indices require you to update, then...
    this.setState({})
  }}
/>

The indices only need to be stored in state if you want them to trigger a re-render. If you don't- (it sounds like you don't)- then just store them as "private" instance variables. eg

As I said in the earlier comment, this is not useful because onScroll fires before onRowsRendered, i.e. onScroll has only access to stale data.

You said that about onScroll yes, but the snippet I post above is onRowsRendered.

Ah, sorry. I just re-read your description and I understand your previous comment now.

The problem with what you're asking is that- as of onScroll- the rows rendered in the table/grid/list are actually still the previous rows. It isn't until the next render (triggered by the scroll) that the indices are updated. So the information you want to fetch doesn't exist at that time; even if I added a method it would have "stale" information unless you waited for the next render. (I recommended onRowsRendered for this reason; it is called when the rows are first updated.)
Perhaps you could explain your use case a little more.

The problem with what you're asking is that- as of onScroll- the rows rendered in the table/grid/list are actually still the previous rows. It isn't until the next render (triggered by the scroll) that the indices are updated.

Sounds like a lacking implementation. A simple solution: You could delay onScroll event propagation to the client until after the onRowsRendered. This way onScroll event propagated to the user would be able to describe the current rendered rows.

(I recommended onRowsRendered for this reason; it is called when the rows are first updated.)
Perhaps you could explain your use case a little more.

We have many tables on the screen. We are using data from the top visible row in the table to adjust scroll of all related tables, e.g. Imagine one table that lists sales (columns: id, time, price) and another table that lists purchases (columns: id, time, price). When user scrolls sales table, we'd use "time" value of the top visible row in sales table to find the nearest time in the purchases table and adjust purchases table scroll to reflect that time window.
Note that rows in sales and purchases do not have 1 to 1 mapping, therefore it is not as simple as offsetting one table scroll by as much as the other table scroll offset is.

Sounds like a lacking implementation.

Sounds like a poor choice of words. A lot of thought and testing (and time) has gone into optimizing scroll performance of this library. The fact that it doesn't handle this particular use case doesn't suggest anything about the quality of the implementation.

I have thought a bit in the past about pre-calculating the visible row range (ahead of render time, in componentWillUpdate for example) and I think I even tried that in a branch at one point- although it's been a couple of months and I'm not sure I recall why it didn't stick. It would be a non-trivial change to make to Grid though and it would have implications for HOCs like CellMeasurer (which may be good or bad, unclear at the moment).
As for delaying the onScroll I think that would make things feel unresponsive. Scrolling already can feel a bit unresponsive due to the fact that the browser manages scrolling in a different thread and just periodically updates JS of the current position. (This is what sometimes leads to empty space at the bottom or top of a grid while you're scrolling.) The best solution I've been able to come up with for this- after a lot of thought and also discussion with others- is the overscan property.

I don't think I'm going to be able to support this feature, at least not in the near future. As such I'm going to close this issue. (It helps me with maintenance if I don't keep issues open that I don't plan to act on in the near future.)
I would be happy to consider a PR if you'd like to contribute towards adding this functionality. I don't think that deferring the onScroll callback is a route I should take because it adds latency to existing, simple users of that event. Exposing a public method to calculate the visible indices isn't a straight forward matter either as calling it before the updated render cycle would yield stale results (as state would contain stale data).
I could cache some properties on the instance (not in state but just as instance properties) but I have a gut feeling that might lead to tricky edge-cases since we'd be doing calculations on potentially stale data (props) mixed with fresh data (cached "state").
Anyway, as I said. Going to close this as unsupported / out-of-scope for the time being. We can talk more if you have ideas though.


A proper documentation needed for newcomers

as if contributors are creating a PR directly into main branch it will lead to conflict after every single merge, so a proper documentation required for it, i.e everyone should create a new branch so that it may not lead to any conflict

@abhay-raj19

that is mentioned up there in the contributing guide


[ROCKETMQ-52] Add unit tests for rocketmq-common  protocol HeartbeatData

What is the purpose of the change
Add unit tests for rocketmq-common  protocol HeartbeatData
Brief changelog
practice the PR procdure
Verifying this change
test pass
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.3%) to 45.069% when pulling fa2b931006ff5b663f59d78b78678bfc5396e899 on hugoasdf:master into 8f37ff27db02177a1e336c8d5ee1a089a4a23939 on apache:master.


.NET TV apps doesn't show in apps list / smart hub

I'm guessing there's something wrong with the manifests - none of the TV apps seem to appear in the apps list / smarthub, so there's no way to launch these apps on the TV without doing it remotely from Visual Studio.

Sorry for late answer.
Plz, refer to this page.
https://developer.tizen.org/forums/tizen-.net/smart-hub-tizen-4.0-tv-.net-app?langredirect=1


Prune excess documentation and commented code

For example, in car_system.ino, there are excess Serial.println(); statements lying around. These should be removed.

Working on this on the branch prune-excess.

Fixed in above merge.


Parsing string values containing whitespaces

Expected behavior
User should be able to pass string containing whitspaces.
Actual behavior
There is no way to pass a string containing whitespaces because it will be treated as separate values.
Steps to reproduce

Create a command class with string property and implement related CommandHandler
run command --property string with wihitespaces

@jmarlew suggested to use " sign to mark a string containing spaces.
ex. command --property "string with wihitespaces"

Fixed with #26. Closing the issue.


IIS support

I know that pathfinder states it is intended for nginx or apache however it runs fine on iis with the exception of the cron job which is due to a slight difference in syntax between cmd and bash,
I resolved this for myself by taking the windows detection from app/lib/base.php and adding it to app/lib/cron.php and a slightly different exec statement and I also added a basic web.config file, see https://github.com/exodus4d/pathfinder/compare/master...webba:windows
I'm unsure if the cron.php is something you have written yourself or is part of an external library but I will happily submit a pull request if this is applicable.

Hi @webba ,  Nice to her, you got PF working on ISS :) I never have tried that before.
The cron.php is a 3rd party plugin for F3 framework: https://github.com/xfra35/f3-cron which is not written by me.
I just checked the repo and figured out the version I use is 3years old and there were many changes made in the meantime, including a "Windows detection" see:
https://github.com/xfra35/f3-cron/blob/master/lib/cron.php#L122
You should be able to update the plugin to the latest version and let me know if this solve your issue. I´ll do some tests as well with Nginx and update to the latest version of cron.php .

Just updated ours on IIS to the version linked works fine and solves the issue.

:heavy_check_mark: Issue resolved
This issue was resolved by the commit(s) and/or the comments above.
It will be auto-closed with the upcoming release ( merge into master branch). Please check the attached Milestone information.
Many thanks to all participants/contributors for the helpful comments! :+1:
:information_source: Please reopen/comment this, if you have problems/questions about it.

Auto-generated response


[VL] Make it easier to replay GHA CI scripts from local environment with docker support: Phase 1

The patch targets to make user be able to replay GHA CI scripts from local host without extra effort to build the required docker images. (phase 1)
Phase 1:
Prepare necessary gluten-te utility scripts without changing CI script.
How should the newly added gha scripts be used:
# Create docker container and checkout code into it (to replace the use of GHA checkout plugin)
OS_IMAGE=centos:7 /opt/gluten/tools/gluten-te/centos/gha/gha-checkout/checkout.sh
# Or (if having cache registry set)
DOCKER_CACHE_REGISTRY=my.registry:5000 OS_IMAGE=centos:7 /opt/gluten/tools/gluten-te/centos/gha/gha-checkout/checkout.sh

# Execute some commands (build, test, etc)
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/exec.sh 'yum -y install epel-release centos-release-scl patch'

# Clean up the container before job exits
/opt/gluten/tools/gluten-te/centos/gha/gha-checkout/clean.sh

We should make actual changes to GHA CI script after phase 1 is merged.

@PHILO-HE @zhouyuan

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_3998_time.csv
log/native_master_12_11_2023_71ec720d4_time.csv
difference
percentage

q1
35.00
32.10
-2.908
91.69%

q2
25.04
24.79
-0.250
99.00%

q3
38.33
38.42
0.094
100.25%

q4
39.05
39.90
0.858
102.20%

q5
71.62
72.41
0.790
101.10%

q6
5.41
7.02
1.610
129.77%

q7
86.16
85.38
-0.784
99.09%

q8
86.31
86.65
0.336
100.39%

q9
128.11
126.76
-1.358
98.94%

q10
46.19
46.79
0.597
101.29%

q11
20.42
20.34
-0.074
99.64%

q12
25.94
26.95
1.010
103.89%

q13
46.75
45.56
-1.187
97.46%

q14
15.80
18.31
2.510
115.89%

q15
29.02
27.78
-1.247
95.70%

q16
15.67
15.83
0.160
101.02%

q17
102.27
101.57
-0.702
99.31%

q18
150.56
151.54
0.980
100.65%

q19
13.73
12.91
-0.825
94.00%

q20
27.15
26.84
-0.313
98.85%

q21
226.36
228.06
1.704
100.75%

q22
13.95
13.81
-0.138
99.01%

total
1248.85
1249.71
0.860
100.07%


Fizzbuzz_normal.py

Hey @iamashiq we are sorry to say this but, it's basic solution already exists, so we can't merge it,
But also there seems like you forgot the case where numbers are not fizz or buzz.
Please check our readme for more information of what we are searching for


Grid displays wrong column widths or cell gaps

I'm creating different views of my data.  Each view has a different number of columns and different column widths.
What is the current behavior?
When moving between views, the grid renders the correct data, however the column widths are often incorrect.  Sometimes gaps occur in the grid display.

See the example at https://codesandbox.io/s/mwm7x6opj
What is the expected behavior?
The grid cells display with the correct column widths and there are no gaps in the grid display.
Which versions of React and react-virtualized, and which browser / OS are affected by this issue? Did this work in previous versions of react-virtualized?

Browser
Chrome and Firefox

OS
Windows 10

React
latest version

React DOM
latest version

react-virtualized
latest version

I had to create a cellRangeRenderer
function myCellRangeRenderer(props) {
  props.styleCache = [];
  var children = ReactVirtualized.defaultCellRangeRenderer(props);
  return children;
}

The defaultCellRangeRender function creates it's own key separate from the key one specifies in cellRenderer.  It uses this key to cache cell styles.  In my use case, row and column alone are not unique.  I also need a "view" variable to uniquely identify rows.  Perhaps this variable could be used in the key that defaultCellRangeRender uses for caching.


Support building with Expo

I could not able to install the expo and facing app crash in the application after installing expo.

@Akarsh08 Any updates on this issue? Can you share a doc with steps to have this implemented?

import HmsManager from '@100mslive/react-native-hms';
const hmsInstance = HmsManager.build();

Error: Requiring module<EMAIL_ADDRESS>which threw an exception: Invariant Violation: Native module cannot be null.
at node_modules/react-native/Libraries/Core/ExceptionsManager.js:104:6 in reportException
at node_modules/react-native/Libraries/Core/ExceptionsManager.js:172:19 in handleException
at node_modules/react-native/Libraries/Core/setUpErrorHandling.js:24:6 in handleError
at node_modules/expo-error-recovery/build/ErrorRecovery.fx.js:12:21 in ErrorUtils.setGlobalHandler$argument_0


"unsupported parameter for module: become_user"

Getting two errors:
"unsupported parameter for module: become_user"
"unsupported parameter for module: become"
For the add CONSUL_RPC_ADDR to .bashrc task in install.yml. Removing them fixed the issue. Should I open a PR?

That sounds like you could be using an older version of Ansible. From memory that started being supported and recommended from around v1.9, what version are you using ?

ansible <IP_ADDRESS>```

There goes that idea, sorry.


Rebase Benji's changes on j-mcnally master

formerly changes were on top of version 1.2.0. now on top of version 1.3.2

Pushed to wrong repo. Sorry about that!


Winduntoo support.

Things to consider to make grpc binaries to run under Windows' Ubuntu layer:
-) epoll_create1 and epoll_wait work under that layer, but not epoll_pwait.
-) TCP_NODELAY can't be set.

I realize this is probably leaking memory.

Closing since this seems stale


R0 Container

A big revamp of the event container to more closely match the proposed CTA data flow.
The dl0 container was renamed to r0, as the adc_samples extracted from hessio files resembles the raw camera data that would exist as R0.
Then created an r1 container for the calibration of r0 adc_samples into pe_samples, this calibration is typically intended to be done inside the Camera Functional Unit, but for the MC has to be done as part of ctapipe. There are also instances where camera teams may want to use ctapipe as a base for their prototype software, so an r0 and r1 container also makes sense for that.
Then re-created a dl0 container, but this time containing data volume reduced pe_samples.
Alongside these new containers, the calib.camera module has been changed to better represent the different data levels:

r1.py handles the calibration from r0 adc_samples to r1 pe_samples.

dl0.py handles the application of data reduction techniques. It accepts a reductor (from reductor.py) as an argument to use for the data volume reduction method in an identical way the dl1 calibration accepts a charge extractor from charge_extraction.py. If no reductor is passed to it, no data-reduction is applied and r1.tel[].pe_samples == dl0.tel[].pe_samples. This layout provides a nice test-bench for different data reduction techniques.

dl1.py handles the calibration from dl0 pe_samples to a dl1 image, where the charge has been extracted using a charge extractor from charge_extractor.py, and you are left with a value per pixel.

With this new calibration Component format, scripts can be made to be flexible with many data-sources.

MC data read through hessio is put into the r0 container, and is the calibrated through the whole chain into dl1.

Camera data that is already in the dl0 format is read into the dl0 container. This dl0 is unchanged when applying the methods in r1.py and dl0.py, as the r0 and r1 containers are empty. Then the data is in a identical format as the MC data is at the dl0 stage, and can continue the rest of the script in an identical fashion (calibration into dl1, plotting, etc.)

A script that uses this format is examples/calibration_pipeline.py.
This PR first needs #283 to be reviewed and merged before merging.

Hi @watsonjj , from the travis build it looks like the calibration tests need to be updated for the new data structures.

@ParsonsRD Yes, there was an update to pyhessio, but the version used by ctapipe (and travis) still points to the old version. This needs updating to use the new one, then the tests should pass.

Ah OK, thanks!

Concerning the update of pyhessio.
API changes are not backward-compatible (get_num_samples does not exist anymore).
So we have to increment the major version: from 1.0.1 to 2.0.0
Versions in setup.py and meta.yaml must be updated to this number.
A new tag and a new release must be created on pyhessio github repo (https://github.com/cta-observatory/pyhessio/releases)
pyhessio version must also be updated in ctapipe .travis.yml file
One remarks about API changes that are not backward-compatible:
Once commited, developers must update their pyhessio installation, which is quite tedious, so, from my point of view, in the future,  will be better to avoid to change the API to often.

This is looking good! All the tests fail though. Does travis.yml need updating? Does it work on your local machine?

Yes I think it does need updating. All tests pass on my machine.

great. Can you check that the version of pyhessio you use locally is the same one downloaded and installed in travis.yml?  Probably just updating that will fix it, since the tests that fail are ones that use pyhessio.

I think a new release still needs to be made of pyhessio. V1.0.1 (the latest release and the one used in travis.yml) does not have my latest pull requests.

I merged one of your earlier PRs and now I cannot merge this due to conflicts, can you merge them in?

Hi, can I just give a bump to this request. Is there are there any serious issues holding this one back? I guess this is a rather major revision to the code structure and I'm a bit reluctant to change much while this is still open.

NO serious issues, other than it requires everyone to update all other branches.  Now that there is a stable release of ctapipe-0.3.4, it should be ok to make this change. We just have to warn the other large feature branches that they will need to make a lot of changes to ensure they still work.

Ah OK, I think both Alison and I are doing rather major refactoring of the code at the moment anyway, so is no big problem for us.

I made a number of small changes to fix bugs introduced by this PR, and I guess that means I need to open a new PR to both merge this in and include the changes.  I will merge this first and then pull them.  Please wait until the second PR is merged


Don't call layer_surface.set_size on configure

Calling set_exclusive_zone and set_size with the values provided by the compositor in a configure will actually freeze the bar in the new configuration it requested, as calling those with non-zero values opts-out of autoconfiguration by the compositor.
By removing these calls, waybar can now adapt to dynamic changes in the output dimensions, which can happen for example if the monitor's transform is changed (like for a tablet-like device auto-detecting its orientation).

Thanks!

Is removing set_exclusive_zone necessary?  Removing this line breaks #75.

There should not be any need to set it again every time the bar receive a configure, as it has been set once at the start and there is no reason this would change.
Unless maybe sway configures the bar to a different height than the one it requested?

No there isn't anything wrong with sway.  The problem is that the gtk window is not created until the exclusive zone is already set.  When it is finally created, it has it's own minimum height which is what can cause an overlap between regular windows and waybar.  I suppose we can just set the exclusive zone as soon as the gtk window is created.

Maybe we need to use wl_display_roundtrip to wait

When it is finally created, it has it's own minimum height which is what can cause an overlap between regular windows and waybar.

In that case, I'd argue that the real issue is that the gtk window may have a different height than the one specified in the configuration file... But yeah, setting the exclusive zone as soon as the gtk window knows its size should work.

What if we set the exclusive zone ONLY if the requested height exceeds the minimum height (still in layerSurfaceHandleConfigure)?

@ForTheReallys Fixed with 311c34ecbc61a3dd4f1f9b4954693bf134e17604


parent.translations.DEFAULT.name breaks export

Description: when using parent.translations.DEFAULT.name the export no longer works. The name of the main variant therefore can't be exported with the variants
Steps to reproduce:

duplicate default product
add parent.translations.DEFAULT.name
export

Expected result:

the export is generated and all variants are also displayed with the name of the main product

Actual result:

export doesn't work (processing)

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-31668.
[created from NEXT-31668, comment 485493]


Update README.md

it works on debian tho

do it in dev

Reopen one in dev as I said :P

Just re open and edit the PR... ? xD

That's not how it works

the person who created the PR can click Edit and change which branch it goes into


more cleanup before generating CFG (continued)

do not review yet

Jenkins: retest this please

@andreistefanescu please review

lgtm

This change seems to have increased the time to execute the Java Semantics test suite by a factor of 6. I suspect it's because of performance issues associated with Java 8 parallel streams use of ForkJoinPool.commonPool() but I don't really know for sure. In any case, @yilongli needs to investigate this and fix this issue otherswise we will have to revert this diff.


[WIP] Rewrite in TS

This PR will provide a complete rewrite of the library in TS as discussed in issue #4

we are working to migrate the library to full typescript. Here is our first implementation https://github.com/Satellite-im/P2PT/tree/typescript-migration


[stable/jenkins] Adding override for ingress paths

What this PR does / why we need it:
This PR is adding the possibility to override the default Ingress paths with a new block of paths defined as YAML data structure. This allows to configure the Ingress resource to work with the AWS ALB Ingress Controller to automatically redirect HTTP traffic to HTTPS on the load balancer (@lachie83, @viglesiasce, @maorfr, @torstenwalter, @mogaal, @wmcdona89).
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name

/assign @torstenwalter

/ok-to-test

@jtyr can you please rebase and bump the version to 1.21.0

@wmcdona89 Done.

/lgtm

@jtyr Thank you for the PR.


[CELEBORN-139][BUG] Fix read wrong yaml file format when loading config

What changes were proposed in this pull request?
Fix read wrong yaml file format when loading config
Why are the changes needed?
its file format should be yaml rather than yml when creating quota config file.
Does this PR introduce any user-facing change?
yes
How was this patch tested?

Pls change change doc of QUOTA_CONFIGURATION_PATH

Do we need to cherry pick it into 0.2.0? cc: @AngersZhuuuu @waitinfuture

I think so


[master] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

/cc we don't use Prow
/assign we don't use Prow

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   96.18%   96.18%
=======================================
  Files          16       16
  Lines         446      446
=======================================
  Hits          429      429
  Misses         15       15
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bd466...6864611. Read the comment docs.


[ISSUE #3157] Optimize admin  dto validate.

Fixes #3157

Make sure that:

[x] You have read the contribution guidelines.
[x] You submit test cases (unit or integration tests) that back your changes.
[x] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

pls check ci

@moremind Hi, check completed. the ci task is gone, whether forced push cause the workflow reset?

Codecov Report

Merging #3804 (242451c) into master (10d466c) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3804      +/-   ##
============================================
- Coverage     64.12%   63.96%   -0.17%
+ Complexity     6039     6005      -34
============================================
  Files           898      898
  Lines         24680    24680
  Branches       2238     2238
============================================
- Hits          15827    15787      -40
- Misses         7457     7492      +35
- Partials       1396     1401       +5

Impacted Files
Coverage Δ

...che/shenyu/admin/controller/AppAuthController.java
96.00% <ø> (ø)

.../org/apache/shenyu/admin/model/dto/AppAuthDTO.java
63.82% <ø> (-2.13%)
:arrow_down:

...rg/apache/shenyu/admin/model/dto/AuthApplyDTO.java
66.66% <ø> (-2.57%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
54.25% <0.00%> (-9.58%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...che/shenyu/admin/model/vo/DashboardUserEditVO.java
60.86% <0.00%> (-4.35%)
:arrow_down:

...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java
8.00% <0.00%> (-4.00%)
:arrow_down:

... and 28 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

maybe you can change more code about dto?

maybe I have finished. :-)


Update slide deck with Allie's new caption

Updated caption on slide 05

i swear the caption makes sense if u see the pic


Migration stalled in queued state

Since last night, when running the migrate-repo command, the request migration its stalled in the state queued.
Using gh-gei v0.23
Migrating GHEC > GHEC w/EMU repo migrations
gh gei migrate-repo --github-source-org "${GH_SOURCE_ORG}" --github-target-org "${GH_DESTINATION_ORG}" \
    --source-repo "${REPO}"  --target-repo "${REPO}" \
    --github-source-pat "${GH_SOURCE_PAT}" \
    --verbose --wait

I attach the log file with GEI_DEBUG_MODE=true
20220819104423.octoshift.verbose.log
I am an Org owner on both the source and target Orgs. Both PATs have all scopes selected.

Thanks @philthethrill99. I passed this info onto our team, but the best thing to do is create a github support ticket with this info. A support ticket is the best way to get the right people looking at it, and make sure somebody gets back to you ASAP.
PS - I'm also pleasantly surprised somebody has discovered and is using GEI_DEBUG_MODE so quickly!

The team got a fix out on Friday to resolve the stuck migration issue. The migrations processed and we're keeping an eye on the migration attempts occurring this week.

@roferg Could you please let me know the fix. We are getting the same issue when we started migration last night.
[1:19 AM] [INFO] Migration in progress (ID: DFlLTRmNzQtODdjOS01NmEyOWEwNWEwMTE). State: QUEUED. Waiting 10 seconds...

Issue still seems to be happening, my migrations have been queued for several hours...
Support ticket: https://support.github.com/ticket/enterprise/10297/2427427

@zikphil Sorry for the delays that you saw last week! The service was exceptionally busy, so we had a long queue of migrations that it took a while to burn down. This certainly isn't normal - our capacity has only been exhausted a couple of times this year - but we are working to increase our migrations capacity for the future.

@zikphil Sorry for the delays that you saw last week! The service was exceptionally busy, so we had a long queue of migrations that it took a while to burn down. This certainly isn't normal - our capacity has only been exhausted a couple of times this year - but we are working to increase our migrations capacity for the future.

Thank you :)


Added support for parsing form data client-side

While the web-request message defines properties corresponding to the form data parsed from a request body, and the current Glimpse Client can display such form data, the current Glimpse Agent does not currently perform such parsing.  This change updates the client to, if no form data exists but body content does exist and the content type is form data, parse the content itself.

This is related to this Glimpse Agent issue.

Looks good. Just one small comment.

Assuming the tests pass, this is good to go.


⚠ ClamAV has degraded performance

In d64be01, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: ClamAV performance has improved in 5672d9b.