Quick fix to ensure user is authenticated before checking time_delta

fixes #176

The RecentLoginRequiredMixin calls super() before it does the recent check. That super() does the is_authenticated() check already. I'm not sure why this change is required.

You are correct, this is not the right way to handle this.
The problem stems from the fact that the call to super() returns redirect for not logged in users, but in RecentLoginRequiredMixin that response is not checked to see if it is a redirect, therefore  an error occurs on the line if now() > (request.user.last_login + delta): as it is possible to get to this point with an anonymous user.
A better fix would be to return the response from the call to super() if it is a redirect response. Either way, there is a bug here that causes an unhandled error

OK, we'll look more into it soon. I want to do a point release with a couple of bug fixes in the next day or two anyway.

Another contributor submitted the resp.status_code check so I'm closing  this issue.


[QUESTION] Command for streaming file source

I am trying to stream from a local file source to aws Kinesis video stream. I believe I am using the wrong command, can someone share the appropriate command to stream from a local file source (.mp4).
gst-launch-1.0 filesrc location=/deepstream-5.0/samples/streams/sample_1080p_h264.mp4 ! videoconvert ! video/x-raw,width=1920,height=1080 ! x264enc bframes=0 key-int-max=45 bitrate=512 tune=zerolatency ! h264parse ! video/x-h264,stream-format=avc,alignment=au,profile=baseline ! kvssink stream-name="MyKVStream" storage-size=512 access-key= secret-key= aws-region="us-west-2

Hello @ishangupta3,
Could you try this pipeline?
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/master/docs/macos.md#running-the-gst-launch-10-command-to-upload-mp4-file-that-contains-both-audio-and-video-in-mac-os . This is for macos, but you could try it for the system you are running in.
One more thing, I have edited your question to remove the access key and secret key you added. Make sure you do not disclose those details in the future. Thanks!

Thank you for doing that. I will try that command, I am using Ubuntu 18.04.

@disa6302 I ran the command for the mp4, while it did say it was writing packets to AWS Kinesis Video Stream - sorry for the long error message. But it seems to send packets successfully then it just stops with an error:

Current transfer rate (bps): 31876704 (31129 Kbps)
2020-07-29 19:34:25 [547630256624] INFO - stopKinesisVideoStreamSync(): Synchronously stopping Kinesis Video Stream<PHONE_NUMBER>3ba5a8.
2020-07-29 19:34:25 [547621863920] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:25 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:25 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:25 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:25 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:25 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:26 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:26 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:26 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:26 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:26 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:27 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:28 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:29 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:30 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:30 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:30 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:30 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:30 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:31 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:32 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:33 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:34 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:35 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:36 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:37 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:38 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:39 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postWriteCallback(): Curl post body write function for stream with handle: MyKVStream and upload handle: 0 returned: {"EventType":"ERROR","FragmentTimecode":1596076463021,"FragmentNumber":"91343852333181447247962534054916022264923153650","ErrorCode":"MAX_FRAGMENT_DURATION_REACHED","ErrorId":4002}

2020-07-29 19:34:40 [547524432368] DEBUG - streamErrorHandler invoked
2020-07-29 19:34:40 [547524432368] ERROR - Reported stream error. Errored timecode: 0 Status: 0x5200005e
2020-07-29 19:34:40 [547524432368] WARN - continuousRetryStreamErrorReportHandler(): Reporting stream error. Errored timecode: 0 Status: 0x5200005e
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000100, Next state: 0x0000000000000200
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000200, Next state: 0x0000000000000001
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000001, Next state: 0x0000000000000002
2020-07-29 19:34:40 [547524432368] INFO - describeStreamResultEvent(): Describe stream result event.
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000002, Next state: 0x0000000000000020
2020-07-29 19:34:40 [547524432368] INFO - getStreamingEndpointResultEvent(): Get streaming endpoint result event.
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000020, Next state: 0x0000000000000010
2020-07-29 19:34:40 [547524432368] DEBUG - getStreamingTokenHandler invoked
2020-07-29 19:34:40 [547524432368] DEBUG - Refreshing credentials. Force refreshing: 1 Now time is:<PHONE_NUMBER>881602000 Expiration:<PHONE_NUMBER>3709551615
2020-07-29 19:34:40 [547524432368] INFO - getStreamingTokenResultEvent(): Get streaming token result event.
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000010, Next state: 0x0000000000000040
2020-07-29 19:34:40 [547524432368] DEBUG - streamReadyHandler invoked
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000040, Next state: 0x0000000000000080
2020-07-29 19:34:40 [547524432368] INFO - putStreamResultEvent(): Put stream result event. New upload handle 1
2020-07-29 19:34:40 [547524432368] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000080, Next state: 0x0000000000000100
2020-07-29 19:34:40 [547524432368] DEBUG - fragmentAckReceivedHandler invoked
2020-07-29 19:34:40 [547524432368] WARN - getStreamData(): Indicating an end-of-stream for a terminated stream upload handle 0
2020-07-29 19:34:40 [547524432368] INFO - postReadCallback(): Reported end-of-stream for stream MyKVStream. Upload handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - postReadCallback(): Wrote 0 bytes to Kinesis Video. Upload stream handle: 0
2020-07-29 19:34:40 [547524432368] DEBUG - putStreamCurlHandler(): Network thread for Kinesis Video stream: MyKVStream with upload handle: 0 exited. http status: 200
2020-07-29 19:34:40 [547524432368] INFO - writeHeaderCallback(): RequestId: e7b63c34-34bc-2163-b02a-083566748f0e
2020-07-29 19:34:41 [547516039664] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 1
2020-07-29 19:34:41 [547516039664] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 1
2020-07-29 19:34:41 [547516039664] DEBUG - postWriteCallback(): Curl post body write function for stream with handle: MyKVStream and upload handle: 1 returned: {"EventType":"ERROR","ErrorCode":"INVALID_MKV_DATA","ErrorId":4006}
2020-07-29 19:34:41 [547516039664] DEBUG - streamErrorHandler invoked
2020-07-29 19:34:41 [547516039664] ERROR - Reported stream error. Errored timecode: 0 Status: 0x52000062
2020-07-29 19:34:41 [547516039664] WARN - continuousRetryStreamErrorReportHandler(): Reporting stream error. Errored timecode: 0 Status: 0x52000062
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000100, Next state: 0x0000000000000200
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000200, Next state: 0x0000000000000001
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000001, Next state: 0x0000000000000002
2020-07-29 19:34:41 [547516039664] INFO - describeStreamResultEvent(): Describe stream result event.
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000002, Next state: 0x0000000000000020
2020-07-29 19:34:41 [547516039664] INFO - getStreamingEndpointResultEvent(): Get streaming endpoint result event.
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000020, Next state: 0x0000000000000010
2020-07-29 19:34:41 [547516039664] DEBUG - getStreamingTokenHandler invoked
2020-07-29 19:34:41 [547516039664] DEBUG - Refreshing credentials. Force refreshing: 1 Now time is:<PHONE_NUMBER>307465573 Expiration:<PHONE_NUMBER>3709551615
2020-07-29 19:34:41 [547516039664] INFO - getStreamingTokenResultEvent(): Get streaming token result event.
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000010, Next state: 0x0000000000000040
2020-07-29 19:34:41 [547516039664] DEBUG - streamReadyHandler invoked
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000040, Next state: 0x0000000000000080
2020-07-29 19:34:41 [547516039664] INFO - putStreamResultEvent(): Put stream result event. New upload handle 2
2020-07-29 19:34:41 [547516039664] DEBUG - stepStateMachine(): State Machine - Current state: 0x0000000000000080, Next state: 0x0000000000000100
2020-07-29 19:34:41 [547516039664] DEBUG - fragmentAckReceivedHandler invoked
2020-07-29 19:34:41 [547516039664] WARN - getStreamData(): Indicating an end-of-stream for a terminated stream upload handle 1
2020-07-29 19:34:41 [547516039664] INFO - postReadCallback(): Reported end-of-stream for stream MyKVStream. Upload handle: 1
2020-07-29 19:34:41 [547516039664] DEBUG - postReadCallback(): Wrote 0 bytes to Kinesis Video. Upload stream handle: 1
2020-07-29 19:34:41 [547516039664] DEBUG - putStreamCurlHandler(): Network thread for Kinesis Video stream: MyKVStream with upload handle: 1 exited. http status: 200
2020-07-29 19:34:41 [547516039664] INFO - writeHeaderCallback(): RequestId: d3f0731a-2cec-5d89-846c-471b7dff844d
2020-07-29 19:34:41 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 2
2020-07-29 19:34:41 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 2
2020-07-29 19:34:41 [547524432368] DEBUG - postReadCallback(): Wrote 65524 bytes to Kinesis Video. Upload stream handle: 2
2020-07-29 19:34:41 [547524432368] DEBUG - postWriteCallback(): Curl post body write function for stream with handle: MyKVStream and upload handle: 2 returned: {"EventType":"ERROR","ErrorCode":"INVALID_MKV_DATA","ErrorId":4006}

You are getting STATUS_ACK_ERR_FRAGMENT_DURATION_REACHED which indicates thats your pipeline is not producing I-frames which will drive the fragmentation. You might want to re-encode your file to have frequent fragments (less than 10 seconds long).

@MushMal thanks for the response, I will do that. Also, do you have any resources where I can better understand the different errors for this plugin?

The documentation covers most of them: https://docs.aws.amazon.com/kinesisvideostreams/latest/dg/producer-sdk-errors.html
However, the documentation could go stale due to fast paced development so if there is an error you don’t see there you can check the public include files in the native repository

yessir thank you @MushMal and @disa6302

I am going to resolve this issue but I encourage re-opening issues or cutting new ones to get help directly from us or from community members.


west: Update hal_stm32 module for stm32l0 series cube update

Update Cube version for STM32L0XX series
from version: V1.10.0
to version: V1.11.2
Requires zephyrproject-rtos/hal_stm32#9
Signed-off-by: Erwan Gouriou<EMAIL_ADDRESS>

Superseded by #16984


Style Color Should be Blue

The style color is blue, receiving error message "should be blue"
Challenge Use CSS Selectors to Style Elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

@jstoneCWS  hi, you have a syntax error. please refer to the help button. this is not a bug.
hint: your header is wrong. hope that gives you a kick start on troubleshooting.

@jstoneCWS Thank you for reporting this issue. As pointed out above, you have a syntax error. The h2 tag doesn't match over into the


PHP 8

Hello,
Thank you for your awesome work!
Do you have in your plans to add image with PHP 8?
Thanks

Hi @DmitrySidorenkoShim
Yes, sure.
I am not using this image actively, but I can of course create php 8 images.
Which deployer version is of interest to you?
Would you already like to use the 7-rc version, too, or only the latest stable 6?
Since I don't want to cause BC issues, I would suggest to use an image name like this:

7-rc-php-8
6-php-8

Unless you have a better idea?

Thanks for the quick reply.
I am using "deployer/deployer" v7.0.0.-rc.4 right now,
(and PHP 8.1.2 (cli) in my project)
and deployment from local terminal is working like a charm.
So, it would be cool to have '7-rc-php-8' also for GitLab CI/CD deploy pipeline.
I hope it wouldn't take too much time for you.

@DmitrySidorenkoShim deployer doesn't work with php 8.1.
Fatal error: Uncaught ErrorException: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in /root/.composer/vendor/deployer/deployer/bin/dep:96
Stack trace:
#0 [internal function]: {closure}(8192, 'dirname(): Pass...', '/root/.composer...', 96)
#1 /root/.composer/vendor/deployer/deployer/bin/dep(96): dirname(NULL)
#2 {main}
  thrown in /root/.composer/vendor/deployer/deployer/bin/dep on line 96

I will only add 8.0. is that okay?
I would then also mark it in the tag accordingly: 7-rc-php-8-0 (or similar)
What do you think?

Yes, lat's try this with 8.0
and I think it should also work.
In worst case I can downgrade my PHP version.
Thank you again for taking care of this.


Add About/Contact Pages

Does anyone have an idea what to put on the about page?

License, GitHub link, codefor link and label (technology-related information)?
Contact, on the other hand, might include content-related information (who set up this specific installation of the FInderApp)?

I added a first version of an about page to the app. I think an extra contact page is not necessary for now, but I'm happy if there's further input/changes to the the about page.


@conda-forge-admin, please add user @username

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @username in conda-forge/pygit2-feedstock#62.


CNX-755: Create Collections by Category

Description & motivation

Related to CNX-755.

Changes:

Grouping of teklaObject by type.
SendCollectionManager.cs added as done with Revit.

Screenshots:
Before

After

Validation of changes:

Tested on the Basic Steel Model
Since grouping is very high-level (not drilling down into property names etc.), chances of Exceptions minimal

Checklist:

[x] My pull request follows the guidelines in the Contributing guide?
[x] My pull request does not duplicate any other open Pull Requests for the same update/change?
[x] My commits are related to the pull request and do not amend unrelated code or documentation.
[x] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[x] I have updated or added relevant documentation.

Welcome to the DUI3 💯.
During testing I noticed that renderMaterial proxies are not attached to the objects properly and there are objects with no color.

That's due to TeklaMaterialUnpacker relies on the application IDs of objects to associate them with the objects. When the subcollections are created, the proxies cannot find the corresponding IDs.
A new logic is needed in TeklaMaterialUnpacker to check the collection path.

Welcome to the DUI3 💯.
During testing I noticed that renderMaterial proxies are not attached to the objects properly and there are objects with no color.

That's due to TeklaMaterialUnpacker relies on the application IDs of objects to associate them with the objects. When the subcollections are created, the proxies cannot find the corresponding IDs.
A new logic is needed in TeklaMaterialUnpacker to check the collection path.

@dogukankaratas This is expected. We are not attaching any render material info into any object. New collections shouldn't effect it. Seems like something else. I can help tomorrow to debug.


fix(devtools): Fix and reenable devtools-view mocha tests on CI

Apparently this package's mocha tests (the visual regression tests) have not been running in CI because CI runs a script called "test:mocha:multireport", rather than "test:mocha", and this package was missing the former.
Curtis has been doing some work to combine the two scripts to avoid this sort of problem, and discovered that these tests have not been running and are failing. For the time being, he has replaced the "test:mocha" script with "test:mocha:fail" to prevent them from being run in CI.
The work to be done here is to fix the mocha tests in this package, and rename the script from "test:mocha:fail" back to "test:mocha" - this should ensure that the tests are run again in CI (though we should confirm this explicitly in the resulting PR for this). We should also ensure the mocha tests are run as a part of the larger "test" script, which is intended to run all the package's tests.

@chentong7 If you haven't yet, I would recommend testing your changes out across a few different environments. E.g. in multiple codespaces, on your machine directly, etc. I want to make sure the image generation is consistent across those environments. It should be, since the tooling creates an isolated environment in which it runs everything, but @alexvy86 noticed behavioral differences running the tests in some environments.
And are the tests working okay in CI?

Apparently this package's mocha tests (the visual regression tests) have not been running in CI because CI runs a script called "test:mocha:multireport", rather than "test:mocha", and this package was missing the former.
Curtis has been doing some work to combine the two scripts to avoid this sort of problem, and discovered that these tests have not been running and are failing. For the time being, he has replaced the "test:mocha" script with "test:mocha:fail" to prevent them from being run in CI.
The work to be done here is to fix the mocha tests in this package, and rename the script from "test:mocha:fail" back to "test:mocha" - this should ensure that the tests are run again in CI (though we should confirm this explicitly in the resulting PR for this). We should also ensure the mocha tests are run as a part of the larger "test" script, which is intended to run all the package's tests.

Nit: I would recommend expressing the description in terms of the changes being made, rather than the description in the task.

I pulled down your branch and ran the tests on Windows. I'm seeing actual visual differences running on Windows relative to the checked-in baselines. Examples:

So it looks like there is more going on here than just GIT LFS issues. The previewjs infra we're using to run the tests is apparently not as sandboxed as I originally thought. We will likely need to dig into our usages of their APIs and see if we need to be specifying something special to ensure we're using OS-agnostic settings, etc. Otherwise these tests just won't work :(

I pulled down your branch and ran the tests on Windows. I'm seeing actual visual differences running on Windows relative to the checked-in baselines. Examples:
So it looks like there is more going on here than just GIT LFS issues. The previewjs infra we're using to run the tests is apparently not as sandboxed as I originally thought. We will likely need to dig into our usages of their APIs and see if we need to be specifying something special to ensure we're using OS-agnostic settings, etc. Otherwise these tests just won't work :(

Since it runs differently every time when switch to a new dev box, should we only test on pipeline sandbox and don't run it locally?

Since it runs differently every time when switch to a new dev box, should we only test on pipeline sandbox and don't run it locally?

Unfortunately, that would mean that devs wouldn't be able to submit changes to the baselines to reflect intended visual changes. In order for this tooling to be useful, we need to ensure consistent image generation regardless of the dev's OS (and any other environmental differences that might be impacting this).
I had thought that the chromeless environment we're using was intended to be OS-agnostic, but that doesn't appear to be the case.
In order to make everything work, I think we need a deeper investigation into how we can make the previewjs tooling actually OS-agnostic, or consider alternative tooling. I suspect the required work for that would be pretty substantial, and beyond the scope we had intended for this task. @rohandubal interested in your thoughts on how we should proceed.

Since it runs differently every time when switch to a new dev box, should we only test on pipeline sandbox and don't run it locally?

Unfortunately, that would mean that devs wouldn't be able to submit changes to the baselines to reflect intended visual changes. In order for this tooling to be useful, we need to ensure consistent image generation regardless of the dev's OS (and any other environmental differences that might be impacting this). .....

In the meantime it might make sense to just acknowledge and add to the README that you must use Linux or something.. (Like, how simple is it to run these tests on Linux? Can developers just spin up a codespace and be good to go here? Or would there be a need to install other dependencies line a chrome browser or something into a linux environment?). If this is only affecting developers using windows, I'd be curious to know what % are burdened by this

(sorry, I missed your response earlier) Yeah, this might be a reasonable short-term solution. Everyone in our org has access to code-spaces, so they would have a way to proceed if they need to update things. It isn't a great long-term, open-source solution, but that's probably okay for the time being. And I think we really need some visual regression testing to prevent accessibility issues.


gson document field exclusion strategy  logic added

hello friends.
when i want ignore fields of document.
the default Gson instance of AbstractJestClient Class has no function.
so i added the Gson document field exclusion strategy logic.
following the guide line.
https://sites.google.com/site/gson/gson-user-guide#TOC-User-Defined-Exclusion-Strategies
it would be default guideline in JestClient when serialization  the document for indexing
please look at my pull request.

Hello @happyprg,
Thank you for your proposal, your input is appreciated, though in the light of below reasons I think it would be wiser to exclude this commit from Jest:

As discussed earlier (#45) at some point we would like to move away from Gson, as such adding more Gson specific features now would be a step back.
Users are free to choose any of the exclusion methods they might want to use with the current code structure since the Gson instance can be set on JestHttpClient. It is unclear to me as to why we would want to include a default decision - and why choose the custom annotation method as that default considering just using the readily available @Expose would be simpler or less cumbersome.

kramer Hello ^^
I have understand your talk.
thank you for check my pull request .
Have a nice day .


use extended version of label-/routeParams in doc

changed routeParams, labelParams to routeParameters, labelParameters

Good catch, thank you for fixing this!

 :)


Embed issue

error thrown when sending an embed with hook.send(message);
System.Net.WebException: {embeds:["0"]}
thanks.

What fields are you trying to send ?

What fields are you trying to send ?

Just a default embed (title and description) but it doesn't matter how many fields I add I get the same error.

Can you submit your code to verify?


How to handle multiple roots?

Right now, this will throw the error multiple root elements must be wrapped in an enclosing tag if more than one root element are given.
For nanohtml it would be pretty great to support multiple root elements, probably using DocumentFragment.
However it seems to me like all hyperscript-style modules also don't support multiple roots. There is a proposal, but it was never implemented: https://github.com/hyperhype/hyperscript/issues/37
I suggest that maybe for now, we can allow an option on hyperx like createFragment. If it's spacified hyperx will call that function with the array of nodes instead of throwing an error.
The change would simply be:
      if (opts.createFragment) return opts.createFragment(tree[2])
      throw new Error(
        'multiple root elements must be wrapped in an enclosing tag'
      )

Then whoever uses hyperx (like nanohtml) could do something like for example:
function createFragment (nodes) {
  var fragment = document.createDocumentFragment()
  for (var i = 0; i < nodes.length; i++) {
    if (typeof nodes[i] === 'string') nodes[i] = document.createTextNode(nodes[i])
    fragment.appendChild(nodes[i])
  }
  return fragment
}

hyperx(createElement, {
  comments: true
  createFragment: createFragment
})

I just tried this and it seemed to work, but I want to get some feedback first :)

@finnp I think that's a pretty reasonable approach. Defaults to safety, but allows opting-in to new behavior for those of us that support it. Neat!


[question] windows installer

I am sorry to ask this here as it is not really a VSCode issue, but i think it can be useful to the whole Electron community.
My question is how did you manage to have such a small windows installer? 30Mo is really low.
And your executable is only 56Mo.
In my project my executable is already 80Mo and the installer (squirrel) is 62Mo.
And i already clean most of the node_modules files.
I have looked at the code and couldn't find the win installer build script so i thought i should ask.
Thanks

We use Inno Setup as a setup framework, which seem to be pretty awesome at compressing. 👍

@farfromrefug Because Squirrel.Windows uses old ZIP instead of lzma. In the electron-builder we will get rid of Squirrel.Windows soon.

@joaomoreno If possible, could you please explain why you decided to use Inno instead of NSIS?

Just caught our attention first and worked.

@joaomoreno you don't apply any transformation to the electron.exe (which becomes vscode.exe) to reduce its size?

None.


chore(ci): update node matrix

Removes 16.x, which is now unsupported.
Replaces 19.x with 20.x as the current release
This should unblock #126

👍


KPCN [Bako et al. 2017], SBMC [Gharbi et al. 2019] link is not working,how can i get it

Holy moly, I just changed the authority! Sorry for the inconvience.


Init create functions for dump and print node

@TomasVotruba I think this is ready for start, the package need to be registered to packagist, per composer name, to be:
rector/rector-debugging

I'm going to add it to packagist right now :+1:

There is it :slightly_smiling_face:
https://packagist.org/packages/rector/rector-debugging

Thank you 👍 , I created PRs to repos, including rector-src to require-dev rector/rector-debugging


Research: Adopt the new modifier "optional" in proto3

Motivation: Google dropped the feature in proto3 but added it back as an experimental option in >=v3.12, and using optional will make the code clearer than the one of value wrappers.
Concern:  I think https://github.com/protobufjs/protobuf.js hasn't supported "optional" and may never support it because it's almost deprecated.


Parsing Errors: Issues with Daily Note Template and {{date}} syntax

Summarized Feedback from<EMAIL_ADDRESS>
Users are experiencing parsing errors with the Daily Note Template in Fleeting Notes, which may be related to the app not recognizing the {{date}} syntax. This is leading to confusion and doubts about the expected behavior of the app.


legitify analyze --repo doesn't support gitlab projects within subgroups

TL;DR
Hey,
We have projects in gitlab like group1/subgroup1/project1. The parameter --repo doesn't support them:
Error: invalid repository format group1/subgroup1/project1 expected "owner/name".
Expected behavior
support them.
Observed behavior
No response
Version
1.0.1
On which operating system are you using legitify?
Linux
Relevant log output
No response
Additional information
No response

Good catch. We will fix it.

fixed

@noamd-legit: Thank you for fixing it. When will this be tagged? Because we use your binaries instead of compiling legitify on ourselves.

@mawl v1.0.2 was released today, containing this fix. Please let us know how it went.

@royb-legit: Thanks a lot! :)


Themes Across Teams

documentation for https://github.com/mattermost/mattermost-server/pull/9419

@jasonblais can you please review again? I removed image and type.  I did not see them when I reviewed the text in the display settings (copy & past to share theme colors field) nor in our documentation.


fix calculate children hierarchy

What type of this PR
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
fix calculate children hierarchy
Which issue(s) this PR fixes:
Fixes #
Specified Reivewers:
/assign @your-reviewer

/approve


Active Parameter in Signature Help gets incremented before typing comma

I was testing the integration of the language server with VS Code.
Take the example of math.max(). This takes 2 parameters
When cursor is inside the brackets, active parameter is shown as the first one.

Type a single digit, the second parameter becomes the active parameter.

Expected: The second parameter becomes the active one only after pressing comma

I'll take a look before EOW

@keegancsmith I have a PR #153 out to fix this. It would be great to fix this issue fixed before I ship the integration with VS Code next week


can not find compatible vulkan driver

follow the guide of Getting Started, when execute the “cd carla_apollo_bridge/scripts
./docker_run_carla.sh” command in terminater，the program stop and pop out “can not find compatible vulkan driver”

could you run Carla with this?
docker run -it --privileged --gpus all -e DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix:rw  carlasim/carla:0.9.13 ./CarlaUE4.sh

I love you charles

thanks，developer. these command works for me to solve the drivers problem. By the way when i run "./run_docker.sh", the terminator shows "access control disabled, clients can connect from any host
docker: Error response from daemon: Conflict. The container name "/carla_cyber_0.9.13" is already in use by container "b0bbb561c7b311a76f7e8d6d56e9d14b7ea4be3897b65ceb3c17a813336319e9". You have to remove (or rename) that container to be able to reuse that name"


Update README.md and added contributors.

enhanced README.md and added contributors.

seen your pr, do the changes first of all is python , tell about swoc, add some images of the project, secondly add small contributing guidelines 4 to 5 points, change our contributors in more attractive way. happy coding


Slow HDD read.

Hello guys, BLAKE3 Team! I found out that any b3sum_windows_x64_bin.exe reads a HDD slow. What exactly I did:
I calculated the sums of Windows 10 iso images, 5.3 Gb and 5.8 Gb files, WD RE 1 Tb was used, I measured with a simple stopwatch.The speed of this HDD is 140-80 Mbyte/s. And it's not about a disk cache, because I rebooted after every test.

And I hear the disk spinning.
b2sum-bin_20130305.zip, 7-zip h command with any algo ~ 5.3 Gb - 45-48 s,  5.8 Gb ~ 55 s -1 m;.
And I don't hear the disk spinning.
So my simple question is:  why b3sum is this slower?

@lulcat Yes, the disk cache reading is OK with Windows b3sum. IDK exactly the languages used but there might be Assembly as well. Most of the third party Windows SW, for example
https://github.com/OV2/RapidCRC-Unicode and Total Commander
use single-threaded reference C code because there’s no multi-threaded C code yet from the developers. As for a raw reading from HDD in RapidCRC Unicode and TC it shows just the same speed as any other algorithm. If you have 210 mb/s you’ll get it. For a buffered reading single-threaded C code gives 1500-1700 mb/s with all SIMDs but AVX-512F (I don’t have them). And, yes, I will be nice to have multithreaded C code, maybe OMP.

Hi again. Let me correct myself. I just checked now.. .the actual RUST binary as well, which does mmap AND MT...runs AT 60 MB/s in an example case I have....
I then evict the file from cache and run ANY Other hashsum, which will beat it... e.g. b2sum? (can be sha*sum, anysum, all will run at the max ingress speed of the file)! e.g.
time b2sum same_example => 210MB/s over 3 times faster!!
I meant the C code won't do any better because it isn't optimised like rust (no mmapping and no MT , i.e. OMP).
THIS Is the issue you notice and reported I think. and it is a 'edge case' of b3 which I haven't figure dout yet WHY happens.
b2sum as you see does NOT suffer from this..  and I DO have avx512, I can run it with that in C etc but this problem persists.
it is on slow spinners and big files which trigger it. fast IO will not spike this case.
Now, again, as I said.. I have solved this in my environment with something on top.. but requires heuristically determining if we have that 'edge case'. I'd prefer obviously it to be solved in the b3 code but I am not sure where to touch it. I don't wanna touch crypto anyway with my edits. :)

@lulcat  I'm glad you've find a solution, but I neither a developer nor a coder myself rather a end user in Windows, we just don't build SW very often :)

@lulcat Yes, --no-mmap solves the issue but as I see : "Disable memory mapping. ### Currently this also disables multithreading."
It's for Rust, because C isn't multithreaded anyway. But what's the point then of using Rust and Rayon if at the and of the day we have exactly what we have in C, and I should say in more understandable form.

Apologies for not commenting here sooner. See this older issue: https://github.com/BLAKE3-team/BLAKE3/issues/31
The problem isn't really specific to BLAKE3 itself, but to the "divide and conquer" multithreading strategy we currently use. When b3sum hashes a file, by default you get a worker thread for every core on your machine, and each of these threads starts working on a different part of the file. From the disk's perspective, this requires a lot of seeking, and for spinning disks / HDDs in particular, it's this seeking that's slow. See also the docs for Hasher::update_mmap_rayon.
The next tricky part is that this performance downside doesn't apply to SDDs or to files cached in RAM. In those cases seeking is cheap or free, and it's common to see a 5-10x performance boost from multithreading. So if we changed the default, the majority of our users would run an order of magnitude slower, and they'd probably never know why. That 5-10x number depends entirely on the number of cores in your CPU of course, but it's going up over time.
In a perfect works there would be some function like File::is_seeking_going_to_be_slow, and we could just ask the OS to tell us what to do. Unfortunately there's no such function.
The --no-mmap flag (or equivalently, taking input with < in the shell) is a fine workaround, but since mmapping provides a slight performance boost even in single-threaded mode, I think the best workaround is currently --num-threads=1.

I guess I can confirm this. I solve this heuristically; however, so far I only did that 'solution' in my old C code. I haven't bothered yet doing it in my MT code, which indeed ironically also suffers from this and in this edge case is even slower than rust. It is a shame rust is being used in the first place, rather sub optimal.
 I do suspect o'Connor is the rust fan of the team as it seems his projects are in rust. Such a shame too, I love bao, tao and lao but alas! all in rust, again, rather sub optimal but it is what it is.
I will release the code publically later but before release , I only am willing to share the binary. if you wanna check it does indeed run 2-3times faster than your rust oconnor: Shout and I will pass it on. This is not down to my code by the way, but down to your team's excellent code in assembly.  (So not the rust code).
[quote]
In a perfect works there would be some function like File::is_seeking_going_to_be_slow, and we could just ask the OS to tell us what to do. Unfortunately there's no such function.
[/quote]
Have a look at what vmtouch and the underlying functions.. I am not sure if they can help in rust, especially since as you say, in MT, the seek pattern(s) will come at a cost. however, with a bit of heuristicvs one can get these times down in edge cases by a lot.

@oconnor663 I understood and closing the issue.

@oconnor663 I understood and I'm closing the issue.


update SeoField to use FieldTypeBase

Fixes #49
In bolt 3.3-beta3 a new interface FieldTypeInterface was introduced, and as of bolt 3.3 as a whole the FieldInterface no longer work. This update changes SeoField to use FieldTypeBase instead.

@siada Thanks for the fix. Did you test this on a default 3.2.x install? If it works too, i can merge it in from my phone, and tag an 1.0.2 release. 😊

Will test it on 3.2.X this weekend and report back

Can confirm that this works on 3.2.14


Skipping already present destination file

I use extrafiles with the most simple configuration: to copy all non-media files to the destination directory, but I'm getting the error:
extrafiles: Skipping already present destination file:
At the same time this seems to be a false positive, because the extra files are being copied twice, like this:
-rw-r--r-- 1 radu users    81154 Sep 16 14:47 cover.1.jpg
-rw-r--r-- 1 radu users    81154 Sep 16 14:47 cover.jpg
-rw-r--r-- 1 radu users    34696 Sep 16 14:47 TFN_band.1.jpg
-rw-r--r-- 1 radu users    34696 Sep 16 14:47 TFN_band.jpg
-rw-r--r-- 1 radu users   107822 Sep 16 14:47 Tides From Nebula - Aura (2009) PL.1.jpg
-rw-r--r-- 1 radu users   107822 Sep 16 14:47 Tides From Nebula - Aura (2009) PL.jpg
-rw-r--r-- 1 radu users  1075993 Sep 16 14:47 tidesfromnebula-inside.1.jpg
-rw-r--r-- 1 radu users  1075993 Sep 16 14:47 tidesfromnebula-inside.jpg
-rw-r--r-- 1 radu users  1063163 Sep 16 14:47 tidesfromnebula-outside.1.jpg
-rw-r--r-- 1 radu users  1063163 Sep 16 14:47 tidesfromnebula-outside.jpg

Here is some info:
beets version 1.4.9
Python version 3.5.3
plugins: discogs, extrafiles, inline

$ pip3 show beets-extrafiles
Name: beets-extrafiles
Version: 0.0.6

Figured it out:
the issue is this line.
When you have the config:
extrafiles:
    patterns:
        all: '*.*'

patterns is in this case '.' and for pattern in patterns iterates over each character of *.* resulting in the plugin matching against three different patterns:

*
.
*

i.e.
for pattern in patterns:   # patterns == '*.*'
    ...                    # pattern == '*' (1st iteration)

The two wildcard patterns results in your doubled up files.
The quick workaround is to make the pattern a list instead of a string:
extrafiles:
    patterns:
        all:
            - '*.*'

which will then be correctly interpreted:
for pattern in patterns:   # patterns == [ '*.*' ]
    ...                    # pattern == '*.*'

I'll try to remember to make a PR to fix the bigger issue later

tl;dr: make each pattern a list instead of a string

I think the problem is in https://github.com/Holzhaus/beets-extrafiles/blob/363897757dee663cc9fb834fa5e9cc52380a4f30/beetsplug/extrafiles.py#L136-L147
I removed the skipped_files variable and replaced skipped_files.add(source) with continue

Nice, can you please open a PR?


chrootenv: strip the binary

Motivation for this change
Get rid of references to the full compiler package from the runtime closure.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Not sure how to test this directly as chrootenv is not publicly exposed AFAIK. Tested indirectly as part of steam.
/cc maintainer @yegortimoshenko

I'm confused by the rebuild amount - is Hydra now building unfree software?

Thanks for the catch! This really shouldn't override default phases. I've pushed a commit that uses Meson to build the project. Meaning, no custom phases are necessary at all. What do you think?
cc @abbradar, @jtojnar

LGTM, thanks!


Re-work metatable

Replace pop-up with fillable table with 'new entry' as last row.

Consider avoiding the <datalist> control due to incomplete browser support (Safari)

Bumping this up per our discussion in DC that this was doable in time for this publication round. Editing metadata using the current interface is time-consuming during the review process.

I've re-prioritized with @lgessler to work on something else important, which is having auto-validation of TEI export (i.e. the dashboard will show the result of converting each document to TEI and running TEI-XSD validation on it). That's one of the things we currently have no automated way of dealing with, but would be really useful for catching errors.
I agree the metatable improvement would be a nice feature though, so it would be nice for the future, but probably not in time for this month's release.

Thanks for the update. This is a hassle, so if we can prioritize for next round it would really help. Thanks.

Done in #109

@lgessler : One small enhancement before closing: can we allow edit, rather than just add/delete? The validation table editor has this enabled, so it would be nice if the editor.py metatable also allowed the edit operation.


Typing out name without tapping suggestion

If you type out a name @Mike but don't tap the @Mike suggestion, it is not registered as a suggestion

Thanks for your feedback @maxhudson!
Sorry, I didn't really catch the issue here?
Because actually it's expected behavior. It allows us for example add multi-word mentions ("@Mike Black"). If a user didn't tap the suggestion then he doesn't want to capture this mention.


Improve syntax highlighting in docs

@kentcdodds mentioned this trick on Twitter. I was going to write some docs for https://github.com/reactjs/react-router/pull/3669 but realized I wanted to do this first.
(this is how I procrastinate from doing actual work 😑)

Going to merge this for trivial-ness.

@kentcdodds Do you know if anybody has an issue open with npm to fix the rendering of "jsx" syntax on the npm website? It's actually not working there. I might have to change the README back to using "js".

This doesn't look ideal:

npm uses highlights, which uses language-javascript and doesn't support JSX. highlights doesn't use language-babel by default, which does have a JSX grammer, which npm would need to install and configure to get this supported.
Long story short, I would just switch back to js highlighting.

Awe dang. Sad story :-( I guess the moral of the story is: use jsx for everywhere you expect github to be the only renderer.

Yeah... I'll drop jsx in the README. It's still helpful for the docs proper... though maybe not if we ingest them into a GitBook or something.


API Keys

How do you insert the api_key into edirect?
If you are piping between commands (e.g. an epost and then an esummary) does the key need to be supplied to both commands?

does the key need to be supplied to both commands?

You can export the NCBI_API_KEY first to avoid providing the api key each time as follows:
export NCBI_API_KEY='abcdef012345'

Better yet, if you can, just add that line to your .bashrc file, go through a login cycle and the api key should be available to all EDirect commands all the time.


Update RTD domain name

Change all references of readthedocs.org to readthedocs.io.

yes, it's on my list, you have to wait til I have a chance to push my current branch

Just a reminder issue. No pressure. I am just going through the whole repo and opening issues about this.


GH7: Remove Verify.XUnit dependency

fixes #7

Yup, sounds completely reasonable to me 👍

@devlead Pushed a new version: 22.3.1

Excellent! Tested with Verify.NUnit and works like a charm 👍


Support local ratelimit

Description:
Support local ratelimt as described in envoy Local rate limit doc.
Global ratelimit and local ratelimit are used in different scenarios:

If you just want to keep the number of requests sent to a single service instance within a reasonable limit, you should use local rate limiting. That’s because local rate limiting is handled separately at each service instance’s Sidecar Proxy, local rate limiting is more precise and reasonable for controlling inbound requests to service instances in this scenario. Used along with an appropriate HPA policy trigger by rate limiting metrics, we can keep the server cluster healthy by horizontally scaling the server cluster when all the existing service instances reach their limiting quota.

If you want to enforce a global access control policy to a particular resource, then global rate limiting should be used. A typical scenario is to set how often a user can access an API according to the user’s service level agreement. Docker Hub, for example, has a rate limiting policy for how often a user can pull images from its registy. Paid users have a higher quota than free users.

+1 for this, the API could mimic/reuse existing data structures that exist from GlobalRateLimit
https://github.com/envoyproxy/gateway/blob/9d6d699e83b37f98f2eca554d68290234ae231c9/api/v1alpha1/ratelimitfilter_types.go#L53
The only issue I see is supporting the Distinct match case, which needs some upstream work
https://github.com/envoyproxy/envoy/issues/23351
cc @cpakulski @vikaschoudhary16


[9.x] Add empty directory assertion to Storage::fake()

I was trying to assert that a given directory was empty in some tests and was surprised to see that there was no bulit-in assertion to handle this.
This PR proposes adding an assertDirectoryEmpty($path) method to the Storage fake.
Obviously this is just a cleaner version of doing...
$this->assertEmpty(Storage::disk('temp')->allFiles('/foo'));

vs
Storage::disk('temp')->assertDirectoryEmpty('/foo');

What is the behavior if there are no files within the directory but there are other sub-directories?

What is the behavior if there are no files within the directory but there are other sub-directories?

The assertion will fail, correctly IMO as the directory is not empty if it contains other folders
Storage::fake('temp');

Storage::disk('temp')->put('/foo/bar.txt', 'string');

Storage::disk('temp')->assertDirectoryEmpty('/'); // fail


How do you change PIN styling without clearing it first?

I have a case where i need to change my PIN style text color, underline color when the PIN input is invalid. I can't seem to do this without calling pin.clearPin() which will reload the view and clear all the input. Is there another way to do this?
Thanks

There is a way in which you can do this, although it's a little ugly.
The didChangeCallback gives you the pin that has been entered so far, this can be stored on the presenting layer (ViewController). You can then set the error styling, call clearPin() and follow it up by pasting the partial (or complete) pin using the pastePin method.
The pasting will have to be delayed by a small offset in order for the view to have time to render itself before the pin is copied (hence ugly 😅).

pinView.textColor = .red
pinView.activeBorderLineColor = .red
pinView.borderLineColor = .red
pinView.becomeFirstResponderAtIndex = tempPinStore.count
clearPin()
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
    self.pinView.pastePin(pin: self.tempPinStore)
}

Thanks for sharing your use-case, will try and improve on the way this is handled.
Do let me know if this resolves your problem.

I actually tried a similar method earlier, but got an error because i didn't add a delay for the rendering. This will solve for now, thanks!

@kosakoytim
I have added a completionHandler for the clearPin method in the latest release.


Name conflict when translating sections

When mixfix operators have unordered sections filled in, Agda generates a binding of a variable named section, which may clash with user-provided identifiers of the same name.
As an example:
inc : List Nat -> List Nat
inc = map (_+ 1)
{-# COMPILE AGDA2HS inc #-}
  -- ~> inc = map (\ section -> section + 1)

incBy : Nat -> List Nat -> List Nat
incBy section = map (_+ section)
{-# COMPILE AGDA2HS incBy #-}
  -- ~> incBy section = map (\ section -> section₁ + section)

The problem is we're not picking the correct name for the binder. As you can see in the body we think the name of the binder is section₁, which is what you'd get in this example if printing the term from Agda. I believe this is broken for normal lambdas as well.
In this case we really should generate the section.


Error. How to solve?

CS0103: The name 'Host' does not exist in the current context.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0a4022c-7ef1-3c30-4f9d-cf521a57a44a
Version Independent ID: a0b5e15c-d747-8710-95fb-a55c09861a1e
Content: Work with SQL in an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/working-with-sql.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The tutorial works. I'm not sure what step you missed. You might try asking on StackOverflow,.


New package: PhysicsInformedML v0.1.0

Registering package: PhysicsInformedML
Repository: https://github.com/TensorDecompositions/PhysicsInformedML.jl
Created by: @montyvesselinov
Version: v0.1.0
Commit: 2861178ae20500baf0bf0c68d8b3374b8b14327d
Git reference: master

[noblock]
what is the problem now?!


BuildPlan: infer -lc++ based on run-time triple

Currently, when cross-compiling from Darwin to platforms that don't expect -lc++ by default (e.g. most Linux distributions), the build will fail because -lc++ is always passed. When should check the destination triple and not the host triple in the build plan code paths.
This leads to confusing build errors when cross-compiling more complex projects like Vapor.
rdar://107487090
Modifications:
Modified BuildPlan.swift to check the value of the triple property instead of hostTriple. Added a test that verifies this cross-compilation case.
Result:
Projects that contain C++ can now be cross-compiled from macOS to Linux.

@swift-ci smoke test

As long as we pass -enable-cxx-interop to the swift driver, it will correctly handle this

This is unrelated to -enable-cxx-interop support though. There are plenty of projects that don't use C++ interop, but fail to cross-compile because -lc++ is always passed when building on Darwin platforms. I'm happy to discuss the removal of this logic outside of the scope of this PR, but within it I'm only fixing the existing cross-compilation behavior without changing it.


ability to link against a system-provided zopfli

Currently we have a very similar patch in Fedora but adding this would allow Fedora to just use py-zopfli as-is.

LGTM, thanks!


updated screensaver plugin

conforms with #121

Coverage remained the same at 83.129% when pulling 7824064a24fcbcd4ab9ebbe3d8c64ce5dfe02926 on z3t0:develop into<PHONE_NUMBER>9bae903ee27c77acc1d628ed26e12a on vutran:develop.


[stress-tests] add README.md

This commit adds README.md for stress tests.

Codecov Report

Merging #125 (c5bcc6c) into master (8cd0f8f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   49.94%   49.90%   -0.05%
==========================================
  Files          38       38
  Lines        4603     4603
==========================================
- Hits         2299     2297       -2
- Misses       2122     2124       +2
  Partials      182      182

Impacted Files
Coverage Δ

web/web.go
47.61% <0.00%> (-3.18%)
:arrow_down:

@Vyrastas Any further comments?

@Vyrastas Any further comments?

Looks much better, thanks for updating!  LGTM


ts: Convert lazy_set module to typescript.

Testing plan: Node tests, lint, and checking correct typescript annotations.

Awesome, thanks for picking this up again!  @showell @andersk are probably the best folks to review.

LGTM

Merged, thanks @priyank-p!


[Bug]: "heating_circuit_1_target_supply_temperature" slider issue.

Issue: currently sensor shows after Installation "0 C" however when moving the slider to 10C and afterwards to the very left it says 7C. The sensor Shows 7C and cant be moved back to 0C.
This seems odd...
however i dont even unverstand yet why it  starts with 7, i guess it's what Modbus says  but i dont understand the idea behind it.

Home assistant version: [2023.4.4]
Home assistant Supervisor:  [2023.04.0]
Home Assistant Operating System:  [9.5]
Solarfocus custom component version: [ 2.2.2 ]
Solarfocus firmware version: [22.050]
Solarfocus biomass boiler: [Ecotop light]
Solarfocus boiler=buffer: [Hygiene Kombispecher HYKO]

Fixed with version 3.0.0
This is due to the specification of Solarfocus. Valid values are 0,7-80, where 0 indicates that the temperature is calculated by Solarfocus according to the heating curve.


Playback Recorded MIDI Data

Overview
Players shall be able to playback the MIDI data that they record and it should use the sounds that they specify from the server.
Questions
Should playback relay on server rendering of audio?

 Playback Recorded MIDI Data


Create the article describing the Console Application Paradigm

See /docs/console/step-by-step-guide.md for a reference to this article.
It should discuss the kinds of applications that are built as console applications.

Closed per #508


API: add optional end timestamp to Span#finish

If/when https://github.com/open-telemetry/rfcs/pull/8 is merged.

This can be closed.

Fixed in #53


Update to use Apache Thrift everywhere, instead of using thriftpy on Python 3.

As requested by @wesm on a PR to impyla: https://github.com/cloudera/impyla/pull/251, here is an update to use Apache thrift everywhere.
Fully tested downstream in pyhive unit tests.

Hi @wesm. Merging this in now... But can you organise a release? Or set up travis auto-releasing? Or add me as a maintainer on PyPI?

@wesm Ping!

I just made you an owner on PyPI. Sorry for the delay!

Thanks @wesm, and no worries :).


cast redis ports to int

What does this pull request do?
It appears possible in at least come versions of the python redis libraries (redis-py and aioredis) to end up with ports that are stored as strings, whereas apm-server is expecting an int, which results in parsing issues. This preemptively casts all redis ports to ints before building the destination info.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-21T11:12:18.778+0000

Duration: 3 min 56 sec

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details here
Description: approval-list/elastic/apm-agent-python.yml

Error signal

Took 0 min 0 sec . View more details here
Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/qeternity return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/qeternity : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/qeternity : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

/test linters : Run the Python linters only.

/test full : Run the full matrix of tests.

/test benchmark : Run the APM Agent Python benchmarks tests.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

/test

:globe_with_meridians: Coverage report

Name
Metrics % (covered/total)
Diff

Packages
100.0% (68/68)
:green_heart:

Files
100.0% (227/227)
:green_heart:

Classes
100.0% (227/227)
:green_heart:

Lines
89.62% (17251/19249)
:+1:

Conditionals
76.771% (3143/4094)
:+1:

/test linters


Project mvdan.cc/sh/

Scorecard uses the mvdan.cc/sh/ for parsing shell-script. This is maintained by a single individual and is looking for sponsorship.

Consider becoming a sponsor if you benefit from the work that went into this release! https://github.com/sponsors/mvdan

https://github.com/ossf/scorecard/pull/1098

Maybe good opportunity for https://sos.dev/, assuming scorecard is considered a critical piece of software

@inferno-chromium @meder FYI

@inferno-chromium @meder Any updates on this? We use this library extensively

Maybe good opportunity for https://sos.dev/, assuming scorecard is considered a critical piece of software

I don't know why this was closed. Probably mistake.


How does villager roller work

I dont understand it pls teach

watch tutorial video https://www.youtube.com/watch?v=x1J2eDnfvbo

Thanks! i didnt see that


good for feature extraction

Hello,
Thanks for sharing your code:)
based on your experience with this code does this code is also suitable for feature extraction>?

That was the intention - but in my experience it hasn't worked very well. Recent literature in NLP has shown that contextualized language models such as Elmo and Bert work much better.


Release v2.3.0 compile error on php7.0 7.1

New release v2.3.0 compile error on php7.0 7.1
classimpl.cpp:307:35 error :'zend_empty_string' was not  declared in this  scope

Is this issue resolved?

There is a maintained fork where a PR to fix this issue has been merged. You can find it here: https://github.com/fast-debug/PHP-CPP

We will not adding 7.0 support.


WIP organizing things into classes

Description:
WIP

Ok so this needs to be split into several PRs. There are too many changes at once to keep track of.

Also we need to separate the multi-process code in its own PR after the reorganization is finished.

I separated multi-process to #11. It needed few compromises but end result is the same.


Set write deadline in client/agent connections

https://github.com/rancher/rancher/issues/15310

LGTM


[RFC] Avoid dispatching calls to abstract methods

Motivation
Possible solution for https://github.com/sorbet/sorbet/issues/7524.
When a method is marked as abstract we shouldn't be able to dispatch calls to it, which is the runtime behavior.
Let's consider this example:
class A
  def foo(x); end
end

class B < A
  sig { abstract.params(x: Integer, y: Integer).void }
  def foo(x, y); end
end

class C < B
  sig { override.params(x: Integer, y: Integer).void }
  def foo(x, y)
    # Calling `super` in this method actually calls `A#foo` and not `B#foo`, because `B#foo` is marked as abstract
    super()      # so this call should error as we expect only one argument `x`
    super(42)    # while this call should be okay
  end
end

[sorbet.run]
At runtime, sorbet-runtime will actually remove the definition of B#foo so when we call super from C#foo, the call is actually dispatched to A#foo.
This behavior can be confusing when compared to the static type checker behavior that will try to check the arguments to foo using the abstract definition.
This is also true when calling initialize:
class A
  abstract!

  sig { abstract.params(x: Integer, y: Integer).void }
  def initialize(x, y); end
end

class B < A
end

B.new(42, 42) # counterintuitively, this should be an error as the actual `initialize` called is `Object#initialize`
B.new         # similarly this should be okay

[sorbet.run]
With the proposed patch, the call resolves to the correct method as we can see in the error:
test.rb:16 Wrong number of arguments for constructor. Expected: 0, got: 2 https://srb.help/7004
    16 | B.new(42, 42)
               ^^  ^^
    https://github.com/sorbet/sorbet/tree/master/rbi/core/basic_object.rbi#L228: initialize defined here
     228 |  def initialize(); end
            ^^^^^^^^^^^^^^^^

While this works, this could be very confusing for the end-user as there is no indication in the error as to why A#initialize was skipped during the resolution. Hence the [RFC] tag.
Test plan
No test yet, let's discuss it first.

Hey thanks, this was on @neilparikh’s radar and I think he might have been working on a fix. I am happy to look at this first thing when I get back from vacation next week.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_PTOPLJGnJwnjRH
→ https://go/builds/bui_PTOPGdLddilGHj
→ https://go/builds/bui_PTOPpQGrRNMOGM

Superseded by https://github.com/sorbet/sorbet/pull/7853. Thanks @neilparikh!


Adding 'ref' attribute to component in router-view breaks beforeRouteEnter next( vm => {} )

Version
4.0.0-beta.9
Reproduction link
https://jsfiddle.net/1e9mqocg/1/
Steps to reproduce
Add router-view with transition
<router-view v-slot="{ Component }">
  <transition v-on:enter="enterTransition">
    <component :is="Component" ref="myRouteComponent"/>
  </transition>
</router-view>

Add beforeRouteEnter guard to child view
beforeRouteEnter(to, from, next) {
    console.log('* beforeRouteEnter');
    next((vm) => { vm.setData(); } );
},

methods: {
    setData() {
        console.log('*** "Set data" from beforeRouteEnter here');
    }
}

What is expected?
setData() to be called when clicking "Home" (inspect console.log)
What is actually happening?
setData is never called

Just deleting the 'ref' attribute makes it work again, but the ref attribute is very useful.

I think this one is a bug on vue. I will try to create a repro in the following days. The problem is we use our own ref to retrieve the component instance but it gets overriden by the user's.
If you want to try to reproduce it in Vue. The relevant code is in RouterView
setup(props, { slots }) {
return () => {
      const component = h(
        ViewComponent,
        {
          ref: viewRef, // a ref()
        }
      )

  return slots.default({ Component: component })
  }
}

Opened https://github.com/vuejs/vue-next/issues/2078

Fixed in vue-next

Hey @posva when this got fixed did the ability to target a ref inside the router-view slot get removed?
The following example with vue 3.1 and router 4 shows no ref whatsoever on the $refs object 🤔
<router-view
    :key="$route.name"
    v-slot="{ Component }"
  >
    <component
      :is="Component"
    ref="routerView"
    />
  </router-view>

I don't know, the reproductions seem to work. A proper bug report would help


[tool_crash] FileSystemException: Creation failed, OS Error: The system cannot find the file specified., errno = 2

Command
flutter create --template app --overwrite .

Steps to Reproduce

...
...
...

Logs
FileSystemException: Creation failed, OS Error: The system cannot find the file specified.
, errno = 2
#0      _Directory.createSync (dart:io/directory_impl.dart:129:7)
#1      _File.createSync (dart:io/file_impl.dart:286:14)
#2      ForwardingFile.createSync (package:file/src/forwarding/forwarding_file.dart:26:16)
#3      ErrorHandlingFile.createSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:287:22)
#4      _runSync (package:flutter_tools/src/base/error_handling_io.dart:600:14)
#5      ErrorHandlingFile.createSync (package:flutter_tools/src/base/error_handling_io.dart:286:5)
#6      Template.render.<anonymous closure> (package:flutter_tools/src/template.dart:288:28)
#7      _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13)
#8      Template.render (package:flutter_tools/src/template.dart:248:24)
#9      CreateBase.renderMerged (package:flutter_tools/src/commands/create_base.dart:489:21)
<asynchronous suspension>
#10     CreateBase.generateApp (package:flutter_tools/src/commands/create_base.dart:512:23)
<asynchronous suspension>
#11     CreateCommand.runCommand (package:flutter_tools/src/commands/create.dart:351:31)
<asynchronous suspension>
#12     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1257:27)
<asynchronous suspension>
#13     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#14     CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#15     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:283:9)
<asynchronous suspension>
#16     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.7.1, on Microsoft Windows [Version 10.0.22621.1105], locale ar-JO)
    • Flutter version 3.7.1 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7048ed95a5 (6 days ago), 2023-02-01 09:07:31 -0800
    • Engine revision 800594f1f4
    • Dart version 2.19.1
    • DevTools version 2.20.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at C:\Users\Abed-Sammer\AppData\Local\Android\sdk
    • Platform android-33, build-tools 32.0.0
    • Java binary at: F:\AS\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✗] Visual Studio - develop for Windows
    ✗ Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[✓] Android Studio (version 2021.3)
    • Android Studio at F:\AS
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.1105]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 109.0.5414.75
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 109.0.1518.78

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Flutter Application Metadata
No pubspec in working directory.

Closing this as a duplicate of https://github.com/flutter/flutter/issues/65242


Bump to test 0.12.20.

Some test 0.12.20 highlights:

introduces expectLater()  that returns a Future that completes when the matcher has finished running
deprecates the verbose parameter to expect() and the formatFailure() (to be removed in 0.13.0)

(For more, see the changelog.)
Otherwise:

to keep up w/ the deprecation of verbose, removes widget_tester API to pass verbose flag (alternatively we could suppress the warning for now)

@Hixie, @abarth, @tvolkert : could someone advise on my changes to  widget_tester?  Happy to opt for a suppressed warning but I'm leary of more debt! 😉

Ok, hmmm, we may not be out of the woods with this version of test (or I got something wrong).  Will take a closer look later but in the meantime, thoughts welcome!

Thanks!


fix: margin-right

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Privileges 2.1] Renew Privileges via Dock Tile

Hi Marc, the following doesn't work like expected during my tests (in german localization).

Privileges 2.1.0 (1901)
macOS 15.2 (24C101)

Dock Tile: Right-click the Dock tile while you have administrator privileges. When the menu appears, hold down the Option key and the menu item "Revoke Privileges" will change to "Renew Privileges". To renew privileges, click the menu item while still holding the Option key.

It remains "Administratorrechte abgeben", after a secondary click on the dock tile while holding the option key afterwards.

Works here as expected. This option must either be enabled by a profile or you must disable and re-enable it to make the Dock tile aware of it. Because of a bug in macOS 15 I had to build a workaround that only works if the option is managed or has been enabled by the user using the new beta build or higher.

@mthielemann Got it, worked like a charm after I unticked the option in the settings as a user and re-enabled it.


Double quotes for html attributes.

NOTE - it's ok to merge.  @jerjou Could you look at why Entities is failing travis.
@tswast Any suggestions you could give Jerjou would be helpful.

#380 should address the entities failure.

Apparently the natural-language API changed it's mind.
"John was seriously injured in an accident" now has positive polarity. We probably need to update the text. I'm not sure it's worth filing a bug, since I think sentiment is supposed to use multiple sentences to be accurate.
https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/language/analysis/src/test/java/com/google/cloud/language/samples/AnalyzeIT.java#L79


Add support to new URL scheme for Youtube channels without the "@"

After adopt the "@" to designate channels URLs, seems Youtube is allowing an additional scheme.
The new scheme is similar to the one with @ but without the @.
Here is an example:
Former channel URL scheme:      https://www.youtube.com/c/joerogan
URL scheme with @:                   https://www.youtube.com/@joerogan
New scheme:                               https://www.youtube.com/joerogan

I'll upload a branch with a possible fix, if you can test it, I'd appreciate it.

in my tests:
>>> from pytubefix import Channel
>>>
>>>
>>> urls = {
...     "url1": "https://www.youtube.com/joerogan",
...     "url2": "https://www.youtube.com/c/joerogan",
...     "url3": "https://www.youtube.com/@joerogan"
... }
>>>
>>>
>>> for key, url in urls.items():
...     c = Channel(url)
...     print(f'Channel name: {c.channel_name}')
...
Channel name: PowerfulJRE
Channel name: PowerfulJRE
Channel name: PowerfulJRE
>>>

is now available in the "channel" branch

Seems it is working properly.
I installed the branch at pycharm with the command:
pip install https://github.com/JuanBindez/pytubefix/archive/channel.zip
Pytubefix was updated to version 7.4.0.
Tested code:
from pytubefix import Channel

url = 'https://www.youtube.com/joerogan'
c = Channel(url)
print(c.channel_name)

Outcome:
PowerfulJRE

Process finished with exit code 0

I tested a few other Youtube channels as well, and all worked well.

It seems so, I'll do more tests later to see if everything is correct.

Although YouTube supports channel urls without the '@', some names can generate bugs
Example:
from pytubefix.contrib.channel import Channel

c = Channel('https://www.youtube.com/null')

print(c.channel_name)
print(c.videos)

null
[]

from pytubefix.contrib.channel import Channel

c = Channel('https://www.youtube.com/@null')

print(c.channel_name)
print(c.videos)

null
[<pytubefix.__main__.YouTube object: videoId=kqeOjDEchlo>, <pytubefix.__main__.YouTube object: videoId=M6ZjMWLqJvM>, <pytubefix.__main__.YouTube object: videoId=9SjHLau-DWE>, <pytubefix.__main__.YouTube object: videoId=KvkNPCCLyVk>, <pytubefix.__main__.YouTube object: videoId=BbHsxrYzdIg>]

Others, for example, cause:
from pytubefix.contrib.channel import Channel

c = Channel('https://www.youtube.com/None')

print(c.channel_name)
print(c.videos)

urllib.error.HTTPError: HTTP Error 404: Not Found

from pytubefix.contrib.channel import Channel

c = Channel('https://www.youtube.com/@None')

print(c.channel_name)
print(c.videos)

None
[<pytubefix.__main__.YouTube object: videoId=o1RZIxzEFPI>, <pytubefix.__main__.YouTube object: videoId=VU_0OQ51kuc>, <pytubefix.__main__.YouTube object: videoId=JG9cyL5FW90>, <pytubefix.__main__.YouTube object: videoId=jikRvNK0LKc>, <pytubefix.__main__.YouTube object: videoId=qc1ArRy3j8I>, <pytubefix.__main__.YouTube object: videoId=P0nfuhazyt0>, <pytubefix.__main__.YouTube object: videoId=_jBeDtT080s>, <pytubefix.__main__.YouTube object: videoId=RfYU_PX9DBs>, <pytubefix.__main__.YouTube object: videoId=7zRUmcFN-Xc>, <pytubefix.__main__.YouTube object: videoId=7-mgU3wzEsg>, <pytubefix.__main__.YouTube object: videoId=8HfzI6Dhpgw>, <pytubefix.__main__.YouTube object: videoId=qOmZY6YzEXM>, <pytubefix.__main__.YouTube object: videoId=gypDP4n1Ddo>, <pytubefix.__main__.YouTube object: videoId=dljOGm0x6Uo>, <pytubefix.__main__.YouTube object: videoId=I6h81Uy4mK4>, <pytubefix.__main__.YouTube object: videoId=ibwu3osov6I>, <pytubefix.__main__.YouTube object: videoId=xm9CD3wEm6w>, <pytubefix.__main__.YouTube object: videoId=ccQ2CANWAyw>, <pytubefix.__main__.YouTube object: videoId=SpHWz_cqvfk>, <pytubefix.__main__.YouTube object: videoId=wRLd3HU7aFg>, <pytubefix.__main__.YouTube object: videoId=_TA_lBYsZog>, <pytubefix.__main__.YouTube object: videoId=mhkGkkdGybU>, <pytubefix.__main__.YouTube object: videoId=8ZFTwgP94o0>, <pytubefix.__main__.YouTube object: videoId=v1fZ2mYn1E4>, <pytubefix.__main__.YouTube object: videoId=uKvQUuM4eCo>, <pytubefix.__main__.YouTube object: videoId=hmhvv73MTfU>, <pytubefix.__main__.YouTube object: videoId=27oBFGhFfUs>, <pytubefix.__main__.YouTube object: videoId=ID15D1Wz2bA>, <pytubefix.__main__.YouTube object: videoId=gaek_48LhtY>, <pytubefix.__main__.YouTube object: videoId=xNjeWaTGrl4>, <pytubefix.__main__.YouTube object: videoId=t1iGRIMljIY>, <pytubefix.__main__.YouTube object: videoId=3TbngrUGE6I>, <pytubefix.__main__.YouTube object: videoId=qTWkTSZHXik>, <pytubefix.__main__.YouTube object: videoId=cZAdWzpExgk>, <pytubefix.__main__.YouTube object: videoId=BTiH7yK2n3Y>, <pytubefix.__main__.YouTube object: videoId=rQwZ2RZrSb8>, <pytubefix.__main__.YouTube object: videoId=tw7k_CzBAmU>, <pytubefix.__main__.YouTube object: videoId=fgTGjXl4duo>]

These are just basic examples, some urls can even redirect to other channels with the same name. So although YouTube supports urls without '@', I believe that now would not be the right time to implement.

I took tests yesterday and thought the same


🧑💻 : Styling scrollbar wrt the webpage

:red_circle: Title : Styling scrollbar wrt the webpage
:red_circle: Enhancement Aim : Giving a new style to the current scrollbar so that it's styling matches with the overall webpage.
:red_circle: Changes :

changing the color of the scrollbar
giving it a rounded edge
adding hover effects to the scrollbar

Screenshots 📷

Current scrollbar -
https://github.com/user-attachments/assets/ace53256-92b6-45ed-8d38-18acae90bcf1
After changes (not with full styling rn, also not appropriate coloring) -
https://github.com/user-attachments/assets/f51e099b-e437-4e94-984f-a2eb34db61b0

✅ Details to Include When Taking the Issue:
Name : Richa Kalpande
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.):

GSSOC-EXT (label: gssoc-ext)
Hacktoberfest (label: hacktoberfest-accepted)

(Kindly add the level label also)

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

Hello there!
May you kindly assign the issue to me please?
Name: Andrea Mariotti
Participant Role: Hacktoberfest
hacktoberfest-accepted
Thankss!

please assign this to me under gssoc


documentation : packager server setting

afte apk installed on android phone, it cannot connect to packager server. there is a red screen. cannot connect localhost:8081.
you should shake the phone to enter dev settings menu and entering ip address of your pc (packager server and port ) info.

@smustaoglu can you make sure your did npm run android/ios and the packager is running?

Hi @smustaoglu ,
Try the following commands :

sudo lsof -i tcp:8081
kill -9  (this is the pid/s that you get from lsof)
adb reverse tcp:8081 tcp:8081
REACT_NATIVE_PACKAGER_HOSTNAME=localhost yarn start

Please do let us know if you are still facing issues.
Thanks.


feat: Make icon selector keyboard accessible

Description

Virtualized icon rendering result in less DOM nodes and improved performance / smooth loading of icons
Made Icon selector keyboard accessible

Tab to focus
ArrowDown|ArrowUp|Space|Enter to open
Esc to close
ArrowDown to Change focus from search bar to icons
Shift+ArrowUp to Change focus from Icons to search bar
ArrowUp|ArrowDown|ArrowLeft|ArrowRight to navigate through icons
Space|Enter to select an icon

Fixes #10060
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manual and Jest tests
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feat/icon-select-control

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.57 (0.11)
37.16 (0.13)
35.56 (0.17)
55.95 (0.11)

:green_circle:
app/client/src/components/propertyControls/BaseControl.tsx
83.33 (16.66)
25 (25)
66.67 (33.34)
81.82 (18.18)

:green_circle:
app/client/src/components/propertyControls/IconSelectControl.tsx
93.01 (50.15)
74.26 (52.04)
100 (80)
93.75 (47.32)

:red_circle:
app/client/src/utils/WorkerUtil.ts
88.98 (-0.78)
70.59 (-1.96)
100 (0)
92.38 (-0.95)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

/ok-to-test sha=a1a6f65

@aswathkk Icon pop-up do not close if we select the icon with space button. One if user has used the space button to select then enter button also start behaving same.
https://www.loom.com/share/e0ec9b1e10bc4144a5f18a4f1431c9e7

@aswathkk I am not able to focus on cancel icon on search icon field using keyboard

@vivekverma2312
As a decent keyboard user myself, here’s my take on this one:

I prefer Cmd + A to select all text and press Delete to clear the selection.
The challenges on making clear-all button also keyboard accessible:

We need to decide on a keyboard shortcut
It might complicate the UX
We need a way to communicate this to the user

@ramsaptami @somangshu @vuiets
I would like to know your thoughts here

I prefer Cmd + A to select all text and press Delete to clear the selection.

@aswathkk @vivekverma2312 I agree to ☝ , Intuitively thats the first thought to achieve the use case

/ok-to-test sha=64427ee

/ok-to-test sha=d210d9d

/ok-to-test sha=94cd303

/ok-to-test sha=94cd303

/ok-to-test sha=59ead1d

@aswathkk It is working fine the only thing observed is that cross icon on search is not able to focus using keyboard.

Thanks, @vivekverma2312
We will be raising a separate PR if we decide to have a focus state for cross icon.


Generate SObject Interfaces so we can construct with props

something like this
interface AccountProps{
     name?: string;
     accountNumber?: string;
}

export class Account extends RestObject implements AccountProps{
    constructor(props?:AccountProps){
        if(props){
           Object.assign(this, props);
        }
    }
}

let acc = new Account({
    name: 'abc',
    accountNumber: '12345'
});

@DServy any thoughts on this design?

@ChuckJonas Yep, Looks good to me.

@ChuckJonas nice to have this to also pass this as a type for new objs