Issues while configuring virtual bridge

Hello. I'm trying to configure virtual bridge. By default my distro uses Network Manager. The /etc/netplan directory is empty.
Firstly I tried to run commands via ip. After running sudo ip addr add <IP_ADDRESS>/24 dev kubr0 I got my Internet connection lost though kubr0 has appeared in ip a.
After PC reboot I tried to configure netplan configs. As I didn't have any default configs I put some for NetworkManager and bridges. I got the same problem with Internet connection. kubr0 interface was created but I couldn't do any HTTP requests and it seems they all go in timeout.
I tried to do another bunch of different configurations using nmcli. As I understood the problem was that I was always try to add my physical eth0 device to the bridge but I don't understand how to do it properly.
In the end of the day I went with this config. I replaced <IP_ADDRESS>/24 with <IP_ADDRESS>/24.
network:
  version: 2
  renderer: NetworkManager
  ethernets:
    enp6s0:
      dhcp4: true
  bridges:
    kubr0:
      addresses: [<IP_ADDRESS>/24]

I got my Internet connection working but after all manipulations with NAT and DHCP the VM has no access to Internet. There are some outputs from ip route and ip a in the VM
default via <IP_ADDRESS> dev enp0s2 proto dhcp src <IP_ADDRESS> metric 100
<IP_ADDRESS>/24 dev enp0s2 proto kernel scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS> dev enp0s2 proto dhcp scope link src <IP_ADDRESS> metric 100

2: enp0s2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP group default qlen 1000
    link/ether 52:52:52:00:00:00 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 metric 100 brd <IP_ADDRESS> scope global dynamic enp0s2
       valid_lft 42040sec preferred_lft 42040sec
    inet6 fe80::5052:52ff:fe00:0/64 scope link
       valid_lft forever preferred_lft forever

Would be very grateful to see your comment on this

The <IP_ADDRESS>/24 or <IP_ADDRESS>/16 prefix is most likely already used by your LAN and <IP_ADDRESS> is probably the IP of your router that gives you internet access. Try using something else for VMs, e.g. <IP_ADDRESS>/24

Thanks for response. I will try to use <IP_ADDRESS> for ip addresses and <IP_ADDRESS>/24  for configuring iptables

I couldn't resolve the problem after changing it to <IP_ADDRESS>/24
ip a on vm gives me this output
default via <IP_ADDRESS> dev enp0s2 proto dhcp src <IP_ADDRESS> metric 100
<IP_ADDRESS>/24 dev enp0s2 proto kernel scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS> dev enp0s2 proto dhcp scope link src <IP_ADDRESS> metric 100

ip route
default via <IP_ADDRESS> dev enp0s2 proto dhcp src <IP_ADDRESS> metric 100
<IP_ADDRESS>/24 dev enp0s2 proto kernel scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS> dev enp0s2 proto dhcp scope link src <IP_ADDRESS> metric 100

resolvectl status
Global
       Protocols: -LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported
resolv.conf mode: stub

Link 2 (enp0s2)
    Current Scopes: DNS
         Protocols: +DefaultRoute +LLMNR -mDNS -DNSOverTLS DNSSEC=no/unsupported
Current DNS Server: <IP_ADDRESS>
       DNS Servers: <IP_ADDRESS>
        DNS Domain: kubenet

ip a on vm gives me this output
Seems like you pasted the same output twice.

In general, it's hard to debug this without having full info about your environment. Make sure you have done everything from scratch. When trying to fix an issue retroactively, it's easy to forget about some steps. You can also try modifying and using the scripts provided by this repository - this way you'll reduce the chance of missing something.

Fixed ip a output.
I've rechecked all of these configs starting from virtual bridge guide.
etc/dnsmasq.conf
interface=kubr0
bind-interfaces

dhcp-range=<IP_ADDRESS>,<IP_ADDRESS>,12h
dhcp-host=52:52:52:00:00:00,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:01,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:02,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:03,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:04,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:05,<IP_ADDRESS>
dhcp-host=52:52:52:00:00:06,<IP_ADDRESS>
dhcp-authoritative

domain=kubenet
expand-hosts

etc/hosts
<IP_ADDRESS>   vmhost
<IP_ADDRESS>  gateway
<IP_ADDRESS>  control0
<IP_ADDRESS>  control1
<IP_ADDRESS>  control2
<IP_ADDRESS>  worker0
<IP_ADDRESS>  worker1
<IP_ADDRESS>  worker2
<IP_ADDRESS>  kubernetes

dnsmasq status after running the VM
● dnsmasq.service - DNSmasq DNS and DHCP server
     Loaded: loaded (/etc/systemd/system/dnsmasq.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2024-05-27 21:37:18 +05; 33min ago
    Process: 29123 ExecStart=/etc/init.d/dnsmasq start (code=exited, status=0/SUCCESS)
   Main PID: 29134 (dnsmasq)
      Tasks: 1 (limit: 38239)
     Memory: 640.0K
        CPU: 97ms
     CGroup: /system.slice/dnsmasq.service
             └─29134 /usr/sbin/dnsmasq -x /run/dnsmasq/dnsmasq.pid -u dnsmasq -r /run/dnsmasq/resolv.conf -7 /etc/dnsmasq.d,.dpkg-dist,.dpkg-old,.dpkg-new --local-service --trust-anchor=.,20326,8,2,e06d44b80b8f1d39a95c0b0d7c65d08458e880409bbc683457104237c7f8ec8d

May 27 21:39:07 pop-os dnsmasq-dhcp[29134]: DHCPACK(kubr0) <IP_ADDRESS> 52:52:52:00:00:00 gateway
May 27 21:55:25 pop-os dnsmasq-dhcp[29134]: DHCPDISCOVER(kubr0) 52:52:52:00:00:00
May 27 21:55:25 pop-os dnsmasq-dhcp[29134]: DHCPOFFER(kubr0) <IP_ADDRESS> 52:52:52:00:00:00
May 27 21:55:25 pop-os dnsmasq-dhcp[29134]: DHCPREQUEST(kubr0) <IP_ADDRESS> 52:52:52:00:00:00
May 27 21:55:25 pop-os dnsmasq-dhcp[29134]: abandoning lease to 52:52:52:00:00:00 of <IP_ADDRESS>
May 27 21:55:25 pop-os dnsmasq-dhcp[29134]: DHCPACK(kubr0) <IP_ADDRESS> 52:52:52:00:00:00 gateway
May 27 22:06:50 pop-os dnsmasq-dhcp[29134]: DHCPDISCOVER(kubr0) 52:52:52:00:00:00
May 27 22:06:50 pop-os dnsmasq-dhcp[29134]: DHCPOFFER(kubr0) <IP_ADDRESS> 52:52:52:00:00:00
May 27 22:06:50 pop-os dnsmasq-dhcp[29134]: DHCPREQUEST(kubr0) <IP_ADDRESS> 52:52:52:00:00:00
May 27 22:06:50 pop-os dnsmasq-dhcp[29134]: DHCPACK(kubr0) <IP_ADDRESS> 52:52:52:00:00:00 gateway

After modifying iptables it appended -A KUBENET_NAT -s <IP_ADDRESS>/24 ! -o kubr0 -j MASQUERADE
If these outputs seem ok to you then I think i have some misconfigurations with netplan

The guide assumes that iptables rules are initially empty on the host machine, thus allowing all traffic. If you already had some traffic blocked, then it is expected that you had to add more rules to allow the traffic to VMs.


Files not auto refreshing when changed.

From<EMAIL_ADDRESS>on 2013-03-20T11:59:00Z
Spyder Version:  <IP_ADDRESS>
Python Version:  2.7.0
Qt Version:      4.8.4, PyQt4 (API v1) 4.9.6 on Windows
What steps will reproduce the problem?
1.install <IP_ADDRESS>
2. install 2.1.13 3. What is the expected output? What do you see instead? When I save a file in another editor the changes are not reflected in spyder <IP_ADDRESS>
I have gone back to 2.1.13
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1328

From pierre.raybaut on 2013-03-21T01:10:36Z
This changeset (post-v<IP_ADDRESS> indeed) fixes the issue: https://code.google.com/p/spyderlib/source/detail?r=b2b019b3abb361c47bc4d4df9d3ae33571de88be&repo=v21 But AFAIK, this issue is also happening with v2.1.13.
Status: Duplicate
Mergedinto: 836


Documenting supported versions

What type of PR is this?
/kind documentation
What this PR does / why we need it:
As this project matures, it's important to document our support guarantees going forward. This proposes a set of basic commitments that I think are both safe for us as maintainers and helpful for anyone building a product with this API.
Does this PR introduce a user-facing change?:
NONE

Adding a hold for consensus, want to get consensus from majority of maintainers before merging.
/hold

/cc @hbagdi @shaneutt @youngnick

/hold cancel

/lgtm


Finetuning 2-bit Quantized Models

Hey @johnsmith0031, thank you for this great repo! I was wondering if you tried implementing the backward pass for 2-bit or 3-bit quantized models?
I would really like to try it as an experiment. If you have any existing work on 2-bit or 3-bit autograd, I would love to contribute to it and submit a PR to this repo. Or as a first step, I could run it and share experimental results.

I think we'd better wait for someone succeed in quantizing model in 2-bit without much performance loss (like QLoRA, but not sure aboute it's performance)

So, actually, we know how to do it in two bits! We're a team of researchers at Cornell and we have working prototypes of two-bit compression that achieves good perplexity at inference time. We would like to now explore finetuning and your codebase is very helpful to us.
There are actually two ways of doing it: one is a new algorithm which we are going to soon put on the ArXiv; but even the vanilla GPTQ model performs somewhat acceptably in 2 bits on the largest LLMs (check out Table 7 in their paper).
Would you be interested in talking more about these experiments and exchanging code or ideas?

Thanks for showing interest in my code!
I add 2bit reconstruction functions to the cuda kernel in another branch. I think you can adjust the code if needed.
https://github.com/johnsmith0031/alpaca_lora_4bit/tree/2bit_support

Hello, I have been working on similar topics (2 bits and lower). However, I have noticed that the PPL calculated using the current main branch is consistently higher than the original GPTQ-Triton. I'm interested in understanding the reasons behind this difference. Could you please provide some insights into whether this could be due to version alignment issues or other factors? I would appreciate any ideas or suggestions to further investigate this matter. Thank you, @johnsmith0031

@johnsmith0031 Thank you! The two-bit extension makes a lot of sense. I'm working on modifying it with custom groupsizes and I can return the code as PR if you're interested.
The part that has been giving me more trouble was the 3-bit one. I'm not sure I understand the implementation well enough to figure out how to unpack and return the weight matrix in CUDA. If you happen to have played with that and you have code you could share, that would be helpful, but no worries if not.

Hello, I have been working on similar topics (2 bits and lower). However, I have noticed that the PPL calculated using the current main branch is consistently higher than the original GPTQ-Triton. I'm interested in understanding the reasons behind this difference. Could you please provide some insights into whether this could be due to version alignment issues or other factors? I would appreciate any ideas or suggestions to further investigate this matter. Thank you, @johnsmith0031

Not sure about the reason, but maybe it is because of the difference of matrix multiplication. I first reconstruct the matrix to float16 and use torch.matmul for matrix multiplication (but only for that case when batch_size * seq_len > 8), which is different from both original cuda and triton kernel.

@johnsmith0031 Thank you! The two-bit extension makes a lot of sense. I'm working on modifying it with custom groupsizes and I can return the code as PR if you're interested.
The part that has been giving me more trouble was the 3-bit one. I'm not sure I understand the implementation well enough to figure out how to unpack and return the weight matrix in CUDA. If you happen to have played with that and you have code you could share, that would be helpful, but no worries if not.

Yes 3-bit seems to be more complicated than 4-bit and 2-bit...


Make "image upload" message more explicit on Product Addition

Make "image upload" toast message more explicit on Product Addition.
Replace "Image uploaded successfully" by "Ingredient image uploaded successfully" or "Nutrition image uploaded successfully" or "Front image uploaded successfully"

@VaiTon I would like to work on this issue.
Please assign this issue to me.

@VaiTon  In this we need to change the "Image uploaded successfully" by one of the options mentioned above or change them according to the options (summary / ingredients / photos)

Yes, change the test of the toast should do it for now, as using another view is not something we can do with Toasts AFAIK

So change needs to be done in strings.xml only to one of the options above.

@pratyaksh1610 no it's not. First we have to create different strings for the different kind of images and then we have to use them while creating the Toasts

@VaiTon Got it , thanks.


requestType strings have changed

snippet from: https://firebase.google.com/docs/auth/custom-email-handler
switch (mode) {
case 'resetPassword':
// Display reset password handler and UI.
handleResetPassword(auth, actionCode);
break;
case 'recoverEmail':
// Display email recovery handler and UI.
handleRecoverEmail(auth, actionCode);
break;
case 'verifyEmail':
// Display email verification handler and UI.
handleVerifyEmail(auth, actionCode);
break;
default:
// Error: invalid mode.
}

i tried one of the codes that you have for auth on email, i can't get a value in the json that says the user is unverified.

Hi,
I have updated the following example EmailLogin.mxml
I tried all the functions and had no problem resetting my password and verifying my email.
Please take a look at it and tell if that solved your issue.

Sorry i wasn't so clear, i meant the verify email works, but the user can still login even if he never clicked the link to verify in his email.

Ah, no problem.
In this case you need to do the following:
First, open this link
Let the users log in, then use the Get Account info function to grab the latest information about their profile.
In the response from Get Account Info there's a key named emailVerified with a boolean value.
If the value is true, you let them through, if not you tell them to verify their account and don't proceed to your app content.

Oh OK thanks for the clarification, i was expecting it to be in the json that returns right after a user logs in.


Movement gets borked randomly

Description
This is kinda of a though one to explain due to it's nature of seemingly being random AND not reproducible in localhost (at least with my attempts).
At random points during a round, MOST players get affected by what I can only describe as a "movement freeze", where you seem stuck to something, even if you're in an empty tile (also happens to ghosts). The only movement you can do is if you spam two movement keys (spam W and D, you'll go NE. Spam S and A, you'll go SW, etc).
Emphasis on MOST players get affected as I have witnessed some players be completely fine even when the rest of the server is stuck in place.

Is this just https://github.com/space-wizards/RobustToolbox/issues/2718

very not actionable


[New game]: Clicks Per Minitues

🎮 Game Request
-Game Use Simple Timer with use of js
-With 1 min user needs to click max times.
-Per click 1 point will be given.
Point down the features
-Real time point counting.
-Show your clicking speed
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @zalabhavy !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @zalabhavy ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Feat(codemods): Add codemod to update Tooltip and Dropdown non-flow p…

…lacements #DS-1138

Description

Additional context

Issue reference

coverage: 81.009% (+6.2%) from 74.819%
when pulling 8278d1a63fa7e6b4f3293742df21d1bd789febf9 on feat/codemod-tooltip-dropdown-placement
into 796b843a51e6aefe14f1c189a4e78671297e985e on main.


Cleanup numeric extensions - remove ugly postFormat overhead

Will do this when the alias progresses

A mask like +{+}.9{2} with the jitMasking option removes the need for the postFormat.
This works when using the numericInput option.  But we need an extention to priorities a part of the mask.


[JOSS] Reproducibility - benchmarks do not run

Regarding openjournals/joss-reviews#4991 - This repository is mentioned in the paper being reviewed under "Benchmarks." Upon cloning this repository and following the README.md to run the run_benchmark.py script, I receive this error:
$ python run_benchmark.py --verbose
===========================================
    Ackermann
===========================================
-------------------
    python
-------------------
['python3', '-m', 'timeit', '-s', 'from ackermann_mod import ackermann;import sys; sys.setrecursionlimit(3000);', 'ackermann(3,8)']
1 loop, best of 5: 326 msec per loop

-------------------
    pythran
-------------------
['time', 'pythran', '-O3', '-march=native', '-mtune=native', '-mavx', '-ffast-math', 'ackermann_mod.py']
Traceback (most recent call last):
  File "/home/aaron/pyccel-benchmarks/run_benchmark.py", line 238, in <module>
    p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
  File "/usr/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'time'

Environment information:
$ python --version
Python 3.9.9

$ lsb_release -a
No LSB modules are available.
Distributor ID: Kali
Description:    Kali GNU/Linux Rolling
Release:        2020.4
Codename:       kali-rolling

$ uname -a
Linux AARON-XPS 4.19.104-microsoft-standard #1 SMP Wed Feb 19 06:37:35 UTC 2020 x86_64 GNU/Linux

You do not have the time command on your Linux terminal?

I'm not sure what could be causing this, other than the time command not being available, but I thought that was available on most linux systems. Does PR #4 help with the issue by any chance ?

time is only a shell built-in on my machines. From man bash:
   Pipelines
       A pipeline is a sequence of one or more commands separated by one of the control operators |  or  |&.   The
       format for a pipeline is:

              [time [-p]] [ ! ] command1 [ [|⎪|&] command2 ... ]

    ...

       If  the time reserved word precedes a pipeline, the elapsed as well as user and system time consumed by its
       execution are reported when the pipeline terminates.  The -p option changes the output format to that spec‐
       ified by POSIX.  When the shell is in posix mode, it does not recognize time as a reserved word if the next
       token begins with a `-'.  The TIMEFORMAT variable may be set to a format string that specifies how the tim‐
       ing information should be displayed; see the description of TIMEFORMAT under Shell Variables below.

Wikipedia has a brief explanation of this:

time(1) can exist as a standalone program (such as GNU time) or as a shell builtin in most case (e.g. in sh, bash, tcsh or in zsh).

Because subprocess attempts to execute time directly (that is, Python starts a new process that is time), and time is not a command on my machines (and likely most others), the process cannot start. subprocess does grant you the ability to start a shell instead - Python starts a process that is sh, and sh then starts the process desired (in this case, time), which will succeed in this case (I tested locally). However, shell=True has security implications that you may not want to expose your users to.
Looking around, I see a few alternatives that may work well here. This solution using the resource module looks promising. I will submit a PR shortly.


Cranelift: handle carry flags as bools in backends

Hi! While using Cranelift as a backend for a project, I ran into a panic compiling iadd_carry instructions on x86_64. Please let me know if there is any other information I can provide that would be helpful.
.clif Test Case
function u0:0() fast {
block0:
    v1465 = iconst.i32 0
    v1467 = bconst.b1 false
    v1468 = iconst.i32 0
    v1469, v1470 = iadd_carry v1465, v1468, v1467
    v1476 = bint.i8 v1470
    v1356 = iconst.i64 0
    v1391 -> v1356
    v1423 -> v1356
    v1447 -> v1356
    v1464 -> v1356
    v1494 -> v1356
    v1516 -> v1356
    v1544 -> v1356
    store notrap aligned v1476, v1356+274
    trap user0
}

Steps to Reproduce
cargo run -p cranelift-tools -- compile test.clif --target x86_64
Expected Results
Code successfully generates without a panic.
Actual Results
Panic: thread 'main' panicked at 'ALU+imm and ALU+carry ops should not appear here!', cranelift/codegen/src/isa/x64/lower.rs:5740:13
Versions and Environment
Cranelift version or commit: main HEAD (4a830b at time of writing)
Operating system: Linux
Architecture: x86_64

using this as an excuse to (finally) familiarize myself with the MachInst backend, i'm not sure why ALU+imm and ALU+carry ops should not appear here should be the case - it looks like x64/lower.rs is the place for lowering to happen in x64, eschewing codegen/meta's lowering?
and if that's so, i'd expect rustc_cranelift_codegen to have hit this, but maybe not, since this is the only carry-shaped instruction i see over there.

Greetings @Hypersonic and thanks for the report!
The plan we made when starting to design the new backend was to phase out add+carry (and sub+borrow) opcodes in the CLIF, instead directly providing the wider adds/subs that one would normally lower into carry-using ops. In the legalization-based old backend, i128.add became an i64.add and an i64.add_carry; now we just open-code the two-add sequence. (This was in discussions between myself, @julian-seward1 and @bnjbvr back in Jan 2020 or so.)
The reason for this design choice was that representing carry flags as normal values is fragile performance-wise: to get the correct (fast) machine code, which implicitly passes the bool in the carry flag, one has to pattern-match on the two instructions. The case where the b1 is separate -- as in your example, coming from a constant -- has to be lowered separately with pushf or setc to extract the flag and popf or a conditional diamond with clc/stc. The latter codepaths would almost never be used and so are a correctness risk as well; and these instructions are slow, to the point that there should (hopefully!) almost always be a better way to solve the problem.
Given that we just recently switched the default backend and haven't started the work of removing the old one, we haven't yet cleaned up the opcode space, but we intend to do so eventually.
That does leave the question: what if one actually wants to generate an add-with-carry? I'm definitely open to understanding use-cases better. Are you hoping to take an arbitrary b1 and feed it into the add? Or is this part of a lowering of some other wider arithmetic operation? If the latter, is there any other instruction that would help?

One use it to check for overflow. In cg_clif I currently have to manually check if an overflow has happened even though at least on x86 the processor already provides this information in the form of a flag.

@bjorn3 there is the iadd_ifcout instruction which is supported on the new backends (because stack-limit checks use it too IIRC) -- that should be usable to detect overflows? If not, we can add a variant that works for your case. Getting the flag out is easier (SETcc); it's the reloading into carry and use by subsequent operation, or pattern-matching to avoid that, that's slow/fragile.

My main use case is detecting the carry-out -- I don't really have any particular need for the carry-in, but this was the instruction I found that would give me the output I needed. If there's a different instruction that can give me that, I'm more than happy to use it.

@Hypersonic the iadd_ifcout instruction should give you just that, then, but if your case needs anything other then a trap, we'd need to add pattern-matching for e.g. selectif on its iflags result (right now we just match a trapif on its flags). We can certainly do that! I'm swamped at the moment but can get to this in a while if no one else is able to sooner.

I think I'm covered by iadd_ifcout, thanks for the info! I'm going to close this issue since I think it's resolved for me.

I'm not sure if this issues should be re-opened or I should make a new one, but iadd_carry and iadd_ifcarry are still definitely broken on x86_64.
Example Cranelift IR that doesn't compile:
function u0:0(i64, i64, i64) -> i64 system_v {
block0(v0: i64, v1: i64, v2: i64):
    jump block1

block1:
    v3 = iconst.i64 -5
    v4, v5 = isub_ifbout.i64 v2, v3
    v6 = iconst.i64 2
    v7 = iconst.i64 -1
    v8, v9 = iadd_ifcarry v6, v7, v5
    return v8
}

(Ignore the weird block0)
Changing it to use isub_bout and iadd_carry doesn't work either.
There was a comment asking about what contexts would need this: I'm writing an x86_64 recompilation/partial application engine using Cranelift as a lifting target. That Cranelift snippet is what I am generating for
move |a: usize| {
    let val: usize;
    if Wrapping(a) + Wrapping(0x5) < Wrapping(a) {
        val = 1;
    } else {
       val = 2;
    }
    val
}

or the compiled assembly function of
---- cmp rsi, -0x5
---- mov eax, 0x2
---- adc rax, -0x1
---- ret

Notably, I don't have access to the un-optimized assembly code that is more "natural" and doesn't depend on the CF behavior. I've had several other issues with Cranelift IFLAGS (and the assumption that all ALU operations clobber all flags means this project is probably dead in the water), but this issue (or a similar one) should probably be re-opened to let future users know.

Hi @chc4 -- we can definitely talk about how to support this use-case; I'll re-open the issue. (As a general principle, we want Cranelift to be as generally applicable as is practical; so "here's my use-case and I can't figure out how to express it in CLIF" is always a valid issue!)
We've been discussing recently how to clean up the IR (see e.g. #3205 for discussion of booleans, which overlaps somewhat with the discussion of iflags values here, and bytecodealliance/rfcs#12 which is proposing to remove the old x86 backend that introduced a lot of these lower-level concepts) so these flags-related ops are sort of in a transition period. The application that most commonly used them before -- wide arithmetic with carries/borrows -- is now lowered directly, so we just have sort of skeletal support for any other use-cases that crop up, until we work out the best long-term design. The general approach that I think is best is to represent specific flags as bools and provide ops as needed, so e.g. iadd_carry is a completely reasonable operator to have available. If you or someone else has the bandwidth to add this lowering, it's probably ~10 lines of code; I can point out the right spot. Sorry for the incomplete/in-transition nature of things here!

I'm still not sure it would fit my use-case, since I need correct implementation of all other processor flags, not just CF. Using a B1 and codegen'ing it back to iflags at instruction selection would work for CF, but I'd probably also need code motion and disjoint flag tracking on the selection backend so that e.g. add x, y; lea w, [x+1]; jz ... doesn't error from an invalid iflags live range. I can lift it as v0, b0 = iadd_cout.i64 x, y; v1 = iadd.i64 x, 1; zf = icmp_imm.i64 v0, 0; br eq ..., but I don't think Cranelift is currently smart enough to treat the icmp_imm as an optional use for iflage.ZF and select the non-flags-clobbering LEA for iadds with no carry-out if possible, or move the iadd_cout below it if the LEA isn't encodable. This may be fine, but I also need e.g. OF, which I'm not sure how I would even naively emit as a branch case without a direct iflags type.
If it is usable that would be great, but I assume I would either have to wait for the iflags design to be stabilized further or write optimization and selection passes myself, which might be a bit too much work for a side-project. My current thought is to switch to dynasm-rs so I can lift instructions to the same flags behavior (and re-implement my own IR and register allocation...)

We can continue this discussion on Zulip

For others who want to follow along: link

Is part of this fixed with https://github.com/bytecodealliance/wasmtime/pull/5784 ?


(PUP-2695) Deprecate reopening and merging classes other than "top scope"

Merge PUP-5889 before this PR as this depends on the --strict setting being present.
This PR errors or warns under the control of --strict if a user redefines/reopens a class. This is still allowed for the class named '' (a.k.a 'main'). as that is the compilers way of merging all top scope logic.

Needs a rebase.

Should not be needed as the commits are the same - but will do one anyway.


Markdown support.

The problem
No markdown support.
Should be able to at least use code blocks (by wrapping stuff in ```)
Is Full markdown even possible in other normal clients?
Your environment

python 3.4,
pytg v0.4.8
Mac OS 1.9.5

Steps to reproduce
sender.msg("username", "`this` is code, and ```this\nis\nmultiline code```")

Expected behaviour

Code highlighting
Actual behaviour

Not parsed.

It is possible to at least use  in HTML mode.
[html] msg username "Well, You can send text like this via <code> tag . Easy."

the [html]  was added in https://github.com/vysheng/tg/commit/666e69391e30bc4250c66ca28e69b7d4478762b9

the TGLMF_HTML flag in https://github.com/vysheng/tgl/commit/f20d6c1b164d9413f0cfb699e08779f0d1e8c180

As usual, the modifier [html] modifier can just be appended to every command.

so multiline messages using the html linebreak
[html] msg username "text with a line
 break"

will be possible soon, too (#8, long time ago)


Fix onKeyPress handler

The event received by the onKeyPress is now the key name.
onKeyPress also receive a key press event for the return key which led to a conflict between the onSubmit and the search methods.

I'd be happy to merge once that minor change is made. thanks for the pr!

Done !

thanks for looking into the issue and sending a PR, much appreciated!

published and released as 0.1.2. thanks again!


1.1.0 is not released, gpm installs 1.0.1

When installing this plugin via gpm, it installs 1.0.1, which misses the very handy external addition.
I have installed it in a different way for now, and ran into a small issue where a single quote in the French translation ("barre d'accès") broke the admin environment. Technically I should probably file a separate issue for that, but I think it's more practial to just mention it here.

1.1.0 is released now, should show up soon.


Running the packaged version and applications will download DMG/PKG but not install.

Hello.
Running into an issue where the downloaders will download but then ends there it doesnt run the installer after the download. Not sure how i would go about correcting this issue. The issue may be that I am manually adding it to installomator.sh or my scripting is ass, most likely the second part, but with the packaged version i am unsure where I would add the "new program" to the list. please advise.

What is DEBUG set to on line 28? Sounds like you have DEBUG enabled.
https://github.com/Installomator/Installomator/blob/main/Installomator.sh#L23

Closing no response.


Challenge request with invalid grand ID should return 400 Bad Request

Currently returns 500 Internal Error.

500 is actually the code that the automatic validation decided to return? Confirm and if yes, close this ticket.

If the grant ID specified is in the correct format (ObjectId) but does not exist, the code returned is 400 Bad Request, which is OK.


pyproject: Include tests in sdist

Include tests in sdist, so that they are part of the signed artifacts.

Lint failure is unrelated, so merging.

Thanks!


StackBlitz server crashed

Describe the bug
.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/reart93/react_crud
Steps to reproduce
.
Expected behavior
.
Parity with Local

[X] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Version = 1.84.0
Hash = 499be3932f50ab06349575b1c9042f95bc072a8b
WebContainer = dc4d7514

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 103
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; CrOS x86_64 14816.131.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 111583947,
  "usedJSHeapSize": 98177451,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
TypeError: Invalid value used as weak map key
at WeakMap.set ()
at registerModule (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:161:1216)
at registerImportModuleDynamically (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:266:529)
at internalCompileFunction (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:266:1091)
at wrapSafe (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:144:13497)
at Module._compile (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:144:13881)
at Module._extensions..js (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:144:14855)
at Module.load (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:144:12820)
at Module._load (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:144:10273)
at Function.executeUserEntryPoint [as runMain] (https://reactcrud-pxbj.w-credentialless-staticblitz.com/builtins.5bf3667c.js:165:1641)
Node.js 18.20.3

Hi :wave: thanks for the report!
This github project appears to be empty. What command are you running to get that error?

This bug has been reproduced, we are tracking it internally and will update here when it's fixed!

Duplicate of https://github.com/stackblitz/webcontainer-core/issues/1492
This is now resolved.


Permissions on experience basis

I think there is a need to implement push notification permissions on experience basis. I just received a push notification from an app that i know nothing about, probably opened it while randomly browsing projects a while ago.
Maybe you can add the slug of the app to the push token ExponentPushToken[key][slug] and then from the exponent client we can toggle/remove slug subscriptions. not sure if your backend can handle this, meaning tokens lookup and filtering, or maybe broadcasting later on.
Same goes for geolocation, since it can work in the background as well, a privacy matter, there should be a way to enforce using Exponent.Location, and that module can do the checkup similar to push notifications, is it possible to disable navigator?

An example:

Yes, this is something we're planning on adding! We're also planning on making navigator.geolocation use our location module that is scoped per experience.

any timeline on that @jesseruder?

I am closing this one, as this issue doesn't affect standalone builds.


Create deno.yml

Summary

Test plan

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on main at 96.03%

Totals

Change from base Build<PHONE_NUMBER>:
96.0%

Covered Lines:
4045

Relevant Lines:
4144

💛  - Coveralls


Verify Reactor SubscriberContext

Verify whether or not reactor's subscriberContext is able to fulfill our needs for passing tracing context.

I wrote the following code and it appears to meet the needs (although I suspect we could improve the Context API to make it easier to work with):
import com.azure.core.util.Context;
import reactor.core.publisher.Mono;

import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;

public class ContextConverter {

    public static void main(String[] args) {
        ContextConverter test = new ContextConverter();

        String result = test
            .clientLibraryAPI("Hello, ")
            .subscriberContext(reactor.util.context.Context.of("Name", "Jonathan"))
            .block();

        System.out.println(result);
    }

    public Mono<String> clientLibraryAPI(String prefix) {
        // convert subscriberContext coming into this method into a Context
        return Mono.subscriberContext()
            .map(this::toAzureContext)
            .flatMap(azctx -> serviceCall(prefix, azctx));
    }

    private Mono<String> serviceCall(String prefix, Context context) {
        String msg = prefix + context.getData("Name").orElse("Stranger");
        return Mono.just(msg);
    }

    private Context toAzureContext(reactor.util.context.Context context) {
        Context newContext = null;

        List<Map.Entry<Object, Object>> entries = context.stream().collect(Collectors.toList());
        for (Map.Entry<Object, Object> entry : entries) {
            if (newContext == null) {
                newContext = new Context(entry.getKey(), entry.getValue());
            } else {
                newContext = newContext.addData(entry.getKey(), entry.getValue());
            }
        }

        return newContext == null ? Context.NONE : newContext;
    }
}

One downside of this approach is that our sync API will be calling through to the async API, and it will have to unwrap the Azure Core Context into a Mono SubscriberContext, only for the async API to then have to wrap this back up into an Azure Core Context. One option would be to have package-private methods that take Context in the async API, so that the sync API can call through directly to that. This might help motivate a design for the async impl code too - it might be something like below (coded in GitHub - not likely to actually work):
public Mono<String> clientLibraryAPI(String prefix) {
    return callWithContext(ctx -> clientLibraryAPI(prefix, ctx));
}

// package-private so it can be called direct from sync API
Mono<String> clientLibraryAPI(String prefix, Context context) {
    return serviceCall(prefix, context);
}

// utility method in azure-core
public static <T> Mono<T> callWithContext(Function<Context, Mono<T>> f) {
    // convert subscriberContext coming into this method into a Context
    return Mono.subscriberContext()
        .map(this::toAzureContext)
        .flatMap(f::apply);
}

Implemented in PR - https://github.com/Azure/azure-sdk-for-java/pull/4379


Getting blank screen when I  build an apk and run on real device.

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19042.1237], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Android Studio
[√] VS Code (version 1.59.0)
[√] Connected device (3 available)
• No issues found!
C:\Projects\fitsapp-customer-app>flutter doctor -v
[√] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19042.1237], locale en-US)
• Flutter version 2.2.3 at C:\Users\PC\Documents\src\flutter
• Framework revision f4abaa0735 (3 months ago), 2021-07-01 12:46:11 -0700
• Engine revision 241c87ad80
• Dart version 2.13.4
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at C:\Users\PC\AppData\Local\Android\sdk
• Platform android-30, build-tools 30.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe
[√] Android Studio
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• android-studio-dir = C:\Program Files\Android\Android Studio
• Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
[√] VS Code (version 1.59.0)
• VS Code at C:\Users\PC\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.25.0
[√] Connected device (3 available)
• sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
• Chrome (web)                • chrome        • web-javascript • Google Chrome 94.0.4606.71
• Edge (web)                  • edge          • web-javascript • Microsoft Edge 94.0.992.38
• No issues found!

https://github.com/evilrat/flutter_zoom_sdk/issues/28#issuecomment-987619892 this might help you.
Application tag change is optional

https://github.com/evilrat/flutter_zoom_sdk/issues/28#event-5725519485 check this out

sign the apk and try again with new updated plugin


description of to do items.

The app only has the title option for the to do item. It would be great if we have a description option too.

I would like to start working on this issue. First maybe start with simple text based description, then add support for images.

It seams nobody is working on this issue. So, I would like to start working on this.

i would love to contribute on this issue too
Have you all started contributing here ?

i'm currently working in this issue.


Add advanced command system with tab completion (mojang/brigadier like)

Working since https://github.com/minekube/gate/commit/f03c4849bd2620aa7fadda7104ce737be9c32181, will be merged into master shortly.


NIFI-13995 - CLI - Add start, run once and clear state for processors

Summary
NIFI-13995 - CLI - Add start, run once and clear state for processors
./bin/cli.sh nifi processor-start -procid 0138c512-0193-1000-dbd7-1891f898e909 -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : RUNNING

./bin/cli.sh nifi processor-clear-state -procid 0138c512-0193-1000-dbd7-1891f898e909 -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : STOPPED

.bin/cli.sh nifi processor-start -procid 0138c512-0193-1000-dbd7-1891f898e909 --runonce -p nifi-cli.properties
Name  : ...
ID    : 0138c512-0193-1000-dbd7-1891f898e909
Type  : ...
Bundle: ...
State : RUN_ONCE

Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

Thanks for the review @exceptionfactory - I rebased the PR after the merge of #9522 and pushed a commit to have Run Once as its own CLI command.


Error: Minified React error

Error: Minified React error

Hi @adacnvwp, can you please open a new issue with some extra context? What were you doing when the error occurred? Can you try checking if it also happens in Incognito mode or another browser?
If you haven't done so already, you can also try running composer update to update Ignition or its dependencies to the latest version.
Thanks for reporting this issue and good luck!


[CINFRA-244] Refactor Supervision for Replicated Logs

Scope & Purpose
This wants to become a bigger refactor for ReplicatedLogs; the goal is to make the original code more transparent in two ways:

Make the function that decides which action needs to be taken more monolithic, because that makes it easier to reason about covering all (necessary) cases
Make SupervisionAction a std::variant and use std::visit to execute actions. This makes the code less cluttery than before with using std::unique_ptrs
Refactor the code that creates the agency transactions (i.e. the executor) so that we have functions that create an entry, or update an entry more directly without having to use an envelope (directly).

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[x] :hammer: Refactoring/simplification

Checklist

[x] Tests

[ ] Regression tests
[x] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)
[ ] Backport for 3.7: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

This is superseded by #15855 and #15840


Transfer to nodejs/build?

Hi Johan, would you consider moving tap2junit to the nodejs organization?
I was looking at a couple of tap2junit failures on Node's CI but realized that I can't really make changes because there is no way to publish a new version.

Hi Johan, would you consider moving tap2junit to the nodejs organization?

Sorry. Been on vacation. Sure - lets get it done.

Bump on this one.  #5 seems to be blocking the Python 3 progress at https://github.com/nodejs/node/pull/29451#issuecomment-533727436

@bnoordhuis do you have a pypi account? @trott @mhdawson @rvagg -- we use this, but to maintain it we'd need pypi accounts to publish it to -- or we could just vendor it into node perhaps?
Its copyright status and code heritage is not clear to me, if that matters. Only one file has a copyright statement, and it's GPL, by Redhat.

I am willing to do the PyPI mechanics and be responsible for the repo but does the TSC need to weigh in on creating the new repo especially given the copyright  question?

I am willing to do the PyPI mechanics and be responsible for the repo but does the TSC need to weigh in on creating the new repo especially given the copyright question?

The policy for transferring a repo into the nodejs org is at https://github.com/nodejs/admin/blob/4f463ad194a48a7d73c1d94588903539819fcbe2/GITHUB_ORG_MANGEMENT_POLICY.md#repositories. In a nutshell: open an issue in the admin repository, wait 72 hours, transfer it in if no one opposes doing so.

Done at nodejs/admin#413

Who should I add to pypi? Couldn't find your username

Please add cclauss

@jbergstroem On node.js side we have to wait about 2 more days to accept the repo, but if you could add pypi credentials for cclauss and initiate the xfer, I think that will allow us to press the "accept the  transfer" button in a couple days. Thanks!

@sam-github will do.
Edit:

[x] added cclauss as owner of tap2junit on pypi
[x] transferred ownership of this repo to @nodejs/build team

👍 I got a notice that I have been added as Owner to the PyPI project tap2junit by jbergstroem.

@cclauss Great, @jbergstroem thanks!


Orchestrator: deadline task yield not detected

Task yield half through computation not detected and counted as 2 loops.
Investigate other tracepoints to find a indicator for yield

92c9e9a


Support GeoJSON Point as location data source

My source data need to be formatted as GeoJSON Feature objects, where location data is stored as GeoJSON Points, e.g.:
{
      "type": "Feature",
      "properties": {
        "scalerank": 2,
        "name": "Niagara Falls",
        "comment": null,
        "name_alt": null,
        "region": "North America",
        "subregion": null,
        "featureclass": "waterfall"
      },
      "geometry": {
        "type": "Point",
        "coordinates": [-79.04411780507252, 43.08771393436908]
      }
}

Would it be meaningful to accept GeoJSON Point as a location data source when adding new GeoDocument, e.g.:
// Add a GeoDocument to a GeoCollection
geocollection.add({
  name: 'Geofirestore',
  score: 100,
  // Location coordinates must be a Firebase GeoPoint or a GeoJSON Point!
  geometry:{
      type:'Point'
      coordinates: [-73.9851, 40.7589]
})

Another option could be to accept [lng, lat] array:
geocollection.add({
  name: 'Geofirestore',
  score: 100,
  // Location coordinates must be a Firebase GeoPoint or [lng, lat] array!
  geometry:{
      type:'Point'
      coordinates: [-73.9851, 40.7589]
},
'geometry.coordinates'
)

So as the plugin stands now (v3) I don't think I'd support that. I had initially created the plugin adamant to use GeoPoints, because if Google does choose to support geoqueries natively it would likely be through this data structure. However I'd be open to it in the future. (I'll leave this open for now as I consider how to address/do this)


Only Black Screen seen when Screen Recording/Screen Sharing with overlay open.

When the overlay is open and we try to record screen/share our screen, only black screen is recorded/shared. The seen screen content is not recorded.
Is this a bug with this package or is there something I need to do while using this package ?

Also we cannot take screenshots. While trying to take screenshots, "Taking screenshots is not allowed by the app" is shown.


Add Yarn 2 section to FAQ

#993.
Before submitting the PR, please make sure you do the following

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Yarn 3 fixes the problem
https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#300-rc1

Yarn 3 fixes the problem

A Yarn maintainer confirmed that this isn't the case, at least not yet.
@merceyz thank you for the review. We stand by the wording here though — PnP is broken if the threshold is parity with Node's default behaviour, for the two reasons given. It's true that it's possible to disable PnP, but as long as it's the default it will continue to cause confusion in the JS ecosystem. As maintainers who have been affected by that confusion we feel that the recommendation to use alternative package managers is justified.

Is this still true after PRs https://github.com/yarnpkg/berry/pull/2161 and https://github.com/yarnpkg/berry/pull/3667 got merged? From a cursory glance it seems like PnP supports ES Modules now — can anyone confirm if that means Yarn 3.1+ work with SvelteKit? @Rich-Harris

We don't use yarn, but you are welcome to try it out and report back if it works now


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit e88e522:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-01-10-07-07-04 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-01-10-07-07-04

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Quoted column identifiers

Closes #141

@cdiniz , could this be merged into main? We also have the same problem for column needs quote

Hi All,
With some of the latest commits, the way I implemented this no longer worked.
I've taken a different approach and opened a new merge request: https://github.com/EqualExperts/dbt-unit-testing/pull/194
Feel free to return to the discussion there and push to give this some attention so we can get this included in the main release.


fix: option to assign a uuid for the BOM

Mainly the BOM receives a newly generated uuid assigned on the fly.  This is basically a fix to enable passing an optional parameter within the constructor to be used as the uuid.

@madpah can we move this in?

re: https://github.com/CycloneDX/cyclonedx-python-lib/pull/316#issuecomment-1350575686
We are currently in a feature freeze state, in order to move forward
to https://github.com/CycloneDX/cyclonedx-python-lib/issues?q=is%3Aopen+is%3Aissue+milestone%3A4.0.0
via https://github.com/CycloneDX/cyclonedx-python-lib/tree/dev/3.0.0
This means that your PR might hang for a while.

re: https://github.com/CycloneDX/cyclonedx-python-lib/pull/316#issuecomment-1351308751
actually it would help to just close this very PullRequest and create a new one that introduces the desired behaviour into dev/3.0.0

I noticed that this constructor parameter is already present on dev/3.0.0, so closing this one,


Add Escuela Especializada de Ingeniería ITCA FEPADE

@ManuelPiano I am sorry, the domain itca.edu.sv is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


chore: upgrade containerd to 1.5.16

Reason for Change:
https://github.com/containerd/containerd/releases/tag/v1.5.16
Issue Fixed:

Credit Where Due:
Does this change contain code from or inspired by another project?

[ ] No
[ ] Yes

If "Yes," did you notify that project's maintainers and provide attribution?

[ ] No
[ ] Yes

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Notes:

/azp run

/azp run


Check wins on diagonals

[x] the game object has moves already sorted by row, column. Use that and there's no need for those additional db sorting queries
[x] Go from the last selected cell instead of going X directions for every selected cell in the board.
[x] Same for rows.
[x] and the column check.

the game object has moves already sorted by row, column

Use that and there's no need for those additional db sorting queries.

Good idea, but not completely... The reason why DB queries were used was because they returned only cells selected by the current symbol. The game object contains all selected cells.
Better approach

[ ]  Collect cells selected by the current symbol. The order is not important. Better avoid ordering because it's a redundant additional operation.
[ ] Put them into [row][column] array like it's done in the Game Entity.

Proof


Add react-numpad to the list

I added react-numpad to the list hoping you find it worthy to be in it.

Please review links (spaces in them).
Please also delete one entry from the list that is not awesome :)


Support pending moves on EVM chains

This implements support for pending moves on EVM chains.  That is quite non-trivial to do, as there is no direct way to retrieve "predicted" events for pending transactions.  To work around this, we use a geth feature for eth_call that allows overriding state for a transaction simulation:

We instrument the Xaya accounts contract so that all move events are not only logged, but also saved into an array in storage.
We apply a state override to replace the real accounts contract with this intrumented version.
We also apply a state override to place a contract at the move sender's EoA address.  This contract has a method that performs the actual transaction we want to simulate, and then reads and returns the "move log array" from the call.
This way, we can use eth_call to simulate a particular pending transaction and get all emitted move events in return.

Xaya X now has a "whitelist" of contracts that are likely to send move events.  Every pending transaction calling one of them will be simulated as described, and all emitted events processed as potential pending moves (that get then fed into the GSP).

Note that this needs support for the eth_call extension in Ganache for successful integration tests.


CVE-2018-10237

Required Information

[X] AEM Version, including Service Packs, Cumulative Fix Packs, etc: <IP_ADDRESS>
[X] ACS AEM Commons Version: 3.17.0
[X] Reproducible on Latest? yes

Expected Behavior
Code should pass vulnerability scan.
Actual Behavior
Code fails vulnerability scan with below output.
One or more dependencies were identified with known vulnerabilities in common AEM Project - Reactor Project:

guava-19.0.jar (cpe:/a:google:guava:19.0, com.google.guava:guava:19.0) : CVE-2018-10237
acs-aem-commons-bundle-3.17.0.jar: guava-15.0.jar (cpe:/a:google:guava:15.0, com.google.guava:guava:15.0) : CVE-2018-10237

Latest version:
guava-19.0.jar (cpe:/a:google:guava:19.0, com.google.guava:guava:19.0) : CVE-2018-10237
acs-aem-commons-bundle-3.19.0.jar (cpe:/a:adobe:dispatcher:3.19.0, cpe:/a:apache:commons_email:3.19.0, cpe:/a:apache:commons-httpclient:3.19.0, com.adobe.acs:acs-aem-commons-bundle:3.19.0) : CVE-2016-0957
acs-aem-commons-bundle-3.19.0.jar: guava-15.0.jar (cpe:/a:google:guava:15.0, com.google.guava:guava:15.0) : CVE-2018-10237

Steps to Reproduce
Implement org.owasp.dependency-check-maven in this code repository and perform an analysis. Repository should fail with violation CVE-2018-10237.
Links
https://github.com/google/guava/wiki/CVE-2018-10237
https://www.cvedetails.com/cve/CVE-2018-10237/

dependency-check-maven  is using the owasp dependency checker but example of pom implementation:
        <plugin>
          <groupId>org.owasp</groupId>
          <artifactId>dependency-check-maven</artifactId>
          <version>3.1.2</version>
          <configuration>
            <cveValidForHours>24</cveValidForHours>
            <failBuildOnCVSS>4</failBuildOnCVSS>
          </configuration>
          <executions>
            <execution>
              <goals>
                <goal>check</goal>
              </goals>
            </execution>
          </executions>
        </plugin>

with the following command to execute : mvn dependency-check:check

so I just added this to the project in my fork and the current list of vulnerabilities is:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '4.0':
[ERROR]
[ERROR] jcr-2.0.jar: CVE-2017-16111
[ERROR] commons-email-1.2.jar: CVE-2017-9801, CVE-2018-1294
[ERROR] logback-core-1.0.13.jar: CVE-2017-5929
[ERROR] com.adobe.granite.poi-2.0.6.jar: CVE-2014-9527, CVE-2016-5000, CVE-2017-5644, CVE-2014-3574, CVE-2012-0213, CVE-2014-3529
[ERROR] tika-core-1.14.jar: CVE-2018-1335, CVE-2018-8017, CVE-2018-1338, CVE-2018-11761, CVE-2018-11762, CVE-2018-1339
[ERROR] tika-parsers-1.5.jar: CVE-2016-6809, CVE-2018-1335, CVE-2018-8017, CVE-2018-1338, CVE-2018-11761, CVE-2018-11762, CVE-2018-1339
[ERROR] vorbis-java-tika-0.1.jar: CVE-2016-6809, CVE-2018-1335, CVE-2017-6888, CVE-2018-1338, CVE-2018-11761, CVE-2018-1339
[ERROR] xz-1.2.jar: CVE-2015-4035
[ERROR] pdfbox-1.8.4.jar: CVE-2018-8036, CVE-2016-2175
[ERROR] fontbox-1.8.4.jar: CVE-2018-8036, CVE-2016-2175
[ERROR] jempbox-1.8.4.jar: CVE-2018-8036, CVE-2016-2175
[ERROR] bcprov-jdk15-1.45.jar: CVE-2016-1000341, CVE-2016-1000352, CVE-2013-1624, CVE-2015-7940, CVE-2018-1000613, CVE-2016-1000339, CVE-2016-1000346, CVE-2016-1000338, CVE-2017-13098, CVE-2016-1000343, CVE-2016-1000342, CVE-2018-5382, CVE-2016-1000345, CVE-2016-1000344
[ERROR] poi-3.10-beta2.jar: CVE-2014-9527, CVE-2016-5000, CVE-2017-5644, CVE-2014-3574, CVE-2014-3529, CVE-2017-12626
[ERROR] dom4j-1.6.1.jar: CVE-2018-1000632
[ERROR] org.apache.sling.models.api-1.3.0.jar: CVE-2013-4390, CVE-2016-0956, CVE-2015-2944
[ERROR] jjwt-0.7.0.jar: CVE-2018-7308
[ERROR] org.apache.sling.servlets.annotations-1.0.0.jar: CVE-2016-5394, CVE-2013-4390, CVE-2016-0956, CVE-2016-6798
[ERROR] org.apache.sling.api-2.16.0.jar: CVE-2013-4390, CVE-2016-0956
[ERROR] aws-java-sdk-osgi-1.10.76.jar\META-INF/maven/com.amazonaws/aws-java-sdk-core/pom.xml: CVE-2006-1643, CVE-2007-4177, CVE-2006-1644
[ERROR]

Some of these might be test only.

Unfortunately, I don't think this can be resolved. ACS AEM Commons depends upon Oak for a number of tests and Oak is still using 15.0 and, specifically using a method which has since been made package-private (com.google.common.collect.Iterators.emptyIterator()).
@BillDinger that list is including provided scope dependencies (which is the default for that plugin). The only relevant vulnerabilities IMO are those in embedded dependencies. Your list does include jjwt which is an embedded dependency, but that CVE is related to some PHP application, so I'm confused by that one.

In #1620, I added the dependency check plugin, although had to exclude guava for the reasons stated above. The plugin is configured to only check embedded dependencies (currently guava, jsch, jjwt, and jzlib).

thanks @justinedelson you beat me to the PR . I think there's an argument for changing to scoped dependencies so we try and force the correct, non vulnerable dependencies to be provided

I'm not sure what you mean by "scoped dependencies" but dependency versions cannot be changed at will -- most of those dependencies are provided by the base platform and must be the exact versions used by the minimal compatible version of the platform. This project should not recommend users do something which would impact their ability to obtain support from Adobe.
That said, I suspect that some of these dependencies may be outdated and as part of changing the minimal version from 6.2 to 6.3, some cleanup would be useful. For example, I'm not sure that the explicit Sling Model API dependency is necessary if the minimal AEM version is 6.3.

Meant provided not scoped apologies. Changing to 6.3 provided dependencies if that is the minimum we are now supporting would clear up most of these. Went through similar when cleaning up our own provided dependencies when going from 6.1 -> 6.3 and virtually everything had been updated or was updated in subsequent fix packs

ah, yeah. there's actually a configuration to ban all compile-scope dependencies by default. I'd personally recommend every AEM project do that :)

one bit of follow up - I confirmed with some internal documentation that AEM is not vulnerable to this particular issue because of the deserialization firewall.

...but because suppression is lame (and Oak 1.8.4+ gets rid of the incompatibility - https://issues.apache.org/jira/browse/OAK-7186), I went ahead and updated Guava anyway.


Remove git bindings from docs and CI as no longer used

Coverage decreased (-0.5%) to 87.221% when pulling 24f3b4918d5cf93e4e5e3f34c66de1ce92026ab6 on no-git-bindings into 250abbd2b74e4c01a374e2efcfde07b0d84b3384 on master.

Nice! +1

LGTM!


[protobuf] update to the latest release (v5.29.1)

Updates protobuf to the latest release (v5.29.1)
Tested locally (on x64-linux) with:
./vcpkg remove protobuf && ./vcpkg install 'protobuf'

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the update!
(The build failures were baseline issues also in https://dev.azure.com/vcpkg/public/_build/results?buildId=109931&view=results )

Oh, I thought this had already landed, stand by...


[TEST] - Unit test for JoinRows step as a part of PDI-14994.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/joinrows/JoinRows.java
  engine/test-src/org/pentaho/di/trans/steps/joinrows/JoinRowsTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change:  + 1.27%
Complexity Change:  + 2.00%

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .39%
Complexity Change:  + .51%
Instruction Change:  + .08%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .15%
Complexity Change:  + .36%
Instruction Change:  + .30%
Line Change:  + .30%
Method Change:  + .49%

org.pentaho.di.trans.step.StepMeta

Instruction Change:  + .19%
Line Change:  + .27%

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change:  + 8.70%
Complexity Change:  + 3.08%
Instruction Change:  + .75%
Line Change:  + .89%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -.10%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -.63%:small_red_triangle_down:
Complexity Change: -.40%:small_red_triangle_down:
Instruction Change: -.49%:small_red_triangle_down:
Line Change: -.23%:small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -.05%:small_red_triangle_down:

org.pentaho.di.trans.steps.joinrows.JoinRows

Branch Change:  + 60.12%
Complexity Change:  + 50.70%
Instruction Change:  + 64.84%
Line Change:  + 63.59%
Method Change:  + 60.00%

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change:  + .06%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%
Instruction Change:  + .18%
Line Change:  + .48%

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -.18%:small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change:  + 3.33%
Complexity Change:  + 1.85%
Instruction Change:  + .28%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change:  + .53%

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -.18%:small_red_triangle_down:

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.BaseStep

Branch Change: -.29%:small_red_triangle_down:
Complexity Change: -.18%:small_red_triangle_down:
Instruction Change: -.13%:small_red_triangle_down:
Line Change: -.23%:small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/joinrows/JoinRows.java
  engine/test-src/org/pentaho/di/trans/steps/joinrows/JoinRowsTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -1.27%:small_red_triangle_down:
Complexity Change: -2.00%:small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.01%:small_red_triangle_down:
Complexity Change: -1.06%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change:  + 3.28%
Line Change:  + 3.87%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .15%
Complexity Change:  + .36%
Instruction Change:  + .30%
Line Change:  + .30%
Method Change:  + .49%

org.pentaho.di.trans.step.StepMeta

Instruction Change: -.19%:small_red_triangle_down:
Line Change: -.27%:small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -.63%:small_red_triangle_down:
Complexity Change: -.40%:small_red_triangle_down:
Instruction Change: -.49%:small_red_triangle_down:
Line Change: -.23%:small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 2.08%
Complexity Change:  + 2.11%

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2.00%:small_red_triangle_down:
Complexity Change: -1.89%:small_red_triangle_down:
Instruction Change: -.17%:small_red_triangle_down:

org.pentaho.di.trans.steps.joinrows.JoinRows

Branch Change:  + 55.02%
Complexity Change:  + 47.31%
Instruction Change:  + 55.72%
Line Change:  + 56.04%
Method Change:  + 60.00%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -.14%:small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -.08%:small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change:  + .08%

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change:  + .04%

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.19%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.step.BaseStep

Complexity Change:  + .18%
Instruction Change:  + .20%
Line Change:  + .38%
Method Change:  + .49%

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f engine/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f engine/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  engine/src/org/pentaho/di/trans/steps/joinrows/JoinRows.java
  engine/test-src/org/pentaho/di/trans/steps/joinrows/JoinRowsTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.auth.core.impl.DefaultAuthenticationConsumerFactory

Branch Change: -7.14%:small_red_triangle_down:
Complexity Change: -7.69%:small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change:  + .78%
Complexity Change:  + 1.03%
Instruction Change:  + .16%

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1.00%:small_red_triangle_down:
Complexity Change: -1.41%:small_red_triangle_down:
Instruction Change: -.30%:small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.28%:small_red_triangle_down:
Line Change: -3.87%:small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change:  + .66%
Complexity Change:  + .93%
Instruction Change:  + .13%

org.pentaho.di.trans.step.BaseStep

Branch Change:  + .15%
Complexity Change:  + .36%
Instruction Change:  + .30%
Line Change:  + .30%
Method Change:  + .49%

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change:  + .11%

org.pentaho.di.trans.steps.combinationlookup.CombinationLookupMeta

Instruction Change: -.04%:small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change:  + .10%

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change:  + .05%

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Instruction Change: -.09%:small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -.63%:small_red_triangle_down:
Complexity Change: -.40%:small_red_triangle_down:
Instruction Change: -.49%:small_red_triangle_down:
Line Change: -.23%:small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change:  + 1.28%
Complexity Change:  + .78%
Instruction Change:  + .08%

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change:  + 1.04%
Complexity Change:  + 1.05%
Instruction Change:  + .14%
Line Change:  + .37%

org.pentaho.di.trans.steps.joinrows.JoinRows

Branch Change:  + 54.83%
Complexity Change:  + 46.38%
Instruction Change:  + 56.04%
Line Change:  + 56.51%
Method Change:  + 60.00%

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change:  + 1.18%
Complexity Change:  + 1.35%

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.33%:small_red_triangle_down:
Complexity Change: -1.85%:small_red_triangle_down:
Instruction Change: -.28%:small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change:  + .91%
Complexity Change:  + .82%

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -.53%:small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change:  + .18%

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.79%:small_red_triangle_down:
Complexity Change: -1.19%:small_red_triangle_down:
Instruction Change: -.07%:small_red_triangle_down:

org.pentaho.di.www.TransformationMap

Branch Change: -3.41%:small_red_triangle_down:
Complexity Change: -3.08%:small_red_triangle_down:
Instruction Change: -.94%:small_red_triangle_down:
Line Change: -1.54%:small_red_triangle_down:


Is there a way to get the shared resources in a chat?

Hi,
if I open a user/group/channel info in the official telegram app, I can see a summary about the shared files:

Is there a way to get this data from tdlib?
I already checked BasicGroupFullInfo and the UserFullInfo, but it doesn't contain any information like this.

You can use getChatMessageCount and getGroupsInCommon to receive the counters.

Great, thank you!


Unable to build identity-apps repository

Describe the issue:
Unable to build the https://github.com/wso2/identity-apps repository locally due to a heap memory issue.
How to reproduce:

Clone Identity apps repository.
Install node
Execute npm run build:dev which results in  FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory error. If I start the console app after this, that also does not work and eventually times out when I try to access https://localhost:9001/console

@wso2is/console: <--- Last few GCs --->
@wso2is/console: [8959:0x1046c6000]   354459 ms: Scavenge 3922.8 (4108.3) -> 3913.4 (4100.7) MB, 1.5 / 0.0 ms  (average mu = 0.200, current mu = 0.098) allocation failure
@wso2is/console: [8959:0x1046c6000]   355007 ms: Mark-sweep 3932.2 (4115.9) -> 3913.4 (4094.4) MB, 519.1 / 0.0 ms  (average mu = 0.148, current mu = 0.093) allocation failure scavenge might not succeed
@wso2is/console: [8959:0x1046c6000]   355032 ms: Scavenge 3930.5 (4109.7) -> 3921.1 (4102.1) MB, 1.5 / 0.0 ms  (average mu = 0.148, current mu = 0.093) allocation failure
@wso2is/console: <--- JS stacktrace --->
@wso2is/console: FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
@wso2is/console:  1: 0x1012e4da5 node::Abort() (.cold.1) [/usr/local/bin/node]
@wso2is/console:  2: 0x1000a6239 node::Abort() [/usr/local/bin/node]
@wso2is/console:  3: 0x1000a639f node::OnFatalError(char const*, char const*) [/usr/local/bin/node]
@wso2is/console:  4: 0x1001e9007 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
@wso2is/console:  5: 0x1001e8fa3 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
@wso2is/console:  6: 0x100397e95 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/usr/local/bin/node]
@wso2is/console:  7: 0x10039995a v8::internal::Heap::RecomputeLimits(v8::internal::GarbageCollector) [/usr/local/bin/node]
@wso2is/console:  8: 0x100395029 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/usr/local/bin/node]
@wso2is/console:  9: 0x1003928c1 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
@wso2is/console: 10: 0x1003a115a v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
@wso2is/console: 11: 0x1003a11e1 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
@wso2is/console: 12: 0x10036eb87 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/usr/local/bin/node]
@wso2is/console: 13: 0x1006ed8d8 v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
@wso2is/console: 14: 0x100a7a239 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/usr/local/bin/node]
@wso2is/console: ><EMAIL_ADDRESS>test /Users/wso2/tharindub/repositories/public/identity-apps/apps/console
@wso2is/console: > npx jest --passWithNoTests
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: ts-jest[config] (WARN) The option `tsConfig` is deprecated and will be removed in ts-jest 27, use `tsconfig` instead
@wso2is/console: PASS src/extensions/components/tests/example.test.tsx (19.771 s)
@wso2is/console:   Test Suite - Sample Extension Component.
@wso2is/console:     ✓ Test proper rendering of Sample Extension component (63 ms)
@wso2is/console: PASS src/features/remote-repository-configuration/tests/remote-fetch-status.test.tsx (24.169 s)
@wso2is/console:   UTC-4.0 - [Remote Fetch Configuration] - Configuration Status
@wso2is/console:     ✓ UTC-4.1 - Test proper rendering of Remote Fetch Configuration Status (132 ms)
@wso2is/console:     ✓ UTC-4.2 - Test trigger confirguration button click event (28 ms)
@wso2is/console:   console.error
@wso2is/console:     Warning: Received `true` for a non-boolean attribute `compact`.
@wso2is/console:
@wso2is/console:     If you want to write it to the DOM, pass a string instead: compact="true" or compact={value.toString()}.
@wso2is/console:         in div (created by MenuItem)
@wso2is/console:         in MenuItem (created by RemoteFetchStatus)
@wso2is/console:         in div (created by Menu)
@wso2is/console:         in Menu (created by RemoteFetchStatus)
@wso2is/console:         in RemoteFetchStatus
@wso2is/console:         in Provider
@wso2is/console:       at console.error (../../node_modules/@testing-library/react/dist/act-compat.js:53:34)
@wso2is/console:       at printWarning (../../node_modules/react-dom/cjs/react-dom.development.js:88:30)
@wso2is/console:       at error (../../node_modules/react-dom/cjs/react-dom.development.js:60:5)
@wso2is/console:       at validateProperty$1 (../../node_modules/react-dom/cjs/react-dom.development.js:5557:9)
@wso2is/console:       at warnUnknownProperties (../../node_modules/react-dom/cjs/react-dom.development.js:5595:21)
@wso2is/console:       at validateProperties$2 (../../node_modules/react-dom/cjs/react-dom.development.js:5619:3)
@wso2is/console:       at validatePropertiesInDevelopment (../../node_modules/react-dom/cjs/react-dom.development.js:5662:5)
@wso2is/console:   console.warn
@wso2is/console:     Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
@wso2is/console:
@wso2is/console:     * Move data fetching code or side effects to componentDidUpdate.
@wso2is/console:     * If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
@wso2is/console:     * Rename co

Tried increasing the heap memory by setting the env variable export NODE_OPTIONS=--max-old-space-size=8192. Still build fails.
Expected behavior:
Build should be healthy and I should be able to access console and myaccount applications.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: Mac OSX Catalina 10.15.5
Node: Tried 10, 12, 14, 15

I had an investigation with the help of @brionmario. When checked out to 1.2.83 -> execute npm clean-all and try to build, then this issue resolves. So it should be a change introduced lately.

Should be resolved with https://github.com/wso2/product-is/issues/13931.


misleading title

The title could be confused by admins to select "All cloud apps", which is a selection possible when configuring a CA policy.  Selecting "All cloud apps" also includes service dependencies that cannot be excluded and can cause unexpected CA results.
Title change better reflects that a CA admin should selectively choose the applications end-users utilize rather than a "catch-all" of using the "All cloud apps" selection.

@dakoer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

WE do not only want to reference end users. Admins should definitely have CA policies applied to them. Given the IMPORTANT note just below, I htink this is clear, however, i am willing to say "each app"

#close

I think your suggestion of including "each app" in the title conveys the correct difference of selecting multiple apps vs. "All cloud apps".

I submitted a pull requests and it should go live later today
Thank you!
-bmws
Barbara Winter Selden
Identity Knowledge Mangement
206-601-4223
From: David Koerth<EMAIL_ADDRESS>Sent: Wednesday, July 1, 2020 9:35 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Barbara Winter Selden<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] misleading title (#58178)
I think your suggestion of including "each app" in the title conveys the correct difference of selecting multiple apps vs. "All cloud apps".
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F58178%23issuecomment-652524414&data=02|01|Barbara.Selden%40microsoft.com|a12e462fc2d348d802e808d81ddca629|72f988bf86f141af91ab2d7cd011db47|1|0|637292180803545777&sdata=gUGyAbXJ7Icx57eEmRAm3EJcrozvh3JyzBrGucfBo5Q%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG4WUUS6YE5KHBN4AQ5YIQTRZNQR5ANCNFSM4OMT5QOA&data=02|01|Barbara.Selden%40microsoft.com|a12e462fc2d348d802e808d81ddca629|72f988bf86f141af91ab2d7cd011db47|1|0|637292180803545777&sdata=at0Y%2FI7EIQvkh%2BJ1uar28yEJurrEuxbIUBQmydTRArs%3D&reserved=0.

Per author’s comment, a separate PR underway. #please-close


Rails 7 Deprecation Warnings

Rails 7 has deprecated ActiveRecord::Base.default_timezone in favor of ActiveRecord.default_timezone.  The railtie for this gem is referencing the deprecated method and generates a warning.  Happy to push a merge request if that will help.
DEPRECATION WARNING: ActiveRecord::Base.default_timezone is deprecated and will be removed in Rails 7.1.
Use `ActiveRecord.default_timezone` instead.

Fixed in #213  .. for now I'm using
 gem 'validates_timeliness', '~> 6.0.0.beta2', github: "mitsuru/validates_timeliness", branch: "rails7"

When will the new version be released? Still the beta out there

+1

thanks for costing me tons of time for nothing... #*#$!&#


joinp: add --right-anti and --right-semi options

Per @datatraveller1 in https://github.com/dathere/qsv/discussions/2363

It would be nice if the following options could be added:
--right-anti
--right-semi
I know I can achieve this by using --left-anti and --left-semi and swapping   and  , but that would be more convenient.

Thank you! I find these -anti and -semi options very useful for list intersection comparisons.
If you decide do add  --right-anti and --right-semi to joinp, it should probably also be added to join.

Just implemented it for joinp. Will add it to join as well for symmetry & consistency and track it on a separate issue.

Hi @jqnatividad, great thank you very much!


feat(documentation): style storybook manager gui

Preview environments are getting posted here, as soon as they are ready!


disabling device discovery for the amazon-echo-hub node does not stop the server on port 80

HI,
Excellent work so far avoiding errors in HA!
The only thing that it seems not to be working now is that after detecting devices in Alexa I tried to disable the "Device Discovery" in the amazon-echo-hub node, but the web server does not stop serving description.xml and /api/description.xml

Could you check this? Thanks


[DOCS] need Constants file for socket events

Description
Organizing constants in a separate file helps keep code clean and organized. It also makes it easier to find the constant you need when working on a project, as all of them are stored in one place. This is especially useful for larger projects with multiple developers, as everyone can easily access the same set of constants.
Screenshots
No response
Additional information
Defining constants in a separate file also allows for better scalability. If changes need to be made to the constants, they can be done quickly and easily without having to search through the entire codebase. Additionally, if new constants need to be added, they can simply be added to the constants file instead of having to modify existing code.
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

duplicate of #310


Browser Support

Need to use webpack for this. Or rollup or snowpack or whatever...
ERROR in<EMAIL_ADDRESS>52:28-45

Module not found: Error: Can't resolve 'crypto' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "crypto": require.resolve("crypto-browserify") }'
	- install 'crypto-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "crypto": false }

ERROR in<EMAIL_ADDRESS>29:13-26

Module not found: Error: Can't resolve 'fs' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist\mixins'

ERROR in<EMAIL_ADDRESS>31:15-30

Module not found: Error: Can't resolve 'path' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist\mixins'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "path": require.resolve("path-browserify") }'
	- install 'path-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "path": false }

ERROR in<EMAIL_ADDRESS>51:24-37

Module not found: Error: Can't resolve 'fs' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist'

ERROR in<EMAIL_ADDRESS>73:24-37

Module not found: Error: Can't resolve 'fs' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist'

ERROR in<EMAIL_ADDRESS>83:32-48

Module not found: Error: Can't resolve 'https' in 'C:\Users\duong\Documents\GitHub\test-dir\node_modules\@codyduong\ytmusicapi\dist'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "https": require.resolve("https-browserify") }'
	- install 'https-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "https": false }

What the fuck.
https://github.com/crypto-browserify/cipher-base/issues/10


IE9 on Windows 7 logs as IE7

Example user agent?

I have the following code:
$browser = Agent::browser();
$browserVersion = Agent::version($browser);
$platform = Agent::platform();
$platformVersion = Agent::version($platform);
$agent = $platform . " " . $platformVersion . " -- " . $browser . " " . $browserVersion;

And it outputs:
Windows 6.1 -- IE 7.0
I asked for a screenshot with more info about the browser:

this is the user-agent from the same user as the screenshot:
Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/5.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; MS-RTC LM 8; Zune 4.7; Media Center PC 6.0; .NET4.0C; .NET4.0E; InfoPath.3)

Isn't MSIE 7.0 Internet Explorer 7? That's one weird user agent string.

http://www.useragentstring.com/ tells me this:
Internet Explorer version 7.0 (MSIE 9.0 in 7.0 Compatibility View)

Apparently Trident/5.0 means that it's coming from an IE9 browser. It's a bit of an edge case actually. To fix this I would have to add custom code for IE only, which I would rather not do of course :)
In case of IE, you could try to check for:
Agent::version('Trident');

This will return 5 in this case. To get the actual IE number, you need to add 4 to it.

ok, thanks!
I'll try to convince the the customer to disable that mode first :-)


[TreeView] Scroll jump bug

When Tree View has a larger height than the window height, clicking Tree Items first jumps the position of the item to the top and then on the second click toggles. See the video, please.
A similar thing happens in the last items too - it just positions the element to the bottom and it is really hard to click it then.
Items in the middle seem fine.
Official doc examples have the same problem.
https://user-images.githubusercontent.com/7082560/102820418-84cc2b00-43d5-11eb-94fb-f7019d355366.mov

Please provide a minimal reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

@oliviertassinari here you go: https://codesandbox.io/s/scroll-jump-bug-24096-46x3q?file=/demo.tsx
Just add some content before the tree, and page needs to have scroll.

@bumTomica Thanks for reporting the issue. @joshwooding What do you think about this fix?
diff --git a/packages/material-ui-lab/src/TreeItem/TreeItem.js b/packages/material-ui-lab/src/TreeItem/TreeItem.js
index 742f6663e5..54b960cebf 100644
--- a/packages/material-ui-lab/src/TreeItem/TreeItem.js
+++ b/packages/material-ui-lab/src/TreeItem/TreeItem.js
@@ -223,7 +223,7 @@ const TreeItem = React.forwardRef(function TreeItem(props, ref) {
   function handleFocus(event) {
     // DOM focus stays on the tree which manages focus with aria-activedescendant
     if (event.target === event.currentTarget) {
-      ownerDocument(event.target).getElementById(treeId).focus();
+      ownerDocument(event.target).getElementById(treeId).focus({ preventScroll: true });
     }

     const unfocusable = !disabledItemsFocusable && disabled;

@bumTomica Thanks for reporting the issue. @joshwooding What do you think about this fix?
diff --git a/packages/material-ui-lab/src/TreeItem/TreeItem.js b/packages/material-ui-lab/src/TreeItem/TreeItem.js
index 742f6663e5..54b960cebf 100644
--- a/packages/material-ui-lab/src/TreeItem/TreeItem.js
+++ b/packages/material-ui-lab/src/TreeItem/TreeItem.js
@@ -223,7 +223,7 @@ const TreeItem = React.forwardRef(function TreeItem(props, ref) {
   function handleFocus(event) {
     // DOM focus stays on the tree which manages focus with aria-activedescendant
     if (event.target === event.currentTarget) {
-      ownerDocument(event.target).getElementById(treeId).focus();
+      ownerDocument(event.target).getElementById(treeId).focus({ preventScroll: true });
     }

     const unfocusable = !disabledItemsFocusable && disabled;

Looks good


[BUG] Incorrect casing of "GitHub"

Description
GitHub is incorrectly written as "Github".
Expected
"GitHub"

Need to add a permanent linter check for this one and fail the build if the word GitHub case is incorrect and not a part of a link.


Added guards to unwrap video connection and buffer

I recently noticed a few crashes from users whenever the shot button was pressed. I am unable to exactly pinpoint the error, but the crash logs states that it is in shotPressed. So I added two new guards just to make sure that the app at least don't crash when force-unwrapping the connection and buffer.
Currently the crashes has occurred on iOS 12 on devices iPhone 6s, 7 and 8.

Updated pod to 1.3.3


[Candidate 1v1 Canyon Frost ZH v1] Map is a copy of Canyon of the Dead

Observed behavior
Canyon Frost is a copy of Canyon of the Dead. There appear to be no major differences between these 2, other than some minor ones like repositioned main Supply Dock, more space around secondary Supply Dock, repositioned houses in villages, repositioned Tech Buildings, minor changes in ramps.
If I am not mistaken this exact map was already dropped in 2021.
See https://github.com/TheSuperHackers/GeneralsRankedMaps/commit/2f7f82a892e57d3308851ce6a18a9914d5e65e1e

Rejected by Rising

Why is a winter version needed again?
Expected behavior
Ranked Maps have unique designs. Maps do not come in duplicated desert, gras, snow variants, because that would bloat the map selection unnecessarily.

i dont think its needed

I improoved Canyon of the Dead years ago and think if that one has major issue, we shall work on them without creating another same map.

Message from MP3:
The map was done based on someone's request which included making minor changes on it, hence a large amount of similarities between original Canyon & Frost edition remaining. The entire list of changes are the following:

Improved visuals/Winter Setting; The lightning became brighter.
Cars were removed entirely off the map!
The middle path is now wider, and is on the same ground level as player bases.
The amount of buildings, on the top and bottom, sides of the map have been shortened down to 4. (Previously there were 10)
Each building is important for the taking, as each structure covers up the tiny path(s) that is leading towards the 2nd supply, in the form of piles.
Command Center positions are now further away from the starting supply dock; China should no longer experience a space-limitation whenever placing down a power near by.
Overall map-terrain is now smoother.
Reinforcement Pads were swapped with Repair Bays
Other than that, visuals remained mostly the same

Although both are similar, in my personal opinion, this can be ranked as this provides much better gameplay than the canyon of the dead and canyon of the dead can be removed from auto download.