is there a way to execute only r10k step when running onceover

Hi,
I am new to onceover and puppet but I am working on testing a control repo with 50+ roles.
I want to trigger onceover from a Azure Devops build, but since I cannot use --parallel (there is already an issue opened on this), I split onceover.yaml in several files and I try to run them in parallel.
In order to shortened the test execution, I want to download all the needed modules on a single location, and then run several onceover instances (with puppet/puppet-dev-tools docker image) that point to that location.
Is there a way to have onceover only downloading the modules ( to make this a first step in the build)?
I tried to download them with a r10k command, but for some reason the execution of onceover afterwards fails.
As a workaround, currently I am executing onceover with a file having no classes defined.
Regards,
John

Hey! The easitest way would be to define some tags that dont exist i.e. --tags donttestanythingplease. That way it won't match any tests and nothing will run, but r10k will still run

I'm going to close this as I'm pretty certain it works for what you need here. But feel free to comment if that's not the case

Thank you, in the meantime my workaround was to use an onceover.yaml file with no classes to test.


Pass build arguments to some swiftExec calls

These particular commands (or subcommands) take the same build arguments as we pass to "build", "run", and "test" commands. To get our tests to run in a sandbox, we need to disable sandboxing because you cannot create a new sandbox when you're already running under a sandbox

Leaving in draft state until we have macOS builders to test this

Have you verified that all of these commands will work with all the build arguments. I'm just wondering if it is safer to have a disable sandbox option which is used in these cases

Ya should have explained in commit message but if you look at:
swift help build > build.txt
swift help package > package.txt
diff build.txt package.txt

Other than "package" having different subcommands, the options are the same other that build can specify target, product, and enable/disable swift-testing and XCTest. In my mind the user wouldn't put these in build arguments to use for everything but maybe you can think of a case I haven't.
Yes the other option is a boolean setting to disable sandboxing but wasn't keen on introducing a new setting for our niche use case, but yes may be safer bet


Replaced the Cognifide logo with Slice icon in package definition

Slice is getting its own logo. I removed the Cognifide logo from the CRX
package definition and replaced it with the new icon that looks like a
slice of pizza (sic!)
Removed the thumbnail/file node, it turns out doing this allows us to get
rid of the OOTB glossy look and feel of icons.

Can you please updated the add-on too?

Coverage remained the same at 66.337% when pulling 8e2c96f85febfef758d090b956c68a23fce5bed2 on feature/new-icon into c2441b1c379020583f418280344edfee510ad0bb on master.

@mmajchrzak will do

Coverage remained the same at 66.337% when pulling 6aab42090897563a651c553d28ccea5e81c7b912 on feature/new-icon into c2441b1c379020583f418280344edfee510ad0bb on master.


Payment protocol implementation only supports paying to p2pkh and p2sh with one output

Payment protocol includes outputs to use for payment. However the current implementation will recreate the output based on standard address formats, and recognizes only one output that is either pay-to-script-hash or pay-to-public-key:
var output = outputs[0];

https://github.com/bitpay/bitcore-wallet-client/blob/master/lib/paypro.js#L116
var buffer = new Buffer(new Uint8Array(output.get('script').buffer));
var scriptBuf = buffer.slice(offset, limit);
var addr = new Bitcore.Address.fromScript(new Bitcore.Script(scriptBuf), network);

https://github.com/bitpay/bitcore-wallet-client/blob/master/lib/paypro.js#L129

This will become more necessary when for paying to native segwit outputs as BIP70 is listed as backwards compatible: https://github.com/bitcoin/bips/blob/master/bip-0141.mediawiki#Backward_compatibility


fix: remove await this.setState; use callback instead resolves Issue #9

Issue #9

:tada: This PR is included in version 0.3.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


game-session-time

Describe the Problem
As a player-team-member is my time till the Terror gets me shared between my other team members or do I have my own time?
References
No response
Describe the Proposed Solution
Time is shared across the "Team" but each player has a "Time" value.

Team has collective Time (e.g. 10 minutes)
Players have an individual Time value (hidden or public) that can be gained by sacrificing player (POST-MVP)


Fix a remaining typo

I was just browsing around and noticed that #12 forgot to fix one of the typos in a doc comment. Hereby fixed.
I found this on the haskell-cafe mailing list; looks cool!

Thanks @tomsmeding - i appreciate any and all typo fixes 😄


Feature: Plushies of Developers

Content
Adds Plushies of the developers and artists who worked on this project
Contributors

Dev - Rae
Dev - PriestOfFern
Dev - Sascha
Dev - ShiroJR
Artist - all members of Create: Calamity

plushie models and textures currently available have been added, custom block class in progress

Added scuffed sound interaction functionality... feel free to change that thing (48622370c3b9935acecae96e6a570309a7d0a7e0 - 88c6661c678a048195888871c5f57c625ff590dd)

Yes

should plushies have 8 possible facings? (N,NE,E,SE,S,SW,W,NW)

address in branch feat/plushie-added-rotation


[2.0] [WIP] Add type hints

Q
A

Type
improvement

BC Break
yes

Fixed issues
#1704

This is work in progress and only UnitOfWork & DocumentManager are done for now.
Some @param & @return docs are invalid so I think that a decision has to be taken which are supported and which not. Take a look at https://github.com/doctrine/mongodb-odm/pull/1846/files#diff-c5b64e39a058b30afece06cc7cd217b7R387 which must support https://github.com/doctrine/mongodb-odm/blob/master/lib/Doctrine/ODM/MongoDB/Query/Builder.php#L109

Thanks for the feedback!
I'll do a rebase when I'll finish. I'm doing this step by step to be easier to fix failing tests or to update type hints. And yes, I know about Doctrine\Common\Proxy being replaced with ocramius/proxy-manager so I will ignore involved classes.

@alcaeus I'm not sure about the code in lib/Doctrine/ODM/MongoDB/Aggregation. Is it worth it to add type hints there ? For some classes I couldn't find any usages.

Most of the arguments to the methods in aggregation pipeline stages accept multiple arguments: a scalar value, an array containing a MongoDB expression or an aggregation Expr object - type hinting is currently impossible unless we introduce value objects which I wouldn't do on short notice.
Do you have any specific issues with aggregation classes?

@alcaeus Can you take a look at \Doctrine\ODM\MongoDB\Aggregation\Stage\GraphLookup\Match::getExpression ? I'm not sure that the method body is correct because \Doctrine\ODM\MongoDB\Aggregation\Stage::getExpression says that the return type should be an array.

I think I've understood why the method body is like that: search for restrictSearchWithMatch https://docs.mongodb.com/manual/reference/operator/aggregation/graphLookup/

Regarding Doctrine\ODM\MongoDB\Aggregation\Stage\GraphLookup\Match::getExpression, its typehint is wrong - it should be @return array|object. The problem is that we need to be specific about arrays vs. objects for the driver. For non-empty values this is relatively easy, but for empty values we need to explicitly convert them to arrays. This might be something that might remain non-strictly typed until we can deal with it properly.
As for tests I can take a look at the two failing tests and why they fail. Step-debugging should prove helpful here to see where they go wrong. Once we've done that and fixed issues found by our static analysers (phpcs and PHPStan) I'll give this another review.

I've made a minor change to Doctrine\ODM\MongoDB\Aggregation\Stage\GraphLookup\Match::getExpression so we can have only 1 return type: array. Take a look at https://github.com/doctrine/mongodb-odm/pull/1846/files#diff-149e2cae007283dbcfb76c37c91fe524R27 and https://github.com/doctrine/mongodb-odm/pull/1846/files#diff-40007aeae56972528d22a8a3f15acf17R175

@alcaeus I've managed to track down the issue with the failing tests. As you can see in commit https://github.com/doctrine/mongodb-odm/pull/1846/commits/6bdd9c6e88031663ffb040c13e65ad4339fb79af when I changed the typehint for dm->clear() to string I couldn't provide the $user object as before so I provided the class but that made the uow to clear the objects used later in the ->contains checks. Providing an invalid string value mimics the behavior before the type hints where added.

@alcaeus this is ready for review :+1:

Updated after review & enabled the CS rules you mentioned above.

The activated CS rules run on lib and tests. The output is huge.

Unfortunately phpcs adds invalid parameter type hints on inherited methods from vendor packages, which lack type hints.

Disabled the CS rules for type hinting.

Before merging I can do a rebase to get rid of all those horrid commit messages.

Yeah, go ahead and give this a rebase - once the build is stable again I'd like to get this merged 🎉

Done.

Thanks @caciobanu! 🎖

Glad to help!


[ZEPPELIN-5982] Merge flink-scala-parent module into flink-scala-2.12

What is this PR for?
Merge flink-scala-parent module into flink-scala-2.12 to simplify the project module structure.
Currently, Zeppelin supports Flink 1.15~1.17, these versions of Flink only support Scala 2.12(specifically, 2.12.7), and the Flink community decided to make the project scala-free instead of supporting new versions of Scala in the future;
What type of PR is it?
Improvement
Todos

[ ] - Task

What is the Jira issue?
ZEPPELIN-5982
How should this be tested?
Pass GA
Screenshots (if appropriate)
Questions:

Does the license files need to update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes, updated the docs correspondingly

cc @huage1994

As you noticed, we selected the current structure as we should support multiple Scala versions for Flink.

Currently, Zeppelin supports Flink 1.15~1.17, these versions of Flink only support Scala 2.12(specifically, 2.12.7), and the Flink community decided to make the project scala-free instead of supporting new versions of Scala in the future;

How do you know they support Scala 2.13 or 3 in the future then?

@jongyoul Flink community decided to remove Scala, so there is no Scala 2.13/3 support in the future.
The detailed discussion occurred at FLINK-13414
The vote-passed proposal FLIP-265 Deprecate and remove Scala API support

@pan3793 Thank you for the information. I read and understood the situation.

@pan3793 Thank you for the information. I read and understood the situation.


Add more Vec/slice-like methods to maps and sets

impl<K, V, S> IndexMap<K, V, S> {
    pub fn truncate(&mut self, len: usize);
    pub fn split_off(&mut self, at: usize) -> Self where S: Clone;
    pub fn first(&self) -> Option<(&K, &V)>;
    pub fn first_mut(&mut self) -> Option<(&mut K, &mut V)>;
    pub fn last(&self) -> Option<(&K, &V)>;
    pub fn last_mut(&mut self) -> Option<(&mut K, &mut V)>;
    pub fn swap_indices(&mut self, a: usize, b: usize);
}

impl<T, S> IndexSet<T, S> {
    pub fn truncate(&mut self, len: usize);
    pub fn split_off(&mut self, at: usize) -> Self where S: Clone;
    pub fn first(&self) -> Option<&T>;
    pub fn last(&self) -> Option<&T>;
    pub fn swap_indices(&mut self, a: usize, b: usize);
}

I would prefer &K instead of &mut K in IndexMap::first_mut and
last_mut, but this is consistent with the existing get_index_mut.

get_index_mut seems to be an oversight. Mutable key access is supposedly hidden away in the trait MutableKeys and I think it seems ok to continue that.

OK, I added more docs for the public methods.
At some point we should probably go for #![deny(missing_docs)], because there are a lot more missing, but I don't want to force that into this PR.

Oh, I switched to &K too -- force-pushed to split up that commit.


SMTP fails when password contains octothorpe ("#") character

Notify version: 1.0.4

Current Behavior: When attempting to use SMTP, I receive the following error:
[ERR] failed to send smtp notification for id: email : parse "smtp://test@example.com:xxxxx": invalid port ":xxxxx" after host
(output has been sanitized) The "xxxxx" is the first half of the password for the mailserver. It is terminated where an octothorpe ("#") appears in the password.  I have attempted to escape the octothorpe with a backslash, as well as enclosing the password in either single or double quotes. All attempts generate the same error.

Expected Behavior: The SMTP functionality should accept passwords verbatim without attempting to interpret any characters as anything other than password characters.

Steps To Reproduce:

Configure notify to attempt to use SMTP with a password that contains an octothorpe ("#")
Run notify
See error

@ossumpossum thanks for reporting this, now fixed in the latest release.


When escape picker, brackets pasted with Pandoc format

For pasting citation key in a document I use Pandoc Quick copy format with the selected option "Surround Pandoc citations with brackets". It functions perfectly. However, when I call a picker to add citation key and change my mind so I press escape to cancel adding the citation key. The picker is canceled but again the brackets are pasted [ ].
Report ID: 3KMN3YXF
Can you make it when I escape the citation picker the brackets not to be pasted.
Thank you!

:robot: this is your friendly neighborhood build bot announcing test build 4938 ("fixes #819").

The picker does not use that preference; CAYW and quick-export are (until #765 is resolved) distinct.
4938 should fix your problem, please try it out.

4938 solves the issue. Thanks!

Wow, that was fast :)

Extremely agile development :)
Sent with GitHawk


Consent is not shown for the requested claims in Request object flow

Steps to reproduce:

Configure some claims under service provider claim configs.
Make a authorization code flow or implicit flow.
You will get consent for the claims requested under service provider.
Add the claims that are requested via request object under claim config.
Try request object flow.

Now you won't get consent for the claims that are requested via request object.

If you check the id_token obtained for request object flow, it won't have the claims that are requested via request object

This breaks the request object flow

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Prevent DynamicMap from running callback on initialization?

TLDR: What is the best way to use dynamic maps when the requisite data is not yet available? This seems like a common need for dynamic plotting (e.g. I need dynamic plotting for the displaying in real-time the training/validation loss for machine learning models).
Right now, dmap = hv.DynamicMap(update_fn, ...) calls update_fn, which is problematic if there is no data to plot. What should update_fn return if it can't plot anything?

Here's an example that mirrors the problem I'm facing:
I want to generate a dynamic plot of two functions, plotting 10 samples each at a time:

squared x**2 for x in [1, 10)
cubed x**3 for x in [1, 10)
squared x**2 for x in [10, 20)
cubed x**3 for x in [10, 20)

The data is generated in an object, which must be retrieved inside update_fn. Since this example snippet assumes a notebook, I'll mimic this with a global var in another cell.
In [0]:
import time
import holoviews as hv
import holoviews.streams as hvstrm
hv.extension("bokeh")

In [1]:
%%opts Curve {+framewise} [width=1200 height=600] (line_width=3)

def update_fn():

    # PROBLEM 1
    global points  # points = {"xsq":[...], "ysq":[...], "xcu":[...], "ycu":[...]}

    # PROBLEM 2
    if (not points["xsq"]) and (not points["xcu"]):
        disp = hv.Curve(([0], [0]), kdims=["x0"], vdims=["y0"])
        return disp

    # Display squared (sq)
    if(points["xsq"]):
        dispsq = hv.Curve((points["xsq"], points["ysq"]), kdims=["x"], vdims=["squared"])
        dispsq.redim.range(x=(0, points["xsq"][-1]), squared=(0, points["ysq"][-1]))
        disp = dispsq

    # Display cubed (cu)
    if(points["xcu"]):
        dispcu = hv.Curve((points["xcu"], points["ycu"]), kdims=["x"], vdims=["cubed"])
        dispcu.redim.range(x=(0, points["xcu"][-1]), squared=(0, points["ycu"][-1]))
        disp *= dispcu

    return disp

dmap = hv.DynamicMap(update_fn, streams=[hvstrm.Stream.define("Dummy")()]);
dmap

In [2]:
points = {"xsq":[], "ysq":[], "xcu":[], "ycu":[]}  # Declaration line

for n in range (0, 2):

    # Squared
    for x in range(0, 10):
        x += 10*n
        points["xsq"].append(x)
        points["ysq"].append(x**2)
        dmap.event()
        time.sleep(0.5)

    # Cubed
    for x in range(0, 10):
        x += 10*n
        points["xcu"].append(x)
        points["ycu"].append(x**3)
        dmap.event()
        time.sleep(0.5)

PROBLEM 1 occurs because update_fn is called upon creation of the DynamicMap, before the points have been initialized:
Out [1]:
NameError: name 'points' is not defined

But, even if points is defined (declaration line moved to cell 1), I run into PROBLEM 2. This would seem like an workable (albeit hacky) way of displaying an empty plot before data is available. But this still runs into issues:
Out [2]:
/usr/local/miniconda3/lib/python3.6/site-packages/bokeh/models/sources.py:91: BokehUserWarning: ColumnDataSource's columns must be of the same length.
Current lengths: ('squared', 2), ('x', 2), ('x0', 1), ('y0', 1)
  "Current lengths: %s" % ", ".join(sorted(str((k, len(v))) for k, v in data.items())), BokehUserWarning))
/usr/local/miniconda3/lib/python3.6/site-packages/bokeh/models/sources.py:91: BokehUserWarning: ColumnDataSource's columns must be of the same length.
Current lengths: ('squared', 3), ('x', 3), ('x0', 1), ('y0', 1)
  "Current lengths: %s" % ", ".join(sorted(str((k, len(v))) for k, v in data.items())), BokehUserWarning))
/usr/local/miniconda3/lib/python3.6/site-packages/bokeh/models/sources.py:91: BokehUserWarning: ColumnDataSource's columns must be of the same length.
Current lengths: ('squared', 4), ('x', 4), ('x0', 1), ('y0', 1)
  "Current lengths: %s" % ", ".join(sorted(str((k, len(v))) for k, v in data.items())), BokehUserWarning))
...
/usr/local/miniconda3/lib/python3.6/site-packages/bokeh/models/sources.py:91: BokehUserWarning: ColumnDataSource's columns must be of the same length.
Current lengths: ('squared', 10), ('x', 10), ('x0', 1), ('y0', 1)
  "Current lengths: %s" % ", ".join(sorted(str((k, len(v))) for k, v in data.items())), BokehUserWarning))
/usr/local/miniconda3/lib/python3.6/site-packages/bokeh/models/sources.py:91: BokehUserWarning: ColumnDataSource's columns must be of the same length.
Current lengths: ('squared', 10), ('x', 11), ('x0', 1), ('y0', 1)
  "Current lengths: %s" % ", ".join(sorted(str((k, len(v))) for k, v in data.items())), BokehUserWarning))
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-3-cc0b44e54a4e> in <module>()
     14         points["xcu"].append(x)
     15         points["ycu"].append(x**3)
---> 16         dmap.event()
     17         time.sleep(0.5)

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/core/spaces.py in event(self, **kwargs)
    811             stream.update(**rkwargs)
    812
--> 813         Stream.trigger(self.streams)
    814
    815     def _style(self, retval):

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/streams.py in trigger(cls, streams)
    146         with triggering_streams(streams):
    147             for subscriber in subscribers:
--> 148                 subscriber(**dict(union))
    149
    150         for stream in streams:

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/plotting/plot.py in refresh(self, **kwargs)
    505         # Update if not top-level, batched or an ElementPlot
    506         if not self.top_level or isinstance(self, GenericElementPlot):
--> 507             self.update(stream_key)
    508
    509         if self.comm is not None and self.top_level:

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/plotting/plot.py in update(self, key)
    484         if len(self) == 1 and key == 0 and not self.drawn:
    485             return self.initialize_plot()
--> 486         item = self.__getitem__(key)
    487         self.traverse(lambda x: setattr(x, '_updated', True))
    488         return item

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/plotting/plot.py in __getitem__(self, frame)
    222         if not isinstance(frame, tuple):
    223             frame = self.keys[frame]
--> 224         self.update_frame(frame)
    225         return self.state
    226

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/plotting/bokeh/element.py in update_frame(self, key, ranges, plot, element, empty)
    863         plot = self.handles['plot']
    864         if not self.overlaid:
--> 865             self._update_ranges(style_element, ranges)
    866             self._update_plot(key, plot, style_element)
    867

/usr/local/miniconda3/lib/python3.6/site-packages/holoviews/plotting/bokeh/element.py in _update_ranges(self, element, ranges)
    549         l, b, r, t = None, None, None, None
    550         if any(isinstance(r, (Range1d, DataRange1d)) for r in [x_range, y_range]):
--> 551             l, b, r, t = self.get_extents(element, ranges)
    552             if self.invert_axes:
    553                 l, b, r, t = b, l, t, r

ValueError: not enough values to unpack (expected 4, got 0)

@nikhilxb There are multiple options here but I may have to clarify what exactly you're trying to achieve a little bit. As far as I can tell this achieves what you want:
%%opts Curve {+framewise} [width=800 height=600] (line_width=3)

points = {"xsq":[], "ysq":[], "xcu":[], "ycu":[]}  # Declaration line

def update_fn():
    global points
    dispsq = hv.Curve((points["xsq"], points["ysq"]), kdims=["x"], vdims=["squared"])
    dispcu = hv.Curve((points["xcu"], points["ycu"]), kdims=["x"], vdims=["cubed"])
    return dispsq * dispcu

dmap = hv.DynamicMap(update_fn, streams=[hv.streams.Stream.define("Dummy")()]);
dmap

And then in another cell:

for n in range (0, 2):
# Squared
for x in range(0, 10):
x += 10*n
points["xsq"].append(x)
points["ysq"].append(x**2)
dmap.event()
time.sleep(0.5)
# Cubed
for x in range(0, 10):
    x += 10*n
    points["xcu"].append(x)
    points["ycu"].append(x**3)
    dmap.event()
    time.sleep(0.5)

Maybe I'm misunderstanding what you are trying to achieve however. Secondly here's several tips:

* A DynamicMap callback should generally always return the same number and types of Elements.
* Most Elements allow declaring empty data with an empty list, e.g. ``hv.Curve([], , kdims=["x"], vdims=["cubed"])``

I think the main issue you ran into was the fact you variously returned a single Element or multiple Elements. Let me know if I've misunderstood your problem or the solution I've provided does not address your needs. It's likely that we need to make this requirement clearer in our documentation. That said I have plans to eventually allow dynamically adding or removing new Elements in a callback but that probably won't happen before 2.0.

@philippjfr Your solution worked for me. Great tips -- exactly the 2 things I wasn't getting. Yes, I think more documentation about the requirements about the DynamicMap in particular would be helpful. Thanks!

@philippjfr it sounds like I have a similar issue but I'm not sure whether this applies, let me know if I need to make a new issue instead of diluting this one.
I have a dynamic number of columns in my dataframe depending on what the user wants to see grouped (basically sql-like group-by clauses), and one boolean value per potential group-by colunm:
dmap = hv.DynamicMap(make_insight_curves, kdims=['group_name', 'group_resultCode'])
dmap.redim.values(group_name=(True, False)).redim.values(group_resultCode=(True, False))

now this function make_insight_curves gives one or more hv.Curve objects (one per column in the dataframe), nested in an hv.Overlay (I've also tried ndoverlay as per your comment, but this didn't fix it)
From your comment I understand that returning a variable amount of elements doesn't work with dynamicmaps. Is there a different kind of element that could do a similar job?

From your comment I understand that returning a variable amount of elements doesn't work with dynamicmaps. Is there a different kind of element that could do a similar job?

Returning a variable number is now allowed.


balancedconsumer fails to reown partitions in case of network failures

Hello,
We experience from time to time problems with balanced consumer: in case of network failures, some partitions left unconsumed.
Here is an example, we are running two consumers in a group for a topic with 6 partitions. Normally each takes care of 3 partitions. In this gist:
https://gist.github.com/tigran-a/c93ca879df25624120d09b15e5019952
you can see, that after connection issues, the consumer "lost" one partition.
The other consumer "lost" 2 partitions.
If I stop both consumers and start them again, all partitions are used.
Is there any reasonable workaround for that?
E.g. periodically try to refresh/reown unowned partitions or so?
PyKafka version:  2.4.0
Kafka version: <IP_ADDRESS>
Thanks for any help!

Thanks for filing this @tigran-a. We've seen it periodically at Parse.ly as well, and in those cases we simply restart the consumers. I'm not sure yet about an automated way to address this - suggestions are definitely welcome.

Yes, but it happened close to 1 am, so... it affected the system till the morning where we could fix it.
I had to mention, it happens independently of whether I use librdkafka backend or not.
I think it is important issue. Do you have any ideas of the reason that provokes such behavior? Where the ownership of the partition is stored?
Thanks!

This logic seems one likely source of this type of issue. It might pay to add some better retry logic around NoNodeError.

But when the stop() is called? And why if I completely stop all the consumers, and start them again, the owned partition is released (in a first glance, if we have this kind of ghost-owner, then restarting consumers should not help) ?

stop() might not be getting called in your case, though I do think it's still a likely source of this type of issue. Here's the other place where the BalancedConsumer gives up owned partitions. The network failure scenarios possible during this logic make it really complicated to reason about. What if multiple rebalances are triggered sequentially as a result of connection loss and the consumer is unable to connect to ZooKeeper to release its partitions?

This could also be related to #701 (cc @tanaysoni), it may be worth reevaluating.

@tigran-a @emmett9001 I tried sporadically stopping Kafka brokers & Zookeeper on my local in order to simulate network failures, but I'm unable to reproduce this error on the master branch. The rebalance calls triggered are able to re-own all partitions among group's consumers, without leaving out any partition. With v2.4.0, I couldn't get rebalance itself to work.
@emmett9001 On a side note, I'm curious if going ahead we'd be focusing on Zookeeper based offsets. From what I have read, the Kafka based offsets scale better.

@tanaysoni Thanks for the info, it sounds like it's reasonable to close this. You're correct that newer versions of Kafka allow Kafka-based offset storage and that it's preferable to using ZooKeeper under many circumstances, but we do still need to support ZK offsets for backward compatibility. In fact, we're still using Kafka 0.8.2 at @parsely, so fixes to this system are very useful to us.


parseQueryString doesn't support basic Arrays

Method
parseQueryString
Fixture
foo=bar&hello%5B%5D=world&hello%5B%5D=mars&hello%5B%5D=pluto

Expected Result
{
  foo: "bar",
  "hello[]": [ "world", "mars", "pluto" ]
}

Actual Result
{
  foo: "bar",
  "hello[]": "world"
}

Basic array (multiple key-value to key-array(values)) is not supported and data is lost.

Fixes are up on origin/next


Sync native library as submodule

Task/Issue URL: https://app.asana.com/0/488551667048375/1203781131138682/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2737

PR #2740

PR #2744   👈

This comment was auto-generated by Graphite.

This is ready for review @aitorvs, I need to take a look what's the issue with Flank so Android tests are executed.


Make legend and triad maintain a 1:1 aspect ratio

Is your feature request related to a problem?
This come from this SRE issue. Terry from LBL would like the triad and legend to maintain 1:1 aspect ratio like the plot when the viewer window is resized.
Additional context

We observed...

triad skew appears to follow window aspect ratio, not object.
triad doesn't honor object perspective
Its conceivable that because triad is part of the annotations layer, it isn't being controlled by the plotted object's view controls.

We can pretty easily change the behavior of objects like the triad so that they maintain a 1:1 aspect ratio, but this also means that they behave more like the axis actors in general. Most notably, this means that these objects can go out of view.
I've created a simple video that demonstrates these behaviors. In this video, the triad has been altered to maintain a 1:1 aspect ratio  by setting its coordinate system to world (like the axis actors). The legend has not been altered here, meaning that it's still using the viewport coordinate system. You can see the difference in behavior pretty easily.
NOTE: the position of the triad in this video is easily adjustable. I just chose something for the demo.
https://user-images.githubusercontent.com/11658578/115591043-85db6f00-a286-11eb-9502-f0c41f101f7f.mov
Is this an acceptable tradeoff?

I originally thought it wouldn’t work well, but it actually is quite reasonable. The only concern is if the user zooms in that the triad would go off screen and you wouldn’t see it. The bounding box has the same issue, but it seems like it’s part of the object and therefore behaves as I expect it would.

I think there's also a ticket somewhere requesting the ability to change the position of the triad and legend. If people really wanted to keep the triad in view after zooming in, they could use that (future) feature to make it happen.

I thought the purpose of the triad was to give some spatial perspective regardless of the zoom/pan of the plot.
If it moves with zoom and pan and can go offscreen, what's the point?

I thought the purpose of the triad was to give some spatial perspective regardless of the zoom/pan of the plot.

I haven't really thought of the triad in that manner, but maybe I'm in the minority here? I always just assumed it was for directional context only.
Should I move this out of reviewed so that we can discuss this in an upcoming meeting?

Any way to force them to maintain their position in the viewport / prevent them moving offscreen when pan or zoomed?

Yes, sounds like we should move out of reviewed and re-discuss.

Any way to force them to maintain their position in the viewport / prevent them moving offscreen when pan or zoomed?

I tried a couple of things earlier, but they all had serious issues. I might be able to translate coordinates from the viewport to the world. I'll give that a try once I finish up this other branch I'm working on.

My efforts to keep the triad in view have failed so far. I'll put a pause on further efforts until we've talked about this as a group.

The triad should be in the corner. It should also have the perspective/parallel mode match the object. I believe it is always in parallel projection mode.

We might want to rethink our ancient triad technology.

The triad should be in the corner. It should also have the perspective/parallel mode match the object. I believe it is always in parallel projection mode.

Do you mean the triad should maintain its position in the screen (as it currently does) but also maintain a 1:1 aspect ratio (which it currently does not do)?

Yes, it should maintain its position and maintain a 1:1 aspect ratio. If this ends up taking too much effort, you can unassign it.

There is a new method for vtkCamera called "SetExplicitAspectRatio", which might help here. The definition is a bit vague, though. We don't currently have access to this, so I'm assuming it's in a newer release.

We decided that this is more effort than it's currently worth.


feat: add postprocessimportmap

TODO:

~Change overrides to spread operator~
~Implement scopes~
~Implement deletes~

was just reading some parts of the spec again... and I saw this
https://github.com/WICG/import-maps/blob/master/spec.md#merging-import-maps
maybe we should "just" support this + delete? e.g. not "deep" merging of scopes? would certainly make it simpler as it would just 2 spread merges... + logic for deletion...
but again maybe people need more control when creating an import map then when merging 2...

So following this
Our config in package.json would look like:
  importmap: {
    deletes: ['a', 'b'],
    overrides: {
      'std:kv-storage': ['std:kv-storage', '/node_modules/kvs-polyfill/index.mjs'],
    },
    merge: {
      'c': 'foo'
    }
  }

?

  "importMap": {
    "deletes": {
        "imports": ["a", "b"],
        // "scopes" and "scopeImports" is also possible
    },

    "overrides": {
       "imports": {
          "std:kv-storage": ["std:kv-storage", "/node_modules/kvs-polyfill/index.mjs"],
          "c": "foo"
       }
       // "scopes" is also possible
    },
  }

I would say importMap as other package.json keys like devDependencies are also camelCased.
and "merge" is not needed as it's basically the same as "overrides"? or we should call overrides => mergeReplace or merge or mergeWithOverride, ...?

Why not?
  "importMap": {
    "deletes": ["a", "a/", "b"]
    },

    "overrides": {
      "std:kv-storage": ["std:kv-storage", "/node_modules/kvs-polyfill/index.mjs"],
      "c": "foo",
      "c/": "foo/"
    },
  }

how can you delete or override scopes then?
for example deletion: https://github.com/open-wc/open-wc/pull/499/files#diff-2e109ad19bb252e6d38876cfe42de032R134
or overriding scopes: https://github.com/open-wc/open-wc/pull/499/files#diff-2e109ad19bb252e6d38876cfe42de032R33

@daKmoR PTAL, I think that should be correct now

@thepassle uhhh that looks really nice 🤗 (sorry for the delay I somehow missed it 🙈 )
just one thing - I think we should call it importMap in the package.json config (to stay consistent with all the other camelCased properties)

thxxxx 🤗
I will do the importMap change in the feat/importMapCreate branch


VDD was not declared in this scope

Please bare with me, i'm new to arduino
I'm attempting to build the Mailbox_Guard_Sensor and I'm getting the following error:
Arduino: 1.8.19 (Mac OS X), Board: "ESP32 Dev Module, Disabled, Disabled, Default 4MB with spiffs (1.2MB APP/1.5MB SPIFFS), 240MHz (WiFi/BT), QIO, 80MHz, 4MB (32Mb), 115200, Core 1, Core 1, Debug, Disabled"

/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino: In function 'void setup()':
Mailbox_Guard_Sensor:29:19: error: 'VDD' was not declared in this scope
   analogReference(VDD);
                   ^~~
Mailbox_Guard_Sensor:29:3: error: 'analogReference' was not declared in this scope
   analogReference(VDD);
   ^~~~~~~~~~~~~~~
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino:29:3: note: suggested alternative: 'analogGetChannel'
   analogReference(VDD);
   ^~~~~~~~~~~~~~~
   analogGetChannel
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino: In function 'void loop()':
Mailbox_Guard_Sensor:54:31: error: 'PIN_PB4' was not declared in this scope
   float volts = analogReadEnh(PIN_PB4, 12)*(1.1/4096)*(30+10)/10;
                               ^~~~~~~
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino:54:31: note: suggested alternative: 'PIN_DAC2'
   float volts = analogReadEnh(PIN_PB4, 12)*(1.1/4096)*(30+10)/10;
                               ^~~~~~~
                               PIN_DAC2
Mailbox_Guard_Sensor:54:17: error: 'analogReadEnh' was not declared in this scope
   float volts = analogReadEnh(PIN_PB4, 12)*(1.1/4096)*(30+10)/10;
                 ^~~~~~~~~~~~~
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino:54:17: note: suggested alternative: 'analogRead'
   float volts = analogReadEnh(PIN_PB4, 12)*(1.1/4096)*(30+10)/10;
                 ^~~~~~~~~~~~~
                 analogRead
Mailbox_Guard_Sensor:87:20: error: 'SLEEP_MODE_PWR_DOWN' was not declared in this scope
     set_sleep_mode(SLEEP_MODE_PWR_DOWN);
                    ^~~~~~~~~~~~~~~~~~~
Mailbox_Guard_Sensor:87:5: error: 'set_sleep_mode' was not declared in this scope
     set_sleep_mode(SLEEP_MODE_PWR_DOWN);
     ^~~~~~~~~~~~~~
Mailbox_Guard_Sensor:88:5: error: 'sleep_enable' was not declared in this scope
     sleep_enable();
     ^~~~~~~~~~~~
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino:88:5: note: suggested alternative: 'spiSSEnable'
     sleep_enable();
     ^~~~~~~~~~~~
     spiSSEnable
Mailbox_Guard_Sensor:89:5: error: 'sleep_mode' was not declared in this scope
     sleep_mode();  // Now enter sleep mode.
     ^~~~~~~~~~
/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino:89:5: note: suggested alternative: 'sleep'
     sleep_mode();  // Now enter sleep mode.
     ^~~~~~~~~~
     sleep
exit status 1
'VDD' was not declared in this scope

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I'm guessing it has to do with the board selected, which is currently the lora gateway board. I'm not really sure what to set it to for the universal programmer. A lot of these look like they're functions that haven't been imported in the header.
Thank you for your help.

Hi,
Select Board type "ATTiny1616 5MHz" https://github.com/PricelessToolkit/MailBoxGuard?tab=readme-ov-file#mailbox-sensor-configuration

Thank you. I'm not seeing that board in the board manager. Is there a specific one I need to install?

You need to install "megaTinyCore" library, it will add ATTiny support. So add this link to Boards Manager "http://drazzy.com/package_drazzy.com_index.json"
https://github.com/PricelessToolkit/MailBoxGuard?tab=readme-ov-file#arduino-setup-ide-20x-unsupported

Thank you for your help. I think I'm getting close to getting the code to verify in the ide. There seems to be one more exception:
Arduino: 1.8.19 (Mac OS X), Board: "ATtiny3226/3216/1626/1616/1606/826/816/806/426/416/406, ATtiny1616, 5 MHz internal, 1.8V (5 MHz or less), Disabled/Disabled, EEPROM retained, Enabled (default timer), UPDI (no reset pin), 8ms, Master or Slave (saves flash and RAM), Default (doesn't print floats, 1.4k flash use), PB0-2, PA3-5, 1-series: PC0/1 (default), On all pins, with new implementation., Disabled (recommended), No delay before window "opens""

/Users/dfrey/Development/git/PricelessToolkit/MailBoxGuard/Code/Arduino/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor/Mailbox_Guard_Sensor.ino: In function 'void loop()':
Mailbox_Guard_Sensor:87:5: error: 'set_sleep_mode' was not declared in this scope
     set_sleep_mode(SLEEP_MODE_PWR_DOWN);
     ^~~~~~~~~~~~~~
Mailbox_Guard_Sensor:88:5: error: 'sleep_enable' was not declared in this scope
     sleep_enable();
     ^~~~~~~~~~~~
Mailbox_Guard_Sensor:89:5: error: 'sleep_mode' was not declared in this scope
     sleep_mode();  // Now enter sleep mode.
     ^~~~~~~~~~
exit status 1
'set_sleep_mode' was not declared in this scope

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

I noticed that this include was commented out:
#include <avr/sleep.h>

I uncommented it and now it compiles. Not sure if I did that or not.

Just checked the code in the repo and it is commented out. Is that intended? Where does that function come from then? Am I missing an included library somewhere?

I got it working. thank you for your help.

Just checked the code in the repo and it is commented out. Is that intended? Where does that function come from then? Am I missing an included library somewhere?

Hi, I can't explain why it was commented out; it was an error on my part. I will uncomment it. Thanks for pointing it out.


IrodsAccessTicketSerializer reassigns assay on update

This is redundant as the assay field is read-only.

Ehh you know what, this approach is also fine. In the end it does the same thing but doesn't require us to override another method. Closing.


Correction for raw affiliation ChemHouse Research Group, Montpellier, France; ITAP, INRAe, Montpellier SupAgro, University of Montpellier, ChemHouse Research Group, Montpellier, France

Correction needed for raw affiliation ChemHouse Research Group, Montpellier, France; ITAP, INRAe, Montpellier SupAgro, University of Montpellier, ChemHouse Research Group, Montpellier, France
raw_affiliation_name: ChemHouse Research Group, Montpellier, France; ITAP, INRAe, Montpellier SupAgro, University of Montpellier, ChemHouse Research Group, Montpellier, France
new_rors: 03rnk6m14;051escj72;00ftatp57
previous_rors: 03rnk6m14;051escj72
works_examples: W3013407923
contact: 311ea135f20216406ce4adea565d380f:1ac0c3be97d2861993fa272f084b95f304b1 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-11-18. The new affiliations should be visible within the next 7 days.


[SPARK-30843][SQL] Fix getting of time components before 1582 year

What changes were proposed in this pull request?

Rewrite DateTimeUtils methods getHours(), getMinutes(), getSeconds(), getSecondsWithFraction(), getMilliseconds() and getMicroseconds() using Java 8 time APIs. This will automatically switch the Hour, Minute, Second and DatePart expressions on Proleptic Gregorian calendar.
Remove unused methods and constant of DateTimeUtils - to2001, YearZero , toYearZero and absoluteMicroSecond().
Remove unused value timeZone from TimeZoneAwareExpression since all expressions have been migrated to Java 8 time API, and legacy instance of TimeZone is not needed any more.
Change signatures of modified DateTimeUtils methods, and pass ZoneId instead of TimeZone. This will allow to avoid unnecessary conversions TimeZone -> String -> ZoneId.
Modify tests in DateTimeUtilsSuite and in DateExpressionsSuite to pass ZoneId instead of TimeZone. Correct the tests, to pass tested zone id instead of None.

Why are the changes needed?
The changes fix the issue of wrong results returned by the hour(), minute(), second(), date_part('millisecond', ...) and date_part('microsecond', ....), see example in SPARK-30843.
Does this PR introduce any user-facing change?
Yes. After the changes, the results of examples from SPARK-30843:
spark-sql> select hour(timestamp '0010-01-01 00:00:00');
0
spark-sql> select minute(timestamp '0010-01-01 00:00:00');
0
spark-sql> select second(timestamp '0010-01-01 00:00:00');
0
spark-sql> select date_part('milliseconds', timestamp '0010-01-01 00:00:00');
0.000
spark-sql> select date_part('microseconds', timestamp '0010-01-01 00:00:00');
0

How was this patch tested?

By existing test suites DateTimeUtilsSuite, DateExpressionsSuite and DateFunctionsSuite.
Add new tests to DateExpressionsSuite and DateTimeUtilsSuite for 10 year, like:

  input = date(10, 1, 1, 0, 0, 0, 0, zonePST)
  assert(getHours(input, zonePST) === 0)

Re-run DateTimeBenchmark using Amazon EC2.

Item
Description

Region
us-west-2 (Oregon)

Instance
r3.xlarge

AMI
ami-06f2f779464715dc5 (ubuntu/images/hvm-ssd/ubuntu-bionic-18.04-amd64-server-20190722.1)

Java
OpenJDK8/11

Test build #118483 has started for PR 27596 at commit 4759725.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23242/
Test PASSed.

Test build #118483 has finished for PR 27596 at commit 4759725.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118483/
Test PASSed.

Test build #118503 has started for PR 27596 at commit 5949128.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23258/
Test PASSed.

Test build #118503 has finished for PR 27596 at commit 5949128.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118503/
Test PASSed.

@cloud-fan @HyukjinKwon May I ask you to review this PR.

LGTM, merging to master/3.0!


fix merging calculator defaults

fixed #226

Converting to Draft, because there is still another bug

@JensWehner @baumeier  This PR is ready for reviewing


OpenWhisk with another database like Cassandra or Redis?

Can you use Cassandra or Redis instead of CouchDB for all the functionalities? If yes does anyway has steps or method to do it? I have successfully installed openwhisk locally on ubuntu 14.0 and want to use another database as the backend.
Appreciate your time and help.
Thanks and Regards.

I’m not aware of anyone having tried this yet. In principle the artifact store interface could be adapted to other data stores. In practice we’ve gone down a fair bit the couch db api. It may require some refactoring and maybe some rearchitecting.

I changed ArtifactStore from Couchdb to Mongodb in my project. I had not only to write new SPI module of ArtifactStore, but also to rewrite WhiskEntityQueries and some other codes. I'd tried to do it clearly, but it slightly ruined codebase. Because current openwhisk architecture is not suitable for any other database. You might need some understanding of openwhisk architecture and context of all queries for doing it.

@devbv We are also looking into Mongodb support. Would it be possible for you to share the fork?

Thanks @rabbah , @devbv , @chetanmeh for your comments. Sorry for the delay in my response as i just picked this up again.
One more option to changing the artifact would be to write an action that writes to another database. I think couchdb is only used to store action, default parameters, sequences, users, credentials etc. Am i  correct?
thanks again for your time.
Regards

The store implementation is pluggable. We welcome other implementations.


Create Azure DevOps MDSA training for CalHFA

I am closing this issue, will create a replacement in the dse-internal-tracker repo to match the others being created.


Change "slave-owner" to "enslaver" on Tabulator

From email to Lin on 5/12:
Gabrielle Foreman, in her article "Writing about Slavery" recommends against using "slave-owner" language and instead using "enslaver" (see here).
Thanks, Ashley -- yes, totally agree. I think we have talked about this before but perhaps never came to a point of action? There is a small side debate in the field about whether "enslaver" applies to later purchases (vs. the person who did the original enslaver), but the bottom line is that ever person who kept a person in slavery was actively an enslaver. So I agree with the change.
Thanks, and good luck with the presentation!
Lin

Moved to SmartSheets


tekton pipeline deploy task failed - can't create directory: permission denied

++ cat ./chart/base/Chart.yaml
++ yq r - name

export CHART_NAME=base
CHART_NAME=base
CHART_NAME: base
echo 'CHART_NAME: base'
[[ base != \f\o\u\r-\m\e\t\r\i\c\s-\a\p\p ]]
Renaming chart from base to four-metrics-app
echo 'Renaming chart from base to four-metrics-app'
cp -R ./chart/base ./chart/four-metrics-app
cp: can't create directory './chart/four-metrics-app': Permission denied

Someone has the same issue at ticket#131.   Can this be resolved?

There is issues with v2.7.1 deploy task: permission denied. can you please help fix it?
@triceam
@Hemankita
@seansund

@schijioke-uche  What version of OpenShift?  and does the user have admin or restricted access?

@triceam :  4.7.16
Thank you.

@triceam  - any update?

@schijioke-uche still have not been able to recreate it yet.  A few of us are trying to reproduce it

@lsteck : -  any update about fixing this bug?

@schijioke-uche FYI @triceam @csantanapr
OK, I found root cause.  GIT-CLONE step is running as  root and DEPLOY step is running as devops.
I've found 2 ways to fix on 4.7.  I need to test/verify these on 4.6 so until I can do that and push the fix to get you going you can edit the ibm-deploy-<version> (example ibm-deploy-v2-6-13) task in your  project namespace and do one of the following:

Add sudo chown -R "$(whoami)" "${CHART_ROOT}" line above the cp -R "${CHART_ROOT}/${CHART_NAME}" "${CHART_ROOT}/${APP_NAME}" line that is failing
Add

    securityContext:
       runAsUser: 10000

To the git-clone step
For example it should look like this
  steps:
    - env:
         <lines omitted>
      image: quay.io/ibmgaragecloud/alpine-git
      name: git-clone
      securityContext:
        runAsUser: 10000
      resources: {}

After testing on OCP 4.6 I believe it is best to put the securityContext on BOTH steps in deploy task (git-clone & deploy) and helm-release task(git-clone & package-helm).
TL;DR
On ocp 4.6 it looks like a random UID is selected and both steps in the task are ran as the same UID.  That is why it currently works.
On ocp 4.7 the git-clone step is running as root and the deploy and package-helm steps are running as user devops as defined in the image: quay.io/ibmgaragecloud/ibmcloud-dev

Wow 😯 Interesting find @lsteck
In OpenShift the default scc is to not run as root, did you added privilege scc to the pipeline service account ?

@lsteck
I proposed the following fix
Option 1:
Update any task that is trying to write in the directory /source that it moves the files to a new directory at the top level /source like /source/helm/
The user id in container 2 has write permissions to /source but not to /source/$gitrepo so it should work
If this doesn't work then I will have the git-clone task do a chmod -R on /source to give read and write access to anyone so any following task can write files inside the git repo folder

@schijioke-uche I fix the issue can you verify the fix using the release https://github.com/IBM/ibm-garage-tekton-tasks/releases/tag/v2.7.2


Problems on string and array

Please accept this pull request and merge it.

@thebit1701 contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


Added event color background override and opacity

Inspired by feature from Today's calendar widget.

Closing as the PR is outdated now.
@easycheese Let's create an issue and discuss what to do first. It's very hard to review such large changes...
Note: Please create new PRs in that repository:
https://github.com/andstatus/todoagenda/pulls


Media library: Hiding channels without download option

I would find it helpful if I could deselect channels that do not offer downloads. This currently applies to "ORF" and "SRF".
Currently it is only possible to filter for certain channels. To get the desired result, I would have to select all channels except the ones mentioned above. In addition, these filters are not permanent. I currently have to reset the settings every time I search, which is quite cumbersome.

As a supplement to existing feature requests:

Blacklist/filter media library entries for certain words/strings #106
Save search queries in the media library filter #303
New tab with predefined media library searches #356

Thanks for your feedback, but this is nothing I will implement in the near future.


Misc enhancements

[ ] Fix the tabbed pane to the bottom of the page
[ ] Make it resizable
[x] Explainer (more like what HexagonyColorer does; draw paths over cells and extract the command sequence)
[x] Save explained code as image (SVG)
[ ] Zoom in/out code area
[ ] Custom codel size on PNG export
[ ] Make test case separator more sane (do not require an empty line on its own for empty test case) ... or just make it more proper and use multiple input/output windows

would zoom in/out be done via scroll wheel?


The passive healthcheck not support fail_timeout?

Like nginx fail_timeout，The passive healthcheck not support it?  How to use only passive healthcheck?

locked, continued conversation in #79


Correct info

Add info as we also support Express Route for two Vnets.

@Danzhang-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Danzhang-msft - thanks for the update. Unfortunately it looks like there's a merge conflict. Do you know how to resolve? If not we can take your update and add it to another PR.

I took these changes, and put them inside PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/83673 to avoid the conflict. Thanks for contribution @Danzhang-msft! Please feel free to submit another arbitrary change to the doc so that you're added as a contributor :)

#please-close


Can we modify this code so that we can record calls on Android 10+ ?

From Android 10+, fake dl_open is blocked by Google policy. I tried a lot, but I couldn't make it. Sorry

From Android 10+, fake dl_open is blocked by Google policy. I tried a lot, but I couldn't make it. Sorry

I see, thanks for your reply.


Helm chart?

I have been using excalidraw for the last few months and have been loving it!  I am getting ready to move my installation from a local docker deployment to a permanent k8s cluster deployment.  I have been looking for a helm chart but have not found one.  Am I missing a helm chart somewhere?  If not I will start working on one and contribute it back.

Can you show an example of how that looks like, how would the implementation look like, what are the use cases?

Can you show an example of how that looks like, how would the implementation look like, what are the use cases?

Examples of how this would work:

(most simple)

Deploying excalidraw with all of the helm chart defaults will result in getting a NodePort and ecalidraw will be reachable via the port on any of the k8s nodes

(most ideal)

With some additional inputs from the user excalidraw can be reachable with an FQDN and protected with an SSL certificate
Implementation
To start I would recommend that we host the helm chart in a helm subdirectory of this project.  If there is interest I would recommend that the helm chart get published to an official chart repository so that ecalidraw could simply be installed with helm install excalidraw.
Use Cases
I don't see the use cases being any different from somebody that is currently running excalidraw in docker.
Here is a work in progress of what I am thinking:
https://github.com/excalidraw/excalidraw/pull/2705

Examples of how this would work:

(most simple)

Deploying excalidraw with all of the helm chart defaults will result in getting a NodePort and ecalidraw will be reachable via the port on any of the k8s nodes

(most ideal)

With some additional inputs from the user excalidraw can be reachable with an FQDN and protected with an SSL certificate
Implementation
To start I would recommend that we host the helm chart in a helm subdirectory of this project.  If there is interest I would recommend that the helm chart get published to an official chart repository so that ecalidraw could simply be installed with helm install excalidraw.
Use Cases
I don't see the use cases being any different from somebody that is currently running excalidraw in docker.
Here is a work in progress of what I am thinking:
https://github.com/excalidraw/excalidraw/pull/2705

docker-postfix is a pretty good example of what I would like to see here at excalidraw.
Simple one line helm install:
https://github.com/bokysan/docker-postfix#tldr
helm sub dir:
https://github.com/bokysan/docker-postfix/tree/master/helm/mail

docker-postfix is a pretty good example of what I would like to see here at excalidraw.
Simple one line helm install:
https://github.com/bokysan/docker-postfix#tldr
helm sub dir:
https://github.com/bokysan/docker-postfix/tree/master/helm/mail

Oh, ok. I had no idea what we were talking about here, not being Docker user myself. I'll forward this to @kbariotis :smile:

Oh, ok. I had no idea what we were talking about here, not being Docker user myself. I'll forward this to @kbariotis :smile:

Where do we stand?

I can do that, I think, if nobody's working on it. I can't promise that it's going to be fast though

I hacked together a rudimentary helm chart a while ago, maybe that can server as a starting point?
https://github.com/johanneskastl/excalidraw-helm-chart/
Proper docker tags would be a nice first step, latest makes a lousy tag in a helm chart...

So, I used git tags for creating versioned containers, it's not perfect yet, but I have something like that
And it what the initial chart for 0.9.0 looks like that

Those links will redirect to my Gitea instance

It seems pretty easy to do the same for other versions, but there are two things that I'm not sure about. I found this repo: https://github.com/excalidraw/excalidraw-room
If somebody could answer, it would be great

Is it possible to add to a self-hosted instance. (In the docker image readme, I found a note that it doesn't work, but when running the app in docker-compose, I remember seeing something about adding a "room backend")

If it's possible, starting from what version it can be done?

And the last one. Does excalidraw needs to store anything, or it's stateless?

Hello,
Just to say that we're writing an helm chart here too.
Will be placed here https://gitlab.com/vigigloo/tools/excalidraw
(And will be released with a terraform module too)
I see that none of your charts are deploying room server.
I see that room server is currently not supporting redis backend (It should be easy to MR).
I've created a ticket to ask excalidraw team to publish tags.
Excalidraw seems to be stateless, using local storage of browsers and sync it via room server.


Add dev container

Add a docker dev container config, and update readme to explain how to use in VSCode

Okay after a small mishap (haven't rebased via command line very much, back when I used to do rebase I would squash commits and do in tortoise git), I think I've addressed both your comments

Feel free to merge! I would vote for squash, but if you want to preserve the 11 commits here (for that dockerfile maybe?) feel free to rebase too

Feel free to merge! I would vote for squash, but if you want to preserve the 11 commits here (for that dockerfile maybe?) feel free to rebase too

Nah dockerfile is being preserved in: https://github.com/acteng/atip-docker/commit/8bada741446aa524e9fe33c33a65a603abb4e3f7 so happy to squash


launch multi-gpu triton server  Got Port already in use

when I launch multi-gpu triton server
python scripts/launch_triton_server.py --world_size 4 --model_repo  /path/to/model/repo
Got port in use error
21 09:27:15.346696872     166 chttp2_server.cc:1080]      UNKNOWN:No address added out of total 1 resolved for '<IP_ADDRESS>:8001' {created_time:"2023-12-21T09:27:15.346653273+00:00", children:[UNKNOWN:Failed to add any wildcard listeners {created_time:"2023-12-21T09:27:15.346644896+00:00", children:[UNKNOWN:Address family not supported by protocol {created_time:"2023-12-21T09:27:15.346609255+00:00", errno:97, os_error:"Address family not supported by protocol", syscall:"socket", target_address:"[::]:8001"}, UNKNOWN:Unable to configure socket {created_time:"2023-12-21T09:27:15.346637691+00:00", fd:113, children:[UNKNOWN:Address already in use {syscall:"bind", os_error:"Address already in use", errno:98, created_time:"2023-12-21T09:27:15.346634796+00:00"}]}]}]}
E1221 09:27:15.346824 166 main.cc:244] failed to start GRPC service: Unavailable - Socket '<IP_ADDRESS>:8001' already in use
E1221 09:27:15.347306746     165 chttp2_server.cc:1080]      UNKNOWN:No address added out of total 1 resolved for '<IP_ADDRESS>:8001' {created_time:"2023-12-21T09:27:15.34725917+00:00", children:[UNKNOWN:Failed to add any wildcard listeners {created_time:"2023-12-21T09:27:15.347249218+00:00", children:[UNKNOWN:Address family not supported by protocol {created_time:"2023-12-21T09:27:15.347199869+00:00", errno:97, os_error:"Address family not supported by protocol", syscall:"socket", target_address:"[::]:8001"}, UNKNOWN:Unable to configure socket {fd:113, created_time:"2023-12-21T09:27:15.347237464+00:00", children:[UNKNOWN:Address already in use {created_time:"2023-12-21T09:27:15.347234311+00:00", errno:98, os_error:"Address already in use", syscall:"bind"}]}]}]}
E1221 09:27:15.347460 165 main.cc:244] failed to start GRPC service: Unavailable - Socket '<IP_ADDRESS>:8001' already in use

Could you make sure there is not other process running the tritonserver on the smae node? If you still encounter such issue, please share the config.pbtxt.

I ran into the same issue, no other process is running on the the same node. Not sure if multiple server instances across different GPUs are trying to access the same port?

def get_cmd(world_size, tritonserver, grpc_port, http_port, metrics_port,
            model_repo, log, log_file):
    cmd = ['mpirun', '--allow-run-as-root']
    for i in range(world_size):
        cmd += ['-n', '1', tritonserver]
        if log and (i == 0):
            cmd += ['--log-verbose=3', f'--log-file={log_file}']
        cmd += [
            f'--grpc-port={grpc_port}', f'--http-port={http_port}',
            f'--metrics-port={metrics_port}',
            f'--model-repository={model_repo}',
            '--disable-auto-complete-config',
            f'--backend-config=python,shm-region-prefix-name=prefix{i}_', ':'
        ]
    return cmd
    ```
    is seems every process will started with the same grpc_port, http_prot, metrics_port while world_size > 1, may be you can and
    `--allow-grpc=false --allow-http=false --allow-metrics=false` option to the process which rank is greater than zero.

Could you please share more detailed reproducing steps and logs? We are running multi-GPU tests and did not see such issue. Thanks.

i think it is because the tensorrt-llm backend has a infinite loop in the ModelInstanceState::ModelInstanceState like this
  if (getCommWorldRank() != 0)
    {
        while (true)
        {
        }
    }
}

This loop appears to be present to block execution on ranks other than rank 0, potentially causing subsequent execution of the server to be halted. It seems that only the first rank node creates the HTTP and gRPC servers as expected.
it's the reason why you don't got the error while the configure is ok.
but how other server shutdown gracefully? there isn't a way to stop the infinite loop. @kaiyux

With no change to any code this issue disappeared briefly but its back, not sure what the root cause is yet.
I was thinking the same as @sydnash; the different processes are all starting the server with the same port but clearly its working for everyone else.


doctor Prescription

I have implemented the doctor Prescription can U once check and merge it

I cannot find a linked issue with this PR! Can you open an issue first and then tell what are you trying to implement?

I cannot find a linked issue with this PR! Can you open an issue first and then tell what are you trying to implement?
Also, I don't know why you are committing the node modules?

Ok I will raise a new issue


ModuleNotFoundError

[root@gpu-4 keras]# nnictl create --config config.yml
INFO: expand searchSpacePath: search_space.json to /home/sunyan/ULM/transfomer/keras/search_space.json
INFO: expand codeDir: . to /home/sunyan/ULM/transfomer/keras/.
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'nni.hyperopt_tuner'; 'nni' is not a package
Traceback (most recent call last):
  File "/root/anaconda3/bin/nnictl", line 10, in <module>
    sys.exit(parse_args())
  File "/root/anaconda3/lib/python3.6/site-packages/nni_cmd/nnictl.py", line 198, in parse_args
    args.func(args)
  File "/root/anaconda3/lib/python3.6/site-packages/nni_cmd/launcher.py", line 535, in create_experiment
    launch_experiment(args, experiment_config, 'new', config_file_name)
  File "/root/anaconda3/lib/python3.6/site-packages/nni_cmd/launcher.py", line 351, in launch_experiment
    check_call([sys.executable, '-c', 'import %s'%(module_name)])
  File "/root/anaconda3/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/root/anaconda3/bin/python', '-c', 'import nni.hyperopt_tuner.hyperopt_tuner']' returned non-zero exit status 1.
[root@gpu-4 keras]# pip show nni
Name: nni
Version: 0.7
Summary: Neural Network Intelligence package
Home-page: https://github.com/Microsoft/nni
Author: Microsoft NNI team
Author-email<EMAIL_ADDRESS>License: MIT
Location: /root/anaconda3/lib/python3.6/site-packages
Requires: requests, PythonWebHDFS, json-tricks, colorama, schema, astor, numpy, hyperopt, coverage, ruamel.yaml, scipy, psutil
Required-by:

pip installed nni but not found

@SunYanCN  It seems that you did not install NNI in right way.
# uninstall NNI first
pip uninstall nni
# if you install nni from the source code, Makefile can help you to uninstall NNI
make uninstall && make clean

# make sure your pip is in your conda environment [e.g. /root/anaconda3/bin/pip ]
which pip

# install NNI from source code or pip source

# pip source
pip uninstall nni

# source code
make easy-install

It seems that you install conda in your server, so you have to specific the command path in your config file.
trial:
  command: /root/anaconda3/bin/python3 FileName.py
  codeDir: .
  gpuNum: 1

@SunYanCN - had you tried to config your command path as @leelaylay suggested? does it work for you know?

closing it for now. @SunYanCN - feel free to reopen the issue if you are still having the problem on your side.


Chinese translation is not fully covered

Description
I noticed that some menus and setting options do not support simplified Chinese during use, but this does not affect normal use. If you are too busy, I can participate in part of the Chinese translation work by submitting PR, but I need to participate in contributing documents
DBeaver Version
<IP_ADDRESS>409011755
Operating System
Manjaro 24.1.2 Xahea
Database and driver
No response
Steps to reproduce
No response
Additional context
No response

DBeaver application translated to Chinese by DBeaver community. However, we're adding new features and change something every day. So, new untranslated places appears.
You can help by providing PR with translation of those places. We would appreciate that.
Here's the guide about that https://github.com/dbeaver/dbeaver/wiki/Localization

DBeaver application translated to Chinese by DBeaver community. However, we're adding new features and change something every day. So, new untranslated places appears.DBeaver 应用程序由 DBeaver 社区翻译成中文。但是，我们每天都在添加新功能并进行更改。因此，出现了新的未翻译的地方。 You can help by providing PR with translation of those places. We would appreciate that.您可以通过提供公关以及这些地点的翻译来提供帮助。我们将不胜感激。 Here's the guide about that https://github.com/dbeaver/dbeaver/wiki/Localization这是关于https://github.com/dbeaver/dbeaver/wiki/Localization的指南

I tried to submit a PR #36340 . If there are any problems, please guide me. I may be more comfortable with this work in the future.


Port interactive window export fix

Port: https://github.com/microsoft/vscode-python/pull/14224
to release

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #14232 into release-2020.09 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@                 Coverage Diff                 @@
##           release-2020.09   #14232      +/-   ##
===================================================
- Coverage            59.85%   59.82%   -0.03%
===================================================
  Files                  692      692
  Lines                38363    38363
  Branches              5521     5521
===================================================
- Hits                 22961    22952       -9
- Misses               14217    14223       +6
- Partials              1185     1188       +3

Impacted Files
Coverage Δ

...atascience/interactive-window/interactiveWindow.ts
9.30% <0.00%> (ø)

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-8.00%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef278da...eb698dc. Read the comment docs.


Adjust PHL weight variable scaling in main code

Resolves #144 by editing the code in GLD and I2D2 to adjust weighting by scaling as needed based on findings in weights_methodology.R and weights_methodology.Rmd.

Note that the documentation required of #144 has already been completed in  PR #152

weight variables have been updated in main script (without running)
markdown file and accompanying R script are updated with:

saving the old Rdata file so when we rerun the code with the update weight in main GLD code it won't overwrite
revisions on summary data workflow in both docs


[New game]: Want to create a Tic-Tac-toe game with AI

🎮 Game Request
I want to add tictactoe game with AI mode and user mode both.
Rules for the game are same as normal TicTacToe
Point down the features
It is made using React
Rules are same as normal TicTacToe
AI is made using minimax algorithm
Select program in which you are contributing
GSSOC 23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @AyishikD !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@kunjgit Please can you also add the gssoc tag

Hey @AyishikD ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Site Support Request Stan.com.au

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.04.01. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.04.01

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

youtube-dl -v https://play.stan.com.au/programs/387127/play
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'https://play.stan.com.au/programs/387127/play']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.04.01
[debug] Python version 2.7.11 - Darwin-15.2.0-x86_64-i386-64bit
[debug] exe versions: rtmpdump 2.4
[debug] Proxy map: {}
[generic] play: Requesting header
WARNING: Falling back on generic information extractor.
[generic] play: Downloading webpage
[generic] play: Extracting information
ERROR: Unsupported URL: https://play.stan.com.au/programs/387127/play
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1348, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 278, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=etree.TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 267, in _XML
parser.feed(text)
File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: mismatched tag: line 5, column 1198
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 669, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 323, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2012, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://play.stan.com.au/programs/387127/play
This is a video page: https://play.stan.com.au/programs/387127/play
This is another video page: https://play.stan.com.au/programs/387128/play

Since this website needs an account, is there something I can do or pull from the website that would be of any help?

@jaimeMF has there been any update on adding this site to the support list?

I would love to get this added as well.

just tried with cookies and everything, no formats found

update, successfully downloaded with ffmpeg, but its encrypted, glitchy video stream and silent audio stream

@ObscenityIB how did you go about that? How did you go about putting in your credentials?

@ObscenityIB how did you go about that? How did you go about putting in your credentials?

netscape cookie file

So is there nothing more that can be done here? I have a login I am willing to share if anyone can help us with this.

Has anyone had any luck getting full streams from Stan?

I'm still pretty new to this but using chrome dev tools I found that Stan seems to use a .mpd file, although both yt-dlp and dash-mpd-cli fail to download it. VLC can accurately get the length of the video, but that's it.
Here's the link to one such .mpd file:
https://api.stan.com.au/manifest/v1/dash/web.mpd?url=https%3A%2F%2F709-stan.akamaized.net%2F09%2Fdash%2Flive%2F406839A-4%2Fsd%2Fsdr%2Fmaster_h264-5efa8b5f.mpd%3Fcdns%3Dgoogle%252Cbandaid%26clearaudio%3Dtrue%26maxQuality%3Dsd&audioType=all&livecaptions=true&captionsUrl=https%3A%2F%2Fapi.stan.com.au%2Fmanifest%2Fv1%2Fvtt%2Fweb.vtt%3Ftype%3Dchrome%26url%3Dhttps%253A%252F%252Fstreamcott-a.akamaihd.net%252F406839A-1%252Feng.vtt&captionsLang=eng&version=126&trickmode=true

I have a Stan tool, but as mentioned it needs an account, and depending on which CDN you choose geo blocking is used as well

The linked MPD specifies PlayReady DRM. Unless someone shows a page whose video plays in a browser with DRM disabled, the issue will be closed.

not sure about PlayReady, but yeah from my testing they for sure use Widevine across the board


HotKeys do not fire on contentEditable div (even when passing ignore options)

Hey,
First thing's first - thanks for maintaining such a great library. Apologies if my issue has an obvious solution, but I couldn't find an answer in the docs.
Describe the bug
I have HotKey mappings to toggle a chatbot modal open/close when fired. These HotKeys works fine anywhere in the app, except when the key combo is pressed within a focused contenteditable div.
How are you using react hotkeys components? (HotKeys, GlobalHotKeys, IgnoreKeys etc)
I'm using the standard HotKeys setup as shown in the doc's example. I also pass the following options to configure:
configure( {             ignoreTags: [],             ignoreEventsCondition: () => {                 return false;             }         } );
N.b I pass an empty array to ignoreTags so that the toggle KeyMap still works when the chatbot is open and the cursor is focused within its input/textarea. The interesting thing is that this functionality works as expected for the input area.
Expected behavior
When the contenteditable div is focused, KeyMap combos should still fire and toggle the chatbot open/close.
Platform (please complete the following information):

Version of react-hotkeys: latest
Browser [e.g. chrome, safari]: chrome

The answer is probably in the function provided to ignoreEventsCondition, but I'm confused as to what should be provided here. Thank you for any guidance
edit: I've noticed that the KeyMap does fire when the contenteditable div is focused, but only like 50% of the time. The behaviour is quite random and inconsistent. I'll investigate further and see if I can get to the bottom of it.

Hi @jkhaui,
Thanks for your kind words. I haven't heard from a user who is using keyboard shortcuts in a content editable div, so thank you for reaching out and providing that perspective.
I agree, from your description of how you're using react-hotkeys, that you can expect it to be working inside the content editable div.
Because you have overridden the ignoreEventsCondition function, ignoreTags isn't actually used. So I think we can rule that out as the problem, for now.
For your reference, the default function for ignoreEventsCondition is as follows:
/**
   * The function used to determine whether a key event should be ignored by React
   * Hotkeys. By default, keyboard events originating elements with a tag name in
   * ignoreTags, or a isContentEditable property of true, are ignored.
   *
   * @type {Function<KeyboardEvent>}
   */
  ignoreEventsCondition: (event) => {
    const {target} = event;

    if (target && target.tagName) {
      const tagName = target.tagName.toLowerCase();

      return Configuration.option('_ignoreTagsDict')[tagName] || target.isContentEditable;
    } else {
      return false;
    }
  },

Basically, it checks for tags in ignoreTags or whether the event target is content editable. So, you have done the right thing by overriding it for your use-case.
I believe because you are seeing inconsistent behaviour, this will be one of the optimization measures at play. Could you please enable logging to verbose and share an instance where the hotkeys fail to trigger while your content editable div is in focus?

Hey guys, I have the same problem:
On my page i have slateJS editor which is basically a div with contenteditable="true" and a wavesurfer.js audio player.
I use
BUT hotkeys work only when text editor is out of focus!
well, slate js allows me to define keybindings, but I want the one and only source of truth, but not many hotkeys function spread over app.

@jkhaui I gather from your edit that you made the hotkey work with
    configure({       ignoreEventsCondition: (event) => {         return false;       }     })
which is great.
In my case, contentEditable div was only firing when I refocused on the div. What helped was adding this line to the handler e.preventDefault(), which prevents default hotkeys assigned to the element. Hope this helps

@aamikus to be honest I can't remember if I ever did get it working. I don't think I did... But I'm working on a similar project now which also uses react-hotkeys, so I'll probably run into the issue again. Your solution will help me and anyone else experiencing issues with contenteditable, thanks for posting it!

Running into this now, also with Slate.js. Is there a way to call react-hotkeys on each keyboard event manually rather than have react-hotkeys capture events?  That would be a reasonable solution.


File manager rewrite

#271
I don't know if anyone uses the file manger things other than me, but it was a rather cumbersome implementation. I've tested these changes on Mac and Windows, seems to work well.

I don't use the file manager stuff, and I'm on linux, so I'm not sure I have much useful feedback to give here. Shall I tag in @dwiel to review instead?

I would be curious to learn what you guys use to navigate folders and such in terminal/file managers efficiently if there's an alternative?

I just use a terminal. I use tab completion a lot, have a command "parent" for going up a directory, and my shell is set up so that I don't need to type "cd directory-name ", just "directory-name " works. But I have to admit it's not the most efficient thing in the world. If I didn't keep most of the files I need open in my editor all the time, I think it would be more annoying – I use emacs, usually have a hundred plus buffers open, and emacs remembers what files I have open on shutdown and restores them on boot up. I'll probably take a look at trying to make file navigation more efficient eventually, maybe using this file manager code, but for now it works ok and I have more pressing needs.

I rarely use the finder app. For navigating directories in a terminal, I also use tab completion a lot. I also have saved directory names so I can quickly navigate to directories I commonly use: cd {user.directories}: "cd {directories}".

I generally only use the terminal (tab completion, fuzzy finding), or for vim I use NERDTree/Fern or fzf to fuzzy search for anything under the current directory I'm working in. I have some generic global code where I can say "path" in some key word that print out my commonly used paths. I use the path thing for all sorts of stuff, and also for the terminal (I have it to if I just press enter like rntz i can enter a dir) and if I end up getting a prompt from Qt or Gtk it's a little bit more annoying to navigate I can sti.l just say the path in roughly get places. That said, I really don't like the way my navigation experience is in general and it's something I want to revisit, mostly because when what I do use fails and I have to manually construct paths or navigate around, is quite awful. I've just been swamped with work, so I haven't really been doing anything with talon that actually takes any real time investment lately

Thanks for the insights. You folks might appreciate this, then.
This is how I use it with both finder and terminal:

Got an imgui for the folders and files, can say "follow 1" or "follow " to navigate folders and such. With small folders + nothing hidden, usually don't even need the imgui.
based on Mike Robert's idea, just trying to make it workable for more apps.

shall we go ahead and merge this? Nobody seems to have any objections.

Seems reasonable.


Confusing "isn't a valid override" error

With code like this:
abstract class AbstractMixin {
  R? watch<T extends ValueListenable<R>, R>({
    T? target,
    String? instanceName,
  });
}

mixin Foo implements AbstractMixin {
  R? watch<T extends ValueListenable<R>, R>({
    T? target,
    String? instanceName,
  }) {
    return target?.value; // simplified implementation,
  }
}

Gives this error:
error: 'Foo.watch' ('R Function<T extends ValueListenable<R>, R>({String? instanceName, T? target})')
isn't a valid override of 'AbstractMixin.watch' ('R Function<T extends ValueListenable<R>, R>({String? instanceName, T? target})').

Not sure what the problem is?

That is a weird error. Appears to be analyzer only.
Reproduces in DartPad if you add:
abstract class ValueListenable<T>{
  T get value;
}
void main(){}

Funny, the CFE had a similar issue a while ago, https://github.com/dart-lang/sdk/issues/47510 (also a case where we have 'S1 is not a correct override of S2' where the signatures S1 and S2 are identical). But the CFE doesn't fail on this one, and the analyzer doesn't fail on that old example. So, fun! :grin:

Ya really weird, I have actually 6 methods in this class, 5 are fine, watch is the simplest one, and throws the error

A smaller example for the analyzer is
abstract class A {
  void foo<T extends R, R>();
}

class B implements A {
  void foo<T extends R, R>() {}
}

https://dart-review.googlesource.com/c/sdk/+/235167

This has returned for me in 2.17
However, this:
abstract class TypeBase {
  String toString();
}

abstract class Scalar extends TypeBase {
  Scalar() : super();
}

class StringScalar<String> extends Scalar {
  @override
  String toString() => 'value';
}

actually gives me two errors:
error • scratch_5.dart:11:10 • 'StringScalar.toString' ('String Function()') isn't a valid override of 'TypeBase.toString' ('String Function()'). •
          invalid_override
           - The member being overridden at scratch_5.dart:2:10.
  error • scratch_5.dart:11:24 • A value of type 'String' can't be returned from the method 'toString' because it has a return type of 'String'. •
          return_of_invalid_type
           - String is defined in /opt/homebrew/Cellar/dart/2.18.5/libexec/lib/core/string.dart at scratch_5.dart:13:4026.


*: add some error description

What problem does this PR solve?

Add some error description to make the error log clearer
avoid retrying context. Canceled error
close #513

What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes
Release Note

Add some error description to make the error log clearer

LGTM

/merge


feat(commit): save message to a file to recover or use as a git editor

This save the convco commit message to a file .git/convco_msg. In case a pre-commit hook failed, the next run of convco commit would recover from this file. convco commit can now also be used as a git editor. In this case git will call convco commit and not the other way around.
Refs: #157

Thank you for the review. I handled all nitpicks as they were easy to do.
I will update the README.md to document the GIT_EDITOR possibility.


Support GHC 8.6.2

This adds support and CI coverage for GHC 8.6.2.
If this looks good, and CI passes smoothly, would you be amenable to this package being added to the Stackage nightly snapshots?

This looks good to me.
@jkachmar, I’ve opened an issue for Stackage. @robrix is on vacation right now, but I think he’ll be amenable to it - we want people to use this package, after all!

Not sure why this is wedged in the builders.

@patrickt: I selected the wrong job in the branch protection settings. Fixed that.

Thanks so much @jkachmar!

If this looks good, and CI passes smoothly, would you be amenable to this package being added to the Stackage nightly snapshots?

I’ve no objection so long as they’re cool with having a 0.x package in there. (In particular, we aren’t promising API stability quite yet.)

Thanks for getting this merged in!
I don't think there should be any objection to API stability, and once the updated version is published to Hackage I can run the Stackage curator again to make sure that everything works together.
How would you like the attribution/maintainership to be set up in Stackage?
e.g. @patrickt is the Stackage maintainer for postgresql-transactional and so shows up in the build-constraints file like this: https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L2798-L2799

@jkachmar: Could you make me the maintainer, with<EMAIL_ADDRESS>for the email address please? 🙏

(I’ve just published <IP_ADDRESS> to hackage today: http://hackage.haskell.org/package/fused-effects-<IP_ADDRESS>)


torch export to ONNX with unwanted layers in AdaptiveAvgPool!

🐛 Bug

I use torchvision.mobilenetV2 export to ONNX, but these are undefine layers add to ONNX, I think these bug exits in nn.AdaptiveAvgPool2d, the fourms discuss in https://discuss.pytorch.org/t/cast-operation-in-onnx/53666.  how can I fix this?
Environment
Name: torch
Version: 1.8.1
Name: torchvision
Version: 0.9.1
Additional context

I export resnet and meet the same problem.

I fix this by saving the simplified model.
change
onnxsim.simplify(
            output_file,
            input_shapes=input_shape_dic,
            input_data=input_dic,
            dynamic_input_shape=dynamic_export)

to
model_opt, check_ok =onnxsim.simplify(
           output_file,
           input_shapes=input_shape_dic,
           input_data=input_dic,
           dynamic_input_shape=dynamic_export)
import onnx
onnx.save(model_opt, output_file)


Add App Insights to Building Real-World Cloud Apps e-book

The telemetry chapter of the Building Real-World Cloud Apps e-book was written before App Insights was released.
https://docs.microsoft.com/en-us/aspnet/aspnet/overview/developing-apps-with-windows-azure/building-real-world-cloud-apps-with-windows-azure/monitoring-and-telemetry

@tdykstra  that series is so obsolete can we get them to retire it and open an issue in the Azure repro? Maybe open an issue in Azure asking them to retire that series too - then close this issue?

Like a lot of the P&P ebooks, the material is old but much of it is still useful.  If we retired everything that's old in the /aspnet/ folder of the repo there wouldn't be much left.  My suggestion is to leave this open with a low priority, and see if someone eventually volunteers to do the update.

@Rick-Anderson @tdykstra is the goal to redo that one doc or eventually every one? Maybe we should be rewriting it for Core 2.0 or .Net 4.7

I'm not working on ASP.NET docs now, so @Rick-Anderson or @scottaddie would know more about current plans for that series.  I believe it would be worth updating if we had enough people interested in working on it.
cc @guardrex

@Rick-Anderson @scottaddie comments?

@isaac2004
I would update the article with a note at the top saying something like
The article was written before App Insights was released. App Insights is the preferred approach for telemetry on Azure. See the following links for more information:

link 1
link 2

@Rick-Anderson PR opened


jenkins,hack: Improve test runner to collect more information at end of tests

Collects Reports, ReportGenerationQueries, and ReportDataSource
resources before deleting the namespace, and also adds junit reports
based on test results.

/lgtm


[ACR] acr task update Fix logic issue for updating encoded task

This PR changes the logic for task update. It resolves the following issues:

The update process missed the EncodedTaskStepUpdateParameters to update the values for EncodedTask. Issue #497.

If our update cmd has a file arg, then CLI makes the assumption that the step is a FileTaskStep or DuckerBuildTaskStep regardless the existing or intended context here. If we want to update the file for an EncodedTask, we will get an error in #313. The reason is the following:
In TasksController, we will first update the exisitingTaskRecord with all of the updated parameters here. As described above, the EncodedTaskStep now has been changed to FileTaskStep. Then we will call ValidateContextProperty() with the updated FileTaskStep. If the step were still EncodedTaskStep, there should have been no validation for context at all, because of this logic. But with the unintended change of task type (from Encoded to File), the validation would fail.

After the change, the update logics follows the create logics.
To test: run
az acr task create -r wjucr001 -n task123 --cmd localhost:12900/test:latest -c /dev/null --schedule \*/3\ \*\ \*\ \*\ \*
az acr task update -r wjucr001 -n task123 --set foo=bar
Observe the value is changed.
az acr task create -r wjucr001 -n task1 -f acb.yaml -c /dev/null
acr task update -r wjucr001 -n task1 -f acb.yaml
Observe no error thrown.
Signed-off-by: Jun<EMAIL_ADDRESS>This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[x] I adhere to the Error Handling Guidelines.

ACR

@wju-MSFT Could you add some tests for those change?

@wju-MSFT Since we will launch the release of this sprint tomorrow, please resolve all the comments before tomorrow, otherwise this PR will not be able to catch up with the release of this sprint, and it can only be postponed to the next sprint (12-06)

@wju-MSFT Since we will launch the release of this sprint tomorrow, please resolve all the comments before tomorrow, otherwise this PR will not be able to catch up with the release of this sprint, and it can only be postponed to the next sprint (12-06)

Will do.

@wju-MSFT Could you add some tests for those change?

Since we are trying to catch up the sprint on Oct 27, I will add unit tests on another PR. Will also create a new WI for unit tests. @zhoxing-ms


[Big Change] Analyze trace, and bring metric/analytic/cause up

Analyze trace data, and give the results.

We will give more details, more visualization demonstrate.
btw @pengys5, @ascrutae

Dev on https://github.com/wu-sheng/sky-walking/tree/feature/3.0

Dev on branch feature/3.0

In 3.0 . We provide:

[ ] Topological graph of application clusters
[ ] New collector restful service for trace-segments
[ ] Upgrade the distributed trace view, in sky-walking-ui

As 3.0 is nearly ready to release, closing this..


Support NodeLocal DNSCache with AntreaProxy

Resolves #2137
Signed-off-by: Lan Luo<EMAIL_ADDRESS>

@antoninbas @tnqn I didn't find an efficient way to check the cache hit inside a DNS pod, I used a prometheus locally to check the metric coredns_cache_hits_total from NodeLocal DNSCache, it looks fine from the metrics, Could you help to take a look? thanks.


Added Change Log

Resolved #5

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jakecarr Can you please sign the CLA? I would like to get this merged in!

@jakecarr
We can’t merge your PR without the CLA being signed.
[ ] Sign the CLA before November 3rd
[ ] Tag @mbernier and @thinkingserious to let us know it is signed
Then we will comment with a link to get your shirt!

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.
Our agenda would be: Explore what you liked and is there anything we can do to improve?
You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.
Thank you so much,
Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@SendGrid


Ethan: Blacklist boxing.oolatv.com

Ethan requests the blacklist of the website boxing\.oolatv\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

boxing\.oolatv\.com has been seen in 3 true positives, 0 false positives, and 0 NAAs.

Approved by cocomac in Charcoal HQ


Resize ( Width or height needs to be defined )

InvalidArgumentException in Size.php line 107:
Width or height needs to be defined.
in Size.php line 107
at Size->resize(null, null, null) in ResizeCommand.php line 20
at ResizeCommand->execute(object(Image)) in AbstractDriver.php line 92
at AbstractDriver->executeCommand(object(Image), 'resize', array(null, null)) in Image.php line 106
at Image->__call('resize', array(null, null)) in ResizeController.php line 65
at ResizeController->performResize()
at call_user_func_array(array(object(ResizeController), 'performResize'), array()) in Controller.php line 55
at Controller->callAction('performResize', array()) in ControllerDispatcher.php line 44
at ControllerDispatcher->dispatch(object(Route), object(ResizeController), 'performResize') in Route.php line 203

Laravel 5.4
Unisharp filemanager 1.7.6
XAMPP for windows
I already add route :

Route::get('/laravel-filemanager/crop', '\Unisharp\Laravelfilemanager\controllers\CropController@getCrop');
Route::get('/laravel-filemanager/cropimage', '\Unisharp\Laravelfilemanager\controllers\CropController@getCropimage');

but still it wont crop and said width and height null

Same issue here. Not working if user only loads img and clicks "resize" button without actually resizing the img.
@rebornishard have You tried to resize the img by pulling the edges? It should work, the dimensions are posted to Size.php
sorry for my english.

@dct24 it actualy resizing, but when submit all error come out because of this
Width or height needs to be defined.
in Size.php line 107

my english also bad

Had same problem, to fix I initialized the new height and width with the original dimensions...
/src/views/resize.blade.php
from:

to:

Issue is still actual.
I'm not able to reproduce the issue.
In my browser, it will always have a default size and doesn't occur any errors.
Would you please also paste your browser console error here?

This is a v1.8.1 issue, and is fixed in dev-master. We will release v1.8.2 to fix this soon.

@g0110280 thanks sir 👍

A fixed issue should be closed. (and links its commit)

@g0110280 what commit is it?

Perhaps  aee7411 from #379

This is a v1.8.1 issue, and is fixed in dev-master. We will release v1.8.2 to fix this soon.

it still not working