HDFS-15963. Unreleased volume references cause an infinite loop.

This patch releases the three previously unreleased volume references.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 46s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 14s

trunk passed

+1 :green_heart:
shadedclient
19m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 231 unchanged - 0 fixed = 237 total (was 231)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
18m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
332m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

427m 51s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestIncrementalBrVariations

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.TestFileTruncate

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.datanode.TestDataNodeMXBean

hadoop.hdfs.server.namenode.TestDecommissioningStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 45fafb4074e9 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 251d055dba4f32fcb446fdbfdacca665f0e0c73d

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/1/testReport/

Max. process+thread count
1964 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 43s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  4s

trunk passed

+1 :green_heart:
shadedclient
16m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 243 unchanged - 0 fixed = 245 total (was 243)

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  4s

the patch passed

+1 :green_heart:
shadedclient
16m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
233m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

320m 42s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9aa1ae06644e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fa37c6a2a87974b3850fa1d3c009ed2d075fc5a7

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/5/testReport/

Max. process+thread count
2803 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 49s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
19m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 231 unchanged - 0 fixed = 233 total (was 231)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
18m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
345m 38s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

440m 25s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.TestStateAlignmentContextWithHA

hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.TestDecommissioningStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4ba7d7f9eddf 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 32fd51264444203fe49620da6d86974ab7f13420

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/2/testReport/

Max. process+thread count
1878 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 46s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 36s

trunk passed

+1 :green_heart:
shadedclient
19m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 231 unchanged - 0 fixed = 233 total (was 231)

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 50s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 39s

the patch passed

+1 :green_heart:
shadedclient
19m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
373m  6s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

471m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestStateAlignmentContextWithHA

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.TestReconstructStripedBlocks

hadoop.hdfs.server.datanode.TestIncrementalBrVariations

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ab8ae4e6a1e3 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fd41b65ff48eb9ffde1acb7041e3a710533e2c6f

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/3/testReport/

Max. process+thread count
1864 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 16s

trunk passed

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
19m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 231 unchanged - 0 fixed = 233 total (was 231)

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 25s

the patch passed

+1 :green_heart:
shadedclient
19m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
382m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

480m 26s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.web.TestWebHdfsFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestStateAlignmentContextWithHA

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 765bf7f4ba05 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c81875c621d8ed74ea1698e9515ef8ccd3588ce9

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/4/testReport/

Max. process+thread count
1880 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failed junit tests have nothing to do with this PR. I ran them locally and all of them passed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 43s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
18m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 14s

the patch passed

+1 :green_heart:
compile
1m 13s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 13s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
3m 18s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
18m 45s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
348m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 35s

The patch does not generate ASF License warnings.

443m 16s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Exception is caught when Exception is not thrown in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetAsyncDiskService$ReplicaFileDeleteTask.run()  At FsDatasetAsyncDiskService.java:is not thrown in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetAsyncDiskService$ReplicaFileDeleteTask.run()  At FsDatasetAsyncDiskService.java:[line 347]

Failed junit tests
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.hdfs.server.namenode.TestFileTruncate

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 34df55f4e902 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 08b8eb023b7490684fd08659224ea67a1f9a4e0b

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/7/testReport/

Max. process+thread count
1992 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Please fix the spotbugs warning. Other than that I am +1.

Thanks @zhangshuyan0 for your great catch here. LGTM. +1 from my side.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 30s

trunk passed

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 27s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
19m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 17s

the patch passed

+1 :green_heart:
shadedclient
18m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
339m 36s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

434m 18s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestIncrementalBrVariations

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.server.datanode.TestBlockScanner

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.server.namenode.TestDecommissioningStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3e2f392f259a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 68dd50e26fa3921b35e88c3e26f4d674c182a899

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/8/testReport/

Max. process+thread count
2249 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 13s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 11s

trunk passed

+1 :green_heart:
shadedclient
17m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 12s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 12s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 55s

the patch passed

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 16s

the patch passed

+1 :green_heart:
shadedclient
16m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
230m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

319m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2889

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 67782299aa3f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 28864d413d5c9c89609b51743443888075307ecd

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/9/testReport/

Max. process+thread count
3627 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2889/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang Hi Wei-Chiu, any furthermore comment here?  If not, I would like to commit this PR shortly. Thanks.

Go ahead. Thanks!

Committed to trunk. Thanks @zhangshuyan0 for your works! Thanks @jojochuang for your reviews!
Will backport to other active branches for a while.


Consider adding orthogonal transformations

Instead of permutations, one can consider learnable linear transformations (See section 3.2 of the Papamakarios review.).
As far as I understand it, in theory this could allow us to learn which conditionals are easier to fit within a model during training.
Obviously this comes with a cost, so may not be practical in all cases.
I have had some decent results with simple versions of this, albeit in low dimensions (< 5), so it could be something worth adding.

e.g. see https://github.com/bayesiains/nflows/blob/master/nflows/transforms/orthogonal.py


fix(curriculum): feedback in replaced elements lecture changed

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #57772

The hint of the last question changed to a more helpful hint.
Hint before: A separate website is an external object.
Hint after: Review the first minute of the video where examples of replaced elements were discussed.

Hi @PanosKatsaras. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


document update

Coverage remained the same at 82.113% when pulling 92a4bee5f792817de674c3b91b037f65146463d5 on erik0704:master into 18eba7e64b300436996cf4b75b59716acbdf9683 on CS2103AUG2017-W10-B4:master.


Update axios.js

SweetAlert sweetalert2.all.js:2863 TypeError: can't access property "constructor", this is undefined

Fixed in 3.0.0


feat(kslideout): support optional title slot

Summary
Adds support for an optional title slot so that additional markup can be used in titles (e.g. a link). The slot takes priority over the prop.
PR Checklist

[x] Conventional Commits all commits follow the conventional commit standards outlined in the main README.
[x] Tests coverage: test coverage was added for new features and bug fixes
[x] Docs: includes a technically accurate README

Just a bypasser here, but since I was involved in where this PR came from:
I'm not totally sure if this should be a PR or just an issue, and not that I have much input over here but ideally any title/header type slots shouldn't be wrapped in a p tag. I'd say its highly likely that the end user is going to want to wrap their 'title' in a semantic h* tag.
Just wanted to leave that as a note.

Closing this as it was superseded by https://github.com/Kong/kongponents/pull/2012.


Phaser CE Version 2.13.1

Please publish to npm @photonstorm

One more to add.

OK, please continue. 🙂


[COPS-3222][DCOS-38688] Cassandra pod replace performs rolling update

This is a follow up for #2556 which was not triggered as part of the PR fro Cassandra as that specific PR job has -k "sanity and not recovery" selector. It failed the nightlies since a permanent node recovery results in a rolling update of other node tasks.
This PR:

Removes the recovery mark from the test (it could be re-added once it is confirmed that this fix addresses the issue)
Adds support to the check_permanent_recovery for updating multiple pods.

Sorry @mpereira, I don't quite follow. What would the pod_deploy_strategy be in this case? I'm definitely open to improving this and making the intent clearer, but my immediate concern was fixing the CI regression that was caused by merging #2556 on Friday.

I was thinking pod_deploy_strategy would be either 'serial' or 'parallel'. If it's 'serial', check_permanent_recovery could just use the pod_list value for what is currently pods_with_updated_tasks, instead of relying on the caller to specify it.

In an offline discussion with @mpereira we sorted out his concerns. I have updated the docstring to be more descriptive.

Thanks for the improved docstring @elezar!


Question about tokenizer.

Thank you very much for your code and excellent job. Could you please explain more about the Tokenizer? I haven't found any introduction to the Tokenizer in your paper. Thank you very much for your help!

Hi @HyoKong, it is the decoding path of feature extractor, which generates a feature descriptor map with the same resolution of the input. I used the name “tokenizer” in view of the term “language tokens” in NLP task.

Thank you for your reply. Could you please explain more about how to apply the attention weight to the raw images? There are many operations in the Regression Head. But it seems that there are few detailed introductions about the regression head in your paper. Thank you very much for your detailed explanation.

Hi @HyoKong, I have added additional documentation to clarify things a bit here. Not all details are mentioned in the paper due to space constraint. So we only include things that we feel are crucial to understand the pipeline. Have you looked at the documentation of each function in regression_head? Which one are you confused about? I can always add more information to clarify.
To answer your question

Could you please explain more about how to use the attention weight to regress disparity and occlusion mask?

Disparity: attention weight is used to find the most attended pixel and build a 3px window around it to regress disparity, as outlined here. The weighted-sum is to produce sub-pixel disparity values.
Occlusion: the attention weight within the 3px window naturally reflect the confidence, therefore the inverse of it is used to predict occlusion, as outlined here
These are in paper Section 3.2.5.


Extentions for time series or vision patches？

An interesting work! Have you ever thought about gzip or other algorithms + KNN/other models for time series classification, these days I have to make predictions on EEG brain signals, it is so long that I can not process them well, Do you think the compressor has potential to extract time series features?

Yes, actually compressor-based methods are really good at time series classification, or even clustering.
You can check this paper: https://www.cs.ucr.edu/~eamonn/SIGKDD_2004_long.pdf


Fixing test262 built-ins json test-cases

JerryScript-DCO-1.0-Signed-off-by: bence gabor kis<EMAIL_ADDRESS>

@galpeter  Yes, you are right.

Why? Part of this PR is needed (bigint and stringify fixes)


How to get date in c# in MS format?

I cant get date in ms format.. its not working.
string end = DateTime.Now.ToString("yyyyMMddhhmmss");

why didnt u tell this is unix epoc time?
http://www.ruddwire.com/handy-code/date-to-millisecond-calculators/#.VOY7dPmsVUV
http://stackoverflow.com/questions/2883576/how-do-you-convert-epoch-time-in-c

Hey, It's all over the readme


confusion with router api

for example, with axum, we can do this:
let app = Router::new()

i don't see anything related to routing in the docs. maybe it could be useful to have examples for routing as well.

Hi @11reed , I’m working to implement that feature.
link: New router API


Error with packagetracer.xlsm

Hi, I've found an error but not sure how to fix it. I have tried going over forums including the one on xlwings but no luck yet.
What?
Got a Error: TypeError message when using the pagetracker.xlsm file
Steps to reproduce

Using Windows 10
Using Excel for Mircosoft 365
PyCharm Community Edition
Python 3.11

On Chapter 11 we are introduced to a packagetrackre.xlsm I enabled the macros and all. I am on the Database sheet and just clic the 'Add Package' button after "xlwings" was added at the package name slot but got: "Error: TypeError("Connection.execute() got an unexpected keyword argument 'package_name'")"

. I was expecting for the "package added" prompt but nope. I tried ussing other packages as pandas but the same thing occurs.
Debugging
I checked on the packagetracker.py file and found that message was given as a general error message in case other errors wouldn;t appear so I haven't been able to figure out what's going on. I found the package name variable, but seems to be trying to fetch the value of the cell in excel.
It;s dving me insane now how I just dont know how to stop getting that error message or how to fix it. Please help.

Are you using the workbook/code from this repo or were you putting it together manually?

I was using the one from here. Downloaded the zip file.

And which version of Anaconda have you got installed?

my conda version is 23.7.3

I've just downloaded the latest Anaconda installer and ran it with the downloaded code from the ZIP and couldn't replicate your issue. Can you copy/paste the your store_package function from the database.py file?

Sure!
def store_package(package_name):
"""Insert a new package_name into the packages table"""
try:
    with engine.connect() as con:
        con.execute(text("INSERT INTO packages (package_name) VALUES (:package_name)"),
                    package_name=package_name)
    return None
except sqlalchemy.exc.IntegrityError:
    return f"{package_name} already exists"
except Exception as e:
    return repr(e)

this one??

You must have upgraded the sqlalchemy package to 2.0. Note that Anaconda still in its latest version comes with 1.4.39, which is compatible with the code in the book.
My suggestion would be to downgrade like this: pip install sqlalchemy==1.4.39 or to use the dedicated conda env, as described in the Appendix of the book or here on the homepage: https://www.xlwings.org/book#pythonanaconda-version

All right, let me give it a try with that one! I'll let you know if it works.

I got the same problem but I figured it out what was triggering it. This problem occurs when you have different version of xlwings installed on the windows but you are using the xlwings module version from the environement.yml file. So If you click the Add Package button or Show Summary Buttons, you will get an error but if you run the packagetracker.py file from the terminal and use the following snippet to mock the call from the packagetracker.py file it will run just fine.
if __name__ == "__main__":
    xw.Book("packagetracker.xlsm").set_mock_caller()
    show_history()

I forked your repo and I am going to modify the code that will run for the latest version as well because new readers might get this error and get annoyed that the code is not updated and it is not even working on the environment that the Author used.

Following the book's instructions, you shouldn't end up in this situation: the book explains how to install the conda env using xl38.yml, not environment.yml. The latter is only there for the Binder online Jupyter notebook service, as mentioned at the top of the file.

Even though I debugged the packagetracker according to latest versions of all modules but I reproduced the Error and figured out what was causing it. It seems that you also have to give conda path and env that you make with xl38.yml to xlwings tab in Excel:

and when you give the path and env name, it works from xlsm sheet as well. I don't know if this step is included in the book or not because I don't remember. and xlwings version difference don't have anything to do with this error because I am using xlwings 0.30.12 as you can see in screenshot but in conda env i just updated to xlwings 0.29

Right, thanks for pointing that out! Well, the instructions are to use (xl38) whenever the book uses (base), so in that case you'd run the add-in's install command (xlwings addin install) from an Anaconda prompt with (xl38) activated, which will properly configure the add-in automatically.
I'll improve the instructions on how to set up a working environment in the next edition.


Where are autoload.php?

I downloaded the code via GIT, but I can't find autoload.php, I can't load the libraries accordingly
require "../../../vendor/autoload.php";

use CloudflareBypass\CFCurlImpl;
use CloudflareBypass\Model\UAMOptions;

$ch = curl_init("https://altadefinizione.cloud/");

// Want to cache clearance cookies ?
// curl_setopt($ch, CURLOPT_COOKIEJAR, "cookies.txt");
// curl_setopt($ch, CURLOPT_COOKIEFILE, "cookies.txt");

curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_HTTPHEADER,
    array("User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36"));

$cfCurl = new CFCurlImpl();

$cfOptions = new UAMOptions();
 $cfOptions->setVerbose(true);
// $cfOptions->setDelay(5);

try {
    $page = $cfCurl->exec($ch, $cfOptions);
} catch (ErrorException $ex) {
    // example of how to handle errors
    echo "Unknown error -> " . $ex->getMessage();
}

// Want to get clearance cookies ?
// $cookies = curl_getinfo($ch, CURLINFO_COOKIELIST);

echo $page;

Install composer and run composer install


[ISSUE-952][FEATURE] Make each partition location data can be grouped and managed by (partitionId, attemptId)

see issue link #952
[BUG]/[FEATURE] title
What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

As we discussed offline, we'd better encode mapId and attemptId into partitionId instead of introducing group.


Check if any value is selected in all selects?

Hi, I have multiple selects in a form and need to check if the form has any values and then toggle a class on the form depending on this.
I tried getValue() but it only return the value from the first select.

push your instances to an array when you instantiate them then iterate using the getValue() method.

alright, any example on how this could look? Basically what im currently trying is the above

        this.choices = new Choices(this.selects, {
            placeholderValue: 'Välj behörighet'
        })

        this.selects.forEach((select) => {
select.addEventListener('change', (e) => {
    if (this.choices.getValue() != '') // do something
})
})

Try this: https://jsfiddle.net/fsquaredmedia/u5twLLLr/


proposal: cmd/compile: refactor compiler and linker to be libraries

The Go compiler and linker are currently built as command line tools. This issue proposes refactoring so they can be used as libraries.
Benefits:

External applications could compile code in a server (or even browser) environment. For example a wasm mode for https://compile.jsgo.io/ and https://play.jsgo.io/. Currently this is impossible.
The go command line tool currently uses os/exec to spawn sub processes when it needs to compile and link. If the compiler and linker were built as libraries, this could be accomplished in-process, without the overhead of os/exec.

Problems:

The current code directly accesses the filesystem with the os package for reading the input code and writing the output binaries. A solution would need an abstraction layer, similar to build.Config.
The current codebase makes extensive use of package level variables to store state - this would need to be refactored.
This will increase the public surface area of the compiler API.

This is #15108

Yes you're absolutely right. I'll close this and add my jsgo.io wasm example as a case-study to the other issue.


What's the main deference from minikube

multi cluster?

Minikube is for local development on top of kubernetes, while kubeone is for running production kubernetes clusters in clouds and on-premieres.
Please take a look at our readme for more information: https://github.com/kubermatic/kubeone/blob/master/README.md


[ENH] Refactor sliding and expanding window splitters to allow timdelta forecasting horizon

Reference Issues/PRs

Next step in #1737
What does this implement/fix? Explain your changes.

In general, I have refactored splitters (mainly SlidingWindowSplitter and ExpandingWindowSplitter) so that they accept pd.Timedelta as forecasting horizons.
More detailed list of changes:

Conditions in _check_window_lengths are simplified taken into account that we now support only two options: either everything (windows, horizons, etc.) is integer, or everything is timdelta-like.
get_cutoffs now returns only integer arrays. This is a unification step to make it clear that we return k instead of either k or t(k). All implementations, docstrings and test function _check_cutoffs_against_train_windows are updated accordingly.
New method _split_windows_generic in BaseWindowSplitter. It encapsulates code repetition from two implementations _split_windows in SlidingWindowSplitter and ExpandingWindowSplitter. The difference is regulated by boolean argument expanding.
Most importantly usage of _coerce_duration_to_int with hardcoded freq="D" is gone. Now we do not care if timedelta is daily, weekly, or any other frequency.
All test functions for SlidingWindowSplitter and ExpandingWindowSplitter have additional test cases TEST_FHS_TIMEDELTA.

Does your contribution introduce a new dependency? If yes, which one?

No
PR checklist

For all contributions

[X] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[X] I've added unit tests and made sure they pass locally.
[X] The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug

@fkiraly @aiwalter Sorry to bother you, but would you be so kind to take a look at this PR? Thanks!

sorry to let you wait, forgot this over GSoC and 0.11.3 and all. Sure!

looks ok, let me just quickly test whether it would break in combination with #2599

Thanks for suggestions! As you requested, I have updated dosctrings for _split_windows_generic and for get_cutoffs. I made it even more explicit that get_cutoffs always return .iloc[] integer indices.

Could you just be a little bit more specific? Made suggestions, but I´m not sure whether they are correct.

All suggestions are fine with me. Tests pass. Anything else I can do here?

you said you changed it in 3 places, but only 1 place is changed. Probably you just forgot to push.

these two lines:
cutoffs : 1D np.ndarray of int
            iloc location indices, in reference to y, of cutoff indices

can be found in line 474, 631, 853, and 1071. You are right, I forgot to push one. Thanks.

I think it´s still missing in line 749, 751? Did you push everything?

I think it´s still missing in line 749, 751? Did you push everything?

Lines 748-751:
train : 1D np.ndarray of int
    Training window iloc indices, in reference to y
test : 1D np.ndarray of int
    Test window iloc indices, in reference to y


Nonexistant gridlines (Rulings) detected in cells

Nonexistent header cells are being detected in certain tables. Page 6 of
MasimoCatalogOnline.pdf (run with arguments -p 6 -r) results in invisible grid lines in the header row. I wrote a python script which draws the Rulings found.

shows the extra horizontal Rulings in the first row.

Hi @MichaelALong,
Some PDFs contain lines that are of the same color of the background. We still haven't implemented a reliable method to filter them out. tabula-java also contains a debugging tool that does what you implemented:
➜  ~ java -cp ~/Downloads/tabula-0.9.1-jar-with-dependencies.jar technology.tabula.debug.Debug -p 6 -r ~/Downloads/MasimoCatalogOnline.pdf

@jazzido
Hi, I have encountered the same problem where there are invisible lines in the PDF that are creating unwanted tables. I found a TODO for the same (in ObjectExtractor) for implementing color filter for such rulings. Can you lead me with some information/suggestions into how to implement this by myself


export model::ModelFactory;

Sorry for no description, I wanted to use ModelFactory to use it in Decoder.decode_reader, because the buffer I pass has multiple structures, and fastlib::from_bytes parses only single struct and throws error if buffer is not empty.
So I can use decode_reader but I was only able to pass JsonFactory to it, When I checked the source, I saw ModelFactory and wanted to use it.

I do not think making ModelFactory public will help you much. You'll need access to TemplateData at least. So, highly likely, even more internals will require pub.
ModelFactory (and ModelVisitor) are both just an internal bridge to/from serde and there is no much reason to make it public. ModelFactory (as well as JsonFactory and TextMessageFactory) implements MessageFactory trait. You can write your own type which implements that trait, so you can deserialize to any format or structure  you need.
Please check serde usage example (e.g.: tests/cqg-serde.rs), that is (probably) the right way to do use the library. ;)
The issue with buffer is not empty is another thing. decode_vec is supposed to be used when outer protocol is packet-based and you usually have exactly one message in buffer. In your case it seems Decoder::decode_stream is a right choice. It can read from anything that implemented std::io::Read trait.

Thanks for the reply, I checked decode_stream, But issue is that I receive packets which indicate when to reset decoder.
By using decode_stream, I won't be able to call reset when required.


[Feature Request]:  Feat:adding a new page to display all contributors✨

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add a page to showcase all the contributors of this website
can you assign me this issue,
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC-EXT contributor
[X] I'm a HACKTOBERFEST contributor
[X] I have starred the repository

@T-Rahul-prabhu-38 go for it.

@T-Rahul-prabhu-38 are you working on this issue? If not, @jeevan10017 could you please assign this to me?
I will create PR soon for the same.


Permissions/ownership on /etc/opendkim folder and key/ subfolder

Hi again,
After running the role (on Ubuntu 20.04 LTS with some specific security configuration), I get:
Jan  1 22:44:43 s89499 opendkim[179674]: can't load key from /etc/opendkim/keys/mail.private: Permission denied

The problem is that dkim_group (opendkim) doesn't have read permissions on all the directories in path.
https://github.com/FoxyRoles/ansible-dkim/blob/108f8c6f460aac488d37a03c0f909e6dec8c46ea/tasks/opendkim.yml#L19-L22
It might be a good idea if the role ensures:

Read permission on dkim_opendkim_config_dir (ie /etc/opendkim) for dkim_group (ie opendkim): either set o+r or, maybe better, set group ownership for this folder to dkim_group (ie opendkim) ensuring that dir has g+r but g-w (group should not have write permissions).
Same for the keys/ subdir.

Locally I used:
    - file:
        path: "{{ item }}"
        group: "{{ dkim_group }}"
        mode: g-w,g+r
      with_items:
        - "{{ dkim_opendkim_config_dir }}"
        - "{{ dkim_opendkim_config_dir }}/keys"

@ulvida Can you look at this please? I don't use keys in subdirs as you are.

@ulvida Can you look at this please? I don't use keys in subdirs as you are.


add checker for non relative links

Check is failing
https://github.com/trunk-io/.trunk/actions/runs/10605073045/job/29393111842

Check is failing https://github.com/trunk-io/.trunk/actions/runs/10605073045/job/29393111842

Strange.  I copied this from Tyler's blog:  https://trunk.io/blog/fixme-please-an-exercise-in-todo-linters#grep-linter-


Use cases

Some stix2arango uses cases :

collection of CTI objets
visualisation of kill chain
handling and managing cyber operations (attack / defense)

Usage of artificial intelligence for objets ?

Lib for visualisation :

https://square.github.io/cubism/ : visualisation of time series data
https://highlightjs.org/ : highlight code
d3 for graph visualisation
Other lib : https://github.com/arkime/arkime/tree/main/viewer/public


Clear for Internal Description

"Clear" function does not work in Internal Description update.

Hi @katbur . Thanks for reporting this issue. We released a small fix which we hope fixes the issue. Please let us know how it works for you.

Hello,
Yes, it is working. Thank-you!
Kathleen
On Sun, Dec 6, 2020 at 6:23 AM Josh Weisman<EMAIL_ADDRESS>wrote:

Hi @katbur https://github.com/katbur . Thanks for reporting this issue.
We released a small fix which we hope fixes the issue. Please let us know
how it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ExLibrisGroup/alma-e-collection-quick-update/issues/6#issuecomment-739488815,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFCIKJOYMGDVUGYDEFXAQTDSTNSSXANCNFSM4ULATJ2A
.

Hello,
Yes, it is working. Thank-you!
Kathleen
On Sun, Dec 6, 2020 at 6:23 AM Josh Weisman<EMAIL_ADDRESS>wrote:

Hi @katbur https://github.com/katbur . Thanks for reporting this issue.
We released a small fix which we hope fixes the issue. Please let us know
how it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ExLibrisGroup/alma-e-collection-quick-update/issues/6#issuecomment-739488815,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFCIKJOYMGDVUGYDEFXAQTDSTNSSXANCNFSM4ULATJ2A
.


External table statistics. WIP.

Proposed changes
Issue Number: close #xxx
Collect HMS external table statistic information through external metadata.
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.28 seconds
load time: 438 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221114140146_clickbench_pr_45873.html


19324 dropdownlist selection for boolean attributes

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#19324

@WinterSilence Just one question about the order of $strict: Should the comparison with == really be the strict one? Comparing with strcmp appears more strict to me, but for now I implemented your original suggestion. What do you think?

Comparing with strcmp appears more strict to me, but for now I implemented your original suggestion. What do you think?

In accordance with how yii\helpers\BaseArrayHelper::isIn handles $strict, I have now inverted the original proposal. Now, for $strict = false, the comparison is done with ==.

@adnandautovic my solution works differently i.e. I not co-author

@adnandautovic please add more test cases, for example, case from your issue: renderSelectOptions(false, ['No', 'Yes'], ['prompt' => 'Please select'])

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

That's true, thank you. I took a look at this and it was caused by previous fixes for wrong default selections in d39d3ed0a65d5e442908f38f105fc6d3e3e01c2f and in e49a52f3a18dd7ae20a710dc8208baaab8a93fa8.
In fact, it appears that the fix in e49a52f3a18dd7ae20a710dc8208baaab8a93fa8 was faulty and the casting should have been removed in that commit.
Unfortunately, in order to do this properly then, I would have to change all three functions, checkboxList, radioList and renderSelectOptions.
I will see how I get along with this, but that definitely expands the scope of this issue.

@adnandautovic invalid order array: ['Please select', No, Yes]

@adnandautovic invalid order in array: ['Please select', No, Yes]

Sorry, I don't understand? This particular test is not failing. Old tests for dropDownList, radioList and checkBoxList are failing, leading me to believe that I should just leave everything other than renderSelectOptions as it is.

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

Thank you, I think I will be able to take a look next week.
In the meantime, I think the conversion to (string) has something to do with https://github.com/yiisoft/yii2/blob/8f4a7b696aad1f59ae9378721924ea8a91d85382/framework/helpers/BaseHtml.php#L1874-L1876 but I will have to check in more detail next time.

@adnandautovic look to HTML returning from updated BaseHtml::renderSelectOptions()

I think the order is fine, actually.

In the meantime, I think the conversion to (string) has something to do with
https://github.com/yiisoft/yii2/blob/8f4a7b696aad1f59ae9378721924ea8a91d85382/framework/helpers/BaseHtml.php#L1874-L1876

In hindsight, this is obvious from d39d3ed0a65d5e442908f38f105fc6d3e3e01c2f.

ArrayHelper::isIn((string)$key, $selection, $strict) this typing is incorrect: same result in strict and non-strict mode.

This has turned out to not be the case (see the tests I added in 8f4a7b696aad1f59ae9378721924ea8a91d85382). The results in strict and non-strict mode are different with the type casting and in fact the type casting is required.
Anyway, I have now added a failing test to demonstrate the impossibility of performing a non-strict check for a traversable selection containing a boolean, i.e. [false], without explicitly handling the case of a boolean selection in renderSelectOptions.
The way I see it, there are two options:

Ignore that, because apparently no one has had a need for that so far.
Add code to separately handle the case where $selection contains a boolean.

I prefer the first, but both would be fine by me.

@adnandautovic nope, you still don't understand how work typing: your array [true => 'Yes', false => 'No'] convert to [1 => 'Yes', 0 => 'No'] i.e.  ['No', 'Yes']. Your expected HTML is invalid:
$expected = <<<'EOD'
<option value="">Please select</option>
<option value="1">Yes</option>
<option value="0" selected>No</option>
EOD;

@adnandautovic nope, you still don't understand how work typing: your array [true => 'Yes', false => 'No'] convert to [1 => 'Yes', 0 => 'No'] i.e. ['No', 'Yes']. Your expected HTML is invalid:
$expected = <<<'EOD'
<option value="">Please select</option>
<option value="1">Yes</option>
<option value="0" selected>No</option>
EOD;

As you can see from the tests that ran in the CI runner, the order is fine as far as php is concerned.
However, if you have some personal preference as to the order you want to see here, I can change that.

As you can see from the tests that ran in the CI runner, the order is fine as far as php is concerned. However, if you have some personal preference as to the order you want to see here, I can change that.

@WinterSilence for your convenience, I have commented out the one failing test that I added on purpose. As you can see, all tests run successfully now, even with the old html. But as I said, I can change it if you like.

@adnandautovic Your current solution is valid, but work slow, better solution is fix expected HTML.

Thank you.


why training and validation loss are always zero during the training phase of deep neural network?

I'm new to machine learning and I'm trying to learn more about it. I have been facing many problems doing my project as DEEP NEURAL NETWORK Classifier (classes 0,1).
I'm using windows 8.1, 4GB ram, python 3.6.4(pip installation), tensorflow cpu version v1.4 (pip installation).
All other packages required for this code also installed through pip installation and have been imported.
During training, Train loss and validation loss are always zero. I don't know why?
If anyone know the problem, please let me know asap!! My project deadline is very near!!
Things I've tried:

different values for hidden_units, no. of hidden layers, batch_size, learning_rate
Equally distributed my sample inputs according to the class labels.
I gave the same data to LDA (Linear Discriminant Analysis) and it's able to classify at the accuracy of 99.6%
I gave the same data to bernoulliRBM and it classifies all samples as class '0'

here is my CODE
def build_neural_network(hidden_units_1=8, hidden_units_2=16):

    tf.reset_default_graph()
    inputs = tf.placeholder(tf.float64, shape=[None, train_x.shape[1]])
    labels = tf.placeholder(tf.float64, shape=[None, 1])
    learning_rate = tf.placeholder(tf.float64)
    is_training=tf.Variable(True,dtype=tf.bool)
    initializer = tf.contrib.layers.xavier_initializer()
    fc = tf.layers.dense(inputs, hidden_units_1, activation=None,kernel_initializer=initializer)
    fc=tf.layers.batch_normalization(fc, training=is_training)
    fc=tf.nn.relu(fc)
    fc = tf.layers.dense(fc, hidden_units_2, activation=None,kernel_initializer=initializer)
    fc=tf.layers.batch_normalization(fc, training=is_training)
    fc=tf.nn.relu(fc)
    logits = tf.layers.dense(fc, 1, activation=None)
    cross_entropy = tf.nn.softmax_cross_entropy_with_logits(labels=labels, logits=logits)
    cost = tf.reduce_mean(cross_entropy)

    with tf.control_dependencies(tf.get_collection(tf.GraphKeys.UPDATE_OPS)):
         optimizer = tf.train.AdamOptimizer(learning_rate=learning_rate).minimize(cost)

    predicted = tf.nn.softmax(logits)
    correct_pred = tf.equal(tf.round(predicted), labels)
    accuracy = tf.reduce_mean(tf.cast(correct_pred, tf.float64))

    export_nodes = ['inputs', 'labels', 'learning_rate','is_training', 'logits',
                'cost', 'optimizer', 'predicted', 'accuracy']
    Graph = namedtuple('Graph', export_nodes)
    local_dict = locals()
    graph = Graph(*[local_dict[each] for each in export_nodes])

    return graph

model = build_neural_network()

epochs = 10
train_collect = 10
train_print=train_collect*2
learning_rate_value = 0.01
batch_size=100
x_collect = []
train_loss_collect = []
train_acc_collect = []
valid_loss_collect = []
valid_acc_collect = []

saver = tf.train.Saver()
with tf.Session() as sess:
    saver.restore(sess, "./save.ckpt")
    iteration=0
    for e in range(epochs):
          for batch_x,batch_y in get_batch(train_x,train_y,batch_size):
                iteration+=1
                feed = {model.inputs: train_x,
                            model.labels: train_y,
                            model.learning_rate: learning_rate_value,
                            model.is_training:True,
                            }
                train_loss, _, train_acc = sess.run([model.cost, model.optimizer, model.accuracy],
                        feed_dict=feed)

                if iteration % train_collect == 0:
                    x_collect.append(e)
                    train_loss_collect.append(train_loss)
                    train_acc_collect.append(train_acc)

                    if iteration % train_print==0:
                        print("Epoch: {}/{}".format(e + 1, epochs),
                        "Train Loss: {:.4f}".format(train_loss),
                        "Train Acc: {:.4f}".format(train_acc))

                    feed = {model.inputs: valid_x,
                                model.labels: valid_y,
                                model.is_training:False
                                }
                    val_loss, val_acc = sess.run([model.cost, model.accuracy], feed_dict=feed)
                    valid_loss_collect.append(val_loss)
                    valid_acc_collect.append(val_acc)

                    if iteration % train_print==0:
                        print("Epoch: {}/{}".format(e + 1, epochs),
                       "Validation Loss: {:.4f}".format(val_loss),
                       "Validation Acc: {:.4f}".format(val_acc))

saver.save(sess, "./save.ckpt")

#here is the OUTPUT of training:
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949

 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 1/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 1/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 Epoch: 2/10 Validation Loss: 0.0000 Validation Acc: 0.4949
 Epoch: 2/10 Train Loss: 0.0000 Train Acc: 0.5013
 ...

(I'm getting the same result as above till epoch 10/10)

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

You have activation = None set on all your layers. Try using rectilinear unit.

@vkmenon I have used ReLU bro. First I've put None but after batch_normalization, I've used tf.nn.relu. So, it should work.
   fc = tf.layers.dense(inputs, hidden_units_1, activation=None ,kernel_initializer=initializer)
   fc=tf.layers.batch_normalization(fc, training=is_training)
   fc=tf.nn.relu(fc)

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


drivers: adc: STM32: add support for oversampling

The STM32 G0, G4, H7, L0, L4, WB and WL series have hardware support for
oversampling. This patch adds support for it, using the oversampling
value provided in the adc sequence. The result is shifted right
accordingly to not change the resolution of the measured value, like it
is done on other ADC drivers.
Signed-off-by: Aurelien Jarno<EMAIL_ADDRESS>

I have just rebased this PR against main to fix the CI issue.


Is there a way to wait until new window fully loaded?

I'm testing the scenario where a new window is created upon button click.
app.client.waitUntilWindowLoaded()
                .click('#sginin-button')
...
...
                // to get the new window?
                .windowByIndex(1)
               .getTitle().should.eventually.equal('SignIn Window');

How do I make the test wait until the new window is fully loaded then check the title among other things in the new window?
Many thanks

I think you could use webdriver's waitUntil, and check how it's used to implement waitUntilWindowLoaded.
I haven't tested this, but maybe something like this might work or gives you some inspiration :)
app.client
  .waitUntilWindowLoaded()
  .click('#sginin-button')
  .waitUntil(function () {
    return app.client.windowByIndex(1).isLoading().then(function (loading) {
      return !loading
    })
  })
  .getTitle().should.eventually.equal('SignIn Window');

Thanks for the suggestion.
The following seems to work in the end:
.waitUntil(function () {
        return this.windowHandles().then(getResponseValue).then(function (handles) {
            return handles.length === 2;
        })
    }, 10000).then(function () { }, function (error) {
        error.message = 'waitUntilTwoWindows ' + error.message
        throw error
})

Nice, glad I could help!

Appears to be resolved 👍


Fix and improve "hourly" data acquisition once more

Introduction
This is a followup to #67.

dwd readings --station=183,662 --parameter=solar --resolution=daily --period=recent --date=2020-05-31

As soon as #63 gets merged, it should probably also start working for hourly data.

We are not there yet.
Rationale
This accounts for another two anomalies within hourly/solar data.

Skip field MESS_DATUM_WOZ on import.
Grok timestamp field values like<PHONE_NUMBER>:03.

Notwithstanding the above, obtaining timestamps from the command line has been improved to be able to say things like --date=2020-06-15T12 in order to properly address the "hour" slot when filtering.
Outlook
Both invocations will start working:
# Acquire hourly "air_temperature" data.
dwd readings --station=44,1048 --parameter=air_temperature --resolution=hourly --period=recent --date=2020-06-15T13

# Acquire hourly "solar" data.
dwd readings --station=183,662 --parameter=solar --resolution=hourly --period=recent --date=2020-05-31T12 --persist

Dear Benjamin,
thanks for merging #65. This PR has now been rebased onto master and is also ready for review.
Cheers,
Andreas.

The only question for me is if the WOZ timestamp has any value.

As MESS_DATUM offers the same value in UTC, I believe it's okay to drop the MESS_DATUM_WOZ field. More information might be available within the PDF documents at [1].
However, I leave the ultimate decision to you guys. Maybe @meteoDaniel and @wetterfrosch can also have a look at this? Thanks already!
[1] https://opendata.dwd.de/climate_environment/CDC/observations_germany/climate/hourly/solar/

When looking at one record, I see some remarkable difference:
        853;2020053108:06;    1;   -999;   72.0;   73.0;   0;    49.68;2020053109:00;eor
I wonder what the digits behind the : mean: I guess minutes! The WOZ is the "Wahre OrtsZeit", or "local mean time" and refers to my understanding to the zenith of the sun on a particular spot. So it contains some meteorological relevant fact. But this fact is from my understanding an inherently constant of station's longitude.

@wetterfrosch: Thanks for looking into this! I will be happy to implement anything you like. Please give me advice which timestamp to use as the canonical one.
Please take into consideration that hourly data is usually queried through --date=2020-05-31T08, where just the hour slot is given. For that reason, I've floored 08:06 to 08:00 in order to make that possible. Otherwise, the filtering will yield empty results. I know this reasoning is technical, but nevertheless I wanted to give you a heads up on this.
Notwithstanding the above, people are usually used to query data by UTC, right?
Proposal

Use<PHONE_NUMBER>:06 floored to 00 by the minute as canonical timestamp converged into the DATE field as currently implemented.
Additionally propagate<PHONE_NUMBER>:00 (the WOZ real local time) into a new DATE_LOCAL field?

Please advise any corrections to this proposal. Maybe @meteoDaniel can also add his thoughts here.

@wetterfrosch: Thanks for looking into this! I will be happy to implement anything you like. Please give me advice which timestamp to use as the canonical one.
Please take into consideration that hourly data is usually queried through --date=2020-05-31T08, where just the hour slot is given. For that reason, I've floored 08:06 to 08:00 in order to make that possible. Otherwise, the filtering will yield empty results. I know this reasoning is technical, but nevertheless I wanted to give you a heads up on this.
Notwithstanding the above, people are usually used to query data by UTC, right?
Proposal

Use<PHONE_NUMBER>:06 floored to 00 by the minute as canonical timestamp converged into the DATE field as currently implemented.
Additionally propagate<PHONE_NUMBER>:00 (the WOZ real local time) into a new DATE_LOCAL field?

Please advise any corrections to this proposal. Maybe @meteoDaniel can also add his thoughts here.

I'm no expert at this topic. However I guess as the DWD points at the exact minute of ending of the interval with the given ":06" minute stamp, this is an important information. Maybe we could store it as an extra column "interval ending minute" or so. Also I'd prefer to rather convert the WOZ to a difference to the other timestamp (in this case 54 minutes). Otherwise we would have two columns with datetime which I think is not good practice for time-series like data.

Use<PHONE_NUMBER>:06 floored to 00 by the minute as canonical timestamp converged into the DATE field as currently implemented.
Additionally propagate<PHONE_NUMBER>:00 (the WOZ real local time) into a new DATE_LOCAL field?

No that would be insane: We would miss the information on the six minute difference at all and would therefore need to re-calculate the WOZ on or own again when needed.
We could:

use "hourly"-time (08:00) as timestamp, calculate WOZ-difference, write that difference to a field and when accessing the data try to add that field-value to the timestamp (I am still getting nightmares.)
calculate the UTC-equivilant of the WOZ, keep the "hourly"-time for formal reasons.

So I would recommend what I think Benjamin says: Let's choose the second way and create a valid and exact UTC-timestamp of the WOZ. The propagated "hourly"-timestamp seems to be more a political/technical value so that not-so-timeseries-software can access the information within the calendaric-hour-pattern -- I guess we're so much 21th century that this information can be stored in a simple (non-indexed) field.

calculate the UTC-equivilant of the WOZ, keep the "hourly"-time for formal reasons.
So I would recommend what I think Benjamin says: Let's choose the second way and create a valid and exact UTC-timestamp of the WOZ. The propagated "hourly"-timestamp seems to be more a political/technical value so that not-so-timeseries-software can access the information within the calendaric-hour-pattern -- I guess we're so much 21th century that this information can be stored in a simple (non-indexed) field.

@amotl can you take care of this? Maybe name the new column woz_diff_in_minutes or something shorter...

@gutzbenj and I decided to keep both datetime fields unmodified and use the main field from the first column as canonical timestamp after stripping off the minute-part.
Please let us know if you have any objections on that.

Sorry that I currently can't find the time to move this forward. Feel free to take over if you are lucky, otherwise, just leave it here and enable drafts mode if you like.

I do not any use case where the WOZ is required. But I know that for very accurate calculations with solar angles and clear sky models you have to know the most representative timestamp for the hourly value. So it might be useful to hold this information. If anybody will use it is a quite different questions.

@gutzbenj: Thanks a bunch for bringing this into mainline through #89.

I just gave it a shot and wanted to share the outcome with you for the final review to see how things are implemented right now:
$ wetterdienst readings --station=183,662 --parameter=solar --resolution=hourly --period=recent --date=2020-05-31T12 --persist

2020-07-06 23:57:44,528 [wetterdienst.data_collection  ] INFO   : Data for solar/hourly/recent/station_id_183 restored from local.
2020-07-06 23:57:44,830 [wetterdienst.data_collection  ] INFO   : Data for solar/hourly/recent/station_id_662 restored from local.

[
    {
        "station_id":183,
        "date":"2020-05-31T12:00:00.000Z",
        "end_of_interval":"2020-05-31T12:04:00.000Z",
        "qn_592":1.0,
        "atmo_lberg":null,
        "fd_lberg":72.0,
        "fg_lberg":292.0,
        "sd_lberg":60.0,
        "zenit":33.15,
        "true_local_time":"2020-05-31T13:00:00.000Z"
    },
    {
        "station_id":662,
        "date":"2020-05-31T12:00:00.000Z",
        "end_of_interval":"2020-05-31T12:16:00.000Z",
        "qn_592":1.0,
        "atmo_lberg":123.0,
        "fd_lberg":139.0,
        "fg_lberg":286.0,
        "sd_lberg":46.0,
        "zenit":30.82,
        "true_local_time":"2020-05-31T13:00:00.000Z"
    }
]

cc @wetterfrosch


Provide a main.py for the package

By providing a __main__.py file in the cookiecutter package it allows for python.exe -m cookiecutter to work (and the entry point can then simply point at the __main__ module). I would be happy to provide a PR for this if you're amenable to the addition.

👍 from me

👍

That's enough votes. :smile: . I'll see if I can get a PR created tomorrow.


Add id to RequestInput and propagate as ExecutionId

Right now, GraphQL populates ExecutionInput with ExecutionId which are generated with UUID.randomUUID().toString(). This call is known to be blocking and could cause issues for our reactive variant.
In the Spring WebFlux variant, we are already setting a custom id on the WebInput using request.exchange().getRequest().getId() (see WebFlux reference docs). As for the Spring MVC one, we're not setting anything currently.
With this issue, we should ensure that we're getting a consistent experience and:

use the WebInput logging id as the execution id
use a custom ExecutionIdProvider strategy that uses the same format as WebFlux - this will be used as a default if no execution id has been set on the input

This has been partially solved with 2e4158c, but might need refining.
We're missing still the custom ExecutionIdProvider implementation. Looking at the method signature to implement, I'm wondering if and how we should replicate our current id generation strategy:
    /**
     * Allows provision of a unique identifier per query execution.
     *
     * @param query         the query to be executed
     * @param operationName thr name of the operation
     * @param context       the context object passed to the query
     *
     * @return a non null {@link ExecutionId}
     */
    ExecutionId provide(String query, String operationName, Object context);

Currently, we're using ObjectUtils.getIdentityHexString(input) (input being the underlying transport request) in many places to generate an id - can we do the same or something close given the method inputs? Without this custom strategy set on the engine, ExecutionInput are getting UUIDs from the default provider.

These last commits changed the original intent of this issue.
Now, the "id" attribute is required for both WebInput and RequestInput - it is automatically propagated as an ExecutionId for the ExecutionInput. There is no need for a specific ExecutionIdProvider as a result, since it only acts as backup solution if no id was set.
We are still reusing the id available from the transport if available, or fall back to an id generated internally with an IdGenerator.

@bclozel I am seriously concerned by the following line:
https://github.com/spring-projects/spring-graphql/commit/2e4158cae8bfbc80c89249a81b69db0b38715e66#diff-872acff6e4aafcfc9ab78f6601d1f7476a25fc6158df13f5f64d435ae8359681R155
.executionId((this.id != null) ? ExecutionId.from(this.id) : null)

This may be an extreme corner case, but:

RequestInput is public (it can be extended)
getId() can be overridden but toExecutionInput() uses this.id. This behaviour is not described and seems confusing to me.
Tracing or metrics providers may (maybe unfairly) rely on the ExecutionId

In the Spring superclasses of RequestInput the getId() method is overriden with
return (super.getId() != null) ? super.getId() : ObjectUtils.getIdentityHexString(this);

(https://github.com/spring-projects/spring-graphql/commit/2e4158cae8bfbc80c89249a81b69db0b38715e66#diff-d89bed7b121d74aa22bd1b794a9775b669ae84e19a5990626b044daf29978888R99)
But this isn't used in the toExecutionInput() method, I think the method should be changed to:
String id = getId();
...
.executionId((id != null) ? ExecutionId.from(id) : ObjectUtils.getIdentityHexString(this));

Please LMK if I should open a new issue or even a PR.

I see the line has been changed to
.executionId(ExecutionId.from(this.id))

and there is a non-null assertion
https://github.com/spring-projects/spring-graphql/blob/main/spring-graphql/src/main/java/org/springframework/graphql/RequestInput.java#L159
I am still of the opinion that we should use getId() instead

@jord1e, RequestInput  is created internally, within the HTTP or WebSocket handlers and it's not meant (not at all convenient) to be extended. If you want to change anything in the ExecutionInput, the intended hook is RequestInput#configureExecutionInput.


Update PYPI_ENDPOINT to use https

Using http seems to cause a ProtocolError
xmlrpclib.ProtocolError: <ProtocolError for pypi.python.org/pypi: 403 Must access using HTTPS instead of HTTP>

Changing the endpoint to https:// instead of http:// seems to work. Possibly the PyPI website has been changed to allow https requests only.

Fixed with c9fff6d562f3649399b74d4cc62e00041db80cee.
Thanks for the heads-up. :) And sorry for the long delay.


CVE RUSTSEC-2024-0320 yaml-rust is unmaintained; Consider using a maintained alternative

Hi,
I am learning Rust (very early stages still) and, along with it, computer science. Because I want to be a good self-taught software engineer. I recently started exploring and learning about AppSec/DevSec and the importance of Securing the entire SDLC. Among other "findings" (tools, websites, guidelines and so forth), I just found out about RustSec.
Because I love learning by both studying and doing, I have an itch to scratch app that I will (knock knock) start coding as soon as I finish The Book and Rust in Action. That said, I have already researched the tools and crates I will be using. One of them is rusti18n which depends on serde. So today, out of curiosity I ran cargo audit (from RustSec) and found out about https://rustsec.org/advisories/RUSTSEC-2024-0320 impacting this very project.
I believe it would be beneficial if rusti18n could adopt the proposed resolution of that CVE: switching to a maintained package.
Please and thank you

Serde does not depend on yaml-rust, so this issue has nothing to do with this repo. If there is some library in your dependency graph that depends on yaml-rust, you would need to report the issue to that library's repo.

hi @dtolnay , my bad. I may have misread the output:
╰─❯ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 630 security advisories (from /Users/andreacfromtheapp/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (458 crate dependencies)
Crate:     yaml-rust
Version:   0.4.5
Warning:   unmaintained
Title:     yaml-rust is unmaintained.
Date:      2024-03-20
ID:        RUSTSEC-2024-0320
URL:       https://rustsec.org/advisories/RUSTSEC-2024-0320
Dependency tree:
yaml-rust 0.4.5
└── serde_yaml 0.8.26
    ├── rust-i18n-support 3.0.1
    │   ├── rust-i18n-macro 3.0.0
    │   │   └── rust-i18n 3.0.1
    │   │       └── crab_news 0.1.0
    │   └── rust-i18n 3.0.1
    └── rust-i18n-macro 3.0.0

warning: 1 allowed warning found

is serde_yaml a different package then?
sorry!

I answer my own: yes it is and it is deprecated.

Hi @dtolnay,
I was thinking about this issue and it must have come across badly. Besides the mistake of not making sure about the dependency, I only had good intentions. That said, my apologies if this has annoyed/offended you in any way.
Cheers


Hermes: infer derivation path from address_type

Would it make sense to have hermes use the right derivation path (by default) based on the chain config address_type = { derivation = 'evmos', ...? For eg. m/44'/118'/0'/0/0 for cosmos and m/44'/60'/0'/0/0 for evmos?
Originally posted by @hu55a1n1 in https://github.com/informalsystems/ibc-rs/pull/1794#discussion_r788628858
For instance, Hermes could automatically infer that it should use derivation path m/44'/118'/0'/0/0 for cosmos and m/44'/60'/0'/0/0 for Ethermint keys.

Copying @Farhad-Shabani as potentially interesting.


Name is undefined.

When both testing and running the npm module myself MainStat returns name as undefined. Everything else is returned except for the Name which is undefined.
Your goal is to fix it :D And by fixing it you score a PR. Also i get to test if I have set up CircleCi properly.
Happy Hunting

Hello, willing to work on this !

ah sorry @jeromechrist, forgot to comment when I started working on this. @MatejMecka You can accept his PR,I don't need more Hacktoberfest PRs 😄

Thanks @kristinn93 also sorry @jeromechrist :(

@MatejMecka @kristinn93 ha, np ! you may want to grab the call to mocha https://github.com/jeromechrist/HacktoberfestStats/blob/db0b9db57fa7afc47ee01d3b3ee48dfaa6d26127/package.json#L7
npm test was failing for me with the previous call to ./node_modules/mocha/bin/mocha
peace !

@jeromechrist just out of curiosity what os are you running ?

@kristinn93 Windows 10

@jeromechrist ah could explain why it works fine on mac


definition is created for wrong DTO

I Have a controller which extends from a base controller. Base controller defines
a Property called AgsDal of type IAgsDal
In a child controller this code:
[HttpPost]
public DumbResponse Post(DrrRequest ddr)
{
	return new DumbResponse();
}

definition that's created is not for DrrRequest but for the property AgsDal:
In service.paths.operations.parameters.schema: "$ref": "#/definitions/IAgsDal"
and in definitions I have an entry for IAgsDal.
There are other properties which also included in definitions and I remove them specifically just before schema is generated. But the DrrRequest param is definitly not included under the path to Post operation.
Included packages from yesterday:
  <package id="NJsonSchema" version="2.13.5966.35759" targetFramework="net452" />
  <package id="NJsonSchema.CodeGeneration" version="2.13.5966.35760" targetFramework="net452" />
  <package id="NSwag.CodeGeneration" version="2.14.5966.37461" targetFramework="net452" />
  <package id="NSwag.Core" version="2.14.5966.37461" targetFramework="net452" />

There was an update today, behaviour did nto change:
  <package id="NJsonSchema" version="2.14.5967.31319" targetFramework="net452" />
  <package id="NJsonSchema.CodeGeneration" version="2.14.5967.31320" targetFramework="net452" />
  <package id="NSwag.CodeGeneration" version="2.15.5967.33136" targetFramework="net452" />
  <package id="NSwag.Core" version="2.15.5967.33136" targetFramework="net452" />

It is included in owin self hosted webapi 2.2, controllers are provided with this op:
var settings = new WebApiAssemblyToSwaggerGeneratorSettings
			{
				AssemblyPath = GetType().Assembly.Location,
				DefaultUrlTemplate = "api/{controller}"
			};

			var controllers = AllAssemblies
					.Matching("Ags.")
					.And("Ra.")
					.SelectMany(x => x.GetTypes())
					.Where(x => typeof(BaseController).IsAssignableFrom(x) && ( x.Name != "BaseController" ))
					//.Where(x => typeof(ApiController).IsAssignableFrom(x))
					.Select(x => x.Name);

			var generator = new WebApiAssemblyToSwaggerGenerator(settings);
			var service = generator.GenerateForControllers(controllers.ToList());

Interesting thing is that after i changed those "Posts" to be "Put" it generated a Post request anyway.
and gave it an operation name "PushKey2_set_AmpService" which differs from the others"PushKey2_Put", "PushKey2_Ggget". So I am wondering maybe it's not a bug, but a feature? in which case how would I avoid this feature?
Thanks very much.

Very strange... and PushKey2_set_AmpService looks like it is generated for a property (set_AmpService is its setter...)
Can you provide a sample project where I can reproduce the problem?

Sorry, I was not available for awhile. I'll set something up tomorow.

Hi Rico,
I've uploaded kind of barebone self hosted project which does not have any injections,etc. hosted on port 12348. MIddleware will generate result if it has word "swagger" in path. "WhateverController" contains a public property called "Bla" and that "Bla" was included in generated result. If this property is not made public then it (correctly) does not get included.
sample: https://github.com/rallister/nswagtest.git
result here : swagger.zip
Thanks for looking at it.

Strange, but GetRuntimeMethods() also returns property getter and setter methods... fixed in https://github.com/NSwag/NSwag/commit/fda203b18d4e7d84367f54d08901030dc2f2826b

v2.23

Please reopen issue if problem still exists. Thanks for using NSwag