Enhancement: Export hidden columns

Added exportHidden boolean which exports hidden columns to csv if flagged true.
Helps when screen real-estate is tight, but you still want to export all the underlying data.
exportHidden (bool) default:false

@mph006, you can apply export={true} on TableHeaderColumn for exporting hidden column. I think this is what you want :)

@AllenFang Yep...that did it. Somehow I missed that in the docs. Thanks!

@mph006, that's ok, you did a great job. Thanks your contribution 👍


Housekeeping

While working on batching DOM ops, these things caught my eye, so I figured I'd factor them out since they're pretty safe and unrelated.
cc: @jerone

One small change, other then that I'm +1 on merging.

I merged #162 & #161 which cleaned up some tings too, resulting in (small) merge conflict here.

Rebased and fixed conflicts. Will merge once the tests are done.

@cakecatz The change in this PR to rename the private property toolBar to toolBarView results in an error at flex-tool-bar. I noticed this commit from you needing that property. There was no issue attached to it, so I was wondering why you need that property? Maybe we can fix it differently.


[#1942] fix: remove useless config filling for MemoryConnectorAdapter

What changes were proposed in this pull request?

fix useless config filling for MemoryConnectorAdapter

Why are the changes needed?
Fix: #1942
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
No

@yuqi1129 @diqiu50 Could you help me review this pr?


Update to version 3.6 of the SPDX license list

This PR updates the license list to version 3.6, and bumps the appropriate version numbers throughout metadata and documentation.
Full Disclosure: Two licenses that I worked on, Parity-6.0.0 and BlueOak-1.0.0, were identified by SPDX in version 3.6. I am a member of Blue Oak Council and the sole member-manager of Artless Devices, the company behind License Zero, which stewards Parity.

Hi @wking, do you have time to look at this? If not, I'm happy to review and publish a new version, I just don't want to step on your toes :)

Thanks, @carols10cents!

I've been super-busy, feel free to take it away ;)

Looks great, thank you so much! I will have a new version published in a bit, and then I will work on updating crates.io.

Thanks again, @carols10cents!


Add .pylintrc and .pep8

after creating the project, i tried to run prospector -s veryhigh  ( pip install prospector ) which runs pylint, pep8 and a bunch of other tools.
Had to add .pylintrc and .pep8 to match the project conventions, here is what i got in .pep8

[pep8]
max-line-length = 120
exclude=/migrations/

and .pylintrc

[MASTER]
ignore=migrations
[FORMAT]
max-line-length=120
[MESSAGES CONTROL]
disable=missing-docstring,invalid-name
[DESIGN]
max-parents=13

I would probably add disable=no-init,too-few-public-methods too, to eliminate most of the false positives.

Actually i found prospector was not loading all the plugins properly, see https://github.com/landscapeio/prospector/pull/134
Once this is addressed, the following .pylintrc is sufficient, and results in a  clean check when run with prospector -F -s veryhigh

[MASTER]
load-plugins=pylint_common,pylint_django,pylint_celery
[FORMAT]
max-line-length=120
[MESSAGES CONTROL]
disable=missing-docstring,invalid-name,locally-disabled
[DESIGN]
max-parents=13

I can do this unless you want to open a pull request and get credit?

I have a PR open here https://github.com/pydanny/cookiecutter-django/pull/283

Merged. Thanks much @kaidokert.


Unable to install with setuptools 58+

Thr use_2to3 option was removed from setuptools v58.0.0.

issue is solved in latest v1.3.2


unpack-assign-to-memoryview crashes cython

$ cat /etc/*-release | grep \^NAME; python --version; cython --version
NAME="Arch Linux"
Python 3.5.2
Cython version 0.24.1

In the code below, you can think of y as a one-tuple that contains an element that can be assigned to a memoryview slice, e.g. a single integer, or another integer array.
$ cat foo.pyx && cythonize -b foo.pyx >/dev/null && python -c 'import foo'
def assign(int[:] x, object y):
    x[:], = y
Traceback (most recent call last):
  File "/usr/bin/cythonize", line 9, in <module>
    load_entry_point('Cython==0.24.1', 'console_scripts', 'cythonize')()
  File "/usr/lib/python3.5/site-packages/Cython/Build/Cythonize.py", line 196, in main
    cython_compile(path, options)
  File "/usr/lib/python3.5/site-packages/Cython/Build/Cythonize.py", line 90, in cython_compile
    **options.options)
  File "/usr/lib/python3.5/site-packages/Cython/Build/Dependencies.py", line 915, in cythonize
    cythonize_one(*args)
  File "/usr/lib/python3.5/site-packages/Cython/Build/Dependencies.py", line 1020, in cythonize_one
    result = compile([pyx_file], options)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Main.py", line 690, in compile
    return compile_multiple(source, options)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Main.py", line 668, in compile_multiple
    result = run_pipeline(source, options, context=context)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Main.py", line 495, in run_pipeline
    err, enddata = Pipeline.run_pipeline(pipeline, source)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Pipeline.py", line 365, in run_pipeline
    data = phase(data)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Pipeline.py", line 53, in generate_pyx_code_stage
    module_node.process_implementation(options, result)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/ModuleNode.py", line 131, in process_implementation
    self.generate_c_code(env, options, result)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/ModuleNode.py", line 359, in generate_c_code
    self.body.generate_function_definitions(env, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 435, in generate_function_definitions
    stat.generate_function_definitions(env, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 3067, in generate_function_definitions
    FuncDefNode.generate_function_definitions(self, env, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 1944, in generate_function_definitions
    self.generate_function_body(env, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 1698, in generate_function_body
    self.body.generate_execution_code(code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 441, in generate_execution_code
    stat.generate_execution_code(code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 4787, in generate_execution_code
    self.generate_assignment_code(code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/Nodes.py", line 5084, in generate_assignment_code
    self.lhs.generate_assignment_code(self.rhs, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/ExprNodes.py", line 6945, in generate_assignment_code
    self.generate_parallel_assignment_code(rhs, code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/ExprNodes.py", line 6980, in generate_parallel_assignment_code
    self.coerced_unpacked_items[i], code)
  File "/usr/lib/python3.5/site-packages/Cython/Compiler/ExprNodes.py", line 4250, in generate_assignment_code
    self.generate_memoryviewslice_setslice_code(rhs, code)
AttributeError: 'MemoryViewSliceNode' object has no attribute 'generate_memoryviewslice_setslice_code'

(Initially reported (a while ago) on cython-users.)

I am running into the same AttributeError message. Has there been any update on this?


More interface compilation fixes

What I did
More work on #495 - source files in subdirectories within interfaces/ weren't compiling properly.
How I Did it
All previous efforts were using streamlined compilation logic to handle one file at a time and only generate an ABI. This time I've used the same logic as actual contract compilation, so hopefully there won't be any further issues.
How to Verify
Run tests. I added some new test cases.

Codecov Report

Merging #498 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   88.33%   88.36%   +0.03%
==========================================
  Files          56       56
  Lines        6105     6104       -1
  Branches     1343     1348       +5
==========================================
+ Hits         5393     5394       +1
+ Misses        490      488       -2
  Partials      222      222

Impacted Files
Coverage Δ

brownie/project/compiler/__init__.py
92.68% <100.00%> (+0.68%)
:arrow_up:

brownie/project/main.py
89.90% <100.00%> (-0.34%)
:arrow_down:

brownie/project/compiler/vyper.py
94.69% <0.00%> (+1.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596099f...4b3bbfc. Read the comment docs.


Thanks for this awesome library! As I was playing around with the demo page, I had to search through the source code to find which props to set in order to get certain functionality to work (for example, scaleX and scaleY for the Group component).
Is adding more documentation for the API already on the project roadmap or would you accept a PR for this? Thanks!

I would also appreciate some documentation. Because I managed to handle the basics stuffs. But I have now some more advanced needs and I'm having a hard time :-(

+1, I was just wondering where to find the documentation, or it just did not have one...😅  Cause it would be to hard to use without documentation...


Add the option to specify a token

Now that GitHub supports OIDC authentication with GCP, it would be great if we could specify the OIDC token as a flag instead of the credentials file.
I'm happy to work on a PR for this, I'd be in favour of doing a major version bump and removing the credentials file support altogether seeing as the service account authentication with the GCP Auth action is deprecated.
The new workflow would look something like this.
- name: Authenticate to Google Cloud
  id: auth
  uses<EMAIL_ADDRESS>  with:
    token_format: access_token
    workload_identity_provider: WORKLOAD_IDENTITY_PROVIDER
    service_account: SERVICE_ACCOUNT
- name: Start CloudSQL Proxy
  uses: ahmadnassri/action-google-cloud-sql-proxy@v2
  with:
    token: ${{ steps.auth.outputs.access_token }}
    connection: ${{ inputs.database-instance-name }}
    port: 5432

You can find the quick and dirty changes I made to my fork to test it and it appears to be working fine.
Cheers!

is your fork still up? the link does not work

Hey @ahmadnassri, my apologies the fork was moved here.

thx, I'll review and merge into this repo.


Browser Plugin - on pop state error handling

I was experimenting with canDeactivate handlers and noticed some behaviour I couldn't understand. On CANNOT_DEACTIVATE errors which were caused after a popstate event by pressing the browser back button, the URL in the browser changed according to the history entry and - as expected  - the router state didn't change because the transition didn't pass the canDeactivate handler. So the router state and the browser url were not in sync anymore.
I looked through the code and correct me if I'm wrong but usually the error object in Router5 code base has always two properties code and segment but in the browser module at line 70 the error is compared to a string constant from errorCodes.CANNOT_DEACTIVATE and the code in that if block is never executed?
Should't the condition be something like that? if(err.code === errorCodes.CANNOT_DEACTIVATE) { ... }
BTW: Very nice work you've done here. Well written code, easy to read and easy to understand! Thanks to you and all contributors!

Hi @olegomon,
Will look at it when I have a bit more time (busy moving house just now). Thanks for your kind words! :+1:
On a side note, canDeactivate and browserPlugin are not good friends, because history popstate events are not cancellable (I recommend using forceDeactivate: true in browser plugin options).


Prepare cloud provider to be included with Kubernetes

Quote from https://groups.google.com/forum/?hl=en#!topic/kubernetes-sig-architecture/soeIadIeMCs :

I did want to shed some more light on the pre-requisites for cloud providers that we have established so far (based on KEP-4 ):

provider has external repo with working out-of-tree cloud provider implementation
there are real user experience reports for that cloud provider
provider is reporting test grid results based on KEP-18
provider has docs based on KEP-19
tech leads of the subproject are members of the Kubernetes org (showing a level of commitment to the Kubernetes ecosystem)

Much of the wording in those documents is obsolete or irrelevant for external cloud providers.
However, there seems to be a general standard for testing and documentation. Investigate what/if anything needs to be addressed for inclusion of the CCM as an "official" cloud-provider SIG project.

This issue is mostly obsolete now, as the Apache project will oversee development of the CloudStack provider. Inclusion within Kubernetes will be limited to mention in the documentation.


Remove stale bot

...as it has been firing continuously on various issues and PRs since the last commit, while the maintainer hasn't responded to any of them.
Proposed Changes
For the main home assistant repo, adding a stale bot to reduce/reap issues on problems that have "likely" been fixed in a recent release is understandable, however, in this repo, where there are multiple issues that are tracked consistently between PRs and other issues, a stale bot just risks each legitimate issue from being closed pre-emptively.
What's worse, is that there has been no maintainer activity since September 2022, about 4 months, where the stale bot poised to reap many issues that the maintainer promised to address, but has not on the meantime.
An alternative solution to this would be for the maintainer to add the no-stale label to all of the mentioned issues, or the issues that they care about explicitly / have shown interest in. The label that does this is defined here.
Related Issues

https://github.com/hassio-addons/addon-tailscale/issues/120
https://github.com/hassio-addons/addon-tailscale/issues/96
https://github.com/hassio-addons/addon-tailscale/issues/119
https://github.com/hassio-addons/addon-tailscale/issues/62
https://github.com/hassio-addons/addon-tailscale/issues/124
https://github.com/hassio-addons/addon-tailscale/pull/89
https://github.com/hassio-addons/addon-tailscale/pull/122

All of these issues have been marked as stale, while the maintainer has had no time to address them, while all of them are legitimate issues.
Previous version: https://github.com/hassio-addons/addon-tailscale/pull/110
@frenck this is why i originally proposed this, this is not a "difference of opinion", unless your 'opinion' on this is that it's better to let legitimate issues languish and auto-close than it is to let them sit there until someone addresses them. Then that is not maintenance, that's negligence.
If you don't have time to maintain this addon, please delegate it to someone else, or pause/defer maintenance by preventing this bot from reaping legitimate issues.

Won't be removing stale bot. Thanks for your suggestion though.
../Frenck

@frenck then at least address the other issues, you're letting a bunch of issues rot stale while you yourself have said that you're interested in solving them, add a no-stale label to them then.
You're solving nothing by closing this.
If you cannot maintain this addon, find someone else to let maintain it, i'd volunteer.

then at least address the other issues

I have over 600 tasks in my github inbox list, besides my personal tasks. Things take time.

You're solving nothing by closing this.

Well... To be fair, merging this would solve anything either. If anything, this PR wasted more of my time.

If you cannot maintain this addon, find someone else to let maintain it, i'd volunteer.

Good. Will consider it someday.
../Frenck

To be fair, merging this wouldn't solve anything either.

It would solve the problem of legitimate issues languishing in this repository, which would come up again, again and again, which wastes everyone's time involved, and potentially hides problems that people once cared about, and now not anymore, because you clearly don't care for their respect by not considering your own limits with these repositories, letting their issues rot away, without any response.
You're managing all these repos on your own, without delegation, and apparantly without a real will to want to manage them in the first place. Find someone who wants to do this job, then.

Please see my previous answer.
Thanks 👍
../Frenck

You clearly haven't read mine.

I did. Could you now stop? Thanks 👍
../Frenck

So let me just re-iterate then; you're completely fine with all the issues here in this repo being closed for being "stale", while you yourself have no time to address them all in due time (before them going stale), thereby basically nullifying any valid issue that people might come up with here?

See my answers above.
I asked you to stop, which you just ignore. This is now hindering progress on anything and just becoming annoying.
../Frenck

I've considered your request for me to stop as much as you've considered the questions i put up

🤷 I asked nicely.
../Frenck


Update inf-addcomponent-directive.md

Removing DisplayName from the component section.

@NabilFates,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Locked Up a Few Times

 is a comment.
You will see these throughout the issue template. Make sure you do not type your comments
between these characters or we will not be able to see what you wrote!

4. Links
To create a hyperlink, type the [text you want to link](followed by the url in parenthesis)
-->
Describe the bug
My lights became unresponsive. Only solution I've found is to restart the addon
Steps to Reproduce

Unsure. Just seems to happen after a while
Expected behavior

Lights should function properly
Logs

    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable
2022-10-15 20:40:40,466 DEBUG emulated_hue.apiv1 -- [<IP_ADDRESS>] GET /api/mIp6SmaWQu2u-vWKbDOvl42pgadTn5hewY44t4Y4/lights
2022-10-15 20:40:40,468 ERROR aiohttp.server -- Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/app/emulated_hue/apiv1.py", line 72, in wrapped_func
    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable
2022-10-15 20:40:41,936 DEBUG emulated_hue.apiv1 -- [<IP_ADDRESS>] GET /api/mIp6SmaWQu2u-vWKbDOvl42pgadTn5hewY44t4Y4/lights
2022-10-15 20:40:41,940 ERROR aiohttp.server -- Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/app/emulated_hue/apiv1.py", line 72, in wrapped_func
    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable
2022-10-15 20:41:43,572 DEBUG emulated_hue.apiv1 -- [<IP_ADDRESS>] GET /api/mIp6SmaWQu2u-vWKbDOvl42pgadTn5hewY44t4Y4/lights
2022-10-15 20:41:43,573 ERROR aiohttp.server -- Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/app/emulated_hue/apiv1.py", line 72, in wrapped_func
    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable
2022-10-15 20:41:45,046 DEBUG emulated_hue.apiv1 -- [<IP_ADDRESS>] GET /api/mIp6SmaWQu2u-vWKbDOvl42pgadTn5hewY44t4Y4/lights
2022-10-15 20:41:45,048 ERROR aiohttp.server -- Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/app/emulated_hue/apiv1.py", line 72, in wrapped_func
    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable
2022-10-15 20:41:46,510 DEBUG emulated_hue.apiv1 -- [<IP_ADDRESS>] GET /api/mIp6SmaWQu2u-vWKbDOvl42pgadTn5hewY44t4Y4/lights
2022-10-15 20:41:46,513 ERROR aiohttp.server -- Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/app/emulated_hue/apiv1.py", line 72, in wrapped_func
    return await func(cls, request)
  File "/app/emulated_hue/apiv1.py", line 145, in async_get_lights
    return send_json_response(await self.__async_get_all_lights())
  File "/app/emulated_hue/apiv1.py", line 780, in __async_get_all_lights
    for entity_id in self.ctl.controller_hass.get_entities():
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in get_entities
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
  File "/app/emulated_hue/controllers/homeassistant.py", line 115, in <listcomp>
    return [entity["entity_id"] for entity in self.items_by_domain(domain)]
TypeError: 'NoneType' object is not subscriptable

Hardware Info:

Architecture (Ex: x86, ARM): ARM
Addon version (Ex: stable or dev):  dev

Value of "tag_commit_or_branch" if using dev:

OS (Ex: Windows 10, Ubuntu Buster):  HAOS
Hardware (Ex: PC, Raspberry Pi 1/2/3/Zero):  rPi 4

Additional context

I think this should fix it. Can you give it a try? fix/issue/354

I installed it. I don't actually know how to reproduce the issue, just seemed to happen over time, so I'll just let it sit for a week or two and report back.


Do not hardcode merchant name in email subject

It's quite inconvenient that merchant's name is hardcoded in email's
subject especially given the flexibility of per-tenant email templates.
It's quite easy to substitute it yourself during the configuration of
the plugin, but you have to remove the hardcoded value first.

Makes sense!

Thanks a lot! Any chance to have a release soon? 🙏

Done!


How to open TCP and UDP ports for asp.net core Azure Appservice deployment?

I've got an asp.net core app deployed to as Azure Appservice. The web pages run without issues, but on Azure, the TCP and UDP port, where the app is listening too, are unreachable from outside so that clients cannot connect.
I cannot find any information how to resolve this. TCP 55556 and UDP 55555 must be reached from outside.
Also, I don't see any other fitting hosting opportunity I can use. E.g. Azure Cloud Service/Web Role seems not to work with asp.net core.
What can I do? How do I get the ports reachable?
ty!

Closing this as external - nothing to do with ASP.NET Core, but more an "AppServices" question.
cc @davidebbo in case he has a recommendation where to file this.  My recommendation is StackOverflow.


Blur and faint background image on bottom of trailers.

Bug Description
All of my videos/trailers have a portion of the bottom blurred. For some games, when playing a trailer I can see part of the background bleeding through the video. Is there an option to fix this?
To Reproduce
No response
Extensions log
No response
Screenshots
No response

Could you show me a screenshot? I know exactly what you mean but I'm curious to see which way you personalized your theme so it make your background bleed through your video, for me is very faint, like almost unnoticeable.
You could try these  2 options in the ThemeModifier constants menu as these will change the blur effect in the background. Please let me know if those 2 options makes a difference for you. (for the "Bleeding part")

If I remove the blur effect by setting "grid view background blur effect height" to max, I get what's in the attached image. Is there a way to get both the trailer and background to cover the same amount of space so that the background image does not show when the trailer is playing?

It looks like they are the same size actually, the background image just bleeds through the video at the bottom.

I already have that setting disabled in Playnite settings. It doesn't fix the issue with the setting enabled or disabled.

I added a trigger to the background image visibility to be disabled when a video is visible. Done in v3.95, the update will be released soon, It should fix this problem!

Update v3.95 completely fixed this issue. It looks really good now. I appreciate you working on a fix really fast. Your theme is amazing!

Its my pleasure, thank you!


Certificates from KeyVault instead of uploading them to Batch

Feature Request Description
Batch should support getting the Certificates from a KeyVault instead of uploading them to Batch
This will reduce the duplication in Certificate management and secret rotation
Describe Preferred Solution
Batch should provide the surface to register certs as (keyvault, certname) with the batch account and store that associated with a moniker
Certificate references should be via moniker not via thumbprint as the thumbprint changes during secret rotation
The access to keyvault could be via the managed identity of the batch account, similar to the ADFv2 setup.
Describe Alternatives Considered
Upload to a KeyVault associated with the batch, but that would not help with rotation and propagation. Would be just another hop in chain. But would be similar to the autostorage.
Additional Context
Certificates need rotation, and that is usually done directly via KeyVault
Currently certificates are uploaded to Batch via own API and then consumed via references in pools
When a certificate is rotates, one need to go add the new cert (new thumbprint) and also remove old certificates.

Could consider using the Keyvault for credentials and secrets like the ones in MountConfiguration

Although no timelines can be shared at this point, we are actively working in conjunction with the Azure Identity team to deliver a solution for this using Managed Identity.

You can now create pools with Managed Identities: https://docs.microsoft.com/azure/batch/managed-identity-pools
We have a preview feature that allows you to add certain VM extensions to pools, including KeyVault VM extension: https://docs.microsoft.com/azure/batch/create-pool-extensions
Using both together should allow your use case. Note that the VM extension on pools needs to be enabled on your account since it's not yet GA. Please raise a support ticket to enable the feature.


How to give commands to Docker through the shell using Python script

Hey,
I am writing a script of python which would run the docker first of the SSD model then change the directory into the SSD directory and then run my trained model for inference.
I am able to run the docker but unable to commands into through the python subprocess module. Any idea how to solve this issue
Thanks in Advance
Code I wrote till now :
import os
import subprocess
os.chdir("jetson-inference")
#os.system("docker/run.sh")
#os.chdir("python/training/detection/ssd")
subprocess.call([
'docker/run.sh', 'cd ./python/training/detection/ssd'
])

Hi @saifurrehman4114, try using the -r option to docker/run.sh for the command that you want to run:
https://github.com/dusty-nv/jetson-inference/blob/19ed62150b3e9499bad2ed6be1960dd38002bb7d/docker/run.sh#L34
subprocess.call([
'docker/run.sh -r detectnet.py --model=python/training/detection/ssd/models/my_model.onnx'
], shell=True)

Thanks  @dusty-nv   it worked!!!


Document how to handle TLEs with poliastro

On #1185 it became clear that we should better document how to properly handle TLEs and other General Perturbations orbital data, like OMMs, in poliastro. By the way, tle is among the most searched term in our documentation, and it's not mentioned even once❗

Ideally, we should write a How-to (more practical) and a Background section (with an expanded version of this explanation https://github.com/poliastro/poliastro/issues/1185#issuecomment-830601802)

An Ephem.from_tle would be perfect!!

Added some notes about potential APIs https://github.com/poliastro/poliastro/wiki/Notes-about-TLEs

Started to add some of these ideas to https://github.com/poliastro/poliastro/pull/1418 and dumped more notes to the wiki

Closing this issue, which was about documenting TLEs in poliastro. Will open a new one for actually adding relevant APIs, which will take a bit more effort.


Annoying autocomplete on Firefox mobile

URL
No response
How to reproduce the issue?
When inserting tags on Firefox mobile the autocomplete function makes this task difficult: you can't write without triggering the autocomplete to complete with the first option.
Screenshot(s) or anything else?
No response
Which iD Editor versions do you see the issue on?
No response
Which browsers are you seeing this problem on?
Firefox

I am finding this to be an issue in any browser. Is there a chance that filling in the text box could be disabled?


BUG: optimize.root_scalar: let bracket be passed as a NumPy array

What does this implement/fix?
The method used by root_scalar depends on the optional arguments passed to the function. Whether bracket is passed is tested by evaluating its truthiness. That raises a ValueError if bracket is passed as a numpy array:
ValueError: The truth value of an array with more than one element is ambiguous.
This commit fixes this by testing bracket against None, and adds a simple test to check that the root obtained when passing bracket as an array is correct.
Additional information

A check was already in place within root_scalar to verify bracket is a list, tuple, or np.ndarray, which led me to believe passing the parameter as a np.ndarray should be accepted by this function.

this looks correct to me, although I'm not sure whether the documented type "sequence" has a more precise meaning historically.

Thanks @tartopohm .


Migration to HttpClient5

Driven by pure curiosity, I was wondering if you could shed some light on when Athenz might be planning to transition to HttpClient5, should such information be available. The reason behind my inquiry is that, as of version 3.1, SpringBoot has removed its dependency on HttpClient4. Subsequently, I anticipate that other Open Source Software (OSS) currently using HttpClient4 will also gradually transition.
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.1-Release-Notes
In the case of Athenz, I noticed that there are parts of the code generated by RDL which are dependent on HttpClient4. Therefore, I presume that the transition to HttpClient5 for Athenz might only happen after RDL has been updated to support HttpClient5. However, if there are any specific plans around this, I would greatly appreciate if you could share them.

At this point we have no plans to migrate to HttpClient5. We're not necessarily looking for any new features that may only exist in 5 and 4 is still supported as far as major defects and security bugs. I'm thinking whenever HttpClient4 is announced as EOL then we'll migrate to HttpClient5.

Thank you for your response. I will close this issue now.


Regression :  GDB/JIT symbols required to bind to debugger must be exported on Windows so debugger can bind.

crates/runtime/src/helpers.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/crates/runtime/src/helpers.c b/crates/runtime/src/helpers.c
index 4865928a1..c743e244e 100644
--- a/crates/runtime/src/helpers.c
+++ b/crates/runtime/src/helpers.c
@@ -42,7 +42,12 @@ void wasmtime_longjmp(void *JmpBuf) {
// Note the weak linkage here, though, which is intended to let other code
// override this symbol if it's defined elsewhere, since this definition doesn't
// matter.
-#ifndef CFG_TARGET_OS_windows
+
+
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
attribute((weak, noinline))
#endif
void __jit_debug_register_code() {
@@ -61,7 +66,10 @@ struct JITDescriptor {
// Note the weak linkage here which is the same purpose as above. We want to
// let other runtimes be able to override this since our own definition isn't
// important.
-#ifndef CFG_TARGET_OS_windows
+#ifdef CFG_TARGET_OS_windows
+// ADV_SW_PATCH - export required for external access.
+__declspec(dllexport)
+#else
attribute((weak))
#endif
struct JITDescriptor __jit_debug_descriptor = {1, 0, NULL, NULL};

Fixed by https://github.com/bytecodealliance/wasmtime/pull/3373


Bugfix/issue 2708 map rect fail

Proposed fix to map_rect_concurrent.  @wds15 I tried updating the tests to do a range of shard sizes but I'm missing something about the combine step.  Currently I don't feel comfortable saying this is fixed unless we test a range of shard sizes.  It might make more sense to me if you explain the two checks in this test:
TEST_F(map_rect, concurrent_ragged_return_size_dd) {
  Eigen::VectorXd res1 = stan::math::map_rect<0, hard_work>(
      shared_params_d, job_params_d, x_r, x_i);

  EXPECT_EQ(res1.size(), 2 * N);

  x_i[1] = std::vector<int>(1, 1);

  Eigen::VectorXd res2 = stan::math::map_rect<1, hard_work>(
      shared_params_d, job_params_d, x_r, x_i);

  EXPECT_EQ(res2.size(), 2 * N + 1);
}

Checklist

[x] Math issue #1075

[x] Copyright holder: Krzysztof Sakrejda

[X] the basic tests are passing

[X] the code is written in idiomatic C++ and changes are documented in the doxygen

[X] the new changes are tested

I don't see math issue 1708.  Is this addressing #1075?

Fixed thanks.

The idea of these tests is to test if the returned ragged vector has the correct size. The first test is for a case where each job returns 2 elements and the second test is to check if things work if one job (the first one) returns 3 instead of 2 elements.

@wds15 can you answer my question up in the main PR description about the 'sizes' test? Why does changing the integer parameters (or running the command a second time with another id) increment the return size by 1? I'll look at it again now but if you have a quick answer to that question it would save me time with adding tests.

re: joint testing with MPI, I agree that's a good idea, would also be good to separate the job counting out into shared code between the two and use a simple thread pool here (it's not bad with c++1y).. I'm going to leave those for later as this is a bugfix PR.  Definitely want more tests, we should've tested for varying shard/thread numbers to begin with. :/

re: functor ok, no idea how I missed that, thanks.  I think I can do the tests now.

@syclik how is the number of threads set for testing? I think we should expand the tests by running the current tests with a range of STAN_NUM_THREADS values but that doesn't seem to be in the testing framework itself.  Is that set via Jenkins or something like that?

Have a look into the get num threads test. There the variable is set to different values.

@sakrejda I am very close to have a PR ready which would allow us to use the parallel STL from Intel as backend in addition to the async facility. This will give us nice speedups - in particular when jobs have unequal cpu needs as the Parallel STL from Intel can deal with this.
This PR would, of course, contain a fix for this issue as well. The downside that this entails a few more lines to review, but not very hard.
The Parallel STL from Intel is rather easy to install via their binary distribution on Mac...and there is even hope for Windows, I think.

uh... sorry to hear, but while not blessed with fever, I also do enjoy right now the season...

@wds15 I think we should keep this branch as a bugfix rather than letting it creep.  I'm happy to review the parallel STL updates on a separate feature PR, just trying to get this in asap esp. since I've been out.

There's still some segfault in here, with 5 shards and 4 threads.

This PR is not quote right yet, I think.
We can work on this one, but the other parallel STL one has all fixes and adequate tests.
If we continue this one, we should at least take over some pieces (like the test) from the parallel STL. However, the parallel STL PR is not too massive ... all I am doing there is to refactor map_rect_concurrent to use for_each from C++17 (and providing a C++11 implementation of that).

@wds15, please work on a fix first before any new improvements. Given that
this feature has lead to a major bug, this is high priority. And new
features will have to be evaluated carefully.
On Mon, Dec 17, 2018 at 8:48 AM wds15<EMAIL_ADDRESS>wrote:

This PR is not quote right yet, I think.
We can work on this one, but the other parallel STL one has all fixes and
adequate tests.
If we continue this one, we should at least take over some pieces (like
the test) from the parallel STL. However, the parallel STL PR is not too
massive ... all I am doing there is to refactor map_rect_concurrent to
use for_each from C++17 (and providing a C++11 implementation of that).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1079#issuecomment-447851480, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F21sllXAW6Cc-HDfWL-aVVYJrfAOks5u56CwgaJpZM4ZIeAw
.

@wds15 @syclik I'm closing this.  @wds15 Can you just take the relevant parts of the STL PR and do a new bugfix PR?

@sakrejda, thanks for letting me know. Feel better.
@wds15, agreed. If you've fixed it on a branch that has a new feature, please separate out the fix so we can patch the issue immediately.


object::stable_erase

Support for erasing an element without reordering. This is part one of support https://github.com/boostorg/json/issues/748, part two would be stable_insert.

impressive work :) you figured out how object is implemented...

@grisumbras I guess I have no objection to offering this feature. If the user wants to opt-in to preserving order at a computational cost, I can't see a downside. But its up to you, maybe there's something I haven't thought of? What does Peter think?

Thanks for the feature.


InitialViewControllerIndex doesn't work after assigning ViewControllers

Hi,
When settings the ViewControllers for an instance of YZSwipe, it will then set the selected VC based off the value of InitialViewControllerIndex. However, setting the index after setting the view controllers does not work and I think that's a bug because often the size of the array of viewcontrollers that you're plugging is indeterminate.
self.swipeBetweenVc.viewControllers = @[safetyPlanIndexVc, navCon1, navCon2, navCon3];     self.swipeBetweenVc.initialViewControllerIndex = 1;  does set the initial index whilst
    self.swipeBetweenVc.initialViewControllerIndex = 1; self.swipeBetweenVc.viewControllers = @[safetyPlanIndexVc, navCon1, navCon2, navCon3]; does work (but is weird).

You are right, that's weird. It's not a bug though. Have a look at the source code. Feel free to send me a pull request.

Try the latest version https://github.com/yichizhang/YZSwipeBetweenViewController/releases/tag/0.1.0


Build Error on Ubuntu 16

When building a Rust crate with tiny-keccak as a dependency, I received the following build error.
   Compiling tiny-keccak v1.4.1
     Running `rustc --crate-name tiny_keccak /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tiny-keccak-1.4.1/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=49d6f213a92cfbc2 -C extra-filename=-49d6f213a92cfbc2 --out-dir /home/ubuntu/whatever/target/debug/deps -L dependency=/home/ubuntu/whatever/target/debug/deps --extern crunchy=/home/ubuntu/whatever/target/debug/deps/libcrunchy-c57bfed60427bcc4.rlib --cap-lints allow`
error: Could not compile `tiny-keccak`.

Caused by:
  process didn't exit successfully: `rustc --crate-name tiny_keccak /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/tiny-keccak-1.4.1/src/lib.rs --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=49d6f213a92cfbc2 -C extra-filename=-49d6f213a92cfbc2 --out-dir /home/ubuntu/whatever/target/debug/deps -L dependency=/home/ubuntu/whatever/target/debug/deps --extern crunchy=/home/ubuntu/whatever/target/debug/deps/libcrunchy-c57bfed60427bcc4.rlib --cap-lints allow` (signal: 9, SIGKILL: kill)

This error occurred when building tiny-keccak on a fresh Ubuntu 16 EC2 instance.
Cargo.toml:
[dependencies]
tiny-keccak = "1.4.1"

Rust Version: rustc 1.27.0-nightly

@DrPeterVanNostrand I'm getting this issue now, did you find a solution?

Yup, for me it was the Linux out-of-memory process killer caused by the loop unrolling macros unroll!.  If you try to build the tiny-keccak crate and get the SIGILL caused by crunchy, you can check if the build process was killed by the Linux OOM killer by running:
grep -i kill /var/log/messages*

If you see something like the following, then you ran out of memory during the build process:
Out of Memory: Killed process <build PID>

When building anything using tiny-keccak on a small EC2 instance, I manually remove the unroll! macros and use that version in place of tiny-keccak in my Cargo.toml files. If you are not limited to using a small EC2 instance, try starting an instance with more RAM and rebuilding there.


cluster pre-provisioning for cluster-wide test

This is an Experiment with Mason. Once we are satisfied, we will update
all postsubmits to take advantage of this.

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
bff2252eff4435f76c86a81f36c5e8f1319b0dba
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-e2e

/test e2e-cluster_wide-auth

/lgtm


Update GitHub list

Added a bunch of GitHub userscripts to the list.
Added Microsoft Edge to Tampermonkey support list - reference.

Great @Mottie! Thanks for the input.


AttemptNumber should be set to 1 when login fails again after the loc…

…k windown is passed

Thanks. This makes a lot of sense at least on the outside :) LGTM

This fails tests. Can you please fix them in a separate PR?


Updating readme to refer docker compose code

Using the include directive to refer to the existing docker compose yml file in the complete project, instead of maintaining an incorrect copy.

Looks good to me!  Thank you for the contribution.


Set performance expectations in configure

If using docker native on OSX, we need to set a clear expectation that it is currently slow.

https://gist.github.com/Tolmark12/480b29f29d9f16cfe5bbcca2e1c94ea3


Lint problems don't show up in editor.

From @chenxsan on May 9, 2017 7:31
I'm running VSCode insider 1.13.0 on macOS 10.12.4.

As you can see in the gif, when we have Unexpected token (4, 1), there's no red mark inside the editor as other ranges.
Copied from original issue: Microsoft/vscode-eslint#236

This is a problem of the editor partly understandable.
Since line 4 has no character but eslint reports an error on [4,1] there is no character to underline. Moving to VS Code to discuss whether we can do something in the editor about it.

Interestingly, the decoration gets rendered with width 0. Perhaps I can expand them when rendering.

@alexandrudima thanks a lot!!

Doesn't seem work for empty lines. See the screenshot below, when I enable the rule no_consequtive empty lines.

Test case can be reproduced by adding the rule as shown above the test lint test project:
https://github.com/Microsoft/vscode-tslint
https://github.com/Microsoft/vscode-tslint/tree/master/tslint-tests

Good catch. In this case, the warning spans multiple lines and it is collapsed on each of those lines

Thanks! This gets me to < 10 open issues in tslint 😸


feat: run unit tests

Add Github actions:

Run unit tests
Test building

Yeah you can check the result here: https://github.com/time-loop/md-to-quill-delta/actions/runs/9254756551/job/25457181678?pr=14 @weiQuill


devicetree: memory-attr: Introduce DT_MEMORY_ATTR_FOREACH_STATUS_OKAY_NODE

Introduce a new DT_MEMORY_ATTR_FOREACH_STATUS_OKAY_NODE() macro and make the DT_MEMORY_ATTR_FOREACH_NODE() macro visiting disabled nodes as well.

DNM, working on a better version of this.

This would be a stable API change and therefore need to go through the process

Yeah, this won't be needed anymore anyway.

Yeah, this won't be needed anymore anyway.

Can it be closed, then?


Added section on deploying using docker

Pushing upstream some work done on multiple projects based on this repository.
Adds:

Documentation on the existence of Dockerfile
Adds Dockerfile to build container for easier deployment to Kubernetes, etc.
Adds docker-compose to allow testing of that repository.

Sorry for the long delay on this, and thanks for doing this work.
I'm afraid I don't know much about Docker, apart from that it's a bit like a VM but much lighter.
Could you explain a bit about what user need this meets, as opposed to deploying to Heroku?
Do you think this might work better as a fork? The kit is primarily aimed at helping people who only need a knowledge of HTML and CSS to get prototypes working, and online. You can see more in our principles:
https://github.com/alphagov/govuk_prototype_kit/blob/master/docs/principles.md

A rapidly emerging standard for hosting applications within the Home Office and other departments is Kubernetes and Docker. Docker being a application container deployment system, and Kubernetes a docker orchestration platform.
While occasionally we might host something in Heroku, the much preferred approach is to use the Shared digital services platform, which is based around those two technologies.
We are not alone in the introduction of this as a standard, a number of other government departments are also switching to Kubernetes or Docker based deployment systems.
Essentially this means we're already running our own internal PaaS (much like heroku) that it's very simply to deploy your own applications to (which is obviously a lot easier sell to product owners).
This dockerfile and associated documentation would essentially mean that any future prototypes are ready to run on our internal PaaS, whereas currently we have multiple projects essentially rewriting the same Dockerfile.

thanks! Another question - this line:
FROM quay.io/ukhomeofficedigital/nodejs:v0.2.1

is that specific to home office or will that work for everyone, and continue to do so?

It will work for everyone, it's one of our open source docker containers
On Wed, 23 Sep 2015 11:07 Joe Lanman<EMAIL_ADDRESS>wrote:

thanks! Another question - this line:
FROM quay.io/ukhomeofficedigital/nodejs:v0.2.1
is that specific to home office or will that work for everyone, and
continue to do so?
—
Reply to this email directly or view it on GitHub
https://github.com/alphagov/govuk_prototype_kit/pull/21#issuecomment-142553765
.

--
Billie Thompson
Software Developer
Purple Booth Ltd
Mob:<PHONE_NUMBER>6
Web: purplebooth.co.uk
Keybase: http://billie.codes/1NOw29c
LinkedIn: http://billie.codes/1KT8gcI
Twitter: http://billie.codes/1SGPMCw

thanks for this PR, but I'm going to close it - we just don't have the docker experience on the team to merge or maintain for now. Sorry!

That's fine! Thanks for your time anyway.


Embed chooser panel

First implementation https://github.com/torchbox/wagtail/issues/634 and reusable embeds in richtext fields.
Tags added as an Embed field but not yet implemented in the admin interface (could be useful I guess).
Edit link set to display: none; as the functionality is not ready yet (could be useful I guess).

Thanks @jordij
I really like the ability to search and choose a past embed! :+1:
Just checking, does this link to embeds by their URL or does it use a ForeignKey to Embed?

Yeah I thought it be useful. I still need to work in a couple of things
though, like the listing styles and the creation (haven't tested from the
chooserpanel, only from the richtext).
As per your question, it works with a ForeignKey, following the way Image
and Document work. Makes sense to you guys?
On Tuesday, July 28, 2015, Karl Hobley<EMAIL_ADDRESS>wrote:

Thanks @jordij https://github.com/jordij
I really like the ability to search and choose a past embed! [image: :+1:]
Just checking, does this link to embeds by their URL or does it use a
ForeignKey to Embed?
—
Reply to this email directly or view it on GitHub
https://github.com/torchbox/wagtail/pull/1553#issuecomment-125532683.

@jordij
I think it would be best if it used the URL (this is how they are stored in rich text and streamfield). This allows the Embed objects to be thrown away and Wagtail will automatically regenerate them (which is useful when you do configuration changes such as switch to using embedly and want your embeds to be consistent).

Sounds good. I'll revert to URL field instead of FK and commit the changes.

We like this, @jordij! Could you please add some tests and docs?

Cheers Tom, I'll be happy to add some tests&docs for this one and the other pending PR when I have some time :)

I sill need to work on this, sorry guys.

Hi there, I think this is almost ready. I have a question related to the max_width field of the Embed class:
class Meta:
        unique_together = ('url', 'max_width')
        verbose_name = _('Embed')

Why do we need the pair url-max_width to be unique? Shouldn't max_width only be passed as a parameter from the front-end but being excluded from the db? As we are reusing embed from multiple templates/pages it makes things easier to have one and only one Embed with a unique URL, regardless of max_width. Why do we wanna save max_width in the db?
Cheers :)

Thanks @jordij

Why do we need the pair url-max_width to be unique?

max_width is sent as a parameter to the oEmbed provider/Embedly. It's possible that the HTML code they send back for one width is different for another. We enforce uniqueness on both fields so it's possible to fetch the same embed in multiple widths (but, IIRC, if max_width is omitted the provider should return a responsive embed so this is probably not necessary for most people).

Then I think there's a bit of inconsistency since the relationship from a Page model to the Embed is done through the url field only and not with the id.
I've set an update of the max_width field each time the Embed is fetched from the front-end but doesn't look like the best solution as it prevents storing the same embed with different max_width values. IMHO It also would potentially cause some confusion to the user when searching past embeds.
I might be wrong but I think we either get rid of the unique_together or we implement the field relationship through the id?
Or maybe I'm missing something here? :)

Hi @jordij - it's a bit misleading to think of Embed as an object with relations to pages. In our design, the Embed model is simply a cache of HTML responses that we get back from the embed code lookup - nothing more than that. As @kaedroho says, those responses depend on the URL and the max_width parameter, so we need to look up on both.
With this PR, you've actually taken things in a bit of an unexpected direction by treating the Embed model as a listing of previously-used, reusable media items. That's not in itself a bad thing, but it does mean that we'll need a bit of fudging of the current data model to make it fit that use-case (since it's possible for a single media item to have multiple Embed entries, corresponding to different sizes). I guess the quick fix would be to fetch a list of unique URLs from the Embed table, using something like Embed.objects.values_list('url', flat=True).distinct().
From a data model perspective, we definitely do want to reference videos within page content by their URLs, not their embed IDs. When an editor places a video on a page, they are specifying a particular video (as identified by the URL) but not a particular embed size (which would be implied by referencing a specific embed ID) - the embed size is a decision for the template developer, not the content editor.

Thanks heaps for the clarifications @gasman
Embeds are kind of filtered by url when displayed in the editor interface. If the same video exists in the database but with several max_width values, only the first one is displayed in the modal/search results. The editor user don't really need to know that there are N instances of the same video, only a nice thumbnail and a title should be enough to make him/her happy.
Have a look and let me know if you guys are happy with it.

Let me know if you need anything else on this one. Cheers

Hi @jordij,
After further discussion, we don't think that making embeds into a full-fledged user-facing model is going to work well, I'm afraid. It means that the model will end up serving two conflicting purposes - as a cache (with one record for each url + max_width combination), and as a way of representing a specific video to the user (which implies that fields such as tags/title have to be shared between all records for that embed). Also, I'm not sure that that the idea of re-using previously-used items fits with the way that most sites are likely to use embeds.
We'd prefer to go for a simpler 'enter a URL' modal - i.e. the same way that the embed chooser for the rich text area works now, but as a standalone panel too. The chooser widget itself is working very well, and we plan to 'cherry-pick' this side of the PR for 1.3. Thanks!

That sounds good @gasman, no worries.

@jordij hi are you willing to continue your effort or looking for a new taker for this? thanks for starting this.

hey mate feel free to continue the work. cheers

Awesome will ping you soon to accept my PR on your branch, you should get the author credit too

@auvipy hi, just want to check if you made any progress on this to avoid potential redundant work... thanks for response .)

@auvipy hi, just want to check if you made any progress on this to avoid potential redundant work... thanks for response .)

sorry I couldn't! if you want to work on this go ahead,if not i will start work

Closing as per https://github.com/wagtail/wagtail/pull/1553#issuecomment-159911447 - given the age of this PR it's highly unlikely that any future implementation of #634 will be based on this code.


Adding topic regarding REST recurrence rules

@jasonjoh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/breadcrumb/toc.yml
:white_check_mark:Succeeded

docs/rest/recurrence-rules.md
:white_check_mark:Succeeded

docs/rest/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Include link to GH page in the app

Specifically requested by OpenFin

Perhaps have a link to the Github page on the version number?


File list freezing when using Filename with (path) rendering

Using an alternative rendering, Filename with (path) for the file list seems to be too heavy for even medium sized projects, causing the UI to freeze for a moment.
The issue is caused by the html parsing.

I'll remove the html highlights for now and try to come up with a different solution as the italic/bold was quite nice


add support for leptos 5

add support for leptos 5
This pull request add support for leptos 5 and axum

Waiting :O


Try to port js-ipfs-gateway to service-worker

ipfs-browser-gateway
Given an IPFS multihash, print the content and try to render web page if the content is HTML.
Development
This is a "create-react-app" app, so just:
yarn && yarn start
Drawback

The first visit is way slower than traditional HTTP page. Though http://ipfs.io/ipfs is slow too.
Can't promise long-term cache, compared to a gateway running on a server, who can pin a file for a longer time.
Don't work with AJAX likes fetch API.
Loading dependencies by importScripts synchronously are slow (10s).

Road Map

Get it work...It's now working due to my not returning a Response.
Bundle all dependencies.

Reference

Discussion
JS-IPFS-Gateway
readable-stream in SW

@linonetwo Let's discuss this in your new PR since we were writing at the same time.


Update readme on: how to run once all the images have loaded

The readme states:

If you only require it to run once all the images have loaded you
can achieve this by passing null as the first parameter:

macyInstance.runOnImageLoad(function () {
  console.log('I only get called when all images are loaded');
  macyInstance.recalculate(true, true);
});

But in the example true and true is provided. What’s the correct way to specify that you only want to run once all the images have loaded.
Thanks for this great lib!

Hi @vincentorback
Sorry for the late response, the documentation here is invalid and references the function from a previous version.
runOnImageLoad takes two paramaters, the first being a function (the callback) the second being a boolean. If you pass true, as the second parameter then it will run on every image load but if not then it will run at the end

@jrmd Thanks a lot for the clarification!


merge/main

the main updates are:

merging domql/main into v2/packages/domql
using all latest packages for code
updating packages to a new settings including @domql/props and @domql/main
adding tests for each package
getting prepared for v2 release

merged to https://github.com/domql/domql/pull/96


permission denied for relation stv_tbl_perm

When running the column encoding utility, I receive the following error:
 raise self.error
redshift_connector.error.ProgrammingError: {'S': 'ERROR', 'C': '42501', 'M': 'permission denied for relation stv_tbl_perm', 'F': '../src/pg/src/backend/catalog/aclchk.c', 'L': '2763', 'R': 'aclcheck_error'}

I have tried allowing privelages with GRANT ALL PRIVILEGES ON stv_tbl_perm to awsuser; but this has not resolved. I also tried to run SELECT * FROM stv_tbl_perm and this failed with ERROR:  permission denied for relation stv_tbl_perm
Command I am running:
python3 analyze-schema-compression.py --db xxx --db-user yyyy --db-pwd zzz --db-host redshift.xxxxxx.eu-west-1.redshift-serverless.amazonaws.com

Hi, thanks for raising the issue. This is a permissions problem, as the user you are running with is a normal user. The permissions on that view are:

STV_TBL_PERM is visible only to superusers

from the docs at https://docs.aws.amazon.com/redshift/latest/dg/r_STV_TBL_PERM.html.
You can use an existing superuser, or create a new one by including the CREATEUSER word as part of the user creation. Check the docs at https://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_USER.html

I should also add that this utility is being phased out, as the functionality exists within Redshift. Check out the auto encoding feature at https://docs.aws.amazon.com/redshift/latest/dg/c_Compression_encodings.html

no, this is a redshift serverless problem. even "superuser" is unable to query this table on serverless

I am a superuser and redshift is not serverless but still unable to access stv_tbl_perm and getting the same error- permission denied for relation stv_tbl_perm. Can anyone please help me ?


Mediaplackback not decoding and playing 360 videos

Hi,
I have tried one 360 videos for which the media playback is not working. Here are the log messages:
MediaPlayback has been created. Hardware decoding of 4K+ is supported.
UnityEngine.Debug:LogFormat(String, Object[])
Playback State: StateType_None
UnityEngine.Debug:Log(Object)
Playback State: StateType_StateChanged - Paused
UnityEngine.Debug:Log(Object)
Media Opened: width: 4096
height: 2048
duration: 616666
canSeek: 1
isStereoscopic: 0
Playback State: StateType_StateChanged - Playing
UnityEngine.Debug:Log(Object)
Video texture updated: 4096x2048
UnityEngine.Debug:LogFormat(String, Object[])
Playback State: StateType_StateChanged - Ended
UnityEngine.Debug:Log(Object)
Here I am attaching the video (which is not working)
https://drive.google.com/file/d/1WOu5GqRLKOclanr3Vz9M2laVtS2SKu6X/view?usp=sharing
Can u please tell me why it isn't working and resolve this issue?

The video has 00:00 duration.


[hotstar] Unable to download JSON metadata: HTTP Error 404: Not Found

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Provide a description that is worded well enough to be understood
it failed to generate token.
i think hotstar stopped the old api,
yt-dlp should be updated with new hotstar api.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', '-F', 'https://www.hotstar.com/in/movies/ms-dhoni-the-untold-story/1000164358']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [93d33cb29] (pip)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: none
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1831 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[hotstar] Extracting URL: https://www.hotstar.com/in/movies/ms-dhoni-the-untold-story/1000164358
[hotstar]<PHONE_NUMBER>: Downloading JSON metadata
[hotstar]<PHONE_NUMBER>: Downloading webpage
[hotstar]<PHONE_NUMBER>: Downloading token
ERROR: [hotstar]<PHONE_NUMBER>: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: Not Found>)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 740, in extract
    ie_result = self._real_extract(url)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\hotstar.py", line 250, in _real_extract
    playback_sets = self._call_api_v2('play/v1/playback', video_id, st=st, cookies=cookies)['playBackSets']
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\hotstar.py", line 65, in _call_api_v2
    return self._call_api_impl(
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\hotstar.py", line 40, in _call_api_impl
    token = self._download_json(
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 1139, in download_content
    res = getattr(self, download_handle.__name__)(url_or_request, video_id, **kwargs)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 1099, in download_handle
    res = self._download_webpage_handle(
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 960, in _download_webpage_handle
    urlh = self._request_webpage(url_or_request, video_id, note, errnote, fatal, data=data,
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 909, in _request_webpage
    raise ExtractorError(errmsg, cause=err)

  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\extractor\common.py", line 896, in _request_webpage
    return self._downloader.urlopen(self._create_request(url_or_request, data, headers, query, extensions))
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\YoutubeDL.py", line 4161, in urlopen
    return self._request_director.send(req)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\networking\common.py", line 117, in send
    response = handler.send(request)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\networking\_helper.py", line 208, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\networking\common.py", line 337, in send
    return self._send(request)
  File "C:\Users\saide\AppData\Local\Programs\Python\Python310\lib\site-packages\yt_dlp\networking\_requests.py", line 361, in _send
    raise HTTPError(res, redirect_loop=max_redirects_exceeded)
yt_dlp.networking.exceptions.HTTPError: HTTP Error 404: Not Found

Passing logged-in cookies may work around this

Is there any content that can be watched on the website (in browser) without an account? I've been told everything is authwalled now

Is there any content that can be watched on the website (in browser) without an account? I've been told everything is authwalled now

https://www.hotstar.com/in/movies/ms-dhoni-the-untold-story/1000164358

Is there any content that can be watched on the website (in browser) without an account? I've been told everything is authwalled now

Hotstar now made their website require login to watch free stuff but on mobile devices you are still able to watch free stuff without login, I just wanted to let you know that maybe helpful if you can emulate android to take json files or something like that. Thanks.

Hotstar now made their website require login to watch free stuff but on mobile devices you are still able to watch free stuff without login, I just wanted to let you know that maybe helpful if you can emulate android to take json files or something like that. Thanks.

AFAICT we were already using the mobile API. But now something has changed with the guest token endpoint. The endpoint itself may not have changed, since 404s from this site are deceiving; e.g. you can get a 404 response from a valid endpoint if you have the wrong params or are geo-blocked

Per #10738, this issue is manifesting as an HTTP Error 503 now

The same issue with the Aeroshield Smart DNS and Hotstar.
I have been struggling with such problems for about 2 weeks now as a customer.
I am logged in with my Hotstar account and only sometimes video play good but mostly I am getting "something went wrong"
From the browser debug I see that the host hses7.hotstar.com receiving Error 503
I am using Firefox and when I do a hard page refresh Ctrl+F5 5-6 times in a row it starts to play OK and hses7.hotstar.com receives 200 OK.
Support can't help and says hses7.hotstar.com is whitelisted on their side.


WIP: Fill in Ingress trait definition

#23  👈
trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RobbieMcKinstry and the rest of your teammates on  Graphite


Incorrect Drawer Menu Width after Upgraded from 1.3.0 to 1.4.2

Hi rt2zz,
Thanks for making such a great RN module. However, after I upgraded to your latest version from 1.3.0, my left drawer menu's width started to appear incorrectly, which spanned the whole screen instead of 45% of it (openDrawerOffset={0.45}). Nevertheless, the width of the tween transition animation was correct. I have tried to fix the problem myself by debugging your index.js, but no luck. Any clue?
Regards,
Guan

Thanks for pointing this out. In making re-orientation work I made some bad assumptions about view sizing.
I believe this is fixed now in 1.4.5, although your help testing would be greatly appreciated. Let me know how it goes.

Yes, I can confirm that it was fixed in 1.4.6. Cheers!


Add support for (f y) notation

This is used when fixing the second argument of a binary operator.
For example:
(> 2)
(= 3)
(pow 2)

One solution is to handle this at parsing and synthesis level, but use other symbols underneath.
(> 2) => le(2)
(= 3) => eq(3)
(pow 2) => rpow(2)

Could add these as symbols and equivalence rules. I think it is important enough to preserve readability.

Closing since this is supported.


walletunlocker+lnd: add command line flag to allow passing admin macaroon after wallet creation

Fixes #1236.
The new flag --stateless_init of the startup commands create, unlock and changepassword instructs the daemon to not create any macaroon files in its file system but instead return the admin macaroon in the response.
The lncli then prints the macaroon to the standard output (binary serialized in hex format) or writes it to the file specified with the --save_to parameter.
Some of the integration test code is also contained in PR #1152. If either of these two PRs get merge, I'll rebase/fix the other one.

This PR has gotten a lot more complicated than initially thought...
The reason is that in #618 it was implemented that when the wallet password was changed, the macaroon DB was just deleted and then re-created, resulting in all macaroons to be invalidated.
According to @Roasbeef (https://github.com/lightningnetwork/lnd/issues/1236#issuecomment-407180785), this was a mistake.
So I also implemented the re-encryption of the macaroon DB and an optional flag --new_mac_root_key in the changepassword command that replaces the existing macaroon root key with a new one in case the user really wants it that way.
@neogeno is helping me with the testing, thanks a lot for that!

@Roasbeef I can confirm I have tested the latest commit 1e6e526c49a9eef87e116031616fdf90d07d8fd1 from @guggero and the initwallet, unlock and changepassword RPC now work as expected and return the macaroons via TLS. I urge a swift commit of this as it fixes the bug in the ChangePassword RPC that deletes the macaroon root key.

@guggero What's the state of this PR?
Should be getting around to giving it some review and testing love soon, so if you could rebase that would be awesome 😀

@halseth FYI I tested the latest rebased version on his repo and it worked fine

@halseth the PR is ready to be reviewed, I have just rebased it.
Thanks for testing and reviewing in advance!

Thank you for your thorough review!
I was able to address all but one of the issues (see comments).
After quite a bit of refactoring and testing, I'm pretty happy with the code as it is now.

@guggero does this mean the macaroon is sent every single time the wallet is unlocked now?

@neogeno yes, exactly. This probably makes it easy for your use case, right?

@guggero @halseth Sure it makes it easier but not sure if it makes it more secure . Right now BOTH the node password and correct macaroon is needed to issue commands to the lnd node, with the macaroon providing an extra layer of protection . So even if an attacker connects to an already unlocked node or knows the password he also has to know the macaroon and therefore cannot send commands.
Correct me if I have misunderstood, but in this new scenario if someone undesirable knows the node password they can always get access to your macaroon? Doesn't that reduce the security from two factor to one ?

@neogeno you are right, this doesn't make it any more secure... Only storing the macaroon in memory isn't really an option since the client would probably be started/stopped way more often than the server needs to be unlocked. So the macaroon still would be stored somewhere on disk on the client side.
@halseth what do you think? What is more important at this point? "Multi factor security" or that all the unlocker RPCs behave the same way by returning the admin macaroon?

@halseth @guggero I feel uneasy about this approach and would advise against returning the macaroon every single time. Doing so basically defeats the purpose of having a macaroon as a secret 'bearer token' if it shown almost like  a welcome message every time.

It should only be returned on creation, haven't checked the latest diff
yet, but in this case no macaroons should be written to disk either.
On Tue, Dec 25, 2018, 7:04 PM Patrick<EMAIL_ADDRESS>wrote:

@halseth https://github.com/halseth @guggero
https://github.com/guggero I feel uneasy about this approach and would
advise against returning the macaroon every single time. Doing so basically
defeats the purpose of having a macaroon as a secret 'bearer token' if it
shown almost like a welcome message every time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lightningnetwork/lnd/pull/1288#issuecomment-449883043,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA87Lj3slC-lKoxxkst_xOeT8Ka9FUQnks5u8ssZgaJpZM4UO-QS
.

Ok, I have changed that part back so no macaroon is returned on unlock.

Woohoo!

I'm not sure if they are any different security wise. My assumption was that if the attacker knows the password, he can just do a ChangePassword request to force a rotation and get a new admin macaroon anyway.
If we want to make sure the macaroon is only exposes at initial creation, then we must also make the ChangePassword request to work without returning a new macaroon automatically. This could maybe be done by requiring the old admin macaroon, but this might get tricky if the user loses the inital macaroon?

Correct me if I am wrong but doesn't issuing the ChangePassword RPC require the attacker to also know the macaroon in the first place? I believe we have to supply a macaroon when making a remote GRPC call.
The ChangePassword RPC needs to return a new macaroon only if the flag to reset a new root macaroon key is used. This is essential in the case I suspect my node is compromised. However if by default it shows the existing macaroon even without the flag then you are right and that part can be removed.

None of the RPCs on the WalletUnlockerService currently requires a macaroon.

It is correct, the WalletUnlockerService does not require any macaroons. So all the operations create, unlock and changepassword are only secured by the password.
So I think we should do it as @halseth suggests and require the old macaroon on changepassword with --new_mac_root_key set. And only return the macaroon on create and changepassword with --new_mac_root_key.
But as mentioned, this means that when the macaroon is lost, the node has to be restored from backup, there would be no alternative. Luckily this will soon be fully possible, thanks to SCBs (#2313).

Actually that's what I suggested as well . So return the new macaroon only when the root key is changed with the ChangePassword RPC.

I haven't had any time to think about this in a while.
But while rebasing the PR today, I thought: Wouldn't the user always have the option to not use the --stateless_init on unlock and then grab the generated admin macaroon from the file system of the machine.
As an emergency option to get to a new admin macaroon in case the user lost the old one, wouldn't this be enough? He could drop the stateless flag, grab the new macaroon from the file system, restart, unlock again with the flag and continue.
Assuming the user has file system access and still knows the password.
@Roasbeef how should we continue with this PR? It was your initial issue that requested this feature. What scenario did you have in mind?

Recap of the current implementation in this PR:

The flag --stateless_init makes sure that no macaroon files are written to disk. It needs to be passed in for every call to InitWallet (lncli create), UnlockWallet and ChangePassword. Is the flag missing, then the files are created.
The actual admin macaroon is only returned for the InitWallet and ChangePassword calls.
The flag --new_mac_root_key triggers a rotation of the macaroon root key, invalidating all macaroons issued before that point (previously, changing the password deleted the whole macaroon.db, always invalidating all existing macaroons, now this is optional).

Discussion points:

The WalletUnlocker RPC requires no macaroons. So an attacker could obtain the admin macaroon by calling ChangePassword (if he knows the password). Is this secure enough or should we require the old macaroon on ChangePassword, basically locking him out of his node if the macaroon is lost (or fall back to the file system by omitting --stateless_init on unlock)?
Is it OK that ChangePassword does not automatically rotate the macaroon root key by default but now requires explicit setting of the --new_mac_root_key flag?

I would recommend requiring the macaroon to change the password otherwise the macaroon is useless.

Rebased and cleaned up.

+1, this should happen.

After thinking on this a little more, I’d like to propose a slight change to how this is implemented. I think the stateless_init flag should be set on the server side (lnd) and not on the client side (lncli). I’m imagining it being a flag you pass to lnd when starting it up. Then in lncli we could either always return the macaroon in the aforementioned commands, or still require a stateless_init flag to return the macaroon. Regardless, since stateless_init is set in lnd the macaroons never get written to disk and the macaroon is only returned if the server agrees.
Some thoughts on why:

with it only client side, a user could accidentally forget to use the stateless_init flag when unlocking. Then the macaroons would be written to disk when they didn’t want them to be.

if an attacker knew the password to an lnd server, they could simply pass the stateless_init flag to lncli and get the admin macaroon back from any lnd instance. If the flag was on the server, an attacker couldn’t get the macaroon from any lnd. Only the ones that had the flag enabled.

Thoughts?

@Roasbeef any thoughts on the above? Would love to get this in for 0.11.

This might be pushed back a minor release so we can finish up some PSBT stuff.

@Roasbeef understood. Whenever you have a second let me know your thoughts on my proposal. I was going to start updating this PR soon.

@guggero and I spoke and it was concluded that it's likely best to leave the implementation as is (being strictly client side controls).

@guggero Was using this today and noticed that there's several macaroons being written to disk when --stateless_init is set.
chainnotifier.macaroon
invoices.macaroon
router.macaroon
signer.macaroon
walletkit.macaroon

These macaroons might have been added after this PR was originally opened, but I think we'll want to suppress these as well?

Right, the subservers with their own macaroons were added after this PR. This needs to be fixed, thanks for the info!

@guggero ping when rebased and ready for another review!!

I've been using this for several months now and haven't hit any problems.

@cfromknecht rebased!

Recap of the current implementation in this PR:

The flag --stateless_init makes sure that no macaroon files are written to disk. It needs to be passed in for every call to InitWallet (lncli create), UnlockWallet and ChangePassword. Is the flag missing, then the files are created.
The actual admin macaroon is only returned for the InitWallet and ChangePassword calls.
The flag --new_mac_root_key triggers a rotation of the macaroon root key, invalidating all macaroons issued before that point (previously, changing the password deleted the whole macaroon.db, always invalidating all existing macaroons, now this is optional).

Discussion points:

The WalletUnlocker RPC requires no macaroons. So an attacker could obtain the admin macaroon by calling ChangePassword (if he knows the password). Is this secure enough or should we require the old macaroon on ChangePassword, basically locking him out of his node if the macaroon is lost (or fall back to the file system by omitting --stateless_init on unlock)?
Is it OK that ChangePassword does not automatically rotate the macaroon root key by default but now requires explicit setting of the --new_mac_root_key flag?

@guggero Is this still the up-to-date description?

2 years and still no sign of merging this?

2 years and still no sign of merging this?

there are signs

Phew, rebasing and simplifying this (always return macaroon) was a lot more work than expected. But I got everything working again.

@guggero Is this still the up-to-date description?

Yes, this is still the most recent discussion point. It basically boils down to: Should the password be enough to get full control over a wallet, if it is in the locked state. I think yes, it should be enough. To exploit this an attacker would both need the password and be able to crash and restart the node to be able to unlock it and get the admin macaroon.

Awesome, thanks for doing that @guggero . I like the idea of just always returning the macaroon.
I concur that having the wallet password should be sufficient. Your summary of an exploit is accurate, but also need to consider network access as an additional boundary for someone to take over a wallet. Given everything we just described, I'd consider the password as a safe method.


Add reverse-proxy to manage endpoints easily

Closes #47

Good job, i'll update documentation of website too


Instructing Bithound to use semistandard

Should I put a eslintrc.json in my project?
https://github.com/Flet/semistandard/blob/master/eslintrc.json

Using eslintrc.json violates the "One Style to Rule Them All" goal of the standard project.
We should use .bithoundrc.
Please comment and/or close this issue.


feat: add new vault dashboard

Note: going to merge this now to avoid having a massive PR later! Couple of outstanding TODOs and questions, but these can be ironed out as we introduce the business logic.


New Game:Endless runner

PR Description 📜
Endless Runner is an exciting, fast-paced game where you guide a chicken through an endless series of obstacles. With intuitive controls, simply click anywhere to make the chicken jump and avoid the oncoming obstacles. Test your reflexes and see how far you can go before colliding with an obstacle. Enjoy dynamic backgrounds and keep track of your score as you strive for a new high score!
Fixes # <4941>

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.

[x] I have performed a self-review of my own code or work.

[x] I have commented my code, particularly in hard-to-understand areas.

[x] My changes generates no new warnings.

[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE

[x] I have added screenshot for website preview in assets/images

[x] I have added entries for my game in GameZone's README.md

[x] I have added README.md in my Game folder

[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @priyashuu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

/assign

Thank you  @priyashuu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Thank you  @kunjgit    🫡


unitTest using roboelectric

added unit test for the utility class GoToAboutFragment using roboelectric.

Hi @Lamouresparus, Here's the first PR for Outreachy (week2).

@sanyud24 I cannot merge and test this until you fix the merge conflict

@sanyud24 I cannot merge and test this until you fix the merge conflict

Yeah, resolved it @wbrunette


Compute on-road screen brightness based on camera exposure

Is there any reason to keep using the light sensor while offroad? I've seen the consistency of the reading vary greatly depending on the device and lighting conditions. Can we just lock brightness to max while offroad?

On my C2 at Night Screen its very bright, that disturb my Driving. Screen brightness should be lovered at Night


Incorrect Breaking Texture

Minecraft v1.15.2
Forge v31.2.31
Double Slabs v2.7.6
When breaking a vertical slab, the breaking texture appears incorrectly. I also sometimes see a missing texture after the block is broken for half a second. Also, Immersive Portals is not installed.

This should be fixed in the latest versions!

Thanks!


refactor(tests): JUnit 5 migration - module qa/large-data-tests

This change refactors the code for module qa/large-data-tests.
It builds up on the refactoring of BatchHelper (https://github.com/operaton/operaton/pull/217).
related to #27

There are 11 new minor issues: https://sonarcloud.io/project/issues?id=operaton_operaton&pullRequest=218&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true
I know that you are tackling this kind of issues with other tasks / migrations, how should we handle this? I'd lean towards having clean commits

I think we started refactoring the tests, so we should finish it, meaning changing the test code to confirm with the ruleset. Backported tests must be adjusted to the new style.

I'll have a look at the findings and will clean them up.


Added ability to listen to the click event

I added the ability to listen to the click event instead of touchstart and mousedown by setting the useClickEvent property to true on your component.
There might be a cleaner way of implementing this.

got a link where I can read up on that? I don't think I've seen useClickEvent before

@Pomax: I just mean you would add your own property called useClickEvent  in your component

hm. I'm hesitant to land this without a use-case to justify it: which problem did you run into that this patch solves?

I have a navigation bar with a button that opens up a dropdown when you click on it. When the dropdown is open, I want to be able to click anywhere to close the dropdown. If I click down on the button that opened the dropdown closes, but when I release the mouse button, the click event gets sent to that button and the dropdown gets opened again.

I'm not sure I understand, that's what the ignore-react-onclickoutside class is for. Does your button use <button className="... ignore-react-onclickoutside" .../> so that when you click it, it doesn't double-trigger? If not: try that first.

closing due to inactivity


MixerApi/ExceptionRender

https://github.com/mixerapi/exception-render

Those are a lot of very specific, edge case plugins it seems
I wonder if it was better to just list the main one?
Or what's the use case for these small specific ones as standalone usage?

Yeah I too don't see someone using this plugin standalone.

I can close this one.

Those are a lot of very specific, edge case plugins it seems
I wonder if it was better to just list the main one?
Or what's the use case for these small specific ones as standalone usage?

It's modular components. So it's up to the developer to decide what they need.


Cereal reports the wrong error message for the wrong problem

I found one problem that has been bugging me.
Instead of reporting the right warning, Cereal reports error: static assertion failed: cereal could not find any output serialization functions... all the time.
For example, for my code that uses std::shared_ptr, if I'm suddenly forgot to include memory.hpp header, for example:
#include <cereal/types/vector.hpp>
//#include <cereal/types/memory.hpp>
#include <cereal/archives/json.hpp>

Compiling the code with above header will show the could not find any output serialization functions, which is very confusing IMHO. This really wasted my time because I kept looking for errors in my code while the real culprit is because I forgot to include the right header to the project. :(
My simplified code for this problem : https://pastebin.com/6cfXG5yy
Cereal version: 1.2.2

I wouldn't consider this to be the wrong message for the wrong problem. As far as cereal is concerned, it looked for a serialization function for std:;shared_ptr, and could not find one. Thus it gives you the could not find any output serialization functions... static assertion. Usually you'll have to look at the traceback to see the offending type or line as well.


AnacondaCON videos

I just came across videos from AnacondaCON.

I was wondering if we could/should also list them on pyvideo.org (I would say yes)
what do you think?

2019 AnacondaCON Sessions - Open Source Track
2019 AnacondaCON Keynotes
AnacondaCON 2018
AnacondaCON 2017

Why not?

I was just wondering if some of the talks are really about Python, and not about enterprise solutions (e.g. https://www.youtube.com/playlist?list=PLGB9meziqbzpLmHKaJUujhNOWILs30Xd_) but it's probably all fine considering what Anaconda, Inc. contributes to the community.


m_BuildHeightMesh not implemented in NavMeshSurface

I needed to use this option on navmesh built at runtime, but it seems that it is not implemented yet 😬
I post an issue in case it was forgotten

Thank you. We are aware of this missing functionality.


Restrict Japanese kanji requirement to joyo kanji

All Japanese fonts have hiragana kana. It's about 120 glyphs and it's an easy target for designers. Creating a Japanese font with a kanji set is a much bigger undertaking - 2000 glyphs plus. So we have a number of Japanese fonts which are just kana, no kanji - these are usable for display purposes only and that's quite a normal thing to do in Japanese design. But of course when you showed the normal Japanese sample text (which includes kanji) they showed tofu. To deal with these display fonts, we created special "languages" ja_Hira and ja_Kana, and a transliterated sample text which just includes kana. They have had a primary script and the ja_Hira language added manually to their METADATA.pb, and they all work fine.
The problem is with the other Japanese fonts, which include both kana and kanji but not enough of the kanji in our ja_Jpan exemplars. They don't have the manually added ja_Hira and they don't fulfil ja_Jpan, so they end up showing as Latin. I think with a reduced ja_Jpan exemplars, that will fix those fonts too, but we will still have to maintain manual tagging of display kana-only fonts to get the hiragana sample.

Why are fonts with incomplete kanji but complete hiragana not tagged as ja_Hira fonts?

Alternatively a ja_Jpan language data with a joyo extension could be defined, but I don't know if that works for you.

The kanji characters should be kept

No. The problem is that fonts which contain Joyo kanji (but not much more) are not being identified as "Japanese" because our exemplars list has loads of non-Joyo kanji. That's why we need to slim it down to Joyo.

or be moved to auxiliary

I thought about this but the number of kanji we could put into auxiliary is potentially infinite. (Or at least, in the high tens of thousands.) So I'm not sure there's any benefit.

Do we now why the base exemplar characters are the way they are?
What about Jinmeiyō kanji?

I suppose it might make sense to put Jinmeiyo into auxiliary. But stepping back, what are you trying to achieve?

OK, let's have another PR to put jinmeiyo into aux.


remove version from composer.json and add .gitattributes to remove tests

https://blog.madewithlove.be/post/gitattributes/

replace version helper function w/ a http request to https://api.github.com/repos/tightenco/tlint/releases/latest


Result cannot be piped

Currently the result of selecta cannot be piped to the next process:
$ ls | target/selecta | echo

thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: IoError { kind: OtherIoError, desc: "stream is not a tty", detail: None }', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/result.rs:743

It panics because of this line: The window size is pulled from the raw stdout which in this case is not the terminal.
@rschmitt has solved it here by calling ioctl.

Closed with #19


MAINTAINER WANTED

I don't actually use this library, but some folks do, so if you are one of those folks and are interested in being the lead maintainer, please let me know.

I forked this here: nfranke/vertx-swift-eventbus
I've fixed a few issues and will attempt to maintain that fork going forward. Most recently I fixed a bug where the stored registrations would not reregister when reconnected.


feat: expose session and headers

In some scenarios you may not always want to change the wizard step in your action. E.G if you are appending form data to the session in a single step.

Previously it was not possible to access the Set-Cookie header for this use case, so I have exposed the underlying session and added a helper function getHeaders which will create the Set-Cookie heder with the data in the session

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use textareas instead of inputs for definitions

Currently, in the AddWord.js form, each definition is placed within an input node. These input elements should be switched to textarea elements so it's easier to create more or less space while the user is editing a long definition.

Closed by #250


Close/Complete a project manually

We have 'Closing' and 'Complete' statuses for a project, but we don't have any way to set these statuses manually for a project.
Do we really need Closing and Complete as two separate statuses? We may just use them as final status just like Accepted/Declined for Submissions.
We can have a button in 'More Actions'(like submissions) to set the Closing state. And the Complete status button should be available for projects in 'IN Progress' status?

@fourthletter What are OTFs needs around closing/completed statuses for projects?

On Jan 31 standup we discussed 'closing' means an accounting process that requires taking funds from a contract, a formal letter, etc. We decided to add an 'update status' button for users to manually move from workflow status to status.


Warnings in XCode 7, Swift 2.0, installed with Pod

Hi there,
I'm building an app with Swift 2.0 using Cocoapods via use_frameworks!, pod Mixpanel, targeting iOS 8.4, running on Xcode 7.
I've managed to get all my other dependencies upgraded to the appropriate swift-2.0 branches, eliminating all warnings. At this point Mixpanel is of the last still throwing warnings that I'm unable to silence.
Any clue as to what I can do about this?

already fixed in master; replacing the NSUInteger with UIInterfaceOrientationMask silenced the warning.

thanks!