KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

Loosens the validation so that we accept duplicate listeners on the same port but if and only if the listeners are valid IP addresses with one address being an IPv4 address and the other being an IPv6 address. The detection of whether an address is a valid IP/IPv4/IPv6 address is done using Apache's commons-validator. Outside of this specific case the validations are kept the same albeit error messages have been updated to reflect that there is this new exception case of accepting IPv4/IPv6 on the same port.
This PR tests different corner cases by checking whether the changed listenerListToEndPoints either throws an exception (and its message or not). The test follows the exact same pattern as the testDuplicateListeners test. Locally on my machine the PR passes both testIPv4AndIPv6SamePortListeners (the new test) and testDuplicateListeners pass but I will wait for CI to finish.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mdedetrich Thanks for the PR. As this changes a bit the semantic of the configuration, we might need a small KIP for it. Have you considered doing one?

Sure I will create one tomorrow, I didn't realize that adjusting the behavior while keep the exact same public interface required a KIP.

Yeah... I would say that this one is a bit on the edge. I feel like we need a small KIP because the semantic of the configuration changes with your patch. Thanks.

No worries, will write one today. In regards to the CI tests, in general they seem to be flaky. When I ran :core:integrationTest locally only the following tests failed and they seem unrelated.
DynamicBrokerReconfigurationTest > testAdvertisedListenerUpdate() FAILED
    org.opentest4j.AssertionFailedError: Unexpected exception type thrown ==> expected: <java.util.concurrent.ExecutionException> but was: <java.util.concurrent.TimeoutException>
        at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:65)
        at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:37)
        at app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3007)
        at app//kafka.server.DynamicBrokerReconfigurationTest.testAdvertisedListenerUpdate(DynamicBrokerReconfigurationTest.scala:990)

        Caused by:
        java.util.concurrent.TimeoutException: Timeout after waiting for 2000 ms.
            at org.apache.kafka.clients.producer.internals.FutureRecordMetadata.get(FutureRecordMetadata.java:76)
            at org.apache.kafka.clients.producer.internals.FutureRecordMetadata.get(FutureRecordMetadata.java:30)
            at kafka.server.DynamicBrokerReconfigurationTest.$anonfun$testAdvertisedListenerUpdate$8(DynamicBrokerReconfigurationTest.scala:990)
            at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:55)
            ... 3 more

DeleteTopicTest > testAddPartitionDuringDeleteTopic() FAILED
    kafka.admin.AdminOperationException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /brokers/topics/test
        at app//kafka.zk.AdminZkClient.writeTopicPartitionAssignment(AdminZkClient.scala:178)
        at app//kafka.zk.AdminZkClient.createPartitionsWithAssignment(AdminZkClient.scala:298)
        at app//kafka.zk.AdminZkClient.addPartitions(AdminZkClient.scala:231)
        at app//kafka.admin.DeleteTopicTest.testAddPartitionDuringDeleteTopic(DeleteTopicTest.scala:290)

I just updated/rebased the PR, apart from a very minor syntactic fixes we also now output the port when its context is relevant in the validation to help users. This was mainly done because the additional effort to do this was trivial (since we already went through the process of grouping ports we can say which port specifically failed the validation).

@dajac KIP created at https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=195726330

I have updated the PR to add some upgrade notes to docs/upgrade.html. I am not sure if additional documentation is needed elsewhere (I had a look at docs in general and couldn't find anything specific enough but I may have missed something).

I have updated the PR to add documentation to https://kafka.apache.org/documentation/#brokerconfigs_listeners

I have rebased the PR against the latest Kafka trunk

@showuon  @tombentley @mimaison Since KIP-797 has the necessary amount of binding votes this PR is now ready to be reviewed.

@mdedetrich Sorry for the delay. I hope to review your PR in the coming days.
Please keep it again trunk, if we also want it in 3.3, we'll backport it.

No worries, I am just a bit unfamiliar with the process for KIP's. Also letting you know the KIP was accepted into the 3.3 release so I do believe it needs to be backported as well?

@mimaison If you approve and merge this soon. I am okay with you cherry picking it to the 3.3 branch.

@tombentley @mimaison I have gone through each of the review comments and submitted the requested changes and marked them as resolved, only one comment is still outstanding.

In that case, should we do this validation? inetAddressValidator.isValid(ep.host). It looks like we don't care about if the host is valid or not, all we want to filter out, is the null host case (i.e. PLAINTEXT://:9096), is my understanding correct?

So we still need it, not for seeing whether hosts are invalid or not (since we don't care about hosts) but rather to filter out all of the IP addresses. This is answered in more detail at https://github.com/apache/kafka/pull/11478#discussion_r928815976

As mentioned above if we are on the same page then creating a JIRA issue to do additional checking to see if hosts are valid seems appropriate.

Yes, please create a JIRA issue. Thanks.

JIRA issue created at https://issues.apache.org/jira/browse/KAFKA-14103

@mimaison @tombentley , do you want to have another look?

Thanks @mdedetrich, the current changes look good.
I wonder if we should also add an integration test. We should be able to extend MultipleListenersWithSameSecurityProtocolBaseTest to test duplicate listeners. There may be other existing tests which would be good candidates for adding this, if you find a better place go for it.

I wonder if we should also add an integration test. We should be able to extend MultipleListenersWithSameSecurityProtocolBaseTest to test duplicate listeners. There may be other existing tests which would be good candidates for adding this, if you find a better place go for it.

I just did a quick glance of MultipleListenersWithSameSecurityProtocolBaseTest and if I understand correctly this appears to be non trivial to extend for this specific test case due to the fact that currently MultipleListenersWithSameSecurityProtocolBaseTest configures the endpoints to use localhost:0 where the 0 is a magic constant which the def validate function deliberately filters out to bypass any kind of validation.

Actually following on from my previous comment (assuming its correct), the currently existing MultipleListenersWithSameSecurityProtocolBaseTest  tests are already covering what would be tested as a result of this PR. Since the MultipleListenersWithSameSecurityProtocolBaseTest effectively disables the listener validation (by filtering out the listeners which contain magic 0 port) it already happens to be testing the case of having multiple brokers with different listener names.

@mdedetrich Sorry for the late reply. I would have liked an integration test that checks 2 listeners, ipv4 and ipv6, can be on the same port as it's the core feature of this KIP. None of the existing integration tests seem to cover that scenario.

@mimaison
Completely agree that an integration test is ideal to specifically test kafka being able to start multiple instances on same machine, one IPv4 and other IPv6, I will start working on this.
I was just slightly confused by the currently existing tests you were recommending to extend, thanks for clarifying that it was in fact testing something else.

@mdedetrich Are you still interested in completing this KIP?
IIRC the changes were fine but I was wondering if an integration test would be necessary. @jlprat @C0urante WDYT?

@mimaison Thanks for the reminder!
Yes I am still interested, unfortunately due to the non trivial nature of the type of tests I needed to write the this ended up becoming de-prioritized due to the amount of work necessary on my end (also our internal usecase of this feature also was delayed).
If its still decided we want full integration tests than in around a few weeks I should have time to look into it.

Hi @mimaison!
We have a variation (simplification) of this change running on our production for over a year and so far no problems. So I'd be fine with merging the change as it is.

Hi @jlprat, the point of tests is also to ensure future changes don't break this feature. You're more familiar with this feature than me, if you think the unit tests are enough, you can merge the PR.

Hi @mimaison, the current unit tests present in the PR seem that they will cover the case of a potential involuntary regression for this feature. So I'm fine adding the change as it currently stands.
@mdedetrich Could you update the documentation bit? Currently, it is under 3.3, but it should be moved under a new 3.6 section.

So one part of the CI seems to be failing, i.e. for JDK 8 and Scala 2.12 (see https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-11478/31/pipeline/11) but it appears to be completely unrelated
[2023-04-19T08:36:22.655Z] Unexpected exception thrown.

[2023-04-19T08:36:22.655Z] org.gradle.internal.remote.internal.MessageIOException: Could not read message from '/<IP_ADDRESS>:51216'.

Maybe someone can retry, looks like a Gradle bug and if I run the failing command locally, i.e.  ./gradlew -PscalaVersion=2.12 :streams:upgrade-system-tests-23:checkstyleTest it passes.

To the best of my knowledge, test failures seem to be all unrelated to the change in this PR.


The input is not a valid Base-64

Hi, could u help me with this error "'The input is not a valid Base-64 string as it contains a non-base 64 character, more than two padding characters, or an illegal character among the padding characters"?
License was generated by Portable.Licensing 1.1.0 in .NET 7 console app and validation was by Portable.Licensing 1.1.0 in WPF app .NET 4.8.

I had the same problem. Until I realized that instead of using the file content, I passed the file name to the function. Make sure that the file content is read correctly(i mean public key File). Read publickey File into a reachtextbox to Check it

        var publicKey = File.ReadAllText("publicKey.pem");
        var Testlicense = Portable.Licensing.License.Load(File.ReadAllText("license.lic"));
        var validationFailures = Testlicense.Validate()
                                .ExpirationDate()
        .When(lic => lic.Type == LicenseType.Trial)
                                .And()
                                .Signature(publicKey)
                                .AssertValidLicense();

thanks for help :)


feat: Add disableAliases option

Resolves #1571

First post content was changed due to wrong issue linked

@Gerrit0 I came back to this after a while and I've noticed strange extendedTypes behaviour.
While extended types reflections are properly resolved for a class (in my case alt-client.WorldObject), in alt-server.WorldObject they point still on first occurence in whole project (alt-client.WorldObject).
I tried to find where's the problem hiding, but so far I couldn't find logic behind assigning reflection ids to types created from classes heritageClauses.

Yeah, that doesn't surprise me. References are created with types having all their links resolved, so you'll end up with multiple reflections with the same symbol. The ImplementsPlugin relies on getting the symbol to perform inheritance analysis, and that hasn't been updated to support Symbol -> Reflection[] (which really needs to happen due to declaration merging anyways, but I haven't figured out a clean way to do it, and it doesn't break too many people)

Yeah, that doesn't surprise me. References are created with types having all their links resolved, so you'll end up with multiple reflections with the same symbol. The ImplementsPlugin relies on getting the symbol to perform inheritance analysis, and that hasn't been updated to support Symbol -> Reflection[] (which really needs to happen due to declaration merging anyways, but I haven't figured out a clean way to do it, and it doesn't break too many people)

Is there an issue created for this? If not, would be nice to have one.

I don't think there's a canonical issue for it, there's probably some discussion in the 0.20 tracking thread, but I honestly don't remember... and yep, I kind of expected that for the latter as well.
Come to think of it, --packages might be a perfect fit for your repo since it will make TD create two programs and therefore the types will be completely separate... though whether that's a limitation of TD or a feature is kind of undefined right now.

In such case I think that we need to either properly document what happens if disableAliases is used or just entirely remove it.

Since it hasn't been published in a non-beta version (happy accident), I'm fine with just removing it - it does reveal more obviously problems with the architecture


Zizaco/Entrust Cache::tags not working on Laravel

New version, last updated through composer update, don't work in L5.
L5 does not accept cache tags neither on database either on file.
I should revert the EntrustUserTrait trait to its old version w/o cacheRoles(), delete(), save(), restore().
Why has Cache::tags been implemented even though L5 does not support cache tags?

Duplicate of #422

Also yes, you should for now - 1.4.1 doesn't have this issue.


Is it possible to install Pacbot on local environment? What are the necessary change we required in pacbot?

❔ Question
Is it possible to install Pacbot on local environment? What are the necessary change we required in pacbot?
🔦 Context

What you meant my install on local environment?

Can I install/deploy Pacbot on my local Linux machine OR If I want to deploy/install pacbot on another cloud apart from aws and azure, What are the changes are necessary?

PacBot installation has some dependency on aws infra to run the jobs and hosting the APIs.
However, you could manually take care of all those dependencies by creating the required environments for running jobs and deploying the APIs probably using some container platform. In t-mobile, we are using a container platform.


Add section about plotting recs

packages we like to use for data vis
{plotly} for interactive exploration of numeric data
{dygraphs} (?) for interactive time series... there may be better options out there now including plotly with tweaks
{mapview} for interactive maps
{ggplot} for pub-quality plots

@juandlt-csu we will want to put a link/integrate out branding code in the plotting section of the ROSSyndicate_best_practices!


[TODO] Increment pool version to 1.2.273.

TODO new pool require unique schema+version for DID, so some tests now failed and should be updated.

Moved to #523


Run using Bun.sh

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
Bun is a runtime alternative to Node.js which is a lot faster and has a variety of features. It's used a lot in the JS community nowadays.

Its like add bun install and bun start feature?

Fine with bun if we don't have to switch other dependencies, but if it's gonna be a headache I think we should just focus on improving turbo devex


Disabled leagcy engine build: Disable code related to ambigs.

Please don't merge yet!

It was compiled fine with --disable-shared.
With --disable-static it gives me a linker error.

/usr/bin/ld: ../textord/.libs/libtesseract_textord.a(cjkpitch.o): relocation R_X86_64_PC32 against symbol `_ZN13GenericVectorIfE5clearEv' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status
Makefile:540: recipe for target 'libtesseract.la' failed

@stweil, can you help me with the linker error?

It works for me without a linker error (Debian stable, g++).

The PR is ready to be merged now.

Thank you. It is merged now.


Created ViewModels and Tests for the ViewModel

Hi @myothiha09, thanks for the pull request. Before we can merge it, we need you to sign our Contributor License Agreement. You can do so electronically here: http://opensource.box.com/cla
Once you have signed, just add a comment to this pull request saying, "CLA signed". Thanks!

Looks good, besides the couple of comments.

After talking with Nyjal, I decided to make the methods in the InviteCollabsTransformer not static. While it's true that the methods does not require on any state, there is no longer the initial concern where the methods within the class are getting called from the constructor of the same class. The InviteCollabsTransformer does not lose real functionality even if we need to make an object of it.
Furthermore, having static methods make it much harder to write Unit tests, and needs the use of Powermock which breaks a lot of Java programming principles. It will also prevent the InviteCollabsTransformer from persistent throughout the application live span if the class starts having states in future changes.


Problem building example site

Describe the bug
When trying to preview the exampleSite, I followed the exact instructions and I received this error:
Start building sites …  hugo v0.84.0+extended darwin/amd64 BuildDate=unknown Built in 53 ms Error: Error building site: "/Users/jeron/projects/personalSite/anatole/exampleSite/content/english/post/rich-content.md:26:1": failed to render shortcode "tweet": failed to process shortcode: template: _internal/shortcodes/tweet.html:6:82: executing "_internal/shortcodes/tweet.html" at <index .Params 0>: error calling index: value has type int; should be string
To Reproduce
Steps to reproduce the behavior:
Following Preview the exampleSite steps
Desktop (please complete the following information):

OS: macOS
Version of Hugo (run a hugo version if unsure): hugo v0.84.0+extended darwin/amd64 BuildDate=unknown

@ThisIsJeron I think you are getting the error due to an outdated hugo version. Would you mind trying to update to 0.89 and see if the issue persists?


Inspecting LUIS Traces gives you an Access Denied error

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
4.6.0.
Describe the bug
Clicking on LUIS Traces in the emulator returns a new trace with the following message:
[LUIS] Access denied due to invalid subscription key or wrong API endpoint. Make sure to provide a valid key for an active subscription and use a correct regional API endpoint for your resource.
The bot works perfectly even after the error shows up
To Reproduce

Set up a bot with LUIS (LUIS App migrated to Azure Resources)
Test your bot locally with Emulator
Click on LUIS Trace to inspect the trace (everything is correct at this point, it even shows the correct information from the endpoint)
After 2 or 3 seconds, a new trace shows up on the Emulator Console showing the error message in red.
Bot works normally even after the error shows up.

Expected behavior
Emulator shouldn't show that error I guess
Screenshots

Additional context
Add any other context about the problem here.
[bug]

Hi @jbeltranluna ,
Are you currently opening your bot via a .bot file, or are you connecting to the localhost:3978 endpoint via URL only?
The LUIS inspector currently does not support bots opened via URL, because it requires the corresponding LUIS credentials to work properly:

region, subscription key, authoring key, app ID, and app name

These credentials are stored in a .bot file, but are not associated to a bot when opened solely via the messaging endpoint.

Thank you @tonyanziano
We are not using bot files since what I last read was that you were moving away from using those files (https://stackoverflow.com/questions/55473167/azure-bot-services-templates-botfilepath-botfilesecret-fields-are-missing-n)
Besides, when we worked with bot files we used a BotFileSecret that we now do not have it in the App Settings with the new Basic Template.
If the issue is strictly related to the bot file, you can close it since I only asked in case the LUIS credentials we were using weren't the right ones.
Thank you :)


icefall/rnn_lm/train.py error

UnboundLocalError: local variable 'loss' referenced before assignment
Variable 'loss' is just a local variable.
def compute_validation_loss(
    params: AttributeDict,
    model: nn.Module,
    valid_dl: torch.utils.data.DataLoader,
    world_size: int = 1,
) -> MetricsTracker:
    """Run the validation process. The validation loss
    is saved in `params.valid_loss`.
    """
    model.eval()

    tot_loss = MetricsTracker()

    for batch_idx, batch in enumerate(valid_dl):
        x, y, sentence_lengths = batch
        with torch.cuda.amp.autocast(enabled=params.use_fp16):
            loss, loss_info = compute_loss(
                model=model,
                x=x,
                y=y,
                sentence_lengths=sentence_lengths,
                is_training=False,
            )

        assert loss.requires_grad is False
        tot_loss = tot_loss + loss_info

    if world_size > 1:
        tot_loss.reduce(loss.device)

    loss_value = tot_loss["loss"] / tot_loss["frames"]
    if loss_value < params.best_valid_loss:
        params.best_valid_epoch = params.cur_epoch
        params.best_valid_loss = loss_value

    return tot_loss

I don't see a bug here. Could you please check if your valid_dl is empty?

I don't see a bug here. Could you please check if your valid_dl is empty?

I change 'world_size' to 1, then there's no Error message.
For world_size == 4, it'll crash.

I change 'world_size' to 1, then there's no Error message.
For world_size == 4, it'll crash.

What are you doing here? Are you using pdb to debug the code? If so, you can only use pdb if you set --world-size to 1.
When you are debugging, could you please check if your code ever goes into the for loop:
for batch_idx, batch in enumerate(valid_dl)

I change 'world_size' to 1, then there's no Error message.
For world_size == 4, it'll crash.

What are you doing here? Are you using pdb to debug the code? If so, you can only use pdb if you set --world-size to 1.
When you are debugging, could you please check if your code ever goes into the for loop:
for batch_idx, batch in enumerate(valid_dl)

I am tring to generate RNN-LM by "./icefall/rnn-lm/train.py", then to use "Shallow fusion" decoding .
I tried --world-size 4 first, then it crashed, then i changed to 1, it runs correctly.
I'll try to see if my code ever gone to the loop.

I change 'world_size' to 1, then there's no Error message.
For world_size == 4, it'll crash.

What are you doing here? Are you using pdb to debug the code? If so, you can only use pdb if you set --world-size to 1.
When you are debugging, could you please check if your code ever goes into the for loop:
for batch_idx, batch in enumerate(valid_dl)

For wolrd-size 2 or 4, it didn't go to the loop.
For world-size 1, it goest to the loop.
A bit strange.

I change 'world_size' to 1, then there's no Error message.
For world_size == 4, it'll crash.

What are you doing here? Are you using pdb to debug the code? If so, you can only use pdb if you set --world-size to 1.
When you are debugging, could you please check if your code ever goes into the for loop:
for batch_idx, batch in enumerate(valid_dl)

I find if batch_size == 400, and your valid data set size is 100 (sentences), world_size > 1, then
valid_dl = get_dataloader(
        filename=params.lm_data_valid,
        is_distributed=is_distributed,
        params=params,
    )

len(valid_dl) will be 0
If your validation data set size is 100, and set batch_size = 50, world_size = 2, then len(valid_dl) = 1.
It seems like when your validation size is small, it'll crash there.


Upgrade eslint to 0.17

There seems to be another breaking change in how eslint supports react, so they released an upgraded version?
May be it's worth relaxing dependency requirements? If someone wants to ensure an incompatible version is not picked up, there is still a possibility to use shrinkwrap.

See https://github.com/MoOx/eslint-loader/pull/17#issuecomment-81207924 for versions.
Thanks !

Released as 0.7.0


Redirect links are not available on open software page

When looking at the open-source software or even any other open-source resources, we don't provide the link to redirect the user to the aforementioned resource.

Issue is resolved with #1006


Testen

Test

yeah so what im going to do now?
On Mon, Jul 5, 2021, 1:28 AM Piotrek @.***> wrote:

Test
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brannondorsey/wifi-cracking/issues/64, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUQLLD2YVZ2I3VPTDKGA5SDTWCK4BANCNFSM47ZMEJMA
.


hardware-detect cmd infiniband fail

I have this error on hardware-detect
  Info: detect_hpa : controller 0 : The specified controller does not have any physical drives on it.
  Cannot get device pause settings: Operation not supported
  modprobe: FATAL: Module ipmi_smb not found.
  Info: Probing ipmi_si failed
  Info: Probing ipmi_devintf failed
  Traceback (most recent call last):
    File "/usr/bin/hardware-detect", line 10, in <module>
      sys.exit(main())
    File "/usr/lib/python2.7/site-packages/hardware/detect.py", line 814, in main
      _main(options)
    File "/usr/lib/python2.7/site-packages/hardware/detect.py", line 776, in _main
      detect_infiniband(hrdw)
    File "/usr/lib/python2.7/site-packages/hardware/detect.py", line 367, in detect_infiniband
      ib_infos = ib.ib_global_info(card_type)
    File "/usr/lib/python2.7/site-packages/hardware/infiniband.py", line 40, in ib_global_info
      global_info = cmd('ibstat %s -s' % card_drv)
  TypeError: not all arguments converted during string formatting

I notice that old use of cmd return https://github.com/enovance/hardware/blame/65fe16757f22ade7a2739e0297989115c3f5794b/hardware/infiniband.py#L20
  >>> from commands import getoutput as cmd
  >>> cmd("echo foo")
  'foo'

But cmd changed and currently return a tuple https://github.com/enovance/hardware/blob/master/hardware/infiniband.py#L27 (ib_card_drv use cmd)
  >>> from hardware.detect_utils import cmd
  >>> cmd("echo foo")
  (0, 'foo\n')

Same on this lines :

https://github.com/enovance/hardware/blob/master/hardware/infiniband.py#L40
https://github.com/enovance/hardware/blob/master/hardware/infiniband.py#L71

Have you any idea of why this changes doesn't broke the unittest ?
Regards,
Florian

hardware module, move on https://github.com/enovance/hardware/issues/13


Add Audio recitations (Sanskrit)

I have added #5

Thanks for your contributions
means a lot
:1st_place_medal:

Thanks for your support will surely contribute more in future.


MRSS 2024

Code base used for MRSS 2024, including autonomous velocity control of the Go1 robot via a server.

Forgot a file...


Default Decimal Formatting Loses Data on Save

I ran into an issue with a clients file where simply open it and hit save and the field 24,000 is truncated to 24.
Would setting the decimal format to . by default be more logical for most peoples use cases?
Example:
#original csv exported from excel
date,income
01/01/01,"24,000"

# after opening in TableTool and hitting save
date,income
"01/01/01","24"

Thanks for reporting this!
Always using . is a bad idea. TableTool is used world wide, not just in places were . is the decimal separator. , is commonly used as a decimal separator, but usually in conjunction with ; as field separator.
TableTool tries to be smart. It checks the file and uses some heuristics to guess what format the file is in. In this case it guesses wrong. I'll have to check the heuristics and maybe add some more test cases.
It would be awesome if you could provide some more sample data -- I prefer test cases to have as realistic data as possible, instead of minimal examples.
Besides this, I think that TableTool should be to conserve number formatting, whitespace, quotes etc. as long as the cell isn't edited. Then this problem wouldn't have happened in the first place.

Thanks for clearing up the decimal separator issue. I didn't realize this format was used so broadly across the world.

Besides this, I think that TableTool should be to conserve number formatting, whitespace, quotes etc. as long as the cell isn't edited. Then this problem wouldn't have happened in the first place.

Agreed, this would make it much safer to use 👍

It would be awesome if you could provide some more sample data -- I prefer test cases to have as realistic data as possible, instead of minimal examples.

Sure i'll clean the file of all PII and post it in a gist as a test case. I think ideally the user of the file shouldn't have included commas but i'm not sure how Excel formats/exports those number.


Document file globbing, from sylabs 41

This pulls in sylabs PR

sylabs/singularity-userdocs#41
which fixed
sylabs/singularity-userdocs#25

We need to skip this doc change, as we have not included the corresponding code PR and intend to do it differently as in apptainer/apptainer#19.


Bevy does not report .just_pressed in this edge case involving windows focus and cursor grab

Bevy version
0.14.0
Relevant system information
Ubuntu 20.04.6 LTS
What you did
I'm using bevy system which grabs cursor on click and releases grab on click release and when window looses focus, code example provided below, here is an output of log_just_pressed_flag_issue with my comments and video demonstration:
# click in bevy window
MouseButtonInput { button: Left, state: Pressed, window: Entity { index: 0, generation: 1 } } .just_pressed is true, .just_released is false
grab cursor

# I switched to another window by pressing Alt+Tab, while holding mouse button,
# and released button under ANOTHER window (if release under bevy window it will work Ok)
release cursor on focus lost
# !!! NO release event reported

# now I clicked on bevy window, event "Pressed" is reported, !!! BUT .just_pressed is false
MouseButtonInput { button: Left, state: Pressed, window: Entity { index: 0, generation: 1 } } .just_pressed is false, .just_released is false
MouseButtonInput { button: Left, state: Released, window: Entity { index: 0, generation: 1 } } .just_pressed is false, .just_released is true
release cursor

https://github.com/user-attachments/assets/68249be5-366f-4a7b-947d-ee2c876afc31
What went wrong
Here is what I expect it is similar example, but without cursor grab, it provided in code example in log_just_pressed_flag_this_is_ok system:
# click in bevy window
MouseButtonInput { button: Left, state: Pressed, window: Entity { index: 0, generation: 1 } } .just_pressed is true, .just_released is false

# alt+tab, release button under another window, events reported, flag set
MouseButtonInput { button: Left, state: Released, window: Entity { index: 0, generation: 1 } } .just_pressed is false, .just_released is true

# click in bevy window again, event reported, flag set
MouseButtonInput { button: Left, state: Pressed, window: Entity { index: 0, generation: 1 } } .just_pressed is true, .just_released is false
MouseButtonInput { button: Left, state: Released, window: Entity { index: 0, generation: 1 } } .just_pressed is false, .just_released is true

Code used in tests
use bevy::{
    color::palettes::tailwind,
    input::mouse::MouseButtonInput,
    prelude::*,
    window::{CursorGrabMode, PresentMode, PrimaryWindow, WindowFocused},
};

fn main() {
    App::new()
        .insert_resource(ClearColor(tailwind::AMBER_900.into()))
        .add_plugins(DefaultPlugins.set(WindowPlugin {
            primary_window: Some(Window {
                present_mode: PresentMode::Immediate,
                ..default()
            }),
            ..default()
        }))
        .add_systems(Startup, setup)
        .add_systems(Update, log_just_pressed_flag_issue)
        // .add_systems(Update, log_just_pressed_flag_this_is_ok)
        .run();
}

fn setup(mut cmd: Commands) {
    cmd.spawn(Camera2dBundle::default());
}

fn log_just_pressed_flag_issue(
    mut window_q: Query<&mut Window, With<PrimaryWindow>>,
    mouse: Res<ButtonInput<MouseButton>>,
    mut buttons: EventReader<MouseButtonInput>,
    mut focus: EventReader<WindowFocused>,
) {
    for e in buttons.read() {
        println!(
            "{:?} .just_pressed is {}, .just_released is {}",
            e,
            mouse.just_pressed(MouseButton::Left),
            mouse.just_released(MouseButton::Left)
        );
    }
    let mut window = window_q.single_mut();
    for e in focus.read() {
        if !e.focused {
            println!("release cursor on focus lost");
            window.cursor.grab_mode = CursorGrabMode::None;
            return;
        }
    }
    if mouse.just_pressed(MouseButton::Left) {
        println!("grab cursor");
        window.cursor.grab_mode = CursorGrabMode::Confined;
    }
    if mouse.just_released(MouseButton::Left) {
        println!("release cursor");
        window.cursor.grab_mode = CursorGrabMode::None;
    }
}

fn log_just_pressed_flag_this_is_ok(
    mouse: Res<ButtonInput<MouseButton>>,
    mut buttons: EventReader<MouseButtonInput>,
) {
    for e in buttons.read() {
        println!(
            "{:?} .just_pressed is {}, .just_released is {}",
            e,
            mouse.just_pressed(MouseButton::Left),
            mouse.just_released(MouseButton::Left)
        );
    }
}

Good report and reproduction, thank you!


Make SLURM available only on Linux OS

I ran into an error importing slurmkit on Windows (specifically calling which sbatch which is not a command available on Windows). As far as I can tell SLURM runs only on Linux, so I'm suggesting restricting that call to Linux systems.

Thanks @ieivanov.

Tests are passing on the cluster.


Did not pause as expected

While the kids were going outside to play, the mower was attempted to be paused in the yard, but failed to respond to the command that was originally sent.
Describe The Bug:
It appears below within the logs that there was an attempt to pause the mower while in operation, but when that request failed my wife attempted to disable the mower instead, causing it to resume its normal operation.
To Reproduce:
While the mower is in operation, turn off the mower. Once the mower is "going home" then pause the mower. The mower MAY ignore the command at this point. The logs below show the command being accepted, with no return acknowledgement from the mower with the state changed.
Expected behavior:
The mower should have paused when instructed to pause.
Logs:
[8/9/2022, 5:08:51 PM] [Homebridge Automower Platform] Sending request [1/5]: 6583f6ec-46db-4ff3-bfac-fdb97bc99a94
 {"url":"https://api.amc.husqvarna.dev/v1/mowers/<REDACTED>/actions","method":"POST","headers":{"X-Api-Key":"<REDACTED>","Content-Type":"application/vnd.api+json","Authorization":"Bearer <REDACTED>","Authorization-Provider":"husqvarna"},"body":"{\"data\":{\"type\":\"ParkUntilFurtherNotice\"}}"}
[8/9/2022, 5:08:53 PM] [Homebridge Automower Platform] Received response: 6583f6ec-46db-4ff3-bfac-fdb97bc99a94
 {"status":202,"statusText":"Accepted","body":{"data":{"type":"control","id":"<REDACTED>","attributes":null}}}
[8/9/2022, 5:09:31 PM] [Homebridge Automower Platform] Sending request [1/5]: 90691e96-21ef-48aa-a530-2e59dfad3a0e
 {"url":"https://api.amc.husqvarna.dev/v1/mowers/<REDACTED>/actions","method":"POST","headers":{"X-Api-Key":"<REDACTED>","Content-Type":"application/vnd.api+json","Authorization":"Bearer <REDACTED>","Authorization-Provider":"husqvarna"},"body":"{\"data\":{\"type\":\"Pause\"}}"}
[8/9/2022, 5:09:32 PM] [Homebridge Automower Platform] Checking keep alive for the client stream...
[8/9/2022, 5:09:32 PM] [Homebridge Automower Platform] Reconnection is not required.
[8/9/2022, 5:09:33 PM] [Homebridge Automower Platform] Received response: 90691e96-21ef-48aa-a530-2e59dfad3a0e
 {"status":202,"statusText":"Accepted","body":{"data":{"type":"control","id":"<REDACTED>","attributes":null}}}
[8/9/2022, 5:09:59 PM] [Homebridge Automower Platform] Sending request [1/5]: a7a257c2-5fac-4b4b-8fc3-f055d877b46f
 {"url":"https://api.amc.husqvarna.dev/v1/mowers/<REDACTED>/actions","method":"POST","headers":{"X-Api-Key":"<REDACTED>","Content-Type":"application/vnd.api+json","Authorization":"Bearer <REDACTED>","Authorization-Provider":"husqvarna"},"body":"{\"data\":{\"type\":\"ResumeSchedule\"}}"}
[8/9/2022, 5:10:01 PM] [Homebridge Automower Platform] Received response: a7a257c2-5fac-4b4b-8fc3-f055d877b46f
 {"status":202,"statusText":"Accepted","body":{"data":{"type":"control","id":"<REDACTED>","attributes":null}}}

Environment:

Plugin Version: 1.2.1
Homebridge Version: 1.5.0
Node.js Version: 16.16.0
NPM Version: 8.11.0
Operating System: oznu/homebridge:ubuntu

This might be a more difficult bug to fix if Husqvarna isn’t always honoring the control requests once accepted.
They may not actually guarantee delivery, which means the plug-in has to retransmit requests until the corresponding event has been received.

Upon further contemplation, this seemingly could have been caused by one of the following failure points:

Husqvarna accepted but did not transmit the request to the mower.
Husqvarna accepted and transmitted the request to the mower, but the mower did not accept the request.
The mower accepted the request, but failed to fulfill the request.
The mower accepted the request, but did not transmit the event back to Husqvarna.
Husqvarna did not accept the event from the mower.
Husqvarna accepted the event from the mower, but failed to retransmit the event to event stream.


git server errors

I'm writing a git SSH server with this package but I'm having quite a bit of trouble with getting it to work. I'm working on a private repository that I cannot share but I extracted out a minimal example into https://github.com/nhooyr/go-git-server with an example test that fails.
I've basically copied the receive_pack and upload_pack from https://github.com/src-d/go-git/tree/6f3b2d878d2f84f513c9dc08b000f653ea83f690/cli/go-git
My copied version is here.
Here is an example of the output from the test script:
Initialized empty Git repository in /private/var/folders/7b/218sfv615xxf_w9ttnpjt0_r0000gn/T/tmp.DyzqkAEA/foobar/

CLONING EMPTY REPOSITORY
Cloning into 'foobar'...
2017/08/23 12:50:40 /var/folders/7b/218sfv615xxf_w9ttnpjt0_r0000gn/T/tmp.DyzqkAEA/foobar
warning: You appear to have cloned an empty repository.
2017/08/23 12:50:40 failed to decode upload pack request: pkt-line 1: missing 'want ' prefix
CLONED EMPTY REPOSITORY

[master (root-commit) d08242a] initial
 1 file changed, 1 insertion(+)
 create mode 100644 somefile
/var/folders/7b/218sfv615xxf_w9ttnpjt0_r0000gn/T/tmp.Tfcs2xMU/foobar
PUSHING REPOSITORY
fatal: The remote end hung up unexpectedly
2017/08/23 12:50:50 error in encoding report status: EOF
	Error Trace:	server_test.go:55
	Error:      	Expected nil, but got: &exec.ExitError{ProcessState:(*os.ProcessState)(0xc4203b4060), Stderr:[]uint8(nil)}

Process finished with exit code 1

The first error about failing to decode a upload pack request seems to happen because the client is fetching a empty repository. I tested the same server on a repository with commits and it works fine. If I'm not doing anything wrong, that error message is very unclear and should probably not be an error at all.
The second error I have no idea why its happening but I have not gotten pushes to work at all with the server and this library. In fact, when pushing a commit, I've managed to make the library panic. Unfortunately, it doesn't panic in my minimal example but I have an example that I cannot share because its intertwined with my private repository that does make the library panic 100%. It's the exact same server code, just a different repository being pushed/pulled. I can extract it out as well, but I'd like to get the above repository working first.
I feel like I'm doing something horribly wrong but I have no idea what. Would really appreciate some assistance in debugging this.

Hmm, definitely not an issue with my code above. I tested using the upload-pack and receive-pack commands provided in this library and I get similar errors. If I substitute those commands for the standard git upload-pack and receive-pack commands, everything works fine.

@mcuadros I noticed the gopkg.in/src-d/go-git.v4/cli/go-git doesn't seem to have much love, and really only seems to contain implementations for upload-pack and receive-pack.
Can you elaborate on the status of the package in question and level of support? Are these implementations even complete?

This package is close to be deleted, the cli is something out of the scope, this two command were created for testing purposes.

Does that mean the upload-pack and receive-pack implementations part of the library will also be deleted?

Maybe, will be better to move they to _examples folder.

The entire implementation?

Errr.. this files are few lines less than a hundred, and are don't thing that someone is using this programs.

I'm talking about the implementation of upload-pack and receive-pack in the library, not in the cli packages.

Hahaha, not this is being use by use in production. I was talking about the
cli package.
El mié., 20 sept. 2017 a las 19:19, Anmol Sethi<EMAIL_ADDRESS>escribió:

I'm talking about the implementation of upload-pack and receive-pack in
the library, not in the cli packages.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/src-d/go-git/issues/556#issuecomment-330920804, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABgA-sk3QxhiSyg4a97oKrSxZG6oJ7JBks5skUkjgaJpZM4PAUBQ
.

Going to close as it has been a long time and I'm not sure if this is relevant anymore.


Default Micophone

Do you have anything similar for input devices / microphones?

Does this work for you? https://github.com/frgnca/AudioDeviceCmdlets

@frgnca Would you like to formally take over this project? If you PR your changes I can transfer the original project to you.
https://help.github.com/articles/about-repository-transfers/

Yes, I would be interested. Thank you for offering this. I've created the pull request #17

@frgnca If you rename/remove your existing repo, I can finalize the transfer.

I have renamed my fork from AudioDeviceCmdlets to AudioDeviceCmdlets-renamed. Don't hesitate to tell me if more needs to be done on my side. First time doing this.

@frgnca Looks yours has to be removed. GitHub won't let me transfer if you have any repo that has a relationship fo the repo being transferred. (cyclical references I suppose)

@cdhunt My repository "frgnca/AudioDeviceCmdlets-renamed" was successfully deleted. Sorry for the late reply.

While pointing the fact that we organized this on an issue titled "Default Micophone", I would like to thank you again @cdhunt and confirm the transfert was successful.


Add support for other elements than table, add support for saving the sorted column to cookies

I had a project where for certain reasons I had to use table like structure that I created using divs and css. I needed to add support for sorting so I expanded the tablesort in a way that it now supports other html elements than just table as long as certain css classes are included.
Example:

Div table

2

1

3

I also added support for saving the sorted column to cookies when tablesort is given saveToCookie option where the value is the name of the cookie used.
My editor did some funky things with the indentation please ignore those..

Hey @Artsu sorry for the delay!
I like the idea of supporting other list structures other than
 but I'm not sure this is the right approach.

It transforms div's into a table. Does it really need to do this?
It's dependent on class names to exist that represent HTML elements. This could be agnostic by reviewing the parent -> child structure.

Also, I'd much rather see saveToCookie in a separate pull request.
cc @ryanmjacobs @xPaw

I don't think this is needed in this library, there's List.js which might be a better fit for this. Also saving any client side data in cookies is absolutely awful.

No problem for the delay!
It doesn't really transform divs into tables. It just gives div elements the same functions that the corresponding table elements got so that I didn't need to touch the actual logic. Also whenever I've seen divs be used as table it's because actual table couldn't be used (eg. forms for every row). And since you want the divs to act like table you have to give them proper styles and usually it is done by using the table element name as class name and then styling with css. It's not really something you should ever be doing but unfortunately it's something that has to be or already has been done and then you'd might want to have the same possibility for sorting as with normal table.
@xPaw: List.js didn't really do what I wanted which is why I had to expand this library in the first place. I don't really feel like saving client side data in cookies is "absolutely awful" but you're right that I should've used local storage instead. I just thought it wasn't supported by older IE versions but I should've actually checked that.
I don't really mind if you don't merge any of this code since I just happened to have a need for it myself and decided might as well make a pull request. So no offense taken if you decide to ditch the chances completely:) Also for the same reason I probably won't be going back to make these into separate pull requests. It was more of a dumping what I made for myself instead of expanding the library for greater good, sorry.

OK thanks - going to close this.


Bookmarks should be case insensitive

In testing, Josh used "Book cyber", but then started typing "book" and there was no autocomplete.
As a user, I want to be able to type in either upper or lower case to get to my links so that I can avoid confusion and disruption.

Fixed in V1.1


conformance test: tear down manifests before blobs

As explained in the added comments, "some registries" (i.e. my own implementation, Keppel https://github.com/sapcc/keppel) forbid deleting blobs that are still referenced by manifests. To do a proper cleanup in this case, the manifest needs to be deleted first.
The diff looks a bit weird, but I really just swapped the order of some paragraphs, pulling the manifest deletion to the top.

This PR should be modified to switch the order based on the presence of some env var

Done.

Documentation added.

@majewsky looks good. Last thing is the DCO check failed on your last commit. Can you amend the commit to contain signoff then we can merge?

@majewsky - thanks for you patience, looks like the final commit had a different email in signed-off-by which might be causing an error: https://pullapprove.com/opencontainers/distribution-spec/pull-request/156/requirements/

LGTM


Add the initial version of the MTMC demo

@sovrasov Please retarget this to the develop branch.

@IRDonch all the comments are resolved in #343


lib/systems/platforms: treat missing cpu version as generic pcBase

Motivation for this change
Since 40e7be1 all ARM platforms that didn't have a parsed cpu version
(e.g. arm-none-eabi) would be handled as armv7l-hf-multiplatform which
did break building arm-trusted-platform packages for some targets (e.g.
rk3399).
Using pcBase as fallback, instead of armv7l-hf-multiplatform,
corresponds with the behaviour we had before 40e7be1.
Things done

[X] building ubootRockPi4 on aarch64-linux works again

I'm not sure exactly what this entails, but kernelArch isn't set in pcBase. I suspect this will prevent building usable kernels.

Then again, I'm not sure if we have generally usable kernels for armv<8 anyway (as opposed to specific kernels for specific devices), so that may be a moot point.
Note also #107214

This looks good to me. I was skeptical when I read https://github.com/NixOS/nixpkgs/commit/40e7be11c8098d11217786d106462e958e1d8718#commitcomment-45533391, but assuming these specific devices i not "proper" anyways, and just something I did for back compat. Ideally that list should only do the "generic" machines anwyays.
Thanks for fixing.


How to control the card width in project title page?

By default, each card in /projects/ occupy 1/3 of the whole width. Is there any way to adjust this default? In the description, it says " Every project has a beautiful feature showcase page. It’s easy to include images in a flexible 3-column grid format. Make your photos 1/3, 2/3, or full width. " Does it mean I can define the width of each project card?
Right now my solution is to change width of grid-item in _base.scss. But it is fixed for all project cards. I am wondering whether there is any flexible way. Thanks.

As of now, the project cards have fixed width specified in the grid-item class as you pointed out. The description that you are referring to is about the layout of images on the project page, not the project cards.
A more flexible solution would be to define a variable in _sass/variables.scss add parameterize the project card width with that variable, so that it can be adjusted easier.

As of now, the project cards have fixed width specified in the grid-item class as you pointed out. The description that you are referring to is about the layout of images on the project page, not the project cards.
A more flexible solution would be to define a variable in _sass/variables.scss add parameterize the project card width with that variable, so that it can be adjusted easier.

Got it. Thanks.

Got it. Thanks.


COM-49: Make white button green / black on hover

New hover state in context on the donate footer:

Updated colour:


Add support for searching in the same venue by default

What

Add support for searching in the same venue by default
Add new parameter called searchAllVenues which is a boolean that can be set in order to perform search across all venues in a solution
Fix issue with categories not updating when changing the venue

How

Add new boolean parameter searchAllVenues and create an atom for storing the value
Rename the currentVenueName for consistency reasons
In the Search.jsx file in the wrapper component, add a check if the searchAllVenues prop is true in the mi-venue
In the Search.jsx file, add the venue attribute when searching for selecting a category in order to get the filtered locations
Add a new useEffect() on the MapTemplate.jsx file which handles the changes in the currentVenueName atom, and gets the current categories based on that

Should this have a major label instead of minor?

That's up for us to decide 🤷🏻♀ @ammapspeople
I just added a minor for now, but we can change it if we decide that it's a major.


Yea. I think i will dig a lil deeper and then remove it.
Also I gotta update the version file again so I can cut the release

Yea. I think i will dig a lil deeper and then remove it.
Also I gotta update the version file again so I can cut the release

deleted!

deleted!

ran make test locally and we're 🟢 mergin'

ran make test locally and we're 🟢 mergin'


Sync eng/common directory with azure-sdk-tools for PR 2810

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/2810  See eng/common workflow

/check-enforcer override


[Feature] Zoom products

Description
Zooming products will increase user interface
Ex.
https://github.com/pooranjoyb/popShop/assets/109230049/4cd035b2-0eca-42ff-83c1-839e3b18a033
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Congratulations, @Che140401! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Cool go ahead :) @Che140401 🚀

when i run the npm run dev it is not running and getting blanked the screen
https://github.com/pooranjoyb/popShop/assets/109230049/fe6a4928-93ce-4a67-b90a-3d7a3aeaedd3

when i run the npm run dev it is not running and getting blanked the screen
Home.tsx.-.popShop.-.Visual.Studio.Code.2024-05-25.22-01-23.mp4

Please follow the CONTRIBUTING GUIDELINES

Closing as no updates!!!

Closing as no updates!!!

Hey can you please open issue again my device got dead


Basepaths like "base%2Fpath" work properly in version 1.43.4 but not in 1.45.11

Describe the bug
I'm trying to create a router on a basepath containing the value %2F (URL encoded representation of /).
With @tanstack/react-router version 1.43.4 (edit: and 1.45.0), the router respects it, and renders links to /base%2Fpath/any-page correctly. Example: https://stackblitz.com/edit/tanstack-router-kaytm9?file=src%2Fmain.tsx
With version 1.45.11, the router, after root route mount, redirects the browser to /base/path and links are rendered incorrectly to /base/path/any-page.
Example: https://stackblitz.com/edit/tanstack-router-dvwena?file=src%2Fmain.tsx
Your Example Website or App
https://stackblitz.com/edit/tanstack-router-dvwena?file=src%2Fmain.tsx
Steps to Reproduce the Bug or Issue

Create router with basepath containing %2F, like /base%2Fpath and serve the page with the router at <domain>/base%2Fpath.
With Chrome (or with probably any other browser), open <domain>/base%2Fpath.
Router mounts, root route mounts, and changes the URL in the address bar to <domain>/base/path. Links are rendered pointing to locations with the changed basepath, for example <domain>/base/path/any-page.

Expected behavior
I expect browser location <domain>/base%2Fpath not to change. I expect Links to point to <domain>/base%2Fpath/any-page.
Screenshots or Videos
No response
Platform

OS: macOS 14
Browser: Chrome
Version: 126.0.6478.183 (Official Build) (arm64)

Additional context
As far as I can tell after debugging, the location is changed after rootRoute onEnter() hook. At that point, the basepath ends up being decoded here https://github.com/TanStack/router/blame/main/packages/react-router/src/path.ts#L184. There's no workarounds that I could, even moving from basepath to splat.

Tried some more versions. Does not reproduce in 1.45.0: https://stackblitz.com/edit/tanstack-router-dmarzj?file=src%2Fmain.tsx
After that version, issue is present in all versions to 1.45.11.

out of curiosity, why do you need this kind of basepath?

out of curiosity, why do you need this kind of basepath?

Thanks for engaging!
We have a service that customers can install for <customer-domain> and/or <customer-other-domain>/<subpath>. From the standpoint of our service, these installs are equal and valid, and are accessed in one level deep path at <our-service-domain>/<customer-domain> and <our-service-domain>/<customer-other-domain>%2F<subpath> respectively.
Imagine https://www.whois.com/whois/example.xyz, https://www.whois.com/whois/example.xyz%2Fpage
I wasn't able to get this working refactoring to splat as well, so I think there's a deeper issue at play here.

A naive fix occurred to me
In packages/react-router/src/path.ts parsePathname function
      const decodeURIComponentExceptForwardSlash = (
        pathSegment: string,
      ): string => {
        return pathSegment.split(/%2F/i).map(decodeURIComponent).join('%2F')
      }

      return {
        type: 'pathname',
        value: decodeURIComponentExceptForwardSlash(part),
      }

In packages/react-router/tests/router.test.tsx an additional case
describe('encoding: URL path segment', () => {
  it.each([
    {
      input: '/path-segment/%C3%A9',
      output: '/path-segment/é',
      type: 'is encoded',
    },
    {
      input: '/path-segment/é',
      output: '/path-segment/é',
      type: 'is not encoded',
    },
    {
      input: '/path-segment/%F0%9F%9A%80',
      output: '/path-segment/🚀',
      type: 'is encoded',
    },
    {
      input: '/path-segment/🚀',
      output: '/path-segment/🚀',
      type: 'is not encoded',
    },
    {
      input: '/%F0%9F%9A%80toMoon%2f🚀toMars%2F🚀toVenus/page',
      output: '/🚀toMoon%2F🚀toMars%2F🚀toVenus/page',
      type: 'contains some encoded characters and an encoded forward slash',
    },
  ])(
    'should resolve $input to $output when the path segment $type',
    async ({ input, output }) => {
      const { router } = createTestRouter(
        createMemoryHistory({ initialEntries: [input] }),
      )

      render(<RouterProvider router={router} />)
      await act(() => router.load())

      expect(router.state.location.pathname).toBe(output)
    },
  )
})

@apata can you see if #2261 fixes your problem?

Retested with the preview package https://pkg.pr.new/@tanstack/react-router@2261 in https://stackblitz.com/edit/tanstack-router-xevuta?file=package.json and can confirm that this issue is fixed.


New-config Main branch and npm

Hi @gioboa, new-config branch is in good state and library is working for me.
The problem is that since it is not the main branch it is not published in npm and using libary from github via  "@module-federation/vite": "github:module-federation/vite#new-config" doesn;t work as lib folder is not included. That stops many people from being able to try try and give feedback.
Would be great to have it in npm even as a beta version to be able to get more feedback and get edge cases covered.
I for instance have some issues and not sure if it is me or library. Having more people would help to get to root of those issues quickly.
Thanks
This is what I mean:
https://www.npmjs.com/package/@module-federation/vite?activeTab=versions
PS. if you think it is yet early to switch to this branch, at least can you please publish this branch to npm as beta.  See here
### Tasks

I can cut a new 1.0 alpha release from the new-config branch>
does it work for you?

Yes, as long as it  can be used from npm.

I added pkg-pr-new for that, but I am waiting for a module-federation approval.
So we'll be able to have a new installable package after each commit. 💪

Excellent, once merged I will add few more examples.

Closing this one. As we have alpha bundles in npm

Thanks @husayt


feat: CI to publish helm chart

dependent on #7 - just an opinionated approach to publishing helm charts, but using github first this time

Hi! I tested this workflow file and came up with some changes. I removed helm-docs (I don't think it was useful since this was not pushed anywhere actually), and replaced the helm releaser by a plain and simpler helm package call. It is also only pushing to ghcr.io (not both gh-pages and ghcr.io). It is installed with the following command:
helm upgrade --install reviewer oci://ghcr.io/pvcnt/helm/reviewer --version ${version}

I validated this in a test branch and its does seem to work. Since I pushed changes to your branch, please let me know what you think of it! Does it fit your use case?

Hi! I tested this workflow file and came up with some changes. I removed helm-docs (I didn't get how it was used?), and replaced the helm releaser by a plain and simpler helm package call. It is also only pushing to ghcr.io. It is installed with the following command:
helm upgrade --install reviewer oci://ghcr.io/pvcnt/helm/reviewer --version ${version}

I validated this in a test branch and its does seem to work. Since I pushed changes to your branch, please let me know what you think of it! Does it fit your use case? Do you also need the publication of a relase on GitHub + publication on gh-pages, like what the chart-releaser-action was doing? I'd like to understand your workflow, and where would you like to install the Helm chart from.

honestly I keep forgetting you can do oci images - there this is totally fine.  The use case was "i dont want to clone and install from local dir" and this completely solves that.
sorry for the late reply!

Let's merge this, then. Thank you!


KOGITO-5533: implement evaluation of rules via CloudEvents (part 2)

Minor leftovers from original PR: https://github.com/kiegroup/kogito-runtimes/pull/1610

The (build) Apps check has failed. Please check the logs.

The (build) Apps check has failed. Please check the logs.


add time-stamp check for spell dictionary to prevent overwriting

model has time stamp for when it was loaded -- check for updates before updating.  need check call in CheckWord

actually only need to call in LearnWord as that is only time it is modified. all logic in place now.


iOS orientation issue using Pager + HtmlView

If the demo apps cannot help and there is no issue for your problem, tell us about it
Please, ensure your title is less than 63 characters long and starts with a capital
letter.
When using an HtmlView as the content of a page within the pager component, changing the orientation of the device is causing some issue on iOS.
When the user opens the first page within pager and then changes the orientation of the device, everything works as expected.
But if the user goes forward and then changes the orientation, the HtmlView suddenly "disappears". And the user has no chance to bring it back to view.
See the following GIF for more details (the Page rbackgroundColor is green, the HtmlView has yellow backgroudColor):

Which platform(s) does your issue occur on?

iOS
tested on iOS 12.4 and 13.3 / 13.4
Simulator and device

Please, provide the following version numbers that your issue occurs with:

CLI: 6.5.0
Cross-platform modules: 6.5.0
Runtime(s): tns-ios 6.5.0
Plugin(s<EMAIL_ADDRESS>
Please, tell us how to recreate the issue in as much detail as possible.
Just do the same steps as shown in the GIF.
Is there any code involved?
ns-pager-htmlview-orientation.zip
Additional info
When using a Label instead of HtmlView, then everything works as expected.
But using an HtmlView without a Pager component works as expected as well, so this issue seems to be caused by the Pager in some way.

Hello Felix, did you ever find a solution for this issue? I'm running into it as well.

I think I may have a fix for this
Sent from Yahoo Mail for iPhone
On Wednesday, October 21, 2020, 5:04 PM, jb-jonathan<EMAIL_ADDRESS>wrote:
Hello Felix, did you ever find a solution for this issue? I'm running into it as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@jb-jonathan nope, I have not found any solution for that, but I am glad to hear that @triniwiz might have a fix for that.


move edited/GT TextEquiv to front

Unfortunately, since PAGE-XML completely underspecifies what and how TextEquiv (with or without @index) is used, applications have to define their own convention. IIUC (please correct me if I'm wrong):
LAREX convention
Existing TextEquivs are kept unchanged. Existing @index=0 is treated as GT. Anything else is treated as prediction, and only the highest position/index is shown.
When manual edits are done, GT is updated or created.
When saving, GT (if available) will become @index=0 and prediction (if available) @index=1. These two will be appended to any existing TextEquiv.
PageViewer
PageViewer only shows the first index as tooltip (regardless of @index).
Aletheia
Aletheia only shows the first index as tooltip (regardless of @index) and does allow editing multiple TextEquivs, but does not set (or even show) their @index. (It just calls them Variant1, Variant2 and so on in the GUI.)
@tboenig please correct me if this is not true for the fully licensed version.
OCR-D convention
The current spec says that where multiple TextEquivs are available, @index=1 should be preferred.
However, that's not at all what is currently implemented across OCR-D: processors read the first TextEquiv (regardless of @index) and write starting at @index=0.
(Reason for this behaviour is probably that it's easier to implement and "works" with PageViewer, and the concrete spec language on that matter came too late... So either we change the spec or we fix the implementation now. @kba?)
Solution
To become interoperable with OCR-D, it would currently suffice to just insert the new TextEquiv elements in front of the existing ones (while keeping all the @index rules).

Hi,
I just would like to add an addtional topic, which in my opinion should be considered here:
Whatever is defined, it should be a clear defined way to generate the according ALTO file from the PAGE file.
Best would be also, if this transformation PAGE -> ALTO is defined as one-to-mapping, this means, it is possible to do a ALTO->PAGE transformation.
In the ALTO definition you can find on Word level a defintion for "CONTENT" and "ALTERNATIV". As you can see here

this is not planned to use for the purpose which is discussed in this issue (at least I have understood that it is about alternative text variants due to different OCR engines including the "special" ORC Engine "GroundTruth").
Instead "VARIANT"s in "GLYPH"s are used to store this information. See

Reference: https://www.loc.gov/standards/alto/v4/alto-4-2.xsd

@stefanCCS thanks for adding this important aspect!

In the ALTO definition you can find on Word level a defintion for "CONTENT" and "ALTERNATIVE"
This is not planned to use for the purpose which is discussed in this issue (at least I have understood that it is about alternative text variants due to different OCR engines including the "special" OCR engine "GroundTruth").
Instead "VARIANT"s in "GLYPH"s are used to store this information

Yes, ALTO only has ALTERNATIVE on word level (StringType), which is indeed meant for other purposes than our concern here, and Variant on glyph level (GlyphType), which does look like our use-case but has no mechanism similar to PAGE's @index.
Since we are mostly concerned with line-level text content here (for which there is no representation at all), not word-level (for which we don't have the proper representation for alternatives), and much less glyph-level (for which we have everything), we must conclude that sadly there simply is no way to get a 1:1 mapping – without severely reinterpreting/abusing the ALTO representation. (For example, one could have one String per TextLine to represent the line level content, and use ALTERNATIVEs for the OCR vs GT. But that convention would always be in danger of being confused with an actual single-word line and actual alternative spellings.)
Our current PAGE→ALTO converter offers an option --dummy-word to preserve line-level text content and options --textequiv-index and --textequiv-fallback-strategy for full control of what TextEquiv to select for @CONTENT in the end.
In the other direction AFAIK we still rely on PRImA's page-converter CLI (which is based on prima-core-libs' parser for ALTO 2.1). That seems to project word-level text to line and region level, so dummy words at least would become TextLine/TextEquiv again. But nothing is done with ALTERNATIVE (or Variant) there.

… without severely reinterpreting/abusing the ALTO representation. (For example …

(Another possibility, suggested by @stefanCCS privately, would be adding one alto:TextLine/alto:String/alto:Glyph per character of pc:TextLine/pc:TextEquiv/pc:Unicode – with pseudo-coordinates, since we usually do not have word or glyph segmentation available. These Glyphs could then carry Variants naturally. But while Variants of different Glyphs are usually independent of each other, here we would have to give them a special interpretation which prevents mixing/recombining local variants – like first glyph first variant with second glyph second variant. Again, there would always be the danger of being confused with actual Glyphs and actual local variants.)

Is the expected behavior that only completely new TextEquiv elements – as in 'no TextEquiv[@index="0"] element existed prior to adding it' – get inserted as first child or should this also apply when users edit the content of already existing TextEquiv[@index="0"]?

The former. (I don't know how LAREX behaves if multiple index0 versions preexist. But whatever index0 it picks up should be the one that OCR-D will see. Therefore, if index0 existed but was not first, LAREX should move it to the fore.)


Remove duplicate word in README

Coverage remained the same at 86.207% when pulling ce238b0a75aa9504997d60984469cce8ce44286e on Trevoke:patch-2 into e952fd631a35cb7f8a2979e00e358d6af63bea6b on kittoframework:master.


[Uavcan] Replace one priority bit with version bit in the Uavcan frame header.

I assume we're going to use the rightmost bit (bit 24 of the header) of the priority field such that priority field decides priority instead of the version field. @pavel-kirienko @thirtytwobits

Correct.


window.localStorage needs to be wrapped in try catch on safari

Coverage decreased (-1.5%) to 87.931% when pulling 4ffb20fa81180c291ec1d6171ac0ad6313a1ab74 on Yleisradio:fix/safari-local-storage-block-all-cookies into f663c23ac41beff094378738843584c5754cd6cf on bigpipe:master.

Coverage decreased (-1.5%) to 87.931% when pulling 4ffb20fa81180c291ec1d6171ac0ad6313a1ab74 on Yleisradio:fix/safari-local-storage-block-all-cookies into f663c23ac41beff094378738843584c5754cd6cf on bigpipe:master.


Update Travis to create GitHub Release with additional zip package of mosh-client executables and Aminal.exe

Is your feature request related to a problem? Please describe.
There is no "official" mosh-client for Windows, so we need to include own one. The problem is that the original implementation uses mosh wrapper which is written in Perl, and including the whole Perl distribution with Aminal is not desirable.
Describe the solution you'd like

I found a mosh wrapper written in Go, and made it working on Windows: https://github.com/nikitar020/mosh/tree/run-on-windows. We could include that wrapper in the Aminal distribution package on Windows.
I extracted the mosh-client executable with its dependencies and put them in the same repository as mosh-client.zip file. Those files should be included in the distribution package as well, and installed in the same directory as aminal.exe file.

[update:15.02.19:MaxRis] Lets try to put all mosh related Windows binaries into the Aminal's repo and update Travis ci to build additional .zip package with latest Aminal.exe and mosh executables.

Please check bottom ([update:15.02.19:MaxRis] section) of the Issue description to get idea of what should be done to resolve this Issue.

Closed due to complete rewrite as part of bringing the project back to life, please create a new issue if still relevant. Thank you!


⚠ Bofrost.at has degraded performance

In ecf5d6c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1847 ms

Resolved: Bofrost.at performance has improved in d9923db after 6 minutes.


Segfault on write_firrtl

Version
Yosys 0.23+45 (git sha1 a64ed824e, clang 10.0.0-4ubuntu1 -fPIC -Os)
On which OS did this happen?
Linux
Reproduction Steps
read_verilog ibex_top.v
hierarchy -auto-top
proc
async2sync
write_firrtl IbexTop.fir

ibex_top.zip
Expected Behavior
Write the design to IbexTop.fir
Actual Behavior
yosys> write_firrtl IbexTop.fir

5. Executing FIRRTL backend.

5.1. Executing PMUXTREE pass.

5.2. Executing BMUXMAP pass.

5.3. Executing DEMUXMAP pass.
Segmentation fault (core dumped)

The target file remains empty.

It looks like in firrtl.cc:emit_elaborated_extmodules the result from the call to design->module(cell->type); returns NULL and always assumes that it's valid
I'm not too familiar with the internals myself but I don't think that's correct, I'll bring this up at the next dev meeting if no one else from the team chimes in before then.

The primary cause here is that there are unknown modules instantiated in the design (if you add -check to the call to hierarchy it errors out right away), but write_firrtl should handle that more gracefully.


figure out how to code offline

these react apps work great if i'm on the network.
would be better if i could code on them away from a network...so point the sites to another location to download data -- ideally a copy of the repo on the same machine.

don't really need this. closing for now.


error when handling new Typescript 2 module declaration shorthand

Bug Report

TSLint version: 3.15.1
TypeScript version: 2.0.2
Running TSLint via: gulp-tslint

TypeScript code being linted
declare module 'node-uuid/node';

with tslint.json configuration:
{
  "rulesDirectory":"node_modules/tslint-eslint-rules/dist/rules",
  "rules": {
    "align": [
      true,
      "parameters",
      "statements"
    ],
    "class-name": true,
    "comment-format": [
      true,
      "check-space"
    ],
    "curly": true,
    "eofline": false,
    "maxlinelength": [
      true,
      80
    ],
    "indent": [
      true,
      "spaces"
    ],
    "interface-name": true,
    "no-duplicate-key": true,
    "no-duplicate-variable": true,
    "no-eval": true,
    "no-extra-semi": true,
    "no-internal-module": true,
    "no-trailing-whitespace": true,
    "no-consecutive-blank-lines": true,
    "no-conditional-assignment": true,
    "no-constant-condition": true,
    "no-switch-case-fallthrough": true,
    "no-string-literal": false,
    "no-require-imports": false,
    "no-var-keyword": true,
    "no-unused-variable": true,
    "no-unreachable": true,
    "no-use-before-declare": true,
    "one-line": [
      true,
      "check-catch",
      "check-else",
      "check-open-brace",
      "check-whitespace"
    ],
    "quotemark": [
      true,
      "single"
    ],
    "semicolon": true,
    "switch-default": false,
    "triple-equals": [
      true,
      "allow-null-check"
    ],
    "typedef": false,
    "variable-name": [
      true,
      "allow-leading-underscore",
      "check-format",
      "allow-leading-underscore",
      "ban-keywords"
    ],
    "whitespace": [
      true,
      "check-branch",
      "check-decl",
      "check-operator",
      "check-module",
      "check-separator",
      "check-type"
    ]
  }
}

Actual behavior
throws error with this stacktrace:
/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/rules/oneLineRule.js:163
        if (body.kind === ts.SyntaxKind.ModuleBlock) {
                ^

TypeError: Cannot read property 'kind' of undefined
    at OneLineWalker.visitModuleDeclaration (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/rules/oneLineRule.js:163:17)
    at OneLineWalker.SyntaxWalker.visitNode (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:366:22)
    at /Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:459:63
    at visitEachNode (/Users/stevenchambers/projects/atla/atla-data/node_modules/typescript/lib/typescript.js:8247:30)
    at Object.forEachChild (/Users/stevenchambers/projects/atla/atla-data/node_modules/typescript/lib/typescript.js:8407:24)
    at OneLineWalker.SyntaxWalker.walkChildren (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:459:12)
    at OneLineWalker.SyntaxWalker.visitSourceFile (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:190:14)
    at OneLineWalker.SyntaxWalker.visitNode (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:414:22)
    at OneLineWalker.SyntaxWalker.walk (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/walker/syntaxWalker.js:7:14)
    at Rule.AbstractRule.applyWithWalker (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/language/rule/abstractRule.js:19:16)
    at Rule.apply (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/rules/oneLineRule.js:21:21)
    at Linter.lint (/Users/stevenchambers/projects/atla/atla-data/node_modules/tslint/lib/tslint.js:68:37)
    at /Users/stevenchambers/projects/atla/atla-data/node_modules/gulp-tslint/index.js:96:34
    at respond (/Users/stevenchambers/projects/atla/atla-data/node_modules/rcloader/index.js:75:7)
    at respond (/Users/stevenchambers/projects/atla/atla-data/node_modules/rcfinder/index.js:140:7)
    at next (/Users/stevenchambers/projects/atla/atla-data/node_modules/rcfinder/index.js:167:16)

Expected behavior
lint code with no errors.

I was wrong on this. I had assumed that the shorthand was usable inline with your typescript code, but it is only valid syntax for d.ts files

@symbyte Actually, I thought you could use it inline with your code as well. Thanks for the info though!

Actually, you're right. Typescript just views it as a module augmentation. In light of this I'm going to reopen the issue.

@symbyte are you able to try<EMAIL_ADDRESS>I believe the dev versions of TSLint (which are designed to work with pre-release versions of TS) should have the necessary changes to handle this correctly.
The next TSLint release, 4.0.0 will include all these changes as well.

@JKillian Sure thing! I'll give it a go in the morning and report back.

when i npm i<EMAIL_ADDRESS>it complains about needing a peer dep of tslint@^3. How do I install these two versions at the same time?

@symbyte Sounds like it's some other package doing the complaining, do you know which one it is?

@JKillian In my case it is also complaining about a peer deep of tslint@^3
This is my console output
`-- UNMET PEER DEPENDENCY<EMAIL_ADDRESS>invalid

npm WARN optional Skipping failed optional dependency /chokidar/fs
events:
npm WARN notsup Not compatible with your operating system or archi
tecture<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but non
e was installed.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but
none was installed.
npm ERR! code 1

Yep, tslint-loader doesn't allow -dev versions of TSLint. You could get them to change their package.json, or just ignore the NPM errors, everything should still work I think

Any workarounds to avoid this error and still have such module declaration in 3.15.1?

This prevents using the handy declare module "*"; declaration which gives all unknown modules a default any type. I haven't found a workaround for this yet.

I confirm that it works with the @next release. I think this can be closed.


Lint error: incorrect handling of configuration files

After #568, the Linux build succeeds but reports the following lint error. Should be an easy fix.
Lint checking error - 14 values have changed since being depended upon:
  Key:  doesFileExist _build/stage0/lib/package.conf.d/process-<IP_ADDRESS>.conf
  Old:  False
  New:  True

  Key:  doesFileExist _build/stage0/lib/package.conf.d/pretty-<IP_ADDRESS>.conf
  Old:  False
  New:  True

  Key:  doesFileExist _build/stage0/lib/package.conf.d/directory-<IP_ADDRESS>.conf
  Old:  False
  New:  True

[...]

Looks like #575 worked.
The solution may be a bit questionable, but the whole unregister + register thing is.


Focusing UWP apps returns ApplicationFrameHost.exe instead of proper data

Focusing any UWP app (not to mention a fullscreen one), returns invalid data in several fields:

active window: ActiveWindow {
    title: "Microsoft Store",
    process_path: "C:\\Windows\\System32\\ApplicationFrameHost.exe",
    app_name: "Application Frame Host",
    window_id: "HWND(3541104)",
    process_id: 15252,
    position: WindowPosition {
        x: 990.0,
        y: 190.0,
        width: 1538.0,
        height: 916.0,
    },
}

Fields process_path and app_name are affected (at least from a general look)

I have a PR ready that fixes this issue, just have a lot of uni work, but you can expect I'll get it to you soon


[Theme] Theme not applied, don't understand why (w/ code)

Hi,
I am trying to change the color of the "primary" button, among other things. As per the docs, I proceeded as following:
File Theme.js :
export default {
    spacing: spacing, // defined in same file
    fontFamily: 'Roboto, sans-serif',
    palette: {
        primary1Color: Colors.blue500, // changed
        primary2Color: Colors.blue700, // changed
        primary3Color: Colors.lightBlack,
        accent1Color: Colors.blueA200, // changed
        accent2Color: Colors.grey100,
        accent3Color: Colors.grey500,
        textColor: Colors.darkBlack,
        alternateTextColor: Colors.white,
        canvasColor: Colors.white,
        borderColor: Colors.grey100,
        disabledColor: ColorManipulator.fade(Colors.darkBlack, 0.3)
    }
};

In my <App> Component :
import ThemeManager from 'material-ui/lib/styles/theme-manager';
import Theme from './Theme';
[...]
let App = React.createClass({
    [...]
    childContextTypes: {
        muiTheme: React.PropTypes.object
    },
    [...]
    getChildContext() {
        return {
            muiTheme: ThemeManager.getMuiTheme(Theme)
        };
    },

All other components are children of App, yet, don't seem to get the modified theme.
Any hint ?
Thanks

k, I did not see all these warnings in my console :
Warning: owner-based and parent-based contexts differ (values: undefinedvs[object Object]) for key (muiTheme) while mounting XXXXX (see: http://fb.me/react-context-by-parent)
XXXX being sub components of my app.
Not sure how to fix that...

create mixins and added component?

I did that more or less, thanks !


[Bug]: homepage fix

Is there an existing issue for this?

[X] I have searched the existing issues

Add Screenshots

Is there an existing issue for this?

[x]  I have searched the existing issues

What happened?
there is a change in whole setup of homepage
Add Screenshots

@mansiruhil13 This issue exists

I will fix this issue
@mansiruhil13 Would you assign it to me

already fixed

It's not yet resolved

@poorvikaa08 i already fixed it ,it is wating in PR's,once the maintainer approves it will be live

Nobody was assigned, right?
Can you create a pull request without getting assigned for the issue??
@Anandha-Vihari How does it work?

Dude, I thought we must get assigned first, make or fix any changes, and then make PRs.
I didn't know we could work on the issues


Schematic wiring diagram

Sorry to ask such a basic question where do l find a schematic?
Hope you can help
Does anyone have a pcb for sale?
Cheers
Bruce

Hi Bruce !
This is my version of schematic for the excellent Web Radio of Edzelf. Hope it  helps.

Thanks l am running a il9341 tft. I think l will be able to change circuit for my tft.

I will be making custom PCB for this without any modules whatsoever, ie bare chips, with ability to order assembled on jlcpcb
Don't like the idea of putting together 5 different modules, will post soon link to repo.


Fix Ockam credential feature

Ockam credential feature seem to be broken. Running
cd implementations/rust/ockam/ockam

cargo check --no-default-features --features "credentials std software_vault"

Fails with
cargo check --no-default-features --features "credentials std software_vault"
    Checking ockam_entity v0.28.0 (ockam/implementations/rust/ockam/ockam_entity)
error[E0658]: custom discriminant values are not allowed in enums with tuple or struct variants
  --> implementations/rust/ockam/ockam_entity/src/credential/error.rs:8:37
   |
8  |     MismatchedAttributesAndClaims = 1,
   |                                     ^ disallowed custom discriminant
...
22 |     InvalidCredentialPresentation(u32),
   |     ---------------------------------- tuple variant defined here
   |
   = note: see issue #60553 <https://github.com/rust-lang/rust/issues/60553> for more information

error[E0277]: the trait bound `credential::messages::CredentialProtocolMessage: ockam_core::Message` is not satisfied
   --> implementations/rust/ockam/ockam_entity/src/credential/workers/verifier.rs:56:14
    |
56  |         msg: Routed<Self::Message>,
    |              ^^^^^^^^^^^^^^^^^^^^^ the trait `ockam_core::Message` is not implemented for `credential::messages::CredentialProtocolMessage`
    |
note: required by a bound in `Routed`
   --> /ockam/implementations/rust/ockam/ockam_core/src/message.rs:109:22
    |
109 | pub struct Routed<M: Message> {
    |                      ^^^^^^^ required by this bound in `Routed`

error[E0277]: the trait bound `credential::messages::CredentialProtocolMessage: ockam_core::Message` is not satisfied
   --> implementations/rust/ockam/ockam_entity/src/credential/workers/presenter.rs:61:14
    |
61  |         msg: Routed<Self::Message>,
    |              ^^^^^^^^^^^^^^^^^^^^^ the trait `ockam_core::Message` is not implemented for `credential::messages::CredentialProtocolMessage`
    |
note: required by a bound in `Routed`
   --> ockam/implementations/rust/ockam/ockam_core/src/message.rs:109:22
    |
109 | pub struct Routed<M: Message> {
    |                      ^^^^^^^ required by this bound in `Routed`

error[E0277]: the trait bound `credential::messages::CredentialProtocolMessage: ockam_core::Message` is not satisfied
   --> implementations/rust/ockam/ockam_entity/src/credential/workers/listener.rs:34:14
    |
34  |         msg: Routed<Self::Message>,
    |              ^^^^^^^^^^^^^^^^^^^^^ the trait `ockam_core::Message` is not implemented for `credential::messages::CredentialProtocolMessage`
    |
note: required by a bound in `Routed`
   --> ockam/implementations/rust/ockam/ockam_core/src/message.rs:109:22
    |
109 | pub struct Routed<M: Message> {
    |                      ^^^^^^^ required by this bound in `Routed`

error[E0277]: the trait bound `credential::messages::CredentialProtocolMessage: ockam_core::Message` is not satisfied
   --> implementations/rust/ockam/ockam_entity/src/credential/workers/issuer.rs:65:14
    |
65  |         msg: Routed<Self::Message>,
    |              ^^^^^^^^^^^^^^^^^^^^^ the trait `ockam_core::Message` is not implemented for `credential::messages::CredentialProtocolMessage`
    |
note: required by a bound in `Routed`
   --> ockam/implementations/rust/ockam/ockam_core/src/message.rs:109:22
    |
109 | pub struct Routed<M: Message> {
    |                      ^^^^^^^ required by this bound in `Routed`

error[E0277]: the trait bound `credential::messages::CredentialProtocolMessage: ockam_core::Message` is not satisfied
   --> implementations/rust/ockam/ockam_entity/src/credential/workers/holder.rs:68:14
    |
68  |         msg: Routed<Self::Message>,
    |              ^^^^^^^^^^^^^^^^^^^^^ the trait `ockam_core::Message` is not implemented for `credential::messages::CredentialProtocolMessage`
    |
note: required by a bound in `Routed`
   --> ockam/implementations/rust/ockam/ockam_core/src/message.rs:109:22
    |
109 | pub struct Routed<M: Message> {
    |                      ^^^^^^^ required by this bound in `Routed`

Some errors have detailed explanations: E0277, E0658.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `ockam_entity` due to 6 previous errors

We should fix and also add CI checks

Can you kindly look at my PR and offer some comments? Thank you!

I'm pretty much certain that this feature doesn't exist anymore. Can someone confirm to close it? (@mrinalwadhwa @SanjoDeundiak )


feat(controller): Retry archiving later on error. Fixes #3786

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.
[x] My organization is added to USERS.md.

Fixes #3786

TestArchivedWorkflowService

TestEventOnWorkflowSuccess

TestEventOnWorkflowSuccess

TestEventOnNodeFail

FAIL: TestFunctionalSuite/TestEventOnNodeFail

FAIL: TestFunctionalSuite/TestEventOnWorkflowSuccess

FAIL: TestFunctionalSuite/TestEventOnWorkflowSuccess

FAIL: TestFunctionalSuite/TestEventOnNodeFail

Event occurring out of order:
m controller | time="2020-09-04T01:39:52Z" level=info msg="Marking workflow completed" namespace=argo workflow=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:52Z" level=info msg="Marking workflow as pending archiving" namespace=argo workflow=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:52Z" level=info msg="Checking daemoned children of " namespace=argo workflow=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:52Z" level=debug msg="Event(v1.ObjectReference{Kind:\"Workflow\", Namespace:\"argo\", Name:\"failed-step-event-wf7tt\", UID:\"6e23f453-b98b-4836-8fb9-f13447d91c44\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"3869\", FieldPath:\"\"}): type: 'Warning' reason: 'WorkflowFailed' failed with exit code 1"
 controller | time="2020-09-04T01:39:52Z" level=debug msg="Event(v1.ObjectReference{Kind:\"Workflow\", Namespace:\"argo\", Name:\"failed-step-event-wf7tt\", UID:\"6e23f453-b98b-4836-8fb9-f13447d91c44\", APIVersion:\"argoproj.io/v1alpha1\", ResourceVersion:\"3869\", FieldPath:\"\"}): type: 'Warning' reason: 'WorkflowNodeFailed' Failed node failed-step-event-wf7tt: failed with exit code 1"
 controller | time="2020-09-04T01:39:52Z" level=info msg="Workflow update successful" namespace=argo phase=Failed resourceVersion=3873 workflow=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:53Z" level=info msg="Labeled pod completed" namespace=argo pod=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:53Z" level=info msg="archiving workflow" namespace=argo uid=6e23f453-b98b-4836-8fb9-f13447d91c44 workflow=failed-step-event-wf7tt
 controller | time="2020-09-04T01:39:53Z" level=info msg="archiving workflow" namespace=argo uid=6e23f453-b98b-4836-8fb9-f13447d91c44 workflow=failed-step-event-wf7tt

Added diagnostics to print when we send a message.

@alexec Can we set up some time to go through changes?

@sarabala1979 ready for review.


Getting Illegal instruction - Building PPC e500

I can build node in the node-v8.11.3 version. But while run node.js on PowerPC , I get only error "Illegal instruction".
===================================Run Node JS ========================
(gdb) run
Starting program: /pureNeApp/EC/node
Using host libthread_db library "/lib/tls/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 805427584 (LWP 697)]
[New Thread 813861664 (LWP 700)]
[New Thread 822250272 (LWP 701)]
[New Thread 830638880 (LWP 702)]
[New Thread 839027488 (LWP 703)]
Program received signal SIGILL, Illegal instruction.
[Switching to Thread 805427584 (LWP 697)]
0x2550ffa4 in ?? ()
===================================In GDB=============================
Fatal error in ../deps/v8/src/ppc/assembler-ppc.h, line 776
Debug check failed: !ra.is(r0).
Program received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread 805427584 (LWP 10184)]
0x124aea9c in ?? ()
CPU info from NE:
cat /proc/cpuinfo
processor       : 0
cpu             : e500
revision        : 2.0 (pvr 8020 0020)
bogomips        : 524.28
chipset         : 8555E
Vendor          : Motorola SPS
Machine         : CPLAB PQ3MC1
bus freq        : 528.000000 MHz
PVR             : 0x80200020
SVR             : 0x80790011
PLL setting     : 0x4
Memory          : 2044 MB
export ProcessPathArmada="/opt/WR/WindRiverLinux-8.0-190909/ppc-85xx/bin"
export PathSysroot=/opt/MV/401CGE-host.26112018/montavista/cge/devkit/ppc/85xx/target
unset MAKEFLAGS
export PATH=$ProcessPathArmada:$PATH
export CFLAGS="-pipe -g  -fno-caller-saves -I$PathSysroot/usr/include/nptl"
export CXXFLAGS="-pipe -g -std=c++11 -fno-caller-saves -I$PathSysroot/usr/include/nptl"
export LDFLAGS="-L$PathSysroot/usr/lib/nptl"
export CC=$ProcessPathArmada/ppc_85xx-gcc
export CXX=$ProcessPathArmada/ppc_85xx-g++
export CPP=$ProcessPathArmada/ppc_85xx-gcc
export AS=$ProcessPathArmada/ppc_85xx-as
export LD=$ProcessPathArmada/ppc_85xx-ld
Required some assistance to move forward this issue.

Steps to build
./configure --dest-cpu=ppc --without-snapshot --without-intl --partly-static --debug --gdb
$ make -j6 node

@Matthew Brandyberry

@mbroadst

cc @nodejs/platform-ppc

cc @nodejs/platform-ppc

Required some guidence

@mbroadst

@richardlau

I’m not aware that anyone has successfully got Node.js working on an e500 (the V8 engine uses PPC instructions that are not available on that processor). There’s a few people trying in https://github.com/nodejs/node/issues/30323 if that helps.

@richardlau
Thanks for your support. i gone through the link but that' not help much


Chatbot doesn't report error to the user properly

See chatbot conversation:

Two problems:

The chatbot doesn't give any feedback about the successfull creation
The new blueprint doesn't show-up in the Cockpit:

Just tried again - in order to be 100% sure:
See blueprint "vm4-of-silke": https://moehaha.barcelona.aydo.com/cockpit/cockpit/Blueprints?ayspath=silke
See result: https://gig.demo.greenitglobe.com/CBGrid/Virtual Machine?id=1229

Can't reproduce.
I just create a new blueprint from the chatbot and the blueprint is avaiable in the portal.
Also the bot send a message once the blueprint is executed.

@zaibon can you try a blueprint that is a little more sophisticated?
I tried the following on the repository "dylanverstraete": https://moehaha.barcelona.aydo.com/cockpit/repo?repo=dylanverstraete

Executing the same blueprint on another repo worked, see first screenshot
Now it shows up in the Cockpit, see second screenshot
Still no/waiting for feedback from the chatbot though, first screenshot

@zaibon see screenshots below for error details as shown in Runs

Only error related to cockpit is the chatbot not reporting error to the user.
Other error relates to AYS itself