Regex search/replace sometimes corrupts text

Type: Bug
Context: I'm cleaning up a bunch of HTML files using search/replace with regular expressions. Sometimes the replace fails to properly process, corrupting the text.
Unfortunately this doesn't happen every time, even for the same regular expression. It seems to happen most of the time when the regular expression involves new lines (\n) with multiple consecutive matches.
Example:
Search: \n\s+
 with regex enabled
Replace:

Example text in file:

Expected result:

Actual result:

v>

VS Code version: Code 1.70.2 (Universal) (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:36:37.829Z)
OS version: Darwin x64 21.6.0
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 3, 2

Memory (System)
64.00GB (37.53GB free)

Process Argv
--crash-reporter-id 5dc625b0-18cb-4408-b2b8-6910c0953274

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

hexeditor
ms-
1.9.8

I can't replicate this on W11 - v1.71 Stable (please test it in v1.71).  Do you see this issue in Find in a file or Search across files?
Does it make any difference if you escape the forward slash, so try <\/div> in your regex?  The change isn't necessary for me but you might try it.

Tested with 1.71 (Stable): bug still exists
This is search across files (Cmd+Shift+F on Mac / View -> Search / the sidebar panel on the left)
Escaping the slash doesn't make a difference

I played around and the following consistently reproduces it for me:
File test.html with contents:

Create a folder on your disk and copy the test.html file in it (don't do this with VSCode! I think there's some caching/buffering going on here).

Open a new VSCode window and open the folder, but not the test.html file!

Run a Search with replace across files for: \n\s+
 with replace: X

Note that in the search result listing, the replacement is incorrect:

If you click any of the search results, the replace preview (compare window) shows also the wrong replacement

Now, with the replace preview open, rerun the search (click on the search input box and hit enter)

The replace preview will close automatically but the search results change: they are now correct

Run the search again: incorrect results

Now, open the test.html file for editing

Run the same search again: correct results

Close the file and rerun the search: replacement is incorrect again

I think it only happens when the file is not yet loaded into a buffer somewhere.

Above steps also reproduce the bug on Windows 10, v1.71, so it's not a Mac-specific bug.

This is https://github.com/microsoft/vscode/issues/131507


Improve the Scroll Bar look.

Is your feature request related to a problem? Please describe.
Currently, the scroll bar is the default scroll bar and looks unattractive.
Describe the solution you'd like
What I would do is make the scroll bar more slim and design it according to the website theme.

@GauravGupta993 okay go ahead
and CSS classes should be in  hierarchical structure

I would like to work on this issue , please assign this to me.
@MAVRICK-1

@GauravGupta993 any update?

Will have it completed by tomorrow @MAVRICK-1. If not feel free to assign it to anyone else.

@MAVRICK-1 I have made a scrollbar using the webkit-scrollbar library in CSS. But the problem is it is a bit laggy. It is better for the sign-in page and some other pages may be due to the small size of the page. Here is its video for home page.
https://github.com/MAVRICK-1/e-commerce_website/assets/123398315/d86ead1f-1631-4944-bb41-7ccf2e494855
Is this fine? Otherwise, I was thinking of exploring some libraries in React built for smooth scrolling.
Also what is meant by CSS classes should be in hierarchical structure that you wrote above because currently, I have written the CSS code for scrollbar in app.css folder through which it is applied to all pages.


Porting the changes from the main README to the react-server README

Just did a pretty simple port over from the main README in PR #286. I also changed the reference to Flux, as I don't think that there's anything in react-server that's really based on Flux, but I could be wrong. Let me know!

I don't think that there's anything in react-server that's really based on Flux

Oh, yeah, nice catch. 😬
Looks like there are two references to big pipe in there now, though?

That's fair. Removed!

This is great.  Thanks again @aickin!
Guess I'll get to try out Lera's new --skip-npm flag for v0.3.3. 😁


Fix failed "closestPoint" for space point to bspline when the closest point is at a bezier junction

Space point projects to a bspline exactly at a knot where there is a transition between 2 beziers.
(A-X) dot X' = 0 should have a root on both beziers.
but numerically the incoming bezier coffs are (-23, -18,  ..., -1.3e-9)  (+1.5e-9, 5, 10, .....)
Add simple proximity test at the endpoint.

Force-merging because unrelated test failures.


Cache ingested scratch DB

Is your feature request related to a problem? Please describe.
Consider a non-SQL source, such as an Excel file. When sq accesses that source (e.g. sq inspect @excel), it ingests the data into the scratch DB on each command. For large files, this can take some time... seconds, or even minutes. If the file doesn't change between commands, this is wasted work.
Describe the solution you'd like
sq could ingest the data the first time, e.g. into a SQLite scratch DB in /tmp. On the next command, if the source file hasn't changed, sq could skip the ingest step, and use the already populated scratch DB.

This is implemented in sq v0.47.0.


Update nav.css

Closes #328
Description
Navbar Container (nav): Sets up the basic structure of the navbar, including width, height, borders, and flexbox properties for alignment.
Buttons and Links: Styles buttons, links, and their hover effects for better interactivity and readability.
Dropdown Menus : Defines styles for dropdown menus, including positioning, width, background, shadow, and transition effects.
Browse All Categories: Styles the expanded and collapsed states of the "Browse All Categories" dropdown menu, including grid layout for items.
Media Queries: Ensures responsiveness by adjusting styles for screens narrower than 992px, such as stacking items vertically and centering text.
Additional Styles: Provides specific styles for icons, headers, and other elements to enhance visual appeal and readability.
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@MAVRICK-1 kindly review this PR

@MAVRICK-1 sir, can you please review

@MAVRICK-1 it's been a week since PR is raised kindly review as soon as possible

@mahek0620 can you share the ss of what you will fix


[WIP] adding support for suse linux

Description
Adding support for suse linux
Motivation and Context
fixes #574
How Has This Been Tested?
Not yet...
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

does not work yet:
https://gist.github.com/runningman84/197a4ceeb6934c510c868f7e82809a8e

This worked for me:
https://github.com/runningman84/sensu-chef/commit/2834183376a124e8d634aa4dc406e5c493d85059
Would you like to integrate it into your pull request or should I create a new request?

probably best if you open a new PR so you get credit. It was almost no effort what I did.


Support file base name substitution in module configuration in launch.json

Environment data

VS Code version: 1.33.0
Extension version: 2019.3.6558
Python version: Python 3.6.7 (miniconda)

Feature Suggestion
It would be great to be able to debug arbitrary files as modules without having to hardcode their path in launch.json. The best I could find was the following which at least allows to debug any file in a given directory as module.
{
  "configurations": [
    {
      "name": "Python: Module",
      "type": "python",
      "request": "launch",
      "module": "src.nn.models.${fileBasenameNoExtension}"
    }
  ]
}

Not sure if this can be done by the Python extension or would have to be implemented by VS Code itself, but basically I'm suggesting something similar to ${fileBasenameNoExtension} that returns the full dotted "path" to a file from a project's root?

This is the configuration that I used as a workaround some time ago. Don't know if it still works:
{
	// This one needs the VS Code Extension "Command Variable"
	"name": "Python: Launch as Module",
	"type": "python",
	"request": "launch",
	"module": "${command:extension.commandvariable.file.relativeDirDots}.${fileBasenameNoExtension}"
},

We are reserving this issue for Grace Hopper's Open Source Day, which will take place on September 22nd, 2023. If you're part of the event and would like to submit a contribution to this issue, please let us know, and we'll be happy to assign it to you.
For other community members who are not participating in the event, we appreciate your interest in contributing! We kindly request that you wait until after September 22nd to work on this issue. If no one from the event has been assigned to it by then, we'll gladly assign it to you. Thank you for your understanding and support!

Can I work on this?


Render Input values?

Before I invest a lot of time finding out, does anyone know if this package can include rendering of <input> values in the PDF? i.e. text inputs and checkboxes, if they are filled in. Can it be done?
We want to convert filled in HTML forms to PDF.

Closing because I've worked out a way. Having looked at the way the package works it's obvious input rendering doesn't work out of the box, but it can be made to by picking up the values on form submit and then processing the HTML to plug those in as hardcoded values before the conversion to PDF.


Please add getForecast() method on WeatherForecast

Not sure why the main data property on WeatherForecast -> forecasts is private, while I get the scope of security, at least make it accessible, it's not very intuitive to have to iterate over each item in the object just to retrieve it what the dev is looking for.
$weather = $owm->getWeatherForecast($location, $units, 'en', '', $days);
$forecast = $weather->getForecast();

Here is a proposal to improve this.

On the other hand, you can't even do temperature->now->value everything in the chain is private. Just doesn't make sense.  Not really sure why this has to be so complicated to get simple values.

Not really important, I'll close this. But I do think the consistency of this SDK should be improved, some priorities are public while others are protected, not sure it makes much sense.


Automatically pull relevant info as tags from Wikidata.

Description
When adding a relevant Wikidata item to osm, (e.g. wikidata=Q1950460) autofill relevant info, like how adding wikipedia=* will autofill Wikidata with the relevant entry.
One example I would find useful would be conflating Wikidata's GNIS Feature ID with osm's gnis:feature_id=* and pull the value from Wikidata.
Screenshots
No response

When contributing to OpenStreetMap, please review each change manually. There is a.o. potential for bad judgement. Treat editor warnings and suggestions with caution. When doing (semi- ! )automatic edits, follow the Automated Edits code of conduct.
Regarding use of Wikidata, see https://github.com/openstreetmap/iD/issues/9231#issuecomment-1214457619
(Furthermore, making adjustments to other fields which already have a default suggestions list may cause some confusion with unexperienced editors -and such suggestions will be inconsistently given based on there being proper wikidata page-.);


fix session backup/checkpoint when closing or reloading page

move onDestroy back to onbeforeunload, unclear why but initiating the session backup from onunload does not work.  also fix the typo and window.unload to window.onunload though so bkEvaluateJobManager.cancel gets called.  this closes Issue #1084

hm, this does not work if the page is closed (command-w).  it does work if the page is reloaded.
let me double check if regression applies to close.

it does.


EnvironmentObjects not being passed to .present-ed views

I'm having trouble figuring out how to have my environment objects pass along to views presented modally with the .present ViewTransition. I am getting the following error: Fatal error: No ObservableObject of type MyObject found. A View.environmentObject(_:) for MyObject may be missing as an ancestor of this view.
The following reproduces the issue:
import SwiftUI
import Coordinator

enum Route {
  case presentView(AnyView)
}

class AppCoordinator: UIViewControllerCoordinator<Route> {
  override func transition(for route: Route) -> ViewTransition {
    switch route {
    case .presentView(let anyView):
      return .present(anyView)
    }
  }
}

class MyObject: ObservableObject {
  let string = "My Object's String"

  init() {}
}

struct ContentView: View {
  var body: some View {
    ViewA()
      .environmentObject(MyObject())
      .coordinator(AppCoordinator())
  }
}

struct ViewA: View {
  @Coordinator(for: Route.self) var coordinator
  @EnvironmentObject var myObject: MyObject

  var body: some View {
    VStack {
      Button(action: {
        coordinator.trigger(.presentView(AnyView(ViewB())))
      }, label: Text("Press Me"))
      Text(myObject.string)
    }
  }
}

struct ViewB: View {
  @EnvironmentObject var myObject: MyObject

  var body: some View {
    Text(myObject.string)
  }
}

Am I missing some required setup? Or is this not possible, if I must I could make the environment objects that I create singletons, although at least one of them that will be less-than-straightforward.

Additionally, I've tried following the EnvironmentInsertions code paths, which I assumed were related to this, but I seem to have lost the thread. My coordinator doesn't have anything in self.environmentInsertions.

Any updates on this?

Any updates on this?


Remove ServiceCapabilities.FilterFunctions and TableDelegationInfo.FilterFunctions

Those are apparently useless and were creating confusion
FilterFunctions stays at column level

Public API changes: ❌CP0002 M:Microsoft.PowerFx.Core.Entities.TableDelegationInfo.get_FilterFunctions❌CP0002 M:Microsoft.PowerFx.Core.Entities.TableDelegationInfo.set_FilterFunctions(System.Collections.Generic.IEnumerable{Microsoft.PowerFx.Core.Functions.Delegation.DelegationOperator})


Because Luke loves PDFs

This adds a new extension to Brackets to allow opening PDF files using PDFJS.  Here's a screenshot of it running, showing that localization into the viewer also works (I'm loading Brackets using the fr locale):

There are a number of things still to do:

I need to figure out the right way to include the built PDFJS and the viewer.  What I have now is a mix of doing gulp build generic in the pdfjs repo, and also manually copying the images/, and locale/ stuff.  I don't really want to add another submodule, but I also don't think I can use npm (e.g., https://www.npmjs.com/package/pdfjs-dist doesn't have all the web viewer bits I need).
The viewer app I'm using needs to get re-skinned.  We can probably strip out a bunch of the features (e.g., we don't need to be able to load a PDF from the viewer).  We can also play with colours, make buttons look more like what you'd expect in Thimble, etc.  I'll need @flukeout's help with that.  You can see what the full viewer looks like here.
I need to sort out the best way to not bundle this in our static service worker cache.  The PDF stuff should only get loaded on demand, and then dynamically cached in the service worker.  Right now I am caching everything in dist/**/*.  Basically, I need to introduce some way to include an extension without having get processed by the service worker pre-cache build step.  Here's what it looks like when it triggers a load:

Finally, I need to see if there's a better way to accomplish the l10n stuff I'm doing in viewer.html.  At the very least, this should get moved to an external script vs. being inlined.  I'm not sure if I can do any better than this method, though, since PDFJS seems to block changes to locale in the viewer.
Adding @Pomax, who might find this interesting, and also @yurydelendik in case he has any thoughts/tips on the above.

Also, @flukeout, I'll need to add a PDF icon to the filetree before this lands.

I've solved the "optional extension caching" issue in https://github.com/mozilla/brackets/pull/818, and I'll move this work to src/extensions/extra to take advantage of it.

I fixed what I need in order to take advantage of #818.  As predicted, it means a lot here: we would have been caching an extra 250+ files!

Well, this works! Here's my take on this feature: It's useful mainly to check which PDF you have included in your project, in which case here's my proposal.

Ditch the zooming features and just scale it using transforms to be as wide as possible.
Limit the UI to...

Printing
Flipping between pages

Indicate how big the PDF file is
Indicate how many pages the PDF has
For viewing and other features, we can add a "view in new tab" link that uses the browser's built-in viewer.

Thoughts @humphd? I'll work on an icon now.

@humphd - I've attached the icon.

pdf.svg.zip

So, it looks like the viewer defaults to automatic zoom, which is good for us. I think we can ditch pretty much the whole UI.
Does it have a mode for a paginated view instead of showing all of the pages at once? If not, is that easy to add? I sort of like how the mac finder preview gives you that UI to go next / previous page...

@flukeout I've done a bit more work on this.  I think for our needs, the easiest thing to do is to take the existing viewer, and just strip out things we don't need.  I've started on that, and this is probably ready for you to take over.  Some things to note:

Add any HTML you need to src/extensions/extra/PDFView/htmlContent/viewer.html
CSS can go in src/extensions/extra/PDFView/styles/viewer-overrides.css
JS can go in src/extensions/extra/PDFView/bramble-pdfjs.js

I've stubbed out the API calls you'll need (file size and page info, page navigation, printing, etc).  If you add UI and hook into those, it should just work.

Hey @humphd - sorry I didn't get to this today, will do it first thing tomorrow. The video viewer stuff is taking longer than I thought.

Ok @humphd - got this running locally. Seems to open PDFs just fine.
Questions

Should I add some placeholder markup for file size, page count and have you populate it?
How can we handle light and dark themes. The viewer lives inside an iframe, so it's not aware of the theme

So I think at a minimum to get this thing done

Let's add the filesize and page count above the pages
Make it work with dark and light themes

Something like...

OK, I've done what I think you want.  You can make changes to the files I mentioned above for JS/CSS, but I got it started.

@humphd not sure if this is related to your most recent work (or something weird in my env) but I'm not able to load the PDF files in the viewer...

It looks like they are 404ing, I can't view them directly via URL either. Might be related to the symptom I'm seeing in the Font Viewer as well.

Disregard the last comment, seems to work fine now, also double-checked that theme switching works - thanks @humphd

@gideonthomas do you want to review this before I land?


serviceRequestRecord schema : release-number pattern needs an update

Currently, the schema of serviceRequestRecord has attribute "release-number" with pattern defined as ^([0-9]{1,2}).([0-9]{1,2}).([0-9]{1,2})$,
Problem statement:
A release-number is expected to be numbers separated by "."(dot). As per the current regex pattern, "." means it shall accept any character except line breaks. This allows application to accept release-number without "." as separator. example: 2/0/2 is accepted.
Proposal: The pattern can be updated as ^([0-9]{1,2}).([0-9]{1,2}).([0-9]{1,2})$ (referred from release-number pattern of other services like /v1/regard-application). In this pattern "." makes it to be strictly "."

Similar issue https://github.com/openBackhaul/OamLog/issues/208

Changed pattern to '^([0-9]{1,2})\.([0-9]{1,2})\.([0-9]{1,2})$'


CacheLib's current support of multi-SSD

Hi, thanks for opening source this great work.
Just wonder if the current CacheLib supports utilizing multiple SSD devices under a single node as the flash cache and whether it further supports running on top of multiple nodes as a distributed system. Thanks.

@wangyuyue: You can use setRaidFiles to configure multiple files/devices to be used as a single cache. And please note the file size must be identical (also see our user doc https://cachelib.org/docs/Cache_Library_User_Guides/Configure_HybridCache#1-common-settings---device).

whether it further supports running on top of multiple nodes as a distributed system

Could you elaborate this part?

Thanks for the response. I further want to know what RAID level CacheLib supports, and if it supports data sharding of multiple SSD devices at the granularity of objects rather than fixed-size blocks.

whether it further supports running on top of multiple nodes as a distributed system
Here I want to know if I can deploy CacheLib on multiple hosts, to each 1 or more SSD attaches. A host has some mechanism to get cached data from another host.
Sorry for my words being confusing. You are free to edit my issue if you find a more descriptive way.

what RAID level CacheLib supports

We only supports RAID0 device https://github.com/facebook/CacheLib/blob/main/cachelib/navy/common/Device.cpp#L82

if I can deploy CacheLib on multiple hosts, to each 1 or more SSD attaches

Yes, you can. Think of CacheLib as a library just like any other C++ libraries hence it can run on any host with "#include".

if there is some kind of communication mechanism allowing a host to get cached data from another host

CacheLib does not have such x-host communication mechanism as it's the caching engine for single-host, i.e. each cachelib instance manages its own cache and doesn't know about the outside world.


Store release

Will you release the app for the Microsoft/Windows Store? That would make it easier for me to keep up to date and test it.

This issue was solved in this #5. This repository is for native x86/x64 excutable.

I can work on that. I know how to produce an appx package with commands using Windows SDK only. Just the repository owner can submit that in Window Store.

Not the manual packaging https://docs.microsoft.com/en-us/windows/uwp/packaging/create-app-package-with-makeappx-tool
I was referring to this https://docs.microsoft.com/en-us/windows/uwp/porting/desktop-to-uwp-run-desktop-app-converter
:-)

No need to use that tool. Just waste of time :)
OK, I'll provide a temporary link of my hand-made temporary appx package.

This is a great idea because it'd solve #82. It'll remove the need for the dependency and also ensure security by handling auto updating.
I think we should not worry about building installers. We should use chocolatey and Windows Store for automated installation and updating, are perhaps the portableApps platform as well. For users who want more control, they can continue to use the zip platform, and those people would likely be "power users" enough to manually update the applications as needed.

Windows Store already has lots of free and open source software. They reflect support to community forums.
Plus, it's really not something I'd worry about, as it's mostly something advanced people would bother downloading. Windows Store also have other advanced desktop file managers, and by reading the reviews, you can tell that the users are pwoer users.
Besides, Winfile won't be compatible with Windows 10 S Mode without this.

Some queries:

Will the winfile executable be compiled without VC runtime DLL in the Appx package?
The project file (.vcxproj) should be edited (i.e. change SDK version) to Visual Studio 2017 for Appx solution file (.sln).
The solution file should be out of src folder.

@Biswa96 APPX packages work like snap packages. The dependencies will be included with the package and the underlying OS will he left untouched. That's why store app packages are so much superior to regular exe installs. They self contain all registry, DLLs, dependencies, etc. It's also why it's possible to uninstall APPX packages completely without leaving behind cruft. It's why you can install and uninstall 100s of store apps and the system remain pristine.

I don't want to know the details. I want to know that you/users want those DLL or a standalone exe file in that appx package.

@Biswa96 I did answer the question. The DLLs should be in the package.

This store version should be in different branch of this repository. What do you think?

@Biswa96 I don't think so, especially because there should be little to no difference between the store and the normal release. We'd usually need a fork if the actual code is different. In this case, it's just the deployment method that's different.
The exception is if you want to create a separate solution and VS project for the store release. Centennial allows existing VS Solutions to spit out appx packages. I think it'd be better if all the output methods are included in the main solution, from Chocolaty, Store, and any other distribution method. So that way, everytime there's a new release, the solution can just deply all the types of releases, from zip release to GitHub, Appx, release, and one for chocolatey.
But you or others may have another opinion as to why a separate solution or branch is necessary, and if so, let's hear it!

I know how to do that and the details. Here are the requirements for Appx. The solution file should be out of src folder. The vcxproj file should be edited to VS2017 build tools and SDK 16299. There would be assets folder for images and many others changes. So if there is a seperate branch then it would not conflict with the present build environment :blush:.

You are right. I forgot that this was set to VS2015. Ignore my previous post then.
I am interested to know what others think.

A Windows store release of the x86 and/or x64 versions, supported by our community makes sense.
Did someone here reserve the app name "Windows File Manager"?  I reserved "WinFile".

@craigwi I don't believe anyone outside Microsoft is allowed to have an app containing 'Windows' in the title

@ZanderBrown no that is not entirely true. The name Windows in the title is checked on case by case basis. You cannot have a title that implies that your app is an Official component of Windows released by Microsoft. You can have the Windows in the title if it is used in ways that makes it clear that it not a component of Windows.
For example, this is allowed: OpenShot Video Editor for Windows
But this NOT allowed: Windows Video Editor
This is allowed, and is a real world example: Cities Skylines Windows 10 Edition
Anyway, whoever reserved the name Windows File Manager is probably breaking the rule, if it's that entity is not Microsoft. In that case, the Store and legal team needs to release the name on the grounds of trademark.
@craigwi did your reserve it on your personal dev account or a company dev account? It should be a company account that is independent from your personal MS account so that in the future, if you wish to move on to different projects, it would be simple to just hand over the account to whoever is heading this repository.

I used my personal (non MS) account to try to reserve it.  Agree on the point about not using my MS account to enable hand off in the future.  I sent a note internally to try to track down who might have that name or the rules for using it.

Good news: the Microsoft Store team released the name Windows File Manager and I reserved it (on my personal account).

As you probably know, a Windows Store submission requires a signed binary.  The signing key needs to be trusted by Windows for a smooth install experience.  A self-signed cert doesn't seem to provide that.
I contacted the OSS folks in Microsoft and they said that if the WinFile project follows our Secure Development Lifecycle (SDL) I can get the binary signed by Microsoft's key.  The work to meet the SDL is not trivial and this approach doesn't handle the case if/when, in the future, the project transitions to a non-Microsoft person.
How are other OSS projects that ship through the Windows Store signed?  Any other thoughts?

How store manage different binary x86 and x64?

They would be packaged in the same .appxbundle / .appxupload and thus distributed together.

@craigwi there are lots of open source projects in the Windows Store. Take the Krita graphics editing app, for example.

They, like other OSS, have simply created a company Windows Store account and uploaded the package through that account. Windows Store will do the signing and no complicated process is necessary. VLC Media Player, for instance, is published in the Store using its company account, VideoLAN, and the experimental version of VLC for Windows 8 was published by VideoLAN's research department, VideoLABS.
So, if there is an existing Microsoft Open Source company account where they release apps that are not from the WDG group, we'd be able to use that. Or, perhaps, just create an account for publishing open source Microsoft apps, including this one any potential others in the future. Having a company account dedicated to only releasing open source projects from Microsoft such as this can allow future OSS MS apps get on the store quickly, as the hard work of establishing a system would have been done thanks to this project.

Now I think there is no need to make a seperate branch. Just make another solution file for Appx package. What do you think? I've make an Appx package. Someone want to test it??

@biswa96 actually, that's not a bad idea at all. Have a solution file for vs2025 (as it exists currently) and another targeting VS2017 that has the additional configs to deploy an Appx package.
In fact, the timing couldn't be more perfect. Visual studio very recently got an update that allows us to easily build APPX packages for Win32 projects right from the IDE without going through complicated hoops like the desktop app converter, manual package creation, or relying on third party tools like InstallShield. UWP VS projects could deploy Appx packages, and now, so can Win32 ones.
Also, since I only have VS2017 running, I couldn't even open the solution file without being forced to upgrade then solution to VS2017. I assumed I'd be able to just install some older SDKs to be able to open the solution directly in VS2017. But VS told me to either upgrade or install an entire copy of VS2015 with C++ support.
If there is a way to open the solution in VS2017 without needing to covert it, do let me know, thanks!
Because of this, I copy the cloned repository to a sandboxed location before opening VS to build the application for fear of accidentally changing the original solution in one of my cloned repositories.
By having a VS 2017 solution, people with VS2017 can use it to quickly open and build the application and also generate Appx packages while people still on VS2015 can continue using the original solution file.

I know both processes.

@Biswa96 are you referring to the Appx package generation or opening VS2015 soln in vs2017? I remember that you, at least I think it was you, mentioning that you knew how to generate Appx packages for Win32 files. So it makes perfect sense that you would know multiple processes for doing this.
As for me, I never gotten around with building app packages myself, so having it now part of the IDE is a big help for me.

I'm getting the store version of WinFile ready.  I recall someone created a high res icon for WinFile, but I can't seem to find it.   Anyone know where that is?

I'd suggest to use a SVG file then convert it to multiple PNG files in any photo editing tool. Visual Studio generates blurry images during conversion from high resolution to low resolution.

@craigwi Perhaps are You looking for #33 ?

I found what I was looking for in https://github.com/Microsoft/winfile/pull/73 (inside the ico file).

Curious.  Someone already released a version of this code: https://www.microsoft.com/store/productId/9ND2N28DX22H.  Yours for only $10.99.  Their market will dry up soon...

Store release is done.  Web link is https://www.microsoft.com/store/apps/9P7VBBBC49RB.
Version is 10.1.3 which has the same features as the previously released version 10.0.1901.1.
Do report issues with the store release and create new issues entries, not reuse this one.

After downloading from the store and installing, I was unable to leave a Winfile review on Microsoft’s Store.
I tried in Edge, IE and Chrome, all using my regular Microsoft account. The page says that the product is installed but that I "cannot rate or leave a review as I do not own the product".
Anyway, I'm over the moon with it, well done.
Chris


Add CI

This repo should have CI to enforce a deployable main branch.

Ham v2 has been moved; closing issues not relevant for v1.


Specifying the data directory using -v

I have a postgres11 from the docker maintained postgres image here. I started to use the -v argument to specify a data directory and this has been working at keeping the data across restarts.
cd playpen/postgres/11/alpine
docker build -t pg11-beta4-alpine  .
docker run -p 5433:5432 -v /playpen/postgres/data:/var/lib/postgresql/data pg11-beta4-alpine

And that has been working fine. Though when trying the same with the the postgis image on my fork with postgres 11 beta 4. it will boot though it won't install postgis.
cd /playpen/docker-postgis/11b4-2.5  # this is my fork
docker build -t pg11b4-postgis2.5 .
docker run -p 5433:5432 -v /playpen/postgres/data:/var/lib/postgresql/data pg11b4-postgis2.5
2018-09-29 23:20:43.252 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2018-09-29 23:20:43.253 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2018-09-29 23:20:43.257 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2018-09-29 23:20:43.444 UTC [25] LOG:  database system was shut down at 2018-09-29 23:10:50 UTC
2018-09-29 23:20:43.479 UTC [1] LOG:  database system is ready to accept connections

If I leave out the -v it runs the set up scripts fine as expected.
docker run -p 5433:5432 pg11b4-postgis2.5
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

fixing permissions on existing directory /var/lib/postgresql/data ... ok
creating subdirectories ... ok
selecting default max_connections ... 100
selecting default shared_buffers ... 128MB
selecting dynamic shared memory implementation ... posix
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok
syncing data to disk ... ok

WARNING: enabling "trust" authentication for local connections
You can change this by editing pg_hba.conf or using the option -A, or
--auth-local and --auth-host, the next time you run initdb.

Success. You can now start the database server using:

    pg_ctl -D /var/lib/postgresql/data -l logfile start

****************************************************
WARNING: No password has been set for the database.
         This will allow anyone with access to the
         Postgres port to access your database. In
         Docker's default configuration, this is
         effectively any other container on the same
         system.

         Use "-e POSTGRES_PASSWORD=password" to set
         it in "docker run".
****************************************************
waiting for server to start....2018-09-29 23:21:04.694 UTC [45] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2018-09-29 23:21:04.709 UTC [46] LOG:  database system was shut down at 2018-09-29 23:21:04 UTC
2018-09-29 23:21:04.714 UTC [45] LOG:  database system is ready to accept connections
 done
server started

/usr/local/bin/docker-entrypoint.sh: sourcing /docker-entrypoint-initdb.d/postgis.sh
CREATE DATABASE
UPDATE 1
Loading PostGIS extensions into template_postgis
CREATE EXTENSION
CREATE EXTENSION
CREATE EXTENSION
CREATE EXTENSION
Loading PostGIS extensions into postgres
CREATE EXTENSION
CREATE EXTENSION
CREATE EXTENSION
CREATE EXTENSION

waiting for server to shut down....2018-09-29 23:21:07.661 UTC [45] LOG:  received fast shutdown request
2018-09-29 23:21:07.666 UTC [45] LOG:  aborting any active transactions
2018-09-29 23:21:07.668 UTC [45] LOG:  background worker "logical replication launcher" (PID 52) exited with exit code 1
2018-09-29 23:21:07.689 UTC [47] LOG:  shutting down
2018-09-29 23:21:07.825 UTC [45] LOG:  database system is shut down
 done
server stopped

PostgreSQL init process complete; ready for start up.

2018-09-29 23:21:07.877 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2018-09-29 23:21:07.877 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2018-09-29 23:21:07.881 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2018-09-29 23:21:07.895 UTC [82] LOG:  database system was shut down at 2018-09-29 23:21:07 UTC
2018-09-29 23:21:07.900 UTC [1] LOG:  database system is ready to accept connections

Any guidance on what needs to changed to allow postgis to be installed and -v to be used would be appreciated.

My mistake. Just tried again after debugging the postgres/11/alpine/docker-entrypoint.sh and noticed init scripts won't run if there is a existing data directory. And this makes sense. This time it does let me create the extension manually on the existing databases I already set up when I restored onto an image postgres/11/alpine.


hyperterm crashes when opening new window, and closing that window

I am running on ubuntu 16.04, via npm start
If I create a new window (via Shell-> New Window, ctrl-n doesnt work for some reason), and then close that new window, either by clicking window close, or typing ctrl-d, hyperterm exits all open windows.
The output as follows, with the 'session not found' appearing after closing the window

<EMAIL_ADDRESS>start /home/nick/code/hyperterm
electron app

running in dev mode
electron will open file:///home/nick/code/hyperterm/app/index.html
ignoring auto updates during dev
ignoring auto updates during dev
session not found by e2044dcc-7588-415d-9a54-9cc832b364af
session not found by null
session not found by null

If  there is  more verbose logging that I can enable (electron debugging?), I will dig into this more.
Cheers

This happens on here as a start point for those who wants to play around

Probably fixed.
Feel free to reopen


Infinite "loop_analysis" optimization

Minimal example that demonstrates the issue: (if I remove any of the seemingly useless lines the problem disappears)
def func_a(var_a):
    inventory = {}
    if var_a:
        pass
    elif var_a:
        pass
    elif var_a:
        inventory = {}

    for _ in ():
        inventory = {}

    for _ in ():
        if var_a:
            for _ in ():
                inventory = {}
        elif var_a:
            for _ in ():
                inventory = {}

The output from nuitka with --verbose is the following lines repeated forever:
Nuitka-Optimization:INFO: test3.py:13 : loop_analysis : Loop has incomplete variable types after 1 attempts for 'inventory'.
Nuitka-Optimization:INFO: test3.py:13 : loop_analysis : Loop has complete variable types after 1 attempts.
Nuitka-Optimization:INFO: test3.py:13 : loop_analysis : Loop has incomplete variable types after 1 attempts for 'inventory'.
Nuitka-Optimization:INFO: test3.py:13 : loop_analysis : Loop has complete variable types after 1 attempts.

The infinite loop occurs on nuitka >= 0.6.10 with python 2.7.
Nuitka installed from pip both with and without a virtualenv, python from apt.
Reproduced on:
0.6.11rc1 (develop branch)
Python: 2.7.17 (default, Sep 30 2020, 13:38:04)
Executable: /home/kenrick/nuitka_tests/VENV_develop/bin/python
OS: Linux
Arch: x86_64

0.6.10
Python: 2.7.17 (default, Sep 30 2020, 13:38:04)
Executable: /home/kenrick/nuitka_tests/VENV_0_6_10/bin/python
OS: Linux
Arch: x86_64

0.6.10
Python: 2.7.13 (default, Aug 22 2020, 10:03:02)
Executable: /usr/bin/python
OS: Linux
Arch: armv7l

This appears to be a regression because the above sample compiles successfully with:

nuitka 0.6.10, python 3
nuitka 0.6.10rc5, python 2.7
nuitka <IP_ADDRESS>, python 2.7

Reproduced it, thanks for the report!

So, this is of course inventory causing it. Nuitka compares for loop tracing, the previous optimization run state at loop entry with the current one, and then can decide to restart it if the pre-conditions changed:

<ValueTraceMerge of (<ValueTraceAssign at Mini.py:2 of <Node EXPRESSION_CONSTANT_DICT_EMPTY_REF value {} at Mini.py:2 True>>,
<ValueTraceMerge of (<ValueTraceAssign at Mini.py:2 of <Node EXPRESSION_CONSTANT_DICT_EMPTY_REF value {} at Mini.py:2 True>>,
<ValueTraceMerge of (<ValueTraceAssign at Mini.py:2 of <Node EXPRESSION_CONSTANT_DICT_EMPTY_REF value {} at Mini.py:2 True>>,
<ValueTraceAssign at Mini.py:8 of <Node EXPRESSION_CONSTANT_DICT_EMPTY_REF value {} at Mini.py:8 True>>)>)>)>,

This is a bit tedious to read, but the repr are the same, but somehow our comparison function fails find attest that the traces are equivalent.

Ok, I was confusing myself by tracing in the wrong spot, comparing a value basically to itself.
What's really going on, is that in the next run, that a trace merge is compared with a non-merge trace. It could be the case, that later merging removes an unnecessary merge of identical stuff. I will need to add a big of debugging aids for these traces to become better in display. Esp. nested merge traces are barely readable to me right now.

Ok, I got this I think. Nuitka is using a set object when merging branches, therefore making the order of branches random on Python2 and I think probably up until 3.6 where I know that the dict got ordered.
In fact, if sets are ordered after some version, Nuitka can stop using OrderedSet as its own implementation and instead use the standard set.
And I'd like to thank for your thorough report, the fact that you saw a Python3/Python2 difference is what made me go right to the merging of the branches and made this easy to find.

What I said about Python3 is untrue. For new set objects it's hard to demonstrate that they are not ordered, this is only actually happening, if I clear them before deleting them, otherwise they seem to be always big enough and to retain ordered. But when I do that, all Python versions show this. Since it's relatively random, there probably has to be some bad luck to be involved to reorder branches in value's merge traces.
The comparison of these merge traces also could do a comparison that would compare all branches with all branches to see if one is a match for every other one, but that's too much overhead.
Unfortunately the OrderedSet is going to make the merging of branches in tracing yet again more expensive, but what can we do, correctness wins.

This is on factory now https://nuitka.net/doc/factory.html and will be in the next hotfix <IP_ADDRESS> once released.

Long released.

Long released.


publish abi3 wheels

Codecov Report

Merging #209 (257e571) into master (09c651b) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 257e571 differs from pull request most recent head 83ef663. Consider uploading reports for the commit 83ef663 to get more accurate results

@@            Coverage Diff            @@
##            master      #209   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           18        18
=========================================
  Hits            18        18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c651b...83ef663. Read the comment docs.


DX-402 Add Validation for Webhook Subscription event

Event Subscription Restrictions
When creating or updating a webhook, partner applications must adhere to the following restrictions:
Non-Duplicate Subscriptions: Partners should not be allowed to subscribe to an event that has already been assigned to another webhook within the same application.
Error Handling: If a webhook creation or update request is attempted for an event that has already been subscribed to, the API will return an error response to notify the partner application.

Thanks, awaiting for Payments team to confirm!


Add support for widget themes

Themes:

[ ] Seamless integration widget, transparent background, no border etc.
[ ] Dark widget

I'm closing this because it's not going to be addressed in the current version, and will be part of the next, and will be kept track of outside of this issue.


Scatter density

Hi all,
I added a new parameter called density which is another way of seeing the density of the points (similar to the 2D histogram), if density=True then show_hist will be flagged as false; by default density=False
This is how it looks like, in the following examples bins=0.3, cmap="rainbow" , and just showing quantiles =  [0.3 ,0.5, 0.9, 0.95, 0.99, 0.999].  The data size is about ~60,000 points

When density=False and show_points=False we get the 2D Histogram

When density=True and show_points=True (we calculate the density with 100% of the points)

When density=True and show_points=15,000 (calculate the density with ~25% of the points and then scale the result)

As you can see all 3 plots are not the same but similar enough I would say, especially when using a sample of the data and then scaling the number of points per bin as  points_per_bin= points_per_bin *  len(points)/len(sample)
I also fixed a typo from other branches, because x=x_sample and y=y_sample  disappeared at some point hence the sampling branch stopped working.

I agree with comments, will work on them.

@jsmariegaard  I think now it should be ok


[CustomRuntime] add CN api doc for custom runtime, test=develop

Related PR: https://github.com/PaddlePaddle/Paddle/pull/39535
Origin Doc PR: https://github.com/PaddlePaddle/docs/pull/4201

Close as duplicated with https://github.com/PaddlePaddle/docs/pull/4201.


[BUG] Missing spaces cause invalid Markdown list

Description
There are missing spaces in the contributing file which prevents proper Markdown lists/formatting.
https://github.com/EddieHubCommunity/good-first-issue-finder/blob/d80ea8883ae8c85a466da27db58beefe818c8bb1/CONTRIBUTING.md?#L45-L47
Steps to contribute
If you've already forked the repository, skip to step 3

Fork the repository here.
Make a new branch named fix_markdown.
Open the CONTRIBUTING.md file in the root directory.
From lines 45-47, replace the current content with the following content.

- Add a `.env` file in the root directory of the folder

- Paste the code below inside the `.env` file with your secret token

Commit and push your changes.
Make a pull request in the head repository.

Screenshots
No response
Additional information
This is a good first issue. Please leave it open to first-time contributors and beginners.

Hey @Panquesito7 I'm a beginner and I think I can fix this. Can you assign this to me.


How to use Interval

Hi, thanks for your great library.
I want show some time in my application and i want when lasted 5s show me toast.
For example : I want how 17s countTimer, when this timer receive to 5s show me toast "just 5s".
how can i it? please help me

I use this code, but show me ever 5s .
        long time1 = (long) 17 * 1000;
        mCvCountdownViewTest1.start(time1);
mCvCountdownViewTest1.setOnCountdownIntervalListener(5000, new CountdownView.OnCountdownIntervalListener() {
            @Override
            public void onInterval(CountdownView cv, long remainTime) {
                Toast.makeText(MainActivity.this, "Just 5s ", Toast.LENGTH_SHORT).show();
            }
        });

I want just lasted 5s not ever 5s.
how can i it?

can you help me my friend? i need this. please help me

Can I modify the color of the font in the code?

Judge in onInterval


[FLINK-11702][table-planner-blink] Introduce a new table type system: InternalType

What is the purpose of the change
Introduce a InternalType system to table internal computing and code generator.
An InternalType may correspond to multiple data formats. The user uses the basic Java data format, while we use a more efficient binary format inside Table for performance, such as StringType corresponds to BinaryString internally, and JDK String corresponds to the user layer.
Brief change log
new TypeSystem: internal type
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

@flinkbot  approve description, consensus

@flinkbot approve all


get_status() doesn't return json

Hey! Thanks for a great product!
Description
geoserver-rest==2.3.4
requests==2.28.1

Geoserver API doesn't return a JSON-response to a request in the get_status() method of the Geoserver class. So return of the method doesn't produce a valid output. I'm not sure if it is only my specific problem because the get_system_status() method works just fine with a similar request.
Code to reproduce
from geo.Geoserver import Geoserver
geo = Geoserver('http://<IP_ADDRESS>:9090', username='admin', password='geoserver')
status = geo.get_status()
system_status = geo.get_system_status()
print(status)
print(system_status)

Output (truncated)
('get_status error: ', JSONDecodeError('Expecting value: line 1 column 1 (char 0)'))
{'metrics': {'metric': [{'available': False, 'description': 'Operating system', 'name': 'OPERATING_SYSTEM', 'unit': '', 'category': 'SYSTEM', 'identifier': 'OPERATING_SYSTEM', 'priority': 1, 'value': 'NOT AVAILABLE'}, ...

Possible solution
Add a header to ensure json return.
def get_status(self):
        """
        Returns the status of the geoserver. It shows the status details of all installed and configured modules.
        """
        try:
            url = "{}/rest/about/status.json".format(self.service_url)
            r = requests.get(url, auth=(self.username, self.password), headers={"Accept": "application/json"})
            return r.json()

Hi @jeafreezy, thanks for the cool package.
I encountered the same problem @gtitov mentioned, but with the create_coveragestore function.
requests==2.28.1
geoserver-rest==2.4.0

Hi @Kilometerfresserin and @gtitov, could you please use the latest version v2.4.0. I think this issue was solved with the latest release.

Hi @iamtekson. Thanks for the quick reply.
I have double-checked my version and I'm sure I'm already running on 2.4.0.
I believe it has been solved for the get_status method that @gtitov mentioned (at least that one works fine for me), but it still occurs with create_coveragestore method.

Hi @Kilometerfresserin, Please go ahead and fix the bug. I will merge it. But before doing that, could you please provide the error message on this issue or create new issue?

I've just encountered the same problem with geoserver-rest==2.4.0:
import os
from geo.Geoserver import Geoserver
from config import SETTINGS

geo = Geoserver(
    "https://my/geoserver/url",
    username=SETTINGS.GEOSERVER_USER,
    password=SETTINGS.GEOSERVER_PASSWORD,
)

fpath = r"/path/to/my_file.tif"
fname = os.path.basename(fpath)
layer_name = os.path.splitext(fname)[0]
status = geo.create_coveragestore(
    layer_name=layer_name, path=fpath, workspace="my_workspace"
)
print(status)

Gives the following error:
JSONDecodeError: Expecting value: line 1 column 1 (char 0)
If I downgrade to version 2.3.4, everything works OK.

Thank you for reporting it. I will have a look and fix the things soon. After that, we can close this issue.

Hi @Kilometerfresserin, Please go ahead and fix the bug. I will merge it. But before doing that, could you please provide the error message on this issue or create new issue?

Hi @iamtekson I've checked out main branch,  branched from it it and fixed the issue, but I seem to lack permission to publish the new branch:
jw@MacBook-Pro geoserver-rest % git push -u origin issue_86_missing_application_json
remote: Permission to gicait/geoserver-rest.git denied to Kilometerfresserin.
fatal: unable to access 'https://github.com/gicait/geoserver-rest.git/': The requested URL returned error: 403

Maybe I haven't understood github (I've only worked with self-hosted gitlab instances so far)  - could someone please explain how to do this correctly around here?

@Kilometerfresserin It is likely that only "core" project contributors have permissions to create and publish branches on the original repository. Instead, you should first "fork" the repository, which creates a copy of the original linked to your own GitHub profile. You can then create a branch on your fork, make changes and commit them to your branch. Finally, make a pull request from the original repository by comparing with changes on your branch. See e.g. here and here.
Good luck!


PowerRename: Variable not Working?

Hello! Is there any difference between the two regex variables?
Because in the overview section of PowerRename, the description for the first picture below would be "Appends ".txt" extension to existing file name" while in the second picture below, it would "Appends ".txt" extension to existing file name only if it does not have an extension."
Thank you.
Screenshots

Indeed. The combination seems to be invalid - for this purpose anyway. Using either part alone in Search, or using $1.txt in the Replace works, but only if there are no special characters (like +-#& and so on) in the filename. Seems like a bad example all together?

Indeed. The combination seems to be invalid - for this purpose anyway. Using either part alone in Search, or using $1.txt in the Replace works, but only if there are no special characters (like +-#& and so on) in the filename. Seems like a bad example all together?


fontbakery version check without network access

Observed behaviour
com.google.fonts/check/fontbakery_version
   Do we have the latest version of FontBakery installed?

I ran fontbakery without network access and received the following error message:
>> com.google.fonts/check/fontbakery_version
   Do we have the latest version of FontBakery installed?
 * ERROR: Running 'pip search fontbakery' returned an error code. Output follows :

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55150>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)': /pypi
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55690>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)': /pypi
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55810>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)': /pypi
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55a90>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)': /pypi
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55890>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',)': /pypi
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/cli/base_command.py", line 178, in main
    status = self.run(options, args)
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/commands/search.py", line 48, in run
    pypi_hits = self.search(query, options)
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/commands/search.py", line 65, in search
    hits = pypi.search({'name': query, 'summary': query}, 'or')
  File<EMAIL_ADDRESS>line 1243, in __call__
    return self.__send(self.__name, args)
  File<EMAIL_ADDRESS>line 1602, in __request
    verbose=self.__verbose
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/download.py", line 831, in request
    headers=headers, stream=True)
  File "/usr/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 581, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/pip/_internal/download.py", line 439, in request
    return super(PipSession, self).request(method, url, *args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/pip/_vendor/cachecontrol/adapter.py", line 53, in send
    resp = super(CacheControlAdapter, self).send(request, **kw)
  File "/usr/local/lib/python2.7/site-packages/pip/_vendor/requests/adapters.py", line 516, in send
    raise ConnectionError(e, request=request)
ConnectionError: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /pypi (Caused by NewConnectionError('<pip._vendor.urllib3.connection.VerifiedHTTPSConnection object at 0x10ef55550>: Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',))

   Result: ERROR

Expected behaviour
Catch ConnectionError and handle this with a more informative message that network was not detected and this version check could not be completed at maybe the info or warning level?

I agree. But it should be a FAIL-level result, because we need to ensure the latest fontbakery version is being used, otherwise all other checks would be implementing an outdated quality-assurance policy.

For this issue though, the graceful exit would be to ignore the check and allow the user to run their installed version of the tool despite the fact that it is not able to confirm that the current version is installed.  It is not clear that there is a FAIL against the current version check, only that the tool can't tell because it can't access current release data.

If it can't tell, then in my opinion it is a FAIL ;-)
(because it will necessarily have to be run again to figure out what's the actual status)

Otherwise we risk a full-PASS report based on checks that could perhaps be outdated.

well... in other words, it is mandatory to get a full-PASS report with the latest version of fontbakery before considering that a font is in an acceptably good state. A FAIL in this check would ensure that holds true.


LDAP Problems

I've had problems with the LDAP settings. I solved my problems, but I'd like to share my experience. You can perhaps add some lines to the documentation, so that other people don't need to make the same mistakes.

The first problem was that i have some special characters in my Password:
OMERO.server/bin/omero config set omero.ldap.password "hel!o"
results in an error. Then i thought, i can just use \ to except that.
OMERO.server/bin/omero config set omero.ldap.password "hel\!o"
But this does actually get used for authentication, which resulsts in a bad credentials error. You can see the config in  /OMERO.server/etc/grid/config.xml
This is the error stated in log/Blitz-0.log

[LDAP: error code 49 - 80090308: LdapErr: DSID-0C09042A, comment: AcceptSecurityContext error, data 52e, v3839]; nested exception is javax.naming.AuthenticationException: [LDAP: error code 49 - 80090308: LdapErr: DSID-0C09042A, comment: AcceptSecurityContext error, data 52e, v3839]

The next problem that occurred was

ome.conditions.InternalException:  Wrapped Exception: (org.springframework.ldap.PartialResultException):
Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name ''

This is, because omero.ldap.referral default is false. For our Active Directory we need omero.ldap.referral follow
OMERO.server/bin/omero config set omero.ldap.referral "follow"

ome.conditions.ValidationException: not-null property references a null or transient value: ome.model.meta.Experimenter.lastName; nested exception is org.hibernate.PropertyValueException: not-null property references a null or transient value: ome.model.meta.Experimenter.lastName

The last problem getting LDAP to work was the user_mapping. I've customized the option and cut some parts of it, which i thought were unnecessary.  Every variable needs to be filled! Otherwise it will fail with the error stated above.
OMERO.server/bin/omero config set omero.ldap.user_mapping "omeName=sAMAccountName, firstName=givenName, lastName=sn, email=mail, institution=department, middleName=middleName"
I hope this is the right place to put this inquiry.

Thank you for so clearly and specifically describing the issues you ran into, this will certainly help us to improve the documentation and/or error reporting for future users; we generally aim for a trend of OMERO becoming easier to install! This is a fine place to open the issue; I'll leave it open to ensure it stays on our radar.

Hi,
Writing here as the issue is still opened,
I ran in the same kind of problem, and setting all the variables in the mapping was indeed a solution, but I have still an issue with the ldap authentication because the givenName attribute is not present for all the users in the Active Directory server I'm querying. I'm not the administrator of that directory, and would prefer to keep a read only role.
Is it possible to directly map the whole cn to the firstName, lastName entries in OME,  it would be fine for me to simply catch the exception and rise a warning?

Hi @glyg,
I think this may be a separate issue, but trying to handle it here before we do anything more heavy weight:

Is it possible to directly map the whole cn to the firstName, lastName entries in OME?

Have you tried to list it twice? firstName=cn, lastName=cn -- it's not going to be overly attractive but it might unblock you. Otherwise, are there any other useful fields? (In OMERO, first and last name are required so a warning won't be possible)
~J.

HI @joshmoore
The sys admins kindly fixed the database, so the problem kind of got away but  I'm sure your fix would have worked
Thanks, I'll close the other issue with a ref to here.


asdasdasdasdasdasdasdasdasdasdasdasdasd

asdasdasdasdasdasdasdasdasdasdasdasdasdAcceptance CriteriaProposal Evaluation CriteriaLorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

This opportunity has been un-assigned

This opportunity has been assigned

This opportunity has been un-assigned

This opportunity has been un-assigned

This opportunity has been un-assigned

This opportunity has been un-assigned

This opportunity has been assigned

This opportunity has been un-assigned

This opportunity has been assigned

This opportunity has been un-assigned

This opportunity has been assigned

This opportunity has been un-assigned

This opportunity has been assigned

This opportunity has been un-assigned

This opportunity has been assigned


Remove extra argument passed to JavascriptGenerator constructor

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
no

If relevant, link to documentation update:
no

Summary
As part of https://github.com/webpack/webpack/pull/6862 I'm proposing fixes that TypeScript have found

Does this PR introduce a breaking change?
no

Other information

thank you so much


UI to search shopcart items

Made the following changes:

UI code to search shopcart items
BDD test to search shopcart items

Good job


Cleanup of "CSS features reference" article

Rendered page for review:
https://review.docs.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/css/reference?branch=pr-en-us-1550
Changes made in this PR:

Promoted h3 sections to h2 (generates long list of h2's, and weakens the "View vs. Change" h2 distinction/parent sections).
Applied style guides for wording & tagging.
Compared wording of Chrome  vs. Edge articles.
Converted :::row/col::: tagging to Markdown table.
Added newer, missing sections.

done: Added Edge screenshot for Clock Angle, & shortcut keys in latter article (4 rows).

Live Edge version of article (before this PR):
https://docs.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/css/reference#change-css

Docs Build status updates of commit 7479016:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/accessibility/navigation.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/shortcuts/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5612f30:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/accessibility/navigation.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/images/css-angle.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/shortcuts/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 9f0b8e9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/accessibility/navigation.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/images/css-angle.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/shortcuts/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md

Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.
Line 1, Column 1: [Warning: ms-prod-missing - See documentation] Missing attribute: 'ms.prod'. If you specify 'ms.technology', you must also specify 'ms.prod'.
Line 1, Column 1: [Warning: ms-prod-or-service-missing - See documentation] One of the following attributes is required: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 25, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'What's New In DevTools (Microsoft Edge 89)'.
Line 154, Column 731: [Warning: bookmark-not-found] Cannot find bookmark '#change-css' in 'devtools-guide-chromium/css/reference.md'.
Line 1, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 69b13b9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/accessibility/navigation.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/images/css-angle.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/shortcuts/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md

Line 154, Column 731: [Warning: bookmark-not-found] Cannot find bookmark '#change-css' in 'devtools-guide-chromium/css/reference.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d038882:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/accessibility/navigation.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/images/css-angle.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/css/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/shortcuts/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/whats-new/2021/01/devtools.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


dq_saturate bug

Summary
it should Limiting amplitude of voltage DQ,not current DQ
Impact
when the current is large enough,there will error
Testing
Motor drive verification

LGTM!

Thank you @zouboan


Null characters, truncated files file size variance.

Hey guys, several issues, but logging it as a single one because it might be related to the same thing.
First up, I noticed null characters being inserted into the built files. It inserts somewhere between 100k and 200k null chars. Where they are placed is always between the joining of two modules, but it's random which modules it's placed between.

Second, it seems the files vary in line length between consecutive builds with no modifications to the source:

Third, sometimes this happens:

That's the end of the file. Notice the unexpected end of input, or truncated source. All of these things are reproducible in the fact that they happen, but where they happen is kinda random.
Here's my gulp build:
module.exports = function dist () {
    var files = glob.sync('./src/js/aui*.js');

    fs.removeSync('dist/aui/js');
    fs.mkdirsSync('dist/aui/js');

    return browserify({
            entries: files,
            externalRequireName: '__aui_require'
        })
        .transform(babelify.configure({
            blacklist: ['useStrict'],
            modules: 'common'
        }))
        .plugin(factorBundle, {
            outputs: files.map(function formatToDistPath (file) {
                return 'dist/aui/js/' + path.basename(file);
            })
        })
        .bundle(function afterBundle () {
            var concatFilter = gulpFilter([ 'aui-common.js', 'aui.js' ]);
            gulp.src('dist/aui/js/aui*.js')
                .pipe(concatFilter)
                .pipe(gulpConcat('aui.js'))
                .pipe(concatFilter.restore())
                .pipe(gulp.dest('dist/aui/js'));
        })
        .pipe(vinylSourceStream('aui-common.js'))
        .pipe(gulp.dest('dist/aui/js'))
        .on('error', error);
};

I'm using Browserify 9.0.3 and Factor Bundle 2.3.3. None of these issues occur when I use Browserify directly and compile to a single resource. Unfortunately that isn't an option for us right now.
The randomness is very disconcerting especially since there's no errors during compilation.

Seems that if you move the stuff outside of the bundle callback things work a bit better. This means that .bundle() must get called prior to the streams being flushed.


[feat]:Adding an attractive hover effect on social links

feature?
I would love to add an attractive hover effect in the social links of the site. It will be more attractive and appealing.
Solution
I will make changes as shown.

Please give me a chance to work on this issue.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

PLEASE ASSIGN ME THIS TASK  UNDER GSSOC'23

I would like to work on that under GSSOC 23

We dont' want to add that as we want our site to be minimalist


Add the issus/pr template

@xiangpengzhao @miaoyq @yanxuean

Pull Request Test Coverage Report for Build 18

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 35.538%

Totals

Change from base Build 17:
0.0%

Covered Lines:
5630

Relevant Lines:
15842

💛  - Coveralls

LGTM

cool


Add an error field to RPC responses

Motivation
Calling
curl --data-binary '{"id":"foo", "method": "getinfo", "params": []}' -H 'content-type:text/plain' localhost:8232 | jq

against zcashd returns
{
  "result": {
    ...
  },
  "error": null,
  "id": "foo"
}

The response contains an error field, which https://github.com/nighthawk-apps/zcash-explorer expects. Zebra doesn't return this field which makes the explorer fail on each RPC.
Solution Proposal
Add the error field to Zebra's RPC responses

It turns out we shouldn't add the error field to the responses.
The JSON-RPC spec says:

error
This member is REQUIRED on error.
This member MUST NOT exist if there was no error triggered during invocation.
The value for this member MUST be an Object as defined in section 5.1.

So zcashd shouldn't return the error field set to null in valid responses and the explorer shouldn't expect the field in each response. It will be better to fix this upstream since making Zebra return the error field in valid responses would make it non-compliant with the JSON-RPC spec.


Permission denied on unittests.cfg

Hello!
After running the following:
$ helm install --name airflow .

I get the following error in the webserver init container:
$ kubectl logs airflow-web-6df8f8bc46-9rlg5 -c init-airflow
+ bash /usr/local/init-airflow.sh
Traceback (most recent call last):
  File "/usr/local/bin/airflow", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/opt/airflow/airflow/bin/airflow", line 21, in <module>
    from airflow import configuration
  File "/opt/airflow/airflow/__init__.py", line 36, in <module>
    from airflow import settings, configuration as conf
  File "/opt/airflow/airflow/settings.py", line 30, in <module>
    from airflow.configuration import conf, AIRFLOW_HOME, WEBSERVER_CONFIG  # NOQA F401
  File "/opt/airflow/airflow/configuration.py", line 512, in <module>
    with open(TEST_CONFIG_FILE, 'w') as f:
PermissionError: [Errno 13] Permission denied: '/usr/local/airflow/unittests.cfg'

I have made a change to the values.yaml to use the apache/airflow:latest docker image. I would expect everything to have worked the same, but maybe not.
Versions:
$ helm version
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.11", GitCommit:"637c7e288581ee40ab4ca210618a89a555b6e7e9", GitTreeState:"clean", BuildDate:"2018-11-26T14:38:32Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.11", GitCommit:"637c7e288581ee40ab4ca210618a89a555b6e7e9", GitTreeState:"clean", BuildDate:"2018-11-26T14:25:46Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Used the image this was written for and it worked, silly me opening this. Closing.


Add SVN integration (icons status and TortoiseSVN to contextual menu)

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
Add integration with Tortoise SVN. Show SVN icons in a repository folder and add Tortoise SVN to contextual menu.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here. Ex: What device type/UI layout and app version?

Both functionalities should be already present. Installing tortoise svn should be enough for it to popup in the context menu and icon overlays.
Do you see them in explorer but not in files? Even after restarting Files?

Both functionalities should be already present. Installing tortoise svn should be enough for it to popup in the context menu and icon overlays.
Do you see them in explorer but not in files? Even after restarting Files?

@melon-boy We need a little more information from you in order to investigate this issue, please reopen this issue once you have filled out the issue template.

@melon-boy We need a little more information from you in order to investigate this issue, please reopen this issue once you have filled out the issue template.

This is probably related to #8633 as the TortoiseGIT/SVN items aren't shown in the context menu on empty folder areas.


[Issue-3305] Move step shorten metadata and calculate metadataHash to client

Related issue(s)

#3305

Is your feature request related to a problem(s)? Please describe.

Fix cannot get metadata when toggle chain active

Describe the solution you'd like

Fix cannot get metadata when toggle chain active

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-3352--sw-web-runner.netlify.app


css: Scale font-size for .small buttons.

Fixes zulip#30895.
The root font-size for the app has always been 16px, and it remains the same when switching between 14px and 16px mode. This leads to .small buttons looking relatively smaller to their surroundings in 16px mode. So, if we use a unit that changes when switching between modes, we will have to multiple that value by (16/14) so that we don't change the existing behaviour for the 14px mode and make things smaller. This commit only affects .small buttons, the same named class is used in other places but does not use rem unit there and therefore does not require any changes.
The original plan was to use em instead of rem and multiply it by (16/14 * 0.8), but since em depends on the parent element, there was a case in the poll button widget where 1em was equal to 16px in the dense 14px mode. While, the right thing to do might have been some refactor to make it work as desired, the safest thing to do right now might be to use the --base-font-size-px variable directly for the 9.0 release.
I've posted a bunch of screenshots and I've looked around all the possible occurrences manually for 16px mode for anything unusually off, and I could not find any. I've also included some screenshot for channel and user group settings since the usage for this class was higher there than other components. Screenshots for every occurrence might just take a lot of time to take, compare and document and not sure if it's worth the effort. Let me know if more screenshots are needed.

Screenshots and screen captures:

Drafts page 2 occurrences - Select all drafts & Delete all drafts

14px - before
14px -  after

16px - before
16px -  after

Poll options 1 occurence - trash icon

14px - before
14px -  after

16px - before
16px -  after

User profile 2 occurrences - Subscribe & Unsubscribe

14px - before
14px -  after

16px - before
16px -  after

Add new bot - clear avatar icon - 1 occurence

14px - before
14px -  after

16px - before
16px -  after

Emoji list - delete trash icon button - 1 occurence

14px - before
14px -  after

16px - before
16px -  after

 User group - multiple occurrences - almost all buttons

14px - before
14px -  after

16px - before
16px -  after

 Channel - multiple occurrences - almost all buttons (the 3 buttons on the right were skewed with each other before the change)

14px - before
14px -  after

16px - before
16px -  after

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

While testing this PR,
Opened #30916 which is independent of this PR.
Opened #30919 which is dependent on this PR.

Looks good! Marking for integration review. Thanks, @shubham-padia!

Merged, thanks @shubham-padia!


Is it possible to run it on Mac M1?

It should be possible to run at least the CLI version.
See also:

https://blog.johnkrauss.com/installing-youtube-viewer/
https://ports.macports.org/port/youtube-viewer/


[Utility] Added option to select 7z level of compression.

Similarly to the tarCompression option, this change allows the user to select the level of compression for 7z files.
The option names follow the naming conventions used by 7z.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alexwiese sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@DavidStaheli

@brcrista

@alexwiese thanks for this great contribution!  Nice work.  Two thoughts:

Can you please change the minor version from 128 to 135?  This number corresponds with our sprint number, allowing us to track when changes are made.
What do you think about changing the option IDs from numeric ("0", "1", "3", "5", "7", "9") to their corresponding name ("normal", "fast", etc.)?  That way, when this task is used in a YAML file definition, it will be more readable, like:

- task: ArchiveFiles@2
  inputs:
    rootFolderOrFile: '$(system.defaultWorkingDirectory)'
    archiveType: 7z
    sevenZipCompression: maximum

Instead of:
- task: ArchiveFiles@2
  inputs:
    rootFolderOrFile: '$(system.defaultWorkingDirectory)'
    archiveType: 7z
    sevenZipCompression: 7

Looks good to me, but I don't own this task.  I'll let @bryanmacfarlane or @ericsciple complete the merge if they agree with adding this parameter.

@brcrista thanks. Makes sense. Please see latest commit.

For safety with values people type in YAML, you could call toLower() on sevenZipCompression before switching on it.

This should be ready to merge now.

@alexwiese sorry this slipped through the cracks! If you're still interested, I think we should take this. If you can resolve conflicts and update the task.json/task.loc.json to 2.159.0 I'll merge.

@damccorm done :)

Merged! Thanks for the really quick turnaround 😃


Fix _toc.yml for real this time?!?

I also noted some stray python and backticks from #38 so fixing that here too.


Fix Node.js version to lts-hydrogen for Docker

Without this, running with Docker tries to run in Node.js 14 which doesn't have the Fetch API.

+1, had to change nodeJS image version and add --legacy-peer-deps flag to npm install

+1.


add toggler HOC for work drawer

As a user I want to toggle drawers of content to feel as though I am in charge of the page.
Here is a HOC to allow us to add toggling to any other of out components.
TODO

[ ] typing

@davidpmccormick I'm going to ignore your initial approval as I've added a few bits that are more architectural which would be good to see what you and @gestchild think.


Where to modify the rpi5 kernel dts to enable the extra UART in pinout?

I see there's a cm2712-rpi-5-b.dtb file but I cannot find the corresponding dts file using find -name cm2712-rpi-5-b.dts*.
I want to expose a TTL in pinout from kernel to be used for my Bluetooth controller, for example the GPIO4 and GPIO5 as UART2 RX/TX. But don't know how to enable it.
As in other boards like the amlogic and rockchip based ones, it can be archived by modify the dts file.
Any tips?

There's no rpi-5 support at the moment. However, all the dts files are located in the kernel tree.

My mistake, I missup the rpi4 and rpi5.
Which one is used for rpi4b?
$find -name bcm2711-rpi-4-b.dts
./aosptree/glodroid/kernel/broadcom/arch/arm64/boot/dts/broadcom/bcm2711-rpi-4-b.dts
./aosptree/glodroid/kernel/broadcom/arch/arm/boot/dts/bcm2711-rpi-4-b.dts
./aosptree/glodroid/bootloader/u-boot/dts/upstream/src/arm64/broadcom/bcm2711-rpi-4-b.dts
./aosptree/glodroid/bootloader/u-boot/dts/upstream/src/arm/broadcom/bcm2711-rpi-4-b.dts
./aosptree/glodroid/bootloader/u-boot/arch/arm/dts/bcm2711-rpi-4-b.dts

And any tips to add the UART? Thanks.

I thinks I found it: ./aosptree/glodroid/kernel/broadcom/arch/arm/boot/dts/bcm2711-rpi-4-b.dts


Resgistration not working with Google Chrome 57.0.2987.133

I does not register, or change password, sign in... etc
here is print:

proxy problem... sorry... my bad!


What type of update are you requesting?
A new version of an existing package
Current Package Identifier
Supernova.SupernovaPlayer
Package Version
0.88+
Please describe the changes you would like to see

Reference: https://github.com/microsoft/winget-pkgs/pull/164054

I made a process error with this package, so it became removed before I created this Issue.


automation and filedescriptorset usage

minor tweaks, i'm still struggling to get the servicegenerator to do something, but saw this pattern around and thought, this is probably a good way to sanity assert. had misunderstood servicegenerator (same as you, and had failed to remember). will explore the FDS path.

moves generated protos list output to protos.list (with include_str! -> split)
moves the fds output to protos.fds
using both files as inputs in build.rs to avoid copying anything
adds a POC file appending mechanics at the end of build.rs (committed a comment line for each api)

goofed around a bit with just in here as well to try to order all the scripts in here accordingly:

Edited a lot and updated. Went with your FileDescriptorSet route, which seems viable. I think we can continue on from something like this and find corresponding types from the api-resources.json and inject as appropriate.
I'm going to be away for a few days. If you want this feel free to squash (to get rid of my failed ServiceGenerator experiments), or fixup. Otherwise I can continue on later in the week (but probably not super actively).

https://github.com/influxdata/pbjson (pbjson-build)  generates serde::Serialize/serde::Deserialize implementations from FileDescriptorSet. Maybe we can learn something from them.


feat: sdk to sdk sdjwt holder verification

Description:
Implementing a basic SDK to SDK verification flow which is currently not using VC Data Model, but just claims as plain objects.
Have added a couple of falsy and truthy test cases for full suite, with selective disclosure and presentable keys
Pending to add documentation and sample content in the demo
Checklist:

[ ] My PR follows the contribution guidelines of this project
[ ] My PR is free of third-party dependencies that don't comply with the Allowlist
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked the PR title to follow the conventional commit specification

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

188 of 227 (82.82%)  changed or added relevant lines in 7 files are covered.
10 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.6%) to 74.911%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pollux/utils/claims.ts
21
22
95.45%

src/edge-agent/didcomm/CreatePresentationRequest.ts
0
4
0.0%

src/pollux/utils/SDJWT.ts
30
35
85.71%

src/pollux/Pollux.ts
121
150
80.67%

Files with Coverage Reduction
New Missed Lines
%

src/pollux/utils/claims.ts
1
78.95%

src/pluto/repositories/CredentialRepository.ts
1
60.0%

src/domain/models/VerifiableCredential.ts
2
96.43%

src/pollux/Pollux.ts
6
80.75%

Totals

Change from base Build<PHONE_NUMBER>9:
0.6%

Covered Lines:
3403

Relevant Lines:
4341

💛  - Coveralls

@curtis-h @amagyar-iohk Please in order to verify this PR can u please:

Open the nextjs demo (holder)
Issue yourself an SDJWT Credential from the CloudAgent (using ed25519 keys)
Open a second nextjs demo (verifier)
Connect Holder and Verifier through didcomm invitation, copy did from one to the other and connect.
Create a Verification request for SDJWT from the Verifier to the Holder.

Prove the following:

We cannot verify OK if the issuer doesn't match the credential issuer
We cannot verify OK if one of the claim fields (emailAddress) doesn't match
Will verify OK if all signatures and claims are valid

Tested in 1.39.1-SNAPSHOT and will require a release from cloud-agent


Vapor 4 content

What do you think about starting to add links to content about Vapor 4? I saw that there are a couple of articles popping up about the beta.

Definitely! It’ll require some adjustment in filtering, but let me see if I can make some progress on this today (or soon).
I think to make things easier for me, I may lock down new entries related to Vapor 2 finally. It’ll reach the end of life in November of this year anyhow.

Tracking progress in #79.

Implemented, thank you!

Awesome, thank you!!


Add warning message on incomplete tests too

Hi @nunomaduro,
The warning message was not passed for incomplete tests, like it is for risky and skipped ones.
This is done.

Actually, I've just been lazy on that, and made the PR quickly directly on Github without cloning it. I could do it later if you want (or do it on your side if you're in the code before me, no matter for me).
But btw, nothing is failing here... No CI for tests on this project?! Come on @nunomaduro 😛!

I will add a test later on this. No worries.

We have CI tests on this project, no sure why they are not showing up on this pull request.

https://travis-ci.org/github/nunomaduro/collision

Thanks men! It's fixed here: https://github.com/nunomaduro/collision/commit/a442e05867fe13c9cd114b7d2b212e3999d0dd88.


Get new _rev using invokeUpdateHandler

Is there a way to get the new _rev field using the invokeUpdateHandler method to invoke an in-line update in Cloudant?
Actually the class com.cloudant.client.api.Database expose only the method public String invokeUpdateHandler that returns the response stream of the update operation. But the new _rev field is in the header of the http response (https://wiki.apache.org/couchdb/Document_Update_Handlers#Response).
So, is there a way to get it?

Currently there is no way in the API, but you can workaround using the CloudantClient#executeRequest method. For example in version 1.x something like:
HttpPut putRequest = new HttpPut(client.getBaseUri().toString()
        + "_design/yourDesignDoc/_update/yourUpdateHandler/yourDocId");
HttpResponse r = client.executeRequest(putRequest);
String rev = r.getFirstHeader("X-Couch-Update-NewRev");

Note that in the master branch this API has changed and would be something like:
HttpConnection putRequest = Http.PUT(client.getBaseUri().toString()
        + "_design/yourDesignDoc/_update/yourUpdateHandler/yourDocId");
HttpConnection response = client.executeRequest(putRequest);
String rev = response.getConnection().getHeaderField("X-Couch-Update-NewRev");

Thinking about this as an enhancement going forwards, to expose the headers would require adding a new variant of invokeUpdateHandler or changing the return type. One option would be to use the Response class, which currently has status codes, but does not expose headers or body. It would need extending or a new type added. That is quite a big change, which given this has a workaround I don't think is urgent so I'm going to mark this a possible enhancement for a 3.0.0, when there is the opportunity for API changes.

Update functions are deprecated in Couch 3.x for removal in 4.x - we won't be adding any client side APIs for them.


Missing Files and Folders

I tried installing React. Only yarn.lock, node modules and package.json were installed. I have tried severally and I am getting the same result.
During installation it gave the following errors during installation
<EMAIL_ADDRESS>Please update: there are crash fixes

warning "react-scripts ><EMAIL_ADDRESS>has unmet peer  dependency "typescript@".                                                       warning "react-scripts ><EMAIL_ADDRESS>has unmet peer depende ncy "typescript@".                                                              warning "react-scripts > @typescript-eslint/eslint-plugin > @typescript-eslint/t<EMAIL_ADDRESS>has unmet peer dependency "typescript@*".                warning "react-scripts > @typescript-eslint/eslint-plugin ><EMAIL_ADDRESS>has  unmet peer dependency<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >=  3.4.0-dev".

What are the likely steps to resolve this

Please use the issue template.

@rovansteen do you mean i should use the generated files as it is? I want to be sure everything is fine or if there is a way around it

@kennysho I don't understand what the issue is, that's why I asked you to fill out the issue template you ignored while making this issue. https://github.com/facebook/create-react-app/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

@rovansteen Thanks. I have gotten the problem solved by using yarn create react-app my-app