Added RTVE play compatibility

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

Added RTVE Play compatibility. I reverse engineered the Javascript from the website to adapt the download from RTVE player
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Thanks for the PR.
Initial review:
Don't subclass from a concrete IE class. RTVPlay doesn't even need to be its own extractor if all it's doing is adding a _VALID_URL pattern; instead you can just add the pattern to RTVEALaCartaIE._VALID_URL (it can be a list of patterns). Check the code with ruff and autopep8; see the developer instructions in the contributing guide

Does this fix #1346 ?

Thanks for the PR.
Initial review:

Don't subclass from a concrete IE class. RTVEPlay doesn't even need to be its own extractor if all it's doing is adding a _VALID_URL pattern; instead you can just add the pattern to RTVEALaCartaIE._VALID_URL (it can be a list of patterns).
Don't replace tests. Add a new test for a play URL
Check the code with ruff and autopep8; see the developer instructions in the contributing guide

Okay thank you for the suggestions and the developer guide. I'll fix that and follow the rules

Does this fix #1346 ?

Actually, yes! I just tested with the first video from https://www.rtve.es/play/videos/comando-actualidad/ (linked in the OP issue)

So I managed to follow your advices, I removed an old IE subclass that was only here to add regex and did the same for the subclass I previously created.
I also edited every tests from this extractor in order to fix and pass them (some previously linked videos were now unavailable so I found other ones)
And I reformatted the code to match the desired style

Why did you remove RTVEInfantilIE ?

Because, as it was a subclass only defined to add a regex, I grouped it in the main class. Should I revert that?

Yes please. I was only referring to the class you were adding.

Ok sorry about that then, I reverted it back (but with the change of test to make it work)

@bashonly Hi, do you consider the PR as ready to be merged or should I add something else? Thanks in advance :)

Does this only work with old shows as per this comment? https://github.com/yt-dlp/yt-dlp/issues/1346#issuecomment-951204695. I had tried with a newer show (https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419) and got stuck in an endless redirect loop.

@meGAmeS1 I'm not sure if I'm doing something wrong then, I don't have a play+ account but get stuck in
[redirect] Following redirect to https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/

@meGAmeS1 I'm not sure if I'm doing something wrong then, I don't have a play+ account but get stuck in
[redirect] Following redirect to https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/

And when you are accessing the page from your browser, what do you see? I see that for me:
!
image
Also, just to check, in what country are you? I'm in France, so maybe I have a different behaviour

@meGAmeS1 I see what you see without a Spanish VPN, the content isn't restricted from inside Spain, there's a modal that pops up that you can close to watch the episode.  I can try again without using a VPN, the other prs I was testing earlier needed that.

@meGAmeS1 I see what you see without a Spanish VPN, the content isn't restricted from inside Spain, there's a modal that pops up that you can close to watch the episode. I can try again without using a VPN, the other prs I was testing earlier needed that.

Oh I see, so indeed the content is freely available with a VPN in Spain. But it completely works with my PR:
[rtve.es:alacarta] Fetching manager info
[rtve.es:alacarta] Extracting URL: https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419
[rtve.es:alacarta] 16160419: Downloading JSON metadata
[rtve.es:alacarta] 16160419: Downloading url information
[rtve.es:alacarta] 16160419: Downloading m3u8 information
[rtve.es:alacarta] 16160419: Downloading MPD manifest
[rtve.es:alacarta] 16160419: Downloading subtitles info
[info] 16160419: Downloading subtitles: es
[info] 16160419: Downloading 1 format(s): hls-1211
[info] Writing video subtitles to: Episodio 384 [16160419].es.vtt
[download] Destination: Episodio 384 [16160419].es.vtt
[download] 100% of   77.12KiB in 00:00:00 at 358.40KiB/s
[SubtitlesConvertor] Converting subtitles
Deleting original file Episodio 384 [16160419].es.vtt (pass -k to keep)
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 648
[download] Destination: Episodio 384 [16160419].mp4
[download]  33.0% of ~ 468.59MiB at    4.51MiB/s ETA 01:03 (frag 215/648)[download] Got error: <urllib3.connection.HTTPSConnection object at 0x1070db2e0>: Failed to establish a new connection: [Errno 61] Connection refused. Retrying (1/10)...
[download] Got error: <urllib3.connection.HTTPSConnection object at 0x1070a8070>: Failed to establish a new connection: [Errno 61] Connection refused. Retrying (2/10)...
[download] Got error: <urllib3.connection.HTTPSConnection object at 0x1070abc10>: Failed to establish a new connection: [Errno 61] Connection refused. Retrying (3/10)...
[download] Got error: <urllib3.connection.HTTPSConnection object at 0x1070a8e50>: Failed to establish a new connection: [Errno 61] Connection refused. Retrying (4/10)...
[download] 100% of  464.76MiB in 00:01:28 at 5.24MiB/s
[FixupM3u8] Fixing MPEG-TS in MP4 container of "Episodio 384 [16160419].mp4"
[VideoConvertor] Not converting media file "Episodio 384 [16160419].mp4"; already is in target format mp4
[EmbedSubtitle] Embedding subtitles in "Episodio 384 [16160419].mp4"

Process finished with exit code 0

Are you sure you are using the code of my PR? Because indeed, if I use the current release of yt-dlp, I get an infinite loop:
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419
[generic] 16160419: Downloading webpage
[redirect] Following redirect to https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/
[generic] 16160419: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 16160419: Extracting information
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/episodio-384/16160419/#__youtubedl_smuggle=%7B%22force...%2F16160419%2F%22%7D
[generic] 16160419: Downloading webpage
[redirect] Following redirect to https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/#__youtubedl_smuggle...3A+%2216160419%22%7D
[generic] 16160419: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 16160419: Extracting information
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/episodio-384/16160419/#__youtubedl_smuggle=%7B%22force...%2F16160419%2F%22%7D
[generic] 16160419: Downloading webpage
[redirect] Following redirect to https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/
[generic] Extracting URL: https://www.rtve.es/play/videos/la-promesa/temporada-3-episodio-384/16160419/#__youtubedl_smuggle...3A+%2216160419%22%7D
[generic] 16160419: Downloading webpage
WARNING: [generic] Falling back on generic information extractor

@meGAmeS1 Yes, I'm sorry I had something weird with my env yesterday and it wasn't picking up the changes at first.  I tested after and it works, and with the VPN everything works.  Thank you so much for fixing this, I was about to give up yesterday on this and then saw your pr at the last moment :)

I checked out this branch and rebased it on master. Verified that it works with this very recent (yesterday) RTVE page: https://www.rtve.es/play/videos/somos-cine/colon-adn-verdadero-origen/16281015/
Nice work!
mleon@Matthews-MacBook-Air yt-dlp % ./yt-dlp.sh 'https://www.rtve.es/play/videos/somos-cine/colon-adn-verdadero-origen/16281015/'
[rtve.es:alacarta] Fetching manager info
[rtve.es:alacarta] Extracting URL: https://www.rtve.es/play/videos/somos-cine/colon-adn-verdadero-origen/16281015/
[rtve.es:alacarta] 16281015: Downloading JSON metadata
[rtve.es:alacarta] 16281015: Downloading url information
[rtve.es:alacarta] 16281015: Downloading m3u8 information
[rtve.es:alacarta] 16281015: Downloading MPD manifest
[rtve.es:alacarta] 16281015: Downloading url information
[rtve.es:alacarta] 16281015: Downloading m3u8 information
[rtve.es:alacarta] 16281015: Downloading MPD manifest
[info] 16281015: Downloading 1 format(s): hls-4976
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 1274
[download] Destination: Colón ADN. Su verdadero origen [16281015].mp4

Glad it could help someone else again @wydengyre, thanks for me letting me know.
Just to keep that branch up-to-date to the master branch I did the rebase too here
@bashonly Could you please remove the pending-fixes tag ?

Glad it could help someone else again @wydengyre, thanks for me letting me know.
Just to keep that branch up-to-date to the master branch I did the rebase too here
@bashonly Could you please remove the pending-fixes tag ?

I'm being hitted by this problem; how can I help so that this is merged?


fix: fix padding on back button, ref #25

Try out Leather build 27c9461 — Extension build, Test report, Storybook, Chromatic

This PR:

makes an adjustment to arrow position on small view when prompting for password
fixes a typo in analytics from https://github.com/leather-wallet/extension/pull/5375

Summary by CodeRabbit

Improvements

Updated error tracking for more accurate analytics in the send inscription review process.
Enhanced header component to adjust padding dynamically based on the variant, improving the user interface during onboarding on small screens.

Commit reference the wrong issue, needs full qualifier if referencing issues repo

Thanks. I wasn't sure how to link / reference.
So I can fix it, what do you mean exactly by full qualifier?
I couldn't find any other examples in git log

leather-wallet/issues#25 I think?


How to disable runOnSave when using pytest

In March release, I saw that it support for continuous test runs.
I want to know that how can I disable this function. When I save the file whose name contain "test", it'll run automatically.

Hi! Are your tests running or discovering on save? The continuous test run is an API, https://code.visualstudio.com/updates/v1_75#_continuous-test-runs,  that should have to be enabled to function so I wanted to gather a bit more information. Thanks!

@eleanorjboyd I read the document and found that I can solve it by add "python.testing.autoTestDiscoverOnSaveEnabled": false to my settings.json.
Thanks alot.

great, happy coding!


565- [POC] use logging module

Replace print statements with logging
Resolves #565
Summary
This pull request addresses the transition from using print()statements to the Python logging module. The update improves flexibility for managing output messages.
Changes made:

Replaced all occurences of print with appropriate logging levels (debug, info, warning, error)
Removed the verbose flag in favor of log levels
Replaced all f-strings with % formatting in logging statements to comply with pylint requirements

Documentation
Updated the documentation to include instructions on how users can configure logging verbosity.
Example
Added an example showing how a users can use and configure logging

@adehecq @rhugonnet @duboise-cnes We reviewed it together with @vschaffn, what do you think of this first contribution?

Seems ok from my view of the xdem code. Maybe not useful to put the example from now and maybe not at this place ?
It would be put into a pipeline code but don't know if it is necessary. @adehecq @rhugonnet your opinon ?
Otherwise, i let Glaciohack say if it is ok for xdem.
As said before, the goal is to merge CNES/CS contributions into this branch-poc branch to aggregate contributions to xdem. @adehecq @rhugonnet feel free to propose other contribution way

@vschaffn @adebardo This is great, thanks! :smile:
Good initative for the example, and documentation page! I think your new documentation page (that is not listed in the index.md right now) would fit very well in the "Reference" section of the doc (with API/Background currently, and where there would be CLI/Config section mirroring the doc of GeoUtils: https://geoutils.readthedocs.io/en/stable/), if this organization makes sense to you all as well?
For the example (not sure I'm commenting on the same commits), I agree with @duboise-cnes that it might not be the best spot, or maybe too generic. I could see it live well in the current "Basic" examples if re-structured into a Sphinx-Gallery format as the others, and calling a typical xDEM function (instead of divide) to show the logging levels (like NuthKaab?).
There is a bit of redundancy between documentation pages and Sphinx-Gallery examples, but this is intended as different users like to learn in different ways.
In terms of the code modifications: It all looks great! I would add a note in the PR description about how you dealt with the interface between tqdm and logging, which doesn't seem trivial, for posterity.
Happy with the organization of merging to GlacioHack:branch-poc. Given the nature of the POC changes, I think there should be minimal conflicts with other changes ongoing on the main branch this fall. But if you'd prefer merging each distinct contribution (like the "logging" one, which is fully documented) individually to main to avoid accumulating too much on branch-poc and potentially get more merge conflicts, this would work as well. :wink:

Thank you for your feedback, @duboise-cnes  and @rhugonnet .

Indeed, this example seems problematic; we will propose another solution.
We will also add a note in the PR regarding tqdm.
Perhaps we could do a mix of both: we can continue working on branch-poc, and if it becomes too complicated, we will do more frequent merges into main.

@rhugonnet @duboise-cnes I have taken your feedbacks into account:

I have changed the interactions between tqdm and logging in xdem.coreg.affine.py to avoid any conflict between the two in the console and added a note about this in the PR.
I have modified the logging example to be more xdem-specific (using NuthKaab coregistration) and restructured it to match the Sphinx-Gallery format.


Vendor prefixes are still needed in "modern" browsers

I found this out the hard way, that even on Safari 16.4 things like backdrop-filter and user-select: none are behind vendor prefixes. It would be nice if we could get a full list of what's prefixed and possibly even pick and choose which ones we want or to specify which browsers we support. I've since had to enable prefixing for features like these.

It would be nice if we could get a full list of what's prefixed and possibly even pick and choose which ones we want or to specify which browsers we support.

It's kind of an all or nothing thing, as far as stylis is concerned. You're right that we could maintain a list of styles that are likely to need prefixing and perhaps emit a dev-time warning if we detect one and enableVendorPrefixes isn't on?

user-select: none

Aside, shocked that user-select still needs prefixing in 2023.

::-webkit-scrollbar { width } also broke for me when migrating over to v6, if declared in a createGlobalStyle and then trying to override in a local styled.div.  v5 accepted both the global declaration and the local.

@probablyup May I ask how long this feature will be implemented? There are always unexpected errors during the development process.

I have this issue for css mask property for Chrome 114 on Mac. Mask doesn't work without prefix.  Would be nice if this prefix was added automatically :)

The functionality isn't removed, it's just not on by default: https://styled-components.com/docs/faqs#vendor-prefixes-are-omitted-by-default

However, not providing by default may cause many users to be misled, as they have a high probability of encountering such problems.

The functionality isn't removed, it's just not on by default: https://styled-components.com/docs/faqs#vendor-prefixes-are-omitted-by-default

However, not providing by default may cause many users to be misled, as they have a high probability of encountering such problems.

Yeah... my intention here was to default to shipping less CSS to the client. I get that it could be confusing though.
I wonder if we could somehow combine browserslist with what stylis is doing to only ship the specific prefixes required for the target environment... @Andarist

In Stylis v4 it's more tricky to selectively prefix things. In Emotion, I maintain a copy of the full prefixed provided by Stylis - the one in Stylis package should usually just be tree-shaken in this setup (see it here). So to integrate with browserlist somehow you'd have to have a script that would generate per-project prefixer like this (based on the one in Stylis).

::-webkit-scrollbar { width } also broke for me when migrating over to v6, if declared in a createGlobalStyle and then trying to override in a local styled.div. v5 accepted both the global declaration and the local override.

Were you able to fix this?  Using enableVendorPrefixes didn't fix it for me 😢
In my case, any ::-webkit-scrollbar* directive doesn't work, unless it is in createGlobalStyle.

@v-almonacid For me, it worked by adding & before ::-webkit-scrollbar. Something like:
&::-webkit-scrollbar {
  display: none;
}


Update setup.py

Regarding issue #33
Added sub-package to the packages list. This appears to be necessary for pip.
I didn't add mle.tests, since a user won't need them.

The ci built failed, but it doesn't seem to be at the fault of my modification. Can somebody enlighten me?

Yes, it is because of your modification. The code is not pep8 compliant anymore:
./setup.py:10:22: E231 missing whitespace after ','

Add one space after packages=['mle',

My bad. I hope it is fine now?


Watch view: Copy value copies array index instead of value

Verifting  #114353
Have the following node program:
const x = [100, 10202, 232., 32];
console.log(x);

set a breakpoint on console.log
reach the breakpoint
In the watch view, create an expression x. Expand x, the first item, Run Copy Value

-> '0' is copied to clipboard
Looks like it's always the index, not the value

@aeschli thanks for filling this.
The problem here is that the evaluateName of the first element of the array is 0 instead of x[0].
This is coming from js-debug thus forwarding to @connor4312

@aeschli thanks for filling this.
The problem here is that the evaluateName of the first element of the array is 0 instead of x[0].
This is coming from js-debug thus forwarding to @connor4312


Open source category

What will be the requisites for a final submission to be considered within the open source category? If it relies on non open source solvers (like CPLEX or Gurobi), is it still considered open source if the code produced by the team is in a public repository?

Hi!
Yes, you can get into the opensource category even if you use a commercial solver, but it has to be a MILP solver where mixte integer linear problem are solved (not constraint programming formulation for example). XPRESS, CPLEX, GUROBI or whatever solver that can be bought.
Best regards


I would like to make a logo of the app

I mean app icon

Is it okay?

I cannot make it smooth more than that

Hello give your logo i will do

see the above comment
the latest one
that is final

you can file in repo so i can merge and not ss send png i will update

Please check the above PR for the logo


feat: added a canvas-based cartesian chart

This was surprisingly straightforward, the only things that needed parameterising were the d3fc-element type and the specific render function. It's made a bit messy wth the need to propagate the transitions, but still surprisingly simple.
I can't help feeling I missed something?!
Aso, fixed casing of cartesian as per https://github.com/d3fc/d3fc/issues/111

@ColinEberhardt Lint error :cry:


Sample auth server doesn't work

Calling /oauth2/authorize doesn't redirect to login page and always fires 401 HTTP error.
Example of request:
http://auth-server:9000/oauth2/authorize?response_type=code&client_id=messaging-client&scope=openid&state=state&redirect_uri=https://openidconnect.net/callback

I've changed the creation of RegisteredClient a little bit to simplify testing:
RegisteredClient registeredClient = RegisteredClient.withId(UUID.randomUUID().toString())
				.clientId("messaging-client")
				.clientSecret("secret")
				.clientAuthenticationMethod(ClientAuthenticationMethod.BASIC)
				.authorizationGrantType(AuthorizationGrantType.AUTHORIZATION_CODE)
				.authorizationGrantType(AuthorizationGrantType.REFRESH_TOKEN)
				.authorizationGrantType(AuthorizationGrantType.CLIENT_CREDENTIALS)
				.redirectUri("https://openidconnect.net/callback")
				.scope(OidcScopes.OPENID)
				.scope("message.read")
				.scope("message.write")
				.clientSettings(clientSettings -> clientSettings.requireUserConsent(false).requireProofKey(false))
				.build();

I run the sample server at http://<IP_ADDRESS>:8888/ if someone would like to reproduce the error :)
Configuration and /oauth2/authorize.

This is a regression in the samples due to 8d57c893fb54525ffcd94ef9574a20b5a7dd066c , which disallows "localhost" has a redirect-uri host.
A proposed solution could be #275

This is a regression in the samples due to [8d57c89]
I am afraid, it's not. As I mentioned, I changed a redirect URI to "https://openidconnect.net/callback". No loopbacks.
And login page is accessible. There is no need to 'permitAll' it ;)

Ah my bad, I thought you had tried this change after noticing the samples were broken.
I cannot access your example, it times out:
$ curl -v --max-time 10 <IP_ADDRESS>:9000
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connection timed out after 10003 milliseconds
* Closing connection 0
curl: (28) Connection timed out after 10003 milliseconds

For the .permitAll(), you are correct, the login page is indeed accessible if you hit /login directly ; or try to access an invalid endpoint /foob/bar.
However, when trying to access /oauth2/authorize?... as a non-logged in user, we should get a redirect to /login but get an HTTP 401 instead.  Something in the filter chain is broken, I haven't figured out what just yet, I'll look into it tomorrow. .permitAll() fixes that particular problem on my setup, you may want to give it a try.

I cannot access your example, it times out:

Sorry for that.  I've run it again.

For the .permitAll(), you are correct, the login page is indeed accessible if you hit /login directly ; or try to access an invalid endpoint /foob/bar.

Yes, that's the case. Any other pages fire login page, as does /oauth2/authorize with invalid GET-params.

.permitAll() fixes that particular problem on my setup, you may want to give it a try.
I have tried, nothing changed.

Thanks for opening it up. I've looked into it, I don't know why I believed permitAll() changed anything. It doesn't. My bad.
The problem is linked to 85d6a1200021ceb10b41c2e708d036b7cfd7b97a . tl;dr do not use that commit until we fix it, I have to check with Joe what would the best approach be.

Longer explanation:
The sample relies on OAuth2AuthorizationServerConfiguration to build a filter chain for auth-server related endpoints. This chain now throws 401 for any unauthenticated request at the ExceptionTranslationFilter level , because of the changes in 85d6a1200021ceb10b41c2e708d036b7cfd7b97a -> the default "redirect to log in page" behavior is not present anymore, because the log-in page must be configured by the application, not spring-auth-server.
Unfortunately, there are two separate filter chains (one for spring-authorization-server, one for OAuth2AuthorizationServerApplication), so I have trouble understanding how we should do this instead.
Note that if you log in first and then visit /oauth2/authorize?..., it works.

For info I have an open PR, #275 , but it's not in a good place yet.

@avpdiver @Kehrlann This is now fixed via 2d8d568

I am running to this same problem on the 0.2.0 release

@igloo12, the sample in this repo works, so make sure you're configured similarly. Also, make sure your redirect_uri is configured with <IP_ADDRESS> and not localhost, like this sample.
You can also check out the spring-security samples project which uses the latest maven dependency.
One note, make sure you are navigating to http://<IP_ADDRESS>:8080 or similar on your client. If you start at http://localhost:8080 and get redirected to http://auth-server:9000/oauth2/authorize you will receive an error. The oauth2-login sample shows a workaround for this.


Sort the array

sort the data in the array

Sort

Please add the entire question on top as a comment. Check the other codes in the repository for reference. Also, add the file extension.


Failed to build

Hello,
I tried to compile it (2019 branch) and got the below error on Ubuntu 18.10.
Did I do something wrong?
[ 64%] Building CXX object thirdparty/clDNN/src/CMakeFiles/clDNN_shlib.dir/graph_optimizer/add_required_reorders.cpp.o
In file included from /home/pnp/repo/dldt/inference-engine/thirdparty/clDNN/src/include/layout_optimizer.h:31,
from /home/pnp/repo/dldt/inference-engine/thirdparty/clDNN/src/include/pass_manager.h:20,
from /home/pnp/repo/dldt/inference-engine/thirdparty/clDNN/src/graph_optimizer/add_required_reorders.cpp:21:
/home/pnp/repo/dldt/inference-engine/thirdparty/clDNN/src/include/generic_layer.hpp: In constructor ‘cldnn::generic_layer::generic_layer(const dto*)’:
/home/pnp/repo/dldt/inference-engine/thirdparty/clDNN/src/include/generic_layer.hpp:64:111: error: type qualifiers ignored on cast result type [-Werror=ignored-qualifiers]
, generic_params(static_cast<const kernel_selector::generic_kernel_params const>(dto->generic_params))
^
cc1plus: all warnings being treated as errors

cc1plus: all warnings being treated as errors

Workaround: remove "-Werror" from CMake files (including submodules).
No idea why it is enabled unconditionally by default.

Is this being addressed yet? Should we propose a PR with the unconditional Werrors being removed?

Apparently this is fixed in 2020.2 (95a57795dcb0ed82324af87918339225148202ca)

Sub-project inference-engine/thirdparty/ade also fails due to Werror. Bumping inference-engine/thirdparty/ade to current master fixes it.
Another fail comes from _deps/ext_onnx-build, Werror is enabled there although ONNX_WERROR is false in the cmake dldt configuration.

Another fail comes from _deps/ext_onnx-build, Werror is enabled there although ONNX_WERROR is false in the cmake dldt configuration.

https://github.com/openvinotoolkit/openvino/issues/462


Feature/grpc logging

RPC errors are not logged, the pr changes that by moving logger from children of AsyncGrpcClient to the parent. Also adds some additional logging.
Note, that grpc errors can be observed via GRPC_TRACE/GRPC_VERBOSITY env variables, but they mostly are not human-friendly

PR description does not follow the template :(


Sql tools service update in ADS to fix SC bugs

This update fixes schema compare bugs fixed on DacFx side : https://github.com/microsoft/azuredatastudio/issues/6173 and https://github.com/microsoft/azuredatastudio/issues/6174
(i.e. Propagates Files and FileGroups as two separate options and shows valid script for CEK and CMK)

@Charles-Gagnon I want to merge this to get SC bugs fixed in Aug, but please let me know if you think new ToolsService update now might be risky.

@kevcunnane since it has your changes too.


fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

SUMMARY

This reverts https://github.com/apache/superset/pull/23012 which per https://github.com/apache/superset/pull/23012#issuecomment-1496518374 introduced two known regressions. Granted we could try to roll forward with a formulation which works for both legacy and non-legacy charts, but in the interim I think it's prudent we ensure we don't regress whilst acknowledging the fact that cache warmup for non-legacy charts is still problematic.
cc: @dheeraj-jaiswal-lowes
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Ok thanks for the heads up @john-bodley . I'll make sure to incorporate the work from all prior PRs in my fix 👍


Not able to run tests on Safari under CircleCi

What is your Test Scenario?

Running tests on CircleCI using Safari as a browser
What is the Current behavior?

What is the Expected behavior?

Execute tests on CircleCi on Safari browser
What is your web application and your TestCafe test code?

 If this doesn't help, please share a minimal configuration file so we can reproduce the "Unable to establish one or more of the specified browser connections" error.
This link might also be helpful: use remote mode.


Add count_time impl

Description
in draf

coverage: 48.008% (+0.02%) from 47.992% when pulling 4dc4fca03a73cd95c6783387b4037a3fa4bb2f0f on beyyes/count_time_fe into 51cdd6a37101329845704676962d0c542d3b37a5 on master.