Incorrect detection if analyzer is actually enabled

Current implementation:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/000b45d99e2a6973db9e5fb9717822dca1404499/StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1119StatementMustNotUseUnnecessaryParenthesis.cs#L91
Problem is when GetValueOrDefault returns ReportDiagnostic.Default.
Fixed implementation:
if (context.IsDiagnosticEnabled(Descriptor))
{
}

internal static class Extensions
{
    public static bool IsDiagnosticEnabled(this CompilationStartAnalysisContext context, DiagnosticDescriptor descriptor)
    {
        ReportDiagnostic reportDiagnostic = context
            .Compilation
            .Options
            .SpecificDiagnosticOptions
            .GetValueOrDefault(descriptor.Id);

        switch (reportDiagnostic)
        {
            case ReportDiagnostic.Default:
                return descriptor.IsEnabledByDefault;
            case ReportDiagnostic.Suppress:
                return false;
            default:
                return true;
        }
    }
}

Decisions related to these checks generally predated the introduction of stylecop.json for configuration. They are problematic because many teams incrementally enable StyleCop Analyzers rules, and these checks result in multiple behavior changes in some cases where only one new rule was enabled. I'd like to address these on a case-by-case basis, resolving them by creating configuration options to clearly state intent.

The check in SA1119 seems like a remnant from the past to me, as it is checking that the rule itself is not disabled. This is unlike several other places in the code where check for the disabling of other rules are done. As far as I known this suppression is handled by roslyn itself (@sharwell can you confirm?), so this check is superfluous.
Note that the check itself has no issues, as the diagnostic is EnabledByDefault.
The proposed improvement should be implemented in:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/3d6cf939cf9c71a2346a2cd1c1ef5cc16f4ee9d9/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/DiagnosticOptionsHelper.cs#L57


fire spread does not stop the fire [1.12.2]

Hello
Again I am having the same problem that I reported a long time ago #485
But now I'm using SpongeForge 1.12.2
griefprevention-1.12.2-<IP_ADDRESS>8.jar
LuckPerms-Sponge-4.3.8.jar
Nucleus-1.6.1-S7.1-MC1.12.2-plugin.jar
spongeforge-1.12.2-2705-7.1.0-BETA-3477.jar
The instructions and steps taken are the same as those found in the previous report. #485
Thank you.

This is a duplicate of #485, and it should have been reopened instead of duplicated.
Aside from that, I'm also getting this issue on SF 3661.

@Brycey92 it is not a duplicate, no more support for version 1.10.2
This topic is for 1.12.2. The labels placed in the title must be respected.
Your post says "SF 3661", and that does not exist.

Sorry, I meant 3361! Got my digits mixed up. I'll fix it on my original comment too.

This seems to work in a manner that is confusing to most. I tested using claimflagdebug and was able to place fire(via flint and steel) in the wilderness, but it would not spread.
Placed as my normal user(with admin permissions) it would spread, so flags in the Wilderness don't apply to Admins either just as they would not in an Admin claim.
This also applies just the same in a claim of your own, if you are the source of the fire, your flags do not apply to you. It also means it does not apply to naturally generated fires, eg; from lightning strikes and lava flow.
In terms of how things are supposed to work, the fire-spread flag is working as intended.
spongeforge-1.12.2-2705-7.1.0-BETA-3481
GriefPrevention-<IP_ADDRESS>2

no its not LOL i set an override and it still will not block it

I've tested it myself on multiple occasions of it not working, and it functions as it should. If even an override is not working, it's almost a 100% guarantee your permissions are incorrectly set up and fubar'ing GP.

that not wood 😂

I did it right beside a tree as well...fix your permissions and make sure you're on latest GP

i am

Well you're doing something wrong? There...a tree. Issue is on your end.

can u add me on discord?


tweak rpc failfast

tweak rpc failfast to allow additional hresult (RPC_X_SS_IN_NULL_CONTEXT). This is because we may have null context handle if context handle for ScriptContext wasn't able to be initialized (due to jit process going away).
Also, add retry logic on the server liveness check. Server may be in process of closing but still alive. Worth waiting a bit to find out rather than having failfast right away.

@sermetiskin, @leirocks, @LouisLaf can you take a look?

@dotnet-bot test Ubuntu ubuntu_linux_debug

:shipit:


Errno::EPERM: Operation not permitted - sendto(2)

I'm getting this exception occasionally on our staging and production systems.
Full backtrace:
gelf-1.4.0/lib/gelf/ruby_sender.rb:16→ send
gelf-1.4.0/lib/gelf/ruby_sender.rb:16→ block in send_datagrams
gelf-1.4.0/lib/gelf/ruby_sender.rb:15→ each
gelf-1.4.0/lib/gelf/ruby_sender.rb:15→ send_datagrams
gelf-1.4.0/lib/gelf/notifier.rb:143→ notify_with_level!
gelf-1.4.0/lib/gelf/notifier.rb:131→ notify_with_level
gelf-1.4.0/lib/gelf/logger.rb:40→ add
gelf-1.4.0/lib/gelf/logger.rb:48→ info
[PROJECT_ROOT]/vendor/bundle/ruby/1.9.1/bundler/gems/mssngr-common-fc49a59faa0a/lib/mssngr/base/lib/daemons/taskd.rb:49→ out
[PROJECT_ROOT]/vendor/bundle/ruby/1.9.1/bundler/gems/mssngr-common-fc49a59faa0a/lib/mssngr/base/lib/daemons/taskd.rb:85→ block (2 levels) in <top (required)>
foreverb-0.3.2/lib/forever/job.rb:12→ call
foreverb-0.3.2/lib/forever/job.rb:12→ call
foreverb-0.3.2/lib/forever/base.rb:378→ safe_call
foreverb-0.3.2/lib/forever/base.rb:370→ job_call
foreverb-0.3.2/lib/forever/base.rb:117→ block (3 levels) in initialize

This is with gelf 1.4.0 and Rails 3.2.21
The error seems to occur not from the normal Rails HTTP operations but only from within two types of service processes (both of which load the full Rails environment, though). One is a delayed_job worker and the other is a foreverb task daemon. The former is forking the main process (I'm loading the gelf logger after the fork, though), and the latter is using threads - could that be connected ?
Any help would be much appreciated, I can't find any definite info on what the low-level error means :/

Just came across the same problem, no idea what's happening here. Do you happen to have any updates on this?

Nope, sorry. I'm just catching the exception and ignore it now, to no obvious ill effects so far :/

I'm receiving a similar error, but in Rails 4 and Ruby 2.0 within delayed_job.  It is happening since delayed_job is sharing the logger between threads and, currently, the ruby_sender code is not thread safe.  In actuality, it appears the UDPSocket is not thread safe in itself, but is being shared amongst threads.
A simple test to help prove my theory is this.  I've changed the socket to be unique per thread in lib/gelf/ruby_sender.rb and I no longer receive the error.
def send_datagrams(datagrams)
  host, port = @addresses[@i]
  @i = (@i + 1) % @addresses.length
  datagrams.each do |datagram|
    socket = Thread.current[:gelf_socket] ||= UDPSocket.open
    socket.send(datagram, 0, host, port)
  end
end

I'm willing to help fix this, but I'm unsure if this is a good solution.

At least it's a good explanation and as such a good start to fix the problem! :)
Just a quick note that Thread.current[:gelf_socket] will set a fiber variable so it may be slightly safer to use Thread#thread_variable_set and Thread#thread_variable_get respectively?

Hi,
I did catch the same issue with Rails 3 & delayed job. My Workaround looks like this
at the moment (within script/delayed_job):
#!/usr/bin/env ruby

require File.expand_path(File.join(File.dirname(__FILE__), '..', 'config', 'environment'))
require 'delayed/command'
require 'delayed/worker'

module Delayed
  class Worker
    class << self
      alias_method :orig_after_fork, :after_fork
      alias_method :orig_before_fork, :before_fork

      def before_fork
        orig_before_fork
      end

      def after_fork

        MyApp::Application.configure do
            config.lograge.enabled = true
            config.lograge.formatter = Lograge::Formatters::Graylog2.new
            config.lograge.logger = GELF::Logger.new('log_server', 12201, 'WAN', { :facility => 'xxx', env: Rails.env, process: Process.pid})
          end
        end

        orig_after_fork
      end
    end
  end
end

Delayed::Command.new(ARGV).daemonize

Maybe this workaround helps some one too.

Rails 4.2.4, Ruby 2.2.3. Similar error with delayed_job 4.1.1:
$ bundle exec bin/delayed_job -n 1 run
closed stream
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:16:in `send'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:16:in `block in send_datagrams'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:15:in `each'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:15:in `send_datagrams'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:143:in `notify_with_level!'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:135:in `rescue in notify_with_level'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:131:in `notify_with_level'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/logger.rb:40:in `add'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/logger.rb:48:in `info'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/worker.rb:277:in `say'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/worker.rb:163:in `start'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:131:in `run'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:119:in `block in run_process'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:265:in `call'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:265:in `block in start_proc'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:274:in `call'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:274:in `start_proc'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:295:in `start'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/controller.rb:59:in `run'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons.rb:193:in `block in run_proc'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/cmdline.rb:88:in `call'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/cmdline.rb:88:in `catch_exceptions'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons.rb:192:in `run_proc'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:117:in `run_process'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:98:in `block in daemonize'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:96:in `times'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:96:in `daemonize'
bin/delayed_job:5:in `<main>'
/home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:16:in `send': closed stream (IOError)
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:16:in `block in send_datagrams'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:15:in `each'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/ruby_sender.rb:15:in `send_datagrams'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:143:in `notify_with_level!'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:135:in `rescue in notify_with_level'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/notifier.rb:131:in `notify_with_level'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/logger.rb:40:in `add'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/gelf-1.4.0/lib/gelf/logger.rb:48:in `fatal'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:135:in `rescue in run'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:124:in `run'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:119:in `block in run_process'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:265:in `call'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:265:in `block in start_proc'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:274:in `call'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:274:in `start_proc'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/application.rb:295:in `start'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/controller.rb:59:in `run'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons.rb:193:in `block in run_proc'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/cmdline.rb:88:in `call'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons/cmdline.rb:88:in `catch_exceptions'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/daemons-1.2.3/lib/daemons.rb:192:in `run_proc'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:117:in `run_process'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:98:in `block in daemonize'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:96:in `times'
	from /home/campaign/apps/shared/bundle/ruby/2.2.0/gems/delayed_job-4.1.1/lib/delayed/command.rb:96:in `daemonize'
	from bin/delayed_job:5:in `<main>'

The fix to the startup script above didn't seem to help.

I use a little bit older versions
delayed_job (4.0.0)
gelf (1.4.0)
lograge (0.3.4)
rails (3.2.22)
Maybe lograge is the part which keeps my monkey patch running.

The patch from markglenn works for me. Will look into the suggestion from milgner.

+1 for the markglenn patch, I'm now using the fork of @swalberg in production, and it seems to work fine so far in both foreverb and delayed_job.

This has been fixed in 3bd9fc9. Thanks for all the debugging and patches! :smiley:

\o/


Debug changed variables highlight does not fade away

VSCode Version: 1.1.0
OS Version: Windows 10

Observe how al is highlighted, but the highlight does not fade away after a while.

fyi @isidorn

That's odd.  It should fade using the animation debugViewletValueChanged.
@keyframes debugViewletValueChanged {
	0% { background-color: rgba(86, 156, 214, 0) }
	5% { background-color: rgba(86, 156, 214, .75) }
	100% { background-color: rgba(86, 156, 214, .3) }
}
.debug-viewlet .monaco-tree-row .expression .value.changed {
	padding: 2px;
	margin: 4px;
	border-radius: 4px;
	background-color: rgba(86, 156, 214, .5);
	animation-name: debugViewletValueChanged;
	animation-duration: .75s;
	animation-fill-mode: forwards;
}

However, I noticed that it's not using the correct animation-name.  See below.  This seems to be happening at build time (see blow web inspection of it in VS Code Alpha).

@isidorn could you take a look at what's going on with this.

@bgashler1 sure, I can investigate

Yup, this was happening due to css minification, with Joao's help we could fix it.

That looks scary

You guys are pros! Thanks


[Refactor] Change to_tensordict to clone when called

Description
This PR aims to change tensordict.to_tensordict behaviour. The idea is to make a clone each time the method is called.
Motivation and Context
The motivation behind it is clone the tensordict when performing .to_tensordict.

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] New feature (non-breaking change which adds core functionality)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)

Thanks @nicolas-dufour for this.
Here's how I would see this instead:
For TensorDictBase, return a tensordict like this
TensorDict({key: value.clone() if not isinstance(value, TensordictBase) else value.to_tensordict() for key, value in self.items()}, **metadata)

And metadata are all the values precomputed elsewhere EXCEPT memmap (it won't be memmap because we clone) shared mem (idem). We can leave the metatensor empty (since the metadata will change).
For savedtensordict we would need to do the same but load the tensordict first.
Hope that makes sense!

LGTM! Let's address these two comments and make the tests pass, then we're good to go!

@nicolas-dufour also we should rename this PR
why not: "make to_tensordict() create a copy of the content"?


Added pytablereader to setup.py and requirements.txt

It appears to get installed automatically with python 3 but not with python 2.  I'm not entirely certain what is going on, but see for example https://travis-ci.org/dhs-ncats/pshtt/jobs/301761188.
Also added test requirements to setup.py

I'm wondering also what the use is in keeping a separate requirements.txt file in pshtt, since it doesn't contain any information not in setup.py.  I'd like to suggest removing it.  The sample project from PyPA does not include one.

@jsf9k -- My approach (not sure if it's the right one) is to use setup.py to define what the package actually requires to run, while the requirements.txt is more of a developer resource. Therefore, it might include things like coverage, pytest, etc which wouldn't be needed to use the package, instead just to do development of it.

@IanLee1521 -- setup.py does allow you to add extra requirements that are not installed unless you specifically request them.  See here, for example.  That's what I did in this commit.
I'm still confused on the difference between setup.py and requirements.txt though.  It seems like you can put concrete (package, version, and where to get it from) dependencies in requirements.txt for repeatable builds, while setup.py can only contain abstract dependencies (package and version only).  We aren't making use of concrete dependencies in the pshtt requirements.txt file, though.  I feel like we have two files that you have to keep in sync when you want to add, remove, or change a dependency, so that's why I'm bringing this up.

Right, the issue is that with putting the extra dependencies in setup.py, you have to install the package locally to get those. The requirements.txt is typically used in conjunction with a virtual environment, and then leverages the directory of Python files (in this case pshtt-git-clone/pshtt/..., rather than the files that the setup installation would place in your python lib path.
But I take your point... One thing that we could do to compress these might be to have the real requirements in setup.py and change the requirements.txt to something like:
# Install the package into the (virtual)-environment, in editable mode
-e .

# Extra testing stuff
coverage
pytest
ipython
...

When I'm working on pshtt I work in a venv, and I just install the package to the local venv with pip install -e ..  With the changes I made to setup.py I can just run pip install -e .[test] instead or in addition if I want to run the tests.  I don't see the need for the separate requirements.txt file unless you want to use it to make concrete dependencies, which we're not doing.
How is the process you described different?

I suppose we could also change the requirements.txt file to
-e .[test]

I completely agree about it being a problem with these files getting out of sync. I think requirements.txt is nice to have around, and is often what people expect in a dev workflow.
It would also be required if we ever wanted to, even temporarily, pin to a git repository instead of a PyPi-published package. I'm currently doing that in domain-scan with pshtt itself, as pshtt is currently evolving faster than its PyPi publication rate.
The solution of using -e .[test] as the requirements.txt content to keep these in sync seems right to me, and also properly semantically expresses that a dev workflow requires installing the test dependencies in setup.py.

Also, I just resolved the merge conflict (it was from me moving requests_cache in a previous PR).


Added Number of Visits Count

Description
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.
#502
Pull Request Checklist
Please make sure that your PR meets the following requirements:

[x] The app is working correctly after applying the changes.
[x] The app is responsive and displays properly on different screen sizes and devices.
[x] The changes are thoroughly documented in the appropriate files or documentation sections.
[x] The coding conventions and style guidelines are followed consistently.

Checklist
Please check all applicable boxes and provide any additional information if needed.

[x] I have tested the changes locally and ensured that the app is functioning as expected.
[x] I have verified that the app is responsive and looks good on various screen sizes and devices.
[x] I have reviewed the documentation and ensured that it accurately reflects the changes made.
[x] I have followed the coding conventions and style guidelines defined in the project.
[x] I have run the automated tests and all of them pass.
[x] I have considered the performance implications of the changes made.
[x] I have considered the security implications of the changes made.
[x] I have checked for any potential regressions or side effects caused by the changes.
[x] I have performed a self-review of my code.
[x] Starred the repository.
[ ] Added My Name to the Contributor's List.
[x] Followed the repository's Contributing Guidelines.
[x] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.
Please add Your API for Counting

Hey! in the issue you described that your were going to implement a search functionality..?

Yh but i have changed it's to number of visit count I can add Search functionality in different issue!

You were assigned the issue for search functionality not view counts.


:yandroid:oneui:compileDebugJavaWithJavac warnings

There are 7 warning messages in :yandroid:oneui:compileDebugJavaWithJavac.
If you want to solve this problem, is there a recommended way?
It may be cumbersome, but please review it.

Those are reversed Pre-Samsung Experience multi-window classes used by Samsung to manage multi-window in older OSs (Android 6.0.1 and lower). Doubt those warnings can be fixed since those classes rely a lot on reflection (we can't call directly Samsung frameworks code since it isn't in Google's Android Sdk)

we can't call directly Samsung frameworks code since it isn't in Google's Android Sdk

I understood.
Thank you for your answer.


[FLINK-23648][task] Replace StreamTwoInputProcessor with StreamMultipleInputProcessor

Multiple input version seems to be better optimised so maintaining both doesn't make sense.
Verifying this change
This is basically a refactor, that is covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I'm waiting for a benchmark-request run:
http://codespeed.dak8s.net:8080/job/flink-benchmark-request/370/


MKL build failing at tensorflow/core/kernels/mkl_input_conversion_op.cc

I'm trying to build TF with the MKL option, and it looks like tensorflow/core/kernels/mkl_input_conversion_op.cc is failing to build, with the following error:
(building off of the master branch)

ERROR: /opt/tensorflow/tensorflow/core/kernels/BUILD:6217:1: C++ compilation of rule '//tensorflow/core/kernels:mkl_input_conversion_op' failed (Exit 1)
In file included from ./tensorflow/core/kernels/mkl_tfconv_op.h:39,
                 from tensorflow/core/kernels/mkl_input_conversion_op.cc:32:
./tensorflow/core/util/mkl_util.h: In member function 'void tensorflow::FactoryKeyCreator::Append(tensorflow::StringPiece)':
./tensorflow/core/util/mkl_util.h:2057:19: error: 'class tensorflow::StringPiece' has no member named 'ToString'
     key_.append(s.ToString());
                   ^~~~~~~~
Target //tensorflow/tools/pip_package:build_pip_package failed to build

Note that I have used a sed to replace the MKL-DNN versions to use the latest release. I'm currently building without that manual update; I'll close this issue if that fixes things right away (since it looks like a header issue now)

@sadatnfs There is a PR https://github.com/tensorflow/tensorflow/pull/21956 that fixes this error.

Nagging Assignee @bignamehyp: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


chore: update cilium images to 1.13.13

What type of PR is this?

What this PR does / why we need it:
Add cilium 1.13.13 image to VHD.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[X] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.013%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3032

Relevant Lines:
3937

💛  - Coveralls


glslify does not work as expected with webpack

I'm having issues compiling shaders that use glslify code. I believe this is related to what is happening here. I think my best bet at this point is to convert the code before saving it in the SIHM_* file.

I think the solution here is just to run glslify via the command line before compiling index.js to main.js. All this command does is replace the proper pragmas, so we can run it on our custom SIHM_* files with no issue.

This is very close to working. Just need a way to automate putting the #DEFINE(s) in a different line other than the first.

Got this working as of 2f4ec620cc5421e884eed7791f751652f51fe5e4.


Review Dark theme

There is an inconsistency in the dark theme styling that affects the readability and overall user experience. Specifically, certain text elements and background colors are not aligned with the expected dark theme design principles.

Not part of scope now

To maintain Consistency, Dark Theme Design system is being Implemented. You will find all the resources from here:
Design System:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=0-1&t=Ki81UCBFapRcFuJ2-1
Dark UI Screens:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=2511-4255&t=Ki81UCBFapRcFuJ2-1

#4138

Dark theme UI has been Updated @Deveshshankar . Now it can be picked up by devs
Design System:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=0-1&t=Ki81UCBFapRcFuJ2-1
Dark UI Screens:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=2511-4255&t=Ki81UCBFapRcFuJ2-1

Replaced by #5189


added Artifical Intelligence through Prolog

Thanks for this huge effort, I appreciate it.
Could you please add a commit to make sure each and every new link added has either http://or https://in front of it?

fix moved to #1656


The SAFE_TX_TYPEHASH value is wrong for < 1.0.0 Safe versions

Safe multisig versions < 1.0.0 use a legacy (i.e. the parameter value baseGas was called dataGas previously) SAFE_TX_TYPEHASH value. Starting with version 1.0.0, baseGas was introduced: https://github.com/safe-global/safe-smart-account/pull/90.
https://github.com/safe-global/safe-core-sdk/blob/014f365e46cf278897c5ece45c1490c7c749f2d7/packages/protocol-kit/src/utils/eip-712/index.ts#L39-L52

Fwiw, I shipped support now for Safe versions 0.1.0 in my Bash script: https://github.com/pcaversaccio/safe-tx-hashes-util/pull/9


Vmx lab

add topology file to the vmx lab

Hi @iproute-net
Before you take this PR further I must inform you that containerlab docs already has lab examples for vMX and cEOS

https://containerlab.dev/lab-examples/vr-vmx/
https://containerlab.dev/lab-examples/srl-ceos/

The containerlab docs are meant to provide examples for different kinds, but it is not a collection of labs with different permutations of the NOSes.
Users are free to create the labs in their own repos or at clabs.netdevops.me

I made this one because the device kinds are changed in the newer container lab and the "juniper_vmx" kind is no longer supported.


Make anvil code size limit configurable

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (359dd77 2022-09-15T00:04:51.833948Z)
What command(s) is the bug in?
forge test
Operating System
macOS (Apple Silicon)
Describe the bug
Using SSTORE2 and running the below test code allows for contracts to be created that exceed 24576 bytes (contract size limit)
pragma solidity ^0.8.9;

import "sstore2/SSTORE2.sol";
import "sstore2/utils/Bytecode.sol";

contract TestSSTORE2 {
    function testWrite() public {
        bytes memory data = bytes(vm.readFile("path/to/large/file"));
        console.log("data length", data.length);

        address memory pointer = SSTORE2.write(data);
        console.log("contract size", Bytecode.codeSize(pointer));
    }
}

My initial anvil script wasn't using --broadcast, so I misinterpreted this as anvil having the same behavior as tests. Once I added --broadcast to the anvil node, I got an error as expected: (code: -32003, message: intrinsic gas too high, data: None)
Updated the above title/description to reflect that I can only exceed contract size limits in tests.

Actually, revisited the anvil side again, and was not able to throw 600kb at it, but was able to throw 48kb at it with no issues. So maybe this is just because my gas limit of the anvil node is lower than in tests.

intrinsic gas too high

is thrown if gas exceeds block gas limit
you can manually set --gas-limit for anvil and bump it

sorry for taking so long.
since you're writing an entire file to storage, the tx gas likely exceeds the max block gas limit, but you can bump this manually.
Closing this, lmk if you're still facing issues after increasing anvil's block gas limit

I don’t think this is a gas limit issue. See https://github.com/ethereum/EIPs/issues/1662

what's the error you get when sending a create tx for a large contract?

what's the error you get when sending a create tx for a large contract?

The problem is there isn’t an error when I expected one. I can throw tons of data at it, we’ll over the contract size limit, and get no errors in anvil/tests.
EIP-170 says anything over ~24kb should be an out of gas error. I can try running this against a testnet and confirm if that’s the error I get for >24kb.

we're not enforcing size limits rn, but I think we should make this configurable.
still don't understand if your issue is that there's no error or whether there's something else wrong?

we're not enforcing size limits rn, but I think we should make this configurable.
still don't understand if your issue is that there's no error or whether there's something else wrong?

The issue is that there is no error. Being able to toggle on/off size limits would be great!

Is it possible to allow forge test to configure in the same way? Ultimately I want to write Solidity tests that will fail if the code size is exceeded.

no but we could add if you open a separate issue

we're not enforcing size limits rn, but I think we should make this configurable.
still don't understand if your issue is that there's no error or whether there's something else wrong?

The issue is that there is no error. Being able to toggle on/off size limits would be great!
I deleted the earlier comments and updated the original issue. Let me know if that’s more clear.

I came into a similar situation. While EIP 170 introduced a limit of 24KB on bytecode size of smart contracts in Ethereum, NOT .sol file size. My 56KB .sol file compiles in Remix with optimization runs set to 200 and the compiled contract bytecode size was only 14KB in my case, which was far below the limit. Not sure if this is the same issue you met.

For testing purpose my deployment was failing with ABC is above the EIP-170 contract size limit (30134 > 24576).
with the added option of --code-size-limit 31000 to the forge script script/deploy.s.sol
It still fails with Execution reverted: EvmError: CreateContractSizeLimit (gas:<PHONE_NUMBER>854775857)

While testing my deployment was failing with ABC is above the EIP-170 contract size limit (30134 > 24576).
with the added option of --code-size-limit 31000 to the forge script script/deploy.s.sol
It still fails with Execution reverted: EvmError: CreateContractSizeLimit (gas:<PHONE_NUMBER>854775857)

I have same problem.


Add "Staff Assigned" elements

Add the Catalyst Staff person assigned to vet the application.
For the Application the staff assigned is the Vetting Agent. Note that this can be from a pull down list of registered users with a Vetting Role since the vetting agent will be someone given a login and Vetting Agent role for the AppVetting tool. Add column in Vetting Summary showing assigned staff (similar to what was done in Project Summary).

Upgrading priority. With more staff involved, being able to directly track who is vetting an application is now required.

Migrating to new GitHub


[framework] don't hit test for system nav bar or system chrome on desktop

Redo of https://github.com/flutter/flutter/pull/97771 due to git

This includes a change to completely skip the status bar test on desktop


Added Operating System resource

@anshulnsit Thanks for Contributing to AlgoWiki, have some 🌮 🌯 🍰 from AlgoWIki Team.
Keep Contributing.


React dependency forces react version to be ^15.6.1

If we are using<EMAIL_ADDRESS>yarn installs both 16 and ^15.6.1 versions.
consider moving react dependency to peerDependencies

Thank you so much for the issue! I was updating React to 16 when received issue notification. So I added peerDependencies at the same time. And<EMAIL_ADDRESS>has been just published ;)


Add cc4e

@fffaraz why this is closed? could you tell me some reasons?

It was closed by mistake. Please open a new one.


Help needed

Hello !
If you need any help with that I'll be happy to try to help you in the k8s implementation of test-containers

hey @LaSylv,
thanks for the offer and sorry for the (very) late reply. But as laid out in my other comment (https://github.com/masinger/testcontainers-java/issues/7#issuecomment-1197255760), my priorities shifted as we replaced Testcontainers.
Nevertheless I am happy for every contribution and will accept any such PR. If you need any specific information to get started, feel free to ask.


[Bug] wrong value in environment variable

Describe the bug
using an environment varialble in the URL for an API call: has "NaN" as the value at the time of the call whereas the actual variable has the true value
To Reproduce
Not sure how to reproduce, see screenshots of my setup
Expected behavior
variable as used in the URL should have the actual value
Screenshots

Desktop (please complete the following information):

OS: macOS Mojave 10.14.6
Installation Method: app
App Version v7.0..6.3258

Hi, try replacing the - with _ in the variable name, see if that works

I can confirm @iudelsmann's suggestion works. I had the same issue where my-env-variable was returning NaN switching to my_env_variable fixes the issue.

It's not accepting - instead try to use _ it works.


[SP-6555] Update and validate in-product links in Pentaho <IP_ADDRESS>

 Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

🐸 JFrog Frogbot

:white_check_mark: Build finished in 27m 13s
Build command:
mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl \
assemblies/static,engine,plugins/connections/ui,plugins/core/ui,plugins/elasticsearch-bulk-insert/core,plugins/file-open-save-new/core,plugins/json/core,plugins/meta-inject,plugins/repositories/core,plugins/s3csvinput/core,plugins/salesforce/core,plugins/streaming/impls/jms,plugins/streaming/impls/mqtt,plugins/xml/core,ui

:ok_hand: All tests passed!
Tests run: 3478, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Focus follows mouse in autofocus mode interacting with Sublime Text window

I noticed that when focusing Sublime Text I'm getting this error message in the sublime text console:
Unable to parse command: drag_select {"additive": true, "event": {"button": 1, "x": nan.0, "y": nan.0}}

I turned on debugging logging and found that whenever I click anywhere the drag_select command gets run:
Unable to parse command: drag_select {"additive": true, "event": {"button": 1, "x": nan.0, "y": nan.0}}
>>> sublime.log_commands(True)
command: drag_select {"event": {"button": 1, "x":<PHONE_NUMBER>, "y": 371.296875}}
command: drag_select {"additive": true, "event": {"button": 1, "x":<PHONE_NUMBER>, "y":<PHONE_NUMBER>5}}

When I turned off yabai and brought focus to sublime via things like clicking or alt-tabbing to the window there were no error messages.
I'm not sure about the internals of yabai or sublime but did some digging into the window_manager_activate_window function:
https://github.com/koekeishiya/yabai/blob/80273cb69b0e7b6f6e8167084bff3771c9a36405/src/window_manager.c#L804-L814
I have a hunch that the error message might be related to some of the numbers that are in that table. The error seems innocuous but I would like to know what's causing it and fix it if possible.
Do you know what's the root cause?
I've also mentioned this issue on the sublime discussion board:
https://forum.sublimetext.com/t/unable-to-parse-command-drag-select/50438
This is my setup
$ yabai --version
yabai-v2.4.1
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.4
BuildVersion:	19E287
$ cat ~/.yabairc
#!/usr/bin/env sh
yabai -m config focus_follows_mouse autofocus

From researching this issue further it's clear there is alot of history to focus follows mouse in autofocus (instead of autoraise), these are some relevant links to check out:

https://github.com/Hammerspoon/hammerspoon/issues/370
https://github.com/lwouis/alt-tab-macos/issues/14#issuecomment-550316911

I assume that one of the synthesized events that yabai is generating to emulate the autofocus functionality observed through the WindowServer might actually be some kind of special mouse click event, and not all applications are capable of interpreting this special click event properly, which is why it will only work for some applications.
There is very little information regarding autofocus on macOS out there; I believe yabai is actually the first software to achieve this, at least for any modern version of OSX. The autoraise mode in yabai does not have these same kinds of issues, so maybe autoraise combined with window_topmost on might be more appropriate for you; it is what I personally use anyway.

I assume that one of the synthesized events that yabai is generating to emulate the autofocus functionality observed through the WindowServer might actually be some kind of special mouse click event, and not all applications are capable of interpreting this special click event properly, which is why it will only work for some applications.

This would be my guess as well. Looks like the event is specifically a button1 + super event, with the position being nan, nan. Other than the error message does everything else work? If so I think the best course of action would be to ignore events with a nan position on the Sublime Text side.

Other than the error message does everything else work?

@BenjaminSchaaf thank you for the response!

Other than the error message does everything else work?

Yes everything works as expected; however, the console log is filed with error messages and I'd like to fix the problem.

I think the best course of action would be to ignore events with a nan position on the Sublime Text side.

Is this the kind that is implemented with a sublime plugin? Is there a configuration change I can make or is there a patch I can submit to the drag_select sublime command?

The drag_select command is not implemented in a plugin. It will need to be fixed in core. Sublime Text is not open source, so there's no way for you to fix it. I'll be adding an issue to the ST issue tracker for this.

Right on @BenjaminSchaaf thank you creating an issue! There is a slight spelling mistake in the title: s/yabi/yabai/ to aid in searching!

Not sure. I'd consider sending an input event with nan position a bug, but maybe that's the only way to safely do focus-follows-mouse on macOS.

As far as I know there is actually no information out there on how to do autofocus on macOS except for what I did in yabai to achieve this, and so I don't think I will consider this a bug in yabai. At the very least I won't be looking more into it, because it is actually a pain and huge time sink. I will be closing this issue as I won't make changes here.
If applications are having problems due to the usage of autofocus, switch to autoraise and enable topmost floating windows instead.

Did a small change on master. Does that help?

I upgraded yabai to version yabai-v3.2.1 and the error has disappeared from my sublime text console log! This issue is resolved, thank you very much and sorry this took me so long to get back to you!
$ brew upgrade yabai
$ brew services restart yabai
$ sudo yabai --uninstall-sa
$ sudo yabai --install-sa
$ killall Dock
$ yabai --version
yabai-v3.2.1
# adjust permissions
$ brew services restart yabai
# launch sublime-text console using cmd - `
# focus window, no errors!

This is my config file
$ cat ~/.yabairc
#!/usr/bin/env sh
yabai -m config focus_follows_mouse autofocus


feat(turbo): add promiseToResponse method

Coverage increased (+1.9%) to 77.816% when pulling 0dc16da23b3f9cd40b381ce90e4ddf75509d2c9f on promisetoresponse into 3cd8d524be9e7287a109f654ddb71e7d73e3fb12 on dev.


A new daemon is always started with OpenJDK 8

Hi,
Is there a known issue with Java versions lower than 11 ?
With Open JDK 8 I always obtain the following message :
$mvnd --version
Starting new daemon, X incompatible and Y stopped daemons could not be reused, ...

This furtive message doesn't appear with open JDK 11.
Reproduced on Windows 10 (mvnd-0.1.1-windows-amd64) & Linux Centos 7 or Ubuntu 20.04 (mvnd-0.1.1-linux-amd64).
First lines of log in Centos 7 :
11:51:38.662 D Initializing daemon with properties:
     mvnd.noDaemon=false
     mvnd.debug=false
     mvnd.idleTimeout=3h
     mvnd.keepAlive=100ms
     mvnd.extClasspath=
     mvnd.coreExtensions=
     mvnd.minHeapSize=128M
     mvnd.maxHeapSize=2G
     mvnd.jvmArgs=
     mvnd.enableAssertions=false
     mvnd.expirationCheckDelay=10s
     mvnd.duplicateDaemonGracePeriod=10s

11:51:38.667 I Daemon started
11:51:38.669 D daemon is running. Sleeping until state changes.
11:51:38.694 I Client connected
11:51:38.698 I Waiting for request
11:51:38.702 I Request received: [...]

in Windows 10 :
09:45:34.813 W Unable to ignore INT and TSTP signals
java.lang.IllegalArgumentException: Unknown signal: TSTP
	at java.base/jdk.internal.misc.Signal.<init>(Signal.java:148)
	at jdk.unsupported/sun.misc.Signal.<init>(Signal.java:139)
	at org.mvndaemon.mvnd.daemon.Server.<init>(Server.java:105)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at org.mvndaemon.mvnd.common.MavenDaemon.main(MavenDaemon.java:75)
09:45:35.906 D Initializing daemon with properties:
     mvnd.noDaemon=false
     mvnd.debug=false
     mvnd.idleTimeout=3h
     mvnd.keepAlive=100ms
     mvnd.extClasspath=
     mvnd.coreExtensions=
     mvnd.minHeapSize=128M
     mvnd.maxHeapSize=2G
     mvnd.jvmArgs=
     mvnd.enableAssertions=false
     mvnd.expirationCheckDelay=10s
     mvnd.duplicateDaemonGracePeriod=10s

09:45:35.914 I Daemon started
09:45:35.915 D daemon is running. Sleeping until state changes.
09:45:36.018 I Client connected
09:45:36.741 I Waiting for request
09:45:36.746 I Request received: [...]

Shame on me, duplicate from #261

The fact that TSTP or INT signals can't be registered should not causeany problem. I'll enhance the warning to explain.
So it should be unrelated to the daemon not being reused, unless you actually hit Ctrl+C or Ctrl+Z in the client, which would cause the daemon to die.

Thanks for the report anyway, @LeBezout. Your report brought the most of details that helped me to find out that we have solved this exact problem in the past already but the fix disappeared through some refactoring.


--excludeExternals but keep custom defined interfaces

Search terms
excludeExternals
Question
hello, i have a library that inject into javascript language my custom methods:
example:
declare interface ArrayConstructor {
	isNotArray(arg: any): boolean
}

declare interface Array <T> {
	remove(t: T): void
}

// implementation

Array.isNotArray = function(arg: any) {
  return !Array.isArray(arg)
}

Array.prototype.remove = function <T>(this: Array<T>, element: T) {
	for (let i = 0; i < this.length; i++) {
		if (this[i] === element) {
			this.splice(i, 1)
			i--
		}
	}
}

now i want to generate documentation using typedoc,
and i want to suppress library methods (any provided by typescript/lib/lib.*.d.s) so i use  --excludeExternals
but in this way my methods are excluded as well.
there is a way to exclude standard methods and only generate mine?
Thanks!

Currently, no. Whether or not a symbol is considered external is determined by whether or not any of its declarations are external. I can't recall right now why some rather than every behavior is important, but I know it is, since I saw false positives when implementing the warnings for missing exports in 0.22 recently when trying to use every.
https://github.com/TypeStrong/typedoc/blob/d943dc6b0f66974d41f55d0206664aaf09960e1f/src/lib/converter/converter.ts#L412-L426
If you are dead set on adding this to globals, I would still likely implement them as standard exported functions, then mention in the documentation comment that it is available on the appropriate global.

Yeah, i mean, i am currently implementing a lib that enhance JavaScript base types: https://github.com/GiovanniCardamone/polyfull and I'd like to use TypeDoc to document this one (but not the language itself)
Furthermore, I'd like to to use TypeDoc but for now I haven't found a way to documentare my declaration and ignore the one of the language
Thanks a lot!

I have the exact same issue. I'm not using TypeScript, just documenting a JS API. Upfrtunately a couple of my class names clash with typescript internal classes. If I includ externals, I get extra stuff added to my classes. If I exclude externals, my own classes disappear. Neither option is desired.

TypeDoc gets what is visible from TypeScript, so your globals clashing with names isn't just a problem here, but will also be a problem when writing code. You should probably set "noLib": true, or adjust the lib option to not include those.
I'll admit that both of these use cases are pretty low priority for me - libraries which muck with globals are doing bad things, and it's much more important to produce good documentation for the vast majority of libraries which do not do this. As for JavaScriptCore, well... if it doesn't have modules, TypeDoc here is matching what TypeDoc is doing.
I would accept a PR which fixes this, but probably won't get to it any time soon.

You should probably set "noLib": true, or adjust the lib option to not include those.

Aha! That pointed me directly to the solution. My big problem was a couple of my interface names clashing with some DOM object names (my environment has no DOM). By setting "lib": [ "ES6" ] I was able to exclude the DOM libraries from the project and, hey presto, no more clashes. Thanks!


Allow to disable elastic IPs if they are unused

Is your request related to a problem? Please describe.
The module creates an Elastic IP as part of the VPC. I don't clearly understand the reasons, seems to be associated with conserving it across creations / destructions.
AWS charges a value when Elastic IPs are created and not associated with any service.
My basic understanding of this, suggests that in some circumstances (like mine, in which I'm not directly exposing services, only using API gateway), that charge doesn't make sense.
Describe the solution you'd like.
Allow to disable elastic IPs

Elastic IPs are only used on the NAT gateways

I still need NAT for outbound access to internet. But Elastic IPs, if I'm not misunderstanding this, are used for maintaining public IP addresses for inbound accessing our network

No, they are required when used to NAT to the public internet https://docs.aws.amazon.com/vpc/latest/userguide/vpc-nat-gateway.html

Public – (Default) Instances in private subnets can connect to the internet through a public NAT gateway, but cannot receive unsolicited inbound connections from the internet. You create a public NAT gateway in a public subnet and must associate an elastic IP address with the NAT gateway at creation. You route traffic from the NAT gateway to the internet gateway for the VPC. Alternatively, you can use a public NAT gateway to connect to other VPCs or your on-premises network. In this case, you route traffic from the NAT gateway through a transit gateway or a virtual private gateway.


I have an issue with the 'userinfo

Hi, I have an issue with the 'userinfo then tagging me will show my status as offline, no matter what it actually is set as.

That's just a limit of Discord. The selfbot has no way of knowing your true status. It should show the proper value if you change your status via //status.

Aight, thanks


compile issue for esp32

header file USBHost_t36.h is only available for teensy board.
please help me to solve the issue.

esp32 can't act as host...use boards which have inbuilt host function or max3421 shield


feat: replace flattenArray with build-in Array.flat function

replacing the helper flattenArray with build-in Array.flat function

@tkgroot Array.flat is not supported in IE11 or am i wrong?
This lib is supported by IE11 so, maybe an check is required here

No, i don't think you are wrong.
Maybe a good idea to drop IE11 support or let it be handled by polyfills?
Also if you look ahead IE11 doesn't support ESM, so it's just a big hurdle to keep the support for it


[client] particle engine

Create particle engine for purpose of easy adding smoke/fire and any other effects

Does internal threejs not suffice?


Enable preview capabilities in existing project

Is it possible to enable preview features in existing project?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: acc2714f-5868-1d4f-b2d8-47eabc3247d7
Version Independent ID: 45ef4bed-492f-136f-a842-7aeeb75c7ce2
Content: Try SharePoint Framework preview capabilities
Content Source: docs/spfx/try-preview-capabilities.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Yes.  Just update your package.json to point to the preview packages (they look like 1.7.0-plusbeta or 1.5.1-plusbeta) and then run npm install .

Thanks!


XamlMarkupHelper.UnloadObject should reference x:Load

This API exists to unload an object that was loaded by x:Load, it should have a reference to that page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0ca78730-03a5-4fbc-89db-424155c526f6
Version Independent ID: 0ca78730-03a5-4fbc-89db-424155c526f6
Content: XamlMarkupHelper.UnloadObject(DependencyObject) Method (Microsoft.UI.Xaml.Markup) - Windows App SDK
Content Source: winapps-winrt-build/xml/Microsoft.UI.Xaml.Markup/XamlMarkupHelper.xml
Product: reunion
Technology: reunion-reference
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Thanks @MikeHillberg. A PR has been submitted to add this information with a link to x:Load.


Fix sign in banner still showing for a moment after login

Details

There is a sign in banner at the report screen footer when logged in as anon user. After login to a real account, the sign in banner doesn't immediately disappear.
Fixed Issues

$ https://github.com/Expensify/App/issues/36976
PROPOSAL: https://github.com/Expensify/App/issues/36976#issuecomment-1961566955
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Log out
Open a public room as anonymous user
Press the sign in banner button
Log in with your account. Wait until the login is successfull
Verify the sign in modal is closed
Verify the sign in banner (report footer) disappears

Android mWeb
I can't open a public room

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/f0cd3335-a97b-4c77-9a12-859d43140eaa

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/50919443/2ee2a56b-64ad-4e80-bdad-f1a3ea233461

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/6287bc7a-96a7-4326-98ab-a9592edd26a9

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/277904b2-db2a-4fa7-8352-fba9b2abb9b0

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/ec0c158d-8a38-4e81-915d-dc055ce5f554

I can't seem to open a public room on Android mWeb.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


sync_s3 broken with py3

  File "/home/kondou/git/project/lib/python3.4/site-packages/django_extensions/management/commands/sync_s3.py", line 261, in sync_s3
    os.path.walk(directory, self.upload_s3, (bucket, key, self.AWS_BUCKET_NAME, directory))
AttributeError: 'module' object has no attribute 'walk'

https://github.com/django-extensions/django-extensions/blob/master/django_extensions/management/commands/sync_s3.py#L261
https://docs.python.org/2/library/os.path.html#os.path.walk

This function is deprecated and has been removed in Python 3 in favor of os.walk().

In #45 there was a version that used os.walk() but it got rejected.

#45 was not so much rejected as it was old and there was no activity on that ticket.
Happy to accept PR's to fix this.


Wrong Method behaviour that causes crash on world generationn

Minecraft Version: 1.12.2
Mod Version: 2.1.8
https://github.com/LogicTechCorp/NetherEx/blob/1.12.x/src/main/java/logictechcorp/netherex/world/generation/ChunkGeneratorNetherEx.java#L471
This is the stacktrace that I get when I try to call the vanilla method "findNearestStructure()" to locate Vanilla nether fortresses

This also breaks the locate command that prints an error to the chat

I am unable to replicate this crash. Are there any other mods installed besides Metallurgy?

of course it doesn't crash we didn't push broken code to curseforge :/
and we do a specific check when generating the ore that also calls the method findNearestStructure to avoid calling it when NetherEX is present otherwise it crashes, I can provide you a build that doesn't have that patch though if you need it please tell me
The check we do in our code
https://github.com/Davoleo/Metallurgy-4-Reforged/blob/03b1252c771a539f33d924ed8dc33cc324710698/src/main/java/it/hurts/metallurgy_reforged/world/spawn/NearFortressSpawn.java#L38-L43

I think you can generate the exception (which doesn't make the game crash but spits out an error) if you use the locate command to locate a nether fortress with only netherEX installed

I was able to find the cause of the crash after some additional testing. NetherEx only generates Nether Fortresses in the default Nether biome, but it turns out that it causes issues when calling certain methods in other biomes. I am going to make it so Nether Fortresses can spawn in any biome which will fix the crash along with some other issues. I am working on other bug fixes and I hope to have the update out sometime next week. I'll close this issue once it is released.

This issue has been fixed in the latest version.


Sarif panel changes unexpectedly when multiple results on a single source line

When I click on a result in the sarif panel, it takes me to the relevant source file and line number. If there are multiple results in the same source file and line number, the sarif panel will sometimes jump to another result. It makes it difficult/impossible to view the details of the result I'm interested in viewing.

@eddynaka  @jeffersonking
Can we get some attention on this one?

@MichaelSquires Do you have a repro handy for this? If not I will need to reconstruct the scenario. Thanks.

@MichaelSquires Do you have a repro handy for this? If not I will need to reconstruct the scenario. Thanks.

Not at the moment. I'll put one together and get it uploaded here.

@jeffersonking: I was able to get a repro for this issue.

Download the two files in this gist.
Save them to d:\temp (if you save them somewhere else, be sure to update foo.sarif:261).
Open VS Code in the new directory: code d:\temp.
Click on Rules in the SARIF panel.
Expand C26481.
Click on one of the results.
Notice it jump to C26440 and then C26493.
Click on any other result in that window and it will always jump to C26440 then C26493.

At one point, the issue stopped presenting but returned after closing and reopening VS Code. Please let me know if you have any issues getting this behavior to repro.

@MichaelSquires Thanks for your patience. #408 is likely to have addressed this issue. Optimistically closing. If not, we'd be happy to take closer look.


show databases return pool size?

Hi, this is an excellent exporter.  We are looking at alerting if pool usage is getting close to limits of pool size but it doesnt appear this script returns the pool size metric.  I may submit a PR if I get the time to work on it, unless this was a feature you already considering adding.  Thanks!

I didn't plan to add it, but it makes sense. If you're willing to submit a
PR I will be glad to review and merge it.
On Mon, Mar 19, 2018, 19:45 fonziesherman<EMAIL_ADDRESS>wrote:

Hi, this is an excellent exporter. We are looking at alerting if pool
usage is getting close to limits of pool size but it doesnt appear this
script returns the pool size metric. I may submit a PR if I get the time to
work on it, unless this was a feature you already considering adding.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spreaker/prometheus-pgbouncer-exporter/issues/2, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABn4EI14tZjDobFQIMsYSZ4zC1rMIBCEks5tf_y8gaJpZM4Sws2n
.

Thanks, I will try to get something together asap.

The metric pgbouncer_databases_database_pool_size is now supported (introduced some time ago by PR #3). I'm going to close this issue.


ATracker resource names should use the prefix for consistency

When the ATracker resources (targets, routes) are provisioned their names should use the prefix (if provided) for consistency with other resources.
https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/blob/25e36fb97f299c15baf9fe25612ae9e160ffe3f9/solutions/instances/main.tf#L73
https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/blob/25e36fb97f299c15baf9fe25612ae9e160ffe3f9/solutions/instances/main.tf#L141
https://github.com/terraform-ibm-modules/terraform-ibm-observability-da/blob/25e36fb97f299c15baf9fe25612ae9e160ffe3f9/solutions/instances/main.tf#L152

:tada: This issue has been resolved in version 1.12.0 :tada:
The release is available on:

GitHub release
v1.12.0

Your semantic-release bot :package::rocket:


Basic example code usage in readme

Hi I am struggling to get this package working. Seems to me that I have connection to mongo db setup properly, because I could list my collections names from calling db._getCollectionNames
but I am not able to figure out how to get collection, so I can perform update on collection:
exports.up = function (db) {
    // how to use db to get to collection?
    // this won't work
    db.collection('Profile').update({},
        { $set: { "termsOfServiceUpdated": true } },
        {
            upsert: false,
            multi: true
        });
};

thank you very much

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

This is a migration library, not just a wrapper for the driver below. So you first need to access the driver should you want to perform operations not, yet, directly supported by the driver or the framework.
In case of mongodb this is getDbInstance merged from this  PR over here https://github.com/db-migrate/mongodb/pull/21

Hi, sorry new to this but trying to use getDbInstance, would this be a case of just doing
exports.up = function(db, callback) {
    db.getDbInstance().getCollection(....)....
}

Thanks in advance.
Kind regards
Sidharth

Hi, sorry new to this but trying to use getDbInstance, would this be a case of just doing
exports.up = function(db, callback) {
    db.getDbInstance().getCollection(....)....
}

Thanks in advance.
Kind regards
Sidharth

@sidharthnayyar were you able to get db.getDbInstance() working? When I try to run it I get [ERROR] TypeError: db.getDbInstance is not a function. I confirmed I have<EMAIL_ADDRESS>too.

Thanks for sharing your trick to getting an instance of Mongo client, @danielabar. It seems like it would open 2 connections to the db though? Thanks also for the debugging tip, that is super useful!
Actually after I posted I found this on the web, so here's what I have for now:
const collections = [ {
    name: 'users'
} ];

exports.down = async (db) => {

    const dbDriver = await db._run('getDbInstance');
    collections.forEach(async (collection) => {
        const fileName = collection.dataFile || `${collection.name}.json`;
        const data = require(Path.join(__dirname, 'docs', fileName));

        await Promise.all(data.map((doc) => {
            return dbDriver.collection(collection.name).deleteOne({ _id: doc._id });
        }));
    });

    dbDriver.close();
};

I wonder if there's a better way than both of ours though -- it seems risky resorting to using undocumented methods that may change internally.

I see what you mean about connecting twice. Also good point about undocumented methods.
To project maintainers: Any thoughts on this - what's the recommended way to get access to mongo instance, given that getDBInstance method from PR #21 isn't working?

This will help people who are still looking for it:
exports.up = function(db) {
  return db._run("update", "collectionToUpdate", {
    query: { id: "1123" }, // What you need to find
    update: { title: "myNewTitle", desc: "It works" }, // What you need to change
    options: {}, // Options like e.g: upsert: false,
  });
};

Have a look here
There is also updateMany

please be aware _ methods are private and subject to change at any time without warning. they may completely change their behavior or suddenly disappear. you can use them, but be prepared that you might have to change your migrations or fixate a driver version.

Is there any other way?

Hello, I've been using db-migrate with mysql and it's working fine.
Now I wanted to use db-migrate with mongodb and am having trouble implementing a migration.
The only documentation I found is here:
https://db-migrate.readthedocs.io/en/latest/API/NoSQL/
It would imply there is no officially supported way of updating or deleting records - or am I missing something?
Thanks for any answer - I'll try using @jugaltheshah suggested method for now.

Not the official way but you can use for a single entry to remove:
exports.down = function(db, callback) {
  db._run("remove", "pages", { _id: new ObjectID("5bb9e79df82c0151fc0cdab2") }, callback);
};

But the code has a bug with deleteMany at the moment so you can use @jugaltheshah method.
More details here: https://github.com/db-migrate/mongodb/blob/master/index.js#L337

thanks - I'm doing that and its working fine 👍


Update dev prefix

:pencil: Description
:link: Related Issues

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Kudu Auth: Revert WIF in affected tasks

Task names:

AzureWebAppV1
AzureWebAppContainerV1
AzureFunctionAppContainerV1

Description: Revert of following PRs with WIF support due to failures in production:

#18188
#18077
#18080

Documentation changes required: N
Added unit tests: Failing scenarios should be covered CI pipeline in separate work item.
Attached related issue:

https://portal.microsofticm.com/imp/v3/incidents/details/385067525/home
https://github.com/microsoft/azure-pipelines-tasks/issues/18194

Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

@ozanovus fixed


iconv dependency

great script, i had to add ruby-iconv package (arch linux) to get it to work.

Thanks for the feedback. This is probably a dependency of pdfbeads, which is written in ruby, and has a runtime dependency on iconv (and, depending on how you installed pdfbeads, this should usually have been installed for you).


docs: Fix "LSP server"

Thanks!

This could link to https://microsoft.github.io/language-server-protocol/
This could use the HTML abbr element.
an <abbr title="Language Server Protocol">LSP</abbr> server could greatly

Feel free to adjust! (I'm not sure whether Hugo allows for inline HTML, we'd have to try it, I think it probably does)


Update Versions

Codecov Report

Merging #666 (650e779) into main (d637ca0) will not change coverage.
Report is 1 commits behind head on main.
 Consider uploading reports for the commit 7269f52 to get more accurate results

@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   42.32%   42.32%
=======================================
  Files           7        7
  Lines         482      482
=======================================
  Hits          204      204
  Misses        262      262
  Partials       16       16


Enhancement of  UI of footer

Describe the feature
I recently visited the Swap Reads website and noticed an opportunity for improvement in the footer UI. The current design doesn't fully align with the site's overall aesthetic and could benefit from a more cohesive and visually appealing layout. By enhancing the footer UI, I aim to provide a more polished and user-friendly experience for visitors. Proposed improvements include aligning the footer design with the site's branding, simplifying and organizing navigation links, incorporating attractive social media icons, and ensuring the footer is responsive across all devices. Additional features like a newsletter signup form and quick contact information could add further value. These changes will make the Swap Reads website more engaging and user-friendly, reinforcing its commitment to quality and accessibility. I am eager to contribute to Swap Reads and help improve the overall user experience through these footer enhancements.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

please assign me this issue if it is not assigned already <3.


Potential enhancements?

Hi! My team is using a Channel module paradigm that lends itself nicely to ChannelHandler's capabilities, so I was excited to come across this project. In addition to dispatching handle_eventss, we also dispatch joins and handle_infos, which ends up looking something like this:
def join("lobby" = topic, payload, socket) do
  Lobby.join(topic, payload, socket)
end

def join("room:" <> _id  = topic, payload, socket) do
  Dashboard.join(topic, payload, socket)
end

def handle_info({:joined, _user} = msg, socket), do: Notifications.handle_info(msg, socket)
def handle_info({:left, _user} = msg, socket), do: Notifications.handle_info(msg, socket)

What do y'all think about adding macros to ChannelHandler for join and handle_info such that something like the following would be possible?
join "lobby", Lobby
join "room:" <> _id, Room

info {:joined, _user}, Notifications
info {:joined, _user}, Notifications

This would really help us streamline our Channel modules into pure "routers" and I imagine could be useful for other ChannelHandler users. I'm happy to do the work on this feature but would like to gauge the likelihood of something like it getting merged.
While evaluating our options, I prototyped a simple set of macros that do what we need and may be of further use in demonstrating the use case: Dispatcher. Check LobbyChannel and RoomChannel for example usage.
My implementation doesn't include things like scopes and plugs, which I think are awesome features. Furthermore, I'd rather contribute to an existing community effort than create another library.
Happy to chat more, and looking forward to hearing your thoughts.

Forgot to mention: As the join fn _topic, _payload, socket -> ... syntax is already supported, I'd just be looking to add the join _topic, ModuleName form.

Hi @ngscheurich!
These changes would be welcome, feel free to submit a PR(I'd be happy to provide context if you're not familiar with Spark, the library this is built with), or I can do that when I get some time
Specifically, I think we need the following additions:

Support info pattern, handler_module, function_name \\ :handle_info
Support  info function like we have handler for events. The reason for this is that the functions generated by this library are injected on a before_compile callback, so I'd rather have all the functions defined in a predictable order, so the clauses evaluate in the same order the user defined them
Support join topic, handler_module, function_name \\ :join

I was also playing with the idea of having something like LiveView's on_mount and hooks to fully consolidate all info logic in the handler modules, but that's a topic of its own :D

Sounds great, @doorgan. Thanks for the pointers. I'll submit a PR and we can go from there!

@doorgan I've done a bit of work on this but am unsure how to proceed. I'm stuck on getting Spark to allow pattern matching on a Spark.Dsl.Entity arg. For instance, I've created an info entity like so:
@info %Spark.Dsl.Entity{
  name: :info,
  target: Info,
  args: [:message, :module, {:optional, :function, :handle_info}],
  schema: [
    message: [type: :any, required: true],
    module: [type: :atom, required: true],
    function: [type: :atom, required: true]
  ],
  modules: [:module]
}

I can use it in a router like this:
info {:info, :delegate}, ChannelHandler.RouterTest.TestHandler

The problem crops up, however, if I use try to pattern-match the message arg:
info {:info, _}, ChannelHandler.RouterTest.TestHandler

I'm reading over the Spark source but thought you might have some insight in the meantime.

@ngscheurich Ah! You need to set the message type to :quoted
Spark uses NimbleOptions under the hood, but has special handling for some types, you can see the list of supported types in https://hexdocs.pm/spark/Spark.OptionsHelpers.html

Ah, great! Thanks for the pointer, @doorgan.


Ag failing in search a path

With grep:
➜ grep -rin "board_approved_date" /.py
scripts/bulk_corporations.py:573:                            board_approved_date=plan_date,
scripts/bulk_corporations.py:648:                board_approved_date=date,
scripts/bulk_corporations.py:674:                board_approved_date=self.date_of_incorporation
scripts/bulk_corporations.py:690:                board_approved_date=self.date_of_incorporation
scripts/bulk_corporations.py:1277:            board_approved_date=profile.date_of_incorporation,
With ag:
➜ ag board_approved_date
➜
Returns nothing, maybe something special with the scripts folder?

When I rename the folder to scripts2:
➜ mv scripts scripts_2
➜ ag board_approved_date
scripts_2/bulk_corporations.py
573:                            board_approved_date=plan_date,
648:                board_approved_date=date,
674:                board_approved_date=self.date_of_incorporation
690:                board_approved_date=self.date_of_incorporation
1277:            board_approved_date=profile.date_of_incorporation,

Do you have a .gitignore that ignores scripts? It's actually a feature of ag to also ignore those files.

That's it! Thanks!
2017-03-13 9:18 GMT-07:00 Erlend Hofstad Langseth<EMAIL_ADDRESS>:

Do you have a .gitignore that ignores scripts? It's actually a feature of
ag to also ignore those files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ggreer/the_silver_searcher/issues/1065#issuecomment-286158345,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXug-pMU0qtAbdzVXsP7aa0nsc753q4ks5rlWw9gaJpZM4MV9dz
.

--
[]`s
Ricardo L. Dani
http://about.me/ricardodani


JUST RECEIVED YOUR EMAIL ABOUT .NET 4.8 UPGRADE DUE BY JULY 14 2020. WE HAVE OTHER THINGS TO DO THAN TO REACT TO A MANDATE IN BASICALLY THREE WEEKS.   THIS KIND OF CRAP MAKES ME WANT TO TAKE OUR ENTIRE ENVIRONMENT ELSE WHERE. THANKS FOR THE 3 WEEKS HEADS UP.
DOUG SROFE
CIO
EAGLE PHARMACY

I assume you are referring to Azure App Servicing moving to .NET Framework 4.8, on July 14th. The following mail was sent out to Azure App Service users (screenshot below) to explain what is happening. The .NET Framework 4.8 Availability on App Service announcement also describe those plans and changes.

As you may know, we only support one version of .NET Framework as part of a Windows installation. I am assuming that App Service team is upgrading all of their servers to .NET Framework 4.8. This is necessary, in order to allow other users to use .NET Framework 4.8 APIs and features.
Existing .NET Framework applications should run correctly on top of this new version without changes. .NET Framework 4.8 was released over a year ago. It is now the most heavily used version of .NET Framework, and we haven't heard much about migration challenges. We expect that your experience will be similarly straightforward.
In terms of what you can do, we recommend you test your application with .NET Framework 4.8 on you local machines. Assuming that works without issue, then one can reasonably expect that you will not notice the update on July 14th. This is the same guidance as you see in the email above.
Does that explanation help? Thanks.

@richlander
https://stackoverflow.com/questions/24144331/what-versions-of-net-are-supported-on-azure-web-sites
According to this article (and by checking it manually), you can see multiple versions of .NET Framework are installed on the VM. What do you mean with "we only support one version of .NET Framework"?
Does it affect a WebJob that is being published using .NET Framework 4.6.2, will it automatically use the installed 4.6.2 or is it currently already using 4.7 (as that is the only framework being visible in the configuration of the Web App)?
Will such a WebJob be forced to use 4.8 after this update?
How about a CMS (like DotNetNuke) that is being installed on a Web App using FTP?
I assume it was built using a specific .NET Framework at some point, will it always use that .NET version?

According to these articles (and by checking it manually), you can see multiple versions of .NET Framework are installed on the VM. What do you mean with "we only support one version of .NET Framework"?

This is how you determine the current framework installed in Windows. In the stack overflow answers that you link, they show the reference assemblies folder, which is used when compiling code targeting those versions listed. That is, those version folders you see there are part of the SDK not the runtime specifically.

How we interpreted the notification we received is that we had to upgrade all of our .net framework applications to 4.8 by the specified date.  If you are telling me that 4.8 is going to be installed but the other versions remain and that we don’t have to upgrade, then that is a different story.  The notification came across as a mandate to convert in 3 weeks.
This is the notification we received.
Test your Azure App Service apps using .NET Framework 4.8 by July 14, 2020
You're receiving this email because you're running a Windows application on App Service.
To improve Azure App Service, we're updating the platform to use .NET Framework 4.8https://github.com/microsoft/dotnet/blob/master/releases/net48/README.md. The update will begin on July 14, 2020, and your apps will be automatically updated by September 15, 2020.
When the update begins, we'll share our progress on GitHubhttps://aka.ms/dotnetframeworkupdates.
Recommended action
To ensure that your App Service apps will run smoothly with the updated platform, test them locallyhttps://github.com/jeffwmartinez/appservicedotnetframework.github.io#net-framework-48-is-coming-to-app-service using .NET Framework 4.8 by July 14, 2020.
If you have questions, please contact ushttps://portal.azure.com/#blade/Microsoft_Azure_Support/HelpAndSupportBlade/overview.
Thanks,
Douglas Srofe
Chief Information Officer
<EMAIL_ADDRESS>350 Eagles Landing Drive
Lakeland, FL 33810
t: +1<PHONE_NUMBER>
m: +1<PHONE_NUMBER>
e: dsrofe<EMAIL_ADDRESS>www.eaglesfp.comhttp://www.eaglesfp.com/
<EMAIL_ADDRESS>https://www.facebook.com/Eagle-SFP-1133509183492377/?modal=admin_todo_tour<EMAIL_ADDRESS>https://www.linkedin.com/company/eaglesfp/<EMAIL_ADDRESS>https://twitter.com/Eagle_sfp
From: benhall_io<EMAIL_ADDRESS>Sent: Friday, June 26, 2020 7:03 AM
To: microsoft/dotnet<EMAIL_ADDRESS>Cc: Srofe, Doug<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/dotnet] ARE YOU KIDDING ME???? (#1223)
According to these articles (and by checking it manually), you can see multiple versions of .NET Framework are installed on the VM. What do you mean with "we only support one version of .NET Framework"?
This is how you determine the current framework installed in Windowshttps://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed. In the stack overflow answers that you link, they show the reference assemblieshttps://docs.microsoft.com/en-us/dotnet/standard/assembly/reference-assemblies folder, which is used when compiling code targeting those versions listed. That is, those version folders you see there are part of the SDK not the runtime specifically.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/dotnet/issues/1223#issuecomment-650120899, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK3V72I2NKQ5YNWZ67VSVQ3RYR57LANCNFSM4OIHYFLQ.
Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.

Hi folks,
I have a couple of simple legacy sites currently set to .NET framework v3.5 on the app service general stack settings. What does this update mean for these sites? Will this setting still be available after these updates?

Hi folks,
I have a couple of simple legacy sites currently set to .NET framework v3.5 on the app service general stack settings. What does this update mean for these sites? Will this setting still be available after these updates?

.NET 3.5 and .NET 4.8 co-exist, with new versions of .NET 4.x being in-place updates to previous updates for .NET 4.x, while .NET 3.5 is a completely independent, side by side stack. So if your application is running on .NET 3.5 today there should be no impact to the .NET 3.5 stack on account of the rollout of .NET 4.8.

Great, thanks @jamshedd !

It's important to note that you can't just update to 4.8 from 3.5. There's at least one major breaking change when you upgrade to .NET 4.5+, and that is the change to how closures operate. (lamda expressions) https://stackoverflow.com/questions/8649337/is-access-to-modified-closure-resolved-by-comprehension-syntax

I assume you are referring to Azure App Servicing moving to .NET Framework 4.8, on July 14th. The following mail was sent out to Azure App Service users (screenshot below) to explain what is happening. The .NET Framework 4.8 Availability on App Service announcement also describe those plans and changes.

As you may know, we only support one version of .NET Framework as part of a Windows installation. I am assuming that App Service team is upgrading all of their servers to .NET Framework 4.8. This is necessary, in order to allow other users to use .NET Framework 4.8 APIs and features.
Existing .NET Framework applications should run correctly on top of this new version without changes. .NET Framework 4.8 was released over a year ago. It is now the most heavily used version of .NET Framework, and we haven't heard much about migration challenges. We expect that your experience will be similarly straightforward.
In terms of what you can do, we recommend you test your application with .NET Framework 4.8 on you local machines. Assuming that works without issue, then one can reasonably expect that you will not notice the update on July 14th. This is the same guidance as you see in the email above.
Does that explanation help? Thanks.

So How do we know if our local machine has 4.8 installed already?
I installed one on my laptop and I don't have any way to verify if its now using the said .NET framework
So many breaking changes in the libraries that I even don't have alternatives
This truly makes me sick!!!

This is our published guidance around how to detect the version of .NET Framework installed.
To add to what richlander already said, the Azure App Service announcement is about the runtime version of the .NET Framework 4.8 deployed to the service. After this rollout, apps compiled against i.e. targeting 4.x version will be using the 4.8 runtime. The announcement is not an ask to rebuild apps to target 4.8 since any previous 4.x targeting app automatically rolls forward to a later 4.x runtime, rather it is an ask that you may want to test your existing apps on the 4.8 runtime in case you have not already done so.
.NET Framework 4.8 has shipped broadly to hundreds of millions of computers including deployed via Windows Update and is a highly compatible update to previous 4.x runtimes, so the vast majority of 4.x apps will run on top of 4.8 (if they're not already running) with no issues and no changes needed. That said, if you have a critical production app it is always prudent to mitigate the possibility of a regression (however small the possibility might be) by testing on the new runtime version ahead of the rollout. That is what the Azure App Service announcement was meant to communicate. I agree this could have been communicated more clearly than we did.


Failing to create a Velero instance

Redhat OCP 4.6 and using OADP operator v 0.2.0. Installation of operator is successfull, but trying to create a Velero instance using AWS cloud provider fails with:
The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'cloud'
The error appears to be in '/opt/ansible/roles/velero/tasks/main.yml': line 60, column 5, but may
be elsewhere in the file
The YAML shows the following:
status:
conditions:
- ansibleResult:
changed: 0
completion: '2021-02-26T15:38:59.792135'
failures: 1
ok: 8
skipped: 42
lastTransitionTime: '2021-02-26T15:39:00Z'
message: >
The task includes an option with an undefined variable. The error was:
'dict object' has no attribute 'cloud'
    The error appears to be in '/opt/ansible/roles/velero/tasks/main.yml':
    line 60, column 5, but may

    be elsewhere in the file depending on the exact syntax problem.

    The offending line appears to be:

      - name: Decode AWS credentials
        ^ here
  reason: Failed

Any help appreciated! :-)

@susinths From the error, it looks like the aws secret is missing the credentials, which should be found in data.cloud. Was the secret created as described in https://github.com/konveyor/oadp-operator#creating-credentials-secret ?

I agree with Scott. That sounds like what you are missing. We should handle this error more gracefully and display it to the end user but I believe this is just missing that secret with data.


Oviraptor Incubation Buff Effects

buff effect showing on wild oviraptors and non incubating oviraptors.

Fixed buff effect showing on wild oviraptors and non incubating oviraptors.


Generate Rust docs for the server's OperationRegistry

Including a quickstart example for the service being generated that the
user can copy and paste.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

What this looks like:


Fix CAS undeploy LDAP thread failed to stop

We should properly stop all LDAP connection pools (which is implemented as thread pools) upon CAS undeploy, otherwise these thread will be orphaned at servlet server (if servlet server is not shutdown), causing memory leak.
In tomcat such error will be observed:
The web application [cas] appears to have started a thread named [XXXXX] but has failed to stop it. This is very likely to create a memory leak.
FYI, the patch in CasPersonDirectoryConfiguration.java is only a workaround. A more proper fix is modifying LdaptivePersonAttributeDao and add a cleanup method, however it is outside of apereo/cas.
LdapPasswordSynchronizationConfiguration.java is also sort of workaround, but I cannot think of more appropriate way.
Also, I consider vt-middleware/ldaptive#174 to be a bug. There should be a way to check the thread pools is closed or not, instead of blindly sleep for a fixed period and assume the pool is closed.

ldaptive maintainer fixed the async shutdown problem, is it possible to update CAS to latest ldaptive snapshot so that I can remove the 5 sec wait?

The 5 sec wait is removed anyway because the ServletContextListener in #4812 already have 5 sec wait

still pending for merge

Found there is more test failure. Need to catch out first (and possibly rewrite some bean tracking using prototype bean scope.

Now the fix is much more elegant and should pass test cases.

Prototype bean cannot be disposed automatically, need to study how to dispose manually.
https://stackoverflow.com/questions/50681027/do-spring-prototype-beans-need-to-be-destroyed-manually

All prototype beans should be properly destroyed now

All prototype beans should be properly destroyed now

Are all prototype beans being referenced in a map in DestroyPrototypeBeansPostProcessor for the life of the server being up? That seems like a memory leak if that is the case because they wouldn't be garbage collected even if they aren't used or referenced elsewhere.

All prototype beans should be properly destroyed now

Are all prototype beans being referenced in a map in DestroyPrototypeBeansPostProcessor for the life of the server being up? That seems like a memory leak if that is the case because they wouldn't be garbage collected even if they aren't used or referenced elsewhere.

Yes, but I cannot think of any other method to properly destroy prototype beans. If you believea it is a concern, then the commit b686537382b1ee36cada8ba75eb49fe6bdb53fda would be a better solution. This explicitly marks all long-lived prototype beans that need to be collected.

ready for merge

In this case I would close this PR first, since I will be busy with other things soon. Breaking this PR need some time and multiple PR is required anyway.


buffrs::build should be resilient to non-existent credentials

Currently we open the credential file eagerly and expecting it to be present. buffrs::build should not error if it does not use the registry (and thus require the credentials)
So we should move from
1. Open the credential file
2. Check if protos are missing
3. Download (eventually) missing protos
4. Compile protos

To
1. Check if protos are missing
2. If yes, open credential file and download protos
3. Compile Protos

FYI @tetigi

Current workaround requires running buffrs login to generate the credentials file.


Feature request: text overflow UX improvements

When there is a large text body in a column now, there is no way to see the full text except inspect the HTML element. It would be nice to be able to see the full text. I have some solutions in mind, each its own feature. Having all of them would be amazing, but just one is a good start
Text popup on hover
It would be nice to have the full text in a little pop-up when you hover over overflowing columns.
Resizeable columns when you drag the column border
I know this isn't a small feature and probably not very easy, but would be very cool to have
Auto horizontally size rows
Auto-increase the row height if not all columns fit. But only behind an option, also not nice to always have this. Maybe behind a right mouse click option, "expand row", "expand all rows"

You can double click on a cell and a popup with the full cell content will appear, does that work for you?

@sosedoff double clicking does nothing for me, both firefox and chromium

Which version are you on? This is a recently added feature so give pgweb v0.14 a try.

Ah now it does work!


Eq 1461 update enter person 1 details

What is the context of this PR?
Piping "address_line_1" into question
Card: https://trello.com/c/XW1OfqKO/1461-update-enter-person-1-details-s
How to review
Run Census Household and check that enter individuals name question now has address piped into it

need to add the extra guidance

needs a yarn format

@MIslam92 squishy-squashy mergy-rebasy