Extension search is broken

Issue Type: Bug
Seemed to have started with yesterday's insiders. If you type in the extensions search box, you get no results and the title says Disabled. See below:

VS Code version: Code - Insiders 1.41.0-insider (4934a6f487b9ed6b99b900ae0710c7b452792e20, 2019-11-20T05:25:39.619Z)
OS version: Windows_NT x64 10.0.19025

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (17.95GB free)

Process Argv

Screen Reader
no

VM
0%

Cannot reproduce using the latest insiders. Can you still reproduce this?

Yeah, even with the 2nd insiders build today.

I see the same thing

I tested both the builds on my windows machine even with a fresh user data dir, couldn't repro.
What headers are sent for the cancelled request ?
Can you also try launching vscode with --disable-features="OutOfBlinkCors" and check ?

Headers are

Accept: application/json;api-version=3.0-preview.1
Content-Type: application/json
Origin: file://
Sec-Fetch-Mode: cors
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.41.0-insider Chrome/76.0.3809.146 Electron/6.1.4 Safari/537.36
X-Market-Client-Id: VSCode 1.41.0-insider
X-Market-User-Id: 7e8a9fb5-fe45-4bed-92c4-761a115ab42a

Though I'm now thinking the cancelled request might be unrelated? I also see an initial cancelled request on stable, followed by a successful request.

If I continue to type in the input box on insiders, no further requests get made.
We seem to ignore the disable-features flag, I get Option 'disable-features' is unknown. Ignoring. when trying to use it

We seem to ignore the disable-features flag

Ah yeah needs to be fixed in https://github.com/microsoft/vscode/issues/84564
Can you verify this from out of sources build, in that case make the following change.
diff --git a/src/main.js b/src/main.js
index d5f4c907fe..c800b74d30 100644
--- a/src/main.js
+++ b/src/main.js
@@ -143,6 +143,8 @@ function configureCommandlineSwitchesSync(cliArgs) {
                        return; // unsupported argv key
                }

+               app.commandLine.appendSwitch('disable-features', 'OutOfBlinkCors');
+
                const argvValue = argvConfig[argvKey];
                if (argvValue === true || argvValue === 'true') {
                        if (argvKey === 'disable-hardware-acceleration') {

I am also not able to repro it.
@eamodio @RMacfarlane Can you please try reproducing it from sources.
Note you have to enable Marketplace for that. I will ping you directly how to enable it.
It would be helpful to nail it down if you can repro from out of sources.

Re request cancellation, we cancel it if there is a new request.

@alexr00 was also seeing this weird behaviour. It disappeared after updating insiders.
@eamodio Can you please try with latest insiders?

Ok, I have repro steps now. I still see this in the latest insiders, and it's related to what views are shown.

In the extensions viewlet, right click and hide the "Recommended" view.
Type in search box - get no results

This causes the error
 ERR view descriptor extensions.disabledExtensionList not found: Error: view descriptor extensions.disabledExtensionList not found
    at PersistentContributableViewsModel.find (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/views.js:280:19)
    at PersistentContributableViewsModel.setCollapsed (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/views.js:224:59)
    at file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/viewsViewlet.js:161:37
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:55:106
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:43:93
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at DisabledExtensionsView.set headerVisible [as headerVisible] (file:///Users/ramacfar/dev/vscode/out/vs/base/browser/ui/splitview/paneview.js:106:31)
    at ExtensionsViewlet.updateViewHeaders (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/paneViewlet.js:317:54)
    at ExtensionsViewlet.removePanes (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/paneViewlet.js:278:18)
    at ExtensionsViewlet.onDidRemoveViews (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/viewsViewlet.js:183:18)
    at file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/viewsViewlet.js:42:57
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at PersistentContributableViewsModel.onDidChangeViewDescriptors (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/views.js:341:35)
    at file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/views.js:175:91
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at ViewDescriptorCollection.onContextChanged (file:///Users/ramacfar/dev/vscode/out/vs/workbench/browser/parts/views/views.js:148:35)
    at Emitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:461:41)
    at file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:55:106
    at PauseableEmitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:458:38)
    at PauseableEmitter.fire (file:///Users/ramacfar/dev/vscode/out/vs/base/common/event.js:519:27)
    at ContextKeyService.setContext (file:///Users/ramacfar/dev/vscode/out/vs/platform/contextkey/browser/contextKeyService.js:247:42)
    at ContextKey.set (file:///Users/ramacfar/dev/vscode/out/vs/platform/contextkey/browser/contextKeyService.js:143:27)
    at ExtensionsViewlet.doSearch (file:///Users/ramacfar/dev/vscode/out/vs/workbench/contrib/extensions/browser/extensionsViewlet.js:422:41)
    at file:///Users/ramacfar/dev/vscode/out/vs/workbench/contrib/extensions/browser/extensionsViewlet.js:396:51
    at file:///Users/ramacfar/dev/vscode/out/vs/base/common/async.js:174:28

and this error is causing the token that gets passed through to the request service to get cancelled.
@sbatten Could this be related to any layout refactoring?

@sbatten I think the problem is here https://github.com/microsoft/vscode/blob/1ca17cd262c53f632a56ccadf92a3d38ee49cfd0/src/vs/workbench/browser/parts/views/viewsViewlet.ts#L242
The concept of "index" here is confusing, it appears to be the index of the view taking into account both visible and hidden views. So the "Disabled" view has index 2 even though it is displayed at index 1.

@sandy081, @sbatten's change was only a rename, after reverting to before 744b5161318a2ebcbd2f0fe0d3124697487907b1 the search works as expected

@RMacfarlane Thanks for the steps and I can repro it too. I guess this is caused due to the fix I did here - #79519. I am actually emitting events with wrong visible indices. Hence views are getting shown and hidden like crazy.
Working on the fix.

Confirmed that this caused by my fix in #79519.
109fab8 fixes this. Sorry for this.


Temporary switching back to Rust 1.32.0

Overview
Switching back to Rust 1.32.0 until bugs introduced by latest compiler version fixed.

See: https://jira.bf.local/browse/ECR-XYZ
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Coverage remained the same at 85.631% when pulling 21b4002514944029e210fcb249beab7de3fad91a on skletsun:switch-back-to-rust-1.32 into 20a5610857dafd271955744d27cacc4f36060515 on exonum:master.


Opening big files leads to Unix EMFILE error

Good morning,
I am trying to open multiple files with several hundred of lines, using the following function:
  let launch_solver target formula =
    let open Feather in
    let open Feather.Infix in
    let files = ls target |> collect_lines in
    let times = List.map files
        ~f:(fun x -> let path = target^"/"^x in
             let trimed = cat path |. head (-2) |> collect_stdout in
             echo trimed > path |> run;
             echo formula >> path |> run;
             let now = Caml.Sys.time () in
             process "z3" [path] > devnull |> run;
             let time_facet = (Float.((Caml.Sys.time ()) - now)) in
             time_facet
           )

Here, target is a folder and files has about 273 elements in it, so no big deal.
However, the program crashes when calling let trimed = cat path |. head (-2) |> collect_stdout in with the following stacktrace
my_prog: internal error, uncaught exception:
       Unix.Unix_error(Unix.EMFILE, "dup", "")
       Raised by primitive operation at Spawn.spawn in file "src/spawn.ml" (inlined), line 118, characters 6-16
       Called from Spawn.spawn in file "src/spawn.ml", line 125, characters 2-65
       Called from Feather.exec in file "feather.ml", line 147, characters 4-122
       Called from Feather.eval in file "feather.ml", line 165, characters 6-173
       Called from Feather.collect_gen in file "feather.ml", line 288, characters 2-177
       Called from Feather.collect_stdout in file "feather.ml", line 300, characters 33-60
       Called from Dune__exe__Disco.launch_solver.(fun) in file "bin/my_prog/my_prog.ml", line 108, characters 26-65
       Called from Base__List.count_map in file "src/list.ml", line 407, characters 13-17
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.count_map in file "src/list.ml", line 415, characters 47-72
       Called from Base__List.map in file "src/list.ml" (inlined), line 418, characters 15-31
       Called from Dune__exe__Disco.launch_solver in file "bin/my_prog/my_prog.ml", line 106, characters 16-428
       Called from Cmdliner_term.app.(fun) in file "cmdliner_term.ml", line 25, characters 19-24
       Called from Cmdliner.Term.run in file "cmdliner.ml", line 117, characters 32-39
Fatal error: exception Unix.Unix_error(Unix.EMFILE, "dup", "")
Raised by primitive operation at Feather.Unix.dup in file "feather.ml", line 14, characters 12-29
Called from Feather.collect_gen in file "feather.ml", line 290, characters 21-40
Called from Feather.collect_lines in file "feather.ml" (inlined), line 307, characters 25-52
Called from Feather.terminate_child_processes in file "feather.ml", line 442, characters 2-70
Called from Stdlib.at_exit.(fun) in file "stdlib.ml", line 553, characters 62-65
Called from Stdlib.do_at_exit in file "stdlib.ml" (inlined), line 556, characters 20-39
Called from Stdlib.exit in file "stdlib.ml", line 559, characters 2-15
Called from Cmdliner.Term.exit in file "cmdliner.ml" (inlined), line 289, characters 25-72
Called from Dune__exe__Disco in file "bin/my_prog/my_prog.ml", line 184, characters 2-46

According to https://ocaml.org/api/Unix.html, EMFILE error seems to indicate that there are too many open files in my process, however I only open one file at the time. It may come from the "z3" binary, but I am not sure exactly how it may interfere.
The problem seems to come from the collect_stdout functions: I tried to replace the head pipe with a custom head function, and it kept crashing. Also, replacing collect_stdout by collect_lines makes the program crash much earlier.
Could you look at it? Thanks in advance for your time.

There was a file descriptor leak in the spawning process we found with @tmarti2 : can you check if pinning Feather to https://github.com/Firobe/feather.git solves your issue ?

Confirmed that pinning your version solves the issue, thanks again :D

Thanks for reporting @GirardR1006 and thanks for the quick fix @Firobe!


Missed a Partial on SaveOptions

@derevnjuk  - I missed one place that I need to add the Partial to. When you get another chance.


Associations

Rental, Book , Classroom

Create a class Classroom with the following:

@label instance variable, should be initialized in the constructor.
Setter and getter for @label (remember about attr_accessor).

Create the has-many/belongs-to relationship between Classroom and Student. The following should be implemented:

Create the has-many side (a classroom has many students).
Create the belongs-to side (a student belongs to a classroom).
Make sure that when adding a student to a classroom it also sets the classroom for the student.
Make sure that when setting the classroom for a student it also adds it to the classrooms' students.

Create a class Book with the following:

@title and @author instance variables, should be initialized in the constructor.
Setters and getters for instance variables (remember about attr_accessor).

Create a class Rental with the following:

@date instance variable, should be initialized in the constructor.
Setter and getter for @date (remember about attr_accessor).

Create the many-to-many (also has-many-through) relationship between Person and Book using the intermediate class Rental. The following should be implemented:

Create the has-many side of Book and Rental (a book has many rentals).
Create the belongs-to side of Rental and Book (a rental belongs to a book).
Create the has-many side of Person and Rental (a person has many rentals).
Create the belongs-to side of Rental and Person (a rental belongs to a person).
Modify the constructor of Rental so Book and Person are set in it.

Status: Invalid 🔴
Hi @Rishi-Mishra0704 🙋♀,
While you made a great effort in this project, I can't review your code.
Invalid Code Review Request
You have submitted a project that has a README that is not professional. Here are key points to consider when documenting your README.

The only optional section is the FAQ section. If there's no information in the FAQ section then it should be deleted. ✔
However, since you deleted the FAQ section, it would be best if you also removed it from the table of contents.

All main headers from the README template should be present.  ✖

Each section description should be removed and replaced with their custom content. The section descriptions are meant to guide you in documenting your README. They are not meant to be part of the final documentation. ✖

For example:

There should not be any blank sections that do not have content. ✖

The Show your support and Acknowledgments sections are compulsory. Kindly add the relevant content

Delete the live demo section if the application is not deployed. If project requirements say to deploy the project, the section should be restored and the link updated.

Delete the FAQ section since you do not have content for it.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers 🥂  and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini  in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


Add JuliaMono type face

Adds the JuliaMono type to the list of fonts:

Landing page: https://juliamono.netlify.app/
Overview and FAQ: https://cormullion.github.io/pages/2020-07-26-JuliaMono/

Might be nice to have WOFF/WOFF2 in there, but I see they don't offer than in the download so we'd have to convert ourselves, yeah? This seems to work fine so we can just leave it.

Thanks!

Thanks for merging this one @chriscoyier 🌟 I've gone ahead and raised #41 to convert the font file to WOFF instead for consistency with the rest of the project -- apologies for not seeing it sooner!


feature(main): add version

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

this feature need optimize, like k8s use env to set var.

@fanux
env: GIT_TAG  code version
MULTI_PLATFORM_BUILD  all support platform build(linux and darwin)


Fix insertion into occupied NullStorage entry

Fixes #266

r? @Ralith
Sorry for the delay!

Is there a principled basis on which to conclude this approach is actually safe? In the issue I proposed a workaround that doesn't actually require potentially taking multiple mutable references to the same thing in parallel, though I can't imagine how that could go wrong in practice.

I don't see how this could potentially go wrong. Here's why:

Nobody reads any bytes from the data
Nobody writes any bytes to the data
Even if there was a data race, it wouldn't matter since we don't care about the value

I agree that a data race is unlikely to be an issue. I'm more concerned about whether this is strictly defined behavior, which rust does not actually have pinned down yet, so perhaps it's a futile worry.

@Ralith Thanks for the review.
bors r+


Action buttons for folder search result nodes

I think this is the only remaining task from https://github.com/Microsoft/vscode/pull/29964#pullrequestreview-51625410

The action buttons are hidden for folders. Maybe could be done as a follow-up PR?

I think the folders should have action buttons, but I don't need everything in one PR.

@keegancsmith Would take a PR for this if you're up for it, otherwise I can do it.

@roblourens Thanks for filing. I can tackle this, but will only have time at the end of this week / early next week if that is alright (I see you added to this months iteration milestone).

That would be fine, thanks!

@roblourens apologies, the other work on my plate is taking more time than I expected. I don't think I'll be able to address it this week.

This is complete now, right?

We are still missing the replace action on FolderMatch. However, that should be a much smaller PR (but requires more testing) than the above.

Oh right, I'll leave this issue open for that.


Event Managers Lister

Breakout from #1803
Include a page which will lists all authorized event users - might be a filtered view of the page from #1896
This page should allow org admins, campaign managers and event managers to see all of the users who can manage events, including their roles.
@schuback - Should event managers also be able to see this lister / add and remove other event managers? My initial impression would be that that access is limited to the level above, but perhaps a lister is still useful? Also, not sure if we should expose contact details etc in this screen to enable communication outside of allReady, such as phone numbers?
Should also include the link to the invite page for org admins and campaign managers only

@stevejgordon - I agree with keeping it to the upper level for adding
managers. I do like the ability of managers seeing a list of other managers
in their org. For sure no reveal of contact/personal information.
On Thu, Mar 16, 2017 at 11:06 AM, Steve Gordon<EMAIL_ADDRESS>wrote:

Breakout from #1803 https://github.com/HTBox/allReady/issues/1803
Include a page which will lists all authorized event users - might be a
filtered view of the page from #1896
https://github.com/HTBox/allReady/issues/1896
This page should allow org admins and campaign managers to see all of the
users who can manage events, including their roles.
@schuback https://github.com/schuback - Should event managers also be
able to see this lister / add and remove other event managers? My initial
impression would be that that access is limited to the level above, but
perhaps a lister is still useful? Also, not sure if we should expose
contact details etc in this screen to enable communication outside of
allReady, such as phone numbers?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HTBox/allReady/issues/1900, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAyqVDyeiuTOc8JmsC3haaLFf12_XfSdks5rmXohgaJpZM4MfrWR
.

--
Pascal Schuback
<EMAIL_ADDRESS>206.414.8799
@schuback

Thanks @schuback - Will update issues accordingly

I'm investigating this issue and building out the query for the page, and want to verify exactly which credentialed users you'd like to see:

The explicit managers for the selected event
The campaign organizers for the campaign managing the event?
The organization administrators?
The site administrators?

Should a lower level administrator reviewing the list of Event Managers be able to see the upper level admins who also have access to the event?
Also: to confirm from the description, this is defined as a separate page and not a separate segment of the same /Admin/Event/Details page correct?


NTR: Single-stranded DNA-dependent CTPase activity

GO term name: single-stranded DNA-dependent CTPase activity
Definition:
Catalysis of the reaction: CTP + H2O = CDP + phosphate; this reaction requires the presence of single-stranded DNA, and it drives another reaction.
Aspect: Molecular Function
Relationships:
Ancestor Chart
is_a CTPase activity (GO:0043273) --> is_a CTPase activity, coupled (NTR)--> is_a DNA-dependent GTPase activity (NTR) --> is_a single-stranded DNA-dependent CTPase activity (NTR)
References:
PMID: 26277776
Figure 6
I've used GO:0043142 (Single-stranded DNA-dependent ATPase activity) as a reference.
Thanks,
Javier K.
CACAO participant

[Term]
+id: GO:0061747
+name: CTPase activity, coupled
+namespace: molecular_function
+def: "Catalysis of the reaction: CTP + H2O = CDP + phosphate; this reaction directly drives some other reaction." [GOC:dph, PMID:26277776]
+is_a: GO:0043273 ! CTPase activity
+created_by: dph
+creation_date: 2015-11-11T13:02:49Z
+
+[Term]
+id: GO:0061748
+name: single-stranded DNA-dependent CTPase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: CTP + H2O = CDP + phosphate; this reaction requires the presence of single-stranded DNA, and it drives another reaction." [GOC:dph, PMID:26277776]
+is_a: GO:0061747 ! CTPase activity, coupled
+created_by: dph
+creation_date: 2015-11-11T13:05:32Z
+


AudioQueue is always empty

public var audioQueued: [SAAudioQueueItem] - this one appears to be empty since it is not proxy-ed from presenter - in presenter it is up to date

SAPlayer.swift
185:
it should get presenter.audioQueue
public var audioQueued: [SAAudioQueueItem] {
    get {
        return presenter.audioQueue
    }
    set {
      presenter.audioQueue = newValue
    }
}

@tanhakabir  can u help it?
thanks

Yep! Externally you should be working with the audio queue saved in the presenter. Is there an issue with it?

@tanhakabir of course, presenter is not public. In order to get access to the queue the code should be adjusted as @twjazzhuang suggested

Fixed and published from https://github.com/tanhakabir/SwiftAudioPlayer/pull/149


Project description.

Project Overview:
General links.

Link to the project: Recipe-App
Here is the task distribution.

Contributors:

Anwar Hussaini: Developer A
Pablo Thasi: Developer B

Hi @M-Anwar-Hussaini & @thasipablo ,

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
✅ Good commit messages
✅ Good descriptive PR
✅ Have To Do column
✅ Have an In Progress column
✅ Have an In Review column
✅ Have Done column
✅ Have a descriptive title
✅ The number of points in the [Xpt] prefix
✅ Have a description of the task.
✅ all cards are assigned to team members.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Is this project still maintained?

I noticed no replies in the last months and I was wondering if this project is still supported and maintained.
I should start a project that needs these functionalities and this will change the whole structure.
Thanks

let's try https://github.com/charlymr/XlsxReaderWriter

Thanks @BananZGan!


Xcode 9 GYM Error: Can't add export_xcargs: "-allowProvisioningUpdates" to fastfile.

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
We are having the same problem that others have had when attempting to build and export our enterprise app where it is creating the package and it can't find the provisioning profile. It seems like the same fix (adding export_xcargs: "-allowProvisioningUpdates") should fix it, however when we attempt to do so we get a gym error "Could not find option 'export_xcargs' in the list of available options:" We've tried adding this in various ways to no avail. Can anyone see what might be the issue? Here is our fastfile code:
# Build the app ENV["PROFILE_UUID"] = sigh( team_id: options[:team_id] || "X555J2KHFQ", app_identifier: options[:app_identifier] || "org.mycompany.*" ) gym( 	scheme: options[:scheme], 	export_method: "enterprise", 	export_xcargs: "-allowProvisioningUpdates"   )
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

`
+-------------------------------------+------------------------------+
|                      Summary for sigh 1.11.2                       |
+-------------------------------------+------------------------------+
| team_id                             | XXXXXXXXXX                   |
| app_identifier                      | org.mycompany.mw.prs.abp.*         |
| adhoc                               | false                        |
| development                         | false                        |
| skip_install                        | false                        |
| force                               | false                        |
| username                            | ******** |
| ignore_profiles_with_different_name | false                        |
| skip_fetch_profiles                 | false                        |
| skip_certificate_verification       | false                        |
+-------------------------------------+------------------------------+
[19:23:17]: Starting login with user '********'
[19:23:19]: Successfully logged in
[19:23:19]: Fetching profiles...
[19:23:20]: Provisioning Profile 'org.mycompany.mw.prs.abp.* InHouse' is not valid, skipping this one...
[19:23:20]: Provisioning Profile 'XC: org.mycompany.mw.prs.abp.' is not valid, skipping this one...
[19:23:21]: Found 1 matching profile(s)
[19:23:21]: Downloading provisioning profile...
[19:23:21]: Successfully downloaded provisioning profile...
[19:23:21]: Installing provisioning profile...
/Users/myapp/Documents/jenkins/workspaces/MyAPP/workspace/InHouse_org.mycompany.mw.prs.abp..mobileprovision
[19:23:21]: Setting Provisioning Profile type to 'enterprise'
[19:23:22]: -----------------
[19:23:22]: --- Step: gym ---
[19:23:22]: -----------------
[19:23:22]: You passed invalid parameters to 'gym'.
[19:23:22]: Check out the error below and available options by running fastlane action gym
[19:23:22]: ----------------------------
[19:23:22]: --- Step: reset_git_repo ---
[19:23:22]: ----------------------------
[19:23:22]: $ git reset --hard HEAD
[19:23:22]: ▸ HEAD is now at 4ddcf0c6 Merge branch 'FRG-iOS' into release-2.2.2
[19:23:22]: $ git clean -qfdx
[19:23:22]: Git repo was reset and cleaned back to a pristine state.
[19:23:22]: -----------------------------------
[19:23:22]: --- Step: clean_build_artifacts ---
[19:23:22]: -----------------------------------
[19:23:22]: Cleaned up build artifacts 🐙
[19:23:22]: ------------------------------------------------------------------------
[19:23:22]: --- Step: killall 'Simulator' || echo 'No simulators to force kill.' ---
[19:23:22]: ------------------------------------------------------------------------
[19:23:22]: $ killall 'Simulator' || echo 'No simulators to force kill.'
[19:23:22]: ▸ No matching processes belonging to you were found
[19:23:22]: ▸ No simulators to force kill.
[19:23:22]: --------------------------------
[19:23:22]: --- Step: clear_derived_data ---
[19:23:22]: --------------------------------
[19:23:22]: Derived Data path located at: /Users/myapp/Library/Developer/Xcode/DerivedData
[19:23:22]: Successfully cleared Derived Data ♻
[19:23:22]: ------------------------------
[19:23:22]: --- Step: reset_simulators ---
[19:23:22]: ------------------------------
[19:23:22]: Resetting iPhone 5s
[19:23:23]: Resetting iPhone 6
[19:23:24]: Resetting iPhone 6 Plus
[19:23:25]: Resetting iPhone 6s
[19:23:26]: Resetting iPhone 6s Plus
[19:23:27]: Resetting iPhone 7
[19:23:28]: Resetting iPhone 7 Plus
[19:23:28]: Resetting iPhone SE
[19:23:29]: Resetting iPhone 8
[19:23:30]: Resetting iPhone 8 Plus
[19:23:31]: Resetting iPhone X
[19:23:31]: Resetting iPad Air
[19:23:32]: Resetting iPad Air 2
[19:23:33]: Resetting generation)
[19:23:34]: Resetting iPad Pro (9.7-inch)
[19:23:35]: Resetting iPad Pro (12.9-inch)
[19:23:36]: Resetting iPad Pro (10.5-inch)
[19:23:38]: Simulators reset
[19:23:38]: Variable Dump:
[19:23:38]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"MyAPP-FRG-Stage", :BUILD_NUMBER=>"There does not seem to be a CURRENT_PROJECT_VERSION key set for this project.  Add this key to your target's expert build settings.", :SIGH_PROFILE_PATH=>"/Users/myapp/Documents/jenkins/workspaces/MyAPP-FRG-Stage/workspace/InHouse_org.mycompany.mw.prs.abp..mobileprovision", :SIGH_PROFILE_PATHS=>["/Users/myapp/Documents/jenkins/workspaces/MyAPP-FRG-Stage/workspace/InHouse_org.myapp.mw.prs.abp..mobileprovision"], :SIGH_UDID=>"4500d438-8763-4e34-8216-ff89368043ba", :SIGH_PROFILE_TYPE=>"enterprise"}
[19:23:38]: Could not find option 'export_xcargs' in the list of available options: workspace, project, scheme, clean, output_directory, output_name, configuration, silent, codesigning_identity, include_symbols, include_bitcode, use_legacy_build_api, export_method, export_options, skip_build_archive, build_path, archive_path, derived_data_path, result_bundle, buildlog_path, sdk, toolchain, provisioning_profile_path, destination, export_team_id, xcargs, xcconfig, suppress_xcode_output, disable_xcpretty, xcpretty_test_format, xcpretty_formatter, xcpretty_report_junit, xcpretty_report_html, xcpretty_report_json
+------+----------------------------------------------------------+-------------+
|                               fastlane summary                                |
+------+----------------------------------------------------------+-------------+
| Step | Action                                                   | Time (in s) |
+------+----------------------------------------------------------+-------------+
| 1    | import_from_git                                          | 0           |
| 2    | Verifying required fastlane version                      | 0           |
| 3    | default_platform                                         | 0           |
| 4    | Switch to ios deploy_tech lane                        | 0           |
| 5    | clean_build_artifacts                                    | 0           |
| 6    | clear_derived_data                                       | 6           |
| 7    | number_of_commits                                        | 0           |
| 8    | increment_build_number                                   | 2           |
| 9    | sigh                                                     | 4           |
| 💥    | gym                                                      | 0           |
| 11   | reset_git_repo                                           | 0           |
| 12   | clean_build_artifacts                                    | 0           |
| 13   | killall 'Simulator' || echo 'No simulators to force kill.' | 0           |
| 14   | clear_derived_data                                       | 0           |
| 15   | reset_simulators                                         | 15          |
+------+----------------------------------------------------------+-------------+
[19:23:38]: fastlane finished with errors
[!] Could not find option 'export_xcargs' in the list of available options: workspace, project, scheme, clean, output_directory, output_name, configuration, silent, codesigning_identity, include_symbols, include_bitcode, use_legacy_build_api, export_method, export_options, skip_build_archive, build_path, archive_path, derived_data_path, result_bundle, buildlog_path, sdk, toolchain, provisioning_profile_path, destination, export_team_id, xcargs, xcconfig, suppress_xcode_output, disable_xcpretty, xcpretty_test_format, xcpretty_formatter, xcpretty_report_junit, xcpretty_report_html, xcpretty_report_json
/var/folders/b_/khfxl00x76s_zcvj33cqzyyr0000gn/T/hudson948403866362078323.sh: line 6: shell_session_update: command not found
Build step 'Execute shell' marked build as failure
Finished: FAILURE`
Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.

Gem
Version

did_you_mean
1.0.0

slack-notifier
1.5.1

CFPropertyList
2.3.3

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.2

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

terminal-table
1.4.5

plist
3.2.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.4

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.54.0

faraday
0.10.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161021

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.2

json
1.8.3

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.5.5

rubyzip
1.1.7

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.1

bundler
1.13.6

faraday_middleware
0.10.1

uber
0.0.15

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
2.1.0

addressable
2.5.2

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
<IP_ADDRESS>

google-api-client
0.13.6

io-console
0.4.5

Yes we looked quite a bit at the code signing troubleshooting guide.

| Summary for sigh 1.11.2 |

Please make sure to update to fastlane 2.x.x. If you have a Gemfile, please make sure to only include fastlane and not sigh. If not, make sure to run gem uninstall sigh and any other gems you have and then gem update fastlane 👍


[FEATURE] Add support for Highlight.js themes

Description
Thsi would very cool to have different theme like dracula or anything into the web viewer.

Closing in favor of #128


Adding babel config inside "using-with-jest.md"

Adding more detailed "using with babel" paragraph since it was not fully complete and required
additional steps that were not present in using-with-jest documentation section.
#1666

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[X] Other, please describe:

Adding more description to docs
Does this PR introduce a breaking change? (check one)

[ ] Yes
[X] No

The PR fulfills these requirements:

[X] It's submitted to the dev branch.
[X] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[X] All tests are passing: https://github.com/vuejs/vue-test-utils/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

There is no need for new tests, as all .md formatting tests pass.
If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

PS this is marked as WIP - are you intending on doing more changes?

Marked WIP because i knew there were some other small final changes to be made (and there were few). Its ready for review now.

Thanks!


Missing FPGA implementation

Nocode runs too slow on my FPGA board, how am I supposed to take profit of it?

Maybe you should try change the synth from Verilog or VHDL to NoCode Synth.  Verilog / VHDL can make some ports connected which pollutes the FPGA. Try to compile using this:


Show only correct answers

I found it helpful to filter out the incorrect answers.
Before:

After:

It's an interesting idea, but I think could be confusing for users. Thanks for the suggestion!


https://sonarwhal.com/about/changelog/ => 404

https://sonarwhal.com/about/changelog/

[changelog.html] page doesn't show any content.


Usage in TypeScript project where "allowSyntheticDefaultImports": false

I am trying to get this package working in my TypeScript app that doesn't allow synthetic default imports.
// tsconfig.json
{
  "allowSyntheticDefaultImports": false,
  "esModuleInterop": false,
}

I can import dayjs using the asterisk syntax without any warnings:
import * as structuredClone from '@ungap/structured-clone';

However when I go to call structuredClone() I see a function dne error: TypeError: structuredClone is not a function
Logging structuredClone yields this object:
{
  default: ƒ,
  deserialize: ƒ,
  serialize: ƒ,
  __esModule: true,
}

// package.json
{
  "@types/ungap__structured-clone": "^0.3.0",
  "@ungap/structured-clone": "^1.0.1",
}

If you import * from the module you need to use structuredClone.default(…) instead

@WebReflection The type declarations don't support that syntax. Should I make a PR in DefinitelyTyped that supports that kind of invocation? What's the proper way to go about this?

@charlesfries I'm afraid I don't use TypeScript so I don't know the best way to support it but, if you do, please file a PR and I'll push it forward 👍

To future readers, it is possible to do:
npm i -s @ungap/structured-clone

npm i -d @types/ungap__structured-clone

Then in your code:
import structuredClone from '@ungap/structured-clone';


chore(main): release 1.270.0

When this PR is merged, a new tagged release will be created with the notes below.
1.270.0 (2024-10-22)
Features

Add Firefox to LCP test matcher (#1223) (c6a20e1)
Move deregisterDrain method to feature-base (#1220) (5fdea14)
Relocate aggregator from loader and improve agent internals (#1216) (789df5a)
Remove 'pageHide' from page end-of-lifecycle listener (#1219) (daf349e)
Remove supportsSendBeacon runtime property (#1224) (a5996be)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/newrelic/newrelic-browser-agent/releases/tag/v1.270.0 :sunflower:


Entity: Best method/optimizations to delete lots of entities at once

What version of entt are you using? 3.6.0
The Background Context:
I have "bundles" of entities that I store together in a std::vector<entt::entity>. A bundle is a logically related group of entities that are created and destroyed together; a particular game level may be a single bundle and the level next to it is a separate bundle. The entities do not have identical components. As an example: 100% of the entities in a level will have a PositionComponent, but 85% will have a WallComponent, and only 5% will have a DamageZoneComponent, etc. There are around 40 component types that could be present on the entities in a bundle, and around 300 pools total in the registry. The entities are always all created at the same time in the order they are stored in the vector, but the components are sometimes created later, or in a different order.
The Issue:
For complex levels, these bundles contain thousands of entities. When a level is deleted, I do the following:
for (entt::entity e : bundle.entities)
    registry.destroy(e);

For around 6000 entities, this can take around 37.5ms in entt code (not including on_destroy signals). Inlining makes it hard to identify exactly where the time is spent, but I would assume the main culprits are cache misses and time spent moving around components, many of which are just going to be deleted in a few iterations anyway.
The Questions:

Are there any optimizations I can/should take advantage of here to improve the destroy time? I know there is a range-destroy function, but it is functionally equivalent to what I am doing here (i.e. it is just a for-loop that calls destroy anyway). Perhaps I should be deleting ranges of the more common components first, or something like that?

Are there any recommendations in general for the bundle pattern that I've described? For example, are there other optimizations I could take advantage of if I used some sort of runtime tag to identify the entities that are part of a particular level instead of putting them in a vector? Of course, very few operations are performed on the list of entities in the bundle; views and groups of the potential components are used almost always outside of the create/destroy steps.

For around 6000 entities, this can take around 37.5ms in entt code (not including on_destroy signals).

These numbers seem odd. I'm facing a similar optimization in a project that has a thousand pools and we are talking to save ~1ms or so. I guess it depends on the hw, but still ~40ms seems very high.

I know there is a range-destroy function, but it is functionally equivalent to what I am doing here (i.e. it is just a for-loop that calls destroy anyway).

A review of the range destroy is in my pipeline, but it requires to split view iterators from views before proceeding.
Long story short, it works like that now because I wanted to also support view iterators. In this case, you can't cleanup a pool at a time because the view would appear as empty as soon as you reset one of its types. However, pools already support the range-remove and it's ofc optimized. So, the goal is to unwrap the iterators and use the optimized path when they don't belong to a view.

Are there any optimizations I can/should take advantage of here to improve the destroy time?
Are there any recommendations in general for the bundle pattern that I've described?

There are many, from cleaning up pools in parallel and force-destroying entities to using a pool mixin that tracks assigned components (for example with a bloom filter or such) and touches only a few storage classes on destruction and so on. The best one depends on your mt requirements, that is, if you want to remove components/destroy entities in parallel or not.
The other option is to wait until I come up with and publish an update upstream because I'm working on this specific aspect, so it's probably only a matter of time to have something built-in.

I guess it depends on the hw, but still ~40ms seems very high.

That 37.5ms number was averaged from captures on older hardware. On new hardware, the same code span still takes ~9ms. These numbers are from optimized (/O2) code with assertions and iterator debug checks disabled.

There are many, from cleaning up pools in parallel and force-destroying entities to using a pool mixin that tracks assigned components (for example with a bloom filter or such) and touches only a few storage classes on destruction and so on. The best one depends on your mt requirements, that is, if you want to remove components/destroy entities in parallel or not.

I do have a thread pool available, so parallelization is an option. I'm curious what you would recommend here since not every component will be on every entity.
My primary alternative is some sort of throttling, i.e. moving the contents of the bundle to a pendingDeletion list and draining some smaller number of entities from that every frame.

The other option is to wait until I come up with and publish an update upstream because I'm working on this specific aspect, so it's probably only a matter of time to have something built-in.

Due to API changes since 3.6.0, it's not certain I will be able to update to a new version but I will try to keep this option open if you think it will be soon.

since not every component will be on every entity

Upstream remove checks if the component exists before removing it and doesn't assert. It also exists a range version for it.

i.e. moving the contents of the bundle to a pendingDeletion list and draining some smaller number of entities from that every frame.

Yeah, this is yet another option actually. What does a bundle contain?

Due to API changes since 3.6.0, it's not certain I will be able to update to a new version but I will try to keep this option open if you think it will be soon.

Oh, it should be very easy anyway. As for the schedule, it's one of the things I've in the pipeline for work, so whether or not it's soon depends only on your definition of soon. 🙂

What does a bundle contain?

A bundle is basically just a std::vector<entt::entity>, there is no other "metadata" attached to it. It is just used to group logically related entities that are created and destroyed together, for example the entities that make up Level 1 would be one bundle, Level 2 is another bundle, Level 3 is another, etc. As you progress into Level 2, you no longer need Level 1, so I want to destroy all of its entities. This is done "seamlessly" (i.e. there's no load screen or anything) which is why it is important that it doesn't take too long.

I see. Have you thought of using different registries for different levels, so as to discard one as a whole when needed?
Anyway, let me know if you want to investigate further one of the possible solutions or if you'll just wait me to push upstream the required changes to have something built-in. 🙂
In both cases, please, don't close the issue, so that we can track all progresses here.

I made a quick and dirty test: 100k entities with 1k components each. Deleting them with an optimized path takes ~30% of the time if compared to the current implementation. That is, less than half of the time.
I'm trying to figure out how to implement it properly but it should be available upstream (and fully documented) soon.

Branch wip contains some general purpose optimizations for the destroy function that also work for the single entity version.
Moreover, it offers that non-EnTT iterators optimization for the range-destroy. It would be great if you could give it a try and let me know.


Split com.google.cloud.trace:sink into sink + consumer

Consumer-API (exporter, reporter):

TraceConsumer interface
TraceConsumer implementations
Minimal dependencies (almost nothing - proto-google-cloud-trace-v1)

Stackdriver-Consumer (depends on google-cloud-java + consumer-api)

gRPC/HTTP implementations of these.

Sink will have the sinkv1 + producers.

@saturnism


[Migrated] Passing non JSON serializable object to task throws cryptic error

Originally from: https://github.com/Miserlou/Zappa/issues/1914 by stan-sack
Passing non JSON serializable object to task throws cryptic error and doesnt throw error when running locally.
Context
I've recently noticed this when passing a Django model instance as a param to a task. The task ran fine when I was running the code locally but it failed when I deployed to lambda.
Expected Behavior
I expected the task to run.
Actual Behavior
My code threw: Object of type '<type>' is not JSON serializable.
Possible Fix
It would be nice if this was caught straight away when running locally. Maybe we can add an assertion in the decorator?
Steps to Reproduce

Create a task using the @task decorator which has a non JSON serializable parameter
Deploy to lambda
Run some code that triggers the task

Your Environment
python 3.6
lambda-packages 0.20.0
zappa 0.48.2

duplicate
https://github.com/zappa/Zappa/issues/704
closing


The project's README

Create the project's README with the neccesary info

Adding information for what we have worked on so far for the README of the Project:

The Rumble Lol Plugin project
 Insert content here > Short description of your project.

Change according to the actions added to the project
///

///
> Please consider that the workflows were not yet added to the project and only the LICENSE.md file has been added
📝 Table of Contents

About
Features
Getting Started
Usage
Contributing
License

About
Provide a brief introduction to your project. What does it do? Why is it useful?
Features
Highlight the key features of the project.

Feature 1
Feature 2
...

Getting Started
Instructions on how to get the project up and running. Include prerequisites, installation steps, and any initial configuration needed.
# Example command for installation or setup

Usage
Example code
import rumble_plugin
plugin = rumble_plugin.Plugin()
plugin.activate()

Adding information gathered for the CONTRIBUTING.md file (please consider that this has not yet been added to the project due to the documentation links missing to be added to it):
Contributing
Contributing to CONTRIBUTING.md
First off, thanks for taking the time to contribute!
All types of contributions are encouraged and valued. See the Table of Contents for different ways to help and details about how this project handles them. Please make sure to read the relevant section before making your contribution. It will make it a lot easier for us maintainers and smooth out the experience for all involved. The community looks forward to your contributions.

And if you like the project, but just don't have time to contribute, that's fine. There are other easy ways to support the project and show your appreciation, which we would also be very happy about:

Star the project
Tweet about it
Refer this project in your project's readme
Mention the project at local meetups and tell your friends/colleagues

Table of Contents

Code of Conduct
I Have a Question
I Want To Contribute
Reporting Bugs
Suggesting Enhancements
Your First Code Contribution
Improving The Documentation
Styleguides
Commit Messages
Join The Project Team

Code of Conduct
This project and everyone participating in it is governed by the
CONTRIBUTING.md Code of Conduct.
By participating, you are expected to uphold this code. Please report unacceptable behavior
to <>.
I Have a Question

If you want to ask a question, we assume that you have read the available Documentation.

Before you ask a question, it is best to search for existing Issues that might help you. In case you have found a suitable issue and still need clarification, you can write your question in this issue. It is also advisable to search the internet for answers first.
If you then still feel the need to ask a question and need clarification, we recommend the following:

Open an Issue.
Provide as much context as you can about what you're running into.
Provide project and platform versions (nodejs, npm, etc), depending on what seems relevant.

We will then take care of the issue as soon as possible.
I Want To Contribute

Legal Notice
When contributing to this project, you must agree that you have authored 100% of the content, that you have the necessary rights to the content and that the content you contribute may be provided under the project license.

Reporting Bugs
Before Submitting a Bug Report
A good bug report shouldn't leave others needing to chase you up for more information. Therefore, we ask you to investigate carefully, collect information and describe the issue in detail in your report. Please complete the following steps in advance to help us fix any potential bug as fast as possible.

Make sure that you are using the latest version.
Determine if your bug is really a bug and not an error on your side e.g. using incompatible environment components/versions (Make sure that you have read the documentation. If you are looking for support, you might want to check this section).
To see if other users have experienced (and potentially already solved) the same issue you are having, check if there is not already a bug report existing for your bug or error in the bug tracker.
Also make sure to search the internet (including Stack Overflow) to see if users outside of the GitHub community have discussed the issue.
Collect information about the bug:
Stack trace (Traceback)
OS, Platform and Version (Windows, Linux, macOS, x86, ARM)
Version of the interpreter, compiler, SDK, runtime environment, package manager, depending on what seems relevant.
Possibly your input and the output
Can you reliably reproduce the issue? And can you also reproduce it with older versions?

How Do I Submit a Good Bug Report?

You must never report security related issues, vulnerabilities or bugs including sensitive information to the issue tracker, or elsewhere in public. Instead sensitive bugs must be sent by email to <>.

We use GitHub issues to track bugs and errors. If you run into an issue with the project:

Open an Issue. (Since we can't be sure at this point whether it is a bug or not, we ask you not to talk about a bug yet and not to label the issue.)
Explain the behavior you would expect and the actual behavior.
Please provide as much context as possible and describe the reproduction steps that someone else can follow to recreate the issue on their own. This usually includes your code. For good bug reports you should isolate the problem and create a reduced test case.
Provide the information you collected in the previous section.

Once it's filed:

The project team will label the issue accordingly.
A team member will try to reproduce the issue with your provided steps. If there are no reproduction steps or no obvious way to reproduce the issue, the team will ask you for those steps and mark the issue as needs-repro. Bugs with the needs-repro tag will not be addressed until they are reproduced.
If the team is able to reproduce the issue, it will be marked needs-fix, as well as possibly other tags (such as critical), and the issue will be left to be implemented by someone.

Suggesting Enhancements
If you want to suggest an enhacement or new feature for the project, please open a new issue describing what you desire to improve, and, potentially, how you plan to contribute to the project.
Before Submitting an Enhancement

Make sure that you are using the latest version.
Read the documentation carefully and find out if the functionality is already covered, maybe by an individual configuration.
Perform a search to see if the enhancement has already been suggested. If it has, add a comment to the existing issue instead of opening a new one.
Find out whether your idea fits with the scope and aims of the project. It's up to you to make a strong case to convince the project's developers of the merits of this feature. Keep in mind that we want features that will be useful to the majority of our users and not just a small subset. If you're just targeting a minority of users, consider writing an add-on/plugin library.

How Do I Submit a Good Enhancement Suggestion?
Enhancement suggestions are tracked as GitHub issues.

Use a clear and descriptive title for the issue to identify the suggestion.
Provide a step-by-step description of the suggested enhancement in as many details as possible.
Describe the current behavior and explain which behavior you expected to see instead and why. At this point you can also tell which alternatives do not work for you.
You may want to include screenshots and animated GIFs which help you demonstrate the steps or point out the part which the suggestion is related to. You can use this tool to record GIFs on macOS and Windows, and this tool or this tool on Linux.
Explain why this enhancement would be useful to most CONTRIBUTING.md users. You may also want to point out the other projects that solved it better and which could serve as inspiration.

Attribution
This guide is based on the contributing.md. Make your own!


Can't build on Arch Linux

Hi @alexmercerind,
first of all thank you for your contribution!
I have a problem launching the sample package (media_kit_test).
I uploaded the log file where the errors that come out are reported.
I tried searching on the internet but I can't figure out what the problem could be.
log mediakit.txt
I installed this packages:

https://archlinux.org/packages/extra/x86_64/mpv/
https://github.com/mpv-player/mpv-build

Can you help me?
Thank you in advance!

This is not clear what version of mpv you have installed.
You say you have th empv package from arhclinux installed, so what about mpv-build?
mpv-build is a script to build mpv from git source on github. It does not give an archlinux package.
Did you install mpv with mpv-build, aka with sudo ./install in mpv-build directory?
What is the point given the mpv arhclinux package is fairly recent?
Finally, this is more help that you are requesting, than about an issue. Better use the discord room at https://discord.gg/h7qf2R9n57

And I have no problem building and running the media_kit_test app on archlinux, with flutter 3.10.1 and mpv-1:0.35.1-6

It's entirely an issue on your development machine. Something I can't help with (& I'm not obliged) either.
As mentioned by @ solsticedhiver, they are able to build & run the project just fine.
I can't help or correct things which aren't in my hand. It's your installation of GNU/Linux; you are responsible.


fix disruptions.md typo

Peployment -> Deployment
/assign @xichengliudui

@imlcl make sure your commit is linked with you GitHub username

I signed it


Custom object merging

I extended your library with ability to custom merge objects, if necessary.
Issue #81

This feels like feature creep to me - if someone needs custom object merging logic, at that point why not just use is-mergeable-object and make your own simpler version of this library?

I'm going to close this for now, but if you think there's some specific behavior that really should be overridable, feel free to open an issue to make the case.

For now im using my own fork, so its ok :)


Traefik: Update to match current behavior for custom configs

Changes in traefik.yaml will be overwritten. See @kamilgregorczyk's
comment:
https://github.com/rancher/k3s/issues/1254#issuecomment-573331185
Signed-off-by: Joakim Roubert<EMAIL_ADDRESS>

Thanks for the contribution @joakimr-axis


Upgrade to Zinc 1.3.0-M6

ScalaInstance#libraryJar was deprecated in favor of
ScalaInstance#libraryJars in sbt/zinc#677, update the code accordingly
which should hopefully fix #4705.

[info] [info] Loading project definition from /tmp/sbt_f49ab8cf/project
[info] [info] Compiling 1 Scala source to /tmp/sbt_f49ab8cf/project/target/scala-2.12/sbt-1.0/classes ...
[info] [info] Done compiling.
[error] /tmp/sbt_f49ab8cf/build.sbt:18: error: No Append.Values[sbt.Keys.Classpath, Array[java.io.File]] found, so Array[java.io.File] cannot be appended to sbt.Keys.Classpath
[error]     unmanagedClasspath in Compile ++= scalaInstance.map(_.libraryJars).value,
[error]                                   ^


Fix IPsec for IPv6 overlays

When using IPv6, the IPsec configuration (ipsec.conf) generated by
ovs-monitor-ipsec for strongSwan is currently not correct. A patch has
been submitted upstream, but until it is accepted and merged, we apply a
temporary version of the patch.
This was tested for a VXLAN overlay in an IPv6-only cluster.
Fixes #3151
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

Codecov Report

Merging #3155 (aa018fa) into main (ebeb2d4) will decrease coverage by 20.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #3155       +/-   ##
===========================================
- Coverage   60.74%   40.35%   -20.40%
===========================================
  Files         295      167      -128
  Lines       24907    20879     -4028
===========================================
- Hits        15130     8425     -6705
- Misses       8118    11631     +3513
+ Partials     1659      823      -836

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/util/runtime/runtime.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/agent/controller/networkpolicy/reject.go
0.00% <0.00%> (-84.68%)
:arrow_down:

pkg/agent/nodeportlocal/k8s/annotations.go
0.00% <0.00%> (-83.88%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

pkg/ovs/ovsconfig/ovs_client_linux.go
0.00% <0.00%> (-76.93%)
:arrow_down:

pkg/flowaggregator/certificate.go
0.00% <0.00%> (-76.58%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-69.86%)
:arrow_down:

... and 235 more

Update on this: my OVS patch has been merged upstream and backported to the 2.15 release train (https://github.com/openvswitch/ovs/commit/e59194b606078d90b73f86092f9b76385afa73f0). I am tempted to drop this PR, wait until OVS 2.15.4 is released and then update the OVS version in Antrea to 2.15.4. I will make a decision before the Antrea v1.6 release freeze.

No OVS 2.15.4 release yet, so I'm merging this for v1.6

/test-e2e
/test-ipv6-only-e2e

/test-ipv6-only-e2e

I forgot that jenkins-ipv6-only was broken because of https://github.com/antrea-io/antrea/issues/3437. Merging this.


Cherry Pick of PR #9391

polkadot v0.9.10 with 9391 PR included

Hi @gilescope, I close this PR without merging since #9704 contains the commit. Thanks for your help with that one!


[NIFI-3038] Update cluster summary dialog layout

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Will review...

Couple quick comments...

The cluster summary dialogs for the other types of components should probably be updated as well.
With the new layout, we can probably remove some of the width restrictions (or at least increase the values).

Looks good @scottyaslan. This has been merged to master.


Email notification Camper News

The email notification that the user receives upon a new comment on one of his stories on Camper News is a little off. Here's what's wrong:

The author of the comment is not the actual author but the user itself. Basically it's saying that you've replied to your own post.
The link to the particular story is broken.
Email gets sent out to both the comment author and story author although it's specifically addressing the story author. Either change the email content or send the email to the story author only.

I'd be happy to issue a PR if you agree with the above. Point 3 needs clarification.

The desired behavior is this:

@maximization how is coming along? Fixing this is a high priority. @terakilobyte designed Camper News and is a good resource if you need help.


Add ability to select directly from S3 and GCS locations in datafusion-cli

Is your feature request related to a problem or challenge?
Once the #9133 is merged, it should be fairly straightforward to implement a similar functionality for other supported types of remote location (S3 and GCS)
We would like to run queries like:
select * from 's3://my_bucket/my_data/foo.parquet';
select * from 'gcp://<location of data in gcp>'

Describe the solution you'd like
Code can be added here to register a relevant object store for a url, which can be obtained calling get_object_store arrow-datafusion/datafusion-cli/src/exec.rs (after making it pub(crate).
get_object_store requires options parameter which can be used to store the authentication information but for select there is no option parameter so an empty HashMap can be used which means the relevant auth details will be taken from the environmental variables
Describe alternatives you've considered
No response
Additional context
No response

take


SQLite3 database export?

I think being able to export a db dump of all the tables described in README.md would be very useful.

@EtherTyper CSV output will come soon, see https://github.com/gitql/gitql/issues/82
I think that should be enough to export to other databases.
Anyway, we might accept contributions of functionality to get the output as a SQL dump.

It is now possible to query tables with SELECT * FROM <table> and dump to a CSV or JSON file.
Closing this, since this is probably as far as we want to go for export. We might add a dump command to dump full databases at some point.

@smola Cool! I'll try that out.


Project Table

The project table should have the fields that are required updated.

There are fields that are required by the US, but the project model doesn't have [Required] and the DB allows nulls.
Crop, CropType, probably a few others.


Pyupgrade: Extraneous parenthesis

A part of #827. Leaving this as a draft for visibility.

This should be ready for review. I made one difference with the original library. The command is called extraneous prints, so I only ran it on print functions; however based on the test below, I don't think the one in pyupgrade runs on prints only. Would you like me to convert it to run on any function?
def f():
    x = int(((yield 1)))

Yeah, probably ok to run on any function.

Changes in!

Oh shoot, I missed one big bug. Let me fix real quick!

Also, I will note that I spent a decent amount of time trying to use libcst_native instead of format! for this, but the solution was going to be really complicated.

Sounds good. Mark as ready whenever it's good for a review.

Its ready!


add target to doc nav links

adds target parameter to doc nav links in order to resolve #79.
Please check the code as i am no NEXTJS Dev
Thanks :)

checked the docs deployment and it seems to be working.

great, thank you!


Authentication testing environment

Hi, it is possible to set authentication ($this->getTestingUser()) with seeded user?
like this

      $user = User::find($id);
      $this->getTestingUser($user);

to test the specific role of possible access,
because the $this->getTestingUser(); is create fresh without any ralation on seeded data on other model

why would you need to create a testingUser when you already have a "real" User? Not really clear to me, haha

because of i have seeded user that has already relationship seeded also to
another models, while the on apiato tesing user is frashly created while
without any relationship on other models,
i have a unit/feature test that need to check user policy on every resources
hmmm, so nit i have only solution
so i called the protected attribute from auth testing trait then set the
user to it, then acting it as authenticated, so core will skip creating
user factory
On Thu, Jul 26, 2018, 1:45 PM Johannes Schobel<EMAIL_ADDRESS>wrote:

why would you need to create a testingUser when you already have a "real"
User? Not really clear to me, haha
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apiato/core/issues/118#issuecomment-407983356, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH3n0Nc-dpbDevQ6VSN9Ydun-6B5pNE_ks5uKVeOgaJpZM4VhAf1
.

i don't really like the approach of adding this functionality to the already existing function as this might break other code..
what about adding a new function to "inject" an existing user?

yes, that much better i think
On Thu, Jul 26, 2018, 5:57 PM Johannes Schobel<EMAIL_ADDRESS>wrote:

i don't really like the approach of adding this functionality to the
already existing function as this might break other code..
what about adding a new function to "inject" an existing user?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apiato/core/issues/118#issuecomment-408044662, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH3n0PRSBofnNBRp-ievaz6dBnBicbKzks5uKZKDgaJpZM4VhAf1
.

I'll close the existing PR

yes 😊😊😊
On Thu, Jul 26, 2018, 6:08 PM Johannes Schobel<EMAIL_ADDRESS>wrote:

I'll close the existing PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apiato/core/issues/118#issuecomment-408047558, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH3n0I3d0yQkNo3Ibh0DObBKsTo_Y4LVks5uKZUEgaJpZM4VhAf1
.

Hi can i submit PR for you idea?

Yes
Lloric Mayuga Garcia<EMAIL_ADDRESS>schrieb am Fr., 27. Juli
2018, 00:43:

Hi can i submit PR for you idea?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apiato/core/issues/118#issuecomment-408257638, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AI_pNoyqkAY6zV6yfyS9NR28txS2A-qmks5uKkYmgaJpZM4VhAf1
.


Update http-pino dependency

Dependency is still "pino-http": "^2.0.1"
Need to install updated dependencies myself to use redact. There is already a pull request for this, so I'm just trying to bring visibility to the problem.

Still not working...

Same boat.. @davidmarkclements maybe you are looking for help maintaining this project? happy to be involved

@davidmarkclements: #30

Dependency is still "pino-http": "^2.0.1"
Need to install updated dependencies myself to use redact. There is already a pull request for this, so I'm just trying to bring visibility to the problem.

@ZackKnopp the version has been bumped to latest. Can we close this issue?

@jmealo Of course :)


clusternet: 0.17.2 -> 0.17.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/clusternet/clusternet/releases.
meta.description for clusternet is: CNCF Sandbox Project for managing your Kubernetes clusters
meta.homepage for clusternet is: https://github.com/clusternet/clusternet
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.17.3 in filename of file in /nix/store/l4a0n238bz3xkqam033nrlpl5mdp89vi-clusternet-0.17.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

clusternet

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/l4a0n238bz3xkqam033nrlpl5mdp89vi-clusternet-0.17.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A clusternet https://github.com/r-ryantm/nixpkgs/archive/0cfcd3e1c411c968b901604ded674d8ad42e0a05.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/0cfcd3e1c411c968b901604ded674d8ad42e0a05#clusternet

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l4a0n238bz3xkqam033nrlpl5mdp89vi-clusternet-0.17.3
ls -la /nix/store/l4a0n238bz3xkqam033nrlpl5mdp89vi-clusternet-0.17.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

clusternet

Maintainer pings
cc @genga898 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


I cannot change the Modal description for APP_TRACKING_TRANSPARENCY

Bug report
 I cannot change the Modal description for APP_TRACKING_TRANSPARENCY

Summary

Environment info

react-native info output:
System:
    OS: macOS 11.2.3
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 411.57 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.9.0 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.7 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.10.1 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
    Android SDK:
      API Levels: 22, 23, 25, 26, 27, 28, 29, 30
      Build Tools: 23.0.1, 25.0.1, 25.0.2, 26.0.2, 27.0.1, 27.0.3, 28.0.0, 28.0.0, 28.0.3, 29.0.2
      System Images: android-26 | Google APIs Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>77832
    Xcode: 12.5/12E262 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_282 - /usr/local/Cellar/jenv/shims/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: ^0.63.2 => 0.63.2
  npmGlobalPackages:
    *react-native*: Not Found

Library version<EMAIL_ADDRESS>Steps to reproduce

Try this code to open ATT modal with customised descriptions
await request(
        PERMISSIONS.IOS.APP_TRACKING_TRANSPARENCY,
        {
          title: "my title",
          message: "my message",
          buttonPositive: "OK"
        }
      );

Describe what you expected to happen:

The modal description should be customisable.

It's not something Apple allows in it's API. There is nothing this module can do
You can (and should) check the source of libraries you use when posting feature requests - frequently it answers the question, or it will with just one more step.
Specifically here we ask iOS to do it's thing, no options:
https://github.com/zoontek/react-native-permissions/blob/540af291422768bc043ebab0a5c5c91aef9f9020/ios/AppTrackingTransparency/RNPermissionHandlerAppTrackingTransparency.m#L41
Well, are there options we are just not using?
https://duckduckgo.com/?q=requestTrackingAuthorizationWithCompletionHandler
https://developer.apple.com/documentation/apptrackingtransparency/attrackingmanager/3547037-requesttrackingauthorizationwith
Nope!
But it looks like you might be able to change the string in your plist based on that doc.
https://developer.apple.com/documentation/bundleresources/information_property_list/nsusertrackingusagedescription

@mikehardy  Thank you for your kind reply. I am trying to figure out how I can put edit description on info.plist with localization

stackoverflow has all the details, I do something similar to all the answers here https://stackoverflow.com/questions/25736700/how-to-localise-a-string-inside-the-ios-info-plist-file
mike@isabela:~/work/Kullki/ksocialscore/packages/public-app/ios (p2p-features) % find . | grep strings
./KScoreApp/en.lproj/InfoPlist.strings
./KScoreApp/es.lproj/InfoPlist.strings
mike@isabela:~/work/Kullki/ksocialscore/packages/public-app/ios (p2p-features) % grep -r InfoPlist.strings
Komp.ai.xcodeproj/project.pbxproj:		272CA8E6230B052D0064E4C3 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 272CA8EB230B052D0064E4C3 /* InfoPlist.strings */; };
Komp.ai.xcodeproj/project.pbxproj:		272CA8E7230B052D0064E4C3 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 272CA8EB230B052D0064E4C3 /* InfoPlist.strings */; };
Komp.ai.xcodeproj/project.pbxproj:		272CA8E8230B052D0064E4C3 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 272CA8EB230B052D0064E4C3 /* InfoPlist.strings */; };
Komp.ai.xcodeproj/project.pbxproj:		272CA8E9230B052D0064E4C3 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 272CA8EB230B052D0064E4C3 /* InfoPlist.strings */; };
Komp.ai.xcodeproj/project.pbxproj:		272CA8EC230B05350064E4C3 /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = es; path = es.lproj/InfoPlist.strings; sourceTree = "<group>"; };
Komp.ai.xcodeproj/project.pbxproj:		27F5643C238EDE0200124B7B /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = "<group>"; };
Komp.ai.xcodeproj/project.pbxproj:				272CA8EB230B052D0064E4C3 /* InfoPlist.strings */,
Komp.ai.xcodeproj/project.pbxproj:				272CA8E9230B052D0064E4C3 /* InfoPlist.strings in Resources */,
Komp.ai.xcodeproj/project.pbxproj:				272CA8E6230B052D0064E4C3 /* InfoPlist.strings in Resources */,
Komp.ai.xcodeproj/project.pbxproj:				272CA8E7230B052D0064E4C3 /* InfoPlist.strings in Resources */,
Komp.ai.xcodeproj/project.pbxproj:				272CA8E8230B052D0064E4C3 /* InfoPlist.strings in Resources */,
Komp.ai.xcodeproj/project.pbxproj:		272CA8EB230B052D0064E4C3 /* InfoPlist.strings */ = {

chunk of Info.plist
    <key>NSCalendarsUsageDescription</key>
    <string>Placeholder</string>
    <key>NSCameraUsageDescription</key>
    <string>Placeholder</string>
    <key>NSContactsUsageDescription</key>
    <string>Placeholder</string>
    <key>NSLocationAlwaysAndWhenInUseUsageDescription</key>
    <string>Placeholder</string>
    <key>NSLocationAlwaysUsageDescription</key>
    <string>Placeholder</string>
    <key>NSLocationWhenInUseUsageDescription</key>
    <string>Placeholder</string>
    <key>NSMotionUsageDescription</key>
    <string>Placeholder</string>
    <key>NSRemindersUsageDescription</key>
    <string>Placeholder</string>

@mikehardy is right. Rationale options are only for Android. For iOS, use NSUserTrackingUsageDescription.


Stuck at Selected Security Scheme

When using wlvncc to connect to a VNC server, I see the following output in Alacritty:
Using EGL for rendering...
20/12/2022 19:04:21 VNC server supports protocol version 3.8 (viewer 3.8)
20/12/2022 19:04:21 We have 1 security types to read
20/12/2022 19:04:21 0) Received security type 2
20/12/2022 19:04:21 Selecting security type 2 (0/1 in the list)
20/12/2022 19:04:21 Selected Security Scheme 2

After that, it just hangs; and I have to go into a different sway workspace to kill it. I would not be surprised if there are missing dependencies as I have a fairly minimal Arch Linux setup, but I did make sure to install all the runtime dependencies mentioned here. Do you have any insight on what the problem may be?

Hi!
I have exactly same problem as @zacknewman.
I've bisected the problem and the problematic commit is:
232bcad Remove vncrec suppport
When reverting this commit on top of master (and resolving one conflict) then it works as expected:
Instead of stucking, it is asking me for a password and connecting afterwards.
Additional info:
Server "unknown (LibVNCServer 0.9.13)"
Steps to reproduce: install eg DroidVNC-NG on your android phone and try to connect to it...


Added initial implementation

Jon asked me to rebase my changes, when I did github closed the last PR (https://github.com/appc/acbuild/pull/11) and it won't let me reopen it, so here's a new PR with the rebased changes.
The main change since the last round of reviews is that acirenderer is now being used to render the ACIs.

A couple of high-level comments:

how do you intend to handle concurrent invocations of acbuild? (it almost certainly makes zero  sense as a use case, but we need to at least block it from breaking things)
re: package naming/organisation - we don't have a great track record of consistency in this area across CoreOS projects (I think because we've never really settled on something we're quite happy with) in terms of where we put commands, libs, etc. I would probably rather just s/libacb/lib for now - the import path means it's still unambiguous and it's what we do in docker2aci.

Re concurrent invocations:
Concurrent invocations in different working directories will be fine, but I assume you mean concurrent invocations in the same working directory. To prevent this being an issue, acbuild could get a lock on a file in .acbuild.tmp before doing any operation, and release it when done.
Re package reorg:
Will do.

Concurrent invocations in different working directories will be fine, but I assume you mean concurrent invocations in the same working directory. To prevent this being an issue, acbuild could get a lock on a file in .acbuild.tmp before doing any operation, and release it when done.

Right, that is what I mean. We can address that in a follow up - I would like to get this landed

Please move /libacb/* --> /*, no need for the extra level.
Other than that, LGTM, let's get this merged and we can iterate from there. Awesome work!

boom!
On Tue, Oct 6, 2015 at 4:55 PM, Derek Gonyeo<EMAIL_ADDRESS>wrote:

Merged #12 https://github.com/appc/acbuild/pull/12.
—
Reply to this email directly or view it on GitHub
https://github.com/appc/acbuild/pull/12#event-428594224.

Huzzah! :+1:

\o/


1638 create a simulated run engine for unit testing

Description
Provides a new class called RunEngineSimulator added to the bluesky.simulators module that assists with testing bluesky experiment plans by invoking the plan generator function and generating the sequence of 'Msg' instances that can then be asserted.
Motivation and Context
bluesky experiment plans can be quite complex and interact with significant amounts of hardware which must normally all be mocked. opyhd allows for simulated devices but often these may have significant internal complexity that is less easily simulated. In addition there may be callbacks that may need to be invoked and it may be desirable to be able to control the content of the callback documents in testing situations.
Being able to test at the message protocol level has the many advantages including:

Many interactions with hardware that are not of interest do not have to be mocked since most messages do not yield a return value.
The sequence of operations is easy to verify since the generated message stream is sequential and can be asserted
Only those callbacks which are of interest need to be triggered as it's possible to fire them selectively at the individual event level
Operations such as wait and sleep that don't directly interact with hardware but are necessary for correct functioning can be tested.
Tests at the message protocol level may be more robust than tests at the unit level which might instead directly mock and verify invocations of bluesky.plan_stubs methods, especially since the order of messages is insensitive to refactoring whereas using patch to intercept library calls often breaks when code is refactored

See also discussion in #1638
How Has This Been Tested?
See additional tests in test_simulators. This code has largely already been in use inhyperion within our unit testing framework, and this change effectively moves this class into bluesky.
The changes made between hyperion and bluesky consist of additional documentation of the methods and also some minor changes to method signatures in order to make them easier to use. In addition, as in hyperion this code was effectively part of the unit test fixtures, it was not itself tested directly and now it has some tests.
It would be good to have some additional feedback, on whether the documentation needs further improvement, or additional tests. I am conscious that as this is now in bluesky it will slightly increase the effort to make changes if in hyperion we want further changes or fixes to this infrastructure. Also in hyperion the callback facility isn't currently in use, as the tests which used it were subsequently refactored out.
Additionally it would be good to know if there are additional features that it needs to be useful to others as in hyperion I think we are only using a subset of all the RunEngine features. For example I don't think we make any use yet of input, or the checkpoints, pausing or rewinding. In general though I think it should be possible to add handlers for arbitrary message commands.

It looks like we will have to pin back pyepics on py3.8 ?

Possibly. I'm not sure who has the dependency on python 3.8.


[FR] - Export RawBytesHexError in Cardano.Api.SerialiseRaw

Internal/External
External.
Area
Other.
Describe the feature you'd like
Export Cardano.Api.SerialiseRaw.RawBytesHexError because it is used by deserialiseFromRawBytesHex, which is part of the public API.
Describe alternatives you've considered
Having to stringify the error and use that instead.
Additional context / screenshots
None.

https://github.com/input-output-hk/cardano-node/pull/4599

The original code has a TODO which suggests that RawBytesHexError should contain
information about the expected type.
The TODO sound reasonable but I found no easy way to do that. (No Show (AsType a)).
The PR just exports RawBytesHexError as.


Committer-queue size and questions

Hello Pascal,
to get a better understand of the committer-queue I need your knowledge.

The size should increase and decrease (as soon as documents are processed) over time. In other words, in the end of the crawling and committing process the queue should be empty and the folder as well?

Does different committer has to implement this queue cleanup on their own or is it implemented in the base class of the committer?

Best regards
Sascha

As long as you do not have multiple committers pointing to the same queue directories, then yes, when the crawler ends normally, you should have no files left and if there are folders, they should be empty.  You can control how many documents get in the queue before it is flushed (i.e. committed) via configuration.
The cleanup is implemented by the base class called AbstractFileQueueCommitter.
Does that answer?

Morning Pascal,
thank you this answer all of my questions.
Best regards
Sascha


Fixed Checkbox Group crashing when a Checkbox was toggled in React 16

Closes #2003

Need a regression test?

I'm just going to refactor all the tests as they clearly don't cover enough

I've updated the tests in this PR


[KYUUBI #2789] Kyuubi Spark TPC-H Connector - Add tiny scale

Why are the changes needed?

fix #2789
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Master branch recovered, please rebase.

cc @pan3793

Codecov Report

Merging #2791 (5f05691) into master (80d45e4) will increase coverage by 0.03%.
The diff coverage is 61.81%.

@@             Coverage Diff              @@
##             master    #2791      +/-   ##
============================================
+ Coverage     62.76%   62.79%   +0.03%
+ Complexity      201      199       -2
============================================
  Files           471      472       +1
  Lines         21276    21302      +26
  Branches       2833     2835       +2
============================================
+ Hits          13353    13377      +24
  Misses         6647     6647
- Partials       1276     1278       +2

Impacted Files
Coverage Δ

...ubi/spark/connector/tpch/TPCHStatisticsUtils.scala
41.17% <10.00%> (-1.25%)
:arrow_down:

...apache/kyuubi/spark/connector/tpch/TPCHTable.scala
48.00% <50.00%> (ø)

...he/kyuubi/spark/connector/tpch/TPCHBatchScan.scala
79.41% <75.00%> (+0.30%)
:arrow_up:

.../kyuubi/spark/connector/tpch/TPCHSchemaUtils.scala
96.00% <96.00%> (ø)

...ache/kyuubi/spark/connector/tpch/TPCHCatalog.scala
40.62% <100.00%> (-1.80%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
80.55% <0.00%> (-1.39%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
96.94% <0.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d45e4...5f05691. Read the comment docs.

Thanks, merging to master


Tile-view.json bug items are not next to each other

Category

[ ] Question
[X] Bug
[ ] Enhancement

Tile-view.json bug items are not next to each other
See picture

I'm not using icons

This is a known issue (unfortunately) when used within the list web part (https://github.com/SharePoint/sp-dev-docs/issues/3537). However, this shouldn't be an issue within the list view itself. I'm going to close this now since this is actually a bug with the web part and not the sample. However, please feel free to reopen if you disagree. Thanks!

the fix for this is in the deployment pipeline now and should be live in next couple of weeks!


test assert rewrite

ref foss4g codespint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.315%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2075

Relevant Lines:
2461

💛  - Coveralls


Feature/eg dtz

Change from WDL to DTZ scores for endgame tablebases (syzygy)

We now handle all cases, from loss to win, given it can be probed in the table base.
Implements an algorithm to check desirability of DTZ category (unconditional loss last, unconditional win first).

If DTZ category is higher than previous move, select the new category.
If DTZ category is same as previous move, compare against the previous score (depending on the category) and change the move if required.

We need to check for cursed win/loss too. Will do.

Change from WDL to DTZ scores for endgame tablebases (syzygy)

We now handle all cases, from loss to win, given it can be probed in the table base.

Implements an algorithm to check desirability of DTZ category (unconditional loss last, unconditional win first).

If DTZ category is higher than previous move, select the new category.
If DTZ category is same as previous move, compare against the previous score (depending on the category) and change the move if required.

@KYLChiu suggest adding a line here to clarify context - why we decided to change from WDL to DTZ - see here for official doc

Change from WDL to DTZ scores for endgame tablebases (syzygy)

We now handle all cases, from loss to win, given it can be probed in the table base.

Implements an algorithm to check desirability of DTZ category (unconditional loss last, unconditional win first).

If DTZ category is higher than previous move, select the new category.
If DTZ category is same as previous move, compare against the previous score (depending on the category) and change the move if required.

@KYLChiu suggest adding a line here to clarify context - why we decided to change from WDL to DTZ - see here for official doc

Not enough to check the likned issue? ;)

Change from WDL to DTZ scores for endgame tablebases (syzygy)

We now handle all cases, from loss to win, given it can be probed in the table base.

Implements an algorithm to check desirability of DTZ category (unconditional loss last, unconditional win first).

If DTZ category is higher than previous move, select the new category.
If DTZ category is same as previous move, compare against the previous score (depending on the category) and change the move if required.

@KYLChiu suggest adding a line here to clarify context - why we decided to change from WDL to DTZ - see here for official doc

Not enough to check the linked issue? ;) Anyway, done.

Please excuse my blindness, but ty for clarifying 🤓


Allow frame header to be customised and add url escape jinja filter

for anything in particular?

yep for zendesk


Sm/strictFolders-match-suffixes

What does this PR do?
make strictDirs a little less eager to resolve
a unit test based on the real registry (we should probably do more of these for type-specific things--they'd be simpler for externals to read/undersand AND we'd be checking for registry-based regressions)
What issues does this PR fix or reference?
@W-9983686@
Functionality Before
thinks  classes/foo/objects/myCls.cls is a CustomObject (objects anywhere in the path)
Functionality After
thinks  classes/foo/objects/myCls.cls is an ApexClass
<insert gif and/or summary>

works for the ApexClass example above
works for moving Tabs under tabs/objects
works for moving RemoteSiteSettings under remoteSiteSettings/objects
is able to retrieve subfolders of custom objects too


Update plotCoverage example

This updates the example for plotCoverage --outRawCounts to use the "more likely to be unique" header from version 2.6.

Great 🎉 No version number...? ;)

ps. It would be really nice to use this pattern as the default in MultiQC, but write in the module-specific docs file that it changed in deepTools 2.6 with an example custom search pattern for users of older versions (eg. from http://multiqc.info/docs/#module-search-patterns)


Make web interface optional and port configurable

I'm not super happy with "web" as an option name but I couldn't come up with anything better.

If you are not happy with web, how about http?

That's better, updated.


wasm

What do you think about shipping wasm version? Will be useful for Node.js and browsers users?

I second this as it would allow to support both NodeJS replacing the current node bindings as well as Deno.

Previously, using esbuild required using C-based FFI and was difficult (if not impossible) to try and build towards other targets, like WASM.
In the latest version 0.9.0, esbuild has been replaced with minify-js, a JS minifier I wrote from scratch fully in Rust, so now it should be able to target any platform that Rust supports. As such, there are now WASM and Deno variants available 🎉
If you try out either, let me know if it works on your end.


fix(backend): fix reading stderr output in build script

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#516
#515  👈
#514
#513
#512
#507
#506
#505
#504
#503
#484
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


DOC Add jupyterbook project site page

Description

xref #362

This PR creates a webpage using jupyterbook and deploys via Github pages.
Some notes:
Although jb can autogenerate a ToC, this had to be manually created because it does not traverse the directories in a way that generates chapters in a usable state.
Generating docs seems to be pinned to python 3.11 for now. There's dependencies on 3.12 for the default runners that requires more work.
Only files under _build is used to publish pages. The api reference pages are build built but not showing up under the ToC [WIP].

Tests and Documentation

Updated all references to existing notebooks. The goal is to merge this in and keep iterating on it until we have a GitHub pipeline in place that publishes it.