fixes dependency check for Redis instrumentation

Overview
When attempting to detect Redis, an error is raised and logged:
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] INFO : Environment: development
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] INFO : No known dispatcher detected.
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] INFO : Application: Performance Test (development)
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] WARN : Agent configured not to send data in this environment.
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] DEBUG : New Relic Ruby Agent 6.13.1 Initialized: pid = 37897
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] DEBUG : NewRelic::Agent.config[:disable_redis] == false => true
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] ERROR : Error while detecting redis_instrumentation:
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] ERROR : NameError: uninitialized constant Redis::VERSION
[2020-10-02 14:10:49 -0400 C02ZH0B1LVDT (37897)] DEBUG : Debugging backtrace:
.../lib/new_relic/agent/datastores/redis.rb:92:in `is_supported_version?'
  .../lib/new_relic/agent/instrumentation/redis.rb:53:in `block (2 levels) in <top (required)>'
  .../lib/new_relic/dependency_detection.rb:88:in `block in check_dependencies'
  .../lib/new_relic/dependency_detection.rb:86:in `all?'
  .../lib/new_relic/dependency_detection.rb:86:in `check_dependencies'
  .../lib/new_relic/dependency_detection.rb:67:in `dependencies_satisfied?'
  .../lib/new_relic/dependency_detection.rb:28:in `block in detect!'
  .../lib/new_relic/dependency_detection.rb:27:in `each'
  .../lib/new_relic/dependency_detection.rb:27:in `detect!'
  .../lib/new_relic/control/instrumentation.rb:65:in `_install_instrumentation'
  .../lib/new_relic/control/instrumentation.rb:48:in `install_instrumentation'
  .../lib/new_relic/control/instance_methods.rb:76:in `init_plugin'
  .../lib/new_relic/agent.rb:356:in `manual_start'
  .../test/performance/suites/transaction_tracing.rb:82:in `setup'
  .../test/performance/lib/performance/test_case.rb:143:in `run'
  .../test/performance/lib/performance/runner.rb:161:in `run_test_inline'
  .../test/performance/lib/performance/runner.rb:172:in `block in run_test_case'
  .../test/performance/lib/performance/runner.rb:170:in `map'
  .../test/performance/lib/performance/runner.rb:170:in `run_test_case'
  .../test/performance/lib/performance/runner.rb:194:in `block in run_all_test_cases'
  .../test/performance/lib/performance/runner.rb:192:in `each'
  .../test/performance/lib/performance/runner.rb:192:in `run_all_test_cases'
  .../test/performance/lib/performance/runner.rb:204:in `run_and_report'
  .../test/performance/script/runner:131:in `<main>'

It is believed that ::Redis becomes defined in our instrumentation file even though it's not yet installed and activated, thus leading to ::Redis being present but not ::Redis::VERSION.  This fix tests for the ::Redis::VERSION as first step rather than just ::Redis

I'd like to know whether you still think this is necessary. Since the error arose when running our performance tests, and I don't know of any occurrences of this appearing in agent logs in any other context, I imagine this is an issue with the performance tests rather than a bug that needs to be fixed.

I do feel this change, albeit small, is a necessary one as it is a more correct check that will work in our performance test environment as well as in the course of detecting Redis for auto-instrumenting.  More resiliency is a good thing!


Task - Clicking Confirm task few times creates multiple tasks

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.70-0.
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to #announce room
Go to +> Assign Task> Add title> Click Next
Click on Confirm task button few times

Expected Result:
Only one Task report should be created
Actual Result:
Clicking Confirm task few times creates multiple tasks
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/c36c3274-5230-4145-8cfb-46bfb55c6d72
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - Clicking Confirm task few times creates multiple tasks
What is the root cause of that problem?
We do not throttle the button clicks here, so Create Task runs multiple times
What changes do you think we should make in order to solve the problem?
We should use the useSingleExecution() hook to carry out the create task presses

Proposal
Please re-state the problem that we are trying to solve in this issue.
Task - Clicking Confirm task few times creates multiple tasks
What is the root cause of that problem?
We do not have the useSingleExecution hook for web:
Code presumes that the issue does not occur for web devices, but we can see that it is possible to run into multiple execution issues
What changes do you think we should make in order to solve the problem?
Enable the useSingleExecution() native logic in web also.

We can just use a single file since we now need it for both web and native.

I can reproduce this. However, reproducing this relies on clicking the button to create a task intentionally repeatedly before receiving feedback, and more quickly than an actual customer is likely to ever do IMO.
I'm not sure it's likely that many/any customers will ever experience this.

I don't think this is something that should be prioritized right now. Closing.


Fixed cloudflare reference for materialize.js

Hey,
Cloned your repository but it showed js errors because the materialize.js wasn't loaded correctly. Seems the url was off. Fixed it and works without js errors now :) cheers

It is only "off" when opening the index.html file as a file (so you see a file:/// in the url).
But yeah, it is properly best to have a https url, so merged.


generaldyne pdf

physics.gaussian.general_dyne() now returns the pdf for further use (e.g. sampling)

This PR adds "pdf" as an output for the generaldyne measurement and fixes small bugs.
Just have a small question for @ziofil before approving it, I haven't found any corresponding tests in tests_gaussian for this, do we need add one?

I'm not sure what you want to test here


VS2017 solution not compatible with /permissive-

Hi Chuck,
DirectXTK won't compile with VS 2017 15.3 and WinSDK 10.0.15063.0. I'm also on Win7 SP1 in case it is needed. Saw that you already fiddled with the /permissive flag in the past...
Here is a part of the actual compiler error:
1>c:\program files (x86)\windows kits\10\include\10.0.15063.0\winrt\wrl\client.h(892): error C2187: syntax error: 'identifier' was unexpected here
1>c:\program files (x86)\windows kits\10\include\10.0.15063.0\winrt\wrl\client.h(900): error C2187: syntax error: 'identifier' was unexpected here
1>c:\program files (x86)\windows kits\10\include\10.0.15063.0\winrt\wrl\implements.h(629): error C2187: syntax error: ')' was unexpected here
....

I've got these fixes in the master branch for the next release, so you can pick them up there...

Two-phase name lookup support comes to MSVC:

If you are using the Windows RedStone2 (“Creators Update”) SDK with the /permissive- switch, you’ll need to temporarily disable two-phase name lookup by using the /Zc:twoPhase- switch until the Windows RedStone 3 (“Fall Creators Update”) SDK is available. This is because the Windows team has been working with the MSVC team to make the SDK headers work properly with two-phase name lookup. Their changes will not be available until the RedStone3 Windows SDK is released, nor will the changes for two-phase name lookup be ported back to the RedStone2 Windows SDK.

There's nothing good MSFT can make, I believe. -permissive- switch can even cause ICE, which was firstly detected on Windows SDK headers.

There's always been a scheduling/coordination challenge between the MSVC compiler team and the Windows SDK. It's certainly gotten better in the past few years than it had been, but both teams are also making a lot of changes more quickly than ever before. The fact that the next Windows 10 SDK will have better support for /permissive- with two-phase is all goodness.
The fact that it generates an ICE in some cases is not actually that surprising. The MSVC team relies heavily upon a large sample suite of code to validate their compiler, but because of the Windows SDK header limitations it can't use /permissive- extensively just yet. This is also why it's off by default right now too.
I make use of /permissive- in DirectXTK and my other libraries to try to improve the portability of the code. I've even tried building it with clang to flush out further issues. This does mean I'm more exposed to the areas of the MSVC compiler that are in flux, which is what happened here. I've applied fixes to the vcxproj which basically enables /Zc:twoPhase- for now until the new Fall Creators Update SDK is available.


Arrow key selection in search suggestions does not work

Describe the Issue
When trying to navigate to an item page via keyboard, it always navigates to the first option in the search suggestions.
While you can select other items with arrow keys, the highlighted selection is ignored when hitting enter and it always navigates to the first suggestion.
Expected Behavior
Hitting enter should navigate to the selected item.
To Reproduce

go to a random item page, e.g. https://tarkov.dev/item/wrench
focus search input
type r43
hit down arrow key to change selection from AS VAL Rotor 43 pistol grip & buffer tube to Rotor 43 9x19 muzzle brake-compensator
hit enter
page navigates to https://tarkov.dev/item/as-val-rotor-43-pistol-grip-buffer-tube

Client
Desktop
Browser
Firefox
Relevant Console Log Output
No response
Extra Information
No response

Thanks for reporting! You can preview the fix here: https://16273265.tarkov-dev.pages.dev/

thanks, that resolves it


DataGrid does paint properly while scrolling the horizontal scroll bar

What steps will reproduce this issue?
Scroll horizontally quickly a DataGrid view from the left to the right
Please look at the attached screen shot.
The image to the left shows the UI before the scroll, and the image to the right shows the result after scrolling right and back to the left.
It looks as if you can continue scrolling to the left, but the scroll bar won't let you.
Write problem description here
The left column header get's cut off, or even disappears completely.
Expected outcome
The left header text should appear properly
Write expected outcome here
--
Environment

MahApps.Metro <IP_ADDRESS>
Windows 7
Visual Studio 2013
.NET Framework 4.5

@EyalYasovsky You say that you use <IP_ADDRESS> Can you try use stable 1.2.4 and/or pre-release 1.3.0-ALPHA160 THX!

I set EnableRowVirtualization="True" and EnableColumnVirtualization="True", and the issue seems to be solved.
Thanks for the help,
Eyal


docs: minor typo and correctness fix

Thank you @fuxingloh I've merged and deployed your changes. Appreciate it!


Feature request: add expected end time of charging

It would be nice if it would be possible to show the expected end time of charging on the summary page of teslamate. This would be presumably after or before "Remaining Time".
Something like:
Remaining time    4h 15 min
Expected end time 16:15

Feature suggestions belong here: 💡 Ideas. I'll move it.


Dotnet Publish crashes with error 'MSB4166: Child node "##" exited prematurely. Shutting down.'

Description
Starting with release 2.319.0 we are consistently seeing the following process crash when running dotnet publish.
MSBUILD : error MSB4166: Child node "xx" exited prematurely. Shutting down. Diagnostic information may be found in files in "/tmp/MSBuildTemprunner/" and will be named MSBuild_*.failure.txt. This location can be changed by setting the MSBUILDDEBUGPATH environment variable to a different directory.
MSBUILD : error MSB4166: /tmp/MSBuildTemprunner/MSBuild_pid-3214_c9915635ac784de6a0cbd7762603f60a.failure.txt:
MSBUILD : error MSB4166: UNHANDLED EXCEPTIONS FROM PROCESS 3214:
MSBUILD : error MSB4166: =====================
MSBUILD : error MSB4166: 08/13/2024 17:39:05
MSBUILD : error MSB4166: System.ArgumentNullException: Value cannot be null. (Parameter 'value')
MSBUILD : error MSB4166:    at System.ArgumentNullException.Throw(String paramName)
MSBUILD : error MSB4166:    at System.IO.BinaryWriter.Write(String value)
MSBUILD : error MSB4166:    at Microsoft.Build.Framework.TelemetryEventArgs.WriteToStream(BinaryWriter writer)
MSBUILD : error MSB4166:    at Microsoft.Build.Shared.LogMessagePacketBase.WriteToStream(ITranslator translator)
MSBUILD : error MSB4166:    at Microsoft.Build.Shared.LogMessagePacketBase.Translate(ITranslator translator)
MSBUILD : error MSB4166:    at Microsoft.Build.BackEnd.NodeEndpointOutOfProcBase.RunReadLoop(Stream localReadPipe, Stream localWritePipe, ConcurrentQueue`1 localPacketQueue, AutoResetEvent localPacketAvailable, AutoResetEvent localTerminatePacketPump)
MSBUILD : error MSB4166: ===================
MSBUILD : error MSB4166:
MSBUILD : error MSB4166:
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[X] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Image version 2.319.0.
Is it regression?
Yes.  2.318.0 did not have this version.
Expected behavior
Successful completion of dotnet publish
Actual behavior
dotnet.exe process crash
Repro steps

Install 2.319.0 on our runners
With a dotnet 8.0 project, run dotnet publish

We're getting this exception on some of our self-hosted runners, but not all. It seems to only happen with SDK 8.0.400 but not 8.0.304; try using a global.json to explicitly use the older SDK:
{
  "sdk": {
    "version": "8.0.304"
  }
}

(That is, I suspect it's an issue in the SDK, not in https://github.com/actions/runner.)

Since this appears to be happening from telemetry, try setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to 1.

This happens in Azure Devops with self-hosted agents as well. Agent version 2.206.1 running Linux

Getting the same issue, looks like something broke today.  Github action is failing whilst building a .net 8.0 C# project....
MSBUILD : error MSB4166: Child node "2" exited prematurely. Shutting down. Diagnostic information may be found in files in "/tmp/MSBuildTemprunner/" and will be named MSBuild_*.failure.txt. This location can be changed by setting the MSBUILDDEBUGPATH environment variable to a different directory.
MSBUILD : error MSB4166: /tmp/MSBuildTemprunner/MSBuild_pid-2168_97623965aa194746ac7549b455b86573.failure.txt:
MSBUILD : error MSB4166: UNHANDLED EXCEPTIONS FROM PROCESS 2168:
MSBUILD : error MSB4166: =====================
MSBUILD : error MSB4166: 08/14/2024 07:07:10
MSBUILD : error MSB4166: System.ArgumentNullException: Value cannot be null. (Parameter 'value')
MSBUILD : error MSB4166:    at System.ArgumentNullException.Throw(String paramName)
MSBUILD : error MSB4166:    at System.IO.BinaryWriter.Write(String value)
MSBUILD : error MSB4166:    at Microsoft.Build.Framework.TelemetryEventArgs.WriteToStream(BinaryWriter writer)
MSBUILD : error MSB4166:    at Microsoft.Build.Shared.LogMessagePacketBase.WriteToStream(ITranslator translator)
MSBUILD : error MSB4166:    at Microsoft.Build.Shared.LogMessagePacketBase.Translate(ITranslator translator)
MSBUILD : error MSB4166:    at Microsoft.Build.BackEnd.NodeEndpointOutOfProcBase.RunReadLoop(Stream localReadPipe, Stream localWritePipe, ConcurrentQueue`1 localPacketQueue, AutoResetEvent localPacketAvailable, AutoResetEvent localTerminatePacketPump)
MSBUILD : error MSB4166: ===================
MSBUILD : error MSB4166:
MSBUILD : error MSB4166:
Error: Process completed with exit code 1.

Can also confirm that adding the ENV variable (DOTNET_CLI_TELEMETRY_OPTOUT: 1) to the github action fixed the issue

This is a dotnet SDK regression - we will have a 401 hotfix SDK out in the next day or so that fixes this. In the meantime the most consistent workaround is using the latest 30x SDK instead.

Duplicate issues filed:

https://github.com/dotnet/msbuild/issues/10518
https://github.com/dotnet/sdk/issues/42719
https://github.com/dotnet/sdk-container-builds/issues/587

This started happening for me as well

The 8.0.401 hotfix SDK has been released on all channels and contains a fix for this issue.

Apparently the same regression has been introduced in .NET 9 preview (9.0.100-preview.7.24407.12) which is now installed with the latest VS, because even after installing 8.0.401 whenever I'm trying to run azd deploy MyService it fails with the error above. When running azd deploy with --debug flag I can see that it appears to be using the latest available .NET version which in my case is the .NET 9 preview. The only way how I could make it work (setting DOTNET_CLI_TELEMETRY_OPTOUT to 1 did nothing) is to add in the root folder of my solution "global.json" with this content:
{
    "sdk": {
        "version": "8.0.401"
    }
}

Hi @lancelind, Could you please confirm if the issue is fixed as external team SDK have provided workarounds Like below :
try using a global.json to explicitly use the older SDK:
{
  "sdk": {
    "version": "8.0.304"
  }
}

(That is, I suspect it's an issue in the SDK, not in https://github.com/actions/runner.)
Thank you.

It resolves the issue!
Skickat från min iPhone
tors 29 aug. 2024 kl. 12:26 skrev hemanthmanga @.***>:

Hi @lancelind https://github.com/lancelind, Could you please confirm if
the issue is fixed as external team SDK have provided workarounds Like
below :
try using a global.json to explicitly use the older SDK:
{
"sdk": {
"version": "8.0.304"
}
}
(That is, I suspect it's an issue in the SDK, not in
https://github.com/actions/runner.)
Thank you.
—
Reply to this email directly, view it on GitHub
https://github.com/actions/runner-images/issues/10437#issuecomment-2317261879,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADLF5GFIVI6INTY4Q3IDADZT3ZMPAVCNFSM6AAAAABMOY3K4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGI3DCOBXHE
.
You are receiving this because you commented.Message ID:
@.***>

Hi @lancelind, Since we haven't heard back, we'll assume your issue is resolved and will close this issue, Thanks.

I'm having this issue since yesterday (not sure what changed on my machine behind the scenes) and only on some projects but not all of them. Enabling telemetry fixes the issue.
$ dotnet --info # failing project

.NET SDK:
 Version:           8.0.400
 Commit:            36fe6dda56
 Workload version:  8.0.400-manifests.57f7c351
 MSBuild version:   17.11.3+0c8610977

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22631
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.400\

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
 [aspire]
   Installation Source: SDK 8.0.400, VS 17.11.35222.181
   Manifest Version:    8.2.0/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.2.0\WorkloadManifest.json
   Install Type:        FileBased

Host:
  Version:      8.0.8
  Architecture: x64
  Commit:       08338fcaa5

.NET SDKs installed:
  6.0.425 [C:\Program Files\dotnet\sdk]
  8.0.304 [C:\Program Files\dotnet\sdk]
  8.0.400 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  C:\Users\rg1844\Development\TobiiDynavox\IdentityManager\App\global.json

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

$ dotnet --info # succeeding project

.NET SDK:
 Version:           8.0.400
 Commit:            36fe6dda56
 Workload version:  8.0.400-manifests.57f7c351
 MSBuild version:   17.11.3+0c8610977

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22631
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.400\

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
 [aspire]
   Installation Source: SDK 8.0.400, VS 17.11.35222.181
   Manifest Version:    8.2.0/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.2.0\WorkloadManifest.json
   Install Type:        FileBased

Host:
  Version:      8.0.8
  Architecture: x64
  Commit:       08338fcaa5

.NET SDKs installed:
  6.0.425 [C:\Program Files\dotnet\sdk]
  8.0.304 [C:\Program Files\dotnet\sdk]
  8.0.400 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.25 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 6.0.33 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

As you can see, the only difference is the presence of the global.json file in the broken project.
{
  "sdk": {
    "version": "8.0.200",
    "rollForward": "latestMinor"
  }
}

@hemanthmanga I still see the issue sporadically on various version of .NET 8 (I'm on latest 403 and tried to reduce to 304 - reproduced on both).


Ninja build tool

I get this error while opening a project that uses cmake and ninja
CMake Error: Error: generator : MSYS Makefiles
Does not match the generator used previously: Ninja
Either remove the CMakeCache.txt file and CMakeFiles directory or choose a different binary directory.

Does jucipp support using ninja?

Could you post a link to that project so I could test it? Never tried ninja but it should work. I take it you also use juCi++ in MSYS2?
If the project has CMakeCache.txt in the root folder (in-source-build), cmake will fail if it tries to create a out-of-source build in for instance the ./build directory. The solution then is to remove the CMakeCache.txt. You could try do the cmake commands in terminal and see if you get the same error message. In preferences you have the following options that control the build (showing MSYS2 default preferences):
    "project": {
        "default_build_path_comment": "Use <project_directory_name> to insert the project top level directory name",
        "default_build_path": "./build",
        "cmake_command": "cmake -G\"MSYS Makefiles\" -DCMAKE_INSTALL_PREFIX=C:/msys64/mingw64",
        "make_command": "cmake --build .",
        "debug_build_path_comment": "Use <project_directory_name> to insert the project top level directory name, and <default_build_path> to insert your default_build_path setting.",
        "debug_build_path": "<default_build_path>/debug"
    }

And this is equivalent to doing the following in the terminal from the project folder when opening the project for the first time:
mkdir build
cd build
cmake -G\"MSYS Makefiles\" -DCMAKE_INSTALL_PREFIX=C:/msys64/mingw64 ..

The make_command "cmake --build ." was used instead of "make" to support Ninja btw in a commit a month or two back.

My guess is that the project already has a ./build directory, and cmake -G"Ninja" .. was used to generate the build there. If you want to always use ninja instead of MSYS Makefiles though, replace MSYS Makefiles with Ninja in the cmake_command. Sadly, one has to specify a build in MSYS2, since the default build will not work. Other platforms does not have this problem.

Here's a link to the project: https://github.com/tylorr/knight-engine

My guess is that the project already has a ./build directory, and cmake -G"Ninja" .. was used to generate the build there.
That's correct

I'll try out your suggestions when I get a chance.

In general, you would not use other users build as it, for instance, contains absolute paths to the various files and executables. If you remove the build directory before opening the project/a file in juCi++, the issue should be resolved.

Saw now that it was probably your build directory already, if you want to use Ninja instead update the cmake_command in preferences and you can most likely open the project without deleting your build directory.

Changing cmake_command to use Ninja did the trick, thanks


Allow claims to be revoked from TransactionList

As a user, I may want to use TransactionList to see past supports, publishes, claims, etc. It would be convenient to have the ability to reclaim credits from this screen.

I will get to this once I figure the rest of abandon related stuff. One of them is directly related to abandoning claims(with supports and tips).

Good progress so far, but I'm sure there will be some confusion going forward. When an action is taken, the icon disappears and a new transaction is created (which is not apparent immediately).
Other areas of possible confusion:

users won't understand why they can take action in some cases but not others - i.e. a publish and then an update - the publish has no action available, but the update does.

Previously revoked/claimed items won't show an action - the only history is the resulting transaction. Maybe some indication an action was already taken?

@hackrush01 shouldn't this make publishes revokeable?

It does... Maybe you misunderstood what I was saying? But if you publish and then update, the update is now revokeable but the publish isn't (since the bid for the claim is now at a different address)

Yep, nm.

Merged


Use istio namespace for global destination rule to avoid overwriting mixer policy

This alleviate the problem described in https://github.com/istio/istio/issues/11545.
More appropriate fix would use a special namespace that no job running, but we can do that in later when we have agreement on global namespace.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: diemtvu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
dd38dc61e694c1d90b6d1f7e3a00cc7b7f5d4136
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Related to #11058

/lgtm
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: diemtvu, wenchenglu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mandarjog
If they are not already assigned, you can assign the PR to them by writing /assign @mandarjog in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Display menu depth

Indicates that there are submenus in the tasks and interfaces menu.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Custom sizing

adds docs for kuberentes component sizing

Thanks for the docs update! I'm performing some profiling this week across VMs and containers, so if you don't mind, can we sit on this for a week or so? I may have some stuff to add to make it more general than just distributed Kubernetes.

We can definitely wait on it! Thanks for letting us know.

@omawhite looks like the link i made to reference another page is broken, so we'll change that tomorrow morning, the details of the broken link are in the failed CI test.

@edwinavalos i think i fixed it, the tests passed locally on my latest commit.

@ttomsu did we want to hold off on this still? I've been pointing people to this PR instead of the website a few times now.

I've also found this PR incredibly helpful :-)
The first question many people are going to have is "This capability is great - but what values should I use for each service?" And that obviously depends on multiple factors of your environment, so I don't think we'll be able to provide that kind of guidance, other than "X, Y, and Z are the largest services, A, B, and C are medium, the rest are small"
Maybe we should include something like that in this doc.

@edwinavalos @ttomsu I took a crack at modifying the recommendations, also added a little intro sentence under the kuberentes header on the page. take a look.

@dorbin Can you take a look?

We'll do that. Thanks, guys.


Feature 264 - Dimensions: Implementing AdCloud extensions

PR to add AdCloud's extensions to support new dimension on ExperienceEvent. This is related to open issue #264.
@kstreeter  @cdegroot-adobe

I am good with this one, @cdegroot-adobe can you make one last pass on this one and then we will push.

@kstreeter - we just need to remove the experience event for now ass ti has a metric from another pending PR and I then Approve.

ExperienceEvent example removed


The log methods should be identified as methods

With the current type definitions for error, warn etc. VSCode is identifying them as properties and not methods. It works out though, but I think it would be a bit nicer if they were identified as methods.
Changing info: ILog; to info(...args: any[]);
VSCode sees info as a property when it's written as info: ILog; in the type definitions file.

VSCode sees info as a method when it's written as info(...args: any[]); in the type definitions file.

I haven't made a pull request for this change, because I don't know how to generalize the writing ILog as a method.

@mhoeger


chore: update nerdctl version

Issue #, if available:
Description of changes:
Update nerdctl version to 1.7.7
Testing done:

[x] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

No diff (dependabot merge)


Fields of some types are not exported

I tried to change the background color of a window:
ctx.style.window.background = nk.NkRgb(0,120,215)
and when building, Golang stopped with an error saying that style was not exported.
I'm not sure how you would go about this in cgogen, but I think that the underlying c structs in nuklear.h need to be extracted or modified in some way so that they are exported or capitalized.

Hi! Structs in Nuklear have too much inner state, I decided to avoid binding them, except cases when they are simple. Also sometimes it's not good for performance of tiny structs that rarely get changed.
See https://github.com/golang-ui/nuklear/blob/master/nk/etc.go I usually write setters and getters for stuff I need to change. You can contribute yours for public fields of nk_context struct.
I think both setters/getters generation can be next feature of cgogen, but that's another story.

Thanks! I will probably write a few and submit a pull request later on.

illinoisjackson did you write code about styling window? Could you give example to us?

I'm stuck here:
http://i.imgur.com/mCnbQcL.png
I think this is related right? Any hint how I could get the begin value?

Thanks.

@rand99 At this moment, all strings must be NULL-terminated, like foo\x00.
Regarding the NkListView, an "unstuck" piece of Go code would look like
func (l *ListView) Begin() int {
	return (int)(l.begin)
}

func (l *ListView) End() int {
	return (int)(l.end)
}

func (l *ListView) Count() int {
	return (int)(l.count)
}

I added it to etc.go, all other things must be done that way, until generator will be able to generate getters/setters..

Thank you for the example.
I got it "kinda" working.
		var view nk.ListView
		var alist = []string{"asdf", "asdf2", "asdf3"}
		nk.NkLayoutRowDynamic(ctx, 90, 1) {
			if nk.NkListViewBegin(ctx, &view, "test", nk.WindowBorder, 25, int32(len(alist))) > 0 {
				nk.NkLayoutRowDynamic(ctx, 25, 1)
				{
					for i := 0; i <= view.Count(); i++ {
						nk.NkLabel(ctx, alist[view.Begin()+i], nk.TextAlignLeft)
					}
				}
				nk.NkListViewEnd(&view)
			}
		}

It crashes easily and the memory is written in the list :-)
http://i.imgur.com/q2TlakL.png
I will stick with https://github.com/nelsam/gxui at the moment.
The examples work and are easy to understand although its really ugly.
I'm sure your repo will become pretty popular when there are working examples for common use-cases. 👍

It crashes easily and the memory is written in the list :-)

Like because you ignored my advice to NULL-terminate the strings and are passing them into C without termination. That's a C library either way, the safest way will always be to use native Go packages.
The reason why I personally don't stick with GXUI is because I won't commit my time and effort in frozen and unfinished projects, had some bad experience doing that in the past.

UPD: c-for-go now support safe strings (automatic NULL-termination of all strings), the bindings for Nuklear were updated, so all strings are automatically terminated now.

I didnt ignore it on purpose. i just didnt get it at 3am after 13 hours of work.
last time i looked at c++ code was 2003.
then java, php, ruby, chsarp and now go :-)
people forget things.
i understand your position on gxui.
One guy is working on it and I m just using it for software that is for me only.
everything (tree, list, btns, layouting, panels) works fine . only the text selection is a bit choppy.
the event handler are really nice.
you will attract people and contributers with the same working examples as gxui.
so your time and effort will be worth it.


Order placemenet fails even after multiple retries

[2024-11-06T09:44:50Z INFO  gateway] <IP_ADDRESS> | 200 | GET /v2/markets HTTP/1.1 | (0.203708ms)
[2024-11-06T09:44:51Z INFO  gateway] <IP_ADDRESS> | 200 | GET /v2/markets HTTP/1.1 | (0.159284ms)
[2024-11-06T09:44:52Z INFO  gateway] accepted Ws connection: <IP_ADDRESS>:35465
[2024-11-06T09:44:52Z INFO  gateway] subscribing to events for: 0
[2024-11-06T09:45:12Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (70.208040ms)
[2024-11-06T09:45:44Z INFO  gateway] <IP_ADDRESS> | 200 | GET /v2/transactionEvent/2bqPN6Jk88kC7ZnE3JRZkHcYVBkBRQk7kUq3UfkMYLkcDNBGxuGEW5PvNCZNnBuwbaDsiKZ9NsdQ6KrqbGJqcwWC?subAccountId=0 HTTP/1.1 | (223.196969ms)
[2024-11-06T09:45:47Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (550.595609ms)
[2024-11-06T09:46:19Z WARN  gateway] failed to get transaction: Error { request: Some(GetTransaction), kind: SerdeJson(Error("invalid type: null, expected struct EncodedConfirmedTransactionWithStatusMeta", line: 0, column: 0)) }, tx_error: None
[2024-11-06T09:46:19Z INFO  gateway] <IP_ADDRESS> | 404 | GET /v2/transactionEvent/4YPAB65LvSqtFp1tb3dVamDVFZjDsi9R1ZUzhMgWNjLQNV2VeJ1bzySbGPoQaccHPhRMuPoin6vjVNe1J1LdnTfW?subAccountId=0 HTTP/1.1 | (281.749459ms)
[2024-11-06T09:46:21Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (557.742885ms)
[2024-11-06T09:46:53Z WARN  gateway] failed to get transaction: Error { request: Some(GetTransaction), kind: SerdeJson(Error("invalid type: null, expected struct EncodedConfirmedTransactionWithStatusMeta", line: 0, column: 0)) }, tx_error: None
[2024-11-06T09:46:53Z INFO  gateway] <IP_ADDRESS> | 404 | GET /v2/transactionEvent/4HEfeuXhuFzh3o5PDb3ZbLE5UfREqZAFkx56DVxBSar6nr1b5PKTh4VEWgTFRuhABhJ1KHKgDoLiuGgKbokM4aKt?subAccountId=0 HTTP/1.1 | (255.769429ms)
[2024-11-06T09:46:56Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (567.745236ms)
[2024-11-06T09:47:28Z INFO  gateway] <IP_ADDRESS> | 200 | GET /v2/transactionEvent/RNLgwbt5jgmNsdbU6WxLPoAQsmawjpUVDF3F3mMV3ThcNuMYpQ5juYetW3bnXhyQa4a5xaS2PyTdNq2YJ24ituT?subAccountId=0 HTTP/1.1 | (228.263934ms)
[2024-11-06T09:47:32Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (575.731289ms)

[2024-11-06T09:48:03Z WARN  gateway] failed to get transaction: Error { request: Some(GetTransaction), kind: SerdeJson(Error("invalid type: null, expected struct EncodedConfirmedTransactionWithStatusMeta", line: 0, column: 0)) }, tx_error: None
[2024-11-06T09:48:03Z INFO  gateway] <IP_ADDRESS> | 404 | GET /v2/transactionEvent/5m2qonhcWzLMRmtCEWts2ZTKtnpCmoBfXr4jQAmkwdnVzM4C9GhsSied22nVLWU9mkPenxhkyBcjSjQGsytr42oM?subAccountId=0 HTTP/1.1 | (305.001184ms)

[2024-11-06T09:48:07Z INFO  gateway] <IP_ADDRESS> | 200 | POST /v2/orders?subAccountId=0 HTTP/1.1 | (590.738517ms)

confirming this is on latest commit/release?

from the logs it looks like the txs aren't being included in blocks by Solana validators. This can happen during busy network times mostly due to competitive tx fees.
for now I recommend your script to retry the tx if it still returns 404s after atleast 15s
or can try more aggressively with something like cancelAndPlace to ensure it doesn't place multiple orders
another option is set a higher CU price per request: https://github.com/drift-labs/gateway?tab=readme-ov-file#cu-price--limits when your script encounters more 404s
also related #67

also try starting gateway with the --skip-tx-preflight flag.

@jordy25519 every Gateway version has been doing the same since we first tried it, and we used to place orders with ridiculously high CU prices and different RPC providers too. Most order placing want a few retries, I hardly ever see orders that fly on the first attempt. What can I provide for diagnostics?

increasing chances of tx landing is a known challenge on Solana. Besides CU prices the options are basically retry the tx and sending to multiples RPC providers simultaneously, will add support for these things in next gateway update.

please see new 1.2.0 release

closing, feel free to reopen after trying suggestions and new config etc.

Thanks @jordy25519 we're trying the new release, will reopen if we face issues again!


tools/sigh devtools produces no build on my Windows machine

I followed the instructions in the README.md and installed the devtools (nice!) on my MacBook, but the same procedure on my Windows machine failed to produce the build folder.
The output of the build command looks like this (interestingly, the emoji appear as ? on my console).
Scott J. Miles@Shhh MINGW64 /e/www/projects/arcs/arcs
$ tools/sigh devtools
😌
🙋 devtools
🙅 devtools
😱

Fwiw, using the commands from sigh.js directly in a terminal (in devtools folder) produced a working extension.
../node_modules/.bin/polymer build
../node_modules/.bin/crisper --html=build/bundled/split.html --js=build/bundled/src/split.js build/bundled/src/index.html

Aside: I'd like to take a stab at converting strategy-explorer to Xen to remove this requirement and decouple us from Bower, et al.

Must be a problem with the target in sigh (maybe the paths? although it all looks correct to me).
@piotrswigon has a cl in-progress to move the strategy explorer to devtools, it might be easier to wait for that to land before converting to Xen. See #687.
As a further aside I was thinking of adding the bower steps to the build in shell, but I wonder if I should just wait for all of this to happen first (which will mean that we don't need that build step, and certainly not in shell) :)

shell/strategy-explorer will disappear soon. @sjmiles was the motivation to move it to Xen primarily for cleaning up shell from the myriad of technologies? My plan was to keep devtools as a Polymer project (partially because I had some exposure to Polymer, partially because strategy explorer already used that, partially affiliation with Chrome), do you consider this a reasonable strategy long-term?

was the motivation to move it to Xen primarily for cleaning up shell from the myriad of technologies?

Yes.
Polymer is between states (imports vs modules, bower vs npm). Would prefer to avoid Bower and Crisper, etc, but it's just a recommendation. Isolating those dependencies inside of devtools lessens the impact.

Follow up: today on my Windows machine, npm run test with start produces:
Starting up http-server, serving ./
Available on:
  http://localhost:8080
Hit CTRL-C to stop the server

><EMAIL_ADDRESS>test-sigh E:\www\projects\arcs\arcs
> tools/sigh

'tools' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>test-sigh: `tools/sigh`
npm ERR! Exit status 1

The rest of the tests run, but it always ends in failure, and I don't have the surety of the build.

That looks like an issue with how npm run test is set up and unrelated to the devtools bug (which has been fixed, we should probably keep this issue closed).


Glitch bug in CesiumJS- Fundamentals tutorial

Code for adding Cesium World Terrain and Cesium OSM Buildings in Step 2 of the flight tracker tutorial is causing app to break
Sandcastle example live site
Sandcastle example code
Browser: Chrome
Operating System: Microsoft
We suspect the the Glitch template doesn't allow the await keyword out of the box. Also that tutorial targets 1.82 which is outdated, we should update it to 1.112.

Duplicate of https://github.com/CesiumGS/cesium/issues/11650
Try the solutions in that issue until we can update the tutorial fully


Add role description for l10n-drivers in community roles document

l10n_community_roles.md needs to have a section describing how the l10n-drivers are accountable to the community in terms of their responsibilities and expectations (see this discourse comment from @MikkCZ ).

I'm struggling a bit to properly define the expectations placed upon us by the community. I have the responsibilities covered, but could use some feedback. Here's what I have:
Responsibilities

Mentor new l10n communities through the process of launching a new localized Mozilla product.
Communicate project updates and participation invitations in primary communications channels, like the dev-l10n mailing list and IRC.
Respond to reports of CPG violations within the community.
Create and guarantee a safe, collaborative space for all communities.
Work with l10n communities to increase the user base for their localizations.
Perform technical validation of contributions from the community to determine whether to ship contributions.
Create and maintain tooling that promotes a healthy and simple localization workflow for the community.
Recognize outstanding contributions made by the community.
Promote translation and localization best practices within the project.

Expectations

Promote the growth and health of each l10n community.
Represent and advocate for the needs of the l10n community to the Mozilla organization.
Respond positively to ideas for l10n improvements from the community.
Utilize open communication channels at every opportunity.

@Delphine @flodolo @peiying2 @TheoChevalier thoughts?

Not on expectations, but minor suggestion on responsibilities: user base > reach, maybe? Not sure user base would work well for an advocacy campaign, for instance.
And I think my brain still struggles to differentiate the two categories… Will try to find other examples online

Yes I admit I still have a hard time understanding the difference between "Responsibilities" and "Expectations" (and although it's been explained to me a few time). Are "Expectations" just a sort of high-level summary of the "Responsibilities", and that should encompass them all? I feel like I'll be able to answer better once I get a better understanding of these definitions :)
Other than that:

"Respond positively to ideas for l10n improvements from the community."  -> should this be more "Review and apply when possible ideas for etc."? I wonder if "respond positively" sounds like we're going to adopt just any idea that comes up, no matter what (maybe it's just because I'm not a native English speaker that I understand it this way). I feel like we should rather say something along the lines that we'll always respond, then review/analyze, and finally apply when possible. Thoughts?

@Theo
Reach is definitely better. I'll go with that one. Thanks!
@Delphine
Here's an example:
Responsibility:
On Wed, Jun 20, 2018 at 12:52 PM, Delphine Lebédel<EMAIL_ADDRESS>
wrote:

Yes I admit I still have a hard time understanding the difference between
"Responsibilities" and "Expectations" (and although it's been explained to
me a few time). Are "Expectations" just a sort of high-level summary of the
"Responsibilities", and that should encompass them all? I feel like I'll be
able to answer better once I get a better understanding of these
definitions :)
Other than that:

"Respond positively to ideas for l10n improvements from the
community." -> should this be more "Review and apply when possible ideas
for etc."? I wonder if "respond positively" sounds like we're going to
adopt just any idea that comes up, no matter what (maybe it's just because
I'm not a native English speaker that I understand it this way). I feel
like we should rather say something along the lines that we'll always
respond, then review/analyze, and finally apply when possible. Thoughts?

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-l10n/localizer-documentation/issues/125#issuecomment-398858205,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1yZFU_RPHS7bt5wUtjEqShEeDlz_mSks5t-poJgaJpZM4Uveyg
.

Mentor new l10n communities through the process of launching a new localized Mozilla product.

I think this could be more generic (new products for all, new locales): "Mentor new and existing l10n communities through the process of launching localized Mozilla products."

Promote translation and localization best practices within the project.

project -> organization?

Respond positively to ideas for l10n improvements from the community.

Evaluate openly?
Possible ideas for responsibilities, not sure how to word them:

Making sure products are properly localizable (strings review, open to all locales, etc.)
Avoid overload/burnout by balancing requests, and identifying alternative solutions to localization products. Thinking mostly about using MT, agencies, asking to move deadlines, etc.

Possible ideas for responsibilities, not sure how to word them:

You meant expectations? If I understood the definition correctly, this seem to be more “how“ than “what”

Making sure products are properly localizable (strings review, open to all locales, etc.)
Avoid overload/burnout by balancing requests, and identifying alternative solutions to localization products. Thinking mostly about using MT, agencies, asking to move deadlines, etc.

I think we should make this project oriented instead of product oriented.
Also open to all locales → open to as many locales as possible? (since this usually depends on resource, platform availability, strategic decisions on a project, etc)
I’m also wondering if this wouldn’t be implicit in the “promote the health of the community” and “advocate for the needs of the l10n community” points

You meant expectations? If I understood the definition correctly, this seem to be more “how“ than “what”

I think you're right. The distinction is still really confused in my head 🦄
There's definitely overlap between some of the points (e.g., isn't the CPG part covered by the next point about "safe community"?), but some are worth being called out explicitly.

Ok, new draft incorporating your feedback. Thoughts?
Responsibilities

Mentor new and existing l10n communities through the process of launching localized Mozilla projects.
Communicate project updates and participation invitations in primary communications channels, like the dev-l10n mailing list and IRC.
Respond to reports of CPG violations within the community.
Work with l10n communities to increase the reach of their localizations.
Perform technical validation of contributions from the community to determine whether to ship contributions.
Create and maintain tooling that promotes a healthy and simple localization workflow for the community.
Recognize outstanding contributions made by the community.
Promote translation and localization best practices within Mozilla.

Expectations

Promote the open, collaborative processes within each l10n community.
Represent and advocate for the needs of the l10n community to the Mozilla organization.
Evaluate ideas for l10n improvements from the community openly.
Utilize open communication channels at every opportunity.
Prevent localization from being an obligation by balancing requests and resources to respect community time and availability.

Thoughts? I would also be interested in input from @MikkCZ to see if this is meeting his own expectations.

Looks good to me 👍

Same here, thanks!

This looks really good to me, thanks Jeff!
I don't know if this is diving into too much details, but I was also thinking under "Responsibilities":

Give early feedback on code and strings to developers - and fix when necessary - to prevent localization issues
Act as a point of contact for questions from localizers regarding localizable content
Advocate for more culturally and linguistically friendly features to Product Management (maybe this is already represented by the "Represent and advocate for the needs of the l10n community to the Mozilla organization." under Expectations?)

Yes, I second everyone, very well put together.
Delphine's comments, though detailed, but very concrete for people outside
our team to understand, especially the 2nd and 3rd bullet.
On Thu, Jun 21, 2018 at 10:31 AM, Delphine Lebédel<EMAIL_ADDRESS>
wrote:

This looks really good to me, thanks Jeff!
I don't know if this is diving into too much details, but I was also
thinking under "Responsibilities":

Give early feedback on code and strings to developers - and fix when
necessary - to prevent localization issues
Act as a point of contact for questions from localizers regarding
localizable content
Advocate for more culturally and linguistically friendly features to
Product Management (maybe this is already represented by the "Represent and
advocate for the needs of the l10n community to the Mozilla organization."
under Expectations?)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-l10n/localizer-documentation/issues/125#issuecomment-399183175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFzumTYgrxvwo2s7GLjEXskHu4NyffRBks5t-9hagaJpZM4Uveyg
.

Advocate for more culturally and linguistically friendly features to Product Management (maybe this is already represented by the "Represent and advocate for the needs of the l10n community to the Mozilla organization." under Expectations?)

I would say it’s implied, but if we’re adding it I would replace Product Management with something that works for all PMs

I was wondering if there should be something about facilitating connections to Mozilla outside of l10n (e.g. getting in touch with people working on specific projects, find who to talk to for specific questions, etc.).

Thoughts? I would also be interested in input from @MikkCZ to see if this is meeting his own expectations.

Thanks for sharing the proposal, +1 from me. I think it's time to put it in the docs and ask for feedback from a broader forum of all localizers.

"Respond to reports of CPG violations within the community." <- @emmairwin I'm wondering if this should be something like "respond to or escalate reports of CPG violations within the community as appropriate".

L10n-drivers is the name of the Mozilla staff on the l10n team.
El lun., 25 de jun. de 2018 13:23, LucyeoH<EMAIL_ADDRESS>escribió:

"Respond to reports of CPG violations within the community." <- @emmairwin
https://github.com/emmairwin I'm wondering if this should be something
like "respond to or escalate reports of CPG violations within the community
as appropriate".

I like that wording. It's what I was going for, but yours is better :-)

Sorry I've lost track of some elements of this are we also going to have
some messaging around how someone can become an l10n driver?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-l10n/localizer-documentation/issues/125#issuecomment-400065368,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB1yZP_jMVS4hwIhmFx-wCwbco68CZeUks5uATjCgaJpZM4Uveyg
.

It might be helpful to know about this doc we are creating (which will be
updated when we have a new system)
https://github.com/mozilla/diversity/blob/master/Draft- REPORTING.MD
On Mon, Jun 25, 2018 at 12:59 PM, gueroJeff<EMAIL_ADDRESS>wrote:

L10n-drivers is the name of the Mozilla staff on the l10n team.
El lun., 25 de jun. de 2018 13:23, LucyeoH<EMAIL_ADDRESS>escribió:

"Respond to reports of CPG violations within the community." <-
@emmairwin
https://github.com/emmairwin I'm wondering if this should be something
like "respond to or escalate reports of CPG violations within the
community
as appropriate".

I like that wording. It's what I was going for, but yours is better :-)

Sorry I've lost track of some elements of this are we also going to have
some messaging around how someone can become an l10n driver?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/mozilla-l10n/localizer-documentation/
issues/125#issuecomment-400065368>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB1yZP_jMVS4hwIhmFx-
wCwbco68CZeUks5uATjCgaJpZM4Uveyg>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla-l10n/localizer-documentation/issues/125#issuecomment-400076236,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADsynxFnPoJS1fjXWZAKlFHTMqM7YN_ks5uAUE7gaJpZM4Uveyg
.

--
-- Emma Irwin

Updated the doc with feedback from this issue and will close it now. If any additional changes need to be made, please file a new issue.


Add Support for Esri Leaflet Renderers

Are there plans to support Feature Layers utilizing the symbology they are published with?
This is taken care of the Esri Leaflet Renderers plugin in non-React environments.

I've never played with that plugin before, but now that I look at it, it seems that as long as the renderers plugin is included in your page /code before any esri-leaflet (or react-esri-leaflet) components get added, the renderers plugin just handles the rest for you.  Have you tried this yet?  It seems like it should just work out-of-the-box  I'm a bit busy today, but if you can test it and let me know what the results are, that would help figure out if we actually need to adjust to code to support this.  Otherwise It may take me some time to test it out myself.

It appears that simply adding Esri-Leaflet-Renderers throws an error.

How are you adding it?  <script> tag in the HTML header?  import 'esri-leaflet-renderers'?  Just adding it in shouldn't cause that kind of error.  It may mean you're imports of leaflet, esri-lealfet, and esri-leaflet-renderers are not cooperating with each other.  Can I see some code?

Without seeing some code / attempts to make this work, I'm going to close this issue for the time being.

I am adding it as a

Interesting.  Here's the issue:
This is ultimately an inconsistency between including libraries through the html header, vs importing them as a module in a node project.  When including libraries like leaflet from the html header, they get attached to the global window.  So if you follow leaflet's instructions and include it as a script tag, you end up with window.L, which can then be used in any module.  Similarly, including esri-leaflet in the html header as a script tag attaches esri to window.L, and you end up with window.L.esri.  And one step further, including esri-leaflet-renderers from the html header will try to attach itself to window.L.esri.  But in your code example, you only ever included the last of these - esri-leaflet-renderer can't find L or L.esri to latch on to, hence the error.
Most react projects are module-based.  Your project, and this library, are no different. react-esri-leaflet imports leaflet and esri-leaflet directly with statements like import * as L from 'leaflet', or import * as EL from 'esri-leaflet'.  That makes them available in the local scope of whatever file they're being imported into.  But they won't necessarily be available at the window level.  This is spefically the case for esri-leaflet, when used as a module.  But this is an easy fix - just import esri-leaflet-renderers as a module.
TLDR - how to fix it

Remove<script<EMAIL_ADDRESS>integrity="..."></script> from your html header

npm install esri-leaflet-renderers

Just after importing anything from esri-leaflet, or react-esri-leaflet, import esri-leaflet-renderers. So in your Layers.js:
 import { LayerGroup } from "react-leaflet";
 import { BasemapLayer, FeatureLayer } from "react-esri-leaflet";
 import 'esri-leaflet-renderers'

profit:

Hope that helps

I'm having the same issue, need it for react-leaflet v2, but tried it in version 3 also, getting the same error in different environments/versions. (esri-leaflet-renderers 2.1.3)
 TypeError: Cannot read properties of undefined (reading 'addInitHook')

As I had said in my previous comment, the issue is most likely with a mistmatch of imports.  Without seeing your project code, I can't really help debug.

I'm having the same issue, need it for react-leaflet v2, but tried it in version 3 also, getting the same error in different environments/versions. (esri-leaflet-renderers 2.1.3)
 TypeError: Cannot read properties of undefined (reading 'addInitHook')

As I had said in my previous comment, the issue is most likely with a mistmatch of imports.  Without seeing your project code, I can't really help debug.


chore: remove generated documentation from the repository

Until now, we included the generated documentation in our code base. The presence of multiple generated files interferes with the process of reviewing pull requests. Moreover, if there is a problem in the pre-commit hook, it can confuse external contributors.
With this PR:

the documentation is generated when building the documentation website
the generated files are git ignored and removed from the repository
no pre-commit hook to generate reference documentation and to add it to the commit files

Codecov Report

Merging #1376 (bd73557) into main (c95bab7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   86.25%   86.25%
=======================================
  Files          82       82
  Lines        9099     9099
  Branches      455      455
=======================================
  Hits         7848     7848
  Misses       1251     1251

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


No support for Virtualmin

I cannot get virtualmin to work?
Why there is even ads on frontpage this should work with virtualmin if this does not work with it?

This project is abandoned. Find another alternatives.


Add NTLM Auth

Connection with issue(s)
#583 onReceivedHttpAuthRequest not called on iOS
Resolve issue #583

Testing and Review Notes
It works and has been tested, how ever I am no expert in native Code and do not fully understand the consequences.

To Do

[ ] double check the original issue to confirm it is fully satisfied

Thanks for the fix! 👍

Thanks for the fix! 👍


Http2FrameLogger frame labels incorrect

Motivation:
The labels identifying the frame types in Http2FrameLogger are not always correct.
Modification:

Correct the string labels to indicate the right frame type in Http2FrameLogger

Result:
Logs are more correct.

4.1 (0f8ecdcad)


Wrong title when using --title-from-h1 and inline template macros

What happened?
When trying to use inline template macros with the --title-from-h1 parameter, instead of using the leading H1 header for the Confluence page title mark is using the template name of the first macro minus its first character (i.e. if the first inline template is defined as Template: #my_template the Confluence title becomes y_template).
What did you expect to happen?
The Confluence title matches the actual leading H1 header.
How can we reproduce the behavior you experienced?

Enable the --title-from-h1 parameter.
Create a document with no <!-- Title --> header and at least one <!-- Macro --> header with an inline template defined.
Try to sync the document with Confluence.

Minimal markdown example where the Confluence title becomes nline instead of Some title:
<!-- Space: Test -->
<!-- Parent: Test -->
<!-- Macro: <test />
        Template: #inline
        inline: Some test
    -->

# Some title

<test />

Information (please complete the following information)

Mark Version (mark --version): v9.11.1
Mark Parameters: --title-from-h1
Confluence Hosting: Cloud
Confluence Version: -
Environment specific Information: running in Github Actions

Logs or other output
No relevant logs that might highlight or help debugging the issue.
Additional context
Looks like the regex used in the ExtractDocumentLeadingH1 function might be the culprit, as it does match the observed behaviour.

Hey @mrueg, not fully sure of what the solution you proposed implies (moving the extraction to the custom parser) but a quick fix could be to just update the regex to better fit the Markdown specification for headings. Something like this should do the job (I can open a PR to add the change together with some tests): ^\s{0,3}#\s+(.*)(\s+#+)?\s*\n


esbuild-plugin-decorator

I can't find sources for esbuild-plugin-decorator, but npm package points here.

It used to be part of this project but is no longer maintained, please use other similar plugins.


It requires to install oh-my-zsh after bootstraping

https://ohmyz.sh/#install

we have migrated to fish shell.


Saving does not work on Android

Tried it out yesterday. No bombs for me on the next play session :-(
Probably should also change the "New Game" label to "Play Game" since the current approach actually hides the limited resume ability behind that button.
May be obsoleted by a more complete overhaul of save games.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/12875167-saving-does-not-work-on-android?utm_campaign=plugin&utm_content=tracker%2F15383776&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F15383776&utm_medium=issues&utm_source=github).

It would be a recent add then... if you take a look at my code that i have from a while back... it still all works. I would say that it is to do with the latest build you guys have made.

@Cervator If you need anymore help on this... please contact me<EMAIL_ADDRESS>as i have all my latest code moved to http://gitpull.xyz/groups/SlyFoxStudios.
Or if you guys have fixed it and just forgot to close this issuse

It may have worked in the past, I'm unaware if so. Pretty sure we still need a fix and/or more advanced saves eventually.

Closing as out of date - I was able to resume a regular game on Android. Still need better saves, but not via this issue.


CNV issues

Description of the bug
Add hg19 for PURPLE cnv caller
Command used and terminal output
No response
Relevant files
No response
System information
No response

Fixed


Progress bar no longer shows total iterations

This seems to have been introduced in master sometime recently. tqdm doesn't seem be be getting total set, so there's no progress bar or time to completion estimate. All we get is this:
374it [00:07, 50.48it/s, batch_nb=372, epoch=0, loss=0.801, some_val=1.25, v_nb=0]

This seems to be the culprit: https://github.com/williamFalcon/pytorch-lightning/pull/345/files#diff-0cd7170e96efa4a55577086f5db2fe4cR1058
@williamFalcon Was that line needed for some reason, or did some debug code just slip in?

Bah, link didn't point to where I wanted it to. The relevant code line in trainer.py is
            # limit the number of batches to 1 in fast_dev_run
            self.total_batches = 1

oh yeah... that's a bug

but on fast_dev_run that should be 1


Respect the file extension for content negotiation

Atm Content Negotiation respects the allow header from a request. For some use cases it's easier to simply set the file extensionto a different value (e.g. set .geojson or .json). This explicit request for one format should lead to a HTTP error, when it is not supported. In the best case the data is returned in the requested format.

Fixed in #17


refactor(*): replace Observables with Promises

BREAKING CHANGE:
all requests no work with and return promises
closes #153

:tada: This PR is included in version 5.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Windows [AST], [Serialization] and [IRGen] Fixes

This pull request contains a few changes to AST, Serialization, and IRGen to enable compiling on Windows against the MSVC toolchain.
The LegacyASTTransformer change to explicit namespacing is somewhat odd, but I was only able to get the compiler to recognise the declaration as being the same as the true definition by doing this; otherwise, it incorrectly infers that LegacyASTTransformer is in swift:: rather than swift::syntax::
In IRGen, the change to the condition for DLLImport linkage is directly taken from an assertion within Verifier.cpp in LLVM.

The IRGen changes seem fine to me.

@swift-ci Please smoke test

Missing UseSwiftCC caused issues where the swifterrorattribute wasn't emitted in IRGenModule::addSwiftErrorAttributes (as there it's conditional on UseSwiftCC, which perhaps it shouldn't be), but only IsSwiftErrorInRegister is tested in IRGenSILFunction::emitErrorResultVar and IRGenSILFunction::emitErrorResultVar, which causes a mismatch later on. I can recompile to find the exact error if you'd like.
As for adding a test case for it: I can try to do that, but I'm not sure exactly what I'd be testing or how I'd be testing it; I haven't looked too much into the Swift testing infrastructure yet.

I don't think there's any good reason we can't use swiftcc on Windows — it's implemented in the x86 backend, and I'd be surprised if somehow being a Windows target interfered with that.  Of course it might not be implemented for x86-32, but that matters to us, too.

At the moment using swiftcc on Windows is blocked by https://reviews.llvm.org/D31372; in short, the Microsoft mangling doesn't support the Swift calling convention. There's a workaround suggested there by @compnerd, but I haven't been able to figure out how to get it to work.

I'll take that up on that thread.

Is there anything remaining blocking this pull request or could it be merged in?

I'd wait a bit to see if John has any further comments, but it looks simple enough to me. Let's do a quick retest just in case, though.
@swift-ci Please smoke test

Since this has been open a while and I’m seeing other (semi-)duplicate PRs (https://github.com/apple/swift/pull/12475), can we get this merged in?
The last commit is just unifying the conditionals around IsSwiftErrorInRegister.

@troughton, could you please rebase this?

Sorry, I wasn't aware of the existence of this. I was trying to cross-compile Swift for Windows with clang-cl, and submitted #12475 and #12479 to fix issues I ran into, which are addressed by this PR as well.
I'm wondering if the additional changes you required were a result of using MSVC rather than clang-cl, or if other code has changed in the meantime that makes those changes unnecessary.

I think the only remaining changes from this that haven’t been separately addressed are the UseSwiftCC and IsSwiftErrorInRegister related ones. I might submit a separate PR with just those changes the next time I get to try a Windows build, but for now I’m closing this.


Fix the issue that first background files are in double precession while mpas-bundle in single-precession.

Description
Our mpas-bundle is commonly built in single precession. However, the first background files are in double precession (i.e. ensemble background at 00Z 15 April 2018). In that case, the analysis output will report error information "ERROR: MPAS IO Error: Inconsistent redefinition of dimension" (@RGNystrom reported). To solve this issue, the NCO is employed to convert double (float) variables to float (double) variables when the mpas-bundle is built in single (double) precision.
Tests completed
Tier 1:

[x] 3dvar_OIE120km_WarmStart
[x] 4denvar_OIE120km_WarmStart
[x] letkf_OIE120km_WarmStart

Instead of converting the files on the fly every time this step is run would it be more efficient to convert the files once, and then use the appropriate files based on bundlePrecision?

@jim-p-w has a good point. It is better to simply convert files offline once, then use them in the workflow, e.g., replace the old double-precision file location with the new single-precision file location.

That's right. Since we now use single-precision mpas-bundle only, it would be better that we prepare these files in single-precession rather than converting them when running workflow. @jim-p-w @liujake

@mos3r3n You can still use this PR, but fixing this in a different way: provide new location of the first cycle ensemble background files.

I think this one can be closed. @mos3r3n . We should have addressed this by converting double precision first background to single precision outside the workflow.


glib::get_real_name return type

It returns PathBuf. Shouldn't it be something like OsString?

You right. get_user_name too.
Want add PR ?


[DEV] Support for public version identifiers (PEP440)

Is your feature request related to a problem? Please describe.
Hi,
Downstream projects using Cython as a development dependencies might need to check Cython version for nightly build. Currently, there is no way to programmatically assess if the an installed version of Cython comes from an (alpha) release or from the source because the version number is not incorporating this information:
https://github.com/cython/cython/blob/ac56a661b6d670b69f24fb92408dd852a583b08d/Cython/Shadow.py#L4
PEP 440 introduced public version identifiers and in particular Development release segment which allow knowing programmatically that packages have been installed from a development version.
Describe the solution you'd like.
Use public version identifiers with a Development release segment.
That is change:
https://github.com/cython/cython/blob/ac56a661b6d670b69f24fb92408dd852a583b08d/Cython/Shadow.py#L4
for:
 __version__ = "3.0.0a12.dev0"

https://github.com/cython/cython/pull/5205/ has been opened accordingly.
Describe alternatives you've considered.
None.
Additional context
For scikit-learn, this limitation was recently met in https://github.com/scikit-learn/scikit-learn/pull/25300#discussion_r1064966103.

This broke installing Cython from the master branch e.g. with:
pip install https://github.com/cython/cython/archive/master.zip

I think similar errors can be seen in the CI.
It does not look like Cython knows what to do with dev0
Full traceback:
Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-req-build-nw3q1z65/setup.py", line 317, in <module>
          run_build()
        File "/tmp/pip-req-build-nw3q1z65/setup.py", line 245, in run_build
          setup(
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/__init__.py", line 87, in setup
          return distutils.core.setup(**attrs)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 148, in setup
          return run_commands(dist)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 163, in run_commands
          dist.run_commands()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 967, in run_commands
          self.run_command(cmd)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/wheel/bdist_wheel.py", line 299, in run
          self.run_command('build')
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/command/build.py", line 136, in run
          self.run_command(cmd_name)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 313, in run_command
          self.distribution.run_command(command)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/dist.py", line 1214, in run_command
          super().run_command(command)
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 986, in run_command
          cmd_obj.run()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 339, in run
          self.build_extensions()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 448, in build_extensions
          self._build_extensions_serial()
        File "/home/lesteve/miniconda3/envs/scratch/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 473, in _build_extensions_serial
          self.build_extension(ext)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Distutils/build_ext.py", line 122, in build_extension
          new_ext = cythonize(
        File "/tmp/pip-req-build-nw3q1z65/Cython/Build/Dependencies.py", line 1134, in cythonize
          cythonize_one(*args)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Build/Dependencies.py", line 1280, in cythonize_one
          result = compile_single(pyx_file, options, full_module_name=full_module_name)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/Main.py", line 604, in compile_single
          return run_pipeline(source, options, full_module_name)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/Main.py", line 528, in run_pipeline
          err, enddata = Pipeline.run_pipeline(pipeline, source)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/Pipeline.py", line 397, in run_pipeline
          data = run(phase, data)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/Pipeline.py", line 374, in run
          return phase(data)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/Pipeline.py", line 52, in generate_pyx_code_stage
          module_node.process_implementation(options, result)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/ModuleNode.py", line 206, in process_implementation
          self.generate_c_code(env, options, result)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/ModuleNode.py", line 475, in generate_c_code
          self.generate_module_preamble(env, options, modules, result.embedded_metadata, h_code)
        File "/tmp/pip-req-build-nw3q1z65/Cython/Compiler/ModuleNode.py", line 783, in generate_module_preamble
          code.putln('#define CYTHON_HEX_VERSION %s' % build_hex_version(__version__))
        File "/tmp/pip-req-build-nw3q1z65/Cython/Utils.py", line 624, in build_hex_version
          digits.append(int(digit))
      ValueError: invalid literal for int() with base 10: 'dev0'


SyntaxError in /

Error in ClashLeaders
SyntaxError in /
JSON Parse error: Unrecognized token '<'
View on Bugsnag
Stacktrace
[native code]:0 - parse

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
SyntaxError in /


Using update = none for submodules breaks git commands

Some git commands don't work correctly if submodules aren't initialized. For example:
$ git clone --recurse-submodules https://github.com/ubolonton/tree-sitter-langs
$ cd tree-sitter-langs
$ git reset --hard
fatal: not a git repository: ../../.git/modules/repos/agda
fatal: could not reset submodule index

This causes problems for tools that operate on git repositories. For example, this package breaks the update tool for Doom Emacs: https://github.com/hlissner/doom-emacs/issues/5064

This should likely be fixed in straight.

The problem isn't related to straight, the Doom Emacs tool uses git commands directly.

The problem isn't related to straight, the Doom Emacs tool uses git commands directly.

For itself, not for package upgrades. So the problem is related to straight.


1.20.1 Temp Files Cause CurseForge Modpacks to Get Rejected

Minecraft version
1.20.1
Describe the bug
Temp Files Cause CurseForge Modpacks to Get Rejected
Steps to reproduce

Make Modpack
Use Connector and Eldritch End
3.Temp Files Get Left in Mod Folder
4.Curseforge cries because mod files are in the zip
5.rejection

Connector is making copies of the mod files and leaving them in the temp folder causing any modpack that uploads a zip file to get rejected.  These temp files should get cleaned out.
Logs
No response
Additional context
No response

Files generated by connector inside the .connector folder contain remapped mods, which are cached between runs to improve load times and are part of essential connector functionality. Unfortunately, we have no plans to make changes to this functionality. I don't think Connector is the only mods that saves its own helper files into the mods folder either.
I recommend simply deleting the temp folder before submitting your modpack to curseforge.

Can I delete everything in the connector folder in the zip file?  Do these files get created automatically when the client runs the game?

Yes, both are correct


[otTables] Use XML snippets for testing fromXML() methods

This should make the unit tests more readable, and it also prevents
failures where a changed fromXML() implementation fails to ignore
interspersed whitespace. This has recently caused some developer
nuisance; see https://github.com/behdad/fonttools/pull/367.
Instead of having a custom parser implementation, it would be nicer
to call the actual XMLReader. However, XMLReader has a deeply built-in
assumption that it is processing an entire TTX file. Changing this
assumption would certainly be possible, but it would need a re-write
of the XMLReader code; having a custom parser just for unit tests
seems less involved.

this is very handy, thanks Sascha!


Add reboot button

just as a heads-up (after the other PR) I would like to add the reboot button so one can also restart the SHC.
Testing with SHC2 is highly appreciated.

There is a bug unrelated to this feature but only highlighted by it:
After a restart, all entities stay "Unavailable". Only after a reload of the Add-In they are updated.
Is there no retry mechanism for restoring the state once the central unit is available again?

Updated and tested again on the SHC1.

I found out how to release beta release for HACS. Simply publish a prerelease (e.g. from the develop branch) and it will show up automatically.
Could you do that? Thanks!

I already did that for https://github.com/planbnet/livisi_unofficial/releases/tag/1.10.0
That one seems to work fine, so I'll set it to released now and create a new one for the release button


Add setter for Retrier random number generator

Thank you for this project.
This pull request adds SetRand(Float64er) in order to provides ones own random number generator.
Uses cases include the following:

providing an alternate RNG.
providing a thread safe RNG.

Hmm, I didn't realize Go's PRNG wasn't thread-safe by default. I'd be tempted to just add a lock around the call instead? Letting people set custom PRNGs seems like overkill for something that doesn't even really need to be meaningfully random.

Ya, please add the lock instead.

Lock added as well as a test for validation.


[bug] require_relative requires binary extention in unexpected location

Please describe the bug
In general binary extensions are residing in a separate directory that is added to $LOAD_PATH, so it works fine. But
https://github.com/sparklemotion/nokogiri/commit/0cee8f01f2a07219407d3ffe5237f46714f71bd9#diff-a610b0ddcdf14966b304b7f6ffc87a1c5866f232f995a0a27d1618b23658b12aR25 changed require (which searched this directory) to require_relative, which looks only in gems/nokogiri-*/lib/nokogiri.
Currently after build on ruby platform we have
$ find vendor/bundle/ -name nokogiri.so
vendor/bundle/ruby/3.0.0/extensions/x86_64-linux/3.0.0/nokogiri-1.12.0/nokogiri/nokogiri.so
vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/ext/nokogiri/nokogiri.so
vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/lib/nokogiri/nokogiri.so

so it works fine.
But for size-cutting some people are using find ${LOCAL_BUNDLE_PATH}/gems/ -name '*.so' -delete that removes seemingly excessive binary exts, after that we have .so only in extension_dir, so require_relative from gems/nokogiri-*/lib/nokogiri/extension.rb fails, even though we have ext in $LOAD_PATH.
I can provide reproducer Dockerfile if needed and I can make a PR that reverts this particular require_relative if it's acceptable.
Expected behavior
Nokogiri works fine when binary ext is removed from gems directory.
Environment
Nokogiri (1.12.0) for ruby platform built for x86_86, docker image build from ruby:3.0.2-slim with find ${LOCAL_BUNDLE_PATH}/gems/ -name '*.so' -delete after gems installation.

@ojab Thanks for reporting this, and I'm sorry if you're having problems.
Can you help me understand why "some people" are doing this? Specifically, is this officially recommended somewhere to maintain smaller install sizes? I do want to make sure Nokogiri is following best practices for C extensions, and I feel like I need to understand this a bit better.

Ah, hmm, OK, I'm reading through the rubygems code and I'm just honestly confused why C extension files are being copied around to multiple places. But I agree the presence of extension_dir in full_require_paths (see https://github.com/rubygems/rubygems/blob/master/lib/rubygems/basic_specification.rb#L152) means it should be the canonical location for extension files.

…and I stopped writing reply after you reply :smile:
I suppose it's used because you can have multiple architectures in one archive/filesystem, so they dont' clash, but I'm surely not authority here, it's just observation that every gem has binary ext in extensions/x86_64-linux/ and all the gems has copy somewhere in gems/.

@ojab Can you reply with the output from nokogiri -v on your platform?
I'm inferring that you're not using the precompiled native gem, and I'm curious a) if that's true, and b) why you're choosing to compile rather than use the precompiled package?

It's official ruby docker image (i. e. debian slimmed down a bit), nothing special:
$ bundle exec nokogiri -v
# Nokogiri (1.12.0)
    ---
    warnings: []
    nokogiri:
      version: 1.12.0
      cppflags:
      - "-I/app/vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/ext/nokogiri"
      - "-I/app/vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/ext/nokogiri/include"
      - "-I/app/vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/ext/nokogiri/include/libxml2"
      ldflags: []
    ruby:
      version: 3.0.2
      platform: x86_64-linux
      gem_platform: x86_64-linux
      description: ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
      engine: ruby
    libxml:
      source: packaged
      precompiled: false
      patches:
      - 0001-Remove-script-macro-support.patch
      - 0002-Update-entities-to-remove-handling-of-ssi.patch
      - 0003-libxml2.la-is-in-top_builddir.patch
      - 0004-use-glibc-strlen.patch
      - 0005-avoid-isnan-isinf.patch
      - 0006-update-automake-files-for-arm64.patch
      - 0007-Fix-XPath-recursion-limit.patch
      libxml2_path: "/app/vendor/bundle/ruby/3.0.0/gems/nokogiri-1.12.0/ext/nokogiri"
      memory_management: ruby
      iconv_enabled: true
      compiled: 2.9.12
      loaded: 2.9.12
    libxslt:
      source: packaged
      precompiled: false
      patches:
      - 0001-update-automake-files-for-arm64.patch
      - 0002-Fix-xml2-config-check-in-configure-script.patch
      datetime_enabled: true
      compiled: 1.1.34
      loaded: 1.1.34
    other_libraries:
      libgumbo: 1.0.0-nokogiri

Precompiled nokogiri also carries multiple copies of binary ext (just for different ruby versions). It's because of obsession with the docker image size, with single copy we're saving 4%.

@ojab OK, just wanted to verify that you're intentionally opting in to compiling during installation. If you wanted the best of both worlds (speed and size), you could delete the shared library files for versions of Ruby that you don't care about).
In any case. #2301 is a PR that should fix this, going through CI now, and I'll release a patch version of v1.12 when it's green.

Fixed in Release 1.12.2 / 2021-08-04 · sparklemotion/nokogiri


Can file name be appended to the log message?

Is there any way to include the Component name along with the string being logged? For example if I'm logging "Function getMusicData() called" inside a Component called Music. I would want my logged message to look like "MusicComponent : Function getMusicData() called".
One way to do this could be declaring a constant string, "MusicComponent : " and appending this, each time I log something. This would be very hectic where there are 100s of lines to be logged and 100s of  files.
This is more of a feature request rather than a issue. I'm quite new to angular2-logger. If this feature already exists, I might have missed it. Can anyone point me to the usage, if it already exists?
Thanks in advance.

Hello @sudhashri , I've been working on this. Its planned for the Appenders and Support named loggers of the TODOs. It's a bit tricky in Typescript/JS so I want to make sure it's decent enough before delivering it. I can't promess you yet it will be as specific to the point of method names, but it will definitely be possible with Component's names.
As for the method name, I think you can already see this if you print it as an error which will make the console show the stacktrace of the callers, would this be a good alternative ?

@langley-agm Thanks for the update. I'm more interested in Component name than Method name. I can wait till released. As you said, I can already see the method name in stacktrace.

:+1:
Otherwise you don't know where the log is coming from...
Strangely, if I use console.debug()... I get the full call stack (and where the log is coming from)

But when using angular2-logger, no such thing ? why ?

Isn't that screenshot from a console.error and not a console.debug ?

Yes your are right my bad :p
But still no call stack if using this.logger.error('...')

@francisoud That's the stacktrace right there.
This is from the demo included in the distributable:

I am curious to know how can we config the log message with component name and time. Any help?
Thanks!!

@prabalakers At the moment that functionality hasn't been implemented so you cannot achieve it only by configuration.
However, Typescript allows extending classes, so you can extend it or create a wrapper of the actual logger if you favor composition over inheritance and extend its functionality.

@langley-agm https://github.com/code-chunks/angular2-logger/issues/60#issuecomment-248677442 finally found time to test it against a clean new angular 2.0.0 project, works like expected :)
I have the source (file and line number of origin stacktrace in case of logger.error() )
My issue was surely related to something I must have left in my code during an angular 2.0.0.rc3 to 2.0.0.rc5 version, sorry for the trouble.

no problem, glad it worked out @francisoud

Could this be a feasible solution to the issue:
currently the logger works like this: (= no prefix)
export class AppComponent(){
    constructor( private _logger: Logger ){
        this._logger.error('This is a priority level 1 error message...');
    }
}

However, if it would be possible to provide an injectable Logger constructor, then we could  write something like this.
export class AppComponent(){
    constructor( private Logger: Logger) {
        this._logger = new Logger(' I prefix every log message');
        this._logger.error('This is a priority level 1 error message...');
    }
}

This would solve the prefixing log message requested.
Any pros or cons on this?

Hi @HNeukermans,
Thanks for taking interest on this.
About the approach you propose:
If you inject the constructor so the user creates the object themselves then it would no longer be Dependency Injection, it would be the opposite and it would not be any different than importing the class and do this._logger = new Logger(' I prefix every log message'); without the need of the injection part constructor( private Logger: Logger).
It could be implemented with something similar to this:
1- Through a Factory:
`this._logger = LoggerFactory.getLogger('com.test.component');
Requires a refactor and a change in syntax of the people who are already using it.
`
2- Through reflection
Not sure if that's the correct word in JS but there is a way to find out the method name of the caller so we can use it as the prefix without the user having to specify it, problem with this approach is that it would only work if the user indeed calls it from the constructor (so it prefixes it with the name of the component) otherwise it will take the name of the function where the user is doing it from. Also, you can run into an issue of duplicated Component names.
3- Hybrid, a mix of the previous two.
Only name it with the caller name if the user doesn't specifies the prefix themselves and highly warn the user about the side effects if they don't.
I wonder if the second approach can be done using Dependency Injection, and have angular tell you who is it injecting it to and use an angular factory instead of singleton, but they were changing too much so I decided to postpone this research and I haven't had time lately to go back to it.

Hi @langley-agm,
Through a factory:
If you would agree on doing it this way, one way to not confront the user with breaking api changes is to develop the 'factory' way of working, parallell to current DI way, and mark the DI way as deprecated, so your api user can gradually phase out to to the new standard.
Through reflection:
I'm also not sure it this is possible using the current reflect metadata library. Reflection apis and features are still to limited for this, I guess..


B758

Use the preview tab to see the example given below. Edit the relevant information and preview the changes before submitting. You may delete these instructions.

Key
Value

ID
B758

Source
Vaaran Bhai Gurdas Ji

Page
28

Line
gur isKI dI vwsu lY; huie durgMD sugMD sryKY [

Correction
THIS ≠ THAT

PROOF (EDITION)
Image:

Correction:
gur isKI ≠ gurisKI
Proof:
Vaaran Bhai Gurdaas Ji | November 2011 | Shamsher Singh Ashok | SGPC, Sri Amritsar
Image: