Clarify named slots behavior

The existing wording was ambiguous; direct + explicit is best in this counterintuitive scenario

So, forgive me, and I'll loop @leader22 in on this convo too, but I think this change makes more sense in the context of the other situation we described, but not necessarily in the general sense?
Two things that I believe are true but am willing to be corrected on: the slot's child can be anything, and a slot doesn't need to have a parent in the html template itself. So, I found talking about parent and child here as a general description to be a little more confusing: I think my mind would jump to the slot's child, not the child of the component rendering the slot (because there might not even be one, so that wouldn't be my first thought.)
Does that make any sense??  :)
As per my comment in the other thread, my main goal is (a. obviously not confusing people! but also b.) not necessarly to document all the use cases. That's why I had suggested "If we scream ASTRO loudly and often enough, while they ae reading this page on Astro components, does that give people enough prompting to think about the fact that they have a Svelte etc. component?"
I was also wondering, if this is a really common use pattern, should it go somewhere in the page about framework components, which is where we're nudging people to read about using React, Svelted etc.? Thoughts?

So, forgive me, and I'll loop @leader22 in on this convo too,

Don't worry, Thank you for your efforts. 😸

but I think this change makes more sense in the context of the other situation we described, but not necessarily in the general sense?

Agree, now I feel some verbosity about these changes.

I was also wondering, if this is a really common use pattern, should it go somewhere in the page about framework components, which is where we're nudging people to read about using React, Svelted etc.? Thoughts?

This is exactly what I've thought today!
My current suggestions are

Keep this page simple like

- Inside of an Astro component, slots can also be **named**. Rather than a single `<slot>` element which renders _all_ children, named slots allow you to specify multiple places where children should be placed.
+ Slots can also be **named**. Rather than a single `<slot>` element which renders _all_ children, named slots allow you to specify multiple places where children should be placed in between Astro components.

And update https://github.com/withastro/docs/blob/main/src/pages/en/core-concepts/framework-components.md#nesting-framework-components

I gave it a try: #373
(BTW I think this should be my first PR...!)

How do you think?

@sarah11918 I agree with you that my wording of parent vs child might be confusing, but I disagree that the warning should go in the frameworks component page and not here: after all, this is the only place in the docs that is focused on Slots.

(Also to clarify what I did mean about parent and child - in the context of slots, the child is the component that can take slots, and the parent is the page/component that includes the child and passes slots. But I agree that we can choose simpler language that doesn't assume this terminology knowledge!)

I would also like to see the new syntax for the slots api, where by we can pass through a callback function into the slot to render dynamic slots, I was taking a look around the github, and couldn't see the finalised api of this albeit this has been merged into Astro since 0.26, I'll ping @natemoo-re  to see if he could provide us with an example for this to include into the documentation,

With fresh morning eyes, can we solve this whole thing via some combination of:

when introducing / referring to slots, sprinkling in every now and then something that makes it explicit... e.g "Slots in Astro..."
a call-out like: "Using Astro slots with other UI framework components ? " and then explain this slot behaviour over there? (specifics to be hashed out in the other PR)

@Jutanium @leader22

Yep, as long as it's a clear and explicit disclaimer on the UI Framework Components page, I'm happy. #373 is a good example of that

@Jutanium OK, assume #373 will be merged!
Given that, are you happy to be the one to make those changes here? Make a call out in our style of " > emoji " and just throw some more Astros on the page?  :smile:

Could we hold of on the push for this, I would like to see the inclusion of the callback api within the slots being documented, just waiting for a definitive example from Nate,

Hey @aFuzzyBear , is this related to Astro.slots? Is there more to document than what's here in reference? https://docs.astro.build/en/reference/api-reference/#astroslots

fml ... that's what I was looking for !! I'm out

@Jutanium & I will finish this off tomorrow (Wednesday)!

@Jutanium Did we decide that this PR can be closed, because we're going to tackle the wording for slots in the other PR? (And, we've added something to Framework Components already?)

I lost track of the other PR, but it's fine if this one's closed!


User Assigned identity for Policy

Has https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues/304 been addressed?  I ran into this issue today and I've not seen an update that appears to address it.  I did note that the version of azurerm being used 3.18.0 does now support user assigned identity.
Thanks,
Shane

Not yet, but we are currently prioritizing our backlog so I will attach this to the related user story as customer evidence to help prioritize this 👍🏻

Coming back to this hoping for an update, but re-thinking my position on this.  I perceive a need for this change because it seems that each policy that I apply that has remediation is being assigned to the contributor RBAC role and it just seems to pollute the RBAC assignment page.  My goal for this request is to have as few identities as possible and that most remediations would use a single principal.  Is that unreasonable?

Linking to AB#25191
However this is not our recommendation due least priv

Understood on the least privileged comment, however when you have several policies that are doing the same thing it potentially makes sense.  For example policies for tag inheritance like as illustrated:
https://github.com/Azure/azure-policy/blob/master/samples/Tags/inherit-resourcegroup-tag-if-missing/azurepolicy.json
If there was a way to have a single policy that trickled all necessary tags from a subscription->RG->Resource then I would have less need of using a user defined identity.  But I've yet to find a way to do that.

This is something we will put in the backlog for the next release.


uplink: support server-side move operation

This patch expose the new move command from uplink-c.

Test isn't running in CI but looks good otherwise.

They seem to be executed: https://github.com/storj/uplink-java/actions/runs/2281601070
And checked the junit file and the new tests are executed:
  60   │   <testcase name="testMoveFailure" classname="io.storj.UplinkTest" time="0.052"/>
  61   │   <testcase name="testObjectsListing" classname="io.storj.UplinkTest" time="1.922"/>
  62   │   <testcase name="testMove" classname="io.storj.UplinkTest" time="0.93"/>

Test isn't running in CI but looks good otherwise.

They seem to be executed: https://github.com/storj/uplink-java/actions/runs/2281601070
And checked the junit file and the new tests are executed:
  60   │   <testcase name="testMoveFailure" classname="io.storj.UplinkTest" time="0.052"/>
  61   │   <testcase name="testObjectsListing" classname="io.storj.UplinkTest" time="1.922"/>
  62   │   <testcase name="testMove" classname="io.storj.UplinkTest" time="0.93"/>

I was confused because there isn't a "test" step in https://github.com/storj/uplink-java/runs/6322434041?check_suite_focus=true and none of the output or commands looks like any tests are run.

@Erikvv Good point.
It doesn't worth to separate build/test IMHO (test includes build), but it's a good idea to rename the stage to test to make it clear what's going on...


Cache unit tests in CI

Description
Adds Go build caching to the CI workflow (see eg. https://github.com/mvdan/github-actions-golang#how-do-i-set-up-caching-between-builds). This allows us to "skip" building and running tests for components that haven't changed.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

I am personally against caching the unit-test results, as it would introduce an additional degree of non-determinism.
This could raise (at least) two possible problems: (a) test coverage reduction, since test suites are slightly randomized, and different runs might uncover different problems; (b) flaky tests: let consider a test that succeeds once (by chance) and fails all the others. If that first run gets cached, it will no longer be executed, and a bug will get unnoticed, regardless of the test existence. This could also potentially cause code modifications to trigger unrelated tests failures, just because they get te-executed, hence making them harder to debug.

I agree with point (b); I'm not sure about point (a), because I don't recall seeing randomized unit tests - a quick grep -R rand **/*_test.go reveals that there is effectively one usage of rand for the IPAM listening port.
With that said, I believe there is value in "incremental testing" for faster iteration, while keeping uncached tests as a requirement for merging. Of course it is still possible for a flaky test to evade detection, but for a typical PR where one runs a few incremental tests and then an uncached one, each test would run at the very least twice (once when it was cached and once in uncached tests).

As for point a) the order of the tests themself is random (could also randomize the It specs, but that is not done at the moment), and controllers (especially in integration tests) have intrinsic random behaviors.
As for keeping both alternatives, that is definitely possible, although with the increased complexity of correctly handling the mandatory checks. Still, I am missing a bit the advantage, as a subset of tests of interest could be easily executed locally for much faster iteration (only a very few network related require to be executed through the container). That way it is also easier to investigate possible failures.


CognitoIDP[UserPoolClient]: Avoid underlying provider validation failure

Description of your changes

In a current state the instantiation of UserPoolClient fails with
cannot run refresh: refresh failed: reading Amazon Cognito IDP (Identity Provider) User Pool Client (): InvalidParameter: 1
validation error(s) found.
- minimum field size of 1, DescribeUserPoolClientInput.ClientId.

unless we explicitly set the external-name annotation. See #752 for more debugging data

This change will preset the id with spec.forProvider.name to avoid the validation failure. The id will be populated eventually with the dynamic value from the cloud provider

I also tried to follow the doc at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cognito_user_pool_client#import but it seems to be wrong in practice:
If we use smth like
TemplatedStringAsIdentifierWithNoName("{{ .parameters.user_pool_id }}/{{ .parameters.name }}"),

it will fail with
cannot run refresh: refresh failed: reading Amazon Cognito IDP (Identity Provider) User Pool Client (us-west-1_dMnICLKVB/): InvalidParameterException: 1 validation error detected: Value 'us-west-1_dMnICLKVB/' at 'clientId' failed to satisfy constraint: Member must satisfy regular expression pattern: [\w+]+

It proves that the import doc deviates from reality and fails its own provider validation.

It is possible that we observe the bug in the underlying terraform aws provider.

This fix provides best possible solution without the fix of underlying provider and associated costs.

Fixes #752

I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

e2e with example from examples/cognitoidp/userpooluicustomization.yaml
I will also execute uptest separately below

/test-examples="examples/cognitoidp/userpooluicustomization.yaml"

@ytsarev please run make generate locally and push any diffs up in this PR

@jeanduplessis Thanks for the catch! I actually didn't expect that and don't like what the generator did, investigating further.

/test-examples="examples/cognitoidp/userpooluicustomization.yaml"

@jeanduplessis updated the solution with the function that does not change CRD structure/name field requirement.


Missing standalone argument Application.run

Hello - I am absolutely new to Autobahn. Please help me understand how do i pass the standalone argument to instance method "run" of autobahn.twisted.wamp.Application.
Source:
http://autobahn.ws/python/_modules/autobahn/twisted/wamp.html#Application.run
Not sure why it is not working for me.
https://github.com/tavendo/AutobahnPython/blob/master/examples/twisted/wamp/app/klein/example2/server.py
On running this example:
Got TypeError: run() got an unexpected keyword argument 'standalone'

Hi,
TypeError: init() got an unexpected keyword argument 'standalone'
when trying wamp example "python calculator.py --web 80"
Autobahn examples work fine, and I checked install of crossbar test OK /opt/crossbar/bin/crossbar version tests OK at 0.10.2


shfmt plugin

Make a shfmt code formatter plugin. Make it use the docker image https://hub.docker.com/r/mvdan/shfmt/ as fallback if shfmt is not installed.

Closed in https://github.com/executablebooks/mdformat/pull/126

Closed in https://github.com/executablebooks/mdformat/pull/126


Exploit-report

https://www.exploit-db.com/exploits/46389

Fixed in v2.2.0, thanks for reporting this.


Training datasets

First of all, Thanks a lot for your work on this amazing tool!
Could you share the datasets used for training? With that we can make the training on sd2.1!

Thanks for these models! ControlNet results with my 1.5 models were awesome, but I have trained so many 2.1 embeddings I'd love to use with this.

I believe that we can create the dataset automatically.

downloads prompts from kreaai for example
generate images according to the prompts
automatically use canny edge detector, hed detector, etc.
use this to train ... we have a source ( canny edges), we have targets ( generated images), we have prompts

I'm sure we could get together funds to train on some A100's, but the training data is the real problem. Is the data even able to be release? Legal issues?

Training seems fast and not really expensive.
i hope they ll be answer, the other solution is to generate our dataset. (100-300k images then use the script to get the scribble, openpose, depth… versions and train after… it ll work but it ll be more energy efficient if we have the data)

Given the current complicated situation outside research community, we refrain from disclosing more details about data. Nevertheless, researchers may take a look at that dataset project everyone know.

Thanks @lllyasviel for your reply.
do you plan to train with sd2.1?

If I can help with funds I'd be happy to help. I'm disappointed in current
Open landscape.
On Sun, Feb 19, 2023, 12:55 PM thibaudart @.***> wrote:

Thanks @lllyasviel https://github.com/lllyasviel for your reply.
do you plan to train with sd2.1?
—
Reply to this email directly, view it on GitHub
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1436090830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A567NIQTY2GYWNSFF5PMFNLWYKCEXANCNFSM6AAAAAAU7MPJBQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@notrydo the first step is having a dataset for the training. If you have 100/300K of image (512x512) of quality and varied, it could be useful. If not, we will need to find a prompt dataset and generate them. (it takes roughly 24 hours to generate 40K images, so around 10 days to have the images, after that it'll take few days to BLIP them and to generate the preprocessed versions)

Any additional specifications?
On Mon, Feb 20, 2023, 10:52 AM thibaudart @.***> wrote:

@notrydo https://github.com/notrydo the first step is having a dataset
for the training. If you have 100/300K of image (512x512) of quality and
varied, it could be useful. If not, we will need to find a prompt dataset
and generate them. (it takes roughly 24 hours to generate 40K images, so
around 10 days to have the images, after that it'll take few days to BLIP
them and to generate the preprocessed versions)
—
Reply to this email directly, view it on GitHub
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1437427767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A567NIWTLOADIQWRJXORD3TWYO4NJANCNFSM6AAAAAAU7MPJBQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

If known where we can purchase drop link.
On Mon, Feb 20, 2023, 2:58 PM Amanda Besemer @.***> wrote:

Any additional specifications?
On Mon, Feb 20, 2023, 10:52 AM thibaudart @.***>
wrote:

@notrydo https://github.com/notrydo the first step is having a dataset
for the training. If you have 100/300K of image (512x512) of quality and
varied, it could be useful. If not, we will need to find a prompt dataset
and generate them. (it takes roughly 24 hours to generate 40K images, so
around 10 days to have the images, after that it'll take few days to BLIP
them and to generate the preprocessed versions)
—
Reply to this email directly, view it on GitHub
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1437427767,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A567NIWTLOADIQWRJXORD3TWYO4NJANCNFSM6AAAAAAU7MPJBQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I am currently training a sketch to image model on Waifu Diffusion 1.5 (which uses SD 2.1 v prediction). I made a dataset of 1 million sketch image pairs, and I'm training with 50% unconditional chance (like in the paper). Here are the results so far at 150k samples seen:

I am currently training a sketch to image model on Waifu Diffusion 1.5 (which uses SD 2.1 v prediction). I made a dataset of 1 million sketch image pairs, and I'm training with 50% unconditional chance (like in the paper). Here are the results so far at 150k samples seen:

Anime models needs larger batchsize and lower (or disabling) text dropping because their tags are dense.

I am currently training a sketch to image model on Waifu Diffusion 1.5 (which uses SD 2.1 v prediction). I made a dataset of 1 million sketch image pairs, and I'm training with 50% unconditional chance (like in the paper). Here are the results so far at 150k samples seen:

See also updated last section of https://github.com/lllyasviel/ControlNet/blob/main/docs/train.md

Don’t know.
Le lun. 20 févr. 2023 à 18:59, notrydo @.***> a écrit :

If known where we can purchase drop link.
On Mon, Feb 20, 2023, 2:58 PM Amanda Besemer @.***> wrote:

Any additional specifications?
On Mon, Feb 20, 2023, 10:52 AM thibaudart @.***>
wrote:

@notrydo https://github.com/notrydo the first step is having a
dataset
for the training. If you have 100/300K of image (512x512) of quality and
varied, it could be useful. If not, we will need to find a prompt
dataset
and generate them. (it takes roughly 24 hours to generate 40K images, so
around 10 days to have the images, after that it'll take few days to
BLIP
them and to generate the preprocessed versions)
—
Reply to this email directly, view it on GitHub
<
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1437427767
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/A567NIWTLOADIQWRJXORD3TWYO4NJANCNFSM6AAAAAAU7MPJBQ

.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1437648800,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYWNXDBGXV62KHSC6UTZSJDWYPZOHANCNFSM6AAAAAAU7MPJBQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
T

@lllyasviel if we paid you for the training, could you do it for 2.1?
Le lun. 20 févr. 2023 à 19:58, lllyasviel @.***> a
écrit :

I am currently training a sketch to image model on Waifu Diffusion 1.5
(which uses SD 2.1 v prediction). I made a dataset of 1 million sketch
image pairs, and I'm training with 50% unconditional chance (like in the
paper). Here are the results so far at 150k samples seen: [image: image]
https://user-images.githubusercontent.com/18043686/220213337-21c349b1-c39b-4095-94df-f032ec3c3e0d.png [image:
image]
https://user-images.githubusercontent.com/18043686/220213345-61279016-3d6c-4220-8227-f013728b6004.png [image:
image]
https://user-images.githubusercontent.com/18043686/220213350-9cf593cc-d9fa-4777-92bc-3e70b0c0f909.png [image:
image]
https://user-images.githubusercontent.com/18043686/220213353-0780274f-2bdf-44fd-a3ff-3a76b6d8c0d8.png
Anime models needs larger batchsize and lower (or disabling) text dropping
because their tags are dense.
—
Reply to this email directly, view it on GitHub
https://github.com/lllyasviel/ControlNet/issues/93#issuecomment-1437678784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYWNXDHBOBYL6TJ73GE3HKDWYQALDANCNFSM6AAAAAAU7MPJBQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
T

Anime models needs larger batchsize and lower (or disabling) text dropping because their tags are dense. Also, because of sudden converge phenomenon, use 10* gradient accumulation to optimize 15k steps will be better than 150k steps.

@lllyasviel
Yeah I'm using as large of a batch size as I can on this machine, which is 1x A40. Going to be switching to 4x A40s soon though. I'm able to fit 18 batch size @ 512 resolution currently. I want to try 768 resolution for the next training run with the 4 GPUs, so I'm not sure what that will look like in terms of batch size.
I'll make the changes in the unconditional dropping, I might copy over the "partial dropout" code from waifu diffusion training, where we train with a variable percentage of the prompt (50% chance to have 0% to 100% of the tags, 50% chance to have 100%), except maybe moving the percentages to maybe have a 30% chance of partial dropout.
Very interesting about the sudden converge phenomenon. I've noticed this phenomenon when normal Waifu Diffusion 1.5 as well. I don't quite see how changing the gradient accumulation steps helps with this though, could you explain that part further?

Anime models needs larger batchsize and lower (or disabling) text dropping because their tags are dense. Also, because of sudden converge phenomenon, use 10* gradient accumulation to optimize 15k steps will be better than 150k steps.

@lllyasviel Yeah I'm using as large of a batch size as I can on this machine, which is 1x A40. Going to be switching to 4x A40s soon though. I'm able to fit 18 batch size @ 512 resolution currently. I want to try 768 resolution for the next training run with the 4 GPUs, so I'm not sure what that will look like in terms of batch size.
I'll make the changes in the unconditional dropping, I might copy over the "partial dropout" code from waifu diffusion training, where we train with a variable percentage of the prompt (50% chance to have 0% to 100% of the tags, 50% chance to have 100%), except maybe moving the percentages to maybe have a 30% chance of partial dropout.
Very interesting about the sudden converge phenomenon. I've noticed this phenomenon with normal Waifu Diffusion 1.5 as well. I don't quite see how changing the gradient accumulation steps helps with this though, could you explain that part further?

Because that "sudden converge" always happens, lets say "sudden converge" will happen at 3k step and our money can optimize 90k step, then we have two options: (1) train 3k steps, sudden converge, then train 87k steps. (2) 30x gradient accumulation, train 3k steps (90k real computation steps), then sudden converge.
Note that (2) is significantly better than (1). Train a controlnet is very different from training other things from scratch.

I see. Just curious, do you think that it would make sense to try the same technique with a normal diffusion model? Would love to talk more about this, but I'm not sure is a github issue about training data is the best place lol. My discord is salt#1111 if we could talk there, although since this is research I'm not sure if there is some requirement where when you talk about it, it has to be in public. Maybe a new thread under the github discussions?
Just read your edit, do you mean that after the "sudden converge", I should reduce my gradient accumulation steps?

no. The batch size should not be reduced under any circumstances. In addition, we should always remember that we are not training layers from scratch, we are optimizing some projections between existing layers. We are still fine tuning a SD.
Feel free to open disscussion if necessary.

just for sake of reference ... is this the correct approach for grad_acc ?
N = 10
trainer = pl.Trainer(gpus=1, precision=32, callbacks=[logger], amp_backend='apex', accumulate_grad_batches=N)
?

When modifying batch size or gradient accumulation, shoud I modify learning rate?

@lllyasviel can you share hyperparameters you used for training e.g. batch size, effective batch size, number of GPUs, number of worker nodes, learning rate, number of training steps, etc?
I saw in the paper you mentioned learning rate as 1e-5 using AdamW optimizer but I'm not sure about the other hyperparameters. I'm especially interested in effective batch size because 1e-5 learning rate means different based on how "accurate" your gradients are. And your gradients accuracy depend on the effective batch size.

I am currently training a sketch to image model on Waifu Diffusion 1.5 (which uses SD 2.1 v prediction). I made a dataset of 1 million sketch image pairs, and I'm training with 50% unconditional chance (like in the paper). Here are the results so far at 150k samples seen:

Can you share a bit more about what you mean by 50% unconditional chance?

@whydna it means that there is a 50% chance for the text prompt input to be dropped (set to empty string) when training the model and only the control image will be used (the sketch in this case).

@off99555 thanks for the explanation - makes sense.
Is this achieved by just omitting prompts for 50% of the data set in prompts.json? Or is there some param to do it in the training function?

@off99555 thanks for the explanation - makes sense.
Is this achieved by just omitting prompts for 50% of the data set in prompts.json? Or is there some param to do it in the training function?

It will be done in the code dynamically. Here is example code I found in another repository that does 5-10% dropping of text prompt:
https://github.com/timothybrooks/instruct-pix2pix/blob/0dffd1eeb02611c35088462d1df88714ce2b52f4/stable_diffusion/ldm/models/diffusion/ddpm_edit.py#L701-L707
I'm not sure where this piece of code exists in ControlNet repo.

The code doesn't exist in the controlnet repo, you have to write it yourself. Also, I talked to the author and he said that 50% is too high for sketch, it should be more like 0-10%

Given the current complicated situation outside research community, we refrain from disclosing more details about data. Nevertheless, researchers may take a look at that dataset project everyone know.

@lllyasviel  could you please share the details of each feature extracters, such as the threshold used by canny(), mlsd() and midas ?

I am currently training a sketch to image model on Waifu Diffusion 1.5 (which uses SD 2.1 v prediction). I made a dataset of 1 million sketch image pairs, and I'm training with 50% unconditional chance (like in the paper). Here are the results so far at 150k samples seen:

See also updated last section of https://github.com/lllyasviel/ControlNet/blob/main/docs/train.md

Could you share the hyperprameter you use? what is the learning rate and effective batch size?


Implement fish feeding control surface

Description
Implement fish feeding control surface such that player can control the game:

Feeding on / off
Feeding rate

Definition of done

[ ] Slider

[ ] Slider model is in environment
[x] Slider has 3 options

[x] Low
[x] Medium
[x] High

[x] Slider position controls food rate

[ ] Slider only controls current view

[ ] When view is changed current rate is kept in previous view
[ ] New view is changed to rate correlating to sliders current position

[ ] Rate is zero if current view has is in the state "off" (given from button)

[ ] Start/Stop Button

[ ] button is in environment
[ ] button controls whether food is being delivered

[ ] First push: "on"
[ ] Second push: "off"
[ ] Base state: "off"

[ ] Button only controls current view

[ ] When view is changed current state is kept in previous view
[ ] New view is kept from its previous state (base: "off", or other if view state was changed earlier)

DOD has been changed, START / STOP button is not wished for - More intuitive with one slider per fish-system for player. With these changes in mind, The issue is completed


SIGINT/SIGTERM not passed to app

I built the following golang app:
package main

import (
	"fmt"
	"os"
	"os/signal"
	"syscall"
)

func main() {
	ch := make(chan os.Signal, 1)
	signal.Notify(ch, syscall.SIGTERM, syscall.SIGINT)
	fmt.Println("waiting for signal...")
	sig := <-ch
	fmt.Printf("received %s\n", sig)
}

Running this manually, I can ctrl+c it and it cleanly exits:
% ./handle
waiting for signal...
^Creceived interrupt

Additionally, I can send it a SIGTERM:
% ./handle
waiting for signal...
received terminated

Now, package up the binary using the following ACI manifest:
{
    "acKind": "ImageManifest",
    "acVersion": "0.5.2",
    "name": "acihandle",
    "labels": [
        {
            "name": "arch",
            "value": "amd64"
        },
        {
            "name": "os",
            "value": "linux"
        }
    ],
    "app": {
        "user": "root",
        "group": "root",
        "exec": [
            "/handle"
        ]
    }
}

...and run it:
% sudo rkt --insecure-skip-verify run jelly/acihandle.aci
waiting for signal...

Attempting to either ctrl+c it has no effect:
$ sudo rkt --insecure-skip-verify run jelly/acihandle.aci
waiting for signal...
^C

Trying again with SIGTERM:
$ sudo rkt --insecure-skip-verify run jelly/acihandle.aci
waiting for signal...
Trying to halt container. Send SIGTERM again to trigger immediate termination.

I am unable to stop the process without SIGKILLing it. I don't know if this is crazy, but I expect both SIGINT (ctrl+c) and SIGTERM to be passed through to my app inside the pods. This is with rkt v0.5.5.

@bcwaldon pretty sure this is #1074, any chance you can test reproducing from master?

Note that for Ctrl+C to work you need to start the container with --interactive

Got it, thanks guys. I can pass SIGTERM through on master @ 66acef9e02d43241d8a43349ead1ea334ba8a881.

Is there some way to get Ctrl+C working with a Pod as well?

@Crafter6432 no, because it's ambiguous where that signal would be sent. If you just need to kill the container, ctrl-] should do it. If you want to send a specific signal to a specific app, I'd suggest using machinectl


Added Forced Previous Button WIP

We had a forced-next button but not a forced previous. Currently, the code was set so if the user tried to go to the previous clip with unsaved changes, the forced next button would appear and take users to the next clip, not the previous one.
Now, when the user goes back to previous clip with unsaved changes, a forced previous button appears to take the user back to the previous button
TODO:

Rebase with refractor changes

Will be resolved by #136


Option for non-radio outlets when "Display As Power Strip" is selected

Hello & thank you again for this awesome plugin -- I use it daily! I have read another closed issue/request for non-radio switches, in which case, I agree should not be built into this plugin when there are stateful switch options out there & that would defeat the purpose of this plugin.
However, given that this is the only dummy switch plugin that I have been able to find in months & months of searching that offers a functional dummy power strip capability, I am in desperate need for an optional setting that makes the outlets stateful/non-radio specifically & only for when a user has the "Display As Power Strip" option selected. This would preserve the intent & purpose of this plugin while also providing one additional feature you cannot find in any other plugin - a properly functional dummy power strip.
If you are aware of a plugin that provides this capability that I for some reason have not been able to find in the last 6+ months, please direct me there & do not adjust your code! Lol but if you can understand the desire for a power strip that functions like an actual power strip would without turning off the other outlets, I kindly ask (beg) you to consider adjusting this one particular setting regarding only the power strip view while not changing core functionality of the plugin.
Thank you kindly for your time & consideration! All the best.

@lukasroegner In a deeper search for a plugin that offers power strip capabilities, I actually found a fork of your plugin that the code suggests the ability to set “IsRadio” as a boolean to adjust individual switches. I’m not installing this to test it since it would override your plugin of the same name, don’t want to re-setup my whole home & automations if it doesn’t work & honestly trust you/the original more lol but I thought it might offer some insight for you to look into & see if it’s possible to only restrict this boolean to the power strip option & not the whole plugin so here’s the project code I’m referencing:
https://github.com/donkeystudio/homebridge-dummy-radio-switch/commit/ce460ba0ab3138f7a76670131f7706873b28de68
I hope this can help! Open to your thoughts or suggestions.

Hello sir @lukasroegner. I just wanted to follow back up on this issue. Have you had a chance to look into this &/or is it something you would consider? Thank you again!


Massive number of lua errors after changing font/colors

Describe the bug
I received 9427 lua errors in just a couple of minutes when I logged in to WoW after installing MPG. I made changes to the font and colors last night before logging off. It seemed to work fine then, but then logging in today seemed to break everything. When I clicked to open MPG, only the header appeared and nothing else. Reinstalling and removing saved settings fixed it, but I'm not sure what is going on to cause the error. Another weird thing that might be a clue is that my wife installed MPG at the same time as I did. We're running the same version, but hers has additional options such as choosing class color and RBG color selection.  - Also, this addon is awesome!
To Reproduce
BugGrabber error report is below. FYI, there were no lua errors during this session other than the 9427 from MPG.
Additional context
9427x MplusGains/MplusGains.lua:2305: attempt to index local 'headerFrame' (a nil value)
[string "@MplusGains/MplusGains.lua"]:2305: in function <MplusGains/MplusGains.lua:2300>
[string "@MplusGains/MplusGains.lua"]:2377: in function <MplusGains/MplusGains.lua:2334>
Locals:
dungeonHolderFrame = nil
summaryFrame = nil
headerFrame = nil
(*temporary) =  defined @MplusGains/MplusGains.lua:263
(*temporary) = 9
(*temporary) =  {
3 =  {
}
10 =  {
}
123 =  {
}
}
(*temporary) = "attempt to index local 'headerFrame' (a nil value)"
weeklyAffix = 10
addon =  {
CalculateChest =  defined @MplusGains/DungeonInfo.lua:211
CreateKeystoneButton =  defined @MplusGains/KeystoneButton.lua:9
fortifiedID = 10
FormatTimer =  defined @MplusGains/FormatHelpers.lua:8
RoundToOneDecimal =  defined @MplusGains/FormatHelpers.lua:23
affixInfo =  {
}
GetPlayerDungeonBests =  defined @MplusGains/DungeonInfo.lua:72
CalculateRating =  defined @MplusGains/DungeonInfo.lua:178
GetOppositeAffix =  defined @MplusGains/DungeonInfo.lua:110
tyrannicalID = 9
GetWeeklyAffixInfo =  defined @MplusGains/DungeonInfo.lua:136
GetGeneralDungeonInfo =  defined @MplusGains/DungeonInfo.lua:56
SetNewBest =  defined @MplusGains/DungeonInfo.lua:304
SortAffixesByLevel =  defined @MplusGains/DungeonInfo.lua:283
SortDungeonsByScore =  defined @MplusGains/DungeonInfo.lua:223
SortDungeonsByLevel =  defined @MplusGains/DungeonInfo.lua:243
FormatDecimal =  defined @MplusGains/FormatHelpers.lua:32
CalculateDungeonTotal =  defined @MplusGains/DungeonInfo.lua:27
CalculateDungeonRatings =  defined @MplusGains/DungeonInfo.lua:40
scorePerLevel =  {
}
}
selectedAffix = 10
SetDesaturation =  defined @MplusGains/MplusGains.lua:263
PopulateAllDungeonRows =  defined @MplusGains/MplusGains.lua:1736
PopulateAllAffixRows =  defined @MplusGains/MplusGains.lua:1720
PopulateAllBestRunsRows =  defined @MplusGains/MplusGains.lua:2122

Hey thanks for the bug report! It is likely that whatever font you chose was missing on your next boot up and is causing the errors. The error checking I did for fonts either isn't enough or not working as intended. I'll take a look into fixing it.
As for the additional options missing, was this when you had errors or after the reinstall?


Milestone 2 - Standardizing names in documents and scripts. Rename the functions too.

Either do it at last or parallelly by coordinating the whole team.

@morrismanfung @austin-shih @MNBhat I made some updates on the variable names. Let me know what you guys think!


Bump to v2.29.0

I’m eager to see if the new publish.yml workflow works correctly ✨
Should we include #1854 in this release? Others too?

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] ~Added tests.~
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

#1854 looked good so I merged it! Let's rebase and release it 🎉.

@bquorningRSpec/EmptyOutput seems to be remain  <<next>> in default.yml

Uh. Its failing to push because of the branch rules:
https://github.com/rubocop/rubocop-rspec/actions/runs/8561970997/job/23464311900
Run sed -i 's/version:.*$/version: ~/' docs/antora.yml
[master 0b618c0] Switch docs version back
 1 file changed, 1 insertion(+), 1 deletion(-)
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 12 of 12 required status checks are expected.
To https://github.com/rubocop/rubocop-rspec
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/rubocop/rubocop-rspec'

At least it’s the very last step that fails, so we still have the gem build/push, tagging and GH release creation happening.
Perhaps there is a way to let GHA write to master branch despite the branch protection rules. I have pushed the Antora config change manually for now.


[regression] Version 0.9.0 fails on FreeBSD

# github.com/liamg/aminal/gui
gui/gui.go:718:9: undefined: platform.LaunchTarget
*** Error code 2

@yurivict thank you for the report! Hopefully, should be resolved with https://github.com/liamg/aminal/pull/211


Hylo LSP proof-of-concept

Hello Hylo team!
I am really excited about the Hylo language effort, mainly from the watching the published presentations and listening to the podcasts, which has convinced me that Hylo has very high potential, and if the project and community get enough momentum this could have a large impact on writing safe and performant code.
I wanted to get more familiar with the language itself, as well as design and implementation details of the compiler.
So I thought building an LSP for Hylo was the perfect project to get hands on experience.
I do have a working proof-of-concept implementation of a hylo-lsp server at this point. I have not been able to spend as much time on the actual Hylo compiler API as I originally intended, because I soon realized that the Swift LSP ecosystem was missing some key components to bootstrap such an LSP project.
I found the LanguageServerProtocol projects, which does provide some of the building blocks, but has up until now only been used for client side LSP integration.
So I have spent quite a bit of work to add functionality for LSP server development, tracked in this issue: https://github.com/ChimeHQ/LanguageServerProtocol/issues/7
After working on those parts, I could then return to the hylo specific parts for an hylo-lsp, writen in Swift, and integrating with the Hylo compiler API.
The hylo-lsp repo is here: https://github.com/koliyo/hylo-lsp
And the current implementation is in the feature/wip branch.
The project consists of the following:

hylo-lsp

A library integrating LanguageServerProtocol with the Hylo compiler

hylo-lsp-executable

Wrapping hylo-lsp as an executable, with command line flags for logging and lsp protocol transport options

hylo-lsp-test-client

POC client to test the LSP implementation, in a single process, where both client and server is written in Swift.

hylo-lsp-vs-code

VS Code extension with the hylo-lsp-executable as LSP backend.

I also have a fork of hylo with some minor changes to allow the LSP development.
The current POC LSP implementation has the following functionality:

textDocument/definition

Jump to symbol, eg cmd-clicking a symbol

textDocument/documentSymbol

All symbols in a document, VS Code outline view

textDocument/semanticTokens/full

Semantic token syntax based hightlighter (partial)

For the sematic token functionality I am missing AST nodes to build more complete support. Specifically AST nodes for keywords, eg public, fun, etc. I understand these do not need to be stored for normal compilation, but for complete syntax highlighting coverage these would be useful to have. Maybe using some custom parameter as part of AST construction?
Also I have forked the hylo compiler itself with some minor changes, mainly to build hylo compiler as a library, and adding public constructor to SourcePosition.
What are your thoughts on LSP development, have you started some internal effort towards this, or how do you see this work going forward? I would be happy to contribute and continue help developing some parts of the LSP server.
The implementation is currently in a pretty rough WIP state :)
I really hope you continue your effort with Hylo development, and that wider adoption start spreading. It is great that you have a public roadmap on the website as well.
Let me know your thoughts on this!

Ok, nice, i will look into using the introducer, introducerSite, and other references. I do not really need it to be explicitly part of the AST, just as long as it is available somewhere. I just needed some pointers on where to look I guess 🤗
And to be honest, I don't plan on spending a ton of effort on this. But it was a good project to get in depth knowledge of Hylo, and hopefully a nudge in the right direction to get broader adoption of the language.
What I really want is to actually start using Hylo itself. And I realize we are still in a very early phase. But as soon as the compiler, language design, and stdlib, are mature enough I want to be able to start building some application/library using Hylo.
And IDE integration specifically is to me a really important part of making a language productive in the hands of a developer. As a reference, I do a lot of work in modern, cross-platform, .NET environment with C#, and the Roslyn-based LSP is such a night-and-day differentiator compared to not having that level of IDE support.
Additionally, not just for human developers, AI developers will have great usage of LSP tools for code comprehension and navigation. And Hylo could imo be an extremely powerful platform in this context for building next generation applications.
My thoughts on next steps for this LSP initiative:

Get my forks of the dependencies, mainly LangaugeServerProtocol library, merged back to the upstream repositories.
Make sure the hylo-lsp WIP is cleaned up a bit, and make sure others can build and test it out locally.
End user (developer) artifacts. First step make sure there is a build pipeline with a release artifact, eg a .vsix extension archive that can be installed in VS Code. And at later point this could also be published to extension marketplace.
Hylo organization based governance for the lsp, eg migrate to hylo-lang/hylo-lsp repository(?)

Regarding keywords, I have resolved a lot of tokens since last time. But I have not been able to get introducer for ProductTypeDecl, is this not available? For VarDecl I was able to use the outer BindingDecl.
Additionally, are ranges for source code comments available?

But I have not been able to get introducer for ProductTypeDecl, is this not available?

It seems like we don't have one. Please open an issue. I'll implement it when I find some time.

For VarDecl I was able to use the outer BindingDecl.

That's probably the best way to get an introducer. Note that a BindingDecl may introduce multiple variables; all will have the same introducer.

Additionally, are ranges for source code comments available?

No, comments are simply ignored during tokenization. It may be a little cumbersome to add them to the AST.
Perhaps in the long run we may need a different parser to interact with LSP, to produce a concrete syntax tree rather than an abstract one. IIUC that's what Swift does. (see swift-syntax).

I have worked a bit with setting up a release workflow for the vscode extension. I have a first test version available now, if anyone is interesting in trying it out
NOTE: The release build only support Mac Silicon (M1 & M2) at the moment.
https://github.com/koliyo/hylo-lsp/releases/tag/v0.5.0
Download the vsix file and install from command line:
code --install-extension ~/Downloads/hylo-lang-0.5.0.vsix

It is also possible to build locally with the script build-and-install-vscode-extension.sh in the hylo-lsp repository.
Current functionality
Semantic token support, for quite a lot different of nodes types at this point

Document symbol list/outline

Jump to symbol/definition

Error diagnostics for compilation errors

Of course also lots of things also not working well, it is a very early version 😅

I pushed a new version, there were some pretty severe document sync issues in the first release. Getting a lot fewer errors now. Also moved the release to the hylo-vscode-extension repository
https://github.com/koliyo/hylo-vscode-extension/releases/tag/v0.5.2

Thanks a lot for this progress report. It looks absolutely awesome!
I'm sorry I didn't have time to test the extension earlier. It seems that my editor is failing to connect to the LSP server, as all requests report a failure. Any idea of a possible step I may have missed?

Here is a summary with feedback on LSP developmen for Hylo, that probably needs to be considered going forward. At least in longer time perspective. This includes:

Compiler must have mechanisms for when source code is not on disk, In the LSP we get in-memory representation of source code that is not saved to disk, and this needs some updated handling. I have a local patch I will make a draft PR with.
Some concept of packages, either implicit based on directory structure, eg python, or explicit, eg swift.

My current approach is to compile Hylo stdlib + the current active file. So multifile programs does not work in the LSP atm.
The LSP needs to know what files to send to the compiler for parsing/analysis.

Performance overall, and especially type checking.

I know Hylo is very early in development, so it is understandable that the compilation performance is not top priority.
The type checking is really expensive right now, which limit usage in LSP.

At first I used the TypedProgram for basically all functions in the LSP, semantic tokens, symbols, diagnostics, etc

But specifically semantic tokens need to be more responsive than the current type checking performance, and we are talking very small programs here.
I have migrated semantic token analysis and document symbol listing to using AST instead of TypedProgram

This gives huge speedup, but adds some additional heuristics that I would get "for free" with the TypedProgram.

And overall, LSP is very demanding of the compiler, and must be considered from the core to get a top-level experience. Especially regarding incremental parsing/analysis and low latency response. Eg Roslyn C# and swift does really good job with this. But I understand this is not top priority at this stage of the project.

@kyouko-taiga Have you had a chance to test running the extension again? I would be glad to help get you up and running!
I have just rebuilt the LSP with the recent changes to hylo, so it is up-to-date, LSP version is now v0.6.10.
Also, I have managed to get upstream swift LSP development PR merged in LanguageServerProtocol repository, so it is now much easier to get started with LSP serverside development in swift. See https://github.com/ChimeHQ/LanguageServerProtocol/pull/14

I'd very much like to try using the extension with emacs, since that's my primary development environment.

Have you had a chance to test running the extension again? I would be glad to help get you up and running!

Haven't had time to try again yet, sorry for the lack of updates. I will try during the weekend and report here.

I have zero experience with emacs, and I do not think I will be able to allocate time to setting up the emacs integration unfortunately.
The upside of the LSP architecture is that the majority of code and logic is in the portable LSP server, and the IDE integration is a pretty thin interface. The main additional complexity in the VSCode extension is that it does handle dynamically installing and updating the LSP server. This allows:

Download the OS/architecture specific build of the LSP. Alternative would be to distribute all OS binaries in the extension package.
Allow updating the LSP server without deploying a new extension version.
Keep the extension installation minimal, in terms of size and installation time. The LSP server is dynamically installed when first hylo buffer is opened in the editor.

Hopefully we could find another resource in the hylo community that could help integrating into emacs.
Also, the prototype has most of the functionality I wanted to be able to at least inspect and navigate hylo files more efficiently. There is much to be done in the LSP, but I will probably not be working much on this in the near term. I have a small baby at home and very limited time for sideprojects atm 😅
Also, it is very much a prototype, and may need to be redesigned in some very fundamental ways going forward, eg in terms of concurrency. But hopefully it can be used as a starting point!

I have zero experience with emacs, and I do not think I will be able to allocate time to setting up the emacs integration unfortunately.

Don't worry; I didn't expect you to.  Emacs has LSP support built-in.

Sorry for the late, late  reply @koliyo 😔 (and happy new year).
I finally took the time to give another try at your extension, and let me say that is so cool! All features worked, and frankly I think the extension can probably already help writing actual code in its form. So really well done.
Regarding your remarks:

Compiler must have mechanisms for when source code is not on disk, In the LSP we get in-memory representation of source code that is not saved to disk, and this needs some updated handling. I have a local patch I will make a draft PR with.

I saw that PR pass and some exchanges with @dabrahams. It seems to me that the both of you are currently on top of this issue so I won't interfere, but give me a sign if my help is required.

Some concept of packages, either implicit based on directory structure, eg python, or explicit, eg swift.

We have a notion of module and should be iterating more seriously on its design pretty soon. Stay tuned.
In a nutshell, a module is a unit of code distribution, like a library. I think it's larger than what Java would consider a package, which is more like a directory AFAIU. Changes in a single source file may have far reaching consequences in a single module, but less influence on other modules (or none if the modification doesn't touch an exported API).

My current approach is to compile Hylo stdlib + the current active file. So multifile programs does not work in the LSP atm.

The standard library will be a module of its own pretty soon so probably you won't have to compile it anymore. At least you won't have to type check it anymore. I think that you could already implement this strategy in your own driver, but it's likely simpler to just wait that the feature lands upstream.
IR lowering and analysis isn't blazingly fast either. Some parts are certainly parallelizable, but since the IR is mutating it won't necessarily trivial.
Note that there should never be further diagnostics after we've applied mandatory IR passes. In the driver that is after we called lower(program: program, reportingDiagnosticsTo: &diagnostics). So for the purpose of live editing support, you can probably stop your compilation pipeline at this stage.

The LSP needs to know what files to send to the compiler for parsing/analysis.

My hot take is that it should be fine to just send the file being edited, but perhaps I'm too naive. I'll need you to understand why my assumptions may be wrong.

Performance overall, and especially type checking.

Working on it 😅

At first I used the TypedProgram for basically all functions in the LSP, semantic tokens, symbols, diagnostics, etc. But specifically semantic tokens need to be more responsive than the current type checking performance, and we are talking very small programs here.

I think that is the right strategy for semantic highlighting. Building a typed program will be significantly faster once we land a first implementation of modules because you won't have to type check the standard library again. Most of the time you spend type checking "Hello, World!" today is actually time spent compiling Hylo.Int...
That won't fly in the long run, of course, so we have to start considering incremental compilation. I know almost nothing about this technique so I'll have to learn.


Remove banpool documentation

I need to remove the info about banpools from the docs

beemo.gg successfully updated to not have any banpool info


GCC/GCCH support

in testing we seem unable to connect to GCCH, is the application supported in GCC/GCCH?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a9d928d-fab5-99af-105f-86cb0520dcfa
Version Independent ID: ded494e8-1cc3-04bb-fec9-1c44e7231d06
Content: The SharePoint modernization scanner
Content Source: docs/transform/modernize-scanner.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

looks to be hardcoded to sharepoint.com when GCCH is sharepoint.us

Suggest posting this question to the project's GH repo's issue list: https://github.com/SharePoint/sp-dev-modernization/

done https://github.com/pnp/sp-dev-modernization/issues/494


2e58z7a sttp scala fx

Implements http-scala-fx
Implements sttp integration for http-scala-fx

@franciscodr, thank you so much for your review. Hold tight and I'll fix the http retries and the TLD extension warnings.

@franciscodr I think I've addressed all your comments. Please re-review at your convenience.

@raulraja comments addressed. Please re-review at your earliest convenience. I'm creating a task to make a style-guide.


⚠ Samsung has degraded performance

In dc5c3a2, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 3086 ms

Resolved: Samsung performance has improved in 39ad8e7.


[breaking change] Rework the server creation API

Fix #101
Fix #104
The ToSocketAddr trait is specially conceived to be passed to TcpListener::bind, so we should use it directly.
Also, the port 0 seems to be a standard for "a random available port", so there's no need for the with_random_port function anymore.
I went with a public ServerConfig in order to make things explicit. This struct can be extended in the future with things such as client_timeout, ssl (cc #11) or max_clients (cc #26). Users are encouraged to call http instead of new.
Note that I removed the client_timeout parameter because I noticed it was unused anyway.

Thanks! Want me to publish a new version or wait for your other PR?

Wait for the SSL stuff maybe.


Add a script to generate screenshots for visual validation

Add a script that will generate screenshots of the variants' alignment in the IGV browser so that it can be validated. This should be done for all the variants passing filtering. The screenshot should include at least one control.
TODO:

[ ] check for existing implementations and tools
[ ] check if IGV is suitable for this task
[ ] check what scriping language to use
[ ] decide for a format of the screenshots
[ ] decide for a file naming convention
[ ] decide for a folder structure
[ ] Implement the script

Duplicate of #32


VirtualizingWrapPanel does not virtualize

Describe your issue
The wrappanel loads all items at once
<ScrollViewer>
            <ItemsControl ItemsSource="{Binding Items}"
                          ScrollViewer.CanContentScroll="True"
                               VirtualizingPanel.CacheLengthUnit="Item"
                               VirtualizingPanel.ScrollUnit="Item"
                               VirtualizingPanel.VirtualizationMode="Recycling"
                               VirtualizingPanel.IsVirtualizingWhenGrouping="True">
                <ItemsControl.ItemsPanel>
                    <ItemsPanelTemplate>
                        <controls:VirtualizingWrapPanel Orientation="Vertical"
                                                        VirtualizingPanel.CacheLength="40"
                                                        VirtualizingPanel.IsContainerVirtualizable="True"
                                                        VirtualizingPanel.IsVirtualizingWhenGrouping="True"
                                                        VirtualizingPanel.IsVirtualizing="True"
                                                        VirtualizingPanel.VirtualizationMode="Recycling"/>
                    </ItemsPanelTemplate>
                </ItemsControl.ItemsPanel>
                <ItemsControl.ItemTemplate>
                    <DataTemplate>
                        <local:MintingPreview_Control Data="{Binding Data}"/>
                    </DataTemplate>
                </ItemsControl.ItemTemplate>
            </ItemsControl>
        </ScrollViewer>

you can see some duplicate properties as I was trying around. no matter what I try, All memory gets instaltly occupied.
Version Info
Package Version [e.g. 1.5.2]
.NET Version: [e.g. .NET Framework 4.7.2]
OS Version: [e.g. Windows 10 Build 19041.508]

The default CacheLengthUnit is Page. That means when you set the CacheLength to 40, 40 times more items than visible are cached (realized). To solve your problem you could decrease the CacheLength or use the CacheLengthUnit values Item or Pixel.

The problem is that the items control is wrapped inside a ScrollViewer. That breaks the virtualisation, because the scrolling can not be handled by the VirtualzingWrapPanel. To solve your issue remove the ScrollViewer and make sure that the ItemsContol height ist not infinity.
Also keep in mind that the default CacheLengthUnit is Page. That means when you set the CacheLength to 40, 40 times more items than visible are cached (realized).

Thank you, i managed to use the listView from the sample application. This works.
There seem to be some bugs (probably misuse from my side)
But at least it initiates correctly and doesnt take 30 seconds to load 2 gb into ram.
the last issue that Im facing is that the memory constantly goes up. for example when I scroll a couple of lines down, the memory increases (expected)
When I scroll these lines up again, The memory increases further. So, either the elements are not recycled properly or the resources are not released properly.

i started to set the settings manually.
I think it was the recycling setting (i changed too many settings at once :P)
The issue is resolved. Thank you.


Enable WebSockets through nginx configuration

Without this, connection attempts fail with "426 Upgrade Required". Resolves #352.

Awesome; thanks!

Now I'm curious why this worked before...


IndexoutofBoundexecption

Hello,
Many thanks to you for deploying the new jar with enhancement... kudo :)
I used the new tool to upload my csv to kiban and I ended up with the following error after 100 % completed.
java.lang.IndexOutOfBoundsException
at java.base/java.nio.Buffer.checkIndex(Buffer.java:669)
at java.base/java.nio.DirectByteBuffer.get(DirectByteBuffer.java:265)
at com.codingchili.Model.CSVParser.readRowCount(CSVParser.java:70)
at com.codingchili.Model.CSVParser.setFileData(CSVParser.java:46)
at com.codingchili.Controller.Website.lambda$parse$11(Website.java:176)
at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$1(ContextImpl.java:273)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:844)
When i try to upload the same using api to elasticsearch, i am able to upload ( just a small chunk of data for testing ).
I am not sure, is this something you have to look for, but I am not good in java or rather can understand and turn on the switch which is causing this error.
Can you share some thoughts on the above message?

Hi,
I don't think I will be able to share the file. The file size is huge and it's a consolidated AWS billing csv (21G).
All I am doing is uploading that file into the elasticsearch which runs on AWS (m5x.large) instance. I am using Indexing as sample-*, mapping as default ( just to test) and row as 3, then upload the file.
The actual process goes for some time (approx 4 hours) to upload the content to the elasticsearch. As soon as it reaches 60 to 70 % I get this error. Any solution to overcome this is of great help.
I am using the latest jar 1.3.1 with basic HTTP configuration on elasticsearch.

Hi,
I will generate some larger files and try to reproduce the issue.
There is a hard cap on ~16kB of data for each row.
How much data is there per row approximately?

wow, that was quick.
Sorry that I am not able to submit what you requested. Now, what's next? any enhancement needed or just a tweak in configuration is enough?

How much data is there per row approximately?
it's huge and it almost occupied the entire excell rows.

I have found some issues with the current implementation.
We are using memory mapped files, which has a limit of 2GB per map.
So for really large files, we need to stripe a bunch of maps.
I implemented the striping but I need more time to verify and test the performance.

I increased the per-row buffer to 512kB, this should be enough unless there are uncompressed images in the data. Will continue testing tomorrow.

Hello,
we should now be able to handle large CSV files more effectively and with less errors.
Released as 1.3.2.
https://github.com/codingchili/parser-excel-elasticsearch/releases

Hey,
Now that I am ending up with a different error ColumnsExceededHeadersException.
com.codingchili.Model.ColumnsExceededHeadersException: Encountered too many values (32) on row 1, expected to match headers (31).
at com.codingchili.Model.CSVParser.process(CSVParser.java:143)
at com.codingchili.Model.CSVParser.readRow(CSVParser.java:203)
at com.codingchili.Model.CSVParser.initialize(CSVParser.java:101)
at com.codingchili.Controller.Website.lambda$parse$11(Website.java:182)
at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$1(ContextImpl.java:273)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:844)

the total file-upload size is 28GB.

I found some more issues with the implementation. We are now ignoring any CR line endings and rely on LF only, fix exists in 1.3.3 - reproduced and verified with CSV files from https://support.spatialkey.com/spatialkey-sample-csv-data/


Use with cordova // Uncaught RangeError: Maximum call stack size exceeded

Hello
i would to use Flipster in a Cordova project,
in my index.html are included jquery, then flipster
<script type="text/javascript" src="cordova.js"></script>
<script type="text/javascript" src="js/vendor/jquery.min.js"></script>
<script type="text/javascript" src="js/vendor/jquery.flipster.min.js"></script>

I create flipster instance with
$('#coverflow-container').flipster({});
If I only preview my page without cordova.js, flipster works.
But if i run my project with cordova, instanciation of flipster make an error :

Uncaught RangeError: Maximum call stack size exceeded

I know flipster is the problem, because when i remove the instanciation, the problem does not appear anymore.
I tried to make the instanciation before or after the "deviceReady" event of cordova, but it dose not change the problem...
Have you an idea of this ?
Thanks
David

I don't know that I've heard of Cordova before. Is this the Cordova you're using?

@shshaw : yes it is !

I am facing the same issue not while using it in Cordova though.
Also reported here
http://stackoverflow.com/questions/34081441/uncaught-rangeerror-maximum-call-stack-size-exceeded-with-flipster

Very strange. I'll look into this further. If you have any more information
(browsers affected or a live demo) that would be greatly appreciated.
On Thu, Feb 11, 2016 at 2:09 AM Aniruddh Bagalkot (BK) <
<EMAIL_ADDRESS>wrote:

I am facing the same issue not while using it in Cordova though.
Also reported here
http://stackoverflow.com/questions/34081441/uncaught-rangeerror-maximum-call-stack-size-exceeded-with-flipster
—
Reply to this email directly or view it on GitHub
https://github.com/drien/jquery-flipster/issues/74#issuecomment-182757871
.

Sorry, it seams it was my mistake, it's working now very fine!
Just I added background-color because without stays a small corner from images

@kulli2000 Are you referring to issue #74 or issue #77?
On Thu, Feb 11, 2016 at 7:38 AM kulli2000<EMAIL_ADDRESS>wrote:

Sorry, it seams it was my mistake, it's working now very fine!
Just I added background-color because without stays a small corner from
images
—
Reply to this email directly or view it on GitHub
https://github.com/drien/jquery-flipster/issues/74#issuecomment-182867532
.

@shshaw : #77 - thank you

Same issue here but when loaded via a directive from angularJS.

Merging with #79 which has more detail about the possible cause. This is all related, no doubt.

Fixed in 1.1.1. If no width is given, a setInterval is run every 500ms to trigger the resize event again instead of running in an infinite loop.
If you want it to run right away and know when it will be visible, you can simply call the jump method with no parameter and resize will be triggered as usual.
Don't run this code with the last version of Flipster, it will crash your browser, but is perfectly fine in 1.1.1!
$('body ').hide();

var flipContainer = $('.flipster').flipster();

setTimeout(function(){
   $('body').show();
   flipContainer.flipster('jump');
},1800);

Thanks !


Potential issue or different implementation with --limit-upload

When uploading data (at least to B2) using --limit-upload 90 (in kB), data flows are bursting to sometimes 1MiB/s or higher, with long delays typically between each large burst.
I suspect the --limit-upload was done by averaging upload data over time.  That would result in 90kB/s over time, but there is no rate limiting of the actual upload itself in real time.  Is this a correct understanding of how it was implemented, or was it supposed to work another way and therefore a bug?
There are other mechanisms by which I could see a more smooth data flow, but it'd require modifications to the firewall rules or a tool to shape restic network traffic.
Restic version details
restic 0.8.0 (b9441a1)
compiled with go1.9.2 on linux/amd64
Output of restic v0.80
(incomplete -- lots of data to upload -- still in progress)
scan [/some/dir /some/dir]
[0:06] 17482 directories, 139992 files, 1.011 TiB
scanned 17482 directories, 139992 files in 0:06
How did you run restic exactly?
(removed some specific directories -- not relevant)
/usr/bin/restic --cache-dir=/some/dir/restic-cache --limit-upload 90 backup --one-file-system /some/dir /some/dir --exclude /some/dir --exclude /some/dir
What backend/server/service did you use to store the repository?
Backblaze B2
Expected behavior
Smooth, consistent data flows according to --limit-upload.  Expected doesn't imply it is what was intended by the developers.
Actual behavior
Bursting, with long delays between bursts
Steps to reproduce the behavior
Just run the command with a lot of files :)
Do you have any idea what may have caused this?
I suspect the implementation of the upload limit was done over time and does not actually limit rate.
Do you have an idea how to solve the issue?
Implement rate/throughput limit differently
Did restic help you or made you happy in any way?
This is a great tool for cloud backup.

Yeah, thanks for bringing this up again. We're aware of the issue, which is on the boundary between restic and the library (blazer) we're using to access B2.

This will be addressed in #1511, which limits the bandwidth at the http.RoundTripper layer.

You can try the branch improve-http-limiting


Updated copy of camera access prompt

Fixes https://github.com/artsy/collector-experience/issues/771
The camera access prompt now reads "Photos will be used to gauge the quality of the work you are submitting" instead of "Used to be able to select photos of artworks that the collector wishes to consign."
Also, I'm using a higher version of Cocoapods. I'm happy to leave out the pod-related changes if they're unnecessary or if there's a reason we're using v1.2.1.

          1 Error

:no_entry_sign:
No CHANGELOG changes made

          1 Warning

:warning:
Needs testing on a Phone if change is non-trivial

  Generated by :no_entry_sign: Danger

The CP version is fine, because we actually updated it recently but not committed the new file changes, I guess 👍
In the future, it would be helpful to keep the changes in distinct commits, though, so one for changing the copy and one for committing the CP related changes.


leap: fix YAML syntax issues (and our RTD build by doing it)

@jbusecke there were YAML syntax issues in a recent change by the use of &profile_list_profile_options_image and *profile_list_profile_options_image etc.
When & is used, its an "anchor", so other fields can reference it with * to re-use that value. The issue was duplicatin of anchors.
I've fixed it by de-duplicating content - but in doing so also added the image choice leap-pangeo-edu to the dev profile - I think this may be acceptable though as its just something you can opt to ignore.

Ah thanks for fixing this @consideRatio


App launch fails occationally

When launching the emulator in Android Studio, the app may fail to launch.
This is the prompt:
ProcessException: Process exited abnormally:
cmd: Failure calling service activity: Broken pipe (32)
  Command: C:\Users\X\AppData\Local\Android\Sdk\platform-tools\adb.exe -s emulator-5554 shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-dart-profiling true --ez enable-checked-mode true --ez verify-entry-points true --ez start-paused true com.something.sw_app/com.something.sw_app.MainActivity

I just updated lots of stuff in Android Studio. Might be that the emulator is outdated and needs to be updated to work with the new setup.

Did a major rework. Seems to be fixed now as of https://github.com/andreped/DSWS/commit/6638c3b95ebffff796e6503d5d1b0a6579413ab6


select range/ slice with method='nearest'

It would be nice to support nearest neighbour selection with a slice like so: ds.sel(lat=slice(30, 50), method='nearest'). Maybe the step has to be disallowed.
Or is there another possibility how to achieve this functionality?
use case:
Often I look at a region with different data sets that don't have the same resolutions. It would be nice to be able to select the closest-matching region with an easy syntax.

I did a short hack - not sure if it is of any help...
#420
import xray
temp = 15 + 8 * np.random.randn(20)
lat = np.arange(0, 20)
ds = xray.Dataset({'temperature': ('lat',  temp)}, coords={'lat' : lat})
ds.sel(lat=slice(1.2, 5.9)) # lat = 2 3 4 5
ds.sel(lat=slice(1.2, 5.9), method='nearest') # lat = 1 2 3 4 5 6

ds.sel(lat=slice(30, 50)) will work to select all values inside interval [30, 50] already -- the values don't have to match exactly. This should probably be noted in the docs.
This inconsistency is definitely a little annoying, though -- I don't see any harm in support nearest neighbor lookups for the bounds.

I just clarified this in the docs: http://xray.readthedocs.org/en/stable/indexing.html#nearest-neighbor-lookups
Let me know if that makes sense -- hopefully it's clear now that you actually don't need method='nearest' most use cases. As for your hack, I'm reluctant to support method='nearest' with label based slicing without the upstream functionality in pandas -- which would need to go in https://github.com/pydata/pandas/blob/be5ad4abcb9d8385110831edd138c1f644fe83ae/pandas/core/index.py#L2457

ok thank you for looking at it and the clarification.


update version to 1.23.2, prepare for release

Codecov Report

Merging #6 (a3066ac) into main (fdb1dac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main       #6   +/-   ##
=========================================
  Coverage     71.19%   71.19%
  Complexity      194      194
=========================================
  Files            25       25
  Lines           934      934
  Branches         69       69
=========================================
  Hits            665      665
  Misses          210      210
  Partials         59       59

Flag
Coverage Δ

unittests
71.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: Disable possibility of vault creation with chain name or an url

LGTM on web and extension

Lgtm

LGTM on web and extension


Rule no-broken-links infinite loop

Steps to Reproduce:

Activate the rule no-broken-links
run sonarwhal http://edge.ms --debug
See that https://www.xamarin.com/ is requested infinitely.

After a first look, the requester get a status code 302 from https://www.xamarin.com/ and the header Location is / so the new url generated is the same.

I can confirm this bug.


Updated Ruby and Rails versions

Updated Ruby version from 2.2.0 to 2.2.5; updated rails version to 4.1.16
This change will likely improve the CodeClimate GPA given that it flagged versions 4.1.7 of several gems with issues.

FYI @jhsu802701, I rebased this branch to include a fix for #50 that I recently added to master. I have since been able to successfully deploy this branch to stage, and everything looks great. Merging.
And FYI for anybody who cares about Puma and deployments, this change does require a manual cap puma:stop and cap puma:start. cap puma:restart (which Capistrano currently does on a deployment) restarts the threads of the Puma process, not the process itself. So, environmental changes, like changes to the version of Ruby, are not applied using a cap puma:restart.

This has been deployed to production.


[KYUUBI #4053] Support GetTableTypes for trino fe

Why are the changes needed?

We intend to introduce Trino FE at https://github.com/apache/kyuubi/issues/3901, This issue aims to support GetTableTypes as subtask.
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @ulysses-you

thanks, merging to master


Large amount of items dropping resulting in instant bans

So multiple people confirmed that if you pop filled chests/double chests, you receive a ban right away. The amount of dropped entities seems to be the reason.

We could simply zero out the DROPPED_ITEM line in the config. I'm a little confused, because tl;dr item stacking, popping a chest should be at most 54 new DROPPED_ITEM entities.

It confused me as well, but multiple people told me completly independent from each other.

Oh, but of course. The issue wasn't the popped chest. This is a false correlation. Dollars to donuts its because they are in a chest vault, surrounded with factories and other auto-machines.
Email me the names of the people who PM'd you, just got a dump, I'll be filtering and sanitizing in a moment but I can prioritize these sorts of "odd" reports.

Sent

Just a note: never did confirm this; standing by my theory as a number of folks during that event were kickbanned due to vast numbers of chests (1k+) in their immediate vicinity. Simply coincidence that it occurred right after popping the chest.


Code

Hello my dear author, I am interested in your article and would like to get the code of the article. Hope to get in touch with you if it is convenient for you.My Email<EMAIL_ADDRESS>

Thanks for focusing on our work.
The code is released now !


hwmv2: boards: update riscv32_virtual board to HWMv2 scheme

Just a sneak peek

Can you rebase and update please?

superseded by #69578


Update role-based-access-control-tenant-admin-access.md and Screenshot

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mbsnl sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@andredm7 - Please review the proposed changes.  Thanks

@GitHubber17 - Please change the H2 from "How to use elevateAccess for tenant access, using Azure Active Directory admin center" to: How to use elevateAccess for tenant access with Azure AD admin center.
#hold-off

#sign-off


Quiver with variable arrow size

It would be nice if the quiver arrow head sizes could be made relative to their sizes. So there are just dots when the velocity is very small

You mean something like:
using AbstractPlotting, Makie
using ImageFiltering, LinearAlgebra

x = range(-2, stop = 2, length = 21)
y = x
z = x .* exp.(-x .^ 2 .- (y') .^ 2)
scene = contour(x, y, z, levels = 10, linewidth = 3)
u, v = ImageFiltering.imgradients(z, KernelFactors.ando3)
n = vec(norm.(Vec2f0.(u,v)))
arrows!(x, y, u, v, arrowsize = n, arrowcolor = n)

Simply great !
I wonder it could be included in the examples because it is the default behavior in matlab or matplotlib and It is not that easy to figure out (at least for me).
Thanks a lot

Perhaps, for the basic (atomic) plotting functions at least, we could add attribute descriptions to docstrings?


Remove 'print' instrinsic, add 'print' implementation-defined built-in routine to the Global object

print (undefined);
print (null);
print (true);
print (false);
print<PHONE_NUMBER>3);
print (-Infinity);
print (Infinity);
print (NaN);
print (0);
print (-0);
print('str\u0013\u0010 str')
print('str\u0101 str')
print ({});

outputs:
undefined
null
true
false
123.23213213
-Infinity
Infinity
NaN
0
0
str str
str\u0101 str
[object Object]

See also: #499

looks good to me

@galpeter, thank you!
I've updated PR to fix length of the lines.

Good to me


No informative logging available for http services and authentication (jwt/oauth2)

Description:
I was trying to implement the following scenario.

Use WSO2 IS to obtain a JWT
Use that JWT to authenticate the following http service

First, due to wrong configuration at IS side, my JWT authentication failed. Then, the scope validation failed since my scope claim was an array and there's a limitation in beta 2. In both cases, I had to do trail and error blindly for a long time to fix the issue since there wasn't any log output. IMO, logs are needed to investigate and fix configuration issues.
As per the observation, when OAuth2 authentication was used, it atleast printed that the validation failed (just mentioned that calling introspection endpoint failed). But the JWT validator did not print anything.
@http:ServiceConfig{
    auth: [
        {
            jwtValidatorConfig: {
                signatureConfig: {
                    certFile: "./is.cert"
                },
                scopeKey: "groups"
            },
            scopes: ["manager"]
        }
        // {
        //     oauth2IntrospectionConfig: {
        //         url: "https://localhost:9443/oauth2/introspect",
        //         clientConfig: {
        //             customHeaders: {"Authorization": "Basic YWRtaW46YWRtaW4="},
        //             secureSocket: {
        //                 // disable: true
        //                 cert: "./is.cert"
        //             }
        //         }
        //     },
        //     scopes: ["openid"]
        // }
    ]
}
isolated service /products on new http:Listener(8080) {

    private mysql:Client? cl = ();

    resource function get .() returns Product[]|error? {
        mysql:Client mysqlClient = check self.getClient();
        stream<Product, error?> prodStream = mysqlClient->query("select id, product_name as productName, price, currency from products", Product);
        Product[] products = [];
        error? e = prodStream.forEach(function(Product p) {
            products[products.length()] = p;
        });

        if e is error {
            return e;
        }

        log:printDebug("Found products", products = products);

        return products;
    }
}

Appreciate if this can be addressed soon.
Steps to reproduce:
See description
Affected Versions:
SL Beta 2

@IMS94 Is this about not having proper tracelogs to trace the internal requests and responses? If so, that is brought back for beta 3 via https://github.com/ballerina-platform/module-ballerina-http/pull/528.

Talked to @IMS94 his requirement is solved 50% by the HTTP tracelogs. Rest should come from Auth error handling flow.

As per the offline discussion with @IMS94 the developer experience for authorization phase can be further improved with adding debug logs. That need to be addressed.


Fix user relationship endpoint for sharkey

Sharkey returns smaller set of data than Mastodon when fetching user relationship. To properly decode its responses additional fields needed to be marked as optional.
I considered adding default values instead of optional but ultimately decided that it'll be better to leave that up to clients.

Testing it a bit further I now see that it always returns the same set of details for me… No matter the account I test against. Before I assumed that it's correct because when I followed someone it returned correct info. But now I see it was only as a response to follow call. Something else must be incorrect
@technicat Is this endpoint working for you correctly?

yeah I'm seeing the same thing

I can't believe I haven't noticed this problem before (maybe it was introduced recently? I think there's been some rewriting of their Mastodon API in progress).
https://activitypub.software/TransFem-org/Sharkey/-/issues/557


Fix syntax in publish file for core images

Resolves formatting error in core images only.

/assign bkatyl


How to set specific routes to load local HTML files in Nuxt.js without recompiling?

Describe the feature
How to avoid route conflicts in Nuxt.js projects that combine SPA and SSR?
How to combine existing SPA and SSR projects?
In a project that combines SPA and SSR, there may be route conflicts when accessing certain routes. To resolve this issue, one solution is to set a specific path in Nuxt.js router for loading an HTML file while avoiding conflicts with other paths. For example, the path "htttp://xxx.com/app" can be used to load the HTML file, while all other paths will be rendered through the Nuxt.js router.
Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[ ] Read the contribution guide.
[ ] Check existing discussions and issues.

If you want to be included in the vue route -> use v-html to render the content of the fetched html data
Otherwise - use .html resource in public dir or return html response from server endpoint(nitro)


Add LINA-BUSD Pool

Vault - 0x922f8807E781739DDefEe51df990457B522cBCf5
Strategy - 0x1198f78efd67DFc917510aaA07d49545f4B24f11
Pool ID - 69
LP - 0xeB325a8ea1c5abf40c7ceAf645596c1F943d0948

Strat needs to use CAKE-BUSD-LINA routing, no liquidity for LINA-BNB

ZEE BNB
Vault - 0x29C4C22eC7dF7e936Cb3e6C4A7E5eAE751C7d86B
Strat - 0xc34b9c9DBB39Be0Ef850170127A7b4283484f804
PoolID = 74
LP - 0xB5Ab3996808c7e489DCDc0f1Af2AB212ae0059aF
BRY BNB
Vault = 0x578C066b5c7289f8Ba7c4DB43c110F19D7c51E03
Strat = 0xF9eBb381dC153D0966B2BaEe776de2F400405755
PoolId = 75
LP - 0x5E3CD27F36932Bc0314aC4e2510585798C34a2fC

@MirthFutures please check preview, it's not working
Preview: https://beefy-app-git-fork-mirthfutures-master.beefyfinance.vercel.app

@MirthFutures please check preview, it's not working
Preview: https://beefy-app-git-fork-mirthfutures-master.beefyfinance.vercel.app

Working now.

@MirthFutures please check preview, it's not working
Preview: https://beefy-app-git-fork-mirthfutures-master.beefyfinance.vercel.app

Working now.

ok, last thing missed is harvest() call for all vaults, to make sure routing is good.
i've no idea where cake-busd liquidity is coming from? is it safer to use cake-bnb-busd-lina?

@MirthFutures please check preview, it's not working
Preview: https://beefy-app-git-fork-mirthfutures-master.beefyfinance.vercel.app

Working now.

ok, last thing missed is harvest() call for all vaults, to make sure routing is good.
i've no idea where cake-busd liquidity is coming from? is it safer to use cake-bnb-busd-lina?

Deployed new strat with a new vault and tested harvest.
Vault = 0x149f3dDeB5FF9bE7342D07C35D6dA19Df3F790af
Strat = 0x66be88070D38d9F8eE96913aeDF1709ED35aB29A


Docs Feature Request: Serving from /dist

Quick Ask
Please add something in the CLI docs that explains how to run the app from the /dist folder. Something that explains how to install lite-server and run it on that folder as a validation or gut-check.
Why? This will help skeptical folks (like me) validate that the /dist files will indeed run properly. The existing ng serve commands run in memory.
Details
from my chat with @filipesilva ...
When I hear build i think that we are going to process the files and prepare them to be served. But not actually serve them. And I think there is a very clear distinction between a dev and prod build. and each of those could be either on disk or in memory.   I’m not suggesting these flags, but I am using them to further explain ...
#these dont exist .... just for clarification on how i was thinking ...
build —dev —in-mem
build —dev —disk
build —prod —in-mem
build —prod —disk

then when i serve, it gets interesting …. some tools consider serve as just serving. some consider it as building and serving. For us we have …  ng serve which builds a dev build in memory and serves it. then we have ng serve —prod which builds a prod build in memory and serves it. Always in mem.
If we wanted, we could have ...
#these dont exist .... just for clarification on how i was thinking ...
ng serve —dev -in-mem
ng serve —dev -disk
ng serve —prod -in-mem
ng serve —prod -disk

again, im not suggesting all 8 of these. just thinking out loud
The way it actually works , we only have these …
ng build

#prod build copied to /dist folder
ng build —prod

#dev build in memory and served
ng serve

#prod build in memory and served
ng serve —prod

I think those are fine … but I do see myself wanting to try a serve off disk … but we have no way of doing that with CLI. And I think it is perfectly fine to not include this in the CLI ... as long as we explain in the docs how people can run it on their own with something like http-server or lite-server.
cc // @Brocco @wardbell

I propose we also add to the docs that when you run ng serve that this is entirely in memory, and not files in dist are affected

Or notify the user at the terminal when they run the command?


ISPN-14290 fix ldap yaml config example

https://issues.redhat.com/browse/ISPN-14290
Remove apostrophe from the ldap config example
Needs backport to 14.0.x and 13.0.x

Hi @tristantarrant, can I have your ack on this PR?

Merged, thanks


Add pandas extra for google-cloud-bigquery to pick up missing pyarrow

resolves #1152
Problem
google-cloud-bigquery==3.20 added pyarrow>=3.0 as a dependency for the pandas extra and we are not declaring the pandas extra. Either we are using functionality that requires the pandas extra and were not aware or this is a required dependency and not an extra dependency.
Solution
Install google-cloud-bigquery[pandas]>=3.0,<4.0
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

Integration tests were skipped, I think because the changed file (setup.py) did not trigger the run. We need to fix that, but for now they are running here: https://github.com/dbt-labs/dbt-bigquery/actions/runs/8460917158.

Hey Guys!
Looks like you have missed the backport for 1.5.X


Avoid panic when getting EntityCommands in hierarchy

Lightyear seems to panic when despawning children with an error message like:
thread 'Compute Task Pool (6)' panicked at lightyear/src/shared/replication/hierarchy.rs:111:30:
Attempting to create an EntityCommands for entity Entity { index: 720, generation: 1 }, which doesn't exist.

This PR adds a test case and attempts a fix.

Yeah I'm also a little confused why actually, but I have seen quite a few similar panics from my own code so I think the answer is no.


Automated cherry pick of #3749: hugepage fix

Cherry pick of #3749 on release/2.13.
#3749: hugepage fix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.13@74a6040). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.13   #3810   +/-   ##
==============================================
  Coverage                ?   6.94%
==============================================
  Files                   ?     499
  Lines                   ?   84250
  Branches                ?       0
==============================================
  Hits                    ?    5850
  Misses                  ?   77904
  Partials                ?     496

Flag
Coverage Δ

#aFlag
6.94% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guestdrivers.go
18.18% <ø> (ø)

pkg/compute/guestdrivers/kvm.go
3.38% <0%> (ø)

pkg/compute/models/guest_actions.go
0% <0%> (ø)

pkg/compute/guestdrivers/azure.go
8.19% <0%> (ø)

pkg/compute/guestdrivers/base.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a6040...dd6ee05. Read the comment docs.


The use of PSBT in the spec would have big advantages

I think the spec could dramatically simplified, as well as allow other existing tooling to interact more easily.
Right now in the messages are exchanged:
In Offer:

Pubkey
Funding inputs
Change
Total collateral
FeeRate

In Accept:

Pubkey
Funding inputs
Change
Total collateral

All of those informations could be replaced by two partial funding PSBTs (one in Accept and One in Offer) which can then be combined for having the funding PSBT.
Since Offer does not know the address of the funding before hand, we could just have a dummy address in the protocol acting as temporary.

Any Bitcoin Wallets with PSBT features will have the capability to create those partial PSBTs out of the box without any change.
This allows additional flexibility for the parties to bundle a bunch of payments in the funding
Scaling to multiple party is easy. (everyone do their funding PSBT with their favorite wallet and share between themselves)
This allow each party to decide how much fee to fund to the funding transaction.
The remove the need of specifying in the protocol how to exactly calculate the weight of the transaction.

There is some check on the validity of the PSBT that need to be done, but those should be relatively minor.

In bitcoin-s we actually do use PSBTs as the back-end data structure when dealing with DLC Txs, but the main reason they haven't been included in the spec is because they can get massive (which is the main reason I've never been a huge fan of the spec).
I am totally open to the idea of adding PSBTs to the spec but I'd be very concerned about a significant increase in the size of P2P messages, especially seeing as each party need not verify the entirety of the previous txs associated with funding inputs that aren't theirs (a more minimal verification is all that is required). If I turn out to be wrong on this front then I'd be happy to rework things to use PSBTs. (I'm also assuming that the clunkiness of PSBT is the reason lightning doesn't use them (not even in dual funding proposal))

The previous transactions, they don't need to be included at all, legacy or segwit funding, only the witness_utxo is enough.
I don't believe dismissing PSBT for the corner case of making a big funding tx happen in practice. (And if it happens, nothing really bad happen)

To be clear, it does not need to be done for next week. But I think that if this is meant to be a standard, the participants should have the maximum flexibility and the standard should take minimum assumption over how the  funding transaction look.
If say both lightning and bitcoin-s were using PSBT, then it would be possible out of the box to make a transaction funding a channel and making a DLC at the same time with standard CLI.

I am reading https://github.com/discreetlogcontracts/dlcspecs/pull/57/files
I think that using PSBT will get rid of all the "expected weight" calculation.

I think even using PSBT doesn't save you to compute weight and fee calculation as every participant need to agree on feerate to avoid a free-rider behavior from the lowest-feerate contributor. If you a fair fee model, you need to track the weight of each party contribution and ensure such contribution commit to the negotiated feerate.
Note also, IMO we need to agree on input/output order otherwise we need to sign every pair as SIGHASH_SINGLE, which is a malleability vector and make pinning easier. And you don't want unconfirmed input.
With regards to flexiblity/multi-party I expect than supporting the LN's dual-channel proposal will give us all these advantages. And I think we would like to avoid diverging from then to facilitate offchain support in the future.
If you want the gain of PSBTs, nothing prevent you to have an interface between your DLC stack and your PSBTs signers. That way you can build a DLC funding between different parties and appear as one participant in a DLC flow.

Closing this one. Using PSBT in the protocol seems controversial.
And @nkohen seems to have something in the pipe so users don't have to agree on complicated algorithms to evaluate transaction size.


docker download error

Expected behavior
(HTTP code 500) server error - {"message":"Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:58634-><IP_ADDRESS>:53: i/o timeout"}
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

Please make sure that you're on a stable connection and use a solid DNS such as Google DNS.


I should be able to example code when I am on the resource details page

As an OSS Concourse User when I go to the resource details page
I can see example code on 5 of the resources (engineers discretion to pick 5 examples from high quality readmes)
So that I can better understand how the resource works and if it meets my requirements
Acceptance Criteria
When I go to the resource details page of one of the 5 chosen resources
I see example code for the resource

We added single snippet usage/example from the readme to resources.yml for this resources

time
pool
bosh errands
cloudformation

We had some issue finding this kind of snippet, with both resource definition and use in the job, so we limited to 4.
A lot of resources don't define a snippet that we can just copy to put in the example field, for example the git-resource has 3 different snippet for resource definition, get, and put.

@carlo-colombo @monika-hrda
Accepting
Thanks,
Olwyn


Extend ruff formatting?

We might want to consider extending our ruff linting to cover:

[ ]  "UP": pyupgrade and pyupgrade settings
[ ]  "D":   pydocstyle and pydocstyle settings
[ ]  "ANN": flake8-annotations and flake8-annotations settings
[ ]  "PTH": flake8-use-pathlib

suggested here: https://github.com/nsidc/earthaccess/pull/372#discussion_r1410264309 by @jhkennedy and supported by @mfisher87

PyUpgrade is one of my favorite rulesets, but we'll need to set it up with target-version of 3.8 to avoid upgrading our code out of compatibility with our target Pythons :)