fix packaging of FSharp.Core and Paket/Paket.Bootstrapper as tool

fixes for packaging and build script
build script

publish exe in bin/net461 and bin/netcoreapp2.1. Do not use bin_netcore anymore.
pack nupkg in temp

for Paket.Core, is done by paket pack only
for Paket/Paket.Boostrapper is done by dotnet pack, because are .net tools

.NET Core Sdk is assumed to exists always (the sdk is always installed because
needed for build), so that simplified a bit the build script
use dotnet test to run tests, remove nunit-console

Others

run tests in netcoreapp3.0 not netcoreapp2.1, because netcoreapp3.0 is bundled with sdk
run paket boostrapper unit tests too in the RunTests target
add SkipTests build script parameter to skip all tests (both unit and integration)
in travis use xenial with .net core 3.x preinstalled
workaround for dotnet test hang on travis (ref microsoft/vstest#2080 )
add boostrapper to appveyor artifacts

remove dotnet-mergenupkg
when Paket and Paket.Boostrapper are donet pack'd with PackAsTool=true property (to pack as .NET Tool) these will include the merged paket.exe/paket.boostrapper.exe inside the package in the tools dir.
The PackAsTool=true will also force to target netcoreapp only, because net461 is not supported.
In development these projects (Paket/Paket.Boostrapper) continue to target both net461 and netcoreapp2.1
no need to dotnet mergenupkg the Paket.Core package, because now it multitarget
correctly (it's only one package)
fix duplicated netstandard tfm in Paket.Core
Paket.Core
set min version of dependencies, so are set on package deps set min version constraints for dependencies, so are set in the nuspec generated by paket pack for FSharp.Core
Otherwise, dotnet restore of FSharp.Core use really old version of Newtonsoft/etc who may not work on .NET Standard.
For example newtonsoft was restored as v6.x who support only net461 (valid for netstandard, but generate warnings and fails on .net core)

bump mono.cecil to stable 0.11 (who support netstandard2.0)

Paket as tool
run as dotnet paket

workaround for transitive of FSharp.Core not pulled when packaging as PackAsTool
copy pdbs of package references into Paket tools package allow to get meaningful stacktraces also for deps (a bit bigger size but is worth it)
remove binding redirects from netcoreapp, leave it only in net461
no need for xml inside tool nupkg
add package metadata, because tool use dotnet pack not paket pack
add release notes to the package, who is created with dotnet pack no paket pack`

Paket.Bootstrapper as tool
run as dotnet paketbootstrapper

dotnet tool doesnt allow command with dot (.), use paketbootstrapper instead as command name (exe name is the same)
copy pdbs of package references into Paket tools package allow to get meaningful stacktraces also for deps (a bit bigger size but is worth it)
add package metadata, because tool use dotnet pack not paket pack
add release notes to the package, who is created with dotnet pack no paket pack`

@forki i'll need to check the full run of integration tests in ci to see if ok

This PR is already big enough.
I'll leave MS sourcelink for next PR.
i checked the pdb with sourcelink test and seems ok

i tried to add a smoke test to dotnet tool install the package, but i failed to do it safely (without cache).
the --no-cache doesnt work (because c:\users\%USERNAME%\.nuget\packages is a source, not a cache, go figure, ref https://github.com/NuGet/Home/issues/5619 )
i tried use a nuget.config like
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <config>
    <add key="repositoryPath" value="C:\temp3\clientpr\packages\" />
    <add key="globalPackagesFolder" value="C:\temp3\clientpr\packages\" />
  </config>
  <packageSources>
    <!--To inherit the global NuGet package sources remove the <clear/> line below -->
    <clear />
    <!-- <add key="nuget" value="https://api.nuget.org/v3/index.json" /> -->
    <add key="pr" value="c:\temp2\feedpr\feed" />
  </packageSources>
</configuration>

the globalPackagesFolder setting does the trick and the package is saved in that dir instead of the global nuget cache/source, running
dotnet tool install paket.bootstrapper --version 5.238.1 --no-cache --configfile nuget.config -v n

is also download, added to .config and success message.
You can invoke the tool from this directory using the following commands: 'dotnet tool run paket' or 'dotnet paket'.
Tool 'paket' (version '5.238.1') was successfully installed. Entry is added to the manifest file C:\temp3\clientpr\.config\dotnet-tools.json.

But doesnt work
C:\temp3\clientpr>dotnet paket
Run "dotnet tool restore" to make the "paket" command available.

because search in global nuget cachen and no option in dotnet tool run to specify another.
le sigh

something is fishy because the Paket package doesnt contains the Mono.Cecil.dll, checking that

green. ready to merge?

Really near but not.
I don’t see mono.cecil is the tools directory if the Paket package. Trying to understand why

is it ILMerged?

is it ILMerged?
@forki not, that's for the netcoreapp2.1 published as FDD who is not ilmerged.
I expect the dll inside the publish dir.
Dunno if is a bug, meanwhile i work arounded.

Let me rerun some tests locally before merge, but afaik should be ok if green, no more known issues

i rechecked locally:

Paket.Core in a net461/netcoreapp2.1 project
Paket as local tool (dotnet paket)
Paket.Boostrapper as local tool (dotnet paketboostrapper), but ihmo is useless

all ok afaik.
There are misc fixes/enhancement documented in the PR description, but should all be ok
@forki so if green, merge it! :shipit:

Can we use bootstrapper as global tool? In magic mode?
Enrico Sada<EMAIL_ADDRESS>schrieb am Do., 28. Nov. 2019, 16:03:

i rechecked locally:

Paket.Core in a net461/netcoreapp2.1 project
Paket as local tool (dotnet paket)
Paket.Boostrapper as local tool (dotnet paketboostrapper), but ihmo
is useless

all ok afaik.
There are misc fixes/enhancement documented in the PR description, but
should all be ok
@forki https://github.com/forki so if green, merge it! [image: :shipit:]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3734?email_source=notifications&email_token=AAAOANEF4N3FCUTLHFSKLBLQV7MTBA5CNFSM4JR3XJ2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFM3C6I#issuecomment-559526265,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANC26GUS3HQ735EIGYLQV7MTBANCNFSM4JR3XJ2A
.

Can we use bootstrapper as global tool? In magic mode?

@forki no, i just packaged as tool. because dunno what you want to do.
But ihmo is not the way forward with that.
I think about that scenario a lot for repotool/.net core paket.
Scenario is a nice dev ux + deterministic builds
I think can be done in two with:
a paket global tool who can do:

run init like command
all other commands, it will execute the dotnet paket (so will run the local paket, deterministic/pinned) passing the same args who got (like magic mode)
seem like bootstrapper in magic mode, but is 2% of bootsrapper code

a paket local tool who can do:

pinned, so deterministic build
all usual commands

Using the bootstrapper ihmo is not needed, because:

just 2% of bootstrapper code is needed
use a single package -> better experience (because naming)

What change without the boostrapper, list of features:

pinning. OK is done by tool manifest
specify a different feed. OK with nuget.config or dotnet tool restore args
download from nuget package. OK the default
download from github releases. KO not supported. BUT with global nuget cache is okish because cached = fast
caching of version. OK in the global nuget cache
magic mode machinery/optimization. OK as local+global tool, have the same name. see below for info
self updates. OK, done with dotnet tool update

So my idea is:
let's use just paket tool. will be paket (global) and dotnet paket (local)
In the first lines of paket main, before argu parse, we include a check.

if is init command -> then do it. OK because we know first word

on init:

generate paket.dependencies as usual
check if exists tool manifests, otherwise generate it
run dotnet tool install paket --local

else

recursive search directory hierarchy for .paket dir.
if exists, it's a paket repo. good
if exits tool manifest (.config/dotnet-tools.json):

then run dotnet paket with args
else run ./paket/paket.exe with args (backward compatibility, no more need for alias)

PRO:

developers use global tool or local tool
CI/Docker use ONLY local tool, no need for global tool

The only unknown i know:

clean repo scenario

given a clean repo (git clone/git clean -xdf), i dont know exactly how too install paket if i do just dotnet build.
If is already restore the tools (dotnet tool restore, like in CI), works. Otherwise dunno (because parallel msbuild etc)
But is okish because we can do dotnet tool restore in the build.cmd (it's fast noop if already restore)
More tied to dotnet cli args (if they change we may need tweaks), but most of the corner cases are inside the target file anyway
I'll try send a PR, should not be lot of work to show it

See https://github.com/fsprojects/Paket/issues/3623
Enrico Sada<EMAIL_ADDRESS>schrieb am Do., 28. Nov. 2019, 16:43:

Can we use bootstrapper as global tool? In magic mode?
@forki https://github.com/forki no, i just packaged as tool. because
dunno what you want to do.
But ihmo is not the way forward with that.
I think about that scenario a lot for repotool/.net core paket.
Scenario is a nice dev ux + deterministic builds
I think can be done in two with:
a paket global tool who can do:

run init like command
all other commands, it will execute the dotnet paket (so will run
the local paket, deterministic/pinned) passing the same args who got (like
magic mode)
seem like bootstrapper in magic mode, but is 2% of bootsrapper code

a paket local tool who can do:

pinned, so deterministic build
all usual commands

Using the bootstrapper ihmo is not needed, because:

just 2% of bootstrapper code is needed
use a single package -> better experience (because naming)

What change without the boostrapper, list of features:

pinning. OK is done by tool manifest
specify a different feed. OK with nuget.config or dotnet tool
restore args
download from nuget package. OK the default
download from github releases. KO not supported. BUT with global
nuget cache is okish because cached = fast
caching of version. OK in the global nuget cache
magic mode machinery/optimization. OK as local+global tool, have the
same name. see below for info
self updates. OK, done with dotnet tool update

So my idea is:
let's use just paket tool. will be paket (global) and dotnet paket (local)
In the first lines of paket main, before argu parse, we include a check.

if is init command -> then do it. OK because we know first word

on init:

generate paket.dependencies as usual
check if exists tool manifests, otherwise generate it
run dotnet tool install paket --local

else
recursive search directory hierarchy for .paket dir.
if exists, it's a paket repo. good
if exits tool manifest (.config/dotnet-tools.json):

then run dotnet paket with args
else run ./paket/paket.exe with args (backward compatibility,
no more need for alias)

PRO:

developers use global tool or local tool
CI/Docker use ONLY local tool, no need for global tool

The only unknown i know:

clean repo scenario

given a clean repo (git clone/git clean -xdf), i dont know exactly how
too install paket if i do just dotnet build.
If is already restore the tools (dotnet tool restore, like in CI), works.
Otherwise dunno (because parallel msbuild etc)
But is okish because we can do dotnet tool restore in the build.cmd (it's
fast noop if already restore)
More tied to dotnet cli args (if they change we may need tweaks), but
most of the corner cases are inside the target file anyway
I'll try send a PR, should not be lot of work to show it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3734?email_source=notifications&email_token=AAAOAND5LCDH7YWISPBVKXDQV7RI3A5CNFSM4JR3XJ2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFM6IIQ#issuecomment-559539234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANFZMX2EUPX6VIDIG53QV7RI3ANCNFSM4JR3XJ2A
.

@forki i know, it was the same idea time of months ago, just not implemented until local tool.
I'll give it a shot
BTW @forki diffing things i see that the generate exe is not digitally signed correctly anymore (i think).
I dont see the icon either (i can try fix that later)
I dont really know that signing stuff well (antivirus whitelist?) just saying if someone can help with it

@forki i know, it was the same idea time of months ago, just not implemented until local tool.
I'll give it a shot
BTW @forki diffing things i seen two bugs in this PR (but merge it anyway)

I dont see the icon either (i can try fix that later)
the generate exe is not digitally signed correctly anymore (i think). I dont really know that signing stuff well (antivirus whitelist?) just saying if someone can help with it

i tried diff the generated exe and old versions and seems ok

@forki there are some flaky tests on travis, but one of two builds was green (i rerun the failed one, now is green, i think can be set FLAKY later)

Signing is done on my pc
Enrico Sada<EMAIL_ADDRESS>schrieb am Do., 28. Nov. 2019, 17:10:

@forki https://github.com/forki there are some flaky tests on travis,
but one of two builds was green (i rerun the failed one, now is green, i
think can be set FLAKY later)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3734?email_source=notifications&email_token=AAAOANAW5XWEQIJCHUR4ZY3QV7UPZA5CNFSM4JR3XJ2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNAMNA#issuecomment-559547956,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANGUQNYERV7W23DUVHLQV7UPZANCNFSM4JR3XJ2A
.

Good!
about the icon:

was added in 8ee2bf9eac83657b9c62e1adb5f2eb476eac4bae
the <Win32Resource>paket.res</Win32Resource> in fsproj doesnt seem to work
in csproj should be <ApplicationIcon>paket.ico</ApplicationIcon> instead, more easy, but we are fsproj :D

Yes please add it back.
Enrico Sada<EMAIL_ADDRESS>schrieb am Do., 28. Nov. 2019, 17:35:

Good!
about the icon:

was added in 8ee2bf9
https://github.com/fsprojects/Paket/commit/8ee2bf9eac83657b9c62e1adb5f2eb476eac4bae
the paket.res in fsproj doesnt seem
to work
in csproj should be paket.ico
instead, more easy, but we are fsproj :D

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/3734?email_source=notifications&email_token=AAAOANAVVUAL62L2THHFAVTQV7XNDA5CNFSM4JR3XJ2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNCD5I#issuecomment-559555061,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOANHIPGIDBU5MPI5N4NLQV7XNDANCNFSM4JR3XJ2A
.

So, for icon bad luck atm.
in F# we need to use native resource like <Win32Resource>paket.res</Win32Resource>, not ApplicationIcon ( ref https://github.com/dotnet/sdk/issues/2818 ).
But is not yet implemented in clr fsc compiler (ref https://github.com/dotnet/fsharp/issues/1172 )
i'll try a tool to fix it after generation, but in another PR, this is done @forki

Awesome. Thanks for the work

a paket global tool who can do:
...
seem like bootstrapper in magic mode, but is 2% of bootsrapper code

So 2 questions about that:

Will paket global tool understand version pinning from paket.dependencies file?
Will paket global tool download latest version of Paket if version is not pinned?

Will paket global tool understand version pinning from paket.dependencies file?
@Krzysztof-Cieslak if you mean version in paket.dependencies, depends.

for current .paket/paket.exe, yes, because paket global tool will run .paket/paket.exe so that (real or magicmode) will read version and use pinned version
for dotnet paket (paket as local tool), no, BUT will be pinned in .config/dotnet-tool.json (the tool manifest of local tools)
for for both, will use the right pinned version afaik

Will paket global tool download latest version of Paket if version is not pinned?
we can discuss about behaviour (i think is a bad idea to not pin, because can break if .paket/paket.restore.targets is not aligned) and preserve old behaviour while forcing pinning for new one.

for dotnet paket (paket as local tool), is pinned in the manifest. We can print a message maybe if is not the latest version (like yarn does afaik) so user can update if they want.
for .paket/paket.exe if is magic mode, same behaviour. it's downloaded first time (respecting paket.exe.config and paket.dependencies version, after that usual check

but we can also just skip paket global tool and not support older .paket/paket.exe .
I'll open a PR with this


[WB-7256] Runtime Error when logging in grad.data

Description
https://wandb.atlassian.net/browse/WB-7256
The PR works around an issue with torch.histc where a runtime error can occur when min == max > 10^15. It also addresses a potential unnoticed issue in which the bins created by histc may not be the ones expected and may cause the histogram to be displayed incorrectly.
When torch.histc receives a tensor with only one distinct value, or when it receives arguments min and max, an attempt appears to be made to separate min and max by assigning min = min-1 and max = max+1. However, histc works with 64 bit floats, so when the values are greater than roughly 10^15, we have min == min - 1 and max == max + 1, so the separation doesn't succeed, and we end up with RuntimeError: torch.histc: max must be larger than min. Simply calling torch.histc(torch.tensor([1e16])) will reproduce this; calling the same with 1e15 will succeed without issue.
The other potential issue is that the separation torch.histc applies results in histc using a different set of bins than the index we create with our call to torch.linspace, which can cause the histogram to be displayed incorrectly. Both of these issues are addressed.
Testing
Unit tests are included.
Release Notes
------------- BEGIN RELEASE NOTES ------------------
NO RELEASE NOTES
------------- END RELEASE NOTES --------------------

@kptkin @adrnswanberg can this be merged?

@kptkin @adrnswanberg can this be merged?

It was a while since I looked at this one... I don't remember the state of it... (not sure if all comments were addressed)


--proto_path parameters are not added the first time protos are built with empty modcache.

This is just regular make eager expansion. The $(shell ...) op that builds the parameters is evaluated before the recipe begins, and hence before go mod download is run.


Infs and Nans

Need to figure out why sometimes when you run through expm you get infs and nan errors even though the matrices are dense and all 0 except for the relevant entries.

think it might be because there was a period of time where I loved uninitialised arrays

Think this is solved using Htot = zeros(eltype(A),size(A)) instead of similar and it seems to not impact performance in a significant way.


Validate required boolean field with false

Hi, I noticed that when using the Required validator against a boolean field with value equals false, the validator will raise
FIELD_NAME: cannot be blank.

Is this expected?
Sample code: https://go.dev/play/p/SkiEIx2aaQN

Yes as per source code
Required is a validation rule that checks if a value is not empty.
A value is considered not empty if

integer, float: not zero
bool: true
string, array, slice, map: len() > 0
interface, pointer: not nil and the referenced value is not empty
any other types


fbsimctl boots all simulators

I'd expect boot to create one simulator that exactly matches the given name, not all of them. If I use the UUID then it works.
$ ./fbsimctl list
06139099-8108-4382-B9B3-3CC0ADB8E48E iPhone 4s iOS 9.2
...

$ ./fbsimctl boot "iPhone 4s iOS 9.2"
Booting 916F3B85-B553-4236-848C-03911CE65A9B iPhone 4s
Error Domain=com.facebook.FBSimulatorControl Code=0 "Expected Simulator 916F3B85-B553-4236-848C-03911CE65A9B to be Booted, but it was 'Booted'" UserInfo={launchd_is_running=0, launchd_subprocesses=[(null)], NSLocalizedDescription=Expected Simulator 916F3B85-B553-4236-848C-03911CE65A9B to be Booted, but it was 'Booted'}
medwards-l:build medwards$ ./fbsimctl boot "iPhone 4s iOS 9.2"
Booting 916F3B85-B553-4236-848C-03911CE65A9B iPhone 4s
Error Domain=com.facebook.FBSimulatorControl Code=0 "Expected Simulator 916F3B85-B553-4236-848C-03911CE65A9B to be Booted, but it was 'Booted'" UserInfo={launchd_is_running=0, launchd_subprocesses=[(null)], NSLocalizedDescription=Expected Simulator 916F3B85-B553-4236-848C-03911CE65A9B to be Booted, but it was 'Booted'}
medwards-l:build medwards$ ./fbsimctl boot "iPhone 4s iOS 9.2"
Booting 916F3B85-B553-4236-848C-03911CE65A9B iPhone 4s
Jan  6 00:07:46  FBSimulatorControl[18468] <Info>: 916F3B85-B553-4236-848C-03911CE65A9B: Did Change State => Booting
Jan  6 00:07:46  FBSimulatorControl[18468] <Info>: 916F3B85-B553-4236-848C-03911CE65A9B: Did Start => simulator_pid 18472 | launchd_sim_pid 18475
Jan  6 00:07:46  FBSimulatorControl[18468] <Info>: 916F3B85-B553-4236-848C-03911CE65A9B: Did Change State => Booted
Booted 916F3B85-B553-4236-848C-03911CE65A9B iPhone 4s
Booting 06139099-8108-4382-B9B3-3CC0ADB8E48E iPhone 4s iOS 9.2
Jan  6 00:07:46  FBSimulatorControl[18468] <Info>: 06139099-8108-4382-B9B3-3CC0ADB8E48E: Did Change State => Booting
Jan  6 00:07:46  FBSimulatorControl[18468] <Info>: 06139099-8108-4382-B9B3-3CC0ADB8E48E: Did Start => simulator_pid 18504 | launchd_sim_pid 18517
Jan  6 00:07:47  FBSimulatorControl[18468] <Info>: 06139099-8108-4382-B9B3-3CC0ADB8E48E: Did Change State => Booted
Booted 06139099-8108-4382-B9B3-3CC0ADB8E48E iPhone 4s iOS 9.2
Booting FAEA8059-5985-4F37-97A6-BEF0289E5618 iPhone 5
Jan  6 00:07:47  FBSimulatorControl[18468] <Info>: FAEA8059-5985-4F37-97A6-BEF0289E5618: Did Change State => Booting
Jan  6 00:07:48  FBSimulatorControl[18468] <Info>: FAEA8059-5985-4F37-97A6-BEF0289E5618: Did Start => simulator_pid 18547 | launchd_sim_pid 18557
Jan  6 00:07:48  FBSimulatorControl[18468] <Info>: FAEA8059-5985-4F37-97A6-BEF0289E5618: Did Change State => Booted
Booted FAEA8059-5985-4F37-97A6-BEF0289E5618 iPhone 5
Booting 279402FF-F382-42FE-913B-72C174508E67 iPhone 5
Jan  6 00:07:49  FBSimulatorControl[18468] <Info>: 279402FF-F382-42FE-913B-72C174508E67: Did Change State => Booting
Jan  6 00:07:50  FBSimulatorControl[18468] <Info>: 279402FF-F382-42FE-913B-72C174508E67: Did Start => simulator_pid 18603 | launchd_sim_pid 18617
Jan  6 00:07:50  FBSimulatorControl[18468] <Info>: 279402FF-F382-42FE-913B-72C174508E67: Did Change State => Booted
Booted 279402FF-F382-42FE-913B-72C174508E67 iPhone 5
Booting 9BEC0903-2A1E-4AAC-9D17-95AB6212FEBC iPhone 5s
Jan  6 00:07:53  FBSimulatorControl[18468] <Info>: 9BEC0903-2A1E-4AAC-9D17-95AB6212FEBC: Did Change State => Booting
Jan  6 00:07:53  FBSimulatorControl[18468] <Info>: 9BEC0903-2A1E-4AAC-9D17-95AB6212FEBC: Did Start => simulator_pid 18679 | launchd_sim_pid 18692
Jan  6 00:07:53  FBSimulatorControl[18468] <Info>: 9BEC0903-2A1E-4AAC-9D17-95AB6212FEBC: Did Change State => Booted
Booted 9BEC0903-2A1E-4AAC-9D17-95AB6212FEBC iPhone 5s
Booting A917A554-E007-463A-B6EE-A0C5EC9D43DC iPhone 6
Jan  6 00:07:57  FBSimulatorControl[18468] <Info>: A917A554-E007-463A-B6EE-A0C5EC9D43DC: Did Change State => Booting
Jan  6 00:07:57  FBSimulatorControl[18468] <Info>: A917A554-E007-463A-B6EE-A0C5EC9D43DC: Did Start => simulator_pid 18757 | launchd_sim_pid 18761
Jan  6 00:07:57  FBSimulatorControl[18468] <Info>: A917A554-E007-463A-B6EE-A0C5EC9D43DC: Did Change State => Booted
Booted A917A554-E007-463A-B6EE-A0C5EC9D43DC iPhone 6
Booting E3FF4EA6-2A34-4674-9A2F-85CC492C6E08 iPhone 6 Plus
...

This looks like erroneous behaviour to me! In future I want an empty Query to signify 'Perform the action with the last query that was run':
boot 279402FF-F382-42FE-913B-72C174508E67 followed by shutdown would result in 279402FF-F382-42FE-913B-72C174508E67 being used as the query for shutdown.
When there isn't a 'prior simulator' it should probably bail out with a suitable error message. Could pick a simulator at random, but that's probably surprising behaviour.

When there isn't a 'prior simulator' it should probably bail out with a suitable error message.

:+1:

Will be fixed when #167 merges.


Palindrome checker #472

This is the PR for the issue Palindrome checker #472

add your project in index and cardsdata file


Runtime error documentation

class to let us document legion runtime errors in the source code.  usage is like this:
        LegionRuntime::Logger::MessageDescriptor
        ILLEGAL_REQ_EMPTY_FUTURE(1000,
                                 "this is an html description of what to do if you see the subsequent error");
        Internal::log_run.error(ILLEGAL_REQ_EMPTY_FUTURE.id(), "Illegal request for future "
                                "value from empty future");

A separate script parses the source files to collate these messages for posting online.
This introduces one new typedef at the Realm level for LoggerMessageID (int).  This might change to a string some day or a long int.
This introduces a new class at the LegionRuntime::Logger level, MessageDescriptor.

A couple of things:

We need to get all the continuous integration tests to pass before doing the merge
https://travis-ci.org/StanfordLegion/legion/builds/229382049?utm_source=github_status&utm_medium=notification
The LegionRuntime namespace is deprecated.  I think we probably want to put this in the Legion::Internal namespace, e.g.
https://github.com/StanfordLegion/legion/blob/master/runtime/legion/runtime.h#L29-L30
You were going to define an operator conversion to Realm::LoggerMessageID right?

Mike,
1&2 yes
3 I made a type so the compiler would type check for us and catch errors.  For this reason I did not define an implicit conversion to int for Realm::LoggerMessageID.  Are you ok with this?

What kind of type errors are you hoping to catch?  I would think that we would always want to be able to pass this to a Realm logging call that takes an integer as the first argument.  It won't implicitly cast to a 'const char*' so it should catch those cases for us.

The realm logging call takes a LoggerMessageID rather than an int precisely so you won't call it unintentionally with an int argument.  The recommended way to call it is with a MessageDescriptor::id().    If you really want to call it with an int you can still do so by using a cast but I would not want this to happen silently (and I cannot think of a reason to do this).

Hmm...  I'm not wild about adding another use of Legion::... inside of Realm, but I'm willing to clean that up later.  Two more pressing questions:

@aheirich Does the message extractor script fail loudly if the same message ID is used in two places?
@lightsighter How painful is this going to be to merge into deppart/control_replication branches on your side?

I'm pretty concerned about the merge with deppart currently.  I thought the plan was we were going to create the infrastructure, and modify a few of the error messages to test it out, and then wait for the deppart merge before annotating all the error messages.  However, it looks like Alan went through and annotated all the error messages which is going to cause lots of conflicts with deppart, especially in the legion_context.cc and region_tree.cc files. Merging with control replication won't be so bad since that is mostly new code on top of deppart, but deppart is going to be painful.

Following up on my question from above, @aheirich does the message extractor script also flag error/fatal messages that do not have a message ID associated with them?  If so, we'd be able to resolve the deppart merge conflicts by ignoring the message ID changes and then add them back in manually without fear of missing any.

I can make the python script notify us of messages that don't have annotations.  But I don't think there should be any, I annotated them all.

to answer @streichler yes the python script will fail if there are duplicate message ids in use
it's not graceful but seems adequate

FYI to all if there is manual work to do I will do it
I already spent the time putting the annotations in!

TO DO (note to self): modify python script to flag error or fatal that are missing annotations.

@aheirich The two files which I foresee being problematic with the merge with deppart are region_tree.cc and legion_context.cc.  They are the ones we'll probably want to set back to their state with master before the merge and then re-annotate them in deppart after merging master into deppart.  You'll see legion_context.cc has changed a lot, and a large fraction of region_tree.cc was completely rewritten with some of it being refactored into region_tree.inl.

Hi
How do I change my registered email address for this list?
thanks
Alan

On Jun 8, 2017, at 1:01 AM, Mike Bauer<EMAIL_ADDRESS>wrote:
@aheirich https://github.com/aheirich The two files which I foresee being problematic with the merge with deppart are region_tree.cc and legion_context.cc. They are the ones we'll probably want to set back to their state with master before the merge and then re-annotate them in deppart after merging master into deppart. You'll see legion_context.cc has changed a lot, and a large fraction of region_tree.cc was completely rewritten with some of it being refactored into region_tree.inl.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/StanfordLegion/legion/pull/248#issuecomment-307029664, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0b3v-yNVBIX00N3BvyTIpp5YoL7Wr4ks5sB6pvgaJpZM4NSp4M.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/StanfordLegion/legion","title":"StanfordLegion/legion","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/StanfordLegion/legion"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lightsighter in #248: @aheirich The two files which I foresee being problematic with the merge with deppart are region_tree.cc and legion_context.cc. They are the ones we'll probably want to set back to their state with master before the merge and then re-annotate them in deppart after merging master into deppart. You'll see legion_context.cc has changed a lot, and a large fraction of region_tree.cc was completely rewritten with some of it being refactored into region_tree.inl."}],"action":{"name":"View Pull Request","url":"https://github.com/StanfordLegion/legion/pull/248#issuecomment-307029664"}}}

You should be able to choose your primary email at https://github.com/settings/emails

Mike,
Is this ready for me to work on yet?  Has deppart merged into master?  Or should I merge deppart into runtime_error_messages?
Alan

On Jun 8, 2017, at 1:01 AM, Mike Bauer<EMAIL_ADDRESS>wrote:
@aheirich https://github.com/aheirich The two files which I foresee being problematic with the merge with deppart are region_tree.cc and legion_context.cc. They are the ones we'll probably want to set back to their state with master before the merge and then re-annotate them in deppart after merging master into deppart. You'll see legion_context.cc has changed a lot, and a large fraction of region_tree.cc was completely rewritten with some of it being refactored into region_tree.inl.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/StanfordLegion/legion/pull/248#issuecomment-307029664, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0b3v-yNVBIX00N3BvyTIpp5YoL7Wr4ks5sB6pvgaJpZM4NSp4M.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/StanfordLegion/legion","title":"StanfordLegion/legion","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/StanfordLegion/legion"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lightsighter in #248: @aheirich The two files which I foresee being problematic with the merge with deppart are region_tree.cc and legion_context.cc. They are the ones we'll probably want to set back to their state with master before the merge and then re-annotate them in deppart after merging master into deppart. You'll see legion_context.cc has changed a lot, and a large fraction of region_tree.cc was completely rewritten with some of it being refactored into region_tree.inl."}],"action":{"name":"View Pull Request","url":"https://github.com/StanfordLegion/legion/pull/248#issuecomment-307029664"}}}


Ignore Empty Lines and Comments

Currently, if there are empty lines between the properties or comments, the extension doesn't work and crashes.

That's currently how it works, yes. Feel free to provide a patch that does handle such scenarios though. The extension doesn't crash however, it provides an Error to the completionHandler (which in Xcode probably incorrectly shows up as a crash).

See https://github.com/rjoudrey/swift-init-generator

Fixed in 8ad07889eedc79499067a124c11468e5416c74ea.


Cannot remove all the ads

HLTV ads cannot be removed by this plugin now. Maybe caused by the update of hltv website.

Works well for now. If failed, just refresh page


Added disable ap tracking libfunc.

Stack:

#2292
#2288
#2273
#2272 ⬅
#2271

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

crates/cairo-lang-sierra/src/extensions/modules/ap_tracking.rs line 9 at r1 (raw file):

define_libfunc_hierarchy! {
    pub enum ApTrackingLibfunc {
        Revoke(RevokeApTrackingLibfunc),

Are you going to remove this?
Can you use  Disable in its place?
Code quote:
Revoke(RevokeApTrackingLibfunc),


Consider adding a license

Howdy! I'm interested in potentially reusing some or all of this code in some APRS tinkering I'm doing. I don't want to trample your intellectual property rights. I'm curious if you'd be okay with code reuse like that. If you'd consider adding an open source license that allows reuse (MIT, GPL, Apache, etc.), that'd be even better to ensure everything is on the up and up.
Thanks for considering!

Hello @CBielstein. Sorry for longtime answer. You can use source code in your projects as you wish. If you will publish sources of your projects anywhere just indicate original source.

Hello @CBielstein. Sorry for longtime answer. You can use source code in any your projects as you with. Just  indicate the original source if you will publish source code of they anywhere.

Thanks! I'll certainly attribute and let you know if I end up using the code in anything. 😊


Seems to be working on B450M GAMING PLUS (MS-7B87)

Seems to be working fine but I have to use invert.
So to make blue:
sudo msi-rgb 00000000 00000000 FFFFFFFF -ir -ig -ib
red:
sudo msi-rgb FFFFFFFF 00000000 00000000 -ir -ig -ib
etc.
Thanks!

So I've been using
sudo msi-rgb 00000000 00000000 FFFFFFFF -ib

as my default color. It's just white and it holds steady, no blinking, no fading.
But now with the same command it fades from white to yellow and back... Quite bizzarre.


[DNM] Release 254 Analysis

This is a dummy PR to help examine the diff between the v20240503.00 release and the last successful hotfix

No longer needed


Cuda out of memory

I tried to run the code on my own laptop and I got this error
Training starts.
#################### Epoch: 1 ####################
0%|                                                                                | 0/9555 [00:00<?, ?it/s]
Traceback (most recent call last):
File "src/main.py", line 283, in
manager.train()
File "src/main.py", line 106, in train
outputs = self.model(
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/reda/anaconda3/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 941, in forward
transformer_outputs = self.transformer(
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/reda/anaconda3/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 789, in forward
outputs = block(
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/reda/anaconda3/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 317, in forward
attn_outputs = self.attn(
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/reda/anaconda3/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 258, in forward
attn_output, attn_weights = self._attn(query, key, value, attention_mask, head_mask)
File "/home/reda/anaconda3/lib/python3.8/site-packages/transformers/models/gpt2/modeling_gpt2.py", line 194, in _attn
attn_weights = self.attn_dropout(attn_weights)
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/modules/dropout.py", line 58, in forward
return F.dropout(input, self.p, self.training, self.inplace)
File "/home/reda/anaconda3/lib/python3.8/site-packages/torch/nn/functional.py", line 1076, in dropout
return VF.dropout(input, p, training) if inplace else _VF.dropout(input, p, training)
RuntimeError: CUDA out of memory. Tried to allocate 192.00 MiB (GPU 0; 3.95 GiB total capacity; 2.92 GiB already allocated; 95.25 MiB free; 2.96 GiB reserved in total by PyTorch)

Sorry for my late response. This is a literally CUDA memory problem which is due to the lack of your GPU memory for training the model. I recommend you to reduce batch size and try it again. Thank you.


changes

implements changes discussed in discord:

clamps temperature to target if close enough to reach it in 1 tick
if temperature is clamped, adjust power consumption
remove the upper temperature limit for freezers, and the lower temperature limit for heaters

Thanks, I'll fix up some minor nits in my own branch.


TTL validation bug

I accidentally created a cluster spiffe id with ttl set to 5d.
It doesn't work as 'd' is not supported. This is fine. The whole controller manager is kind of broken with syncing at this point... this even is kind of fine, as its not supported and my mistake.
I then did a kubectl edit on it and tried to remove the ttl, or change it to something valid. It fails:
error: clusterspiffeids.spire.spiffe.io "spire-root-server-spire-step" could not be patched: admission webhook "vclusterspiffeid.kb.io" denied the request: time: unknown unit "d" in duration "5d"

It seems to be validating the previous version before validating the current version?
But there's now not a way to fix it.

Used the helm chart. It was an initial deployment... I guess in that case it may load in the cr before the webhook gets into place.


Update service-fabric-cluster-resource-manager-cluster-description.md

NodeTypeName is also generated by default for clustermanifest

@jagilber : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close and we can reopen this if we want to figure out a good way to communicate this information


Objc-C Usability: Automatically Complete Opening Square Brackets

Hi awesome clangd folks,
Thanks for building such an awesome tool. I've newly gone from being a consumer of clangd in other IDEs to building a build-system integration of my own.
One really handy Obj-C(++) ergonomic feature in other completion systems that I think would be relatively easy to add to clangd: Automatically adding opening square brackets to message passing in Obj-C.
This is really handy, since functions calls are often deeply nested in Obj-C and autocompleting opening braces to match closing ones saves a lot of back-and-forth and planning. Xcode and Nuclide both have this feature, and it's very nice.
Clangd surfaces a quick fix for the issue, but it'd be awesome if it would just automatically do the insertion of the opening square bracket, having already identified the fix. [If there's already a way to auto-apply certain quick fixes, and I've missed it, please lmk, but this would definitely be a great one to enable by default.]
Thanks so much for your consideration!
Platform: macOS 11, clangd 11, VSCode

I think in terms of the LSP, the intended way to support this is via textDocument/onTypeFormatting?

I think in terms of the LSP, the intended way to support this is via textDocument/onTypeFormatting?

I think in terms of the LSP, the intended way to support this is via textDocument/onTypeFormatting?

That sounds very hackish. I don't feel like we should (ab)use formatting to automatically fix this.

I think in terms of the LSP, the intended way to support this is via textDocument/onTypeFormatting?

That sounds very hackish. I don't feel like we should (ab)use formatting to automatically fix this.

What other mechanism is there to automatically insert something without the user explicitly invoking an action?

What other mechanism is there to automatically insert something without the user explicitly invoking an action?

Is that what you use for other automatic brace or parenthetical completion? If so, this feels fairly parallel.

Is that what you use for other automatic brace or parenthetical completion? If so, this feels fairly parallel.

Is that what you use for other automatic brace or parenthetical completion?

I think that may be done by clients without clangd's involvement.

Is that what you use for other automatic brace or parenthetical completion?

I think that may be done by clients without clangd's involvement.

Err, auto #include insertion, then?

Err, auto #include insertion, then?

Err, auto #include insertion, then?
Auto include insertion is a done when you code complete a type that's not defined in the file you are using. So while not strictly an explicit action, its blurring the lines. It can also be disabled with a command line flag.

Err, auto #include insertion, then?
Auto include insertion is a done when you code complete a type that's not defined in the file you are using. So while not strictly an explicit action, its blurring the lines. It can also be disabled with a command line flag.

Also worth mentioning Nuclide's implementation is here, but I don't see a clear way to port this over to VS Code using VS Code's public API. If anyone has any ideas, let me know.

Also worth mentioning Nuclide's implementation is here, but I don't see a clear way to port this over to VS Code using VS Code's public API. If anyone has any ideas, let me know.
EDIT: I think this might be possible by using the following:
* `vscode.workspace.onDidChangeTextDocument`

* `vscode.workspace.applyEdit`

If the feature can be implemented without access to server-side semantic information (e.g. the clang AST), then yes, I think it could be implemented on the client side using APIs such as these.

Thanks for your deep digging, @DavidGoldman.
How hard do you think it would be to do?

I just did a quick test of whether it's possible to use the VS Code API to do such a thing, and it does indeed work for my simple test case:
    vscode.workspace.onDidChangeTextDocument(event => {
      const document = event.document;
      const lang = document.languageId;
      if (lang !== 'objective-c' && lang !== 'objective-cpp') return;
      for (const change of event.contentChanges) {
        if (change.text.trimEnd() === ']') {
          const edit = new vscode.WorkspaceEdit();
          const lineNum = change.range.start.line;
          const textLine = document.lineAt(lineNum);
          const position = new vscode.Position(lineNum, textLine.firstNonWhitespaceCharacterIndex);
          edit.insert(document.uri, position, '[');
          vscode.workspace.applyEdit(edit);
        }
      }
    });

So I think it's possible, we can try to use logic similar to Atom's to implement this

Sharing thoughts I was having rereading this--at the risk of overly generalizing, breaking frame:
Are there other categories of fixes, currently presented to the user as "fix available", where we're sufficiently confident in our proposal that we should auto-apply the fix? (Or auto-apply on save? A quick search indicates that this issue has arisen in a number of other extensions.)
Closing brace matching is already handled by VSCode, of course, and we already handle missing #include, but it seems like there might be something more general here. One example would be missing ;--we could speed those out of existence by more generally auto-applying high-confidence quick fixes.

Sharing thoughts I was having rereading this--at the risk of overly generalizing, breaking frame:
Are there other categories of fixes, currently presented to the user as "fix available", where we're sufficiently confident in our proposal that we should auto-apply the fix? (Or auto-apply on save? A quick search indicates that this issue has arisen in a number of other extensions.)
Closing brace matching is already handled by VSCode, of course, and we already handle missing #include, but it seems like there might be something more general here. One example would be missing ;--we could speed those out of existence by more generally auto-applying high-confidence quick fixes.

Not sure if @sam-mccall or @kadircet have any opinions, I think the main concern is automatically adding these during edits may not be a great experience (e.g. LSP is all async, non-blocking calls which can be slow in some cases) - applying these on save might be reasonable but it's not exactly the feature being requested here. It does seem possible though - there is the workspace/applyEdit request.


[move] Allow reserved words to be used in some contexts

🚀 Feature Request
address and signer are both reserved in Move but extremely common, especially in smart contract code. It would be nice if they would not be forbidden in all contexts.
Example:
let address = x"dd";

is illegal, but unambiguous that address is a variable name.

Thanks for the report! This issue has been resolved since it was posted (I won't dig into the exact commit), now both signer and address are contextually interpreted as either a keyword or as an identifier.


Keyboard Layout Window Rule

Description
Adding a window rule to have a different keyboard layout on different windows.

why? niche + scriptable


init

Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[ ] I have read the contributing guidelines
[ ] Existing issues have been referenced (where applicable)
[ ] I have verified this change is not present in other open pull requests
[ ] Functionality is documented
[ ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

@utsavberi @DominicDC Is this a test PR? Can it be closed?

Was a test PR, closed it
On Wed, Jan 4, 2023 at 4:16 PM Ian White @.***> wrote:

@utsavberi https://github.com/utsavberi @DominicDC
https://github.com/DominicDC Is this a test PR? Can it be closed?
—
Reply to this email directly, view it on GitHub
https://github.com/wayfair-incubator/postmessage-communicator/pull/15#issuecomment-1371429139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADCZ4DOSDDTMMN35R2FBSLWQXSD7ANCNFSM6AAAAAATIBJZ6A
.
You are receiving this because you were mentioned.Message ID:
@.***
com>


⚠ SceneTime has degraded performance

In b70cf09, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1818 ms

Resolved: SceneTime performance has improved in d07de92 after 9 minutes.


Update package.json esy dependency

Thank you. Curious, was this causing you problems?

@jordwalke yes:
$ yarn global add git://github.com/reasonml/reason-cli.git#beta-v-1.13.5
yarn global v0.23.3
warning No license field
[1/4] 🔍  Resolving packages...
error Couldn't find manifest in "git://github.com/reasonml/esy.git".
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

Oh whoa - yarn doesn't do redirects. FYI, the yarn global add workflow isn't heavily tested so we don't claim support. Glad if it works though.


Enable creating Index from list like 'Index([1, 2, 3])'

Resolves #948
>>> Index([1, 2, 3])
Int64Index([1, 2, 3], dtype='int64')

>>> Index(list('abc'))
Index(['a', 'b', 'c'], dtype='object')

Codecov Report

Merging #986 into master will decrease coverage by 2.45%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #986      +/-   ##
==========================================
- Coverage   94.84%   92.39%   -2.46%
==========================================
  Files          34       34
  Lines        6519     6520       +1
==========================================
- Hits         6183     6024     -159
- Misses        336      496     +160

Impacted Files
Coverage Δ

databricks/koalas/indexes.py
96.64% <100%> (+0.01%)
:arrow_up:

databricks/koalas/usage_logging/__init__.py
24.54% <0%> (-72.73%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
78.04% <0%> (-7.32%)
:arrow_down:

databricks/conftest.py
91.48% <0%> (-6.39%)
:arrow_down:

databricks/koalas/frame.py
93.84% <0%> (-2.42%)
:arrow_down:

databricks/koalas/groupby.py
89.34% <0%> (-2.05%)
:arrow_down:

databricks/koalas/namespace.py
85.71% <0%> (-1.56%)
:arrow_down:

databricks/koalas/plot.py
93.33% <0%> (-0.96%)
:arrow_down:

databricks/koalas/utils.py
97.36% <0%> (-0.66%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feca119...a10e510. Read the comment docs.

Thanks! merging.

@ueshin Thanks :)


Inconsistent effect of setting rlimit

In the code below, if we run Boogie with /proverOpt:O:smt.qi.eager_threshold=100 /rlimit:5, the verification of test1 fails with an out-of-resource error.  However, if we comment out the test0 procedure, then test1 succeeds.
The underlying issue appears to be that Boogie emits a push operation before setting the (large) rlimit for test1.  According to Nikolaj, however, Z3 does enough work in a push that it exhausts the resource limit before it reaches the point of setting the larger rlimit.
I think the fix would be to move the if case here: https://github.com/boogie-org/boogie/blob/1a18c9c956249098f6a6a9fc7830e88ebed1aa0d/Source/Provers/SMTLib/SMTLibProcessTheoremProver.cs#L559  two lines earlier (so that it precedes the call SendThisVC("(push 1)");).
Does anyone anticipate issues with this change?
function f(i:int, j:int) returns (int)
{
    if i == 0 then 0 else f(i - 1, i * j + 1) + f(i - 1, 2 * i * j)
}

procedure test0(x:int)      // Causes test1 to fail when run with /rlimit:5
{
    assert(x - x == 0);
}

procedure {:rlimit 100000000} test1()
{
    assert(f(13,5) == 0);
}

I like the F* solution.  It is what the user would expect when she provides a resource bound for a particular procedure, i.e., the bound should apply only to the checking of that procedure.
@parno :  If you are satisfied with the F* solution, would you like to take a shot at updating your PR?

Sure, I can give it a whirl.  Would you suggest doing it immediately after the CheckSat (i.e., line https://github.com/boogie-org/boogie/blob/ca31fcb2636de4c1582236a8cdf42a799f0b1cae/Source/Provers/SMTLib/SMTLibProcessTheoremProver.cs#L589), or as part of Reset (https://github.com/boogie-org/boogie/blob/ca31fcb2636de4c1582236a8cdf42a799f0b1cae/Source/Provers/SMTLib/SMTLibProcessTheoremProver.cs#L609)?  The latter seems more semantically appropriate.  The former matches F*'s approach.

Also, is the test suite known to be in a passing state.  On a fresh checkout of bced465a1989df30004, when I run lit, I get:
Failing Tests (11):
    Boogie :: aitest9/TestIntervals.bpl
    Boogie :: floats/issue110.bpl
    Boogie :: livevars/bla1.bpl
    Boogie :: livevars/stack_overflow.bpl
    Boogie :: sequences/intseq.bpl
    Boogie :: sequences/intseq_datatype.bpl
    Boogie :: test15/CaptureInlineUnroll.bpl
    Boogie :: test15/CaptureState.bpl
    Boogie :: test15/IntInModel.bpl
    Boogie :: test15/ModelTest.bpl
    Boogie :: test15/NullInModel.bpl

  Expected Passes    : 482
  Expected Failures  : 3
  Unsupported Tests  : 13
  Unexpected Failures: 11

For example, test15/IntInModel.bpl fails because of differences in the model returned:
--- /Users/parno/git/boogie/Test/test15/IntInModel.bpl.expect	2021-02-04 10:02:24.000000000 -0500
+++ /Users/parno/git/boogie/Test/test15/Output/IntInModel.bpl.tmp	2021-03-31 11:06:40.000000000 -0400
@@ -4,14 +4,11 @@
 *** MODEL
 i -> 0
 ControlFlow -> {
-  0 0 -> 51
   0 25 -> (- 52)
   0 51 -> 25
-  else -> (- 52)
+  else -> 51
 }
 tickleBool -> {
-  false -> true
-  true -> true
   else -> true
 }
 *** END_MODEL

Perhaps this is based on Z3 version?  I'm using 4.8.5.  The testing documentation (https://raw.githubusercontent.com/boogie-org/boogie/master/Test/README.md) has a "" for the expected Z3 version number.

I'd like to make sure I have a good baseline before I start tampering with things.

The test suite assumes Z3 version 4.8.8.
https://github.com/boogie-org/boogie/blob/ca31fcb2636de4c1582236a8cdf42a799f0b1cae/.github/workflows/test.yml#L14

Cool, thanks for the tip.  Pointing Boogie at 4.8.8 did the trick.  Now all of the expected tests are succeeding.


Documentation

Write documentation.

[x] General Information
[x] Brew Command
[x] Flip Command
[x] Roll Command
[ ] Setup Command
[x] Wishlist Command

Created a Gitbook for documentation at https://docs.golemheart.io/.


remove all remaining references to chroma-externals

Such as update_chroma-externals and friends.

think this might be done now @brianjmurrell ?

Fixed in #146 and #147.


Compatibility document moved into the repo

I had been updating a Graphite compatibility document in the wiki section. But keeping that in step with PRs was mostly up to me and not something contributors could readily update. This moves that document to the repository as COMPATIBILITY.md - I've also taked the opportunity to update it with recent changes (and also some not so recent ones which I had missed).

LGTM


[BUILD] Increase jOOQ reactive timeout for testing

After Apache James CI issue with infra recently, the tests are somehow more unstable.
PostgresBlobStoreDAOTest.concurrentSaveInputStreamShouldReturnConsistentValues:
18:39:45.087 [ERROR] o.a.j.b.p.u.PostgresExecutor - Time out executing Postgres query. May need to check either jOOQ reactive issue or Postgres DB performance.
java.util.concurrent.TimeoutException: Did not observe any item or terminal signal within 10000ms in 'flatMap' (and no fallback has been configured)

Note that the failure rate locally is really low though...

Can we merge this @chibenwa ?


Node compile-cli problem for node

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

The log given by the failure.

Desired functionality.

Mention any other details that might be useful.

See error. Tried uninstalling and reinstalling angular-cli. Doesn't fix issue
compile-cli-problem.docx


Tabline doesn't scroll well with the active tab

http://recordit.co/469Bacb5jy
As you can see, if I have enough tabs open that they don't all show at once, the tabline doesn't scroll well. If I scroll to the left of whatever the visible list of tabs is, the list doesn't scroll to match, so I am unable to see the visible tab that is currently active

<3
This fixes the issue for me. Thank you so much for making this improvement!!


Ajax paginate

Just added a AJAX functionality to issues paginations

Seems like this languished, build's not passing, and no one has really stepped in to make a case for ajax here. Gonna close for now, feel free to re-open if anyone wants to engage in heated debate! :)


How do I raise 2 to the power of a tensor?

How do I write:
x = 2 ** (y * z)

Where y is an integer and z is a tensor?
I tried to use powf, but it only works with float arguments.

Haven't tried but I think something like the following should work: (z * (y as f64 * f64::log(2))?.exp()?

ah I should've thought of that, thanks

Closing this as done but feel free to reopen or create a new issue if you have further questions.


Say command not working

My guess is that this is due to some audio driver not being implemented, but anyways:
alex@AlexanderPC:/mnt/c/Users/Alexander$ say hi
2016-11-01 00:10:01.134 say[15] No local time zone specified.
2016-11-01 00:10:01.135 say[15] Using time zone with absolute offset 0.
2016-11-01 00:10:01.131 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.213 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.267 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.328 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.382 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.435 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.487 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.540 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.593 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.646 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.699 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.751 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.805 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.858 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.911 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:01.964 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.017 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.069 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.122 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.175 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.229 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.282 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.335 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.387 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.441 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.517 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.571 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.624 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.677 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.730 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.783 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.836 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.890 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.943 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:02.996 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.049 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.101 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.154 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.207 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.261 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.313 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.367 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.421 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.474 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.526 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.579 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.633 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.685 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.738 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.791 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.844 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.896 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:03.949 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.002 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.056 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.109 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.162 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.216 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.268 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.322 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.375 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.428 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.481 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.535 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.588 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.640 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.694 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.748 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.803 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.856 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.910 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:04.962 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.015 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.069 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.122 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.175 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.227 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.281 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.334 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.387 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.440 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.493 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.546 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.599 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.652 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.705 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.758 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.811 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.866 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.919 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:05.972 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:06.025 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:06.078 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:06.131 say[15] connect attempt failed - Invalid argument
2016-11-01 00:10:06.185 say[15] connect attempt failed - Invalid argument
say: Uncaught exception NSInternalInconsistencyException, reason: unable to contact GDNC server -
please check that the gdnc process is running.
I attempted to start it at '/usr/bin/gdnc'

Thanks for reporting the issue.  Currently WSL does not support device access, and there are a few related posts.  Closing this out as a duplicate of #237 since it is a related issue.


[Request] Add Clash for windows

Clash is a simple and powerful Proxy system. It is very easy to use and very handy!
https://github.com/Fndroid/clash_for_windows_pkg/releases

This could be Closed. This code repository has stopped maintenance and has been deleted
https://github.com/ScoopInstaller/Extras/pull/5049#discussion_r517188994


Add passphrase configuration for custom-cert keys

Would it be possible to add the parameter -passin to configure a passphrase for the key.pem file for custom certs:
https://github.com/confluentinc/cp-ansible/blob/d54f68b504093c94f7feadc8c409fa2ce842e9ec/roles/confluent.ssl/tasks/custom_certs.yml#L34-L41

Just created this PR: https://github.com/confluentinc/cp-ansible/pull/222
Please review

@domenicbove Thanks. Exactly what I needed.


[OTHER] "USE CASES" FOR ABBREVE TERMS

What would you like to share?
I think "use cases" could be added to the terms to give users more insight into the term to those who are new to it and as an illustration.
Additional information
No response

this could be added to the db.json files as "use cases".

this could be added to the db.json files as "use cases".

We are currently adjusting the structure of the database. You can check out the conversation at issue #46

Discussion for this is already going on in #42 I am going to close this issue, and you can move this conversation there :+1:


Tag aws error stats with correct error code

Fixes https://github.com/remind101/empire/issues/960.
Turns out, the Error attribute on a request.Request isn't actually real until the  UnmarshalError handler is called. The Retry handlers are called immediately after UnmarshalError, so this seems like the best place to put it.

👍


Text styled like hyperlinks leading nowhere

There are a huge number of things on this page that look like hyperlinks but don't actually lead anywhere when clicked on.
In addition, I don't feel very confident after running through this that I could create a hyperdrive experiment myself.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82c2fcdc-a4d7-20b5-a53e-33a84b723989
Version Independent ID: 9811ee46-407f-553a-4e78-214d2fdd723a
Content: Tune hyperparameters for your model - Azure Machine Learning
Content Source: articles/machine-learning/how-to-tune-hyperparameters.md
Service: machine-learning
Sub-service: core
GitHub Login: @swatig007
Microsoft Alias: swatig

HI @wamartin-aml thanks for bringing this up. Can you please point out which specific hyperlinks did not lead anywhere - i checked the page and they all seem to load for me. But if there are specific hyperlinks that i might have missed, we should correct them.
Can you also please elaborate on the other feedback? The goal of the document is to go over the concepts needed in configuring a HyperDrive experiment (the various fields in the HyperDriveConfig). Was there a specific piece for creating the experiment that was missing?
thanks.

The "Specify primary metric" header, "Specify the" in that section, "Log metrics for hyperparameter tuning" header, "The training script...run performance. (See" in that section, everything in the "Specify early termination policy" section including the header and the "Bandit policy" header below that. Looks like Rohit already has a PR fixing some of these.
As for other feedback, I think it would be helpful to see a toy example to go along with the code snippets shown, but I suppose that's what the notebook is supposed to be for. The only issue there is that there's only one hyperparameter tuning notebook I've found and it's fairly complex, with a bunch of python dependencies, gpu cluster setup, and a long runtime. It would be nice to have a simpler example just for playing around with the hyperparameter part.

@wamartin-aml, thanks for calling this to our attention. I've created a PR that resolves the hyperlinking rendering issue.
@sdgilley can you work with @swatig007 on the content items?
#assign:@sdgilley

@wamartin-aml thanks for calling out the specific hyperlink issues. We've fixed the doc to address those.
Re: the example code, it's covered in the sample notebooks. we have a bunch of notebooks showing use of HyperDrive with various ML frameworks. However, since this feature is a part of AzureML, the user needs to have access to (or create like demoed in the notebooks) resources like a ML workspace, compute, etc. Additionally, since hyperparameter tuning requires a working training script, the samples also usually go over using a training script for direct training before showcasing how the hyperparameter space can be explored for that model training.
Here's a link to a sample notebook showing how HyperDRive can be used to tune parameters for a simple MNIST model.
https://github.com/Azure/MachineLearningNotebooks/blob/master/how-to-use-azureml/ml-frameworks/tensorflow/deployment/train-hyperparameter-tune-deploy-with-tensorflow/train-hyperparameter-tune-deploy-with-tensorflow.ipynb

@PeterCLu @swatig007 Thanks for fixing the doc issue and providing the examples.
@wamartin-aml Please let us know if this helps as we can proceed to close the issue. If there are further questions regarding this matter, please tag us in your reply.

I think with those hyperlinks addressed that should all be taken care of.
@swatig007 I've gone through that notebook, there was just a lot more complexity than I wanted to understand how HyperDrive itself works.

@wamartin-aml thanks for your feedback.
The section in that notebook that demonstrates HyperDrive is: Intelligent hyperparameter tuning.
Do you have questions about that section in particular or just that the notebook as a whole goes through many other steps to show the end-to-end build and deploy scenario?

@wamartin-aml - please let us know if you have suggestions for simplifying the notebook or if you can give us further insight into any confusion.  In the meantime, I'm going to #please-close this thread as we've fixed the link problem mentioned above.
Thanks!


Add support for pixi (e.g. pixi_install_from_pyproject)

Hi there,
I see you support a poetry install from a pyproject.toml: https://modal.com/docs/reference/modal.Image#poetry_install_from_file
pixi is really fast and growing in popularity, thus please consider supporting it.
Thanks for any help!

Going to close as we don't plan to prioritize a convenience method for pixi in the near term, but feel free to reach out if you are having trouble getting it to work through Image.run_commands, etc.


Add input support to audio_codec

Is your enhancement proposal related to a problem? Please describe.
The current APIs for audio codecs contain only support for output, e.g. audio_code_start_output and audio_codec_stop_output.
Describe the solution you'd like
Add APIs to support input through audio codecs. These can largely mirror the output functions, enums etc. Additional channels for input will need to be defined
Describe alternatives you've considered
I am developing a codec driver at present and have overloaded the output functions so that they also start/stop input as well, but this does not give any fine control to the user. Also, I want to be able to mute the input while playing output, and overloading does not allow this.
Additional context
Existing audio codecs will need updating to add these functions. Certainly, the TLV320DAC 310 supports input.

need support too !

please submit a pull request with the changes you are looking for.


Allow binding to models with non public no args ctors

Since my issue #1938 seems to be getting no attention, I went ahead and fixed it in my fork.
This resolves some issues for me when model binding directly to 'domain' commands, since I don't want to promote newing them up in an inconsistent manner I've hidden the no args constructor.

Fixes #1938


Allow default delegation in SessionDelegate (with attached pr)

By default, the session delegate executes a delegate block property if it exists and then stops. I would like to be able to set various delegate closure properties that get executed but also continue with default handling. I need to be notified of a few methods being called (along with their args), but I want the default behavior to continue. I have a PR on a forked Alamofire open: https://github.com/taquitos/Alamofire/pull/1/files
I'm open to suggestions on how to accomplish, or make it better. I know that it isn't perfect as we can't add this feature to every delegate callback (because some require completion blocks to be called as part of the delegate callback), but I think keeping clear documentation and comments is the best solution.
Note: I didn't include unit tests yet as I'd like to make sure this approach is something people agree on before I invest the time. Also note that It seems like there are no tests that ensure the block properties are called in the SessionDelegate yet.

Anyway we can discuss this suggestion?

Hi @taquitos, my apologies for not getting back to you sooner.
Your use case here is completely valid, and is definitely something that you can't do with the current implementation. Essentially you'd like to be able to proxy a SessionDelegate API or two somewhere to perform some additional operations, yet still be able to use the default logic. The problem is that you can't actually do this with the basic closures or even the closures with completion.
Now I'm not entirely sure I follow what you're attempting to do in your PR, but I do have a simple solution here. I have been debating this for quite some time, and I think it might just be time to do this. If we remove the final signature on the SessionDelegate, users are free to subclass the SessionDelegate and proxy the delegate APIs as much as necessary for the use case. Here's what that "could" look like:
public class SessionDelegate:
    NSObject,
    NSURLSessionDelegate,
    NSURLSessionTaskDelegate,
    NSURLSessionDataDelegate,
    NSURLSessionDownloadDelegate
{
    // All the current implementation...
}

public class CustomSessionDelegate: Manager.SessionDelegate {
    public override func URLSession(
        session: NSURLSession,
        dataTask: NSURLSessionDataTask,
        didReceiveData data: NSData)
    {
        print("I received some data!")
        super.URLSession(session, dataTask: dataTask, didReceiveData: data)
    }
}

This would give a power user complete control over the process if they really needed. What I also like about this is that you can still use the more convenient override closures without having to subclass which is generally what you'd do in most cases. IMO, this seems like the best approach. Let's see if we can gather some feedback from some of the rest of the Alamofire team.
cc @jshier, @kcharwood, @kylef, @AnthonyMDev

I love this idea.

@cnoon I don't have any problem with this in general, but we did discuss something similar in #1099 and decided against it. These were your words:

An alternative approach to this PR would be to remove the final modifier from the SessionDelegate declaration. This would allow users to subclass the SessionDelegate which would remove the need for these variant closures. I feel though that this is not a good idea since the SessionDelegate does not publicly expose the subdelegates and opening this up could lead to misuse when subclassing.

What "misuse" were you referring to here? I think we should consider that before making this change.
Generally, I feel like this is an advanced use case, and anyone who needs to do this should be taking the responsibility to not misuse the subclass and dealing with any bugs that come of it. I think that there is a balance between making things simple for most users and protecting them from bugs and allowing the flexibility for advanced users to customize. This proposal seems to keep that balance intact to me.

I tend to agree, make things simple for normal users, but allow advanced use cases. Perhaps a good balance would be: remove final keyword from SessionDelegate, and add extra documentation and maybe an example of proper usage for advanced users in the documentation? I know we want to make it hard for people to do the wrong thing, but we also should balance that with enabling more advanced uses.
Another alternative approach could entail posting notifications for each delegate method call, and stuffing the same arguments into the userInfo object as the delegate methods. IMO this feels worse than removing "final" from the delegate, but we already have a few notifications for task lifecycle events.

The misuse I was referring to @AnthonyMDev was around the subdelegates and making sure they're still created and deallocated appropriately. I really hesitate to make them public. I just opened #1172 which should address all the concerns in this issue.
I'm going to close this issue out for now. Please direct all future comments to #1172.


Matrix: Read later / Mark as unread

This is very popular request among matrix users, and IMO it must be a core matrix functionality, rather than custom implementation. Although, i saw issues on matrix repos - like https://github.com/matrix-org/matrix-spec/issues/612 or https://github.com/matrix-org/synapse/issues/5601, or https://github.com/vector-im/element-meta/issues/347
... Since 2017 🤦
Question - how can we make it? Either help them or do a workaround or do something more "smart" 😄
No clear idea how to do this, but this is part of an issue - investigate and propose possible solutions, and implement

@yncyrydybyl can you please point to your source? I can't find it anywhere.

should be fixed with https://schildi.chat/


CASMINST-5921 License check sporadically fails

Description
License check sporadically fails to determine the list of changed files. This seems to be happening due to a bug in tj-actions/changed-files@v34, which does not filter out temporary merge commits, created by Github to assess mergeability of PR. The tj-actions/changed-files@v34 has this problem addressed.
Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see [example][1]).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in [Cray-HPE][2].
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.4

/backport release/1.3


[KARAF-5618] Upgrade to Aries JMX Blueprint 1.2.0 | [KARAF-5617] Upgrade to Aries JMX Core 1.1.8 & Whiteboard 1.2.0

retest this please

retest this please

retest this please

I'm chaging the BundleTest itest as the wiring is different.

retest this please


E2E test for examples/storm

Please provide some background about the test (either a bug, pr description or block comments around the test itself)

@bprashanth Umbrella bug: #10013
Added more By(), the test follows the scenario described in https://github.com/GoogleCloudPlatform/kubernetes/blob/master/examples/storm/README.md.

LGTM short of limits thingy.

Limits thingy fixed.

@wojtek-t


Cannot add an OpenAI api key

Describe the bug:
Cannot add openAI key
Steps to reproduce:

Install the plugin
Restart IDEA or other jetbrain product
IDE ask for a licence key
=> Stuck

Expected behavior:
Adding OpenAI key before restarting IDE or being able to add key at startup
Additional context:
None

Please select “start trial” for now，and when promo code is ready, I will send you a license :)


Automated Youtube Video Uploads

Feature: Upload newly recorded videos (private visibility, backlog playlist)

This is done, to run:
go run ./cmd/yt-uploader-v2/main.go


False positives on Ether Withdrawal

Description
The changes introduced in #1025 (presumably) cause a regression on two SWC samples:

wallet_03_wrong_constructor
wallet_04_confused_sign

In both cases, an issue is incorrectly reported in the withdraw() function.
How to Reproduce
For bytecode of wallet_03_wrong_constructor:
$ $MYTH -xc<PHONE_NUMBER>34801561001057600080fd5b506103e1806100206000396000f300608060405260043610610062576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff1680632e1a7d4d146100675780633e326048146100945780634ddaf8f2146100ab578063d0e30db0146100ee575b600080fd5b34801561007357600080fd5b50610092600480360381019080803590602001909291905050506100f8565b005b3480156100a057600080fd5b506100a96101dd565b005b3480156100b757600080fd5b506100ec600480360381019080803573ffffffffffffffffffffffffffffffffffffffff16906020019092919050505061021f565b005b6100f66102db565b005b600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff16815260200190815260200160002054811115151561014657600080fd5b3373ffffffffffffffffffffffffffffffffffffffff166108fc829081150290604051600060405180830381858888f1935050505015801561018c573d6000803e3d6000fd5b5080600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000206000828254039250508190555050565b336000806101000a81548173ffffffffffffffffffffffffffffffffffffffff021916908373ffffffffffffffffffffffffffffffffffffffff160217905550565b3373ffffffffffffffffffffffffffffffffffffffff166000809054906101000a900473ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1614151561027a57600080fd5b8073ffffffffffffffffffffffffffffffffffffffff166108fc3073ffffffffffffffffffffffffffffffffffffffff16319081150290604051600060405180830381858888f193505050501580156102d7573d6000803e3d6000fd5b5050565b600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff1681526020019081526020016000205434600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001908152602001600020540111151561036657fe5b34600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001908152602001600020600082825401925050819055505600a165627a7a72305820735f51b5302c1991fa13fe782ce8f949a28337b9fa882605ab6542e1ec5b74c90029
==== Unprotected Ether Withdrawal ====
SWC ID: 105
Severity: High
Contract: MAIN
Function name: withdraw(uint256)
PC address: 374
Estimated Gas Usage: 768 - 1239
Anyone can withdraw ETH from the contract account.
Arbitrary senders other than the contract creator can withdraw ETH from the contract account without previously having sent an equivalent amount of ETH to it. This is likely to be a vulnerability.
--------------------

==== Unprotected Ether Withdrawal ====
SWC ID: 105
Severity: High
Contract: MAIN
Function name: _function_0x4ddaf8f2
PC address: 705
Estimated Gas Usage: 1179 - 1790
Anyone can withdraw ETH from the contract account.
Arbitrary senders other than the contract creator can withdraw ETH from the contract account without previously having sent an equivalent amount of ETH to it. This is likely to be a vulnerability.
--------------------

Expected behavior
Only 1 issues should be reported.

@b-mueller , this can be closed right?

Yeah.


COSBase#toList() causes  exception

COSBase#toList() causes the follow exception:

Exception in thread "main" java.lang.IndexOutOfBoundsException: Source does not fit in dest

Looks like ArrayList<COSBase> retList = new ArrayList<>(size()); creates an array but the size is zero.

I assume you are referring to COSArray#toList(), correct?  Can you attach the stacktrace or the input file you are using?

Yes it is COSArray#toList(). Please see the stack trace below:
Exception in thread "main" java.lang.IndexOutOfBoundsException: Source does not fit in dest
	at java.util.Collections.copy(Collections.java:556)
	at org.sejda.sambox.cos.COSArray.toList(COSArray.java:483)
	at org.sejda.sambox.pdmodel.common.PDStream.getFilters(PDStream.java:198)

See: https://stackoverflow.com/q/6147650/197473

this was fixed by 653a7d794640826e494c230cdada453d8eba6ba1


[SPARK-44032][BUILD] Remove threeten-extra exclusion in enforceBytecodeVersion rule

What changes were proposed in this pull request?
This PR aims to remove an exclusion for threeten-extra dependency in enforceBytecodeVersion rule.
Why are the changes needed?
threeteen-extra library has no problem with Apache Spark 4.0.0 because Spark's minimum JDK is 17.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.

Thank you, @pan3793 and @bowenliang123 .

Thank you, @yaooqinn .

Java 21 Maven build test passed. Merged to master.


narrowing doesn't work when spreading from ternary operator

Bug Report

🔎 Search Terms
narrow spread ternary
🕗 Version & Regression Information
v4.5.0-dev.20210907
⏯ Playground Link

Playground link with relevant code
💻 Code

interface Foo {
  type: "foo"
  foo: string
}

interface Bar {
  type: "bar"
  bar: number
}

declare const thing: Foo|Bar

const otherThing: Foo|Bar = { //error: Type '"foo" | "bar"' is not assignable to type '"foo"'.
  type: thing.type,
  ...(thing.type === "foo" ? { foo: thing.foo } : { bar: thing.bar })
}

🙁 Actual behavior
error: Type '"foo" | "bar"' is not assignable to type '"foo"'.

🙂 Expected behavior
no error, since it's not possible for the object to not match either the Foo or Bar types

Related: #19513

Reminds me a bit of #30581, but more difficult to tell that we’re in that kind of scenario. It seems extremely difficult for us to do better here.


Get state property using state slice selector

Using getStateProperty after setting a stateSliceSelector begins searching at the base state, not taking into account the stateSliceSelector.
Steps to reproduce

Set stateSliceSelector in the constructor of Service.
Call getStateProperty in the same Service.
getStateProperty searches properties in the base state.

Expected behaviour
I would expect the getStateProperty to search the state in the result of the stateSliceSelector function.
Potential solutions

When using getStateProperty, check for a stateSliceSelector function, if nothing, then search at base state, if set, then begin the search at the function result.
Have a getStateSliceProperty that checks for a stateSliceSelector and begins at the result of that function.

Chosen solution

Have a getStateSliceProperty that checks for a stateSliceSelector and begins at the result of that function.

Thanks @ConnorSmith-pf - really appreciate the PR! I'm tied up right now but will try to make some time later this month to look at it more closely. On the surface it looks like a nice addition/fix though.

Sorry for the delay @ConnorSmith-pf but this looks like a great addition. Really appreciate it!


docs(tree-checklist-example): root tree node correct selected state

Fixed the checked state of the root node in the tree when the initial root state was checked, but then children were deselected, causing the root node to not update correctly.
Fixes #13314

@fabioloreggian looks like you pushed a commit signed with a different email addressed which causes the CLA check to fail.

I saw, and I am not sure why it did that. I'm trying to rectify it now.