error in build.yaml / wrong call to build coverage

In build.yaml following steps are defined:

I think the hatch run test:pytest is wrong here.
a) It calls the test environment which is managed outside in the GitHub action (beside the fact, that for coverage I think there is no difference between different Python/OS version) so this is not helpful and causes overhead.
b) pytest just does not create the coverage report that the subsequent job / codecov action wants to retrieve.
I think the right call to be
hatch test -cover
which should be executed in the "hidden" hatch-test environment
However, I  still have not yet resolved the coverage file not being found by the CodeCov action.

Fixed in https://github.com/FlorianWilhelm/the-hatchlor/pull/21


Better organization and titles for plutip tests

This change improves output of the test suite, making it more descriptive, as requested during the review process.

A version for develop: https://github.com/Plutonomicon/cardano-transaction-lib/pull/1410


Fix setuptools deprecation warning about license_file

Setuptools spews out this warning when installing the package:

The license_file parameter is deprecated, use license_files instead.
By 2023-Oct-30, you need to update your project and remove deprecated calls or your builds will no longer be supported.
See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.

This fixes that by switching away from the deprecated license_file setting to instead set licence_files.
license_files has been available since setuptools 42.0.0 released on 23 Nov 2019. license_file has been marked as deprecated since setuptools 56.0.0 released on 8 Apr 2021.

this will be handled automatically in setup-cfg-fmt at some point -- I'd prefer to let that just do it

For reference it has been fixed here: https://github.com/shellcheck-py/shellcheck-py/commit/d36de88ab407394919f9e8dfbaec50fa16a63f5a.


Enhance Readability of Air Quality Text

Description:

Current Behavior:  The text color for air quality information is difficult to read.

Expected Behavior: The text color or the background of the text should be more user-friendly and easy to read.

Steps to Reproduce:

Open the weather app https://avinash201199.github.io/weather-app/
Search for cities having different air quality.
Notice that it's hard to read for some air quality.

Screenshots:

Suggested Fix:
The background color of the text of air quality should be based on the Air Quality Index (AQI) to provide better visibility and context for different AQI levels.

Good: Green color
Satisfactory: Yellow color
Moderate: Orange color
Unhealthy for Sensitive Groups: Reddish color
Unhealthy: Red color
Very Unhealthy: Purple color
Hazardous: Maroon color

Please assign this issue to me under hacktoberfest'23


Responsive UI for mobile devices

This site is really useful, but the UI does not work well with mobile devices, specially with smartphones. It would be good to make this site responsive so that it can scale to be displayed in smaller screens.

Thanks, I don't think we currently have bandwidth for this, but patches are always welcome.


Home page creation

Create a gallery page :
It should feature the following :

The hero section of the home page should have a background image and a logo with the center as absolute position and some text. [Refer to the image below to have a rough idea of the mentioned]
After the hero section, we need to add an about us section, and following we add the team section
For reference of teams section refers to the team's page of RWOC website.

color pallet :
Red orange - #FD383B
Dark shade of Grey - #1E1E1E
Metallic Silver - #A8A9AD
// you can use online color grabbers like the ColorZilla.
**** Create an external CSS and a separate HTML for the Home page****

Sure! @anou1234

@anou1234  This will be assigned to two members. Are you ok with that.


DietaryRestriction Usecase

Contains all the files for the DietaryRestriction usecase along with some modifications to the viewmanager, viewmanagermodel, and profile to accommodate the usecase

DietaryRestrictionDataAccessInterface should be placed in the use_case folder, not in the data_access folder, to adhere to the Clean Architecture structure.


Feature Request: LDAP Login Integration

Didn't see any mention of this so I'm assuming this is not yet implemented, but it would be great to offer an integration with LDAP so users can log in using OpenLDAP credentials for example. SSO support is critical imo for any organization that has more than 3 systems.

It certainly seems like a good idea, though I have no idea how much work it'd take. I'll have to think about it.


Hardware setup

Great project! I'm looking for info about the rest of your hardware setup in addition to the MAix board, such as; power management HAT, power source, cell modem or usb storage, etc.
Thanks!

Sorry for the delay. I've been very busy. Most of the project works but there was an issue with the regulator not doing what the specs said it should. I'll likely be doing more work on this over the next few months.


createRoom should be idempotent

to stop all the clients which don't debounce start chat buttons properly

what kind of approach did you have in mind? The spec so far uses the last parameter to act as a transaction ID - does it make sense to use this same format here?

what kind of approach did you have in mind? The spec so far uses the last parameter to act as a transaction ID - does it make sense to use this same format here?

Yes, to just slap a txn ID on it and use PUT rather than POST.


Text highlight barely visible in Nord theme

Highlighting text in TextField or TextArea components is barely visible in Nord theme, especially in Dark mode. This is very visible even in the Sampler app.
NB: This is also true for selection color in ListView, TableView etc components, most visibly in striped mode. I think it would be worth revisiting the global highlight color.

Nord lacks some contrast. That's ok, original theme doesn't have much contrast as well. But I see your point and keep this as a reminder.

I'm all for low contrast, but I think there is a more concrete issue here.
If you look at the screenshot below, the ListView has a correct contrast highlight on the selected item. But in the TextField where the cursor is I selected the word StockFish and there is no real way of saying what is selected. I think it should have the same selection color as the ListView.

For reference here is a screenshot of the Emacs Nord theme which also contrasts selection a but more.


Process math with markdown-it-mathjax

Possible fix of #91. Unsure if it causes any regression with respect to #14/#15.

Pull Request Test Coverage Report for Build 292

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 69.039%

Totals

Change from base Build 278:
0.06%

Covered Lines:
320

Relevant Lines:
438

💛  - Coveralls

Also worth considering replacing mathjax with katex: https://github.com/danielwe/markserv/tree/katex


fix logout button bug

When I run flask application. There is an error
Uncaught TypeError: Cannot set property 'onclick' of null

1.I found that I should put the following code in index.html instead of base.html. Because the base.html should not have log out button. That fixation works.

Secondly, in view.py, when we get user profile from GraphAPI, we should consider that someone may not have link property like me. So we should add an if statement in get_current_user function.

Hope my solution is right, and I make a pull request.

Since this pull request contains two changes (moving the logout JavaScript to index.html and handing user profiles without links), could you rebase it so it contains two commits?

Thank you. I create a new pull request following your advice.


Apache-composer command usage bugs collection

Similar wit: https://github.com/IBM/kui/issues/54#issuecomment-444566451

When users click an entity in usage model, maybe it's more reasonable to just promote the command in the REPL instead of executing the command.


Add 'iexact' to available filters

Hi, I have added 'iexact' to the list of available filters.
https://docs.djangoproject.com/en/2.1/ref/models/querysets/#iexact

:+1:


npm run serve fails in my spfx 1.15.2 project

Hi Sergei, love fast-serve:)
Recently i upgraded a project to spfx 1.15.2 and suddenly npm run serve stopped working
Hope that you can shine some light on it?
"node": "16.15.1" and "spfx-fast-serve-helpers": "~1.15.0"
[14:02:18] Build tools version:3.17.19
[14:02:18] Node version:v16.15.1
[14:02:18] Total duration:1.02 min
[14:02:36] [fast-serve] To load your scripts, use this query string: ?debug=true&noredir=true&debugManifestsFile=https://localhost:4321/temp/manifests.js
i ｢wds｣: Project is running at https://localhost:4321/
i ｢wds｣: webpack output is served from https://localhost:4321/dist/
i ｢wds｣: Content not from webpack is served from ..\Contract Management
i ｢wds｣: 404s will fallback to /index.html
..\Contract Management\node_modules\webpack\lib\Dependency.js:339
throw new Error(
^
Error: module property was removed from Dependency (use compilation.moduleGraph.updateModule(dependency, module) instead)
at ProvidedDependency.set (..\Contract Management\node_modules\webpack\lib\Dependency.js:339:9)
at iterationDependencies (..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\Compilation.js:940:21)
at ..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\Compilation.js:950:8
at ..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\NormalModuleFactory.js:409:6
at ..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\NormalModuleFactory.js:155:13
at AsyncSeriesWaterfallHook.eval [as callAsync] (eval at create (..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\tapable\lib\HookCodeFactory.js:33:10), :6:1)
at ..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\NormalModuleFactory.js:138:29
at ..\Contract Management\node_modules\spfx-fast-serve-helpers\node_modules\webpack\lib\NormalModuleFactory.js:346:9
at processTicksAndRejections (node:internal/process/task_queues:78:11)

Hi, in such cases I usually suggest completely removing node_modules and package-lock.json, then reinstalling all dependencies. Could you try it?

Thanks Sergei, I did a m365 cli project upgrade so i was obviously wrong in my assumption that i didn't need to clear node_modules and the lock file...
Did what you said and... it worked... thanx


registering buffer classes in kryo

solves #127

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/147/
Test PASSed.

Merged build finished. Test PASSed.


At Ubuntu installed by Japanese locale setting, the error occurs

When I tried PlutoPlotly, Error was occured like next.
julia> using PlutoPlotly
Precompiling PlutoPlotly
         Info Given PlutoPlotly was explicitly requested, output will be shown live
ERROR: LoadError: InitError: StringIndexError: invalid index [41], valid nearby indices [39]=>'プ', [42]=>'\"'
Stacktrace:
  [1] string_index_err(s::String, i::Int64)
    @ Base ./strings/string.jl:12
   [2] SubString{String}(s::String, i::Int64, j::Int64)
    @ Base ./strings/substring.jl:35
  [3] SubString
    @ ./strings/substring.jl:41 [inlined]
  [4] SubString
    @ ./strings/substring.jl:47 [inlined]
  [5] SubString
    @ ./strings/substring.jl:43 [inlined]
  [6] getindex
    @ ./strings/substring.jl:292 [inlined]
  [7] parseuserdirs(configdir::String)
    @ BaseDirs ~/.julia/packages/BaseDirs/tgw06/src/unix.jl:23
  [8] reload()
    @ BaseDirs ~/.julia/packages/BaseDirs/tgw06/src/unix.jl:56
  [9] __init__()
    @ BaseDirs ~/.julia/packages/BaseDirs/tgw06/src/BaseDirs.jl:38

I found the error unix.jl:23 of BaseDirs.jl.
I am using Ubuntu 23.10 installed with Japanese locale.
Default ~/.config/user-dirs.dirs is like next at Japanese locale.
# This file is written by xdg-user-dirs-update
# If you want to change or add directories, just edit the line you're
# interested in. All local changes will be retained on the next run.
# Format is XDG_xxx_DIR="$HOME/yyy", where yyy is a shell-escaped
# homedir-relative path, or XDG_xxx_DIR="/yyy", where /yyy is an
# absolute path. No other format is supported.
#
XDG_DESKTOP_DIR="$HOME/デスクトップ"
XDG_DOWNLOAD_DIR="$HOME/ダウンロード"
XDG_TEMPLATES_DIR="$HOME/テンプレート"
XDG_PUBLICSHARE_DIR="$HOME/公開"
XDG_DOCUMENTS_DIR="$HOME/ドキュメント"
XDG_MUSIC_DIR="$HOME/ミュージック"
XDG_PICTURES_DIR="$HOME/ピクチャ"
XDG_VIDEOS_DIR="$HOME/ビデオ"

The cause of the error is the value[2:end-1] part.
I tried to reproduce the error with REPL, next.
julia> line="XDG_DESKTOP_DIR=\"\$HOME/デスクトップ\""
"XDG_DESKTOP_DIR=\"\$HOME/デスクトップ\""

julia> key, value = split(line, '=', limit=2)
2-element Vector{SubString{String}}:
 "XDG_DESKTOP_DIR"
 "\"\$HOME/デスクトップ\""

julia> value[2:end-1]
ERROR: StringIndexError: invalid index [41], valid nearby indices [39]=>'プ', [42]=>'\"'
Stacktrace:
 [1] string_index_err(s::String, i::Int64)
   @ Base ./strings/string.jl:12
 [2] SubString{String}(s::String, i::Int64, j::Int64)
   @ Base ./strings/substring.jl:35
 [3] SubString
   @ ./strings/substring.jl:41 [inlined]
 [4] SubString
   @ ./strings/substring.jl:47 [inlined]
 [5] SubString
   @ ./strings/substring.jl:43 [inlined]
 [6] getindex(s::SubString{String}, r::UnitRange{Int64})
   @ Base ./strings/substring.jl:292
 [7] top-level scope
   @ REPL[4]:1

An error occurs when accessing the second and subsequent bytes of a multibyte character using index.
The fixes I can think of are
replace(value, r"^\"" => "", r"\"$" =>"")
or
strip(value, '"').
julia> replace(value, r"^\"" => "", r"\"$" => "")
"\$HOME/デスクトップ"

julia> strip(value, '"')
"\$HOME/デスクトップ"

In environments without Japanese fonts, the characters may not be visible. Sorry.

Thanks for both raising this issue ujimushi and doing such a thorough investigation into the root cause, this is tremendously helpful! :grinning:
I've just fixed this, and gone a step further and looked for any other instances of offset-based string indexing like this that could cause a similar problem. I've found a few others, and fixed them too. I've also added a new testset based on the details you've so kindly provided here. See 742caa35640fc4327dd9f068e8aaa99393b9fdf2.
I'll release a patch version (probably v1.2.3) shortly :slightly_smiling_face:.
Thanks again!


[FEAT] Added TSMixerx model

This PR adds the TSMixerx model into neuralforecast (in the paper referred to as TSMixerExt), which provides support for exogenous inputs, and demonstrates its application in a Multivariate_with_TSMixer example notebook.

Added TSMixerx and AutoTSMixerx models to NeuralForecast
Included tests in core class
Included performance evaluation in example notebook.
Updated some codeparts from TSMixer for consistency with TSMixerx

... attempt 2, previous branch went into merge conflict hell.

Could you check whether I've implemented the addition of the exogenous variables in the example correctly?


Fix space regression

In old versions of WebKit, with CodeMirror's wrap mode enabled, an odd behavior happens. That is, the first whitespace keypress in a sequence is not displayed until another space is added.
This is the commit that introduced the issue: https://github.com/codemirror/CodeMirror/commit/e60f4b7dd88b71e227f79200932c028ca047d78e
I have added a special case to the code to fallback to the old method in case an old version of WebKit is used.

My Chrome 52 matches as Webkit 537, so this also applies to recent versions of Chrome (which don't suffer from issue #237), and breaks the fix for #4097 there. I don't think that's acceptable.
(Also, if someone's userAgent string happens to contain Webkit/ without a number following it for some reason, this'll crash the library on startup.)


[ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: NoSuchMethodError: The getter 'focusScopeNode' was called on null.

Microsoft Windows [Version 10.0.18362.418]
(c) 2019 Microsoft Corporation. All rights reserved.
C:\Saravanan\i-eX_Driver\iex_driver>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel master, v1.10.15-pre.137, on Microsoft Windows [Version 10.0.18362.418], locale en-IN)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Android Studio (version 3.5)
[√] Connected device (1 available)
• No issues found!
C:\Saravanan\i-eX_Driver\iex_driver>

Thank you @saravananmnm for the report! Can you come up with a small self-contained app that reproduces the problem? You can include small examples inline if they're enclosed by backticks, or just provide a public link to a github "gist" - https://gist.github.com/.

I am also facing this issue,please support me for solve this issue

i get this error several times a day. it's harmless, but it's annoying, because it spams up the terminal, obscuring my own terminal output that i need to see for debugging.
it's going to be very difficult to isolate a test case. i spent several hours on it and gave up. could you guys please just take our word for it that this is happening? the fix is very easy.
in (package:flutter/src/widgets/navigator.dart:139:17) --
@protected
@mustCallSuper
TickerFuture didPush() {
return TickerFuture.complete()..then((void _) {
navigator.focusScopeNode.requestFocus();
});
}
all you have to do is change that one line to:
if (navigator != null) navigator.focusScopeNode.requestFocus();
... and the problem would be fixed. (or use the ? operator, i guess. personally i never do, because i think it's ugly and obscures intent.)
i keep making this fix in my own copy of flutter, and of course it keeps getting overwritten on every update.
please, guys. put me out of my misery.


[Twitch] mobile version (m.twitch.tv) support

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.03.08
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

 youtube-dl -v https://m.twitch.tv/rossbroadcast/clip/ConfidentBraveHumanChefFrank
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://m.twitch.tv/rossbroadcast/clip/ConfidentBraveHumanChefFrank']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.03.08
[debug] Python version 2.7.12 (CPython) - Linux-4.4.95-i686-athlon-with-glibc2.7
[debug] exe versions: ffmpeg 2.8.11, ffprobe 2.8.11, rtmpdump 2.4
[debug] Proxy map: {}
[twitch:stream] rossbroadcast: Downloading stream JSON
ERROR: rossbroadcast is offline
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info
    ie_result = ie.extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/twitch.py", line 582, in _real_extract
    raise ExtractorError('%s is offline' % channel_id, expected=True)
ExtractorError: rossbroadcast is offline

Description

WRITE DESCRIPTION HERE
If you try to use yt-dl on mobile version twitch URLs, e.g. this clip:
https://m.twitch.tv/rossbroadcast/clip/ConfidentBraveHumanChefFrank
they are not working as expected, instead they are all treated as a main channel URL (presumably) and report the link being offline (or starting to play a live stream, if it's online).
Workaround: they are working as intended just after deleting the "m." prefix from the link.
This issue was found after trying to play just a couple of clips by feeding mobile links to mpv, so it can be wider than reported here (not every possible combination of links is tested). Hopefully it can be fixed just by cutting the "m.".

https://github.com/ytdl-org/youtube-dl/blob/6a6e1a0cd8bacf5a23f731eedaa1783503470227/youtube_dl/extractor/twitch.py#L646
Given this line, the extractor for twitch clips is simply not recognizing links from the mobile version, and it seems looking up the main stream is the fallback action for twitch links. I will change the regular expression to include the mobile versions and test it.


Build: Add support for pg 12

JIRA: MADLIB-1391
This commit adds the necessary files for PG12 support and makes a few changes
in the backend.
The FunctionCallInfoData struct from postgres has been changed to
FunctionCallInfoBaseData. This new structure replaces the "value" variable with
"value" and "isNull". We made changes in the backend to handle this new
struct.
Co-authored-by: Nikhil Kak<EMAIL_ADDRESS>

[ ] Add the module name, JIRA# to PR/commit and description.
[ ] Add tests for the change.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/1182/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/1183/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/1186/


feat: setup release please.

Fixes https://github.com/microsoft/kiota-abstractions-python/issues/174

Sets up release please for merged repository.
Migrates changelogs from individual library repositories.
Updates source to read version from toml rather that being hand set in _version.py files in various projects.
Sets all project versions to 1.3.4 to be the highest for the next release.

Just ensured the app was installed on this repo


Release 0.3.0

It seems it's time to tag a new release. For ease of reviewing, a copy/paste of changelog addition is below.
I tried to make it smaller, omitting some intermediary changes and trying to focus on what was changed since 0.2.19.

[0.3.0] - 2023-08-01
This is a major release, which allows more fine-grained exceptions
configuration. Instead of merely excluding some files from being checked,
it is now possible to ignore specific well known errors for some specific
files or directories in a specific RPM packages, or components, or tags.
In addition, per-rpm configuration rules ([rpm.xxx], previously known as
[node.xxx]) are now applicable to payload and image scans, alleviating the need
to duplicate the exclusions.
The exceptions printing (-p) now prints exceptions in the new format (per-error,
also per-rpm, if possible, or per-component, or per-tag), making it easier to
maintain configurations.
Another notable feature is that a versioned configuration is not merged into
the main one, rather that replacing it, allowing to specify exclusions common
to multiple OpenShift versions to a main configuration file.
The configurations were rewritten mostly using the new rules. Due to this,
some previously added exceptions might be lost and need to be re-added.
Some validations of configuration were added, and invalid configurations might
be rejected now (or warned about, depening on the severity). An example of such
bad configuration is a non-canonical (non-clean or not absolute) file name.
A bunch of performance optimizations has been made, and the tool no longer
requires "file" and "go" binaries to be present on the system.
Features

Ensure the configuration is fully parsed
Remove dependency on go binary
Rename node ignores to rpm ignores in configs
Use rpm name only (not name-version-release.arch) in configs
Report rpm name in image/payload scan results
Use per-rpm config filters in image/payload scans
Add tag and rpm support to displayExceptions
Show component, tag, rpm in log
Unify node and payload/image reports
Add known errors
Add ability to ignore specific known errors for specific files/dirs
Display exceptions in the new per-error format
Major config facelift using (mostly) per-error exclusions
Make the versioned config (e.g. -V 4.12) added to the main one,
implement config merging with duplicate checks
Add configuration validation (absolute/clean URLs, etc)

Bug fixes

Node scan: use dbpath in all rpm calls for node
Add warning where there are no build tags in Golang binary
Fix "Successful run" message when there are warnings
Log the entire configuration, not a part of it
Check for and report errors from isGoExecutable
node scan: report warnings as such
Hide "found operator" messages under increased verbosity level
Do not ignore rpm -qa errors from node scan
Add/use getTag, getImage, getComponent to avoid potential nil dereferences
Report, do not lose error from filepath.WalkDir
Log inner path in node scan
scan payload: require either --url or -- file

Performance

Store semver in baton
Instantiate go semver constraint only once
Instantiate go tag mapsets only once
Optimize validateGoVersion, add a benchmark
Improve regexp use in validateGoTags, add a benchmark
validateGoTags: simplify and speedup
validateStringsOpenssl: simplify and speedup
ReadTable: do not build a map
Skip all files with no x bit set
Use debug/elf (rather than spawning file tool) to detect static binaries

Code cleanups

Removal unused code and variables
Unify loop in scanBinary
ExpectedSyms: document, refactor, return bool
Simplify displayExceptions
Remove tag argument from validation functions
Move rpm-related functionality to a separate package
Simplify file mode check in RunNodeScan
Simplify returns from validateTag
Simplify return from RunOperatorScan
Remove tag and component arguments from ScanBinary

Miscellaneous

Add OWNERS file
CI: add golangci-lint timeout
GH: add dependabot configuration
GH: add ok-to-test label to dependabot
Add vendor directory
CI: add make test
CI: test that embedded configs are sane
CI: tests for config merge

/lgtm


[Sema] When resolving type declarations, if there is an error with a typealias,...

... check to see if the type alias refers to any associated types to maybe display a bad conformance diagnostic.
Partially resolves SR-8813. (Arguably, we should be inferring a valid witness for Value here, but since we aren't, we should definitely be diagnosing it.)
Rather than put the ASTWalker here, would it be better to move it into TypeRepr.cpp via adding a member TypeRepr::visitTypeReprs(llvm::function_ref<void(TypeRepr *)>visitor)?
Relatedly, I noticed that TypeRepr::visitTopLevelTypeReprs() currently has no callers. Should I remove it in this or separate PR?

@swift-ci Please smoke test.

Tests?

@slavapestov Yep, will do! Have any opinion on the TypeRepr members?

@gregomni After looking at the test case, this feels like a workaround for a bug in associated type inference. I'd rather not add complexity to the type resolution code, which is already very complex, to deal with this particular issue.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

@swift-ci Please smoke test.

This is much better, thanks! It looks like you fixed compiler_crashers_2/0127-sr5546.swift as well, do you mind moving it to compiler_crashers_2_fixed? I'll dupe the SRs too.

@swift-ci Please smoke test.


In-progress games show up on game list

This is unexpected behavior, although does not pose any problems, just a visual bug

We can put "in progress" injected into the game title

Fixed in Robo v1.01


How to apply MeiliSearch to VuePress?

Hello!
Is it possible to provide a tutorial on applying MeiliSearch to VuePress?
I used to use Algolia as Vuepress's search engine, but it required A lot of rent.
I was glad to find MeiliSearch. This search box is awesome.

But I don't know how to write JS code, to apply MeiliSearch to VuePress.
Hope to get your tutorial or guidance.

Hello,
Thanks for your interest in MeiliSearch and in our new documentation search bar ♥
I'm the one who works on the Vuepress search-bar on our MeiliSearch Documentation :) We've just integrated it one week ago.
Now, we plan to do:

a Vuepress plugin for MeiliSearch
a detailed tutorial to explain how to integrate MeiliSearch in your own documentation.

Both of these points are still a work in progress, and I will keep you in touch. It should be available in the next few weeks 🙂

Thanks so much. Then thousands of VuePress users will be able to upgrade their search box.

I would like to keep the issue open, this way other interested people could find this issue ;)

I close this issue in favor of meilisearch/backlog#9


UX: Improve readability for ISIS workflows

Implements changes as suggested for guideline addition in scipp/essreduce#22.
This goes one step further and also improves the currently very confusing way of switching between tutorial data from pooch and "local" data.

I think I address all comments now. FilePath and DataFolder are gone. Ready for another review!


Transport action support for deny privileges

Codecov Report

:exclamation: No coverage uploaded for pull request base (schema_privileges@474eac0). Click here to learn what that means.
The diff coverage is 53.33%.

@@                 Coverage Diff                  @@
##             schema_privileges    #5817   +/-   ##
====================================================
  Coverage                     ?   83.14%
  Complexity                   ?    12071
====================================================
  Files                        ?     1421
  Lines                        ?    46149
  Branches                     ?     5728
====================================================
  Hits                         ?    38369
  Misses                       ?     5111
  Partials                     ?     2669

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/io/crate/analyze/user/Privilege.java
83.01% <0%> (ø)
17 <2> (?)

...rate/operation/user/TransportPrivilegesAction.java
89.58% <88.88%> (ø)
17 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474eac0...2a34d9b. Read the comment docs.


Fix E2 Permission Escalation Using Code Upload

Updates a chip's owner when uploading into it if the current chip owner does not match the uploading player.
Fixes #929 (thanks to @adosikas for mentioning this here https://github.com/wiremod/wire/pull/2157#issuecomment-821809937)
Solution is only a few lines, only difficulty was updating the E2 chip's overlay which uses a completely undocumented function ENT:GetPlayerName(), which is set using another undocumented function ENT:SetPlayer().

How about simply blocking the upload?
You know, like I suggested 5 years ago:
https://github.com/wiremod/wire/issues/929#issuecomment-124960778

I actually like @thegrb93's suggestion in the next commit, but you need to persist the "do not run" flag through dupes, otherwise you'll just delay the issue.
How does your fix address this, btw?

reviews 6 year old comments on the original issue
I think the main downside of this is:

newbie makes a chip, its not working, asks for help
Neb (as an admin, or PP friend) takes a look, fixes the bug, hits Upload and Exit
the chip is now Neb's, so newbie can't access it without Neb granting him PP access

Your #2157 PR does at least mean in that last case, the newbie can at least request to read the updated version of previously-their-chip, but its a bit inconvenient if they need to then rewire the chip to actually use it... hmm...
I don't think thats a blocker, and the security benefit you're proposing probably outweighs that con, but how do you feel about:
When you update someone else's chip, for E2 purposes the owner changes, but for PP purposes the owner remains the original. ie, the code's owner changes, but the gmod_entity's owner (who created the physical Entity into the world, and welded it to their ship, and wired it to their screen) remains. I think that'd just mean removing the SetOwner/CPPISetOwner lines, and adding a comment explaining that this distinction is intentional.
Then, if the ownership of the code isn't critical to the function of the chip (eg. it doesn't hover above owner()'s head), this workflow makes intutive sense. If the ownership does matter, then (as opposed to prior to this PR), there's simply a 4th step of the newbie resaving the chip, which seems like something users would figure out.

That'd be confusing as hell to have different PP and E2 owners. Let's not do that.
This issue you're fixing here only exists if someone has the right to right-click your chip but not to left-click it.
I wonder what change made that distinction possible.

Naw, all of this is still pertinent without #2157's changes, since PP can often be one-directional: an admin can do anything (eg. fix a chip) to a newbie, a newbie can't write or (without #2157) read an admin's chip, so if all chips an admin writes becomes the admin's, its kinda hard to collaborate.
Its slightly confusing, but I don't think it'd actually come up much. Its not like E2 programatically exposes the PP owner, so for all E2/code purposes "the owner changed" (which is different behaviour than we've had for the last decade, and thus by default I dislike the backwards compatibility change, but we've acknowledged the security hole it leaves for 6 years now), the PP staying is an implementation detail nobody'll notice - unless you can think of a semi-common use case this would affect/break.

Ok let me summarize @thegrb93's suggestion, together with my improvement and a suggestion on how to implement it:

Uploading to a chip that is not your own adds "@disabled\n" at the top
If a chip starts with "@disabled\n", it is not run at all. Basically all further processing steps will receive an empty string
If the user wants to re-enable the chip, they simply remove line 1 and click Upload & Exit

@TomyLobo

How about simply blocking the upload?

Actually joked about this on Discord but you did in fact find a reason why this extremely simple fix wasn't adequate.
@Nebual not setting the CPPI and SENT owner is fine (only set them towards the end of testing this so I know not setting them works), seems like all of the internals just rely on chip.player anyway (and that undocumented func), I'll push those changes now.

Tomylobo's solution also seems acceptable, if a bit less streamlined for collaborating.
I'd tolerate either but I prefer 100PX's with CPPI left original - perhaps we can try that, and if the community hates it or finds it buggy/conflicting, we can pivot to the safer but less-streamlined "@disabled" solution.

If you want a more streamlined solution, have it as a separate flag, but make damn sure it never ever gets discarded

@TomyLobo why use a flag when you can literally prevent a user from impersonating another user at all?

@TomyLobo why use a flag when you can literally prevent a user from impersonating another user at all?

How certain are you that your change actually does that?

@TomyLobo because I tested using concmd mainly, possibly the most harmful function to have run on another player

oh so you just lack imagination, got it.

@TomyLobo well given you can literally run concmd as another user without this PR, have you considered the security implications of that?

First of all, you can run concmd as someone else only if they give you PP and that was, so far, always the end of what we cared about, security-wise, anyway.
Second, we're not talking your solution vs. nothing, we're talking your solution vs. mine.

@TomyLobo then implement your solution and either PR, upload, or merge so we can compare the differences in what they allow.

so why not use the suggestion by myself and @thegrb93 as seen here
https://github.com/wiremod/wire/issues/929#issuecomment-125074292
and here
https://github.com/wiremod/wire/issues/929#issuecomment-125106689

@TomyLobo

I'm talking about what mixed-owner contraptions mean, security-wise. Have you even considered that?

You realise that mixed owner contraptions are already possible with wire, and function no differently given each chip is individual?

edit 2: anyway I'm fine with the change in this PR. it might be a little bit confusing sometimes but I don't see anything wrong with it.

I'm not fine with it, since it allows you to change ownership of an entity, which is not something wire currently does.
We shouldn't merge a potentially dangerous stop-gap if there's a simple solution that doesn't share this issue, waiting to be implemented

You realise that mixed owner contraptions are already possible with wire, and function no differently given each chip is individual?

Now make up your mind, do you trust people you shared PP with or not?
If you do, then your other PR makes no sense.
If you don't, then this one doesn't.

3. "If there's a simple solution", doesn't get much simpler than 8 lines (or 5 LoC).

Challenge accepted aaaand met:
https://github.com/wiremod/wire/pull/2162
boom, merge, test and ship

#2162
I can feel my braincells slowly dying after this.

I don't see anything wrong with this implementation. Probably just needs a bit of testing.

I'm fine with merging as long as any issues found are fixed by @100PXSquared . Otherwise we can just revert the changes.

Since nobody else is going to open their notepad and fix the issue. (I saw @TomyLobo at least tried, but that solution is not great)

What's the worst that can happen? The original owner able to applyForce the uploader's props? I don't think there'll be any issues.

I'll give it a day to simmer

@TomyLobo given before everything a player did inside a script uploaded to another player’s E2 ran as the owning player, this gives no additional access by not updating the CPPI or SENT owner, as you could already modify the owning player’s props with a code upload.

I like the internal e2 owner change idea—it lets other people safely upload to your chip without it halting their code.

I think a solution like this is better thegrb93/StarfallEx@592a3c2

I think a solution like this is better thegrb93/StarfallEx@592a3c2

What happens if you dupe a contraption that contains this chip?

I think a solution like this is better thegrb93/StarfallEx@592a3c2

What happens if you dupe a contraption that contains this chip?

All works fine

I think a solution like this is better thegrb93/StarfallEx@592a3c2

What happens if you dupe a contraption that contains this chip?

All works fine

That's literally the least specific you could have been :)
How did you try to break it and in what way does it "work fine"?

I think he means nothing breaks.  Unless you specify what should happen when a contraption is duped, his implementation is okay.

I think he means nothing breaks. Unless you specify what should happen when a contraption is duped, his implementation is okay.
[EDIT] starfalls are also rarely duped

I make lots of dupes with starfall

sigh you're the worst support customers...
Can you please define "okay"?
I'm sure it won't crash or anything, so at that very basic level it's probably okay, I figured that much before asking.
I asked for what you do to determine it's "okay" and what result constitutes "okay".
Specifically if you upload code to my chip, I dupe it and then your code runs, is that "okay" for you (because that wouldn't be okay for me)

Yes, and that is ok

how visible is this when the chip is buried in your contraption somewhere?

Well @TomyLobo if I also error the chip like sparky does in his commit to Starfall, then you'll see the errored chip due to the red highlight.

how visible is this when the chip is buried in your contraption somewhere?

If you're worried about this, you should also be worried about someone putting their own e2 in your dupe. I recall and 'e2 virus' using this mechanism.

Although @thegrb93 I would rather not halt the chip at all, updating the owner could theoretically cause some confusion, although I doubt that much, halting the chip however makes collaboration significantly harder (I also think removing updating the owner from Starfall in favour of halting the chip is worse for the same reason, and regarding confusion, I literally never found anyone confused with SF owners updating, hell I didn't even really notice them changing automatically myself, just felt natural).

how visible is this when the chip is buried in your contraption somewhere?

If you're worried about this, you should also be worried about someone putting their own e2 in your dupe. I recall an 'e2 virus' using this mechanism.

hmmmm, true, if they have PP, they can weld stuff to your contraption.
I'm actually not sure though, does advdupe/advdupe2 duplicate entities that are not your own?

how visible is this when the chip is buried in your contraption somewhere?

If you're worried about this, you should also be worried about someone putting their own e2 in your dupe. I recall an 'e2 virus' using this mechanism.

hmmmm, true, if they have PP, they can weld stuff to your contraption.
I'm actually not sure though, does advdupe/advdupe2 duplicate entities that are not your own?

@TomyLobo just tested with Adv Dupe 2, they copy (and swap owner to the duping player as expected)

that leaves advdupe1 (and probably garry's duplicator, too)

Although @thegrb93 I would rather not halt the chip at all, updating the owner could theoretically cause some confusion, although I doubt that much, halting the chip however makes collaboration significantly harder (I also think removing updating the owner from Starfall in favour of halting the chip is worse for the same reason, and regarding confusion, I literally never found anyone confused with SF owners updating, hell I didn't even really notice them changing automatically myself, just felt natural).

There's some cases where issues could happen. I don't think collaboration will have any negative impact

Although @thegrb93 I would rather not halt the chip at all, updating the owner could theoretically cause some confusion, although I doubt that much, halting the chip however makes collaboration significantly harder (I also think removing updating the owner from Starfall in favour of halting the chip is worse for the same reason, and regarding confusion, I literally never found anyone confused with SF owners updating, hell I didn't even really notice them changing automatically myself, just felt natural).

There's some cases where issues could happen. I don't think collaboration will have any negative impact

Changing the owner also felt completely natural to me (not to mention nobody on my server has ever complained about it working that way)
Could you describe in specific where "issues could happen"?  Aside from the niche case the owner HAS to stay the same (in which case you could just hardcode your chip to find the correct owner), I see no issues.

Pretty much 'niche case the owner HAS to stay the same'

This was reverted and replaced with @disabled by @TomyLobo last year, however despite the vote that was taken in the Discord server being marginally in favour of @disabled, multiple people dislike it as it makes collaboration needlessly annoying.
I would suggest undoing the decision to revert this and add @disabled instead, as the only downside with my implementation is possibly unexpected behaviour if you're used to the way E2 currently handles the owner. Although I think most people will find the owner being the person who ran the chip more intuitive.
(from #off-topic today)

Seconded. Having @disabled added to the chip any time I'm collaborating with somebody is incredibly annoying.


Introduce build path on BuildIdentifier

Historically, BuildIdentifier relied on the build name to identify the build. However, since the name of the build is not necessarily unique in the build tree, an actual identity path of the build has to be tracked separately.
Until recently, it was possible to convert a build name into a build path, because all nested builds in a composite builds were "flattened". This changed with the introduction of the qualified build paths. Now, the build-name to build-path is not possible without additional information.
This PR changes the BuildIdentifier implementations to be based on an actual build path and introduces a new getBuildPath(): String method on the BuildIdentifier interface.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test PRF

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and merge

I've triggered a build for you.

@bot-gradle cancel

I've cancelled the pre-tested commit build.

@bot-gradle test and merge

I've triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

I've triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

I've triggered a build for you.


MSID: 89023 Version: 2 DOI: 10.1101/2<IP_ADDRESS>3136

MSID: 89023
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>3136
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89023
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>3136

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89023v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>3136
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89023/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

@acollings Can I double check the keywords in the assessment are correct here: convincing + incomplete?

Hi @naushinthomson yes, thanks for checking! (It's not what I'd have done, but this was intentional)


Feat: remove delegated wallets on wallet forget

Changes:

Updated forget-wallet-model to remove delegated wallets and accounts, proxies and proxyGroups connected to forgotten wallet

Task linked: CU-86936jpap Update wallet removal (forget wallet) procedure


Images

2 Questions:

Your theme centers the image and adjusts the size. What can I put in a snippet to avoid that? I just want the image to be on the left and to adjust the size this way: ![[image.png|300]].
This ![right](sky.png) does not work for me.

This snippet should do the trick:

.view-content .markdown-rendered img {
width: revert !important;
max-width: unset !important;
min-width: unset;
margin: 4em 1.5em;
display: revert;
}

I'm not sure why the right image is not working. Make sure the theme is updated to version 0.0.6 and check if the image is inside, directly before, or directly after a paragraph (sometimes the image will not float around headings or callouts). Also, see if there are any snippets enabled that might intervene with the images floating to the side. If the image is local, try ![[sky.png|right]] With the snippet above, you may need to reduce the size of an image for the change to be visible. Let me know if the problem still persists.

Unfortunately the problem persists.
Re 1.: your snippet has no effect.
Re 2.: the theme is updated. The image is neither inside, nor directly before, nor directly after a paragraph. There are no interfering snippets. ![[sky.png|right]] does not work.

I made an update to the theme a few seconds ago. Please update to version 1.1.6. It includes a Style Setting option to fix images.
The image will only float if it is inside, directly before, or directly after a paragraph. Try putting it in the middle of a block of text. If it still does not work, try it with an external image instead. If the problem persists even after that, consider sending a screenshot of the image in both preview and source mode.

I updated to 1.1.6 and in Style Settings disabled both image toggles. The original size is now preserved, but the image is still centered.
Below are screenshots in source mode and live preview:

Hmm...
This is a hard one. I'm really not sure why the image is still centered. I notice that the background looks like a different color. Is it inside a callout?
Is it just this one image or all images in the vault behaving like this? If it is this one image only, try  ![[Jacinda-Ardern.png|left]]. That might fix it in this one case.
If it's all images in the vault, try disabling every one of your snippets and seeing if anything about the image changes. If nothing changes, then I'll have to check if it's something interfering inside the theme. It works perfectly fine in my vault with snippets disabled.
If all that fails, check your version of Obsidian. Make sure it is updated.
Otherwise, I'm not sure what the cause of the misaligned images could be.

I tested it in the sandbox vault, and it works on my device. The last thing I can think of is that it could be your installer version. My installer version is at v1.1.9.

I am using the same installed version.

Aw, man. I have no idea what could be causing the issues, then. Is Style Settings up to date?
If so, then I'm clueless. Right now it seems to only be affecting your vault, so I'm thinking it might be something in the vault rather than the theme.

OK, we'll have to leave it that for now. I'll see if there is a way with CSS to force it comply. I don't think it is a vault problem because it does not happen with most other themes I tried/use.
The only other one it happens with is Maple, but this solves it:
body.image-alt .view-content img:not(.emoji) {
  margin: 0;
}

Unfortunately, that does not work for Big-and-Bold.

I changed the way images display in Preview Mode a little bit in the newest update. Let me know if this fixes the issue.

Thank you for giving it another try.
However, it does not work. Having said that, though, it seems we are talking cross purposes. I am talking about Live Preview, you are talking about Reading mode.

Oh, that's it! This whole time I've been trying to fix Reading Mode! My bad. I know what to do now.

No way, it is NOT your bad!! It is my bad, I should have mentioned it from the outset.
I sincerely apologize for making you lose your time

No, you did mention Live Preview earlier. I just got the two terms mixed up somewhere.

Thank you for fixing this.


Hosted version of safe-settings

Prerequisites:

Is the functionality available in the GitHub UI? If so, please provide a link to information about the feature.
N/A

Is the functionality available through the GitHub API? If the functionality is available, please provide links to the
API documentation (https://developer.github.com/v3/) as well as the Octokit documentation (https://octokit.github.io/).
N/A

If the functionality is not yet available in the API, it would be helpful if you
contacted support (https://support.github.com/) or posted in the Community Forum (https://github.community/). Please
include a link to the forum post if you create one or a copy of the response from support.
N/A

New Feature
Please describe the desired new functionality:
This is more of a question than a feature request. The documentation says "See docs/deploy.md if you would like to run your own instance of this plugin." Does that mean not running our own instance of the plugin is an option?
In other words, is there a hosted option for safe-settings from GitHub?

Hi @LamarrD There is a hosted version of the app. It is a public GH App. However, it is only suited for dev/test. We have not dedicated resources towards making it a production-grade version because there isn't a lot of demand for a public version. If you are interested in testing it for Dev/Test, you can go to this URL https://github.com/apps/safe-settings-app

Thanks @decyjphr! Out of curiosity what makes it only suitable for Dev/Test. Is it just due to not having support, scalability, or security?

It is mostly because of the lack of support, scalability, and availability.  There are security implications when installing public GH Apps because you would be trusting an external app with admin permissions to your Org, and that could be problematic depending on your industry, and compliance requirements.

because there isn't a lot of demand for a public version

As a maintainer of an OSS organization, I would see demand in this area (since we have no interest in hosting and operating our own services). Is the public version just hosted and maintained by you @decyjphr, or is there any involvement from GH?

Only by me (I pay for it but keep a cap on it)


head: PostCSS processing

The PostCSS processing is failing currently and disabled. There needs to be a check if postcss is configured (check for file postcss.config.js?) and if so it runs.

fixed somewhere along the lines


Benchmark flow needs to be split

The benchmark flow needs to be refined in order to enable conditional execution of flow elements, which are controlled by the config file.
It should be possible to conditionally perform all benchmark flow stages, most notably the:

init
installSmartContract

My recommendation would be to conditionally execute the above based on config parameters within the main run section of the caliper flow.
This would enable a user to easily run a benchmark on a network that has been initialised and had a smart contract installed

@nklincoln I've worked on the runtime config parts, I'll also add this decision points with the new config mechanism.
Question/suggestion:
Do we need to separate the two steps? Can't we just say that an adapter provides an init step? The sawtooth adapter doesn't do anything for the installSmartContract. So an adapter should encapsulate what it means by init. So the Fabric adapter could allow skipping channel creations as well as chaincode deployment (the CCP adapter checks the latter automatically).

Having a single init could make things a little more concise, especially if the installSmartContract method is redundant in some cases

@nklincoln yes, I've looked at this function. But it only tells what channels that peer has joined. Even if I query this for every peer, it's not a guarantee that the channel doesn't exist. Unless I get back that a peer is part of that channel (and this last part could be added to the adapter for convenience)
But I don't know of a correct way to check whether a channel exists or not, since it is supposed to be a sensitive information.

this is now duplicated by #535


Bug: Moving MVs to dbt caused them to be materialized to the wrong schema

We need to fix up the dbt project so that the MVs we had in the xapi schema go back there. We should be able to do this by doing the following:

Override the generate_schema_name macro to not concatenate custom schema names to the target schema
Add schema to the model configs of the MVs, using an env var that points to the xapi schema, like we do here: https://github.com/openedx/tutor-contrib-aspects/blob/main/tutoraspects/templates/aspects/apps/aspects/scripts/dbt.sh#L18C13-L18C13

It's also possible to simply override the database using the env var like we do here: https://github.com/openedx/aspects-dbt/blob/d0b59458faf368b51ad8b6d44bce75ab895e6ee8/models/completion/schema.yml#L5
More info: https://docs.getdbt.com/docs/build/custom-schemas

@SoryRawyer just giving you a heads up on this one

My apologies for overlooking this. As far as I know, the MVs and tables that should go into the ASPECTS_XAPI_DATABASE schema are listed here: https://github.com/openedx/tutor-contrib-aspects/blob/main/tutoraspects/plugin.py#L81-L97
Am I forgetting anything?

@SoryRawyer seems right to me

Fixed by:
https://github.com/openedx/aspects-dbt/pull/39
https://github.com/openedx/tutor-contrib-aspects/pull/562


Remove old "Using Compose with Swarm" page

This page describes using docker compose with legacy swarm, which has been deprecated.

@usha-mandya @StefanScherer ptal


Gitea Actions Marketplace

Feature Description
I think this would be nice to have in future a markat place for Gitea Actions, as it is done for GitHub (https://github.com/marketplace?category=&query=&type=actions&verification=)
There are some actions that can be re-used from GitHub, but there are some, that will only work for Gitea, so need to have a separate place to store such actions, that can be developed by community and published in central marketplace
Screenshots
No response

github.com/marketplace is just an index or collection, the actions store in github.com.
We do have a separate place to store actions  for Gitea only, that's gitea.com, like https://gitea.com/actions/go-hashfiles
Sure, building a marketplace is a good idea, we are working on it.


Bump github.com/IBM/idemix and github.com/consensys/gnark-crypto

Bump github.com/IBM/idemix to get updated github.com/consensys/gnark-crypto.
Note that github.com/IBM/idemix pulls in github.com/kilic/bls12-381,
which requires build tag "generic" to compile on amd64 in plugin mode.

@ale-linux Got it working with the "generic" build tag.

+1 for merging this!

Depends on https://github.com/hyperledger/fabric/pull/4664 , please review/merge that one first.


New demo feature

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
-

.

Need overall benchmark to ensure logger doesn't consume CPU/memory more than it was before refactoring. That is critical framework component in this regard.

There is one caveat that checks were added here, but they are not in the master. For true benchmarking, must also add checks to the master.

Benchmark doesn't reveal anything critical about refactoring.

@devanych would you please resolve conflicts?

👍


Update sql-database-monitor-tune-overview.md

Suggestion for sample query to track long running queries

@FonsecaSergio : Thanks for your contribution! The author, @danimir, has been notified to review your proposed change.

@ktoliver - Please reject. Two reasons 1) we do not want to crow this page with code examples, and 2) We cannot publish any code which has not been vetted internally. Thanks.

Closing per @danimir

@FonsecaSergio Please see this article for a similar query: https://docs.microsoft.com/en-us/azure/sql-database/sql-database-monitoring-with-dmvs#identify-long-running-transactions
Please review and suggest changes in this article as it is a more appropriate place for the query that you propose. Also, I will look at this particular article to see if additional links to the DMV article might be useful.


⚠ Bofrost.lu has degraded performance

In 18fb4f3, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1294 ms

Resolved: Bofrost.lu performance has improved in a09c9ae after 20 minutes.


Disable X11 forwarding in ssh connections

In some cases the X11 forwarding caused the connection to get
stuck. Let's disable the forwarding by default. We can add an
option to enable it upon request if needed later.
Resolves #1023.

A simple change, let's squeeze this into 1.10 unless there are any concerns.


Conflicts

https://nsec.esri.com/arcgis/home/item.html?id=c4748fea240c44f6894a7b3f9faa5111

[x] Title is vague
[x] Description is vague
[x] No Access and Use Constraints
[x] No Credits
[x] Delete Protection Disabled

https://nsec.esri.com/arcgis/home/item.html?id=a7afe86cdcfe4c2992b9b2e69f7fda4b

[x] Title is vague
[x] Description is vague
[x] No Access and Use Constraints
[x] No Credits
[x] Delete Protection Disabled

https://nsec.esri.com/arcgis/home/item.html?id=fbde636938264d5b8fcfa3bf2e68c31d

[x] Title is vague
[x] Description is vague
[x] No Access and Use Constraints
[x] No Credits
[x] Delete Protection Disabled

Done.


Some lines in terminal output missing

Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763
A strange issue happens in VScode when running some tasks. This is the (very ugly) batch script used for testing purposes:
@echo off
SET /A "index = 1"
SET /A "count = 50"
SET /A "number_of_pings = 2"
:while
if %index% leq %count% (
   echo The value of index is %index%
   SET /A "index = index + 1"
   for /L %%a In (0 1 %number_of_pings%) do (
ping -n 1 -w <IP_ADDRESS> > nul
)
   goto :while
)

Normally, when run through CMD it produces the following output:
The value of index is 1
The value of index is 2
The value of index is 3
The value of index is 4
The value of index is 5
The value of index is 6
The value of index is 7
The value of index is 8
The value of index is 9
The value of index is 10
The value of index is 11
The value of index is 12
The value of index is 13
The value of index is 14
The value of index is 15
The value of index is 16
The value of index is 17
The value of index is 18
The value of index is 19
The value of index is 20
The value of index is 21
The value of index is 22
The value of index is 23
The value of index is 24
The value of index is 25
The value of index is 26
The value of index is 27
The value of index is 28
The value of index is 29
The value of index is 30
The value of index is 31
The value of index is 32
The value of index is 33
The value of index is 34
The value of index is 35
The value of index is 36
The value of index is 37
The value of index is 38
The value of index is 39
The value of index is 40
The value of index is 41
The value of index is 42
The value of index is 43
The value of index is 44
The value of index is 45
The value of index is 46
The value of index is 47
The value of index is 48
The value of index is 49
The value of index is 50

In VScode, I'm running this script through the following task:
{
    "label": "test cmd",
    "type": "shell",
    "problemMatcher": [],
    "command": "test.bat",
    "options": {
        "shell": {
            "executable": "C:\\Windows\\System32\\cmd.exe",
            "args": ["/C"],
        },
        "cwd": "${workspaceRoot}"
    }
},

And this is the output in VScode terminal:
> Executing task: test.bat <

The value of index is 1

The value of index is 12
The value of index is 13
The value of index is 14
The value of index is 15
The value of index is 16
The value of index is 17
The value of index is 18
The value of index is 19
The value of index is 20
The value of index is 21
The value of index is 22
The value of index is 23
The value of index is 24
The value of index is 25
The value of index is 26
The value of index is 27
The value of index is 28
The value of index is 29
The value of index is 30
The value of index is 31
The value of index is 32
The value of index is 33
The value of index is 34
The value of index is 35
The value of index is 36
The value of index is 37
The value of index is 38
The value of index is 39
The value of index is 40
The value of index is 41
The value of index is 42
The value of index is 43
The value of index is 44
The value of index is 45
The value of index is 46
The value of index is 47
The value of index is 48
The value of index is 49
The value of index is 50

Terminal will be reused by tasks, press any key to close it.

Doesn't make much sense - I would expect if there is a timing issue that the first n lines wouldn't be shown, but in this case first line is printed normally. Running this multiple times results in same output.

Duplicate of #57803.


DBeaver FR: Add function for Administer -> Locks for MS SQL Server

DBeaver - Version 5.3.3 CE
DBeaver driver: MS SQL Server  / Microsoft Driver (the new Microsoft Driver)
Operating System: Windows 7 / Windows 8.1 / Windows 10
Database Server: Microsoft SQL Express 2014, 2016, 2017
It would be benificial if the same functionality that already exist for PostgreSQL to view database locks (choose Database -> Administer -> Locks for a PostgreSQL database)  was available for MS SQL Server.

We'll need some SQL Server expert to write locks reading queries for this feature..

I wonder if fetching them like telegraf is doing would help anything at all to get measurements for mssql:
https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sqlserver/sqlserver.go


JavaScript: Fix performance regression in IncorrectSuffixCheck.

The query works fine with code:ql-master, but something seems to have changed on code:master to make it blow up on, for example, ajaxorg/ace. This little refactoring seems to fix it; more comprehensive evaluation ongoing.

Evaluation confirms that this fixes the timeout on ace and ten other projects in our default suite. A detailed report is available here (internal link), note that the reported result changes are due to the fixed timeouts.


add support for nektro/zigmod package manager and remove use of git submodules

removed too much, making new PR

removed too much, making new PR


Add to psc-0.13.8 package set

Version 3.0.0 seems to do fine in a project that I just upgraded from psc-0.11.7 / bower / pulp to psc-0.13.8 / spago. I see you have three packages in the latest package set but not this csv package. Do you want to create a PR? Or shall I?
Verify went fine:
spago verify csv
[info] Verifying 1 packages, this might take a while..
[info] Verifying package "csv"
[info] Build succeeded.
[info] Successfully verified "csv"

Here the changes I made for package-sets:
diff --git a/packages.json b/packages.json
index 974c5bb..c68c6b9 100644
--- a/packages.json
+++ b/packages.json
@@ -844,6 +844,15 @@
     "repo": "https://github.com/danieljharvey/purescript-cssom.git",
     "version": "v0.0.2"
   },
+  "csv": {
+    "dependencies": [
+      "arrays",
+      "ordered-collections",
+      "parsing"
+    ],
+    "repo": "https://github.com/nwolverson/purescript-csv.git",
+    "version": "v3.0.0"
+  },
   "data-algebrae": {
     "dependencies": [
       "arrays",
diff --git a/src/groups/nwolverson.dhall b/src/groups/nwolverson.dhall
index ba1bb80..b427613 100644
--- a/src/groups/nwolverson.dhall
+++ b/src/groups/nwolverson.dhall
@@ -3,6 +3,11 @@
   , repo = "https://github.com/nwolverson/purescript-aff-promise.git"
   , version = "v2.1.0"
   }
+, csv =
+  { dependencies = [ "ordered-collections", "arrays", "parsing" ]
+  , repo = "https://github.com/nwolverson/purescript-csv.git"
+  , version = "v3.0.0"
+  }
 , dom-filereader =
   { dependencies = [ "aff", "arraybuffer-types", "web-file", "web-html" ]
   , repo = "https://github.com/nwolverson/purescript-dom-filereader.git"

Hi, feel free to raise a PR, I'm happy for the package to be included in the package set.

Submitted, checks passed, waiting for merge. Glad to do it, thanks for providing this package!


Fix RSSExtrasolar installation and details

Found to be broken via Netkan status page. Quite a few changes to the organisation on this one. Enabled staging

Strange error Jenkins is giving, there. Testing locally without RSS dependency to avoid the huge installation overhead.

Looks good to me. Thanks, me from two weeks ago!


Hugo workflow (hugo & gulp.js). Just checking?

I did not find much about Hugo & gulp.js so I am checking.
Here is my summary:

Hugo is fast on building Websites, but does not concern itself with any asset management.
For this one needs to employ a task runner, i.e. gulp.js

So what would gulp.js need to do:

Sass: .scss -> .css
Jade: .jade-> .html (this is valid for both pages and layouts). Jade instead of Haml because it handles the {{syntax nicely.
Coffee: .coffee-> js
Icons: generate favicon.ico, apple-touch-icon.png, tile.png, tile-wide.png form png-template
Images: optimize images
Fonts: copy/generate local fonts

gulp.js would need to take the source-files from a folder called, say, src and put the results into themes\mytheme. Actually, with this approach nothing would go into themes\mytheme manually but only by way of gulp.js
Then Hugo would do its work.
Finally gulp.js would need to apply hash-values to .js and .css files in the public-folder resulting from Hugo with something like gulp-rev & gulp-rev-replace and gzip them with gulp-gzip. Done.
I suppose this is a pretty standard workflow, so I am wondering if anybody is already working along these lines or whether this is crossing paths with anything that is already been worked on.
Finally some observation concerning Markdown: currently Hugo is using blackfriday. I understand that this is a hardwired choice. Correct? I also understand that there are Shortcodes to overcome the shortcomings of markdown or the markdown engine. However, there are numbers of markdown engines around, such as kramdown that extend the pure markdown capabilities and provide for very handy options. I think using such is much more handy then using Shortcodes (even though I like Shortcodes for not standard stuff). There is even a blackfriday fork written in Go that builds in a lot a very useful markdown extensions mmark.

See http://discuss.gohugo.io/ - search for Gulp. Thats a better forum for questions/discussions.
But in general, you are right (I didn't understand the jade part, but that's me).
As to hardwired: Yes - this is Go and static linking all the way. The main rendering engine is Blackfriday (extremely fast and native go) -- there is one other (external tool), do not remember name and a 3 template engines (Go, Amber and Ace) ... If there are a good Go implementation of Kramdown or others, pull requests are welcome.


When special stages are complete it  doesn't show player

When you enter a special stage and complete it and it takes you back it doesn't show the player

What version of the framework were you using and what version of godot are you using?
Could you provide the location and anything that you did that could be related too if this happened in base zone?

I'm using v2.9.0 and the version of godot that I'm using is 4.3
Uploading 2024-08-27-11-26-50-trim-00-38-0.MP4…

In SpecialStageRing.gd there is a check for player.character == player.CHARACTERS.SONIC
This is an oversight, it should be player.character == Global.CHARACTERS.SONIC
I will make this fix shortly.


Handling of system ID: default, from conf file or from autopilot

@hamishwillee @SaliniVenate
For System ID, this could be a strategy to follow for CSD -

Read from the conf file (-1 : read from network, >=0 : use as it is )

If conf file is not there, use some default value (1)

Read from the network (if system ID is set to -1 in conf file)

Start sending camera heartbeat with default system ID (1)
On receiving autopilot heartbeat, send camera heartbeat with updated system ID.
On receiving heartbeats from multiple autopilots, stick to the first one

Sounds good to me. In 90% of cases this will be connected to autopilot with sys id 1 and this will just work.
The only problem I see is the case of multiple autopilots (small fraction of time) - should we somehow report/log multiple autopilots on the network so users can know this is a possible problem?

@hamishwillee Can we close this issue?

Nearly. Can you update the defaults in the sample file - https://github.com/Dronecode/camera-streaming-daemon/blob/master/samples/config/config.sample#L20 e.g. system id default is now effectively 1.


NBSNEBIUS-193: mount volumes in local mode

Maybe it would be useful to forward this option as a parameter with default value as "local"


Convert Time picker to Variants

Variants in Figma

[ ] Add documentation link
[x] Create nested component

Time picker has no documentation in the storefront yet

Looking good @benkeq


Peer struct

Most importantly reduce the message size significantly, and seperate structs for datastore and peer node.

Is this part of the re-org?

Pretty much.
On Tuesday, May 24, 2016, Ioannis Papapanagiotou<EMAIL_ADDRESS>wrote:

Is this part of the re-org?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/Netflix/dynomite/pull/297#issuecomment-221333885

The branch is out of date.


Enabling Container Insights for Azure Arc enabled Kubernetes clusters was failed

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az k8s-extension create Extension Name: k8s-extension. Version: 0.4.1.
Errors:
'DeploymentsOperations' object has no attribute 'begin_create_or_update'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 233, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 660, in execute
    raise ex
...
k8s-extension/azext_k8s_extension/partner_extensions/ContainerInsights.py, ln 110, in _invoke_deployment
    return sdk_no_wait(no_wait, smc.begin_create_or_update, resource_group_name, deployment_name, deployment)
AttributeError: 'DeploymentsOperations' object has no attribute 'begin_create_or_update'

route to service team

This does not contain enough information to triage; please provide more environment details, including exactly what command failed and what versions of Azure CLI and the extensions you have (include the command line output of az version), so that we can take a look.


The integer constant was replaced by an enum

If you use an integer constant for a switch statement, you need to infer the contents of the onCreateOptionsMenu () method to make some actions.
I hope it will be useful.

Hi there, since this is just a sample, I am fine with it not being an enum. Thanks for the suggestion though!


NewParser use os.Open  and how to close it

NewParser use os.Open  and how to close it ?

good catch with my rookie mistake, I would happily merge if you want to fix it @ixqbar .

@tufanbarisyildirim I pushed merge request to fix it. #29

Thanks @berejant


PR:  Algo Bubble Sort  in JavaScript

Description:
This pull request introduces the Bubble Sort algorithm implemented in JavaScript, along with a comprehensive README file.
Changes Made:
Added JavaScript code for the Bubble Sort algorithm.
Included a README file with the following sections:
Definition: Describes the algorithm's purpose and operation.
Explanation in Simple Terms: Provides a non-technical explanation for easy understanding.
Code-Related Explanation: Offers a detailed breakdown of the JavaScript code.
Included example usage and a sample array for sorting.
Purpose:
The purpose of this contribution is to provide developers with a clear and educational resource for understanding and implementing the Bubble Sort algorithm in JavaScript. The README file ensures that both technical and non-technical users can grasp the concept and its practical application.
@Abishethvarman    Please review this PR, and if it aligns with the project's goals, consider merging it. Your feedback and suggestions are welcome. Thank you!

Hello @Abishethvarman i made changes in the Readme file

Hello @Abishethvarman I kindly request that you review my pull request and, if you find it suitable, consider merging it with the "hacktoberfest-accepted" label. This will not only help me in achieving my Hacktoberfest goals but will also contribute to the growth and development of the project.

@Thevapriyan07 please review this PR ASAP and merge it.


integrate external device inventory proposal draft

first version.
Akri can get more device related information beyond discovery.
Suggest Akri agent talking with an external device inventory POD/service

@kate-goldenring , my bad the previous PR wrongly includes non-relevant commits. Recreate and reply your comments as below.
Is it the Agent or Discovery Handlers that will reach out to the device registry?
RE: I understand Agent does periodically run multiple discovery handlers(usb,onvif,OPC) according to Akri config, am I right? If so, I think it should be Agent to talk with external device registry no matter which discovery handler reports it finds a new device. Discovery handlers just do necessary action defined by protocols. Without knowing the current discovery handler detail, I am guessing we may need to split the discovery procedure into two parts. For onvif, the first discovery part is to find host ip/MAC, and second discovery part is to extract the video stream URI. Between part 1 and part 2, Agent can query device registry and get necessary ONVIF host credential so part 2 can be succeeded.
Would be good to add a section defining the API in detail, specifically the contents of the query
RE: I will fill in details after we are fine with the basic ideas: Agent fetch additional device info, and embed them into customer resource Akri instance.
how will the device inventory service know to trust the Akri Agent and vice versa?
RE: My initial thought on security is just by K8s cluster admin to define network policy to allow Akri agent ingress/egress with the external device inventory POD. I guess you mean stricter way such as mutual authentication. I think from the point of view that this is a IoT Solution in a relatively safe OT on-premise environment so as initial step maybe k8s cluster network policy is good enough?  Safer mutual comm (through a identity solution such as Azure AD) could be later. More importantly I think is that we should have a device management system first, that is essential for IoT solution which is my interest :)
Why not make the connection with the device inventory part of the initial discovery process in the discovery handlers? So, instances are created fully formed and all information is grabbed at once?
RE: I am align with you that once Akri instance is created it is with full device information. I am not sure if this question is still about if Akri agent or the discovery handler should talk to external device inventory. As my previous answer, I think Agent is in better place to talk to device inventory. Each discovery handler should just follow protocol (onvif, OPC. etc.) to do necessary tasks so in the future anyone who wants to contribute another protocol discovery handler, he/she just follow the protocol document but does not need to know any knowledge about talking with device inventory system.
instead of Akri hosting the service, maybe it would be better to add another endpoint to the inventory service that should also be exposed to kubernetes. This matches akris approach to date of query for devices rather than being told about them.
RE: I totally agree and I thought about the same thing as well. If Akri agent can periodically "scan" device inventory system to "find" new device just like it does onvif or OPC scan. It is best as the logic flow will be same.
but if we want the updateDevice endpoint as well, this may make sense
RE: yes, the ingress request to Akri Agent is still needed in some use cases, such as update device info.
I wonder if the /addDevice and /updateDevice services can be bundled together under some device registry extension to Akri
RE: same comments as previous two questions. We can work on this detail later after we align on the basic principles of this proposals first.
what changes to the DiscoveryHandler interface are needed to support credentials
RE: I do not dig into code level detail yet. I hope my previous imagination on split discover process into two parts is useful.
how to move credentials around securely
RE: Is this question about credentials of device? I thought just simply give to broker pod as env variables....
how new device credentials are passed to running brokers. I wonder if there needs to be some way for the device registry to pass "device registry access creds" that can be given to brokers to query for new creds when they expire but maybe this opens up the registry too much and defeats the point of rotating creds
RE: That is my suggestion of ingress request to Akri agent as /updateDevice. I think Akri agent is the only one allowed to talk to device inventory. Broker pod should not be allowed to do so.
We might need to create a new threat model around this to understand the flow of trust and creds.
RE: yes, I wish to dig further on security topics. My current thought is presented in previous answers.

@kate-goldenring , I did not know device discovery handler is not embedded in Akri agent but separate POD. The proposal should clearly define the flow with discovery handler together. I update the diagram. The discovery handler is added in. To minimize the change request, I suggest a new gRPC service in Akri agent for discovery handler to talk with agent during the discovery procedure. This is necessary for discovering credential protected Onvif camera.
If you think this proposal is worth a try, may I volunteer to try developing the suggested change?

@kate-goldenring , I did not know device discovery handler is not embedded in Akri agent but separate POD. The proposal should clearly define the flow with discovery handler together. I update the diagram. The discovery handler is added in. To minimize the change request, I suggest a new gRPC service in Akri agent for discovery handler to talk with agent during the discovery procedure. This is necessary for discovering credential protected Onvif camera. If you think this proposal is worth a try, may I volunteer to try developing the suggested change?

Originally the discovery handlers were embedded, but we soon moved them behind a gRPC interface so that not all discovery protocols needed to be embedded in the agent. You can still conditionally compile them into the agent. I'd recommend skimming through our architecture documentation if you havent already. This diagram lays out all of akris components, this walks through the information flow, and this section on resource discovery talks about the discovery handler interface. It may make more sense to extend this interface rather than make a new one.

@kate-goldenring , yes, I already changed the proposal based on the links you shared, please review the proposal again. With keeping the current structure (discovery handler talking with Agent with gRPC call), I suggest adding a new gRPC service:RequestDeviceInfo in Agent that device handler may call it to fetch more device information through Agent. It does not deprecate current device handler. For example, current Onvif handler will still work for non-protected camera. Optionally, it is also possible to enhance current onvif handler to support Onvif authentication, by calling RequestDeviceInfo during the discovery procedure. That is drawn in proposal. I will create a PR to show the suggested code work.

A quick summary of my current progress and things I think of before submit my PR:

I have implemented the additional RPC function for discovery handler to call and get additional device information from an external REST POST API endpoint (which is supposed to be developer to deploy based on the actual device inventory system). This RPC function is optional, that means all the current discovery handler still works with the change.
I create a demo device inventory image that can be deployed to cluster for test purpose. It provide the query device endpoint and it does even have a simple web page portal for simple device data record add/delete/update operation.
I do not change current discovery configuration yaml format, instead the new development allows user insert a optional field "query_device_http" in the disocvery detail part. If it presents, discovery handler will try to query device info from external REST endpoint.
To be able to re-create Akrii after device information record being added/updated/deleted, each discovery iteration not only simply compare discovered device basic info, but it will also compare the external device info, any discrepancy will trigger discovery handler report full list of devices to agent also.
Additional device information from external device inventory system is put into Device properties, they will appear in Akrii custom resource device portion. They can be further relay to broker pod like the current available discovery device detail for different protocols.

This PR wont not request importing additional cargo library. Current discovery handlers will still work.
Some thoughts:
I find the current onvif discovery only verify camera WSDL endpoint availability by check its system date time, but not process further such as check device capability, video streaming format, framerate and so on. It does not do authentication since protected onvif is not supported yet. With this new integration with external device inventory, it is possible to implement a more comprehensive Onvif discovery handler. I will leave it to future plan. For now, I assume broker pod developer will do those steps.
I will think how to enhance device query efficiency, right now I have to query all devices in every discovery iteration to pick up updated device info. It will be more efficient if there is a way to directly notify agent some devices' external information changes.

Can this proposal be built up to discuss/detail the proposed implementation: https://github.com/project-akri/akri/pull/520. Specifically, detail the defined services and payloads and discuss the decision making around it.


Clicking middle text of a notification row has an inconsistent darkening animation to icon and date

Summary
Clicking on the middle text of a notification row doesn't change the background of that row. However, the icon and the date do. We should show the animation for consistency (also pressing and holding should make row darker shade like others)
Screen-shot
This is the animation I'm talking about:

Possible solution
A solution that might solve all of this issue and #1981 is doing away with the "show more", and having the entire notification row be a link. Having a longer trimLength (I'm thinking like 280 chars) with an ellipsis if it's somehow over that should be okay. The user can view the commons website for the entire notification text if it's really long, if they're clicking through to the website anyways.

Also see #1955, #1862

Fixed in #1998


Cherry picking PR 251 for branch 1.3.1

cc @JoshRosen

Current coverage is 85.53%

Merging #287 into branch-1.3.0 will increase coverage by +0.05% as of f515479

@@            branch-1.3.0    #287   diff @@
============================================
  Files                 10      10
  Stmts                489     491     +2
  Branches             147     149     +2
  Methods                0       0
============================================
+ Hit                  418     420     +2
  Partial                0       0
  Missed                71      71

Review entire Coverage Diff as of f515479

Powered by Codecov. Updated on successful CI builds.

Merged this into branch 1.3 and published the jars.


Decide on formatting/linting options

Currently, we don't have a linter or formatter hooked up in gradle. What should we use? Should it match otel? Should it match Android Studio's defaults?

Resolved with https://github.com/signalfx/splunk-otel-android/pull/277


Format Json Output

Question
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.4
            pydantic compiled: True
                 install path: /opt/conda/lib/python3.6/site-packages/pydantic
               python version: 3.6.8 |Anaconda, Inc.| (default, Dec 30 2018, 01:22:34)  [GCC 7.3.0]
                     platform: Linux-4.19.76-linuxkit-x86_64-with-debian-stretch-sid
     optional deps. installed: ['typing-extensions', 'email-validator']

For HttpUrl and IPvAnyAddress I would like to format the json output.
For the url I get the following:
from pydantic import BaseModel, HttpUrl

class Test(BaseModel):
    url: HttpUrl

m = Test(url="http://www.example.com/123/abc?123#abc")
m.json()
# '{"url": "http://www.example.com/123/abc?123#abc"}'

Instead I would like the json to include all of the properties of the url. Something like:
'{"url":{"scheme": "http", "host": "www.example.com",  "tld": "com", "host_type": "domain", "path": "/123/abc", "query": "123", "fragment": "abc"}}'

For the IPvAnyAddress I would like to return some of the properties that the ipaddress provides. For example:
from pydantic import BaseModel, IPvAnyAddress

class Test(BaseModel):
    ip: IPvAnyAddress

m = Test(ip="<IP_ADDRESS>")
m.json()
# '{"ip": "<IP_ADDRESS>"}'

Instead I would like something like:
'{"ip": {"compressed": "<IP_ADDRESS>", "version": 4, "is_global": False, "is_private": True, "is_multicast": False}}'

Is either of these things possible and if so how?

Huh, I would have expected this to be possible by stealing some logic from the repr function on AnyUrl for a custom json_encoder, but it doesn't work as I would expect either:
In [1]: from pydantic import BaseModel, HttpUrl
   ...:
   ...: def dump_attrs(v):
   ...:     return {n: getattr(v, n) for n in v.__class__.__slots__ if getattr(v, n) is not None}
   ...:
   ...: class MyModel(BaseModel):
   ...:     url: HttpUrl
   ...:
   ...:     class Config:
   ...:         json_encoders = {
   ...:             HttpUrl: dump_attrs
   ...:         }
   ...:
   ...: m = MyModel(url="http://www.example.com/123/abc?123#abc")

In [2]: m.json()
Out[2]: '{"url": "http://www.example.com/123/abc?123#abc"}'

In [3]: dump_attrs(m.url)
Out[3]:
{'scheme': 'http',
 'host': 'www.example.com',
 'tld': 'com',
 'host_type': 'domain',
 'path': '/123/abc',
 'query': '123',
 'fragment': 'abc'}

IPvAnyAddress would be similar.

So there isn't a way to do this with the json_encoder?

It's looking like it may be hard to do, as HttpUrl and IPvAnyAddress are subclasses of str, though based on the logic I see in the json_encoders, it should be catching it. I suspect it has to do with python's JSONEncoder always checking if the element is an instance of str and encoding based on that, but even subclassing HttpUrl and overriding the __str__ method doesn't do it.
@samuelcolvin, shouldn't a custom definition for a class encoder override the default json encoding, even if it's a subtype of a native type? i.e. https://github.com/samuelcolvin/pydantic/blob/master/pydantic/main.py#L266?

Currently this isn't possible with json_encoder. You could achieve this by either:

modifying the model's dict method to override the value of url
or, if you don't want to modify dict, you could hack around withe Config.json_dumps

This should be possible in in future, either when I implement a fix for #935 or #951


how to skip googletest when compile source

i met following error, how to skip it (how to modify cmake)
577.1 [ 11%] Creating directories for 'googletest-populate'
577.1 [ 22%] Performing download step (git clone) for 'googletest-populate'
577.1 Cloning into 'googletest-src'...
577.1 fatal: unable to access 'https://github.com/google/googletest.git/': Failed to connect to github.com port 443 after 130633 ms: Connection timed out
577.1 Cloning into 'googletest-src'...
577.1 fatal: unable to access 'https://github.com/google/googletest.git/': Failed to connect to github.com port 443 after 131033 ms: Connection timed out
577.1 Cloning into 'googletest-src'...
577.1 fatal: unable to access 'https://github.com/google/googletest.git/': Failed to connect to github.com port 443 after 131038 ms: Connection timed out
577.1 -- Had to git clone more than once: 3 times.
577.1 CMake Error at googletest-subbuild/googletest-populate-prefix/tmp/googletest-populate-gitclone.cmake:39 (message):
577.1   Failed to clone repository: 'https://github.com/google/googletest.git'
thanks

You could try setting the BUILD_TESTS here as OFF.

Hi @whk6688 please feel free to reopen this ticket if needed.


patchelfUnstable: unstable-2022-02-21 -> unstable-2022-03-26

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for patchelfUnstable is: "A small utility to modify the dynamic linker and RPATH of ELF executables"
meta.homepage for patchelfUnstable is: "https://github.com/NixOS/patchelf"
meta.changelog for patchelfUnstable is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/g4dnwvwg7cf352cr2x48yy8j3yq0p2xw-patchelf-unstable-2022-03-26/bin/patchelf had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found unstable-2022-03-26 in filename of file in /nix/store/g4dnwvwg7cf352cr2x48yy8j3yq0p2xw-patchelf-unstable-2022-03-26

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
p4v
patchelfUnstable
python310Packages.tensorflowWithCuda
python39Packages.tensorflowWithCuda

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g4dnwvwg7cf352cr2x48yy8j3yq0p2xw-patchelf-unstable-2022-03-26 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A patchelfUnstable https://github.com/r-ryantm/nixpkgs/archive/4dc7f3c6a7b689408269ae9e208f651e6dbd8969.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g4dnwvwg7cf352cr2x48yy8j3yq0p2xw-patchelf-unstable-2022-03-26
ls -la /nix/store/g4dnwvwg7cf352cr2x48yy8j3yq0p2xw-patchelf-unstable-2022-03-26/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @edolstra for testing.

Most recent commit is from April 7th


Add event

@SundeepK ,this is awesome library
i just added  your dependency.i cant add a new event ,
add event method got deprecated.
how to change event add based on date.now the add method is based on time stamp.

You can use 2 other ways:
    /**
     *  Adds an event to be drawn as an indicator in the calendar.
     *  If adding multiple events see {@link #addEvents(List)}} method.
     * @param event to be added to the calendar
     * @param shouldInvalidate true if the view should invalidate
     */
    public void addEvent(Event event, boolean shouldInvalidate);

    /**
     * Adds multiple events to the calendar and invalidates the view once all events are added.
     */
    public void addEvents(List<Event> events);

It was a mistake that I made early on allowing people to control if they wanted to re-draw the the calendar. addEvent(Event event, boolean shouldInvalidate); allows you to add events without causing the calendar to redraw saving on performance by passing in false in the second parmeter. But it probably wasn't too useful.
So you can simply call calendarview.addEvent(someEventt, true);. Adding multiple events is best done through  addEvents(List<Event> events); method.

Say I have Firestore..
Collection = "2018-11-7", Document (randomKey) with fields Xvalue (TimeInMillis) and dataField ) .
How to add this with addEvents ?


updated to have a click event emitter in HeaderAction

Closes carbon-design-system/carbon-components-angular#2698
Since moving to the base icon button, the click event does not propagate up the chain. This adds the click event as an Output on the BaseIconButton and the emitter within the onClick function in the UIShellModule Header Action Component
Changelog
Changed

BaseIconButton to have an Output
Header Action click feature returned

I have read the DCO document and I hereby sign the DCO.

@ParkerMIBM I'm closing this PR as we have alternatives available.