[comms,commsdsl,comms-ublox] update ports

Describe the pull request

What does your PR fix?

updates comms to 3.4
adds feature tools to comms.
update commsdsl to 3.6.4
update comms-ublox to 0.20.2

Which triplets are supported/not supported?

When building comms[core,tools]:x64-windows-static:
-- Installing: G:/19581/vcpkg/packages/comms_x64-windows-static/share/comms/copyright
-- Performing post-build validation
DLLs should not be present in a static build, but the following DLLs were found:

    G:/19581/vcpkg/packages/comms_x64-windows-static/bin/comms_champion.dll
    G:/19581/vcpkg/packages/comms_x64-windows-static/debug/bin/comms_champion.dll

There should be no bin\ directory in a static build, but G:\19581\vcpkg\packages\comms_x64-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but G:\19581\vcpkg\packages\comms_x64-windows-static\debug/bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
    endif()

Found 2 error(s). Please correct the portfile:
    G:\19581\vcpkg\ports\comms\portfile.cmake
-- Performing post-build validation done
Error: Building package comms:x64-windows-static failed with: POST_BUILD_CHECKS_FAILED

@JackBoosY Is there a way to add supports fields to a feature property?
The tool itself builds a shared library (hardcoded) which is needed for the build plugins.
So the feature tools can only be build if the triplet is dynamic, but the port without the feature tools supports all triplets, since it is header only

Is the DLL only used by the tools (= a private implementation detail)?
If yes, can't the DLL and its import library be removed from everything but tools/${PORT}?

Is the DLL only used by the tools (= a private implementation detail)?
If yes, can't the DLL and its import library be removed from everything but tools/${PORT}?

It's not a private implementation detail. It can be used to develop own plugins for the tool application.

@JackBoosY please review again. I've also replaced the deprecated cmake functions with the new one

This all looks clean and reasonable. Thanks for the update!


Add Catalan and Spanish translations.

You're welcome @Miskerest. Happy to give back.
I've finally had a chance to test them.
Applies to both languages:

File and text upper tab titles are not translated (uppercase?)
Same for 'select' file button
Same for hashes match toast

Looks like they are not in the base English strings file.

Hi @pataquets,
I think I've fixed all these. I tested in each locale, and they all seemed to appear correctly. Next up is fixing some minor memory leaks, once I get the free time :)


Use compile-testing to improve testing

It might be a good idea to use the newly available compile-testing API (https://github.com/google/compile-testing) to improve the testing of the generated assertions. It can test that the generated assertions compile as well as doing a compile-tree diff of the generated file (instead of a plain-text diff).

That might be interesting indeed, right now I'm using assertj-examples for that.

addressed by @Nava2 in #101


Incorrect indentation

Reported by @kuon in:https://github.com/Microsoft/TypeScript-Sublime-Plugin/issues/220
When I use autoformat, the following block get the following indentation:
toolsElement = h.div({ className: "row-tools" },
    h.button({
        className: "add-node",
        onClick: () => DataController.createNode(this.props.parentId)
    }, "Create new node")
    );

While I expect (Last line should be to the left):
toolsElement = h.div({ className: "row-tools" },
    h.button({
        className: "add-node",
        onClick: () => DataController.createNode(this.props.parentId)
    }, "Create new node")
);

Another example:
return (
    h.div({
        className: "view-node-row",
        style: {
            width: width,
            height: rowHeight
        }
    },
        backgroundElement,
        centerElement,
        toolsElement,
        h.div({ className: "nodes" }, items)
        )
    );

While I expect:
return (
    h.div({
        className: "view-node-row",
        style: {
            width: width,
            height: rowHeight
        }
    },
    backgroundElement,
    centerElement,
    toolsElement,
    h.div({ className: "nodes" }, items)
    )
);

PS: I'm doing react without JSX because TypeScript > JSX, but proper indentation is really crucial to readability.

+1

+1
https://github.com/Microsoft/TypeScript/issues/871

@SaschaNaz wanna take a look at this one?

@mhegazy Sure, interested. I will take a look.

I'm not sure about the second example. #3738 currently makes it into:
return (
    h.div({
        className: "view-node-row",
        style: {
            width: width,
            height: rowHeight
        }
    },
        backgroundElement,
        centerElement,
        toolsElement,
        h.div({ className: "nodes" }, items)
    )
);

and this is in fact what I expect. Is your indentation example generally preferred?

I think the first argument should be aligned with the other arguments.
Ii could also be something like this:
return (
    h.div({
            className: "view-node-row",
            style: {
                width: width,
                height: rowHeight
            }
        },
        backgroundElement,
        centerElement,
        toolsElement,
        h.div({ className: "nodes" }, items)
    )
);

Which is even better. And I think it's what JSBeautifier produces.

Yup. I believe backgrondElement should be pushed back one step.

The JSBeautifier way looks a bit more complicated. Okay, I'll follow the general preference.

Perhaps you may introduce some form of configuration, style is quite personal.

One question: What do we want in this case?
{
    foo(`foo
foo
foo
`, {
            }); // <- this is current indentation that should be fixed, but what do we want?
}

Seems that https://github.com/Microsoft/TypeScript/issues/3673 is a duplicate of this one

Two PRs #3738 and #3827 fix this.

One more question: Which do we want for variable declaration list?
// This is current behavior
var foo = {
    a: 3
},
    bar = 3;

// Pushed back
var foo = {
    a: 3
},
bar = 3;

I'd say:
var foo = {
        a: 3
    },
    bar = 3;

@kuon JSBeautifier also does so but we have to choose a default behavior. I personally like your push-forward way, if you ask.

I think the most important thing is to keep the }, aligned with the next thing.
So either of those:
var foo = {
    a: 3
},
bar = 3;

var foo = {
        a: 3
    },
    bar = 3;

Just not the current behavior.
Then it's really a matter of style. I like the push-forward better and as JSBeautifier is the closest thing we have to a reference I'd say do the same if possible.
Personally I stopped using variable declaration list for readability, mostly because different formatters have different behaviors and this ensure a "push forward", I simply do:
var foo = {
    a: 3
};
var bar = 3;

#3827 is waiting feedback, if anyone asks ;)

closing this issue since it was marked as fixed few months ago

Not completely fixed, but I think the remaining problem should be posted as a separate issue.

@SaschaNaz can you please file it it so we can understand what part of work is not finished yet?

Okay, I just opened #5834.


Add documentation for bulk-resetting signon password

This is a leftover action from an incident in February 2016. This
documentation was in the old opsmanual but was lost in the move to this
manual.

At the time I put this into https://github.com/alphagov/signon/issues/543 because we felt it was too app-specific for the manual. We could add this page to the /docs folder in signon?

Ah ok, good call. I'll sort that out.


Add mime types in summary

I think it is good to be able to see the default mime types by checking the summary instead of source code or at runtime.

I don't think there's a good way to render this that won't be kinda ugly in the tool-tip view VS provides. This is better rendered in non-API docs. Thanks for the contribution, but we're going to decline this change.


fix: 修正拼写错误

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

建议编写代码的时候开启拼写检查插件。


FAQ section and improvement on createComponent method

added FAQ section
improvement on createComponent method

Coverage increased (+0.6%) to 51.176% when pulling f3049543c2fd0451258e338d793455322b3865ad on faq into 544429c06329e958bbbdba6f92aff3f63d993cff on master.

Coverage increased (+0.6%) to 51.176% when pulling 81c2ec3c1e703930146c325e4fac8e3f038ca45d on faq into 544429c06329e958bbbdba6f92aff3f63d993cff on master.

Coverage increased (+0.6%) to 51.176% when pulling 02eca5ba596ad754155a4761b94073c5e52c0007 on faq into 544429c06329e958bbbdba6f92aff3f63d993cff on master.

Coverage increased (+0.6%) to 51.176% when pulling 782b35f6153d5b8026a4a71cf4a3c856c53bf913 on faq into 544429c06329e958bbbdba6f92aff3f63d993cff on master.


[autostart] The application break on windows when autostart

As the above images show, when I restart my windows, the application breaks.
Here is the reproduce repo.  https://github.com/jason89521/auto-start-tauri
Did I miss something to let the autostart work correctly?

The auto started app is the debug one which uses your localhost server, would you try again with a release build? (npx tauri build and launch it then restart your computer)

Oh! Thank you!


Support Host.requestPolicy for TLS and HTTP [apro #721]

This is a whole lot of Listener rework to:

support requestPolicy
never ever reply with 301s to ACME challenges
give Edge Stack a fighting chance of warning users about scary browser warnings
ditch some of the evilness about SNI in the past so that we have a fighting chance of being able to reason about SNI

VERY IMPORTANT: we don't use require_tls any more. Instead we use explicit header matching and the redirect action. This means there'll be a commit shortly with a massive update for the local-mode tests. Nothing will pass just yet.
Best to review this commit-by-commit, to expect this description to change quickly, and to plan to just reread the following classes:

IRListener
V2VirtualHost
V2Listener

This is for https://github.com/datawire/apro/issues/721 and https://github.com/datawire/apro/issues/735.

@alexgervais The ACME hole-punching won't synthesize a Mapping for /.well-known/acme-challenge/ if you've already supplied one, so that should be fine.


Bugs when metadata records from different positions/field of views are merged

Hi @karlduderstadt ,
I noticed some bugs when MARS merges the metadata record for different positions (fields of view) within the same experiment. First of all, most metadata records are not merged at all. However, when they are merged, it seems like Metadata properties are lost and overwritten with subsequent merged ones. For instance, the parameter DnaMoleculeCount in DnaMoleculeArchives keeps being overwritten but in this case it should be summed up. In other cases a different action might be preferred. To keep it simple, maybe metadata merging is not absolutely required and they could kept separate?

Hi @mjosch
Thanks for pointing out this problem. It seems there are a couple issues here. First, all positions from a single experiment should get the same metadata UID and I guess that didn't happen. This could be a bug in mars-scifio or could be a difference in the metadata records, such that the UUIDs don't match. I will investigate this further. In any case, I think in micromanager 2 they removed the global UUID, so it might be even harder to ensure all positions from an experiment get the same metadata UID.
I completely agree with you. I think by default all metadata records should not be merged, so I will change this. But I do think there might be some special situations when this feature is desired. So I have added a radio button to all image commands that create archives with two options "unique from dataset" or "random" with "random" as the default. I hope this addresses the main issue.
If two metadata records have the same metadata UID, but you don't want them to be merged when running the merge archives command, you will need to change the metadataUID of one of the datasets using the follow script:
#@ MoleculeArchive archive

import de.mpg.biochem.mars.util.*
import org.apache.commons.lang3.reflect.FieldUtils

def metadata = archive.getMetadata(0)

archive.removeMetadata(metadata)
newUID = MarsMath.getUUID58().substring(0, 10)
FieldUtils.writeField(metadata, "uid", newUID, true);
archive.putMetadata(metadata)

archive.molecules().forEach{ molecule ->
	molecule.setMetadataUID(newUID)
}

archive.rebuildIndexes()

The uid is a private variable with no set method by design because it shouldn't typically be changed. This script uses java reflection to force the change. It assumes all molecule in the archive are associated with the same metadata records and also updates those.
Ultimately, the merge archives command should have a checkbox or some options that provide more possibilities, but this will take some time to implement. I think using the script above before merging is a suitable workaround for situations where a lot of analysis has been completed and you don't want two datasets with the same metadata UID to be merged.
If you happen to be in a position where you have two metadata records with different metadataUIDs and you still want to merge them. This can also be done very easily in a script using the merge method.
#@ MoleculeArchive archive1
#@ MoleculeArchive archive2

def metadata1 = archive1.getMetadata(0)
archive2.getMetadata(0).merge(metadata1)

A similar merge method is also available for merging molecule records. As you discovered, when this method is used (it is called in the merge command) last one in wins in terms of parameters, regions, positions, etc... more care is taken when merging molecule tables and metadata record OME images to ensure all information is retained.
I am not sure there is a simpler way to deal with this. I could add a rule for the DnaMoleculeCount and adds them I suppose, but I think not merging is a better solution.
The changes have all been implemented in image commands, but I didn't reference this issue in the commits, sorry. For now I will leave it open until I work on the merge command and add the checkbox.


X50Q not detected

I am running Das Keyboard Q 3.3.3 on my laptop, but my X50Q keyboard is not detected by the software. The window just says: "Plug your Q Device in." The keyboard itself works, but I can not make changes to the RGB profile or use any applets. I tried unplugging the keyboard and restarting my laptop without success.
System:
Memory: 16GB
Processor: Intel Core i7-4720HQ
GPU: NVIDIA GeForce GTX 970M
OS: Ubuntu 21.04 64-bit
Kernel Version: 5.11.0-37-generic
GNOME: 3.38.5
Windowing: X11

Mine got recognized after a Firmware update. Updating the X50Q requires a software only available for Windows:
https://www.daskeyboard.io/get-started/firmware/

I tried updating the firmware. The firmware updater showed, that my current firmware version is already the latest 0040. Nevertheless, I hit the Update button and the tool patched 0040 again. However, the keyboard is still not recognized on my ubuntu machiene :(

The X50Q Q software is only supported on Windows.


Deal with missing cached resources from live dev sw

In https://github.com/mozilla/thimble.mozilla.org/issues/2381 and via support emails, we hear about users sometimes having their live dev preview not show the correct page, and instead show an S3 "missing key" 404 type page.  Why this is happening, I'm not sure, but the reason we do this is because the URL cache storage is obviously missing the resource it should have (i.e., we cache all files in the filesystem on project load, and also whenever we write to disk).
The most likely cause of this is that the service worker code is somehow not fully updated or the cached content is missing something.  One or more refreshes to force the service worker to update is necessary.  We need a way to communicate this.
In this PR I've added some custom checking to the service worker to see if the URL in question is a live dev URL that should be in cache and isn't.  When that happens, we'll return a custom 500 error page, which can have whatever we want in it.  Right now I did something very basic, and I'll get @flukeout to help me make it better:

To simulate the situation where this happens, modify this line of code to this:
var request = new Request(url + "missing", {

This will cause all live dev URLs to be wrong, and force this custom error handler to kick in.
To do localized versions of this page, we'll have to generate them statically at build-time so they can get cached.  And/or, I'll have to add requirejs to the service worker, which I'd like to avoid.

Not sure if this helps but error occurs for me in two common situations:

CSS Animations. I sometimes change something and then if I hit refresh it will occur.
-Javascript Navigation. When I use fadein or outs, slide navigations, etc.

It seems when I ask the Preview window to do stuff in the window that we know it doesn't do it just sometimes gets hung up.

@jgmac1106 so it would be helpful if you could aid me in figuring this out, since I can't reproduce it.  Does the preview ever work since you saw this error (i.e., is it intermittent, or did if fail and now it's not working)?
Have you tried refreshing a few times (the browser, not the preview)?

I tried the project, and a remix based on the project in multiple browsers
in both private and public. I get the cache error each time.
When things settle down a bit I will try to recreate the bug by fooling
around with teh types of projects that usually trigget this for me.
On Mon, Aug 14, 2017 at 11:28 AM David Humphrey<EMAIL_ADDRESS>wrote:

@jgmac1106 https://github.com/jgmac1106 so it would be helpful if you
could aid me in figuring this out, since I can't reproduce it. Does the
preview ever work since you saw this error (i.e., is it intermittent, or
did if fail and now it's not working)?
Have you tried refreshing a few times (the browser, not the preview)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/brackets/pull/866#issuecomment-322222174, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKC-ptw11NTtPCD-gEhHcWtq_FpIQ8Dyks5sYGeJgaJpZM4O02fU
.

@jgmac1106 can you paste / send the link to a published version of that project?

@jgmac1106 would you be willing to debug on vidyo with me sometime?  I'm not able to reproduce this at all, and it's hard to fix it without knowing what I'm dealing with

Here is the link: https://thimbleprojects.org/jgmac1106/303410/ The project
works fine.
And I have time to vidyo on Thursday or Friday of this week.
This isn't crucial in anyway so don't go crazy on my behalf.
On Tue, Aug 15, 2017 at 1:26 PM David Humphrey<EMAIL_ADDRESS>wrote:

@jgmac1106 https://github.com/jgmac1106 would you be willing to debug
on vidyo with me sometime? I'm not able to reproduce this at all, and it's
hard to fix it without knowing what I'm dealing with
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/brackets/pull/866#issuecomment-322532576, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKC-pjqdWXAaz_tfGGj_70flyFs4utxjks5sYdTKgaJpZM4O02fU
.

@humphd - the related PR for the page in Thimble is here - https://github.com/mozilla/thimble.mozilla.org/pull/2460
I've got one more fix to make on that page and it will be good to go

@humphd - OK I've merged the related Thimble PR and the page should be available at /refresh

So another set of fixes from @gideonthomas, and I'm still failing to get this to work...now with CSP issues and localhost:8000:

The crazy number of hacks we're having to do to make this work is starting to get to be too much.  I think we should regroup, and see if there is a better solution.  Let's discuss on our next call.

I've fixed this another way, closing.


Can you send video attachment not in metadata?

Howdy, I'm willing to send a video as an attachment seeing from the docs of rasa-webchat that it can display a video if it receives it as a normal attachment to the response. In Botfront - I've been able to send an attachment with the Custom Format Response - but that only sends it under the metadata section in the "customAttachment" field - which is probably why it isn't displayed in rasa-webchat, as I don't think it reads that stuff from the metadata unless you make a special custom component or a handler for custom messages.
This is how my Custom Format Response looks like:
attachment:
  type: video
  payload:
    title: Blank
    src: 'https://youtu.be/8tPnX7OPo0Q'

This is how the response of the bot looks when sent:
{
  "event": "bot",
  "timestamp":<PHONE_NUMBER>.1438482,
  "metadata": {
    "metadata": null,
    "customText": null,
    "customImage": null,
    "customButtons": null,
    "customElements": null,
    "customAttachment": {
      "type": "video",
      "payload": {
        "title": "Blank",
        "src": "https://youtu.be/8tPnX7OPo0Q"
      }
    }
  },
  "text": null,
  "data": {
    "elements": null,
    "quick_replies": null,
    "buttons": null,
    "attachment": null,
    "image": null,
    "custom": null
  }
}

You can look at how rasa-webchat detecs if the response contains a video here and how the check is used to display the video here.
Is there any way to send the attachment without it being in the custom data or metadata, or any other way to send a video as a response that will work with rasa-webchat?

Hi @M-Shadow, thanks for reporting. This is definitely a bug. The event should end up as:
{
  "event": "bot",
  "timestamp":<PHONE_NUMBER>.1438482,
  "metadata": null,
  "text": null,
  "data": {
    "elements": null,
    "quick_replies": null,
    "buttons": null,
    "attachment": {
      "type": "video",
      "payload": {
        "title": "Blank",
        "src": "https://youtu.be/8tPnX7OPo0Q"
      }
    },
    "image": null,
    "custom": null
  }
}

I was able to replicate. I'll keep you updated.

Found the problem. Fixed in https://github.com/botfront/rasa-addons/commit/00ca3541d3920d4c1fd71177a3ac5b633d3435fa. Will be part of rasa-for-botfront:v1.9.0-bf.13.

Videos are blocked in widget, cf. https://github.com/botfront/botfront/issues/603


Drawer page title disappears

Problem description
After selecting different drawer pages a few times, the page title disappears.
To reproduce, open the Drawer snippet 'Using a Drawer for app navigation' in the Tabris Developer App:

Tap Create page in drawer
Select the menu icon and switch forth and back between Basket and Checkout

The page title that used to be shown next to the menu icon disappears
Environment

Tabris.js version: 3.7.2
Device: iPhone
OS: 14.7.1

Screen Recording
https://user-images.githubusercontent.com/607182/129175332-7f4c21fa-6d3b-4aa7-b808-e62cc859772b.mov

fixed https://github.com/eclipsesource/tabris-ios/commit/e6a6fd96229e5f4f8fdd8c2e6a70d3d1248b3a65


Pre-Built openroad gui crashes

Describe the bug
Trying to use Pre-built binareis of OpenROAD from here: https://github.com/Precision-Innovations/OpenROAD/releases/tag/2023-06-26
Last build I tried is
$ openroad -gui
OpenROAD 7134b2d295137b28b4b9f3f02acbdcb18391a6cf
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.

OpenROAD GUI is working fine and tested with Ubuntu 20.04
With latest release  openroad_2.0_amd64-ubuntu22.04-2023-06-26.deb
OpenROAD GUI is crashing for both Ubuntu 20.04/22.04
OpenROAD b024b1f964dc6b656abc84e5fa65d10827f5ba33
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
openroad> gui::show
Signal 11 received
Stack trace:
 0# 0x000056416CA51F5B in openroad
 1# 0x00007FA09B527520 in /lib/x86_64-linux-gnu/libc.so.6
 2# 0x00007FA09CEECEE5 in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 3# 0x00007FA09CEF5D73 in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 4# 0x00007FA09CEF989B in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 5# 0x00007FA09CF241DA in /lib/x86_64-linux-gnu/libQt5Widgets.so.5
 6# gui::MainWindow::MainWindow(QWidget*) in openroad
 7# gui::startGui(int&, char*, Tcl_Interp, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) in openroad
 8# 0x000056416CED2658 in openroad
 9# TclNRRunCallbacks in /lib/x86_64-linux-gnu/libtcl8.6.so
10# 0x00007FA09F3C0028 in /lib/x86_64-linux-gnu/libtcl8.6.so
11# Tcl_EvalEx in /lib/x86_64-linux-gnu/libtcl8.6.so
12# Tcl_Eval in /lib/x86_64-linux-gnu/libtcl8.6.so
13# ord::tclAppInit(Tcl_Interp*) in openroad
14# Tcl_MainEx in /lib/x86_64-linux-gnu/libtcl8.6.so
15# main in openroad
16# 0x00007FA09B50ED90 in /lib/x86_64-linux-gnu/libc.so.6
17# __libc_start_main in /lib/x86_64-linux-gnu/libc.so.6
18# _start in openroad
Segmentation fault

Expected Behavior
GUI should open smoothly.
Environment
Ubuntu 20.04/22.04
Tried with WSL based Ubuntu also.

To Reproduce
https://github.com/Precision-Innovations/OpenROAD/releases/tag/2023-06-26 download ubuntu 22.04 deb package and install with
sudo apt install  openroad_2.0_amd64-ubuntu22.04-2023-06-26.deb
openroad -gui

Relevant log output
No response
Screenshots
No response
Additional Context
No response

@vijayank88 reports:
build_openroad.sh --local working fine. Only prebuilt binaries crash and final gds not generated

@vvbandeira any ideas?


updated eula on App SDK download page

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Can't install sass-globbing with gem

error code
ERROR:  Could not find a valid gem 'sass-globbing' (>= 0), here is why:           Unable to download data from https://rubygems.org/ - Errno::ECONNRESET: Connection reset by peer - SSL_connect (https://rubygems.org/latest_specs.4.8.gz)

seems like a problem with rubygems or your networking.

@zhangzan Try using ruby.taobao.org explained here: https://github.com/jekyll/jekyll/issues/1409#issue-17909206


Add guide for upgrading to v3

This adds a guide from upgrading from v2 to v3.
TODO:

[x] Cover git-clean-flags change (added -x)
[x] Cover interpolation
[x] Annotations

@harrietgrace we are going to get this into prod and then some copy iterating on it!


logger: macros evaluate logging level before invoking logger

Description: logger's current severity level is checked before calling logger's API. This avoids evaluating parameters passed to the logger when message severity is lower than logger's setting. Before this change, params were evaluated even when the message was later on dropped by logger. This addresses  issue #2330. First PR #2676 was reverted because code did not compile when NVLOG compile flag was enabled. This has been fixed and test for this case has been added.
Risk Level: Medium. This is simple fix, but the code is extensively used across the project.
Testing: unit tests: added 3 tests to test/common/common/log_macros_test.cc. Added test to makes sure that code compiles when NVLOG is defined.
Docs Changes: N/A
Release Notes: N/A

@mrice32 sorry for the hot spotted load balancing here, but can you also look at this one as this is your code? Thanks.

@ggreenway @junr03 @lita @ccaraman Second PR attempt to address #2330. Corrected issue with NVLOG compile flag. The first PR was #2676 and was reverted.

If there are any other comments related to this PR, they will have to wait - I will be away for few days.

@mattklein123 sure - I can remove NVLOG. I am away though for few days.
On Mar 9, 2018 3:02 PM, "Matt Klein"<EMAIL_ADDRESS>wrote:
@mattklein123 commented on this pull request.
In test/common/common/log_macros_test.cc
https://github.com/envoyproxy/envoy/pull/2751#discussion_r173553538:

// Just log as part of if ... statement

if (true)
ENVOY_LOG_MISC(critical, "test message 1");
else
ENVOY_LOG_MISC(critical, "test message 2");

// do the same with curly brackets
if (true) {
ENVOY_LOG_MISC(critical, "test message 3");
} else {
ENVOY_LOG_MISC(critical, "test message 4");
}
+}

+#ifdef NVLOG
@cpakulski https://github.com/cpakulski are you interested in just
getting rid of NVLOG as part of this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/pull/2751#discussion_r173553538, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Aiy1DlAGE75oMLso-SxQK4fL8OfJ_oSdks5tct-_gaJpZM4ShLzL
.

@cpakulski no problem, take your time. Thank you!

Per new release note policy please add a release note with any applicable feature docs to https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst. Thank you!

@mattklein123 @ggreenway I would prefer to remove NVLOG flag as a separate PR. My main concern is that if for any reason (performance for example) those changes have to be removed, it will be easier to revert. If you agree, please merge this PR #2751 and open a new issue to track removal of NVLOG flag.

@cpakulski sure, that's fine. I opened https://github.com/envoyproxy/envoy/issues/2854 to track.


Fix Solaris defines for Endian-ness

Don't use variants with IN which expect pointer.
Sorry for the issue. Please see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1405268
https://bugzilla.mozilla.org/show_bug.cgi?id=1419009
Now it should be hopefully right. I have created test program for these macros and I'm getting the same results as on Linux.

Thanks ! :) I'll propagate that to HACL* and NSS asap and comment in Bugzilla when done.


Expand .net compatibility

The dotnet tool currently does not support .Net9 investigating this, I believe is we add netstandard we could expand the supported runtimes a lot.

Before:


Applies to 2012r2 also?

I can't figure out why should this content not apply to AD FS 2012r2 also. The content of the page seems to match this one which is labeled for server 2012 technical preview: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-R2-and-2012/dn823754(v=ws.11)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce6494d8-d525-8961-8dff-c5ee55a18849
Version Independent ID: a3608a5f-26ed-1a93-2cd2-2fe2e5238248
Content: Configure AD FS to authenticate users stored in LDAP directories
Content Source: WindowsServerDocs/identity/ad-fs/operations/Configure-AD-FS-to-authenticate-users-stored-in-LDAP-directories.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

Configure AD FS to authenticate users stored in LDAP directories
I executed  the cmdlet '$vendorDirectory = New-AdfsLdapServerConnection –HostName adserver.contoso.com –Port 389 –SslMode None –AuthenticationMethod Basic –Credential $DirectoryCred' met error, error info is :
New-AdfsLdapServerConnection : The term 'New-AdfsLdapServerConnection' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the
path is correct and try again.
At line:1 char:20

$vendorDirectory = New-AdfsLdapServerConnection -HostName adserver.contoso.com -P ...

               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (New-AdfsLdapServerConnection:String) [], CommandNotFoundException
FullyQualifiedErrorId : CommandNotFoundExceptionpelease help me

#please-close

Hi, may I know the solution to this? Why is it that we cannot apply this command (New-AdfsLdapServerConnection) in windows server 2012. Is there a workaround for this?


CZs and iSWAPs characterized

All the iSWAPs and CZs available (coupler 0 not working so q0-q2 2q gate can not be characterized) characterized.
This runcard need the implementation of qibolab issues (to run with qibolab/qibocal main):
https://github.com/qiboteam/qibolab/issues/921
https://github.com/qiboteam/qibolab/issues/920
https://github.com/qiboteam/qibolab/issues/900
Fine tunning of the CZs  landscape also need the implementation of the issues 921, 920 and 900 is needed to be able to run landscape without fitting errors (already fixed in qibocal main)

IMPORTANT INFO:

coupler 0 is not working so, q0q2 CZ is not operative. Still q0 can be used for single qubit  operations

In order to test q4q2 CZ or use q4 single qubit gates, set q4 sweetspot to -0.3. I need to recalibrate q1q2 CZs after setting q4 out of the ss to be able to characterize q4q2 CZ

This characterization allows pass mermin and CHSH tests.

q4 - q2 CZ recalibrated:
http://login.qrccluster.com:9000/mPzele1YQVKwh2eoueKxPw==

q1q2 CZ characterized after latest warm up:
http://login.qrccluster.com:9000/mSt5Xc6cSnWCfOf9i6ql1g==


generic scalar pointtrait

ref https://github.com/georust/geo/discussions/838#discussioncomment-3797418

stale and no longer relevant


Delete bundle: handle pre-installed karaf bundles

Previously, if you tried to delete a bundle that was pre-installed in brooklyn karaf then the REST pai call would return a 500 response:
curl -v -X DELETE -u xxxxxxxx:xxxxxxxx http://localhost:8081/v1/catalog/bundles/org.example.my-pre-installed-bundle/1.0.0

gave the exception:
"No such bundle installed in OSGi when uninstalling: BasicManagedBundle{symbolicName=org.example.my-pre-installed-bundle, version=1.0.0, url=mvn:org.example/my-pre-installed-bundle/1.0.0}"...

e.g. to reproduce, try removing a bundle like http://localhost:8081/v1/catalog/bundles/org.apache.brooklyn.software-database/1.0.0.SNAPSHOT
This PR changes our bundle-lookup so that we don't just use the bundleMetadata.getOsgiUniqueUrl(), but instead use lookup by url etc (in the same way as we use elsewhere).

non-det test failure:
org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogicTest.testStopsNicelyToo

LGTM, merging


Support non-Linux platforms

Checks

[ ] Debugging completed
[ ] Please debug me

Related Issue
This PR closes #32.

Seems too much fix needed


Broken link to contributing guide in docs

Describe the bug
The page at https://pyinfra.readthedocs.io/en/latest/contributing.html points to https://github.com/Fizzadar/pyinfra/blob/master/CONTRIBUTING, but the link is broken.
To Reproduce
Navigate to https://pyinfra.readthedocs.io/en/latest/contributing.html, click on "Contributing guide".
Expected behavior
The link should go to https://github.com/Fizzadar/pyinfra/blob/master/CONTRIBUTING.md
Meta

Include output of pyinfra --support.
How was pyinfra installed (source/pip)?
Include pyinfra-debug.log (if one was created)
Consider including output with -vv and --debug.

Thanks @stchris, https://github.com/Fizzadar/pyinfra/commit/e0982134ee6dafaaef71d46452b7f0ba19516da6 should fix this!


Improve DataFrame Stringer interface behaviour for large tables

Consider modifying DataFrame.String() by limiting the column length to a number of characters. Likewise, it could be interesting to wrap columns in separate lines if the combined length is too large.
Additionally one might want to summarise this information if the number of rows is very high. We could use something like what dplyr or data.table are doing, showing only the first and last 10/20 rows instead of the whole table.
An alternative could be to leave DataFrame.String() as is and move these suggested modifications to a separate function. That way, if we want to print the entire table instead of a summary of it we will still be able to do it.

As of e362eb18dc8ba042ec0a0ded2e74134aab90a172 the new DataFrame.String() method has been largely inspired by dplyr trying to keep the same conventions Gota has been using so far.

Not Showing: B_207 <int>, B_223 <int>, B_239 <int>, B_255 <int>, B_271 <int>, C <float>,
D <bool>

In the future we might want to make the max number of rows shown and max number of characters per line parametric, but for now I'm closing this issue as the current solution is good enough for me. If the feedback merits it, I will reopen it to include further improvements.


CONTRIBUTING.md is missed in moby/tool

We need this file as internal legal approval(for inbound license or agreement for contributions to project), but this file is missed in moby/tool project. Can anyone help us out that?

Sorry, originally this was going to be merged into another repo and we did
not add all the supporting files, will fix this.
Cc @thajeztah
On 12 Jul 2017 07:30, "Dennis Chen"<EMAIL_ADDRESS>wrote:

We need this file as internal legal approval(for inbound license or
agreement for contributions to project), but this file is missed in
moby/tool project. Can anyone help us out that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/moby/tool/issues/108, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPH-BJS4F0X53CI0t5xsDXgKULzV-ks5sNGfsgaJpZM4OVLp2
.

OK, thanks for the update!

The doc has now been added.


Improve SEO

Feature Request
Improve the SEO for Google etc. by adding a sitemap and a robots.txt
Problem description
When we search e.g. for "semantic ui react label", no result for the react label will appear:

Proposed solution

add a sitemap.xml
add a robots.txt which refer to the sitemap

MVP
Best way would be to not hard code the sitemap. So maybe we could generate the links?
I'm also not sure, if this repo is the correct place for such an issue. I haven't found the repository for the semantic ui react documentation page yet.
Edit:
I tried to find the URLs in Google by searching for site:https://react.semantic-ui.com/elements/label.
=> Google has indexed the result, so maybe just the SEO is very bad on these pages? idk

I want to try move our docs to Gatsby, it looks like the best solution there.

Prerendering would be great.


Add Infro PR Checks?

I noticed that this repo uses Argo CD, and I thought I’d let you know that I recently released a Github app called Infro that several companies use internally that allows Argo CD users to preview Kubernetes changes in Github pull requests before they merge. I’m providing it for free to open source projects (here’s an example in the wild). Here’s a setup guide with links to documentation. It’s in early stages, so I’m sure there will be warts. All feedback is welcome!

Thank you for the suggestion. I will close the issue just because this does not relate to our project directly, but relates more with how people could use the Argo CD installed by our project.


Support idmapping

https://github.com/opencontainers/runtime-spec/pull/1143
We need to support for mount_setattr syscall

[ ] libc crate support
[ ] nix crate support

idmap and ridmap mount options
https://github.com/opencontainers/runtime-spec/pull/1222


curl-based request does not maintain HTTP keepalive after 4xx response

Describe the bug
I have noticed that the AWS CPP SDK does not maintain HTTP keepalive with services when the service responds with a HTTP 4xx or 5xx status code - the connection is closed directly after receive such a response. The result is a high volume of HTTP reconnects and, in my case, high CPU usage due to excessive loading of /etc/pki/ssl/certs/ca-bundle.crt for each new connection (and the abundance of HTTP 400 errors in DynamoDB for ConditionalCheckFailed exceptions)
The root cause is behavior from libcurl, in which some code determines that 'upload was incomplete' after receiving an HTTP error code which is 300 or above (see https://github.com/curl/curl/blob/master/lib/http.c#L4128 ). The reason for this is that the AWS SDK CPP is providing a CURLOPT_READFUNCTION but not a CURLOPT_POSTFIELDSIZE. Normally this would result in a chunked upload, but CurlHttpClient.cpp is overriding this by providing a Content-length and Transfer-Encoding header explicitly. As a result, libcurl is unable to determine if the entire request body has been sent after receiving the response. Disputably this is a bug in libcurl, but the fix in the SDK seems pretty easy.
On my system the fix caused significant CPU usage improvements (like, 50%) due to not having to re-load the cert bundle for each request but it is heavily dependent on the number of 4xx's received.
Expected Behavior
HTTP keepalive should work when we receive a 400
Current Behavior
HTTP connection is dropped after any 3xx, 4xx or 5xx response from a service
Reproduction Steps
The easiest way to show this is by modeling the interaction with libcurl. The minimal code for libcurl to show the reconnection, modeled after the interaction that CurlHttpClient has with libcurl is:
#include <stdio.h>
#include <curl/curl.h>

size_t read_callback(char *ptr, size_t size, size_t nmemb, void *userdata)
{
  return fread(ptr, size, nmemb, (FILE *)userdata);
}

int main(void)
{
  CURL *curl;
  CURLcode res;

  curl = curl_easy_init();
  struct curl_slist *list = NULL;

  if(curl) {
    FILE *file = fopen("small", "rb");
    fseek(file, 0, 2);
    size_t size = ftell(file);
    fseek(file, 0, 0);
    char buf[1024];

    sprintf(buf, "Content-length: %d", size);

    list = curl_slist_append(list, buf);
    list = curl_slist_append(list, "Expect:");
    list = curl_slist_append(list, "transfer-encoding:");

    curl_easy_setopt(curl, CURLOPT_URL, "https://dynamodb.us-east-1.amazonaws.com");
    curl_easy_setopt(curl, CURLOPT_POST, 1L);
    curl_easy_setopt(curl, CURLOPT_READFUNCTION, read_callback);
    curl_easy_setopt(curl, CURLOPT_READDATA, (void *)file);
    curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
    curl_easy_setopt(curl, CURLOPT_HTTPHEADER, list);

    // ------------------------------------------ UNCOMMENT TO FIX
    //    curl_easy_setopt(curl, CURLOPT_POSTFIELDSIZE, size);

    // FIST REQUEST
    res = curl_easy_perform(curl);
    if(res != CURLE_OK)
      fprintf(stderr, "curl_easy_perform() failed: %s\n",
              curl_easy_strerror(res));

    // SECOND REQUEST
    fseek(file, 0, 0);

    res = curl_easy_perform(curl);
    if(res != CURLE_OK)
      fprintf(stderr, "curl_easy_perform() failed: %s\n",
              curl_easy_strerror(res));

    curl_easy_cleanup(curl);
  }
  return 0;
}

Just compile with g++ -o curltest curltest.cpp -lcurl and create a file called small with some random content for it to attempt to upload.
This test makes two requests to dynamodb which are clearly incorrect, resulting in a 404 from dynamodb. What should happen, is that the second request re-uses the connection from the first, but it does not (see output below), unless the "UNCOMMENT TO FIX" line is uncommented.
Without the fix, this will output:
...
* HTTP error before end of send, stop sending
<
* Closing connection 0
...
* Hostname dynamodb.us-east-1.amazonaws.com was found in DNS cache
*   Trying <IP_ADDRESS>:443...
* Connected to dynamodb.us-east-1.amazonaws.com (<IP_ADDRESS>) port 443 (#1)
...

uncommenting the fix produces:
...
* We are completely uploaded and fine
...
* Connection #0 to host dynamodb.us-east-1.amazonaws.com left intact
* Found bundle for host dynamodb.us-east-1.amazonaws.com: 0x7073d0 [serially]
* Can not multiplex, even if we wanted to!
* Re-using existing connection! (#0) with host dynamodb.us-east-1.amazonaws.com
* Connected to dynamodb.us-east-1.amazonaws.com (<IP_ADDRESS>) port 443 (#0)

Possible Solution
diff --git a/aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp b/aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp
index 5e6c8fc..8a06bca 100644
--- a/aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp
+++ b/aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp
@@ -653,6 +653,7 @@ std::shared_ptr<HttpResponse> CurlHttpClient::MakeRequest(const std::shared_ptr<
             curl_easy_setopt(connectionHandle, CURLOPT_READDATA, &readContext);
             curl_easy_setopt(connectionHandle, CURLOPT_SEEKFUNCTION, SeekBody);
             curl_easy_setopt(connectionHandle, CURLOPT_SEEKDATA, &readContext);
+            curl_easy_setopt(connectionHandle, CURLOPT_POSTFIELDSIZE, request->GetSize());
             if (request->IsEventStreamRequest())
             {
                 curl_easy_setopt(connectionHandle, CURLOPT_NOPROGRESS, 0L);

Additional Information/Context
Currently I'm using a different workaround, which is setting CURLOPT_KEEP_SENDING_ON_ERROR which also allows the connection to stay open. This is settable without modifying the AWS SDK CPP by setting this curl flag manually, but that seems like a bit of a hack.
AWS CPP SDK version used
I used 1.8 but the same code is in 1.9
Compiler and Version used
gcc
Operating System and version
linux AL2

This is currently behaving as expected, but it is a feature request that we might add at some point in the future


VSCode no longer showing Go To Definition on right click has returned

Right click go to definition has returned in Version: 1.39.2.  I know this has been and on and off return. It has returned. Please fix.

VSCode Version:  .39.2.
OS Version:  Windows 10 pro

Steps to Reproduce:

Does this issue occur when all extensions are disabled?: Yes/No

Please describe in more detail. If there was a previous issue it would help to link it.

There is really no detail to provide.  I open a folder project.  I go to the code and it is not there. I will get a screen shot for you on Monday. Thanks.

What language? What extensions are you using?


Update ava to ^0.7.0

Some things changed, needed to strip ansi from a test. :+1:

:+1:

closes #48


Generated references could use forward slashes as path seperators

When generating references for FSI:
#I __SOURCE_DIRECTORY__
#r @"..\..\..\src\bin\Debug\FunSharp.Library.dll"
#r @"System.Core.dll"
#r @"System.dll"
#r @"System.Numerics.dll"
#r @"..\..\..\lib\Xwt.dll"
#r @"..\..\..\lib\Xwt.Gtk.dll"

Backslashes don't work on non-windows platforms, whereas Windows can handle forward slashes.
Would like to be able to use the generated files on OSX without manually replacing the slashes ;)

Oh, I have never thought of that.
Do you want to send a PR? Handling relative path is done at https://github.com/fsprojects/VisualFSharpPowerTools/blob/e736aa38668d182696b04dd2f6e6dd637b2515f1/src/FSharpVSPowerTools.Logic/FsiReferenceCommand.fs#L69-L77

Will try to find the time ;)

Hurry up, I've almost picked this one :)

Please, go ahead. This week is quite tight for me ;)

Same ;)

I would prefer that @devboy PRs and @vasily-kirichenko reviews  the code (and I'm cheerleading).
The more contributors there are, the merrier the project is :-).


Add Mindforger-1.48

Add another package for nixpkgs users
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

I have coreutils-8.30 in nixpkgs and it builds.
AC_TR=`acLookFor tr`
if [ "$AC_TR" ]; then
    # try posix-style tr
    ABC=`echo abc | tr abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ`
    if [ "$ABC" = "ABC" ]; then
        AC_UPPERCASE="$AC_TR abcdefghijklmnopqrstuvwxyz ABCDEFGHIJKLMNOPQRSTUVWXYZ"
        AC_UPPER_PAT="ABCDEFGHIJKLMNOPQRSTUVWXYZ"
    else
        ABC=`echo abc | tr a-z A-Z`
        if [ "$ABC" = "ABC" ]; then
            AC_UPPERCASE="$AC_TR a-z A-Z"
            AC_UPPER_PAT="A-Z"
        else
            ABC=`echo abc | tr '[a-z]' '[A-Z]'`
            if [ "$ABC" = "ABC" ]; then
                AC_UPPERCASE="$AC_TR '[a-z]' '[A-Z]'"
                AC_UPPER_PAT="'[A-Z]'"
            else
                AC_FAIL "$AC_TR cannot translate lowercase to uppercase"
                return 0
            fi
        fi
    fi
else
    AC_FAIL "configure requires a functional version of tr"
fi

Here is a script. Looks like it can not find working tr in an environment. Do I need to add coreutils as explicit dependency? Is standard environment in NixOS differs?

This fixes the tr issue and the one I ran into after that:
https://github.com/dtzWill/nixpkgs/commit/833b82b97922481c24df13f8274d707d55ddbd39

Is ccache needed for the build, or useful for non-sandbox building? If the latter then it should be removed before merging.
Also, I think this should have enableParallelBuilding = true; in it-- unless the choice to not do so was intentional?  Helps it not take forever :grin:

Hmm, the .desktop needs to be fixed: it references /usr/bin/mindforger apparently.
(Thank you!! Not your fault all these things need addressing haha :3)

@dtzWill Thanks! How .desktop can be fixed?

And using ccache is definitely not needed here.

@dtzWill Thanks! How .desktop can be fixed?

Something like:
substituteInPlace path-to-it.desktop --replace /usr "$out"

Maybe?
I would expect it's just hard-coded so it can be done during postPatch -- which is nice to see if it's fixed without needing to build first :D.

in postPatch or in postInstall directly on the installed desktop file

Not for this particular case, but in general

I guess https://nixos.org/nixpkgs/manual/#ssec-stdenv-functions is the best source

Ok thanks.

@GrahamcOfBorg build mindforger

Failure on aarch64-linux (full log)
Attempted: mindforger
Partial log (click to expand)
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/build.make:12375: Source/WebCore/CMakeFiles/WebCore.dir/css/CSSAllInOne.cpp.o] Error 4
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:783: Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/q3q603mwkl7wfwfkfb18zpg1hd0bsyk3-qtwebkit-5.212-alpha-01-26-2018.drv' failed with exit code 2
cannot build derivation '/nix/store/imaa3s0g08asn074yrajz84bs4gwllhk-mindforger-1.48.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/imaa3s0g08asn074yrajz84bs4gwllhk-mindforger-1.48.2.drv' failed

Timed out, unknown build status on x86_64-linux (full log)
Attempted: mindforger
Partial log (click to expand)
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/TempRegisterSet.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/ThunkGenerators.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LLIntCLoop.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LLIntData.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LLIntEntrypoint.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LLIntExceptions.cpp.o
[ 19%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LLIntSlowPaths.cpp.o
building of '/nix/store/1242dn82d4p5ww7jn7w6ha6ylq4lvxxf-qtwebkit-5.212-alpha-01-26-2018.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/s1b2syxp8aqqcl64f116v4yscpaf3sji-mindforger-1.48.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s1b2syxp8aqqcl64f116v4yscpaf3sji-mindforger-1.48.2.drv' failed

Looks like binary cache not ready yet

Failure on aarch64-linux

I think it is not supported in upstream. Can I limit architectures to build this package on?

(only trusted users can invoke the bot :) )
The previous aarch64 failure was not with mindforger but with qtwebkit it seems.. which is supposed to be multi-arch. Let's retry once, then we'll decide whether to restrict supported platforms.
@GrahamcOfBorg build mindforger

Success on x86_64-linux (full log)
Attempted: mindforger
Partial log (click to expand)
shrinking /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2/bin/mindforger
gzipping man pages under /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2/lib  /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2/bin
patching script interpreter paths in /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2
checking for references to /build in /nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/72z1w4q6nmsjilsazpczj8xzlb7nw5w6-mindforger-1.48.2

Success on aarch64-linux (full log)
Attempted: mindforger
Partial log (click to expand)
shrinking /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2/bin/mindforger
gzipping man pages under /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2/lib  /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2/bin
patching script interpreter paths in /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2
checking for references to /build in /nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/cqp878bdndzvpphl0qqkfr2h2m75b6y5-mindforger-1.48.2

Well now this is ready. :)
@s9gf4ult thank you for the contribution to nixpkgs

Cool!


Use hooks (easy to unregister hooks)

up ?

Thank you for this PR. Could you tell me why it is better to use hooks?

Closing due inactivity.


Browser instance is never destroyed

Running this locally and noticed that the process never finishes. Upon testing it looks like this is because the browser is never closed/destroyed. Is this a problem? Seems like a good enhancement would be a method to shut down the browser/ProfileScraper when you're done scraping.

I have added a websocket endpoint to manage your own browser with this PR: https://github.com/linkedtales/scrapedin/pull/106
Waiting for a merge...


Lack of spaces inside calc(+-)

Hey guys, when I'm trying to compile simple sass file with supercube included I'm getting an error:
Syntax Error: SassError: "+" and "-" must be surrounded by white-space in calculations.

There are also couple of warning that perhaps could be fixed as well:

Superkube 2.4.0 / Vue 3 / sass 1.43 / sass-loader 10.2

Fixed in https://github.com/imperavi/superkube/commit/01905727f31251549b62479d4c1073b29cd20302
Huge thanks for quick support :)
'till it will be tagged & released I will just go with:
yarn add https://github.com/imperavi/superkube.git


Refactor server deallocation

This is intended to address the following issues related to Python server shutdown and garbage collection:
https://github.com/grpc/grpc/issues/15756
https://github.com/grpc/grpc/issues/17093
https://github.com/grpc/grpc/issues/17214
https://github.com/grpc/grpc/issues/17258
This avoids taking a lock in the server's __del__ method, which is unsafe as the lock may never be released when the interpreter is shutting down or the process has forked prior to exec. It also avoids relying on garbage collection to trigger the final grpc_server_destroy() call to fully shutdown the server in core.
I'm still not fully certain that our existing calls into core from Cython __dealloc__ methods are guaranteed safe in the event of interpreter shutdown or post-fork thread state cleanups, but any issues there are not introduced by this PR and can be addressed as a follow-up item.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,388      Total (=)      2,019,388

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,154,192      Total (>)     11,154,187

 No significant differences in binary sizes

Can you take a look at Sanity Test and Basic Tests Multi-language Linux? The Channelz test in the later one failed with Segfault...

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,548      Total (=)      2,019,548

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,155,942      Total (<)     11,155,947

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,548      Total (=)      2,019,548

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,155,944      Total (>)     11,155,943

 No significant differences in binary sizes

Can you take a look at Sanity Test and Basic Tests Multi-language Linux? The Channelz test in the later one failed with Segfault...

Ack, fixed (messed up the original fix for pylint's too-many-branches)

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,019,548      Total (=)      2,019,548

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,155,947      Total (<)     11,155,951

 No significant differences in binary sizes

@gnossen PTAL
@lidizheng Thanks for the review.

Tests added, PTAL. This should be ready to go now.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,730      Total (>)     11,324,724

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,727      Total (<)     11,324,731

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,727      Total (>)     11,324,724

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,723      Total (<)     11,324,732

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,726      Total (>)     11,324,724

 No significant differences in binary sizes

Looks like Basic Tests Multi-language Linux has a flake somewhere that hits a segfault intermittently on Python 2.7, usually (but also during other tests) during py27_native.test.unit._channel_ready_future_test.ChannelReadyFutureTest.
The failure has already occurred several times on master in the last few days, but it looks like the changes here might have made it more frequent. I think it may be a bug in our test suite (since it only started segfaulting on this PR after I added the new tests, but it's not the new tests that are failing), diagnosing now.

This is https://github.com/grpc/grpc/issues/15308 - although it can also occassionally segfault during a different test, e.g., MetadataCodeDetailsTest here

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,727      Total (<)     11,324,732

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,842      Total (=)      2,026,842

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,324,723      Total (>)     11,324,721

 No significant differences in binary sizes

Unable to reproduce the flake on this branch; will continue to investigate #15308 separately, but I believe this PR can proceed.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,850      Total (=)      2,026,850

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,325,195      Total (>)     11,325,185

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,850      Total (=)      2,026,850

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,325,190      Total (>)     11,325,187

 No significant differences in binary sizes

Added _server_shutdown_scenarios to BUILD.bazel.
The segfault in https://source.cloud.google.com/results/invocations/240bcd80-572c-4d22-8d00-f1581e764510/targets/github%2Fgrpc%2Fpython_linux_opt_native/tests is #15308

Forward the critical log segment in the failed test:
TIMEOUT: //src/python/grpcio_tests/tests/unit:_server_shutdown_test (Summary)
      /root/.cache/bazel/_bazel_root/d2dc70c3d9da3fab488ba0dcbbd35051/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/testlogs/src/python/grpcio_tests/tests/unit/_server_shutdown_test/test.log
==================== Test output for //src/python/grpcio_tests/tests/unit:_server_shutdown_test:
test_deallocated_server_stops (__main__.ServerShutdown) ... ok
test_server_exception_exits (__main__.ServerShutdown) ... Traceback (most recent call last):
  File "/var/local/git/grpc/src/python/grpcio_tests/tests/unit/_server_shutdown_scenarios.py", line 97, in <module>
    run_test(args)
  File "/var/local/git/grpc/src/python/grpcio_tests/tests/unit/_server_shutdown_scenarios.py", line 71, in run_test
    raise Exception()
Exception
ok
test_server_fork_can_exit (__main__.ServerShutdown) ... Terminated
external/bazel_tools/tools/test/test-setup.sh: line 193:  6696 Terminated              ( "${TEST_PATH}" "$@" &> "${XML_OUTPUT_FILE}.log" )
================================================================================

Bazel failure was due to our (rather old) bazel docker image not supporting ipv6. This + wait_for_ready=True means that the test was timing out while the channel attempted and repeatedly failed to connect with the error:
"Connect Failed","file":"src/core/ext/filters/
client_channel/subchannel.cc","file_line":867,"grpc_status":14,"referenced_errors":[{"created":"@1545109177.781701379","de
scription":"OS Error","errno":97,"file":"src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":379,"os_error":"Address family not supported by protocol","syscall":"socket","target_address":"[::]:43403"}]}]}]

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,850      Total (=)      2,026,850

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,325,191      Total (<)     11,325,195

 No significant differences in binary sizes


iOS: Share and reader buttons should be disabled if the permalink is missing

This occurs on Feedly and only on this blog https://blog.hal.codes/rss.xml.

It looks like this is an issue with the permalink. The article title correctly doesn’t link out.
When the permalink is missing or invalid, the share and reader buttons should be disabled.
There is still the issue of why the permalink is bad on Feedly.

The blogs permalink is invalid. It looks like Feedly strips out invalid URL’s.

@vincode-io Is the permalink stored in the url property of ExtractedArticle ?

You should test to see if the preferredLink on the article is nil.

@vincode-io As I'm in a hurry and cannot open another PR right now, here is my change to fix this issue: Edit LOC 144 onwards in ArticleViewController.swift to the following:
nextUnreadBarButtonItem.isEnabled = coordinator.isAnyUnreadAvailable
prevArticleBarButtonItem.isEnabled = coordinator.isPrevArticleAvailable
nextArticleBarButtonItem.isEnabled = coordinator.isNextArticleAvailable
readBarButtonItem.isEnabled = true
starBarButtonItem.isEnabled = true

let permalinkPresent = article.preferredLink != nil && article.preferredLink?.count ?? 0 > 7
articleExtractorButton.isEnabled = permalinkPresent
actionBarButtonItem.isEnabled = permalinkPresent

article.preferredLink?.count ?? 0 > 7 is just pure guessing. We could also 8 characters to make sure it's https:// or similar. What is also entire feasible: Use URL(from string:String) to check wether iOS can create a valid URL from this string. If this works, we treat the link as present.
There are multiple ways of solving this.

You can trust preferredLink to be nil if the link isn't there.  You don't need the length test.
We've got plenty of time still to get this in.  Just open a pull request for it when you are available.


Dynamically load VRTK through code

Is there an example anywhere of dynamically loading VRTK through code instead of setting up through the inspector? My app sets everything up in code based on whether Oculus or Vive is detected and I can't VRTK to update the system type appropriately unless I change it through the inspector.

I actually worked on exactly that the last day and will push it to my PUN Test project sometime tomorrow.
My work on that project resulted in #1024 and #1025, that should simplify things a bit. After updating the project I'll probably work on #817 which expands on the idea of using the SDK Manager at runtime. More tomorrow!

@bddckr how are you getting the VRTK sdk_manager to work in multiplayer? I am struggling to get multiple instances of it running (when attached to a player prefab). I have tried spawning local versions with the player but get similar issues. Which led me here with the idea of dynamically adding the steamVR components to the manager on player spawn, which requires runtime usage.

@mcgi5sr2 Yeah, don't use multiple ones, just set up a single one for your usage. I'm 90% finished on my test project linked above and will post here when done. You can also watch that repository to get notifications when I do something (you can set GitHub's settings to even email you then).

Thanks man, been driving me up the wall. If I could just call the sdk setup functions on player join && if player is VR it would be fine.

@mcgi5sr2 The project does include an "SDK Chooser" now. Have a look.

@bddckr the latest version of VRTK allowing for run time population/assignment of VR controllers etc is excellent, but I am struggling to find a method of calling it before the GameObject the VRTK_sdkManager is attached is activity (thus causing unity to crash due to the headset etc variables not being defined).

@mcgi5sr2 I just start with the SDK Manager game object being disabled and then enable it after setting everything up. You can see that in the example project here.

@mcgi5sr2 I also suggest you to join our  for these back and forth discussions 😄

This will be resolved with this: https://github.com/thestonefox/VRTK/issues/817
(i assume)

Yup!


Token '134>Feb  8 11' doesn't match specifier '%d'

Hello. Please help me parse log.
Format:
<134>Feb  8 11:44:00 haproxy[888]: <IP_ADDRESS>:37776 [08/Feb/2021:11:44:00.092] in-75-m-local -mobile/app 1/0/0/4/5 200 268 - - ---- 2128/102/41/5/0 0/0 "GET /service/api/oauth/verify HTTP/1.1"
I tried
goaccess accesslog --log-format='[%d:%t %^] %^=%h %^="%r" %s %^=%b %
^' --date-format='%d/%b/%Y' --time-format=%T
Parsed 1 linesproducing the following errors:
Token '134>Feb  8 11' doesn't match specifier '%d'
and many otger queries. But still have errors

Hi @Lsytnyk .
Can You show HAProxy logformat for this?
thanks.

Closing this. Feel free to share those fields/reopen it if needed.


Fixed MEAR-217: Correct match of snapshot version in skinny wars

The patch was already proposed (and tested by the community) within JIRA issue https://issues.apache.org/jira/browse/MEAR-217
but never integrated. The patch includes a very small fix and a corresponding integration test of the problem.

The added IT test is not passing, with the error:

Could not find artifact eartest:jar-sample-one:jar:1.0-20150825.210557-91 in local.snapshot (file://...\maven-ear-plugin\target\test-classes/m2snapshots)

The JAR file needed for the test is not in the snapshot local repository (under the new src/test/resources/m2snapshots). Could you look into that?

The file should be contained in the commit: https://github.com/apache/maven-plugins/pull/100/files#diff-3409a3090fdfb8413bd84dca2ac25e34
The its run successful on my box.
[INFO] --- maven-invoker-plugin:2.0.0:integration-test (integration-test) @ maven-ear-plugin ---
[INFO] Building: basic\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (54.0 s)
...
[INFO] Building: skinny-wars-javaee5\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (29.5 s)
[INFO] Building: skinny-wars-timestamp\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (5.0 s)
[INFO] Building: transitive-excludes\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (2.7 s)
[INFO]
[INFO] --- maven-failsafe-plugin:2.19.1:integration-test (default) @ maven-ear-plugin ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.maven.plugins.ear.it.EarMojoIT
  Building: project-001
  Building: project-002
  ...
  Building: project-082
  Building: project-083
  Building: project-084
  Building: project-085
Tests run: 85, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 224.081 sec - in org.apache.maven.plugins.ear.it.EarMojoIT

Results :

Tests run: 85, Failures: 0, Errors: 0, Skipped: 0

[INFO]
[INFO] --- maven-checkstyle-plugin:2.15:check (checkstyle-check) @ maven-ear-plugin ---
[INFO] There are 3 errors reported by Checkstyle 6.1.1 with config/maven_checks.xml ruleset.
[INFO] Ignored 3 errors, 0 violation remaining.
[INFO]
[INFO] --- maven-invoker-plugin:2.0.0:verify (integration-test) @ maven-ear-plugin ---
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 16, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO]
[INFO] --- maven-failsafe-plugin:2.19.1:verify (default) @ maven-ear-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:54 min
[INFO] Finished at: 2016-12-14T09:33:58+01:00
[INFO] Final Memory: 46M/813M
[INFO] ------------------------------------------------------------------------

Did you use the patch attached to JIRA I originally build for SVN? This one does not contain the jar, but the jar is attached to JIRA issue as additional file.

No, I used this pull request as patch file. I just took the JAR file attached to the JIRA issue and the IT passes correctly, yes. Thanks for the PR! Committed in r1774310.


[0.10.0-beta1] : debian jessie package: systemd unit file removed on upgrade

Hi,
I have upgrade from 0.9.6 to 0.10.0-beta1, and the influxdb.service systemd unit file has been removed.
The problem seem to be in postinst script
elif [[ -f /etc/lsb-release ]]; then
# Debian/Ubuntu logic
I don't have any /etc/lsb-release file on my debian jessie.
I think it's only available on ubuntu.
I could be better to use /etc/debian_version to test if it's  debian/ubuntu
Hi,
I have upgrade from 0.9.6 to 0.10.0-beta1, and the influxdb.service systemd unit file has been removed.
The problem seem to be in postinst script
elif [[ -f /etc/lsb-release ]]; then
# Debian/Ubuntu logic
I don't have any /etc/lsb-release file on my debian jessie.
I think it's only available on ubuntu.
I could be better to use /etc/debian_version to test if it's  debian/ubuntu

Fixed with #5357


AWS ssm - don't treat "ParameterNotFound" as a fatal error

This PR checks the SSM response error string for "ParameterNotFound" and, if found, ignores the error.  Had I been more proficient at golang, I might have checked something more substantial like a status code.
This is in an effort to fix https://github.com/kelseyhightower/confd/issues/606.

@gdw2 I've simplified the error checking. Please, take a look.

@okushchenko , beautiful.  I need to learn go.

@okushchenko I was attempting to test this, and the strings.Contains() version of checking seemed to work, while the err.Error() version did not. Could this be because the error includes the name of the parameter it failed on, so will never equal ssm.ErrCodeParameterNotFound?

ssm.ErrCodeParameterNotFound is of Type Error. This needs to be:
err != ssm.ErrCodeParameterNotFound
Anthony Black<EMAIL_ADDRESS>schrieb am Mo., 18. Dez. 2017,
17:30:

@okushchenko https://github.com/okushchenko I was attempting to test
this, and the strings.Contains() version of checking seemed to work, while
the err.Error() version did not. Could this be because the error includes
the name of the parameter it failed on, so will never equal
ssm.ErrCodeParameterNotFound?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kelseyhightower/confd/pull/639#issuecomment-352479243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQFc8x5tB-e1ylF7OwZmkkRg_qo5CH91ks5tBpMQgaJpZM4Q9-Xl
.

Oh it's not, sorry.
Rene Kaufmann<EMAIL_ADDRESS>schrieb am Mo., 18. Dez. 2017, 17:49:

ssm.ErrCodeParameterNotFound is of Type Error. This needs to be:
err != ssm.ErrCodeParameterNotFound
Anthony Black<EMAIL_ADDRESS>schrieb am Mo., 18. Dez. 2017,
17:30:

@okushchenko https://github.com/okushchenko I was attempting to test
this, and the strings.Contains() version of checking seemed to work, while
the err.Error() version did not. Could this be because the error includes
the name of the parameter it failed on, so will never equal
ssm.ErrCodeParameterNotFound?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kelseyhightower/confd/pull/639#issuecomment-352479243,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQFc8x5tB-e1ylF7OwZmkkRg_qo5CH91ks5tBpMQgaJpZM4Q9-Xl
.

It looks like aws-go-sdk has a special type for errors. Fixed in #647
@BlackAR @HeavyHorst fyi


Back to CocoaPods

This change removes the embedded Branch iOS SDK from this package. The iOS SDK must now be taken from CocoaPods. To convert a pure React Native app built with react-native link:

Add a Podfile to your project under the ios subdirectory if you don't already have one. It should have these contents:platform :ios, "9.0"
use_frameworks!
pod "Branch", "0.26.0"
target "MyApp"

Use the name of your app target instead of MyApp. The use_frameworks! directive is optional but recommended.
Your deploy target in the platform directive may vary.
If you already have a Podfile, add:pod "Branch", "0.26.0"

After modifying your Podfile, run pod install --repo-update. [TODO: Should this be pod update in some cases?]
If you have just added the Podfile to your project, a new workspace will be created called MyApp.xcworkspace (assuming MyApp.xcodeproj). From now on, open the workspace instead of the project to build your app.

If you have a native iOS app that includes a RN component using this SDK, remove pod "Branch-SDK" from your Podfile and run pod install.
If you are using the react-native-branch-segment pod, replace it with react-native-branch in your Podfile and run pod install.
Notes:

The use_frameworks! directive is recommended but optional. The RNBranch.xcodeproj has both a Framework Search Path and a Header Search Path to pick up Branch imports. We don't want to impose this choice on Partners. We have to support both options.
This has been tested with Xcode 10.2.
The webview_example_native_ios app is throwing a runtime exception from JS. This will be fixed.
All example apps udpated to RN 0.59.3 or 0.59.4 and React 16.8.3. Both testbed_native_ios and webview_example_native_ios have been updated to RN 0.59.3, React 16.8.3. The pure RN apps and testbed_native_android should also be updated.
The Branch SDK is required in the react-native-branch.podspec using ~> 0.26.0. This pins the minor version but allows patch updates. Is this best? 0.26.0. This pins to a specific release.
All iOS example apps have been updated. Some have use_frameworks!. Some do not.
The webview_tutorial needs to be updated (docs only).
The Fastlane automation that updated the embedded SDK needs to be updated to modify the podspec and the MINIMUM_BRANCH_SDK_VERSION REQUIRED_BRANCH_SDK_VERSION. This is not much work.
Apologies to @echo-branch for the huge PR. Most of the changes are automated from CocoaPods. I'll highlight key changes with line comments.
This package will perform runtime validation of the native iOS SDK version. This is the only way to ensure the correct version is present with pure RN apps. If the minimum SDK version is not met, an error is logged. This is visible as an overlay in the app in dev mode at least. The current minimum is 0.26.0. This screenshot was generated by increasing the required minimum to 0.26.1, which does not yet exist in CocoaPods.

Looks good!  Lets update docs to say just use yarn.


relativePath default groovy method

Simple but useful method inspired by GFileUtils from Gradle build system ( https://github.com/gradle/gradle/blob/5f98c7d9e52033d9eb32b635d7edc60319a363ba/subprojects/core/src/main/groovy/org/gradle/util/GFileUtils.java#L236 )

Um... Er..... similarly to another methods :D Should I remove it at all?

Pushed new version without deprecated method (+ with tests)

New version without Ant dependency (Implementation was borrowed from Ant's FileUtils since it's pretty good and clean)

+1

Is there a releated JIRA ticket? (Useful for release notes)

Nope. I can create one if you want

Sure, thank you!

https://jira.codehaus.org/browse/GROOVY-7313
done


Added 5720A model

Adding the model 5720A with the capability for changing the output and read it

Adding the 5720A with the capability to change values.


Charges.create method does not support statement_descriptor parameter

Platforms can set the statement descriptor dynamically to update what appears on the customer’s account statement on each charge request via the statement_descriptor parameter, which pinax-stripe doesn't currently support.
charge = stripe.Charge.create(
  amount=1000,
  currency="usd",
  source="tok_visa",
  statement_descriptor="Custom descriptor",
  stripe_account="{CONNECTED_STRIPE_ACCOUNT_ID}",
)

ref: https://stripe.com/docs/connect/statement-descriptors

Please consider creating a PR.
(As for when idempotency_key was added, I've thought already that pinax-stripe's actions should support and pass through un-handled kwargs to the stripe-python method.)


kvstore: Fix event watcher serialization

When using the watcher in log messages with JSON-based logging, logrus
would give up on trying to generate the log message and print this to
the logs instead:
Failed to obtain reader, failed to marshal fields to JSON, json:
unsupported type: kvstore.EventChan

Fix it by fixing the JSON serialization tags to the structure to avoid
serializing fields that don't make sense to be serialized, and to export
the fields that do make sense to be serialized.
Manually tested by applying this diff:
diff --git a/pkg/kvstore/base_test.go b/pkg/kvstore/base_test.go
index e9ee7da296bf..eb5a3548039b 100644
--- a/pkg/kvstore/base_test.go
+++ b/pkg/kvstore/base_test.go
@@ -292,3 +292,10 @@ func (s *BaseTests) TestListAndWatch(c *C) {

        w.Stop()
 }
+
+func (s *BaseTests) TestFoo(c *C) {
+       w := ListAndWatch(context.TODO(), "testWatcher2", "foo2/", 100)
+       c.Assert(c, Not(IsNil))
+
+       log.WithField(fieldWatcher, w).Fatal("Stopped watcher")
+}
diff --git a/pkg/logging/logging.go b/pkg/logging/logging.go
index 9989e8db0280..6a651c0c87f4 100644
--- a/pkg/logging/logging.go
+++ b/pkg/logging/logging.go
@@ -50,7 +50,7 @@ const (

        // DefaultLogFormat is the string representation of the default logrus.Formatter
        // we want to use (possible values: text or json)
-       DefaultLogFormat LogFormat = LogFormatText
+       DefaultLogFormat LogFormat = LogFormatJSON
 )

 var (

Fixes: #14028

test-me-please

retest-gke

retest-gke

I don't see a way that the GKE build could fail while the others are all successful, so given the problems with running GKE CI runs right now I think it's reasonable to bypass that check and merge.

retest-gke

GKE Failed again, and it definitely looks unrelated.
===================== Exiting AfterFailed =====================
15:24:30 STEP: Running AfterEach for block EntireTestsuite K8sServicesTest
FAIL: terminating containers are not deleted after timeout
Expected
    <*errors.errorString | 0xc0004bdd40>: {
        s: "Pods are still not deleted after a timeout: 4m0s timeout expired",
    }
to be nil
15:28:30 STEP: Running AfterEach for block EntireTestsuite


Dynamiclly hide/show template

[ ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[X] support request

Current behavior
I have created a custom type of tabs, I need to have the ability to hide/disable a tab when value X in the model changes.
Currently, the model value is dynamic and I can use that, however, I want the value to be part of the field options so this feature becomes generic.
The value I'm passing to the type now doesn't reflect the changes in the model, it always the inial value
Minimal reproduction of the problem with instructions
this is one of the ways I tried but hideIt always has the inial value when checking what is inside this.to
label: 'Infection details',
              templateOptions: {
                hideIt: this.model.impact != 2,
              },

What is the motivation / use case for changing the behavior?
A generic solution to hide/show tabs dynamically, the reason I don't want to implement the role inside the type itself so I can keep it generic because I have many roles like this :\

Angular version: 8.0
Browser: [Chrome]
Language: [TypeScript]

use hideExpression: https://ngx-formly.github.io/ngx-formly/examples/field-options/hide-fields

What do you mean? hideExpression doesn't seem to work on the custom template and reading its value myself isn't changing dynamically.
I think this is more of what I need maybe!
https://stackblitz.com/edit/angular-i29psx
I'm not quite clear about what going on there and not sure if I should use it, to simplify what im trying to achive is
stepper/tab custom template with ablity to hide/show the whole step/tab dynamically as values in other steps changes


Error with CMSIS DAP DIY

Hi
I am making a programmer with CH552 and I am testing your great tool but I am have the next error, in openocd work fine, and with pyocd list

the error
➜  ~ pyocd erase -t nrf52840 --chip
0001536:CRITICAL:__main__:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/probe/cmsis_dap_probe.py", line 147, in open
    self._link.open()
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/utility/concurrency.py", line 28, in _locking
    return func(self, *args, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/probe/pydapaccess/dap_access_cmsis_dap.py", line 592, in open
    self._packet_count = self._protocol.dap_info(self.ID.MAX_PACKET_COUNT)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/probe/pydapaccess/cmsis_dap_core.py", line 138, in dap_info
    raise DAPAccessIntf.DeviceError()
pyocd.probe.pydapaccess.dap_access_api.DAPAccessIntf.DeviceError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/__main__.py", line 362, in run
    self._COMMANDS[self._args.cmd](self)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/__main__.py", line 556, in do_erase
    with session:
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/core/session.py", line 302, in __enter__
    self.open()
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/core/session.py", line 416, in open
    self._probe.open()
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/pyocd/probe/cmsis_dap_probe.py", line 167, in open
    six.raise_from(self._convert_exception(exc), exc)
  File "<string>", line 3, in raise_from
pyocd.core.exceptions.ProbeError

Thanks

(Terribly sorry I missed this issue until now!)
The exception that is being raised here is due to the DAP_Info command not returning a valid packet. Specifically, the first byte of the response packet must be the command ID, and this exception is raised because the first byte does not match the DAP_Info command ID.
Bunch of questions:

What host system? (Linux on PC, Windows, Mac, RasPi, etc)
What implementation of CMSIS-DAP is the probe running?
Is it based on the official CMSIS-DAP reference code?
Is the probe firmware open source so I can take a look?

It's going to be very hard to diagnose and fix the issue without very detailed information (i.e. code) about the firmware, and, more importantly, USB bus traces. Do you happen to have a USB bus tracer available? 😀  There are also software solutions for Linux (e.g., usbmon) and Windows (several), but software bus trace is in my experience less reliable and quite limited (since it shows the OS view, not the actual bus view).

Hi @flit
thanks for answering, answering your questions

What host system? (Linux on PC, Windows, Mac, RasPi, etc)
Mac

What implementation of CMSIS-DAP is the probe running?

Is it based on the official CMSIS-DAP reference code?
https://github.com/ElectronicCats/DAP-Cat-Programmer/tree/master/firmware/CMSIS_DAP

Is the probe firmware open source so I can take a look? Yes, and hardware https://github.com/ElectronicCats/DAP-Cat-Programmer


GRSISort tab/space convention

Is there a tab/space convention for GRSISort?  It seems that files are a mix of 3 spaces per indent and 4 spaces per ident, with some files containing spaces and other files containing a mix of tabs and spaces.

At some point  I set my editor to turn tabs into three spaces.  Before that
its was a bit random.  I think we should set it to either three space a
stick with it.  I've been slowly trying to fix the wonky functions as I
come across them.
On Tue, May 26, 2015 at 11:08 AM, gdemand<EMAIL_ADDRESS>wrote:

Is there a tab/space convention for GRSISort? It seems that files are a
mix of 3 spaces per indent and 4 spaces per ident, with some files
containing spaces and other files containing a mix of tabs and spaces.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/342.

I also use three spaces on a tab.

On May 26, 2015, at 12:10 PM, pcbend<EMAIL_ADDRESS>wrote:
At some point I set my editor to turn tabs into three spaces. Before that
its was a bit random. I think we should set it to either three space a
stick with it. I've been slowly trying to fix the wonky functions as I
come across them.
On Tue, May 26, 2015 at 11:08 AM, gdemand<EMAIL_ADDRESS>wrote:

Is there a tab/space convention for GRSISort? It seems that files are a
mix of 3 spaces per indent and 4 spaces per ident, with some files
containing spaces and other files containing a mix of tabs and spaces.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/342.

—
Reply to this email directly or view it on GitHub https://github.com/GRIFFINCollaboration/GRSISort/issues/342#issuecomment-105580701.

I vote for 3 spaces based on what already exists. We can just fix stuff that we come across from this point forward. We can always push those fixes on their own separate "didn't really do anything" commits. I can see the merit to having actual tabs, but then everyone has to use tabs as well or it turns into a big mess in some editors.

This also might be a good time to say we should use root naming conventions in stuff we add (and fix stuff if we get around to it). ie

we should use the prefix f on member variables
Each word in a function name starts with a capital unless it's two capitals back to back GetPosition() vs GetXaxis().

I'd prefer tabs, since it's makes it faster to navigate through code, but it's probably best to keep it how it currently is (unless we an use an existing script to convert spaces to tabs and we can commit this to the repository silently without having every line be flagged as changed).

@gdemand , I think the issues you're seeing are that your editor interprets tabs as four spaces, not three. That's what makes the indentations look weird. If you change your editor to interpret tabs as three spaces it shouldn't make any difference whether it's actual spaces or tabs in the file (apart from navigation).

@VinzenzBildstein There are definitely files with non standard tabbing.(example MakeTimeDiffSpec.C has a number of two space indents and mixed tabs and spaces).
In editors that auto indent new lines, when you move code between lines the editor will sometimes change tabs to spaces, which counts as a diff for git, even though the code looks the same.

Because editors are open to interprete tabs as they want, I think we should
not use them.  Instead set a standard, every time one  would use a tab, us
three spaces instead.  Most editors (emacs/vim//gedit) have this as an
option, pushing the tab button literally replaces the tab with x number of
spaces. This keeps tabs out of the code all together.  Than independent of
how one has the viewer set up the code appears the same.  This is the way I
vote to continue moving.
On May 26, 2015 11:57 AM, "gdemand"<EMAIL_ADDRESS>wrote:

@VinzenzBildstein https://github.com/VinzenzBildstein There are
definitely files with non standard tabbing.(example MakeTimeDiffSpec.C has
a number of two space indents and mixed tabs and spaces).
In editors that auto indent new lines, when you move code between lines
the editor will sometimes change tabs to spaces, which counts as a diff for
git, even though the code looks the same.
—
Reply to this email directly or view it on GitHub
https://github.com/GRIFFINCollaboration/GRSISort/issues/342#issuecomment-105602086
.


App is not "force-started" in Android 10

Hello,
first of all, thank you so much guys for your invaluable help regarding this plugin. Hope you could shed some light on my issue.
I´ve been using my app in several devices, most of them Android 8 and Android 9 with no major issues. But now, my One Plus 6T device (now with android 10, layer OxygenOS 10.3.0) behaves different when a push notification arrives.
Expected Behaviour
I need to open the app with no user interaction, no need to put it in foreground, but I need it to run the onNotification event.
What always happended, with Android 9, was that when the push notification arrived the device, the app was opened and brought to foreground, regardless it was in background or dead. The onNotification event was then properly triggered.
Actual Behaviour
But since the last update to Android 10, the notification does arrive the device, but no app is launched and no "onNotification" event is triggered.
I don´t know yet if the problem is in the plugin, in the sintax of my notification (most likely), or a bug in Android 10, but have some of you guys experienced something similar?
I´m using the following sintax for the notifications. As far as I know, "content-available" and "force-start" tags are the one responsible for opening the app:
{"registration_ids":["..xxxx..."],
"data":{"visibility":"-1","content-available": 1, "force-start": 1, "priority": 2, "message": "msgTest", "notId": "24", "title": "titleTest"},
"priority":"high" }
Also, looking at the logcat, all traces enabled, what I see in the Android 10 device, is:
...
D/Push_FCMService: contentAvailable =[1]
D/Push_FCMService: forceStart =[1]
D/Push_FCMService: create notification
D/Push_FCMService: Using channel ID = PushPluginChannel
D/Push_FCMService: stored icon=null
D/Push_FCMService: stored iconColor=null
D/Push_FCMService: stored sound=true
D/Push_FCMService: stored vibrate=true
D/Push_FCMService: no icon resource found - using application icon
D/Push_FCMService: create actions: with in-line
D/Push_FCMService: app is not running but we should start it and put in background  (This is the last trace!)
What I see in a similar device with Android 9 is:
...
D/Push_FCMService: stored sound=true
D/Push_FCMService: stored vibrate=true
D/Push_FCMService: no icon resource found - using application icon
D/Push_FCMService: create actions: with in-line
D/Push_FCMService: app is not running but we should start it and put in background
W/ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@2f58d4
D/ZrHung.AppEyeUiProbe: notify runnable to start.
D/ZrHung.AppEyeUiProbe: Runnable thread started.
D/IMonitor: Load library imonitor_jni
W/ZrHung.AppEyeUiProbe: Failed to get config from zrhung
V/ActivityThread: Skipping new config:{1.0 214mcc21mnc [es_ES] ldltr sw423dp w423dp h807dp 408dpi nrml long hdr port finger -keyb/v/h -nav/h winConfig={ mBounds=Rect(0, 0 - 0, 0) mAppBounds=Rect(0, 90 - 1080, 2150) mWindowingMode=fullscreen mActivityType=undefined} nonFullScreen=0 suim:1 s.13}, config:{1.0 214mcc21mnc [es_ES] ldltr sw423dp w423dp h807dp 408dpi nrml long hdr port finger -keyb/v/h -nav/h winConfig={ mBounds=Rect(0, 0 - 0, 0) mAppBounds=Rect(0, 90 - 1080, 2150) mWindowingMode=fullscreen mActivityType=undefined} nonFullScreen=0 suim:1 s.13} for app:com.qvadis.app
V/HwPolicyFactory: : success to get AllImpl object and return....
V/ActivityThread: callActivityOnCreate
D/Push_HandlerActivity: not id = 0
V/Push_HandlerActivity: onCreate
D/Push_HandlerActivity: callback = null
D/Push_HandlerActivity: dismissed = false
... more traces below ...
I´m sending the same notification to both devices (regId changes obviously).
Version used:

cordova --version 9.0.0
phonegap-plugin-push 2.3.0

Any feedback will be really appreciated. Thanks so much in advance.
Cheers

Same problem here! Any updates on this?

I've noticed the same thing as well, except I'm seeing it on Android 9.  Some tests in prior versions work as they should.
cordova --version 9.0.0
android 8.1.0
phonegap-plugin-push 2.3.0

Uh, that's weird. Did you check your permissions in the device configuration? @kd8ssq

I've noticed the same thing as well, except I'm seeing it on Android 9. Some tests in prior versions work as they should.
cordova --version 9.0.0
android 8.1.0
phonegap-plugin-push 2.3.0

Looks like my issue is different.  I'm not passing the force-start variable.  I can see through the inspector and logs that the on notification function is being triggered, but when you click on the notification in the shade, the app doesn't open.

If you do not pass the "force-start" flag in the push notification, the app does not wake up, at least for Android<10.
What I´ve noticed is that this flag seems to be ignored in Android 10.
Do you know any other way to execute the code in the "onNotification" event when the app is in background or dead?
According to the Android10 new policies (https://developer.android.com/guide/components/activities/background-starts), it seems this push pluging may not be handling the flow properly, but i´m not expert enough to identify where.
Actually, something similar happens in iOS13, and the new VoIP restrictions.

Most of my testing was done in Android 9 and I was still having the same issues.  I did discover that I had to change the launchMode to SingleTop because another plugin (branch) was overriding it.  Of course even after fixing that, it seems like it's a toss up as to whether or not the app will open when you click on the notification shade.  I don't see any patterns in when it works vs when it doesn't.   Even in my Android 10 testing, I'm getting the same results.

Besides "force-start" flag enabled, you must also require the SYSTEM_ALERT_WINDOW permission in the AndroidManifest, and grant the permission "Draw over other apps" in the device.