[PE-D][Tester A] Copying tags to the clipboard gives undesirable Output

Steps to reproduce:
1.Right click copy tag for a review or stall that has two tags

Ctrl + V to paste the tags in command box.

The tags will be appeared in the form of array which I feel that it shouldn't be the correct form of display, when a user really wants to copy this detail to somewhere else they will not want to include the square brackets around the tags. My suggestion is to remove the square bracket around the tags.

Labels: type.FeatureFlaw severity.Medium
original: NUSDG/ped#1

Thank you for the suggestion. This has been fixed in 1.3.1 which was not released for testing.


Example installs the deprecated cluster.exe command

not sure why it is in the example, and don't see any need for it in any of the code.

Simply remove the RSAT-Clustering-CmdInterface resource from the example code.  Works fine without it.
    WindowsFeature RSATClusteringCmdInterface
    {
        Ensure = "Present"
        Name   = "RSAT-Clustering-CmdInterface"

        DependsOn = "[WindowsFeature]RSATClusteringPowerShell"
    }


Add Dockerfile for Azure

@andrenarchy If you are interested in supporting Azure as a new flavor, could you please review/merge this PR when you get a chance?
Thanks!


Code review: Report timeout problems, and fix retries

This sends an email whenever a level doesn't load within 30sec, or if the supermodel fails.
It also fixes the retry logic so it does actually retry. Before the @model.loading flag was preventing it from sending another request.

Since the retry logic only happens sometimes, and it was apparently buggy, and it's used in key places, this code should be tested. Jasmine provides a clock you can manipulate, so you could give a SuperModel a resource to load, tick the clock manually, then assert that it created another request.

Checking out the logs on Travis, looks like the retry logic is firing when tests generate requests but do not fulfill them. Should figure out a way to clear them after each test. One possibility: when testing, keep an array of created timeouts on the SuperModel and clear them afterEach test.

I saw another sometimes-error on another RequestQuoteView test that uses _.defer to wait for the SuperModel to load. I changed the code for both those tests so if you pull that in, Travis should (hopefully) consistently pass those tests now.


Additional Data in Marker

Is this possible? I want to add ID in the marker..

Haven't thought about this before but it seems you could:
https://stackoverflow.com/questions/11378450/google-map-api-v3-how-to-add-custom-data-to-markers

i tried but it didn't worked

Can you share an example of what you're trying to achieve? Hard to imagine what's not working exactly.
You can use https://vite.new/vue

Closing due to inactivity


Adding NODE_PATH to start script so paths resolve properly

Change Description
Paths weren't being resolved properly; we must have broken this in a recent merge..
API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Ahhh, right, the consequence of dealing with 16 repos in parallel... ok, I switched this to check for .env and copy it if it's not there.


make the union conditions sort stable

We union conditions, but we forgot to sort the constituent conditions to have a stable message.  This causes lots of extra updates.

/cherry-pick release-4.7

/cherrypick release-4.6

/cherry-pick release-4.5


Python Requirements Update

Python requirements update. Please review the changelogs for the upgraded packages.
Deleted obsolete pull_requests:
https://github.com/zubairshakoorarbisoft/edx-repo-health/pull/13

List of packages in the PR without any issue.

asgiref changes from 3.5.2 to 3.6.0
attrs changes from 22.1.0 to 22.2.0
certifi changes from 2022.9.24 to 2022.12.7
diff-cover changes from 7.2.0 to 7.3.0
exceptiongroup changes from 1.0.4 to 1.1.0
google-auth-oauthlib changes from 0.7.1 to 0.8.0
importlib-metadata changes from 5.1.0 to 5.2.0
isort changes from 5.10.1 to 5.11.4
pip-tools changes from 6.11.0 to 6.12.1
pylint changes from 2.15.8 to 2.15.9
pytest-asyncio changes from 0.20.2 to 0.20.3
pytz changes from 2022.6 to 2022.7
tox changes from 3.27.1 to 3.28.0

These Packages need manual review..

[MAJOR] coverage changes from 6.5.0 to 7.0.0
[MAJOR] coverage[toml] changes from 6.5.0 to 7.0.0
[MAJOR] packaging changes from 21.3 to 22.0
[REMOVED] pyparsing (3.0.9) removed from the requirements

Closing obsolete PR.


Dark mode blur?

Maybe someday, but not something I have time to work on right now.

Hi, is it still an issue? can i contribute?


RISC-V compliance mtvec alignment

Follow-up for PR #427 and in connection to #100
The current RISC-V compliance test places a trap handler at non 256-byte aligned position and uses this as a target for mtvec.
Ibex requires that the mtvec value is 256-byte aligned.
RISC-V Privileged Spec:

If mtvec is writable, the set of values the register may hold can vary by implementation. The value in the BASE field must always be aligned on a 4-byte boundary, and the MODE setting may impose additional alignment constraints on the value in the BASE field.

An implementation may have different alignment constraints for different modes. In particular,
MODE=Vectored may have stricter alignment constraints than MODE=Direct.

Allowing coarser alignments in Vectored mode enables vectoring to be implemented without a
hardware adder circuit.

@vogelpi mentioned in #427 that this should be fixed upstream.
The purpose of this issue is make the problem visible and to discuss the correct solution.

Thanks @towoe for creating this issue :+1:

This has also been mentioned as part of another discussion here: #99 (comment)

Ah thanks! The reference/title did not show that this discussion was already happening.
Best place for the issue would then be riscv-compliance to have the best visibility.

@towoe, @vogelpi: As far as I understand the linked issues and discussion, this is a problem with riscv-compliance requiring something stronger than what is required in the spec. (Is that right?)
I think we're not planning to change our mtvec alignment requirement, so should we just close this (and track any waivers needed as part of #100)?

@towoe, @vogelpi: As far as I understand the linked issues and discussion, this is a problem with riscv-compliance requiring something stronger than what is required in the spec. (Is that right?)
I think we're not planning to change our mtvec alignment requirement, so should we just close this (and track any waivers needed as part of #100)?

Hey Rupert,
I lost a bit track of this. Thanks for pinging me.
I think you got it right. However, it seems that riscv-compliance very recently modified the behavior of the corresponding test (see https://github.com/riscv/riscv-compliance/issues/72#issuecomment-747072591) in a way that should allow Ibex to pass if the default mtvec doesn't point to ROM. Checking the Ibex riscv-compliance "wrapper" https://github.com/lowRISC/ibex/tree/master/dv/riscv_compliance it seems the default mtvec points to RAM, so the test should pass now.
However, I don't know which version of the compliance suite we usually run/is run in CI. I should probably check that.

Hey Rupert,
I lost a bit track of this. Thanks for pinging me.
I think you got it right. However, it seems that riscv-compliance very recently modified the behavior of the corresponding test (see https://github.com/riscv/riscv-compliance/issues/72#issuecomment-747072591) in a way that should allow Ibex to pass if the default mtvec doesn't point to ROM. Checking the Ibex riscv-compliance "wrapper" https://github.com/lowRISC/ibex/tree/master/dv/riscv_compliance it seems the default mtvec points to RAM, so the test should pass now.
However, I don't know which version of the compliance suite we usually run/is run in CI. I should probably check that.

There are still problems with riscv-compliance and mtvec as mentioned for example in https://github.com/riscv/riscv-compliance/issues/145
But this is an issue with the compliance framework so yes, I agree that this issue can be closed and we use the tracking issue for this.

There are still problems with riscv-compliance and mtvec as mentioned for example in https://github.com/riscv/riscv-compliance/issues/145
But this is an issue with the compliance framework so yes, I agree that this issue can be closed and we use the tracking issue for this.


license added

I have added the MIT license (http://choosealicense.org) to the project (cf. #74), using the name "The GLENCO team".

Maybe you should put actual names.

I added the names as they appear on the article.


Question: Add support for std::byte

Hello,
Since new cppwinrt relies on C++17 and STL now includes the std::byte implementation it immediately caused conflicts with SDK rpcndr.h that uses byte typedef in global scope. It was good excuse to try (again) convert code from uint8_t to std::byte. Once all user code is converted the interaction with cppwinrt is awkward, since arary_view<T> wrappers expect containers of uint8_t, and there is no straight conversion from/to std::byte. The only way to pass vector<std::byte> to API is to use array_view constructor with start/end pointer args and to explicitly cast pointers:
    const std::vector<std::byte> buffer = cmdSelect.GetBuffer();
    auto cmdSelectBuffer = CryptographicBuffer::CreateFromByteArray({
            reinterpret_cast<const uint8_t*>(buffer.data()),
            reinterpret_cast<const uint8_t*>(buffer.data() + buffer.size())
        });

I would like to know what approach will you choose in future in cppwinrt to provide transparent conversion from c++ containers containing std::byte and ABI layer expecting buffers of "unsigned char"?
Do you think conversion  between these buffers should be automatic or user must explicitly call some conversion function?

I've experimented with providing alternative constructors to array_view<T> that allow to completely transparently pass any container of std::byte to array_view (my template-fu was not enough to make initializer_list work as I wanted). It worked fine for my test program, but probably there are many other scenarios that I am not aware of. Not yet sure whether same changes required to com_ptr<T> as well.
See my std::byte aware array_view<T>:
https://gist.github.com/jonitis/797712c7b8c61fb29cc9f06e675f1fff
Thanks in advance

Thanks for the suggestion. We are evaluating whether to support std::byte directly. Although I like the functionality of std::byte, I am of the opinion that it was very poorly named. Given that Windows has included a type alias called byte for time immemorial (at least as far back as the Windows NT 4 SDK, but likely much earlier), following the convention of the fixed width integer types (such as byte_t) might have been a more practical choice to encourage wide adoption.

We are unlikely to make such a change at this stage due to compatibility with existing code that uses both the Windows SDK and the C++ standard library. There are efforts to modernize the Windows SDK, but that's another matter. There's also nothing wrong with using uint8_t. Keep in mind that while we require a C++17 compiler and embrace much of modern C++, we are under no obligation to embrace all of it. For example, there's no value in us using std::future, std::function or std::shared_ptr since we have alternatives that are more suitable to WinRT.

Thank you for clarification.


Add language for council membership exit ramps

cc @pangeo-data/steering-council

Any idea why this has a merge conflict? So annoying.

So the PR was merged! https://github.com/pangeo-data/governance/commit/97146212612be9e6db8eacb229f642860e9e70aa
But for some reason this PR doesn't seem to know about this. GitHub glitch?


Conflicting C416 and C400 rule

Python Version
3.9.12
flake8 Version
5.0.4
Package Version
3.10.0
Description
Reproduction:
from datetime import date

from dateutil.rrule import MONTHLY, rrule

# Unnecessary list comprehension - rewrite using list(). flake8(C416)
datetimes = [dt for dt in rrule(MONTHLY, dtstart=date(2001, 1, 1), until=date(2005, 1, 1))]

# Unnecessary generator - rewrite as a list comprehension. flake8(C400)
datetimes = list(dt for dt in rrule(MONTHLY, dtstart=date(2001, 1, 1), until=date(2005, 1, 1)))

The way C416 wants you to rewrite it is:
datetimes = list(rrule(MONTHLY, dtstart=date(2001, 1, 1), until=date(2005, 1, 1)))

not with a generator.
If you think the docs could be improved, please make a suggestion!

The way C416 wants you to rewrite it is:
datetimes = list(rrule(MONTHLY, dtstart=date(2001, 1, 1), until=date(2005, 1, 1)))

not with a generator.
If you think the docs could be improved, please make a suggestion!

Makes sense, thank you!


Pinot Controller leader re-election not triggered

We faced an issue in production wherein the controller leader node went down but re-election was not triggered. This lead to segment upload errors for tables trying to commit a segment, instances being marked as unavailable for the segment and finally queries failing for the tables with segments unavailable error.
Pinot version - 1.0.x
Timeline for this was as follows:

A GET call for a large table's segments' metadata tables/<tablename>/segments/<segmentName>/metadata?columns=* spawns ~75k threads. This cause a huge memory spike and heap to go out of memory (heap size being 128GB here), maybe crashing the node. We suspect it was because of reload status button which triggers the segment metadata call

The node's 2 zk sessions time out at 17:19:56, the node tries to reestablish connection but it keeps emitting metrics as a leader until 17:29:x

The health check for node starts failing around 17:20:x, but standby controller nodes keep polling and getting failed leader's session ID as leader until 18:10 when we triggered a force replacement of error node

Instance 123 is not leader of cluster production-cluster due to current session<PHONE_NUMBER>90178 does not match leader session<PHONE_NUMBER>90171

Ideally the re-election should've triggered around 17:20.

Controller leader election is managed by Helix, so you might get more help posting this to Apache Helix project.
On Pinot side, we should triage why a metadata fetch call can spawn 75k threads. It doesn't look correct to me

On Pinot side, we should triage why a metadata fetch call can spawn 75k threads. It doesn't look correct to me

Yes we were able to find the root cause for this. We spawn one thread per segment in case of server-metadata fetch. Ref: https://github.com/apache/pinot/blob/266073eee0a56ae811c65cb0828cff294212aa48/pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java#L185-L194
Ideally we can do one call per server rather than one call per segment.
Plus we also use an unbounded thread pool for submitting these calls per segment causing 75k threads to spawn: https://github.com/apache/pinot/blob/266073eee0a56ae811c65cb0828cff294212aa48/pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java#L254-L255
We can limit the number of threads in this pool to something reasonable.
I think what we are interested to know more is why didn't leader-election kick off even when zk-client session was lost. We will raise an issue in Helix and link it here. Thanks!

We'll address the above issues:

[ ] Reduce the threads spawned in API from no of segments to no of servers
[ ] Use a fixed thread pool
[ ] Explore Reload Status UI button. It shouldn't trigger the call for both reloadStatusOp and fetchTableJobs when only checking list of jobs


[Bug] : Improve alignment of top bar labels , text hover effect #273

Overview
This Pull Request addresses issue #273. It includes improvements to the alignment of top bar labels and introduces text hover effect on tabs.
Details

Fixed the alignment issues with top bar labels to ensure they are properly positioned , add text hover effect on tabs.

What is the purpose of this pull request?

[ ] New feature
[ ] Documentation update
[x] Bug fix
[ ] Refactor
[ ] Release
[ ] Other: Spelling corrections

Looks great to me, awesome work @Sai-Manikanta-Andey @drfarrell !


new term: intestinal fistula

closes #5543

from Peter's comment on the issue, this term is a phenotype not a disease. Closing this PR.


cassandra: add more comments in the schema

This change is

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[prometheus_sd/kubernetes]add new node address types for discover

Please see here: https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-apiserver/app/options/options.go#L104

@brian-Brazil. Requesting your review

Review comments addressed.

lgtm :+1: leaving last call up to @brian-brazil

You've got a stray file here.

Thanks for catching that @brian-brazil!

Thanks!


Plists generated via service blocks are broken

Describe the bug
The service plists are broken since they get generated via service blocks.
PHP versions
All of them, but I'll focus on 8.0 in this bug report.
To Reproduce
brew install<EMAIL_ADDRESS>brew services start shivammathur/php/php

Expected behavior
~/Library/LaunchAgents/homebrew.mxcl.php.plist looks like this:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict>
    <key>KeepAlive</key>
    <true/>
    <key>Label</key>
    <string>homebrew.mxcl.php</string>
    <key>ProgramArguments</key>
    <array>
      <string>/opt/homebrew/opt/php/sbin/php-fpm</string>
      <string>--nodaemonize</string>
    </array>
    <key>RunAtLoad</key>
    <true/>
    <key>WorkingDirectory</key>
    <string>/opt/homebrew/var</string>
    <key>StandardErrorPath</key>
    <string>/opt/homebrew/var/log/php-fpm.log</string>
  </dict>
</plist>

Notice how ProgramArguments is an array and includes --nodaemonize.
Screenshots/Logs
Since the recent change to generate plists via service blocks the generated plist looks like this:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>KeepAlive</key>
	<true/>
	<key>Label</key>
	<string>homebrew.mxcl.php</string>
	<key>ProgramArguments</key>
	<string>/opt/homebrew/opt/php/sbin/php-fpm</string>
	<key>RunAtLoad</key>
	<true/>
	<key>StandardErrorPath</key>
	<string>/opt/homebrew/var/log/php-fpm.log</string>
	<key>WorkingDirectory</key>
	<string>/opt/homebrew/var</string>
</dict>
</plist>

No ProgramArguments array, no --nodaemonize. Starting the service fails:
brew services start shivammathur/php/php
Bootstrap failed: 5: Input/output error
Error: Failure while executing; `/bin/launchctl bootstrap gui/501 /Users/nikolas/Library/LaunchAgents/homebrew.mxcl.php.plist` exited with 5.

Additional context

Suspected commit
service do DSL PR
Similar issue (presumably)

brew config:
HOMEBREW_VERSION: 3.1.4-24-g8d35744
ORIGIN: https://github.com/Homebrew/brew
HEAD: 8d3574458178bf1594475444986b44171a7c527e
Last commit: 2 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 99a41050d89b6983a9f5aa310cf79a0f7218b568
Core tap last commit: 2 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 12.0 build 1205
Git: 2.31.1 => /opt/homebrew/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.2.3-arm64
CLT: <IP_ADDRESS>.1.1617976050
Xcode: N/A
Rosetta 2: false

Are you willing to submit a PR?
Sure.

@vintagesucks
I have reverted https://github.com/shivammathur/homebrew-php/commit/919b5af50859a0377cda4d11274dd01d22336fbf till there is a fix upstream.

Reverted to fix my issue here

@asentner No I reverted the change in this tap, httpd in the core tap will be fixed once https://github.com/Homebrew/brew/pull/11279 gets merged.

Fixed upstream. Reverted the revert 😅

Hi,
I came across the same problem when running brew services start<EMAIL_ADDRESS>Try re-running the command as root for richer errors.
Error: Failure while executing; `/bin/launchctl bootstrap gui/502<EMAIL_ADDRESS>exited with 5.

plist looks like this:
	<array>
<EMAIL_ADDRESS>		<string>--nodaemonize</string>
	</array>


Text lists classes

Closes #1 — DefaultEmbed must be used instead.
Closes #2 — Two classes for generating bulleted and ordered lists.
OrderedList usage:
let list = new OrderedList();
list.startingPoint = 1;
list.push("Item");
list.push("Another item");
list.toString();
// `1.` Item\n
// `2.` Another item

BulletedList usage similar with OrderedList (both classes extends default Array), but there is no starting point. To set different marker, just change BulletedList.marker.
let list = new BulletedList();
list.marker = "-";
// etc...

This PR also contains tiny change in AboutCommand — somehow I missed up that there no resolveLang for embed.


Documentation GitHub workflow failing

What's the problem?
The build is generating the warning
pickling environment... WARNING: cannot cache unpickable configuration value: 'typehints_formatter'

This is only a warning so the build does succeed but the GitHub workflow fails as we've got it set to fail on warnings.
How can we reproduce the issue?
https://github.com/gchq/coreax/actions/runs/8719140758/job/23917872705
Python version
3.11, 3.12
Package version
0.1.0
Operating system
Linux, Windows
Other packages
Dependency updates that seem to have triggered the issue:
docutils 0.20.1->0.21.1
sphinx 7.2.6->7.3.5
Relevant log output
No response

xref: https://github.com/sphinx-gallery/sphinx-gallery/issues/1286
A


v1.0.9

Add class L10n_mx

Stamp  cfdiv33 foreign trade
Stamp  cfdiv33 payroll
Stamp  cfdiv33 cancel
Stamp  cfdiv33 status


List is blocking legitimate url:api.punchh.com

As discussed on NextDNS Issue #260.
The list is blocking the login url for blazepizza.com

Thanks Luis @luisv5z.
Ping @jawz101 — can you look at this?  Presently 13 punchh.com domains are blocked which indicates to me, punchh.com is unclean.
Luiz @luisv5z it's possible that Blaze Pizza has made some unfortunate choices.  I'm letting the folks at AdAway continue to decide.

@StevenBlack Got it, thanks for checking it out!

geez.  Even going to their website they have a cookie consent box w/ an opt-out checkbox saying "So Not Sell My Personal Information"
I wish I had access to their developer documentation to see what they mean by
Reveal the Anonymous
Get to really know your customers, generating insights from every channel, in-store or online

Punchh Acquire
Supercharge your customer acquisition by optimizing omnichannel marketing and analytics. Easily and cost-effectively turn anonymous consumers into customers – and customers into brand loyalists.

If this does any location or proximity tracking, asks for phone/contacts/sensors/text/etc. permissions that would be my concern.

Yeah, I'm going to stand firm that someone can whitelist this if they want it.  Looking at their privacy policy and the CEO's past experience with location-based stuff, I'm really not interested in allowing it.  These are the sorts of removals that make me lose the reason why I blocked them in the first place.

@jawz101  just FYI:

"So Not Sell My Personal Information"

This only applies to California residents,everyone else is under the knife.

If someone has can tell me that their apps don't have proximity, read cell info or location permissions, clipboard or sensor access I'd remove it.  sensor & clipboard permissions on Android cannot be controlled by the end user w/o something like XPrivacyLUA so I really don't have any way to prove they don't do something I cannot see.

Good call, @jawz101.  Thank you, as always, for taking the time to review this.  Thanks for the comment, Dan @dnmTX.
There you have it, Luis @luisv5z.
Closing.

https://www.fastcasual.com/news/blaze-fast-fired-pizza-partners-with-punchh-for-mobile-app-launch/

Thanks LE @llacb47.
I think I can safely say, people who want to be tracked and sold by a Pizza chain aren't typical of the people we serve, here 😄.

@StevenBlack @jawz101 Guys, thank you so much for this. 🙌🏽
I guess, the more you know...

Well, I'm not one to dismiss them.  Like if all of the marketing is user initiated (Sign up for rewards points!) I'd feel like it's up to the user.
If they were tracking your location, using bluetooth proximity to throw coupons at you when you're near some place, requesting calendar, clipboard, microphone permission, etc.  Or if they sell your data to others.  How do I get that 3rd party twice-removed to delete my data that they got from the first person?  Stuff like that creeps me out and once I see a worse-case scenario I assume everyone does it.
I'd allow them if I knew how their stuff works.  Privacy policies are usually pretty vague on specifics.


GUI: OpenDir fails if oldest or youngest file have no data within filename

Finished with 6a3d4ab11080af05f7b77b923108c07d41945300.
Closing #35


SurrealDB 2 functions are not allowed

SurrealDB 2 has new functions that did not exist before.
When running surrealdb-client-generator in a code with such functions, it fails. As an example, record::id causes an error to be thrown.

Record functions before SurrealDB 2.0 were located inside the module meta. As of version 2.0, these functions are now part of SurrealDB's record functions.

./node_modules/.bin/surql-gen --no-generateClient
No config file found.
Starting temporary SurrealDB instance
Temporary SurrealDB instance started at http://localhost:33789
Connecting to database
Connected to database successfully

🔴 This did not work as expected 🥺
🔴 I am sorry that this happened, and I kindly ask for your help to fix this.
🔴
🔴 Please open an issue here:
🔴 👉 https://github.com/sebastianwessel/surrealdb-client-generator/issues
🔴
🔴 Please copy & paste the following code into the ticket:
=====
ResponseError: There was a problem with the database: Parse error: Failed to parse query at line 109 column 61 expected function arguments
    |
109 | ...ice(record::id($value.id), 0, 4);
    |              ^

    at Surreal.query_raw (/node_modules/.pnpm/surrealdb@1.0.0-beta.21_tslib@2.7.0_typescript@5.6.2_ws@8.18.0_bufferutil@4.0.8_utf-8-validate@6.0.4_/node_modules/surrealdb/dist/index.cjs:1:45589)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Surreal.query (/node_modules/.pnpm/surrealdb@1.0.0-beta.21_tslib@2.7.0_typescript@5.6.2_ws@8.18.0_bufferutil@4.0.8_utf-8-validate@6.0.4_/node_modules/surrealdb/dist/index.cjs:1:45244)
    at async insertDefinitions (/node_modules/.pnpm/@sebastianwessel+surql-gen@2.6.1_tslib@2.7.0_typescript@5.6.2_ws@8.18.0_bufferutil@4.0.8_utf-8-validate@6.0.4_/node_modules/@sebastianwessel/surql-gen/dist/index.js:92:3)
    at async main (/node_modules/.pnpm/@sebastianwessel+surql-gen@2.6.1_tslib@2.7.0_typescript@5.6.2_ws@8.18.0_bufferutil@4.0.8_utf-8-validate@6.0.4_/node_modules/@sebastianwessel/surql-gen/dist/index.js:1006:9)

From first guess, looks like an issue in the surrealdb (client)

@zvictor did you provide a schema file?

of course. the record::id is part of the schema. Once I get back to my computer I will reply with an example schema

of course. the record::id is part of the schema. Once I get back to my computer I will reply with an example schema

Okay, try adding the -i flag with the nightly image surrealdb/surrealdb:nightly see if that fixes the issue for you.

That works! I am sorry I didn't notice the --surrealImage had been added...
Morever, to my surprise, using --surrealImage surrealdb/surrealdb:nightly also gets rid of #63.


Streaming examples?

Would be great to get client streaming, server streaming and bi-di streaming examples if possible? Including how to properly handle cancellation!

In this example the server prints both messages but client only prints the first.
https://github.com/SemanticBeeng/fs2-grpc-example/blob/6bdd633fe10a86e569f5f15745edc976f671a4f8/client/src/main/scala/Main.scala#L24-L26
@fiadliel  please advise if there is a way to write the client to get both server replies using the generated stub.
Will it work using java_runtime.client.Fs2ClientCall and the generated server?

In the for-comprehension:
  _ <- runProgramStream(helloStub)
} yield StreamApp.ExitCode.Success

You are running Stream#flatMap, and yielded the exit code on first reply.

Your server implementation is also confusing, if not buggy.
_ ← sayHello(req, clientHeaders)
_ ← IO(println(s"Pausing a little ..."))
_ ← IO(println(s"Responding to lady $req again"))
_ ← timer.sleep(1 second)
r ← sayHello(req, clientHeaders)

All the first sayHello does is to calculate a response, which you discarded. If you want multiple reply for one incoming message, use flatMap and construct your multiple response stream instead of using evalMap.


ImageDataGenerator fetches ~ ten times more samples than necessary.

System configuration: Running on CPU, Ubuntu 12.04, Theano latest version, Keras updated around Mid-January
I want to use real-time data augmentation and so I started using fit_generator() with ImageDataGenerator object as its generator. According to generator documentation: An epoch finishes when samples_per_epoch samples have been seen by the model. So I wrote my generator as follows (mainly to test it):
# written in such a way that only the mean of the dataset will be subtracted
# from each image and the data itself will not be augmented.

datagen = ImageDataGenerator(
        featurewise_center=True,  # set input mean to 0 over the dataset
        samplewise_center=False,  # set each sample mean to 0
        featurewise_std_normalization=False,  # divide inputs by std of the dataset
        samplewise_std_normalization=False,  # divide each input by its std
        zca_whitening=False,  # apply ZCA whitening
        rotation_range=0,  # randomly rotate images in the range (degrees, 0 to 180)
        width_shift_range=0,  # randomly shift images horizontally (fraction of total width)
        height_shift_range=0,  # randomly shift images vertically (fraction of total height)
        horizontal_flip=False,  # randomly flip images
        vertical_flip=False)  # randomly flip images

    # compute quantities required for featurewise normalization
    # (std, mean, and principal components if ZCA whitening is applied)
    datagen.fit(X_train)

    batch_size=32
    nb_epoch =10

    # fit the model on the batches generated by datagen.flow()
    model.fit_generator(datagen.flow(X_train, Y_train, batch_size=batch_size),
                        samples_per_epoch=batch_size ,
                        nb_epoch=nb_epoch, verbose=2, show_accuracy=True, callbacks = [history],
                        validation_data=(X_test[0:100], Y_test[0:100]),
                        nb_worker=1)

Note that I have purposely set samples_per_epoch = batch_size. So after the generator has yielded one batch, it should start the next epoch. However, it loops over 11 batches to start the next epoch. I know this from the callback I have written as follows:
class LossHistory(callbacks.Callback):
    def on_train_begin(self, logs={}):
        self.losses = []

    def on_epoch_end(self, epoch, logs={}):
        self.losses.append(logs.get('val_loss'))
        logging.info('-----------------------------------------------------------------------')
        logging.info('Epoch ' + str(epoch) + ' - Validation loss: ' + str(logs.get('val_loss')) + ' accuracy : ' + str(logs.get('val_acc')))
        logging.info('-----------------------------------------------------------------------')

    def on_batch_end(self,batch,logs={}):
        logging.info('Batch ' + str(batch) + ' - Validation loss: ' + str(logs.get('loss')) + ', validation accuracy: ' + str(logs.get('acc')))

If samples_per_epoch = 2*batch_size, then the fit_generator() loops over 22 batches. This is quite surprising to me. It would be great if someone can explain this phenomena. I am not sure whether this bears some relation with #1639. I am tagging @fchollet @wongjingping as they have been helping me in the issues with data generator.
If someone wants to runnable script reproducing this issue (very similar to Keras demos), here it is:
from __future__ import print_function
import sys
import threading
from multiprocessing import Queue

from keras.datasets import cifar10
from keras.preprocessing.image import ImageDataGenerator
from keras.models import Sequential
from keras.layers.core import Dense, Dropout, Activation, Flatten
from keras.layers.convolutional import Convolution2D, MaxPooling2D
from keras.optimizers import SGD
from keras.utils import np_utils
from keras import callbacks
from keras.callbacks import ModelCheckpoint
import logging

logging.basicConfig(level=logging.DEBUG,
                    format='%(asctime)s %(name)-12s %(levelname)-8s %(message)s',
                    datefmt='%m-%d %H:%M',
                    filename='Run_10Feb_cifar10_withDataAug_2.txt',
                    filemode='w')

logging.info('Done with all the imports')

class LossHistory(callbacks.Callback):
    def on_train_begin(self, logs={}):
        self.losses = []

    def on_epoch_end(self, epoch, logs={}):
        self.losses.append(logs.get('val_loss'))
        logging.info('-----------------------------------------------------------------------')
        logging.info('Epoch ' + str(epoch) + ' - Validation loss: ' + str(logs.get('val_loss')) + ' accuracy : ' + str(logs.get('val_acc')))
        logging.info('-----------------------------------------------------------------------')

    def on_batch_end(self,batch,logs={}):
        logging.info('Batch ' + str(batch) + ' - Validation loss: ' + str(logs.get('loss')) + ', validation accuracy: ' + str(logs.get('acc')))

logging.info('History class defined')

batch_size = 32
nb_classes = 10
nb_epoch = 100
data_augmentation = True
weightSavePath = '/media/vijetha/DATA/vijetha2/Documents/imageClassification_Parag/weights/'

# input image dimensions
img_rows, img_cols = 32, 32
# the CIFAR10 images are RGB
img_channels = 3

# the data, shuffled and split between train and test sets
(X_train, y_train), (X_test, y_test) = cifar10.load_data()
logging.info('X_train shape:' + str(X_train.shape))
logging.info(str(X_train.shape[0]) + ' train samples')
logging.info(str(X_test.shape[0]) + ' test samples')

# convert class vectors to binary class matrices
Y_train = np_utils.to_categorical(y_train, nb_classes)
Y_test = np_utils.to_categorical(y_test, nb_classes)

history = LossHistory()

logging.info('Model buidling started')

model = Sequential()

model.add(Convolution2D(32, 3, 3, border_mode='same',
                        input_shape=(img_channels, img_rows, img_cols)))
model.add(Activation('relu'))
model.add(Convolution2D(32, 3, 3))
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))

model.add(Convolution2D(64, 3, 3, border_mode='same'))
model.add(Activation('relu'))
model.add(Convolution2D(64, 3, 3))
model.add(Activation('relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))

model.add(Flatten())
model.add(Dense(512))
model.add(Activation('relu'))
model.add(Dropout(0.5))
model.add(Dense(nb_classes))
model.add(Activation('softmax'))

# let's train the model using SGD + momentum (how original).
sgd = SGD(lr=0.01, decay=1e-6, momentum=0.9, nesterov=True)
model.compile(loss='categorical_crossentropy', optimizer=sgd, class_mode='categorical')

logging.info('Model buidling and compilation finished')

X_train = X_train.astype('float32')
X_test = X_test.astype('float32')
X_train /= 255
X_test /= 255

checkpointer_all = ModelCheckpoint(filepath= weightSavePath + "withDataAug_weights.{epoch:02d}.hdf5", verbose=1, save_best_only=False)
checkpointer_best = ModelCheckpoint(filepath= weightSavePath + "withDataAug_bestWeights.hdf5", verbose=1, save_best_only=True)

if not data_augmentation:
    logging.info('Not using data augmentation.')
    model.fit(X_train, Y_train, batch_size=batch_size,
              nb_epoch=nb_epoch, verbose=2, show_accuracy=True, callbacks = [history, checkpointer_all, checkpointer_best],
              validation_data=(X_test, Y_test), shuffle=True)
else:
    logging.info('Using real-time data augmentation.')

    # this will do preprocessing and realtime data augmentation
    datagen = ImageDataGenerator(
        featurewise_center=True,  # set input mean to 0 over the dataset
        samplewise_center=False,  # set each sample mean to 0
        featurewise_std_normalization=False,  # divide inputs by std of the dataset
        samplewise_std_normalization=False,  # divide each input by its std
        zca_whitening=False,  # apply ZCA whitening
        rotation_range=0,  # randomly rotate images in the range (degrees, 0 to 180)
        width_shift_range=0,  # randomly shift images horizontally (fraction of total width)
        height_shift_range=0,  # randomly shift images vertically (fraction of total height)
        horizontal_flip=False,  # randomly flip images
        vertical_flip=False)  # randomly flip images
    # compute quantities required for featurewise normalization
    # (std, mean, and principal components if ZCA whitening is applied)
    datagen.fit(X_train)

    # fit the model on the batches generated by datagen.flow()
    model.fit_generator(datagen.flow(X_train, Y_train, batch_size=batch_size),
                        samples_per_epoch=2*batch_size,
                        nb_epoch=nb_epoch, verbose=2, show_accuracy=True, callbacks = [history],
                        validation_data=(X_test[0:100], Y_test[0:100]),
                        nb_worker=1)

    logging.info('History of the losses is: ')
    logging.info(str(history.losses))

No, it doesn't. Maybe you are using an outdated version of Keras.

Ok. The problem doesn't exist anymore in the latest version.

@fchollet : I have the latest version of keras  (Keras 1.0.6).
But I am getting the error:
ValueError: I/O operation on closed file.


Remove bone_pose_updated signal and replace it with the skeleton_updated signal

As has always been the case, the bone_pose_updated signal is fired a crazy many times in a single frame and can cause unusual updates in BoneAttachment. It should never be used, but used only by BoneAttachment.
For safety and performance, make skeleton fire the skeleton_updated signal only once per frame at the moment all modifiers processed. Then, the BoneAttachment uses it.
If the user has been using the bone_pose_updated signal, replace it with the pose_updated signal which is used by some Editors. This signal may also be fired multiple times per frame, but is relatively safe to use since it is not fired during the update process although it does not detect changes made by the Modifier.
If you need a post modification signal for a specific modifier, use the already existing SkeletonModifier3d.modifier_processed signal.
For the final pose reflected in the skin, use the skeleton_updated signal that this PR adds.

I think we need to understand the overall design regarding the update order. Also, is it okay from the user perspective for bone attachment to only update once per frame?

I have already agreed with @reduz in the past that if poses during modification by the Modifier are needed, the user must either use the modification_processed signal or create their own SkeletonModifier3D.
From the use case of the BoneAttachment, I conclude for now that it is only important to be consistent with the final visual pose.

Thanks!

@TokageItLab
@lyuma
https://github.com/godotengine/godot/blob/57aa7345627075fa4cf3f1de33bcddf67baafe80/scene/3d/xr_body_modifier_3d.cpp#L76
when is the Target removed? Why?

@GeorgeS2019 please don't ping me on two different messenger apps. You asked the same question in godot contributor chat and I answered there. It is off topic for this PR anyway


Update DAO contracts

put this on hold for now - will use the simplified contracts - see branch #332


Internal("Subscription failed, try again later...") on pubsub

I have an app where pubsub connection is created from actix_rt runtime (based on Tokio runtime), but occasionally I get error just like in #47 when trying to subscribe to the topic.
Fails the same in these configurations:

Linux host with Redis in Docker
macOS host with Redis in Docker (within VM of course)
Linux host with Redis on AWS (Elasticache)

Turns out that library drops connection when stream from subscription is dropped, while the expectation is that subscription will be removed and connection will remain active.
It also happens to not always being able to reconnect before subscribing to another subject, which seems to be exactly the kind of race condition Rust is supposed to avoid.
Also no reconnection happens, despite Redis didn't go away and connection from another library (https://github.com/mitsuhiko/redis-rs) is active all the time.

I ran into the same issue.
In a dynamic environment where I first subscribe and then unsubscribe to topics dynamically when 0 subscriptions are left the connection becomes unusable and a reconnection is required.

Same problem here


fix: DocumentDB SQL version for Hash default is 2 - avm/res/document-db/database-account

Description
SQL database container defaults to 2 if omitted. This fixes that issue
Fixes #1852 (closed by accident)
Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utlities (Non-module effecting changes)
[ ] Azure Verified Module updates:

[x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@Agazoth I have multiple remarks here:

Version 2 is only needed for large partition keys or Hierarchical partition keys as far as I know.
I removed support for Range partition key in #1407
The default kind for partition key is 'Hash' so the default value for partition key version will be 1.
You need to add a test for your change, which in your case you won't be able to do as Range partition key is unsupported as mentioned above.

What is the issue you are having or is there a new feature you would like to use?

@bryansan-msft thanks for your feedback!
I'm currently working on converting several deployments from using local modules/another module registry to AMV modules.
One of the larger deployments have a Cosmos DB, that has been deployed with a very basic setup, and it would not accept the current AVM module, because it had version 2 for Hash.
I see now, that this setting was actually requested by the original template author and you are probably right about keeping version on 1 (I wrongly assumed 2 would be the correct default).
I do however think, that it should be possible to change the version on hash, since there are 2 options. The setting cannot be changed after the resource is deployed, and we still need to flow version 2 to the deployment.
I would be glad to add the parameter to the module, if there is a branch I can append it to or I can create a new branch and pr. I could remove Ranged in the too :-)

Well, then feel free to open a PR or modify this one to add an optional partition key version parameter for the UDT of SQL containers. Take into account the following:

The default version value of "Hash" partition key kind must remain 1.
This new parameter must be optional.
The version value of "MultiHash" partition key kind must always be 2.
Add tests in the SQL test suite for your changes.

Well, then feel free to open a PR or modify this one to add an optional partition key version parameter for the UDT of SQL containers. Take into account the following:

The default version value of "Hash" partition key kind must remain 1.
This new parameter must be optional.
The version value of "MultiHash" partition key kind must always be 2.
Add tests in the SQL test suite for your changes.

Done :-)

Well, then feel free to open a PR or modify this one to add an optional partition key version parameter for the UDT of SQL containers. Take into account the following:

The default version value of "Hash" partition key kind must remain 1.
This new parameter must be optional.
The version value of "MultiHash" partition key kind must always be 2.
Add tests in the SQL test suite for your changes.

Done :-)

I will need you to resolve the conflict you are heaving in main.json

@bryansan-msft Alexander is pushing some punctuation updates to the file on the main branch. I merged his changes into my branch. It is updated now and good to go.

Sorry about that @Agazoth, we updated some tests as they were not correctly picking up nested properties to validate them - and with the fix we had to apply a couple small updates to a handful of modules.

@bryansan-msft Alexander is pushing some punctuation updates to the file on the main branch. I merged his changes into my branch. It is updated now and good to go.

Sorry about that @Agazoth, we updated some tests as they were not correctly picking up nested properties to validate them - and with the fix we had to apply a couple small updates to a handful of modules.

No problem @AlexanderSehr , we'll just catch the next run 😊


Update of Storage Component

Addition of backup method for usage later

Check coding style by commiting one more for travis to check


Utility method to wrap PPNL in dynamic proxy that ignores all the exceptions

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Can O' Spam: Watch +4915792621410

Can O' Spam requests the watch of the watch_number +4915792621410. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Jeff Schaller in Charcoal HQ


[BUG] Cannot save large C file

What did you expect to happen?

Open sqlite3.c amalgamation file (8.1MB file)
Make any edit
Save (complete successfully)

What actually happened?
Save has not yet completed in ~5 minutes
Additional details:
Save works fine if mode switched to fundamental-mode beforehand.
Steps to reproduce:

Open sqlite3.c amalgamation file (8.1MB file)
Make any edit
Save (C-x C-s)

System information:

((system
  (type . darwin)
  (config . "x86_64-apple-darwin18.5.0")
  (shell . "/usr/local/bin/zsh")
  (uname . "Darwin 18.7.0 Darwin Kernel Version 18.7.0: Mon Aug 31 20:53:32 PDT 2020; root:xnu-4903.278.44~1/RELEASE_X86_64 x86_64")
  (path "~/.ebcli-virtual-env/executables" "~/.rbenv/shims" "/usr/local/bin" "/usr/bin" "/bin" "/usr/sbin" "/sbin" "~/dev/go/bin" "~/Library/Android/sdk/emulator" "~/Library/Android/sdk/tools" "~/Library/Android/sdk/tools/bin" "~/Library/Android/sdk/platform-tools" "/usr/local/Cellar/emacs-plus/26.3/libexec/emacs/26.3/x86_64-apple-darwin18.5.0"))
 (emacs
  (dir . "~/.emacs.d/")
  (version . "26.3")
  (build . "Aug 30, 2019")
  (buildopts . "--disable-dependency-tracking --disable-silent-rules --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs-plus/26.3/share/info/emacs --prefix=/usr/local/Cellar/emacs-plus/26.3 --with-xml2 --without-dbus --with-gnutls --with-imagemagick --with-modules --with-rsvg --with-ns --disable-ns-self-contained")
  (features . "JPEG RSVG IMAGEMAGICK GLIB NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS LCMS2")
  (traits batch server-running envvar-file))
 (doom
  (dir . "~/.doom.d/")
  (version . "2.0.9")
  (build . "HEAD -> develop 1456108d5 2020-09-10 18:03:32 -0400")
  (elc-files . 0)
  (modules :completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) vc-gutter vi-tilde-fringe window-select workspaces :editor file-templates fold (format +onsave) multiple-cursors rotate-text snippets word-wrap :emacs dired electric ibuffer vc :term eshell :checkers syntax spell grammar :tools docker editorconfig (eval +overlay) (lookup +docsets) :os macos :tools magit make rgb :lang data emacs-lisp go javascript markdown (org +dragndrop +hugo +present) python sh web :config (default +bindings))
  (packages (ace-jump-mode) (telephone-line) (doom-modeline))
  (unpin "n/a")
  (elpa "n/a")))

Confirmed.

It appears you have :editor (format +onsave) enabled. Does the issue go away if you disable it?

No difference for me without (I also had (format +onsave)). OP?

@peterhoeg Could you try profiling this? SPC h T (M-x doom/toggle-profiler) to start the profiler, save the large c file, after some time mash C-g to break out of it, then SPC h T again to produce a report.

I commented out (format +onsave) in my init.el file, restarted emacs, and tried again. It still hangs. While it hangs I see clang-format using 100% of a CPU.
Is there something else I need to do to disable that?

I commented out (format +onsave) in my init.el file, restarted emacs, and tried again.

Did you remember to run doom sync before restarting Emacs?

While it hangs I see clang-format using 100% of a CPU.

This sounds like :editor (format +onsave) was not correctly disabled (or doom sync was forgotten).

Maybe vlf can solve the issue since it can save chunks when working with big files.


Examples/event.php will pop a warning after certain time

I am testing the Mosquitto-PHP with the event.php example,. Unfortunately, I found that the script will pop up an PHP Waring after running awhile (a minute or two), no matter it have received a message or not, and will be stopped to received message after the warning. The warning is:

PHP Warning:  EventBase::dispatch(): An error occurred while invoking the callback in /path/to/mosquitto/examples/event.php on line 27"

I have checked the Apache error.log and confirmed that there is no error there. But I don't known which log file stored errors for PHP CLI mode.
I am not familiar with libevent or PHP Event extension. As the callback is quite sample, I wonder why it will become hang for running awhile.

That was a bit of an example thrown together in a few minutes to see if it would work - I've not run it myself for any great length of time myself. When it happens does the script crash?


React 18 support #166

closes #166

react-ssr-prepass is still in use. renderToReadableStream support not added. I may be able to look into those next week.


Hibernate 6.3 support

Includes some major refactoring to use the new API.

Indeed, this minor version of Hibernate brings quite a few changes

BTW There are no branches for the Hibernate 5, 5.2, and 6 (with this MR) versions as mentioned in the docs. IMO we should add these branches and add them to the docs.

BTW There are no branches for the Hibernate 5 and 5.2 versions as mentioned in the docs. IMO we should create these branches and add them to the docs.

Good catch. I've created an hibenate5 for 5.2 and more. Then I referenced it in the readme without any PR.

6.3.0 release in progress: https://github.com/arey/hibernate-hydrate/actions/runs/6051514637


11.2 Detecting Multiple Images -- Issue with the format_img function

Hi,
We are trying to implement the Notebook, and we have the error following : "NameError: name 'format_img' is not defined", at the line "X, ratio = format_img(img,c)", of the following code,
`img = cv2.imread('data/cat_dog.jpg')
X, ratio = format_img(img, c)
if K.image_dim_ordering() == 'tf':
X = np.transpose(X, (0, 2, 3, 1))
y1, y2, f = model_rpn.predict(X)
r = keras_frcnn.roi_helpers.rpn_to_roi(y1, y2, c, K.image_dim_ordering(), overlap_thresh=0.7)
roi_count = R.shape[0] // c.num_rois
r2 = np.zeros((roi_count * c.num_rois, r.shape[1]))
r2 = r[:r2.shape[0],:r2.shape[1]]
r2 = np.reshape(r2, (roi_count, c.num_rois, r.shape[1]))
`
Is the function defined somewhere in the project ? We can't retrieve it, and can't solve this issue.

I tried the the methods as follows. All the new methods could not work. I thought that format_img() might be either CV2 or PIL methods. However, I could not find the trackback in the web.
-X, ratio = format_img(img, c)
X, ratio = format.img(img, c)
AttributeError: 'builtin_function_or_method' object has no attribute 'img'
-X, ratio = format_img(img, c)
X, ratio = format(img, c)
TypeError: format() argument 2 must be str, not Config
-X, ratio = format_img(img, c)
X, ratio = im.format(img, c)
NameError: name 'im' is not defined

format_img() is included in the library keras_frcnn. Please import the function of format_img() as follows.
from measure_map import format_img


Make sure all types for properties and methods are correct

Make sure the types are accurate, especially the callbacks. There are parameters that Express and Node.js might pass back that I might be missing

They are all as correct as I can get them, some types just don't exist.


How many of the first TF-IDF processing needs to be retained?

Hello！ I would like to ask how many tf-idf need to be kept at the beginning. Is it fixed?
Thank you!

Hi @ditingdapeng, thanks for your interest in our work!
Sorry, I'm not sure about which issue (or email?) you are mentioning... Would you give me more information about the  how many tf-idf need to be kept at the beginning? Is it about the document filtering process in the inference time or the number of negative examples during training?

Hi @ditingdapeng, thanks for your interest in our work!
Sorry, I'm not sure about which issue (or email?) you are mentioning... Would you give me more information about the  how many tf-idf need to be kept at the beginning? Is it about the document filtering process in the inference time or the number of negative examples during training?

Thank you for your reply. What I want to express is: In your paper, the first jump from the question to the relevant facts is calculated by the tf-idf method. So when using tf-idf to sort supporting documents, how many paragraphs are selected last as the initial nodes of multi-hop? Hope i can express my problem clearly

Thank you for your reply. What I want to express is: In your paper, the first jump from the question to the relevant facts is calculated by the tf-idf method. So when using tf-idf to sort supporting documents, how many paragraphs are selected last as the initial nodes of multi-hop? Hope i can express my problem clearly

Thanks for the clarification!
For our best models, we set the initial retrieval number (F in the paper) to 500, 100, and 100 paragraphs for HotpotQA full wiki, SQuAD Open, and Natural Questions Open, respectively ("Implementation details" section in our paper).
Please see the detailed discussion on the relationship between the number of the initial TF-IDF and performance in Section C.1 & Figure 5 in Appendix.

Thanks for the clarification!
For our best models, we set the initial retrieval number (F in the paper) to 500, 100, and 100 paragraphs for HotpotQA full wiki, SQuAD Open, and Natural Questions Open, respectively ("Implementation details" section in our paper).
Please see the detailed discussion on the relationship between the number of the initial TF-IDF and performance in Section C.1 & Figure 5 in Appendix.

Thank you for your kind reply!

Thank you for your kind reply!

 Feel free to start another issue or reach me via email if you have follow-up questions.

 Feel free to start another issue or reach me via email if you have follow-up questions.


Fix Playlist.ReplaceItems response (#972)

PlaylistClient method ReplaceItems now returns a SnapshotResponse instead of boolean.
I removed the status code check, now the behavior is the same as for other non-primitive return types in PlaylistClient.
This fixes issue #972

Thanks! 👍🏼


feat: Select Reskinning

Description
Current select widgets have many minor inconsistencies. This PR fixes them
Fixes #10988
Fixes #10991
Fixes #10984
Fixes #10990
Type of change

Bug fix

How Has This Been Tested?

Manually

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

@jsartisan

Can we add some kind of hover state or emphasis to depict that the user has hovered over an option for the selected and first item in the dropdown as well to make it seem more responsive?

Error state should also be seen when we hover over the icon when it's set to required

@jsartisan Also, the error state is not being seen on the Tree-select widget when it is set to required.
https://www.loom.com/share/7de40bd8f7974421a3afbfeb261d79fa

/ok-to-test sha=9328f97

@jsartisan Noticing some weird behaviour with select widget on release.
The widget looks disabled even when the option is turned off. Can you please check?
https://www.loom.com/share/d272006d6c1445f399ea6fa8a44f3040


Added google-test submodule

pls add some sample tests(maybe rewrite tests that we already have), just to ensure that everything works

also, would be cool to integrate it with github actions

OK, man!

OK, man!


Poorly Written requirements.txt

The provided requirements.txt for the StableVideo model lacks crucial dependencies and contains incorrect version specifications, leading to installation failures. Many essential packages required for the model's proper functioning are missing, and users are forced to manually search and install them, along with downgrading certain dependencies to make the model run successfully.

Could you please share the updated requirements.txt?

try this version:
dependencies:

python=3.8.5
pip=20.3
cudatoolkit=11.3
pytorch=1.12.1
torchvision=0.13.1
numpy=1.23.1
pip:

gradio==3.16.2
albumentations==1.3.0
opencv-contrib-python==<IP_ADDRESS>
imageio==2.9.0
imageio-ffmpeg==0.4.2
pytorch-lightning==1.5.0
omegaconf==2.1.1
test-tube>=0.7.5
streamlit==1.12.1
einops==0.3.0
transformers==4.19.2
webdataset==0.2.5
kornia==0.6
open_clip_torch==2.0.2
invisible-watermark>=0.1.5
streamlit-drawable-canvas==0.8.0
torchmetrics==0.6.0
timm==0.6.12
addict==2.4.0
yapf==0.32.0
prettytable==3.6.0
safetensors==0.2.7
basicsr==1.4.2

It looks like the author's whole environment was just dumped into a requirements.txt with pip freeze, packages that are not being used at all were there.
After spending a lot of time fixing issues with the requirements, this minimal set of packages works for me to run this.
torch
einops
pytorch_lightning
timm
omegaconf
open_clip_torch[training]
opencv-python
scipy
imageio[ffmpeg]

I've removed the requirement of the package basicsr which was used only in one place to download a file!
I have also had to make tons of changes to the code to fix simple errors, if anyone is interested you can see my fork
I've tested this on CPU (Apple M2) and Colab V100 and A100 GPUs.


Can't open the Download Manager

the .exe file just won't run, I've even tried to run as Administrator. Have even checked if it's running in the background and end it from Task Manager, it's just not running. I've even reinstalled it twice--still same issue.
edit: reinstalled using scoop, having the same issue
edit2: Made the .exe startup file, still the same

@sai-Ga Hi there. I think there is a crash at startup
Please do this

Go to the installation folder
run the program using terminal by ABDownloadmanager.exe | more

if there is a crash in startup it will show that in the terminal

Hi @amir1376, I tried running it as mentioned---I'm not seeing any crash details in the terminal. I'll update you if the app does start, as someone else's issue says that the app is taking way to long to open.

@sai-Ga Ah Sounds weird!
another possibility that may cause this problem is your graphic environment
This app uses compose-multiplatform for GUI.
I'm using Open GL by default (for now) for its render api in Windows
but you can override it by SKIKO_RENDER_API environment variable
possible values for Windows are

OPENGL (you are using it now, Open GL)
DIRECT3D (uses DirectX)
SOFTWARE_COMPAT
SOFTWARE_FAST

For example
SKIKO_RENDER_API=SOFTWARE_FAST

After changing your environment variable, make sure the app process is not running and start the app again let see if its work?
BTW I should add a logger for better debugging this problems.

چجوری باید RENDER_API رو تغییر داد؟


Add .gobook as an extension to Markdown

I've developed an extension for VS Code that has a file extension of .gobook, it works like a Jupyter notebook running Go code in a REPL, except the source code is fully markdown compliant. This would allow code committed to GitHub as a .gobook extension to be rendered correctly.
Checklist:

[x] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com
[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

https://marketplace.visualstudio.com/items?itemName=gobookdev.gobook

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

Closing this as you're really jumping the gun and missing the documented minimum usage levels by a massive margin… GitHub's search returns one file with this extension.


Celebrate 1K stars

Need to find a way to celebrate 1K stars!

Found the best way to celebrate
https://github.com/pomber/stargazer

https://user-images.githubusercontent.com/11095731/124502906-5ff83d80-dd92-11eb-830a-8a00f64c36bf.mp4

https://twitter.com/BenEmdon/status/1412097102877007875


Temporarily pin Docker v19.03.8.

Fixes a regression with Docker v19.03.9 by pinning the previous release. This "pinning" should be undone with a followup PR once Docker v19.03.10 is released.
Fixes #489.

@KyleTryon Mechanism not per-say but I did create #491.

Perfect


Add a GUI

Though a user would still have to know how install this with pip, it would be nice to add a GUI. Looks like this could be accomplished by adding just a few lines with https://github.com/chriskiehl/Gooey

Working right now if you do:
pip install Gooey (or pip install -r requirements)
python epub2tts-gui.py
The workflow in the GUI is:
-use file selector to choose epub
-scroll down and check "scan"
-click "start", then "OK" when it says execution finished
-scroll through window to pick start/end chapters
-click "edit"
-uncheck "scan"
-enter any other parameters (start, end, xtts options, etc)
-click start

i just redownloaded the zip but
i dont see a python epub2tts-gui.py
[Errno 2] No such file or directory

It's in the "gui" branch (https://github.com/aedocw/epub2tts/tree/gui) but still has the same base install requirements, so this will probably not be the easy path forward for you. Also this is still a work in progress, as I've barely tested the functionality so far.

It's in the "gui" branch (https://github.com/aedocw/epub2tts/tree/gui) but still has the same base install requirements, so this will probably not be the easy path forward for you. Also this is still a work in progress, as I've barely tested the functionality so far.

o i see, thank you, i await your great accomplishment, ure very talented, this is the best program for tts ive found so far by faaaar, even eleven labs is limited to 5mins on all plans


Derive frequently used traits

I'm writing a library making use of this project, and it would be hugely helpful if the types derived common traits like PartialEq, Eq, Hash, Debug, Clone etc (where possible). I'm happy to make a fork, but I think it would be generally good for the usability of the library.

Is there a particular type where you ran into a limitation?
I think apart from Hash we should already be pretty consistenly implementing those.

Is there a particular type where you ran into a limitation?
I think apart from Hash we should already be pretty consistenly implementing those.

Sorry, that's why I closed it. I looked through the source code and realised I had pretty much hallucinated a lack of default impls. Thanks for responding though!


docs: #2832 range with custom color

There is no mention of how to add custom color to the range. A mention of it saves a little bit of time for most developers. Because the same thing is mentioned for the toggle.

Thanks


Runtime errors in elif statements report the line number of the if statement instead of its own

Godot version:
3.2.2.rc1
OS/device including version:
Windows 10
Issue description:
If you make a series of if-elif-elif blocks in GDScript and there is a error in the condition statement in one of the elifs, then the error message incorrectly reports that it was on the line number of the if-statement.
This makes debugging very difficult when you don't know about the issue and you have some very long if-blocks.  I spent a long time scratching my head at the perfectly good line nowhere near where the error actually occurred.
Steps to reproduce:
Consider the code below, which prints the correct error on the correct line:

res://immediate_code.gd:41 - Division By Zero in operator '/'.

19  func _run():
20	var i = 10
21	var z = 0
22
23	#i = 11  # uncomment this line to create the errors
24
25	if i == 20:
26		print("i is twenty")
27	elif i == 10:
28		print("i is ten")
29
30	# Error 1
31	#elif i == "three":
32	#	print("garbage in garbage out")
33
34	# Error 2
35	#elif i == 1/z:
36	#	print("more garbage")
37
38	# Error 3
39	elif len(i) == 3:
40		print("more garbage")
41	print("reached the end", 1/z)

When I uncomment the i=11 on line 23 and run the error is:

res://immediate_code.gd:25 - Error calling built-in function 'len': Object can't provide a length.

When I uncomment lines 35 and 36, the error is:

res://immediate_code.gd:25 - Division By Zero in operator '/'.

When I uncomment lines 31 and 32, the error is:

** res://immediate_code.gd:25 - Invalid operands 'int' and 'String' in operator '=='.**

The reason for testing with all these errors is that at first it looked like a problem with type-checking.  But this proves that it's every run-time error in the elif-statement that goes wrong.  Parser errors are okay: for example elif i == nonexistingfunction(10): on line 27 gives the correct error line.
Minimal reproduction project:
N/A

Godot version:
3.2.2.rc1

Time to update :)
This is fixed in 3.2.2-stable already.

goddammit.  I can't keep up with this place.


undmg: init at 1.0.0

Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
[ ] Built on platform(s): NixOS / OSX / Linux
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.
[x] Fix the remaining issues of undmg

More
Fixes issue #12969

Ok, I added an install target in the Makefile so that shouldn't be necessary. The version has been bumped to 1.0.2 (not that it's all that important). Everything else looks good. I've added some error checking and made sure it's not printing out in verbose mode. There's probably a few bugs in it still and lots of unused code from XPWN, but besides that it looks good.

Ok, awesome, thanks. Just updated the package to the latest version.

Please squash

output path ‘/nix/store/1l2kvkqdx66a1ck7yb73isp6yx69d6ig-undmg’ has r:sha256 hash ‘1lpqhij3x7kk4s3rw2v1ja393hwp09idzzg22jva67wpfmwz5v5c’ when ‘06z83b762xppnc325vqnmf3fq2hbhx6pxgr6mwzjiz01pfksbccs’ was expected
...
The invocation of "nix-build -A undmg /home/travis/.nox/nixpkgs" failed

ping @mpscholten

@mpscholten see 20a7b9803d99a74f76ff33ba9731aacc4b528765

Everything fixed and squashed :) Travis should also be green again.


Added badges to Readme.md

Badges make projects more newbie-friendly by making useful information about the project itself easily visible, although they should not be too many to keep the document clean.
The following badges have been added (those marked with "*" are updated automatically):

Travis CI *
Appveyor *
Gitter *
Code size *
License
Latest tag *

I am not sure whether the Appveyor badge is properly working or not. The proper link to the status badge is probably accessible through the Appveyor page of the repository , that I cannot access.

@phil-opp So do you think is it a good idea or should I close it ? :)

Sorry for the late reply
I'm not sure if these badges are a good idea for the project because the master branch does not contain the code. So things like code size and build status are not really important. Further, we don't do releases so there is no use in displaying the latest tag (which points to the outdated first edition). The gitter chat and the license are already mentioned in the readme, so I don't see any advantage in the badges.

Alright !


Updated Relay Environment and created a subscription

Signed-off-by: dhruv0000<EMAIL_ADDRESS>Description

Updated relay-env to support subscriptions.
Added subscriptions-transport-ws to support ws.
Created a sample subscription for operator status

To-Do

Create fragment for the operator component once the resolver are created.
Update the relay-store in the Subscription in accordance with the fragment created.

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@dhruv0000 can you update the query once. We are good to merge post that


Set the correct flag when init with a value

Would it make sense to add a test for this functionality?

It would, I will make a task for it in the bounty board


feat(Hide project timeline link from project overview page): hide Pro…

JIRA TICKET: https://pins-ds.atlassian.net/jira/software/c/projects/ASB/boards/166?modal=detail&selectedIssue=ASB-334
Hide Project Timeline Link from Project Overview Page.
Commented out the pertinent parts of the code where we want the element "Project Timeline" hidden.
Got it commented out and with this JIRA ticket reference so it's easy to make it get displayed back when it's time.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix : #216 Mark as complete button UI sync

Hi @hkirat , to solve this issue I observed that whenever a user is changing content then the sidebar reload data from backend and the checkbox is checked according to completed or not but the problem is only when a user is on the same page and tried to check or click on markascompleted then it could not see the changes in the sidebar and the main content screen accordingly. If sidebar again reloads the data then it will show the correct checked status.
My Approach
I created a atom for this, if any user is changing checkbox then this atom will hold its value and will reflect on the right side and vice versa. As user changes content page, sidebar again gets data from backend and the role of atom is complete.
I am just a beginner, please suggest for the improvement required

@devsargam I tried to do it that way but didn't got the solution show sidebar's re-render will be triggered. for re-rendering states are the best things so I tried with it.


Countries are not in alphabetical order

Countries are not in alphabetical order

Hi @warrickrandi, could you able to solve the issue?


[GHSA-mvr2-9pj6-7w5j] Denial of Service in Google Guava

Updates

Affected products

Comments
Several other components are also affected as a result of cloning or shading. Proof-of-Vulnerability projects with tests to verify the presence of the CVE can be found here: https://github.com/jensdietrich/xshady-release/ , the process was the same used for #2258 .

Manually merged in


1.14.4 Mobs from spawners regenerate health

Just set up a XP farm with 2 swarm spawners I found covered in vines close to each other. They fall 21 blocks and are left with half a heart, but then they regen slowly back to full. I've been searching through my mods and configs, and I'm sure this is the only mod of my 40-mod 'pack' that changes spawners. I've tried spawning mobs in creative with spawn eggs and they don't regenerate. Any ideas?

You probably picked up a brutal spawner, which by default applies a couple potions to the mob contained in said spawner.  Regeneration happens to be one of them.


Allow gcs._DeleteOnCloseFile().close() to be called multiple times

Closes #1221
Could someone point me towards a unittest that I can use as an example for how to structure a test?  Where should I put a test?

Sorry about the intermittent fail from Travis. The build should be green.
Anyhow, this implementation doesn't look to follow the LBYL principle that python usually follows. Can't you try to catch the Exception type raised by a file not existing instead?

@Tarrasch We have a domain specific I/O library that behaves like Python's open and file, so I can't catch the exception on close, because I might be suppressing other valid exceptions.
Your comment reminded me that I ended up in this situation because I thought a luigi file-like object's .close() was not being called in __exit__(), so I have been doing:
with target.open('w') as f, io_library.open(f, 'w', driver='name') as src:
    for line in src:
        # do something

So .close() was being called explicitly once when my I/O library hits __exit__() and again in the target's __exit__().  I verified that I can just pass target.open() to my I/O library so this is no longer an issue, but Python's io.FileIO(), gzip.GzipFile(), and bz2.BZ2File() libraries all allow .close() to be closed multiple times, so this seems like an acceptable pattern.
What about the code below?  More sane logic based on whether the file is already closed rather than checking to see if the file exists.
    def close(self):
        if not self.closed:
            super(_DeleteOnCloseFile, self).close()
            os.remove(self.name)

@Tarrasch it is common in most languages to specify close() as callable multiple times.
For example in Java: http://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html#close()
Python: https://docs.python.org/2/library/stdtypes.html?highlight=close#file.close
C#: https://msdn.microsoft.com/en-us/library/system.idisposable.dispose(v=vs.110).aspx
etc :)

Sorry I'm a bit unclear on what I wanted. I'm totally agreeing that close() should be callable twice. However, the implementation in this PR is not following the "don't LBYL" principle.
So change
        if os.path.exists(self.name):
            os.remove(self.name)

to something like
        try:
            os.remove(self.name)
        except GCPFileDoesNotExist:
            pass

LBYL is described here: https://docs.python.org/2/glossary.html. I just made GCPFileDoesNotExist up. I'm fine with the current implementation if there's no defined exception subclass for "FileDoesNotExist", but if there is, let's do it the python way.

@Tarrasch Agreed - here's my suggested revision from above.  The logic only gets executed if the file is not closed.
    def close(self):
        if not self.closed:
            super(_DeleteOnCloseFile, self).close()
            os.remove(self.name)

Does that not have the race-like problem? But sure. That sounds good if there's not GCPFileDoesNotExistException, have you verified that there is not?

@Tarrasch I'm not following your comment about a "race-like condition" or where GCPFileDoesNotExistException fits into this.
Checking to see if the object is already closed and only attempting to remove the file if the object is still open seems to be the most Pythonic and still follows LBYL.

By race I mean that two thread first check if not self.closed: condition. And then they both run os.remove(self.name) and then the second thread to do it fails.

@Tarrasch Ah ok your point about threading makes sense - is that something that we need to handle here?  You are more familiar with Luigi's internals so I defer to your judgement.
When you say GCPFileDoesNotExist, this is a local file so os.remove() just raises an OSError if it doesn't exist, unless I'm missing something.

Well, it's better be safe than sorry I think. Oh, I didn't see it was implemented with a local file. Yes, then please use OSError. Thanks! :)

@Tarrasch Updated.  Any guidance for a unittest, or are you happy without one?

I usually suggest you should add a test case that's similar to how you encountered the bug. Would that be possible?

Yeah I meant more information about where luigi's test data lives in GCS.
To replicate all I need to be able to do is open a test file in GCS with
GCSTarget(), but I don't which bucket to pull from. Is there a similar test
I can look at?
On Fri, Sep 18, 2015 at 9:59 PM Arash Rouhani<EMAIL_ADDRESS>wrote:

I usually suggest you should add a test case that's similar to how you
encountered the bug. Would that be possible?
—
Reply to this email directly or view it on GitHub
https://github.com/spotify/luigi/pull/1222#issuecomment-141608731.

Didn't you see https://github.com/spotify/luigi/blob/master/test/contrib/gcs_test.py?

@Tarrasch Thanks.  Updated with a test and squashed my two commits into one.

@geowurster, since they are in the same PR, it makes sense to merge the commits. :)

@Tarrasch Yep forgot to do it a second time.  Too much multitasking.

There's a flake8 error. Sorry you have to rebase again :p

@Tarrasch Fixed it.

Thanks!!


Revoking sessions for Desktop App gives "invalid session" errors in server logs

I confirm (by marking "x" in the [ ] below):

[X] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[X] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have read contributing guidelines.

Summary

Revoking sessions for Desktop App gives "invalid session" errors in server logs
Steps to reproduce

Environment:

Windows 10 / Mattermost Server v3.5.0 / Mattermost Desktop App v3.4.1

Repro steps:

In a Mattermost server, go to Account Settings > Security > View and Logout of Active Sessions
Find the session corresponding to the desktop app
Hit "Logout"
With a System Admin account, go to System Console > Logs and find the most recent errors

Expected behavior
No errors pertaining to revoking a desktop app session
Observed behavior

The following errors show up in Logs for each revoked desktop app session:
[2016/11/22 22:17:58 UTC] [EROR] Invalid session token=cyy5izi1jbrnzcdrcjxoqe1rar, err=sessionIdOrToken=cyy5izi1jbrnzcdrcjxoqe1rar
[2016/11/22 22:17:58 UTC] [EROR] /api/v3/users/status/set_active_channel:ServeHTTP code=401 rid=53pbqf9xg3fntqrguq9kgf3fbc uid= ip=XXXXXXXXXX Invalid or expired session, please login again. [details: token=cyy5izi1jbrnzcdrcjxoqe1rar]

Possible fixes

?

Just tried the following:
I just tried this with browsers (e.g. login in two different browsers or in an incognito tab or something) and Log this session out from the other Browser.
The messages in the system log are slightly different from yours, but this might just be related to timing (your client tried to call a different API than mine).
The only fix I can see is to send a message to the client that has just been logged off (if it was active) so that it can react to that by suspending eventual API requests...

Thanks @jnugh - would the proposed fix remove the errors from the System logs?
Would a message be displayed on the JavaScript console?
Any side effects that you might foresee to the user?

This is something which needs to be fixed in platform - the logout has to notify the browser/app which runs the session. Nothing we can do (and not limited to the desktop app)

Ah, got it. I'll let the platform team know and create a ticket for them

Ticket is here: https://mattermost.atlassian.net/browse/PLT-4940
We might still want to consider fixing it ourselves and potentially submitting a PR for it. I'm not sure when the platform team would get to this bug..
If there's any information that would be useful to fix it, let me know.

Closing - this will be tracked on the platform side and a fix is scheduled for Mattermost Server 3.7
Thanks @jnugh for your help!


Persisting options button in sample app to avoid hiding

What
Persist the options button to avoid hiding it on re-renders.
Why

How Tested

Process & policy checklist

[ ] I have updated the project documentation to reflect my changes if necessary.
[ ] I have read the CONTRIBUTING documentation.

Is this a breaking change?

[ ] This change causes current functionality to break.

@anjulgarg does this need to be applied to the participant button also?


minADE is not right

when I trained the Set Predictor, eval results are as follows:
other_errors {'stage_one_k': 3.0803698258030754, 'stage_one_recall': 0.9638398086076706, 'set_MR_pred': 0.0738903979863932, 'set_minFDE_pred': 1.3842987156892936}
{'minADE': 14.246385467933312, 'minFDE': 1.3842987156892916, 'MR': 0.0738903979863932}
ADE 14.316873007381048
DE@1 9.875993647573898
DE@2 19.429086244927365
DE@3 3.496420582410066
the minADE is absolutely wrong. I visualize the pred trajs, they are also not right, I think the complete traj module is not trained sufficient, but I trained the model follow your instructions, so where exactly is the problem?

Decoder.py 174, why you add a 'pass', skip the loss of pred trajs ？causing the complete traj module not trained.

The 'pass' does not take any effect here. What is the value of 'complete_traj' in args.other_params, is it True?

Sorry，I made a mistake of 'pass'. But 'complete_traj' is indeed True. Can you give me a trained weight?

These are my parameters, Can you find what is wrong?
--argoverse
--future_frame_num
30
--do_train
--data_dir
train/data/
--output_dir
models_complete_traj
--model_recover_path=models.densetnt.set_predict.2/model_save/model.16.bin
--hidden_size
128
--train_batch_size
64
--use_map
--core_num
16
--use_centerline
--distributed_training
1
--other_params
semantic_lane
direction
l1_loss
goals_2D
enhance_global_graph
subdivide
goal_scoring
laneGCN
point_sub_graph
lane_scoring
complete_traj
set_predict=6
set_predict-6
data_ratio_per_epoch=0.4
set_predict-topk=0
set_predict-one_encoder
set_predict-MRratio=1.0
set_predict-train_recover=models.densetnt.set_predict.2/model_save/model.16.bin
--reuse_temp_file

It seems that model_recover_path does not appear in the README

It doesn‘t matter，if I don't set model_recover_path, it will go to ./tmp to search the weight file. Can you give me a wechat number for deeper communication for details?

What is your evaluation command? During evaluation, you should set model_recover_path to the correct ${OUTPUT_DIR}/model_save/model.16.bin.

Thank u, I knew my problem. model_recover_path should be set to weights of Set Predictor training, but set_predict-train_recover set should be set to weights of first training.


fix: issue 352 kconnect doesn't respect -k --kubeconfig

What this PR does / why we need it:
This PR fixes the issue where passing in the -k flag to kconnect to with a custom kubeconfig path honors it instead of writing it to the default kubeconfig path.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #352

@srinathanand Small issue I have found in the following scenario:
kconnect use eks -k /home/user/test/myconfig
User then runs:
kconnect to -
Config doesn't store in correct place (/home/user/test/myconfig), it instead stores in the default location. Have verified that latest release of kconnect does indeed store it in the correct location (/home/user/test/myconfig). Could you address this please?

This PR is not needed, since #561 fixes the issue.


Automated cherry pick of #1991: * Rename "Admitted by" to "Reserving in" printed column *

Cherry pick of #1991 on release-0.6.
#1991: * Rename "Admitted by" to "Reserving in" printed column *
For details on the cherry pick process, see the cherry pick requests page.

/ok-to-test

/release-note-edit
Improve the kubectl output for workloads using admission checks.

/kind feature


Commenting

Things to do:

Don't generate DB objects on build, but in JS on initial comment
Clean up design/UI
Add moderation elements

I guess all of this is kind of done or not updated?

Yea, we killed commenting. 😢


Using ALE for Python development with both python2 and python3 on $PATH

Information
VIM version

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Sep 30 2017 18:21:38)
Included patches: 1-197, 322, 377-378, 550, 703, 706-707
Operating System:
Debian Stretch
:ALEInfo

Current Filetype:
Available Linters: []
Enabled Linters: []
Suggested Fixers:
'remove_trailing_lines' - Remove all blank lines at the end of a file.
'trim_whitespace' - Remove all trailing whitespace characters at the end of every line.
Linter Variables:
Global Variables:
let g:ale_cache_executable_check_failures = v:null
let g:ale_change_sign_column_color = v:null
let g:ale_command_wrapper = v:null
let g:ale_completion_delay = v:null
let g:ale_completion_enabled = 0
let g:ale_completion_max_suggestions = v:null
let g:ale_echo_cursor = 1
let g:ale_echo_msg_error_str = v:null
let g:ale_echo_msg_format = v:null
let g:ale_echo_msg_info_str = v:null
let g:ale_echo_msg_warning_str = v:null
let g:ale_enabled = 1
let g:ale_fix_on_save = 0
let g:ale_fixers = {}
let g:ale_history_enabled = 1
let g:ale_history_log_output = 1
let g:ale_keep_list_window_open = v:null
let g:ale_lint_delay = 200
let g:ale_lint_on_enter = 0
let g:ale_lint_on_filetype_changed = 1
let g:ale_lint_on_save = 1
let g:ale_lint_on_text_changed = 'never'
let g:ale_lint_on_insert_leave = 0
let g:ale_linter_aliases = {}
let g:ale_linters = {}
let g:ale_linters_explicit = 0
let g:ale_list_window_size = v:null
let g:ale_list_vertical = v:null
let g:ale_loclist_msg_format = v:null
let g:ale_max_buffer_history_size = v:null
let g:ale_max_signs = v:null
let g:ale_maximum_file_size = v:null
let g:ale_open_list = v:null
let g:ale_pattern_options = v:null
let g:ale_pattern_options_enabled = v:null
let g:ale_set_balloons = 0
let g:ale_set_highlights = 1
let g:ale_set_loclist = 1
let g:ale_set_quickfix = 0
let g:ale_set_signs = 1
let g:ale_sign_column_always = v:null
let g:ale_sign_error = v:null
let g:ale_sign_info = v:null
let g:ale_sign_offset = v:null
let g:ale_sign_style_error = v:null
let g:ale_sign_style_warning = v:null
let g:ale_sign_warning = v:null
let g:ale_statusline_format = v:null
let g:ale_type_map = v:null
let g:ale_use_global_executables = v:null
let g:ale_warn_about_trailing_blank_lines = 1
let g:ale_warn_about_trailing_whitespace = 1
Command History:
What went wrong

While developing python programs for python3.5 ALE insists on using python2's pylint. This is quite annoying.
I've tried to look at the help according to this issue but the help pages cannot be found. Not sure why.
Reproducing the bug

I install ALE via VIM's own package management thingy. So ALE is installed in /home/patriki/.vim/pack/mrx/start/ale.
I have both python2 and python3 on my $PATH.
Start vim foo.py and try writing print("This should work").

Python2's pylint will complain about the parens for print. This is wrong as in python3 that is valid. If python3's pylint is used, there are no issues.

See this for generating help tags. https://github.com/w0rp/ale#generating-vim-help-files You'll have to configure your settings so you can use the right Python version.

I found let g:ale_python_flake8_executable = 'python3' via this issue which seems to fix my immediate issue.
This still means that if i happen to work on multiple code bases, some python2 and another python3 based, then it's less than optimal to set the executable globally in the vimrc file.
Is there something in ale to help here? Something like if there is for example a .alerc file or similar. That could contain the project specific ale settings like let g:ale_python_flake8_executable = 'python3' which might not fit very well in the global vimrc file.

You can use buffer local variables in ftplugin files, like g:ale_python_flake8_executable. If you install Python into a virtualenv directory in your source tree, you can load the Python version from there automatically. You can use g:ale_pattern_options to set up options based on filename patterns.

As i read the helpfile g:ale_pattern_options only works on filename based patterns, correct?
g:ale_pattern_options looks somewhat interesting but is still nothing that follows the project regardless of where the project might be checked out.
As I don't have special file name patterns for python3 files vs python2 files I cannot really see how g:ale_pattern_options would help. I doubt anyone has a file naming convention for distinguishing between python2 and python3 files...

Configure g:ale_virtualenv_dir_names and install different versions of Python into different virtualenv directory names. Or use a virualenv plugin. Or write some logic yourself in an ftplugin file. Or use plugins or other commands for project specific settings.

There are many way so configuring Vim how you want it. Pick whatever works best for you.


Clear Containers 3.0.22

Changes
Version bump, no changes

LGTM

cri-o error on ubuntu 16.04
not ok 12 ctr list label filtering
# (in test file ctr.bats, line 488)
#   `[ "$status" -eq 0 ]' failed
# time="2018-03-15T19:25:25Z" level=error msg="'overlay' not found as a supported filesystem on this host. Please ensure kernel is new enough and has overlay support loaded."
# 0


When walking through creating a new instance, the data-binary field does not appear in any instance request

As title. I found the /nnnn/instance request calls, but none of them have a data-binary parameter (nor do any of them appear red in the networking console).  Did something change on Oracle's end?

This is so-called pre-flight request (OPTIONS).  Try different browser

Very unusual. Firefox doesn't show the payload at all, but Chromium-based browsers do.

same error using chrome as well as edge. The payload data isn't copied in the curl request. Got them from the payload tab in the developer tools itself.


Allow custom profile repository name

As title.

nobody see this pull request? sad :(

nobody see this pull request? sad :(

How about helping to review some other PRs? For example, review my PRs, then I could review back.

nobody see this pull request? sad :(

I want to why this custom name is necessary. Why not just use the default one?

Yes, but why?
It makes the logic much more complicated, and I don't see a reason for it.
What's so bad about having one path where it is always expected?
On the contrary, it makes it harder for others to guess where your profile repo is located, i.e. if they want to copy something from your bio in raw markdown.

Yes, but why?
It makes the logic much more complicated, and I don't see a reason for it.
What's so bad about having one path where it is always expected?
On the contrary, it makes it harder for others to guess where your profile repo is located, i.e. if they want to copy something from your bio in raw markdown.

Okay, I see, maybe you are right.   But still a little wonder about why the name of 'pofile repository' must be .profile?  Who rulered it?  the government or laws?  a little sad about the gitea become closing

Yes, but why?
It makes the logic much more complicated, and I don't see a reason for it.
What's so bad about having one path where it is always expected?
On the contrary, it makes it harder for others to guess where your profile repo is located, i.e. if they want to copy something from your bio in raw markdown.

Okay, I see, maybe you are right. But still a little wonder about why the name of 'pofile repository' must be .profile? Who rulered it? the government or laws? a little sad about the gitea become closing

Discussion is here https://github.com/go-gitea/gitea/issues/12233 .
I don't think it's closing, as a product, we have to chose to do something and not do something.

I don't think it's closing, as a product, we have to chose to do something and not do something.

In my view. An open software should be more and more configable , cuttable and extensible. in other words it meanings user should have abilty to using this softerware in any ways they like. a completely immutable product is unlikely to adapt to the needs of the all users it uses.

I don't think it's closing, as a product, we have to chose to do something and not do something.

In my view, An open software should be more and more configable , cuttable and extensible. in other words it meanings user should have abilty to using this softerware in any ways they like. a completely immutable product is unlikely to adapt to the needs of the all users it uses.

I don't think so. Back to the code, gitea does not allow users to define user-level .gitea folder's name and README's name and so on. These should be hard-code, otherwise it will make code too hard to maintain.

In my view, An open software should be more and more configable , cuttable and extensible

Yes, at points where it makes sense.
However, over-configurability is also a thing.
I have no problem with a setting when there are valid usecases/concerns.
But I want it is not a valid concern for it, unless you can give me a practical reason for it.
If we make everything configurable, no one wants to use Gitea either.

I like the idea of "keep it simple" and Occam's razor https://en.wikipedia.org/wiki/Occam's_razor


Coverage improvements for emilsjol

Description
Create tests as described in 3.5.2 Task 2.
Minimum of 2 tests to pass, 4 for P+.

Duplicate


Improve fetch regression test

The fetch regression test has often had failures that we learn to ignore.  Problems:

Using the MD5 sum on the ASCII representation of values is prone to platform dependent problems.
Assuming the MSIDs per content type is static fails when the TDB is updated.

Should we just remove Ska/engarchive/tests/test_fetch_regr.py or is it sometimes being run manually to good use?

(I assume this issue speaks to why the test is skipped by default now)

Yeah, that can be removed.


add benches for simple run criteria

Objective

Add benches for run criteria. This is in anticipation of run criteria being redone in stageless.

Solution

Benches run criteria that don't access anything to test overhead
Test run criteria that use a query
Test run criteria that use a resource

bors r+


Add subscriptions list

@gsvr review please. Landing for QA review.

:+1: Your choice about changing incompleted :)


res.sendFile() throws ReferenceError on Azure

Node version: v0.10.40
Express version: 4.16.4
Error:
Application has thrown an uncaught exception and is terminated: ReferenceError: setImmediate is not defined     at next (D:\home\site\wwwroot\node_modules\express\lib\router\index.js:202:7)     at Layer.handle [as handle_request] (D:\home\site\wwwroot\node_modules\express\lib\router\layer.js:97:5)     at D:\home\site\wwwroot\node_modules\express\lib\router\index.js:281:22     at param (D:\home\site\wwwroot\node_modules\express\lib\router\index.js:354:14)     at param (D:\home\site\wwwroot\node_modules\express\lib\router\index.js:365:14)     at Function.process_params (D:\home\site\wwwroot\node_modules\express\lib\router\index.js:410:3)     at next (D:\home\site\wwwroot\node_modules\express\lib\router\index.js:275:10)     at SendStream.error (D:\home\site\wwwroot\node_modules\serve-static\index.js:121:7)     at SendStream.emit (events.js:88:20)     at SendStream.error (D:\home\site\wwwroot\node_modules\send\index.js:270:17)
I am trying to use express and node to create a middle ware to serve some environment variables from a config.json that is written by octopus, and to log to SEQ. Some of these variables contain api keys to do logging so the idea is to pull out the non sensitive variables and serve them to the client side, and to do the logging from express using app.post() and app.get().
I'm not sure this is the best approach, but I am currently just trying to get the server.js to serve my index.html.
const http = require('http');
const express = require('express');
const path = require('path');
const fs = require('fs');

var port = process.env.port || 1337;
var app = express();

app.use(express.static(__dirname + '/public'));

app.use('/static', express.static(__dirname + '/public'));
app.use('/Content', express.static(__dirname + '/public'));

app.get('*', function(req, res){
    res.sendFile(path.join(__dirname, '/public', 'index.html'));
});
var server = http.createServer(app).listen(port);

When I attempt to hit the site I get a 500 error, and in the console on azure I get the above error.

ReferenceError: setImmediate is not defined

This is a global provided by Node.js, just like how setTimeout is a global provided by Node.js . If you're running into an issue where this is not define, this is likely a Node.js runtime issue vs an Express issue.
I see you say you're using Node.js 0.10.40. Here are the docs on that method from their docs: https://nodejs.org/dist/v0.10.40/docs/api/timers.html#timers_setimmediate_callback_arg
I'm happy to reopen the issue if you think it is an express issue that setImmediate is missing from the runtime and exactly how that conclusion was made and we can get a fix worked out :+1:


persist in redis

Hi, I am really interested in this project,
What would be the best way to store in redis? Should I store every operation ?
thanks

FYI, I made a blog post with instructions on how to get OT in Redis up and running.  Hope it helps!
http://codrspace.com/vote539/operational-tranformation-in-redis/


Cannot query the API using inspect link

Hello,
I have a trouble with calling the API using any inspect link. When I call http://<IP_ADDRESS>:60/stats everything is alright (I assume) and I get this response: {"bots_online":2,"bots_total":2,"queue_size":0,"queue_concurrency":2}
The problem is when I call any inspect link, e.g.
http://<IP_ADDRESS>:60/?url=steam://rungame/730/76561202255233023/+csgo_econ_action_preview M4860026836990897821A38189083877D12028068010305938751
It just takes forever and literally nothing happens. I do not get any error message or anything. Is it any known issue or I just messed something up?
Have a great day guys!

Ensure that you setup the Postgres database: https://github.com/csfloat/inspect?tab=readme-ov-file#how-to-install