Finetuning

Hi,
I don't want to retrain the model from scratch, I want to fine-tune it using a different dataset and most likely different number of classes. is there anyway to do so?

See #34 , #31

Thank you but they are about training from scratch, not fine-tuning.

For fine-tuning you will need pretrained models  and someone who has succesfully trained it, both issues show that this is not the case, thus it is not yet possible to do finetuning on different datasets due to the lack of pretrained models

if a pre-trained model exist in .caffemodel format, it can be converted (potentially) to tensorflow. The only thing remain would be some modifications in the model to accept a different number of class. I think it should be done with last conv layer generally, but I''m not quite sure about MaskRCNN. You are tensorflow expert, you know more.

Till now and to my knowledge there is no implementation of the Mask RCNN in any framework available. While the paper states that

code will be made availble

Mask RCNN paper
it has not been done yet - and if so it is likely to be in Torch or similiar since it comes from FAIRE.
However if you are looking for a way to already have a trained model, you could try to train the Faster R-CNN with your dataset and wait till this repository is finished and then try to merge both architectures. MASK-RCNN is an extension of Faster RCNN.


Aliases not working

Hey there!
First of all, I really liked this as a starting point for antidote configuration. However, I stumbled over the .aliases file being referenced in .zsh_plugins.txt giving me function definition file not found, and thus being unable to use the project 🤔
Any ideas on this are much appreciated! 🙏

What is sounds like you want is to include local files / folders as plugins rather than git repos. No problem! That's supported in antidote, but in order to do that you need to put the full path in your .zsh_plugins.txt, or use a variable like so:
# ~/.zsh_plugins.txt
# This will fail because antidote thinks you want a repo:
.aliases

# This will succeed because you were explicit with a path:
~/.aliases

# This will also succeed because you used a variable:
$ZDOTDIR/.aliases

Alright, thanks so much!


WIP: Brings back the helm code

Revert "Revert "This closes #830""
This reverts commit 4236ff272903a8ffe77a06d9b146aea40b3f057e.
Added a few changes, played around with the version to avoid conflicts and added OSGI setup.

Awesome stuff!
Hellish dependencies.  But if you got it working, let's merge once comments are addressed.
Mainly it's comments to help us in future though there is one bit about cross-platform builds that needs to be checked.
In future it might be nicer to jarjar the odd helm deps in a separate project rather than pull them all in here via OSGi.  But not worth the effort if you have it working.
One other question, do you have an Apache contributor license agreement @iuliana ?

Putting a break on this because of the hellish dependencies.


Upgrading bicep templates

During the deployment, there are several BICEP warnings that alert to changes on the bicep specifications and that there are newer versions.
DoD

Review all bicep modules from the sample and upgrade to the newest version
Test e2e sample to verify that there is no breaking change
Create a table in the ReadMe specifying what is the current version per each bicep module and in which date was upgraded in the sample

Rafaat to review first set 6 templates
Ayman to review second set of 6 templates


Within a col-md-8, a .pell-button width makes the button label break.

Removing width: 30px from .pell-button fixes it.


Not issue, just a question

I'm quite a newbie on Arduino, ESPs,... I'm learning now... So, sorry for these questions:
I haven't understood exactly the ideia of this project...
I want to connect my NodemCU (wich is an home automation hub - temperature, humidity, lights,...) to the Home app of the iOS, through MQTT protocol. I have any other devices wich I want to connect at this moment.
Is this the idea of this project?
I've installed the homebridge and homebridge-mqtt plugin on a Debian server and I believe the I've configured correctly, but on my iOS Home app nothing appears.

homebridge is a framework and server for hardware specific plugins. I think you got this part. If you want to see anything in a HomeKit app (such as apple home, elgato eve, or others) you need to

install at least one plugin (you did)
configure that plugin (if it requires configuration, see the plugin's repository)
if the hardware (in your case probably the software - mqtt broker) needs configuration, do that
start homebridge (there multiple ways depending on OS and preferences, see Wiki pages)
add homebridge as accessory to HomeKit (home -> add -> homebridge should show up -> warning, add anyway -> enter code manually (scanning works almost never). This is called pairing just as with Bluetooth devices, but in the HomeKit apps.

Now the plugins should provide the services to homebridge, which itself bridges to HomeKit. The services should show up in the HomeKit apps.
Some thinks to remember:

one homebridge instance can only be paired with one iCloud account.
access is restricted to local LAN unless you have an Apple TV 4 (3 works for some), or an ios10 iPad configured with the same iCloud account as the home hub - and it's always on.

Regarding mqtt: we have an expert here @cflurin , but questions to that platform might better be posted to the homebridge-mqtt repository.

Thank you very much for your tips @snowdd1 !!!!!
I'm gonna study more... I've tried to find some tutorials or tips of using MQTT + HomeBridge but I couldn't find anything that really helped me. The most of tutorials are confusing and uses the ESP Easy (an ESP8266 custom firmware, that I really don't like).
If you or someone did it and have any tips or suggestions and can share...
But, again, thank you very much!!!

I took a different approach to the same problem statement, and built my own esp8266 code in Lua, and a custom plugin in homebridge to pull the data into HomeKit.  It is something you might consider as an approach.  It does require rolling up your sleeves though.
Take a look at this.
https://www.instructables.com/id/Homebridge-MCU-IOT/

On Mar 17, 2017, at 8:37 AM, felipebraz<EMAIL_ADDRESS>wrote:
Thank you very much for your tips @snowdd1 !!!!!
I'm gonna study more... I've tried to find some tutorials or tips of using MQTT + HomeBridge but I couldn't find anything that really helped me. The most of tutorials are confusing and uses the ESP Easy (an ESP8266 custom firmware, that I really don't like).
If you or someone did it and have any tips or suggestions and can share...
But, again, thank you very much!!!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Great ideia @NorthernMan54 !!
In fact the idea is really good, but I have some other stuff that uses the MQTT protocol (such as integration between NodemCUs).
But I'll keep in mind your tips to try in another opportunity.
Thanks!!


Lidl FB20-002

When I pair my Lidl/Livarno remote (model HG06323) in Domoticz it is is paired as Model FB20-002 but I do not see any devices showing up. Furthermore I get the error.
2021-01-27 23:01:27.501 Python Plugin System: (Zigbee2MQTT) This plugin does not support zigbee device with model "FB20-002" yet
2021-01-27 23:01:27.501 Python Plugin System: (Zigbee2MQTT) If you would like plugin to support this device, please create ticket by this link: https://github.com/stas-demydiuk/domoticz-zigbee2mqtt-plugin/issues/new?labels=new+device&template=new-device-support.md
I am running v.1.17.0 (zStack3x0 20200925) and entry in database.db looks like.
{"id":17,"type":"EndDevice","ieeeAddr":"0xec1bbdfffeab6f9d","nwkAddr":63218,"manufId":4098,"manufName":"_TYZB01_bngwdjsr","powerSource":"Battery","modelId":"TS1001","epList":[1],"endpoints":{"1":{"profId":260,"epId":1,"devId":260,"inClusterList":[0,1,3,4,4096],"outClusterList":[25,10,3,4,5,6,8,4096],"clusters":{"genBasic":{"attributes":{"modelId":"TS1001","manufacturerName":"_TYZB01_bngwdjsr","powerSource":3,"zclVersion":3,"appVersion":81,"stackVersion":0,"hwVersion":1,"dateCode":""}}},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":81,"stackVersion":0,"hwVersion":1,"dateCode":"","zclVersion":3,"interviewCompleted":true,"meta":{},"lastSeen":1611784379831}
How pair the remote properly?

already solved by updating plugin

already solved by updating plugin


Cannot follow the instructions

Open the API Management Developer Portal Application from the list of applications and select the Keys tab (under General) then click 'Generate Key' to generate an auth key
I cannot seem to find this either in the Developer Portal (APIM) or in the Azure Portal. It looks like the instructions are out of date?

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 623cc870-6f9d-039e-b965-a964482a3e6d
Version Independent ID: 80cb6774-fc95-f551-aae7-5f8091bd3b17
Content: Protect SPA backend with OAuth 2.0 by using Azure Active Directory B2C and Azure API Management.
Content Source: articles/api-management/howto-protect-backend-frontend-azure-ad-b2c.md
Service: api-management
GitHub Login: @WillEastbury
Microsoft Alias: wieastbu

@chugh97 Thank you for your feedback! We will review and update as appropriate.

@chugh97 Thanks for catching that! Looks like the doc is written for the older app registration experience. We have assigned this issue to the content author to review and update accordingly.

Hi thanks for triaging the issue. Do you want me to close it?

@chugh97 The issue would be closed when the docs have been updated accordingly. Please feel free to follow this issue for updates.
In the meantime, Keys & Generate Key is equivalent to Certificates and secrets & New client secret. And further in the doc, wherever this key is referred to, you would have to use the generated client secret instead.

@chugh97 - thanks for the feedback - the document update is in progress

thanks guys, much appreciated


Add Calculator component

In this PR, I added boilerplate JSX and developed the UI of the app.
Changes

Created a functional component
Added JSX to the component
Added CSS style rules to the app

Thanks, @omarsalem7 😃


Command systems run all the time

Currently the system provided to add_console_command run every frame, this seems inefficient to me,
would it be possible instead to run these systems only when the command event fires instead ?

Currently in bevy every system runs every frame

iyes_loopless could give you a way to manage conditional execution of systems

I was thinking some sort of run condition which checks if there are outstanding console events, before running the possibly many console systems would be preferable, albeit it would be a small performance improvement

Closed in #41


Hey, me too.


Add GHA workflow to perform integration tests

The GitHub Actions workflow does the following things:

spins up a 3 nodes cluster in AWS using OSS C* 3.11
compresses and uploads the diagnostic collection tool to the first node
runs the collection in extended mode
downloads the generated tarball locally and decompresses it
runs the test scenarios written using Behave (Gherkin syntax)
Tears down the cluster

@rzvoncek-ds @msmygit, I've fixed the PR and added some tests for additional files.
Should be good to review again and hopefully merge.
We should add new tests along the way when we push PRs to the project (coverage is low for now, but the framework is in place at least).


Having a global variable named "URL" prevents css sourcemaps from correctly linking to the source file

I've encountered a weird bug. Having a global variable named URL prevents CSS sourcemaps to correctly link to the source file.
Here's a simple test setup to replicate the bug, almost identical to the one in the getting-started:
document.write('It works.');
require('./css.css');

The above works ok, the css styles display the correct source.
But if I define a global variable URL then it fails to show the source and just points to the <style> element as a source:
document.write('It works.');
URL = require('url');           // problem
// global.URL = require('url'); // problem
// URL = 'anything';            // problem
// global.Url = require('url'); // works
require('./css.css');

It also works if I have the css before the URL:
document.write('It works.');
require('./css.css'); // works
URL = require('url');

yes, because overriding the global URL overrides the browser API: https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/url
Having a global called document also breaks stuff...
globals are bad!
so wontfix.


[mempool] Remove flaky test

Overview
The flaky failover test in the mempool scenario didn't have enough
context, and was too low level to do a full test of a failover
situation.  There is already a test_vfn_failover test covering this
scenario in smoke test.
This is the test that covers the scenario: test_vfn_failover.
Related issues
https://github.com/diem/diem/issues/8671

/land

:broken_heart: Test Failed - ci-test

/land

@gregnazario :bulb: This PR is already queued for landing

:broken_heart: Test Failed - ci-test

/land


Will it support Slim 3

I try to modify this project to Slim 3, but Slim 3 uses a lot dependency injection, and doesn't provide getInstance() anymore.
No idea how to make it work on Slim 3

Hi there, sorry for just replying this now....
Hmmm, I don't know about this new version of Slim.... Maybe we can try to make it compatible together... I will take a more detailed look in this later! 🙋

I'm closing this since there is no response and I can't make it work with Slim3 because I'm not working with PHP for a long time now if someone wants to make it compatible just create a PR or another issue to discuss this.


fix(rds): Handle DBParameterGroupNotFound

Description
Handle DBParameterGroupNotFound when calling describe_db_parameters RDS API.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Removing backport-v3 tag in favor of the new PR of this issue


python311Packages.authcaptureproxy: 1.2.0 -> 1.2.1

https://github.com/alandtse/auth_capture_proxy/releases/tag/v1.2.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 269827 run on x86_64-linux 1

17 packages built:

home-assistant-component-tests.roborock
python310Packages.alexapy
python310Packages.alexapy.dist
python310Packages.authcaptureproxy
python310Packages.authcaptureproxy.dist
python310Packages.python-roborock
python310Packages.python-roborock.dist
python310Packages.teslajsonpy
python310Packages.teslajsonpy.dist
python311Packages.alexapy
python311Packages.alexapy.dist
python311Packages.authcaptureproxy
python311Packages.authcaptureproxy.dist
python311Packages.python-roborock
python311Packages.python-roborock.dist
python311Packages.teslajsonpy
python311Packages.teslajsonpy.dist


Crash

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.02.22
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--no-warnings', '--default-search', 'ytsearch', '-x', '-g', ' https://www.youtube.com/watch?v=qNf9nzvnd1k']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2021.02.22
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 2021-01-09-git-2e2891383e-full_build-www.gyan.dev
[debug] Proxy map: {}
Trailing option(s) found in the command: may be ignored.
[tls @ 0000021fc1cf3a80] Error in the pull function.
[mov,mp4,m4a,3gp,3g2,mj2 @ 0000021fc1cefa80] Packet corrupt (stream = 0, dts = 5576704).
https://r3---sn-uxaxoxu-cg0r.googlevideo.com/videoplayback?expire=1614107494&ei=Bv80YLXOB9bOgAeU3arYAw&ip=2a02%3A1810%3A4e0a%3Aa300%3A706b%3Ae2ba%3A5976%3Aae96&id=o-ACepPM4QtG0DRR1adVyj5KRhoozJwfpHoJIs7A1y67j8&itag=140&source=youtube&requiressl=yes&mh=Ob&mm=31%2C29&mn=sn-uxaxoxu-cg0r%2Csn-5hne6nzs&ms=au%2Crdu&mv=m&mvi=3&pl=33&initcwndbps=1787500&vprv=1&mime=audio%2Fmp4&ns=3PcaMF_xaaROp3qqNEZdcAAF&gir=yes&clen=2330999&dur=143.986&lmt=1604957343412413&mt=1614085727&fvip=3&keepalive=yes&fexp=23983797&c=WEB&txp=5531432&n=z2-cYLc8uQlQd8_5&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhAIAk0nBJk29qycWmDMm9vzFwrLZlSqDCjycEdGjIDYdvAiB3ScCxVEuUZbkUmC_Zc9rh8xiyofRKVufgxxrCPzId8Q%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIhAM-17cs52hTBLE6_dkhotiyAmBUvcYWN0LRtHITJPOQoAiAeDHd7uU3IgAgbSx9u_zGmB0915zj5OKAD_ss8Ygf6CA%3D%3D: corrupt input packet in stream 0
[aac @ 0000021fc233db80] decode_band_types: Input buffer exhausted before END element found
Error while decoding stream #0:0: Invalid data found when processing input
[mov,mp4,m4a,3gp,3g2,mj2 @ 0000021fc1cefa80] stream 0, offset 0x1f40dd: partial file
https://r3---sn-uxaxoxu-cg0r.googlevideo.com/videoplayback?expire=1614107494&ei=Bv80YLXOB9bOgAeU3arYAw&ip=2a02%3A1810%3A4e0a%3Aa300%3A706b%3Ae2ba%3A5976%3Aae96&id=o-ACepPM4QtG0DRR1adVyj5KRhoozJwfpHoJIs7A1y67j8&itag=140&source=youtube&requiressl=yes&mh=Ob&mm=31%2C29&mn=sn-uxaxoxu-cg0r%2Csn-5hne6nzs&ms=au%2Crdu&mv=m&mvi=3&pl=33&initcwndbps=1787500&vprv=1&mime=audio%2Fmp4&ns=3PcaMF_xaaROp3qqNEZdcAAF&gir=yes&clen=2330999&dur=143.986&lmt=1604957343412413&mt=1614085727&fvip=3&keepalive=yes&fexp=23983797&c=WEB&txp=5531432&n=z2-cYLc8uQlQd8_5&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhAIAk0nBJk29qycWmDMm9vzFwrLZlSqDCjycEdGjIDYdvAiB3ScCxVEuUZbkUmC_Zc9rh8xiyofRKVufgxxrCPzId8Q%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIhAM-17cs52hTBLE6_dkhotiyAmBUvcYWN0LRtHITJPOQoAiAeDHd7uU3IgAgbSx9u_zGmB0915zj5OKAD_ss8Ygf6CA%3D%3D: Invalid data found when processing input

Description

The audio just randomly stops and returns the error pasted above. 'Invalid data found when processing input', 'Error in pull function.'
I use FFmpeg with Lua so my discord bot can stream the audio.
My code is attached. First one is the youtube-dl args handler etc.
Second one is the FFmpeg process.

This is youtube-dl issue tracker, not general programming forum.

This is an issue?
This bug has been here for 3 months, I expected some help, not my issue being skipped.

I've already pointed out: this has nothing to do with youtube-dl since it fails in your code after obtaining the download URLs with youtube-dl.


AttributeError: 'Agent' object has no attribute 'train_online'

Rasa Core version: 0.11.3
Python version:  3.5
Operating system (windows, osx, ...): Windows
Issue:  agent.train_online( training_data_file,
AttributeError: 'Agent' object has no attribute 'train_online'
Content of domain file (if used & relevant):
language: "en"

pipeline:
 - name: "nlp_spacy"
 - name: "tokenizer_spacy"
   model: "en"
 - name: "ner_crf"
 - name: "intent_featurizer_spacy"
 - name: "intent_classifier_sklearn"

@Akelad the link is not working


WatchingProblemCollector - Problem matcher memory leak

Type: Performance Issue
NOTE: currently adding more information and a minimal reproduction case
VSCode WatchingProblemCollector memory leak
Source code for the class with the issue
Explanation (from what I can tell)
Every time this.modelService.onModelRemoved is called,
https://github.com/microsoft/vscode/blob/dc619de8d9efdabd781fc5658d0051813c347055/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L435
every line in the terminal is processed.
https://github.com/microsoft/vscode/blob/dc619de8d9efdabd781fc5658d0051813c347055/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L446-L448
Since there are no problem matches, this.tryBegin never wipes the lines stored in this.lines to [].
https://github.com/microsoft/vscode/blob/dc619de8d9efdabd781fc5658d0051813c347055/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L506
Then this.tryBegin & this.tryFinish return false and we don't abort.
https://github.com/microsoft/vscode/blob/dc619de8d9efdabd781fc5658d0051813c347055/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L468
Then, one-by-one, each line is pushed to this.lines, despite already existing in it.
https://github.com/microsoft/vscode/blob/dc619de8d9efdabd781fc5658d0051813c347055/src/vs/workbench/contrib/tasks/common/problemCollectors.ts#L471
The amount of memory used by these arrays grows exponentially until this.modelService.onModelRemoved is called again and either

reading every line takes too long and VS Code stalls and crashes
the WatchingProblemCollector fails to add another line to this.lines and VS Code crashes

Steps to reproduce

Run a shell task that doesn't end and has "isBackground": true, "problemMatcher": [],
Generate a lot of output from that shell task
Keep opening and closing files with at least 1 problem in them to duplicate the number of lines stored in the problem collector
VSCode gets slower and slower at closing files until it eventually crashes the window process

https://user-images.githubusercontent.com/20326398/219228328-6998ffc9-2ee8-4b91-af3f-f96d84f2a988.mov
Minimal reproduction repo
It includes instructions on how to specifically trigger the issue.
https://github.com/zachhardesty7/vscode-problem-matcher-memory-leak
Build information
All extensions disabled
VS Code version: Code - Insiders 1.76.0-insider (af4a70d991053dcbf64d9a86c76a02dced81d9c4, 2023-02-14T05:34:56.983Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: Yes
Note
I spent forever trying to debug what was wrong with my setup, combing thru extensions, debug logs, performance traces, memory dumps, etc. Hopefully this helps! To me, it seems like the problem collection shouldn't be created if there's no problem matches, regardless of what isBackground is set to. Side note, the tasks.json schema indicates that the default for isBackground is true, but this issue does not occur without that manually setting it to true.

I added reproduction steps, a minimal reproduction repo, and a video demonstrating the crash using that repo!

Thanks for the detailed investigation. I'll look into this next week


Re-adding snap-server

Because threepenny-gui transitively depends on snap-server I'd like to see it re-added now that its bounds on time have been bumped.
snap-server doesn't appear to have a Stackage maintainer though. I could volunteer to add it to my packages of course, but ideally one of its Hackage maintainers would step up. Any chances, @mightybyte or @gregorycollins?

Neither of us use stack so it's hard for either of us to justify taking on the extra work right now, sorry.

Neither of us use stack so it's hard for either of us to justify taking on the extra work right now, sorry.

Ok! snap-server was added to my packages in https://github.com/fpco/stackage/commit/47d011bc6405dc3cc02febd63ee8182b2b36ce9c. Thanks @mihaimaruseac!


Merge release/0.13.0 into develop branch

This PR merges release/0.13.0 code into the develop branch.

@daniloprates please approve this chore PR 🙏

bors r+


Markdown previewScripts new rendering behavior

This issue documents the new rendering behavior of the markdown preview, specifically how it may effect previewScripts
Existing Behavior (Pre 1.63)
VS Code's markdown preview updates lives as the user types. To support this, we currently re-render the entire webview.
This means that any scripts on the page are restarted every time the preview contents are updated. These scripts could always count on running in a fresh environment with freshly rendered markdown content
This approach has a number of problems:

It is difficult to correctly maintain the original scroll position
Resources on the page are reloaded on every update
Scripts need to re-initialize themselves on every update

New behavior
Starting in 1.63, we'd like to migrate to use incremental dom updates for updating the markdown preview.
For preview scripts, this means that they are initialized once when the page first loads, but then are expected to handle any future markdown content updates that happen in the existing document. This change in behavior isn't a change for some scripts, but may cause unexpected behavior for others
Updating your preview scripts to support 1.63
The most common issue you may see after updating is that your script runs for the initial page render, but does not kick in for subsequent page updates. This is because preview scripts were written assuming the markdown on the page would only ever be rendered once, which is no longer true
To workaround this, add a new listener in your preview for the 'vscode.markdown.updateContent' custom event. This event is fired when the markdown content on the page has been updated:
window.addEventListener('vscode.markdown.updateContent', () => {
    // Update based on the new markdown content in the file
});

Closing as this was just a notification for extension authors. Will also note this in the release notes


Simplified boolean logic in GLES2/3 rasterizers

These were found with cppcheck:
[drivers/gles2/rasterizer_storage_gles2.cpp:1605]: (style) Redundant condition: p_material->shader->spatial.uses_alpha. '!A || (A && B)' is equivalent to '!A || B'
[drivers/gles3/rasterizer_storage_gles3.cpp:2833]: (style) Redundant condition: material->shader->spatial.uses_alpha. '!A || (A && B)' is equivalent to '!A || B'

Thanks!


ASIT-57: add code for checking reports/replies, blocking/unblocking n…

Adding code for:

checking reports
checking replies
blocking numbers
unblocking numbers

Adding more samples.

Just general commentary:
I'm not sure why the end of php script closing ?> wasn't included in the original example.php but can you please add it to each functional example.
Can you please update to README.md's usage section to stop referencing example.php and the new ones.

Or do you plan to keep the original example? I assumed it was going to be removed.

It's good practice to omit the closing tags on PHP documents (mostly to reduce the risk of output occurring).

Ah yea, just read up on it. :-) thanks.

I removed the original example file and reformatted the code.

Looks good.


fix: adjust Cli and CliCommand type

BREAKING CHANGE: Cli takes two generics instead of one.

Coverage remained the same at 97.063% when pulling dd91b0754d6aa0a6834fb7b2fc8ad8c3de06b943 on config into 2aff932701d8a6012d6176a205420fb4a62f4fd0 on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[video_player] Support video, audio and text track selections

Use case
There have been multiple requests to support getting and setting trackSelections for video_player plugin.

https://github.com/flutter/flutter/issues/59437

Proposal
Providing an easy way to get all types of trackSelections (like video, audio, and text) and set the requested track selection.
The current video player uses auto quality. trackSelections are useful to change the qualities of video and audio and embedded audio languages manually and choose the text trackSelection which could be a caption in this proposal. Since the current video player uses a widget to present captions, this can't be done by backed like exoplayer (as mentioned in https://github.com/google/ExoPlayer/issues/8750#issuecomment-805668040 we can't get the complete srt file as string). Therefore, we should extract all embedded subtitle files by some tools like ffmpeg for mp4 video files, then providing a method that returns a string of current subtitle file.
Some workarounds have been done in this repository (https://github.com/aliyazdi75/plugins/tree/feature_track_selection) that supports android getting and setting trackSelection, but not the subtitle method mentioned above and I needed to take some feedback about it. I haven't started the ios and web sides because I wanted to make sure this is a good way to implement this amazing feature.
UPDATE:
The current video_player_web uses simple HTML video player. As I explored there are some methods to get the video tracks:

HTMLMediaElement.videoTracks
HTMLMediaElement.audioTracks
HTMLMediaElement.textTracks

But they are limited for almost every browser and are behind the enable-experimental-web-platform-features and need to enable by users. Furthermore, they don't provide our needs like bitrate.
For the second option, Shaka Player is another proposal that is blocked by https://github.com/flutter/flutter/issues/66931. By exploring its API, the track represents as mentioned here and they can be accessed by:

getVariantTracks()
getTextTracks()

TODO
This list contains all features mentioned above. Feel free to add yours and give your feedback. All ticked tasks are in the forked repository, feel free to make PRs to complete this feature, and finally, I will request a PR to merge them in the video player plugin.

[ ] Get list of trackselection includes auto with their specifications for video, audio and text.

[x] android
[ ]  ios
[ ]  web (blocked by https://github.com/flutter/flutter/issues/66931)

[x] Providing a class (TrackSelectionNameResource) which helps to change the suggestion trackName by the specific strings.
[ ] Set the requested trackSelection includes auto for video, audio and text.

[x] android
[ ]  ios
[ ]  web (blocked by https://github.com/flutter/flutter/issues/66931)

[ ] Providing a method to get the string of the currently embedded subtitle file.

[ ] android
[ ]  ios
[ ]  web (blocked by https://github.com/flutter/flutter/issues/66931)

could you provide example app something simple so we can understand how to implement track selection in android

could you provide example app something simple so we can understand how to implement track selection in android

It's already implemented in the example.

Is it possible to deselect text tracks with your fork, like https://developer.android.com/reference/android/media/MediaPlayer#deselectTrack(int)?

any update on this issue ? this will be very nice feature addition

Providing a method to get the string of the currently embedded subtitle file.

Regarding getting the current subtitle, one can listen to the onCues events, to get the current subtitles (after setting the track of course in the mentioned PR):

internal interface VideoPlayerCallbacks {
    // ...
    override fun onCues(cueGroup: CueGroup) {
        events.onTextTrackUpdate(cueGroup.cues)
    }
}

internal class VideoPlayerEventCallbacks private constructor(private val eventSink: EventSink) : VideoPlayerCallbacks {
    // ...
    override fun onTextTrackUpdate(cues: List<Cue>) {
        val event: MutableMap<String, Any> = HashMap()
        event["event"] = "textTrackUpdate"
        event["cues"] = cues.map {
            // For docs, see: https://developer.android.com/reference/kotlin/androidx/media3/common/text/Cue
            hashMapOf(
                "size" to it.size,
                "text" to it.text,
                "textSize" to it.textSize,
                "textAlignment" to it.textAlignment?.name,
                "position" to it.position,
                "positionAnchor" to it.positionAnchor,
                "line" to it.line,
                "lineAnchor" to it.lineAnchor,
                "windowColor" to it.windowColor,
            )
        }
        eventSink.success(event)
    }
}

I did the major of the work and I did a pull request but I was not able to merge it, if some one would continue.
I remember I implemented :

[x] Get all sounds inside the video
[x] get all closed captions inside the video
[ ] select a sound
[ ] select a closed captions


Increase priority for global bucket merges

@geirst @toregge please review
To avoid global buckets competing with (and usually being starved by)
default bucket space merges, explicitly prioritize default bucket
merges above most other load.
Increases both distributor-internal maintenance schedulinr priority and
persistence-level operation priority.

@geirst @toregge PTAL at the latest commit. I've added an escape valve for manually getting out of a resource exhaustion scenario where global merges are starving default merges. This is of course not optimal, but serves as a stop-gap until we have more robust and generalized resource exhaustion handling across nodes.


Cleanup.sh: detect graphics card and install appropriate driver

During the last step of the installation process we should detect if a graphics card is present and install the correct driver for it (might need to happen in calamares though)

We are not going to solve this in the calamares installer for 2 reasons:

Some people are unaware of their gpu (and thus which driver to pick)
If people install the wrong driver they can break their system

We will use the cleanup script to detect the gpu and use the correct driver version

We are not going to solve this in the calamares installer for 2 reasons:

Some people are unaware of their gpu (and thus which driver to pick)
If people install the wrong driver they can break their system

We will use the cleanup script to detect the gpu and use the correct driver version


[Docs]: Internal properties to be updated for all widgets

Is there an existing issue for this?

[X] I have searched the existing issues

Documentation Link
https://docs.appsmith.com/widget-reference/camera
Describe the problem
Binding properties of a widget are different to other properties on the property pane and needs to be listed down to explain the usage and expected behaviour of using these widget binding properties. Camera widget has these properties listed.
Describe the improvement
For example, when using Button1. then there are currently 4 properties that show up for a user to access. The meaning and usage are apparent in some cases but are not so clear in others like on the audio widget's playState. The possible values are not apparent unless user tries different combinations. Documenting this would help provide clear information.

@jnikhila can you take a look once on how we can work on this and what are the current gaps?

Sure @dilippitchika. cc - @ajinkyakulkarni

@ajinkyakulkarni - Moved the ticket to consider for upcoming sprint as this needs analysis in terms of sizing the work.


send CONNECTION_CLOSEs from the stateless server

Fixes #1002.
If an error occurs after a packet was successfully unpacked, we should send a CONNECTION_CLOSE.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ad3fbd3). Click here to learn what that means.
The diff coverage is 79.31%.

@@            Coverage Diff            @@
##             master    #1088   +/-   ##
=========================================
  Coverage          ?   90.89%
=========================================
  Files             ?      107
  Lines             ?     7290
  Branches          ?        0
=========================================
  Hits              ?     6626
  Misses            ?      430
  Partials          ?      234

Impacted Files
Coverage Δ

mint_utils.go
64.1% <33.33%> (ø)

server_tls.go
76.74% <84.62%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad3fbd3...7687415. Read the comment docs.


Can't comment in pull request via github.dev

Extension version: Not obvious how to check this. It doesn't show in the extensions tab from github.dev.
VSCode Version: 1.63.0
OS: macOS. Using Edge browser.

Steps to Reproduce:

Open PR https://github.dev/dotnet/roslyn/pull/57780
Navigate to NullableWalker.cs in the GitHub Pull Request tab
Try to leave a comment on a changed line

Expected behavior:
The "new comment" glyph shows up and you can leave a comment
Actual behavior:
No "new comment" glyph shows up

I suspect you were hitting https://github.com/microsoft/vscode-pull-request-github/issues/3173, which should be fixed in version 0.34.1 of the extension.


chore: add incubating tag

Incubating  tag is required before graduation

could put the incubate label down below title?


Fixing the shuffle function

It seems you used "chatgpt or from someone" to make your shuffle function!  The shuffle function is not working...
the answer always the first choice :)
i hope i fixed the shuffle function i

Thank you 🙏


#define not supported.

#include <stdlib.h>

#define BIG 10000

typedef struct {
    int value;
    struct node *next;
} node;

void free_list(struct node *head) {
    struct node *q;
    int k;
    k = 0;
    for (struct node *p = head; p != NULL; p = q) {
        q = p->next;
        free(p);
	k += BIG;

	for(int q = 0; q <= MID; q+=1) {
	  int g += SMALL;
	}
    }

    if(SMALL < g + q) {

      return BIG;
    }

    else {

      return MID;
    }
}

The parser does not isolate the #define. The #define is not represented int he code property. Is there a way to get access to #defines?

We're working on a joern preprocessor, and this will also include "#define". Currently, this is skipped, afaik.

This should be fixed by the joern preprocessor.


Request: Auras for (fixed) template locations, not actors

I am trying to implement an aura for the 5e Silence spell.  Silence is a ranged 20 foot sphere, with effects: "Any creature or object entirely inside the sphere is immune to thunder damage, and creatures are deafened while entirely inside it. Casting a spell that includes a verbal component is impossible there."  So the silence aura is not based on a specific actor having the DAE, but a location/template.  Not sure if doing this is even possible.
I did try creating it as a non-transfer effect on the silence spell, but as expected essentially all it does is put the aura onto any targeted actors at cast time.  Then those actors have the 20-foot aura fixed to them, and as they move around the aura moves with them, which is definitely not how the spell is intended to work.  (If no actors are targeted, then the caster gains concentration, but no targets are affected and no one gets the aura, even if they later move into the template area.)
If multiple nearby creatures are targeted, all sorts of weird things happen.  Moving other creatures into range will cause double sets of the aura affect to appear.    Plus some of the initial targets get multiple copies of some of the effects, but not all, and not the same ones on different actors.
I guess a workaround would be to create a fake actor, drop them where you want the effect to be, and then target them with the spell, but that's obviously not the ideal workflow for this.

This is a enhancement Ive been thinking about for a quite, good to have an issue here to track now

closed with #112


Fix gh-601 issue

Fix gh-601

@cbezmen Thanks for the PR. We don't maintain 2.2.x any longer. Will cherry-pick to 3.0.x.

Merged within ae33802a4b37889d1a93035cb866fc65a627bef4.


Add python 3.10 support

Fix ast.alias call in Python 3.10+
Traceback (most recent call last):
  File "/tmp/app/dessert/rewrite.py", line 144, in exec_module
    source_stat, co = _rewrite_test(fn, self.config)
  File "/tmp/app/dessert/rewrite.py", line 243, in _rewrite_test
    co = compile(tree, fn, "exec", dont_inherit=True)
TypeError: required field "lineno" missing from alias

@nikitanovosibirsk thanks for this!!! Much appreciated!

@vmalloc can you please bump version on pypi?

@nikitanovosibirsk sure! pushed 1.4.2 - should be available soon. Let me know if for some reason it isn't

Thanks!


Feature Request: New Send mode with even better reliability

For turn based games, a single lost message can break the game and if someone disconnects,they just lose without a chance to reconnect, so i'd like the send mode "OverlyReliableQueue".
Each Connection would have a Queue of sent messages.
When sending with OverlyReliableQueue it would add the message to the Queue and if it is the first, then send it immideately.
When recieving confirmation, that the message arrived, it would remove the message from the Queue and send the next.
Each Heartbeat it should resend the first message of the Queue, in case it was lost.
In case a message was recieved multiple times, there would be a ushort highestQueuedSequenceId to check if it should be accepted.
Connection should also have a ClearQueue function in case i want to disconnect intentionally.

closed as it has been denied in https://github.com/RiptideNetworking/Riptide/pull/150

I just wanted to add a more specific explanation since you laid out more specific requirements here: you could implement this on top of the Notify send mode.

Maintain your own message queue.
Send the first message via Notify.
Use the related NotifyDelivered and NotifyLost events to either send the next message from the queue or resend the one that was lost.

Notify send mode already filters duplicates (by sequence ID) so you shouldn't have to worry about that yourself.


feat(ecmascript): constant eval null to number

#6879  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


luci-app-wireguard: add QR Code support plus fixes

add optional QR Code support to status page (per wg Interface),
submitted information via QR code are:

[Interface] (list of) Address / PrivateKey
[Peer] Endpoint / PublicKey / (list of) AllowedIPs
support multiple interfaces and peers

fix XHTML rendering errors with OpenWrt standard theme
fix logical glitch with empty descriptions, remove needless variables
left align the output for better viewing esp. with material theme
freshen up design a little bit
switch space indentation to tabs

Signed-off-by: Dirk Brenken<EMAIL_ADDRESS>

A few screenshots from the "new" status page wir QR Codes:
Default view (with collapsed QR Code):

QR Code view (of course usually without U2 tag ...;-)):

Hint for users without qrencode library:

I looked briefly over the proposed changes and they look good. I do not have access to a system where I could test this with. That means, the value of my review is limited.
Two minor questions:

Would we need to escape the string that we send to qrencode somehow or can we trust it to not contain characters that would end the quotation of the string etc.?
Do you mind saying a word about why you replaced fieldset by div. I think I can learn something here. Thank you!

CC @zx2c4
Look at this, the interface is getting cooler every day!

@danrl thanks for your feedback. Meanwhile I've added the interface address(es) to the provided QR Codes well - as requested by @nerdoc in #2180.
Regarding your questions:

the qrcode input characters are coming from wg dump, therefore I would say they are safe. During my tests with the wireguard android app I didn't see any failures caused by unquoted chars or something like that.
in the past "fieldset" was used for grouping & the "legend" tag - nowadays page structuring and grouping will be done by divs (we've removed the old table structure) and replaced legend with (a more screenreader friendly) "h3" tag

This is super cool. Thanks for pointing it out to be @danrl. It's a bit hard to review, though, because it appears that every line has changed, due to formatting fixes?

@danrl ok to merge?

@dibdot It is fine for me, but as I said, I currently lack the setup and hardware to properly test it.

OK, than let's merge it to get more feedback! ;-)

Is it possible to add more data to the qrcode, at least the IP range and perhaps set the router ip as dns?


"to" function is a footgun when it returns normal outputs. Disallow that case.

The input
0 to 30000000

produces a normal and not a lognormal, and in general the "to" function produces a normal estimate when one of the inputs is 0 or lower. This was a footgun here: https://forum.effectivealtruism.org/posts/YajssmjwKndBTahQx/improving-karma-usd8mn-of-possible-value-my-estimate
Solution: Throw an error instead.

Is lognormal the right distribution for cases like this, though?
It's heavily biased towards the lower values, and the lower boundary affects the mean and the median significantly: https://develop--squiggle-documentation.netlify.app/playground/#code=eNqrVirOyC8PLs3NTSyqVLIqKSpN1QELuaZkluQXwUQy8zJLMhNzggtLM9PTc1KDS4oy89KVrJRSDBVsFYBK8pITS1KDMtMzSjQMFUryFYwNDHQUDA0MDDRj8lKMMNQY6BkYoKlTqgUAXGMtBw%3D%3D
This seems even more like a footgun to me.

Also a conversation to be had.

Can't comment on whether log-normal is appropriate, but I strongly agree that it should support just one distribution. I brought this up when interviewing actually.

I'd be fine replacing the normal with an error, for now.
I'm much less sure about if we should replace lognormal - or more specifically, what we should replace it to. I know David Moss had strong opinions here. I think he thought that lognormal is too heavy tailed. I imagine it will take some investigation and maybe investigation to figure out what to replace it with though. This alone is a small (but important!) research project.

This could be good to do before release.

I think we should deprecate raw a to b, and require normal(a to b) and lognormal(a to b). Then we could do other nice things with that syntax, e.g. use it in annotations (as I proposed previously in https://eaforecasting.slack.com/archives/C030T49UHSS/p1679531237164559).


updated deprecated provider arguments

This is to resolve warnings from Terraform when using the Azure (ARM) provider backend configuration arguments for subscription_id, tenant_id, client_id, client_secret. There is no need for the arm_ prefix.
https://www.terraform.io/docs/providers/azurerm/index.html

Hi @Roshan-Kumar-Microsoft I noticed on #738 you said you would be happy to accept a PR on that subject. I've been searching this repo for this same issue and found this PR. It doesn't have a reviewer. Can you be the reviewer?

@Roshan-Kumar-Microsoft Please do! Would like to start using these tasks again! 👍

duplicate of https://github.com/microsoft/azure-pipelines-extensions/pull/863 closing this


FreezeFrame of viewerCesium3DTilesInspectorMixin occasionally causes crash

@loshjawrence
Failure message:
An error occurred while rendering. Rendering has stopped.
DeveloperError: This object was destroyed, i.e., destroy() was called.
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:43:19)
    at VertexArray.throwOnDestroyed (http://localhost:8080/Source/Core/destroyObject.js:45:19)
    at continueDraw (http://localhost:8080/Source/Renderer/Context.js:1032:12)
    at Context.draw (http://localhost:8080/Source/Renderer/Context.js:1069:9)
    at DrawCommand.execute (http://localhost:8080/Source/Renderer/DrawCommand.js:538:17)
    at executeCommand (http://localhost:8080/Source/Scene/Scene.js:1875:21)
    at executeCommands (http://localhost:8080/Source/Scene/Scene.js:2139:21)
    at executeCommandsInViewport (http://localhost:8080/Source/Scene/Scene.js:2667:9)
    at updateAndExecuteCommands (http://localhost:8080/Source/Scene/Scene.js:2460:13)
    at render (http://localhost:8080/Source/Scene/Scene.js:3075:9)

Example Sandcastle:
anything with a pickable 3dtileset

duplicate #7680


Junit tests for commands

Coverage increased (+6.7%) to 49.524% when pulling 8045f380a05a2e58b6a0427b978ac2f502559a49 on junit-tests3-mikko into 9e106156341aa5fa1ff72ee8cb8bfcce679a6cb0 on master.

Coverage increased (+6.7%) to 49.524% when pulling 8045f380a05a2e58b6a0427b978ac2f502559a49 on junit-tests3-mikko into 9e106156341aa5fa1ff72ee8cb8bfcce679a6cb0 on master.

Coverage increased (+6.7%) to 49.524% when pulling 4a1bf963c6c06c1b8d80f1094bd8b1590a97f102 on junit-tests3-mikko into 66751e476aeb6889fcfc8c721903e336e2ee39c3 on master.

LGTM.


owl-lisp: 0.1.23 -> 0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/owl-lisp/versions.
meta.description for owl-lisp is: "A functional Scheme for world domination"
meta.homepage for owl-lisp is: "https://gitlab.com/owl-lisp/owl"
meta.changelog for owl-lisp is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.2 with grep in /nix/store/glgry9g9s66930gl7lnbqnfk6kx8xzqa-owl-lisp-0.2

directory tree listing: https://gist.github.com/8be3f7ba6b7984b7404c0541da7e43d5

du listing: https://gist.github.com/1ce8839753db1f3ab1a0681e4a9a2a50

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
owl-lisp

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/glgry9g9s66930gl7lnbqnfk6kx8xzqa-owl-lisp-0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A owl-lisp https://github.com/r-ryantm/nixpkgs/archive/2197c952225aee6bead5bf53d0d7c08656998121.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/glgry9g9s66930gl7lnbqnfk6kx8xzqa-owl-lisp-0.2
ls -la /nix/store/glgry9g9s66930gl7lnbqnfk6kx8xzqa-owl-lisp-0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

owl-lisp

Maintainer pings
cc @peterhoeg for testing.

Result of nixpkgs-review pr 112958 at 2197c952 run on aarch64-linux 1

1 package built:

owl-lisp

1 suggestion:

warning: unused-argument
Unused argument: coreutils.
Near pkgs/development/compilers/owl-lisp/default.nix:1:33:
  |
1 | { lib, stdenv, fetchFromGitLab, coreutils, which }:
  |                                 ^


Climber

some errors with gradle (maybe the depreciated gradle?, don't know how to fix)

closing this for now


rare memory corruption in cachemgr_t::compare_cache_mappings()

there is a rare chance of memory corruption in the method cachemgr_t::compare_cache_mappings() which valgrind can't seem to detect. making a ticket for this so i don't forget about it.
real-world output of said corruption:
W [2023-10-03 21:18:55.634704623][cachemgr][main    ] found differences between expected and actual cache mappings
W [2023-10-03 21:18:55.634705243][cachemgr][main    ] count of differences: 1
W [2023-10-03 21:18:55.634706160][cachemgr][main    ] difference: /caches/1000/dartServer <=> /caches/1000/dar/home/magiruuvelvetServer

superseded by a better implementation → 8bb5db43213df2078754e2862489c5c1c2f6397e


Reduce size of MicroProfiler

The MicroProfiler class has these buffers:
const char* tags_[kMaxEvents];
uint32_t start_ticks_[kMaxEvents];
uint32_t end_ticks_[kMaxEvents];

struct TicksPerTag {
  const char* tag;
  uint32_t ticks;
};

TicksPerTag total_ticks_per_tag[kMaxEvents];

We need 20 bytes per event, so an instance of MicroProfiler uses 80 KB of RAM, even if the model you're profiling has only a few nodes.

#2724 is still open


Improper placement indicators displayed for some “Hug” widgets

https://www.loom.com/share/32ed94ca0f15413c9633e275873e9344

This issue is fixed.


Memory map: mmap+memcopy instead pread+pwrite

Allows for only-in-memory caching for usecases where such behavior is needed (i.e. Live Video caching). It maps storage directly into user space memory, so reads and writes are being done by a memcpy (without calls to io).
To build:
cmake -B build -DENABLE_HWLOC=ON -DENABLE_MMAP=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF
cmake --build build -j
cmake --install build

Is this a replacement of #10832? Should the other PR be closed?

Yes #10832 should be closed. As per the comment, it has been merged into the master branch.

@monkuta Please run cmake --target format.

Changes have been made. (https://github.com/apache/trafficserver/pull/11484/commits/6df2474f6d6735ca49f0f7c2f52eb0791317ff6a)

@monkuta Do you have benchmarking number without and with this change?

@bryancall
For 1MB objects, 100% cache hit ratio mean latency drops from 800ms to 23ms @ 33.27GiB/s transfer rate. The achievable transfer rate for 50kB objects at 100% cache hit ratio is 4.84GiB/s compared to 0.94GiB/s for baseline at comparable latencies.


Textfield does not get colored bottom line on focus when label element is absent

Is label mandatory according to the specs?
When the label element is abset, the bottomline does not get colored animation:
http://codepen.io/anon/pen/YXJryb

Labels are required as the documentation states.


[FLINK-20007] Let SinkTransformationTranslator connect the SinkWriter to the real upstream node

What is the purpose of the change
In current version SinkTransformationTranslator connects the SinkWriter with a PartitionerTransformation if the input transformation of SinkTransformation is PartitionTransformation. This would lead to NullPointExcetion.
Brief change log

Use the context.getStreamNodeIds(input) to get the real node id
Make the addOperatorToStreamGraph could connect to a collection of uptream node

Verifying this change
This change added tests and can be verified in SinkTransformationTranslatorTest
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for the PR @guoweiM , I will have a look now.


⚠ Jenkins Plugins Artifactory has degraded performance

In 38216ce, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1003 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 37bdedc after 18 minutes.


Variable NUGET_PACKAGES set to a different value in separate docs.

On this page, the example states to set the NUGET_PACKAGES: '' variable to a blank string. But on this one: https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching?view=azure-devops#netnuget the example has it as NUGET_PACKAGES: $(Pipeline.Workspace)/.nuget/packages
Which one is recommended.?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 94a47e28-d827-dd09-61f4-7198941d2cb5
Version Independent ID: 94a47e28-d827-dd09-61f4-7198941d2cb5
Content: Caching NuGet packages - Azure Pipelines
Content Source: docs/pipelines/artifacts/caching-nuget.md
Product: devops
Technology: devops-cicd-artifacts
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

@jptissot Thanks for your feedback! This should be the path: $(Pipeline.Workspace)/.nuget/packages. The fix will be published shortly.


Remove alpha from ExponentialHermite spline

Check if alpha should be remove for the Hermite spline as well.

As for the exponential B splines we should set this to be always 2pi/M to avoid any bugs

Done in 800e728.


How to open a database as readonly with TypeScript?

The solution of the PR #39 does not seem to work or at least the constants are not in TypeScript types.

Feel free to open a PR to add any missing properties

v4 of sqlite should cover this problem - see the readme on how to get it.


--is-linux Required

This tutorial does not work as instructed. This is because the node version installed is very old as confirmed when queried from Kudu remote console.
Kudu Remote Execution Console
Type 'exit' then hit 'enter' to get a new CMD process.
Type 'cls' to clear the console

Microsoft Windows [Version 10.0.14393]
(c) 2016 Microsoft Corporation. All rights reserved.

D:\home>node -v
v0.10.40

This is when the node runtime version was set when webapp is created beforehand.
az webapp create --name $appname --plan $planname --% --runtime "node|10.14"

This is even with the engine version set to 7.0.0 in package.json, as suggested in the tip section.
"engines": {
    "node": ">7.0.0"
},

The only corrective that worked was when the app service was created with --is-linux option.
az appservice plan create --name $appname --sku F1 --is-linux

az webapp create --name $appname --plan $planname --% --runtime "node|12-lts"

This resolves the node runtime installed on the host, as confirmed when queried from an SSH session.
Last login: Mon Nov  9 10:17:32 2020 from <IP_ADDRESS>
  _____
  /  _  \ __________ _________   ____
 /  /_\  \___   /  |  \_  __ \_/ __ \
/    |    \/    /|  |  /|  | \/\  ___/
\____|__  /_____ \____/ |__|    \___  >
        \/      \/                  \/
A P P   S E R V I C E   O N   L I N U X

Documentation: http://aka.ms/webapp-linux
NodeJS quickstart: https://aka.ms/node-qs
NodeJS Version : v12.18.3
Note: Any data outside '/home' is not persisted

root@744b79b1368e:/home# node -v
v12.18.3
root@744b79b1368e:/home#

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43c16465-63f3-f230-21b6-cdb276950c70
Version Independent ID: 8ed2938f-4484-3117-4eb8-291cb6933df9
Content: Deploy the app code to Azure App Service using the Azure CLI
Content Source: articles/javascript/tutorial-vscode-azure-cli-node-04.md
Product: azure-nodejs
GitHub Login: @diberry
Microsoft Alias: diberry

This tutorial does not work when the location is set to uksouth.
When the location is set to westus as instructed, it works as expected.
Also doesn't work in ukwest.

@dev-playbook Thank you for letting us know. I'll add information in a note to distinguish win/linux and region. #in-progress

@dev-playbook I don't reproduce your issue. Both uksouth and ukwest work for me.

@dev-playbook I'm closing this issue. If you can reproduce the issue, please reopen with more details.

10-deploy-with-local-git.zip
Hi @diberry
Thanks for looking into this.
I am still able to recreate the issue as described. Without the --is-linux option, the deployment is using the 0.10.40 version of NodeJS.
I've attached a compressed file which includes a ps1 script and outputs of local git deployment from 2 scenarios. The script follows the same process as the tutorial.
If you execute 10-deploy-with-local-git.ps1 as is on PowerShell with --is-linux commented out in line 25, you should expect the same failure in uksouth-win.txt. As you can see, the code is deployed with NodeJS 0.10.40 runtime.
Once you rolledback, if you include --is-linux in line 25 and execute, you should expect the same success in uksouth-linux.txt. This time the code is deployed with Node v12.18.3 runtime.
As said earlier, this failure also occurred in ukwest but not in westus.
I was using Windows 10.
I hope that clarifies.


qt5-declarative: empty directories found

building qt5-declarative yields:
Starting package 51/179: qt5-declarative:x64-windows
Building package qt5-declarative[core]:x64-windows...
-- Downloading http://download.qt.io/official_releases/qt/5.12/5.12.0/submodules/qtdeclarative-everywhere-src-5.12.0.tar.xz...
-- Extracting source C:/Tools/vcpkg/downloads/qtdeclarative-everywhere-src-5.12.0.tar.xz
-- Using source at C:/Tools/vcpkg/buildtrees/qt5-declarative/src/5.12.0-db3c45d0e0
-- Configuring x64-windows-rel
-- Configuring x64-windows-rel done
-- Configuring x64-windows-dbg
-- Configuring x64-windows-dbg done
-- Package makefiles-x64-windows-dbg
-- Package build-x64-windows-dbg
-- Package makefiles-x64-windows-rel
-- Package build-x64-windows-rel
-- Package install-x64-windows-dbg
-- Package install-x64-windows-rel
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5Qml.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5Quick.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5QuickParticles.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5QuickShapes.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5QuickTest.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/bin/Qt5QuickWidgets.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5Qmld.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5QuickParticlesd.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5QuickShapesd.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5QuickTestd.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5QuickWidgetsd.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/debug/bin/Qt5Quickd.dll
-- Installing: C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/share/qt5-declarative/copyright
-- Performing post-build validation
There should be no empty directories in C:/Tools/vcpkg/packages/qt5-declarative_x64-windows
The following empty directories were found:
    C:/Tools/vcpkg/packages/qt5-declarative_x64-windows/tools/qt5-declarative/plugins/platforminputcontexts
If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:
    file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/a/dir ${CURRENT_PACKAGES_DIR}/some/other/dir)
Found 1 error(s). Please correct the portfile:
    C:\Tools\vcpkg\ports\qt5-declarative\portfile.cmake

This is from appveyor: https://ci.appveyor.com/project/josch/3dtk/builds/22543051/job/ota5dbppnf9krds0
Vcpkg version: 2018.11.23-nohash
Yes, we run vcpkg update before anything else.

The issue still persists today:
https://ci.appveyor.com/project/josch/3dtk/builds/22972606/job/6f6pvn8ma88uguyr

Thanks for your feedback. I installed qt5-declarative:x64-windows successfully with VS 2017 15.9.11,
this isuse should be fixed in https://github.com/Microsoft/vcpkg/pull/5025. Please try to use latest vcpkg version and reopen a new issue if it is still a problem for you!


Add a bare-bones CV example

Repo URL: https://github.com/caffeinatedgaze/bare-bones-cv

Thanks for the awesome contribution @caffeinatedgaze !


[BUG] Starting Influx eats up all available disk space, error with compaction?

Suddenly and unexpectedly, Influx started using up all disk space and stopping Influx frees up that disk space, while starting Influx takes up all available space again.
When Influx is stopped:

When Influx is started and run for a couple minutes:

Here is a graph of the disk usage.

You can see the disk usage keeps jumping to 100% (it only falls when I restart Influx)
Once the disk space is full the log starts being filled with lines like:
[tsm1] 2016/12/11 01:27:40 beginning level 2 compaction of group 0, 1 TSM files
[tsm1] 2016/12/11 01:27:40 compacting level 2 group (0) /vol/influxdb/data/telegraf/default/160/000000515-000000002.tsm (#0)
[tsm1] 2016/12/11 01:27:40 aborted full compaction group (0). compaction in progress
[tsm1] 2016/12/11 01:27:40 aborted level 2 compaction group (0). compaction in progress
[tsm1] 2016/12/11 01:27:40 beginning level 2 compaction of group 0, 1 TSM files
[tsm1] 2016/12/11 01:27:40 compacting level 2 group (0) /vol/influxdb/data/telegraf/default/144/000000527-000000002.tsm (#0)
[tsm1] 2016/12/11 01:27:40 aborted level 2 compaction group (0). compaction in progress
[tsm1] 2016/12/11 01:27:40 beginning level 2 compaction of group 0, 1 TSM files
[tsm1] 2016/12/11 01:27:40 compacting level 2 group (0) /vol/influxdb/data/telegraf/default/72/000000503-000000002.tsm (#0)
[write] 2016/12/11 01:27:41 write failed for shard 216: engine: error writing WAL entry: write /vol/influxdb/wal/telegraf/default/216/_01550.wal: no space left on device

I also attempted setting cache-max-memory-size =<PHONE_NUMBER> as I saw an error earlier regarding that, but that did not stop the problem.
System info: [Include InfluxDB version, operating system name, and other relevant details]
InfluxDB version: 1.1.0
operating system name:  64-bit Ubuntu 14.04.5 LTS
Disk Space for influx data: 50gb
Steps to reproduce:

Unknown, it happened randomly and unexpectedly.

Expected behavior: For Influx to not take up all available disk space
Actual behavior: Influx is taking up all available disk space
These files available at this gist
curl -o block.txt "http://localhost:8086/debug/pprof/block?debug=1"
curl -o goroutine.txt "http://localhost:8086/debug/pprof/goroutine?debug=1"
curl -o heap.txt "http://localhost:8086/debug/pprof/heap?debug=1"
curl -o vars.txt "http://localhost:8086/debug/vars"
iostat -xd 1 30 > iostat.txt
influx -execute "show shards" > shards.txt
influx -execute "show stats" > stats.txt
influx -execute "show diagnostics" > diagnostics.txt

Reading old issues, I seem to be having issues very similar to https://github.com/influxdata/influxdb/issues/4699.
If Influx has been started and run for a while, one of the data directories has a whole lot of of .tsm.tmp files:

And if Influx is stopped, nowhere near as many files:

It's appears in that old issue, that after leaving it run overnight the compaction completed? I will leave Influx run tonight and update this issue in the morning.

Left overnight, the same issue has not resolved itself

and now the log is full of write failed for shard 216: engine: cache-max-memory-size exceeded:<PHONE_NUMBER>/4194304000)
Will try setting cache-max-memory-size to 0 to let it use all ram (this is a t2.large with 8gb ram)

Resized the EBS volume and turned telegraf on all systems reporting to the host, after a LOT of load and Disk IO, things returned to normal and we were able to turn telegraf back on all other systems.

Your server looks like it might be somewhat underpowered for your workload.  It looks like it only has 2 cpu cores.  Are your disks SSDs?
The large number to *-000000001.tmp files looks a little odd.  There may be a bug where failed snapshots are not cleaning up the tmp files for some reason.  Do you have any errors in the logs related to snapshotting?  A large number of tmp files can happen normally when a large compaction runs, but the naming of the files would be different.

Closing this due to inactivity.  If this is still occurring w/ 1.2 release, please log a new issue.


Can CSP use the reporting API?

Can CSP use the reporting API? If yes, are there any notes?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ed7b604-d89f-1d59-87d6-d32e29eb6245
Version Independent ID: 0113a6ce-3f69-73ce-b063-c07b52348f92
Content: Azure Billing Enterprise APIs
Content Source: articles/billing/billing-enterprise-api.md
Service: billing
GitHub Login: @mumami
Microsoft Alias: erikre

@kazshi, Thanks for the question! For CSP, you can use Azure Rate Card or Partner Center API. See the references below.
Azure Rate Card: https://docs.microsoft.com/en-us/azure/cloud-solution-provider/integration/manage-billing/get-azure-prices and https://docs.microsoft.com/en-us/partner-center/develop/get-prices-for-microsoft-azure
Partner Center API: https://docs.microsoft.com/en-us/partner-center/develop/scenarios

@SadiqhAhmed-MSFT  Thanks for your response. I understand the Reporting API is only for EA. I would provide the links to my customer.


[CP Staging] Fix: Not redirect to workspace chat when pay IOU with business account

Details

This PR resolves:

Pay IOU with business account does not redirect to workspace chat
Personal bank account is always selected when Pay with Expensify

Fixed Issues

$ https://github.com/Expensify/App/issues/46339
$ https://github.com/Expensify/App/issues/46490
PROPOSAL: https://github.com/Expensify/App/issues/46339#issuecomment-2254183898
Tests

A submits an IOU in DM with USD currency
B selects Pay with Expensify
Verify at least these 2 options appear: Personal bank account & Business bank account
Select Business bank account
[mWeb & Native]
Verify app opens Add bank account page
Press back
Verify app opens the workspace chat
[Web & Desktop]
Verify app opens Add bank account page on top of the workspace chat
Verify the expense converted from the IOU in step 1 is highlighted
Verify the workspace chat item in LHN has GBR

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

See Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/193e2834-6dc6-4198-ad87-200fc5ebe74c

Android: mWeb Chrome

https://github.com/user-attachments/assets/45e024c9-2599-4a6b-ae79-2fb3f00512a8

iOS: Native

iOS: mWeb Safari

https://github.com/user-attachments/assets/14164752-7e14-4249-980f-0d395f4ac760

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/8d9dcaa8-308f-48b9-b97a-d68dd10eaecb
RHP opens on top of Workspace chat

The workspace chat is GBR and the expense is highlighted

MacOS: Desktop

https://github.com/user-attachments/assets/9ef22898-6690-4c01-a94a-b0a3cf5a7c19

I tried to test this. The workspace is created and I am redirected but it then leads to a Not Found page.
https://github.com/user-attachments/assets/4411f7b4-d72a-4ecb-8a57-018d28f2058f

Yeah the problem was with my account as I had crossed the limit of workspace. I tested in a new account and it works fine. @gijoe0295 Can you please sync the latest main especially because we reverted a change. I am currently testing by locally updating the code.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/3838687e-d973-4995-8f31-3f8313dc17cd

Android: mWeb Chrome
https://github.com/user-attachments/assets/1677e385-e5fc-41cb-8a8f-6f7144ff10e6

iOS: Native
https://github.com/user-attachments/assets/5f0494c3-e4c2-4325-bc2b-8ce691313c6e

iOS: mWeb Safari
https://github.com/user-attachments/assets/f00cf82b-ef15-405b-ac7a-492bf3db8aa7

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/9812644f-cd28-4dad-abe5-0cdd362d3a33

MacOS: Desktop
https://github.com/user-attachments/assets/5fc2b441-814d-480f-be22-8d7fa7b03db0

Thanks @gijoe0295. @marcaaron Can you take a look?

@mountiny why does this need to be CP'd to staging? Not linked to any deploy blockers AFAICT.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@marcaaron it was originally meant to fix a deploy blocker alongwith other change but then @mananjadhav separated the pr for only the deploy unblocking fix that was CPed
Sorry for the confusion

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Change config.py not to store secrets in plain text

Is your feature request related to a problem? Please describe.
By default config.py stores secrets (such as GOOGLE_CLIENT_SECRET, MICROSOFT_CLIENT_SECRET and other OAuth related things) in PersistentConfig, which saves all variables to config.json in plain text. This is a potential security vulnerability.
Describe the solution you'd like
As wildtangn:3t from Discord has suggested, users could use DotenvX to store encrypted environment variables. The main change would be to simply avoid wrapping secrets in PersistentConfig, but for backwards compatibility reasons it might be useful to keep reading those variables from config.json if present, and warn users that storing secrets there is potentially unsafe.
I understand that the variable will be decrypted in transit anyway and there are no perfect solutions, but it probably better than nothing. Happy to put up a PR if you agree to a direction.

DotenvX might work in the short term but if we plan to add secrets from the UI it's not a solution: instead we could encrypt secrets using WEBUI_SECRET_KEY which is not itself stored.
Here's the current plan:

In config.py, attempt to read encrypted secrets and decrypt with WEBUI_SECRET_KEY. If encrypted secret not present, read unencrypted for backwards compatibility and add the encrypted key. Advise users to delete unencrypted keys from config.json after migration.
When a secret is added, it's encrypted with WEBUI_SECRET_KEY and stored as f"{secret_name}_ENCRYPTED" in config.json.
When decrypting the secret, verify if decryption was successful and raise if WEBUI_SECRET_KEY was not set correctly.

WEBUI_SECRET_KEY can be stored as a file, when the var is left blank then a secret key is generated and inserted into this file. But I'm not sure if when it's set via envvar it populates said file.

Original PR closed because config is being moved to the database. For now, you should probably just use environment variables.


cudnn: 8.7.0

Description of changes
Adds CUDNN 8.7.0.
Release notes are here: https://docs.nvidia.com/deeplearning/cudnn/archives/cudnn-870/release-notes/rel_8.html#rel-870.
Support matrix is here: https://docs.nvidia.com/deeplearning/cudnn/support-matrix/index.html#cudnn-cuda-hardware-versions.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ConnorBaker OOC why did you close this?

btw there's now cuDNN v8.8.0 available. we should prob add that one. we need a new cuDNN version in order to upgrade CUDA 11.x -> 12.x

@samuela I've got a few PRs open and wasn't careful with my naming of branches and got confused between patch-1 .. patch-n. I'll make a new one for CUDNN 8.8.0 with a proper branch name.
I thought if I renamed the branch that GitHub would automatically update the PR to use that branch but I guess it just closed it.

no worries! a cuDNN 8.8.0 PR would be great!

Would it be okay to include 8.7.0 for CUDA 10.2? I don't recall what Nixpkgs wants to provide in terms of support for older versions (CUDNN 8.8.0 seems to have dropped support for CUDA 10.2).

I'm not against adding cuDNN 8.7.0 as well, but we will be wanting to cull old CUDA versions at some point. the maintenance burden is just too high. is there a reason you need CUDA 10.2 in particular?

I don’t need it personally. My thought was if we’re not removing it immediately I might as well update it to the last supported CUDNN. Does that make sense?

On that note, I recall someone in the chat asking for cudnn 8.2.*. It's a dependency for onnxruntime. Maybe we should package that

onnxruntime using nvidia docker hub images
nvidia hub using cudnn 8.2.4

damn is there any way we can upgrade/patch onnxruntime around that?

With these unfree packages, is there any harm in providing multiple releases given that Hydra won’t cache them?
For example, if we wanted to provide all of the 8.x series for CUDNN, would that be problematic?
I would think just having them available would be helpful because it allows users to avoid having to vendor a specific release.

damn is there any way we can upgrade/patch onnxruntime around that?

I haven't tried. But it's what they use in the trunk

I would think just having them available would be helpful

I think so too, especially that vendoring new releases out of nixpkgs tree is kind of cumbersome atm.

is there any harm in providing multiple releases

Only that it's extra attributes that can break and thus require keeping an eye on

It seems like 8.8.0 isn't available through the link we've been using previously: https://developer.download.nvidia.com/compute/redist/cudnn/
Is there anything to do but wait for it to appear there? Or is it possible they'd put it somewhere else?
For what it's worth, I was able to download it through the developer portal.

See https://github.com/NixOS/nixpkgs/pull/215578

Is there anything to do but wait for it to appear there? Or is it possible they'd put it somewhere else?

Hmm, well it does appear to be a recent release. It's also not showing up on https://developer.nvidia.com/rdp/cudnn-archive. If it doesn't show up in a week, ping me and we can reach out to them.


Canvas pattern new option to control the behavior during zoom

The current canvas pattern is nice, but the visuals get a bit 'hectic' during zooming.
Here is a mockup of how it could behave:
https://codesandbox.io/s/canvas-gradient-pattern-forked-srcd3z?file=/main.js
Finland shows the existing pattern method and other countries show the desired way. The difference is evident during zooming. Please ignore what happens during panning - for panning the existing method is ok.
So instead of constantly repositioning itself, it should have clear and concise anchor point so that the zooming would not flicker it around.

The rendering is optimised for styling vector tiles.  Using a vector image layer https://codesandbox.io/s/canvas-gradient-pattern-forked-4h9izy?file=/main.js or redefining the vector layer and source as a vector tile layer with single zoom level source https://codesandbox.io/s/canvas-gradient-pattern-forked-1i5bec?file=/main.js can improve the user experience.

Yes, I tried that vector image layer already and probably go with that. Still I hope someday this would get implemented.

@nobodo If you want to work on this, a new gradientPatternOrigin fill style option would make a nice pull request.

Yes, I assume that if the pattern origin could be set to some fixed point instead of extent top left (did I understand it correctly?), then it would behave as wanted.
In ol/render/canvas/Immediate.js, setImageStyle(imageStyle) takes the origin from:
const imageOrigin = imageStyle.getOrigin();
Is this the one that affects eventually?

No, that's for styling images. For fill patterns/gradients, the executor's fill_ method is used:
https://github.com/openlayers/openlayers/blob/f20df54d84c63d9447347284430935eeefad5663/src/ol/render/canvas/Executor.js#L558-L564
The alignFill_ property comes from the fill instruction, and is set to true whenever a pattern or gradient is used as fill style:
https://github.com/openlayers/openlayers/blob/main/src/ol/render/canvas/Builder.js#L539-L542


Cannot execute tests in Firefox

Are you requesting a feature or reporting a bug?
Bug
What is the current behavior?
Firefox webbrowser can not execute tests.
Application throws error:
Uncaught JavaScript error "TypeError: Argument 4 of TouchEvent.initTouchEvent is not an object." on page
What is the expected behavior?
Would like to execute tests as in Chrome or Egde.
How would you reproduce the current behavior (if this is a bug)?
Run a test in Firefox
Provide the test code and the tested page URL (if applicable)
"@fixture Authentication";
"@page [Can not de shown]

"@test"["Login (username & password)"] = {
    "1.Clear current session": function() {
        window.localStorage.clear();
        window.location.reload();
        act.wait(5e3);
    },
    "2.Click div": function() {
        act.click(".overlay");
    },
    "3.Press key TAB": function() {
        act.press("tab");
    },
    '4.Type in input "Username"': function() {
        act.type("#username", "MY_TEST_USER");
    },
    "5.Press key TAB": function() {
        act.press("tab");
    },
    '6.Type in password input "Password"': function() {
        act.type("#password", "MY_TEST_PASSWORD");
    },
    "7.Press key ENTER": function() {
        act.press("enter");
    },
    "5.Check login success": function() {
        eq($(".col-xs-12").find(" > h3:nth(0)").text(), "Welcome TEST_USER");
    }
};

Specify your

operating system: Windows 10 64bit
testcafe version: 15.1.3
node.js version: 8.11.1 (But are not you providing a Node.exe of your own?)
Firefox version: 60.0.1

Hellom
We provide two TestCafe versions: a paid version with a recorder and an open source version. According to your description, you are using the former version. So, please use the DevExpress Support Center to submit tickets regarding your version (https://www.devexpress.com/Support/Center/Question/Create) as we generally process issues related to the paid TestCafe version there to avoid mixing two different versions. The GitHub channel is intended for the open-source version.

Was this issue ever addressed in the support center? I cannot seem to find this ticket.


feat: Fixed typo in mutlicast to multicast, also in the variable name

Description

Fix multicast typo mutlicast > multicast
Motivation and Context

Incorrect spelling
Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

Thank you! Technically, this is a new feature (variable name changes).


Add Atmel SAM0 pinctrl for SPI, I2C & TCC

This PR adds pinctrl support for the SAM0 SPI, I2C and TCC drivers, as a continuation of #35423, and in support of #41308.

Hi @attie-argentum , you got the spirit !

I'm unsure how we should handle samr2x-pinctrl.dtsi... there are a number of functions that the SAMD2x parts have available that are not available on the SAML2x parts - for example:

On SAML2x, it looks like perhaps PA02 & PA03 aren't bonded out
On SAML2x, PA04 has TCC0/WO[0] on mode E, but does not have TCC3/WO[2] on mode F like the SAMD2x.

For pads that aren't bonded, I'm fairly happy to leave the pinctrl items in place (it's "harmless"?), but for modes that aren't available (e.g: PA04.F), I'd be tempted to use a /delete-node/ in samr2x-pinctrl.dtsi... I suspect there could be many... any thoughts?

I believe this is now ready for review.
I've tested this on SAML21 XPro and SAMR34 XPro boards (via #41308), as well as our custom board.

Hi @gmarull,
I'm not sure what you mean - this PR follows directly in the footsteps of https://github.com/zephyrproject-rtos/zephyr/pull/35423/commits/7c91f46f0584f21bb14eac62610594bc1ff2eadc (#35423, which is listed in #39740).
Please could you clarify?

Hi @gmarull,
I'm not sure what you mean - this PR follows directly in the footsteps of 7c91f46 (from #35423, which is listed in #39740).
Please could you clarify?

I can't see any drivers/pinctrl driver here, nor any of the pinctrl APIs being used. Please check the references I've provided, this is using a custom API.

Hi @gmarull, understood... If you're pushing for a "proper" pinctrl driver right now, then I'll have to put this PR on hold for the moment. Hopefully I'll get back to it, but it may be a couple of weeks.

After discussion, this PR is on hold, and I'm going to try and spend some time on a proper pinctrl driver in the next month or so...

After discussion, this PR is on hold, and I'm going to try and spend some time on a proper pinctrl driver in the next month or so...

I'm closing this in favor of #43731. New devices should have their pins defined as https://github.com/zephyrproject-rtos/hal_atmel/pull/19 pinconfigs/README and will be accept after #43731.

Thanks @nandojve !