Double-wrapping of args leads to bogus "ERR wrong number of arguments for 'eval' command"

Version 0.12.1
I'm calling redisClient.eval with an array of args (doesn't matter which), but no callback.  The LUA script passed in must not be cached by Redis for the bug to trigger.  The library will first try EVALSHA, fail, and then go back to regular EVAL.  It will run the callback originally passed into self.evalsha (index.js, around line 1200):
self.evalsha(args, function (err, reply) {
    if (err && /NOSCRIPT/.test(err.message)) {
        args[0] = source;
        eval_orig.call(self, args, callback);
    } else if (callback) {
        callback(err, reply);
    }
});

To recap, at this time args contains my eval arguments, and callback is undefined.
eval_orig.call() will be routed to RedisClient.prototype["eval"], defined as so (index.js, line ~990):
RedisClient.prototype[command] = function (args, callback) {
    if (Array.isArray(args) && typeof callback === "function") {
        return this.send_command(command, args, callback);
    } else {
        return this.send_command(command, to_array(arguments));
    }
};

Because we will fail typeof callback === "function" check, we'll get to the else clause.  arguments at this point contains 2 values: arguments[0] is the args collection from the previous stack frame, and arguments[1] is callback, which is undefined.  to_array(arguments) will convert arguments into an array of two members, the first of which is going to be the args array.  This seems wrong, and as the request propagates to Redis, "Error: ERR wrong number of arguments for 'eval' command" is generated" is thrown.
The workaround (possibly the correct fix) is to insert an else if clause into the second snippet, like so:
RedisClient.prototype[command] = function (args, callback) {
    if (Array.isArray(args) && typeof callback === "function") {
        return this.send_command(command, args, callback);
    } else if (Array.isArray(args)) {
        return this.send_command(command, args);
    } else {
        return this.send_command(command, to_array(arguments));
    }
};

This is the same issue as #321, but since that one is more than 2 years old, I'm going to open it again just to highlight that yes, the bug is still present and live, and can be easily encountered in production.

In order to better support this project and its new group of collaborators under a new org we are trying to clean up and close issues older than 6 months. Your issue may have been fixed since the issue was open, however, if you are still experiencing a problem please re-open this issue and we will label it accordingly.

This got fixed in v.2.0 and I highly recommend updating to that version as it fixed most issues people ran into.


[RFC] New supervisor review type

In response to #350 - Tag reviews as supervisor reviews properly
Reviews now have a type, creating two mutually exclusive categories of reviews. To me, this makes more sense than a boolean flag, and this allows for future extensibility. Now, supervisor reviews can also make use of the "closed" stage, which should allow us to model all supervisor review states using review.stage and review.go. So we can now more easily distinguish open and closed supervisor reviews as well. The continuation field is unused for supervisor reviews, for now.
This is just meant as a place to propose changes, obviously a lot more plumbing has to happen in the review creation and update process. But we might as well do this right and think ahead.

Closing as deprecated


PR for #888

What this PR does / why we need it:
This PR allows arbitrary features from the FluentD CRD to be used as they are developed
Which issue(s) this PR fixes:
Fixes #888
Does this PR introduced a user-facing change?
None

Additional documentation, usage docs, etc.:

@Nyefan Nice move! Thanks!


"cv2.error: OpenCV(4.7.0) D:\a\opencv-python\opencv-python\opencv\modules\imgproc\src\resize.cpp:4065: error: (-215:Assertion failed) inv_scale_x > 0 in function 'cv::resize'"

This error shows up after starting train.py with the configuration that came with traiNNer. Fresh install with nothing modified (except the train_sr.yml"
23-05-31 19:09:48.945 - INFO: Random seed: 0
23-05-31 19:09:49.264 - INFO: Dataset [AlignedDataset - DIV2K] is created.
23-05-31 19:09:49.266 - INFO: Number of train images: 14,361, epoch iters: 1,795
23-05-31 19:09:49.266 - INFO: Total epochs needed: 279 for iters 500,000
23-05-31 19:09:49.266 - INFO: Dataset [AlignedDataset - val_set14_part] is created.
23-05-31 19:09:49.267 - INFO: Number of val images in [val_set14_part]: 1
23-05-31 19:09:49.624 - INFO: AMP library available
23-05-31 19:09:51.252 - INFO: Initialization method [kaiming]
23-05-31 19:09:51.547 - INFO: Initialization method [kaiming]
23-05-31 19:09:51.670 - INFO: Loading pretrained model for G [..\experiments\pretrained_models\RRDB_PSNR_x4.pth]
23-05-31 19:09:52.916 - INFO: GAN enabled
23-05-31 19:09:52.922 - INFO: AMP enabled
23-05-31 19:09:52.923 - INFO: norm gradient clip enabled. Clip value: 0.1.
23-05-31 19:09:52.935 - INFO: Network G structure: DataParallel - RRDBNet, with parameters: 16,697,987
23-05-31 19:09:52.936 - INFO: Network D structure: DataParallel - Discriminator_VGG, with parameters: 14,502,281
23-05-31 19:09:52.936 - INFO: Model [SRModel] created.
23-05-31 19:09:52.936 - INFO: Start training from epoch: 0, iter: 0
E:\nn\trainner\codes\models\base_model.py:921: FutureWarning: Non-finite norm encountered in torch.nn.utils.clip_grad_norm_; continuing anyway. Note that the default behavior will change in a future release to error out if a non-finite total norm is encountered. At that point, setting error_if_nonfinite=false will be required to retain the old behavior.
self.grad_clip(
C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\optim\lr_scheduler.py:129: UserWarning: Detected call of lr_scheduler.step() before optimizer.step(). In PyTorch 1.1.0 and later, you should call them in the opposite order: optimizer.step() before lr_scheduler.step().  Failure to do this will result in PyTorch skipping the first value of the learning rate schedule. See more details at https://pytorch.org/docs/stable/optim.html#how-to-adjust-learning-rate
warnings.warn("Detected call of lr_scheduler.step() before optimizer.step(). "
Traceback (most recent call last):
File "E:\nn\trainner\codes\train.py", line 500, in
main()
File "E:\nn\trainner\codes\train.py", line 496, in main
fit(model, opt, dataloaders, steps_states, data_params, loggers)
File "E:\nn\trainner\codes\train.py", line 224, in fit
for n, train_data in enumerate(dataloaders['train'], start=1):
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line 521, in next
data = self._next_data()
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line 1203, in _next_data
return self._process_data(data)
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data\dataloader.py", line 1229, in _process_data
data.reraise()
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch_utils.py", line 425, in reraise
raise self.exc_type(msg)
cv2.error: Caught error in DataLoader worker process 0.
Original Traceback (most recent call last):
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data_utils\worker.py", line 287, in _worker_loop
data = fetcher.fetch(index)
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\torch\utils\data_utils\fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "E:\nn\trainner\codes\data\aligned_dataset.py", line 117, in getitem
img_A, img_B = paired_imgs_check(
File "E:\nn\trainner\codes\dataops\augmentations.py", line 1388, in paired_imgs_check
img_A, img_B = shape_change_fn(
File "E:\nn\trainner\codes\dataops\augmentations.py", line 1141, in shape_change_fn
img_A = transforms.Resize((int(h/scale), int(w/scale)),
File "E:\nn\trainner\codes\dataops\augmennt\augmennt\transforms.py", line 192, in call
return F.resize(img, self.size, self.interpolation)
File "E:\nn\trainner\codes\dataops\augmennt\augmennt\common.py", line 211, in wrapped_function
result = func(img, *args, **kwargs)
File "E:\nn\trainner\codes\dataops\augmennt\augmennt\functional.py", line 187, in resize
output = cv2.resize(img, dsize=(size[1], size[0]), interpolation=_cv2_str2interpolation[interpolation])
cv2.error: OpenCV(4.7.0) D:\a\opencv-python\opencv-python\opencv\modules\imgproc\src\resize.cpp:4065: error: (-215:Assertion failed) inv_scale_x > 0 in function 'cv::resize'

I missed this issue before, did you find a solution?
I can take a look in the following days to see if I find where it's coming from.


Scene tree dock: Can't drag node to last position if last item is a lower-level nested child node

Godot version:
3.2-stable
OS/device including version:
Any
Issue description:
In the scene tree, when the last item is the child of a parent node, it's not possible to drag another node as a sibling to that parent that would come in the last position. See:

When releasing the cursor, the "Parent2" node would become a sibling of "Child2", which is a valid use case, but it should be possible by dragging further down to have it come after "Parent3":

This can be achieved currently by dragging "Parent3" onto "Root", which will make it the last child of that new parent.
If the last item in the scene tree is not a lower-level child, it is possible to achieve the intended result by drag and drop (notice the longer underline showing what the parent level will be):

Steps to reproduce:

See MRP, try to drag "Parent2" to be the last child of "Root"

Minimal reproduction project:
scene_tree_drag.zip

Isn't it duplicate of #34033?

Indeed :)


How to analyze BERT results

Can we use the analyze_results.py script also for txt results from eval_bert.py? Or do we have to convert them somehow to .wordscores files?

To get accuracies for BERT, you can use bert-syntax/gen_marvin_tbl.py. I'll add this clarification to the README, and when I get some time I'll also refactor this to take command-line arguments. Thanks!


Main loop error

此错误来自自定义集成。
Logger: custom_components.xiaomi_gateway3.core.gateway
Source: custom_components/xiaomi_gateway3/core/gateway/__init__.py:77
Integration: Xiaomi Gateway 3 (documentation, issues)
First occurred: 14:55:51 (3 occurrences)
Last logged: 14:55:54

<IP_ADDRESS> | Main loop error
Traceback (most recent call last):
  File "/config/custom_components/xiaomi_gateway3/core/gateway/__init__.py", line 92, in run_forever
    not await self.enable_telnet():
  File "/config/custom_components/xiaomi_gateway3/core/gateway/__init__.py", line 77, in enable_telnet
    raw = json.loads(self.telnet_cmd)
  File "/usr/local/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/local/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/lib/python3.9/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 44 (char 43)

Same issue:
Logger: custom_components.xiaomi_gateway3.core.gateway
Source: custom_components/xiaomi_gateway3/core/gateway/init.py:77
Integration: Xiaomi Gateway 3 (documentation, issues)
First occurred: 22 августа 2022 г., 07:08:58 (18835198 occurrences)
Last logged: 21:36:45
Traceback (most recent call last):
File "/config/custom_components/xiaomi_gateway3/core/gateway/init.py", line 92, in run_forever
not await self.enable_telnet():
File "/config/custom_components/xiaomi_gateway3/core/gateway/init.py", line 77, in enable_telnet
raw = json.loads(self.telnet_cmd)
File "/usr/local/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 2 (char 1)

2022-10-21 12:36:38.197 ERROR (MainThread) [custom_components.xiaomi_gateway3.core.gateway] <IP_ADDRESS> | Main loop error
Traceback (most recent call last):
File "/config/custom_components/xiaomi_gateway3/core/gateway/init.py", line 93, in run_forever
not await self.enable_telnet():
File "/config/custom_components/xiaomi_gateway3/core/gateway/init.py", line 78, in enable_telnet
raw = json.loads(self.telnet_cmd)
File "/usr/local/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/usr/local/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/local/lib/python3.10/json/decoder.py", line 355, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

@asumras you have wrong open telnet command in settings

Please reopen the issue if it is still relevant


Cross compiling for NXP/Freescale processors, e.g. MC9S08DZ60

This CPU/Platform or similar ones are not listed at: https://doc.rust-lang.org/rustc/platform-support.html
So the only way would be a custom target as pointed out at: https://doc.rust-lang.org/rustc/targets/index.html
Is this correct?

At least LLVM support is need to generate machine code, which is missing (https://docs.rust-embedded.org/embedonomicon/compiler-support.html). Sadly not possible


Add style to wrap text

Change Summary
Added a style to wrap text
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

[ ] The pull request title has an issue number
[ ] The change works by "Smoke testing" or quick testing
[ ] The change has tests
[ ] The change has documentation

Other Information
I can't create an event with my login, could someone see if this change is working?
Related Issue

Resolve #214

Issue is still free


Update ad-fs-tshoot-logging.md

User Rights Management folder is User Rights Assignment folder.

@Systems-Liam : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Set Theory Supplemental Material: How to Prove Two Sets Are Equal (Improper Word Use)

In the first example of this section, while explaining your proof, you used "compliment" instead of "complement" which is the correct term in context

Fixed


Add Certified Page

Add partner certification page
Add to high level nav
Updated sidebars
Removed Partner Owned Integ page
Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer

So from this, I understand that the certification level will be set only on the PR level and not before as was done so far?

Not sure I follow. We'll have discussions w Partners up front about what this means and guide them based on their preference and our wants.

@mchasepan looks good. But I think we should explain a bit more about full functionality testing.
https://github.com/demisto/content-docs/pull/258#discussion_r469246106
Don't you think?

I think we should explain a bit more about full functionality testing. Don't you think?

I changed it to:

Fully functionality testing — partners must ensure full Pack compatibility with future versions of Cortex XSOAR via a self-certify process. This process shall occur with all major and minor release of Cortex XSOAR (3-4/yr) and include each component of the Pack.

What do you suggest @anara123  ?

@glicht done, thx for finding. didnt know about that sidebar file!

@mchasepan can we merge this?

@mchasepan can we merge this?

@ShahafBenYakir can you help me tmrw while Charlie is out? The Marketplace page is live on GA but on the preview its gone.....

@glicht @anara123 @ShahafBenYakir @trorabaugh  FYI added a gate such that Certified partners req 2 mutual customers. Its up to us to enforce but this will help cut down on smaller partners without a need.

@glicht Any idea why the checks are timing out?

And who can help me figure out why some pages have a sidebar and others dont?

I dont see a setting in the page itself. Thx.

Magically started working. Merged. Thx all.

@mchasepan the build was failing. Once it passed then all was good.

@glicht Any idea why the checks are timing out?

I re-ran the build and it passed. Lately there are cases that it times out. We are working on this.


Move introduction to top of README

fixes #9

I see this has now been addressed; closing this PR.


[stable/openvpn] README scripts reflect new labels

What this PR does / why we need it:

Update readme instructions to work with the new labels introduced in 3.0.0
Quote bash variables to avoid word splitting

/assign @prydonius

I also hit this. Thanks for fixing to -l app=openvpn and actually adding the release= selector!

/ok-to-test

Note that there's also #5455 which is likely related to this.
Currently service labels are broken.

/lgtm


[SPARK-26418][SHUFFLE] Only OpenBlocks without any ChunkFetch for one stream will cause memory leak in ExternalShuffleService

What changes were proposed in this pull request?
In current code path,  OneForOneStreamManager holds StreamState in a Map named streams.
A StreamState is initialized and put into streams when OpenBlocks request received.
One specific StreamState is removed from streams in two scenarios below:

The last chunk of a stream is fetched
The connection of ChunkFetch is closed

StreamState will never be clean up, if OpenBlocks request is received without any following  ChunkFetch request. This will cause memory leak in server side, which is harmful for long running service such as ExternalShuffleService.
Could we call StreamManager#registerChannel to associate the channel with StreamState when server handles OpenBlocks request?
How was this patch tested?
New test added.

Can one of the admins verify this patch?

If ExternalShuffleService only received a OpenBlocks message, not received any ChunkFetchRequest message, associate StreamState is hold by streams.
You thought this method that build relationships between Channel and StreamState  is valid.
But when a Channel is terminated of failed,TransportClientFactory will create another one, please see the method TransportClientFactory.createClient.
So I propose to add a parameter to control some timeout of Channel that sended OpenBlocks.When the time expired,call the method connectionTerminated.

Let me explain my problem in detail.
We use YarnShuffleService as aux service of NodeManager in our cluster. Full GC happened in some NodeManagers. We dump the heap memory, found that the map held StreamState in OneForOneStreamManager was 3G bytes, almost 80% of heap size. Some applications have finished, but the StreamStates were still in OneForOneStreamManager.
In current code, server creates StreamState when handle OpenBlocks request and  associates StreamState with channel when handle following ChunkFetchRequests.
I think two reasons will cause this:

OpenBlocks request is received and StreamState is initialized in server side. Then transport layer client lost or even executor lost, no ChunkFetchRequest is sent to server for the stream.
OpenBlocks request is received and StreamState is initialized in server side. ChunkFetchRequests for the stream are sent to server. But server is under heavy pressure and not able to handle the ChunkFetchRequest before timeout. Then client close its connection in TransportChannelHandler.userEventTriggered.

Currently the OpenBlocks request and following FetchChunkRequests for a specific stream are sent in the same TransportClient in OneForOneBlockFetcher. So I think associate StreamState with channel when handle OpenBlocks request will be fine.

Also, please explain the fix, not the problem, in the PR.

ok to test

Test build #100344 has started for PR 23355 at commit 7a94112.

Test build #100344 has finished for PR 23355 at commit 7a94112.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100344/
Test PASSed.

I check OneForOneBlockFetcher again, the method start use the same TransportClient to sent message OpenBlocks  and following message FetchChunkRequest.There have no chance to call TransportClientFactory.createClient. So I thind your change of code is OK, but still propose to add a parameter to control some timeout of Channel.When the time expired,call the following code
if (state.associatedChannel == channel) {
  streams.remove(entry.getKey());

  // Release all remaining buffers.
  while (state.buffers.hasNext()) {
      state.buffers.next().release();
  }
}

@vanzin
Thanks a lot for review. I will fix the code.

Also, please explain the fix, not the problem, in the PR.

Should I add some explanation about the fix in the PR description?  Thank you.

Test build #100355 has started for PR 23355 at commit c1c8551.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6319/
Test PASSed.

Test build #100355 has finished for PR 23355 at commit c1c8551.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100355/
Test PASSed.

@vanzin
Hi, I fixed the code and updated the PR description.  Could you take a look if you have time. Thank you!


Invert the list for role/member mapping so that member is the key

This PR is to propose a change in the syntax for the input of the module project for additive roles, by reversing the mapping on the member and not on the role.
If I want to check the permissions for user A :
Currently : I need to check all of the keys "role", and see if each of them contains user A.
Example with the current syntax :
module "project" {
  source         = "./modules/project"
  name           = var.project_id
  project_create = false

  iam_additive_roles = [
    "roles/editor",
    "roles/viewer",
    "roles/storage.objectCreator",
    "roles/pubsub.subscriber",
    "roles/storage.objectAdmin"
  ]

  iam_additive_members = {
    "roles/editor" = [
<EMAIL_ADDRESS>    ],
    "roles/viewer" = [
<EMAIL_ADDRESS>    ],
    "roles/storage.objectViewer" = [
<EMAIL_ADDRESS>    ],
    "roles/pubsub.suscriber" = [
<EMAIL_ADDRESS>    ],
  }
}

By reversing : I directly look for the user A entry and have directly the list of all of the roles this user have.
See the "Minimal example with IAM additive roles" section added in the Readme

Thx for the feedback @ludoo
I have updated with iam_additive_members and the test suite in the last commit.
For the other modules, I found the following modules to be concerned by a change:

folder-units
folder
kms
net-vpc
organization
pubsub
secret-manager
service-directory
source-repository

This list is meant to be exhaustive, so I could be wrong by forgetting some. Any feedback welcome.
I will make changes time-opportunistically.

Looks good! Please ping me when you manage to tackle all modules, or let me know if you find out you don't have time so I can do a few. :)

I can help too if needed :)

You probably already discovered it, but you can just point tools/tfdoc/tfdoc.py to the module folder to update the README (provided you have installed its Python requirements).
@juliocc let's split modules three way (Vanessa, you, me) so we get this done, WDYT?

@ludoo , thx for the tip.
Yes, we can totally split the load.
I have numbered the list of modules, we can assign the following way:

I take the modules that are multiple of 3,
@juliocc takes the modules that are multiple of 3 +1
@ludoo  takes the modules that are multiple of 3 +2

Let me make a different proposal as some modules are more complex than others and I'm more familiar with them (which is another way of saying that if they break, it will be my fault). :)
vanessa

folder-units
folder
pubsub

julio

secret-manager
service-directory
source-repository

ludo

net-vpc
kms
organization

Ideally, we should all work in the same branch. What is the best way of doing that in your opinion?

Do you have access to my forked repo https://github.com/voi-oss/cloud-foundation-fabric  ?

Nope:
ERROR: Permission to voi-oss/cloud-foundation-fabric.git denied to ludoo.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I invited both of you with write access on the fork (@ludoo and @juliocc ).

I made a mistake with the previous list: none of the modules have additive bindings, except for organization (for which I commited the change some minutes ago).
Most of the modules only offer authoritative bindings, not additive.

That's right. None of mine have additive bindings yet. Do we want to add them?

Super! Can you just fix the merge conflict in your branch? Guess we're good to go then. :)
Did you also check if we're using additive roles in the end to end examples, or do you need us to check?


[Bug] Page size and page number do not have a default value

When an on load action depends on page size and page number (sql query with the mustache on limit), when triggered, page no and page size are null leading to zero rows being fetched from the query. This leads to the table (on which this action was attached) being empty.
I tested that if the query is also dependent on search text of the table, and I add a default search text, this value is sent to the server for execution. So even though the widget probably hasn't come up when the action was executed, the default value for search did exist when the on load actions were triggered. This should also be the case for table size and table page number.
This issue is being faced by a user of Appsmith.

Closing this as this is not an issue. A table widget's pageNumber defaults to the value 1 during the first page load. On the other hand, pageSize for a table widget is calculated dynamically based on the incoming data. On client-side pagination, this number depends on the height of the table widget while for server-side pagination, this depends on the incoming data. Hence, to reduce any confusions, on first page load, the Appsmith framework doesn't expose this information to the user.
As a user, incase you wish to use the Table.pageSize property in an action, please set a default value via the dynamic binding as well. Example below:
{
  "pageSizeInAPI": {{ Table1.pageSize || 10 }}
}


RuntimeError: This event loop is already running

Getting RuntimeError: This event loop is already running in a Jupyter notebook.
2020-07-01 00:00:00
RuntimeError                              Traceback (most recent call last)
 in ()
17
18
---> 19 twint.run.Search(c)
20 dfunsorted = twint.storage.panda.Tweets_df
21
3 frames
/usr/lib/python3.6/asyncio/base_events.py in run_forever(self)
423         self._check_closed()
424         if self.is_running():
--> 425             raise RuntimeError('This event loop is already running')
426         if events._get_running_loop() is not None:
427             raise RuntimeError(
RuntimeError: This event loop is already running
This code was running well for weeks and died.

Also I have the same error. Someone has the solution. Please !

This is the solution. To Import the following library into script of scraping
import nest_asyncio
nest_asyncio.apply()


Question about eval code

https://github.com/zju3dv/SMAP/blob/9fbcbe4ee2cd6f6d6d6a4e5a05a637629cb5b2e1/lib/eval/mupots_smap.m#L55
I have no idea about the difference about 'annot3' and 'univ_annot3', and why did you use the 'univ_annot3'?  I would so appreciate it if you could give help.

Actually we follow Moon and the original code of MuPoTS dataset. The difference between these two type of annotations seems subtle through visualization, which we are also not sure about.


Label in Root menu showing ???

The label field for the top menu is showing "???" instead of the linked menu's name.
https://i.ibb.co/9bK46RG/2020-05-02-14-25-28.png
The menu.xml file used: https://pastebin.com/hRPDDyWL

Thank you.
The issue occurs due to the missing default namespace. I will fix this in xml loading.

Should be fixed now.


learning rate

in train_cls.py,when the learning rate is set to 0.1,the loss is increasing,so I tried to set it to 0.01,it works,,so can you verify the learning rate in train_cls.py and train_aff.py?Thanks in advance!

That should work fine. Perhaps there is a problem while loading the pre-trained model. Could you check (https://github.com/jiwoon-ahn/psa/issues/1)?

modelA and modelA1 doesn't make difference,for me the learning rate need to be set to 0.01,after train for a night,the loss of validation decreased to 0.79,it seems works.
By the way, in train_cls.py,line133 and line 142,the "if...else..."really confused me,I think I understand what you mean,in order to be more clear,could you revise it ?

modelA and modelA1 doesn't make difference,for me the learning rate need to be set to 0.01,after train for a night,the loss of validation decreased to 0.079,it seems works.
By the way, in train_cls.py,line133 and line 142,the "if...else..."really confused me,I think I understand what you mean,in order to be more clear,could you revise it ?

The learing rate given in the tutorial is only for VGG-16.
It is not "if ... else" sentence, rather it is "for ... else" sentence. I don't see any problem in there.
But the code is not perfect. It does contain many typos, grammar errors, etc.The best way to fix it is to fork yours.

Thanks for your reply,it works fine now.


Add dataSourceViewId in agent_data_source_configurations

Description

This PR introduces the dataSourceViewId column to the agent_data_source_configurations table. Currently, dataSourceViewId is inferred from the selected data source, defaulting to the view within the workspace vault, and is not passed in the API call yet. This is a temporary solution to transition our logic to data source views. Additionally, we need to update the existing index in data_source_views to include a composite index on workspaceId, dataSourceId, and vaultId.
Risk

Deploy Plan

[ ] Run the SQL migration

This PR assumes a view for all data source which is not what was planned as discussed https://dust4ai.slack.com/archives/C050SM8NSPK/p1722368349079209?thread_ts=1722332810.418999&cid=C050SM8NSPK
Let's converge on this discussion before moving forward here.

This PR assumes a view for all data source which is not what was planned as discussed https://dust4ai.slack.com/archives/C050SM8NSPK/p1722368349079209?thread_ts=1722332810.418999&cid=C050SM8NSPK
Let's converge on this discussion before moving forward here.

Updated based on the discussion.


[BUG] Directories > Risk of Rain 2 Install opens the modmanager install folder

Describe the bug
When selecting Directories > Risk of Rain 2 Install, an explorer window opens that points to the Mod Manager install directory instead.
To Reproduce
Steps to reproduce the behavior:

Open the Mod Manager
Click on Directories in the menu bar
Click on Risk of Rain 2 Install

Expected behavior
The Risk of Rain install folder should be opened.
Desktop (please complete the following information):

OS: Windows
Version 1.0.3

is this modloader deprecated? the stale bot is running rampant in this repo.


PR for bp_finish at end of atomic_demo

Hi, I'd like to make a PR for atomic_demo. When running it, it counts up completed instructions until my simulator runs out of memory. It needs to have a call to bp_finish at the end.

Hi, sounds like a good change. The tests are located in this repo: https://github.com/black-parrot/bp_tests
Please make the PR there


Use a threadpool to handle incoming requests

Adds a pool of worker threads to handle incoming requests. Uses a bounded channel to pass incoming requests to each worker. Closes #24.
Alternatives
This is an alternative to #25 which uses a semaphore to limit the number of requests in flight but still spawns a thread per request. This version uses existing dependencies instead of rolling our own semaphore.
There's another (easy) alternative to this approach that doesn't use a channel to pass the incoming UnixStream to worker threads:
    let pool = ThreadPool::new(N_WORKERS);

    for stream in listener.incoming() {
        match stream {
            Ok(stream) => {
                let logger = logger.clone();
                pool.execute(move || handle_stream(logger, stream));
            }
            Err(err) => {
                error!(logger, "error accepting connection"; "err" => %err);
                break;
            }
        }
    }

Calling pool.execute like this doesn't apply any backpressure. ThreadPool is build on std::sync::mpsc unbuffered channels so pool.execute never blocks. Using this means we have no signal we can use to do something (log? crash the process?) if things get slow.
On the plus side, this approach is less code and handles panics gracefully - ThreadPool makes sure there are always N_WORKERS threads in the pool. With the approach in the PR, on panic we'll kill a worker thread but nothing starts a new worker task.
I don't have a strong preference between the threadpool approaches, but they both seem better than #25. The pool.execute version requires the least code but doesn't let us detect a hang and crash.

Closed in favor of #28


Create icon for change privacy modal window affecting other users

Or we can use the same we have in the privacy window.

#1745

/ cc @viddo

IMO 1st one.

I don't have a strong opinion on any of them ;) :shipit:

In that cae, 1st one :smile:


[locale] es: Update month and week names

Update to capital letter the first letter of months and days.

@jsegra change only src/locale/es.js and src/test/locale/es.js.

@julionc any comments?

In Spanish we capitalize proper names for people, places and so on. The names of months and weekdays are written in lower case.
See #2497 discussion - Spanish Source
Remember, The first word of a sentence, or of a fragment, begins with a capital letter.
In that case, take a look at the following example:
var chosenLocale = 'es';

moment.locale(chosenLocale);

var __weekdays = moment.weekdays().map(function (days) {
	return days.charAt(0).toUpperCase() + days.slice(1);
});

moment.updateLocale(chosenLocale, {
	weekdays: __weekdays
 });

document.body.innerHTML = moment().format('dddd, LL'); // Martes, 24 de octubre de 2017

Want more info? Here's an article that explains which words are capitalized in Spanish.

@julionc thank you!

But what happends if a sentence starts with July. First letter of any sentence should be Upper case


fix: duplicate null | null in union types

Fixes: https://github.com/hey-api/openapi-ts/issues/968

Can you add tests? It's hard to say whether this works without them

Done, can you recheck?

@vkuprin if you're curious, I cleaned this up in https://github.com/hey-api/openapi-ts/pull/1095


README.md generator and Web Scenario(s)

Any plans for README.md generator to also include Web Scenario(s)?

I think it's possible. But only when generating new files.


Basic Deployment: Region Filtering is not working correctly

Description
The region filtering in the basic configuration is not working correctly. it's only available for deployment when the region is either Asia or Europe but it doesn't work with Africa, Oceania, or Americas even though there are multiple nodes available in each of these regions according tho the explorer.
Get Mastodon.webm
and according to the statistic page and map distribution there are nodes in each of these regions.

North America: 1000+ Nodes
South America: 3 Nodes
Africa: 10 Nodes
Oceania: 70 Nodes

After some investigation discovered that nodes Filter only returns first 50 nodes that fulfil the requirements.
If we pick farm brautech-3bot(2317) and pick region Africa
We'll find nodes (3882, 3954) which proves the issue
@AhmedHanafy725 @mohamedamer453

The issue is still valid. All the mentioned regions still report that there were no nodes found.

After some investigation discovered that nodes Filter only returns first 50 nodes that fulfil the requirements.

and indeed as mentioned above this was the issue because when i changed the disk to 1000 instead of 100 it returned the first 50 nodes that had 1000 gb of sru, then i selected Americas in the region and it returned these nodes.

steps to verify :
1-go to mastodon
2-insert your credentials
try to choose a region if it is not available

3-go to advanced try to choose the farm and the nodes and make sure that they are down or filled


Add Speed Control

🚀 Feature Request
Description
Like most modern players, there should be speed control to either increase/decrease the reproduction velocity
Implementation details
Use the settings menu to set this control
Potential caveats
N/A
Acceptance criteria

[ ] User can toggle between reproduction speed

Additional info:
Speed Control: 0.75 | 1 | 1.25 | 2.
The playback speed list is composed of the following or a subset: 0.25x | 0.5x | 0.75x | Default (1x) | 1.25x | 1.5x | 1.75x | 2x
It can be accessed in the Settings Menu on the Playback Speed entry
The display mode is different from Portrait and Landscape. On Portrait we need to present in a Modal/Drawer


Model GC bias and mappability  explicitly

Account for GC (and perhaps mappability), then feed the coverage into the PoN.
More ambitiously, replace the PoN with a Bayesian PCA and combine this with known biases in a single graphical model.

Assigning to @achevali , but assuming that @davidbenjamin will be working on it, as well.

Mappability can be optional for beta release.

Closed by PR #532.  Issues for mappability and integrating GC bias in the new coverage model may be created later.


Compile Problems referencing incorrect source lines

Has anyone ever had an issue where the compile problems are referencing the incorrect line? I assume it's probably related to some RPG copy books in my program causing this extension to incorrectly interpret the compile listing. I've tried restarting VS Code and reconnecting to the i, but it doesn't seem to fix this issue.
To simulate this issue, I removed a ";" at the end of my If statement below. Error is recognized in Problems console, but selecting the RNF7030 error references the in correct line (referencing my "dcl-pi" line 204 instead of line 242 where the error exists.

Oh yes, absolutely a problem with SQLRPGLE and copybooks. I would love if you were able to recreate this and paste all the code here so I can recreate it.
Liam

I've seen an issue like this in RDi where certain compile commands were causing the line numbers to be incorrect in the EVENTF. I think its worth looking at the compile commands used for this, specifically OPTION, RPGPPOPT and COMPILEOPT.

Same as #405 so I will close it.


Support multi-question challenges

Add support for challenges of the style in the certification exam, where subsequent questions ask you to make modifications on the part from one question to the next. This could enable us to explore research questions related to design intent.

[x] Add option in questioner database for multi-part challenges

Still don't support multi-step assemblies challenges as of now


Clean up Clang compile flags

I realized that clang's default diagnostics have changed significantly since I last looked through the list.
CFLAGS is much smaller now, and it's great.

bors r+


Modsec rule causes nginx cu spin up a lot of worker processes

Describe the bug
Hi there, we run Nginx in a Docker container as a sidecar in a pod in a Kubernetes cluster.
We have the ModSec module (version 3.0.3) enabled for Nginx.
In our Nginx configuration, we set the number of worker processes to be 16 (we have 16 cpu cores on our machines):
    worker_processes 16;
    events {
      worker_connections 1024;
    }

With modsec disabled, it all works fine, we can see in the access logs that requests are processed fine, there are 16 worker processes running and the memory usage is not higher than 200-300MB.

However, when the modsec is enabled, the initial number of worker processes in nginx is 16, but over a period of 12 hours, the number of worker processes increases whenever a given modsec rule is matched by an HTTP request (in our case it is ruleID: 920350).

The number of worker processes increases until the memory limit (2GB, set at a kubernetes level) is met (at that point, nginx started up to 500 worker processes!)
When it hits the memory limit, nginx stops handling requests (according to the access log, we cannot see any requests being handled anymore). Furthermore, the issue is causing the entire machine where the nginx container is running to crash.
My question is: is there something at the modsec level that causes nginx to spin up a lot more worker processes (around 500) than configured (16) when the modsec rule 920350 matches http requests? Could it be a resource leak?
Logs and dumps
Output of:

NGINX access log example when a given HTTP request is matched to modsec rule 920350

"GET /healthcheck HTTP/1.1" 200 0 "-" "ELB-HealthChecker/2.0" "-"
{"transaction":{"client_ip":"<IP_HIDDEN>","time_stamp":"","server_id":"<replaced>","client_port":<replaced>,"host_ip":"<replaced>","host_port":<replaced>,"unique_id":"<replaced>","request":{"method":"GET","http_version":1.1,"uri":"/healthcheck","headers":{"Host":"<IP_ADDRESS>:12345","Connection":"close","User-Agent":"ELB-HealthChecker/2.0","Accept-Encoding":"gzip, compressed"}},"response":{"http_code":200},"producer":{"modsecurity":"ModSecurity v3.0.3 (Linux)","connector":"ModSecurity-nginx v0.1.1-beta","secrules_engine":"DetectionOnly","components":["OWASP_CRS/3.0.2\""]},"messages":[{"message":"Host header is a numeric IP address","details":{"match":"Matched \"Operator `Rx' with parameter `^[\\d.:]+$' against variable `REQUEST_HEADERS:Host' (Value: `1<replaced_numberic_ip_and_port>' )","reference":"o0,15v32,15","ruleId":"920350","file":"/usr/local/owasp-modsecurity-crs/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf","lineNumber":"777","data":"<replaced>","severity":"4","ver":"OWASP_CRS/3.0.0","rev":"2","tags":["application-multi","language-multi","platform-multi","attack-protocol","OWASP_CRS/PROTOCOL_VIOLATION/IP_HOST","WASCTC/WASC-21","OWASP_TOP_10/A7","PCI/6.5.10"],"maturity":"9","accuracy":"9"}}]}}

To Reproduce
Steps to reproduce the behavior:
Start nginx with modsec enabled and ensure that ruleID: 920350 is present.
Configure nginx to use maximum 16 worker processes (or a similar, fixed number)
Start multiple HTTP requests that match that given rule (ID: 920350)
Expected behavior
Nginx will not spin up more than 16 worker processes in total (16 is the number of worker processes configured in nginx).
Server (please complete the following information):

ModSecurity version: 3.0.3 connector: ModSecurity-nginx v1.0.0
WebServer: NGINX (nginx version: nginx/1.15.4 built by gcc 4.8.5 20150623 (Red Hat 4.8.5-36) (GCC) built with OpenSSL)
OS (and distro): CentOS 7

Rule Set (please complete the following information):

Running any public or commercial rule set? rule set OWASP CRS 3.0.2
What is the version number? 3.0.2

Additional context
Add any other context about the problem here.
Note: I have raised a bug in owasp-modsecurity-crs as well: https://github.com/SpiderLabs/owasp-modsecurity-crs/issues/1649

Server (please complete the following information):
ModSecurity version: 3.0.3 connector: ModSecurity-nginx v0.1.1-beta
Sorry for the question, but are you sure you have this version?

the connector version we use is actually v1.0.0, thanks for the heads up!
interestingly enough, in the nginx access logs it appears as "connector":"ModSecurity-nginx v0.1.1-beta"

Could you try with the code from current master?

Hi @davidbalazs ,
I have tried a few things to try to recreate what you've seen but have not been successful so far (although my test environment is not particularly close to your deployment).
Clarification question:  Do I understand correctly that if you remove rule 920350, you don't see the problem any more?

hi @martinhsv to work around the issue, I whitelist the endpoint that is being hit via numeric ip (that used to trigger the rule 920350):
    SecRule REQUEST_URI "@contains /healthcheck" \
    "id:1005,\
    phase:1,\
    pass,\
    nolog,\
    ctl:ruleEngine=Off"

If I whitelist this endpoint, then all the healthcheck requests that are coming via direct IP won't be intercepted anymore by modsec and the memory remains constant + there are exactly 16 worker processes running in nginx (which is the desired number)

Hi @davidbalazs ,
Thanks, that clarifies your workaround.
What I would be interested in doing, however, is narrowing down whether processing of the rule itself is what is triggering the bad result, or if the content of the request is causing the bad result irrespective of whether that particular rule is active.
If you are willing to try an experiment or two, my first suggestion would be to alter the rule you are currently using to whitelist.  Instead of using 'ctl:ruleEngine=Off', try 'ctl:ruleRemoveById=920350'.  That would result in those requests still otherwise being processed by ModSecurity, but avoiding that one particular rule (and any processing due to that detection including logging).  If the problem does not occur when using ctl:ruleRemoveById, then that is a safer (from a security standpoint) customization than turning off the engine entirely for those requests.
Also, could you please clarify/confirm the version of ModSecurity that you're using.  You mentioned v3.0.3.  Is that from a distro package?  Or is it built directly from the v3.0.3-tagged commit in github?  Or is it possibly from a more recent github 'v3/master' commit that still happens to be labelled as 3.0.3?

Thanks @martinhsv
I will try that next week.
The ModSecurity version is v3.0.3 and it is built from the v3.0.3 tagged commit in github

Hi @davidbalazs ,
You could also consider proceeding with the suggestion from @airween , and use the code from HEAD of v3/master.
There have been quite a few bug fixes implemented over the past year+, at least one of which might be relevant ( https://github.com/SpiderLabs/ModSecurity/issues/1927 ). The symptoms reported in that bug aren't exactly the same as what you're seeing, but there are a few points of commonality that make we wonder if that fix might also have resolved your issue.

hi @martinhsv
I have tried to whitelist the specific rule as suggested (ctl:ruleRemoveById=920350) (but still using ModSecurity v3.0.3) and I can confirm that Nginx was working properly over this period. The number of worker processes remained constant to 16 (which is the configured number) and the memory remained constant as well.
I will try the latest master version as well and I will let you know.
Thanks!

Hi @davidbalazs ,
I was just curious if you had had opportunity to try current v3/master code.  Thanks.

hi @martinhsv sorry for the long delay, I was involved in something else in the meantime, but I have some great news to share:
with modsecurity":"ModSecurity v3.0.4 (Linux)
and ModSecurity-nginx v1.0.1 connector, it worked fine.
I ran the same test over the weekend and the number of processes remained constant and the memory didn't go higher than 200MB
Thanks for the assistance!

Hi @davidbalazs ,
That's great to hear.  Thanks for posting the update.


Has EF Core client been implemented to allow complex models?

I have been looking for a solution to syncing offline data from a mobile app to a remote service.  In my research everything seems to show that the sync process can only handle single, simple, table entities.
Our application has multiple tables that are treated as a single entity, i.e. contains navigation properties, one to many, many to many etc. and I feel saving them as individual tables would be unsafe, we could end up only saving half of the entity.

Does azure mobile apps in an offline mode support this sort of functionality, and if so, do you have an example or blog somewhere? I read it was not available in version4, but might be available in version 5, so was wondering did it happen?
Many thanks in advance for your feedback.

You can't preserve navigation properties in an offline case.  You have to synchronize the entities, then set up the navigation yourself.  The reason for this is because a synchronization may break in the middle (network goes down, for example) which results in the navigation properties being broken.

But by syncing the entities individually there is a finite time when the entity state is incomplete on the server, i.e. invoice header has been sync'd but the invoice lines have not, this then gets sync'd to other devices, and they have only partial data, which is very dangerous, especially of one of them is processing the payment for the invoice, but only knows about half of the items purchased.
That is the whole point of saving the invoice plus items as a single transaction is all succeed or all fail.   I am sure there are many other use cases for this type of behaviour also.
I find it very disappointing, when Microsoft is pushing mobile apps through Maui and Blazor, they do not have a complete, off the shelf, solution for offline data and syncing.


Bug:

Describe the bug
No longer able to authenticate to cameras
To Reproduce
Camers are off line, all attempts to reauthenticate, then delete and re-add fail.
Expected behavior
I expect it to work
Log
If applicable, add error logs.
Nothing in th elogs
Camera (please complete the following information):

Device Model: C200
FW: 1.0.17 Build 20111 Rel.74534n(4555)

Using stream component
yes
Camera works through onvif component OR different cameras work in general
yes
Camera has all attributes filled out properly in developer tools
yes
HASS Environment
Pi3B Supervised
System Health

version
2021.1.5

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

virtualenv
false

python_version
3.8.7

os_name
Linux

os_version
5.4.79-v7

arch
armv7l

timezone
Europe/London

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 5.10

update_channel
stable

supervisor_version
2021.01.7

docker_version
19.03.13

disk_total
57.8 GB

disk_used
4.2 GB

healthy
true

supported
true

board
rpi3

supervisor_api
ok

version_api
ok

installed_addons
Terminal & SSH (8.10.0), Check Home Assistant configuration (3.6.0), Duck DNS (1.12.4), File editor (5.2.0), Home Assistant Google Drive Backup (0.103.1)

Lovelace

dashboards
1

mode
storage

views
8

resources
4

Additional context
Just stopped working today.

Scratch that, multiple reboots of cameras and HA finally for them working again..., what a pain (great integration BTW...)


AssemblyName attribute of iOS library has ambiguous value

Expected Behaviour
When I use both Adobe.AEPAssurance.iOS and Adobe.ACPUserProfile.iOS in my project, both libraries are available to me and work as expected.
Actual Behaviour
When I use both Adobe.AEPAssurance.iOS and Adobe.ACPUserProfile.iOS in my project, NuGet discards the one with the lower version number because both libraries compile to "NativeLibrary.dll".
Reproduce Scenario (including but not limited to)
Every build of iOS projects using both Adobe.AEPAssurance.iOS and Adobe.ACPUserProfile.iOS.
Steps to Reproduce

Create new Xamarin.Forms project
Add NuGet Adobe.AEPAssurance.iOS to iOS platform project
Add NuGet Adobe.ACPUserProfile.iOS to iOS platform project
Probably reference both in your code
Build iOS project

Platform and Version

Xamarin.Forms for iOS
Adobe.AEPAssurance.iOS 1.0.0
Adobe.ACPUserProfile.iOS 0.0.2

Sample Code that illustrates the problem
I cannot post any actual code, I'm afraid.
Logs taken while reproducing problem
Encountered conflict between 'Reference:/Users/XXX/.nuget/packages/adobe.acpuserprofile.ios/0.0.2/lib/xamarinios10/NativeLibrary.dll' and 'Reference:/Users/XXX/.nuget/packages/adobe.aepassurance.ios/1.0.0/lib/xamarinios10/NativeLibrary.dll'. Choosing 'Reference:/Users/XXX/.nuget/packages/adobe.aepassurance.ios/1.0.0/lib/xamarinios10/NativeLibrary.dll' because AssemblyVersion '<IP_ADDRESS>' is greater than '<IP_ADDRESS>'.

We have a question about if you need to use the UserProfile features in your project.
We will follow up this issue in https://github.com/adobe/xamarin-acpuserprofile/issues/3.
Closing this one.

The AssemblyName of the iOS library is still "NativeLibrary" which looks like an oversight and should be fixed.

The clash between UserProfile and Assurance should be fixed after the UserProfile update.  We will fix the AssemblyName for Assurance when there is a new update for Assurance.


Rewindable event handler separation

This should give us type-safe rewindable and non-rewindable EventHandler implementations.
Non-rewindable implementations will not be able to throw RewindableException but will be able to implement EventHandler::setSequenceCallback and the opposite for rewindable implementations.
This will fix #437

RewindableException extends Throwable
Extending Throwable :(
https://stackoverflow.com/a/2756001
And if we're going that path, it isn't an Exception any more.

RewindableException extends Throwable
Extending Throwable :( https://stackoverflow.com/a/2756001
And if we're going that path, it isn't an Exception any more.

I also questioned this offline - my understanding of the reasoning here is that we have no way of allowing the regular handlers to throw an arbitrary exception but not a RewindableException. Making it an Error wouldn't work, as these are unchecked, so the only other option would be to change the signature of onEvent() in EventHandler.
Something like this would work in theory:
void onEvent(T event, long sequence, boolean endOfBatch) throws DisruptorException;

but that would require catching and wrapping every Exception, and would probably make migration onto 4.0 painful.

On the topic of exceptions and use of Throwable: I think it's justified here as it's a specific exception we want to raise in a certain circumstance.
There's probably some major refactoring I'd like to make in a future major release to make EventHandler::onEvent return something as right now we're straying down the path of exceptions for control flow. Another case in #397
For now I think it's a fair trade off as the RewindableException is not something that should bubble out past the BatchEventProcessor and concerns of it not being caught by those only catching Exception should be mostly moot in this case.

Man this interface is appalling for reviewing.


function uuid_generate_v4() does not exist

Hello again @glutamate
I don't get how to automatically get a new ID.
I though UUID would fix it, but it looks like it failed to install:

If you are using saltcorn.com, this has now been fixed
If you are self-hosting, You can run the following command as root: sudo -iu postgres psql -U postgres -d saltcorn -c 'create extension if not exists "uuid-ossp";'
if you are self-hosting on digitalocean and don't know how to use SSH, I can't do anything about your existing droplet. When the droplet is next updated (following commit https://github.com/saltcorn/saltcorn/commit/476d462d85f77ad6b50e6ac0f765a2bd91a8af99) You will need to backup, create a new droplet, and restore)

Thanks!

@glutamate unfortunately it's not working on a container (no sudo, already root).

Within the container, I tried:
root@3b48c5b5b1bb:/opt/saltcorn/packages/saltcorn-cli/bin# ./saltcorn -c 'create extension if not exists "uuid-ossp";'
 ›   Error: command -c not found

@glutamate not sure why the bin on the container doesn't recognize -c
Any other way to add it?

OK, my bad, it is working in the db container using:
su postgres
psql...
I get
NOTICE:  extension "uuid-ossp" already exists, skipping
CREATE EXTENSION

So I guess it is installed, but uuid is not generated when adding a row through:

Is the uuid_generate_v4 postgres function looks like that in a working environment using Adminer (public > routines > alter)?

No length?

Tested on a brand new 0.6.0-alpha.0Latest
By default, it's not present in a slatcorn-db container:

Once installed, it looks like the function is working in postgres server itself:

After installation I restarted both containers.
Only saltcorn still doesn't use it.

I am not 100% sure about these things, but this is what I think:
after you have reset the scheme on the command line with saltcorn reset-schema (possible running this inside docker with docker run), you should run the sql command create extension if not exists "uuid-ossp"; as the postgres user (i.e. the database superuser) in the saltcorn database. This could be done with the database admin tool you use. But saltcorn cannot do this on its own because it does not have database superuser access
See what happens here in the digital ocean image creation: https://github.com/saltcorn/saltcorn/blob/master/deploy/digitalocean-marketplace/files/var/lib/cloud/scripts/per-instance/01-set-secret#L21
This is last thing that happens before the process is started and made available for the user.


Misleading content at https://www.openhistoricalmap.org/help

Majority of that channels are OSM-only and OHM-specific content is offtopic there (except cases when it is about OSM).

See: https://github.com/Open-Historical-Map-Labs/ohm-website/pull/4

Fixed. Closing.

Fixed. Closing.


For super build, installed libraries can conflict with those in $HOME/local

I get non-fatal warnings like the following:
CMake Warning at google/cloud/storage/examples/CMakeLists.txt:56 (add_executable):
  Cannot generate a safe runtime search path for target
  storage_notification_samples because files in some directories may conflict
  with libraries in implicit directories:

    runtime library [libcares.so.2] in /usr/lib64 may be hidden by files in:
      /home/tom/local/lib
    runtime library [libz.so.1] in /usr/lib64 may be hidden by files in:
      /home/tom/local/lib

  Some of these libraries may not be found correctly.

These warnings do not appear in the build output for the Kokoro build. I suspect this is because the conflicting libraries aren't installed by the package manager in the Dockerfile.
I am unsure how dangerous this warning is, but might be worth fixing.

As an addendum, I'm currently trying to add the super build to google-cloud-cpp in the readme Dockerfile. When using -DCMAKE_BUILD_TYPE=Debug, I observe the following:
On my system, I see that it finds my system GTest and not the one in $HOME/local:
-- Found ZLIB: /home/tom/local/lib/libz.so (found version "1.2.11")
-- Found ProtobufTargets: TRUE
-- Found Protobuf: /home/tom/local/lib/libprotobuf.a;-lpthread (found version "3.7.1")
-- Found OpenSSL: /usr/lib64/libcrypto.so (found version "1.1.1c")
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WALL
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WALL - Success
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WEXTRA
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WEXTRA - Success
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WERROR
-- Performing Test GOOGLE_CLOUD_CPP_COMPILER_SUPPORTS_WERROR - Success
-- Performing Test CXX_SUPPORTS_COVERAGE_FLAG
-- Performing Test CXX_SUPPORTS_COVERAGE_FLAG - Success
-- clang-tidy found: /usr/bin/clang-tidy
-- Found GTest: /usr/lib64/libgtest.so

When GTest is not installed by the package manager (i.e, in the Dockerfile), then it can't find it at all:
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find GTest (missing: GTEST_LIBRARY GTEST_MAIN_LIBRARY)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindGTest.cmake:197 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/IncludeGMock.cmake:56 (find_package)
  cmake/GoogleCloudCppCommon.cmake:46 (include)
  google/cloud/CMakeLists.txt:62 (include)

even though the artifacts exist in $HOME/local. I suspect the way we're looking for the debug files in IncludeGMock is problematic for the super build.

I deleted the previous comment because I can no longer reproduce it. Maybe it's a heisenbug?

Looking again at the warnings, it appears to only be complaining about google/cloud/storage and libcares and libz. Looking at the link one for one of the targets:
/usr/bin/ccache /usr/lib64/ccache/c++
CMakeFiles/storage_default_object_acl_samples.dir/storage_default_object_acl_samples.cc.o
-o storage_default_object_acl_samples -Wl,-rpath,/home/tom/local/lib
../libstorage_client.a ../../libgoogle_cloud_cpp_common.a
/home/tom/local/lib64/libcrc32c.a /home/tom/local/lib/libcurl.so
-ldl /usr/lib64/libcares.so /usr/lib64/libssl.so /usr/lib64/libcrypto.so
/usr/lib64/libz.so -lpthread /usr/lib64/libssl.so /usr/lib64/libcrypto.so
/home/tom/local/lib/libz.so

Notice how it's linking against both /usr/lib64/libz.so and /home/tom/local/lib/libz.so.

The culprit seems to be the curl external project. Observe:
cmake-out/external/curl/src/curl-project-build/CMakeCache.txt:CARES_LIBRARY:FILEPATH=/usr/lib64/libcares.so
cmake-out/external/curl/src/curl-project-build/CMakeCache.txt:ZLIB_LIBRARY_RELEASE:FILEPATH=/usr/lib64/libz.so

Comparatively, Protobuf for example finds the correct ZLIB:
cmake-out/external/protobuf/src/protobuf-project-build/CMakeCache.txt:ZLIB_LIBRARY_RELEASE:FILEPATH=/home/tom/local/lib/libz.so

This problem does not exist for the readme builds in google-cloud-cpp (sudo docker build -f ci/kokoro/readme/Dockerfile.fedora .), which tests the external projects.

Ack.  Maybe we should consider removing libcurl and zlib from the list of external projects, and (like openssl and the C++ library) just assume that they are provided by the OS.  This is reasonable on Linux, mostly Okay on macOS, I am not sure how well it works on Windows.
On the other hand, we assume that OpenSSL is installed on Windows, typically via vcpkg, so maybe we can assume the same for libcurl and zlib?


adjust spec for new standard styling

Description
Brought over the scripts and styling info used for the Advancing PDF documentation.
Update the spec to take advantage of it

https://github.com/adobe/json-formula/pull/83


Cannot get studio.

I tried to get a studio but it returned this error:
Traceback (most recent call last):
File "", line 1, in
File "/home/runner/Broadcasting/venv/lib/python3.8/site-packages/scratchclient/ScratchSession.py", line 82, in get_studio
return self._to_studio(
File "/home/runner/Broadcasting/venv/lib/python3.8/site-packages/scratchclient/ScratchSession.py", line 60, in _to_studio
return Studio(data, self)
File "/home/runner/Broadcasting/venv/lib/python3.8/site-packages/scratchclient/Studio.py", line 12, in init
self.owner = data["owner"]
KeyError: 'owner'
This was my code:
import scratchclient
session = scratchclient.ScratchSession(USER, PASS)
studio = session.get_studio(ID)
[insert the other code here]
Could somebody help? That would be very appreciated.

This isn't your fault.. it's a problem in the package

Why don't you try manually requesting to the API link? Or use another package? I can help you to do both

I tried some others packages and they didn't work sadly. Maybe i chose the wrong ones.
I think i will manually request to the API. What is the URI and required parameters?
Thanks in advance.

Why don't you try manually requesting to the API link? Or use another package? I can help you to do both

I tried some others packages and they didn't work sadly. Maybe i chose the wrong ones. I think i will manually request to the API. What is the URI and required parameters? (i don't know much about the scratch API lol) Thanks in advance.

Um I think I shouldn't say about other packages in this repo lol

I have found the URI i needed. Still thanks for proposing the idea of making the request myself. Why didn't i think of that lol. Anyway, it works now.


Fix testNoBrokerResource test

Description
This PR fixes testNoBrokerResource test because of the changes introduced from this PR:
https://github.com/apache/pinot/pull/7470
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

I saw this was flaky on another branch. Can you explain the fix? It passes sometimes in its current state, how will it not continue to fail sometimes by changing the assertions?

Codecov Report

Merging #7478 (1395f15) into master (8aeca69) will increase coverage by 7.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7478      +/-   ##
============================================
+ Coverage     62.59%   69.82%   +7.22%
+ Complexity     3289     3285       -4
============================================
  Files          1510     1125     -385
  Lines         74993    53259   -21734
  Branches      10947     8027    -2920
============================================
- Hits          46942    37187    -9755
+ Misses        24672    13432   -11240
+ Partials       3379     2640     -739

Flag
Coverage Δ

integration2
?

unittests1
69.82% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeca69...1395f15. Read the comment docs.

I saw this was flaky on another branch. Can you explain the fix? It passes sometimes in its current state, how will it not continue to fail sometimes by changing the assertions?

This failed test is caused by a recent commit merged today (#7470). It won't appear after you rebase with the latest master branch since this PR has already been merged.


Update the user management code to handle project set user access management

Describe the Issue

we want to include user management to all the available roles in aws through product registry

Additional Context
Add any other context, attachments or screenshots
Acceptance Criteria

service design is done for the new UI changes
Nats message format is designed
Usermanagement code is modified to handle all the roles

Need to discuss this issue with Nick C to validate it

We are no longer pursuing this architecture


Pressing 7 to go to the Chart Editor no longer works in the latest action build

Describe your bug here.
even when i set the 7 event to none it doesnt work
https://github.com/JordanSantiagoYT/FNF-PsychEngine-NoBotplayLag/assets/117042313/e502de39-cacb-495a-ba1f-72ae7de99f1c

Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
nope
If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None

okay so not only do I know the reason why, I also know a fix, it's due to a little oversight by not adding a missing case for "None"

latest commit fixed this


[easy] Simplify update parameters callback

[easy] Simplify update parameters callback
Have updateParameters take a JSONObject. Makes it much cleaner to use elsewhere.
ParametersRenderer simply converts its ParametersArray to JSONObject before triggering the update.

Stack created with Sapling. Best reviewed with ReviewStack.

-> #674
#673

I think I ran yarn build, and forgot to remove the files. Does it matter if these are updated?

I think I ran yarn build, and forgot to remove the files. Does it matter if these are updated?

I don't think so. They probably should be removed/excluded from git actually, but I don't think they'll cause issues?


Remove fs.statSync call

https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/window.ts#L159
I don't see a reason to have this there, can we make this async?

Nevermind... I see why now... dnd is hard.

Actually... couldn't we make the (async) call after you drop? And show a hover feedback any way?

Now using async, I think it is fast enough that you do not notice any delay in the hover.


[blackjack] Aces aren't always calculated correctly

once an ace is set as 11, it is always 11

Actually fixed in b0a6ccce65a6fb4ea61bb8b0d75941c1fccab4c0


Check security-flag on node-list

As part of the versions-check, check the security-flag from node-list and stop process execution if an unsecure version is being used.
Whenever node releases a new version because of a security vulnerability within node (or npm), the release is flagged with "security": true. We can use this to make sure projects run a secure version of node/npm. More information about the security flag.
This is a follow-up ticket.

Has been merged. Thanks again @prothweil 🙏


update thirdreality smart plug

@greens
Hi, we have update our device, thirdreality smart plug, now, our plug have power meter. But in smartthings APP, it will not show the power.
Does this pull request will make our plug show the power? If not, what i need to change?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Newly-installed devices will have the Power Meter capability displayed.
But I wonder what you mean by "updated the device"? Is there a new firmware? Devices on the old firmware probably cannot report power consumption still, is that right?

yes

@greens please help to review the merge require, thanks

@weihuan1111 unless someone manages to buy and install a device still using the v1 firmware. Or they have a v1 installed and remove and re-add it. Then they'll see a capability their device does not support.
I'd recommend building in some functionality to handle the version of the device. You can see how to query this information and use a sub-driver based on it in this driver and its sub-driver: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/tree/main/drivers/SmartThings/zigbee-window-treatment/src/axis

@greens I have tested locally, both v1 and v2 are work normally in this pull request.

@weihuan1111 I don't understand how that can be. If you install a v1 that does not support power meter, but it uses a profile that includes it, the user will see and empty power meter tile. Is that not correct?

@greens But now, our plugv1 and plugv2 use the same version, the difference is that v2 has the power function, everything else is the same. And we have tested locally, v1's on/off function, v2's on/off and power function are both used normally on smartthings.


Algorithm-Easy-5

Solve Utopian Tree, Sequence Equation and Find Digits

I want to do it in C++.

I can implement in java

I would like to implement in Python.


Gradle import fail,need help.

Hi awxkee, When I import through Gradle：implementation 'com.github.awxkee:avif-coder:2.0.6' an error occurs:
Null extracted folder for artifact: ResolvedArtifact(componentIdentifier=com.github.awxkee:avif-coder:2.0.6, variantName=null, artifactFile=/Users/eclipse/.gradle/caches/modules-2/files-2.1/com.github.awxkee/avif-coder/2.0.6/10d54edb6afc36d5dae19b8e07beca4d134f7756/avif-coder-2.0.6.aar, extractedFolder=null, dependencyType=ANDROID, isWrappedModule=false, buildMapping={__current_build__=/Users/eclipse/Develop/AndroidStudioProjects/wood-device}, mavenCoordinatesCache=com.android.build.gradle.internal.ide.dependencies.MavenCoordinatesCacheBuildService$Inject@204272f5)
do you have any suggestions？ thx

I don’t know how to fix it

I don’t know how to fix it

thx bro. by the way I referenced your component in the Android Java project. Is there any difference between the introduction of Java and Kotlin?

I never used this in Java project. However, there are should be no differences

ok, I'll try again. Anyway, thank you for this nice project!!!


US159929 Move Pagination to labs monorepo

Context for US159929: Migrate Pagination to the Labs Monorepo
The purpose of this PR is to move the code from pagination labs repo to the labs monorepo with the goal of eventually graveyarding the old repo once it's been move over and all of the references to the old repo are update to point to here instead.
There are a few changes between the code in the old repo and here, which include:

Simplifying and reusing code where possible
Replaced the use of d2l-input-text with d2l-input-number, since the pagination component was initially created prior to the d2l-input-number existing.
Changed the names of the events to match the d2l-labs-* format
Improved the format of the README file
Replacing some of the old tests with visual-diff tests, since the old repos didn't initially have them.
Updating lang term names to match the format used in this repo
Fixed an issue where the fraction was being flipped in RTL when it shouldn't be flipped (see here)

This PR should be ready for a @BrightspaceUI/gaudi-dev review!


Remember Last Used Pattern (feature)

As title.

Close because of https://github.com/ilime/Petal/issues/10#issuecomment-486522122

Reopen https://github.com/ilime/Petal/issues/22#issuecomment-492112297

Finish in v2.18.0


Can't work in nvim terminal

My pdf, office, picture preview of the effect are displayed like this, my nvim version is NVIM v0.7.2

Do you use Xorg or Wayland?

Do you use Xorg or Wayland?

i am use xorg now

Do you use Xorg or Wayland?

But I can preview the images normally using ranger and w3m

Do you use Xorg or Wayland?

Does ctpv image previews work in other terminals? Did you install ueberzug package?

Does ctpv image previews work in other terminals? Did you install ueberzug package?

yes, i installed, it is work in alacritty

Could you please send a screenshot showing that it works fine in Alacritty?

Could you please send a screenshot showing that it works fine in Alacritty?

This is alacritty work with ueberzug

Could you please send a screenshot showing that it works fine in Alacritty?

This is nvim terminal work with ueberzug, it is show nothing

e

Could you please send a screenshot showing that it works fine in Alacritty?

This is alacritty work with chafa, Cannot display properly

ee

Could you please send a screenshot showing that it works fine in Alacritty?

This is nvim terminal work whith chafa, Cannot display properly too

This is alacritty work with chafa, Cannot display properly

Actually, it is how image previews with chafa are supposed to look. It draws an image with terminal characters; this method works in every terminal and system but is of bad quality.
I've tested and ueberzug image previews work well in nvim terminal. Could you please share more information about your system? Linux distribution version, ueberzug version?

This is alacritty work with chafa, Cannot display properly

Actually, it is how image previews with chafa are supposed to look. It draws an image with terminal characters; this method works in every terminal and system but is of bad quality.
I've done some testing and ueberzug image previews work well in nvim terminal. Could you please share more information about your system? Linux distribution version, ueberzug version?

I found the reason, I made a mistake and ignored the existence of the terminal multiplexer.
I used neovim and abduco instead of tmux as my terminal taker and executed the following command
alacritty -e abduco -e '' -A nmux nvim +terminal

At this point opening lf does not allow you to use ctpv to preview the image properly.
Then when I don't use abduco:
alacritty -e nvim +terminal

I can preview the image with ctpv, everything works fine

This is alacritty work with chafa, Cannot display properly

Actually, it is how image previews with chafa are supposed to look. It draws an image with terminal characters; this method works in every terminal and system but is of bad quality.
I've done some testing and ueberzug image previews work well in nvim terminal. Could you please share more information about your system? Linux distribution version, ueberzug version?

I am using arch linux
❯ ueberzug version
18.1.9

❯ uname -a
Linux x550vc-yyy 5.18.16-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 03 Aug 2022 11:25:04 +0000 x86_6

❯ pacman -Q xorg-server
xorg-server 21.1.4-1

❯ pacman -Q neovim
neovim 0.8.0-3

❯ pacman -Q abduco
abduco 0.6-6

❯ pacman -Q alacritty
alacritty 0.10.1-2

❯ yay -Q lf
lf-bin 27-1

Do image previews work if you use tmux?

Do image previews work if you use tmux?

yes, it work

No issues with arch / alacritty / lf / chafa

Although the blockyness is chafa being lazy & quick. Ueberzug works fine too.

Yes, I think the problem is with abduco, as soon as you use it you can't preview the images, but its maintainer, martanne, stopped being active two years ago

I don't understand you btw. What's abduco ? I'm using chafa to preview images. I think you don't need abduco for chafa. It should work fine anywhere, since chafa only generates lowres.

abduco is a terminal multiplexer that does not preview images when working with neovim terminations

Yes, I think the problem is with abduco, as soon as you use it you can't preview the images, but its maintainer, martanne, stopped being active two years ago

You are right, it seems like abduco and ueberzug don't work well together and the issue is not on the side of ctpv.

Yes, I think the problem is with abduco, as soon as you use it you can't preview the images, but its maintainer, martanne, stopped being active two years ago

You are right, it seems like abduco and ueberzug don't work well together and the issue is not on the side of ctpv.

Yes, the maintainers of both programs are no longer active, so I'll close this issue for now. Thank you.

Then try tmux I guess.

Thanks, tmux is too complicated for me, I just need a simple terminal multiplex


maxNumThreads as user settings

Allow each user to set a maxNumThreads to limit the number of thread per project.
Ex: the versionned file "openedge-project.json" contains "numThreads": 10 but I want to limit to 2 threads without without impacting my colleagues

Allow each user to set a maxNumThreads to limit the number of thread per project.

Interesting idea. Note that settings can also be per workspace ( https://code.visualstudio.com/docs/getstarted/settings ).

Merged in main


[WFLY-13283] suspending WFTC transaction on response of REST-AT bridge

https://issues.redhat.com/browse/WFLY-13283

enhancing comments related to XTS filters and their ordering
https://issues.redhat.com/browse/WFLY-9455

replaces PR: https://github.com/wildfly/wildfly/pull/13140

@asoldano can you please take a look? This is an update of the of discussed PR#13140.

@asoldano is this one for you to review?

/retest

@asoldano do you think you may take a look, please?

@asoldano the changes in javadoc is releated in the regards as it talks about the filter ordering and it talks about wrongly to how the process goes. I joint the both changes to this one PR as they both are about filtering of the incoming messages and processing the translational context.
If you think I should create a new WFLY issue I can do so and create a separate PR. WDYT?

@bstansberry what do you think about merging this? :)

/retest

@ochaloup i kicked off CI again as it hasn't been tested for a while. If it's ok please merge it @asoldano

It passed before i went to bed so....


Should we accept username=None in UserUpdate schema?

This is related to https://github.com/fractal-analytics-platform/fractal-web/issues/368.
At the moment, we don't accept a payload with "username": null, and therefore we cannot unset the username of a user once it's set.

Closing, as the use of username should be superseded by the future task access-control configuration (based on either task-user relationship or task-user_group relationship, and not on string matching for specific columns).


Allocation API isn't as flexible as Lua's

You might just want to close this WONTFIX since duktape's allocation strategy is baked into its API at this point.  I just wanted to at least raise it as a point of discussion.
In lua, malloc/free/realloc are all routed via a single callback, namely:
typedef void * (*lua_Alloc) (void *ud, void *ptr, size_t osize, size_t nsize);

The important feature is that free/realloc requests always get passed the old size of the object.  This made it very easy to track the total amount of space that a lua instance had allocated.  This is especially important for the small-memory environments that duktape is targetting.
It's certainly possible to get by without this information:

Some allocators have APIs to find the size of an allocation given its pointer (for instance jemalloc has malloc_usable_size()), but this is non-portable
The allocator can allocate a bit of extra space before each returned memory region and stash the size there.  In practice this means using 8 extra bytes for each allocation to preserve alignment guarantees.

Another smaller benefit of passing the size along to deallocators is that it may be faster if the allocator can use that hint.  That's uncommon today, but google has been talking about that optimization, for instance in this C++ proposal: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3536.html
Anyway, to change it now would require an API break since exposed interfaces like duk_free() don't take a size parameter.  So this would only be worth fixing if you're planning any other API breaks.  I just thought I'd bring it up since it was one of the only places that I had trouble while converting some existing lua code to duktape.

Since there's been no activity I'll close this.


Add message to TokenMismatchException

When thrown, TokenMismatchException gives empty message.
If form is submitted async, warning is thrown in console but message is empty and if for example axios interceptor is set to display message, it shows empty.

Why not pull same message from 419 error page
https://github.com/laravel/framework/blob/734d7584e4f1cdf306fb611fa6266113f962dc56/src/Illuminate/Foundation/Exceptions/views/429.blade.php#L11

@taylorotwell If I add docblock and localization, would you consider it?

Yes, he is a nice guy

Updated changes, created #26215


match nuke fails with deleting from S3

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I am running fastlane match nuke distribution.
Fastlane deletes certificates from Apple but leaves them in S3 because it fails here.
Access to S3 is read/write and checked by previous runs of fastlane match appstore.
Complete output when running fastlane, including the stack trace and command used

irix@tau ~/projects/REDPROJECT/ios [∓ ci +] % fastlane match nuke distribution
[✔] 🚀
[13:46:44]: fastlane detected a Gemfile in the current directory
[13:46:44]: However, it seems like you didn't use `bundle exec`
[13:46:44]: To launch fastlane faster, please use
[13:46:44]:
[13:46:44]: $ bundle exec fastlane match nuke distribution
[13:46:44]:
[13:46:44]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[13:46:46]: Successfully loaded '/Users/irix/projects/REDPROJECT/ios/fastlane/Matchfile' 📄
+----------------------+------------------------------------------+
|           Detected Values from './fastlane/Matchfile'           |
+----------------------+------------------------------------------+
| storage_mode         | s3                                       |
| s3_bucket            | REDBUCKET                                |
| s3_region            | eu-west-1                                |
| s3_access_key        | RED                                      |
| s3_secret_access_key | RED                                      |
| type                 | appstore                                 |
+----------------------+------------------------------------------+
[13:46:50]: 🔓  Successfully decrypted certificates repo
+----------------------------+------------------------------------------+
|                    Summary for match nuke 2.144.0                     |
+----------------------------+------------------------------------------+
| type                       | appstore                                 |
| readonly                   | false                                    |
| generate_apple_certs       | true                                     |
| skip_provisioning_profiles | false                                    |
| username                   | RED                                      |
| team_id                    | RED                                      |
| storage_mode               | s3                                       |
| git_branch                 | master                                   |
| shallow_clone              | false                                    |
| clone_branch_directly      | false                                    |
| s3_region                  | eu-west-1                                |
| s3_access_key              | RED                                      |
| s3_secret_access_key       | RED                                      |
| s3_bucket                  | REDBUCKET                                |
| keychain_name              | login.keychain                           |
| force                      | false                                    |
| force_for_new_devices      | false                                    |
| skip_confirmation          | false                                    |
| skip_docs                  | false                                    |
| platform                   | ios                                      |
| verbose                    | false                                    |
+----------------------------+------------------------------------------+
[13:46:50]: Fetching certificates and profiles...
+--------------+------------+-------------------+------------+
|         Certificates that are going to be revoked          |
+--------------+------------+-------------------+------------+
| Name         | ID         | Type              | Expires    |
+--------------+------------+-------------------+------------+
| Distribution | RED_______ | AppleDistribution | 2021-03-27 |
| Distribution | RED_______ | AppleDistribution | 2021-03-27 |
| Distribution | RED_______ | AppleDistribution | 2021-03-27 |
| Distribution | RED_______ | AppleDistribution | 2021-03-27 |
+--------------+------------+-------------------+------------+
+---------------------+------------+--------+------------------+------------+
|            Provisioning Profiles that are going to be revoked             |
+---------------------+------------+--------+------------------+------------+
| Name                | ID         | Status | Type             | Expires    |
+---------------------+------------+--------+------------------+------------+
| match AppStore      | JL3DTBA4D8 | Active | iOS Distribution | 2021-03-27 |
| RED                 |            |        |                  |            |
+---------------------+------------+--------+------------------+------------+
+-----------------------+----------------------------------------------+
|                  Files that are going to be deleted                  |
| S3 Bucket [REDBUCKET] on region eu-west-1                            |
+-----------------------+----------------------------------------------+
| Type                  | File Name                                    |
+-----------------------+----------------------------------------------+
| distribution cert     | XV3J38D5RH.cer                               |
| distribution cert     | J395LL23Y5.cer                               |
| distribution cert     | XV3J38D5RH.p12                               |
| distribution cert     | J395LL23Y5.p12                               |
| appstore profile      | AppStore_RED.mobileprovision                 |
+-----------------------+----------------------------------------------+
13:47:13: Are you sure you want to completely delete and revoke all the
13:47:13: certificates and provisioning profiles listed above? (y/n)
13:47:13: Warning: By nuking distribution, both App Store and Ad Hoc profiles will be deleted
13:47:13: Warning: The :app_identifier value will be ignored - this will delete all profiles for all your apps!
13:47:13: ---
13:47:13: Do you really want to nuke everything listed above? (y/n)
y
[13:47:35]: -------------------------------------------
[13:47:35]: --- Deleting 1 provisioning profiles... ---
[13:47:35]: -------------------------------------------
[13:47:35]: Deleting profile 'match AppStore RED' (JL3DTBA4D8)...
[13:47:36]: Successfully deleted profile
[13:47:36]: ----------------------------------
[13:47:36]: --- Revoking 4 certificates... ---
[13:47:36]: ----------------------------------
[13:47:36]: Revoking certificate 'Distribution' (XV3J38D5RH)...
[13:47:38]: Successfully deleted certificate
[13:47:38]: Revoking certificate 'Distribution' (J395LL23Y5)...
[13:47:39]: Successfully deleted certificate
[13:47:39]: Revoking certificate 'Distribution' (XV3J38D5RH)...
[13:47:39]: {"responseId"=>"a9be006a-af2e-4e39-8dbe-c5b155651230", "resultCode"=>7470, "resultString"=>"This certificate cannot be revoked because it is not in an "issued" state.", "userString"=>"This certificate cannot be revoked because it is not in an "issued" state.", "creationTimestamp"=>"2020-03-27T10:47:39Z", "protocolVersion"=>"QH65B2", "userLocale"=>"en_US", "requestUrl"=>"https://developer.apple.com/services-account/QH65B2/account/ios/certificate/revokeCertificate.action", "httpCode"=>200}
[13:47:39]: Successfully deleted certificate
[13:47:39]: Revoking certificate 'Distribution' (J395LL23Y5)...
[13:47:39]: {"responseId"=>"f954c446-6f3e-4775-86ed-c1d0b3de15b0", "resultCode"=>7470, "resultString"=>"This certificate cannot be revoked because it is not in an "issued" state.", "userString"=>"This certificate cannot be revoked because it is not in an "issued" state.", "creationTimestamp"=>"2020-03-27T10:47:39Z", "protocolVersion"=>"QH65B2", "userLocale"=>"en_US", "requestUrl"=>"https://developer.apple.com/services-account/QH65B2/account/ios/certificate/revokeCertificate.action", "httpCode"=>200}
[13:47:39]: Successfully deleted certificate
[13:47:39]: --------------------------------------------
[13:47:39]: --- Deleting 5 files from the storage... ---
[13:47:39]: --------------------------------------------
[13:47:39]: Deleting file 'XV3J38D5RH.cer'...
[13:47:39]: Successfully deleted file
[13:47:39]: Deleting file 'J395LL23Y5.cer'...
[13:47:39]: Successfully deleted file
[13:47:39]: Deleting file 'XV3J38D5RH.p12'...
[13:47:39]: Successfully deleted file
[13:47:39]: Deleting file 'J395LL23Y5.p12'...
[13:47:39]: Successfully deleted file
[13:47:39]: Deleting file 'AppStore_RED.mobileprovision'...
[13:47:40]: Successfully deleted file
[13:47:40]: 🔒  Successfully encrypted certificates repo
Looking for related GitHub issues on fastlane/fastlane...
Found no similar issues. To create a new issue, please visit:
https://github.com/fastlane/fastlane/issues/new
Run fastlane env to append the fastlane environment to your issue
Traceback (most recent call last):
20: from /Users/irix/.rbenv/versions/2.5.5/bin/fastlane:23:in <main>' 	19: from /Users/irix/.rbenv/versions/2.5.5/bin/fastlane:23:in load'
18: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/bin/fastlane:23:in <top (required)>' 	17: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/fastlane/lib/fastlane/cli_tools_distributor.rb:111:in take_off'
16: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/commands_generator.rb:25:in start' 	15: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/commands_generator.rb:186:in run'
14: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!' 	13: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!'
12: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command' 	11: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run'
10: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call' 	 9: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/commands_generator.rb:179:in block (3 levels) in run'
8: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/nuke.rb:78:in run' 	 7: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/nuke.rb:240:in nuke_it_now!'
6: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/interface.rb:59:in save_changes!' 	 5: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/interface.rb:59:in chdir'
4: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/interface.rb:78:in block in save_changes!' 	 3: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/s3_storage.rb:132:in delete_files'
2: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/s3_storage.rb:132:in each' 	 1: from /Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/match/lib/match/storage/s3_storage.rb:133:in block in delete_files'
/Users/irix/.rbenv/versions/2.5.5/lib/ruby/gems/2.5.0/gems/fastlane-2.144.0/fastlane/lib/fastlane/helper/s3_client_helper.rb:44:in delete_file': [!] undefined local variable or method bucket_name' for #FastlaneCore::Helper::S3ClientHelper:0x00007f8dc357c9b8 (NameError)
Did you mean?  bucket

Environment

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.6

Ruby
2.5.5

Bundler?
false

Git
git version 2.25.1

Installation Source
~/.rbenv/versions/2.5.5/bin/fastlane

Host
Mac OS X 10.14.6 (18G3020)

Ruby Lib Dir
~/.rbenv/versions/2.5.5/lib

OpenSSL Version
OpenSSL 1.0.2r  26 Feb 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Prepare beta release"
  lane :beta do
    match(type: "appstore")
    build_app(workspace: "RED.xcworkspace", scheme: "RED")
  end

  desc "Push a new release build to the App Store"
  lane :release do
    match(type: "appstore")
    increment_build_number(xcodeproj: "RED.xcodeproj")
    build_app(workspace: "RED.xcworkspace", scheme: "RED")
    #upload_to_app_store(skip_metadata: true, skip_screenshots: true, skip_binary_upload: true)
  end
end

`./fastlane/Appfile`
app_identifier("RED") # The bundle identifier of your app
apple_id("RED") # Your Apple email address

itc_team_id("RED") # App Store Connect Team ID
team_id("RED") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem
Version
Update-Status

fastlane
2.144.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.2.0

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.2

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.15.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.6.0

terminal-table
1.8.0

plist
3.5.0

addressable
2.6.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.7.1

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.73.0

faraday
0.17.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.7

gh_inspector
1.1.3

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
2.0.1

naturally
2.2.0

simctl
1.6.8

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.13.1

signet
0.13.2

memoist
0.16.2

os
1.0.1

googleauth
0.11.0

httpclient
2.8.3

google-api-client
0.36.4

google-cloud-env
1.3.1

google-cloud-errors
1.0.0

google-cloud-core
1.5.0

digest-crc
0.5.1

google-cloud-storage
1.25.1

emoji_regex
1.0.1

jmespath
1.4.0

aws-partitions
1.288.0

aws-eventstream
1.0.3

aws-sigv4
1.1.1

aws-sdk-core
3.92.0

aws-sdk-kms
1.30.0

aws-sdk-s3
1.61.1

json
2.2.0

stringio
0.0.1

openssl
2.1.2

strscan
1.0.0

date
1.0.0

fileutils
1.0.2

etc
1.0.0

io-console
0.4.6

zlib
1.0.0

mini_portile2
2.4.0

nokogiri
1.10.3

ipaddr
1.2.0

psych
3.0.2

webrick
1.4.2

generated on: 2020-03-27

Thanks! The fix helped at least one person so I think it should work. I will check it later (cannot drop certificates right now).