EditDialogFormApi

I tried to find a way to communicate between EditDialog and FinalForm. There were two motivations for this:

Finding a solution for closing the EditDialog after submitting the form with ENTER click
-> solved by adding a closeDialog() method to the EditDialogApi. It is called in the onAfterSubmit() method of FinalForm  (see https://github.com/vivid-planet/comet-admin/pull/576#discussion_r844753345)

Showing an out-of-the-box loading/error state in EditDialog
-> this is done by adding a new context EditDialogFormApiContext that allows EditDialog and FinalForm to communicate with each other. This way FinalForm can pass its loading or error state to EditDialog. The SaveButton in EditDialog is used to display these states

These changes are non-breaking and work out-of-the-box. Nothing has to be changed in a project.
Check out Dev Story: https://deploy-preview-630--comet-admin.netlify.app/?path=/story/comet-admin-edit-dialog--edit-dialog-states
TODO:

[ ] Docs with Examples (I'll do that once the changes have been approved since atm the API is just a proposal)

great work!
have you considered a naming for EditDialogFormApi without "Form", as it is not really form-only?

These changes are non-breaking and work out-of-the-box. Nothing has to be changed in a project.

:+1:

have you considered a naming for EditDialogFormApi without "Form", as it is not really form-only? - @nsams

Having both editDialog and editDialogFormApi is kinda strange - @johnnyomair

An EditDialogApi already exists. The difference between these two APIs is

EditDialogFormApi is private. Its sole purpose is internal communication between the EditDialog and FinalForm. This API is only used internally and is not exposed to the application.
EditDialogApi is public. It's exposed by the useEditDialog() and useEditDialogApi() hooks. The dev can use this API in their application to open/close EditDialogs.

My motivation to split these APIs was that I didn't want to overload the public API with properties for private, internal communication. Since this

adds a lot of props to the public API that are irrelevant to the application
creates the potential for the application developer to break something (by using the internal API in the wrong way)
makes future changes more complicated because a public API has to be changed -> changes in docs, potential major version upgrade

Good analysis of our current context-based effects :+1:
However @johnnyomair 's concern (as I understand it) is more the implementation: our FinalForm wrapper needs to know (and has dependencies on) Table, Stack and EditDialog - stuff that is completely unrelated to a form. And he is right - this is not good.
Alternative ideas, anyone?

[ ] Docs with Examples

does that internal change really need docs?

I've added a task for my concerns regarding the God Mode Final Form: https://app-eu.wrike.com/open.htm?id=919648614


Handle Context Menus for Links (http, email, etc)

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/31183952-handle-context-menus-for-links-http-email-etc?utm_campaign=plugin&utm_content=tracker%2F19476668&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F19476668&utm_medium=issues&utm_source=github).

Is it solved?

@akashnimare I don't think so.

It's fairly easy. I'll send a PR to fix this.

hi @akashnimare
Are you still willing to contribute with a PR for this?


Azure OpenAI: update test automation resource management

This change makes minor modifications to the Azure OpenAI test automation project to optimize internal resource utilization amidst high customer demand:

WestEurope will be used for the test resource, instead of EastUS
Standard scale type will be used for inference model deployments, instead of Manual
The test resource name has a slightly more self-documenting name

Tests were re-run to regenerate matching recordings.

API change check
API changes are not detected in this pull request.


Configuration Dropdown not populating with options.

Describe the bug
When in the yap admin if i go to configure a service body the Configuration Dropdown is not populating with options. I tested this on SEZF and NERNA servers running 3.8.1
What version are you running?
3.8.1
Did this happen on prior versions to the one you are running?
not sure about 3.8.0 but it def didn't happen on 3.7.5.
To Reproduce
In the yap admin, go to configure a service body and try to add a configuration option.
Expected behavior
The configuration options are available to edit.
Screenshots

Additional context
If setting were set previously they still show up and work, just are not able to set new ones.

will be released in 3.8.2


Adding function equivalent to ZPL numeric function OBJC($A) in zospy.functions.nce

Hi Jan-Willem, and team,
This refers to my answer in the Zemax Community about a ZOSAPI function equivalent to ZPL numeric function OBJC($A).
I somehow didn't manage to run ZOSPy with 2023 R1.03 though, so I couldn't test the example I wrote in the docstring.
I also don't know about unit testing (I'm not a software engineer) but I'm happy to help if you explain me how to do this kind of stuff.
 We are about to push some new functionality to ZOSPy, so this one can swiftly be included the new versions.
Regarding ZOSPy not working with your OpticStudio, we are happy to help/fix the problem. But maybe then it is better to report an issue, so we can follow up (as this pull request will probably soon closed).

@crnh Would be willing to implement the unit test? I think the example David gave is already a sufficient test, which can be applied to the simple_system.

@crnh Would be willing to implement the unit test? I think the example David gave is already a sufficient test, which can be applied to the simple_system.

Sure, unless @Omnistic is very eager to learn about unit testing... I think you did already give some hints!

Hi @Omnistic, nice work! Two questions regarding the implementation:

The function currently returns -1 if no objects are found. This probably reflects the behaviour of the macro, but I think that's not required. What about returning None or an empty list? (The latter is common practice in libraries like NumPy and Pandas; check e.g. numpy.where or pandas.DataFrame.query).
Instead of a list of ints, you can also return a list of objects, since you're probably going to use the indices to get the objects anyways.

Regarding point 1, I think returning an empty list is preferable. In most cases, you will have to check the length of the returned list anyway befire you do that. Returning '[]' in stead of '-1' will save you from checking the tyoe of the return first.
Regarding point 2, I am also in favour of returning the object as you can get the position fron the object. We could also add a parameter to specify whether objects or object positions are returned if we want to support both possibilities.

@LucVV suggested that this function can also be implemented for the LDE. I still need to investigate if we can do this using a shared implementation, or if we need completely separate implementations for each editor.

I have had a similar implementation in a project before to find the position of a surface in the LDE. I think you need to call slightly different API functions so separate implementations might be the easiest. I'll look into this.

I agree with this. Although explicit type checking is not needed in this case (comparing a list with an int will return False, so that would be sufficient), it is still better to limit the amount of possible return types. An empty list therefore also has my preference.
Object indices can be easily found using a simple list comprehension, so I would leave this to the user. I don't think there are many cases in which you really need the indices instead of the objects.
As far as I know, the LDE rows and NCE objects implement the same interface. If the Comment property is part of this interface, we can probably use a shared implementation for both editors. Otherwise, it's indeed better to have two completely separate implementations.

As far as I know, the LDE rows and NCE objects implement the same interface. If the Comment property is part of this interface, we can probably use a shared implementation for both editors. Otherwise, it's indeed better to have two completely separate implementations.

I just checked this. INCERow and ILDERow do indeed both implement IEditorRow, but Comment is not a member of IEditorRow. So we need two separate implementations.

Thank you for the comments. The function now returns a list of object that is empty is no match is found. As for the sequential mode implementation of this function, the only difference is that one has to call GetSurfaceAt from the LDE instead of GetObjectAt (from the NCE). Let me know if I should implement this in the same function or if you think  we need another one (happy to write it as well).

@crnh Would be willing to implement the unit test? I think the example David gave is already a sufficient test, which can be applied to the simple_system.

Sure, unless @Omnistic is very eager to learn about unit testing... I think you did already give some hints!

Not eager definitely, but if you have some pointers for me to have a rough idea of what it means, I'm all ears.

Now that I'm able to better run ZOSPy, I noticed both function in nce.py wre refering to oss.NCE.InsertNewObjectAt(0) in their docstring. However, OpticStudio counts objects from 1. I think it should be replaced by oss.NCE.InsertNewObjectAt(1).

However, OpticStudio counts objects from 1. I think it should be replaced by oss.NCE.InsertNewObjectAt(1).

I see, sorry the example is incorrect. I will adjust it soon! It seems to stem from the equivalent function for the LDE. Somehow,surface numbering starts at 0 in sequential mode but and at 1 in non-sequential mode. I have never fully figured out the reasoning behind that. I do think this is why two separate implementations of your function are required.

now. Should object_change_type be called from zp somehow?

That is correct, object_change_type() is available by calling zp.functions.nce.object_changetype(). Or equivalently by importing it:
from zospy.functions.nce import object_change_type()
object_change_type(...)

Sorry that that is not clear in the example, I will update that.

Hi @Omnistic,
I have just added the same function for the LDE as find_surface_by_comment(). I have furthermore added a unit test. I think this unit test can swiftly be altered to work for the NCE. However, the simple_system that I use is sequential. We have a nsc_simple_system ready in the next release that might be optimal for this test. @crnh what do you think is the best way to go regarding to that non-sequential simple system?

We have a nsc_simple_system ready in the next release that might be optimal for this test. @crnh what do you think is the best way to go regarding to that non-sequential simple system?

Introducing the nsc_simple_system in this PR as well seems to me the easiest way to add proper unit tests for zospy.functions.nce.find_objects_by_comment. Otherwise we won't be able to test the unit tests...

I have added the non-sequential simple system for testing purposes.

@crnh Could you "quickly" add the unit test for the non-sequential part, so we can include it in the merge with all our internal stuff for version 1.1.0


add Halstead metrics

In addition to the completely banal classical quantitative metrics, I also propose to add Halstead metrics (at least the most basic ones to begin with).
Halstead metrics are a system for evaluating program performance that measures the complexity and size of code. Such metrics are a more advanced version of assessing complexity and labor costs than the standard SLOC.
How to calculate

@yegor256 please, verify this suggestion
If we need it, I'll take it to work

@IlyaPechersky I believe, we already have them, calculated by Multimetric: https://github.com/yegor256/cam/blob/master/metrics/multimetric.sh#L36-L38

Oh, I see, thank you!


Co-authored-by: Deadop123<EMAIL_ADDRESS>

Co-authored-by: Deadop123<EMAIL_ADDRESS>

Co-authored-by: Deadop123<EMAIL_ADDRESS>


Modal size broken?

Hi!
When trying to create a modal with the size option "lg", the markup seems to be wrong.
According to bootstrap's documentation, it should be

      ...

but what I get instead is

      ...

The resulting modal is not large, and positioned off-center to the left.
Is there an easy way to fix this?
PS: Thanks for the great plugin.

I think Bootstrap change the target for the class in a recent version. I'll push a fix as soon as I can (this is an easy fix but I do not have access to a working dev environment right now).

Should be fixed by ba8cb3f9e763ab3cba1dd7ede35e5b64b080bb81.

Thank you so much!

I am closing this, feel free to open a new issue if you have any problem!


Feature request: Support 12bit pixel depth

Currently only 8bit pixel depth is supported. The brightness / exposure search and different other functions are operating on values between 0 and 255. The support of 12bit pixel depth would need to template multiple functions that take uint8_t as default pixel type by taking into account the number of channels.

Are you still working on it @marceldebout? I really want to take advantages of wide dynamic range camera.
Which are the parts of the codes that I need to template to make it support 12bit pixel?

Are you still working on it @marceldebout? I really want to take advantages of wide dynamic range cameras.
Which are the parts of the codes that I need to template to make it support 12bit pixel?

Are you still working on it @marceldebout? I really want to take advantages of wide dynamic range cameras.
Which are the parts of the codes that I need to template to make it supports12bit pixel?

Are you still working on it @marceldebout? I really want to take advantages of wide dynamic range cameras.
Which are the parts of the codes that I need to template to make it supports 12bit pixel?

Crosslink https://answers.ros.org/question/308885/capturing-12-bit-with-pylon_camera/


disable redundant circleci tests

@rosenhouse / @utako / @Nino-K / @zachgersh et al, if you can help migrate this cf test to prow, then we can disable circleci fully.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

.circleci/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
77e151ece98a65f410d2aabd58dbb977aae50443
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
77e151ece98a65f410d2aabd58dbb977aae50443
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
77e151ece98a65f410d2aabd58dbb977aae50443
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Effectively a dupe of https://github.com/istio/istio/pull/15068, I think it can be closed


Complete ML Engines Table

Add the missing engines in the ml engines table

[ ] vllm
[ ] tensorrt
[ ] optimum
[ ] lightning
[ ] exllamav2
[ ] deepspeed
[ ] ctransformers
[ ] autogptq
[ ] autoawq

Notes

remove ROCM, Intel, Blas, Model, Tensor, ONNX, Training rows
transpose the table

This is done, so closing this issue


Issue report (angle-bracket style assertion and JSX) for TypeScript Playground about default configs and contact channel

Suggestion
As shown in the TypeScript Playground (as of v4.3.5) and screenshoots, the angle-bracket style assertion conflicts with the default config of Playground with JSX enabled (JSX: React), where as set to None could fix this issue.

This is a bug (or not even one) for Playground rather than TypeScript language itself so I didn't report it as a bug.
However, the playground is important for everyone to try a piece of code as quick as possible. It would be better to disable the default JSX config in order not to violate the valid TypeScript syntax.
TS error message:
JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.(7026)
JSX element 'string' has no corresponding closing tag.(17008)
On the other hand, I wonder if there could be a bug report page or contact info on the Playground website (I know the maintainers might not want such a directly contact though _(;3
By a quick search, I found the original issue #2246 on implementing such a Playground page as well as the microsoft/TypeScript-Playground-Samples repo, but not sure if there's any formal channel for reporting such an issue in the future.

🔍 Search Terms
Playground, default TS Config, angle-bracket style assertion, and JSX syntax
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Remove the default TS Config for JSX: React on https://www.typescriptlang.org/play
Add a formal channel (e.g., an issue report page or maintainer's contact info) for TypeScript Playground

📃 Motivating Example
Thanks to the original post @Facebook for reporting this issue
It might not be a critical issue but it may influence the user experience for the beginner of TypeScript. Hopefully this issue report could make them a better TS coding life :D
💻 Use Cases
N/A

You're looking for: https://github.com/microsoft/TypeScript-Website
And IMO this is no big deal. Just use the alternative syntax: foo as T - they do absolutely the same.

Thank you for the quick reply and I'll close this issue here !
I just miss that repo :(

Yes, I know the other as style syntax is also available (and I always use it personally); however, some of the sample code (e.g., like the original post) is provided with the angle-bracket style.
Actually, there's a typescript-eslint rule called consistent-type-assertions to limit the syntax of type assertion (also uses assertionStyle: 'as' by default)
However, if I were the designer of the Playground and need to make a trade-off between official TypeScript syntax (<Type>foo) and JSX syntax, I would rather pick the former one as it's part of the standard of TypeScript.


Missing files

Hi! Can you elaborate further on your issue and give a complete list of the missing files? Thanks

Closing this issue for inactivity


WebGLRenderer method fails when running on a Google Chrome Extension

Whenever I try to use it injecting the pixi.js to a page etc, when I call WebGLRenderer, it throws an error saying "TypeError: Cannot read property 'bind' of undefined"
The line that produces that is the following: (playerAPIDiv is a jquery DOM element)
renderer = PIXI.WebGLRenderer(playerAPIDiv.width(), playerAPIDiv.height());
When I try to do that:
renderer = new PIXI.autoDetectRenderer(playerAPIDiv.width(), playerAPIDiv.height());
It just freezes the page (because there is no try/catch in autoDetectRenderer)
Thanks for reading. I'm waiting for a feedback.

//WRONG
renderer = PIXI.WebGLRenderer(playerAPIDiv.width(), playerAPIDiv.height());
//OK
renderer = new PIXI.WebGLRenderer(playerAPIDiv.width(), playerAPIDiv.height());
//WRONG
renderer = new PIXI.autoDetectRenderer(playerAPIDiv.width(), playerAPIDiv.height());
//OK
renderer = PIXI.autoDetectRenderer(playerAPIDiv.width(), playerAPIDiv.height());

@ivanpopelyshev Doing the above generates the same error, while using it with Tampermonkey don't. Here it is a Tampermonkey extension that works perfectly: https://github.com/MrAnyone/YouTube-Audio-Visualizer
But when I try to execute the same code in a Google Chrome extension, this error occurs.

I found an way to fix it, all you need to do is inject the code of the library ( & yours ) to the page scope, here is what injector looks like (using JQuery):
https://github.com/MrAnyone/YouTube-Audio-Visualizer/blob/master/injector.js
The chrome extension runs in a different scope from the page, thats why PIXI (and any other library like ThreeJS) fails to init.


rpc: use compat mode in latest_block_results()

Fixes: #1325 as it applies to the implementations of Client::latest_block_results

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[x] Added entry in .changelog/

Codecov Report

Merging #1326 (0ca81b9) into main (9854a66) will increase coverage by 0.0%.
The diff coverage is 0.0%.

:exclamation: Current head 0ca81b9 differs from pull request most recent head ac84961. Consider uploading reports for the commit ac84961 to get more accurate results

@@          Coverage Diff          @@
##            main   #1326   +/-   ##
=====================================
  Coverage   59.7%   59.8%
=====================================
  Files        283     283
  Lines      26903   26909    +6
=====================================
+ Hits       16087   16092    +5
- Misses     10816   10817    +1

Impacted Files
Coverage Δ

rpc/src/client/transport/http.rs
20.0% <0.0%> (-0.3%)
:arrow_down:

rpc/src/client/transport/websocket.rs
64.2% <0.0%> (-0.3%)
:arrow_down:

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Wfnews-455, add supportLink property into config

This is just a tab-group set-up and Active Wildfire List still need to be implemented. The activeWildfireList endpoint in our news-api will need pagination,


Temporarily disable luci try jobs on flutter/engine

We are disabling luci try jobs for flutter/engine to fix several things without affecting developer workflows:

Add mac capacity, 10 machines for try jobs.
Optimize flutter dashboard - github - luci communication to provide enough information about what was scheduled and pending for resources and not mark the pr as green.
Fix mac simulator installation issues

I'm adding the capacity to enable flutter/engine try jobs again, so I tried re-running latest successful engine builds on the new LUCI bots. Here's a failed build, could someone from engine team take a look? /cc @chinmaygarde @dnfield
https://chromium-swarm.appspot.com/task?id=4ae3e98afcc76110 was building "Mac Android Debug Engine" for https://github.com/flutter/engine/pull/17095, and it failed on "build android_release_vulkan".

Seems like is looking for the java sdk

Oh, I see. I wonder why luci.flutter.prod doesn't have this issue and should we fix it in the Engine recipe or the salt states that provision LUCI bots?
Error found:
FAILED: gen/flutter/shell/platform/android/flutter_shell_java.d flutter_embedding_release.jar flutter_embedding_release.jar.md5.stamp flutter_embedding_release-sources.jar flutter_embedding_release-sources.jar.md5.stamp
python ../../build/android/gyp/javac.py --depfile=gen/flutter/shell/platform/android/flutter_shell_java.d --jar-path=flutter_embedding_release.jar --jar-source-path=flutter_embedding_release-sources.jar --jar-source-base-dir=/b/s/w/ir/cache/builder/src/flutter/shell/platform/android --classpath=\[\"../../third_party/android_tools/sdk/platforms/android-29/android.jar\",\ \"../../third_party/android_support/android_support_compat.jar\",\ \"../../third_party/android_support/android_support_annotations.jar\",\ \"../../third_party/android_support/android_support_fragment.jar\",\ \"../../third_party/android_support/android_arch_lifecycle_common.jar\",\ \"../../third_party/android_support/android_arch_lifecycle_common_java8.jar\",\ \"../../third_party/android_support/android_arch_lifecycle_runtime.jar\",\ \"../../third_party/android_support/android_arch_lifecycle_viewmodel.jar\"\] --bootclasspath=../../third_party/android_tools/sdk/platforms/android-29/android.jar ../../flutter/shell/platform/android/io/flutter/Log.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivity.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java ../../flutter/shell/platform/android/io/flutter/app/FlutterActivityEvents.java ../../flutter/shell/platform/android/io/flutter/app/FlutterApplication.java ../../flutter/shell/platform/android/io/flutter/app/FlutterFragmentActivity.java ../../flutter/shell/platform/android/io/flutter/app/FlutterPluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidKeyProcessor.java ../../flutter/shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java ../../flutter/shell/platform/android/io/flutter/embedding/android/DrawableSplashScreen.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterActivityLaunchConfigs.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterEngineConfigurator.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterEngineProvider.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragment.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterFragmentActivity.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterSplashView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterSurfaceView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterTextureView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/FlutterView.java ../../flutter/shell/platform/android/io/flutter/embedding/android/RenderMode.java ../../flutter/shell/platform/android/io/flutter/embedding/android/SplashScreen.java ../../flutter/shell/platform/android/io/flutter/embedding/android/SplashScreenProvider.java ../../flutter/shell/platform/android/io/flutter/embedding/android/TransparencyMode.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEngineCache.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterEnginePluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/FlutterShellArgs.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartExecutor.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/DartMessenger.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/dart/PlatformMessageHandler.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/ResourceCleaner.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/ResourceExtractor.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/loader/ResourcePaths.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/FlutterPlugin.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/PluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/activity/ActivityPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/broadcastreceiver/BroadcastReceiverPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/contentprovider/ContentProviderPluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/lifecycle/HiddenLifecycleReference.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServiceAware.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServiceControlSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/service/ServicePluginBinding.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/shim/ShimPluginRegistry.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/plugins/shim/ShimRegistrar.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/FlutterUiDisplayListener.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/renderer/RenderSurface.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/KeyEventChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LifecycleChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/LocalizationChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/NavigationChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/SettingsChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/SystemChannel.java ../../flutter/shell/platform/android/io/flutter/embedding/engine/systemchannels/TextInputChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/ActivityLifecycleListener.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BasicMessageChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BinaryCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/BinaryMessenger.java ../../flutter/shell/platform/android/io/flutter/plugin/common/ErrorLogResult.java ../../flutter/shell/platform/android/io/flutter/plugin/common/EventChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/FlutterException.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONMessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONMethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/JSONUtil.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodCall.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodChannel.java ../../flutter/shell/platform/android/io/flutter/plugin/common/MethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/PluginRegistry.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StandardMessageCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StandardMethodCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/common/StringCodec.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/InputConnectionAdaptor.java ../../flutter/shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/AccessibilityEventsDelegate.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformView.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewFactory.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewRegistry.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewRegistryImpl.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsAccessibilityDelegate.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/SingleViewPresentation.java ../../flutter/shell/platform/android/io/flutter/plugin/platform/VirtualDisplayController.java ../../flutter/shell/platform/android/io/flutter/util/PathUtils.java ../../flutter/shell/platform/android/io/flutter/util/Preconditions.java ../../flutter/shell/platform/android/io/flutter/util/Predicate.java ../../flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java ../../flutter/shell/platform/android/io/flutter/view/AccessibilityViewEmbedder.java ../../flutter/shell/platform/android/io/flutter/view/FlutterCallbackInformation.java ../../flutter/shell/platform/android/io/flutter/view/FlutterMain.java ../../flutter/shell/platform/android/io/flutter/view/FlutterNativeView.java ../../flutter/shell/platform/android/io/flutter/view/FlutterRunArguments.java ../../flutter/shell/platform/android/io/flutter/view/FlutterView.java ../../flutter/shell/platform/android/io/flutter/view/TextureRegistry.java ../../flutter/shell/platform/android/io/flutter/view/VsyncWaiter.java gen/flutter/shell/platform/android/io/flutter/BuildConfig.java
Unable to find any JVMs matching version "1.8".
No Java runtime present, try --request to install.

I have manually installed java8 sdk on the try bots, next step is to verify different engine try builders on each try bot.

I have tried "Mac iOS Engine" on the 10 try bots, failed 2 out of 10 on "Scenario App Unit Tests":

https://chromium-swarm.appspot.com/task?id=4b038eebab992d10
https://chromium-swarm.appspot.com/task?id=4b038f1deccfaf10

There's a step in one of the recipes where we can install jdk8 at runtime, but I didn't do it for one of the platforms because they already had it and it's extra overhead to install it.

For the failing test at https://logs.chromium.org/logs/flutter/led/wutong_google.com/15e3c12c598aadeefa00a566bf1ca97a4bbc4aa18a6f89e267ea3f1f154ea94c/+/steps/Scenario_App_Unit_Tests/0/stdout#L24334_0 - maybe @gaaclarke or @xster know, I think one of them wrote that test.

Similar failures in https://logs.chromium.org/logs/flutter/led/wutong_google.com/a479151790909f219ba2c1a5d98c5dbf4d226b6234ab9e21a1b273850f76bfbf/+/steps/Scenario_App_Unit_Tests/0/stdout#L24322_0, also seeing this line which seems concerning but not sure about:
 Details:  [DVTiPhoneSimulator -primaryInstrumentsServer was called from the main thread
 Object:   <DVTiPhoneSimulator: 0x7fcb4472abc0>
 Method:   -primaryInstrumentsServerWithError:
 Thread:   <NSThread: 0x7fcb744153b0>{number = 1, name = main}
 Please file a bug at https://feedbackassistant.apple.com with this warning message and any useful information you can provide.
 All tests

Do those happen on the prod bots?

I don't see them happen on prod bots, "Mac iOS Engine" are all green on prod bots.

Running from the machine I'm getting:
Must specify the device out directory containing gen_snapshot.
Command PhaseScriptExecution failed with a nonzero exit code
Testing failed:
Test session results, code coverage, and logs:
/Users/swarming/Library/Developer/Xcode/DerivedData/Scenarios-efgskbqbyxwwrrfdsxqpswpwbbkb/Logs/Test/Test-Scenarios-2020.03.18_20-29-37--0700.xcresult
Command PhaseScriptExecution failed with a nonzero exit code
Testing cancelled because the build failed.

** TEST FAILED **
The following build commands failed:
PhaseScriptExecution Compile\ iOS\ JIT /Users/swarming/Library/Developer/Xcode/DerivedData/Scenarios-efgskbqbyxwwrrfdsxqpswpwbbkb/Build/Intermediates.noindex/Scenarios.build/Debug-iphonesimulator/Scenarios.build/Script-0D8470A8241035AD0030B565.sh

Sometimes the "Mac iOS Engine" passes after I deleted /b/s/c cache directory. I'm still experimenting to see whether this is a reliable fix.

@dnfield you're referring to the AppLifecycleTests.m right? Is it still failing on head? It's passing locally for me.

Yes - I haven't tried it again recently though.  We could try re-enabling and running via led.

The scenario app tests are passing locally. Is it possible to re-enable this test?   This might be related to https://github.com/flutter/flutter/issues/53455
@godofredoc @digiter

The capacity has been increased by 10 mac minis.


use html instead of text method in the message open

modern browsers will use escaped version of the text, meaning
>script<alert(1);>/script< would actually render script
tag with an alert in the message
3.2 version of https://github.com/mkoistinen/django-cms/pull/3

LGTM

Coverage decreased (-0.1%) to 88.81% when pulling 6f60242e23ac0deaf30eb2b9c19c4c0b766f0a25 on vxsx:bugfix/modal-mark-safe into f82c132a9956bd1f79b8bd460cd86b8359b71c1a on divio:release/3.2.x.

obsolete as of https://github.com/divio/django-cms/pull/5186


VERSION 1.21 MUST BE SUPPORTED!

When I try to open a server with 1.21, it gives a warning and the server does not load!

What warning? What environment? What selected options? The more information you provide, the more likely I can help.
Is it related to the Java class version? Keep in mind, that Minecraft 1.21 requires Java 21 to be installed and used.
Also, GitHub issues are for reporting bugs, while the Discord server is for support requests like this. You can still respond here! But for future reference, Discord is a better place for questions like these.


WIP - Resilient Verk - Fix scaling up and down

[CI SKIP]
Hey team here is my first stab at solving this issue: https://github.com/edgurgel/verk/pull/159/files
The idea is:
(frequency) = 60 seconds ?
On starts Each node generates a new id (We can check if it's actually new by the result of SADD)
    SADD nodes node_id
    PSETEX verk:node:#{node_id} 2 * frequency alive]
Each time a node starts working on a queue the queue name is added to "node:queues" set;
Each time a node stops working on a queue the queue name is removed from "node:queues" set;
Each frequency seconds we set the node key to expire in 2 * frequency
    PSETEX verk:node:#{node_id} 2 * frequency alive]
    Also check for all the keys of all nodes. If the key expired it means that this node is dead.
    To restore we go through all the running queues of that node and enqueue them from progress back to the queue. Each "enqueue back from in progress" is atomic (<3 lua) so we won't have duplicates.

We may need to review some edge cases like what if we still have unfinished jobs while removing a queue from the list of running queues etc but I will work on them case by case
I need to review this as clearly it's just a stab at the final solution. I've played with some instances running locally and so far so good.
Related to https://github.com/edgurgel/verk/issues/157

Hey After releasing 1.4 my plan is to somehow introduce this as "experimental" so it won't affect current users and they can try it out. I should have something "ready" in 2 weeks?  I need to figure it out how to run integration tests

Hi @edgurgel, any update ?

@tlvenn , not really but I intend to get back to this probably next week. I need to find a simple way of making this optional for now so that we can release a non-major version 🤔
Maybe if no node_id was defined Verk could generate one and keep track of these automatically generated etc.
I also don't know which kind of configuration should we expose for example:

How often should we sample the nodes (heartbeat) ?
How many times should the heartbeat fail so that we consider that the node is down?
What if I'm a node that got "removed" erroneously? Should I log something and stop processing etc?

Coordination is hard 😢

@edgurgel is this PR ready to be tested as is?

@mikeastock yes it works as expected! I need to add more tests and decide some other considerations. My goal is to have the next minor version with an option to use this to control your node ids. And my "goal" is end of October maybe before that

I said end of October but it will probably be mid November 😶
I'm adding some tests and ensuring this can be used as optional until it's robust enough to be used by all users.

@edgurgel maybe a xmas gift in the end ? ;)


Use font-weight numbers instead of keywords

For font weights, should it be $t-fontWeight-400/tw400 or $t-fontWeight-normal/twn but use 400 and other keywords as the value?

I'm all for the number-based approach. They're consistent and easier to read/maintain once you pick up the syntax.
We can probably kill the variables since 100, 300, etc. are keywords in CSS. Variables like $t-fontWeight-400 only duplicate static values.
And we can drop the trailing zeros in class names because they're implied.
.mv-tw1
  font-weight: 100
.mv-tw3
  font-weight: 300
.mv-tw4
  font-weight: 400
.mv-tw6
  font-weight: 600
.mv-tw7
  font-weight: 700
.mv-tw8
  font-weight: 800
.mv-tw9
  font-weight: 900

This also addresses the issue of different fonts calling their values different names. One font might be "light" at 200 while another font is "light" at 300. Trying to use both with named variables can get icky.
:+1::question:

Good call. I agree with this :+1:


One semicolon per line

I got the following code and would like to know if there is a way to change it to multi-lines with each line only containing one semicolon?
<?php
 chdir('../'); define('IS_UC', true); $_GET['g'] = 'Member'; $_GET['m'] = 'Ucenter'; require './index.php';

Expected:
<?php
chdir('../');
define('IS_UC', true);
$_GET['g'] = 'Member';
$_GET['m'] = 'Ucenter';
require './index.php';

Does this make sense? If it does, I would like to code this fixer and submit a pull request.

PSR2

There MUST NOT be more than one statement per line.

So yes, this would make sense :)
Please check the pr's/issue's since IIRC someone did start on a fixer for this.

See #4885.

This one can be closed after https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6458 which added rule no_multiple_statements_per_line that does what is requested here.


No sound on iOS

As there are no install instructions for iOS in the documentation I tried adding RNTrackplayer.xcodeproj to my Libraries and then linking libRNTrackPlayer.a, as you would do with many other packages. I can build my app without problems and I can use the controls but there's no sound and the progress bar isn't moving. Any idea why it isn't working? Have I missed some installation step?

there's plenty of documentation. It sounds like you may not be adding tracks and playing the properly. Are you still facing this issue?

there's plenty of documentation. It sounds like you may not be adding tracks and playing the properly. Are you still facing this issue?

I solved the issue by copying the example project and modifying it.
Good job on the new release!


test: Verification of trailing spaces in pipeline run command

Description
Validating changes related to trailing spaces in pipeline run command.
Please do not merge.

Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

GitHub release
v1.3.0

Your semantic-release bot :package::rocket:

/run pipeline

/run pipeline

/run pipeline


Make ccSGD behaviour match documentation w.r.t clip_gradient

The documentation states that if glip_gradient > 0, then the gradient is
clipped.

Something is weird here, just run the lenet example with ccSGD and the accuracy is 0.0692

looks good to me.


File transfer progress can be unexpectedly hidden

If storage preferences are changed while a file is being transferred, the transfer progress indicator will be hidden when the mapping update completes.
To reproduce:

Start uploading a large-ish (100MB) file to a cloud service.
Browse to your storage preferences and authorize or deauthorize a new option.
Observe the local mappings update as expected.
Observe the upload progress is no longer visible.

This issue is caused on ViewModel.cs lines 197-204. When the storage mapping finishes, the method checks simply checks for outstanding mapping jobs and, finding none, closes the balloon.
I think the desirable behavior is something like this: if the mapping completes successfully and file transfer(s) are ongoing, immediately remove that item from the Mappings collection. However, if the mapping fails and file transfer(s) are ongoing, remove it from the Mappings collection after a 10-15 second delay.

Fixed for 3.3.0-beta1


Add ggplotnim plotting tutorial, round 2

My statements from #25 still apply.
Opening another one to see if netlify preview works now.

I didn't find much to remark on here given that it's only a draft. A few of the sentences were perhaps a tad bit too "wordy" but that might just be because I'm quite tired when reading this upside_down_face Otherwise I think it was a good tutorial for someone new who wants to learn about ggplotnim smile

Thanks!
I felt it's important to give some explanation somewhere that talks about the whole idea first. Otherwise all plots seems like some kind of arbitrary thing. I just want to get across that there is a simple logic. Once understood you can mentally create a ggplot command and you should be able to visualize what the resulting plot looks like, just from the command. Once someone understands that (even if not intuitively yet), looking at normal examples (e.g. the ggplotnim recipes) should become crystal clear.
I'll re-read the whole thing later today again and try to get it into a state I'm actually happy with.

Thanks!
I felt it's important to give some explanation somewhere that talks about the whole idea first. Otherwise all plots seems like some kind of arbitrary thing. I just want to get across that there is a simple logic. Once understood you can mentally create a ggplot command and you should be able to visualize what the resulting plot looks like, just from the command. Once someone understands that (even if not intuitively yet), looking at normal examples (e.g. the ggplotnim recipes) should become crystal clear.
I'll re-read the whole thing later today again and try to get it into a state I'm actually happy with.

I agree 👍 There's a threshold at entry but when you're over it you have basically learned all there is to know.
Great! I changed the Preview CI message, so if everything works well it should pop up at the start as pending (instead of appearing first after valid has finished). Would you mind checking if it works when you push your commit? 😄

I changed the Preview CI message, so if everything works well it should pop up at the start as pending (instead of appearing first after valid has finished). Would you mind checking if it works when you push your commit? smile

Works as intended!

Works as intended!

Awesome, thank you! 😄 That should be the last change I will make in a while on my own accords unless anyone else has any ideas :P

Nope, I think this is pretty great now.
Regarding this PR. I need to think about this thing a bit more. I'm struggling to find a structure that gets across that which I have in my head. But maybe I'm overthinking and the current thing isn't too bad. I'm confused. :laughing:

Regarding this PR. I need to think about this thing a bit more. I'm struggling to find a structure that gets across that which I have in my head. But maybe I'm overthinking and the current thing isn't too bad. I'm confused. 😆

I think it's a great start definitely. Something I think would be nice is a short description of the plot and a summary of what pieces of code created which behaviors. Right now it feels a bit like we see the plot and then it's time to go home without any reflections on it. Do you understand what I mean?

Yes, I understand what you mean and I feel the same.
The original idea of course is that I explain everything so well that it's obvious, haha.
I'm thinking of doing what you propose in the geom subsection. Do what I did in the other sections before and start building each line and explain the choices. The thing confusing to me is whether I can make that a cohesive whole with what's written already.

Yes, I understand what you mean and I feel the same.

Okay 👍 The more intuition between code and plot we can give, the better.

The original idea of course is that I explain everything so well that it's obvious, haha.

Haha, the dream of a writer 🤣

I'm thinking of doing what you propose in the geom subsection. Do what I did in the other sections before and start building each line and explain the choices. The thing confusing to me is whether I can make that a cohesive whole with what's written already.

Okay great, that feels like the section that would benefit the most from this treatment! :D Write new what you want and keep everything that makes sense afterward, most of it should probably me salvageable with a little bit of rewriting, and part of it will be obsolete with the new awesome geom-by-geom walkthrough ;)

Ready for another review. Now I'm mostly happy. :partying_face:

Nice work! I especially appreciate the work through solving all the "errors" :). One curiosity by reading this would be to try the dodge position to see how a grouped histogram would work...

Nice work! I especially appreciate the work through solving all the "errors" :). One curiosity by reading this would be to try the dodge position to see how a grouped histogram would work...

Thanks!
 First are the 3 or 4 bugs / issues visible in the example here. Most importantly range calculation for stacked identity histograms and the right most "extra" bin for outlined histograms.

I'll give this a final read later today and merge then, if there aren't any objections.

There's a few things I'd probably change, but I'll merge it for the time being and go over it next week at some point. Want this out of the way for now. 😄


Migrate rest-utils to use AK library instead of common-metrics

Jira: https://confluentinc.atlassian.net/browse/MMA-7195
As part of our efforts to converge on a single telemetry pipelines for Cloud, Hosted Monitoring, and Proactive Support, we want to standardize on one metrics library and associated metrics collection framework.
This change is prerequisite for Telemetry Reporter work.
Verfication

[x] Manually cloned and verified downstream components build + test passes https://confluentinc.atlassian.net/wiki/spaces/MMA/pages/1193709217/Rest-utils+metrics+migration+plan
[x] Muckrake spot test https://jenkins.confluent.io/job/system-test-confluent-platform-branch-builder/3710/
[x] Packaging job https://jenkins.confluent.io/job/confluentinc-pr/job/packaging/job/PR-741/2/
[x] Full Muckrake test
baseline: https://jenkins.confluent.io/job/system-test-confluent-platform-branch-builder/3721/console
with this change: https://jenkins.confluent.io/job/system-test-confluent-platform-branch-builder/3715/

@confluentinc It looks like @srpanwar-confluent just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

What's the testing strategy for this?
Probably warrants more than just building downstreams, but might be a good candidate for testing confluentinc/jenkins-common#208

I have made the change to include downstream validation.
I may have underestimated the scope. From the build error(with validation on) it looks like not all projects have migrated to use ak metrics library. I'll work with the individual team to see we can get those changes before merging this one. May/may not be possible for all the project to be fixed before this change. Anyways, I have created this page to track the migration https://confluentinc.atlassian.net/wiki/spaces/MMA/pages/1193709217/Rest-utils+metrics+migration+plan

Glad I asked then! cc @xli1996
Btw, not necessary to make the changes permanent for the downstream checks, this just seemed like a good test case for it (relatively new functionality). Eventually we'll turn it on for everything, but if you just want to test this PR, you can take any build of the PR in jenkins, do a Replay, and force it on. (Or leave as is and if you want to revert that before merge, feel free.)
In terms of other tests, good things to check are the muckrake build (if you just want to iterate relatively quickly locally to make sure downstreams build), packaging (has smoke tests to make sure things at least start running; should be pretty reliable as long as builds work but is a good sanity check), and full muckrake tests (which likely won't pass on the job due to flaky tests, but you can compare results to nightlies to see if anything looks off). If you need help with how to do any of these, ask here, or generally to the tools team.

Thanks @ewencp I'll remove the flag before checkin.
Regarding the tests, I was able to manually clone the downstream projects and verify build + test passed. All except kafka-rest need no change. I also added back dependencies for common-config and common-metrics  in pom.xml. Some dwonstream projects need them.
As you have suggested, I ran muckrake job (updated the repo+branch to point to my changes in rest-utils and kafka-rest) https://jenkins.confluent.io/job/system-test-confluent-platform-branch-builder/3710/. It passed . I am trying to figure out how to do same for packaging but not sure how to go about. If you can point me to the instruction. Thanks

@arrawatia let me know if should include this change as well https://github.com/confluentinc/rest-utils/compare/master...arrawatia:telemetry-reporter?expand=1#diff-64aa9920b5a3321a914eaee14ab57ecfR122

For packaging, you can point to your fork for specific repos here https://github.com/confluentinc/packaging/blob/master/settings.sh#L255 and override branch here https://github.com/confluentinc/packaging/blob/master/settings.sh#L241. Then submit a DNM PR job with those changes.

@ewencp verified there us no regression by running the packaging job, muckrake build and full muckrake test. Updated the description with the links .

@arrawatia let me know if should include this change as well https://github.com/confluentinc/rest-utils/compare/master...arrawatia:telemetry-reporter?expand=1#diff-64aa9920b5a3321a914eaee14ab57ecfR122

No. The work on MetricsContext is still a "work in progress". We will raise a separate PR for this after we finalize the API.

I tested changes on this PR with Schema Registry on my local laptop. All tests passed successfully and I was able to run it with our telemetry reporter enabled.

@xvrl  pr for kafka-rest https://github.com/confluentinc/kafka-rest/pull/651. If you can take a look. I merge both of them accordingly.

@srpanwar-confluent let's do it!


Add new search action in Word Search and refactor code

Description
Add two new actions to Word Search: Search for Words with Missing Letters and Search for Adjectives
To search for missing letters, place ? between the letters you are unsure about.
For example, in the picture below, s??a?t means search for a word, 6 characters in length, where we don't know 3 of the letters in those positions where the ? is.

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hey @pernielsentikaer,
Thank you for letting me know. I ended up duplicating the files in metadata folder to media folder and referenced those in the README.


chore: export commands flags

Overview
Exports the commands flags to be used by testground

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Codecov Report

Merging #298 (07b0090) into main (a96395c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   43.20%   43.20%
=======================================
  Files          26       26
  Lines        1949     1949
=======================================
  Hits          842      842
  Misses        991      991
  Partials      116      116

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


test_pos_option should use collision bitmap

When testing to see if the 'option' can be put down the test function is using the level bitmap (including backgrounds) rather than the collision bitmap.

Fixed with 0.6


Scaling cluster down to 0

What
I'm hoping to use the operator to provide test clusters for developers. Since the development cycle is not 24 hours it would be more cost-effective to shut down the instances when not in use to free up resources.
I can see that deleting the entire cluster wipes the root access credentials as well as all PVCs, which is not ideal for this setup.
How
It would be convenient if the option to scale to 0 replicas was allowed by the operator.
Alternatively a different option to suspend the cluster that's not tied to the replica count may be preferable if some other logic is tied to increasing the number of replicas.
Checklist

[ ] Finish implementation of the issue
[ ] Test all functions
[ ] Have enough logs to trace activities
[ ] Notify developers of necessary actions

My gut feeling is like the following.
Add a mode of operation to the moco-controller so that it removes StatefulSet but keeps the PVCs and all other resources. When the user wants to restore the cluster, the moco-controller will just create the StatefulSet, which will reuse the PVCs.
Does it sound good?

Sounds like that would work. Scaling the STS down to 0 would probably be equivalent.

I've done a little local experimenting with and have it working reasonably well, but the controllers are throwing a lot of benign errors as a result. If this approach proves workable in my setup I'll clean up the implementation. My approach is to add another property to the spec, rather than setting the spec.replicas=0, since the replica count in the CRD has implications for clustering.


Stream stays online, al lot of CPU usage

HA docker 2024.1.6
WebRTC hacs v3.5.1
After viewing streams in Home Assistant with a WebRTC dashboard streams stays online and are using a lot of CPU usage. I can't stop the online streams, visible in go2rtc streams web view with a non zero. Not even with switching off Wi-Fi on the device which I viewed with. The online connections only disappear if I reload the WebRTC integration.

This also sometimes happens directly when loading go2rtc in the browser and then cloading the webrtc stream - ffmpeg stays running in the background


Respect the tile grid's extent in ol.source.TileVector

By adding a getTileCoordForTileUrlFuction() method like for ol.source.Tile, we can now properly handle extent and resolution restrictions, and reuse tiles on wrapped worlds. Also adds the missing wrapX option to ol.source.TileVector.
Fixes #3798.

LGTM


Trim all dots/whitespace from end of dirname for Windows

Windows doesn't allow . + whitespace at the end of directory names - but it just drops them invisibly instead of throwing an error. So for 'The Hero Suddenly Proposed to Me, but . . . ', the directory gets created as 'The Hero Suddenly Proposed to Me, but' and then create_zip() throws an exception because the directory doesn't exist.  This strips them off the end first.

Don't pad arguments for a function call with spaces. None of our existing code does this.

https://github.com/sizer99/cum will be fixes and enhancements to make cum work with Batoto.  Either take the fixes or don't, I won't be doing any more pull requests.


Slightly improved README

This PR updates the README to include guidance on installation and usage of this package.
This should make it easier for people to test and use native voice, since they will have more concrete direction on how it is used.

Travis is failing on this PR due to changes to cibuildwheel which are accounted for in #5.

Should be worth noting this entire module is basically an experiment since it doesn't have feature parity with the actual parent module (it's a bit hard to do that anyway...)


Anchorize footnotes

Resolves #90
A footnote will will generate an "id" on both the hyperlink on the main text and the list item on the footnote that both serve as anchors. The generated html is as follows

Like this1.

A footnote ↩

Where in the above #fn-1 is the anchor for the main text and #fnref-1 is the anchor for the footnote
The footnote on the list item is a little awkward since the anchor is positioned in Positioner::position() which doesn't get sent list items. Instead a pending anchor is pushed that gets attached to the inner paragraph element
Aside: The footnote doesn't get a numbered list even though it should. I'm assuming some of the more complicated elements in the footnote are causing the interpreter state to get messed up
Other aside: The footnote number isn't a superscript, but I think you mentioned that was one of the side effects of the glyphon switch
Demo
# Header

Like this[^1].

1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler

Another footnote[^2].

1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler
1. filler

- [To Header](#header)

[^1]: A [footnote](https://www.markdownguide.org/extended-syntax/#footnotes)
[^2]: 2nd [footnote](https://www.markdownguide.org/extended-syntax/#footnotes)

https://github.com/trimental/inlyne/assets/30302768/704eb582-f882-4bba-a8d2-9cff80759c1f

Looks like a good change. I want to focus on multisized font lines in glyphon for things like  and  soon but I think I'll do that once I've got taffy up and running as that may be hard enough to do without adding weird positioning hacks to the text rendering code.

That'd be great! (but also no rush at all of course)


Typos in the docs

Describe the bug
Hey, I have seen some typos in the v4->v5 changelog page. Can I go ahead and fix those typos?
Version of Package
Related to docs
To Reproduce
NA
Expected behavior
There are some typos in the docs

For sure, you can submit a PR.

Oh okay.


Template

template does not work when it is offline

Hi @Afdhal-Mahdi , make sure that your base url correct or may you can show me your html source of the home page. Hope I can help you to solve this issue.


Location of this repository

The codspeed workflow is to have a repository and automatically benchmark PRs to it. We'll set up a cron job to run it weekly or so (gh-4). The question is where to place the repository, should it live in the OpenBLAS organization?

Following the offline discussion with @rgommers, the most maintainable solution seems to be to move the benchmark collection + CodSpeed integration to the OpenBLAS repository. This way, each OpenBLAS PR would trigger a CodSpeed run on x86.
The work needed is:

remove scipy_openblas32 wheel from the equation, reuse a from-source openblas build;
send an OpenBLAS PR with the benchmarks and CI scripts;
hook up the OpenBLAS repository to CodSpeed.

The first two items I'm ready to provide a PR for. The last one needs an action from an OpenBLAS repository owner/maintainer. The amount of work is about five minutes: register on CodSpeed, click on a repository and add their token to the OpenBLAS repo settings. WDYT @martin-frbg?

My (perhaps misguided) question is how many files this will add to the OpenBLAS repo, including any generated by the benchmark runs ? (If it turns out to be a significant amount that would be needlessly cloned by people, perhaps making it a separate project under the OpenMathLib organization would make sense.)

I have now connected the OpenMathLib/OpenBLAS repository with codspeed - hope I did it right

Right now it would be seven source files, none of them autogenerated (two meson.build files, a single python source for the benchmarks themselves, one f2py recipe, two more source files to build the python wrapper, and the CI yml recipe :-)). Benchmark run results will be all stored by "them".


error occured  on initiaion of 11-slim-faststart type

i can start the database and use it with no problem currently.
but every time error output can be confirmed like below.
2023-04-19T07:15:47.765538000Z #########################
2023-04-19T07:15:47.765573000Z DATABASE IS READY TO USE!
2023-04-19T07:15:47.765601000Z #########################
2023-04-19T07:15:47.767810000Z
2023-04-19T07:15:47.768159000Z ##################################################################
2023-04-19T07:15:47.768211000Z CONTAINER: The following output is now from the alert_XE.log file:
2023-04-19T07:15:47.768244000Z ##################################################################
2023-04-19T07:15:47.783278000Z     DATAFILE '/u01/app/oracle/oradata/XE/MYDB.dbf'
2023-04-19T07:15:47.783537000Z     AUTOEXTEND ON NEXT 1G
2023-04-19T07:15:47.783579000Z     MAXSIZE UNLIMITED
2023-04-19T07:15:47.783609000Z Wed Apr 19 16:15:37 2023
2023-04-19T07:15:47.783638000Z Errors in file /u01/app/oracle/diag/rdbms/xe/XE/trace/XE_j001_117.trc:
2023-04-19T07:15:47.783665000Z ORA-12012: error on auto execute of job "SYS"."BSLN_MAINTAIN_STATS_JOB"
2023-04-19T07:15:47.783724000Z ORA-06550: line 1, column 807:
2023-04-19T07:15:47.783760000Z PLS-00201: identifier 'DBSNMP.BSLN_INTERNAL' must be declared
2023-04-19T07:15:47.783913000Z ORA-06550: line 1, column 807:
2023-04-19T07:15:47.783948000Z PL/SQL: Statement ignored

Hi @kaiei-chou,
You can happily ignore that error.
This is just an output written in the database's alert log (CONTAINER: The following output is now from the alert_XE.log file).
Oracle 11g XE (and later versions) do not include all Oracle Database functionality and thus some errors may be seen.
I highly recommend using the latest image (Oracle 21c XE) or even migrating to github.com/gvenzl/oci-oracle-free

thanks. feel relieved to hear that I can ignore it


write_verilog generate "always @*" blocks that can't be emulated properly

Steps to reproduce the issue
Consider the following nMigen code:
from nmigen import *
from nmigen.cli import main

class Top(Elaboratable):
	def __init__(self):
		self.a = Signal()

	def elaborate(self, platform):
		m = Module()

		with m.FSM():
			with m.State("aaaaaaaa"):
				m.d.comb += self.a.eq(1)

		# Workaround to
		b = Signal()
		m.d.sync += b.eq(1)

		return m

if __name__ == "__main__":
	top = Top()
	main(top, ports=[top.a])

Which will generate the following RTLIL code:
attribute \generator "nMigen"
attribute \top 1
attribute \nmigen.hierarchy "top"
module \top
  attribute \src "verilogfail.py:6"
  wire width 1 output 0 \a
  attribute \src "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/ir.py:526"
  wire width 1 input 1 \clk
  attribute \src "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/ir.py:526"
  wire width 1 input 2 \rst
  attribute \src "verilogfail.py:11"
  wire width 1 \fsm_state
  process $group_0
    assign \a 1'0
    attribute \src "verilogfail.py:11"
    switch \fsm_state
      attribute \src "verilogfail.py:12"
      attribute \nmigen.decoding "aaaaaaaa/0"
      case 1'0
        assign \a 1'1
    end
    sync init
  end
  attribute \src "verilogfail.py:16"
  wire width 1 \b
  attribute \src "verilogfail.py:16"
  wire width 1 \b$next
  process $group_1
    assign \b$next \b
    assign \b$next 1'1
    attribute \src "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/xfrm.py:519"
    switch \rst
      case 1'1
        assign \b$next 1'0
    end
    sync init
      update \b 1'0
    sync posedge \clk
      update \b \b$next
  end
  connect \fsm_state 1'0
end

Which will result in the following Verilog:
/* Generated by Yosys 0.9+2406 (git sha1 021ce8e5, gcc 10.1.1 -fPIC -Os) */

(* \nmigen.hierarchy  = "top" *)
(* top =  1  *)
(* generator = "nMigen" *)
module top(clk, rst, a);
  (* src = "verilogfail.py:6" *)
  output a;
  reg a;
  (* src = "verilogfail.py:16" *)
  reg b = 1'h0;
  (* src = "verilogfail.py:16" *)
  reg \b$next ;
  (* src = "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/ir.py:526" *)
  input clk;
  (* src = "verilogfail.py:11" *)
  wire fsm_state;
  (* src = "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/ir.py:526" *)
  input rst;
  always @(posedge clk)
      b <= \b$next ;
  always @* begin
    a = 1'h0;
    (* src = "verilogfail.py:11" *)
    casez (fsm_state)
      /* \nmigen.decoding  = "aaaaaaaa/0" */
      /* src = "verilogfail.py:12" */
      1'h0:
          a = 1'h1;
    endcase
  end
  always @* begin
    \b$next  = 1'h1;
    (* src = "/home/jeanthomas/.local/lib/python3.8/site-packages/nmigen/hdl/xfrm.py:519" *)
    casez (rst)
      1'h1:
          \b$next  = 1'h0;
    endcase
  end
  assign fsm_state = 1'h0;
endmodule

Expected behavior
When the above Verilog code is emulated using a Verilog simulator (say Icarus Verilog), a register isn't initialized because there is no event at t=0 triggering the always @* block.
Actual behavior
At t=0, a is set to its initial value.
Related
nMigen issue for this bug: https://github.com/nmigen/nmigen/issues/418 (cc @whitequark)

For context, we already discussed this on a Yosys meeting, and decided that the solution here differs by the mode. In SystemVerilog mode (which doesn't exist yet), write_verilog should just use always_comb. In Verilog-2001 mode, something like this:
reg init;
initial init = 0;
reg x;
always @* begin
    if (init) begin end
    x <= 1;
end

See #2272 and #2273.

Reopening because Verilog-2001 mode is still broken.


Allow language switcher dropdown to expand horizontally

Handy for displaying languages with very long names!
Part of mysociety/alaveteli#2989.
Before:

After:

:+1:


fix dist route security issue

you can download any file just by knowing the location:
https://rems.darkube.app/dist/?file=../rems.nimble

https://owasp.org/www-community/attacks/Path_Traversal


Slow rendering of adaptive cards causes frame drops

Platform

Android

Host
Microsoft Teams
Version of SDK
1.0 / 1.1
Issue
The slow rendering of cards ( due to extreme nested view hierarches created more than 15 levels of depth in some cases ) causes extreme slow rendering of cards
{ 	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json", 	"type": "AdaptiveCard", 	"version": "1.0", 	"height": "stretch", 	"verticalContentAlignment": "center", 	"body": [ 		{ 			"type": "TextBlock", 			"text": "Hi," 		}, 		{ 			"type": "TextBlock", 			"text": "MasterHip", 			"isSubtle": true 		}, 		{ 			"type": "ColumnSet", 			"height": "stretch", 			"columns": [ 				{ 					"type": "Column", 					"width": 1, 					"items": [ 						{ 							"type": "TextBlock", 							"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet...", 							"wrap": true 						} 					] 				}, 				{ 					"type": "Column", 					"width": 1, 					"verticalContentAlignment": "top", 					"items": [ 						{ 							"type": "TextBlock", 							"text": "This text should be at the top", 							"wrap": true 						} 					] 				}, 				{ 					"type": "Column", 					"width": 1, 					"verticalContentAlignment": "center", 					"items": [ 						{ 							"type": "TextBlock", 							"text": "This text should be at the vertical center", 							"wrap": true 						} 					] 				}, 				{ 					"type": "Column", 					"width": 1, 					"verticalContentAlignment": "bottom", 					"items": [ 						{ 							"type": "TextBlock", 							"text": "This text should be at the bottom", 							"wrap": true 						} 					] 				} 			] 		} 	] }
This card itself takes 20ms to render + 35ms to parse ( Each card should be rendered in < 15 ms to ensure no frame drops in android ) . More complex cards take 50+ms to render essentially making scrolling not possible .

Have you tried to do the parsing in a background thread (making the call to function AdaptiveCard.DeserializeFromString(jsonText, AdaptiveCardRenderer.VERSION, elementParserRegistration); ) and after parsing rendering the result in the UI thread (calling this other function AdaptiveCardRenderer.getInstance().render(this, getSupportFragmentManager(), parseResult.GetAdaptiveCard(), this, hostConfig); ) ??

We parse the json in main thread and cache it . But rendering needs to happen on main thread . I think the view hierarchy could be flattened a bit to allow fast rendering .

Also the parser is really slow . Parsing should not ideally take more than a couple of milliseconds . Not sure but i feel it is a problem with the JSON library that is being used

Does this still repro on a more recent version of the renderer? If so, please feel free to reactivate.


Use writable buffer writer

/cc @benaadams

@pakrym run a measurement on the end to end. Last I checked it didn't improve anything.

@davidfowl what if it improves Output benchmark only?

This one did too https://github.com/aspnet/KestrelHttpServer/pull/1562.

Run both and report the numbers.

@pakrym builds breaks

dev

[01:07:53.530] Warmup
[01:08:09.631] RPS: 1197771.77
[01:08:09.633] Benchmark
[01:08:25.671] RPS: 1225775.69

KestrelHttpServer@pakrym/wbw

[01:09:36.210] Warmup
[01:09:52.287] RPS: 1255312.63
[01:09:52.292] Benchmark
[01:10:08.337] RPS: 1273102.54


chore: add PLATFORM to versionInfo file

Extracted from #521
This prepares the launcher to know for which platform it was built. To include that information in a local build run the following (replacing the value with the platform/architecture of your choice):
export PLATFORM=linux64
./gradlew linux64DistZip

@skaldarnar What happens if I do
export PLATFORM=windows64
./gradlew linux64DistZip

Then the linux64 distribution will think it was actually build for windows64.
Instead of taking that information from the environment, we may take it from the task itself. I don't know whether there's a good way to update the properties file, and there's still the problem that it is located within the JAR - which is already built when we get the platform information... =/
@jdrueckert Feel free to suggest a better approach here.

If we are not implementing the self-update this information is likely not needed. As the proposed solution is all but ideal I'll just close this PR.


Two Accessibility Issues

the list of suggestions is not accessible with arrows, most screen readers and other assistive technologies will not understand the element.
Also, the aria-label of all the list items will have the same value (which is the search keyword) rather than the suggestions themselves (the list item's content). This will lead, for example,  to repeatedly hear the postcode numerous times, not the actual addresses to select from. See below:

There is no way to customize the input to return the suggestions as a datalist, that would be the ideal solution for all scenarios.
Thank you for the great package and for the good work BTW.

There is no way to customize the input to return the suggestions as a datalist, that would be the ideal solution for all scenarios.

All three elements, input, list and list-item, are able to be overwritten with your own custom components.
However, I do agree that the accessibility of the default components could be improved and will do so in a future PR.


Package.swift in master branch and 0.1 tag

Both Package.swift file order are not the same, 0.1.0 tag need update to reflect correct Package.swift order.

The Package.swift file order will be changed for the next release that will support the 07-20snapshot.

0.2 has the correct order now.


merge autorest 20221602 3

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

/azp run net - tables - ci

The ci has passed but github can't see the update for some reason https://dev.azure.com/azure-sdk/public/_build/results?buildId=1373601&view=results


should the optimizer state dic be loaded in self-critical?

Hello @ruotianluo .
After training with XE, and when we want to start self-critical training, it is clear that we should load the model. But should the optimizer state dictionary be loaded from the XE ckpt as well? In your code, you load it, but I saw other codes don't and they just define a new optimizer from scratch.
Thanks

Yes, that's what I did. I think there is no big difference.

Actualy you are not defining a new one. You are loading the old one, as here:
    if opt.start_from is not None and os.path.isfile(os.path.join(opt.start_from,"optimizer.pth")):
        optimizer.load_state_dict(torch.load(os.path.join(opt.start_from, 'optimizer.pth')))

In your code, you load it
I am agreeing this

sorry. Alright thanks for your reply. I don't think it matters but i just wanted to check


Is this normal

Is this normal cause my account isn't 15 days old yet and maybe it's that or do I need to redo cause I messed up?

duplicate of #26


Add option for primer set

I had to add a couple of input files to step test Quast, which are in "consensus-genome/test/quast", I can reorganize though if preferred.

@morsecodist

consensus-genome/test/no_host_1.fq.gz is empty is that intentional?
I think the commit might be empty, since the file is already in main, but I think the file is still there. I think this showed up because of a weird rebase that I did.


Lock screen unlock doesnt work on Ubuntu

It works fine for everything else, but times out on the lock screen. Tried  sudo chmod -R 755 /lib/security/howdy and setting the no_confirmation to true in the config.
auth.log

Hi, I'm no expert but followed some other suggestions and added this line:
auth sufficient pam_python.so /lib/security/howdy/pam.py
To this file on line 2:
/etc/pam.d/sddm
All seems to be working now :)

Have you tried that solution @Fhesseti ?


documentation about entry points is unclear

First, thanks for making an awesome tool! Click made knocking together a CLI for my masters work trivial.
These documentation questions are an effort to clarify some of the language in the setuptools and shell completion sections, to reduce friction for new users like me.

Though Shell Completion depends on users installing through a setuptools entrypoint, and refers to the Setuptools Integration docs, the terminology is not aligned between the two sets of examples. Scripts in Packages refers to the package yourpackage, a subpackage scripts, a module yourscript, and a click command cli. Shell Completion refers to PROG_NAME, "the executable name in uppercase...". Does PROG_NAME map to the the name of the package yourscript, the entrypoint yourscript, the command cli, or something else entirely? Clarification of exactly what the "executable name" is here would be very helpful.
In the Scripts in Packages example, it is unclear that the console_scripts key is a "default" value, and not something package-specific. For users who have worked with entrypoints in setup.py before, this is probably obvious, but for newcomers there's no visual way to differentiate "standard" values from semantically meaningful ones in this example. A single-sentence note clarifying would help.

Python version: 3.8
Click version: 8

Happy to review a PR.

Currently working on issue.


AUR Build Error

First i tried installing it using paru -S gittyup then paru -S gittyup-git and last with git clone git clone https://aur.archlinux.org/gittyup.git & makepkg -si
Always the Same error.
Do you have an Idea how this could happen?
[***@*******-arch ~]$ gittyup
Theme dir:  QDir( "/home/***/packages/github/gittyup/src/build/Resources" , nameFilters = { "*" },  QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntries ) )
Theme dir:  QDir( "/home/***/packages/github/gittyup/src/build/Resources" , nameFilters = { "*" },  QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntries ) )
PANIC: unprotected error in call to Lua API (cannot open /home/***/packages/github/gittyup/src/build/Resources/System.lua: No such file or directory)
Aborted (core dumped)
[***@*****01-arch ~]$

OS: Arch
Kernal: 5.18.12-zen1-1-zen
WM: Awesome

Is there any reason why it would be calling lua files from the build directory rather then an installed location in the first place?

@elman22 got the Aur package to work.

I had no Build Error, but after the Build the Software wouldn't run and through the Same Error:
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway. Theme dir:  QDir( "/home/jki/.cache/paru/clone/gittyup/src/build/Resources" , nameFilters = { "*" },  QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntries ) ) Theme dir:  QDir( "/home/jki/.cache/paru/clone/gittyup/src/build/Resources" , nameFilters = { "*" },  QDir::SortFlags( Name | IgnoreCase ) , QDir::Filters( Dirs|Files|Drives|AllEntries ) ) PANIC: unprotected error in call to Lua API (cannot open /home/jki/.cache/paru/clone/gittyup/src/build/Resources/System.lua: No such file or directory) Aborted (core dumped)

Ah ok I thought you got it completely run. Sorry then for disturbing

i use flatpak now :)

i use flatpak now :)

haha ^^.

He was able to get it running

When building directly from AUR, I got the same error as @hofq. But then I tried to edit PKGBUILD using patch by patlefort from https://aur.archlinux.org/packages/gittyup#comment-872036, changed version to 1.1.2 and it is working now.

Many of the issues AUR builds were running into have been fixed in master, but they haven't landed in a stable release yet. I'll update the stable AUR package when there is a new release. I've also contacated the -git package maintainer with an offer to help get it updated. In the mean time if you're hankering for a build you can try this PKGBUILD.

@alerque this was the latest mr before the release mr. So it will not take that long anymore until the new release

Cool beans!
I don't think we're quite far enough along cleaning up the 3rd party dependency scene to move it to [community] this release cycle, but #314 sure brought it a lot closer. In any event even if [community] is one more release cycle off we should be able to get a pretty stable easy to compile AUR build going for this cycle (and of course I host prebuilt versions of all my AUR packages).


Error: Failed to launch the browser process

I couldn't run it on my mac machine, what could be the reason? :(

The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

@believe75 hi!
Use this one https://waha.devlike.pro/docs/overview/quick-start/#11-download-image-on-arm
# Download the image
docker pull devlikeapro/whatsapp-http-api:arm
# Rename it, so you can use devlikeapro/whatsapp-http-api image in other place
docker tag devlikeapro/whatsapp-http-api:arm devlikeapro/whatsapp-http-api


Event Fees/Payments

Update: https://sfdo-community-sprints.github.io/summit-events-app-documentation/docs/advanced-features/capturing-payments/events-fees/
Review: No previous documentation
Intent:

Articulate the need and desire to capture event fees during the registration process
Walk through how to create the right things in Salesforce to capture event fees
Walk through the registrant experience, less actually making the payment.
Talk about different use cases and examples related to event fees only.

@rdblake21 I am marking this as complete but if you get a chance, can you review?


Update docs with options

In the docs, not all available options for each zstash command are described. --keep needs to be added for check and update. -v needs to be added for create, check, update, extract, and ls.

#94 merged, so we can close this issue.


Updating the model on change based on fields calculations

My model reducer is linked to a state like this :
state= {
  a: 2,
  b: 3,
  result: 5
}

In my Form, I have 2 <Fields /> pointing to state.a and state.b
I want to calculate, as the user is typing and while validating his input the result of state.a + state.b
As soon as the user has typed correct values, I want to display this result, update state.result with the calculated value while still updating the model as he keeps on typing.
How would you do it ?
Thank you.
I made it work for the onSubmit event, but I can't seem to find a proper way to do it onChange. Feel free to ask me if you need more context or code to understand my question :)

As Redux suggests, result is derived data so it's best handled in a selector: http://redux.js.org/docs/recipes/ComputingDerivedData.html
So you ideally would have a state that only contains non-derived data:
state = {
  a: 2,
  b: 3,
}

and a selector:

const MyComponent = // ...

export default connect((state) => ({
  ...state,
  result: state.a + state.b,
})(MyComponent);

Oh, I see ! Indeed, that makes a lot of sense.
Thank you for pointing me in the right direction and for creating react-redux-form :)


Added no-self-import rule

New rule checks against importing from the current file. Ref #447.
First time working with eslint rules. Please review.

Coverage decreased (-1.9%) to 95.701% when pulling 85b2e716bfdafbbe2790eeddd7bc9b919c635f9d on just-paja:feature/no-self-import into 6e12c9e24e6c4fc770093637f976e1a84b633d40 on benmosher:master.

I think this rule should leverage the resolve infrastructure.
At least, if resolve comes back non-null, then the result should be compared with context.getFilename(). Then the resolver is responsible for things like missing extensions, aliases, linklocals, etc.

This would be a cool rule to have!
Are you still up to work on this @just-paja? No worries if you're not :)

Hey, sorry all, I completely forgot about this. @jfmengels, I will happily pass this to you.

Hey, no problem ;)
Not sure if/when I'll get to this. It's up for the taking if someone wants to have a go at it.

If it's all right with everyone. I would like to take a crack at this one.

Please do @giodamelio!

Awesome, I just opened #727.


Consider Kitto.root when serving static assets

This is necessary to use kitto in umbrella projects.
See bug #52

Hello, @chrta! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

On my local PC, mix test is working without issues...

Coverage remained the same at 86.477% when pulling cd29a0f44a5cbc58bc9b80481aa87ccb3bb31be1 on chrta:bugfix-for-#52 into 7eeda801218c9af3c76da8cc51478ff5d592b616 on kittoframework:master.

Looks good. The test failure was due to a flawed test which has to be re-written.


cannot import name 'build_flow_not_intersect' from 'loss_functions_summary'

I run train.py according to the tutorial, but the following error is reported：
Traceback (most recent call last):   File "/home/lcj/lcj/SLAM/DOPlearning-master/train.py", line 21, in <module>     from loss_functions_summary import compute_errors, compute_epe, compute_all_epes, flow_diff, spatial_normalize_max, spatial_normalize_mean, new_static_mask, build_flow_not_intersect ImportError: cannot import name 'build_flow_not_intersect' from 'loss_functions_summary' (/home/lcj/lcj/SLAM/DOPlearning-master/loss_functions_summary.py)
I checked loss_functions_summary.py, there is no build_flow_not_intersect function here.

Yes, the build_flow_not_intersect function is not in loss_functions_summary.py, because the function is actually for another project. We had deleted it before uploading the codes. Sorry for that I forgot to delete the import of the function. I have deleted the import now. You can run the codes again.


Make setuptools dependency optional

Fallback assignment of model_utils.__version__ = None if pkg_resources can not be imported due to setuptools not being installed
Problem
Fixes https://github.com/jazzband/django-model-utils/issues/506
Solution
Wrap pkg_resource import in a try block as done in other projects like pytz to make dependency optional.
Commandments

[ ] Write PEP8 compliant code.
[ ] Cover it with tests.
[ ] Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
[ ] Pay attention to backward compatibility, or if it breaks it, explain why.
[ ] Update documentation (if relevant).

https://github.com/jazzband/django-model-utils/pull/545 replaced pkg_resource with importlib


[python/r/c++] Fold in TileDB Core 2.15.3

Along with concomitant TileDB-Py and TileDB-R micros as they become ready

There is nothing SOMA-specific in 2.15.3, and 2.16 is coming soon.


Unable to install on Ubuntu 16.04

Hello, I got the following error on trying to install Weex. Please see what might have gone wrong.
~# npm install -g weex-toolkit
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
/usr/local/bin/weex -> /usr/local/lib/node_modules/weex-toolkit/bin/weex

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/weex-toolkit/node_modules/spawn-sync
> node postinstall

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/weex-toolkit/node_modules/weex-previewer
> node ./src/hook/post-install.js

Error:permission denied.Please apply the write premission to the directory: "/root"

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/weex-toolkit/node_modules/xtoolkit
> node ./src/hook/post_install.js

init toolkit directory error!
we suggest you run "sudo chmod 777 ~" and re installor you can try "mkdir ~/.xtoolkit&&chmod 777 .xtoolkit"
/usr/local/lib/node_modules/weex-toolkit/node_modules/xtoolkit/src/util/index.js:40
            throw e
            ^

Error: EACCES: permission denied, mkdir '/root/.xtoolkit'
    at Error (native)
    at Object.fs.mkdirSync (fs.js:923:18)
    at Object.exports.init (/usr/local/lib/node_modules/weex-toolkit/node_modules/xtoolkit/src/util/index.js:34:16)
    at Object.<anonymous> (/usr/local/lib/node_modules/weex-toolkit/node_modules/xtoolkit/src/hook/post_install.js:7:6)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
/usr/local/lib
`-- (empty)

npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/weex-toolkit/node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm ERR! Linux 4.4.0-89-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install" "-g" "weex-toolkit"
npm ERR! node v6.11.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>postinstall: `node ./src/hook/post_install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'node ./src/hook/post_install.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the xtoolkit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node ./src/hook/post_install.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs xtoolkit
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls xtoolkit
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /root/npm-debug.log
npm ERR! code 1

I saw that the error message mentions the directory ~/.xtoolkit but it's already there with 777 permissions.

@ankush981 Could you find the solution?

@flowck Nope. I gave shortly after that. :disappointed:

@ankush981 I had the same problem, fixed by running chmod 777 ~/ and then I had another problem due to my nodejs version (4.4), I updated to 8.0 and then worked fine.

Solution provided by @flowck worked for me. A big thank you.


No securityContext set

The deployment does not set the securityContext. Can the securityContext be added to the deployment(s)?

Would you like to change the default user mattermost (id 2000) from the image you use ?
Or is this a bug between the latest versions of mattermost and the /data and /plugins volumes ?
In another words, would you like to have it in the values file or just fix the bug ?

We are installing mattermost on k8s clusters that have PodSecurityPolicies enabled. In the deployment manifest the securityContext needs to be set. It would be useful if this could be configured in the values file.

If you use the official mattermost docker image, the process and volumes must stick to the mattermost user ownership (from 5.14 onwards). Then, securityContext shouldn't be configurable to avoid mistakes.

@etlfg It is good practice to have restricted PodSecurityPolicies in place. This is to ensure that pods do not run as root. Certain cloud providers like OpenShift will have such policies in place. To make mattermost compliant, the securityContext must be set:
 securityContext:         runAsUser: 2000         fsGroup: 2000
One could do what @mdekoster has done. However the community would appreciate the same patch being applied to the chart.

added for MM-EE
for MM-TE will come next


Add showAboutDialog sample

Description
Added a sample that shows two ways to open AboutDialog using showAboutDialog and AboutListTile widget
Related Issues
[#34495]
Tests
I added the following tests:
No tests added
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

@googlebot I signed it!

Done.

LGTM