Minify CSS, HTML and JS before merging with Main branch

Remember to minify the frontend parts into a optimized branch before merging into the main branch for slight performance gain!

I think we should focus on keeping the readability in the main branch also as we may need to clone from this when fixing bugs in the future but we could minify the the frontend code before we create a release.

Yeah waiting until the release build to minify is definetly smarter. Something we could do is automate minify to happen automatically when the working css file is saved, and save the minify version in a seperate release-directory. We could do this with Node.js and Gulp.

I think we should focus on keeping the readability in the main branch also as we may need to clone from this when fixing bugs in the future but we could minify the the frontend code before we create a release.

Yeah waiting until the release build to minify is definetly smarter. Something we could do is automate minify to happen automatically when the working css file is saved, and save the minify version in a seperate release-directory. We could do this with Node.js and Gulp.

Yes that sounds good, if it slow down the ide too much we could create do the optimisation automatically when the dev branch is pushed in to master. We will later tag the master branch with release tags when we feel happy with the state.


bad permissions for /usr/local/lib/python2.7/dist-packages/kivy/data/ on linux

After a fresh install of kivy from source (make force; sudo make install) I tried to run an example (bezier.py) and got the error
   File "bezier.py", line 12, in <module>
     from kivy.app import App
     ...
 IOError: [Errno 13] Permission denied: '/usr/local/lib/python2.7/dist-packages/kivy/data/style.kv'

It looks like files under kivy/data need to be chmod a+r
$ ls -al /usr/local/lib/python2.7/dist-packages/kivy/data/
total 72
drwxr-sr-x  7 root staff  4096 Nov 19 14:53 .
drwxr-sr-x 18 root staff  4096 Nov 19 14:53 ..
drwxr-sr-x  2 root staff  4096 Nov 19 14:53 fonts
drwxr-sr-x  2 root staff  4096 Nov 19 14:53 glsl
drwxr-sr-x  2 root staff  4096 Nov 19 14:53 images
drwxr-sr-x  2 root staff  4096 Nov 19 14:53 keyboards
drwxr-sr-x  2 root staff  4096 Nov 19 14:53 logo
-rw-r-----  1 root staff  2603 Nov 19 14:08 settings_kivy.json
-rw-r-----  1 root staff 40704 Nov 19 14:08 style.kv

(subdirs like data/fonts show the same issue)

@thopiekar, have you seen this before? I couldn't reproduce it when I last tried.

This is an installation from source, not from a distributed package. We do not control these permissions.
This is almost certainly an issue with the umask in effect on your system/user. And this is now an old issue - if you are still experiencing difficulty, feel free to join us on our IRC channel for support, but this is not an issue with Kivy itself.


[Feature Request] JSON-RPC method for calling Move func or executing Move code.

🚀 Feature Request
A JSON-RPC method that can call a Move functions defined in stdlib or modules that will be used by transaction script, returns the function call result.
It is also acceptable to define a specific set of functions for this method to call.
Motivation

We have some calculation logic used by transaction script, like calculate non-XDX currency travel rule limit threshold. To give a client accurate number of the threshold number, we should have a way to invoke same logic for the client built by different language.
Explore options like https://web3js.readthedocs.io/en/v1.2.11/web3-eth-contract.html

Pitch
TBD
Describe alternatives you've considered

Are you willing to open a pull request? (See CONTRIBUTING)
Additional context
Current travel rule limit threshold is defined for XDX only, for different currency, you need convert the amount into XDX currency amount first for comparing with the threshold. The calculation involves divide, thus may cause rounding difference if we tried to replicate same logic into different languages.
Client need know exact number of the threshold number for deciding whether the payment requires metadata signature for dual attestation.

CC @jolestar, who I think has mentioned this in the past.

@vgao1996, are there any blockers left for implementing this now that the execute_function refactoring is done?

How about the RPC API designed?  The json RPC method can call any Move function? if the function change the state, should return an error or return the state and function result both? eth only support call read-only function.

How about the RPC API designed? The json RPC method can call any Move function? if the function change the state, should return an error or return the state and function result both? eth only support call read-only function.

support read-only function is fine.
I think the best will be given input, move function, get output, the move function can only operate on the input.

are there any blockers left for implementing this now that the execute_function refactoring is done?

@sblackshear Sorry for the late reply. I don't think there are road blockers left.
I do have a few questions however:

Should this be metered? If so, how?
Overall this seems to be a very powerful feature. Is it desired to expose the Move layer directly to clients? How would this compare with the option of adding a new interface to the Diem adapter, which the clients can interact with, and that the Diem adapter will use a Move VM internally to get the result. Would the latter achieve better encapsulation?
This also doesn't really look that different from our existing scripts & function scripts -- maybe another option is to allow them to return values to clients?

I think the best will be given input, move function, get output, the move function can only operate on the input.

"Input" includes both the function arguments and the current on-chain state, correct?
Also: I think it's quite reasonable to start with this, but in the long run we might want to support lifting the read-only restriction + returning the WriteSet from the function call as well. That could be a powerful dev tool, but isn't needed for the initial use-cases.

Should this be metered? If so, how?

I think this is important for the long term (since in the presence of custom modules, an author can expose a non-terminating endpoint), but not as important in the short term for Diem because our exposed functions are very limited. I would suggest an approach where we set a fairly low max_gas_units on the server side (high enough to accommodate use-cases like reading on-chain constants, but not much more) and consider increases as we see the need.

Overall this seems to be a very powerful feature. Is it desirable to expose the Move layer directly to clients? How would this compare with the option of adding a new interface to the Diem adapter, which the clients can interact with, and that the Diem adapter will use a Move VM internally to get the result? Would the latter achieve better encapsulation?
This also doesn't really look that different from our existing scripts & function scripts -- maybe another option is to allow them to return values to clients?

I think directly exposing an API for calling Move functions is desirable. The way I think about this is:

The Diem adapter layer takes transactions as input and produces writes to the ledger as output
The new API we will expose takes functions as input and returns values as output (no writes or side effects of any kind)

Because the inputs and the roles of these layers are so different, it makes sense to expose them via separate APIs. I don't think encapsulation is a concern for this new layer because it is read-only; it is only a more convenient way of exposing information that clients already had access to.

The separation of roles makes sense to me! Just one question: how do we enforce that these queries are actually read-only? I can think of two ways:

We simply don't commit the write set.
Implement another verifier check disallowing borrow_global_mut, move_to and move_from.

I never expect this function execution can change anything on-chain or local database data.
So I should state it in this way: readonly is required.

Yes, totally agree that function execution can't modify anything! What I was suggesting is that because of Move's execution model (which outputs a WriteSet instead of performing modifications on-the-fly), we could still choose to allow users to execute Move functions that perform writes and return the WriteSet to the user. Such an execution would be read-only from the perspective of json-rpc, but allow a user to see the writes that a function would perform.

We implement an execute_readonly_function in starcoin base MoveVM
https://github.com/starcoinorg/starcoin/blob/9ce8fc03d96461ab6b8fbcdf58b1e533b2501917/vm/vm-runtime/src/starcoin_vm.rs#L830
if the function change the state will report an error.  I think this can be a Move VM feature.


Implement the nav bar container (the brand and the links) - No styling required

Visual Aid: Figma File

[ ] Create  a container that would store the brand and the navbar
[ ] Create the container for the brand (The Algorithmia logo)
[ ] Create the container for the nav bar
[ ] Add the navigation items
[ ] Add hyperlinks to point to the appropriate pages

@ALX-SE-Algorithmia

@flexywork327 @Collins331 @Maryanemwende @NanaAba08 @Smartjona111
You have all been assigned to work on this issue, and you all will be working with @chykB on it too.
Kindly, note:
The deadline for this project is on or before the 3rd of October 2023.
Facing any issues?
Reach out to @ALX-SE-Algorithmia/code-reviewing-team.


How to limit date range and time range and the same time

Any way how to solve this? I found my question on stackoverflow asked by somebody else too http://stackoverflow.com/questions/28940527/how-to-limit-min-max-time-in-bootstrap-datetimepicker
Lets say I limit datetime picker for 8 to 18h from next Monday to next Sunday but I can select 22h on Wednesday because it's in range. Is it possible?
The only way I found was to separate it as a date and time picker, not datetimepicker. Thanks a lot

Please check the dev branch


create stable builds using AppVeyor from Git tag

#433 makes all the builds pre-release NuGet builds. I am proposing that the stable NuGet builds be done from AppVeyor as well. I do this for my open source and work projects. The AppVeyor NuGet project feed may be used for testing the builds. If a stable build fails testing, you can delete and then re-add the Git tag. AppVeyor will replace the file in the nupkg in the feed.
The changes to appveyor.ps1 would be pretty simple.
if ($env:appveyor_repo_tag -eq 'true' -and isVersionTag($env:appveyor_repo_tag_name)){

We would just need to agree upon what locally the isVersionTag is. I don't currently understand how this repo is being tagged:

Why aren't there any 3.1.2.x builds? Why are there so many? Are some unstable builds? Does the change log only have the stable builds?
https://github.com/fsharp/fsharp/blob/master/CHANGES.txt

Re tagging - yes, it looks like 3.1.2,x tags should have been used at some point.  I don't see any reason not to have used those. CHANGES.txt looks like it has not been kept up to date (I did the last couple of integrations from visualfsharp so it's my fault)
.

If you merge in #437, you and create a <IP_ADDRESS> git tag, it will create a FSharp.Core.<IP_ADDRESS>.nupkg and put it in the AppVeyor Project Feed.  We can then test out that package if rename the AppVeyor Project Feed as explained in #433. After a sufficient period of testing, I can promote it to the NuGet Gallery.

@dsyme Thanks for merging in #433, but it is #437 that is needed before creating the <IP_ADDRESS> tag. Could you merge it in and then move the tag?
PS for moving the tag:
$v = '<IP_ADDRESS>'
git tag -d $v; git push origin ":$v"
git tag $v; git push origin $v


Appstudio update test-component-pac-xvyu

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-xvyu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
46 seconds
build-container

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
16 seconds
deprecated-base-image-check

✅ Succeeded
51 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
16 seconds
sbom-json-check

✅ Succeeded
11 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
10 seconds
show-summary

Pipelines as Code CI/test-component-pac-xvyu-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
29 seconds
build-container

✅ Succeeded
20 seconds
inspect-image

✅ Succeeded
20 seconds
deprecated-base-image-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
8 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary


Manual Hidden Power Feature

So I thought it might be nice to let the player change the move type of Hidden Power manually (as opposed to it being calculated automatically somehow). This would allow a bit of convenience without being overly automated. My idea that I have implemented here is allowing the player to click the move's name to cycle through types, with the color, STAB effectiveness, and move effectiveness all changing dynamically.
The way I did this is to add a special Hidden Power button that is only drawn when the player has the move. If they have it, it gets drawn where the move would normally go, and responds to clicks accordingly. The tracker will store what the player has manually selected as Hidden Power's type, making it so that enemy mons with Hidden Power will still default to normal type.
I've tested this and it should work fully, so I would love to hear your thoughts on this feature or any changes I should make!
Here's a video as well:
https://user-images.githubusercontent.com/61294586/171597645-8c022839-71c5-481e-bf9e-65a8eb817bd4.mp4

Thanks, great catch! I completely forgot about that and have updated it.

Merged! Thanks again for another great addition!


No MEI files are included for testing

Because no actual MEI files are included, nothing shows up on index.html. Perhaps this is intentional, but something somewhere should link to the demo files, perhaps in the readme?

Maybe on Rodan?

Does https://github.com/DDMAL/Neon.js/blob/master/test/data/allneumes.mei work?

Sorry, I was unclear in my issue message. The MEI in the folder is there for qunit testing I'm pretty sure, but we were more looking for the MEI files found in the demo at http://neon.simssa.ca/.
I also just realized we can download those files straight from that page..... so going to close this issue.

Pre-emptively closed, there seems to be no way to access those files from the demo page.

I accidentally clicked close and comment 👎

There are thousands of MEI files on Gershwin in the Liber Usualis folders. Ask @vigliensoni to give you access to Gershwin.

Found MEI files (Both salzinnes and from the demo)


[Multi-Region] Adding pipeline changes for Multi region load tests

Adding multi region support on the ADO pipelines
Bump up the data plane API version

make sure the pr builds are running fine now, its just authentication issue, just ask radhika to update the spn in the github secret. lets make it a habit to wait for builds to be succesful instead of surpassing.

main.js missing.

please add a temporary spn (ask @radhikajain99) to add the same, then the auth will succeed, from next time we should not need this anyway, we can go with WIF


fix: more specific feature test within fmt

Summary

This PR is a bugfix
It does the following (modify list as needed):

Fixes #681

Do you need to upstream this to fmt or is it fixed in the new version?


Hide the URL has changed banner in development

Changes proposed in this pull request:

Hides the banner The Sequencescape URL has changed. Please switch to using the new URL by 9th May: https://sequencescape.psd.sanger.ac.uk/ in the dev environment.

PS: should all this code just be removed? A year should be sufficient...
Related code:
https://github.com/sanger/sequencescape/blob/6320e82c5e52fc5bd5893953e3d98d61c24aaf4f/app/helpers/application_helper.rb#L312C1-L321
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check version

I think it's ben several years... just get rid of it :)


Lambda expession in observer currentWordCount

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-livedata?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-3%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-livedata#8
In which task and step of the codelab can this issue be found?
When setting the observers in the GameFragment
Describe the problem
There is no problem I just wanted to know what is the purpose of the third parameter in the getString method?
viewModel.currentWordCount.observe(viewLifecycleOwner,
   { newWordCount ->
       binding.wordCount.text =
           getString(R.string.word_count, newWordCount, MAX_NO_OF_WORDS)
   })

Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

The word_count string resource has two arguments, the %d's on either side of the word of.
<string name="word_count">%d of %d words</string>

Assuming newWordCount is 3, and MAX_NO_OF_WORDS is 10, then the string would become: 3 of 10 words.
I hope that helps.

@DemisChan Thank you for reaching out to us!
@IanRiley237 Thank you replying, that is exactly the reason.


tweak resource ids for :outcome-panel/contact-nurse-triage and :outcome-panel/for-further-evaluation

Follow up from PR #9

Right now, :outcome-panel/contact-nurse-triage and :outcome-panel/for-further-evaluation make up one sentence but are divided (I'm assuming because of the phone number in between the two). In Korean the order needs to be reversed. But in this case it will still be comprehensible as long as the two phrases stay in one line/sentence and the phone number stays where it is.

How can we re-write the text here in order to handle this situation? tempura supports some light variable interpolation. Maybe we can do something like:
:outcome-panel/contact-call-center "Contact the COVID-19 Nurse Triage Call Center at % for further evaluation."

Would that work @semper21 ?

Yes it would. I can make the changes, but the keys have to be changed for all languages, right?

@semper21 updated the dictionaries to use positional arguments, see https://github.com/LuminareMed/quickscreen-translations/commit/c4b6a041f009cd339394db8605baf8b2c9bc0724
for this issue, see https://github.com/LuminareMed/quickscreen-translations/blob/master/ko.edn#L127-L129

Fixed with PR #13


[Bug]: OAuth 2.0 token is NOT refreshed

Is there an existing issue for this?

[X] I have searched the existing issues

Description
We are not authenticating a data source in this case with Zoho. Zoho provides a token that expires approximately an hour after it is obtained. Once the token expires, Appsmith does not automatically refresh this token, which causes the API to fail.
Steps To Reproduce

Enter the [Zoho development console](https://api-console.zoho.com/add).
Create a new client and use the client called 'Server-based Applications'.
Get your Homepage URL in Appsmith.
Configure the application as follows:

Client Name: <<Appname>>
Homepage URL: <<YourAppsmithApplicationURL>>
Authorized Redirect URIs: https://app.appsmith.com/api/v1/datasources/authorize

Press the CREATE button.
After creating your application, you will obtain your Client ID and Client Secret credentials on a dashboard like this.
Add a new data source of Authenticated API type
Data source configuration

URL: https://expense.zoho.com/
Authentication Type: OAuth 2.0
Grant Type: Authorization Code
Add Access Token To: Request Header
Header Prefix: Bearer
Access Token URL: https://accounts.zoho.com/oauth/v2/token
Client ID: <<YourClientID>>
Client Secret: <<YourClientSecret>>
Scope(s): ZohoExpense.fullaccess.ALL
Client Authentication: Send as Basic Auth header
Authorization URL: https://accounts.zoho.com/oauth/v2/auth

Press the Save and Authorize button.
Verify that everything is working by running this query: api/v1/organizations from this data source using this endpoint. You should receive this output if everything went well.

After an hour and a half the token will expire and appsmith will not refresh it
Public Sample App
https://app.appsmith.com/app/cnv-y3rxhu4/page1-641a223433970d1990c88202
Environment
Production
Issue video log
https://www.loom.com/share/22988ee151e7486396caf325a15aa67e
Version
Appsmith v1.9.12-SNAPSHOT

Hi, thank you very much for that observation! I added access_type: offline, but still the token expires and is not recovered.

Hi @felix-appsmith, We are working on the fix. You may follow this PR -https://github.com/appsmithorg/appsmith/pull/22406

Thank you very much for the effort and your great work!

@felix-appsmith We checked on our side, refresh token works with adding the following in Custom Authentication Params

access_type=offline
prompt=consent

Closing this for now. You may reopen this issue if this doesn't work for you and/or you have some additional info.
Attaching the configs used on our side for reference

@sanveer-osahan This is also happening with the token received from signing into Appsmith with Google. The token available with <<APPSMITH_USER_OAUTH2_ACCESS_TOKEN>> doesn't refresh after an hour. Should we open a separate issue for this?

Hi @AS-Laguna, yes this is a different issue. Please open a separate one for this.

I opened the ticket. #23422


default_body_scrubber Regex.match? call fails if property is non-string.

With, for example, a payload of {"some_property": false}, the default_body_scrubber will fail with the following stacktrace:
Request: POST /some/endpoint
** (exit) an exception was raised:
    ** (FunctionClauseError) no function clause matching in Regex.match?/2
        (elixir) lib/regex.ex:159: Regex.match?(~r/^(?:\d[ -]*?){13,16}$/, false)
        (sentry) lib/sentry/plug.ex:149: anonymous fn/1 in Sentry.Plug.default_body_scrubber/1
        (elixir) lib/enum.ex:1188: anonymous fn/3 in Enum.map/2
        (stdlib) lists.erl:1263: :lists.foldl/3
        (elixir) lib/enum.ex:1188: Enum.map/2
        (sentry) lib/sentry/plug.ex:146: Sentry.Plug.default_body_scrubber/1
        (sentry) lib/sentry/plug.ex:107: Sentry.Plug.build_request_interface_data/2

Reason being, Regex.match? expects a string as the second argument, which a boolean clearly is not. Same goes for any other non-string, ex. integer

Oops, good catch.  Thanks for the report.  🙂
It's been fixed in https://github.com/getsentry/sentry-elixir/commit/fe55fccecbfc62447f4dedb4cf3cdd36597b8ebf and released in 2.0.2

Ah good job reporting this @begedin. I saw this same issue but figured it was a "me" error.


Utils Package

Moved validation.py to a new utils module.
Also made all the methods in validation.py static. This helps enforce the idea that they are separated utility functions. Also the the class doesn't have to be instantiated for the methods to be used.

Looks good to me. Not 100% sure why code cov is annoyed at this change.

I'm a bit confused at this too, it's complaining at this line
line 64 estimators.py
raise ValueError(f"Unsupported type for effect_modifiers {effect_modifiers}. Expected iterable")
Which wasn't affected by this PR..


Fab not visible or in wrong position when put inside Content

react-native, react and native-base version
{
  "main": "node_modules/expo/AppEntry.js",
  "private": true,
  "scripts": {
    "test": "node ./node_modules/jest/bin/jest.js --watch"
  },
  "jest": {
    "preset": "jest-expo"
  },
  "dependencies": {
    "@expo/samples": "2.1.1",
    "@expo/vector-icons": "^6.2.1",
    "expo": "^23.0.0",
    "firebase": "^4.6.2",
    "moment": "^2.19.3",
    "native-base": "^2.3.3",
    "react": "16.0.0",
    "react-native": "https://github.com/expo/react-native/archive/sdk-23.0.0.tar.gz",
    "react-native-datepicker": "^1.6.0",
    "react-native-keyboard-spacer": "^0.4.1",
    "react-navigation": "^1.0.0-beta.19",
    "react-redux": "^5.0.6",
    "redux": "^3.7.2",
    "redux-logger": "^3.0.6",
    "redux-thunk": "^2.2.0",
    "validate.js": "^0.12.0"
  },
  "devDependencies": {
    "jest-expo": "^23.0.0"
  }
}

Expected behaviour
Fab is shown like the example.
Actual behaviour
if Content contains only Fab: Fab is invisible
if Content contains other components: Fab is shown in the wrong position (e.g. right top when is should be bottomRight)
Steps to reproduce (code snippet or screenshot)
<Content style={{flex: 1}}>
  <Fab position="bottomRight">
    <Icon name="add"/>
  </Fab>
</View>

(note: adding or removing flex=1 has no effect)
I think I'm using this wrong...
Please add a Fab demo to KitchenSink that uses Fab with Content and List (which is a typical use case, rather than an empty View like current examples)
Screenshot of emulator/device

Is the bug present in both ios and android or in any one of them?
Tested in Android 7.0 only.
Any other additional info which would help us debug the issue quicker.
Please add a Fab demo to KitchenSink that uses Fab with Content and List (which is a typical use case, rather than an empty View like current examples)

"Workaround": this suggestion works: http://discuss.nativebase.io/t/how-to-use-a-fab-in-page-with-a-list/237/2
If this is the official recommendation, I suggest putting it in the KitchenSink/docs as it's a very common use case.

@ceefour Proper use case says, use FAB inside Container
I will add this to docs though

@SupriyaKalghatgi , thanks, current docs / examples use Fab inside View

@SupriyaKalghatgi following this issue, I’d like to present my FAB over a List – make it always visible on the right-bottom with a fixed position, floating above the list.
The thing is that I was only manage to present it on the end of the list; i.e., if the list is longer then a screen height, then it won’t be visible until the user scrolls to the end.
Any idea how to work around this issue?


Enhancement: Initial improvements to Guessing The Correct Logo game

PR Description 📜
I have resolved the issue #3821.Kindly review it, I have enhanced the UI and also have added the replay button in the game.

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images .
[x] I have added README.md in my folder .
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @Changingthegame ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Hello @kunjgit , honestly speaking I tried for this single PR five times, it was again and again closing automatically .So, I had to again clone the repository and made subtle changes in my folder and finally I did it.
I hope it will be approved by you.
Thanks.

Thank you  @Changingthegame , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Duplicate key values error is not thrown as exception and is getting ignored

I'm trying to capture 'Duplicate key values error ' message if there is any insert statement that is violating the primary key constraint. In the following code I created a 'demo' table with 'demo_id' as the primary_key and tried to insert the same row twice.
Example:
`connection = v.connect()
cursor = connection.cursor()
cursor.execute("""
DROP TABLE IF EXISTS demo;
CREATE TABLE demo (
demo_id integer primary key enabled,
code varchar(20),
quantity smallint,
amount money,
product_id int,
demo_date datetime);
""")
cursor.execute("""
INSERT INTO demo
SELECT 1,'RT0132',1,100,10023,now();
""")
cursor.execute("""
INSERT INTO demo
SELECT 1,'RT0132',1,100,10023,now();
""")
connection.commit()`
For the above code I would expect it to throw an Exception like "Message: b"Duplicate key values: 'demo_id=1' -- violates constraint", but it doesn't. Is there an existing solution to handle this case or can this issue be resolved by doing some quick workaround ?
I'm using Python 3.5.2  and vertica_python 0.8.2 versions.

You can do this
cursor.execute(query)
res = cursor.fetchone()
while res is not None:
    cursor.nextset()
    res = cursor.fetchone()

It will raise an exception for each error associated with a result set (tested only with user-generated error).

Hi, same problem w/ Airflow VerticaOperator
Some version info:
Python 3.10.10

Airflow version: 2.5.3

package_name                     | description                      | version
=================================+==================================+========
apache-airflow-providers-vertica | Vertica https://www.vertica.com/ | 3.0.0

import vertica_python as vp
print(vp.version_info)
(1, 3, 8)

Vertica Analytic Database v12.0.4-25

@sitingren yeah it is not your project, but it uses default methods.
I saw your suggestion in this thread earlier, however it looks like workaround.
Is it possible to make in future versions default indications for PK problem?

@sitingren Thank you for your explaining, now I get it and will try to check apache-airflow-providers-vertica for updates or connect developers to create issue for implementing your suggestion

Hi, same problem w/ Airflow VerticaOperator
Some version info:
Python 3.10.10

Airflow version: 2.5.3

package_name                     | description                      | version
=================================+==================================+========
apache-airflow-providers-vertica | Vertica https://www.vertica.com/ | 3.0.0

import vertica_python as vp
print(vp.version_info)
(1, 3, 8)

Vertica Analytic Database v12.0.4-25

For those who have the same problem with airflow:
This problem fixed in apache-airflow-providers-vertica 3.5.2: https://airflow.apache.org/docs/apache-airflow-providers-vertica/3.8.2/changelog.html#id14
https://github.com/apache/airflow/pull/34041
If you by any reason can not to upgrade apache-airflow-providers-vertica to higher version, my suggestion is to temporary, I repeat: temporary - replace your operator with small fix, here is my draft:
from typing import TYPE_CHECKING
from airflow.providers.vertica.hooks.vertica import VerticaHook
if TYPE_CHECKING:
    from airflow.utils.context import Context

from airflow.providers.common.sql.hooks.sql import fetch_all_handler
from airflow.providers.vertica.operators.vertica import VerticaOperator

class VerticaOperatorTMP(VerticaOperator):
    def execute(self, context: 'Context') -> None:
        self.log.info('Executing: %s', self.sql)
        hook = VerticaHook(vertica_conn_id=self.vertica_conn_id)
        hook.run(
            sql=self.sql,
            handler=fetch_all_handler,
        )

As @sitingren explained - the problem is in fetching response, you can see how my suggestion works by trying this:
-- create table
DROP TABLE IF EXISTS dev.vp_issues_255;
CREATE TABLE dev.vp_issues_255
(
    pk_1 int,
    ldm timestamp NOT NULL DEFAULT now(),
    CONSTRAINT pk PRIMARY KEY (pk_1) ENABLED
);

from airflow.providers.vertica.hooks.vertica import VerticaHook
from airflow.providers.common.sql.hooks.sql import fetch_all_handler

h = VerticaHook('conn_id')
sql = 'INSERT INTO dev.vp_issues_255 (pk_1) VALUES (1);'

for i in range(2):
    print(f'Attempt w/ silent error {i+1}')
    h.run(sql=sql)

h.run('TRUNCATE TABLE dev.vp_issues_255;')

for i in range(2):
    print(f'Attempt w/ error after first insert {i+1}')
    h.run(sql=sql, handler=fetch_all_handler)

I hope this will help.


USER STORY: Realtime playlist track construction

As a: User
I can: See a preview of my playlist tracks in real time, as I am entering the message
So that: I don't have to wait until the playlist is created in order to see the tracks.
Acceptance Criteria:

[ ] The service layer communicates with the Spotify API to find suitable tracks as the user is typing the message, and constructs a suitable track in order in real time, returning this for the UI to render.
[ ] The service layer utilises smart caching to achieve this without excessive API calls.

Service layer task


[chip-test]  Issues with ADC's chip_sw_adc_ctrl_sleep_debug_cable_wakeup

Test point name
[chip_sw_adc_ctrl_sleep_debug_cable_wakeup](https::// github.com/lowRISC/opentitan)
Host side component
SystemVerilog
OpenTitanTool infrastructure implemented
Unknown
Contact person
Jacob-Levy
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)

Assert fail: HwIdSelCheck_A

"../src/lowrisc_prim_subreg_0/rtl/prim_reg_cdc_arb.sv", 169: tb.dut.top_earlgrey.u_adc_ctrl_aon.u_reg.u_adc_chn_val_0_cdc.u_arb.gen_wr_req.HwIdSelCheck_A: started at<PHONE_NUMBER>0ps failed at<PHONE_NUMBER>0ps
Offending '$past(dst_update_i, 1)'
UVM_ERROR @ 18363.300000 us: (prim_reg_cdc_arb.sv:169) [ASSERT FAILED] HwIdSelCheck_A
"../src/lowrisc_prim_subreg_0/rtl/prim_reg_cdc_arb.sv", 169:
tb.dut.top_earlgrey.u_adc_ctrl_aon.u_reg.u_adc_chn_val_1_cdc.u_arb.gen_wr_req.HwIdSelCheck_A: started at<PHONE_NUMBER>0ps failed at<PHONE_NUMBER>0ps
Offending '$past(dst_update_i, 1)'
UVM_ERROR @ 18363.300000 us: (prim_reg_cdc_arb.sv:169) [ASSERT FAILED] HwIdSelCheck_A

Assert fail:  WakeUpChnSelIn (NTIL assert at chip level)
the channel select is being  set after ~15us although the spec defines “Wait 30 uS for the ADC to wake up” . (in this test adc_pd_ctl.pwrup_time was set to 2).

@tjaychen  We are using open source chip-level tests as a starting point by adapting them to the NTIL chip-level extended environment.
For the 1st issue we failed on NTIL first and when we run the test on OS we noticed it failed the same way.
We might be missing the open source update that address the issue on the OS and on the NTIL.
Can you direct us to the update?
@ariel9678 Can you please show the command that you run on the OS chip-level to replicate issue (1).
As for issue (2), The assert in question was added to the NTIL chip-level among other things. The ones that apply to
OS chip-level (not related to security) should be added to the OS chip-level and not be part of the extend.
@sha-ron Can you please add the relevant non-secure asserts to the OS chip-level.

wait really? it failed in OS also? let me check that then. Maybe there's some corner case with the cdc reg handling that's not done.
for the assert, it would just be helpful to have something that isn't proprietary in the open that checks for interface expectations. That way we can help catch these things in the open and not let them fall onto you guys to debug only.

@tjaychen We are using 2week old opentitan version. When did you incorporated the update?
In any case, I asked @sha-ron to move to the latest opentitan early next week.

@tjaychen I will check the local version for the prim_reg_cdc_arb.sv version.
Will also run the test on the latest OS version tomorrow.

@tjaychen  The test was run by @ariel9678  on the latest version and PASSED.
So, we left with issue (2) that will be handled next week after we review all the check that was added in NTIL and are valid for the OS too.
We will also fix the configuration to avoid the ASSEET.

@Jacob-Levy assigning to you for now. Once you guys update, let me know and I can have a look.

Issue (1) resolved by PR #15047.
Issue (2) requiers ast_spec_checks.sv  that includes all the assertion that check the AST Spec restrictions like the "30us wait after power-up"..

Closing this issue based on the latests results:

Tests
latest
2022.09.28
2022.09.27
2022.09.26/1
2022.09.26/2
2022.09.24
2022.09.23
2022.09.22/1
2022.09.22/2
...
2022.09.20/2
2022.09.18
2022.09.17
2022.09.16
2022.09.15/1
2022.09.15/2
2022.09.13
2022.09.12
2022.09.11
Suite

chip_sw_adc_ctrl_sleep_debug_cable_wakeup
100.00
100.00
100.00
100.00
66.67
100.00
100.00
100.00
100.00
...
100.00
100.00
100.00
100.00
100.00
100.00
100.00
100.00
100.00
chip_sw_adc_ctrl_sleep_debug_cable_wakeup

Should we open an issue for the second item mentioned by @Jacob-Levy previously?

Should we open an issue for the second item mentioned by @Jacob-Levy previously?

ah yes good point. @Jacob-Levy did mention there will be discussions whether it can be added to open source, so keeping track of it would be good.


bug: does not properly validate assertion of status code

Hello! When using probe to validate status codes, it will pass regardless of what the status code is set to. An example of this is running the following test case:
name: Writing Test
stages:
  - name: first stage
    request:
      url: "https://google.com"
      method: GET
    assert:
      status: 200

This test case should fail with a status code of 301 but instead you will receive a pass.

Hello, @ethanholz  thanks so much for noticing and reporting this.
This is happing because of a redirect from google.
Working on a fix.


Popover blurred on chrome

components: Popover
reactstrap version #6.5.0
react version #16.6.3
bootstrap version #4.0.0-alpha.6

What is happening?
Popover content looks blurred on chrome.
This didn't happen before, only since a couple of weeks.
It doesn't look blurred on IE
What should be happening?
Shouldn't look blurred
Steps to reproduce issue
run the code below
Error message in console
N/A
Code
I created a new app with
npx create-react-app my-app
npm i reactstrap

then App.jsx:
import React from 'react';
import { Button, Popover, PopoverHeader, PopoverBody } from 'reactstrap';

export default class Example extends React.Component {
  constructor(props) {
    super(props);

    this.toggle = this.toggle.bind(this);
    this.state = {
      popoverOpen: false
    };
  }

  toggle() {
    this.setState({
      popoverOpen: !this.state.popoverOpen
    });
  }

  render() {
    return (
      <div>
        <Button id="Popover1" onClick={this.toggle}>
          Launch Popover
        </Button>
        <Popover placement="bottom" isOpen={this.state.popoverOpen} target="Popover1" toggle={this.toggle}>
          <PopoverHeader>Popover Title</PopoverHeader>
          <PopoverBody>Sed posuere consectetur est at lobortis. Aenean eu leo quam. Pellentesque ornare sem lacinia quam venenatis vestibulum.</PopoverBody>
        </Popover>
      </div>
    );
  }
}

The version of bootstrap you are using is not compatible with the version reactstrap you are using.
I am on Chrome and am not noticing a blur: https://stackblitz.com/edit/reactstrap-v6-m9xqj7?file=Example.js

I guess you're right, your example isn't blurred, I haven't managed to resolve the problem but I guess that's not your problem :) thanks!

This is still an issue, even with the latest<EMAIL_ADDRESS>and<EMAIL_ADDRESS>but only when you're zoomed in or out, or with High DPI enabled.
You can see the issue with @TheSharpieOne 's example or this fork https://reactstrap-v6-gj7hm6.stackblitz.io with the latest versions.

I see a slight blur when zoomed in or out, but I am also noticing the same blur on bootstrap's docs which suggests this is an issue with the styles within bootstrap. I would recommend opening an issue with bootstrap (although, this may even be a browser related issue).

We have encountered this exact same issue and after debugging the css, I've determined that the cause is in Popper.js. It adds an inline-style with a transform: translateZ() which is causing the blurriness. Not sure why it needs the translateZ and not a top/left combo, but replacing it with top/left fixes it...


Made insecure channel/stub explicit, in all layers

This is an API breakage. A few constructors that previously took the credentials as an optional keyword argument now take it as a mandatory positional argument.

Changes look great. Thanks much for doing this in record-time.
It looks like you forgot to patch the src/ruby/bin/interop/interop_client.rb. All the ruby interop tests are failing. I'll merge after you fix that.

OK, I fixed that, and now the only interop failure is C++ -> Java (which was already happening)


Prevent publishing outside of confluence_publish_root

Is there a way to prevent anything from being published outside of confluence_publish_root?
Today, this appears to happen for documents that aren't in any toctree.

This is most likely a bug. From a quick inspection, it appears the default/fallback parent page for documents does not consider the case when confluence_publish_root is configured. This may be corrected with a change to this line:
https://github.com/sphinx-contrib/confluencebuilder/blob/703ee5444f84ef08f088f1af689543f7528e91be/sphinxcontrib/confluencebuilder/publisher.py#L244
To be something like:
base_page_id = self.config.confluence_publish_root

Changes (#740) have been made to ensure orphan documents will respect the confluence_publish_root configuration. This change has been added into the main branch and should be made available next stable release. If users wish to use this capability before a release is made, the development version of this extension can be installed.

v2.0 is now available on PyPI -- marking as closed.


Calling only super() in a derived class constructor after some comment produce wrong output.

TypeScript Version:  2.1.6
writing a costructor in a derived class with comments before calling super() generate an unexpected behaviour in javascript,
the compiler puts the "return" statement before comments, this produce at runtime a wrong  behaviour because the super method will never be executed.
Code
class A {

}
class B extends A {
	constructor() {
		// comment
		super();
	}
}

Expected behavior:
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var A = (function () {
    function A() {
    }
    return A;
}());
var B = (function (_super) {
    __extends(B, _super);
    function B() {
        // comment
        return _super.call(this) || this;
    }
    return B;
}(A));

Actual behavior:
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var A = (function () {
    function A() {
    }
    return A;
}());
var B = (function (_super) {
    __extends(B, _super);
    function B() {
        return
        // comment
        _super.call(this) || this;
    }
    return B;
}(A));

duplicated

I can't repro this on the 2.1.6 branch or in master. Can you verify your version (tsc -v) ?

what is 2.1.6? that version does not exist any where.

looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/12764

sorry, the version was 2.1.4


Default egress/ingress limits should be updated

[Enter feedback here]
I believe the ingress/egress for standard V2 accounts are now 60/120 Gbps respectively. Should we update the document to reflect this as well?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c9ef03f-cf87-a333-623b-afbd39fd75a2
Version Independent ID: 7ab8460b-b303-c829-4c45-462be21b38b2
Content: Scalability and performance targets for standard storage accounts - Azure Storage
Content Source: articles/storage/common/scalability-targets-standard-account.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@yuyichung Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.We will update you accordingly.

@tamram Can you please check and add your comments on this doc update request as applicable

@yuyichung - Thanks for your feedback! This was updated in the docs a while ago; now closing the open issue.
#please-close


when upgrading k8s 1.7 to 1.8, kubelets fail to start if swap is enabled on the host

After upgrading to k8s 1.8 in my rancher 1.6.11-rc build, kubelets failed to start citing running with swap is not supported. We should either leverage that flag by default or release note the change in behavior.
related ticket:
https://github.com/kubernetes-incubator/kubespray/issues/1787

Tested by upgrading from v1.6.10 to v1.6.11-rc9 with k8s 1.8.2 and swap enabled hosts. Upgrade completed successfully and kubelet started correctly with no problems. When the new option "fail on swap" is set to true, kubelet failed to start.


Improve printing (flags + impl.)

We should add PrintFlags and use them to accordingly implement the printing as kubectl commands do.

The goal of this would be to have the option to do things like:
kubectl trace get -o json <trace-id>

OR
kubectl trace get -o yml <trace-id>

OR
kubectl trace get -o table <trace-id>

Exactly. :)
L.
On Thu, Nov 29, 2018 at 12:03 AM Lorenzo Fontana<EMAIL_ADDRESS>wrote:

The goal of this would be to have the option to do things like:
kubectl trace get -o json
OR
kubectl trace get -o yml
OR
kubectl trace get -o table
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/fntlnz/kubectl-trace/issues/6#issuecomment-442639368,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHU8zXgAGxqbU-Q2zP3PL-5j7iRAvjHks5uzxZdgaJpZM4Yx7a2
.


Hang in Parsing response

Don't know why but it hangs on first Directory response and this fix makes it work:
 src/Oocx.ACME/Client/AcmeClient.cs | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

 diff --git a/src/Oocx.ACME/Client/AcmeClient.cs b/src/Oocx.ACME/Client/AcmeClient.cs
 index 76fb7c9..832909e 100644
--- a/src/Oocx.ACME/Client/AcmeClient.cs
+++ b/src/Oocx.ACME/Client/AcmeClient.cs
@@ -213,7 +213,8 @@ namespace Oocx.ACME.Client
                 return certificateResponse as TResult;
             }

-            var responseContent = await response.Content.ReadAsAsync<TResult>();
+            var responseJson = await response.Content.ReadAsStringAsync();
+            var responseContent = JsonConvert.DeserializeObject<TResult>(responseJson);

             GetHeaderValues(response, responseContent);

Hi, will you accept pull request, because this is only thing which currently blocks me to publish Nowin middleware.

I'd like to reproduce the error first before I fix anything that I don't understand. What exactly are you doing to cause this call to hang? How are you calling this code? Which runtime are you using?

I added ConfigureAwait(false) to async calls in AcmeClient. Depending on how you use the client, deadlocks may occur without ConfigureAwait(false). However, now calls to AcmeClient might return on a different thread than the one used to call its methods. Please try 0.0.0-beta-75 to see if this fixes your problem.

Yes, that's was problem. I can confirm 0.0.0-beta-75 works without problem.


Infrastructure as code

Right now, the configuration steps (setting up the SES email address, validating, and attaching the S3 hook to the SES incoming message action) are all manual. They're pretty well-documented (ha! not by me; check out the AWS docs in the README) but I'd love for this all to happen during deploy.
Most likely this looks like a provisioning step (some python script) which you run beforehand (which also creates a config.py for you), followed by a regular zappa deploy.

[ ] init
[ ] create-bucket
[ ] verify-domain
[x] verify-sender
[ ] validate-ses-account
[ ] create-s3-event
[ ] connect-s3-event

There are two options:

cloudformation (big json file)
boto python for everything


Fix git push error for protected CLA branch

The pull request is created from master636855070291101859 to master to fix git push error for protected CLA branch

@opbld17 : Thanks for your contribution! The author, @, has been notified to review your proposed change.


[Feature]: Update documentation on mocking named exported simple functions

🚀 Feature Proposal
I would expand either Manual mocks or Mock functions pages with writing one of the most used mock case:
// my-module.js

export function workerFunction(param1, param2) { /* ... */ }

// my-other-module.spec.js
// write what is the best practice according to the designers of the library
import { workerFunction } from './my-module';

jest.mock('./my-module.js'); // ?? - it won't work

Motivation
It is 2022, a lot of people favor named exports over default exports (for reasons of tree-shakability, better refactoring support by coding tools, etc.). I failed many times finding the right way to mock that simple case. There is stackoverflow, obviously, however the answers are from different years and honestly they are contradicting each other many times. And then I waste a lot of time looking through many different answers.
Just for the sake of experiment, search your documentation for "named exports" and you will only find examples for class-es which is also a very dated thing in 2022.
Thanks for reading this! I suppose for the right dev, this would be a 10 minutes adventure saving many of us hours of searching in different Q&A sites and finding examples that don't work with TypeScript.
Example
No response
Pitch
N/A: This is just documentation it's already there.

PR welcome!

@SimenB OK, but what is the team's intended way to do it so? There are quite hacky ways to do it, and honestly I am more curious about how the original developers thought about this problem, then using some random cooked up solution I can or stackoverflow folks can come up with.


CLTools Wizard: Reorder Input / Output Ports

Platform: Ubuntu 14.04 64-bit
VT Version: v<IP_ADDRESS>a01936a5640
Steps to recreate:
Create multiple Input Ports (Input1, Input2, Input3) and one Output Port (Output1).
Change Output1 to String, make visible, and generate a string for the description field.
Highlight Output1 (Bring into focus), and click the "up arrow" to move Output1 up the stack.
Results:
After one click, Output1 is moved up one spot in the stack, as expected, leaving Input3 on the bottom. However, the focus stays on Input3, which is now set to visible, type set to string, with it's description field overwritten by the contents from the description field of Output1.
Clicking the up arrow again, moves Input3 (which continues to retain the focus).

Thanks for the report!
There is indeed a problem, only happens for the "options" (so: prefix, flag, and description).
Fixed on v2.1 with bec1f386:
--- a/vistrails/packages/CLTools/wizard.py
+++ b/vistrails/packages/CLTools/wizard.py
@@ -1013,8 +1013,8 @@ class QArgWidget(QtGui.QWidget):
     def toList(self):
         self.getValues()
         if self.argtype not in self.stdTypes:
-            return [self.argtype, self.name, self.klass, self.options]
+            return [self.argtype, self.name, self.klass, dict(self.options)]
         else:
-            return [self.name, self.klass, self.options]
+            return [self.name, self.klass, dict(self.options)]

     def fromList(self, arg):


Webhook proposal

Description of the change:
Markdown proposal for including webhook support from controller runtime into the operator-sdk
Motivation for the change:
Implementation in progress, want to get feedback on the design/proposal
ref: #1218 #1217

/cc many customers look forward to this feature. :)

Here is an example of the planned implementation on the alpha version of controller runtime (out of date, currently being re-implemented with new/updated design).
Additionally here are reference resources being used:
https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/builder/webhook.go#L50:30

I'm still reading up on the process for proposed changes to the SDK, but is there a ballpark as to when this feature would be available? I've looked through the planned implementation and it looks like controller-runtime is getting closer to its v0.2.0 release. Kubebuilder supports scaffolding webhook implementations as well as generating the corresponding Kubernetes manifests via controller-gen, but mixing Kubebuilder with the Operator SDK is a bit wonky

Any updates on this, @theishshah?

@theishshah Given that we plan to integrate Kubebuilder and Operator SDK, I think this proposal is obsolete, as we'll inherit Kubebuilder's support for webhooks. If you agree, let's close this.

For what it's worth, I used Kubebuilder to scaffold the Go implementations for the webhooks in my Operator SDK project and controller-gen to autogenerate the Kubernetes manifests. It's working quite nicely now that v0.11.0 is using v0.2.0+ of controller-runtime. All of that being said, I think integrating the two frameworks would be a huge plus

@joelanford would you say the recommended practice at this point is to upgrade to v0.11.0 and do what @robbie-demuth said? Or should I follow the existing documentation surrounding webhooks at this point?


could this work with WebReflection/import.js ?

hi
great example thanks!
As nomodule fallback this is building for system. But I wonder if we could use
https://github.com/WebReflection/import.js instead of systemjs?
and build iife or umd as nomodule fallback, but in my test iife or umd does currently not support experimentalCodeSplitting

That project may well work with the direct es module output, but it would need to be tested and I'm not sure what the performance implications might be.
SystemJS is designed as a fallback for older browsers as a module loader is required to be able to dynamically load chunks. There's no way to make that work through iife, but an AMD loader can definitely be used with the AMD output so SystemJS is by no means the only option.

@guybedford makes sense thanks


[embeddingapi]Auto embeddingapi build cases

Impacted tests(approved): new 1, update 6, delete 6
Unit test platform: Crosswalk Project for Android 14.43.343.20
Unit test result summary: pass 7, fail 0, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4698

@jennycao I thought thus can directly use the built apk to install, launch, stop, uninstall. These apks are built in different ways, so need to install, launch, stop, uninstall to check if the apk is good. so install and so on is a check way.


Support for denying crates with executables or specific file extensions

Some crates like prost-derive include embedded executables that they run in build.rs,  this works on the main dev platforms but something we would like to have pure Rust versions of and deny.
@luciofranco also mentioned that it could be useful to be able to deny crates with specific file extensions in it, which could be part of the same feature.
This would require some scanning and wouldn't be fool proof because a crate could still contain say a zipped exe that it unpacks or simply download an exe and run it  in build.rs. But can be good to investigate still

prost-build has moved away from included prebuilt executable in the crate, to use cmake instead (which for us is almost worse), so we built https://github.com/EmbarkStudios/proto-gen to manually prebuild and checkin the Rust protobuf bindings for our crates, which has been working well.
though now very recently the very popular serde-derive started having a checked in executable in the crate:

https://github.com/serde-rs/serde/issues/2538

so this issue is still relevant

prost-build has moved away from included prebuilt executable in the crate, to use cmake instead (which for us is almost worse)

They did this in prost-build 0.10 but as far as I know prost-build 0.11 requires protoc installed prior (I know this because I had to fix my docker images to support this, both with the cmake build in 0.10, and with the no cmake version in 0.11)
prost no longer bundles anything
Removal PR:
https://github.com/tokio-rs/prost/pull/657/files#diff-b55be6bbf5c9750593e84b0c298cb44d32a5221d3965ec540aa2391cb7f86e9aL76-L87

prost-build has moved away from included prebuilt executable in the crate, to use cmake instead (which for us is almost worse)

They did this in prost-build 0.10 but as far as I know prost-build 0.11 requires protoc installed prior (I know this because I had to fix my docker images to support this, both with the cmake build in 0.10, and with the no cmake version in 0.11)
prost no longer bundles anything
Removal PR: https://github.com/tokio-rs/prost/pull/657/files#diff-b55be6bbf5c9750593e84b0c298cb44d32a5221d3965ec540aa2391cb7f86e9aL76-L87

Yeah, proto-gen doesn't solve the bundling issue, it's just a smooth(-ish) way of generating the Rust-code and checking that it's up to date with the proto-files, one still needs to wrangle protoc, but only if you want to update protos. That's nice because if you have someone who wants to edit unrelated stuff they generally don't have to bother with protoc. It's does create a bit of a mess since generated files are checked in, but on the positive side it removes the need for a build.rs and tonic build as a direct dependency. It also plays nicer with editors which has been a plus!


Pagination

Currently the homepage displays all the content.
This could be improved by adding a pagination feature
https://www.gatsbyjs.org/docs/adding-pagination/

Worked on it in branch pagination. Testing now before deployment

Pagination doesn't deploy on Netlify.
The build times out :( Contacted netlify for more infos
12:01:19 PM: Build ready to start 12:01:26 PM: build-image version: d5d16c91ca3e1e5a990086daa8a1d5bd8564d12a 12:01:26 PM: build-image tag: v3.2.2 12:01:26 PM: buildbot version: 93c10be3dc42bccef2b5600a7e10ec1d4a1c7051 12:01:27 PM: Fetching cached dependencies 12:01:27 PM: Starting to download cache of 255.1KB 12:01:27 PM: Finished downloading cache in 77.287655ms 12:01:27 PM: Starting to extract cache 12:01:27 PM: Failed to fetch cache, continuing with build 12:01:27 PM: Starting to prepare the repo for build 12:01:27 PM: No cached dependencies found. Cloning fresh repo 12:01:27 PM: git clone https://github.com/jpvalery/pricingpages 12:01:29 PM: Preparing Git Reference refs/heads/pagination 12:01:30 PM: Starting build script 12:01:30 PM: Installing dependencies 12:01:32 PM: v10.15.3 is already installed. 12:01:32 PM: Now using node v10.15.3 (npm v6.4.1) 12:01:33 PM: Attempting ruby version 2.6.2, read from environment 12:01:34 PM: Using ruby version 2.6.2 12:01:34 PM: Using PHP version 5.6 12:01:34 PM: Started restoring cached node modules 12:01:34 PM: Finished restoring cached node modules 12:01:35 PM: Installing NPM modules using NPM version 6.4.1 12:02:08 PM: ><EMAIL_ADDRESS>install /opt/build/repo/node_modules/sharp 12:02:08 PM: > (node install/libvips && node install/dll-copy && prebuild-install) || (node-gyp rebuild && node install/dll-copy) 12:02:08 PM: info 12:02:08 PM: sharp 12:02:08 PM:  Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.7.0/libvips-8.7.0-linux-x64.tar.gz 12:02:11 PM: ><EMAIL_ADDRESS>postinstall /opt/build/repo/node_modules/axe-core 12:02:11 PM: > node build/utils/postinstall.js 12:02:11 PM: ><EMAIL_ADDRESS>postinstall /opt/build/repo/node_modules/gatsby-telemetry 12:02:11 PM: > node src/postinstall.js 12:02:11 PM: ><EMAIL_ADDRESS>postinstall /opt/build/repo/node_modules/cwebp-bin 12:02:11 PM: > node lib/install.js 12:02:12 PM:   ✔ cwebp pre-build test passed successfully 12:02:12 PM: ><EMAIL_ADDRESS>postinstall /opt/build/repo/node_modules/mozjpeg 12:02:12 PM: > node lib/install.js 12:02:13 PM:   ✔ mozjpeg pre-build test passed successfully 12:02:13 PM: ><EMAIL_ADDRESS>postinstall /opt/build/repo/node_modules/pngquant-bin 12:02:13 PM: > node lib/install.js 12:02:13 PM:   ✔ pngquant pre-build test passed successfully 12:02:16 PM: npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents): 12:02:16 PM: npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) 12:02:16 PM: added 1978 packages from 1100 contributors and audited 27452 packages in 40.296s 12:02:16 PM: found 0 vulnerabilities 12:02:16 PM: NPM modules installed 12:02:16 PM: Started restoring cached go cache 12:02:16 PM: Finished restoring cached go cache 12:02:16 PM: unset GOOS; 12:02:16 PM: unset GOARCH; 12:02:16 PM: export GOROOT='/opt/buildhome/.gimme/versions/go1.12.linux.amd64'; 12:02:16 PM: export PATH="/opt/buildhome/.gimme/versions/go1.12.linux.amd64/bin:${PATH}"; 12:02:16 PM: go version >&2; 12:02:16 PM: export GIMME_ENV='/opt/buildhome/.gimme/env/go1.12.linux.amd64.env'; 12:02:16 PM: go version go1.12 linux/amd64 12:02:16 PM: Installing missing commands 12:02:16 PM: Verify run directory 12:02:16 PM: Executing user command: gatsby build 12:02:19 PM: success open and validate gatsby-configs — 0.015 s 12:02:20 PM: success load plugins — 1.059 s 12:02:20 PM: success onPreInit — 0.006 s 12:02:20 PM: success delete html and css files from previous builds — 0.006 s 12:02:20 PM: success initialize cache — 0.007 s 12:02:20 PM: success copy gatsby files — 0.024 s 12:02:20 PM: success onPreBootstrap — 0.012 s 12:02:20 PM: success source and transform nodes — 0.371 s 12:02:21 PM: success building schema — 0.311 s 12:02:21 PM: success createPages — 0.151 s 12:02:21 PM: warning Attempting to create page "/tags/", but page "/tags" already exists. This could lead to non-deterministic routing behavior 12:02:21 PM: success createPagesStatefully — 0.043 s 12:02:21 PM: success onPreExtractQueries — 0.005 s 12:02:21 PM: success update schema — 0.071 s 12:02:21 PM: success extract queries from components — 0.178 s 12:02:21 PM: success run static queries — 0.011 s — 1/1 98.24 queries/second 12:05:55 PM: success run page queries — 214.367 s — 75/75 0.35 queries/second 12:05:56 PM: success write out page data — 0.341 s 12:05:56 PM: success write out redirect data — 0.005 s 12:16:43 PM: done generating icons for manifest 12:16:43 PM: success onPostBootstrap — 0.197 s 12:16:43 PM: info bootstrap finished - 867.336 s 12:16:58 PM: success Building production JavaScript and CSS bundles — 14.589 s 12:17:01 PM: success Building static HTML for pages — 2.746 s — 75/75 88.30 pages/second 12:17:01 PM: Generated public/sw.js, which will precache 13 files, totaling 314468 bytes. 12:17:01 PM: info Done building in 884.872 sec 12:17:02 PM: Execution timed out after 15m0s 12:17:02 PM: failed during stage 'building site': Command did not finish within the time limit 12:17:02 PM: Error running command: Command did not finish within the time limit 12:17:02 PM: Failing build: Failed to build site 12:17:02 PM: Finished processing build request in 15m35.374544085s 12:17:02 PM: Shutting down logging, 0 messages pending

Still haven't heard back from Netlify - will update this issue as soon as I do.


Something went wrong in RepeatedDenseBlock.update_curvature_matrix_estimate

I think current version of update_curvature_matrix_estimate have something problem for ignoring the input name pmap_axis_name, and thus I think the proper function should be given as follow:
  def update_curvature_matrix_estimate(
      self,
      state: kfac_jax.TwoKroneckerFactored.State,
      estimation_data: Mapping[str, Sequence[Array]],
      ema_old: Numeric,
      ema_new: Numeric,
      batch_size: int,
          pmap_axis_name: Optional[str],
          sync: Array | bool = True,
  ) -> kfac_jax.TwoKroneckerFactored.State:
    estimation_data = dict(**estimation_data)
    x, = estimation_data["inputs"]
    dy, = estimation_data["outputs_tangent"]
    assert x.shape[0] == batch_size
    estimation_data["inputs"] = (x.reshape([-1, x.shape[-1]]),)
    estimation_data["outputs_tangent"] = (dy.reshape([-1, dy.shape[-1]]),)
    batch_size = x.size // x.shape[-1]
    return super().update_curvature_matrix_estimate(
        state=state,
        estimation_data=estimation_data,
        ema_old=ema_old,
        ema_new=ema_new,
        batch_size=batch_size,
        pmap_axis_name=pmap_axis_name,
    )

where I added pmap_axis_name.

We track the HEAD of kfac-jax. The pmap_axis_name argument  TwoKroneckerFactored.update_curvature_matrix_estimate was removed a few months ago (https://github.com/deepmind/kfac-jax/commit/4bf9bec1618035cb58586ea1b00d75a6172da45c).
If you are using an older version of kfac-jax, you can either update or rollback the commit which updated the API ferminet uses (https://github.com/deepmind/ferminet/commit/e29145a6a18ffa74f4d012b718526bada3ffcd18 - looks like the code in your comment)

Thank you for your answer. I'm sorry that I installed the kfac-jax via pypi, which is updated in May 17, and this 4bf9bec is commit on Jun 26. Thank you again for solving my question.


Fixing license headers and merge conflict in License file

Pull Request Test Coverage Report for Build 54

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.371%

Totals

Change from base Build 51:
0.0%

Covered Lines:
1935

Relevant Lines:
2207

💛  - Coveralls


tailwindcss-purgecss example is not more up to date

Version
v2.11.0
Reproduction link
https://github.com/nuxt/nuxt.js/blob/dev/examples/tailwindcss-purgecss/package.json
Steps to reproduce

Clone https://github.com/nuxt/nuxt.js/blob/dev/examples/tailwindcss-purgecss/
Run yarn generate

What is expected ?
No warnings
What is actually happening?
WARN  Please use build.postcss in your nuxt.config.js instead of an external config file. Support for such files will be removed in Nuxt 3 as they remove all defaults set by Nuxt and can cause severe problems with features like alias resolving inside your CSS.
Additional comments?
Furthermore the interactive tailwind installation provides broken purgecss mentioned in https://github.com/nuxt-community/tailwindcss-module/issues/55

This bug report is available on Nuxt community (#c10369)

Also tailwindcss example is out of date as it is using postcss external config.

Also documentation https://nuxtjs.org/faq/postcss-plugins/ mentions tailwind only in Legacy Method and doesn't provide any example how to instantiate require('tailwindcss')(tailwindJS) with Recommended Method

@Atinux

Also documentation https://nuxtjs.org/faq/postcss-plugins/ mentions tailwind only in Legacy Method and doesn't provide any example how to instantiate require('tailwindcss')(tailwindJS) with Recommended Method

this is not fixed


Issue 43: Add Logout feature

Type of Change

[X] Feat: Implement Logout Functionality

Description
Add logout function in NavbarItems component by using logout API from backend then clear user information in React context => Navigating user back to Login page.
Linked Issue
#43
Screenshots
Before logout:

After logout, the state is clear (not by F5):

Tests

Run Cypress tests.
Manual testing by login => logout then checking user state in context.

Thanks. Just added 1 commit to fix the convention. Sorry about this since I was used to Erlang convention...
Btw, I am also not familiar with Github way of working, so do I need to push another commit to fix reviewer's comment? or I could use git commit --amend and then pushing again?

Thanks. Just added 1 commit to fix the convention. Sorry about this since I was used to Erlang convention...
Btw, I am also not familiar with Github way of working, so do I need to push another commit to fix reviewer's comment? or I could use git commit --amend and then pushing again?

No worries.
I would prefer that you address review comments by pushing new commits. This would allow us to view only the newly changed code. Therefore, for each set of review comments, there should be a new push. When we merge the PR into the master branch, we can opt for "Squash and Merge" instead of a normal merge. This will combine all the commits into a single one, which helps maintain a clean commit history.


Character models

Hi this is more of a question, is it possible to increase the resolution of character models? I feel like they are being rendered at 720-1080p despite you running the game at 4k or above so it looks quite jarring.

Not possible, there are indeed only 720p and 1080p versions for each asset in the game. Feel free to join the Supergiant Games modding Discord for general modding questions => https://discord.gg/KuMbyrN


Fix typo ArmTemplateParameters_master.json

@jpbelli : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jonburchel
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jonburchel

This change has been made now.  Thanks for contributing to the docs @Jak-MS!  #please-close


Slot values in stories expect only strings

Rasa Core version: 0.8.6
Python version:  3.6
Operating system (windows, osx, ...): Linux (Fedora)
Issue:  Slot values in stories seem only to expect strings. For instance, when I am setting slots to None in actions (which is how they initialize, no?) and null in stories, I am bombarded by warnings that I'm setting slots to value types that are never set during training, since it is expecting "None". This seems to indicate that my None value in actions is being stringified.
Should I start using "None" in my stories? Could sticking to null adversely affect my bot's flow expectations? I've also noticed this behavior with False.

Can you add an example? But no as far as I understand that should not be the case, you should be able to set any type allowed in a json.

A story snippet:

The above story snipped shows the action being performed based on the intent, and the slots being filled to some values throughout. The part of particular interest is at the end, where many slots are set to null.
My action snippet:

The above action snippet is my approach for clearing slots that were not filled after the last entity extraction, since this is appropriate my my specific use. You can see there that the slots are being set to None if they were not extracted from the most recent user message.
My command-line errors:

The above errors seem to indicate that my None values given in my custom action are being stringified. It does seem to be adversely affecting my story flow, since in my case {"results": null} should trigger an expanded search; however, since it is being turned to a string, the bot things that there are results and attempts to display them.

Alright, so I took a look at the print statement, the "" are added to the None there, it is actually set to None, I'll change that output. Can you please add the content of the policy_metadata.json file from a trained model here? That would help me find the issue.

Just trained using stories with "None" instead of null, and that definitely didn't work--which makes sense, because it's just checking whether there's a string or not. I'll switch it back in my stories and then train again. I'll add the policy metadata content after that.

So far I think you can ignore the warning. I also think the warning should not be emitted with the latest master version anymore. I am very happy to help :)

I'm fairly certain it was a lack of training. I'm going to go ahead and close this. Thanks!


Component not updating in React Native

I've followed the tutorial so far and I have to admit that, albeit the Flux/Redux architecture has a steep learning curve, I managed to successfully make almost everything work very quickly and understanding all the fundamental things.
However, the component I'm rendering is not updating when an action is dispatched.
I want to add elements to a list. Here's the code I made so far:

Actions.js:

export const ADD_ELEMENT = 'ADD_ELEMENT'
export function addElement (element) {
  return { type: ADD_ELEMENT, element }
}

Reducers.js:

import { ADD_ELEMENT } from 'Actions'
import { combineReducers } from 'redux'

const initialState = {
  elements: [
    {id: 1, element: 'thing'},
    {id: 2, element: 'anotherThing'}
  ],
}

function elements (state = initialState.elements, action) {
  switch (action.type) {
    case ADD_ELEMENT:
      return [...state, action.element]
    default:
      return state
  }
}

const boatApp = combineReducers({
  elements
})

export default boatApp

index.ios.js:

// ...Imports
const logger = createLogger()
const createStoreWithMiddleware = applyMiddleware(thunk, promise, logger)(createStore)
const store = createStoreWithMiddleware(boatApp)

class boat extends Component {
  render () {
    return (
      <Provider store={store}>
        {() => <TabBar />}
      </Provider>
    )
  }
}

Then, inside the <TabBar /> component I have a view with a React Native <ListView /> component that has to display the list of elements:
import React, { Component, View, Text, ListView, StyleSheet } from 'react-native'
import { connect } from 'react-redux/native'

@connect(state => ({ elements: state.elements }))
class ElementItemsList extends Component {
  constructor (props) {
    super(props)
    let dataSource = new ListView.DataSource({
      rowHasChanged: (r1, r2) => r1 !== r2
    })
    this.state = {
      elements: props.elements,
      dataSource: dataSource.cloneWithRows(props.elements)
    }
  }

  _renderRow (rowData) {
    return (<Text>{rowData.element}</Text>)
  }

  render () {
    return (
      <View style={{flex: 1}}>
        <ListView style={styles.container}
          contentInset={{top: 0}}
          automaticallyAdjustContentInsets={false}
          dataSource={this.state.dataSource}
          renderRow={(rowData) => this._renderRow(rowData)}
        />
        <Text style={{flex: 1}}>
          {this.state.elements}
        </Text>
      </View>
    )
  }
}

The thing is that I need to update this.state.dataSource in order to make <ListView /> update it's content. Any clue about how I can update the state when the elements are updated?
Update
Just FYI, there is also a <Text /> component I put after the ListView that doesn't need the dataSource update, it prints this.state.elements and it's not updating also.

And this is the output of the logger:

The only way to reflect the changes is to navigate to the previous component and navigate again to the list (forcing the state refresh).

I managed to update the current state but honestly I don't think it's the right way to do it:
componentDidUpdate () {
  if (this.state.elements.length !== this.props.elements.length) {
    this.setState({
      elements: this.props.elements,
      dataSource: this.state.dataSource.cloneWithRows(this.props.elements)
    })
  }
}

Alas, I don't know enough about what dataSource is to help you. The problem is not Redux-specific, and is described in Props in getInitialState is an anti-pattern. You'll get new props from Redux every time store updates, but you don't use them: you only use state which you initialize once.
Does something like this help?
componentWillReceiveProps (nextProps) {
  if (nextProps.elements !== this.props.elements) {
    this.setState({
      elements: nextProps.elements,
      dataSource: this.state.dataSource.cloneWithRows(nextProps.elements)
    })
  }
}

Note that unlike componentDidUpdate(), a setState() call inside componentWillReceiveProps() won't trigger another render, so it will be faster.
Still, it looks rather weird to me, but again, I don't know enough about React Native or dataSource.

(Small suggestion: elements is confusing naming because I thought you're referring to React elements, i.e. stuff you get from React.createElement. Better to rename it to items.)

Couldn't you just create a new DataSource instance in the render method? or do something like this:
@connect(state => ({ elements: state.elements }))
class ElementItemsList extends Component {
  constructor (props) {
    super(props)
    this.dataSource = new ListView.DataSource({
      rowHasChanged: (r1, r2) => r1 !== r2
    })
  }

  _renderRow (rowData) {
    return (<Text>{rowData.element}</Text>)
  }

  render () {
    const dataSource = this.dataSource.cloneWithRows(this.props.elements);

    return (
      <View style={{flex: 1}}>
        <ListView style={styles.container}
                  contentInset={{top: 0}}
                  automaticallyAdjustContentInsets={false}
                  dataSource={dataSource}
                  renderRow={(rowData) => this._renderRow(rowData)}
        />
        <Text style={{flex: 1}}>
          {this.state.elements}
        </Text>
      </View>
    )
  }
}

Or does that result in performance issues?

Thanks for the info @gaearon! componentWillReceiveProps() seems the way and it's working perfectly. I'm still a novice to the React world, so thanks for pointing the anti-pattern I was doing.
@Blystad that approach is working also, but I should run a profiler to know which is better in terms of performance. We could check how's the garbage collector dealing with the dataSource too. I think both approaches should perform in a very similar way, but for me the componentWillReceiveProps() is more elegant and keeps responsibility separated between the render and the state.

I think both approaches should perform in a very similar way, but for me the componentWillReceiveProps() is more elegant and keeps responsibility separated between the render and the state.

Generally you should strive to avoid state when possible, especially the state synced with props. In this case, I think @Blystad's approach is better, but indeed, you should profile first.

That's interesting @gaearon, do you have any docs or an article about how to deal with state, when to use it and/or best practices? Maybe I'm not using the state correctly but in the Movies app example of Facebook's React Native code, they're using state to feed the <ListView /> data source https://github.com/facebook/react-native/blob/master/Examples/Movies/SearchScreen.js#L66.

I was confused too in the beginning. If you use Redux, you don't really need the state anymore (only for things you don't want to store in the redux stores/state ).

I ended up doing something like this.
class TodoList extends Component {
  renderRow(todo) {
    return (
      <View><Text>{todo.text}</Text></View>
    );
  }

  render() {
    return (
      <ListView
        dataSource={this.props.dataSource}
        renderRow={(rowData) => this.renderRow(rowData)}
      />
    );
  }
}

TodoList.propTypes = {
  dataSource: PropTypes.object,
};

function mapStateToProps(state) {
  const dataSource = new ListView.DataSource({
    rowHasChanged: (r1, r2) => r1 !== r2,
  });

  return {
    dataSource: dataSource.cloneWithRows(state.todos),
  };
}

export default connect(mapStateToProps)(TodoList);

Hi @luqmaan your final  code (use dataSource in the mapStateToProps) still works for you?

I moved
  const dataSource = new ListView.DataSource({
    rowHasChanged: (r1, r2) => r1 !== r2,
  });

outside the function. Works fine for me. The problem I'm having is if I want to press on the row and make it active/checked, I have to go through the whole list in the reducer find the row and change the state on it, doesn't seem to be very efficient... Any opinion on how or where properly to set selected: true/false on the row?

Instead of setting an attribute against the row, maintain a "selected_row" key: {selected_row: row_id}

Thanks I'll try using index. Also realized that I can use object as data source but then my question is how is the sort order going to be preserved?

@nodkrot The sort order can be preserved in a separate array of identifiers, besides the entity objects dataset. Note that you'll have to keep it in sync with the dataset if the entities get deleted or added.

@sompylasar gotcha, thanks

@Blystad's method worked for me

@Blystad's method worked for me too!!

@Blystad's method worked for me too.

@sompylasar @luqmaan @alvaromb  This solution didn't work for me,i'm using react native's Navigator component to render my scenes, could this be the cause, although when JavaScript Set interval to console log the same prop data it displays the new state when changed, can't seem to tell whats wrong here.
This is my component:
`import React, {Component} from 'react';
import * as routes from '../configs/routes';
import Icon from 'react-native-vector-icons/FontAwesome';
import {connect} from 'react-redux';
import {showNavbar} from '../actions/UIActions';
var menuIcon = require('../assets/images/header/menu_icon.png');
var search = require('../assets/images/header/search.png');
import {
View,
Text,
Image,
TouchableOpacity,
StyleSheet
} from 'react-native';
class Header extends Component{
constructor(props){
	super(props);
	//
	this.state = {};
	// bind methods
	this.setOptions = this.setOptions.bind(this);
	this.navbar = this.navbar.bind(this);
}

setOptions(){
	// get component options
	var {options} = this.props;
	this.setState({label: options.label});
}

navbar(){
	this.props.showNavbar();
}

componentDidMount() {
	setInterval(() => {
		console.log(this.props.navbar);
	}, 5000)
}

componentWillReceiveProps(nextProps) {
	console.log(nextProps);
}

componentWillMount() {
	// set options
	this.setOptions();
}

render(){
	return(
		<View style={styles.conatiner}>
			<View style={styles.row}>
				<View style={styles.col1}>
					<TouchableOpacity style={styles.tochable}
						onPress={this.navbar}>
						<Text style={styles.tochableTextLeft}>
							<Image source={menuIcon} style={styles.tochableIcon} />
						</Text>
					</TouchableOpacity>
				</View>

				<View style={styles.col2}>
					<Text style={styles.label}>
						{this.state.label}
					</Text>
				</View>

				<View style={styles.col3}>
					<TouchableOpacity style={styles.tochable}>
						<Text style={styles.tochableTextRight}>
							<Image source={search} style={styles.tochableIcon} />
						</Text>
					</TouchableOpacity>
				</View>
			</View>
		</View>
	);
}

}
const styles = StyleSheet.create({
...
});
const mapStatToProps = (state) => {
return {
navbar: state.navbar
};
}
const mapDispatchToProps = (dispatch) => {
return {
showNavbar: () => dispatch(showNavbar())
};
};
export default connect(mapStatToProps, mapDispatchToProps)(Header);`
Someone please help!

I am facing a related issue.
I have a list of items with a selected state. But the selected state is never in sync with the actual state.
Using Redux-Logger I can see that the state is getting updated. I also see render being called and the right style being assigned in the logs. But the actual rendered state does not match what was logged.
Its a fairly simple setup, so I am sure I am doing something wrong. Just cant figure what.

I think the root of the problem is somewhere deeper, where dataSource is changed. One of the most recommended practices when dealing with state and redux is immutability. That translates to avoid doing something like:
dataSource.slice() | delete dataSource[customKey] | dataSource.push(...)

but instead do something like:
dataSource = Object.assign({}, dataSource, ...) //if it's a object
dataSource = [...dataSource, newElement] //creating new array

Otherwise, the render method doesn't detect changes

I always wonder about this and come away thinking that this seems soooooo inefficient... a single change to a value in a data-row results in 1) a new array instance 2) garbage collecting old one 3) triggering render method 4) re-running all of that render logic that you may not want to re-run every single time due to a tiny change in a data-cell 5) react doing it's best to figure out what's changed and 6) rendering only the changes or, failing that, re-rendering the entire component.
Is this really the way to go? I'm not react expert so I'm truly interested in determining if this is really the way to go or if there's some other pattern that should be used.

@AnthonyPaulO

I always wonder about this and come away thinking that this seems soooooo inefficient... a single change to a value in a data-row results in 1) a new array instance 2) garbage collecting old one 3) triggering render method 4) re-running all of that render logic that you may not want to re-run every single time due to a tiny change in a data-cell 5) react doing it's best to figure out what's changed and 6) rendering only the changes or, failing that, re-rendering the entire component.

Immutability is good from the large-scale maintainability perspective, but it is a trade-off for performance.

Is this really the way to go? I'm no react expert so I'm truly interested in determining if this is really the way to go or if there's some other pattern that should be used.

Newer features of React (Suspense, Async Rendering) are there to address that by distributing state across components and make their rendering dependent on the availability of the data only they require. Google it. https://twitter.com/acdlite/status/1025408731805184000

edit: ag-grid seems to have the user actually modify the value directly; I wonder if it's doing the whole immutability thing in the background and thus going through the entire process I already mentioned or if they're doing something more efficient. Check out nameValueSetter method in the example source-code on ag-grid.com/javascript-grid-value-setters; they are setting firstName and lastName properties on a data-row directly and returning a boolean true to indicate that the row has changed.

Angular does dirty-checking behind the scenes: it holds copies of objects and compares them with whatever is mutated in the objects the app has access to (so-called digest), detecting what has changed and re-rendering bound components (via so-called scope watchers).


📝 Fix broken link to article: Machine learning model serving in Python using FastAPI and Streamlit

Sorry, I moved the article (I am the author)

@tiangolo Would you be interested in a similar github action as https://github.com/gaurav-nelson/github-action-markdown-link-check but for yml?

Great, thanks for fixing it! :rocket: :tada:


chore: onboard renovate

:tada: This PR is included in version 0.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Hibernation Broken Again (beta 7)

Bug description:
Updated to 5.6.0-beta.7
"Enable Hibernation" became disabled for all my services
I reenabled it for the ones I want.
However, those services aren't hibernating after the amount of time I have set.
Also, if I enable "Keep services in hibernation on startup", it's hibernating ALL services, not just those with hibernation enabled. But even then, once opened for the first time, they don't re-hibernate after x amount of time
Steps to reproduce:

Update to 5.6.0-beta.7
Enable hibernation for services
They don't hibernate
Enable keep services in hibernation on startup
Restart
All services are hibernating, not just those that have it enabled.

Expected behavior
Functioned correctly in 5.6.0-beta.5
I notice the "Starting " dialog is changed too, I assume its some change that was implemented at the same time as the useragents change

Services, with hibernation enabled, hibernate after the time defined in the hibernation strategy in settings
With "Keep services in hibernation on startup" enabled, only those with hibernation enabled are hibernating on startup

Environment:

Operating System: Windows 10
Ferdi Version: 5.6.0-beta.7
Server: w/o Account

Is this related to #1486 ?

Could be, though that pull request is older than this update

Yes - that's becuase the PR was created much earlier, but the author and the other maintainers had some discussion that is not yet resolved.

This should be in the next nightly: 5.6.1-nightly.3


missing gitops tool "kind" should throw error

missing gitops tool "kind" should throw error

if we have fail repo config, it does not tell us why


[BUG] ImportError: _libcamera.cpython-39-arm-linux-gnueabihf.so: undefined symbol

After install Raspberry Pi OS updates. picamera2 now fails to initialize.
I also run
sudo apt install -y python3-libcamera python3-kms++
sudo apt install -y python3-pyqt5 python3-prctl libatlas-base-dev ffmpeg python3-pip
pip3 install numpy --upgrade
pip3 install picamera2

To Reproduce
import time

from picamera2 import Picamera2, Preview

picam2 = Picamera2()
picam2.start_preview(Preview.QTGL)

preview_config = picam2.create_preview_configuration()
picam2.configure(preview_config)

picam2.start()
time.sleep(5)

Console Output, Screenshots
$ python test.py
Traceback (most recent call last):
  File "/home/pi/test.py", line 3, in <module>
    from picamera2 import Picamera2, Preview
  File "/home/pi/.local/lib/python3.9/site-packages/picamera2/__init__.py", line 1, in <module>
    from .configuration import CameraConfiguration, StreamConfiguration
  File "/home/pi/.local/lib/python3.9/site-packages/picamera2/configuration.py", line 1, in <module>
    from .controls import Controls
  File "/home/pi/.local/lib/python3.9/site-packages/picamera2/controls.py", line 4, in <module>
    from libcamera import ControlType, Size, Rectangle
  File "/usr/lib/python3/dist-packages/libcamera/__init__.py", line 4, in <module>
    from ._libcamera import *
ImportError: /usr/lib/python3/dist-packages/libcamera/_libcamera.cpython-39-arm-linux-gnueabihf.so: undefined symbol: _ZN9libcamera8controls7AfRangeE

Hardware :
Pi 4b with HQ camera
Additional context
$ uname -a
Linux 5.15.32-v7l+ #1538 SMP Thu Mar 31 19:39:41 BST 2022 armv7l GNU/Linux

$ python -V
Python 3.9.2

apt show python3-libcamera
Package: python3-libcamera
Version: 0~git20220705+f30ad033-1

 $ libcamera-hello --version
libcamera-apps build: 35266e84043f 07-07-2022 (17:54:29)
libcamera build: v0.0.0+3495-bd38def2

$ pip3 show picamera2
Name: picamera2
Version: 0.2.3
Summary: The libcamera-based Python interface to Raspberry Pi cameras, based on the original Picamera library
Home-page: https://github.com/RaspberryPi/picamera2
Author: Raspberry Pi & Raspberry Pi Foundation
Author-email<EMAIL_ADDRESS>License: BSD 2-Clause License
Location: /home/pi/.local/lib/python3.9/site-packages
Requires: piexif, v4l2-python3, pillow, PiDNG, python-prctl, pyopengl, numpy, PyQt5, simplejpeg

Looks like your libcamera build is out of step with python3-libcamera.
Your python3-libcamera build:is
v0.0.0+3495-Package: python3-libcamera
Version: 0~git20220705+f30ad033-1
with a libcamera of
libcamera build: v0.0.0+3495-bd38def2
I think the suitable libcamera build is
libcamera build: v0.0.0+3700-f30ad033
So perhaps another sudo apt update & sudo apt full-upgrade  cycle needed?

@sandyol55 sudo apt update & sudo apt full-upgrade have no effect, it says All packages are up to date

@jenyak Hi, sorry that didn't help.  I have the same system as you and apart from the libcamera build version I mentioned above everything else shows the same version as yours.  Don't recall doing anything special to get that libcamera 3700 version. (My system is happily running all the latest examples with no errors)

The current python3-libcamera version (0~git20220705+f30ad033-1) has as dependency:
libcamera0 (>= 0~git20220705+f30ad033)
The current libcamera0 version is 0~git20220705+f30ad033-1
The output of my libcamera-hello --version is:
tvo@picam2-32:~ $ libcamera-hello --version
libcamera-apps build: 35266e84043f 07-07-2022 (17:54:29)
libcamera build: v0.0.0+3700-f30ad033
tvo@picam2-32:~ $

@jenyak Your libcamera0 is obviously older.
Do you by chance have an other one in /usr/local/lib (e.g. the one you had to build yourself for the initial picamera2 testing)?

Yes, I have. How can I remove it properly and use a new one?

@jenyak Delete everything related to libcamera under /usr/local/lib.
The package version is in /usr/lib/arm-linux-gnueabihf.
I do not remember if there is the equivalent /usr/local/lib/arm-linux-gnueabihf. If so, look there.

thank you @tvoverbeek
it's work now.

The current python3-libcamera version (0~git20220705+f30ad033-1) has as dependency: libcamera0 (>= 0~git20220705+f30ad033) The current libcamera0 version is 0~git20220705+f30ad033-1
The output of my libcamera-hello --version is:
tvo@picam2-32:~ $ libcamera-hello --version
libcamera-apps build: 35266e84043f 07-07-2022 (17:54:29)
libcamera build: v0.0.0+3700-f30ad033
tvo@picam2-32:~ $

@jenyak Your libcamera0 is obviously older. Do you by chance have an other one in /usr/local/lib (e.g. the one you had to build yourself for the initial picamera2 testing)?

many thanks for that. It also worked in my project.

@jenyak Delete everything related to libcamera under /usr/local/lib. The package version is in /usr/lib/arm-linux-gnueabihf. I do not remember if there is the equivalent /usr/local/lib/arm-linux-gnueabihf. If so, look there.

This worked for me too, thank you : )


Build error against PostgreSQL 13

Hi,
1.0.6 fails to build against PostgreSQL 13. 13.0 is due tomorrow. Can you please take a look?
wal2mongo.c:26:10: fatal error: utils/jsonapi.h: No such file or directory
26 | #include "utils/jsonapi.h"
|          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [: wal2mongo.o] Error 1
make[1]: *** Waiting for unfinished jobs....
wal2mongo.c:26:10: fatal error: 'utils/jsonapi.h' file not found
#include "utils/jsonapi.h"
^~~~~~~~~~~~~~~~~
1 error generated.
Regards, Devrim

Hi,
Any updates?
Regards, Devrim

ping.

ping

@devrimgunduz @devrimgunduz-edb
Please see my pull request here. It supports for Postgres 13
https://github.com/HighgoSoftware/wal2mongo/pull/3

sorry for the late! the build issues has been fixed and verified not only on PostgreSQL 13, 14 but also 15 and 16. please see the latest release v1.0.7.

sorry for the late! the build issues has been fixed and verified not only on PostgreSQL 13, 14 but also 15 and 16. please see the latest release v1.0.7.


getLocationAbsUrl for Angular 2 apps fails to execute 'querySelector' on 'Document'

getLocationAbsUrl relies on a document query selector which does not work with Angular 2.
lib/clientsidescripts.js:
var el = document.querySelector(selector);
  if (angular.getTestability) {
    return angular.getTestability(el).
        getLocation();
  }

sample spec:
    var url = 'http://localhost:3000/';
    browser.get(url);
    expect(browser.getCurrentUrl()).toBe(url);
    expect(browser.getLocationAbsUrl()).toBe(url);  // <-- does not work

error output:
1) test suite should navigate to the baes url
  Message:
    Failed: invalid element state: Failed to execute 'querySelector' on 'Document': The provided selector is empty.
      (Session info: chrome=48.0.2564.116)
      (Driver info: chromedriver=2.21.371459 (36d3d07f660ff2bc1bf28a75d1cdabed0983e7c4),platform=Mac OS X 10.11.3 x86_64) (WARNING: The server did not provide any stacktrace information)

Historically, the only reason we have getLocationAbsUrl is kind of a workaround for IE. You should be able to use getCurrentUrl just fine in Angular2, and generally prefer that.
Changing this to a documentation issue.

Ok about getLocationAbsUrl, but looks like he will get the same issue if he calls setLocation.
The error message says 'The provided selector is empty' because he is using useAllAngular2AppRoots() I suppose.


VS Code - Info: Resolve Dependancies Fails if User Path contains a SPACE

From @sporens on January 17, 2016 20:57
Hi,
The command executed by VS Code to install and resolve missing dependancies for an ASP.NET application fails with "Can't find path" when the path to the users' home folder includes a space. For example:
c:\users\joeblogs\ <- works
c:\users\joe blogs\ <- fails
Running procmon I see it's attempting to execute:
cmd.exe /c start /wait cmd.exe /c "C:\Users\joe blogs.dnx\runtimes\dnx-clr-win-x<IP_ADDRESS>-rc1-update1\bin\dnu.cmd restore & pause"
Which fails.
Thanks
Copied from original issue: Microsoft/vscode#2072

this is either omnisharp-vscode or omnisharp itself

Fixed for 'dotnet' with PR #238


hide data points

is there any way to show and hide data sets in chart.js

@sadhnaprajapati the way to do this is to set the point styles to be transparent or set the point radius to be 0


update-base-image

bumped the base image version from 3.4 to 3.9

@aliartiza75 Image is available for testing. docker pull stakater/chowkidar:SNAPSHOT-PR-32-1


Proper semantic analysis

Currently analysing the expressions generated by NML channels is largely ad-hoc and rule based.
This is sub-optimal for some reasons

optimisations are missed
no usage information is gathered, so we need to be quite conservative when generating NMODL
we might accidentally produce invalid code

This has partially been addressed in #7. We still do not check whether state variables are actually changed.
Should be easier from here though.
Reasoning like this:

assume state variable S
if S is not in derivatives
nor S in write position during breakpoint
then S never changes

That case is quite a niche occurance, closed until further notice.


[WIP] RAINCATCH-451 Update to use new simple store

What
Updated server.js to add in an id field, required by the new raincatcher-simple-store module, to the workflow object upon creation.
JIRA Ticket
https://issues.jboss.org/browse/RAINCATCH-451

LGTM

@JameelB, @nialldonnellyfh think do we need some unit tests for this?