printers not working with freerdp

Hi,
We are trying to migrate our rdesktop environment to freerdp, but we have problems with freerdp printing (usb and network)
Now we are using in rdesktop environment with thinstation 5.4 with lprng packages
this:
network printer:
PRINTER_0_NAME=LASER_GINE
PRINTER_0_DEVICE=<IP_ADDRESS>%9100           #printer_id%9100
PRINTER_0_TYPE=N
SESSION_0_RDESKTOP_OPTIONS="-k es -a 24 -u '' -d domain-r printer:LASER_='Brother PCL5e Driver' -r scard"
or usb printer:
SESSION_0_RDESKTOP_OPTIONS="-k es -a 16 -u '' -d domain-r printer:usb='Brother PCL5e Driver' -r scard"
And this works perfect with rdesktop
Now, we are trying to migrate to freerdp but we have many problems with printers in freerdp, in any situation (usb or network printer) printer is redirected but when we try tyo print a message is showed in windows ts session that can't be printed, we have tried with:
usb printer with driver
xfreerdp /printer:usb /v:server
[10:17:36:403] [6271:6272] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[10:17:36:403] [6271:6272] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[10:17:36:404] [6271:6272] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: root
[10:17:36:418] [6271:6272] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[10:17:36:421] [6271:6272] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[10:17:36:522] [6271:6273] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[10:17:36:523] [6271:6273] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[10:17:52:716] [6271:6273] [INFO][com.freerdp.channels.rdpdr.client] - registered device #1: PRN1 (type=4 id=1)
[10:18:25:253] [6271:6273] [ERROR][com.freerdp.channels.rdpdr.client] - Ignoring unhandled message PAKID_PRN_CACHE_DATA (EventID: 0x0002)
[10:21:22:572] [6271:6273] [ERROR][com.freerdp.channels.rdpdr.client] - Ignoring unhandled message PAKID_PRN_CACHE_DATA (EventID: 0x0002)
[10:21:24:083] [6271:6272] [ERROR][com.freerdp.core] - ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off his or her session on the server.
[10:21:24:084] [6271:6272] [ERROR][com.freerdp.core.rdp] - DisconnectProviderUltimatum: reason: 3
network printer with driver
ts:~# xfreerdp /printer:NETWORK-PRINTER /v:server
[10:28:07:778] [6390:6391] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[10:28:07:778] [6390:6391] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[10:28:07:780] [6390:6391] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: root
[10:28:07:791] [6390:6391] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[10:28:07:793] [6390:6391] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[10:28:07:884] [6390:6392] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[10:28:07:884] [6390:6392] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[10:28:13:969] [6390:6392] [INFO][com.freerdp.channels.rdpdr.client] - registered device #1: PRN1 (type=4 id=1)
[10:28:46:057] [6390:6392] [ERROR][com.freerdp.channels.rdpdr.client] - Ignoring unhandled message PAKID_PRN_CACHE_DATA (EventID: 0x0002)
[10:30:13:464] [6390:6391] [ERROR][com.freerdp.core] - ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off his or her session on the server.
[10:30:13:464] [6390:6391] [ERROR][com.freerdp.core.rdp] - DisconnectProviderUltimatum: reason: 3
usb printer with driver
ts:~# xfreerdp /printer:usb,'Brother PCL5e Driver' /v:server /f
[12:03:58:681] [6566:6567] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[12:03:58:681] [6566:6567] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[12:03:58:683] [6566:6567] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: root
[12:03:58:692] [6566:6567] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[12:03:58:695] [6566:6567] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[12:03:58:798] [6566:6568] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[12:03:58:799] [6566:6568] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[12:04:04:752] [6566:6568] [INFO][com.freerdp.channels.rdpdr.client] - registered device #1: PRN1 (type=4 id=1)
[12:04:27:677] [6566:6567] [ERROR][com.freerdp.core] - ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off his or her session on the server.
[12:04:27:677] [6566:6567] [ERROR][com.freerdp.core.rdp] - DisconnectProviderUltimatum: reason: 3
network printer with driver
ts:~#  xfreerdp /printer:NETWORK-PRINTER,'Brother PCL5e Driver' /v:server /f
[12:08:18:839] [6385:6386] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[12:08:18:839] [6385:6386] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[12:08:18:840] [6385:6386] [INFO][com.freerdp.client.x11] - No user name set. - Using login name: root
[12:08:18:850] [6385:6386] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[12:08:18:853] [6385:6386] [WARN][com.freerdp.core.nego] - Error: SSL_NOT_ALLOWED_BY_SERVER
[12:08:18:934] [6385:6387] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[12:08:18:935] [6385:6387] [INFO][com.freerdp.channels.rdpdr.client] - Loading device service printer (static)
[12:08:27:548] [6385:6387] [INFO][com.freerdp.channels.rdpdr.client] - registered device #1: PRN1 (type=4 id=1)
[12:08:52:101] [6385:6386] [ERROR][com.freerdp.core] - ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off his or her session on the server.
[12:08:52:101] [6385:6386] [ERROR][com.freerdp.core.rdp] - DisconnectProviderUltimatum: reason: 3
What can I do allow printer with freerdp and thinstation as it was used with rdesktop?
Thanks

Could you give some details regarding your environment, freerdp version and compile flags?
What comes to mind is WITH_CUPS cmake option is required for proper operation.

Hi,
freerdp was compiled with cups:
cmake . -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_INSTALL_LIBDIR=lib
-DDOCBOOKXSL_DIR=/usr/share/sgml/docbook/xsl-ns-stylesheets
-DCMAKE_BUILD_TYPE=Release
-DWITH_PCSC=ON
-DBUILD_SHARED_LIBS=ON
-DWITH_CHANNELS=ON
-DWITH_CHANNELS_PRINT=ON
-DWITH_SERVER=OFF
-DWITH_CLIENT=ON
-DWITH_PULSE=ON
-DWITH_ALSA=ON
-DWITH_CUPS=ON
-DWITH_FFMPEG=ON
-DCHANNEL_URBDRC_CLIENT=ON
-DWITH_GSTREAMER=ON
-DWITH_DIRECTFB=OFF
-DWITH_XINERAMA=ON
-DWITH_CUNIT=OFF
-DWITH_JPEG=ON
-DWITH_IPP=OFF
-DWITH_NPP=OFF
-DWITH_MANPAGES=ON
-DWITH_SAMPLE=ON
With rdesktop printing was wotrking without cups. With freerdp is required to install cups? Can be used without cups? How I have to configure for network and usb printing?
Thanks

@trentasis yes we rely on cups for printing

only cups? or are there other options?
what is the xorrect way to configure freerdp printing?

with cups Works, but driver is fixed with imagesetter?


Don't use setlocal in syntax file

I'm not 100% sure that one should not use setlocal in a syntax file, but this breaks other filetypes that may include this syntax file, like the vim-markdown plugin if jinja is included in its g:markdown_fenced_languages.  The comments and commentstring end up set in the markdown buffer with the jinja settings.
See https://github.com/dhruvasagar/vim-table-mode/issues/162#issuecomment-595317626 for an example of side effects.

I think the right place for this would be in a filetype plugin, as in https://github.com/Glench/Vim-Jinja2-Syntax/blob/6eff8287c4b61e9fb8657773f36402b33750fc27/ftplugin/jinja.vim#L10-L11

I know nothing about vim or its syntax files. These lines seem to refer to entering comments in Jinja, how does removing these lines affect that?

@davidism Not an expert on what vim's doing here, but I'll give it a try.
The gist of it is that this file defining syntax highlighting is exceeding its scope by setting the detected comment format in the syntax file.
The upshot is that when a vim buffer that pulls in multiple different syntax highlighting files, such as a markdown file with a Jinja code block in this case, evaluates this syntax file, it sets the comment format for the whole buffer.  So the comment format for the entire markdown file ends up as Jinja's comment format.

Ok, but if this is removed and we're no editing jinja in markdown, what happens to jinja comments?

This behavior seems correct for a jinja template that happens to render a markdown document. Jinja comments will be processed out when rendering jinja before rendering markdown, they're the comments that should be preferred.

This behavior seems correct for a jinja template that happens to render a markdown document. Jinja comments will be processed out when rendering jinja before rendering markdown, they're the comments that should be preferred.

Yes, true.  It is not correct for a markdown document (that is not being rendered) that includes a Jinja code block.  That's my case.

If this is removed and we're not editing jinja in markdown, just plain jinja, what happens to comments?

If you're just using this syntax file alone, I'm not sure.  As far as I understand it, this could/should be set elsewhere, per my earlier comment:

I think the right place for this would be in a filetype plugin, as in https://github.com/Glench/Vim-Jinja2-Syntax/blob/6eff8287c4b61e9fb8657773f36402b33750fc27/ftplugin/jinja.vim#L10-L11

cc: @tbnorth who originally added this in #990.

Are there other Vim syntax files you can compare this to? How does, for example, a Python or HTML syntax file define comments that work in fenced blocks / multi-language files? Are we sure this is an issue with this file and not with Vim / another plugin that's providing fenced code support?

Are there other Vim syntax files you can compare this to? How does, for example, a Python or HTML syntax file define comments that work in fenced blocks / multi-language files? Are we sure this is an issue with this file and not with Vim / another plugin that's providing fenced code support?

This jinja one is the only one that has broken markdown highlighting for me, and I have around 20 languages configured to highlight in the fenced code blocks.
Here's where html and python in the vim repository set their comment strings, in the ftplugin file, and not in the syntax file:

html: https://github.com/vim/vim/blob/9be61bbb170ed3df0e408c8ac12516e772dc0b75/runtime/ftplugin/html.vim#L16
python: https://github.com/vim/vim/blob/9be61bbb170ed3df0e408c8ac12516e772dc0b75/runtime/ftplugin/python.vim#L38

Here's where commentstring is set in ftplugin or syntax files in the vim repository for languages included with vim.  Only in two syntax files, and I suspect those may not be intended.  In both cases, they are already set in ftplugin files.
ken@pancakes:~/working/git/github/vim/runtime (master=) $ ack -l '^set(local)? commentstring' | sort
ftplugin/abaqus.vim
ftplugin/ada.vim
ftplugin/awk.vim
ftplugin/bst.vim
ftplugin/cfg.vim
ftplugin/clojure.vim
ftplugin/cmake.vim
ftplugin/cobol.vim
ftplugin/csh.vim
ftplugin/c.vim
ftplugin/dockerfile.vim
ftplugin/dosbatch.vim
ftplugin/dtd.vim
ftplugin/dtrace.vim
ftplugin/eiffel.vim
ftplugin/eruby.vim
ftplugin/gdb.vim
ftplugin/go.vim
ftplugin/groovy.vim
ftplugin/hamster.vim
ftplugin/hog.vim
ftplugin/html.vim
ftplugin/javascript.vim
ftplugin/java.vim
ftplugin/jproperties.vim
ftplugin/json.vim
ftplugin/j.vim
ftplugin/liquid.vim
ftplugin/make.vim
ftplugin/matlab.vim
ftplugin/meson.vim
ftplugin/mma.vim
ftplugin/msmessages.vim
ftplugin/nroff.vim
ftplugin/ocaml.vim
ftplugin/pdf.vim
ftplugin/perl6.vim
ftplugin/perl.vim
ftplugin/php.vim
ftplugin/python.vim
ftplugin/registry.vim
ftplugin/rmd.vim
ftplugin/rrst.vim
ftplugin/ruby.vim
ftplugin/rust.vim
ftplugin/r.vim
ftplugin/sass.vim
ftplugin/scala.vim
ftplugin/sh.vim
ftplugin/tcl.vim
ftplugin/text.vim
ftplugin/tmux.vim
ftplugin/vim.vim
ftplugin/vroom.vim
ftplugin/wast.vim
ftplugin/xml.vim
syntax/dockerfile.vim
syntax/mma.vim


Prepare for new release of Jira

Workflow links: https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/5408449166, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/5408451041, https://github.com/atlassian-labs/atlassian-slack-integration-server/actions/runs/5408452801.

This one will be addressed in #299


prompt as class

We plan to change the prompts (system messages) to a class and make schema-specific inputs as class parameters. This will facilitate improving prompts over time and enable benchmarking across prompts.

Parent class Prompt, has input space of a message with placeholders (how do we format them)
and a list of elements (of length same as the placeholders) to insert at the placeholders

Would be most useful in the automated benchmarking matrix, to be able to change the prompts in isolation from the other components of the benchmarking tests.


Infinite Loading Loop

I have followed all of the steps in the document on GitHub CoPilot Studio Samples and have run into an infinite loading screen on when clicking on the button generated in our SharePoint page, I feel as though all of the information in the elements file is correct (In step 3 I chose Option 2: manually replace placeholders in elements.xml with actual values. ClientSideComponentProperties accepts an escaped JSON string.)
When inspecting the console on the webpage, these errors are found: “invalid contentSourceFilter config” and “Unsafe attempt to initiate navigation for frame with origin ‘https://...’ from frame with URL 'https://…'  The frame attempting navigation of the top-level window is sandboxed, but the flag of ‘allow-top-navigation’ or ‘allow-top-navigation-by-user-activation is not set.”

i have the same issue

Open dev tools, and follow the login.microsoftonline.com url in the error for a page with more details.
See for example here: https://github.com/microsoft/CopilotStudioSamples/issues/231#issuecomment-2263146384


[SCB-813] Fix the pack-contract-grpc build issue on macOSX

升级依赖的protoc-gen-grpc-java版本，见 https://github.com/grpc/grpc-java/issues/1683

Follow this checklist to help us incorporate your contribution quickly and easily:

[ x ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ x ] Each commit in the pull request should have a meaningful subject line and body.
[ x ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ x ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

[ERROR] PROTOC FAILED: --java-pgv_out: protoc-gen-java-pgv: Plugin killed by signal 11.

how did you run the JVM? I guess you may still need to use X86 interpreter.

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/Homebrew/Cellar/maven/3.6.3_1/libexec
Java version: 15.0.1, vendor: N/A, runtime: /usr/local/Homebrew/Cellar/openjdk/15.0.1/libexec/openjdk.jdk/Contents/Home
Default locale: en_IN, platform encoding: UTF-8
OS name: "mac os x", version: "11.2.1", arch: "x86_64", family: "mac"
✗ java -version
openjdk version "11.0.9" 2020-10-20
OpenJDK Runtime Environment (build 11.0.9+11)
OpenJDK 64-Bit Server VM (build 11.0.9+11, mixed mode)

That might be helpful
https://github.com/grpc/grpc-java/issues/7690


Adding a 3rd party library such as PrimeNG

Hello,
I'm having a hard time adding any 3rd party modules.  I've tried PrimeNG and ag-grid, with little success.  I have been successful at adding a 3rd party module to the base repository ( AngularClass/angular2-webpack-starter).  I then try to replicate what I did with an instance of this repository and I end up with odd errors on load:

Error: Unexpected value 'AccordionModule' imported by the module 'AppModule'. Please add a @NgModule annotation.
at syntaxError (file:///D:/devtools/js/tutorials/angular-electron-dream-starter/dist/vendor.dll.js:16427:34) []
at file:///D:/devtools/js/tutorials/angular-electron-dream-starter/dist/vendor.dll.js:29321:44 []
at Array.forEach (native) []
at CompileMetadataResolver.vendor_lib.136.CompileMetadataResolver.getNgModuleMetadata (file:///D:/devtools/js/tutorials/angular-electron-dream-starter/dist/vendor.dll.js:29304:49) []
at JitCompiler.vendor_lib.136.JitCompiler._loadModules (file:///D:/devtools/js/tutorials/angular-electron-dream-starter/dist/vendor.dll.js:40485:64) []

I've found this on the web https://github.com/angular/angular/issues/15763 but not sure how that relates to this project.
First this is what I did to get PrimeNG to work with a fresh clone of AngularClass/angular2-webpack-starter:

git clone https://github.com/AngularClass/angular2-webpack-starter.git
npm install
cd angular2-webpack-starter
npm start
everything goes ok
Now add PrimeNG and font-awesome
stop the server
npm install --save primeng
npm install --save font-awesome
open /config/webpack.common.js
change line ~286 to:

new CopyWebpackPlugin([
        { from: 'src/assets', to: 'assets' },
        { from: 'src/meta'},
        {
          from: 'node_modules/font-awesome/css/font-awesome.min.css',
          to: 'assets/font-awesome/css/font-awesome.min.css'
        },
        {
          from: 'node_modules/font-awesome/fonts',
          to: 'assets/font-awesome/fonts'
        },
        { from: 'node_modules/primeng/resources', to: 'assets/primeng/resources' }
      ]),

open /config/head-config.common.js
add following line ~40
/**  tags for primeng and font-awesome **/
{ rel:"stylesheet", type:"text/css", href:"/assets/primeng/resources/themes/omega/theme.css" },
{ rel:"stylesheet", type:"text/css", href:"/assets/primeng/resources/primeng.min.css" },
{ rel:"stylesheet", type:"text/css", href:"/assets/font-awesome/css/font-awesome.min.css" }
open /src/app/app.module.ts
add line 2
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
add line 32
import { AccordionModule } from 'primeng/components/accordion/accordion';
add BrowserAnimationsModule and AccordionModule (this is from primeng) to imports (line ~61):
imports: [ // import Angular's modules
    BrowserModule,
    BrowserAnimationsModule,
    FormsModule,
    HttpModule,
    AccordionModule,
    RouterModule.forRoot(ROUTES, { useHash: true, preloadingStrategy: PreloadAllModules })
  ],

in /src/app/home/home.component.ts line 3 add
<p-accordion>
        <p-accordionTab header="Godfather I" [selected]="true">
            The story begins as Don Vito Corleone, the head of a New York Mafia family, overseeshis daughter's wedding. His beloved son ichael has just come home from the war, but does not intend to become part of his father's business. T hrough Michael's life the nature of the family business becomes clear. The business of the family is just like the head of the family, kind and benevolent to those who give respect, but given to ruthless violence whenever anything stands against the good of the family.
        </p-accordionTab>
        <p-accordionTab header="Godfather II">
            Francis Ford Coppola's legendary continuation and sequel to his landmark 1972 film, The_Godfather parallels the young Vito Corleone's rise with his son Michael's spiritual fall, deepening The_Godfather's depiction of the dark side of the American dream. In the early 1900s, the child Vito flees his Sicilian village for America after the local Mafia kills his family. Vito struggles to make a living, legally or illegally, for his wife and growing brood in Little Italy, killing the local Black Hand Fanucci after he demands his customary cut of the tyro's business. With Fanucci gone, Vito's communal stature grows.
        </p-accordionTab>
        <p-accordionTab header="Godfather III">
            After a break of more than  15 years, director Francis Ford Coppola and writer Mario Puzo returned to the well for this third and final story of the fictional Corleone crime family. Two decades have passed, and crime kingpin Michael Corleone, now divorced from his wife Kay has nearly succeeded in keeping his promise that his family would one day be completely legitimate.
        </p-accordionTab>
    </p-accordion>
<p-accordion>
        <p-accordionTab header="Godfather I" [selected]="true">
            The story begins as Don Vito Corleone, the head of a New York Mafia family, overseeshis daughter's wedding. His beloved son ichael has just come home from the war, but does not intend to become part of his father's business. T hrough Michael's life the nature of the family business becomes clear. The business of the family is just like the head of the family, kind and benevolent to those who give respect, but given to ruthless violence whenever anything stands against the good of the family.
        </p-accordionTab>
        <p-accordionTab header="Godfather II">
            Francis Ford Coppola's legendary continuation and sequel to his landmark 1972 film, The_Godfather parallels the young Vito Corleone's rise with his son Michael's spiritual fall, deepening The_Godfather's depiction of the dark side of the American dream. In the early 1900s, the child Vito flees his Sicilian village for America after the local Mafia kills his family. Vito struggles to make a living, legally or illegally, for his wife and growing brood in Little Italy, killing the local Black Hand Fanucci after he demands his customary cut of the tyro's business. With Fanucci gone, Vito's communal stature grows.
        </p-accordionTab>
        <p-accordionTab header="Godfather III">
            After a break of more than  15 years, director Francis Ford Coppola and writer Mario Puzo returned to the well for this third and final story of the fictional Corleone crime family. Two decades have passed, and crime kingpin Michael Corleone, now divorced from his wife Kay has nearly succeeded in keeping his promise that his family would one day be completely legitimate.
        </p-accordionTab>
    </p-accordion>

go back to command line and do:
npm start
you should see:

Everything works.
I repeat the above steps but instead clone this repository.  I run into two problems:

The exception noted above
Resource load failures
Failed to load resource: net::ERR_FILE_NOT_FOUND primeng.min.css
Failed to load resource: net::ERR_FILE_NOT_FOUND font-awesome.min.css
Failed to load resource: net::ERR_FILE_NOT_FOUND theme.css
Although even with the resource load failure it should at least run, just not look good.

Any hints on what steps I should follow when adding a module like PrimeNG to this?
Things I've tried:

update the version of Angular to 4.0.3 from 4.0.2, no effect.

Thanks
Greg.

I don't believe I've changed anything from AngularClass/angular2-webpack-starter that would impact this behavior. From the error message it looks like it is a Webpack DLL issue. A couple things to check:

Test if it works in a production build
Try adding NGPrime to the list of vendor DLLs here: https://github.com/colinskow/angular-electron-dream-starter/blob/master/config/webpack.dev.js#L160

I've been working on the Electron port and haven't yet had a chance to customize it much to work out the issues. So I apologize I can't help you much at this point.

Import your stylesheets here instead of in /config/head-config.common.js.

Hello,
Thanks for the reply, it has me on the right track.  I had previously tried adding Primeng to the vendor dlls, I tried adding both as:
'primeng',
and
{
     //see https://github.com/shlomiassaf/webpack-dll-bundles-plugin/issues/16
      name: 'primeng',
      path: 'primeng/primeng'
},

neither worked, or generated any errors (perhaps that's meaningful).
Before trying the production builds I commented it out of the vendor dll settings in webpack.dev.js.
Then I did:

npm run build:prod

Then ran it, still same problem.
Then I tried:

npm run build:aot

and it runs!
I haven't got the styles sorted out yet but that shouldn't be a problem.
So the question is what is different between these builds ?  I'll try to figure it out but if you have any ideas where to look that would be great.
Thanks for your help.

To get PrimeNG working with Angular 4, you need to specify version 4.0.0-rc.4. The latest stable release (installed by default with npm install) will only work with Angular 2.
It is likely that you were using the Angular 2 version of angular2-webpack-starter, and the Angular 4 version of my repo... which would explain the different behavior.

Hello Colin,
No I was using the correct version of Primeng and Angular.  In BOTH cases it was:
Primeng 4.0.0-rc.3 and rc.4 (tried both)
and
Angular 4 (4.0.2 and 4.0.3)
FWIW doing npm install --save primeng installs the latest 4.0 release not 2.0.x, here I did npm init then install,:

Directory of D:\devtools\js\tutorials\testprimeng
4/28/2017  09:12 AM              .
4/28/2017  09:12 AM              ..
4/28/2017  09:12 AM               207 package.json
1 File(s)            207 bytes
2 Dir(s)  458,858,405,888 bytes free
:\devtools\js\tutorials\testprimeng>npm install --save primeng
<EMAIL_ADDRESS>D:\devtools\js\tutorials\testprimeng
--<EMAIL_ADDRESS>  <--- installs 4.0.0.x

This is one of the first things I verified.  This is a section of package.json that I used when testing latest of your repo:
"dependencies": {
    "electron-devtools-installer": "^2.2.0",
    "font-awesome": "^4.7.0",
    "primeng": "^4.0.0-rc.4",
    "rxjs": "~5.3.0"
  },
  "devDependencies": {
    "@angular/animations": "~4.0.3",
    "@angular/common": "~4.0.3",
    "@angular/compiler": "~4.0.3",
    "@angular/compiler-cli": "~4.0.3",
    "@angular/core": "~4.0.3",
    "@angular/forms": "~4.0.3",
    "@angular/http": "~4.0.3",
    "@angular/platform-browser": "~4.0.3",
    "@angular/platform-browser-dynamic": "~4.0.3",
    "@angular/platform-server": "~4.0.3",
    "@angular/router": "~4.0.3",
    "@angularclass/conventions-loader": "^1.0.13",
    "@angularclass/hmr": "~1.2.2",
    "@angularclass/hmr-loader": "~3.0.2"
    ...

Note I had updated your angular from 4.0.2 to 4.0.3 to match what was in the  angular2-webpack-starter project to see if that made a difference (it didn't).
Here is the package.json for angular2-webpack-starter
"dependencies": {
    "@angular/animations": "~4.0.3",
    "@angular/common": "~4.0.3",
    "@angular/compiler": "~4.0.3",
    "@angular/core": "~4.0.3",
    "@angular/forms": "~4.0.3",
    "@angular/http": "~4.0.3",
    "@angular/platform-browser": "~4.0.3",
    "@angular/platform-browser-dynamic": "~4.0.3",
    "@angular/platform-server": "~4.0.3",
    "@angular/router": "~4.0.3",
    "@angularclass/conventions-loader": "^1.0.13",
    "@angularclass/hmr": "~1.2.2",
    "@angularclass/hmr-loader": "~3.0.2",
    "core-js": "^2.4.1",
    "font-awesome": "^4.7.0",
    "http-server": "^0.9.0",
    "ie-shim": "^0.1.0",
    "jasmine-core": "^2.5.2",
    "primeng": "^4.0.0-rc.4",
    "reflect-metadata": "^0.1.10",
    "rxjs": "5.0.2",
    "zone.js": "~0.8.5"
  },
  "devDependencies": {
    "@angular/compiler-cli": "~4.0.3",
    "@types/hammerjs": "^2.0.34",
    "@types/jasmine": "2.5.45",
    "@types/node": "^7.0.13",
    "@types/source-map": "^0.5.0",
    "@types/uglify-js": "^2.6.28",
    "@types/webpack": "^2.2.15",
    ...

For your repo the only build that I have working is the:
npm run build:aot
When I run the resulting electron it executes normally, for any other build I get the:

Unexpected value 'AccordionModule' imported by the module 'AppModule'. Please add a @NgModule annotation.

exception.
I've been looking over the webpack files to figure out why but haven't yet.

OK I finally figured out what the problem was.  The webpack.common.js file for your repository contains:
~ line 213
    /*
     * Exclude package.json dependencies from the bundle
     *
     * See: https://webpack.js.org/configuration/externals/
     */
    externals: [dependencyExternals()]

The above code is not in the webpack.common.js from AngularClass/angular2-webpack-starter.
In an AOT build I'm guessing the dependencies are pre-compiled into the bundle, and that's why it works and primeng was loaded.
From the docs I'm trying to reconcile what this means:

Each package listed in package.json under dependencies will automatically be packaged with your app and rebuilt for Electron if it contains native bindings.

Given that the above webpack dependencyExternals seems to contradict this.  When I commented out the externals: [dependencyExternals()]  the primeng components were loaded OK.  However I have a dependency on better-sqlite3 (a module with native bindings), which if I leave externals: [dependencyExternals()] commented out no longer works (get errors from binding.js).  So I've white listed primeng like:
    /*
     * Exclude package.json dependencies from the bundle
     *
     * See: https://webpack.js.org/configuration/externals/
     */
    externals: [dependencyExternals({
        // this will include `primeng`
        whitelist: ['primeng/primeng']
    })],

and for the .css files in src/styles/styles.scss
@import './../../node_modules/primeng/resources/themes/omega/theme.css';
@import './../../node_modules/primeng/resources/primeng.min.css';
@import './../../node_modules/font-awesome/css/font-awesome.min.css';

now npm build:dev and npm build:prod builds work.
If you have a chance and could explain why primeng needs to be white listed while a module like better-sqlite3 needs to be excluded I'd love to know.
Thanks.
Greg.

Hi Greg,
You don't need to whitelist PrimeNG. You simply need to make it a devDependency.
Every module that is listed under dependencies is packaged in the node_modules directory of the built app and is not parsed by Webpack.
See this part of the README:
https://github.com/colinskow/angular-electron-dream-starter#managing-dependencies
Your dependencies are modules that are needed by the Electron runtime. DevDependencies are parsed and bundled by Webpack.
SQLite3 has native node dependencies so it won't work if bundled by Webpack. It should be included in dependencies.
Remove the whitelist and try it as a simple devDependency. It should work as expected.

Hello Colin,
OK tried that and it does indeed work.
I feel stupid... I read that doc over and over thinking I had things right.
With your explanation I think I understand the reasons for the separation.  The confusing part for me (being new to Electron and Web dev) is that most examples for 3rd party modules recommend that they go in "dependencies".  And when I read the npm install docs

"dependencies": these packages are required by your application in production
"devDependencies": these packages are only needed for development and testing

Intuitively to me primeng is a dependencies package.  However with your explanation I understand what you've done for Electron.
Thanks for the help.
Greg.

Yes, if you notice almost everything in my package.json is under devDependencies.
dependencies are packaged with the application runtime in production by Electron Builder. @angular and its modules are compiled and tree shaken by Webpack, so the original files don't need to be packages with the application.
I needed a way to tell Electron what to package with the app, and dependencies vs. devDependencies seemed like the simplest distinction.


Named semaphores are not supported on Unix

Ref: https://github.com/dotnet/coreclr/blob/5e9a125/src/mscorlib/src/System/Threading/Semaphore.cs#L96
This fixes some of the failing tests on Ubuntu.

These are the three tests that were failing:

Log was expected to contain 'Value:Baz', but did not.
Log was expected to contain '[Build]', but did not.
Log was expected to contain '[fail]', but did not.

An example of exception:
        Log was expected to contain 'Value:Baz', but did not.
        =======
        Build started.
        /tmp/tmp37cda089252f45e69601cf324a856456.tmp(0,0):  error MSB4014: The build stopped unexpectedly because of an internal failure.
        This is an unhandled exception from a task -- PLEASE OPEN A BUG AGAINST THE TASK OWNER.
        System.PlatformNotSupportedException: Named synchronization primitives are not supported on this platform.
           at System.Threading.Semaphore.CreateSemaphone(Int32 initialCount, Int32 maximumCount, String name)
           at System.Threading.Semaphore..ctor(Int32 initialCount, Int32 maximumCount, String name)
           at Microsoft.Build.BackEnd.NodeProviderInProc.CreateNode(Int32 nodeId, INodePacketFactory factory, NodeConfiguration configuration)
           at Microsoft.Build.BackEnd.NodeManager.AttemptCreateNode(INodeProvider nodeProvider, NodeConfiguration nodeConfiguration)
           at Microsoft.Build.BackEnd.NodeManager.CreateNode(NodeConfiguration configuration, NodeAffinity nodeAffinity)
           at Microsoft.Build.Execution.BuildManager.PerformSchedulingActions(IEnumerable`1 responses)
           at Microsoft.Build.Execution.BuildManager.HandleNewRequest(Int32 node, BuildRequestBlocker blocker)
           at Microsoft.Build.Execution.BuildManager.IssueRequestToScheduler(BuildSubmission submission, Boolean allowMainThreadBuild, BuildRequestBlocker blocker)
        Build FAILED.

        =======
        Expected: True
        Actual:   False
        Stack Trace:
              at Microsoft.Build.UnitTests.MockLogger.AssertLogContains(Boolean isCaseSensitive, String[] contains)
              at Microsoft.Build.UnitTests.MockLogger.AssertLogContains(String[] contains)
              at Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.GhostProjectRootElementCache()
     Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.Regress239661 [SKIP]
        FEATURE: OOP NODES
     Microsoft.Build.UnitTests.BackEnd.BuildManager_Tests.FailedAfterTargetInP2PShouldCauseOverallBuildFailure_MultipleEntrypoints [FAIL]

@rainersigwald, @cdmihai can you please take a look?  :)

@jasonwilliams200OK
We have to review the msbuild multi-proc protocol to understand the implications of this change.
How urgent do you require this in? Is it a blocking issue?

@cdmihai, not really blocking me. I am behind dotnet-cli cover for xplat. I saw https://github.com/Microsoft/msbuild/pull/667 and found that some tests are failing and thought about investigating the issues on Ubuntu and found this one as a low-hanging fruit. :smile:

Ok, I'm pretty sure I understand enough about this now that this looks good with a little more explanation commentary in the commit message.

Thanks @rainersigwald, I have addressed the feedback.

@dotnet-bot test this please

@rainersigwald, is that OSX build failure unrelated to my changes?

:shipit:

@dotnet-bot test this please

@jasonwilliams200OK I haven't seen that failure before, and it happened twice in a row on this change, so I am suspicious of this change. Though I cannot see why this would change it . . .

@rainersigwald, https://github.com/Microsoft/msbuild/pull/883#issuecomment-238714213 :smile:
Agree that this is intermittent issue and a strange one.

@dotnet-bot test OSX Build for CoreCLR please

@dotnet-bot test OSX Build for CoreCLR please

With #886 merged, I have rebased it and all green! :deciduous_tree:

@rainersigwald, can you please take another look? :)

Looks good, thanks again!


No Unity 2020.2.5f1 docker image

Context
I want to use this image. Because old Unity version don't works correctly with com.unity.localization package. Updating of Unity to latest is one of suggestions from Unity Team. https://forum.unity.com/threads/troubleshooting-addressables-issues.1060346/
I want to avoid version degradation to 2019. May be new version solve my problem with localization.
Suggested solution
Please, deploy this version to docker hub to use it from GH Actions.
Considered alternatives

Additional details
I have failed build here https://github.com/kreghek/Zilon_Roguelike/runs/1933651478?check_suite_focus=true
There is my build config https://github.com/kreghek/Zilon_Roguelike/blob/fix-997-localization-recreate-2/.github/workflows/activation.yml

+1. Also, 2020.2.6f1 is out for a few days. Is the automated system broken? The readme states that new versions should be added automatically after a few hours.

See my answer here https://github.com/game-ci/docker/issues/79

It's running.

Closing this issue. Thanks for bringing it up!


build: install the layers libraries on linux

My previous PR #48 apparently forgot to install the layers themselves.

No idea if this is the expected location for these, but it's more correct that what's in there :)


Fix mixed content warnings

From another PR:
https://github.com/SenseNet/sensenet.github.io/pull/315/checks?check_run_id=249526454
Mixed content detected
Although you have enabled HTTPS on your site, we’ve detected some content that’s still being served over an HTTP connection.

DETAILS
In blog/2016/02/02/sn7-picker-under-the-hood.html:

img http://download.sensenet.com/BlogPostImages/SN7CopyPicker/tabletfoundationgrid.png
img http://download.sensenet.com/BlogPostImages/SN7CopyPicker/tabletbootstrapthumb.png
In blog/2016/02/23/improving-the-portlet-structure-in-sn7.html:

img http://download.sensenet.com/BlogPostImages/CardSorting/cards.png,
img http://download.sensenet.com/BlogPostImages/CardSorting/groups.png

Hi @hugovk,
Thank you for your contribution! Make sure to fill in our form so we can send you a 👕.

Done, thanks!


explain S0020 startup modes

We need a bit more explanation of the modes here:
https://rsmp-nordic.org/rsmp_specifications/rsmp_sxl_traffic_lights/1.0.15/sxl_traffic_light_controller.html#s0020

startup: The controller starts up, performs a power on self test and performs the start-up intervals*
control: Normal 3-light control
standby: The controller is in dark or yellow flash mode (either according to programming or manually set)
failure: The controller has a “major fault” defined according to 3.8 i EN12675. The controller is in dark or yellow flash mode
test: Mode used for various tests, e.g. signal lights

Note:
*)  It is required that
the controller always starts with a startup sequence before using normal 3-light control:
In Sweden this can be defined as:
Start-up interval 1: minimum 3 seconds, yellow flash for vehicles and bicycles
Start-up interval 2: minimum 3 seconds, yellow
Start-up interval 3: minimum 3 seconds, red
This is specfied in Transportstyrelsens författningssamling TSFS, chapter 2, §17 (page 4)

PR here: https://github.com/rsmp-nordic/rsmp_schema/pull/98

done


Problem in safari glow animation

fix: add css will-change prop to fix safari glow animation

Done


Sometimes client calls server IP which fails SSL check as IP adress is not included in servers SSL certificate

Using Angular 10 and oidc client package from dotnetcore individual auth startet project, the client sometimes loses its 'authenticated' state. In the browsers F12 debugger i found that the client is lauching a request against servers IP, which fails SSL check as IP adress is not included in servers SSL certificate.
I am using the authorize guard inside 2 different routing modules, one of it is lazy loaded.
This only happens from day to day... how can i fix this?

Sorry, I can't help you with your TLS issues.

Thank you, of course. I thought the issue is, that it is calling the IP instead of domain. Because win-acme (which i am using) could not include ip addresses to the SSL certificate.
Maybe its okay that it is using the IP but i need another cert? Is this what you mean? Thank you

Oh I see... I wasn't clear that you were trying to use the IP. So no, you can't do that :) You need proper DNS (or local hosts hacked up) and cert to match.

Okay thank you1 :)  How can i configure oidc-js NOT to use ip address?

Don't use an IP address in the Authority.


Break is_binary_string() into separate functions

More info: https://scrutinizer-ci.com/g/audreyr/binaryornot/code-structure/master/py-function/binaryornot.is_binary_string

PR https://github.com/audreyr/binaryornot/pull/38


Add docs cmdline args

Description
This PR introduces a new CI step which generates new cmdline args documentation, depending if pkg/apis/externaldns/types.go is modified by a PR.

Won't be integrated in upstream


Konnect August Release Notes

Summary
Kong Konnect August updates to the release notes.
Reason
Monthly release notes.
Testing
None required.

This PR replaces https://github.com/Kong/docs.konghq.com/pull/4324


Implement Markdown Changelog Message Feature in Inbox System

The task involves implementing a changelog message feature to our inbox system before we launch the dimension to the public. The content format should be in markdown to allow for the inclusion of images and other media in the release notes.
Here are the steps to complete this task:

Develop a system to generate and send changelog messages to users' inboxes.

Ensure the system supports markdown format for versatile content creation.

Include fields for a short title and description for the preview of the changelog message.

Add metadata fields such as the author and date published.

Collaborate with our designer to create a user-friendly and aesthetically pleasing layout for these changelog messages.

Test the system thoroughly before the public launch of the dimension.

Remember, the goal is to keep our users informed about updates in a clear and engaging manner.

lgtm!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #486 (827ceb7) into main (65d2aee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add food recommendations based on weather

We would like to add a feature for recommending food based on the weather at the user's chosen location.
@Ahmed-Labs @sumana2001

Could you elaborate more on the issue? Will it based on location as well? Like must try foods of certain places? Also how many options will they be getting? Will it be hardcoded or from some API call?

Currently, we have four categories of food types {summer, fall, spring and winter} and associated food recommendation names that are scraped from articles on a website. We use the weather condition code from the API response to determine the appropriate food category. We then randomly recommend the food from the category and display it with an icon or background that represents that category.
The location is not currently being used to recommend specific local dishes.


[v1.22] connection handler: handle the update of listener's ipv4_compat flag correctly

Signed-off-by: He Jie Xu<EMAIL_ADDRESS>Commit Message: connection handler: handle the update of listener's ipv4_compat flag correctly
Additional Description:
Currently, when updating a listener's ipv4_compat flag from true to false, the mapping on the corresponding ipv4 address for this listener will be kept. After the old listener is drained, that mapping will be left on the map also. That mapping will reference a destructed listener config, which will lead to envoy crash at any time.
This PR fixes that by cleanup those mapping when found there is an update for ipv4_compat flag.
Risk Level: high
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Fixes #22449

waiting for @LithiumSR do a test on the fix.

@soulxu is this only an issue on 1.22?
if not we should probably land on main then backport to affected branches

@soulxu is this only an issue on 1.22?
if not we should probably land on main then backport to affected branches

Got it, thanks. This should be fix on main also, I fix the 1.22 first for @LithiumSR do a test, if things go right, I will fix main first

/retest

/wait

This isn't right fix, try another fix https://github.com/envoyproxy/envoy/pull/22616


Add a "Swap Herb clean/use" option to MenuEntrySwapper

I greatly enjoy doing herb runs, but doing them on a laptop without a mouse is sometimes frustrating. I don't clean my herbs before noting them, and with my touchpad, it's easy to accidentally left click on a herb and start cleaning them when I meant to right click.
The simple solution to this is to have a MenuEntrySwapper toggle that would swap the Clean and Use option on grimy herbs, making the left click on ALL herbs Use. There's already precedent for this with the MenuEntrySwapper toggle that swaps Bury and Use for bones.
The alternative offered by other RuneLite contributors has been to use the configurable shift click option to set the shift click of grimy herbs to be Use. However, in my opinion this is not a solution for several reasons:

It adds an additional step to using a herb on something (pressing down shift).
It forces the use of a second hand.
Still allows for the possibility of accidentally cleaning herbs by forgetting to press down shift.
It's not feasible to somehow lock shift down, since this interferes with other RuneLite functionality (e.g. using right click to move the camera, since shift right click is used for marking tiles).

Many requests for this feature have been opened in the past, showing there is a clear desire for it among users. If a toggle for swapping Bury and Use on bones can be included (which is arguably a much more powerful and significant toggle, as it greatly speeds up offering bones at the dangerous chaos altar), I don't see why a swap for Clean and Use on herbs can't be included.

Duplicate of #10159
Duplicate of #6049
Using the bone swap as a precedent isn't a good idea, since we only added that for parity with OSB. As we've said with basically every item swap added in the last few years: just use Shift Click. Also, just clean all your herbs when doing a farm run? Takes barely any time, and you can make them into potions later faster.
Also also, it's really bad form to make an issue just to make a PR directly after, especially when it's a duplicate issue


CSAD enhancements

Split the ORP sensor out to it's own entity
Add a number entity for adjusting ORP with a range between 400-900 in increments of 10
@jplivingston08 can you respond to this issue and attach the diagnostic data from the integration?

Sure !! I think the item you would be looking for is 700
I have mine set to 700 and when i change it, it changes that spot in the diagnostics.
config_entry-omnilogic_local-15eafe02fff8a6619f654171297c0a96.json
Also, Occasionally the acid feeder will timeout and require you to clear the alert for it to start again.  Mine has only done it once this year.  The next time it does it, i will wait to clear it so that maybe we can figure out which item it is in the data to potentially clear it.

@SelfSufficient08 whenever you get that alert, feel free to open up an issue and attach the diagnostics data!

One question, if I don't use ORP to control my Salt cell, the Hayward app doesn't show me the ORP reading at all. I do still see the value for it in this component though. It seems to be accurate, is there any way to confirm?


ishmahajanbhanu<EMAIL_ADDRESS>

Hexagonal architecture

closing the pull request immediately as suggested


Add examples

@ruscoder can you review my examples ?

@ruscoder Add our .jscsrc to the project and let @ir4y check your PR. Many code style errors.

@temrdm thank you!
It's a great suggestion.

I have added .jscs and linted all project files.


Macd Signal

How to obtain the macd signal?
In the tests, one can only obtain the macd and macd histogram values
package techan

import (
	"testing"

	"github.com/stretchr/testify/assert"
)

func TestNewMACDIndicator(t *testing.T) {
	series := randomTimeSeries(100)

	macd := NewMACDIndicator(NewClosePriceIndicator(series), 12, 26)

	assert.NotNil(t, macd)
}

func TestNewMACDHistogramIndicator(t *testing.T) {
	series := randomTimeSeries(100)

	macd := NewMACDIndicator(NewClosePriceIndicator(series), 12, 26)
	macdHistogram := NewMACDHistogramIndicator(macd, 9)

	assert.NotNil(t, macdHistogram)
}

Any thoughts ?

The signal-line is usually the 9-day EMA of the MACD. So to obtain the signal indicator, you can do the following:
macd := NewMACDIndicator(NewClosePriceIndicator(series), 12, 26)
signal := NewEMAIndicator(macd, 9)


For the RuneWatch plugin, how do I log in to my Imgur for the runewatch plugin to send the trade screenshots to my imgur?

For the RuneWatch plugin, how do I log in to my Imgur for the runewatch plugin to send the trade screenshots to my imgur?  Sorta new to github don't know how to dm someone lol

No need for DMs on github, you're using it correctly!
As for uploading to a private account, I'm currently using the imgur feature baked into RuneLite, so when they support custom API keys this plugin will also support custom imgur accounts.
I haven't looked into it yet, but if it seems simple I might give it a go in the RuneLite codebase.
Thread to watch/subscribe to:
https://github.com/runelite/runelite/issues/2120

So how do I receive my images on RuneLite's imgur? Where are they located?

When a screenshot is taken it's uploaded to Imgur and the URL of the image is saved to your clipboard to be able to paste.


Update to latest dependencies

Thanks @dineshmm23 for the PR and Effort.
I have merged the same.
Thanks
</ Pranav >


how to use in multi so or dll

a.so export  class A
lua require b.so have interface param 1 is A
how to get a point if use kaguya::get_pointer(L, nIndex, kaguya::types::typetag());
the metatable_name_key is not same so it will fail

so i suggest metatable_name_key and metatable_type_table_key use fix address

Thank you for the report.

when use kaguya::get_pointer(L, nIndex, kaguya::types::typetag());
the type_info compare is not same。so get the object is nullptr
how to solve?


espanso-pre: Add version 2.1.4-beta

Relates to #422

I made two manifests for alpha and beta, alternatively we could have one 'pre-release' manifest that switches to whichever is latest?

[x] I have read the Contributing Guide.

/verify

Don't know why the tests are failing, I removed the trailing whitespace :(

alternatively we could have one 'pre-release' manifest that switches to whichever is latest?

This is preferable

/verify

/verify


App should use OpenTracing API

getForwardHeaders pulls the raw Jaeger headers. It should use OpenTracing API.

ping @linsun


fix: export event selector and replace function selector with event selector where appropriate

Addresses #7089

Benchmark results
Metrics with a significant change:

avm_simulation_time_ms (Token:transfer_public): 36.0 (-30%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-init): 484 (-19%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_30_ms
11,517
3,087 (-2%)
1,547 (-12%)
1,585 (+10%)
1,569 (+7%)

proof_construction_time_sha256_100_ms
45,423
12,229
5,657 (-4%)
5,564 (-2%)
5,525

proof_construction_time_poseidon_hash_ms
79.0
34.0
34.0
58.0
87.0

proof_construction_time_poseidon_hash_30_ms
1,537
423
203
230 (-3%)
266

proof_construction_time_poseidon_hash_100_ms
5,810
1,592
731 (-1%)
765 (-6%)
806 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,476
9,462
9,476

l1_rollup_execution_gas
610,297
610,283
610,297

l2_block_processing_time_in_ms
751
1,398 (-1%)
2,676 (-1%)

l2_block_building_time_in_ms
25,422
51,015
99,784

l2_block_rollup_simulation_time_in_ms
25,328
50,711
99,432

l2_block_public_tx_process_time_in_ms
21,764
46,937
95,712

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,927 (-1%)
9,761 (-1%)

node_database_size_in_bytes
12,165,200
16,015,440

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
68.0
13,873

GasToken:set_portal
16.7
3,495

Token:constructor
93.6
24,207

FPC:constructor
61.8
13,893

GasToken:mint_public
51.8 (-2%)
10,241

Token:mint_public
609 (+3%)
19,216

Token:assert_minter_and_mint
80.0 (+8%)
13,034

AuthRegistry:set_authorized
33.0
7,869

FPC:prepare_fee
155 (+3%)
15,187

Token:transfer_public
:warning: 36.0 (-30%)
31,425

FPC:pay_refund
155 (+17%)
20,080

Benchmarking:increment_balance
2,678 (-1%)
15,465

Token:_increase_public_balance
56.2 (-1%)
15,089

FPC:pay_refund_with_shielded_rebate
150
21,167

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.181 (-1%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3
16.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.595
0.512
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
48.4 (+1%)
76.8 (+1%)
131
244 (-1%)
471

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.493 (+1%)
0.472 (+1%)
0.450
0.443
0.441

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.5 (+1%)
112 (+1%)
181
350 (-1%)
687 (-1%)

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.504 (+1%)
0.504 (+1%)
0.482
0.474 (-1%)
0.473

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.5
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.517
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
85,672
670,983

Transaction size based on fee payment method
| Metric |  |
| - |  |


Add support for timeofday column type and allow javascript types as draw options

Visualizations like the AnnotatedTimeline require a Date as one of the options (zoomStartTime, zoomEndTime). I have created a DataCell class to deal with formatting the value to the object that google expects and that class is used to format the values sent to the draw options and the DataTable values.
This pull also adds support for the timeofday type which is returned when a Time object is provided.

Thanks Christopher, I'll see about getting this merged in soon


extend sdk with dedicated host operations

Extend create cluster to accept a dedicated host pool ID
Extend create worker pool to accept a dedicated host pool ID
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/vpcCreateWorkerPool
Ensure get worker pool output details dedicated host pool ID
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/getWorkerPool
Ensure get worker output details dedicated host pool ID and dedicated host ID
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/getWorker
Create Dedicated hostpool api client w/ CR(U)D operations as per our API spec
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/createDedicatedHostPool
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/getDedicatedHostPool
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/removeDedicatedHostPool
Create Dedicated host api client w/ CR(U)D operations as per our API spec
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/createDedicatedHost
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/getDedicatedHost
https://containers.cloud.ibm.com/global/swagger-global-api/#/v2/removeDedicatedHost

example execution logs:
$ CreateDedicatedHostPool % go run main.go -flavorclass bx2d -metro dal -name tf-dhostpool
...
Create dedicated hostpool response: {<dedicated host pool id>}

$ ibmcloud ks dedicated pool ls
ID                        Name                        Metro   Flavor Class   Hosts   State
...
<dedicated host pool id>   tf-dhostpool                dal     bx2d           0       created

$ CreateDedicatedHost % go run main.go -flavor bx2d.host.152x608 -zone us-south-1 -hostpoolid <dedicated host pool id>
...
Create dedicated host response: {<dedicated host id>}

$ ibmcloud ks dedicated host ls --pool <dedicated host pool id>
ID                    Zone         Flavor              CPU Capacity   CPU Allocation   State            Status                           Placement
<dedicated host id>   us-south-1   bx2d.host.152x608   152            0                create_pending   Registering the dedicated host   yes

$ UpdateDedicatedHostPlacement % go run main.go -hostpoolid <dedicated host pool id> -hostid <dedicated host id>
...
DisableDedicatedHostPlacement was successful

$ ibmcloud ks dedicated host ls --pool <dedicated host pool id>
ID                    Zone         Flavor              CPU Capacity   CPU Allocation   State     Status                                 Placement
<dedicated host id>   us-south-1   bx2d.host.152x608   152            0                created   Disable placement request successful   no

$ UpdateDedicatedHostPlacement % go run main.go -hostpoolid <dedicated host pool id> -hostid <dedicated host id> -enableplacement
...
EnableDedicatedHostPlacement was successful

$ ibmcloud ks dedicated host ls --pool <dedicated host pool id>
ID                    Zone         Flavor              CPU Capacity   CPU Allocation   State     Status                                Placement
<dedicated host id>   us-south-1   bx2d.host.152x608   152            0                created   Enable placement request successful   yes

$ CreateCluster % go run main.go -vpcid <vpc id> -subnetid <subnet id> -name tf-dhosttest -hostpoolid <dedicated host pool id>
...
out= {<cluster id>}

$ ibmcloud ks dedicated host ls --pool <dedicated host pool id>
ID                    Zone         Flavor              CPU Capacity   CPU Allocation   State     Status                                Placement
<dedicated host id>   us-south-1   bx2d.host.152x608   152            16               created   Enable placement request successful   yes

$ DeleteDedicatedHost % go run main.go -hostpoolid <dedicated host pool id> -hostid <dedicated host id>
Remove dedicated host was successful

$ ibmcloud ks dedicated host ls --pool <dedicated host pool id>
ID                    Zone         Flavor              CPU Capacity   CPU Allocation   State      Status                        Placement
<dedicated host id>   us-south-1   bx2d.host.152x608   152            0                deleting   Deleting the dedicated host   no

$ DeleteDedicatedHostPool % go run main.go -hostpoolid <dedicated host pool id>
...
Remove dedicated hostpool was successful

$ ibmcloud ks dedicated pool ls
ID                        Name                  Metro   Flavor Class   Hosts   State
...
<dedicated host pool id>   tf-dhostpool    dal     bx2d           0       deleting

$ ListDedicatedHostFlavors % go run main.go -zone us-south-1
...
ListDedicatedHostFlavors was successful: [{bx2d.host.152x608 bx2d us-south us-south-1 false 152 0 [{2 3200}]}]

Fix the conflcit also


SQLServer system table 'master..sysprocesses' cannot be parsed

Input data
SELECT es.TOTAL_ELAPSED_TIME FROM master..sysprocesses as prs left outer join sys.dm_exec_sessions as es on prs.spid = es.session_id where spid = 62

Expected Output
SELECT es.total_elapsed_time
FROM   master..sysprocesses AS prs
       LEFT OUTER JOIN sys.dm_exec_sessions AS es
                    ON prs.spid = es.session_id
WHERE  spid = 62

Actual Output
An Unexpected Error Occurred
Parse error at token: . at line 1 column 42 Unexpected DOT token: {"type":"DOT","raw":".","text":".","start":41}. Instead, I was expecting to see one of the following: A LINE_COMMENT token based on: comment → ● %LINE_COMMENT _$ebnf$1 → _$ebnf$1 ● comment _ → ● _$ebnf$1 property_access → atomic_expression _ %DOT ● _ property_access$subexpression$1 atomic_expression$subexpression$1 → ● property_access atomic_expression → ● atomic_expression$subexpression$1 asteriskless_andless_expression$subexpression$1 → ● atomic_expression asteriskless_andless_expression → ● asteriskless_andless_expression$subexpression$1 asteriskless_free_form_sql$subexpression$1 → ● asteriskless_andless_expression asteriskless_free_form_sql → ● asteriskless_free_form_sql$subexpression$1 free_form_sql$subexpression$1 → ● asteriskless_free_form_sql free_form_sql → ● free_form_sql$subexpression$1 other_clause$ebnf$1 → other_clause$ebnf$1 ● free_form_sql other_clause → %RESERVED_CLAUSE ● other_clause$ebnf$1 clause$subexpression$1 → ● other_clause clause → ● clause$subexpression$1 expressions_or_clauses$ebnf$2 → expressions_or_clauses$ebnf$2 ● clause expressions_or_clauses → expressions_or_clauses$ebnf$1 ● expressions_or_clauses$ebnf$2 statement → ● expressions_or_clauses statement$subexpression$1 main$ebnf$1 → main$ebnf$1 ● statement main → ● main$ebnf$1 A BLOCK_COMMENT token based on: comment → ● %BLOCK_COMMENT _$ebnf$1 → _$ebnf$1 ● comment _ → ● _$ebnf$1 property_access → atomic_expression _ %DOT ● _
...

Usage

How are you calling / using the library?

import { format } from 'sql-formatter';
format(text, { language: 'sql' })

What SQL language(s) does this apply to?
SQLServer

Which SQL Formatter version are you using?
14.0.0

Thanks for reporting.
Can you point me to any resources that document this .. syntax in SQLServer?
I know of similar syntax in BigQuery, but there one can only use it inside quoted table names like `project..dataset....table` where the repeated . is simply treated the same as single .. Does the SQLServer also simply allow repeated .. instead of just ., or does the multi-dot syntax have some special meaning?

Thanks for reporting.
Can you point me to any resources that document this .. syntax in SQLServer?
I know of similar syntax in BigQuery, but there one can only use it inside quoted table names like `project..dataset....table` where the repeated . is simply treated the same as single .. Does the SQLServer also simply allow repeated .. instead of just ., or does the multi-dot syntax have some special meaning?

master..sysprocesses is a shorthand for the [database_name].[schema_name].[object_name] format. I apologize, as I am also not clear on where this syntax is located in the official documentation, but it is indeed legal in SQL Server.

Fixed in 15.1.0 release.


user State is not getting maintained between browser tabs

Using the example I have configured my userManger, store, and HomePage but the issue with private routing I have enabled it by adding an additional reducer. If the user is logged in one tab when trying to invoke another tab directly bypassing the URL path application is redirecting back to the login page instead it should go the specified path and also in the session storage user object is not getting persisted so I am unable to secure my app
Here is my store file

And added an additional reducer for managing the authenticated state

Here is my privaterouter.tsx which allows only authenticated users

@maxmantz  Can you please help me out as the user state in the new tab is not loaded even the user is logged in another tab, couldn't figure out whats the root cause

oidc-client-js stores session information in session storage, not local storage. Session storage is per tab. This is an except from the oidc-client-js config documentation on how to use local storage.
userStore: (default: session storage): Storage object used to persist User for currently authenticated user.
E.g. userStore: new WebStorageStateStore({ store: window.localStorage })

Thank you, now I am using localStorage for my user store that resolved my issue.


[FEATURE] Multi-server permissions

Let me explain the feature. For example you have 3 servers - Survival, Creative and Hub - connected with BungeeCord (all of them are hooked up with a single MySQL database). But for example, I want to give people /give in Creative, but not In Survival. It would be nice to have that sort of feature in PEX (correct me if feature already exists)

You can do this with per world permissions and world inheritance. Per world currently isn't working in 1.9 though. Additionally, you have to do a /pex reload on each server after the change.. It's kind of implemented and kind of not.

I'm here for the same idea so ... i explain :
Currently I have some servers and that's work with grade and group's sames databases for each servers but different permission's database for each kind of server ( bedwar, mobarena, ... ).
So what's the problem ?
If I want add global perm ( like new group prefix ) I must change it on every server.
Already tried the philip'ulrich's idea who's the opposite of mine.
And now what's the problem ?
Like he said "Per world currently isn't working in 1.9 though. Additionally, you have to do a /pex reload on each server after the change.." when we have only 1 world per server that's the only problem but when we have 5 worlds in a server we need to add 5 times permissions per server :/
My idea ?
Add a 4's table database like a "global database" like this we put each kind of server with 3 sames tables ( rank, group and global_permission ) and a personal permission's file.
Can also add a scheduler to reload global database each 10 minutes ( can edit in config file )
If you could that's will be great :)
Thanks.

@dracnis you don't have to do the permission adding 5 times. Just do world inheritance and send them all to a parent world where you have the permissions.
I can't speak for the devs, but it seems like they are leaving 1.x to die and solely working on 2.0. If you are trying to get them to implement new things into 1.x, I don't think they are going to do it.
I just switched to PowerfulPerms and it meets all my needs perfectly. You might consider looking into that.

Yeah, 2.0 supports per-server permissions (and it would be way more complicated to implement per-server permissions on 1.x since it's not designed around anything but per-world permissions). Additionally, 2.0 is very close to having SQL support (as in it's implemented but performance tweaks are still in progress), so we're getting pretty close to 1.x users being able to do everything they want to in 2.x.

@zml2008 How do I download PEX 2.0?

From https://ci.yawk.at/job/PermissionsEx -- keep in mind the command structure is entirely different and documentation is a bit limited at this point though.

Where is the documentation?

https://github.com/PEXPlugins/PermissionsEx/tree/master/doc
On 04/15/2016 11:22 AM, DoNotSpamPls wrote:

Where is the documentation?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/PEXPlugins/PermissionsEx/issues/2390#issuecomment-210575696

Sorry for the many questions, but how do I connect the plugin with MySQL?

That's not yet implemented in 2.0 (and is in fact what I am working on
right now (aka each time you ask a question I switch away from finishing
up the implementation))
On 04/15/2016 12:22 PM, DoNotSpamPls wrote:

Sorry for the many questions, but how do I connect the plugin with MySQL?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/PEXPlugins/PermissionsEx/issues/2390#issuecomment-210605665

Oh, sorry :(. I will wait


Empty email views will no longer send attachment

Laravel Version: 5.6.12
PHP Version: 7.1
Database Driver & Version: Mysql 5.7

Description:
attaching an existing pdf file to an empty email, no longer shows the attachment. Mailtrap will show it as raw text with no attachment, apple mail shows nothing.
Putting anything in the email view will allow the attachment. However this conflicts with the api of some email fax services which need an empty email with a pdf attachment. This worked as of 5.5.37
Steps To Reproduce:
Controller:
// token is just a field to secure a private file on a public drive for the few seconds this file is available and has no bearing.

Mail::to($email)->send(new EmailPdfAttachment($this->token,$this->subject));

Laravel 5.6 mailable EmailPdfAttachment.php
namespace App\Mail;

use Illuminate\Bus\Queueable;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

class EmailPdfAttachment extends Mailable
{
    use Queueable, SerializesModels;

    public $token;
    public $subject;

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct($token,$subject)
    {
        $this->token = $token;
        $this->subject = $subject;

    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->view('emails.empty.single')
            ->attach('storage/'.$this->token.'/output.pdf',['mime' => 'application/pdf'])
            ->subject($this->subject);
    }
}

View emails/empty/single.blade.php

// this was just an empty file, which worked perfectly in 5.5.37, after a half a day i added the
// follwing text and now it works, but it has the text attach a pdf.

attach a pdf

Here is screen shot from email

It's too clever and whitespace won't fool it.
The same code will run in laravel 5.5.x
Cheers,
please let me know if there is anything else I can do to help fix this.

I think Laravel is using Swiftmailer for sending emails, maybe test a couple of versions of swiftmailer if it triggers the same error?

Sure, I’ll look into it, the only change on our end was the shift from laravel 5.5 to 5.6 but I’m sure that many of the dependency versions were bumped. I’ll restore an older version to check. But if there is a way to make it work with the current technology stack that’s always preferable.
Sent from my iPhone

On Mar 17, 2018, at 4:10 PM, M. Vugteveen<EMAIL_ADDRESS>wrote:
I think Laravel is using Swiftmailer for sending emails, maybe test a couple of versions of swiftmailer if it triggers the same error?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I just experienced this same issue.
I had been using mandrill and attaching PDFs successfully in v5.5 and just upgraded to 5.6 yesterday.
I have a view that I use as a dummy view so that the mailable will send without any errors — my actual templates are in MailChimp and set via the X-MC-Template header.
I added just an HTML comment to my dummy view and attachments now work as expected.

Thanks for the comment, I’d like to go back and test that, I know the single character in my case was being parsed by the external service and I ended up just downgrading to not add hours to the project. But that’s seems like a great idea!

Hmm I see your point but you could argue that this is standard behavior and you would have to be explicit about any content you place in the email. Since this is more a behavioral change if we would have to add some sort of dummy comment if an email was empty I suggest to open up an issue at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework.


better logger that includes filename and line

I enhanced the logger to include filename and line. What do you think?

Looks good to me. Just need to fix the lint issues and then we're good to go!


Improved error message when trying to update static leaves

Hey Patrick, I've been playing around with the idea of enabling the updating of static leaves in my downstream library (details here if you want to look).
Long story short making this safer requires catching the empty AssertionError that is thrown here. I want to make this more robust by checking for the specific error message to ensure other errors aren't accidentally caught. Another possibility could be to raise a custom StaticLeaf error or something like that.
Here a minimal example:
import equinox as eqx

class Foo(eqx.Module):
    bar : str = eqx.field(static=True)

    def __init__(self):
        self.bar = 'baz'

eqx.tree_at(lambda tree: tree.bar, Foo(), 'new_baz')

which throws the empty AssertionError.
I was thinking something simple for the error message like "Static leaves can not be updated", but there might be some other cases that this is catching that I'm unaware of.
Anyway let me know what you think, I'm happy to do the PR for this.
Thanks as always for your help!

Yeah, using tree_at to update something that isn't even part of the pytree isn't defined. It's like trying to change a method on a dictionary: eqx.tree_at(lambda d: d.get, dict(), None).
I agree we could make the error message clearer. I'd be happy to take a PR on this.

Fixed in #460.


ADOPTERS.md dp phase update

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Thanks, @liyangbing !

/lgtm
/approve


request: responsive

Any plans on making the modal responsive?

Not currently, but happy to look at a PR

FYI, I did this in a project to make sure the calendar is fixed at the approximated center of the screen on mobile devices :
Add this class fullscreen-when-on-mobile to your datepicker instance (using the wrapper-class prop).
And add this style somewhere (SASS) :
.vdp-datepicker {
    &.fullscreen-when-on-mobile {
        @media (max-width: 767px) {
            position: static;
            .vdp-datepicker__calendar {
                position: fixed;
                top: 50%;
                left: 5%;
                margin-top: -25%;
                width: 90%;
            }
        }
    }
}

Hope it helps ! :slightly_smiling_face:

my 2 cents... I added an overlay using outline, easy, and effective:
        z-index: 2000; outline: rgba(0, 0, 0, 0.5) solid 9999px;
so, full CSS will be:
.vdp-datepicker {   &.fullscreen-when-on-mobile {     @media (max-width: 767px) {       position: static;       .vdp-datepicker__calendar {         position: fixed;         top: 50%;         left: 5%;         margin-top: -25%;         width: 90%;         z-index: 2000;         outline: rgba(0, 0, 0, 0.5) solid 9999px;       }     }   } }


Deprecation warning thrown when building project with ember-cli

ember-cli version is 1.13.6
ember version is 1.13.7
DEPRECATION: Using the '{{#each item in model}}' form of the {{#each}} helper ('px-web-client/templates/components/object-bin.hbs' @ L5:C2) is deprecated. Please use the block param form instead ('{{#each model as |item|}}'). See http://emberjs.com/guides/deprecations/#toc_code-in-code-syntax-for-code-each-code for more details.

I was on holidays last week, but I have a branch free of deprecations ready to be released. You should see a new release this week that fixes this and many other issues.

Version 0.1.6 has been published and addresses this.