 Be sure to warn European users of this issue.
ISSUE-2: even with language on English, my medtronic export uses "," instead of "." as a seperator for real values. E.g. RATE=0,9 instead of RATE=0.9.
BasalProfileStart,"PATTERN_NAME=standard, PROFILE_INDEX=0, RATE=0,9, START_TIME=0, ACTION_REQUESTOR=pump"
ISSUE-3: Unfortuately, when I fix this in the input csv file (regexp in VI :%s/([A-Z_][A-Z])=([-0-9][0-9]),([-0-9][0-9]* )/\1=\2.\3/g) I still encounter problems, such as:
CareLink CLI: Loading CareLink CSV...
No local session found
POST /auth/login
Session saved
CareLink CLI: Loading using the timezone CET
CareLink CLI: Loading for user  xxx
CareLink CLI: Reading /xxx/CareLink-Export-test-uk.csv
CareLink CLI: Error processing CareLink data: { [TypeError: Cannot read property 'start' of undefined] step: 'processData' }
TypeError: Cannot read property 'start' of undefined
at processParts (/home/xxx/tidepool-org/chrome-uploader/lib/carelink/carelinkSimulator.js:221:38)
at pushBasalClockForward (/home/xxx/tidepool-org/chrome-uploader/lib/carelink/carelinkSimulator.js:299:14)
at Object.basalScheduled (/home/xxx/tidepool-org/chrome-uploader/lib/carelink/carelinkSimulator.js:366:7)
at Array.3 (/home/xxx/tidepool-org/chrome-uploader/lib/carelink/basal.js:60:21)
at /home/pieterb/tidepool-org/chrome-uploader/lib/drivers/carelinkDriver.js:331:28
at Array.forEach (native)
at Object.processData (/home/xxx/tidepool-org/chrome-uploader/lib/drivers/carelinkDriver.js:323:38)
at processData (/home/xxx/tidepool-org/chrome-uploader/lib/driverManager.js:135:16)
at fn (/home/pieterb/tidepool-org/chrome-uploader/node_modules/async/lib/async.js:641:34)
at Object._onImmediate (/home/xxx/tidepool-org/chrome-uploader/node_modules/async/lib/async.js:557:34)
Any clue how to fix this?

@PieterGit unfortunately at the moment we don't have the resources to work on international support for CareLink. However, we absolutely welcome pull requests from the open-source community to this end. Our dream is to be completely international one day!
As to debugging this particular processing issue, it looks like an issue with the basal processing, but I can't tell much more without seeing the raw data. If this is an older Medtronic pump - 522/722 or below - there could be substantial issues; we don't fully support those older pumps, as there are significant differences in the CSV data, particular with respect to the basals.
Filed on Trello here.


Can't bind remain::sorted to a different name

Hey there,
I was trying out the proc-macro-workshop for #[sorted], and while coding it I thought of the following edge case (thanks for the awesome intro to macros btw!):
use remain::sorted as blah;

#[remain::check]
fn main() {
    let x = Some(3);
    #[blah]
    match x {
        None => {}
        Some(_) => {}
    }
}

The above code won't compile, I get the following error:
error[E0658]: attributes on expressions are experimental
 --> src/main.rs:6:5
  |
6 |     #[blah]
  |     ^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/15701

error[E0658]: custom attributes cannot be applied to expressions
 --> src/main.rs:6:5
  |
6 |     #[blah]
  |     ^^^^^^^
  |
  = note: for more information, see https://github.com/rust-lang/rust/issues/54727

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0658`.

I think this is because the code here relies on the value of the path being either "sorted" or "remain :: sorted".
I assume the same would be true about the "unsorted" attribute.
This seems to show that relying on the imported attribute having a specific name may not be a good idea when developing a proc macro, since the user can bind it with a different name.
Is there a way to work around this (not that it's important)? If not, this may need to be highlighted in the documentation as being a limitation?

Hum actually this may just be a non-issue; when using:
use remain::sorted as blah;

We're actually just renaming the proc macro attribute that is applied on methods, not what users rely on.
This code is still valid, it just has an unused import:
use remain::sorted as blah;

#[remain::check]
fn main() {
    let x = Some(3);
    #[sorted]
    match x {
        None => {}
        Some(_) => {}
    }
}

On nightly, this code runs perfectly fine:
#![feature(proc_macro_hygiene, stmt_expr_attributes)]

use remain::sorted as blah;

fn main() {
    let x = Some(3);
    #[blah]
    match x {
        None => {}
        Some(_) => {}
    }
}

Sorry for the confusion, feel free to close the issue!

Yeah I think this is fine as is.


Request to Add to Wiki: Quickstart - Raspberry Pi 4b

Hi there,
I have written up a quickstart guide for users on Raspberry Pi 4b. I was unable to commit directly to the wiki git repository due to permissioning.
Here is the article. I would also suggest adding a section for quickstarts in the home page of the wiki.
======== start article ===========
Overview
This is a quickstart to get a hello world application (the default flutter counter app) running on Raspberry Pi 4b.
Requirements

Raspberry Pi 4B (not tested on other boards)
HEADLESS Raspbian 64bit (bullseye release 11)
HDMI display

Quickstart
Use Raspberry Pi Imager tool to set up SD card.
# dependencies
$ ssh <user>@<hostname>
$ sudo apt install curl unzip git clang cmake pkg-config -y
$ sudo apt install libegl1-mesa libgles2-mesa libxkbcommon-dev -y
$ sudo apt install libdrm-dev libgbm-dev libinput-dev libudev-dev libsystemd-dev -y
$ sudo apt install build-essential libegl1-mesa-dev libgles2-mesa-dev

# I had to do this due to being in US locale: see [this issue](https://github.com/sony/flutter-embedded-linux/issues/387).
$ sudo cp /usr/share/X11/xkb/symbols/us /usr/share/X11/xkb/symbols/US

$ git clone https://github.com/sony/flutter-elinux.git
$ sudo mv flutter-elinux /opt/
# OR add below line to ~/.bashrc
$ export PATH=$PATH:/opt/flutter-elinux/bin
$ flutter-elinux doctor

# project creation & build
$ cd ~
$ flutter-elinux create helloworld
$ cd helloworld
$ flutter-elinux build elinux --debug --target-backend-type=gbm
$ cd build/elinux/arm64/debug/bundle/

# run
$ sudo FLUTTER_DRM_DEVICE=/dev/dri/card1 ./helloworld -b ~/helloworld/build/elinux/arm64/debug/bundle

Warning: this setup may change if in a different environment or a future version of Raspbian.
====== end article =========

Added https://github.com/sony/flutter-elinux/wiki/Quickstart-‐-Raspberry-Pi-4-Model-B. Thanks.


openbmc, supermicro: implement BMCResetter interface

What does this PR implement/change/remove?
This makes sure when the provider is pinned/filtered* the BmcReset method is available.

https://github.com/bmc-toolbox/bmclib#one-time-filtering

Checklist

[ ] Tests added
[ ] Similar commits squashed

The HW vendor this change applies to (if applicable)
OpenBMC firmware, Supermicros

rebased on main


efibootmgr needs separate disk and partition

efibootmgr needs a separate device (/dev/xxx) and partition number.

This should resolve #49


Replace Dash-specific threads with Dash-specific scheduled tasks

As pointed out in #2041, triggering various logic of multiple different submodules in a single (legacy) PrivateSend thread is confusing. Having few separate threads for each of them would probably make things a bit clearer but would be an overkill imo, so I'm proposing to utilise builtin scheduler for this instead - each submodule has DoMaintenance() and all of them are scheduled independently in one place in init.cpp now.

Please give me some time to review this tomorrow (didn't check the code at all yet). Not sure if it's a good idea to change threading related stuff so close to release ;)

Yep, I agree that it makes sense to postpone this one for some later release to avoid any unpredicted issues with lock order and such. Let's set 12.4 as a milestone for now.

Partially tested,  ACK

Fixed a couple of issues and rebased to solve merge conflicts, pls re-review.

@UdjinM6 Did you check if all maintenances are non-blocking and not too cpu intensive? Otherwise it might happen that other things get blocked/slow.

@codablock this PR just reorganises things by replacing 3 ThreadCheckPrivateSend* threads with few separate module-specific DoMaintenance  functions which are executed in one single scheduler thread. It changes nothing in the underlying (locking) logic as far as I can tell, so I don't expect any changes in behaviour here.


Ionic 2 please add method Keyboard.shrinkView

Hello!!!
Please add Methods Keyboard.shrinkView!!!

+1


Update M0 USB examples

This is still a work in progress.
Building on the great updates from #125, I'm trying to get the M0 USB examples updated. So far I've got the Metro M0 example compiling but I don't have a Metro M0 to test with. I do have a couple other atsamd21 boards around that I'm planning to port the example to.
Extra sets of eyes on here would be great as I did a lot of copy-paste programming to get it in line with the M4 examples.

I'll let @keithduncan handle this one because he's the expert here.


Component - CTA - Keyboard - After activating the close icon in the model page, focus not set on the triggering element .

Detailed description
Issue :- After activating the close icon in the model page, focus not set on the triggering element .
Expected :-  Focus should set on the triggering element. Which is a folgers coffee link.

@kennylam Moving this to sprint 20-19, based on the discussions in Modany's engineering meeting

@kennylam Moving this sev 4 to next sprint

Re tested above bug, now Focus is set on the triggering element. Working fine.
@jeffchew cc @RobertaJHahn


Unique DeviceId

Have you read the FAQ and checked for duplicate open issues?: Yes
What version of Shaka Player are you using?: 2.4.2
Can you reproduce the issue with our latest release version?: Yes
Can you reproduce the issue with the latest code from master?: Yes
Are you using the demo app or your own custom app?: Both
If custom app, can you reproduce the issue using our demo app?: not applicable
What browser and OS are you using?: Chrome on Windows 10
What are the manifest and license server URIs?: We don't need this to reproduce this issue
What did you do?
We whant to have à unique deviceId for chrome Browser nad firefox. Widevine advised me to activate these 2 attributes
config.drm.advanced = ({
'com.widevine.alpha': {
distinctiveIdentifierRequired: true,
persistentStateRequired: true,
},
});
But if do that, i have this error on shaka player
Shaka Error DRM.REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE ()
what is the solution ?
What did you expect to happen?
What actually happened?

Well, trying those configs out on our sample assets...
Narrowing it down, persistentStateRequired: true works, but distinctiveIdentifierRequired: true does not.
The REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE error is thrown if navigator.requestMediaKeySystemAccess fails for every DRM system.
Now, distinctiveIdentifierRequired: true from our config is translated into distinctiveIdentifier: "required" in the final config passed to navigator.requestMediaKeySystemAccess. It's possible that distinctiveIdentifier: "required" isn't supported anymore, or something. I'll bring this to the attention of the Widevine team.
In the meantime, does your asset play with just persistentStateRequired: true set?

I'have tested "persistentStateRequired: true", but we have some strange issue, If i try to play 10 lives content we have 4 failures, we have a black screen and no error on the console.
Do we need any think on the licence ?

Well, I can't say much more without having access to your content. You can send the information (manifest URI, license server URI, etc) to<EMAIL_ADDRESS>if you are able to distribute them.
If not, you could go to chrome://media-internals/ while playing in Chrome to see if the video element's log has any errors in it. If Shaka Player isn't showing any errors, there might be a problem somewhere in the media pipeline that we don't get to touch.

I tried to reproduce this on Chrome and Firefox on macOS for a while, and was unable to with either.
On a Windows 10 computer, on the other hand, the video was sometimes hanging forever without actually playing. The screen wasn't black, per se, but it might be what you were seeing.
Interestingly, I was getting media internal logs like this (key ID censored for privacy reasons):
00:00:02:103 DecryptingDemuxerStream: no key for key ID *KEYID*
00:00:02:103 DecryptingVideoDecoder: no key for key ID *KEYID*
00:00:02:854 DecryptingDemuxerStream: key was added, resuming decrypt
00:00:02:854 DecryptingVideoDecoder: key added, resuming decode
00:00:02:855 DecryptingDemuxerStream: no key for key ID *KEYID*
00:00:02:855 DecryptingVideoDecoder: no key for key ID *KEYID*

And then no other updates after that about the decoder or demuxer.
So the key is supposedly added, and then a millisecond later it's saying that there's no key for that key ID again? And then it just is hanging there, waiting for that key. I don't know how the CDM works well enough to say what's happening here; maybe it's getting a bad key or something.

The key was added log is printed whenever any keys are added, so what is likely happening is we are getting the wrong keys from the license server.  You should check the key status changed event to see what keys were added vs what keys we need.  Also you should check the expiration of the sessions to see if the session is expiring before we can use it.
@mjaddani I think that distinctive identifiers are only supported on Android which is why you are getting an error on desktop platforms.  I don't think there is a way to get unique IDs for desktop since the OS doesn't provide that info.  Unfortunately you'll need to use platform detection to determine if you are on Android and conditionally set that attribute.

When the playing failed, i'have all the time this.
00:00:00 691 | info | DecryptingDemuxerStream: no key for key ID XXXXXX
00:00:00 691 | info | DecryptingVideoDecoder: no key for key ID XXXXXX
00:00:00 224 | duration |<PHONE_NUMBER>
00:00:01 734 | info | DecryptingDemuxerStream: key was added, resuming decrypt
00:00:01 734 | info | DecryptingVideoDecoder: key added, resuming decode
00:00:01 734 | info | DecryptingDemuxerStream: no key for key ID XXXXXX
00:00:01 735 | info | DecryptingVideoDecoder: no key for key ID XXXXXX
I'have the same process on proxy server, the same key, and the duration session it's same all the time.

This case is like #1554
do you have analyse my content ?

It's not clear to me from the issue history what your problem is right now.  Can you please explain it again?  Also, can you please provide some content URLs so that we can reproduce your issue exactly?  Thanks!

No problem, We use a live content with widevine DRM.
If i use persistentStateRequired: true on shaka, most of the time the content works, but some times, shaka don't play the content and we have an error with Firefox and no error with Chrome but the content don't play.
On chrome,  we have this error on chrome://media-internals/
00:00:00 691 | info | DecryptingDemuxerStream: no key for key ID XXXXXX
00:00:00 691 | info | DecryptingVideoDecoder: no key for key ID XXXXXX
00:00:00 224 | duration |<PHONE_NUMBER>
00:00:01 734 | info | DecryptingDemuxerStream: key was added, resuming decrypt
00:00:01 734 | info | DecryptingVideoDecoder: key added, resuming decode
00:00:01 734 | info | DecryptingDemuxerStream: no key for key ID XXXXXX
00:00:01 735 | info | DecryptingVideoDecoder: no key for key ID XXXXXX

And for Firefox, we have this
{
"severity": 2,
"category": 3,
"code": 3016,
"data": [
3,
null,
"NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - class mozilla::ipc::IPCResult __cdecl mozilla::gmp::ChromiumCDMParent::RecvDecodeFailed(const unsigned int &): ChromiumCDMParent::RecvDecodeFailed"
],
"handled": false,
"message": "Shaka Error MEDIA.VIDEO_ERROR (3,,NS_ERROR_DOM_MEDIA_FATAL_ERR (0x806e0005) - class mozilla::ipc::IPCResult _cdecl mozilla::gmp::ChromiumCDMParent::RecvDecodeFailed(const unsigned int &): ChromiumCDMParent::RecvDecodeFailed)",
"stack": "shaka.util.Error@******/lib/util/error.js:88:13\nshaka.Player.prototype.onVideoError@*****/lib/player.js:3114:17\n"
}

But if i disable persistentStateRequired: false, we don't have any error. We send the same widevine licence, with the same id.
I send you email to reproduct that

@mjaddani If I understand correctly, you are looking for a way to track device ids for Chrome and Firefox. Are you looking to track this in the license requests?
When you say "Widevine advised me to activate these 2 attributes", where did you get that instruction from?

Yes we want to track device Id to do a restriction, we use persistentStateRequired: true, and we use provider_client_token on widevine licence.
It's Widevine engeneer who has give me this  advice.

So Shaka Player is part of Widevine - who in Widevine have you been talking to? We can touch base with them to figure out both ends of this issue because I suspect most of this is license based as the player has no actual control over the CDM.

On Widevine DRM Proxy documentation, we have this,
Client token to send back in the license response.  If
the license request contains a client token, this value
is ignored. The client token will persist beyond license
sessions.
provider_client_token is only supported in the Chrome
CDM and persistentState must be enabled by the Application.

My Widevine contact is Prashant Grover. Also I have met Joey Parrish in London as part of Widevine training

I have reached out to Prashant Grover and will figure out what he is suggesting you do. I will assign this to myself so that we don't lose track of it.

My need is to be able to have a device id

After talking this over with Prashant, he said his original instructions would have been:

Specify Provider Client Token on your proxy.
Set distinctiveIdentifierRequired and persistentStateRequired in the player.

As you pointed out,

provider_client_token is only supported in the Chrome CDM and persistentState must be enabled by the Application.

For distinctive identifier to work, the CDM must be willing to provide one, that is why we query for it. If the configuration cannot be fulfilled (REQUESTED_KEY_SYSTEM_CONFIG_UNAVAILABLE) there is nothing we can do, the EME specs even say,

Implementations that use Distinctive Identifier(s) or Distinctive Permanent Identifier(s) should support the option to not use them.

And it even recomends against their use (source).
So @mjaddani, with all that said, unless a platform is willing to give you distinctive identifiers, there is no way to force it.

Thanks @vaage , but for the Android Device, we have solution. My point is for Chrome and Firefox, the advise it's to use persistentStateRequired=true and Widevine Proxy set the param provider_client_token with a device Id. This advise work but sometimes I have some mistakes that I went back to above

Sorry not following-up sooner.  I believe this is a duplicate of #1554, which has been fixed by Widevine and will appear at least in Chrome 71, maybe sooner.  It was also fixed on the CDM side, so it should appear in Firefox too, although I don't know when.


Fetch libs from google

Fixes the issue where gradle sync fails because it cannot recognize design and recyclerview libs.

Thank you


Merge for o365 & Workspace Update

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
v1.4.0

Your semantic-release bot :package::rocket:


feat: add host parameter

Adds host parameter to CLI
Fixes: https://github.com/contentful-userland/cf-content-types-generator/issues/312

@marcolink Validated by myself on a eu hosted plan, that this solution will fix #312 .


Missing parameters in SOAP to REST conversion

Description
HI Team,
There is an issue regarding SOAP to REST conversion[1] and you can follow the below steps to reproduce the issue.
[1] https://apim.docs.wso2.com/en/latest/integrate/develop/creating-artifacts/creating-an-api/#creating-the-api-artifact
Steps to Reproduce

Crete a Hello world project
Create a schema file(.xsd) with a complex type element

<xsd:element name="SAMPLE" minOccurs="0">
                <xsd:complexType>
                    <xsd:sequence>
                        <xsd:element name="PARAM" minOccurs="0" maxOccurs="unbounded">
                            <xsd:complexType>
                                <xsd:sequence>
                                    <xsd:element name="NAME" type="xsd:string" />
                                    <xsd:element name="VALUE" type="xsd:string" />
                                </xsd:sequence>
                            </xsd:complexType>
                        </xsd:element>
                    </xsd:sequence>
                </xsd:complexType>
            </xsd:element>

Set the correct location of the schema file in the wsdl file which needs to be converted.
Generate an API with this wsdl file(browse the wsdl file and import it to the ESB project).
Go to the generated API and search for the relevant resource.

Expected behaviour:

The SOAP service under PayloadFactory mediator should include all the configured parameters in the schema.

Current behaviour:

Some of the paramters are missing in the SOAP service in generated API

Affected Component
IntegrationStudio
Version
8.2.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

This issue has already been resolved in the master branch.


[GOBBLIN-1838] Introduce total count based completion watermark

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/GOBBLIN-1838

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

Currently the completion watermark is determined according to the completeness percentage: max of srcCount/refCount, for each refTier. This change introduces a new "total count based completion watermark", which is determined by a new completeness percentage: srcCount / sum of all refCount, for each refTier.
The new total count based watermark will be used to check the completeness of data which is aggregated from multiple tiers.

Tests

[ ] My PR adds the following unit tests:

KafkaAuditCountVerifierTest
IcebergMetadataWriterTest

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3701 (a435b57) into master (51a852d) will increase coverage by 7.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3701      +/-   ##
============================================
+ Coverage     46.97%   54.67%   +7.69%
+ Complexity    10794     1383    -9411
============================================
  Files          2138      278    -1860
  Lines         84132     9965   -74167
  Branches       9356     1078    -8278
============================================
- Hits          39518     5448   -34070
+ Misses        41015     4009   -37006
+ Partials       3599      508    -3091

see 1860 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Have option to specify gitops path where to place generated files

Description
Currently, gitops files get generated under a hardcoded prefix path of cloud, need a way to have a variable input for this
Related Issue
https://github.com/adobe/rules_gitops/issues/60
Motivation and Context
For repositories that do not want gitops files generated at cloud path, this change is needed
How Has This Been Tested?
Just started using this and verified that no gitops_path renders gitops files in usual cloud directory, while specifying path correctly changes the prefix path
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@arturo-skydio thank you for the contribution! mind signing the CLA?

@arturo-skydio thank you for the contribution! mind signing the CLA?

@michaelschiff I thought I did,
not sure if its because the change comes from our skydio org, maybe I should just try to open the PR from my gh account?

closed in favor of #62

@michaelschiff sorry, was a bit impatient with opening up the other PR, looks like the CLA is green now, thanks

Looks good overall. No issue with the change. But there are couple issues that need to be addressed before we can merge:

You might want to add another test case into the e2e_test. Right now we rely on cloud directory being default. For example you can add another k8s_deploy target alongside release and canary targets and update the script. Don't forget to update the .gitignore file too.
cloud also is hardcoded in couple places ( 1, 2 ) in the GitOps PRs tool.

Sounds good, thanks for taking a look, I'll add the test

@kzadorozhny Added a test for gitops_path and made sure to remove hardcoding in the Gitops Prs tool, let me know if all look good, thanks again


Cherry pick some release issue fixes from rc/1.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.85%. Comparing base (972d23d) to head (7eff171).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #296   +/-   ##
========================================
  Coverage    63.85%   63.85%
========================================
  Files          501      501
  Lines        31790    31790
  Branches      4112     4112
========================================
  Hits         20301    20301
  Misses       11012    11012
  Partials       477      477

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BUG]: crash with the last version of sodium beta

Does an issue already cover this?

[X] I have searched for any existing issues, and didn't find any.

Does your system support Faster Random?

[X] I have checked that my JVM supports Faster Random 3.0.0+.

Issue description.
.The new version of faster random is not compatiable on 1.21.1 with sodium beta.
Issue replication.
1- install sodium and faster random and it crashes on launch
Log File / Crash Report (if applicable)
crash-2024-11-04_19.38.15-client.txt

This isn't a bug with sodium, I think the wrong engine is being chosen in this case. I'll delist 6.0.0 and look into it later.

Sodium does not provide any crash. Could you please check if your JVM is headless, or try using a known working JVM?


how to install conpy by anaconda

when run 'pip install https://github.com/wmvanvliet/conpy/zipball/master',  i got a error:
File "C:\Users\ADMINI~1\AppData\Local\Temp\pip-5qdm7gdd-build\setup.py", line 17, in
long_description=open('README.md').read(),
UnicodeDecodeError: 'gbk' codec can't decode byte 0x93 in position 4882: illegal multibyte sequence
how to solve it?

That looks like a text encoding problem. Thanks for reporting. Let's see if we can debug this.
First, can you tell me which Python version you are using?

The problem about install may still unsolved.
After debuged, I can install the module of "conpy", but i got a warning when input "conpy.csd_epochs(epochs,frequencies, tmin =0, tmax = 0.4, decim = 20)", the warning is "module 'conpy' has no attribute 'csd_epochs'".
ps The Python version i used is 3.6.4.
<EMAIL_ADDRESS>From: Marijn van Vliet
Date: 2018-07-04 15:24
To: wmvanvliet/conpy
CC: Iv911; Author
Subject: Re: [wmvanvliet/conpy] how to install conpy by anaconda (#1)
I've change the offending line of code to make the text encoding explicit (0d72f50). Can you try it now?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

conpy no longer has a csd_epochs function. Please use mne.time_frequency.csd_morlet. See also the latest version of the preprint of the paper:
https://www.biorxiv.org/content/early/2018/01/16/245530

On 5 Jul 2018, at 13:15, Iv911<EMAIL_ADDRESS>wrote:
The problem about install may still unsolved.
After debuged, I can install the module of "conpy", but i got a warning when input "conpy.csd_epochs(epochs,frequencies, tmin =0, tmax = 0.4, decim = 20)", the warning is "module 'conpy' has no attribute 'csd_epochs'".
ps The Python version i used is 3.6.4.
<EMAIL_ADDRESS>From: Marijn van Vliet
Date: 2018-07-04 15:24
To: wmvanvliet/conpy
CC: Iv911; Author
Subject: Re: [wmvanvliet/conpy] how to install conpy by anaconda (#1)
I've change the offending line of code to make the text encoding explicit (0d72f50). Can you try it now?
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

conpy no longer has a csd_epochs function. Please use mne.time_frequency.csd_morlet. See also the latest version of the preprint of the paper:
https://www.biorxiv.org/content/early/2018/01/16/245530


Debugging gaussian scales for GNILC dust

I 've identified several issues in https://github.com/healpy/pysm/pull/72 that can lead into errors in the estimates.
I am using exactly  the same routines  and the same inputs used in https://github.com/healpy/pysm/pull/72  to further debug the procedure, the main difference is that i perform the estimates on GAL060 mask, instead of GAL080 ( in https://github.com/healpy/pysm/pull/72 )
Think a source of error can be related to the monopole subtraction :
Monopole subtraction
Estimate the monopole term from the map outside the galactic mask to have a rough estimate of the CIB monopole .
However, I  don't perform the monopole subtraction  before injecting small scales but  once the maps with Large and small scales are coadded together .
In fact, I noticed that:

doing it before transforming to logarithmic pol. tensor results in NaN regions in correspondence of (I^2 - P^2 )< 0  pixels
removing a monopole term in the pol.tensor transformed quantities $i,q,u$ is not correct as,  when we transform back to real quantities, the maps before and after transformation don't match anymore , one can easily understand it when you transform to real quantities a map with  i' with  a constant term  subtracted  i.e.
i' =i -c
and another map transformed from i .

Estimating the monopole at high Gal. latitudes (excluding the Gal. plane) leads to ~0.16 MJy/srad , which is very closed to the value reported by Section 2.2 of Planck 2018 XII value reported:  0.13 MJy/sr .

The argument against the unires maps is that treatment of polarization systematics in Planck evolved from the 2015 to the 2018 release. I wonder if that accounts for the qualitative differences we are seeing? Rather than use the unires QU maps, it may be worth investigating the NPIPE raw 353 GHz QU maps instead.

I addressed most of @zonca  comments on the notebooks, in particular :

subtracting the monopole term in the intensity map (not in the log pol tens transformed quantities)  with the value reported in Planck 2018
performing the whole analysis with the varres maps with the GAL080 mask apodized with 2 degree radius
namaster spectra
fit the power law at the ranges as in #72 , i.e. for TT ell =400-600, for EE and BB ell=30-110
I am not finding flat spectral indices , see the spectra below

The small scales are coadded  in the logpol tens maps and the namaster spectra are shown below

notice in particular the light green line ( with large scale only) and the orange line encoding spectra with gaussian small scales injected .
Finally, I transformed back the maps into real quantities and got reasonable power spectra (mild decrease in power in TT at ell>600)

gonna clean up a bit the notebook and commit it to this PR.

The argument against the unires maps is that treatment of polarization systematics in Planck evolved from the 2015 to the 2018 release. I wonder if that accounts for the qualitative differences we are seeing? Rather than use the unires QU maps, it may be worth investigating the NPIPE raw 353 GHz QU maps instead.

discussed with @keskitalo and we agreed that  this is something that can be surely done, although we have to deal with synchrotron and CMB residuals when using the NPIPE maps as those haven't been processed with component separation.

If everything is working for varres--and I think it looks really good!--no need to go to the NPIPE maps. Relieved to see those -0.5 spectra!

Notebook with varres maps  available at
https://gist.github.com/giuspugl/4fb30306e99dfed4a193c80fe9c3c94a

thanks @giuspugl! great progress, I am worried that the loss of power in TT (IQU) compared to Poltens could be caused by a bug somewhere.

Agreed, looking great @giuspugl ! Re: loss of power in TT: is there also a small knee in BB at the same ell?

I've digged a bit into the mismatch we discussed last week,  see the gist
https://gist.github.com/giuspugl/4fb30306e99dfed4a193c80fe9c3c94a
I am finding that the reason for  the mismatch  is mostly driven by the fact that the i map with large scales  in the logpol tensor formalism shows the largest contribution  when we transform back to IQU maps. I think we are hitting a limitation of this proposed formalism proposed, although i 'd like to stress that a by-product of this formalism is that the smaller scales even if simulated uniformly they present a modulation by the larger scales of the intensity maps.

If we simply let i = I does everything look ok, or are there other problems that fix doesn't address?

There is undoubtedly a nicer way to share this, but I've put together a little proof of concept here: https://www.dropbox.com/s/zl64y70bsouco99/polfractens.ipynb?dl=0
Given that this looks reasonable, the current thought is that there is a bug in the code joining the small and large scales in alm-space. Stay tuned.

Summary of the analysis performed so far
The  tests performed with @brandonshensley  are converging  to the fact that using a map with variable resolution (e.g. Planck 2015 I map)  can be the reason why we see a knee in the power spectra of real quantities as stated above by @seclark.
To further simplify the test we therefore proceeded by considering the Planck 2018 unires map which has the downside of being coarser in terms of resolution ,  80' , and of being less optimized in the removal of the CIB  but as a pro it has the  same resolution in each region of the sky.
We repeated the same procedure as outlined above and we restricted in particular to the case with P=0, i.e. i = log( I )
The procedure so far i used :

i = log(I)
run Namaster on 80% sky on the i  map
fit from the  Namaster  spectrum the power law to get the small scales ss map
get the large scale map with ls= Alm2map(almxfl(i,sigmoid))
I’ = exp(ls +ss)
we combine the maps ls and ss in step 5 but we can't combine ss and ls together as the two maps are estimated on different domains, the former    estimated by fitting the spectra estimated with namaster and the other  estimated from pseudo -alm . We fix this issue by running 2., 3. and 4. on fullsky quantities (i.e. using anafast) .

I map at 80'
We transform to the i map and estimate the power spectrum with anafast

With a lower reso, we have to restrict our fitting range in ell=30-100 .The spectral index of the fitted power law is -1.58.
A comparison on the map level of the maps with and without small scales injected by extrapolating the power law is shown below :

and the TT power spectrum estimated from the I' map (solid orange) , compared with the input I with 80' reso (solid blue). As you can see the spectra behave as expected.
Modulating small scales with a template map.
We now want to inject a modulation of the small scales similarly to what was done in the PySM2, since so far the amplitude is uniform across the sky.
We therefore :
a. smoothed the same I map used above to 5 deg,
b. take the log10,
c.  saturate to 2 all the pixels whose log10 value is >2.
d. Minmax rescale the map from 0.1 to 1 .
In this way we shrink  the dynamic range where we expect the scales to be modulated by the dust  intensity profile, A . Below the map produced following the steps from a-d .

Then we follow the steps from 1-5 and just changed the definition in 5.  as :  I’ = exp(ls +( A*ss ))
below you can see a direct comparison of the maps produced with the modulation defined above for a region at ~intermediate Gal. latitudes (same area as the one shown above)

Notice how the small scales now are dimmer in the vicinity  of low intensity regions and viceversa.
Finally, we want to check whether this modulation affects the power spectrum.

the anafast  power spectrum obtained from the logarithmic map  (shown in solid orange)  do not seem to be affected by the modulation ( compared with the  input i map spectrum shown in solid blue) .

As well as the TT power spectrum estimated from the I' map (solid orange) , compared with the input I with 80' reso (solid blue).
Remarks

We propose to use the Planck 2018 GNILC maps with unires both for IQU maps, given the fact that we don't see the inconsistency observed in TT spectra when varres maps are chosen.
We found a modulation technique that seems to be working both at the map and at the power spectrum level ( we can further tweak some of the parameters, e.g. resolution of the template map, saturation scale, etc...)

Summary of the analysis performed so far
The  tests performed with @brandonshensley  are converging  to the fact that using a map with variable resolution (e.g. Planck 2015 I map)  can be the reason why we see a knee in the power spectra of real quantities as stated above by @seclark.
To further simplify the test we therefore proceeded by considering the Planck 2018 unires map which has the downside of being coarser in terms of resolution ,  80' , and of being less optimized in the removal of the CIB  but as a pro it has the  same resolution in each region of the sky.
We repeated the same procedure as outlined above and we restricted in particular to the case with P=0, i.e. i = log( I )
The procedure so far i used :

i = log(I)
run Namaster on 80% sky on the i  map
fit from the  Namaster  spectrum the power law to get the small scales ss map
get the large scale map with ls= Alm2map(almxfl(i,sigmoid))
I’ = exp(ls +ss)
we combine the maps ls and ss in step 5 but we can't combine ss and ls together as the two maps are estimated on different domains, the former    estimated by fitting the spectra estimated with namaster and the other  estimated from pseudo -alm . We fix this issue by running 2., 3. and 4. on fullsky quantities (i.e. using anafast) .

I map at 80'
We transform to the i map and estimate the power spectrum with anafast

With a lower reso, we have to restrict our fitting range in ell=30-100 .The spectral index of the fitted power law is -1.58.
A comparison on the map level of the maps with and without small scales injected by extrapolating the power law is shown below :

and the TT power spectrum estimated from the I' map (solid orange) , compared with the input I with 80' reso (solid blue). As you can see the spectra behave as expected.  Notice that for the real quantities we can keep estimating the spectra with Namaster on  the 80% of the sky.
Modulating small scales with a template map.
We now want to inject a modulation of the small scales similarly to what was done in the PySM2, since so far the amplitude is uniform across the sky.
We therefore :
a. smoothed the same I map used above to 5 deg,
b. take the log10,
c.  saturate to 2 all the pixels whose log10 value is >2.
d. Minmax rescale the map from 0.1 to 1 .
In this way we shrink  the dynamic range where we expect the scales to be modulated by the dust  intensity profile, A . Below the map produced following the steps from a-d .

Then we follow the steps from 1-5 and just changed the definition in 5.  as :  I’ = exp(ls +( A*ss ))
below you can see a direct comparison of the maps produced with the modulation defined above for a region at ~intermediate Gal. latitudes (same area as the one shown above)

Notice how the small scales now are dimmer in the vicinity  of low intensity regions and viceversa.
Finally, we want to check whether this modulation affects the power spectrum.

the anafast  power spectrum obtained from the logarithmic map  (shown in solid orange)  do not seem to be affected by the modulation ( compared with the  input i map spectrum shown in solid blue) .

As well as the TT power spectrum estimated from the I' map (solid orange) , compared with the input I with 80' reso (solid blue).
Remarks

We propose to use the Planck 2018 GNILC maps with unires both for IQU maps, given the fact that we don't see the inconsistency observed in TT spectra when varres maps are chosen.
We found a modulation technique that seems to be working both at the map and at the power spectrum level ( we can further tweak some of the parameters, e.g. resolution of the template map, saturation scale, etc...)
didn't have time to clean up the notebook will do asap (apologies!)

This sounds really promising @giuspugl! Glad to hear that the tests are converging. From a conversation with @brandonshensley, I am curious now what the histogram of the polarization fraction looks like after the addition of small scales

Finalizing the injection of small scales on GNILC dust maps
With the last commit of this PR, we show good results in injecting small scales in the poltens formalism on the dust emission.

We use the  2015 GNILC intensity map from the 2nd Planck release, as it encodes less contamination from CIB at 21.8' resolution
for Q and U we adopt maps from the 3rd Planck release as they were optimized for polarization studies at 80' reso.

in this way, we make   our modeling  of smaller angular scale to fully benefit  of the currently available data sets, where Intensity maps have been assessed at good high SNR at smaller resolutions than polarization ones.
We summarize the preprocessing steps as it follows:

Monopole subtraction:  we subtract the value reported in  Section 2.2 of Planck 2018 XII  to the I map for   the pixels outside  the Galactic   080 mask .
We fit the power-law in different multipole ranges  as the input maps are at different resolutions
as the injected small scales are at different multipoles for intensity and polarization, we consider 2 different modulation maps
estimate the NaMaster spectra outside   080 mask of the maps before and after the small scale injection
estimate the polarization fraction distribution  before and after the   small scale  injection
eventually re-include the monopole term to the intensity map ( not done yet  ...)
The updated  jupyter notebook is available here

thanks @giuspug
do you think this is completed? should I start turning this into production code to be merged into PySM3? Or better first produce IQU maps to be shared with the Panex group for further analysis?

We decided that we 're ready to port it into PySM3, please let me know if I can be of any help on this!

very good! I'll start to work on this and keep you posted.

@giuspugl should I use the gnilc_gaussian_scales.ipynb notebook inside this pull request or expansion_logpoltens.ipynb in the Gist?

@zonca i recommend to use the notebook in the gist  here

@giuspugl can you please make /global/cscratch1/sd/giuspugl/workstation/FG_extension/extending_gnilc_dust/ readable so I can compare results?

Sure, i made a new directory
/global/cscratch1/sd/giuspugl/workstation/FG_extension/extending_gnilc_dust
you 'd be able to access .

continues in #82


apt-get command not included

dpkg, apt-get commands not included in the ubuntu shell on PWD.
Is there a way to make it available?

@ravola can you please add more details.
Why do you need the apt-get command?
It's prepared virtual machines for just playing with Docker.
In my opinion, you shouldn't expect more.

@ravola can you please add more details.
Why do you need the apt-get command?
It's prepared virtual machines for just playing with Docker.
In my opinion, you shouldn't expect more.

What i meant was, if i am inside the container (docker exec) i should be able to run apt-get in the container for Ubuntu image.

What i meant was, if i am inside the container (docker exec) i should be able to run apt-get in the container for Ubuntu image.

@ravola I just checked by simple commands and it works:
docker run -it ubuntu sh
apt-get update

@ravola I just checked by simple commands and it works:
docker run -it ubuntu sh
apt-get update

apt-get work when i add a docker compose but doesn't work when i docker exec. Maybe a configuration issue on my end.

apt-get work when i add a docker compose but doesn't work when i docker exec. Maybe a configuration issue on my end.

@ravola probably. Can you attach the source code for detailed investigation or just the issue should be closed?

@ravola probably. Can you attach the source code for detailed investigation or just the issue should be closed?

@andrzejsydor sorry for the late reply. I will share my compose file.

@andrzejsydor sorry for the late reply. I will share my compose file.


CAPI: Add a pre-defined default time period to renew control plane certificates before they expire

Configure a default time period to renew control plane certificates in CAPI clusters before they expire:
The default value should be 180 days.
https://cluster-api.sigs.k8s.io/tasks/certs/auto-rotate-certificates-in-kcp
Also check if the time period can be changed in existing clusters.

CAPI supports this feature natively.
Automatic control plane certificate rotation can be configured in several properties of the KubeadmControlPlane (or KubeadmControlPlaneTemplate) CRs - time to rotate the certificates can be defined either as the number of days before the certificate expires, or as a timestamp after the certificate creation.
The first way - number of days before the certificate expires - is more useful in our case because certificate rotation works the same in vintage clusters.
Not sure how useful the second property is - since it's a timestamp, it can only take effect once. But it is also possible to add support for it if needed.
We deploy a specific app to MCs to initiate the creation/provisioning of a new workload cluster. The app creates all the necessary CAPI CRs including KubeadmControlPlane.
So, the property to rotate certificates can be exposed in the app's values and added to the KubeadmControlPlane definition.
In case the value is not explicitly defined by the user, it can default to 180.
Next steps: Prepare a draft PR in the cluster app repo, add support for the configuration of automatic certificate rotation and discuss it with Team Turtles.

Also check if the time period can be changed in existing clusters.

The time period can be changed in existing clusters. KubeadmControlPlane CR can be updated with the new time period and the change will take effect immediately. KubeadmControlPlaneTemplate is immutable, so in case the time period is set there, a new template needs to be created (the old one can be deleted).

CAPI handles the certificate rotation by rolling the control plane nodes.

Exposed the relevant KubeadmControlPlane properties as values of the cluster app and opened a PR: https://github.com/giantswarm/cluster/pull/60


Spelling

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

Nice work here, @jsoref!


Right click don't open the contextual menu

Info:

OS: Windows 10
Logseq ver: 0.8.2
Theme ver: v2.1.6
⚠  I don't have any custom info in ny custom.css
⚠  I don't have the bug using default theme

Description:
On windows, every time I press the right click on the mouse, nothing is happening.
To Reproduce:

Install LogSeq on Windows
Install solarized extended theme
Press the right click of your mouse
Nothing is happening ( Bug )

Expected behavior:

Install LogSeq on Windows
Install solarized extended theme
Press the right click of your mouse
The contextual menu must been shown ( expected behavior )

Attach files
Demo

Win10, can't reproduce ((

is it stiil exist in latest SolExt and Logseq 0.8.7?

@bwnyasse does it still exist in latest AwesomeStyler & latest Logseq?

@bwnyasse does it still exist in latest AwesomeStyler+AwesomeUI & latest Logseq?


Could support typescript client?

Could support typescript client so that I can use the wsrpc in browser?

@zhzblackc12 we have no plans to support a typescript client currently. https://developer.mozilla.org/en-US/docs/Web/API/WebSocket is likely the best path forward. Thanks!


Text selection on title don't work

For some reason, I can't start the text selection process on the tree item title. To select any text, i need to start selection outside of tree
code to reprodcue
import {
  StaticTreeDataProvider,
  Tree,
  UncontrolledTreeEnvironment,
} from "react-complex-tree";
import "react-complex-tree/lib/style-modern.css";

export const App = () => {
  const items = {
    root: {
      index: "root",
      isFolder: true,
      children: ["child1", "child2"],
      data: "Root item",
    },
    child1: {
      index: "child1",
      children: [],
      data: "Very long test case",
    },
    child2: {
      index: "child2",
      isFolder: true,
      children: ["child3"],
      data: "Child item 2",
    },
    child3: {
      index: "child3",
      children: [],
      data: "Child item 3",
    },
  };

  return (
    <UncontrolledTreeEnvironment
      dataProvider={
        new StaticTreeDataProvider(items, (item, data) => ({ ...item, data }))
      }
      getItemTitle={(item) => item.data}
      viewState={{}}
    >
      <Tree treeId="tree-1" rootItem="root" treeLabel="Tree Example" />
    </UncontrolledTreeEnvironment>
  );
};

Hi, thanks for your report! The tree node DOM items are provided with a "draggable" attribute, which means that clicking with the mouse an them and dragging, which is usually the behavior for selecting text, will drag the entire item instead, and surpress the text selection that would otherwise happen on the text within the item. In general, supporting both manually selecting text in an elemnent and also supporting to drag that item won't work, in any browser. Or am I misunderstanding the issue?

You understand it correctly. Maybe there is a way to change drag handle selector so i can drag item by cliching on it instead of whole item?

Hm, I'd say your best bet is to use a custom interaction manager implementation, that allows you to customize the props provided to the interactive element, there you can write the logic of how the interactive element is rendered yourself: https://rct.lukasbach.com/docs/guides/interaction-modes#custom-interaction-modes


Separate line length setting for comments

There should be an option to define the max. line length for comments; like IDEA has it. Studies show that readability of text is best limited to around 75 characters. [refs] Since most code has an indent of 4 spaces limiting comments to 80 characters makes sense.

I couldn't find that setting in IntelliJ to differ between code and comment line length.
Should detekt really make a difference between code and comments concerning the line length?
I don't think so.
I did a quick research and found the following here

While there's no definitive answer, reading code is still reading just like any other text and some
guidelines indicate that 50-75 characters per line is a good number for English.

Well, you're right, IDEA can actually display an infinite amount of guides. I only ask for comments because that seems rather complicated to implement.

Ok, I didn't know that.
I'm arguing that there shouldn't be a difference between source code and comments regarding line lenght based on the provided link.

I'm closing this, since there is no guideline for this. Detekt mostly complies with the official Kotlin style guide. However, for me this seems like a good example for a custom rule, if you want to have such a setting. The MaxLineLength rule is a good starting point for this indent.


chardet is not required for anything

Description
Removes chardet dependency.

not used by our code
doesn't show up as a dependency of anything in pipdeptree
tests pass without it
command line still seems to work
git history does not provide a clear reason for why it was added

Type of change

[x] Maintainability

How has this change been tested, please provide a testcase or example of how you tested the change?

Tests passing
Used the CLI locally

Any specific deployment considerations
No need to release because of this

Yeah, response.text seems to work ok without it too


test: move test to internal/test

Fixes #521

not sure if doing this before #540 would have helped, but conflict now :/

@sdboyer rebased to tip

tyty


Fixing Auto Updates

@lesv - FYI
I've rolled back a few samples that are still having issues in particular monitoring/, bigtable/, and dataflow/spanner-io. They seem to have non-trivial updates required to the samples. I'll work with @dzlier-gcp to figure out what is going wrong.


tweak: Allow domains linked in my website

Adds domains I use in nunosempere.com. I also vouch that these domains are not threatening.

Flyby code review: I would highly, highly suggest separating out "code formatting" changes from "functionality changes".
Right now your review combines both, making it hard for Vlad to see what's actually changed, and thus really hard to know if this is safe to merge.
See https://google.github.io/eng-practices/review/developer/small-cls.html
(CL is Changelist, google-speak for Pull Request)

Yeah, makes sense. I have https://prettier.io/ set up so that it formats on save, I didn't even notice.

Thanks, @NunoSempere !
The current formatting is intentional (I should bring over the .eslintrc that has generated it #2 ), so I'd appreciate if you conform to it!

See also https://github.com/Stvad/link-summoner#whitelisting-more-websitesadding-custom-preview-types on how to add customization just for your website


Should remove the property of type java.nio.file.FileSystem out of ProjectDirectoryResolver class

See https://github.com/kazurayam/unittest-helper/blob/0.3.3/lib/src/main/java/com/kazurayam/unittest/ProjectDirectoryResolver.java
ProjectDirectoryResolver has a property of java.nio.file.FileSystem as follows:
import java.nio.file.FileSystem;
...
public final class ProjectDirectoryResolver {

    private static final Logger logger = LoggerFactory.getLogger(ProjectDirectoryResolver.class);
    private final FileSystem fileSystem;
    ...

However, actually this property seems is not used.
Had better to remove this property?

However, one think I need to remember.
The TestOutputOrganizer.Builder accepts a FileSystem object as prameter to the ProjectDirectoryResolver. It seems to be important.


set use_remote_address to true for egress listeners in side car mode

When Istio Proxy runs in side car mode and makes calls to other services, we would like the x-forwarded-client-cert header to be passed to the server side as we do some validations. Similarly we we set service specific timeouts with x-envoy-upstream-rq-timeout-ms while making egress calls. These headers are sanitized by client Envoy because we set use_remote_address to false for outbound listeners.
I think it should be OK to set use_remote_adress to true for side car outbound listeners so that it picks up the localhost address of the sender, which is an internal address, so that trusted headers are not sanitized.
Refer to https://github.com/envoyproxy/envoy/issues/4654 and https://groups.google.com/forum/#!msg/envoy-users/lf2up8V2Cn8/7ItTCWBQBwAJ for relevant discussion.
This PR sets the use_remote_address to true for sidecar's outbound listeners.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ramaraochavali
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ramaraochavali. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
189c702431d4e9fd5a5461c27d29a5d56c5c4d37
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
189c702431d4e9fd5a5461c27d29a5d56c5c4d37
link
/test e2e-simpleTests-master

prow/e2e-dashboard.sh
189c702431d4e9fd5a5461c27d29a5d56c5c4d37
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/retest

/test e2e-dashboard-master

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
189c702431d4e9fd5a5461c27d29a5d56c5c4d37
link
/test e2e-dashboard-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@rshriram added comments. PTAL - needs lgtm one more time looks like

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
9ee6d3f5c6e836fee97e03ffac4716b6d38361d1
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-presubmit-tests-master

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-k8s-presubmit-tests.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

a recent pr fixed that test, maybe just want to rebase

Just rebased yesterday - Was there any fix today?  If it does not pass this time, will rebase

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
57c92eb4078ed907ce5ea41c774793488dfc174d
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@howardjohn @rshriram just merged master. can you add lgtm one more time - sorry for this

/lgtm
based on Shrirams approval

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

@ramaraochavali: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
d29b98325caa47c7951776780b6af23de735f230
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@rshriram @howardjohn had to merge master again for test case to pass. Can you please lgtm again?

/lgtm sorry I think I said the test was fixed before it actually got merged

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn looks like the lgtm is not parsed correctly by bot. Can you adding it again?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, ramaraochavali, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Publish new docker image of Alpine 3.7

Alpine 3.7 was released yesterday. https://alpinelinux.org/posts/Alpine-3.7.0-released.html

@ncopa It looks like you've been working on this already. How's the progress?

I just made a PR for it: https://github.com/docker-library/official-images/pull/3762


Adding Apple Silicon GPU Acceleration examples

Description & Motivation
We could add Apple silicon GPU support for the examples of lightning-AI.
Pitch
Add MPS support for the examples.
Alternatives
No response
Additional context
Had Created a pull request https://github.com/Lightning-AI/lightning/pull/18127 for this.
cc @borda

Thanks @NripeshN for sending the PR 🎉


edns-buffer-size problem prevents unbound-host from getting response

On a server I have access to I’ve noticed that unbound-host -t NS . fails. When I strace the command I see that it’s sending a bunch of UDP queries to the root nameservers but receiving no replies.
When I create myunbound.conf:
server:
	edns-buffer-size: 512

… and run unbound-host -d -C myunbound.conf -t NS ., then I get the expected results.
While it’s reasonable that the EDNS buffer size would need to be adjusted for a UDP response, it seems like I shouldn’t have to do that in order to get any response, should I? If a certain time passes and no UDP queries have succeeded, shouldn’t libunbound fall back to TCP?
And, moreover, would it also make sense to send multiple UDP queries concurrently: one with a EDNS=512, another with EDNS=1472, etc.? That way if, e.g., 4096 gets no response but 1472 and 512 do, and 512 is truncated but 1472 isn’t, we can still have the UDP response without having had to do TCP?

If a certain time passes and no UDP queries have succeeded, shouldn’t libunbound fall back to TCP?

Unbound only queries over TCP when instructed to do so, ie TC bit received. Unless you configure Unbound to always use TCP or TLS.

And, moreover, would it also make sense to send multiple UDP queries concurrently: one with a EDNS=512, another with EDNS=1472, etc.? That way if, e.g., 4096 gets no response but 1472 and 512 do, and 512 is truncated but 1472 isn’t, we can still have the UDP response without having had to do TCP?

Unbound already falls back to 1472 for IPv4 and 1232 for IPv6 when resolving using a bigger buffer size fails. These fall-back values are chosen to prevent fragmentation, which in some cases can lead to resolution failures.

@ralphdolmans Thank you for your response.
Would it be reasonable, then, to implement a fallback to 512 if 1472/1232 fails? We actually are seeing cases where 1472 is too big. Unbound will fall back to TCP if the UDP/512 query is fragmented, right?

Would it be reasonable, then, to implement a fallback to 512 if 1472/1232 fails?

I would prefer to not add an extra fallback for this. All these fallbacks make the code more complicated and generate more traffic towards unresponsive servers. This fallback is in place to work around fragmentation issues, which usually does not happen on 1472/1232. I recommend to debug and fix this network issue instead of working around it in Unbound. Maybe you have an overly aggressive firewall on your path?

Unbound will fall back to TCP if the UDP/512 query is fragmented, right?

The root NS set + signature won't fit in a 512 answer, so the server will reply with the truncation bit set. This will indeed trigger Unbound to retry over TCP.

Alas, we don’t always control firewall settings, and a fair number of servers where we run libunbound apparently drop UDP responses whose sizes exceed 512 bytes.
It would be great to have an option to fall back to 512 and/or TCP. Failing that, we’ll see about some sort of application-level detection of this issue and force the EDNS max to 512 accordingly.


Need a better way to check for successful attribute read in python tests

As discussed in this PR: https://github.com/project-chip/connectedhomeip/pull/35322#discussion_r1739403129
It is awkward to check for successful read as shown in the following test code:

            for server in server_list:
                cluster = Clusters.ClusterObjects.ALL_CLUSTERS[server]
                data = await dev_ctrl.ReadAttribute(dut_node_id, [(endpoint, cluster.Attributes.GeneratedCommandList),
                                                                  (endpoint, cluster.Attributes.AcceptedCommandList),
                                                                  (endpoint, cluster.Attributes.AttributeList),
                                                                  (endpoint, cluster.Attributes.FeatureMap),
                                                                  (endpoint, cluster.Attributes.ClusterRevision)])
                for endpoint, clusters in data.items():
                    for cluster, attributes in clusters.items():
                        for attribute, value in attributes.items():
                            asserts.assert_false(isinstance(value, ValueDecodeFailure) and
                                                 isinstance(value.Reason, InteractionModelError) and
                                                 value.Reason.status == Status.AccessRestricted,
                                                 "AccessRestricted is not allowed on Global attributes")

There should be a better way to verify all attributes read ended in success with values.

@tleacmcsa
check for successful read - the test from this example is a lot more targeted than that: it specifically tests that the error is not AccessRestricted, but does allow any other error whatsoever. Is this what is intended?
I fully agree we should make it easy to check for "no errors at all" however I am not sure we should optimize for this kind of specific exclusions. Overall I am questioning it somehow: why do we allow global attribute read failure as long as they fail with a different reason?

See https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/matter_testing_support.py#L1152

@andy31415 Perhaps the test is too specific, but the goal is to ensure none are AccessRestricted.
@cecille is there a multi-attribute read version that checks for success?


change pod icons

HI
i want to change the controls icons with custom icons , Is there any way to do that?

Hi, I found a easy way to change icons.

Open path Photo Editor/Photo Editor, you can see one file called icomoon.ttf
Open https://fontdrop.info/. Upload file icomoon.ttf which you found above, then you can see order of icons. Also hover each actual icon to see unicode of each (Don't worry about first 4 characters)
Open https://icomoon.io/app/#/select. Create your own icons pack. Note that you need to select only 10 icons, first 4 blank characters will be generated when you exported ttf file)
After select icons, you have to edit icon code manually. Notice that code is the same with code of each icon in original ttf file.
Export ttf file and replace it in source code.
All done!


Unable to save set data

Hi!
After all the issues with updating from v.1.0.44 to the latest version, set data does not save when tapping the save button.
The set counter does not increment, and no record gets generated for the graphs. I tried with the built-in plans and the one I imported and both have the same issue. There's no error message displayed on screen.
I had to revert back to v.1.0.44 to be able to save anything. Uninstall/clean cache/reinstall does not help.
Thanks!

Hi!
I did some more testing and it seems the issue started in v1.0.47. I tried every subsequent version (by uninstalling, reinstalling, and using the built-in data) and they all behave the same way: the save button does nothing when adding a new set.
After more digging, sets will not be added/saved if rest timers are disabled in the application settings. Since I don't use them, it's blocking me from adding sets... I'll temporarily enable them to work around that issue.
I took a quick look at the code, but I'm not familiar enough with Dart to offer anything other than wild guesses. I believe that specific view is defined in lib/start_plan_page.dart, so either the onPressed event handler of the save button isn't called, or the call to save() silently fails. I didn't see any change that would cause this, beside one extra condition being checked on line 158 (the check on mounted).
Thanks!

Wow this bug is really dumb I literally just returned and didnt save if the timers were turned off...


Update rust-toolchain.toml

I think we are safe to use any version within the 1.xx release train.
Maybe due to a local setup problem, I had this error when trying cargo check after pulling latest master branch:
$ cargo check
error: the 'cargo' binary, normally provided by the 'cargo' component, is not applicable to the '1.68.0-aarch64-apple-darwin' toolchain

I tried rustup update but didn't change anything. Changing rust-toolchain.toml to use 1.68 fixed it.
Maybe a side effect of "changing" which Rust version to use (?). Anyway, I think it's quite safe to not force the usage of a particular minor version.

The integration test failures seems unrelated to this PR.

I've been able to fix that error in the past by uninstalling and reinstalling the rustup toolchain. Seems to be a rustup bug.


THRIFT-5584: use gradle toolchain to specify Java 11 with --release 8

use gradle toolchain to specify Java 11 with --release 8

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
[x] Did you squash your changes to a single commit?  (not required, but preferred)
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
[x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Looks good to me, for the most part. I would suggest a slight change to the error message.
Also, there are some conditionals in the Gradle build files that check for Java 11. Those can be removed now.
We'd also need to remove the CI checks that run using JDK 8, like that the Ubuntu Xenial builds, unless you want to restore your previous workaround to force JDK 11 to be installed.

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

Ah, ok. That's convenient. I assumed it worked like Maven toolchains: detected but not installed.

we don't need to update the xenial build, since using java toolchain means we are decoupling the JDK used to run gradle from the one used to compile Java. in the case of xenial, JDK8 is used to run gradle, which will download JDK 11 on its own before compiling Java.

Ah, ok. That's convenient. I assumed it worked like Maven toolchains: detected but not installed.

yes there's a section in here describing the auto provisioning feature in case you are interested

why not split dependency updates or other code changes - not related to Gradle/Java update from real Gradle Java 11 upgrade?

If they are small and trivial, like these, I don't think it matters much. All of these are related to updating the build.

Hi,
It seems that the version 0.18 is compiled in Java 11 even if --release 8 is present :

libthrift 0.18 :
javap -verbose org/apache/thrift/transport/THttpClient.class | grep -i major
major version: 55
libthrift 0.17 :
javap -verbose org/apache/thrift/transport/THttpClient.class | grep -i major
major version: 52

https://javaalmanac.io/bytecode/versions/

@nicolasb29 That's not a bug. Thrift moved to Java 11 in #2686 (THRIFT-5644)


Implement Lootable API for Block States

Description
Implements the Lootable API for Block States
Checklist
The following items should be checked before the pull request can be merged.

[x] Code follows existing style.
[x] Unit tests added (if applicable).

I did some testing on when the container refills occurs.

Happens when a player opens a lootable inventory that has been scheduled for replenishment
Happens immediately if the container has not been filled before.

This is when the following conditions are filled:

The inventory has a loot table set.

On phone now will add more to this comment

As I said here you can't add functionality that modifies the block state over time, as it is indeed a state... But why not add a block state simulator, i.e. something that has a block state and ticks to simulate as an input, and a new block state as an output.

Also about loot tables, isn't fully copying the functionality disjoint with testing for this as loot tables are based out of randomness, which is not viable when unit testing?
We simply just have to have our own deterministic implementation for this, which means a lot of freedom on our end. I will write an pull request on randomness guidelines plus framework for mockbukkit.


CI: remove paths-ignore

Description
when a PR modifies any path in paths-ignore, even if the pr has other changes from paths, the whole PR gets ignored from core test runs
see example: https://github.com/facebook/lexical/pull/6420
Test plan
Before
PR does not get test runs
After
PR gets test runs

it actually worked fine in https://github.com/facebook/lexical/pull/6357 , are we sure about the reason

it actually worked fine in [lexical] Feature: registerMutationListener should initialize its existing nodes #6357 , are we sure about the reason

the check to ignore lexical-website was before change from nicholas and seemed fair as website changes shudn't trigger test

m not sure, need to test, based on the docs

it maybe ?
i think no harm landing this first just to see if it unblocks. i have another wip PR to test out using the paths: option and specify paths to include so hopefully PR that modify both website and other paths will trigger the tests

prolly not the reason since: https://github.com/facebook/lexical/pull/6425


Run scanCode in travis builds

We need to catch tabs/non-compliant files in the build process again.

Rebased and merged as https://github.com/openwhisk/openwhisk/commit/dade50b2a6f213282cb225c1c5def88e8cd80f27.


Report fields - "title" report field shows up and app crashes when clicking on checkbox.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Go to Account settings.
Create a new workspace.
Quickly go to More features and enable Report fields.
Note that "title" report field appears. (might need to repeat Step 3 to 5 a few times)
Click on the "title" checkbox.

Expected Result:
"title" report field will not show up and app will not crash when clicking on the checkbox.
Actual Result:
"Title" report field shows up and app crashes when clicking on the checkbox.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Bug6532499_1720042271423!crash.txt
https://github.com/Expensify/App/assets/38435837/d9889ff0-d203-48ef-91b0-1ff627be6b6a

View all open jobs on GitHub

@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

@rezkiy37 @waterim Can you please check this out?

Hello, Im Artem from Callstack and would like to help with this issue as it was my filter and it should be adjusted

@nyomanjyotisa thanks for the proposal, but this feature is being worked on by Callstack and its behind beta, since their PR has caused this regression, they will work on the fix

@mountiny This one will be addressed here

@waterim thanks, I have linked the PR to this issue

@rushatgabhane @shubham1206agra can you please complete the checklist?

@slafortune this is a new feature and we are handling all these cases as part of the report fields configuration project so I think we can close this issue now, payments are done per project


Outdated example in 'Migrating to module Workers'

Which Cloudflare product does this pertain to?
Workers
Existing documentation URL(s)
https://developers.cloudflare.com/workers/learning/migrating-to-module-workers/#configuring-your-wranglertoml
Section that requires update
Configuring your wrangler.toml
What needs to change?
[build.upload]
format = "modules"
dir = "./src"
main = "./worker.js" # becomes "./src/worker.js"
[[build.upload.rules]]
type = "ESModule"
globs = ["**/*.js"]
How should it change?
When you run Wrangler with this configuration you've got warnings:
- Deprecation: "build.upload.format":
  The format is inferred automatically from the code.

- Deprecation: "build.upload.dir":
  Use the top level "main" field or a command-line argument to specify the entry-point for the Worker.

- Deprecation: The `build.upload.rules` config field is no longer used, the rules should be specified via the `rules` config field. Delete the `build.upload` field from the configuration file, and add this:
  ```
  [[rules]]
  type = "ESModule"
  ```

Additional information
In my case (using TypeScript) I also got an error:
[ERROR] [plugin wrangler-module-collector] Cannot read properties of undefined (reading 'map')

In _data/chains/eip155-1111.json:

"chain": "WEMIX", + "rpc": ["https://api.wemix.com", "wss://ws.wemix.com"], + "faucets": [], + "nativeCurrency": { + "name": "WEMIX", + "symbol": "WEMIX", + "decimals": 18 + }, + "infoURL": "https://wemix.com", + "shortName": "wemix", + "chainId": 1111, + "networkId": 1111, + "explorers": [ + { + "name": "WEMIX Block Explorer", + "url": # "https://explorer.wemix.com",


Update README.md to support Remix 2.0

Some types have been changed since Remix 2.0. This commit fixes the readme to support Remix 2.0

cc @pbteja1998 if you have time to review this small changes

Please run lint and format commands to follow prettier setup that is configured.

The Readme being out of date caused me some confusion when I was getting started with this library. Can someone with write access merge these changes?

@refactornator thanks for bringing it up. I hope @pbteja1998  (the main owner) takes this into action. I am not sure if other contributers have write access cc @Hansenq
@maddhruv
@MichaelDeBoey
@TheRealFlyingCoder


couple of enhancements

Hi, I've got a remarkable 2 with the type folio option.

There's a checkbox paragraph option for textual lists (this may not need a type folio tho).
The unknown int in PageInfo is a counter of how many times the document has been edited with the type folio - not how many characters, more like the number of "sessions".

Please see https://github.com/ricklupton/rmscene/issues/25 -- using the JSON debug files I've implemented block types 8 + 13 as well now.

Thanks for contributing @adq! I added your test file shared in issue #25 to the tests (hope that's ok) and made a few tweaks so they pass. I've also updated the changelog and listed you as a contributor.


How to add a "raw" html+javascript page?

I'd like to add a page that would be purely in HTML + javascript that would come up on my domain (alkamid.com/mypage) but not in the post index. I tried simply creating another layout (_layouts/raw-page.html) with {{ content }} only, but javascript (d3.js) is not executing. Specifically, I'd like to add this gist as a separate page: https://gist.github.com/alkamid/29f86cfb22c8bdb080ab. How to do this properly?

You'll want to create a page outside of the _posts folder. Look at theme-setup as an example of how pages are setup.
Basically you create a folder in the root of your Jekyll site and place an index.md file inside of that with Markdown or HTML. There's a million different ways to do this but one way off the top of my head:

Create a new layout /_layouts/raw-page.html and populate it with the contents from that gist.
Create /mypage/index.md. Add the appropriate YAML Front matter for title and set layout: raw-page and leave the content blank.

When you build your site you should get a page at alkamid.com/mypage/ that looks like your gist.
If you want more info on how Pages work with Jekyll check out the official documentation.

Also you should be able to just add a raw HTML file (or any file for that matter) in root. If you don't include any YAML Front Matter Jekyll should leave it alone. So instead of doing what I suggested above just created /mypage/index.html and place the contents of your gist in that file.


Update to REST functionality

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.gpickett seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[CXF-8299] Impl for QueryParamStyles in RestClient

This is a draft PR for now since the new API (new builder method and enum) is not yet available in Maven.
When ready, this will resolve JIRA CXF-8299.
It allows users to configure the style of query parameters when multiple values are specified for the same parameter key.  This may be useful in scenarios where the client developer has little to no control over the RESTful endpoint - which might require PHP-style query parameters, or comma-separated values.

Superseded by #680


Reduce complexity on raiden-ts/src/channels/epics.ts

Description
According to the code climate reports raiden-ts/src/channels/epics.ts is one of the often modified classes that has a high maintenance cost due to complexity.
The purpose of this issue is to identify the possible improvements that can be done on raiden.ts in order to reduce the complexity and improve the maintainability of the class.
Acceptance criteria

Tasks

[ ]

This has got an A rating now: https://codeclimate.com/github/raiden-network/light-client/raiden-ts/src/channels/epics.ts -> Closing


Enable StoreResolvedURIs when loading SDF

🎉 New feature
Summary
Replaces #2323 - see description in that PR.
This PR is needed so that bullet-featherstone plugin in gz-physics can load meshes with relative path URIs.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The ServerFixture.LoadSdfModelRelativeUri test in UNIT_Server_Rendering_TEST.cc was failing because it contains a mesh uri pointing to a non-existent dae file. With SetStoreResolvedURIs set to true, it returns an error and so the server stops loading the model. This breaks current behavior. To resolve this, I added logic in ddf7f46 to allow the server to proceed with presence of URI_LOOKUP errors.

The ServerFixture.LoadSdfModelRelativeUri test in UNIT_Server_Rendering_TEST.cc was failing because it contains a mesh uri pointing to a non-existent dae file. With SetStoreResolvedURIs set to true, it returns an error and so the server stops loading the model. This breaks current behavior. To resolve this, I added logic in ddf7f46 to allow the server to proceed with presence of URI_LOOKUP errors.

Looking for feedback on this. Any objections to allowing Server to continue loading with presence of URI errors?

I'm not sure this is a good idea. The URI_LOOKUP error is not just emitted for missing mesh files, but also when an included model is not found, which should be a blocker error IMO.

The other option is to not return the URI_LOOKUP error in sdformat when resolving URIs but that's also not ideal.
So with SetStoreResolvedURIs  now set to true, we'll just be more strict and stop the Server from loading that model if an URI is not found. How does that sound?

Maybe we can define a parameter in ServerConfig that determines if a SDF errors prevent the Server from loading. Or it could be an environment variable. Either way, we can just set that in the test without affecting end users.

Maybe we can define a parameter in ServerConfig that determines if a SDF errors prevent the Server from loading.?

Added a new parameter in ServerConfig, blockOnSdfErrors to stop server from loading in presence of SDF errors. It can also be passed from the command line, gz sim -v 4 shapes.sdf --block-on-sdf-errors 1

DCO needs to be fixed.

fixed and force pushed

fixed a couple of windows failures in 7488f7e.


Prerequisites for '24 workshop

Currently we have: an interest in teaching.
Should it be more specific, should people have some setup on their own computers?

First episodes would have needed a note on being familiar with git to make it easier to follow along

TODO: Add some info on each episode to the instructor guide


podman issue with tag and digest

On Debian bullseye, the current stable release I get this:
$ podman build -t nostr-rs-relay .
STEP 1: FROM docker.io/library/rust:1.66.0@sha256:359949280cebefe93ccb33089fe25111a3aadfe99eac4b6cbe8ec3e1b571dacb AS builder
STEP 2: FROM docker.io/library/debian:bullseye-20221205-slim@sha256:25f10b4f1ded5341a3ca0a30290ff3cd5639415f0c5a2222d5e7d5dd72952aa1
Error: error creating build container: Docker references with both a tag and digest are currently not supported

I suspect that's just an old version of podman?  It's supported on latest Fedora.
But regardless, i'm going to stop bringing in the hash of the image.  We use a couple of trusted base images (debian & rust), and this will more easily let people re-build quickly for normal patching.
This should also let ARM people build more easily.
Try again and I bet it will work.


Allow custom command start activity

Android 10 restriction start activity on background service, so app can't start activity in onCommand method.
Maybe can change onCommand return PendingIntent like getArtworkInfo to allow start activity.

We're actually looking at solving this slightly differently, where getCommands() would return a list of RemoteActionCompat objects rather than UserCommand, allowing you to tie an action directly to any PendingIntent you want (i.e., to start an activity) as an alternative to using the default onCommand callback (which will still be available).
(As a side benefit, it'll let you attach a custom icon to your action)


add support http client multipart response

Codecov Report
Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (4c2e142) 93.95% compared to head (8712a18) 93.88%.

Files
Patch %
Lines

include/libasyik/http.hpp
90.76%
12 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   93.95%   93.88%   -0.07%
==========================================
  Files          15       15
  Lines        1571     1767     +196
==========================================
+ Hits         1476     1659     +183
- Misses         95      108      +13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Disable outline on Grid component

I think we should disable outline on Grid class. If it's fine, I will submit a pull request.

@nhducit Outline is an important usability mechanism for keyboard-only users. As such, I want it to be enabled by default for focusable elements.
You're free to disable it yourself via a custom className or inline style (eg style={{ outline: 'none' }}). react-virtualized supports both. :)

@bvaughn It's OK. Thanks a lot ^^

No problem. 😄
You aren't the first one to ask this! I just think it's important that react-virtualized be as accessibility-friendly as possible by default. People can choose to disable accessibility features (like outline) if they think it's appropriate to their applicate. 😁

Is there a way to disable a MultiGrid's child Grid's outline?

Never mind. Fixed by setting styleBottomRightGrid