Code actions not working

Hi there,
Code actions have stopped working.
I found this in the logs:
[fail]: OmniSharp.MSBuild.ProjectManager         Failure while loading the analyzer reference 'Microsoft.CodeAnalysis.CSharp.NetAnalyzers': Type Microsoft.CodeQuality.CSharp.Analyzers.ApiDesignGuidelines.CSharpUsePreferredTermsAnalyzer has invalid vtable method slot 5 with method none
If found out that this might be an issue when using .NET 6, which we are.
There is a flag in the VSCode plugin called usemodernNet that causes it to use a .NET 6 compiled version of Omnisharp which supposedly fixes this issue if you have them in VSCode.
I haven't been able to figure out what this flag does exactly "under the hood" though.

I think the vscode useModernNet is essentially the same as our g:OmniSharp_server_use_net6, which is an instruction to use a different server build. Try adding this to your .vimrc:
let g:OmniSharp_server_use_net6 = 1

Then re-install the server with :OmniSharpInstall

Thanks Nick,
That did the trick, there are no longer any errors in the log and code actions are back.


2nd Voip Push does not execute app code (looks like app stays in zombie mode)

Hello master(s),
we are facing a very challenging problem and I don't know if you have also encountered this problem with your implementations:
We are sending Voip Push notifications to report a new incoming call.
When voip push is received in the device, the callkit (incoming call) interface is opened and our app is opened in the background in order to connect to our socket etc.
This is all working fine when:

the app is in the foreground
the app is loaded in the background (with the phone locked or unlocked)

But it doesn't work when:

the app is killed (with either the phone locked or unlocked).

The (very) strange thing is that if i.e. the app is killed and we receive a first voip push, the app is loaded and iOS grants us a couple of seconds (2 / 3 seconds) to execute some code. BUT after that, if we don't open our app in the mean time and send a second push notification, the voip push is received, the call interface is open but our app does not run any code.
Looks like after we receive a first voip push, the app is loaded into a some sort of "zombie mode" (invisible to the user) and after that, the code is paused and no longer available for execution.
If between the first and second voip push calls we open and close our app, it works fine.
Do you have any information about this "Zombie mode" and how we can avoid it?
Thank you so much!
-ct-

Sorry for late reply @neeact , actually this is our problem as well (not on the 2nd time, but always when app is killed). We are using MeteorJS and when the app is killed we don't get the 'on' notification callback until the app is initialized/opened (which takes few seconds).
That is why we have changed our whole approach to Voip Calling - check the new branch that we are using
https://github.com/AleksandarTokarev/cordova-plugin-callkit/tree/trusted-care-master
Basically, instead of relying on Native to pass Notification to JS and start the call, we are calling a Webhook (Get Endpoint) - to notify the server that the user has accepted the capp, and when the user opens the app, Meteor DDP (something like Websocket) tells the Callee on IOS that the call is active and the Phone UI opens.
Let me know if u have any questions

Thank you for the reply @AleksandarTokarev .
I understand your approach.
We have decided for a different strategy: we have created a keep alive routine that is triggered as soon as the voip push is received in the device and keeps the app running while the webrtc flow is processed.
We also had to implement some logic to guarantee that the webrtc flow is only processed once our socket is connected and the peerconnection created.
Once again, thank you for your help!
Cheer.
-ct-


feat(search): keyboard-accessible search button

This PR reworks the search button to provide proper semantics and keyboard accessibility. It uses an HTML <button> element for the button that invokes the search overlay, ensures focus goes to that button element, and allows activation of that element with "space" and "enter" keys (as a natural consequence of <button> behavior). I've also made some minor flexbox tweaks.

Hmm, looking at the live quartz.jzhao.xyz and it looks like the .search>.search-button rule didn't get built into the output stylesheet for some reason, which is causing it to look odd. I'm not familiar with the way the CSS gets put together, any idea what could be causing this?

seems like cloudflare butchered the css caching haha, a quick cache bust fixes this
(for future visitors, you just need to wait a few minutes/hours before your CDN refetches the CSS)


publish on npm

Done: https://www.npmjs.com/package/snackbarjs
Added you as collaborator already, @FezVrasta :)

Thanks


feat: schema changes for features

Some backend schema changes. Mostly:

Combine metadata predistill and postdistill into a single feature type.
Rename project and add a few fields.

Should also check if we use the column types somewhere in the frontend to make rendering decisions.


fix(tmpl): replace upstream of webpack-asset-relocator-loader

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Switch to upstream which is still actively maintained

A small search on npmjs.com returns three results
The one provided in the webpack-related templates aka. @marshallofsound/webpack-asset-relocator-loader hasn't been updated for more than two years, while the other two seems to be still actively under developments.
Thus, I think the team should move to this branch instead of the old one.
Also, it solves the issue for project running with external electron.
When running directly via
project_dir $> node node_modules/.bin/electron .

after electron-forge make
it would turn to run .webpack, which is expected.
But the modules wouldn't be found as the old relocator marks path as relative to the executable, aka.
/path/to/project/node node_modules/.bin/electron/.webpack/main/native_modules/my_module not found.
with the new one, it correctly search into the defined location.

My understanding is that this PR is the reason why there's a fork. If this is somehow fixed upstream, then we can move back to the original package.

See also #1327

Well, fork and put on the shelf is a no go on one hand.
On another hand, the added environment variable is not documented anywhere, which cost downstream dev like me days to debug this.
Also, somehow I cannot tell how "it doesn't work with electron" now, as the refs are quite old.

@malept yes, I clone and test the project mentioned in #1327, with update the devdeps of package.json to latest, it does work properly either from electron-forge start or from raw electron.

Also, about the fork, the added environment variable wasn't documented anywhere

Hi, @malept any update on this?

It would help if you could provide a repository containing an Electron Forge app using native modules and this PR applied to the template, that shows that it works.

Check this
https://github.com/Zettlr/Zettlr/commit/11e348a1ef7d22c33ff4261b3181bc443c9cf154
Mark Lee<EMAIL_ADDRESS>於 2020年12月13日 週日 下午12:28 寫道：

It would help if you could provide a repository containing an Electron
Forge app using native modules and this PR applied to the template, that
shows that it works.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/electron-userland/electron-forge/pull/2067#issuecomment-743947377,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA626RXLP37XCZXM37LIFETSUQ7FBANCNFSM4UP33HKA
.

A minimal repository would be better, since it's easier to tweak and debug without worrying about other variables.

Okay, how about https://github.com/Brli/poc-native-modules ?
It just log serial ports available in console after run.

@malept hi, I've updated a repo with poc for you to test.

Hi, any further update?

Hi, any further update?

So the main problem with switching to the upstream version is that using native modules in the renderer process is broken. I've verified this with the latest version of upstream, and get the following error:
Uncaught Error: Cannot find module '/tmp/forge-sqlite3/node_modules/electron/dist/resources/electron.asar/renderer/native_modules/build/Release/better_sqlite3.node'

The change in the fork fixes this. It may end up being that there needs to be a fork that follows upstream and makes releases with the change. However this is a lot of work to do and maintain.

Repro steps:

Run:

npx create-electron-app --template=webpack forge-sqlite3
cd forge-sqlite3
yarn add better-sqlite3

Replace @marshallofsound/webpack-asset-relocator-loader with @vercel/webpack-asset-relocator-loader in webpack.rules.js and do the same replacement in package.json, but use yarn remove and yarn add --dev as appropriate

Add the following to src/renderer.js:

import * as sqlite from 'better-sqlite3';
console.dir(sqlite);

Run yarn start

Expected: console.dir prints something out in the DevTools console
Actual: Error from above

So the main problem with switching to the upstream version is that using native modules in the renderer process is broken. I've verified this with the latest version of upstream, and get the following error:
Uncaught Error: Cannot find module '/tmp/forge-sqlite3/node_modules/electron/dist/resources/electron.asar/renderer/native_modules/build/Release/better_sqlite3.node'

The change in the fork fixes this. It may end up being that there needs to be a fork that follows upstream and makes releases with the change. However this is a lot of work to do and maintain.

Repro steps:

Run:

npx create-electron-app --template=webpack forge-sqlite3
cd forge-sqlite3
yarn add better-sqlite3

Replace @marshallofsound/webpack-asset-relocator-loader with @vercel/webpack-asset-relocator-loader in webpack.rules.js and do the same replacement in package.json, but use yarn remove and yarn add --dev as appropriate

Add the following to src/renderer.js:

import * as sqlite from 'better-sqlite3';
console.dir(sqlite);

Run yarn start

Expected: console.dir prints something out in the DevTools console
Actual: Error from above

it is https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackConfig.ts#L58 that causing your requirement of forking and patch upstream, not an upstream fault after all.

it is https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackConfig.ts#L58 that causing your requirement of forking and patch upstream, not an upstream fault after all.

it is https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackConfig.ts#L58 that causing your requirement of forking and patch upstream, not an upstream fault after all.

This isn't the case, as the code you're linking to is for production only, whereas the repro steps are explicitly for development mode.

it is https://github.com/electron-userland/electron-forge/blob/master/packages/plugin/webpack/src/WebpackConfig.ts#L58 that causing your requirement of forking and patch upstream, not an upstream fault after all.

This isn't the case, as the code you're linking to is for production only, whereas the repro steps are explicitly for development mode.

btw, you can try steps in https://github.com/electron-userland/electron-forge/pull/2067#issuecomment-765812524 without changing the relocator-loader.

btw, you can try steps in https://github.com/electron-userland/electron-forge/pull/2067#issuecomment-765812524 without changing the relocator-loader.

Would be great if MarshallOfSound could get this PR in after more than a year:
https://github.com/vercel/webpack-asset-relocator-loader/pull/41


Settings UI crashes on toggling FancyZones on/off

ℹ Computer information

PowerToys version: 0.20.1
PowerToy Utility: Settings (Fancy Zones)
Running PowerToys as Admin: nope
Windows build number: 10.0.19041.450

📝 Provide detailed reproduction steps (if any)

Open Settings > Fancy Zones
Toggle FZ on or off
…

✔ Expected result
What is the expected result of the above steps?
❌ Actual result
What is the actual result of the above steps?
The GUI crashes/closes. It does apply the setting.
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

Closing as dup of https://github.com/microsoft/PowerToys/issues/5955


Net Standard

Hi,
That would be great to release a .Net Standard version of NControl, since it replaces PCL.
What's needed to be done for NControl to be compatible with .Net Standard?
Regards,

Hi, any progress on this topic? A netstandard compatible version would be very appreciated.
Regrads

any updates?


Can't recovery tpg from disable to enable.

OS: Centos 7.6.1810
Version: ceph-13.2.5 + tcmu-runner-1.4.1
When ceph pool is fault, it will return timeout to tcmu-runner, and create a recovery thread and disable the tpg. The device can only be added into tpg->devs one time in tcmu_add_dev_to_recovery_list called by tcmu_notify_conn_lost. But from the logs, the device maybe added into tpg->devs more than one times:

2019-12-30 17:54:47.797 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.799 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.808 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.810 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.828 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.830 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.869 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.871 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.876 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.878 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.878 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.880 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
2019-12-30 17:54:47.888 12783 [ERROR] tcmu_rbd_handle_timedout_cmd:996 rbd/mixpool.vlmix: Timing out cmd.
2019-12-30 17:54:47.890 12783 [ERROR] tcmu_notify_conn_lost:209 rbd/mixpool.vlmix: Handler connection lost (lock state 1)
Maybe cause:
The ret in tcmu_add_dev_to_recovery_list not inited, if it finds the tpg on tpg_recovery_list, it will goto the add_to_list and will return the ret that is not inited. And it will not set the flags with TCMUR_DEV_FLAG_IN_RECOVERY.  When come timeout again, it maybe add the same device into the tpg->devs twice times. When the recovery thread tgt_port_grp_recovery_thread_fn process the tpg->devs with list_for_each_safe,  it always get the same node that added twice times.

The ret in tcmu_add_dev_to_recovery_list not inited, if it finds the tpg on tpg_recovery_list, it will goto the add_to_list and will return the ret

ret is not initialized at the top of the function. It will be zero if we get to:
        /*
         * This assumes a tcmu_dev is only exported though one local
         * enabled tpg. The kernel members file only returns
         * the one and runner is not passed info about which
         * tpg/port IO was received on.
         */
        list_for_each(&alua_list, group, entry) {

because a couple lines above that we do:
        list_head_init(&alua_list);
        ret = tcmu_get_alua_grps(dev, &alua_list);
        if (ret) {
                /* User is deleting device so fast fail */
                tcmu_dev_warn(dev, "Could not find any tpgs.\n");
                goto done;
        }

so if tcmu_get_alua_grps returns failure, ret will non-zero and we will hit the "goto done". If that function returns success, ret will be zero, and then we will continue to run the function and do the loop above. If the loop detects the port is on the recovery list already then we will return 0. tcmu_notify_conn_lost should then set the TCMUR_DEV_FLAG_IN_RECOVERY bit.

Are you hitting one of the errors paths in tcmu_add_dev_to_recovery_list where ret != 0?  If you did, we would normally see another error message, but there are those 2 cases where we log a warning only:
                /* User is deleting device so fast fail */
                tcmu_dev_warn(dev, "Could not find any tpgs.\n");

or do not log anything:
        tpg = setup_tgt_port_grp(enabled_port);
        if (!tpg) {
                ret = -ENOMEM;
                goto done;
        }

We use tcmu-runner that version is 1.4.1, But we patch the code https://github.com/open-iscsi/tcmu-runner/pull/596, so it does not have the list code in tcmu_add_dev_to_recovery_list:
list_head_init(&alua_list);         ret = tcmu_get_alua_grps(dev, &alua_list);         if (ret) {                 /* User is deleting device so fast fail */                 tcmu_dev_warn(dev, "Could not find any tpgs.\n");                 goto done;         }

We use tcmu-runner that version is 1.4.1, But we patch the code #https://github.com/open-iscsi/tcmu-runner/pull/596, so it does not have the list code in tcmu_add_dev_to_recovery_list:
list_head_init(&alua_list);
	ret = tcmu_get_alua_grps(dev, &alua_list);
	if (ret) {
		/* User is deleting device so fast fail */
		tcmu_dev_warn(dev, "Could not find any tpgs.\n");
		goto done;
	}

Ah ok, I am working on a different patch for 596 which will fix the other bug you reported where we can still deadlock during deletion. I am on vacation until Jan 6th. When I am back next week I will post a new PR with a fix for all the issues.
I uploaded a updated version of the 596 patch in that PR patch with the "ret = 0" issue change, if you need a quick temp fix.
Going to close this since it's not related to the upstream code or a release and is a bug with a specific PR that is still open.


Multiline comment inserts extra # > even if I already have closing tag

When I add a multiline PowerShell comment, and then add a new line in the middle, an extra character is added automatically.
I end up with this:
<#
    .SYNOPSIS
        Some text
    # > # <- this keeps getting added each time I try to add a new line
    # >
#>

I think this is a duplicate of #183. That is already closed, but the fix is not yet released; I am preparing some final patches for the upcoming release. If everything goes as planned, it should be available in a few days.

But now wait a minute. The fix is supposed to be in 2.5.0. What plugin version do you use?

I updated to the latest plugin version today and this appears to be fixed. Thanks. We can close this out


When connecting with Graphana

Version <IP_ADDRESS>
When querying from Graphana, I see this in the logs.
2018-04-06 20:39:08,305 ERROR [elasticsearch[<IP_ADDRESS>][search][T#140]] org.apache.cassandra.service.CassandraDaemon$2.uncaughtException(CassandraDaemon.java:231) Exception in thread Thread[elasticsearch[<IP_ADDRESS>][search][T#140],5,main]
java.lang.NoClassDefFoundError: Could not initialize class org.elasticsearch.painless.WriterConstants
Is this a plugin missing?

This is partially fixed by https://github.com/strapdata/elassandra/commit/8667ae48a501c7a1830e1f4b09115da04af40ddd https://github.com/strapdata/elassandra/commit/8667ae48a501c7a1830e1f4b09115da04af40ddd in release <IP_ADDRESS>
In fact, both cassandra and elasticsearch needs asm jar to execute CQL functions or elasticsearch scripted fields, but elasticsearch scripts runs in a separated class loader.
So, it seems that asm jar is available only form the system OR the ES plugin classpath, depending on class loading order.
This is an issue to provide support for both CQL functions and scripted fields.

Le 6 avr. 2018 à 22:47, rsliotta<EMAIL_ADDRESS>a écrit :
Version <IP_ADDRESS>
When querying from Graphana, I see this in the logs.
2018-04-06 20:39:08,305 ERROR [elasticsearch[<IP_ADDRESS>][search][T#140]] org.apache.cassandra.service.CassandraDaemon$2.uncaughtException(CassandraDaemon.java:231) Exception in thread Thread[elasticsearch[<IP_ADDRESS>][search][T#140],5,main]
java.lang.NoClassDefFoundError: Could not initialize class org.elasticsearch.painless.WriterConstants
Is this a plugin missing?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/182, or mute the thread https://github.com/notifications/unsubscribe-auth/AJzHmTiAe2iYucdPHOOT2yMK6800HXaQks5tl9R6gaJpZM4TKrvk.

Vincent,
Is there a parameter to add to Elassandra to see the ES queries?
We are running Graphana and getting strange results if you are setting up a dashboard.  Not on all of them but some.
We are trying to debug it...
Get Outlook for iOShttps://aka.ms/o0ukef
On Sat, Apr 7, 2018 at 6:02 PM -0400, "Vincent Royer" <notifications<EMAIL_ADDRESS>wrote:
This is partially fixed by https://github.com/strapdata/elassandra/commit/8667ae48a501c7a1830e1f4b09115da04af40ddd https://github.com/strapdata/elassandra/commit/8667ae48a501c7a1830e1f4b09115da04af40ddd in release <IP_ADDRESS>
In fact, both cassandra and elasticsearch needs asm jar to execute CQL functions or elasticsearch scripted fields, but elasticsearch scripts runs in a separated class loader.
So, it seems that asm jar is available only form the system OR the ES plugin classpath, depending on class loading order.
This is an issue to provide support for both CQL functions and scripted fields.

Le 6 avr. 2018 à 22:47, rsliotta<EMAIL_ADDRESS>a écrit :
Version <IP_ADDRESS>
When querying from Graphana, I see this in the logs.
2018-04-06 20:39:08,305 ERROR [elasticsearch[<IP_ADDRESS>][search][T#140]] org.apache.cassandra.service.CassandraDaemon$2.uncaughtException(CassandraDaemon.java:231) Exception in thread Thread[elasticsearch[<IP_ADDRESS>][search][T#140],5,main]
java.lang.NoClassDefFoundError: Could not initialize class org.elasticsearch.painless.WriterConstants
Is this a plugin missing?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/182, or mute the thread https://github.com/notifications/unsubscribe-auth/AJzHmTiAe2iYucdPHOOT2yMK6800HXaQks5tl9R6gaJpZM4TKrvk.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/strapdata/elassandra/issues/182#issuecomment-379502301, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AQ-uqzg-yc-i4OKuLWtfUdKAVihuTBuiks5tmTdHgaJpZM4TKrvk.
NVOCC Services are provided by CEVA as agents for and on behalf of Pyramid Lines Limited trading as Pyramid Lines.
This e-mail message is intended for the above named recipient(s) only. It may contain confidential information that is privileged. If you are not the intended recipient, you are hereby notified that any dissemination, distribution or copying of this e-mail and any attachment(s) is strictly prohibited. If you have received this e-mail by error, please immediately notify the sender by replying to this e-mail and deleting the message including any attachment(s) from your system. Thank you in advance for your cooperation and assistance. Although the company has taken reasonable precautions to ensure no viruses are present in this email, the company cannot accept responsibility for any loss or damage arising from the use of this email or attachments.

The Issue was the datatype being used in Graphana's 5.5 driver.  No Issue with Elassandra!

Shorts are not supported in Graphana with elasticsearch 5.5


Hazelcast-based implementation for SAMLMessageStore

Reference discussion: https://groups.google.com/g/pac4j-dev/c/KK1lQy6kaYM/m/D0UU4i2NBQAJ

Excellent! Thanks


feat: Add a logical clock to all the messages created within an actor

Pull Request Test Coverage Report for Build 52

20 of 22 (90.91%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 87.423%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ActorSystem.ts
17
19
89.47%

Totals

Change from base Build 51:
-0.1%

Covered Lines:
208

Relevant Lines:
232

💛  - Coveralls

:tada: This PR is included in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Simplified diagram of baselines layers and dID interaction.

Please assign this to me! We can include this diagram in our scope.

@jack-garvin -- please get together with @awoie and @italobb and @caleteeter to properly address this issue. Thank you!

Can you or someone Assign us to the Issue?

@jack-garvin, @AshCos - @awoie is working on #28. Please let us ensure that there is no duplicate work happening as there may be some overlap here.


Feat/mono repo

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This pulls in the various integration libraries to make this a mono repo.

What is the current behavior? (You can also link to an open issue here)

With the libraries being in separate repositories, it makes versioning them more complex, and it makes it obvious what versions should be used for any version of core.

What is the new behavior (if this is a feature change)?

This will allow us to version and maintain core and the libraries as a single unit. They will follow the same release cycle, and have matching version numbers.
We can also be clearer about what constitutes a breaking change in the libraries, as it is only breaking if it breaks the api for consumers, not what core has to implement.

Other information:

TODO

[x] Discuss workflow with team
[x] typedoc - we want this for at least blueprints
[x] fix failing core version tests
[x] codecov - ensure is ok for core portion
[x] add npm deploy token
[x] skip npm publish if no token? (for prs/forks)
[x] Add readme to packages dir
[x] Add documentation on working to main readme
[ ] update, rename and tidy the absorbed libs

Status

[ ] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Thanks, this is exactly what I was hoping for in a review here :)
Startup
That is strange, I have tested that myself and it does start. Maybe some quirk of a different os? Ill do some digging.
Shared API between core and integration
I am expecting that to become a follow up task. I know Johan had some concerns about the dependencies that using server-core-integration directly would pull into core (ddp client), so I have opted to not do anything on this for now.
Local linking
Perfect
Typedoc documentation
Yeah, there isnt an explicit script as I didn't think anyone would run it locally. There is a ci step to generate and publish this on the master branch. Running yarn typedoc inside the packages folder will produce the docs folder containing both libraries. I shall add a script in case it is wanted.

Codecov Report

Merging #337 (e6cd9b8) into release27 (9f35005) will increase coverage by 0.40%.
The diff coverage is 81.86%.

@@              Coverage Diff              @@
##           release27     #337      +/-   ##
=============================================
+ Coverage      66.81%   67.21%   +0.40%
=============================================
  Files            192      203      +11
  Lines          12950    13785     +835
  Branches        3046     3223     +177
=============================================
+ Hits            8652     9266     +614
- Misses          4227     4352     +125
- Partials          71      167      +96

Impacted Files
Coverage Δ

.../server-core-integration/src/lib/coreConnection.ts
75.78% <75.78%> (ø)

...kages/server-core-integration/src/lib/ddpClient.ts
75.83% <75.83%> (ø)

...ckages/server-core-integration/src/lib/timeSync.ts
78.87% <78.87%> (ø)

...ckages/server-core-integration/src/lib/watchDog.ts
79.48% <79.48%> (ø)

meteor/server/coreSystem.ts
69.95% <80.76%> (-0.97%)
:arrow_down:

...es/server-core-integration/src/lib/ddpConnector.ts
90.36% <90.36%> (ø)

packages/blueprints-integration/src/util.ts
100.00% <100.00%> (ø)

packages/server-core-integration/src/index.ts
100.00% <100.00%> (ø)

.../server-core-integration/src/lib/configManifest.ts
100.00% <100.00%> (ø)

...server-core-integration/src/lib/corePeripherals.ts
100.00% <100.00%> (ø)

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f35005...e6cd9b8. Read the comment docs.

Approved due to:

issues with Quick Start was a local meteor install corruption, not this repo
shared API between core and core-integration package can be a topic of further discussion
the build of the documentation for the packages is now working and has a script


Jenkins: How to pass SSH keys for pulling private repositories as secretVolume ?

Is this a request for help?:
Yes
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Version of Helm and Kubernetes:
Helm: 2.6.1
Kubernetes: 1.7.2
Which chart:
Jenkins
What happened:
I am trying to mount ssh keys to access private repositories inside agent containers using SecretVolume.
When specifying like this
Agent:
  volumes:
    - type: Secret
      secretName: ssh-key
      mountPath: /home/jenkins/.ssh

All the files like id_rsa and id_rsa.pub gets mounted as 0777 as symbolic links.
Cloning private repositories fail because it expects the permission of id_rsa to be 0400.
What you expected to happen:
I would like to specify the permissions of mountpoint.
How to reproduce it (as minimally and precisely as possible):
Simply use jenkins chart with Agent.volumes specified
Anything else we need to know:

Hi, can someone please help in achieving this. Thanks.

Did you find any solution for this?

@pimeys i used a workaround by changing the permission in the entrypoint script like this
  if [ -f /home/jenkins/.ssh/id_rsa ]; then
    echo "Setting correct permission for jenkins ssh private key"
    chmod 600 /home/jenkins/.ssh/id_rsa
  fi

/reopen


Thumbnail filename extension gets ignored

[x] I've verified and I assure that I'm running youtube-dl 2018.03.14

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--write-thumbnail', '--skip-download', '-o', '1.thumbnail', 'https://www.youtube.com/watch?v=APqFDseaF7o']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.03.14
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] APqFDseaF7o: Downloading webpage
[youtube] APqFDseaF7o: Downloading video info webpage
[youtube] APqFDseaF7o: Extracting video information
[debug] Default format spec: best/bestvideo+bestaudio
[youtube] APqFDseaF7o: Downloading thumbnail ...
[youtube] APqFDseaF7o: Writing thumbnail to: 1.jpg
Description of your issue, suggested solution and other information
I want to decide which extensions  gets used for the thumbnail.  But when I put -o image.thumbnail in the command, the created file always will be image.jpg or image.png. How can I overwrite the filename extension?

Short: you can't. You'll always get the actual thumbnail's extension. Forcing extensions is also completely senseless since this won't change actual image format anyway.

No this is actual quite important. I'm write a gui program which offers a thumbnail preview. When the file format can alway be different I always need to search the whole directory. With a pseudo file extension like .thumbnail I can let my ImageHandler decide which format it is. I'm sure this wouldn't be much work to do, since the %(ext)s operator is already implemented, so just deactivate it by default?


Add "Filmography" macro

Will fetch all movies with this actor in the cast and render first image of each movie + title.

Related https://github.com/enonic/app-contentstudio/issues/6115


Feature/homepage hero

Ticket: trello ticket

Add markup for homepage hero component
Add styles
Add webfonts to the page

Please use a single language, ideally english for your commit list from here on.

 HERO SECTION [1] - As a user i need an initial section to land and have a clear idea of the business and look of "Las paisas" hostel


How to install amuse in Windows?

the recommended way of installing AMUSE on windows (10 only) is through the windows subsystem for linux (WSL) 2, is that an option?

yes ok, whatever is the best way.

ok, then the procedure is as follows:

install WSL 2 as per microsoft instructions (https://docs.microsoft.com/en-us/windows/wsl/install-win10#update-to-wsl-2 )
install ubuntu (or another linux distro) from the windows store
start up the ubuntu image and follow the AMUSE install instructions for linux

I can confirm this works fine on Windows 10 using the Ubuntu distro install from the Windows Store. This includes installing via pip although compiling from source can help fix any errors that come up.
~ Joe G.

Multipass (https://multipass.run) is another way of installing Ubuntu (on Windows, but also on macOS and even Linux). This works very well in my limited experience so far.

closing as solved
vagrant is another option btw


remove -garbage-collect and -delete-extra-tags flags

Also make the Manifest type hold more information (this is in preparation for solving #64).
Fixes #63.

/assign @justinsb

Awesome stuff.  Take a gander at the comments and then feel free to remove hold...
/lgtm
/hold

/assign @amy

/lgtm

Gonna wait this out while waiting for @amy to chime in as well.

/uncc

/lgtm

/lgtm

/hold cancel


didChangeAppLifecycleState resume method executed multiple times

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Using didChangeAppLifecycleState code in main.dart
on simulator/emulator or on actual device move the app to background or terminated state
open the app again
Check the logs in

  void didChangeAppLifecycleState(AppLifecycleState state) async {
    switch (state) {
      case AppLifecycleState.resumed:

case  AppLifecycleState.resumed. It is executed multiple times.
Expected results
AppLifecycleState.resumed should run only once.
Actual results
AppLifecycleState.resumed should is running multiple times. Mostly two times
Code sample
Code sample

@override
  void didChangeAppLifecycleState(AppLifecycleState state) async {
    switch (state) {
      case AppLifecycleState.resumed:
        //This state is called each time when app moves from background to foreground no need to do these additional things
        Eraser.clearAllAppNotifications();
        if (!_isResumed) {
          await _lock.synchronized(() async {
            _isResumed = true;
            print('resumed method called main ::  1 ${_isResumed}');
            setState(() {
              _showSplashScreenLoadingForChatItems = true;
            });
            try {
              await performResumedOperations();
            } catch (e) {
              printFun(
                  message: e.toString(),
                  file: 'mainTabs',
                  functionName: 'initApp');
            } finally {
              setState(() {
                _showSplashScreenLoadingForChatItems = false;
                _isResumed = false;
              });
            }
            setState(() {
              _showSplashScreenLoadingForChatItems = false;
            });
          });
        }

        break;

      case AppLifecycleState.inactive:
        _isInForeground = true;
        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      case AppLifecycleState.detached:
        _isInForeground = false;
        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      case AppLifecycleState.paused:
        _isInForeground = false;
        _isResumed = false;

        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      default:
    }
    super.didChangeAppLifecycleState(state);
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs

3 I/flutter (17338): resumed method called main ::  1 true

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.3.9, on macOS 13.3 22E252 darwin-arm, locale en-US)
    • Flutter version 3.3.9 on channel stable at /Users/bilalrabbi/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (8 months ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/bilalrabbi/Library/Android/sdk
    • Platform android-33, build-tools 33.0.1
    • ANDROID_HOME = /Users/bilalrabbi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.79.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.68.0

[✓] Connected device (2 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 12 (API 32) (emulator)
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 114.0.5735.198

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Thanks for the report @bilalgodesto
Can you upgrade to latest stable or master and run your scenario again to check if the reported behavior still persists or not ?

Thanks for the report @bilalgodesto Can you upgrade to latest stable or master and run your scenario again to check if the reported behavior still persists or not ?

just tried upgrading flutter to 3.10.5, and it can still be reproduced

@bilalgodesto
Please check https://github.com/flutter/flutter/issues/130055 and see if it resonates with your scenario or not.

@darshankawar
In my case didChangeAppLifecycleState resume state is called multiple times on both android and ios

Updated to latest SDK but still same issue
[✓] Flutter (Channel stable, 3.10.5, on macOS 13.3 22E252 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.3)
[✓] VS Code (version 1.79.2)
[✓] Connected device (3 available)
[✓] Network resources

Thanks for the update @bilalgodesto .
I used below code sample with which the resumed state is printed only once as below when the app comes back to foreground:
I/flutter ( 6914): AppLifecycleState.inactive
D/EGL_emulation( 6914): app_time_stats: avg=4645.98ms min=2.70ms max=9289.26ms count=2
I/flutter ( 6914): AppLifecycleState.hidden
I/flutter ( 6914): AppLifecycleState.paused
I/flutter ( 6914): AppLifecycleState.hidden
I/flutter ( 6914): AppLifecycleState.inactive
I/flutter ( 6914): AppLifecycleState.resumed

 runnable code sample

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatefulWidget {
  MyApp({Key? key}) : super(key: key);

  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> with WidgetsBindingObserver{
  String latestState = "";

  @override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addObserver(this);
  }

  @override
  void dispose() {
    WidgetsBinding.instance.removeObserver(this);
    super.dispose();
  }

  @override
  void didChangeAppLifecycleState(AppLifecycleState state) {

    switch(state) {
      case AppLifecycleState.resumed:
      //  print('app resumed');
    }
    print(state.toString());
    setState(() {
      latestState = state.toString();
    });
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text("DEMO - didChangeAppLifecycleState"),
        ),
        body: Center(
          child: Text('Latest state: $latestState'),
        ),
      ),
    );
  }
}

Check the same at your end and confirm the behavior.

It is still happening when we use async code  in  didChangeAppLifecycleState resume
happening in both IOS and android
  @override
  void didChangeAppLifecycleState(AppLifecycleState state) async {
    switch (state) {
      case AppLifecycleState.resumed:

        if (!_isResumed) {
          _isResumed = true;
          try {
            await performResumedOperations();
          } catch (e) {

          } finally {
            setState(() {
              _showSplashScreenLoadingForChatItems = false;
              _isResumed = false;
            });
          }
        }

        break;

      case AppLifecycleState.inactive:
        _isInForeground = true;
        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      case AppLifecycleState.detached:
        _isInForeground = false;
        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      case AppLifecycleState.paused:
        _isInForeground = false;
        _isResumed = false;

        await FireStoreUtils.updateUserOnlineStatus(status: false);
        break;

      default:
    }
    super.didChangeAppLifecycleState(state);
  }

Thanks for the update.

void didChangeAppLifecycleState(AppLifecycleState state) async {

I see that you are making this method async which is something not mentioned in the documentation.
Also, check the official example in which too, it isn't async call:
If you remove async, do you still get same behavior ?


Add more useful sample datasets

Add more sample datasets that could e.g. be used for more relevant analytics tasks, e.g. time-series data, user/usage data, ...
Possible sources:

https://github.com/ozlerhakan/mongodb-json-files

Moved to https://github.com/tfreundo/airflow-dev-env-mongodb/issues/3


feat: add link to logo

Adding a link back to the homepage when the logo in the left upper corner is clicked.
format files

Looks Good to me, but UserPreview.stories.js, and Navbar.stories.js, do not have any measurable changes, not sure why these are included in the PR!

I ran formatter on the project and those files changed


Feature/loading bg color

Change listview loading background to white
Remove unnecessary description

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   81.81%   81.81%
=======================================
  Files           2        2
  Lines          55       55
  Branches       12       12
=======================================
  Hits           45       45
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4572a...37b9605. Read the comment docs.


Unable to create vm using unmanged disk in azure using terraform

Hello team,
i was facing issues while creating vm using storage account using terraform and hoping that you guys can definitely help me out , please find my tf file from my git-hub repo from below mention link
click here
and you can even find error logs attached to this issue
error.log
thanks in advance
with regards
Bhaskar Degala

Hi ..  here are couple of things to be corrected ..
1...on file publicip.tf -- correct location value ..make sure not to hardcode once u make it as variable .
location            = "${var.location}"

Reg storage account - unmanaged disks
u can create VHDs and attach them as data disks but not as OS disks . As OS disks get created by cloning from the image files , so pre-created blank disks doesnt work here .
below is what u need to modify to add in the VM file from ur storage account

storage_os_disk {
name          = "vm-osdisk"
caching       = "ReadWrite"
create_option = "FromImage"
os_type       = "linux"
vhd_uri       = "https://learningbhaskar123.blob.core.windows.net/vhds/web-osdisk.vhd"
}
storage_image_reference : can be same .
leave "azurerm_storage_container" as it is and
u can just comment out all the VHD creations section , if u dont want to add data disks .
attaching those 2 file .. note .. i have tried creating one VM and commented out rest to check . And it worked well(attached screenshot)

.
Hope i didnt forget any , as i did couple of modification . please update if it didnt work .
vm.txt
storageaccount.txt

Also one other thing on storageaccount.tf
all disk attribute names are given same as sample.vhd , u need to change it they should be different .

Hi ..
here are couple of things to be corrected ..
1...on file publicip.tf -- correct location value ..make sure not to hardcode once u make it as variable .
location = "${var.location}"

Reg storage account - unmanaged disks
u can create VHDs and attach them as data disks but not as OS disks . As OS disks get created by cloning from the image files , so pre-created blank disks doesnt work here .
below is what u need to modify to add in the VM file from ur storage account

storage_os_disk {
name = "vm-osdisk"
caching = "ReadWrite"
create_option = "FromImage"
os_type = "linux"
vhd_uri = "https://learningbhaskar123.blob.core.windows.net/vhds/web-osdisk.vhd"
}
storage_image_reference : can be same .
leave "azurerm_storage_container" as it is and
u can just comment out all the VHD creations section , if u dont want to add data disks .
attaching those 2 file .. note .. i have tried creating one VM and commented out rest to check . And it worked well(attached screenshot)

.
Hope i didnt forget any , as i did couple of modification . please update if it didnt work .
vm.txt
storageaccount.txt

Vineela , thank you so much for your reply, sorry about that 1st error I some how missed it while changing it to variables .
For vhd url i thought that we need to give a created blob url
And once again thank alot

Also one other thing on storageaccount.tf
all disk attribute names are given same as sample.vhd , u need to change it they should be different .
Ho no I missed that , thanks for your intimation
And I think I have given different names

Hey Vineela i have a query
actually my os_disk has no dependency on storage account or at least container and by default terraform can execute 10 resources at a time and in some case if my vm tries to create before storage account then it will throw a error that it can not find storage account can you please explain me how to resolve this sort of scenario and create dependency and i could no find any argument to create dependency in os_disk
thanks in-advance
with regards
Bhaskar

yes , i hope u can create dependency like "https://${azurerm_storage_account.trial.name}.blob.core.windows.net/vhds/web-osdisk.vhd"
havent tested it , i hope this should work .. if not need to check some thing else .

Yes I have already tried that and it worked , but I thought we can have some arguments to use storage account attributes
And any how thank you for your time for resolving the issue and it helped me

I found resolution for dependency
We can use depends_on argument in one resource to depend on other resource

excellent.. thanks for sharing..


BUG: Video texture alpha differs by platform

This simple video code on Linux using this file:

import numpy as np
import pyglet
from pyglet import gl
window = pyglet.window.Window()
player = pyglet.media.Player()
source = pyglet.media.StreamingSource()
media = pyglet.media.load('example-video.mp4')
player.queue(media)
player.play()

@window.event
def on_draw():
    window.clear()
    if player.source and player.source.video_format:
        tex = player.get_texture()
        global rawimage
        rawimage = tex.get_image_data()
        fmt = 'RGBA'
        assert rawimage.format == fmt
        pitch = rawimage.width * len(fmt)
        pixels = rawimage.get_data(fmt, pitch)
        data = np.frombuffer(pixels, np.uint8).reshape(rawimage.height, rawimage.width, len(fmt))
        print(data[..., -1])
        print(data.shape)
        gl.glEnable(gl.GL_BLEND)
        gl.glBlendFunc(gl.GL_SRC_ALPHA, gl.GL_ONE_MINUS_SRC_ALPHA)
        tex.blit(0, 0)
    else:
        pyglet.app.exit()

pyglet.app.run()

Produces a correct video output:

And correct alpha channel in the texture if you pull the data (all 255's):
...
[[255 255 255 ... 255 255 255]
 [255 255 255 ... 255 255 255]
 [255 255 255 ... 255 255 255]
 ...
 [255 255 255 ... 255 255 255]
 [255 255 255 ... 255 255 255]
 [255 255 255 ... 255 255 255]]
...

But on Windows, it produces an all black image, and the alpha channel is all zeros:
[[0 0 0 ... 0 0 0]
 [0 0 0 ... 0 0 0]
 [0 0 0 ... 0 0 0]
 ...
 [0 0 0 ... 0 0 0]
 [0 0 0 ... 0 0 0]
 [0 0 0 ... 0 0 0]]

This was discovered because blitting does not work for this video/texture on Windows when blending is enabled (because alpha is zero).
This suggests that there is some difference in the FFMPEG->texture extraction on Windows compared to Linux.

Turns out this is a WMF problem, not ffmpeg, so I re-titled this

This was fixed by #534. No idea why my magic tag in the PR description did not close this issue.


Native modules

Description
This PR removes redundant dependencies such as colorLogger in favor of @wdio/logger and also gets rid of bluebird in favor of native Promise.

Additionally tests are rewritten to use async/await and chai
debug flag in configuration is deprecated in favor of logLevel

Checklist

[ ] Unit/Integration test added (if applicable)
[X] Documentation added/updated (wiki or md)
[X] Code style is consistent with the rest of the project

LGTM , great job! 👍

@stsvilik After this I can actually start debugging the test Promise errors. Last time I got lost in the bluebird stack.
I can create a separate issue for these:
(node:1188) UnhandledPromiseRejectionWarning: undefined
(node:1188) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 3)

@serbanghita I think those are not a problem - it is caused by using sinon stubs and returning Promise.reject()

@serbanghita I fixed those pesky Promise errors ;)

@stsvilik great job! 🍾

@stsvilik do you release the tag manually in npm?

manually


Make connection adapter for array slices

The existing connectionFromArray requires an array representing all the records in a connection. Actually materializing such an array may be prohibitively expensive when dealing with large connections (containing thousands of items, or more). This largely defeats the purpose of pagination, which is supposed to free us from having to deal with total data sets when subsets suffice.
At the moment, it is possible to do some ghastly workarounds to trick connectionFromArray into thinking it has a fully materialized array. For example:
const paddedItems = new Array(offset).concat(...items);
if (count > offset + args.first) {
  paddedResults.length++;
}
const connection = connectionFromArray(paddedItems, args);

In other words, we create an array with, say, 1000 empty slots, then insert the 10 items actually retrieved, then increment the length property on the array to trick connectionFromArray into thinking that hasNextPage should be true.
This commit seeks to address this common use case by implementing connectionFromArraySlice. This effectively allows you to fetch the data for a subset of a connection, and pass that in with some metadata indicating where the subsequence starts and how long the total array would be if materialized, and get a connection object back.
We also add connectionFromPromisedArraySlice, for parity with connectionFromPromisedArray, and we reimplement the existing connectionFromArray to call through to the new function.
All specs pass, except one, which I actually think is a bug in the old implementation, so I changed it. The test case uses first: 0 with no before or after. Previously, the code returned hasNextPage: false, but according to the spec, it seems it should actually return true.
HasNextPage is specified as follows:

If first was not set, return false.
Let edges be the result of calling ApplyCursorsToEdges(allEdges, before, after).
If edges contains more than first elements, return true.
Return false.

Given that there are no before or after calls, and ApplyCursorsToEdges specifies that allEdges should be returned in this case, it seems we should be returning true as per step 3 above.
One final thing to note: I've exported cursorToOffset as it can be useful to schema authors when they prepare array slices suitable for passing in to connectionFromArraySlice.

Adding some Relay peeps: @steveluscher, @yungsters, @josephsavona.
I'll add a separate test for connectionFromPromisedArraySlice which I think should satisfy the coverage complaint.

:+1:


Add full wide view mode

Thanks Global Custom CSS plugin

[x] UI layout
[ ] Support wide mode (Change size)

won’t fix

Check plugins

Column Layout (original sidebar)

[x] release new version for support

[x] tabbed sidebar

https://github.com/YU000jp/logseq-page-tags-and-hierarchy/commit/7e6a428126a847b8f2716fc7019c335582ef6342


User flow

https://www.figma.com/file/Ejq2QLCf1dHh2jNlgXKiaC/Project-Team-8-Design?node-id=521%3A3

https://www.figma.com/file/q4lyIe3HeFY22wFikSgS5B/TEAM-8---AUTH-WIKI?node-id=31%3A436
https://www.figma.com/file/q4lyIe3HeFY22wFikSgS5B/TEAM-8---AUTH-WIKI?node-id=0%3A1


Add --float16 (was --float-16) to llama-cli and associated support to llama-rs

This change adds a --float-16 flag which allows using a 16 bit float for the model memory key and value tensors.
The --float-16 flag enables it for both K and V, however internally it is possible to set it independently (I don't know why you'd want to, but...)
In addition to saving memory, this change only reduces the size of the cached prompt by about 50% when enabled.
Should complete #51.

I am not sure if I am understanding/testing this right but the following command:
cargo run --release -- --model-path ~/Downloads/LLaMA/7B/ggml-model-f16.bin -f examples/alpaca_prompt.txt -R --float-16

use the same amount of memory (as reported by htop), ~12G on my machine, with or without --float-16

@RCasatta
The default context size is 512, which means with 32bit it would be around 512MB, with 16bit it would be 256MB. That may not be a big enough change to notice from htop depending on how it's rounding the memory sizes. Try with --num-ctx-tokens 2048 and you should notice a bigger difference. You can also try using --cache-prompt FILENAME with a prompt specified and observe how the output file changes size depending on whether the flag is on or off.

@philpax
No problem. I can make those changes, however other code (the caching stuff) is using serde::Deserialize and serde::Serialize. So I would need to change the imports to bring it into scope and then it probably would make sense to change the other code using Serde to use that as well. I was trying to keep the scope of the changes small.
Changing the name of the flag is certainly no issue. What do you want me to do about the Serde stuff?

What do you want me to do about the Serde stuff?

The code is using the same style of the other structs. So I'd say we can just merge this and sneak in a change to use serde::{Serialize, Deserialize} in another PR.
I'll just have a quick look at the diff first :eyes:

Thanks a lot for this BTW! :smile:

Happy to contribute!


Add run file for Hampstead

The NH State file isn't as complete as it claims to be.
This adds a custom bash script for processing the Hampstead municipality.

re-run this please

re-run this please

re-run this please


CLOUD-54639 Fix NPE during router creation on non existing openstack …

@keyki plz review

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2282/


Rebuild networking to use TCP vs UDP

The UDP systems requires bonding of ports to a selected number, and if/when the app crashes the port may get leaked. The TCP system requires only one socket to run, (two, if multicast is enabled) one in UDP mode for listening for a multicast. The UDP is also using hardcoded strings for IP addresses in stead of relying on validated user input.
What I have done:

[x] Re-build the networking components to use the TCP mode, instead of UDP
[x] Re-factor out the old systems
[x] Write a new data exchange protocol
[x] Add options about simulation to the settings menu

What doesn't work:

[x] Thread safety is apperently not so good (the Android App is throwing a ConcurrentModificationException, which shutdowns the server) EDIT: Not quite: according to Android App thread dumps I am getting caught in a dead spin when I reimplemented the storage queue with a proper object designed for this usage (the old invalidated the iterator in my foreach, when the data got changed from a different thread)
[x] Console is overflowing - the amount of data being sent and received is causing the console output to noticeably slowdown the application, it is taking its sweet time to catch back up after running for more than a few seconds (right now, one minute of running takes the console writer ten minutes to do) Code to display full data is commented out, otherwise it has an adepquate speed now
[x] The device list getter/setter doesn't work just yet (probably because of problem one) Is XML Deserializer working?
[ ] Commenting (a need to add quite a few of those)

What we need to do:

[x] figure out what is happening when a Concurrent Modification Execption gets fired

[x] see what happens when above is fixed see what happens when if it works

[x] Log the packet data and only display the important details if necessary

[ ] Add a way of turing debug mode on/off*

[ ] Get and validate user input for an IP address if multicasting is off or fails*

[ ] Add an option to turn multicasting on or off*

[x] Add more ways to Stop / restart the Simulator*

[x]  Fix any leaking memory (when the client is left running it caches everything until it gets processed) I have trimmed the memory usage of my side down from 2.5GB to 100MB (client) and 100MB to 16MB (my side) (that's what I get for forgetting to remove a section of the mirror protocol, plus having high data retention policy)

[ ] Figure out why the networking is acting buggy
*since you are maintaining the interface, I would recommend you the do the following

I opened this early so I could get feedback from you and to request changes, it is not ready to be considered alpha yet

I resolved the issue with the ConcurrentModificationException, so that a dead spin could show up.

Dead spin fixed, plus a few minor touchups to identify now your code is throwing: org.xml.sax.SAXParseException: Unexpected token (position:TEXT ?@1:2 in java.io.InputStreamReader@376a700e). I will go see if the data is valid in the parser, or just the code running the XML is expecting a new format of XML.

Thanks.  I'll start working on merging it into a branch to try it out.  I just committed a lot of changes trying to get the GUI working better along with some restructuring.

Sorry, about any delays, any ideas about any problems or have suggestions?

I am working out why the XML is getting corrupted by the exchange. How would the Device List exchange work best for you?

Hi,  I'm a little confused.  When you were working on your new networking code, I was also restructuring some of the classes and also I changed the package names to ftccommunity.  I then merged my new code into master.  When  you issued your 2nd pull request I took a look but saw that because I make so many changes that I had to do some work to merge it with my latest develop branch.  I haven't had a chance to merge it because I was working on getting the new ftc_app release working with the existing code.  I guess the XML parser stuff above is just added to your original networking code.   My question is, when you are working on your networking code, is it also merged with my latest master branch?

Some of the times, I am trying to stay somewhat recent, but I had to take a break (from coding) when you slightly before you started pushing, so I am trying to catch up. My side of Git went slightly nuts on this repo, so thats why there is multiple commits with the same comments.

Can I try to repackage some common items in it a module that both use? The current problem is that when the OpMode is switched it doesn't switch and it is stuck in the init phase.

I am finally looking at your code.  I have to catch up with all the work you did!  I did get the new SDK updated and working in a separate ftc_app repository along with changes on the PC side in my develop branch.

Okay, I figured out why it gets stuck in init, its completing a send then the client tries to reply back but a) the packet is getted corrupted b) the system for saving the packets is getting blocked or is not functioning, my bet is on the former. Right now commit a9ea7e0 is the best bet for looking at somewhat working code, the latest additions have the GUI closing cleanly, but the networking sections went all crazy, when I tried to optimize memory usage even more. I will try to get all of that protocol stuff functioning before I get the new app components folded in (so I don't have to work out both problems)

I tired your code but it seems I am missing the SimulatorData class.  Did you check that in or am I doing something wrong?

That is a problem. That file is generated from the protobuf/Data.proto. You can use the copy of it in the App, otherwise you can download protoc and rebuild the file, or you can wait a tad a bit for me to force the file to be there.

No problem.  I'll just get it from the App.  Thanks.

I am still figuring out why the client is not replying back to the server, but I improved/polished lots of things

The bug is apparently within the server receive Non-Heartbeat type. I validated the following components:

[x] Server - send

[x] Server -> Network Manger - send

[-] Server -> Network Manger - recieve

[ ] Server - recieve

[ ] Server - Heartbeat recieve*

[x] Encoder

[x] Decoder

[x] Client - send

[x] Client - recieve

[x] Client -> Network Manager - send

[x] Client -> Network Manager - recieve

[x] Client -> Heartbeat recieve

[x] Client -> Heartbeat send

[x] Decoder

[x] Encoder

Thanks.  I've been working on making sure I understand the communication between an actual Legacy Module and the Phone  Still trying to understand switching from read and write modes.

I am going to try to re-read the Netty and Protobuf documentation, and see if our software mentor can spot the bug. If all else fails, I am going to need fresh to eyes to spot that bug.

I seem to have fixed the problem bug, now we can see it gets stuck on init with waiting on the Simulator Device feedback. So, I probably missed something when I updated the simulator to the latest version, I designed the networking to be backwards-compatible with your code (as in the functions that handle specific things should have the exact same behavior as before). I did add the throwing of an Interrupted Exception to the functions that wait for user input, to allow safe termination. Can you specify an overview of how each component is networked, or evaluate your module code to see if I only partially changed something.

Sure, I will look at it right now.  After a lot of tracing with an actual device, I now understand more about what is going on in the modules.  Thanks.

Let me know, if you find the mistake. Do you want a layout of how everything works in the networking?

yes, if it is not too much trouble.  Thanks.

The Network Manager class takes care of keeping track of every send, and the received data. The received data is getting dumped into the Network Manager, then gets sorted by a "process queue" thread that moves everything to the right place. The Server/Client classes are Runnable classes that taking care of the bootstrapping the communications, it also handles the configuration options. The *Handler classes take on creating sends, and receiving things. The Decoder/Encoder classes change the Data class to a ByteBuf (an extension of the ByteBuffer) , and it gets written to the data stream, and vice versa.
Sending:
NetworkManager.requestSend (builds the Data object) - Handler -> NetworkManager.getNextSend() -> Encoder -> Data gets flushed to the stream
Receiving:
New data appears in the stream -> Decoder -> Handler -> NetworkManager.add - processQueue - getNextMessage (callable) (-> getNextData (gets the data encoded (used ASCII to encode)

-> Next object gets called immediately

This may or may not happen immediately

There should be a protocol.md that goes into the communcation

Have you gotten anywhere? I have been busy trying to get 4 teams started on the learning the new platform.

I am thinking that I already need to do a major rewrite of my own code to increase readability and performance.

Same here.  Working on getting started.  I have more time now.  I'll see what I can do.  I like what you did but I need to make some changes to merge it with the current code.

Okay, though what changes need to be made to push it to the current code, even you get settled down with this keep this pull request open, so we can collaborate on the optimization and rewriting the things that need to be rewritten

If you are still looking at this feed, can you rewrite and point me towards the MR USB communication protocols on the PC side? I can re-implement the hooks that you had previously to emulate devices, and rebuild the TCP stack to work correctly.

Hi!  I just saw your note.  Yes, I would like to get back into the simulator.  I need a few more weeks to see where we end up this season.  Thanks for your interest.

Sorry for responding 23 days after your reply. I'm busy with FTC and FRC as well, so my time is limited right now. But I should be free to help out sometime soon.


Loading continues

Hi,
When I try to translate from EN to another language, the cell shows "Loading" and the translation continues without any error message.   Could you please tell me what would be an issue?

Hi @sasamasama, this could be an error in the the retranslation-detection. Unfortunately it is still a little unreliable. The code line in question is line 57. The line looks like this:
    if (cell.getDisplayValue() !== "" && cell.getDisplayValue() !== "Loading...") {

You could try changing this line in your script to fix the problem.
First, try modify the loading text to match exactly what you see, for example:
    if (cell.getDisplayValue() !== "" && cell.getDisplayValue() !== "Loading") {

or secondly, you could disable this feature entirely, for example:
    if (false) {

Please let me know if that works for you.

Hi  @daniel-jones-deepl
Thank you very much for your prompt advice.
Modification didn't work but the disablement worked!
Thank you again!

Ok, great that disabling it worked. I'd advise you to look into the Copy-paste Values only section in the readme though, to avoid translating more characters than you plan.

Thank you and I will refer to the link provided and set the limit to avoid going over 500,000 characters.

@daniel-jones-deepl OK to close this issue after this week's update?


updated w2form docs and demos, improved w2form.applyFocus, Recompiled JS

updated w2form docs and demos, improved w2form.applyFocus, Recompiled JS

Also, please do separate PR for /dist/* file. Often it creates conflicts as I might have been building it locally, and if it is a separate request, it is easier to merge or ignore.


Build system not safe for parallel builds and makefile improvements

We received a bug report for Gentoo Linux[1], which seems to be related to  a parallel build issue.
From what I can see, the reason is, that in the all target, the libs and xephem goals can be called in parallel. The xephem target will usually have been compiled faster, than the list of libraries it depends on, which can lead to a race condition. Moving libs from all to the xephem target, should IMO resolve this. The source files for the xephem binary can be compiled ASAP, but the linking will only take place, once the libs target is finished. I have a PR open to fix it with this solution[2], but it's not yet verified to work.
In addition, and in response to https://github.com/XEphem/XEphem/issues/59#issuecomment-1243769710, in the libs target, using $(MAKE) -C <target> instead of cd ../../<target-dir>; make could also lead to an improvement regarding parallel builds. We already use this for our 4.1.0 package[3].
If desired, I can open a PR to patch any of these.
[1] https://bugs.gentoo.org/881813
[2] https://github.com/gentoo/gentoo/pull/28610
[3] https://github.com/gentoo/gentoo/blob/master/sci-astronomy/xephem/files/xephem-4.1.0-respect_env_vars.patch#L37-L45

The race condition disappears if one uses the GNU autotools and declares the libraries as SUBDIRS, such that they are built before the main/application program. This strategy is used within the Makefile.am in https://build.opensuse.org/package/show/home:rjmathar/xephem .


#1966 Adding Github Action for publishing multi-arch docker images

#1966 Adding Github Action for publishing multi-arch docker images
Github action that triggers docker image build and publish action upon:

merging into master using tag :master
creating a new Prism Release with tags: latest, ,

Additionally adding YARN_NETWORK_TIMEOUT to Dockerfile with default value set to Yarn's default. This extra argument increases network timeout for arm64 Docker image builds since QEMU emulation tends to be slow.
Addresses #1966
Summary
Currently, no ARM64 images are being published to DockerHub for Prism resulting in AMD64 emulation mode on ARM64 based systems.
Requirements
This Github action expects the following two secrets to be defined on the Github repository in order to push images to DockerHub:

DOCKERHUB_USERNAME
DOCKERHUB_TOKEN

Checklist

The basics

[x] I tested these changes manually in my local or dev environment

Tests

[ ] Added or updated
[x] N/A

Event Tracking

[ ] I added event tracking and followed the event tracking guidelines
[x] N/A

Error Reporting

[ ] I reported errors and followed the error reporting guidelines
[x] N/A

Testing Screenshots
Merge/Push to master:

Release Created:

Personal DockerHub build results:

@saturna thank you for the PR! We really like this and want to make this happen. However, our current build/deploy stuff is all in circleci and not github actions, so we'll need to convert this over to be done in circleci. Since there's not really a good way for community members to test circleci config changes, we'll have to prioritize this amongst our team when we have capacity.


Make point mass images to unsigned int

For some reason, point mass images are affected by the new code to transfer psi and kappa maps to python in 64bit float format.  Images should use 8bit integer consistently.  This seems to be the cause of #101

This was not the problem, see #101


Remove unused code

Pull Request Test Coverage Report for Build 7195

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.007%) to 33.84%

Files with Coverage Reduction
New Missed Lines
%

src/commons/application/reducers/SessionsReducer.ts
2
89.47%

Totals

Change from base Build 7188:
0.007%

Covered Lines:
2355

Relevant Lines:
6444

💛  - Coveralls


fix: prevent unnecessary overlay from being added while opening RIGHT_DOCKED modals

Details
This PR ensures that unnecessary overlay will not be added while opening RIGHT_DOCKED modals.
Fixed Issues
$ https://github.com/Expensify/App/issues/19073
PROPOSAL: https://github.com/Expensify/App/issues/19073#issuecomment-1634721968
Tests

Login to expensify.

Navigate to Settings -> Profile -> Click on Profile picture -> Click on Upload Photo -> Select picture.

Verify that Edit photo modal is opened and no overlay is added to the screen.

Navigate to Settings -> Profile -> Personal details -> Home address -> Click on Country.

Verify that no overlay is added to the screen(the screen doesn't become darker).

Navigate to Settings -> Profile -> Personal details -> Date of birth -> Click on the year.

Verify that no overlay is added to the screen(the screen doesn't become darker).

Navigate to Settings -> Workspace -> Choose workspace -> Click on Bank account -> Connect Bank account -> Continue to Company Information step -> Click on State or Incorporation state option.

Verify that no overlay is added to the screen(the screen doesn't become darker).

[x] Verify that no errors appear in the JS console

Offline tests
Same as Tests section.
QA Steps
Same as Tests section.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/39636266/4f33c457-9c26-4613-834c-6dbb6bf57b14

Mobile Web - Chrome
https://github.com/Expensify/App/assets/39636266/01bc207c-873f-422a-9cfb-f8196fe6e224

Mobile Web - Safari
https://github.com/Expensify/App/assets/39636266/14f30b7e-51ef-48f6-806c-23af4cc2feda

Desktop
https://github.com/Expensify/App/assets/39636266/a7a138a3-3af8-4306-bdc2-5ce9c507edbc

iOS
https://github.com/Expensify/App/assets/39636266/e91b75ec-d164-4a1a-992f-f1a3d87853c4

Android
https://github.com/Expensify/App/assets/39636266/7e5d5417-5f18-48b1-a905-8b8622312f42

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.55-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.56-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Allow any Rng implementing type in next_rng

This allows any Rng implementing type to be used as an RNG instead of only ThreadRng. For example Xoroshiro128PlusPlus.

@ramon54321
Oh sorry for not noticing the PR for 6 months!
It was @Braymatter's comment that made me aware of this PR. Thank you very much!
Thanks for your contribution!


feat(daffio): add design docs route

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #2684
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[ ] No

Other information
#3112 is an issue but shouldn't block this PR

Top nav should stay the same as the primary /docs nav, except Design needs to be added as a nav item, which navigates to docs/design

Examples is not going to be path that we'll be using.

Packages should be changed to Components

docs/design should be a custom page not rendered by a README. It's going to look something like this (I can do the UI for it, just needed the route set up)

The API reference page for each component is going to be displayed in the form of a tab within the component page.

@xelaint I've reworked the design docs structure to hopefully match your requirements. Note there are two issues that should be handled in future PRs and not block this one:

The order of items in the sidebar does not match the design. We need a good pattern for hardcoding tree order and sorting.
The docs don't have overview/API tabs. In a future PR, add a design for this and I will wire it up.

@xelaint I've reworked the design docs structure to hopefully match your requirements. Note there are two issues that should be handled in future PRs and not block this one:

The order of items in the sidebar does not match the design. We need a good pattern for hardcoding tree order and sorting.
The docs don't have overview/API tabs. In a future PR, add a design for this and I will wire it up.

issues for these have been added, #3123 and #3124


Issue with selection 'all' for long time period

my data from '29-MAR-2001'(Thursday) to '16-MAR-2017'.
When I choose 'all' selection in rangeSelector.
The graph become from '26-MAR-2001' to '15-MAR-2017'.
Each point in the graph is Monday in that week.
So I think why '26-MAR-2001' becomes first point is to contain the '29-MAR-2001' in graph.
It's weird that we haven't data at   '26-MAR-2001' (our data is from  '29-MAR-2001'), but when hover the first point, there is a specified value for  '26-MAR-2001'.
Please help to check.

Closing and there has been no activity in this issue for a while.
if this is still relevant, please feel free to reopen


ArcPro 3.0 Crashes when Install R Packages and 15a XS Dimensions Level1 are run

Installed ArcPro 3.0, R 4.1.3 is the installed arcgisbinding, R packages are updated. RStudio Check for Package Updates is completed. Install R Packages tool crashes ArcPro 3.0 and tool 15a XS Dimensions Level 1 crashes ArcPro 3.0.

I put a ticket in to set the system path C:\rtools40\usr\bin

Installed R 4.2.0, updated arcgisbinding, and ran Install R Packages. tool 15a XS Dimensions, Level 1 now runs as well as Report- L1


[Bug] Can't move screen on IOS

I tried eaglermobile on my iphone but i was not able to move my screen but buttons were working

Hi @4ykhxn, I would recommend reading our community guidelines. You continue to create issues without providing relevant information, such as what OS, browser, Eagler Mobile version, steps to reproduce the issue, images, or console logs. If you can’t take the time to document the issue, we will not be able to help you.

I am closing this due to inactivity :/


Non-linear time alignment

Description
Non-linear time alignment.  Different tempos of recording of music.  Align points, but not in time.  Same score, different audio times. (http://beethovens9thsymphony.touchpress.com/ is a realisation of this use case). See also NYPL Labs video web tool to combine multiple recordings (http://digitalcollections.nypl.org/tools/video/)
Wikipedia use cases. Music / speeches where would want to mark up points from one alternative version to another.
Might be able to be done automatically.  Good to look at NYPL offering.
Refer to multiple points at the same time, and be able to state they're the same abstract thing.
Variation(s)
Annotations on video, with multi-camera.  Diff positions based on version of video being watched
Proposed Solutions
Annotation that tags multiple canvases to indicate aligned points in the different canvases.
Additional Background
Source: BL workshop notes
Interest: 65%

Related to #18

Is this playback alignment or is this about annotations. I'm reading this as annotations for a kind of shared table of contents. Is there a way to say that the third movement starts at this time in this audio file and this other time in a different audio file? Is this the kind of thing that's desired and meets this use case?

Same problem as critical edition in text. Not the problem of IIIF to solve.
Multiple manifests, one per performance.


Buffer full error when recording with certain headsets

For some headsets, the NAudio library generates a different amount of bytes over time for the output loopback and the mic. Since the current implementation relies on processing the same amount of bytes for each period of time, the result is that one of the buffers keeps storing unprocessed bytes over time and ends up overflowing.
Confirmed that this happens with the Skullcandy Hesh 3 Bluetooth headset and possibly others.

To solve this problem, we would probably need to find another way to synchronize the input and the loopback audio streams, without relying only on the number of bytes recorded. However, I am not sure yet how to do this.


Update artemis-jms-client-all to 2.27.0

Updates org.apache.activemq:artemis-jms-client-all from 2.19.1 to 2.27.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.apache.activemq", artifactId = "artemis-jms-client-all" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #351.


Error: No matching key. history:<PHONE_NUMBER>779782

Sometimes hedera-wallet-connect will start logging errors in the browser console:
 Error: No matching key. history:<PHONE_NUMBER>376459
    at Vt.getRecord (x25519.ts:616:1)
    at Vt.get (x25519.ts:616:1)
    at ds.onRelayEventResponse (index.ts:54:1)
    at EventEmitter.<anonymous> (index.ts:54:1)

Once this happens the communication between wallets and applications becomes unreliable.  Sometimes the transactions will continue processing as normal, other times the wallets will begin throwing exceptions before the transaction has even been signed (though the transactions will usually still process).  Sometimes the wallet will stop receiving the transaction signature requests.  The only way to overcome this is to disconnect the wallet from the app and close the browser.
Reproducing is not always straightforward.  I am able to do this consistently in the hashconnect react example application.  Just connect your wallet, then try to create a transaction.  See video for example.
https://github.com/hashgraph/hedera-wallet-connect/assets/34159275/323d3290-6247-418d-a436-0c163932afb7
Applications are only as reliable as their wallet interactions.  We need this to work more reliably if we want hedera-wallet-connect to be a viable option for app developers.

OS: Windows
Browser Chrome, Edge

+1 seeing this issue as well. Very difficult to reproduce on other machines, but seems to persist on the same machine.

This seems to be an expected error that might be able to be handled more efficiently - https://docs.walletconnect.com/web3wallet/wallet-usage#-expected-errors

This seems to be an expected error that might be able to be handled more efficiently - https://docs.walletconnect.com/web3wallet/wallet-usage#-expected-errors

Appreciate the link.  I arrived at a similar conclusion, and determined that the connectivity issues I was seeing were more likely related to hashconnect v3 than hedera-wallet-connect.  I'll close this issue, as the described error message seems to be pervasive and mostly unavoidable in the world of WalletConnect. 🤷

Same issue for me, keeps coming up

@supermonkeybrainz seem like this issue is on hedera-wallet-connect.

https://www.loom.com/share/2d896a9e4e7c4e6eb6f5f487b2bf0999


Design Grafana dashboard for Iter8 experiments

We are moving away from generating a report (and an HTTP report) for Iter8 experiments and moving towards Grafana dashboard.
Investigate into replicating the report in Grafana as well as what the data should look like.
Consider how the metrics server needs to be modified in order to provide the desired data.

Duplicate of #1547 and #1548


Automated Testing

Add automated testing using cucumberjs

What kind of tests should be added?

What kind of tests should be added?

Check if all the events are added properly...
All links work (not broken/404)
Maybe also some tests that check for accessibility


Unable to run on Terraform Cloud when specifying tf-vars

Terraform Cloud gives me an error regarding the variables that have been uploaded to the run. Apparently they're missing a trailing newline, and nothing I've tried in the yaml will force the variable definition to include one.

I would expect that updating tfe-run or go-tfe-run to ensure there's a newline at the end of the vars file would fix this.

Thank you for reporting this!
I haven't encountered this myself and I define my tf-vars using a pipe:
          tf-vars: |
            image_version = "${{ env.BUILD_VERSION }}"

But I agree we should handle this properly in go-tfe-run.

Thank you for reporting this!
I haven't encountered this myself and I define my tf-vars using a pipe:
          tf-vars: |
            image_version = "${{ env.BUILD_VERSION }}"

But I agree we should handle this properly in go-tfe-run.

Hi @nikrolls, this is a bit difficult to test currently due to an outage on Terraform Cloud, but I believe your run is failing because the value of the variable is not quoted. The .tfvars format expects variables in the format var_name = "<value>".
tfe-run copies the entire contents of tf-vars into a file run.auto.tfvars and uploads that together with the other configuration. When I look in my own workspaces there is also no trailing new line, so I believe this isn't necessary for a working configuration.
Googling a bit on "Missing newline after argument" this is a common but very confusing error when the Terraform parser encounters an error :/

Hi @nikrolls, this is a bit difficult to test currently due to an outage on Terraform Cloud, but I believe your run is failing because the value of the variable is not quoted. The .tfvars format expects variables in the format var_name = "<value>".
tfe-run copies the entire contents of tf-vars into a file run.auto.tfvars and uploads that together with the other configuration. When I look in my own workspaces there is also no trailing new line, so I believe this isn't necessary for a working configuration.
Googling a bit on "Missing newline after argument" this is a common but very confusing error when the Terraform parser encounters an error :/

Can you let me know whether this fixes your issue? If so, I'll update the documentation to list this as a possible error 🙂

Can you let me know whether this fixes your issue? If so, I'll update the documentation to list this as a possible error 🙂

@kvrhdn OK, I feel a bit silly now. That was it. Worse, when I temporarily switched to another action that required me to zip everything up manually, I implemented my own .auto.tfvars creation and fixed the quotes there without it occurring to me that it was the cause of this issue as well.
Thanks for looking into it! Sorry for wasting your time 😁

No worries! This happens to me all the time 😅  Glad it was a quick fix once we found the issue.
The example in the README is actually a bit confusing because the variable run_number is an integer which doesn't require quotes.
    tf-vars: |
      run_number = ${{ github.run_number }}

Ah! Yes, that clarification will help a lot, I think. Thanks!


Correction for raw affiliation Université de Rennes, CNRS, ISCR-UMR 6226, F-35000 Rennes, France

Correction needed for raw affiliation Université de Rennes, CNRS, ISCR-UMR 6226, F-35000 Rennes, France
raw_affiliation_name: Université de Rennes, CNRS, ISCR-UMR 6226, F-35000 Rennes, France
new_rors: 015m7wh34;02feahw73;00adwkx90
previous_rors: 015m7wh34;02feahw73
works_examples: W4383896488
contact: 1fe6b56b5a7223f4cb144211a6c2c5fe:7aeec916b6ed14c366c4a509118be83c @ univ-rennes.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Prod: investigate failed map delete

please poke around the prod DB and see if you can see any anomalies between Biblica 01 (which should be deleted) and Biblica 02_03 (which should be normal).

Biblica 02_03 is normal
Biblica 01 and Biblica 07 a have not successfully deleted all translated maps.
Ihor has found that this is related to a vote issue and is going to put in a PR tomorrow, once that's patched/merged to prod we can proceed to delete the offending maps from UI and do a reupload.

https://github.com/etenlab/crowd.rocks/pull/463