Goals are contradictory

Remove all the backslashes ()
You should have two single quotes ' and four double quotes "
Only remove the backslashes \ used to escape quotes.
Challenge Quoting Strings with Single Quotes has an issue.
User Agent is: Mozilla/5.0 (iPad; CPU OS 9_3_3 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G34 Safari/601.1.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

var myStr = "Link";

@marienhof thanks for the issue. I think we've had issues with this in the past (e.g. https://github.com/FreeCodeCamp/FreeCodeCamp/issues/8400).
The last test message could be rewritten to something like this

Change the string from double to single quotes but keep double quotes for the inner quotes.

@erictleung I think the third test should be combined with the first test if possible. The third test implies there are backslashes in the editor that don't escape quotes but there aren't. So if you remove all the backslashes (per the first test), you are fulfilling the third test.

I like @dhcodes idea. Let's merge the first and third test into one into something like this.
"assert(!/\\\\/g.test(code) && myStr === 'Link', 'message: Remove all the backslashes (\\)');",

I think that should still make it clear enough on what needs to be done to complete the challenge. If anyone finds a hole in the challenge, please comment. Otherwise, I'll mark this Help Wanted.

Updated via the PR above. Thanks for doing the hard part @erictleung

i got it...
var myStr = 'Link';

Yeahhh i got it!!!


Replace calls of deprecated login methods in examples

The examples in samples/ directory used MatrixClient.login_with_password() and
MatrixClient.login_with_password_no_sync(). These calls are replaced
by newer MatrixClient.login() method.

Hiya, CI appears to be broken and will be fixed by #307 so I'll wait for that before merging. Can you also sign off as stated in https://github.com/matrix-org/matrix-python-sdk/blob/master/CONTRIBUTING.rst :)

Thanks for the quick review! :)
I added a 'sign-off-by' line in https://github.com/matrix-org/matrix-python-sdk/pull/306/commits/2dda341144b6e0f9fa0fcdb4190b1aa2f0b5d8d0

Looks like this could be pushed now the CI is green again!

He's right. @sblondon, could you please rebase on master so CI passes?

After the rebase, the CI is green. However, as the new commits are visible, I guess I failed to do a clean rebase.

Don't worry about it. I'll just cherry-pick your commit. Thanks for updating these.


Using brew to install glfw3 conflicts with FLAC on OSX Catalina 10.15.5

When ffmpeg is installed via brew on an OSX system, the FLAC subsystem is also installed.  The FLAC subsystem includes its own assert.h in /usr/local/include.
The realsense-viewer build targets search /usr/local/include so that they may find glfw3-related include files that are installed via brew.
Unfortunately, if ffmpeg is already installed on the system, then assert.h from FLAC is found before the assert.h presumed by imgui.h, and the build fails.
I think it's bad behavior on the part of FLAC to claim <assert.h> in the include hierarchy namespace, but there it is.
The work-around of uninstalling ffmpeg (and many other modules that depend upon FLAC) in order to clean up this conflict is annoying.  It would probably be better to move the very small glfw sub-system into the project build arena (rather than the /usr/local arena) so that /usr/local/include can be swapped out for /usr/include in the system include rules.
But I don't know that much about how brew and Xcode really should interoperate.  So an expert should weigh in.

Hi @MichaelTiemann   I believe that the best way to handle your question will be to treat it as a Feature Request.  I will file a feature request report with Intel now and they can then direct the case to members of the RealSense team with the specialist knowledge to evaluate whether or not to proceed with implementing it.

Closed due to decision not to proceed with implementing the requested feature.


Update insider-risk-management.md

Fixed typo on the document

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/4283

@robmazz Please merge this PR. Thanks


Customer column and Symfony services

Hello,
I have create my own type of column and put the file into my bundle (Xxx/Bundle/AdminBundle/Grid/Column/ThumbColumn.php).
Now I try to load this new type vie the services and but I don't find the good configuration.
Here are my 2 files
services.yml
services:
    grid.column.thumb:
        class: Xxx\Bundle\AdminBundle\Grid\Column\ThumbColumn
        tags:
            -  { name: grid.column.extension }

ThumbColumn.php
<?php
namespace APY\DataGridBundle\Grid\Column;
class ThumbColumn extends Column
{
    public function getType()
    {
        return 'thumb';
    }
}

When I try I have this error
The autoloader expected class "Xxx\Bundle\AdminBundle\Grid\Column\ThumbColumn" to be defined in file "C:\wamp\www\ecom/src\Xxx\Bundle\AdminBundle\Grid\Column\ThumbColumn.php". The file was found but the class was not in it, the class name or namespace probably has a typo.
Please, can you help me ?

You have wrong namespece.
Should have
namespace Xxx\Bundle\AdminBundle\Grid\Column;

Hello,
I can use my services now but I have new issue now.
here is my column.

namespace xxxx\Bundle\AdminBundle\Grid\Column;

class ThumbColumn extends \APY\DataGridBundle\Grid\Column\Column
{

    public function __initialize(array $params)
    {
        $params['filterable'] = false;
        $params['sortable'] = false;

        parent::__initialize($params);
    }

    public function getType()
    {
        return 'thumb';
    }

    public function renderCell($value, $row, $router)
    {
        if ($value) {
            return "<img src=\"{{ '/".$value."' | apply_filter('small') }}\">";
        } else {
            return false;
        }
    }
}```

The result is a string with the HTML code but the HTML is not render...what is wrong ?


SSL certificate parameters

Hi, so the server I am testing against needs ssl certificate. I am aware that we can copy the whole /plans folder to ECS now. So I copied the p12 file into the /plans folder, and added "--env JMETER_FLAGS=-Djavax.net.ssl.keyStore=/plans/someCert.p12 " to add as system properties when running lucy.
After running it, the result are still all 401. And going throught the logs, The log on Gru has "Setting System property: javax.net.ssl.keyStore=/plans/.....p12" line, but the logs on minions don't have this line. So just wondering if the variable line I added is enough or is there some changes need to be made?

The JMETER_FLAGS are passed to Gru here:
https://github.com/smithmicro/jmeter-ecs/blob/f9f4459b8b738103aef1818879fd40a776b4e376/lucy/lucy.sh#L160-L161
This has been a recent change, so I a wondering if you might have an older Lucy image.  Can you try the following to see if you have the latest?
docker pull smithmicro/lucy

The JMETER_FLAGS are passed to Gru here:
jmeter-ecs/lucy/lucy.sh
Lines 160 to 161 in f9f4459
ssh -i $PEM_PATH/$KEY_NAME.pem -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no ec2-user@${GRU_HOST} \
"docker run --network host -v /tmp:/plans -v /logs:/logs --env MINION_HOSTS=$MINION_HOSTS --env JMETER_FLAGS=$JMETER_FLAGS smithmicro/jmeter:$JMETER_VERSION $JMX_IN_COMTAINER"
This has been a recent change, so I a wondering if you might have an older Lucy image. Can you try the following to see if you have the latest?
docker pull smithmicro/lucy

Thanks for the quick reply, I am running the latest lucy, I've also tried CSV file test case, and I can confirm that the whole /plans folder are being copied to ECS since the CSV tests are running fine. So I guess my question now is, does "JMETER_FLAGS=-Djavax.net.ssl.keyStore=/plans/someCert.p12" this System property line need to be added to the minions as well? in order to run the ssl related test.

OK, I understand the scenario now.  Currently, JMETER_FLAGS are only passed to Gru.
Passing JMETER_FLAGS to the Minions is straightforward and would be a simple edition to lucy.sh and lucy.yml.  I will take a look.

I have the change coded but not yet tested.  If you want to give it a try, change your docker run command line to:
docker run ... smithmicro/lucy:feature-39

Hi @dsperling , I have just run the 'smithmicro/lucy:feature-39', but still got 401s in my test. And I lwent through the jmeter-server.log files in both of my minions, I don't see the line 'Setting System property: javax.net.ssl.keyStore=/plans/someCert.p12' which is there in the Gru jmeter.log
So don't know if the new code is working correctly?
Thanks.

Strike 1.
Is there a jmx and p12 file you could share with me to duplicate the issue?

Hi @dsperling here is my test file and cert file. Please just use it as your debug purpose.
Thanks.
testCert.zip

Hi @dsperling any update on this issue?

Code changes may not be required assuming the --globalproperty (-G) switch works as advertised.  Try using the production lucy:latest and change your JMETER_FLAGS variable to:
--env JMETER_FLAGS=-Gjavax.net.ssl.keyStore=/plans/someCert.p12

You should see the following in your log:
Setting Global property: javax.net.ssl.keyStore=/plans/test.p12

Does this work for you?

There is a missing piece.  In order to unlock the keystore remotely, we will need to pass the following variable:
javax.net.ssl.keyStorePassword

Could you send the password for your .p12 file sent previously?

Hi @dsperling, I didn't set the password for this certificate. And I also tried running locally using jmeter CLI "jmeter -n -t test.jmx -l log.jtl -Djavax.net.ssl.keyStore=path_to/someCert.p12" (you can try run this locally and see the log also). This command is good enough to get the right result.
And I also tried -G on latest Lucy. Still got unauthorized. Also "-G" says it's global property, not sure if it's the same as System properties(-D)..
Really appreciate your help.
Di

Hi @dsperling , I edited the entrypoint.sh for jmeter. Added the properties in the "# run jmeter in server (minion) mode" section. And it's working now.
Thanks,
Di

Just to confirm, you are using lucy:feature-39 from above and edited entrypoint.sh here:
https://github.com/smithmicro/jmeter-ecs/blob/f9f4459b8b738103aef1818879fd40a776b4e376/jmeter/entrypoint.sh#L69
to read:
  exec jmeter-server -n $JMETER_FLAGS \

Correct?

Glad it is working now.  I was looking into the password required for the .p12 file since when I run the following locally on JMeter using:
./jmeter -Djavax.net.ssl.keyStore=test.p12

I am asked for a password when running the plan.

I could see how your local keystore might cache the password, but am wondering how JAVA inside the Docker image knows the keystore password.
Are you using the identical test.p12 file that you sent me, or something different?

Hi @dsperling, it failed for me without password too. So I added a password to the certificate. Then it was working fine.
Also the screenshot you sent seems like you were trying on GUI mode, try using Non-Gui mode, and you may not need the password.
Thanks,
Di

I was only trying GUI mode to ensure I could run your JMX first.  Are you comfortable in sharing your .p12 password out of band?


Attractor

A component that gravitates toward a Target using Newton's law. Should have controls for:

attraction force
friction/dampen factor
max speed

additional notes:
max speed should not necessarily be owned by this class, but rather belong to some other config point and either remain as such here or be reset after initialization

To be used for tracking projectiles


Added variable depth cache limit.

Added user specified depth cache limit when initializing a DepthCache object.

Coverage decreased (-0.06%) to 38.647% when pulling 6fedf1810df4537464e20ac88aaa1a9c52fcaf90 on vegardbotnen:master into 78a64a67cad02ca6397b0b95486b2bc830ae5ef0 on sammchardy:master.

Coverage decreased (-0.06%) to 38.647% when pulling 6fedf1810df4537464e20ac88aaa1a9c52fcaf90 on vegardbotnen:master into 78a64a67cad02ca6397b0b95486b2bc830ae5ef0 on sammchardy:master.


Two-pass geo-location

Step 1: identify the general area where the photo was taken (circle)
Step 2: identify the precise location where the photo was taken (point)
(... and then Step 3: angle)

@subsublibrary ideas for new copy/texts for both steps?


Allow single-atom residues to use the residue map

The _check_independent_residues function, which needs to be True in order to use the residue map feature I added a while back, breaks if the atoms in the residue have no bond partners. The function checks to see if any bond partners of atoms in a given residue are not themselves atom in said residue:
if set(atoms_in_residue) != set(bond_partners_in_residue):
    return False

But this was breaking when bond_partners_in_residue is an empty list.
This small fix handles this case, and should allow single-atom residues to use the residue map for speedup in atomtyping.
h/t @justinGilmer, who found this by way of an argon system that was slow to apply a force field to.

Nice LGTM!
Looks like Travis is having a blast again though... can you try removing the rvm update? I think we might have only needed the brew updatesince that worked in a recent mdtraj PR but @justinGilmer probably knows more.

👍
Will merge #152 into this once those tests pass


Self-managed nodes kubelet fails to start.

Description
If self-managed nodes are used, the container runtime is set to be docker, regardless of the version of k8s.
The version I am using is 1.27 without specifying the container runtime

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version: 19.17.2

Terraform version: 1.5.7

Reproduction Code

Steps to reproduce the behaviour:
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 19.0"

  cluster_name    = "my-cluster"
  cluster_version = "1.27"

  cluster_endpoint_public_access = true

  vpc_id                   = local.network.vpc_id
  subnet_ids               = local.network.private_subnets
  control_plane_subnet_ids = concat(local.network.private_subnets, local.network.public_subnets)

  self_managed_node_group_defaults = {
    instance_type                          = "t3.medium"
    update_launch_template_default_version = true
    iam_role_additional_policies           = {
      AmazonSSMManagedInstanceCore = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
    }
  }

  self_managed_node_groups = {
    one = {
      name                       = "my-cluster"
      min_size                   = 1
      max_size                   = 5
      desired_size               = 1
      use_mixed_instances_policy = false
    }
  }

  # aws-auth configmap
  manage_aws_auth_configmap = true
  create_aws_auth_configmap = true

  aws_auth_roles = [
    {
      rolearn  = "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/OrganizationAccountAccessRole"
      username = "admin-role"
      groups   = ["system:masters"]
    },
  ]

  aws_auth_accounts = [
    data.aws_caller_identity.current.account_id,
  ]

  tags = {
    Environment = "dev"
    Terraform   = "true"
  }
}

Expected behaviour

Kubelet uses containerd as a container runtime.
Kubelet service starts and onboards the node to the EKS cluster

Actual behaviuor
The kubelet service does not start due to an error Failed to start kubelet.service: Unit not found.
The kubelet service manifest looks like this (/etc/systemd/system/kubelet.service)
[Unit]
Description=Kubernetes Kubelet
Documentation=https://github.com/kubernetes/kubernetes
After=docker.service iptables-restore.service
Requires=docker.service

[Service]
ExecStartPre=/sbin/iptables -P FORWARD ACCEPT -w 5
ExecStart=/usr/bin/kubelet \
    --config /etc/kubernetes/kubelet/kubelet-config.json \
    --kubeconfig /var/lib/kubelet/kubeconfig \
    --container-runtime docker \
    --network-plugin cni \
    --image-credential-provider-config /etc/eks/image-credential-provider/config.json \
    --image-credential-provider-bin-dir /etc/eks/image-credential-provider \
    $KUBELET_ARGS \
    $KUBELET_EXTRA_ARGS

Restart=always
RestartSec=5
KillMode=process

[Install]
WantedBy=multi-user.target

Terminal Output Screenshot(s)
Checking kubelet status
[root@ip-172-31-33-150 bin]# service kubelet status
Redirecting to /bin/systemctl status kubelet.service
● kubelet.service - Kubernetes Kubelet
   Loaded: loaded (/etc/systemd/system/kubelet.service; disabled; vendor preset: disabled)
   Active: inactive (dead)
     Docs: https://github.com/kubernetes/kubernetes

Additional context
Dockershim is not supported by k8s version > 1.23.

If self-managed nodes are used, the container runtime is set to be docker, regardless of the version of k8s.

How are you verifying the container runtime? Have you looked at the logs for kubelet and containerd on the host? This module does not set the container runtime, its whatever the default is as specified by the EKS AMI used

If you look a closer look at the kubelet service configuration, you can clearly see that the container runtime is docker
ExecStart=/usr/bin/kubelet \
    ...
    --container-runtime docker \
    ...

The issue can no longer be reproduced


skip view execution through arranged_axes argument in _execute_view_csv_use_blob

Some MDX queries take very long to execute, while the equivalent Native View selection can be consumed by TI a fraction of the time.
The execute_view_csv  and execute_view_dataframe functions already allow you to circumvent this issues through the use_blob argument. However, even when using use_blob=True TM1py currently executes the view in order to retrieve the axes composition.
This is required so that in the TI process, the variables can be understood and consumed and a sensible CSV can be produced where the headers match with the dimensions.
By introducing a new argument: arranged_axes to the  execute_view_csv  and execute_view_dataframe functions, we can skip the view execution if the caller passes the axes composition to the function.

resolved with #961


Make request throttling less aggressive

I'm submitting a bug report
Brief Description
Whenever I’m using osmcha.org, after reviewing a handful of changesets, I get a “Request was throttled. Expected available in 16 seconds.” message when trying to review additional ones. The required delay varies from a few seconds up to about a minute. It counts down.
This makes reviewing larger numbers of changes really frustrating, because I have to sit and wait up to around 30 seconds to submit my review for each changeset.
What is the motivation / use case for this feature?
Being able to review changesets quickly. Particularly useful when someone has done a load of StreetComplete quests.
What  is the current behaviour, (attach relevant screenshots) ?
As described above, “Request was throttled. Expected available in 16 seconds.” message displayed as a notification in the top-right of the page.
What  is the expected behaviour ?
Don’t throttle requests so aggressively, or don’t throttle requests at all for logged in users.
When does this occur ?
All the time.
How do we replicate the issue ?

Open osmcha.org, sign in and run a query
Review several changesets relatively quickly (say, 5 seconds per changeset)
Receive a “request was throttled” message

Please tell us about your environment:
Firefox on Linux
Other Information / context:
None, happy to provide more details if you need them

Same #723


Added codeowners

Description
Added codeowners
Type of change

Coniguration update

Testing steps
N/A

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   89.50%   89.50%
=======================================
  Files          18       18
  Lines         591      591
=======================================
  Hits          529      529
  Misses         54       54
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ec45e...7367209. Read the comment docs.


Compatibility with Chart.js-2.0

Any plans to make this directive compatible with Charts.js 2.0.

+1

You can now upgrade to version 2 which supports Chart.js 2!

Will close this now as Chart.js 2 support is now in thanks to @joris-lambrechts

Chart.js-2.0 support Mixed charts, tc-angular-chartjs support Mixed charts?


Use a shared cached bundle for all repos to speed up travis builds

The bundle caching on travis has helped make our builds faster.  However, we still have to run a full bundle install when the build for rspec-x bundles for rspec-y in order to run the rspec-y specs.  For example, see this rspec-expectations build:
https://travis-ci.org/rspec/rspec-expectations/jobs/45419435
The main bundle install step took 4.27 seconds and didn't have to install any gems thanks to travis's bundle caching.  However, the "Running specs for rspec-core" step took 68.6 seconds, of which the specs themselves were only ~ 5 seconds of it.  The other 63 seconds were spent installing rspec-core's bundle, which isn't cached at all.
It would cut about a minute out of each build matrix entry if we could find a way to make travis's bundler caching apply to all the repos.  I'm not totally sure how to do this but I'm thinking that if we have a common bundle directory that all the repos use (e.g. ../vendor, since they are all cloned as sibling directories) it would perhaps work.

Can this be closed with the merging of #103?

Yep.


Add Minute_Of_Hour Function As An Alias Of Minute Function (#196)

Signed-off-by: GabeFernandez310<EMAIL_ADDRESS>Description
Adds support for the minute_of_hour function as an alias for the minute function which currently exists in opensearch
Issues Resolved
#722
Check List

[X] New functionality includes testing.

[X] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[X] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1230 (89dba98) into main (1b58f7d) will decrease coverage by 35.55%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1230       +/-   ##
=============================================
- Coverage     98.32%   62.76%   -35.56%
=============================================
  Files           344       10      -334
  Lines          8762      658     -8104
  Branches        554      119      -435
=============================================
- Hits           8615      413     -8202
- Misses          142      192       +50
- Partials          5       53       +48

Flag
Coverage Δ

query-workbench
62.76% <ø> (?)

sql-engine
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...c/main/java/org/opensearch/sql/expression/DSL.java

...arch/sql/expression/datetime/DateTimeFunction.java

...h/sql/expression/function/BuiltinFunctionName.java

...search/executor/protector/ResourceMonitorPlan.java

...ch/sql/opensearch/response/OpenSearchResponse.java

...h/sql/expression/function/OpenSearchFunctions.java

...n/java/org/opensearch/sql/utils/DateTimeUtils.java

...nsearch/data/value/OpenSearchExprValueFactory.java

...pensearch/sql/planner/physical/FilterOperator.java

...rc/main/java/org/opensearch/sql/storage/Table.java

... and 344 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[3.0 Cherry Pick] [#3423] Fix unnecessary DynamoDB GET calls during LogStore::listFrom VACUUM calls

Cherry-pick 03bdf8476c3e4f76d9a2d26592b7fd638736f57a to branch 3.0
Which Delta project/connector is this regarding?

[X] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[ ] Other (fill in here)

Description
Resolves #3423.
This PR updates the logic in BaseExternalLogStore::listFrom so that it does not make a request to get the latest entry from the external store (which is used to perform recovery operations) in the event that a non _delta_log file is being listed.
This is useful for VACUUM operations which may do hundreds or thousands of list calls in the table directory and nested partition directories of parquet files. This is NOT the _delta_log. Thus, checking the external store during these list calls is (1) useless and unwanted as we are not listing the _delta_log so clearly now isn't the time to attempt to do a fixup, and (2) expensive.
This PR makes it so that future VACUUM operations do not perform unnecessary calls to the external store (e.g. DyanamoDB).
How was this patch tested?
Unit tests and an integration test that actually runs VACUUM and compares the number of external store calls using the old/new logic. I ran that test myself 50 times, too, and it passed every time (therefore, not flaky).
Does this PR introduce any user-facing changes?
No

Failures are unrelated to my PR. Merging.


Cluster Provisioning: Create Cloud Credential - Oracle

Similar to https://github.com/rancher/dashboard/issues/2162

Closed because we consolidated cloud credentials.


make object checking a bit more faster

I suggest to check if the pointers are NULL just after checking if they are in the region.
https://github.com/azure-rtos/threadx/blob/b0e9b132b59ab703f19b4588ed785c9c8e7a1072/common_modules/module_manager/inc/txm_module_manager_util.h#L85-L105
that won't cause problems as the pointers are not in use here, and it will be faster because in most of the time they are inside the regions (and in c, conditions are checked from left to right).

Hi @amgross - thank you for the suggestion! I didn't know about the guaranteed left to right checking; I learned something new. I'll add this change to my to-do list.

This can help you.
https://stackoverflow.com/questions/2456086/order-of-execution-for-an-if-with-multiple-conditionals

This improvement has been added internally and will be available in our next release.


feat: bump Windows CSE script package to v0.0.38

What type of PR is this?
/kind feature

What this PR does / why we need it:
bump Windows CSE script package to v0.0.38
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.313%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2285

Relevant Lines:
2881

💛  - Coveralls


Stable release

Do you plan to release a stable version ? In composer.json, your minimum stability is actually dev and you don't have any tag.

Well, good point. Okay. I will look into this :)

I have added a 1.* for the stable release and updated the README.MD accordingly


Security Alert

This is a really good module, but when I put it into production, I get a security alert.  How do  I remove it and just get the name of the application? I have named it and given it a uuid that I generated.

Closed due to ignorance. This error shows up whenever the user opens the oauth2 application when on a different IP.


ESP32: Fix compiling errors for ESP32H2

Problem
There are some issues on lighting app of ESP32-H2
Change overview
Fixed the issues
Testing
Tested on ESP32H2

/rebase


Convert merge errors to bad requests

closes #1547

Codecov Report

Merging #1555 (977cd6d) into master (e301359) will increase coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   38.96%   39.03%   +0.07%
==========================================
  Files         167      167
  Lines       13706    13706
==========================================
+ Hits         5340     5350      +10
+ Misses       7590     7581       -9
+ Partials      776      775       -1

Impacted Files
Coverage Δ

api/controller.go
34.40% <0.00%> (ø)

pyramid/tier_fs.go
58.51% <0.00%> (+1.74%)
:arrow_up:

config/logger.go
75.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e301359...977cd6d. Read the comment docs.


[WIP] Jenkins pieline

Dropped in favour of a github actions/workflow PR: https://github.com/Quadrabee/arnavon/pull/15


feat(analysis/nnreal): define the nonnegative reals

NB: This file has a lot in common with ennreal.lean, the extended nonnegative reals.

It looks like you forgot to add induced_comp

I processed almost all your comments. Only the stuff on orders I didn't touch. I think I might need a bit of help there...

Merged in https://github.com/leanprover/mathlib/commit/9303bc024fccb60cfcdb4f8f9ba6459b02deec3b
I added more type class instances to nnreal.


Shelf Life

There is a need for some sort of shelf life for each product. It would be very beneficial to add in a shelf life data value to each product.
This would open up the possibility of items being removed from the database if their shelf life has been passed and possibly moved to clearance if it is close to end of life.

As of right now, this request is very difficult. It is unlikely to get shelf life information on every product. You would have to check the expiration date, and then know when the product was made or sent to the store. So, I will close this for now. As of right now, it is un doable.


Can not run test with playwright

What are you trying to achieve?
I'm a new player on codeceptjs with playwright so I just compose simple test script using Gherkin but it can not load the browser?

Provide console output if related. Use --verbose mode for more details.

CodeceptJS v2.6.1
Using test root "C:\git\my-project"
Helpers: Playwright
Plugins: screenshotOnFail, retryFailedStep

Business rules --
  In order to achieve my goals
  As a persona
  I want to be able to interact with a system
    [1] Starting recording promises
    Emitted | suite.before ([object Object])
 » [Session] Starting singleton browser session
    [1] Error | Error: Arguments can not specify page to be opened
    Emitted | test.failed ([object Object])
  × "before all" hook: codeceptjs.beforeSuite for "do something" in 5ms
    [1] Error | Error: Arguments can not specify page to be opened
Error: Arguments can not specify page to be opened
    Emitted | suite.after ([object Object])

-- FAILURES:

  1) Business rules
       "before all" hook: codeceptjs.beforeSuite for "do something":
     Arguments can not specify page to be opened
  rror: Arguments can not specify page to be opened
      at Chromium._defaultArgs (node_modules\playwright-core\lib\server\chromium.js:130:19)
      at Chromium._launchServer (node_modules\playwright-core\lib\server\chromium.js:67:42)

  FAIL  | 0 passed, 1 failed   // 10ms
    Emitted | global.result ([object Object])
    Emitted | global.after ([object Object])

Configuration file:

require('import-export');

exports.config = {
  output: './output',
  helpers: {
    Playwright: {
      url: 'https://www.google.com',
      show: true,
      browser: 'chromium',
      waitForNavigation: ['domcontentloaded', 'networkidle0'],
      waitForAction: 1000,
      getPageTimeout: 10000,
      waitForTimeout: 10000,
      windowSize: '1366x784',
      chromium: {
        args: ['--disable-gpu',
          '--disable-extensions',
          'disable-popup-blocking',
          'disable-infobars'
        ]
      }
    }
  },
  include: {
    I: './steps_file.js',
    testPage: './pages/test.js'
  },
  mocha: {},
  bootstrap: null,
  teardown: null,
  hooks: [],
  gherkin: {
    features: './features/*.feature',
    steps: ['./step_definitions/steps.js']
  },
  plugins: {
    screenshotOnFail: {
      enabled: true
    },
    retryFailedStep: {
      enabled: true
    }
  },
  name: 'my-project'
}

Details

CodeceptJS version: v2.6.1
NodeJS Version: v10.16.0
Operating System: Windows 10
playwright

Check this #2329 to modify your config, the waitForNagivation section.

Check this #2329 to modify your config, the waitForNagivation section.

I have changed:
waitForNavigation: 'domcontentloaded',

but it still got same error

Could you post your test file?

Page:
const { I } = inject();

class GooglePage {
  constructor() {
    this.searchTextBox = '//input[@name="q"]'
    this.searchButton = '(//input[@name="btnK"])[2]'
  }

  inputSearchTextBox(value) {
    I.appendField($this.searchButton, value)
  }

  clickSearchButton() {
    I.click(this.searchButton)
  }
}

export default new GooglePage()

Step:
const { I, testPage } = inject();
// Add in your custom step files

When('I input "([^"]*)"', (value) => {
  testPage.inputSearchTextBox(value)
});

Feature:
Feature: Business rules
  In order to achieve my goals
  As a persona
  I want to be able to interact with a system

  Scenario: do something
    Then I input "XYZ"

Oh, don’t you have the step I.amOnPage()?

I have just added it into Step:
When('I am on page', () => {
  I.amOnPage()
})

This step can be recognized by Gherkin:
$ npx codeceptjs gherkin:steps
Gherkin Step definitions:

  I input "([^"]*)"
    => (C:\git\gf-service-booking-service-testing\step_definitions\steps.js:4:1)
  I am on page
    => (C:\git\gf-service-booking-service-testing\step_definitions\steps.js:8:1)

(node:18944) ExperimentalWarning: The fs.promises API is experimental

Feature:
Feature: Business rules
  In order to achieve my goals
  As a persona
  I want to be able to interact with a system

  Scenario: do something
    When I am on page
    When I input "XYZ"

But it still got same error

Did you inject I actor?
// use I  via inject() function
const { I } = inject();

Did you inject I actor?
// use I via inject() function
const { I } = inject();

off course. I generate this file by codepceptjs cli so it auto add const { I } = inject(); at the top of page/steps_definition files.

Have you tried?
I.amOnPage('/')

Have you tried?
I.amOnPage('/')

also tried that, not working

So could you provide a repo that could easily reproduce your issue?

Have just upload it on this: https://github.com/ledaivuong/codeceptjs-testing-sample

I’m suspicious that you’re using playright v0.13 causes issue. Have you tried with v0.12?

I’m suspicious that you’re using playright v0.13 causes issue. Have you tried with v0.12.1?

It happens with v0.12.1 so I try to update it. Both of them have the same issue

@PeterNgTr Any news or solutions to work around with that. I wonder how can we connect remote chromium or selenium on local manually

@ledaivuong I found out, it's your passed args, you missed the two dashes --
...
          '--disable-popup-blocking',
          '--disable-infobars'
...

It's correct. Thank you very much for your time


Network usage while paused

When I pause a stream I notice that the app is still downloading some data. Is this normal behavior?

It's weird for me. The program does not transmit any telemetry or other information. I'm too lazy for this :)
There are only 3 parts of the program where traffic can be generated:

The actual music playback. You say that the music is not playing at this moment.
Requests to www.radio-browser.info . Several DNS and HTTP requests are made there, but only when you are explicitly looking for stations.
Updates. The program uses the Sparkle library to support updates and check for new updates. If auto-update is enabled, the program periodically downloads the file https://sokoloffa.github.io/radiola/feed.xml

I think, this is most likely the last point.
I'll do some research on this. How long did the program download 15 MB?

I was wrong. These are not updates, the AVPlayer class continues to download data in a paused state.
I changed the code, now the download is interrupted after a pause.

Done in the 6.1.0 release


Fixed a bug with bytes encoding error

Bytes has a  decode method but no encode, so it the string version needs to be used.

Fixes #2872

Can somebody help me with this ?

Hi, Can you try closing and reopening this PR to trigger the checks again?

So, I'm going to merge this because it fixes the immediate issue. The whole structure there reeks, though - we should definitely give it a structural cleanup.


Yes, but what does it do?

"to create generative AI experiences with the copilot look and feel, which includes signature visuals, and built-in safety controls for customers" is so generic as to be meaningless. It could describe any number of AI-related apps, controls, programs, experiences equally, because it does not really describe anything.
Just showing code and comments does not cut it, either. We can do better than this. How about a single paragraph with some background and an actual "for example" description that would make clear what this is, why it would be included in BC, and who might be interested in adding it to their environment? I think that would constitute a cheap but enormous improvement. Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2b8581be-c8ea-6997-13df-5e253e24a496
Version Independent ID: 2b8581be-c8ea-6997-13df-5e253e24a496
Content: The PromptDialog object - Business Central
Content Source: dev-itpro/developer/devenv-page-type-promptdialog.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for your feedback. This article is more of a reference article for the object and came out with the refreshed properties. We'll be publishing much more conceptual documentation on AI capabilities soon, so hope you'll find that helpful. Stay tuned and thanks for your patience!


Build docker image and push Github Registry

Hi, I had the build hang on a linux vm we use to host some docker containers. As I could not solve the problem, I added a workflow to publish the image.
I basically copy pasted from here: https://docs.github.com/en/actions/publishing-packages/publishing-docker-images
The workflow publishes the image if something is pushed the branch release.
LG Philipp

Thank you for adding this! Setting this up now.


fix typo

Hi @Ohadbasan,
Do you see why the build is failing https://travis-ci.org/ubuntu/microk8s/builds/492799022#L2250 ?
Also for the record, this is not a typo. ISTIO_ERSION holds the ISTIO_VERSION without the "v". For example lets say ISTIO_VERSION="v1.0.5", ISTIO_ERSION="1.0.5". But since this seems to confuse people I do not object to your PR.

I see the failures. I am not sure its related to the PR.
seems like the the micro8s_reset is trying to access a file that doesn't exist.
am I wrong?

The build of the snap is failing on travis. Are you able to build the snap locally without any issues?
The error:
/bin/sh: 35: build-scripts/fetch-binaries.sh: Bad substitution

I am using mac os and a gnu/linux distro is mandatory for snap building (afaik)
I have just validated the syntactic validity of this changes on my machine (using bash 4.4)
if this script is invoked using dash or a vanilla posix shell, it might be the cause of the issue but I can not reproduce it on my mac machine.


Resolve issue when hitting routes via CURL/POSTMAN

Closing for now due to reasons I enumerated on in #70. If more people run into this problem and would like the example config changed, we can definitely do that.


Avoid to infinitely split bundle

Motivation
If there is just one topic, but reached the split conditition. The pulsar broker will went to infinitely splitting bundle.
Modifications
If there is just one topic, we do not split.
Documentation

[x] no-need-doc

It's an internal change, no need doc

I have one question:
Why 1 and not a configurable threshold ? is it for developers / pulsar standalone users ?

First, It's not a config like minBundleTopics.
Second, it's not only for developer use, let's think a scene
One namespace, one topic/partition, but the topic's rate is high, the bundle split will infinitely splite bundle, make this topic doesn't work.

I have one question:
Why 1 and not a configurable threshold ? is it for developers / pulsar standalone users ?

And it's meaningless for split bundle that has only one topic

why bundle contains one topic cannot split? I am confused.

why bundle contains one topic cannot split? I am confused.

Cause it will lead to infinitely split bundle.

Good catch @Shoothzj !


[CI] Move Aarch64 to Cirrus and add FreeBSD as well

CC @ararslan

@ararslan aarch64 is failing with
cirrusjl build
/tmp/scripts9566c74d10037c4d7bbb0407d1e2c649.sh: line 5: cirrusjl: command not found
Exit status: 127

Hm. Is the wget invocation incorrect maybe so sh -c isn't doing anything? The installation step in the Cirrus log should have a lot of output but it has nothing.

Looks like it doesn't have curl nor wget?

I thought wget was always available on Linux. Even Alpine as it by default, so it's crazy to me that Ubuntu wouldn't...

It depends on what they put in the image. The standard Ubuntu installation should come with wget, but maybe they provide a stripped down environment?

AFAIK (arm_)container: ubuntu:latest should be the official Ubuntu Docker image. According to one of the folks from Cirrus, the Cirrus Agent bootstraps itself in a very similar way as this. He specifically showed me the following code:
download_agent() {
    if [ -x "$(command -v wget)" ]; then
        echo "Trying to download regularly via wget"
        wget -t 0 "$agentUrl" -O $AGENT_LOCATION
    elif [ -x "$(command -v curl)" ]; then
        echo "Trying to download regularly via curl"
        curl --retry 10 --location "$agentUrl" -o $AGENT_LOCATION
    else
        exit 1
    fi
    chmod +x $AGENT_LOCATION
}

But I wonder if there's some fallback since the echoes there say "regularly." I guess they must also figure out how to download... irregularly.

I think that if I can get https://github.com/ararslan/CirrusCI.jl/pull/14 fully functional in the way that I'm hoping, it will obviate the need for the checks on commands being available. Big if true, as they say.

@ararslan
-e �[0;34m[CIRRUSCI.JL]�[0m: Downloading Julia from https://julialangnightlies-s3.julialang.org/bin/linux/aarch64/julia-latest-linuxaarch64.tar.gz

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now

https://github.com/JuliaLang/www.julialang.org/pull/1752 is probably relevant


Edit Channel Numbers

I tried to edit channel numbers to the ones I like, but Jellyfin and Kodi is only going by alphabetical order rather than my customized channel numbers.

Kodi isn't doing a custom channel order. And then all of the channels are 0s instead of the specific channel.

Although, I have found an issue with the code and will fix it, the issues you are having are with apps external to Cabernet.

Some channels ended up playing incorrect ones, such as foreign sports channels instead of the channels I wanted.

Channel number update in <IP_ADDRESS>.  This fix stops users from cause their own issue by having the Starting Ch Number set while trying to change the channels in the channel editor manually.
If you read #78 and changed the "Use Channel # for Channel ID" to true, it states you can cause your own issues by changing channel numbers.  After a while, the clients will resync to the new numbers, but in the meantime, issues like the ones posted are expected.
This issue is fixed and closed.


Remove done releases from the schedule

As per title, this patch is created based on https://github.com/knative/release/pull/157.
/cc @lionelvillard

/lgtm


Kubernetes cluster type 'gke' not respecting backend auth

This fixes bug #13648

:heavy_check_mark: Checklist

[x] ChangeSet name is thirty-sloths-sin.md and there l describe what it doing it the code. (more info)
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

The implementation consist in adding a piece of code starts in 58 adding some config.getString() method to find out if the app-config.yaml kubernetes config includes the type of Auth as googleServiceAccount
So the behavior is:
Before implementation we had this:

After implementarion:

So as you can see after the implementation the UI renders all the pods related to the Kubernetes Engine Clusters
Testing the script with the implementation:

Thank you for reviewing the pull request.

Hi guys!
@jamieklassen @mclarke47 @erikprice Thisi is just a reminder that we have this PR pending.
Thank you for taking the time to reviewing it.

Changeset looks better and unit tests look pretty good; can you also update the config schema here to mention this new parameter?
https://github.com/backstage/backstage/blob/2d59a19fd3a566dbb8f1639aab8c79f84db7db2a/plugins/kubernetes-backend/config.d.ts#L76-L87
Otherwise people might start using the new parameter in their app-config and find that yarn backstage-cli config:check --strict starts failing.

Done!, already uploaded!

Hi guys,
I just wondering if you have reviwed the last changes on this PR @jamieklassen @mclarke47 @Rugvip
Thanks!

Hi guys,
I just wondering if you have reviwed the last changes on this PR @jamieklassen @mclarke47 @Rugvip
Thanks!

Yep, you can see I approved yesterday. If you rebase on master to include #22297, the CI checks should be fixed.

Hi guys,
I just wondering if you have reviwed the last changes on this PR @jamieklassen @mclarke47 @Rugvip
Thanks!

Yep, you can see I approved yesterday. If you rebase on master to include #22297, the CI checks should be fixed.

HI @jamieklassen,
Yes, l did already that, and the checks now are in green.
My question is, this is not going to be merged to the backstage:master branch?
Thank you!

I wonder if this is not going to be merged to the backstage:master branch guys?
Please let me know if you need anything else.
Thank you!

Because the PR includes docs changes (and the docs are not owned by the Kubernetes maintainer group), I can't merge this with my approval alone. This will need an approval from the core maintainers before it can be merged, and they have a lot of other PRs to consider, but I'm sure they'll take a look when they get a chance!


Translate May 1 covid report into Korean

Hello @nextstrain/korean!
The situation report from 2020-05-01 is ready to be translated to Korean. The report focuses on Central & Eastern Europe. As per previous week's, please translate the Twitter post below! It's still a bummer when the translation is great, but people do not know it because I used Google translate for the Twitter post (lol).
Branch to translate on: sit-rep_ko
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_ko/narratives/translations_ncov_sit-rep_ko_2020-05-01.md You can translate directly in this file, but please remember to push often as other people may be working on the translation!
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_ko/ncov/sit-rep/ko/2020-05-01
Twitter post to translate:
“In the latest #COVID19 situation report, we explore outbreaks in Central & Eastern Europe. The report is now available in Korean. Thank you @, @, and @ for the rapid translation."
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/korean
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. (Although it is okay to update Wikipedia or CDC links to the appropriate language version.) Comments to help with translation are noted in comment symbols like <! -- Comment -->.
Please add your name under translators: with new line, tab, and dash, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Korean; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy of what we publish. Thanks for understanding.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.
Feel free to use a live, online editor like hackmd (sign in with GitHub) to translate together.
Thank you so very much! As always, it's an honor work with you all to make these analyses accessible. Take care.

Hi @nextstrain/korean ,
Now, the 05-01 report is ready for proofreading and review.
One thing is that I didn't translate the sentence that includes "Explore the data yourself" on purpose, as that button is still in English in the Korean version.
If you have a question, feel free to let me know. Thank you in advance.
Best,
TH

Thanks so much @taehoonh! @KyobinKang, @minkyuxyz, or @hanbin973, any chance of you can proofread the translation?

Proofread done. Nothing to change.

Thanks, @minkyuxyz !

Published: https://nextstrain.org/narratives/ncov/sit-rep/ko/2020-05-01
Thanks all!


Create Alert Component

Create <Alert/> Component
Create a reusable basic Alert component for use in the DAOhaus forms and other UI.
Details
Name: <Alert />
https://www.figma.com/file/R1a1bwODnzCHHHw0EJALAU/DAOhaus-v3-Pattern-Library-(In-Progress)?node-id=147%3A56949
Spec questions

Note: The design may not be fully ready yet, so we may want to keep this in Backlog until we discuss it.

We may want to give some additional thought on how we want to handle this semantically since it's not a Dialog -- it can be included as an Error/Warning/Success when combined with other elements. It could also be included on a Dialog, but this atom is self-contained.

If it's included with a Form, I think a modified <Label> may make sense, so we'd need the htmlFor property. If this is outside of a form we wouldn't want to use a <Label/>. We may want to give this one some thinking before we build it out.

Variants
https://www.figma.com/file/R1a1bwODnzCHHHw0EJALAU/DAOhaus-v3-Pattern-Library-(In-Progress)?node-id=44%3A477
Props

Type (Success/Info/Warning/Error)
Message
Icon

If we want to provide flexibility, if not we can lock it in

Color

If we want to provide flexibility for the color of the text and icons, otherwise we can lock it in

Resources/Design
Figma PL Node
Deliverable

Code/PR
Storybook deployment

@0xRowdy


detect and strip "mommy i mean"

Users should be allowed to write
cargo mommy i mean mommy i mean test

Ok this should still work for cargo mommy i mean mommy BUT if you type cargo mommy i mean daddy it should reconfigure everything such that cargo daddy and CARGO_DADDYS_LITTLE=... now work.


Tkwar 22 DONE

If you can, remove few pointless println (QuadtreeRenderer line 36, GFXManager line 66
QuadtreeRenderer line 26: Use val
On UIManager put a description of all the listeners
Move environRenderer (World line 82) to GFXManager


connected stablecoin section to the stablecoin gas fee comparison tool

What

included a link in the Stablecoin devportal section, the link is pointing to the Stablecoin gas fee comparison tool website

Why

updating devportal
(if this patch addresses and existing, feel free to copy this section across)

Refs

(optional: include links to other issues, PRs, tickets, etc)
@owans please review.

Thanks @owans for the suggestions, missed those little errors. I have committed your suggestions.


ModelBackend object permissions fallback to model permissions

This is for the issue:
https://code.djangoproject.com/ticket/20218
and the discussion:
https://groups.google.com/forum/#!topic/django-developers/MLWfvPPVwDk

Closing for now, absence a consensus on the mailing list.


test: node: use Eventually() to check CiliumNode labels

Manual backport of https://github.com/cilium/cilium/pull/21353/ (these 2 PRs were targetting 1.12 and 1.11 as this test does not exist anymore in master)

/test-backport-1.11

/test-backport-1.11

/test-backport-1.11

/test-1.23-4.9

/test-1.23-4.9

/test-gke

/test-1.23-4.9

/test-1.23-4.9

/test-backport-1.11

Marking it as ready to merge as the failure is unrelated to the changes of this PR


The network connection was lost - Error Domain=kCFErrorDomainCFNetwork Code=-1005 - in GET

I have an application on Tomcat that behind Apache WWW. In client-side Android, client don't have any problem, in iOS client All POST request works fine but in GET request we don't get any response and after while getting this error "The network connection was lost ".
None of this solution didn't work for me.
I put a question into Stack overflow but I didn't get any answer yet.
please help me thanks.

Finally, after 3 weeks I found a solution. we set "Content-length" into header and Apache(WWW) drop that response that has it. So I removed that header and everything works fine now :)


GPTPandasIndex could not handle long query and threw EOL exception

GPTPandasIndex.query(): when Pandas Instruction gets too long, an EOL exception was thrown (shown as below). Could elimnate the error by using less conditions but hopefully the program can handle longer Pandas Instruction
> Pandas Output: There was an error running the output as Python code. Error message: EOL while scanning string literal (<unknown>, line 2)
Traceback (most recent call last):
  File "C:\Users\justin\AppData\Local\Programs\Python\Python39\lib\site-packages\gpt_index\indices\struct_store\pandas_query.py", line 49, in default_output_processor
    tree = ast.parse(output)
  File "C:\Users\justin\AppData\Local\Programs\Python\Python39\lib\ast.py", line 50, in parse
    return compile(source, filename, mode, flags,
  File "<unknown>", line 2
    df[(df['产品条件名称'].str.contains('整存整取定期存款|约定期限|利率|存款人|支取本息|存期|个人|单位|逐笔计息法|挂牌公告利率')) | (df['产品条件描述'].str.contains('整存整取定期存款|约定期限|利率|存款人|支取本息|存期|个人|单位|逐笔计息法|挂牌公告利率'))]['产品条件
                                                                                ^
SyntaxError: EOL while scanning string literal

I'm having a similar problem on this, error below
Traceback (most recent call last):
  File ".../python3.11/site-packages/llama_index/query_engine/pandas_query_engine.py", line 50, in default_output_processor
    tree = ast.parse(output)
           ^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 50, in parse
    return compile(source, filename, mode, flags,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<unknown>", line 2


bugfix/camera-pan-destination

Fixes a bug

Describe the changes below:
Camera pan did not work correct for me, moving in the opposite destination direction.
For me it worked after this small change.

Please post a code sample showing how this fixes the pan movement, as none of the pan examples are broken with the current implementation and all act as expected.

Closing due to inactivity. Happy to look at this again with an example.


Update Composer dependencies (2020-06-18-00-10)

Visual regression test passed!
View the visual regression test report


PLNSRVCE-534: abort override bundle for periodic but do not exit CI setup

see https://github.com/openshift/release/pull/31046#issuecomment-1205697890

did not break PR / CI flow:
JVM_BUILD_SERVICE_IMAGE is set
JVM_BUILD_SERVICE_PR_SHA is set so overriding tekton bundles

merging


RawModule with no reset should be able to use withClock method.

Motivation
Fixes bug identified in Issue #1041
Description
A user defining defining a Module with a clock and no reset cannot use the
withClock(clock) { val r = RegNext(...) }. Attempting to do so will generate an exception saying
there is no reset even though no reset is required.
Details

refactor ClockAndReset

now has clockOpt: Option[Clock] and resetOpt: Option[Reset] constructor params
convenience methods clock and reset tries to deref the option
ClockAndReset.empty is factory method for (None, None)

In Builder

forcedClock does not check resetOpt now
forcedReset does not check clockOpt now

withClock no longer looks at resetOpt
withReset no longer looks at clockOpt
Module starts with empty ClockAndReset

Impact
Internal API change.

@ducky64 good points, I have refactored to simply have two variables since they are orthogonal.


Update the whois servers with the IANA list

Hello,
I made a comparison between the list of official whois servers indicated by IANA and those listed in the JSON, there are more than 300 differences.
Some servers have just changed and the old ones no longer exist, others often correspond to the same server (same IP address) but have changed names (for example with hosts with the same extension as tld).
Locally I'm already updating the json file, can it make sense to report the changes on the master?
A single PR or separate in different blocks to make them more readable?

Hello.
Wow, you've done a good job!
I guess it should be two commits:

Just updating IANA servers
Remove/replace junk

What you think?

Sorry for my late reply.
I started thinking about doing various PRs, but in fact it would be useless.
I create a new branch with the various modifications, grouped into some commits to make them more readable.
I am not going to explain everything, you will understand it at the first PR.
Is it good for you?

Don't worry I late too :)
Yes. Single PR with strict commits it's OK. One action - one commit.
For example:

removing junk/unnecessary servers - first commit
updating some whois hosts to actual - second commit
something else - third
and so on..

I guess you're not needing to do unit tests. Because it's very long and hard work

Hei @io-developer i'm still working on this, just i have not so much time to devote to it.
I just saw your new branch, do you want to download the list of tlds from IANA and use the *.whois-servers.net aliases?
Will manual configurations also be possible? Because in my past tests not all tlds were sometimes active as aliases on whois-servers.net

Hi!
Actually that idea from Sep 2018 as I remember. And still have no clear vision how to release it.
Some concept:

Project (this lib) have lightweight server list - just very specific tld/servers/rules
Base whois list loading from IANA (path in config I guess to get possibility to override at project level)
So, rules building from project list + IANA => all are happy :)

Problems:

IANA have some base list (url with plain text), but it's not complete
Also IANA (maybe not) provides special whois selver which accept zones instead domain. But impossible to load all known TLD via one request
So solution may be as refactoring TldServer::match* to work with single TLD insteal full list

I guess so... What you think?

I just saw your new branch, do you want to download the list of tlds from IANA
It's related to this issue https://github.com/io-developer/php-whois/issues/37

Will manual configurations also be possible?
Yes, of course :)

Ok, understood. Having a dynamic servers list it's a nice idea (and if I say so where almost all of my commits are to update the servers... :D ) but sometimes Iana's data is incorrect, some whois servers exist but are not documented, others are documented but do not work or are removed, having them automatic I don't know if in the end it can become more of a problem than a solution.
Your static list + dinyamic fallback is a good way, but maybe the extra work isn't worth it.
And in the meantime I'm flooding you with PR, in these days of coronavirus there is a bit of calm and I'm catching up on backlog for this project, if I can in the next days / weeks I will also resume this issue.

Hi all !
Thanks for your work 👍
Is there any luck to update this issue ?
Is there a way to help ?
Thx

Hello,
most of the work is already done on my local copy, but I stopped because there is no more news from the maintainer, I have some PR waiting for months and I have others to send that now I have stopped in my fork :(

Hey @io-developer, after i while i'm back!
I took advantage of this week of calm with clients in the summer holidays to resume this job that I had abandoned.
I did a big JSON update of the whois servers, separating various commits.
There is only a few commits too many because I was lagging behind your master, and I had to align everything, but the important file is the JSON of the TLDs with all the updates and insertions.


DevTools docked to tab interface

DevTools button added but it pops out of tab window. Not ＡＥＳＴＨＥＴＩＣ.

There aren't any implementations for custom DevTools stuff, just ability to show it. Closing this until it's possible.


Proper handling of CFDE: related entities with non-RID source definitions

Summary
For the "explore" link in chaise, ermrestjs is creating a reverse path of the related entity where the main table's shortest key would be the selected facet. To make sure that the proper facet is selected when users click on "explore" button, data-modelers have to define their facet using the shortest key to align with this automatic process. So technically data-modelers cannot have any entity non-RID facets.
Example
Assume the A (RID) <- B (fk_to_A_col) relationship and that B is defined as a related entity in the table A:
{
  "tag:isrd.isi.edu,2016:visible-foreign-keys": {
    "*": [
      {
        "source": [
          {"inbound": ["s", "fk_from_B_to_A_constraint"]},
          "RID"
        ],
        "entity": true
      }
    ]
  }
}

By navigating to a page with S:A/RID=v1_rid, users would be able to see the related entities in table B for this record. Clicking on "Explore" should navigate them to a recordset of table B where this relationship is defined as a facet. So ermrestjs would create a URL to S:B with the following facet:
{
  "and": [
    {
      "source": [
        {"outbound": ["s", "fk_from_B_to_A_constraint"]},
        "RID"
      ],
      "choices": ["v1_rid"]
    }
  ]
}

And if the same exact facet definition is missing from the table's facet list, ermrestjs will append a temporary facet to the facet panel. This can be very confusing if your facet definition is based on the same path but different end column.
Proposed solution
After discussion we came up with a better solution which is documented in this comment

For the original proposed solution click here.
We should come up with a new annotation that would allow users to have control over this reverse path.

What to name the new property is not the main focus right now. We should first make sure what the new annotation/property should do and then we can improve the naming.

The most straightforward solution would be allowing data-modelers to define the whole reverse path. And then do the same heuristics if this reverse path is missing. So

{
  "source": [
    {"outbound": ["s", "fk_from_B_to_A_constraint"]},
    "RID"
  ],
  "entity": true,
  "parent_source": [
    {"inbound": ["s", "fk_from_B_to_A_constraint"]},
    "some_other_key_in_table_A"
  ]
}

Other names that I can think of: explore_source, source_to_parent, reverse_source

We can easily figure out the reverse path and the only issue here is the end column. So maybe we just want to allow data-modelers to define the last column in the reversal path.

{
  "source": [
    {"outbound": ["s", "fk_from_B_to_A_constraint"]},
    "RID"
  ],
  "entity": true,
  "parent_key": ["some_other_key_in_table_A"]
}

Other names that I can think of: explore_key, reverse_source_key

Assuming that we want to go with one of these solutions, the following would be the required tasks to achieve this:

[ ] Finalize the annotation
[ ] Modify ermrestjs code to use the annotation for reverse path.
[ ] Add new test cases to ermrestjs
[ ] Add new test cases to chaise

Perhaps it should be something like preferred_entity_key as a table
annotation and affect all heuristics related to shortest-key.  Not
just explore links but any automatically generated entity-mode facets,
etc.

We had another discussion about this issue and the following are the summary of changes that we want to work on:

For the reverse path heuristics, instead of always using the shortest key we should be smart about it and try to find a better key. If we couldn't find any other keys, we would fallback to using RID. To find a better key,

We should first look for the facet definition. If we can find a facet with the same path in entity mode, we should use the key defined in there. Our goal is to avoid adding a duplicated facet to facet panel, and by doing this, that issue is solved.
If we cannot a similar path in facet definitions, it means that we have to create that new facet when users navigate to recordset. So our goal would be making sure the name and other display related properties that will be generated by heuristics are accurate. So we might potentially look at related references in the detailed context. And in the end we should look for the source definitions. This part requires more thought

As it was pointed out in the previous comment, in some deployments we still want to define the preferred_entity_key. So we should introduce a new annotation that can support this. The following are two proposed solutions:
"tag:isrd.isi.edu,2021:table": {
  "preferred_entity_key_cols": ["name1", "name2"],
  "preferred_entity_key": ["schema", "constraint"]
},
// or
"tag:isrd.isi.edu,2016:table-display": {
  "row_name": {
    "row_markdown_pattern": "{{{id}}}",
    "preferred_entity_key_cols": ["name1", "name2"]
  },
  "*": {
    "preferred_entity_key": ["schema", "constraint"]
  }
}

The first one would change the key for all the contexts, while the other one is context-based. I should mention that the initial reason for adding the second method was to avoid introducing new annotation. And since table-display is context-based, this new attribute must be contextualized as well. But we couldn't come up with a use case that would require using different keys in different contexts. While discussing this we also talk about potentially refactoring the table-display annotation and moving it into a display property under this new table annotation. But that won't be the focus on these changes for now. Needs more thought into whether we actually want context or not

Due to database changes, this is no longer a high priority for CFDE.

Moved to wish list.


Fix builders by including Nullable fields contained in equals().

This pull request adds fields to builders that are present in equals(). Updated unit tests to assert fields added to Builders. Thanks to Zac for pointing this out.
Zac also mentioned all namespace builders are taking Map instead of ImmutableMap. They should either take ImmutableMap or make a defensive copy. Ben, is there a preference here?

Regarding maps vs immutable maps, I don't have a strong preference; I guess it depends on how the builders will work.  I'd say stick with a defensive copy of a map if:

we want to expose a builder API like Builder withNamespace(NamespaceScope, String)
or, if the other collections in the builder are also mutable

If not, we ought to just be consistent with the rest of the builder params and use immutable maps.

Maps with a defensive copy might be the nicest in the API though, then maybe a check under the hood to just keep the parameter if it's an immutablemap instance

Mutable maps definitely give more options for nice APIs; if we want to make nice builder APIs, let's keep them.

Awesome thanks Ben and Zac.

Is there anything else you'd like me to do here? I'm not sure how I can resolve the conflicts. I'm currently rebased on top of master.

Yeah, I'm not sure why there is a conflict, but it's minor.  I suspect that you could manually squash your commits then git push -f origin ws_builder_fix, and the problem would be resolved.
Alternately, I could do the merge manually in the same way; the drawback is that your name would no longer be on the commit.

 That did it!

Thanks, @naturalwarren!


Rendering issue from certain angles.

@SlightlyMad
If i have shadows enabled for the spotlight, and it doesn't hit any objects, the light stops rendering / turns invisible if viewed from certain angles.
This can be recreated in the spotlight scene, if you rotate the light upwards, then move the camera and the light upwards, at one point it will stop rendering the light, seems like range has something to do with it as well.
Is this a known issue or something new? The rendering's values seems to stay the same, so I couldn't debug it any further.

Im having the same issue. It stops working when my character is out of a certain range from my camera. When the volumetric light stops working, the statistics shows that there are 0 shadow casters.

Yes, that's a known unity limitation. Unity controls when lights are rendered and it disables them when there are no light/shadow receivers as an optimization. Unity doesn't know the light is volumetric and that the volume should still be visible.
You can try to add small shadow caster with large bounding box inside light's volume. That should force unity to keep the light on.

@SlightlyMad Thanks for replying!
I didn't quite understand the part about a small shadow caster with a large bounding box, but it gave me an idea for a fix and I want to share it.
Creating a cube with scale 0x0x0, and placing it just inside the lights reach seems to trigger shadow casting, forcing the light to stay active. Thanks!


Analyzer does not allow declare a class with typed function parameter if it's parametrized contravariant or invariant.

Dart SDK Version: 2.1.0-dev.9.3
OS: Windows 10
This bug is similar with the issues #34689, #34699, but it seems like it's a slightly different case.
Here is a source code example:
typedef G<X> = void Function(X);
class A<X extends G> {}

main() {
  G<dynamic> b;
  G<Null> a;
  G<int> c;

  A<G<dynamic>> b1;
  A<G<Null>> a1;
  A<G<int>> c1;
}

Seems like all the source lines are valid and should pass.
However, analyzer throws a errors for the lines 10 (A<G<Null>> a1;) and 11 (A<G> c1;).
Analyzer sample output is:
Analyzing test.dart...
  error - '(Null) -> ’ Null' doesn't extend '(dynamic) -> ’ dynamic' at test.dart:10:5 - type_argument_not_matching_bounds
  error - '(int) -> ’ int' doesn't extend '(dynamic) -> ’ dynamic' at test.dart:11:5 - type_argument_not_matching_bounds
  hint - The value of the local variable 'b' isn't used at test.dart:5:14 - unused_local_variable
  hint - The value of the local variable 'a' isn't used at test.dart:6:11 - unused_local_variable
  hint - The value of the local variable 'c' isn't used at test.dart:7:10 - unused_local_variable
  hint - The value of the local variable 'b1' isn't used at test.dart:9:17 - unused_local_variable
  hint - The value of the local variable 'a1' isn't used at test.dart:10:14 - unused_local_variable
  hint - The value of the local variable 'c1' isn't used at test.dart:11:13 - unused_local_variable
2 errors and 6 hints found.

This happens for both contravariant (typedef G<X> = void Function(X);) and invariant (typedef G<X> = void Function(X);) cases.
The test passes for covariant (typedef G<X> = X Function();) and unused parameter (typedef G<X> = void Function();).
Dart passes with the line 10 and throw a compile time error for the line 11 here. I am going to file a separate issue about this against runtime.

The treatment of these situations depends critically on the outcome of CL 80140.
If it is landed then all lines in main are OK (and a raw G means G<Null>).
If it is not landed then we're hit by the inconsistency that caused me to create that CL: Variance at top-level is ignored, so a raw G means G<dynamic>. Then A<G<Null>> and A<G<int>> are not regular-bounded (<: G<dynamic> fails for both G<Null> and G<int>). For the super-boundedness check, we need to check whether A<G<Object>> is regular-bounded (which it is) and whether A<G<int>> is regular-bounded (which it's not). So if we don't have 80140 then the type annotation of c1 is a compile-time error, and the rest is OK.

CL 80140 landed Dec 2018. The rules have changed a couple of times since then, so it's time to revisit this issue.
In particular, the raw G used as a bound means G<dynamic>.
Today, I get the following errors from the analyzer (of 8f9113d9f1cb11400c384a4ac68fc050636cf573):
ERROR|COMPILE_TIME_ERROR|TYPE_ARGUMENT_NOT_MATCHING_BOUNDS|/usr/local/google/home/eernst/lang/dart/scratch/202108/n035.dart|11|5|6|'void Function(int)' doesn't conform to the bound 'void Function(dynamic)' of the type parameter 'X'.
ERROR|COMPILE_TIME_ERROR|TYPE_ARGUMENT_NOT_MATCHING_BOUNDS|/usr/local/google/home/eernst/lang/dart/scratch/202108/n035.dart|10|5|7|'void Function(Null)' doesn't conform to the bound 'void Function(dynamic)' of the type parameter 'X'.

and the following from dart (same commit):
n035.dart:10:14: Error: Type argument 'void Function(Null)' doesn't conform to the bound 'void Function(dynamic)' of the type variable 'X' on 'A'.
Try changing type arguments so that they conform to the bounds.
  A<G<Null>> a1;
             ^
n035.dart:2:9: Context: This is the type variable whose bound isn't conformed to.
class A<X extends G> {}
        ^
n035.dart:11:13: Error: Type argument 'void Function(int)' doesn't conform to the bound 'void Function(dynamic)' of the type variable 'X' on 'A'.
Try changing type arguments so that they conform to the bounds.
  A<G<int>> c1;
            ^
n035.dart:2:9: Context: This is the type variable whose bound isn't conformed to.
class A<X extends G> {}
        ^

These error messages are correct for a test where null safety is enabled. In a test without null safety the type A<G<Null>> is superbounded, so in that case there should not be an error, and that is also the behavior I see from both tools.
So at this point we can close this issue, because there are no known issues with tools connected to the topic of this issue.
However, there may be a need to change some co19 tests (to expect an error on line 10 and 11) and co19_2 tests (to expect an error on line 11). I created https://github.com/dart-lang/co19/issues/1178 to handle this.


Set password for root account to allow remote access.

This partially resolves #15. What remains is update the openshift-docs.
Test work fine with both rhel and centos.

lgtm, please make sure the openshift-docs get this update too.

LGTM, two small nits

Small change, added flush-privileges before shutdown.


feat(forge verify-contract): support fully verifying a partially-verified contract

Component
Forge
Describe the feature you would like
forge verify-contract does not attempt to re-verify an already-verified contract as this is an expensive operation. However there are some cases in which this behavior is desired e.g. to re-verify a partially-verified contract with source code that matches the metadata hash. I suggest adding a flag --ignore-already-verified to the verifier command-line arguments to skip the contract already verified check.
Additional context
No response

closed by #6461


Authorized IP ranges support for private IP addresses

According to this section, authorized IP ranges are for public IP values
However, in the Azure portal, at the location where we specify IP range values the tooltip suggests example values representing private IP addresses
Is the example correct and this value will be supported for private addresses as well?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 660320d4-fad5-3307-e29f-5f4cfad4b7f7
Version Independent ID: 85ac2e8b-633f-6e1a-e642-0645ca92e129
Content: API server authorized IP ranges in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/api-server-authorized-ip-ranges.md
Service: azure-kubernetes-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@assaf-grth
Thanks for your feedback! We will investigate and update as appropriate.

@MGoedtel
Can you please check and add your comments on this doc update request as applicable.

@assaf-grth
I'm going to assign this to the document author so they can take a look at it accordingly

#reassign:schaffererin

Hi, @assaf-grth! Thank you for your feedback. I apologize for the delay in a response.
Since your feedback was posted, the portal experience has been updated with the following changes in the Networking tab of the cluster creation process:

There are now two separate sections for access:

Private access, which, when selected, allows you to enable a private cluster to restrict worker node to API access, enhancing your Kubernetes workload's security and isolation.
Public access, which, when selected, allows you to secure access to the API server using authorized IP address ranges.

Hopefully these updates help provide more clarity around enabling private access. I will now close this GitHub issue, as no article updates are necessary.
Thanks again!
#please-close


[Bug]StereoSoundv0.0.6by bep

I'm using "StereoSoundv0.0.6 by bep" on BetterDiscord.
AppData\Local\Discord\app-1.0.9004\modules
If I replace the discord_voice folder in this path to use the Stereo Plugin, viewers cannot hear the sound of the screen sharing application when I turn on screen sharing in Discord.
If you restore the replaced folder, you can hear the sound from screen sharing, but the Stereo Plugin does not work instead.
What should I do?
I am using version Discord 1.0.9004 / Discord PTB 1.0.1013

This is not an issue for this repo, and that plugin is not supported by BetterDiscord.


Do not error if use_2to3 is set to a false value

Summary of changes
I think this slight change fixes an issue where setting use_2to3=False would fail fast when really it ought to be ignored.
I think this results in behaviour closer to what I had in mind with #2769.
Pull Request Checklist

[ ] Changes have tests - no because I can't see where one would go
[x] News fragment added in changelog.d/.

should 58.0.2 be yanked? I assume this will go into a 58.0.3

FTR somebody needs to evaluate this as a possible fix for #2776.

should 58.0.2 be yanked? I assume this will go into a 58.0.3

What value would there be in yanking 58.0.2?

In general, I think it's a move in the right direction but could you also add a regression test for this scenario? I'd like to see both positive and negative test cases added.

I'm happy to skip regression tests for these tweaks.

should 58.0.2 be yanked? I assume this will go into a 58.0.3

What value would there be in yanking 58.0.2?

No, there wouldn't be, if a 58.0.3 is released.

We have some packages as dependencies, which have 2_to_3 set to true (specifically FlaskOpenId  which has not been updated since 2016, so this is likely it won't be updated. https://github.com/mitsuhiko/flask-openid/ Any chance setuptools can simply ignore 2_to_3 setting, rather than ignore when false ?

@potiuk See https://github.com/pypa/setuptools/issues/2775#issuecomment-914606508 and https://github.com/pypa/setuptools/issues/2769 for rationale behind not ignoring the flag - the installed package almost certainly won't be importable.

Yeah. Absolutely. Actually we had an interesting case because the Flask-openid actually was working with just removing 2_to_3 - because it was really small, the changes were harmless (like removing u` from unicod strings) and the only non-compatible change was under "if python < 2" anyway. Thankfully we got response from the maintainers and we became maintainers ourselves and we released a new version of package (after manually converting it with 2_to_3 and making it python3 - only). We also released a .wh;l package which remove the need of using setuptools at all.
I agree it's not possible and tha approach you come up with with "false" is good.


fill match arms with empty block rather than unit tuple

As requested by @Veetaha in #3689 and #3687, this modifies the fill match arms assist to create match arms as an empty block {} rather than a unit tuple ().
In one test I left one of the pre-existing match arms as a unit tuple, and added a body to another match arm, to demonstrate that the contents of existing match arms persist.

Seems like CI is failing though....
Have you recieved an email notification about the failure? I wonder if they are missing for some reason...

I've been receiving the notifications yesterday, so they work.

The CI failure is related to the fact that we generate the docs for all asissts and currently they are out of date due to the () -> {} changes.
The CI cannot regenerate and update the docs itself, since a review of the changes is good to have also, so it fails, asking you to run the cargo xtask codegen command in the project.
So, the fix would be to run the command, double check the changes and push them.

Not sure how I missed that, thanks for the feedback. For the record, I did not get an email about the CI failure.

bors r+

For the record, I did not get an email about the CI failure.

Would be nice to debug that, I have a feeling that a number of contributors also don't get emails...

Hmm, may the difference be explained by the missing public email in the GitHub profile or some other setting?

I have a feeling that a number of contributors also don't get emails...

I get them, I just don't get to look over the PRs in time (sorry, @Veetaha).


Always show tooltip text in hotspot

is it possible to always show the tooltip of a hotspot? currently, there is display on hover.
i want to change the behaviour to always shown

You just need to change the CSS. Adding this to your CSS should work:
div.pnlm-tooltip span {
    visibility: visible !important;
}

Gotcha


PP-5930 prefetch-src directive for ZAP tests

WHAT

prefetch-src directive is an experimental and CSP level 3 directive which is not required on card details page.
However, ZAP tests fails on directive being not defined.

Adds a flag CSP_ADD_PREFETCH_DIRECTIVE to add prefetch-src directive to card details page (set to true to add directive and end to end environment only)

Closing as we don't want to add prefetch-src directive just for ZAP tests


Ledger hardware wallets?

Hi, on your Bitcoin wallet guide you left off the Ledger hardware wallets. Do you not recommend them for some reason? Thanks, Peter

No I don't recommend. They are absolutely terrible at looking after peoples data and do not offer Bitcoin only firmware.

No I don't recommend. They are absolutely terrible at looking after peoples data and do not offer Bitcoin only firmware.


Editorial review for Parallel Statement Execution doc

Feedback about clarity, correctness, and ease-of-use for the Parallel Statement Execution doc

Only after the client receives the return value of a statement, it sends the next SQL statement to be executed.
What does the "it" refer to in the sentence above? Is "it" the client?

We've de-emphasized this feature in 2.1 and beyond, so closing this.


General cleanup of Scala Similarity and Drivers

Many small cleanup changes:

simplified drivers
removed any reference to cross-indicator and most references to indicator
shortened long lines
cleaned up comments and scaladoc annotations
replaced old use of o.a.m.math.Pair with Scala tuples

Tested spark-itemsimilarity on cluster but not naive Bayes stuff
Decided not to remove scopt. Removing it would be more trouble than it's worth given how small the lib is. It still may be worth using case classes for options to get rid of verbose casts but doesn't seem pressing.
This PR doesn't touch the job.jar assembly in the spark module. I have a pare down of that waiting for other refactoring  commits from @dlyubimov.
No other work planned on this PR

Tested  TrainNBDriver and TestNBDriver from the command line with no problems.  I need to do some cleanup of the rest of the Naive Bayes classes as well.

As soon as this looks ok, I'd like to work on the getting 1.2.1 in next so let me know

The only thing that stands out to me is the move to scaladoc style doc comments (away from the spark/java style doc comments).  I'm not sure if it matters, but as Dmitriy mentioned above, we should really pick one style to go with.  Spark style seems to be the de facto convention.  It would make it easier to point people to the Spark style guide as discussed on the dev list.

I don't recall a decision on that or I wouldn't have set my line width to 120. If we are going to be that exacting let's make sure everyone agrees and I'll change this later if necessary. I need to get Spark 1.2.1 in this week if possible

I don't think we really made any hard decision on it- just discussed it a bit..  I don't see any reason not to commit and revise later after we decide.

Let me see what I can do. It should be easy to change the scaladoc comments, it's just the first line. 100 chars will be harder. Would be nice to get it over with.

i'd suggest to be ok with 120 characters. at least our java style is 120-line-long compliant.
Spark people were also ok with 120 characters in my contributions (in fact, initially 100 character constraint applied only to comment style, not the code there. For reasons nobody truly knows).

That will make it much easier, ok Andrew?

I was only referring to the comment style ... not the 100 chars limit.

Basically what we were talking about on this thread:
http://mail-archives.apache.org/mod_mbox/mahout-dev/201501.mbox/<BLU436-SMTP226CD60AFFD7C2AE452278694320%40phx.gbl>

So something like this?

javadoc style documentation comments like Spark
For Scala follow: http://docs.scala-lang.org/style/
We are relaxing the required use of infix for all appropriate method calls and encouraging
“dot” notation. Spark goes further to say you must not use infix unless it’s an operator
method.
Line lengths not to exceed 120 chars—Spark limits to 100

I'm all for using infix as little as possible.  It really does make
scala unnecessarily difficult to read for those  coming from other
languages.
I think we're really only using using infix (aside from operators) in
tests where it seems useful and relatively straightforward. eg:
 InCore(dslCat2, 3) - aggInCore(dslCat2, 3) should be < epsilon

+1. General notion is that custom dsls are big consumers of infix. Indeed.
but OOA should not be one.
On Thu, Feb 19, 2015 at 3:53 PM, Pat Ferrel<EMAIL_ADDRESS>wrote:

So something like this?

javadoc style documentation comments like Spark
For Scala follow: http://docs.scala-lang.org/style/
We are relaxing the required use of infix for all appropriate
method calls and encouraging “dot” notation. Spark goes further to say you
must not use infix unless it’s an operator method.
Line lengths not to exceed 120 chars—Spark limits to 100

I'm all for using infix as little as possible. It really does make
scala unnecessarily difficult to read for those coming from other
languages.
I think we're really only using using infix (aside from operators) in
tests where it seems useful and relatively straightforward. eg:
InCore(dslCat2, 3) - aggInCore(dslCat2, 3) should be < epsilon
—
Reply to this email directly or view it on GitHub
https://github.com/apache/mahout/pull/76#issuecomment-75164360.

Yes- that's what I was thinking.  On the list there is also a link to the Spark Code Style  giude:
https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
and I was suggesting that we use the (javadoc) comment style from that rather than the scaladoc style.  Since it seems to be what a lot of projects are adopting and what we presently use in our codebase.

OOA?

oh sorry i didn't see that you had "javadoc style documentation comments like Spark" in that list.

+1 on doc commit.

OK, well thanks. Hopefully this cleans my desk up a bit.

BTW I like being able to use infix for little DSLs even though they don't use operators they are sometimes easier to read--like the test ones.

agreed

Since 1.2.1 was pushed I had to merge those changes but they break execution of spark-itemsimilarity due to HashBiMap class missing at deserialization.
This is a known bug in Spark 1.2.x with at work around that I am trying.

Seems like we should avoid 1.2 and 1.2.1 though we could tell someone how to make it work and only item and rowsimilairty are broken anyway.
So I'm testing this with Spark 1.1.1 and will push that for now. All that is required to upgrade to 1.2 or 1.2.1 would be the root pom Spark version change and build from source


KRunner fails to find installed dictionaries

Describe the bug

Since upgrading to Plasma 6.2, KRunner fails to find installed dictionaries in NixOS.
Steps To Reproduce
Steps to reproduce the behavior:

Install KRunner and some dictionaries. In my case, I have pkgs.kdePackages.krunner in environment.systemPackages and the following dictionaries in my user's packages:users.users.naxdy.packages = builtins.attrValues {
  inherit (pkgs)
    aspell
    hunspell;

  inherit (pkgs.aspellDicts)
    de
    en
    en-computers
    en-science;

  inherit (pkgs.hunspellDicts)
    en_US
    en_US-large
    de_DE;
};

Enable "Spell Checker" in KRunner's plugins
Open KRunner and type in "spell help"

Expected behavior

KRunner confirms that the word "help" is spelled correctly.
Screenshots

Additional context

Metadata

system: "x86_64-linux"
host os: Linux 6.11.5-zen1, NixOS, 24.11 (Uakari) 24.42.20241107.3aea494
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.24.10
nixpkgs: /nix/store/i7h0a3zw3nhv0fzyslfs2s4c476a4y9v-source

Notify maintainers

@ilya-fedin
@K900
@LunNova
@mjm
@NickCao
@SuperSandro2000
@ttuegel

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Can we somehow start krunner with strace and figure out where it wants to read the dicts from?

After a couple days of trying to navigate strace, I updated today and found that it's no longer an issue. This is on nixpkgs ref ac35b104800bff9028425fec3b6e8a41de2bbfff where it's fixed. If no one did anything on our end, I'm assuming it was upstream? Either way, issue is resolved.


Case Edit Form - HTML fields

adds buttons/logic for quick submit vs full submit

adds full key to article/thing json blob to handle full vs quick submit (let me know if you'd like to handle this differently)

moves handlebars helpers to it's own file to keep things organized, adds a bunch of helpers

adds html for fields
-- boolean/checkbox
-- text
-- date
-- number
-- single select
-- textarea
-- edit-list-ranked
-- edit-media-link-list
-- location (adds single text field for all location attributes, need to add js for autocomplete)

adds submit and floating submit buttons

adds placeholders for JS driven fields

adds temporary handling for select options until the api changes for this are merged in

Ah, I see what you mean by a full key now. Is it possible to render the form either way, but to hide/show using CSS to switch between full and quick views?

@dethe we are using css to show/hide the correct fields depending on if it's full submit or not. we are using the key on the article to set a data attribute called submit-type in order to set the correct css styles. https://github.com/participedia/api/pull/345/files#diff-8df5c69eb793c611517fc5a299761c7dR3
we could add the key to the parent node rather than the article node if that makes more sense...

@dethe moved the param check for full vs quick to a handlebars helper. think it makes more sense here. https://github.com/participedia/api/pull/345/files#diff-5cd984740a5faccec00678b105dc5be0R118


repository.Log with filename included in LogOptions will inf loop if file does not exist in repository

My issue is that the repository.Log with filename provided as an option will not search for changed directories by name, like the functionality in git log.

I have done a minor investigation.  I see that when diff trees are compared, if two directories have different hashes, instead of adding these directories as 'changed entities', we do nothing and then recurse into the directory to add changed files from within.  I believe my issue would be solved by adding a changed directory to changes when running a diff tree


Add HP VSR1000

Dunno for what really.. for the lulz!?
https://h10145.www1.hp.com/Downloads/SoftwareReleases.aspx?ProductNumber=JG811AAE&lang=en&cc=us&prodSeriesId=5443163

One for the lulz attempt here https://github.com/plajjan/vrnetlab/pull/128 :-)

Take two https://github.com/plajjan/vrnetlab/pull/129

This is now fixed, roughly by taking the changeset of #129 and then doing a few things differently and manually merging it.


Request to implement fisher exact-p in golang

If it is not already in the pipeline, i can create a pr to implement fisher exact p in pure go.

Before we go ahead with implementing a whole heap of statistical test functions, I like to have some idea of what the API for the test package is going to look like. Can you make suggestions at gonum-dev so we can have a discussion first.


promoted git-sync-annotation to spec field

Ⅰ. Describe what this PR does
It promotes git-sync annotation to the spec field
II. Does this pull request fix one issue?

#262
There are issues with deepcopy, should we write deepcopy for that manually.

cc @SimonCqk


What if my :8443 port is blocked and I just have the :80 port ?

What if I want to serve the uLogMe pages over a restricted network ?
Or if you want to access it with a simple URL instead of remembering the exact port ?

Simple! You can use a local nginx server to set up a proxy, so that: http://localhost/ulogme/ loads its content from http://localhost:8443/.
Cf. the full configuration in this gist, but the basic thing to do is this:
# Local proxy for uLogMe (https://localhost:8443/)
location /ulogme/ {
    proxy_set_header Host      $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_buffering            off;
    proxy_cache                off;
    proxy_ssl_verify           off;
    proxy_pass                 https://localhost:8443/;
}

It works perfectly fine:


Support metrics annotations for microprofile gRPC

There are standard annotations for micro profile metrics that the current Helidon CDI code creates interceptors for. This means that any gRPC service method annotated with one of these annotations will have metrics applied. The issue here is that using CDI interceptors to apply metrics does not really work for asynchronous methods such as gRPC methods (as an aside it would not work for async Jersey JAX-RS methods either) because the metrics will only wrap the actual method call and not the time between the start of the method and sending the async result.
We need to decide whether to do something different for gRPC. This might be difficult given how the rest of the Helidon MP code processes these annotations. We might have to use a different set of annotations for gRPC metrics.

This is sort of on hold until we've decided how it is going to work. The existing Helidon MP metrics code processes the metrics annotations and we cannot easily override this for gRPC methods. It may be that our only solution is to add some new gRPC specific annotations (e.g. @GrpcTimed etc), but this is TBD.

Initial implementation is done. This now requires examples and docs but the examples will require the MP client which cannot be done until the gRPC client is in the MP branch.


spicypy not found using caonda install

Attempted to install via conda.  Following error given:
conda install -c https://conda.anaconda.org/andrewannex spiceypy
Fetching package metadata .........
Solving package specifications: .
Error: Package missing in current linux-64 channels:

spiceypy

Anaconda version:
anaconda                  2.3.0                np19py27_0

Hi Ross thanks for writing in, I had not tested the anaconda cloud install of spiceypy on linux so I might just need to upload another artifact to their website, but I won't be able to get to this for a day or two.
That being said you can still install spiceypy using  pip instead of conda. Pip is included in your version of anaconda so you should be able to just run pip install spiceypy.
let me know if that works for you

so I started taking a look at this and it looks like I underestimated some of the complexities of conda. I will start work on conda files for linux and maybe macs. I will also probably update the documentation to emphasize installation using pip which is included in the miniconda and anaconda distributions.  @RossWilliamson if you are still having issues installing spiceypy using pip would work instead of using conda.

So I have taken another look at this and the news is not so good. First of all I made a false assumption when I thought conda would fallback automatically to pip, this is not the case.
From the start I also assumed most anaconda users were windows users (for some reason idk what). So I only made conda packages for windows as the build process is so complicated on windows. If a user has a mac or linux computer they have the tools out of the box to run the pip install with no other steps involved.
To properly support Linux/Mac with conda I will need to do some work on my end to make sure I have build environments ready to go for linux/mac. I do this already with windows using appveyor, and I anticipate being able to do this also using travis ci. This will be a non trivial amount of work so it may take me a bit, but it may be a good excuse for me to sort out automatic artifact uploading.
@RossWilliamson I will make a ticket for myself relating to the eventual fix for this, but as it doesn't prevent you from installing spiceypy using pip I would claim that this isn't a critical issue.

@RossWilliamson well it ended up not taking me all that long to sort this out. I now have conda packages built for 64 bit mac/linux for both python 2.7 and 3.5.
Let me know if that works for you. I will likely mark this issue as resolved in a day or two.

closing this ticket as I think I have resolved it, I still have a little work to do with automated artifact deployment