update charts

What is the purpose of the change
update skywalking
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #1020 (081bd95) into refactor-with-go (812bbff) will increase coverage by 15.65%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           refactor-with-go    #1020       +/-   ##
=====================================================
+ Coverage             67.07%   82.73%   +15.65%
=====================================================
  Files                    15       13        -2
  Lines                  1227      973      -254
=====================================================
- Hits                    823      805       -18
+ Misses                  364      130      -234
+ Partials                 40       38        -2

Impacted Files
Coverage Δ

pkg/authority/v1alpha1/ca.pb.go

pkg/authority/v1alpha1/ca_grpc.pb.go

pkg/authority/cert/storage.go
77.77% <0.00%> (+2.46%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


controller: create clustersync as separate reconcile

For a new ClusterDeployment, the ClusterSync is created and then immediately updated with the status of applying any syncsets. If there were errors applying syncsets, then the clustersync controller may do its next reconcile using the created version instead of the updated version. When this happens, the update at the end of the reconcile will fail due to a conflict.
With these changes, when there is no ClusterSync, the clustersync controller will create the ClusterSync as the only thing that it does for the reconciliation. The clustersync controller will requeue the ClusterDeployment when the controller sees the new ClusterSync, and the controller will not get any conflicts when doing updates.

/cc @csrwng

I like this change -- doing the creation up front rather than deferring it. But based on your explanation in slack (relevant bit copied below) I don't understand how it actually solves the problem.

Let's assume that we have a fresh ClusterDeployment with no ClusterSync. The first reconcile will do the applies of the syncsets, create a ClusterSync (version A), then update the ClusterSync with the status of the applies (version B). Asynchronously, the informers will inform the controller's watches that there has been a ClusterSync created and a ClusterSync updated. In response to both of those, the controller will requeue the ClusterDeployment. When the controller reconciles the ClusterDeployment again, the ClusterSync that is in the local cache may be either version A or version B. If it is version A, then any update of the ClusterSync during that reconciliation will fail with a conflict.
Doing an update of a resource in a controller does not directly change that resource in the local cache. The local cache only changes after the API server sends the change out.

With these changes, the clustersync will always do a reconcile using version A of the ClusterSync, but that reconcile will not have an update conflict because version B does not exist yet. Version B is created during the reconcile of version A, rather than during the reconcile where the ClusterSync does not yet exist.

Ah, sorry, I just noticed the return immediately after the create. ++.

I'm like totally leery of adding an actual /lgtm now. But this lgtm.

/retest
infra blew up

aha, I vaguely remembered there was a reason we only did create (and no update) within a single reconcile :) sorry overlooked in the initial review.

/lgtm


[Fixes #7587] No easy way to change ASPNETCORE_ENVIRONMENT

Set the environment to development by default. This allows users to write tests as long as the app runs with dotnet run/F5 on visual studio.

This was merged into 2.1


adding turbofan repository to external tests

@bqpd should be ready to merge

Will merge once we've 1) created the push/PR jenkins jobs for this, and 2) it's passing those.

Jenkins is ready, now the tests are just waiting on a syntax failure!

where is the syntax error occurring? I'm a little confused because when I run runtests.sh everything passes without an issue.

If you look at the error in https://acdl.mit.edu/csi/job/gpkit_ResearchModel_turbofan_Push/5/buildnode=macys,optimizer=cvxopt/parsed_console/, it says Couldn't parse '/Users/jenkins/workspace/gpkit_ResearchModel_turbofan_Push/buildnode/macys/optimizer/cvxopt/Fan_LPC.py' as Python source: 'invalid syntax' at line 9

oh weird that's an old file that shouldn't be used. do the tests try and compile every file or something?

Yeah, so that we can say what % of python lines in the repository are run by the tests.

If it's an old file, maybe remove it?

Or just change the extension to .py.old or something.

ah okay. there's a lot of old files i need to remove. i'll sort through them all and let you know when i think it's done.

@bqpd i have all the turbofan code in a ready to review state and the tests pass so I would like to merge this

Confirmed!


Chrome shortcuts do not work immediately after using quicktabs

After using quicktabs to change to a specific tab, standard chrome shortcuts like ctrl+tab and ctrl+w don't seem to work.
Chrome Version 44.0.2403.157 (64-bit)
Ubuntu 15.04 linux kernel 4.1.3-040103-generic 64bit

Are you seeing this issue with all tabs or just specific websites?  Quick Tabs doesn't install key listening content_scripts on pages any more.

It seems to work every now and so often on some sites (worked on arstechnica just now), but when I try it out again I get the same issue (even on arstechnica for example). Is there any way I can provide more information for debugging?

I'm having the same issue. When using quicktabs to switch to a tab, it retains focus. It seems to do this only if you search and pick a selection and hit enter (doesn't happen if I cancel using Esc). After the enter quicktabs still catches all key-combinations. The way around this is to do a new quicktabs toggling and directly hit Esc, that makes key combinations work again.
Also running on Linux with Chromium Version 45.0.2454.85 (64-bit).

I wonder if this is a Linux specific issue, I have not managed to reproduce it on my Mac.  Thanks for reporting these extra details, any further thoughts would be very helpful.
Version 45.0.2454.93 (64-bit)

I have the same described issue:
Shortcuts ctrl+w, ctrl+t, ctrl+n, ctrl+pg_up/pg_down do not work after entering tab from quicktabs.
Ubuntu 14.04.3 LTS 64 bit
Version 43.0.2357.125 (64-bit)

I have just deployed code that unbinds the document event listeners when the popup closes (version 2015.10.7), hopefully that will resolve this issue, please let me know if it persists...

this issue could be related to #67

Still having the same issue.

Somehow, in my case, the solution was that my keyboard wasn't in english layout... when I change to english it works!


Adding version check for iPhone

Adding the ability to pass in and check the version number when using the is.iphone method.
These comparisons were written and tested based on the user agent string examples found here:
http://www.useragentstring.com/pages/Safari/

Closed by https://github.com/arasatasaygin/is.js/commit/89d6743eddb3c0bfad9515de9c9d45ec92ceacaf.


Email Message Missing

When I populate the Message field, the email I receive does not contain the message.
I am using docker run with this image: remie/youtransfer

Same for me !
Try to find a solution on my side.
I give you soe feedback if i find something....


[ServiceBus] Support fully qualified namespaces both with and without "sb://" prefix.

Currently, one will get a Connection or Timeout error when attempting to connect a servicebusclient if your fqdn contains "sb://".
This is not the case in dotnet.  The assumption being that we should normalize and support both formats.
CC @ramya-rao-a on this observation in case I'm off in left field.

In JS, I believe we strip out "anything://" from the endpoint in the connection string.
Not sure what we do for the fully qualified namespace that is passed to the client constructor
But @HarshaNalluru would know :)

Looks like this has already been addressed with the strip_protocol_from_uri method in azure/servicebus/_common/utils.py.
Works with both:

<sb/http>://<sb-namespace>.servicebus.windows.net
<sb-namespace>.servicebus.windows.net

Addressed in both sync and async clients:

Sync Client, line 74
Async Client, line 75

Looks like this has already been addressed with the strip_protocol_from_uri method in azure/servicebus/_common/utils.py.
Works with both:

<sb/http>://<sb-namespace>.servicebus.windows.net
<sb-namespace>.servicebus.windows.net

Addressed in both sync and async clients:

Sync Client, line 74
Async Client, line 75


Forward solve with DifferentialEquations.jl and exponential integrators for constant Hamiltonian and Lindblad terms.

Fix the comments

@ZhichaoPengMath I fixed the broken checks. You fix the comments. Use markdown.


[Code health] Add general guidelines for writing tests to README

From https://github.com/google/ground-android/pull/1027#issue-1034130097

@mmisim Would you like to work with @shobhitagarwal1612 to incorporate his guidance in https://github.com/google/ground-android/pull/1027#issue-1034130097 into our contributor docs?

@shobhitagarwal1612, I can help with this if needed.


Helm can't enable geneve protocol:  line 132: mapping key "tunnel-protocol" already defined at line 131

We are attempting to change our helm config to use Geneve instead of VXLAN, so what we can use DSR in our cluster.  Unfortunately, native routing mode is not an option in our case.
When attempting to deploy the helm chart with tunnelProtocol: geneve we get the error:
line 132: mapping key "tunnel-protocol" already defined at line 131

I believe this is due to the fact that the line referenced below is creating the tunnel-protocol: vxlan line.
https://github.com/cilium/cilium/blob/5614531067a83e20d24bccc7b12b314330d043c3/install/kubernetes/cilium/templates/cilium-configmap.yaml#L477
Then when it gets further down and tries to insert the geneve line, this is seen as a duplicate entry.
https://github.com/cilium/cilium/blob/5614531067a83e20d24bccc7b12b314330d043c3/install/kubernetes/cilium/templates/cilium-configmap.yaml#L481
I think the "default" in helm just needs to be a little smarter here to allow for properly enabling Geneve.
We are specifically running helm chart version 1.15.6, but it looks like this issue exists in the main branch and probably also affects 1.16.x release.

@CompPhy  I am not 100% sure if it a bug but we have been using 'geneve' protocol in all of our ops clusters and using helm to deploy cilium. We pass values.yml file where values are placed as:
kubeProxyreplacement: true
loadBalancer:
  mode: dsr
  dsrDispatch: geneve
routingMode: tunnel
tunnelProtocol: geneve

And this been working for us during new installation or upgrade.

Hi @CompPhy, your report makes sense and I agree that the Helm templates just need to be made a bit more smart. Would you be willing to send a PR to fix this up?


index out of bounds when running any Bevy example

Bevy version
7673db731e7de0039dd97aa9c1b4ddf675ef9d60
Issue exists since #5413, and disappear if I revert that commit
[Optional] Relevant system information
AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, backend: Metal }

What you did
cargo run --example load_gltf --release

    Finished release [optimized] target(s) in 0.16s
     Running `target/release/examples/load_gltf`
2022-10-11T00:45:54.918977Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, backend: Metal }
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', crates/bevy_render/src/lib.rs:168:70
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

it seems to be running OK in CI so potentially a macOS bug

Ping @VitalyAnkh for thoughts.

Presumably this is only occurring for you on examples that invoke the renderer? Hello World for example shouldn't hit this path at all.

I can't reproduce this on Window 10; I suspect this is Mac specific.

reading the code, this will happen on iOS and android too. on those systems we don't create the window early, so the surface is not yet available when initialising the renderer

this will happen on iOS and android too

The linked PR makes sense. Thanks! I wonder why the "run exampes" check didn't catch this problem. Should we make this check examples on more platforms/features?

There is a balance with CI time and example coverage.
At one point I wanted to try to mitigate this by running the examples occasionally in a separate repo with a dashboard: https://rparrett.github.io/prototype_bevy_example_runner/
This runs all examples, but only on Linux right now.

Bevy CI is running a few examples in wasm on firefox and chrome, and in native on linux and windows.
There may be a way to also run them on macOS, but I haven't had the time to set it up yet. Running on iOS and android would be great, but I'm not aware of it being possible in GitHub actions


Can Paste option be added to the command palette since copy is available?

Great tool! I use it when working with Linux VMs. I read one of issues about the paste feature. Is that the reason why Paste is not available in the command palette. Since I work on OS X, switching b/w the Ctrl and Cmd keys can be a problem sometimes, and easy access to basic functions via the command palette makes it easier.

Thanks for reporting this. It just looks like a mistake on my behalf for not having Paste in the command palette all the time.


Replace Twitter references in the docs with more appropriate alternatives

Pertinent section of the Wagtail docs
Our official tutorial, embeds docs, third-party tutorials.
Details
While we’re X users, we’ve decided to move the bulk of our activity to other platforms (see our announcement). We have a few Twitter references which are out of date as the platform’s changed names, and we’d now rather switch to showcasing networks that are more relevant for us and Wagtail users (for example Facebook or LinkedIn).
Related: #12459
Working on this

Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.
There are a few references, so this could be separate PRs from different people:

[ ] OEmbed docs examples
[ ] Official tutorial
[ ] Site settings examples
[ ] Third-party tutorials (one link, one "let us know on Twitter")

@ayaan-qadri nope :)

Hey @Srishti-j18, I have been working on this issue, but as I’m still new to Wagtail, taking time to read and understand the documentation and codebase. Are you planning to resolve this one? If so, I’ll happily move on to another issue.

Hey @Srishti-j18, I have been working on this issue, but as I’m still new to Wagtail, taking time to read and understand the documentation and codebase. Are you planning to resolve this one? If so, I’ll happily move on to another issue.

Hi @ayaan-qadri ,
Yes, I am planning to work on this issue, but since you are also working on it, we can collaborate and make changes together. We can also discuss it on Slack for better judgment, as this task requires suggestions from different people to ensure meaningful improvements.

Sure thing @Srishti-j18, Glad to collaborate and discuss over slack, I'm with same name as github on slack.

Hey @thibaudcolas, So after reading and understating docs and bit of codebase, I can now get into this and these are the files possibly needs to change (@Srishti-j18 lemme know which files are you gonna be edit) :

I'm bit confused, like should i also need to change 'Twitter' to 'X' for example in this tutorial
twitter_url = models.URLField(verbose_name="Twitter URL", blank=True)
to
x_url = models.URLField(verbose_name="X URL", blank=True)
or will this be replaced by appropriate alternatives ?

(@Srishti-j18 lemme know which files are you gonna be edit) :

Hey, I was a bit busy, so I haven't started editing yet. You can choose the first files you want to edit, and I'll work on the others.

I'm bit confused, like should i also need to change 'Twitter' to 'X' for example in this tutorial
twitter_url = models.URLField(verbose_name="Twitter URL", blank=True) to x_url = models.URLField(verbose_name="X URL", blank=True)
or will this be replaced by appropriate alternatives ?

I think we can replace it with a LinkedIn URL .It might be the better option for portfolio site.

I think we can replace it with a LinkedIn URL .It might be the better option for portfolio site.

Both works for portfolio site, but i think this is not specific to what the issue as it is more specific on wagtail itself, not the tutor which is for personal use case (it is portfolio site in tutorial).

While we’re X users, we’ve decided to move the bulk of our activity to other platforms (see our announcement). We have a few Twitter references which are out of date as the platform’s changed names, and we’d now rather switch to showcasing networks that are more relevant for us and Wagtail users (for example Facebook or LinkedIn).

We just have to wait until @thibaudcolas to reply on this.

Hey @ayaan-qadri and @Srishti-j18 I would also love to collaborate and work with you guys on this. I am also pretty new to wagtail so I'm also figuring out the codebase.

I’ve assigned this to @ayaan-qadri for the time being. Let’s leave them time to figure out which aspects of this they want to work on, before other people attempt to work on this. There are plenty other interesting issues to work on so we don’t all need to rush for this one.

Thank you for picking this up @ayaan-qadri! As far as I can tell you’ve updated all the relevant Twitter references in the docs with more relevant options, so I’ve closed this now.

Yes @thibaudcolas, most references have been changed, but there are still some Twitter mentions. I think they are meant to be there, though (lemme know if we should change it too):
releses/4.0.md:

https://docs.wagtail.org/en/stable/releases/4.0.html#other-features
reference/settings.md

https://docs.wagtail.org/en/stable/reference/settings.html#embeds
releses/2.14.1.rst

https://docs.wagtail.org/en/stable/reference/settings.html#embeds
advanced_topics/third_party_tutorials.md

https://docs.wagtail.org/en/stable/advanced_topics/third_party_tutorials.html

thank you @ayaan-qadri, yes I think all those references are fine.

@thibaudcolas I think the one in reference/settings.md could perhaps be changed to Reddit to match the same sentence in advanced_topics/embeds.md, seeing as Twitter embeds apparently don't work any more (as reported by @cnk on Slack)?
Agreed that the release notes and third-party tutorials don't need changing.

@gasman before making this change:

i tested if tweeter's embeds still work or not it was working and again for surety i freshly docker setup to check is it still working:

404.html:

Note:

when i was trying to hit any random route it was throwing django 404 not the wagtail
I do not think that this happening because of old embeds (embedded when it was tweeter, not X) because still the url structure is same (post > three dots > Embed post)


can't parse float timestamp

for this float timestamp in sec<PHONE_NUMBER>.370 it should parse as  2019-11-12T18:23:59.369Z in format "2006-01-02T15:04:05.000Z". but it's not happening and getting  "1573583039.370": hour out of range error.

I'm gonna work on this issue


Custom request

@dirkjanfaber I dont get all the values I was hoping for using the "diagnostic data", since it is limited to 100. And I cant figure out how to send a spesific request with a inject node. For instance this request : https://vrmapi.victronenergy.com/v2/installations/NNNNNNN/widgets/Status
I am quite new to this, so sorry if this is something I should have picked up my self, byt can someone explain how to inject a custom request?

Sorry for the late reply. Guess you are not that new to it anymore by now. ;)
There is only support for the Summary State widgets in the node. Afaik a global widgets/Status does not exist as an API endpoint.
Closing this issue. Feel free to open a new one if you still struggle with this.


Articles on Wiki

My thoughts as someone who built a React.js and Redux app:
This is not very beginner-friendly, but sufficient.
In fact, I found it easier to just create my own boilerplate.
I don't know if it makes sense to add related articles to the Wiki. We do that in several open source projects. Or should we just point to a repository like https://github.com/xgrommx/awesome-redux?

Hey Katherine, thanks for coming by!

This is not very beginner-friendly

Can you expand on this? If there is anything you think we could improve to make this tool more beginner-friendly, I’d like to know!

I don't know if it makes sense to add related articles to the Wiki.

We started this project to solve the problem of the build configuration being too intimidating. So far the focus hasn’t been on “How do I learn React?” but rather “How do I get started with a production-ready build configuration without learning Webpack, Babel, etc?”
We have plans to revamp the React documentation itself to be more beginner-friendly but this is out of scope of this particular project. Perhaps, however, we are in a unique position to offer links to good React guides, so I will consider this.
We probably won’t link to anything related to Redux though because React beginners often get confused by it. Redux is fine when your app is bigger, but we’d like to make sure people learn React itself first. Additionally, “awesome” lists are very long and give the impression that you have to choose from a thousand of options. I would rather link to a few good articles than to a list of a hundred medium-quality articles.
I hope this makes sense. Would love to hear more you thoughts on this.

@gaearon So I understand now that this isn't an equivalent of ember-cli for React.js. I had a great expectation. It's definitely off scope. For many projects, I think Redux-first approach sort of helps. I look forward to that boilerplate project or I could write up about it. I admit I spent many hours just learning webpack.
This is helpful enough for absolute beginners, but pointing them to a documentation or a list of articles would be helpful. Thank you!

No, it’s much more modest in scope than ember-cli. We just want to solve the build configuration. Code generation, plugins, or customization are not something we are working on, although we might explore this in the future.


feat: nope resolver

Welcome to a new resolver: nopeResolver 🎉
Related to https://github.com/react-hook-form/resolvers/pull/18, the issue bvego/nope-validator#288  is closed.
FYI

sync mode only
No support criteriaMode: all

Thanks to @kysley for the first implementation!

wow another resolver!


Tado Presence detection not creating entities

Home Assistant release with the issue:

0.102.3
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Docker (homeassistant/home-assistant:latest), running on Synology DS1817+
Integration:

https://www.home-assistant.io/integrations/tado/
Description of problem:
Presence detection set up as described in the link above, and per yaml extract below.
Tado climate and sensors working fine.
API URL used for presence detection returns appropriate content - https://my.tado.com/api/v2/homes/xxxxx/mobileDevices?username=xxxx&password=xxxx, i.e. JSON with details of the 4 users attached to my tado account.
Log file with DEBUG level of detail says:
2019-12-07 21:56:50 DEBUG (MainThread) [homeassistant.components.tado.device_tracker] Tado presence query successful, 1 device(s) at home
This is correct, currently only one of the four users of the account are at home.
However there are no associated device_tracker entities viewable via the UI, e.g. Configuration / Entities.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
# Tado support
tado:
  username: xxxx
  password: xxxx

# Tado device tracking support
device_tracker:
  - platform: tado
    username: xxxx
    password: xxxx
    home_id: xxxxx

Traceback (if applicable):

Additional information:

On looking at this a bit more maybe it is expected behaviour for a device_tracker created via the configuration.yaml file rather than via the UI - as I see the same with this integration - https://www.home-assistant.io/integrations/google_maps/.
The entities created can be seen when adding them to a person via the UI, but they are not listed when you browse the list of entities in the UI - which is what I was doing before.

I don't use the device tracker of tado so I don't know how it behaves. The code is also seperated of the climate integrations.

@davideyre so I suppose that this isn't a bug then. Feel free to reopen if you think otherwise.


Add siemens CT header

nipype currently fails to parse the CSA string from this dicom.  I do not believe it is corrupt, just not supported yet.

Are you (and any relevant institutional authorities) okay with this being released into the public domain by way of the CC0 license?

My boss has asked to redact a few more things...I'll get back to you with a new one.


Implementation of Generative Adversarial Network (GAN) for MNIST Handwritten Digits From Scratch in Keras

💥 Proposal
I want to implement a Generative Adversarial Network (GAN) from scratch using the Keras framework to generate realistic MNIST handwritten digits. This GAN will consist of a generator and a discriminator, where the generator will learn to generate realistic digits, and the discriminator will learn to distinguish between real and generated digits.
I would like to request that you please assign it to me under the tag/label GSSoC'23.

@SAPNILPATEL  - you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!
Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.

I'm a contributor for GSSoC '23, I want to work on this issue. Please assign me.

@UditSharma9999 - since we are following the first-come-first-serve policy, we will not be able to assign you this issue. However, you can create another issue on the similar lines.


errors not shown after starting webpack dev server after initial start

node 11.12.0
webpack 4.8.2
webpack dev server 3.1.1
eslint-loader 2.1.2
after doing a fresh install, and starting webpack dev server, the loader will properly display lint warnings/errors. I can go through and edit files to fix the issues, and when dev server refreshes, it shows the remaining issues.
if I stop the dev server, then just start it, no warnings/errors are displayed, even though I know there still are some.
{
        enforce: 'pre',
        test: /\.(ts|tsx)$/,
        include: [path.join(cwd, 'src/js')],
        loader: 'eslint-loader',
        options: {
          configFile: '.eslintrc.js',
          emitWarning: true,
          cache: false,
        },
      },
      {
        include: [path.join(cwd, 'src/js')],
        test: /\.(ts|tsx)$/,
        use: [
          {
            loader: 'cache-loader',
          },
          {
            loader: 'thread-loader',
            options: threadLoaderOptions,
          },
          {
            loader: 'babel-loader',
            options: {
              cacheDirectory: true,
              cacheCompression: false,
              babelrc: false,
             .....other stuff
            },
          },
        ],
      },

if I remove cache loader it displays all the time and this issue does not occur.
is there a way to display the issues all the time while using cache loader?

just to update, I also found that if I add
failOnWarning: true

this issue doesn't occur. however during development, i'm wanting it to still compile, and fix as I go.
we have a pretty large project, so disabling cache loader doesn't seem to be an option for.

any enabling of cacheing in the loader causes this issue as well. tried cache: true, and failOnWarning: true, but the issue persists.

Exactly the same situation here. Any chance to fix this?

We ended up removing cache loader and turning on cacheing for eslint loader not as fast but ok for now

The same.

I found that if you make sure to enable root: true and what not from eslint to make sure it doesn't recursively check for eslint, that gave us a perf boost for sure.

@kelly-tock could you provide a repository ?

@ricardogobbosouza @kelly-tock
Repro repository provided here: https://github.com/barberdt/loader-issue
Repro steps:

@ricardogobbosouza @kelly-tock
Repro repository provided here: https://github.com/barberdt/loader-issue
Repro steps:
$ git clone git@github.com:barberdt/loader-issue.git
$ cd loader-issue
$ yarn install
$ yarn run test

Observe the output of the single eslint error:

ERROR in ./index.js
Module Error (from ./node_modules/eslint-loader/dist/cjs.js):

/Users/davis/github/loader-issue/index.js
  1:13  error  'foo' is not defined  no-undef

✖ 1 problem (1 error, 0 warnings)

ℹ ｢wdm｣: Failed to compile.

Kill the dev server
Start the dev server again (yarn run test)
Observe a successful build instead of seeing the expected error.

Restarting the server from this point forward should continue to show a false successful build.
Without having dug into the issue itself, I'm not 100% sure which repo this issue belongs to between eslint-loader, cache-loader, babel-loader, webpack, and webpack-dev-server, but this was the most fleshed out of the related issues, so I thought I'd post here. Happy to move this repro around wherever needed.

Thanks for providing this!

Hi @barberdt, @ kelly-tock
Thanks for reporting
I do not recommend using cache-loader and eslint-loader together, use the cache option
But if you want to use both together, enable the failOnError option.
Soon this loader will be deprecated in favor of this plugin eslint-webpack-plugin

I am using typescript so recently switched raking over to be handled by fork ts checker plugin

@ricardogobbosouza Which loader exactly will be deprecated? Caching or ESLint? When will that deprecation happen, and is there a guide present for moving from one to the new plugin?

Hi @onebree

We are analyzing the depreciation of the eslint-loader
We will be launching v1.0.0 of eslint-webpack-plugin  until this weekend

Please use eslint-webpack-plugin. eslint-loader will be deprecated.


Unregister field from the form's state

What
Need to call some unregister method (similar to mapFieldToState) when unmounting the component.
Why
Right now the internal references and props of the field still reside after the field has been unmounted. You would never what this behavior on purpose. Field's reference in the state should be removed, and state updated.

Also, since mapFieldToState() now has an opposite method, it would be good to rename it to registerField(). It's used for internal purposes anyway, which makes it clear.

Field not calls Field.context.unregisterField() to remove its bindings from the Form upon unmount. Closing.


Add support for Teradata SQL

Very simple ask, support for Teradata SQL through VS Code SQL Tools. There's currently a VS Code Teradata driver, but it doesn't function at all. I've tested on 5 different versions of VS Code, and none of them work with Teradata driver (linked below). I don't think I would be able to figure out a fix for this driver, unfortunately, as it's written in typescript which I'm unfamiliar with, and would require a huge amount of time investment to learn how to develop a working extension.
The error for Teradata driver occurs when the extension tries to register a plugin but encounters a problem with the process. This could be due to incorrect file paths or other issues related to how the extension is set up to handle this registration.
https://github.com/ScriptPup/sqltools-teradata-driver/tree/master

I think this needs to be resolved by the extension author. I saw you had created https://github.com/ScriptPup/sqltools-teradata-driver/issues/28 so I am going to close this here.


adding term "linux" specifying it as 'Unix like'

Fixing a probable translation problem adding the "unix like" term to best understanding.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Validation issue

After the "standardized" format is written, we delete the original non-standard file. If the file then fails to extract metadata, then the final path is not updated in the Resource object.
This will be more generally addressed as part of improved/clearer validation flows.
Here is an example log:
2022-06-19 18:24:27,653 api.utilities.resource_utilities.validate_resource INFO     Validate resource 26beb427-e995-49d8-811f-105c80ec0b65 against requested type of: ANN
2022-06-19 18:24:27,654 api.utilities.resource_utilities.validate_resource INFO     Since the resource class permits validation, go and validate this resource.
2022-06-19 18:24:27,659 api.storage_backends.google_cloud.get_local_resource_path INFO     Pulling Resource (26beb427-e995-49d8-811f-105c80ec0b65) from google storage to local cache.
2022-06-19 18:24:27,662 api.storage_backends.google_cloud.get_local_resource_path INFO     Resource was already located in the local cache.
2022-06-19 18:24:27,899 api.storage_backends.google_cloud.get_local_resource_path INFO     Pulling Resource (26beb427-e995-49d8-811f-105c80ec0b65) from google storage to local cache.
2022-06-19 18:24:27,900 api.storage_backends.google_cloud.get_local_resource_path INFO     Resource was already located in the local cache.
2022-06-19 18:24:27,900 api.utilities.resource_utilities.handle_valid_resource INFO     The local path prior to standardization is: /data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80>
[2022-06-19 18:24:27,900: INFO/ForkPoolWorker-2] Saving resource with path (/data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80ec0b65) to the standard format. for a table-based resour>
[2022-06-19 18:24:27,900: INFO/ForkPoolWorker-2] Writing the reformatted table-based resource to: /data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/39dcc445-2c09-40b0-8e19-80ca409165f9. The new name is 1-s2.0-S08>
[2022-06-19 18:24:27,905: WARNING/ForkPoolWorker-2] /data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/39dcc445-2c09-40b0-8e19-80ca409165f9
[2022-06-19 18:24:27,905: WARNING/ForkPoolWorker-2]
[2022-06-19 18:24:27,906: WARNING/ForkPoolWorker-2] 1-s2.0-S0888754319303714-mmc4 (2).tsv
[2022-06-19 18:24:27,906: WARNING/ForkPoolWorker-2] ????????????
2022-06-19 18:24:27,906 api.utilities.resource_utilities.handle_valid_resource INFO     The standardization changed the path. Go delete the non-standardized file: gs://webmev-storage-prod/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff>
2022-06-19 18:24:27,911 api.storage_backends.google_cloud.delete INFO     Requesting deletion of file at gs://webmev-storage-prod/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80ec0b65
2022-06-19 18:24:27,912 api.storage_backends.google_cloud.get_blob INFO     Get blob at gs://webmev-storage-prod/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80ec0b65
2022-06-19 18:24:27,912 api.storage_backends.google_cloud.get_bucket INFO     Requesting bucket: webmev-storage-prod
2022-06-19 18:24:28,010 api.storage_backends.google_cloud.get_blob INFO     Get blob at gs://webmev-storage-prod/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80ec0b65
2022-06-19 18:24:28,010 api.storage_backends.google_cloud.get_bucket INFO     Requesting bucket: webmev-storage-prod
2022-06-19 18:24:28,186 api.storage_backends.google_cloud.delete INFO     Successfully deleted file at gs://webmev-storage-prod/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/26beb427-e995-49d8-811f-105c80ec0b65
[2022-06-19 18:24:28,187: INFO/ForkPoolWorker-2] Extracting metadata from resource with path (/data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/39dcc445-2c09-40b0-8e19-80ca409165f9).
[2022-06-19 18:24:28,187: INFO/ForkPoolWorker-2] Resource with path (/data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/39dcc445-2c09-40b0-8e19-80ca409165f9) was previously parsed.
[2022-06-19 18:24:28,187: INFO/ForkPoolWorker-2] Pre-populate/setup empty metadata.
[2022-06-19 18:24:28,187: INFO/ForkPoolWorker-2] Done with setting up the metadata.
[2022-06-19 18:24:28,187: INFO/ForkPoolWorker-2] For element type <class 'type'>, extract out metadata
2022-06-19 18:24:28,576 api.utilities.resource_utilities.add_metadata_to_resource INFO     Resource had some existing metadata, so update.
2022-06-19 18:24:28,628 api.async_tasks.async_resource_tasks.validate_resource INFO     Caught an exception raised by the validate_resource function.
[2022-06-19 18:24:29,160: INFO/ForkPoolWorker-2] Task validate_resource[e966a286-937a-4caf-ba8a-1ef2b8a0efd1] succeeded in 1.5240549901500344s: None
[2022-06-19 18:25:21,505: INFO/MainProcess] Task validate_resource[f6986115-0c9c-4a3f-9783-a37bb4d3ed35] received
2022-06-19 18:25:21,526 api.utilities.resource_utilities.validate_resource INFO     Validate resource 26beb427-e995-49d8-811f-105c80ec0b65 against requested type of: EXP_MTX
2022-06-19 18:25:21,526 api.utilities.resource_utilities.validate_resource INFO     Since the resource class permits validation, go and validate this resource.
2022-06-19 18:25:21,532 api.storage_backends.google_cloud.get_local_resource_path INFO     Pulling Resource (26beb427-e995-49d8-811f-105c80ec0b65) from google storage to local cache.
2022-06-19 18:25:21,536 api.storage_backends.google_cloud.get_local_resource_path INFO     Did not locate file in local cache. Download it.
2022-06-19 18:25:21,536 api.storage_backends.google_cloud.get_blob INFO     Get blob at /data/resource_cache/user_resources/23cf8ea3-15d8-46c6-ad2b-762e9cff430c/39dcc445-2c09-40b0-8e19-80ca409165f9
2022-06-19 18:25:21,536 api.storage_backends.google_cloud.get_bucket INFO     Requesting bucket:
2022-06-19 18:25:21,537 api.storage_backends.google_cloud.get_bucket INFO     Failed to retrieve bucket () for unexpected reason. Check that this bucket exists.
2022-06-19 18:25:21,537 api.storage_backends.google_cloud.get_blob INFO     Could not retrieve the desired bucket due to an unexpected error.

we no longer delete the 'non-standard' resource, so this is moot


[wallet-kit] Add wallet kit docs site

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Current dependencies on/for this PR:

main

PR #8736   👈

This comment was auto-generated by Graphite.


changing some settings causes custom theme to be lost

Go to Settings > Themes
Enter a custom theme (I'm using #222222,#E2E2E2,#FFFFFF,#00789E,#004A79,#017D73,#092B40,#42b7c5,#2A7580,#ecb30a,#333333,#89ADCC,#6D6D6D,#FFE7E7,#ECFEFF but it probably doesn't matter)
click Apply
Navigate to sessions
Navigate back to settings
enter something in Hide Tags From Sessions
tab out of the text input there
the theme is reset

See video:
https://github.com/user-attachments/assets/c5b8b1af-8311-4216-806c-08267f398826

This happens with almost any setting change, just sometimes you need to do a reload to see it. Looks like setTheme has this.settings.theme = 'custom-theme'; which replaces the theme on next save so on next reload the theme is lost.


after merging two clusters, pressing  should pin the newly created (and now selected) cluster

After merging the new cluster is correctly displayed and seems to be selected. If you press enter here you'd expect to pin it and continue working on that cluster.
Currently, instead, it pins the next one in "spacebar order", i.e. the next one you'd see if you pressed spacebar rather than enter.

Fixed on an upcoming PR (pushed once @nippoo merges the previous one)


Path with spaces in directory name

I'm trying to tell jrnl the path to a folder for storage of journal.txt. The folder has spaces in the name.
If I try to set up with this path:
~/Files/Office\ Briefcase/Notes/journal.txt

Jrnl then makes a folder named "Office\ Briefcase" inside of the directory "Files".
I then just tried to use a blank space and it worked:
~/Files/Office Briefcase/Notes/journal.txt

This was a bit confusing.

This is a non-issue in 2.0 since it uses YAML, which precludes the need for any escape characters.


CheckAndRefreshAccessToken and refreshAccessToken typescript declaration is invalid

Describe the bug
checkAndRefreshAccessToken and refreshAccessToken functions return a promise and not void.
The consequence is call to this function cannot be blocking and create issue when calling getAccessToken that returns undefined or an obsolete token.
Here is the declaration in types/index.d.ts, we can see comment is correct but declaration not ;-)
  /**
   * Checks if a token is needed, can be refreshed and if the token is expired.
   * If so, attempts to refresh access token
   * @returns {Promise<*>}
   */
  checkAndRefreshAccessToken(): void;

Expected Behavior
Prototype should be
checkAndRefreshAccessToken(): Promise<void>;
refreshAccessToken(): Promise<void>;

Versions
Latest version v10.31.0 under typescript backend app (nestjs)

Thanks for the report. I'll ask the team to correct this.

I also have this issue.  checkAndRefreshAccessToken works as expected, but only if I await it.

Thanks for the note. This is still open with the team.


Plains of Pain template help?

Hey everyone! I’m a complete noob with all of this stuff, I was attempting to create a template for Plains of Pain so I could setup a server for myself and some friends. Any chance I can get someone’s assistance with doing this? I’ve been googling and messing around with no success. It would be GREATLY appreciated!
Thanks in advance and keep doing what you guys are doing because this software is AMAZING!!

Doesn't look like they have made the dedicated server available for self hosting. You need to rent from 4NetPlayers

Doesn't look like they have made the dedicated server available for self hosting. You need to rent from 4NetPlayers

Seems like they've changed some things and we are now able to create our own hosted worlds. Still not sure how to go about setting up a template for AMP though. :-(

I don't see any evidence that the dedicated server is broadly available. In-game multiplayer is not the same as running a dedicated server

Plains_of_Pain_-Dedicated_Server-_Windows_Setup.pdf

I don't see any evidence that the dedicated server is broadly available. In-game multiplayer is not the same as running a dedicated server

I got this directly from the Dev of the game.
Plains_of_Pain_-Dedicated_Server-_Windows_Setup.pdf

Great, that will make it easy then.

Great, that will make it easy then.

I guess I'm too dumb. LOL

Was there any progress with this Greelan? I’ve not been successful, but I’ve no where near your knowledge with this stuff.

Yeah, it was done last week. But the server is badly built. It basically limits you to only using the default game port, and using the command line arg to set that port stops the query port from being opened. I've noted this to the dev

Ah okay, is it anywhere I can get it? I didn’t see it in your GitHub, that’s why I was asking if there was any progress. I appreciate the time you’ve taken for this!

Greelan/AMPTemplates:dev
But you won't be able to connect to the server until the devs fix their issue.


Darken background image: Too Dark

"Darken background image", this is the same as in P8 in an old Ps5ish version and then later on got fixed in P8 but now came back in P9 where the background is set way too Dark even when slider + 1

Fixed in v4.5.0, no ETA on release yet.


Designer UI breaks when adding a default to switch statement

Describe the Bug with repro steps
It doesn't happen reliably, but:

Create a new workflow
Init a variable
Switch on variable value
Implement some actions for each case
Add action to default case
Hit save

EDIT: this seems to happen with multiple Response actions. So use a response inside the Default case and then add a Response directly after the switch statement.
EDIT2: I think this has something to do with the fact that actions get cached in some way. Often when I add an action of the same type, it will be named exactly the same as a previous action I created earlier (after renaming).
EDIT3: Sometimes hitting save multiple times can cause this too. I generally hit save 2-3 times because often any changes I make get reverted for some reason.
I think the cause might be that the runAfter property gets updated incorrectly. In my case it changed the Switch action to run after the new action inside the Default case. It even shuffled around all the actions inside the other cases.

What type of Logic App Is this happening in?
Standard (VSCode)
Which operating system are you using?
Windows
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
{
    "definition": {
        "$schema": "https://schema.management.azure.com/providers/Microsoft.Logic/schemas/2016-06-01/workflowdefinition.json#",
        "actions": {
            "Switch_(subdomain)": {
                "type": "Switch",
                "expression": "@toLower(triggerBody()?['subdomain'])",
                "default": {
                    "actions": {
                        "Response_(404_-_key_not_found)": {
                            "type": "Response",
                            "kind": "Http",
                            "inputs": {
                                "statusCode": 200
                            },
                            "runAfter": {
                                "Get_secret_(key1)": [
                                    "SUCCEEDED"
                                ]
                            }
                        },
                        "Terminate_(404_-_key_not_found)": {
                            "type": "Terminate",
                            "inputs": {
                                "runStatus": "Failed",
                                "runError": {
                                    "code": "404",
                                    "message": "Could not find api key in key vault"
                                }
                            },
                            "runAfter": {
                                "Response_(404_-_key_not_found)": [
                                    "SUCCEEDED"
                                ]
                            }
                        }
                    }
                },
                "cases": {
                    "Case_(dev)": {
                        "actions": {
                            "Get_secret_(key2)": {
                                "type": "ServiceProvider",
                                "inputs": {
                                    "parameters": {
                                        "secretName": "key2"
                                    },
                                    "serviceProviderConfiguration": {
                                        "connectionName": "keyVault",
                                        "operationId": "getSecret",
                                        "serviceProviderId": "/serviceProviders/keyVault"
                                    }
                                }
                            },
                            "Set_variable_(ApiKey)": {
                                "type": "SetVariable",
                                "inputs": {
                                    "name": "ApiKey"
                                },
                                "runAfter": {
                                    "Get_secret_(key2)": [
                                        "SUCCEEDED"
                                    ]
                                }
                            }
                        },
                        "case": "dev"
                    },
                    "Case_(support)": {
                        "actions": {
                            "Get_secret_(key1)": {
                                "type": "ServiceProvider",
                                "inputs": {
                                    "parameters": {
                                        "secretName": "key1"
                                    },
                                    "serviceProviderConfiguration": {
                                        "connectionName": "keyVault",
                                        "operationId": "getSecret",
                                        "serviceProviderId": "/serviceProviders/keyVault"
                                    }
                                }
                            },
                            "Set_variable_(ApiKey2)": {
                                "type": "SetVariable",
                                "inputs": {
                                    "name": "ApiKey"
                                },
                                "runAfter": {
                                    "Response_(404_-_key_not_found)": [
                                        "SUCCEEDED"
                                    ]
                                }
                            },
                            "Response_(404_-_key_not_found)": {
                                "type": "Response",
                                "kind": "Http",
                                "inputs": {
                                    "statusCode": 200
                                },
                                "runAfter": {
                                    "Get_secret_(key1)": [
                                        "SUCCEEDED"
                                    ]
                                }
                            }
                        },
                        "case": "support"
                    }
                },
                "runAfter": {
                    "Initialize_variable_(ApiKey)": [
                        "SUCCEEDED"
                    ]
                }
            },
            "Initialize_variable_(ApiKey)": {
                "type": "InitializeVariable",
                "inputs": {
                    "variables": [
                        {
                            "name": "ApiKey",
                            "type": "string"
                        }
                    ]
                },
                "runAfter": {}
            }
        },
        "contentVersion": "<IP_ADDRESS>",
        "outputs": {},
        "triggers": {
            "When_a_HTTP_request_is_received": {
                "type": "Request",
                "kind": "Http",
                "inputs": {
                    "method": "GET",
                    "schema": {
                        "type": "object",
                        "properties": {
                            "subdomain": {
                                "type": "string",
                                "enum": [
                                    "dev",
                                    "support"
                                ]
                            }
                        },
                        "required": [
                            "subdomain"
                        ]
                    }
                }
            }
        }
    },
    "kind": "Stateful"
}

Screenshots or Videos
No response
Browser
vscode
Additional context
No response

Hey @Andrew-Lahikainen thanks for raising this issue. I have taken a look at your workflow definition and found out a couple of things.

You have 2 actions that have the same name (Response_(404_-_key_not_found)).

The first one is inside the default in the switch statement
The second one is inside the Case_(support) case in the switch statement

The Terminate_(404_-_key_not_found) and Set_variable_(ApiKey2) actions are setup to be run after the Response_(404_-_key_not_found). Therefore the designer gets confused and messes it up the renderization. As it is tryingot to point different actions from different statements to a single actions

In the meantime as a workaround could you please rename one of the Response_(404_-_key_not_found) actions as well as the runAfter from the action that is in the same case that you are remaining the action?

I will take a look, try to repro it an see why this is happening

Thanks for taking a look, yeah that's my problem, there seems to be duplicates being added when I add another action of the same type even if I rename it.
I'll create a new action (let's say Response) and it will immediately inherit the name of the last Response action I used. I will then change the new Response's name (before saving). After I hit save, it will revert back to the initial name (which is the same as the previous Response action) and then it messes up the ui.
It's kinda hard to reproduce reliably, but I do encounter it quite often.

Hi @Andrew-Lahikainen I tried to repro the issue with different types of actions and scenarios, but I wasn't able to do it. I know there was a new deployment with fixes last week, those fixes might have solved this. I will keep trying to repro it and keep this issue open for the next week. Please let me know if this keeps happening.

If I reproduce on my end next week, would it be helpful to set up a Teams
meeting so you can have a look?
I have not run into the issue this week, but I have been extremely careful
to not break it.
The issue stems from creating an action of the same type in the same
“session” (I.e. not closing the designer tab). Have you ever encountered
the problem where the new action uses the name of the last action when you
create it? If you forget to rename one of these actions and then save, it
will break. Usually the designer will validate the action name to prevent
duplicates, but since the user doesn’t touch the name input, it seems the
validation doesn’t run and allows it to be saved.
On Sat, 28 Sep 2024 at 5:17 AM, Carlos Emiliano Castro Trejo <
@.***> wrote:

Hi @Andrew-Lahikainen https://github.com/Andrew-Lahikainen I tried to
repro the issue with different types of actions and scenarios, but I wasn't
able to do it. I know there was a new deployment with fixes last week,
those fixes might have solved this. I will keep trying to repro it and keep
this issue open for the next week. Please let me know if this keeps
happening.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/LogicAppsUX/issues/5702#issuecomment-2379731868,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQU4MIWYAL5ROFCBA7MFADZYWHJ3AVCNFSM6AAAAABOM2B62CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZG4ZTCOBWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Andrew-Lahikainen  Yes that would be great, let me know if you face it again and we can sync on a Teams meeting.

I haven't faced the issue yet. I tried by not renaming it and by renaming the addition actions.
When you face the issue, does the new actions show the duplicated name in the designer UI while you add them or is it until you save it and comeback that it breaks?

Hi @Andrew-Lahikainen I will be closing this issue as it seems that is not happening anymore. Please let me know if its somehow is still repro on your end

repro steps:

Create new stateful workflow
Create a Http request trigger
Create a Initialize Variable action and change the action name to 'Initialize variable (A)', name the variable 'A', change the type to String, and assign it the value of triggerBody().
Hit save
Create a Initialize Variable action. You should notice that it inherits the name of the previous Initialize Variable action.
Name the variable 'B' and use the same type and value as before but do not change the name of the action.
Hit save.

The UI should now be messed up.
Another things I've noticed which you might want to add as separate issues:
a) The array select action automatically stringifies json values if you touch an input.
repro steps:

Add a select action
Switch to text mode
Enter following JSON

{
 "a": {
    "aa": 1,
    "ab": true,
    "ac": "str"
  },
  "b": "str",
  "c": true
}

Hit save
On key value mode, click inside any input
You should notice the value inside text mode got stringified:

{
 "a" : "{"aa":1,"ab":true,"ac":"str"}",
 "b" : "str",
 "c" : "true"
}

b) Pressing save after creating a Initialize variable action causes ui to look like it's loading
repro steps:

Create an initialize variable action, fill out with whatever
Without clicking outside the action details panel, hit save
The ui should now look like it's in a loading state

c) Updating parameters.json  with unsaved changes causes loss of work
repro steps:

Create an Http request trigger
Hit save
Create any action
Do not hit save
Create a new parameter via parameters.json
Save parameters.json
Navigate back to designer
Your unsaved action should be lost

d) Moving actions into a scope (and potentially for each, do until etc.) does not persist
repro steps:

Create am Http request trigger
Create a Scope action
Create a init variable action inside Scope
Create an init variable action after Scope
Create another init variable action after Scope
Hit save
Try moving an action into the scope
Hit save
Try moving another action into the scope
Hit save (this is where it did not persist my change during my test)
Move an action outside of the scope
Hit save (happened again here for me, but just try moving things around and saving each time).

Hi @Andrew-Lahikainen  thanks for the details, I reopend it and I will take a look at it gain.

Hi @Andrew-Lahikainen. It tried to repro it but couldn't do it.
Is there any chance you can provide us your portal extension version when you open the designer? Here is a small guide on how you can do it Finding your session ID or portal extension version

Here is a video on me couldn't repro it.  I will take a look on the other issues as well
https://github.com/user-attachments/assets/5930a47e-6108-48db-89de-10fb357d8deb

https://github.com/user-attachments/assets/6455fc1b-b7bb-4521-a85c-7d6660163e52

ok ok, makes sense. I am able to repro the issue. I will take a look at it. Thanks!

Hi @Andrew-Lahikainen this PR https://github.com/Azure/LogicAppsUX/pull/5888 will solve the initial issue and the b) issue. About the other issues:
A) - I will create a separate issue to track this.
C) - This is expected by design for now. When user switches from the designer view into any file view and the user updates it we try to reload the content of the webview with the latest content of the files, in this case workflow.json, parameters.json, etc. There is an ongoing effort on making this smarter and keep the work done so far. Also, if the customer doesn't update any file, the work in progress will not be lost.
D)-  I will create a separate issue to track this.
Thank you so much for being so proactive with letting us know all your issues, we really appreciate it.

Brilliant, thanks for your hard work mate!

@ccastrotrejo when do you guys push updates to the vscode extension? Quite keen for these fixes

Hi @Andrew-Lahikainen we have been slowly down the releases cadence, but I will try to make a hotfix for this issue. Once its done I will let you know

Hey @Andrew-Lahikainen actually I can provide a private vsix with the fixes of it. Do you mind sharing your email so I can send it to you?

@ccastrotrejo sure that'd be awesome<EMAIL_ADDRESS>

HI @Andrew-Lahikainen I just sent you the email with the private vsix


Refactor onRequestPermissionsResult to be simpler

Refactor onRequestPermissionsResult to be simpler
onRequestPermissionsResult has a switch statement with a single case, and a functionally empty default; this patch refactors it into an if statement to simplify the code. This patch also changes a C-style array declaration (String permissions[]) to the more standard Java style (String[] permissions). There's no change in functionality, just in code style.
Tests performed
Tested prodDebug on Pixel 2 emulator with API level 25.
Screenshots showing what changed
No change in functionality, so no screenshots.

Codecov Report

Merging #2965 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2965      +/-   ##
=========================================
+ Coverage    3.69%   3.69%   +<.01%
=========================================
  Files         247     247
  Lines       12214   12213       -1
  Branches     1081    1081
=========================================
  Hits          451     451
+ Misses      11729   11728       -1
  Partials       34      34

Impacted Files
Coverage Δ

...r/free/nrw/commons/contributions/MainActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877c669...80b3b21. Read the comment docs.


partial fix for RackHD/RackHD#363

formal docs update to resolve RackHD/RackHD#363

(apologies for the whitespace cleanup in the diff)
FYI @codenrhoden
@RackHD/corecommitters please review

:+1:

:+1:

👍


Hanging on [INFO]  systemd: Starting k3s-agent

Progressing with installing the cluster and i'm not sure if the installer is stuck or just chilling like it should.
My output has been like this for quiet some time
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  systemd: Starting k3s-agent
[INFO]  systemd: Starting k3s-agent
[INFO]  systemd: Starting k3s-agent
[INFO]  systemd: Starting k3s-agent

Alright, left it a bit and then restarted the process and now it seems that it deployed everything, but there's an issue with the secret
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  No change detected so skipping service start
...k3s has been deployed to master golemgrid-cpx21-master2.
[INFO]  No change detected so skipping service start
...k3s has been deployed to master golemgrid-cpx21-master3.
Deploying k3s to worker golemgrid-cpx21-pool-small-worker1...
Deploying k3s to worker golemgrid-cpx21-pool-small-worker2...
Deploying k3s to worker golemgrid-cpx21-pool-small-worker3...
Deploying k3s to worker golemgrid-cpx21-pool-small-worker4...
[INFO]  Using v1.21.3+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.21.3+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.21.3+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.21.3+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.21.3+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.21.3+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.21.3+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.21.3+k3s1/sha256sum-amd64.txt
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  No change detected so skipping service start
...k3s has been deployed to worker golemgrid-cpx21-pool-small-worker2.
[INFO]  No change detected so skipping service start
...k3s has been deployed to worker golemgrid-cpx21-pool-small-worker3.
[INFO]  No change detected so skipping service start
...k3s has been deployed to worker golemgrid-cpx21-pool-small-worker1.
[INFO]  No change detected so skipping service start
...k3s has been deployed to worker golemgrid-cpx21-pool-small-worker4.

=== Deploying Hetzner drivers ===

Creating secret for Hetzner Cloud token...
Error from server (ServiceUnavailable): the server is currently unable to handle the request
Failed to create Hetzner Cloud secret:
Error from server (ServiceUnavailable): the server is currently unable to handle the request

Upgraded to v1.24.9+k3s1 and now it deploys smoothly. :-)

It's likely that v1.21 is not compatible with the latest versions of the Hetzner drivers. I will update the config examples with a newer version for people who take that version. Glad you got it working :)


LEGO: Pull request from lego/hb_839_20181017214038998 to master

LEGO: Pull request from lego/hb_839_20181017214038998 to master with localized lcls

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: csigs sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


MultiPartParser::parse returns -1 on forms

Describe the bug
Using MultiPartParser::parse on a request form returns -1, and is unable to parse. This is the case with and without <form> tags.
To Reproduce
The drogon side of the code is as follows:
void LoginCtrl::asyncHandleHttpRequest(const HttpRequestPtr& req, std::function<void (const HttpResponsePtr&)>&& callback)
{
	MultiPartParser parser;
	std::cout << parser.parse(req) << '\n';
	const auto& params = parser.getParameters();

	const auto unameFind = params.find("u");
	if(unameFind == params.end())
	{
		auto resp = HttpResponse::newHttpResponse();
		resp->setStatusCode(k401Unauthorized);
		callback(resp);
		return;
	}

	const auto passFind = params.find("p");
	if(passFind == params.end())
	{
		auto resp = HttpResponse::newHttpResponse();
		resp->setStatusCode(k401Unauthorized);
		callback(resp);
		return;
	}

	const string_view
		uname = unameFind->second,
		pass = passFind->second;

	std::cout << uname << '\n' << pass << '\n';
	callback(HttpResponse::newHttpResponse());
}

The form is submitted via JavaScript:
const
	uname = "admin",
	pass = "admin",
	form = new FormData();
form.append("u", uname);
form.append("p", pass);
fetch("/api/login", {
	method: "POST",
	body: form,
	headers: {
		"Content-Type": "multipart/form-data",
	},
});

Expected behavior
It must parse the request form.
Desktop:

OS: Ubuntu
Browser Chrome

Additional context
If the req->body() is printed, the form content can be seen. This is an issue with the MultiPartParser.

I had used a different approach right after making this issue, and thought this may help people who may stumble upon this.
For the time being until this is solved, users have to use normal HTTP requests and make a protocol for it, for my case I made a byte array with the following format:
[1 byte: uname length] [<uname length> bytes: uname] [1 byte: pass length] [<pass length> bytes: pass]

If you need more length, make length bytes more than 1.
On the server side, it is as easy as casting the lengths to appropriate size type pointers and dereferencing them:
const std::string_view body = req->body();

const uint8_t unameLen = body[0];
const std::string_view uname = body.substr(1, unameLen);
// etc.

Of course you must do boundary and length checks yourself when retrieving each piece of information from the body, requests from outside must never be trusted and should be validated so you don't encounter out of bounds errors or buffer overflows.

The MultiPartParser works if the header in the frontend is not set manually like in the example.
Do we need to fix anything? Or have MultiPartParser parse requests with Content-Type: multipart/form-data as well?
If the the content type header is not set, the frontend sends:
multipart/form-data; boundary=----WebKitFormBoundarybRHe2TiCOeJdlhGA

I don't understand what's the problem. according to the protocol, the Content-type header of multipart/form-data should be set with the boundary string.

If we set the header in the frontend:
const form = new FormData();
form.append("key", "value");
fetch("/api/form", {
	method: "POST",
	body: form,
	headers: {
		"Content-Type": "multipart/form-data", // note this
	},
});

Then the http request's content type header looks like:
Content-Type: multipart/form-data

And the returned value of MultiPartParser::parse(req) will be -1.

However, if we don't set the content type header:
const form = new FormData();
form.append("key", "value");
fetch("/api/form", {
	method: "POST",
	body: form,
	/*headers: {
		"Content-Type": "multipart/form-data"
	},*/
});

Then the http request's content type header looks like:
Content-Type: multipart/form-data; boundary=----WebKitFormBoundarybRHe2TiCOeJdlhGA

And the returned value of MultiPartParser::parse(req) will be 0 and parses as expected.

I am not familiar with the HTTP form spec, is not having a boundary illegal? If so, I will close this issue

Please print the body in the first case to see if there are boundaries in the body.

I don't think this is a bug, if the frontend client sets its Content-Type header to something without a boundary, it may be violating the specification.


Can Powerinfer run on CPUONLY?

How does Powerinfer compare to llama.cpp when run on CPU only?

PowerInfer can work well on x86 CPU only mode. For other like arm, PowerInfer has limited speedup for now. :)


hsa-ext-rocr-dev is broken since ROCm 2.9

When hsa-ext-rocr-dev is upgraded from ROCm repo 2.10 or 3.0 for image support clinfo segfaults and so does Darktable. Last version that worked was hsa-ext-rocr-dev-1.1.9-122-ge5c4efb1-Linux.rpm from ROCm 2.9. Downgrading to package hsa-ext-rocr-dev-1.1.9-122-ge5c4efb1-Linux.rpm solves the issue.
ROCm 2.2 to 2.9 works
2.10 and 3.0 does not.
AMD Raven Ridge APU 2700u Fedora 31 x64

Yes, looks like it. Since the update to ROCm v3, my environment is broken. Output for rocminfo is as below
ROCk module is loaded
<username> is member of video group
hsa api call failure at: /data/jenkins-workspace/compute-rocm-rel-3.0/rocminfo/rocminfo.cc:1102
Call returned HSA_STATUS_ERROR_OUT_OF_RESOURCES: The runtime failed to allocate the necessary resources. This error may also occur when the core runtime library needs to spawn threads or create internal OS-specific events.

Still broken in ROCm 3.1

Still broken in ROCm 3.3

Hi @btspce, please check latest ROCm Documentation and ROCm 5.7.1 to see if your issue has been resolved.  If resolved, please close the ticket.  Thanks.

I don't have this laptop anymore so I can't verify if it is fixed. Closing for now.


Unwrap filter factories with empty constructors in FilterCollection

Fixes #7855

What's the purpose?

OH huh, I missed the link to the bug. Which talks about throwing?

There isn't a very good heuristic to determine when to throw - for instance a AuthorizeFilter that's both a filter and a filter factory would work "ok" when registered. This was a more of a targeted fix that addresses some filter factories,  AutoValidateAntiforgeryTokenAttribute being one of them.

So in general what's the expected behavior?

More like, if I register a factory and we can initialize it, we'll treat it like a factory.
I couldn't come up with a better alternative for this (specifically around the case of a type being a filter factory and a filter).

I don't think this is the right fix - this means that if you have a filter factory and you suddenly start using DI - everything will work differently
Could we address this inside of TypeFilterAttribute instead? I would suggest logic like:

Is factory? create the factory and then call it - return the result
Is not factory? return the result.

🆙 📅


Copying Lectures from one Course to another

Is your feature request related to a problem?
As of the last winter semester, the iPraktikum is using the Artemis platform in order to conduct the intro course which teaches about 60-80 students the fundamentals of Swift and iOS development.
This intro course is also held this semester, again via the Artemis platform, therefore requiring a new course. As the content of the course stayed mostly the same, we copied over the Exercises (which automatically also creates the required repositories etc.). However, the same isn't possible for the Lecture material. The tutors had to manually copy over all Lectures together with each individual lecture unit to this semester's Artemis intro course, consuming multiple work hours.
Describe the solution you'd like
A simple copy-and-paste functionality from one course to another, similar to the copying of the Exercises (which is already possible), should resolve the need for manual copy-and-pasting, which can take hours for larger courses.
The solution I'm envisioning is basically the same as the Exercise-copying (see image below), enabling the course instructor to click "Import Lecture" and then select the respective lectures out of all to him/her accessible lectures.
This feature will drastically reduce the time to set up new Artemis courses which are very similar to old ones.

Describe alternatives you've considered
No real alternative, except for manual copy-and-pasting ;)
Additional context
No response

Hello @philippzagar, thank you for documenting this issue. I agree that manual copy-pasting is not a satisfying solution here.
As you might know, each lecture has multiple lecture units which in turn are connected to learning goals. By only copying the lectures these valuable mappings would be lost.
The question is if there exists a use case where one would only copy selected lecture content and not wish to clone the whole course (e.g., all lectures with units  and learning goals). I'd argue that mostly the second use case is more applicable.  Do you agree?

I've decided with @krusche that for a first version, we will add the feature to import one or multiple lectures (thereby duplicating all lecture units and attachments to the new course) just like with exercises.
Later, we might revisit this in regard to also copying the learning goals while simultaneously keeping the mappings between the objects.

Perfect, thanks for quickly resolving the issue :)

Hey @philippzagar! Good news: Development is complete, and you can expect this feature to be included in the next Artemis version.


Fix torpedo pod logs getting printed on console

What this PR does / why we need it:
We have been observing this from a very long time in long torpedo runs. The logs we get on the jenkins console is a result of kubectl logs -f torpedo
But for some reason this log stream exits after every 4 hours and the whole log is printed again.
The cumulative logs get printed on the console page and this is resulting in slowness while loading the jenkins console page and also crashing at times.
To fix this we will be getting only recent logs if kubectl logs -f torpedo exits during the first iteration by using kubectl logs -f --since=1m -f torpedo
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:

@lsrinivas-pure Successful jenkins run for full pipeline - https://jenkins.pwx.dev.purestorage.com/job/portworx-backup/job/system-tests/job/basic-system-test/job/px/job/s3/job/px-backup-system-test-vanilla/520/

@mkoppal-px Should we do the same change in https://github.com/portworx/torpedo/blob/master/deployments/deploy-pxb-cloud.sh as well?

@mkoppal-px Should we do the same change in https://github.com/portworx/torpedo/blob/master/deployments/deploy-pxb-cloud.sh as well?

@kshithijiyer-px Did the same for other sh files


[dx/307] Update action versions

This PR updates various actions to the latest versions.
This is required for Piclo/flex#11037.

 Update third party actions to the latest versions

What risks are there that no CI running either here or flex?

I ran the tests locally and they pass. We pin GADK to a Git SHA in flex and updating it will trigger CI.


[Enhancement] Custom lua conditions

I'd like to be able to write a custom lua function as a condition. This can help with things like correcting cast times with respect to haste, estimating projectile travel time based on unit distance, etc.
If security is a concern, I recommend warning users when importing a rotation with custom lua code, or simply preventing the import entirely.

I added this to 1.4.2 beta 1


Set a custom color background, rather than just 'light' or 'dark' theme.

Is it currently possible to set a custom background color for the color picker. I want to replace the 'dark'/'light' theme with a custom color?

After importing the component's style file, the following css code will fulfil your request.
import<EMAIL_ADDRESS>
:root{
--cp-container-bg: customColor
}


Fix missing yardocs

Fixes #24 to provide 100% yardoc coverage
Files:          20
Modules:         9 (    0 undocumented)
Classes:        36 (    0 undocumented)
Constants:       9 (    0 undocumented)
Attributes:      9 (    0 undocumented)
Methods:       107 (    0 undocumented)
 100.00% documented

There's some warnings related to the dry-types metaprogramming, but I don't think it's possible to get rid of those:
[warn]: in YARD::Handlers::Ruby::MixinHandler: Undocumentable mixin: YARD::Parser::UndocumentableError for class K8s::API::Types
	in file 'lib/k8s/api.rb':9:

	9: include Dry::Types.module

[warn]: in YARD::Handlers::Ruby::MixinHandler: Undocumentable mixin: YARD::Parser::UndocumentableError for class K8s::Config::Types
	in file 'lib/k8s/config.rb':26:

	26: include Dry::Types.module

I tired adding @!parse ... directives, but those just extend the yardocs, but don't actually supress the warnings on the non-const includes.

Note that the yardoc 100.00% documented doens't seem to cover @param, so there might still be some important params that need documenting...


feat: option --no-push

this is useful for minikube, where you can directly build using the minikube docker instead of setting up and pushing to a dummy registry.
See here for the minikube instructions about how to directly build inside minikube.
I tested them locally and could speed up my build process significantly:

With push, after stopping and restarting minikube, the images (several GB) need to be send to the minikube cluster again. This is a common case, kind of every day, as I like to stop the minikube if I don't need it.
Without push (i.e. with the new --no-push enabled), no pushing is needed and the cache of the minikube docker can be successfully used. julia_pod is super fast even after restarting minikube.
Mind that when deleting minikube cluster and recreating it, the cache of the minikube docker is lost and the rebuilding takes very long. But this is very rare, only needed if you are still experimenting about which minikube config like cpus and memory are good for your local dev environment.

Thank you for thumbs up.
I added documentation to the README.md
(mind that my autosave config removed all trailing whitespace, the actual changes are rather a few.
It helps to set the github's option to ignore whitespace changes - click on the gear symbol at the top)
I hope it is ready for merge now :slightly_smiling_face:


shellIntegration not working

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.0
OS Version: Archlinux (Linux x64 5.18.10-arch1-1)

I wanted to try out the shellintegration, so i enabled it with "terminal.integrated.shellIntegration.enabled": true but it does not worked. I use bash with a dead simple prompt PS1='[\u@\h \W]\$ ', other than this i just have a few alias in .bashrc.
I tried it on an ubuntu VM with bash and it worked on it without any problem (exact same bash version).
Steps to Reproduce:

Turn on shellintegration
Close all integrated terminals, and then open a new one.

Tell me what log should i include.

I was able to get it to work by installing the starship prompt.
I don`t understand why it doesn`t work with the above mentioned simple prompt.
No error message in the terminal, nor in the debug level logs (as far as i can see), but it still doesn`t work for me without starship.

I figured it out.
In archlinux the PROMPT_COMMAND was set in /etc/bash.bashrc (by default), but it wasn`t obvious because env not printed it out, so i thought it wasn`t set.
Moving it into a function like it`s stated in the vscode docs had weird side effects for me, so i just "emptied" it in my .bashrc.
BTW this error message from vscode docs Shell integration cannot be activated due to complex PROMPT_COMMAND: ... wasn`t printed for me. Otherwise i would figured it out much earlier.

This is actually tracked in https://github.com/microsoft/vscode/issues/146197, thanks for reporting


Update Sablier to v1.1.2

Name/Description
Sablier. We listed new tokens:

ANT
CENT
D2D
FLX
HOTCROSS
jCAD
jCHF
jEUR
jGBP
jSGD
PERC
PLA
RAI
ROOK

And made a few fixes, the most important one being that we fixed a bug that incorrectly generating the Polygon Infura URL.
Type

Update

Compatible Networks

Mainnet
Polygon
BSC
Rinkeby

Code for review
https://github.com/paulrberg/sablier-safe-app/releases/tag/v1.1.2
IPFS hash/App URL
https://cloudflare-ipfs.com/ipfs/QmX6HayKpDCGhQEk5egfa5zLJ29aznB75YNq5cE84mzkS1/
Desired date
As soon as possible.

hey, thanks for the update :) it's live now


Earthdawn 4e: Version 2.3

Questors tab added

Greeting @dougansf ,
I'm going to approve this merge request but I wanted to let you know that in the near future we have new standards coming that will effect this sheet. All sheets are going to need to be accessible without the use of the API. I see this sheet is using Power Cards to do all the rolls & ChatSetAttr . While these can be useful companion features, it should not be the default as it will make the sheet unusable for basic & plus accounts.
Thanks,
Cassie

Thank you for informing me of the impending change.  Is it known when that
will happen?
Due to the complexity of the rolls involved with this sheet, I'm not sure
that will be possible, but will make the attempt.
On Mon, Aug 27, 2018 at 11:31 AM Cassie Levett<EMAIL_ADDRESS>wrote:

Greeting @dougansf https://github.com/dougansf ,
I'm going to approve this merge request but I wanted to let you know that
in the near future we have new standards coming that will effect this
sheet. All sheets are going to need to be accessible without the use of the
API. I see this sheet is using Power Cards to do all the rolls &
ChatSetAttr . While these can be useful companion features, it should not
be the default as it will make the sheet unusable for basic & plus accounts.
Thanks,
Cassie
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/4093#issuecomment-416266391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYCoo0l11A4T3J8_h9Zh4ZoGclZW8-8Zks5uVBC2gaJpZM4WIz-z
.

The stated changes will hopefully be posted in the near future but I don't expect to start 'enforcing' them on for the older sheets for another month or two at the earliest. I just want to let sheet authors know they are coming. :)
A good way to keep your fancier rolling is to make a checkbox toggle that switches out the API roll for a more basic roll macro. I know Earthdawn's step system makes for a bit of an interesting challenge. The simpler rolling does not need to cover all the possibility but just provide minimal functionality. Let me know if you run into blockers and I'll be happy to try to help. I've a passion for the 4th World.
Thanks,
Cassie

You are my new favorite R20 rep.  :)
I'm teaching myself HTML by creating this sheet.  I've gotten help on the
R20 forums from some great people to get me this far.  I now have an
assistant from the Earthdawn West Marches campaign, who is easily my
largest user of the sheet.
We started figuring out a basic roll template.  I already had a basic roll
to give to folks that were not Pro Subs.
The idea of a toggle to activate the APIs would be great, though I have no
idea how to implement that.  Recommendations would be greatly appreciated.
Thanks,
Brett

The new Wrath & Glory Sheet did this an interesting way.
First at the top of the HTML they used a checkbox to determine if you want to use standard rolls or API:
<input type="checkbox" name="attr_roll-toggle" class="sheet-roll-useDice" value="1" title="check to use the standard Roll20 Dice Rolling mechanism vs the Wrath & Glory Dice Rolling API." checked="false"/> Use inline dice (vs API)?

Then in the sheet they made two separate buttons like this:
<button class="sheet-diebutton-api" type="roll" title="Click to make a Ballistics skill test."  value="!wag {{[[[[@{BallTotal} + @{BallBonusRoll} - 1]]d6]]}} {{[[1d6]]}} --Name|@{character_name} --Skill|Ballistics --Modifier|@{BallRollMod}"  name="roll_ballistics" style="font-size: 175%;"></button>
<button class="sheet-diebutton-simple" type="roll" title="Click to make a Ballistics skill test." value="&{template:roll_dicepool} {{name=@{character_name} makes a Ballistics Skill test}} {{dice=[[@{BallTotal} + @{BallBonusRoll}]]}} {{roll=[[[[@{BallTotal} + @{BallBonusRoll} - {1}]]d6>4]]}} {{wrath=[[1d6]]}}" name="roll_dice4ballistics" style="font-size: 175%;"></button>
Lastly in the CSS they included this:
input.sheet-roll-useDice:unchecked 	~ div table button.sheet-diebutton-api { display: inline; } input.sheet-roll-useDice:unchecked 	~ div table button.sheet-diebutton-simple { display: none; } input.sheet-roll-useDice:checked    ~ div table button.sheet-diebutton-simple { display: inline; } input.sheet-roll-useDice:checked    ~ div table button.sheet-diebutton-api { display: none; }
What is happening is the "API roll button" is displaying on the character sheet unless that checkbox at the top is checked. When the roll-useDice checkbox is checked then the "API roll button" is hidden and the "simple button" is displayed. It would likely be a better practice to have the simple one displayed by default but this was a patch the author was nice enough to add when the sheet was first submitted. :)

Awesome.  I'll see if I can incorporate that.
For the standard Roll20 roller, I've figured out a macro to ask for a Step
value, roll the right exploding dice, add Karma dice and then compare that
against a target tokens' Defense to give the number of Successes (1 success
for meeting the Target Number, +1 for every 5 over the TN).
Is there a way to display the Roll Result AND the number of Successes at
the same time?  I can only seem to do one or the other.
This is the big reason I went with Power Cards.

You may want to outline the rules, goal, and dice used on the Character sheet forum then ask for help. There are likely better people over there than I who can provide a suggestion. I have to relearn how dice & macros work with new every sheet. :)
Hopefully some one on the forums can come up with an elegant solution. If there isn't one with the current dice roller then keep in mind the simple roll just needs to be functional. This may mean you just show the dice result in a nice roll template and let users apply the rules as need. Just like if they were playing in the physical world with real dice.


docs(README): import ApplicationBuilderFromModule

Coverage remained the same at 80.862% when pulling a9afc5eda12eb89b081004012e970508026432f2 on leo6104:patch-1 into 20069feea8ff371b652495155ce25b62dff7095a on clbond:master.

Thank you!


CAT can return reserved txs

Occasionally, CAT will return txs that are reserved but not yet stored. This can result in weird behavior, such as passing the application a zero length transaction during PrepareProposal.
To fix this, we just need to filter out all reserved txs in the few occassions where they actually get read before actually being added or released.

What is a reserved tx?

CAT will return txs that are reserved but not yet stored.

Stored where?

Answering my questions from above:

A reserved tx is a tx that has been received by the CAT Pool but hasn't been processed yet. Reserved txs aren't ready for inclusion in a block because they haven't gone through CheckTx yet.
I think "not yet stored" meant not yet stored in the mempool but that's kinda confusing because the tx is in the mempool, it's just processing and not ready for inclusion in a block.

See https://github.com/celestiaorg/celestia-core/pull/1267#pullrequestreview-1944044341

closing as completed


Bump hasura to 2.0.9

Also, stop restricting the size of the pg connection pool, since that
would be unfair on higher benchmark concurrency levels and reduce the
logging volume.

Closed in favor of the more all-encompassing update in #27