Unit incompatibility error when reporting some scenarios

Simple message_ix reporting gives the following error for some sets of models (e.g. ENGAGE, NGFS) but not for some other models (e.g. MESSAGEix-Materials). This error is coming from either fom or vom key, but those incompatible units are not found from corresponding parameters.
Code sample or context

import ixmp as ix
import message_ix
from message_ix.reporting import Reporter

mp = ix.Platform('ixmp_dev')
Sc_ref = message_ix.Scenario(mp, 'ENGAGE_SSP2_v4.1.7', 'EN_NPi2020_1400')
rep = Reporter.from_scenario(Sc_ref)
df = rep.get("message:default")

Expected result
An df output of type pyam.core.IamDataFrame
Problem description
Error (Units incompatible)
inv_cost: mixed units ['USD/GWa', 'USD/kWa'] discarded
emission_factor: mixed units ['tC', '???', 'kg/kWa', '-'] discarded
input: mixed units ['GWa', '-', '???'] discarded
output: mixed units ['GWa', '-'] discarded
Traceback (most recent call last):

  File "<ipython-input-8-1bb63ffa22ff>", line 1, in <module>
    df = rep.get("message:default")

  File "C:\ProgramData\Anaconda3\lib\site-packages\genno\core\computer.py", line 407, in get
    raise ComputationError(exc) from None

ComputationError: computing <tom:nl-t-yv-ya> using:

(<function add at 0x0000021CC2FB5168>, 'fom:nl-t-yv-ya', 'vom:nl-t-yv-ya')

Use Computer.describe(...) to trace the computation.

Computation traceback:
  File "C:\ProgramData\Anaconda3\lib\site-packages\genno\computations.py", line 74, in add
    raise ValueError(f"Units '{ref_unit:~}' and '{u:~}' are incompatible")
ValueError: Units '' and 'USD / GWa' are incompatible

Versions
Output of message-ix show-versions

ixmp:        3.3.0a0
     0188de0 (HEAD -> origin/main) Re-enable py3.9 runs of "pytest" CI workflow
message_ix:  3.2.1.dev55+g2107fbc.d20210506
     a73cc36 (HEAD -> master, VK/master) Merge pull request #456 from iiasa/issue_437
message_data: 0.1.dev0
     6c656e01 (HEAD -> DLE-MESSAGE, Jihoon/DLE-MESSAGE) Add an emission constraint

click:       7.1.2
dask:        2021.04.0
graphviz:    0.12
jpype:       1.2.1
… JVM path:  C:\Program Files\Java\jdk1.8.0_202\jre\bin\server\jvm.dll
openpyxl:    3.0.7
pandas:      1.2.4
pint:        0.14
xarray:      0.17.0
yaml:        5.4.1

iam_units:   installed
jupyter:     installed
matplotlib:  3.3.4
plotnine:    0.7.1
pyam:        0.10.0

GAMS:        26.1.0

python:      3.7.10 (default, Feb 26 2021, 13:06:18) [MSC v.1916 64 bit (AMD64)]
python-bits: 64
OS:          Windows
OS-release:  10
machine:     AMD64
processor:   Intel64 Family 6 Model 94 Stepping 3, GenuineIntel
byteorder:   little
LC_ALL:      None
LANG:        None
LOCALE:      None.None

Thanks for the report!
Can you do the following for at least (a) a scenario where this error occurs and (b) one where it does not?
for name in ("inv_cost", "fix_cost", "var_cost"):
    print(name, sorted(scen.par(name)["unit"].unique()))

This will help us detect differences in the contents of the scenarios that could be a cause of this error.

Incidentally: there could be two or more issues and corresponding fixes here:

The scenarios have inconsistent structure and contents—that needs to be fixed in message-ix-models and message_data, either by:

Generating better scenarios ex-ante / before they are solved.
Improving the default reporting configuration (global.yaml) for the full model in order to apply proper units ex-post.

message_ix, ixmp, and/or genno are not tolerant of these inconsistent contents. This might be fixed in this package.

(a) For a scenario that has the error:
inv_cost ['USD/GWa', 'USD/kWa']
fix_cost ['USD/GWa', 'USD/kWa']
var_cost ['USD/GWa']

(b) For a scenario with no error:
inv_cost ['USD/GWa', 'USD/kWa', 't']
fix_cost ['USD/GWa', 'USD/kWa', 't']
var_cost ['USD/GWa', 't']

Thanks. I'm puzzled why there is no "mixed units discarded" log message for fix_cost (for fom) and var_cost (for vom).
Next, for each scenario:
print(rep.get("fom:nl-t-yv-ya"))
print(rep.get("vom:nl-t-yv-ya"))

Here we're trying to climb back up the chain of calculations to see where the incompatible values originate.

Thanks. I'm puzzled why there is no "mixed units discarded" log message for fix_cost (for fom) and var_cost (for vom).
Next, for each scenario:
print(rep.get("fom:nl-t-yv-ya"))
print(rep.get("vom:nl-t-yv-ya"))

Here we're trying to climb back up the chain of calculations to see where the incompatible values originate.

Sorry, it was my bad that I didn't copy the whole error log correctly.

From the conversation with @GamzeUnlu95, we've figured out, for case (b) above, all the units are discarded for the three parameters so that they become compatible with each other. But for case (a), var_cost will still keep 'USD/GWa' causing the incompatibility.
So we were luckily able to use the reporting for our model so far, thanks to the arbitrary addition of 't'.
The most fundamental way to fix it will be to harmonize the units for the cost params to one (MUSD/GWa or USD/kWa), as @GamzeUnlu95 suggests the unit 'USD/GWa' is not correct in the first place. But there will be many other workarounds depending on priorities..

(b) above, all the units are discarded for the three parameters so that they become compatible with each other. But for case (a), var_cost will still keep 'USD/GWa' causing the incompatibility.

Indeed, I think this is the correct diagnosis.
Another workaround could be to use units/apply/var_cost: "" in the configuration / YAML file to force var_cost to be dimensionless, to the same effect.

The most fundamental way to fix it will be to harmonize the units for the cost params to one (MUSD/GWa or USD/kWa), as @GamzeUnlu95 suggests the unit 'USD/GWa' is not correct in the first place.

Agreed. So indeed fixing the scenario contents is probably in message_data or message-ix-models. We can either transfer this issue, or close it and open a new one there.
However, there is a more fundamental issue that's actually in message_ix or ixmp. I realized it when we first developed the reporting code, but no one has yet run into it:

ixmp parameters, such as var_cost, have units. These are stored, and can be retrieved and used by reporting.
For variables, such as ACT, in reality they do have units, but ixmp was not originally built to handle these.
So we mostly treat these implicitly.
For instance, if you run a coal_ppl and it outputs 100 (the activity, ACT), and its variable cost is 2 USD / kW·a (var_cost). The units of ACT are implicitly kW·a. So the total variable cost is ACT × var_cost [=] kW·a × (USD / kW·a) [=] USD.
It's very reasonable for each (technology, commodity) pair in to have different units for activity. For instance, for a technology that outputs commodity water, it might be natural to denote water in m³, and thus also the ACT. Then the var_cost for this technology should be in units of USD / m³, and USD / kW·a would be a weird choice.
To truly fix this would need deeper changes in the ixmp internals to store and retrieve the units of ACT.
Failing that, we could have a "permanent workaround" in the reporting code, by these steps:

Split ACT and var_cost, etc. into multiple different quantities—each with consistent units.
Auto-configure fom, vom, tom etc. separately for each of these.

Writing this down here simply so we are aware of it when doing further development.

Another workaround could be to use units/apply/var_cost: "" in the configuration / YAML file to force var_cost to be dimensionless, to the same effect.

A quick question about this workaround. Since @GamzeUnlu95's script is not relying on a yaml file, I've tried this below instead, which didn't resolve the incompatibility as I hoped. Do we need something more?
from ixmp.reporting import configure
configure(units={"apply": {"var_cost": ""}})

I am also curious when units/apply/var_cost is applied correctly, whether it applies to the entire platform or specifically to this model somehow?

A Reporter object is always needed to run reporting. Some configuration settings are global, others can be set differently on each Reporter instance. See “Global and specific configuration” in the genno docs.
Here's the documentation for how units/apply is handled in ixmp: https://docs.messageix.org/projects/ixmp/en/stable/reporting.html#ixmp.reporting.units (please read).
Finally, note that extra keyword arguments to from_scenario() are forwarded to configure(). So with those points, you should instead do:
from message_ix import Reporter
r = Reporter.from_scenario(scen, units={"apply": {"var_cost": ""}})
r.get(…)

This ensures (per the first link above) that the units setting is retained and applied when data is pulled out of scen.
To directly answer your final question, the configuration is not tied to either (a) a particular ixmp.Platform object nor (b) a particular message_ix.Scenario object. This means that, after the above, you can do this:
# Change the "scenario" key in the already-configured Reporter to point to a different scenario object
# All other described computations remain the same
r.add("scenario", scen2)

# Configuration set above will still apply, but data will be extracted from `scen2`, not `scen`
r.get(…)


Make fused ctuples work

Fixes #6068.
Ideally should go in 3.0.x.

Probably also fixes https://github.com/cython/cython/issues/3904

3.0.x commit b217edfd4


Error module 'tensorflow' has no attribute 'app'

After i install the requirement.txt file, I face such an error. I think this TensorFlow compatibility.
you can change "import tensorflow as tf" to "import tensorflow.compat.v1 as tf"
it worked for me.
see this

Hi @Milad-Hosseini! Thanks for your suggestion. Since the TensorFlow version has not been maintained for a while, errors like this could happen. We will fix this nevertheless.


How do i assign value to placeholder of input?

Do you want to request a feature or report a bug?
Feature | Bug
What is the current behavior?
I want to assign value to placeholder value of input textbox, I need help.
Which versions of react and react-localize-redux are you using?
I am using "react-localize-redux": "^3.5.1" version.
Thank you :)

Hi,
I've got the solution,

{({translate}) => (
{translate("password")}
<input placeholder={translate("password").toString()}/>

)}


Fixed [default value] For Mysql

The [default value] can'nt use [modify column] in mysql.

Would you mind squashing the commits into one and targeting 1.9.x ?
Thanks

I am a novice, I will try my best to learn


Allow valid Rust syntax

Allow this syntax:
#[distributed_slice]
static RES: [Res; 0] = [];

as equivalent to
#[distributed_slice]
static RES: [Res];

so CLion won't complain about syntax it does not understand.

Actually, nevermind,
this syntax is fine:
#[distributed_slice]
static RES: [Res] = [..];


[Feature] Add dig method to CSV::Table and CSV::Row

Abstract

This PR implements dig method to CSV::Table and CSV::Row

Background

Already, Array, Hash and Struct class has dig method from Ruby 2.3, but CSV::Table and CSV::Row not has this method.
I would like to use #dig for CSV::Table or nested arrays (or hashes) with CSV::Row without distinction.

Usage
arr_of_arrs = CSV.parse("first,second,third\n1,2,3\n", headers: true)

# as single value
arr_or_arrs.dig(0) # row mode
=> #<CSV::Row "first":"1" "second":"2" "third":"3">
arr_of_arrs.dig("first") # col mode
=> ["1"]

# as nested values
arr_of_arrs.dig(0, "first")
=> "1"
arr_of_arrs.dig("first", 0)
=> "1"

I fixed about the part reviewed.
and I changed behavior when following value does not have #dig method.
(would raise same error as Array and Hash #dig.)

Thanks.
I've merged with some modifications.


BUG: remove hardcode domain name in image URL

Changes:

Remove hardcoded domain-name of image URLs in HTML when converted from ReST
Serve media files under development server

Description:
Previously, image URLs in HTML are in format: http://scipy-central.org/{{MEDIA_URL}}/{{IMAGE_URL}}/. Now, image URLs in HTML are in format: /{{MEDIA_URL}}/{{IMAGE_URL}}/ (domain name is not needed for modern browsers)
NOTE: {{MEDIA_URL}} if changed in settings.py needs maintenance work to recompile stored links in submissions' description!

@pv Can you please look into rest_comments test cases are failing in Travis CI while all are passing on my local machine (Windows)

Issues effected with this PR
https://github.com/scipy/SciPyCentral/issues/177
https://github.com/scipy/SciPyCentral/issues/123


ComfyUI Path_to_MODEL not working - Paperspace

Hi, First of all, excellent job!
I am using paperspace A1111 without problems, now I want to start using ComfyUI, but it does not recognize/detect the models that I use correctly in A1111.
In the ComfyUI Notebook I left these parameters and only modified this section
Original_Model_Version = ""

# Choices are "SDXL", "v1.5", "v2-512", "v2-768"

#-------------- Or

Path_to_MODEL = "/notebooks/sd/stable-diffusion-webui/models/Stable-diffusion/"

# Insert the full path of your trained model or to a folder containing multiple models.

MODEL_LINK = ""

# A direct link to a Model or a shared gdrive link.

#--------------------
model=mdls(Original_Model_Version, Path_to_MODEL, MODEL_LINK)

I am using the latest version of Notebooks (latest_notebooks), in the ComfyUI frontend it only shows me the 4 basic ones that come by default
What could be happening? thank you!

I'll check it out, try using civitai links for now

Perfect, thanks! The problem is that I have several models and the option of using the link is not functional for me.


Old Config in v0.3.0 works good, but the new config in readme with latest update has some issues.

Is there an existing issue outlining your problem?

[X] I have searched the existing issues and they do not solve my problem.

Describe your problem.
In the latest one, you can see the statusline below. Unappropriate colors in the left side. And the rightest one, has english letters?

While in v0.3.0, the old readme config, it looked like this:
Appropriate colors in the left, and numbers in the rightest one.

Paste your configuration.
OLD ONE:
unbind r
bind r source-file ~/.tmux.conf
set -g mouse on

set -g prefix C-b
bind C-b send-prefix
bind C-l send-keys 'C-l'

set-option -g status-position top
set-option -sg escape-time 10
set-option -g focus-events on
set-option -a terminal-features 'xterm-256color:RGB'
set -g default-terminal "screen-256color"

# Yazi
set -g allow-passthrough on

set -ga update-environment TERM
set -ga update-environment TERM_PROGRAM

# act like vim
setw -g mode-keys vi
bind-key h select-pane -L
bind-key j select-pane -D
bind-key k select-pane -U
bind-key l select-pane -R

# List of plugins
set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'christoomey/vim-tmux-navigator'
set -g @plugin 'tmux-plugins/tmux-resurrect'
set -g @plugin 'tmux-plugins/tmux-continuum'
set -g @plugin 'tmux-plugins/tmux-yank'
set -g @plugin 'b0o/tmux-autoreload'
set -g @plugin 'sainnhe/tmux-fzf'
set -g @plugin 'catppuccin/tmux#v0.3.0'

set -g @catppuccin_window_left_separator " "
set -g @catppuccin_window_right_separator " "
set -g @catppuccin_window_middle_separator " █"
set -g @catppuccin_window_number_position "right"

set -g @catppuccin_window_default_fill "number"
set -g @catppuccin_window_default_text "#W"

set -g @catppuccin_window_current_fill "number"
set -g @catppuccin_window_current_text "#W"

set -g @catppuccin_status_modules_right "directory user host session"
set -g @catppuccin_status_left_separator  " "
set -g @catppuccin_status_right_separator ""
set -g @catppuccin_status_fill "icon"
set -g @catppuccin_status_connect_separator "no"

set -g @catppuccin_directory_text "#{pane_current_path}"
set -g @catppuccin_flavor 'mocha'

set -g @resurrect-capture-pane-contents 'on'
set -g @continuum-restore 'off'

run '~/.tmux/plugins/tpm/tpm'

And The new one:
unbind r
bind r source-file ~/.tmux.conf
set -g mouse on

set -g prefix C-b
bind C-b send-prefix
bind C-l send-keys 'C-l'

set-option -g status-position top
set-option -sg escape-time 10
set-option -g focus-events on
set-option -a terminal-features 'xterm-256color:RGB'
set -g default-terminal "screen-256color"

# Yazi
set -g allow-passthrough on

set -ga update-environment TERM
set -ga update-environment TERM_PROGRAM

# act like vim
setw -g mode-keys vi
bind-key h select-pane -L
bind-key j select-pane -D
bind-key k select-pane -U
bind-key l select-pane -R

# List of plugins
set -g @plugin 'tmux-plugins/tpm'
set -g @plugin 'christoomey/vim-tmux-navigator'
set -g @plugin 'tmux-plugins/tmux-resurrect'
set -g @plugin 'tmux-plugins/tmux-continuum'
set -g @plugin 'tmux-plugins/tmux-yank'
set -g @plugin 'b0o/tmux-autoreload'
set -g @plugin 'sainnhe/tmux-fzf'
set -g @plugin 'catppuccin/tmux'

set -g @catppuccin_window_status_style "rounded"
set -g @catppuccin_window_number_position "right"

set -g @catppuccin_window_default_fill "number"
set -g @catppuccin_window_default_text "#W"

set -g @catppuccin_window_current_fill "number"
set -g @catppuccin_window_current_text "#W"

set -g @catppuccin_status_left_separator  " "
set -g @catppuccin_status_right_separator ""
set -g @catppuccin_status_fill "icon"
set -g @catppuccin_status_connect_separator "no"

set -g @catppuccin_directory_text "#{pane_current_path}"

run '~/.tmux/plugins/tmux/catppuccin.tmux'

set -g status-left ""
set -g  status-right "#{E:@catppuccin_status_directory}"
set -ag status-right "#{E:@catppuccin_status_user}"
set -ag status-right "#{E:@catppuccin_status_host}"
set -ag status-right "#{E:@catppuccin_status_session}"

set -g @resurrect-capture-pane-contents 'on'
set -g @continuum-restore 'off'

run '~/.tmux/plugins/tpm/tpm'

Attach screenshots.
No response
What tmux version are you seeing the issue on?
tmux 3.5a
Any additional comments?
No response

It looks like the right side has been cut off because the length of the status bar is no longer set by the plugin.
Add the following configuration:
set -g status-right-length 100

Your old look is pretty similar to mine. You can see what changes I had to make here. I think the blue on non-active windows can be restored with:
set -g @catppuccin_window_default_background "#{@thm_blue}"
set -g @catppuccin_window_current_background "#{@thm_peach}"

You can tinker with the backgrounds for windows if you don't like the shading underneath the text:
set -g @catppuccin_window_default_color "#{@thm_surface_1}"
set -g @catppuccin_window_current_color "#{@thm_bg}"

Where is the host module?????

Where is the host module????? And, the green number one in the old is now like, ummmm, merged? Its now pink with another icon, not like the old one.

Did you set the status right length as suggested?

Where is the host module????? And, the green number one in the old is now like, ummmm, merged? Its now pink with another icon, not like the old one.

Did you set the status right length as suggested?

Oh forgot. I am doing it.

The right side problem solved.

But In the left side, the unappropriate colors that i am meaning, in the image i have three tabs open. The left side, rightest tab has orange color, the other two is gray. But in the old one, there was no gray.

Your old look is pretty similar to mine. You can see what changes I had to make here. I think the blue on non-active windows can be restored with:
set -g @catppuccin_window_default_background "#{@thm_blue}"
set -g @catppuccin_window_current_background "#{@thm_peach}"

You can tinker with the backgrounds for windows if you don't like the shading underneath the text:
set -g @catppuccin_window_default_color "#{@thm_surface_1}"
set -g @catppuccin_window_current_color "#{@thm_bg}"

Oh I forgot About This. Sorry. Yeah, it now works as the old one. Thanks guys.


Display the Container ID of the client's connection in Console.

Partly addresses #1605.
Screenshot attached.

@k-wall Happy to see your updates, wondering 'kw1' refers to which Container ID (see my attachment)?

@yih-wang kw1 would be the container id of the connection i.e. the top number in your picture 267f943f-... A lot of libraries default that to a uuid but it can also be supplied by the application making the connection (as in the case for Keith's screenshot).
The link names are sometimes also uuids, though again that is dependent on the library used to connect with and it can also be overridden by the application.

@grs Got it, thanks!


Remove download section

We're not going to support the download of images, at least not until we have a good design for it. So we should remove the code related to it, including feature flag handling

I want to work on it @brenoferreira  :)


⚠ Bofrost.at has degraded performance

In 2ede76d, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1896 ms

Resolved: Bofrost.at performance has improved in 9c28de4 after 6 minutes.


Support prepopulated tabs and headers in playground

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- graphqlapi/src/main/java/io/stargate/graphql/PlaygroundServlet.java  2

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- graphqlapi/src/main/java/io/stargate/graphql/PlaygroundServlet.java  3

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- graphqlapi/src/main/java/io/stargate/graphql/PlaygroundServlet.java  3

See the complete overview on Codacy


Doc about Task, WIP

Anything specific I should add? Got a few good ideas for examples?

In February this made a lot of sense, now I think it seems a bit more niche with #1197 on the horizon. Where do we stand on that state of this PR?

Drop it, link to cats-effect documentation?

It's probably still nice to say a few words about some operations appearing on both Response and Task[Response] (and likewise Request).  But a general discussion of effects should definitely refer to the cats-effect documentation.
With the deprecation of fs2.Task, I think cats.effect.IO will be what we see in our docs.


Remove generated dependency-reduced-pom.xml

@dgutierr, @romartin could you please quickly check this? I believe it fine to remove this file.

+1


Random Events: "Pick" option on Strange Plant isn't removed

Describe the bug
The Remove others' menu options option in the Random Events plugin doesn't work on Strange Plants.
Environment:

OS: Windows 10
RuneLite version: 1.5.41-SNAPSHOT

Determining whether a strange plant belongs to you isn't as straight forward as other events and wouldn't be reliable in crowded areas so it was left out.

Is it possible at all to determine who a strange plant belongs to? As I understand it, it does not interact with players like the other random events do. The only indicator to my knowledge is the direction it faces when it spawns, so we could reliably determine when it is not ours (if it faces away as it spawns) or sometimes if it is ours (if we are the only player on a tile it is facing). If that's not a reliable detection method this issue should be closed since we cannot fix this.

The Strange Plant always faces South, so that approach doesn't work. I was considering checking adjacent tiles for players when it spawns but that's even less accurate than orientation. I guess sometimes not removing options if there are many players in the area isn't terrible, but that's the main situation in which you'd want to remove the options anyway.

Is there a delay to the strange plant spawning? If not, can we not rule out it being "your" plant if it spawns more than a tile away from you?


Issue using ReactLayout.render

Hi, sorry for posting this question here. Wasn't quite sure where was the best spot to post it.
While trying to pass a React component to the main layout content prop, I get "SyntaxError: Unexpected token <"
I tried to follow the guide in this repo. Note that I don't get the error if I user a simple string like "Hello" in content: . It renders and displays Hello correctly.
Thanks for your assistance!
My default route:
FlowRouter.route('/', {
name: 'Home',
action: function(params) {
ReactLayout.render(MainLayout, {content: });
}
});
My MainLayout (exactly like the guide):
MainLayout = React.createClass({
render() {
return(

            </header>
            <body>
                {this.props.content}
            </body>
            <footer>

            </footer>
        </div>
    );
}

});
My Home component:
Home = React.createClass({
render() {
return (

{this.props.welcome}

)
}
});

I am adding an image of the code to avoid the markdown of GitHub...

It might be that your router file is has a .js extension instead of .jsx

That was exactly that!
Merci @maz-dev :)

Thanks @maz-dev !


% and £

Add % and £ to the relevant text boxes on the interface.  Either at the end as text or within the box as a glyfy thing.

Added using
.form-control {
/* set the width to less than 100% to leave space for £ and %  */
display: inline;
width: 80%;
}
.percentage:after {
content: "%";
}
.pounds:after {
content: "£";
}

0dc3e3c01b569f39e21017364db357bcc38c653d


COMP: fix compilation of external project depending on RTK with Cuda

@LucasGandel I think this is required until CudaCommon is split to a separate repository.

What do you think @LucasGandel?

@SimonRit Sorry for the late reply. Yes this should be correct as long as ITKCudaCommon is built with add_subdirectory.
+1


Fix rest-server tests

Since today, the rest-server needs to be explicitly told (via --no-auth) that authentication is not necessary.

Codecov Report

Merging #1684 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   52.14%   52.18%   +0.04%
==========================================
  Files         143      143
  Lines       11394    11394
==========================================
+ Hits         5941     5946       +5
+ Misses       4534     4529       -5
  Partials      919      919

Impacted Files
Coverage Δ

internal/archiver/archiver.go
64.04% <0%> (-0.22%)
:arrow_down:

internal/backend/s3/s3.go
63.07% <0%> (+2.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0fee9...e5c929b. Read the comment docs.


chromium: 56.0.2924.87 -> 57.0.2987.110 [release 16.09]

Motivation for this change
Security fixes. Includes backport of fix to make patchPhase work again.
cc @joachifm @aszlig @grahamc
Things done
Build in progress. Patch Phase + Configure Phase works

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Testing currently


Add work/jobs badges

added in https://github.com/inttter/md-badges/commit/b2bbe69973703228bdd33c338a9ff54ee19882e7


exchangeRefreshTokenForAuthTokens not returning new refresh_token as stated in documentation

I'm trying to get a new refresh token without having to use my npsso token. I was hoping that exchangeRefreshTokenForAuthTokens would do this as the description of this function in the documentation makes me think it should.

This function lets you exchange your refresh token retrieved from your initial log in for a set of new access and refresh tokens. By using this function, you no longer need to constantly retrieve a new NPSSO.

Unfortunately, it returns the refresh token I use to make the call, and the "refresh_token_expires_in" property doesn't reset so it keeps counting down. Can I only get a new refresh_token once the current one has expired, or is this function broken?
I'm looking for something that returns a new refresh token without the need of my npsso. Basically I want to keep my authentication valid as long as possible instead of having to login to playstation.com every 2 months.

is this function broken?

In order to rapidly respond to breaking changes, psn-api is intentionally low-level. The function is a very thin wrapper around direct API calls to PSN itself, with little to no magic within.

I'm looking for something that returns a new refresh token without the need of my npsso. Basically I want to keep my authentication valid as long as possible instead of having to login to playstation.com every 2 months.

That is indeed desirable. To the best of my knowledge, no public-facing endpoint exists for this purpose. However, if one does exist, I'd be happy to add it.

Alright, makes sense. Perhaps an idea to update the documentation for this part: https://psn-api.achievements.app/api-docs/authentication#exchangerefreshtokenforauthtokens as it let me to believe that there's a way to keep your 'session' alive without the need for your npsso token. If I understand correctly, the maximum time to keep a live connection with the API is 2 months before you'll need a new npsso token?
thanks in advance :)


Fetch and pre-process Glass AI data

Closes #2

I tested the getters and they work. Good to merge with a couple of observations:

A bit of RY with run_data = run.data if run else _get_run_data() in multiple functions (admittedly it is a one liner)
The get_organisation_metadata getter looks like a leftover from kuebiko. Perhaps we should remove it from here given it is not relevant for the project?

All tested, good to merge


[🐛] Android: Application not responding after selecting many videos

Description
When selecting many videos in the new Android 13 picker, an Android "Application Not Responding" message appears.
If "wait" is pressed, then the application works fine, so the main thread is not the one that is stuck.
Detail about the videos is shown, and thumbnails are here as expected.
How to repeat issue and example

launch the example app on an Android 13 phone
tap "select image or video"
select 15 videos from your library
wait for the videos to be process, then see that an ANR dialog is shown

Solution
There should not be any ANR
Additional Information

Image Picker version: 5.4.0 (also 5.3.1)
React Native version: 0.71.2 (example app), 0.71.8 (my app)
Platform: Android
Development Operating System: macOS

I think this is fixed by #2139, I am no longer reproducing the issue with this patch.

Update: I have been testing this further, and while the issue occurs less often, I still get ANRs when selecting a lot of videos using the new Android 13 photo picker.
I am starting to suspect this is an Android issue.

Still investigating this…
It only happens when getAppSpecificStorageUri() is called, meaning the files are copied to the app's cache directory.
This led to #2141 which fixes some issues, but unfortunately I can still reproduce the crashes.
I tried to not copy the files to the app's cache directory, but instead require Android to make the content:// URLs persistant, and this seems to solve the issue. I will tidy up my work on this and submit a PR.

Another update:

MediaMetadataRetriever also needs to be closed after use, I updated #2141 to do it. This change made a big difference and after some testing I did not get ANRs once the files were processed
The processing is done in the main thread, which can cause it to be unresponsive and trigger ANRs while the files are processed after being picked. This also makes the app UI non-responsive. Opened #2142 to run the processing in another thread

With those 2 changes I am no longer experiencing ANRs or crashed, even when selecting 50 videos on the phone.
getAppSpecificStorageUri() still makes things quite slow as every file needs to be copied in the app's storage, so I may still send yet another PR to allow avoiding this step through an option.

Closing the issue as the PRs mentioned above have been merged and fixes the issues for me.


Suggestion: Enabling both Double and Triple Hook

It would be amazing if you could turn on the "Use Double Hook" and the "Use Triple Hook" options both at once. So that if the hook triggers it would use either Hook, Double Hook, or Tripple Hook depending on how much GP you have.

There's not much use enabling both option, for example, if you enable both options with max GP, the first hook is going to be a triple hook and every other hook will always be a double hook because it'll never reach the GP for the next triple hook


Assert the default value in unwrapOr/unwrapOrElse for Maybe/Nullable/Undefinable

Fix https://github.com/karen-irc/option-t/issues/254

This change is

bors r+


Cannot login.

I used gcalcli list --noauth_local_webserver to try to auth my account, but even so I cannot login, after I past the code, nothing happens. is there any way i can get more debug information? using OS X 10.10

I've tested again on 10.10.2 and I'm still not able to reproduce this.  I am given the URL, I visit the URL, authetnicate, copy the code, paste the code in the terminal, hit return and am given "Authentication successful."


Revert "stmcginnis changes for cinder profiles."

Fixes: https://clusterhq.atlassian.net/browse/FLOC-3069
This reverts commit 1b5ef85b8874f1ba3b4cf42d39f3583dd9134904.

Reverted independently.


airplane path color matrix

each airplane should use a different color for highlight and path

Notes and requirements:

the max planes variable configuration.airplaneSeedTime never exceeds 8, we probably need at most 8 different colors
it wont work right to just cycle through a color array, since planes can land or fly off screen so the order is not linear. to guarantee each plane on screen uses a different color it will require some logic to figure out what colors are currently assigned to planes and what colors are not.
the highlight circle and the line path should both use the same color

Improvements:

find next unused color
also include stroke color and highlight color as arrays to match

@ansmor


after change default key mapping, navbuddy asking choice lsp server

currently I'm using mason , and I set the navbuddy attach on tsssever
require("lspconfig").tsserver.setup { capabilities = capabilities, on_attach = function(client, bufnr)
navbuddy.attach(client, bufnr)
end
}
after I set the default key map. I found navbuddy asking choice lsp Client
local navbuddy = require("nvim-navbuddy")
local actions = require("nvim-navbuddy.actions")
navbuddy.setup {
mappings = {
["o"] = actions.parent(),
["m"] = actions.children(),
},
source_buffer = {
follow_node = true, -- Keep the current node in focus on the source buffer
highlight = true, -- Highlight the currently focused node
reorient = "smart", -- "smart", "top", "mid" or "none"
scrolloff = nil -- scrolloff value when navbuddy is open
}
}
screenshot
this message only show after override default keymap setting
currently I have three lsp client for typescript (ts server, tailwind , emmet-ls)
I think it is related something but don't know how to fix it
This is my neovim config file
https://github.com/tendertree/config/tree/main/data/nvim

Hi @tendertree !
I wasn't able to reproduce your issue.. but have added some changes that might help.
Can you checkout if "fix_repeatation" branch fixed your issues?

Thanks :) !
after apply "fix_repeatation" branch, it fixed issue :) work out of box :)


⚠ ClamAV has degraded performance

In 0a0d46c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 85 ms

Resolved: ClamAV performance has improved in a2fd23a after 6 minutes.


Make config setup for target data/theme path

Hello,
While I'm testing it, I found that fixed data/theme path and value is a bit inconvenient on working. I have to fix the setups in data.js every time after cleanup git status(it is not ignored by git), and need to add theme path in 'data/theme.js', 'src/theme/index.js' and some more files.
How do you think about...

Setup data path as config file so make it easy to change target file
Add theme loader to check all themes in 'src/theme' directory so user don't need to add every part of the code
...and would it be better to make data.js as JSON file? Cause it only includes data, there's no codes

Please look on, and share us if you have other plans for this.
Thanks.

Hello, @djKooks .
Thank you for your good feedback.
I did not care about this project on a personal schedule. Based on your feedback, we are planning an overall code refactoring. The project is still 0.0.2 version, so there are many deficiencies because it is for personal use. Please refer to the issue (https://github.com/JaeYeopHan/myownresume/issues/19) for the official release plan.

@JaeYeopHan Okay, I got it. But I just want to know is how you think about it.
So I mean, will it be okay to me to work on this? If you are planning to keep in current state, I'll let this as now. But if you think it will be better to fix as what I commented, I'll look on to update it. Because this will change some directory tree structure, I wanted to ask you to know how you think.
Thanks.

@djKooks Oh, I got it.
If the directory structure you want to change is better than it is now, I think it is right to proceed. However, it is difficult to grasp only the text registered in the current issue. If you register this content as a pull request in this repository, I will actively review it.
Thanks.

@JaeYeopHan Okay, thanks!
I'll work on it when I have time. Please look on it and update if you think it looks better for working.


az image builder output: how to specify SIG version in distribute

My question is related to az image builder output command which related to Azure Image builder RP.
az image builder output add -n mytemplate -g my-group --gallery-name my_shared_gallery \
    --gallery-replication-regions westus brazilsouth \
    --gallery-image-definition linux_image_def --defer

Our customers want to add image version with image definition for Shared image gallery. They create image builder template using az builder output add  commands. It seems this command does not have option to add gallery image definition version.
They can still add it if they supply whole template in command like this..
az image builder create -g gaagar-testing -n gaagartest1 --image-template <template name>

Compute

Hi @garimakhulbe02, please see az sig image-version create


OK does not work in the Add Word dialog sometimes

Currently when I add a word to a dictionary I have to use touch screen to confirm the word. It would be nice if Ok key would confirm the word in the dialog.

If I press the hardware OK on my phone, it automatically selects the OK of the dialog, then I just need to press it again to add the word. In other words, double pressing OK on the keypad is enough to add the word.
I am unsure if this is Android standard or it's something Xiaomi did on mine. Have you tried double pressing on yours? If it doesn't work, this would be worth implementing, indeed.

Hmm. It works but not reliably. I found when it doesn't work.

Open fresh input
Type some word
Press asterisk (star)
Press ok multiple times

I cannot reproduce it, but I suppose different phones and/or Android versions are not exactly consistent.
Either way, there are two ways of solving this:

Define (or fix) the default action of the input field in the Add Word dialog. The OK key is already adjusted to execute the default action if there is one, so it would automatically start working.
Modify TraditionalT9.onOk() to save the word when the input field has private option io.github.sspanak.tt9.addword. This is more of a hack, so option 1. is the better one.

I've changed the title to reflect better the problem we are discussing. I hope you don't mind.

It's all good, no need to do anything fancy. I just fixed the default action and it now works properly. It's just 2 lines of code.
It will be available in the next release. :slightly_smiling_face:


Add ISSUE_TEMPLATE.md

Coverage remained the same at 100.0% when pulling 22a7919d19297682a026cd02d60f532b0a228513 on issue-template into ff93ad95ac98c4a2255c9391ddefe4931612495d on master.

Coverage remained the same at 100.0% when pulling 22a7919d19297682a026cd02d60f532b0a228513 on issue-template into ff93ad95ac98c4a2255c9391ddefe4931612495d on master.


uninitialized constant Pod::MasterSource::MASTER_REPO_NAME

Hi, on OSX Mojave 10.14.5
after:

gem install cocapods-art
pod repo-art add cocoapods-remote-github https://mycompanyartisrv.domain/api/pods/cocoapods-remote-github
Modified file .Podfile:
plugin 'cocoapods-art', sources => [
'cocoapods-remote-github'
]
and now when we want to "pod install", all dependencies download correctly but on the end there is error:

/Library/Ruby/Gems/2.3.0/gems/cocoapods-art-1.0.3/lib/cocoapods_plugin.rb:122:in block in source_from_path': uninitialized constant Pod::MasterSource::MASTER_REPO_NAME (NameError) Did you mean?  Pod::MasterSource 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-art-1.0.3/lib/cocoapods_plugin.rb:130:in source_from_path'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-core-1.5.0/lib/cocoapods-core/source/manager.rb:301:in block in aggregate_with_repos' 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-core-1.5.0/lib/cocoapods-core/source/manager.rb:301:in map'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-core-1.5.0/lib/cocoapods-core/source/manager.rb:301:in aggregate_with_repos' 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-core-1.5.0/lib/cocoapods-core/source/manager.rb:24:in aggregate'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-core-1.5.0/lib/cocoapods-core/source/manager.rb:61:in all' 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/lib/cocoapods/user_interface/error_report.rb:170:in repo_information'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/lib/cocoapods/user_interface/error_report.rb:77:in stack' 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/lib/cocoapods/user_interface/error_report.rb:24:in report'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/lib/cocoapods/command.rb:66:in report_error' 	from /Library/Ruby/Gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:396:in handle_exception'
from /Library/Ruby/Gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:337:in rescue in run' 	from /Library/Ruby/Gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:324:in run'
from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/lib/cocoapods/command.rb:52:in run' 	from /Library/Ruby/Gems/2.3.0/gems/cocoapods-1.5.0/bin/pod:55:in <top (required)>'
from /usr/local/bin/pod:22:in `load'_
how to fix it? because it crash Jenkins build...

Have you done a $ pod repo update? CocoaPods still needs the master repo to be checked out.

Have you done a $ pod repo update? CocoaPods still needs the master repo to be checked out.

Yes and it not worked.

I have the same issue when running pod install on the CI

Upon further investigation, seems like cocoapods-core introduced a breaking change in 1.8.0 on this PR when they replaced Pods::MasterSource with Pods::TrunkSource here https://github.com/CocoaPods/Core/pull/552/files#diff-93c5b71b3ca5a2938863bca360c91993R31
I assume this is something that can be fixed within cocoapods-art here https://github.com/jfrog/cocoapods-art/blob/master/lib/cocoapods_plugin.rb#L122
In order to fix my CI build, I changed the cocoapods version to 1.7.x in Gemfile, forcing the cocoapods-core dependency to downgrade
gem "CocoaPods", "~> 1.7.0"

Created a PR for this which fixes the issue. Hopefully it will be merged soon!
https://github.com/jfrog/cocoapods-art/pull/36


xgboost.core.XGBoostError: b'[18:53:36] /root/repo/xgboost/src/common/host_device_vector.cu:355: Check failed: distribution_.IsEmpty() || distribution.IsEmpty()

Traceback (most recent call last):
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/sklearn.py", line 738, in fit
    callbacks=callbacks)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/training.py", line 227, in train
    xgb_model=xgb_model, callbacks=callbacks)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/training.py", line 74, in _train_internal
    bst.update(dtrain, i, obj)
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/core.py", line 1053, in update
    dtrain.handle))
  File "/home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/core.py", line 170, in _check_call
    raise XGBoostError(_LIB.XGBGetLastError())
xgboost.core.XGBoostError: b'[18:53:36] /root/repo/xgboost/src/common/host_device_vector.cu:355: Check failed: distribution_.IsEmpty() || distribution.IsEmpty() \n\nStack trace returned 10 entries:\n[bt] (0) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN4dmlc15LogMessageFatalD2Ev+0x26) [0x7fb3d1a5dcf6]\n[bt] (1) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost20HostDeviceVectorImplIfE7ReshardERKNS_15GPUDistributionE+0x8e) [0x7fb3d1c4d0ae]\n[bt] (2) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost3obj10RegLossObjINS0_22LogisticClassificationEE11GetGradientERKNS_16HostDeviceVectorIfEERKNS_8MetaInfoEiPNS4_INS_6detail20GradientPairInternalIfEEEE+0x47f) [0x7fb3d1c7309f]\n[bt] (3) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(_ZN7xgboost11LearnerImpl13UpdateOneIterEiPNS_7DMatrixE+0x385) [0x7fb3d1aeb815]\n[bt] (4) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/site-packages/xgboost/./lib/libxgboost.so(XGBoosterUpdateOneIter+0x35) [0x7fb3d1a6c755]\n[bt] (5) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call_unix64+0x4c) [0x7fb575fdee40]\n[bt] (6) /usr/lib/x86_64-linux-gnu/libffi.so.6(ffi_call+0x2eb) [0x7fb575fde8ab]\n[bt] (7) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(_ctypes_callproc+0x2cf) [0x7fb5761f2d2f]\n[bt] (8) /home/jon/.pyenv/versions/3.6.4/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so(+0x8c69) [0x7fb5761e9c69]\n[bt] (9) /home/jon/.pyenv/versions/3.6.4/lib/libpython3.6m.so.1.0(_PyObject_FastCallDict+0x8a) [0x7fb5c8b158ca]\n'
"""

Hitting this now alot and wasn't hitting this a few months ago.  I can find repro.

Can you provide the exact commit of XGBoost?
There's a known bug that if you want to change the number of GPU* you need to reload all data.

aa48b7e9033a4d78bf4f336960f62f63212d5530
All of our tasks are in a sub process and no model or cuda context is preserved across any of our xgboost runs.
But, it seems like once this bug is hit, it keeps happening over and over.

@pseudotensor Could you show me how to reproduce it?  The error is mostly caused by changing the n_gpus or gpu_id without reloading data.  But I can't be sure if that's the problem you encountered.

I would like to provide an MRE, but it doesn't happen in a deterministic way apparently.  Also odd is when it happens it seems to cause it to happen alot, even though all our xgboost calls are in a subprocess.
I'll keep looking to isolate it at least to give MRE.

distempty.zip
This issue never occurred until the recent xgboost updates in last few months.

distempty2.zip

@pseudotensor We have multiGPU tests set up in Jenkins CI

Similar changes are also applied to script contained in distempty.zip

As I mentioned above, it works for n_gpus=1 or 2 but failed for 3 or 4.  Those arguments are not important.

@pseudotensor We are currently using P2.8xlarge instance (8 GPUs) for multi-GPU testing. See https://github.com/dmlc/xgboost/blob/master/tests/ci_build/test_mgpu.sh for the list of commands. As far as I know all of the 8 GPUs are used.

Ok great.  Then should be able to reproduce the above with the available system.

@pseudotensor I'll try to reproduce it on my end using P2.8xlarge. If so, we'll need to add more tests. Multi-GPU testing is in its infancy, so it needs more coverage.

@trivialfis Do you have access to a machine with 4+ GPUs?

@hcho3 No.  If there's not too much traffic on Jenkins I will open a small PR for testing in a few days.

@RAMitchell This is again caused by having less data than number of GPUs.  One way to solve it is by moving devices_ = GPUSet::All(param_.gpu_id, param_.n_gpus); of every objectives  from Configure into both GetGradient and PredTransform.  Another way is we start planing a global devices manager which can take all DMatrix including the ones from training, eval_set and predict into consideration.
Personally I prefer the later.  But any other suggestions are welcomed.
Another thing worth noting is that, after commit a9d684db185b1e5ee5a0dd64b646b58da28e6b05 , the script provided by @pseudotensor hangs in ncclAllReduce when calling AllReducer::AllReduceSum.  Recreating the model works fine.  Weird world.

@trivialfis You could do the first for a quick fix, the second for a long-term fix. I will leave it up to you.

Fixed as we now have an unified way of passing gpu_id, also tests for handling empty dataset.


Only approachable via Spotify on computer not via phone

Since updating both my raspberry and I think the spotify app on my phone (Android), I can no longer approach Librespot directly from my phone. When I setup a connect session via the computer I am able to use my phone as a remote.
Any ideas? I found out that the Spotify app does the same with Sonos lately

I just installed Raspotify and I'm experiencing the same results.
The device shows up on Spotify on my mac, but not on my Android.
Only after selecting the device on my mac it shows up on my Android.
After disconnecting it's gone from my Android again.
INFO:librespot: librespot 8971d3a (2017-10-05). Built on 2017-10-05. Build ID: POyxPQVg

If this is occurring with Sonos as well, wouldn't that indicate it's a Spotify issue? It sounds like they've broken casting completely. Did you end up with any solution to this?

I suspect this is your issue:
https://community.spotify.com/t5/Other-Partners-Web-Player-etc/Sonos-Bug-Spotify-Connect-is-broken/td-p/3608434
https://community.spotify.com/t5/Android/Spotify-app-won-t-connect-to-Sonos/td-p/3564456
Downgrading the android app should solve your problem. That's a pretty bad bug!


feat: Support syncing all objects from a given point in time forward

This PR adds an optional argument that when specified overrides all positions to be from that point in time forward. This PR also adds an argument to exclude objects from this behavior by persistence key. When the startFrom time is nil, the behavior is unchanged.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


load_weights fails because 'layer_names' is missing

Hi,
I am re-opening this issue again from this link #3359.
My problem is described in here
Please advise. Thanks.

Please clarify the issue as I am also facing the same issue. I have the same code and using the same version of keras.


dev-community: Document chat.zulip.org linkifier for flutter project.

Adds the Flutter mobile project to the section on chat.zulip.org linkifiers in the development community page. Moves the React Native mobile project to the bottom of the list as that project/repository is in maintenance mode.
Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @laurynmm!


Update CLI naming to pg:privatelink

Updates CLI naming to pg:privatelink
See this Trello card for more details.

Codecov Report

Merging #11 into master will increase coverage by 2.47%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage    86.9%   89.37%   +2.47%
==========================================
  Files           9        9
  Lines         168      160       -8
  Branches       22       20       -2
==========================================
- Hits          146      143       -3
+ Misses         11        6       -5
  Partials       11       11

Impacted Files
Coverage Δ

src/commands/pg/privatelink/access/remove.ts
95.23% <100%> (ø)

src/commands/pg/privatelink/access/index.ts
81.25% <100%> (ø)

src/commands/pg/privatelink/create.ts
96.29% <100%> (ø)

src/commands/pg/privatelink/index.ts
78.12% <100%> (ø)

src/commands/pg/privatelink/access/add.ts
95.23% <100%> (ø)

src/commands/pg/privatelink/wait.ts
94.44% <100%> (ø)

src/commands/pg/privatelink/destroy.ts
93.33% <100%> (ø)

src/lib/fetcher.ts
50% <0%> (+8.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1ebe1...92e866a. Read the comment docs.


link The Dao of Immutability to medium post in README.md

I was curious why functional programming is next (current) big thing, but the link was broken.
Is this link correct?

Thank you!


Allow testing of interactivate code paths within BuildStream

See original issue on GitLab
In GitLab by [Gitlab user @Qinusty] on Aug 17, 2018, 12:07
The following discussion from !662 should be addressed:

[ ] [Gitlab user @Qinusty] started a discussion:

I have removed the tests I was prototyping from this branch.
Further work is required for testing interactive parts of BuildStream
Tasks:

[ ]  Be able to cli.run() on a separate process.
[ ]  Be able to send signals to such a process.

BuildStream test utils currently provide no utilities for running BuildStream on a separate process. This inhibits the ability to test BuildStream's interactive code paths.

In GitLab by [Gitlab user @Qinusty] on Aug 17, 2018, 12:09
mentioned in merge request !662

In GitLab by [Gitlab user @jonathanmaw] on Oct 24, 2018, 17:24
I tried to get interactive testing to work while working on https://gitlab.com/BuildStream/buildstream/merge_requests/869, and while I haven't managed to do so successfully, I'll document my findings in case they're useful in future.
My first attempt was with using pexpect (https://pexpect.readthedocs.io/en/stable/api/index.html).
    # Start an interactive session and intercept the interactive prompt
    child = pexpect.spawn('bst', ['--no-colors', 'build', element_name], cwd=project)

    # Ensure starting a shell is a valid option
    child.expect('\(s\)hell')

    # Wait for the interactive prompt
    child.expect('Choice: \[continue\]:')

    # Start a shell and wait for the shell's prompt
    child.sendline('s')
    child.expect('\]\$')

    # Read the contents of the file we added
    child.sendline('cat test')
    child.expect('Hi')

This worked locally, but this turned out to be because buildstream was installed on my local computer. When running through the CI worker, it failed because bst is not installed - our tests invoke buildstream's main() directly. Looking into what pexpect was capable of, it was ultimately impossible to get it to call a function instead of starting a new process (technically, it can call a function before starting the new process, but that's for fiddling with signal handlers, rather than tracking input/output as it's executed.)
At this point, my options seemed to be to either make gitlab-ci install buildstream as part of testing, or write my own solution to monitor a fork's input/output. This appears to be done by the built-in module pty, using pty.fork()
From a modified version of a script I found on stackoverflow, a basic script that uses pty.fork() is:
#!/usr/bin/env python3

import sys
import os
import time
import pty

def echo():
    while True:
        line = sys.stdin.readline()
        if "END" in line:
            break
        else:
            print(line.upper())
    return "END"

def my_pty_fork():

  # fork this script
  try:
    ( child_pid, fd ) = pty.fork()
  except OSError as e:
    print(str(e))

  if child_pid == 0:
      print("In child process: PID# %s" % os.getpid())
      result = echo()
      exit(1)
  else:
    print("In Parent Process: PID# %s" % os.getpid())
    # MUST read from fd; else no spawn of child!
    print(os.read(fd, 100))

    os.write(fd, bytes("message one\n", "utf-8"))
    print(os.read(fd, 100))
    time.sleep(2)
    os.write(fd, bytes("END\n", "utf-8"))
    print(os.read(fd, 10000))
    time.sleep(2)
    print(os.read(fd, 10000))
    _, waitdata = os.waitpid(child_pid, 0)
    print("Child died with result {}".format(os.WEXITSTATUS(waitdata)))

if __name__ == "__main__":
    my_pty_fork()

Unfortunately, this did not translate as easily to getting an interactive session to work with buildstream. Calling cli.run() in a fork didn't work for me because:

(possibly) we monitor the stdout and stderr of calls to main()
stdin is redirected to /dev/null when calling main()
buildstream will only provide an interactive prompt if stdout and stderr are TTYs (i.e. sys.stdout.isatty())
the child process from pty.fork() doesn't seem to actually write through the pseudo-terminal, instead being received through whatever capture device is normally used. I think this is due to pytest controlling stdout/stderr somewhere else.

Ultimately, I gave up because I didn't understand enough about what pytest does to stdin/stdout/stderr to make it do what I wanted.

In GitLab by [Gitlab user @jonathanmaw] on Oct 24, 2018, 17:56
mentioned in merge request !869

In GitLab by [Gitlab user @cs-shadow] on Jul 17, 2020, 19:30
Initial batch of interactive tests were added in https://gitlab.com/BuildStream/buildstream/-/merge_requests/1706. We can always add more test cases to cover more scenarios, but I 'll close this issue now as the initial implementation is done.


Allow mounting be-log fe-log volume to side car container

Describe the problem
Some logs like fe.internal.log fe.gc.log.20240605-094644 are not print to stdout even when LOG_CONSOLE=1 is set.
One way to get it to datadog is to tail it from a sidecar container and leverage datadog agent to upload it to DD backend
Describe the solution you'd like
Have an option in the helm values.yaml file to allow mounting log volume to sidecar
Additional context
Add any other context or screenshots about the enhancement here.

The sidecar is fully open, allowing users to attach any volume to the sidecar themselves.
In helm values.yaml, you can check how log volume name is named.
    - name: {{ .Values.starrocksFESpec.storageSpec.name }}{{ template "starrockscluster.fe.log.suffix" . }}


Compute 'now' average intensity estimate alongside optmised one

In order to estimate carbon emission savings, cats needs to know:

The average carbon intensity associated to running the job at the time of running cats
The average carbon intensity associated with running the job at the proposed time.

Currently, (1) is computed independently of (2) using a separate function parsedata.avg_carbon_intensity. This could however be computed alongside (2) directly as the first item in the WindowedForecast object*.
This makes get_lowest_carbon_intensity return two CarbonIntensityAverageEstimate values now and then, corresponding to (1) and (2), respectively. This removes the need for parsedata.avg_carbon_intensity and parsedata module altogether.
Note that #45 adds a couple of tests checking that (1) and (2) are computed correctly.

*As a reminder, (2) is computed by taking the min of a WindowedForecast object (see get_lowest_carbon_intensity), where the window size is the job duration in unit  of forecast time intervals (e.g. 30min).

@tlestang I'm a bit confused here as to why continue editing main as PR #43 is still pending? Wouldn't it be best to include these changes into #43, as I think it already addressed some of this? (Test #45 would be great to add in particular)

I'm closing this. It is replaced by #52 which directly onto the new project structure introduced in #49.


Only the first method of a resource defined in an external file is detected

I'm trying to define a resource type in an external RAML file, but when ramlfications parses it, only the first of several access methods (get/post/patch/etc.) are detected. A minimal set of RAML files illustrating the problem are attached (GitHub doesn't support uploading .raml files, so the extensions need to be changed).
externalResource.raml.txt
resource_with_multiple_methods.raml.txt
When I parse 'resource_with_multiple_methods.raml', the result has four resources - get, patch and post for the /internal path, but only get for the /external path. I would have expected 'get', 'post' and 'patch' methods for both paths.
>>> from ramlfications import parse
>>> spec = parse("resource_with_multiple_methods.raml")
>>> spec.resources
[ResourceNode(method='get', path='/internal'), ResourceNode(method='post', path='/internal'), ResourceNode(method='patch', path='/internal'), ResourceNode(method='get', path='/external')]

I reproduced this behaviour with ramlfications 0.1.9.
Any help would be greatly appreciated.

I have developed a test case and a fix for this issue based on the RAML files included in the issue description in the 0.2.0-dev branch (the problem exists in 0.2.0-dev as well as 0.1.9), but unfortunately the fix has broken the tests/test_parser.py::test_resource_inherits_type test case, and I don't understand enough of how the parsing works to fix what I've broken. Would someone who knows more about how the parsing works be able to take a look at what I've done? Do I need to post a pull request?

@bpowell65536 hey sorry I didn't originally respond. You don't have to make a PR, but it'd be great if you could push it to a branch on your fork, then I can take a look at it.

@econchick Thanks for your response :). I have pushed my changes to the v0.2.0-dev branch on my fork of ramlfications, which is here: https://github.com/bpowell65536/ramlfications/tree/v0.2.0-dev/ramlfications . The changed implementation file is ramlfications/parser/main.py, the associated tests are in tests/test_parser.py and the test data files are tests/data/examples/external_resource_with_multiple_methods.raml, tests/data/examples/extended_external_resource_with_multiple_methods.raml, tests/data/examples/includes/external-resource.raml and tests/data/examples/includes/extended-external-resource.raml.

I think I have fixed the problem. I have run tox on my version of the code and all the tests are passing on Python 2.6.9, 2.7.6, 3.3.6, 3.4.3 and pypy 2.2.1, except tests/test_tree.py:test_print_tree_light_v, tests/test_tree.py:test_print_tree_light_vv, and tests/test_tree.py:test_print_tree_light_vvv, which were marked as skipped in the original checkout of the code. I can make a pull request now if you like.

Sure, feel free to make a PR.

OK, done. PR is here: https://github.com/spotify/ramlfications/pull/88

@econchick I have made a new PR with all the previous commits (including changes in response to comments on this PR) squashed into one: #91. There is an extra commit because my change broke some of the CI tests - I can try to squash this into the same commit as well if you like.

Thanks a lot for your PR @bpowell65536. I'm having the same issue. Originally described it here https://github.com/spotify/ramlfications/issues/23#issuecomment-153009690

@postatum No worries! Hope it helps!

@econchick This issue didn't really go through the normal process, but since it is fixed now, did you want me to close it?

sure, thanks!


chore(ci): bump cargo-make version

See https://github.com/sagiegurari/cargo-make/releases

Perhaps replace with https://github.com/davidB/rust-cargo-make and just use latest.
Alternatively I think there is a way to reference the latest url on a github release.


Bump react-remove-scroll version (prevent spurious console errors)

Bug report
Current Behavior
The dependency react-remove-scroll (at v2.5.5) can spew spurious console errors (see #1594 and #1670).
react-remove-scroll-bar: cannot calculate scrollbar size because it is removed (overflow:hidden on body
    at RemoveScrollBar (http://localhost:3000/node_modules/.vite/deps/chunk-Y3VCPVOO.js?v=fe40dff0:440:26)
    at RemoveScrollSideCar (http://localhost:3000/node_modules/.vite/deps/@radix-ui_react-dialog.js?v=fe40dff0:1260:35)

Expected behavior
No spurious console errors
Suggested solution
Update react-remove-scroll from 2.5.5 to 2.5.6.

@benoitgrelard something seems very off here...
First, without question the dependency react-remove-scroll is set to 2.5.7 in all the appropriate locations. However, if you look at the lock file, react-select somehow resolves to 2.5.5.
And while, I'd probably never even notice this, there does seem to be an issue with react-remove-scroll.
Here is a link to a decent write-up:
https://github.com/shadcn-ui/ui/assets/49651661/75ee2744-285c-4019-865a-4411f15c9d41
Some how there is 64px of margin being inserted into the body.
So I'm a little lost...
My default stance is that there is something wrong with my setup, but I'm really struggling to understand what that could be.
Any ideas what might be going on here? Should I open a separate issue?
(And again to restate, I don't know that the dependency resolution matters much. I am concerned about the margin)

Ok, I'm maybe more or less confused, but either way I think there is a resolution
Here is a screenshot of the computation react-remove-scroll-bar uses to add margin to the body:

The problem is that somehow the window.innerWidth is evaluating to 454 when it should be 390. This mismatch is what results in react-remove-scroll-bar adding 64px of left-margin to the body.
However....
This only seems to be a problem with dev-tools (Brave). So again, I'm a little lost / confused, but... 🤷🏻

First, without question the dependency react-remove-scroll is set to 2.5.7 in all the appropriate locations. However, if you look at the lock file, react-select somehow resolves to 2.5.5.

I know!!! I got so confused by that when I did the upgrade! I kept trying to nuke some of these out of the lockfile and but it kept coming back. Eventually I realised why! That's because we have storybook in the repo, and they happen to use some radix components for their UI, Select being one of them, so that resolution is their Select. You can see they are a version behind for it.
That has no effect on our packages' latest versions though.
Do you still have your issue after updating to the latest RC which would include this change? Worth noting also because this is a dependency of a dependency, you may not get it automatically as it would be locked in your lockfile, so you may need to nuke that first.
FWIW I can't reproduce what you're talking about so inclined to think it's something about your setup. If you can reproduce something in a sandbox we can take a look.


Right side button column cuts off text descriptions

Describe the bug
In the title
To Reproduce
Just open the plugin
Expected behavior
Should be wider or maybe have a column slider to widen it manually and save the position
KiCad Version

Application: KiCad x64 on x64

Version: 8.0.2, release build

Libraries:
	wxWidgets 3.2.4
	FreeType 2.12.1
	HarfBuzz 8.3.0
	FontConfig 2.14.2
	libcurl/8.5.0-DEV Schannel zlib/1.3

Platform: Windows 11 (build 22631), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Apr 27 2024 23:05:17
	wxWidgets: 3.2.4 (wchar_t,wx containers)
	Boost: 1.83.0
	OCC: 7.7.1
	Curl: 8.5.0-DEV
	ngspice: 42
	Compiler: Visual C++ 1936 without C++ ABI

Build settings:

Fixed in #491


Groupby apply with as_index=False

Hi, is there any reason why running apply on grouped DataFrame with as_index=False does not return group keys as columns?
I see a great benefit in creating generic apply function with base schema like
def my_func(df: pd.DataFrame): -> ks.DataFrame("value": float):
   return pd.DataFrane({"value": df["x"].value[0] + 1})

That I can apply with different group by keys
df = ks.DataFrame({'A':[ 'a', 'a', 'b'], 'B': [1, 2, 3], 'C': [4, 6, 5]}, columns=['A', 'B', 'C'])

ver1 = df.groupby("A", as_index=False).apply(my_func)
ver2 = df.groupby("B", as_index=False).apply(my_func)

and get A column with output for ver1 and B column for ver2

Hi @kismsu, would you please show a reproducible example to help us understand your question?

It's because of missing type hint support for index. This is a limitation for now. @kismsu you can simply omit the type hints and let it infers properly for now.


export addQueryMerging

fixes #363

Nice, perfect fix!

Just have to wait for tests to pass and then I'll merge and publish. Do you mind adding a change log entry?

done 👍

Thanks!


Expand test coverage with name-filter-fn.

Changes proposed in this PR

Add some unit tests for named-filter-fn == nil as well as non-null.

Why are we making these changes?

We test it == (constantly true), but name-filter-str->name-filter-fn only sets it to a regexp matcher closure or nil.
This exercises the special case nil in the query logic which wouldn't be exercised with the 'constantly true' existing implementation.

Needs rebase


calendar - create secondary google calendar with other civic hacking meetups

http://webapps.stackexchange.com/questions/3628/can-i-publish-a-feed-of-my-meetups-to-appear-on-my-google-calendar

Why?
What are the other Meetups in the first place?

like the maptime meetup, there was a github workshop last week that helped me lots, d3 meetup sometime, hacks/hackers, and things like the myCreek charette and divHack, etc.

I don't believe this is priority either but it would def be a nice to have.

agree

I think the Text that is now on the front page about "Our Events" that @luqmaan added should be moved to the Events page.
The current Events page is kind of lacking with just the Google Calendar so this would be a good addition and placement for that info.

Our Events
Every month Open Austin hosts three events:
Open Gov & Civic Tech Meetup - We invite a speaker from the civic tech community and try cover a broad range of topics. Normally at the Terrazas public library.
Civic Hack Night - We try to invite a non-profit or anybody with an idea for a civic tech project to come pitch their ideas. Then we break out into project-specific groups and work for about two hours. Normally at WeWork on 6th & Congress.
Civic Hack Saturday - Like the Civic Hack Night but on Saturday's and without presentations. This is a comfortable space to come and work on a project for a few hours. Usually at Urban Co-Lab.
In addition, every year we host three larger events. We could probably use another sentence or two here.
Code Across - What is Code Across and why do we do it? Write a sentence or two about it.
Hack For Change - What is Hack For Change and why do we do it? Write a sentence or two about it.
Ship It Weekend - What is Ship It Weekend and why do we do it? Write a sentence or two about it.

closing this issue since the page is live. if there are specific content or design suggestions, lets open new issues


feat: fixed for the issue (#389)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #403 (a58f8d8) into main (8e898f6) will increase coverage by 0.48%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
+ Coverage   71.67%   72.16%   +0.48%
==========================================
  Files         149      144       -5
  Lines        1370     1304      -66
==========================================
- Hits          982      941      -41
+ Misses        388      363      -25

Impacted Files
Coverage Δ

packages/bluesky/lib/src/entities/list_item.dart
100.00% <100.00%> (ø)

packages/bluesky/lib/src/entities/list_items.dart
100.00% <100.00%> (ø)

...ackages/bluesky/lib/src/graphs/graphs_service.dart
100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Traction Sandbox refresh action failure and unplanned trigger

It looks like the GHA that takes care of refreshing the Sandbox instance of traction is triggering every time a PR is merged, which is not the desired behaviour. See: https://github.com/bcgov/trust-over-ip-configurations/actions/runs/6712985673
Additionally, the installation failed on the last run (same link as above).

Hmmmm :thinking:
Could this have something to do with my previous merge? I'm not seeing a lot for logs. Can dig in further if nobody has found anything.

Resolved in https://github.com/bcgov/trust-over-ip-configurations/pull/164


Added rates caching

Similar update like the one I recently made to the nodejs-currency-converter

I just realized some issues with my rate caching solution.

In line 147, I should be returning a promise. You can update line 147 to this:
return new Promise((resolve, _) => {
resolve(this.ratesCache[currencyPair]);
});
For the rates caching to work properly, you might have to export an instance of the CurrencyConverter class rather than the CurrencyConverter class itself. If the CurrencyConverter class is instantiated every time it is needed, the cache will be cleared and the caching will not be useful. Since the CurrencyConverter already supports chaining, you can export an instance of the CurrencyConverter (see below) therefore, the same CurrencyConverter instance is used everywhere in a project and the cache does not get cleared. This change might require some updates to the documentation in the README of the project.
// exporting the currency converter instance will look like this:
let currencyConverter = new CurrencyConverter();
module.exports = currencyConverter;


Production release of Auto-save

Title of ticket:
Description
https://app.zenhub.com/workspaces/foi-flow-607f0ab6ae54b700111dc733/reports/release?release=Z2lkOi8vcmFwdG9yL1JlbGVhc2UvNzc5ODE
Dependencies
Are there any dependencies?
DOD

[x] Finish QA
[x] Tagging

Went to prod last week.


Please invite me to the community

Name
Josh Groban
Additional Context
Hi, Nice to meet everyone.
I would like to be part of the awesome community.

Invitation sent to join the GitHub Organization. Welcome to Infraform 🎉Please check your mail to accept the invitation sent by GitHub! 🤖About usInfraform is a remarkable open-source solution tailored for serverless platforms, aimed at empowering creators to craft their infrastructure solutions. 💻 We're thrilled to welcome you into our vibrant community! ✨ We eagerly anticipate your valuable contributions! 🤓 Don't forget to explore our community on Github and connect with us on LinkedIn 💜 Feel free to spread the word about our community to like-minded individuals interested in development, DevOps, technology, and collaborative contributions. 👉💜👈


(Win10) :LeaderfFile  error

:LeaderfFile with any specific directory (e.g. ., X:\, C:\Program Files\Vim\vim80\, etc.) gives these errors with no LeaderF window or anything:
Error detected while processing function <SNR>38_main[53]..<SNR>38_clean:
line    3:
E108: No such variable: "s:show_range"
Error detected while processing function <SNR>38_main[53]..<SNR>38_clean:
line    9:
E802: Invalid ID: -1 (must be greater than or equal to 1)
Error detected while processing function <SNR>38_main[53]..<SNR>38_clean:
line   11:
E802: Invalid ID: -1 (must be greater than or equal to 1)
>>>
Error detected while processing :
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\manager.py", line 47, in deco
    func(self, *args, **kwargs)
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\manager.py", line 818, in input
    self._search(self._content)
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\manager.py", line 281, in _search
    self.clearSelections()
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\manager.py", line 584, in clearSelections
    lfCmd("call matchdelete(%d)" % i)
vim.error: Vim(call):E803: ID not found: 4

seems related to #91

after disabling traces.vim (because of s:show_range, explained here #91) and all my other plugins, these are now the errors that appear:
 searching ...
Error detected while processing function leaderf#File#startExpl[5]..leaderf#LfPy:
line    1:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\fileExpl.py", line 557, in startExplorer
    super(FileExplManager, self).startExplorer(win_pos, *args, **kwargs)
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\manager.py", line 726, in startExplorer
    content = self._getExplorer().getContent(*args, **kwargs)
  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\fileExpl.py", line 443, in getContent
    lfCmd("silent cd %s" % args[0])
vim.error: Vim(cd):E472: Command failed
Error detected while processing function leaderf#File#startExpl:
line    5:
E171: Missing :endif

First make sure C:\Program Files\Vim\vim80\ exist,
then launch LeaderfFile C:\Program\ Files\Vim\vim80\ , note that the space between Program and Files should be escaped.

It gives these errors with paths that don't have spaces, and even if I correctly escape them

It's weird. On my machine it is OK.
You can just try :cd <directory>, to see if there is an error E472.

I can change directories fine with no errors

What is the version of your vim?
Could you provide a minimal vimrc?

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Oct 31 2017 23:01:47)
MS-Windows 64-bit GUI version with OLE support
Included patches: 1-1241

and a minimal vimrc:
" setup vim-plug
call plug#begin()
    Plug 'Yggdroot/LeaderF' " {{{
    nnoremap <space>- :LeaderfFile <c-r>=fnameescape(expand('%:p:h'))<cr>/<cr>
    nnoremap <space>+ :LeaderfFile<cr>
    nnoremap <space>b :LeaderfBuffer<cr>
    nnoremap <space>r :LeaderfMru<cr>
    nnoremap <space>ff :LeaderfFile<space>
    nnoremap <space>fl :LeaderfLineAll<cr>
    nnoremap <space>fb :LeaderfLine<cr>
    nnoremap <space>ft :LeaderfTag<cr>
    nnoremap <space>fh :LeaderfHelp<cr>
    nnoremap <space>f: :LeaderfHistoryCmd<cr>
    nnoremap <space>f/ :LeaderfHistorySearch<cr>
" initialize vim-plug
call plug#end()

Sorry, I still can not reproduce.

I can not reproduce even with your full vimrc.

It's almost certainly on my end, then. I'll try to look more into it and post results if/when I find them.
Thanks a ton for the help and sorry for my mistake!

  File "C:\Users\aws\AppData\Roaming\vimfiles\plugged\LeaderF\autoload\leaderf\python\leaderf\asyncExecutor.py", line 80, in read
    raise Exception(lfEncode(lfBytes2Str(err)))
Exception: File not found - -NAME^M
Access denied - .^M
File not found - -O^M
File not found - -TYPE^M
File not found - D^M
File not found - -NAME^M
File not found - .SVN^M
File not found - -PRUNE^M
File not found - -O^M
File not found - -TYPE^M
File not found - D^M
File not found - -NAME^M
File not found - .GIT^M
File not found - -PRUNE^M
File not found - -O^M
File not found - -TYPE^M
File not found - D^M
File not found - -NAME^M
File not found - .HG^M
File not found - -PRUNE^M
File not found - -O^M
File not found - -TYPE^M
File not found - F^M
File not found - -PRINT^M
sed: -e expression #1, char 1: unknown command: `''^M

Any ideas based on that? Maybe Windows line endings are somehow mucking things up during the process?

This is the same as issue #87 . Because you are using dos command find.
The sequence of choosing external tool to index the files is rg->ag->find(if sed is also available).
You can install rg to solve the issue.

Hooray! It works now that I put rg in my path.
I have sed from Gow, but I guess it doesn't come with a unixey find..
also, one last question: How do I get git repositories to show up in my file searches?

e.g. I have a vimfiles\plugged folder full of my plugins, yet none of those files are in my results for :LeaderfFile C:\Users\aws\AppData\Roaming\vimfiles

Use rg --files to see the files are listed.

Ah, it was because rg ignores .gitignore files by default. I added let g:Lf_ExternalCommand = 'rg "%s" --files --no-ignore', and that got the desired result

You can follow here  to install the C extension to get better performance.


Allocate namespace for signalling ADLs for use in selectors/IPLD

These are not used in CIDs regularly, so size is not a primary concern. As such, adding to a high byte range space.

So the idea is that these aren't used for codecs, but are magic numbers that may be used... somewhere else, in specific places where we're expecting to talk about ADLs, such as in a field of integer type in a selector extension we're about to propose?

in general i would not expect them to be directly embedded as CIDs, but they are sufficiently cid-adjacent that they should not conflict with other defined multi-codecs, and I believe warrant their own namespace in the multicodec registry in which to be defined and delineated.

Nvm. Apparently we're not using codecs.

this got deprecated in favor strings