update_substrate_template doesn't replace dependency references correctly

As demonstrated by https://github.com/substrate-developer-hub/substrate-parachain-template/pull/149/files and pointed out by https://github.com/substrate-developer-hub/substrate-parachain-template/pull/149#pullrequestreview-1271942422, the update_substrate_template script seems to incorrectly replace branch = with " branch" =. There might be other issues, but this is the obvious one.

Apparently caused by a problem in Diener which was fixed in https://github.com/paritytech/diener/commit/0e35ce70f97cd6baa6aea129ed2edd0ee47304c7. Perhaps the problem will go away if we were to update Diener.


fixed type hint of hrandfield method

hrandfield returns a byte if no count is given
if count is given it returns a list of bytes
if there is no value found, it returns None

ah
sorry, was doing the same thing in another package and forgot


Set Private Key to Environment Variables

Tests currently hardcode the private key for the testnet account. Not only is this bad practice but considering this is an example, it should show developers how to deal with this regularly.
https://github.com/dutterbutter/nft-paymaster-dapp/blob/c9ee98f34d42952c3ae7ee825355981940dfe3ec/zksync/test/main.test.ts#L7
I suggest replacing the above with for example:
const PRIVATE_KEY: any = process.env.PRIVATE_KEY;
if (!PRIVATE_KEY) {
    throw ...
};

and include the private key in the repo secrets that get loaded whenever a GitHub Action runs for example.

Yes I agree, this was bootstrapped with zksync-cli which pulls in the following template: https://github.com/matter-labs/zksync-hardhat-template/blob/main/test/main.test.ts
Please raise this issue there as well.


launch_browser.dart does not support --dartium flag

If you run ./tools/test.py with the --dartium flag, like so:
./tools/test.py --mode=release --compiler=none --runtime=dartium --tasks=1 --dartium=../../dartium-git/src/out/Debug/Chromium.app/Contents/MacOS/Chromium html/js_test
and it fails, it will print something like this:
To retest, run:  /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/bin/macos/dart /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/dart/http_server.dart -p 51496 -c 51497 --build-directory=/Users/justinfagnani/Documents/Projects/dart2-repo/dart/xcodebuild/ReleaseIA32 --runtime=dartium
Command[dartium]: /Users/justinfagnani/Documents/Projects/dart2-repo/dart/tools/testing/bin/macos/dart tools/testing/dart/launch_browser.dart dartium http://<IP_ADDRESS>:51496/root_build/generated_tests/none-dartium/tests_html_js_test/test.html?crossOriginPort=51497
Notice that the Command[dartium] does not include the path to the Dartium binary originally used, nor does launch_browser.dart seem to support a --dartium flag

Dartium will no longer be supported in 2.0.


Update the example app to use the Remix template

With the release of the Remix app template, we're updating our tutorials to start from that template instead.
This PR proposes a rewrite of the example app using the new template, which we can use to update the tutorial. It functions essentially in the same way, by setting up the routes / markup used to make requests to the GraphQL API.

The template has evolved since this, I'm closing the PR but we can reopen it if we still want to update.


solana-zk-token-sdk still has a dependency on zeroize 1.3

Problem
The workspace Cargo.toml has a reference to zeroize set to 1.7:
zeroize = { version = "1.7", default-features = false }
And the solana-zk-token-sdk's Cargo.toml uses a workspace reference to pull in the zeroize dependency:
zeroize = { workspace = true, features = ["zeroize_derive"] }
However, the solana-zk-token-sdk that is published still has the dependency on zeroize set to 1.3 which causes version conflicts when attempting to integrate solana crates into projects with more recent versions of many popular crates.
Reference
https://crates.io/crates/solana-zk-token-sdk/2.0.14/dependencies
Proposed Solution
Publish solana-zk-token-sdk with the zeroize dependency set to the workspace designation (currently 1.7).

This will be done when v2.1 is published, which should be within the next few days. The updated dependency won't be backported to v2.0, per the backport guidelines.


"NixOS Flow" broken image

The following image appears to be broken in the blog post "My NixOS Desktop Flow":

I'll try and fix it, thanks!

Fixed by #224


CB-15877: solrctl does not work on the gateway machines of the DDE template

When creating a data hub using the DDE template, machines in the gateway
instance group did not get the solr-gateway role. As a consequence of this, the
solrctl command did not work from these machines.

Can one of the admins verify this patch?

Sorry, I just wanted to give it a try whether a new PR would trigger the checks and forgot to close it afterwards. All other recent PR-s trigger the checks correctly, only mine doesn't.


VSPIX not supported on ARM64 VS

Adding clarification that ARM64 does not support VSPIX

Docs Build status updates of commit a564436:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/debugger/graphics/visual-studio-graphics-diagnostics.md
:white_check_mark:Succeeded

docs/profiling/gpu-usage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@Mikejo5000,
Can you review the proposed changes? Note: The first changed needs a line break added (apparently) and a period.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Docs Build status updates of commit 5f7026a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/debugger/graphics/visual-studio-graphics-diagnostics.md
:white_check_mark:Succeeded

docs/profiling/gpu-usage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit bcec199:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/debugger/graphics/visual-studio-graphics-diagnostics.md
:white_check_mark:Succeeded

docs/profiling/gpu-usage.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off

Docs Build status updates of commit d61ae11:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/8450/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


IQueryableExtensions contains-filter expansion

Expands the IQueryableExtensions with new IsContainedIn, and IsNotContainedIn criterion conditions for handling List based filtering in a Generic manner, as well as the addition of ObjectExtensions ConvertTo() as a form of a Generic Parse.

Does this mask an error when it shouldn't?  Would it be best to let this fail?  In other words, does allowing it to fail push the responsibility to the caller to validate parameter values before sending them?  What is the risk of letting it fail versus never setting the "typedFilterValue" value?  Could someone be accidentally short-circuit a filter and end up with more data than intended?


Enhancement : Generate report of References updated for Renovator

Required Information

[x] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.5.2
[x] ACS AEM Commons Version: 4.8.6
[x] Reproducible on Latest? Yes

Expected Behavior
Print the references updated with Renovator so the users have a report of pages impacted
See attached snapshot in comments. See the last column "Referred In"
Actual Behavior

There are no columns showing the pages/XF where references are updated.

Steps to Reproduce

Provide a spreadsheet with paths of existing and new location of Assets for Renovator and the report generated doesn't include the updated references. The user would have to download a detailed report to see the pages impacted.

Links
PR : https://github.com/mxp737/acs-aem-commons/commit/c61757141a5cef2780698fd3c035174a721c3254

Let me know if we can close this one out now that the PR is accepted.  Thank you for your contribution! 👍

@badvision  : The issue can be closed. Thank you for the quick review and approval


if manifest read fails, wskdeploy should not read details from hardcoded manifest

wskdeploy fetches the runtime manifest from hardcoded values here should it fail reading from the API host.
https://github.com/apache/incubator-openwhisk-wskdeploy/blob/b9fd4d317888319ddd3fea3ad8458b2b661ec407/utils/runtimes.go#L229
this is startling - instead wskdeploy should fail --- the hardcoded values could be very different from the deployment wrt action default, supported actions, etc... isn't this dangerous?!

Reading hardcoded values can be disabled using --strict flag.


Fix Sign out and then sign in screen does not respond. (database/)

Hi, I find this issue and fix it.
I hope this is useful.

I signed it!

I have finished it.
Glad to help.

Thanks @gengshuo !


make emulator emit its own device tree blob

The ocaml version of the emulator emits its own device tree blob by going via a text file and then calling out to dtc.
TinyEmu has helper functions to write flattened device tree binary data into memory directly here, and they are used below that, we should copy this approach.

done in #49


Add codecov feature to pr_checks.yml

Signed-off-by: Kim, Vinnam<EMAIL_ADDRESS>
Summary

How to test

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@74842de). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #756   +/-   ##
==========================================
  Coverage           ?   84.17%
==========================================
  Files              ?      157
  Lines              ?    21855
  Branches           ?     4779
==========================================
  Hits               ?    18396
  Misses             ?     2371
  Partials           ?     1088

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Change data type names and change endianness to be handled by a codec

There seemed to be consensus to rename data types to more commonly-used names, rather than the NumPy type string-derived names.
There also seemed to be potential agreement to handle endianness via a codec rather than as part of the data type, as long as there is a migration path for zarr v2 data that does not require any chunk re-encoding.

cc @QuLogic (in case you have thoughts here)

I believe all FITS integer values are big-endian, for reference.

LGTM :+1:

Merging based on current approvals.


20220207: Unit comes with a value associated

Describe the issue

As a data wrangler, I would like to ensure that units are always associated with a value.
Test template

Test name: Unit has value associated
Test Description: Ensure that any unit-related field has a value associated with the unit, otherwise throw an error
Cypher query:

MATCH (b)
WITH b, keys(b) as fields
WHERE any(field IN fields WHERE field CONTAINS "unit")
WITH b, [field IN fields WHERE field contains "unit"] as unit_fields, [field IN fields WHERE NOT field contains "unit"] as no_unit_fields
WHERE NOT ANY(u in unit_fields WHERE any(n in no_unit_fields where u contains n))
return b, "Missing unit values", labels(b)

** Acceptance criteria**

[ ] The test has been reviewed
[ ] The test has been implemented into the graph_test_set folder

@ESapenaVentura if you make a PR i will approve  - looks fine to me

I'd like this check to become part of the schema using the keyword dependencies to link together unit and value


SharpThumbnailHandler uses white hinting for alpha transparency

Version of SharpShell used: 2.7.1
Related type(s) of SharpShell-Server: SharpThumbnailHandler
I'm implementing a very simple SVG thumbnail handler (with the help of https://github.com/vvvv/SVG). While the SVG renderer is correctly drawing alpha transparency, thumbnails returned through SharpThumbnailHandler seem to use white hinting to draw alpha transparent pixels.
Please have a look the following sample:

The SVG document is a simple black spiral line.
When rendered against dark background, white artifacts appear in SharpThumbnailHandler.
A (previous diagonal line) test export of the bitmap I return in GetThumbnailImage does not have these artifacts, as you can see in the Windows default PNG preview which also does not create white mess around it.
So apparently it seems like SharpThumbnailHandler does not set up alpha transparency "correctly"; or at least draws it against white color.

Here's my drawing code, nothing spectacular:
protected override Bitmap GetThumbnailImage(uint width)
{
    try
    {
        // Load the SVG document.
        XmlDocument xmlDocument = new XmlDocument();
        xmlDocument.Load(SelectedItemStream);
        SvgDocument svgDocument = SvgDocument.Open(xmlDocument);

        // Calculate the thumbnail size and create the image buffer to return.
        float scale = Math.Min(1, (int)width / svgDocument.Width);

        // Render the image and return it.
        return svgDocument.Draw(
            (int)Math.Round(scale * svgDocument.Width),
            (int)Math.Round(scale * svgDocument.Height));
    }
    catch
    {
        return null;
    }
}

Got it - thanks for sharing the repro steps, will look into it soon!

Testing this with Windows x64 last update and:
<package id="SharpShell" version="2.7.1" targetFramework="net471" />
<package id="Svg" version="2.3.0" targetFramework="net471" />

I am able to reproduce it using the example SharpThumbnailHandler with your replacement of GetThumbnailImage. But it's not at all that bad for me (at least not with my sample SVG files).
My result:

Note: It's only really noticable if you use very big thumbnails (resp. zoom all the way in).

My guess would be, it uses the "selected" background to render because if you select the file it looks better.


Improve Performance by Reducing API Calls to GitHub

Calling the GitHub Pull Request API is not necessary as all the information required is acquirable via the Issue API.
Reduced from 88s to 50s on my pc for uat.

Cool, I think we can look at parallel requests separatly to make further improvements.


code warnings in ezxml.c and nczarr_test/bm_chunks3.c

In current master, I see:
ezxml.c: In function ‘ezxml_parse_fd’:
ezxml.c:669:13: warning: implicit declaration of function ‘read’; did you mean ‘fread’? [-Wimplicit-function-declaration]
  669 |         l = read(fd, m = malloc(st.st_size), st.st_size);
      |             ^~~~
      |             fread
ezxml.c: In function ‘ezxml_parse_file’:
ezxml.c:685:18: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
  685 |     if (fd >= 0) close(fd);
      |                  ^~~~~
      |                  pclose

Also, with --enable-benchmarks:
In file included from bm_utils.h:93,
                 from bm_chunks3.c:22:
bm_chunks3.c: In function ‘main’:
bm_chunks3.c:170:13: warning: implicit declaration of function ‘getoptions’; did you mean ‘bm_getoptions’? [-Wimplicit-function-declaration]
  170 |     NCCHECK(getoptions(&argc,&argv,&bmoptions));
      |             ^~~~~~~~~~
ut_test.h:66:32: note: in definition of macro ‘NCCHECK’
   66 | #define NCCHECK(expr) nccheck((expr),__LINE__)
      |                                ^~~~
bm_chunks3.c:171:13: warning: implicit declaration of function ‘nc4_buildpath’; did you mean ‘bm_buildpath’? [-Wimplicit-function-declaration]
  171 |     NCCHECK(nc4_buildpath(&bmoptions,&path));
      |             ^~~~~~~~~~~~~
ut_test.h:66:32: note: in definition of macro ‘NCCHECK’
   66 | #define NCCHECK(expr) nccheck((expr),__LINE__)
      |                                ^~~~
bm_chunks3.c:174:9: warning: implicit declaration of function ‘reportoptions’; did you mean ‘bm_reportoptions’? [-Wimplicit-function-declaration]
  174 |         reportoptions(&bmoptions);
      |         ^~~~~~~~~~~~~
      |         bm_reportoptions
bm_chunks3.c:175:9: warning: implicit declaration of function ‘reportmetaoptions’; did you mean ‘bm_reportmetaoptions’? [-Wimplicit-function-declaration]
  175 |         reportmetaoptions(&bmoptions.meta);
      |         ^~~~~~~~~~~~~~~~~
      |         bm_reportmetaoptions
bm_chunks3.c:325:5: warning: implicit declaration of function ‘clearoptions’; did you mean ‘bm_clearoptions’? [-Wimplicit-function-declaration]
  325 |     clearoptions(&bmoptions);
      |     ^~~~~~~~~~~~
      |     bm_clearoptions

Please add this issue to milestone 4.8.2.  The Dec. 20 netcdf-c snapshot (main) failed in this way for me on Mac OS 10.15.7 Catalina and Apple clang version 12.0.0.


Adding roles to members using queue()

General Troubleshooting

[x] I have checked for similar issues.
[x] I have updated to the latest JDA version.
[x] I have checked the branches or the maintainers' PRs for upcoming bug fixes.

Bug Report

I tried to add methods to my guild members. It doesn't seem to work (or take a very very long time) to add the roles, when I am using the AuditableRestAction#queue method. I fixed it by using the AuditableRestAction#complete method, but that's not a good fix, as you know...
Expected Behavior

It should add roles in a matter of seconds, and not waiting minutes for it to work.
Code Example or Reproduction Steps

Not working:
guild.addRoleToMember(member, role).queue()
Working:
guild.addRoleToMember(member, role).complete()
Exception or Error

N/A

Please provide actual code snippets, so that we can see what could be the actual issue.
If you have more questions, don't hesitate to join the JDA Discord and ask your questions there for a fast response.

Please provide actual code snippets, so that we can see what could be the actual issue.
If you have more questions, don't hesitate to join the JDA Discord and ask your questions there for a fast response.

What exactly do you need?
I am just adding the roles, and it doesn't work when using the queue method, but it works (same code) with the complete method.

I just said what we need: The code you have.
Just saying "It doesn't work with X but with Y" doesn't help us at all to understand your setup.
We need to know what code you use to see if something there could cause this odd behaviour.

Both of those work for me.

I'm pretty sure the issue is a bug in your code and not JDA. The implementation for complete() just calls queue() and blocks the thread until the success callback is invoked.

I'm pretty sure the issue is a bug in your code and not JDA. The implementation for complete() just calls queue() and blocks the thread until the success callback is invoked.

I will give more details and some code snippets later. I dont think its an issue on my end, as complete() works and with the same code, queue() doesnt.

I dont think its an issue on my end, as complete() works and with the same code, queue() doesnt.

Again, complete just calls queue and blocks the thread. So its not an issue with queue but an issue with your handling of asynchronous operations.

@OmerBenGera It appears this may have the same cause as #1212. Are you calling shutdown()?

The code and logs you're providing make no sense to me. You're telling me the 5 lines here take 8 seconds with complete() and 360 seconds with queue()?
I'm still certain the real issue lies somewhere in your handling with asynchronous operations as per my previous comment. I recommend you use a real debugger and try to make a mcve.

I don't know if the issue is these actual methods, but you can clearly see the issue. Maybe the queue is full, idk - there are many tasks running at the same time, I really don't know.
I know complete() skips the queue, and queue() doesn't, which leads me to think it has to do with that. What do you think?

but you can clearly see the issue

Not really.

I know complete() skips the queue

Nothing skips the queue. The raw complete() will simply append it to the queue and wait by blocking the thread.
If you do a lot of requests to the same endpoint, yes you will definitely be rate limited by discord. All rate limit backoff is logged on debug level in the RateLimiter. The endpoint for adding roles to a member has a 10/10s rate limit per guild.

but you can clearly see the issue

Not really.

I know complete() skips the queue

Nothing skips the queue. The raw complete() will simply append it to the queue and wait by blocking the thread.
If you do a lot of requests to the same endpoint, yes you will definitely be rate limited by discord. All rate limit backoff is logged on debug level in the RateLimiter. The endpoint for adding roles to a member has a 10/10s rate limit per guild.

You can't see that it takes 360 seconds with queue and only 8 seconds with complete?
I showed code snippets and also debug messages.
What can I do then so you can understand the issue and the cause?

You can't see that it takes 360 seconds with queue and only 8 seconds with complete?
I showed code snippets and also debug messages.
What can I do then so you can understand the issue and the cause?

Do what Minn already suggested you to do:

I recommend you use a real debugger and try to make a mcve.

You can't see that it takes 360 seconds with queue and only 8 seconds with complete?

I don't believe queue will take 360 seconds to run. If that were the case, no bot written in JDA would be able to work. Additionally, I tested it myself and it took less than a second to run. I believe that the story here is incomplete, which is why I told you to use a real debugger (or profiler) and make a simple mcve.

You can't see that it takes 360 seconds with queue and only 8 seconds with complete?

I don't believe queue will take 360 seconds to run. If that were the case, no bot written in JDA would be able to work. Additionally, I tested it myself and it took less than a second to run. I believe that the story here is incomplete, which is why I told you to use a real debugger (or profiler) and make a simple mcve.

I made a new bot, with that code on startup:
            for(Role role : guild.getRoles()){
                try {
                    guild.addRoleToMember(member, role).queue(v -> {
                        System.out.println("Took " + (System.currentTimeMillis() - startTime));
                    });
                }catch(Exception ex){
                    continue;
                }

                counter++;

                if(counter == 10)
                    break;
            }

It doesn't seem to occur. Anything else I can do so you guys can better understand the issue?

You can't see that it takes 360 seconds with queue and only 8 seconds with complete?

I don't believe queue will take 360 seconds to run. If that were the case, no bot written in JDA would be able to work. Additionally, I tested it myself and it took less than a second to run. I believe that the story here is incomplete, which is why I told you to use a real debugger (or profiler) and make a simple mcve.

I can't use an actual debugger on a big bot, we won't be able to understand anything.
That's the only method so far that causes issues.
And if you believe it or not, it doesn't matter - that's a fact, it happens with the queue().

And if you believe it or not, it doesn't matter - that's a fact, it happens with the queue(), and complete() fixes iit.

Well... they are the people you are supposedly asking for a fix.
You can at least enable debug logs and see if you hit a lot of ratelimits or something similar.

It doesn't seem to occur. Anything else I can do so you guys can better understand the issue?

If it doesn't happen in a mcve then it must be some issue in your code. Try to isolate the issue by using a debugger. I'd say it's safe to say the issue is not with queue/complete but rather with something in your code, as I've alluded to since the beginning of this thread.
I recommend joining our discord server and figuring out the problem there. If you can find a real bug in JDA that is reproducible with a mcve then feel free to open a new issue.

I can't use an actual debugger on a big bot, we won't be able to understand anything.
That's the only method so far that causes issues.
And if you believe it or not, it doesn't matter - that's a fact, it happens with the queue(), and complete() fixes iit.

It was mentioned before that complete() does essentially nothing more than queue the request and blocking the threat until the RestAction was performed.
We asked 3 times already for you to do a mcve and from what I can tell you didn't.
And your reason to not use a debugger on a big bot is kind of crap as most if not all IDEs have a debugger you can use.

I've also tested it with submit - and did it once with the queue parameter on true, and another time with false. When the parameter is true, it takes ages to respond. When the parameter is on false, it takes literally no time. It's your choice if you want to fix it or not, I found the solution :)

Working code, on the same bot that didn't work before:
    public void addRolesToMember(Member member, Role... roles){
        Arrays.stream(roles).forEach(role -> guild.addRoleToMember(member, role).submit(false));
    }

For the sake of completeness, there is a method which adds multiple roles to a member at once which is better than requesting an addition each. Guild#modifyMemberRoles is what you can use for that. Else I can just repeat what the others have said.

It's your choice if you want to fix it or not

I can't fix something that I can't reproduce and (probably) isn't actually broken.

It's your choice if you want to fix it or not

I can't fix something that I can't reproduce and (probably) isn't actually broken.

It was proven to be broken, as same code but with some other parameters work.

For the sake of completeness, there is a method which adds multiple roles to a member at once which is better than requesting an addition each. Guild#modifyMemberRoles is what you can use for that. Else I can just repeat what the others have said.

Does this method add roles, or makes the roles of a member to be the ones that were provided?

Does this method add roles, or makes the roles of a member to be the ones that were provided?
The documentation states that, look it up.

It was proven to be broken, as same code but with some other parameters work.

That doesn't prove anything, because the code is not isolated (which is what an mcve would give you). Asynchronous operations can be a bigger impact than synchronous operations on non-isolated code. If you want me to fix something you have to give me something to reproduce the problem. submit(false) and complete(false) will simply throw an exception if you are getting rate limited, causing it to never complete.


Remove symbol overloads of Colorize color methods for symbol auto-casting

Colorize methods receiving a color (#fore and #back) have overloads receiving a Symbol parameter which is manually mapped to values of ColorANSI. This implementation predates the symbol auto-casting of enum values.
This patch removes the overloads with Symbol typed parameters which leaves the overloads receiving a Color parameter. This type is a union including the enum ColorANSI which enables symbol auto-casting for color values.
The problem is: it's a breaking change. If the API is used with symbols that are not directly created from literals, there will be a compile time error. This is good and intended because it adds type safety (you can know at compile time whether a value is valid). But it's still a breaking change that destroys valid use cases which would require changes to user code (as demonstrated by the changes in samples/2048.cr and  src/spec/dsl.cr for example). So I believe we can't merge it just like that.
The only option is to leave the removed overloads in with a deprecation notice. That's not ideal though because the deprecation warning even triggers for usages that are compatible with the auto-casting method. But the symbol overload takes precedence over auto-casting. The only way to deactivate deprecation warnings is using a named argument: fore(fore: :green).
Are there any other ideas? We could use a feature flag but I think would be silly for such a minor thing.
This patch has been extracted from #7690.

This is observed in #11020 and also in:
https://github.com/crystal-lang/crystal/blob/9e52dd6a4078b4f637e25f685bd47faf63c74273/src/time/location.cr#L147-L156
I don't know any way other than as part of some other flag disallowing Symbol-typed variables altogether.


Clarify default condition

I'm assuming the default condition of a step is "succeeded()". Is that correct? This should be added to this page as it's a good starting point when thinking about writing custom conditions. For example, what would happen if the condition is only eq(variables['Build.SourceBranch'], 'refs/heads/master')? Would this step run whether the preceeding tasks have failed or succeeded?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f151218-9a11-0078-e038-f96198a76143
Version Independent ID: 09c4d032-62f3-d97c-79d7-6fbfd89910e9
Content: Conditional tasks - Azure Pipelines
Content Source: docs/pipelines/process/conditions.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

+1 Is succeded() the default?

I'd like to know this as well, it's not clear from the documentation. Can anyone on the AzDo team clarify?


Ghcid ignoring /dev/tty

I'm running into a weird situation where ghcid hangs while running ghci directly works: https://github.com/alexfmpe/reproduce-bugs/blob/ghcid-ssh-passphrase/Main.hs
cabal new-run or cabal new-repl both show me the prompt and then continue execution after I input the ssh passphrase, whereas ghcid seems to just hang.
I'm running into this on Linux, NixOS where it looks like the passphrase is read/written via /dev/tty. I'm guessing ghcid is just not interacting with it?

Ghcid spawns Ghci and takes control of its stdin. As a result, I'm not surprised that ghcid hangs - the underlying ghci will hang until it gets the pass phrase, and there's just no way for the pass phrase to get in. Are you running Ghcid with --test? Why does cabal new-repl ask you for a prompt?

Are you running Ghcid with --test?
Indeed

Why does cabal new-repl ask you for a prompt?
I'm cloning via ssh: "git" ["clone", "git@github.com:ndmitchell/ghcid.git"]

If I unlock the passphrase beforehand, ssh-agent will remember it and I won't get a prompt.

The --test can't get access to stdin, and if it tries, it will steal the commands that Ghcid wants to send to Ghci. I don't see many ways around this, so I've documented it in the README.

Isn't the ssh prompt coming from /dev/tty ?
I still get the prompt when doing
cabal new-run > /dev/null 2> /dev/null < /dev/null

I have no idea - that's not what I would have expected. I'm on Windows, so if you can tell me how you think it should be working, happy to adapt.


Upgrading fluxctl is painful

I've heard this from several members of the weave team.
Because you have to pull in the dependencies to build fluxctl, which includes k8s.
We could potentially:

use kubernetes go-client
Pre-build and cross-compile binaries into github releases (or elsewhere). We could have circle build them, and push when on master.
Split fluxctl into a separate (smaller) repo.

I thought we already did publish binaries for releases.

This is less about releases, and more about latest, for internal users.

Ah ok. Github releases are probably not the best place for that. Unless we have some sort of "current snapshot" release that we update/re-create continuously.

We can have CircleCI put the most recent binaries somewhere.
Most of the time it's not necessary to have the absolute latest, even for internal use; downloading from github is fine, until the API version changes. Which we should avoid doing too much.

fluxctl binaries are uploaded to github releases now. As mentioned, you don't in general have to have the absolute latest.


Dynamically create child_process args.

I would like one of my argument values to be dynamically created right before the child_process is spawned. Specifically my use case is to pass a a unique port number to each child_process --inspect=AVAILABLE_PORT.
I have been reviewing the src, and it looks as though this isn't possible. It looks like the args are hard coded in a cached settings.json file... Is this correct? Do you see any possible path forward to support the requested functionality?

Continuing to review the src / my requirements, and I believe I could accomplish what I need by forking spawn-wrap and making modifications directly in the shim. I really hate to take that path. Wondering if instead some sort of hooks interface could be implemented?
I would like to be able to execute code before the child process is spawned, and after the process has exited
I'd be willing to take a stab at a PR if I could

Can you sketch out an example program that would use your proposed API surface, and explain what's going on?  It's a bit challenging to follow the description, and I'd want to make sure we get it right if we're going to muck about in there.
It sounds like you want to provide a little node program/module that defines the added args in the shim, rather than putting them in a json config file.  Why not just write a little node program that does this, and then calls runMain()?  Then the config is static, but points at a program that does whatever.
// set-port.js
process.env.PORT = getAvailablePort()
// could just as easily do process.argv.push('--inspect=PORT')
require('spawn-wrap').runMain()

// wrapper.js
const sw = require('spawn-wrap')
const setPortModule = require.resolve('./set-port.js')
sw([setPortModule])

// now spawnning 'node foo.js --bar' will instead do `node set-port.js foo.js --bar`,
// and the runMain in set-port.js will re-load the node environment with the changed
// PORT environ as if `PORT=12345 node foo.js --bar` was run.

doStuffThatSpawnsChildProcs()

Oh, is the issue that you need to pass the arg as a node execArgs, before the main file?  Hm.  That's trickier.
It wouldn't be too hard to specify a module that exports an array for the args to use, or something.  It'd have to point at a file, not a stringified function, because otherwise any context would be lost.

We are encountering the same issue (for the same use case) in c8.
Thinking about it, I think that the most reliable solution would be to not use wrapper modules but handle the creation of Node subprocesses with an event emitter in the top process.
const ee = spawnWrap.spawn(file, args, opt);
ee.on("spawn", onSpawn);

// Triggered when a Node subprocess is about to be spawned, anywhere in the process subtree.
function onSpawn(spawnEvent) {
  // You can read the arguments and env of the subprocess
  console.log(spawnEvent.args);
  console.log(spawnEvent.env);
  // These fields are mutable:
  spawnEvent.args.unshift("--inspect=0");
  spawnEvent.env.DEBUG = "1";
  // When you are ready, you can start the real process (equivalent to `runMain`):
  const childProc = spawnEvent.spawn(); // or .spawnSync
  // It uses the parameters currently defined in `args` and `env`
}

Ultimately, the nyc or c8 wrappers using spawn-wrap currently do not need to be executed inside the spawned process: they can migrate to an event handler at the top process. This would naturally enable dynamic args/env configuration, and alleviate my concerns about patching the global module and messing with concurrent tasks (#73).
This kind of architecture would also solve bcoe/c8#20: when executing the wrapper and original main in the same process, the original main can prevent the completion of the wrapper. Having the handler in the top process would solve this thanks to process isolation. (the original main would have to detach itself and nuke its ancestors chain...)

I implemented a way to intercept spawn calls and dynamically replace the arguments.
Still WIP, but you can check this commit. Here is a usage example:
spawnWrap
  .observeSpawn(process.execPath, [NESTED_SYNC])
  .subscribe((ev) => {
    console.log('Intercepted a Node process spawn!')
    console.log(ev.args)
    ev.voidSpawn([...ev.args, 'extra'])
  })

This is similar to childProcess.spawn(process.execPath, [NESTED_SYNC]) but instead of returning a ChildProcess, it returns an observable for spawn events. The event contains the original arguments in ev.args. You can then read them and build a new array of arguments and pass it to ev.voidSpawn.
voidSpawn is named this way because it spawns the process with the new args, but does not return anything. This process may be deep in the tree so you don't have direct access to it and cannot read its stdout/stderr from the root process. I intend to add a proxySpawn method to proxy the stdout/stderr.
This should allow to inject --inspect=0 args and then read the stderr.


How to set up to run from a console application?

I want to create a Fun.Build app that can be launched simply with dotnet run. I can't figure out how to create a "default" pipeline that will be run automatically. If I don't use runIfOnlySpecified, firstly I get a warning (about not assigning the PipelineContext to a symbol - fair enough) and secondly Fun.Build doesn't seem to pick up that pipeline.

I had the same question.  So, to help future travellers on the Fun.Build path, the answer is to remove runIfOnlySpecified from the end of the pipeline and add runImmediate.  🚀
pipeline "Build Something" {
    description "Building Something"

    stage "Do something" {
        run "something"
    }

    // runIfOnlySpecified
    runImmediate
}


(doc) Translation: BKM -> DCM

Description
Changed BKM to DCM. The German acronym BKM for
Bedarf- und Kapazitaets-Management was still used
as acronym for Demand and Capacity Management in
the README. Changed one instance.
Pre-review checks

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

LGTM


update router-prefetcher/src/index.js getInitialData() matchPath option

fix the issue that exact flag is not being considered and multiple component.getInitialData() might be called

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #145   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          67     68    +1
  Branches       13     13
=====================================
+ Hits           67     68    +1

Impacted Files
Coverage Δ

<EMAIL_ADDRESS>100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fdff1...cae1fcf. Read the comment docs.

thanks for the PR, will review this

Released on v4.2.1 🎉


suggestion: add ncnn release version

how about adding a prebuilt libncnn.a to the project ?

ok

BTW, hardware platform should be described in the README.md,  our test result is 20fps on MI note2 (qcom 821).
An prebuilt apk file could help us to exclude building problem.

Thank you for your suggestion. This repo use original MTCNN as our detection and tracking model.  We will release modified version mtcnn with faster inference speed. BTW, how about the speed on your device with original face detection MTCNN  model.


log.error() will throw following exception

Hi,
I just start to use simple-node-logger.  When I use "log.error()", I will get this exception.  Do you know what I have done incorrectly?  It runs ok with log.debug or log.info, etc 😄
Would you point me right direction?  Thanks!
=============================================
events.js:188
throw err;
^
Error: Unhandled "error" event. ([object Object])
at process.emit (events.js:186:19)
at D:\DEV\nodejs_projects\SystemMonitors\node_modules\simple-node-logger\lib\Logger.js:46:25
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)

Hi,
I'm experiencing the same. Just downloaded the tool and tried to use it using the simplest example (didn't even log anything, just required and created it):
// create a stdout console logger
const log = require('simple-node-logger').createSimpleLogger();

and I'm getting this:
[1] module.js:538
[1]     throw err;
[1]     ^
[1]
[1] Error: Cannot find module 'simple-node-logger'
[1]     at Function.Module._resolveFilename (module.js:536:15)
[1]     at Function.Module._load (module.js:466:25)
[1]     at Module.require (module.js:579:17)
[1]     at require (internal/module.js:11:18)
[1]     at Object.<anonymous> (/Users/sgivony/dev/nodeapp3/server/routes/index.js:9:13)
[1]     at Module._compile (module.js:635:30)
[1]     at Object.Module._extensions..js (module.js:646:10)
[1]     at Module.load (module.js:554:32)
[1]     at tryModuleLoad (module.js:497:12)
[1]     at Function.Module._load (module.js:489:3)
[1] [nodemon] app crashed - waiting for file changes before starting...

Node js version is v8.9.3
Thanks

Im getting the same error . My node version is 8.9.4

I'm not able to reproduce so can you send me a snippet of code that breaks?

Same for me on node 8.11.1:
const logger = require('simple-node-logger').createRollingFileLogger({
    errorEventName: 'error',
    logDirectory: 'app/logs',
    fileNamePattern: 'app-<DATE>.log',
    dateFormat:'YYYY-MM-DD'
});

logger.error("This throws exception");

FYI
I am having the problem on Ubuntu 18.04 / Node v8.10.0
Thanks for the fix

There is not much activity on the sources.
Anyway I needed syslog function and auto remove (old) logfiles. For now if you remove old log when the app is running, it will crash. If you are interested to test, I made a really simple package to manage the log files. Give it a try and send me back if something is missing for you.
https://www.npmjs.com/package/sw-node-logger

This solves the problem but it no make sense because String is not a possible output for typeof().
Putting
if (level === 'error' && typeof(errorEventName) === String) {

is exactly the same as putting:
if (false) {

I am on Ubuntu 18.10 with Node 8.11.4 and log.error() throws also this exception.

because this line: "errorEventName:'error' " - throw error in node.
remove this line from your "simple-node-looger" config object and the error will not show anymore.

@benivalotker I know this is almost a year later, but this is the fix that worked for me. Thank you! I was having this issue using log.error() after switching from createSimpleFileLogger() to createRollingFileLogger().

Fixed it!
const logger = require('simple-node-logger').createRollingFileLogger({
    logDirectory: 'app/logs',
    fileNamePattern: 'app-<DATE>.log',
    dateFormat:'YYYY-MM-DD'
});

logger.log("error", "This throws exception");

The problem is still not fixed as I see:
events.js:305
    throw err; // Unhandled 'error' event
    ^

Error [ERR_UNHANDLED_ERROR]: Unhandled error. ({
  ts:<PHONE_NUMBER>792,
  pid: 27492,
  level: 'error',
  msg: [ 'My message' ]
})
    at process.emit (events.js:303:17)
    at process.EventEmitter.emit (domain.js:483:12)
    at /home/andrew/project/node-app/node_modules/simple-node-logger/lib/Logger.js:46:25
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 'ERR_UNHANDLED_ERROR',
  context: {
    ts:<PHONE_NUMBER>792,
    pid: 27492,
    level: 'error',
    msg: [ 'My message' ]
  }
}

It disappears if I remove this line from options errorEventName: 'error',, but this looks like it's a bug.

After lots of struggle, finally, I simply followed the examples and got it working.

const opts = {
domain:'Domain-A',
logDirectory: __dirname + '../../../logfiles',
fileNamePattern: 'hourly-test-.log',
dateFormat:'YYYY.MM.DD-HH'
};

const log = require('simple-node-logger').createRollingFileLogger( opts );

The same error here:

Ubuntu 20.04.4
Node 16.14.0
Simple Node Logger 21.8.12

What's the meaning of the code guarded by conditions? Based on previous comments and my case It looks like lines 45-47 could be removed completely...

Running into the same bug, couldn't figure out for the life of me where the exception was coming from, until I replaced ".error()" with ".info()" and voila, the exception disappeared. The exception I get is identical to the one @awps posted. What's more baffling is that there are other sections of the program where .error() works just fine.
I'm running node v16.9.1 on Ubuntu 22.04.
Since this program has a lot of async functions in it, I'm thinking maybe the problem stems from something related to async? I don't know really. I haven't been able to produce a minimal example of the bug nor can I show you the real source code since it's proprietary.


Augmented Random Search (ARS)

Description
closes #41
WIP pull request for ARS. Still some work to be done, but ready for some feedback before moving forward.
Original paper: https://arxiv.org/abs/1803.07055
A few questions that I would like feedback on

I don't plan to support CNN policies for ARS. It is certainly possibly to make ARS support them, but not really what ARS was meant for. Do you think that is alright for now?
I only support Box spaces for action and observation, the only other one that I think makes sense to add is dict observations, which I will probably add. But if other spaces should be included let me know.
I validate user hyper-parameters when learn is called, and will automatically adjust them if n_delta is not a multiple of n_workers. I could support the case where this condition is not met but it will considerably complicate the code to support a use case that doesn't really provide a benefit and makes the training slower.

Critical feedback on the code quality is definitely welcome, I'm not super happy with the code right now, it seems more complicated than it needs to be, but I think its what makes the most sense for sb3 vec envs. Also, I put a lot of time trying and tried several approaches to make ARS fast with large env# subprocvecenvs but ultimately I find it's considerably faster to run single threaded (1 env dummyvec) and run multiple seeds in parallel.   Perhaps in the future I can make an MPI version along with PPO
Context

[x] I have raised this issue to propose this change (required)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)

Checklist:

[x] I've read the CONTRIBUTION guide (required)
[x] The functionality/performance matches that of the source (required for new training algorithms or training-related features).
[x] I have updated the tests accordingly (required for a bug fix or a new feature).
[x] I have included an example of using the feature (required for new features).
[x] I have included baseline results (required for new training algorithms or training-related features).
[x] I have updated the documentation accordingly.
[ ] I have updated the changelog accordingly (required).
[x] I have reformatted the code using make format (required)
[x] I have checked the codestyle using make check-codestyle and make lint (required)
[x] I have ensured make pytest and make type both pass. (required)

Baseline Reward Curves
The original paper uses v1 versions of the Mujoco envs. getting back to the old V1 envs will require an ancient version of gym and mujoco_py, which IIRC have breaking changes and are not compatible with sb3. But I did train on v2 using hyper params from original paper, using my fork of zoo. Each environment trained with 8 random seeds. Results are marginally worse than the paper, but seem fine to me given the environment version difference and the fact that only 3 seeds are presented for the optimized params in the paper. However If you'd like it should be possible to compare the papers original implementation on the newer envs.
I can also train on v2 for Walker, Ant, and Humanoid, they just take a bit longer, and I'm not sure what the differences between v1 and v2 are there. However perhaps instead it might make sense to ignore Mujoco and to run optuna on the bullet envs and box2d before merging, since I want to do this in any case. I have several workstations to put to this task, but it will still take quite some time.

I don't plan to support CNN policies for ARS. It is certainly possibly to make ARS support them, but not really what ARS was meant for. Do you think that is alright for now?

Yup this is alright. Original paper did not have CNN policies, and I think it would require some more tweaking to get them working in reasonable time.

I only support Box spaces for action and observation, the only other one that I think makes sense to add is dict observations, which I will probably add. But if other spaces should be included let me know.

This is alright for now, too. Anything beyond the original implementation is "nice to have but not necessary". I would recommend using your energy trying to match the original results as closely as humanly possible, rather than adding new things on top :)

I validate user hyper-parameters when learn is called, and will automatically adjust them if n_delta is not a multiple of n_workers. I could support the case where this condition is not met but it will considerably complicate the code to support a use case that doesn't really provide a benefit and makes the training slower.

Sounds ok as it is, as long there is a warning message about this (ps: have not checked the code yet).

Results are marginally worse than the paper, but seem fine to me given the environment version difference and the fact that only 3 seeds are presented for the optimized params in the paper. However If you'd like it should be possible to compare the papers original implementation on the newer envs.

That'd be nice. A simple table of the final agent performances side-by-side (with the variances included) would be the best case. We can then determine if it is close enough or something needs tweaking. Again, repeating experiments on the environments original paper used is enough (or on a subset of them).

I won't have time (not energy) before next week to a full review, but just a quick remark:

I only support Box spaces for action and observation

I would disagree with that as adding Discrete support should be fairly easy, see https://github.com/osigaud/stable-baselines3/blob/64baf2125dec791c20c41f4b39ed1dc2ad914010/stable_baselines3/cem/policies.py#L60
Also, you are not squashing the output for continuous actions (which means that they will be clipped automatically instead), is there a reason? (btw, if you do, you need to update call to parent class)
I saw that you overloaded load to default to cpu?
Why is that? And can't you do everything with torch? (removing the need of numpy)
and as overall remarks, same I did for TRPO, please use meaningful names and avoid mathematical notation when possible.

Last remark, I know you are trying to have an efficient implementation by using n_envs and and the candidates in parallel,
but I think it would be clearer (and less prone to errors) to use evaluate_policy as in the CEM implementation: https://github.com/osigaud/stable-baselines3/blob/64baf2125dec791c20c41f4b39ed1dc2ad914010/stable_baselines3/cem/cem.py#L156

I would disagree with that as adding Discrete support should be fairly easy, see https://github.com/osigaud/stable-baselines3/blob/64baf2125dec791c20c41f4b39ed1dc2ad914010/stable_baselines3/cem/policies.py#L60

Will do

Also, you are not squashing the output for continuous actions (which means that they will be clipped automatically instead), is there a reason? (btw, if you do, you need to update call to parent class)

No good reason, I think I was changing this while debugging performance and never changed it back. The original paper does not squash though, and I believe it may have a small effect on the learning performance. I can check if this is true.

I saw that you overloaded load to default to cpu?
Why is that?

This was changed to pass some of the existing tests.I think ARS should default to CPU because it prefers linear policies or small MLPs. So when one creates a policy object it will default to CPU, but when loading will default to "auto" which searches for a CUDA device, this causes a test to fail and I think is not what the user wants. Now that I think about it though I might only need this for the policy not for the agent?

And can't you do everything with torch? (removing the need of numpy)

with the approach I've landed on I certainly can.

I know you are trying to have an efficient implementation by using n_envs and and the candidates in parallel,
but I think it would be clearer (and less prone to errors) to use evaluate_policy as in the CEM implementation.

Yes after going through the trouble of making a parallel version I sort of a agree, it won't take long to make the simple version and profile it to see how much performance that leaves on the table.

That'd be nice. A simple table of the final agent performances side-by-side (with the variances included) would be the best case. We can then determine if it is close enough or something needs tweaking. Again, repeating experiments on the environments original paper used is enough (or on a subset of them).

Ok, I'll make the changes @araffin already suggested, and then rerun my own along with the reference on the v2 Mujoco envs.

Ok, this is finally ready for review, no rush from my end though. Results actually do match the original paper now, I think this can be attributed to:

Removing the bias term on the output of the linear policies, which helped the swimmer avoid local minima.
Realizing there was a default max_steps parameter in zoos all_plots.py script (notice in the original plots all had 2e6 time-steps).

I am still running the slower environments, they look like they are matching performance but I will update when they finish.
I did wind up going with the simpler, essentially single threaded approach using evaluate_policy, it's can't make use of vectorized envs for speedup, but its cleaner, and for the most part one wants to be training on many seeds / params in parallel anyway, so you can still use your whole processor if you want.

Original results:

@sgillen could you have a look at what I did? (I added async evaluation and sync of the normalization, so I can reach 10 000 FPS when training on mujoco =))
I could reproduce your results in the zoo, so what's missing is some polishing (adding docstrings, help is welcomed ;)) and adding some pre-trained models in the zoo (I'll do that).

Cool! This looks good to me, glad you found a way to make things much faster. I can add some polish/docstrings early next week.
The one thing that sticks out to me now is the device argument, since the implementation is CPU only now should we just remove that entirely? or do you want to keep it for compatibility? When running on my local machine I see four of the pytests failing right now, two are from TRPO, and two are from ARS not respecting the device argument.

I can add some polish/docstrings early next week.

perfect =)

since the implementation is CPU only now should we just remove that entirely? or do you want to keep it for compatibility?

I want to keep it for API consistency and or I plan to make it compatible with GPU at some point (even tough CPU will be the default device).

When running on my local machine I see four of the pytests failing right now, two are from TRPO, and two are from ARS not respecting the device argument.

oh, because of the GPU? (I think this is the case for ARS loading at least)
Let me try out, otherwise please open issue with the associated error and tracebacks ;)

Ok, made some minor changes to the doc strings, and all my local tests are passing now too. Let me know if there is anything else I can do.

Ok, made some minor changes to the doc strings, and all my local tests are passing now too. Let me know if there is anything else I can do.

thanks =)
there are some doctrings missing in the ars implementation, for instance for the do_one_update()

thanks =) there are some doctrings missing in the ars implementation, for instance for the do_one_update()

Thanks for taking care of that, I was going from the TQC implementation in terms of what needs a doc string or not.


1.Sloved Import failed Error  2. Isn't switch button enable？

Section1.To Slove Import failed Error,
step-1: Open this folder:
custom_nodes\ComfyUI_StreamDiffusion，

step-2: type CMD in the address , enter.
step-3: in CMD, type it.
 ..\..\..\python_embeded\python.exe -s -m pip install diffusers==0.25.0

enter.
step-4: Restart ComfyUI.
Section2. Isn't switch buttion enable？

This Warning is confusing.

The warning message is about the scheduler, the attribute will work when the scheduler has the attribute. You can read more from https://huggingface.co/docs/diffusers/v0.9.0/en/api/schedulers.


Use lattest version of library

Use the lattest version of the google-api-client library

Great idea! :-) Thanks!


Fallback to node internal IP if external IP is not set

Ref. this comment: https://github.com/kubernetes/kubernetes/issues/42125#issuecomment-320137328
Right now kube-keepalived does not work if using a cloud provider as the external IP field cannot be set.
I'm using my own cloud provider (https://github.com/munnerz/keepalived-cloud-provider) that automatically configures kube-keepalived-vip for service LoadBalancer support. Without this change, it will not work with any version of Kubernetes that doesn't use the old NodeLegacyHostIP.

This change is

Built image of this PR: quay.io/munnerz/kube-keepalived-vip:0.10
Tests appear to be failing due to service-loadbalancer tests failing. Not sure how best to resolve other than a rebase once it's fixed in master :)

@munnerz I think we both fixed this in slightly different ways.  I have PR #2705 which just removes the NodeLegacyHostIP comparison, since that is now deprecated and removed.  I've also got a PR up to fix the CI failures at #2707

Ah sorry - I didn't see your fix! Glad somebody else is onto it...
I'm not really sure which approach is best - I just didn't want to change existing behaviour, as some users on older clusters may still depend on this field?
Either way, thanks and happy to close this as a dupe!

Fair point about older clusters.  I'm ok either way.

@munnerz Are you still working on this patch?

@cmluciano
Since https://github.com/kubernetes/contrib/pull/2705 has been merged I think we can close this instead.
I'm assuming we don't want to support older clusters that set NodeLegacyHostIP any more. If we do, I'm happy to rebase this PR.

Sure thing, feel free to close

/close


Add tern migrator

I heard about this project at gophercon, and I would like to try it out. The project I want to use it for uses https://github.com/jackc/tern for migrations. Would you consider a PR implementing a tern migrator?

Hi Will, thanks for asking before getting started. Yes, I would happily accept a PR contributing a tern migrator, and I can take on any maintenance/updating work necessary after the initial contribution.
I haven't used Tern before but based on their readme docs it should be fairly straightforward to call it as a library:

All the actual functionality of tern is in the github.com/jackc/tern/v2/migrate library. If you need to embed migrations into your own application this library can help. If you don't need the full functionality of tern, then a migration generator script as described below may be a easier way of embedding simple migrations.

I would generally recommend/prefer this approach, but if need be, you can always fall back to calling the tern cli tool similar to how the atlasmigrator does it.

Great. I already have an internal tool that is pretty similar to pgtestdb. I should be able to port over the migrator pretty easily.

Awesome. I'll do my best to review and merge any submission in a timely manner, but heads up that this is a somewhat busy time of the year for me. Thanks again for being interested in contributing. Please let me know if you have any questions or suggestions for improvement, and apologies in advance for anything confusing you run into.


chore(main): release 2.35.4

:robot: I have created a release beep boop
2.35.4 (2024-08-09)
Bug Fixes

EMS-3633: data migration - xlsx - eligibility questions (#2932) (f80ac41)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v2.35.4
:sunflower:


Cassandra_stress - Exception occurred while calling RunTestOnLoader

I ran some tests successfully (ping and cassandra_cassandra_ycsb) but when trying to run cassandra_stress with default configuration, I get the following error:
2019-12-06 13:42:23,777 0cddc950 MainThread cassandra_stress(1/1) background_tasks.py:545 ERROR    Exception occurred while calling RunTestOnLoader(<IP_ADDRESS>, 0, 1, [u'<IP_ADDRESS>', u'<IP_ADDRESS>', u'<IP_ADDRESS>'], write, insert=1, 1.0, None, None): Traceback (most recent call last):   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/background_tasks.py", line 255, in Run     self.return_value = self.target(*self.args, **self.kwargs)   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_benchmarks/cassandra_stress_benchmark.py", line 404, in RunTestOnLoader     threads=FLAGS.num_cassandra_stress_threads))   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_virtual_machine.py", line 281, in RobustRemoteCommand     return _WaitForCommand()   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_virtual_machine.py", line 278, in _WaitForCommand     ignore_failure=ignore_failure)   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_virtual_machine.py", line 724, in RemoteCommand     return self.RemoteCommandWithReturnCode(*args, **kwargs)[:2]   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_virtual_machine.py", line 740, in RemoteCommandWithReturnCode     return self.RemoteHostCommandWithReturnCode(*args, **kwargs)   File "/home/factory/PerfKitBenchmarker/perfkitbenchmarker/linux_virtual_machine.py", line 812, in RemoteHostCommandWithReturnCode     raise errors.VirtualMachine.RemoteCommandError(error_text) RemoteCommandError: Got non-zero return code (1) executing python /tmp/pkb/wait_for_command.py --status /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.status --stdout /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stdout --stderr /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stderr --delete Full command: ssh -A -p 22<EMAIL_ADDRESS>-2 -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -o PreferredAuthentications=publickey -o PasswordAuthentication=no -o ConnectTimeout=5 -o GSSAPIAuthentication=no -o ServerAliveInterval=30 -o ServerAliveCountMax=10 -i /tmp/perfkitbenchmarker/runs/0cddc950/perfkitbenchmarker_keyfile -o ControlPath="/tmp/perfkitbenchmarker/runs/0cddc950/ssh/%h" -o ControlMaster=auto -o ControlPersist=30m python /tmp/pkb/wait_for_command.py --status /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.status --stdout /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stdout --stderr /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stderr --delete STDOUT: Invalid value 1.0..1.0; must match pattern [0-9]+[MBK]?\.\.+[0-9]+[MBK]?
My idea is that somewhere in the code, extra 'u's are getting added to the ip addresses and that's why I'm getting this error.
2019-12-06 13:42:23,777 0cddc950 MainThread cassandra_stress(1/1) background_tasks.py:545 ERROR    Exception occurred while calling RunTestOnLoader(<IP_ADDRESS>, 0, 1, [u'<IP_ADDRESS>', u'<IP_ADDRESS>', u'<IP_ADDRESS>'], write, insert=1, 1.0, None, None):
I've tried digging through the code but I haven't found the issue yet. Any help would be greatly appreciated.
The full logs are also attached here.
pkb.log
Thanks in advance.

Quick question, are you running PKB with python3+? This particular benchmark seems to be outdated and may not work with python 3, can you try py2.7
More details:
Following command failed:
INFO:root:Started pid 16010: /opt/pkb/cassandra/tools/bin/cassandra-stress write cl=QUORUM n=1 -node <IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS> -schema replication(factor=3) -pop seq=1.0..1.0 -log file=/tmp/pkb/pkb-0cddc950-0.stress_results.txt -rate threads=150 -errors retries=1000
Stacktrace:
2019-12-06 13:42:23,634 0cddc950 Thread-268 cassandra_stress(1/1) vm_util.py:423 INFO     Ran: {ssh -A -p 22<EMAIL_ADDRESS>-2 -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -o IdentitiesOnly=yes -o PreferredAuthentications=publickey -o PasswordAuthentication=no -o ConnectTimeout=5 -o GSSAPIAuthentication=no -o ServerAliveInterval=30 -o ServerAliveCountMax=10 -i /tmp/perfkitbenchmarker/runs/0cddc950/perfkitbenchmarker_keyfile -o ControlPath="/tmp/perfkitbenchmarker/runs/0cddc950/ssh/%h" -o ControlMaster=auto -o ControlPersist=30m python /tmp/pkb/wait_for_command.py --status /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.status --stdout /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stdout --stderr /tmp/pkb/cmd0f419fc8-ddb3-4f79-97f7-a259688defb1.stderr --delete}
ReturnCode:1
STDOUT: Invalid value 1.0..1.0; must match pattern [0-9]+[MBK]?..+[0-9]+[MBK]?
If I understand correctly, this is caused by https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/blob/a2e48f4a8a0f40a82a989d43d9b017d7d7b292c3/perfkitbenchmarker/linux_benchmarks/cassandra_stress_benchmark.py#L428, which should produce an Int in python2, but in python3+, this is a float.
I would suggest running with python 2 for now if you would like to try this benchmark.


Custom task-colletion endpoint does not handle invalid python interpreter correctly

Ref https://github.com/fractal-analytics-platform/fractal-web/pull/523#issuecomment-2217706992.
To reproduce: call the endpoint with python interpreter equal to /something/invalid.
(thanks @zonia3000)

Closed with #1629


Fixes #134

Adds DeployedService entity to support selectively rolling out services per state. Also makes many of our API calls Transactional. Enables LanguageContrller test cases that were erroneously disabled.

lgtm :)

:)
It looks like the CI build failed yesterday and I haven't had time to look into it. All tests passed for me locally.
-----Original Message-----
From: "Rob LaRubbio"<EMAIL_ADDRESS>Sent: 5/16/2015 7:35 AM
To: "motech-implementations/mim"<EMAIL_ADDRESS>Cc: "Lauren Lavoie"<EMAIL_ADDRESS>Subject: Re: [mim] Fixes #134 (#256)
lgtm :)
—
Reply to this email directly or view it on GitHub.

Detached field.  I put a fix in for it.
On May 16, 2015 8:03 AM, "Lauren Lavoie"<EMAIL_ADDRESS>wrote:

:)
It looks like the CI build failed yesterday and I haven't had time to look
into it. All tests passed for me locally.
-----Original Message-----
From: "Rob LaRubbio"<EMAIL_ADDRESS>Sent: 5/16/2015 7:35 AM
To: "motech-implementations/mim"<EMAIL_ADDRESS>Cc: "Lauren Lavoie"<EMAIL_ADDRESS>Subject: Re: [mim] Fixes #134 (#256)
lgtm :)
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/motech-implementations/mim/pull/256#issuecomment-102635376
.

Forget about the failure. It's my bug.
On May 16, 2015 8:03 AM, "Lauren Lavoie"<EMAIL_ADDRESS>wrote:

:)
It looks like the CI build failed yesterday and I haven't had time to look
into it. All tests passed for me locally.
-----Original Message-----
From: "Rob LaRubbio"<EMAIL_ADDRESS>Sent: 5/16/2015 7:35 AM
To: "motech-implementations/mim"<EMAIL_ADDRESS>Cc: "Lauren Lavoie"<EMAIL_ADDRESS>Subject: Re: [mim] Fixes #134 (#256)
lgtm :)
—
Reply to this email directly or view it on GitHub.
—
Reply to this email directly or view it on GitHub
https://github.com/motech-implementations/mim/pull/256#issuecomment-102635376
.

@larubbio your last two commits look fine to me.


Add support for GraphQL operations tracking on server-side renders

Description
Related to Add Performance Metrics
I tried to split this PR up into separate PRs but that seemed to be more trouble than good.

Its easier to grok this solution in one diff than 4
It's hard to teach Lerna about different lib changes without them in the branch.

This PR adds GraphQL metric support in @shopify/react-server by introducing new features into our pre-existing libraries.
@shopify/react-graphql
This is where the core of the solution comes from. I'm adding a createOperationDetailsLink Apollo link to expose GraphQL operation details. Also adding a totalGraphQLTime utiltiy to determine the duration of those GraphQL operations.
@shopify/react-network
We need to eventually share the provided GraphQL operations from createOperationDetailsLink to our koa state so we can metric, yo. I've introduced serverState into the NetworkManger to enable this and updated applyToContext to add it to the koa context.
@shopify/react-graphql-universal-provider

Update our API to create the ApolloClient instead of letting consumers create it. (Context: https://github.com/apollographql/apollo-client/issues/5347)
Add createOperationDetailsLink from react-graphql to ApolloClient and use it to track GraphQL operations using the NetworkManager. The use NetworkManger's serverState APIs to store these operations in koa state.

@shopify/react-server

Use the @shopify/react-network changes to get the GraphQL operations stored from the server-side render. Throw them into the GraphQL timing utilities added in @shopify/react-graphql to get the graphql operation durations. Then send them off in the response header

🎩

In gems/quilt_rails/lib/quilt_rails/react_renderable.rb make some changes so we can see the headers get sent

Change the _response to response in the reverse_proxy block
Add puts "************* Headers: #{response.to_hash.inspect}" in the block

Check out the poc-graphql-server-operations-2 branch in web-rails-proving-ground and run the app
Hit a full page reload on /customers so we get an SSR page.

Verify that the logs prepended with ************* Headers:   contains metrics for graphql_time and react-rendering

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above

I'm going to close this for now. As Chris mentioned, there's still a fair amount of work required to Add performance metrics properly to our quilt framework. Extracting more performance-related libraries out of web, better collection mechanics from the app, and better patterns to interact with rails to name a few.


Make real error rate closer than expected

Codecov Report

Merging #1 (e5b532f) into master (a2834c1) will decrease coverage by 6.39%.
The diff coverage is 67.37%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
- Coverage   95.21%   88.82%   -6.40%
==========================================
  Files          16       16
  Lines        1296     1208      -88
==========================================
- Hits         1234     1073     -161
- Misses         62      135      +73

Impacted Files
Coverage Δ

src/simulate/mod.rs
94.28% <ø> (ø)

src/simulate/error.rs
62.74% <62.56%> (-36.20%)
:arrow_down:

src/alignment.rs
95.34% <96.55%> (+6.45%)
:arrow_up:

src/simulate/quality.rs
92.00% <100.00%> (-0.07%)
:arrow_down:

src/model/error.rs
96.03% <0.00%> (-2.98%)
:arrow_down:

tests/two_run_same.rs
84.78% <0.00%> (+1.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2834c1...e5b532f. Read the comment docs.


Implement authorisation and sustainable sessions

Support for phoenix authorization and authorized calls using CSRF Token and PHP session.

🚢


MediaEngineDCompWin32Sample for PlayReady content

I am looking into extending MediaEngineDCompWin32Sample application to enable it play PlayReady content. Given that playback asset in #60 is fixed the application starts the playback.
I would like to enable it to also play PlayReady protected content (and then playready content coming from our source).
To define a simple initial case I would like to play asset from MediaEngineEMEUWPSample which also plays well there. Apparently there should be some PMP reference involved, discussion about something related I found in #37.
There is a discussion about IMFContentDecryptionModule::SetPMPHostApp for which I would need IMFContentDecryptionModule and it seems I have a problem even getting this. The initialization copy from MediaEngineEMEUWPSample starting from IMFContentDecryptionModuleFactory4::CreateContentDecryptionModuleFactory gives me type supported, and then fails at IMFContentDecryptionModuleAccess->CreateContentDecryptionModule so that I can't even have a CDM pointer:

0xC00D36BA : 'The object does not support the specified service.'.

Even though the arguments are the asme as in UWP EME
        // This is equivalent to the following Javascript EME call:
        // Navigator.requestMediaKeySystemAccess("com.microsoft.playready.recommendation", [{ initDataTypes: ['cenc'], persistentState: 'optional', distinctiveIdentifier: 'required'])

From the MF Media Engine end, execution reaches Windows::Media::Protection::IMediaProtectionManager::Properties() call where I seem to need to pass properties obtained from CDM and I don't have it.
If I use C++/WinRT defined MediaProtectionManager instead with properties borrowed from UWP PlayReady sample, this does not work either because, as I assume, the application is outside of UWP and requires additional steps.
Could you please give some guidance how to connect the pieces together?

With the help of #37 I could really pass further.
So, first of all, there is indeed an exception

Exception thrown at 0x00007FFD211CCF19 (KernelBase.dll) in CompositionPlayback.exe: WinRT originate error - 0xC00D36BA : 'The object does not support the specified service.'.

taking place in IMFContentDecryptionModuleAccess::CreateContentDecryptionModule call:
 	KernelBase.dll!00007ffd211ccf19()	Unknown
 	combase.dll!SendReport(HRESULT error, unsigned int cchMax, const wchar_t * message, unsigned short pSid, void * pExceptionObject, IUnknown *) Line 433	C++
 	combase.dll!RoOriginateErrorW(HRESULT error, unsigned int cchMax, const wchar_t * message) Line 569	C++
 	Windows.Media.dll!Windows::Media::Report(HRESULT hr) Line 22	C++
 	Windows.Media.dll!Windows::Media::Protection::MediaProtectionPMPServerImpl::GetService(const _GUID & guidService, const _GUID & riid, void * * ppvObject) Line 182	C++
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf29d1e2()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf29dbbc()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf2a02b0()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf29d68a()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf29b24c()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf261293()	Unknown
 	Windows.Media.Protection.PlayReady.dll!00007ffcdf263419()	Unknown
>	CompositionPlayback.exe!MediaEngineNotify::CreateContentDecryptionModule(const wil::com_ptr_t<IMFMediaEngineClassFactory,wil::err_exception_policy> & ClassFactory) Line 509	C++
 	CompositionPlayback.exe!MediaEngineNotify::Initialize::__l2::<lambda>(IMFAsyncResult * AsynResult) Line 549	C++

But you can skip it and you obtain the COM pointer.
Then I am seeing a call from CMD to create a client space object Windows.Media.Protection.PlayReady.PRRemoteObjectFactory, and it succeeds.
Then I am seeing a few calls to winrt::Windows::Media::Protection::IMediaProtectionManager::Properties(), where I try to follow logic of UWP EME sample (also spotted in Chromium). I do see the property set is populated with values
Windows.Media.Protection.ConstrictionActive, Windows.Media.Protection.GraphicsTrustStatus but then player fails fast, where UWP EME player takes time to wait for exchange of messages with PlayReady server.
This is some progress, so I will follow up then when I give up.

Following steps of MediaEngineEMEUWPSample along with establishing connection to PMP server, the application reaches IMFContentDecryptionModuleSession::GenerateRequest call. CDM session is created. it's GetSessionId succeeds returning empty string givin ghte impression that the pointer is generally valid.
The arguments to the call GenerateRequest are exactly the same as in the MediaEngineEMEUWPSample: "cenc" and 852 bytes of WRMHEADER.
There is an exception inside GenerateRequest:

Exception thrown at 0x00007FFC3284B4FA (Windows.Media.Protection.PlayReady.dll) in CompositionPlayback.exe: 0xC0000005: Access violation reading location 0x0000000000000000.

MFTrace gives this:
CompositionPlayback.txt

If this could help, I can share a standalone small Win32 app whcih produced 0x8004C3E8 or memory AV as described above.

If you are able to provide the team with a way to reproduce the error you are seeing, that would greatly help us in identifying the issue.

If you are able to provide the team with a way to reproduce the error you are seeing, that would greatly help us in identifying the issue.

Thanks for your attempt. I posted the reproducer into branch at fork here https://github.com/microsoft/media-foundation/pull/62, I also added review/comments to point to the problem in question and reproduction steps.


WIP: Move corner when in a working tree with multiple versions

Fixes https://github.com/microsoft/vscode/issues/160712

Fixing this with https://github.com/microsoft/vscode/pull/169864


CSS : Github Icon Added

Added Github Icon
Fixes #134
Added Github icon from Remix icon.

Few changes made in css

Light Mode

Dark Mode

The guidelines specifically state that there should be no changes to the home page. Do not become discouraged and raise a new issue.


Numeric histogram performance improvement

Up to 2.5x as fast as the current implementation.

Inlines __cdb_filtered_source.
Uses percentile_disc instead of ntile to calculate the interquantile range.

Some benchmarks (the response is exactly the same for all 6):
hist_master_vs_hist_improved.pdf
Closes https://github.com/CartoDB/Windshaft-cartodb/issues/1074

@jgoizueta, can you help us to move this PR forward?

It's nice how percentile_disc simplifies the query and makes it faster. I'd only wish that PG took care of optimizing away CTEs in cases like this rather than forcing us to do so.

It will be done in PG12.


References tickets #86 #87 #88 #89 that I worked on.

I made a CSV file from the 3-column tables I used in CalAccess-Documentation/CalFormat/cal_format_201.pdf
Hopefully this will help get descriptions for other fields in other tables.

Thanks. I just gotta figure out the best place to put this. Maybe it would make a good list in the public documentation as well.

Coverage remained the same at 98.22% when pulling 5c07df079152c9cb3e74f0eabd11ea9a72f9b330 on enactd:master into a736508ae9a78411445d1f6f8cabb9e8528e884f on california-civic-data-coalition:master.

This is a valuable resource but there is currently no good place to park it in our code, so I'm going to close this pull request for the time being. However, the work will remain in the issues of our the repository for future reference.


Release 2.7.0

[!CAUTION]
Do NOT use the latest RaspberryPi OS Bookworm release (also don't upgrade via apt) with the new kernel 6.6, if you need to use GPIO components . There have been incompatible changes for the RPi.GPIO library, so Buttons, Shims and Rfid Reader usage can be broken (#2295).
Using RaspberryPi OS Bullseye is the current recommendation as it does not use the new kernel.

Summary
Features

Support for Spotify again!

a prerelease of mopidy-spotify is used to bring back the spotify integration. Please see Spotify-FAQ for further information

Raspberry Pi OS Buster and Python 3.7 will not be supported/tested anymore with this release.

official Buster support is running out by June 30th, 2024
mopidy-spotify minimum support is Bullseye

Improvements

Some reafactorings of the installation script
Better installation logging
Documentation updates
version updates for github actions

Fixes

Fix for special characters entered during setup (spotify credentials, wifi, ...)
Fix for function calls from RotaryEncoder
Update defaults and fixed handling for some yes/no questions

Version 3 is becoming mature and will soon be the new default of Phoniebox. Therefore Version 2 is slowly going into a maintenance mode and no new features will be added to this version.

Would like to also integrate https://github.com/MiczFlor/RPi-Jukebox-RFID/pull/2357


Correction box-emotion.tpl: retina fixes

https://github.com/FriendsOfShopware/FroshWebP/issues/88

Thanks for both PRs 💙


No multi scan support for fastlane swift

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Complete output when running fastlane, including the stack trace and command used

[INSERT OUTPUT HERE]

Environment

[INSERT OUTPUT HERE]

Going to close this issue since no issue since there is not description of the issue, question, or requested feature. Please open another issue with all requested information and I will be happy to look into 😊


Date not selected first time when date picker has placeholder in IE11

Description
The vaadin-date-picker does not set the selected date the first time when it has a placeholder in IE11.

Expected outcome
When a date is selected from the overlay, the placeholder should be removed and replaced with the selected date.
Actual outcome
When a date is selected from the overlay, the placeholder text is removed but is not replaced with the selected date. When you select another date it will behave as expected and set that date in the input field.
Browsers Affected

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[x] IE 11
[ ] iOS Safari
[ ] Android Chrome

There is a known IE11 bug which is workarounded by using this code in vaadin-text-field.
Need to investigate how it interferes with vaadin-date-picker.


Feature/mot cooperate shape pose estimation

Description

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Already merged to awf source


Fix for issues #35, #37, #38

Issue #35 : For fields which are not predefined in %methods, use the input as it is without changing _ to -.
Issue #37 : Included quotes
Issue #38 : Commented out the print statement.
Additional change : Commented out 'Disconnecting' carp call.

I assume the question is for fix to Issue #35 at line 566.
The issue as explained is the conversion of underscore(_) to hyphen(-) for the input netconf query parameters.
The change here is to use the variable 'field' which is the actual parameter rather than the variable 'tag' which has underscores changed to hyphens at line 525. This change will be applicable only for fields not predefined in netconf libarary in %methods hash.


Compatibility with pytest-sugar

Hi,
I'm testing with your plugin and 'pytest-sugar==0.8.0' also and raise a pytest-sugar error when your plugin detect an ipdb use but it runs well when there isn't any ipdb.
So, It seems that your plugin require a def reportinfo(self) to guarantee the compatibility with 'pytest-sugar'.
The error trace when an ipdb is detected using 'pytest-sugar' is:

Results (2.72s):
35 passed
1 failed
Traceback (most recent call last):
File "/home/tomeu/virtualenvs/wdna/bin/pytest", line 11, in
sys.exit(main())
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/config.py", line 57, in main
return config.hook.pytest_cmdline_main(config=config)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 745, in call
return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 339, in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 334, in
_MultiCall(methods, kwargs, hook.spec_opts).execute()
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 614, in execute
res = hook_impl.function(*args)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/main.py", line 127, in pytest_cmdline_main
return wrap_session(config, _main)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/main.py", line 122, in wrap_session
exitstatus=session.exitstatus)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 745, in call
return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 339, in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 334, in
_MultiCall(methods, kwargs, hook.spec_opts).execute()
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 613, in execute
return _wrapped_call(hook_impl.function(*args), self.execute)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/vendored_packages/pluggy.py", line 250, in _wrapped_call
wrap_controller.send(call_outcome)
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/_pytest/terminal.py", line 374, in pytest_sessionfinish
self.summary_stats()
File "/home/tomeu/virtualenvs/wdna/lib/python3.5/site-packages/pytest_sugar.py", line 494, in summary_stats
report.location[1] + 1,
TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'
If you suspect this is an IPython bug, please report it at:
https://github.com/ipython/ipython/issues
or send an email to the mailing list at<EMAIL_ADDRESS>You can print a more detailed traceback right now with "%tb", or use "%debug"
to interactively debug it.
Extra-detailed tracebacks for bug-reporting purposes can be enabled via:
%config Application.verbose_crash=True

Fixed with the last version, 0.3.5.
Thank you.


Tutorial Screen or Level

Basic tutorial teaching the player on how to play the game.
Done: Level that displays the controls for the game or a level that takes the player through the controls is created and operable.

Further tutorial levels will be created as new game mechanics are introduced
The first tutorial will be focused purely on instructing the user how to move the character


System.DefaultWorkingDirectory broken in version 2.161.1

Agent Version and Platform
Version of your agent? 2.161.1
OS of the machine running the agent? Ubuntu 16.04.6 LTS
Azure DevOps Type and Version
dev.azure.com
What's not working?
It appears as if version 2.161.1 (or 2.161.0) broke the System.DefaultWorkingDirectory environment variable, at least in bash steps. When looking at its value inside a script, it is set to /data/azure/azure-agent/_work/10/s/, which is the path on the hosting machine. I believe it should be set to /__w/10/s, which is the path inside the agent. This used to work on 2.160.1, and our agents were updated overnight and multiple jobs stopped working.
We have a workaround, as it looks like the SYSTEM_DEFAULTWORKINGDIRECTORY environment variable is set properly, so we'll update our scripts.
I'm also surprised that our agents were automatically updated by dev.azure.com despite that version being tagged as pre-release.
The broken step looked like:
node $(System.DefaultWorkingDirectory)/azure/update-versions.js
We were able to work around the bug by replacing it with:
node ${SYSTEM_DEFAULTWORKINGDIRECTORY}/azure/update-versions.js
Agent and Worker's Diagnostic Logs
If there is a specific section of the log you are interested in, let me know and I'll post it, but that log contains a lot of sensitive information, including our build steps, so I'm not willing to post it in it's entirety.

Work around doesn't seem to be working for stuff like the publish step: https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/pipeline-artifacts?view=azure-devops&tabs=yaml#publishing-artifacts
Still looking into solutions, this is a major issue for us as we are unable to release to production.

We're affected by this as well. There's a community thread: https://developercommunity.visualstudio.com/content/problem/844025/container-build-jobs-paths-are-incorrectly-mapped.html
Our builds were working fine on 2.160.1, so it looks like 2.161.1 is the culprit.
Our agents are automatically upgrading to a release that is marked as a pre-release - I'm not sure if that's the expected behavior.
Also I'm not sure if there is a way to disable automatic upgrades as that would allow us to downgrade.

So some updates. We were successful in downgrading the agent to 2.160.1 and hacking our way around the auto-updating by messing with permissions, but it appears as if the capability requirement is set at 2.161.1 on our pipelines, so now we can't find agents with the right capabilities. Is there a way to override this requirement?
I cannot stress enough how bad this problem is for us. Our whole CI/CD infrastructure is down, and we haven't heard a word here in 4 hours, nor in the community thread linked above.

Same thing here. This is a major issue!

We rolled back the agent version on the server. But since the version went backwards, self-hosted agents will not be automatically updated. We will root cause the issue and get out a real fix for it ASAP. Any additional information you can provide would be helpful.

@jpricket thanks for that, we were able to make it work with your change yesterday.
Once that fire is extinguished, I think there's a larger conversation to have about giving users control over the version upgrades. It's not only that the new version broke something. It's that it broke something at a very bad moment for us, and that we had no way of rolling back the changes.

We have identified the bug that caused this issue and are working to get a new release out ASAP.
To comment on 2.161.1 marked as pre-release issue, as we roll out new versions of the agent, a version gets marked as 'release' once it reaches a certain threshold of customers. We are updating our process to mark as 'release' sooner.
In parallel, we are working on two things to help us respond faster to these types of issues in the future:
One, is a better rollback mechanism for when we detect an issue with the agent during rollout.
The second, is improved controls for hosted agents to manage their agent version. This is a complicated issue and will take some time to get right. The specification for this is happening here: https://github.com/microsoft/azure-pipelines-yaml/pull/399

@jtpetty thanks for your feedback. I commented on that PR since I believe we are neither customer "N" nor "K". Hope this helps.

@jtpetty @jpricket Builds just broke again with version 2.162.0. Please fix ASAP.

@jbblanchet - can you point me to the pipeline having this issue?

Organization ompnt, pipeline pi-server.

@jbblanchet - I do not appear to have access. Can you send me a log?

Exact same message as last time about the directory not found.

I can send you a log in private, or I can give you temporary access to our org. Is your email your github user name @microsoft.com?

my email is<EMAIL_ADDRESS>

Sent. I appreciate the quick feedback.

Thanks for the logs. We are going to roll back 2.162.0 right now and try and debug this failure case.

This may actually be a separate issue from the one we addressed above and may be specific to publishing artifacts.

I'll be honest, whether the root cause is the same or not is not that important to us. The effect on the build is the same, and it's twice in 7 days that an update has broken our builds, so points to issues with QC and availability.
Do we need to downgrade the agent versions on our server manually? Do we need to block auto-update?

@jbblanchet  - Agreed an all of this. I want to get you back up and going as fast as possible. We have initiated a rollback of Agent 2.162.0. Once that is complete, you will be able to manually downgrade the agent on your servers. I will post on here when that is process is complete.

@jtpetty thanks for the help.

@jbblanchet - just as an update, we are in the process of creating agent version 2.163.0 which will be the same bytes last 2.160.1 and will auto update on your side.

@jbblanchet - 2.163.0 is now available on GitHub. You can manually upgrade to that version or you can wait for our rollout and it will do it automatically.
Also, I have triaged your failing case and am working on a fix. When I have something ready, I will message you and see how best to verify that this will no longer impact your team.


IP verification cookie does not work as intended

IP verification cookie does not allow to login with different IP.

Identified | That is not a bug, but an intended feature that keeps email check cookie secure from being compromised and used with another session. In order to sustain this security more strict requirements are needed.

Update | No changes are needed, as this behavior of ip check cookie is necessary.

This behavior is intended for this cookie.

Closing, as this is not a planned change.


this.$event is not available when evaluating at the $parent scope

If you delegate an event using the $parent scope, for example <button click.delegate="$parent.click()"></button>, this.$event is undefined within the click() function. In fact, the event is not available to such a handler at all. We would expect this.$event to be defined within every click handler, regardless of the scope.

I'm not sure that commit resolves this issue. More, the issue I was seeing was that I was expecting $event to be accessible on this for every event handler. Instead, the API supports writing <button click.delegate="$parent.click($event)"></button>. This issue can be closed.