Warning message "Possibly ambiguous ID being introduced."

Hello
First of all, thank you for making a good tool.
while converting SPDX spreadsheet to SPDX RDF using java-tools, I saw the following warning message.
id is the same value, but output a warning message, "Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25"
Is it the intended behavior to output an error message even if the id and previous values are the same?
debugger
id and previous are the same.

warning message
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-25 is being raplaced by SPDXRef-Package-25
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-Package-1 is being raplaced by SPDXRef-Package-1
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT
WARN  21-10-05 12:19:28[http-nio-8180-exec-1] [o.s.s.RdfSpdxDocumentModelManager:326] - Possibly ambiguous ID being introduced.  SPDXRef-DOCUMENT is being raplaced by SPDXRef-DOCUMENT

@riyenas0925 In looking at the code, it seems like the warning is generated whenever there is an SPDX Element or SPDX License created with the same ID.  Since the ID's are case insensitive and RDF is case sensitive, it is possible that an ambiguous ID is created.
In looking at the warnings you posted, however, they are the same case.  This may be an issue with the spdx-java-rdf-store library.  In a quick look at the code, I noticed that if an element is deleted then added, it could cause this warning.
If you have steps to reproduce the warning, I can take a look and provide a bit more detail.

Dear @goneall
Would it be helpful to attach the SPDX spreadsheet you were using? And I wonder if there is any problem in converting and using SPDX even if there is a current error.

File before conversion.
SPDXRdf-test_20211005.xls
File after conversion
GitHub does not support RDF, so it is compressed and uploaded.
SPDXRdf-test_20211005.zip
.

@riyenas0925 I wasn't able to duplicate the warning using the above attached spreadsheet.  I may be on a different version of the library, however.
Can you set a breakpoint on the warning and copy/paste the stack trace?  I'm curious what is calling the method that is generating the warning.

dear @goneall
Currently, org.spdx:tools-java 1.0.2 is added as a dependency to gradle and used. tools-java 1.0.2 depends on spdx-rdf-store 1.0.2.

Dear @goneall
oh sorry
the old file was an invalid file The file below was before the file was converted.

I currently know that checksums is require, is there any way to replace checksums with NONE or NOASSERTION in spdx2.2?
The issue below says it could be included in spdx 3.0, when will spdx 3.0 be released?
https://github.com/spdx/spdx-spec/issues/47

@riyenas0925 I was able to duplicate the problem and I think the warning can be safely ignored.
There is an issue in that the warning should not be generated.  I need to do a bit more research to find out if there is a way to distinguish when the RDF Jena library creates a new resource from when a new statement is created.

I currently know that file checksums is required in per file info sheet, is there any way to replace checksums with NONE or NOASSERTION in spdx2.2?

In SPDX 2.2, checksums are required.  The library will verify that the checksum matches a specific pattern.  As you mentioned, this may change in 3.0.

I created PR #23 which resolves this issue.
In the process of investigating this issue, I found another minor issue #24 which I'll look into before the next release.


CodeMirror too eager at capturing (middle-click) paste events

be on linux (or some system that has middle-click paste)
go to http://codemirror.net
select some text in the editor
click off of the editor (and observe the highlight color changes to indicate it's not focused anymore)
middle click paste, repeatedly

Expected: nothing happens, since there's no text field focused to receive the pastebuffer contents
Actual: CodeMirror pastes the pastebuffer contents into itself, even though it's not focused
If this behavior is helpful for some use-cases, could an option be added to disable it?

Which browser did this happen in? I'm not seeing it in Firefox or Chrome. The editor definitely doesn't register any global handlers related to this, so I'm not sure how it can be happening when it's lost focus.

Heh, okay, I got a chance to play around with this some more. Try this:

http://codemirror.net
triple click on one of the lines (e.g. line 7) to select it all
move your mouse directly to the right, so that it's outside the border of the CodeMirror, but not above or below it.
middle-click

I can see this happen now -- even when the editor isn't focused. My best guess is that Chrome is using some kind of heuristic to find the element that the user might have meant to click on... the mouse target isn't related to CodeMirror there, and the focus isn't on it, so from what I understand of the DOM, there really isn't any reason to deliver the pasted content on the editor, yet it does. No paste event is fired, either.
The fact that this only happens up to a certain pixel distance from the editor seems to also point in the direction of a misguided heuristic. But interestingly, I can't reproduce this with a plain textarea, so it might be possible to work around it by changing some DOM structure or CSS value ... I haven't been able to figure out such a workaround yet though.

FYI, I was reproing this in Firefox too, so I don't think it's chrome
specific.
On Aug 19, 2017 09:33, "Marijn Haverbeke"<EMAIL_ADDRESS>wrote:

I can see this happen now -- even when the editor isn't focused. My best
guess is that Chrome is using some kind of heuristic to find the element
that the user might have meant to click on... the mouse target isn't
related to CodeMirror there, and the focus isn't on it, so from what I
understand of the DOM, there really isn't any reason to deliver the pasted
content on the editor, yet it does. No paste event is fired, either.
The fact that this only happens up to a certain pixel distance from the
editor seems to also point in the direction of a misguided heuristic. But
interestingly, I can't reproduce this with a plain textarea, so it might be
possible to work around it by changing some DOM structure or CSS value ...
I haven't been able to figure out such a workaround yet though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codemirror/CodeMirror/issues/4900#issuecomment-323533413,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE0RXzVMffBUXalnqCRSB-gBhNOoPqT6ks5sZw5GgaJpZM4Ov03f
.

Interesting. I've never had middle-click paste in CodeMirror work in Firefox, and right now (with Firefox 57) middle-click still does nothing -- whether I click inside or outside the editor. Which Firefox version are you using, and do the steps you outlines above cause actual pasting to happen on your system?

You're right. I was mistaken – I never did get it reproing on FF. But for the Chrome specific behavior, would you mind putting together a simpler repro case than the full codemirror, and filing a bug at https://bugs.chromium.org/p/chromium/issues/list? If you link it here, I can comment on it to get it prioritized a bit.

On closer look, this seems to be a behavior that Chrome exhibits for all DOM nodes that aren't input fields or textareas — when a middle mouse paste happens, that's not over a regular input field, it searches for a nearby valid cursor position, which in this case will be in the text inside of the editor, and fires the paste event on that.
So it appears that what we're seeing here is what the Chrome developers intended to happen, probably for usability reasons. I also don't see an easy way to disable it, so I would propose to just leave it as it is. Can you live with that?

I'd rather have the actual discussion with the relevant Chrome developers directly, to determine what it was they did or did not intend. But to do that, I need a small repro case that I can attach to a bug. Since you noted you could get this happening on other input fields, would you mind putting a small one together?
Something super minimalist like

<input>

doesn't appear to repro.

Middle-clicking anywhere on this page fires the event handler, though the div only extends to the border.
<!doctype html><meta charset="utf-8">

Hello

Thanks! Filed https://bugs.chromium.org/p/chromium/issues/detail?id=786490

That issue doesn't seem to be public. At least I cannot see it.

Ah, yes, it appears visibility-restricted to Google. Sorry about that. But I think the relevant tagging should help prioritize a response.

I'm closing this here and hope that the discussion with the Chrome developers is helpful.

Could this issue needs to be re-opened? For both Chrome 81 and Firefox 75 on linux middle clicking outside the editor will paste highlighted text

triple click on one of the lines (e.g. line 7) to select it all
move your mouse directly to the right, so that it's outside the border of the CodeMirror, but not above or below it.
middle-click

I also find that this is true for clicking to the left of the demo:

Could this issue needs to be re-opened?

It's still not something CodeMirror can help. I can confirm that Firefox is also firing a paste event on the editor in this situation. The event doesn't provide any information that could help distinguish it from a paste inside the editor, so I don't see a way for the library to avoid this. You could open a bug report for Firefox if you want (the issue can be reproduced without CodeMirror by registering a paste event handler on a block element that has visible content, and middle-clicking in the margin next to that element).

Experiencing something similar where if you middle click outside of the editor, hold it, then release with the cursor on the editor, it will paste the contents.
Would a solution be to listen to the mouse down and mouse up events, determine if the mouse down was on while on the editor and use that to block the event?


Set To Dictionary does not support non-string keys when used like key=value

All is OK with &{Dict}=    BuiltIn.Create Dictionary    ${1}=one    one=uno    uno=um    um=ein    ein=un
But fails with Collections.Set To Dictionary    ${Dict}    two=dois    ${2}=two
with:   FAIL    Argument names must be strings.

This is certainly true. It's not really a bug because it is also the documented behavior of the keyword. The general way to add set dictionary items is using
Set To Dictionary    ${dict}    key    value    ${2}    two

This is obviously highly inconsistent with how Create Dictionary works. It currently still supports
${dict} =    Create Dictionary    key    value

but that approach is deprecated in favor of
${dict} =    Create Dictionary    key=value

There are various things we could do to remove this inconsistency:

Support non-string keys with Set To Dictionary. Notice that the underlying reason they don't work is that **kwargs syntax in Python supports only string keys. Avoiding that limitation requires changing how arguments are resolved in general. Currently only some keywords in BuiltIn use that approach and there is no clean API to do that. Cleaning up this stuff is the topic of #2190. Required changes may be too big to be done in RF 3.0.x versions.

Remove deprecation from Create Dictionary to pass keys and values as separate items. Then there would at least be a common way to create and modify dicts. Not forcing users to switch dictionary creating to the key=value format would probably be a good idea in general. This could be done already in RF 3.0.1 but would require a separate issue.

Decisions:

Try to make Set To Dictionary work with all valid dictionary keys similarly as Create Dictionary. This requires too big changes to be done in RF 3.0.x but hopefully can be done in RF 3.1.

Remove deprecation from passing keys and values individually for Create Dictionary. I submitted #2386 about that and targeted it for RF 3.0.1.

RF 3.1 is so long overdue and this is so low priority issue that I move this to RF 3.2 scope. After #2386 included in RF 3.0.1 there's also a non-deprecated uniform way to use Crate Dictionary and Set To Dictionary.


Stop assuming the HTTP client has a base URL

Instead do URL resolution inside the manifest that we've just
downloaded. That way manifests written to disk always have
absolute URLs in them.

Much better


Reading cause split data randomly

Hi, I am using 0.1.4 version of telnet-rs .
Error
The telnet rs only read first part of data
How to fix
https://github.com/SLMT/telnet-rs/blob/80eddf03029dcfd60c107409b011debc7695db3b/src/lib.rs#L168
If we can change read method to read_to_end , we will able to read all of tcp parts.
Client code
let mut stream = Telnet::connect(("whois.nic.uno", 43), 1024 * 1024).expect("Couldn't connect to the server...");
stream.write("kaan.uno \n".as_bytes()).expect("Write Error");

// sleep(Duration::from_secs(1));

let event = stream.read().expect("Read Error");
if let TelnetEvent::Data(buf) = event.borrow() {
println!("{}", from_utf8(&buf).unwrap()); // Sometimes full data some time half of data
}

Half data

Full data

Tcp data

Thanks for your report. We will look into it.


__webpack_public_path__ does not work if entrypoint uses ES6-style imports

I'm submitting a bug report
Webpack version: 1.13.1
Please tell us about your environment: Ubuntu 14.04
Current behavior:
Entrypoint file:
__webpack_public_path__ = SETTINGS.STATIC_URL + 'build/'
require('navbar/navbar.es6')

If I use import 'navbar/navbar.es6' instead, the images that are loaded inside of navbar.es6 (via import imageName from 'img/filepath.png') do not have the public_path prepended to them. When I use the above require('navbar/navbar.es6'), it works fine. CommonJS imports work but ES6-style ones do not when dynamically setting __webpack_public_path__
Expected/desired behavior:
There should be no difference between ES6 and CommonJS modules

Browser: Chrome 50
Language: [ES6/7]

ES6 says that import statements are always hoisted (brought to the top of the current module).  This means that the following are equivalent:
__webpack_public_path__ = "asdf";
import foo from "foo";

import foo from "foo";
__webpack_public_path__ = "asdf";

They are always treated as though you had the second version.
This is part of the ES6 spec and has nothing to do with Webpack.
Since the import statement will occur before the assignment to __webpack_public_path__, it will happen before the public path has been updated.
Therefore, your desired behavior would require you to use require().  Anyone correct me if I'm wrong.

@harmony7 ohh, didn't even think that hoisting could be the root cause of that problem, thanks for the tip!
To have symmetry with the publicPath configuration, I would assume that webpack would read that line first before anything else. To achieve that kind of symmetry, I would guess that webpack would have to hoist __webpack_public_path__ to the top of the module after any loaders run (not sure what that might involve)

One way you can work around this (sort of) is like this:
main.js
import 'navbar/navbar.es6';
/* ... The rest of your program ...*/

entry.js
__webpack_public_path__ = SETTINGS.STATIC_URL + 'build/';
require('./main');

Use entry.js as your webpack entry point. If you want to use import everywhere else then you can; entry.js would be the only point in the code where you need a require().

@harmony7 yea that's what I'm currently doing (thanks for the suggestion though!), it's not the prettiest solution as it means I need to create separate files for each of my entrypoints that uses __webpack_public_path__. The broken symmetry with publicPath (and broken symmetry with require in a codebase that uses ES6 imports) is fairly unintuitive on top of that. It feels really hacky right now as I have 4 entrypoints.
Broken symmetry/intuition in build tools IMO warrants an eventual solution

// entry.js
import "./public-path.js"
import "app";

// public-path
__webpack_public_path__ = "..."

@sokra (just a clarification) is that always guaranteed to work, or just a quirk of how webpack builds the imports?

I think this should be guaranteed by the ES6 spec.

I've found that you can load the public-path.js file in @sokra 's example by adding to the entry array in webpack.config.js.  Then it's much less intrusive.
entry: ['./public-path.js', './entry.js']

Is it worth defining a plugin extension point to allow developers to reprogram how public paths are computed, for cases where the config file default isn't sufficient? I wanted this in the context of Aerobatic, where an HTML preprocessor outside of my control modifies my pages to add a CDN base URL as a global variable, well after webpack has finished running.

@ojacobson i bumped into the same problem and drafted this solution
https://github.com/agoldis/webpack-require-from
I needed to be able to switch webpack public path at runtime and fine tune how files are loaded from CDN. While you can override the __webpack_public_path__ manually, sometimes it isn't enough.

Am I wrong to think that this would be much simpler if publicPath could be set to a function?

Would be really cool if window.__webpack_public_path__ would be respected at runtime (after webpack compilation). So webpack compilation can be part of the compilation process where the public path is not baked in. A good use case is building a docker image that can be used for both staging and production (with different cdn urls).

window.webpack_public_path why not use

For anyone making a lib consumed by other app and who wants to set public path at runtime, here is what i ended up doing (no es6 import required for this)
// entry file
export default options => {

    __webpack_public_path__ = options.publicPath || '/'

    const App = require('./app')

    return new App.default(options)

}
```

I've tried all this suggestion and others but none of them are working for me. I have a similar problem, where i need to load mu chunks from a different origin. Currently using CRA -create-react-app-, i have in my entry file:
index.js
import './src/containers/async/build';
import React from 'react'
import {render} from 'react-dom'
import {Provider} from 'react-redux'
import store from './store'
import App from './containers/app'

import './index.css'

const target = document.querySelector('#root');

render(
    <Provider store={store}>
        <React.Fragment>
            <App/>
        </React.Fragment>
    </Provider>,
    target
);

in src/containers/async/build.js
__webpack_public_path__ = 'http://my-server-assets.com';
Am i missing something?

@rrubiorr81 Did you solved it ?

// entry.js
import "./public-path.js"
import "app";

// public-path.js
__webpack_public_path__ = "..."

this is not working in my case. path is not setting for image and css files

Hi.
My name is  Kirill Borodavkin.
I appied for this job on freelancer.com.
Looking forward to hearing from you.


Bug Report: Dialogue Sound Missing

Which target are you using?
[X] Windows
[ ] Linux
[ ] Mac
Explain your issue
There's no text.ogg in the files. Please add that. It's not even really a bug, it's just a little goof
Please check first if your issue haven't already been reported yet.

well i left that one there for mods to use it, but if you suggest we should, then which sound should we use even, getting one from other engines would suck honestly lol

actually its better not, cuz if people want no sounds theyd have to create a script to mute it, its better like this on default

well i left that one there for mods to use it, its not a bug, but if you suggest we should, then which sound should we use even, getting one from other engines would suck honestly lol

(also senpai's box dialogue uses it)


DevPool by Ubiquity

Project Abstract
DevPool is a crypto-native platform that organically sits on top of GitHub to optimally match developers with open tasks and get paid in crypto while automating management for distributed organizations and repository maintainers.
Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

fund ink! smart contracts

What is "fund ink!"?
I understand that these submissions are expected to be delivered in a single commit. It makes more sense to me that we append changes to this same pull request, possibly while leaving it as a draft pull request, and to keep the context of the conversation.
Otherwise, please confirm if you want me to close this pull request, and open another when we complete our changes.

Thanks @pavlovcik yep no worries, you can make the changes on the current PR, no need to open a new one. We will squash the commits anyway.

I wanted to let you know that I'm closing this because of inactivity. Let me know if I should reopen it.


Bug! Should've ignored format string in logs

Minimal case,
func main () {
    log.Println ("Hello There! %Y %s", "123")
}

And you will see this in fresh,
15:24:52 app         | 2016/05/16 15:24:52 Hello There! %!Y(MISSING) %!s(MISSING) 123

@CaledoniaProject you are right, but everything is used in the string format for now. feel free to open a PR if you want to fix it :)

@pilu I made a PR for this (https://github.com/pilu/fresh/pull/54), please consider ^^

:+1:


Add PKCE option to authorization code flow

Solves #219
Remaining tasks:

[ ] Remove dependency to pkce-challenge
[ ] Unit test

You're welcome to try your hand at unittest, but it gets hard because of the server component. I don't have an example for it yet.

Thanks for the pull request. I will merge it and then test it manually with the keycloak. Let's see how I have to set this up.

I have adjusted one little thing. Instead of base64Url I use base64. Currently I still support NodeJS v12 and therefore I can't use this option yet. Otherwise, I have successfully tested it with Keycloak. Thank you.

RFC 7636, section 4.2 states that the code challenge must be base64url encoded. I assume the reason is because the code challenge is added as query parameter to the auth url. The regular base64 encoding produces characters like +, / or =, which have a special meaning in URLs. The base64url encoding avoids this by replacing reserved characters with unreserved ones, e.g + with - and  / with _.
When we go back to base64 we should post process the encoded string by replacing the reserved characters.

I did copy the replace from pkce_challenge and test it afterwards with Keycloak and PKCE support enabled.
https://github.com/AnWeber/httpyac/blob/main/src/plugins/oauth2/flow/authorizationCodeFlow.ts#L124-L127

Just saw the code. You already took care of it. Nevermind ;-)


Progressbar synchronisation

When seeking in Kodi, the progressbars in Kore are not synchronised. Although the Player.OnSeek notifications are captured in kore, they are not passed to the HostConnectionObserver.PlayerEventsObserver.

I extended the PlayerEventObserver interface with the method:
https://github.com/xbmc/Kore/blob/65ae63966e8e9b0ecb2d242feaf966ef942f1eb2/app/src/main/java/org/xbmc/kore/host/HostConnectionObserver.java#L106-L111
I passed the OnSeek notification in the HostConnectionObserver class:
https://github.com/xbmc/Kore/blob/65ae63966e8e9b0ecb2d242feaf966ef942f1eb2/app/src/main/java/org/xbmc/kore/host/HostConnectionObserver.java#L412-L420

This enables the classes BaseMediaActivity and NowPlayingFragment to update the progressbars.
Not sure why this was not implemented though, probably a good reason I'm not aware of.

Why have you closed this?
Sorry for not replying earlier, but i haven't had much time lately. I intended to look into this soon.

Sorry for making a mess... I'm getting used to commits to my fork.

I'm trying to get things right in new pull resuests, sorry!

Ah, ok.
Make a PR when you're ready.


[Windows 7] .exe Installer for 2.0.9 Fails with old N1 install active

Are there any related issues?

Could not find any
What operating system are you using?
Windows 7
What version of Nylas Mail are you using?
2.0.9
--
Bug?
Do you have any third-party plugins installed? If so, which ones?
No
Is the issue related to a specific email provider (Gmail, Exchange, etc.)?
No
Is the issue reproducible with a particular attachment, message, signature, etc?

No
--
Feature Request?
Does this feature exist in another mail client or tool you use?
No
--
There is an issue where the installer fails partway through the install if Mail is installed while N1 is still open (I originally thought the test build exe would install alongside N1, but it is treated as an upgrade and removes N1, even when the install fails).
I have attached the log (had to "convert" to .txt for Github, but this is a straight copy of the original log), and the fix is to close N1/restart the installer, but perhaps a check for a running instance would help.
SquirrelSetup - Copy.log.txt

thanks for the report! we'll look into it!

@jtflynnz , the issue regarding N1 upgrading to Nylas Mail should be fixed now. See: https://github.com/nylas/nylas-mail/issues/3366#issuecomment-293452858. Is the issue fixed for you now?
However, there seems to be an issue when starting the windows build: #3367

hi @jtflynnz, the windows build has been fixed. If you've downloaded a bad build, you can re-download it from nylas.com/download

The installer worked, and Nylas Mail launched fine once the initial issue of closing N1 was finished. I still have the N1 exe, so I will try to test with a newer installer for Mail later this week.
Sent from Nylas Mailhttps://n1.nylas.com/link/ca4c7f86243d364c88d91b6a5e21baf43fb75a478b3866d191b0008bd11cfdf6/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&r=cmVwbHkrMDA1MzI2ZTNhZDJkZjAxOWI4NTQ0OGQwOWVmNzQ4OGViZDc4NmM0NWU2ZDAwYTk0OTJjZjAwMDAwMDAxMTUwNTg3NTE5MmExNjljZTBkMmQ2NDAwQHJlcGx5LmdpdGh1Yi5jb20=, the best free email app for work
On Apr 12 2017, at 2:12 am, Juan<EMAIL_ADDRESS>wrote:
hi @jtflynnzhttps://github.com/jtflynnz&r=cmVwbHkrMDA1MzI2ZTNhZDJkZjAxOWI4NTQ0OGQwOWVmNzQ4OGViZDc4NmM0NWU2ZDAwYTk0OTJjZjAwMDAwMDAxMTUwNTg3NTE5MmExNjljZTBkMmQ2NDAwQHJlcGx5LmdpdGh1Yi5jb20=, the windows build has been fixed. If you've downloaded a bad build, you can re-download it from nylas.com/download
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/nylas/nylas-mail/issues/3365#issuecomment-293483571&r=cmVwbHkrMDA1MzI2ZTNhZDJkZjAxOWI4NTQ0OGQwOWVmNzQ4OGViZDc4NmM0NWU2ZDAwYTk0OTJjZjAwMDAwMDAxMTUwNTg3NTE5MmExNjljZTBkMmQ2NDAwQHJlcGx5LmdpdGh1Yi5jb20=, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFMm4_lE4VGMVeWNoK9azaNZkEuQiTNkks5rvGtRgaJpZM4M6o8w&r=cmVwbHkrMDA1MzI2ZTNhZDJkZjAxOWI4NTQ0OGQwOWVmNzQ4OGViZDc4NmM0NWU2ZDAwYTk0OTJjZjAwMDAwMDAxMTUwNTg3NTE5MmExNjljZTBkMmQ2NDAwQHJlcGx5LmdpdGh1Yi5jb20=.

The installer worked, and Nylas Mail launched fine once the initial issue of closing N1 was finished. I still have the N1 exe, so I will try to test with a newer installer for Mail later this week.
Sent from Nylas Mailhttps://n1.nylas.com/link/ca4c7f86243d364c88d91b6a5e21baf43fb75a478b3866d191b0008bd11cfdf6/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&r=bWVudGlvbkBub3JlcGx5LmdpdGh1Yi5jb20=, the best free email app for work
On Apr 12 2017, at 2:12 am, Juan<EMAIL_ADDRESS>wrote:
hi @jtflynnzhttps://github.com/jtflynnz&r=bWVudGlvbkBub3JlcGx5LmdpdGh1Yi5jb20=, the windows build has been fixed. If you've downloaded a bad build, you can re-download it from nylas.com/download
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/nylas/nylas-mail/issues/3365#issuecomment-293483571&r=bWVudGlvbkBub3JlcGx5LmdpdGh1Yi5jb20=, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFMm4_lE4VGMVeWNoK9azaNZkEuQiTNkks5rvGtRgaJpZM4M6o8w&r=bWVudGlvbkBub3JlcGx5LmdpdGh1Yi5jb20=.

The installer worked, and Nylas Mail launched fine once the initial issue of closing N1 was finished. I still have the N1 exe, so I will try to test with a newer installer for Mail later this week.
Sent from Nylas Mailhttps://n1.nylas.com/link/ca4c7f86243d364c88d91b6a5e21baf43fb75a478b3866d191b0008bd11cfdf6/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1&r=bnlsYXMtbWFpbEBub3JlcGx5LmdpdGh1Yi5jb20=, the best free email app for work
On Apr 12 2017, at 2:12 am, Juan<EMAIL_ADDRESS>wrote:
hi @jtflynnzhttps://github.com/jtflynnz&r=bnlsYXMtbWFpbEBub3JlcGx5LmdpdGh1Yi5jb20=, the windows build has been fixed. If you've downloaded a bad build, you can re-download it from nylas.com/download
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/nylas/nylas-mail/issues/3365#issuecomment-293483571&r=bnlsYXMtbWFpbEBub3JlcGx5LmdpdGh1Yi5jb20=, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFMm4_lE4VGMVeWNoK9azaNZkEuQiTNkks5rvGtRgaJpZM4M6o8w&r=bnlsYXMtbWFpbEBub3JlcGx5LmdpdGh1Yi5jb20=.

This should be fixed with version 2.0.13 which was released today! You should be able to run both N1 and Nylas Mail simultaneously if you want without having issues. Let me know if this works for you!

Works like a charm now; both installs are running side-by-side (while I try to provide details to a different issue with mail, haha) Thank you to the team!

hi, i encountered the same error on windows 10 ltsb having installed n1 previously, so not sure if it is actually fixed?
workaround was deleting n1 folders from both appdata\local and appdata\roaming
attached is my log
SquirrelSetup.txt


App icon not visible in windows file explorer

Describe the bug

The icon is not visible in the windows file explorer even though it is visible in the taskbar and title bar of the app.
The icon looks like this:

whereas it should look like this:

I have also tried using multi sized icon file (.ico) format, but to no avail.
To Reproduce
Steps to reproduce the behavior:

 Download [arnabanimesh/headlines](https://github.com/arnabanimesh/headlines)

 Compile using `cargo build --release`

Go to `target/release` inside the repo

 Check the icon of `headlines.exe`

Expected behavior

The file icon shown in the file explorer should match with the one shown in the taskbar/title bar
Screenshots

Already provided above.
Desktop (please complete the following information):

OS:  Windows 10 x64 latest
Browser  NA
Version  NA

Smartphone (please complete the following information):

Device:  NA
OS:  NA
Browser  NA
Version  NA

Additional context

NA

This is not egui or winit problem.
let see https://stackoverflow.com/questions/30291757/attaching-an-icon-resource-to-a-rust-application


FIX: docs not included in composer package installs

This change will improve the performance of package-download-based installs of composer packages, by excluding docs. It does this by excluding them from the output of the "git archive" command.
It uses the export-ignore git attribute to do this.
The suggestion came from https://github.com/composer/composer/issues/1750

I'm keen to hear whether other people see any downsides to this. Note also that we could consider wether we want to exclude tests/ as well. Although some users might want to run package tests, they always have the option of installing with --prefer-source to do this.
Note that I'm expecting that these changes will flow through to the .tar.gz and .zip downloads on silverstripe.org, once https://github.com/silverstripe/silverstripe-buildtools/issues/8 is done.

I'm in favour of removing both docs/ and tests/. If you run tests, it's likely because you're contributing, in which case you can't work off the archive anyway.


Godot scene .tscn icon not working in light mode

When working with the editor in dark mode the icons work properly as seen below:

However when switching to light mode the icons get replaced with this:

I tested this with different color themes, the result is the same. I'm on macOS, I can test this on windows and linux later if needed.

i'm not currently able to replicate this.
i notice your other icons are not switching to latte either, do you have catppuccin.syncWithIconPack enabled? i don't know if it's related, but let me know if that changes anything.

@backwardspy thanks for getting back to me! I did have that setting enabled, but it doesn't seem to work for me. Toggling the themes doesn't change the icon theme. I tried to reset both the theme plugin and the icon plugin, but it doesn't seem to work. Also setting the icon theme manually to Latte will still display those broken icons

Actually I got the icon sync to work after completely uninstalling the plugins and restarting VSCode and installing plugins again. But the godot icons are still broken

I think I found the reason why the icon toggle does not work for me:
I sync my VSCode theme to the system theme, so if I have a dark system theme I use Macchiato, if I have a light theme I use Latte. The problem is that VSCode does not actually change the current theme.

From what I can tell the plugin looks at the workbench.colorTheme and not the preferredLightColorTheme and preferredDarkColorTheme settings, probably, maybe it's not easy to tell what mode window.autoDetectColorScheme is currently in?
Either way for me the Latte icons are still broken

thanks for that additional info, that's really helpful. i'll look into this shortly and get back to you.

Either way for me the Latte icons are still broken

if even manually setting the icon theme to latte doesn't resolve this, please could you raise an issue for it on https://github.com/catppuccin/vscode-icons? i don't think that part of the problem is caused by this plugin.


Use Angular CLI and ng-packagr for local development and CI servers

Type of Issue
[x] Bug Report
[ ] Feature Request

Description
Not sure the packagr is actually compatible with the cli in the same repo as described in the readme.  I realize that this issue is related to another repo, but this was the only place to file an issue.  I believe it is related to how the cli resolves modules slightly differently than tsc (at least for modules outside the baseUrl).
How To Reproduce
When attempting to use the repo from the readme, the ng serve command fails with ERROR in src/app/app.component.ts(3,28): error TS2307: Cannot find module '@my/lib'. src/app/app.module.ts(7,29): error TS2307: Cannot find module '@my/lib'.
Expected Behaviour
It should be able to resolve lib
Version Information
  "dependencies": {
    "@angular/common": "~5.0.0",
    "@angular/compiler": "~5.0.0",
    "@angular/core": "~5.0.0",
    "@angular/forms": "~5.0.0",
    "@angular/http": "~5.0.0",
    "@angular/platform-browser": "~5.0.0",
    "@angular/platform-browser-dynamic": "~5.0.0",
    "@angular/router": "~5.0.0",
    "core-js": "^2.4.1",
    "rxjs": "^5.4.2",
    "zone.js": "^0.8.14"
  },
  "devDependencies": {
    "@angular/cli": "1.5.0",
    "@angular/compiler-cli": "~5.0.0",
    "@angular/language-service": "~5.0.0",
    "@types/jasmine": "~2.6.0",
    "@types/node": "~8.0.0",
    "codelyzer": "~4.0.0",
    "cpr": "^3.0.0",
    "jasmine-core": "~2.8.0",
    "jasmine-spec-reporter": "~4.2.0",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.3.0",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "ng-packagr": "1.5.0",
    "protractor": "~5.2.0",
    "rimraf": "^2.6.1",
    "ts-node": "~3.3.0",
    "tslint": "~5.8.0",
    "typescript": "~2.5.2"
  }

Update:
For anyone else facing this issue, I believe it is being tracked here in the cli project and has been assigned to someone. - https://github.com/angular/angular-cli/issues/8308
Seems it is looking in node_modules to module resolution and ignoring all other path settings and alias' such as those in tsconfig or webpack (according to the issue).

@jonesmac are you using tsconfig paths? if so ng-packagr uses it's own internal tsconfig that has no insight into your projects defined paths. I opened a different issue asking to be allowed to provide your own tsconfig.

Hi @jonesmac,
thanks for reporting! The ng-packaged demo needs an update!
My recommended way is to use "ng serve" with a cli config that uses the library sources and another npm/yarn script for building against binaries of library (e.g. on a ci server)

Updated the ng-packaged demo.
I guess the readme over there is now out-of-date. I'd very much appreciate when someone could send a PR for that when she/he tries to get going with the demo....

@dherges thanks so much for updating the repo!  I pulled it down and verified that it all works locally.  I see the CI config and updated scripts.  Are you looking for a PR that documents how to the new features you recently added or a general rewrite of the README?

@jonesmac Exactly! That will be super-cool!

Did not want to create another ticket since this one already exists. A simple clone of the repo and build is still causing ERROR in src/app/app.component.ts(3,28): error TS2307: Cannot find module '@my/lib'. src/app/app.module.ts(7,29): error TS2307: Cannot find module '@my/lib'.
Any workarounds?


WebSocket push, stop broadcasting

I tried to send data to user by using WebSocket push.
The fact is, if at any moment, the onPublish did'nt work well, the websocket server automatically send the push data to all the user connected.
Moreover, I tried to just remove the line (OnPublish method)
$topic->broadcast($dataPush,[],[]);
Also try to add
return;
But in any case, all user connected get the data push by the method
this->pusher->push([$data],"NotificationCenter_topic", []);
So, how can i stop the server to send any data after a push in certain case ?

Thanks for the answer.
When using Websocket push, the OnPush is'nt called.
see Note 2 :
https://github.com/GeniusesOfSymfony/WebSocketBundle/blob/master/Resources/docs/Pusher.md#websocket-pusher

Okay, as mentioned in the docs, you should use another pusher than Websocket pusher because it has a lot of overhead - or choose another way of using them.

When you use the websocket pusher we rely directly on wamp protocol so
onPublish is call. All other pusher use onPush method. And yes websocket
pusher have a high cost due to handshake when we connect.
On Mon, 6 Jun 2016 9:05 am novacp<EMAIL_ADDRESS>wrote:

Okay, as mentioned in the docs, you should use another pusher than
Websocket pusher because it has a lot of overhead - or choose another way
of using them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GeniusesOfSymfony/WebSocketBundle/issues/156#issuecomment-223882934,
or mute the thread
https://github.com/notifications/unsubscribe/ABroDdXGA4fcSspSzONWwu-IyuL4Mrpsks5qI8ajgaJpZM4IrTxx
.


cmd/compile: spurious "goto label jumps over declaration"

go version devel +4a839bf01b58 Tue May 20 15:52:08 2014 +1000 + linux/amd64

The program is:
package main
func main() {
    goto label
    type X int
    label:
}

$ go build goto.go
goto.go:3: goto label jumps over declaration of X at goto.go:4

The spec only requires new variables to not come into scope:
"Executing the "goto" statement must not cause any variables to come into
scope that were not already in scope at the point of the goto".

Fix at https://go-review.googlesource.com/#/c/9442/

I reverted the fix, since it broke all the builds.

Too late for Go 1.5.

At the risk of sounding like a fool: suppose that the next line in main in dvyukov's example is
var v X = 0

What then? I think this is a problem with the spec, and not the toolchain.

@IronGopher If the declaration were about a variable X rather than a type, then it would be a correct error. The issue is that it's only an error if variables are coming into scope, not types or constants. The spec is clear. This is a compiler bug.

CC  @griesemer @dvyukov
If i modify original program as:
package main
func main() {
    goto label
    X := 0
    label:
}

output is still:
go build t.go
# command-line-arguments
./t.go:3:10: goto label jumps over declaration of X at ./t.go:4:7

go version
go version go1.9 linux/amd64

Should  new bug be opened ?

@djadala

Should new bug be opened ?
yes

@djadala I can't reproduce https://github.com/golang/go/issues/8042#issuecomment-333481153 on tip though
$ cat main.go && go version && go build main.go  && echo "Success" || echo "Fail"
package main
func main() {
    goto label
    type X int
    label:
}
go version devel +a82ee9c Sat Sep 30 17:01:26 2017 +0000 darwin/amd64
Success

s/ type X int/ X := 0/

Never mind my last comment, your bug still stands even on the latest code @djadala :)

ok, new issue is #22101

Okay hold up though, your program isn't correct and you have made a declaration with
goto L
X := 0

A goto shouldn't allow a variable that wasn't already in scope to come into scope. I don't see the bug here.

@djadala I've commented on the other issue that this isn't a bug, and coincidentally the spec provides a similar example to what you posted
https://golang.org/ref/spec#GotoStmt
Initially I had copied and pasted the original code without checking it, but on a closer look I deduced that this isn't a bug.

Sorry for noise,
i thought if variable is not used after label, this must compile, but i'm  wrong.

Not a problem at all @djadala, thank you for checking up on the bug.


Add Mautic

ℹ Repository information
The repository has:

[x] At least three issues with the good first issue label.
[x] At least 10 contributors.
[x] Detailed setup instructions for the project.
[x] CONTRIBUTING.md
[x] Actively maintained.

List of issues: https://github.com/mautic/mautic/issues
Good first issues: https://github.com/mautic/mautic/issues?q=is%3Aissue+is%3Aopen+label%3A"good+first+issue"

Hey @RCheesley  ! I tried to contribute to this repo as well but I haven't seen any activity in the last few months. I decided to fork it to keep it alive. Please see https://github.com/lucavallin/gfi and feel free to open a pull request there. At this time I am setting up the hosting and cleaning up the code. If you're up for it, I could use some help to convert the app from Nuxt.js & Python to Next.js & Typescript.

Great - please do add Mautic if you are able, I don't have the dev skills to help unfortunately!


[Impeller] Extend coverage API for filters to allow supplying input coverage Rects

Currently, filters resolve coverage rectangles from inputs directly, but there are situations where it's convenient to be able to fetch coverage prior to assigning filter inputs. For example, with backdrop filters, the input for the filter is the parent pass texture. However, the size of the parent pass texture is in part determined by the output size of the filter itself. If its a kernel filter that may expand or contract the texture size (such as Blur and Erode), the parent pass layer should also expand or contract in size.
This circular coverage dependency can be resolved by changing the EntityPass coverage resolution to:

Compute the subpass coverage as it currently does.
Pass the unfiltered coverage rectangle through the coverage routine of the subpass backdrop filter.
Intersect with the SaveLayer bounds rect as usual, if one was given.

It should also respect clip so it could be considered to limit itself to the parent pass which means it shouldn't contribute to the parent pass size, lest it contribute to its own clip???
If it expands the parent pass size, then it is just padding its input with more transparent pixels. Perhaps that is another angle that recommends a termination of the circular bounds feedback. This might not apply if the filter is a matrix filter that turns transparent pixels non-transparent. That can happen with a MatrixImageFilter and if it does, the MatrixImageFilter typically reports that the bounds of its output is "unbounded" or "bounded only by the enclosing clip".


Firmware Dump for Feit BPPLUG/SMART/3

Dumped using LightLeak profile BK7231N Type 2 / Addr 1 Standard
I'd love to help create new profiles for this and other devices, but I don't know what to look for in the firmware files

dump_test-2.zip


rkt fly status

This is an umbrella issue for tracking the progress of the fly feature.
Features:
#1833

[x] rbind-mount /dev, /sys, /proc
[x] Make GC compatible #1856
[x] Merge mountpoints from manifest

TODO:

[ ] Merge environment from manifest
[ ] make rkt fly a synonym for `rkt run --stage1-image=stage1-fly.aci
[ ] See TODOs in commit code

Undecided:

[ ] support kind=empty mountpoints
[ ] clean error handling (move away from magic error numbers)

[ ] coreos.com/rkt/stage1/run command is inconsistent. It is /run in fly, /init otherwise. It can be changed to /run everywhere.
[ ] rework directory structure: Krzesimir had suggestions in https://github.com/coreos/rkt/pull/1833#issuecomment-163160952

@alban I suggest just editing the OP to add those bullet points
On Fri, Dec 18, 2015 at 11:32 AM, Alban Crequy<EMAIL_ADDRESS>wrote:

coreos.com/rkt/stage1/run command is inconsistent. It is /run in
fly, /init otherwise. It can be changed to /run everywhere.
rework directory structure: Krzesimir had suggestions in #1833
(comment)
https://github.com/coreos/rkt/pull/1833#issuecomment-163160952

—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/issues/1889#issuecomment-165742739.

@alban: Actually, the coreos.com/rkt/stage1/run cannot be /run everywhere, because /run is supposed to be a directory. fly is an exception, because it is not running systemd in stage1.

@krnowak oh right. We could just find another name, like "/usr/bin/rkt-run-pod" or something.

It would be nice also to have support for the eventHandlers in rkt fly, particularly for pre-start.

Hi @steveeJ do you plan to support --set-env with the new stage1?  What about setting up the $PATH before running the image?
Those were the missing features I had to work around to get Calico working in rkt.  If you're planning to add them then I'll just wait for that. Otherwise, I'll start looking at adjusting Calico's container to fit in with the new stage1.

@slallema I agree that pre-start hooks would be useful. Out of interest, what are your use-cases for this?
@fasaxc Setting environment variables on CLI and through manifest is definitely something that will be implemented.

@steveeJ : We would like to use cnt, a tool we developed, for those 'fly' containers. It's running a prestart to resolve some templates of config files and prepare the container before actually running the exec we want.

@steveeJ Great, glad to hear that environment support is in the plan.

@steveeJ can you prioritize the items in the list, and create issues for the ones relevant for 1.0?

@steveeJ what do we need here for 1.0?

I tested --set-env and "Merge environment from manifest". It works fine now. I think the remaining tasks can be moved to after.


Integration with Quirk

Suggestion
Is it feasible to integrate Qiskit with Quirk? It's used often enough that I feel it could be beneficial. Perhaps someway to import or export circuits?

I am not quite familiar with Quirk but judging by its features I believe IBM Quantum Experience also gives the provision to generate circuits using the "drag and drop" functionality and generate the corresponding code. But if Quirk gives enhanced options to play with the Quantum circuits, it is certainly worth a try.

I agree with @navaneethsdk about the circuit simulator, I think IBM Quantum have a better UI but the Quirk is way more better in terms of no. of gates and features. I think Quirk Features can be brought to IBM Quantum Simulators. That would be better.

IBM Quantum already offers the circuit composer online and as a Jupyter widget that can generate Qiskit code. I am not sure what functionality is not covered by this?

IBM Quantum already offers the circuit composer online and as a Jupyter widget that can generate Qiskit code. I am not sure what functionality is not covered by this?

In Quirk one can directly use many predefined functions like QFT and QFT inverse. There are certainly more number of Gates which are predefined in Quirk than IBM circuit composer. One can get some predefined circuits (which works as a tutorial) for different topics.Of course that can be done with IBM Circuit composer but we don't have any Circuit specific code files for tutorial purposes. I am not here to compare the features between two (Just saying).

Well then it seems like there are two possible routes to take. 1) try to integrate Quirk with Qiskit, as the composer already does or 2) add the ability to use a catalog of gates / circuits (like the Qiskit circuit library) into the current composer widget. Regardless of the choice, they are both outside of the core Qiskit mission, but would make for an interesting add-on project.

Closing as out of scope for Qiskit proper.  Looking forward to seeing this pop up as an add-on in the future.


Remove redundant write header

Write already writes 200 status code, so this wasn't needed. This caused
unneeded logging every time it was called.
Fixes https://github.com/istio/istio/issues/12726

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ff851fb4edfb06eaa180b6a93e037dec8d601d33
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ff851fb4edfb06eaa180b6a93e037dec8d601d33
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
ff851fb4edfb06eaa180b6a93e037dec8d601d33
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This should go into master.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, linsun
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I think ok for release-1.1 so users can get this fix soon in 1.1.x.


feat: Community Interaction with comment section added successfully Issue 116

Pull Request Resolves [#116]
Title: Added Comment section in style share webapp.
Description

Created comment section in frontend as well as backend.
Created Prisma schema, controllers, routes in backend.
Created Comment file and added in Post file.
API fetch and Posting comment is implemented.
Responsive design.

Related Issues
Fixes #116
Changes Made
New feature: Comment section .
Screenshots

Video
https://github.com/VaibhavArora314/StyleShare/assets/120380073/baa6cb47-22ce-48f2-819e-7394ba421ca4
I certify that I have carried out the relevant code of conduct and provided the requisite screenshot for validation by submitting this pull request.
Thank You for this contribution.

@VaibhavArora314 ok i will do it, where have you been all day ? busy day right :)

@VaibhavArora314 see now, i had implemented it ONLY VERIFIED ONE CAN COMMENT !

@VaibhavArora314 ok i will do it, where have you been all day ? busy day right :)

I have my exams going on so will take some time to review sometimes


media extension template and some refactoring

Allowing to put a template as iframe instead of just choosing heigth and width.
This allow compatibility with frameworks like bootstrap 4.
http://getbootstrap.com/docs/4.0/utilities/embed/

Could you split the real commit 77d6f42 related to this PR, and the others that are unrelated, otherwise I can't merge it. In the other, there are some changes that I don't want to be applied (even for example if a variable is not used)


illegal Windows filename characters when creating a new log file

I am facing ENOENT error, caused by illegal Windows filename characters on src/engine/logger/write-log.ts
new Date().toISOString()
'2023-11-05T14:56:17.530Z'

this fixed my issue:
from
path.join(process.cwd(), `log-${logger.getType()}-${new Date().toISOString()}.log`)

to:
path.join(process.cwd(), `log-${logger.getType()}-${new Date().toISOString().replaceAll(":",".")}.log`)

Hi @Panospan,
thanks for reporting this - a fix is on its way: https://github.com/contentful/contentful-merge/pull/527


Create Contract Page

To create a contract, you need:

a list of judges (order matters)
the price these judges will receive for mediating a conflict
the deadline they will have,
a list of inputs/questions
a service

Sources:

https://chakra-templates.dev/forms/authentication
https://choc-ui.tech/docs/forms/form-layouts

Contract Template
1.Field - Publisher,  records: ID name, CAS,     Accumulated Review Credit ()
2. Field - Service Title,
3.Field - Service Description
records: Details , Estimated Duration (hours/days)
4. Field – Price , record: per hour or service in DSET unit or different unit to edit
5. Field – TrustToken in DSET
6 . Judge Selection (**)
(): Accumulated Review Credit over the last 12 months
(**): in case of Mediation
Contract Example

Publisher: #101 IoT_Solutions  records: ID name, CAS: 70,000,Accumulated Review Credit (: 10,000
Service Title: IoT Design for household devices
Service Description – Details: Wireless connection of all desired household appliances to command, control and collect usage data;  Estimated Duration (hours/days) : 5 days based on 5 appliances, provided hardware is compatible for IoT solutions
Price: 100 DSET per appliance
TustToken: 10 DSET per appliance
6 . Judge Selection : Robin

We shall need also a common template common to all contracts, in which we have following fields
No. of questions Publisher   ---- Publisher shall enter a number
No. of questions Client     ---- Client shall enter a number
Publisher
Question 1
Question 2
Question 3
….
Client
Question 1
Question 2
Question 3


Missing 2.0 in https://github.com/JadenGeller/Helium/releases

Missing Version 2.0 in https://github.com/JadenGeller/Helium/releases
in MAS is Version 2.0 available

and much more releases since 2015 ;)

Still not corrected.
MacUpdate also lists v2.0.
The project’s release page should be updated - a lot of people hate MAS.

How we can get the update app, from github repo?

As I said, 2.0 is available on MacUpdate, so you can get it there if you refuse to use MAS.
https://www.macupdate.com/app/mac/53937/helium


Updated DEVELOPMENT instructions

This change is

Coverage decreased (-0.08%) to 55.857% when pulling c96230685fd8755ca0b3d29cad681ba9169d6568 on saturnism:update-dev-doc into 882cc2d33d00817301f3f357be635d9742c70f52 on jdeferred:master.


AZ Pull

Not sure how to handle sub-domains, but Geometry Dash is the first sub-domain wiki that wasn't english forked. https://geometrydash.wiki.gg/es/wiki/Wiki_Geometry_Dash

ULTRAKILL was also added to this change


FileService.watch fails if given resource does not exists

Assume that a resource is being watched at multiple locations in code.

Resource does not exist

Location 1: Watch on the resource.

Location 2: watch on the resource.

Location 1: Stop watching. Create the resource. Start watching

Open resource and change the content.

🐛 No change events are triggered

I am closing this as designed, as discussed the contract on the caller is that the file/folder must exist.


Compilation error w/ OpenCV2 file

/usr/include/opencv2/contrib/contrib.hpp:273:23: error: ‘vector’ does not name a type
         Octree( const vector<Point3f>& points, int maxLevels = 10, int minPoints = 20 );

I'm just doing cmake .. and then make from a build sub-folder, but the make crashes fairly quickly with the above error. I have all dependencies installed including opencv2 and opencv3.

Hm.. It seems OpenCV bug. Anyway removed opencv2/contrib/contrib.hpp include

Hm.. It seems OpenCV bug. Anyway I removed #include opencv2/contrib/contrib.hpp and this should fix it.

Fixed. Thanks!


remove deps

Removes stringr (which depends on the very large stringi package) from Imports to Suggests.
Replaces the cut2() function from Hmisc (which has lots of dependencies including stringr and stringi) with the functionally identical cutf2() from the cutr package.

By removing stringi as a recursive dependency, the total Travis build time is reduced from ~1 h to ~10 min. Also reducing camprotR dependencies to a minimum is probably a good idea in general.

Thanks @csdaw! Yes, removing dependencies is definitely a good idea. Feel free to merge if it's ready.

Thanks @csdaw! Yes, removing dependencies is definitely a good idea. Feel free to merge if it's ready.


Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of ConnectionInterface, instance of React\Socket\Connection given

After running my server socket, I try to connect to them by javascript client. I get the error when I run my client.
index.php:
<?php
require 'vendor/autoload.php';

$loop = React\EventLoop\Factory::create();
$socket = new React\Socket\Server('<IP_ADDRESS>:8080', $loop);

$socket->on('connection', function (ConnectionInterface $conn) {
    $conn->write("Hello " . $conn->getRemoteAddress() . "!\n");
    $conn->write("Welcome to this amazing server!\n");
    $conn->write("Here's a tip: don't say anything.\n");

    $conn->on('data', function ($data) use ($conn) {
        $conn->close();
    });
});

$loop->run();

index.html:
<script>

var socket = new WebSocket('ws://localhost:8080');

// Open the socket
socket.onopen = function(event) {
    var msg = 'I am the client.';

    console.log('socket opened!');

    console.log('> ' + msg);

    // Send an initial message
    socket.send(msg);

    // Listen for messages
    socket.onmessage = function(event) {
        console.log('< ' + event.data);
        socket.close();
    };

    // Listen for socket closes
    socket.onclose = function(event) {
        console.log('Client notified socket has closed', event);
    };

    // To close the socket....
    //socket.close()

};

</script>

I get the following errors:
Fatal error: Uncaught TypeError: Argument 1 passed to {closure}() must be an instance of ConnectionInterface, instance of React\Socket\Connection given, called in C:\wamp64\www\socket-react\vendor\evenement\evenement\src\Evenement\EventEmitterTrait.php on line 123 and defined in C:\wamp64\www\socket-react\index.php:6
Stack trace:
#0 C:\wamp64\www\socket-react\vendor\evenement\evenement\src\Evenement\EventEmitterTrait.php(123): {closure}(Object(React\Socket\Connection))
#1 C:\wamp64\www\socket-react\vendor\react\socket\src\Server.php(47): Evenement\EventEmitter->emit('connection', Array)
#2 C:\wamp64\www\socket-react\vendor\evenement\evenement\src\Evenement\EventEmitterTrait.php(123): React\Socket\Server->React\Socket\{closure}(Object(React\Socket\Connection))
#3 C:\wamp64\www\socket-react\vendor\react\socket\src\TcpServer.php(233): Evenement\EventEmitter->emit('connection', Array)
#4 C:\wamp64\www\socket-react\vendor\react\socket\src\TcpServer.php(213): React\Socket\TcpServer->handleConnection(Resource id #25)
#5 C:\wamp6 in C:\wamp64\www\socket-react\index.php on line 6

Hey @vahidvdn looks like you didn't import the ConnectionInterface in your file or used the FQIN (React\Socket\ConnectionInterface) in your callable. By the looks of it you copied that code directly from our readme and we didn't include it there. I'll open a PR shortly resolving that.
Also it looks like you want to use websockets, this package does TCP sockets where HTTP and then websockets are build on top, we suggest https://github.com/ratchetphp/Ratchet for serving websockets.

Hi @WyriHaximus. Thanks for the response. Yeah I forgot to import the ConnectionInterface by mistake. Now in client side I get the following error:
WebSocket connection to 'ws://localhost:8080/' failed: Error during WebSocket handshake: net::ERR_INVALID_HTTP_RESPONSE

Btw, I going to test your mentioned package for  serving websockets. Thanks.


Song Information & Albumart missing

Description
I don't when it happened but I just noticed it. I no longer have the Albumart showing nor the Songinfo just N/A. Controls and Visualization are still working fine. I'm kind of clueless here.
Versions

Rainmeter Version: 4.2.0 r3111 64bit
OS Version: Windows 10 64bit 1803
Skin Version: 2.0.2
Spotify Version: <IP_ADDRESS>1.ge2a121fc

I also have the same problem, clean install as well.

Duplicate of #191.


Add option to allow Fabio to register frontend services in Consul on behalf of user services

We would like to have Fabio re-register itself in Consul under user-specified names, so that users can access their services through Fabio via Consul-provided A records. The motivation for this is:

Users can immediately access their service "foo" directly at foo.service.example.com using Consul DNS
Users do not need to create CNAMES to Fabio for their service in an external DNS system, e.g. foo.example.com IN CNAME fabio.service.example.com
The service will be reachable via a DNS health-checked A record so that Kerberos auth in browsers will work correctly with a Kerberos principal unique to the user's service name. Currently this fails if the service is accessed via a CNAME to Fabio, unless principals are made too generically to match (e.g.) fabio.service.example.com.

The intended usage is that users will give their service a backend-specific name, and pass to Fabio the name they wish to use for the front end via a new "alias" option. For example:
    "ServiceName": "foo-backend",
    "ServiceTags": [
        "urlprefix-foo.service.example.com/ alias=foo",
        "urlprefix-foo/"
    ],

Fabio then registers new service foo.service.example.com with its own host and port information and creates routes "foo.service.example.com/" and "foo/" to foo-backend.service.example.com as usual.

Thanks @magiconair. I tried to address your feedback with these changes:

removed UpdateAliases() and moved parse code to ParseAliases() in route/parse_new.go. Implements a subset of Parse(), so there is some redundancy. Better to just call Parse()?. Had to import config to check if fabio should register itself. Can't get that from the private config member of the backend. Brought in log for some visibility.
Added DeregisterAll(), but kept Deregister() for single deregistrations. I wasn't sure if that's what you had in mind.
Extended Register() to handle removal and addition of aliases.
Changed option name to register (much better :)
Still tracking registered services in b.dereg map. Is that OK? Wasn't clear on "you need to keep the state of what is registered in the backend anyway"

I had a couple of questions while working on this:

Would you be OK with adding "DeregisterCriticalServiceAfter" to registrations so that if fabio exits uncleanly, Consul will clean up services? That was added in Consul 0.7.0, not sure if you have a minimum support Consul version or we could check version with the API before including that option.
Any concerns about duplicate health checks? Would be nice if Consul allowed you to specify an existing health check when registering a service. I can open a feature request against Consul.
Do you have any thoughts on test coverage for Register() and Deregister(All)()?

I see the Travis CI build failed, I'll look in to that.

The Consul API does allow you to pass existing checks via the AgentServiceRegistration struct via the Checks element which references AgentServiceChecks which is a slice of pointers to AgentServiceCheck.

You may be able to register existing services and checks with CatalogRegistration but I'm not sure that has the intended result.  I'll check locally and see how it works.

I think adding DeregisterCriticalServiceAfter with a sane default makes sense. Can you please add that as a separate commit within this PR?

Ah, and please add some tests to https://github.com/fabiolb/fabio/blob/master/route/parse_test.go

@magiconair here is the latest version of the patch.

Updated Commands const to included register. I noticed that host was missing and took the liberty of adding it.
Updated docs to include register option.
Removed config check from ParseAliases() and moved it to Consul backend
Added comment for ParseAliases()
Added tests for ParseAliases()
Removed unneeded magic value from Deregister()
Factored out excess indents
Cleaned up logging statements
Added DeregisterCriticalServiceAfter as a separate commit. Used the 90m default from Consul docs. Not sure if that fits your definition of sane :) We will likely set it to something much shorter in production.

I think this is good enough as is. Thanks a lot!

Great, thank you!


golint suggests removing else illegally even when it is necessary.

golint warns for code like this:
    if v, ok := aMap[key]; !ok {
        return
    } else {
        // code use v
    }

The warning says "if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)", but of course else cannot be removed here.

move short variable declaration to its own line if necessary

Thank you.

move short variable declaration to its own line if necessary

Doing so will enlarge the variable scope, which may break codes.
I think it is arguable which is better:

to outdent a block in exchange for wider scope, or
to narrow variable scopes in exchange for an else block.

In case else block has just 1 or 2 lines of code, having
short variable declaration and else block is not so bad.

The established Go style is what golint suggests, even if that isn't your preference.

@dominikh @dsymonds
Just to clarify, I can fix the code as follows:
    if v, ok := aMap[key]; ok {
        // code use v
    } else {
        return
    }

But I don't understand why this is OK for golint while the first is not.
Is this intended behavior?
A real-world example is here.
https://github.com/cybozu-go/goma/commit/cfded2d3d7bcf0f56fbb02836300b838da55c371#diff-ad79469688b87932daa9a5969430cc26

Golint doesn't try to catch every possible situation. Your code isn't "broken", it just doesn't follow the standard Go style, which would be to write
v, ok := aMap[key]
if !ok {
  return
}
// use v

@dsymonds
I see.  Thank you!


[Bug]: Resource dependency for IAM in terraform destroy

Welcome to Amazon SSP EKS Accelerator!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Amazon EKS Accelerator Release version
v3.2.2
What is your environment, configuration and the example used?
When deleting example with
cd aws-eks-accelerator-for-terraform/examples/observability/eks-cluster-with-amp-amg-opensearch
terraform destroy -var-file=dev.tfvars

What did you do and What did you see instead?
Got an error on
│ Error: error deleting IAM policy arn:aws:iam::xxx:policy/fluentbit-opensearch-access: DeleteConflict: Cannot delete a policy attached to entities.
│       status code: 409, request id: 1e141617-559c-4585-93d6-8e7dad974aeb
│

Additional Information
No response

@bonclay7 I wasn't able to reproduce the exact same failure you reported, few questions/notes:

Release version 3.2.2 doesn't have the observability example, any chance you ran against main branch?
Running the example using main branch, TF destroy failed with the following error message:

│ Error: error waiting for IAM Service Linked Role (arn:aws:iam::<my_account>:role/aws-service-role/es.amazonaws.com/AWSServiceRoleForAmazonElasticsearchService) delete: unexpected state 'FAILED', wanted target 'SUCCEEDED'. last error: %!s(<nil>)
│
│

I could also see the error on the IAM console deletion failed, I believe a proper dependency (either explicit depends_on or implicit) should be added between the linked service and the relevant resources (opensearch mainly) for a cleaner destroy process, as you first must destroy all the linked resources before the IAM role itself.
Shared this with the rest of the team, will create a PR to address this soon.

Following to point 2, can you please check if the reported policy (policy/fluentbit-opensearch-access) was added to other IAM roles outside of this TF example?

Thanks a lot @Zvikan, and yes that was the main branch

Closing the issue as fix merged


removed extra main tag

Fixes Issue
Closes #4224
Changes proposed
Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[  ] My change requires changes to the documentation.
[  ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
Extra main tag is removed

Thank you for the contribution.
It looks like you have used npm install instead of npm ci from the docs, this causes the generated file package-lock.json to be updated, this is not a problem but these should not be committed without specific changes to package.json.
https://linkfree.eddiehub.io/docs/environments/local-development
Please remove the unrequired changes with:

git checkout main -- package-lock.json

It is always best to check file changed with git status -s before doing a commit and never use . in your git commands as this will include files you may not want.
Any questions come and ask in the EddieHub Discord http://discord.eddiehub.org

ok i will take care of all this from now

Here i made a new fresh PR: #4317

Please close this PR if it is no longer needed

I


API versioning for OSAL

The OSAL version ID e.g. "<IP_ADDRESS>" can also be used by application code to determine API features in case they change over time.
Although the existing OSAL API is intended to remain stable across versions, new calls can (and should) be added when appropriate.  However this presents a problem for backward compatibility as new code written against a new API cannot be compiled with an older version of OSAL.
This is a common problem and is generally solvable by creating/checking a version macro.  For example, glibc uses "POSIX_C_SOURCE" as an integer to define which version of POSIX it should behave like.
The OSAL should do the same, and create an "OSAL_API_VERSION" macro that application code can check to see what version of the API the current OSAL supports.  Application code can then adjust itself accordingly, either by compiling without the new feature or generate a compile error if that feature is required.

Imported from trac issue 10.  Created by jphickey on 2015-01-06T10:24:30, last modified: 2015-11-20T16:22:16

Trac comment by jphickey on 2015-01-06 11:29:55:
Pushed branch "trac-10-os_api_version_indicator" (commit [changeset:1ad9f81]) to reflect this change.
This adds an OS_API_VERSION macro that application code can check.  This is 5-digit number where the most significant digit is the major (4), the next 2 digits are minor (01) and the least significant 2 are the revision.
For example, code that needs OSAL 4.1.1 or better can do:
{{{
#if OS_API_VERSION >= 40101

#endif
}}}
This commit also changes the OS_REVISION to "91" to indicate that this is a development version of the OSAL but not yet 4.2.0.

Trac comment by glimes on 2015-01-29 15:13:30:
Click [changeset:1ad9f81 here] to see the changeset.

Trac comment by mlogan on 2015-01-30 19:24:14:
I also ACCEPT the change.

Trac comment by glimes on 2015-01-29 15:47:17:
I have reviewed this change, and recommend ACCEPT.
It would be quite silly for any existing code to conflict with this change.

Trac comment by jwilmot on 2015-02-11 12:44:09:
Makes sense. ACCEPT  Should we have a convention where the OS_REVISION dotted notation means something? A.B.C  A means existing APIs have changed. B means new APIs added, C is bug fixes.

Trac comment by dheater on 2015-02-03 18:32:52:
ACCEPT

Trac comment by acudmore on 2015-02-11 14:36:34:
I ACCEPT the specific changes, but would like to make sure all of the version numbers are treated the same way through the product line. The current practice in the cFE and cFS applications is to change the version to <IP_ADDRESS> on the head of the CM system so it can be determined that a un-released version is being used. I have not followed that practice with the OSAL, and I'm not crazy about it.
RTEMS does something similar to this change where the current head is <IP_ADDRESS> ( will become <IP_ADDRESS> )

Trac comment by jphickey on 2015-02-11 13:22:47:
The A.B.C revision notation should be something meaningful, but the major problem is that (as I understand) changing "A" necessitates going through the full NOSA release process again, so it must be reserved for those types of major changes that will really require modification of user application code.  Many times an API can change and still be compatible with existing application source code, which I don't think should require changing the "A" number.
Alternatively a new replacement API can be added while deprecating the old one - this is actually the precise reason for this addition, so that application code can utilize a new API that appeared after a certain version, otherwise do some workaround for the lack of the new API.  This way we only need to bump the "B" number and it just makes life easier for everyone using it.

Trac comment by glimes on 2015-03-04 15:17:38:
Confirmed that the fix from [changeset:1ad9f81] is present in the
current development branch of OSAL, [changeset:5aae372], defining
the current version as "4.1.91" using OS_REVISION=91.


Diet app

Description
Create a
login screen
register screen
Home screen
Settings screen
Screenshots
No response
Additional information
No response

I am a GSSOC'22 participant and would love to work on this issue.

Hi @naveeramesh I am a GSSOC'22 contributer. Can I work on Login screen?

Yes you can carry on the work

I can work on home screen

can I work on register and settings screen?

I can work on home screen

Yeah you can

Hii @naveeramesh, I'm a GSSOC'22 contributor can I work on the register and settings screen?

Yeah you can

Hi @naveeramesh, I am a GSSOC'22 contributor and a beginner in open source. Can I work on Login screen?

@ayush-1601 yeah you can

Hi @naveeramesh, I am a GSSOC'22 contributor. Can I work on Register Screen and Login screen?

Hi @naveeramesh, I am a GSSOC'22 contributor. Can I work on Register Screen and Login screen?

Yeah you can

@naveeramesh  please assign me this issue

@naveeramesh , I guess it'll be a better idea to have a user profile screen in this app too? Can you add description for it? Or profile screen is not needed??


[Exclusivity] Support exclusivity checks originating from block arguments

This includes:

Not crashing in AccessEnforcementOpts in case we have an Unidentified storage access - rdar://problem/45956642 and rdar://problem/45956777
Actually supporting finding the storage locations if we do begin_access
Test case for said support

cherry-pick of https://github.com/apple/swift/pull/20522 for 5.0 branch per the offline discussion with @AnnaZaks and @atrick

@swift-ci Please smoke test OS X

Closing - will only merge to master per the new discussion


Log number of steps in execution

We should log the number of steps after execution or proving. The log entry should have info severity.

We can add a field to ProofState which tracks the current execution depth. The field will be incremented whenever a semantic rule is applied. We can log the final execution length of any unproven configuration, or the longest proven claim (in case the proof is successful).


Add presubmit test for canary upgrade

Not sure if there is already a presubmit check or not for canary upgrade, but https://github.com/istio/istio/issues/28189 suggests it unlikely exists. We should add a smoke test to prevent this kind of issue. cc @ostromart @sdake

It seems to be hard to add presubmit test between different versions, specifically between different minor releases. That's why we define upgrade/downgrade test(canary or rolling upgrade, the canary one was recently added) as periodic job running on a real gke clusters. But the problem with that is it does not get enough attention and it is not stable enough. Are you currently maintaining that? @carolynhu

right, this is under maintaining https://github.com/istio/tools/tree/master/upgrade_downgrade


Cannot scan yarn projects

Describe the bug
I can't scan yarn projects
To Reproduce
Given the Jenkins pipeline:
pipeline {
    agent {
        docker {
            image 'node:16'
        }
    }

    parameters {
        string name: 'project', trim: true, description: 'Bitbucket project'
        string name: 'repo', trim:true, description: 'Bitbucket repository'
        string name: 'deps_cmd', trim:true, description: 'The command that installs the project dependencies'
        booleanParam name: 'all_vulns', description: 'Displays all existing vulnerabilities'
    }

    environment {
        JF_ACCESS_TOKEN=credentials("JF_ACCESS_TOKEN_XRAY")
        JF_GIT_API_ENDPOINT="https://bitbucket.redacted.org/rest"
        JF_GIT_PROVIDER="bitbucketServer"
        JF_GIT_TOKEN=credentials("JF_GIT_TOKEN")
        JF_URL=credentials("JF_URL")
    }

   stages {
        stage('Download Frogbot') {
            steps {
                sh """curl -fLg "https://releases.jfrog.io/artifactory/frogbot/v2/2.1.3/getFrogbot.sh" | sh"""
            }
        }

        stage ('Scan Pull Requests') {
            steps {
                withEnv(["JF_INSTALL_DEPS_CMD=$params.deps_cmd",
                         "JF_GIT_OWNER=$params.project",
                         "JF_GIT_REPO=$params.repo",
                         "JF_INCLUDE_ALL_VULNERABILITIES=$params.all_vulns"]) {
                    sh "./frogbot scan-pull-requests"
                }
            }
        }
    }
}

parameter JF_INSTALL_DEPS_CMD is yarn install
Getting this error output:
+ ./frogbot scan-pull-requests
13:06:43 [Info] Running Frogbot "scan-pull-requests" command
13:06:45 [Info] Auditing /tmp/jfrog.cli.temp.-1658322404-2045215346
13:06:45 [Info] Executing 'yarn' [install] at  /tmp/jfrog.cli.temp.-1658322404-2045215346
13:09:11 [Info] Detected: Yarn.
panic: runtime error: slice bounds out of range [1:0]

goroutine 1 [running]:
github.com/jfrog/build-info-go/build/utils.(*YarnDependency).Name(...)
	/root/go/pkg/mod/github.com/jfrog/build-info-go@v1.3.1-0.20220620130614-83dda95caddf/build/utils/yarn.go:183
github.com/jfrog/jfrog-cli-core/v2/xray/audit/yarn.getXrayDependencyId(0x0)
	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.16.1-0.20220621124242-4fe813879da6/xray/audit/yarn/yarn.go:67 +0xb5
github.com/jfrog/jfrog-cli-core/v2/xray/audit/yarn.parseYarnDependenciesMap(0xc00003c150, 0x100b0b8)
	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.16.1-0.20220621124242-4fe813879da6/xray/audit/yarn/yarn.go:54 +0x10c
github.com/jfrog/jfrog-cli-core/v2/xray/audit/yarn.buildYarnDependencyTree()
	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.16.1-0.20220621124242-4fe813879da6/xray/audit/yarn/yarn.go:46 +0xf7
github.com/jfrog/jfrog-cli-core/v2/xray/audit/yarn.AuditYarn({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xe8412e, 0xa}, 0x0, ...}, ...)
	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.16.1-0.20220621124242-4fe813879da6/xray/audit/yarn/yarn.go:18 +0x33
github.com/jfrog/jfrog-cli-core/v2/xray/commands/audit/generic.GenericAudit({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xe8412e, 0xa}, 0x0, ...}, ...)
	/root/go/pkg/mod/github.com/jfrog/jfrog-cli-core/v2@v2.16.1-0.20220621124242-4fe813879da6/xray/commands/audit/generic/auditmanager.go:42 +0x3a5
github.com/jfrog/frogbot/commands.runInstallAndAudit({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xe8412e, 0xa}, 0x0, ...}, ...)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequest.go:178 +0x1db
github.com/jfrog/frogbot/commands.auditSource({{0x0, 0x0}, {0x0, 0x0}, {0x0, 0x0, 0x0}, {0xe8412e, 0xa}, 0x0, ...}, ...)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequest.go:122 +0x192
github.com/jfrog/frogbot/commands.scanPullRequest(0xc0004a3558, {0x101d2a0, 0xc00029a6c0})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequest.go:38 +0xec
github.com/jfrog/frogbot/commands.downloadAndScanPullRequest({0x30, {{0xc0000d3780, 0x36}, {0xc0002dae44, 0x9}}, {{0xc0002daf50, 0xf}, {0xc0002daf94, 0x9}}}, 0xc0000d4800, ...)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequests.go:130 +0x3ed
github.com/jfrog/frogbot/commands.scanAllPullRequests(0xc0000d4800, {0x101d2a0, 0xc00029a6c0})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequests.go:37 +0x297
github.com/jfrog/frogbot/commands.ScanAllPullRequestsCmd.Run(...)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/scanpullrequests.go:17
github.com/jfrog/frogbot/commands.Exec({0xff55c0, 0x1716828}, {0xe9c913, 0xc000280880})
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/commands.go:28 +0x1d5
github.com/jfrog/frogbot/commands.GetCommands.func3(0xc0002e6360)
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/commands/commands.go:62 +0x32
github.com/urfave/cli/v2.(*Command).Run(0xc0002e6360, 0xc0002807c0)
	/root/go/pkg/mod/github.com/urfave/cli/v2@v2.10.2/command.go:169 +0x6be
github.com/urfave/cli/v2.(*App).RunContext(0xc000133380, {0x1006f10, 0xc0000c4000}, {0xc0000b4000, 0x2, 0x2})
	/root/go/pkg/mod/github.com/urfave/cli/v2@v2.10.2/app.go:341 +0x89c
github.com/urfave/cli/v2.(*App).Run(...)
	/root/go/pkg/mod/github.com/urfave/cli/v2@v2.10.2/app.go:247
main.ExecMain()
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/main.go:27 +0x158
main.main()
	/var/opt/jfrog/pipelines/data/release_frogbot/runs/954228/steps/Release/7407400/dependencyState/resources/frogbotGit/main.go:16 +0x1e

Other projects (golang, java) can be scanned normally (with their specific docker agent).
Expected behavior
yarn projects can be scanned.
Versions

Frogbot version: 2.1.3
Operating system: linux
JFrog Artifactory version: 7.37.14
JFrog Xray version (version 3.29.0 or above is required): 3.52.4

@lorsatti Thanks for the report! To investigate this, could you please mention the Yarn version you use?

@asafgabai Hi! Yarn is 1.22.19. This is the one contained in the node docker image.

Hi, I have the same issue.
Do you know when it will be solved?

We're working hard on improving Frogbot and have a long list of features and improvements which we're gradually introducing. Support of Yarn 1 is one of them. We're planning to introduce Yarn 1 support in the future.


Alternative tabbable implementation

I like to suggest this alternative solution for tabbable / vertical tabs for version 2.0. It's based on the vertical tabs implementation I'd written for 1.4 and not based on the tabbable currently in 2.0. (Loving what you're doing with 2.0 by the way :D)
I've rewritten my version, so the HTML syntax it almost the same as the current implementation. I also tried to make to use existing classes as much as possible instead of introducing new ones and in general make tabbable follow the bootstrap logic.
Please have a look at http://jasny.github.com/bootstrap/components.html#navigation
This implementation got some advantages:

Placing tabs in a tabbable doesn't border it by default, giving you the ability to place the tabs above, below, left of right with the current look for tabs.
You can optionally put a border around the tabs using .bordered-tabbable
The borders of a .bordered-tabbable are rounded.
Vertical tabs (without borders) always look good, no-mater if the content is smaller than the tabs. (A bordered vertical tabbable with little content still looks strange.)
There is no need to specify .above, .below in .tabbable. Putting the tabs below the content will automatically change the orientation of the tabs.
Instead of putting .left and .right in .tabbable, you may use .pull-left and .pull-right on .tabs.
If the text is to long for vertical tabs, it will wrap nicely.
You may resize vertical tabs using the known .spanX syntax on .tabs.

Please let me know your thoughts about this. Thanks in advance :)

Shouldn't tabs with .danger' or .success` classes have a colored border, too? So far they are still gray and that doesn't look so well, IMO.

@pokonski Do you mean when the tabs is active? The grey border is part of the whole tab element. I don't think that should change color.
Perhaps it better to take that out of this branch (and pull request), since it's something I want to use, but isn't necessarily part of this tabbable impementation.

@pokonski I've removed the .danger and .success from this pull request. It's an additional feature on itself, which may or may not be useful (to others).
https://github.com/jasny/bootstrap/tree/2.0-tabs-color

Will keep an eye on that, thanks for info ;)

+1

Great feedback all around. I can see some of the advantages of this. I've gone ahead and rewritten all of our tabs, pills, and common nav styles. Here's what's new:

All tabs and pills require a new base class, .nav
We still require the .tabs-bottom etc for easier and more straightforward styling. It makes each direction super consistent and keeps the components isolated from other parts of the toolkit.
I removed the borders from the other edges—only the border on the .tabs is added by default now.

Check it out in the latest 2.0-wip. Thanks again for the feedback :).

sigh You're making my life very hard here Mark, by reimplementing almost all my pull requests in a slightly different way. Merging is becoming a real pain. :(


squeue fails if a job id is passed to -j for a job that is not in…

… the
queue (any more). Because we cannot guarantee that the query intervals are smaller than the intervals at which jobs get purged from the queue, failed squeue invocations can happen.
This change replaces the -j option with --me, which lists all jobs for a user. This has the potential of listing more jobs than necessary (since a user can have multiple PSI/J instances managing jobs).

Thank you @andre-merzky!


Change filename for CSV table downloads on gene page

Observed Behaviour
When a user downloads a table on the gene page (e.g. PCSK9), the downloaded file name is undefined.csv.
Expected behaviour
When a user downloads a table from the gene page, the filename should contain the HGNC symbol. Perhaps the filename could be ESR1_associated_studies.csv?

@andrewhercules @edm1 should be fixed now.


Bindings being overwritten

Hello, I have the following bindings set in my config:
book_id,12|scan_id,14

Correctly, the LaravelGenerator.php is giving me the integer ids instead of the {book_id} etc. placeholders.
However when viewing the docs afterwards, the ids have been overwritten, and I get the following request instead:
curl "http://bookscanner.dev/api/server/scans/{book_id}" \
-H "Accept: application/json" \
    -d "book_id"="49166501" \

@JapSeyz what was the resolution? I have the same issue


blockly implementation

Hello
I would like to know how did you manage to implement without having the error cannot use import outside a module as written in the forum that you launched a year ago
Thanks for your answer in advance
Cordially

I have updated my answer in https://github.com/nbudin/react-blockly/issues/71#issuecomment-1188935219 to point to the correct file. You can copy my solution and adapt it to your use case


Regarding Integration in dapp

I have developed a dapp using Truffle Framework.I am trying to integrate wallet for other users to pay ether in my dapp.How can i integrate the wallet in my dapp??

You're going to want to encourage users to use MetaMask or Mist.
Dapps should not be managing keys / wallets for users. #trustless

Anyother way to integrate wallet interface in dapp?

Instead of thinking about adding a wallet to the Dapp, think about it like adding the Dapp to the wallet. Please take a look at the links I provided. Both are trusted applications that allow users to have a wallet and interact with your dapp.

Okay..
Send me the links...

https://metamask.io/
https://github.com/ethereum/mist/releases

Okay ..Thankyou


Deal with invalidation parallelism-induced memleak

This is just a port of the exact same fix that was implemented in the old cache, adapted for chunks.
And with, we are now leak free for both long-running latest and range workloads!
Long running face_tracking (latest-at):

Long running plot_dashboard_stress (range):

DNM: requires https://github.com/rerun-io/rerun/pull/7181

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

@rerun-bot full-check


Added Directory badges

Hi,
These badges will make your component listing accessible for our Directory users. For more information on how to generate these badges, head to this guide.
Regards,
Binh

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Include .NET Core SDK in Dockerfile

Can you run docker images and check the size difference between the one with this change vs image version 0.4.10?

Will do in the morning. I expect it'll be a pretty large size difference, to be honest - the SDK isn't small...

Before: 2.21GB
After: 2.796GB
So yes, it's pretty significant I'm afraid.

It's fine if that is the minimal installation requirement already. Please add a comment in the Dockerfile about the size increase. Luke once suggested shipping different artman docker images for each languages. We can consider that option if necessary.

Just tried it without the first dotnet call, and it's down to 2.495GB, which is a bit more reasonable. Will amend the commit...

Done, PTAL.