Add RSpec/NoExpectationExample

This cop checks that each example has any expectation.
Example
# bad
it do
  a?
end

# good
it do
  expect(a?).to be_truthy
end

Background
Trying it out on my Rails project, I found the following bad cases by this Cop:
it do
end

it 'succeeds' do
  subject
end

xit 'returns 200' do
end

then I corrected the code like this:
- it do
- end

it 'succeeds' do
-   subject
+   expect { subject }.not_to raise_error
end

- xit 'returns 200' do
- end
+ xit 'returns 200'

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop is configured as Enabled: pending in config/default.yml.
[x] The cop is configured as Enabled: true in .rubocop.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.
[x] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

[ ] Set VersionChanged in config/default.yml to the next major version.

Sorry I haven't read the related issues at all. I see that we had the same discussion a few days ago and even 10 years ago. It's just a coincidence that I created this pull request today.

https://github.com/rspec/rspec-core/issues/759
https://github.com/rubocop/rubocop-rspec/issues/208
https://github.com/rubocop/rubocop-rspec/issues/1319

Thanks for the review comments! I learned a lot of information I didn't know 👍
I have made some improvements and hope you will take another look.

I don't feel that this cop should implement autocorrection. WDYT?

I'm on the fence about that.
RSpec/EmptyExampleGroup, which has a similar concept, implements autocorrection, so I thought it might be a good idea for this cop to do the same. Sometimes this autocorrection is useful, sometimes it is not. This cop is marked as Safe: false, so it will not be unintentionally autocorrected unless users force it. But thoughtlessly erasing the code is indeed dangerous...
I actually used this cop's autocorrection in my Rails app because I had to change a large amount of code there, but I am thinking that maybe this autocorrection should be removed.

RSpec/EmptyExampleGroup, which has a similar concept, implements autocorrection, so I thought it might be a good idea for this cop to do the same

I think an empty example group has more chances to be a deliberate choice than the no expectations one. The latter is most likely a mistake.
For me, removing the empty example group doesn't seem to be an ideal autocorrection. But for the no expectations, it isn't for sure. Taking example from the NoExpectations ticket:
it { subject } # Just checks if calling `subject` doesn't raise any exceptions

it { validates_presence_of(:attribute) } # Oops, missing `is_expected.to`

It would be quite odd to remove those examples.

This cop is marked as Safe: false

I have to agree with this, unfortunately, with the Safe definition as "indicates whether the cop can yield false positives (by design) or not". It is unfortunate, though, that this cop would in most cases won't be run, and won't detect legitimate offences. Sadly, I don't have an idea how to overcome this.

that maybe this autocorrection should be removed

I fully support that.
Let me quickly run the cop against several codebases in real-world-rspec to see how severe and frequent false positives are.

57497 files inspected, 24233 offenses detected

I briefly went through, and tried categorizing cases that look like false positive/suspicious:

Legacy RSpec expectation notation:

# /Users/pirj/source/real-world-rspec/loomio/spec/models/user_spec.rb
    it "returns the stored name if deactivated_at is nil" do
      user.name.should_not == 'Deleted user'
    end

# /Users/pirj/source/real-world-rspec/rspec-mocks/spec/rspec/mocks/configuration_spec.rb
          it "does not warn about the should syntax" do
            RSpec.should_not_receive(:deprecate)
            Object.new.should_not_receive(:bees)
          end

Might be legitimate offences

# /Users/pirj/source/real-world-rspec/mastodon/spec/controllers/auth/registrations_controller_spec.rb
    it 'does nothing if user already exists' do
      Fabricate(:account, username: 'test')
      subject # Frankly, I'm struggling to understand where `subject` is defined
    end

# /Users/pirj/source/real-world-rspec/refinerycms/pages/spec/models/refinery/page_meta_data_spec.rb
      it 'meta_description' do
        page.respond_to?(:meta_description) # should be `expect(page).to respond_to(:meta_description)` ?
      end

Expectation helper method

    it 'tracks when sign in is nil' do
      user.update(current_sign_in_at: nil)
      sign_in user, scope: :user
      get :show

      expect_updated_sign_in_at(user)
    end

Skipped examples

      it "updates the requested expense" do
        expense = Expense.create! valid_attributes
        put :update, {:id => expense.to_param, :expense => new_attributes}, valid_session
        expense.reload
        skip("Add assertions for updated state")
      end

Rails/Minitest-style assertions

# /Users/pirj/source/real-world-rspec/publify/publify_core/spec/controllers/admin/articles_controller_spec.rb
      it "sends notifications on create" do
        u = create(:user, notify_via_email: true, notify_on_new_articles: true)
        u.save!
        ActionMailer::Base.deliveries.clear
        emails = ActionMailer::Base.deliveries

        post :create, params: { "article" => base_article }

        assert_equal(1, emails.size)
        assert_equal(u.email, emails.first.to[0])
      end

Alternative mocking library (e.g. Mocha)

# /Users/pirj/source/real-world-rspec/puppet/acceptance/lib/puppet/acceptance/classifier_utils_spec.rb
  it "provides a handle to the classifier service" do
    handle.expects(:perform_request).with(Net::HTTP::Get, '/hi', {})
    handle.get('/hi')
  end

No explicit expect { ... }.not_to raise_error

# /Users/pirj/source/real-world-rspec/rspec-core/spec/rspec/core/backtrace_formatter_spec.rb
      it "deals gracefully with a security error" do
        Metadata.instance_eval { @relative_path_regex = nil }
        with_safe_set_to_level_that_triggers_security_errors do
          self.formatter.__send__(:backtrace_line, __FILE__)
          # on some rubies, this doesn't raise a SecurityError; this test just
          # assures that if it *does* raise an error, the error is caught inside
        end
      end

Esoteric - definition of examples inside examples

# /Users/pirj/source/real-world-rspec/rspec-core/spec/rspec/core/configuration_spec.rb
      it 'successfully invokes the block' do
        RSpec.describe("group") { it "example 1" do; end}
        example = RSpec.world.example_groups.first.examples.first
        expect(example.metadata[:new_key]).to eq(:new_value)
      end

Missing configuration for well-known expectations

    it 'does not register any offenses' do
      expect_no_offenses(<<~RUBY, 'foo.rb')
        # cop will not read these contents
        gem('rubocop')
        gem('rubocop')
      RUBY
    end

Can we put this:
RSpec:
  Language:
    Expectations:
      - expect_correction
      - expect_no_offenses
      - expect_offense

into some additional YAML file so rubocop and other extensions could just include this, and this would be used in both this cop and MultipleExpectations?
It looks like an immense effort to fix this all. With Safe: false, I believe it's ok to keep the cop as it is.
I wouldn't even care about the long-deprecated monkey-patching object.should RSpec syntax and Minitest-style assertions.

Thank you, @r7kamura !


Error in Public Input Verification with cairo_verifier on example_proof

Description:
Issue Summary:
I am facing a challenge with running the cairo_verifier on the cairo-lang, specifically with the version tagged as v0.12.3 using Python 3.9.0. While I am able to compile and run cairo_verifier, an error occurs when executing it with a example proof.
Steps to Reproduce:

Clone the cairo-lang repository from this link (branch v0.12.3-run-proof). This repo has bazel build fixed manually see this issue for more info
Setup a Python 3.9.0 environment and create a zip package:zip -r cairo-lang-0.12.3.zip cairo-lang-0.12.3
pip install cairo-lang-0.12.3.zip

Compile cairo_verifier using:cairo-compile --cairo_path=./src src/starkware/cairo/cairo_verifier/layouts/starknet_with_keccak/cairo_verifier.cairo --output cairo_verifier.json

Execute cairo_verifier with:cairo-run \
   --program=cairo_verifier.json \
   --layout=starknet_with_keccak \
   --program_input=cairo_verifier_input.json \
   --trace_file=cairo_verifier_trace.json \
   --memory_file=cairo_verifier_memory.json \
   --print_output

Using cairo_verifier_input.json with the content from src/starkware/cairo/stark_verifier/air/example_proof.json.

Expected Result:
The cairo_verifier should execute successfully without any errors.
Actual Result:
The program executes but fails during the _verify_public_input function this assertion. The error message is as follows:
[src/starkware/cairo/cairo_verifier/layouts/starknet_with_keccak/cairo_verifier.cairo:74:5: Error at pc=0:31735]
An ASSERT_EQ instruction failed: 0 != 3.
    assert public_input.n_continuous_pages = 0;
    ^*****************************************^
Cairo traceback (most recent call last):
src/starkware/cairo/cairo_verifier/layouts/starknet_with_keccak/cairo_verifier.cairo:199:39: (pc=0:31899)
    let (program_hash, output_hash) = verify_cairo_proof(proof);
                                      ^***********************^
src/starkware/cairo/cairo_verifier/layouts/starknet_with_keccak/cairo_verifier.cairo:52:12: (pc=0:31709)
    return _verify_public_input(public_input=cast(proof.public_input, PublicInput*));

This indicates an issue with the public input verification, even though the core stark verification seems to work fine.
Additional Information:

Python version: 3.9.0
Tag: v0.12.3
The issue seems to be specific to the _verify_public_input function.
The error occurs when running the verifier on the example proof located at src/starkware/cairo/stark_verifier/air/example_proof.json.
The compilation takes around 8 minutes and requires about 10GiB of RAM.
Execution takes approximately 23 minutes and requires about 91GiB of RAM.

Questions:

What could be causing this failure in the public input verification step?
Can you help explain the error message and suggest potential fixes?

Continuous memory pages are not supported by the Cairo verifier.

Are u able to provide example proof with small layout, proof in the repo has multiple memory pages and I have trouble generating one from stone-prover as mentioned here


check_alive 503 with ALB

Describe the bug
We are using an ALB alongside a NodePort Service to route traffic to our Ambassador pods. We are seeing a pretty consistent small percentage (2-3%) of ALB health checks fail with a 503 UC.
We have 5 mappings, all of which have remained the same since we started adopting.
The number of 503s is pretty sporadic, but with ~25 nodes health checking down to 6 Ambassador pods via NodePort, we see about 1-2% of our total traffic volume (including the healthcheks) register as 503s in envoy. I can get more specific info or try more specific tests if need be. See below for the health check config.
To Reproduce
Use the ALB ingress controller to setup an Ingress to point to your kind: Service of type: NodePort
Expected behavior
The ALB health check passed without 503, as the pods are healthy and not crashing/restarting.
Here is the log line from Envoy
2019-12-09T20:54:05.000Z <POD_NAME> ACCESS [2019-12-09T20:54:04.729Z] "GET /ambassador/v0/check_alive HTTP/1.1" 503 UC 0 95 0 - "-" "ELB-HealthChecker/2.0" "e9b1934b-e62c-488b-a0a3-fb8f7935803b" "REDACTED:32149" "<IP_ADDRESS>:8877"

Versions (please complete the following information):

Ambassador: 0.85.0
Kubernetes on EC2 version 1.14.8

Additional context
We have the health check on the ALB configured with the following:

When sending traffic via siege to the ALB DNS name, then to the check_alive path, all requests succeed. Also testing via a node in the cluster on its NodePort, all requests succeed. Any thoughts or guidance on how to narrow this down?
Note: regular traffic works as expected, Mappings and all. This seems to be only affecting the AWS ALB health check.

I've done some additional digging into this. It seems increasing the gunicorn keepalive setting significantly reduces the frequency of these 503s (although we still see one occasionally). I'm guessing there is some interaction between gunicorn closing connections and Envoy's connection pool causing these 503s. Thoughts? I'd be happy to open a PR if this is something other people are running into.

We are experiencing the same issue in all of our environments running Ambassador v0.86.1, Kubernetes v1.16.4 and Calico v3.11. We have ALBs pointed at cluster workers via a NodePort service and the health checks are sporadically failing with a 503 error, showing up as a "UC" error code in Envoy's access logs exactly as shown above. In this case, our ALB health check is routed to a Java application instance running Tomcat rather than Ambassador's own health check.
There seems to be an issue, possibly with Envoy connection pooling as suggested that is causing requests originating from within the VPC to sporadically fail with a 503. We are also seeing sporadic 503s when we run our Helm chart test suite which spins up Job resources in the cluster that test external endpoints through the ALB. The failures behave like the well-documented issues with Envoy and HTTP keep alive connections, but no amount of adjusting the keep alive settings in all parts of the stack have fixed this issue. Even setting up retries doesn't completely eliminate it.
Envoy reports that the upstream returns a connection refused (code 111) error:
[2020-01-06 22:21:55.881][147][debug][pool] [source/common/http/http1/conn_pool.cc:95] creating a new connection
[2020-01-06 22:21:55.881][147][debug][client] [source/common/http/codec_client.cc:31] [C1092] connecting
[2020-01-06 22:21:55.881][147][debug][connection] [source/common/network/connection_impl.cc:711] [C1092] connecting to <IP_ADDRESS>:80
[2020-01-06 22:21:55.881][147][debug][connection] [source/common/network/connection_impl.cc:720] [C1092] connection in progress
[2020-01-06 22:21:55.881][147][debug][pool] [source/common/http/conn_pool_base.cc:20] queueing request due to no available connections
[2020-01-06 22:21:55.881][147][debug][connection] [source/common/network/connection_impl.cc:568] [C1092] delayed connection error: 111
[2020-01-06 22:21:55.881][147][debug][connection] [source/common/network/connection_impl.cc:193] [C1092] closing socket: 0
[2020-01-06 22:21:55.881][147][debug][client] [source/common/http/codec_client.cc:88] [C1092] disconnect. resetting 0 pending requests
[2020-01-06 22:21:55.881][147][debug][pool] [source/common/http/http1/conn_pool.cc:136] [C1092] client disconnected, failure reason:
[2020-01-06 22:21:55.881][147][debug][pool] [source/common/http/http1/conn_pool.cc:167] [C1092] purge pending, failure reason:
[2020-01-06 22:21:55.881][147][debug][router] [source/common/router/router.cc:911] [C1084][S12840280777660819839] upstream reset: reset reason connection failure
[2020-01-06 22:21:55.881][147][debug][http] [source/common/http/conn_manager_impl.cc:1354] [C1084][S12840280777660819839] Sending local reply with details upstream_reset_before_response_started{connection failure}

This seems to only happen for traffic originating from within the VPC. There are no errors when hitting the services directly via their ClusterIPs and there are no errors for requests originating outside the VPC like customer API calls and external health monitoring that hit the same endpoints.
My next steps are to see if the EA release of Ambassador Edge Stack fixes it. If that doesn't work, I'll start analyzing packet captures between the pods.

this issue still exist. did anyone got the fix for it?

same here. Will anyone will look into this ?


Finish implementing datatypes

Requires a change to timing of list processing.

Now that the recursive compilation point has moved, this requires testing with creating instances of q-structs and using them

Currently dtypes are not actually saved to scope variables..

Now warrants changes to memory mapping

Structs are fully implemented!


feat: Improve Git handler and introduce caching

Changes

Persist Git Repository Id: This PR stores the remote repository id (i.e. project id for GitLab and {owner}/{repo_name} for GitHub) along with the git model in the database, so we only need to fetch it once. If the git model path changes, we also need to update the repository id.
Persist Job Identifier for Diagram Cache: This PR allows the job identifier corresponding to the last successful pipeline to be retrieved only once, rather than for each requested diagram. This is achieved by providing the job identifier along with the initial diagram metadata response, so that the frontend can always send the job identifier along with a requested diagram. However, this behavior is optional, so if no job identifier is provided, we will still look up the identifier for each request.
Git Handler Improvements: This PR contains a number of improvements/refactorings to the git handler. For example, the project identifier has been removed from all function parameters and is now set on the object itself, unused functions have been removed, return types have been changed to properly match the actual type, documentation has been added to the abstract git handler, and more.
Git Handler Caching: This PR introduces an initial caching approach for files and artifacts retrieved from git pipelines. This should reduce the number of API calls we make and thus significantly improve image load times. We use redis as a caching solution with the following keys {git path}:{git revision}:f:{file path} for files and {git path}:{git revision}:a:{job id}:{file_path} for artifacts. These keys should uniquely identify a file or artifact, and the hierarchical structure allows us to easily clear the cache for certain git models (i.e., we can remove all keys under {git path}:{git revision}:*).

Open TODOs

Make sure that only communication between backend and redis is possible.
Refine error handling so that the user is not overwhelmed with error messages when the complexity badge is not properly configured for some project models.

Resolves #893

@MoritzWeber0 I went over your comments and implemented them in my last commit. I mentioned open issues in my replies to your comments, but the main open issue is how to handle cache clearing (see my comment above), and what resource we should allocate to the valkey pod.
Another open question is how to properly set the cache TTL, which is currently set to 3600, i.e. 1 hour, which is probably too low. Theoretically, we could set it to infinite, since valkey should take care of removing keys when the cache is full, but personally, I would say that it makes sense to have a TTL (even if it is set quite high).


"Server disconnected!" error sometimes when stopping the game in the editor

Godot version:
d2eb731
OS/device including version:
Manjaro Linux
Issue description:
When stopping the game in the editor, sometimes this error message will be printed out:
drivers/unix/stream_peer_tcp_posix.cpp:276 - Server disconnected!

Sometimes I can't initially play the project, as it is saying Server disconnected. But this only happens when I have multiple instances of Godot running (not of the same project, though, and without any other project already playing). Probably not related, bit still.

https://github.com/godotengine/godot/issues/15393

Can't reproduce this anymore, closing it.


binary-search: clean up

Cleans up a few issues remaining from adding the binary-search exercise.

Removed extra .cache files
Altered filenaming system to match other exercises
Updated tests to match common json

I'll just note that without this patch, anyone doing the exercise needs to name their solution example.py unless they modify the test file.

Thanks 👍

We're missing binary-search from the "exercises" key in the config.json.


Roadmap and timeline

Are there any roadmap and timeline for this project?
I want to know what is the end goal for this project, what features are going to be included in the 1.0 version, and when it is likely to happen (Q2 or Q3?)

There is a rough roadmap.
Our current major goal is to make pDSL "ready" for the Sub0 workshop.

Where can I see the rough roadmap?
https://github.com/Robbepop/pdsl/projects/1
Those are the tasks for Sub0 right?

There is no concrete roadmap online so far. We are thinking about creating one. Thanks for the reminder!

https://github.com/paritytech/ink/issues/153
Closed.


[ios] Crash in func NowPlayingInfoKeyValue (Thread 103: EXC_BAD_ACCESS (code=EXC_I386_GPFLT))

Describe the bug
I'm using 'hls' objects and sometimes insert before 'mp3' objects with ".add(object, insertBeforeId)" function.
To Reproduce
Steps to reproduce the behavior:
1 - Start a player with a 'hls' stream track
2 - After 1 second, set a 'default' track with 'hls' track id (insert before => TrackPlayer.add(mp3Object, htlObject.id);
3 - After set a Mp3 before 'hls' file, try reset, stop and add new 'hls' tracks
Environment (please complete the following information):
System:
OS: macOS 10.15.3
CPU: (4) x64 Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz
Memory: 21.93 MB / 8.00 GB
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 13.8.0 - /var/folders/3p/ql42h5js4pjct_87l75jxllc0000gn/T/yarn--1599245865513-0.8621646158837184/node
Yarn: 1.21.1 - /var/folders/3p/ql42h5js4pjct_87l75jxllc0000gn/T/yarn--1599245865513-0.8621646158837184/yarn
npm: 6.13.6 - ~/.nvm/versions/node/v13.8.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 27, 28, 29
Build Tools: 28.0.3, 29.0.3, 30.0.0, 30.0.1
System Images: android-25 | Google APIs Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.6 AI-192.7<IP_ADDRESS>08749
Xcode: 11.6/11E708 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
"react-native-track-player": "^1.2.3" i'm install with #dev
Are you testing on a real device or in the simulator? Which OS version are you running?
I'm test in real device and simulator, version is 13
Code
May be after this:
       yield call(TrackPlayer.add, publicity, response.nextTrack);
        yield call(TrackPlayer.skip, `${publicity.id}`);

Or after remove a track with this:
 TrackPlayer.remove(id)
      .then(() => {
        console.log('track removed');
        resolve(true);
      })
      .catch(() => {
        resolve(false);
        console.log('track not removed');
      });
  });

I solved this problem by removing a TrackPlayer.play that exists within the 'playback-track-changed' event. For that reason I was breaking my app.


[GOLANG] Some fixes for golang latest version compiler. #3119

Ref. https://github.com/aai/go-face/commit/7c338c5174282cd92d9d46e81dc7a2a456be0cdd
Enforces not to use mangled C names.
Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

cc @tqchen


getting ready for release

Coverage remained the same at 97.816% when pulling 527f9c530297911adec13a1c968449e39e265ab2 on yuce:releasing-v1.3.4 into 7ec4d41d7522bf9f89eac3ce42f1ae64e2a1c5ab on pilosa:master.


Mujoco cpp sensors

Added the following messages:

ObkImu
ObkFramePose
ObkPDFeedForward (not used anywhere for now)

Renamed: JointEncoders -> ObkJointEncoders. Removed y field. Added joint_names field, joint_pos, joint_vel fields.
Added support for these messages in the Mujoco C++ simulation.
Updated examples.

Dummy bot now has an IMU and FramePose sensor

Added support for sensor of heterogeneous Mujoco sensor types.
Including:

In the config files mujoco sensor names have mujoco sensor types associated with them
Mujoco simulation now packs message properly rather than dumping into y

@alberthli I believe that the changes to the launch file parsing break the python mujoco side (you would just need to add the extra layer of parsing), its not too bad. I didn't do it because I wasn't sure if we wanted to keep the python side up to date. Other than that, all the python stuff should be up to date.


Fix parent map issues

This PR fixes two main issues with current parent map:

Mod whose parent also has a parent doesn't show up. Now if A has parent B, and B has parent C, then C will be treated as parent of both A and B.
If two or more mods declare each other as parents, then none of them is visible and trying to search for mods may crash the game (it's probably the case in #763). Now in such case all of these mods will be treated as root mods.

Thanks! looks great


chore: go-qs1 to 0.0.2

chore: Promote go-qs1 to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


DEN-16 Implement ResourceManagedRuleCreate for Managed Rule

Closes #26

All good, feel free to merge whenever!


chore: upgrade catalog

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm

kube
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm

kube
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test kube

gsm-kapp
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm-kapp

vault
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm

kube
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test kube

gsm-kapp
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm-kapp

vault
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test kube

gsm-kapp
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm-kapp

vault
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test vault

gsm
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm-kapp
e76fdf896ddab1c5948ff4208299864b1bfb5fbd
link
/test gsm-kapp

vault
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test vault

gsm
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test gsm

kube
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test vault

gsm
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test gsm

kube
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test kube

gsm-kapp
04408a62f8d12904b71b1d1efd9d626858ec9843
link
/test gsm-kapp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Possible to make SettingStack search field optional?

Hi,
First of all, such a great library! Amazing job :)
Is it possible to hide the search bar at the top?

Supported in 1.0.1!


Suricata start failed: No DPDK ports found

suricata --dpdk
19/8/2020 -- 16:01:30 -  -  DPDK Mode selected
19/8/2020 -- 16:01:30 -  -  (name:suricatareassembly)
19/8/2020 -- 16:01:30 -  -  (n:8000)
19/8/2020 -- 16:01:30 -  - This is Suricata version 4.1.4 (rev 09ee165)
19/8/2020 -- 16:01:30 -  - [ERRCODE: SC_ERR_DPDK_CONFIG(319)] -  No DPDK ports found
There are different from:
https://github.com/vipinpv85/DPDK_SURICATA-4_1_1/issues/5
I can't find  the "mysuricata.cfg" file, I don't even know what format to input into this file.
I found the DPDK options in the "suricate.yml" file, I guess it's a update, but how can I set it?

l2fwd example is worked.

humbly suggesting to refer the https://github.com/vipinpv85/DPDK_SURICATA-4_1_1/blob/master/README.md.  There are no mysuricata.cfg

l2fwd example is worked.

this is more like https://github.com/vipinpv85/DPDK_SURICATA-4_1_1/issues/11. Hence marking this duplicate too.

Yes, it's similar, could you please tell me how to modify the Makefile or Makefile.in ?
just append "-lrte_pmd_e1000 -Wl" to "-lrte_pmd_i40e -Wl"?

Configure.ac is already having 'lrte_pmd_i40e -Wl'. What are you saying

l2fwd example is worked.

this is more like #11. Hence marking this duplicate too.

Your dpdk debugging is incorrect, there is no X710 ports in your system. Recheck your system configuration rather than assuming the cause of errors.

l2fwd example is worked.

this is more like #11. Hence marking this duplicate too.

Your dpdk debugging is incorrect, there is no X710 ports in your system. Recheck your system configuration rather than assuming the cause of errors.

But I run the exmaple "l2fwd", it can send and receive data normally

l2fwd example is worked.

this is more like #11. Hence marking this duplicate too.

Your dpdk debugging is incorrect, there is no X710 ports in your system. Recheck your system configuration rather than assuming the cause of errors.

But I run the exmaple "l2fwd", it can send and receive data normally

your DPDK debugging is incorrect, you do not have X710 (i40e) but you have X540 (not i40e). Please cross-check before you make assumptions.

DPDK_LDFLAGS is override in configure.ac:1351, therefore "-lrte_pmd_ixgbe -Wl" is missing.
Add it and "make && make install"
problem solved.

DPDK_LDFLAGS is override in configure.ac:1351, therefore "-lrte_pmd_ixgbe -Wl" is missing.
Add it and "make && make install"
problem solved.

I humbly request to check what you are writing, as I have already communicated this

your error is same as https://github.com/vipinpv85/DPDK_SURICATA-4_1_1/issues/11
your debugging of missing dpdk driver is incorrect (as you are assuming it is i40e)

DPDK_LDFLAGS is override in configure.ac:1351, therefore "-lrte_pmd_ixgbe -Wl" is missing.
Add it and "make && make install"
problem solved.

I humbly request to check what you are writing, as I have already communicated this

your error is same as #11
your debugging of missing dpdk driver is incorrect (as you are assuming it is i40e)

you are right, but I didn't know which driver I should use, and there was no mention of how to modify makefiles in https://github.com/vipinpv85/DPDK_SURICATA-4_1_1/issues/11
just solved it and write there :P


Added optional flags to corresponding ClaimsIdentityRpc fields.

Per this comment in PR review.

Does proto3 support optional?

..now that you mention it, I don't. My mistake; I'll close this PR.


✏ Create dynamic util function that calculates x months in the past

Currently, discover requests are using 2023-01-01 date ranges as "new".

Determine what date range constitutes "New" (currently, 6 months)
Create util function that dynamically calculates 6 months in the past
apply to discover requests using release_date parameters.

Closed by #690


My sibling´s parent is my parent

If A -up> B and C -same/next/prev> B, then C -implied down> A

I've added this in the latest release, please let me know if it works :)

If A -up> B and C -same/next/prev> B, then C -implied down> A

Isn't this aunt/uncle (parent's sibling) rather than sibling's parent? Also, is next/prev a specific kind of sibling?

Indeed. The relation described with the arrows is an Aunt/Uncle relation (already implemented). But the relation described in the title of the issue is different

is next/prev a specific kind of sibling?

@ooker777 I guess so...
Next/Prev is just a directed sibling

@ooker777 I guess so... Next/Prev is just a directed sibling

But they still don't show up as siblings...hence my FR here

Alright, I'm gonna close this issue because the initial request has been implemented, and the second request has its own FR


App crashing after navigatingview to scrollview with SwiftUIRefresh

Its crashing for me on PullToRefresh.swift line 68 refreshControl.beginRefreshing() Thread 1: EXC_BAD_ACCESS (code=1, address=0x20).
My app uses a navigationview and when I navigate to a view that uses a scrollview with this library (so its a navigation view with a scrollview inside of it) it sometimes crashes with that error.
As soon as the view becomes visible it starts loading data and the isShowing binding turns to true (I know it still can't be triggered programmatically).
Please tell me what else would you need to diagnose this issue.

Now it's crashing for me even on app launch on iOS 14 beta 4 with the same error.

same here,

Same thing was happening to me because when onValueChanged() was called from PullToRefresh's Coordinator I was updating the binding value myself and the code ran into an infinite loop. So the solution for me was to remove line 31


Extend pidgin SASL guide to include setting SASL login name

The other day a user in #pidgin followed this guide and had problems logging in because they had set Real name to their full name and no SASL login name. Pidgin uses Real name as fallback for login, so setting SASL login name fixed the login problems.

Is there something I should do here? I don't think the failing Lint step is caused by my changes.


Super does not work

class b()
    def __init__(self):
        pass
    def go(self):
        print('b.go')

class a(b)
    def __init__(self):
        pass
    def go(self):
        super(a, self).go()
        print('b.go')

inst = a()

Feature implemented. Thanks for reporting this!


Updated default settings parameters

Updated AppSettings class with the latest default URL services endpoints

Please keep the same App Center SDK since we are using the App Center Demos Org.

Ok!


Old radio button stays selected when new button is selected in RadioGroup.

Old radio button stays selected when new button is selected in RadioGroup (until you force it to redraw by e.g. hovering over it).

What platform are you on? I do now have this issue (in the flex example) on linux/gtk

So I think my problem comes from the fact that my RadioGroup is inside a List.

Progress: in ClipBox, the widget is not correctly identifying that its children are active, and so it is not passing events down the tree. This only happens if the events have been added dynamically in a List so I assume this is the problem, but need to dig deeper.

I thought the patch would fix this bug, but sadly it does not. I will investigate.

This bug manifests without any Scroll, so the only requirement is that some Radio buttons are inside a List.

In the end it was a bug in user code - I need to implement Data manually to skip checking part of my state under certain conditions. I think added some new state, but forgot to update the same method, meaning that data wasn't being informed of a change.


Update winit version to 0.22.2

The winit integration is avoiding 0.19.4 due to build errors but winit is now on 0.22.2.
I have opened a similar issue for pathfinder.

https://github.com/servo/surfman/pull/179 is work being done in the upstream repository.


Missing semicolon at the end of bootstrap.js causes issues when bundled with other scripts

I am bundling bootstrap.js with other scripts and I get a runtime error which I found out is due to a missing semicolon at the end of bootstrap.js:
https://github.com/twbs/bootstrap/commit/ba312c20a5ceca42117dd53303bafda485d8facd#diff-5492e5c74c97b8b5256879d136b55c88R3631
Only the unminified file is missing the semicolon.

/CC @bardiharborow @Johann-S

That is why I don't like the no semi approach, personally. That being said. can't we just add the end of file semi here?

Yes that's just a mistake from stamp.js (Babel add semicolons to our dist files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/bootstrap.js#L97) and when https://github.com/twbs/bootstrap/pull/22888 will be merge stamp.js won't exist 😄

I believe that until that is merged we should fix it in dev branch. Because
as you know that might a while to merge...
On Jul 31, 2017 11:03, "Johann-S"<EMAIL_ADDRESS>wrote:
Yes that's just a mistake from stamp.js (Babel add semicolons to our dist
files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/
bootstrap.js#L97) and when #22888
https://github.com/twbs/bootstrap/pull/22888 will be merge stamp.js won't
exist 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/23175#issuecomment-318996746,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtUbXSsgPi_ltqTJXxmrr-1KuWJjrks5sTYpYgaJpZM4Ond54
.

I'm going to submit a PR later unless you beat me to it.
On Jul 31, 2017 11:26, "XhmikosR"<EMAIL_ADDRESS>wrote:
I believe that until that is merged we should fix it in dev branch. Because
as you know that might a while to merge...
On Jul 31, 2017 11:03, "Johann-S"<EMAIL_ADDRESS>wrote:
Yes that's just a mistake from stamp.js (Babel add semicolons to our dist
files see : https://github.com/twbs/bootstrap/blob/v4-dev/dist/js/bootst
rap.js#L97) and when #22888 https://github.com/twbs/bootstrap/pull/22888
will be merge stamp.js won't exist 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/23175#issuecomment-318996746,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtUbXSsgPi_ltqTJXxmrr-1KuWJjrks5sTYpYgaJpZM4Ond54
.


incorrect SpecWarn regarding self links in top-level nameserver objects

Situation: A nameserver query receives a response that looks like this.
{
  [...],
  "objectClassName": "nameserver",
  "links": [
    {
      "rel": "self",
      "href": "[...]",
      "type": "application/rdap+json",
      "value": "[...]"
    }
  ]
  "notices": [
    {
      "links": [
        {
          "rel": "terms-of-service",
          "href": "[...]",
          "type": "text/html",
          "value": "[...]"
        }
      ],
      "title": "Terms of service"
    },
    [...]
  ],
  [...]
}

Even though the self link is present, the client will report SpecWarn: RFC 9083 recommends self links for all object classes in this case.
It seems to me that the cause can be found here:
https://github.com/icann/icann-rdap/blob/5f945c88bae665b280272c0defbcf5648431fa93/icann-rdap-common/src/check/types.rs#L87-L96
The root type is checked against Nameserver, but the direct parent type is not, meaning the terms-of-service link embedded in "notices" will also satisfy this condition and be recognized as a missing self link.

Fixed in #60


Resolve syncing conflicts from repo_sync_working_branch to main

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to main.

Learn Build status updates of commit 6c8fedc:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 6c8fedcb4a0f5bd8555aab8726eb54e984019f5e in branch repo_sync_working_branch of repository https://github.com/MicrosoftDocs/azure-docs into branch main (commit e320d3efa3fe1dadc58509ec1d2bd83092349936). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@SyntaxC4 - can you review this sync pr? thanks.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 200e602:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 200e60230ec42303d06e02399a977f479b639c38 in branch repo_sync_working_branch of repository https://github.com/MicrosoftDocs/azure-docs into branch main (commit f76cfaa16e9f5e45c8cb2b2ead3e96ddd819541b). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 2426912:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/102090/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


added eggcatcher game

sorry the first pull req is not required, its regarding the other issue with the missing vouchers.

Please add the game into the main program and make sure it works! @tnayagarwal


gBar failed to open config after enable Nvidia Driver

Describe the bug
The bug I'm facing after  I finally manage to config my Nvidia 630M card to play on Hyprland. After that gBar crashes and won't open.
**OS **
Arch Linux
Hyprland

Does it crash(Segmentation fault or similar) or does it not open(idles forever). If it idles, please install and start either pipewire or pulseaudio and see if that changes anything.
If it crashes, please debug it with gdb, as the don't reveal further clues: gdb /<pathtogbar>/gBar and run bar 0 inside gdb. Please post any output of gdb.
The config warning is not critical, if you want to configure gBar, please read the corresponding section in the README. The warning should go away.

Maybe I'm too young to play with that... kidding.
So I couldn't play gdb the way you said. But, I unninstalled and compile from source.
Then, the error goes on and I had that:

Does the bar open now, as those are all benign warnings and I can't see any indications of a crash in the screenshot. If it did indeed crash, a crash report via gdb would be really useful.
I forgot to mention, for gdb to display any helpful information you need debug symbols(Run inside where gbar is cloned):
meson setup build-debug -Dbuildtype=debug && ninja -C build-debug to build, then gdb build-debug/gBar and run bar 0 inside gdb.

It still won't open.

My bad. First time using gdb.
That was my result

Ok, gBar crashes, because gpu utilization is not supported on your gpu. I'll be working on a fix.

Should be fixed now. Instead of crashing, gBar will disable the GPU module, since the required information isn't available.

The build failed, so no binaries have been built or installed. The first error is still the initial error from when you first installed gBar. The gdb error is due to the fact that there is no local binary, because the build failed.
Since you're on arch, I'd recommend you to use my AUR package (In the following I use yay, other tools should work similar):
yay -S gbar-git.
Then check if you've got any remaining files from local installations left in /usr/local (/usr/local/bin/gBar, /usr/local/lib/libgBar.a, /usr/local/include/gBar), as they could interfere with the AUR installation.
Running it now with gBar bar 0 should use the updated version.
In case you're wondering about the build error, you forgot to clone a submodule. git submodule update --init, then ninja -C build-debug again should work. build-debug/gBar bar 0 to run it.

It works! Thanks to the whole explanation. I'm kind a new to open source and programming too. I'm very excited about open source projects and WM's and the rabbit hole of personalization. Your bar is a really good project.
Cheers from Brazil

No problem.
And good luck on your open source journey!


Unable to run npm build

I want to add functionality to this package and turn this into a plugin for hardhat, and the evm library works fine when imported, but I am unable to run "yarn install" due to some issues with scrypt in the outdated web3 package,  and am unable to run "yarn build" after updating the web3 package due to some issues with typescript in webpack.
Is there any configuration (version of npm) for which building this works? Otherwise I plan to update every package and try to get the build working.

Fixed in #32 . Would appreciate some input/feedback if the changes are fine.


Feature/call test

Description

Change 'Shard' test to 'TPS' test
Add 'QPS' test
Now more tests are possible

Thanks for the quick review! Now merigng


[My Daily Log] Add ability to edit log line

Extension
https://www.raycast.com/frugoman/my-daily-log
Description
I'm an avid user of this extension, it's super simple and perfect for my daily use, so thanks so much for making it!
One thing that happens frequently is that I mistype something in my log and don't notice until afterwards. It's not the end of the world, since the logs are for myself, so I generally understand what I meant, but if there was a way to edit or delete loglines from within raycast that would be amazing.
Thanks again for all your work!
Who will benefit from this feature?
No response
Anything else?
No response

Hey @boaz-wiesner Thanks for this!!
I've revamped the extension, rewriting most of it following clean architecture and some other behind the scenes changes. While at this, I've added support for editing the logs!
The refactor was done mainly because of this, as it wasn't even possible before because of the initial state of the project's code 😬, so thanks for giving me a reason to finally get back to it and fix all this!!
https://github.com/raycast/extensions/pull/5389
Hopefully will be merged soon!

Hah, awesome! Glad to hear it 😄 Always happy to be a reason for more robust code 😉
Thanks again for the work on this extension, really appreciate it!

@boaz-wiesner Enjoy!
@raycastbot close this issue


Bug fix for showing absent students

@sanjay-v46  The behaviour you are noticing is a existing bug. We can take that issue separately.


Widget generator does not work if App generator is not run first

To reproduce:
npm install -g yo generator-esri-appbuilder-js
yo esri-appbuilder-js:widget

It looks like it attempts to read a number of config variables that are set by the main generator. In my case, I only wanted to scaffold a new widget to drop into an existing app, and didn't particularly want/need to go through the process of fiddling with Esri's WebappBuilder SDK or anything like that.
Would it perhaps be possible to just ask for these config variables in the Widget sub generator as well, instead of relying on the main generator being run first?

@dzackgarza thanks for the report. Currently, it is required that you run the "main generator" (aka "App" or "Default" Generator) first. We should probably make this fact more explicit in the documentation.
You're correct that the widget generator depends on a variety of questions that are asked by the Main/App/Default Generator. For example if you've chosen to use SASS for CSS preprocessing, the widget generator will create you a style.scss file instead of a style.css file. We've never really thought about extracting the creation of the widget from the main generator, because there are so many benefits that come with the main generator including a grunt task runner, the SCSS stuff that I mentioned earlier, ES6 or TypeScript transpilation, etc. A few thoughts come to mind:

Workaround: I assume you have web appbuilder developer edition installed somewhere on your machine - if you simply run the Default Generator first, pointing to that Web AppBuilder location, and then run the widget generator, you will get what you want. As long as you don't run the grunt command after you run the widget generator, no changes will be made to your Web AppBuilder install.
Would making the "Web AppBuilder install root` question of the generator optional make the above workaround easier for cases like yours where you just want to get the widget files out. This might be the best "quick win" to resolve your issue above.
Why do we even have a 2-step process at all? I do not think this solves your problem, but maybe we should switch to having just a single yeoman task, that automatically asks you the "initial" questions (The questions currently in the Default Generator) and asks you if necessary but if you've already answered those, jump directly into the widget questions. (props to @gbochenek for this idea)

As part of this process one of the questions could be something like "do you want to install the Grunt task runner (file copier and transpiler for ES6 or TypeScript) or just get the widget files directly (ES5 style javascript only)" ... this would address the request above.
This might be a significant re-work of the codebase, so I'd like to hear others weigh in on this

re: 3.
A significant reason for the 2 step process is exactly that - there are several questions you don't want to answer more than once. If it can be done as a one step process that retains the answers to the first questions (I recall that yeoman has some mechanism for that), that might be slicker, but I don't think any easier to explain than the current 2 step process.

I have added a pull request to solve this - I had a project requirement for it so shared the code - #145


feat(rtc_auto_approver): add rtc_auto_approver

Signed-off-by: Fumiya Watanabe<EMAIL_ADDRESS>Description
To approve the request to cooperate from behavior planning modules, I add  rtc_auto_approver.
rtc_auto_approver approves the request if the corresponding module outputs safe status.

Related links
https://github.com/autowarefoundation/autoware.universe/issues/891

Tests performed
I checked by the planning simulator with the following PR.
https://github.com/autowarefoundation/autoware.universe/issues/891

run planning simulator
set the route including some regulatory elements (e.g. crosswalk or intersection)
check that the behavior velocity planner modules set some stop points
launch rtc_auto_approver
check that the stop points are removed
check that the stop points are set if the modules output unsafe status.

Notes for reviewers
Adding launch configuration to launch this node is next action.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I'd like to use the interface class for each scene module. and then, new scene module will able to be added more easy and simple

@yukkysaito
I fixed to use interface class in https://github.com/autowarefoundation/autoware.universe/pull/964/commits/371264a1b20b62374234f6a6634785956d33367a


testdriver: add ability to write tests that use feedkeys

WIP in https://github.com/myitcv/govim/pull/50

This was fixed in #50


[Epic] Add Models in CUDA Benchmark Focus Suite to IREE Benchmarking System

Request description
We have defined a set of models to monitor and make progress on. This issue tracks work involved in adding these models to the IREE Benchmarking System.
Tensorflow
ResNet50

[x] Inference, FP32, Batch Sizes 1, 8, 64, 128, 256, 2048

Bert-Large

[x] Inference, FP32, Batch Sizes 1, 16, 24, 32, 48, 64, 512, 1024, 1280
[ ] Training. Workloads TBD.

T5-Large

[x] Inference, FP32, Batch Size 1, 16, 24, 32, 48, 64, 512

DLRM

[ ] Inference, FP32, Batch Sizes 51.2k, 65.5k, 200k, 262.1k, 263k, 274k, 315k, 334k

PyTorch
ResNet50

[x] Inference, FP32, Batch Sizes 1, 8, 64, 128, 256, 2048
[x] Inference, FP16, Batch Sizes 1, 8, 64, 128, 256, 2048

Bert-Large

[x] Inference, FP32, Batch Sizes 1, 16, 24, 32, 48, 64, 512, 1024, 1280
[x] Inference, FP16, Batch Sizes 1, 16, 24, 32, 48, 64, 512, 1024, 1280
[ ] Training. Workloads TBD.

T5-Large

[ ] Inference, FP32, Batch Size 1, 16, 24, 32, 48, 64, 512

Error lowering to MLIR (https://github.com/llvm/torch-mlir/issues/1977)

[ ] Inference, FP16, Batch Size 1

DLRM

[ ] Inference, FP32, Batch Sizes 51.2k, 65.5k, 200k, 262.1k, 263k, 274k, 315k, 334k
[ ] Inference, FP16, Batch Sizes 51.2k, 65.5k, 200k, 262.1k, 263k, 274k, 315k, 334k

JAX
ResNet50

[x] Inference, FP32, Batch Sizes 1, 8, 64, 128, 256, 2048
[ ] Inference, BF16, Batch Sizes 1, 8, 64, 128, 256, 2048

Bert-Large

[x] Inference, FP32, Batch Sizes 1, 16, 24, 32, 48, 64, 512, 1024, 1280
[ ] Inference, BF16, Batch Sizes 1, 16, 24, 32, 48, 64, 512, 1024, 1280
[ ] Training. Workloads TBD.

T5-Large

[x] Inference, FP32, Batch Size 1, 16, 24, 32, 48, 64, 512
[ ] Inference, BF16, Batch Size 1, 16, 24, 32, 48, 64, 512

DLRM

[ ] Inference, FP32, Batch Sizes 51.2k, 65.5k, 200k, 262.1k, 263k, 274k, 315k, 334k
[ ] Inference, BF16, Batch Sizes 51.2k, 65.5k, 200k, 262.1k, 263k, 274k, 315k, 334k

GPT-3

[ ] Training, FP32, Global batch size 1536 over 768 replicas.
[ ] Training, BF16, Global batch size 1536 over 768 replicas.

AlphaFold 2

[ ] Inference, FP32, Batch Size 1

GPT-3 Training owner: @phoenix-meadowlark
Alphafold 2 Inference owner: @silvasean

@mariecwhite Is this in progress? Would like to update the status if so!

Yep, in progress.

@mariecwhite Taking Epic updates on a weekly basis - let us know if any news here or just WIP? Target for these Epics is end of Q2.

I've updated the description with what has been implemented. We now have TF and PyTorch ResNet50, Bert-Large and T5-Large models running in OOBI for IREE CUDA. XLA:GPU currently in progress.

@mariecwhite Any updates on this Epic?

The list itself is evolving. Some high level changes:

We'll pare back on the number of FP16 models needed. There isn't a straightforward way to generate FP16 models in TF so we'll remove that and use FP16 models in JAX and PyTorch. BF16 is also top of mind so we'll add models with this datatype once compiler support is online.
We're adding FLAX pretrained models to the mix. Specifically, BERT and T5.
@phoenix-meadowlark is making progress on GPT-3 training and has it running locally.
Deepmind models have been de-prioritized.
We expect to add more LLMs into the suite with eventual support for multi-gpu.

I updated the list of models in the Issue description to include JAX models and BF16. We are making progress on adding JAX inference FP32 models and @reichlfl will have some FP16 Torch models ready in the next week.

We now have JAX models running for XLA:GPU and IREE.

We can close this.


Add a third volume provisioning encryption choice for ONTAP drivers to allow for NAE configurations

ONTAP supports volume encryption (NVE) and aggregate encryption (NAE) for volumes.  When provisioning volumes via the CLI or API, using a value of "true" for the encryption parameter results in a NVE encrypted volume in order to be backwards compatible with older versions of ONTAP that did not support NAE.  In order to actually provision a NAE encrypted volume, the encryption parameter needs to be omitted from the CLI or API call, in which case the default for an NAE enabled aggregate on an AFF system is to use NAE enabled volumes.
Right now, Trident only allows for provisioning of volumes with encryption=false (the default) or encryption=true.  With these being the only options, there is no way to make use of NAE encrypted volumes.  One suggestion would be to allow a 3rd choice, such as encryption=aggregate_default, in which case the API call for volume creation from Trident would not pass in anything at all related to volume encryption, and ONTAP would provision the volume with it's own defaults based on the platform and aggregate encryption configuration.

Hi all, any update on this?

Hi @frasmarco, we are currently tracking this feature request on our roadmap. Thanks for inquiring on this issue as it provides us with a better idea of interest in this enhancement.

Can we please have an update for when this is expected to be implemented?

Hi @pjos and @matalve,
The Trident team just finished investigating this issue and found that if NAE is enabled for your aggregate then data at rest is encrypted for every volume on that aggregate. This means that NAE does not require any interaction with Trident in order to work. We will update the Trident documentation in the next few days with this information.
Refer to the Security hardening guild for NetApp ONTAP 9 for more information on NAE and NVE.

Hey @gnarl, does that mean that something has changed since @arndt-netapp made his description starting this issue?
Because I've read that Trident refuses to provision storage if the aggregate is NAE enabled and I think @arndt-netapp ran into the same thing.

Hi @matalve,
From our testing we did not observe that NAE encryption could be disabled. We did observe that setting the encryption flag as "true" overrides NAE enabled aggregates with an NVE encrypted volume. This is a feature that allows the customer to choose the encryption that they need based on their use case. More information can now be found in the Trident documentation. Reading the Security hardening guide for NetApp ONTAP 9 is also recommended.

Can you please point to the Trident release where NAE support was added?
I assume your testing was made with the latest version of Trident.
Previously linked NetApp Docs issue from February says it's not possible for Trident to handle NAE and the documentation was changed.
Has it now been changed again to saying NAE is ok?

@matalve and @arndt-netapp,
I need to apologize as @arndt-netapp's original post is correct. The issue is that current Trident versions send a "false" flag for the encryption value when a volume is created. I initially thought that this only applied to NVE. In the case of when NAE is enabled, setting the encryption value to false for volume creation results in an error of "Unencrypted volumes are not supported in NAE (NetApp Aggregate Encryption) aggregates.".
With commit 418b9eb Trident will not set the encryption value if it is not specified in the backend configuration file. This will allow volumes to be created on NAE enabled aggregates. This change will be available in the Trident 22.10 release.

@matalve and @arndt-netapp,
I need to apologize as @arndt-netapp's original post is correct. The issue is that current Trident versions send a "false" flag for the encryption value when a volume is created. I initially thought that this only applied to NVE. In the case of when NAE is enabled, setting the encryption value to false for volume creation results in an error of "Unencrypted volumes are not supported in NAE (NetApp Aggregate Encryption) aggregates.".
With commit 418b9eb Trident will not set the encryption value if it is not specified in the backend configuration file. This will allow volumes to be created on NAE enabled aggregates. This change will be available in the Trident 22.10 release.

How to work around this now? I am having this exact issue.
Is the solution to remove the encryption parameter completely or to set it to "true"?

Just remove the encryption parameter from your configuration and you should get the default encryption behavior for the platform/aggregate you are provisioning on.
From: Janina Uhl @.>
Date: Wednesday, May 24, 2023 at 10:35 AM
To: NetApp/trident @.>
Cc: Arndt, Michael @.>, Mention @.>
Subject: Re: [NetApp/trident] Add a third volume provisioning encryption choice for ONTAP drivers to allow for NAE configurations (Issue #672)
@matalvehttps://github.com/matalve and @arndt-netapphttps://github.com/arndt-netapp,
I need to apologize as @arndt-netapphttps://github.com/arndt-netapp's original post is correct. The issue is that current Trident versions send a "false" flag for the encryption value when a volume is created. I initially thought that this only applied to NVE. In the case of when NAE is enabled, setting the encryption value to false for volume creation results in an error of "Unencrypted volumes are not supported in NAE (NetApp Aggregate Encryption) aggregates.".
With commit 418b9ebhttps://github.com/NetApp/trident/commit/418b9eb918fe5f253944868c1760132d43aff936 Trident will not set the encryption value if it is not specified in the backend configuration file. This will allow volumes to be created on NAE enabled aggregates. This change will be available in the Trident 22.10 release.
How to work around this now? I am having this exact issue.
Is the solution to remove the encryption parameter completely or to set it to "true"?
—
Reply to this email directly, view it on GitHubhttps://github.com/NetApp/trident/issues/672#issuecomment-1561280335, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE6WSUDNMGR3W2GV737ZSBDXHYMBNANCNFSM5HOIWOVA.
You are receiving this because you were mentioned.Message ID: @.***>


Numbered steps alignment off

This is a weird one, but sometimes I'm finding numbered steps are out of alignment and appear too high. Just wondering if this is a known problem or something to do with my setup. Screenshot as example:

Are you using a custom PDF theme or the default one? If you're using a custom one, could you share a link to the theme file?

Ah yes I'm using a custom theme, here's a link: release-pdf/circle-theme.yml Thanks!

In that case, it could have to do with how you are setting the line height / line height length.
I'd test it out, except that's not a link ;)

haha oh no! Sorry! here: https://github.com/rosieyohannan/circleci-docs/blob/server/tranfer-content/release-pdf/circle-theme.yml

Excellent. I'll investigate.

Roboto Mono has a larger implicit line height than Lato. That means you need to reduce the font size of Roboto Mono (used for inline code) so that it doesn't impact the height of the line.
You can do this by adding the following property to your theme:
literal:
  font_size: 0.8em

I suppose a case could be made that an inline element such as a monospaced phrase should not affect the height of the line. However, I'm not sure if Prawn supports that option.

@mojavelinux Thank you so much for your help, that makes total sense :-)

Works perfectly now, thanks again!


messages in chat disapper

Minimising the app while on the other page (not the chat page) and then reopening it and going back to chat makes messages dissapear (2 messages missing between those 2)

Just seems like they aren't being checked while the app is closed and then not being checked when it's reopened


Remove QuickCheck dependency from library.

Hi there,
Hope you don't mind the PR, this should close #35 for you.
Have a great day!

Thanks you!


A big refactoring PR

Sorry, it got a little big. But let me try to explain all the changes in-depth here.
Moving to config over functional API
I have removed the functional API methods like setBuildDirectory, setHotFilePath and instead opted for config. The configuration options for the backend are a subset of config options for the client. So it is easy to understand them or maybe maintain a single config file.
The config file is saved inside the config/vite.ts file. The exported variable is named viteBackendConfig to explicitness.
Renaming vite_plugin to client
Renamed the folders and references of vite_plugin to client. Feels more in-sync with backend.
Also renamed the vite plugin export variable to adonisjs from Adonis. I think vite also uses lowercase export names everywhere.
Edge integration
Instead of integrating with @adonisjs/view, we will integrate directly with Edge. The goal of v6 is to get rid of all these proxy packages. Like we use vinejs directly, we will use Edge directly as well in AdonisJS projects.
I have create an Edge plugin that integrates vite with Edge. This plugin is applied to the global instance of Edge automatically (when edge.js is installed). However, if someone creates a custom Edge instance, then they can import this plugin and apply it manually.
import { Edge } from 'edge.js'
import { Vite } from '@adonisjs/vite'
import { edgePluginVite } from '@adonisjs/vite/plugin_edge'

// Custom instance
const edge = Edge.create()
const vite = new Vite(config)

edge.use(edgePluginVite(vite))

Returning JSON instead of HTML as text
Remember we discussed, how HTML can be problematic with our TSX integration? I have updated all the methods to return an object representation of the script or link elements.
For example: The vite.generateEntryPointsTags returns the following output.
[
  {
    tag: 'script',
    attributes: { type: 'module', src: 'http://localhost:9484/@vite/client' },
    children: [],
  },
  {
    tag: 'script',
    attributes: { type: 'module', src: 'http://localhost:9484/test.js' },
    children: [],
  },
]

You can loop over these entries and call toString to get the HTML.
const tags = vite.generateEntryPointsTags()
const tagsAsHtml = tags.join('\n')

// output
<script type="module" src="http://localhost:9484/@vite/client"></script>
<script type="module" src="http://localhost:9484/test.js"></script>

Lemme know if you think this is a bad approach :)
Changes to config
I got a little confused with certain config properties, especially finding some of them are interlinked with each other. I tried my best to simplify it as follows.

Remove publicDirectory option all together. It was used to build paths for the hotFile and the buildDirectory
The buildDirectory path is now relative from the project root in both backend and client configs.
The hotFile path is also relative from the project root in both backend and client configs.

Caching of manifest file
I see we use the manifest file only during production (or when the hot file is missing), so should we not cache it always? Is there any use-case where we will be generating manifest file during development?

Looks perfect to me, thanks dude !
This is annoying, I never have anything to say about your PRs, could you please make a mistake or two once in a while? 😂


support/historyarchive: Make sure all http requests bypass cache for files that do not have unique names

What version are you using?
stellar-archivist master
What did you do?
Attempt to run archivist against a bucket that does not mark files whose name does not change with no-cache (e.g. stellar-history.json)
What did you expect to see?
Up to date stellar-history.json
What did you see instead?
Bucket returned cached stellar-history.json
As a workaround, I have a gswrapper for google buckets:
#!/bin/bash

if [ $# -ne 2 ]; then
    exit 1
fi

dest=$(basename $2)
if [ "$dest" == "stellar-history.json" ]; then
    header="Cache-Control:no-cache, max-age=0, no-transform"
    exec gsutil -h "$header" cp "$1" "$2"
else
    exec gsutil cp "$1" "$2"
fi

A possible solution is to append ?<datestamp> to the stellar-history.json URL when fetching it.

Is it a public history archive? The problem with adding a random string is it doesn't solve the core issue which is a lack of Cache-Control header.

This would be hitting the http endpoint of a google storage backed archive. Convincing the google bucket to send the right cache control headers natively requires something like the wrapper I included above.

Wouldn't this solve the issue in Google Cloud Storage: https://cloud.google.com/storage/docs/metadata#cache-control ?

Yes, the wrapper above solves the issue, but it is an extra step that a node runner would have to set up.

Note that the cache-control header has to be set every time the stellar-horizon.json file is uploaded.

I understand. What I'm trying to say is that adding unique string to the request doesn't solve the root issue. Even if we add this change to all of the SDKs and you request stellar-horizon.json in a browser it's still possible you'll get a cached version.
I think a solution could be to have a simple bash script in your Stellar-Core config that adds cache headers when uploading .well-known/stellar-history.json file.

I think this should be documented somewhere then, along with providing an example wrapper script.

Good point, created a new issue here: https://github.com/stellar/docs/issues/557

Thanks. I believe you are correct about this not solving the root cause, nor the issue with other HTTP clients.


fail to download pretrained model

I fail to download pretrained model ，Could you send the model MDef_DETR_r101_epoch20.pth to my email<EMAIL_ADDRESS>@mmaaz60

+1, the link probability failed. Could you update the link?

Hi @22wei22, @fushh
For me the links are working, could you please try it again? MAVL Downloads.
Thanks


Release

When is the next release planned? A couple of packages like get-contract-instance have useful updates that I'd like to use.

@juharris We're actively working on this. Hopefully we can make an official beta release at the end of next week.

@juharris I have released 0.2.0 prior to the EDCON talk, so it is "relatively" stable for now. That being said, there are some issues that still need fixing, like #98 for example. Please give this a try and let us know if you have any feedback/bugs to report.

Closing for now, thanks for creating the issue.


Filter task run

Fixes

https://issues.redhat.com/browse/HACBS-1170?
Description

Adds filter for Task name to filter by metadata.name and spec.taskRef.name
Type of change

[x] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/retest

/lgtm
/approve

@abhinandan13jan tests are failing

/lgtm cancel

/lgtm


generic_fourier_derivative

currently fourier_derivative returns the two first order derivatives.
I suggest to refactor fourier_derivative -> fourier_first_derivatives
And implement a generalized version of the fourier derivatives:
def generic_fourier_derivative(topography, orderx=-1, ordery=0):
    nx, ny = topography.nb_grid_pts
    sx, sy = topography.physical_sizes

    qx = 2 * np.pi * np.fft.fftfreq(nx, sx / nx).reshape(-1, 1)
    qy = 2 * np.pi * np.fft.fftfreq(ny, sy / ny).reshape(1, -1)

    if nx % 2 == 0:
        qx[int(nx / 2), 0] = 0
    if ny % 2 == 0:
        qy[0, int(ny / 2)] = 0

    spectrum = np.fft.fft2(topography.heights())
    if orderx < 0:
        qx[qx==0] = 1
    if ordery < 0 :
        qy[qy==0] = 1

    spectrum *= (1j * qx) ** orderx * (1j * qy) ** ordery

    heights =np.fft.ifft2(spectrum)
    print(np.max(abs(heights.imag)))
    return heights.real

This actually also computes integrals.
@pastewka what do you think ?

Do we need the dedicated fourier derivative at all? You can just plug muFFT's Fourier derivative operator into derivative.

Ah I didn't know that

Do you have an example for the python interface ?

Does this help? https://gitlab.com/muspectre/muspectre/-/blob/master/tests/libmufft/python_derivative_tests.py#L167


Correct the array description of Chunky Monkey

The array required from the Chunky Monkey challenge is two-dimensional, not multidimensional.
The change has been made in both English and Spanish.

You should NEVER be submitting from your staging, only a branch off staging.
Your branch name should be in the form fix/some-short-description

Please review: Contributing.md and its ancillary documents.
If you have messed up your staging branch, you can seek assistance in HelpContributors

Thanks for the feedback!
This is my first attempt at doing pull requests, so I had no idea how to do them... (I have read Contributing.md though)
Should I redo all my changes and submit another pull request?

In case my staging branch is messed up, can't I just simply delete it and re-fork the repository from here?

I think that you probably should.  You're going to need to clean your staging. Assuming you have a link to the main repo at upstream, you can do this from your local staging branch:
git reset --hard upstream staging
That will completely wipe your current staging and reset it to the current live branch head.  You shouldn't need to delete and re-fork.
Then you can create a branch and make your changes again.
NOTE:  You can just copy and paste the changed lines into a text editor so you can redo them.

One more thing - once you reset the head, you can push your changes back to your github staging:
git push origin staging -f
You need the -f to overwrite the current staging branch on your GitHub repo.

Thank you so much for the tips!


Wolfi user

Chainguard Images Pull Request Template
First time I've seen this template and it's a bit confusing. This PR adds the nonroot user to the wolfi-base image. It does not enable it by default. It's useful for Dockerfiles building on top of wolfi-base to have a nonroot user.
Image Size

[x] The Image is smaller in size than its common public counterpart.
[ ] The Image is larger in size than its common public counterpart (please explain in the notes).

Notes:
Image Vulnerabilities

[x] The Grype vulnerability scan returned 0 CVE(s).
[ ] The Grype vulnerability scan returned > 0 CVE(s) (please explain in the notes).

Notes:
Basic Testing - K8s cluster

[x] The container image was successfully loaded into a kind cluster.
[ ] The container image could not be loaded into a kind cluster (please explain in the notes).

Notes:
You'd have to run something like sleep infinity
Basic Testing - Package/Application

[x] The application is accessible to the user/cluster/etc. after start-up.
[ ] The application is not accessible to the user/cluster/etc. after start-up. (please explain in the notes).

Notes: I guess the default app is the shell? It's not really appropriate to k8s.
Helm

[ ] A Helm chart has been provided and the container image can be used with the chart.  If needed, please add a -compat package to close any gaps with the public helm chart.
[ ] A Helm chart has been provided and the container image is not working with the chart (please explain in the notes).
[x] A Helm chart was not provided.

Notes:
Processor Architectures

[ ] The image was built and tested for x86_64.
[ ] The image could not be built for x86_64 (please explain in the notes).
[x] The image was built and tested for aarch64.
[ ] The image could not be built for aarch64. (please explain in the notes).

Notes:
Functional Testing + Documentation

[ x] Functional tests have been included and the tests are passing.  All tests have been documnted in the notes section.

Notes: There is a simple existing test
Environment Testing + Documentation

[x] There has not been a request and/or there is no indication that this image needs tested on a public cloud provider.
[ ] The container image has been tested successfully on a public cloud provider (AWS, GCP, Azure).
[ ] The container image has not been tested successfully on a public cloud provider (AWS, GCP, Azure) (please explain in the notes).

Notes:
Version

[x] The package version is the latest version of the package.  The latest tag points to this version.
[ ] The package version is the not the latest version of the package (please explain in the notes).

Notes:
Dev Tag Availability

[ ] There is a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base')
[x] There is not a dev tag available that includes a shell and apk tools (by depending on 'wolfi-base') (please explain in the notes).

Notes: This is wolfi-base
Access Control + Authentication

[ ] The image runs as nonroot and GID/UID are set to 65532 or upstream default
[ ] Alternatively the username and GID/UID may be a commonly used one from the ecosystem e.g: postgres
[x] The image requires a non-standard username or non-standard GID/UID (please explain in the notes).

Runs as root by default so apk tools works
ENTRYPOINT

[ ] applications/servers/utilities set to call main program with no arguments e.g. [redis-server]
[ ] applications/servers/utilities not set to call main program with no arguments e.g. [redis-server] (please explain in the notes)
[x] base images leave empty.
[ ] base image and not empty (please explain in the notes).
[ ] dev variants is set to entrypoint script that falls back to system.
[ ] dev variants is not set to entrypoint script that falls back to system (please explain in the notes).

CMD

[ ] For server applications give arguments to start in daemon mode (may be empty)
[ ] For utilities/tooling bring up help e.g. –help
[x] For base images with a shell, call it e.g. [/bin/sh]

Environment Variables

[ ] Environment variables added.
[x] Environment variables not added and not required.

 Logs DO NOT write to file.

Documentation - README

[x] A README file has been provided and it follows the README template.

The readme is in a bad state, I will take a look after this PR.

I've clearly f'd up my git history somehow...


Adding scenarios for types of artifacts and delayed verification

This started with a scenario to handle the cases where verification may be delayed. Often testing and approval of a release to production will lag the signing of new images, and one method to ensure tests and deploy is on the same image is to dereference the image to a sha256 digest. The actual verification of that digest may happen some time later, including after a cluster failure where workload is migrated to new nodes, and the verification of older releases that are previously running on other nodes should not fail and result in a cascading failure of the cluster. This scenario 11 will cause issues for implementations that only include the current tags in the list of valid signatures.
Split off of scenario 11 is the need to verify different types of artifacts, so I added a scenario 10. We need the ability to verify signatures regardless of how the artifact is referenced by the end user, whether they use a sha256 digest, a mutable tag, or a pointer to a multi-platform image. This may require that the implementation signs all of those references, or that it sign the lowest common denominator (the sha256 digest) and that clients first dereference the image name to the digest before verifying.

Closing since this is pretty stale, if there's value in any of the suggested requirements, I can refresh or open a new PR.


Fraction formatting - too little space

The formatting of this compound fraction is awkward. Both the numerator and denominator are too close to the main fraction line.
$\dfrac{1}{Rb}=\dfrac{\dfrac{1}{R1,R3}}{\dfrac{R2,R3}{R1,R2,R3}+\dfrac{R1,R3}{R1,R2,R3}+\dfrac{R1,R2}{R1,R2,R3}}$
screenshot:

I'm using this version of KaTeX:
<EMAIL_ADDRESS>This comes from the 5th equation from the end of https://spinningnumbers.org/a/delta-wye-derivations.html

You are right about the source code I put in my original message. The comma's should all be ,
(aside: That line of source code came was extracted by the copy-tex contributed extension. The back slashes didn't make it into the pasted text.)
The code is as you suggested:
$\dfrac{1}{Rb}=\dfrac{\dfrac{1}{R1,R3}}{\dfrac{R2,R3}{R1,R2,R3}+\dfrac{R1,R3}{R1,R2,R3}+\dfrac{R1,R2}{R1,R2,R3}}$
My point is the tight spacing where the minor fractions crowd the major fraction line (example: the space below R1 R3 in the numerator). The major fraction has very little spacing above and below the major fractionline, in contrast to the minor fractions that have significantly more space.
In the minor fractions the spacing to the fraction line is larger, but not symmetric. The numerators float higher above their short fraction lines than the denominators below the fraction line.
When the major fraction is composed, the top and bottom are mashed close to the major fraction line.
I'm glad KaTex matches LaTeX. Since that is always a key objective then this observation is perhaps more about LaTeX and should be put aside.

Unfortunately this is an issue that affects LaTeX as well as evidenced by many questions on stack exchange.  TBH, I feel like TeX gets this wrong.  My expectation of nested fractions is that the child fractions should have their numerators and denominators closer to their fraction bars and the parent's numerators and denominators should be further away.


Added types and JSON-LD support

This PR adds TypeScript types and JSON-LD support.
JSON-DL allows sites to show up as articles or show rankings in the search results.
https://developers.google.com/search/docs/data-types/article

Hi @ginnyTheCat,
Thank you for your contribution. i will merge it to master, but I have 2 remarks:

There is a small typo in word customisized.
Consider updating tests. You can use this spec file as an example. This can be done in a separate PR, no problem.

Thanks for the example. Made it much easier.

I added schema-dts as a real dependency instead of a dev dependency. This allows for better TypeScript types when using JSON-LD. It won't make the bundle bigger because the js file has no real content and types are not compiled/bundled.
It's no problem if you don't want that. I'll just revert it then.

thanks again for adding JSON-LD, I've released a new version 1.2.0 with your changes


Release Toolium 3.0.1

Coverage: 91.097%. Remained the same when pulling 1799d40f85512a0d254ed777b9171051adce919c on release/3.0.1 into 37f2d1d694136d67f7b91e720a1d059924bce138 on master.


Forceclose: Signature must be zero for failed CHECK(MULTI)SIG operation

Hi, when I use the forceclose command some channels give me this error regarding the signature:
[INF] CHAN: Published TX a445b928e0603d0af0b1c23876adb975c442009aa7c73c1c08bbb9a09bf1918e, response: sendrawtransaction RPC error: {"code":-26,"message":"non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)"}

It seems like you're affected by an old bug of lnd that would sometimes produce an invalid commitment transaction signature. Unfortunately there isn't a lot you can do about that. Do you have any balance in those channels? Were they closed out by your peer in the meantime perhaps?

Yes, I have local balance inside. All of them are still open and the other peers are unreachable

Hmm, well, there is a way to re-sign those commitment transactions by turning them into PSBTs and re-signing just your part of the signature. But that's rather complicated and I haven't written it down anywhere. But I've done it twice before, manually. Unfortunately I'm very busy as always. How many sats are we talking about here?
If you want I can send you the transcript of my chat with the latest user I explained the process to, if you want to reconstruct it from there.

You are the best!
Sure, you can send it to me. I will try, thank you very much!

What's the best way to contact you directly?
I'm adding a 200k satoshi bounty for turning the transcript into a document that can be added to the docs of chantools. So if you're up for writing a HOWTO, I'm looking forward to the PR.

I just wrote you on Slack

Encountered this today, didnt realize my lnd was so out of date:
--> lnd --version
lnd version 0.15.99-beta commit=tlv/v1.1.0-66-gd468391d9
--> chantools -v
chantools version v0.12.2, commit

@guggero out of curiosity is this bug disclosed or explained somewhere? Seems like an invalid signature could be a big problem.

Ok after upgrading to lnd version 0.17.0-beta commit=fn/v1.0.2-58-g54c47a3fe and creating a new (test) channel and attempting a force close, I still got this signature failure. I didn't change the walletDB, just upgraded lnd.

@guggero out of curiosity is https://github.com/lightninglabs/chantools/issues/31#issuecomment-923852001 disclosed or explained somewhere? Seems like an invalid signature could be a big problem.

I think I was speculating at that point, as I was never actually able to track down a specific bug.
In your test scenario, did you also update your peer? Or is that on the same (old) version?
And which commitment transaction are you publishing? I assume the one from the updated node?

Remote node is "version": "0.17.3-beta commit=v0.17.3-beta" and has never been restarted. Local node started off 15.99-beta, created wallet, opened channel, attempted and failed force close with chantools. Then upgraded local to 17.0-beta without clearing out channel.db or wallet.db. Opened a new channel, backed up channel.db, sent LN payments, then failed again to forceclose with chantools.
I'm going to dig in a bit to the details today to figure out which sig is invalid. "Hopefully" its an issue with chantools right? Because otherwise that implies LND is either sending invalid sig, or allowing invalid sigs from remote or both!

Yeah, very likely a bug in chantools itself. This command wasn't updated in a while, so maybe it just needs some tweak to be compatible with anchor channels (which might have been used as the default because v0.17.3 chooses them by default and v0.15.99 supports them).


2.6.8

?

2.6.9

Welcome to GitHub. This is a public repository used by thousands of people. Please use your own repositories for testing GitHub features.


Add instantclick library

InstantClick is an older library by the same developer as instantpage. It also prefetches pages on mouseover, but only replaces body and title, which fits well with blog-like sites and gives a noticeable difference in speed compared with instantpage. Although a bit old, it is still well-used and stable.
I think it would be a great addition to this collection of jslibs.
My knowledge of Go, and especially its package system, is not great. So I couldn't find a way to test if this works. I've based most of it on the instantclick part of this repo.
Thank you in advance for considering this addition.

Thanks for this, I had to tweak it a little to make it work.
A note to others reading this: https://github.com/gohugoio/hugo-mod-jslibs/tree/master/turbo also has "instant click" behaviour built-int, but that's probably overkill for simple blogs.

Thank you for merging! Indeed, turbo felt a bit overkill for my simple blog.


ORCID identifiers can end in 'X'

Describe the bug
Per the spec, the last character of an ORCID is a checksum and can be the character 'X' (denoting the value 10):
https://support.orcid.org/hc/en-us/articles/360053289173-Why-does-my-ORCID-iD-have-an-X-
https://orcid.org/0000-0002-9079-593X
Currently, the webservice assumes that ORCIDs are four groups of four decimal digits, separated by dashes:
https://github.com/dockstore/dockstore/blob/273cd85d5df19491b298111ed36a5e3b15c522ab/dockstore-webservice/src/main/java/io/dockstore/webservice/helpers/ORCIDHelper.java#L71
I believe the upshot is that we're not processing about 1 out of 11 valid ORCIDs here:
https://github.com/dockstore/dockstore/blob/273cd85d5df19491b298111ed36a5e3b15c522ab/dockstore-webservice/src/main/java/io/dockstore/webservice/resources/AbstractWorkflowResource.java#L816
To Reproduce
Investigator should confirm the above behavior.
Expected behavior
Valid ORCIDs should be accepted/processed.
Additional context
current webservice
┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.13.x
┆friendlyId: DOCK-2256
┆sprint: 97- Yazoo Darter
┆taskType: Story

👍

I am not able to see an ORCID author on staging, nor on my local development build, X or no X. In debugging it, the logic for this PR looks good -- an ORCID id with an ending X passes the regex test and at least locally gets added to the DB, but it's not coming back in the API nor (of course) visible in the UI.
So I could mark this closed, since I think the base issue is addressed, but ideally I should actually be able to see in the UI, can cannot.
Note that I can see a "regular" author.
Using this repo/branch to test: https://github.com/coverbeck/md5sum-dockstore-yml/tree/orcidtest

I verified that an ORCID id with a trailing X does get put in the database in staging. There is a generic problem that we have been looking at with staging not being able to read public records, and hence not display them on the workflow version table.
I think this is basically done, but to be paranoid, I'm going to wait until this is deployed to prod and verify there.


Parsing translateX, translateY, scaleX and scaleY

Warnings on translateX, translateY, _scaleX and scaleY : Warning (in usvg_parser::svgtree:282): Failed to parse transform value: 'translateX(20px) translateY(20px) scaleX(2) scaleY(3)'.
SVG File :

Those are from SVG 2, which is not supported yet.
resvg supports only SVG 1 transforms: https://www.w3.org/TR/SVG11/coords.html#TransformAttribute

On the other hand:

For the attributes, there is no support for additional <transform-function>s defined for the CSS transform property. Specifically, <translateX()>, <translateY()>, <scaleX()>, <scaleY()> and <skew()> are not supported by the transform, patternTransform, gradientTransform attributes.

https://www.w3.org/TR/css-transforms-1/#svg-syntax
I guess transform defined as an attribute and as a CSS property should be parsed differently. Therefore resvg is still technically correct.


Pls Make A Dedicated Tutorial Video

Hello i am abel i am trying to make a telegram on replit but i cannot. because i dont have enough information to run your code so pls make a tutorial video on how to run this code on Replit .Pls Its A Request 😥

**And This Is  My Bot FetchRobot Currently Its in a Develpoment Stage It can go ON OR OFF AT ANYTIME But I need your bot Code So that I am Able to Upload files larger than 50mb through telegram .So Kindly Pls Make A Tutorial ******

[ Respectfully Abel]

You can find the installation/usage instructions in the README.md file.

Bro I am Not A Programmer Can You Pls Atleast Tell Me The Steps To How Install And Make It work on Replit Pls Its A Humble Request

Respectfully Abel


[feat] Add microsite accessibility CI workflow

Hey, I just made a Pull Request!
Added a workflow and lighthouse configuration to check microsite accessibility. Current configuration supports:

/
/docs/getting-started
/docs/features/software-catalog
/docs/plugins/create-a-plugin
/docs/dls/design
/docs/releases/** (all)
/blog
/plugins
/demos
/community

closes #22191
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

run prettier:fix in root and microsite directory then commit.

This is great 💯 what do you think about lower the score to 0.92 as part of this PR and open issues (if not already available) for the additional issues identified + open a new issue where we can higher the score to 1 once those issues has been fixed? That way we don't need to block this PR which will make sure we don't introduce new issues in the meanwhile.

@jithenms great to see https://github.com/backstage/backstage/pull/22387, lets make sure to merge that one first then and keep the score as it is!
Yes I think its a great idea to go through all docs, especially since this workflow only runs on microsite changes so won't block other PRs that needs to get merged. Would love to hear from @benjdlambert if you see any issues with running the checks on all docs pages as well?
Since you mention its about ~117 doc pages, do you know how much longer the check will take to run if we included that?

I think the docs are 97 pages we can merge with comment out outpath as adopter can uncomment themselves.


Copy - purpose of the recursive flag?

The recursive flag doesn't seem to do anything for resources, only directories. But if it only applies to directories, shouldn't it be recursively inherently -- else it would just copy an empty directory?

Recursive would be for subdirectories, but this may be the expected default behavior

So it would copy each resource in that directory, but any directories would be left empty after the copy? Or would they not be copied in the first place?

After with talking with @JustinLivi we decided that it makes the most sense to simply copy everything recursively, rather than 1) an empty top-level folder, or 2), the top-level folder, the children, but leaving any subdirectories empty. Thus, we're going to remove this flag and bake it into the action by default, when acting on a directory.


Cypress. Saving the label name before creating the object.

Cypress. Saving the label name before creating the object.
Checking the main parameters of the created object moved to commands.js.
Motivation and context
There were situations when a new shortcut added to the task was placed at the top of the list of shortcuts. In this case, when creating an object, the new shortcut is placed first in the drop-down menu. This may affect the passing of tests that check this value.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage remained the same at 60.663% when pulling e98c41269076b989e02a03c93aa8ac145c3ab9cb on dvkruchinin:dkru/get-label-name-creating-object2 into ec7d2b9687aa712f8eb8da32241ff2850a9d37ed on openvinotoolkit:develop.