Twinkles DESC request to Project

The Twinkles TaskForce would like to request the following things from LSST Project.  This request cover, and often span, both DM + SIMS.

SIMS master should build against DM master
Weekly builds should be tagged for both SIMS and DM.
Weekly Conda binaries based on those tags should be distributed for both SIMS and DM.
Breakage of SIMS against last week's DM tag or breakage of DM against last week's SIMS tag should be noted.

@drphilmarshall @rbiswas4 @danielsf @jchiang87 @jbkalmbach
Please add additional items to help put together our request.  @drphilmarshall and @wmwv will edit and summarize the list and submit through DESC Leadership.

I think this is implicit above but just in case:
Having master builds is good but have a version of sims built against a stable version of the stack when feasible is also useful (preferable) as DM is often changing APIs etc during their development.

Just to be clear: the way LSST's continuous integration works, Sims master is already guaranteed to build against DM master.

@cwwalter what do you mean by "stable"?  Is a DM weekly release good enough?

Weekly builds should be tagged for both SIMS and DM.
It occurs to me that we may already be able to do this for ourselves (at least for eups distrib install-able versions of the stack).  I just haven't been doing it because I did not realize there was demand for DM stack versions between "official releases" (where "official releases" means things like v11.0 or Winter2016).
The next time I cut a new version of Sims (which will be version 2.2.4), I can just publish a version of lsst_aps that is tagged sims_2_2_4.  The people will have the option of
eups distrib install lsst_apps -t sims_2_2_4

and getting a version of lsst_apps that is consistent with Sims version 2.2.4 (and so on into the future)

@danielsf   Excellent.  That would be great.

Follow up to my own post: I ran the idea by Simon and he saw no problem with publishing sims tagged versions of lsst_apps.  So, really, the only thing we can't do for ourselves is guarantee the availability of conda builds with any regularity.

At this point, should we pause while we implement the things we can do, and
then send the request for what we know we cannot? If you think that's
sensible, we are only left with what to do about the draft request in the
first comment: I think I'd suggest we edit that so that it reflects our
current understanding, and keep iterating until we are ready to draw
people's attention to this issue thread (at which point the first comment
will be the first thing they see).
On Fri, Mar 25, 2016 at 1:44 PM, danielsf<EMAIL_ADDRESS>wrote:

Follow up to my own post: I ran the idea by Simon and he saw no problem
with publishing sims tagged versions of lsst_apps. So, really, the only
thing we can't do for ourselves is guarantee the availability of conda
builds with any regularity.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/Twinkles/issues/190#issuecomment-201490339

I am fine with that.  I need to sit down with Mario and talk to him about implementing git-lfs in the conda-lsst build system, anyway.  I will try to broach the subject of who is going to be maintaining conda-lsst long-term when that happens.

On Mar 24, 2016, at 5:16 PM, danielsf<EMAIL_ADDRESS>wrote:
@cwwalter what do you mean by "stable"? Is a DM weekly release good enough?

@danielsf Sorry… missed this before.
What I meant was that, although having weekly releases is also fine, having a quickly moving sims version that is built against the stable DM version (I mean quarterly releases modulo version that have bugs which must be fixed) is valuable since it gives us a stable API base to build on when we are thinking about the sims work and not DM.
I’m open to be convinced otherwise on this, but having only one thing changing at a time and being able to look at the stable DM documentation is valuable.  I understand that sometimes we will also want to build on a new feature but I think an update to that release might happen in a deliberative fashion.

@cwwalter In principle, I agree with you.  I'm not sure if it's possible, though.  For example: sims cannot be built against DM v11.0, which, I think, is still the stable version of record.  Granted, that had to do with changes to afwCameraGeom, which I don't anticipate changing in the near future, but I cannot guarantee that something else we want to change won't come up between stable DM releases.
I think the problem is that Sims is operating on a much more rapid release schedule than DM and, as long as we are trying to maintain a unified LSST software framework, that is occasionally going to involve adding things to the DM stack in service of Sims and requiring us to build against something more modern than the last stable release.

@cwwalter
There are two kinds of API changes in the DM stack that you might worry about:

Those API that are directly called from sims that may have changed from a release to weekly builds
Those API that are only indirectly called by sims or not called at all.

For those in the first category, it would seem that two versions of sims code will need to be produced and maintained, one that corresponds to the stable release, and one that corresponds to weekly builds. I don't think this is done currently, and would probably be a lot of work even apart from creating a build.
For those in the second category, I think this is possible for the user to do this using eups, with different forms of tagging and also in conda using conda environments (for python this corresponds to building a package choosing the versions of different , but this may be a problem if there are static C++ libraries) without requiring a separate build. I have not exactly done this, and it is possible that I am forgetting something (like some problem with libraries). In practice though, I think most changes that we will worry about for which the new build is required will probably be of type 1.

I  think it would help us prioritize our requests if we kept track of the functionality or use-cases for the requests. This might be in terms of approachability for a casual user, functionality (some need in our workflow, so it could be done in an alternative way if such a method is available) or other categories that I am not thinking of.
Approachability: This was supposed to be for 'casual users' of Twinkles. I imagine this is for someone who would want to see what Twinkes is about and to gauge whether they will be interested in getting involved or if they can perhaps use Twinkes code/products for their projects and start off with Twinkles. I think in practice, the set of tasks a 'casual user' can perform will always be a subset of tasks that a more involved user can perform (which is not to say that things cannot or should not be made simpler for everyone). I think we need to define that approximate boundary
Functionality: Things we need for our setup to absolutely have
For example, in the meeting, when we were talking about conda binaries, I had in mind:
Approachability: for new users to be able to check out Twinkles workings
Functionality Aspects:

Running on continuous integration systems like travis quickly (eups distrib install takes more than 2 hours to install sims from scratch https://docs.travis-ci.com/user/common-build-problems/#My-builds-are-timing-out, but maybe the cacheing can help there too?)
Practical/Quick ways of getting Twinkles setup running on a cluster

@danielsf Yes, OK I agree.  Clearly we couldn't use V11.0 as you said.   What I meant by "deliberate" above was that I would imagine in those cases we could agree to bump to a  higher version (as opposed to just taking a weekly snapshot) when it became necessary.  But as both you and @rbiswas4 say that is going to be a lot of work and overhead.

The request to the project was made, and progress happened!


Remove #[derive(clap::Parser)] from Config

When integrating this into our internal services we ran into a few oddities that were caused by having #[derive(clap::Parser)] on Config:

Docs on the fields becomes help text for CLI arguments. You cannot specify the two separately which means things like default values are repeated in the help text, once from the doc comment and once #[clap(default_value = "...")].
Not clear whether Config's Default implementation should call clap or not. Getting env vars in Default is kinda odd but if you don't you have to duplicate the default values in the code.
Users might wanna customize the prefix used to env vars, that wasn't previously possible.

With this change Config is becomes just a regular struct. Users can then build then own CLI arg parsing and convert between their config and our config however they want. Thats a bit less convenient but probably worth it overall.

if one end up with a lot of small service apps using this and wanting to reduce boilerplate with them one could add this as an optional clap feature that has a small conversion struct from this config to a clap-compatible config. for a fully batteries-included (but optional) approach.
but starting without it and with this feels like the easiest and cleanest.


Change in the type structure

This PR closes #27 . All individual points are addressed for a consistent structure. From this PR, we can see that a lot of iteration utilities can be reused nowadays, although I have not yet implemented these, except for TreeNodes.
The naming changes lead to breaking changes for EnergyModelsInvestments, as we previously used (unnecessary) dispatch on StratPeriods.

LGTM


Install the Kubernetes Command Line Tool

Tutorial: https://developers.sap.com/tutorials/cp-kyma-download-cli.html
In step 3 you are saying: "Please note that the kubeconfig has an expiration and will have to be re-download once it expires."
Can you please add a note of how long the downloaded kubeconfig can be used?
Thanks a lot and best regards,
Iwona

Hi Iwona,
Thanks for the feedback. This will be included in the next push to production.

Hi Iwona,
Thanks for the feedback. This will be included in the next push to production.


dev: Normalize natspec comments and use them to generate docs from said natspec comments

Dev Request
Describe the Dev Request
Leverage and normalize natspec comments to have docs generated in the CI
We have non-uniform natspec comments in the codebase. For example:
https://github.com/sayajin-labs/kakarot/blob/74890cb0aa78380cdc484224ffbe4d8739a44e74/src/kakarot/stack.cairo#L55
in contrast with:
https://github.com/sayajin-labs/kakarot/blob/74890cb0aa78380cdc484224ffbe4d8739a44e74/src/utils/utils.cairo#L62

Describe Preferred Solution

normalize natspec docstrings
do the integration work on Kakarot to add doc generation and publishing as part of the CI, using https://github.com/onlydustxyz/kaaper

Hey, I did a first shoot, minor things to fix in the doc, but I'll stop for today.
Could you tell me if it match what you expect before I commit more on it?
Note:

I didn't work on natspec comments for now
I did the hosting manually, I need to dig a big more to manage the deploy through the CI. About this point, I was wondering if you wanted to host the react doc in this repo, an alternative could be to host the doc in another repo and "bind" CI to deploy the doc from the new repo when an event is send in this repo. It could be much more work but it could keep this repo cleaner.

What is the status of this? Should we close the issue @Bal7hazar ?

@Eikix it was not finish :sweat:
I needed this PR to be merged to start working on Kakarot natspec comments (clean things, etc.)
I'll try to finish it this week.

@Eikix it was not finished :sweat:
I needed this PR to be merged to start working on Kakarot natspec comments (clean things, etc.)
I'll try to finish it this week.

Do you know if natspecs or similar stuff will be kept for Cairo1 I would want your hard work to live long 🫡🤝

Do you know if natspecs or similar stuff will be kept for Cairo1 I would want your hard work to live long 🫡handshake

We will defintely need to upgrade kaaper to be Cairo 1.0 compatbile. It will also be a good opportunity to check if rust compatible doc generators do the job (then we could cancel Kaaper).

func exec_stop{
        syscall_ptr: felt*,
        pedersen_ptr: HashBuiltin*,
        range_check_ptr,
        bitwise_ptr: BitwiseBuiltin*,
    }(ctx_ptr: model.ExecutionContext*) -> model.ExecutionContext* {
        let ctx = ExecutionContext.stop(ctx_ptr);
        return ctx;
    }

These function are not parsed correctly by kaaper due to return format.
Options:

Take time to fix it in kaaper, then finalize the issue.
Ignore it, so all these functions will be ignored by kaaper and won't be inculded in the final documentation (until Cairo 1.0 I guess).
@Eikix


Add support for bumping external files

Codecov Report

Merging #9 (12df34f) into main (880fa75) will decrease coverage by 0.67%.
The diff coverage is 78.88%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   82.57%   81.90%   -0.68%
==========================================
  Files           4        4
  Lines         132      210      +78
==========================================
+ Hits          109      172      +63
- Misses         16       27      +11
- Partials        7       11       +4

Impacted Files
Coverage Δ

internal/git/utils.go
66.07% <45.83%> (-13.35%)
:arrow_down:

internal/semver/bump.go
86.48% <90.76%> (+8.30%)
:arrow_up:

internal/git/testing.go
88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880fa75...12df34f. Read the comment docs.


the attached hjson file can't be parsed

the following example can't be parsed. but it's legit.
you can verify it here https://hjson.github.io/try.html
{
  title : CodeStage example
  repo : https://github.com/shi-yan/codestage
  # need to have the slash
  prefix : ""
  target : dist
  url : "http://localhost:8000"
  meta_image : meta.png
  description :
    '''CodeStage is a static site generator to build JS playground demos.'''
  utilities : [ "khronos",  "tdl" ]
}

the error message I got was
Error: Eof at 11:3 at "utilities : [ \""

This would probably be solved with the work of @pamaury on multiline values in https://github.com/Canop/deser-hjson/pull/15

It should be OK now.
There are some tests at https://github.com/Canop/deser-hjson/blob/main/tests/multiline_strings.rs


git clone nvm with --depth 1, to make clone faster

nvm git repo has 1500+ commits, there's no necessary to clone the full repo.
So add --depth 1 when git clone to make it faster

Hi @Treri, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Awesome, thanks!


Avro Serializer

Have you ever thought of releasing an avro serializer that is able to integrate a schema registry?

That's a good point... it isn't something I've needed so far, but I can see how it could be useful. I'll add it to my todo list, but as I don't have any immediate need for it, I can't guarantee how soon I'll get to it.


Karpenter deleting drifted nodes with reason SecurityGroupDrift even though there is no change in the security group

Description
Observed Behavior:
Karpenter deleting nodes with reason securityGroupDrift even though there is no change In the security group.
Karpenter Logs:
{"level":"DEBUG","time":"2024-09-02T10:22:25.036Z","logger":"controller","caller":"disruption/controller.go:91","message":"marking drifted","commit":"62a726c","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","NodeClaim":{"name":"al2-9x6cm"},"namespace":"","name":"al2-9x6cm","reconcileID":"ef9fbbda-8a18-4ebc-8378-e1455235597a","reason":"SecurityGroupDrift"}

Expected Behavior:
There should be no deletion of nodes with reason securityGroupDrift
Reproduction Steps (Please include YAML):
apiVersion: karpenter.sh/v1
kind: NodePool
metadata:
  annotations:
    karpenter.sh/nodepool-hash: "18440777320956233133"
    karpenter.sh/nodepool-hash-version: v3
    meta.helm.sh/release-name: nodepool
    meta.helm.sh/release-namespace: karpenter
  creationTimestamp: "2024-09-02T10:06:11Z"
  generation: 1
  labels:
    app: raw
    app.kubernetes.io/managed-by: Helm
    chart: raw-0.2.3
    heritage: Helm
    release: nodepool
  name: al2
  resourceVersion: "867401464"
  uid: 714495e7-f180-4841-b8ee-e358cc40256b
spec:
  disruption:
    budgets:
    - nodes: 10%
    consolidateAfter: Never
    consolidationPolicy: WhenEmpty
  limits:
    cpu: "120"
    memory: 320Gi
  template:
    metadata:
      labels:
        errors.ea.com/linux-distro: al2
    spec:
      expireAfter: 720h
      nodeClassRef:
        group: karpenter.k8s.aws
        kind: EC2NodeClass
        name: al2
      requirements:
      - key: topology.kubernetes.io/zone
        operator: In
        values:
        - us-east-1a
        - us-east-1b
      - key: node.kubernetes.io/instance-type
        operator: In
        values:
        - c5.large
        - c5.xlarge
        - c5.2xlarge
        - c6i.large
        - c6i.xlarge
        - c6i.2xlarge
        - m5.large
        - m5.xlarge
        - m5.2xlarge
        - m6i.large
        - m6i.large
        - m6i.2xlarge
        - r5.large
        - r5.xlarge
        - r6i.large
        - r6i.xlarge
        - t3.small
        - t3.medium
        - t3.large
        - t3.xlarge
        - t3.2xlarge
      - key: kubernetes.io/arch
        operator: In
        values:
        - amd64
      - key: kubernetes.io/os
        operator: In
        values:
        - linux
      - key: karpenter.sh/capacity-type
        operator: In
        values:
        - on-demand

apiVersion: karpenter.k8s.aws/v1
kind: EC2NodeClass
metadata:
  annotations:
    karpenter.k8s.aws/ec2nodeclass-hash: "2204428126396386490"
    karpenter.k8s.aws/ec2nodeclass-hash-version: v3
    meta.helm.sh/release-name: nodepool
    meta.helm.sh/release-namespace: karpenter
  creationTimestamp: "2024-09-02T10:06:11Z"
  finalizers:
  - karpenter.k8s.aws/termination
  generation: 1
  labels:
    app: raw
    app.kubernetes.io/managed-by: Helm
    chart: raw-0.2.3
    heritage: Helm
    release: nodepool
  name: al2
  resourceVersion: "867406141"
  uid: 78db21aa-dded-40a8-aa1a-02770631c7c6
spec:
  amiFamily: AL2
  amiSelectorTerms:
  - alias: al2@latest
  metadataOptions:
    httpEndpoint: enabled
    httpProtocolIPv6: disabled
    httpPutResponseHopLimit: 1
    httpTokens: required
  role: KarpenterNodeRole-XXX
  securityGroupSelectorTerms:
  - tags:
      karpenter.sh/discovery: XXX
  subnetSelectorTerms:
  - tags:
      karpenter.sh/discovery: XXX

Versions:

Chart Version: 1.0.1
Kubernetes Version (kubectl version):

Client Version: v1.23.15
Server Version: v1.30.2-eks-db838b0

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Are there any process inside of the account that would be tagging/untagging security group(SG)? Keep in mind SG drift is considered a special case of drift. If SGs inside of the AWS account are being tagged or untagged that karpenter discovers, that can causel nodes to be drifted.

I don't think that there are any processes inside the account or EKS cluster that might be modifying the tags. Karpenter is still deleting the nodes even when I disable Drift from budgets.

Since you have not defined any budget that relates to drift, all drifted nodes will be disrupted. Budgets only block based on what is defined or else it defaults to allow disruption: https://karpenter.sh/docs/concepts/disruption/#reasons. To block drift you will need to an additional budget as such:
budgets:
  - nodes: "10%"
    reasons:
      - "Empty"
      - "Underutilized"
  - nodes: "0"
    reasons:
      - "Drifted"

Are you able to see the security groups that are discovered in the status of the EC2NodeClass? If the  SGs are updated then karpenter is discovering new SGs in the account.

Yes, I can see that it is discovering the correct SG in the EC2NodeClass.
  - lastTransitionTime: "2024-09-02T10:06:11Z"
    message: ""
    reason: AMIsReady
    status: "True"
    type: AMIsReady
  - lastTransitionTime: "2024-09-02T10:06:11Z"
    message: ""
    reason: InstanceProfileReady
    status: "True"
    type: InstanceProfileReady
  - lastTransitionTime: "2024-09-02T10:06:11Z"
    message: ""
    reason: Ready
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-09-02T10:06:11Z"
    message: ""
    reason: SecurityGroupsReady
    status: "True"
    type: SecurityGroupsReady
  - lastTransitionTime: "2024-09-02T10:06:11Z"
    message: ""
    reason: SubnetsReady
    status: "True"
    type: SubnetsReady
  instanceProfile: XXX
  securityGroups:
  - id: sg-XXX
    name: YYY
  subnets:
  - id: subnet-XXX
    zone: us-east-1b
    zoneID: use1-az2
  - id: subnet-XXX
    zone: us-east-1a
    zoneID: use1-az1

I noticed that some Security Groups are managed by our organization and are automatically added to nodes. My question is, will Karpenter detect these security groups, even if they aren't tagged for discovery, and subsequently mark the node as drifted?

Yeah, if there is another process in the account adding security groups to a node or tagging a security group. Karpenter will detect those changes and consider the node drifted if the EC2NodeClass and instance security groups are not the same https://github.com/aws/karpenter-provider-aws/blob/c83c154504ca0e0b172ca3c8ac0c923ad9c1996c/pkg/cloudprovider/drift.go#L110


Impossible to compile OBJCXX Test

Windows version: Windows 10 Education
Visual studio version: Visual studio Enterprise 2015
Build in 32-bits
When I'm trying to build the Test solution under Visual studio Enterprise 2015, I have these errors:

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2440	'reinterpret_cast': cannot convert from 'overloaded-function' to 'IMP'	Test	C:\Users\...\OBJCXX-master\OBJCXX-master\OBJCXX\include\OBJCXX\ClassBuilder.hpp	138

Severity Code	Description	Project	File	Line	Suppression State
Error	C2198	'bool (__cdecl *)(Class,SEL,IMP,const char *)': too few arguments for call	Test	C:\Users\...\OBJCXX-master\OBJCXX-master\OBJCXX\include\OBJCXX\ClassBuilder.hpp	140

Any Idea ?
Thanks :),
Heru.

Thanks for the report. This issue has been fixed in 6cd9b53be63aa8040a291b03a2008a6217778eac.


Update the projects list

Detailed description
As we have already completed these below mentioned projects they should be removed from the List to fix.
https://github.com/TheAlgorithms/C-Plus-Plus/projects/6#card-63413879
https://github.com/TheAlgorithms/C-Plus-Plus/projects/6#card-63413841
https://github.com/TheAlgorithms/C-Plus-Plus/projects/6#card-63413788
Context
To keep our TODO list updated.
Possible implementation
Remove the completed projects from the list.
Additional information
No response

Updated. Thank you for reporting. 🙂


add bundler:audit rake task

run with bundle exec rake bundler:audit
run task with travis

Can you please update the PR to describe what bundler:audit does and why we should merge this? Thanks.

@bradleywright the task bundler:audituses https://github.com/rubysec/bundler-audit, which checks for vulnerable versions of gems in Gemfile.lock
I will update the PR description

I just noticed that the repo for bundler audit is not very descriptive, it downloads https://github.com/rubysec/ruby-advisory-db and uses that db to check against the versions of gems used in your application.


Waiting 5.0 Data

finally we can open new region, still waiting to get 5.0 update. enjoy your time traveler :)

hang on i gotta speed run the simulanka event first xdd

published


Building on windows: issue and solution.

Took me a while to work out - the build.py (and associated scripts) on a windows machine fail with a not very useful error if the directory path contains a space character (which github desktop defaults to including); they also won't download the libraries from the other githubs unless the path to the git command line executable is added (which the desktop github for windows doesn't do automatically).

Thanks for reporting @LovelyXandy. Sorry to hear you didn't have the smoothest ride here.
Perhaps you could advise a fix when you have a bit of spare time @jamesadevine? I think you know that script better than anyone?

Have you got a repro @LovelyXandy?

I think https://github.com/lancaster-university/microbit-v2-samples/pull/10 will help build.py work with spaces.
I haven't hit the problem with the git command path.

PR created:

https://github.com/lancaster-university/codal/pull/50


Time Sheet Filling

What's up?
No response
To Do
Kindly request to fulfill weekly time sheet.
Checklist

[x] Elif Bayraktar
[ ] Serdar Akol
[ ] Sena Mumcu
[x] Karahan Sarıtaş
[ ] Mustafa Cihan
[ ] Serhat Hebun Şimşek
[x] Doğukan Türksoy
[x] Furkan Keskin
[ ] Metehan Dündar
[x] Sinem Koçoğlu

Deadline
29.05.2022 @23.59
Additional Information
No response
Reviewers
No response

As our work for CmpE352 finished, there is no point keeping this issue open. No further action is taken, closing the issue.


First pass of parsing entity xml

Key issues to work out:

Unified parsing of form defs

Ideally, entity parsing happens at the same time a form def is uploaded and parsed for the existing reasons (extracting form fields and their types). The form def data comes in from the request stream and is processed as as stream.

Namespaces and namespace prefixes

We're trying to support a new entities namespace: xmlns:entities="http://www.opendatakit.org/xforms/entities". The prefix could be anything, not just entities: But given the stream reading issues above, it's tricky (but probably not impossible) to read and check for namespace mappings at the beginning of the stream and use them later. We might need to get into the core Iteratee code (lib/util/xml.js) to do this. This might look like tracking the namespace mappings once we see them and being able to use them in node processing, i.e. looking for entity/create nodes of any namespace but then confirming the namespace on that node. Or we could take a different approach to this whole issue, like with a convention prefix.

Double-checking the meaning of ref/saveTo attributes on bind

Related to namespace issues above, we were discussing what to call the attribute in a bind statement that specifies the entity prop that a form field maps to, and how critical having the entities namespace is. The latest notes in the spec now have this being called saveTo.

FYI: This branch is getting really experimental trying to find the possible/best places to entity extraction code.

replaced by newer and better PRs


Error message on func git config set when PAC is not installed

A minor fix could be applied on the error message on func git config set when when pipeline as code is not installed. It prints %!w(<nil>)
$ func config git set
...
Error: failed to run generate pipeline: pipelines as code not installed: %!w(<nil>)

/kind good-first-issue


React Native

I think that the HCI classes would like to have their students do some Mobile apps.  Maybe flesh out the PWA section a little more.  Or do more with react native.

Dan, Mark, and Lee met. The resolution was that React Native was too difficult to work with at this phase of the student's development.


Travis for iOS

The podspec changes are already merged into grpc/master; not sure why they show up here again.

This is the result for my repo's branch: https://travis-ci.org/jcanizales/grpc/builds/88049191

The only other author is already added to this PR, Googlebot.

CC: @murgatroid99 :)


Feat/Msm with gpu (metal shader language) on laptop

Accumulation state algorithm in Metal is implemented at mopro-core/src/middleware/gpu_explorations/metal/.
points and operations using BLS12381 curve was integrated and we converted them into BN254.
current report

The result of metal_msm that runs 2^10 (1024) randomly-chosen points and scalars:
Run metal msm benchmarking
    ```bash
    cargo test --release --package mopro-core --lib -- middleware::gpu_explorations::metal::msm::tests::test_benchmark_msm --exact --nocapture
    ```

    Result:
    ```
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.059988125s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.037813333s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 6.948694125s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 6.983621s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.005291583s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.019227875s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.026516125s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.037779959s
    test middleware::gpu_explorations::metal::msm::tests::test_benchmark_msm has been running for over 60 seconds
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.017979667s
    Average time to execute MSM with 1024 points and scalars in 1 iterations is: 7.042247291s
    Done running benchmark: Ok([7.059988125s, 7.037813333s, 6.948694125s, 6.983621s, 7.005291583s, 7.019227875s, 7.026516125s, 7.037779959s, 7.017979667s, 7.042247291s])
    test middleware::gpu_explorations::metal::msm::tests::test_benchmark_msm ... ok
    ```

Hi, @vivianjeng I've rebased to main and adapted changes from the code reviews above. After the review from @FoodChain1028 , we can consider to merge it back to main.


Update Esprima

Currently using ~1.0.4. The latest version is 2.1.0.
Esprima 2.x significantly improves ES6 support.

I am fine with this, want to open a PR?

I'll have a go, but feel free to beat me to it :-)

I am closing this issue due to inactivity


great job! keep it up :)

Thanks :)

I especially like how the docs include a remark precisely addressing my confusion / frustration regarding the return type.
Lets leave this as an open ticket for now?


Save chat history for user

Describe the feature or improvement you're requesting
I Saw this feature on this repo's trello, and im working on it
Additional context
No response

@TaylorHawkes do you think we can save on localstorage for now?

I just opened the pull request for this feature/issue #11 @TaylorHawkes

https://github.com/TaylorHawkes/ChatGPTArms/pull/11#issuecomment-1495135383


Check device sensors

Hi ! there is a way to check if the device has some sensors? My phone dont have gyroscope and I get a error but my app will be use some features with gyro and other without it, react-native-sensors let me check sensors before start?

I think it should be checkable if you use the rxjs syntax and check if the promise is rejected. I guess, we should also include it somehow in the observable syntax.
Would you rather

Always get a null from the sensor
Have a dedicated error prop that you can check
both

What do you think is the best one to use?

Thanks for your response @DanielMSchmidt I'm a little busy these days but as sonn as possible I'll check that solution and update this issue, thanks again

Hi! I have just created a pull request to solve that. It was a problem to me because I want to know at the beggining if I'm able to use the sensor or not.
Whilt it is reviewed you can install by npm install -S github:dabit1/react-native-sensors#master
The pull request:
https://github.com/react-native-sensors/react-native-sensors/pull/47

We have one problem, that there is no support for this functionality in windows. The person adding windows left the project, so I will remove windows for now.

@dabit1 @darioodiaz Please check out version 3.0.0-0 and see if it works. Once I got the OK from you I will publish the official 3.0.0 release 👍  Thank you for dedicating time to this project 👍


MM-29853: Expose plugin-apps REST APIs

Summary
Expose plugin-apps REST APIs
Ticket Link
https://mattermost.atlassian.net/browse/MM-29583

Codecov Report

Merging #52 (b7090ac) into master (831d203) will increase coverage by 0.13%.
The diff coverage is 14.78%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   21.51%   21.65%   +0.13%
==========================================
  Files          25       19       -6
  Lines         674      605      -69
==========================================
- Hits          145      131      -14
+ Misses        520      468      -52
+ Partials        9        6       -3

Impacted Files
Coverage Δ

server/api/impl/appservices/subscriptions.go
0.00% <0.00%> (ø)

server/api/impl/proxy/expand.go
0.00% <0.00%> (ø)

server/api/impl/proxy/manifest.go
0.00% <0.00%> (ø)

server/api/impl/proxy/proxy.go
0.00% <0.00%> (ø)

server/api/impl/store/apps.go
0.00% <0.00%> (ø)

server/http/restapi/bindings.go
0.00% <0.00%> (ø)

server/http/restapi/call.go
0.00% <0.00%> (ø)

server/http/restapi/restapitestlib.go
0.00% <0.00%> (ø)

server/http/restapi/subscribe.go
0.00% <0.00%> (ø)

server/api/impl/proxy/bindings.go
23.40% <25.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831d203...b7090ac. Read the comment docs.

Codecov Report

Merging #52 (b7090ac) into master (831d203) will increase coverage by 0.13%.
The diff coverage is 14.78%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   21.51%   21.65%   +0.13%
==========================================
  Files          25       19       -6
  Lines         674      605      -69
==========================================
- Hits          145      131      -14
+ Misses        520      468      -52
+ Partials        9        6       -3

Impacted Files
Coverage Δ

server/api/impl/appservices/subscriptions.go
0.00% <0.00%> (ø)

server/api/impl/proxy/expand.go
0.00% <0.00%> (ø)

server/api/impl/proxy/manifest.go
0.00% <0.00%> (ø)

server/api/impl/proxy/proxy.go
0.00% <0.00%> (ø)

server/api/impl/store/apps.go
0.00% <0.00%> (ø)

server/http/restapi/bindings.go
0.00% <0.00%> (ø)

server/http/restapi/call.go
0.00% <0.00%> (ø)

server/http/restapi/restapitestlib.go
0.00% <0.00%> (ø)

server/http/restapi/subscribe.go
0.00% <0.00%> (ø)

server/api/impl/proxy/bindings.go
23.40% <25.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831d203...b7090ac. Read the comment docs.


Modify sonarqube docs to handle new sonar token behaviour

in qps-pipeline#745 there was a set of modifications to the sonarqube token configuration, need to update sonar docs to display such changes.

Token assignation is now part of registerOrganization job.
Modify .sonarqube file properties to match https://github.com/qaprosoft/carina-demo/commit/ea5ee9576770215dc2e9b308fbad556c2b33f73f for single maven projects.
Modify .sonarqube file properties to mach https://github.com/qaprosoft/carina/commit/3897b8c32990e82e212bfc749a0571f9599b6760 for multi maven projects.
Add set of permissions that the sonar token should have.

changes could be seeing in #178

Verified


Make preBuffer int type

Janus API accepts preBuffer as an integer

@all-contributors please add @musagil for code


Add missing require in dev-cmd/irb.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

Fixes https://github.com/Homebrew/brew/issues/9362.

Review period skipped due to critical label.

thanks for the quick fix!


set medium priority for process signed block - 2.0.x

Change Description

This is change related to EOSIO/eosio-security#340,
Still see the unlinkable block for each restart but it is expected when switching from in-sync to head-catchup and that is the current block that the node just produced
Co-Authored-By: Kevin Heifner<EMAIL_ADDRESS>Change Type
Select ONE

[ ] Documentation

[x] Stability bug fix

[ ] Other

[ ] Other - special case

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

0

Will do more testing on 2.0.x with config bp<--API<--API.

It works fine after test env config fix, see less " Unlinkable block", and syncing can always be re-established.

For more information see #9369

merged on behalf of Yue


UFO auto closes all folds (zM) on text change

Neovim version (nvim -v | head -n1)
0.7
Operating system/version
Arch Linux
How to reproduce the issue
https://user-images.githubusercontent.com/102876811/174476410-87af1302-71de-47bc-bc1d-b0bb4cefdb89.mp4
Expected behavior
I want to open / close my folds manually.
Actual behavior
It closes all folds when the text change.

https://github.com/kevinhwang91/nvim-ufo/issues/7
It's easily solved by saving foldlevel before zR and restoring after. I am considering add an action for that.

Thanks for the plugin :)

I'm having this same issue and nothing seems to fix it. Any text change auto closes everything.


[slugification] When using Thai and Japanese, the automatically generated slug is empty

Upon further investiation unfortunately looks like the underlying package (https://github.com/sindresorhus/slugify) does not support these languages.


Implement equivalent of gradcheck from PyTorch

During today's tutorial @jhueckelheim mentioned PyTorch's gradcheck. We already have something similar in the tests but only for scalar functions.
@jhueckelheim also mentioned some better ways of doing it.

Resolved by EnzymeTestUtils


feat: add variable to configure auto-sync of the Argo CD Application

two features: remove autosync and add release-please with target_revision
these features has been tested on a Scaleway instance

Approved. I had to do a rebase to change one of your last commits so we pass our linters for conventional commits. Make sure that when you accept changes on the GitHub web UI you still need to set commit messages otherwise our checks will not let us merge the PR. For now its not that important as we are doing Squash and merge but in the future we might force Rebase and merge as this way every relevant commit in the PR will appear on the changelog by our Release-Please pipeline.
Do not forget to add the comment Release-As: v1.0.0-alpha.3 when merging this PR.


Revert "Shelve"

Reverts assembla/subversion#1
... because I chose to merge that PR by "rebasing", which applied 4 new commits that are different from the original 4 commits, whereas what I wanted was to simply update this fork to look the same as if it were a brand new fork, which I believe would most neatly be accomplished by a "fast-forward" merge.

But GitHub's "revert" option creates more new commits. Instead I think I need to "reset". So closing/deleting this PR.

I deleted those 4 commits, by means of:
$ git checkout shelve
$ git reset --hard HEAD~4
$ git push origin +shelve


[IGNORE] Test Issue - Attempt 2

Creating this issue to test ADO sync workflow. Test 3.

This is awesome!!!!

Creating this issue to test ADO sync workflow. Test 3.

HI

pls work

Making sure the sync works here aswell.


fix: Unblock rake from v12 after forking as we are on v13 in some ser…

…vices

@michaelklishin would it be welcomed to open PR to unlock rake? This prevents me from using latest sneakers in my project.


SUBMARINE-79. Solve potential NPE for MockRemoteDirectoryManager

What is this PR for?
Solve potential NPE for MockRemoteDirectoryManager
MockRemoteDirectoryManager#getModelDir:
File modelDir = new File(modelParentDir.getAbsolutePath(), modelName);
If modelParentDir is null, we could have an NPE easily.
What type of PR is it?
[Bug Fix | Improvement ]
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-79
How should this be tested?
https://travis-ci.com/cchung100m/submarine/builds/152619875
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@liuxunorg
Thanks for managing this PR. :)


Upgrade to bootstrap 4 beta

Bootstrap 4's beta version has been released. We should upgrade from the alpha version provided @ng-bootstrap is compatible

https://github.com/twbs/bootstrap/issues/24078
I would wait until the bootstrap 4 CSS only package is released. We probably do not want jquery or popper.

As discussed in today's meeting, we'll upgrade to beta now, but switch to bootstrap-css when it comes out.
https://github.com/DSpace/dspace-angular/issues/154

This upgrade is complete. An issue has been opened to address the peer dependency warnings. #154.
Please refer to Bootstrap 4 for styling and variables. Refer to ng-bootstrap for functional UI components.
Closing now.


Editable Rich Text

Also Refactored Quite a bit to support the abstract classes and code duplication

Great enhancements!
Thanks @rodydavis

Got pub.dev package errors:

Fix lib/src/custom_text_field.dart. (-99.99 points)

Analysis of lib/src/custom_text_field.dart failed with 33 errors, 2 hints, including:

line 66 col 14: Case expressions must be constant.

line 66 col 29: The getter 'macOS' isn't defined for the class 'TargetPlatform'.

line 90 col 14: Case expressions must be constant.

line 90 col 29: The getter 'macOS' isn't defined for the class 'TargetPlatform'.

line 108 col 14: Case expressions must be constant.

Fix lib/src/flutter_syntax_edit.dart. (-1 points)

Analysis of lib/src/flutter_syntax_edit.dart reported 2 hints:

line 134 col 25: This function has a return type of 'bool', but doesn't end with a return statement.

line 165 col 27: This function has a return type of 'bool', but doesn't end with a return statement.

Format lib/src/syntaxes/javascript.dart.

Run flutter format to format lib/src/syntaxes/javascript.dart.

looks like custom_text_field.dart has some conflicted code with the package

I’m doing this on master, what about you?

There was a package in pub.dev and i got these erros after i updated it.
also the problem occurs in my machine when i try to test it fater the merge.
have you faced any problem like that while you was testing ?

No I didn’t, but I can check today!

Thanks! here's some info about the platform i work on:
[√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft
Windows [Version 10.0.16299.1029], locale en-US)
• Flutter version 1.12.13+hotfix.8 at
E:\Dev\SDKs\FlutterSDK\flutter
• Framework revision 0b8abb4724 (12 days ago), 2020-02-11
11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0


Pod version is outdated

I tried to use this library using pod, but this version is not the same as when you download the code

Yes, skipNegotiation in options

Are you seeing failures related to jumping the servers resulting in error
when starting the connection or you want to use it for a different purpose?
On Tue, Sep 24, 2019, 12:05 PM Khaled Khaldi<EMAIL_ADDRESS>wrote:

Yes, skipNegotiation in options
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/moozzyk/SignalR-Client-Swift/issues/74?email_source=notifications&email_token=AAK7JJHGMXZ3SYRBNDQMS5DQLJQG5A5CNFSM4IZ7YAL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7PO45Y#issuecomment-534703735,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAK7JJFO7BZOOXTLDMJLIHLQLJQG5ANCNFSM4IZ7YALQ
.

I updated the version on CocoaPods to the latest version today.


⚠ Bofrost.fr has degraded performance

In 5d2f57e, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1305 ms

Resolved: Bofrost.fr performance has improved in 29da0f1 after 7 minutes.


Commander incompatible with dialogue commands

Hiya! just letting you know; dialogue based commands don't seem to be working.
Eg;
[ /commander create "/tellraw @a ["Hello World"]" CONSUME SERVER 200 ] wont work thanks to the command itself featuring the quotation marks the plugin uses to define its commands.
Is there any work arounds i'm missing, or is this a bug?
Thank you!

Heyo!
The mod works with those commands, BUT you either:

Escape your qoutation marks with \ like this: \"

/commander create "/tellraw @a \"Hello World\"" CONSUME SERVER 200

OR

Use different quotations, like the apostrophe sign '

/commander create '/tellraw @a "Hello World"' CONSUME SERVER 200

This should be added to the FAQs, but for now I'll just pin the issue.
Thank you for your report!


feat(ffi)!: Separate verification and publishing options

This change makes the verifier FFI easier to work with because the publishing options are split from the verification options.
The verification options should apply to all pact sources (such as file and URL) because they contain global settings such as request timeouts and callbacks.
However, the publish options only make sense when a Pact Broker is configured. This made the FFI tricky to use from library code (in particular from PactNet) because that meant you could only set the global verification options when using a Pact Broker source, instead of when using any source. This change will allow that happen properly in future.
As an aside, I didn't find any unit tests to update at all for this, which is a bit concerning.

Awesome, thanks Adam!

RE: tests, for previous FFI changes I've made, I've created an acceptance suite. I haven't looked at the FFI code here in detail, but for the functions exposed as the c interface they lend themselves more to this style of test. There is likely other glue code below this that could be tested differently.

The only type of tests I would expect is testing behavior when a NULL pointer is passed in. They should just be wrapping other functionality that should have the unit tests.


[ENHANCEMENT] add libnvme, nvme-cli and uuid-devel to harvester OS

Is your enhancement related to a problem? Please describe.
To support NVME over TCP, we need libnvme and nvme-cli packages.
Describe the solution you'd like

Install libnvme and nvme-cli by default
And uuid-devel (a requirement for Longhorn v2 engine).

Describe alternatives you've considered
None
Additional context
None

Changes are being tested in the OBS build Dockerfile for the baseos; it does not appear that a change is required in the github repository.

Also, the description mentions "libnvme".  The zypper package named "libnvme" is a source code package and it seems unlikely that the source code is what is required.  Installing the "nvme-cli" package will automatically bring in the runtime library  /usr/lib64/libnvme.so etc

uuid-devel is not in the available set of package repositories in the current way things build in OBS.  We'll have to figure out how to solve this.

@Vicente-Cheng could you clarify why the uuid-devel package is required for the Longhorn v2 engine?

https://longhorn.io/docs/1.5.0/spdk/quick-start/#install-nvme-userspace-tool-and-load-nvme-tcp-kernel-module

I think we can remove this because after longhorn v1.5.2. It builds in on the instance-manager pod.
Related issue: https://github.com/longhorn/longhorn/issues/6798

It should be used for built time. If could, let's don't add this to the host.

I'm going to separate the uuid-devel package from this issue.

I believe this is now completed for 1.3.0

Close it because we can verify the whole package things together.
Ref: https://github.com/harvester/harvester/issues/4595#issuecomment-1899560946


'Meta' object has no attribute 'app_config'

I'm getting the error: 'Meta' object has no attribute 'app_config' when trying to access /admin
Mezzanine 4.1.0
Django 1.9.6
Python 3.4.4
MySQL 5.7.10
Darwin 15.5.0

Which version of django-constance?

The latest version (1.2)

See the linked issue in Mezzanine for more detail. Basically it appears that constance registers a fake model class, with a fake meta class, against an admin class, which doesn't conform to the same members as django.db.models.options.Options.

Cool. Thanks.

Any ideas?


merge 3 repeated keyword.operator.comparison.r in r.json file.

What problem did you solve?
I found there are two Def. of keyword.operator.comparison.r and one keyword.operator.comarison.r (without letter p), I think it is a typo, so I put them together.
(If you have)Screenshot
No
(If you do not have screenshot) How can I check this pull request?
Please use diff to check the changes.

@Jieli12 Thank you for your first pull request.
LGTM.


Create your own Fiori Launchpad

Hi!
I followed the tutorial and it worked so far despite most of the screenshots not loading on your website. I have the fiori Launchpad, but while I see the drop down for the SAPUI5 version will the system not let me choose anything else than Innovation. When I click custom does it simply flip back to Innovation...

Hi there! It looks like you no longer need to update the version of SAPUI5 on the Fiori Launchpad, so please ignore that step and continue. Sorry for the delay!
Thank you,
Meredith


adding zenodo metadata

Per @castelao's excellent suggestion, to capture author orcids ahead of release.
@s-good that looks like your ORCID, but please double check; @castelao I lifted your entry right out of your example, lmk if that's all current and accurate.

Hi, yes that's my ORCID.


Create OWNERS file in main branch

Description

Update OWNERS per https://issues.redhat.com/browse/RHOAIENG-2311
Approvers are everyone in the Model Serving Team
Reviewers are everyone in the relevant subteam
How Has This Been Tested?

No need to test
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/retest


Balder/transfer when selecting the best

@arnej27959 PR

@havardpe PR
We are holding this one until the @havardpe is back from vacation and can review this one.

@havardpe I suggest pulling this one in now. It is currently not possible to trigger the filter code currently so this should be fine.
Renaming and proper fix for rescaling I suggest we discuss tomorrow.


Only include the optimized .wasm in our re_web_viewer_server crate

Because of #1327 we now include both the debug and release version of our .wasm, more than doubling the crate.
See https://github.com/rerun-io/rerun/pull/1518#pullrequestreview-1335848774

We do this now since a few weeks


Login issues on hub.grid.tf

No data shown on app. Selecting the correct icon but nothing happens so no login. Blocking our devs

https://hub.grid.tf/

Due the update to null safety support, null values are almost never accepted anymore. I assumed 3th party apps without asking any scope as required data would provide just an empty scope as JSON object, but tf-hub didn't add any scope as parameter, which returned into null in the app, since the new update of the app this broke the login attempt.

Quick fix => added an empty scope object as parameter in tf-hub = DONE
On our side, we will fix the error and redeploy it to the app / playstore


Setting window size according to the screen size or maximize the window

I am using tr1ckydev/webview-bun. I want to launch a maximized window. Currently, I achieved this using.
// index.ts

import { Webview, SizeHint } from "webview-bun";
const document = new Webview(true, { width: 300, height: 300, hint: SizeHint.NONE });

document.bind('setWindowSize', async (height: number, width: number) => {
    document
        .size = { height, width, hint: SizeHint.FIXED };
    return true;
});

document
    .setHTML(await Bun.file(require('path').join(import.meta.dir, 'index.html')).text()); document.run();

<!-- index.html -->
<html lang="en">

<head>
    <title>Document</title>
</head>

<body>
    <script>
        (async () => {
            await setWindowSize(Math.round(window.screen.availHeight), Math.round(window.screen.availWidth));
        })();
    </script>
</body>

</html>

This is also well achieved, and it launched with maximized window. But the problem is the window is first opened at center respect to the height and width set as 300. After resetting the width and height, it simply increases the width and height from the position it launched, is it possible to set the window position to (0,0) or internal way to maximize the window.

Sorry, but currently there is no API for doing that. Also, I believe you want to make the window "maximized" and not merely set dimensions manually. You can take the document.unsafeWindowHandle which is a pointer to the GTKWindow (if you are on linux) and pass it to some ffi function which can maximize the window state.


Plots section collapse review

Do not collapse the section when clicking on the empty space on the right side of the title, but collapse only when clicking on the chevron-shaped mark beside the section title.
When a chevron-shaped mark hovered, show pointer (cursor)
Hover over the information mark (i) on the right side of the section title open the tooltip -> select the text of the tooltip -> release the left mouse button, the entire section is collapsed
Select the title to copy -> release the left mouse button, the entire section is collapsed
Select the title to copy -> right click is not working, no context menu with the text copy option is opened

Do not collapse the section when clicking on the empty space on the right side of the title, but collapse only when clicking on the chevron-shaped mark beside the section title.

I don't mind changing that, but I just want to point out that we are currently using the built-in mechanism of the <details>  HTML element for the collapse behaviour. I think it would be possible to keep the current behaviour (less code, and more performant) and simply reducing the width of the <summary> element (the section title).
Other points should be possible to fix easily as I've already done something similar elsewhere.

Great! Another thing to mention: does the section title needs to be part of the trigger or only the chevron-shaped mark? If one day (and it is probably coming soon) we will be able to modify or copy the title, better if it won't be part of the section collapse trigger.

Sound good. Thank you @sroy3 !

I have noticed that when the section is collapsed and you click on the chevron it takes somehow more time to uncollapse the section than collapse.

Hovering over the info icon -> Copy text -> Right click won't do anything. I would expect to have the context menu with the copy option.

Select the title to copy -> right click is not working, no context menu with the text copy option is opened

It still not working. Is there a reason?

I would like only to copy the title -> double click -> section is collapsed. This is confusing as I did not want to collapse, the section, but only copy the text. Any suggestions here?

Let's not do this for now folks. It's good enough and we need to tackle bigger problems with the plots first.


EF7 One to one relation results tables associated with simple one to many relationship

Even when I try  the sample code in Microsoft ef7 one to one docs the result is blog and blogimage as one to many
Sample from Ms site https://docs.efproject.net/en/latest/modeling/relationships.html#one-to-one
class MyContext : DbContext
{
public DbSet Blogs { get; set; }
public DbSet BlogImages { get; set; }
    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        modelBuilder.Entity<Blog>()
            .HasOne(p => p.BlogImage)
            .WithOne(i => i.Blog)
            .HasForeignKey<BlogImage>(b => b.BlogForeignKey);
    }
}

public class Blog
{
    public int BlogId { get; set; }
    public string Url { get; set; }

    public BlogImage BlogImage { get; set; }
}

public class BlogImage
{
    public int BlogImageId { get; set; }
    public byte[] Image { get; set; }
    public string Caption { get; set; }

    public int BlogForeignKey { get; set; }
    public Blog Blog { get; set; }
}

Are you using RC1? If so, the work to introduce indexes on FK properties wasn't yet done. We've since implemented this so that you'll get a unique index on the FK property of a one-to-one (https://github.com/aspnet/EntityFramework/pull/3764). This will ship in RC2.

yes im using the "EntityFramework.MicrosoftSqlServer": "7.0.0-rc1-final"
thank u anyway and i hope u release the RC2 soon

the problem still exist in rc2

Reopening. From talking to @ajcvickers and @smitpatel it seems we don't affect the uniqueness of the FK side when setting up a 1:1 relationship.

@divega I don't think we talked about this. The code above explicitly creates a one to one relationship using the fluent API. The original bug was the Migrations ignores our metadata about this and instead relies on the idea that we will by convention also create a unique index for the FK column. Therefore if you use Migrations to create the database you will get a unique index on the FK column, unless you remove that unique index, in which case you won't. Regardless, the relationship is always one to one in our metadata and treated as such.
What we discussed on Friday was that if the relationship would be one to many in our metadata because it has only one reference nav property, then we won't check to see if the app put an explicit unique index on the FK property and use this to change the relationship to one to one.

@1amirjalai can you open a new issue with details of the issue you are seeing (be sure to include code to reproduce the issue etc.).

@rowanmiller the issue is created here #5623

Closing this as all the relevant details are in #5623.


Failure processing step

Feature request:
It would be nice to have special step that is executed during failure when job stopes processing next steps.
This ability can be used in following case when
job should collect and publish artifacts just at the end.

It can be done currently additng special final step but it is not called during failure on one of the previous steps.
onfail does not help because it can describe commands but can not publish using archiveArtifacts

pipeline_stop is always executed and it has env variable indicating succ/fail, plz see example here:
https://github.com/Mellanox/ci-demo/blob/master/.ci/examples/job_matrix_containerSelector.yaml#L45
archiveArtifacts can be used globally, per step, per pipeline-stop/start special steps as well
does it help?

pipeline_stop is always executed and it has env variable indicating succ/fail, plz see example here:
https://github.com/Mellanox/ci-demo/blob/master/.ci/examples/job_matrix_containerSelector.yaml#L45
archiveArtifacts can be used globally, per step, per pipeline-stop/start special steps as well
does it help?

It does not help because pipeline_stop is executed on master node when results can be collected from different $WORKSPACE.
For example I found that $WORKSPACE can point on different locations as
to /home/jenkins/agent/workspace/LIBVMA-PRO in steps but to /scrap/jenkins/workspace/LIBVMA-PRO when I use $WORKSPACE inside pipeline_stop.

attachArtifact (attachJunit, attachTap) can be per step as well and always executed (in step $WS) regardless if step failed or succeeded

attachArtifact (attachJunit, attachTap) can be per step as well and always executed (in step $WS) regardless if step failed or succeeded

It is clear. But I do not need to publishng artifacts in success on intermidiate step. Just as last step.

you can add archiveTap to last step only
if step-1 fails, step.archiveTap will not take effect

you can add archiveTap to last step only
if step-1 fails, step.archiveTap will not take effect

Yep. It is a reason that this feature request was submitted

cool. can be closed? or I missed smth

cool. can be closed? or I missed smth

No.
I would like to post artifatcs just once if on failure step or as last step.
Current implementation does not allow to do what I need.

I can set special step to submit artifacts as last step but in case failure on previous step it is not executed. As a result artifacts are not published
I can set publishing artifacts for each of steps and results will be published for every steps on success or on failure. But I do not want to submit results on success.

multiple pipelines (per dimension) running in parallel (each in own containers and WS) and not aware of each other.
when job fails - it is known in "pipeline_stop" with pipeline_status var set and in its own WS.
why you need such distinction (attach only on fail). It can be "always attach" and on fail you just will check attachments.

Existing project jenkins scripts supports test results collection internally in tar-file step by step and get all results in single file after failure or success comppletion. Getting such approach allows to use this locally w/o using jenkins and use in previous jenkins scheme.
Submitting this tar-file on every step from ci-demo means getting mostly the same tar-file many times.

per step, one can use onfail and always directive to run commands.
if we expand onfail/always to specify attachXXX - will it do it?
steps:

- name: step1
   run: command
   onfail:
       archiveTap: '**/*.tap'

WDYT

This approach can solve my issue but has minor weakness.
I think ArchiveTap and archiveArtifacts
Weakness:
In this case I must dumplicate the same code for all steps. There is a chance that doing modifications in this part a user can forget to to it in all places.
For example I should duplicate:
    run: |
      if [ -d ${WORKSPACE}/jenkins ]; then
        gzip ${WORKSPACE}/jenkins/*.tar 2>/dev/null || true
        pushd ${WORKSPACE}/jenkins/ ;
          for f in *.tar.gz ; do [ -e "$f" ] && mv "$f" "${name}-$f" ; done ;
        popd
        pushd ${WORKSPACE}/jenkins/${flags};
          for f in *.tap ; do [ -e "$f" ] && mv "$f" "${BUILD_NUMBER}-${name}-${flags}-$f" ; done ;
        popd
      fi
    archiveArtifacts: |
      jenkins/*tar.gz,
      jenkins/${flags}/*.tap
    archiveTap: |
      **/**/*.tap

@igor-ivanov - please see if following can be helpful:
https://github.com/Mellanox/ci-demo/blob/master/.ci/examples/job_matrix_onfail.yaml#L32
added "-onfail" modifier support for archiveXXX command

Thanks


Triple clicking in the last line of settings file selects too much

See below - two lines are selected, rather than the line that was triple clicked

This doesn't seem to occur in other JSON files, so not sure what's up.

Aha! It's not all settings files... it's this specific settings file, and in fact when I copy and paste it to another editor, it actually appears as though everything is on the same line. See below
// Place your settings in this file to overwrite default and user settings.
{
"editor.wrappingColumn": 0,
"typescript.check.workspaceVersion": false,
"markdown.preview.doubleClickToSwitchToEditor": true,"css.lint.argumentsInColorFunction": "error"
}

Oh, ha! Turns out I can't read line numbers :wink:


Support tooltips on all Bootstrap supported components

Is your feature request related to a problem? Please describe.
Bootstrap tooltips can be added on a lot of components. I tried to add the custom attributes, hoping they would work out of the box on components.
Describe the solution you'd like
For all supported HTML elements, having a method like tooltip requiring string $placement (top, left, right, bottom) and string $title and the result would be as in Bootstrap's documentation.

Yes, You can use icon instead of text。
More space saving, improve user experience。
That good idea.


Bare bones support for libxc development branch

The current development branch of libxc has reorganized the handling of hybrid functionals to allow functionals like HISS to be implemented. The branch also includes support for double hybrids.
With this patch, the libxc master branch can be used with PySCF.
The patch also restores earlier functionality that allows reading in the list of functionals from libxc, which is now handled via a __config__ parameter.

Codecov Report

Merging #604 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   82.35%   82.21%   -0.14%
==========================================
  Files         582      582
  Lines      109995   109995
==========================================
- Hits        90590    90437     -153
- Misses      19405    19558     +153

Impacted Files
Coverage Δ

pyscf/geomopt/berny_solver.py
6.20% <0.00%> (-67.45%)
:arrow_down:

pyscf/geomopt/addons.py
20.00% <0.00%> (-55.00%)
:arrow_down:

pyscf/geomopt/test/test_berny_solver.py
55.55% <0.00%> (-37.04%)
:arrow_down:

pyscf/__config__.py
80.00% <0.00%> (-15.00%)
:arrow_down:

pyscf/lib/misc.py
66.87% <0.00%> (-3.80%)
:arrow_down:

pyscf/data/elements.py
86.81% <0.00%> (-1.10%)
:arrow_down:

pyscf/lib/logger.py
88.49% <0.00%> (-0.89%)
:arrow_down:

pyscf/df/addons.py
99.14% <0.00%> (-0.86%)
:arrow_down:

pyscf/dftd3/itrf.py
77.92% <0.00%> (-0.65%)
:arrow_down:

pyscf/grad/casci.py
91.21% <0.00%> (-0.42%)
:arrow_down:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2675459...308dac8. Read the comment docs.

Could this be merged?

Could this be merged?


[NETBEANS-54] Module Review

Switches HtmlElements.java to use ASF license.
Addresses #67

Should automatically resolve when you pull from apache repo

Closing this since you opened https://github.com/emilianbold/incubator-netbeans/pull/327


Cert prepfor deployment AND secret rotation

Current wording suggests that this doc only applies for azure stack deployment whereas it also applies to certificate preparation for azure stack secret rotation

@PPacentMSFT : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.

#sign-off

@GitHubber17 : Thanks for your contribution! The author, @mattbriggs, has been notified to review your proposed change.

#sign-off


fix(input): suppress mouse events after touch

Quick fix to prevent duplicate taps on Surface

This seems too aggressive.
Chrome doesn't seem to always send synthesized mouse events if the touch is a drag.   In that case, your next (possibly mush later) mouse session will get ignored.   That's only really a problem in cases where you want to allow both touch and mouse use --- I know I use my Surface like that when I have the type cover on, but I may be an outlier.

Yeah, I agree there needs to be a more comprehensive solution.  Just wanted to get something in as a quick fix to make it usable at all on Surface.  It looks like a larger rewrite is currently being considered, so I'll close for now.

I think the approach forward is going to be that input sessions are channeled by source type, and gestures can only trigger within a given channel, not across channels.

@arschmitz thoughts?

If we actually build a channel primitive, this could help us with the linearly-composable gesture concept we've been bantering about.

That makes sense to me, it's the ideal we were trying to fake in our workaround to this issue.   About the only issue that we identified was the possibility that an accidental touch -- say brushing the screen --- might interfere with an in flight mouse gesture.    I can imagine fairly straightforward implementations of channelization that would handle this case properly where our workaround failed.

@runspired yes thats right that is for sure the way forward and what we have been discussing


74 rest service servicesweatheree

https://github.com/buerokratt/Common-Services/issues/74

https://github.com/buerokratt/Common-Services/issues/74


"Learn More" button unexpectedly orphans unsaved editors when reopening workspaces on untrusted UNC hosts

Does this issue occur when all extensions are disabled?: Yes

Version: 1.78.1 (system setup)
Commit: 6a995c4f4cc2ced6e3237749973982e751cb0bf9
Date: 2023-05-04T09:48:08.683Z
Electron: 22.5.1
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No
Steps to Reproduce:

Open a workspace at a UNC path that isn't set in security.allowedUNCHosts.
Click "Yes" when prompted to temporarily allow working from that host.
Make changes to one or more files without saving them.
Restart VSCode without closing the workspace (may require specific settings to automatically re-open the previous workspace).
This time, click the "Learn More" button when prompted to allow working from that host.

Note that any unsaved editors remain, but the rest of the workspace is not loaded as though the user clicked the "No" button.  I'd argue that "Learn More" doesn't constitute a decision from the user and shouldn't proceed as though it was.  Depending on the nature of the changes, this may cause a problem for safely saving those changes because if the user tries to re-open the workspace, they are asked to either save or close these orphaned editors.
Perhaps a link among the text in the dialogue box would be more appropriate than a button which closes the box.

I agree that the dialog should not close and/or make a decision when you click "Learn More". Unfortunately the dialog closes when you press that button, so best I can do is to open it again asking the same question.


[warning] failed package validation and/or copy for commit d48cf646a7f92b4ec751de58680423695a94b88d

Hi @conda-forge/slack-sdk! This is the friendly automated conda-forge-webservice!
It appears that one or more of your feedstock's outputs did not copy from the
staging channel (cf-staging) to the production channel (conda-forge). :(
This failure can happen for a lot of reasons, including an outdated feedstock
token. Below we have put some information about the failure to help you debug it.
Rerendering the feedstock will usually fix these problems.
If you have any issues or questions, you can find us on gitter in the
community chat room or you can bump us right here.
output validation (is this output allowed for your feedstock?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

copied (did this output get copied to the production channel?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

error messages:

output noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2 not allowed for conda-forge/slack-sdk-feedstock

@ocefpaf, we could use your help with one more thing. Could you remind me what the procedure is for switch over the slack_sdk package so the slack-sdk-feedstock is now allowed to build it?

@ocefpaf, I found a similar conversation from email-validator vs. email_validator: https://github.com/conda-forge/email-validator-feedstock/issues/5
It seems that someone from core (hopefully you) will need to add slack_sdk to this list:
https://github.com/conda-forge/feedstock-outputs/blob/master/outputs/s/l/a/slack-sdk.json
Thanks again!

Hi @conda-forge/slack-sdk! This is the friendly automated conda-forge-webservice!
It appears that one or more of your feedstock's outputs did not copy from the
staging channel (cf-staging) to the production channel (conda-forge). :(
This failure can happen for a lot of reasons, including an outdated feedstock
token. Below we have put some information about the failure to help you debug it.
Rerendering the feedstock will usually fix these problems.
If you have any issues or questions, you can find us on gitter in the
community chat room or you can bump us right here.
output validation (is this output allowed for your feedstock?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

copied (did this output get copied to the production channel?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

error messages:

output noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2 not allowed for conda-forge/slack-sdk-feedstock

@maresb, I'm guessing this is from me trying to just rerun the failed merge.  I didn't realize a rerender is needed, too (but no surprise in retrospect).  Hopefully, your merge will work fine.

Hmm, seems to be failing on your build, too.  Maybe we can try again in a few hours, just in case it's a propagation issue.  Sometimes, these things take an hour or so.

I see. Very good idea.
It looks like the build job is in a retry loop. If your hunch is correct, maybe it will eventually succeed.

I can't remember exactly how the deployment of feedstock-outputs works. If it still doesn't work in a few hours ping me and/or core and someone can take a look.

Hi @conda-forge/slack-sdk! This is the friendly automated conda-forge-webservice!
It appears that one or more of your feedstock's outputs did not copy from the
staging channel (cf-staging) to the production channel (conda-forge). :(
This failure can happen for a lot of reasons, including an outdated feedstock
token. Below we have put some information about the failure to help you debug it.
Rerendering the feedstock will usually fix these problems.
If you have any issues or questions, you can find us on gitter in the
community chat room or you can bump us right here.
output validation (is this output allowed for your feedstock?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

copied (did this output get copied to the production channel?):

noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2: False

error messages:

output noarch/slack_sdk-3.6.0-hd8ed1ab_2.tar.bz2 not allowed for conda-forge/slack-sdk-feedstock

I just restarted the pipeline. Let's see what happens...

Sorry @xylar, looks like I'm late here. Hopefully this is fixed now...

Welcome back @ocefpaf! Unfortunately the current pipeline is still failing. Any ideas?

Welcome back @ocefpaf! Unfortunately the current pipeline is still failing. Any ideas?

Looking into it.

I didn't realise that the slack_sdk.json file should have been updated instead of slack-sdk.json, sorry about that 😅 I think it's fixed now.

The - vs _ is the real root of all evil!

I believe it was the slack-sdk.json that should be updated and it looked right to me.

Ah, I think I see the logic now...
slack_sdk.json lists the feedstocks which are allowed to build the slack_sdk package.
Originally we mistakenly believed that slack-sdk.json lists the packages which the slack-sdk feedstock is allowed to build.
It makes sense to link in this direction because package names are by default available. Once a package name gets taken, it needs to know the feedstock which owns it. Hense the .json files correspond to packages, not feedstocks.
@ocefpaf, is there any official conda-forge guidance for - vs _?
If I'm not mistaken, I generated my duplicate recipe with grayskull pypi slack_sdk and even though PyPi uses the name slack-sdk I think grayskull followed the PyPi redirect from slack_sdk to slack-sdk and build the package with the name slack_sdk. I wonder if this is a bug in grayskull.

@maresb, thanks for the explanation.  If that's correct, it also explains my misunderstanding.  It would explain why email_validator.json was edited even though email_validator-feedstock was archived.
Sorry everyone for the misunderstandings.  Hopefully I'll remember this for the next time.
Regarding grayskull, it think it would be a little tricky for it to know which is a real package and which is a redirect on PyPi but let's see what the developers say.

I'm looking to close out this issue...
I just checked anaconda.org:

I notice that the build string for slack_sdk no longer has the py… prefix. Is this normal, or is it a sign of something not quite right in my recipe? Perhaps because it has no contents, and simply points to the other package?
If the experts think everything looks in order, then please close the issue. Thanks so much to everyone for the help in getting this resolved!

It's because it no longer depends on Python in host and run. As slack-sdk is noarch: python I think it's fine.


ENH: special.logsumexp: add array API support

Reference issue
Toward gh-20930
What does this implement/fix?
Adds array API support to special.logsumexp. I'll need this for integrate.qmc_quad.
@lucascolley @j-bowhay the xp_broadcast_promote utility should replace the need for promoting dtypes manually.

As an aside I realised we have not been keeping https://scipy.github.io/devdocs/dev/api-dev/array_api.html#currently-supported-functionality up to date. Do we want to try to get a doc update into 1.14?

Oops. If I knew that existed, I forgot. Yes, would you like to do that or should I?

Oops. Will do.

It will be easier to review the latest commit separately with "Hide whitespace" on, since I moved all the logsumexp tests into a class.

I went this way because torch. logsumexp doesn't support weights, and this would allow all libraries to share an implementation with a handful of changes from NumPy-specific calls to array API calls.
The diff would be very small but for things like the array API standard not supporting simple things. For example, xp.max doesn't have initial argument, so I worked around it. xp.real doesn't work on real dtypes. And the input validation of this test was interspersed throughout the implementation, so I replaced it with a general function that we can call at the top and re-use in other functions.

Hey Matt, it was a genuine (and fairly obvious, since it was your first idea as well) question, not a blocking review- so no need to close this straight away.
It still isn't quite clear to me to what extent weights or complex support are needed. I had a quick look, and the b input doesn't seem to be used outside of tests/docs:

% rg logsumexp -g'!_lib/boost_math' -g'!special/tests'
special/_logsumexp.py
4:__all__ = ["logsumexp", "softmax", "log_softmax"]
7:def logsumexp(a, axis=None, b=None, keepdims=False, return_sign=False):
58:    NumPy has a logaddexp function which is very similar to `logsumexp`, but
65:    >>> from scipy.special import logsumexp
67:    >>> logsumexp(a)
76:    >>> logsumexp(a, b=b)
83:    >>> logsumexp([1,2],b=[1,-1],return_sign=True)
86:    Notice that `logsumexp` does not directly support masked arrays. To use it
92:    >>> logsumexp(a.data, b=b), np.log(5)
172:    The `softmax` function is the gradient of `logsumexp`.

special/meson.build
342:  '_logsumexp.py',

special/__init__.py
765:   logsumexp -- Compute the log of the sum of exponentials of input elements.
819:from ._logsumexp import logsumexp, softmax, log_softmax
848:    'logsumexp',

stats/_morestats.py
854:    return special.logsumexp(logx, axis=0) - np.log(len(logx))
861:    logxmu = special.logsumexp([logx, logmean + pij], axis=0)
862:    return np.real(special.logsumexp(2 * logxmu, axis=0)) - np.log(len(logx))

stats/_continuous_distns.py
4146:            return -scale * (sc.logsumexp(-data / scale) - np.log(len(data)))
9875:# logsumexp trick for log(p + q) with only log(p) and log(q)
9877:    return sc.logsumexp([log_p, log_q], axis=0)
9882:    return sc.logsumexp([log_p, log_q+np.pi*1j], axis=0)

stats/_distn_infrastructure.py
1596:            # here we could use logcdf w/ logsumexp trick to take differences,

stats/_discrete_distns.py
8:from scipy.special import entr, logsumexp, betaln, gammaln as gamln, zeta
683:                # Integration over probability mass function using logsumexp
685:                res.append(logsumexp(self._logpmf(k2, tot, good, draw)))
695:                # Integration over probability mass function using logsumexp
697:                res.append(logsumexp(self._logpmf(k2, tot, good, draw)))

stats/_stats.pyx
799:cdef real logsumexp(real a, real b):
875:                estimate[j, k] = logsumexp(estimate[j, k],

integrate/_tanhsinh.py
401:            Sn = (special.logsumexp([Snm1 - np.log(2), Sn], axis=0) if log
670:    Sn = (special.logsumexp(fjwj + np.log(work.h), axis=-1) if work.log
705:        Snm1 = (special.logsumexp(fjwj, **axis_kwargs) + np.log(h) if work.log
724:        Snm2 = (special.logsumexp(fjwj, **axis_kwargs) + np.log(h) if work.log
739:        d1 = np.real(special.logsumexp([work.Sn, Snm1 + work.pi*1j], axis=0))
740:        d2 = np.real(special.logsumexp([work.Sn, Snm2 + work.pi*1j], axis=0))
853:def _logsumexp(x, axis=0):
854:    # logsumexp raises with empty array
861:        return special.logsumexp(x, axis=axis)
1165:    S = _logsumexp(fs, axis=-1) if log else np.sum(fs, axis=-1)
1179:    tol = _logsumexp((tol, rtol + lb.integral)) if log else tol + rtol*lb.integral
1224:        S = _logsumexp(S_terms, axis=0)
1226:        E = _logsumexp(E_terms, axis=0).real

integrate/_quadrature.py
10:from scipy.special import gammaln, logsumexp
1290:            return logsumexp(integrands) + np.log(dA)
1296:            return logsumexp(estimates) - np.log(n_estimates)
1305:            diff = logsumexp(temp, axis=0)
1306:            return np.real(0.5 * (logsumexp(2 * diff)

For complex support it's a little harder to tell without auditing all the code. Both are probably not that hard to implement in PyTorch - just wondering how pressing the need is.

The diff actually is quite readable if you were to take a look.

It's still ~300 lines with whitespace hidden, and mixes in two separate refactors (input validation and tests in a class) in the same commit. If those refactors were separated out, this would probably look cleaner? Note that it's not that it's me who is most concerned here - I'm very aware that there's a subset of maintainers who don't have a personal interest in array types support; they're fine with it as long as it doesn't get in the way too much. These refactors sound like perfectly fine code cleanups in isolation, but I'm worried that to the casual reader they seem necessary for array types support and make that look much more complex/churny than it really is.

If you have general concerns about all these conversions, consider setting up a meeting.

Having a higher-bandwidth conversation more regularly sounds like a great idea. Are you able to join the community meeting today?


Restrict user input requests

Also, you bring up a good point that I have been thinking about. The mechanism of socket triggering on every button is really slowing down the input of the user. I am thinking of an enhancement in the form of a buffer in the front-end so that the command is executed only when return is pressed. The input delay, is an issue that needs to be addressed before the software can have a functional release. Any thoughts @hericlesme ?

Originally posted by @satanb4 in https://github.com/pod-cast/cast-sh/issues/42#issuecomment-548548063

Actually, every  keydown event is triggering a request to the python backend. A good solution would be to wait for the user to press return so that the request would be made with the command to be executed. This would also simplify the logic in the backend. As @satanb4 said.

I'll look into this. This would also allow for a more comprehensive log file.

Okay, @satanb4! Yes, of course, greatly simplifying the logger and will help us create a better view of the commands. When resolved, we will only receive the commands that are executed.

Assign me this Issue

@satanb4 sure! :rocket:

@hericlesme I have a major issue here. We need to update to a newer version of XtermJs to support advanced cursor movement, better buffer security and also general speed. There is implementation of cursor controls on the XtermJS from the Node package manager and hence I propose that we migrate to that. Otherwise we're already developing an application that will be outdated when released,

@hericlesme I have a major issue here. We need to update to a newer version of XtermJs to support advanced cursor movement, better buffer security and also general speed. There is implementation of cursor controls on the XtermJS from the Node package manager and hence I propose that we migrate to that. Otherwise we're already developing an application that will be outdated when released.
Take a look at this and this. There's issues that are based on this dependency as this. Would need to discuss the migration.

Good catch on this @satanb4. Maybe open up a migration issue for discussion? I would like to ask a few questions maybe about building a bundle for our frontend deps with webpack?

So you want something like a local echo mode. As you already figured, xterm.js does not provide anything like that out of the box, as it mainly mimicks functionality of DEC terminals, which are seen as dumb terminals always relying on the input --> pty --> process --> pty --> output cycle (in contrast to "intelligent" terminals in the 80s, which had local mirroring and editing functionality).
It is still possible to get this done, but it is more involved. Things to consider:

Will the local echoing violate the rule, that the pty output is solely responsible for what gets shown? Here you will have to implement a backtracking of what was inserted ahead-of-time and possibly have to remove it again, if the pty output does not match.
Closely track termios changes - If termios is set to raw mode, local echoing should be switched off in any case, as the process might have a completely different idea of what to make out of the input. Thats how most cmdline editors operate and provide changes to the screen by just one keystroke. If ECHO is switched of in termios settings, local echoing should never apply (often used for password inputs). There are more intermediate modes to be considered, see termios manpage.
Implement termios (pty/pty) replacements. Depending on the active termios settings the tty might do several character replacements like '\r' -> '\r\n'. Example - Enter will trigger '\r' to be sent, but the pty will echo back '\r\n', if ICRNL and ONLCR is set (default in ICANON mode).
Do not implement local echo with direct access to terminal internals (like direct buffer access, cursor manipulations triggered from custom key listeners). This will most likely lead to desync artefacts. Instead rely on on data from the terminal (onData event) and data from the pty to do the backtracking. If a state change of the terminal is needed, use sequences (thats important to stay in sync with the band data, as the whole pty-->term communication is stream based). You can find an updated version of the supported sequences on CI server (not yet merged into public, the wiki document will be deleted soon).

I think mosh implements local echoing and pty decoupling to a very good degree, might be worth looking at it.


Get formatted value without an element

Say I want to make a method that takes a number and autoNumeric options and returns a formatted number using autoNumeric and the provided. This is currently how I'd go about it:
format(input, options) {
    const element = $("

");
    element.autoNumeric("init", options);
    element.autoNumeric("set", input);

    const value = element.html();
    delete element;

    return value;
}

I would like to suggest that autoNumeric should support this without the creation of an element.

Thank you for the suggestion - you are not the first.
It can be done by adding a public function but I have been reluctant to add this feature.
Formatting a string to represent currency can be accomplished with a few lines of code. Using autoNumeric for this is overkill.
I am open to adding the feature but need a compelling argument why add the extra overhead.
Bob

The overhead is very little. The case here is I'm integrating autoNumeric with Angular. I've made a directive that binds autoNumeric on an element, and I also want to make a filter that formats some input using autoNumeric.
So, for example, when I write:
{{ someNumberVariable | autoNumeric : { *AutoNumericOptions go here* } }}

What happens behind the scenes currently is an element is created like I described in my original post. This is done every time the value of someNumberVariable changes. Other than being inefficient I find it to be bad practice and kind of a hack.
I see no reason to be concerned about creating a public method for this. I mean, I'm already using autoNumeric. Why would I want to implement an additional formatter to facilitate auch a filter, when autoNumeric already contains this implementation?
The overhead you mention I find insignificant, it's just a matter of making a public method exposing what's already implemented in autoNumeric. We're talking less than 1 KB to a script of 68.7 KB unminified. That's no overhead at all compared to what overhead those of us who have requested this feature will experience, either from having to maintain a fork or from having to apply the "hack" I mentioned.
What if we flip around your question... Do you have a compelling argument not to add this feature?
I can make a PR if that's the issue. Regardless thank you for the very good job on creating and maintaining autoNumeric :)

This would be considered a new feature and would be added to version 2.0 if i move forward.
Version 1.9.nn updates will be fixes only

@jesperzach Take a look at the last version, it provides two format and unFormat methods that allows to do just that without having to first init an element.

Given those new functions, we'll close the issue.
Feel free to re-open it if needed.


Fixing  #1076 show proper legendFormat on Grafana dashboards

Due to export issue some dashboard legends were screwed up. This PR fixing this problem.

abandoning this PR, wrong git history


Swift 4.1 issue discovered around Structs with two Strings

It was reported that the Swift 4.1 runtime was exhibiting a strange behavior.  The behavior in question occurs when a Struct has multiple Strings and those Strings are being initialized directly from static Strings.
For instance, the following piece of code will work:
struct Output: Codable {
    let greeting: String
    let group: String
}
func main(completion: (Output?, Error?) -> Void) -> Void {
    let name = "MyName"
    let result = Output(greeting: "Hello \(name)", group: "Greetings")
    print("Log greeting:\(result.greeting)")
    completion(result, nil)
}

However the following code will not:
struct Output: Codable {
    let greeting: String
    let group: String
}
func main(completion: (Output?, Error?) -> Void) -> Void {
    let result = Output(greeting: "Hello Name", group: "bummer")
    print("Log greeting:\(result.greeting)")
    completion(result, nil)
}

It appears to be a bug within Swift itself.
We have discovered that if the code is compiled with the compiler flag to turn off optimizations then the compiling will work.  This compile flag is -Xswiftc -Onone

PR https://github.com/apache/incubator-openwhisk/pull/3647 was merged as a temp fix until the issue is addressed in the Swift Docker image.

I believe I have narrowed down the reasoning for this issue as coming from the use of the "@escaping" syntax in here https://github.com/apache/incubator-openwhisk-runtime-swift/blob/master/core/swift41Action/epilogue.swift#L98
I have stripped down this code the mainly the essentials (non-whisk related) items and when the "@escaping" option is present the code will throw a compiler error, however when I remove the statement the code will compile fine and execute successfully.
I will be opening an issue against the Swift Docker image tomorrow and will link that here when I do.

Issue moved to apache/incubator-openwhisk-runtime-swift #60 via ZenHub


feat(lint): make testing lint easier

related to #1743

I am unsure about this, as this seems like very opinionated change, but allows developers without all the setup to run the lint stage. However, this sort of thing should be handled by the person wanting to contribute, as people tend to have different opinions about this kind of stuff...

I am fine with it being changed and generalized based on opinion.
If you would like we can add this to the bash-it container and use that one to test.
This way we can validate the scripts are ok, and make the container mode widely used

In general, I like the idea of running tools in containers, since it makes it easier to run uncommon tools without having to install all of the dependencies. The tradeoff is that you have to have Docker installed...
I'm also careful with using open-sourced containers, e.g. from Docker Hub, since many of them contain security vulnerabilities or malware - we need to be careful to not introduce these issues here. There are some pre-built shfmt containers out there, but we'd need to check whether they are up to date and reasonably secure. Rebuilding the container before running the command feels like a bit of a waste, ideally, we'd use a pre-built container that has all of the required dependencies.
To me, it feels like these instructions are a better fit for our documentation - I don't see us adding more and more test scripts to the project root, it will get crowded there...

Hi Team,
After grinding on this for a bit, here are my thoughts:

Create a bin/ folder for non-primary scripts (addresses crowded root folder)
Consider moving lint_clean_files.sh into bin/
Create an official bash-it-pre-commit-docker image

It lives alongside our bash-it-docker image
It contains a fully configured (as per Bash-It needs) pre-commit setup. ie:

pre-commit
shfmt

Create bin/pre-commit-docker.sh

Knows how to invoke pre-commit from the docker image running against the current bash-it folder

Create 'bin/lint_clean_files-docker.sh'

Knows how to invoke pre-comit-docker.sh against clean_files.txt

This would provide a basic ability to lint files without having to have pre-commit/shfmt installed locally.
The user could get clever and do things like:

alias pre-commit ~/.bashit/bin/pre-commit-docker.sh or
ln -s ~/.bashit/bin/pre-commit-docker.sh /usr/local/bin/pre-commit
Which would allow them to invoke lint_clean_files.sh directly for convenience.

I am all for what @davidpfarrell said, and I agree with ya'll on the concerns.. should we create a roadmap we agree on for this?
I think that:

moving the container into the bash-it-container is a good idea
moving non-necessary scripts into ./bin is also a fair point
we could also add an env var check into 'clean-files.sh' to run the checks inside a container if need be

if [[ -n $RUN_IN_CONTAINER ]]; then
  ./lint_clean_files-docker.sh
  exit
fi

moving the container into the bash-it-container is a good idea

You know, my statement was actually to create a separate container for the pre-commit, ie:

docker pull bashit/pre-commit

Having it in the same container may also be useful, but I think there's value in a stand-alone container as well.

created PR Bash-it/bash-it-docker#3 on it, we can do some stuff there and them move back to this one

Howdy y'all. Great discussion! Here's my $0.02

there should be a dedicated container for pre-commit. It can be the base upon which the bash-it container is built, but it should be independent.
moving scripts to bin seems like an easy win, but we should still do everything possible to reduce sprawl.
keeping with the previous point, lint_clean_files.sh should be updated to check for an environment variable to toggle running in a container, and any docker-specific scripts should simply set that environment variable and execute lint_clean_files.sh.

Howdy y'all. Great discussion! Here's my $0.02

there should be a dedicated container for pre-commit. It can be the base upon which the bash-it container is built, but it should be independent.
moving scripts to bin seems like an easy win, but we should still do everything possible to reduce sprawl.
keeping with the previous point, lint_clean_files.sh should be updated to check for an environment variable to toggle running in a container, and any docker-specific scripts should simply set that environment variable and execute lint_clean_files.sh.

Hey y'all!
I have the PR for the dockerfile written out and it fails for some reason
Can someone TAL to see what I missed so we can proceed with this PR?

Hey y'all!
I have the PR for the dockerfile written out and it fails for some reason
Can someone TAL to see what I missed so we can proceed with this PR?

hey! bumping up as it didn't get eyes yet...
can you TAL at https://github.com/Bash-it/bash-it-docker/pull/3 ?


Line 1194 in python  it is showing an error please solve this immediately

Checkboxes

[ ] Updated fsociety
[ ] Issue does not already exist
[ ] fsociety issue, not a tool issue

Expected Result

Actual Result

"solve this immediately"
Are you paying support or something?
Too rude for something free ;)

no, not at all. I just asked for the error that happend for you.

Hi, if there is still an issue please consider creating a new issue with more information.


Enable multi-threaded forwarding

The forward_proxy is only accepting one request at a time, which is particularly unsuitable if the server is not responding or we have intermittent links. For example, if for some reason the first ACK sent be the proxy is lost, no other ACKs are sent (until the response), and the client might give up if the server is taking some time to respond.

Coverage increased (+0.06%) to 89.715% when pulling d056158fda3f06970839b9686b8a73a0092eb220 on PalmaITEM:patch-3 into 10b85a1f76f066dd96a285528d170a252e120f41 on Tanganelli:master.


Fix all Vulnerable Dependencies

This removes all node modules that contain some type of vulnerability.

The usage of Gulp had to be removed and is instead replaced with Grunt to run build tasks. This is due to gulp relying on dependencies with security concerns.
Lodash was updated along with deprecated functions updated to new usages.

I would love to see this merged!


Add $CDN logo

delete space from folder name

delete space from folder name

@pecio222 space is deleted