CodeDOM or RazorEngine

Hi, I'd like to use Blazor to write an application for developer screening website, where problems must be solved by writing C# code. So the whole reason I'm attracted to Blazor is for the potential to compile and run the C# in the browser rather than server, for security.
Seems I would need Blazor to be running on the Mono for WebAssembly describes as,

The second prototype compiles the Mono C runtime into web assembly, and then uses Mono’s IL interpreter to run managed code.

Is that possible?
Alternatively, is there a way to compile assemblies independently (on the server), and load them into a running Blazor application.
Finally, if neither of the above options are available, is there any guidance on something like on-demand server-side Blazor app compilation for reloading in an iframe?
Thanks in advance!! Exciting project!!

AFAIK

Blazor is running on Mono.
You can't compile C# code into dll in the browser.
You can manually download dll from server and load it into the app in the browser - example #1025.

It's possible, it's not uber fast but it works, see https://github.com/Suchiman/Runny and the demo at http://runny.azurewebsites.net/


Added EdgesGeometry to ElementDescriptorContainer.

The descriptor for EdgesGeometry was not included in ElementDescriptorContainer (but was defined in the descriptors folder) so I added it, along with it's documentation!.

Good catch and great work, thanks for the PR!!


Rename GetSaved / SetSaved to IsDirty / MarkDirty

Just seems more consistent with typical terminology used in this area, like in Fowler's book.

fixed in 3a6611


Fixes #292 - adds ephemeral sections to the redshift watcher

Makes the redshift watcher less noisy during maintenance periods.

If we don't have all the fields, we may need to add on to this later.


[Feat]Add Support with Jupyter Extension for Visual Studio Code

Already worked in release 0.1.4-alpha.


How to explicitly set DXF color to black?

I need to set color of entity to black, but when I use DxfColor.FromIndex(0), I get it as ByBlock. Same happens when I use FromRawValue. I also get ByBlock. It is mentioned here: https://github.com/ixmilia/dxf/issues/97
So, how do I set a color to black? Other colors work, but I'd like black

tl;dr - Black isn't a color that's supported by default.
Long version
Colors in DXF files aren't really colors, but they're an index into a palette and each CAD program is free to interpret each index as a specific color as they see fit, or an individual user can even override that, but AutoCAD seems to use the colors that I define here with the caveat that you mentioned that index 0 isn't really an index, but a placeholder to mean BYBLOCK (256 = BYLAYER, 257 = BYLAYER, etc.)
A little further down in issue #97 I mention that starting with AutoCAD 2004 individual entities can have a 24-bit integer representing the RGB color, but that concept doesn't exist on the layer; only on the entity.


Remove nohost/StaticServer (dead code), always rewrite CSS files, fix remote script injection

I'm slowly working up the courage to tackle #549 and add Service Worker support.  As I do, I'm re-familiarizing myself with our live dev server infrastructure.  Today, I noticed a few bugs, and this fixes things:

We don't actually use the nohost/StaticServer module at all, so I've removed it.  Kind of hilarious I wrote it at all, since it's 100% dead code :)
I've refactored the LiveDev script injection to always use what's defined in the PostMessageTransport vs. the hack we had in the HTMLServer before.  I think this might actually fix a few other scroll-position bugs that @flukeout mentioned in Thimble, specifically https://github.com/mozilla/thimble.mozilla.org/issues/1671
I've fixed a bug in our server.urlToPath() method to ignore non-Blob/relative path URLs.  This was causing an exception when HTML docs included links to stylesheets on the web (i.e., we were looking for a related doc in the editor, but we don't have one because it's actually an http:// url).
I've fixed a bug in our initial filesystem cache logic where we were reading but not rewriting HTML and CSS files, and then serving them without also rewriting any internal links (e.g., images).  A good way to see the bug was to have a CSS that used background-image: url(something.png); and when you first load it, the image won't show.  You have to edit the CSS file to make it actually rewrite it, and purge the existing, incorrect cached URL from the Blob Cache.

everything seems to be working fine. I do see this showing up now though:

@gideonthomas do you know what you were doing when that was caused, and/or what the project you're editing looks like (files/folders/types)?

@humphd it's the default project and it seemed to happen when I switched files. So I'm guessing when the preview reloads?

@gideonthomas I can't reproduce that error.  I think we should take this patch, and fix bugs we find as a result.


125812 Update homepage heading

125812 - update H1 to match design system specs

Removed h1 and replaced with Heading component from SCDS

Test Instructions

See that the design matches that seen in the task card found here

Definition of Done

[x] Update CHANGELOG

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1398752203.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1398752203.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1398752203.azurewebsites.net

A pull request preview is being generated. Hold tight!

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-1398752203.azurewebsites.net


[Feature Request] Pydantic Integration

Courtesy the illimitable @gabrieldemarmiesse at this excellent comment on the beartype.claw megathread, @beartype should ideally provide seamless out-of-the-box support for Pydantic models. Since Pydantic models are so common in the data science community, this feature request is effectively a hard blocker for our upcoming @beartype 0.15.0 release.
My face continues exhaling. :face_exhaling:
Take It Away, @gabrieldemarmiesse!
I tried something else and I got an interesting warning:
:dada.py:
from pydantic import BaseModel

class Something(BaseModel):
    name: str

dodo.py:
import beartype.claw
beartype.claw.beartype_packages(["dada"])

from dada import Something
Something(name="some-name")

I get the following warning, which is likely not desirable with the beartype.claw api:
$ python dodo.py
/opt/conda/lib/python3.10/site-packages/beartype/_decor/decorcore.py:381: BeartypeClawDecorWarning: Object pydantic.json.pydantic_encoder() :
<cyfunction pydantic_encoder at 0x7f79eb7b0110> not pure-Python function.
  warn(warning_message, warning_category)

Resolved by 7bfa5c61598... I think. Sadly, I can't reproduce this on my end with the most recent @beartype commit + Pydantic 2.0.2 (both with and without Cythonized C extensions). Even more sadly, I failed to test this earlier. Let's pretend this now works.
Clearly, these statements are not inspiring confidence in anyone. :weary:


Config Page: Anchor DAO should be able to edit the explore page banner & text

Summary:
As a Anchor DAO I would like to be able to change the copy and header image of the /explore page.
AC:

add another section at the end of the "design" / "Banners" section
Only make it visible for anchor daos
add a field to upload header image
add a field to change headline
add a field to change description

@Gerard097 Is there a way to identify anchor dao ?


feat(it_IT): generate only valid IT phone

Changed the Italian PhoneNumber provider to generate only valid Italian phone numbers (telephone and cellphone).

Codecov Report

Merging #2042 into master will decrease coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2042      +/-   ##
============================================
- Coverage     56.56%   56.36%   -0.21%
  Complexity     2068     2068
============================================
  Files           306      306
  Lines          4849     4849
============================================
- Hits           2743     2733      -10
- Misses         2106     2116      +10

Impacted Files
Coverage Δ
Complexity Δ

src/Faker/Provider/de_AT/Person.php
0.00% <0.00%> (-100.00%)
1.00% <0.00%> (ø%)

src/Faker/Provider/ne_NP/Person.php
0.00% <0.00%> (-50.00%)
2.00% <0.00%> (ø%)

src/Faker/Provider/fi_FI/Address.php
33.33% <0.00%> (-33.34%)
3.00% <0.00%> (ø%)

src/Faker/Provider/es_ES/Person.php
75.00% <0.00%> (-25.00%)
3.00% <0.00%> (ø%)

src/Faker/Provider/en_AU/Address.php
75.00% <0.00%> (-25.00%)
4.00% <0.00%> (ø%)

src/Faker/Provider/en_ZA/Address.php
50.00% <0.00%> (-25.00%)
4.00% <0.00%> (ø%)

src/Faker/Provider/ja_JP/Address.php
76.19% <0.00%> (-23.81%)
8.00% <0.00%> (ø%)

src/Faker/Provider/en_UG/Person.php
60.00% <0.00%> (-20.00%)
5.00% <0.00%> (ø%)

src/Faker/Provider/es_ES/Address.php
40.00% <0.00%> (-20.00%)
5.00% <0.00%> (ø%)

src/Faker/Provider/fr_CA/Address.php
60.00% <0.00%> (-20.00%)
5.00% <0.00%> (ø%)

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5337ce5...c266ea8. Read the comment docs.


Point Description Key Set Nodes (Feature Request)

Ability to create a description key with at least "Code" "Style" and "Point Label Style" and "Layer". This would save some time and allows for a way to export to excel and be managed outside of Civil 3D.

This has been sitting for awhile and unfortunately I don't think I'm going to have time to prioritize it.


LTS 9.5 mandated deprecated fgl <IP_ADDRESS>

The latest Stackage LTS  9.x package set mandates use of fgl version <IP_ADDRESS>, but upstream has deprecated that version on Hackage.
Ping @ivan-m.

Yes, I accidentally broke PVP hence <IP_ADDRESS>

Okay might be better to open a issue under https://github.com/fpco/lts-haskell

Moved to https://github.com/fpco/lts-haskell/issues/70.


Remove one of the main file entries from the bower.json

Only one of the files is needed to run the application:
"main": ["dist/angular-applicationinsights.min.js", "dist/angular-applicationinsights.js"],

The docs say:

string or array: The primary acting files necessary to use your package.

As angular apps are usually preprocessed, I recommend the non-minified version.

Thank you for your feedback
Both are provided so the consuming dev can choose which one to use. This is inline with what is done for npm and nuget distributions as well, and some app devs do use the pre-minified so it is preferred to leave that option open to them.


Bulk update map typekeywords for use in Field Apps

A few comments/issues:
Minor: you can easily put a search in that returns web maps that you have access to but don’t own and cannot update (e.g.  leave out the owner part of the search and not be an adminstrator, which will return things shared with you via groups/org but you don't have permissions to update).  The script will fail when trying to write typeKeywords to these items.  Might want a try/except or something in there(?) for the update.
Major:  Collector status has 3 states with respect to the typeKeywords:
•	“Collector” keyword is present- webmap is collector-ready, i.e. it has editable layers in it and thus can be changed to CollectorDIsabled
•	“CollectorDisabled”  keyword is present: webmap is collector-ready but disabled, but can be changed to be enabled
•	Neither of the above keywords are present, and thus it is not “collector-ready” and no keyword changes should take place
The stripped down script does not deal with that tri-state possibility and could add “Collector”  or “CollectorDisabled” to a web map that normally is not available in collector. (that is what turns the UI “checkbox” on, presence of Collector/CollectorDisabled, but these items do not (should not) even show a checkbox)

A few comments/issues:
Minor: you can easily put a search in that returns web maps that you have access to but don’t own and cannot update (e.g.  leave out the owner part of the search and not be an adminstrator, which will return things shared with you via groups/org but you don't have permissions to update).  The script will fail when trying to write typeKeywords to these items.  Might want a try/except or something in there(?) for the update.
Major:  Collector status has 3 states with respect to the typeKeywords:
•	“Collector” keyword is present- webmap is collector-ready, i.e. it has editable layers in it and thus can be changed to CollectorDIsabled
•	“CollectorDisabled”  keyword is present: webmap is collector-ready but disabled, but can be changed to be enabled
•	Neither of the above keywords are present, and thus it is not “collector-ready” and no keyword changes should take place
The stripped down script does not deal with that tri-state possibility and could add “Collector”  or “CollectorDisabled” to a web map that normally is not available in collector. (that is what turns the UI “checkbox” on, presence of Collector/CollectorDisabled, but these items do not (should not) even show a checkbox)

a few comments:
(near the top) gis=GIS(“home”) works in Pro’s notebook environment as well, so you might change your comment on that line to reflect hosted or pro notebooks
If I do a query for web maps that does not explicitly query for collector/collectordisabled keywords, I can still be adding a Collector/CollectorDisabled keyword where I shouldn’t.
Example:
collector_usage=”enabled”
webmap_search_query=”Hydrant”
Let’s say that returns 1 web map, but it is not collector-ready, meaning it has no editable layers in it, and neither of the Collector/CollectorDisabled typeKeywords are present.
I believe your code will add “Collector” to the typeKeywords, which will be bad, since it will add the UI checkbox and actually let it show up in collector when it should not.

a few comments:
(near the top) gis=GIS(“home”) works in Pro’s notebook environment as well, so you might change your comment on that line to reflect hosted or pro notebooks
If I do a query for web maps that does not explicitly query for collector/collectordisabled keywords, I can still be adding a Collector/CollectorDisabled keyword where I shouldn’t.
Example:
collector_usage=”enabled”
webmap_search_query=”Hydrant”
Let’s say that returns 1 web map, but it is not collector-ready, meaning it has no editable layers in it, and neither of the Collector/CollectorDisabled typeKeywords are present.
I believe your code will add “Collector” to the typeKeywords, which will be bad, since it will add the UI checkbox and actually let it show up in collector when it should not.

need to correct the typekeyword/typekeywords (should be plural) in commented sample queries
Example query which would only update maps currently enabled for Collector
webmap_search_query = "title:Hydrant AND typekeywords:'Collector'"
Example query which would update maps currently enabled for Field Maps
webmap_search_query = "title:Hydrant AND NOT typekeywords:'FieldMapsDisabled'"
Maybe it's overkill but perhaps in the comments cell can mention this is following agol/portal query guidelines (include link to advanced query doc? https://doc.arcgis.com/en/arcgis-online/reference/advanced-search.htm  which oddly does not include mention of searching with typekeywords!) and they can test their query in their portal to make sure it comes back with what they are expecting.

need to correct the typekeyword/typekeywords (should be plural) in commented sample queries
Example query which would only update maps currently enabled for Collector
webmap_search_query = "title:Hydrant AND typekeywords:'Collector'"
Example query which would update maps currently enabled for Field Maps
webmap_search_query = "title:Hydrant AND NOT typekeywords:'FieldMapsDisabled'"
Maybe it's overkill but perhaps in the comments cell can mention this is following agol/portal query guidelines (include link to advanced query doc? https://doc.arcgis.com/en/arcgis-online/reference/advanced-search.htm  which oddly does not include mention of searching with typekeywords!) and they can test their query in their portal to make sure it comes back with what they are expecting.


Refactor for C++11 and Teensy 4.1

Changes required to compile with C++11 (as of version 1.6.6, the Arduino IDE enables C++11 by default).

I edited my pull request title to clarify that these changes were required to get it to compile on a Teensy 4.1 board.


Material with whitespaces cannot be read by ObjFileReader.FromStream

https://github.com/JeremyAnsel/JeremyAnsel.Media.WavefrontObj/blob/7b83ffbde616f021e6f1b3821097799d7f7da7e4/JeremyAnsel.Media.WavefrontObj/JeremyAnsel.Media.WavefrontObj/ObjFileReader.cs#L784
If an obj with "mtllib my cool material.mtl" is read, an exception is beeing thrown that the file has no extension.
Could this be fixed accordingly to https://github.com/JeremyAnsel/JeremyAnsel.Media.WavefrontObj/issues/3?

Hello,
I've modified the code to allow spaces in the mtllib instruction.


fix(ui): permission to delete media file match API

Description
UI needs to have ADMIN permission to display delete file link, but API only needs to have MANAGE_REQUESTS.
To-Dos

[x] Successful build yarn build
[x] Translation keys yarn i18n:extract

needs more tests


Downgraded TensorFlow to 1.5 to fix AVX incompatibility

Older CPUs do not support AVX, which is a requirement for TF>1.5. Several users (>5) are not able to use SCT because of that, so this PR downgrades TF to 1.5 until we find another solution (e.g., move to Pytorch).
Also removed requirements-freeze.txt (it was mistakenly added to master branch, but should only be present in release)
Fixes #2562

Thanks @bcdarwin!  I'd like to wait for feedback from at least one user in this situation to make sure it works on their end. Users contacted:

https://github.com/neuropoly/spinalcordtoolbox/issues/2562#issuecomment-592979815
http://forum.spinalcordmri.org/t/installation-failed-during-installation-of-keras/349/5?u=jcohenadad

Since this is a big deal, I am also testing all the scripts from the SCT course...


wip precompiled schema

Change Summary
Make it possible to re-use schema validators; the ultimate inlined definition!
Related issue number
N/A
Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@BoxyUwU, have you been working on this? Can we close as stale?

Closing in favor of Boxy's approach (coming soon)


Add option to convert nullable int columns to float columns in toPand…

…as to prevent needless Exceptions during routine use.
Add the strict=True kwarg to DataFrame.toPandas to allow for a non-strict interpretation of the schema of a dataframe. This is currently limited to allowing a nullable int column to being interpreted as a float column (because that is the only way Pandas supports nullable int columns and actually crashes without this).
I consider this small change to be a massive quality of life improvement for DataFrames with lots of nullable int columns, which would otherwise need a litany of df.withColumn(name, F.col(name).cast(DoubleType())), etc, just to view them easily or interact with them in-memory.
Possible Objections

I foresee concerns with the name of the kwarg, of which I am open to suggestions.
I also foresee possible objections due to the potential for needless conversion of nullable int columns to floats when there are actually no null values. I would counter those objections by noting that it only occurs when strict=False, which is not the default, and can be avoided on a per-column basis by setting the nullable property of the schema to False.

Alternatives

Rename the kwarg to be specific to the current change. i.e., nullable_int_to_float instead of strict or some other, similar name.
Fix Pandas to allow nullable int columns. (Very difficult, per Wes McKinney, due to lack of NumPy support. https://stackoverflow.com/questions/11548005/numpy-or-pandas-keeping-array-type-as-integer-while-having-a-nan-value)

Can one of the admins verify this patch?

@logannc , thanks for this.  You bring up a big issue here that I think was overlooked when this code was added in Spark.  I filed a JIRA for this SPARK-21766, which generally comes before the PR.  Please see the contributing guide here

There should be no way an error like this is raised during the call toPandas() so I am thinking that if there is a nullable int column, the type should not try to be changed in _to_corrected_pandas_type cc @HyukjinKwon @ueshin

I read the contributing guide. It said that simple changes didn't need a JIRA. Certainly this code change is quite simple, I just wasn't sure if there would be enough discussion to warrant a Jira. Now I know.
So, rather than return np.float32, return None? That would probably also work, though the bug might get reintroduced by someone unfamiliar with the problem. That is why I prefered the explicitness of returning a type.

@logannc, mind adding the JIRA number in this PR title as described in the guide line?
I definitely also think this needs a JIRA as before and after are not virtually same and it looks a non-trivial change - this even could be a regression if SPARK-21163 was resolved in 2.2.0. I believe tests are required here too.

Another rough thought for a feasible way I could think to keep the current behaviour (to be more specific, to match the types with / without Arrow optimization, IIUC) is, to make a generator wrapper to check if None exists in the results for columns where the type is int and nullable.

I'm not sure I follow @HyukjinKwon , we can just look at the pdf when it is first created but before any type conversions and just not do anything if it the column is a nullable int with null values.  Is this similar to what you're suggesting?

Ah, I had to be clear. I thought something like ...
dtype = {}
for field in self.schema:
    pandas_type = _to_corrected_pandas_type(field.dataType)
    if pandas_type is not None:
        dtype[field.name] = pandas_type

# Columns with int + nullable from schemaa
int_null_cols = [...]

# Columns with int + nullable but with actual None.
int_null_cols_with_none = [...]

# This functions checks if the value is None.
def check_nulls():
    for row in rows:
        # Check with int_null_cols and set int_null_cols_with_none if there is None.
        yield rows

# Don't check anything if no int + nullable columns.
if len(int_null_cols) > 0:
    check_func = check_nulls
else:
    check_func = lambda r: r

pdf = pd.DataFrame.from_records(check_null(self.collect()), columns=self.columns)

# Replace int32 -> float one by checking int_null_cols.
dtype = ...

for f, t in dtype.items():
    pdf[f] = pdf[f].astype(t, copy=False)
    return pdf

So, I was thinking of checking the actual value in the data might be a way if we can't resolve this only with the schema.

Yea, I think it is basically similar idea with https://github.com/apache/spark/pull/18945#discussion_r134033952.

Thanks for clarifying @HyukjinKwon , I see what you mean now.  Since pandas will iterate over self.collect() anyway I don't think your solution would impact performance at all right?  So your way might be better, but it is slightly more complicated..
Just to sum things up - @logannc does this still meet your requirements?
Instead of having the strict = True option we do the following:
for each nullable int32 column:
    if there are null values:
        change column type to float32
    else:
        change column type to int32

I'm also guessing we will have the same problem with nullable ShortType - maybe others?

BTW, I think it'd be nicer if we can go with the approach above ^ (checking the null in data and setting the correct type). I am okay with any form for the approach above as we have a decent Arrow optimization now for the performance aspect.

Sorry for the delay. Things got busy and now there is the storm in Houston. Will update this per these suggestions soon.

Hey @logannc, have you had some time to work on this? I want to fix this issue asap. Ortherwise, would anyone here be interested in submitimg another PR for the another approach?

gentle ping @logannc.

@BryanCutler, @a10y and @viirya, would you guys be interested in this and have some time to take over this with the different approach we discussed above -  https://github.com/apache/spark/pull/18945#issuecomment-323917328 and  https://github.com/apache/spark/pull/18945#discussion_r134033952? I could take over this too if you guys are currently busy.

Sorry I feel off the face of the earth.  I took your suggestions but implemented it a little differently. Unless I've made a dumb mistake, I think I improved on it a bit.

We also need a proper test for this.

@HyukjinKwon I can take over this if @logannc can't find time to continue it.

Hm. Where would I add tests?

@logannc There are pandas related tests in python/pyspark/sql/tests.py.

@logannc, mind adding the JIRA number in this PR title as described in the guide line? Please take a look - http://spark.apache.org/contributing.html.
I'd read carefully the comments above, e.g., adding a test, https://github.com/apache/spark/pull/18945#issuecomment-323307343, fixing the PR title, https://github.com/apache/spark/pull/18945#issuecomment-323162796, following the suggestion , https://github.com/apache/spark/pull/18945#issuecomment-331008594.

ok to test

Test build #82024 has started for PR 18945 at commit 18d8d72.

Test build #82024 has finished for PR 18945 at commit 18d8d72.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82024/
Test FAILed.

Test build #82025 has started for PR 18945 at commit 18d8d72.

Test build #82025 has finished for PR 18945 at commit 18d8d72.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82025/
Test FAILed.

Test build #82060 has started for PR 18945 at commit b313a3b.

Test build #82060 has finished for PR 18945 at commit b313a3b.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82060/
Test FAILed.

Test build #82061 has started for PR 18945 at commit 14f36c3.

Test build #82061 has finished for PR 18945 at commit 14f36c3.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82061/
Test FAILed.

Test build #82062 has started for PR 18945 at commit 6e248dd.

Test build #82062 has finished for PR 18945 at commit 6e248dd.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82062/
Test FAILed.

I've continued to use @HyukjinKwon 's suggestion because it should be more performant and is capable of handling it without loss of precision. I believe I've addressed your concerns by only changing the type when we encounter a null (duh).

Test build #82063 has started for PR 18945 at commit bd25923.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82065/
Test FAILed.

Merged build finished. Test FAILed.

Test build #82066 has started for PR 18945 at commit d93a203.

Test build #82063 has finished for PR 18945 at commit bd25923.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82063/
Test FAILed.

Test build #82066 has finished for PR 18945 at commit d93a203.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82066/
Test FAILed.

Hey @logannc, let's don't make it complicated for now and go with their ways first - https://github.com/apache/spark/pull/18945#discussion_r134033952 and https://github.com/apache/spark/pull/18945#discussion_r134925269.
Maybe we can make a followup later with some small benchmark results for the performance one and precision concern (I guess this one is not a regression BTW?). I think we should first match it with when spark.sql.execution.arrow.enable is enabled.

Test build #82067 has started for PR 18945 at commit 6e16cd8.

Test build #82067 has finished for PR 18945 at commit 6e16cd8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82067/
Test PASSed.


python312Packages.extract-msg: 0.50.1 -> 0.51.1

Diff: https://github.com/TeamMsgExtractor/msg-extractor/compare/refs/tags/v0.50.1...v0.51.1
Changelog: https://github.com/TeamMsgExtractor/msg-extractor/blob/0.51.1/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 348205 run on x86_64-linux 1

2 packages failed to build:

open-webui
open-webui.dist

4 packages built:

python311Packages.extract-msg
python311Packages.extract-msg.dist
python312Packages.extract-msg
python312Packages.extract-msg.dist

open-webui fails because of opentelemetry-proto failure.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 348205

x86_64-linux

:white_check_mark: 6 packages built:

open-webui
open-webui.dist
python311Packages.extract-msg
python311Packages.extract-msg.dist
python312Packages.extract-msg
python312Packages.extract-msg.dist


Sometimes data lost

Just a heads up, in case it is good to know.
I came across the issue, that some data will be lost in the client when I create a new subscription. E.g., I have a user with an avatar property. When I create a new subscription in an autorun, which is totally unrelated to these avatars (at first sight), the avatar collection is cleared. This doesn't happen if I replace SubMgr with default subscriptions.

Okay. Seems like a big issue.
Is it possible to have a sample code as a gist or as a repo.
So, I can locally replicate and fix this quickly.
On Wed, Feb 25, 2015 at 2:39 PM bensmeets<EMAIL_ADDRESS>wrote:

Just a heads up, in case it is good to know.
I came across the issue, that some data will be lost in the client when I
create a new subscription. E.g., I have a user with an avatar property.
When I create a new subscription in an autorun, which is totally unrelated
to these avatars (at first sight), the avatar collection is cleared. This
doesn't happen if I replace SubMgr with default subscriptions.
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/subs-manager/issues/30.

Will try to get something like my setup in meteorpad. Might take same time because of the setup I use though :(

Okay. That's perfect.
I'll wait for that.
I couldn't try to replicate it locally.
On Wed, Feb 25, 2015 at 9:45 PM bensmeets<EMAIL_ADDRESS>wrote:

Will try to get something like my setup in meteorpad. Might take same time
because of the setup I use though :(
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/subs-manager/issues/30#issuecomment-75989896
.

After trying a couple of hours to get something reproducable to you, I'm stuck while banging my head against the wall. There is never 1 single reproducable way when it goes wrong. Not even a way for sure to know what the cause is. It feels totally random. Since I can't share the entire project, it's hard to prepare something that is and still contains the issue.
I've been debugging like crazy (which is hell in Meteor's publish/subscribe if you don't know where to look btw :) ) and the more I try things, the more I feel like it's not so much a subs-manager problem. It feels more like something within a published Meteor.users collection is deciding that some added meta fields to the user collection need to be removed (I see the Avatar's image being removed at random in the ddp analyzer).
So let's assume it's my misunderstanding of publications, or maybe something regarding the reactive joins I'm publishing or whatnot. I'm gonna keep on trying to find the issue, if it is anything related to subs manager, will get back to you.
Thanks for the quick reply :)

Great. If you found something let me know.
I will help you to fix it.
On 2015 පෙබ 26, බ්‍රහස් at පෙ.ව. 4.47 bensmeets<EMAIL_ADDRESS>wrote:

After trying a couple of hours to get something reproducable to you, I'm
stuck while banging my head against the wall. There is never 1 single
reproducable way when it goes wrong. Not even a way for sure to know what
the cause is. It feels totally random. Since I can't share the entire
project, it's hard to prepare something that is and still contains the
issue.
I've been debugging like crazy (which is hell in Meteor's
publish/subscribe if you don't know where to look btw :) ) and the more I
try things, the more I feel like it's not so much a subs-manager problem.
It feels more like something within a published Meteor.users collection is
deciding that some added meta fields to the user collection need to be
removed (I see the Avatar's image being removed at random in the ddp
analyzer).
So let's assume it's my misunderstanding of publications, or maybe
something regarding the reactive joins I'm publishing or whatnot. I'm gonna
keep on trying to find the issue, if it is anything related to subs
manager, will get back to you.
Thanks for the quick reply :)
—
Reply to this email directly or view it on GitHub
https://github.com/meteorhacks/subs-manager/issues/30#issuecomment-76082886
.

If it's in a autorun function, do the parameters that it is subscribed to change?  If so, it may be reaching the maximum number of cached subscriptions and unsubscribing from the avatar's subscription.

Hi!
Same issue here. Have you found the problem?
I'll try to reproduce it.
When I make a new subscription with subs.subscribe to get more documents for a subscription (infinite scroll; ex: user activity), other subscriptions are cleared but I still need them (ex: user info). If I use Meteor.subscribe inside this.autorun this doesn't happen.

@VioletaCalvo this may be reason of the default cache limits. Try to increase it.
See: https://github.com/kadirahq/subs-manager#cache-control

Thank you @arunoda I'll try that :blush:

also happening here. Did anybody identify the underlying cause? @VioletaCalvo did increasing the cacheLimit help?

I would expect that subs.subscribe inside an autorun is reran in case it is expired. Is that maybe not the case?

Sorry for the late reply @miri-am.
I couldn't fix the problem with cacheLimit so I used Meteor.subscribe


Abstracts over the target runtime Monad

The following PR decouples DataSource impls making them agnostic of the target runtime M[_] : MonadError[A, Throwable] so this only needs to be known to the actual call site run semantics.
As a side effect makes Fetch structures re-computable to any arbitrary M[_] such as Future, Task etc...
@dialelo Can you please review?

Outstanding!


Please add last commit date

It would be useful to see when the last commit was made.
Even better would be to see the date of the last upstream commit as well, because "70 commits behind" say nothing about dates. But not sure how difficult it will be.

maybe it makes sense to get the dates of the fork by an explicit request? (button or something like that)

Not a bad idea. I'll consider it.

Turns out the pushed_at data was already part of many of the requests the tool was already issuing.
Thanks for making this great suggestion! :)

See #35 for a small related update/improvement. :)


Update Remove-AutoSensitivityLabelRule.md

Docs Build status updates of commit 1563e7a:
:clock10: Full build: the average full build time is 17 min(s) 34 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 1563e7a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Remove-AutoSensitivityLabelRule.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8b8d6f0:
:clock10: Full build: the average full build time is 17 min(s) 34 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 8b8d6f0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Remove-AutoSensitivityLabelRule.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Move concluded / withdrawal event to post db update

What does this pull request do?
Move notification event(s) to after the updates are applied in R&M
What is the intent behind these changes?
Avoid out of sync notifications when database change in unsuccessful causing issues with NDelius

Looks good @awhodgson256 . Just wondering if we need to add exception handling block for conclude method call ? If something goes wrong with that, we don't want to publish conclude event.

Looks good @awhodgson256 . Just wondering if we need to add exception handling block for conclude method call ? If something goes wrong with that, we don't want to publish conclude event.

Hi @amolphalnikar In the event of exception (or a throwable), processing stops and we jump back to exception handling further up the call stack - so in that event we don't get as far as the "signalEnding" method which would send the event.  I think we're ok?

If that's the case then great. Thanks @awhodgson256.  I have approved the PR.


permissionsDeniedMethod is never called

When handleRationale = false and handlePermanentlyDenied = false the method to handle denied permissions is never called.
When I deny the permission in the Android dialog, my callback is never called.
This is my code:
val options = QuickPermissionsOptions(
    handleRationale = false,
    handlePermanentlyDenied = false,
    permissionsDeniedMethod = {
        // This method is never called
    }
)

activity.runWithPermissions(Manifest.permission.ACCESS_FINE_LOCATION, options = options) {
    // Works Ok
}

This issue is now fixed

New version released with fix: https://github.com/QuickPermissions/QuickPermissions-Kotlin/releases/tag/0.4.0


Change links to React lifecycle methods diagram to use HTTPS

Why HTTP 301 if we can have HTTP 200 :)

@wojtekmaj thanks!


Github MultiOrgEntity Provider using Github App Authentication type does not pull emails from Github

📜 Description
Both GithubMultiOrgProvider and GithubOrgProvider while using Github App Authentication type do not pull emails from Github.
From this logic https://github.com/backstage/backstage/blob/af3c08e6607f3e9e486bb9958744982eb056d625/plugins/catalog-backend-module-github/src/lib/github.ts#L171
and here
https://github.com/backstage/backstage/blob/af3c08e6607f3e9e486bb9958744982eb056d625/plugins/catalog-backend-module-github/src/lib/github.ts#L151
obviously, you are ignoring the email whenever the token type is app.
👍 Expected behavior
emails should not be ignored when the token type is app
👎 Actual Behavior with Screenshots
Email is ignored when token type is app
this is one example of githubUser coming in from the GithubMultiOrgProvider
 user pulled in  {
   avatarUrl: 'https://avatars.githubusercontent.com/u/132474028?v=4',
   bio: '',
   login: 'joshua-obasaju-sky',
   name: 'Joshua Obasaju',
   organizationVerifiedDomainEmails: []
 }

email is not pulled in.
👟 Reproduction steps
This configuration is in app-config.yaml
integrations:
  github:
    - host: github.com
      apps:
        - appId: ${GITHUB_APP_ID}
          webhookUrl: ${GITHUB_APP_WEBHOOK_URL}
          clientId: ${GITHUB_APP_CLIENT_ID}
          clientSecret: ${GITHUB_APP_CLIENT_SECRET}
          webhookSecret: ${GITHUB_APP_WEBHOOK_SECRET}
          privateKey: ${GITHUB_APP_CLIENT_PRIVATE_KEY}

In user transformer here

  userTransformer: async (user, ctx): Promise<UserEntity | undefined> => {
        const entity = await defaultUserTransformer(user, ctx);

        console.log('user pulled in ', user);

        if (entity && user.organizationVerifiedDomainEmails?.length) {
          entity.spec.profile!.email = user.email;
        }

        return entity;
      },

Print looks this way
 user pulled in  {
   avatarUrl: 'https://avatars.githubusercontent.com/u/132474028?v=4',
   bio: '',
   login: 'joshua-obasaju-sky',
   name: 'Joshua Obasaju',
   organizationVerifiedDomainEmails: []
 }

📃 Provide the context for the Bug.
Our Authentication source of truth is Azure AD, we want to use Github as our teams and Group's source of truth.
In order to achieve ownership and groups each user belongs to, we want to use email as a way of connecting logged-in AD Users with GitHub Users.
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

Unfortunately due to a limitation in the Github API (GitHub's official answer)) we are unable to implement this functionality. Due to this I am closing the issue.


Font Awesome icons in skins with black footer not visible

Environment

Minimal Mistakes version: 4.20.2
Ruby gem or remote theme version: jekyll-remote-theme 0.4.2
Jekyll version: 3.9
Git repository URL: https://github.com/dleidert/www.wgdd.org
GitHub Pages hosted (if yes provide URL to site): no (builds locally and on travis)
Operating system: Debian Linux

Expected behavior
I'm using the neon skin and the contrast skin. In both some fa icons (e.g. github) in regions with a black background color (e.g. the footer in this case) are not visible.
Steps to reproduce the behavior
It can be reproduced by building the test folder in the mm theme using the neon or the contrast skin. The github icon in the footer is not (hardly) visible.
Example
https://www.wgdd.org/projects/

Also it would be nice to have a general class for fa icons in the footer or in the sidebar so the icons have the same color as the ones already handled in the CSS stylesheets like github, email or instagram.

Thanks. Works like a charm now :)


Build: Use Travis Stages

This is still beta, but I thought I'd give it a try.
Instead of running the full matrix at once, run the mainline node release linting and coverage, and then run the rest if that is ok.
I think in the end there could probably be a "docker" phase to maybe run some alpine stuff in the future. It could also be used to orchistrate the releases, although there would need to be some sync/handshake with AppVeyor

I also removed "iojs" since it was already excluded from the matrix

This is cool, nice one!

True we would still need to change it. At some point in the future we'll
only support LTS and current so using the node key is nice because it'll
always be the current.
On 26 May 2017 3:01 pm, "Nick Schonning"<EMAIL_ADDRESS>wrote:

@nschonni commented on this pull request.
In .travis.yml
https://github.com/sass/node-sass/pull/1977#discussion_r118696645:

env:
global:
- SKIP_SASS_BINARY_DOWNLOAD_FOR_CI=true

-matrix:

fast_finish: true
exclude:

node_js: iojs

node_js: "0.10"
+jobs:

include:

stage: test

 node_js: "7"

Looks like there is a "node" key https://docs.travis-ci.com/
user/languages/javascript-with-nodejs/#Specifying-Node.js-versions
We would still have to change for Node 8 since we would need to add it to
the matrix. I do like this idea though
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/pull/1977#discussion_r118696645, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjZWM5Yp44bA6vgJ1Fr_hEVkTxgFnUDks5r9s0qgaJpZM4NnKTJ
.

Yeah, it would be good to see if the "LTS" could be used too. It looks like NVM does have that concept https://github.com/creationix/nvm#long-term-support

I swapped the 6 for lts/boron and 4 with lts/argon. It looks like we could uselts/* in that future case where you only want the latest & LTS though.

Nice find. I'm still traveling but sounds good to me
On 26 May 2017 3:50 pm, "Nick Schonning"<EMAIL_ADDRESS>wrote:

I swapped the 6 for lts/boron and 4 with lts/argon. It looks like we
could uselts/* in that future case where you only want the latest & LTS
though.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/pull/1977#issuecomment-304287398, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAjZWIMiBeiKzvI4xdyAmpqscCuiJOb6ks5r9ti6gaJpZM4NnKTJ
.

I think landing this can wait a bit, just to see if Travis changes anything before it gets out of beta.

I'm just going to land this and then add in 8 separately


tests: drivers: uart: Fix async write abort test

During the write abort test, a second write is started then quickly aborted.  This means that the number of bytes sent is relative to that second write.  So when comparing it against the number of bytes received which is NOT reset, the first (completed) send of five bytes has to be accounted for.  The current nrfx implementations abort quick enough that no bytes are reported sent, so this wasn't currently being exercised (i.e. the short circuit of zero bytes sent was taken).
Tested on nrf52840_pca10056.

This approach is incorrect.

So when comparing it against the number of bytes received which is NOT reset, the first (completed) send of five bytes has to be accounted for.

Number of bytes received is updated at every UART_RX_RDY event to number of bytes that have been received between the last UART_RX_RDY event and current event. So you don't have to account for bytes already received.
Previous test implementation was correct, perhaps I should clarify how number of bytes received is calculated in API documentation.
This has to be reverted.

Ok, sorry for the misunderstanding.
Just for clarity: the description of rx.len is something like "Number of (new) bytes received", so the valid range is rx.buf[rx.offset] to rx.buf[rx.offset+rx.len] (i.e. offset is relative to the start of the buffer, and len is relative to offset)?

Yes, that was the intention


Vscode debug doc changes for config files

Changes made to vscode debug instructions including:

Updated "tasks.json" to version 2.0.0 format.
Compile task references the default "compile" script from package.json.
Updated "launch.json" to specify Windows path for "runtimeExecutable" parameters.

@vlad-shatskyi btw do you think it's worth adding both these files under a ".vscode/" folder in the branch (and remove them from .gitignore)? I can see that not everyone uses vscode so maybe not.

@mkenne11 I don't think it'd be useful for anyone else, taking into account that nobody really contributes these days. https://github.com/railsware/upterm/graphs/contributors
But if it's useful for you, go ahead and add it.

By the way, I didn't ask your feedback, right? Would you mind answering the following questions?

Do you use Upterm as your main terminal emulator?
What feature is the best for you?
Is there anything that annoys you?
What features do you miss?
How did you find Upterm?

Not a problem @vlad-shatskyi see my answers below:

Do you use Upterm as your main terminal emulator?
No atm I use Ubuntu's standard terminal application.

What feature is the best for you?
I like auto-suggestion of commands and options. I'm a part-time linux person so this is very helpful.

Is there anything that annoys you?
The major annoyance is I doesn't keep the sudo session active past one command entry - re-entering my command each time i sudo isn't ideal.
There are also some minor formatting and performance issues as well.

What features do you miss?
In terms of a wish list of features I'd like to see:

Tabs which can be dragged to change there order.
A "history" tab which shows previously used tabs for the session, and could be filtered to see all commands or per tab; and the ability to select commands from the history list to re-run.

How did you find Upterm?
Through the awesome-electron list (https://github.com/sindresorhus/awesome-electron). I was looking for an electron + react + typescript project to contribute too to learn these skills.


Can you make it so the host has access ?

RUN  usermod -u 1000 www-data
If there's another way to do this, I'd love to know.  I can do a PR!
Thanks :)

Hello, @iot-resister. Sorry for a late reply.
What do you mean under "host has access"?
Your PR is welcome!


SVGGroup assertion failure fuzzing balancing-chemical-equations

Trying to dispose an SVGGroup before it is empty. Triggered with ?fuzzMouse=100&ea, no clue yet how to easily reproduce it (it takes a while to happen).

Query parameter: sceneryStringLog&sceneryLog=Stitch.GreedyStitcher.BackboneDrawable.Display.Drawable.FittedBlock.Instance.SVGBlock.SVGGroup

Also possibly related (found with fuzzing in FPAF):
Uncaught Error: Assertion failed: There should be no drawables on a block when it is disposed
Error: Assertion failed: There should be no drawables on a block when it is disposed
    at window.assertions.assertFunction (http://<IP_ADDRESS>:8080/assert/js/assert.js:22:13)
    at SVGBlock.inherit.dispose (http://<IP_ADDRESS>:8080/scenery/js/display/Block.js?bust=1423709343298:57:44)
    at SVGBlock.inherit.dispose (http://<IP_ADDRESS>:8080/scenery/js/display/FittedBlock.js?bust=1423709343298:130:31)
    at SVGBlock.inherit.dispose (http://<IP_ADDRESS>:8080/scenery/js/display/SVGBlock.js?bust=1423709343298:245:37)
    at Display.extend.updateDisplay (http://<IP_ADDRESS>:8080/scenery/js/display/Display.js?bust=1423709343298:284:40)
    at animationLoop (http://<IP_ADDRESS>:8080/joist/js/Sim.js?bust=1423709343298:742:23)

The fixes applied for https://github.com/phetsims/scenery/issues/392 were the root cause of this (descendant Instance not being disposed caused the Backbone to not be disposed, thus removeDrawable was not called).
Closing.

Still occurs, but takes much longer to happen.

From 30 minutes of testing yesterday and 20 minutes today, I haven't been able to reproduce with fuzzing. Will wait a while more.

Ok, 2 hours total of fuzzing with no reproduction. Closing.


Leak in DiskBasedMap

Describe the problem you faced
java.lang.ApplicationShutdownHooks holds huge number of org.apache.hudi.common.util.collection.DiskBasedMap and org.apache.hudi.common.util.collection.LazyFileIterable$LazyFileIterator object, run out of memory.
To Reproduce
Steps to reproduce the behavior:

run hudi in local mode with  local[4] and 4G memory, set spark.memory.fraction=0.2 spark.memory.storageFraction=0.2 (allowing it to spill rather than OOM according to tuning guide)
receive messages from kafka and write them into hdfs using hudi for few days
then out of memory happened

I check lsof, the process opens 25000+ temp file in /tmp
Check with jmap -dump, there are large number of DiskBasedMap and LazyFileIterable in ShutDownHooks. (see below)
How to close these temp files and hooks ?
Environment Description

Hudi version : 0.5.3

Spark version : 2.4.6

Hive version : 1.2.1

Hadoop version : 2.7.3

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) : no

Additional context
Class Name                                                                                | Shallow Heap | Retained Heap
----------------------------------------------------------------------------------------------------------------------------------------------------------------
class java.lang.ApplicationShutdownHooks @ 0x6c45b3888 System Class                                                              |            8 | 3,233,852,456
|- <class> class java.lang.Class @ 0x6c3d26108 System Class                                                                      |           40 |         1,152
|- <classloader> java.lang.ClassLoader @ 0x0  <system class loader>                                                              |           64 |            64
|- <super> class java.lang.Object @ 0x6c3d4e498 System Class                                                                     |            8 |            40
|- <resolved_references> java.lang.Object[3] @ 0x6c449b708                                                                       |           32 |           208
|- hooks java.util.IdentityHashMap @ 0x6c4658950                                                                                |           40 | 3,233,852,240
|  |- <class> class java.util.IdentityHashMap @ 0x6c45b36a0 System Class                                                         |           32 |           264
|  |- table java.lang.Object[262144] @ 0x794000000                                                                               |    1,048,592 | 3,233,852,200
|  |  |- <class> class java.lang.Object[] @ 0x6c3cc9610                                                                          |            0 |             0
|  |  |- [221646], [221647] org.apache.hudi.common.util.collection.LazyFileIterable$LazyFileIterator$1 @ 0x6c0009d60  Thread-112 |          128 |           536
|  |  |- [88924], [88925] org.apache.hudi.common.util.collection.LazyFileIterable$LazyFileIterator$1 @ 0x6c0019338  Thread-1549  |          128 |           536
|  |  |- [203058], [203059] org.apache.hudi.common.util.collection.LazyFileIterable$LazyFileIterator$1 @ 0x6c0019650  Thread-1611|          128 |           536
|  |  |- [256104], [256105] org.apache.hudi.common.util.collection.LazyFileIterable$LazyFileIterator$1 @ 0x6c0160080  Thread-1460|          128 |           536
|  |  |- [239698], [239699] org.apache.hudi.common.util.collection.DiskBasedMap$1 @ 0x6c0160500  Thread-1432                     |          128 |       131,808
|  |  |- [72214], [72215] org.apache.hudi.common.util.collection.DiskBasedMap$1 @ 0x6c01609d0  Thread-1451                       |          128 |       131,808
|  |  |- [31762], [31763] org.apache.hudi.common.util.collection.DiskBasedMap$1 @ 0x6c0160df0  Thread-1435                       |          128 |       131,808
----------------------------------------------------------------------------------------------------------------------------------------------------------------

This is currently tracked in https://issues.apache.org/jira/browse/HUDI-945
Should be a simple fix as mentioned in the jira. Are you interested in submitting a PR ? We will have this fixed in next release.

Closing this issue as we have a jira to track.


sqlalchemy.exc.IntegrityError

Hi, i train the bot with the same response for different input  :
chatbot.train(["Hello Good Morning", "Hi"])
chatbot.train(["Hello Goog Night", "Hi"])

and I get :
sqlalchemy.exc.IntegrityError: (sqlite3.IntegrityError) UNIQUE constraint failed: ResponseTable.text, ResponseTable.text_search [SQL: 'INSERT INTO "ResponseTable" (id, text, occurrence, statement_text, text_search) VALUES (?, ?, ?, ?, ?)'] [parameters: (None, 'Hello Good Morning', 1, 'Hi', '{"id": null, "text": "Hello Good Morning", "occurrence": 1, "statement_text": "Hi"}')]

yes, i'm reproducing it... could anybody help with this? thanks.

Hey, this is definitely a bug. Its in this file: https://github.com/gunthercox/ChatterBot/blob/master/chatterbot/storage/sql_storage.py
It may be a day or so before I get a chance to check through the code and fix it.
Sorry.

@gunthercox, what is the status of this bug? I ran into this a few days ago, and it seems that it doesn't connect to the database when one uses the SQLStorageAdapter. Is this what you found? In this case, I suppose we can just hard code the path to our SQL dbs while we wait for the fix, right?

@sal48 The status is the same as it was a few days ago. You will see comments and / or pull requests from me when I make changes.

it seems that it doesn't connect to the database when one uses the SQLStorageAdapter

This issue is due to integrity errors from a unique constraint violation.


Handle Abort command correctly

Previously
Goal False.
Abort.

Goal True.
  tauto.
Qed.

was displayed as
Goal False.

because Abort. was not recognised as proof end.

Thank you!


File title versus file-history

I'm not sure if that's great or confusing ..

Open file a.xml in XMLnotepad
"a.xml" is displayed in caption of program and in history-list
Open file b.xml in another XMLnotepad session
"b.xml" is displayed in caption of program and in history-list of second session
close "session b"
"a.xml" is still displayed in caption of "Session A" and history-list changes to "B.xml"

I think if it's a real history, then the currently opened file should not be displayed..

Should be fixed by commit https://github.com/microsoft/XmlNotepad/commit/6f040c47cfee560575f33c6d9226fe2603c54b7f

Fixed in https://github.com/microsoft/XmlNotepad/releases/tag/<IP_ADDRESS>

Thanks number 3

I have to open this again, because it is still (or again) confusing me.
To reproduce:
Double click  on A.xml - it is opened
Double click  on B.xml - it is opened
Double click  on C.xml - it is opened
I have three sessions; in each I have the current file in the caption of the software and in the "recently used files".
Problem A: The caption shows only the filename, the MRU shows full path.

(Optionally: Open in one of the sessions (e.g. in Session B) the file something.xml)
Close one of the sessions (e.g. "B")
-->> The currently used file from session B appears in the "Recently list" from active sessions A and C.

I'm still not sure if this is a) more helpful or b) more confusing. (Personally, I tend to b). But in any case, it is a unique feature - I'm not aware of another software.
(But maybe it is caused because there are not three sessions but only three windows of one session? Or so ...??)


Added steps to backup ce data

@sum35h Can you let us know which of the steps in backup before upgrading to BE (K8s) is mandatory? https://docs.appsmith.com/getting-started/setup/upgrade-to-business-edition/kubernetes#backup-data
For eg: in the screenshot below, are the highlighted steps required before these start the installation. Like can they not download the backup later when required? Basically, asking because, in the shorter version available on the customer portal, we want to ensure we don't skip any mandatory step.   Here's the link to the original -

Adding the DP links here for easy access as these hidden pages
https://appsmith-docs-git-steps-to-backup-ce-get-appsmith.vercel.app/getting-started/setup/upgrade-to-busin[…]ion/upgrade-docker-to-business-edition
https://appsmith-docs-git-steps-to-backup-ce-get-appsmith.vercel.app/getting-started/setup/upgrade-to-busin[…]dition/upgrade-k8s-to-business-edition


Wassaf/28 ocw hugo footer

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling

[x] Desktop screenshots
[x] Mobile width screenshots

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
Closes #28
What's this PR do?

Updates footer as per invision design
Adds footer to Home Page About and Educator Page

How should this be manually tested?

Verify footer is responsive
Verify all links point to correct URLs
Verify spacing and font sizes

Screenshots (if appropriate)

@pdpinch.
I currently just need the icon images for the social websites after which this PR will be ready to go.

Footer looks great! just noticed few design things:

I guess all the "non-ocw" links, such as links to mit, openlearning, especially social media, should be opened in a new tab? Perhaps @pdpinch can share his thoughts.
Not sure, but what if we keep the social media links in their original color instead of all being blue? (also dropped a comment in design)
Shouldn't the copyright text include 2022 instead of 2021? (also dropped a comment in design)
For large screens, having width from 992px to somewhere around 1190px, the social media links section comes close to the first section, instead of being float/pushed to right. (Not sure, you can also verify). For reference please see image#1.
For mobile screens, having width 375px, the 2 logos seems to be overlapping. I guess these logos can be aligned vertically (instead of being aligned horizontally) for this screen size. Please see image#2
Same issue as above, open education global, can be aligned vertically with it's heading.
Please see image#3

Reference images:
image#1
image#2
image#3

I have addressed all the feedback However I do want to inform that Open learning Image will still be unaligned at  < 400px
since the image itself has right padding I will add comments in the invision design to request that image

Sorry I missed these questions.

Yes please open the off-site links in a new window.
Did you get a reply from the designer? If not, just leave them as they are now.
Yes copyright should be 2022
I think this is OK.
Yes, please try aligning vertically
This doesn't look too bad to me, but you can try aligning vertically if you like.

please don't merge this yet. The MIT logo, and the social network logos need attention, but I need to talk to some other folks to figure out what to do with them.

please don't merge this yet. The MIT logo, and the social network logos need attention, but I need to talk to some other folks to figure out what to do with them.

@pdpinch Sure I will wait.
However I had added comments on the invision design but received no reply from the designer and I am aware of the social links issue but not of the MIT logo.

@pdpinch @MAbdurrehman12 Updated social images

Sorry @Wassaf-Shahzad you questions brought up some issues with the footer design. Can you update to use his new design? I hope it's not a lot of work. https://invis.io/UM12AT5562GS#/463497214_OCW_Footer_2022_V1

Sorry, I have no idea what that red border is for. Let's discuss tomorrow, but it shouldn't block this PR.

Does this PR add the footer to the course theme as well, or will that be in another PR?

This PR does not add the footer in the course theme however the footer was already added in the initial commit for the course theme .

@pdpinch addressed changes


Small fixes to minmea_gettime

Handle four digit years provided by ZDA in minmea_gettime
Assume GPS epoch to allow dates prior 2000 to be parsed

This really needs unit testing to make sure we're handling all cases correctly. Could you please add tests for edge conditions in test_minmea_gettime? Specifically, the following cases:

year=79 (should read as 2079)
year=80 (should read as 1980)
year=1979 (?????? - I don't know how we should handle this one, possibly as a wraparound in receiver firmware, so... 2079?)
year=1980 (should read as 1980)

Thank you, will do. Do you mind the assumption of the GPS epoch for interpreting two digit years?

The assumption sounds fair to me - at least, this the most logical way to handle two-digit years. Also, minmea_gettime() is just a convenience helper, so if someone happens to own a receiver with really b0rked date handling they can just roll out their own version.

Another question: I've written tests that run well on my Mac, but I'm a little less confident in systems with a 32-bit time_t with standard libraries that are affected by the year 2038 problem. I can ifdef out tests out of this range based on sizeof(time_t) and an assumption that a typical platform will use a signed int. Does this sound good to you?

I like if (sizeof(time_t) == sizeof(int64_t)) as platforms with 32-bit time_t are screwed anyway. One more thing though: can you please normalize whitespace in your patches? All tabs should be four spaces. That, and we're good to merge.

Thanks for your patient feedback.

Merged. Thanks a lot!


A question: how to use to wait until image is available

Hi, my use case is to wait (show spinner) until the image is available on the server (i.e. show spinner even in case of 404 and try to load). Does this component fit for such a case? Can you suggest how it's better to make it wait?

I had a similar use case.. I needed to retry the request X number of times until the asset was available. I ended up wrapping this library using composition, and re-rendering the  component after some delay inside the onError prop function.


Gh 5121 fedx bind left join

Note: The PR is still WIP (some further changes, and especially unit test coverage will follow) however it is ready for early review. The goal is to have this available in RDF4J 5.1
GitHub issue resolved: #5121
Briefly describe the changes proposed in this PR:
The PR consists of multiple commits which add an implementation for bind left joins. It is recommended to follow the change commit by commit (as the first ones are preparational refactoring)
Commit 1: GH-5121: refactor the bind join logic into a reusable base class
Refactor the existing logic for executing bind joins into a reusable
base class.
This change mostly moves the implementation logic from the existing
ControlledWorkerBindJoin class to a new intermediate implementation
(with the goal to make it reusable in a second step for left joins).
Note that the bind join implementation no longer uses the
ControlledWorkerJoin as base class, i.e. the decision of which join
implementation to use is moved to the strategy.
For backwards code compatibility the "ControlledWorkerBoundJoin" is
kept, but no longer used. Instead the new code is in
ControlledWorkerBindJoin.
Commit 2: GH-5121: prepare execution of left joins in the federation strategy
Prepare to execute a specific implementation of a left join
implementation through the federation strategy.
Commit 3: GH-5121: implementation of left bind join operator
This change provides the implementation and activation for the left bind
join operator.
The algorithm is as follows:

execute left bind join using regular bound join query
process result iteration similar to BoundJoinVALUESConversionIteration
remember seen set of bindings (using index) and add original bindings
to those, i.e. put to result return all non-seen bindings directly from
the input

Note that the terminology in literature has changed to "bind joins".
Hence, for new classes and methods I try to follow that.
Change is covered with a unit tests
Commit 4: GH-5121: configurability of bind left joins
Bind left joins for OPTIONAL can be disabled using the
"enableOptionalAsBindJoin" flag in the federation config
Integrate the switch between implementations in the unit test as
parameterized test
Commit 5: GH-5121: code simplifications in bind join implementation

use for-each loop for iterating bindingset
use IntHashSet
use Literal#intValue instead of Integer#parseInt

TODOs

[x] further unit test coverage
[x] validate check left bind join pattern
[x] configurability to turn bind left joins off
[x] ...

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad thanks for the feedback. I will get back to this PR soon (we are currently in the release finalization phase of our product and this requires most of my attention).
Quick question: is there a timeline for the 5.1 release? I would like to see this change included (if I get it ready) such that we can make use of it in our next release. Ideally the 5.1 release would be available in the second half of november. What are the current project plans?

We don't have any plans at the moment.
I'm currently working on the last SHACL paths that aren't supported. I also have a PR for configuring the Apache HttpClient timeouts. And there is a request for adding support for configuring the document loader in the new JSON-LD 1.1 parser.
Would really want the timeouts included, and if I start on the JSON-LD document loader then it shouldn't take more than a few weeks to get it merged.
So we can say mid november for RDF4J 5.1.

The PR should not be fully ready for review. I have addressed my remaining TODOS and the feedback from @hmottestad  (Thanks for that btw).
Can I ask for reviews on this?
Note: when this is merged, I will create some additional improvements as part of orthogonal improvement issues (still to be created)

-So we can say mid november for RDF4J 5.1.

That sounds really great. Let's aim for that. Might be helpful for us in our product to test the 5.1 branch earlier in our product (to be able to react when there are still issues encountered during testing / using). Note: we cannot really use RDF4J snapshot versions. Would it be poissible to create a milestone build some time end of October for acceptance testing?

I would like to merge this PR in the upcoming days, to continue with https://github.com/eclipse-rdf4j/rdf4j/issues/5151 and https://github.com/eclipse-rdf4j/rdf4j/issues/5152
Anybody interested in doing further reviews before merging (e.g. @hmottestad )? I will also ask a colleague of mine to help with a review, will likely be there early next week

LGTM. Feel free to merge!

thanks @hmottestad
Have merged it. Unfortunately the merge commit message does not reference the PR correctly (and I messed up the commit message, has a lower case issue reference). Is this something that requires to be resolved?


recent updates to python3-colored "break" the standalone tests

Recent updates to https://pypi.org/project/colored/ (dslackw/colored@0c83f9d6d and dslackw/colored@07b96ebc4) made colored "tty aware". Now when redirecting stdout/stderr, colored won't colorize unless FORCE_COLOR=1 is set in the environment. This applies to the (default) "standalone" tests.
Currently you get something like:
## update tests
$ CHEATSH_UPDATE_TESTS_RESULTS=YES bash tests/run-tests.sh

## this will 100% pass
$ bash tests/run-tests.sh

## this will have some test fails
$ CHEATSH_TEST_STANDALONE=NO bash tests/run-tests.sh

An example of a failing test is:
Running 17: az                          # chubin/cheat.sheets
curl -s http://localhost:8002/az
--- results/17^I2022-08-09 19:13:32.000000000 -0400
+++ /tmp/cht.sh.tests-BZChFgyKuYEhgr^I2022-08-09 19:14:23.000000000 -0400
@@ -1,4 +1,4 @@
- cheat.sheets:az
+^[[48;5;8m^[[24m cheat.sheets:az ^[[24m^[[0m
 ^[[38;5;248;03m# Microsoft Azure CLI 2.0^[[39;00m
 ^[[38;5;248;03m# Command-line tools for Azure^[[39;00m

@@ -95,7 +95,7 @@
 ^[[38;5;248;03m# detach disk^[[39;00m
 ^[[38;5;252maz^[[39m^[[38;5;252m ^[[39m^[[38;5;252mvm^[[39m^[[38;5;252m ^[[39m^[[38;5;252mdisk^[[39m^[[38;5;252m ^[[39m^[[38;5;252mdetach^[[39m^[[38;5;252m ^[[39m^[[38;5;252m--vm-name^[[39m^[[38;5;252m ^[[39m^[[38;5;252mvm1^[[39m^[[38;5;252m ^[[39m^[[38;5;252m-g^[[39m^[[38;5;252m ^[[39m^[[38;5;252mRESOURCE_GROUP^[[39m^[[38;5;252m ^[[39m^[[38;5;252m--name^[[39m^[[38;5;252m ^[[39m^[[38;5;252mDISK1_ID^[[39m

- tldr:az
+^[[48;5;8m^[[24m tldr:az ^[[24m^[[0m
 ^[[38;5;248;03m# az^[[39;00m
 ^[[38;5;248;03m# The official CLI tool for Microsoft Azure.^[[39;00m
 ^[[38;5;248;03m# Some subcommands such as `az login` have their own usage documentation.^[[39;00m

And a sample of the results file tests/results/17, post-update:
diff --git a/tests/results/17 b/tests/results/17
index 6fb087f..802fded 100644
--- a/tests/results/17
+++ b/tests/results/17
@@ -1,37 +1,37 @@
-^[[48;5;8m^[[24m cheat.sheets:az ^[[24m^[[0m
-^[[38;5;246;03m# Microsoft Azure CLI 2.0^[[39;00m
-^[[38;5;246;03m# Command-line tools for Azure^[[39;00m
+ cheat.sheets:az
+^[[38;5;248;03m# Microsoft Azure CLI 2.0^[[39;00m
+^[[38;5;248;03m# Command-line tools for Azure^[[39;00m

You'll notice the section_name "cheat.sheets:az" is no longer highlighted post-update. The following procedure worksforme. Note that the local server always provides colorized output, so FORCE_COLOR=1 does't do anything in that context.
## update tests
$ FORCE_COLOR=1 CHEATSH_UPDATE_TESTS_RESULTS=YES bash tests/run-tests.sh

## this will 100% pass
$ FORCE_COLOR=1 bash tests/run-tests.sh

## this will 100% pass
$ FORCE_COLOR=1 CHEATSH_TEST_STANDALONE=NO bash tests/run-tests.sh

## this will also 100% pass
$ CHEATSH_TEST_STANDALONE=NO bash tests/run-tests.sh

The best solutions is to either update tests/run-tests.sh to always use FORCE_COLOR or update the docs in tests/README.md and tests/run-tests.sh to this new discrepancy.

hmm... db5217aac2e67c1b1f9d8bf8bd4e044270dc17b1 didn't seem to do it for me

ugh. wrong venv.


PowerBI Service UI update

Module: 00
Lab/Demo: 08 - Perform Data Analysis in PowerBI. Exercise 1
Task: 02 through task 03
Step: task 2. 1-6 and Task 3 steps 9-11
Description of issue: the UI has changed and there is no option Get Data on the service side. Instead it has to be New -> Dataset etc.
Then in task 3 for powerBi datasets instead of Create this button is "Connect"

Duplicate


Add Replace from file to Replacement Editor

We have a replacement editor (press o then R in mitmproxy) that allows us to add replacement patterns for flows.
There's also a --replace-from-file cmdline option that gets the replacement text from a local file.
But this functionality can't be used from the replacement editor itself.

A user tried to enter the path to file in the Replacement text field: https://discourse.mitmproxy.org/t/emulate-charles-proxys-map-local/116

Is anyone currently working on this issue ? If no, may I work on this ?

@arjun23496 I don't think anyone is working so feel free to take it up, but before you start I think it'll be nice if you discuss your ideas with the dev team over at Slack.

Fixed by #2120


e2e: refactor RBD and CephFS template deployment model

e2e: refactor RBD and CephFS template deployment model

At present the RBD and CephFS deployment is really clumsy and have
code deplication and difficulty to follow. This patch try to group the
tasks together in more modular fashion and make it flexible to
extend the same model for both deployment.

This introduces a new interface called deployer with below methods:

        replaceNamespaceInTemplate(string) (string, error)
        runAction(string, string)
        runActionRookDelete(string, string)

These methods handle common tasks for the deployment process of RBD and
CephFS.The individual deployers are free to override the methods or extend
their own later.  For example:
                changeTemplateAndRunAction(string, string)

 is 'deployer' specific ( rbd, cephfs...etc) which   handle deployer specific cases.

Functions removed from both cephfs.go and rbd.go:
    createORDeleteRbdResources()

NOTE FOR REVIEWER:
Commit has to be split
Updates:  https://github.com/ceph/ceph-csi/issues/2178
Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>

@nixpanic just started to prototype it and was about to mark WIP , but you were too fast to get in here :)

Ok.. Looks like a promising run :) , the failure is on etcd timeout:
Jun 17 11:22:40.477: INFO: Running '/usr/bin/kubectl --server=https://<IP_ADDRESS>:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-7a476401 create --namespace=cephcsi-e2e-7a476401 -f -'

Jun 17 11:22:47.896: INFO: rc: 1

Jun 17 11:22:47.896: FAIL: failed to create vault configmap error running /usr/bin/kubectl --server=https://<IP_ADDRESS>:8443 --kubeconfig=/root/.kube/config --namespace=cephcsi-e2e-7a476401 create --namespace=cephcsi-e2e-7a476401 -f -:

Command stdout:

stderr:

Error from server: error when creating "STDIN": etcdserver: request timed out

error:

exit status 1

/retest ci/centos/upgrade-tests-rbd

/retest all

/retest ci/centos/mini-e2e/k8s-1.19

The failure is : failed to create PVC with error etcdserver: request timed out

@nixpanic @Madhu-1  can you take a look at this ? would like to continue refactoring the E2E code, so the ping.

/retest all

/retest all

@Madhu-1 comments are addressed, ptal , Thanks .

/retest ci/centos/mini-e2e/k8s-1.20

@Madhu-1 @nixpanic can you please take a look at this?

Can I get some review here please ?  its around 3 weeks now, so the ping,

still vault-related are not making use of this interface?

Vault deployment can be handled in  a follow up PR. I will mark it in todo list.

except for #2180 (comment) everything LGTM. this can be enhanced later

Thanks :+1: , let me get rid of rook method quickly so that no concern :)

/retest all

except for #2180 (comment) everything LGTM. this can be enhanced later

Thanks +1 , let me get rid of rook method quickly so that no concern :)

@madhu-1 took out rook specific method, and tests are passing... ptal. Thanks !

@humblec static checks are failing

@humblec static checks are failing

Looks spurious

npm ERR! code E403
npm ERR! 403 403 Forbidden - GET https://registry.npmjs.org/@commitlint%2fcli
npm ERR! 403 In most cases, you or one of your dependencies are requesting
npm ERR! 403 a package version that is forbidden by your security policy.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-07-06T10_01_28_476Z-debug.log
The command '/bin/sh -c source /build.env     && dnf -y install 	git 	make 	golang 	gcc 	librados-devel 	librbd-devel 	rubygems 	ShellCheck 	yamllint 	npm 	diffutils       python3-prettytable       pylint     && dnf -y update     && dnf -y clean all     && gem install mdl     && curl -sf "https://install.goreleaser.com/github.com/golangci/golangci-lint.sh"        | bash -s -- -b ${GOPATH}/bin "${GOLANGCI_VERSION}"     && curl -sfL "https://raw.githubusercontent.com/securego/gosec/master/install.sh"        | sh -s -- -b $GOPATH/bin "${GOSEC_VERSION}"     && curl -L https://git.io/get_helm.sh | bash -s -- --version "${HELM_VERSION}"     && mkdir /opt/commitlint && pushd /opt/commitlint     && npm init -y     && npm install @commitlint/cli     && popd     && true' returned a non-zero code: 1
make: *** [Makefile:207: .test-container-id] Error 1

Error: Process completed with exit code 2.

@Madhu-1 I reran it and static checks pass now.. The previous iteration looked spurious failure.

/retest all

/retest all

Considering this is on e2e and deployment  and been out for  review for 3 weeks, can we add ready-to-merge?

As mentioned over chat, there are several things that I would like to see improved. My previous comment might not have been clear enough, sorry.

no need for multiple deploy types
templates in the rbdDeploy and cephfsDeploy is not a useful list of filenames to templates, as the changeTemplateAndRunAction compares the item with the path?! There should be no need to compare paths if the list of templates is expected to be adaptable, as that always requires changes in the list and the function
the helper functions for the deploy type do not use anything from the deploy struct, they can be just stand-alone helper functions
a possible extension to deploy Vault should definitely not require adding yet an other deploy type, a single deploy type that can apply templates in different ways (or 'stages' as I called them above) would make things so much simpler to use

In general, refactoring should make the code easier to understand and better to maintain. This current PR increases the line-count and adds obfuscation (by having the filenames of the templates 2x). IMHO this does not contribute to better maintainability of the e2e tests.

As mentioned over chat, there are several things that I would like to see improved. My previous comment might not have been clear enough, sorry.

....
As mentioned over the chat I am making my view here:
*)  The changeTemplateandRunAction was in common deployer interface which has been taken out as per the review comment (https://github.com/ceph/ceph-csi/pull/2180#discussion_r658485887), so , kept inside the deployer specific paths,
*) The current model of embedding interface make use of common mehods whereever possible even from seperate deployers, so no code duplication..
*) deploy is a placeholder for operating on the templates and will be transitioning to method receiver  as mentioned over previous comments
*) The logic of 'some' templates are  different  ( for example : provisioner) for rbd and cephfs.
*) Also, as noted in the issue tracker, ideally the deployment of templates has to make use of builtin methods like  `f,load/create/manifests..etc eventually which is totally different route altogther.
Obviously we can squash the phases of optimization in one attempt or go with different model altogether, or have intermediate phases without much disturbances to the code structure we have. The latter is the attempt here, if we want to go with former one, it is possible too and it looks like thats what the request here.
AI : /hold this PR

fwiw, #2270 is an example that re-models the KMS configuration so that it becomes more modular. Functions use an interface as parameter, and use the methods of the structs to call the implementation. This allows for simple addition of new objects with different properties for the different KMS backends. It prevents switch/cases for each object.
I hope that the example is clear, and you can use a similar approach for deploying templates with different requirements.


448 add all day label to the calendar

Proposed changes
Added "All Day" label to the week/day's view first row on the left.

Checklist

[x] Are the issues being addressed linked to this PR?
[x] Do all commit messages start with the issue number?
[x] Are all code changes sufficiently tested?
[x] Are there screenshots for UI changes?

@wendyyng If we want to change all day in the screenshot that you sent(agenda's view), we should release new issues because those codes do not relate to all day in agenda's view. The code belongs to week/day's view.

changes display as expected on my machine. I agree with @wendyyng 's suggestion re: capitalizing the "all day" text in the agenda view as well.


Paso Robles, CA

To:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: +++Insert Uniquie Subject Line+++
Message:
Dear Mayor Steven Martin and City Council,
My name is [YOUR NAME] and I am a resident of Paso Robles. I am writing to demand that the Paso Robles City Council adopt a city budget that prioritizes community well-being, and redirects funding away from the police.
In 2019, the City of Paso Robles allocated $10,759,000  dollars to our police system, an inordinate 28% of our total budget. This is compared to just 18% of the budget, $6,598,900, allocated towards community development, with only no money towards affordable housing development. Next year, the city estimates that there will be deficits as a result of the pandemic. The city may recoup these funds by decreasing the police budget.
I demand that the City Council begin meaningfully defunding the Paso Robles Police Department and re-allocate those funds to programs proven to more effectively promote a safe and equitable community. We need funding for community-based mental health services, substance abuse treatment services, affordable housing programs, not police. I demand a budget that reflects the actual needs of Paso Roble residents.
History has shown that police “reform” is not enough. No more money, and more importantly, no more lives must be lost to police. We must take a hard look at the way the current system in place fails to serve-and in fact actively harms-our community, and come together to reimagine the role of police in our city.
I am urging you to completely revise the budget for the 2020-2021 fiscal year, and to invest in the people, not the police.
Thank you for your time,
[YOUR NAME] [YOUR ADDRESS] [YOUR EMAIL] [YOUR PHONE NUMBER]

Thank you for submitting your city to defund12.org! Your request is now in the queue for review and publishing. We’ll reply here if we have any questions.


Logging File log empty

package.json -> depedencies:
...
"@sap-cloud-sdk/util": "^2.11.0",
...
logger.js
const {
    unmuteLogger, createLogger, setGlobalTransports, setGlobalLogLevel,
} = require('@sap-cloud-sdk/util');
const { transports, format } = require('winston');

const consoleFormat = {
    format: format.combine(
        format.splat(),
        format.simple(),
        format.errors({ stack: true }),
    ),
    level: 'info',
    handleExceptions: true,
    json: false,
    colorize: true,
};
setGlobalLogLevel('info');
setGlobalTransports(
    new transports.File({
        name: 'info-file',
        filename: './logs/exceptions.log',
        level: 'info',
        json: false,
    }),
    new transports.Console(consoleFormat),
);
const logger = ({ name }) => createLogger(name);
module.exports = logger;

server.js
`
const myLogger = require('./logger')({ name: 'server' });
...
myLogger.info('ok5');
...
`
file log empty

Hello @luizcarlospedrosogomes,
I had a quick and compared to our test case for the logger. I experienced the behaviour, that I needed to create the logger before I set the global transport. Could you perhaps change the order in your code so that the createLogger is called before the setGlobalTransports and setGlobalLogLevel.
I guess these methods only effect existing logger. Let me know if this helps.
Best
Frank

Good morning @luizcarlospedrosogomes,
I think the order is still set before creation. As you wrap the createLogger() in an arrow function the logger is created in line 20 of the server.js whereas the setGlobalTransports is executed by the require which loads the whole file. Can you try in line 9 of the logger.js to write the function like:
const logger = ({name}=>{
   const myLogger = createLogger(name);
   setGlobalTransports(fileTransport);
   return myLogger
}

Best
Frank

Good morning @FrankEssenberger
Sorry for the delay, I followed your suggestion but I got another error

`const fileTransport = new transports.File({
filename: 'test.log',
level: 'info',
});
const logger = ({ name }) => {
const myLogger = createLogger(name);
setGlobalTransports(fileTransport);
return myLogger;
};
module.exports = logger;
error ![image](https://user-images.githubusercontent.com/9791364/206082569-7a3d1761-3edd-4072-84db-53a8c041264f.png)><EMAIL_ADDRESS>start

cds run

[cds] - loading server from { file: 'srv/server.js' }
(node:796) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)
(node:796) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 unpipe listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:796) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 drain listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:796) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:796) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [File]. Use emitter.setMaxListeners() to increase limit
[ERROR] write after end
at writeAfterEnd (/workspace/node_modules/readable-stream/lib/_stream_writable.js:261:12)
at PassThrough.Writable.write (/workspace/node_modules/readable-stream/lib/_stream_writable.js:305:21)
at File.log (/workspace/node_modules/winston/lib/winston/transports/file.js:185:34)
at File._write (/workspace/node_modules/winston-transport/index.js:82:19)
at doWrite (/workspace/node_modules/readable-stream/lib/_stream_writable.js:409:139)
at writeOrBuffer (/workspace/node_modules/readable-stream/lib/_stream_writable.js:398:5)
at File.Writable.write (/workspace/node_modules/readable-stream/lib/_stream_writable.js:307:11)
at DerivedLogger.ondata (/workspace/node_modules/readable-stream/lib/_stream_readable.js:681:20)
at DerivedLogger.emit (node:events:513:28)
at addChunk (/workspace/node_modules/readable-stream/lib/_stream_readable.js:298:12)
`
I haven't had time to investigate the error yet but I thought it was important to give you some feedback

server.js
`
const { transports } = require('winston');
const { createLogger, setGlobalTransports } = require('@sap-cloud-sdk/util');
...
const fileTransport = new transports.File({
filename: 'test.log',
level: 'info',
});
setGlobalTransports(fileTransport);
const myLogger = createLogger('server');
...
`
log on start
[cds] - loading server from { file: 'srv/server.js' } [2022-12-08T13:56:24.495Z] INFO     (server): CDS API Boostrap from /srv/server.js (node:2744) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 unpipe listeners added to [File]. Use emitter.setMaxListeners() to increase limit (Usenode --trace-warnings ...` to show where the warning was created)
(node:2744) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:2744) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 drain listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:2744) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [File]. Use emitter.setMaxListeners() to increase limit
(node:2744) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [File]. Use emitter.setMaxListeners() to increase limit
[cov2ap] - [HPM] Proxy created: /  -> http://localhost:4004
[cov2ap] - [HPM] Proxy rewrite rule created: "^/v2" ~> ""
[cov2ap] - [HPM] Proxy created: /  -> http://localhost:4004
[cov2ap] - [HPM] Proxy rewrite rule created: "^/v2" ~> ""
[cds] - loaded model from 6 file(s):
db/schema.cds
srv/index.cds
db/data/model.cds
srv/src/models/solicitation-service.cds
db/data/views.cds
db/data/views_expand.cds
`
test.log
[2022-12-08T13:56:14.701Z] INFO     (server): CDS API Boostrap from /srv/server.js
That way, despite the log indicating the need for some intention, it worked, but now how to make it work in isolation?

https://github.com/winstonjs/winston/issues/1573#issuecomment-880833813
I followed this comment fully, implemented the code that is as an example. It worked I have the log files too. But the sap package, this package, was left out.

hm, I do not know. This is issue is strange and I can not reproduce it. I think there must be some problem with calling things by reference creating shallow copies if you adjust a logger after creation. This is what we do when calling setGlobalTransports. In the example  the logger is created correctly right away. Perhaps you can try putting everything inside the function scope:
export const loggerBuilder = (name: string): Logger => {
  const myLogger = createLogger(name);
  const fileTransport = new transports.File({
    filename: 'test.log',
    level: 'info'
  });
  setGlobalTransports(fileTransport);
  return myLogger;
};

If this also does not help I, I would perhaps use the code sample you found. @marikaner do you have an idea on this issue?
Best
Frank

@luizcarlospedrosogomes, it has been a long time since this issue was discussed. Were you able to solve or work around it since then?

It was implemented as per the guidance, I didn't return to the scenario again.
I must return soon


Create process to publish on dev.to under the Meilisearch organization

@Luna-meili created a process on Google docs(private link). We need to make it public on GitHub


Deploy Platform script. Minio Gateway Tweaks.

Updated the platform directory to properly deploy the platform with one command.
Edited Minio gateway to be more generic to work with google cloud in the future.

Just added in kdp and platform chart changes. Google credentials json file is now only created and volume mounted on deployment if minio gateway is gcs. Renamed some values for better clarity as well.

Update the description on this to omit the redis work, as this is now merged into the main platform.

Merged in under a different PR


Bootstrap v4

I am using this with v4 alpha, works perfectly. Would be good to update the examples etc. Thanks for this lib, really nice.

v4 is still in alpha right? As soon as it goes into beta, i'll update things :smile:


Remove handling of RejectedExecutionException

Codecov Report

Merging #5648 into reliable_table_copy will decrease coverage by 0.03%.
The diff coverage is 100%.

@@                    Coverage Diff                    @@
##             reliable_table_copy    #5648      +/-   ##
=========================================================
- Coverage                  82.92%   82.89%   -0.04%
+ Complexity                 11775    11768       -7
=========================================================
  Files                       1388     1388
  Lines                      45070    45065       -5
  Branches                    5606     5605       -1
=========================================================
- Hits                       37375    37357      -18
- Misses                      5119     5121       +2
- Partials                    2576     2587      +11

Impacted Files
Coverage Δ
Complexity Δ

.../projectors/BatchIteratorBackpressureExecutor.java
94.44% <100%> (+3.53%)
21 <0> (-1)
:arrow_down:

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
80% <0%> (-20%)
2% <0%> (ø)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...ration/reference/doc/lucene/IpColumnReference.java
72.72% <0%> (-13.64%)
5% <0%> (ø)

...a/io/crate/operation/join/NestedLoopOperation.java
82.85% <0%> (-11.43%)
14% <0%> (-1%)

...ava/io/crate/data/CloseAssertingBatchIterator.java
71.42% <0%> (-10.72%)
9% <0%> (-1%)

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-10.53%)
2% <0%> (ø)

...n/java/io/crate/planner/projection/Projection.java
90% <0%> (-10%)
6% <0%> (-1%)

...crate/planner/projection/MergeCountProjection.java
63.63% <0%> (-9.1%)
5% <0%> (-1%)

...src/main/java/io/crate/jobs/NestedLoopContext.java
66.66% <0%> (-5.56%)
7% <0%> (-1%)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8334551...0e00a0b. Read the comment docs.


[[TEST]] Test escaped regex char ranges

Include test to ensure lexer/parser can handle escaped character ranges \[\]. Improves test coverage of lexer.

Coverage increased (+0.05%) to 94.8% when pulling 2554c0ba1c6290e75814437098d233e42156053c on leebyron:regexptest into 083ca4b58d63dd3d01e2ff72d3ec5070a7f89671 on jshint:master.


[DRAFT]: Program cache index v2

Ah sorry, did not realize you were dependent on the branch. It is merged into monorepo now, so you can reopen against that.


how to add a robot

This is a very good repo, but I don't have any idea on how to add a robot.
I'm a newbie to this, can anyone help.
THANKS in advance

source this file to your workspace then launch it.


Pass -Ddisable_quic to crystal build

Don't enable QUIC by default.
This change allows using invidious with postgres 14 and above

LGTM :+1:
Thanks!


Adds wideswing to xenos.

About the PR

xenos now have a wideswing attack!
Why / Balance

indiscriminate munchins
-fix #1205
Technical details

if you set the altDisarm component to false it does this. not sure if it's possible to keep disarm and wideswing. someone smart with C# could make it a toggle, maybe?
Media

https://discord.com/channels/1168210010233376858/1168210011823026270/1229610857558966333

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

Xenos now have a wideswing attack.

I think we're going to have spacebar bound to wind swing for xenos