Simplify customization

Resolves #438
Resolves #409
Impact: breaking
Type: feature
Various changes based on audits and feedback about difficulties running, building, and customizing.
Changes

Moved .yarnrc to .reaction/yarnrc-docker.template and updated the Dockerfile to copy it in. This matches how it's done in component-library and fixes the fact that the yarn config prevents yarn from working outside of Docker.
Other changes to Dockerfile to match the one in component-library
Move analytics from /config to /src/custom
Move next.config.js into /src.
Fix NextJS build config so that all of the manual steps are no longer needed.
Run the dev server with normal node rather than babel-node. babel-node was unnecessary and slower.
Update to latest @reactioncommerce/components-context
Add jest-styled-components for tests. This updated all of the snapshots so that styles are also snapshotted.
Move setupTests.js from /src to /tests/
Add envalid and update everything that uses process.env so that is uses config that is run through envalid for validation and transformation first.
Remove remaining Keycloak code that was never used
Remove some properties of the AuthStore that are no longer used
Move reactionTheme.js and componentTheme.js to /src/custom
Move the components context file from /src/lib/theme/components.js to /src/custom/componentsContext.js
Move route definition to a new defineRoutes function in /src/custom/routes.js
Clean up the default logger object a bit
Remove unused appConfig from MobX UIStore
Move pagination functions from helpers to utils and get rid of helpers folder
Remove unused props from serverRuntimeConfig and publicRuntimeConfig
Fix errors on the _error page
Move all auth-related server setup out of server.js to a new serverAuth.js
Server now listens on PORT env variable, which defaults to 4000 if not set, rather than being hard-coded to 4000.
Remove the request NPM package and use fetch instead in the two places where request was used. This removes a large dependency that was unnecessary since fetch is already available.
Fix #409

Breaking changes
Because some of the build steps and file locations, and the way env variables are handled, have changed, this may break custom scripts or tools. In general the defaults here should be much simpler now.
If you have server code that was relying on the fact that babel-node was transpiling it, you'll need to update it to syntax that is compatible with Node 10.
As long as you double-check .env and rebuild your development Docker image, you should be alright. If you have problems trying to run for development, you might also want to remove all of the local Docker volumes used by this project.
Testing

Verify all major aspects of the app continue to work correctly when running in dev mode (docker-compose up -d --build)
Verify that you can build for production (see instructions in readme)
Verify all major aspects of the app continue to work correctly when running the production Docker image you built.
In particular, test logging in and out.
Run without env variables set and verify that you get helpful errors on startup now.

@samkelleher If you have a few minutes, I'd like your feedback on whether these changes help to resolve some of your pain points. There will be additional PRs coming for better separation of pages/data/routing from page presentation and better isolation of all things Stripe for removal.
As you mentioned elsewhere, it's not possible to fully separate customized code from code that likely won't be customized, but the aim of this PR is to at least be a little smarter about that separation to avoid conflicts and confusion when possible.

I like the improvements @aldeed, did you use my fork for reference as have made many of the same changes.
👍🏻 Consolidation of src outside the src directory (like the analytics)
👍🏻 The .yarnrc file being moved
👍🏻 Removal of unused code like keycloak
That said I evolved the babel-node usage rather than remove it so we can write the same node features (namely ES6 modules) in all files (so webpack, server, and browser scripts).
But overall a great good housekeeping and consolidation PR.

Note for anyone looking at this: I did need to remove my volumes (docker system prune --volumes) in order to get this started correctly.

@samkelleher Yes, I reviewed and borrowed some of your changes from the fork. Thanks! We decided to veer from your approach on babel-node for server code (1) because nearly all ES6 is already supported other than modules and (2) because there is very little server code in this project anyway.
You may be aware, but you could also enable module support in pure node v10 with --experimental-modules flag, though it requires changing all extensions to .mjs. More details here and here

I updated the description with better instructions on which specific volumes to remove.

You may be aware, but you could also enable module support in pure node v10 with --experimental-modules flag, though it requires changing all extensions to .mjs.

This is true in general, but in practice there are things you can do to work around it. Such as including a loader like in their example in the node docs:
NODE_OPTIONS='--experimental-modules --loader ./custom-loader.mjs' node x.js

I did actually try the --experimental-modules flag in attempt to avoid the babel-node situation. Discussed it internally and based upon it remaining experimental till at least April (after golive) didn't seem worth the risk given our tight timetable.
In my technical experimentation however, it did not like destructured imports, which are used extensively import { this } from "that". So eventually I gave up after spending and went with babel-node just for time wise.


train a new model

For different datasets, how can you retrain a new model using VideoMamba?

Check the scripts used for COIN~


mydumper: init at 0.9.3

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I have rebased and squashed your commits (usually a new package would be one commit, any fixup commits should be squashed).
Thank you!


NJ Onboarding Operations

The following items, generally in order, must be completed to successfully onboard a receiver to ReportStream:

[ ] Added to organization.yml
[ ] Added to organizations-local.yml
[ ] Added to staging settings table
[ ] Added to prod settings table
[ ] Added at least one receiver
[ ] Added OKTA group to download site
[ ] Added customers to OKTA group for download site
[ ] Is customer contact made?
What doc format are we supporting for the receiver (HLV, CSV, other)? (Add comment below)
What transport(s) are we supporting for the receiver (SFTP, other)? (Add comment below)
[ ]  Got credentials?
[ ] Tested ELR connection locally?
[ ] Tested ELR connection from Azure?
[ ] Has the receiver accessed the download site?
[ ] Has the receiver been sent at least one test file?
[ ] Has the receiver signed off on file formatting?
[ ] Are there labs sending data?
[ ] Has the receiver confirmed receipt of the data?
[ ] Have the files processed successfully?
[ ] Are we in production?

Summary of next steps -

Begin testing your HL7 messages generated from your system, using the message validation resources listed in the on-boarding manual. Please be sure to read the on-boarding manual and the NJ Implementation Guide thoroughly (https://cdrs.doh.state.nj.us/cdrss/common/cdrssELREnrollment ) as these detail all steps involved with creating a successful interface with the NJDOH.

Please set up your SFTP connection with NJDOH by sending an email to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>. Please include your organization/lab/hospital name in the subject line with the phrase "SFTP connection for ELR".

After completing steps 1 and 2, send an email to<EMAIL_ADDRESS>to start phase 1 of testing. Please remember to include your organization/lab/hospital name in the subject line for all communications with the ELR group.


[QoL] Export to AppleWin's Debugger

AppleWin has several debugger commands to allow the debugger to mark up data instead of interpreting it as code. Ideally we could export the disassembly as a plain-text file to be fed into the debbugger.
There are 3 sections of the export:

Raw text dump. addr: byte1 byte2 byte3 ...
Symbol names. sym <Name> = <Addr>
Data regions (tells the debugger to not interpret as code but display as inline data)

Raw bytes: db <name> <addr>
Raw pointers: da <addr>
TEXT. ASC <start>:<end>
Sprites -- I have the foundation of this in AppleWin but it is still incomplete.

AppleWin's TODO:

Need to look into how well .ORG $#### is supported in the debugger.
pseudo-directives starting with period need to be ignored on the command line
Need to add support to the debugger command line to ignore text past the semi-colon.  (Should have never used the C++ // double forward slash comment and used the proper  ; assembly comment from the beginning.)

There are currently 3 export options (HTML, text, CSV), in addition to the cross-assembler code generation.  I was expecting to add a symbol export at some point.  Hadn't thought about providing type info.
Seems like you want a list of {address,label} pairs, and then a list of {start,length,type} tuples if you want to define what's code vs. raw data vs. text vs. graphics.

The list of 2D and 3D tuples would be a great start!
I assume I'll have to munge the data to be script-ready but tweaking is to be expected.

Migrating feature requests to wiki.


" " <= Spaces can be in the path.

"absolute start" does not work when " " in absolute path.
$ ./absolute start
./absolute: line 8: cd: too many arguments
$ pwd
/c/Users/CHANGSU LEE/work/absolute

@cs-lee, , I'm closing this issue, you can re-open it if you want.


Attribute colour to spool instead of filament section

Hello,
I just started using Spoolman and it's great!
But to my mind it would make more sense to attribute the colour of a filament to the spool instead of to the filament. My assumption is that the print parameters are mainly related to the filament type of a certain manufacturer and only in rare cases to the colour of the filament. So to me it would make more sense to define the parameters of the filament like PLA +, PLA matte, PLA silk with no link to the colour and then be able to define the relevant colour if I put a new spool in my inventory.
Just my 2 cents....

It depends how you work with it. For me it's good to have these as part of the filament definition. But a compromise could be, to inherit it from the filament. So the spool inherits the color value from the filament definition and can be overwritten with in the spool properties. This would enable both approaches.

You're the boss, but from my point of view that would indeed cover both use-cases, so having the option to override the color setting would be great!

You're the boss

No, not me... that's @Donkie  😄

I too have recently started using spoolman and have an issue finding colors the way it is implemented right now. If the color alone was exposed as a column of the spool I could sort and find all my blues or whatever. Unless there is some way I havent figured out yet.


How to remove dropdown if I click outside?

yes please add this too in next update

Hey @Donaboyev @AyushTripathi28
Currently, this behaviour is already added. Dropdown overlay should close if you tap outside. Can you guys explain your issue more?

I just noticed that after 3.0 upgrade, but only does that in certain scenarios

@karniv00l
This not looks good. Can you please share the video so I can properly analyse whats happening...

Also on which platform you are using dropdown?

I'll try to write some example code when i have more time. Looks like it's platform independent (tested on macOS and Android). But as I mentioned, this is not present everywhere in my app, only in some parts

Ok, I found the issue
I'm currently using MediaQuery trick/hack to remove unnecessary left padding from ListTile and AppBar on mobile, and appears that this was causing the issue with the drop-down. I just needed to move the MediaQuery down the tree to make it work properly. Sorry for the confusion, this library is fantastic!

@karniv00l Ah, I see. No worries. Thanks for the appreciation :thumbsup:

@AyushTripathi28
You are calling this widget inside AppBar widget?

yes in app bar.
sorry for late reply .

I got it actually i put
canCloseOutsideBounds: false,
but it should be true for this functionality.

Hi, what if the dropdown is inside a modal which have a scaffold, and if i press anywhere outside the scaffold, the dropdown didnt close
untitled.webm


Breaking change in cargo_util 0.1.3, in semver-minor version!

Problem
ProcessBuilder::get_args returns an impl Iterator<Item = &OsString> now, whereas previously, it returned &[OsString].
This has the effect that non-locked builds of cargo-outdated and cargo-geiger fail (these crates are depending on cargo 1.61 or 1.60).

Apologies for that, we need to be more vigilant in handling versions around here.
I'll start the process of getting a version bump and yanking 0.1.3 of cargo-util.

I have yanked cargo-util 0.1.3 and cargo 0.63.0 and published new versions (0.2.0 and 0.63.1 respectively).
Please let me know if you have any issues.
Closing as fixed by #10806.

That fixes it, thanks!

Can confirm this resolves the problems :-)


GradientTape.gradient returning null

I am porting the Keras Actor Critic Method to Tensforflow.net and when I attempt to calculate the gradients it returns null.
using (var tape = tf.GradientTape())
{

    // ....

    // relevant code
    float loss_value = actor_losses_sum + critic_losses_sum;
    Tensor loss_value_tensor = tf.convert_to_tensor(loss_value);
    var grads = tape.gradient(loss_value_tensor, model.trainable_variables);
}

I have posted the full source code to reproduce the issue on this [Gist].(https://gist.github.com/alexhiggins732/320286f89e53c3bb3ae291f5979db1f3)
I have research and found several example saying tape.watch may need to be called but I have tried "watching" several tensors with no success.

Did you find any solution?

I am porting the Keras Actor Critic Method to Tensforflow.net and when I attempt to calculate the gradients it returns null.

Did you find any solution?

No.

Hey, I have encountered the same issue and wanted to show how I solved it for anybody that might end up here.
I encountered it while trying to port the Deep Deterministic Policy Gradient which is very related to what @alexhiggins732 has tried.
This is the python code from the Keras example:

which translated to this in Tensorflow.NET:

You need to take special care of the loss. Take a look of what happens to var y. This is because the shape was not the same as what the critic_model expected and so the critic_loss was ultimately of a bad size which resulted in a null gradient. In this particular case the y would not be known once the gradient is computed and this resulted in another Error once the code gets actually computed. This was solved with tape.watch(y).
Basically what you want to see is something like this where the shapes of the Tensors all align nicely:

There must be a bug here, the variable is not automatically captured. Is it possible to provide a minimal unit test that reproduces this behavior? It's easier for me to fix things that way.

Sure thing, here you go:
using Tensorflow;
using Tensorflow.Keras.Engine;
using static Tensorflow.Binding;
using static Tensorflow.KerasApi;
using Tensorflow.NumPy;

public Model get_actor(int num_states)
{
    var inputs = keras.layers.Input(new Shape(new int[] { num_states, }));
    var outputs = keras.layers.Dense(1, activation: keras.activations.Tanh).Apply(inputs);

    Model model = keras.Model(inputs, outputs);

    return model;
}

public Model get_critic(int num_states, int num_actions)
{
    // State as input
    var state_input = keras.layers.Input(new Shape(new int[] { num_states }));

    // Action as input
    var action_input = keras.layers.Input(new Shape(new int[] { num_actions }));

    var concat = keras.layers.Concatenate(axis: 1).Apply(new Tensors(state_input, action_input));

    var outputs = keras.layers.Dense(1).Apply(concat);

    Model model = keras.Model(new Tensors(state_input, action_input), outputs);
    model.summary();

    return model;
}

[TestMethod]
public void GetGradient_Test()
{
    var numStates = 3;
    var numActions = 1;
    var batchSize = 64;
    var gamma = 0.99f;

    var target_actor_model = get_actor(numStates);
    var target_critic_model = get_critic(numStates, numActions);
    var critic_model = get_critic(numStates, numActions);

    Tensor state_batch = tf.convert_to_tensor(np.zeros((batchSize, numStates)), TF_DataType.TF_FLOAT);
    Tensor action_batch = tf.convert_to_tensor(np.zeros((batchSize, numActions)), TF_DataType.TF_FLOAT);
    Tensor reward_batch = tf.convert_to_tensor(np.zeros((batchSize, 1)), TF_DataType.TF_FLOAT);
    Tensor next_state_batch = tf.convert_to_tensor(np.zeros((batchSize, numStates)), TF_DataType.TF_FLOAT);

    using (var tape = tf.GradientTape())
    {
        var target_actions = target_actor_model.Apply(next_state_batch, training: true);
        var target_critic_value = target_critic_model.Apply(new Tensors(new Tensor[] { next_state_batch, target_actions }), training: true);

        // this works
        // var y = reward_batch + target_critic_value;

        // this only works with tape.watch
        var y = reward_batch + tf.multiply(gamma, target_critic_value);
        //tape.watch(y);

        var critic_value = critic_model.Apply(new Tensors(new Tensor[] { state_batch, action_batch }), training: true);

        var critic_loss = math_ops.reduce_mean(math_ops.square(y - critic_value));

        var critic_grad = tape.gradient(critic_loss, critic_model.TrainableVariables);

        Assert.IsNotNull(critic_grad);
        Assert.IsNotNull(critic_grad.First());
    }

@LedStarr Thank you for your help and we have submit a fix for it. However we noticed that when running your test case, it throws an exception when getting the gradient instead of returning null, as described in this issue. Is it the same with your local environment?

@AsakusaRinne yes, sorry for the confusion, I should have pointed that out a bit more. I do get the Exception in my environment as well.
Here is the test case for the original problem pointed out by @alexhiggins732
[TestMethod]
public void GetGradient_Test()
{
    var numStates = 3;
    var numActions = 1;
    var critic_model = get_critic(numStates, numActions);

    float constant_loss = 0.1f;

    using (var tape = tf.GradientTape())
    {
        var critic_loss = tf.convert_to_tensor(constant_loss);

        var critic_grad = tape.gradient(critic_loss, critic_model.TrainableVariables);

        Assert.IsNotNull(critic_grad);
        Assert.IsNotNull(critic_grad.First());
    }
}

@LedStarr Thank you a lot for your test case. I wrote it's python version and run it. However I found that in python it also get [None, None] as gradient. The critic_loss is a constant instead of the result of critic_model, I guess returning null in this case is  reasonable?
The python version code is here:
import tensorflow as tf

def get_critic(num_states, num_actions):
    state_input = tf.keras.layers.Input(num_states)
    action_input = tf.keras.layers.Input(num_actions)
    concat = tf.keras.layers.Concatenate(1)([state_input, action_input])
    outputs = tf.keras.layers.Dense(1)(concat)
    model = tf.keras.Model([state_input, action_input], outputs)
    model.summary()
    return model

if __name__ == '__main__':

    num_states = 3
    num_actions = 1
    loss_value = 0.1

    with tf.GradientTape() as tape:
        critic_model = get_critic(num_states, num_actions)
        critic_loss = tf.convert_to_tensor(loss_value)

        critic_grad = tape.gradient(critic_loss, critic_model.trainable_variables)
        print(critic_grad)

@AsakusaRinne hmm if this is the case then I also think this is reasonable. The critic_loss is a constant because I wanted to show that this is happening when you call tf.convert_to_tensor(loss_value) within the with statement of the tape. It should not be a constant in a regular scenario of course. I thought this problem only occurs when you create a tensor from a single float value within the tape sequence.
Anyways if the python code is returning a null here as well, then I don't consider it as a bug of tf.net :)

@LedStarr Thank you very much for your help in this issue! :)

The original tensorflow code in python is:
loss_value = sum(actor_losses) + sum(critic_losses)
grads = tape.gradient(loss_value, model.trainable_variables)
optimizer.apply_gradients(zip(grads, model.trainable_variables))

The Keras Actor Critic does not return null.
What is the difference?

@alexhiggins732 it might be that the type is different. Can you compare the loss_value variable in both python and c# code?


Feature Request: No Background image option please...

I thought this was the app that already did it, but I guess not, or I can't find out how. Problem: When you have a webpage with a gradient background that does NOT scroll with the page, when you take a full page screenshot in "sections" ...you end up with a repeating background that goes from dark to light, to dark, to light, to dark, to light...over and over again, and it looks crappy. Most sites with this type of background have a general single color underneath the background image as a fall-back, and that is the desireable way to capture the full page on this type of thing...I had something that did it once, but can't find what I did them with.

  (ref: https://worship101.org  for one example)

Hey @everything-it — I think this particular issue is out of the scope of the extension. I’ll keep it in mind for future advanced features, but some advanced functionality around scrolling and other issues like that are currently the priority. I would recommend in this kind of scenario—if you’re comfortable with HTML/CSS—to just edit the page manually in Inspector before capturing it.


Add a Gitter chat badge to README.md

craftyjs/Crafty now has a Chat Room on Gitter
@kevinsimper has just created a chat room. You can visit it here: https://gitter.im/craftyjs/Crafty.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

@starwed @kevinsimper
Should we give support via gitter? It's a neat platform for instant communication, plus it also archives all conversations. On the other hand we already have google group forum, should we really split up the information even more across different platforms (remember we also have to check stackoverflow for crafty related content)?


No longer launches with newest Serene Seasons 1.16.5

an update to Serene Seasons was published a few days ago, and the dependency.json will not permit the patch to load.  please change the json to assume future versions are working as 1.16.5 support has been dropped beyond crash and bug fixes.
the new version: <IP_ADDRESS>
this mod version: 1.0.4
error message: "serene seasons fix is incompatible with serene seasons.  please use <IP_ADDRESS> or below."

Just uploaded a fix to that, should accept all revisions above 125.
Will upload soon similar fix for 1.18 and 1.17.


[Service Bus] TypeError: Cannot read property 'maxMessageSize' of undefined

Package Name: @azure/service-bus
Package Version: 7.0.5
Operating system:debian
[ ] nodejs

version: 14.15.4

[ ] browser

name/version:

[ ] typescript

version

Describe the bug
when i used sender.sendMessages encount this exception.I had set retryPolicy
{
maxRetries: 20,
retryDelayInMs: 500,
maxRetryDelayInMs:10000,
mode:RetryMode.Exponential
};
i did nothing,sender came to be noraml and sendMessages successed after 2 seconds,
call stack:
dispatchTask error TypeError: Cannot read property 'maxMessageSize' of undefined
at MessageSender. (/usr/local/src/ddcloudProxy/src/node_modules/@azure/service-bus/dist/index.js:8916:30)
at Generator.next ()
at fulfilled (/usr/local/src/ddcloudProxy/src/node_modules/@azure/service-bus/node_modules/tslib/tslib.js:114:62)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:93:5).

Hello @winterAndvelvet , we've released a new version of the Service Bus package with this fix<EMAIL_ADDRESS>

Hello @winterAndvelvet , we've released a new version of the Service Bus package with this fix<EMAIL_ADDRESS>
thank you


fix Android and Tizen Location error #581

Fixed OnTouch e.Location error if IgnorePixelScaling = true; in Android and Tizen

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] File:../externals/skia not existed.
[Error] Some error ocurred while parsing changelist file: W:\wk03-log-bb861770\change-list-with-redirection.mapped.tsv.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

build

Thanks for the PR. As soon as the build completes, I'll merge.

build


X509_sign fails when building with address sanitizer on FreeBSD

I have a problem with the function int ret = X509_sign(cert.get(), pkey.get(), EVP_sha256());  when using address sanitizer specifically on FreeBSD.
I'm building the code using:
clang++ -Wall -std=c++11 -g -fsanitize=address -fno-omit-frame-pointer  main.cpp -lcrypto -o main
or
clang++ -Wall -std=c++11 -g main.cpp -lcrypto -o main.
If tested the code on the following systems:
Ubuntu 22.04.4 LTS - OpenSSL 3.0.2 15 Mar 2022
-> building without address sanitizer: WORKS
-> building with address sanitizer: WORKS
FreeBSD 14.0-RELEASE - OpenSSL 3.0.12 24 Oct 2023
-> building without address sanitizer: WORKS
-> building with address sanitizer: building works but execution fails on given line
ONLY on FreeBSD with address sanitizer the code fail on execution.
Note: I am not getting any output from the address sanitizer, it seems like X509_sign is just failing.
Does anyone have any ideas for possible solutions?
Here is my code (just a sample method for creating/signing a certificate).
#include <memory>
#include <string>
#include <openssl/x509.h>
#include <openssl/rsa.h>
#include <openssl/evp.h>

#define RSA_KEY_LENGTH 2048

int main(int argc, char* argv[])
{
    std::string certFileName = "MyTestCert";
    std::string keyFileName = "MyKeyFile";
    long daysValid = 31;

    std::unique_ptr<BIO, void (*)(BIO *)> certFile  { BIO_new_file(certFileName.data(), "wb"), BIO_free_all  };
    std::unique_ptr<BIO, void (*)(BIO *)> keyFile { BIO_new_file(keyFileName.data(), "wb"), BIO_free_all };

    if (certFile && keyFile)
    {
        std::unique_ptr<RSA, void (*)(RSA *)> rsa { RSA_new(), RSA_free };
        std::unique_ptr<BIGNUM, void (*)(BIGNUM *)> bn { BN_new(), BN_free };

        BN_set_word(bn.get(), RSA_F4);
        int rsa_ok = RSA_generate_key_ex(rsa.get(), RSA_KEY_LENGTH, bn.get(), nullptr);

        if (rsa_ok == 1)
        {
            // --- cert generation ---
            std::unique_ptr<X509, void (*)(X509 *)> cert { X509_new(), X509_free };
            std::unique_ptr<EVP_PKEY, void (*)(EVP_PKEY *)> pkey { EVP_PKEY_new(), EVP_PKEY_free};

            // The RSA structure will be automatically freed when the EVP_PKEY structure is freed.
            EVP_PKEY_assign(pkey.get(), EVP_PKEY_RSA, reinterpret_cast<char*>(rsa.release()));
            ASN1_INTEGER_set(X509_get_serialNumber(cert.get()), 1); // serial number

            X509_gmtime_adj(X509_get_notBefore(cert.get()), 0); // now
            X509_gmtime_adj(X509_get_notAfter(cert.get()), daysValid * 24 * 3600); // accepts secs

            X509_set_pubkey(cert.get(), pkey.get());

            // 1 -- X509_NAME may disambig with wincrypt.h
            // 2 -- DO NO FREE the name internal pointer
            X509_name_st* name = X509_get_subject_name(cert.get());

            const unsigned char country[] = "RU";
            const unsigned char company[] = "MyCompany, PLC";
            const unsigned char common_name[] = "localhost";

            X509_NAME_add_entry_by_txt(name, "C",  MBSTRING_ASC, country, -1, -1, 0);
            X509_NAME_add_entry_by_txt(name, "O",  MBSTRING_ASC, company, -1, -1, 0);
            X509_NAME_add_entry_by_txt(name, "CN", MBSTRING_ASC, common_name, -1, -1, 0);

            X509_set_issuer_name(cert.get(), name);
            int ret = X509_sign(cert.get(), pkey.get(), EVP_sha256()); // some hash type here
            if(!ret)
            {
                printf("Error!!!\n");
            }
        }
    }

    return 0;
}

a few notes:

The above test case doesn't compile without the addition of several header files:
#include
#include
#include <openssl/x509.h>
#include <openssl/rsa.h>
#include <openssl/evp.h>

I don't have a freebsd system setup at the moment, can you post the tsan output that you get when running here please?

I started trading Crypto on Binary options, at first everything was going smoothly till I tried withdrawing. I was made to believe that I had to build my account to a certain point before withdrawing, I had lost total sum of 10.000btc. After weeks of turmoil and sadness that investment brought me and my family. I saw recommendations to
P E R F E C T R E C L A I M R E C O V E R I N G O N   I N S T A and i was lucky they helped me recover all of my funds without any hassle in less than 48 hours, I am so happy doing this because I know how many people would benefit from this useful information. Fortunately for me I was able to recover all i lost P E R F E C T R E C L A I M RECOVERY CONSULTANT is a real refund professional feel free to reach out to them for quick response if you’re having similar issues

I started trading Crypto on Binary options, at first everything was going smoothly till I tried withdrawing. I was made to believe that I had to build my account to a certain point before withdrawing, I had lost total sum of 10.000btc. After weeks of turmoil and sadness that investment brought me and my family. I saw recommendations to
P E R F E C T R E C L A I M R E C O V E R I N G O N   I N S T A and i was lucky they helped me recover all of my funds without any hassle in less than 48 hours, I am so happy doing this because I know how many people would benefit from this useful information. Fortunately for me I was able to recover all i lost P E R F E C T R E C L A I M RECOVERY CONSULTANT is a real refund professional feel free to reach out to them for quick response if you’re having similar issues

I started trading Crypto on Binary options, at first everything was going smoothly till I tried withdrawing. I was made to believe that I had to build my account to a certain point before withdrawing, I had lost total sum of 10.000btc. After weeks of turmoil and sadness that investment brought me and my family. I saw recommendations to
P E R F E C T R E C L A I M R E C O V E R I N G O N   I N S T A and i was lucky they helped me recover all of my funds without any hassle in less than 48 hours, I am so happy doing this because I know how many people would benefit from this useful information. Fortunately for me I was able to recover all i lost P E R F E C T R E C L A I M RECOVERY CONSULTANT is a real refund professional feel free to reach out to them for quick response if you’re having similar issues

1. The above test case doesn't compile without the addition of several header files:
#include
#include
#include <openssl/x509.h>
#include <openssl/rsa.h>
#include <openssl/evp.h>

Oh sorry, i have updated the code above

2. I don't have a freebsd system setup at the moment, can you post the tsan output that you get when running here please?

I get no tsan output at all. Neither when executing ./main nor from TSAN_OPTIONS="verbosity=2+" ./main
I compiled using "clang++ -Wall -std=c++11 -g -fsanitize=address -fno-omit-frame-pointer  main.cpp -lcrypto -o main".

building with address sanitizer: FAILS

Could you post the full commands you are running and the full output please?

building with address sanitizer: FAILS

Could you post the full commands you are running and the full output please?

If updated my original message and added the used build comments.
Here the full build output:
main.cpp:23:53: warning: 'RSA_new' is deprecated [-Wdeprecated-declarations]
        std::unique_ptr<RSA, void (*)(RSA *)> rsa { RSA_new(), RSA_free };
                                                    ^
/usr/include/openssl/rsa.h:201:1: note: 'RSA_new' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 RSA *RSA_new(void);
^
/usr/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
main.cpp:23:64: warning: 'RSA_free' is deprecated [-Wdeprecated-declarations]
        std::unique_ptr<RSA, void (*)(RSA *)> rsa { RSA_new(), RSA_free };
                                                               ^
/usr/include/openssl/rsa.h:293:1: note: 'RSA_free' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 void RSA_free(RSA *r);
^
/usr/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
main.cpp:27:22: warning: 'RSA_generate_key_ex' is deprecated [-Wdeprecated-declarations]
        int rsa_ok = RSA_generate_key_ex(rsa.get(), RSA_KEY_LENGTH, bn.get(), nullptr);
                     ^
/usr/include/openssl/rsa.h:260:1: note: 'RSA_generate_key_ex' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0 int RSA_generate_key_ex(RSA *rsa, int bits, BIGNUM *e,
^
/usr/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
main.cpp:36:13: warning: 'EVP_PKEY_assign' is deprecated [-Wdeprecated-declarations]
            EVP_PKEY_assign(pkey.get(), EVP_PKEY_RSA, reinterpret_cast<char*>(rsa.release()));
            ^
/usr/include/openssl/evp.h:1329:1: note: 'EVP_PKEY_assign' has been explicitly marked deprecated here
OSSL_DEPRECATEDIN_3_0
^
/usr/include/openssl/macros.h:182:49: note: expanded from macro 'OSSL_DEPRECATEDIN_3_0'
#   define OSSL_DEPRECATEDIN_3_0                OSSL_DEPRECATED(3.0)
                                                ^
/usr/include/openssl/macros.h:62:52: note: expanded from macro 'OSSL_DEPRECATED'
#     define OSSL_DEPRECATED(since) __attribute__((deprecated))
                                                   ^
4 warnings generated.

On execution i don't get any output, other than my "Error!!!" debug print when executing the code under bsd (with asan)

If updated my original message and added the used build comments.

How did you configure OpenSSL?

How did you configure OpenSSL?

I'm using the default configuration as deployed by bsd.
Which file is from relevance here? /etc/ssl/openssl.cnf?

I'm using the default configuration as deployed by bsd.

Ah, sorry, it's the system OpenSSL - I'd missed that.
If you run openssl version -f you should get most of the options that it was built with

If you run openssl version -f you should get most of the options that it was built with

openssl version -f returns compiler: clang
here the output from openssl version -a:
OpenSSL 3.0.12 24 Oct 2023 (Library: OpenSSL 3.0.12 24 Oct 2023)
built on: reproducible build, date unspecified
platform: FreeBSD-amd64
options:  bn(64,64)
compiler: clang
OPENSSLDIR: "/etc/ssl"
ENGINESDIR: "/usr/lib/engines-3"
MODULESDIR: "/usr/lib/ossl-modules"
Seeding source: os-specific
CPUINFO: OPENSSL_ia32cap=0x5eda2203478bffff:0x842529

Hi everyone,
I wanted to check in and ask if there have been any updates regarding this issue. There hasn't been any activity for some time, and I was wondering if there have been any updates or workarounds.

No, I'm afraid not.  I still don't have a freebsd system setup here, but are you able to step through X509_sign with gdb to see where the function is failing?

This may be related...
https://github.com/curl/curl/issues/15477

This is the same FreeBSD/NetBSD toolchain bug with SHA-2 interceptors as https://github.com/openssl/openssl/issues/25456, see also https://github.com/llvm/llvm-project/issues/110215. It will be fixed once these BSDs update to LLVM-19.

Thank you @botovq


Revert "Del kingnodes REST endpoint"

Reverts cosmos/chain-registry#1986
Hi @JeremyParish69.
Our rest endpoints are indeed REST endpoints. We use caddy to map the path to the cosmos API. There is nothing wrong with it other than we block some features. @staking-explorer should have messaged me rather than get our endpoints removed. Can you please revert this PR.

Apologies! I think we'll need to be more careful removing links in the future.

Thanks Jeremy.

@nullmames, @JeremyParish69 we are sorry. This is really REST. An interesting scheme that no one else uses. This approach allows you to make fewer mistakes at the URL\DNS, because the path to RPC and REST is the same. We are sorry.

People make mistakes sometimes. No problem. We were able to get it restored very quickly.


profiles/core: add comments for each option

closes #295

bors r+

Going to manually merge, CI is not currently working and this is just a docs change


Origin header is always sent from WebSocket client

Expected behavior
No 'Origin' header sent by default.
A way to set custom 'Origin' header when it is needed.
Actual behavior
'Origin' header is set.
'Origin' header is auto-resolved into meaningless value. In my case - IP of the intermediate proxy between client and server sides.
Enforced 'Origin' header leads to cors check failure on server side and denial of service for legitim client.
Steps to reproduce
Open WebSocket connection with v13 handshaker
WebSocketClientHandshaker13.newHandshakeRequest:

if (!headers.contains(HttpHeaderNames.ORIGIN)) {
    headers.set(HttpHeaderNames.ORIGIN, websocketOriginValue(wsURL));
}

Netty version
4.1.39
Related issues: PR #9312 and PR #9435.
JVM version (e.g. java -version)
1.8.0_223-b27
OS version (e.g. uname -a)

Windows 7 Enterprise
Linux gmafxu42 3.0.101-108.98-default #1 SMP Mon Jul 15 13:58:06 UTC 2019 (262a94d) x86_64 x86_64 x86_64 GNU/Linux

Hi, @ursaj. I agree that Origin and  Sec-WebSocket-Origin is not required according the spec https://tools.ietf.org/html/rfc6455#section-1.3 Origin/Sec-WebSocket-Origin header field is sent by browser clients; for non-browser clients, this header field may be sent if it makes sense in the context of those clients.  But i'm not sure can we just delete them. WDYT @normanmaurer @slandelle

I agree there's no way for an HTTP client to be able to infer Origin header and it can only be provided reliably by the user. IMHO, this is a bug, but fixing it would be a breaking change.
I say we should have an option to disable and deprecate sending Origin header for removal in Netty 5.

Actually it is already a breaking change between 4.1.31 and 4.1.39 - when 'Origin' header was forcibly injected. I'd spend quite a lot of effort to sort it out, when Singapore clients failed to connect to our backends during their upgrade. For me it was 4 a.m. on Sunday - quite an inconvenient time to solve such issues.
I'll better interpret it like a "temporary bug" and revert this behaviour to the one of 4.1.31.

@slandelle I agree with @ursaj ... we should fix it.  @ursaj can you do a pr ?

Sorry but I have to never this as this needs more thoughts.

Out of curiosity, what motivated the revert for this? I see "more thoughts" are cited but why? To me it seemed like the argument in this commit message was pretty compelling https://github.com/netty/netty/commit/19a46338595beba0ae3854a6346ec6f2ec73a0b9
For context, I ran into this bug when performing a minor upgrade, too.

This feels more wrong the more I look into it.
The current state, in which the bug fix is reverted, sets the Origin header to the target webSocketURL
That is flat out wrong.
HTTP Origin
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin

The Origin request header indicates where a fetch originates from

webSocketURL

URL for web socket communications. e.g "ws://myhost.com/mypath".
Subsequent web socket frames will be sent to this URL.

It seems that the bug was introduced to hack in a fix for CORS requests. The hack was a breaking change that truly makes no sense. If a user wants to spoof the origin by setting it to the target URL, then there's an API in place to do this.
Why would you break the library by making this the default behavior?

I agree with @tmsimont .Reasoning like "this needs more thoughts" feels really disappointing. To such extend that I've just lost my passion to discuss or contribute anything.
Adding something or removing something to project is ok. Even if its buggy. But double standards in change management feel disrespectful to contributors.
Just a thought.

I fully understand and I am really sorry about that. I am currently OOO but will try to pick this up again once back.

Am 17.07.2020 um 22:56 schrieb ursa<EMAIL_ADDRESS>
I agree with @tmsimont .Reasoning like "this needs more thoughts" feels really disappointing. To such extend that I've just lost my passion to discuss or contribute anything.
Adding something or removing something to project is ok. Even if its buggy. But double standards in change management feel disrespectful to contributors.
Just a thought.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.

Since everyone is busy allow me to review the history here...
It looks like this Origin header has had a rough history:

The ORIGIN used to be totally absent from all but v0 handshake... see https://github.com/netty/netty/commit/16be36a55fded330a92a4869e127b6b7249c6d13#diff-ffbbdb8352c6101b19ebd7c08d125bca

Initially, the only version of the handshake (v0) was allowing custom headers to override the Origin if set: https://github.com/netty/netty/blob/16be36a55fded330a92a4869e127b6b7249c6d13/codec-http/src/main/java/io/netty/handler/codec/http/websocketx/WebSocketClientHandshaker00.java#L139-L150)

Then a bug was introduced (still only v0)... ORIGIN always overrode custom headers (May 30, 2018) https://github.com/netty/netty/commit/48911e0b633da526f37fb4e5bdcddf3f97c091b5#diff-ffbbdb8352c6101b19ebd7c08d125bca

Then (July 12, 2019), the bug grew beyond v0 into v13 in a misguided attempt to fix a broken handshake in #9134
Before this, the Origin field was totally absent from requests unless set in custom headers, but Sec-WebSocket-Origin was present and for some odd reason was being set to the target, not the origin. This is wrong.
From https://tools.ietf.org/id/draft-ietf-hybi-thewebsocketprotocol-06.html#:~:text=The |Sec-WebSocket-Origin,API in a Web browser.&text=If the server does not,choose to abort the connection.

The |Sec-WebSocket-Origin| header is used to protect against unauthorized cross-origin use of a WebSocket server by scripts using the |WebSocket| API in a Web browser. The server is informed of the script origin generating the WebSocket connection request. If the server does not wish to accept connections from this origin, it can choose to abort the connection. This header is sent by browser clients, for non-browser clients this header may be sent if it makes sense in the context of those clients.

So, before #9134, we already had a bug in Sec-WebSocket-Origin and then the fix for #9134 extends that bug into Origin, which then breaks a lot more users, which leads to...

#9435
The previous "fix" has extended the bug into Origin from Sec-WebSocket-Origin. Not only is Origin now set incorrectly, but it also overrides any explicitly set Origin fields in custom headers. The fix for this is to allow Origin to be set in custom headers, and we only set the buggy and incorrect value if Origin is not already set. This is the fix in #9435 (August 10, 2019)

Now we finally arrive at #9673 -- this issue... As we pull in the Origin-forcing function, we break because the value being set makes no sense. @ursaj has a fix, which is don't set Origin incorrectly at all. This fixes the bug introduced in #9134, but now the problem is that #9134 is basically reopened because Origin is not going to be present automatically without being explicitly set into a custom header.

so to review...

Origin used to be missing from v13 handshaker and has a bumpy history in v0
Origin and Sec-WebSocket-Origin have always been set to the "Target" which is wrong...
Origin is now set incorrectly in v13, too, in addition to v0 but is not set in v7 nor v8
We can now at least set Origin into custom headers that won't be overridden which is nice
Users that depend on a value in Origin  probably are not setting it explicitly and allowing the default behavior, which is backwards.

I'm totally lost as to why it was ever thought to be correct to set Origin = targetUrl
Can anyone explain that one?


Terminal sticky scroll is showing for a single line empty prompt

Repro:

Open terminal
Ensure a single line pwsh prompt is used
Press enter to fill viewport, 🐛 the top line should not show sticky scroll as it just obscures the line underneath

Likely related, this is showing a 2 line sticky scroll but should not be:


Generic FieldItemListInterface and related stubs

Recent stub additions conflicted with some stubs in my website project so sharing here.
I have a lot of annotations like @property EntityReferenceFieldItemListInterface<UserInterface> $owner on custom entities so PHPStan knows the type of $entity->owner->entity and so on.
Happy to try and help split into smaller PRs and take direction on testing.
This is related to #353 and may also allow some extension code to go away?
Fixes https://github.com/mglaman/phpstan-drupal/issues/432

Ready to merge, I just want some other community feedback quick to forgo writing a bunch of tests right now.

tagging @brambaud and @dpi for review

Looks good to me!
Awesome 🤩

MERGING! I didn't put this in 1.1.22 as I wanted to ship some other fixes. But this will be in 1.1.23!


GitHub Actions fail

Have been failing at least since March 2024.

reopening as was fixed in main, not develop


microfab

Microfab is a containerized Hyperledger Fabric runtime for use in development environments
Signed-off-by: Matthew B White<EMAIL_ADDRESS>

Hello... just wanted to check what's the next step @ryjones / @tkuhrt  :-)

Hi, @mbwhite : From hyperledger-labs/governance select the transfer repo option. Then you should be able to transfer the repo to @ryjones to have it moved to the hyperledger-labs organization.

https://github.com/hyperledger-labs/governance/issues/15


chore: add non-interface modules to monorepo

Adds all supported non-interface modules to the monorepo.

@achingbrain @p-shahi : have we lost all the git history of these files (same goes with https://github.com/libp2p/js-libp2p/pull/1823 )?  Given the age of the codebase, it seems unfortunate to lose the history of how the code evolved.  With all the repo consolidation we did with Boxo, we maintained the commit history: https://github.com/ipfs/boxo/wiki/Copied-or-Migrated-Repos-FAQ#was-the-git-history-maintained-for-repos-that-were-copied-in .

Yeah it looks like this was missed, I believe history was maintained in the go-libp2p monorepo consolidation as well. If it's not too late to add it back, I would be in favor of that.
I would also like to transfer issues from archived repos into this one. I manually unarchived https://github.com/libp2p/js-libp2p-webrtc earlier today and migrated issues, it looks like not all have been archived yet though

I can add it back but it'll mean force pushing to master.  I hadn't done it because I previously did for the repo consolidation of js-ipfs but I don't think anyone ever actually went spelunking deep in the repo history so it didn't seem worth the effort involved but from an OSS point of view it's probably a good idea to preserve contributor history if nothing else.
The simplest way to do this is probably to push straight to master rather than go via a PR.

Your branch and 'origin/master' have diverged,
and have 3828 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

😱


Deprecate includeOptions, move it to include

The reasoning is that the current way of specifying options to include is not granular enough. The proposed solution:
{
  include: [ [ 'field1', 'field2', { ... } /* options last */ ] ]
}

It would technically be a breaking change but I'm not sure if anyone is using it yet.

Done in commit https://github.com/fortunejs/fortune/commit/7f506fb639e2c4543018bc9c95cb5f74459c01ec.


Create dataset loader for ASR-MALCSC: MALAY CONVERSATIONAL SPEECH CORPUS

Dataloader name: asr_malcsc/asr_malcsc.py
DataCatalogue: http://seacrowd.github.io/seacrowd-catalogue/card.html?asr_malcsc

Dataset
asr_malcsc

Description
This open-source dataset consists of 5 hours of transcribed Malay conversational speech on certain topics, where ten conversations between five pairs of speakers were contained.

Subsets
-

Languages
zlm

Tasks
Text-To-Speech Synthesis, Automatic Speech Recognition

License
Creative Commons Attribution Non Commercial No Derivatives 4.0 (cc-by-nc-nd-4.0)

Homepage
https://magichub.com/datasets/malay-conversational-speech-corpus/

HF URL
-

Paper URL
-

#self-assign


Comments on selectors

Breaking comments on selectors, see:
Before:
///
/// 1. Google Maps breaks if `max-width: 100%` acts upon it; use their selector
///    to remove the effects.
/// 2. If a `width` and/or `height` attribute have been explicitly defined, let’s
///    not make the image fluid.
///
.gm-style img, // 1
img[width], // 2
img[height] {  // 2
    max-width: none;
}

After:
///
/// 1. Google Maps breaks if `max-width: 100%` acts upon it; use their selector
///    to remove the effects.
/// 2. If a `width` and/or `height` attribute have been explicitly defined, let’s
///    not make the image fluid.
///
.gm-style img,
// 1
img[width],
// 2
img[height] {
    // 2
    max-width: none;
}

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/23963488-comments-on-selectors?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F214563&utm_medium=issues&utm_source=github).

Did you set space-after-selector-delimiter to true? Then this is exactly the expected behavior though it seems weird… Maybe I need to add an option to bypass comments.

Thanks for the reply, I ended up solving it through another solution.


"Page not found" error

a url such as: isaacphysics.org/events/anyrandomevent
gets a "Page not found" error
Is it possible to make any such url take one to the events page? I had thought that that was what would happen, or is it desirable to tell people that the url they've entered is not correct?

I am not sure if this is what you mean but I think if a user enters an invalid or incorrect url they should be told in the form of an error message (as this is the behaviour for the rest of the site).
Is it currently showing this message for a valid event id as well as invalid one - if so then this is a bug.

Closing as this seems to be behaving as expected.


Adds HTML Import support

Adds a unit test to cover basic HTML imports
Adds third party WebComponentsJs for unit testing HTML Imports
Relates to #1765

@arv PTAL, will squash when approved

@arv I've addressed your initial feedback. PTAL

One thing I noticed is that the imports need to be loaded in a certain order of dependency which I will address now.

@arv
I've addressed the HTMLImport order requirements and added a unit test for that.
Tidied up the tests.
Squashed back to one commit.
PTAL

just a note, I noticed that travis is passing even when there are failing tests in the testRunner.html.
other note, running make test on windows fails with:
./traceur --out bin/traceur-runtime.js<EMAIL_ADDRESS>\
   --script src/runtime/runtime.js  --script src/runtime/url.js  --script src/runtime/ModuleStore.js -- src/runtime/runtime-modules.js src/runtime/polyfills/Map.js src/runtime/polyfills/Set.js src/runtime/polyfills/Promise.js src/runtime/polyfills/String.js src/run
time/polyfills/Array.js src/runtime/polyfills/Object.js src/runtime/polyfills/Number.js src/runtime/polyfills/Math.js src/runtime/polyfills/polyfills.js
./tval test/traceurTests.js
Error: Error: File not found 'D:\modular\testRunner.js'
Specified as ./modular/testRunner.js.
Imported by D:\dev\github\pflannery\traceur-compiler\test\traceurTests.js.
Normalizes to D:modular/testRunner.js
locate resolved against base 'D:/dev/github/pflannery/traceur-compiler/'

The logic LGTM.
The combination of HTML Imports and ES6 imports needs experience.  Importing HTML async then internal modules async seems technically dubious.

@arv thanks, i've let loose on all vars, exports scriptSelector instead of static, fixed missing LFs in test files, remove unused body. PTAL

Regarding the failure on Windows, I'll look into to it.
The testRunner.html fails because our polyfill interferes with the browser.

LGTM

thanks @arv
I think it will need wiki info on bootstrapping and working with HTML Imports.

The combination of HTML Imports and ES6 imports needs experience. Importing HTML async then internal modules async seems technically dubious.

@johnjbarton yeah good point about the async load timings between ES6 and HTML Imports.
Using a script type="module" and an import {SomeModule} from './somewhere.js'; statement will cause the HTML import load order to be wrong. The same goes when using type="text/traceur" and an System.import(...) statement. But the ordering problem can be resolved if you put an import or System.import(...) statement in all related HTML imports.
I've noticed an error when trying to use script type="module" and import {SomeModule} from './somewhere.js'; in two separate HTML imports. Traceur spits out Error: duplicate module named. This error does not occur with type="text/traceur" and System.import(...).
Another thing I see (in the current release) is that if I try to mix match  script type="module" and script type="text/traceur" an error is thrown. This error also occurs when mix matching script types across HTML imports.

Please open issues for each problem, preferably with test code.


ERROR: attempt to index a nil value

From commit   78cda7ed94663416f401ca114bde124f178cec05
Every time I try to open code actions I get the following error:
Error executing vim.schedule lua callback: ...e-ui-select.nvim/lua/telescope/_extensions/ui-select.lua:34: attempt to index a nil value
stack traceback:
        ...e-ui-select.nvim/lua/telescope/_extensions/ui-select.lua:34: in function <...e-ui-select.nvim/lua/telescope/_extensions/ui-select.lua:22>
        ...e-ui-select.nvim/lua/telescope/_extensions/ui-select.lua:90: in function 'select'
        /usr/local/share/nvim/runtime/lua/vim/lsp/buf.lua:720: in function 'on_code_action_results'
        /usr/local/share/nvim/runtime/lua/vim/lsp/buf.lua:789: in function 'handler'
        /usr/local/share/nvim/runtime/lua/vim/lsp.lua:1516: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

fix is here: https://github.com/nvim-telescope/telescope-ui-select.nvim/pull/27
reason is a recent breaking change in neovim nightly, so you can checkout the PR and it should work again, but i cant merge that commit yet because it breaks this plugin for everyone who uses a neovim stable release

I'm on the latest commit referenced above, nvim 0.9.4, and i'm running into this issue still. any tips on where i should be debugging?

This issue should only affect the latest nightly (0.10-dev) we only enabled the fix for versions greater equal 0.10.
0.9 never needed a fix.
Can you maybe provide a error message and the output of nvim --version


fix(ui): change waiting_circular to Lottie animation, called "Organized 3D Loader"

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Task linked: CU-86c0jt02p Loading icon as Lottie Animation

:tada: This PR is included in version 2.130.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


highlight runtime errors

Fixes #99

@saimeunt thank you for the contribution!
After looking at the app it looks like the error highlighting in Instructions as well as in CASM is working pretty well. However, I do not see the error being highlighted in Sierra, can you look into that?
Also, can you move the execution to the "error" statement? Currently the execution is at the beginning at "Step 1", but we want to move it to the error in case of an error.
Please reach out in case of any questions.

@mazurroman I've moved the execution step to the error instruction on program run.
Regarding the SIERRA issue, I noticed the last execution trace is always pointing to the final return exiting the program and this instruction is not mapped to any SIERRA code 🤔 (no active index either).
Maybe the assumption "the last trace item is the runtime error" is untrue?
In this scenario I'm unsure how to proceed in order to pinpoint the SIERRA runtime error, I will try compiling and running the examples that panic with Cairo on my machine to get more info.

@barabanovro thanks for the heads up, we should be getting there now 💪

lgtm!


Implement check to ensure form has a contact for notifications

Error in VATSIM-UK/Core (Laravel)
Symfony\Component\Debug\Exception\FatalThrowableError in /var/www/core/current/artisan feedback:summarise --interval=p1d
Call to a member function notify() on null
View on Bugsnag
Stacktrace
app/Console/Commands/Feedback/GenerateFeedbackSummary.php:56 - App\Console\Commands\Feedback\GenerateFeedbackSummary::handle

View full stacktrace
Created by Alex Toff via Bugsnag

Duplicate of #1145


Load discrete libraries and utilities

Allow loading discrete libraries, added utility functions for modifying/overwriting fields in global tables and moved get/set to global context.

This is hopefully the last of my feature PRs for a while. I think this library now has the flexibility to be used in a server-side sandbox. I'm planning to drop it into a sort of cloud agnostic serverless Lambda system like AWS's but smaller in scope. I'm sure I'll end up sending you a few more feature PRs though :)


ClientError: Bad Request: rate_limit_error

Please check the boxes below by filling [ ] with an x so it looks like [x].
Remove all spaces already present in the box.

[x] I have installed the latest version of PyInstaLive: 2.4.9.
[x] I have installed either Python 2.7.x or 3.5>=.
[x] I have read the README.
[x] I have read the FAQ.
[x] I have checked all existing issues, none of which could solve my issue.

I am using:

[x] Windows 10

To report a bug, fill in the information below.
Command used
pyinstalive -u "myuser" -p "password" -r "streameracc"
Behavior
[E] ClientError: Bad Request: rate_limit_error
(Code: 400, Response: {"message": "Please wait a few minutes before you try again.", "status": "fail", "error_type": "rate_limit_error"})
Steps to reproduce issue
I'm using batch script loop with interval 6 secs, it worked for a few minutes then error happened.

The error seems pretty self-explanatory. Decrease the amount of requests you're making by using a higher interval.


[Azure OpenAI Service - Azure OpenAI Service] API Review

New API Review meeting has been requested.
Service Name: Azure OpenAI Service - Azure OpenAI Service
Review Created By: Ralf Beckers
Review Date: 05/09/2024 08:00 AM PT
Onboarding Record: https://dev.azure.com/azure-sdk/Release/_workitems/edit/17714
PR:
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: Placeholder, AzureOpenAI 2024-06-01-preview
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Cancelled by: Ralf Beckers


imageproxy use proxy to request image?

Hi Will,
First of all thanks for this wonderful tool and this is very handy, I hope if you don't mind asking can we explicitly tell imageproxy to use proxy list to request image? so that a remote site will block ip server if server request many to site

Yes, you can setup proxy from Environment.
Currently, by default it uses https://github.com/willnorris/imageproxy/blob/master/imageproxy.go#L101. By default it uses Proxy: ProxyFromEnvironment,.
You can setup it using following tip:

Thanks @Fieldistor, I wasn't even aware of that myself... that the DefaultTransport would accept those environment variables :)


TC Login 05

Description: Email with missing characters in the Email box field
Preconditions: Conection/Log In page is opened

Step.1 Open Chrome
Expected result: The page is opened

Step.2 The user clicks on the search bar the admin URL
Expected Result: Admin page is displayed

Step.3:The user writes the email incomplete
Expected result: A message should appear telling that the email is not valid or does not exist
Actual result: A email was sent to a incorrect/bad email address.


Razor Page Type in PageActionDescriptor

In the ControllerActionDescriptor I have access to the attributes that have decorated on the controllers and action. I use this option for implementing the dynamic permission scenario and with GetCustomAttribute I fetch the AuthorizeAttribute that has decorated on my controllers and actions.
descriptor.ControllerTypeInfo.GetCustomAttribute<AuthorizeAttribute>()?
     .Policy == ConstantPolicies.DynamicPermission

descriptor.MethodInfo.GetCustomAttribute<AuthorizeAttribute>()?
     .Policy == ConstantPolicies.DynamicPermission;

Now, I want to use this feature for the projects that use Razor Pages instead of MVC. So here I need to to use the PageActionDescriptor rather ControllerActionDescriptor than for the Razor Pages. The information that PageActionDescriptor Gives me are above:
public string AreaName { get; set; }

public string DisplayName { get; set; }

public string ViewEnginePath { get; set; }

public IList<ParameterDescriptor> Parameters { get; set; }

public IList<ParameterDescriptor> BoundProperties { get; set; }

public IList<FilterDescriptor> FilterDescriptors { get; set; }

// more

I've tried following code for getting AuthorizeAttribute:
descriptor.GetType().GetCustomAttribute<AuthorizeAttribute>()?
    .Policy ==  ConstantPolicies.DynamicPermission;

I've faced with the null value and in the debugging there hadn't been any Attribute, It's clear cuz the descriptor isn't the Razor Page Type.
Here I need to access the Razor Page Type for getting the decorated attributes and there aren't any properties for this fact.
Note that the AuthorizeAttribute isn't there in the FilterDescriptors property if you want to forward me to the doc.
Versions:
ASP.NET Core 2.1 +

.NET Core SDK (reflecting any global.json):
 Version:   3.0.100-preview4-011004
 Commit:    563371c23a

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.17763
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview4-011004\

Host (useful for support):
  Version: 3.0.0-preview4-27529-01
  Commit:<PHONE_NUMBER>

@pranavkm Can you take a look?

Thanks for contacting us, @xsoheilalizadeh.
@blowdart what would you recommend here?

I have no recommendations, this isn't a security decision, but rather one about the differences between MVC and Razor. The thing attempting to be done is valid, so Razor would need to find a way to expose the same sort of information.

You could get to the CompiledPageActionDescriptor using IPageLoader. HandlerType \ HandlerTypeAttributes are the equivalent to attributes on the controller.

Closing as this questions now seems to be answered.


DCTM connector

Coverage remained the same at 98.913% when pulling 9328e465bb547508d23fb1405ece733a1156188c on thakarevb:patch-2 into 43eb09440eab24b1476a00a04d0f81818934d9a5 on tableau:master.

Can you please help me if any action has to be taken from my side?
Regards
Vishal Thakare
On Wed, Jul 29, 2020 at 13:38 Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/32392710
Coverage remained the same at 98.913% when pulling 9328e46
https://github.com/tableau/webdataconnector/commit/9328e465bb547508d23fb1405ece733a1156188c
on thakarevb:patch-2 into 43eb094
https://github.com/tableau/webdataconnector/commit/43eb09440eab24b1476a00a04d0f81818934d9a5
on tableau:master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tableau/webdataconnector/pull/390#issuecomment-665507257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHNL4QBBRKYE5X6VBFFNYR3R57KIBANCNFSM4PLKJMGQ
.


Update README.md

so ppl have a idea of what it does if they cant guess from the title

Guess it's time I look into adding a bit more description and images to show some of the features. I'll try to cook up something soon ish hopefully. Thanks for the feedback, its more then welcome.


Path as attribute

Most of the use cases where I can see fsql being useful, normally involve doing something with the files found in the query, it would be really useful to know their file system location, at the moment additional manipulation is needed to get the path easily.
Adding path attribute as a fully resolved path, opens up a lot of possibilities.

FULLPATH(name) - Doh


IPN Verification

Hi, I just want to point out that the IPN endpoint is vulnerable. It's missing the verification steps which are steps 4 and 5 from https://developer.paypal.com/webapps/developer/docs/classic/ipn/integration-guide/IPNIntro/
As it is, a POST with txn_id and payment_status from anywhere can authorize a payment.

@munsu thanks for pointing this out. Looks like we took a shortcut years ago when we built this. I will try to patch this this week or next week.


fix(deps): update dependency @vitejs/plugin-vue to v4

This PR contains the following updates:

Package
Type
Update
Change

@vitejs/plugin-vue (source)
dependencies
major
^2.2.2 -> ^4.0.0

Release Notes

vitejs/vite-plugin-vue
v4.1.0
Compare Source

fix: avoid resolving to 2.7 compiler-sfc (cf36b3e)

v4.0.0
Compare Source

chore: update vite dep to ^4.0.0 (#49) (5a2f789), closes #49
chore(deps): update all non-major dependencies (#40) (4c95967), closes #40
chore(deps): update rollup and esbuild (#46) (92fec7b), closes #46

v3.2.0
Compare Source

chore(deps): update all non-major dependencies (#10393) (f519423), closes #10393
chore(deps): update all non-major dependencies (#10488) (15aa827), closes #10488
fix(plugin-vue): enable ts in template when using tsx in dev mode (#10180) (a9f9d31), closes #10180
docs: add missing binding in asset import example (#10414) (d7ac96d), closes #10414

v3.1.2
Compare Source
v3.1.1
Compare Source
v3.1.0
Compare Source
v3.0.3
Compare Source
v3.0.2
Compare Source

chore: fix code typos (#9033) (ed02861), closes #9033
chore: narrow down rollup version (#9637) (fcf4d98), closes #9637

v3.0.1
Compare Source

fix: mention that Node.js 13/15 support is dropped (fixes #9113) (#9116) (2826303), closes #9113 #9116
fix(vue): remove ssr.external config (#9128) (ec91f98), closes #9128
refactor(vue): limit passable compilerOptions (#8994) (b7b3e65), closes #8994

v3.0.0
Compare Source

chore: 3.0 release notes and bump peer deps (#9072) (427ba26), closes #9072
fix(vue): handle undefined on import.meta.hot.accept (fixes #8625) (#9011) (70af44a), closes #8625 #9011
docs: cleanup changes (#8989) (07aef1b), closes #8989

Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: frontend/package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/vite
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@vitejs/plugin-vue
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/cache/others/npm/_logs/2023-04-20T11_18_31_569Z-debug-0.log

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

Handle with corequisize in #438.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 4.x releases. However, if you upgrade to 4.x manually then Renovate will reenable minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Code cleanup: Use LogMessageGenerator.GetErrorsHeaderString() for logging errors

We should use this method in all clients when possible for logging errors. There is duplication of code in the different clients (CLI, MSBuild, and .vsix) and we should avoid it.


Alignment Fixes

Icons to alignment views to indicate correct orientation, such as front on, side on.

Add test to make sure that e.g. it's not vertical when it should be horizontal before registration/end of alignment, as a sanity check for user.
This will help with stopping invalid CSA calculations due to incorrect orientation of scans.

[ ] Add text into the 4 windows
[ ] Make sure manual alignment changes are pushed to the server

[ ] Add 3 point alignment


fix: should not use switch outside a router

Description
The error You should not use <Switch> outside a <Router> seems to be related to the <LocalizationProvider> component and its async nature. Perhaps React Router doesn't like having anything asynchronous between Router and Switch. This PR is moving <LocalizationProvider> down the tree and seems to be preventing the error.
Additional context
A way to reproduce this is having 2 browsers connected to the Vite server and refreshing automatically.
cc @codyscott1

Before submitting the PR, please make sure you do the following:

[ ] Add your change under the Unreleased heading in the package's CHANGELOG.md
[x] Read the Contributing Guidelines
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository for your change, if needed

Fixes #64

This breaks the useCountry hook in toplevel page components.
Additionally, when I log the props passed to the page components, they're always {}.
If I'm not mistaken, this means there's no way to get the country from the top level page components.


Use heartbeat to detect loss of connection to taker daemon

Fixes #482.
A few notes:

I haven't done the same thing for the maker yet. I'm unsure if we actually intend to keep supporting the maker frontend. If so I'll do it in a separate PR, following a similar approach.
This does not yet support reconnecting once the daemon is up again, it simply prompts the user to refresh the page. It may be simple to add this feature, but it isn't strictly necessary at this stage, as discussed with @thomaseizinger.
I am unsure about the way I've handled the toast. In fact we get a big warning every time it renders:

Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.
App@http://localhost:3000/src/App.tsx:32:45
Router@http://localhost:3000/node_modules/.vite/react-router-dom.js?v=b11c8a18:438:7
BrowserRouter@http://localhost:3000/node_modules/.vite/react-router-dom.js?v=b11c8a18:980:7
EnvironmentProvider@http://localhost:3000/node_modules/.vite/chunk-IDFFKOBS.js?v=b11c8a18:3863:18
ColorModeProvider@http://localhost:3000/node_modules/.vite/chunk-IDFFKOBS.js?v=b11c8a18:4024:15
ThemeProvider2@http://localhost:3000/node_modules/.vite/chunk-IDFFKOBS.js?v=b11c8a18:2145:43
ThemeProvider4@http://localhost:3000/node_modules/.vite/chunk-IDFFKOBS.js?v=b11c8a18:5922:28
IdProvider<@http://localhost:3000/node_modules/.vite/@chakra-ui_react.js?v=b11c8a18:791:18
ChakraProvider2@http://localhost:3000/node_modules/.vite/@chakra-ui_react.js?v=b11c8a18:1478:18 react-dom.development.js:67:29

bors r+


Pick up log4j config files from environment variable if not set in config override

Enable system admin or infra team to set log4j config file from SPARK_LOG4J_CONFIG_FILE_NAME and RAY_LOG4J_CONFIG_FILE_NAME environment variable. So the user don't have to know these system details.

@pang-wu Could you please also update the doc accordingly in doc/ray_on_spark.md? You can scroll down and update the last item. Or add a new item for logging. thanks

@pang-wu Could you please also update the doc accordingly in doc/ray_on_spark.md? You can scroll down and update the last item. Or add a new item for logging. thanks

done. I also updated raydp-submit

LGTM

Merged. Thanks!


Add a standalone test for qnn and byoc

Introduce a standalone regression test for the issue https://github.com/apache/tvm/issues/7067
@masahi @mbrookhart

@corehalt I dont think we need to introduce a new file, please add your change to qnn_test.py

thanks @corehalt


page.setExtraHTTPHeaders cause 'ERR_INVALID_ARGUMENT' error

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.20.0
Platform / OS version:  mac OS
URLs (if applicable):
Node.js version: v11.11.0

What steps will reproduce the problem?
const puppeteer = require('puppeteer');
(async () => {
    const browser = await puppeteer.launch({
        headless: false,
        ignoreHTTPSErrors: true,
        ignoreDefaultArgs: ["--enable-automation"],
        args: [
            '–no-sandbox',
        ]
    });
    const page = await browser.newPage();
    await page.setExtraHTTPHeaders(
        {'proxy-authorization': 'test'}
    );
    await page.goto('http://example.com/');
    await page.waitFor(10000);
    await browser.close();
})();

What is the expected result?
go to the url success
What happens instead?
(node:86672) UnhandledPromiseRejectionWarning: Error: net::ERR_INVALID_ARGUMENT at http://example.com/
    at navigate (/Users/andrew/Documents/otherProject/vs/demo/node_modules/puppeteer/lib/FrameManager.js:120:37)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)
  -- ASYNC --
    at Frame.<anonymous> (/Users/andrew/Documents/otherProject/vs/demo/node_modules/puppeteer/lib/helper.js:111:15)
    at Page.goto (/Users/andrew/Documents/otherProject/vs/demo/node_modules/puppeteer/lib/Page.js:674:49)
    at Page.<anonymous> (/Users/andrew/Documents/otherProject/vs/demo/node_modules/puppeteer/lib/helper.js:112:23)
    at /Users/andrew/Documents/otherProject/vs/demo/demo.js:16:16
    at processTicksAndRejections (internal/process/next_tick.js:81:5)

But, if I replace header proxy-authorization to proxyauthorization, it's fine.
So,it seems that it's not allowed containing '-' in header, is this corrent? Or is it an issue?

I wonder if setting (resetting?) some headers is bad?
https://github.com/chromium/chromium/blob/b2254b38369f4f8ce8685b7a82dee1251f6cea22/services/network/url_loader.cc#L679-L683
https://github.com/chromium/chromium/blob/3611052c055897e5ebbc5b73ea295092e0c20141/services/network/public/cpp/header_util_unittest.cc#L50

fwiw, we started seeing this error when we upgraded to puppeteer 2.0.0.  And like @danielabel said, it turned out to be because of a header we'd always been sending (Cookie2) making chrome barf.

We’re getting the same ERR_INVALID_ARGUMENT error when setting a Host header via page.setExtraHTTPHeaders() and loading http://localhost/path/to/tested/page. When I curl it, I get the response I expect:
curl -H "Host: [REDACTED]" http://localhost/path/to/tested/page

Using v2.0.0.

Agreed with @agarzola, the Host header causes problems when I set it explicitly.

FYI we're also encountered this error with Puppeteer 2.0 (not before) and when overriding header Keep-Alive.

It seems that some headers cannot be set using setExtraHTTPHeaders. "Proxy-" cannot be set probably because that's a browser-wide setting and should be done by
puppeteer.launch({
    args:[ '--proxy-server=http://example.com' ]
});

others are Hop-by-hop headers that only make sense per-request https://www.freesoft.org/CIE/RFC/2068/143.htm (setExtraHTTPHeaders works per-tab and influences for example all XHR requests from that tab too).
But it would be nice if Puppeteer returned a more helpful error message than just net::ERR_INVALID_ARGUMENT

same issue

same issue here, when I call
 page.setExtraHTTPHeaders({ 'host': 'www.amazon.com' });
I saw net::ERR_INVALID_ARGUMENT issue

We’re getting the same ERR_INVALID_ARGUMENT error when setting a Host header via page.setExtraHTTPHeaders() and loading http://localhost/path/to/tested/page. When I curl it, I get the response I expect:
curl -H "Host: [REDACTED]" http://localhost/path/to/tested/page

Using v2.0.0.

Is there any workaround?

If you want to pass proxy-authorization then use below code instead of page.setExtraHTTPHeaders():
await page.authenticate({username:'', password:''})

If you want to pass proxy-authorization then use below code instead of page.setExtraHTTPHeaders():
await page.authenticate({username:'', password:''})

Thanks for replying me. Actually, I want to get workaround for page.setExtraHTTPHeaders({ 'host': 'www.amazon.com' });

Fix?

I removed it, and then everything works

I meant an error in principle, I think it is wrong that some arguments cannot be passed.


Update readme, index.html, and lipsum.txt file from example branch

Updates
I have updated these files:

readme
index.html
lipsum.txt

Please review and accept

I probably should not, but OK. 👍


Better handling of missing inputs in get_total_irradiance, get_sky_diffuse

[x] Closes #949
[x] I am familiar with the contributing guidelines
[x] Tests added
[x] Updates entries to docs/sphinx/source/api.rst for API changes.
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

Missing airmass can be calculated.
Calculating missing dni_extra requires having a datetime index. Since the functions are not constrained to input type Series, I suggest that pvlib raise an informative ValueError and let the user handle it.

Thanks Cliff. Can I push the button when the tests are done?

Push the green button - yes. Not the red one.

🚀


linux_xanmod, linux_xanmod_latest: 2024-10-22

~Still needs testing~
LTS working fine for my setup ZFS rootfs on amd cpu/gpu
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

tested lts.


Fix wiki.openwrt.org top-level pages

As with the OpenWrt home page (see issue #12 ) the top-level pages of the Wiki need to be updated with the same spirit of confidence and helpfulness to entice new people, especially newbies, to give OpenWrt a try.
Currently, the wiki has many pages in the top two levels that are listed as under construction, haven't been updated in years, or have information of questionable relevance beyond historical curiousity.
Ordinarily, this is a clear sign that a project is on its death bed. If I hadn't known that OpenWrt had real legs, I would never have switched from DD-WRT (or even Tomato.)
The current wiki conceals the fact that OpenWrt is a major success.
My recommendation is that we make a quick pass through all the pages that are two clicks from http://wiki.openwrt.org and ensure that each page:

Reassures new people (no "Under construction" notation),
Emphasizes the Barrier Breaker release, since it works, is the current build, and can make a lot of people happy if they would only give it a try.
Is correct (if possible)
... and if we can't do any of these, the page should be marked at the top with a sub-headline of "This page has not been updated, and may not contain current information." We might also tag these pages with "Outdated" for further processing

This won't take long, and will give us enough information to make further priority decisions.

I'm going to take a crack at creating a new version of the wiki home page. (It's not editable by ordinary wiki members) and then post the URL to it here by the end of this weekend.

Awesome @richb-hanover, thank you very much! Is there anything I or anyone else can do to help?

Maybe this is overly simplistic but if you look at http://wiki.openwrt.org/doc/start, that feels more like what I'd expect the OpenWrt wiki homepage (http://wiki.openwrt.org) to look like. I mean, it needs some cleanup but it's organized somewhat already. Could we simply start with that as the beginning of the Wiki homepage?

@richb-hanover made a start page to discuss:
https://forum.openwrt.org/viewtopic.php?pid=276602#p276602
I find that version a better starting point than http://wiki.openwrt.org/doc/start
I dont know exactly why though. And the latter one probably contains links/things that should, one way or another be in the starting page.
At the same time: less is more ;) Lets keep it quite simple.
Could we (@richb-hanover) merge the "other start" page into "his" start page, and then we can start taking away stuff (by just linking, or even removing links) until the start page is clean and simple enough?

@zo0ok I think @richb-hanover's start page is supposed to be the main (openwrt.org) homepage. I was thinking http://wiki.openwrt.org/doc/start would be the homepage of the wiki (wiki.openwrt.org).
I would agree that we need to highlight different pieces of content on both pages though!

Ahhh... I am just trying to be helpful and constructive when I should probably be sleeping instead ;)

No need to worry @zo0sk! You're helping a lot!

I see a couple competing goals:

I agree that the Documentation page might be the best foundation for the top level wiki.openwrt.org. (The current wiki home page is appears to have the same goal, but lacks the conviction to say it.) That top-level page should lead the way for different kinds of people:

newcomers who have heard OpenWrt is cool
experienced people who want to find out about specific features
developers

I don't know if there is going to be some resistance to changing the top of the home page and wiki, so I want to keep things familiar, and minimize the changes in format from the current. (I would agree that a good wiki home page could indeed become the openwrt.org home page as well).

I have taken a stab at converting the wiki's Documentation page (http://wiki.openwrt.org/doc/start) into something that could be come the wiki's top-level page. I factored out the info into three sections:

Newcomers Guide
Experienced User Guide
Developer Guide

You can review the first cut of this work at http://wiki.openwrt.org/doc/playground My mind reels at the amount of work that will be required for the Newcomer page. But that's OK - we have a good team here.
I'm going away for the remainder of the weekend. Please feel free to edit these pages!

I have also posted the full set of OpenWrt documentation pages to another github repo: https://github.com/richb-hanover/openwrt-docs This is one way to see how our current set of pages fit into the three guides described above.

I think the Wiki Documentation page with its 3 categories is good. And I understand it is not the OpenWrt start page. Allt the docs that went to github in HTML format... I don't really know what to do with it.

I created the github files simply to show all the documentation pages that exist in the wiki.
I have the sense that some of those pages could be valuable for one or more of the guides - just looking at the filenames of the articles was helpful for me to understand what kind of info was there.

@richb-hanover I like where this is going! I worry though that the top level wiki page seem a bit sparse. I'm not sure what should be added though.
Also I was off this weekend and part of last week so I didn't get this until now!

Yes, my proposed top-level page for the wiki at http://wiki.openwrt.org/doc/playground does look a little sparse. That's why I said, "What Else?" at the bottom :-)
On the other hand, it is my intent that the three guides should direct people to most everything they would want/need to know, so my hope was to focus most of the energy toward each of those three guides. (NB - the wiki's old home page is basically a concatenation of the Newcomer's Guide and the Developer Guide. I had to collect a few items to flesh out the Experienced Guide.)

Oops, I totally forgot to get back to you on this. I think you did a great job honestly. The documentation seems much better organized like this than before.

I modified the table so that that there's a line break between the description of a guide and the line saying "Read the " with a link to the guide. I also bolded the line. I think it's a little clearer visually but if others don't agree, I'm cool with changing it back :)

No, it's definitely better to have those links to the guides separated and bolded. Good catch!
I think the last interesting change I want to see is to shuffle around the info in the Newcomers Guide to be a straightforward guide that leads people from discovery, to reading the detail page, to installing the firmware, and finally to getting it successfully running and on the Internet, with LuCI, Wifi, etc.
The information is mostly there, but it's presented badly/in a poor order. Currently, it says, "Just do this." "Oh, and now do this." "Oh, and if you want wireless, do this..."
Fixing the top-level page, and preserving most of the specific words will get us started. Anyone hungering to jump in? If not, I'll put it on my list after the ToH/Detail Pages settle down.
Thanks!

@richb-hanover I've started a new issue #17 for the newcomers guide and I'll take a crack at improving it.

I took advantage of the (new?) ability to edit :doc:start (the top-level Documentation page) to install the draft that we had cooking from last summer. Please check out the new top-level documentation page at: https://wiki.openwrt.org/doc/start
If you have thoughts or comments, just start editing (it's a wiki, after all!)


Fixed form switch when enable-rounded is false

Description
Different approach to #38109. When enable-rounded is set to false switch indicator shouldn't be rounded.
Motivation & Context
When enable-rounded is set to false form switch component takes the form of a retangle with rounded corners removed. However the switch indicator is still a circle, which is not consistent.

After the fix the switch indicator will be a rectangle.

Type of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[X] I have read the contributing guidelines
[ ] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[X] All new and existing tests passed

Related issues
#38109

@maciek-szn I have updated my PR (#38109) pretty much at the same time as you proposed this one. I also did a demo app:
https://gregorw.github.io/bootstrap-switch-bugfix/
Would you mind closing your PR such that I can get my first contribution to this repository? I’d love to be a contributor to Bootstrap.


how to add sonar to the turtlebot3

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[x] Burger

Which ROS is working with TurtleBot3?

[x] ROS 1 Kinetic Kame

Which SBC(Single Board Computer) is working on TurtleBot3?

Which OS you installed on SBC?

[x] Ubuntu MATE (16.04/18.04/20.04)

Which OS you installed on Remote PC?

[x] Ubuntu 16.04 LTS (Xenial Xerus)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.

HERE

Copy and Paste the error messages on terminal.
I want to use dqn with the sonar, but I don't know how to add sonar into the turt3bolt3, Is there any tutorials or examples for me to achive my purpose?

Please describe the issue in detail.

HERE

Hi. @w5688414  Thanks for the question.
Please refer to the link below for related information.
13.3.3 Ultrasonic
Thank you.

Please also refer to below issue thread regarding the sonar add on to TurtleBot3
https://github.com/ROBOTIS-GIT/OpenCR/issues/233

I want to add sonar to TurtleBot3 in gazebo. like this, https://emanual.robotis.com/docs/en/platform/turtlebot3/machine_learning/#machine-learning
I want to train DQN in gazebo, not the OpenCR of TurtleBot3.

@w5688414
YOu can refer to the link below.
https://answers.ros.org/question/362576/adding-sonar-in-gazebo-and-ros/

This issue will be closed due to prolonged inactivity. Please try again with the Humble or Noetic versions, and if the issue persists, feel free to reopen it.


Potential issues with current UTXO mechanism

For FairMinters, we (https://openstamp.io/) have launched account model-based trading and are currently exploring Counterparty's UTXO design to support Atomic Swap trading in the UTXO model. However, we have found that the current UTXO design may have certain inconsistencies with its intended purpose:
Currently, Counterparty allows assets to be attached to already spent UTXOs
One of the main reasons Counterparty introduced the UTXO model was to allow Counterparty assets to be compliant with the Ordinals trading transactional structure, facilitating seamless integration of Counterparty assets into the Ordinals ecosystem for major Ordinals players.
However, allowing assets to be attached to already spent UTXOs prevents achieving a consistent trading model with Ordinals, as Atomic Swap transactions need to reference UTXOs to which assets are attached.
Therefore, our recommendations are as follows for a reference:
Assets should not be specifically attached to a particular UTXO but rather to the outputs of the current transaction by default, with attachment to the first non-OP_RETURN output.

Assets should not be specifically attached to a particular UTXO but rather to the outputs of the current transaction by default, with attachment to the first non-OP_RETURN output.

This is already possible. You simply don't specify the destination when attaching.

@btcopenstamp thank you very much for this report and all these great suggestions!!
Please see https://github.com/CounterpartyXCP/counterparty-core/pull/2626


Add a Menu

I want to have a public endpoint (e.g. /menu) that shows a subset of cocktails I can make. This differs from the shelf (which shows all cocktails I can make) and favorites (which shows some of my bar's specialties that I can't always make).

This endpoint shouldn't require authentication so I can share it with guests so they can pick a cocktail from the menu.
I should be able to add/remove an individual cocktail to the menu via a button/link on the cocktail details page.
I should be able to click a button/link on a collection that sets the menu to the collection (clear the current menu and then add each cocktail in the collection). This should be a one time push/sync; it shouldn't be a constant sync (e.g. allowing me to adjust the menu if I need to add/remove things that are/aren't in the collection)
The menu page, when visited without authentication, should only show cocktails I can make
The menu page, when visited with authentication, should show the cocktails I can't make with some visual indicator they will be hidden (transparency, an icon, etc)
The menu page, when visited with authentication and applicable authorization, should show a button/link by each cocktail in the list that lets me remove the cocktail from the menu

I've been thinking about the best way to make a collection public and this seems like a really good idea. Thanks!

I've started looking at creating a PR for this and I noticed that Collections belong to a BarMembership instead of a Bar, but I really envision this feature would be a singleton for a Bar. I think being able to make a collection public is a great addition, but I don't think that really addresses this feature. Making a collection public would mean that I'd have to create a dedicated "Menu" collection to make it so the link would never change, and it wouldn't really make sense to add the "set a collection's contents to this collection" feature.
I was looking at adding a bar_menus table that has bar_id and cocktail_id columns instead; which feels like a redundancy, but I believe it adds a unique value prop.

I'm not sure if bars should have multiple menus, and then have only 1 menu active at a single time.

Agreed that bars should only have one menu. I originally had menu_cocktails but wasn't sure if you preferred to have a bar prefix since the menu is associated with the bar.

Oh, I see what you mean. Having two tables works; I figured it could be just one table, but having 2 will be useful and prevent columns I was adding to bars

Thanks for implementing this @karlomikus! Sorry I didn't take this over the finish line


Updated documentation & bugfix for issue #214

Updated documentation for Connect-SPOnline, Get-SPOAuthenticationRealm & Add-SPONavigationNode and bugfix for issue #214

Hi @Laskewitz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks Daniel!