Finch configuration

@restlessronin are you still against providing configuration for Finch?
I would love to tweak some of the connection options too and I don't see a way to do it. Having a glance at the code, I think the way to do it would be to hook into this line:
https://github.com/restlessronin/openai_ex/blob/669c663a557ab691b6b8b01c51790c2984ad716b/lib/openai_ex/application.ex#L9C6-L9C6
we could grab the options from either Config and/or specify a callback function in config that is called to fetch the configuration - I don't mind either solution.
Originally posted by @hubertlepicki in https://github.com/restlessronin/openai_ex/issues/48#issuecomment-1873875245

@hubertlepicki
I would like the out-of-the-box defaults to be working fine for all non-production use-cases. And to use key-value pairs within the %OpenaiEx{} to do any remaining configuration.
Having said that, I would like to support production use cases where tweaking is necessary, but I'd prefer to exhaust non config options first. It seems like you want to adjust the pools that finch is using. Is that correct?
If so, would it work for you to do something like
Finch.start_link(
name: MyConfguredFinch,
pools: ...
)
and then use a new key-value setter
myopenai = openai |> with_finch_name(MyConfiguredFinch)
which would use yourMyConfiguredFinch instance instead of the default OpenaiEx.Finch.

@restlessronin that will work for me

@hubertlepicki done. published as v0.5.5. take it for a whirl and let me know if anything else needs to be done.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

Don't miss out on your $1500 in BNB! Act now to secure your tokens.
Winners: @spkuehl, @gebbbiii, @KewlAid83, @krzysztof-naglik-codilime, @luyzdeleon, @nishit-g, @vxzhong, @lujianmei, @DMuld, @MAOSOE, @Kreedzt, @fondroid, @avardaan, @ElectronSz, @KamilKwapisz, @SparrowOchon, @alan-andrade, @Fooooooooooox, @developerasun, @SerialDev, @secretsauce988, @cbdyzj, @qhxin, @enixdark, @dleurs, @m4r1-pac, @Bamco, @sunvim, @YangYuchu, @albincsergo, @stoppark, @kenvinwei, @pietromenna, @YusufJaj, @Xexanoath, @fraystation, @bayu-fahrera, @gunzombie, @C-Band, @Ivan92750, @hungpro30, @Crushedlex, @skycccu, @Dev-HyunSang, @joelvh, @kazani-351, @hefgi, @lyknice23, @huazhuangnan, @joshkmartinez

@hubertlepicki I am closing this issue assuming that things are working as you expected.


Corrected small misspelling

misspelled 'to' as 'tp'. Corrected.

@tcstar : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; merging.


Websocket input/output adapter

Hi Gunther. Is it possible for you to release a websocket adapter?
I have been trying to implement one with autobahn, But i am not sure how the input and output adapters should be

Got around implementing it. Was quite simple
from autobahn.twisted.websocket import WebSocketServerProtocol, \
    WebSocketServerFactory
from chatterbot import ChatBot

chatbot = ChatBot(
    'Ron Obvious',
    storage_adapter="chatterbot.adapters.storage.MongoDatabaseAdapter",
    database="chatbot"
)

print chatbot.get_response("Hello, how are you today?")

class MyServerProtocol(WebSocketServerProtocol):

    def onConnect(self, request):
        print("Client connecting: {0}".format(request.peer))

    def onOpen(self):
        print("WebSocket connection open.")

    def onMessage(self, payload, isBinary):
        msg = chatbot.get_response(payload.encode('utf8'))
        self.sendMessage(msg.text.encode('utf8'), isBinary)

    def onClose(self, wasClean, code, reason):
        print("WebSocket connection closed: {0}".format(reason))

if __name__ == '__main__':

    import sys

    from twisted.python import log
    from twisted.internet import reactor

    log.startLogging(sys.stdout)

    factory = WebSocketServerFactory(u"ws://<IP_ADDRESS>:9000")
    factory.protocol = MyServerProtocol
    # factory.setProtocolOptions(maxConnections=2)

    # note to self: if using putChild, the child must be bytes...

    reactor.listenTCP(9000, factory)
    reactor.run()

Fixed this by setting user_id before get_response.

I have a global users object with all user settings (eg: Intent)
Single instance of Chatbot
Pass the users object into Chatbot while initializing

def onConnect(self, request):
    # Create or re-use the user_id based on cookies
    self._user_id = user_id # Generate this
    self.chatbot = bot
    users[self._user_id] = { ... user settings here }

def onMessage(self, payload, isBinary):
    self.chatbot.user_id = self._user_id
    msg = self.chatbot.get_response(payload.encode('utf8'))
    self.sendMessage(msg.text.encode('utf8'), isBinary)

It would be great if you can provide a method to set context variables dynamically. And even adding/removing adapters

@rmdort I'm glad you figured it out. I agree with the idea to add methods to add and remove logic adapters. Feel free to open a ticket with that request.


Help Debug Editor should open a new editor instead of copying to clipboard

For some reason, using the clipboard does not always work with Atom. /cc #1060 et al.

In fact, let's create the entire Gist automatically: https://developer.github.com/v3/gists/#create-a-gist

Published to v0.29.10

It should be made clear in the doc that this changed. The troubleshooting page wasn't updated with this.


feat: re-implement caching in Actions

Uses the example documented in GitHub Help:
https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#example-using-the-cache-action

When actions/cache@v1 was re-introduced in this workflow file via https://github.com/francisfuzz/eleventy/pull/1/commits/8f37291a8d2d8e314a134f64874108b0c2d957b3, the builds failed with this error:
##[error]The template is not valid. hashFiles('/home/runner/work/eleventy/eleventy/**/package-lock.json') failed. Search pattern '/home/runner/work/eleventy/eleventy/**/package-lock.json' doesn't match any file under '/home/runner/work/eleventy/eleventy'

https://github.com/francisfuzz/eleventy/pull/1/commits/deaae810e80f68d8576c4ddd8faf897052749574 re-introduces the package-lock.json file according to what's defined in package.json, also updating .gitignore to reflect the change. 👍


How to translate this part of page?

https://github.com/miguelgrinberg/microblog/blob/22fe46f615bd398a8cc69d64e20e8f0ef66e7d01/app/templates/base.html#L42

Apply the _('text') in the code where all the messages are generated, so that the message reaches the template after it was translated. This is done in this tutorial.

Ok, Thank You
sob., 11 lip 2020 o 18:51 Miguel Grinberg<EMAIL_ADDRESS>napisał(a):

Apply the _('text') in the code where all the messages are generated, so
that the message reaches the template after it was translated. This is done
in this tutorial.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/miguelgrinberg/microblog/issues/248#issuecomment-657142426,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANEB4GDOVENVBJ6YY5T5YA3R3DUGTANCNFSM4OXQD5VA
.


Moving back models from archive to main ILSVRC2012 folder

Moved back models to main ILSVRC2012 folder.
Removed archive folder.

LGTM


[#130102001] Bootstrap bosh and concourse

What
Story: Create custom release concourse
We need a new concourse that will be used to build bosh releases. It was decided to take the opportunity and deploy this concourse with bosh instead of bosh-init. The main reasons are:

bosh-init can handle only 1 VM. bosh can handle complex deployments and we may need it to scale concourse
bosh can cache compiled artifacts
bosh manages the state automatically
reduces the size of the CF pipeline so this should improve our development time

This is now a generic concourse that we will use to build bosh releases, but eventually paas-cf may be migrated to use it for its bootstrap. We created a new repository that uses a lot of the paas-cf code so most is already known. The main changes are:

bosh is now created in the bootstrap pipeline instead of the CF pipeline
concourse is deployed with bosh instead of bosh-init
since concourse lite is in a different VPC than bosh, bosh is now accessed via its external IP
the security groups have changed slightly because we moved things around and the dependencies have changed
update CPI to latest (v60). This was required for the auto-assign feature introduced in v55. The pipeline point to the bosh-init container tagged for the new version.
changed IAM policies (See PR in aws-account-wide-terraform)

We have made other smaller changes:

improve naming
parallelise and merge pipeline jobs
improve management of bosh_fqdn variable
other minor things

How to review

Apply changes from the PR in aws-account-wide-terraform
Start concourse lite:

DEPLOY_ENV=testabcd make dev bootstrap

Connect to localhost:8080 and start create pipeline
In the end you should be able to access concourse at: https://concourse.testabcd.dev.cloudpipeline.digital
Login to concourse, upload pipelines
Destroy the environment using the destroy pipeline
Destroy concourse-lite:

DEPLOY_ENV=testabcd make dev bootstrap-destroy

Set up the local environment with python, ruby, go and check that make test passes successfully

Create the build CI

Make sure the previous concourse lite is destroyed
Start concourse lite for CI:

DEPLOY_ENV=build make ci bootstrap

Connect to localhost:8080 and start create pipeline
In the end you should be able to access concourse at: https://concourse.build.ci.cloudpipeline.digital
Destroy concourse-lite:

DEPLOY_ENV=build make ci bootstrap-destroy

Who can review
Anyone but @HenryTK or myself

I know that it is a bunch of work, but it would have been great if we keep the history from paas-cf when copying the files across:http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/
I did it for other parts of the project.
But it is not easy. true.

So, we discussed it internally and we agreed that it is too much of a PITA to get the history in the repository. We will instead add a link to the old project tree in github in each commit that copies files across.
@saliceti do you mind to do that? :)


I am get mac address instead of LocalName

this is your provided apk I install to get familiar with the features.
I get mac address instead of Names? why is that? Is it some settings in android or my phone is operating differently.
my phone is Sony xperia z3+ and android version is 7.1.1

maybe your device doesn't broadcast their bluetooth name


room.disconnect() then check room.isconnected() sometime have some bug: room.isconnected() return True

issue code:
import asyncio
import datetime
import logging
from signal import SIGINT, SIGTERM
from typing import Union
import os

from livekit import api, rtc, protocol

# https://docs.livekit.io/home/client/events/#Events
# NOTE!!!! please see Room on method Available events Arguments :)

async def main(room: rtc.Room) -> None:
    @room.on("participant_connected")
    def on_participant_connected(participant: rtc.RemoteParticipant) -> None:
        logging.info(
            "participant connected: %s %s", participant.sid, participant.identity
        )

    @room.on("participant_disconnected")
    def on_participant_disconnected(participant: rtc.RemoteParticipant):
        logging.info(
            "participant disconnected: %s %s", participant.sid, participant.identity
        )

    @room.on("local_track_published")
    def on_local_track_published(
        publication: rtc.LocalTrackPublication,
        track: Union[rtc.LocalAudioTrack, rtc.LocalVideoTrack],
    ):
        logging.info("local track published: %s", publication.sid)

    @room.on("active_speakers_changed")
    def on_active_speakers_changed(speakers: list[rtc.Participant]):
        logging.info("active speakers changed: %s", speakers)

    @room.on("local_track_unpublished")
    def on_local_track_unpublished(publication: rtc.LocalTrackPublication):
        logging.info("local track unpublished: %s", publication.sid)

    @room.on("track_published")
    def on_track_published(
        publication: rtc.RemoteTrackPublication, participant: rtc.RemoteParticipant
    ):
        logging.info(
            "track published: %s from participant %s (%s)",
            publication.sid,
            participant.sid,
            participant.identity,
        )

    @room.on("track_unpublished")
    def on_track_unpublished(
        publication: rtc.RemoteTrackPublication, participant: rtc.RemoteParticipant
    ):
        logging.info("track unpublished: %s", publication.sid)

    @room.on("track_subscribed")
    def on_track_subscribed(
        track: rtc.Track,
        publication: rtc.RemoteTrackPublication,
        participant: rtc.RemoteParticipant,
    ):
        logging.info("track subscribed: %s", publication.sid)
        if track.kind == rtc.TrackKind.KIND_VIDEO:
            print("Subscribed to an Video Track")
            _video_stream = rtc.VideoStream(track)
            # video_stream is an async iterator that yields VideoFrame
        elif track.kind == rtc.TrackKind.KIND_AUDIO:
            print("Subscribed to an Audio Track")
            _audio_stream = rtc.AudioStream(track)
            # audio_stream is an async iterator that yields AudioFrame

    @room.on("track_unsubscribed")
    def on_track_unsubscribed(
        track: rtc.Track,
        publication: rtc.RemoteTrackPublication,
        participant: rtc.RemoteParticipant,
    ):
        logging.info("track unsubscribed: %s", publication.sid)

    @room.on("track_muted")
    def on_track_muted(
        publication: rtc.RemoteTrackPublication, participant: rtc.RemoteParticipant
    ):
        logging.info("track muted: %s", publication.sid)

    @room.on("track_unmuted")
    def on_track_unmuted(
        publication: rtc.RemoteTrackPublication, participant: rtc.RemoteParticipant
    ):
        logging.info("track unmuted: %s", publication.sid)

    @room.on("data_received")
    def on_data_received(data: rtc.DataPacket):
        logging.info("received data from %s: %s", data.participant.identity, data.data)

    @room.on("connection_quality_changed")
    def on_connection_quality_changed(
        participant: rtc.Participant, quality: rtc.ConnectionQuality
    ):
        logging.info("connection quality changed for %s", participant.identity)

    @room.on("track_subscription_failed")
    def on_track_subscription_failed(
        participant: rtc.RemoteParticipant, track_sid: str, error: str
    ):
        logging.info("track subscription failed: %s %s", participant.identity, error)

    @room.on("connection_state_changed")
    def on_connection_state_changed(state: rtc.ConnectionState):
        logging.info("connection state changed: %s", state)

    @room.on("connected")
    def on_connected() -> None:
        logging.info("connected")

    @room.on("disconnected")
    def on_disconnected(reason: protocol.models.DisconnectReason) -> None:
        logging.info(f"disconnected reason:{reason}")

    @room.on("reconnecting")
    def on_reconnecting() -> None:
        logging.info("reconnecting")

    @room.on("reconnected")
    def on_reconnected() -> None:
        logging.info("reconnected")

    # will automatically use the LIVEKIT_API_KEY and LIVEKIT_API_SECRET env vars
    token = (
        api.AccessToken()
        .with_identity("python-bot")
        .with_name("Python Bot")
        .with_grants(
            api.VideoGrants(
                room_join=True,
                room=os.getenv("ROOM_NAME", "chat-room")
            )
        )
        .with_ttl(datetime.timedelta(hours=1))
        .to_jwt()
    )
    # need LIVEKIT_URL env vars to connect
    await room.connect(os.getenv("LIVEKIT_URL"), token)
    logging.info("connected to room %s", room.name)
    logging.info("participants: %s", room.remote_participants)

    # pub data
    await room.local_participant.publish_data("hello world")

    # chat
    chat = rtc.ChatManager(room)

    # receiving chat
    @chat.on("message_received")
    def on_message_received(msg: rtc.ChatMessage):
        print(f"message received: {msg.participant.identity}: {msg.message}")
    # send msg
    await chat.send_message("hello world msg")

    # have some disconnect BUG
    while room.isconnected():
        print("room disconnecting")
        await asyncio.sleep(1)
        await room.disconnect()

    logging.info(f"room isconnected:{room.isconnected()}")

if __name__ == "__main__":
    # golang style

    logging.basicConfig(
        level=logging.INFO,
        format='%(asctime)s - %(name)s - %(levelname)s - %(pathname)s:%(lineno)d - %(funcName)s - %(message)s',
        handlers=[
            # logging.FileHandler("room_rtc_events.log"),
            logging.StreamHandler()
        ],
    )

    loop = asyncio.get_event_loop()
    room = rtc.Room(loop=loop)

    async def cleanup():
        print("isconnected:", room.isconnected())
        try:
            await room.disconnect()
        except AssertionError as err:
            print("AssertionError", err)
        except Exception as e:
            print("Exception", e)
        loop.stop()
        print("cleanup ok")

    asyncio.ensure_future(main(room))
    for signal in [SIGINT, SIGTERM]:
        loop.add_signal_handler(signal, lambda: asyncio.ensure_future(cleanup()))

    try:
        loop.run_forever()
    finally:
        loop.close()

print info:
......
room disconnecting
room disconnecting
room disconnecting
room disconnecting
^C
isconnected: True
cleanup ok
......

@weedge which version of the SDK as this observed on?

@weedge which version of the SDK as this observed on?

@davidzhao
pip show livekit livekit-api

Name: livekit
Version: 0.17.5
Summary: Python Real-time SDK for LiveKit
Home-page: https://github.com/livekit/python-sdks
Author:
Author-email:
License: Apache-2.0
Location: /Users/wuyong/project/python/chat-bot/.venv_achatbot/lib/python3.11/site-packages
Requires: protobuf, types-protobuf
Required-by:
Name: livekit-api
Version: 0.7.1
Summary: Python Server API for LiveKit
Home-page: https://github.com/livekit/python-sdks
Author:
Author-email:
License: Apache-2.0
Location: /Users/wuyong/project/python/chat-bot/.venv_achatbot/lib/python3.11/site-packages
Requires: aiohttp, livekit-protocol, protobuf, pyjwt, types-protobuf
Required-by:


PLAT-84609: Add Loading Spinner

Add loading spinner

FYI, this PR will need to include the base-skin initialization variables now that PR #147 has merged.

Closing in favor of #155


Debt: Refactor Home Page Script

Topic
Refactoring William's initial work on the Home.vue view.
Service
Frontend
Steps

[x] Implement Environment Variables
[ ] Refactor Axios Requests
[ ] Simply logic (use computed, map, etc.)
[ ] Add type support

@willcbelcher @TylerB890 @geiger96 @calvinmead1 @ITM007
Good learning experience to take the Frontend code William wrote and systematically refactor it with a new section completed in the different commits in the connected PR.

I think this is ready to be closed. Is this refactor done?

Complete.


[Proposal] Make Zipkin and Jaeger formats analysis product available

Now we have a Zipkin receiver(experimental), which could process data and reformat it to SkyWalking native format. The reason I called it experimental because really it is not available in cluster mode, and not in high performance.
Thanks to @peng-yongsheng and other committers deliver the new core of SkyWalking v6, I have some new solutions.
The basic principle is

Deliver trace and span storage based on native implementation of Zipkin or Jaeger.
Metric of service, service instance, endpoint scope come from span directly, no need to wait.
Relationship of service based on the span with RPC info, keep in Redis(or other) cache, set a timer to read and try match. Dispatcher as relation scope when both sides are ready.

Thank modulization and scan based extension mechanism, I could provide

A new storage implementation for all metric and alarm
A storage-ext module and implementations for Zipkin or Jaeger. They take charge of span based trace persistence
New query implementations for Zipkin or Jaeger.

The benefits of doing these are

Cluster mode easier to support. (Important for production ready)
Lower cache requirements in backend and reids.  (Important for production ready)
We don't need to depend on SkyWalking native span/segment data structure to run the analysis for Zipkin and Jaeger. (Reduce the chances to face bugs of formats adaptor)
Storage of traces could follow the native Zipkin and Jaeger.
Storage still switchable, old codes of metric, alarm and record still useful.

The ideal result of this could be shown in application.yml, which should like this
storage:
  elasticsearch:
    nameSpace: ${SW_NAMESPACE:""}
    clusterNodes: ${SW_STORAGE_ES_CLUSTER_NODES:localhost:9200}
    indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
    indexReplicasNumber: ${SW_STORAGE_ES_INDEX_REPLICAS_NUMBER:0}
    # Batch process setting, refer to https://www.elastic.co/guide/en/elasticsearch/client/java-api/5.5/java-docs-bulk-processor.html
    bulkActions: ${SW_STORAGE_ES_BULK_ACTIONS:2000} # Execute the bulk every 2000 requests
    bulkSize: ${SW_STORAGE_ES_BULK_SIZE:20} # flush the bulk every 20mb
    flushInterval: ${SW_STORAGE_ES_FLUSH_INTERVAL:10} # flush the bulk every 10 seconds whatever the number of requests
    concurrentRequests: ${SW_STORAGE_ES_CONCURRENT_REQUESTS:2} # the number of concurrent requests
storage-jaeger-ext:
  default:
receiver_jeager:
  default:
    parameters:xxxx
query:
  graphql-jaeger:
    path: ${SW_QUERY_GRAPHQL_PATH:/graphql}

Hope I haven't missed anything in high level. @peng-yongsheng @JaredTan95 @YunaiV @candyleer Welcome to join the discussion.

For sure, Zipkin will come first, because we have the old one, need to replace it with the new proposal. Don't get it wrong by the demo yaml above. I just try to avoid confusing with the existing Zipkin receiver settings.

Deliver trace and span storage based on native implementation of Zipkin or Jaeger.

@wu-sheng What means native implementation? Copy their implementation into our project or users deployment both SkyWalking and Zipkin or Jaeger' server?

Maybe, maybe not. The point is I intend don't use our segment table to save this for sure

https://ignite.apache.org

Relationship of service based on the span with RPC info, keep in Redis(or other) cache, set a timer to read and try match. Dispatcher as relation scope when both sides are ready.

Ignite™ is a memory-centric distributed database, caching, and processing platform for
transactional, analytical, and streaming workloads delivering in-memory speeds at petabyte scale

Ignite™ is a memory-centric distributed database, caching, and processing platform for
transactional, analytical, and streaming workloads delivering in-memory speeds at petabyte scale

Yes. Known this, several people have sent this to me several months ago. Maybe it is useful, maybe not. I don't know yet. Especially for this case. Are you proposing to use this as cache?

Yes. Known this, several people have sent this to me several months ago. Maybe it is useful, maybe not. I don't know yet. Especially for this case. Are you proposing to use this as cache?

This is a native memory distributed database and it's an apache project. I prefer to use it.

How many RPC info need to cache is unknown. So, a distributed memory database is a best choice. As far as I know, the solution of Redis cluster is not standby.

Right now, I am focusing on how to make the span analysis ready in production env.
Here are the highlights

Don't wait for the whole traces ready before analysis. Then need to support new trace storage module and query implementation.
Span for client/server side match to build relation scope. Then a timeout mechanism required in backend and cache layer. I guess you are saying, this part could be done by Ignite? If so, maybe YES.

But back to the topic, I have more concerns about other parts. such as,

Do I miss any other thing to make things work?
Do our modulization and switch mechanism cover all requirements?
How to process multiple instrumentations for a single RPC call.
etc.

This biggest proposal here is don't wait for the whole trace.

@wu-sheng Show us some sample Zipkin trace. How to design a no wait analysis system must be base on that.

Show us some sample Zipkin trace. How to design a no wait analysis system must be base on that.

No, I just say wait for the whole trace. I think you misunderstand.
Let's say right now, the whole trace is buffer and waiting, then do the reformat to SkyWalking native trace format, right? Because we want to reuse the process of trace parse codes.
But, actually, we don't really need that based on the new core. We have scope dispatcher now. The only thing needs to wait is RPC related spans, we need the client and server span match to build the relation scopes, right? This part is still waiting, no change and no chance to improve.
In this proposal, other local spans could be passed and saved. Only some RPC related trace id and span id need to buffer in local and do timeout/match (Span info saved in cache for sure, no matter what it is). Also, no need to wait for the whole trace ready, just a pair of RPC spans is ready, the analysis is good to go for this part.

Right now, SkyWalking backend supports traces from Zipkin and Jaeger, saved in their native formats, providing query capabilities from SkyWalking UI.

Trace formats are supported, I would expect to support analysis in the short term. Because no particular committer or contributor wants to work on this.
As, I will remove the milestone and label as TBD.


Toggle Light visuals

Signed-off-by: ahcorde<EMAIL_ADDRESS>🎉 New feature
Summary

Build on top of https://github.com/ignitionrobotics/ign-gazebo/pull/1343
Requires https://github.com/ignitionrobotics/sdformat/pull/877

This allows to enable/disable the visual from lights

Test it
ign gazebo lights.sdf

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1


A way to add arguments to MD_RENDERER

I'd like to customize the call to pandoc, e.g. by using a template:
pandoc --template my_template.md

I tried doing:
export MD_RENDERER="pandoc --template my_template.md"

but it fails for this reason.
Therefore I think an additional option called MD_RENDERER_ARGS could be added (just my first idea, maybe there's a better way).

Sorry for responding after some time, I was rather busy.
I see the problem, I believe that it can be fix with using eval – something like:
diff --git a/ssb b/ssb
index e5186b9..4a6cdc5 100755
--- a/ssb
+++ b/ssb
@@ -304,7 +304,7 @@ make_html_files()
 		# Ignore the suggestion because tempf can be expanded immediately
 		# shellcheck disable=SC2064
 		trap "rm $tempf" 0 2 3 15
-		append_posts_list "$posts" | cat "$md_file" - | "$MD_RENDERER" > "$tempf"
+		append_posts_list "$posts" | cat "$md_file" - | eval "$MD_RENDERER" > "$tempf"
 		cat "$HEADER_PATH" "$tempf" "$FOOTER_PATH" > "$output_file"
 	done
}

I tested it in a very ad hoc way -- seems to work. If you have time you can check out if it works in your scenario, then please let me know.
If it works and you are willing, you can open a PR to the development branch and to the honours.

Thanks! I recall something that eval is an antipattern in shell scripting, but I think your solution would be good enough and a justified use.

Thanks for explaining in more details!

This scenario seems very unlikely for a blogging system used by two people.

Yeah, strong agree.


Merge code from external library

https://github.com/LancasterSolutions/mindbaz-library

Could be done using lancaster-solutions/mindbaz-library

Closing as project is not maintained anymore


exclude products

Please describe the feature.
I am working with a customer who is using APIOps toolkit to enable CI/CD on APIM instances used by multiple teams. It is possible to extract explicit API's using the process described at https://azure.github.io/apiops/apiops/6-supportingIndependentAPITeams/
However they would also like to apply this same process for the extraction of products within an APIM instance. This way they can exactly specify what needs to move to a next environment.

It would make sense to implement this with the existing configuration.extractor.yaml file and support the inclusion of products and tags basides apis? For example just extract the APIs that have the tag GA to avoid promoting things still under development into production.

Either use gitignore for now or wait for worksapaces #274 te become available.


Question about the validity of my data in a PRE_COPY event

Hello,
I want to add checks on the validity of my data in a PRE_COPY event. Specifically, I want to verify if my data has the correct expected format, if there are no null values in any fields, etc. However, I do not understand how the bundle operates when I perform these checks. Should I retrieve the data from the temporary import table, perform my checks on this data, then truncate the table to insert the valid data back into the same table, and finally let the bundle handle the copying?

See my example with valid IS true copy condition in issue https://github.com/le-phare/import-bundle/issues/2. In a POST_LOAD event subscriber you can set the valid boolean to false or true based on your custom logic. A common use case is running SQL queries on your temp table to validate the data. Then let the bundle handle the copying: lines with valid values set to false won't be copied.

Or, can we validate the current occurrence? For example, the bundle checks the first occurrence in the table, then my program checks the same row immediately afterward, and so on until there are no more data to validate. This would save me from having to retrieve all the data and manipulate the import database.

See my example with valid IS true copy condition in issue #2. In a POST_LOAD event subscriber you can set the valid boolean to false or true based on your custom logic. A common use case is running SQL queries on your temp table to validate the data. Then let the bundle handle the copying: lines with valid values set to false won't be copied.

Ok thank you for your answer, so I have an extra_field isValid like this in my configuration :
resources:
  import:
    tablename: scratch.import_file_tmp
    load:
      add_file_line_number: true
      # strategy: https://github.com/le-phare/import-bundle/blob/master/docs/configure/load.md#strategy
      pattern: '.*poke.*'
      format_options:
        with_header: true
        field_delimiter: "\t"
        line_delimiter: "\n"
      fields: # https://github.com/le-phare/import-bundle/blob/master/docs/configure/load.md#:~:text=fields%20et%20extra_fields-,fields,-and%20extra_fields%20have
        NAME: ~
        family: ~
        pv: ~
        pf: ~
        pm: ~
      extra_fields: # https://github.com/le-phare/import-bundle/issues/2
        calcul: integer
        isValid:
          type: boolean
          options:
            default: NULL

    copy:
      target: poke
      strategy: insert # https://github.com/le-phare/import-bundle/blob/master/docs/configure/copy.md#:~:text=MySQL%2C%20PostgreSQL%209.5%2B-,Executes,-an%20UPDATE%20in
      strategy_options:
        copy_condition: isValid IS TRUE
        distinct: true
        conflict_target: name
        non_updateable_fields: ["name"]
      mapping:
        name: name
        family: family
        pv: pv
        pf: pf
        pm: pm

And now, assuming I want to validate my data where the pv field must not be null and it is an integer, how can I do this in my POST_LOAD event? Without considering the possible options in the configuration file such as:
<field_1_name>:
    type: string
    options:
        notnull: false

<?php

namespace App\EventSubscriber;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;

class OnPostLoadSubscriber implements EventSubscriberInterface
{
    public function onImportPostLoad($event): void
    {
        dd($event);
    }

    public static function getSubscribedEvents(): array
    {
        return [
            'import.post_load' => 'onImportPostLoad',
        ];
    }
}

In order to understand the validation logic and enforce my constraints (using Symfony forms, etc.), do I need to retrieve all the data from the table with an SQL query and validate them one by one, ensuring to indicate whether isValid = true or false?

Is it available on MariaDB & MySQL? Because here the prefix pg seems to indicate PostgreSQL... and not on that the other engines propose it.

Is this available on MariaDB & MySQL? Because here, the prefix pg seems to indicate PostgreSQL ... and I'm not sure if the other engines offer it.

I gave you an example in Postgresql but you can use any function available in your DBMS.


Cleanup generated code artifacts

This PR:

Adds a top-line helper comment in generated Source and Dashboard files to point to the (not-yet-written) Rill Code documentation
Removes not-yet-implemented keys from generated Dashboard files
Removes the code comments from generated Dashboard files

It merged in the code from #1382, which is itself pending review.

please include timegrains in this effort.
timegrains — if you remove this property from the yaml it breaks the application. It has no impact on the user experience.


Vim-Plugin YouCompleteMe unavailable: Request Vim Compiled with python (3.6.0+) support

Describe the bug
I am upgrading the 20.03 to 20.09, the YouCompleteMe vim-plugin seems to have some issues. When using vim to edit files, it will pop message:
YouCompleteMe unavailable: requires Vim compiled with Python (3.6.0+) support.
, I tried to change the python with python36, but it does not seem to work.
I am using vim-configurable, and vim ---version outputs:
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Jan 01 1980 00:00:00)
Included patches: 1-1522
Compiled by nixbld
Huge version with GTK3 GUI.  Features included (+) or not (-):
+acl               -farsi             +mouse_sgr         +tag_binary
+arabic            +file_in_path      -mouse_sysmouse    -tag_old_static
+autocmd           +find_in_path      +mouse_urxvt       -tag_any_white
+autochdir         +float             +mouse_xterm       -tcl
-autoservername    +folding           +multi_byte        +termguicolors
+balloon_eval      -footer            +multi_lang        +terminal
+balloon_eval_term +fork()            -mzscheme          +terminfo
+browse            +gettext           +netbeans_intg     +termresponse
++builtin_terms    -hangul_input      +num64             +textobjects
+byte_offset       +iconv             +packages          +textprop
+channel           +insert_expand     +path_extra        +timers
+cindent           +ipv6              -perl              +title
+clientserver      +job               +persistent_undo   +toolbar
+clipboard         +jumplist          +popupwin          +user_commands
+cmdline_compl     +keymap            +postscript        +vartabs
+cmdline_hist      +lambda            +printer           +vertsplit
+cmdline_info      +langmap           +profile           +virtualedit
+comments          +libcall           +python            +visual
+conceal           +linebreak         -python3           +visualextra
+cryptv            +lispindent        +quickfix          +viminfo
+cscope            +listcmds          +reltime           +vreplace
+cursorbind        +localmap          +rightleft         +wildignore
+cursorshape       +lua               +ruby              +wildmenu
+dialog_con_gui    +menu              +scrollbind        +windows
+diff              +mksession         +signs             +writebackup
+digraphs          +modify_fname      +smartindent       +X11
+dnd               +mouse             -sound             -xfontset
-ebcdic            +mouseshape        +spell             +xim
+emacs_tags        +mouse_dec         +startuptime       +xpm
+eval              -mouse_gpm         +statusline        -xsmp
+ex_extra          -mouse_jsbterm     -sun_workshop      +xterm_clipboard
+extra_search      +mouse_netterm     +syntax            -xterm_save
system vimrc file: "$VIM/vimrc"
user vimrc file: "$HOME/.vimrc"
2nd user vimrc file: "~/.vim/vimrc"
user exrc file: "$HOME/.exrc"
system gvimrc file: "$VIM/gvimrc"
user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
defaults file: "$VIMRUNTIME/defaults.vim"
system menu file: "$VIMRUNTIME/menu.vim"
fall-back for $VIM: "
/nix/store/fapbjg2ifazx385pyixdlz2mkhx8szn7-vim_configurable-8.2.1522/share/vim
"
Compilation: see nix-store --read-log /nix/store/fapbjg2ifazx385pyixdlz2mkhx8szn7-vim_configurable-8.2.1522
Linking: see nix-store --read-log /nix/store/fapbjg2ifazx385pyixdlz2mkhx8szn7-vim_configurable-8.2.1522
python --version outputs:
Python 3.6.12
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
these paths will be fetched (0.12 MiB download, 0.51 MiB unpacked):
/nix/store/ajib0wv150ah6nqbkn5b5kwmqldk368y-patchelf-0.12
/nix/store/ajidkqg53y0zvh0m5cjgqiw3pf9cvlf0-bash-interactive-4.4-p23-dev
/nix/store/f95jkch26wxmqd076bcm976qrn7ml46i-stdenv-linux
copying path '/nix/store/ajidkqg53y0zvh0m5cjgqiw3pf9cvlf0-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/ajib0wv150ah6nqbkn5b5kwmqldk368y-patchelf-0.12' from 'https://cache.nixos.org'...
copying path '/nix/store/f95jkch26wxmqd076bcm976qrn7ml46i-stdenv-linux' from 'https://cache.nixos.org'...

system: "x86_64-linux"
host os: Linux 5.4.83, NixOS, 20.09.2290.647cc06986c (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.9
channels(root): "nixos-20.09.2290.647cc06986c"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@jagajaga
@MarcWeber

This appears to be fixed on master through https://github.com/NixOS/nixpkgs/commit/576a9287941b279fff9684013266bf89aeb68a02. Should that commit be backported to stable @dasJ?

I tried to change the python with python36, but it does not seem to work.

What have you tried? This works for me:
(vim_configurable.override {
  python = pkgs.python3;
}).customize {
  # …
}

This appears to be fixed on master through https://github.com/NixOS/nixpkgs/commit/576a9287941b279fff9684013266bf89aeb68a02. Should that commit be backported to stable @dasJ?

I tried to change the python with python36, but it does not seem to work.

What have you tried? This works for me:
(vim_configurable.override {
  python = pkgs.python3;
}).customize {
  # …
}

Oof, I'd rather not have that backported since it breaks Python 2 plugins (if anyone uses them) and while doing so between releases is okay IMO, it's hard to reason that in a backport.

Oof, I'd rather not have that backported since it breaks Python 2 plugins (if anyone uses them) and while doing so between releases is okay IMO, it's hard to reason that in a backport.


Exporting Google Docs -> Markdown Minutes Notes

So I've noticed that the Minutes are usually taken in Google Docs, and that there's only currently one markdown version of the Minutes in the /meetings folder.
At work, I've actually been using a small script I found online to convert Google Docs into Markdown files. I've put the script in a Gist (can't find the original source 🤔), and would be happy to help get people familiar with the workflow.
I'd also be happy to take on this responsibility myself, if that would be helpful!

Nice :). Does the script convert the styles to markdown styles? e.g. does italic convert to _italic_? I think we may end up with double style code if it does convert them. As is, we just need to copy paste the Google Doc straight into the markdown file.

@nebrius Yep, it does convert GDocs styled italics, boldface, etc to Markdown italics. If we already write in markdown style in GDocs, then I don't think it'll be an issue 😁
That said, this may be a useful resource to provide for Teams to use for documentation purposes nevertheless. ❤

I'm going to go ahead and close this, since we don't have any actionable items to accomplish. Thanks again for the post!


Remove redundant concatenation

it's not easy to have a check for this because:
eg https://github.com/prestosql/presto/blob/119efdaf7168a984d912e0a9e0848d4c3822256f/presto-main/src/test/java/io/prestosql/operator/scalar/TestVarbinaryFunctions.java#L75-L76
uses this intentionally (disputable)
naive context-free check would prevent uses like https://github.com/prestosql/presto/blob/ad7a77886d9e0be0bac59cbb1c85fab361a90115/presto-main/src/test/java/io/prestosql/sql/planner/TestLocalExecutionPlanner.java#L51-L52


persist assets over sections of skillsmap

I've been playing around with https://arcade.makecode.com/skillmap.
It would be great if the sprite you created in the first section of Simple Platformer persisted when you move on to the second section. It's a bit of a let-down to see the generic sprite in the second section, especially if you did a bit of work to create your own sprite in the second section.

Tom - maybe should log this in the Arcade repo?  And I think there may already be a bug for it...

sorry. I'll check over there.


Add shader disposal support

Closes #4534
Follows the existing pattern for GL disposal, if a Shader/ShaderPart gets finalised, the 3-frame delay will be applied, but if it's explicitly disposed, then there won't be any delay from the class itself, it would come from whatever's disposing of it internally (the ShaderManager in this case).
Double-checked with osu!lazer master and ppy/osu#13594. Looks to be working as intended.
Also added a simple test case ensuring Shader references aren't leaked after disposing of ShaderManager (which heavily depended on doing https://github.com/ppy/osu-framework/commit/cd36ea3b8608aaa305603c0763c142a2ffd063f9 for testing without GL context, kinda ugly but needed).

Blocking momentarily while I figure out what's causing Shader references to still remain even though the manager is disposed of, scary enough that it happens on a real Shader, not a TestShader (even though the abstraction was meant in a way that doesn't result in differentiation between both classes).

Turns out it was due to the test scene stupidly forces a silent Shader compile before the GLWrapper scheduled one, resulting in compiling twice and registering to GlobalPropertyManager twice.
I have solved that in multiple ways, by:

Guarding in Shader.Compile to never recompile again,
Guarding in GlobalPropertyManager to not add shader twice (not sure if all_shaders should actually exist in the first place, GC purposes?),
And privatizing Shader.Compile, to be replaced with using EnsureShaderCompiled instead (all internally).

I'm not a super big fan of the private protected virtual stuff, but let's go with this for now.

Yeah without doubts, I'm not really sure what's the reason behind making all of them internal, but sounds like they should be separated in some better way, something like Texture and TextureGL maybe, needs investigation at some point.


Update service.md

securityGroupName is the required value when creating LoadBalancer type service in Azure.
I got the following error without securityGroupName value.

Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

/assign heckj

/lgtm from writing's perspective, need tech review.

/assign

/approve


Separate out the compose call.

Useful for when uses are not changing the Wares after composing so it doesn't have to compose on every call to ServeHTTP.

This is a related idea to #8 - just FYI.

Totally agree, apologies as I should have read through the previous issues first before making a PR. Though now reading both, I still think this implementation has merit. Surfacing the compile behavior publicly middleware.Handler() gives the user of the library more control, while being totally backwards compatible for anyone already using the library with the expected behavior of recomposing ever time. It is explicit and less automagical, which I really appreciate as a developer.

I think this PR is an improvement; you don't need to apologize. @carbocation doesn't need to wait for me to review #8 either (just in case that wasn't clear).
I still feel like the empty handler is silly; there's a clever way to get rid of it, but I haven't the time right now to figure it out.
Anyway, +1 on this. :+1:

Am very busy until Sunday, but am looking forward to taking a look. Especially if the changes are less intrusive than my 'compiled' branch, I will happily incorporate this or a derivative into master.


Due to an inconsistent behavior of the OBS API, multibuild variants are listed in the package results.

Due to a bug in the OBS API endpoint (reported here: https://github.com/openSUSE/open-build-service/issues/12925) when explicitly passing deleted=0 in the /sources/<proj> endpoint, the multibuild versions of packages are listed in the results, see this example:
> osc api /source/devel:languages:python:Factory | grep python36
  <entry name="python36"/>

Now if I append deleted=0  to the arguments, the API endpoint lists also multibuild variants:
> osc api /source/devel:languages:python:Factory?deleted=0 | grep python36
  <entry name="python36"/>
  <entry name="python36:base" originpackage="python36"/>
  <entry name="python36:doc" originpackage="python36"/>

Until this gets fixed upstream, it would be nice if osc-tiny could omit the deleted=0 from the API request.

I had reported this already two years ago: https://github.com/openSUSE/open-build-service/issues/9715 :joy:

Given the discussion in this original issue, I would not object to a work around in osc-tiny, but I'm afraid that there is a method to the madness and it would be nice to have a single workaround to catch them all.


error: name 'add_all_ta_features' is not defined

Thanks for sharing this good work. I'm trying to get to know him better. I have found this bug.
`import pandas as pd
import ta
import yfinance as yf
Add ta features filling NaN values
df = yf.download("AAPL", start= '2015-1-4', end = '2021-12-30')
df = ta.utils.dropna(df)
df = add_all_ta_features( df, open="Open", high="High", low="Low", close='Close', volume="Volume", fillna=True)
df`
`---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
/tmp/ipykernel_10246/3945308011.py in
7 df = ta.utils.dropna(df)
8
----> 9 df = add_all_ta_features( df, open="Open", high="High", low="Low", close='Close', volume="Volume", fillna=True)
10 df
NameError: name 'add_all_ta_features' is not defined`
¿What can be the cause?  Thanks in advance.

You are not importing the function.
df = ta.add_all_ta_features(...)

Also, you can import at the first of your script:
from ta import add_all_ta_features


Revise the explanation of the cartridge header (continued)

Follow up of https://github.com/gbdev/pandocs/pull/422

See points in https://github.com/gbdev/pandocs/pull/422#pullrequestreview-1048684969

I incorporated the changes suggested in #422. I also went through the entire document one more time and fixed whatever inconsistencies and such I could find. I squashed all the changes suggested in earlier reviews into a single commit, so there are now 3 commits in this PR: my original commit, the changes suggested in #422 and my latest clean-up commit.
Regarding the supposedly premature merging of the previous PR, I'll point out that I don't think that is a fair assessment as there were in fact no more unaddressed issues at the time @ISSOtm did the merge, so it's hardly his fault.
Regardless, feel free to conduct any further reviewing, but as far as I am concerned this PR is ready for merge.
P.S. I'm not sure if the changes suggested by @ISSOtm in #422 to src/Power_Up_Sequence.md are relevant to this PR, so I did not include those (yet).

I incorporated the changes suggested in https://github.com/gbdev/pandocs/pull/422. I also went through the entire document one more time and fixed whatever inconsistencies and such I could find, as well as fixed the broken links. The changes suggested in earlier reviews have now been squashed into a single commit.
Regarding the supposedly premature merging of the previous PR, I'll point out that I don't think that is a fair assessment as there were in fact no more unaddressed issues at the time @ISSOtm did the merge, so it's hardly his fault.
Regardless, feel free to conduct any further reviewing, but as far as I am concerned this PR is ready for merge.

It looks great now, I guess we just need to revert the - -> — changes, as they also break links..

I suppose you mean that we would have to fix every link that references one of the changed headers? Because I did that, at least to the best of my abilities, by searching for every instance of the old title in the source and replacing it with the new one.
It's no big deal to undo the change if you want me to, but I did my best to make the new titles work as well, so whichever you prefer.

It looks great now, I guess we just need to revert the - -> — changes, as they also break links..

I suppose you mean that we would have to fix every link that references one of the changed headers? Because I did that, at least to the best of my abilities, by searching for every instance of the old title in the source and replacing it with the new one.
It's no big deal to undo the dash change if you want me to, but I did my best to make the new titles work as well, so whichever you prefer. I just thought en dashes looked better, and also it's the correct dash to use in ranges (such as address ranges), so I went for it.

The issue here is that changing dashes changes and breaks all the links outside of our control, and it's a change that should be discussed in a different PR. If we decide to switch to another dash, we should apply that globally to the entire document.
Let's bring back the PR on the scope and open another one to decide about the titles

That's a good point about external links.
Should I undo all other changes in the header titles as well? For example, I changed Mask ROM Version number -> Mask ROM Version Number (to be fair, I think that's the only non-dash change).

Alright, I undid the title changes. Feel free to merge. :)


Fix 685

This will fix #685
I have still two questions:

Should I also update the CHANGELOG.md and README.md as it is just a minor change.
Do you rather want to fix the conda environment packages or leave them with a lower bound? I personally prefer the less stringent way. But could be different for such a pipeline, where stability is in favor.

Best,
Christian

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

I just realized that I probably should update the modules in https://github.com/nf-core/modules and update the json file here: https://github.com/nf-core/rnaseq/blob/master/modules.json
Is this correct? Should I do a PR to both the modules and the rnaseq pipeline?

Yes, please! You would need to update the module and then re-install in the pipeline. Sorry, I am not really working at the mo so may be a bit slow to respond.

@drpatelh I updated the modules. Can you please review it and merge it?
BTW Thank you for the invite! Hope to contribute a bit more in the future through GHGA.


Comments on enum values cause C++ enums to be commented out

If you have an enum definition like this:
foreign_enum!(
    /// Represents the reason a document can be viewed by the requesting user.
    enum AssociationType {
        /// User created the document
        Owner = AssociationType::Owner,
        /// User directly granted access to the document
        FromUser = AssociationType::FromUser,
        /// User granted access to the document via a group they are a member of
        FromGroup = AssociationType::FromGroup,
    }
);

It will create C++ code like this:
//Represents the reason a document can be viewed by the requesting user.
enum AssociationType {
    //User created the documentOwner = 0,
    //User directly granted access to the documentFromUser = 1,
    //User granted access to the document via a group they are a member ofFromGroup = 2

};

I believe this is because https://github.com/Dushistov/rust_swig/blob/master/macroslib/src/cpp/fenum.rs#L109 which puts the comment on the same line. Since the comments don't have an ending, this comments out the entry.

If you have a preferred way you want this fixed I can PR it. Just wanted to get you to weigh in.

If you have a preferred way you want this fixed I can PR it

No preferred way, just test + fix. So I will gladly accept PR.


Can't seem to use type as a property name

My model has a string property called type, however when using make and passing in { type: 'foo' }, I get "Error: No model was found for 'foo'". Is there a workaround to this?

ooo .. that is kind of a weak point.  I was hoping no one would use that as an attribute ( like with rails where they reserve that property name 'type' for use when using polymorphic models.
Do you have to use that property name?  Can you convince the database to change itself real quick? ( joking ) .. but if you can switch that .. it would be easiest ( duh ) .. because I can't think off the top of my head how I am going to change that internally.

I'll see what I can do about changing it. In the meantime hopefully you can come up with a solution :)

@visoft ... there is a solution ( 99% sure ) , but it means you would flag that there are no polymorphic relationships on your models. where you can set a flag in the test environment that looks something like ENV.APP.FACTORY_GUY_NO_POLYMORPHIC_MODELS =  true
to disable that use of the type field in FactoryGuy to determine the type of a model.
Let me know if that would work for you.

That would work awesome.

Version 1.1.0 fixes this issue, and no funny business needed ( ENV.APP.FACTORY_GUY_NO_POLYMORPHIC_MODELS ) just works as is. Thanks for pushing me to fix this @visoft , because it showed me a flaw in my model definitions.


Make base path of endpoints injectable and use  schema +  domain +  baseUrl  as default value

Something like

@Injectable()
export class CareerService {
  constructor(private http: HttpClient, @Inject(URL) baseUrl: string='http://localhost/api/') {}
.....
positions(params: PositionsParams): Observable<object> {
    const pathParams = {
      positionId: params.positionId,
      version: params.version
    }
    return this.http.get<object>(
      `${this.baseUrl}/api/career/v${pathParams.version}/positions/${pathParams.positionId}`
    )
  }

And in def add a file with:
import { InjectionToken } from '@angular/core';
export const URL = new InjectionToken<string>('baseUrl');

@leiserfg, thanks for the idea. Btw, you are welcome to make a PR (incl. docs update demonstrating the usage), if you want to have it done faster.

Currently the ad hoc (env-based) configuration can by done via interceptors, which are typically used also for authentication, e.g.


Get-SFTPFile stalls on large file

When issuing get-SFTPFile for a large file (35GB), the process gets to about 35MB and stalls. I have to close the PD windows as it becomes unresponsive. Is there a setting in the session that may help with this?

No clue there, if you look at the traffic and target file is there activity? (file growing in size and network traffic shown in task manager)

No, there seems to be no activity. I will give it another try. The provider is not me, it is a vendor and they are not allocating much bandwidth to this SFTP connection. (Averages 2.5 Mb/s)

yes, just tried it again, just stops at around 35MB. Powershell command window becomes unresponsive. Powershell process is showing 2% usage every few seconds. I will try from one of my local servers and see if there is a difference.

What is the providers machine? OpenSSH on linux? If so what distro
Sent from my iPhone

On Oct 22, 2019, at 3:53 PM, Clifra-Jones<EMAIL_ADDRESS>wrote:

yes, just tried it again, just stops at around 35MB. Powershell command window becomes unresponsive. Powershell process is showing 2% usage every few seconds. I will try from one of my local servers and see if there is a difference.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

What is the providers machine? OpenSSH on linux? If so what distro
…
Sent from my iPhone
On Oct 22, 2019, at 3:53 PM, Clifra-Jones @.***> wrote:  yes, just tried it again, just stops at around 35MB. Powershell command window becomes unresponsive. Powershell process is showing 2% usage every few seconds. I will try from one of my local servers and see if there is a difference. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

I really do not know. They are one of out software vendors. SFTP shows server version SSH-2.0-2.0

I am also doing research on this topic as I am facing exact same issue. I am working on developing a script to copy file from SFTP server to our another local server using posh-ssh module. I am dealing with 600 MB file and powershell IDE stops at 574 MB. Below is my snippet to copy file.
Get-SFTPFile -LocalPath $localPath -RemoteFile $file.FullName -SessionId $theSession.SessionId -Overwrite
Please suggest something.

Have you tried on the console and not on the “IDE”? I noticed that PS behaves differently in VSCode from PowerShell.exe and same with ISE.

I have the same issue. The remote files have between 400 MB and 6 GB. In our case it's a managed server at domainFACTORY. The download of every file hangs at +-235 MB .

Any specific file? Or is it random?

We pack the webspace into a tar.gz and dump the database into a sql.gz file. Afterwards they will be downloaded with Get-FileSCP. All Files wihch are smaller thant +-234MB are downloaded successfully.

Confused, the issue is for SFTP but the command you reference is SCP, 2 different protocols and sections of the module. So this would be a different issue then, corrected?

i thought perhaps it is the same source of error...

So this would be a different issue then, corrected?
Yes. Can you split it in a new issue or do I have to create one manually?

Could be related but no clue yet. If it is the underlying library not much I can do but will test to definitely know

so far have not been able to replicate I so know that ISE and VSCode consoles suck for this operation causing issues. Bur from powershell.exe I have not been able to replicate, been downloading via SFTP and SCP 2.8 GB in  img files with no issues. Wonder of communication errors or blips could be an issue.

Thanks a lot. So i will open a support ticket at our webhoster.


Bind label to arrow

Original issue raised by @Dcarnik for the Obsidian-Excalidarw plugin (#570)
The arrow/line which connects two figures follows the figure when figure is moved to other position. That is great! We use text to identify the line (for process diagram), like numbers or other text parameters. In case the text is placed next to the line, after moving the figure, the line follows the  figure, yet text stays in same position (see fig. 1, 2)
It would be nice that text moves together with lane (see fig. 3).
The ideal solution. The line/arrow when double clicked allows to add text which is then connected with line/arrow. The line/arrow separates into 2 parts (see fig. 4). In case text manually moved to other position which do not intersects line, the line/arrow's 2 segments become as 1 segment.
Good realization of that was said above at: https://www.diagrams.net/
Thanks.

We are aiming for implementing (4) once time permits (or anyone submits a PR). I think the tracking issue is here: https://github.com/excalidraw/excalidraw/issues/5010 (needs better naming)

would love to see this as well, i was surprised to find it wasn't implemented. very helpful feature.

+1 Very useful feature.

+1

We'll be working in this very soon!

are there any news about this feature?

We're looking into starting to work on it during this week!

Closing as we support labelled arrows with #5723


Improve handling of series file truncation

If only very few chunks are to be truncated from a very large series
file, the rewrite of the file is a lorge overhead. With this change, a
certain ratio of the file has to be dropped to make it happen. While
only causing disk overhead at about the same ratio (by default 10%),
it will cut down I/O by a lot in above scenario.
@fabxc @matthiasr
Fixes https://github.com/prometheus/prometheus/issues/1296

:+1: sort of hesitant to put a storage change into a bug fix release that won't have an beta or RC.
But this is fairly minor. Your call whether this should make it into 0.16.2

I'd like to let it bake for a day with our MySQL Prometheus (which is heavily purging right now). If we have enough time for that, then let's get it into 16.2.
(This is one of the improvements that are simple but effective, and I feel dumb that I didn't think about it from the beginning. So getting it in ASAP will reduce my embarrassment.)


Strengthen the relationship between scalaJSModuleIdentifier and ModuleKind

By coupling the information on the module identifier with the actual module kind we avoid runtime checks.

I'm not sure about this one. I considered doing something like that initially, but it requires duplicating the entire ModuleKind alternatives in a new data structure. And that means specific code to translate from one to the other, etc.
It is not clear to me that it improves the situation. I need to think more about it.


Support multiple tokens with destRowTemplate

We needed a file list where the filename appears more than once but String.prototype.replace only does that for the first occurrence. Turning it into a regex with the global flag fixes this. Test included.

This looks good, sorry for the very delayed reply. Thanks so much for contributing!


Update azure-vmware-solution-platform-updates.md

@rosydutt22 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@rosydutt22 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


1.68.0 libSkiaSharp not copied when published WPF

Description
When running this project in debug or release, behavior is as expected. When published, libSkiaSharp.dll is nowhere to be found. I've tried all solutions I could find on github but none seemed to work. I'm using the NuGet package.
Code
Code included in zip.
Expected Behavior
On launch, the application creates a pdf on your desktop with two pages, both stating ...PDF...
Then it displays a window plotting a red rectangle.
When the window is closed, the pdf is deleted.
Actual Behavior
An exception is caught and displayed in a messagebox: "Unable to load DLL 'libSkiaSharp': The specified module could not be found. (Exception from HRESULT: 0x8007007E).
After clicking OK on the messagebox, the window is shown with the red rectangle. The file is never created.
Basic Information

Version with issue:  1.68.0
Last known good version:  -
IDE: Visual Studio
Platform Target Frameworks:

WPF: 4.7.1

Target Devices:

Windows desktop

WpfApp1.zip

Closing this as a duplicate of #1327

Fixed in #1342 and on the preview feed as v2.80.0-preview.20


Add model.json for Sonos Play:3

Streamed 'Pink noise' from https://www.genelec.com/audio-test-signals and measured with TP-Link KP115 (Kasa) using Docker container; manual mute/zero volume measurement.

I may need a little help with the model/alias(es), as my Sonos Play:3 is not matching with the model.json that I created.  Possibly because of the colon in the model name?

This error originated from a custom integration.

Logger: custom_components.powercalc.sensors.power
Source: custom_components/powercalc/sensors/power.py:94
Integration: Powercalc (documentation, issues)
First occurred: 12:18:24 PM (2 occurrences)
Last logged: 12:18:24 PM

media_player.office_sonos: Skipping sensor setup Model not found in library (manufacturer: Sonos, model: Play:3)
media_player.office_sonos: Skipping sensor setup: Model not found in library (manufacturer: Sonos, model: Play:3)


Create a treeview for the grid data

How about some implementation like this: https://github.com/valor-software/ng2-tree

Looks like a good option, I will review


点击同步，闪退

OS:Win11
Browser:Edge 97.0.1072.69

There is too little information (even "actual behavior" was not described), but it may be related to #187.


What is the invisible 24x24 path used for?

I've noticed there's always a <path fill="none" d="M0 0h24v24H0z"/> path inside every icon, but I couldn't find any documentation mentioning why it's there or what it's used for.
It seems redundant since the viewBox="0 0 24 24" already sets the size, but I was wondering if it serves some other sort of functionality I'm not aware of?

Thank you for your question.
The path <path fill="none" d="M0 0h24v24H0z"/> is a 2424 rectangle.
This is made for designers. Designers can get a 2424 icon with paddings when they insert our icons.
With uniform-size icons, designers can easily manage and align their icons and elements.
With the path, all icons are visually aligned.

If the path puzzled you in your projects, we could talk about it.

@xiaochunjimmy Ahh okay, so they exist for development use and don't have a use in production? Would it be safe to trim out the path with optimisation tools such as svgo when deploying assets to production?

Our icons are compressed by svgo, svgo will not trim the paths we intentionally draw.
You mean remove the path when convert icons into fonts?


AttributeError: 'DuneClient' object has no attribute 'get_latest_result'

Hi, new error I started seeing today. get_latest_result started retuning that it doesn't exist: AttributeError: 'DuneClient' object has no attribute 'get_latest_result'
Not sure if it'a local environment thing or not.
Example implementation: https://github.com/ethereum-optimism/op-analytics/blob/main/contracts_tracking/test_get_result.ipynb
Query result in Dune: https://dune.com/queries/2457627
I'm on version 1.1.1

Hey @MSilb7
Please show the output of pip show dune_client / pip3 show dune_client

Yeah it must be local. I use it in a github action, and it was fine. Locally:
pip show dune_client:
pip show dune_client
Name: dune-client
Version: 1.1.1
Summary: A simple framework for interacting with Dune Analytics official API service.
Home-page: https://github.com/cowprotocol/dune-client
Author: Benjamin H. Smith
Author-email<EMAIL_ADDRESS>License: Apache License Version 2.0
Location: /Users/michaelsilberling/opt/anaconda3/lib/python3.9/site-packages
Requires: aiohttp, ndjson, python-dateutil, requests, types-python-dateutil, types-PyYAML, types-requests, web3

Yeah it's 100% a local thing. My conda environment says I have version 1.1.1, but when I print the version in my notebook, it shows 0.3.0 . I'll let you all know how I resolve it, thanks for checking!

Ok resolved it.  So my conda environment had version 0.3.0.
I actived my conda environment, upgraded, and not it works.
Resolved, closing. Big fan of dune-client haha.

Glad it's all good! Have fun Dune-ing


Failed to synchronize tags to release in SyncMirror with error: "pushUpdateAddTag: GetTag: Length must be 40:"

Feature Description
In gitea.log I see sometimes:
==> gitea.log <==
2022/03/09 12:06:37 ...irror/mirror_pull.go:261:runSync() [E] Failed to synchronize tags to releases for repository: pushUpdateAddTag: GetTag: Length must be 40:
        /source/services/mirror/mirror_pull.go:261 (0x1cdf3b8)
        /source/services/mirror/mirror_pull.go:376 (0x1ce10b8)
        /source/services/mirror/mirror.go:42 (0x1cdb344)
        /source/services/mirror/mirror.go:144 (0x1cdbe31)
        /source/modules/queue/unique_queue_channel.go:76 (0x14954b6)
        /source/modules/queue/workerpool.go:437 (0x149e1c5)
        /source/modules/queue/workerpool.go:280 (0x149d096)
        /usr/local/go/src/runtime/asm_amd64.s:1581 (0x471520)

But you can't see:

which project
which tag?
how long is it?

Screenshots
No response

You have to tell us what version of Gitea you're reporting from.
Assuming you're using 1.16 - you can add a trace logger for the services/mirror as I have previously explained which will add significant amounts of tracing.
How to add trace logging for services/mirror
You can adjust your ini like this:
[log]
MODE=console, traceconsole
...

[log.traceconsole]
MODE=console
LEVEL=trace
EXPRESSION=services/mirror

Or you can run gitea manager logging add console -n traceconsole -l trace -e "services/mirror"
You can use a file logger too. Look at gitea manager logging add --help gitea manager logging add file --help

This is an interesting case. The error is coming from within:
https://github.com/go-gitea/gitea/blob/2448c5ad8b82eb06ec63bcc9c696d380b35ea97c/modules/repository/repo.go#L293-L295
The error string indicates that the ID it is trying to look for is actually an empty string but that doesn't make any sense at all.
I've created another PR to further improve the logging here, but if you add the tracelogger as above we can find out what is special about the repo that is causing this.

I'm using 1.16.3.

@zeripath some log examples
Repo-URL: https://github.com/ballerina-platform/module-ballerina-cache
2022/03/10 08:50:08 ...irror/mirror_pull.go:356:SyncPullMirror() [T] SyncMirrors [repo_id: 6354]
2022/03/10 08:50:08 ...irror/mirror_pull.go:375:SyncPullMirror() [T] SyncMirrors [repo: 6354:ballerina-platform/module-ballerina-cache]: Running Sync
2022/03/10 08:50:08 ...irror/mirror_pull.go:190:runSync() [T] SyncMirrors [repo: 6354:ballerina-platform/module-ballerina-cache]: running git remote update...

==> gitea.log <==
2022/03/10 08:50:09 ...age_stats_nogogit.go:86:func2() [E] Unable to open checker for 11d0f5d34c7e8287afa5724c0e4b907a00ebe573. Error: failed to run attr-check. Error: context canceled
        Stderr:
        /source/modules/git/repo_language_stats_nogogit.go:86 (0xaeef8f)
        /usr/local/go/src/runtime/asm_amd64.s:1581 (0x471520)

Repo-URL:  https://github.com/hendisantika/spring-boot-paypal
2022/03/10 08:49:53 ...irror/mirror_pull.go:356:SyncPullMirror() [T] SyncMirrors [repo_id: 6417]
2022/03/10 08:49:53 ...irror/mirror_pull.go:375:SyncPullMirror() [T] SyncMirrors [repo: 6417:hendisantika/spring-boot-paypal]: Running Sync
2022/03/10 08:49:53 ...irror/mirror_pull.go:190:runSync() [T] SyncMirrors [repo: 6417:hendisantika/spring-boot-paypal]: running git remote update...

==> gitea.log <==
2022/03/10 08:49:53 ...age_stats_nogogit.go:86:func2() [E] Unable to open checker for cf898a8c2e397c699e5e65b8ffa060883532eb1a. Error: failed to run attr-check. Error: context canceled
        Stderr:
        /source/modules/git/repo_language_stats_nogogit.go:86 (0xaeef8f)
        /usr/local/go/src/runtime/asm_amd64.s:1581 (0x471520)

Repo-URL: https://github.com/ballerina-platform/ballerina-standard-library
2022/03/10 08:49:53 ...irror/mirror_pull.go:356:SyncPullMirror() [T] SyncMirrors [repo_id: 6330]
2022/03/10 08:49:53 ...irror/mirror_pull.go:375:SyncPullMirror() [T] SyncMirrors [repo: 6330:ballerina-platform/ballerina-standard-library]: Running Sync
2022/03/10 08:49:53 ...irror/mirror_pull.go:190:runSync() [T] SyncMirrors [repo: 6330:ballerina-platform/ballerina-standard-library]: running git remote update...

==> gitea.log <==
2022/03/10 08:49:53 ...age_stats_nogogit.go:86:func2() [E] Unable to open checker for a5f1ab1c2af1bb0866438c793c390062bf0e39ec. Error: failed to run attr-check. Error: context canceled
        Stderr:
        /source/modules/git/repo_language_stats_nogogit.go:86 (0xaeef8f)
        /usr/local/go/src/runtime/asm_amd64.s:1581 (0x471520)

Unable to open checker for a5f1ab1c2af1bb0866438c793c390062bf0e39ec. Error: failed to run attr-check. Error: context canceled

Ignore these. They are nothing to do with your initial report. They are incorrectly being reported as an error when they're normal.

Unable to open checker for a5f1ab1c2af1bb0866438c793c390062bf0e39ec. Error: failed to run attr-check. Error: context canceled

Ignore these. They are nothing to do with your initial report. They are incorrectly being reported as an error when they're normal. PRs to fix them have already been merged and I recently closed a duplicate issue you opened about these.

Sorry. Wrong post.

I got this error on run "Garbage-Collection" cron. I will start it again.

@zeripath I got this
2022/03/24 02:07:27 ...irror/mirror_pull.go:261:runSync() [E] SyncMirrors [repo: 225:games/triplea]: failed to synchronize tags to releases: unable to PushUpdateAddTag: "2.0.17694" to Repo[225:games/triplea]: unable to GetTag: Length must be 40:
        /source/services/mirror/mirror_pull.go:261 (0x1d49ddc)
        /source/services/mirror/mirror_pull.go:376 (0x1d4bc4d)
        /source/services/mirror/mirror.go:46 (0x1d45cb5)
        /source/services/mirror/mirror.go:148 (0x1d467d1)
        /source/modules/queue/unique_queue_channel.go:76 (0x14ffd76)
        /source/modules/queue/workerpool.go:406 (0x150863a)
        /source/modules/queue/workerpool.go:280 (0x1507956)
        /usr/local/go/src/runtime/asm_amd64.s:1581 (0x471520)

repo: https://github.com/triplea-game/triplea

Sorry I missed your response.
Let's break down the log message
2022/03/24 02:07:27 ...irror/mirror_pull.go:261:runSync() [E] SyncMirrors [repo: 225:games/triplea]: failed to synchronize tags to releases: unable to PushUpdateAddTag: "2.0.17694" to Repo[225:games/triplea]: unable to GetTag: Length must be 40:

In repo with ID: 225 which has the path games/triplea and would therefore be GITEA_REPOSITORY_ROOT/games/triplea.git whilst PushUpdateAddTag was trying to work it tried to push the tag 2.0.17694 but the tag was not found.
So...
Does that tag exist in that repository?

@zeripath I don't know. But the error happens during mirror update cron.
My local mirror:

GutHub repo:
https://github.com/triplea-game/triplea/tags?after=2.0.17751

What are the results of:
git show-ref --tags | grep 2.0.17694

git show-ref --tags -- 2.0.17694

$ git show-ref --tags | grep 2.0.17694
ef59fccf7e34a7f036829d2fdc4f5e09006ddb78 refs/tags/2.0.17694

$ git show-ref --tags -- 2.0.17694
ef59fccf7e34a7f036829d2fdc4f5e09006ddb78 refs/tags/2.0.17694

This is on the gitea repository on the server right?

I started new mirror and got this:
==> gitea.log <==
2022/03/27 21:37:54 ...s/repository/repo.go:146:MigrateRepositoryGitData() [E] Failed to synchronize tags to releases for repository: unable to PushUpdateAddTag: "<IP_ADDRESS>.9102" to Repo[10988:gitea_admin/triplea]: unable to GetTag: Length must be 40:
        /source/modules/repository/repo.go:146 (0x14fea5f)
        /source/services/migrations/gitea_uploader.go:116 (0x1dcb0b5)
        /source/services/migrations/migrate.go:201 (0x1de2f6c)
        /source/services/migrations/migrate.go:129 (0x1de2579)
        /source/services/task/migrate.go:112 (0x1e898f5)
        /source/services/task/task.go:33 (0x1e8a7a4)
        /source/services/task/task.go:55 (0x1e8aa6f)
        /source/modules/queue/workerpool.go:445 (0x1607ade)
        /source/modules/queue/workerpool.go:280 (0x1606c16)
        /usr/local/go/src/runtime/asm_amd64.s:1571 (0x46ffe0)

This is on the gitea repository on the server right?

[So Mär 27][21:39:55][git]@[nuc-mini-celeron]:[~/data/repositories/games/triplea.git]$ git show-ref --tags | grep 2.0.17694
ef59fccf7e34a7f036829d2fdc4f5e09006ddb78 refs/tags/2.0.17694
[So Mär 27][21:40:19][git]@[nuc-mini-celeron]:[~/data/repositories/games/triplea.git]$ git show-ref --tags | grep 2.0.17694
ef59fccf7e34a7f036829d2fdc4f5e09006ddb78 refs/tags/2.0.17694

Pull and build #19236 and see if the problem still happens.

The second line there is not right they are not supposed to be the same it should be git show-ref --tags -- 2.0.17694 .

However, I don't understand what is happening here.
The ref is being listed by git show-ref --tags but then when we try to use git show-ref --tags -- TAG_NAME it doesn't work.
I dunno.
I've got a patch that tries to avoid the second show-ref so I guess we try that?

Pull and build #19236 and see if the problem still happens.

I can't do this on my gite instance.
Can you check this on https://try.gitea.io/ ?

The second line there is not right they are not supposed to be the same it should be git show-ref --tags -- 2.0.17694 .

wrong copy & paste
So Mär 27][22:05:49][git]@[nuc-mini-celeron]:[~/data/repositories/games/triplea.git]$ git show-ref --tags -- 2.0.17694
ef59fccf7e34a7f036829d2fdc4f5e09006ddb78 refs/tags/2.0.17694

Pull and build #19236 and see if the problem still happens.

I can't do this on my gite instance.
Can you check this on https://try.gitea.io/ ?

If I could replicate your issue I would have done so myself and I wouldn't have asked.
"I can't do this on my gitea instance" does not make sense. You have already determined that this is a bug of significant importance to you and your workflow. Running a small patch temporarily in order to test if a bug fix works, resolves or helps to explain your problem further cannot therefore break your instance further.
Honestly it's like working blindfolded in the dark and it's deeply infuriating - it unnecessarily delays the resolution of your issues and leads to these months long issue threads where I or others attempt to fix the problems that affect you - often unsuccessfully and if the issue is ever fixed it is because someone else has finally managed to replicate or reported the problem in a different way and has tested a bug fix.
Having just managed to successfully migrate https://github.com/triplea-game/triplea locally - I can see a number of potential issues with the code - not least that it is repeatedly calling git commands instead of reusing the open cat-files. This may be a cause of fd exhaustion so I guess I will take a look at reducing that and will continue to work on #19236 as an efficiency improvement.
However, if you are unwilling to try patches - I am afraid I don't know what to do.
PushAddUpdateTag only runs on tags which have been emitted by git show-ref --tags first. The error you receive indicates that a subsequent git show-ref --tags -- TAGNAME is then returning no id. How this could happen I don't know and it doesn't make sense to me. I guess all I can say is I will have a think and will comment again if again comes to me.

@zeripath I don't want test unofficial release on my private prod instance. This is the main relason.

However, if you are unwilling to try patches - I am afraid I don't know what to do.

Hm ... you are developing software or fixes without testing them? In this case you have to add new mirror and check the log.
But it's ok. I will check it on other computer. But not today.
I need some infos:

should I compile the 1.16 branch? If not, which commit is it?
how to compile it for PostgreSQL? I'm not working with go.
which go version I need?

However, if you are unwilling to try patches - I am afraid I don't know what to do.

Hm ... you are developing software or fixes without testing them? In this case you have to add new mirror and check the log.

As I said - I am unable to replicate your problem on my testing machine.
I do not know why but the code works for me.

I need some infos:

should I compile the 1.16 branch? If not, which commit is it?

#19236 is the attempted fix PR backported to v1.16. Its branch name is backport-19235-v1.16 on my fork zeripath/gitea.git
The github ssh url is therefore git@github.com:zeripath/gitea
If you have the gh github cli tool:
gh pr checkout 19235

if you have a clone of the gitea repo you can either add my fork as a remote or use fetch to get the branch.
git fetch git@github.com:zeripath/gitea.git backport-19236-v1.16:backport-19236-v1.16
git checkout backport-19236-v1.16
make vendor

how to compile it for PostgreSQL? I'm not working with go.

TAGS="bindata sqlite sqlite_unlock_notify" make

You will need also need Node.js LTS

which go version I need?

It is probably best to just get 1.18

hm ... I try this. My system is optimized for Java development.
It's possible to compile the code with go in docker?
docker run --rm -i -t -v $PWD:/v -w /v golang:1.18 make
Or you can attach an gitea-1.16.x-linux-amd64 to the ticket?

My instance for testing hat at the moment problem with
2022/03/28 21:56:04 ...ervices/task/task.go:56:handle() [E] Run task failed: pq: doppelter Schlüsselwert verletzt Unique-Constraint »topic_pkey«
        /source/services/task/task.go:56 (0x1e8aa75)
        /source/modules/queue/workerpool.go:445 (0x1607ade)
        /source/modules/queue/workerpool.go:280 (0x1606c16)
        /usr/local/go/src/runtime/asm_amd64.s:1571 (0x46ffe0)

I updated this

from gitea-1.14.5-linux-amd64
to gitea-1.15.11-linux-amd64
to gitea-1.16.5-linux-amd64

gitea doctor recreate-table topic

I've managed to hopefully create a docker image at https://eldritchkitty.com/~andrew/backport-19235-v1.16.tar.gz

I can't reproduce the problem on my 2nd gitea 1.16.5 instance. Strange.

I've managed to hopefully create a docker image at https://eldritchkitty.com/~andrew/backport-19235-v1.16.tar.gz

thx.


Mobs attacking task - shooting projectiles and close-range melee attacks

Ignore this issue, it was opened by mistake.


Updating to include Tekton installtion

Without this, students trying this tutorial will get:
error: unable to recognize "task.yaml": no matches for kind "Task" in version "tekton.dev/v1alpha1"

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot I signed it!

HI @vdemeester @dlorenc pls let me know if any action item pending from me. Thanks

/ok-to-test

Absolutely! The Hello World Tutorial can be seen as a stand-alone guide from a student perspective and this guide does not contain the step on installing Tekton. Is your recommendation more on adding a link to https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines rather than hardcoding the kubectl command?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Scott<EMAIL_ADDRESS>Sent: Thursday, February 6, 2020 3:26:34 PM
To: tektoncd/pipeline<EMAIL_ADDRESS>Cc: Dewan Ahmed<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [tektoncd/pipeline] Updating to include Tekton installtion (#2012)
@sbwsg commented on this pull request.

In docs/tutorial.mdhttps://github.com/tektoncd/pipeline/pull/2012#discussion_r376063585:

@@ -9,7 +9,11 @@ This tutorial will walk you through creating and running some simple

Creating a hello world Task
Creating a hello world Pipeline

-Before starting this tutorial, please install the Tekton CLI.
+Before starting this tutorial, please install the Tekton CLI and install the latest Tekton release by the following command:
Instead of hard-coding the kubectl command here, how about linking to the install doc we have for tekton at ./install.md? The user might need to go through the steps of setting up a cluster as well before starting the tutorial and that would be covered by linking to the existing install doc.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/tektoncd/pipeline/pull/2012?email_source=notifications&email_token=AHJPZLPKCNCPADQRRTGKVVLRBRW7VA5CNFSM4KRBSCYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUSQNNA#pullrequestreview-354748084, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJPZLLVLDOW5IRSCGII5QDRBRW7VANCNFSM4KRBSCYA.

Is your recommendation more on adding a link to https://github.com/tektoncd/pipeline/blob/master/docs/install.md#installing-tekton-pipelines rather than hardcoding the kubectl command?

Yeah that would be great, thank you!

@sbwsg Is there an action item on me for tide Pending — Not mergeable. Needs approved, lgtm labels. ?

Please update your PR to include the link instead of hard-coding the kubectl command.  Once that is done I will approve and lgtm and the PR will be merged.  Many thanks!

/lgtm
/approve


External datasets

Add external datasets option
Allow for "external" datasets to go into the registry, i.e., those that do not have their data managed by the registry but we still want to have them entered and be queryable.
These behave just like the dummy datasets from before.
I've added a locale column for the dataset table which can be "onsite", "external" or "dummy". I've also added a url and contact_email column. If the dataset is "external" either a url or contact_email must be entered. Beyond that the external and dummy datasets operate the same way.
Thoughts/todos

There was previously an is_external_link option in the dataset table. I guess this was a similar idea, redundant now?
Executions also have a locale entry. Do we want to change this name? or change the dataset locale to something else, so that they don't get confused?
Add CI test for external dataset entry (might wait for test refactor PR merge before doing this)
Is url and contact_email the extra columns we want, and the behavior that one is mandatory?
Add an example in the docs

In response to your first point - I think the idea for is_external_link was that there would still be an entry under the root directory, but it would just be a symlink. Probably the new formulation supersedes this so we can get rid of is_external_link.

About the field locale - I do think it will be confusing to use the same word for different concepts. For the execution table it really means site, as in computing facility. I'm leaning slightly towards changing execution.locale to execution.site. For the new dataset column, it's more like kind of location.  We could call it location_type (a bit clunky but clear) or maybe come up with a better synonym.

Concerning

Is url and contact_email the extra columns we want, and the behavior that one is mandatory?

I think so; at least I don't currently have any better ideas.


Move discovery stuff to separate file

As promised :camel: :camel: :camel: :camel: :camel: :camel: :camel: :camel: :camel:

Github doesn't make it easy to review things when they're moved into a different file, but assuming there weren't significant code changes, this looks good to me!


Scanner not detecting QR codes after view switch

Describe the bug
Hi, I am working on a MAUI project and have installed the latest package version. The first time I enter the view, the scanner works as expected. I can do multiple scans and it is super fast, yeah! When I navigate away from the view and return to the view after a while, the scanner view is shown correctly and I can see the output from the camera, but no QR codes are detected.
It looks like my view model is not disposed. Any suggestions on how to dispose of the scanner correctly?
To Reproduce
Steps to reproduce the behavior:

Create a view and a view model
Open the view and verify that the scanner works as expected
Navigate to another view
Navigate back to the scanner view
Observe

Expected behavior
QR code
Screenshots
None
Smartphone (please complete the following information):

Google Pixel 6
Android 12
Version Maui v<IP_ADDRESS>-pre]

Closing this one. The description is not correct - the view was registered as a singleton...


Testing

The library needs in depth testing for being relyable
and "serious" enough to be published. The following is a list of
priorities, of modules that should be covered by tests:

Static reflection API:

Function, Field, Class, Enum. Most of this classes are just
bridges to the generated code, so it's hard to add tests there. At least
Enum has some functionality (fromString()/toString()) that needs to be
tested.

At least black-box test the API for occurrencesof types, members, missing fields,
etc. Check that the API gives right data from a given source.

Dynamic reflection runtime:

Unit test Type: Registration, data, etc.
Unit test Object.
Unit test Object manipulation: Function invocation, assignment, etc.
Unit test Object pool. Consider a more relyable pool implementation (Ahem @foonathan).
Unit test automatic data registration: By default runtime dynamic reflection data should match
that collected by static reflection API.

And more, and more, and moooooooore things need testing. I should be doing like a true TDD fan, writing tests first. Meanwhile, yes, having features not covered by tests is considered a bug.


Can't find info on machine.conf file considering deployment of ADO.NET providers

Is there a particular best practice on locking the file for editing while installing our in-house ADO.NET provider?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3b87e17b-2c03-c2cd-b821-66d96ffc0616
Version Independent ID: 74ab8406-068b-38d0-8948-39a93e4e3b1f
Content: Deploying the .NET Framework and Applications
Content Source: docs/framework/deployment/index.md
Product: dotnet-framework
GitHub Login: @mairaw
Microsoft Alias: mairaw

Hello!
Sorry to say, but this article is not the right place to ask that question. I think you will have a better chance of getting your question answered if you post it on a forum such as StackOverflow.
I'm going to close the issue.
Thanks.


Update README document for MOP

document which MQTT protocol that MOP supports
Add a roadmap there

This is done

https://github.com/streamnative/mop


fix: trim slashes from dest when flatten false; add support to ../

This PR addresses https://github.com/sapphi-red/vite-plugin-static-copy/issues/46

it removes ../ from dir so dest reliably replaces the first folder in the path on .split('/')[0]
it trims slashes from the path so destDir doesn't end up in the root folder

My fork was behind, I tried to sync it, but the comparision with the main repo was showing changes in test files, which I didn't author and were probably out-of-date. I tried to fix it, which created unwanted extra commits and when trying to clean up the git history things got really messy. I'd rather close this PR now and perhaps submit a new one starting from a fresh fork.


Crash on PhantomJS 1.9.7 during remote debugging

While remote debugging, it crashed with the attached stack trace (top says "Crash address: 0x8").
I have converted it with minidump_stackwalk.

Please upgrade to PhantomJS 2. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2 version.


Missing issues?

It seems not to  get all open issues, is there an age cut off?

No there's none. It doesn't show Pull Requests by default, but if you press p then they appear.
Which repository did you test?

On 28.03.2016, at 10:02, plaindocs<EMAIL_ADDRESS>wrote:
It seems not to get all open issues, is there an age cut off?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

https://github.com/travis-ci/docs-travis-ci-com/
Last one I see is 388


Syntax error in webb.py for Python 3+

In webb.py
print url exists print without parenthesis is not supported in Python 3+.
It should be print (url)

I have the same issue.
Traceback (most recent call last):
  File "13_rpi_web_crawl.py", line 1, in <module>
    from webb import webb
  File "D:\Miniconda3\envs\test\lib\site-packages\webb\webb.py", line 213
    print url

After looking into webb.py,  actually you can fix it by adding the bracket around "url" at line 213
# from
print url
# to
print (url)

My guess is that the author missed this one while transitioning to Python 3.

Guessing this lib is abandoned?

I have the same issue.
Traceback (most recent call last):
  File "13_rpi_web_crawl.py", line 1, in <module>
    from webb import webb
  File "D:\Miniconda3\envs\test\lib\site-packages\webb\webb.py", line 213
    print url

After looking into webb.py, actually you can fix it by adding the bracket around "url" at line 213
# from
print url
# to
print (url)

My guess is that the author missed this one while transitioning to Python 3.

The fix entails using parentheses, e.g., print("text to print to stdout"), not brackets []


Can't install on Laravel 7

There is an error when installing on Laravel 7:
Problem 1
    - Conclusion: remove nesbot/carbon 2.31.0
    - Conclusion: don't install nesbot/carbon 2.31.0
    - pragmarx/ia-collection v5.5.33 requires nesbot/carbon ~1.20 ->

laravel-shift

not working for me as well..

I also have issues installing this on laravel 7

Opened 20 days ago, no response, all for a simple change in the composer.json of another required package. Guess we'll have to fork 4 different packages in order to make this work...

@pixelplant gonna use your forks for now, thanks :)

@Skullbock
You'd also need to define all the other repos in your project's composer.json
"repositories":[
        {
            "type": "vcs",
            "url": "https://github.com/pixelplant/countries-laravel.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/pixelplant/coollection.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/pixelplant/countries.git"
        },
        {
            "type": "vcs",
            "url": "https://github.com/pixelplant/ia-arr.git"
        }
    ],

It still wouldn't work though because of all the other dependencies in the other projects. To be honest we only use the countries list and in 1 place only so we'll completely remove this package from our list and create a table and model that holds this data, this way we remove a whole bunch of dependencies for our project.

@pixelplant yeah i did exactly that and still didn't work.
Unfortunate though. I hoped to PR the fix here but it seems the dependency tree is just to messy.
Thanks anyway

@pixelplant , You went all the way down to create a lot of forks to fix it, but I don't see any Pull Requests to fix those packages, sorry, but why?
Updating them to really work with everything for whole ecosystem is not as simple as bumping some versions on composer.json.
Take a look at these commits:
https://github.com/antonioribeiro/ia-collection/commits/master
https://github.com/antonioribeiro/ia-str/commits/master
https://github.com/antonioribeiro/ia-arr/commits/master
https://github.com/antonioribeiro/coollection/commits/master
But it's done.
Thank you.