user/serviceaccount/groups impersonation fails

Bug description
While working with flux and the multitenancy setup flux is not able to impersonate the service account which is tenant owner.
It fails with
timeout waiting for: [Namespace/test-hola status: 'Unknown': namespaces is forbidden: User "system:serviceaccount:test-home:gitops-reconciler" cannot list resource "namespaces" in API group "" at the cluster scope: Azure does not have opinion for this user.]
How to reproduce
Deploying a kind cluster and using https://github.com/ppodevlabs/capsule-gitops-testing should reproduce the issue where the test-hola namespace is created but the kustomization is stuck due to the above error.
Expected behavior
the namespace should be created and the service account should be able to list namespaces.
Logs
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:33.373Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:35.374Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:37.376Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:39.376Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:41.375Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:43.378Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:45.372Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:47.375Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:49.380Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}
capsule-proxy-bb55f97b6-m7w4p capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:41:51.374Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}

As you can see in the logs the groups are empty, which makes capsule not to work.
Additional context

Capsule-Proxy version: v0.4.6
Helm Chart version: 0.5.1
Kubernetes version: tested on 1.26.3 and 1.27

While checking with @maxgio92, i figured out that if i use version clastix/capsule-proxy:v0.4.4 it works perfectly
capsule-proxy-59b7b6cfc8-jqblk capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:24:47.026Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":["system:serviceaccounts","system:serviceaccounts:test-home","system:authenticated"],"uri":"/apis/kustomize.toolkit.fluxcd.io/v1/namespaces/test-home/kustomizations/namespaces"}
capsule-proxy-59b7b6cfc8-jqblk capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:24:47.046Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":["system:serviceaccounts","system:serviceaccounts:test-home","system:authenticated"],"uri":"/apis/kustomize.toolkit.fluxcd.io/v1/namespaces/test-home/kustomizations/namespaces"}
capsule-proxy-59b7b6cfc8-jqblk capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T11:24:49.633Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":["system:serviceaccounts","system:serviceaccounts:test-home","system:authenticated"],"uri":"/api/v1"}

groups are filled in and it is able to reconcile the kustomization

Hi @ppodevlabs,
thank you for time spent documenting this.
We'll work on that - actually, we should already have a patch to fix it.
@prometherion would you agree assigning this issue to me?
Thank you all

I was able to reproduce the issue @ppodevlabs, by bootstrapping your simplified scenario: https://github.com/maxgio92/capsule-gitops-testing/, and explicitly setting the version v0.4.6.
Indeed, using the SA gitops-reconciler Tenant owner, the requests to Capsule Proxy appear as below:
capsule-proxy-5f6968fcc4-w58bq capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T20:28:23.454Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":[],"uri":"/api/v1/namespaces"}

without the require Capsule group (i.e. system:serviceaccounts:test-home).
By testing the version built from #350, I'm able to make Flux apply the Tenant Kustomizations, because the impersonate groups now appear in the request:
capsule-proxy-65bcdc9c8-4xmx2 capsule-proxy {"level":"Level(-4)","ts":"2023-11-30T20:45:56.337Z","logger":"proxy","msg":"impersonating for the current request","username":"system:serviceaccount:test-home:gitops-reconciler","groups":["system:serviceaccounts","system:serviceaccounts:test-home"],"uri":"/api/v1/namespaces/test-hola"}

Thanks also to @prometherion for the debug done together.

Hello. I tried the image v0.5.0 and still the issue persists.
{"level":"error","ts":"2024-02-09T14:01:48.606Z","msg":"Reconciliation failed after 30.767523613s, next try in 1m0s","controller":"kustomization","controllerGroup":"kustomize.toolkit.fluxcd.io","controllerKind":"Kustomization","Kustomization":{"name":"my-kustomization","namespace":"my-namespace"},"namespace":"my-namespace","name":""my-kustomization","reconcileID":"XXXXXX","revision":"XXXXXXX","error":"timeout waiting for: [Namespace/my-tenant-namespace status: 'Unknown': namespaces is forbidden: User \"system:serviceaccount:my-namespace:gitops-reconciler\" cannot list resource \"namespaces\" in API group \"\" at the cluster scope]"}

When I rolled back to v0.4.5 the issue did not persist.
@oliverbaehler can you please re-open the issue?


Job tagging

I change the 'add_tags' function so that it actually works.
I change the notifier views so that we display a short message for every job tag.
I followed the ideas and instructions found in: https://github.com/travis-ci/travis-ci/issues/217

Great work, @lucaspinto!
One thing: we need to keep the tagging.yml file in the config directory of the app which is using the travis-core gem. For different apps we might have different tag definitions and/or notes.
I'll have a couple more comments but i might need to leave this for tomorrow :)


libmcrypt: Fixed missing nmedit on darwin

Motivation for this change
This change fixes libmcrypt not building on OS X (see #15482). It does by adding the missing nmedit dependency which is distributed via the OS X cctools.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS (not affected by this change)
[x] OS X
[ ] Linux (not affected by this change)

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This looks good to me. Could you add linux and darwin to the platforms array as well?

Looks like there is no platform defined yet, do you know what's the default platform? And can we just set platforms = stdenv.lib.platforms.all?

"all" should be fine for now.

Fixed and rebased.


Update path for HIP in GinkgoConfig.cmake.in

GinkgoConfig.cmake will be created in build directory, not in ginkgo cmake, therefore need to add "/../cmake/" as path

Hi! Thanks for this PR, you are correct we have an issue with this from the perspective of the build directory. One thing to consider though, is that the current setup works when installing Ginkgo (as the helpers are copied to the same directory as the GinkgoConfig.cmake), and your version would make us lose this ability.
We should probably fix this in another way, some ways to fix it that I can think of are:

Somehow adding a condition based on whether we installed or not Ginkgo (can be variable controlled, defined in the installation step, or maybe CMake has something for that), and switch the path depending on this "installed" condition.
Simply copy the two helper files from the cmake directory to the build directory.

For now, I am more leaning towards option 2. What do you think. Also @ginkgo-project/developers.

option 2 also sounds better to me.

If we are reasonably sure that these are the only two files that will need this kind of change when Ginkgo is used without installation, then option 2 sounds good. Otherwise, we might want to look at option 1 for a general solution in which we can fine-tune everything for a kind of in-source use case.
The package registry option that @tcojean mentioned is also an interesting idea for a more general solution, but I feel it's not the most suitable for this PR's use case. It seems like the idea is to have a Ginkgo build specifically for one dependent project, rather than user-wide or system-wide.

Option 1 sounds more brittle to me, since it sounds to me like we would need to assume that a build directory is used either to install Ginkgo, or to include from directly, but not both (since variables are more or less fixed, only generator expressions can depend on the output).
@cho-uc Just so we understand what you are looking for, can you tell us what your current mode of use is? Right now, we support and test for Ginkgo installed with make/ninja install and find_package(Ginkgo) or as a subdirectory build add_subdirectory(ginkgo), it sounds like we are missing another option you are using?

Since I don't have admin privilege in the server where I installed ginkgo, I can only built locally, run "make" but not "install".
Previously, when I run the CMake for test_install, it gave me error that it cannot find hip_helpers.cmake and windows_helpers.cmake.
Once I fixed it, test_install was successfully built.

Thanks for the details, I see the issue now. Another solution to this issue would be to install Ginkgo in a custom user-local CMAKE_INSTALL_PREFIX (in case you are not familiar with CMake variables, you can do this by setting it in your CMakeCache.txt, using ccmake, or completely recreating your build directory with the -DCMAKE_INSTALL_PREFIX=/home/.../... flag). I've been using this approach with many libraries or tools I didn't want to install system-wide, it usually works pretty well.
In our root CMakeLists.txt, the CMAKE_INSTALL_PREFIX gets propagated to the CMAKE_PREFIX_PATH for the test_install step which is then used in find_package(Ginkgo)

Ach I see, I didn't set CMAKE_INSTALL_PREFIX so it used the default value in /usr/local/ in which I don't have access to.
Do you think it's still beneficial to revise this config file or should I just close this PR?

Good that you found your solution. I think this file should still be revised. As we discussed, there is indeed an issue with this file, but maybe it's better to tackle this in a separate PR since we need to use another way, and probably add a test as well.


Unhandled exception: Drive with the same letter exists

I am unable to start the latest win-sshfs due to this error.
Where can I tell win-sshfs which drive letter to use? Is there another fix for this?

Try this quickfix: %User%/AppData/Local/WinSshFS/config.xml edit value of coresponding sftpdrive node, in subnode . The number is ascii ordinal value, 32 for unset letter, 84 for T etc.

Thanks for that. Now I get no error, but I also do not have winsshfs start up. I can see it in process view, but it is idle until I manually kill it. What can I try next?

I tested it more, and this happens only with virtual drive. Fix is in commits already.

fixed in https://github.com/dimov-cz/win-sshfs/releases/tag/<IP_ADDRESS>

Wow, super fact fix! OK, now it starts, but I have a variant of the original error. It is not longer an exception but a handled error, nevertheless the message is the same:
"Virtual drive could not connect
Drive with the same letter exists"
There is no %User%/AppData/Local/WinSshFS/config.xml file. There is a vfs.xml file instead but there are no options that correspond to what you are suggesting.
Where can I tell winsshfs what drive letter to use?
Thanks.

Never mind. User error. Run as administrator gets me to the settings screen. Thanks!

Message is same of course. The difference is that you can access GUI now.


Test toolchain built with hardware and minimal application

Make sure that the toolchain we built is usable on different machines + produces valid firmware that can run on various boards/chips

We accomplished this with a new project: https://github.com/vkottler/xmc!


More details in comment

feat(Hydration): Can now hydrate next season schedule data
fix(MongoDB): Converted logic for new database-collection structure
fix(Schedule): Can now get schedule for current or next year. If failed default value gets returned

Ignore comments, going to do this on my side.


NullPointerException when invoking "com.shaft.properties.internal.Timeouts.apiSocketTimeout()"

This is currently a known issue dear.
You aren't able to setup any properties programmatically in the following case:

You did not do an initial test run and therefore your listeners aren't configured.
You did not initialize the driver instance yet.

Kindly share your code to confirm if this is a new case.
In your case since this seems to be a global configuration for you, then note that it's advised to handle global configuration by used file-based properties as per our user guide.

closing due to lack of response. kindly feel free to reopen it if needed.


ISPN-11444 Upgrade JUnit version 5

https://issues.redhat.com/browse/ISPN-11444

@danberindei do you think anything else is needed at this point ?

@karesti I think even after adding the dependency, the tests still run with JUnit4, because of this:
https://github.com/infinispan/infinispan/blob/38d42d23216ebaa169db885356d2a2584c33439c/commons/all/pom.xml#L192
I didn't read the JUnit5 maven documentation properly, it doesn't explain how to use it with Maven when the module also has a TestNG dependency. There is however an example in the Maven Surefire documentation:
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html
Something else I think is missing is a way to check that the tests really are running with JUnit 5 and not with JUnit 4.

@danberindei looking tonight

@danberindei wdyt now ?

@karesti how can we check if the tests really are running with JUnit 5?

@danberindei I'm trying to run junit 4 and 5 tests at the same time in another PR. It does not work (yet)

@danberindei I give it up. I can't make work on command line a junit 5 test

@karesti I have made the JUnit 5 test driver run the tests with JUnit 5 here: https://github.com/infinispan/infinispan/commit/8dde3ef4e02f5a032f5168d639f4f3345dca16e5
Similar changes would be needed in all the modules currently using JUnit 4 to upgrade them to JUnit 5. Careful review would also be needed to make sure that the modules actually run with JUnit 5 (by running Maven with -X and inspecting the output), that the test count is the same, that test parameters are also preserved in the test results to keep the tests unique, and that tests that run twice in different modules (like hibernate v51 and v53) get different names in the results.

@danberindei the best will be to treat it all in the same PR


module type bug

Describe the bug
type must be specified when a module field is in a module
To Reproduce
Steps to reproduce the behavior:

not specify a module type in the module field in a module

Expected behavior
module class must be generated
Koin project used and used version (please complete the following information):
core version 3.2.0
annotations version 1.0.1
video:
https://imgur.com/USbXqjq

You must keep using class modules between them, and avoid mix Module DSL & Class Module annotations


libcouchbase: 2.5.2 -> 2.7.2

Motivation for this change
Update
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I also enabled tests of this project.


Load ribbon classes if defined via properties.

Allows ribbon class name properties to be used to define beans.
This seems like boilerplate, but works, though not easily extensible.
fixes gh-927
/cc @dsyer @jkschneider @twicksell

Closed via 7dc8b86001ea6cb32b7e70b46ea716b0b6dfd0a8


Bump to v1.2.0 and include an example for Service/rc with EXTERNAL-IP

Thanks a lot. Does the job of setting up quickly your cluster for demo purposes and etc. The 25 replicas stuff bothers me, but not too much, so I'm merging. Thanks again.


Added generated rule for SpecFlow's *.feature.cs

More info about specFlow here http://www.specflow.org/

Hi @mamodom - could you link me to an example file that you'd want to be considered generated? Are these all examples? https://github.com/search?utf8=✓&q=Feature+feature.cs+in%3Apath&type=Code&ref=searchresults

Hi @arfon, thanks for the quick reply. Here is an example of the generated feature flie. It generates 100+ lines of code just from this 4 steps gherkin

OK thanks @mamodom. I think this PR is going to need some work before it can be merged as these search results all match your regex but are mostly not SpecFlow files.
Do you have any suggestions for ways we could limit the scope of this regex?

Sincerely  I'm not experienced in ruby but after some research I found this tool which tests regular expressions in ruby, and judging by this expression which is the one I submitted doesn't match files named feature.cs, only the files that match *.feature.cs.

@mamodom - you're absolutely right about this. I added a test to your commits in #2328.
This change will be live in the next release of Linguist which will likely be next week sometime.


Resolve file path with {{ role_path }}

I was getting errors with this playbook when executing "include OS family/distribution specific variables." Even though my ansible_os_family is RedHat, with_first_found was finding no results. (I am running Centos 7, but I confirmed the RedHat value in the ansible facts with ansible all -m setup.)
When I prepended the defaults/... relative path with {{ role_path }}, this playbook ran successfully.

@jonwolski which ansible version was it breaking with?

$ ansible --version
ansible <IP_ADDRESS>
  config file =
  configured module search path = Default w/o overrides

FWIW, I was applying this role from a role defined outside of my standard roles directory.
I have something like https://gist.github.com/jonwolski/aa235a5d3e774a08df8e0d40b48a4a48 checked out on my Macos box at ~/workspace/infrastructure.
When I run ansible-galaxy install -r requirements.yml, the ansiblebit.oracle-java role is installed in /usr/local/etc/ansible/roles. However, this is referenced in a playbook (site.yml) found in a sub-directory of my home directory.

@jonwolski no problem.
I just wanted to know which version so I keep a close eye on it when I run my tests.
thank you!

My pleasure. Thanks.

merged with `master: https://github.com/ansiblebit/oracle-java/releases/tag/5.14.10
@jonwolski if you use this role please star it.
cheers!


#145 Feat: AutoMapperSerializer - add types for to object method

reference issue
Fix|Change|Update
This pull request aims to solve the problem of inferring the correct types in the toObject method
implementing a serializer at type checking level without break changes.
The only change made at runtime is that toObject returns a deepReadonly object
#issue #145
Resolves #145

My bad
I just noticed that my auto-eslint changed some import module order and indentation


De-escalate LDAP health check when using SSO

Background
LDAP is part of the overall health-check in the Portal, which reports a 500 error when any failures arise.  This means that LDAP connectivity loss can take out the entire portal.
When using SSO, LDAP is currently only used for NEW users in login, and for Add users to group.  These functions represent a small, partial loss when using the application.
Solution
If SSO is being used, the LDAP health check should log loudly / raise an alert, but should NOT result in a 500 error response from the health check.

Seems like low-hanging fruit that can improve site reliability in case of an outage.  Moving to ready.


DOC: langchain plus OpenAI-compatible URL API equally error

Issue with current documentation:
hello everyone! Is it possible to use the OpenAI-compatible URL API from text-generation-webui with langchain? the langchain documentation says about localhost, but I don't have access to it, I tried to insert the link into model_url, the error appeared both in google colab and in the terminal.

Idea or request for content:
No response

@hherpa Hi, I'm a langchain user and volunteer, and I'm here to assist with your issue. I've noticed that you're using the openai_api_key to input your OpenAI proxy address, which seems problematic. To fix this, simply replace openai_api_key with openai_api_base. If you encounter any issues, don't hesitate to reach out to me.

@chyroc hello! Thank you for helping, but this only leads to an error:
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
Cell In[2], line 4
      1 from langchain.chat_models import ChatOpenAI
      2 from langchain.prompts import ChatPromptTemplate
----> 4 model = ChatOpenAI(openai_api_base = "https://eat-smooth-rob-attacked.trycloudflare.com")
      5 prompt = ChatPromptTemplate.from_template("tell me a joke about {topic}")
      6 chain = prompt | model

File ~\AppData\Roaming\Python\Python311\site-packages\langchain_core\load\serializable.py:107, in Serializable.__init__(self, **kwargs)
    106 def __init__(self, **kwargs: Any) -> None:
--> 107     super().__init__(**kwargs)
    108     self._lc_kwargs = kwargs

File ~\AppData\Roaming\Python\Python311\site-packages\pydantic\v1\main.py:341, in BaseModel.__init__(__pydantic_self__, **data)
    339 values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
    340 if validation_error:
--> 341     raise validation_error
    342 try:
    343     object_setattr(__pydantic_self__, '__dict__', values)

ValidationError: 1 validation error for ChatOpenAI
__root__
  Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass  `openai_api_key` as a named parameter. (type=value_error)

@hherpa Okay, it seems that you have set the proxy address, but you are still missing an openai secret. Please use openai_api_key to set it. If your proxy does not require this parameter, please also pass an arbitrary string.

@hherpa you've used the openai_api_base but still you are missing openai_api_key. You have to provide both openai_api_base and openai_api_base.
Here something like this:
model = ChatOpenAI(openai_api_base = "https://eat-smooth-rob-attacked.trycloudflare.com", openai_api_key='<YOUR_OPENAI_API_KEY>')

@chyroc hello! Thank you for helping, but this only leads to an error:
---------------------------------------------------------------------------
ValidationError                           Traceback (most recent call last)
Cell In[2], line 4
      1 from langchain.chat_models import ChatOpenAI
      2 from langchain.prompts import ChatPromptTemplate
----> 4 model = ChatOpenAI(openai_api_base = "https://eat-smooth-rob-attacked.trycloudflare.com")
      5 prompt = ChatPromptTemplate.from_template("tell me a joke about {topic}")
      6 chain = prompt | model

File ~\AppData\Roaming\Python\Python311\site-packages\langchain_core\load\serializable.py:107, in Serializable.__init__(self, **kwargs)
    106 def __init__(self, **kwargs: Any) -> None:
--> 107     super().__init__(**kwargs)
    108     self._lc_kwargs = kwargs

File ~\AppData\Roaming\Python\Python311\site-packages\pydantic\v1\main.py:341, in BaseModel.__init__(__pydantic_self__, **data)
    339 values, fields_set, validation_error = validate_model(__pydantic_self__.__class__, data)
    340 if validation_error:
--> 341     raise validation_error
    342 try:
    343     object_setattr(__pydantic_self__, '__dict__', values)

ValidationError: 1 validation error for ChatOpenAI
__root__
  Did not find openai_api_key, please add an environment variable `OPENAI_API_KEY` which contains it, or pass  `openai_api_key` as a named parameter. (type=value_error)

@cyai Can you post your error stack?


feat: generating random pokemon for catching

Codecov Report

Merging #23 (e2c7a10) into main (986cc18) will decrease coverage by 15.27%.
The diff coverage is 48.57%.

@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
- Coverage   97.72%   82.45%   -15.28%
===========================================
  Files           6        7        +1
  Lines          88      114       +26
  Branches       21       25        +4
===========================================
+ Hits           86       94        +8
- Misses          2       20       +18

Impacted Files
Coverage Δ

lib/services/rng.ts
23.80% <23.80%> (ø)

lib/services/pokemon.ts
81.25% <33.33%> (-11.06%)
:arrow_down:

lib/services/stat.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 986cc18...e2c7a10. Read the comment docs.


Update readme.md

This library provides a very easy way to create transition effects when an user is manipulating an UI control like DrawerLayout
https://github.com/kaichunlin/android-transition

Thanks


V0.1: bug fix, docs refine

Description

Fix dist decorator
Add example docs for CIM and Citi Bike scenario
Refine annotation

Linked issue(s)/Pull request(s)

147
144
136
142

Type of Change

[x] Non-breaking bug fix
[ ] Breaking bug fix
[ ] New feature
[ ] Test
[x] Doc update
[ ] Docker update

Related Component

[x] Simulation toolkit
[ ] RL toolkit
[x] Distributed toolkit

Has Been Tested

OS:

[x] Windows
[x] Mac OS
[x] Linux

Python version:

[x] 3.6
[x] 3.7

Key information snapshot(s):

Needs Follow Up Actions

[x] New release package
[x] New docker image

Checklist

[x] Add/update the related comments
[x] Add/update the related tests
[x] Add/update the related documentations
[x] Update the dependent downstream modules usage

Codecov Report

Merging #153 into master will increase coverage by 0.13%.
The diff coverage is 69.69%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   72.36%   72.50%   +0.13%
==========================================
  Files          87       86       -1
  Lines        4089     4062      -27
==========================================
- Hits         2959     2945      -14
+ Misses       1130     1117      -13

Flag
Coverage Δ

#unittests
72.50% <69.69%> (+0.13%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

maro/communication/dist_decorator.py
15.38% <0.00%> (ø)

...o/simulator/scenarios/citi_bike/business_engine.py
74.69% <75.00%> (+0.58%)
:arrow_up:

maro/simulator/abs_core.py
78.46% <100.00%> (ø)

maro/simulator/core.py
84.29% <100.00%> (ø)

maro/simulator/scenarios/abs_business_engine.py
88.67% <100.00%> (+1.17%)
:arrow_up:

maro/simulator/scenarios/cim/business_engine.py
86.20% <100.00%> (+1.87%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e268ef3...77b8288. Read the comment docs.


Upgrade Kujaku dependencies to the latest

Closes https://github.com/onaio/kujaku/pull/369
Describe the feature request.

The mapping feature on FHIR Core uses the Kujaku Library. This library hasn't been uploaded for a while.
This update should focus on the Google Location Services dependencies but we can update all the other dependencies too.

Additional context
If available add any other context or screenshots about the feature here.
Acceptance criteria

[x] Kujaku should use version 21+ of the Google Location Services.
[x] All the mapping functionality provided by Kujaku should work as expected with the latest main branch.

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

Depends on Kujaku PR https://github.com/onaio/kujaku/pull/369

Update July 1st 2024

CI is still broken and needs maybe to be addressed on CHT

Kujaku libs still have issues with CI  - Aug 5th
CC @ndegwamartin @dubdabasoduba

Closing this since the corresponding PR on Kujaku is merged to main - https://github.com/onaio/kujaku/pull/369


Deployment

Find and test a free Rust web hosting service. Options:

[x] now.sh (zeit.co) community Rust builder
rust runtime for AWS lambda
IPFS

Support for now.sh is on the works in the now branch

Heroku works with this buildpack and this config:
    let options = ServerOptions {
        cache_max_age: 24 * 3600 * 7, // cache all responses for 7 days
        port: env::var("PORT").ok().and_then(|port| port.parse().ok())
            .unwrap_or(1337),
        ip: Ipv4Addr::new(0, 0, 0, 0).into(),
    };
    serve_http(interface, options);

(The most important is the port - Heroku assigns it dynamically and it's often a higher number.)
Procfile can look like this one:
web: ./target/release/addon_example

(Tested with this PR - https://github.com/sleeyax/stremio-addon-sdk/pull/10)


Add dyno name and remove UUID labels to reduce cardinality

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


ISPN-5683 Removed whitespaces at the end of the lines

https://issues.jboss.org/browse/ISPN-5683
Please do not close the issue once this PR gets in. I'm turning on the rules gradually.
Fixed by a simple command:
find . -name "*.java" -exec sed -i 's/\s*$//' {} \;

@rvansa @anistor @galderz @Sanne Could you please review it?

-1 I use git annotate (blame) to crawl through history quite often, and this introduced unwanted churr.

@rvansa Hey Radim! Just to be crystal clear - the alternative is to skip this rule.
I assume you are -1 for submitting this change and +1 for removing the rule for checking empty char at the end of the line?

http://bit.ly/29oQu40  :broken_heart: :disappointed:

@slaskawi Yep. My priority list is : nice history > no invisible chars on the end of lines > invisible chars on the end of lines
Is it possible that such post-processing would be rather a part of a commit hook, affecting only diffs?

I have an idea - would you prefer to have this one or https://github.com/infinispan/infinispan/pull/4515 ? Let the vote begin!

:-1: from me

If we give up on this then we might as well give up on the remaining ~35 rules. -1 for giving up.

By looking at the changes I see that the majority are on empty lines or javadocs, and few on actual statements. There will be some noise in history indeed, but not where it hurts the most. I'd allow this. And would even go as far as activate the manadatory new-line at EOF rule too so we are spared from seeing these: https://github.com/infinispan/infinispan/pull/4513/files#diff-e2e6f183514f1de4a3e41498851f8a46L6

@anistor has a point here. If we give up one simple rule like this one, we might give up all of them. Also if you use formatter, you should never see this violation in practice. So changing my mind, :+1: from me.

My vote is with Adrian on this one
On 18 Aug 2016 07:56, "Sebastian Łaskawiec"<EMAIL_ADDRESS>wrote:

@anistor https://github.com/anistor has a point here. If we give up one
simple rule like this one, we might give up all of them. Also if you use
formatter, you should never see this violation in practice. So changing my
mind, 👍 from me.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/infinispan/infinispan/pull/4513#issuecomment-240630825,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAX9Hmq1MnlBNDGWIDiXp-_lXqTSWV_nks5qg_P8gaJpZM4JmZ-O
.

Okay, I admit I haven't checked all the files - if it's mostly javadoc, it probably won't hurt.

+1 It will be worth the initial pain in the long run.

Rebased

Looking again and pulling...

Integrated. Thanks @slaskawi !


[WIP] SFC improvements [sfc-improvements-dev]

NCMesh now supports triangles, prisms and tets, but the ordering of child (refined) elements is rather bad. This PR attempts to come up with improved orderings that lead to better SFCs (space filling curves) and thus better parallel partitions.

Refining a coarse mesh consisting of two triangles. Old ordering:

New ordering (better, but still not as good as Hilbert for quads):

@jakubcerveny, should this go in master after nc-tet-dev (which in turn should go after nc-prism-dev)?

Yes, that is the intended order. Once the previous branches are merged the diffs should look cleaner, now it's basically 3 PRs mixed together.


coinstac-simulator performance problems

I used coinstac-simulator-load-tester to run a varying number of clients with a varying number of iterations:

Each client computes the hash of a 1mb file on every iteration. The average client computation time is ~19.8ms. What’s concerning here is that simulating 20 clients each running 50 iterations takes 5 minutes and 48 seconds. Each client’s computation time is, on average, <1 second in this case. What’s taking up so much time?

as usual, my first guess is pouchdb server.  now that you clearly have some awesome benchmarking hooks setup, it would be cool to use perf-now to try and trace it.

we could try measuring from clients getting a change event all the way to pipeline run:end

if this time is ~constant between iterations, we know the problem is not in our code, but rather in the network or pdbs
if these numbers do increase, we should probably profile the final saving of our docs in the pipeline runner.  this is unlikely.

i'm curious if we stretch out the polling interval to reduce the noise all of the clients induce on PDBS if that would increase perf too in the many client count scenarios.
easily the most troubling thing here is that none of these lines are flat.  something isn't able to keep up with steady state, right off the bat, seemingly no matter what.  we do expect some increase in time on each iteration, because we are maintaining history on each client save, but I'd be hard pressed to think that such a factor would even be observable.

does the same happen against couchdb?

Another test, this time on one of our servers:

250 iterations w/ 5 clients took ~27 min
Higher numbers of clients couldn’t complete higher numbers of iterations (probably due to errors?)
Average client compute time for a single iteration was 55ms
This only measures time spent within the computation. The entire run took >12 hours?

@cdaringe Good ideas. We'll see how high a priority simulator is and check them out.

Adding some stat/graphs from VMware for context:

Virtual Hardware:

CPU info:
$ cat /proc/cpuinfo
processor	: 0
vendor_id	: GenuineIntel
cpu family	: 6
model		: 26
model name	: Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz
stepping	: 4
microcode	: 0x70d
cpu MHz		: 2000.000
cache size	: 15360 KB
physical id	: 0
siblings	: 1
core id		: 0
cpu cores	: 1
apicid		: 0
initial apicid	: 0
fpu		: yes
fpu_exception	: yes
cpuid level	: 11
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts mmx fxsr sse sse2 ss syscall nx rdtscp lm constant_tsc arch_perfmon pebs bts nopl xtopology tsc_reliable nonstop_tsc aperfmperf pni ssse3 cx16 sse4_1 sse4_2 x2apic popcnt hypervisor lahf_lm ida arat pln pts dtherm
bogomips	: 4000.00
clflush size	: 64
cache_alignment	: 64
address sizes	: 40 bits physical, 48 bits virtual
power management:


"Invalid checksum" Error When Trying to Authenticate With KerberosAuthenticator

I have written an LDAP server that, among other things, processes Kerberos authentications. I had been using an old C SSPI library to process these authentications, but would like to use Kerberos.NET for a multitude of reasons. My code looks like:
byte[] token = ... (parsed Kerberos request bytes from incoming request)
KeyTable table = new KeyTable(File.ReadAllBytes());
KerberosAuthenticator authenticator = new KerberosAuthenticator(table);
Task authenticateTask = authenticator.Authenticate(token);
authenticateTask.Wait();
KerberosIdentity claimsIdentity = (KerberosIdentity)authenticateTask.Result;
I am getting an exception with the following stacktrace when calling authenticateTask.Wait():
System.AggregateException: One or more errors occurred. ---> System.Security.SecurityException: Invalid checksum
at Kerberos.NET.Crypto.AESTransformer.Decrypt(ReadOnlyMemory1 cipher, KerberosKey kerberosKey, KeyUsage usage) in D:\a\1\s\Kerberos.NET\Crypto\AES\AESTransformer.cs:line 112    at Kerberos.NET.Entities.KrbEncryptedData.Decrypt[T](KerberosKey key, KeyUsage usage, Func2 func) in D:\a\1\s\Kerberos.NET\Entities\Krb\KrbEncryptedData.cs:line 39
at Kerberos.NET.Crypto.DecryptedKrbApReq.Decrypt(KerberosKey ticketEncryptingKey) in D:\a\1\s\Kerberos.NET\Crypto\DecryptedKrbApReq.cs:line 75
at Kerberos.NET.Entities.ContextToken.DecryptApReq(KrbApReq token, KeyTable keytab) in D:\a\1\s\Kerberos.NET\Entities\SpNego\ContextToken.cs:line 45
at Kerberos.NET.KerberosValidator.d__15.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosValidator.cs:line 75
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Kerberos.NET.KerberosAuthenticator.d__13.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosAuthenticator.cs:line 73
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Kerberos.NET.KerberosAuthenticator.d__12.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosAuthenticator.cs:line 69
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at LdapSession.d__58.MoveNext() in LdapSession.cs:line 629
---> (Inner Exception #0) System.Security.SecurityException: Invalid checksum
at Kerberos.NET.Crypto.AESTransformer.Decrypt(ReadOnlyMemory1 cipher, KerberosKey kerberosKey, KeyUsage usage) in D:\a\1\s\Kerberos.NET\Crypto\AES\AESTransformer.cs:line 112    at Kerberos.NET.Entities.KrbEncryptedData.Decrypt[T](KerberosKey key, KeyUsage usage, Func2 func) in D:\a\1\s\Kerberos.NET\Entities\Krb\KrbEncryptedData.cs:line 39
at Kerberos.NET.Crypto.DecryptedKrbApReq.Decrypt(KerberosKey ticketEncryptingKey) in D:\a\1\s\Kerberos.NET\Crypto\DecryptedKrbApReq.cs:line 75
at Kerberos.NET.Entities.ContextToken.DecryptApReq(KrbApReq token, KeyTable keytab) in D:\a\1\s\Kerberos.NET\Entities\SpNego\ContextToken.cs:line 45
at Kerberos.NET.KerberosValidator.d__15.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosValidator.cs:line 75
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Kerberos.NET.KerberosAuthenticator.d__13.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosAuthenticator.cs:line 73
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Kerberos.NET.KerberosAuthenticator.d__12.MoveNext() in D:\a\1\s\Kerberos.NET\KerberosAuthenticator.cs:line 69
The Zone of the assembly that failed was:
MyComputer<---

The Invalid Checksum error means the key used to decrypt the incoming AP-REQ is wrong. Since it's pulling the key from KeyTable table = new KeyTable(File.ReadAllBytes()) that would suggest the keytable either has the wrong key or no key at all (though no key should trigger a different error).
You can test this by ruling out any oddities with KeyTable lookups with something like this:
foreach (var entry in keyTable.Entries)
{
	KerberosAuthenticator authenticator = new KerberosAuthenticator(new KerberosValidator(entry.Key));

	try
	{
		var identity = await authenticator.Authenticate(token);
	}
	catch (Exception ex)
	{
		// blah
	}
}

If it is a key selection issue then I can make that logic a bit smarter based on what you happen to find with the above test.

Okay, not that surprising. The key in the keytab "just" isn't the correct key. How did you generate the keytab file?

I have 2 domains, which have a 2-way transitive trust. The LDAP server is running in domain A and I'm trying to authenticate users from domain B. I created the keytab file in domain B:
ktpass /princ<EMAIL_ADDRESS>/mapuser B\krbsvt /pass password /out Bkeys.keytab /crypto all /PTYPE KRB5_NT_PRINCIPAL /mapop add
B\krbsvt has “This account supports Kerberos AES 256 bit encryption”, "Password never expires" and "User cannot change password" enabled. I have verified that the UPN for user B\krbsvt got changed to<EMAIL_ADDRESS>after generating the keytab file. I also validated that I could log into domain B with B\krbsvt and password.

If the LDAP server is in domain A why are you giving it a service account from domain B?
What is the SPN you're using for the LDAP server? What is the name you're passing to the client to resolve that SPN? I would guess it's getting a referral to A, and resolving an SPN from domain A.

I created the keytab file in domain B, which is where the accounts are that will be used for Kerberos authentications, and which is why I used the service account from domain B.
The SPN, registered on the LDAP server in domain A, is ldap/host.A.local:port. I connect to ldap://host.A.local:port from the client in domain B. Domain B does not have any SPNs registered for ldap/host.A.local:port. Should I have the SPN registered in domain B as well? And if so, to the same service account I'm using for the keytab file?
Thanks again.

So it sounds like SPNs are OK. Did you see anything of concern with the way I'm creating the keytab file, since that seems the be the cause of the errors I'm seeing?

You have an SPN of ldap/host.a.local[:port] registered to the<EMAIL_ADDRESS>account?

Yes, I added the SPN to the domain B krbsvt user, re-generated the keytab file and still no luck.
I also used Bruce with the verify flag to inspect the keytab file. I see the Principal Name is listed as host/krbsvt. Is that correct even though I set the principal to<EMAIL_ADDRESS>

From within bruce what does klist get ldap/host.a.local --verbose with or without the port get you? If you get Cannot request a service ticket until a user is authenticated then please also do kinit from there too.

I assume you wanted the output from bruce on server B:
`bruce>klist get ldap/host.A.local --verbose
[Info]    A ticket was retrieved for<EMAIL_ADDRESS>Ticket Count: 3
#0>                Client : MYUSER @ B.LOCAL
Server<EMAIL_ADDRESS>@ B.LOCAL
Ticket EType : AES256-CTS-HMAC-SHA1-96 (18)
Flags : 0x40e10000 -> Encrypted Pre-Authentication, Pre-Auth
enticated, Initial, Renewable, Forwardable
Start Time :
End Time : 4/18/2024 1:59:46 AM -04:00
Renew Until : 4/18/2024 3:59:46 PM -04:00
Session Key Type : AES256-CTS-HMAC-SHA1-96 (18)
#1>                Client : MYUSER @ B.LOCAL
Server<EMAIL_ADDRESS>@ B.LOCAL
Ticket EType : AES256-CTS-HMAC-SHA1-96 (18)
Flags : 0x40a10000 -> Encrypted Pre-Authentication, Pre-Auth
enticated, Renewable, Forwardable
Start Time :
End Time : 4/18/2024 1:59:46 AM -04:00
Renew Until : 4/18/2024 3:59:46 PM -04:00
Session Key Type : AES256-CTS-HMAC-SHA1-96 (18)
#2>                Client : MYUSER @ B.LOCAL
Server<EMAIL_ADDRESS>@ A.LOCAL
Ticket EType : AES256-CTS-HMAC-SHA1-96 (18)
Flags : 0x40a50000 -> Encrypted Pre-Authentication, Ok as De
legate, Pre-Authenticated, Renewable, Forwardable
Start Time :
End Time : 4/18/2024 1:59:46 AM -04:00
Renew Until : 4/18/2024 3:59:46 PM -04:00
Session Key Type : AES256-CTS-HMAC-SHA1-96 (18)
bruce>`

There's your issue. If you walk the list you'll see the order of operations.

Get TGT(B) for B.LOCAL
Have TGT(B), get ldap/..., KDC said it needs a referral to A.local, get TGT(A)
Have TGT(A), get ldap/... from A.local

The SPN is not registered correctly in B.local so the KDC never finds it, and thinks it needs to go ask A.local instead.

Thanks again for all your help. Would this still be your explanation, knowing that I can authenticate via Kerberos from server B to server A AD (not my LDAP instance)?

Yes, because the Server A would have the key of host.A.local because that's its key.


add Azure Pipelines Scaler

Add a new Azure Pipelines Scaler
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
- [ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable) (https://github.com/kedacore/keda-docs/pull/411)
[x] Changelog has been updated

Relates to #1705

Thanks a ton @troydn, this is great!

LGTM, thanks @troydn
Would be nice if you could add e2e test for this scaler.
https://github.com/kedacore/keda/tree/main/tests

I can add e2e tests for this scaler but this would require an Azure DevOps organization that can be used for the e2e tests. Should I create one and provide the details/access or would you rather provide one?

I can set one up, what do you need? Org id and PAT?

And what PAT permissions?

@tomkerkhove great, just to be sure, we will need something pernament once the tests are ready. Mabye @jeffhollan or @ahmelsayed could help with that?

They are free so should be OK!

Org created as per https://github.com/kedacore/governance/issues/20 and is up on

Org created as per kedacore/governance#20 and is up on https://dev.azure.com/kubernetes-event-driven-autoscaling/Kubernetes Event-driven Autoscaling (KEDA)

Thanks!
Should the e2e test also manage the creation of the build definition and the agent pool on Azure DevOps? It could also be a one time setup where an empty agent pool is created and a simple build definition is created that sleeps for 2 minutes.

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.
What else do you need in terms of config and what PAT permissions are required?

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.
What else do you need in terms of config and what PAT permissions are required?

I finished the e2e test. But I'm not sure what image should be used for the Azure DevOps Agent. For now, I used one on my docker registry. But I think this should be replaced by one on a registry managed by KEDA.
The test requires an Azure DevOps environment with the following config:

Agent pool created
A pipeline configured to run on the created agent pool with "sleep 2m" as build step
A PAT with the following permissions:

Agent Pools : Read & manage
Build: Read & execute

I'm happy to set it up, I'll create an empty pool and pipeline that has a 2 min delay in it.
What else do you need in terms of config and what PAT permissions are required?

I finished the e2e test. But I'm not sure what image should be used for the Azure DevOps Agent. For now, I used one on my docker registry. But I think this should be replaced by one on a registry managed by KEDA.

We host all test images on https://github.com/kedacore/test-tools, are you OK in adding a container image there?

The test requires an Azure DevOps environment with the following config:

Agent pool created

A pipeline configured to run on the created agent pool with "sleep 2m" as build step

A PAT with the following permissions:

Agent Pools : Read & manage
Build: Read & execute

I'll get this setup tomorrow.

@troydn I've added these GitHub secrets for you:

Pipeline is up on https://dev.azure.com/kubernetes-event-driven-autoscaling/Kubernetes Event-driven Autoscaling (KEDA)/_build?definitionId=1 with PR open on https://github.com/kedacore/test-tools/pull/11

@tomkerkhove thanks for your help on this. I think the e2e test is ready now.

Thank you @troydn and let me know if you are interested for the blog post<EMAIL_ADDRESS>

@troydn I have very strange behaviour when I am using scalerJob which works fine but always create useless job with no pods running
so I have 1 pending pipeline job and here's the result from the kubernetes namespace
 kubectl get jobs -n azure-devops
NAME                         COMPLETIONS   DURATION   AGE
azure-devops-runner-nsvv2    0/1           18s        18s
azure-devops-runners-g82f9   0/1                      4s

kubectl get pods -n azure-devops
NAME                              READY   STATUS    RESTARTS   AGE
azure-devops-runner-nsvv2-8dtb2   2/2     Running   0          27s

I don't understand why it creates 2 jobs not only one and why only one pod is spawned. I expect 1 job with 1 pod not 2 jobs with 1 pod.
the job config
  pollingInterval: 20                         # Optional. Default: 30 seconds
  successfulJobsHistoryLimit: 0               # Optional. Default: 100. How many completed jobs should be kept.
  failedJobsHistoryLimit: 0                   # Optional. Default: 100. How many failed jobs should be kept.
  triggers:
  - type: azure-pipelines
    metadata:
      poolID: "39"
      organizationURLFromEnv: "AZP_URL"
      personalAccessTokenFromEnv: "AZP_TOKEN"
      targetPipelinesQueueLength: "1"


⚠ Samsung has degraded performance

In 351ef04, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2377 ms

Resolved: Samsung performance has improved in 9307f7a.


Redo of issue 39. Commented there, but it didn't reopen. Kind of new to this.

This is a duplicate of the comment I left on issue #39
Okay, so I know this is supposed to be fixed and I even saw the code that is supposed to reset the ender dragons activity phase when spawned, but ...
Mine is not working and is acting just like this issue. I have rebuilt my dimension several times and even got another syringe and rebuilt the dimlet. The only thing I might think is an issue is the workbench selected a rarity 5 card when the config says the enderdragon is a rarity 6. Direwolf20, in his vid (Lets Play S9 E83) used a rarity 5 card without issue, so I'm not thinking it's a problem.
I am using the 1.8.0 of the Direwolf20 1.12.2 pack. It has the 5.51 version, which I'm pretty sure is the latest version of the rftools dimension mod.
Any ideas why this might not be working or more information you might need would great.

I reopened that one.


Switch to Psycopg3 for Django

Django 4.7 and higher supports psycopg3
With a goal to migrate to Django 5.0, would be it a good idea to also move to psycopg3 (from psycopg2)
Resources:

https://django.readthedocs.io/en/stable/releases/4.2.html
https://www.psycopg.org/psycopg3/docs/basic/from_pg2.html

It doesn't seem that there is an OpenTelemetry autoconfig for psycopg3


ja: Make docs/concepts/containers/container-lifecycle-hooks.md follow v1.17 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/containers/container-lifecycle-hooks.md to follow v1.17 of the original (English) text.
Why is this needed
content/ja/docs/concepts/containers/container-lifecycle-hooks.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.17-ja.3/content/ja/docs/concepts/containers/container-lifecycle-hooks.md
Original
https://github.com/kubernetes/website/blob/release-1.17/content/en/docs/concepts/containers/container-lifecycle-hooks.md
diff between translated and v1.17
https://gist.github.com/77df88e36cc0afd819155c08c34c0bb6
Note
Currently, we use dev-1.17-ja.3 branch. Please open a PR targeting the branch.
ref
How To Contribute
翻訳スタイルガイド
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel

/assign

/close


Order of attributes xs and sm matter?

It seems that
<Row>
    <Col xs={6} sm={4}>

    </Col>
    <Col xs={6} sm={4}>

    </Col>
    <Col xs={6} sm={4}>

    </Col>
</Row>

is not the same as
<Row>
    <Col sm={4} xs={6}>

    </Col>
    <Col sm={4} xs={6} >

    </Col>
    <Col sm={4} xs={6}>

    </Col>
</Row>

Is this by design?

Hi @thongly
No, props order should not affect the media queries that are generated.
Dimension props are sorted here: https://github.com/LoicMahieu/react-styled-flexboxgrid/blob/master/src/components/Col.js#L29
I don't see differences in theses examples, see: https://codesandbox.io/s/9o053mwlrp

Yes, indeed old versions are affected by this buggy behavior. Feel free to reopen the issue if you encounter this problem with current version.


Utility class for logging to channel

Added a utility class that wraps calls to Log*Channel(...) so that you can get code completion and don't have to worry about typing the channel name correctly each time.
My use case looks like this:

Make a static class with a number of UberLoggerChannel as members:

public static class Logger {
    public static readonly UberLoggerChannel Core = new UberLoggerChannel("Core");
    public static readonly UberLoggerChannel Achievements = new UberLoggerChannel("Achievements ");
    // .... More channels
}

Then usage looks like:
Logger.Core.Log("Foo");
Logger.Achievements.LogWarning("Bar");

And you get compile-time support (code completion, error checking, find-references, etc..). This is really useful when you want to standardize the usage of channels across a team because you don't have to remember capitalization and channel names.
Also you can easily turn on/off these channels without sprinkling your code with if (muteMyChannel) { Debug.Log("...."); } checks:
For example:
public static class Logger {
    public static readonly UberLoggerChannel ObscureSystem = new UberLoggerChannel("ObscureSystem");
    // ... Other channels

    static Logger() {
        ObscureSystem.Mute = true;
    }
};

This is neat. I like the lightweight-ness of your implementation, that's quite in line with core UberLogger. One suggestion: change the "mute" flag into a filter level; thus, you can choose to mute just messages from an obscure system. I find that it is common to want to mute messages, but not warnings/errors. Example here. With filter level muting I'd vote for including this into core UberLogger.
I've made a similar but more enterprise-y thing. It has an inspector + a source code generation step. The code generation allows for removal of the call sites for muted channels -> good for projects with lots of logging. It is a bit more clunky to use; the editor is still a bit clunky, and if the user generates source code for a bad configuration it is difficult to go back without reverting all changes to the configuration asset. I think what you have made is more suitable for core UberLogger.

Added flags to allow you to filter out messages now. You can now filter out normal .Log(...) calls (for example) by using something like ObscureSystem.Filter = UberLoggerChannel.Filters.HideLogs; or ObscureSystem.Filter = UberLoggerChannel.Filters.HideLogs | UberLoggerChannel.Filters.HideWarnings;


Problem when using arrow functions callbacks with no parentheses syntax

If I use this syntax (no parentheses surrounding the 'I' object)
Scenario('test if the welcome is shown', I => {
  I.amOnPage('/');
  I.see('Hello');
});

When using the 'SeleniumWebdriver' plugin the tests simply don't run, they get stucked on line that shows the first Feature's name. No errror is shown.
When using the 'WebDriverIO' plugin the tests run, but I got an 'Object of type '/' is not defined in container' error.
If I surround the 'I' object with parenthesis everything run just fine.

Try to use parentheses around I, like (I). We had to stop use a naked I for other reason. I hope it solves it.


FRW-286 Stabilized Glue infrastructure

Developer(s): @yaroslav-spryker

Ticket: https://spryker.atlassian.net/browse/FRW-286

Release Group: https://release.spryker.com/release-groups/view/4390

merge: squash

Release Table

Module
Release Type
Constraint Updates

UnzerRestApi
patch (currently 0.x)

Module UnzerRestApi
Change log
Adjustments

Adjusted composer.json to allow for new GlueJsonApiConventionExtension major.

Can be released with the red Travis, same issue in the master.
No code changes in the PR. (Target extension module was stabilized without changing functionality)

Please check the change logs, they are not relevant to the change made.

Please check the change logs, they are not relevant to the change made.

Could you please clarify what is wrong with the changelogs? @limeeugenia
We've allowed a new major according to https://spryker.atlassian.net/wiki/spaces/CORE/pages/523730976/Release+Notes+and+Changelogs

Please check the change logs, they are not relevant to the change made.

Could you please clarify what is wrong with the changelogs? @limeeugenia We've allowed a new major according to https://spryker.atlassian.net/wiki/spaces/CORE/pages/523730976/Release+Notes+and+Changelogs

I have already fixed the wrong module name in the change log, I think this was the issue.


With Zipkin, exception during startup trying to fetch endpoint prior to registration

I"m seeing an exception in the logs during application startup.  It's logged at the WARN level and the application does start and work properly.
It looks like part of Zipkin initialization (in autoconfig) is trying to determine the current services endpoint info (host/port, I assume) by looking the service up in the service registry (in my case, Consul).  However, the service doesn't register itself with Consul until later in the boot up process so it cannot find itself in Consul.  The code then falls back to using information from the local properties files, logs the warning and moves on.
Is there any way move Zipkin initialization so that it occurs after service registration?
2016-03-08 11:30:46.115 [session=,request=,trace=,span=, export=,] [           main] [WARN] o.s.c.s.z.FallbackHavingEndpointLocator : Exception occurred while trying to fetch the Zipkin process endpoint. Falling back to server properties endpoint locator.
java.lang.IllegalStateException: Unable to locate service in consul agent: api-gateway-9999
	at org.springframework.cloud.consul.discovery.ConsulDiscoveryClient.getLocalServiceInstance(ConsulDiscoveryClient.java:67) ~[spring-cloud-consul-discovery-1.0.0.M4.jar:1.0.0.M4]
	at org.springframework.cloud.sleuth.zipkin.DiscoveryClientEndpointLocator.local(DiscoveryClientEndpointLocator.java:43) ~[spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.FallbackHavingEndpointLocator.local(FallbackHavingEndpointLocator.java:32) ~[spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.ZipkinAutoConfiguration.sleuthTracer(ZipkinAutoConfiguration.java:68) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.ZipkinAutoConfiguration$$EnhancerBySpringCGLIB$$7ee28321.CGLIB$sleuthTracer$2(<generated>) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.ZipkinAutoConfiguration$$EnhancerBySpringCGLIB$$7ee28321$$FastClassBySpringCGLIB$$84e3604.invoke(<generated>) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:228) [spring-core-4.2.4.RELEASE.jar:4.2.4.RELEASE]
	at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:355) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.cloud.sleuth.zipkin.ZipkinAutoConfiguration$$EnhancerBySpringCGLIB$$7ee28321.sleuthTracer(<generated>) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-20160308.165913-370.jar:1.0.0.BUILD-SNAPSHOT]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_60]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_60]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_60]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_60]
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:162) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:588) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1123) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1018) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:510) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:482) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:772) [spring-beans-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:839) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:538) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:118) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:766) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at org.springframework.boot.SpringApplication.createAndRefreshContext(SpringApplication.java:361) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:307) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1191) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1180) [spring-boot-1.3.2.RELEASE.jar:1.3.2.RELEASE]
	at com.appdirect.appdirect.service.gateway.Application.main(Application.java:17) [classes/:na]

H! Can you check out this branch: issues_#205_deferring_locating_endpoint , build Sleuth locally and check if it's working better?

Interesting...  Two out of three of my services started with no errors in the logs.  The thirds one has the a similar, but different,  stack trace but it has moved later in the start process.  It now shows up 20ms after I see the log message for Consul registration.
Looks like it is now happening while instrumenting a request, probably the health check ping from Consul. So, there is some sort of race condition.  Note in the stack trace that Consul registration happens on the main thread and the exception happens on request processing thread pool-2-thread-1.
2016-03-08 14:10:59.246 [session=,request=,trace=,span=, export=,] [           main] [INFO] o.s.c.consul.discovery.ConsulLifecycle  : Registering service with consul: NewService{id='pong-service-port8004-8004', name='pong-service', tags=[], address='<IP_ADDRESS>', port=8004, check=Check{script='null', interval=10s, ttl=null, http=http://<IP_ADDRESS>:8004/health, timeout=null}}
2016-03-08 14:10:59.267 [session=,request=,trace=c3b6b6b0b611989f,span=c3b6b6b0b611989f, export=,true] [pool-2-thread-1] [WARN] o.s.c.s.z.FallbackHavingEndpointLocator : Exception occurred while trying to fetch the Zipkin process endpoint. Falling back to server properties endpoint locator.
java.lang.IllegalStateException: Unable to locate service in consul agent: pong-service-port8004-8004
	at org.springframework.cloud.consul.discovery.ConsulDiscoveryClient.getLocalServiceInstance(ConsulDiscoveryClient.java:67) ~[spring-cloud-consul-discovery-1.0.0.M4.jar:1.0.0.M4]
	at org.springframework.cloud.sleuth.zipkin.DiscoveryClientEndpointLocator.local(DiscoveryClientEndpointLocator.java:43) ~[spring-cloud-sleuth-zipkin-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.FallbackHavingEndpointLocator.endpoint(FallbackHavingEndpointLocator.java:45) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.FallbackHavingEndpointLocator.local(FallbackHavingEndpointLocator.java:35) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.ZipkinSpanListener.convert(ZipkinSpanListener.java:144) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.zipkin.ZipkinSpanListener.release(ZipkinSpanListener.java:120) [spring-cloud-sleuth-zipkin-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_60]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_60]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_60]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_60]
	at org.springframework.context.event.ApplicationListenerMethodAdapter.doInvoke(ApplicationListenerMethodAdapter.java:227) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.event.ApplicationListenerMethodAdapter.processEvent(ApplicationListenerMethodAdapter.java:144) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.event.ApplicationListenerMethodAdapter.onApplicationEvent(ApplicationListenerMethodAdapter.java:106) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:163) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:136) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:381) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:335) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.cloud.sleuth.trace.DefaultTracer.close(DefaultTracer.java:131) [spring-cloud-sleuth-core-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at org.springframework.cloud.sleuth.instrument.scheduling.TraceSchedulingAspect.traceBackgroundThread(TraceSchedulingAspect.java:67) [spring-cloud-sleuth-core-1.0.0.BUILD-SNAPSHOT.jar:1.0.0.BUILD-SNAPSHOT]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_60]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_60]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_60]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_60]
	at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethodWithGivenArgs(AbstractAspectJAdvice.java:620) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.aspectj.AbstractAspectJAdvice.invokeAdviceMethod(AbstractAspectJAdvice.java:609) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.aspectj.AspectJAroundAdvice.invoke(AspectJAroundAdvice.java:68) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:655) [spring-aop-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.cloud.consul.discovery.ConsulCatalogWatch$$EnhancerBySpringCGLIB$$353374e3.catalogServicesWatch(<generated>) [spring-cloud-consul-discovery-1.0.0.M4.jar:1.0.0.M4]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_60]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_60]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_60]
	at java.lang.reflect.Method.invoke(Method.java:497) ~[na:1.8.0_60]
	at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:65) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54) [spring-context-4.2.5.RELEASE.jar:4.2.5.RELEASE]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_60]
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_60]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_60]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_60]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_60]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_60]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_60]

Hmm. Interesting. Can you share a sample project that I can take a look
into?

Not easily since it's forked off a private repo.  Let me see what I can do. I think there is a way to duplicate it.

I added you as a Collaborator on my repo.  I hope you get an email with the repo info so I don't need to post it here.  Let me know if you didn't get an email.

Yup I got some access - will check it out today

Can you join Gitter - https://gitter.im/spring-cloud/spring-cloud-sleuth cause I'd like to have a chat with you about this issue

I wonder what we can really do about this actually... Like you said a request came in and instrumentation took place. A span is ready to be sent to Zipkin. It needs an endpoint so either we block span sending until an event was emitted that the app got registered. But if that event never comes? So we would have to have a timeout...
Another solution would be to update that value of Endpoint once an event that the app got registered was received. Then you could have a warning in the logs but only once. ATM you also have once but then the property based solution is used. In this case the next time the dependency based would be chosen.
Another interesting matter is whether we shouldn't skip the /health endpoint.
CC @dsyer @spencergibb @adriancole

I thought we already skip exporting /health traces (so yes, probably we should skip it)? I'm OK with any solution that a) doesn't crash the app, and b) sends the correct endpoint information for all spans as soon as it is known (and doesn't bother trying to fix the race).

So it seems that we skipped /health endpoint and now I've added it on this branch and re-run the apps - I can't see any errors in the logs. I think this is the best solution - let's defer endpoint location until the first usage and let's skip /health endpoint by default

I had already added /health to skipPattern using spring.sleuth.instrument.web.skipPattern so not sure that that part of your fix is actually going to help.  Using the local endpoint definition until it can be read from Consul is a good solution, though.

Hmm the combination of both adding /health + deferring the local endpoint resolution worked for me. But maybe I'm lucky. Check if things in master are working fine. If not then we'll reopen this and  think of some other solution

Looks good now. I'm not seeing the errors anymore.


Suggestion - change version numbers to match targetted Spelunky version

Suggestion - change version numbers to match targetted Spelunky version, e.g.
Overlinky 1.20.4a-r1, 1.20.4a-r2, 1.20.4a-r3, 1.20.4b-r1 and similar :)

Nah


Rename dpNP to dpnp

@diptorupd
It is good initiative. Did you find all dpNP cases? I think DPNP should be renamed too.

@diptorupd
It is good initiative. Did you find all dpNP cases? I think DPNP should be renamed too.

I think I got all the dpNP uses. Will check for DPNP.


[Bug]: Debugger needs to retain user selected filter condition for logs

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Selected filter always resets to default on Logs tab of the debugger on a fresh query/function run - this setting needs to be retained to improve UX
Steps To Reproduce

Add a query/function to a page and run it
Navigate to the logs tab and modify the filter conditions as seen in the video or any other preference
Re-run the query/function and observe the filter conditions have been reset to default

Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/4b7797bb10df4fc6ab25876ea7a1aedc
Version
Cloud

Duplicate of #23108


Question - How to produce fontFamilies?

Hi, just a question:
Seeing that the webFont.js file seems to recognized that there could be plural fontFamilies. But how does one get this out of figma and the Design Tokens plugin? I can only get the singular form.
Thanks!

What do you mean by multiple font families?
One type style may only refer to one family.
What happens in this file (https://github.com/lukasoppermann/design-token-transformer/blob/562bfc634b4e7740a16b8169dac84fbd1c02bbd5/src/web/webFont.js#L3) is that you can replace the figma font-family name. E.g. if figma exports "helveticaNeue" but you need it to be "Helvetica Neue" to work on the web, this function can help.

Sorry, my question was not clear. My desire is to have CSS with fallback fonts: IBM Plex Sans, "Helvetica Neue", sans-serif
i.e., my current output is like:
--mytheme-font-h1: 400 2.625rem/3.375rem IBM Plex Sans
But I want:
--mytheme-font-h1: 400 2.625rem/3.375rem IBM Plex Sans, "Helvetica Neue", sans-serif
I have a silly hack right now that looks for "sans" or "mono" in the font name and appends some hard-coded fallbacks based on that, but it would be a lot better if I could specify that in Figma.

Sadly I don't see a way of how this could be specified within Figma.
I am doing the same with the webFont.js
it used the options provided in the config file for style dictionary. https://amzn.github.io/style-dictionary/#/config?id=platform
So within this options object I would define 'IBM Plex Sans': 'IBM Plex Sans, "Helvetica Neue", sans-serif' and the webFont.js would replace it.
You may be able to use a comment on the type styles and read this in a custom transformer, but I have not done this yet.


Application hangs with "flicker" when loading this logfile

Describe the bug
Using the function to "Scan Old Logs" the application processes all my old logs (even though I don't see any results on the website. . but that's another issue) except the attached one which instead starts to "flicker" the buttons "Manual Re-Sync" and "Scan Old Logs"
To Reproduce
Steps to reproduce the behavior:

Click on "Scan Old Logs"
Select the attached log-file (unzipped of course)

Expected behavior
Successful parse of the log
Screenshots
Additional context
I'm using v1.8.2
UTC_Log - 7-25-2019 6.06.54 AM - 1.zip

Thanks, we'll check this log

Investigation showed that "flicker" happens when you try to upload log generated by MTGA client before latest update (which changed log format). Unfortunately, support of both formats is not going to be implemented. But we will fix this in order to get rid of flicker and show user proper warning message.

Ok. Flicker still occurs in 1.8.3 I noticed. :-)

Just released 1.8.4 fixes this issue


[INTEL MKL] Fix for Batchmatmul regression.

BatchMatmul now uses the BatchMatMulV2 operator, however TF+MKL hadn't been updated accordingly.  Fixed this issue and also added missing unit tests. Since V2 is now the default, I replaced MklBatchMatMul with V2 operator rather than adding a new one.

Temporarily closing this. I will reopen shortly.


Speed up queryByServiceName by removing orderBy from query By Service

@yurishkuro any reason not to do this?

this is a duplicate of already closed #385

Coverage remained the same at 100.0% when pulling 4e19470341e044f8f25b86cd6da4bb798933040b on oibe-remove_order_by_from_query_by_servicename into b8a4fe0c6f9a3a910d46fcce2040cd8799af1313 on master.


With basic auth enabled, k8s startup probe fails

If I enable basic auth  via BASIC_AUTH_ENABLE: true
I'm unable to complete a deployment on k8s due to failing startup probes.  Workaround for now has been to disable the startup / liveness / readiness probes
I can confirm that the endpoint /api/result used for the health check requires credentials if basic auth is enabled.
running from debug container:
We get a 401 without creds:
curl http://localhost:8080/api/result <!doctype html><html lang="en"><head><title>HTTP Status 401 – Unauthorized</title><style type="text/css">...
while if we provide the basic auth credentials, the healthcheck endpoint is available:
curl -u admin:admin http://localhost:8080/api/result []#
Suggestion is to implement a standard endpoint /healthz which is exempt from auth and can be used by the k8s healthchecks

I've been able to workaround this by the following additions.  Will raise a PR for this.
templates/deployment.yaml
    livenessProbe:
        httpGet:
          path: /api/result
          port: http
          {{- if .Values.basicAuth.enabled }}
          httpHeaders:
            - name: Authorization
              value: Basic {{ .Values.basicAuth.base64EncodedPassword }}
          {{- end }}
        initialDelaySeconds: {{ .Values.livenessInitialDelay }}
        periodSeconds: 30

values.yaml
basicAuth:
  enabled: true
  base64EncodedPassword: <encoded value>


Update scalafmt-core to 3.7.17

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.15 to 3.7.17
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6576959) 78.83% compared to head (c01562e) 78.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2779   +/-   ##
=======================================
  Coverage   78.83%   78.84%
=======================================
  Files         466      466
  Lines       15903    15903
  Branches     2604     2604
=======================================
+ Hits        12537    12538    +1
+ Misses       3366     3365    -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Improve Mongodb reference handling

Fixes #1528 and https://github.com/querydsl/querydsl/issues/1525

This looks good to me.

Looks good.


Extend the IT framework to allow tests in extensions

The "new" IT framework provides a convenient way to package and run integration tests (ITs), but only for core modules. We have a use case to run an IT for a contrib extension: the proposed gRPC query extension. This PR provides the IT framework functionality to allow non-core ITs.
The it.sh script takes an option third parameter to specify the relative path to the Maven module that holds the test:
./it.sh test MyCategory extensions-contrib/my-extension-it

Because of the Maven build order, the ITs for an extension must be in a Maven module separate from the extension itself. In this case, my-extension is the extension, while my-extension-it are the ITs for that extension.
The layout in the extension mimics the existing cases module. Provide a Maven file that runs the tests using FailSafe. Provide a cluster directory structured as explained in the IT docs.
Extra Extensions
Contrib extensions are not added to the base Docker image. They can still be used in a test:

Create an extensions directory in the shared folder (mounted at /shared in the container.)
Unpack the extension to this directory so you have extensions/my-extn.
Add the absolute path to the extension in your docker_compose.py file: /shared/extensions/my-extn

Revision to IT Structure
As part of this work, several changes were made to the structure of the existing IT directory.

The Python "template" for Docker Compose moves from templates/Category.py to cluster/Category/docker-compose.py.
A new 'cluster/Category/verify.shscript peforms pre-test checks. The awkward code that was in.it.shto check for required environment variables moved intoverify.sh`.
A new cluster/Category/setup.sh script does any additional setup needed before launching an IT cluster. Use this to add additional files to the shared directory, for example. Using the script is far easier than trying to script in Maven.
The cluster startup and shutdown steps were removed from cases/pom.xml. We were not using them: we now use it.sh to do this work.
The it.sh and cluster.sh scripts are now aware of two modules: the "base" cases module, and the "test" module. Before now, those were the same. Not they can differ.

Prevent Snapshot Downloading
Also added configuration to the root pom.xml file to prevent an attempt to download snapshots from upstream. This most often happens when dependencies are missing and Maven cannot find a required Druid module, and instead tries to ask upstream repos. Bad Things would happen if it actually found such jars.
Release note
Added the druid.extensions.path config setting. This setting is optional and is normally not set. Primarily for testing. See configuration/index.md for details.

This PR has:

[X] been self-reviewed.
[X] added internal documentation for new or modified features or behaviors.
[X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[X] added integration tests.
[X] been tested in an integration test Druid cluster.

This PR is blocked on a failure in the Kafka tests. Debugging failed to determine if a change in this PR caused the failure, or if the tests are just reliably flaky. Kafka failures seem uncorrelated to the changes made while debugging, and the tests fail so often it is hard to determine when a code path might be clean. Let's just put this on hold until the Kafka issue is resolved.

The Kafka tests have failed for the last month. At first I thought it was because the PR contained a change to the way Druid locates extensions. But, I removed that code (having found another solution to adding test-specific extensions), yet Kafka still fails. I suspect the test itself is flaky. The test was converted to the new IT framework to allow debugging (in a separate PR). However, the test ran perfectly on the local machine after the conversion. So, let's just assume the Kafka test is flaky and ignore it.


Ensure commit-statuses box is sized correctly in headers

When viewing commits as commits the commit-status box will be fixed at 30px in height
due to being forced to be this size by a fomantic selector. This PR simply adds a
few more selectors to force this to have height auto.
Fix #18498
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

The requirement for this patch-up comes from _base.less:
https://github.com/go-gitea/gitea/blob/92e81e97e848f95af437694297105ec8fa18365e/web_src/less/_base.less#L1932-L1941
Which appears to come from #13932
I'm not sure if anything is really meant to match that selector anymore.

Can we remove the right class from the popup? That selector is meant to vertically center those right buttons on headers and it's obviously not ideal but I think a better fix is just to remove that class.

Can we remove the right class from the popup? That selector is meant to vertically center those right buttons on headers and it's obviously not ideal but I think a better fix is just to remove that class. The popup is absolutely positioned anyways, so I think right makes no sense on it.

from repo-legacy.js:
https://github.com/go-gitea/gitea/blob/76e31115965164112a6dfdbd297632431e896e5e/web_src/js/features/repo-legacy.js#L426-L436
The right/left says which side the popup appears.

it's our change in _base.less that has made this necessary.

Seems so, we should instead use a class name distinct from fomantic for these right-aligned header contents, which will then allow us to remove that troublesome rule.

Agreed but I think it's kinda difficult to even determine which things are relying on this selector - that's why I simply overrode the individual thing.
I wanted something that was simple to backport to 1.16 without having to make major changes across several templates files.

I think this might be a bit similar to our previous less code where we had at some point overridden right to always mean float right...

The .ui.attached.header .right:not(.dropdown) is specifically for vertically centering those right-aligned things in box headers which isn't something thats natively possible with fomantic. I will check the possiblilty of just adding a unique classname, it's a better solution for sure.
Ideally, I guess we should just flexbox all these headers instead, but it'll be a even more involved change.

Ideally, I guess we should just flexbox all these headers instead, but it'll be a even more involved change.

Why don't we do that after we've merged this and backported it to 1.16 then we can properly fix this.

make L-G-T-M work


Support FusedLinearCrossEntropy for Gemma2

Summary
Resolves #127.
Fuse softcapping into cross_entropy kernel, so it can be called by fused linear cross entropy function.
Testing Done
Current monkey patch for Gemma2 can't pass covergence test without flce either. The test is commented out for now.

Hardware Type:
[x] run make test to ensure correctness
[x] run make checkstyle to ensure code style
[x] run make test-convergence to ensure convergence

@ByronHsu Hi! Can you review this PR please? It thinks to me that this improvement will be very useful)

@pansershrek merged. can you try by installing liger-kernel-nightly?

Hi! My colleagues say it's working fine


[BEAM-8858] sdks/java/extensions/sql to declare used-but-undeclared dependencies

https://issues.apache.org/jira/browse/BEAM-8858
As per Gradle Lint Plugin output , restoring these dependencies that have been removed by PR #9189.
CC: @iemejia @kennknowles @vectorijk

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Argh just tested it against the latest 2.17.0-SNAPSHOT and the issue is there so it should be cherry picked into 2.17.0 (and 2.18.0). Changing the ticket to reflect that

Since 2.18.0 already has the release branch cut, how about just targeting that?

It is pain, but I am afraid that future users of 2.17.0 will find the problem too (because the deps are not declared in that version too, error started since the move to vendored calcite). SQL will break at runtime because of the non available deps (note that users can still do the workaround of defining the missing deps manually in their projects). We can add a note to the release notes but probably it is worth to fix. So I cherry-picked it in both branches.

One extra thing I tested this with the latest SNAPSHOTs and confirmed that we still need to get the Nullable annotations fix (#10324) in and backported, otherwise Schema-based PCollections of Avro will break on SQL too.

@iemejia Thank you for checking.


add schedule by user

editable
deletable by user
auto delete by uploaded upcoming stream

add from YouTube app share intent


Code for running the Hartree-Fock VQE experiment

All necessary scripts and code for collecting 1-RDMs, calculating fidelities, and optimizing RHF wavefunctions.

mypy does not seem to run locally.  I opened Issue #386 to check on this.  The incremental coverage is also broken.  It is asking for coverage on _test files despite .coveragerc providing an exemption.

@ncrubin  mypy passes on travis.

@vtomole I appreciate your feedback on this PR. And ultimately, we plan to reorganize things in this PR over the next couple of weeks. But for reasons that will be apparent very soon, we want to merge this quite quickly (probably today). Over the next few weeks we'll do a better job of integrating things with OpenFermion-Cirq. In particular, we should abstract some of the functionality here as more general library code that can be used for more than just this experiment. Ultimately I hope we can have almost no library code in the experiment repo, to the point that the entire experiment repo can be moved outside the library (to the top level directory of the GitHub) and just import things from the core of the library. But like I say, due to a time crunch for reasons that will be more apparent very soon, we are going to merge this in a somewhat suboptimal way first and then do it better later. Not a good example of how we like to run things, but alas...

I strongly disagree with disabling continuous integration checks so that things can be merged faster. We have them to prevent exactly this kind of thing.

@Strilanc , as far as I can understand it, the incremental coverage check is not respecting the coveragerc file

It does look like the coverage is being incorrectly computed.
There is a true positive on a test test_prepare_slater marked "skip" because it's using == instead of cirq.approx_eq. That one can be fixed.

I have figured it out.
d05033ad continuous-integration/.coveragerc (Craig Gidney 2018-06-29 15:56:12 -0700  4) # Failure to do so will result in false positives.
d05033ad continuous-integration/.coveragerc (Craig Gidney 2018-06-29 15:56:12 -0700  5) include = ./*
3d4f62c7 dev_tools/conf/.coveragerc         (Nick Rubin   2020-04-08 11:30:54 -0700  6) omit =
3d4f62c7 dev_tools/conf/.coveragerc         (Nick Rubin   2020-04-08 11:30:54 -0700  7)     # test files should be excluded from coverage
3d4f62c7 dev_tools/conf/.coveragerc         (Nick Rubin   2020-04-08 11:30:54 -0700  8)     *_test.py
04fe6aeb dev_tools/conf/.coveragerc         (Nick Rubin   2020-04-07 21:00:28 -0700  9)

Nick turned off coverage annotation for tests, and so now the coverage check is freaking out because there's no coverage annotated for the tests. Just need to delete those lines in coveragerc. :P

After discussing with @Strilanc we clarified what needed to happen with this PR.  We've cleared up the testing issue by making sure that code skipped by tests is also skipped by coverage.  The skipped tests are mostly a stop gap measure for now.   As @babbush said, this will be remedied over the coming weeks.


load_data() module

Hey, Thanks for gathering all the CNN model + ImageNet Pretrained Models in a repo. I am confused about load_data() module. It would be nice if you can explain more or add some code how to write load_data() module. For example, there are two folders which one for training images and one for test images. How am I going to write load_data() module? Do you have any code which helps me?
Thanks.

I also want to get the load_data() module.......
Thanks.

This code might serve as an example:
def load_data():
    # load the dataset (it's a normal numpy array, samples x features (features = channel x width x height))
    dataset = np.load("dataset.npy")
    # load the targets (they must be one hot encoded; np.array([1,0]) rather than 1
    targets = np.load("targets.npy")
    # select training and validation / test
    x_train = src_dataset[:-1, :, :]
    y_train = targets[:-1, :, :]

    x_test = src_dataset[-1:, :, :]
    y_test = targets[-1:, : , :]

    y_train = np.reshape(y_train, (len(y_train), 1))
    y_test = np.reshape(y_test, (len(y_test), 1))

    return (x_train, y_train), (x_test, y_test)

Please correct me if something is wrong or it could lead to any errors

@margaro95  Could you share the source code that load my own dataset ? I am a fresher. Thank you very much.


GitHub Actions: Remove deprecated set-output command

The GitHub set-output command is now deprecated which results in numerous warnings like at the bottom of https://github.com/casey/just/actions/runs/7603050227
This pull request replaces the old syntax by using the environment file $GITHUB_OUTPUT as recommended in the deprecation notice.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands
Related to #1868
These tests are modified:

junk_is_other()
valid_version_is_release()
valid_version_with_trailing_characters_is_other()
valid_version_with_lots_of_digits_is_release()

Awesome, great PR! I've been procrastinating dealing with these errors. The output of ref-type is used in release.yaml, so I think that needs to be updated too.

Don't worry about the lint failure, I'll fix that.

Linter: Shorter lines are not wrapped

Nice, thank you!

My pleasure.  Just is a cool tool!!


Lost blue on the United Nations flag

Reference https://github.com/godotengine/godot/issues/48243

@fire today the css styling was merged :)
it's blue now

The css styling feature must be included in thorvg v0.8, its viewer as well.
The next major up version will be released in early March.

@fire https://github.com/Samsung/thorvg/releases/tag/v0.8.0
the viewer has been updated as well.

Confirmed fixed. :+1:


Color palette is now more colorblind-friendly

I chose a subset of the Wong palette described here:
https://www.nature.com/articles/nmeth.1618
closes #450

Looks good, one small comment on the color choice. Otherwise :woman_dancing:

Thanks @nicholas-esterer ! Looks good to me, :woman_dancing:
@surchs the black color is indeed very distinct but I'm not sure it renders that well for semi-transparent overlays. I'll let Nick decide whether he wants to try it out ;-).

It's true that black is more contrasting and it works when changing its alpha channel for a segmentation image

but to me it seemed sort of out of place maybe? For example if there were text on the image it would probably be in black. Also I hoped to solve the problem that the yellows and blues are sort of similar, but it seems it isn't possible for 5 colors, even if you include the black (this website tries to simulate the effect).
https://davidmathlogic.com/colorblind/#%23000000-%23E69F00-%2356B4E9-%23009E73-%23F0E442-%230072B2-%23D55E00-%23CC79A7
So probably I will just leave it as is :-)