[DT] Unify encoding materialization pass into a single pass.

The revision creates a generic materialization pass and uses it for backends that implement data-tiling. After months of development, we identify that the needs of GPU is a superset of the needs of CPU. To be more specific, it has the additional "swizzle" field in terms of layout. It means that the GPU set_encoding/unset_encoding lowering patterns cover the needs of CPU path. The lowering of contraction ops is different. CPU lowers it to mmt4d ops, while GPU lowers it to multi_mma op. However, the lowering of contraction is implemented through attribute interface. Thus, we can have a generic pattern to lower contraction ops.
To make the review process much easier, the revision is created by 5 commits.

It directly creates the MaterializeEncoding pass and copy-paste the GPU patterns: SetEncodingOpLoweringConversion, UnSetEncodingOpLoweringConversion, and MaterializeContractionOp. In the first commit, it also updates the GPU tests to use the new pass.
The GPU data-tiling does not support element-wise generic op lowering atm. The second commit moves the pattern to shared pattern set and bail out when swizzle is present. This is an NFC for both pipelines.
The third commit replaces the existing materialization pass with the generic pass, and deletes all the legacy passes.
The four commit moves the lit tests from Common/[CPU|GPU]/test to Common/test.
Now there are duplicate patterns for set_encoding, unset_encoding, and contraction ops lowering. The last commit deletes the legacy patterns, and move the patterns from MaterializeEncoding.cpp to where the legacy patterns locate. Furthermore, it renames the file as MaterializeEncodingPatterns.cpp.

The revision retains the MaterializeEncodingIntoNop pass, and add a TODO item. Because it is still used by MaterializeHomogeneousEncoding pass. It can be deleted once we deprecate the early materialization path.

This depends on https://github.com/iree-org/iree/pull/19452 and https://github.com/iree-org/iree/pull/19453


added changes markdown

Having a look at if we can maintain a changes list, with the hope that we might be able to see what's been changed and maybe help clients find where they're up to...

I love this idea. I am updating Prysm as we speak because I missed several merged PRs...

Yes that would be great info for downstream consumers

Ok cool, lets see how we go keeping it up to date I guess :)


Simple smart contract project for level 0

Description
@Vikash-8090-Yadav I want to add a simple smart contract project for the level 0 folder. can you assign this issue to me under hacktoberfest'23

@Vikash-8090-Yadav can you change the label SWOC to hacktoberfest


can it support https ?

my website has ssl and i really need it

Unfortunately HTTP over TLS is not supported by HTTPRequest yet.

This is ridiculous, junk


Pin style CI to nightly with components

bors: r+

bors: r+

bors crashed.
bors: r+

It says it was cancelled.
bors: r+

This is either an upstream bors issue or a permissions issue. Asked on bors forum, will look at this myself again later.
bors: ping

Tweaked restrictions so one more try of
bors: r+


[Feature][dolphinscheduler-source-plugin] Support oss datasources

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
No response
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

这个功能我来帮忙实现可以吗？

这个我这边已经实现了，代码提交中，分了几部分


Uploading to Github?

How do you handle source control with this? I know VSCode has source control built in.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47be9e62-a0a7-b842-ab8d-e3611c3ea75a
Version Independent ID: 15fb316f-4166-dc73-e4bb-31dab82903fd
Content: Create and manage automated workflows with Visual Studio Code - Azure Logic Apps
Content Source: articles/logic-apps/quickstart-create-logic-apps-visual-studio-code.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@cconrado Thanks for the Comment. We are actively investigating and will get back to you soon.


Show package info sometimes doesn't correctly display version of Winget packages

This problem happens only in the update and uninstall sections, and only for Winget packages. For example, you can see the installed version of this package and the new version available:

However, if I click show more info, this same information isn't displayed:

On the Discovery tab this problem doesn't happen. So, I believe it only does when there's nothing besides "Latest" in the combo box. Also, this only affects Winget apps because scoop ones always have their version under "Latest".

Fixed!


ToggleSwitch not aligned correctly to right

Describe the bug
ToggleSwitch not get aligned to right correctly, even after set OffContent="" OnContent="". Others controls get rendered correctly, but looks like ToggleSwitch have some right margin even when there is nothing to show there.
Maybe is because of:
<x:Double x:Key="ToggleSwitchThemeMinWidth">154</x:Double>

Screenshots

Desktop/Platform (please complete the following information):

OS: Windows 10
FluentAvalonia Version 1.3.2
Avalonia Version 0.10.13

Additional context

Duplicate of #36
Correct, you can set the MinWidth to 0 and it will align correctly. The MinWidth comes from the WinUI design

Yes, your are right, I didn´t check to set MinWidth to 0, just tried with Width to 0.


[WIP] Move holland to a virtual environment

This change allows for holland to be completely inside the virtual
environment.

 The main issue is it is calling holland the old way. We either need to create a symlink or modify Jenkins to call holland accordingly to the new way.

The main issue is it is calling holland the old way.

@cloader89 what is the "it" here?

@alextricity25 @nategraf and I worked on this today, created a PR on Jenkins, which depends on this issue.
https://github.com/rcbops/jenkins-rpc/pull/620

@sigmavirus24 the holland tests are not running according to the change to the location of holland.

Ok I will do them today. Thanks.

@cloader89 can you please squash these 2 commits into 1

Just a little nit but holland-vevn-9eb62140a2c8ff56.yaml has a typo. vevn should be venv.
Also please squash the commit.

@mancdaz fixed. @ameserole fixed.

RPC-AIO-Ceph-Liberty-PR: Fail

testing...

👍
on a greenfield with master, I got holland in a venv and was able to run a holland bk from within the venv.

Trusting @mancdaz's testing. This looks very well done to me. 👍


Is any setting for always expanding all outline section level?

I don't understand the question, please provide more details.

Adding an expand all button as requested in #54941 might also be a workaround for this issue.

@zoehneto

Agree 100%; structured text (Markdown docs with a few levels of nesting) is exactly how I ended up at this issue
Personally I'd prefer 'expand all' as a setting; mouse interaction would kill the "quick glance what's happening in this document" utility of an outline

@zoehneto
* Personally I'd prefer 'expand all' as a setting; mouse interaction would kill the "quick glance what's happening in this document" utility of an outline

As a fix for now, you can try CTRL+SHIFT+O which will also give you a "quick glance" without using the mouse :)

Also I want to note that there is a bug sometimes with the "expand all" button that is implemented now from #54941 where the outline is collapsed completely, but the button doesn't recognize that and only offers a choice to "collapse all" which renders the button useless until you manually expand the outline using the tree nodes.

/duplicate of https://github.com/microsoft/vscode/issues/53262
Closing as dupe of https://github.com/microsoft/vscode/issues/53262 - if we add setting they will allow for collapsing and expanding


Username uniqueness should be enforced at the database level

Unless I'm not thinking clearly, there should never be a scenario when there are multiple users with the same username.  All usernames should be unique and this should be required and enforced on the DB level if possible.
Right now, it is only enforced at the UserService level.  We have seen some weird behavior where we have duplicate user accounts created in the Orchard DB, where the User ID is only 1 number apart - making me think there's a race condition somewhere (in our code).
That being said, we have a custom membership service that uses the UserService to create and manage user accounts - and are syncing those accounts with an external repository for future SSO support.

The solution would be to perform checks on application level and remove the race condition.
We're not adding DB-level UNIQUE constraints (as well as NOT NULL) on purpose. NHibernate controls when and how data is flushed to the database. With constraints on this could lead to undesired behavior.

Under every single other circumstance, I agree.  I don't agree, however, when it comes to something as application critical as unique user names and identity.
While this can be enforced at the application layer, it should be so that even if it isn't enforced at the database layer, that there would be absolutely no way to create two users with the same username.
The race condition occurs because we are creating a mirrored user account in an external database and piggy backing off of that for authentication, so that we can implement SSO.  The other part of this is that the UserPart has an additional UserProfilePart associated with it, where the UserProfilePart includes first and last name.
My hunch is that the user record is being created twice in this case, but I'm not sure why... and it's incredibly difficult to reproduce (i.e. doesn't happen every time).
Out of 7500 user accounts, we have 13 that are duplicates.  That's how rare of an occurrence this is.
I will look into it on the coding end some more, but thought that enabling a uniqueness constraint could help point out when and where this issue occurs.  In fact, I may try setting that constraint locally to see if I can get it squared away.

Closing this - as changing the schema would never be feasible today.

Actually, reopening this.
Can others verify that they have duplicate records in their UserPart table?
SELECT TOP 1000 [Id]
      ,[UserName]
      ,[Email]
      ,[NormalizedUserName]
      ,[Password]
      ,[PasswordFormat]
      ,[HashAlgorithm]
      ,[PasswordSalt]
      ,[RegistrationStatus]
      ,[EmailStatus]
      ,[EmailChallengeToken]
  FROM [dbo].[Orchard_Users_UserPartRecord] as b

  where b.UserName in (
  Select UserName from [dbo].[Orchard_Users_UserPartRecord] as a
  group by UserName having count(UserName) > 1
  )

  order by username,id ```

I agree with dcinzona. When we install 2 instances of Orchard on 2 different servers (like Farm scenario), and point them to the same database there is no way to enforce uniqueness of username reliably on application level. So Sometimes the uniqueness of data should be enforced on the storage level.

I think I figured out why there's a problem with enforcing uniqueness.  Orchard, by design, doesn't perform hard deletes.  This means if you delete a user, the user still exists in the table.  Therefor, they wouldn't be able to enforce the uniqueness constraint lest old usernames also be unavailable.
My recommendation would be very difficult to implement, and that is to perform hard deletes on security related content, such as user accounts.  I've noticed that the database retains users AND their old passwords.  I understand that this allows for the ability to restore old or deleted accounts and retain the password - but from a security perspective, these should be completely deleted.
In fact, maybe ONLY the users module should perform hard deletes.
I'm not sure how this would affect the Audit module in 1.9....

And also because of case sensitivity that needs to be handled in code.


cache space leaking in writeback mode

closes #2225

Codecov Report

Merging #2227 (fc5df99) into main (6c7c91d) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2227      +/-   ##
==========================================
+ Coverage   61.70%   61.84%   +0.14%
==========================================
  Files         137      137
  Lines       25035    25034       -1
==========================================
+ Hits        15447    15482      +35
+ Misses       7783     7753      -30
+ Partials     1805     1799       -6

Impacted Files
Coverage Δ

pkg/chunk/disk_cache.go
79.80% <100.00%> (-0.54%)
:arrow_down:

pkg/fs/fs.go
76.87% <0.00%> (-0.79%)
:arrow_down:

pkg/meta/redis.go
71.61% <0.00%> (+0.04%)
:arrow_up:

pkg/meta/sql.go
66.43% <0.00%> (+0.37%)
:arrow_up:

pkg/meta/tkv_mem.go
88.43% <0.00%> (+0.57%)
:arrow_up:

pkg/vfs/writer.go
79.66% <0.00%> (+1.01%)
:arrow_up:

pkg/vfs/reader.go
82.84% <0.00%> (+5.65%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7c91d...fc5df99. Read the comment docs.

I think we should  just  modify  remove function.
func (cache *cacheStore) remove(key string) {
cache.Lock()
path := cache.cachePath(key)
if cache.keys[key].atime > 0 { -------->   replaced with       if cache.keys[key].atime > 0 && cache.keys[key].size > 0 {
cache.used -= int64(cache.keys[key].size + 4096)
delete(cache.keys, key)
} else if cache.scanned {
path = "" // not existed
}
cached.used is caculated as only read cached size and should not add staging block. And when add staging block ,size argument is set as < 0.
func (cache *cacheStore) stage(key string, data []byte, keepCache bool) (string, error) {
stagingPath := cache.stagePath(key)
if cache.full {
return stagingPath, errors.New("Space not enough on device")
}
err := cache.flushPage(stagingPath, data)
if err == nil {
stageBlocks.Add(1)
stageBlockBytes.Add(float64(len(data)))
if cache.capacity > 0 && keepCache {
path := cache.cachePath(key)
cache.createDir(filepath.Dir(path))
if err := os.Link(stagingPath, path); err == nil {
cache.add(key, -int32(len(data)), uint32(time.Now().Unix()))              --------> look at this line
} else {
logger.Warnf("link %s to %s failed: %s", stagingPath, path, err)
}
}
}
return stagingPath, err
}

Agree with this PR!


Showcase code not generating plot

Using the following code does not generate the expected plot as shown in the showcase documentation:
from matplotlib import pyplot
from fuzzylogic.classes import Domain
from fuzzylogic.functions import R, S, alpha
pyplot.rc("figure", figsize=(10, 10))
T = Domain("test", 0, 30, res=0.1)
T.up = R(1,10)
T.up.plot()
I am using python3.   The code runs without any apparent error or issues.   However, no plot is generated.   I placed additonal code after the T.up.plot() to pause the program and still no plot output.
Any suggestions for generating the plot files as expected?
Thank you very much

How do you run the code?
I just tried to run the code in Thonny, where it behaved pretty much like you described, but when I run it in a Jupyter Notebook in vscode, it runs as expected.

from matplotlib import pyplot
from fuzzylogic.classes import Domain
from fuzzylogic.functions import R, S, alpha

pyplot.rc("figure", figsize=(10,10))
T = Domain("test", 0, 30, res=0.1)
T.up = R(1,10)
T.up.plot()
**pyplot.savefig('foo.png')**

should work either way. Closing the issue as solved.

Plot is correctly save to file.
Thank you very much for the support.


Suggestion: Include supergfxctl in asus images

The asus-linux project recommends in its documentation that users install supergfxctl from their repository when setting up their utilities in order to enable gpu-switching functionality via the system tray icon and cli program. This is important for users to be able to disable the dGPU on intel+nvidia, amd+nvidia, and amd+amd gpu systems to save battery.
This package is not included in uBlue's asus images. I believe it would make sense for it to be included given its potential benefit for users with dual-gpu laptops.

Even though the rog-control-center gui still works without it, it does want it to be there, and perhaps other parts of the program wont behave correctly without it.


Multiple loadouts for a single pawnkind not possible?

I'm trying to get a certain pawnkind to be able to select between two outfits and weapon sets. What I've done is to make each outfit into their own pool and weight each of them to 100% so that when the pool is selected they're guaranteed to spawn.

For reference, these are the apparel sets I've assigned to pools 1 and 2, respectively.

I thought that this would result in the pawnkind being able to spawn with one of two loadouts. However, they always spawn with only parts of the pool equipped, or even mixed and matched. I made sure to tick "force only selected" and I've also tried to increase the apparel value to very high numbers. The following image shows the pawn wearing an armor piece from pool 2 and the scarf from pool 1

They're still able to equip the full set if I changed the selection mode to "always picked". Did I misunderstand what "pools" meant in the options or did I do something wrong? Please advise.

Sorry it took me a while to look into this, had some family issues so didn't have my PC to hand to check. Answer is that indeed you've (quite reasonably!) misunderstood pools.
What actually happens is as follows a pawn will spawn with:

Every item listed as always picked
Any items listed as Random chance to be picked are all rolled for individually, so you may get between 0 and all of them.
1 random item from Pool 1, the item chosen will be determined by the weight or zero if no items in pool 1
1 random item from Pool 2, the item chosen will be determined by the weight or zero if no items in pool 2
1 random item from Pool 3, the item chosen will be determined by the weight or zero if no items in pool 3
1 random item from Pool 4, the item chosen will be determined by the weight or zero if no items in pool 4

This thing could do with some better docs couldn't it...

As such, no it's not currently possible to force one of several outfits. I'd have to add "outfit 1", "outfit 2" etc as more options to support this.

Though I will say there's kind of a way to do this. TC allows you to edit pawn kinds individually. Raid groups/ trader groups etc are made up of sets of pawn kinds so for example you might have a faction which has both mercenary gunner and mercenary elite. If you set a specific outfit for gunner and elite respectively then if you got a raid with those two types of pawn you'd have your desired one of two loadouts. So within a pawn kind, you can't but by configuring the pawn kinds separately you absolutely can do it.

I see, thank you very much!


Help article for "Querying models based on their relations existence" only describes list relationships

https://www.prisma.io/docs/support/help-articles/finding-entities-based-on-relation
This help article only explains how to query existence on a list relationship, but not if the related model is singular.
Using the same example schema:
model User {
  id    Int    @id @default(autoincrement())
  name  String
  posts Post[]
}

model Post {
  id     Int   @id @default(autoincrement())
  user   User? @relation(fields: [userId], references: [id])
  userId Int?
}

How would one write a query on all posts that have a user? Or that don't have a user?
await prisma.post.findMany({
  where: { user: /* user exists? */ },
})

await prisma.post.findMany({
  where: { user: /* user does not exist? */ },
})

Still wondering about this. Is this the correct syntax?
await prisma.post.findMany({
  where: {
    user: { isNot: null }
  },
})

await prisma.post.findMany({
  where: {
    user: { is: null }
  },
})

Hey 👋
Apologies for the delayed response. You can filter for null if a relation is singular as follows:
await prisma.post.findMany({
  where: {
    author: null
  }
})

We'll add this to the docs soon. 🙂


chore: incentives feature flag

Checklist

[ ] I have read the coding guide.
[ ] My change requires a documentation update, and I have done it.
[ ] I have added tests to cover my changes.
[ ] I have filled out the description and linked the related issues.

Description

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Shouldn't this flag be ignored when the mainnet flag in the configuration is set to true: mainnet: ture?

This PR just adds the feature flag, the logic that uses the flag will be a different PR


[chip] Sensor control rst_ni input is connected to aon reset domain

Description
Sensor control that is part of the main power domain is not reset when vcamin power is turned off.
Its signal reset is connected to aon reset: rstmgr_aon_resets.rst_lc_io_div4_n[0].
CC: @arnonsha @yehuda-bejar @meisnere

ah yes good catch, we should fix this.
Thanks for the find.

@GregAC If possible to give this issue high priority it will be great since it is needed for UPF testing.

Bumping to P1 for visibility for project planning purposes. May move back to P2 once properly assigned (with the understanding it will be at the top of the queue for things to fix at P2 level).

Hi @arnonsha, We checked on our end and confirmed that sensor_ctrl should be part of the aon domain. Can you update this configuration on your end? Thanks

Yes will do. Thanks for confirming

done on our side. closing


Improve error related to variable assignment

Description:
$title.
type x record {|

|};
public function main() {
    x = 5;
}

Above program gives an error as incompatible types: expected 'typedesc<x>', found 'int'. But we can't assign value to a type definition.
Related Issues (optional):
#23847

type x record {|

|};

public function main() {
    typedesx<x> td = x;
    x = td;
}

For the above program, it gives error as
ERROR [test3.bal:(33:20,33:20)] invalid expr in assignment lhs
ERROR [test3.bal:(34:9,34:11)] undefined symbol 'td'

Need to improve error related to this also.

With beta1 above issues have been fixed. Hence closing this issue.
type x record {|

|};
public function main() {
    x = 5;
}

This now results in
ERROR [main.bal:(5:5,5:6)] cannot assign a value to a type definition
ERROR [main.bal:(5:9,5:10)] incompatible types: expected 'typedesc<x>', found 'int'

type x record {|

|};

public function main() {
    typedesx<x> td = x;
    x = td;
}

This now results in
ERROR [main.bal:(6:20,6:20)] invalid expr in assignment lhs
ERROR [main.bal:(7:5,7:6)] cannot assign a value to a type definition
ERROR [main.bal:(7:9,7:11)] undefined symbol 'td'


new Blob error on android native browser

new Blob(zip.js line 198) has error on some android devices.
I know below bug fix.
https://github.com/TEA-ebook/readium-js/commit/a7d82f92df4213f4153fc77f58ba37406c1e60ca
but zip.js:198 is different position.

Related issue: https://github.com/readium/readium-js/issues/72#issuecomment-55868127


Feature Request • Drag file from nagivator into editor to insert path

Problem

When I drag a file from the navigator, I expect the file path to be inserted into the editor, upon where I place it.
I expect this functionality when I am writing the path for image files, for html files in the href property, and other code files when I am writing <script> and <stylesheet> tags.

Proposed Solution
When I drag a file from the project navigator, the path of that file should be inserted at the location where I let go of the click-and-drag. This capability is found in other text-editors, including Xcode, and is very helpful.

You may want to check out https://atom.io/packages/drag-relative-path


Port Close Logic.

In the source, I see you keep a reference to the writableStreamClosed promise.  However, you don't await this promise nor is there any logic to close the writer, reader, and port.  I also saw the reader.releaseLock line commented (I don't recall if there was a writer.releaseLock).  Maybe there can be a Close button to exercise this logic, which would allow the user to reuse the serial port without necessarily having to close the browser tab?

Hitting the refresh button when you want to connect to a new device is a problem?


Replace tagBuildOrRelease with Powershell inline script

Summary
The tagBuildOrRelease task has been disabled/removed from the Azure DevOps organization. Replace with built-in support for tagging builds via Powershell inline script and logging commands.

Release Notes Entry

/backport to release/8.x

/backport to release/7.x

/backport to release/6.x

/backport to feature/9.x


GameObject deconstructor crashes the engine on some systems

The GameObject deconstructor when called by std::vector::push_back() seems to crashes the engine on some systems.

A read accses violation triggeres on the line
delete reinterpret_cast<T*>(attr.content);
in GameObject::removeAttribute function
when the attribute is the placeholder (name = "")
and the function is called by the deconstructor of GameObject which in turn needs to be called by
std::vector::push_back()

This seems to happen seemingly at random

Couldn't reproduce


Combo events which include left or right arrow keys will fire even if only the arrow key is pressed

For instance, with the following code:
Mousetrap.bind('backspace+capslock+left', function(e, combo) {
	alert('You pressed: ' + combo);
}, 'keydown');

Pressing just the left arrow key will trigger the alert, even though the user should have to press it in combination with the backspace and capslock keys.
This is a problem, for instance, in a video game in which diagonal movement is allowed, as different behavior is required when a player presses, e.g., left alone versus up+left.
See https://jsfiddle.net/59cgxmw3/

Key combos only work with modifier keys. See #323

Sorry, looked through the issues but didn't realize these were related. Thanks for the quick response! Can you recommend a library which supports combos without modifier keys?

For anyone interested, I'm just using the solution found here:
http://stackoverflow.com/questions/10655202/detect-multiple-keys-on-single-keypress-event-in-jquery


[Request] Add the possibility of choosing the quality of the artwork

As the title says, it would be very good if this possibility existed. It's not just about the visuals, but it has a lot of influence on the speed of creation of the list. I participated in the improvement of the tmdb helper and the implementation of this option. You have a link with the discussion. The plug-in fen, which has a similar purpose as an elementum, also has this option and works fast as lightning. Currently, elementum pulls artwork of the highest quality, which affects performance, and it is especially pronounced on android devices and custom skins. Tmdb api supports this feature, fanart does not. But you can also do a combination of artwork from tmdb and fanart. Read the discussion a bit when you have time. I think you will be surprised at the difference in performance. 😉
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/617
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/pull/638

Hi @elgatito @antonsoroko. I see you are working hard on the new update, and I am very happy about it. Elemntum has been one of my favorite addons for years. Is there any chance that this request of mine will be taken into consideration? I think it will mean a lot in the speed of opening any list. Thanks in advance.

@matke-84

If I understand correctly, this change will improve performance only for skins that use script.module.metadatautils.
I checked 3 standard skins that I used (Confluence, Mimic-LR, Aeon Nox: SiLVO) - I do not see it in their dependencies.
So for standard skins - maybe there will be some minor speed improvement because of smaller download size and maybe faster resize if skin uses even smaller size than the smallest size from your proposed sizes.

We use w1280 for tmdb for all image types. Not sure if it is big resolution. See https://github.com/elgatito/elementum/blob/efdcb9af863f3fca5cf63afe3c80da8249cc0ccb/tmdb/show.go#L507 for more technical details.

For fanart tv we use what they provide, since they have only 1 size. But you already know that.
But unlike that tmdb helper we completely override all tmdb images with images from fanart tv if you enabled setting to use fanart tv, which makes more sense, imho.

But I think we can add simple option to change this default w1280 to different size, without changes like mixing images from tmdb and fanart tv.
Personally I do not care about images, latest changes that I made were to simplify and standardize the image related code and to remove any image related discrepancies between trakt and tmdb lists (code was different , now it is the same).
Thus it would be nice to have some pre-defined sizes, instead of defining out own sizes.
I guess we can re-use sizes from https://github.com/jurialmunkey/plugin.video.themoviedb.helper/pull/638#issuecomment-1031073847
Does it sound ok?

@antonsoroko
No. Nothing to do with metadatautils. My skin no longer uses metadatautils. The bottom line is not to use the highest resolution images when it is not necessary. Fanart images, posters and clearlogos are very often very high resolution from tmdb by default. Most skins do not need such a high resolution. This is to be noticed when you scroll through movies and tv shows, that all fanarts are displayed with delay. Images from fanart.tv serve mainly as a fallback for tmdb images because there is a much larger base on fanart.tv. Fanart.tv also offers some artwork that tmdb doesn't offer (tmdb only offers posters, fanart and clearlogo) so it is used for that as well. I see now that you downsized to w1280 but I think it was 4k for fanart some time ago. In principle, the scheme from the tmdb helper can be used. Just a note about the tmdb artworks. A lot of fanarts have text with roles, synopsis... on them and it looks very ugly. Try using it backdrop without iso_639_1 value for fanarts and backdrop with iso_639_1 value for landscape art. Unfortunately, fanart.tv is sometimes slow, but it is necessary and you have to leave it as an option when you turn on fanart.tv to display all other artworks (banners, cleararts, disk...). If I can do anything else, feel free to contact me.

@matke-84

it was w1280 for last 3.5 years, before that it was w500, see https://github.com/elgatito/elementum/commit/a4a3cc807e327cc333686c97d623eec6f0b7cf31
Elementum actually prefer images with iso_639_1 because elementum has language settings and supports localization. I do not think this will be changed. But maybe @elgatito has different opinion.
As I wrote above, if fanart.tv is enabled, Elementum  uses fanart.tv for everything, not only for fanarts (but it can use tmdb as fallback, e.g. if fanart.tv does not have image at all or does not have image for user's language). If I understood correctly the "issue"  you linked - tmdbhelper uses fanart.tv only for fanarts. I do not think we should do the same, but again, maybe elgatito has different opinion.
Btw, what is the name and repo of your skin?
So in the end, in your opinion as skin developer, does it make sense to use images smaller than w1280? If yes, we can add such option.

This request requires properly rewritten Art selection.
Taking in mind Trakt is not providing art at all, we first select Art from TMDB, and then if Fanart is available and configured - we overwrite TMDB Art with Fanart.
And we always check for language in Fanart Arts, for any type of Art.
I don't see anything bad with implementing a proper Art selection, but this needs a good refactoring and clean setup for each Art type.

But just for "choosing size of image" - we can make simple change - set of sizes (borrowed from link i posted above) that user can select. Instead of hardcoded w1280, I mean.

But just for "choosing size of image" - we can make simple change - set of sizes (borrowed from link i posted above) that user can select. Instead of hardcoded w1280, I mean.

Yes, I support proposed setting to select quality that would translate into different sizes, depending on the type of Art. (as done in tmdbhelper)

@matke-84 please test this build -
plugin.video.elementum-v0.1.99-23-gd8f7ef7.windows_x64.zip
i used the following sizes:
https://github.com/elgatito/elementum/pull/111/files#diff-2a10e699183778675910d9b2aa96b31a37981b5c0c9df1e256e582d45ed76dd5R29-R31
	//                                  Original    High    Medium  Low
	ImageQualitiesPoster    = []string{"original", "w780", "w500", "w185"}
	ImageQualitiesFanArt    = []string{"original", "w1280", "w780", "w300"}
	ImageQualitiesThumbnail = []string{"original", "w780", "w500", "w185"}

you can see all available sizes here https://github.com/elgatito/elementum/pull/111
so if something does now look good - please tell me and i will change those values.
(also this build will post log messages into log file with the sizes that were used.)

Hi @antonsoroko. This is great news. First of all, thank you. I tested it. Here is my suggestion.
        //                                  Original    High    Medium  Low
	ImageQualitiesPoster    = []string{"original", "w780", "w500", "w342"}
	ImageQualitiesFanArt    = []string{"original", "w1280", "w1280", "w780"}
	ImageQualitiesThumbnail = []string{"original", "w780", "w500", "w342"}

Any resolution below w342 is too poor quality even for smaller screens. I see that you use a poster for thumbs, so that's what I wrote to you. In TMDb helper I think backdrop is used for thumbnail so it took me a while to figure it out. :-)
I think you forgot about clearlogo (logo). It also supports the TMDb api. In that case, it would go like this.
       //                                  Original    High    Medium  Low
   ImageQualitiesClearLogo    = []string{"original", "w500", "w500", "w300"}

This is why I mentioned that iso_639_1 is not used for fanart. It looks great for landscape thumb, but the fanart itself is pointless with this inscription. In TMDb helper how it is solved (it should be this).
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/commit/e622468dadc91dcc353817223e942c3bca2348f5
Again, I'm just talking about the backdrop (fanart). I just don't know how it was solved in the elementum. I would certainly separate fanart and landscape thumbs images.
I'm here for anything you need.

@burekas7 i guess you also might be interested in these new Art changes. at least you will not be surprised after new version will come out.

@antonsoroko
First of all, thank you for the effort and time you invest together with @elgatito to improve our favorite plugin.

Great, thank you.
I asked because tmdb helper uses fanart (backdrop) for thumbs in movies and tv shows. If it skin used, for example, squared shape, an image without text looks better than a poster (very often the titles are cut as well as the pictures themselves.). Now that I've read what you wrote, I'm not sure how he achieved it but I noticed that some other plugins use the same as tmdb helper.
TMDb helper

Elementum

P.S. Speaking of episode thumbs, is it also covered by these changes, does the quality change with the settings change?

Take care of one thing about the logo. Kodi doesn't support svg so it should skip somehow. Some movies and tv shows don't display the logo for this reason. Example, tv show Supernatural: https://www.themoviedb.org/tv/1622-supernatural/images/logos
As resolved in the tmdb helper: https://github.com/jurialmunkey/plugin.video.themoviedb.helper/commit/9273c1a871974c2877180fb9afb8a953fcd859cd
Yes, I mean landscape. My mistake, I wanted to write thumbs, then I remembered that it was landscape, so both remained. :-)
Yes, landscape must have text, fanart doesn't.

then i do not understand where is "fanart" on your screenshot?

I wrote on the picture. :-) But as far as I can see, you have taken care of it now. Thanks.
5. And thanks again. ;-)
6. I have to look at this. Give me little time to look and test everything with a few skins.
You could send it to me for Android, so I can test it on a Xiaomi TV stick.

@matke-84

tmdb helper uses fanart (backdrop) for thumbs in movies and tv shows.

looks like this is very specific for the skin you use. that's why i never have seen such issue.
and Kodi official wiki says that thumbs is used ONLY for episodes.
so looks like your skin for some reason use thumbs instead of fanart - which is incorrect, in my opinion. why? because thumbnail is basically a screenshot  (that's why it makes sense only for episodes).
and even this "tmdb helper" had to use a hack for this view - they set thumbs=fanart.
standard skins does not use "thumbs" for movies/shows as i can see.
even view called "Thumbs" in titan mod/titan bingie mod use "landscapes" but not "thumbs".
but that "Square" view in those titan skins uses thumbs.

my guess is that "Square" view was originally designed for episodes, but now you use it for movies/shows. which is not correct, imho.
ideally, you should use different "views" for different video types.
elementum supports that, click "Default view for ..." in context menu of any item to set default view. Also check elementum settings - bottom of appearance tab - it has all "Default view for ..." options.
but okay, i also will set thumbs=fanart. but this is a hack.
this is the result:
titan mod

titan bingie mod

P.S. Speaking of episode thumbs, is it also covered by these changes, does the quality change with the settings change?

yes. i use new "image quality settings" for everything.
you can read the code changes in PR - it is quite human readable, no need to know golang.

thanks for info! fixed.

I wrote on the picture. :-)

looks like i was mistaken about purpose of fanart and landscape. i thought that landscape must be used as background and fanart as "icon", but looks it it is vice versa.
thanks.

please test this new build:

windows https://disk.yandex.by/d/20qkkSdga6RHFA
android tv https://disk.yandex.by/d/6sRgkYf8qmPxRQ
it also will log sizes and images used for different art - so if unsure about some image - you can check log file.

@antonsoroko

I think you are absolutely right. I immediately changed this in my skin. Thanks. I didn't think about this at all. I'm not sure why plugins use this hack then. As far as I've noticed all the ones I use. There must be some reason.
I tested with yesterday's build and the banners have no alternative. I would leave it as it was. If there is no real banner, the skin decides what will be used. On this way, if you force some artwork for banner, it looks very strange in some skins, trying to fit an image into a very specific banner container.
Thats why TMDb helper uses fanart.tv as a fallback for artworks that don't exist in the tmdb database. It exists as an option, so it can be turned on. The actual tmdb helper uses three display modes:

only tmdb default like elementum now
only fanart - elementum has same option
tmdb and fallback fanart.tv when there are no artwoks from tmdb - this would be good if possible with elementum also.

FanArt/Banner/Landscape/Poster/Thumbnail = Still

I think the poster when entering the episode level should show the poster of the season or the poster of the whole series if there is no season poster and not thumbs of an episode. It's like that in other plugins and it looks better.
I haven't had time to test it on Android yet, but I'll do that today, so I'll report the results. ;-)

@matke-84
1.

There must be some reason.

maybe they just do not want to explain to people why thumbnail is only for episodes :-)
or they have not read Kodi wiki.
or there is some old/historical reason that is obsolete now, but hacky code still exists.
or there is undocumented reason. since i do not develop skins - i dunno :-)
anyway, now we also use this hack. test latest build plz.

I tested with yesterday's build

please test the latest build, otherwise it is confusing to understand what is not okay from your point of view.

the banners have no alternative. I would leave it as it was.

not sure what you mean. banner logic have not changed!
we set banner to backdrop, and if TMDB has more backdrops - then we also do addAvailableArtwork() for banner (like for fanart and others).
see current version of code here:
https://github.com/search?q=repo%3Aelgatito%2Felementum+item.Art.AvailableArtworks.Banner+item.Art.Banner&type=code
and see my changes here https://github.com/elgatito/elementum/pull/111/files (search on page for item.Art.AvailableArtworks.Banner and item.Art.Banner)

I think the poster when entering the episode level should show the poster of the season or the poster of the whole series if there is no season poster and not thumbs of an episode.

you can see the code
	if episode.StillPath != "" {
		item.Art.FanArt = ImageURL(episode.StillPath, fanArtQuality)
		item.Art.Banner = ImageURL(episode.StillPath, fanArtQuality)
		item.Art.Landscape = ImageURL(episode.StillPath, fanArtQuality)
		item.Art.Thumbnail = ImageURL(episode.StillPath, thumbnailQuality)
		item.Art.Poster = ImageURL(episode.StillPath, posterQuality)
		item.Art.TvShowPoster = ImageURL(episode.StillPath, posterQuality)
	} else {
		// Use the season's artwork as a fallback
		season.SetArt(show, item)
	}

i think i already do exactly what you said.
(and in season i have:
	// Use the show's artwork as a fallback
	show.SetArt(item)

)

tmdb and fallback fanart.tv when there are no artwoks from tmdb - this would be good if possible with elementum also.

please create new issue about this. i have no plans to implement this feature in this PR since it is not connected to "choosing the quality of the artwork".
our conversation is already diverted to TMDB->Kodi art mapping, which is also not connected to "choosing the quality of the artwork".
let's keep things separated, otherwise it is hard to keep track of them and implement them without messing thing up.
thank you.

Everything I write below has been tested with the latest version.
I will try to explain. Pictured is the current version of the elementum. My skin and some others, when there is no banner, displays the fanart image and over the clearlogo, when there is no clearlogo, then it displays the text. Since the current version of elementum does not have a clearlogo, on the picture, you can see fanart (old fanart with text) and over text (movie title).

The last version you sent me, Kodi recognizes that it is actually a real banner and it is actually a backdrop with text which also doesn't look good. That's why I mentioned that it's not good to force the banner look, because Kodi now sees that it's a real banner even if it's not.

Here's how it looks with another plugin. So this is not a real banner, but it looks very similar. Many skins use this trick.

So something was changed during the changes, as you can see.
It doesn't do what I mentioned. This is what it looks like with the version you sent me. I think you mentioned that you use the skin Aeon Nox: SiLVO, so I'll give you that screenshot.

And this is how it looks with other plugins.

You're right, sorry. Let's take care of this first.

P.S. The version you sent me works well on Android, all of what I have listed also happens on Android, but what is more noticeable is the difference in the speed of opening and switching between movies. We are going in the right direction. Great job so far. :-)

@antonsoroko
5. I forgot to tell you that in the episode level as a fanart (on the screenshot is image in the background) set a backdrop without text if possible (as in the second picture in tmdb helper). The thumb of the episode is often of lower resolution, so it looks bad as a background, and when moving it changes like the thumb and it should be a static image.

@matke-84

So something was changed during the changes, as you can see.
Kodi recognizes that it is actually a real banner and it is actually a backdrop with text

Even before this conversation I added banner, but new version was not released yet.
Then during thin conversation i logo, as you requested.
But now i can see that our "fake" banners does not look good.
I used backdrop as banner, but backdrop is much higher than banner supposed to be.
from https://kodi.wiki/view/Artwork_types#banner

In the video library, banners are wide and short images that contain recognizable characters or props from the video and typically includes a clearly visible logo or the name of the movie, movie set or tv show.

To be clear  - all 3 (1 elementum's old, 1 elementum's new, and 1 from other plugin) screenshots with banners looks bad in my opinion, since they use not a real banners.
(note about screenshots below: look at "Logan" on all my screenshots as a reference image)
If you enable fanart.tv - then you will see how it supposed to be with real banners:
Aeon Nox: SiLVO

bingie

But for TMDB the only good solution is to remove banners but keep logos:
Aeon Nox: SiLVO:

bingie

It doesn't do what I mentioned.

i see now.
that's why we use comas in my language - to correctly separate phrases and make complicated thought look clear :-)
i misread your message:

poster when entering the episode level should show the poster of the season or the poster of the whole series if there is no season poster and not thumbs of an episode.

as "use poster from a season/show ONLY if there is no thumbnail for an episode" :-D
right now we do this exactly, because it is faster to set all art of all episodes to "Still" image, rather than for every episode we will have to look back to season/show.

And this is how it looks with other plugins.

Does tmdb helper also set thumbnail? the view you use does not show it. Try with "bottom list" - it has thumbnail+poster+fanart.
Anyway, i did changes for episode and now we have thumbnail as episode Still, poster/fanart/landscape - taken from season/show.
Aeon Nox: SiLVO with view called "bottom list":

so i set fanart and landscape to default backdrop - it has no text.
then i try to find backdrop with text and set landscape to it.
so far so good, right? fanart has no text, landscape has text.

but i also set "available artworks" (so user can choose different art for video) via addAvailableArtwork() - e.g. i set "available fanarts" to "all backdrops" , but it looks like skin can use random image from this lists.
so now i changed logic for available artworks:
for fanarts - i take only backdrops with empty iso_639_1,
for landscapes - i take only backdrops with non-empty iso_639_1.
so i think now skin will always use only images w/o text for fanart (either default one or from "available arts") and only images with text for landscape.
Aeon Nox: SiLVO with view called "landscapes":

New version:
windows https://disk.yandex.by/d/20qkkSdga6RHFA
android tv https://disk.yandex.by/d/6sRgkYf8qmPxRQ
Changes:
Do not set Banner to BackdropPath b/c of significant mismatch of needed size
For tmdb episode take additional art from season/show
fix for AvailableArtworks: FanArt should be without text, Landscape with text.

@antonsoroko
1.

To be clear - all 3 (1 elementum's old, 1 elementum's new, and 1 from other plugin) screenshots with banners looks bad in my opinion, since they use not a real banners.
If you enable fanart.tv - then you will see how it supposed to be with real banners:

Well, that's exactly why we need a third option, that when tmdb doesn't deliver an artwork or simply doesn't have it, such as a banner, clearart, cd... fanart.tv takes over those artworks as a fallback. :-)

Does tmdb helper also set thumbnail? the view you use does not show it. Try with "bottom list" - it has thumbnail+poster+fanart.

It shows the same as now elementum with the last version you sent me, as it should.

I'd say it's all settled now. It would be nice if someone else took a look. I have to look on android but there shouldn't be any difference. I will definitely let you know. Also, if I notice something unusual, I report it.
P.S. I noticed a small bug with the duration of the episodes, but I will make a new issue. Just take a look. And I will certainly make an issue for the third option for artwork. :-)

@matke-84

I'd say it's all settled now.

glad to hear that, b/c tbh i already tired of this Art-related things :-)
thank you very much for testing!
btw, about

but what is more noticeable is the difference in the speed of opening and switching between movies.

is it on your android device? with which quality? is increase in speed really noticeable?

@antonsoroko

glad to hear that, b/c tbh i already tired of this Art-related things :-)

Come on, we just started. You know we have one more little thing. :-)

thank you very much for testing!

No, thank you very much for your time and effort.

is it on your android device? with which quality? is increase in speed really noticeable?

Yes. Xiaomi stick 4k. Nothing special. But you can really notice the difference. I set it to medium quality, you get a nice display and fast loading and especially switching between titles. I am very satisfied. That's why I said it would be nice if someone else could check.

@matke-84
i have MECOOL KM6 Deluxe, which has slightly more powerful CPU than Xiaomi Mi TV Stick 4K:
https://gadgetversus.com/processor/amlogic-s905y4-vs-amlogic-s905x4/
https://androidpctv.com/amlogic-s905y4-comparative/
see Geekbench tests.
Also it has 4GB ram. (but I do not recommend to buy it, it has several annoyng issues)
but i use simple skin Mimic-LR and simple view "list" (that show image only for one selected item), because with "heavy" skin and "heavy" view - even with amlogic s905x4 and 4 GB of ram - Kodi does now work fast enough, in my opinion. you need at least cheap but modern mini-pc (with with real x86 CPU) for such workload, imho.
i tried to use "views" with images and tried low and high settings for image quality - but it is hard for me to compare, since i have not used images before - for me Kodi looks slow in any mode with images :-)
but at least it looks like Kodi downloads images faster with low quality (b/c of smaller size).

@antonsoroko
Ohhh it's a ferrari unlike the xiaomi stick 4k. :-)
In general, Kodi is a bit heavy for weak devices.  All in all, I can feel the difference with the new settings. It just takes less time to download a smaller image, so it also affects performance.

@matke-84

Ohhh it's a ferrari unlike the xiaomi stick 4k. :-)

Nvidia Shield is a Ferrari :-) even after all these years. But the price is too high, imho.
Anyway, i hope this change will make elementum experience a bit more pleasant.


Monthly Chat Agenda August 2022 (2022-08-01 and 2022-08-15)

This is the Agenda for the Monthly CRS Chat.
The general chat is going to happen on https://owasp.slack.com in the channel #coreruleset on Monday, 2022-08-01, at 20:30 CET. That's the 1st Monday of the month. A separate issue chat is happening at the same location, same time on Monday, 2022-08-15. That's the 3rd Monday of the month. Please note that we have a CRS calendar (maintained by @fzipi).
Archived previous meetings and their decision are here.
What happend in the meantime since the chat last month
Outside development

Blog post explaining the delay
The CRS project entered an agreement with a PR company to help us with project marketing. The goal is the promote the project and participating as developer (we are not doing marketing to bring CRS to users, we do marketing to bring developers to our project!). This is paid for by our sponsors.
The CRS project has started to pay Christian Folini / @dune73 a small monthly sum for project coordination and various administration work. This is paid for by our sponsors.
There is a virtual hackathon running from Aug 1 to Aug 5 where CRS developers will write PRs to fix the remaining open bug bounty reports. This is happening in the private dev slack channel.
The 2022 CRS developer retreat will happen from Saturday Oct 29 to Saturday November 5, 2022. We'll stay in the Villa Cagnola near Varese, Italy. That's 20-30 min from Milano airport.

PRs that have been merged since the last meeting

#2700
#2696
#2667
#2687
#2590
#2669
#2668
#2594
#2578
#2557

We merged 10 PRs since the last monthly project chat.
Open PRs

#2702
#2677
#2676
#2666
#2663
#2637
#2595
#2591
#2584
#2581
#2575
#2573

Open PRs marked DRAFT or work in progress or needs action

#2701
#2572
#2562
#2478
#2303
#2302
#2301
#2290
#2217
#2067
#1975

Sub projects

Demo / Sandbox site: There is a new sandbox mode that triggers a blockade / 403 if the anomaly score is above the treshold. This can be configured via a HTTP header.
Documentation: FIXME
Technical Blog Posts:

@RedXanadu is slowly :turtle: :snail: working on a blog post idea: "A quantitative approach to false positives": Testing our regular expressions against large bodies of examples of natural language and seeing how different PLs compare for FPs (inspired by a Bug Bounty submission).

Status page: FIXME
Coraza: FIXME

Other items

Sandbox: Should blocking with 403 be the new default behavior?
Restricted file types: We removed .axd from the restricted extensions list, but there's talk of adding it back. Should we leave it off the list? (Re: #2562)
#2591 is at an impasse. Need to make a tough decision about the direction we are taking here.

Open Issues - Separate Issues Meeting (Monday, 2022-08-15)
Status of issues covered last month

Issue slot 1: #FIXME
Issue slot 2: #FIXME
Issue slot 3: #FIXME
Issue slot 4: #FIXME
Issue slot 5: #FIXME
Issue slot 6: #FIXME
Issue slot 7: #FIXME
Issue slot 8: #FIXME
Issue slot 9: #FIXME
Issue slot 10: #FIXME

Stats

Covered in chat: FIXME
Closed: FIXME
Pending: FIXME

This month's issues
There are FIXME open issues at the beginning of the issue chat.
We generally cover 10 issues per month in a separate issue meeting. Add them as you see fit.

Issue slot 1: #FIXME
Issue slot 2: #FIXME
Issue slot 3: #FIXME
Issue slot 4: #FIXME
Issue slot 5: #FIXME
Issue slot 6: #FIXME
Issue slot 7: #FIXME
Issue slot 8: #FIXME
Issue slot 9: #FIXME
Issue slot 10: #FIXME

How to get to our slack and join the meeting?
If you are not yet on the OWASP Slack, here is your invite: https://owasp.org/slack/invite .
Everybody is welcome to join our community chat.

Meeting decisions
Other Items

Sandbox: Should blocking with 403 be the new default behavior? -> Unless @fzipi  and maybe @theMiddleBlue bring some cutting arguments in favor of 200 we'll change to 403 by default during the week.
Restricted file types: We removed .axd from the restricted extensions list, but there's talk of adding it back. Should we leave it off the list? (https://github.com/coreruleset/coreruleset/pull/2562) -> If we removed .axd in 7 Dec 2020 and no one has noticed or complained… maybe we keep it simple and take it out for good. Assuming there are no objections or good reasons to add it back in. And if somebody has hard feelings we're open for a PR that adds a commented out variant with .axd to crs-setup.conf.
https://github.com/coreruleset/coreruleset/pull/2591 is at an impasse. Need to make a tough decision about the direction we are taking here.

Can i close this?

Absolutely. Thank you for cleaning up.


Remove client certificate results sending

🗣 Description
This pull request removes all configuration elements around running the cisagov/client-cert-update Docker image in the CyHy environment. This includes removing the use of cisagov/ansible-role-client-cert-update, removing the client_cert_update role from this project, and any configurations or requirements around using those two Ansible roles.

💭 Motivation and context
The cisagov/client-cert-update image's emails do not seem to be needed as we have manually turned off the cron job that runs the Docker composition and have received no complaints. Maintaining unused Docker, Ansible, and Terraform configurations is an unnecessary burden on our development team's limited resources. As a result we will cease its deployment in the CyHy environment which will allow us to archive any of the related repositories.

🧪 Testing
Automated tests pass. I find no results of note in this project when running grep -rin client_cert in the root directory.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

✅ Post-merge checklist

[ ] Archive cisagov/ansible-role-client-cert-update.
[ ] Archive cisagov/client-cert-update.

Hi Team @all, for the file cyhy_amis/terraform/bod_docker_ec2.tf lines 46 to 48, should the comment be updated to omit the client-cert-update? Currently it reads as "# database and send email using SES. The cisagov/client-cert-update # and cisagov/code-gov-update Docker containers need to send email using # SES."


move to wrtc version 0.0.55?

I am getting an error on npm install from the npm repo. Looks like it would be solved by bumping up the dependency on wrtc to version 0.0.55.

Can you confirm that that worked?

@jtj02 @silviapfeiffer I think this is a good idea.  I was waiting for a version of wrtc to be released that had pre-built packages for linux, etc.  Looks like 0.0.55 does not so I think upgrading to that is a no brainer.

Cool!


Laravel & Type Casts

So I've got the following test code:
$vectorArray = FaceEmbedding::first()->embedding; //returns a Vector::class cast from my model which is a VECTOR(2056)
$documents = FaceEmbedding::orderByRaw('embedding <-> ?', [$vectorArray])->take(5)->get()

However, upon running the code I get the following error:
SQLSTATE[42883]: Undefined function: 7 ERROR: operator does not exist: public.vector <-> unknown LINE 1: ...elect * from "face_embeddings" order by embedding <-> $1 lim... ^ HINT: No operator matches the given name and argument types. You might need to add explicit type casts. (Connection: pgsql, SQL: select * from "face_embeddings" order by embedding <-> [0,128,250,68,0,0,156,66,255,56,29.......

But when I do the following:
$documents = FaceEmbedding::orderByRaw('embedding <-> ?', [$vectorArray])->take(5)->toRawSql()

And copy it directly into my postgres console, it works perfectly fine?

Hi @CLCWebsiteServices, I'm not able to reproduce the issue and recommend using nearestNeighbors, but you could try using embedding <-> ?::vector to see if that fixes it.

Okay, so I've found out the issue... when I'm doing it via eloquent I've printed out the toRawSql() it's doing the following:
select * from "face_embeddings" order by embedding <-> '[0,128,250,68,0,0,156,66,255,56,2

But infact I need it to do the following:
select * from vector.face_embeddings order by embedding <-> '[0

Yeah, appears that when doing schema it isn't working correctly as it's trying to get the vector datatype from the public schema rather than my created vector schema that I placed the face_embeddings inside.


Is subsampling performed once for each iteration?

I am not sure from the documentation how subsampling is done here. Is subsampling done for each iteration, so the model has a different data for constructing each tree? Or is subsampling done only at the beginning of calling xgb.train, then the same data is used for constructing all trees?

I just did an experiment of customizing a loss function which prints out the mean of label at each iteration, and the number is the same across iterations. So it seems xgboost uses the same data for each iteration.

Is subsampling done for each iteration, so the model has a different data for constructing each tree?

Yes. Subsampling is done for each iteration: https://github.com/dmlc/xgboost/blob/master/src/tree/updater_basemaker-inl.h#L145


Constraint is not honored

When using asn1c to check a SubjectAltName PDU (as defined in RFC3280/5280), given the input string of {0x30,0x00} as DER, it returns no errors.  However the syntax is defined as:
SubjectAltName ::= GeneralNames

   GeneralNames ::= SEQUENCE SIZE (1..MAX) OF GeneralName

   GeneralName ::= CHOICE {
        otherName                       [0]     OtherName,
        rfc822Name                      [1]     IA5String,
        dNSName                         [2]     IA5String,
        x400Address                     [3]     ORAddress,
        directoryName                   [4]     Name,
        ediPartyName                    [5]     EDIPartyName,
        uniformResourceIdentifier       [6]     IA5String,
        iPAddress                       [7]     OCTET STRING,
        registeredID                    [8]     OBJECT IDENTIFIER }

It seems like that input should not be valid.

The constraint checking is performed using a separate API call. See the Chapter 4 in doc/asn1c-usage.pdf

I'm aware of the extra API call.  I'm using the sample tool and passing -c which should make that API call happen.
I'm using asn1c as part of https://github.com/awslabs/certlint.  I'm building a standalone binary based on the examples.  The full command being run is $CMD -c -p "$PDU" -oder -with the claimed DER being passed on standard in.

Oh, I see. Let me check...

Here are two minimal test cases:
echo -n 'ME0wQQYLKwYBBAGA5TcCAwEwMjAwBggrBgEFBQcCARYkaHR0cHM6Ly93d3cudGJzLWludGVybmV0LmNvbS9DQS9DUFMzMAgGBmeBDAECAg==' | base64 -D | certlint-x509helper -c -p CertificatePolicies -oxer -

echo -n 'MAA=' | base64 -D | certlint-x509helper -c -p SubjectAltName -oxer -

Two more test cases, these both generate "ASN.1 constraint check failed"  errors.  So the constraint checking happens...
echo EwA= | base64 -D | certlint-x509helper -c -p X520name -oxer -
echo EwTRYWJj | base64 -D | certlint-x509helper  -p X520name -oxer -
and one more case where a defined constraint is not applied:
echo EwNhYmM= | base64 -D | certlint-x509helper -c  -p X520countryName -oxer -

Looking at the code generated, it seems that SEQUENCE SIZE (1..something) OF SomeType is usually getting a constraint function of SEQUENCE_OF_constraint.  This is really SET_OF_constraint (via a #define).  SET_OF_constraint does no checking for the size.
Therefore it seems that SIZE constraints are simply not supported on SEQUENCE/SET OF things.

I am looking into that in search of the rationale. The asn1c supports much of the constraint checking because it is required for the PER encodings. The PER encoding are peculiar in that some ASN.1 constraints are visible for PER, and some aren't. This might be the one particular case when ASN.1 states that the constraints are invisible for PER-encoding. Should not prevent asn1c from generating the full constraint checking code in most of the cases though. Checking still...

More code diving makes it seem like there are two different bugs here.
The first one is places where the SEQUENCE_OF_constraint is being used instead of a custom function that enforces the SIZE constraint.
However, SubjectAltName does have such a function, checking that size >= 1.  However it appears that it is never being called.  I did some basic printf debugging, and asn_check_constraints is being called but SubjectAltName_constraint is not.  type_descriptor->name is SubjectAltName, so it is using the right PDU struct.

It looks like the constraint is being associated with the wrong PDU in some cases.  For example, SubjectAltName is getting a size >= 1 constraint when that constraint really belongs to GeneralNames.  This is causing the generated constraint code to be wrong.
I'm still working to figure out how the compiler gets this wrong.

Best I'm able to guess, https://github.com/vlm/asn1c/blob/master/libasn1parser/asn1p_y.y#L1213 might be attaching the constraint wrong.  I need to create a really small ASN.1 grammar to verify.

Here is a minimal test case.  In the generated code, AliasOomt gets the size constraint, not OneOrMoreThings.
TestSequenceSizeOf
  { iso(1) identified-organization(3) amazon(187) test(999) one(1) }

DEFINITIONS IMPLICIT TAGS ::=
BEGIN

SomeThing ::= PrintableString

OneOrMoreThings ::= SEQUENCE SIZE (1..MAX) OF SomeThing

AliasOomt ::= OneOrMoreThings

END


teach script/integration how to run against a specific git-lfs build

This is useful if you want to run the existing tests against a specific git-lfs binary.

Cool :+1:


kernel manuelmapping issue because of blackbone::Driver().Unload(); ?

hello, sorry for thats me again, but i cant find a solution on my own with the following problem.
for some reasons i get an "APC_INDEX_MISMATCH" bluescreen (stopping at ntoskrnl.exe+xxx) if i disable the "hiding modul from the VAD list" feature while im (kernel) manualmapping inside a (x86) usermode process (on win8.1 b9600). besides that for another reason my usermode application i want to inject my image via. kernel-mm crashes if i close the GUI (injector), it reacts like a SetWindowsHookEx injection, it cant stand without the "parent process" (the injector, properly caused by the driver unload?).
the results are the same with the usermode manualmapping injection. its the frist time since i updated to the newest version of bb-library that i experienced that "issue".
you as creator of this beauty properly know whats about it - may you can give a look at it.
thanks alot!
my kernel manuelmapping "issue" is caused by bb-driverunloading. but since i dont get a dea why ?
beginning at this comment:
https://github.com/DarthTon/Xenos/commit/f44474c94322141244db7952169479793bcc1992

Caused by #35


Issues in JSON-Schema Definition

Hi,
I am currently going in detail through JSON-Schema Definitions and I found some inconsistencies on these definitions. I am not sure how these were created - manually or generated. Please triage them and if necessary fix them:

[x] Typo: compare https://creativecommons.org/schema.rdf https://github.com/International-Data-Spaces-Association/ids-specification/blob/524039dcf1d52eceb9acf00c90c7a237c97afd95/negotiation/message/schema/contract-schema.json#L291
[ ] Not defined: https://github.com/International-Data-Spaces-Association/ids-specification/blob/524039dcf1d52eceb9acf00c90c7a237c97afd95/negotiation/message/schema/contract-schema.json#L330
[x] Differs from ODRL definition: see https://www.w3.org/ns/odrl/2/ODRL22.ttl https://github.com/International-Data-Spaces-Association/ids-specification/blob/524039dcf1d52eceb9acf00c90c7a237c97afd95/negotiation/message/schema/contract-schema.json#L326
[ ] JSON-Schema Reference instead of a definition name: https://github.com/International-Data-Spaces-Association/ids-specification/blob/524039dcf1d52eceb9acf00c90c7a237c97afd95/negotiation/message/schema/contract-schema.json#L105

I will extend the list when I find more inconsistencies.

Great observations, I already prepared a fix for the first and third one.
RightOperand is not defined on purpose, as it can appear in many ways in JSON. If you can provide a pattern, very much appreciated!
The construct for Offer is also on purpose, due to the fact that we need to express that target is forbidden in most cases (everytime the schema validation goes through the Offer path) but not always (when coming through MessageOffer directly).

Let's use #236 to derive a solution.

The construct for Offer is also on purpose, due to the fact that we need to express that target is forbidden in most cases (everytime the schema validation goes through the Offer path) but not always (when coming through MessageOffer directly).

@sebbader-sap I cannot completely follow what you are describing. But from what I understood you are referring with target to the Agreement.odrl:target, which is three references away. To be honest I think this is a way to complex data structure. Just imagine how somebody should implement it. You need separate classes/structs anyway, otherwise you are not able to implement a data structure, which in one case has a required attribute and in another case it is not required. A specs purpose is to be implemented, therefore it should strive for simplicity and not complexity. I would suggest to refactor this, I can make a suggestion but I need some guidance what else depends on it and needs to change accordingly.
Actually I was referring with the fourth issue to the fact, that this Json-Schema definitions-part is a key-value map and the key in this case is #/definitions/Offer instead of Offer.

the key in this case is #/definitions/Offer instead of Offer.

I see, this is of course a correct finding but already merged, see https://github.com/International-Data-Spaces-Association/ids-specification/blob/36960607a67793e3fc5089655102ac6d5b9b5445/negotiation/message/schema/contract-schema.json#L105

We need to continue this discussion as soon as the Eclipse Project has been established. As the 2024-1 release in this repo is nearly done, any further corrections / extensions need to happen in the new project.

Adding another yet one:

[ ] Context in line 58 is missing a comma

AbstractPolicyRule does not contain odrl:target:

The clause with not(required) didn't really work out as intended, therefore, this line has been deleted.

Open topics for the Eclipse Dataspace Group:

Schema definition of the RightOperand
Decide on odrl:prohibition - is it needed? If so, how shall it be modelled?

@ssteinbuss please move these topics to the new repo. Apart of that, I regard the findings of this issue as solved as I also, for now, do not see a need to change the timestamp format.

[...] Apart of that, I regard the findings of this issue as solved as I also, for now, do not see a need to change the timestamp format.

@sebbader-sap I think this is rather unconventional. There are standardized timestamp formats defined like RFC3339, which is pretty similar to the Regex defined there. I compared the Regex with the definition from RFC3339 and the differences leave room for interpretation, which results in not compatible or complex implementations.

Is there really a need for B.C. timestamps?
24:00:00 is not represented in the RFC3339
Leap seconds are not represented, compare RFC3339: Section 5.6. Internet Date/Time Format and RFC3339: Appendix D. Leap Seconds

If there is no reason for it to differ from the standard, why reinventing the wheel?


"Invalid redeclaration of 'JSON'" error when using SwifyJSON with project.

My iOS Swift project includes SwifyJSON to parse JSON I download from my API easily.
When I include HanekeSwift into my project, I get the error "Invalid redeclaration of 'JSON'" in my SwifyJSON.swify file line 56 as it declares a struct called JSON:
public struct JSON {
    ...
}

and HanekeSwift uses the name JSON as well for an enum:
public enum JSON : DataConvertible, DataRepresentable {
    ...
}

The two are conflicting with each other. I use HanekeSwift for caching images specifically now but potentially other data later. I use SwifyJSON to parse JSON data coming back from my API that I download with Alamofire. So I don't see where I can remove the need for a library as they all have different needs.
Any workaround to this? Or will it require the need to rename JSON enum declaration in the library to avoid the conflict?

This is also true for extension NSFileManager function:
func < (lhs: NSNumber, rhs: NSNumber) -> Bool {
    return lhs.compare(rhs) == NSComparisonResult.OrderedAscending
}

SwifyJSON has it's own version of this code:
public func <(lhs: NSNumber, rhs: NSNumber) -> Bool {

    switch (lhs.isBool, rhs.isBool) {
    case (false, true):
        return false
    case (true, false):
        return false
    default:
        return lhs.compare(rhs) == NSComparisonResult.OrderedAscending
    }
}

I already went through my code and change all JSON instances in HanekeSwift to JSONData and removed the function <, though it should be renamed. Compiles and works great.

Use fully qualified names. Haneke.JSON.

I will not make a pull request at the moment, but I may in the future. SwiftyJSON is a popular library and so is Haneke. I will for sure be using both in future projects so using fully qualified names for Haneke would be great to resolve this issue again in the future.
Thank you for the help!


Change KitchenSink to use implicit standalone mode

Remove Partial.cs file from the project. Switch to use middleware, as presented in:  https://github.com/Starcounter/Starcounter/issues/3451#issuecomment-199349823

This part in Program.cs is redundant (by JsonAutoSessions) and should be removed:
                if (session == null) {
                    session = new Session(SessionOptions.PatchVersioning);
                }

Fixed in rv

Thanks. Looking good now.
This needs to be tested (with and without Launcher) after https://github.com/Starcounter/Starcounter/issues/3539 is fixed.

@aloscha, please comment out the line app.Use(new JsonAutoSessions()); and revert the commit https://github.com/StarcounterSamples/KitchenSink/commit/3989d0d373cea16095de045cc52697861b83acd0, because it doesn't work until https://github.com/Starcounter/Starcounter/issues/3575 is fixed.
After that, make sure that Selenium tests are passing and merge to master

Merged into master.


Failed mtar file deploy to Cloud Foundry

I'm trying to deploy mtar file to Cloud Foundry but I got similar errors:
Cannot retrieve service parameters of service "productdb_html5_repo_host"
Cannot retrieve service parameters of service "productdb-db-hdi-container"
Cannot retrieve service parameters of service "productdb_html5_repo_runtime"
for example:
#2.0#2019 11 27 12:54:23.414#Z#WARN#com.sap.cloud.lm.sl.xs2.f84a2c16-1114-11ea-9fce-eeee0a801b06.MAIN_LOG.DetermineServiceCreateUpdateActionsTask#
######com.sap.cloud.lm.sl.cf.persistence.services.ProcessLogger########flowable-async-job-executor-thread-28###
[DetermineServiceCreateUpdateServiceActionsStep] Cannot retrieve service parameters of service "productdb_html5_repo_runtime"#
org.cloudfoundry.client.lib.CloudOperationException: 400 Bad Request: This service does not support fetching service instance parameters.
Please provide the following info:

MBT Version: How can I get this?
OS Version: Win 10 X64

mta.yaml:
ID: productdb
_schema-version: '2.1'
parameters:
  deploy_mode: html5-repo
version: 0.0.1
modules:
  - name: productdb_appRouter
    type: approuter.nodejs
    path: productdb_appRouter
    parameters:
      disk-quota: 256M
      memory: 256M
    requires:
      - name: productdb_html5_repo_runtime
      - name: productdb-uaa
      - name: srv_api
        group: destinations
        properties:
          forwardAuthToken: true
          name: srv_api
          url: '~{url}'
  - name: productdb_ui_deployer
    type: com.sap.html5.application-content
    path: productdb_ui_deployer
    requires:
      - name: productdb_html5_repo_host
    build-parameters:
      requires:
        - name: ui-product
          artifacts:
            - './*'
          target-path: resources/ui-product
  - name: productdb-db
    type: hdb
    path: db
    parameters:
      memory: 256M
      disk-quota: 256M
    requires:
      - name: productdb-db-hdi-container
  - name: productdb-srv
    type: java
    path: srv
    parameters:
      memory: 1024M
    provides:
      - name: srv_api
        properties:
          url: '${default-url}'
    requires:
      - name: productdb-db-hdi-container
        properties:
          JBP_CONFIG_RESOURCE_CONFIGURATION: '[tomcat/webapps/ROOT/META-INF/context.xml: {"service_name_for_DefaultDB" : "~{hdi-container-name}"}]'
      - name: productdb-uaa
  - name: ui-product
    type: html5
    path: ui-product
    build-parameters:
      builder: grunt
      supported-platforms: []
      build-result: dist
    requires:
      - name: srv_api
        group: destinations
        properties:
          forwardAuthToken: true
          strictSSL: false
          name: srv_api
          url: '~{url}'

resources:
  - name: productdb_html5_repo_runtime
    parameters:
      service-plan: app-runtime
      service: html5-apps-repo
    type: org.cloudfoundry.managed-service
  - name: productdb_html5_repo_host
    parameters:
      service-plan: app-host
      service: html5-apps-repo
    type: org.cloudfoundry.managed-service
  - name: productdb-db-hdi-container
    type: com.sap.xs.hdi-container
    properties:
      hdi-container-name: '${service-name}'
  - name: productdb-uaa
    type: org.cloudfoundry.managed-service
    parameters:
      service-plan: application
      service: xsuaa
      config:
        xsappname: 'productdb-${space}'
        tenant-mode: dedicated

@mikolasz  - I was able to deploy successfully a project with the same modules types, can you please share the project? or some minimal reproducible example.

@mikolasz  - any update?

Hi,
I am closing the issue since there is no response for a few weeks. Please re-open, if still relevant.
Regards
Natalia


[LexicalCasesWikipedia] ProgressIndicator when one article is searched is not useful

Example of problem:

Note how found is at 0, which at the moment can't be avoided. Maybe it would suffice to not have that data show up if there is only one article being searched?

Better handling of single article; pushed to main.


fix: react-icons tree shaking

saving 3mb by tree-shakling react-icons correctly

faker and semantic are the next big things to remove


respond to ping

Need to respond to ping to satisfy https://dev.twitch.tv/docs/irc/#keepalive-messages

Sorry, this was an accident!


Feature/lol/create layer selector component

Moves hard coded values from the Library component into sub components wired to backbone models and collections.
Connects #53
To test:

Bundle and test out the layer selector.
Add a break point after the rendering of the library and update any of the layer models.
Ensure the component rerenders.
Click component UI and check to see that dummy handlers are firing.

+1, tested

I think this could be avoided using:
https://github.com/clayallsopp/react.backbone
Search for "multiple models"

Good point. If I do this, I'd have to pass the user model all the way down the chain. The current way seems mildly cleaner. And if the information @kdeloach has led me to believe is true, this is all Backbone-React would do behind the scenes. I'm inclined to leave it unless you feel very strongly.

@lewfish Did some fixups and a rebase. You might want to take it for another spin. I'll merge it later today but I'm going to start building the next feature on top of it.

Good point. If I do this, I'd have to pass the user model all the way down the chain. The current way seems mildly cleaner. And if the information @kdeloach has led me to believe is true, this is all Backbone-React would do behind the scenes. I'm inclined to leave it unless you feel very strongly.

I'm ok with leaving it as is.

+1

I could be wrong, but I think you only need to wrap values in curly braces if there is interpolation involved.

When I used booleans without the braces it complained.

What does this do?

Proves that the action UI elements render conditionally.

Consider lifting this out because we shouldn't need to create a new ActionElements class everytime render is called. You can pass callbacks to the element props instead like <ActionElements onDelete={this.onDelete} ... />

Yeah I changed that a commit later.

Consider binding events in componentDidMount (called when the component is rendered for the first time).

Good idea. Will fix.

Going to make some small changes as per notes tomorrow. Will merge after I test and rebase.

Consider flattening this.

Since I have to pass it in a few layers deep into the component, it is a lot easier to send it all as a single object than a bunch of individual properties.

I think this is equivalent to React.render(, el);

Yes. Simplified this... https://github.com/lliss/raster-foundry/blob/ee4e1ad46056242230e0c52376f5284d556d9b3b/src/rf/js/src/home/controllers.js#L61


Update hibernate-core to 6.2.6.Final

About this PR
📦 Updates org.hibernate:hibernate-core from 5.6.15.Final to 6.2.6.Final
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.hibernate", artifactId = "hibernate-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.hibernate", artifactId = "hibernate-core" }
}]

labels: library-update, commit-count:1

Superseded by #376.


feat: Include hoursBeforeEarlyXpDecay in response

Includes hoursBeforeEarlyXpDecay in return response. This is to allow the frontend to know when full bonus xp ends.
Frontend PR: https://github.com/source-academy/frontend/pull/3025

coverage: 94.382% (+0.002%) from 94.38%
when pulling c8038f5d3b125c3ad7241af908c3c5df3ee4da51 on GabrielCWT:feat/show-bonus-xp-end-date
into e6a96182bf782c547efebf5138c9c8e0deb812ec on source-academy:master.


(maint) Fix broken Windows acceptance tests

Starting with Bolt 3.0, we no longer include the bolt function in the
PuppetBolt PowerShell module and instead shipped with a batch file for
Windows packages that would run the Bolt executable. When this change
was made acceptance tests were broken as the PATH did not include the
path to Bolt's bin/ directory and the test would error with a "bolt is
not a recognized command" message.
During the beaker setup process (specifically step 032), beaker
updates the PATH to include Bolt's bin/ directory. Previously, the
script responsible for this used the Join-Path cmdlet with multiple
positional arguments, which is not supported in PowerShell < 6.0,
resulting in the PATH not getting updated. Updating this line to not
error correctly sets the PATH for the step that sets it, but the
PATH is not preserved between PowerShell sessions. This resulted in
the tests continuing to fail since bolt was not recognized as a
command.
This change updates the bolt_command_on helper method to set the
PATH prior to invoking bolt, ensuring that the PATH is correctly
configured every time Bolt is run.
!no-release-note

Ran locally and confirmed that this results in acceptance tests passing with a Windows controller:
$ bundle exec beaker-hostgenerator windows2019-64bolt%2Cwinrm. --hypervisor abs --disable-default-role --osinfo-version 1 > hosts.yaml
$ bundle exec beaker --log-level debug --hosts hosts.yaml --tests tests --preserve-hosts never --keyfile ~/.ssh/id_rsa-acceptance --options config/package/options.rb

...

      Test Suite: tests @ 2021-07-06 14:27:15 -0700

      - Host Configuration Summary -

              - Test Case Summary for suite 'tests' -
       Total Suite Time: 347.57 seconds
      Average Test Time: 19.31 seconds
              Attempted: 18
                 Passed: 10
                 Failed: 0
                Errored: 0
                Skipped: 8
                Pending: 0
                  Total: 18

      - Specific Test Case Status -


In RichTextBox, can not use other input method except microsoft pinyin

When I use ms pinyin input method, I can input sth in RichTextBox.
But using 3rd party input method can not input anything, even using US keyboard - English.
my xaml:
<emoji:RichTextBox x:Name="TextBoxDoc"
Grid.Row="1"
Margin="5"
AcceptsReturn="True"
VerticalScrollBarVisibility="Visible"
FontSize="15"/>

Can you please let me know if this still happens with version 0.2.0? Thanks!

Can you please let me know if this still happens with version 0.2.0? Thanks!

It's all right now in v0.2.0

It's all right now in v0.2.0


Remove fixtures from ion device test

Fixtures shouldn't be called directly.  Here the fixture doesn't really provide any benefit over a global method.  Renamed method to avoid it being a test.

This is generating warnings in pytest.

@dabacon What warnings is it generating? I can't see anything "significant" in the build logs.

~/.virtualenvs/cirq/lib/python3.6/site-packages/_pytest/python.py:198: RemovedInPytest4Warning: Fixture "test_ion_device" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.


No longer working since last update

Hi,
I am facing issue since the last update. It is no longer working.
I can slide the light power but it won't even turn on.
The custom name that I set in Home will also always gets reset.
I can see it in the console:
[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 2 main#main] setConfiguredName [ 'GuangCan Ceiling Light 2 main' ]
[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 2 main#main] setConfiguredName [ 'GuangCan Ceiling Light 2 main' ]
[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 2 main#main] setConfiguredName [ 'GuangCan Ceiling Light 2 main' ]

[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 3#main] setConfiguredName [ 'GuangCan Ceiling Light 3 main' ]

[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 3 main#main] setConfiguredName [ 'GuangCan Ceiling Light 3 main' ]

[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 3 main#main] setConfiguredName [ 'GuangCan Ceiling Light 3 main' ]
[12/2/2020, 12:56:36 PM] [Yeelighter] [GuangCan Ceiling Light 3 main#main] setConfiguredName [ 'GuangCan Ceiling Light 3 main' ]
[12/2/2020, 12:56:40 PM] [Yeelighter] [0x00000000101cc163] ceiling20 Connected []
[12/2/2020, 12:56:40 PM] [Yeelighter] [0x00000000101cc163] requesting attributes. Transactions: 5 []
[12/2/2020, 12:56:40 PM] [Yeelighter] [GuangCan Ceiling Light 3 main#main] temperature light updated {"power":true,"color_mode":2,"bright":94,"hue":0,"sat":0,"ct":2703,"bg_power":false,"bg_bright":100,"bg_hue":6,"bg_sat":100,"bg_ct":4000,"bg_lmode":3,"nl_br":22,"active_mode":1,"name":""} []

I tried to removed all cached accessories, restart, etc.

Had the same isse. Try to go back to 1.5.16 - for me its works. If you have some strange device left (from 2.1.11) use
sudo rm -rf /var/homebridge/accessories
Good luck.

After going back and forth, I believe this is finally fixed in 2.3.4, Unfortunately you may have to delete the accessory cache once more.


[Portfolio] Your portfolio

As a Likecoin wallet address owner, I want to see the details info about the history and current status of my wallet so that I can manage my account
Acceptance Criteria
Positive

[ ] I can see my portfolio
[ ] I can see my desmos profile that connect to my wallet
[ ] Guard the portfolio page when not connected to wallet, and will trigger connect to wallet modal

General

[ ] Support RWD

Content

Name
Wallet address (one-click copy)
Total amount of LIKE I have (rounded off & actual)
Stake: total amount I own
Unstaking: the like in unbonding period
Available: total - stake - unstaking

Test flow

Try click and copy address
Compare to the data I see on bigdipper
Check my desmos page

Design
Figma

Reference

Unstaking: https://www.forbole.com/blog/unbonding-period-in-cosmos-bpos-ch
desmos profile:https://docs.desmos.network/next/
Oursky's desmos profile: https://explorer.desmos.network/accounts/desmos1ze7n3xsfd7na2saj070v0cx0eu7twng9dxxrlt
bigdipper is a block explorer that provides a website UI for non-tech users to view the chain data: https://likecoin.bigdipper.live/

build: dev
Description

When unconnected,visiting portfolio page and see error msg
The portfolio data is different from bigdipper

Expected results

Should trigger connect to wallet modal when unconnected, instead of visiting portfolio page and see error msg
Available = 44, Unstaking = 8

Screenshot

@mitchellchou incorrect balances are fixed in #183, I realised I made a few mistakes when working on that PR.

I will open an issue to fix the open connect wallet dialog if not logged in. (sorry for not reading the requirements carefully, I will double check from now on)

@ivanng-oursky The total LIKE didn't match

cosmos1yrzytk9urmdvn0rkpt6r0hjuhdpth5473caq2k

https://likecoin.bigdipper.live/accounts/cosmos1yrzytk9urmdvn0rkpt6r0hjuhdpth5473caq2k

Expected results

Okay that Reward shows 0 after rounding
The total should be 75.365 and 75.365243764

Bigdipper seems to be having issue fetching the lastest data

@mitchellchou
I have checked a couple addresses against https://likecoin-public-testnet-5.netlify.app/ and from direct rpc query, I think its safe to assume our balance values are correct. Most likely BigDipper's data was inaccurate or not yet updated.
cosmos1yrzytk9urmdvn0rkpt6r0hjuhdpth5473caq2k

test site
lunie
rpc

like1sxjgwl2m35c6sah4f3yhd764csn307alx6h9le

test site
lunie
rpc


Search is slow when processing node is loading reference data

Looking for confirmation that this looks like disk contention rather than some locking issue
Will attach stack traces from a proc node and UI too

proc_node_stack1.txt
proc_node_stack2.txt
proc_node_stack3.txt
proc_node_stack4.txt
ui_node_stack1.txt
ui_node_stack2.txt
ui_node_stack3.txt
ui_node_stack4.txt

Is this still the case?

It does look like disk contention.  Have checked that two LMDB envs (i.e. search and ref) can co-exist without blocking each other.


crouton -u gives "Release doesn't match" errors for sid

Trying to add a target, I get "Release doesn't match" errors:
chronos@localhost ~ $ sudo sh ~/Downloads/crouton -u -t xiwi -n sid
/usr/local/chroots/sid already exists; updating it...
Enter encryption passphrase for sid:
Unable to determine the release in /usr/local/chroots/sid. Please specify it with -r.
chronos@localhost ~ $ sudo sh ~/Downloads/crouton -u -t xiwi -n sid -r sid
/usr/local/chroots/sid already exists; updating it...
Enter encryption passphrase for sid:
Release doesn't match! Please correct the -r option, or specify a second -u to
change the release, upgrading the chroot (dangerous).
chronos@localhost ~ $ sudo sh ~/Downloads/crouton -u -t xiwi -n sid -r sid -u
/usr/local/chroots/sid already exists; updating it...
Enter encryption passphrase for sid:
WARNING: Changing the chroot release to sid.
Press Control-C to abort; upgrade will continue in 5 seconds.
chronos@localhost ~ $ sudo sh ~/Downloads/crouton -u -t xiwi -n sid -r sid
/usr/local/chroots/sid already exists; updating it...
Enter encryption passphrase for sid:
Release doesn't match! Please correct the -r option, or specify a second -u to
change the release, upgrading the chroot (dangerous).
The chroot is encrypted and
$ croutonversion
crouton: version 1-20141231011135~master:992afe3e
release: sid
architecture: amd64
targets: gnome
host: version 6310.68.0 (Official Build) stable-channel quawks
I did a few tweaks inside the chroot after installing it, but I can't imagine how any of them would have broken then release detection...
Thanks,
JM

Ah ha!  There seem to be 2 conditions that my changes did not satisfy:

There must be sources.list and instead of files in sources.list.d
There must be the version name 'sid' in sources.list rather than the alias 'unstable'.

Thanks for the help.

Ah ha!  There seem to be 2 conditions that my changes did not satisfy:

There must be sources.list and instead of files in sources.list.d
There must be the version name 'sid' in sources.list rather than the alias 'unstable'.

Thanks for the help.

Yep!  crouton behaves well in the presence of lots of hacks, but some things do end up confusing it...

Yep!  crouton behaves well in the presence of lots of hacks, but some things do end up confusing it...

I have the same issue ( https://github.com/dnschneid/crouton/issues/2174 ), so I tried your suggestion. I went into the chroot and edited the sources.list. It looks like this now:
deb http://mirrors.ustc.edu.cn/ubuntu/ trusty multiverse universe restricted main
deb-src http://mirrors.ustc.edu.cn/ubuntu/ trusty multiverse universe restricted main
deb http://mirrors.ustc.edu.cn/ubuntu/ trusty-updates multiverse universe restricted main
deb-src http://mirrors.ustc.edu.cn/ubuntu/ trusty-updates multiverse universe restricted main
deb http://mirrors.ustc.edu.cn/ubuntu/ trusty-security multiverse universe restricted main
deb-src http://mirrors.ustc.edu.cn/ubuntu/ trusty-security multiverse universe restricted main
(I live in China so I'm using Chinese mirrors)
I also deleted the sources.list.d (it didn't have any critical application sources).
However, attempting to update crouton in Crosh still gives the error "release not recognized." Forcing the update (/crouton -u -u) doesn't work either. My release is trusty, and it's clearly listed in each line of my sources list, so why is it still unrecognized by crouton?
Any help would be great! Thank you.


Replace icons in the Tab Bar

Image resources can be found:
https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?seid=5d11e61ebcecab70f88959bf
All 4 icons are to be replaced and the text follows the icons (explicit text).

iOS implementation can be found here:
https://github.com/AlphaWallet/alpha-wallet-ios/issues/1273

Just a comment on this one. We can improve that before the next release.
Video comment:
https://www.dropbox.com/s/m7uuvndzu8x7zuf/09.06-tab-bar.mov?dl=0

The active tab label text should be blue #1899c2
Increase touch target size to labels too


Add starter pack submodule and update build script

New directory organisation with each deck of slides in decks/ as a submodule so the deck of slides can remain private
And a very quick start template repository with instructions to quickly create a new deck ;)

Thanks for the PR! I see why you'd want to separate this project from the slide deck.
I'm debating whether submodules for decks are the way to go. Maybe it's better to 'install' slides on your system as a software package / module and then use it in a deck.

Yes I am not a big fan of submodules, probably because I break them too often...
I don't like so much installing a package, I prefer to clone the repo and use it. Especially if I want to update some things in the module.
I could go with a separate directory for each deck at the same level as slides. It's a bit hacky but it's dead simple. With a very clear error message if ../slides/ does not exist to remind me to clone this repo there, I think it would be user friendly.

Do you prefer multiple decks in this repo? Or just fork this thing for each
deck? I think I’d prefer that, as each deck may also depend on a different
version of the code
On Fri, 3 Apr 2020 at 13:56, Jean-Baptiste Cordonnier <
<EMAIL_ADDRESS>wrote:

Yes I am not a big fan of submodules, probably because I break them too
often...
I don't like so much installing a package, I prefer to clone the repo and
use it. Especially if I want to update some things in the module.
I could go with a separate directory for each deck at the same level as
slides. It's a bit hacky but it's dead simple. With a very clear error
message if ../slides/ does not exist to remind me to clone this repo
there, I think it would be user friendly.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tvogels/slides/pull/4#issuecomment-608392716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGNI6KV6GQUEYIQQ7OZKDLRKXFFHANCNFSM4L33TE3Q
.

as each deck may also depend on a different
version of the code

Good point!
Then it would be perfect to make this repo a template (so that we can copy it privately instead of forking). And maybe adding a sketch file to start quickly ;)

Then it would be perfect to make this repo a template (so that we can copy it privately instead of forking). And maybe adding a sketch file to start quickly ;)

That sounds nice. Forking would have the benefit that you can still contribute framework edits to the main repo (with cherry-pick)
Do you want to update this PR and add your starter kit?

I had a second thought on this: what do you think of creating a template starter pack with this repo as a submodule, a bit like the ext/ folder of dependencies in nanoGUI. I think it solves all the problems we mentioned above:

it's clone and play
the deck of slides can be private
a deck of slide is bound to a certain version of the library and will always work
you can still contribute to the upstream when changing the submodule

With only one slide deck as a submodule, it could work. I guess the benefit of the submodule is cleaner contributing to slides?
I guess the process would be: check out the repo, remove the template submodule, create a repo for your slides, add that one instead. Not really clone & play?

I was thinking the opposite. Having a repo to clone for each new deck of slides and inside having a slides/ directory (submodule) containing this library.

The process would be, "template" clone the repo in your github, clone it on your laptop and you are ready to update slides.

Ah yes, I didn't read your post carefully. That makes much more sense. Yes, let's do it like that!


Replace bower with npm

Lately there are two issues with bower package installations:

When '^' used, it's retrieving latest major package, instead of minor.
During initial setup, VS could get npm packages but not bower packages (due to firewall settings?), which makes it difficult to install the project on a new computer.

Having two package managers for front-end is already redundant, so if all packages are okay, remove bower and move its packages to npm.

This is okay.
Only datajs v1.1.3 was downgraded to v1.0.3, but it didn't create any issue as far as it has been tested.
Otherwise find a copy of v1.1.3 and store it in /lib folder.