Add command for tailing logs

Could we spec out some ideas about how this might work in an ideal world? We don't have to implement all right away, but I'd like to get the API right.
Here's my proposal for the final API:
cage logs [<pods_or_services>...]

This covers a number of cases:

If it displays logs for more than one container, it annotes each line with the container name.
With no args, it displays interleaved logs for all containers.
With a pod name, it displays the logs for all containers in that pod.
With either pod/service or a unique service name, it displays the logs for that service.

The standard Docker tools include the following options:
Usage:	docker logs [OPTIONS] CONTAINER

Fetch the logs of a container

Options:
      --details        Show extra details provided to logs
  -f, --follow         Follow log output
      --help           Print usage
      --since string   Show logs since timestamp
      --tail string    Number of lines to show from the end of the logs (default "all")
  -t, --timestamps     Show timestamps

docker-compose logs --help
View output from containers.

Usage: logs [options] [SERVICE...]

Options:
    --no-color          Produce monochrome output.
    -f, --follow        Follow log output.
    -t, --timestamps    Show timestamps.
    --tail="all"        Number of lines to show from the end of the logs
                        for each container.

@dkastner Let me fix #8 first (the new argument-parsing scheme), and then you can go ahead and implement any subset of this that you want to work on.

The fancier, multi-container versions of this might benefit from #9, which would make it easier to multiplex tagged I/O from multiple threads or external processes. But that doesn't need to block the initial implementation.

OK, I've added a project.pod_or_service(name) function which can be used to look up either a pod or a service to print the logs from. This will allow you to easily implement:
cage logs <POD_OR_SERVICE>

I wouldn't worry about the multi-pod / multi-service version of this command yet, because doing a good job of that depends on #9, which I want to poke at some more.
To implement this, I would recommend doing the following:

Edit src/cli.yml to add a new logs subcommand with appropriate arguments. See the clap documentation.
Dispatch the new arguments in src/main.rs to your new src/cmd/logs.rs. This should look like:pub trait CommandLogs {
    /// Up all the images in the specified pods.
    fn logs<CR>(&self, runner: &CR, ovr: &Override, pod_or_service_name: &str) -> Result<()>
        where CR: CommandRunner;
}

From inside that function, call match try!(self.pod_or_service_or_err(pod_or_service_name)) { ... } and handle both the PodOrService::Pod and the PodOrService::Service case.

Also, if you want to pass through any arguments, you can add a new args::opts::Logs structure to src/args/opts.rs, based on the ones already there (but ignore the Deref hack; that's going away shortly) and implement ToArgs and add method to ArgMatchesExt in src/main.rs that builds your args::opts::Logs structure based on the ArgMatches structure from clap.
If you have any questions, please let me know!

There are also new goodies in 488bf19 which might be of interest. Although you probably can't use the compose command directly, it would be easy to make a single-item wrapper around it.


Use static facebook visibility animation for screenshots

:eyeglasses: @keybase/react-hackers

:mag_right: The commits 707333bac884...5f0b19c218a8 introduced some visual changes on linux:

Changed: New_Proof_Post-Facebook (before) (after)


As a developer, I have the option of configuring Azure Standard DDoS protection on my Application Gateway

Copied from Azure Dev Ops Backlog

Fixed typo

moved to entref-appservice-containers project


Allow custom sorting for ordered imports

Solves #3864

It's a definite no from me, this would create an injection point in my project PHP-CS-Fixer and similar applications

Closing, as too many deciders disagree with idea, first on initial issue #3864 , then here in PR.
As SpacePossum said, it's possible to extend, but not to allow everything.
If you will like to implement the feature request, you are more than welcome, yet please first align the direction how to do it in ticket, and when it comes to implement it in new PR - remember that each config of every single fixer has to be documented in readme (here, you created new option, but it's not documented)


Add regex to match the story's kind

 Issue by olistic
Tuesday Mar 28, 2017 at 00:00 GMT
Originally opened as https://github.com/storybooks/storyshots/issues/91

What do you guys think about having these two config options: storyKindRegex and storyNameRegex instead of the current storyRegex?
storyNameRegex would behave just as the existing storyRegex, while storyKindRegex would match against the story's kind, giving users more flexibility.
For example, it could be used to solve #84 doing something like this:
// SomeComponent.stories.js

// ...
storiesOf('SomeComponent', module)
    .add('foo', () => {
        // ...
    });

// SomeComponent.test.js

import initStoryshots from 'storyshots';

initStoryshots({
  storyKindRegex: /^SomeComponent$/,
});

Which will cause storyshots (or jest actually) to output a __snapshots__ directory colocated with the component and with just its storyshots.
If you think it is a good idea, I'm happy to submit a PR!

 Comment by olistic
Tuesday Mar 28, 2017 at 00:31 GMT

I guess I'm submitting the PR anyway, it's simple enough and I need it for my projects.

 Comment by alexfedoseev
Saturday Apr 08, 2017 at 03:36 GMT

Why not just writing snapshots next to the stories file? W/o dummy regexp for each component.

@olistic We're interested in this PR, if you'll submit it. We've moved to a mono-repo architecture, if you need help, let us know?

@ndelangen @shilman I migrated the changes from the old repo and made sure the linter passes. PR is now open against the mono-repo!

I think that closes this issue?

I really like this feature, when did you plan to release it?

There's no date yet, sorry. Next release will be 3.0.0.

@marcoala I had published a fork of the old storyshots repo in npm, which includes this feature. I'm using it in my projects until 3.0.0 is released. Just npm i @olistic/storyshots or yarn add @olistic/storyshots.

@olistic Thanks!

I hope this does't sound dumb, but what do you think about adding a reverse of the same option. I know you can do an inverse regex but it may not be easy for some of us.
I am suggesting something like this.
initStoryshots({
  storyIgnoreKindRegex: /^SomeComponent$/,
});

I can put together a PR

@tmeasday What do you think?

Is it possible to just write a negative regelated?

Ugh, regexp

@tmeasday I was using https://regex101.com to try to create inverse regexes and they were not working for some reason and i assumed maybe they were not supported in JS or required rear regex tricks. Tried the same inverse regexes in the browser console window and they worked.
I am guessing maybe we may not need the reverse the same although it might be convenient for people who find regexes intimidating.

Maybe we can add something to the docs? I guess I'm not sure how common
this use case is?
On Fri, 9 Jun 2017 at 19:52 Lukwago Allan<EMAIL_ADDRESS>wrote:

@tmeasday https://github.com/tmeasday I was using https://regex101.com
to try to create inverse regexes and they were not working for some reason
and i assumed maybe they were not supported in JS or required rear regex
tricks. Tried the same inverse regexes in the browser console window and
they worked.
I am guessing maybe we may not need the reverse the same although it might
be convenient for people who find regexes intimidating.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/storybook/issues/892#issuecomment-307347207,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIFyu6CXpZwQTelpZk3vycGStN17nYbks5sCRXBgaJpZM4M-aU8
.

I agree we could add something to the docs in form of an example or leave as is. I doubt its a common use case.

If you want to send a PR of what you did (I don't know how to write a negative regexp myself ;) ), that'd be super!

Just sent a PR https://github.com/storybooks/storybook/pull/1317

@epicallan I tried to use your regexp from docs and I have a file named tooltip.DontTest.stories.js. But the story still not skipping :( Could you please tell me what I'm doing wrong?

@tirli
Can you please share your regex ?

@igor-dv The same as in docs: storyKindRegex: /^((?!.*?DontTest).)*$/

storyKindRegex is for the storyKind (the first parameter you provide to the storiesOf(...)), but not for the story file name..  I think currently is not possible to filter stories by files..

@igor-dv Now it works :) Thank you

Hi, I'm finding a way to separate the snapshots generated by storyshot. I read the README of storyshot and found here.
import initStoryshots from '@storybook/addon-storyshots';

initStoryshots({
  storyKindRegex: /^MyComponent$/
});

This can be useful if you want to separate the snapshots in directories next to each component. See an example here.

This statement indicates that if I use this option, then the snapshots will be separated and be placed nearby each component's source code. I gave it a try but just found the generated snapshots are stilled merge into a big file. The regex works well.
So, do I misunderstand the documents? Or I have a wrong version (3.0.0) or this feature is not available yet? I would appreciate your help :)

@matsumatsu233
Today the only way to do what you want is creating a storyshot.test.js for each story separately. For example having Button.stories.js file you can create Button.storyshots.tests.js and configure it to take only the kind from Button.stories.js.
The limitation is from the Jest's side that do not support multiple snapshots per test file.
But we have this #1584 PR that will probably help with this requirement in the future.

@igor-dv Thank you very much! I will try to create test file for each component, and I'm looking forward to #1584 :)


Limited timezone selection / daylight savings time

Hi, seems like there is no option to configure VMs with the correct timezone where daylight savings time is used.
I want to configure my VMs to have the correct London time. The only suitable option in SCVMM → Template properties → OS Configuration is (GMT) Greenwich Mean Time : Dublin, Edinburgh, Lisbon, London but it doesn't apply during summer as the timezone changes to UTC+1
https://github.com/Microsoft/SCVMMLinuxGuestAgent/blob/d95bd437be488fa7f7407acf6e9f653a523c6d97/vmm/dev/scripts/cfgtimezone#L69
This command relies on a limited lookup list of timezones in https://github.com/Microsoft/SCVMMLinuxGuestAgent/blob/master/vmm/dev/scripts/tztable
For the time to be correct in London it should use /usr/share/zoneinfo/Europe/London  but there doesn't seem to be a way to configure that

Same here for the timezone Europe/Berlin !

Forgot mention a workaround, doh. You should be able to add a RunOnce command to the OS template that does something like ln -s /usr/share/zoneinfo/Europe/Berlin /etc/localtime

I actually did
echo "Europe/Berlin" > /etc/timezone
dpkg-reconfigure tzdata

:wink:

Which doesn't even work properly. Great!

I actually don't see the point in the tztable mapping - why can't the SCVMM just supply the wanted timezone as a string?


[MM-27274] Add and enforce convert public channel to private permission

Summary

Adds and enforces converting channels to private using the new convert public channel to private permission.

Ticket Link

https://mattermost.atlassian.net/browse/MM-27274

Checklist

[ ] Added or updated unit tests? Do we generally do tests for container components?

Device Information
This PR was tested on: iPhone 11 sim

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/10019
https://circleci.com/gh/mattermost/mattermost-mobile/10018

Artifact links:
https://10019-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.apk
https://10018-70265724-gh.circle-artifacts.com/0/~/mattermost-mobile/Mattermost_Beta.ipa


Add workflow to tun GET_PYTHON_MODULES against all roles

@richm please take a look if this workflow needs to do anything special for https://github.com/linux-system-roles/tft-tests/pull/40

Not tested yet, I just hope that this should work. Once this is managed, we can add comment ``[get_python_modules]` to #40 and it will run on the PR

The best way to test this is to fork tft-tests, and in your fork, open a PR in reverse. I.e. do changed on the main branch, then open PR from main to any other branch. This way, the workflow still runs from the main branch, so from the branch where you do changes. You can try cherry-picking commits from #40 and #41 to your fork's branch and open a PR like I described.

I don't think we need a separate workflow for this.  I have been testing with kernel_settings - https://github.com/linux-system-roles/kernel_settings/pull/226 - I add a comment like this: [citest] GET_PYTHON_MODULES - which will run the ci tests with GET_PYTHON_MODULES=true set.  This results in a .packages file for each "regular" log file.  https://dl.fedoraproject.org/pub/alt/linuxsystemroles/logs/tf_kernel_settings-226_CentOS-Stream-10-2.17_20240920-001352/artifacts/
I was planning to add a comment to the weekly_ci PRs - [citest] GET_PYTHON_MODULES - at first, just a one time thing

The actual workflow change is https://github.com/linux-system-roles/kernel_settings/pull/225
Once I get the bugs worked out, I'll revert this

Rich implemented this elsewhere


Should we automatically add extensions to package command results on Windows if -o is used?

Since Windows interprets the file type using its extension, should we add them whenever the user calls the package function that creates a runnable file and the -o flag is given?
E.g.
scala-cli --power package Hello.scala -o hello
./hello

When I tested this snippet, after running the second line, the system asked me which program do I want to use to run the file hello. Using -o hello.bat instead worked.
Another thing:
scala-cli --power package Hello.scala --assembly
./hello.jar

This does not look like it runs the program from Hello.scala, probably due to the way .jar files are being used on Windows.
Any more feedback from active Windows users are very welcome!

Perhaps logging a warning would be enough?
Since the user is passing the output explicitly with -o, it makes sense to follow that, but maybe warn that adding an extension may be a good idea...


Move type assertion tests into TypeTest

Feel free to decline this if it's too much or goes in the wrong direction. The idea is to clean up TypeInferenceTest in data.php which got a bit messy IMO.

This is fine :) Feel free to do the same in phpstan-beberlei-assert if it's similar there.

Thank you.


Proper way to refer to IdentityModel2 in a .netstandared2.0 library.

This issue is related to this StackOverflow question. https://stackoverflow.com/questions/44211741/how-to-resolve-httpclient-exists-in-multiple-libs/44299428.
We need to refer IdentityModel library which is targeting .netstandared1.4 from our library targeting .netstandared2.0. But we also refer to HttpClient in our library as well. Ideally .netstandared1.4 targeted library is callable from higher version targeted library. But IdentityModel also references System.Net.Http outside of the standard library. So we ended up with 2 HttpClients  and failed to build our project. What is the proper way to fix this? Should we wait until newer version targeting .netstandared2.0?

I actually don't know - we had various problem reports because of that.
Maybe open an issue on the dotnet repo asking for right way to deal with HttpClient. Would be interested in the result.


Introduce DynamicContentView

Introducing DynamicContentView
Usage
Dynamic Content is a view that decides which content will be rendering according to your conditions defined in XAML:
<uranium:DynamicContentView Value="{Binding MyNumber}">
    <uranium:DynamicContentView.Conditions>

        <uranium:ValueCondition LesserThan="5">
            <DataTemplate>
                <BoxView Color="Red" />
            <DataTemplate>
        </uranium:ValueCondition>

        <uranium:ValueCondition Equal="5">
            <DataTemplate>
                <Label Text="MyNumber is 5!"  />
            <DataTemplate>
        </uranium:ValueCondition>

        <uranium:ValueCondition GreaterThan="5">
            <DataTemplate>
                <Button Text="Special Button for number greater than 5" />
            <DataTemplate>
        </uranium:ValueCondition>
    </uranium:DynamicContentView.Conditions>
</uranium:DynamicContentView>

The aim of DynamicConentView is performance. This way won't initialize any view when a condition hasn't been met yet unlike managing all of them by setting IsVisible property.

Still needs a converter for numeric fields.

DynamicContentValueTypeConverter has been added but still passing type is highly recommended: {x:Int32 5}"
        <uranium:ValueCondition LesserThan="{x:Int32 5}">
            <DataTemplate>
                <BoxView Color="Red" />
            <DataTemplate>
        </uranium:ValueCondition>


[11.x] Add create quietly method

Add the create quietly method

https://laravel.com/docs/11.x/eloquent#saving-a-single-model-without-events

https://laravel.com/docs/11.x/eloquent#muting-events

You're calling $this from a static method? Did you try the code?


CcHex doesn't add dashes

CcHex doesn't add dashes, for readability

@rultor release, tag is 0.13.3

@rultor release, tag is 0.13.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.13.3

@yegor256 Done! FYI, the full log is here (took me 17min)


Player transfer bug fixes

Many issues with hero transfer fixed in this. Object Transaction system was scrapped for this update and will remain as an on-hold until we see more value in it. SyncStore works fine for now. Mainly serialization updates and manager updates to pass around newly created heros.

I pushed 2 compile fixes in 32ffda5 . Most likely these are due to the latest update.


Better control over the section ordering in documentation

Description
As we've now split the documentation into new sections, we desire control over the ordering of said sections, that wasn't necessary with the Core Nodes or handbook documentation (which order alphabetically)
This change introduces a new map in the createNav function which stores an ordered list of the sections in an array. The order value for a section is then determined by the index in that array, or falls back to MAX_INT, and will show at the bottom (then by alpha if multiple here).
Now:

Checklist

[x] I have read the contribution guidelines
[x] I have considered the performance impact of these changes

Not the most elegant of solutions, but it works, and still provides the flexibility of adding new sections without needing to define an order.


Won't start on Ubuntu 20 after recent update

*NOTE THAT UNCLEAR BUG REPORTS (i.e. without the information requested below like Aug 16 07:08:39.771 INFO locast2tuner 0.1.52 on Linux 5.4.0-81-generic starting..
Aug 16 07:08:39.771 INFO UUID: 7151e129-3bdf-46b1-81f4-aab466850ef1
Aug 16 07:08:39.772 INFO Logging in with USERNAME
Aug 16 07:08:40.014 INFO Login succeeded!
Aug 16 07:08:40.412 INFO Using cached FCC facilities at /var/lib/locast2tuner/facilities
thread 'main' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Decode, source: Error("missing field transcodeId", line: 1, column: 242015) }', src/service/mod.rs:329:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Aborted

Aug 16 08:01:09.508 INFO Cached FCC facilities to /root/.locast2tuner/facilities thread 'main' panicked at 'called Result::unwrap()on anErrvalue: reqwest::Error { kind: Decode, source: Error("missing fieldtranscodeId", line: 1, column: 218065) }', src/service/mod.rs:329:10
Also seeing the same thing...

my issue began with the most recent update to the Ubuntu packages.

I'm seeing the same on my system as well.  Running Ubuntu 20.04 with updates applied yesterday.

Filling this out as a bug report (I'm running on docker, same issue):
NOTE THAT UNCLEAR BUG REPORTS (i.e. without the information requested below like logs, settings, versions, etc) MIGHT BE CLOSED WITHOUT ANY HELP!!
Describe the bug
thread 'main' panic, started around 5am Eastern
thread 'main' panicked at 'slog-scope: No logger set. Use slog_scope::set_global_logger or slog_scope::scope.', /github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/slog-scope-4.4.0/lib.rs:125:13,
stack backtrace:,
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.,
0: std::panicking::begin_panic
To Reproduce
Steps to reproduce the behavior:
Starting/restarting docker container with latest image
** Logs **
10: tokio::macros::scoped_tls::ScopedKey::set,
11: tokio::runtime::Runtime::block_on,
note: Some details are omitted, run with RUST_BACKTRACE=full for a verbose backtrace.,
Aug 16 13:25:43.150 INFO locast2tuner 0.1.52 on Linux 4.15.0-50-generic starting..,
Aug 16 13:25:43.150 INFO UUID: 60e30119-1f04-4661-8b68-1998e028638e,
Aug 16 13:25:43.150 INFO Logging in with<EMAIL_ADDRESS>config selected = /app/config/config ,
Aug 16 13:25:43.163 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:43.407 DEBG response '200 OK' for https://api.locastnet.org/api/user/login?client_id=CqhAMsBw%2BnxTXSJMLGqyOw%3D%3D,
Aug 16 13:25:43.407 INFO Login succeeded!,
Aug 16 13:25:43.419 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:43.617 DEBG response '200 OK' for https://api.locastnet.org/api/user/me,
Aug 16 13:25:43.627 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:43.799 DEBG response '200 OK' for https://api.locastnet.org/api/dma,
Aug 16 13:25:43.802 INFO Using cached FCC facilities at /root/.locast2tuner/facilities,
Aug 16 13:25:43.823 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:43.835 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:44.010 DEBG response '200 OK' for https://api.locastnet.org/api/watch/dma/zip/10019,
Aug 16 13:25:44.034 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:44.036 DEBG response '200 OK' for https://api.locastnet.org/api/watch/dma/zip/30360,
Aug 16 13:25:44.047 DEBG starting new connection: https://api.locastnet.org/,
Aug 16 13:25:44.219 DEBG response '200 OK' for https://api.locastnet.org/api/watch/epg/524?startTime=2021-08-16T00:00:00-00:00&hours=192,
Aug 16 13:25:44.246 DEBG response '200 OK' for https://api.locastnet.org/api/watch/epg/501?startTime=2021-08-16T00:00:00-00:00&hours=192,
thread 'main' panicked at 'called Result::unwrap() on an Err value: reqwest::Error { kind: Decode, source: Error("missing field transcodeId", line: 1, column: 194739) }', src/service/mod.rs:329:10,
stack backtrace:,
0: rust_begin_unwind,
at ./rustc/c755ee4ce8cae6ea977d65a0288480940db721d9/library/std/src/panicking.rs:493:5,
1: core::panicking::panic_fmt,
at ./rustc/c755ee4ce8cae6ea977d65a0288480940db721d9/library/core/src/panicking.rs:92:14,
2: core::result::unwrap_failed,
at ./rustc/c755ee4ce8cae6ea977d65a0288480940db721d9/library/core/src/result.rs:1355:5,
3: <core::future::from_generator::GenFuture as core::future::future::Future>::poll,
4: <core::future::from_generator::GenFuture as core::future::future::Future>::poll,
5: <futures_util::future::maybe_done::MaybeDone as core::future::future::Future>::poll,
6: <futures_util::future::join_all::JoinAll as core::future::future::Future>::poll,
7: locast2tuner::main::{{closure}},
8: tokio::macros::scoped_tls::ScopedKey::set,
9: <core::future::from_generator::GenFuture as core::future::future::Future>::poll,
10: tokio::macros::scoped_tls::ScopedKey::set,
11: tokio::runtime::Runtime::block_on,
** Configuration **
Add a copy of your config. You can get a copy of your running config by opening /config in a browser (e.g http://localhost:6077/config). This will not expose your locast password. If you can't access /config, please add your config file without your password.
Environment
Latest docker image (ghcr.io/wouterdebie/locast2tuner:latest)
Screenshots
If applicable, add screenshots to help explain your problem.
** Environment**
What operating system and version you are using.
Additional context
Add any other context about the problem here.

Same issue on mac running in terminal and installed with brew.
Has been running fine since upgrading to 0.1.52 on Aug 14 and failed last night right at 2AM when it logged back in after the token expiring:
Aug 16 02:00:36.343 INFO Login succeeded!
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Decode, source: Error("missing field `transcodeId`", line: 1, column: 195683) }', src/service/mod.rs:329:10

Restart immediately failed with the same error.

0.1.53 has the fix. It's building as I write this and should be ready in 15 mins or so.


Enhance the alarm and event message conversion error logs

Proposed changes
Make Alarm and Event message conversion error log messages more verbose by adding payload, topic and error string to the error log message.
For example the alarm conversion error message looks as below
2022-12-08T05:36:45.031302856Z ERROR tedge-mapper-c8y:messages{ops_dir=Some("/etc/tedge/operations/c8y")}: tedge_mapper::core::converter: Mapping error: Deserialing of alarm message: {
    "message": "Temperature is very high",
    ", received on topic: tedge/alarms/critical/temperature_high, failed due to error: trailing characters at line 4 column 2

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

@PradeepKiruvale You need to write how to reproduce the error messages that you fixed if you think this PR needs to be verified by QA.

@PradeepKiruvale You need to write how to reproduce the error messages that you fixed if you think this PR needs to be verified by QA.

The steps are added here:
https://github.com/thin-edge/thin-edge.io/issues/1627


Fix(Amap) Use constants for slots

Close #298

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ea99eb6) 56.46% compared to head (53030d6) 56.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   56.46%   56.45%   -0.02%
==========================================
  Files         159      160       +1
  Lines        3482     3488       +6
==========================================
+ Hits         1966     1969       +3
- Misses       1516     1519       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add a Bash version

Thanks for doing this Ben!

I appreciate the contribution! However, I don't think I'll add this version to the benchmarks, because it takes over 2 minutes to complete (even the optimized version), so it doesn't really seem a useful language to be doing it in. I'll still merge the PR so the code is there, but without the benchmarks. Sorry about that!

makes sense, thanks @benhoyt for looking at it!


There are some UT failed in ZookeeperRegisterServiceImplTest

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description
There are some UT failed in ZookeeperRegisterServiceImplTest
https://github.com/seata/seata/runs/5960322217?check_suite_focus=true

Ⅱ. Describe what happened
If there is an exception, please attach the exception trace:
Just paste your stack trace here!

Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

JDK version :
Seata version:
OS :
Others:

please assign it to me


Add --logbufsecs

Review status: all files reviewed, 1 unresolved discussion, all commit checks successful.
Reviewed files:

glog.go @ r1
glog_test.go @ r1

glog.go, line 52 [r1] (raw file):
For consistency with the rest of the comment use tabs instead of spaces.

Comments from the review on Reviewable.io

LGTM, +@rojer

Review status: all files reviewed, 1 unresolved discussion, all commit checks successful.

Comments from the review on Reviewable.io

Review status: 1 of 2 files reviewed, 1 unresolved discussion, all commit checks successful.

glog.go, line 52 [r1] (raw file):
Done.

Comments from the review on Reviewable.io


Locales for MomentJS are loaded when not used (v4)

(shameless copy+paste from my 'fullcalendar' GitHub issue. With a stripped down FullCalendar example (no Vue) the issue is not present. It appears to be vue-full-calendar related.)
According to the docs on locale...

When you load a FullCalendar locale file, it also loads the translations for MomentJS and jQuery UI Datepicker...

Expected behaviour:
Without any locales set, only the default locale (English) should be loaded for MomentJS.
When loading one or more FullCalendar locale files, the related locale files for MomentJS should get loaded, but only those (no more, no less).
What's happening now:
All locales for MomentJS appear to be loaded regardless.
Details:
I'm using the following in a stripped down example found here:
"dependencies": {
  "vue": "^2.5.2",
  "vue-full-calendar": "^4.0.0-1"
},

Futhermore, in the example I cleared the list of events and removed the moment.js import in App.vue and I removed the jquery references in webpack.base.conf.js.
When analyzing the Webpack bundle from this example and even without any locales set for the FullCalendar instance (thus relying on the default English setting), it appears that all locales for MomentJS end up in the final package, resulting in a JavaScript file that's much larger than needed.

Hi @gmw-web
It looks like you are using the prerelease that isn't quite ready yet.
Can you try using a 2.X version of vue-full-calendar?


⚠ Samsung has degraded performance

In a2e5979, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2222 ms

Resolved: Samsung performance has improved in 192ea2e.


Embeding the same form in a list and in a section (and fieldset)

Let's assume that I have a 'template' form named options.yaml:
form:
  fields:
    .options:
      type: checkboxes
      label: Options
      options:
        option_a: Option A
        option_b: Option B
      use: keys

I use this form to embed it in a list:
header.list:
  type: list
  label: List
  style: vertical
  import@:
    type: 'partials/options'
    context: blueprints://

I would like to reuse the same 'template' form in a section (and also in a fieldset):
header.section:
  type: section
  title: Section
  underline: true
  import@:
    type: 'partials/options'
    context: blueprints://

Unfortunately, embedding it in a section (and fieldset) doesn't work. Everything is displayed correctly in admin, but saving does not work (in fieldset I can't even check the checkbox). Is there any way to embed this 'template' form in section and fieldset? I would like to avoid duplicating the file and adding header. before every field name.
I could possibly change section to a list, and set min and max to 1, but I would also like to avoid this.
Example I showed is very simplified. I have multiple 'templates' with many fields, that I later reuse in different places - some are in sections, some in fieldsets and some in lists. It would be a much simpler, if I could reuse the same file everywhere.
PS. I'm not sure if this is related to Grav or just Admin Plugin, so I'm posting it here.

@mahagr you know forms best? Any initial thoughts on this?

I need to take a look at this before I can say anything. If this is an issue, it is surely something that needs to be looked at.

I have a couple of observations that came about when doing some imports yesterday. These may or may not be causing this particular issue, or maybe the ordering issue of imports:

If you try to import@ a chunk of fields under a fields: header, then the import will not work unless there is at least 1 existing child. I added an empty spacer field, and my import all of a sudden started working.

Import@ statements seem to need to exist at the fields: level of indention even when the actual content is purely intended to be children of said fields:.

@pshe94 Did you ever figure this out? I'm having the same issue now, despite implementing what @rhukster suggested. I can get everything to show up just fine in the admin panel, but it deletes when I try to save.


Support some kind of fallback encoder

My use case is to serialize arbitrary clojure data for logging purposes in a library. I cannot guarantee that data will be acceptable by Cheshire (it can include atoms, functions or other objects). On the other hand, it's fine to just include the .toString value as a json string.
I could build on the support for custom encoders, and define an encoder for java.lang.object such as:
(extend-protocol cheshire.generate/JSONable
    Object
    (to-json [this jsonGenerator]
      (.writeString jsonGenerator (str this))))

The issue with this approach is that it changes cheshire's behavior for the entire program, which is not acceptable in a library (no one expects their logging library to change how it serializes http responses, for instance).
If I could pass a fallback encoder function as an option to generate-string, the scope of the extension would be local to the library.
As another alternative, I could build upon https://github.com/dakrone/cheshire/issues/118 and recurse through the data (maybe with postwalk) before sending it out to cheshire, but I worry about the performance impact.

I have precisely the same use case / issue.

Same for me! cheshire.generate/generate could support a fallback option!

Same for me!
Has anyone found a descent workaround?


[Feature Request]: Datepicker working with livewire

Feature Description
Use datepicker (flatpickr) with livewire (wire:model)
Is this feature valuable for other users as well and why?
No response

Please read the docs. This is already possible.

It works just like the other inputs do. I'm not sure what you mean by "doesn't work", but if you have your livewire component set up correctly, a wire:model will work for it.
class MyComponent extends Component
{
    public $myDate;
}

<x-date-picker wire:model="myDate" />


Cannot load capa rules from IDA7.5

Hello everyone
I use Ida 7.5 sp3 with python 3.8 but i cannot load capa-rules to analysis. Error isbelow

I tried capa-rules older version v4 and it doesn't show error but no result after analysis.
I have no way to fix the error !!! pLs help me

So, the v4 rules load successfully but there are no hits?
Could you share a screenshot of the plugin and the output window from IDA?

Please try again with the respective rule release available at https://github.com/mandiant/capa-rules/releases.
Feel free to reopen this if you still have issues.


[DO NOT MERGE] Low Pri: Remove ConcurrentDictionary from CachedBotState

The ConcurrentDictionary in CachedBotState presents a problem when serializing.
This reproduces in the Cafebot when serializing state.
 at System.Collections.Concurrent.ConcurrentDictionary'2.System.Collections.IDictionary.set_Item(Object key, Object value)    at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateDictionary(IDictionary dictionary, JsonReader reader, JsonDictionaryContract contract, JsonProperty containerProperty, String id)    at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)    at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)    at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)    at Newtonsoft.Json.Linq.JToken.ToObject(Type objectType, JsonSerializer jsonSerializer)    at Newtonsoft.Json.Linq.JToken.ToObject[T](JsonSerializer jsonSerializer)    at Microsoft.Bot.Builder.MemoryStorage.ReadAsync(String[] keys, CancellationToken cancellationToken) in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\MemoryStorage.cs:line 77    at Microsoft.Bot.Builder.BotState.<LoadAsync>d__4.MoveNext() in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\BotState.cs:line 67 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Bot.Builder.BotState.BotStatePropertyAccessor'1.<SetAsync>d__8.MoveNext() in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\BotState.cs:line 314 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.BotBuilderSamples.CafeBot.<OnTurnAsync>d__19.MoveNext() in C:\Samples\51.cafe-bot\CafeBot.cs:line 132 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Bot.Builder.AutoSaveStateMiddleware.<OnTurnAsync>d__7.MoveNext() in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\AutoSaveStateMiddleware.cs:line 60 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Bot.Builder.MiddlewareSet.<ReceiveActivityWithStatusAsync>d__3.MoveNext() in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\MiddlewareSet.cs:line 55 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Bot.Builder.BotAdapter.<RunPipelineAsync>d__13.MoveNext() in C:\Users\daveta\bots\botbuilder-dotnet\libraries\Microsoft.Bot.Builder\BotAdapter.cs:line 167

Sorry, that's a partial stack trace there... you don't actually include the details of the exception being thrown? Personally I think it should be Dictionary<,> any way for reasons previously detailed, but I'm still curious exactly what exception you're getting.

Thanks Drew, appears to be a set of a null in a dictionary for serialization.

@daveta What's the update on this PR? Should we close it? or Merge it?

This occurs if you have null keys.  I think this is a pretty fringe case.


Relative CSS File import issue

I'm getting an issue using css-loader in conjunction with this (wonderful) project.  Inclusion of a relative css file via import or require throws the following webpack compilation error via ASP.NET:
ERROR in ./ReactApp/components/ReactApp.css Module build failed: Error: Cannot find module './../../node_modules/css-loader/lib/css-base.js' at Function.Module._resolveFilename (module.js:440:15) at Function.Module._load (module.js:388:25) at Module.require (module.js:468:17) at require (internal/module.js:20:19) at eval (eval at <anonymous> (D:\Code\JavaScriptServices\samples\react\ReactGrid\node_modules\css-loader\index.js!D:\Code\JavaScriptServices\samples\react\ReactGrid\ReactApp\components\ReactApp.css:54:2), <anonymous>:1:18)
Running webpack by itself will correctly process the .css file.
Within the ReactGrid sample application, I added a ReactApp.css file to the components directory and tried to include it at the app's root ReactApp.jsx file: import ./ReactApp.css.  HMR will recognize a new .css file but will not hot reload anything.

I generated a new React project via yeoman and it's working with relative css declarations just fine.  Might just be something funky with the path set up within the samples directory vs the root project.
Anywho, I'm good.  Will close unless there's anything else to add.

OK, not sure what was weird about your first project, but glad a new one was OK. If you do track down what was wrong and you suspect it's something anyone else might hit, please let us know!


Bump v4.0.0-beta.2

Signed-off-by: MyonKeminta<EMAIL_ADDRESS>
What have you changed?
Bump v4.0.0-beta.2
What is the type of the changes?

Misc (other changes)

How is the PR tested?

Unit test
Integration test

/run-all-tests


Multi-agent search stops at the edge of the map

When my agent searches or runs away, it hits the edge and can't run

Hi,

the (self-organizing search) environment is designed in this way. When an agent collides with an obstacle, e.g., a boundary, it will die in its location.
If you want a less restricted search environment where an agent will be penalised by reward if it collides with obstacles but will keep alive and continue the game, we recommend the Pursuit-Evasion-O environment of our new work in https://github.com/LijunSun90/pursuitMatrixWorld. If you want to compare with our algorithm, you can continue use the current repository, or our new environment. We will integrate our algorithm FSC2 in that new repository soon.
If there are other problems, you are welcome to contact us.


Error indexing a resource into DPUL

[DPUL/production] Psych::DisallowedClass: Tried to load unspecified class: IIIF::OrderedHash
https://figgy.princeton.edu/catalog/d52aa68c-6fb4-4afc-8398-dd9dd503b04f
Backtrace
line 87 of [PROJECT_ROOT]/app/services/iiif_manifest.rb: add_metadata
line 15 of [PROJECT_ROOT]/app/services/iiif_manifest.rb: to_solr
line 58 of [PROJECT_ROOT]/app/models/iiif_resource.rb: reindex

View full backtrace and more info at honeybadger.io

Fixed by https://github.com/pulibrary/dpul/pull/1444

Error still occurring

stackoverflow suggests we should add the class to https://github.com/pulibrary/dpul/blame/0dfca59508dbb7d6e5b3fd26ea763712c2957b58/config/application.rb#L35


Invalid streamlines for software

This is outside of the scope of the specification, but it is related to what is written inside of the 'container'.
Even if it is true that someone could write what he/she wants in the file and get away with it for internal use, it could be nice to discuss what we DO NOT want to see when we share files.

For example, at the SCIL (and to some extend in Dipy), streamlines with 0 points are problematic (I think it cannot be written or loaded by Nibabel. I believe no software should play with this idea. In the TRX that would be achieved by having two sequential identical offset values. This should absolutely be against the specification, offsets should have unique, always increasing values.

At the SCIL, streamlines with 1 point are not considered streamlines. It can be written in TRK/TCK and is somewhat useful for some visualization (Workaround some tools to show only endpoints) and mostly debug. I think that for "normal" data generation of tractogram streamlines with only 1 point should be removed by default. Leaving a --debug_single_point is acceptable.

Streamlines with 2 perfectly overlapping point, a step-size below 1x10^-6, are problematic for some software. Furthermore, since TRX supports float16 this would become perfect zero and that could be a problem. I think these should be removed by default. Leaving a --debug_overlap_point is acceptable.

Finally, it would be nice that streamlines do not end up out of the volume used to generate them. That's true in RASMM as well as VOX. Why would a streamline be outside of the data? Of course, it can be written and even loaded in most software and be usable data. BUT it would be nice if we had an agreement not to write streamline like that in "normal" data generation of tractogram. Leaving a --debug_outside_bbox is acceptable.

Related to this issue, I saw more than once single point streamlines or entire streamlines at -INF or +INF, or streamlines having their last/first points at -INF or +INF, which was causing rendering issues with automatic camera position (MITK, TrackVis), etc. So removing them not only makes sense it could help a bit.
Internally we have a scil_remove_invalid_streamlines.py that removes any streamline of these 3 cases, so I am sure we can deal with this ourselves. But in an effort to bring more unity to the field and facilitate the exchange of data and limits corner case for everyone in every tools/library it would be nice that the default case is more stable.
This is similar to reserved keyword/tag for metadata and header, nothing is forcing anyone except the desire to make it easy to exchange data.
PS : I mentioned the TRX for 'fun fact', but this is actually relevant for any file format past, present or future.

@jchoude @mdesco in your experience with weird datasets, phantoms, challenges and clinical data have you ever seen something that could be relevant here?
It would not be mandatory, I don't think anyone wants the file format to magically crash by itself if these happen. But having an agreement on what no one likes could be useful when its time to implement their reader/writer and other I/O functions.

What you mention above covers (I think) most weird cases I'm seen in the latest years.  If you need, I could find data with such examples.

I appreciate these might cause trouble with various software implementations. Personally though, I think as long as the format allows for zero or length 1 streamlines without being overtly malformed, implementations will need to be robust to that. Murphy's Law dictates they're going to happen...
Same with coordinates that end up outside the FoV of the original dataset: there's nothing actually wrong with that, and it's hard to even detect without access to the original dataset and explicitly checking for this. What if the vertex is right on the boundary, but ends up outside due to a simple rounding error? But more generally, users are bound to do this eventually, and they may even have legitimate reasons for doing so that we haven't anticipated.
Yes, we could mandate that compliant data should not do any of the above, but I expect someone will eventually do just that - maybe they've not read the spec. Or more likely, they may not have bothered to perform the sanity checks this would require when generating the data. Regardless of what the specification might state, I don't think there's any way around making implementations robust to these cases.
Just my 2¢, obviously...

I totally agree that the file format should not be limited to avoid explicitly these cases (which are bound to happen).
But I think that the main "generator" of tractogram could make an effort to avoid these cases. Since we do have access to the data (since we are generating tractogram) and that such checks are easy to do as each streamline get generated we could avoid being the ones introducing such 'corner case'.
So I understand now that this is outside of the scope of the specification, but my point can then be switch to implementation. Do you think avoiding these cases (in mrtrix for example) by adding a few checks at save time of tckgen would have a downside? (skipping the checks could be optional)

But I think that the main "generator" of tractogram could make an effort to avoid these cases.

Do you think avoiding these cases (in mrtrix for example) by adding a few checks at save time of tckgen would have a downside?

I think it's important here to establish that algorithms that perform tractography to generate streamlines from DWI data are not the only sources of streamlines data. There are multiple other processes for which streamline vertices are an output.
The one that caught us out was non-linear spatial transformation of streamlines vertices. In the ideal case, this is merely a shift in position of each vertex individually, and data-per-streamline / data-per-point (-vertex) would not only not be affected but also have correspondence to both pre-transformation and post-transformation vertex data. However, vertices of a streamline may lie outside of the volume of valid non-linear transformation information. In the case of the .tck file format, non-finite values (NaN, Inf) are reserved as delimiters, and hence retaining such vertices in-place but with "invalid" values was not possible. So removal of those vertices from the streamlines data was necessary, which immediately breaks correspondence between data-per-point (/-vertex) data and streamlines vertices. If all vertices of a particular streamline lie outside this region, then one can either write a zero-vertex streamline (now our solution: MRtrix3/mrtrix3#2159) or break correspondence between data-per-streamline and vertex data. Now in the case of something like TRX, you could detect that such is occurring and re-write all contained DPP / DPS data as necessary, hence "preventing the breaking of correspondence between associated data"; but it would nevertheless still break the implicit correspondence between the original streamlines data source and that result.
In my case all I do is report on the presence of zero-vertex and single-vertex / "zero-length" streamlines if the user runs a command that calculates streamlines lengths (tckstats). I would similarly endeavour to issue warnings for any calculations where such data actively preclude such calculations, though I certainly can't guarantee I've caught all cases. But similarly to @jdtournier I'd prefer that the awkwardness of such cases, or existing assumptions of specific softwares, not lead to explicit forbidding of such data within the specification.
If TRX does not use delimiters and hence NaN-valued vertices could be utilised in such a scenario, that would potentially be more faithful to the originating data; but if softwares currently err with single-vertex streamlines or streamlines with two vertices that are too close to one another, they would almost certainly have issues with NaN-valued vertex locations; so that would not mitigate the need for greater care in software implementations.

For fun's sake, another interesting use case is vertex masking, i.e. using a binary image to modulate which streamline vertices are retained and which should be removed from the dataset. Masks are often used during tractography to control when to stop propagation, but there's no theoretical reason why this process can't be applied post hoc to include / exclude streamlines. But there's a trap: a single streamline input can be bisected as a result of the masking process. With our code currently, in this case a single streamline in the input file can result in multiple streamlines in the output file, breaking DPS correspondence. The alternative (if permissible in a format) would be to NaN-fill the excluded vertices. Maybe more faithful to the process would be to produce a DPP mask based on that mask image, but e.g. if one wants to use such a mask to control which streamline vertices to display, there then needs to be a software mechanism in place to modulate whether or not each vertex is displayed based on DPP data.

Do you think avoiding these cases (in mrtrix for example) by adding a few checks at save time of tckgen would have a downside?

Not really a big deal, no. These corner cases can be useful in some contexts (e.g. just storing the seed point locations when no streamline was generated), but the current framework provides alternative and better ways of doing this anyway. Not storing streamlines outside the original dataset is what happens anyway, but we do often still need to handle cases where the streamlines are being mapped or transformed onto different datasets whose FoV don't match. So I don't think that needs any special handling at write-time, but it definitely requires handling where required at read time.
Just to be clear: I have no objection to the spec providing a list of undesirable cases like this. I just don't think it will therefore remove the need for validation when loading these data.

I agree that streamlines outside of volume is quite common for registration. My point was specifically only for data generation, at save time during the tractography process, same with overlapping points or zero/single step streamlines. These "cases" would only be undesirable straight out of tckgen or local_tracking in Dipy for example. Advanced processing such as connectomics or nonlinear transformation are more complex, so in my mind I was not requesting anything concerning these operations.
I will not include these as undesirable in the specs since I was proposing to try to avoid these cases only at tractography generation, the very first step only. And only in normal cases, default config tracking. And since various operations will likely still get into these corner cases (rightfully or not) it is true that code will have to handle it one way or another.
PS: When I said -INF +INF, it was also -65536/65536 (highest allowed values, but I saw that more often with trk than tck)


Multiple Local Video Files Directories

Feature request. A way to have multiple local video directories.

For now you can probably work around this by symlinking


develop

Impl PyList::enumerate
Add py example: enumerate
Enumerator トレイトに統合
input をモジュールに分割
Add test: arr_enumerate_works
Impl Enumerator for String
Add some examples
Update README: enumerate

Codecov Report
Base: 86.95% // Head: 85.71% // Decreases project coverage by -1.24% :warning:

Coverage data is based on head (e14fa4b) compared to base (c510a13).
Patch coverage: 85.71% of modified lines in pull request are covered.

:exclamation: Current head e14fa4b differs from pull request most recent head e87999d. Consider uploading reports for the commit e87999d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   86.95%   85.71%   -1.25%
==========================================
  Files           2        2
  Lines          23       28       +5
==========================================
+ Hits           20       24       +4
- Misses          3        4       +1

Impacted Files
Coverage Δ

src/enumerate.rs
85.71% <85.71%> (-14.29%)
:arrow_down:

src/input.rs
85.71% <85.71%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Post card sizes look uncomfortable

I don't know whether other people feels, but I think some of these post cards are too hight or too big
See screenshots below:

I think reason is post image, I saw official demo post image size was 1400 x 933, so I tried to change every post image size in my blog, but the result was first post card same as official demo, others post cards change nothing or change a little bit
Check my blog

Detail
Ghost 1.5.1
Casper 2.0.2

Upgrade to 2.0.3, same as 2.0.2

@ImKcat the card size is determined by the amount of text, Casper uses the the {{excerpt}} helper with a "words" setting of 33 which for English works OK.
I think the problem you're seeing arises because the helper can only count spaces as "words" so when using certain languages which don't have english like word boundaries you end up with more content than desired. I would suggest adapting your theme to use the characters` parameter or using the new custom excerpt feature to tailor the content that is displayed in each post.
I'm going to close this issue as it's not a problem in Casper itself and Ghost has added features to work around the limitations of the {{excerpt}} helper.

@kevinansfield Thanks ; )


0.8.8 on PyPi

Hi ! Thanks for releasing 0.8.8. It looks like it's not on PyPi yet. Can we expect it to be updated there soon ?

Uploaded.


Cant run example

Using the minimal example i get the following error:
Cannot find module 'localhost.daplie.com-certificates'

Fixing momentarily...

try v1.0.4

like that? npm install --save-dev<EMAIL_ADDRESS>doesn't work..

[LEX] creating sniCallback {
"debug": true,
"webrootPath": "/tmp/acme-challenge",
"configDir": "/home/ben/letsencrypt/etc",
"privkeyPath": "/home/ben/letsencrypt/etc/live/:hostname/privkey.pem",
"fullchainPath": "/home/ben/letsencrypt/etc/live/:hostname/fullchain.pem",
"certPath": "/home/ben/letsencrypt/etc/live/:hostname/cert.pem",
"chainPath": "/home/ben/letsencrypt/etc/live/:hostname/chain.pem",
"server": "https://acme-staging.api.letsencrypt.org/directory",
"letsencrypt": {
"backend": {}
}
}
/home/ben/projects/getMoving/getMoving/node_modules/letsencrypt-express/lib/standalone.js:188
plainPorts.forEach(function (addr) {
^
TypeError: undefined is not a function
at Object.listen (/home/ben/projects/getMoving/getMoving/node_modules/letsencrypt-express/lib/standalone.js:188:16)
at Object. (/home/ben/projects/getMoving/getMoving/app.js:60:21)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3

my code:
lex.create(app).listen(3000, function() {
console.log("Express server listening on port: " );
});

listen takes two arrays (for plain and tls ports), not one number
.listen([80], [443, 5001], function () {
  console.log("ENCRYPT __ALL__ THE DOMAINS!");
});

I should probably make an error message for that...

I have changed to:
lex.create(app).listen([3000], [443, 5001], function () {
console.log("ENCRYPT ALL THE DOMAINS!");
});
However when i do:
https://localhost:3000/ or https://localhost
It doesn't work..
(I am new to SSL..can i test on local?)

https://localhost.daplie.com is the testing domain for localhost.
You can't test a real domain on localhost though, you'd have to run it on your server.

Did that work? Can I close this?

Since I haven't heard back, I'm closing this.


RM3 stop words

The RM3 reranking is called at https://github.com/lintool/Anserini/blob/master/src/main/java/io/anserini/search/SearchWebCollection.java#L202 where the constructor takes a stop words list file as the argument.
I am not sure how the file was generated - but my guess is it was extracted from the index using https://github.com/lintool/Anserini/blob/master/src/main/java/io/anserini/util/ExtractRm3Stopwords.java (although there are 500 terms in https://github.com/lintool/Anserini/blob/master/src/main/resources/io/anserini/rerank/rm3/rm3-stoplist.gov2.txt whereas the default output size is 100)
If this is true then the stop words list is collection dependent.
@lintool do you think it would affect the results of other collections? i.e. CW09B, CW12-b13, CW12-full.
This is the reason that why I did not test the RM3 on earlier TREC collections and any clarification will be appreciated.

That is correct - I have not done any stopword tuning (e.g., number of terms, etc.), and I've just used the gov2 terms for all the other RM3 runs. Please feel free to tune...

With the recent implementation of regression tests, it is perhaps time to revisit this issue.


Small typos in code examples

Summary
There are small typos in some of the code examples on the guidance site.
💬 Description

In the react example of breadcrumbs, the second breadcrumb href has an extra space (see screenshot 1)
Skeleton contains height="20" but height doesn't exist (see screenshot 2)
<IcSkeleton variant="circle" height="20" />
Seems like it could just be a typescript issue, but textfield example comes with maxLength="25" but a string isn't assignable to a number so it would only accept maxLength={25} (see screenshot 3)
The Select react example has const [value, setValue] = useState(null); however in typescript projects where <string> is needed, null causes errors. Should look more like this for typescript projects: const [value, setValue] = useState<string>("");

💰 Use value
Users should be able to copy and paste code examples without getting errors.
Additional info

In relation to point 2, the prop rows on the react component IcTextField is a number type. The react examples with the prop rows should be in brackets instead of speech marks, e.g. {6}

Hi, kindly assign this to me


Ton coin did not drop to the wallet address

Please help me retrieve the ton coin that I just sent here is the wallet address and comments number
EQDD8dqOzaj4zUK6ziJOo_G2lx6qf1TEktTRkFJ7T1c_fPQb
Comments number 12368553bybit

Please help me retrieve the ton coin that I just sent here is the wallet address and comments number EQDD8dqOzaj4zUK6ziJOo_G2lx6qf1TEktTRkFJ7T1c_fPQb Comments number 12368553bybit

@Omobaprince  It sounds like your query would be best dealt with by the support team.
I'll have to refer you to the official support live chat with the ticket ID TON07638
Please see the link below to our dedicated support line:
Ton live support
Note; Click on the live chat icon at the bottom corner of the page to initiate chat with a live support agent

Contact the Support page to resolve your request.
Note: You can also initiate a chat with the live agent on the chat button to get more information about your request via Live Chat
@Omobaprince
Support.
{c}2024

Please help me retrieve the ton coin that I just sent here is the wallet address and comments number
EQDD8dqOzaj4zUK6ziJOo_G2lx6qf1TEktTRkFJ7T1c_fPQb
Comment 11839982

@Emoni12 Thanks for posting the issue.
Your query would be best dealt with by the support team.
For the fastest resolution please see the link below to our dedicated support line:
Support : Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

@Emoni12 Thanks for posting the issue. Your query would be best dealt with by the support team.
For the fastest resolution please see the link below to our dedicated support line:
Support : Help Center
Note: Click on the live chat icon at the bottom corner of the page to start a conversation

Hi. How can I
My own NFTs or tokens,Should I send it to my personal wallet?!


Transfer openmodel.ml and chassis.ml domains to the Modzy team

@n8mellis is this still outstanding? whois returns an owner in the netherlands.


[QUESTION] How to avoid recursion in redux?

Problem:
Component receive props from router (params, query) and call dispatch from componentWillMount method. All good. But if we use filtering / sorting / pagination in component with new query string (example /news/list?page=5) new props passed to componentWillReceiveProps method - we catch recursion.
router > componentWillMount -> dispatch -> componentWillReceiveProps -> dispatch ...
How to avoid this situations?
Sorry for my bad english.

componentWillReceiveProps(nextProps) {
  if (nextProps.query.page !== this.props.query.page) { // only when necessary!
    this.props.fetchPage();
  }
}

But i think it's a bad solution, because i have many params or dynamic params. Any other solution?

I'm curious about this as well. What is the best practice here?


Search across catalogs

Add a large central search box on the landing page https://devarchy.com/ to search across all catalogs.
Thumbs up this if you want this feature.

Not doing this in the short/mid term. Closing for now.


pytest-ibutsu is missing some dependencies

It seems that pytest-ibutsu is missing some dependencies, specifically 'attrs'

attrs is specified in dependencies https://github.com/ibutsu/pytest-ibutsu/blob/master/pyproject.toml#L17, and tests pass

Weird, I installed it on a clean env and it didn't seem to have it. Maybe I had an older version somehow.


backport: Derive Clone for tendermint::PrivateKey

Backport of #1082 for v0.23.x.

[x] Referenced an issue explaining the need for the change
[ ] Updated all relevant documentation in docs
[ ] Updated all code comments where relevant
[ ] Wrote tests
[x] Added entry in .changelog/

Doesn't appear as though Clone is implemented for ed25519_dalek::Keypair, so we'll leave this for the v0.24.x release of tendermint-rs.


Group by month

Hello, It could be awesome to group heatmap by month to get something like:

I have done something similar using the package. I create separate calendars and arrange them in a grid. It would be nice if there was a props that could automatically do this.

Nice. Could you share the props you used to get this result ?

@SamSunani I would like to check how you did this as well. Could you share it please.

Hi everyone,
@skjo0c @xuopled
sorry for the late reply.
Here is the code I used to generate this:
I create a calendar array with the start and end dates for each month. The first month's date is inside calendarStartDate
 const { calendarStartDate } = props;
 const calendarDatesArray = [];
for (let i = 1; i < 5; i++) {
    calendarDatesArray.push({
      start: new Date(
        Date.UTC(
          calendarStartDate.getFullYear(),
          calendarStartDate.getMonth() + i - 1,
          0
        )
      ),
      end: new Date(
        Date.UTC(
          calendarStartDate.getFullYear(),
          calendarStartDate.getMonth() + i,
          0
        )
      )
    });
  }

and then using the calendar date array I create four CalendarHeatmap. I create it inside a Grid which is part of semantic-ui-react
  <Grid columns="two">
{calendarDatesArray.map((date, index) => (
          <Grid.Column key={index}>
            <CalendarHeatmap
              showWeekdayLabels={true}
              startDate={date.start}
              weekdayLabels={['Mon', 'Mon', 'Wed', 'Wed', 'Fri', 'Fri', 'Sun']}
              endDate={date.end}
              horizontal={false}
              values={props.values}
              transformDayElement={(element, value, index) => {
                  do_something()
              }}
              classForValue={value => {
                  do_something()
              }}
            />
          </Grid.Column>
        ))}
  </Grid>

I had issues displaying the proper names of days of the week, so I used  weekdayLabels={['Mon', 'Mon', 'Wed', 'Wed', 'Fri', 'Fri', 'Sun']} to overwrite the previous values and offset the labels so my week begins with Mon.

@SamSunani thanks for your help, I was able to recreate it for my project as well. But it looks like weekdayLabel is shown only for even days!


Date filter cuts off date in Chrome

It seems like the comparator dropdown is far too wide and the date picker input doesn't have enough room. The CSS for the date input includes a hard coded calculation which makes it hard to override.

it's minor issue I will handle it if I have time, PR is welcome 👍

How to filter date like an example I selected start date yesterday and End date today and it will select data all from the start date and end date all


Using transformers with created/accepted

It would be really useful to be able to use transformers with the created and accepted response helper methods. Currently it seems impossible, at least I can't figure it out?

You can do something like this:
// create a new object and save it to the database
$object = new Object();
$object->name = "test";
$object->save();

// output the result
// e.g, use a transformer with the respective object information and status code
return $this->response
    ->item($object, new ObjectTransformer())
    ->setMeta(/* additional Meta information */)
    ->setStatusCode(201);

Does this solve your problem!?

@johannesschobel Yes, thank you very much!
Would it be possible to include this functionality in Dingo?

What do you mean "include this functionality"? This is already fully included in dingo/api ...

@johannesschobel Sorry, let me clarify what I meant!
Can we change the definition of Dingo\Api\Http\Response\Factory::created and ::accepted so that we can pass transformer objects for the $content parameter? As such:
$this->response->created('/foo/1', $foo, new FooTransformer)

Currently they only take $location and and $content as parameters.

Aaaaaaah.. not i understand your problem...
Note that created() only provides one parameter, which is the location of the entity, which was created.. This location can be found in the http headers of the response (field Location I think).
In my opinion, both methods (accepted and created) are mainly used to redirect the requestor to another endpoint of your API, where the entity can be requested.
This enhances maintainability of your API, because you can "reuse" already implemented routes (e.g., to show the created entity you may send the requestor the URI to the /show/{id} route).
I know, that is one more request, for the client, and so on... BUT it makes your API, as well as the communication with the API, more understandable and self-explanatory...
However, if you want to send back "real" data, use the collection, item or paginate method (whatever suits your needs best).

Okay, thank you for the help!

@denizdogan What @johannesschobel is correct, but the second param on both responses is $content. If you give that a Eloquent model or collection of models, Dingos response class will automatically use the transformer you have registered for that model.


Add initial github.actions.workflows.name package

This PR start to populate the repository with a github.actions.workflows.name package that enforces name in workflow, step and jobs in GitHub Actions workflows.
It then adds a Makefile with some helpful target and reuse them via a GitHub Actions workflow to validate and test policies.

It would be nice to have it running only for files under .github/workflows but I think it can be merged for the moment and then eventually improved to do that!


Vagrant

Adds vagrant support for development environments.
Closes #45.
@chriskrycho @brson This should make it significantly easier to contribute!

Sweet!


ARROW-10968: [Rust][DataFusion] Don't build hash table for right side of join

This PR changes to not build an index for the probe side of the join.
This has big impact on join performance, e.g. query 12 has a >4x speedup.
Query 12 (locally, in memory).
Master
Query 12 iteration 0 took 1102 ms
Query 12 iteration 1 took 1084 ms
Query 12 iteration 2 took 1099 ms
Query 12 iteration 3 took 1077 ms
Query 12 iteration 4 took 1082 ms
Query 12 iteration 5 took 1098 ms
Query 12 iteration 6 took 1081 ms
Query 12 iteration 7 took 1101 ms
Query 12 iteration 8 took 1138 ms
Query 12 iteration 9 took 1084 ms

PR
Query 12 iteration 0 took 257 ms
Query 12 iteration 1 took 255 ms
Query 12 iteration 2 took 255 ms
Query 12 iteration 3 took 254 ms
Query 12 iteration 4 took 260 ms
Query 12 iteration 5 took 261 ms
Query 12 iteration 6 took 266 ms
Query 12 iteration 7 took 259 ms
Query 12 iteration 8 took 256 ms
Query 12 iteration 9 took 255 ms

FYI @andygrove @jorgecarleitao

Codecov Report

Merging #8965 (7c03853) into master (d65ba4e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #8965   +/-   ##
=======================================
  Coverage   83.25%   83.26%
=======================================
  Files         196      196
  Lines       48116    48196   +80
=======================================
+ Hits        40059    40128   +69
- Misses       8057     8068   +11

Impacted Files
Coverage Δ

rust/datafusion/src/physical_plan/hash_join.rs
92.19% <100.00%> (+0.09%)
:arrow_up:

rust/parquet/src/arrow/array_reader.rs
77.00% <0.00%> (-0.56%)
:arrow_down:

rust/parquet/src/arrow/schema.rs
91.31% <0.00%> (-0.50%)
:arrow_down:

rust/parquet/src/encodings/encoding.rs
95.24% <0.00%> (-0.20%)
:arrow_down:

rust/parquet/src/file/statistics.rs
93.80% <0.00%> (ø)

rust/arrow/src/array/array_binary.rs
90.73% <0.00%> (+0.21%)
:arrow_up:

rust/parquet/src/schema/types.rs
90.19% <0.00%> (+0.26%)
:arrow_up:

rust/datafusion/src/datasource/parquet.rs
95.62% <0.00%> (+0.30%)
:arrow_up:

rust/parquet/src/arrow/arrow_reader.rs
91.25% <0.00%> (+0.66%)
:arrow_up:

rust/parquet/src/file/metadata.rs
91.82% <0.00%> (+0.77%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65ba4e...5159ef2. Read the comment docs.


Derive Debug for Data and Enums

Hey, it would be nice to be able to debug these types and make serialization easier. I hope you would consider merging this.

Hi @ssolit  The error here is likely to be accidental, and subsequent retries are based on the first cache, so the error continues. I tested it locally with no errors. Can you help force push this PR and use different commit information to trigger CI execution?

I believe I did what you requested. I rebased off of the latest dependabot commit in origin/main and mildly changed the commit message.
I can't see if this is going to work on my end because the workflows are skipped until there's an approving review. If it doesn't work again should I create a fresh PR?

It seems now "CoCo-AS Rust Suites / Check (pull_request)" is failing. However it succeeds when I run it locally

Re-running. Let's see if the caching works out.
@Xynnn007 maybe we should take another look at how we are comparing the errors in the test. That may be a bit error-prone.
I had some trouble comparing errors in some other tests and introduced a weird compare errors function. I'm not sure if there is a great generic way to do it.

Hi @ssolit , the error is not related to your PR I believe. I have put a PR for the CI error https://github.com/confidential-containers/trustee/pull/538
Let's take a rebase after that gets merged and hopefully all will be green

@ssolit hey, could you help to take a rebase of this PR? #538 fixed the CI error I think hopefully

Thanks @ssolit

Thank you all for help getting the change in


Multi language support

It's support multilanguage that i know. I want to know how do i display the attribute name in the selected language. We are defining key names in the controller and field/column in validation message displayed on that basis.
e.g.
$rules = ['User Name' => 'required|min:3|max:60', 'User Password' => 'required|min:7|max:25'];
if we use the above rule in controller it will look for User Name and show the message as per the validation file defined in lang folder.
Defined in lang file : "The :attribute field is required."
It will show ""The User Name field is required."
But in case of another language like in hindi how do we show User Name in hindi.

Try attributes key in lang/{{ your lang}}/validation.php :
    /*
    |--------------------------------------------------------------------------
    | Custom Validation Attributes
    |--------------------------------------------------------------------------
    |
    | The following language lines are used to swap attribute place-holders
    | with something more reader friendly such as E-Mail Address instead
    | of "email". This simply helps us make messages a little cleaner.
    |
    */

    'attributes' => ['User Name' => 'User Name in Your Lang'],

Thanks its working.


This patch is no longer needed

Changes were merged upstream and now this patch breaks the build.

Also bumped to latest go patch release.


Fixed #27081 -- Allowed migrations to serialize methods on pypy.

Fixed existing test failures in migrations.test_writer on pypy.
https://code.djangoproject.com/ticket/27081

@MarkusH, you worked a little with pypy before. See any problem here?


Add a keybind to delete a whole line[FEATURE].

Is your feature request related to a problem? Please describe.
I want the editor to delete a whole line when someone presses CTRL + x
Describe the solution you'd like
The key can be added to src/input.c in the procKey function. And the line can be deleted with the delRow function.

can you assign the issue to me?

sure

which file has the shortcut to exit and save the file? I will add the shortcut there

for now in input.c in prockey function

I need this too

@proh14 sorry I wont be able to do it, I have recently gotten busy with something else :(( Really sorry

Added in 87f9561b300a971bc7697631a872fcd14f4d2147


react-three-fiber onWheel

From the docs...
"If you use react-three-fiber, onWheel might prove useful to simulate scroll on canvas elements."
@drcmda Do you have an example of this yet? :)

Hey! It's still in progress, but there is now one:
https://codesandbox.io/s/react-three-fiber-suspense-gltf-loader-l900i


Move the webworker to the highlight function

Actually the webworker code is done basically in the highlightElement function - thous leaving the raw highlight method to be alway executed in the browser.
What do you think about moving the webworker code in the inner highlight function?
It would help who's using that function for custom purposes.

If this is something you're interested in pursuing, we'd welcome a PR! Otherwise, I'm closing as we probably won't address this ourselves.


Update README.md

Correct cleanupInput option section.
Correct spelling.

Coverage increased (+1.4%) to 96.042% when pulling d5c093a8c5ef0dedf1442306423fe64feee3fc83 on leotm:master into 96634727ec973ee0a57c5060139bfd747f079b67 on paquettg:master.

Good to see ya Gilles! 🎉


Add Ada constructor to Token datatype

Add Ada constructor to Token datatype to avoid using (Token "" "") to represent Ada values.
This appears a lot in pretty-printing, Blockly, Show, etc.

I don't want to do this because this is not how we expect things to be represented in the real version.
I don't mind if you want to change the pretty-printing though.

That's for Marlowe Token datatype only, though, not the Ledger stuff.


multiple issues running on ubuntu 22

Environmental Info:
K3s Version:

k3s version v1.25.3+k3s1 (f2585c16)
go version go1.19.2

Node(s) CPU architecture, OS, and Version:

Linux oa-node-0 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:03:55 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

3 servers, 3 agents
Describe the bug:

After update of host OS Ubuntu 20.04 -> 22.04 pods cannot connect to each other between nodes. Even within the same namespace. So NodePorts & Ingress do not properly work also.
Steps To Reproduce:

Installed K3s:
with custom ansible role.
k3s config.yaml:
token: xxx
bind-address: <IP_ADDRESS>
node-ip: <IP_ADDRESS>
tls-san:
  - "oa-cluster.local"
disable: ['traefik', 'servicelb']
kubelet-arg: ['container-runtime=remote', 'container-log-max-files=3', 'container-log-max-size=10Mi']
kube-proxy-arg: [ 'conntrack-max-per-core=0', 'proxy-mode=iptables']

systemd unit:
[Unit]
Description=Lightweight Kubernetes
Documentation=https://k3s.io
Wants=network-online.target
After=network-online.target

[Install]
WantedBy=multi-user.target

[Service]
Type=notify
EnvironmentFile=-/lib/systemd/system/k3s.service.env
KillMode=process
Delegate=yes
# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNOFILE=1048576
LimitNPROC=infinity
LimitCORE=infinity
TasksMax=infinity
TimeoutStartSec=0
Restart=always
RestartSec=5s
ExecStartPre=-/sbin/modprobe br_netfilter
ExecStartPre=-/sbin/modprobe overlay
ExecStart=/usr/local/bin/k3s server --cluster-init --debug --flannel-external-ip --v 5

.env file:
HTTP_PROXY="http://<IP_ADDRESS>:3128"
HTTPS_PROXY="http://<IP_ADDRESS>:3128"

NO_PROXY=<IP_ADDRESS>/8,localhost,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>,<IP_ADDRESS>

sysctl:
  - fs.inotify.max_queued_events= 32768
  - fs.inotify.max_user_instances= 2048
  - fs.inotify.max_user_watches= 16384
  - kernel.panic_on_oops= 0
  - kernel.panic= 10
  - net.ipv4.ip_forward= 1
  - vm.overcommit_memory= 1
  - vm.panic_on_oom= 0
  - net.core.somaxconn=65535
  - net.ipv4.ip_local_port_range=1024 65535
  - net.nf_conntrack_max=4194304
  - net.netfilter.nf_conntrack_max=4194304
  - fs.file-max=2097152
  - net.ipv4.tcp_syncookies=1
  - net.ipv4.tcp_max_syn_backlog=65535
  - net.ipv4.conf.cni0.rp_filter=0
  - net.ipv4.conf.ens18.rp_filter=0

  echo 0 > /proc/sys/net/ipv4/conf/flannel.1/rp_filter

Expected behavior:

A perfectly working cluster
Actual behavior:

Pods/services cannot interoperate while located on different nodes. One pod cannot ping other pod even within the same namespace. At the same time the service network is accessible.
Attempts to access resources via ingresses lead to 5хх errors.
Tried to flush iptables/switch to ipvs - no changes.
NodePorts works only if desired pod is located on that particular node
i.e
my-pod works on node-2, has nodeport 30087
so node-2:30087 - works, and node-1:30087 - not
Additional context / logs:

nothing really meaningful/pointing into any issue in k3s logs
Please advise me what could I also check and try? Thanks in advance.

Does this affect pods on different nodes, or even pods on the same nodes?
Have you tried switching to iptables-legacy instead of iptables-nft?

It affects pods on different nodes. Pods on the same node can connect.
Yes, I use iptables-legacy.
Regarding vxlan:
lsmod | grep vxlan
vxlan                  86016  0
ip6_udp_tunnel         16384  1 vxlan
udp_tunnel             20480  1 vxlan

I see only errors regarding unability to connect to metrics-server even with --v 5 verbosity.

Did firewalld or ufw get accidentally re-enabled as part of the upgrade? Do you have anything else on the nodes that might be blocking vxlan traffic?
What sort of hardware is this on? There have been issues with hardware checksum offload corrupting vxlan packets on vmware when used with specific kernel versions.

@brandond, thank you very much, and I am sorry for wasting your time. I've managed to solve the issue.
Found out that someone for some unclear reason enabled hypervisor-level firewall in Proxmox UI for nw devices...

Unchecked that, performed reboot - everything works perfectly now.


Question: can I update a variable in a group that is specified in yaml only.

Azure DevOps Extension you are using
https://github.com/rfennell/AzurePipelines/blob/master/Extensions/BuildUpdating/BuildVariableTask/BuildVariableTask.ps1
Where are you running it?

Azure DevOps Service (VSTS)

Version of Extension/Task
Latest public
Expected behaviour and actual behaviour
I have to manually add (in the web UI) the variable group to a pipeline definition as well as  specifying the group in my yaml.
If I remove the group in the online definition but leave the reference in the yaml the task fails to find the variable to update (other tasks can use the variable).
##[error]Cannot set variable [ProjectBuildId] as variable could not be found in the a pipeline or associated variablegroups
Steps to reproduce the problem
Add a variable group to a yaml build (set its permissions in the library).
Add the step that updates the variable and run a build.

That sounds like an API difference between the two ways of declaring the variable group. I will need to investigate. However, it might be a limitation at present

Thanks, I'll take a closer look tomorrow, it just occurred to me that we will probably want to alter this group across branches so specifying the group in the UI is an issue.

Spent a while reading about this. If I understand the docs then I don't think you can do what you have outlined.
I think the variable groups entry in the YAML is a reference, a link, to a UI defined variable group.
I am surprised that the other tasks work

Yes the variable groups are defined in the UI. But I am also having to edit the actual pipeline definition in the UI. I have to click edit pipeline (the yaml editor appears), then the three dots button and choose Triggers to get up the old style build page and go to the variables tab and associate the group with the pipeline.
I'll have a longer look tomorrow, its entirely possible I have got a permission wrong or something.

OK, that article does make special mention over authorisation - probably worth another look.
Let me know how it goes

Hi,
I have reproduced this.
https://dev.azure.com/WyrdsoftOS/PublicBuildTesting/_build/results?buildId=74&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=32f188ea-5e98-5907-ea3f-173bf74782da&l=47
And it works with the same yaml, but linking the variablegroup to the pipeline definition in the web ui.
https://dev.azure.com/WyrdsoftOS/PublicBuildTesting/_build/results?buildId=75&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=32f188ea-5e98-5907-ea3f-173bf74782da
It seems that the api call to get build definition "$($tfsUri)/$($teamproject)/_apis/build/definitions/$($buildDefID)?api-version=$apiVersion"
does not return the variable groups collection if the asociation is in the yaml only. This makes complete sense in retrospect otherwise the api call would have to go away and start parsing the yaml, which is silly.
I'm just going to have to take a different approach and update the variable group item explicitly.

Thank for looking into it and reporting back. Building up a history of issue like this is useful


SeekTime Now Handles When "seekEnabled" setting changes

It doesn't yet but hopefully will by the end of this pull request!
This is what I have so far, it's basically the same as before just refactored slightly.
I have some questions:

How do I get access to the container to listen for the settings changed event? Does it need to be a UICorePlugin to get access to this?
Where in the code does the duration value get added and updated? It feels like this should be something that is controlled here as well?

Thanks

@tjenkinson thanks so much, you always help a lot. :smile:
Some notes though:

instead of doing var self = this use arrow function:

    this.listenTo(this.mediaControl, Events.MEDIACONTROL_MOUSEMOVE_SEEKBAR, (event)  =>  {
      this.hoveringOverSeekBar = true
      this.calculateHoverPosition(event)
      this.update()
    })

avoid ;

"1. How do I get access to the container to listen for the settings changed event? Does it need to be a UICorePlugin to get access to this?"

It doesn't need to be a UICorePlugin and I think you can achieve this by listening for settings update.
this.listenTo(this.mediaControl.container, Events.CONTAINER_SETTINGSUPDATE, () => {})

"2. Where in the code does the duration value get added and updated? It feels like this should be something that is controlled here as well?"

You usually can listen to container time update or progress.
Events.CONTAINER_TIMEUPDATE
Events.CONTAINER_PROGRESS

Both cases you can see examples through the code and I feel that we also need to add more test cases for code we add.

Thanks this is the first time I've used es6 do that's useful to know I'll update it :)
I think I tried accessing 'container' on 'mediaControl' (in the comment) but it was undefined. I'll check again later.
Still not sure what the answer is to my question 2. The duration is already getting added, but I don't know where from, and was thinking that that logic, wherever it is, should maybe be here aswell?
Thanks

@tjenkinson I beg your pardon I didn't answer you. (I read fast and :hankey:)

Where in the code does the duration value get added and updated? It feels like this should be something that is controlled here as well?

It depends on the playback:

For html5_video it listens to durationchange event from video tag and then it know that it can query $videotag.duration.

For flashls it does listen to some events on flash and then it updates the duration (while you're playing a vod you have a fixed duration but with live different.

Thanks that's still not quite what I was looking for :P
I was wondering where the duration value was appended to the seek time component, because it doesn't happen inside it. I've found it now in the DVR Controls plugin: https://github.com/clappr/clappr/blob/b544caac327966a628b4c0e29c9a518e84437d23/src/plugins/dvr_controls/dvr_controls.js#L81
Wouldn't it make more sense that the SeekTime plugin is responsible for adding the duration (and keeping it updated) rather than the DvrControls plugin?
So the SeekTime plugin would contain the logic to determine if dvr is enabled (or changed) and then show or hide the duration accordingly. Then the <span data-duration></span> could also go in the https://github.com/tjenkinson/clappr/blob/seek-time-handle-settings-event/src/components/seek_time/public/seek_time.html template file.

@tjenkinson sorry once more :(
Now I could understand and I agree with you but maybe there is a reason for this component, what you think @towerz @thiagopnts @flavioribeiro

@leandromoreira @tjenkinson Actually, the DvrControls plugin was added later on the player development and we didn't revisit these plugins after that.
The reason behind DvrControls handling the duration value is that SeekTime is not actually a plugin, it's a part of MediaControl that we separated from the main file to keep it better organized. We wanted to make available for plugins to alter the appearance/structure of the media controls, and this manipulation is one of the examples we wanted to show.
In fact, we didn't want to make MediaControl know what DVR is. The plugin for handling DVR should be the only one to know what dvr is and change the controls accordingly.
@tjenkinson's comment pointed out a failure in that. We should either remove DVR state handling (CONTAINER_PLAYBACKDVRSTATECHANGED event) from MediaControl or we follow his suggestion to handle duration directly in SeekTime. I'm opposed to the latter because we would need to add VoD/live/DVR checks to SeekTime, instead of giving it a single responsibility of displaying the current time of the hovering position on the seek bar.

Oh yeh I didn't realise SeekTime wasn't in the plugins folder, just assumed it was for some reason. If SeekTime is basically part of MediaControl maybe it could live in the MediaControl folder?
It looks to me like the CONTAINER_PLAYBACKDVRSTATECHANGED and CONTAINER_SETTINGSUPDATE are triggering the entire MediaControl component to be completely rerendered. Is this right? If it is then surely there's no reason to listen for a settings change event in SeekTime because it would get rerendered whenever this happens anyway?

@tjenkinson due to a limitation in our build process, SeekTime could not be included in the same folder as MediaControl. There were conflicts when loading html/css templates. Now that we use webpack for managing these assets, we don't have this limitation anymore.
About the events, you are right. Both events cause MediaControl to re-render, so there's no need to listen for a settings change event.

I have removed the comment with that event in now. Also because it is a separate class it looked to me that the events would not get unregistered if the MediaControl component was removed. My latest commit should pass a remove() call from MediaControl through to SeekTime.
Also now the update() method will always be called on a render() meaning if a container setting does change, ie DVR enabling, it should react.
In MediaControl there is a destroy() method. Where is this called from? I'm a bit confused as to where this fits in with the system. Also shouldn't the stuff it does also happen if the user was to call remove()?
Sorry about all the questions :P

;) no problem @tjenkinson you always help a lot :smile:

In MediaControl there is a destroy() method. Where is this called from? I'm a bit confused as to where this fits in with the system. Also shouldn't the stuff it does also happen if the user was to call remove()?

I think the Core is responsible for the life cycle of MediaControl (alongside with Container and all the plugins which also should have destroy method), therefore when you destroy the core it'll destroy also all the plugins and the media control.

Also shouldn't the stuff it does also happen if the user was to call remove()?

I think the API for plugins is the destroy method, although I see that UIObject employs the remove API instead... anyway I think @towerz @thiagopnts @flavioribeiro can help us out here, in these two questions.

In MediaControl there is a destroy() method. Where is this called from? I'm a bit confused as to where this fits in with the system. Also shouldn't the stuff it does also happen if the user was to call remove()?
Also shouldn't the stuff it does also happen if the user was to call remove()?

Ok in which I case to me it looks like this means none of the event handlers are unregistered as remove() appears to do that with the stopListening() call.

@tjenkinson yeah, you're right but since I'm kinda new I want the others to check if we are correct on this too, then we can fix this possible bug.
While the super method remove does that (I mean it calls stopListening and undelegatingEvents, which stops listening all the events) that's why I suppose we might need to call within mediaControl#destroy
  remove() {
    this.$el.remove()
    this.stopListening()
    this.undelegateEvents()
    return this
  }

@leandromoreira @tjenkinson The destroy() api was created to remove event handlers, release resources and remove the element from its parent.
This was made before creating the remove() method for the UIObject, which should replace destroy as the method responsible for freeing resources and event handlers from the object, thus removing the responsibility from the plugin creators to take care of this.
Apparently, the plugin base classes have been changed to call remove from their destroy methods, but some UIObjects have not been changed to do it, so it's actually a bug.
About the other two questions:

The responsible for the lifecycle of MediaControl is indeed the Core object, @leandromoreira is correct in that.
The user should not call remove at all, since it's not exposed in the Player API.

To remove doubts about this, I think we should remove the destroy methods, using only remove instead.

Great in which case I think this pull request is finished unless you have any issues :)

I'm cool with that, once again thanks so much @tjenkinson :clap: :clap: :clap:

Thanks again, @tjenkinson.


Code doesn't find 'stat.txt',' my_train.txt', or 'my_test.txt' files.

Hi,
I tried to run this code for the test set directly using the provided checkpoints using the command :
python main.py --ckpt_path OGM-GE_CVPR2022/ckpt/AVE_concat/archive/data --dataset AVE --alpha 0.3
I also made some changes to the main.py code like setting tensorboard requirement to False
I also changed the formats from .txt. to .csv for CREMAD in dataset.py and then ran this for CREMAD where it gave the error that ValueError: num_samples should be a positive integer value, but got num_samples=0
Please help.

Hi,
I tried to run this code for the test set directly using the provided checkpoints using the command : python main.py --ckpt_path OGM-GE_CVPR2022/ckpt/AVE_concat/archive/data --dataset AVE --alpha 0.3
I also made some changes to the main.py code like setting tensorboard requirement to False
I also changed the formats from .txt. to .csv for CREMAD in dataset.py and then ran this for CREMAD where it gave the error that ValueError: num_samples should be a positive integer value, but got num_samples=0
Please help.

Hello,
It's because the dataset.py is prepared for 'AVE' task by default.  For CREMAD the dataset should be slightly different,
here we provide a demo dataset.py file for CREMAD that you can use as a reference.
https://zenodo.org/record/6597205
Best,
Xiaokang,


 This could be fixed with a setting that allows us to select
a certain amount of pixels as "blank space" on the right side of the keyboard.

What steps will reproduce the problem?
1. Install hackerskeyboard on a kindle fire
2. Tilt device into landscape mode

This happens in english and greek. It probably happens in all languages, it's
amazon's issue, not yours... It'd still be great if you could fix it though.

My version is 1.33.1332 d27b5144b8e2 2012-07-03

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 7 Mar 2013 at 12:59

The same thing happens on Galaxy Note 8 (stock software).


♻(payment) rename ProformaInvoice model

Purpose
In previous commit fc0d94eecb6c5cbaa366402affcabfe4c618ec10  we had renamed the model from Invoice to ProformaInvoice thinking invoices from Joanie from an accounting point of view were not real ones. As invoices are only generated after payment, they cannot be a proformat as this kind of document is not related to payment. So to simplify, we revert and call our model back Invoice.
Proposal

rename proformat to invoice

@carofun It appears you exec a case sensitive search & replace. There is remaining some Pro forma.


Decimal separator for locales where decimal point is a comma

Unfortunately, the "amount" entry field only allows a dot ( . ) as decimal separator, not a comma ( , ). This is not a problem on desktop computers with a keyboard, however on iPhone with german keyboard layout, I am presented with a keyboard containing 0-9 and the comma only (due to the input field type I guess). I have no possibility to enter a dot instead of a comma, and therefore cannot add an expense. I hope you're able to fix that, that would be awesome!

Stilly trying to reproduce. Getting more information about the bug.

I can reproduce this on my phone, and am available to help out with testing if you wish
I tried looking into this myself, but to no avail 😅