Feature/2456

@kwin - any idea why the ui.config filevault maven plugin goals are not binding to the default maven phases? It doesn't look like filevault is being invoked at all on mvn package for ui.config.

The new modules have the wrong parent version: https://github.com/davidjgonzalez/acs-aem-commons/blob/7a3cf6c49152156156b3d89c9560db6a64391041/ui.config/pom.xml#L24 and https://github.com/davidjgonzalez/acs-aem-commons/blob/7a3cf6c49152156156b3d89c9560db6a64391041/ui.apps.structure/pom.xml#L10.
Then you load both com.day.vault:content-package-maven-plugin:0.0.24 and org.apache.jackrabbit:filevault-package-maven-plugin. Both provide lifecycle configuration for package content-package. You have to update the former to version 1.0.2 (compare with https://jackrabbit.apache.org/filevault-package-maven-plugin/migrating.html) to no longer take precedence for the packaging content-package.
Also you must make sure that you no longe copy stuff around with the resource plugin as the filevault-package-maven-plugin uses the src directories (in https://github.com/davidjgonzalez/acs-aem-commons/blob/7a3cf6c49152156156b3d89c9560db6a64391041/ui.apps/pom.xml#L22).
Also the configuration package is supposed to be of packageType container!

INFO] --- filevault-package-maven-plugin:1.1.4:validate-package (default-validate-package) @ acs-aem-commons-ui.content ---
[WARNING] Using package id in dependencies is deprecated. Use Maven coordinates (given via 'groupId' and 'artifactId') instead of 'adobe/consulting:acs-aem-commons-ui.apps'!
[INFO] Start validating package '/Users/ira/Code/acs-aem-commons/ui.content/target/acs-aem-commons-ui.content-4.11.1-SNAPSHOT.zip'...
[INFO] Trying to resolve dependency 'adobe/consulting:acs-aem-commons-ui.apps:4.11.1-SNAPSHOT' from Maven repository
[WARNING] Could not resolve dependency from any Maven Repository for dependency adobe/consulting:acs-aem-commons-ui.apps:4.11.1-SNAPSHOT
[INFO] Register node types from tccl:aem.cnd
[INFO] Using 9 validators for package of type CONTENT: jackrabbit-filter (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedFilterValidator), jackrabbit-properties (org.apache.jackrabbit.vault.validation.spi.impl.AdvancedPropertiesValidator), jackrabbit-docviewparser (org.apache.jackrabbit.vault.validation.spi.impl.DocumentViewParserValidator), jackrabbit-dependencies (org.apache.jackrabbit.vault.validation.spi.impl.DependencyValidator), jackrabbit-emptyelements (org.apache.jackrabbit.vault.validation.spi.impl.EmptyElementsValidator), jackrabbit-mergelimitations (org.apache.jackrabbit.vault.validation.spi.impl.MergeLimitationsValidator), jackrabbit-oakindex (org.apache.jackrabbit.vault.validation.spi.impl.OakIndexDefinitionValidator), jackrabbit-packagetype (org.apache.jackrabbit.vault.validation.spi.impl.PackageTypeValidator), jackrabbit-nodetypes (org.apache.jackrabbit.vault.validation.spi.impl.nodetype.NodeTypeValidator)
[WARNING] ValidationViolation: "jackrabbit-dependencies: Dependency 'adobe/consulting:acs-aem-commons-ui.apps:4.11.1-SNAPSHOT'was not successfully resolved and can therefore not be used for analysis.", filePath=META-INF/vault/properties.xml
[ERROR] ValidationViolation: "jackrabbit-filter: cvc-complex-type.3.2.2: Attribute 'mode' is not allowed to appear in element 'include'.", filePath=META-INF/vault/filter.xml, line=6, column=74
[ERROR] ValidationViolation: "jackrabbit-filter: cvc-complex-type.3.2.2: Attribute 'mode' is not allowed to appear in element 'include'.", filePath=META-INF/vault/filter.xml, line=20, column=89
[ERROR] ValidationViolation: "jackrabbit-filter: cvc-complex-type.3.2.2: Attribute 'mode' is not allowed to appear in element 'include'.", filePath=META-INF/vault/filter.xml, line=21, column=101
[ERROR] ValidationViolation: "jackrabbit-filter: cvc-complex-type.3.2.2: Attribute 'mode' is not allowed to appear in element 'include'.", filePath=META-INF/vault/filter.xml, line=42, column=72
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/conf' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/conf/acs-commons' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/content/dam/rep:policy(' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/content/rep:policy(' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/clientlibs' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/cloudservices' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/dam/video' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/designs' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/notification' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/workflow/instances' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/etc/workflow/packages' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/home/groups' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/home/users' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/home/users/system' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[WARNING] ValidationViolation: "jackrabbit-filter: Filter root's ancestor '/oak:index' is not covered by any of the specified dependencies nor a valid root.", filePath=META-INF/vault/filter.xml
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/dam/rep:policy/allow' is not contained in any of the filter rules", filePath=jcr_root/content/dam/_rep_policy.xml, nodePath=/content/dam/rep:policy/allow, line=7, column=80
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{}allow [rep:GrantACE]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/content/dam/_rep_policy.xml, nodePath=/content/dam/rep:policy/allow, line=7, column=80
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/dam/rep:policy' is not contained in any of the filter rules", filePath=jcr_root/content/dam/_rep_policy.xml
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy/allow' is not contained in any of the filter rules", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow, line=7, column=48
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{}allow [rep:GrantACE]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow, line=7, column=48
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy/allow0' is not contained in any of the filter rules", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow0, line=11, column=48
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{}allow0 [rep:GrantACE]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow0, line=11, column=48
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy/allow1' is not contained in any of the filter rules", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow1, line=15, column=83
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{}allow1 [rep:GrantACE]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow1, line=15, column=83
[WARNING] ValidationViolation: "jackrabbit-nodetypes: Error while retrieving property '{internal}privileges': crx: is not a registered namespace prefix.. Skip validation of nodes with that type/name", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow1, line=15, column=83
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy/allow2' is not contained in any of the filter rules", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow2, line=19, column=113
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{}allow2 [rep:GrantACE]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow2, line=19, column=113
[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/rep:policy/allow1' is not contained in any of the filter rules", filePath=jcr_root/content/_rep_policy.xml
[ERROR] ValidationViolation: "jackrabbit-filter: Ancestor node (/etc/acs-commons/qr-code) of Node '/etc/acs-commons/qr-code/jcr:content' which is contained in a filter include element is not included!", filePath=jcr_root/etc/acs-commons/qr-code/.content.xml, nodePath=/etc/acs-commons/qr-code/jcr:content, line=7, column=71
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/acs-commons/qr-code/.content.xml, nodePath=/etc/acs-commons/qr-code/jcr:content, line=7, column=71
[ERROR] ValidationViolation: "jackrabbit-mergelimitations: Non-empty Node '/etc/acs-commons/qr-code/jcr:content/config' is supposed to be imported with mode 'merge' but it is not the aggregator's root node. This is currently not supported by FileVault (https://issues.apache.org/jira/browse/JCRVLT-255).", filePath=jcr_root/etc/acs-commons/qr-code/.content.xml, nodePath=/etc/acs-commons/qr-code/jcr:content/config, line=11, column=82
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/acs-commons/qr-code' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/acs-commons/qr-code/.content.xml
[ERROR] ValidationViolation: "jackrabbit-filter: Ancestor node (/etc/acs-commons/instant-package) of Node '/etc/acs-commons/instant-package/jcr:content' which is contained in a filter include element is not included!", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent (mix:versionable)]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[512d8079-4cdc-49fe-ae92-eba91859faf1], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[cq:PageContent, mix:versionable]': Property is protected!", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}isCheckedOut, values=[true], isMulti=false, type=6, isReferenceProperty=false]' is not allowed in node with types '[cq:PageContent, mix:versionable]': Property is protected!", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}baseVersion' missing in node with types [cq:PageContent, mix:versionable]", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}versionHistory' missing in node with types [cq:PageContent, mix:versionable]", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}predecessors' missing in node with types [cq:PageContent, mix:versionable]", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79
[ERROR] ValidationViolation: "jackrabbit-mergelimitations: Non-empty Node '/etc/acs-commons/instant-package/jcr:content/config' is supposed to be imported with mode 'merge' but it is not the aggregator's root node. This is currently not supported by FileVault (https://issues.apache.org/jira/browse/JCRVLT-255).", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content/config, line=16, column=39
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/cloudservices' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/cloudservices/.content.xml
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/cloudservices/sharethis/.content.xml, nodePath=/etc/cloudservices/sharethis/jcr:content, line=16, column=88
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/cloudservices/sharethis' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/cloudservices/sharethis/.content.xml
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/cloudservices/typekit/.content.xml, nodePath=/etc/cloudservices/typekit/jcr:content, line=16, column=86
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/cloudservices/dtm/.content.xml, nodePath=/etc/cloudservices/dtm/jcr:content, line=18, column=82
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/cloudservices/dtm' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/cloudservices/dtm/.content.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/dam' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/dam/.content.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/etc/dam/video' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/etc/dam/video/.content.xml
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}isCheckedOut, values=[true], isMulti=false, type=6, isReferenceProperty=false]' is not allowed in node with types '[mix:versionable, nt:unstructured]': Property is protected!", filePath=jcr_root/etc/dam/video/flacmono/.content.xml, nodePath=/etc/dam/video/flacmono/jcr:content, line=18, column=32
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}predecessors' missing in node with types [mix:versionable, nt:unstructured]", filePath=jcr_root/etc/dam/video/flacmono/.content.xml, nodePath=/etc/dam/video/flacmono/jcr:content, line=18, column=32
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}baseVersion' missing in node with types [mix:versionable, nt:unstructured]", filePath=jcr_root/etc/dam/video/flacmono/.content.xml, nodePath=/etc/dam/video/flacmono/jcr:content, line=18, column=32
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}versionHistory' missing in node with types [mix:versionable, nt:unstructured]", filePath=jcr_root/etc/dam/video/flacmono/.content.xml, nodePath=/etc/dam/video/flacmono/jcr:content, line=18, column=32
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/home/groups' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/home/groups/.content.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/home/users' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/home/users/.content.xml
[INFO] ValidationViolation: "jackrabbit-filter: Ancestor node '/home/users/system' is not covered by any of the filter rules. Preferably depend on a package that provides this node or include it in the filter rules!", filePath=jcr_root/home/users/system/.content.xml
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-bulk-workflow-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/bulk-workflow/.content.xml, nodePath=/home/users/system/acs-commons/bulk-workflow, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-bulk-workflow-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/bulk-workflow/.content.xml, nodePath=/home/users/system/acs-commons/bulk-workflow, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[b03204a7-0df9-30eb-85d9-513054ee5443], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/bulk-workflow/.content.xml, nodePath=/home/users/system/acs-commons/bulk-workflow, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-shared-component-props-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/shared-component-props-service/.content.xml, nodePath=/home/users/system/acs-commons/shared-component-props-service, line=6, column=69
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-shared-component-props-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/shared-component-props-service/.content.xml, nodePath=/home/users/system/acs-commons/shared-component-props-service, line=6, column=69
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[de08ffa2-0d09-36a5-9a11-536e92940515], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/shared-component-props-service/.content.xml, nodePath=/home/users/system/acs-commons/shared-component-props-service, line=6, column=69
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-package-replication-status-event-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/package-replication-event-service/.content.xml, nodePath=/home/users/system/acs-commons/package-replication-event-service, line=6, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-package-replication-status-event-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/package-replication-event-service/.content.xml, nodePath=/home/users/system/acs-commons/package-replication-event-service, line=6, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[6a14e71d-f983-35e6-8353-cdfa7c15284d], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/package-replication-event-service/.content.xml, nodePath=/home/users/system/acs-commons/package-replication-event-service, line=6, column=79
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-ensure-service-user-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-service-user/.content.xml, nodePath=/home/users/system/acs-commons/ensure-service-user, line=6, column=66
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-ensure-service-user-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-service-user/.content.xml, nodePath=/home/users/system/acs-commons/ensure-service-user, line=6, column=66
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[631f75c7-4e6b-3186-82c4-2b5df96de1d8], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-service-user/.content.xml, nodePath=/home/users/system/acs-commons/ensure-service-user, line=6, column=66
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-review-task-asset-mover-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/review-task-asset-mover-service/.content.xml, nodePath=/home/users/system/acs-commons/review-task-asset-mover-service, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-review-task-asset-mover-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/review-task-asset-mover-service/.content.xml, nodePath=/home/users/system/acs-commons/review-task-asset-mover-service, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[fe2f3e40-e46f-3af2-9668-62072d41dff5], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/review-task-asset-mover-service/.content.xml, nodePath=/home/users/system/acs-commons/review-task-asset-mover-service, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-twitter-updater-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/twitter-updater/.content.xml, nodePath=/home/users/system/acs-commons/twitter-updater, line=6, column=62
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-twitter-updater-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/twitter-updater/.content.xml, nodePath=/home/users/system/acs-commons/twitter-updater, line=6, column=62
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[71bf2fa4-4e65-3a40-be1f-008699379c61], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/twitter-updater/.content.xml, nodePath=/home/users/system/acs-commons/twitter-updater, line=6, column=62
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-remote-assets-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/remote-assets-service/.content.xml, nodePath=/home/users/system/acs-commons/remote-assets-service, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-remote-assets-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/remote-assets-service/.content.xml, nodePath=/home/users/system/acs-commons/remote-assets-service, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[a1544aa0-90e1-3719-9473-674376d67e91], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/remote-assets-service/.content.xml, nodePath=/home/users/system/acs-commons/remote-assets-service, line=6, column=60
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-form-helper-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/form-helper-service/.content.xml, nodePath=/home/users/system/acs-commons/form-helper-service, line=6, column=58
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-form-helper-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/form-helper-service/.content.xml, nodePath=/home/users/system/acs-commons/form-helper-service, line=6, column=58
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[78dade7c-4e5d-3b4a-8e9a-e33dbd10d6ab], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/form-helper-service/.content.xml, nodePath=/home/users/system/acs-commons/form-helper-service, line=6, column=58
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-ensure-oak-index-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-oak-index-service/.content.xml, nodePath=/home/users/system/acs-commons/ensure-oak-index-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-ensure-oak-index-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-oak-index-service/.content.xml, nodePath=/home/users/system/acs-commons/ensure-oak-index-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[006878ae-9772-3f3f-89b3-3a9cbf701988], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/ensure-oak-index-service/.content.xml, nodePath=/home/users/system/acs-commons/ensure-oak-index-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-email-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/email-service/.content.xml, nodePath=/home/users/system/acs-commons/email-service, line=6, column=52
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-email-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/email-service/.content.xml, nodePath=/home/users/system/acs-commons/email-service, line=6, column=52
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[42e38ac7-6920-3f53-beaf-53ebc4842d24], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/email-service/.content.xml, nodePath=/home/users/system/acs-commons/email-service, line=6, column=52
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-dispatcher-flush-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/dispatcher-flush-service/.content.xml, nodePath=/home/users/system/acs-commons/dispatcher-flush-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-dispatcher-flush-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/dispatcher-flush-service/.content.xml, nodePath=/home/users/system/acs-commons/dispatcher-flush-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[0cdb16c9-534e-3f02-b307-55083160bb30], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/dispatcher-flush-service/.content.xml, nodePath=/home/users/system/acs-commons/dispatcher-flush-service, line=6, column=63
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-component-error-handler-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/component-error-handler/.content.xml, nodePath=/home/users/system/acs-commons/component-error-handler, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-component-error-handler-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/component-error-handler/.content.xml, nodePath=/home/users/system/acs-commons/component-error-handler, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[017fba56-806e-3919-86e8-8733aff8f6d3], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/component-error-handler/.content.xml, nodePath=/home/users/system/acs-commons/component-error-handler, line=6, column=70
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-error-page-handler-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/error-page-handler/.content.xml, nodePath=/home/users/system/acs-commons/error-page-handler, line=6, column=65
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-error-page-handler-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/error-page-handler/.content.xml, nodePath=/home/users/system/acs-commons/error-page-handler, line=6, column=65
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[80101d3e-6fb1-378e-a4f5-c13a94f795a6], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/error-page-handler/.content.xml, nodePath=/home/users/system/acs-commons/error-page-handler, line=6, column=65
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-system-notifications-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/system-notifications/.content.xml, nodePath=/home/users/system/acs-commons/system-notifications, line=6, column=67
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}principalName, values=[acs-commons-system-notifications-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/system-notifications/.content.xml, nodePath=/home/users/system/acs-commons/system-notifications, line=6, column=67
[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={http://www.jcp.org/jcr/1.0}uuid, values=[8c1283dc-f7f0-3084-909b-5bc052b01cd0], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/system-notifications/.content.xml, nodePath=/home/users/system/acs-commons/system-notifications, line=6, column=67
[INFO] ValidationViolation: "jackrabbit-filter: Found orphaned filter entries: entry with root '/conf/rep:policy', includes [regex: /conf/acs-commons/reports/jcr:content] below root '/conf/acs-commons/reports', entry with root '/content/dam/rep:policy(/.*)?', entry with root '/content/rep:policy(/.*)?', includes [regex: /etc/acs-commons/jcr:content, regex: /etc/acs-commons/bulk-workflow-manager, regex: /etc/acs-commons/dispatcher-flush, regex: /etc/acs-commons/lists/dynamic-deck-query-list, regex: /etc/acs-commons/lists/sharethis-services, regex: /etc/acs-commons/lists/font-awesome-icons, regex: /etc/acs-commons/lists/report-parameter-components, regex: /etc/acs-commons/notifications, regex: /etc/acs-commons/redirect-maps, regex: /etc/acs-commons/reports(.*)?, regex: /etc/acs-commons/audit-log-search, regex: /etc/acs-commons/jcr-compare, regex: /etc/acs-commons/manage-controlled-processes, regex: /etc/acs-commons/oak-index-manager, regex: /etc/acs-commons/page-compare, regex: /etc/acs-commons/reports, regex: /etc/acs-commons/version-compare, regex: /etc/acs-commons/version-replicator, regex: /etc/acs-commons/workflow-remover] below root '/etc/acs-commons', entry with root '/etc/clientlibs/acs-commons', entry with root '/etc/packages/rep:policy'"
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for ACS AEM Commons - Reactor Project 4.11.1-SNAPSHOT:
[INFO]
[INFO] ACS AEM Commons - Reactor Project .................. SUCCESS [  0.327 s]
[INFO] ACS AEM Commons - Bundle (Core) .................... SUCCESS [ 36.515 s]
[INFO] ACS AEM Commons - Oakpal Checks .................... SUCCESS [  3.143 s]
[INFO] ACS AEM Commons - UI.Apps Structure ................ SUCCESS [  0.714 s]
[INFO] ACS AEM Commons - UI.Apps .......................... SUCCESS [ 16.328 s]
[INFO] ACS AEM Commons - UI.Config ........................ SUCCESS [  0.192 s]
[INFO] ACS AEM Commons - UI.Content ....................... FAILURE [  0.710 s]
[INFO] ACS AEM Commons - Content (All) .................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@kwin so i moved over to filevault plugin and getting tons of violations, wanted to pick you brain on best/easiest way to fix some of these :)

I keep seeing issues where nt:unstructured nodes are not allowed under nt:folders (this is when we filter in under "undeclared structured" ... I don't want to make this all sling:OrderedFolders or something ...  This initially popped up as a problem in /apps when we inject some nodes into a cq:Page under /libs to add a button.

What's the story with service users? It look like these can't? be declared as JCR nodes anymore? Obviously, repoInit is the right way to go, but i was hoping to avoid doing all that work right now :)

@davidjgonzalez Let me try to comment on the individual issues

[WARNING] ValidationViolation: "jackrabbit-dependencies: Dependency 'adobe/consulting:acs-aem-commons-ui.apps:4.11.1-SNAPSHOT'was not successfully resolved and can therefore not be used for analysis.", filePath=META-INF/vault/properties.xml

Please migrate package dependencies to using Maven coordinates, only that way they can be used for validation purposes as well (https://jackrabbit.apache.org/filevault-package-maven-plugin/generate-metadata-mojo.html#dependencies)

[ERROR] ValidationViolation: "jackrabbit-filter: cvc-complex-type.3.2.2: Attribute 'mode' is not allowed to appear in element 'include'.", filePath=META-INF/vault/filter.xml, line=6, column=74

The filter.xml is plain wrong. Filters don't allow attribute mode on element include (https://jackrabbit.apache.org/filevault/filter.html)

[ERROR] ValidationViolation: "jackrabbit-filter: Node '/content/dam/rep:policy/allow' is not contained in any of the filter rules", filePath=jcr_root/content/dam/_rep_policy.xml, nodePath=/content/dam/rep:policy/allow, line=7, column=80

Even ACEs must be included in filter rules

[WARNING] ValidationViolation: "jackrabbit-nodetypes: Error while retrieving property '{internal}privileges': crx: is not a registered namespace prefix.. Skip validation of nodes with that type/name", filePath=jcr_root/content/_rep_policy.xml, nodePath=/content/rep:policy/allow1, line=15, column=83

Please use the newest CND from https://github.com/Netcentric/aem-nodetypes

[ERROR] ValidationViolation: "jackrabbit-nodetypes: Mandatory property '{http://www.jcp.org/jcr/1.0}baseVersion' missing in node with types [cq:PageContent, mix:versionable]", filePath=jcr_root/etc/acs-commons/instant-package/.content.xml, nodePath=/etc/acs-commons/instant-package/jcr:content, line=12, column=79

False positive, fixed in upcoming version https://issues.apache.org/jira/browse/JCRVLT-485

[ERROR] ValidationViolation: "jackrabbit-nodetypes: Property 'DocViewProperty [name={internal}authorizableId, values=[acs-commons-bulk-workflow-service], isMulti=false, type=0, isReferenceProperty=false]' is not allowed in node with types '[rep:SystemUser]': Property is protected!", filePath=jcr_root/home/users/system/acs-commons/bulk-workflow/.content.xml, nodePath=/home/users/system/acs-commons/bulk-workflow, line=6, column=60

That seems like a false positive as well. Actually all authorizables should be ignored (https://github.com/apache/jackrabbit-filevault/blob/0fa305d5b0f6dec43e181db3fabeb32603d69501/vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/nodetype/JcrNodeTypeMetaDataImpl.java#L161). I am gonna investigate.

[ERROR] ValidationViolation: "jackrabbit-nodetypes: Node '{http://www.jcp.org/jcr/1.0}content [cq:PageContent]' is not allowed as child of not contained node with potential default types '[nt:folder]': Could not find matching child node definition in parent's node type", filePath=jcr_root/etc/acs-commons/qr-code/.content.xml, nodePath=/etc/acs-commons/qr-code/jcr:content, line=7, column=71

Don't rely on the automatic handling of ancestor node types (http://jackrabbit.apache.org/filevault/filter.html#Uncovered_ancestor_nodes). This might easily lead to errors in case the ancestor node is already there with the wrong type. Therefore whenever you want to add a non-simple node (=nt:folder) please make sure that the parent is created explicitly with an appropriate node type (compare also with https://github.com/adobe/aem-guides-wknd/issues/174#issuecomment-734192205)

@joerghoh do you happen to know what version/SP of AEM 6.4 and 6.5 have Sling's

o.a.s.repoinit.parser 1.6.2
o.a.s.jcr.repoinit 1.1.24

Id like to move some of the /etc/acs-commons/ to  repoinit, however setting properties was only introduced later (in above versions). TBH I'm not sure the best way to look up what SP introduced these (or if they were ever introduced)

@joerghoh do you happen to know what version/SP of AEM 6.4 and 6.5 have Sling's

o.a.s.repoinit.parser 1.6.2
o.a.s.jcr.repoinit 1.1.24

Id like to move some of the /etc/acs-commons/ to  repoinit, however setting properties was only introduced later (in above versions). TBH I'm not sure the best way to look up what SP introduced these (or if they were ever introduced)

@adamcin im getting some Oak PAL acl verification errors on this build since part of ti included a move of the ACLs to repo init scripts.
[INFO] --- oakpal-maven-plugin:2.1.0:verify (oakpal-verify) @ acs-aem-commons-ui.apps ---
[INFO] OakPAL Check Reports
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR] ** Violations were reported at or above severity: MAJOR **

Is there a way for OakPAL to validate the repo init script ACL definition? Or should I just remove these OakPAL checks?

@adamcin im getting some Oak PAL acl verification errors on this build since part of ti included a move of the ACLs to repo init scripts.
[INFO] --- oakpal-maven-plugin:2.1.0:verify (oakpal-verify) @ acs-aem-commons-ui.apps ---
[INFO] OakPAL Check Reports
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[INFO]   verify-acls-on-apps
[ERROR]    +- <MAJOR> expected: principal:acs-commons-ensure-oak-index-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-component-error-handler-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR]    +- <MAJOR> expected: principal:acs-commons-shared-component-props-service ace:type=allow;path=/apps;privileges=jcr:read [acs-aem-commons-ui.apps-4.11.1-SNAPSHOT.zip]
[ERROR] ** Violations were reported at or above severity: MAJOR **

Is there a way for OakPAL to validate the repo init script ACL definition? Or should I just remove these OakPAL checks?


Inverted condition in PMKAlertController

Hello,
The condition seems flipped in :
https://github.com/mxcl/PromiseKit/blob/master/Categories/UIKit/PMKAlertController.swift#L43

Looks correct to me.

Seems it was fixed by this commit : https://github.com/mxcl/PromiseKit/commit/cc91705174a4f331b24ebb22fcd12f03f16776e3


Made it possible to add objects to tables + other improvements

Solves #5. For all the changes see the commit messages.

Amazing! :sparkles:


Backups now including media

I have been using the addon for a year and just noticed that the media folder is now included in daily backups.
I checked the settings and Exclude media folder is still on and File Sync Paths is still set to: /media/**/*.*
These settings haven't changed in months.
Going back through the backups, it looks like it started on Jan 22 when the backup size went from approx. 300MB to 4GB and has stayed up there ever since.
In the /config folder the media directory is empty. The FileSync directory has a media sub-directory with my Frigate recordings under that.

If I open the backup file it shows:

The backups are working otherwise and sent to OneDrive, however they are huge.
Don't know if this is related, but in the logs, there are many warnings, but the backups look fine.
01/29/2024 22:08:36 [33] Info: Reached Max Online Backups (10)
01/29/2024 22:08:36 [33] Info: Found 1 backups to delete from OneDrive.
01/29/2024 22:08:36 [33] Info: Deleting item: ha_backup_2024-01-21-14-02..tar
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : www
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:08:37 [20] Warning: Unrecognized file found in backup folder : www
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : www
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : www
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:13:36 [14] Warning: Unrecognized file found in backup folder : www
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : blueprints
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : custom_components
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : deps
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : media
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : packages
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : themes
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : tts
01/29/2024 22:13:37 [27] Warning: Unrecognized file found in backup folder : www

Let me know if I can get you any more info to track this down.
Thanks

Something is not right there.
First - Notice the Media folder in your backup is 0 bytes. It is not the cause of the large backup size. The cause is the "FileSync" folder that is part of your Home Assistant backup. What is the 'FileSync' folder you have under your Configuration dir ?
Second - Those warnings should not happen - it means these files exist in the backup folder in OneDrive. Have you manually extracted / moved files there ?

I did not do anything earlier this month except maybe a HA upgrade. The Frigate addon is the only thing that stores media. I have not changed that setup or upgraded the addon in months.
I did not create the FileSync folder. I just noticed it is there. I thought maybe this plugin created it given the name.
I have not manually done anything with the backups. No restore, extraction, or manual deletions.
I searched for the word 'FileSync' in the config folder and no instances were found.

I deleted the FileSync directory in /config.
Frigate stores its media in /media not in /config/media so that is why it is 0 bytes.
I also noticed that the files and directories in the log were in OneDrive. I deleted them as well.
I triggered a new backup and it is back to 350MB and no more warnings. I have no idea what happened. It almost looks like the FileSync directory was dragged/dropped into /config by accident since it was not updated in over a week.
Thanks for getting back to me on this. I will close and if anything happens again, I will reopen.


[PE-D][Tester D] Command Mismatch between UG and App: 'find !mp/YYYY-MM' vs "find !m/YYYY-MM"

The user guide specified that to find contacts with months not paid, a user should input:
find !mp/YYYY-MM
An error message is displayed with a suggestion to use 'find !m/YYYY-MM' instead.

Labels: severity.Medium type.DocumentationBug
original: lutfir-cpu/ped#6

Resolved


Feature request: Windows installer for kick-off-koa

I feel a bit weird about npm -g installing Koa as I don't like making things globally available as coding packages  when they are more coding tutorial programs...

I'm sure our other Junior Dev could do that, in between writing silly blog posts (@clown-fox !!)

@GranularDetective I tried the npm -g installation method and it doesn't work for me currently. My priority on this will be to get it working at all on my system before starting to worry about things like this. Also, it takes me quite a long time to put a proper site together and we'd need to think about it properly before taking time away from our main project, unless putting together an installer or interactive tutorial site would help us with our project, which it might.
Either way, @thepurplerabbits isn't around to ask at the moment, so I'm saying nay for the moment. But I will work on getting the tutorial working at all on my system.
The 'build failing' icon might have been a clue for you....


NTRs: looking for ECO classes for technique or assay used to generate expression data from single-cells

this issue is related to #186
Now we have then
ECO:0001560 single-cell RNA-sequencing evidence
but
in the annotation process of expression data from single-cell dataset, we aim to make distinction between cell type identified 'a priori', (ex. by FACS isolation), and cell type defined 'a posteriori' by clustering of the results, and we (maybe) need a larger panel of ECO classes for technique or assay used to generate the evidence of 'a priori' defined cell-type, I mean, the cell-type that the authors isolated to perform scRNA-sequencing:

cells isolated (and maybe identified) by size at a specific developmental time, from a dissected embryo (cf PMID:27554860)
or simply, cells isolated by any physical technique of dissociation, but from a defined tissue, and then broadly defined by the authors as, for example, 'hepatocytes'

(see WP: 'Many single-cell analysis techniques require the isolation of individual cells. Methods currently used for single cell isolation include: serial dilution, micromanipulation, laser capture microdissection, FACS, microfluidics, Dielectrophoretic digital sorting, manual picking, enzymatic digestion, and Raman tweezers')
Any help here will be greatly appreciated.
Anne Niknejad
curator for Bgee (bgee.org)

Hi @ANiknejad,
I am bringing this ticket up for discussion at the next ECO meeting.
James

Hi @ANiknejad,
Apologies for the tardy reply.
Can I assume that the assertion that you wish to make is that "This is cell type X based on evidence Y?"  That is, is the assertion you wish to make the identification of a certain cell type based on a type of evidence?
We can create evidence terms that assert cell type X based on Y evidence (such as 'FACS evidence'), and we can capture types of technologies (such as '10X single-cell RNA-sequencing evidence' or 'SmartSeq single-cell RNA-sequencing evidence'.) However, we would not want to make terms that combined steps such as ''10X single-cell RNA-sequencing evidence derived from cells sorted by FACS'. That would be trying to encode a protocol into a term name. One could imagine also then capturing things like if the source of the cells was cell culture or fresh tissue - this becomes unmanageable. If you want to capture protocols in an ontological way, this falls under the purview of OBI. For annotation purposes, I suggest annotating with the ECO term that represents the primary piece of evidence that led to the conclusion.
I hope this helps to explain the scope of what we can provide. Happy to discuss this further as well. If you have a specific set of evidence terms that you would like to add to ECO, I am more than happy to work with you to make this possible.  To speed the process along, I would ask for your help in providing a list of terms, definitions, and possible papers that can be used as database cross references.
Thank you.
James

Hi @ANiknejad,
Just following up on this and wondering if there is anything further I can do.
James

Hi James, I am very sorry to be late answering you, thank you so much for managing that.
Actually, yes I would like to have 'evidence terms that assert cell type X based on Y evidence (such as 'FACS evidence')', because in Bgee (bgee.org) we are on the process to annotate expression data from single-cell sequencing, and we would like to annotate in 2 steps:
-first, to annotate the cell type identified by the authors as the cells they used for the single-cell sequencing,
-then in a second step, and still for the same library, the (new) cell-type the authors can at the end specify thanks to the clustering of the results from the single-cell RNA-seq, and for this second step, yes, the 'ECO:0001560 single-cell RNA-sequencing evidence' is fine.
Here an interesting paper that, I guess, emphasizes the issue I am encountering:
https://www.ncbi.nlm.nih.gov/pubmed/?term=29149607
From FACS isolated olfactory projection neurons (PNs), many cell-sub-types are identified at the end of the single-cell RNA-seq analysis. So here the 'a priori' cell-type evidence is FACS, ok, and the 'at posteriori' cell-(new)type evidence is ECO:0001560 single-cell RNA-sequencing evidence', ok.
I also understand that I am mixing a bit the concept of ECO and OBI, but I wanted to anticipate any other new cell-type results that may come from 'a priori' evidence of 'general' cell-type isolated by any method other than FACS, because:
"WP: 'Many single-cell analysis techniques require the isolation of individual cells. Methods currently used for single cell isolation include: serial dilution, micromanipulation, laser capture microdissection, FACS, microfluidics, Dielectrophoretic digital sorting, manual picking, enzymatic digestion, and Raman tweezers"
Many thanks in advance for your patience, and thank you again for being open to discussion.
Best regards,
Anne

Hi @ANiknejad,
No apology necessary and happy to help!
I think that I now better understand what you need. You want to request terms that cover the possible types of evidence that are used to determine what a cell type is - correct? (Be it a priori or a posteriori matters not as the terms should be applicable to either situation.)
As I noted earlier, please feel free to provide a list of terms.  Additionally, if you provide definitions, and possible papers that can be used as database cross reference, it will speed up the process and make things more clear.  For example, you note "serial dilution" above.  I am unfamiliar with just how this provides evidence for determining cell type.  To me, serial dilution is a process/method involving the stepwise dilution of a substance in solution.
James

Hi @ANiknejad,
Checking in to see where we stand with your NTRs.  If you have a list of terms and can provided definitions and reference papers to speed the process, I can move forward with this.
James

Hi @jbmunro
Very sorry not being able to answer you more quickly. Actually I still have to do some work for providing definitions and reference papers, thank you for your patience. Cheers,
Anne

Hi @ANiknejad,
Not a problem at all.  I just wanted to make sure that this was still an active request.
James

Hello James, I got the feeling I made complicated something very easy actually...
When annotating samples for bulk RNA-seq, I never tried to put an ECO term on the sample itself actually, because the sample is considered as it is claimed by the experimenter, but here with scRNA-sequencing we can a posteriori re-annotate the 'sample' (=cell) thanks to the results of the sequencing and here ECO:0001560 single-cell RNA-sequencing evidence is appropriate. I just wanted to put an ECO also at the first annotation level, but maybe 'experimental evidence' or even nothing as previously is fine??

Hi @ANiknejad,
Sorry - I am not fully following.  Would it be possible to provide an example or two?
Thank you.
James

Hi James,
this paper was the reason for this brainstorming...
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6095479/
"Single-cell RNA-seq has recently emerged as a powerful technique to investigate cellular heterogeneity, discover new cell types, and identify cell type-specific markers. We established a robust single-cell RNA-seq protocol for Drosophila neurons and glia. By focusing on olfactory projection neurons (PNs), among the best characterized cell types in all nervous systems, we established unequivocally that transcriptomic identity corresponds with the anatomical and physiological neuronal subtypes defined by connectivity and function."
The fact that scRNA-seq of a defined cell-type allows to discover new (potentiential) sub-cell-type thanks to new markers gave me the reason to ask for making difference between 'a priori' and 'a posteriori' evidence codes...I am not sure how much I am more clear here, sorry for the trouble...

Hi @ANiknejad,
Thanks for the reference and for pulling out the section of interest.
Apologies for the confusion on my part.
I am struggling to understand what you are looking for us to provide:

A series of evidence terms that are applicable to the identification of a cell's type?
An evidence term applicable to the identification of a cell's type for this paper only?
A generic evidence term applicable to the identification of a cell's type?

If 1, then I need you to provide a list of terms, definitions for those terms, and where possible, papers that can be used as database cross references.
If 2, then to be honest - I am having trouble seeing a strong assertion being made with regard to 'a priori' cell type determination in the example provided.  Essentially, what is being stated in the excerpt is that a protocol was developed using transcriptomic data from scRNA-Seq data to create cell-specific gene expression profiles that corresponds with cells defined by either anatomic or physiological means.  But what exactly are the types of evidence used to define a cell by anatomic or physiological means?  It is not clearly stated here.
If 3, I cannot think of a generic, "catch-all" term that would be suitable or applicable.  In fact, ECO strives to try provide as specific a type of evidence term as possible. Certainly you could use 'experimental evidence', however, there is a lack of specificity.  If you have a term in mind - please feel free to request it.
I reached out to my colleague @nsuvarnaiari who suggested that you might be looking for a single term to annotate this paper (i.e. 2 above).  Both @nsuvarnaiari and I have read the provided paper.  @nsuvarnaiari suggested that the sentence you might be trying to annotate is this one:
"We sequenced cells from Drosophila pupal brains that were labeled by the astrocyte driver alrm-GAL4 (Doherty et al., 2009) and olfactory projection neurons (PNs) labeled by the GH146-GAL4 driver, which is expressed in 40 of 50 PN classes (Stocker et al., 1997; Jefferis et al., 2001) (Figure 1C)."
If this is so, then I believe that the labeled cells were identified 'a priori' because they express GFP.  ECO has the evidence term 'green fluorescent protein immunolocalization evidence'.  Will this term work for you?
Please let me know what I can do to help.
James

Dear James, @jbmunro
Thank you very much for your kind attention and efforts to support my messy request!
Yes, I was looking for "1. A series of evidence terms that are applicable to the identification of a cell's type."
But your colleague @nsuvarnaiari (please say thank you to him from my side!) is right too, for this paper I was looking to report the evidence for the 'a priori' brain cells, that are actually 2 different cell types identified by GFP.
In bgee.org, we annotate RNAseq from 'bulk' and now 'single cells' libraries, and the annotation procedure is obviously not the same, due to the results the authors usually provide after scRNA-seq sequencing.
At the end we decided to annotate only papers with clear transcriptomics of cell-type, without dealing with complex clusters of 'new' sub-sub-cell types.
Once again, thank you very much for your help, James, and thank you for your time and your patience.
Kind regards,
Anne

Hi @ANiknejad,
No problem at all.
So - where do we stand with this?  It sounds like you have resolved the issue of annotating the paper at hand, but what about the series of evidence terms that describe the identification of a cell's type?
I would like to suggest that we close this ticket and that as you come across the need for additional terms, you open new tickets and request new terms as needed.
Please let me know how you wish to proceed.
James

Hi @jbmunro ,
I agree, we can close this ticket. Also some work is in progress concerning the set up of minimal requirements for single-cell RNA-seq data, maybe you could have a look at this document here:
https://docs.google.com/document/d/1UglgMOlmzbZQPe4JG5v8-75iaQ1ezt97Dz83qKncuA8/edit#

Hi @ANiknejad,
OK - closing the ticket.  Thanks for the link to the manuscript.  Feel free to create new tickets for new term requests as they arise.
James


Bulk Edit Screen

@jamesrwelch - is there any way you could adjust the Bulk Edit Screen so the Data Element name can be viewed in full.
I thought I may be able to change the size of the column like in file explorer but you can't. I can expand the column but it still doesn't show the full name of the Data Element.
When we have Data Elements with similar names you won't know which is which, as per my example below in the Data Set Table view.

It is OK in the profile view:

Can we also please discuss the Multiplicity for the Data Groups and Sub Groups.
The multiplicity for the groups is taken from the text, e.g. To carry Eye Colour details for the patient. One occurrence of this group is required for each patient.
Therefore, would be need to update this for the data groups and sub groups using the Bulk Editor or can I not mention it in the Wiki?

15/10/24 - James will:

see if the Bulk Edit Screen can be adjusted to view the full Data Element name.
investigate why the multiple occurrences text below the Data Elements is not working.


Cups not working on Ubuntu 23.04

Describe the bug
After upgrading to Ubuntu 23.04, my laptop failed to discover our print server.
The problem seems to have been caused by a new change in cups-browsed that was added to Ubuntu 23.04.
I looked into it and found a small fix that seems to solve my issue.
Using the debug configuration for cupsd and cups-browsed, I looked through the logs and noticed the following line:
failed to bind CUPS Browsing socket: Permission denied
After reading more about printer advertisement and cups-browsed, I concluded that the printer is shared to my Ubuntu 23.04 laptop via CUPS on port 631.
When I connected an Ubuntu 22.04 laptop to the WIFI network, I saw the printer really was being shared with CUPS on port 631.
Cups-browsed was running as root on 22.04 while on 23.04 it is running as a new user - cups-browsed, but this new user didn't seem to have the necessary permissions to open a listening socket on port 631.
The solution I tried was granting the relevant binding permissions to the binary with this command (on the 23.04):
setcap cap_net_bind_service+ep /usr/sbin/cups-browsed
After giving the permissions, my computer successfully discovered the printer, just like it used to on 22.04!
I think the command should be added to the post install script or maybe the capability should be granted to the new cups-browsed user.

Hi @m0rgn ,
this looks like an issue Ubuntu packaging of project cups-browsed (cups-browsed runs as root on Fedora Linux), please report the issue to Ubuntu.
Thank you in advance!


Allows % and infinity for Memory Limits + Add MemoryMin

Pull Request (PR) description
The memory service limits were missing support for specifying a percentage of memory, same for infinity. This PR fixes this.
I also noticed that MemoryMin was missing.

@SeanHood can you please write some basic tests for this? an example for another type is at https://github.com/voxpupuli/puppet-systemd/blob/master/spec/type_aliases/systemd_coredumpsettings_spec.rb

Though that type should probably allow some percentages in places as well. Not relevant to this patch.

Thanks for the suggestions, I've pulled in the regex changes and added some basic tests.


added FAQ to fix main and master branch name issue

This is for new visitors who have a hard time figuring out that their solution is indeed correct but there's a bug on our side. This is a temporary fix.

Thanks <3

Thanks <3

Thanks for Githug!!! I absolutely love it.


[stb] Add support for stb_vorbis and update port.

Describe the pull request

What does your PR fix?
I wanted to use the stb_vorbis library from stb.
The current stb port does not have support for the stb_vorbis library.
I have added support for stb_vorbis.
I have also added some updates to the port.
I have replaced the CONTROL file with a vcpkg.json manifest file since I needed to add some dependencies on vcpkg features.
In the replacement file, I have updated the version string to "2021-06-20". That is the data of the latest commit in the stb repository.
I updated the portfile's REF to the latest commit as well.
To add stb_vorbis I used the compilation guide at https://nothings.org/stb_vorbis/.
I made the portfile first cut the header out from the source file and write it to a seperate file.
Then, the portfile needs to compile the source file as a library.
First, it adds an export macro to the source file along with an include to find the header.
Then it copies a CMakeLists.txt to the source path. I wrote this file to configure and install a library for stb_vorbis.
Next, vcpkg configures and installs the library.
The portfile installs the rest of the stb libraries as normal.
I have no clue what vcpkg-cmake-wrapper.cmake is, and I do not think FindStb.cmake is still needed. If I do not install them, I can still use the other libraries, but I have kept them to be safe. At least keeping the FindStb.cmake should ensure that projects that use stb don't break.
This is my first pull request. I hope that there are no issues. I updated this port for my personal use and it works for me so feel free to deny the request if there are issues.

Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows, No
Other triplets should be support but I have not tested them.

Does your PR follow the maintainer guide?
Yes. (hopefully)

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
Yes. It seemed to also update the formatting of libsmb2 in baseline.json, I reverted that change since it is not relevant to this.

All stb libs have been updated a few days ago for stability. Could we update the portfiles in this PR or should I create a new one?

There are still some review suggestions not updated now. So we still need to wait for the response from @Colon-D.

It seems I have made some mistakes. I thought I had confirmed the review suggestions but this is not the case.
I have made another attempt at resolving the review suggestions.
As this is my first attempt at a contribution to a public repository I am making lots of mistakes. Let me know if there are any other issues.

For the failures on x86-windows, you can run vcpkg x-add-version --overwrite-version stb and then submit the changes to solve it.

Hi @Colon-D
Could you please address the review suggestions?

I am afraid not. I wanted to share the changes I had made incase anyone else wanted stb's vorbis library. Doing so became much too complicated so I gave up and switched to another language.

I am afraid not. I wanted to share the changes I had made incase anyone else wanted stb's vorbis library. Doing so became much too complicated so I gave up and switched to another language.

It's a bit pity. But thanks for your contribution to vcpkg anyway.

You can reopen this PR if you want to continue to work on this PR in the future.


Add guardrails for users that pull from or push to Docker Hub via the invalid docker.io domain

We should add some registry-specific checks (like have been done for Amazon Elastic Container Registry endpoints) that issue a warning

if the docker.io URI is used as the ContainerRegistry (because it won't work), or
the registry.hub.docker.com or  registry-1.docker.io domains are used as the ContainerRegistry but we only have credentials for index.docker.io (because the user used a 'normal' docker login command, which defaults to this domain)

We should also consider seeing if we can use the credentials from index.docker.io in this case to make things 'just work' and/or automatically rewrite docker.io urls to registry-1.docker.io urls.
Originally posted by @baronfel in https://github.com/dotnet/sdk-container-builds/discussions/359#discussioncomment-5125638

We do this now!


Ignore key events (specifically arrow keys) if a modifier key is down

The web ui supports using alt+up/down to change the weights of the selected text/lora, however this also activates the tag autocomplete popup at the same time.
Is there any reason for the code to respond to arrow keys while alt/shift/control are pressed? It looks like you can just exit early in tagAutocomplete.js' navigateInList function if event.getModifierState indicates that any modifiers are down.

I'm not sure what your issue is, I already do exactly that. See the following line:
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/blob/main/javascript/tagAutocomplete.js#L1116-L1117
It uses the direct event vars instead of getModifierState, but for this case it should be functionally identical.
It will not force-close the popup if it is already open, but at least for weight editing this happens automatically for me due to the text change. And it definitely stops the list from capturing the key press. Works as intended for me:
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/assets/34448969/4e408722-641e-4e8e-9ab9-ecb7df1c6184
Also as a side note, at least in the default webui weight editing is only possible with CTRL, and ALT for switching the position of the selected word in the prompt. You can't change it to ALT for weight editing there. Are you using a fork?

Are you using a fork

No I'm using a Mac. I meant Control. This is what happens; Auto1 version 1.5.2 with the latest Chrome.
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/assets/44075232/a514d129-fe01-485b-a6c9-5b9610db3639
Don't know why the popup isn't showing up near the text cursor, it was doing that properly before.

Ah, I think I see the issue now. The mac command key is event.metaKey, not event.ctrlKey, which I didn't catch before.
I believe it should be fixed now. I don't have a mac to try it out myself, so feel free to reopen if it still has issues.


x/crypto/ssh/agent: failure in TestServerResponseTooLarge on plan9-arm builder

-- FAIL: TestServerResponseTooLarge (0.67s)
    client_test.go:347: At least 4 bytes (the response size) should have been successfully written: 0 < 4: write tcp <IP_ADDRESS>:38085-><IP_ADDRESS>:42354: write /net/tcp/33/data: i/o on hungup chann
2021/12/03 20:06:22 agent 23: agent: incorrect passphrase
agent.test 2590: warning: process exceeds 100 file descriptors
FAIL
FAIL	golang.org/x/crypto/ssh/agent	6.393s

greplogs --dashboard -md -l -e 'FAIL: TestServerResponseTooLarge'
2021-12-03T18:27:20-5770296-c4a8550/plan9-arm
(Note 2-year gap here!)
2019-11-16T20:31:45-e1110fd-6ba0be1/plan9-amd64-9front
2019-03-20T22:39:03-b7391e9-ff04803/plan9-arm
2019-01-28T20:35:33-c7b33c3-c00595c/plan9-386
2018-11-10T11:57:17-e4dc69e-6dd70fc/plan9-386
See previously #35888. (CC @fhs @0intro @millerresearch)

As noted, this seems to be a recurrence of #35888. That was fixed by special case code for Plan 9, which looks for error messages "Hangup" or "i/o on hungup channel". In this new occurrence, it appears the expected message has been truncated to "i/o on hungup chann" -- or is that an artefact of the logging mechanism?
The obvious workaround would be to make the error message comparison more liberal, but it would be good to know what causied the truncation.
I can't replicate this -- perhaps not surprising if it has happened only once in the last 2 years.

Heh, neat! I don't think the truncation here is intentional — this looks like probably a memory-corruption bug. (Maybe a 1-to-0 bit flip somewhere in the path generating the string?)

Duplicate of ##35888

probably a memory-corruption bug

There was an issue with syscall error strings being corrupted which should have been fixed by this commit. Possibly it's still not quite right, but if so I would have expected more symptoms by now.


Implement HasId trait

Any ideas on how to reuse that for get_object?
Doing
pub fn get_object(id: &str) -> Option<impl HasId> {
    js_unwrap!(Game.getObjectById(@{id}))
}

seems pretty pointless.

My best idea would be to move the declaration of get_object inside the HasId trait and basically use the method as a constructor of Self. My only problem with that approach is I don't know how to actually check whether it is actually the right object.
One possible solution to that problem, while not perfect, would be to hijack the ids and type them, maybe by appending something like 1134e143e...137243#Creep.

As far as I'm concerned I don't think we need to change get_object for this. HasId should be a strict subset of RoomObjectProperties, so I can't think of a much more useful thing to do than to return RoomObject.
I guess it means we can't immediately get the id from something which we've just gotten from an id, but that seems pretty niche.
Maybe we could add a get_object_as_has_id function which returns Option<Box<HasId>>?

Actually, the more I'm thinking about it, the more I believe implementing type safe TryFrom<Value> for all rust objects, with js-side type check (ie using instanceof) would make the code much more readeable (and safe!) in the long run.

Yeah, that could definitely be good. I think stdweb might even have some derive utilities to create TryFrom implementations for Reference if we want to do that.
The main reason I didn't implement them with type checks built in initially was the potential performance cost of doing an instanceof check every time rust grabs a reference. I don't know how much that performance cost is, but it seemed like it could be nontrivial, and it didn't seem worth it when we most of the time we can instead just trust that Game.creeps contains Creeps, for instance, or that RoomObject.pos is a RoomPosition.
I wouldn't necessarily be against changing TryFrom implementations to check for their source, but I'm still relatively confident I wouldn't want to perform those type checks when getting properties of things that we know the game always creates as the right type. Maybe we could have TryFrom<Reference> implementations do the checks and introduce a local FromReferenceUnchecked trait which a variant of js_unwrap! could use?

That sounds like a best of both world approach. I'll take a look tonight.

I just stumbled upon this: https://docs.rs/stdweb/0.4.6/stdweb/trait.ReferenceType.html
It'd fit the bill nicely for the quick, cheap conversion.

This should address all your concerns.

Regarding #51, I'm not yet convinced this is needed. I'd wait until we've used the API enough to make up our mind about it.

Thanks - everything's great!


Poor frame rate when jumping to definition over long distances with smooth scrolling enabled

VSCode Version: Code - Insiders 1.16.0-insider (d0d00e882437092f521d2d7893cc56ee296d278f, 2017-08-29T06:58:13.897Z)
OS Version: Linux x64 4.10.0-32-generic
Extensions:

Extension
Author (truncated)
Version

EditorConfig
Edi
0.9.4

lorem-ipsum
Tyr
1.0.0

sort-lines
Tyr
1.3.0

vscode-svgviewer
css
1.4.2

tslint
eg2
0.17.0

git-project-manager
fel
1.4.0

md-navigate
jri
0.0.1

theme-monokai-pro-vscode
mon
1.0.1

vscode-scss
mrm
0.6.2

seti-icons
qin
0.1.3

Ruby
reb
0.15.0

vim
vsc
0.9.0

(1 theme extensions excluded)

#33299

Open this line https://github.com/Microsoft/vscode/blob/30b47ba11c3a206773953909bbf2291670c8cbd6/src/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#L763
Ctrl+click on TerminalInstance

Specs:
CPU: 3.50GHz 4 core with hyperthreading
RAM: 64gb

@Tyriar The animation takes 100ms. What concerns me is the high ratio of JS Scripting to Browser Rendering on your trace. Here is the trace of doing the same thing on my machine (a MacBook Pro at 3.3GHz)
(Note I have turned off Screenshots in the Timeline)
The 1 is where the editor begins to paint (i.e. related to smooth scrolling). The code before is all specific to jump to definition. We can look into improving that, but I think your point is about smooth scrolling being slow.
On my machine, the 100ms end up in 5 editor frames, the slowest JS paint happens at frame number 4, at about 12ms spent in JS. I've recently (2 days ago) further optimized the JS times by using a TypedArray based StringBuilder for generating the HTML output. I think we're at a point where we need to consider reducing the times the browser takes to recalculate styles and relayout. IMHO this could be done by using shadow dom.

There are two things:

the smooth scrolling animation function does not make sense over large distances. i.e. when jumping at a distance above two viewport lengths, it does not make sense to flash a portion of source code in between the start and the end viewport. I will tweak this animation function, which should improve the feeling (actually seeing things moving rather than some unrelated viewport flashing in and out) and should improve the total consumed time.

What concerns me, is the high time spent on your machine in JS compared to the browser layouting/rendering. Is it perhaps that you have enabled a certain set of settings that make the editor slower: e.g. using a non-monospaced font, using ligatures, having 1000s of decorations, etc. What settings do you have enabled ? e.g. on Joh's machine painting a frame in a certain file took 60ms due to tens of thousands of decorations from the rainbow brackets extension. I need to figure out how to faster intersect the current viewport with all the multiline decorations, but yeah ... it would be nice to find out if a certain setting is causing the slowness for you ?

the smooth scrolling animation function does not make sense over large distances. i.e. when jumping at a distance above two viewport lengths

This is one of the main places it makes sense imo. I personally don't find this feature particularly valuable when I know where I'm scrolling to, but when I don't know (jump to defintiion), it can provide some great context of where I went relative to where I was (in the same file).

it would be nice to find out if a certain setting is causing or aggravating the slowness for you ?

Here are my settings:
{
  "editor.autoClosingBrackets": false,
  "editor.codeLens": false,
  "typescript.implementationsCodeLens.enabled": true,
  "typescript.referencesCodeLens.enabled": true,
  "editor.folding": false,
  "editor.fontFamily": "Hack",
  "editor.formatOnPaste": false,
  "editor.minimap.enabled": true,
  "editor.minimap.renderCharacters": false,
  "editor.renderControlCharacters": true,
  "editor.renderIndentGuides": true,
  "editor.renderWhitespace": "boundary",
  "editor.roundedSelection": false,
  "editor.rulers": [ 80, 100, 120 ],

  "explorer.autoReveal": false,
  "explorer.openEditors.visible": 0,

  "extensions.autoUpdate": true,
  "extensions.ignoreRecommendations": true,

  "files.defaultLanguage": "markdown",
  "files.hotExit": "onExitAndWindowClose",
  "files.useExperimentalFileWatcher": true,

  "terminal.integrated.cursorBlinking": true,
  "terminal.integrated.scrollback": 5000,
  "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",

  "window.restoreWindows": "all",
  "window.title": "${rootPath}${separator}${activeEditorName}${separator}${appName}",

  "workbench.colorTheme": "Sapphire",
  "workbench.editor.enablePreviewFromQuickOpen": false,
  "workbench.iconTheme": "seti",
  "workbench.startupEditor": "none",

  // Languages
  "typescript.check.tscVersion": false,
  "[markdown]": {
    "editor.quickSuggestions": false
  },

  // Extensions
  "gitProjectManager.baseProjectsFolders": [
    "$HOME/dev",
    "%USERPROFILE%\\Documents\\dev"
  ],
  "gitProjectManager.maxDepthRecursion": 2,
  "window.zoomLevel": 0
}

re:

This is one of the main places it makes sense imo. I personally don't find this feature particularly valuable when I know where I'm scrolling to, but when I don't know (jump to defintiion), it can provide some great context of where I went relative to where I was (in the same file).

The smooth scrolling makes sense to work when jumping to definition. IMHO the problem lies with the animation function that determines the scrollTop of the editor in an indiscriminate fashion as a cubic ease out.
e.g.
a small jump
suppose scrollTop is 0 and a smooth animation request comes in to jump to 500. The line height is 20px and 30 lines fit in the viewport.
Here's what the animation will be like assuming the editor has time to render 5 frames in 100ms (~20ms per frame):
frame 0: 10/110=0.09, easeOutCubic:0.25 => scrollTop 124 => [6, 36]
frame 1: 30/110=0.27, easeOutCubic:0.62 => scrollTop 308 => [15, 45]
frame 2: 50/110=0.45, easeOutCubic:0.84 => scrollTop 419 => [20, 50]
frame 3: 70/110=0.64, easeOutCubic:0.95 => scrollTop 476 => [23, 53]
frame 4: 90/110=0.82, easeOutCubic:0.99 => scrollTop 497 => [24, 54]
frame 5: 110/110=1.00, easeOutCubic:1.00 => scrollTop 500 => [25, 55]

The animation function (in its current form) works well in this case. Each frame contains a region of lines from the other frame, so the eye would presumably form a motion. i.e.:

frame 1 has 20 lines overlapped with frame 0
frame 2 has 25 lines overlapped with frame 1
frame 3 has 27 lines overlapped with frame 2
frame 4 has 29 lines overlapped with frame 3
frame 5 has 29 lines overlapped with frame 4

a large jump
suppose scrollTop is 0 and a smooth animation request comes in to jump to 50000. The line height is again 20px and 30 lines fit in the viewport.
frame 0: 10/110=0.09, easeOutCubic:0.25 => scrollTop 12434 => [621, 651]
frame 1: 30/110=0.27, easeOutCubic:0.62 => scrollTop 30766 => [1538, 1568]
frame 2: 50/110=0.45, easeOutCubic:0.84 => scrollTop 41886 => [2094, 2124]
frame 3: 70/110=0.64, easeOutCubic:0.95 => scrollTop 47596 => [2379, 2409]
frame 4: 90/110=0.82, easeOutCubic:0.99 => scrollTop 49699 => [2484, 2514]
frame 5: 110/110=1.00, easeOutCubic:1.00 => scrollTop 50000 => [2500, 2530]

The animation function (in its current form) does not work well in this case.

frame 1 has no lines overlapping with frame 0, so it appears as a random flash of text
frame 2 has no lines overlapping with frame 1, so it appears as a random flash of text
frame 3 has no lines overlapping with frame 2, so it appears as a random flash of text
frame 4 has no lines overlapping with frame 3, so it appears as a random flash of text
frame 5 has 14 lines overlapped with frame 4, so a motion could be formed.

So I'm thinking to change the animation function when the jump distance is > 2*viewport such that it  stays a bit near the initial viewport and then boomerangs straight to a place near the final viewport (fyi @jrieken ).

I've extracted the tweaking of the animation function in #33534
I don't see anything "shady" in your settings that would cause us to skip the optimized path in the rendering code, unless Hack is not detected as monospace on your machine. Minimap will probably add a couple of ms of rendering time, especially when jumping a long distance (as explained above) and I'm not really happy with the indent guide rendering times.

frame 1 has no lines overlapping with frame 0, so it appears as a random flash of text

This is a good point 😄 Thinking about it now, the reason I felt I had context was the animation in the minimap and scrollbar

I am not sure what else is actionable in this issue:

editor.smoothScrolling is off by default
the animation function is already tweaked via #33534 such that the 3-4 frames that get painted show lines next to the destination

I will close this issue for now...


Gyro sensitivity feature

Added gyro sensitivity feature for windows+Linux for D435i (Old/New sensor) and D455
tracked by RSDSO-19305

Looks great overall good work!!

What about the scan factor we have on the output?
Should remain the same for D400
?


Consider Add or Replace Endpoint extension method

For this, we already have a AddEndpoint -- perhaps this impl shoul[d just change to put the item in front?

I suspect we'll be reworking in terms of endpoint routing at some point, and AddEndpoint already works, I'm closing this.

Did this show up in the release notes as an enhancement because it was attached to a milestone even though this issue resulted in no changes?

I think you're right -- there was no action here in 2.5 IIRC.


whenever window is initialized or updated, make sure we unsubscribe f…

…rom any events in odd-region-draw-tool and osd-svg-overlay, since they will be re-subscribed
closes #1075

Coverage increased (+0.01%) to 47.44% when pulling b66d762525fa9da1b7001a6cb6b858e8d1b85389 on 1075-destroy-events into 09457bf8afbacfa651d80a17c3fb4726d2d5ff77 on release2.1.


Regression: Restrictions augmenter exposes bug in restrictions checker

The restrictions augmenter (#12103) added some type restrictions to ivar parameters. This exposed a bug in the type restrictions checker (#12126) when previously working code began to fail with Crystal nightly (example).
So it's technically a regression. But it's not a bug in the restrictions augmenter itself. It just applies code that can trigger the bug and break a previously working code base.
I'd suggest to simply deactivate the restrictions augmenter until #12126 is resolved.

Resolved by https://github.com/crystal-lang/crystal/pull/12129


Async failures are not retried with backoff

What happened?
During the implementation of this PR, I realized that the current async operation callback mechanism does not back off after a failure with the current APICallback mechanism.
The main problem is when an async operation fails; there is no way to trigger a reconciliation with backoff since we are no longer inside the Reconcile method of controller-runtime; hence, we cannot use the existing backoff mechanisms coming with controller-runtime. As an example, think of the following scenario where we are trying to delete a non-empty s3 bucket:

Delete a non-empty bucket.
An async destroy operation started.
Async destroy failed -> we updated status (and annotations with this PR)
Resource is queued immediately, triggering a new reconciliation.
Go to step 2

As you can see from the above flow, we are not re-queuing with backoff, and there is no easy way to do so unless we implement our own mechanism somehow.
How can we reproduce it?
See the example flow above.
/cc @ulucinar @muvaf

Mostly yes.
Indeed, this is only a problem when a resource is running in async mode, however, AFAIK, this is the default configuration for most of the resources. (@ulucinar can correct me)
There is a natural rate-limiting in upjet-based providers due to the time it takes to complete a reconciliation loop. However,  we cannot leverage the backoff machinery in the controller runtime.