Import all dependencies from single webpack bundle/entry automatically

I have webpack-bundle-tracker and django-webpack-loader in a working state after manually fixing them, but as part of my CI/CD it is not viable to do this.
A thing that I noticed this project does not do is link which npm packages are used in which bundles when you follow the tutorial which got me into this in the first place (which you also link in your readme) which makes all the npm packages into different .js files to save bandwidth with caching.
Here's an example of the output of<EMAIL_ADDRESS>(note it does not do this in 0.4.3):
...
"chunks": {
        "globals": [
            "runtime.7389d0ed4f1baaf09d7f.js",
            "globals.cfeb587d501142b196c5.js"
        ],
        "board": [
            "npm.underscore.c7a03d459b7d101c847b.js",
            "npm.regexp.prototype.flags.2623abc18f6e36f1fbd2.js",
            "npm.object-is.38cd874c904b51db50c7.js",
            "npm.object-keys.dfaa60aa949e1df12b1c.js",
            "npm.has-symbols.05e790e10906ba453058.js",
            "npm.function-bind.2d6787cc6f5f48b3b50e.js",
            "npm.es-abstract.6c4cb5b8e3a358d794f8.js",
            "npm.is-regex.4a1384cbccb2368b5c84.js",
            "npm.is-date-object.39cb2bf1968347761930.js",
            "npm.is-arguments.ff60d7ce5200e7f3abb1.js",
            "npm.invert-color.1ed95cd7bb596a2a2a68.js",
            "npm.has.4bac64353b104fe339c3.js",
            "npm.fast-diff.809067b7dc8fbef37c87.js",
            "npm.extend.cf12587c8e830c228315.js",
            "npm.define-properties.a59ce35a4273a902a5e2.js",
            "npm.deep-equal.35ddf946ff5693b1dd89.js",
            "board.5d76531bfc5c8812e276.js"
        ],
        "drive": [
            "npm.quill.0f4eed0169b981e5c8e3.js",
            "npm.quill-cursors.c297e81a0f33e5574f5d.js",
            "npm.quill-delta.ca815e1b8e309922cae6.js",
            "drive.b3ce3a01d399c22a27e2.js"
        ]
    },
...

With the output above, I was able to do {% render_bundle 'board' %} and it would import all the files as seen above under the 'board' chunk.
I believe this is a mandatory feature, as I do not want to be keeping track and/or guessing which npm package I use in which bundle, thus forgetting to add or remove a script tag in my HTML.
I also do not know the significance of the runtime.js file webpack outputs when you have multiple entry files and runtimeChunk: 'single', in your webpack config, but I assume it should be imported when using any of the bundles?
You could even go further as to support webpack's dependOn: 'x', flag, and have the bundles that depend on other bundles automatically imported also, which is something the older project does not do.
With all that in mind, it should probably prevent importing the same file twice in one document?
Thanks for creating and maintaining this project. Please let me know if this feature is possible for you to implement.

Hi @manstie, I'm not understanding what exactly you want to do. If you're using this app, django-manifest-loader, you can import all files with a single tag, where the first argument is the pattern to match, and the second argument is what string to embed the matched file path into:
{% load manifest %}
{% manifest_match '*.js' '<script src="{match}"/>' %}

Please not that this app is not designed to work with webpack-bundle-tracker. django-webpack-loader is a different app from this one, which is designed to work with webpack-bundle-tracker.
This app uses webpack-manifest-plugin

The point is I do not want to import every file on one page because I have created multiple bundles/apps, and my webpack config has multiple entry-points.
So for this feature to work, the output of webpack-manifest-plugin would have to have an option, and webpack-manifest-loader would have to have a function to allow for specific bundle (and its dependencies) importing only.
I understand the difference between the two sets of applications, and I was trying to explain the feature of the old unmaintained repos.

Okay. I think I see what you're saying. I'll admit that it's been several years since I used django-webpack-loader, and I wrote this app instead of having to learn it again. I'm working on a pull request (#22) right now that allows the implementation of custom loaders. I'm pretty sure a custom loader could be used to do what you want to do. Once I finish that PR I might look into building a loader for this to help people transition from one app to the other.

Sounds good, thanks for working on that.

@manstie the custom loaders have been released and are available in the latest version of this package. You can build a custom loader that will allow you to parse through the manifest file as you choose. This should let you implement compatibility for the manifest file generated by webpack-bundle-tracker.
Documentation on how to build a custom loader can be found here: https://django-manifest-loader.readthedocs.io/en/stable/docs/usage.html#custom-loaders
Seeing how webpack-bundle-tracker is no longer maintained I will not be implementing a loader for it into the source code of this package. If you do build a loader I encourage you to share the source code of it here so that others in the future may be able to find it.

PS this draft of a loader I built for create react app is pretty close to what you'd want to implement for this: https://github.com/shonin/django-manifest-loader/pull/33/files#diff-52d43aa2f47a3b5faa105d50717c0277a2af1a9dc404e43860e3d42719b5f051R29

Nice work.

Nice work.


Fix Travis CI by restoring postinstall script in package.json

postinstall script got lost by https://github.com/tgriesser/bookshelf/commit/61f287ba09d3ae2cce45656d34e3d8729bf2fb9d. Restore it.

This is caused by problems in the build script. :-S


Reload swaybar/swaybg on config reload.

This works by tracking the pids of the child processes in the related
output container and terminating the processes and spawning new ones on
a config reload.
Should solve: #347

This has one problem where the windows will cover the bar after a reload until you do something to rearrange them, i.e. spawn a new window. I suspect this also happens on startup but since you don't have any windows open at that point you won't see it.
Any ideas how to update the layout correctly when spawning the bar after a reload?

@mikkeloscar just run arrange_windows(&root_container, -1, -1) to force a rearrange of the entire compositor.

Hmm, that is called in cmd_reload after a new bar is spawned.
I just tried on the master branch and if you spawn a window and then spawn a swaybar manually the same thing happens (it spawns behind the window).
I did a bisect of master and I think this issue was introduced in ed730db

Yes, this problem doesn't happen if I revert ed730db

Hmm... I'm looking in to it now.


Add tests for portal controller VinylDNS.scala

This work can be broken down into multiple PR's. If submitting a PR for this issue, please specify the scope of work completed in the PR description.
Motivation
We have a lot of untested functions in the VinylDNS controller. Code coverage is currently turned off for those functions, but when it's on our code coverage drops to around 59% for the file. We want full test coverage so future changes to the codebase don't cause issues without us realizing it.
Scope of change
Note: All of the functions are already tested for the custom action in them (userAction, or frontEndAction).
Functions with coverage turned off:

getZones
getZone
syncZone
getRecordSets
listRecordSetChanges
addZone
updateZone
addRecordSet
deleteZone
updateRecordSet
deleteRecordSet

To test locally
After writing the tests in VinylDNSSpec:

remove the // $COVERAGE-OFF$ and // $COVERAGE-ON$ where applicable
in the terminal run sbt ";project portal;coverage;test;coverageReport"
this will generate a local report that you can view in the browser. The html file path will appear towards the end of the terminal output, you can copy and paste it in the browser to review the code coverage changes.

This should be handled as part of #968


 This would provide substantial performance value options in themes.

[x] There's a clear use-case for this code change
[x] Commit message has a short title & references relevant issues
[x] The build will pass (run yarn test and yarn lint)

More info can be found by clicking the "guidelines for contributing" link above.

Honesty time, this is a half measure.
What I'd really prefer is a way to register something like WordPress' content filtering to be able to adjust and influence content output in a meaningful way.
Like middleware for content output which would ok it's own make the extensibility of Ghost much much more dev friendly and allow for devs to solve for any number of use cases ahead of template or API output.

Gonna close this as per your own comments about it not being the right solution. Gonna put a larger comment on the more recent PR :)


make stack traces nicer

take a good look at the stack traces that failures generate and see if we can make them nicer. for example it would be nice if in the case of parametrized tests the stacktrace would contain the line of the test config

I think we should create a pseudo stacktrace that contains stacktrace elements for every context leading to the test and the test itself.


[Provider Audit] provider.akth-cryptobabou.com

Hello !
Please can you pass the audit for provider.akth-cryptobabou.com ?
Discord handle : CryptoBabou
Contact email address<EMAIL_ADDRESS>thank in advance,

duplicates https://github.com/akash-network/community/issues/464


Modulize the installation script

The script is useful as a standalone script, so it's probably not necessary to fully convert it to a module, but a simple module that acts as a wrapper around the install script would make this a bit more Ansibley - that would take care of copying it over and running it for you, and cleaning up afterward.
That said, it's actually not necessary to copy it over at all. It could run on the host from which you're running Ansible.

I see in tools.yml that it in fact does run locally. Heh.

I am a little wary of using this on Galaxy Main for the moment just because I won't be able to tell individually what it did. If Ansible itself read the tool YAML and provided that to a tool installation module as {{ item }}s you'd get a single line of output showing changed or unchanged for each item in the tool list.

That's a good idea. I'll see how to make it happen.
For what it's worth, it logs to /tmp/galaxy_tool_install.log where is captures everything that's done.


how to avoid insert the same style

When @material-ui/pickers and @material-ui/core/Select in a same page，it will insert the same css，then they will be affected by each other，how to insert the style only once time!

Duplicate of #1143


Make org_meta_return work in insert mode

Does this feature exist in Emacs orgmode core?
No
Orgmode link
it's not a emacs specific feature request
Feature value
No response
Additional context
the default mapping is not suitable for insert mode but it can be mapped to a appropriate mapping like <A-CR> the problem is the mappings are restricted for normal mode

I agree, this is a limitation I also struggle with every day (because I use bullet lists and checklists quite a lot).
I already had a look at the code, but the way, how mappings are handled is not as easy to understand as I had hoped. Maybe @kristijanhusak can elaborate on thoughts behind these design decisions and also has some hints how the current structures could be extended to allow user mappings on other modes.
My current intuition is, that maps should alternatively accept a table with a key "mode" and a key "map" and MapEntry:attach should handle this case (see snippet).
https://github.com/nvim-orgmode/orgmode/blob/92bfc3fb7ee845d9e58326b0b69f3ed89e84253f/lua/orgmode/config/mappings/map_entry.lua#L64-L103
I think this extension should be handled particularly at the beginning of this iteration over mapping:
https://github.com/nvim-orgmode/orgmode/blob/92bfc3fb7ee845d9e58326b0b69f3ed89e84253f/lua/orgmode/config/mappings/map_entry.lua#L94-L102
Something like this:
local modes
if (type(map) == "table" and map["modes"] and map["map"]) then
  modes = map["modes"]
  map = map["map"]
else
  modes = self.modes
end
-- ...
vim.keymap.set(modes, map, ...)
-- ...

Than we would be able to handle a map entry in the config like this:
org_meta_return = { map = '<M-CR>', modes = { 'n', 'i' }

@kristijanhusak What do you think?

As stated here:

Support for this was added on the latest nightly branch. You can find docs about it here: https://github.com/nvim-orgmode/orgmode/blob/nightly/DOCS.md#use-enter-in-insert-mode-to-add-list-itemscheckboxestodos

Nightly was merged into master so this should now work: https://github.com/nvim-orgmode/orgmode/blob/nightly/DOCS.md#use-enter-in-insert-mode-to-add-list-itemscheckboxestodos


Draw border 1 range

I want to draw border 1 range, I don't know how to do it

You'll need to do it cell by cell. There is no border around feature.


map mouse buttons to keyboard

Description of the new feature / enhancement
have the possibility to remap mouse buttons to any key on the keyboard using the keyboard utility
Scenario when this would be used?
could be useful to have those buttons if the mouse/trackpad buttons broke and don't have time to fix or replace the mouse/trackpad
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/1475


Add support for  Llama2, Claude, Palm, Cohere, Replicate (100+ LLMs)

Hi @thy09 @zhengfeiwang @lalala123123,
Based on your feedback on this PR - https://github.com/microsoft/promptflow/pull/359.
My PR shows users how to call their custom LLM providers (bedrock, togetherai, huggingface tgi, replicate, ai21, cohere, ai21 etc.) by pointing the api base to a local proxy they can use for experimentation with PromptFlow.
This makes no code changes to PromptFlow.
Happy to add additional tests/documentation if the initial PR looks good.

@microsoft-github-policy-service agree [company="BerriAI"]

@microsoft-github-policy-service agree

Hi @krrishdholakia, thank you for this helpful contribution! We think the integrations  doc dir would be a better place to host this tutorial. Could you please add a new page under docs/integrations/llms to introduce this integration between Litellm and Prompt flow? That way it will show up nicely under the "Integrations" section of the PromptFlow documentation site. We're excited to see this integration documented - it's a clever way to combine these two.

@chjinche done

Hi @krrishdholakia glad to see the change! Maybe you could improve the doc file name and the content structure a little bit, then community may have a clear overview and concise steps for integrating additional LLMs through LiteLLM.
Following are just some ideas to potentially improve findability and user-friendliness. Please feel free to tweak the title and content structure as you see fit.
filename: integrations_litellm.md
content structure:
# Integrating Additional LLMs into Prompt flow using LiteLLM

This guide explains how to connect additional large language models (LLMs) to PromptFlow conversations using the open source LiteLLM proxy.

## Overview

LiteLLM allows you to create a proxy that translates OpenAI API calls into requests for other LLM providers like Anthropic, HuggingFace, Ollama, etc.

By running a LiteLLM proxy and configuring PromptFlow to point to it, you can leverage different LLMs while still using PromptFlow's OpenAI integration.

## Steps

1. Install LiteLLM

    ```python
    pip install litellm
    ```

2. Launch LiteLLM proxy for desired LLM

    E.g. Ollama CodeLLama

    ```python
    litellm --model ollama/codellama

    #INFO: Ollama running on http://<IP_ADDRESS>:8000
    ```

3. Create PromptFlow connection to proxy

    ```bash
    pf connection create --file ./my_chatbot/azure_openai.yaml --set api_key="my-fake-key" api_base=http://<IP_ADDRESS>:8000 --name open_ai_connection
    ```

Refer to [LiteLLM Docs](https://docs.litellm.ai/docs/) for more details on setup and usage.

As the author of this documentation, the community may look to you as the expert on this LiteLLM integration. Please consider adding your support contact or linking to the LiteLLM issue tracker so users have a channel for feedback.
For example, you could append something like:
"For issues or questions on the LiteLLM integration, please create an issue on the LiteLLM GitHub repo."
Providing a way to contact you ensures users can get help if they run into any problems following this guide. Since you developed this integration, directing questions your way would be appreciated.


Allow LeftNav to call a function when its open/closed state changes

In an app I'm building, I'd like to keep track of whether or not the LeftNav is currently opened or closed. It is fairly easy to do when opened (as you can call something along with opening the nav), however closing can be done via a few methods (selecting an item, clicking away, etc) that it's not very easy to keep track of.
I was wondering if it was possible to fire a function whenever the opened state of the nav has changed, like onStateChange or something along those lines. It will return what the new state is, like open: (true|false).
Thanks for the great project!

@mmrtnz Would adding two addition function props, "onNavOpen" and "onNavClose" be a reasonable fix?

@BobertForever yes that would be reasonable. They can be called in LeftNav's open and close functions here.

Wow, incredible, thanks :)

Anytime!


Does not install on Raspberry OS 64Bit

Hi,
I tried to install the client on a Raspberry PI 4 (8 GB) with Raspberry OS Lite 64 Bit (2022-09-22). Unfortunately the dpkg call with avsystem_svetovid-21.12-raspberry-Linux-fsdmtool-runtime-python.deb failed (see [1]). The Raspberry was fresh installed.
The installation on the 32 bit variant of the same OS release on the same Raspberry PI 4 went well.
It would be great if you could update debs. Do you still maintain the project?
Best regards
Andy
[1]
pi@actuator:~/Svetovid-raspberry-client $ sudo dpkg -i avsystem_svetovid-21.12-raspberry-Linux-fsdmtool-runtime-python.deb
Selecting previously unselected package avsystem_svetovid-fsdmtool-runtime-python:armhf.
(Reading database ... 96589 files and directories currently installed.)
Preparing to unpack avsystem_svetovid-21.12-raspberry-Linux-fsdmtool-runtime-python.deb ...
Unpacking avsystem_svetovid-fsdmtool-runtime-python:armhf (21.12-raspberry) ...
dpkg: dependency problems prevent configuration of avsystem_svetovid-fsdmtool-runtime-python:armhf:
 avsystem_svetovid-fsdmtool-runtime-python:armhf depends on python | python3.

dpkg: error processing package avsystem_svetovid-fsdmtool-runtime-python:armhf (--install):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 avsystem_svetovid-fsdmtool-runtime-python:armhf

Same issue here.  Need 64-bit.

the LICENSE file says Apache, but - where is the source-code?


Denial of service with array validations?

Based on Zod's README.md and the mentioned libraries using Zod that are linked within that document, I would assume that Zod is designed to be used in potentially highly security-critical situations as a first line of defense against malicious users sending invalid data, i.e., in form validations, when parsing/validating HTTP request bodies, etc. If that is not the case, please (also) interpret this ticket as a request to clearly indicate the intended use cases of the library.
If my understanding is correct, however, I think there might be a security issue around the handling of arrays: Assuming a Zod schema z.number().max(1).array(), parsing the value new Array(1000000).fill(5) yields 1000000 validation errors, taking safeParse 3 seconds to generate the completely useless list of errors. For an array length of 10000000 (one additional 0), the Nodejs process crashes due to an out-of-memory error on my machine.
Is is also possible to generate an array like const a = [1,2,3]; a[1000000000] = 4. In that case, after about 20 seconds (!), safeParse of the same example schema (see above) crashes with an error: TypeError: Cannot read properties of undefined (reading 'status')  at ParseStatus.mergeArray (.../node_modules/zod/lib/helpers/parseUtil.js:62:19).... The huge computation time during which the entire Nodejs main thread is blocked is obviously problematic. The error that is thrown seems unintentional, i.e. this might even be a Zod bug and the<PHONE_NUMBER> error messages should have been reported.
By the way, I used the lastest version of Zod, 3.20.2, for my tests.
Now, you could say that there should be other lines of dense against such attacks, such as the maximum request body size. You could also use the array schema's length function to restrict the maximum allowed array length (if there is some meaningful upper bound for your particular use case). And all of that is true, but it violates the secure by default/by design principle.
As asked above, isn't the point of Zod that I can just pass it some data that I want to ensure to have a certain shape/schema? So are my findings above the intended behavior of Zod? Other issues like #1403 seem to suggest that Zod's design explicitly wants to return all errors to the user, which is clearly undesirable from a security (in particular: availability) perspective. If the behavior is intentional, I don't see how Zod can be recommended for security-critical applications and use cases like the libraries mentioned in the Readme.md. Yes, it doesn't leak data, but it endangers the availability of a system since it facilitates denial of service attacks. This behavior might be surprising to users; it clearly was surprising to me.
The fact that this project doesn't even seem to have a security policy defined (at least none that I could easily find; I expected to find it here) also doesn't look like security is a primary concern. I would have preferred to not report this (potential) issue publicly in a GitHub issue.

Maybe we should check for status === 'dirty' after length checks and stop parsing if array length was erroneous (not continue and check each individual array item)?
.. or provide an parse option that behaves like that.
If this is reasonable, we could also suggest (for concerns brought in this thread, and for general batch processing use cases) to always limit array length.

any updates of the discussion? seems this issue lack of attention.

I'd encourage this to be merged as well - seems like a pretty simple and quick addon. And it would save major headaches in chaining if we could prevent refine/superRefine from running (especially if we're querying dbs) if a simple chained error pops first.

Hi, any updates on the issue?

This seems to be a critical issue, yet lacks attention


[test] Revert "[test] Remove CPU=i386_or_x86_64 hack."

Swift master uses LLVM swift-4.0-branch, which does not yet have
the lit change implementing this syntax.

@swift-ci please test

@swift-ci please test


Iteration through search results is broken

To reproduce:

search for "Canada" and limit collection dates to last three weeks (2022-11-16 as of today)
when search results are rendered, use "Next" button to click through highlighted beads
iteration breaks after attempting to step from 3rd to 4th result

Snippet from console:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'scrollIntoView')
    at select_working_bead (search.js:443:16)
    at HTMLButtonElement.<anonymous> (covizu.js:482:9)
/api/cid/EPI_ISL_15930625:1          Failed to load resource: the server responded with a status of 503 (Service Unavailable)
/api/cid/EPI_ISL_15930384:1          Failed to load resource: the server responded with a status of 503 (Service Unavailable)
search.js:443 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'scrollIntoView')
    at select_working_bead (search.js:443:16)
    at HTMLButtonElement.<anonymous> (covizu.js:482:9)
style.css:1          Failed to load resource: the server responded with a status of 503 (Service Unavailable)
gisaid.css:1          Failed to load resource: the server responded with a status of 503 (Service Unavailable)

I wrote the issue shortly after encountering the error, so that timestamp should be pretty close.

New data files were uploaded to the web server at ~9 am today.

I was looking at the wrong time before. New files were uploaded at 13:31 today, which was around the time the issue was opened

Ok then that's a likely explanation.  Would it be possible to have a 503 response trigger a pop-up for the user to know that the server is being updated and is temporarily unavailable?


Upgrade SLF4J

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage remained the same at 100.0% when pulling aeabe9c5b198b46cbed44a2b4b116b5f14a3f508 on slf4j into 7295f766faf1af5185cc1a9c47621f9faffd1fe2 on main.


Feature/lookup and list

This PR adds the ability to use the lookup endpoint, as well as adds some detail to the security policy list.
Both of these are in support of a cli tool I'm writing in my main branch.
Feeback appreciated, happy to contribute here following your guidelines :)
I'd be very interested to know
a) why the repo seems to avoid unmarshalling into objects directly? I wanted to go that route w/ the security rule objects, but that would be a change in behavior from the rest of the repo.
b) if there's any kind of test suite I can run

Hi @stobias123 ,
Thank you for contributing to Terraform FortiOS provider.  /api/v2/monitor/firewall/policy-lookup is monitor API. Monitor APIs are stateless, and we do not provide resources for stateless APIs. It will violate Terraform's purpose https://www.terraform.io/docs/language/state/purpose.html, and may make user confusing.
For monitor APIs, we have a solution of using generic resource: https://registry.terraform.io/providers/fortinetdev/fortios/latest/docs/resources/fortios_json_generic_api. We encourage user using this generic resource to handle monitor APIs to keep Terraform FortiOS provider's consistence.
As for your question a, please check here: https://github.com/fortinetdev/forti-sdk-go/blob/master/fortios/sdkcore/sdkutils.go#L36. If this isn't what you mean, I would appreciate it if you could give me some details of your question. And for question b, we do not have public opened test suite specialized for SDK. But we do have some test cases under terraform-provider-fortios repo (https://github.com/fortinetdev/terraform-provider-fortios/tree/master/fortios), hope this could answer your question.
Thanks,
Xing

This is just a go library for interacting with the api... this pr isn’t
requesting or suggesting including it in the terraform provider.
Any reason not to include this given that perspective? I have downstream
projects that could benefit.
On Thu, Aug 5, 2021 at 4:31 PM lix-fortinet @.***>
wrote:

Closed #5 https://github.com/fortinetdev/forti-sdk-go/pull/5.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fortinetdev/forti-sdk-go/pull/5#event-5120188738, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEQGVM6PEC3QYHIDU7D2RTT3MNO5ANCNFSM5BIZGFSQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hi @stobias123 ,
Thank you for your question. forti-sdk-go is imported and used by Terraform FortiOS provider. Any change on forti-sdk-go may affect the functionality of Terraform FortiOS provider. So we treat it very carefully to avoid confusing other users.
Thanks,
Xing

@lix-fortinet  - If this function isn't implemented in the terraform provider how could it impact the code?
Really would be nice not to have to maintain a whole separate fork to get additional functionality out of this sdk.

Hi @stobias123 ,
Thank you for your question. We are so sorry that we could not merge your code into the main branch, since we need to keep the consistency with Terraform FortiOS provider. You are very welcome to fork our code and personalize it based on your own working scenario. We really appreciate your understanding and supporting.
Thanks,
Xing


Enable copying practice proposals as real proposals

Apparently some people (understandably) fill in the practice portal as if they were filling in a real proposal. It would be more efficient if they can copy that practice application and submit that.

Fixed in<PHONE_NUMBER>44dd61056fc253afdabea8d43330ea


Support reading external hudi table

Hudi is a rich platform to build streaming data lakes with incremental data pipelines on a self-managing database layer, while being optimized for lake engines and regular batch processing.
We should give more abilities to Starrocks in data lake analytics scenario.
Here is a parent issue for work plan about reading hudi data as a external table like hive.

[ ] read copy on write table
[ ] read merge on read table
[ ] get table meta from hive and file system
[ ] get table statistics for CBO
[ ] incremental query

@imay @dirtysalt @DorianZheng @caneGuy @Ielihs

@miomiocat This is an exciting feature. Do you have some project milestone?

@miomiocat This is an exciting feature. Do you have any project milestone or roadmap?

Full feature support will be divided into 3 milestones and implemented in the following order:

support copy on write table
support copy on write table
support hadoop catalog

@miomiocat This is an exciting feature. Do you have any project milestone or roadmap?

Full feature support will be divided into 3 milestones and implemented in the following order:

support copy on write table
support copy on write table
support hadoop catalog

1 and 2 is the same? may be you mean '2. support mor table'? right?  @miomiocat

@miomiocat This is an exciting feature. Do you have any project milestone or roadmap?

Full feature support will be divided into 3 milestones and implemented in the following order:

support copy on write table
support copy on write table
support hadoop catalog

1 and 2 is the same? may be you mean '2. support mor table'? right? @miomiocat

yes, sorry for typo

what's the feature support hadoop catalog? Does it mean support hudi table that meta is stored in hadoop?

what's the feature support hadoop catalog? Does it mean support hudi table that meta is stored in hadoop?
Thank you for your attention.

Currently, Starrocks obtains all of table/partition statistics from hive metastore to do CBO tasks for Hive/Hudi external table and there are no APIs to extract related statistics in hudi like iceberg.
The term of hadoop catalog is more like iceberg's, We hope starrocks can read external table efficiently without external meta system like hive metastore to make the whole data lake framework more general.
Welcome to participate in community building of Starrocks and we can discuss more about this topic.


I want to see all keyboard shortcuts that are not assigned so I know which shortcuts I can pick from

I want to be able to quickly determine what keys and key combinations are available for assignment in VS Code instead of trying dozens of combinations to find out they are already assigned to a different editor function.

I think it is not possible to get all unassigned keys. @alexdima Not sure if it is?


Within State total count is less than showing count.

Within State total count is not showing proper.

Expected:- State Count should be show summation of all district

API is not working properly

Nothing we can do about it here


Add test cases for JSON resource marshaling

Resource Covered :

InstallationRepositoriesEvent
TeamEvent
StarEvent
TeamAddEvent

Helps with issue: #55

@sagar23sj - either you can resolve the conflicts or I can - either way is fine with me, please just let me know.


Update Dockerfile on the humble branch to use ROS humble

Description
The backport in https://github.com/ros-planning/moveit2_tutorials/commit/e292e4da088420c41269e5301be132a1ca9661ca set the ROS_DISTRO to rolling for the humble branch, which would probably cause issues for users who are trying to go through the MoveIt2 tutorials with MoveIt2 humble. This PR sets the ROS_DISTRO to humble in the Dockerfile so that if users decide to use the Docker setup for the humble tutorials, ROS_DISTRO matches the MoveIt2 version.
Checklist

[x] Required by CI: Code is auto formatted using clang-format
[x] While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@MikeWrock CI / humble-source is failing, and I'm not sure why. The error messages in GitHub actions mention struct planning_interface::MotionPlanResponse, but in humble, it looks like the PlanningComponent::Plan API call returns a PlanSolution struct instead. In rolling, the PlanningComponent::Plan API call does appear to return the planning_interface::MotionPlanResponse struct: https://github.com/ros-planning/moveit2/blob/00e10bbebdbef336aacd66fce3f2593844aee834/moveit_ros/planning/moveit_cpp/include/moveit/moveit_cpp/planning_component.h#L199-L201
So, it seems to me like the error stems from rolling code still being used somewhere. I tried modifying https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/docker-images.yml#L12 to only build humble and not rolling, but I am still seeing the same CI failures. It also looks like humble is used in the industrial_ci for this action (https://github.com/ros-planning/moveit2_tutorials/blob/adlarkin/humble_docker_version_fix/.github/workflows/ci.yaml), so I am not sure what is causing this issue at the moment.

I am going to close this PR - it turns out that for the CI builds that build and push updated tutorial Docker images, the ROS_DISTRO is correctly being set via a build arg (notice how there are build args for both rolling and humble, which means that a humble and rolling image will be built and pushed). The real issue here that's causing some of the humble Docker images to actually have rolling installed is upstream (https://github.com/ros-planning/moveit2/pull/2035#issuecomment-1480082496). Once the upstream issue is resolved, we will probably need to re-build the tutorial Docker images since they depend on the upstream Docker images.
I have created an issue so that we can track the progress of getting the tutorial images fixed: #646


Wrong result for rangeCardinality

I noticed a wrong result when calculating the cardinality of a bitmap using rangeCardinality.
I was able to reduce it to the following failing test case:
RoaringBitmap r = new RoaringBitmap();
r.add(66236);
Assert.assertEquals(1, r.rangeCardinality(60000, 70000));

I executed the test on the current master branch: fe261ccfdb0cd27dfbbd81a329d4924e0499344d

Thanks for the report.


kakoune: add philiptaron as maintainer to most kakoune-related things

Description of changes
I'd like to step up and help maintain the Kakoune editor and its plugins and related tools.
Things done

[x] Fits CONTRIBUTING.md.

Would be good to add yourself to the codeowner of pkgs/applications/editors/kakoune, but it's up to you

My understanding is that I can't add to codeowner until I'm a committer, which as of today I'm not. Someday!

Oh didn't know that!

Would be good to add yourself to the codeowner of pkgs/applications/editors/kakoune, but it's up to you

In the interim, I ascended. Added.


Add patient language preference

Related Issue or Background Info

Resolves #1196

Changes Proposed

Adds migration and field on backend (as string)
Adds field on frontend as string union
Not sure if we need stricter validation on the backend for this field

I'd like to talk about this, actually—we now have testResultDelivery and preferredLanguage as columns on the person table, with both being saved perpetually as part of the time-of-test record (which seems a bit odd). These seem like, well... preferences. Not part of the person. Though obviously the preferred language is something we would expect staff to always have access to (maybe not so much the preferred results delivery?).
So, question for folks: do we need to split these things out of the person table? If not, how many more non-demographic objects to we add before we do need to?

@benwarfield-usds That's a great question. Pulling these fields off of Person simplifies the maintenance of them, and I'd rather do it sooner than later if it's going to result in some number of TestEvents existing in production with serialized Persons that have extraneous fields on them, persisted as an audit in perpetuity.
This also impacts Tribal Affiliation, but not Multiple Phone Numbers, which are the other bodies of work in-flight that affect Person. I'll follow-up on Slack to talk about the "how" & preferred data model

@benwarfield-usds:

This looks sane, but we might want to be a little more cautious with the migration ... It's pretty easy to just not run the drop-column migration yet.

This is exactly what I've done for now; it ensures backwards compatibility in the event of a software rollback, and it will be plenty clear enough in a future release to remove the comments on that changeset to let it roll

Sigh. In smoke-testing this before merging it, I've come to realize that testResultDeliveryPreference is propagated into the provider view, in the front end, via GetFacilityQueue. Adding the getTestResultDelivery field onto that query results in exactly the N+1 issue that we added comments to warn about, so even before #1290 this ticket still requires a little bit of rejiggering before it can be merged


custom home tab sample

I found out that we already support custom dashboard home tab while trying to add this feature. :)
add a sample for it.

also fixed an issue I found while working with the sample providers, I need to pass in unique ids for the connections.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.006%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26507

Relevant Lines:
57181

💛  - Coveralls


As an Administrator/API user I want to be able to Delete Dictionaries and all content therein

Consider return of HTTP call.
Process could be long-running, so 202 seems appropriate, but this would need to be delegated to a background thread.
https://stackoverflow.com/questions/2342579/http-status-code-for-update-and-delete

Appears to be working, but Hangfire Dashboarddoes not work when using Static Files.

Suspect use of static files is also responsible for Swagger UI also failing.

Possibly not, Swagger UI works locally.


Add readinessProbes for envoy proxy deployment

Description:
Envoy-gateway should add readiness probes in envoy proxy deployments to allow in-place upgrades(and proxy configurations) without traffic drop. Without any readiness probes, the proxy is immediately marked ready for traffic. This leads to traffic drops in case of in-place upgrades or proxy configurations.
Steps to reproduce:

Install EG with quickstart yaml and configure multiple replicas using EnvoyProxy configuration:

apiVersion: gateway.networking.k8s.io/v1beta1
kind: GatewayClass
metadata:
  name: eg
spec:
  controllerName: gateway.envoyproxy.io/gatewayclass-controller
  parametersRef:
    group: config.gateway.envoyproxy.io
    kind: EnvoyProxy
    name: custom-proxy-config
    namespace: envoy-gateway-system
---
apiVersion: config.gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: custom-proxy-config
  namespace: envoy-gateway-system
spec:
  provider:
    type: Kubernetes
    kubernetes:
      envoyDeployment:
        replicas: 2
        pod:
          annotations:
            custom: deploy-annotation

Check that pods are ready and traffic is getting routed
Generate continuous traffic for quickstart backend service.
Change the annotations in EnvoyProxy configuration to custom1: deploy-annotation1

Expected Behaviour:
No traffic drop as the gateway has replicas, and rolloutStrategy is configured on gateway deployment.
Current Behaviour:
Traffic drops due to pods not being ready to receive traffic.

hey @psinghal20 thanks for highlighting this work item.
Instead of using the admin-add:admin-port/ready endpoint which is not accessible due to security reasons, which eats up CPU from the main thread either affects other endpoints on that port, another option is to create a custom ready-port and use a health check filter to  achieve the same.
above is how emissary solved it  https://github.com/emissary-ingress/emissary/pull/4300
@kflynn @AliceProxy @LanceEa @haq204  for any additional advice
this does introduce platform complexity of one more port that needs to be opened
above static resources would in here https://github.com/envoyproxy/gateway/blob/main/internal/xds/bootstrap/bootstrap.yaml.tpl

@arkodg - I left a comment on the PR, generally speaking it all looks good. I just had one comment around IPV6 Only support which might not be a concern for now but thought I would raise it up.

thanks for looking into the design @LanceEa, hoping the Ipv6 piece gets addressed as a whole feature set in the future


Fix GLES3 multimesh rendering when using colors or custom data

Fixes https://github.com/godotengine/godot/issues/71897

OpenGL compatibility renderer compresses the 4-float instance color and instance custom data into 2 floats each, which means that if you only use color OR custom data the component count given to glVertexAttribIPointer() will be wrong. This causes the last rendered element to access data outside the instance buffer and the value it will try to read will be invalid (or it might crash your driver if you're unlucky).
This PR adjusts the component count to use 2 if only color or custom data are used. If both are used, the count will be 4.

Good catch, the demo project didn't test that scenario so I missed that. I think the additional fix should be pretty simple, but I'll test this some more.

Thanks!

Cherry-picked for 4.1.2.


example code

Hi,
I am new to Rust, I was not able to understand it properly. Is there an example code that I can refer to?
I have used bvh crate and it seems to work fine, but I also want to test this approach.

I had an example in the readme, but it seems like it was outdated. I updated the example there and made sure it compiles. I also expanded the README a bit to explain some of the less obvious design details (like the support of multiple bounding volume types, and the use of bevy_math) of the crate.

Thanks a lot!


The Linf version

Hi, I am glad to learn from this interesting work. I got one question here. In attack.py Line#238, why do you add deltas on the variable, x_curr, instead of x_best_curr? Thanks a lot.

Hi,
Because here we define deltas as deltas = x_best_curr - x_curr. So it is the difference between x_best and x for some particular indices idx_to_fool.
And what we do here, we modify this difference  to be +eps or -eps in some square-shaped region.
I think it's a bit confusing that in the code we call as deltas the adversarial perturbation, while in the paper delta rather refers to the sampled update:

Sorry for this discrepancy :) I guess it can lead to some confusion.
I hope that helps.
Best,
Maksym

Okay, I got that. Thanks for your kind reply.


Select dark variant of a theme (data-bs-theme="dark")

Is there a way to toggle between dark and light (data-bs-theme="dark") instead of chosing a different theme with ThemeSwitchAIO?
https://getbootstrap.com/docs/5.3/customize/color-modes/

Hi @jzju
This is an exciting new feature in Bootstrap 5.3 that has a lot of potential for Dash apps.
I was hoping that it would be as simple as wrapping the layout with an html.Div with  data-bs-theme="dark" or data-bs-theme="light"
In Dash it's possible to add data-* props to html components, although I don't think it's documented.  It looks like this:
html.div(
    id="theme",
    **{"data-bs-theme": "dark"}
)

And it's even possible o update the data-bs-theme prop in a callback
app.callback(
    Output("theme", "data-bs-theme").
    ...

However it didn't work "out-of-the-box".  I have some ideas about how to fix it though, so I'll be working on this.  Thanks for the suggestion! :slightly_smiling_face:

Running this seem to work for everything except plots:
document.documentElement.setAttribute('data-bs-theme', 'dark')

oh, interesting. I wouldn't expect it to work with the figures, as you would still have to update the figure template in a callback. But for the rest, could you please share a complete minimal working example?

https://dash.plotly.com/external-resources#adding-your-own-css-and-javascript-to-dash-apps

Hi @jzju
The latest release V1.1.0 has figure templates to match  the dark and light color modes.  See the forum post for how to use the Bootstrap color modes in a dash app.
https://community.plotly.com/t/light-and-dark-color-modes-with-dash-bootstrap-components-1-5-0/78810


Particular links is not allowed id: 1365, from: 376, to: 0, type: 3.

Package<EMAIL_ADDRESS>Error:
"message": "Particular links is not allowed id: 1365, from: 376, to: 0, type: 3.",
  "clientErrors": [],
  "networkError": null,
  "graphQLErrors": [
    {
      "message": "database query error"
    }
  ]

@FreePhoenix888 when does this error occurs?

Bug is not reproducible on package installation.


Fail2ban iptables based firewalling does not work

I use ufw but this same problem happens with firewalld.
Based on looking at the nginx access log, I automatically identified and banned IP adddresses from accessing my server. However, bacause the Docker NAT rules giving access to containers and ports precede the other iptables deny rules, the attempt to bar those IP addresses is ineffective.
Details here: https://github.com/moby/moby/issues/4737

With ossec and iptables + docker NAT, I use the following rules to limit traffic on ports 80 and 443 :
/sbin/iptables -N http-flood
/sbin/iptables -I FORWARD -p tcp --syn --dport 80 -m connlimit --connlimit-above 1 -j http-flood
/sbin/iptables -I FORWARD -p tcp --syn --dport 443 -m connlimit --connlimit-above 1 -j http-flood
/sbin/iptables -A http-flood -m limit --limit 10/s --limit-burst 10 -j RETURN
/sbin/iptables -A http-flood -m limit --limit 1/s --limit-burst 10 -j LOG --log-prefix "HTTP-FLOOD "
/sbin/iptables -A http-flood -j DROP

And this works well. It is necessary to add your rules before (iptables -I) docker rules and all in FORWARD chain.
But your issue isn't related to hardware/mailserver, maybe you'll find help on Docker Community Forums.

Thanks. What I want is to have fail2ban and ufw manage the ban list. It certainly was surprising to me to have ufw say that a certain IP was banned and to see their access.log entries later.

Transferring this to me on my repo, since I'd like to have the Ansible setup be a run-and-play solution that sets everything up correctly.

FYI: I added new configuration files set up by the Ansible playbooks so that the fail2ban jails that monitor docker services now use a new  /usr/local/bin/ufw-docker-hack shell script which inserts/deletes banned IP addresses into the DOCKER-USER table in addition to the ufw rules.
This is a hack, but works well in keeping the ability to see what is happening with banned IPs by running ufw status.


webhook: optimize webhook patchResponse function

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm
/approve


Don't flashing esp8266 (NodeMCU V3 Lolin)

Hello! I'am new user esp-rfid. How flashing NodeMCU V3 module ESP8266? My steps:

Connect ESP8266 to computer from USB-port (COM-port (COM5));
Run flash.bat
Choose Flash Generic Firmware and Enter
Chose COM-port - my port is COM5 and Enter
Nothing. In my console write "esptool v0.4.8 - (c) 2014 Ch. Klippel<EMAIL_ADDRESS>after console is closing.
What i can do?

I have solution

And what is this solution?
Mine will not work after flashing :(


Error handler can't skip certain malformed string values

I'm trying to get JSON.NET to skip errors in properties when deserializing.  I have a string property that represents a path name. If the user forgets to escape backslashes in the path, Json.NET cannot successfully skip the error.
Specifically, when handling the first (expected) error, Json.NET hits a second error (inside its handler for the first) and this causes DeserializeObject to return null, instead of returning an instance of my object with the bad property skipped.
Source/destination types
        class TestClass
        {
            public string Foo { get; set; }
        }

Source/destination JSON
{
    "Foo" : "d:\aTest"
}

Note that the backslash here is not escaped. That is the error I'm trying to catch and ignore.
Expected behavior
DeserializeObject should return an instance of TestClass with the property having its default value.
Actual behavior
DeserializeObject returns null. Here's some output, with some logging/dumps of errors included:
Note

Correct callstack from the first error
The second error happens inside JsonSerializerInternalReader.HandleError, so this second error is NOT caught in the JSON.Net code like the first one was.
DeserializeObject returns null.

Newtonsoft.Json.JsonReaderException: Bad JSON escape sequence: \a. Path 'Foo', line 3, position 16.
   at Newtonsoft.Json.JsonTextReader.ReadStringIntoBuffer(Char quote)
   at Newtonsoft.Json.JsonTextReader.ReadStringValue(ReadType readType)
   at Newtonsoft.Json.JsonTextReader.ReadAsString()
   at Newtonsoft.Json.JsonReader.ReadForType(JsonContract contract, Boolean hasConverter)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)

Newtonsoft.Json.JsonReaderException: Unexpected character encountered while parsing value: r. Path 'Foo', line 3, position 16.
   at Newtonsoft.Json.JsonTextReader.ParseValue()
   at Newtonsoft.Json.JsonReader.Skip()
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.HandleError(JsonReader reader, Boolean readPastError, Int32 initialDepth)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)

Outer object is null

Steps to reproduce

            var obj = JsonConvert.DeserializeObject<TestClass>(json, new JsonSerializerSettings()
            {
                Error = (sender, args) =>
                {
                    Console.WriteLine(args.ErrorContext.Error.ToString() + Environment.NewLine);
                    args.ErrorContext.Handled = true;
                }
            });

            Console.WriteLine(obj == null ? "Outer object is null" : "Outer object has value");
        }

This feature was really designed for serialization type conversion errors. Skipping past errors in JSON syntax is always very hit or miss. The reader has no idea what state it should be in when it hits an invalid char, and can't it recover. You will need to use something else to get the results you desire.


Use iterators to expand chunks when downsample

Signed-off-by: yeya24<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Fix #2542
Changes

Use iterators to expand chunks when downsampling is performed.
Verification

Existing tests should still pass since this is just refactoring.

Would be great to get some attention on this.


Cds 93147

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6617ec5d34a773102b73ee37--harness-developer.netlify.app


Electron 323: allow admins to set permissions to peripherals

Description
Allows admins to set permissions on peripherals during installation ELECTRON-323
Approach
Electron provides apis to set permissions on accessing peripherals in the window web contents session object. We use that to set the permissions.
Learning
https://perzoinc.atlassian.net/wiki/spaces/DES/pages/320897190/Electron+Wrapper+Permissions
https://github.com/electron/electron/blob/master/docs/api/session.md#sessetpermissionrequesthandlerhandler
Blog Posts
N/A
Related PRs
N/A
Unit Tests Results
ELECTRON-323 - Unit Tests.pdf
Spectron Tests Results
ELECTRON-323 - Spectron Tests.pdf
Open Questions if any and Todos

[x] Unit-Tests
[x] Documentation
[x] Automation-Tests

@KiranNiranjan @VikasShashidhar Please review.


Please learn about structs and struct packing (and EVM gas costs in general)

https://github.com/keep3r-network/keep3r-network-v2/blob/cdd28f3da309af9eb18b6abe03ea139155d0aefb/solidity/interfaces/peripherals/IKeep3rAccountance.sol#L27
Start here:
https://docs.soliditylang.org/en/v0.8.11/internals/layout_in_storage.html
https://fravoll.github.io/solidity-patterns/tight_variable_packing.html

Hey @boringcrypto ! Please expand on the possible ways to improve the Keep3r Network, it would be very constructive.
As of now, I will proceed to close this issue.


cycle detection inconsistent

If you have a cycle in your package dependencies, bosh create release will tell you you have a cycle (and nothing more). If you comment out the cycle detection in bosh_cli-1.5.0.pre.676/lib/cli/dependency_helper.rb then create release will complete normally, and then upload release will fail, telling you that you have a cycle. However, this time, it actually tells you what the cycle is, which is extremely helpful.
It is worrying that the cycle detection code has been reinvented rather than abstracted out.
Even more helpful than telling you what the cycle is in both places, would be telling you what all the cycles are - it's annoying to fix a cycle only for create+upload to fail again on the next one. Obviously, it's more work, but in general, detecting as many errors as possible at once and reporting them all is preferable to stopping and reporting on the first error you find. More info is always better, in general.

Closing - upcoming CLI is written in Go so there is no longer potential shared Ruby code that can be refactored. The gobosh CLI does not do any special parsing of package dependencies, so all cyclical dependency checks end up happening on the director and a verbose error is given.


Revert "Work around macro expansion bug in 2024-4-1 toolchain."

This reverts commit 95b3df5fa401f0b4a2f395abf46b11b2371aa6dc.
Yesterday's toolchain (2024-01-07) resolves rdar://120559184 with https://github.com/apple/swift/pull/70740, so we don't need the workaround anymore.
Checklist:

[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.

@swift-ci please test


Remove extraneous logging and bump version

This is fine, but can haz rebase against master?

yes you can haz


[feature request] save API key?

Just found out alpha_vantage, and installed python module.
Not sure if i rushed to post this issue, but here i go:
Wouldn't be more elegant to save API key with some function like alpha_vantage.setAPIkey("apikey")
?
Quandl does this, and it's quite nice, not having to enter api key each time.
quandl.ApiConfig.api_key = "YOUR_KEY_HERE"
not sure where quandl saves the key though
anyway,
is this feature present in alpha_vantage?
I've looked around, but found nothing about this

Hi @ifmihai the feature is not present. Maybe I could implement it (I am kinda busy with other projects ATM but I could lok at the best way of doing this later) what I do and should work for you (many people do it this way) is to save the key as an environment variable and use it as os.environ["API_KEY"] for example. You can check how to set environment variables in your operating system of choice. If you fancy tackling the problem yourself I am always happy with pull requests ;)

@RomelTorres Do you think the best way of doing this would be to add the option of storing the API key in a configuration file?
We could use the configparser module; I have tested compatibility using 2.7.12 and 3.6.4, both work well.
I would be happy to implement this if so.

@addisonlynch Thanks for the response, that makes sense.
Based on this, do you think it would be worth adding a check for a specific environment variable, e.g. AV_API_KEY or ALPHA_VANTAGE if no key is specified? This should provide a more convenient way of storing the API key if users want it.
@RomelTorres

@Rishk exactly! Here's an example implementation that I used for the Pandas Datareader AV reader:
https://github.com/pydata/pandas-datareader/blob/da18fbd7621d473828d7fa81dfa5e0f9516b6793/pandas_datareader/av/__init__.py#L17-L29
I can create a quick pull which will take care of it, if that works.


Add ability to track application revision history in CSV export

Is your feature request related to a problem? Please describe.
Seattle has found that applicants frequently need to revise their applications. It is difficult for program admins to track these duplicate applications across multiple revisions and determine if an application is a new application or a revision of an existing one.
Below, I use "revision set" to describe the set of all revisions of an application by an applicant.
Describe the solution you'd like
Adding some additional fields to the CSV export could help clarify the relationships between applications.

revision_state, which is either OBSOLETE or CURRENT. It is currently in the JSON export, we have #5390 open as well. This is only marginally useful, as it doesn't help differentiate between "this is the first and only application" and " this is the most recent of several applications"
revision_set could be a unique ID given to a set of revisions. Every application in the set would share the same revision_set.
initial_application_id could be the ID of the initial application. If the application_id and the initial_application_id are the same, you're looking at the first application of the set. Every application in the set would share the same initial_application_id.

Some other ways of finding these relationships include:

In the destination data system, grouping by program and applicant_id and sorting by submission_time desc will find the most recent application in the revision set. There's only ever 1 revision set per applicant per application.

Questions

If someone upgrades their application to the newest version of a program (a feature we're considering) should that be a new application or stay as part of the set?

@msprenke reports that for program admins, if it's part of the same program it's part of the same revision set, even if the program has been updated.

Additional context

#1731 fixes a bug with the submission time, but this will only work going forward. Historical submission times were overridden when a new draft was created.
#5390 covers adding the revision_state column to the CSV.

Next Steps
As this effects the data export, the next steps are to write a quick TDD a bring it to the governance committee.

This is related to https://github.com/civiform/civiform/issues/4022 to provide the same distinct indicator on the Applications Screen that a program is an edit.


camelize comment typo

one comment about camelize function,
which can be found in this line
/**
 * Camelize a hyphen-delmited string.
 *
 * @param {String} str
 * @return {String}
 */

Did the delmited word mean the delimited ？

Yes, it does. If you could submit a PR for this, that'd be great 😄

ok, i submit a PR, you can check it. Thanks!

Thanks, don't worry about that 😉


Fix logo

make sure svg text is displayed the same on all systems. thus have 2 svgs: one raw (for inkscape) and one for display.

Codecov Report

Merging #139 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #139   +/-   ##
========================================
  Coverage    68.44%   68.44%
========================================
  Files           11       11
  Lines         1090     1090
  Branches       256      256
========================================
  Hits           746      746
  Misses         307      307
  Partials        37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0487fc...1dccc34. Read the comment docs.

see also #133


Add Patch for VTK mfc (windows) capability

Thanks for this PR, @MouhammadEV! I see that you suggested this workaround in PR #4661. That PR mentions that this issue is fixed in VTK 8.2.0, which was not released at the time. VTK released 8.2.0 a week ago, so would updating VTK fix this issue without the need to patch this call?

Yes. I think, updating VTK would fix this issue without applying the patch.

Closing the PR because it was decided to move to the 8.2.0 release of VTK rather than apply the patch - which looks like it is already in progress in your other PR #4661.


helix: fix build with clang 16

Description of changes
Fix an implicit int error in one of the tree-sitter grammars.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks!

Not sure why but this broke the build at least on darwin x86:
error: builder for '/nix/store/nzs5j2qxl59kfic0x0rm7bbjjaj5n625-helix-23.10.drv' failed with exit code 101;
       last 10 log lines:
       >   /private/tmp/nix-build-helix-23.10.drv-0/source/runtime/grammars/sources/rescript/src/scanner.c:184:10: warning: unused variable 'is_unnested' [-Wunused-variable]
       >       bool is_unnested = state->parens_nesting == 0;
       >            ^
       >   1 warning and 1 error generated.
       >
       >
       >   --- stderr
       >   thread 'main' panicked at helix-term/build.rs:7:14:
       >   Failed to compile tree-sitter grammars: 1 grammars failed to build
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       For full logs, run 'nix log /nix/store/nzs5j2qxl59kfic0x0rm7bbjjaj5n625-helix-23.10.drv'.
       ```

Not sure why but this broke the build at least on darwin x86 with home-manager

Can you check the log further up to see what the error was and post that? That warning isn’t the source of the failure.
FWIW, I tried building both from master and nixpkgs-unstable, and helix builds for me.
$ nix build 'github:NixOS/nixpkgs#legacyPackages.x86_64-darwin.helix'
$ nix-store -qR ./result
/nix/store/0ly5lpwanagc5qpmnqrw8aqxb4ivw7kf-bash-5.2-p15
/nix/store/4j38m9c97qzf7zhamm7i7gyrgbikcfhn-libiconv-50
/nix/store/pka340xbqzk4r46si0hjkadk00c69a18-libcxxabi-16.0.6
/nix/store/x4s0wi6d2z38wa0jb4yf769sl1c0c50z-libcxx-16.0.6
/nix/store/pcms9c977cgfgiynxgxk14ipyaiz6g0g-helix-23.10
$ nix build 'github:NixOS/nixpkgs/nixpkgs-unstable#legacyPackages.x86_64-darwin.helix'
$ nix-store -qR ./result
/nix/store/0ly5lpwanagc5qpmnqrw8aqxb4ivw7kf-bash-5.2-p15
/nix/store/4j38m9c97qzf7zhamm7i7gyrgbikcfhn-libiconv-50
/nix/store/pka340xbqzk4r46si0hjkadk00c69a18-libcxxabi-16.0.6
/nix/store/x4s0wi6d2z38wa0jb4yf769sl1c0c50z-libcxx-16.0.6
/nix/store/pcms9c977cgfgiynxgxk14ipyaiz6g0g-helix-23.10

I concede it's weird because it builds fine when I do nix build nixpkgs#helix but when I add it to my home-manager config (there is a built-in [programs.helix.enable](https://nix-community.github.io/home-manager/options.html#opt-programs.helix.enable)) I get the error. Could you try that maybe?
Here is the full error:
162 grammars built now
        ["astro", "awk", "bash", "bass", "beancount", "bibtex", "bicep", "blueprint", "c", "c-sharp", "capnp", "clojure", "cmake", "comment", "cpon", "cpp", "css", "cue", "d", "dart", "devicetree", "dhall", "diff", "docke>
  Failure 1/1: rescript Parser compilation failed.
  Stdout:
  Stderr: /private/tmp/nix-build-helix-23.10.drv-0/source/runtime/grammars/sources/rescript/src/scanner.c:134:9: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit->
    const in_string = state->in_quotes || state->in_backticks;
    ~~~~~ ^
    int
  /private/tmp/nix-build-helix-23.10.drv-0/source/runtime/grammars/sources/rescript/src/scanner.c:184:10: warning: unused variable 'is_unnested' [-Wunused-variable]
      bool is_unnested = state->parens_nesting == 0;
           ^
  1 warning and 1 error generated.

  --- stderr
  thread 'main' panicked at helix-term/build.rs:7:14:
  Failed to compile tree-sitter grammars: 1 grammars failed to build
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It might be a coincidence but I figured since the error originates from the patched file and they didn't update that derivation in home-manager since I had it working, it must be related.

Oh wait is it because home-manager doesn't include this patch? So weird that I could build fine a few days ago...

I concede it's weird because it builds fine when I do nix shell nixpkgs#helix but when I add it to my home-manager config (there is a built-in programs.helix.enable) I get the error. It was building fine before the patch with home-manager. Could you try that maybe?

If I set programs.helix.enable in my Home Manager config and build it, it builds successfully.

It might be a coincidence but I figured since the error originates from the patched file and they didn't update that derivation in home-manager since I had it working, it must be related.

Is [this][1] your flake? It has Home Manager following nixos-unstable. nixos-unstable is behind master and nixpkgs-unstable, so it doesn’t have the fix in this PR yet. nix shell would work with that flake because nix.registry isn’t being set up for Darwin, and the default for nixpkgs is github:NixOS/nixpkgs/nixpkgs-unstable, which does have the change.

Okay I think I get it. It should be fixed once nixpkgs-unstable gets this patch and the problem probably appeared when I updated macOS today. Sorry for the confusion! I'll try again in a few days

Okay I think I get it. It should be fixed once nixpkgs-unstable gets this patch and the problem probably appeared when I updated macOS today. Sorry for the confusion! I'll try again in a few days

If you switch to nixpkgs-unstable, Helix should build, but that may cause issues with NixOS since something is presumably preventing the nixos-unstable channel from advancing.

I'm actually not using nixOS at the moment so should be fine to switch, thanks!


Latest Report

This report should show just the latest results in a radar chart

 Single point report

I have been rethinking this idea. Instead of offering a latest report, another option would be to allow users to specify a minimum number of records for the report. By selecting 1, all records will be included. However, the distance travelled would no longer be valid. Warning messages should be shown when selecting 1 and when viewing a report with a setting of 1 min record.
Something like:
Warning: Including beneficiaries who only have a single record means the distance travelled analysis is not valid. However, setting a minimum of one record can be used to view intermediate results before two records have been completed.
Warning: This report includes beneficiaries with a single record. In this case, the initial and latest records will be the same record and hence there will be no distance travelled. This report should only be used to view the aggregated initial or last record, and not used to assess distance travelled between initial and last.

Not pursuing any longer. Impactasaurus is about longitudinal data analysis not one off questionnaires. If users need that, they could use popular tools like google forms, typeform and survey monkey.


Manifest entry for main class & dependencies missing in jar

Would be nice to have a single jar with all dependencies and manifest entry for main class.
I have implemented this in my fork. (See upcoming pull request)

Hi @SvenEwald thanks for your interest but this project is not expected to be used as day-by-day client is just a sample on how to use the library, there no reason why we should build this as a single jar.
Our internal client implementation include certificate deployment, encrypted certificate storage, automatic renewal, etc but we currently have no plan into make our internal tool opensource.
Furthermore your pull request is a mess with a commit and rollback of the same code.


Allow bind Webpack to <IP_ADDRESS>

As far I've seen, npm start start webpack serving from localhost:3000.
It would be nice an option to bind IP <IP_ADDRESS> to webpack, like the option --host <IP_ADDRESS> Webpack already accept today.
This is specially useful when starting server from inside a Docker container: even mapping the port 3000 to localhost, Webpack doesn't accepts connections from outside the container.

This will be doable with #128!

Yep, we’ll probably go with #128—just want to make some other things work there first.

#128 should have fixed this.
Will be out in next release.
(We might wait a week before doing it so we accumulate some fixes.)

Ok, thanks for the quick feedback guys.
Outstanding work :)

This should be fixed in 0.2.0 alpha, mind giving it a spin to confirm? Here's how: https://github.com/facebookincubator/create-react-app/pull/190

It seems that it is now public by default but you may have a flag in your package.json {private: true} that you need to set to false.