Plans to drop babel in v3

I have been thinking about this lately, once we dropped node v4 and v6 support in 3.x release, do we still need babel?
My gut feeling is node v8+ are modern enough that all of our code are covered, so there is no value in transpiling (and I want to change back to CommonJS syntax)
https://node.green
If possible I want to drop our build step (rollup) altogether.

I'm on board with that too.

I guess a build step would still be needed as modules are not the same in Node & web.
I ended up using @pika/pack, which is using rollup under the hood. I see it as a polyfill until we can have the same modules work in both, node & browser.
I wrote about my setup here: https://gist.github.com/gr2m/5dd2ec6e3a04c3dc79f0cbb46decbe46

@bitin

My gut feeling is node v8+ are modern enough that all of our code are covered, so there is no value in transpiling (and I want to change back to CommonJS syntax)

The PR https://github.com/bitinn/node-fetch/pull/649 is meant as the first step in this direction. It deals with single exports.
My question is now, what should be the strategy for multiple exports?
A possible way could be to avoid them altogether,
to prevent the modules from doing "too much".
Would that be desired or is some other strategy preferred?

I’m very much onboard with removing Babel. The time has come for that. I still prefer to keep our source in ES module form though. It’s much easier to transform from ESM to CommonJS style than vice versa, and with the dust settling on Node.js’ support for ESM more people would want to use it, rather than relying on CJS-ES interop.

@TimothyGu I hear you, but the status quo seems to be that many bundling tools are better at transforming from CommonJS to ESM? We have had a lot of problem with people trying to package up node-fetch for AWS using Webpack.
(My guess is most of them are confused about how Webpack/ESM work, but my anecdote observation remains that Webpack seem to just work with CommonJS?)
I love the named export from ESM, for sure, just that it seems to cause some troubles for users at the moment.

many bundling tools are better at transforming from CommonJS to ESM

Well I meant like actually transforming the source, rather than providing interoperability. But if that's the difficulty people are having, then I'm all for it :)

@TimothyGu
Just trying to understand, if is there an example of a specific benefit for this project from using CommonJS mixed along with ESM?
If yes, maybe I shouldn't have been wasting my time on
https://github.com/bitinn/node-fetch/pull/649 :)

@dmitriz, I think I'll defer to other people in the thread as I haven't been as active.

Babel and rollup have been dropped in favour of microbundle in 3.x


Add option to show all header lines in article view unwrapped

Since some articles have header lines (title, URL, ...) with one line and others with more, the place of the first line of the article description jumps when reading through the articles. For me, that disturbs the reading flow.
Therefore, it would be nice to have an option which allows the header lines to be shown unwrapped (and truncated) in article view. This also applies to the links at the bottom.
For URLs this may have security implications, as later parts of an URL would be invisible, but for me that would be reasonable.

Hi!
All the entries in the header—feed title, article title, article author etc.—are optional, so lengthy title isn't the only thing that can affect header's "height". Thus, not wrapping the header will only fix part of the problem.
Also, while I can see how this is a problem for the header, I don't understand why should links at the bottom not be wrapped. Right now they kinda aren't—text-width doesn't affect them, they're always wrapped at the screen's border. Can you explain?
The only solution I can think of is to fix the header's "height", but that's lame. Any other ideas?
(Tagging as "question", not "enhancement", because there's no clear path forward on this.)

All the entries in the header -- feed title, article title, article author etc. --
are optional,

I see, didn't know that.

so lengthy title isn't the only thing that can affect header's "height".
Thus, not wrapping the header will only fix part of the problem.

At least, can one assume that the existence of the header items is consistent over all articles in its respective feed? If the header of all articles in a certain feed would take up the same number of lines, by not wrapping long ones, "jumps" in the sense I described above would only occur when switching from one feed to an other. And even that could be avoided by replacing empty values with a string like "<undefined>", if the user desires it.

Also, while I can see how this is a problem for the header,
I don't understand why should links at the bottom not be wrapped. [...]
Can you explain?

You are right, there is no need to not wrap (and truncate) the links at the bottom. Nonetheless, I would vote for not wrapping them for reasons of "optical consistency" between them and the article header. This could be made choosable by the user, too.
Does that answer your question?
I know, I am asking for a lot =:)

At least, can one assume that the existence of the header items is consistent over all articles in its respective feed?

No, because some items depend entirely on the article—its title, its author, its flags, it podcast URL and type; maybe even more, but I didn't check the code.

And even that could be avoided by replacing empty header values with a string like "<undefined>", if the user desires it.

I still find this lame. Firstly, this is a round-about way of solving the problem ("I want the article body to start at the same line every time, so let me pad the header to have a fixed height"). Secondly, I just don't think it's a good idea to make our internal renderer very complicated. I think it should serve the needs of the most, and the rest can use some extension mechanism (like html-renderer) to tweak things to their exact specification.
But article headers don't have anything like html-renderer at the moment.
If I take this idea to the extreme, and mix in #688 for a good measure, it appears that Newsboat needs a templating engine that lets the user decide how to lay out the article. Right now this seems like an overkill to me, but it'll probably solve this whole class of problems.
You did answer my question; thanks. I'm also sorry, because the "optical consistency" argument is dead to me. Newsboat isn't meant to be beholden from the distance—the user is supposed to read what Newsboat displays. So truncating lines just to look pretty gets outright "no".

Thank you for your answer. Your code, your rules =;)
Still, if you ever would think about giving the header(s) a fixed height, it would be appreciated. I get about 400 new articles each day, and with a "motionless" layout the reading experience would be even more enjoyable, at least for me.
You may close this issue now.

Sorry I'm not ready to do anything about this one yet. I'll keep it open, since the problem wasn't solved and I don't consider this a "wontfix".
I won't close #688 either, because I think there is a solution that would satisfy both of us. It's a matter of implementing it now.
Thank you for taking the time to file both of those.


remove "beta" restriction, allow everyone to use the new admin activity editor

┆Issue is synchronized with this Trello card by Unito

Done with #177


Only receiving empty data frames

I used some of your code for my own automations. Originally I was able to grab the pro forecasts and the model data via the API but I haven’t been able to get that working as of a couple of months ago.
When I run your scraper to get the pro forecast data it only returns empty data frames. Is this working for you?

Also your Jupyter test notebook returns an empty array and fails.


[Task] SpringCloudLocalCache task

Description
currently, eureka and nacos has a local cache for service instance,but zookeeper and consul must get node from registry. when can build a local cache for springcloud plugin.
Task List

listener heartbeat and get instances from the registry.
when selector initializing, get instances from the registry.
add unit test for the local cache

pls assign 2 me.

Please assign consul to me


Modified Spanish language

example:
This code "echo Date::now()->format('l j F Y');" should display "jueves, 7 de julio de 2016".

This will mess up other formats though.

What would be the right way to do it? In catalan, romanian and other latin languages happens something similar.


Support PyTorch 1.13.X versions

Loosen the pytorch requirements to support the full range of minor versions under 1.13

We can view on CI that only pytorch 1.13.1 is installed (both 1.13.0 and 1.13.1 were installed before)


fix bugs for parent relationship

as title.
Currently, "update" for parent-child relationship is broken.

@siddontang


Please update GMS notification "Can't work without Google Services" in some app (gmail, happn, dr parking 4)

Huweai P40 Lite
Android 10
EMUI <IP_ADDRESS>
Location Modules
Both network and adress, no modules installed

yeah having the same issue on
Android 10
havoc 3.7

Some how I just install GMS and delete. After that I install microG Apps and deleted again except DroidGuard Helper. Then I install GMS again and installed other apps started to work properly. Now Apps worked but GMS notificating certification error message.

Often "can't work without Google Services", does not refer to Play Services, but Google Play (Store). Do you have Play Store installed?


Feature request: Player pause icon

Players should have a pause icon (the two white rectangles) somewhere around them when they are paused. Their animation should also pause. This would require a protocol update.

This would require a protocol update

that's where you're wrong!
added in next update.

I thought it would :D

It was already internally sent in v0.4.0, but only used to stop interpolation when the player is paused (to stop weird glitches). now it will also show an icon :)


PDF Generator use for .net

Convert The HTML To PDF By PDF Generator
Convert The HTML To PDF By PDF Generator in Projects developed on .net core or Node.

https://github.com/vivifyhealthcare/PDF-Generator-Python/releases/tag/PDF-Generator_v1.1.0
Generate PDF from HTML via Rest API and save the PDF file in configured s3 Bucket


Typo in 8.3.9 footnote 4 (page 195)

4 For this too look nice, we have to “forget” a bunch of parentheses in n according
to the rule ((x, y), z) = (x, y, z).
-> "For this to"

Thanks, @heliagh ! Good spot (and great that you're reading the footnotes ;) )


No background to effects drop down when lights are off

This may be due to the HA theme I'm using, but I've noticed that the drop down for the effects list only has a background applied when a light effect is active. When the lights are off, the background is transparent and the effects list renders over other elements:

I've also noticed that the effects drop down is visible if the light toggle is off. Selecting an effect doesn't enable the light, so I wonder if the effects list should be hidden unless one is active (or perhaps selecting one should turn the light on?)

This could definitely look better, I'll try to improve it!

Are you on 0.9.3 or 0.9.4? Make sure you have 0.9.4, the prior version had a really stupid bug that broke updates of the widget when the state changed.

I was actually on 0.9.2! It seems HACS isn't offering up updates very frequently any more. I'll be sure that I'm running latest before I raise any other issues.
I've updated to 0.9.4 and I can confirm the issue still exists. Best way to replicate it is to close SignalRGB and reload the integration. This is the theme I'm currently using: https://github.com/tgcowell/waves

Thanks! I'll try it with waves later today and see if I can repro it. It doesn't seem to happen (at least for me) on the default or minimal themes.

I've just noticed it's been over a year since that theme received an update, and there have been plenty of front-end changes since then, so it's quite possibly an issue with the theme, rather than this card. I'm happy to close this issue if that's the case.


Correct Version label

Would be cool to have something like labled version releases... would make it much more easy to release in the fdroid!

Will do that in the next release. Thanks for reminding


Some little features/improvements

I have added some very simple features that add new variables and makes the traceback cleaner.

In player.py: load_playtime a new variable called total_time_played_hours (self explanatory):

async def load_playtime(self) -> None:
        data = await self._auth.get(self._url_builder.playtime())
        stats = data.get("profiles", [])[0].get("stats", {})

        self.level = int(stats.get("PClearanceLevel", {}).get("value", 0))
        self.pvp_time_played = int(stats.get("PPvPTimePlayed", {}).get("value", 0))
        self.pve_time_played = int(stats.get("PPvETimePlayed", {}).get("value", 0))
        self.total_time_played = int(stats.get("PTotalTimePlayed", {}).get("value", 0))
        self.total_time_played_hours = self.total_time_played // 3600 if self.total_time_played else 0

In auth.py:  _find_players in case of no results, close the connection before raising InvalidRequest to avoid Unclosed connector exception in the traceback: (this can be applied to every raise in  _find_players and maybe other methods)

async def _find_players(self, name: str, platform: str, uid: str) -> list[Player]:
        . . .
        . . .
        . . .

        if "profiles" in data:
            results = [Player(self, x) for x in data["profiles"] if x.get("platformType", "") == platform]
            if len(results) == 0:
                await self.close()
                raise InvalidRequest("No results")
            return results
        else:
            raise InvalidRequest(f"Missing key profiles in returned JSON object {str(data)}")

Maybe these are worth or useful, lmk what you think

Oh yeah for sure these are all good ideas.
The await self.close() could theoretically be added before every raise to avoid the Unclosed connector exception
I will add all of this once I get home later today (or you can submit a PR if you want 😃)

Thanks!
I made some little fixes and submitted the PR.

Coolio 😄
The new version got published to PyPI a few moments ago and is also available as a release here on GitHub


volume +/- buttons on iPhone is disabled after DBMeter.start

Hi,
I found a problem, once DBMeter.start is called, the volume +/- button on iPhone are not working any more.
Even after DBMeter.stop or .delete is called, still don't work.
Could you please have a check on this?
Thank you for your great work.

Hi! Dude. I also encountered this problem, have you solved it?

@libyenter Have you solved this problem?

having the same issue

Same issue


Outdated documentation on Java API dependencies

The official documentation has outdated information regarding the required library to use the Java API in the following pages:

Graph API
Document API
Object API

orient-commons-*.jar is stated as required but this is not true since version 2.0 as it has been absorbed into orientdb-core-*.jar. This will probably confuse a lot of new users. It should be either be removed or there should be an explanation that it only applies to version prior to 2.0.

You're right, fixed. Thanks.


docs: add disable instructions

What does this pull request do?
To assist support, we're adding disable instructions to each Agent's troubleshooting docs.

Related issues
For https://github.com/elastic/observability-docs/issues/35.

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #893 opened]

Start Time: 2020-07-29T19:48:22.285+0000

Duration: 4 min 40 sec


Units with Kombi-weapon don't have them when imported

Describe the bug
When I import units with kombi-weapons, their is a "missing item" error, and the unit is imported without the weapon
To Reproduce
Steps to reproduce the behavior:

create an army with https://www.newrecruit.eu containing orks with Kombi-weapons
export to .ros
import in foundry
See error

Expected behavior
My troups need to have their weapons

Unfortunately I am currently too busy to work on this module, and expect to remain so for the next couple of months. I recommend manually adding the missing items as a temporary solution.
Also, I would appreciate if you could add the .ros that causes the issue, in case I cannot recreate it by making one myself.

Well, Github don't let me import the file as a .ros, so I'm putting it in this zip: Waaaaaagh.zip


Wrong cursor selection when unfocus - focus on Android 5.1

Description
Hello, I'm working on a TextField to modify an IP address. And I would like to preselect the last digits after the last point when it is focused.
I've already done my code but there is a little problem. When my text is preselected and I press the backspace, the first time it works perfectly and erases the selection. But the other times, after an unfocus and a focus this erases the character before the selection.
I think it's a wrong cursor position. But I don't understand because I defined the affinity to TextAffinity.upstream. You can see an example with the following animation :

Steps to Reproduce
You can reproduce it with the follow code
import "package:flutter/material.dart";

void main() async {
  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text("Test"),
        ),
        body: Page(),
      ),
    );
  }
}

class Page extends StatefulWidget {
  @override
  _PageState createState() => _PageState();
}

class _PageState extends State<Page> {
  final TextEditingController _controller = TextEditingController();
  final FocusNode _focus = FocusNode();

  @override
  void initState() {
    super.initState();
    _controller.text = "<IP_ADDRESS>";
    _focus.addListener(() => _focus.hasFocus
        ? _controller.selection = TextSelection(
            baseOffset: _controller.text.lastIndexOf(".") + 1,
            extentOffset: _controller.text.length,
            affinity: TextAffinity.upstream,
          )
        : null);
  }

  @override
  void dispose() {
    _controller.dispose();
    _focus.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Padding>[
        Padding(
          padding: EdgeInsets.all(10),
          child: TextField(
            controller: _controller,
            focusNode: _focus,
            decoration: const InputDecoration(
              labelText: "Test",
              suffixIcon: const Icon(Icons.router),
              border: const OutlineInputBorder(
                borderRadius: const BorderRadius.all(const Radius.circular(10)),
              ),
            ),
            keyboardType: TextInputType.datetime,
            textInputAction: TextInputAction.next,
            showCursor: false,
            onEditingComplete: () => FocusScope.of(context).nextFocus(),
          ),
        ),
        Padding(
          padding: EdgeInsets.all(10),
          child: RaisedButton(
            onPressed: () => FocusScope.of(context).unfocus(),
            child: const Text("Unfocus"),
          ),
        )
      ],
    );
  }
}

phone details
My phone is a HUAWEI CUN-L21 under android 5.1.

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-2.0.pre.66, on Linux, locale en_US.UTF-8)
    • Flutter version 1.21.0-2.0.pre.66 at /home/mpi3d/flutter
    • Framework revision 54c9441723 (2 days ago), 2020-07-17 18:56:12 -0400
    • Engine revision d327828632
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /home/mpi3d/Android/Sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /opt/android-studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

Hi @MPi3D
Even on multiple tries, i cannot reproduce this issue on Samsung device using Samsung Keyboard and Gboard. Can you please give us details on what device you experiencing this issue? or please try on emulator or device, if it reproduces or not

Code Sample
import "package:flutter/material.dart";

void main() async {
  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text("Test"),
        ),
        body: Page(),
      ),
    );
  }
}

class Page extends StatefulWidget {
  @override
  _PageState createState() => _PageState();
}

class _PageState extends State<Page> {
  final TextEditingController _controller = TextEditingController();
  final FocusNode _focus = FocusNode();

  @override
  void initState() {
    super.initState();
    _controller.text = "<IP_ADDRESS>";
    _focus.addListener(() => _focus.hasFocus
        ? _controller.selection = TextSelection(
            baseOffset: _controller.text.lastIndexOf(".") + 1,
            extentOffset: _controller.text.length,
            affinity: TextAffinity.upstream,
          )
        : null);
  }

  @override
  void dispose() {
    _controller.dispose();
    _focus.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Padding>[
        Padding(
          padding: EdgeInsets.all(10),
          child: TextField(
            controller: _controller,
            focusNode: _focus,
            decoration: const InputDecoration(
              labelText: "Test",
              suffixIcon: const Icon(Icons.router),
              border: const OutlineInputBorder(
                borderRadius: const BorderRadius.all(const Radius.circular(10)),
              ),
            ),
            keyboardType: TextInputType.datetime,
            textInputAction: TextInputAction.next,
            showCursor: false,
            onEditingComplete: () => FocusScope.of(context).nextFocus(),
          ),
        ),
        Padding(
          padding: EdgeInsets.all(10),
          child: RaisedButton(
            onPressed: () => FocusScope.of(context).unfocus(),
            child: const Text("Unfocus"),
          ),
        )
      ],
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-2.0.pre.66, on Mac OS X 10.15.6 19G73,
    locale en-GB)
    • Flutter version 1.21.0-2.0.pre.66 at /Users/taha/Code/flutter_beta
    • Framework revision 54c9441723 (3 days ago), 2020-07-17 18:56:12 -0400
    • Engine revision d327828632
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (5 available)
    • SM M305F (mobile)      • 32003c30dc19668f          • android-arm64  • Android 10 (API 29)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS 13.6
    • macOS (desktop)        • macos                     • darwin-x64     • Mac OS X 10.15.6 19G73
    • Web Server (web)       • web-server                • web-javascript • Flutter Tools
    • Chrome (web)           • chrome                    • web-javascript • Google Chrome 83.0.4103.116

• No issues found!

Thank you

Hi @TahaTesser
My phone is a HUAWEI CUN-L21 under android 5.1 with Android Keyboard (AOSP).
And sorry but I can't try on an emulator because my laptop is not powerful enough and I don't have any other phone.
Sorry

Hi again @TahaTesser
I have installed Gboard on my phone and its working perfectly! So the problem comes from Android Keyboard (AOSP) with maybe doesn't support the affinity parameter.
I let you resolve this.

I can reproduce this issue on Android 5.1 emulator

Code Sample
import "package:flutter/material.dart";

void main() async {
  runApp(App());
}

class App extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: Text("Test"),
        ),
        body: Page(),
      ),
    );
  }
}

class Page extends StatefulWidget {
  @override
  _PageState createState() => _PageState();
}

class _PageState extends State<Page> {
  final TextEditingController _controller = TextEditingController();
  final FocusNode _focus = FocusNode();

  @override
  void initState() {
    super.initState();
    _controller.text = "<IP_ADDRESS>";
    _focus.addListener(() => _focus.hasFocus
        ? _controller.selection = TextSelection(
            baseOffset: _controller.text.lastIndexOf(".") + 1,
            extentOffset: _controller.text.length,
            affinity: TextAffinity.upstream,
          )
        : null);
  }

  @override
  void dispose() {
    _controller.dispose();
    _focus.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Padding>[
        Padding(
          padding: EdgeInsets.all(10),
          child: TextField(
            controller: _controller,
            focusNode: _focus,
            decoration: const InputDecoration(
              labelText: "Test",
              suffixIcon: const Icon(Icons.router),
              border: const OutlineInputBorder(
                borderRadius: const BorderRadius.all(const Radius.circular(10)),
              ),
            ),
            keyboardType: TextInputType.datetime,
            textInputAction: TextInputAction.next,
            showCursor: false,
            onEditingComplete: () => FocusScope.of(context).nextFocus(),
          ),
        ),
        Padding(
          padding: EdgeInsets.all(10),
          child: RaisedButton(
            onPressed: () => FocusScope.of(context).unfocus(),
            child: const Text("Unfocus"),
          ),
        )
      ],
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-2.0.pre.83, on Linux, locale en_US.UTF-8)
    • Flutter version 1.21.0-2.0.pre.83 at /home/taha/Code/flutter
    • Framework revision 9e658bc3d5 (6 hours ago), 2020-07-21 03:56:07 +0200
    • Engine revision dcc9a4048d
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /home/taha/Code/sdk
    • Platform android-30, build-tools 30.0.1
    • ANDROID_HOME = /home/taha/Code/sdk
    • Java binary at: /home/taha/Code/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Android Studio (version 4.0)
    • Android Studio at /home/taha/Code/android-studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.12.2

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android
      5.1.1 (API 22) (emulator)

• No issues found!

Hi @mpi3d, this issue seems to have been fixed on the latest master channel as I cannot reproduce it there. See the demo below.

Demo
https://user-images.githubusercontent.com/104349824/207843592-ca157bee-e10e-4b69-b176-e22cdbf1625e.mov

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.9, on macOS 13.0 22A380 darwin-x64, locale en-VN)
    • Flutter version 3.3.9 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b8f7f1f986 (31 hours ago), 2022-11-23 06:43:51 +0900
    • Engine revision 8f2221fbef
    • Dart version 2.18.5
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 107.0.5304.110

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[!] Flutter (Channel master, 3.7.0-9.0.pre.11, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.7.0-9.0.pre.11 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dbc9306380 (4 hours ago), 2022-12-14 13:53:20 -0800
    • Engine revision 0a6a4a58f4
    • Dart version 3.0.0 (build 3.0.0-21.0.dev)
    • DevTools version 2.20.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

[✓] Connected device (4 available)
    • SM T225 (mobile) • R9JT3004VRJ                              • android-arm64  • Android 12 (API 31)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.2 19H218
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 108.0.5359.98
    ! Error: iPhone is busy: Fetching debug symbols for iPhone. Xcode will continue when iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I'll be closing this issue since it has already been fixed on the latest master channel. If you still experience this issue on the master channel, kindly leave a comment below and I will reopen this. Thank you!

I don't have Android 5 anymore so I can't test. But I'm guessing it's fixed. Thanks


Move regenerator and nodent to ajv-async

The regenerator runtime by itself makes up just under half of ajv's npm package installation footprint. Considering that the async features were split out into a separate package anyway and the regenerator runtime is relatively easy for frontend people to add to their projects separately, would it be possible to not include the regenerator runtime in the npm package? Or maybe have a separate package for the frontend dist stuff?

It would be the right thing to do. It would require:

moving nodent and regenerator to ajv-async (its next major version)
moving all tests that use them there as well
publishing ajv-async to cdnjs

Once it's done, they can be removed from here in the next major version, together with the tests that use them.

in 6.0.0-beta.2


[Event Request] Table 5901 Service Item No. OnValidate

Hi,
We would like to extend Service Item No. OnValidate Trigger with OnBeforeCheckShipToCode like this:

[IntegrationEvent(false, false)]
    local procedure OnBeforeCheckShipToCode(ServItem: Record "Service Item";ServHeader: Record "Service Header";var ServiceItemLine: Record "Service Item Line";var IsHandled:Boolean)
    begin
    end;

Best regards!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


training terminates at 0%

I'm training on my own multiview dataset and followed every step in the instruction. However, training simply just wouldn't proceed; it shows 0% progress and then terminates, with no error message given. Stepping through the code suggests that the termination occurs at running the first backpropagation; loss.backward() in train_frames.py.
Any suggestions?

reducing image sizes and frames solved the problem. So it might be a memory issue


Move window analysis to the window method

Which issue does this PR close?

Closes #.
Rationale for this change
This PR is mostly a restructure PR. All of the changes comes from code movement or comment updates.
Currently window construction analysis for the given input is done using a helper function inside enforce_sorting. However, doing this in enforce_sorting clutters code a bit there. Also this functionality may be useful in other places also.
This PR moves this analysis to the methods of the WindowAggExec and BoundedWindowAggExec.

What changes are included in this PR?

Are these changes tested?
Existing tests should work

Are there any user-facing changes?

I skimmed the PR and it also looks good to me -- thank you @ozankabak  and @mustafasrepo and @metesynnada


No any warnings in console when SMTP port is already taken

If port 1025 is already taken - it does not show any warning on running. Well, UI works, but SMTP server does not catch any emails. Here's the output:
$ MailHog
2019/06/07 16:40:26 Using in-memory storage
2019/06/07 16:40:26 [SMTP] Binding to address: <IP_ADDRESS>:1025
[HTTP] Binding to address: <IP_ADDRESS>:8025
2019/06/07 16:40:26 Serving under http://<IP_ADDRESS>:8025/
Creating API v1 with WebPath:
Creating API v2 with WebPath:
[APIv2] GET /api/v2/jim
[APIv2] GET /api/v2/messages
[APIv2] GET /api/v2/websocket

I ran both Mailcatcher and then MailHog on Mac OS, the first catches all the emails, the second is always empty

i'd say that's impossible :-) for example if you try to run MailHog twice you'll get this error:
2019/09/23 00:19:53 Using in-memory storage
2019/09/23 00:19:53 [SMTP] Binding to address: <IP_ADDRESS>:1025
[HTTP] Binding to address: <IP_ADDRESS>:8025
2019/09/23 00:19:53 Serving under http://<IP_ADDRESS>:8025/
2019/09/23 00:19:53 [SMTP] Error listening on socket: listen tcp <IP_ADDRESS>:1025: bind: address already in use

maybe you're running mailcatcher and mailhog on different interfaces?

Yeah, sorry, Mailcatcher is on <IP_ADDRESS>:1025 but MailHog is on <IP_ADDRESS>:1025, so same port but different host, my bad!


fix(#3554): correct module_to_os_path to return directory paths

To resolve the issue, we need to update the module_to_os_path function to check if the found path is a file. If it is, we should return the parent directory instead. This can be done by using Path(src.origin).parent if src.origin is a file.

@all-contributors, add @supercoder-dev for bugs, code


Parse failure with lines starting with ?.

peek @children
?.trimRight?()

This was working until recently. Hopefully it isn't hard to fix.

FIX: v0.26.0


The itwinjs-sandbox npm module is missing

I cannot find the @itwinjs-sandbox npm module used in ViewAttributesApp.tsx. It doesn't seem to be mentioned in the API docs and it isn't available on npmjs.com. Have I missed something in the tutorial?

⚠ Do not edit this section. It is required for imodeljs.github.io ➟ GitHub issue linking

LINK: Adding-showcase-widgets-to-your-iTwin-Viewer---iTwin.js-link-to-docs
TAG: imodeljs-docs-question
SOURCE: https://www.itwinjs.org/learning/tutorials/showcase-to-viewer/

@itwinjs-sandbox is internal to the showcase, and you can see some its contents by right-clicking on the desired import and using the "go to definition" option. However, most of the content that is in the @itwinjs-sandbox package will not be desirable, and it can be safely removed as an import.
It would be more beneficial to keep the original App.tsx file rather than copying the app file from the showcase and modifying the props necessary on the Viewer component. In the case of adding a ViewAttributesWidget, it would mean importing the component into the App.tsx file:
import { ViewAttributesWidgetProvider } from "./ViewAttributesWidget";

const uiProviders = [new ViewAttributesWidgetProvider()];

And modifying the viewer component like so:
<Viewer
  contextId={sampleIModelInfo.contextId}
  iModelId={sampleIModelInfo.iModelId}
  authConfig={{ oidcClient: AuthorizationClient.oidcClient }}
  uiProviders={uiProviders}
/>

@itwinjs-sandbox is internal to the showcase, and you can see some its contents by right-clicking on the desired import and using the "go to definition" option. However, most of the content that is in the @itwinjs-sandbox package will not be desirable, and it can be safely removed as an import.
It would be more beneficial to keep the original App.tsx file rather than copying the app file from the showcase and modifying the props necessary on the Viewer component. In the case of adding a ViewAttributesWidget, it would mean importing the component into the App.tsx file:
import { ViewAttributesWidgetProvider } from "./ViewAttributesWidget";

const uiProviders = [new ViewAttributesWidgetProvider()];

And modifying the viewer component like so:
<Viewer
  contextId={process.env.IMJS_AUTH_CLIENT_CONTEXT_ID as string}
  iModelId={process.env.IMJS_AUTH_CLIENT_IMODEL_ID as string}
  authConfig={{ oidcClient: AuthorizationClient.oidcClient }}
  uiProviders={uiProviders}
/>

I didn't quite understand the file structure at that time. Everything is working fine now, thanks.


Subaru Stop and Go support for both Global and Pre-Global platforms, and additional signals for Auto Stop-Start button press and status

Add signal for Engine Auto Stop Start status and button press

I added new Dashlights STOP_START signal and Engine_Stop_Start message to subaru-community branch dbc, currently without the Dashlights filler signals


Bug: javascript highlighting only works for exact string matches

Example:
when the user searches within reviews for "bass quality", it searches the postgres db for "bass AND quality", but the resulting highlighting on the front end will only highlight "bass quality" not individual instances of "bass" and "quality"

4dcb4568f60fb7b86ad8d1ae38fddd6f3dca3a1c


In Progress: Add main layout

Resolves #13.

Obviously need to re-work the HTML, the nav bar, etc. -- but I can look at the previous site to figure out how to match it up.
It's here in case you want to hack on it in the meantime.


[FR] Add IPN to KiCad Fields.

I find IPNs more ergonomic to deal with than the IvenTree integer field or the Part URL field.

Thanks for that.


Run with less memory

Hi,
thank you for sharing your research results openly. For testing purpose I'd like to run the webservice as Docker container on my locale machine. But the memory consumption seems to high to run it on a consumer laptop. Even the small version produces a stack overflow error:
...
nlu_1  | [INFO] Started ServerConnector@2489ee11{HTTP/1.1,[http/1.1]}{<IP_ADDRESS>:8080}
nlu_1  | [INFO] Started @279688ms
nlu_1  | [INFO] Started Jetty Server
nlu_1  | 2019-04-25 08:26:45,349 [qtp165255249-17] INFO  entitylinking.processor.DocumentProcessor:112  - Initializing DocumentProcessor for type 'FACTS_WITH_SALIENCE_EN_STANFORD'.
nlu_1  | 2019-04-25 08:26:48,578 [sparkDriverActorSystem-akka.actor.default-dispatcher-2] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Starting remoting
nlu_1  | 2019-04-25 08:26:48,599 [sparkDriverActorSystem-akka.actor.default-dispatcher-2] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remoting started; listening on addresses :[akka.tcp://sparkDriverActorSystem@localhost:45885]
nlu_1  | 2019-04-25 08:26:52,922 [sparkDriverActorSystem-akka.actor.default-dispatcher-5] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Shutting down remote daemon.
nlu_1  | 2019-04-25 08:26:52,925 [sparkDriverActorSystem-akka.actor.default-dispatcher-5] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remote daemon shut down; proceeding with flushing remote transports.
nlu_1  | 2019-04-25 08:26:52,945 [sparkDriverActorSystem-akka.actor.default-dispatcher-5] INFO  event.slf4j.Slf4jLogger$$anonfun$receive$1$$anonfun$applyOrElse$3:74  - Remoting shut down.
nlu_1  | 2019-04-25 08:27:22,090 [qtp165255249-17] INFO  entitylinking.preparation.Preparator:53  - Document 'doc1' prepared in 51.0ms.
nlu_1  | 2019-04-25 08:27:22,867 [qtp165255249-17] INFO  nlu.entitylinking.Disambiguator:101  - Document 'doc1' disambiguated in 771.0ms (1 chunks, 4 mentions).
nlu_1  | 2019-04-25 08:27:25,876 [qtp165255249-17] INFO  util.impl.JSR47Logger_impl:255  - Loading parser from serialized file jar:file:/root/.ivy2/cache/de.tudarmstadt.ukp.dkpro.core/de.tudarmstadt.ukp.dkpro.core.stanfordnlp-upstream-parser-en-rnn/jars/de.tudarmstadt.ukp.dkpro.core.stanfordnlp-upstream-parser-en-rnn-20140104.jar!/de/tudarmstadt/ukp/dkpro/core/stanfordnlp/lib/parser-en-rnn.ser.gz ...
nlu_1  | [WARNING] /factextraction/analyze
nlu_1  | javax.servlet.ServletException: javax.servlet.ServletException: org.glassfish.jersey.server.ContainerException: java.lang.StackOverflowError
nlu_1  | 	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146)
nlu_1  | 	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
nlu_1  | 	at org.eclipse.jetty.server.Server.handle(Server.java:564)
nlu_1  | 	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:317)
nlu_1  | 	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
...

Request:
curl --request POST   --url http://localhost:8080/factextraction/analyze   --header 'accept: application/json'   --header 'content-type: application/json'   --data '{"docId": "doc1", "text": "Jack founded Alibaba with investments from SoftBank and Goldman.", "language":"en"}'

Is there a way to decrease the memory consumption, e.g. disabling components or using a smaller knowledge base?
Best,
Malte

For others who face similiar issues:
Some API endpoints need less memory. For example, using entity linking alone works with my 16 GB memory (/entitylinking/analyze):
curl --request POST   --url http://localhost:8080/entitylinking/analyze   --header 'accept: application/json'   --header 'content-type: application/json'   --data '{"docId": "doc1", "text": "Jack founded Alibaba with investments from SoftBank and Goldman.", "language":"en"}'
>> {"docId":"doc1","language":"en","matches":[{"charLength":4,"charOffset":0,"text":"Jack","entity":{}},{"charLength":7,"charOffset":13,"text":"Alibaba","entity":{}},{"charLength":8,"charOffset":43,"text":"SoftBank","entity":{}},{"charLength":7,"charOffset":56,"text":"Goldman","entity":{"id":"http://www.wikidata.org/entity/Q193326","confidence":1.0}}],"entities":[{"id":"http://www.wikidata.org/entity/Q193326","name":"Goldman Sachs","url":"http://en.wikipedia.org/wiki/Goldman%20Sachs","type":"ORGANIZATION","salience":0.23286642671259394}]}

Yes, entitylinking alone is doable with 16 gigs and the small KB.
You can also disable languages (set languages to 'en' only in aida.properties and ner.properties).
Other than that, there is little you can do - AmbiverseNLU requires significant main memory at this point.


fixed Symfony deprecations

This is work in progress as I need to also fix Symfony to make it happen:

symfony/symfony#13315
symfony/symfony#13316
symfony/symfony#13317
symfony/symfony#13323

Fixes #928, #1085, #981, #998
Todo:

[ ] update the documentation

:+1:
Are we need to add some things to the CHANGELOG for this, e.g. I'm pretty sure the CsrfTokenManager behaves differently enough to warrant a little warning to people?

@davedevelopment Sure, but first, let me fix all the things :) Then, we will see how to update the documentation accordingly.

@fabpot absolutely, no pressure ;)

I'm making some very good progress. Everything is fixed now (let's see what Travis thinks) but the validation provider, which will take a bit more time on the Symfony side.

If we bump Symfony to 5.3.x (x > 3), I propose to do the same for Silex 1.2.

\o/ Done, tests pass for all versions of Symfony.

Remaining tasks:

[ ] update docs where needed (hopefully nothing)
[ ] add notes in the changelog

needs to be rebased to fix conflicts according to github

Closing. Will be reopened on 1.3 now that 1.2.3 is out.

see #1097


After reordering TreeItem in TreeView, multiple selection broken

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
As title describe, the index (internal state of TreeView) not update after reorder items, that will cause multiple selection (hold shift) broken. (see Steps to reproduce for example)
Expected behavior 🤔
(see Steps to reproduce for example)
Steps to reproduce 🕹
Steps:
sandbox

click move 3rd item to last
select item 4
hold shift and select item 5
only item 4 and item 5 selected (should be item 5/2/3/4)

Context 🔦
I'm creating a app which will let the user reorder the tree item
Workaround: (not tested, just trace the source)
If remove and add it in new place, the multiple selection may work, but my tree may be deep and frequently change its content and order, if I use this workaround may cause some performance issue.
Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: Windows 10 10.0.19044
  Binaries:
    Node: 16.13.0 - ~\AppData\Local\Temp\xfs-cd02493b\node.CMD
    Yarn: 3.1.0 - ~\AppData\Local\Temp\xfs-cd02493b\yarn.CMD
    npm: 8.1.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1266.0), Chromium (96.0.1054.57)
  npmPackages:
    @emotion/react: ^11.7.1 => 11.7.1
    @emotion/styled: ^11.6.0 => 11.6.0
    @mui/base:  5.0.0-alpha.60
    @mui/icons-material: ^5.2.4 => 5.2.4
    @mui/lab: ^5.0.0-alpha.60 => 5.0.0-alpha.60
    @mui/material: ^5.2.4 => 5.2.4
    @mui/private-theming:  5.2.3
    @mui/styled-engine:  5.2.4
    @mui/system:  5.2.4
    @mui/types:  7.1.0
    @mui/utils:  5.2.3
    @types/react: ^17.0.37 => 17.0.37
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.5.4 => 4.5.4
    and my app is running in electron 16

Can I take this issue?

Any updates here? Same problem with arrow navigation. If the order of tree items has changed, they still react as they are in their old places.

Hi, we had the same problem with arrow navigation. The only one fix that helped us is using as a key index while mapping through the elements.
{items.map((item) => (
          <TreeItem key={item} nodeId={item} label={item} />
        ))} =>
{items.map((item, index) => (
          <TreeItem key={index} nodeId={item} label={item} />
        ))}

Maybe it would help somehow in further fixes for TreeItem.


BIGTOP-3981. Get rid of building patched leveldbjni in Hadoop packaging on aarch64.

https://issues.apache.org/jira/browse/BIGTOP-3981
Since Hadoop is using org.openlabtesting.leveldbjni on aarh64 now, we can get rid of patching and building leveldbjni in do-component-build script on aarch64.
Attachments

+1

Smoke tests hava been verified on Arm64 Ubuntu-22.04.

Merged.


Changed the vite command parameter for the --api to --api.port instead

Related to issue https://github.com/vitest-dev/vscode/issues/55

Changed the vite command parameter for the api to --api.port instead of --api to allow manual setting of the host.
Updated vitest version in the basic sample
Added a setting to the basic sample to set the host manually
Updated version and changelog

@zxch3n  can you take a look?

Thanks!


Dismissing intro dialog with ESC leaves the UI largely empty

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
If you dismiss the intro dialog using the escape key, the UI is left mostly uninitialized. If you dismiss it by clicking the background however it does initialize the UI.
To Reproduce
Steps to reproduce the behavior:

Launch the desktop app
Press the escape key

Expected behavior
I would expect the two methods of closing the dialog to behave identically.
Screenshots

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version v22.1.11 (desktop)

Desktop (please complete the following information):

OS: macOS Sonoma 14.1.1
Browser: N/A
Browser Version: N/A

Smartphone (please complete the following information):

Device: N/A
OS: N/A
Browser: N/A
Version: N/A

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

N/A

Additional context
I use the draw.io desktop app and it appears the dialog in question doesn't even exist on the web version, so it's likely only relevant for the desktop version.

Fix in 22.1.22


Automatic module name property in manifest

Changes
Add a manifest entry for automatic module name as a small improvement for use with modules and JDK9+. Or better yet, use a plugin to create a release compatible with both 8 and 9+, for example a multi-release jar.
References
http://branchandbound.net/blog/java/2017/12/automatic-module-name/
Testing

[ ] This change adds test coverage
[x] This change has been tested on the latest version of Java or why not

Manually inspected resulting jar.
Checklist

[x] I have read the Auth0 general contribution guidelines
[x] I have read the Auth0 Code of Conduct
[x] All existing and new tests complete without errors

Perhaps fix a multi-version jar instead? This is the quick-fix / minimum solution.

Not a priority for the team today, but if done, will be done on the oss release library we use on every java library. I've created an issue there to track it and keep the conversation in a single place.


Implement Any-IP feature

Any-IP is the capability to accept packets locally even when the
destination address is not configured on any interface. This lets
a service bind to an entire subnet of addresses and is particularly
useful in anycast deployments.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4465b469008bc03b98a1b8df4e9ae501b6c69d4b
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ab79ad14a2d51e95f0ac3cef7cd116a57089ba82

@m-labs-homu r+

:pushpin: Commit 4053e27 has been approved by whitequark

:hourglass: Testing commit 4053e27f26abcc4bde7257c33cc9d033282efb0b with merge a1d0e0c2af00ef56ea48663ef751cb122c0ad08f...

:broken_heart: Test failed - status-travis

Ah,  it looks like I forgot to account for all the feature permutations (not really surprised) - looking into it.

@m-labs-homu r+

:( looks like homu is rebelling

@m-labs-homu retry

@m-labs-homu r+

:pushpin: Commit 824bc13 has been approved by whitequark

:hourglass: Testing commit 824bc13fe78cfa0498cfffedb6d1a40c7cfc4611 with merge 6793792b02d7da436d08b6ab6eecf25c171eb3b5...

:sunny: Test successful - status-travis
Approved by: whitequark
Pushing 6793792b02d7da436d08b6ab6eecf25c171eb3b5 to master...


screen: make _wait_for_input public

Issues fixed by this PR
None
What does this implement/fix?
Renames Screen._wait_for_input method into Screen.wait_for_input and makes it formally public.
Any other comments?
First of all, thank you so much for this amazing project! We are using
it in our project [1] to interactively visualize dependency graphs for
our pipelines across all platforms. We are mostly using screen class
directly, as a cross platform ncurses of sorts and would love to have
an ability to use _wait_for_input method directly. In order to do that
properly, we need to make it formally public, so we could rely on it in
future versions of asciimatics.
I couldn't find any docs that need to be adjusted for this(seems
auto-generated), so please let me know if I need to add/change anything.
[1] https://github.com/iterative/dvc
Signed-off-by: Ruslan Kuprieiev<EMAIL_ADDRESS>

Coverage remained the same at 96.257% when pulling e8e2eb5a599651e1da80f81ee0893d651d698a6c on efiop:master into fcedb4947933de7e1507ec0dee8ca7a3f466928a on peterbrittain:master.

Coverage remained the same at 96.257% when pulling e8e2eb5a599651e1da80f81ee0893d651d698a6c on efiop:master into fcedb4947933de7e1507ec0dee8ca7a3f466928a on peterbrittain:master.

Coverage remained the same at 96.257% when pulling e8e2eb5a599651e1da80f81ee0893d651d698a6c on efiop:master into fcedb4947933de7e1507ec0dee8ca7a3f466928a on peterbrittain:master.

Thanks for your support!
I think I'm happy to expose the API as it stands.  Arguably it would be better with an option to block forever, but it sounds like you and I don't need that, so I'll not do that for now.  In the meantime, I've added some extra docs so that people are aware of the option.

Thank you!


Tableau log not displayed

The 1.1.0 version of the WDC simluator displays messages written with tableau.log in the bottom area of the Simulator UI.
I see that tableau.log is still part of the WDC 1.1.1 API, but none of the message being written are displayed anywhere.  Is there something I need to do to display the tableau log?

Oops that's a bug.  We removed the duplicate log entries at the bottom of the simulator because we felt it was overkill to have the logs spit out there and also as expected in the console window.  But it looks like we forget to catch the tableau.log statements and redirect them to console.out.
Thanks for the report @mradamlacey.  I would suggest just using console.log for now instead of tableau.log.  We output all of the console.log statements in the Tableau log files anyways, so tableau.log isn't necessary, you will see the same behavior with just console.log statements.

I believe this is resolved with the new simulator as well

Closing this, fixed in the v2 simulator.  We are no longer actively developing the v1 simulator (though it can still be used through our GH releases) so closing this as a won't fix.


Bootloader does not map all required pages

So I have no idea where to put this, though I've spoke about it in various places and have gotten no response in a month or so. (I apologize if I seem impatient.) It doesn't appear like the bootloader is mapping all of the required paged memory regions that my kernel uses. This in turn makes it prohibitive to continue my project because I have no idea why this is even happening to begin with. My debugging has lead me -- repeatedly -- to conclude that its a bug when x86_64 goes to zero an entry in one of the paging structures, though which one I am unclear about. Specifically, it occurs when allocating the kernel heap. When my kernel attempts to allocate address 3000h (or, rather,<PHONE_NUMBER>0h) I get a #PF, but since (for some reason) my IDT is being ignored (presumably it isn't mapped yet) a page fault occurs. Then another occurs because the ISRs aren't mapped, and then a double fault occurs, and then a triple fault. It has gotten to the point where I'm considering just making my own paging structures and not using the bootloader-provided ones. I want to avoid that but if there is truly no solution to this then I won't have much of a choice. My code is available here. Does anyone know why this is happening? Is there something I'm missing? From what I can tell the bootloader sets CR3 and (appears) to map everything but the behavior of my kernel leads me to believe otherwise.

That's what my code does, but I don't set up my own paging structures right now (I don't change CR3). Do need to go through that entire process? If so, the blog never covered actually setting up those tables, and I'd need to locate the kernel stack, code/data sections, etc., and map them in, I imagine.

It doesn't appear like the bootloader is mapping all of the required paged memory regions that my kernel uses

Specifically, it occurs when allocating the kernel heap. When my kernel attempts to allocate address 3000h (or, rather,<PHONE_NUMBER>0h) I get a #PF

The bootloader maps all pages of your kernel code and data segments. Your description sounds like you're choosing an arbitrary virtual address range for your heap. This address range is not mapped by the bootloader because it's not part of a code or data segment of your kernel. Instead, you need to add the required mappings to the page tables yourself.

@phil-opp I should clarify: I don't know where the 3000h is coming from. The<PHONE_NUMBER>0h part is my page table virtual offset. That is, this is the code that causes the #PF:
// In main.rs
    info!("Initializing virtual memory manager");
    let rdrand = RdRand::new().unwrap();
    let mut start_addr: u64 = 0x0100_0000_0000 + rdrand.get_u64().unwrap();
    start_addr.set_bits(47..64, 0);
    let mut end_addr = start_addr + MAX_HEAP_SIZE;
    end_addr.set_bits(47..64, 0);
    libk::memory::init(
        boot_info.physical_memory_offset.into_option().unwrap(),
        start_addr,
        MAX_HEAP_SIZE,
    );

// In memory.rs

/// Initializes the memory subsystem.
#[cold]
pub fn init(physical_memory_offset: u64, start_addr: u64, size: u64) {
    let mut mapper = MAPPER.lock();
    *mapper = Some(unsafe { init_mapper(physical_memory_offset) });
    let mut allocator = FRAME_ALLOCATOR.lock();
    *allocator = Some(GlobalFrameAllocator::init());
    let end_addr = start_addr + size;
    match (mapper.as_mut(), allocator.as_mut()) {
        (Some(m), Some(a)) => allocate_paged_heap(start_addr, end_addr - start_addr, m, a),
        _ => panic!("Memory allocator or page frame allocator failed creation!"),
    }
}

/// Initializes a memory heap for the global memory allocator. Requires a PMO to start with.
#[cold]
unsafe fn init_mapper(physical_memory_offset: u64) -> OffsetPageTable<'static> {
    // Get active L4 table
    trace!(
        "Retrieving active L4 table with memoffset {:X}",
        physical_memory_offset // is<PHONE_NUMBER>0h
    );
    unsafe {
        let (level_4_table, _) = get_active_l4_table(physical_memory_offset);
        // initialize the mapper
        OffsetPageTable::new(level_4_table, VirtAddr::new(physical_memory_offset))
    }
}

// ...

/// Allocates a paged heap.
#[cold]
pub fn allocate_paged_heap(
    start: u64,
    size: u64,
    mapper: &mut impl Mapper<Size4KiB>,
    frame_allocator: &mut impl FrameAllocator<Size4KiB>,
) {
    debug!("Allocating heap in paged memory with start of {:X}", start);
    // Construct a page range
    let page_range = {
        // Calculate start and end
        let heap_start = VirtAddr::new(start);
        let heap_end = heap_start + size - 1u64;
        let heap_start_page = Page::containing_address(heap_start);
        let heap_end_page = Page::containing_address(heap_end);
        Page::range_inclusive(heap_start_page, heap_end_page)
    };
    debug!("Page range constructed: {:?}", page_range);
    // Allocate appropriate page frames
    page_range.for_each(|page| {
        debug!(
            "Requesting new page frame for page at addr {:X} with size {:X}",
            page.start_address().as_u64(),
            page.size()
        );
        debug!(
            "Page table indexes: {:?}, {:?}, {:?}, {:?}",
            page.p4_index(),
            page.p3_index(),
            page.p2_index(),
            page.p1_index()
        );
        let frame = match frame_allocator.allocate_frame() {
            Some(f) => f,
            None => panic!("Can't allocate frame!"),
        };
        let flags = PageTableFlags::PRESENT | PageTableFlags::WRITABLE;
        let frame2 = frame;
        debug!("Requesting mapping of page with flags {:X}", flags);
        unsafe {
            // Below line crashes...
            match mapper.map_to(page, frame, flags, frame_allocator) {
                Ok(f) => {
                    debug!("Map complete, flushing TLB");
                    f.flush();
                    MUSE.fetch_add(1, Ordering::Relaxed);
                }
                Err(e) => panic!(
                    "Cannot allocate frame range {:X}h-{:X}h: {:?}",
                    frame2.start_address().as_u64(),
                    frame2.start_address().as_u64() + frame2.size(),
                    e
                ),
            }
        }
    });
    SMUSE.fetch_add(size, Ordering::Relaxed);
}

I create a random heap location because I (don't) want to clobber any existing memory, and I think that<PHONE_NUMBER>0h plus a random 64-bit offset should avoid clobbering anything. But this code might be wrong. But I need the start address for my memory allocator (the Rust one as well as the VMM) and so I'm not quite sure how to go about resolving this bug. I could go through the list of (free) memory regions and select the largest one, then pick a random offset in there, but the problem is that the bootloader gives me an invalid memory map (all addresses in hex):

Start
End
Type

0
1000
usable

1000
46000
bootloader

46000
A0000
usable

100000
800000
usable

800000
808000
acpi non-volatile

808000
810000
usable

810000
900000
acpi non-volatile

900000
1500000
usable

1500000
7BF36000
usable

7BF36000
7BF56000
usable

7BF56000
7E8C7000
usable

7E8C7000
7ECCE000
usable

...
...
usable

7FAEF000
7FB6F000
reserved

7FB6F000
7FB7F000
acpi reclaimable

7FB7F000
7FBFF000
acpi non-volatile

7FBFF000
7FE00000
usable

7FE00000
7FEF6000
usable

...
...
usable

7FF78000
80000000
acpi non-volatile

100000000
140000000
usable

140000000
1400A6000
usable

1400A6000
580000000
usable

B0000000
C0000000
reserved

FFE00000
100000000
mmio

As you can see, the map is littered with no loader code/loader data, boot services code/data, runtime services code/data, etc. The UEFI specification mandates that all UEFI implementations MUST expose UEFI runtime services in the memory map, and, assuming that the bootloader isn't doing any trickery with it behind the scenes (which if its not if I'm understanding the code correctly), this is the exact same memory map given to the bootloader by EDK II. And EDK II is UEFI spec compliant, so therefore the bootloader must be doing something wrong. Since the bootloader doesn't give me any strong enumeration variants to work with, I am forced to try to interpret the enum values by hand:
    for region in boot_info.memory_regions.iter() {
        info!(
            "| {:X} | {:X} | {} |",
            region.start,
            region.end,
            match region.kind {
                MemoryRegionKind::Usable => "usable",
                MemoryRegionKind::UnknownUefi(kind) => match kind {
                    0 => "reserved",
                    1 => "loader code",
                    2 => "loader data",
                    3 => "boot services code",
                    4 => "boot services data",
                    5 => "runtime services code",
                    6 => "runtime services data",
                    7 => "Usable",
                    8 => "unusable",
                    9 => "acpi reclaimable",
                    10 => "acpi non-volatile",
                    11 => "mmio",
                    12 => "port mmio",
                    13 => "pal code",
                    14 => "free nvm",
                    _ => "unknown",
                },
                MemoryRegionKind::UnknownBios(_) => "unknown",
                MemoryRegionKind::Bootloader => "bootloader",
                _ => "Unknown",
            }
        );
    }

So, to rap this up: what is the best solution to this problem? And how would I go about fiddling with the page tables? I thought that the heap allocation routine was supposed to do that.

Update (just commenting again so people using emails see this): the other issue is that I don't really see any other way of passing the strong enum values to kernels. I don't think you can do that over an FFI boundary, but at the same time you shouldn't ever try to (manually) interpret the memory map types since an implementation can use any value they want for any of them, excluding those that the UEFI spec explicitly marks as reserved. So this feels kinda like a catch-22: the bootloader has to tell the kernel what memory region is of what type, but the bootloader can't pass strong Rust enums over an FFI boundary to the kernel, but the kernel can't just interpret a particular memory type value as "free" or whatever because the hard-coded values may not even remotely match the UEFI implementations values (say, an implementation could use 1000h for MMIO regions).


[Bug] Crash 5.5.3 webOS

Checklist

[X] I will only use English in my report.
[X] I have used the search function for open and closed issues to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

Questions

[X] xCloud officially supports my country/region.
[ ] The bug doesn't happen when I disable Better xCloud script.
[X] The bug didn't happen in previous Better xCloud version (name which one).

Device
TV
Device
OLED77B36LA
Operating System
webOS 8.3.1-3607
Android app/Browser Version
Not Applied
Better xCloud Version
5.5.3
Game list
No response
Reproduction Steps
Hi, crash after a few seconds of opening the app ( page is refreshing continuously and crash at the 3rd refresh), it was working on version 5.5.0. Can't upload video since limit is 10mb.
Tried reinstalling the app and problem presists.
Cheers.
Screenshot/video
No response

Bad click, for now I'm on 5.4.2 that is the most usable and stable one that have the streaming options available but unfortunately not all the app settings.
5.5.4 have the same issue.
Hope you can find a fix.
Cheers

Using 5.5.6 and having the same problem on my LG TV. Will try downgrading the version when I get chance to see if that helps.

Can confirm. 2-3 crashes on 5.5.6 and kicks me out to the LG menu

Yep, exactly the same issue, LG G2

Can confirm. 2-3 crashes on 5.5.6 and kicks me out to the LG menu

5.5.0 is working but it doesn't have the app settings like server region etc but streaming options are there anyway OpenGL gives me black screen and throws an cloud error at screen after some seconds of playing sound and no image.. Don't know what's been going on with Better xcloud.

#2


Merge changes from main branch

just take this and merge into your template manager plugin. no need for 2 plugins.

Are you sure? I guess it is related

yes, I'm sure.


PacVis distribution not found

With the current version (0.2.7.r4.g30b2956-1) from the AUR the bin won't run.
The error message is
pkg_resources.DistributionNotFound: The 'PacVis==0.2.7' distribution was not found and is required by the application
this might be due to the python 3.8 update not so long ago?
Reinstalling didn't help. Installed the package via pikaur from the AUR with no error messages, I'm on arch 5.4.3.
Thanks.

You need to rebuild your packages from AUR by yourself. pikaur may cache the built package so you will need to let it rebuild instead of only reinstalling the package. Try clean pikaur package cache and rebuild it.
Or there is already built package in [archlinuxcn], I am maintaining the package myself there:
https://github.com/archlinuxcn/repo/blob/master/README.md


Map doesn't load offline, because js libraries could not be loaded

Map could be shown offline even without internet if js libraries would be downloaded and saved initialy.

Data age would have to be shown to not confuse the user. And data would have to be saved permanently.

^ making new branch for this and utiliizing storage structure

As discussed - we will not use the storage structure and just save the js libraries

(i will use the existing map branch for this issue)

Can I use charts offline?
Your users' computers must have access to https://www.gstatic.com/charts/loader.js in order to use the interactive features of Google Charts. This is because the visualization libraries that your page requires are loaded dynamically before you use them. The code for loading the appropriate library is part of the included script, and is called when you invoke the google.charts.load() method. Our terms of service do not allow you to download the google.charts.load or google.visualization code to use offline.
Can I download and host the chart code locally, or on an intranet?
Sorry; our terms of service do not allow you to download and save or host the google.charts.load or google.visualization code. However, if you don't need the interactivity of Google Charts, you can screenshot the charts and use them as you wish.
This is from the google documentation... So no loading it offline apparently

We could save a screenshot but I don't think it's quite what we want...

@aleksn41 What do you think we should do?


Fix high specificity for input display property

This will reduce input selector specificity for display property to prevent overriding user written css. fix #78.

Hmm, interesting solution! I'll have to think on this one for a bit.
Note: this will have merge conflicts due to the change to CSS variables in #71. The change will have to be made to src/parts/_forms.css instead.

Sorry for not getting back to you on this pull request!
This is a good contribution, but it's now out of date with master. If you are able to resolve the merge conflicts we would love to have this contributed to water.css.

Hey @frontendmonster, I'll close this merge request for now but feel free to reopen if you can resolve the conflicts. We'd love to have your contribution!

I confirmed that this is still an issue, and did the same fix from the latest branch. So there shouldn't be any merge conflicts.
I'm creating a pull request...

Hi @kylejrp.
Can you check if I missed any steps in my PR?
I ran yarn changeset, but I still got an email re "This PR includes no changesets".
So is my change going to make it through or not?


repl screenshot for activation list squishes the table when it shouldn't

i think we want a fixed table layout for this view, to avoid it being squished down when the user clicks the screenshot button

versus this with a fixed table layout


URL class is undefined only with remote debugger off

Is this a bug report?
maybe
Have you read the Contributing Guidelines?
no
Environment
Environment:
OS:  macOS Sierra 10.12.6
Node:  v6.11.1
Yarn:  0.27.5
npm:  5.4.2
Watchman:  4.7.0
Xcode:  Xcode 9.1
Android Studio:  2.3
Packages: (wanted => installed)
"react-native": "0.45.1",
"react": "16.0.0-alpha.12",
Target Platform: iOS (11.0.1) Android (5.1)
Steps to Reproduce
The curious is that this error only occur while remote debugger is off, if its on everthing works fine.

Turn off remote debugger
var url = new URL('https://facebook.github.io/react-native');

Same code work if remote debuger is turned on

Expected Behavior
A new instance of URL() class like documented in mozila and the URLSearchParams from the searchParams property
Actual Behavior
URL is undefined so everything messup
Why this happens? I think all js apis are supposed to work, and most weird it only work when debugger is on.

URL() is Web API and not available in pure js Environment (JavaScriptCore in your device). When you're using remote debugger, the host environment is your Chrome browser which have those APIs and you should not rely on that.
You may want to have add a URL polyfill example to your project.

@facebook-github-bot expected


Permanently showing default touch bar layout

It seems regardless of which app is currently active, the Touchbar Simulator buttons/layout remains the same (default).
Likely irrelevant note: it does respond to holding the fn key.

Wow - typically just after posting the issue after investigating the problem well beforehand, I've just realised what it was. I remembered I had run a mac set-up script, which includes disabling the touchbar... https://github.com/paulirish/dotfiles/blob/master/.osx


Environment URI normalization

Go doesn't seem to have a standard way / default library to normalize URIs. As part of the environments feature, we want to be able to deploy to a specific cluster given the environment's URI. We cross-check against kubecfg for this URI's location. For fail-safe comparison, we probably want to normalize these URIs.

This issue was moved to ksonnet/ksonnet#10


Encoding when reading/writing files

Foreign characters are getting convert when reading/writing. Would it help to have an option to set the encoding when reading/writing files like in grunt-cache-bust?
å -> Ã¥
ä -> Ã¤
ö -> Ã¶
options: {
    encoding: 'utf8',
}

Yes, we are seeing this issue as well.


Make gas price adjustment more obvious

Recently we got a 1* review because someone didn't like the suggested gas price (over 30 gwei, during 100% ethereum loading) and didn't know/weren't aware gas price is decided by supply/demand loading not by the wallet.
Also they didn't know you could adjust the gas price.
Could we make it more obvious that the gas price can be adjusted on the confirmation screen? When someone's looking at the gas price that's where their focus is, maybe something could be put there.

@JamesSmartCell Remember we have a yet-to-implement action sheet-style UI replacement for confirmation screens. That would help https://zpl.io/aNJ6Ykv

@hboon I'm not allowed to see that page :(

@JamesSmartCell I see a similar one for Android in https://app.zeplin.io/project/5d088205bff2d15de6a4397b/screen/5e996534a4a77b53a3c35ef0
But it looks like it's not in-sync, the iOS version has the gas displayed. @tomekalphawallet would you help to grant James access?

I was building the iOS version halfway a few months ago and unfortunately had to shelve it to work on other things. But I think it helps to resolve this GitHub issue or at least we can tweak it to solve it rather than to work on the existing confirmation page unless it's a tiny change

@hboon I'm not allowed to see that page :(

You are now.

What if:
By default, we use a recommended speed. When the action sheet is extended, they can set up manually. If they change their mind, the toggle can set it back to the recommended speed.

@tomekalphawallet That’s the current design of the actionsheet right?
I think in this case, the recommended gas is too much (to the user especially because it can fail). So a possible improvement is to hardcoded a heuristic and display a warning of some sort when gas amount > $X or X ETH
What do you think?

I like it - but I think we should err on the side of recommending a lower gas price unless the user requires the transaction to parse quickly. Maybe something like a 'Turbo' (or the 21st century equivalent 'Warp') button that is expensive but the user has to click it to get a < 10 mins or <1 min.


Support for linear gradients: add additional type to waveColor and progressColor parameters

Short description of changes:
Added feature to pass an array of colors into the waveColor and progressColor parameters.  Edited the setFillStyles function to check if the provided argument is a string or an object.  In the case of an object, a linear gradient is created, with each item in the array added as a color stop.

Breaking in the external API:
Not sure.
Breaking changes in the internal API:
None, as it runs the check to see if it is a string, therefore should be backwards compatible.
Todos/Notes:
If this feature is integrated, I would eventually like to integrate the ability to pass images and even a video as the wave background.
Related Issues and other PRs:

That's great @califken!

Can you also add an example that showcases this feature?
Done, added a gradient-fill-styles directory in the examples folder.  Not sure if there is an index that I should add it to somewhere.
And it'll also need a changelog entry?
Done, added a changelog entry to CHANGES.md.  Bumped the version up to 5.3.0.
And make sure to run npm run lint because there's a lint error: https://github.com/katspaugh/wavesurfer.js/pull/2345/checks?check_run_id=3384740565#step:8:26
Corrected the issue.
add a unit test
Added @test {WaveSurfer#setWaveColorGradient} to wavesurfer.spec.js
Also, what does it look like with bars (#1722)?

It looks awesome with bars!  :)

Rebased and pushed the one commit.  Ready to go.

Coverage decreased (-0.1%) to 81.529% when pulling d3044325496db55e4a5b257da6dbcdf17741ce97 on califken:wavecolor-gradient into e4d17d260c2090432d6892d04eca153f80374a7c on katspaugh:master.

@thijstriemstra is it possible to have the linear gradient show left to right - photo attached to see what I mean


can carla-challenge-1.0 still support carla-0.9.9 ?

Hi
I have upgraded to carla-0.9.9,  and I want to test my code with carla-challenge, can carla-challenge-1.0 still support carla-0.9.9 ?

You can still use agents and routes, so yes you can still run the challenge scenarios. However, the execution changed a bit, so did the output. Please have a look into the updated documentation.

thank you very much,  I will try to debug them.


Search bug when using the in-memory store

In some environments, due to security issues, I need to use the in-memory store.
If I try to search for an emoji newer than the supported emoji version on the platform, the search container shows it with a squared placeholder.
In this case, I think that the search should only include platform-supported emojis.
I created a simple jsfiddle that shows the issue.
Please try to search for "troll" on a browser that doesn't support emoji 14. I've used Chrome 109 on Big Sur.

It doesn't happen when I use the IndexedDB store.
Thanks.

The in-memory store was missing the version check in the search function, oops. Should be all set now, fixed in 5.7.6.
Really appreciate you reporting these issues!


MediatR library

Hey,
Your course on this was really great!
In the introduction of the course you mention that you will introduce the open source library MediatR.
Is there any reason why you prefer your own implementation over MediatR?
Thanks in advance.

I had to cut the material about MediatR because the course was too lengthy already. I plan to do a separate course on this topic.


Add Magic8Ball Function

This will create a function so when a user types 8ball (input) it will generate a response from a predefined list of answers.

Looks good!


Add brackets autoclose and highlighting

As mentioned in #9

This looks really nice: thanks for submitting!  Did you test that it works nicely with syncing?

Yes, it works with the syncing as well.

There seem to be several other options available in codemirror that can be used to make this project even more interesting! I wanted to try some more features, but didn't have much time. You should take a look at the list

Cool, just merged this guy.  I'll try and run a release soon.

Just ran a release (I think I did while in May as well) so this should be live.


Run delete_everything inside a transaction

This should use an explicit transaction to avoid "database locked" errors:
https://github.com/simonw/datasette/blob/b89cac3b6a63929325c067d0cf2d5748e4bf4d2e/datasette/utils/internal_db.py#L68-L85

This keeps on coming up with datasette.execute_write_fn() - I think it should automatically wrap a transaction around the function that gets executed.


Import profiles from shortcuts and/or folders

Summary of the new feature/enhancement
Development environments, such as Visual Studio, SDKs, etc. install shortcuts that open command prompts with a pre-configured environment (e.g. "x64 Native Tools Command Prompt for VS 2019"). It's tedious and error prone to copy settings from these shortcuts. Terminal should do it automatically, either on a shortcut-by-shortcut basis, or even better letting you dynamically import a whole directory of shortcuts
Proposed technical implementation details
Until Terminal has a UI for creating and editing profiles, this feature will simply involve changes to the schema of profiles.json
I propose a new key for profile dictionaries, let's call it "importDefaultsFromLnk", which can specify a path to a shell link (.lnk) file. A profile can contain a single importDefaultsFromLnk field and nothing else, and all settings will come from the shell link and its NT_CONSOLE_PROPS and NT_FE_CONSOLE_PROPS data blocks (except those that don't make sense for Terminal, of course, like NT_CONSOLE_PROPS::dwWindowOrigin); the name field would default to the file's display name (IShellItem::GetDisplayName), so that it would automatically hide the extension and/or load a localized description that might be present. If other profile fields are explicitly specified, they'll override settings from the shell link. A null value for a field could be used to mean "override with the Terminal default"
Importing a set of shortcuts from a directory (e.g. all shortcuts in Programs folder "Visual Studio 2019\Visual Studio Tools\VC", or even better all shortcuts under "Visual Studio 2019\Visual Studio Tools", recursively) could be done naively, with a profile field that we might call "importProfilesFromDirectory", but unlike importing a single shortcut this feature has non-trivial implications, including but not limited to:

should profiles imported from a directory be grouped in a sub-menu of the "new tab" menu?
what about recursively imported profiles? should there be sub-sub-menus?
how do we specify a dynamically imported profile in globals\defaultProfile?

Would this make more sense as a tool to try and turn a shortcut into a profile you could put in your profiles.json, as opposed to something built in? That would have the downside of not syncing the settings with the shortcut, but it would leave all of the terminal settings in one place. I'd be wary of running something like this on every launch, since it might dramatically reduce startup time - something we're discussing over in #1258.
I don't hate this idea, and it's definitely unique enough to stand on its own.

I think it would be very cool if our settings supported a one-way "import .lnk". It shouldn't have to be a separate tool, since we've got all the code in the codebase right now, in C++, so we could just make it a shared component.
I do agree with the Terminal Backlog milestone, though.

Probably dependent on #1564.


Show accumulated time in failed status in a given timespan (e.g. in the last month)

Thanks for your feedback, @fabiofrascella. This sounds like a useful thing to have :-)


how to debug the application in the Xcode

Hello Anyone knows how to debug the application in the Xcode? And are available to share how to do it?

You may want to see the conversation in the following closed issue:
https://github.com/SAP/macOS-enterprise-privileges/issues/37


Check for user write access (also, more speed and less code!)

Description
This PR improves the owners check:

It now checks that users have write access (this notably was already done for teams, though undocumented)

Updated the README.md documentation to mention that

Speeds up the users check by not querying for all organisation members (gets just a bit slow if you have 3k members!), instead just querying the users with access to the repository
Simplify the team query code by just querying the teams with access to the repository

See the commits for more details.
Other than the locally runnable tests, I've also tested this minimally with an actual GitHub org repo
Related issue(s)

Fixes https://github.com/mszostok/codeowners-validator/issues/157
Fixes https://github.com/mszostok/codeowners-validator/issues/115, because the new API call used includes collaborators (and more).

Similarly, fixes https://github.com/mszostok/codeowners-validator/issues/73

Resolves https://github.com/mszostok/codeowners-validator/issues/21, there shouldn't be a need to switch to GraphQL with this
I haven't tested this, but this could fix this issue: https://github.com/mszostok/codeowners-validator/issues/194

This work is sponsored by Antithesis :sparkles:

Just discovered that when using this with a GitHub App, it needs the "Administration -> read-only" permission instead of the "Members -> read-only" permission. So I guess this is a breaking change. I only updated the documentation for now, but I imagine more might be needed because of this.


Tensorflow 2.5 wheels depend on an unreleased keras version and restrict numpy to 1.19

The published wheels for tensorflow 2.5 depend on a nightly dev version of keras and restrict numpy to 1.19.x.
Depending on a nightly build of some package in a stable version is just, in lack of a better word, crazy.
The dependency on a specific numpy major version is maybe necessary, but is it really impossible to have a wheel that supports numpy >1.19 (including the current 1.20 release)?
❯ unzip -p tensorflow-2.5.0-cp37-cp37m-macosx_10_11_x86_64.whl  tensorflow-2.5.0.dist-info/METADATA | grep Requires-Dist
Requires-Dist: numpy (~=1.19.2)
Requires-Dist: absl-py (~=0.10)
Requires-Dist: astunparse (~=1.6.3)
Requires-Dist: flatbuffers (~=1.12.0)
Requires-Dist: google-pasta (~=0.2)
Requires-Dist: h5py (~=3.1.0)
Requires-Dist: keras-preprocessing (~=1.1.2)
Requires-Dist: opt-einsum (~=3.3.0)
Requires-Dist: protobuf (>=3.9.2)
Requires-Dist: six (~=1.15.0)
Requires-Dist: termcolor (~=1.1.0)
Requires-Dist: typing-extensions (~=3.7.4)
Requires-Dist: wheel (~=0.35)
Requires-Dist: wrapt (~=1.12.1)
Requires-Dist: gast (==0.4.0)
Requires-Dist: tensorboard (~=2.5)
Requires-Dist: tensorflow-estimator (<2.6.0,>=2.5.0rc0)
Requires-Dist: keras-nightly (~=2.5.0.dev)
Requires-Dist: grpcio (~=1.34.0)

Most version requirements here seem rather restrictive.

Where is the source code for keras-nightly? I'm trying to see where it is actually built? It seems necessary to be able to package TF 2.5.0 into Nixpkgs.

Can it be changed the Keras nightly dependency? It really is stopping my team from using 2.5. Thanks!

@maxnoe Is this still an issue for you? numpy 1.20 is compatible with latest TF version.
Please verify once and close the issue if this was resolved. Thanks!


Expose the ability to provision from a backup CRN in the postgresql DA

changes added to this PR: https://github.com/terraform-ibm-modules/terraform-ibm-icd-postgresql/pull/511

PR merged. Closing issue.


mir_robot: 1.0.5-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mir_robot to 1.0.5-1:

upstream repository: https://github.com/dfki-ric/mir_robot.git
release repository: https://github.com/uos-gbp/mir_robot-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.3
previous version for package: 1.0.4-1

mir_actions

No changes

mir_description
* Switch from Gazebo GPU laser to normal laser plugin
  The GPU laser plugin has caused multiple people problems before, because
  it is not compatible with all GPUS: #1 <https://github.com/dfki-ric/mir_robot/issues/1>
  #32 <https://github.com/dfki-ric/mir_robot/issues/32>
  #46 <https://github.com/dfki-ric/mir_robot/issues/46>
  #52 <https://github.com/dfki-ric/mir_robot/issues/52>
  The normal laser plugin directly uses the physics engine, so it doesn't
  depend on any specific GPU. Also, it doesn't slow down the simulation
  noticeably (maybe 1-2%).
* Contributors: Martin Günther

mir_driver
* Add optional prefix parameter to fake_mir_joint_publisher (#47 <https://github.com/dfki-ric/mir_robot/issues/47>)
* tf_remove_child_frames: Don't publish empty TFs
* Add sdc21x0 package, MC/currents topic
* Contributors: Martin Günther, Nils Niemann

mir_dwb_critics
* mir_dwb_critics: Add plot_dwb_scores.py
* mir_dwb_critics: Improve print_dwb_scores output
* added PathDistPrunedCritic for dwb (#42 <https://github.com/dfki-ric/mir_robot/issues/42>)
  which works exactly like the original PathDistCritic, except that it
  searches for a local minimum in the distance from the global path to the robots
  current position. It then prunes the global_path from the start up to
  this point, therefore approximately cutting of a segment of the path
  that the robot already followed.
* Contributors: Martin Günther, Nils Niemann

mir_gazebo

No changes

mir_msgs

No changes

mir_navigation
* Rename hector_mapping.launch, add dependency
* genmprim.py: Improve plotting
* genmprim.py: Make executable
* SBPL: Reduce allocated_time + initial_epsilon params
  This leads to shorter planning times, but will perhaps fail on larger
  maps.
* Update mprim file to mir-software 2.0.17
  This was updated in 2.0.17 and hasn't changed through 2.6 at least.
* Add genmprim_unicycle matlab + python script, fix mprim file
* Adjust dwb params: split_path, finer trajectories (#43 <https://github.com/dfki-ric/mir_robot/issues/43>)
  - use split_path option to enforce following complex paths
  - more trajectory samples over a smaller simulated time. This fixes a
  problem where the robot would stop too far away from the goal, as all
  possible trajectories either overshot the goal, or were too short to
  reach into the next gridcell of the critics.
  - remove Oscillation critic (never helped)
* added PathDistPrunedCritic for dwb (#42 <https://github.com/dfki-ric/mir_robot/issues/42>)
  which works exactly like the original PathDistCritic, except that it
  searches for a local minimum in the distance from the global path to the robots
  current position. It then prunes the global_path from the start up to
  this point, therefore approximately cutting of a segment of the path
  that the robot already followed.
* Add default local_planner to move_base launch file
  This makes the hector_mapping Gazebo demo work with the instructions
  from the README (see #32 <https://github.com/dfki-ric/mir_robot/issues/32>).
* Contributors: Martin Günther, Nils Niemann

mir_robot

No changes

sdc21x0
* Add sdc21x0 package, MC/currents topic
* Contributors: Martin Günther
* Add sdc21x0 package, MC/currents topic
* Contributors: Martin Günther

Holding for sync