[flutter_tools] ArgumentError: Invalid argument(s) (onError): The error handler of Future.catchError must return a value of the future's type

On beta/3.4.0-34.1.pre
Command: flutter debug-adapter
ArgumentError: Invalid argument(s) (onError): The error handler of Future.catchError must return a value of the future's type
at _FutureListener.handleError(future_impl.dart:181)
at Future._propagateToListeners.handleError(future_impl.dart:779)
at Future._propagateToListeners(future_impl.dart:800)
at Future._completeError(future_impl.dart:575)
at _rootRunBinary(zone.dart:1422)
at _CustomZone.runBinary(zone.dart:1314)
at _FutureListener.handleError(future_impl.dart:162)
at Future._propagateToListeners.handleError(future_impl.dart:779)
at Future._propagateToListeners(future_impl.dart:800)
at Future._completeError(future_impl.dart:575)
at _rootRunBinary(zone.dart:1422)
at _CustomZone.runBinary(zone.dart:1314)
at _FutureListener.handleError(future_impl.dart:162)
at Future._propagateToListeners.handleError(future_impl.dart:779)
at Future._propagateToListeners(future_impl.dart:800)
at Future._completeError(future_impl.dart:575)
at _rootRunBinary(zone.dart:1422)
at _CustomZone.runBinary(zone.dart:1314)
at _FutureListener.handleError(future_impl.dart:162)
at Future._propagateToListeners.handleError(future_impl.dart:779)
at Future._propagateToListeners(future_impl.dart:800)
at Future._completeError(future_impl.dart:575)
at Future._asyncCompleteError.<anonymous closure>(future_impl.dart:666)
at _rootRun(zone.dart:1398)
at _CustomZone.run(zone.dart:1300)
at _CustomZone.runGuarded(zone.dart:1208)
at _CustomZone.bindCallbackGuarded.<anonymous closure>(zone.dart:1248)
at _microtaskLoop(schedule_microtask.dart:40)
at _startMicrotaskLoop(schedule_microtask.dart:49)
at _runPendingImmediateCallback(isolate_patch.dart:122)
at _RawReceivePortImpl._handleMessage(isolate_patch.dart:193)

cc @jmagman

Future.delayed(const Duration(seconds: 1))
.whenComplete(
() => Future.delayed(const Duration(seconds: 1)).then((value) {
throw Exception("主动抛出异常333333");
}, onError: (e) {
print("333333=========onError==${e.toString()}");
}).catchError((e) {
print("333333===catchError=0000=======${e.toString()}");
}))
.catchError((e) {
print("333333====catchError=======${e.toString()}");
});
print messsage:
333333===catchError=0000=======Exception: 主动抛出异常333333
333333====catchError=======Invalid argument(s) (onError): The error handler of Future.catchError must return a value of the future's type
why print Invalid argument(s) (onError)???

why print Invalid argument(s) (onError)???

I'm not sure I understand your question. Are you asking why the error message tells you that there are "Invalid arguments"?

why print Invalid argument(s) (onError)???

I'm not sure I understand your question. Are you asking why the error message tells you that there are "Invalid arguments"?

Never mind, I think I understand your question. The reason you're hitting this is because (I think) the callback to catchError is supposed to return a value of the type of the Future (in this case, I think dynamic).

Closing this as a duplicate of https://github.com/flutter/flutter/issues/105750

This is still happening, likely from dependencies.
The source code for this analyzer check is https://github.com/dart-lang/sdk/blob/main/pkg/analyzer/lib/src/generated/resolver.dart#L3451

This is also occurring from dds https://github.com/dart-lang/sdk/issues/50802

Lowering the priority, as I think the largest cause of this, the DAP server spawned from VSCode, is no longer switched on, and the crash rate is much lower.

Increasing the priority as this is still one of the top crashers on stable/3.7.0

@christopherfujino are the current crashes still coming from DAP, or somewhere else? (almost nobody should be on the new DAP for Flutter right now, it's still defaulted to off)

@christopherfujino are the current crashes still coming from DAP, or somewhere else? (almost nobody should be on the new DAP for Flutter right now, it's still defaulted to off)

Hard to tell, since the stacktrace is no help. I have been assuming it's not coming from DAP, since you flipped it off. After what you found, I need to re-evaluate a bunch of tool usage of .catchError.

@christopherfujino are the current crashes still coming from DAP, or somewhere else? (almost nobody should be on the new DAP for Flutter right now, it's still defaulted to off)

Hard to tell, since the stacktrace is no help. I have been assuming it's not coming from DAP, since you flipped it off. After what you found, I need to re-evaluate a bunch of tool usage of .catchError.

Actually, I can see the top-level command, and I don't see debug-adapter among the 20 or so I spot checked. I think we're good.

Most instances (but not all) will be fixed by https://github.com/flutter/flutter/pull/119977

@DanTup can you try to repro at https://github.com/flutter/flutter/commit/b8f5394a5ca6d2bce062d9d0a20aaffb4289fb4c ? I'm guessing you'll hit a different crash, which I still need to fix.

@christopherfujino running the command from #119432 (yes | flutter doctor --android-licenses) results in the "correct" exception showing up now (I've no idea what the other warning output is about):
danny@Dannys-MacBook-Pro flutter % yes | flutter doctor --android-licenses
Warning: This version only understands SDK XML versions up to 2 but an SDK XML file of version 3 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"extension-level"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"extension-level"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: Errors limit exceeded. To receive all errors set com.sun.xml.bind logger to FINEST level.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
All SDK package licenses accepted.======] 100% Computing updates...

Echoing stdin to the licenses subprocess failed:
SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
#0      _NativeSocket.write (dart:io-patch/socket_patch.dart:1195:34)
#1      _RawSocket.write (dart:io-patch/socket_patch.dart:1938:15)
#2      _Socket._write (dart:io-patch/socket_patch.dart:2385:18)
#3      _SocketStreamConsumer.write (dart:io-patch/socket_patch.dart:2128:26)
#4      _Socket._onData (dart:io-patch/socket_patch.dart:2356:19)
#5      _rootRunUnary (dart:async/zone.dart:1414:13)
#6      _CustomZone.runUnary (dart:async/zone.dart:1307:19)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1216:7)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
#11     _StreamController._add (dart:async/stream_controller.dart:648:7)
#12     _StreamController.add (dart:async/stream_controller.dart:596:5)
#13     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1876:23)
#14     _NativeSocket.issueWriteEvent.issue (dart:io-patch/socket_patch.dart:1354:14)
#15     _NativeSocket.issueWriteEvent (dart:io-patch/socket_patch.dart:1361:7)
#16     _NativeSocket.multiplex (dart:io-patch/socket_patch.dart:1396:13)
#17     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

No additional info if running with -vv`:
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: Errors limit exceeded. To receive all errors set com.sun.xml.bind logger to FINEST level.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
All SDK package licenses accepted.======] 100% Computing updates...

[+1385 ms] Echoing stdin to the licenses subprocess failed:
[   +2 ms] SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
           #0      _NativeSocket.write (dart:io-patch/socket_patch.dart:1195:34)
           #1      _RawSocket.write (dart:io-patch/socket_patch.dart:1938:15)
           #2      _Socket._write (dart:io-patch/socket_patch.dart:2385:18)
           #3      _SocketStreamConsumer.write (dart:io-patch/socket_patch.dart:2128:26)
           #4      _Socket._onData (dart:io-patch/socket_patch.dart:2356:19)
           #5      _rootRunUnary (dart:async/zone.dart:1414:13)
           #6      _CustomZone.runUnary (dart:async/zone.dart:1307:19)
           #7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1216:7)
           #8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
           #9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
           #10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
           #11     _StreamController._add (dart:async/stream_controller.dart:648:7)
           #12     _StreamController.add (dart:async/stream_controller.dart:596:5)
           #13     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1876:23)
           #14     _NativeSocket.issueWriteEvent.issue (dart:io-patch/socket_patch.dart:1354:14)
           #15     _NativeSocket.issueWriteEvent (dart:io-patch/socket_patch.dart:1361:7)
           #16     _NativeSocket.multiplex (dart:io-patch/socket_patch.dart:1396:13)
           #17     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

[  +13 ms] "flutter doctor" took 4,125ms.
[   +2 ms] Running 0 shutdown hooks
[        ] Shutdown hooks complete
[   +1 ms] exiting with code 0

@christopherfujino running the command from #119432 (yes | flutter doctor --android-licenses) results in the "correct" exception showing up now (I've no idea what the other warning output is about):
danny@Dannys-MacBook-Pro flutter % yes | flutter doctor --android-licenses
Warning: This version only understands SDK XML versions up to 2 but an SDK XML file of version 3 was encountered. This can happen if you use versions of Android Studio and the command-line tools that were released at different times.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"extension-level"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"extension-level"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: Errors limit exceeded. To receive all errors set com.sun.xml.bind logger to FINEST level.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
All SDK package licenses accepted.======] 100% Computing updates...

Echoing stdin to the licenses subprocess failed:
SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
#0      _NativeSocket.write (dart:io-patch/socket_patch.dart:1195:34)
#1      _RawSocket.write (dart:io-patch/socket_patch.dart:1938:15)
#2      _Socket._write (dart:io-patch/socket_patch.dart:2385:18)
#3      _SocketStreamConsumer.write (dart:io-patch/socket_patch.dart:2128:26)
#4      _Socket._onData (dart:io-patch/socket_patch.dart:2356:19)
#5      _rootRunUnary (dart:async/zone.dart:1414:13)
#6      _CustomZone.runUnary (dart:async/zone.dart:1307:19)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1216:7)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
#11     _StreamController._add (dart:async/stream_controller.dart:648:7)
#12     _StreamController.add (dart:async/stream_controller.dart:596:5)
#13     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1876:23)
#14     _NativeSocket.issueWriteEvent.issue (dart:io-patch/socket_patch.dart:1354:14)
#15     _NativeSocket.issueWriteEvent (dart:io-patch/socket_patch.dart:1361:7)
#16     _NativeSocket.multiplex (dart:io-patch/socket_patch.dart:1396:13)
#17     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

No additional info if running with -vv:
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: Errors limit exceeded. To receive all errors set com.sun.xml.bind logger to FINEST level.
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}api-level>
All SDK package licenses accepted.======] 100% Computing updates...

[+1385 ms] Echoing stdin to the licenses subprocess failed:
[   +2 ms] SocketException: Write failed (OS Error: Broken pipe, errno = 32), port = 0
           #0      _NativeSocket.write (dart:io-patch/socket_patch.dart:1195:34)
           #1      _RawSocket.write (dart:io-patch/socket_patch.dart:1938:15)
           #2      _Socket._write (dart:io-patch/socket_patch.dart:2385:18)
           #3      _SocketStreamConsumer.write (dart:io-patch/socket_patch.dart:2128:26)
           #4      _Socket._onData (dart:io-patch/socket_patch.dart:2356:19)
           #5      _rootRunUnary (dart:async/zone.dart:1414:13)
           #6      _CustomZone.runUnary (dart:async/zone.dart:1307:19)
           #7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1216:7)
           #8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11)
           #9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
           #10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774:19)
           #11     _StreamController._add (dart:async/stream_controller.dart:648:7)
           #12     _StreamController.add (dart:async/stream_controller.dart:596:5)
           #13     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1876:23)
           #14     _NativeSocket.issueWriteEvent.issue (dart:io-patch/socket_patch.dart:1354:14)
           #15     _NativeSocket.issueWriteEvent (dart:io-patch/socket_patch.dart:1361:7)
           #16     _NativeSocket.multiplex (dart:io-patch/socket_patch.dart:1396:13)
           #17     _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:192:26)

[  +13 ms] "flutter doctor" took 4,125ms.
[   +2 ms] Running 0 shutdown hooks
[        ] Shutdown hooks complete
[   +1 ms] exiting with code 0

Thanks, I will open a new issue for this

@christopherfujino it seems like catchError is quite a footgun, maybe we should forbid its use in the tool à la https://github.com/flutter/flutter/blob/e627e8d84147cbb58e2fad38415c805410917ce0/packages/flutter_tools/test/integration.shard/forbidden_imports_test.dart ?

@christopherfujino it seems like catchError is quite a footgun, maybe we should forbid its use in the tool à la https://github.com/flutter/flutter/blob/e627e8d84147cbb58e2fad38415c805410917ce0/packages/flutter_tools/test/integration.shard/forbidden_imports_test.dart ?

agreed

Created https://github.com/flutter/flutter/issues/120146.


Update for gnome 43?

love the kde fuzzy clock, wanted to use something similar on gnome but found out its not compatible with gnome 43
will this be updated for gnome 43?

If it's as 42, yes. If it needs a bunch of work, probably not, depends how annoyed I get without it.

Just gonna mark as closed because of the pull request


Removing how to fund your training blog

Trello card
https://trello.com/c/oUXB0ZyR/4213-update-how-to-fund-your-training-blog
Context
Our how to fund your training blog is currently very out of date and is not a high traffic page. We should delete the blog and redirect to our funding page.
Changes proposed in this pull request
Guidance to review

Redirect tested successfully :-)
Do we want to clear up the blog tags at the same time @EllieNodder ?
It looks to me like none of these are used on any other blog

Should we remove them from the blog tag config file as good housekeeping practice?


Xnero: Blacklist bestsocialplan.com

Xnero requests the blacklist of the website bestsocialplan\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

bestsocialplan\.com has been seen in 6 true positives, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


It would be good to include an actual URL for visual studio subscription admin page.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0037633d-5fa6-5f52-8f3b-5c7742d29b9d
Version Independent ID: b6ff4517-52d9-b203-9f8f-adefb576a29b
Content: Accessing the Admin Portal for Visual Studio Volume License customers
Content Source: subscriptions/volume-license.md
Product: visual-studio-family
Technology: vs-subscriptions
GitHub Login: @evanwindom
Microsoft Alias: amast

@vknair74 - Thanks for pointing this out.  I'll get it updated.

#please-close


Breaking script when inside a folder with spaces

PR following resolution for #14884

/cc @cbracken @goderbauer

Thanks for the contribution!  Please sign the contribute license agreement so we can accept it 🙂

@tvolkert already signed it some hours ago, is it normal to take that much?

Nope - must have just needed to be kicked 😄
I'll let @cbracken or @goderbauer review and merge

This doesn't look correct to me. In fact, when I do this and run flutter doctor after removing all previous artifacts with git clean -xfd I am getting the following error:
Exists failed, path = '"C:\src\flutter\.pub-cache"\hosted\pub.dartlang.org\archive-1.0.33' (OS Error: The filename, directory name, or volume label syntax is incorrect.
, errno = 123)
Error: Unable to 'pub upgrade' flutter tool. Retrying in five seconds...

As you can see, there are quotes in that path that do not belong there.

I am also curious: This code path only becomes active when you have a .pub-cache directory inside your flutter folder. How did you end up with such a directory in there?

@goderbauer It might have been the case that I was with an already broken install after several attempts.
I honestly don't remember if I did cleanup or not the git repo before rerunning, but as you can see in the #14884 I was down the rabbit hole trying to fix the scripts to make it work in my environment (corporate machine with lots of blocked things).
I'm sure at home it would have worked in the first trial :sweat_smile:

btw, i realized I made a PR to master when I was trying the beta branch actually.

btw, i realized I made a PR to master when I was trying the beta branch actually.

You did it right - we merge all changes into master, and rather than patching changes into branches, we just cut new branches off master.  See https://github.com/flutter/flutter/wiki/Release-process for more details.

Based on @goderbauer's comment above I'm going to close this PR; please don't hesitate to reopen or file a new one if I am wrong in doing so.

That's ok, I guess I had another issue here that somehow this fixed but I
can't reproduce.
On Fri, 9 Mar 2018, 23:47 Ian Hickson<EMAIL_ADDRESS>wrote:

Closed #14955 https://github.com/flutter/flutter/pull/14955.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/14955#event-1514283330, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABfi7a357TqITos8QzXpSr0T2fAy50k7ks5tcwZzgaJpZM4SWZPX
.


[winpr] fallback to pkg-config for uriparser

older versions do not ship a CMake configuration, fall back to pkg-config based detection in that case.

@freerdp-bot test again please


Request: Recognize flags for consumable attributes and resources

As a module developer, I would like to be able to add module-defined consumable attributes (e.g. Power Points) as consumable resources for actions and resource bars.
Currently, everything is assumed to be a property of system; I would appreciate handling that changes the context if an attribute starts with flags

It seems I might need to do this as my own PR
For the attribute bars

As of v11, everything is handled with TokenDocument5e._getTrackedAttributesFromSchema
This means there's an assumption that everything can only every flow from the data model
I think the "fix" is that there needs to be a CONFIG registration that getTrackedAttributes() can call to insert extra bars or static properties. The obvious question is what's the label; having the full flags.module-id seems unwieldy, so I think modules should have to provide their own labels?

Sample typedef for the registration
/**
* @typedef {object} RegisteredAttributeFlag
* @param {boolean} isBar    - Bar or Single Value
* @param {string} label        - Unlocalized label that gets run through preLocalize
* @param {string} attribute - The full attribute path under `flags` - `["module-id"].myProp`
*                                              If `isBar` is true, myProp is an object with a `value` and `max` field
*                                              If `isBar` is false, myProp is numeric
*/

The consumable resources are a related issue; I'm unsure if I should stick them in the existing Attributes space or add a new entry to CONFIG.DND5E.abilityConsumptionTypes; the latter is already doable on a module end and would mostly just exist to standardize the display but otherwise not add much.

I think the "fix" is that there needs to be a CONFIG registration that getTrackedAttributes() can call to insert extra bars or static properties.

This is exists as CONFIG.Actor.trackableAttributes, and we do use it in the dnd5e system. See here for information on the core API.

Reviving this in the wake of 3.0's deprecation of resources
Right now, the item-oriented resource tracking works well for resources that are scaled to a specific class or are a function of level (e.g. something that's usable 2x proficiency). It is NOT useful for something that has scaling that interacts with multiclassing, such as Spell Points or some third party psionics systems that have Psi Points or other such systems.
It would be useful if there was a way to have that kind of information provided to items that would be pulling from those pools as well as have it tracked on a character bar.

Hmm, looking I do see that flags are included in roll data. That does offer an option for making it show on the resource bar at least by setting up an item and having its max uses tied to @flags.moduleID..., although that still leaves some complications with "upcasting"

This is resolved by the 4.0 consumption rework


[google_maps_flutter] Android TalkBack crashes when useAndroidViewSurface is false

Internal: b/329766984
Steps to reproduce

Enable Android TalkBack (Settings -> Accessibility -> TalkBack).
Open a Flutter app using google_maps_flutter and a useAndroidViewSurface value of false (the current default).
Interact with the map.
Observe crashes of the TalkBack service, effectively ANR'ing the app itself.

Expected results
TalkBack should not crash when used in an app using google_maps_flutter.
Actual results
TalkBack crashes and causes the app to be unusable.
Code sample
Code sample
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:flutter/material.dart';
import 'package:google_maps_flutter_android/google_maps_flutter_android.dart';
import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';

void main() async {
  //*****ENABLE this line to avoid TalkBack crashing
  // _googleMapsFlutterSetup();
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: GoogleMapPage(),
    );
  }
}

void _googleMapsFlutterSetup() {
  final mapsImplementation = GoogleMapsFlutterPlatform.instance;
  if (mapsImplementation is GoogleMapsFlutterAndroid) {
    mapsImplementation.useAndroidViewSurface = true;
  }
}

class GoogleMapPage extends StatefulWidget {
  GoogleMapPage({Key? key}) : super(key: key);

  @override
  State<GoogleMapPage> createState() => _GoogleMapPageState();
}

class _GoogleMapPageState extends State<GoogleMapPage> {
  @override
  Widget build(BuildContext context) {
    return GoogleMap(
      initialCameraPosition:
          const CameraPosition(target: LatLng(0.0, 0.0), zoom: 1),
    );
  }
}

Screenshots or Video
No response
Logs
Logs
E/AndroidRuntime(11211): FATAL EXCEPTION: main
E/AndroidRuntime(11211): Process: com.google.android.marvin.talkback, PID: 11211
E/AndroidRuntime(11211): java.lang.StackOverflowError: stack size 8188KB
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityNodeInfo.init(AccessibilityNodeInfo.java:4157)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityNodeInfo.<init>(AccessibilityNodeInfo.java:944)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityCache.getNode(AccessibilityCache.java:344)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityInteractionClient.findAccessibilityNodeInfoByAccessibilityId(AccessibilityInteractionClient.java:541)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityNodeInfo.getNodeForAccessibilityId(AccessibilityNodeInfo.java:4625)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityNodeInfo.getNodeForAccessibilityId(AccessibilityNodeInfo.java:4614)
E/AndroidRuntime(11211): 	at android.view.accessibility.AccessibilityNodeInfo.getParent(AccessibilityNodeInfo.java:1903)
E/AndroidRuntime(11211): 	at androidx.core.view.accessibility.AccessibilityNodeInfoCompat.getParent(PG:1)
E/AndroidRuntime(11211): 	at com.google.android.accessibility.utils.ScrollableNodeInfo.findScrollableNodeForDirectionRecursive(PG:2)
E/AndroidRuntime(11211): 	at com.google.android.accessibility.utils.ScrollableNodeInfo.findScrollableNodeForDirectionRecursive(PG:2)
E/AndroidRuntime(11211): 	at com.google.android.accessibility.utils.ScrollableNodeInfo.findScrollableNodeForDirectionRecursive(PG:2)
E/AndroidRuntime(11211): 	at com.google.android.accessibility.utils.ScrollableNodeInfo.findScrollableNodeForDirectionRecursive(PG:2)

Flutter Doctor output
Doctor output
[✓] Flutter (Channel google3, on macOS 14.4 23E214 darwin-x64, locale en)
    • Framework revision 03b5ea519a (2 days ago), 2024-03-18T00:00:00.000
    • Engine revision aebc0021cd
    • Dart version d5cf2d3849

[✓] Android toolchain - develop for Android devices (Android SDK version Stable)
    • Android SDK at google3
    • Platform Stable, build-tools Stable
    • Java binary at: /Applications/Android Studio with Blaze
      Beta.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.9+0-17.0.9b1087.7-11185874)

[✓] GoogleMac (on macos)
    • AppleWWDRCA installed.
    • Google development certificate installed.
    • Device 00008101-000539403403001E is whitelisted

[✓] Connected device (2 available)
    • Pixel 4 (mobile) • 99211FFAZ0054E • android-arm64 • Android 13 (API 33)

• No issues found!

Google bug: b/329766984.

I'm seeing this behavior on google_maps_flutter version 2.6.0 (also repros for me on 2.5.0 and presumably in between), and google_maps_flutter_android version 2.7.0 (similarly, down to 2.5.1).

Hi @ChristianEdwardPadilla, are you only seeing this on the Pixel 4 device or are you experiencing this on other devices as well? When you interact with the map, how long does it take before the ANR occurs?

Hey Daniel, sorry I don't have much more info. The ANR on the Pixel 4 happens after only a few seconds of interacting with the map.
However, I am unable to repro this on a Pixel 4a with the following flutter doctor output:
[✓] Flutter (Channel google3, on macOS 14.4 23E214 darwin-x64, locale en)
    • Framework revision b96c13d1e9 (5 days ago), 2024-03-20T00:00:00.000
    • Engine revision 883adfe2ef
    • Dart version 1fec623555

[✓] Android toolchain - develop for Android devices (Android SDK version Stable)
    • Android SDK at google3
    • Platform Stable, build-tools Stable
    • Java binary at: /Applications/Android Studio with Blaze
      Beta.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.9+0-17.0.9b1087.7-11185874)

[✓] Connected device (2 available)
    • Pixel 4a (mobile) • 01091FQC200240 • android-arm64 • Android 13 (API 33)

• No issues found!

I don't have any leads on why there might be a difference for the two devices. I'll add more details as I find them.

Thanks for the update.
Labeling based on the report shared above. For now, it seems to be only reproducing on the Pixel 4. Other devices may be affected but I didn't run into it on either my Nokia 6 or Pixel 7.
There was a similar issue a while back, maybe it wasn't completely fixed (it seemed to be occuring on specific devices in the old issue as well)

Hi Daniel, I am able to reproduce the issue 100% on Pixel 6 and Pixel 5a, both running Android 13, with the exact same steps.
Build app with useAndroidViewSurface set to false
Enabling TalkBack app , swipe left/right until the Google Map widget get focus, ANR happens.

Ops, sorry one in Android 14.
flutter doctor output:
[✓] Flutter (Channel google3, on macOS 14.4 23E214 darwin-arm64 (Rosetta), locale en)
    • Framework revision 73e78fd97c (3 days ago), 2024-03-23T00:00:00.000
    • Engine revision 689ea4b10b
    • Dart version 4ed5b58c2c

[✓] Android toolchain - develop for Android devices (Android SDK version Stable)
    • Android SDK at google3
    • Platform Stable, build-tools Stable
    • Java binary at: /Applications/Android Studio with [Blaze.app/Contents/jbr/Contents/Home/bin/java](http://blaze.app/Contents/jbr/Contents/Home/bin/java)
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Connected device (2 available)
    • Pixel 5a (mobile) • 0C181FQCB00400 • android-arm64 • Android 13 (API 33)

• No issues found!

[✓] Flutter (Channel google3, on macOS 14.4 23E214 darwin-arm64 (Rosetta), locale en)
    • Framework revision 73e78fd97c (3 days ago), 2024-03-23T00:00:00.000
    • Engine revision 689ea4b10b
    • Dart version 4ed5b58c2c

[✓] Android toolchain - develop for Android devices (Android SDK version Stable)
    • Android SDK at google3
    • Platform Stable, build-tools Stable
    • Java binary at: /Applications/Android Studio with [Blaze.app/Contents/jbr/Contents/Home/bin/java](http://blaze.app/Contents/jbr/Contents/Home/bin/java)
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Connected device (2 available)
    • Pixel 6 (mobile) • 23241FDF6003AE • android-arm64 • Android 14 (API 34)

• No issues found!

/cc @johnmccutchan

This will be a difficult bug to figure out because the crash isn't in code we own.

If this platform view uses a SurfaceView it will end up in a VirtualDisplay which has completely broken a11y support.
Using hybrid composition mode should make everything work but I understand there are performance problems with that approach.

We are investigating how to improve the performance in hybrid composition mode but that doesn't help you out today.

@mariamhas to coordinate either a work around or something else.

Since last week, Google Map is only a black widget on some of Android devices
Until I add this
final GoogleMapsFlutterPlatform mapsImplementation =
      GoogleMapsFlutterPlatform.instance;
  if (mapsImplementation is GoogleMapsFlutterAndroid) {
    // Force Hybrid Composition mode.
    mapsImplementation.useAndroidViewSurface = true;
  }

it works. What's the problem please? I don't know how to create a new issue here.


Bluetooth: host: Avoid using out-of-scope pointer

Mkae sure that variable pointed by params is valid when passing it
as function argument.
Fixes #10587
Signed-off-by: Szymon Janc<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@10c77df). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10699   +/-   ##
=========================================
  Coverage          ?   53.11%
=========================================
  Files             ?      214
  Lines             ?    25828
  Branches          ?     5695
=========================================
  Hits              ?    13719
  Misses            ?     9800
  Partials          ?     2309

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c77df...22c4638. Read the comment docs.


added-button-for-tablet

Modified:

Bale.js:

Changed buttons on header to use a style.
Added create bale button for tablet on the right.
Added prop dependencies for showing the modal

bale/styles.js

Added a style for tabletHeaderButtons

Seem to be working fine


http://www.waltztechnology.com down

can i have access to your demosite plz?

Hi Howard,
Will take a look at this tomorrow when I'm wfh.
Note we're also looking to have an demo instance hosted on FINOS kit in the near future (using the JuJu Charm work we've been doing with Canonical).

Thanks Dave
I was also thinking an export to solidatus format (as well as csv/xlsx) might be helpful for clients (as there must be at least two common clients between us!)
Howard Guess
Data Architect | Solidatus | solidatus.com
London: 30 Stamford Street, London, SE1 9LQ, United Kingdom
Email: @.***
United Kingdom | Singapore | USA
From: David Watkins @.>
Date: Wednesday, 2 March 2022 at 15:58
To: finos/waltz @.>
Cc: Howard Guess @.>, Author @.>
Subject: Re: [finos/waltz] http://www.waltztechnology.com down (Issue #5934)
You don't often get email from @.*** Learn why this is importanthttp://aka.ms/LearnAboutSenderIdentification
Hi Howard,
Will take a look at this tomorrow when I'm wfh.
Note we're also looking to have an demo instance hosted on FINOS kit in the near future (using the JuJu Charm work we've been doing with Canonical).
—
Reply to this email directly, view it on GitHubhttps://github.com/finos/waltz/issues/5934#issuecomment-1057088986, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX4D3B5XSNR7IG7XDDKP4BDU56FZZANCNFSM5PK6R3UQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
TSL Disclaimer: This message is confidential and may be privileged. It is intended solely for the named addressee. If you are not the intended recipient, please inform us. Any unauthorised dissemination, distribution or copying hereof is prohibited. Threadneedle Software Limited (trading as Solidatus), registered in England and Wales number 07485799, does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. Solidatus is a registered trade mark of Threadneedle Software Limited. TSL may monitor e-mails for business and operational purposes. By replying to this message you understand that the content of your message may be monitored.

Should be back now.
http://www.waltztechnology.com/home
Try test1/test1password  if you need to logon
Hopefully this will be replaced by the hosted FINOS version soon.

May be worth spinning the idea of the csv export into a new issue.  If you could outline the desired format we'll see if it's something we can squeeze into an upcoming release.

Thanks Dave will look tomorrow.
Is there any chance of a read only database connection account ? Don’t worry if not .
Get Outlook for iOShttps://aka.ms/o0ukef

From: David Watkins @.>
Sent: Thursday, March 3, 2022 5:57:49 PM
To: finos/waltz @.>
Cc: Howard Guess @.>; Author @.>
Subject: Re: [finos/waltz] http://www.waltztechnology.com down (Issue #5934)
You don't often get email from @.*** Learn why this is importanthttp://aka.ms/LearnAboutSenderIdentification
Should be back now.
http://www.waltztechnology.com/home
Try test1/test1password if you need to logon
Hopefully this will be replaced by the hosted FINOS version soon.
—
Reply to this email directly, view it on GitHubhttps://github.com/finos/waltz/issues/5934#issuecomment-1058326577, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX4D3B5BOI2JSISPWMSGWTLU6D4R3ANCNFSM5PK6R3UQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>
TSL Disclaimer: This message is confidential and may be privileged. It is intended solely for the named addressee. If you are not the intended recipient, please inform us. Any unauthorised dissemination, distribution or copying hereof is prohibited. Threadneedle Software Limited (trading as Solidatus), registered in England and Wales number 07485799, does not guarantee that the integrity of this communication has been maintained nor that this communication is free of viruses, interceptions or interference. Solidatus is a registered trade mark of Threadneedle Software Limited. TSL may monitor e-mails for business and operational purposes. By replying to this message you understand that the content of your message may be monitored.

It may be easier to just take the dump file (see the assets section at the bottom of the 1.39 Release and load that into a new db.
Once you've unpacked the tar.gz (tar -xzf ....) you can restore this into a postgres with:  psql -U {user} {database} < dump.sql


Update license for Safe Ecosystem Foundation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.671%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11881

Relevant Lines:
13399

💛  - Coveralls


feat: add alicloud secrets manager based secret store provider

What type of PR is this?

/kind feat
What this PR does / why we need it:
This PR adds alicloud secrets manager based secret store provider and related unit test cases.
Which issue(s) this PR fixes:

Fixes #638
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

47 of 61 (77.05%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.003%) to 74.904%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/secrets/providers/alicloud/secretsmanager/secretsmanager.go
47
61
77.05%

Files with Coverage Reduction
New Missed Lines
%

pkg/engine/operation/watch.go
1
85.93%

Totals

Change from base Build<PHONE_NUMBER>:
0.003%

Covered Lines:
6856

Relevant Lines:
9153

💛  - Coveralls


Update Fabric.js to 1.6.2

Hi guys,
Latest version of Fabric.js is v1.6.2 (https://github.com/kangax/fabric.js/tree/master/dist), and it fixes some issues for creating canvas from SVG (for me transform: rotate() was completely wrong), so it may be good to update it in AmCharts/export too.
I just use it for converting some non-AmChart graphs for export, and it is convenient since I already have AmCharts on the page, so don't need to load it additionally.

Hi Anton,
Thanks for pointing this out, we will verify this release and let you know when we've updated fabric.

I understand, you have to be careful with what they could break :) Thanks for looking into this!

Hi Anton,
We have verified that fabric version and were not able to find any issues. Please find the new version within the most recent commit https://github.com/amcharts/export/commit/dd2ffe872d906effd77fd2c2a9708bc5f2dea9f7.
Sincerely
Benjamin

Thanks Benjamin!


loadDiscoveryDocumentAndTryLogin() for Discord accesses /api/authorize/.well-known/openid-configuration

I am trying to set up SSO with Discord oauth2 and Angular. When I use the discord api url and run loadDiscoveryDocumentAndTryLogin() it appends .well-known/openid-configuration to the URL and doesn't work. I have also tried to just leave the function out completely and that doesn't work either.
import { Injectable } from '@angular/core';
import { OAuthService } from 'angular-oauth2-oidc';
import { authCodeFlowConfig } from './sso.config';
import { JwksValidationHandler } from 'angular-oauth2-oidc-jwks';

@Injectable({
  providedIn: 'root'
})
export class AuthService {

  constructor(private oauthService: OAuthService) {
    this.configureSingleSignOn();
   }

  configureSingleSignOn() {
    this.oauthService.configure(authCodeFlowConfig);
    this.oauthService.tokenValidationHandler = new JwksValidationHandler();
    this.oauthService.loadDiscoveryDocumentAndTryLogin();
  }

  login() {
    this.oauthService.initImplicitFlow();
  }

  logout() {
    this.oauthService.logOut();
  }

  get token() {
    const claims: any = this.oauthService.getIdentityClaims();
    return claims ? claims : null;
  }
}

import { AuthConfig } from 'angular-oauth2-oidc';

  export const authCodeFlowConfig: AuthConfig = {
    // Url of the Identity Provider
    issuer: 'https://discord.com/api/authorize',
    redirectUri: 'http://localhost:4200/',
    clientId: 'xxxxxxxxxxxxxxxxxxxxx',
    scope: 'guilds email identify',
    responseType: 'code',
    strictDiscoveryDocumentValidation: false,
    oidc: false,
    showDebugInformation: true,
  };

Just a quick thought. Your configuration says:
issuer: 'https://discord.com/api/authorize'

But that value is not an issuer, it is the authorize endpoint for the issuer. I reckon the issuer should be https://discord.com probably?
Also, if you use loadDiscoveryDocument... methods, you need to be sure that your Identity Server solution supports a discovery document (for example see https://demo.identityserver.io/.well-known/openid-configuration from another server side solution). If they don't, you cannot rely on discovery and you need to check the docs of this library to connect without discovery document.

@jeroenheijmans Thanks for the reply, I tried using loginUrl instead of issuer and that did the trick. Of course I ran into some other issues, but that is off-topic for this thread.

Thx for letting us know! Good luck with the follow up. 💪

example plz


Enhancement/icons list

Autogenerate icons list
Improved usability to search and copy icons in different sizes

Changed my mind about script location... it's better to locate it near the action, i.e. in the icon folder.


Fix potential security vulnerabilities com.fasterxml.jackson.core:jackson-databind

Update jackson-databind artifact version to  <IP_ADDRESS> as suggested by GitHub after finding potential security vulnerabilities:
Remediation
Upgrade com.fasterxml.jackson.core:jackson-databind to version <IP_ADDRESS> or later. For example:
<dependency>
  <groupId>com.fasterxml.jackson.core</groupId>
  <artifactId>jackson-databind</artifactId>
  <version>[<IP_ADDRESS>,)</version>
</dependency>

Details:
CVE-2017-17485 (high severity)
Vulnerable versions: < 2.8.11
Patched version: 2.8.11
FasterXML jackson-databind through 2.8.10 and 2.9.x through 2.9.3 allows unauthenticated remote code execution because of an incomplete fix for the CVE-2017-7525 deserialization flaw. This is exploitable by sending maliciously crafted JSON input to the readValue method of the ObjectMapper, bypassing a blacklist that is ineffective if the Spring libraries are available in the classpath.
CVE-2017-15095 (high severity)
Vulnerable versions: < 2.8.11
Patched version: 2.8.11
A deserialization flaw was discovered in the jackson-databind in versions before 2.8.10 and 2.9.1, which could allow an unauthenticated user to perform code execution by sending the maliciously crafted input to the readValue method of the ObjectMapper. This issue extends the previous flaw CVE-2017-7525 by blacklisting more classes that could be used maliciously.
CVE-2018-7489 (high severity)
Vulnerable versions: < <IP_ADDRESS>
Patched version: <IP_ADDRESS>
FasterXML jackson-databind before <IP_ADDRESS> and 2.9.x before 2.9.5 allows unauthenticated remote code execution because of an incomplete fix for the CVE-2017-7525 deserialization flaw. This is exploitable by sending maliciously crafted JSON input to the readValue method of the ObjectMapper, bypassing a blacklist that is ineffective if the c3p0 libraries are available in the classpath.
CVE-2017-7525 (high severity)
Vulnerable versions: >= 2.8.0, < 2.8.9
Patched version: 2.8.9
A deserialization flaw was discovered in the jackson-databind, versions before <IP_ADDRESS>, <IP_ADDRESS> and 2.8.9, which could allow an unauthenticated user to perform code execution by sending the maliciously crafted input to the readValue method of the ObjectMapper.

Closing this issue as per fix introduced in https://github.com/dikhan/pagerduty-client/pull/15


Tables not editable

When inserting a new table only 2 columns and 2 rows are set by default. However there doesn't seem anyway to add/remove rows or columns. Can this be resolved or can I remove the table button somehow?

Also can't seem to delete any tables either

Closing as a RTE Config like the below will fix this issue:
{
  "theme": "inlite",
  "inline": true,
  "plugins": "modxlink image imagetools media lists table",
  "insert_toolbar": "image media table modxlink",
  "selection_toolbar": "bold italic underline | alignleft aligncenter alignright | bullist numlist table | modxlink h2 h3 h4 blockquote",
}


geo_point does not support range queries while select by not null

CrateDB version:
2.0.6
JVM version:
openjdk version "1.8.0_144"
OpenJDK Runtime Environment (build 1.8.0_144-b01)
OpenJDK 64-Bit Server VM (build 25.144-b01, mixed mode)
OS version / environment description:
Archlinux. Kernel 4.12.4.
Problem description:
When I select geo_point field filter by not null, it throws error:
select * from geo_test where geo is not null;

It responses with:
SQLActionException[UnhandledServerException: java.lang.IllegalArgumentException: Field [geo] of type [geo_point] does not support range queries]

The table structure is like this:
create table geo_test (geo geo_point, id long);

Steps to reproduce:
Create the table:
create table geo_test (geo geo_point, id long);

Insert data:
insert into geo_test (geo_point, id) values ([1, 1], 1);
insert into geo_test (id) values (2);

Query:
select * from geo_test where geo is not null

Thanks for reporting,
we're able to reproduce it and will take a closer look at it.

We've merged a fix which will be included in the next 2.1 release.


update docs for mutual SSL

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[GHSA-hj32-9mcw-5cwh] Jenkins Project Inheritance Plugin 19.08.02 and earlier...

Updates

Affected products
CVSS
CWEs
Description
Summary

Comments
Fill in advisory details according to https://www.jenkins.io/security/advisory/2020-06-03/#SECURITY-1582

Hi @NotMyFault
So the plugins page for this one says that the most recent version is 21.04.03, but also has a warning banner indicating that this vulnerability is still unresolved. Just wanted to confirm that before updating the VVR and description to the later version.
Thanks!

Good catch, the versions affected should point to <= 21.04.03 then, apparently new versions with this vulnerability included have been published :/

Thanks, I will use that version then.


RemakeConstraint is not working as expected in snapkit new version when installed using cocoa pods

New Issue Checklist

[ ] I have looked at the Documentation
[ ] I have read the F.A.Q.

Issue Info

Info
Value

Platform
iOS

Platform Version
9.0

SnapKit Version
0.30.0.beta1

Integration Method
cocoapods

Issue Description
remake constraint not working as expected
below is fuction stack:
public func remakeConstraints(@noescape closure closure: (make: ConstraintMaker) -> Void) {
ConstraintMaker.remakeConstraints(view: self.view, closure: closure)
}
internal static func remakeConstraints(view view: ConstraintView, @noescape closure: (make: ConstraintMaker) -> Void) {
self.removeConstraints(view: view)
self.makeConstraints(view: view, closure: closure)
}
internal static func removeConstraints(view view: ConstraintView) {
}
removeConstraints is not doing anything. please check

@Yalqun this was a known bug, can you upgrade to 0.30.0.beta2 please?

update the new version everything is fine @Yalqun

I just fixed this in feature/0.40.0 but not yet tagged a version. It was an issue I can confirm


Minor enhancements needed to use this package in additional projects

In my current project, there is a strict requirement to have go v1.21 while later versions like v1.22 are not allowed. The only change needed is go 1.22.0 => go 1.21.0 in go.mod file. I tried locally and it works fine.
Also in my project, I need to load Markdown files with extension .mdx (rather than .md) while the content format is the same. To support this extension just need to change condition filepath.Ext(file.Name()) != ".md" to (filepath.Ext(file.Name()) != ".md" && filepath.Ext(file.Name()) != ".mdx") in documentloaders/notion.go

These changes will not impact existing behavior and no regressions are expected. I already prepared these changes locally, so if you are OK with them - please give me permissions to commit/merge and I will send PR for review.
Thanks.

diff --git a/documentloaders/notion.go b/documentloaders/notion.go
index 0dacbe7..c59b696 100644
--- a/documentloaders/notion.go
+++ b/documentloaders/notion.go
@@ -39,7 +39,7 @@ func (n *NotionDirectoryLoader) Load() ([]schema.Document, error) {

        documents := make([]schema.Document, 0, len(files))
        for _, file := range files {
-               if file.IsDir() || filepath.Ext(file.Name()) != ".md" {
+               if file.IsDir() || (filepath.Ext(file.Name()) != ".md" && filepath.Ext(file.Name()) != ".mdx") {
                        continue
                }

diff --git a/go.mod b/go.mod
index 6401ef7..214b001 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/tmc/langchaingo

-go 1.22.0
+go 1.21.0

@tmc - are you OK with it?

@tmc can you please take a look here? it is a very small change that will allow me to use your package (rather than forking it( thanks.

our project moved to go 1.22 - so this issue is not relevant anymore (support of .mdx can be worked around)


Add vectorized signatures for RNGs

Summary:
@bbbales2 added vectorized forms for a bunch of RNGs with these PRs:  https://github.com/stan-dev/math/pull/605 https://github.com/stan-dev/math/pull/722. Now we can add their signatures to the language. We might do something in line with what happened in this vectorizing PR: https://github.com/stan-dev/stan/pull/2107 but they won't be unary, so that will be slightly more complicated.
Current Version:
v2.17.1

@seantalts I just submit a pull request for this issue, Feature/issue 2467 vectorized signatures rn gs, please review when convenient.  Thank you.

Thanks.  I just reviewed.

With https://github.com/stan-dev/stan/pull/2585, https://github.com/stan-dev/stan/pull/2583, https://github.com/stan-dev/stan/pull/2580, and https://github.com/stan-dev/stan/pull/2471 all merged, should we  close this?

Sure.  We need a second issue for the versions that look like normal_rng(N, mu, sigma) to generate an array of N i.i.d. draws from a normal_rng(mu, sigma).  Those should be really easy to add and test with C++11 lambdas able to bind normal_rng(mu, sigma) into a nullary functor that can be iterated N times.

On Aug 9, 2018, at 7:30 PM, Edward A. Roualdes<EMAIL_ADDRESS>wrote:
With #2585, #2583, #2580, and #2471 all merged, should we close this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

There's already #1558 about generating and array of N draws, so I'm closing this.


"Slănic-Moldova" is listed in the drop-down menu

Description:
"Slănic-Moldova" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Slănic-Moldova" in the search bar.
Expected results
The location is listed in the drop-down menu as "Slănic-Moldova, Bacău"


Remove getByBlockNumber from ProtocolScheduleBuilder

PR description
Fixed Issue(s)

Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Acceptance Tests (Non Mainnet)

[ ] I have considered running ./gradlew acceptanceTestNonMainnet locally if my PR affects non-mainnet modules.

Changelog

[ ] I thought about the changelog and included a changelog update if required.

Closing this PR in favor of https://github.com/hyperledger/besu/issues/5159


Darknet Component

When trying to setup Darknet, i get the following
Traceback (most recent call last):
File "/src/viseron/components/init.py", line 130, in setup_component
result = component_module.setup(self._vis, config)
File "/src/viseron/components/darknet/init.py", line 125, in setup
vis.data[COMPONENT] = DarknetDNN(vis, config[CONFIG_OBJECT_DETECTOR])
File "/src/viseron/components/darknet/init.py", line 219, in init
super().init(vis, config)
File "/src/viseron/components/darknet/init.py", line 164, in init
self._model_width = int(model_config.get("net", "width"))
File "/usr/lib/python3.8/configparser.py", line 781, in get
d = self._unify_values(section, vars)
File "/usr/lib/python3.8/configparser.py", line 1149, in _unify_values
raise NoSectionError(section) from None
configparser.NoSectionError: No section: 'net'
[2023-04-21 22:41:42] [ERROR   ] [viseron.components] - Uncaught exception setting up component darknet: No section: 'net'
None
[2023-04-21 22:41:42] [ERROR   ] [viseron.components] - Setup of component darknet failed
[2023-04-21 22:41:42] [ERROR   ] [viseron.components] - Failed setup of component darknet

Seems similar to #476
What hardware are you running on?

Seems similar to #476
What hardware are you running on?

OS: Ubuntu 22.04.2 LTS x86_64/Installed on top CasaOS
Host: B550 AORUS ELITE AX
Kernel: 5.15.0-70-generic
Uptime: 10 hours, 58 mins
Packages: 1157 (dpkg), 6 (snap)
Shell: bash 5.1.16
CPU: AMD Ryzen 5 3600 (12) @ 3.600GHz
GPU: AMD ATI Radeon RX 5500/5500M / Pro 5500M
Memory: 9943MiB / 64211MiB
Also the M.2 Coral

@roflcoopter Not sure what it was, but the error didn't come back after the update. Ill use logs debug just in case and bring logs. Thanks!

@roflcoopter So after the update, absolutely no errors, however I have it set for recording trigger on darknet when object is detected. However, since then I have not been able to get record trigger to happen on detection.


Method descriptions missing from Sounds Modules

I'm starting to get interested in exploring audio in Python and was excited to discover the capabilities of your Jupylet project.
But I've just realized that although the documentation is extensive, many of the classes in the Sound and related modules only have the attributes defined, not the methods. Is this an oversight, or because they are waiting updating for the latest code changes or just because you have not got around to documenting them yet?
I note that the code itself is quite well documented, so perhaps there is an issue with documentation not getting automatically generated from the docstrings correctly?
I know that I can find out basic information about the classes using the Python "help" function but this does give any explanation of the methods, just the bare bones of class definitions.
Anyway, you're the expert and I'm only guessing but if you would like help in this area, then I've got the time (if only limited expertise) so I could have a go at helping with documentation.

If the code is documented but these docstrings do not appear in the online documentation it could indeed indicate a problem in the documentation setup. if you are willing to look into that that would be awesome.

It seems on further investigation that the problem is just that the
docstrings are incomplete. I think that I can generate these for you, so
will have a go at that shortly. We're away for a long weekend right now but
I'll get back to the task next week.
On Fri, 3 May 2024, 11:16 Nir Aides, @.***> wrote:

If the code is documented but these docstrings do not appear in the online
documentation it could indeed indicate a problem in the documentation
setup. if you are willing to look into that that would be awesome.
—
Reply to this email directly, view it on GitHub
https://github.com/nir/jupylet/issues/44#issuecomment-2092713414, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AUEHXT2FQBQQXBZFWSCAYYLZANPZBAVCNFSM6AAAAABHD46SVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSG4YTGNBRGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I've now created a full set of docsstrings for all classes and methods in the /jupylet/audio/sound.py file with help of Chat GPT and then pasted them in by hand to the souce code. No python code was pasted back in from Chat GPT, so the original code should be preserved as it was unless I made a typo in editing.
Generally I've preserved the content of original docstrings where they existed and incorporated original single line comments within new docstrings.
I'm not experienced at setting up GitHub so that I can insert/update code, so I'm attaching the result as a file attachment here - but this has to be done as a .txt file so I've just changed the extension.
Jupylet Sound - Docstrings.txt
Please do refer any problems back to me.

I think you need to create a pull request, but I'm not familiar with the procedure either. why don't you ask chatgpt how to do it and this way your contribution will be properly recorded ?


Cancelling account - PASSWORD INCORRECT !!!!

Not impressed chaps ...
Support tickets on Sendggrid takes days to be answered and when I come to close my account I get incorrect password when I try to confirm cancellation even though it is EXACTLY the same password I had just logged in with!
Coupled together with the fact that it will probably take a week or two for you to get back to me on the support tickets - it smells a bit like ....
Please close my account immediately!
Thank you.

Hello,
Sorry to hear about the situation, and I'll see what we can do.
Please provide your SendGrid support ticket number (if you are unable to login and you do not have a ticket yet, submit a ticket here--which is possible without being logged in: https://support.sendgrid.com/hc/en-us/requests/new#login-issue ).  Otherwise, please provide your SendGrid username and we'll get back to you as soon as we can.
Thank you.

4Productions is my username
Thank you
Sent from my iPhone so apologies if predictive text has taken over!

On 22 Jun 2020, at 20:26, Tully Parker<EMAIL_ADDRESS>wrote:

Hello,
Sorry to hear about the situation, and I'll see what we can do.
Please provide your SendGrid support ticket number (if you are unable to login and you do not have a ticket yet, submit a ticket here--which is possible without being logged in: https://support.sendgrid.com/hc/en-us/requests/new#login-issue ). Otherwise, please provide your SendGrid username and we'll get back to you as soon as we can.
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi Lee,
Thanks for the update and confirming your username.  I replied through an
open SendGrid support ticket #4584505.  Please check your emails for the
specific.  To summarize, however, we are refunding you based on the
situation, your account was closed per your request and you won't be
charged again.
Thanks,
On Mon, Jun 22, 2020 at 1:46 PM leehendo<EMAIL_ADDRESS>wrote:

4Productions is my username
Thank you
Sent from my iPhone so apologies if predictive text has taken over!

On 22 Jun 2020, at 20:26, Tully Parker<EMAIL_ADDRESS>wrote:

Hello,
Sorry to hear about the situation, and I'll see what we can do.
Please provide your SendGrid support ticket number (if you are unable to
login and you do not have a ticket yet, submit a ticket here--which is
possible without being logged in:
https://support.sendgrid.com/hc/en-us/requests/new#login-issue ).
Otherwise, please provide your SendGrid username and we'll get back to you
as soon as we can.
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/sendgrid/docs/issues/6097*issuecomment-647734332__;Iw!!NCc8flgU!MMi3BNyZp8v9JM88qf7IzyUp1GZRUrB843DQLpFtWAeqzJv-MIX-2cEM14ri-SLQecso$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AFLPWVO5GDJW5JK4DM5XHI3RX6YHXANCNFSM4ODJLXOQ__;!!NCc8flgU!MMi3BNyZp8v9JM88qf7IzyUp1GZRUrB843DQLpFtWAeqzJv-MIX-2cEM14ri-W9nlpun$
.

--
--
Tully Parker
Support Engineer | Customer Support
t tully.parker<EMAIL_ADDRESS>

Hi @leehendo ,
It appears that support is helping with this Issue. Thank you for your patience, and we're sorry for the trouble. We will be closing the Issue here in the docs, as you can now follow up directly with support for further assistance.
Twilio SendGrid Docs Team


Adding version.cuh

Adding version.cuh based on Thrust version.h
Bug 2880952

Please bump the version to 1.9.9, which is the next release.

Please bump the version to 1.9.9, which is the next release.

Fix with 45e35c7
Direct link: https://github.com/thrust/cub/commit/45e35c7f5ec091a3cfab89087469f2690ac5ab18#diff-7627cc29bbee0a14b18395492ee5e80cR46


"email del" does not remove data directory, even if it says so

Context
While investigating my failing test on my PR (https://github.com/tomav/docker-mailserver/pull/884), I discovered that one feature is not working as expected and its test fails to provide guard.
When running ./setup -c mail email del<EMAIL_ADDRESS>there is an option to delete the data folder.
Sadly when that option is selected (-y or y at run time), it does not delete the directory.
Expected Behavior
The user should be removed from the account file and if I wish the maildir folder should be deleted too.
Actual Behavior
Mail folder is not deleted.
Possible Fix
The script delmailuser is ran from setup.sh in a docker "run" command. This command only mount the configuration directory and not the persistence of the mail folder so obviously the "normal" server will not have its maildir (inside the container or on the host filesystem) deleted as it only tries to delete a folder in a docker run once container.
Steps to Reproduce

launch the setup for tests "mail, mail-xx"
add a user through the script
delete a user through the script
check the existence of the folder on the main "mail" container

The impact
The test that is supposedly validating this feature does not its job and fails to "see" the issues.
I will comment that test in my PR as it does not work as expected (when I finish)

Yes, I just started redesigning the tests today and realized that useless test as well. (the delmailuser script works as expected, but the setup.sh script is running against the image, not the actual container.)
Workaround would be to call the delmailuser script from within the container. (docker exec mail delmailuser ...)
Will be fixed with my next PR! Thanks a lot for reporting!

@17Halbe @callmemagnus any progress on this?

This issue was closed due to one or more of the following reasons:

Age
Contributor inactivity
The issue seems to be resolved

If you think this happened by accident, or feel like this issue was not actually resolved, please feel free to re-open it. If there is an issue you could resolve in the meantime, please open a PR based on the current master branch so we can review it.


[meta] Update NEAR Proto definitions for the latest Firehose types

The type definitions have been updated for the NEAR firehose. In order to migrate to the latest version, we need to make the Graph Node and graph-ts types compatible too

[ ] Add types to Graph Node
[ ] Update hosted service configuration (near-mainnet, add near-testnet) & handle switch-over

This sounds good @maoueh - let us know when the v1 symlink is in place and we can make the config update

We will also add testnet support at the same time as this switch-over, assuming the endpoint is ready cc @sduchesneau

To fix an issue when dealing with undo on Near, we will need to add a field previous_block_height in the protobuf definition so we are able to fully reconstruct the parent ptr when a block is undo.
This means we will need to reprocess again so we will need to post-pone a bit the upgrade.


Easiness to merge with existing applications

Hi, first thanks for the time saver simple base. However, having some comments about the pythonic interpretation which can be subjective to the perspective. The following are suggestions for better usage of the repository.

It wasn't so easy merging the UI base with an existing application, that was due to a circular import.
there are some pythonic oop bugs or better ways to approach the solution
no need for global variables since they are already included in the Functions class
too many comments with no added details than the declared already in functions names
In the repository, the credits are for the writer (Wanderson M. Pimenta), yet the repo doesn't follow any licensing, It would be helpful to include a license, MIT recommended.
the skin color is somehow limited, it would be nicer to include a light skin besides the dark one.

besides those comments the repo is really helpful and time saver, thanks a lot!

Thank you for the tips @ramymagdy-rm !
The aim of this project was to serve as inspiration for new projects, showing that it is possible to create modern interfaces using Python and its official interface module (PySide2). This was a personal project that I decided to share publicly.
Feel free to use as inspiration, use in your projects, fix bugs and improve as needed.
A license was added to the project and a new file called "app_modules.py" to call all additional modules dependent on the interface of the application.
If you want to use it commercially, I recommend reading it on the official Qt website because there are limitations:


Got error on webSocketNotConnected after scan an QR code

Describe the bug
For now, the example app is not working when scanning the QR code.
SDK Version

Client: Swift
Version: v0.7.0-beta.101

To Reproduce
Steps to reproduce the behavior:

Go to https://react-app.walletconnect.com
Click on connect
Open example wallet App
Scan the QR code
Error shown

Expected behavior
Wallet connect should establish the connection.
Screenshots

Device (please complete the following information):

Device: iPhone12Pro Max
OS: iOS15
Browser: Chrome

For me, this was fixed in v0.8.1-beta.102

@Imcmz still an issue?

I was able to reproduce the error only with a debugger connected and activated breakpoint for >~30. Web socket disconnects in abnormal conditions and there is not trigger to connect it back. It may be inconvenient during debugging but won't cause any issues after app release.
If anyone can notice that behaviour without activating breakpoint please let us know so we can examine the issue closer.

Let me update my local version and re-test it. Thanks

Tried the latest code, and it works fine. :)
Close it accordingly

Encountered this issues again recently, hence reopen it. It happens intermittently.

@lmcmz is it possible that it was caused by the breakpoint?

Ahh, yes.  That's good point !!
It does happens when I put breakpoint in Xcode.
Let me close it then, if I encountered other scenario will update here again.
Thanks, @llbartekll


create a website

Build the backend
Build the front end
Get a server for hosting the website

https://bajpaik.github.io/github-slideshow/


TTF version?

I appreciate the whole point of this font is that it's dynamically generated, but we're curious about using it as a font for a brand. In this instance, we'd need to be able to use it in an old fashioned Adobe scenario - is there a way to output a traditional TTF / OTF etc file?

I'm actually working on with Google Font team for that. I think the best way is that export all the types to SVG and convert it to OTF. You may can get the font file on Google Font website if I can success to convert it.

Thanks for the speedy response!
Do you have any tips on how we would export as SVG?

https://gliffy.github.io/canvas2svg/ it works well, I may can add this one to my examples

That would be amazing!

Yes I love the idea of having the option of actual font files!
@cmiscm please release TTF/OTF versions of this beautiful font.
I love Geometric Sans fonts but haven't came across many good ones. So far Publica Sans is the closest to the pure, geometric look that I'm going after. Your font is basically perfect for my aesthetic, and I would love to be able to use them in my design!

Hello - I feel like this is the perfect font for me HOWEVER I would need the traditional TTF / OTF to have consistent branding. Please let us know if you ever publish the  traditional TTF / OTF. Excellent work - you are very talented!

+1 would love to use this if served up via google fonts!

Any news? @scottybo

Not sure why I would have any news @Droyk !

@scottybo @Droyk hey it seems like the author did create OTF versions!
https://github.com/cmiscm/leonsansfont

Yup, my bad! @sammdu @scottybo


mTLS: encrypted alert and TCP RST

Bug description
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
istio 1.5.4
k8s 1.14.8
I use mTLS mode permissve for my istio cluster, when capture traffic from ingressgateway I got follow tcp flow.

why there are too many encrypted alert and TCP RST ?

This is interesting. @lizan do you know anyone from Envoy community can help investigate?

Is this the traffic from the ingressgateway to a cluster internal workload?

yes. ingressgateway to my web service

Hi,
I'm also seeing TCP RST with an external service for which TLS origination is configured.

Could we reopen this issue?


Add enum entries for Microsoft JDKs

Microsoft publishes its own builds of OpenJDK:

https://www.microsoft.com/openjdk
https://docs.microsoft.com/en-us/java/openjdk/download

Adding these enum entries will allow type-safe configuration of the vendor filter as shown here.

@bot-gradle help

Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
test and merge to trigger a pre-tested commit build
cancel to cancel a running pre-tested commit build or remove it from queue
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle QF SC

Sorry I don't understand what you said.
Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
test and merge to trigger a pre-tested commit build
cancel to cancel a running pre-tested commit build or remove it from queue
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle QF

Sorry I don't understand what you said.
Currently I support the following commands:

@bot-gradle test {BuildStage} to trigger a build

e.g. @bot-gradle test SanityCheck plz
SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/ReadyForMerge/ReadyForNightly/ReadyForRelease are supported
test this means test ReadyForMerge
test and merge to trigger a pre-tested commit build
cancel to cancel a running pre-tested commit build or remove it from queue
SanityCheck can be abbreviated as SC, ReadyForMerge as RFM, etc.
Specific builds:

AST: AllSmokeTestsReadyForMerge
AFT: AllFunctionalTestsReadyForMerge
ASB: AllSpecificBuildsReadyForMerge
ACC: AllConfigCacheTestsReadyForMerge
ACT: AllCrossVersionTestsReadyForNightly
APTN: AllPerformanceTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle help to display this message
@bot-gradle clean to clear the conversation history

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.


Multi column github join returning too many rows?

I'm trying to get commit data for each tag in a github repo. But, when I do the join it seems to return too many columns each time?
> select commit_sha from github_tag where repository_full_name = 'turbot/steampipe-plugin-aws'
+------------------------------------------+
| commit_sha                               |
+------------------------------------------+
| fa2897d55f312b94176f255d21cf15430e83e9ff |
| c64562b03df0badfb64f0fb5581a829a4bb01087 |
| 29b8c635414dc2268eef1ffb38dd0085164c6a5a |
| 39e6fc4ffb360904cd244a9a637d73313fdfdd67 |
| 7ae796c3e3b1aefbe60a5810ca8f971dbd05745f |
| 91961cd85387ff271a5e720e838ce1c3f55f34c9 |
| 956c8debeb3049e4344f019ef3ecfb0f442ae065 |
| dd02b8ed972e46f88661049d74970c10f0897220 |
| a3c7da8c6b1f190afe155209cf7a77c5b4d703e3 |
| 27a996429a1268ea861cc5cb43d0344c3d592297 |
| 48bd0cd4c3267d36f11926be5678605fb225c16b |
| 4a47bede92f5624c1763025bf43d2ce9a665fa71 |
| 4521aa40811e5dc401f822d769aa6ece541f3fe8 |
| b1f4519a1d013cf239b1f3f180f899a6fa6a6c60 |
| 92676be13febc0e290191fbcb5ab05383fcf9f0f |
| 7872804fb729b88bfda4361d6cf9f626c8a3f19a |
| 3b749b51b41609b42059d2f843bf78dbf6ad98b4 |
| da4ccff31bb1881a2c43f642c8658529a129d899 |
| 7263eb680c8b1799fc4394b159b089db13145ad7 |
| abd8a067d8031b85a50084e9d6af8979371e4e14 |
| d2da467b6182c7c539c4f3020244edd4bed7a122 |
| d2da467b6182c7c539c4f3020244edd4bed7a122 |
| d2da467b6182c7c539c4f3020244edd4bed7a122 |
| e04d29c2d7d41296652c38157115fccfee5bf772 |
+------------------------------------------+
>
>
> select count(*) from github_commit where repository_full_name = 'turbot/steampipe-plugin-aws' and sha in (select commit_sha from github_tag where repository_full_name = 'turbot/steampipe-plugin-aws')
+-------+
| count |
+-------+
| 167   |
+-------+
>
> select count(*) from github_commit where repository_full_name = 'turbot/steampipe-plugin-aws' and sha = any(select commit_sha from github_tag where repository_full_name = 'turbot/steampipe-plugin-aws')
+-------+
| count |
+-------+
| 167   |
+-------+
>
>
> select count(*) from github_commit as c, github_tag as t where c.repository_full_name = 'turbot/steampipe-plugin-aws' and t.repository_full_name = 'turbot/steampipe-plugin-aws' and c.sha = t.commit_sha
+-------+
| count |
+-------+
| 4008  |
+-------+

solution is to add in optional key columns to the path keys we generate
select count(*) from github_commit as c, github_tag as t where c.repository_full_name = 'turbot/steampipe-plugin-aws' and t.repository_full_name = 'turbot/steampipe-plugin-aws' and c.sha = t.commit_sha
+-------+
| count |
+-------+
| 28    |
+-------+

it is unclear why this is necessary - here is the plan:
 explain select count(*) from github_commit as c, github_tag as t where c.repository_full_name = 'turbot/steampipe-plugin-aws' and t.repository_full_name = 'turbot/steampipe-plugin-aws' and c.sha = t.commit_sha
+-------------------------------------------------------------------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                                |
+-------------------------------------------------------------------------------------------------------------------------------------------------------+
| Aggregate  (cost=20000212510000.00..20000212510000.01 rows=1 width=8)                                                                                |
|   ->  Nested Loop  (cost=0.00..20000200010000.00 rows=5000000000 width=0)                                                                             |
|         ->  Foreign Scan on github_commit c  (cost=0.00..20000000000000.00 rows=1000000 width=200)                                                    |
|               Filter: (repository_full_name = 'turbot/steampipe-plugin-aws'::text)                                                                    |
|         ->  Foreign Scan on github_tag t  (cost=0.00..200.00 rows=1 width=200)                                                                        |
|               Filter: ((repository_full_name = 'turbot/steampipe-plugin-aws'::text) AND (repository_full_name = 'turbot/steampipe-plugin-aws'::text)) |
+-------------------------------------------------------------------------------------------------------------------------------------------------------+

and here is the plan with the optional key columns
 explain select count(*) from github_commit as c, github_tag as t where c.repository_full_name = 'turbot/steampipe-plugin-aws' and t.repository_full_name = 'turbot/steampipe-plugin-aws' and c.sha = t.commit_sha
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| QUERY PLAN                                                                                |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Aggregate  (cost=20000212510000.00..20000212510000.01 rows=1 width=8)                                                                                |
|   ->  Nested Loop  (cost=0.00..20000200010000.00 rows=5000000000 width=0)                                                                                |
|         ->  Foreign Scan on github_commit c  (cost=0.00..20000000000000.00 rows=1000000 width=200)                                                                             |
|               Filter: (repository_full_name = 'turbot/steampipe-plugin-aws'::text)                                                                                |
|         ->  Foreign Scan on github_tag t  (cost=0.00..200.00 rows=1 width=200)                                                                                |
|               Filter: ((repository_full_name = 'turbot/steampipe-plugin-aws'::text) AND (repository_full_name = 'turbot/steampipe-plugin-aws'::text) AND (c.sha = commit_sha)) |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+


Do not propagate the first child's requestCause() for nested logs

Motivation:
With RetryingClient involved, a RequestLog can have child
RequestLogs. Currently, the parent RequestLog's request-side
properties are fetched from the first child, and response-side
properties from the last child. See: https://line.github.io/armeria/advanced-structured-logging.html#nested-log
However, if the first child request fails with an
UnprocessedRequestException (e.g. due to a connection refused error),
the first child's requestCause(), which is non-null, is propagated to
the parent log. As a result, even if the request eventually succeeded
thanks to retries, the parent log's requestCause() will be non-null,
making MetricCollectingClient consider the request as a failure.
Modifications:

Always use null as a parent requestCause().
Miscellaneous:

Fixed a bug where DefaultRequestLog.endRequest() does not set
requestHeaders properly.

Result:

MetricCollectingClient correctly records the metrics of the request
which succeeded after a retry due to a 'connection refused' error.
RequestLog.requestHeaders() has some headers set even for the
requests that failed early, i.e. without writing anything.

Thanks for reviewing, @ikhoon

Note: This issue was reported by @andrey-tpt via our Slack workspace. Thanks, @andrey-tpt!


Custom search function

Hello, I'm trying to modify the search behaviour to be hyphen insensitive so when the user types "Alava", he will get a result "Álava" as a match. I wonder if we could have a similar function like "item-projection" to define the search behaviour.
Many thanks

Right now I have found a workaround by overiding the filteredItems computed method as follows but it would be very interesting to be able to overide it as a parameter.
SimpleTypeahead.computed.filteredItems = (self) => {
  // Normalize string before performing the search
  // Normalize string before performing the search

  const regexp = new RegExp(
    self.escapeRegExp(
      self.input.normalize('NFD').replace(/[\u0300-\u036f]/g, '')
    ),
    'i'
  );

  return self.items.filter((item) =>
    self
      .itemProjection(item.normalize('NFD').replace(/[\u0300-\u036f]/g, ''))
      .match(regexp)
  );
};````


[Bug]: scrollbar appears with modal in 2.1.0

Before submitting...

[X] I have searched for duplicate or closed issues.
[X] I have read the CONTRIBUTING document and my issue is following the guidelines.
[X] I have read the template completely before filling it in.

Context
The vertical scrollbar appears on the right  when using modal

Expected behavior
no scrollbar
Possible Solutions or Causes
I think the bug is due to the code :
   html.noscroll {
              position: fixed;
              overflow-y: scroll;
              width: 100%
               }

in https://github.com/materializecss/materialize/blob/main/sass/components/_global.scss  line 118
I think the code should be replaced by:
   html.noscroll {
              position: fixed;
              overflow-y: hidden;
              width: 100%
               }

to remove the scrollbar:

Steps to reproduce
1.Open the link : https://materializeweb.com/modals.html
2. open a  Modal
Your Environment

Version used: Release 2.1.0

I can prepare a PR if the diagnosis and solution are correct

Hello @OlivierMadant
This is intendent behavior. Because before the page content was jumping if a modal is opened. It only appears when there already is a scrollbar.

Hello @wuda-io ,
Thank you for your quick reply and great work.


feat(security): add security as a content type

Implements https://github.com/kentcdodds/all-contributors/issues/106

:tada: This PR is included in version 2.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


test: updates to allow #1102 to be merged

These are some changes to tests that when merged with PR #1102 will hopefully allow the tests to continue working.

Thank you @blgm.
I think the tests uncovered an actual problem, though: Values which are returned by the function NewWorkspace changed with #1102. Namely, the function does not return proper go zero-values in case function inputs are empty or nil.
I proposed #1115 to fix this.


update vagrant to reflect recent changes to yaml files

With the commit<PHONE_NUMBER> [Simplify OVN install] certain changes were
made to ovnkube yam files -- master, node, policy, and so on.
This commit reflects those changes in vagrant so that we can start
using it.
Signed-off-by: Girish Moodalbail<EMAIL_ADDRESS>

Thanks for the fixes (I generally run vagrant without dameonset).

@girishmg I think DKMS package should be installed for dameonsets too. We don't install DKMS module via daemonset, do we?


boolConversionCheck should throw an error with a description

Today you get: Instance of 'AssertionError' if boolConversionCheck fails in checked mode.
I think we can do better.

The spec prescribes the operation of boolean conversion:
(bool v){
    assert(v != null);
    return identical(v, true);
}(o)

In checked mode the bool type annotation takes priority.
The error is only an assertion failure for the value null.
I think the most reasonable enhancement that sticks to the letter of the spec would be to add a message to the assert once assertions with messages are supported.
The VM hides any helper code.
Turing on various checks shows that it does not strictly follow the spec:
--enable-asserts does not enable any part of the check
--enable-type-checks enables both the type check and the assertion.
VM:
Unhandled exception:
type 'int' is not a subtype of type 'bool' of 'boolean expression'.
#0      main (file:///home/sra/play1/bug6i8k.dart:2:6)

Unhandled exception:
Failed assertion: boolean expression must not be null
#0      main (file:///home/sra/play1/bug6i8k.dart:2:6)

dart2js shows several frames of helper code. These could be marked to be elided.
out.js:1012: type 'JSInt' is not a subtype of type 'bool'
      throw H.wrapException(H.TypeErrorImplementation$(value, "bool"));
      ^
type 'JSInt' is not a subtype of type 'bool'
    at dart.wrapException (out.js:624:17)
    at dart.boolTypeCheck (out.js:1012:15)
    at dart.boolConversionCheck (out.js:989:9)
    at dart.main (out.js:1795:13)

out.js:1058: Assertion failed
        throw H.wrapException(new P.AssertionError());
        ^
Assertion failed
    at dart.wrapException (out.js:624:17)
    at dart.assertHelper (out.js:1058:17)
    at dart.boolConversionCheck (out.js:990:9)
    at dart.main (out.js:1795:13)


Better suggestions in VSCode chat

I am not sure if this is normal difference because of the nature of AI, but I find the suggestions based on a single file and a directed question produces better results in VSCode over copilot-chat. Here is the sample buffer attached in both VSCode and Emacs (copilot-chat-add-current-buffer)
---
question:
  - text: Which of the following is not an assignment operator?
  - code:
      - '**='
      - '/='
      - '=='
      - '%='
answer:
  - code: ==
tags:
  - basics
  - operators
exam: None
book: None
---
question:
  - text: Which of the following is valid logical operator
  - code:
      - '&&'
      - '>'
      - 'and'
      - '=='
answer:
  - text: and
tags:
  - basics
  - operators
exam: None
book: None

Here is the sample prompt given to Emacs and VSCode
Convert the following questions to yaml format strictly following the example.yml file attached. Include answers, tags and marks for each question.

1. Which of the following commands will create a list?
2. list1 = list()
3. list1 = []
4. list1 = list([1, 2, 3])
5. all of the mentioned

The response returned in Emacs is
questions:
  - question: "Which of the following commands will create a list?"
    options:
      - "list1 = list()"
      - "list1 = []"
      - "list1 = list([1, 2, 3])"
      - "all of the mentioned"
    answer: "all of the mentioned"
    tags: ["list", "creation"]
    marks: 1

The response returned in VSCode is
---
question:
  - text: Which of the following commands will create a list?
  - options:
      - code: 'list1 = list()'
      - code: 'list1 = []'
      - code: 'list1 = list([1, 2, 3])'
      - code: 'all of the mentioned'
answer:
  - code: 'all of the mentioned'
tags:
  - lists
  - creation
marks: 1

The example.yml file contains 55 questions, and the prompt contains 15 questions. Only a sample is attached above. I have similar results with most responses based on attached buffers in Emacs.

When you open the chat window, by default, it does not add any buffer to the context -- you need to do it by calling copilot-chat-prompt-split-and-list and adding the buffers to the context.
I've got the following response after ensuring the example file was in the chat context:
[11:35:18] Convert the following questions to yaml format strictly following the format in the example file attached. Include answers, tags and marks for each question.

1. Which of the following commands will create a list?
2. list1 = list()
3. list1 = []
4. list1 = list([1, 2, 3])
5. all of the mentioned
## [11:35:19] Certainly! Here is the conversion of the provided questions to YAML format, strictly following the format in the example file you mentioned:

questions:
  - question:
      - text: "Which of the following commands will create a list?"
      - code:
          - "list1 = list()"
          - "list1 = []"
          - "list1 = list([1, 2, 3])"
          - "all of the mentioned"
    answer:
      - code: "all of the mentioned"
    tags:
      - python
      - lists
    marks: 1

This YAML format includes the question, possible answers, the correct answer, tags, and marks for each question. Adjust the tags and marks as needed based on your specific requirements.

I ended up creating a function that always adds the current buffer to the context before displaying the chat
https://github.com/kassick/dotfiles/blob/main/dots/emacs/spacemacs.d/layers/kzk-copilot/funcs.el#L47
(defun kzk/copilot-chat-display (prefix)
  "Opens the Copilot chat window, adding the current buffer to the context.

Called with a prefix, resets the context buffer list before opening"
  (interactive "P")

  (require 'copilot-chat)
  (let ((buf (current-buffer)))

    ;; Explicit reset before doing anything, avoid it resetting later on
    ;; target-fn and ignoring the added buffers
    (unless (copilot-chat--ready-p)
      (copilot-chat-reset))

    (when prefix (copilot-chat--clear-buffers))

    (copilot-chat--add-buffer buf)
    (copilot-chat-display)))

Thank you for your response. In my OP I mentioned adding the buffer example.yml through copilot-chat-add-current-buffer. I verified the addition of the buffer through copilot-chat-prompt-split-and-list. The response I receive is as follows.

After which, I used the nice function you've provided for adding the current buffer and obtained the following response.

I performed the above tests in separate emacs session, though I'm still not sure if the difference is just AI being AI. As you can see, the second image is far closer to the original source and VSCode as well.
In both the images, I have opened the buffer list alongside the prompt, to show that the file has been attached.
Let me know if I am doing anything incorrectly.

Hi,
I created a example.yml with your data, started emacs, called copilot-chat-display, pasted your prompt, C-c l, selected example.yml and sent prompt.
Here is what I got :
 * *[18:21:15]* Convert the following questions to yaml format strictly following the example.yml file attached. Include answers, tags and marks for each question.

1. Which of the following commands will create a list?
2. list1 = list()
3. list1 = []
4. list1 = list([1, 2, 3])
5. all of the mentioned
** *[18:21:16]* ```yaml
---
question:
  - text: Which of the following commands will create a list?
  - code:
      - list1 = list()
      - list1 = []
      - list1 = list([1, 2, 3])
      - all of the mentioned
answer:
  - text: all of the mentioned
tags:
  - basics
  - lists
marks: 1
---

This seems correct. I can't see any difference with what you described in your last comment, sorry.
(Note that Copilot is using Markdown, even though the prompt explicitly requests the use of Org-mode syntax only.)

I guess I being unnecessarily picky about the expected structure of the yaml file, which may vary based on every run. I'll close the issue. Thank you for your response.