Add support for shared analysis configurations.

A tracking issue for analysis configuration sharing as described in the Sharing Analysis Options Rethink doc.

First cut out for review:  https://codereview.chromium.org/1923973004/


feat: confirm deletion

Adds input to type in project name before being allowed to delete
Fixes css visibility issue with restore modal

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.36%. Comparing base (23f7f20) to head (43f4e73).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1192      +/-   ##
==========================================
+ Coverage   71.33%   71.36%   +0.02%
==========================================
  Files         301      302       +1
  Lines       10411    10419       +8
  Branches     2423     2425       +2
==========================================
+ Hits         7427     7435       +8
  Misses       2984     2984

Flag
Coverage Δ

unitests
71.36% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support both a number of iterations and Duration

In JMeter I can set both a number of iterations and specify a thread lifetime (Duration) for a ThreadGroup, however, the DSL currently does not support this.
Use case:
I specify the thread lifetime to make sure a test does not exceed a certain duration
Screenshot:

Thank you for asking for this!
This is an interesting use case. Anyone else with the same need?
We may implement something like:
threadGroup()
 .rampTo(1, Duration.ofSeconds(1))
 .holdIterating(30)
 .upTo(Duration.ofMinutes(200))

Any other ideas or comments?

That looks good to me, very easy to see at a glance what it does

This has been added on latest release


Native cross section

Is there currently any more "native" way to take and view cross sections of Mesh objects?
I see the example under trimesh, but I'm having some trouble installing required libraries (particularly shapely gives some trouble, on Windows 64bit).

you can check out examples/basic/surfIntersect.py to obtain a set of lines or can also slice a thin slice with .cutWithPlane() method which results in a mesh.
vedo --search cutWithplane -i
vedo --run inset

Perfect! It seems you have already made a method for everything 🥇


Disable by default RunningSpanStore, and enable if Zpages are initialized.

Fixes https://github.com/census-instrumentation/opencensus-java/issues/1813

Updated changelog, also allow users to set a limit.

@songy23 this issue is totally independent of blocking. blocking can occur if users forget or not to close some of the spans. This issue is related to OOM-ing if Spans are not correctly ended.


kie-issues#1387: Adjust pipelines to use the gpg key provided by Apache to sign the artifacts

Part of: https://github.com/apache/incubator-kie-issues/issues/1387

PR job #17 was: UNSTABLE
Possible explanation: This should be test failures
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/17/display/redirect
See console log:

Console Logs
Starting building: KIE » kogito » main » pullrequest » kogito-images.build-image #46Starting building: KIE » kogito » main » pullrequest » kogito-images.build-image #48Starting building: KIE » kogito » main » pullrequest » kogito-images.build-image #44Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-base-builder: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-jit-runner: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-jobs-service-postgresql: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-data-index-postgresql: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-data-index-ephemeral: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: UNSTABLE[Pipeline] unstableWARNING: Tests on kogito-data-index-ephemeral seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-jobs-service-ephemeral: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: UNSTABLE[Pipeline] unstableWARNING: Tests on kogito-jobs-service-ephemeral seems to have failed[Pipeline] }[Pipeline] // stage[Pipeline] }Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1778 - kogito-jobs-service-allinone: https://github.com/apache/incubator-kie-kogito-images/pull/1778 completed: SUCCESS[Pipeline] }[Pipeline] // stage[Pipeline] }[Pipeline] // parallel[Pipeline] }[Pipeline] // dir[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Declarative: Post Actions)[Pipeline] script[Pipeline] {[Pipeline] sh+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/17/api/json?depth=0'[Pipeline] readJSON[Pipeline] sh


Add a warning regarding outdated dev-dependencies left over from old …

…versions (<= 6.4) of the production template

Pushed too quickly, we'll need this in the 6.5 recipe as well. I'll rebase on @pweyck s branch.


Is there a way to share from local file instead of Url?

Is there a way to share from local file instead of an Url?
Right now I'm taking a screenshot, uploading it to firebase and then sharing with the url from firebase. 😬

Nope now such things implemented yet


Unused write database connections.

Everytime a connection is initiated for any query with seperate read and write hosts, eg:
<?php $user = \App\User::find(1); ?>

... a connection is made to the write node. This occurs even when no writing queries are run (including set names 'utf8', etc).

@ryannjohnson Could you test the following config.
DB_CONNECTION=mysql::read

instead of
DB_CONNECTION=mysql

@crynobone Using ::read could allow me to create a workaround (turn off config caching and detect the uri). However, even when I'm able to get Illuminate\Database\DatabaseManager::parseConnectionName() to parse the ::read correctly, the following queries (and therefore the write connection) is still run:
execute pdo_stmt_00000001: set names 'utf8'
execute pdo_stmt_00000002: set search_path to "public"

Note that I'm using 5.0.

NB, 5.0 is not supported, but I assume the issue is the same in 5.1.

Closing due to no response.


MSL120DA HomeKit Native

Please explain your feature request in a one or two sentences.
Added some MSL120DA smart bulbs which are native HomeKit items but they showing up as not native and therefore replicating inside Home as native and via bridge.

Is your feature request related to a problem? Please describe.

Any particular Meross devices that this relates to?
Model			MSL120DA
Hardware Version	7.0.0
Firmware Version	7.2.7

Anything else?

Hi @AndreGT6 thanks for this
I published a beta version of the plugin which should remove this device from your homebridge

@bwp91 thank you so much! That did the trick.


computer vision nanodegree

Respected sir, can you pls arange computer vision nanodegree by nvidia

Unfortunately, they don't list (and make available) all the courses in that nanodegree for free. I am not affiliated with Udacity - if you don't see the content available, I don't have access to it either.


Fix rSNBATWPL output to match rsnbatwpl-cli.js

Fix rSNBATWPL output to match rsnbatwpl-cli.js when called with filename argument, see here. See also this issue. I will fix this answer accordingly.

Nice, thanks!


Why preserve self loops?

Just a question about the build_path function in the simplify.py module.
You've written an if statement to identify and preserve the nodes in self loops, but (I'm pretty sure) the vast majority of self loops in the OSM road network represent cul-de-sacs. For most purposes I'd consider these to be the same as endpoints (at the very least don't represent real intersections).
Before I go tinkering with your script to change that for my purposes I was curious what your thinking was here and if perhaps there's something I'm missing. Thanks!

There are a decent number of self-loops in a street network's graph, such as here. Some represent the intersection of 3 or 4 street segments. Some loops are very long (some suburban areas have 200m loops). Either way, if we break them, we get an inaccurate representation of the topology and can break accessibility to parcels along the loop.

I see, thanks for explaining!


User Voice to request Components

Reply to this thread with any Element you'll want to see in Papanasi and we will consider the ones with more votes:
Prioritized List:

[ ] Skeleton Layout element https://ant.design/components/skeleton/

Toast Extension https://getbootstrap.com/docs/5.1/components/toasts/

Popover Component https://popper.js.org/

Select Component https://react-select.com/home

Tabs Component https://mui.com/material-ui/react-tabs/

Text Editor https://xdsoft.net/jodit/

I just found the link to this lib from the mitosis page. Do you plan to include React-Native in the future?

@dohomi
Any mitosis lib can be supported in the future, but right now the experience is a little pain, then I'll first be sure that the ones supported are working well.

Toast Extension https://getbootstrap.com/docs/5.1/components/toasts/

Any good idea for renderToBody   multi framework?

I very keen for a library like this that has material design components.  Similar to Vuetify, but for all frameworks.
Is this roughly your vision, too?  If so, can I get involved with building out some of these components?
If not, would you mind if I were to folk the project and start building in that direction?

I'm very keen for a library like this that has material design components. Similar to Vuetify, but for all frameworks.
Is this roughly your vision? If so, can I get involved with building out some of these components?
If not, would you mind if I were to fork the project and start building in that direction?

Sorry I didn’t see this message I’m not creating the new bootstrap, I’m trying to do a set of components but really customizable and dev oriented, I mean I expect the devs to change a lot of variables etc as I explain in the docs :) is not thought to be super simple to use and have all the websites with same ui

Idea: sharing component https://github.com/nicolasbeauvais/vue-social-sharing/issues/271#issuecomment-1481126774


Documentation Clarification for Negative Prompts

Great plug and highly useful. But I do not see any information about including Negative prompts. Is this possible to include in the prompt section? If it is not, please advise and maybe update the documentation?

i'll try to add negative prompts to the next update


ChmodAdapter: don't set hdr.Mode early as subsequent lines still need to read it

[test]

lgtm, thanks @jim-minter
[merge]

failed windows testing

[test]

@bparees I think the change itself is legitimate; the windows testing is failing on this PR (and indeed on master) because of what looks like a change in behaviour or regression in Docker.  The version of Docker has been updated in our CI rhel image from 1.10 to 1.12.  With the new version, there's an issue with the container not seeing stdin close correctly, at least when attaching to a container via the Docker API via TCP+TLS (as our CI system windows testing does).  Running locally over UNIX sockets, it works.  This is causing the CI testing hangs on windows and not linux testing.
I'll look at this further next week, aiming to (a) get a workaround on our CI and (b) deal with the root cause.

@bparees so if your s2i bump is in a hurry, I'd disable the windows ci and get this PR in and rolled up into your bump. If it can wait, I'll look at this on Mon.

i've disabled the windows test (hopefully).
[merge]


utils/curl.rb: accept 1xx HTTP status codes

RFC 2616 states:
A client MUST be prepared to accept one or more 1xx status responses
prior to a regular response, even if the client does not expect a 100
(Continue) status message. Unexpected 1xx status responses MAY be
ignored by a user agent.
In the rare cases that we encounter a formula URL with a server that
provides a preliminary 1xx status code, it seems that (at least during
audit) we are failing on encountering this status code, even though
retrieving the file will succeed without issues.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

This change addresses #6431.

Thanks @alebcay!


Add the ability to send an INIT IPI.

It looks like all the IPI delivery modes have methods to send them in the LocalApic struct, but not Init. Hence I propose adding these methods to complete this.
The INIT IPI is sent to a processor to initialize it prior to sending the Startup IPI.

Apologies if I missed it, but it does appear this functionality is missing so far. Some notes, however: I named the methods send_init_ipi_*, while others have names like send_nmi_*, send_sni_* etc, but I think it makes sense because the others already have "IPI" in the acronym itself, whereas INIT does not. However, if you prefer, I can rename them to send_init_*.
Also, will I need to bump the version up before this is merged in? It's technically a new feature so we might want to bump up the minor version.
I am happy to make any further changes.

Thank you! I agree with you about the name.


Add a --manual_seed flag to the CLI

Description

Allows manually seeding random number generators from the CLI via either --manual_seed or setting the MORPHEUS_MANUAL_SEED environment variable.
Makes testing example CLI pipelines easier.

Closes #1211
By Submitting this PR I confirm:

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

/merge


Update length scale metrics with new imageruler

The current imageruler algorithm reports inappropriately large length scales for "checkerboard" designs, which will be fixed with https://github.com/NanoComp/imageruler/pull/35.
We should re-generate the leaderboard once the updated imageruler algorithm is finalized.

This was completed with https://github.com/invrs-io/leaderboard/pull/29, which resulted in the expected reduction in minimum length scale for some solutions.


ng generate module

Will be possible to add this command to ng g module?
--flat flag to indicate if a dir is created

@Brocco what do you think?
Related: https://github.com/angular/angular-cli/issues/4155

I don't have an issue with this, even though I don't think I'd use it. But I do not want this implemented until a decision is made no the related issue from above #4155.

This option was added via this PR: #4767 - closing this issue.


[hotfix][runtime] fix grammatical errors in description

fix grammatical errors in description

Thanks for your PR @leesf!
Merging...

@flinkbot approve all

Fixed in master: b4593e52b4eb1dc35ab96615a0de0f3568cab7ce
Fixed in release-1.8: 645c47cb9bf485c55e28766747c72eca5f8e8735


Roll Engine from cdc49c575b0b to b9ecd8aca650 (2 revisions)

https://github.com/flutter/engine/compare/cdc49c575b0b...b9ecd8aca650
2021-02-11<EMAIL_ADDRESS>Always set change type to cancel with touchesCancelled on iOS platform view (flutter/engine#24333)
2021-02-11<EMAIL_ADDRESS>[web] Fix svg stroke when style is not provided (flutter/engine#24153)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Gold has detected about 13 untriaged digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/75827

@ferhatb to approve golden file diffs


Unpredictable behaviour resizing and moving slices

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.26.3
Expected results
Resizing a slice doesn't move other slices all over a dashboard.
Saving a dashboard saves the current positions.
Actual results
Resizing or moving one slice makes other slices move unpredictably.
Even after manually restoring the position, they won't be stored when saving the dashboard.
Steps to reproduce

Install superset 0.26.3 from pip or git clone following the documentation, including the sample dashboards. Open the "World's Bank data" dashboard.

Reduce the top left "region filter" size a little. As a result, the bottom right "box plot" slice is moved.

Move the "box plot" back to its original position at the bottom right of the dashboard.

Restore the top left "region filter" size. The box plot is moved again, move it back one more time.

Save the dashboard (it now looks like the original example dashboard).

Reload the page: the box plot is again in the wrong position and there is no way to put save it in the original bottom right position.

It looks like this was introduced by #5122 using react-grid-layout 0.16.6.
Dashboards v2 don't rely on react-grid-layout so I'm not sure if this needs to be fixed for v1 or we just wait for v2 in superset 0.27.

@octaviancorlade Same problems here. BTW, what is Dashboards V2? Under what circumstances will the dashboards use v2?

Dashboard v2 addresses all of this. The transition requires a bit of work. We need to release 0.27.0, which offers users a flow to convert their dashboards, followed by 0.28.x (where master is at now), which fully deprecates dashboard v1.

#4596 this is part of the solution


Report missing translations

Problem Statement
I just stumble upon a feature in the documentation of Laravel 10 that allows us to perform any action when the framework encounter a missing translation.
Solution Brainstorm
To be able to report a missing translation by opt-in for Sentry to catch it:
// app/Providers/AppServiceProvider.php

public function boot(): void
{
    Lang::handleMissingKeysUsing(function (string $key, array $replacements, string $locale) {
        Sentry::reportMissingTranslation($key, $replacements, $locale);

        return $key;
    });
}

I don't think that many people will be willing to burden the cost for each missing translation. As this then will also be reported for each request, your quota will be depleted in no time.


feat(#316): Replace 'scope' attribute with an appropriate object for all the usages

In this PR I entirely remove 'scope' attribute usage for all the AST nodes.
Now we use data objects instead.
The current implementation of 'attributes' looks a bit inconvenient and not so flexible.
This might cause problems in the future. For example, if we will decide to change 'attributes' representation one more time, it might require significant efforts to change the representation. The better approach would be to remove 'attributes' usage at all.
Closes: #316.
History:

feat(#316): use correct attributes in Constructor without using scope attribute. ALL TESTS PASS
feat(#316): fix static invocation attributes convertation
feat(#316): fix 'this' attributes convertation
feat(#316): fix 'field' attributes translation
feat(#316): fix 'local-variable' attributes translation
feat(#316): remove redundant code from XmirParser
feat(#316): fix 'static-field' attributes translation
feat(#316): fix 'super' attributes translation
feat(#316): start fixing Invocation class

PR-Codex overview
The focus of this PR is to update XML parsing and XMIR generation in various classes.
Detailed summary

Updated XML parsing in This, Field, Invocation, Super, Constructor, StaticInvocation classes
Updated XMIR generation in ClassField, LocalVariable, Field, Invocation, Super, Constructor classes
Added HexData import in LocalVariableTest class
Added EqualsAndHashCode and ToString annotations in ClassField, Field, Invocation, Super classes

The following files were skipped due to too many changes: src/main/java/org/eolang/opeo/ast/StaticInvocation.java, src/test/java/org/eolang/opeo/ast/ConstructorTest.java, src/main/java/org/eolang/opeo/ast/InterfaceInvocation.java, src/test/java/org/eolang/opeo/ast/ClassFieldTest.java, src/test/java/org/eolang/opeo/ast/SuperTest.java, src/test/java/org/eolang/opeo/ast/FieldTest.java, src/it/spring-fat/src/test/java/org/eolang/jeo/spring/FactorialApplicationTest.java, src/test/java/org/eolang/opeo/ast/InterfaceInvocationTest.java, src/main/java/org/eolang/opeo/compilation/XmirParser.java, src/main/java/org/eolang/opeo/ast/Attributes.java, src/test/java/org/eolang/opeo/ast/InvocationTest.java, src/test/resources/xmir/decompiled/StreamUtils$NonClosingOutputStream.xmir, src/test/resources/xmir/decompiled/Enhancer$3.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 6min)


Validation of dependent fields

I have two fields which are related. I would like to perform custom validation on the second field based on the value of the first field. Is this possible to do?

#150 answers my question


Show instance driver startup errors

Instead of just reporting that an instance driver isn't supported, report the reason for which it was marked as unsupported.

@tomponline feedback addressed

Testsuite passed


Nested properties support

Support for columns with nested properties. Declare these columns
as it follows: "address.street":{title:"..."}.
Signed-off-by: Dani Ughelli<EMAIL_ADDRESS>

Hi,
Could you provide a small example please ?

I've attempted a similar fix with an older version of the project (0.5.0-6), it works great for displaying the nested properties, but appears to break filter and sort functionality for the columns that use this nested style.

@hgarc014 is this available in v1.2.1. I am trying to use this feature but cont use it. Do I need to build the code with these changes?

This feature is not availble in v1.2.1. I build the code with the changes suggested. Code built properly and displayed the nested properties. The problem I saw was that, I couldnt filter the nested property.
Updated row.ts Please let me know if I am missing something:
import { Cell } from './cell';
import { Column } from './column';
import { DataSet } from './data-set';

export class Row {

  isSelected: boolean = false;
  isInEditing: boolean = false;
  cells: Array<Cell> = [];

  constructor(public index: number, protected data: any, protected _dataSet: DataSet) {
    this.process();
  }

  getProperty(data:any,property:string):any {
     let parts = property.split(".");
     let prop = data;
     for (var i = 0; i < parts.length && typeof prop !== 'undefined'; i++) {
         prop = prop[parts[i]];
     }
     return prop;
   }

  getCell(column: Column): Cell {
    return this.cells.find(el => el.getColumn() === column);
  }

  getCells() {
    return this.cells;
  }

  getData(): any {
    return this.data;
  }

  getIsSelected(): boolean {
    return this.isSelected;
  }

  getNewData(): any {
    const values = Object.assign({}, this.data);
    this.getCells().forEach((cell) => values[cell.getColumn().id] = cell.newValue);
    return values;
  }

  setData(data: any): any {
    this.data = data;
    this.process();
  }

  process() {
    this.cells = [];
    this._dataSet.getColumns().forEach((column: Column) => {
      const cell = this.createCell(column);
      this.cells.push(cell);
    });
  }

  createCell(column: Column): Cell {
    const defValue = (column as any).settings.defaultValue ? (column as any).settings.defaultValue : '';
    //const value = typeof this.data[column.id] === 'undefined' ? defValue : this.data[column.id];
    var value = this.getProperty(this.data,column.id);
    value = typeof value === 'undefined' ? defValue : value;
    return new Cell(value, this, column, this._dataSet);
  }
}

This fix will bug out when the nested property doesn't exist. You may want to have it validate whether the nested property actually exists since that can get to be a real pain when using this with Mongodb.

even if the nested property exist it bug too, the first argument of filterFunction is always empty when its a nested property

i found a solution for filtering on nested data just change yout node_modules/ng2-smart-table/lib/data-source/local/local.filter.js
var LocalFilter = /** @class */ (function() {
function LocalFilter() {}
LocalFilter.filter = function(data, field, search, customFilter) {
var filter = customFilter ? customFilter : this.FILTER;
return data.filter(function(el) {
let parts = field.split(".");
let prop = el;
for (var i = 0; i < parts.length && typeof prop !== 'undefined'; i++) {
prop = prop[parts[i]];
}
return filter.call(null, prop, search);
});
};
LocalFilter.FILTER = function(value, search) {
return value.toString().toLowerCase().includes(search.toString().toLowerCase());
};
return LocalFilter;
}());
export { LocalFilter };
//# sourceMappingURL=local.filter.js.map

News?


OS Command

Hello team,
I hope you are doing well :)
A potential OS command injection vulnerability has been identified in the reflect.go file within the GitHub repository of the nginx/agent project. The vulnerability arises from unsanitized user input from the execOnly flag, which is directly utilized in constructing an exec.Command, allowing a malicious user to inject arbitrary commands into the system shell.
Steps to Reproduce:

Clone the Repository: git clone https://github.com/nginx/agent.git cd agent

Navigate to reflect.go: Open the reflect.go file using your preferred text editor. The vulnerable code is located at this link.

Identify the Vulnerable Code: Observe the usage of the execOnly flag at line 107: go cmd := exec.Command(program, "-output", filename)

Craft a Malicious Command: Set the execOnly flag to a malicious value: go run reflect.go -exec_only "malicious_command"
Replace "malicious_command" with any command you wish to inject.

Fix:
To address this vulnerability, it is essential to follow secure coding practices:
Replace the vulnerable code at line 107 with the following secure implementation:
cmd := exec.Command(program, "-output", filename, *execOnly)

This modification ensures that the user input from the execOnly flag is appropriately passed as a separate argument, reducing the risk of command injection. Additionally, consider implementing input validation and sanitization measures as outlined in secure coding best practices.
Impact
An attacker exploiting this vulnerability could execute arbitrary commands on the application server, potentially leading to data exposure, deletion, or other harmful consequences. The issue poses a significant risk due to the direct injection of unsanitized user input into the system shell.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[x] I have read the CONTRIBUTING document
[ ] I have run make install-tools and have attached any dependency changes to this pull request
[x] If applicable, I have added tests that prove my fix is effective or that my feature works
[x] If applicable, I have checked that any relevant tests pass after adding my changes
[x] If applicable, I have updated any relevant documentation (README.md)
[ ] If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Hi team, it's a bug but my label is not changed to bug why ?

Hi @aravindb26 thanks for the PR.
I don't believe this change modifies the operation of the mockgen command. Based on the code paths, if exec_only parameter is set in the mockgen CLI, then that condition will be met on this line https://github.com/nginx/agent/pull/523/files#diff-d812b40f63d05eeefeb35d70ea6415076911fd9f6b4a89c97700fd0aaeeccf9dR46 and will get executed appropriately. The change you made uses the global variable execOnly gets passed as a command line argument to exec.Command. This does not change the operation of the underlying code and only passes this value as a parameter to that command. The program  variable is set as the exec_only value via the execOnly variable anyway and used in the line you modified.
If you feel this isn't correct, I'm happy to have a conversation about this. I will highlight the next steps from our perspective in another comment

Based on the version of mockgen we were using is read-only on github, I have replaced it with a forked version in this PR: https://github.com/nginx/agent/pull/524
If there are security concerns with the underlying code in mockgen I suggest raising an issue with the repository https://github.com/uber-go/mock and we can track it as an issue and update mockgen as appropriate since we don't use that functionality in mockgen in this repository.
I will leave the PR open until early next week for further comment, but if no more change is required, I'm happy to close it.

Based on the version of mockgen we were using is read-only on github, I have replaced it with a forked version in this PR: #524
If there are security concerns with the underlying code in mockgen I suggest raising an issue with the repository https://github.com/uber-go/mock and we can track it as an issue and update mockgen as appropriate since we don't use that functionality in mockgen in this repository.
I will leave the PR open until early next week for further comment, but if no more change is required, I'm happy to close it.

So u mean it doesn't have OS command injection vulnerability ? I mean i have submitted this report by keeping mind in attacker perspective and the fix i provided will mitigate the issue

the library has a potential vulnerability, so I recommend you open the issue with the repository I mentioned. The attacker would have to change our code to use the capabilities as we currently don't use that parameter. It does not impact the running of the binary we produce or our customers. The library is used to generate mocks as a once off operation, so if people modify any of that flow, it has to be reviewed by our team. Your code change does not fix the potential vulnerability

the library has a potential vulnerability, so I recommend you open the issue with the repository I mentioned. The attacker would have to change our code to use the capabilities as we currently don't use that parameter. It does not impact the running of the binary we produce for our customers. The library is used to generate mocks as a once off operation, so if people modify any of that flow, it has to be reviewed by our team. Your code change does not fix the potential vulnerability

I found bug in this repo know why should be reported in https://github.com/uber-go/mock repo ?

thanks for the reply, here is a reference on how golang manages dependencies https://go.dev/ref/mod
Since this isn't an issue I'm happy to close the PR as no further action is required


unable to lock screen in xfce

Issue description
It's not possible to lock screen in xfce unless "xlockmore" is installed.
Steps to reproduce

Add services.xserver.desktopManager.xfce.enable = true; in configuration.nix
Login in XFCE and try to lock without success
nix-env -i xlockmore and then retry to lock

Technical details

System: NixOS Emu
Nix version: 1.11.2
Nixpkgs version: "16.03.973.8bf31d7"

I think that's because there is no blessed lock screen for XFCE. xflock4 tries XScreenSaver, GNOME Screensaver, XLock and SLock -- in that order.

Has a situation like this (multiple optional but at least one required dependency on an executable) already been handled in NixOS?

I think this is generally resolved by some kind of switch, but we have to add one. Something like services.xserver.displayManager.xfce.screenLock of types.enum...

I kept slock as-is: see #22532

I think the issue may be resolved.
At least with my setup  (as of 2023-09-17) lock screen is possible without having xlockmore installed.


Draw road segment on map in a given color

live drawing on a map http://kasheftin.github.io/gmaps/


Update version string in the README to point to the 1.0.0-M15-1 release instead of the M15 one

The one -1 release is the one listed in Maven Central. The README still uses the M15 release (which cannot be resolved), which necessitates some investigation.
Please fix it.
Thanks.

@alexarchambault please update the version string from:
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0-M15")
to:
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0-M15-1")
People are running into problems due to this tiny error. E.g. #425

The 1.0.0-M??-? releases are not meant for a wide use. These should be used only if you know what you're doing (like you're interested in a recently fixed bug). The README only advertises the 1.0.0-M?? versions.


Implement asyncstreams

Implements:

Async streaming I/O when httpxUseStreams is true
Exposes request ID
Exposes parsed request content length

TODO In another PR:

Limit request header sizes to 8kib
Write documentation for streams mode

Tested with Prologue, it passes as well.

how's the performance change?

@bung87 Really bad. That's part of why I never finished it. You can checkout the branch and try it for yourself.

I've heard of the low performance when nim std provide stream api, because it uses dynamic dispatch functions.

I don't think mine uses dynamic dispatch, but there are problems with how httpx/httpbeast read sockets which makes the problem worse.
You can see my implementation here:
https://github.com/ringabout/httpx/blob/83f6a1a839ba0c322859f876938a8881100df4ec/src/httpx/asyncstream.nim
And its tests:
https://github.com/ringabout/httpx/blob/83f6a1a839ba0c322859f876938a8881100df4ec/tests/t_streams.nim

these functions associate with stream object are dynamic dispatch, no ?
result.readCbs = initDeque[AsyncStreamCb](1)
result.writeCbs = initDeque[AsyncStreamCb](1)
result.afterReadCb = afterReadCb
result.afterWriteCb = afterWriteCb

@bung87 AsyncStreamCb just a typedesc, not a method. It won't use dynamic dispatch vtables, but it does run a proc via its pointer. Not sure if that counts.

Any progress on this one?

@atlas-pouriya I've abandoned it, the architecture is just too different to support it without breaking everything or making a compiletime switch that requires a lot of conditional code which is hard to test.
I'll close it now.


The media palette is broken

https://user-images.githubusercontent.com/481418/118795052-30d05000-b868-11eb-819e-0895c2752e7b.png
Traceback (most recent call last):
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1241, in _buttonpress_cb
    self.button_press(
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1311, in button_press
    elif self._check_for_anything_else(spr, x, y):
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1624, in _check_for_anything_else
    self._select_category(spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1794, in _select_category
    self.show_palette(i)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 987, in show_palette
    self.show_toolbar_palette(n)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 1097, in show_toolbar_palette
    self.palette_views[n].create(regenerate=regenerate, show=show)
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 64, in create
    self._create_proto_blocks()
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 198, in _create_proto_blocks
    self._proto_skin(name + 'small', self.blocks[-1].spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tapaletteview.py", line 211, in _proto_skin
    x, y = self._turtle_window.calc_image_offset(name, spr)
  File "/app/lib/python3.8/site-packages/TurtleArt/tawindow.py", line 4863, in calc_image_offset
    iw = self.media_shapes[name].get_width()
KeyError: 'camera1small'

as reported on https://github.com/flathub/org.laptop.TurtleArtActivity/pull/5#issuecomment-843954442 , managed to reproduce myself.
One thing to note is it seems that clicking it the first time produces the error but going to another tab and then back to it works fine.

Is this issue fixed? Can't reproduce it.

Seems it's been fixed as I can't reproduce it too.


[wip] Refactor of metrics operator

This is WIP for a huge refactor because (like most things I make) I realized the design was not right / was not good enough. I'll include the notes here I shared in slack. Consider this a WIP because I have to update every single metric and test the case that I originally wanted with hpctoolkit, and I suspect that will take me a few more days (just started on this actually last night, damn). I want to be able to summarize this more simply, e.g.,:

A Metric Set is a collection of metrics to  measure IO, performance, or networking that can be customized with addons.

And for the expected use case (for now) I expect the user to choose one metric, and then customize with addons for their needs. And that's it. We will have a registry of metrics (as we do now) and a registry of addons (not created yet for the UI) that range from volume types to drop-in applications/containers.

To summarize my (possibly terrible ideas) the design we started with is as follows:

A Metric Set holds one or more metrics, and a separate entity that represents an application (lammps) or storage (anything from pvc to config map) or standalone "roll your own"-
One metric generates one JobSet with some number of replicated jobs
The Metric Sets come in flavors, storage and application, where the first expects a storage defined, the second shares the namespace, etc.

The Metric is an interface, so as I started to make different flavors of Metric interfaces (e.g., a Launcher Worker design that would generate a launcher replicated job and then workers as another one) I started to dislike it more and more - the designation of different Metric Set types didn't have a lot of meaning. It also seemed unlikely anyone would actually put two metrics alongside the same storage or application, at least it would be challenging. And the arbitrary need to define some specific storage or application was not very flexible. Then I started implementing actual applications (e.g., lammps) as metrics themselves. The goop hit the fan when I realized I wanted to put together two metrics, lammps that had a Launcher worker design, and HPCtoolkit, which was an entirely different thing that generated and shared a volume. I scribbled down some ideas last night at ~10pm (below, "MetricContainer" turned into more generic "Addon") and worked until 2am on the refactor. For the new design:

A Metric Set is a generic shell - there is one type that holds some number of metrics scaled to some number of pods.
There is a new entity, an "Addon" that you can add to a Metric
An addon is flexible to add volumes, containers, update entrypoints, or even provide applications.

Then means we can define HPCToolkit as an addon to the app-lammps metric, and it makes sense - we know HPCToolkit is going to add a container, an empty volume, and then update an entrypoint for the metric it is attached to. It also means all the storage tests we were doing? Well now a volume type is just an addon you add to, for example, the io-fio metric.
So I conceptually like the direction of this design more, but it's much more complex because I've essentially broken up a block of LEGO into much smaller pieces, and of course getting those to work and updating all the existing is going to be... a lot. I'm giving myself to the end of the week to get something working and then likely will need to abandon HPCToolkit.
Requirements before this can be merged:

[ ] All metrics re-implemented and re-tested in this new design
[ ] My Kubecon experiments also verified to function the same
[ ] A web UI of addons
[ ] A larger version bump here (likely alpha 1 to alpha 2)

And probably something else I didn't think of. I'm giving myself to the end of the week to complete this and prototype hpctoolkit as an addon with the lammps app. This probably could be enough work to spread out over a few weeks to a month... no pressure!

This was merged with #68


Update reference to IPAM/api

What this PR does / why we need it:
Since IPAM master now has go modules under /api folder, reference in CAPM3 should be changed accordingly.

/test-integration

/lgtm


In Google Sheets, selection tools window pops up when clicking any cell

Describe the bug
When in a Google Sheets document (https://docs.google.com/spreadsheets/), selection tools window pops up after every click on any cell, making navigation with mouse more difficult and covering parts of content.
To Reproduce
Steps to reproduce the behavior:

Open any Google Sheets document, such as https://docs.google.com/spreadsheets/d/your-sheet-id/edit
Click on any cell in the sheet (might need to wait for page to fully load first)
Selection tools window appears, covering nearby cells

Expected behavior
Maybe only enable Selection tools when actual text inside of a cell is selected, or a range of cells rather than one cell. Or add an option to blacklist some domains, but GPT could be useful in Sheets so it's not the best option.
Screenshots

Please complete the following information):

OS: Ubuntu 22.04
Browser: Firefox
Extension Version: v2.1.2

v2.1.5


Add content in Virtual Realms Section

When I go through your website on clicking on home page section .I see the virtual realms I was eager to learn about it more but when I am clicking on the Virtual Realms does not redirect to any page as I can't read the content of this topic .So, I want to add the content  related to  this topic like Abouts ,images , technology ,how does it work etc.
Additional context
Add any other context or screenshots about the feature request here.

we arent adding hardcoded articles at the moment , thanks


[NEW ALGORITHM]  Want to add dijkstra's shortest path algorithm in graph folder

Description:
Dijkstra's shortest path algorithm finds the shortest path from a source node to all other nodes in a weighted graph. It uses a priority queue to explore the least-cost path, updating distances as it processes each node. The algorithm guarantees the shortest path for graphs with non-negative weights.
Checklist:

[ ] Contributor in GSSoC-ext
[ ] Want to work on it
[ ] add hactoberfest label also

Additional Information:
Provide any other relevant information or resources regarding the algorithm.

@pankaj-bind kindly assign me


[BUG] Keyring never seen as saved -  ERROR :: root :: sync.py :: 116 :: Password is not stored in keyring. Please save the password in keyring.

I know this is a duplicate of the previous report, but am filing separately as that issue is awaiting a response. I am using the new /config directory layout for local config and session_data storage (as seen in the included docker-compose and config file)
Describe the bug
The authentication information is not correctly stored in the keyring, according to the app
App was working fine before the recent updates.  Love the app.  So dearly want it to be working again!
Platform: Synology NAS
To Reproduce

delete all session data in ./config
docker-compose up -d
log in using following command (outside docker container):
docker exec -it icloud /bin/sh -c "icloud<EMAIL_ADDRESS>--session-directory=/config/session_data"
answer "y" to save keyring prompt
enter TFA
assume that nothing returned means login was successful
either a) wait 10 minutes or b) stop container and restart
see error "Password is not stored in keyring"

Expected behavior
keyring save should result in successful login
Configuration
docker-compose.yaml
version: "3.4"
services:
  iCloud:
    container_name: icloud
    image: mandarons/icloud-drive:latest
    environment:
      - PUID=1000
      - GUID=1000
      - ENV_CONFIG_FILE_PATH=/config/config.yaml
      - TZ=America/Boise
    volumes:
      - ./config:/config
      - ./icloud:/icloud

I've also set the config to have logs at debug level. I don't see debug level logs.  I know the config is somewhat working, as the Discord notifications about TFA requirements are working
./config/config.yaml:
app:
  logger:
    level: "debug"
    filename: "/config/icloud.log"
  credentials:
    username<EMAIL_ADDRESS>    retry_login_interval: 600
  root: "/icloud"
  discord:
    webhook_url: https://discord.com/api/webhooks/XXXwebookidXXX
    username: iCloud-Files
  region: global
drive:
  destination: "drive"
  remove_obsolete: false
  sync_interval: 600
photos:
  destination: "photos"
  remove_obsolete: false
  sync_interval: 300
  all_albums: true
  folder_format: "%Y/%m"
  filters:
    file_sizes:
      - "original"

I'll add that subsequent attempts to authenticate do not prompt for password - just exits code 0.

Try setting the ENV_ICLOUD_PASSWORD variable.

I have the same issue. Setting ENV_ICLOUD_PASSWORD has no effect.

Same issue. Adding the ENV_ICLOUD_PASSWORD variable to Docker container does nothing.
I have it setup with Telegram. I get the notification to run the Auth command, since the variable is set it doesn't ask me for a password, and then I enter the 2FA code, it takes me back to a prompt.
2024-07-05 21:07:58,417 :: INFO :: icloudpy.base :: base.py :: 253 :: Session file does not exist
2024-07-05 21:07:59,567 :: ERROR :: root :: sync.py :: 100 :: Error: 2FA is required. Please log in.
2024-07-05 21:07:59,567 :: INFO :: root :: config_parser.py :: 69 :: Retrying login every 600 seconds.
2024-07-05 21:07:59,567 :: INFO :: root :: sync.py :: 109 :: Retrying login at Fri Jul  5 21:17:59 2024 ...

I have also tried the ENV_ICLOUD_PASSWORD variable.  Still no luck

Yep. Also still broken here.

Not for me. I am using that exact var.

@rix1337 Onboarding is not smooth, I give you that. I've had to find my way to various trials and errors to get the latest version to run properly. The latest release(s) have made some underlying changes that are most likely the cause of the confusion.
The other problem I am running into is this. Not a big deal, but it's not "clean." This never happened before the latest releases either. Are you seeing the same?

Agreed. The docker was working for months. The recent changes broke it with the above error.
The new ENV does not help, even when used.

Same issue here, keep getting the error "Password is not stored in keyring. Please save the password in keyring." on reboot. If I add the ENV variable ENV_ICLOUD_PASSWORD I get a TFA push notification from Apple on reboot. If I manually remove the password from keyring and login again everything seems fine in the console, but the errors are still there.

I also noticed that the init script makes a directory called session under /config but the code and examples reference a directory called session_data. So I made session a symlink to session_data, emptied the directory and started with a new login. Seems to have worked.
At this point, I am just shooting in the dark and hoping something sticks! 🙂
Let's wait for @mandarons to share guidance.

Sounds like that’s the bug

I debugged this project and found the issue.
Do not run icloud --session-directory=/app/session_data<EMAIL_ADDRESS>--> this dir is not referenced at all
Run this instead icloud --session-directory=/config/session_data<EMAIL_ADDRESS>

I debugged this project and found the issue.
Do not run icloud --session-directory=/app/session_data<EMAIL_ADDRESS>--> this dir is not referenced at all Run this instead icloud --session-directory=/config/session_data<EMAIL_ADDRESS>
That worked, thank you!

@mandarons the current docket build notifications reference a wrong dir

@mandarons I updated yesterday to the last version. With this version I'll get the 2FA Apple prompt every hour.
But I have already executed the command "docker exec -it icloud-docker /bin/sh -c "icloud --username=*** --session-directory=/app/session_data"" and filled in the Auth code once. Repeating that commend does not show any missing info, so I'll get no output anymore.
So this is unfortunately still not working! :(

@nicx : Please use /config/session_data instead of /app/session_data and try again.

@mandarons shit, that was my mistake. thanks for your hint! I just used the old command from an old mail :)

I'm finally got a change to try the latest "main" tag today, seeing this error:
Starting icloud ... done
Attaching to icloud
icloud    | s6-rc-compile: fatal: unable to open /etc/s6-overlay/s6-rc.d/svc-icd/up: No such file or directory

@TheCase please try again. I added the missing file. It seems to be working on my system.

Ok. That worked...
But only when ENV_ICLOUD_PASSWORD is defined.  This was not a requirement before the latest changes (where you moved config assets from /app to /config, which still seems to be a dicey situation.  I'm pretty sure /app/config.yaml is the file that is read).
I would prefer not to hard core my iCloud password in a file or provide it to the docker environment (where it is visible in the docker inspect output of the container).
Unfortunately, this is still a bug.  Auth was working fine without the var, previously.

@TheCase: Completely agree with you about recent hard requirement of ENV_ICLOUD_PASSWORD. Please try the following steps and let me know if that works (it seem to be working for me).

Remove ENV_ICLOUD_PASSWORD variable
Use docker exec -it --user=abc icloud /bin/sh -c "icloud --username=<icloud-username> --session-directory=/config/session_data" to save icloud password in keyring. (Note the use of --user=abc option in docker exec command).

Please let me know if it works. I will update the documentation accordingly.

Indeed, that --user add was the trick!
Please note that this did not work until I deleted any existing session data from the /config volume.
Thank you!  This is perfect.  Cheers!

I will update the docs to indicate ENV_ICLOUD_PASSWORD is optional (again). Thanks for quickly testing it.


Please indicate what to do when we get an error message about locks

More than once I have have such a lock blocking me. I then have to try to find how to remove it. BUT the error message is useless. So please tell the reader how to find the "source of the lock". Example error:
The lock named e66f5b3b08274953a0be4cd24e589cc6 was unable to be deleted for the following reasons: {"errorThrown":"content: {"error":{"code":"UnauthorizedApplicationId","message":"The management lock 'e66f5b3b08274953a0be4cd24e589cc6' is owned by system application(s) 'ba4bc2bd-843f-4d61-9d33-199178eae34e'. Please see https://aka.ms/arm-lock for detail."}}\r\ncontentLength: 234\r\nheaders: {"Pragma":"no-cache","x-ms-request-id":"canadaeast:d7718b86-8800-451f-aace-5ad9e407a17f","x-ms-ratelimit-remaining-subscription-deletes":"14999","x-ms-correlation-request-id":"b4532d42-7592-492b-9a02-bafc9eac4a67","x-ms-routing-request-id":"CANADAEAST:20190114T220504Z:dc2a6ebc-34c0-4753-bb6d-56b7cfdaa780","Strict-Transport-Security":"max-age=31536000; includeSubDomains","X-Content-Type-Options":"nosniff","Connection":"close","Cache-Control":"no-cache","Date":"Mon, 14 Jan 2019 22:05:04 GMT"}\r\nhttpStatusCode: 401\r\n","jqXHR":{"responseJSON":{"error":{"code":"UnauthorizedApplicationId","message":"The management lock 'e66f5b3b08274953a0be4cd24e589cc6' is owned by system application(s) 'ba4bc2bd-843f-4d61-9d33-199178eae34e'. Please see https://aka.ms/arm-lock for detail."}},"responseText":{"error":{"code":"UnauthorizedApplicationId","message":"The management lock 'e66f5b3b08274953a0be4cd24e589cc6' is owned by system application(s) 'ba4bc2bd-843f-4d61-9d33-199178eae34e'. Please see https://aka.ms/arm-lock for detail."}},"status":401}}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc7050b4-1877-2cee-d1a9-6eb3a3f39d2c
Version Independent ID: 07cfb5e4-24f3-2654-7ca1-1a25e00ee26b
Content: Lock Azure resources to prevent changes
Content Source: articles/azure-resource-manager/resource-group-lock-resources.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@tfitzmac - Thank you for asking. I'm confused by your question. We use standard Azure with Microsoft 365 E3.  My cynical side says "If the error message would have indicated what this error was related to then I would have been able to tell you more about the deployed solution, but I do not know what/who locked this". My guess is that I created a test VM and then tried to remove it and could not. It was probably a Meraki Virtual Firewall (vMX100).

@blouwagie - sorry for the delay on this issue. There are some services that are implemented as managed applications. For those services, the infrastructure is locked. You can still delete the service itself, which will delete the locked infrastructure.
I have added a new section in this article for this information. It should get published tomorrow morning.


Adding RMSNorm to apply_ln_to_stack

Description
Adding support to RMSNorm in the apply_ln_to_stack function. It should be supported by: https://github.com/TransformerLensOrg/TransformerLens/pull/489
Fixes #472
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

Looks good! Thanks for submitting this.


After selecting the plugin template, the storage error has been opened

Signed-off-by: liuying<EMAIL_ADDRESS>
What type of PR is this?
/kind bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #65
Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

/lgtm
/approve


Fix naming for EVP_RAND_CTX_gettable functions.

Change:
EVP_RAND_gettable_ctx_params -> EVP_RAND_CTX_gettable_params
EVP_RAND_settable_ctx_params -> EVP_RAND_CTX_settable_params

Which brings them in line with the other similar functions for other algorithm
types.

[x] documentation is added or updated
[x] tests are added or updated

Fixes #14880

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master.


Auto Tagging images - Chrome Extension

Project Name
Auto Tagging images - Chrome Extension
Project Description
Given an image input this tool should generate a set of tags for that image. You can create your own models and use them to create a web based interactive tool or you can even use APIs from hugging face or other open-source models.
Project Type:

NLP, Text processing
Image generation

Mention the technology stack, and how your are going to go through with this project.

Hello @yagyesh-bobde 👋, I'm interested in taking on this task. Please assign it to me, under SWOC 24 !!

Sure @Sgvkamalakar I have assigned this issue to you.

@Sgvkamalakar great work on this project ✨ Keep contributing!!


Enhanced Image Management to Ensure Code Readability & Usability In Main File

All image files are scattered in the main file randomly

I will create a new folder & transfer all images to it to ensure:

better code readability
easy access to developers & contributors

@vivekvardhan2810
Please assign this task to me.

@vivekvardhan2810
Please assign this task to me.

also i will be correcting this missing images.
please assign the task to me @vivekv2810

@Adarsh-Chaubey03 pls complete the task that I have assigned you before.

 also i will be correcting this missing images. please assign the task to me @vivekv2810

And also we are updating this page, so that's why I didn't assigned the course page related issue to anyone
Please understand.


code editor duplicate  row

Hello, I have a question for you: I've been researching for days but I don't know exactly how to get the current line of the code editor, I want to copy the current line and insert it while holding down ctrl+d, do you have any hints? Thank you!

		if k.Modifiers.Contain(key.ModShortcut) {
			switch k.Name {
			case "D": // copy line todo
				c.editor.Insert("//todo get current line text and  duplicate it")
				//c.lines
				gtx.Execute(op.InvalidateCmd{})
				break
			}
		}

In addition, the scrollbar of the list widget does not seem to register events, I don't understand: the scrolling behavior of the edit area should be controlled by the list widget, if so, we need to alias the scrollbar widget type of the list to the local area, and define its scrolling event and trigger the registered scrolling event behavior, so that when the event is obtained, the layout is refreshed so that the coordinates of the highlighted rendering overlap with the coordinates of the editing area. I'm not sure if my logic is correct though, and I need your further confirmation.

It would be very nice to add this duplicate functionality to code editor, it's kinda limited by abilities of gioui framework. unfortunately their api is not givin us access to the underlying text editor.
and again unfortunately its the same issue with scroller bar and styled text.
I'll try to solve this issues in gio framework.

It would be very nice to add this duplicate functionality to code editor, it's kinda limited by abilities of gioui framework. unfortunately their api is not givin us access to the underlying text editor.
and again unfortunately its the same issue with scroller bar and styled text.
I'll try to solve this issues in gio framework.

I see, and in that case, I have an idea: it's unlikely that a proposal to let them export something would make us fork one and force a point to our version inside the mod. In addition, in order to refresh their commits in real time, we need to make minimal changes in the fork repository, and then we will make a path script that can easily replace any version with one click. What do you think of this idea

This was followed by AI code completion until I found a suitable small model. Also, can a split layout be split vertically? This will be used for the packet capture layout or the ollydbg debugger layout

I've gotten the controllable scroll-down behavior of the code editor through the cursor, and scrolling up only needs to register a scroll event to get it, and horizontal left and right scrolling has not been tested. Unfortunately, the rich text editor doesn't have scrollbars or offset coordinates to refresh the position, so after solving this, optimize the performance of loading large files to add the AI model auto-coding test. It is theoretically possible to copy the line: just get the cursor line number and then wrap the line character to insert it, and in addition, it is possible to copy the selected area for cloning. I also figured out the idea of the tree table, and the rest is all about the details. I haven't been researching GIO for 20 days, and I feel like I'm on my own, and it's useless to ask others.


id = 0 for node is replaced with uuid()

For our root node we have
let root = {
   id: 0,
   name: 'All'
};

We can't easily change that, it's hardwired in our DB via
parentId === 0

for top level elements. The problem is, this ID is replaced with a UUID somewhere down the line, because 0 evaluates to falsy.
constructor(public data: any, public parent: TreeNode, public treeModel: TreeModel, index: number) {
   this.id = this.id || uuid(); // Make sure there's a unique ID
   this.index = index;

   if (this.getField('children')) {
      this._initChildren();
   }

   this.allowDrop = this.allowDropUnbound.bind(this);
}

By the way, this is version 3.3.1 but the offending code is the same in the current repo.

Hey @erasethis
Thanks for the PR - I made a comment

Fixed and released


misc: add code of conduct

Copied from our documentation repo.

Current dependencies on/for this PR:

main

PR #109   👈

This comment was auto-generated by Graphite.


Enable gzip encoding in undertow for all cases

I found that gzip encoding for http request is not enabled in indy starter(also happened on production). After checking code, found it is only enabled when starting port < 1. Not sure if this has some special meaning.
I've enabled it in all cases as some of our static resources (js or css) are not so small (> 200k), so this can help to reduce the bandwith for them.
@jdcasey do you know what cases for that port<1? If some special meaning please let me know and I'll change it back.

retest this please

Good catch, I think this was just an oversight.


Add missing common routes for api

too many changes at once, please make the PR more readable:)

@ces365 What is this PR for? Could you elaborate more on the PR description?


Revert to TD Gradle plugin to v2.2

Disclaimer: This PR replaces this closed PR
Upgrading the TD agent to v1.6.1 indeed fixed this problem reported by Bo (no occurrence since 3 days), therefore we no longer need the additional logging to isolate the problem and want to revert back to the latest official release v2.2.

@bot-gradle test rFM please

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


[Bug]-[40]:Disabled button can be clicked on the welcome page

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Disabled button registers a click on the welcome page and hence user is navigated to the next page without needing to enter details
Steps To Reproduce

Sign up to Appsmith
On the welcome page, click enter without entering any details and observe user navigated to next page even though button is disabled.

Public Sample App
No response
Version
Cloud

Stats

Stat
Values

Reach
10

Effort (months)
0.5

We have some trouble verifying this in deploy preview.
https://theappsmith.slack.com/archives/CGBPVEJ5C/p1678694313317649

This is fixed verified it on the DP url.


Add assemble-sdks CI job and add Termux packages necessary for XML and networking

This PR adds a workflow job that runs at the end of the CI cycle. It takes the artifacts from the build-sdk-and-tests for each of the versions (release, devel, and trunk) and aggregates them into a single SDK archive. This is the start of addressing https://github.com/finagolfin/swift-android-sdk/issues/163, but does not yet generate a toolchain.json file or an .artifactbundle.
You can see the artifacts that it will generate at https://github.com/marcprux/swift-android-sdk/actions/runs/10781519718, which creates swift-5.10.1-RELEASE-android-sdk.tar.xz, swift-6.0-DEVELOPMENT-SNAPSHOT-2024-07-19-a-android-sdk.tar.xz, and swift-DEVELOPMENT-SNAPSHOT-2024-07-15-a-android-sdk.tar.xz. These archives can be used with a custom destination JSON file (not included, since it will need to reference the local NDK and host toolchain locations, which will vary from machine to machine).
In addition, this PR adds the following Termux packages to the SDK, which enables FoundationXML and FoundationNetworking: zlib, libnghttp3, libnghttp2, libssh2, openssl, liblzma, and libiconv. With these included, XMLParser and URLSession are working (albeit not HTTPS yet – we need to be able to hook into the Android certificate store somehow).

I've updated this PR with the latest 6.0 work, and the resulting swift-6.0-RELEASE-android-sdk.tar.xz artifact works well from my initial experimentation.
A couple of observations:

libc++_shared.so seems to no longer be included in /usr/lib. Not sure what changed (since it was included in the 5.10 SDK), but for now it needs to be manually copied from the NDK along with the other shared objects to get a test executable to run on Android.
swift-testing is not being built. I am currently experimenting with adding it to the build-script flags in https://github.com/marcprux/swift-android-sdk/pull/11

OK, I think this is ready for review. The resulting SDK artifact works on my local macOS machine, except for a weird error when building tests … I'll make a separate issue/PR for that.

libc++_shared.so seems to no longer be included in /usr/lib. Not sure what changed

Not sure what you mean: I see it in both my Swift 6 single-arch SDKs and in these multi-arch SDKs you're uploading now.
I've started reviewing this pull, will examine the uploaded SDK now and finish my review.

libc++_shared.so seems to no longer be included in /usr/lib. Not sure what changed

Not sure what you mean: I see it in both my Swift 6 single-arch SDKs and in these multi-arch SDKs you're uploading now.

This was just an error on my part: I was copying it to the wrong location.

I notice a couple more files in usr/etc/, usr/lib/engines-3/, and usr/lib/ossl-modules/ that were added as part of your Termux library additions: can you remove them if not needed? The config file doesn't matter much, but the shared libraries are wrongly available for only a single arch, if needed for the other Termux libraries.

Alright, other than those last tweaks and your separate rpath pull, this is looking good. Once you make those last few changes, I will merge and the CI will produce the multi-arch SDKs from now on.
No need to add separate commits for each change anymore, mash it all into a final commit now that we're reaching the end.
Thanks for working on this, 😄 hope you don't mind all my tweaks.

I've handled the final nits. Ready for squash and merge!

Thanks for all your work on this, Marc! 😃 I will start using this multi-arch SDK to create an SDK bundle locally, then merge those changes back to the CI this week and release.


chore: update yarn=4.0.0-rc.2 typescript=4.6.3

https://github.com/coilhq/web-monetization-projects/issues/2631
This still seems to be an issue :/


Change the tab names

"The Tab names should be changed. Currently they read as “1. New job”, “2. New job”, “3. New job”. It can be renamed as “Job 1”, “Job 2” and “Job 3”."
cc @prashantverma2014

This is a little tricky; right now the tabs are numbered to correspond with the visual tab order, not any default job name.
So I would not change that aspect of the job name but I think elsewhere there is a request to change the job name as soon as the user picks a script from the drop down.

It is not a high priority for December release. We can discuss it further after upcoming release.

In the latest commit ( https://github.com/daisy/pipeline-ui/commit/0e57c9932fd75d64c24f914c2107f072498152f4 )

the job is called "Untitled job" until a script has been selected
the job name changes when a script is selected
the jobs are numbered according to position in the tab list


[#1190] feat(server-common): Support custom filters

What changes were proposed in this pull request?
Add the support of custom filters referring to the Spark.
Why are the changes needed?
Some filters can be configured by users, the needs of users are different. Some filters are implemented by other libs.
For example, Jetty has implemented the CORS filter, so we supported custom filters to satisfy the needs of users.
Fix: #1190 #42
Does this PR introduce any user-facing change?
Yes, I have added the document.
How was this patch tested?
test by the browser console
I test Jetty's cors filter.
Configuration
gravitino.server.webserver.customFilters=org.eclipse.jetty.servlets.CrossOriginFilter
gravitino.server.webserver.org.eclipse.jetty.servlets.CrossOriginFilter.param.allowedOrigins=*

Browser console code
var http = new XMLHttpRequest();
var url = 'http://localhost:8090/api/version';
http.onreadystatechange = (e) => {
    console.log(http.responseText)
}
http.open("GET", url);
http.send();

Can you please add some UTs, at least to test the correctness of the configurations?

Also, I think we should support cors filter by our own, rather than letting users to configure it.

Also, I think we should support cors filter by our own, rather than letting users to configure it. So you should have a new PR to implement cors filter.

Jetty have implemented CORS filters: org.eclipse.jetty.servlets.CrossOriginFilter . Why do we reuse it?  You can see my test.

You should at least wrap the jetty's implementation and provide gravitino configurations. Cors support is very important for all the web based apps, like Livy, Zeppelin, I don't see them letting users configure a filter to achieve this.
a) Users don't know where's the right filter they want, and how to enable this, unless they read the code of that filter. Here jetty for example, how did users configure this without knowing Jetty?
b) Spark is not a web based app, so don't take Spark as an example for everything.

You should at least wrap the jetty's implementation and provide gravitino configurations. Cors support is very important for all the web based apps, like Livy, Zeppelin, I don't see them letting users configure a filter to achieve this.
a) Users don't know where's the right filter they want, and how to enable this, unless they read the code of that filter. Here jetty for example, how did users configure cors without knowing Jetty? b) Spark is not a web based app, so don't take Spark as an example for everything.

Ok, I will prefer wrapping the CORS filter of Jetty.

Can you please add some UTs, at least to test the correctness of the configurations?

Fixed.


SAMOA-77: Rebuild and unification of data serialization

This PR provides unified data serialization pattern for SAMOA project. In particular, the currently distributed code is groupped into samoa-instances and unified to single Loader pattern (derived from existing one). The readers can be created by factory class. This PR also clean some of the Kafka-related code and introduces new structure to samoa-instances class/packets structure.

@pwawrzyniak is this ready for merging?


Move all connections to dbtcloud_global_connection

Changes

Add support for all connection types in dbtcloud_global_connection (added PostgreSQL, Redshift, Apache Spark, Starburst, Synapse, Fabric and Athena) and add deprecation warnings for all the other connections resources: dbtcloud_connection, dbtcloud_bigquery_connection and dbtcloud_fabric_connection

Docs

Update "Getting Started" guide to use global connections instead of project-scoped connections

CI passed 🚀


Make some BooleanQuery methods public and a new #add(Collection) method for BQ builder

Description
Changes in this PR :

Makes getClauses(Occur occur method public to get the collection of one type of clauses. Without public I had to call getClauses and then iterate to store this info whereas BoolenQuery is already storing this info in clauseSets which seems like a good candidate to be exposed for reuse this method. This would also simplify not having checks like eg: 1, 2, 3, 4 etc along with the add(Collection) method(point 3 below).
Similarly makes #isPureDisjunction and isTwoClausePureDisjunctionWithTerms public which looks could be something useful and right thing to be exposed by the BooleanQuery class.
Adds an add(Collection<BooleanClause> collection) method to BooleanQuery.Builder. While doing some query manipulation I had to insert a set of clause but one by one. I'd be useful if there was a add(Collection<BooleanClause> collection) to add the to the maintained list of clauses and simplify it for cases where users are manipulating the BQ. I see some places in code that could be refactored to avoid looping to insert the list of clauses as mentioned in point 1.

I'd love to hear thoughts and suggestions. I don't know if there are any rationale of not having these methods public earlier(or a previous attempt) but would love to know.

This LGTM but it has been this way for so long I wonder if someone with more historical knowledge will have a rationale for hiding these things?

I took a quick peek at the git history and it looks like:

#getClauses was added back in LUCENE-6944 as a new method and hasn't been touched since. I would guess it was added with the most limited access visibility required as a default practice?
#isPureDisjunction was added in LUCENE-7386 in a pattern that looks similar to above (only added with necessary pkg-internal visibility).
#isTwoClausePureDisjunctionWithTerms was added recently in #13036, and looks like yet another situation where only the necessary visibility was given for the reason it was being added.

So tl;dr: it looks like access was restricted as a good practice for the use-cases they were being added for.
IMO, I think it's fine to expose #getClauses(Occur) since it does provide a better way to access data already being publicly exposed (i.e., makes sense to not require the client to iterate all the clauses when there's a better way to directly do this). I'm a little less convinced on the other two though. Is there a concrete use-case for exposing these? While, on one hand, it's not really leaking any internals to do this, it's also something the calling code can figure out on its own just as easily with what's already provided. While it's nice for calling code to not have to reimplement this logic, it's also nice to keep the API surface tight. Maybe there's a good motivating use-case though (and sorry if I missed this somewhere)?

Thanks everyone for taking a look! As per comments the #isPureDisjunction and #isTwoClausePureDisjunctionWithTerms seems to be the debatable ones :

About #isTwoClausePureDisjunctionWithTerms, I'm myself not super convinced considering its targeting a very specific type of query and I agree it might only be useful in rewrite optimizations. Its good to have these helper functions but since it only has one usage(same for #isPureDisjunction) currently prolly keeping it more local to the only usage is better than in highly visible class like BooleanQuery (but then it loses the chance of being visible and reused :) ). Anyways I'll remove it.
#isPureDisjunction does seem and also sound more generic/useful comparatively to above one but I'm not able to think of any specific use case generic enough to convince exposing(though there maybe one for this).

I removed these 2 for now and fixed the comments. Thanks!


Bridge found at incorrect address - no lights found

[MacOS]
I’m facing problem in version 2.0.1 that probably somewhere is old config.json from version 1.x and it has old IP address of bridge. I tried to use force, host, ip options with setup but none worked. On Windows deleting configuration file helps because it allows you to run fresh dmx-hue setup and just click the bridge button and repeat the command to enter configuration process.
So the question is, where on MacOS this file is being created or should be created? I don’t remember the path from last year usage probably on different device and can’t find on current one.

On Mac OS the config file is located in ~/Library/Preferences/dmx-hue-nodejs/
Running dmx-hue setup --force forces a new bridge search and configuration from scratch though.

Thanks I will check this later when have access to MacOs. On a side note I still think the process of switching bridge between devices isn’t user friendly. At least it would be useful  to have this mentioned in readme.
The solution I found now to be working, but within the same OS (in this case Windows) is to copy config.json so dmx-hue on new device use same bridge right away without setup thanks to the same user property hash.

If dmx-hue setup --force fails, that means it's unable to locate your bridge automatically.
In that case you would need to use --ip to set it manually, along with the --force as you already have an existing config file.
I'm using https://www.npmjs.com/package/node-hue-api to communicate with Hue lights, so there's nothing I can do if your bridge or lights can't be found by this library.

You might me right, at the end at the first place with Windows device it shows lights like a charm with existing configuration file as long as bridge IP is correct. At second location and where I tried to run it on MacOS Hue mobile app showed different address than it was in fact. Well, I hope that network setup is the problem and using another router should be fine.

Reopening this because I really hate the user experience of this (very usefull) software and have no idea what I'm doing wrong.

Tried on 2 Windows 10 OS and one Mac OS and the result is same as above. Also important thing is there were previous versions of dmx-hue installed on some but after trying to just reuse them with dmx-hue command it gave authorization error so the connection between the dmx-hue app with the saved clientId wasn't working anymore and you really need to have this pushing button on the bridge done to create this connection on each OS and device. I don't know what's under the hood of creating this authorization with bridge but each time I return to this it makes problem.
How can it be changed to be more user-friendly?

Hello,
I have the same problem with my Windows 10 machine. I used a new bridge which is up to date. I can use an old config-file an put in "C:\Users\CS\AppData\Roaming\dmx-hue-nodejs\Config", then I can at least find the bridge but I get an authorization error "Unauthorized user". So it doesn't help.
When I use an older bridge which wasn't updated since at leasts 2021, it works.
Does anyone have a solution for this? How to get connected with the up-to-date Hue bridge?


[AMBARI-22984] Old mpacks broken (echekanskiy)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/584/
Test FAILed.
Test FAILured.

ci failure not related to changes, AMBARI-22918 broke it.


Support external account binding

@picoHz here's an experiment to support external account binding with an API that's a bit cleaner, IMO (avoiding code duplication). Can you review it and, ideally, test that it works?
(Alternative to #21.)

@djc It worked for Google Domains and ZeroSSL 👍

Thanks for the feedback and testing! (And also, thanks for maintaining the mediatype crate, which we use.)
This just got published as 0.3 on crates.io.


Source files on PyPI

Ciao Leonardo,
I was planning to submit your package to conda-forge, such that it's installable using conda (since I want to put one of my packages there and yours is a dependency).
Would you mind to please put the source files of joypy on PyPI , too, i.e. submit the tar.gz next to the wheel? That would be great. Thanks!
Cheers,
Simon

Sure thing, just uploaded the source too. Thanks!

Cool, in the future ppl can download joypy using conda install -c conda-forge joypy


Are there any callback supports?

For example, is there anyway to get the following support?
Client:
connection.send("someData", function (returnedData) {
     // Returned by the server
     console.log(returnedData);
});

Server:
connection.on('message', function (message, cb) {
    // Message contains "someData" string
    // Use cb to send data back to the call
    cb("Here you go sir");
});

The pattern above currently doesn't do anything. The callback inside the client is intended as an error handling, i.e. returnedData is actually the error if data was not sent down the line.

No. What you're describing is higher level functionality, and is not part of the WebSocket protocol. This library only provides an API around an implementation of the WebSocket protocol itself. Additional enhanced functionality should be implemented in your own code, or by another library that would in turn use this library internally.


[WIP] THREESCALE-8000 + THREESCALE-8007 + THREESCALE-8252 (clear context policy)

This PR adds compatibility with this OpenResty change.
It takes care of clearing the local context at the beginning of every separate request.
We use the context to determine routing to Products (when APICAST_PATH_ROUTING is enabled) or to Backends (when using APIaaP). Both those routing scenarios can be affected by the bug when connections are reused (see also KCS1 and KCS2)

umm, maybe I do not understand the full context here, but I do not think that context should be clear at all. Maybe what we should do it drop support of SSL_context on ssl_certificate phase and keep as was before the change.

umm, maybe I do not understand the full context here, but I do not think that context should be clear at all. Maybe what we should do it drop support of SSL_context on ssl_certificate phase and keep as was before the change.

The idea is based on the problem being that our code does not expect the context to be shared across different requests but rather for it to be scoped by request (this is true at least for the path routing algorithm and the routing policy).
The option we are exploring here would address this by resetting the context at the beginning of each request (which is what this policy does), that should be equivalent to what happens when the ssl_certificate phase is not executed at all (i.e. there will be nothing in the current context when the first policy executes for a certain request).
Another option (which I believe is what you are suggesting?) would be to avoid interacting with the context in all the ssl_certificate phases across all policies but that seemed more of a breaking change due to this and this for example.

After some more testing I found another problem with the same root cause: THREESCALE-8252.
@eloycoto I just committed a slightly modified version of the policy that I believe to be a safer option: it resets the current context at the end of every request (in the log phase of the last policy in the chain) rather than at the beginning. This way the reset of the context will happen when no other policy will need to access to it, and so it will be reinitialized correctly in the executor on the next request. If in the future we will want some parts of the context to be shared through different requests it will be easy to tune the policy accordingly to leave those.
This commit also takes care of THREESCALE-8252 because the original_request will be populated as normal here.
I added integration tests to confirm all 3 issues are covered.

umm, I do not think that will work @samugi , mainly because requests can be concurrent, and that can be a problem. SSL context should be disabled.

umm, I do not think that will work @samugi , mainly because requests can be concurrent, and that can be a problem. SSL context should be disabled.

@eloycoto does that mean concurrent requests could share the same context? I thought that wouldn't be possible especially since we are relying on context.current for things like routing and some objects in particular (e.g. context.current.service) require to be scoped by request but perhaps I'm missing something.
In what scenario would properties of context.current be reused after a policy chain completes its execution for a certain request? Is there any test that you would be expecting to fail?
Also I thought we were relying on the SSL context for a few things now, am I wrong? I thought this to be the case for the TLS policy for example, which requires the service to have already been determined during the ssl_certificate phase. I'll double check though, maybe we are storing the service in the context for other reasons there, I haven't looked into that yet.
Thanks for your feedback

SSL certificate only happens once, on ssl_handshake, and from there many more requests to come.
So, no set context on ssl_certificate and initialize on rewrite phase where the service will be in there.
I mean, if you change this line should be ok:
https://github.com/3scale/APIcast/blob/master/gateway/src/apicast/policy/find_service/find_service.lua#L62

@eloycoto I already suggested the same and @samugi gave some reasoning why that wouldn't be a good idea. I forget exactly what that was now but I suspect it is something related to the fact that removing the context in the ssl_certificate_phase could end up breaking the new behaviour introduced in OpenResty that @samugi mentioned at the top of this PR. My thinking here was that we never needed that behaviour previously and therefore we would not need it now and given that we have a very specific use case regarding the context in APIcast probably we can just unset it during that phase and initialise it in the next (rewrite) phase.
@samugi could you remind why else you thought that was a bad idea because I cannot remember now. I think I remember you preferred to keep the behaviour introduced in OpenResty and only improve how we manage the management of the context object right?
I'd say in general that's the best approach and keep compatibility with as much OpenResty features as possible but I also think this was a breaking change in OpenResty that they didn't handle very well and as a result we have to cope with this somehow.
One advantage to Samuele's proposal I'd say is that this behaviour could be configurable and so in future if we need to "enable" that OpenResty "feature" again then skipping or disabling the policy would be easy don't you think @eloycoto ?

I discussed this with @kevprice83 this morning, here is a recap of our discussion:
We believe we have 3 ways of addressing this problem:

The current proposal here (clearing the context in the log phase of the last policy in the chain).
Pros:

Safe because it clears the context at the end of the policy chain when no other policy could need to access it
Modular: can be reverted or altered by removing / modifying the policy
Allows to take advantage of the OpenResty change should we need to share the context from ssl_* phases in the future

Cons:

We would execute some code (the claring context part) even when it's not strictly necessary (e.g. in the event the ssl_certificate phase was never executed)

Clearing the context right after these lines
Pros:

The change would only apply when strictly necessary, during the ssl_certificate phase

Cons:

Potentially in the future we might want to access the context of the ssl_certificate phase in a policy that comes after find_service and that would be problematic because:

the context would have been cleared already
any change in the context executed after find_service would then be shared with multiple requests (potentially producing the same issue we see now)

Does not allow to take advantage of the OpenResty change should we need to share the context from ssl_ phases in the future

Clearing the context in the clear_context policy, from the last position in the policy chain, but in the ssl_certificate phase (rather than the log phase)
Pros:

The change would only apply when strictly necessary, during the ssl_certificate phase
Modular: can be reverted or altered by removing / modifying the policy

Cons:

Does not allow to take advantage of the OpenResty change should we need to share the context from ssl_ phases in the future

What would you think of the proposals above @eloycoto ?
Also one more thing just to clarify a point from the previous comments: when you said "SSL context should be disabled." and "So, no set context on ssl_certificate and initialize on rewrite phase where the service will be in there.", did you in fact mean to suggest the context should be cleared during the ssl_certificate phase or do you actually meant that we should completely stop accessing / sharing a context in the ssl_certificate phase of any policy?

Would be good to get some feedback from @sergioifg94 & @eguzki on that last comment maybe?

I think it would be useful to run the test requests concurrently to see the outcome. I'd expect one of them to fail in which case that would make it clearer that we then must clear the context at the end of the ssl_certificate_phase in the last policy in the policy chain. Other than that I think doing this as a separate policy is a good approach. Maybe using the concurrent library here?

for this one I used request_pipeline. I then verified that in fact the tests fail when clearing the context in the log phase (which wouldn't handle concurrent requests) and pass when the context is cleared at the end of the ssl_certificate phase (as we expected).

yeah, make sense that ssl_certificate, because all connections do the ssl_handshake before it. I have another thing in mind here, use with tls_termination policy too, because clear the context is ssl_certificate happens before ssl_handshake on tls_termination.
Please raise this issue to the QE team, @DavidRajnoha  is no longer working on this, but I'm sure that @mganisin can make a test plan for this. But overall, it's testing that two services in the same APICAST landed in the right place.

there seems to be a problem when the tls policy is in the policy chain and executes this code which exits and does not permit the clearing context code to be executed.


Should setup travis to automatically build all branches and PRs.

This is so that @Achati can have it so that all commits must pass a check before they are merged into master...

https://github.com/blog/2051-protected-branches-and-required-status-checks
how much of that can we use?

Well, we need travis to automatically build branches, and if it builds, we can merge with master.
The setting needs travis to do the status checks to be of any value.

Right, this is done!


Provide the debian copyright file acl version 2.2.52

The package provides Commands for Manipulating POSIX Access Control Lists.
The project homepage is http://savannah.nongnu.org/projects/acl

This is not necessary anymore


Who merges the forks and when?

Csaba and I are working on notebooks for the SOLID process. They are two separate notebooks in forked repositories from this one, so "nateme16/geo-aquawatch-water-quality" for example. What is the smoothest process and timing to merge with the main github? Maybe after some major parts are done?

Well I figured out the pull request system that will allow someone to review our forked changes. I suppose we assign someone to be the quarterback for that.


fix: match mergedGateways irKey for ClientTrafficPolicy

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes

https://github.com/envoyproxy/gateway/issues/2661

/retest


Devcontainer variables are not set

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.79.1
OS Version: Windows 10, WSL2

Steps to Reproduce:

I need to mount local ssh keys from ~/.ssh into the devcontainer using this mount option:
"mounts": [
"source=${localEnv:HOME}${localEnv:USERPROFILE}/.ssh,target=/home/vscode/.ssh,type=bind"
]
I need this to be able to push and pull changes from Github.
Both of the variables ${localEnv:HOME} and ${localEnv:USERPROFILE} seem to be empty when devcontainer is activated and I can see the devcontainer output that docker command is being passed wrong mount options as a result of this and therefore the devcontainer activation fails.
This is true when running vscode directly from Windows or running it from WSL.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!


Loading gifs not found

When uploading a photo, the system is unable to find some images.
/img/loading.gif
img/loading-sm.gif
There may be more. I believe this is in \how-to-sane\client\vendor\bootstrap-fileinput\fileinput.js:234
Looks like bootstrap can't find the necessary files.

thanks for opening the issue, i think they're being ignored by git, i'll fix that


NPM package updates

Description
NPM package updates including Keycloak-JS and Axios.
There are still some outdated packages as a result of using Vue2 and the CKEditor.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-2896
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

PR Deployed at: https://chess-dev.apps.silver.devops.gov.bc.ca/pr-28

PR Deployed at: https://chess-dev.apps.silver.devops.gov.bc.ca/pr-28


magicbot

haciendo unas pruebas.

Hi @tomerqueves good day to you
Please be advised that if this ticket is something to do with enhancement or an issues is to make sure to add details or supporting files such as logs, strategy config and screenshots so we can help investigate.
We will close this ticket for now, we suggest to visit our discord channel for support related concerns. Thanks!


Fixes infinite loop when switching editor

This fixes #34255

The loop condition is inverted

FYI: 3D / Script / AssetLib can be hidden, but the 2D Editor is always visible

Thanks!


Install Tensorflow Anaconda / Windows

Could you make a step by step guide/video on how to install Tensorflow and use it in a ide. There is always a new problem that pops out... Several of my friends have problems here and its super frustrating.

I just merged a change to the installation instructions for Windows that should make this easier.
I know there can be issues but I do not think I can all the problems that i do not know about in a video. The basic installation when everything works correctly is just 2 steps, as describes in INSTALL.txt


Remove redundant key from ContainerReference

It looks like this key slipped in as part of 3f6cc65457309b4e736a960e24999e69c216bb77, and it's making its way to the database.
This isn't great because it's the same data as the type key, isn't shipped by the SDK, etc.
I did a quick check and the key isn't used anywhere but its own class, so it seems safe to remove.
Could be accompanied by a database migration if you reeeeally want one.

LGTM

Thanks for fixing! Didn't realize at the time that they get stored, and was hasty with getting rid of the builtin override. LGTM


Server/host calling ServerRpc

Describe the bug
If the server/host calls a server RPC function nothing happens.
To Reproduce
public override void NetworkStart()
    {
        if (IsServer)
        {
            Debug.Log("Hello");
            MyFancyServerRpc();
        }
    }

    [ServerRpc]
    void MyFancyServerRpc()
    {
        Debug.Log("World");
    }

Run this in a NetworkBehaviour
Expected behavior
I'd expect one of two things to happen:

An exception is thrown telling you that server can't invoke a server RPC.
Server executes the function like a regular function.

Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

MLAPI Version: release/0.1.0

Added to bug backlog for triaging, https://jira.unity3d.com/browse/MTTSDK-11

Fixed in v1.0.0-pre.x releases.