Create a account details registration page

As a user I want to populate additional data in account details registration page so that site community knew about me more.
PRECONDITIONS

The user started account creation on a page for user registration details https://github.com/ita-social-projects/Fragments-back-end/issues/16
The user undertook registration via Facebook https://github.com/ita-social-projects/Fragments-back-end/issues/17
The user is redirected from Facebook to the website's account details registration page in order to specify more details.
The following fields are populated automatically via Facebook:

“Фото”
“Ім’я”
“Прізвище”
"e-mail"

ACCEPTANCE CRITERIA

Create an account details registration page to specify user registration details.

Add following fields to the registration form:
2.1. Label at the top "Вітаємо! Для завершення реєстрації у Спільності дозвольте нам дізнатися про Вас більше:".
2.2. checkbox “представник влади” is not required , unchecked by default
2.3. checkbox “представник ЗВО” is not required, unchecked by default.
2.4. text field “Чим можу бути корисним” is not required. special characters allowed, max. 500 characters. There is a tooltip button located outside the field near the right upper corner. The tooltip button is represented by a dialogue bubble with a question mark (?) inside.
2.5. text field “Мої інтереси” is not required. special characters allowed, max. 500 characters. There is a tooltip button located outside the field near the right upper corner. The tooltip button is represented by a dialogue bubble with a question mark (?) inside.
2.6. Additional communication channel consists of three sub-fields put in a line:
2.6.1. an add button - a box with a plus sign (+) inside - the button is disabled until user populates "канал зв'язку" and "деталі";
2.6.2.  "канал зв'язку" - a search field with a dropdown menu. The dropdown menu has the following:  viber, telegram, messenger, sms. The user may select only 1 communication channel at a time.
2.6.3. "деталі" - details of user's communication channel - text field, special characters allowed, max. 100 characters, should be unique identifier of a user

When user selects button “Зберегти”, the system:
3.1. save new/updated data in the database
3.2. show relevant notification: “Дякуємо! Ваші дані збережено”
3.3. show notification "Сталася помилка" when data is no saved for some reason.

epic link #15

@anya1609 2.2 , 2.3 : one of radiobuttons should be selected. What other type of user can be there ?

updated the ticket as agreed: radiobutton changed to checkbox.

@KhrystynaSuliy
2.6.2: Need a trash bin symbol picture
Asking you to pay attention to the design of this story


"Trash" reference in 2.13 New Features instead of "Recycle Bin"

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: Google Pixel 3a emulator
Android version: 11
First reported on App version: 2.13.1-RC1
Still present in App version: 2.13.2

Describe the bug
The Recycle Bin is incorrectly referred to as "Trash" in the new features list.
Steps to reproduce the issue
With locale set to English (United States):

Open CWA
Tap three-dot symbol
Note the option in the menu called "Recycle Bin"
Tap "App Information"
Tap "New Features"
Note the text
"Restore Certificates
Removed certificates are moved to the trash. They can be restored within 30 days."

Expected behavior
The app should consistently refer to the "Recycle Bin" only by that name.
Possible Fix
Modify https://github.com/corona-warn-app/cwa-app-android/blob/5ea5c9c329e3ae31598bd476716e1348e6d44169/Corona-Warn-App/src/main/res/values/release_info_strings.xml#L30 accordingly, changing "trash" to "recycle bin".
Additional context
During early stages of the development cycle the name "Trash" was used. This was later changed to "Recycle Bin".

Closing, since the descriptions in "New Features" don't get fixed after the version is released. They are replaced in the next version.


Support validation with asymmetric keys

As noted in the Configuration section of the README, nginx-jwt only supports symmetric keys for validating JWT's. However, many applications require the use of asymmetric keys so they don't have to distribute secrets (which can be used to sign JWT's) to all of their applications.
To implement asymmetric keys, nginx-jwt would need to support the RS256 encryption algorithm, which really means the underlying JWT library lua-resty-jwt would need to support it. That library has recently added limited support for RS256, but only if your JWT also supplies the x5c header. While this approach works, one drawback is that header contains the public key itself, which adds a noticeable increase to the JWT's size. Usually the x5c header needs to contain the entire cert trust chain (significantly more size) but lua-resty-jwt library relieves this by requiring the existence of a trusted_certs_file that must be deployed to the server, so that the x5c header only contains the signing cert itself.
It's my opinion that most users of RS256 would prefer to use an approach where the public key was somehow provided externally to the JWT. Here are a couple ideas, but they would both require changes to the underlying lua-resty-jwt library to support them:

Put both the signing certificate and chain trust certs in the trusted_certs_file and not use the x5c header. However, I'm not entire sure this follows the spec.

Use the kid header (Key ID) to point to a public key on some trusted external public key server. We'd need additional configuration to support how that certificate would be obtained (i.e. an HTTP call to download it, and maybe cache it on the first request). We also need to figure out if it would be lua-resty-jwt or nginx-jwt that would do the work of obtaining that cert.

Well, this may be the shortest-lived enhancement request ever. It turns out nginx-jwt does have support for asymmetric keys as of PR #38. I didn't pay attention to that PR close enough nor did I read the source for lua-resty-jwt close enough as its clear you can pass the public key cert via the secret argument.
For the moment, I don't see a need to do anything fancier, so I'm going to close this issue.  Further comments are welcomed.

If one was to only configure the JWT_SECRET with a public key, it might a bit of a surprise to find out that the server would accept a JWT signed by the public key with the HS256 algorithm, as described in the auth0 blog[1].
Perhaps as a minimum, one could configure JWT_SECRET with a public key AND configure the the lua-resty-jwt whitelist with only asymmetric algorithms?
[1] https://auth0.com/blog/2015/03/31/critical-vulnerabilities-in-json-web-token-libraries/


feat: add support for config sesh source

Description

Combine to one sessions state object
Switch icon getter logic to switch case
Add config section between tmux and zoxide in list items

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer any chance this can get merged soon?

@pernielsentikaer awesome, hope you had a good vacation! 🍹

I had a nice easter vacation 🐰


Update UI for nodedriver fields

Nodedrivers now have an annotation to specify which fields should be a multiline input vs the standard text box. This should only affect nodedrivers that do not have their own custom UI already.
io.cattle.nodedriver/ui-field-hints": "{\"privateKeyFile\":{\"type\":\"multiline\"}}"

Backend is already merged in 2.2.x and master
Original issue: https://github.com/rancher/rancher/issues/20747

Version: Master (v2.3) (6/12/19)
I can confirm that we now see multi-line fields for fields that have UI hints.
For example, with openstack, privateKeyFile and is a multi-line field.
Also, userDataFile has been added in the API and this too is multiline. They don't initially appear as multiline (not apparent) but they are indeed multiline and in my browser I can use the handle at the bottom-right to expand these:

We do not have test accounts for other providers that might utilize ui hints, but the expected behavior is exactly the same. This is for situations where a UI is not provided by 3rd party drivers only so testing openstack should be sufficient.


Docusaurus: Module not found: Error: Package path ./js is not exported from package

Hello,
I am trying to implement this Search into Docusaurus.
So far I did:

Create Docusaurus instance
Install Docsearch: npm install meilisearch-docsearch
Swizzle SearchBar component npm run swizzle @docusaurus/theme-classic SearchBar -> Choose Eject Method
Set up component in \docusaurus\src\theme\SearchBar.js

This is how my SearchBar.js code looks like:
import React from 'react';
import { docsearch } from "meilisearch-docsearch/js";
import "meilisearch-docsearch/css";

export default function SearchBarWrapper() {

  docsearch({
    container: "#docsearch",
    host: "https://ms-1c8012be0538-2040.fra.meilisearch.io",
    apiKey: "XXXXXXX",
    indexUid: "docs",
  });

  return (
    <>

    </>
  );
}

Unfortunately, I get this error afterwards:
Module not found: Error: Package path ./js is not exported from package ..\docusaurus\node_modules\meilisearch-docsearch (see exports field in ..\docusaurus\node_modules\meilisearch-docsearch\package.json)
client (webpack 5.84.1) compiled with 1 error

When changing the import method to this:
import { docsearch } from "meilisearch-docsearch";

I get this:
Uncaught runtime errors:
ERROR
element is null
render/<@webpack-internal:///./node_modules/solid-js/web/dist/dev.js:185:53
createRoot/updateFn<@webpack-internal:///./node_modules/solid-js/dist/dev.js:237:19
runUpdates@webpack-internal:///./node_modules/solid-js/dist/dev.js:857:17
createRoot@webpack-internal:///./node_modules/solid-js/dist/dev.js:242:12
render@webpack-internal:///./node_modules/solid-js/web/dist/dev.js:183:55
A2@webpack-internal:///./node_modules/meilisearch-docsearch/dist/index.js:9:36694
SearchBarWrapper@webpack-internal:///./src/theme/SearchBar.js:8:93
renderWithHooks@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:14985:27
mountIndeterminateComponent@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:17811:13
beginWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:19049:16
callCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3945:14
invokeGuardedCallbackDev@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:3994:16
invokeGuardedCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:4056:31
beginWork$1@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:23959:28
performUnitOfWork@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:22774:12
workLoopSync@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:22702:22
renderRootSync@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:22665:7
performSyncWorkOnRoot@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:22288:18
scheduleUpdateOnFiber@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:21876:28
updateContainer@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:25477:24
legacyRenderSubtreeIntoContainer/<@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26016:22
unbatchedUpdates@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:22426:12
legacyRenderSubtreeIntoContainer@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26015:21
render@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26098:10
@webpack-internal:///./node_modules/@docusaurus/core/lib/client/clientEntry.js:21:176

Maybe somebody can help me on this issue.
Many Thanks in Advance ☺

I'm not sure how it's actually supposed to work, and if there's a bug or if the readme is wrong, but we currently import it like this: https://github.com/tauri-apps/tauri-docs/blob/54de0e747978453fe38284d8cb430811c642456a/src/theme/SearchBar/index.js#L9 maybe that helps you to at get it somehow working for now :)

Many thanks!! This helped a lot :)


[Spike] Set up Cucumber/Gherkin to be used in the front end test suite

Description
We should adopt Cucumber/Gherkin for describing test cases, to make it easier to write and maintain them and to create a common vocabulary around testing and test scenarios. This will make QA a lot easier and faster and make it easier to maintain the codebase.
Solution
We should setup cypress-gherkin-preprocessor to bridge cypress and gherkin for describing test cases.
Describe alternatives you've considered

Using cypress out of the box helps engineers, but is less visible to non-engineers / makes it harder to write and maintain test suites.

Links to user research or other resources

https://github.com/TheBrainFamily/cypress-cucumber-preprocessor
https://cucumber.io/
https://cucumber.io/docs/gherkin/

Tasks

[x] Adopt gherkin-cypress-cucumber
[x] Setup a test or two to show how it would work

Definition of "Done"

[x] An initial pattern for creating more gherkin tests
[x] More fleshed out issues to write remaining gherkin tests

Status update:
tasks:

[ ] initial set up of cucumber/gherkin integration
[ ] added title page to each page
[ ] refactor each page (mostly cejst) to remove any dependencies on local css (tech debt)
[ ] move title string to intl


Rotate + Zoom on Image Decoder

I've an uploaded file selection that stores JPEG's and PDF's. Upon clicking any of them it'll detect the file type and use the appropriate render function for PDF's or JEPGs to display on a canvas in a modal on the same page. The JPEG render function is similar to the example image_decoders.
The issue I've run into is providing a Zoom and Rotation functionality to the image. Providing it to the PDF is straight forward using the Viewport, but have not found a solution to doing something similar with the image if there is one available?
I'm trying to avoid using CSS transforms as an alternative.
my current JPEG render function:
function renderJPEG(data) {
    pdfViewOptions.setAttribute('hidden', '');
    hideLoader();

    // Convert base64 encoded jpeg to a Unit8Array
    const typedArrayImage = Uint8Array.from(atob(data), c => c.charCodeAt(0))
    const jpegImage = new pdfjsImageDecoders.JpegImage();

    jpegImage.parse(typedArrayImage);

    const width = jpegImage.width,
        height = jpegImage.height;
    const jpegData = jpegImage.getData({
        width,
        height,
        forceRGB: true,
    });

    // Render the JPEG image on a <canvas>.
    const imageData = context.createImageData(width, height);
    const imageBytes = imageData.data;
    for (let j = 0, k = 0, jj = width * height * 4; j < jj;) {
        imageBytes[j++] = jpegData[k++];
        imageBytes[j++] = jpegData[k++];
        imageBytes[j++] = jpegData[k++];
        imageBytes[j++] = 255;
    }
    viewerCanvas.width = width;
    viewerCanvas.height = height;
    context.putImageData(imageData, 0, 0);
}

but have not found a solution to doing something similar with the image if there is one available?

That's because no such functionality exists for images.
Please note that the purpose of the PDF.js library is to, as its name suggests, parse/render PDF documents.
As part of doing that you also need to ability to decode various image formats, and as a convenience (since users asked for it) we thus provide some image decoders standalone (e.g. JpegImage). However, these image decoders are purposely very bare-bones and they only allow you to decode the image data (e.g. for rendering onto a canvas) but no other functionality.


Complete issue 265

This is an attempt to address checkbox 3 of https://github.com/tdwg/dwc/issues/265 . There were a couple other corrections that I also made.
One thing that I don't know how to address is making the list of terms document show up in the TDWG bar at the top of the page. That should probably be revised, changing "Terms" to "Quick Reference" and adding something like "Term list" for the new list of terms document.

After this gets merged, I think the build script for the QRG actually needs to be run and pushed to make the updates live.

@tucotuco @peterdesmet Should the list of terms document have text about the QRG and a link? People can see it in the header, but I'm thinking that it should. See also https://github.com/tdwg/website/pull/165

Yes, I think it would be good.
On Sun, Aug 16, 2020 at 11:54 AM Steve Baskauf<EMAIL_ADDRESS>wrote:

@tucotuco https://github.com/tucotuco @peterdesmet
https://github.com/peterdesmet Should the list of terms document have
text about the QRG and a link? People can see it in the header, but I'm
thinking that it should. See also tdwg/website#165
https://github.com/tdwg/website/pull/165
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdwg/dwc/pull/272#issuecomment-674536383, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADQ72ZYBL2R2EWQJ2DTI3DSA7XKVANCNFSM4QATR5PA
.

How's this for the link from the list of terms to the QRG: https://github.com/tdwg/dwc/pull/272/commits/b01b1ad6b276f1113f1fd5cf3a7c0cdeda10b904 ?

@peterdesmet Are you good with this? To summarize:

a link was added from the QRG to the new list of terms document https://github.com/tdwg/dwc/pull/272/commits/8b9c956400278878449e66b1e9ff5ebd977f432d Please check that the relative link to the list of terms document was done correctly (list/)
a link was added from the DwC GitHub repo readme to the new list of terms document https://github.com/tdwg/dwc/pull/272/commits/90b42ab46198e6aaead66ca00f3e777aec41561b
a link was added from the list of term document to the QRG https://github.com/tdwg/dwc/pull/272/commits/b01b1ad6b276f1113f1fd5cf3a7c0cdeda10b904
changed Baskauf affiliation https://github.com/tdwg/dwc/pull/272/commits/3ebeb8894fe123541de19ab653c53822696f02cf

After merging, the QRG needs to be rebuilt and pushed to GitHub.
I believe that this is all that remains for completing the Implement sustainable vocabulary maintenance workflow milestone.

Yay! So close!
On Wed, Aug 19, 2020 at 12:19 PM Steve Baskauf<EMAIL_ADDRESS>wrote:

@peterdesmet https://github.com/peterdesmet Are you good with this? To
summarize:

a link was added from the QRG to the new list of terms document
8b9c956
https://github.com/tdwg/dwc/commit/8b9c956400278878449e66b1e9ff5ebd977f432d Please
check that the relative link to the list of terms document was done
correctly (list/)
https://github.com/tdwg/dwc/blob/complete_issue_265/build/terms.tmpl#L11
a link was added from the DwC GitHub repo readme to the new list of
terms document 90b42ab
https://github.com/tdwg/dwc/commit/90b42ab46198e6aaead66ca00f3e777aec41561b
a link was added from the list of term document to the QRG b01b1ad
https://github.com/tdwg/dwc/commit/b01b1ad6b276f1113f1fd5cf3a7c0cdeda10b904
changed Baskauf affiliation 3ebeb88
https://github.com/tdwg/dwc/commit/3ebeb8894fe123541de19ab653c53822696f02cf

After merging, the QRG needs to be rebuilt and pushed to GitHub.
I believe that this is all that remains for completing the Implement
sustainable vocabulary maintenance workflow milestone
https://github.com/tdwg/dwc/milestone/10.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdwg/dwc/pull/272#issuecomment-676491460, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADQ727BGTAQQRHATZZIWTDSBPURTANCNFSM4QATR5PA
.

I noticed some 2020-08-12 terms, should we rebuild?

I noticed some 2020-08-12 terms, should we rebuild?

Yes, please.
On Thu, Aug 20, 2020 at 6:02 AM Peter Desmet<EMAIL_ADDRESS>wrote:

I noticed some 2020-08-12 terms, should we rebuild?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tdwg/dwc/pull/272#issuecomment-677473634, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADQ727EL45LWCV2D5W6C73SBTRDTANCNFSM4QATR5PA
.

See https://github.com/tdwg/dwc/pull/277 for rebuilt term_versions.csv. After running build.py I think the QRG should be in synch with the list of terms document since it has already been updated to the 2020-08-12 version.


Manual Installation Required for gh.py

I am getting an error when I try to install gh calling for manual installation. Sorry if I am missing something.
[~/Documents]$ pip install gh
Querying PyPI ...
Downloading package ...
Opening: https://files.pythonhosted.org/packages/46/80/c1e50b9b09a944b9b5f160d689fbf637b543bb8391019df1019986b8d397/gh-0.0.4.tar.gz
Save as: /private/var/mobile/Containers/Data/Application/00218FFC-9327-4A7E-AD86-2ACC00711426/tmp//gh-0.0.4.tar.gz (2192 bytes)
2192  [100.00%]
Extracting archive file ...
Archive extracted.
Running setup file ...
TypeError("a bytes-like object is required, not 'str'",)
Failed to run setup.py
Fall back to directory guessing ...
Error: Cannot locate packages. Manual installation required.

are you trying to use the gh github module for creating github repos?  that comes preinstalled with stash.  (this actually has no relation to the pypi gh command)

I was trying to figure out how to commit to an existing repository from StaSh.


Flip segment text

I can't find a method to change segment text so I made a custom adapter and I override  this method
@Override
    public void onSegmentSelected(boolean isSelected, boolean isReselected) {
        super.onSegmentSelected(isSelected, isReselected);
        if (isSelected) {
            setSectionDecorationSelected(true);
            itemTV.setText(R.string.on);
        } else {
            setSectionDecorationSelected(false);
            itemTV.setText(R.string.off);
        }
    }

then I used this adapter in my activity by this code
           segmentedShipSwitch.setAdapter(new ShipSegmentAdapter());
but segment text not fliped

I tried to made breakpoints but it doesn't stop in the adapter I think it doesn't use it

    segmentedShipSwitch.findSegmentByAbsolutePosition(this.isEasyShip ? 0 : 1).setSelected(true);
    segmentedShipSwitch.findSegmentByAbsolutePosition(this.isEasyShip ? 1 : 0).setSelected(false);

instead of segmentedShipSwitch.setSelectedSegment(this.isEasyShip ? 0 : 1);


Implement a file viewer on the drafts page

I was wondering if implementing a file viewer on the drafts page would be a nice enhancement.
Currently, we cannot see a file uploaded to a draft:

Of course, we can always download the file and check it. But, since we have a file viewer for the published modules, it would also make sense to implement here. People may want to preview how it would look like before publishing.
Thought about this while working on #481.

Great suggestion @nsunami!
This should be feasible as we can factor out the code from https://github.com/libscie/ResearchEquals.com/blob/b8e21f84e404eede7202113aa0363fd59c03552c/app/pages/modules/[suffix].tsx#L279 and implement it in two ends.
One additional thought I'm having is whether we should have a toggle for previewing supporting files in a similar way  (although that might be a separate issue/discussion)? What do you think?

@chartgerink Not sure why I missed your comment!

One additional thought I'm having is whether we should have a toggle for previewing supporting files in a similar way (although that might be a separate issue/discussion)? What do you think?

I think presenting supporting files can be too much if they are many.
One thing we could improve may be to open a new tab to show the files?
Currently, clicking the title of a supporting file downloads the supporting file. The behavior is the same as for the download button.

This would mean removing download from here
https://github.com/libscie/ResearchEquals.com/blob/eddbcbce3697a933ea6e2fabf11ea16fc365a650/app/modules/components/ViewFiles.tsx#L7-L13
To like this:
      <a
        href={url}
        className="mr-1 flex flex-grow rounded border border-gray-100 px-2 py-1 text-sm font-normal leading-4 text-gray-900 shadow-sm hover:bg-gray-100 dark:border-gray-600 dark:text-gray-200 dark:hover:bg-gray-700"
        target="_blank"
        rel="noreferrer"
      >


Bug Fix: IntervalSet Join with window

I'm using Join Operation of Rekall, and found that it is pretty slow. Then I went to the source code and found that the function IntervalSet._map_with_other_within_primary_axis_window used by IntervalSet.join  may have a bug.
Here is the location of the bug:
https://github.com/scanner-research/rekall/blob/master/rekallpy/rekall/interval_set.py#L244
I think the other_end in this line of code should be self_end, right?

Thanks for the bug fix! Things run much faster now :)


Move Identity dependency to a devDependency

Currently, the following packages use @azure/identity as a dependency rather than a devDependency:

app configuration - cc @richardpark-msft
event hubs - cc @chradek
text analytics - cc @willmtemple

Ping @willmtemple, @chradek, @richardpark-msft

This was done for event-hubs as part of #7669.
It looks like app-configuration and text-analytics were updated there as well:
https://github.com/Azure/azure-sdk-for-js/pull/7669/commits/1727353f192d640727b14131b1311d601308bb3b
I think this is safe to close now.

Confirmed all 3 packages have identity as a devDependency. Closing.


No wifi card found

My Phone is OnePlus7+Android 9.5.8+Nethunter
Perhaps this Android version is too new, so I have encountered a lot of strange problems (about aircrack-ng、wifite), but the difficult ones have been solved one by one.
hcxdumptool is the only problem left. I think this problem can only be solved by you. ;-)
airodump-ng works fine, but now hcxdumptool doesn't seem to recognize

The included driver doesn't support ioctl() system calls.
It is reported also here
https://forums.kali.org/showthread.php?44222-Gemini-monitoring-mode-question-amp-using-hcxdumptool&p=85992#post85992
and here
https://github.com/ZerBea/hcxdumptool/issues/60
airodump-ng and iw, too is working, because they use NETLINK and the driver uses NETLINK, too.
hcxdumptool doesn't use NETLINK and will not workusing this driver
The error message told you this:
ioctl(SIGCGIWMODE) not supported by driver
You can try to stop wpa_supplicant. But I don't think it will block the ioctl() system calls.
You can test if NETLINK is in use, running this command:
iw --debug dev wlan1 set type monitor
If you receive a message like this
Debug: Sent Message:
BEGIN NETLINK MESSAGE ---------------------------
[NETLINK HEADER] 16 octets
.nlmsg_len = 36
.type = 30 <0x1e>
.flags = 5 <REQUEST,ACK>
.seq =<PHONE_NUMBER>
.port =<PHONE_NUMBER>
[GENERIC NETLINK HEADER] 4 octets
.cmd = 6
.version = 0
.unused = 0
[PAYLOAD] 16 octets
08 00 03 00 03 00 00 00 08 00 05 00 06 00 00 00 ................
END NETLINK MESSAGE   ---------------------------
You're on a NETLINK interface.

Thanks for your detailed reply, I will perform more tests to determine the problem
btw: I used the same wifi card to use hcxdumptool normally on another older (CM13) Android phone. I will see if the driver is different, thank you again

We can use iconfig to test that ioctl() calls are working. iwconfig doesn't use NETLINK.
iwconfig wlan1 mode monitor
if we get an error, we know that ioctl() calls are not supported by the driver.

USING NETLINK is no option for hcxdumptool, because:
https://www.quora.com/What-are-the-differences-between-netlink-sockets-and-ioctl-calls
https://config9.com/linux/ioctl-vs-netlink-vs-memmap-to-communicate-between-kernel-space-and-user-space/

We can use iconfig to test that ioctl() calls are working. iwconfig doesn't use NETLINK.
iwconfig wlan1 mode monitor
if we get an error, we know that ioctl() calls are not supported by the driver.

Yes, as you would expect, iwconfig reports an error.

There must be a reason why the developer decided to use NETLINK instead of ioctl() calls.
I'm running this driver (rt2800usb) on Arch Linux and it is working fine (out of the box). All ioctl() calls are supported.
Maybe you can open an issue on Android Nethunter.
There are similar issues mentioned here:
https://forums.kali.org/archive/index.php/t-22989.html

@ZerBea We've got it. Thanks a lot, there are some issues as Android 9 & Android 10 is fairly new to the NetHunter project, as it was left behind for some time there's lots to catch up with :1st_place_medal:

Great, please keep me in the loop, because hcxdumptool can't give up ioctl() system calls. NETLINK is not an alternative to perform high speed attack vectors.

By the way:
Siwtching from iwconfig to iw doesn't make life easier. iw doesn't detect missing ioctl() system calls.

Hmm... I haven't really figured all that IOCTL, Netlink functions yet. This is what I see..
"iwconfig" is deprecated
see https://dougvitale.wordpress.com/2011/12/21/deprecated-linux-networking-commands-and-their-replacements/
And I notice it struggles more and more, but! I also see developers is removing the IOCTL functions from their drivers, similar to our.
Think I need to spend some time learning more about those two.. IOCTL is also used for lots of functions. Read, read read

Yes correct, iwconfig is deprecated and replaced by iw and iw is working fine. I recommend iw and ip, too, to set monitor mode. Unfortunately NETLINK and it's messages isn't able to control a driver in that way, we need to run some attacks.
Control: ioctl should be your first choice, unless there’s an overriding reason, due to its immediacy and reliable delivery.
Data: For occasional data passing, ioctl should work fine. For bulk data, and especially if you’re look at asynchronous operation, NETLINK is preferred.
Unfortunately we need "control" to perform attacks. In other words, if that feature is removed, the developer can remove monitor mode, too.
Unfortunately, I noticed that Realtek is going in this direction (NETLINK prefered, no monitor mode and packet injection in staging driver).

BTW
I share this opinion:
https://stackoverflow.com/questions/40529308/linux-driver-ioctl-or-sysfs/41258845#41258845

Well this actually happened.. I've added monitor / frame injection to branch v5.2.20(.2) on rtl8812au, on the release after (v5.3.4), Realtek actually added frame injection themselves, BUT.. they have hidden it pretty good, cause I can't really find it. It's become unstable with time, so I have to diff and look around between v5.2.20 and v5.3.4 to find where they hidden it. Totally weird, as I can't maintain it properly..

I have a 8188 device (my 8811 isn't working) and try to find out, what's going on inside the driver, if hashcat 6.0.0 and hcxtools 6.0.0 released.
New hashmode 22000 has priority (Atom pushed an update, yesterday), because it will save much GPU time. From now on we pay the price (PBKDF2) once and get the results (PMKID and EAPOL) twice (on same ESSIDs). Firsts tests are very  impressive.

8188 is working fine, they didn't add it there, and that's much more stable, faster/reliable. injection at 88XXau is sluggish, but working atm, even though I only did the v5.3.9 branch, not the two others yet

BTW:
I have a 8821AE PCIe device and monitor mode is working like a charm. All ioctl() system calls are accepted by the driver.

8188:
$ sudo hcxdumptool -i wlp39s0f3u3u1u2 --check_driver
initialization...
starting driver test...
failed to set monitor mode, ioctl(SIOCSIWMODE) not supported by driver: Operation not permitted
now running iw and create a NETLINK interface:
Interface wlp39s0f3u3u1u2
ifindex 8
wdev 0x200000001
addr 50:3e:aa:d5:e0:35
type monitor
wiphy 2
txpower 13.00 dBm
$ sudo hcxdumptool -i wlp39s0f3u3u1u2 --check_driver
initialization...
starting driver test...
interface is already in monitor mode
driver tests passed...
all required ioctl() system calls are supported by driver
terminating...
Now the driver is working. Unfortunately, the only way to set monitor mode is doing this via NETLINK
once, if we did that we can set monitor mode by ioctl() calls, too:
Interface wlp39s0f3u3u1u2
ifindex 8
wdev 0x200000001
addr 50:3e:aa:d5:e0:35
type managed
wiphy 2
txpower 13.00 dBm
$ sudo hcxdumptool -i wlp39s0f3u3u1u2 --check_driver
initialization...
starting driver test...
driver tests passed...
all required ioctl() system calls are supported by driver
terminating...
In other words: After device is plugged in, we must use NETLINK to set monitor mode - otherwise the driver doesn't initialize the hardware properly. There is something missing if we try to do initialization by ioctl() calls only.

Take a look at this...
root@kali:~/Desktop/rtl8812au# grep -or "ioctl" | wc -l
2086
root@kali:~/Desktop/rtl8812au# grep -or "NL80211" | wc -l
537
root@kali:~/Desktop/rtl8812au#

Correct. Unfortunately the ioctl() part is skipped during first init. Running NETLINK first, the driver doing an init as expected. Running ioctl() first, the interface remaining partly uninitialized. In that case we never reach this part:
https://github.com/aircrack-ng/rtl8812au/blob/v<IP_ADDRESS>/os_dep/linux/ioctl_linux.c#L1390
because we run into several fails between here:
https://github.com/aircrack-ng/rtl8812au/blob/v<IP_ADDRESS>/os_dep/linux/ioctl_linux.c#L1363
and here
https://github.com/aircrack-ng/rtl8812au/blob/v<IP_ADDRESS>/os_dep/linux/ioctl_linux.c#L1388
Mostly the fail ocured here:
https://github.com/aircrack-ng/rtl8812au/blob/v<IP_ADDRESS>/os_dep/linux/ioctl_linux.c#L1371
and here
https://github.com/aircrack-ng/rtl8812au/blob/v<IP_ADDRESS>/os_dep/linux/ioctl_linux.c#L1376
because the struct wasn't filled properly, because the init failed.


added scpi command for copying images

This adds copy image (scpi) command for copying images from one machine to another. Helpful if you have huge image that pulling it again will take long or if you don't have internet access.
This is my first PR, any feedback would be appreciated. :)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Very interesting.  I guess this would allow for things like:
$ docker $(docker-machine config swarmnode-0) pull me/image
$ docker-machine scpi swarmnode-0:me/image swarmnode-1
$ docker-machine scpi swarmnode-0:me/image swarmnode-2

?

@nathanleclaire yep, sorry forgot to add an example. The syntax is basically:
docker-machine scpi [machine]:[image][:tag] [machine]

The tag is optional, if omitted, defaults to latest.

Cool use case -- I'm definitely interested.  Why not use the Docker client API that machine has (this is how we manage swarm containers) directly instead of running docker commands over SSH?

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@nathanleclaire ah right, I think I can make that work. Will keep you posted.

@nathanleclaire I made some progress and I thought it even became simpler, let me know what you think. ;)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "scpi" git@github.com:marconi/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~4
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Hm, I think I have not been clear in communicating what I mean.
I mean that instead of shelling out to docker and docker-machine commands, it should use the built-in DockerClient from mcndockerclient module: https://github.com/docker/machine/blob/master/libmachine/mcndockerclient/docker_client.go#L11
Example usage in Swarm code here: https://github.com/docker/machine/blob/master/libmachine/provision/configure_swarm.go#L110
Can you update it to use that please?
Likewise, it should probably invoke scp directly.  I'd suggest trying to use the existing docker-machine scp-related methods.
Thanks!

@nathanleclaire ah, I see. Sure will update, I was actually initially looking for something like it but wasn't sure how libmachine worked.

Only see one problem, the DockerClient doesn't have support for saving image. But the engine-api's client does, I saw some discussion with dockerclient moving to engine-api so its prolly not worth it adding an image save endpoint for it esp. since machine has this as well.

Close this for now.


Bug: Unable to use toolbar on Android. How can I disable the context menu on text selection?

In the playground, if I highlight text, the Android context menu prevents me from selecting an option from the toolbar because it appears on top of the selected text. On iOS, it appears below the selection. Is there any solution for this?

Lexical version: 0.13.1
Steps To Reproduce

Use Android device
Go to playground
Highlight a text on top of the editable content area
You will notice that the Android context menu prevents selecting an option from the toolbar

Link to code example:

The current behavior
The Android context menu appears on top of the highlighted text, which prevents us from selecting an option from the toolbar.
The expected behavior
The context menu should be displayed above the highlighted text to allow for selection, or it should not be displayed at all.

The playground is, as its name suggests, only a showcase of what can be done with Lexical. That is, the functionality available there is provided for demonstration purposes, it's not expected to be production-ready. It's up to you to come up with UI/UX solutions that suit your use case(s).


Support both secure and non-secure connection

Is it possible to make WebSocker server with both supporting secure and non secure connections ?
If this TLS use secure and if it is regular HTTP, then resort to non secure.

Potentially, yes, even though I would recommend against it for obvious reasons. It's generally advisable to put a reverse proxy ahead (e.g. Nginx) anyways, so it's not something I see a real need for. @aaugustin might have a different opinion.

Potentially, yes, even though I would recommend against it for obvious reasons. It's generally advisable to put a reverse proxy ahead (e.g. Nginx) anyways, so it's not something I see a real need for. @aaugustin might have a different opinion.

I need it just for tests ,not for production.

I need it just for tests ,not for production.

Why not simply spin up an insecure server then or one with a self-signed certificate?

Why not simply spin up an insecure server then or one with a self-signed certificate?

I do it but I wanted to use the same port.

I do it but I wanted to use the same port.

Could you show how you would achieve this for a simple TCP echo server, written with asyncio?
Then we can evaluate adapting your proposal to websockets.

Could you show how you would achieve this for a simple TCP echo server, written with asyncio?
Then we can evaluate adapting your proposal to websockets.

I don't have an idea.
Something like pseudo code
on_request:
  if HTTP: use non encrypted
  else: use encrypted

I don't have an idea.
Something like pseudo code
on_request:
  if HTTP: use non encrypted
  else: use encrypted

If you look at the APIs provided by asyncio, you'll realize that it cannot work that way.
Here's the starting point: https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.create_server

If you look at the APIs provided by asyncio, you'll realize that it cannot work that way.
Here's the starting point: https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.create_server

I see. Closing then.

I see. Closing then.


Move to GitHub?

In GitLab by @wtbarnes on Jun 24, 2019, 11:30
RE: the discussion on the heliopython mailing list, I think there is a reasonably strong case for moving this package to GitHub.  While there are not really any technical downsides to staying on GitLab, the vast majority of packages in the heliopython and Python in Astronomy ecosystems (sunpy, astropy, etc.) are on GitHub.
Also, GitHub is undeniably the more widely-used platform. I think it would greatly increase the visibility of the package and subsequently the buy-in from the wider solar and Python communities if aiapy was on the same platform as everything else.
From what I can tell, none of the packages on the AIA_HUB or any part of aiapy has any tie-in to GitLab so this should be a very easy transition.

In GitLab by @wtbarnes on Jun 24, 2019, 14:44
There are various 3rd party CI services for doing automatic testing at PRs, merges that integrate easily with GitHub. A few examples are Travis CI and Circle CI. Both have free tiers and fairly easy to configure.

In GitLab by @wtbarnes on Apr 30, 2021, 05:55
I'm going to close this for now since we seem to have built up a decent workflow on GitLab and everyone seems to be pretty happy with keeping the development here.

In GitLab by @markcheung on Jun 24, 2019, 14:23
I do not have a strong opinion for keeping aiapy in Github.
One question though: What about testing new commits?


"missing whitespace" warning is reported even with every whitespace rule turned off

Bug Report

TSLint version: 5.12.0
TypeScript version: 3.1.6
Running TSLint via:  Vue CLI

TypeScript code being linted
beforeDestroy(){
               ^
  window.removeEventListener('resize', this.handleWindowResize);
}

with tslint.json configuration:
{
  "defaultSeverity": "warning",
  "extends": [
    "tslint:recommended"
  ],
  "linterOptions": {
    "exclude": [
      "node_modules/**",
      "**/*.json"
    ]
  },
  "rules": {
    "quotemark": false,
    "indent": [true, "spaces", 2],
    "interface-name": false,
    "ordered-imports": false,
    "object-literal-sort-keys": false,
    "no-consecutive-blank-lines": false,
    "whitespace": false,
    "typedef-whitespace": false,
    "no-trailing-whitespace": false,
    "no-irregular-whitespace": false,
    "space-before-function-paren": false,
    "space-within-parens":false,
    "prefer-const":false,
    "max-line-length":false,
    "comment-format":false,
    "member-access":false,
    "arrow-parens":false
  }
}

Actual behavior
I still get the whitespace error, I'm assuming because of the "check-preblock" check in the whitespace rule. All the other rules are correctly being turned off by the configuration, but not this one
Expected behavior
No more whitespace errors

💀 It's time! 💀
TSLint is being deprecated and no longer accepting pull requests for major new changes or features. See #4534. 😱
If you'd like to see this change implemented, you have two choices:

Recommended: Check if this is available in ESLint + typescript-eslint ✅
Not Recommended: Fork TSLint locally 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


feat: add '-h' flag for help command

add -h to list of available commands / flags to invalidProfiles making -h flag available.
This fixes #20

thank you for your contribution

thanks for your continued work!


Unable to play m3u8 HLS stream

Have you read the FAQ and checked for duplicate open issues?:
YES
What version of Shaka Player are you using?:
2.5.0-beta
Can you reproduce the issue with our latest release version?:
YES
Can you reproduce the issue with the latest code from master?:
YES
Are you using the demo app or your own custom app?:
If custom app, can you reproduce the issue using our demo app?:
What browser and OS are you using?:
Chrome on OSX
What are the manifest and license server URIs?:
Skipping to 10 seconds
https://video-dev.github.io/streams/x36xhzz/x36xhzz.m3u8
Not playing
https://watch.hoichoi.stream/movies/Chaya-Surya/hls/CHAYA_SURYA.m3u8
What did you do?
Tried to play normal HLS
What did you expect to happen?
Video should be played
What actually happened?
Errors
A very heartwarming hello to shaka team :)
I am facing 2 issues with Non DRM HLS Streams.
ISSUE 1

URI: https://video-dev.github.io/streams/x36xhzz/x36xhzz.m3u8
Content automatically skipping to 10 seconds.
CodePen Example: https://codepen.io/bansalvks-the-decoder/pen/xyYgEp?editors=1010
If I am playing the same stream with HLS.js then its working fine, example
https://codepen.io/bansalvks-the-decoder/pen/pxaRdN?editors=0010
ISSUE 2
ERROR: 4030 -- MANIFEST.HLS_COULD_NOT_PARSE_SEGMENT_START_TIME
Unable to fetch a partial HLS segment! Falling back to a full segment request, which is expensive!
URI: https://watch.hoichoi.stream/movies/Chaya-Surya/hls/CHAYA_SURYA.m3u8
SHAKA CODEPEN: https://codepen.io/bansalvks-the-decoder/pen/JmpXWR?editors=1011
With Hls.js its working fine.
HLS.js CODEPEN : https://codepen.io/bansalvks-the-decoder/pen/gBvgGN?editors=0010
I am very new to streaming domain and I am trying my best.. Many Thanks for everything,
Your Fan,
Vikas Bansal
P.S: I am not comparing HLS.js with Shaka player, I am just trying to validate the streams... Please do not take it wrong..

@ismena thank you for replying, it means a lot.
I updated the codepen : https://codepen.io/bansalvks-the-decoder/pen/xyYgEp?editors=0010
and added the config that you mentioned
 player.configure('manifest.defaultPresentationDelay', 0);
However it does not work. :( still stuck with both issues.

Ahh, I was so sure, that was it :)
Sorry for the random guess, I'll do a proper investigation tomorrow.

Many thanks @ismena... it feels so good and emotionally helpful that someone is looking after your issue. Huge thanks for devoting your time.
I struggling with playing HLS .m3u8 streams in shaka player...
P.S/FYI: I am working for a content distributor not content owners so I have to support all kind of streams.. I cannot or request to alter or change streams manifest. We just have to play it.

@joeyparrish could you please check if our parser is doing something wrong, once you're back

@ismena You have the skill of cutting the tension with a hilarious comment just like one of my fav char Cisco Ramon
Will be waiting for the response from @joeyparrish and hope he will like the big pink sticky note on his monitor :D :X :)

Aww, I've never been compared to a superhero before :blush:

Noticed in #1602, fixed in bc7f31efbd6d57ef905c344338bba8fd8c0da5ab.  You can try the nightly to see it works: https://nightly-dot-shaka-player-demo.appspot.com

The second isn't playing because we can't parse the TS data.  We only support playing encrypted TS through Widevine, we don't support AES-128 (see #850).  With Widevine encryption, the TS headers are still in the clear, so we can pull the start time out of it.  With AES-128, the whole data is encrypted, so we can't get the start time.  Even if we ignored that error, we would get a different error later since we don't support AES-128.

Thank you @TheModMaker, I should've known to ask you!
On the down side, I'll have to take the sticky note off Joey's monitor now.

Many thanks @TheModMaker  @ismena  for sparing your time to look at this issue
First Issue:
As you said I used
https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.debug.js
and found that the video is still skipping 10 seconds as you can see in this code pen
Second issue:
Its seems that I have to use HLS.js to play the AES-128 content or please let me know if there is any work around to do so.

Many thanks @TheModMaker @ismena for sparing your time to look at this issue
First Issue:
As you said I used
https://nightly-dot-shaka-player-demo.appspot.com/dist/shaka-player.compiled.debug.js
and found that the video is still skipping 10 seconds as you can see in this code pen

Did you try clearing your browser cache?  When I go to the code pen link it plays from 0.

Second issue:
Its seems that I have to use another lib e.g.HLS.js to play the AES-128 content. If you know a workaround please let me know.

Unfortunately yes, until #850 is closed you'll need to use something else to play that content.

Yes its working fine after cleaning cache. Pardon me for my ignorance @TheModMaker
Waiting for the release with this fix.
May I Know when will it be released?
Many thanks  : )

This is a Disheartening News for me @TheModMaker
May I know the release cycle span. So that I may guess how soon will we get the release v2.7

We released v2.4 in May and are still working on v2.5.  v2.6 will hopefully have a shorter release cycle, but it is hard to tell.  It will probably be at least 6 months before we can work on that feature.


How to generate the bear at the end of the readme.md？

Great work! Could you please tell me how to generate the bear at the end of the readme.md？

Thanks!
Well, first, it's not a bear, it's a koala xD
I just searched on google for something like "koala ASCII", then the code formatting allows to have  fixed-width characters.


Is the guidance up to date?

Microsoft has recently been using icons without a backplate.
My opinions below:
Android 8 and above force apps to use adaptive icons. Android 7 and below have "shapeless" icons
iOS and iPadOS have "shaped" icons
What's the deal with Windows 10? 7 has shapeless. 8-10 have shaped. How about now?
Adaptive icons wouldn't be particularly bad, as long as the user can customise the OEM's default and if users could make an app ditch the white background.
I've mentioned it, now I have to talk about it. yeah nah, i'll get someone else to do it for me https://medium.com/swlh/let-s-talk-about-white-app-icons-ce2e83b9eb86
Google and Apple both are guilty. Google especially though. Google made a shapeless Maps icon and on Android 7 and below it has a white background lmfao
then again, there's mobile vs desktop (iOS vs macOS) but Microsoft and other companies make icons for both anyway.
all of the apps that have these new icons have hardcoded blue splash screens except for OneNote too

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 287ed7e0-5cbc-bf87-360c-5c5a47b451d0
Version Independent ID: 87cd355a-d27b-47cc-1be5-951653cf52f1
Content: App icons and logos - UWP applications
Content Source: windows-apps-src/design/style/app-icons-and-logos.md
Product: uwp
Technology: design
GitHub Login: @hickeys
Microsoft Alias: hickeys

Icon and Tile asset documentation should be refreshed and updated

They should add guidelines or tutorials for people trying to design icons using the fluent design language.

Thank you for the feedback. I agree that the icon guidance needs to be updated, but some of the comments in this issue are beyond the scope of this repo. Issues here are for documentation changes only.
I've taken the feedback here and am tracking it internally. I know that isn't the most satisfying resolution, and I'm sorry. The core issue here with respect to documentation is valid, and it will be addressed in future documentation updates.


Wrong Video URL

Hi there,
I was trying to download a course, everything works good, except for one video. The video url was a placeholder. Is it a bug or somnthing wrong with FEM api?

Thank you

Yes, this does happen only for few recent released courses. When the video DOM element cannot be found in the page, a dummy URL is produced (temp solution to make sure the script does not fail and tell me which video is not get downloaded).
I am not sure why this bug exist from FrontendMasters site. When you try to open the target video from the site it just redirect to the home page (it is the reason why the script cannot extract the URL from the DOM).
This is the exact same issue mentioned in https://github.com/li-xinyang/OS_FrontendMaster-dl/issues/21.

Thank you @li-xinyang


docs: Correct the reference repo in the Cloud - Setup App (pyproject.toml) documents

fix: Point the reference repo to langgraph-example-pyproject
fmt

nice, thank you


Annotation Time

Great job! A Simple idea with wonderful results. How do you annotate all training videos by using 17 trackers? And how much time it will take?

I am assuming by annotation, you mean data generation for our BofN predictor. If yes, we run all trackers on the training videos to obtain their respective performance and then select the tracker with the best performance. This gives a video-'best tracker' pair. More details can be found in our paper.
Regarding the time, it depends on your computing resources.

In your paper, the Bofn predictor is used to choose the best of 17 trackers. However, the workload of obtaining the AUC of all trackers for each training video is enormous.  Can you share information about your computing resources and the time cost for annotating all training videos?

At the moment, I cannot ascertain our actual time cost for annotating all the videos but one can easily determine the time it'll take a tracker to run a video, hence, the overall time on a dataset can easily be determined. As with most data creation tasks, running all the trackers on all the datasets will definitely take some time. However, this is a one-time task.


Making sure default_stack_size is defined whenever declared

Fixes problems as described in #5351

@hkaiser That fixed the linking error reported in #5351


Switch from Eclipse Package Drone to Packager for RPM support

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage     27.79%   27.79%
  Complexity      322      322
=========================================
  Files            46       46
  Lines          2911     2911
  Branches        341      341
=========================================
  Hits            809      809
  Misses         2018     2018
  Partials         84       84

Impacted Files
Coverage Δ
Complexity Δ

...ain/java/com/redhat/red/build/finder/Checksum.java
55.55% <0%> (ø)
15 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5cf61...8d09bd1. Read the comment docs.


[R-package] Fix R memory leaks (fixes #4282)

Fixes #4282
This PR addresses a couple sources of potential memory leaks in the R interface:

Changes the logger to print R error messages instead of throwing errors directly, thus avoiding long jumps in the middle of C++ functions (which would be triggered by R errors).
Adds unwind protection around R allocations that happen after C++ allocations that need to call a destructor.
Expands the try-catch blocks to catch also C++ exceptions, which if thrown from an R-called C function can produce leaks in the best case and segfaults in the worst case.
~* Moves the order of header includes so as to have the R ones at the end as suggested in the R extensions manual, in order to avoid any possible misinitialization of non-R code.~

@jameslamb I see the linter complains about system headers being included before R headers, but the R extensions manual recommends the opposite (e.g. in section 6) and in the past it has happened that some compiler updates cause strange breakage when R headers are included before system ones (and it will BTW have an issue with clang13 if any of those LGBM headers include omp.h).
Was this for some code aesthetic reason, or is there some issue with the order of header includes that the linter tries to prevent?

Including <R.h> in utils/log.h causes compilation errors in windows due to conflicting function or macro names between R headers and other headers (Realloc and Free). This is most likely due to the header inclusion order.
I think it is enough with just declaring the function prototypes from <R.h> that will be used instead of including the full header (at least compiles and loads on my setup) but I'm not 100% sure about it.

🎉 thanks for this awesome contribution, really exciting!

I see the linter complains about system headers being included before R headers... is there some issue with the order of header includes that the linter tries to prevent?

After a little investigation, I see that you're referring to these specific errors from build https://github.com/microsoft/LightGBM/runs/3528466185?check_suite_focus=true.
R-package/src/lightgbm_R.cpp:15:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:16:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:17:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:18:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:20:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]
R-package/src/lightgbm_R.cpp:24:  Found C system header after other header. Should be: lightgbm_R.h, c system, c++ system, other.  [build/include_order] [4]

Yes, cpplint tries to enforce the Google style guide for C++ code. See https://github.com/microsoft/LightGBM/issues/3132#issuecomment-636508918
Since it seems you've removed the header-reordering stuff from this PR, it seems those changes are not strictly related to this one, and could be proposed in a separate PR. If you think cpplint's decision here could lead to issues, we'd welcome a separate PR with the header-reordering for the R package, a link to the specific advice you're referring to from "Writing R Extensions", and a link to any other evidence you can provide that a different ordering is preferable. It's possible to add line-level comments to to suppress false positives from cpplint.

I think it is enough with just declaring the function prototypes from

I'll have to investigate a bit to see if just including the template for R_FlushConsole() in log.h works as expected, thanks for calling it out as worthy of extra attention.

/gha run r-valgrind

/gha run r-solaris

/gha run r-valgrind

@david-cortes thanks for looking into the valgrind issues. Right now only maintainers can trigger new builds of that check (and other comment-triggered actions in this repo), so I'll do that for you.
Alternatively, you can try running it manually using Docker. You can see the relevant setup at https://github.com/microsoft/LightGBM/blob/64f15005040aafa528bbec7f873364d94b7e36a4/.github/workflows/r_valgrind.yml#L12.

/gha run r-valgrind

Well, valgrind this time does not report any "definitely lost" or any "indirectly lost" memory. The only thing that I see is a "possibly lost" which is the memory allocated by the C++ exception objects like std::runtime_error when they are thrown, and I'm not 100% sure that those are actual leaks since libstdc++ is also supposed to be managing exceptions (not sure where exactly and at which moment are the exception objects supposed to be destructed though).
There's also other "possibly lost" coming from GNU's openmp, and I'd guess those are false alarms since valgrind and libgomp don't play along. The RDvalgrind build is BTW not supposed to use openmp in packages.
It additionally has some additional warnings coming from outside the package, such as from R's grep, which may be false alarams, or may be actual cases of some R string being created from uninitialized memory:
==3480== Conditional jump or move depends on uninitialised value(s)
==3480==    at 0x49D0CB1: gregexpr_Regexc (grep.c:2429)
==3480==    by 0x49D39AD: do_regexpr (grep.c:3066)
==3480==    by 0x49A0D06: bcEval (eval.c:7128)
==3480==    by 0x498C390: Rf_eval (eval.c:740)
==3480==    by 0x498F0FF: R_execClosure (eval.c:1910)
==3480==    by 0x498EDB2: Rf_applyClosure (eval.c:1836)
==3480==    by 0x49A093A: bcEval (eval.c:7096)
==3480==    by 0x498C390: Rf_eval (eval.c:740)
==3480==    by 0x498BEDC: forcePromise (eval.c:568)
==3480==    by 0x4997059: FORCE_PROMISE (eval.c:5149)
==3480==    by 0x4997214: getvar (eval.c:5190)
==3480==    by 0x499DE53: bcEval (eval.c:6880)
==3480==  Uninitialised value was created by a stack allocation
==3480==    at 0x49D07B0: gregexpr_Regexc (grep.c:2359)
==3480==

After some more investigation, it seems in theory a standards-compliant compiler should not produce any memory leak from std::runtime_error + longjmp, but in practice some compilers (tried GCC and CLANG) may leak it if the jump is not within the same function call.
I've pushed a workaround which should fix it by using a global variable with a string buffer, which I guess should solve the "issue" but it's perhaps not as ideal (now it copies messages from a fixed buffer, to an exception, to another fixed buffer).

@jameslamb Another unrelated thing: the R examples and tests are not supposed to use more than 1 or 2 threads. One of the tests currently calls function LGBM_DatasetCreateFromCSC from the C api, whose function definition contains has this line:
#pragma omp parallel for schedule(static)

... which would make it run with the maximum available number of threads.
I guess the proper solution would be to modify that C function to take the number of threads as a parameter, but that'd be bigger then this PR as it's also used by the other interfaces.

... maximum available number of threads

thanks for opening #4598 to document this outside of this PR!

After some more investigation... I've pushed a workaround

wow awesome, thanks! I'll trigger another valgrind build to test that.

/gha run r-valgrind

Looks like the memory leaks are fixed now. What remains from the valgrind logs (outside the scope of this PR) is to avoid multithreading in the examples (https://github.com/microsoft/LightGBM/issues/4598) and to investigate the R string that's being used uninitialized (no idea about it and don't know which example is triggering it).
The other check that is failing is unrelated to this PR since it's about the Python version.

What remains from the valgrind logs...outside the scope of this PR

Yep, excellent! We've already gotten CRAN's agreement in the past that remaining "possibly lost" warning is allowable based on their policies, so it's intentionally allowed in our tests here.
==3478== 336 bytes in 1 blocks are possibly lost in loss record 147 of 2,542
==3478==    at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==3478==    by 0x40149CA: allocate_dtv (dl-tls.c:286)
==3478==    by 0x40149CA: _dl_allocate_tls (dl-tls.c:532)
==3478==    by 0x5724322: allocate_stack (allocatestack.c:622)
==3478==    by 0x5724322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==3478==    by 0x56F2DEA: ??? (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==3478==    by 0x56EA8E0: GOMP_parallel (in /usr/lib/x86_64-linux-gnu/libgomp.so.1.0.0)
==3478==    by 0x151B6C5B: LGBM_DatasetCreateFromCSC (c_api.cpp:1343)
==3478==    by 0x151E6284: LGBM_DatasetCreateFromCSC_R (lightgbm_R.cpp:135)
==3478==    by 0x49423D7: R_doDotCall (dotcode.c:627)
==3478==    by 0x494D38B: do_dotcall (dotcode.c:1284)
==3478==    by 0x498CA40: Rf_eval (eval.c:843)
==3478==    by 0x4992DAA: do_set (eval.c:2982)
==3478==    by 0x498C7E7: Rf_eval (eval.c:815)

https://github.com/microsoft/LightGBM/blob/64f15005040aafa528bbec7f873364d94b7e36a4/.ci/test_r_package_valgrind.sh#L46-L71

The other check that is failing is unrelated to this PR since it's about the Python version.

yep, you are right! We have some ongoing issues in CI with a build that tries to emulate ARM64 architectures using QEMU. #4594 tracks it, if you're curious.

/gha run r-solaris

@david-cortes sorry for the inconvenience, but could you please merge the latest master into this branch? That should fix the unrelated CI failures, now that we've merged #4600.

/gha run r-solaris

On second thought, these changes would still leave open a very small chance of leaking memory if a continuation token fails to allocate, which should be very improbable but is in theory possible. I’ve modified it now to avoid potentially leaking if that happens, would be good to run valgrind again just in case.

@jameslamb I’m fairly certain that this r-rchk test is throwing a false alarm. It doesn’t seem to work correctly when R dynamic objects are managed through C++ constructors and destructors.

/gha run r-valgrind

/gha run r-solaris

@Laurae2 Are you able to provide a review for this PR?

/gha run r-valgrind

/gha run r-solaris

I think that formal approval should be done by R-package maintainer.

thanks! I'll review the new changes tonight


Edit of comment no longer working

Editing of an issue comment is no longer working.
Win7  & Firefox 47
Android 8.1 Browser at Samsung Galaxy  S4 Tablet

... no its working on Android.

.. and this is the wrong repo. This repository is about the hub CLI tool and not about GitHub itself.


fixing portrait mode

changes on 2 functions to get correct rotation and aspect ratio of models in portrait mode

WOW thanks, i will test that, but if it works it is great! i had this bug for a long time :(

Yeah, a long time issue, I really needed portrait mode on XR.+, so I had no choice but to fix it ;)

@pikilipita @jeromeetienne  do you have the A-Frame Build to test the fix? Thank you !

Sorry, I'm not using A-Frame so did not applied the patch to it. You have to wait for  jeromeetienne  to review this commit

Ammended it like yout did. Works for me, thanks pikilipita!

Thanks @pikilipita ! Your fix works like a charm :)

Merged! thanks for fixing this :)

friends, this was  a great fix, anybody has any ideas for #249 ? its a basic one, being able to click on an specific element (which works great on aFrame by itself), all best

this doesn't fix it on ios devices but this does :)
            function onResize() {
                arToolkitSource.onResizeElement()
                arToolkitSource.copyElementSizeTo(renderer.domElement)
                setTimeout(function(){
                    arToolkitSource.onResizeElement()
                    arToolkitSource.copyElementSizeTo(renderer.domElement)
                }, 500);
            }

@makslevental interresting! where is this onResize you are speaking about ?

@jeromeetienne https://github.com/jeromeetienne/AR.js/blob/146d301c86f641dc3b392954ff526bce06972af7/three.js/examples/basic.html#L70

All the new branches after fixing the portrait mode do not work aframe using a-anchor and custom markers. Does anyone have an working version? Thank you.

@stefanluchian Interesting, do you know of a fix for this?

No, but I look forward to test the fixes in issues #678 and #750 regarding this problem.
Also something new seems to be available: https://github.com/AR-js-org/AR.js/. Not sure what exactly is different comparing to this repo.

The one you linked is the repo where you should open issues/PRs. It will be the new repository for AR.js, owned by an organization and not left alone like the current one.
Migration is happening, we are in the process these days.


version broken, changelog not working

The problem

semantic-release version posts wrong version
semantic-release changelog prints nothing

Expected behavior

there are 11 feat:  commits in the log.  Just so you know - since you've only done a single release, all those feat commits should only trigger a single new version, 0.2.0, instead of 0.11.0 - you don't get a bump for each feature commit :slightly_smiling_face:
I guess the problem is here, regex-matching for something that "looks" like a version commit from a previous PSR run. I don't have a quick/good solution for you other than a quick-and-dirty reword of the commit message refactor: use to_list\n\nfrom flupy 1.2.0\n to something which doesn't contain the three-digit pattern.
Are you now generating any changelog?

Just so you know - since you've only done a single release, all those feat commits should only trigger a single new version, 0.2.0, instead of 0.11.0 - you don't get a bump for each feature commit 🙂

Hi, maybe that's common knowledge but is this expected behaviour? If so, could you explain why that is? Is is because we want to have consistent version bumps, e.g. from 0.1.0 to 0.1.1 or 0.1.0 to 0.2.0 for a patch and minor release respectively? Why not going from one release at 0.1.0 to 0.3.0? Would be interested to hear the reasoning behind it. Thanks for your contribution on 0.8.x, looking forward to the changes! @bernardcooke53

Hi @johschmidt42 - yes that's expected behaviour. Let's say you have a process to release a new version of your software - it might be git tag, it might be running PSR or it might be something else entirely. If you want to release a new version with every commit, you can run that process automatically after every commit. However let's say you're making many incremental changes towards a new release of that software - in that case you'll roll many commits that have taken place since your previous release into the new release. With the commit log above, running a release would look at those commits, identify the feat prefix and deduce that the most significant change since the last release is a compatible feature - so you'd get a single minor release.
The semantic versioning spec says that when you release a new version it should indicate the most significant change introduced since the last release - a new release can contain both features and patches, but if it does the new version number should indicate that new features are introduced (i.e. a minor release) instead of just fixes. Likewise if there's a breaking change along with other fixes, the new version should still indicate a breaking change via a major release. Items 6-8 here are carefully worded so that although many types of changes can be introduced version-to-version, the new version communicates the most significant change that's introduced.
Generally speaking you wouldn't see versions 0.1.0 and 0.3.0 without 0.2.0, although technically it still represents that some compatible features were introduced between 0.1.0 and 0.3.0 - if a release is "missing" it might have been yanked, which would indicate there was a serious problem/risk with allowing that software to be installed by a user (like a CVE).

Hi @bernardcooke53,
thank you for explaining that part! Your explanation is clear and helpful, I appreciate the time you took to explain it to me!


Wait and retry when back-up url is available but returns HTTP error

This is helpful in cases where the Rust app is running behind a proxy.
Closes #12

@liamdawson it would be greatly appreciated if you could try this PR and report whether or not it fixes your issue. I will then merge it and probably publish a new release.


Implement datamodule for ecoacoustics dataset

supersedes #71

Please review, Myles, and merge if it's all fine.


Add example of Loggers

@nohwnd : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@pavelhorak @AbhitejJohn Please take a look. Thanks!

@nohwnd Jakub, looks like this got merged. Would you mind opening a new PR to address comment from Abhitej? Thx!

@Mikejo5000 @AbhitejJohn Apologies--I didn't observe that approval of the commit conflicted with a request for a revision (and so, a need for clarification or explicit approval). Sorry for the oversight.


Better handling of iCal files with recurrences

Adds more robust handling for iCal files containing complex recurrence rules:

Recurrence rules with exceptions ("daily at 7 PM except 7/4")
Individual edits of a specific recurrence ("On 7/3, title='Day before 7/4' and start at 9 PM instead of 7 PM")

Wow, so nice. I'll try after some times. Thanks for your contributions


Use includeBuild in samples

When setting up samples you can sometimes use gradle's includeBuild to automatically substitute your local version for the published artifact. You can see an example in CrashKiOS here.
For each sample in Kermit, update settings.gradle to use includeBuild to substitute a local build of Kermit. You will also need to not include versions when using the kermit dependency in the samples.
Confirm it's working by making local changes to Kermit and making sure the sample picks up the change.

We ran in to issues when using the composite build including a metadata issue with kermit-crashlytics, incompatibility with the legacy JS compiler.


automatically find key of audio

right now I need to separately use a KeyFinder or experiment a bit to know which key my sample audio is in and restrict the midi output with this info. it would be very convenient if this could be done in the plugin with the press of a button.

Hi,
Thanks for the request. It's not on the roadmap at the moment but it would definitely be nice to have it. Contributions are welcome!


[Security] Domain verification could be easily bypassed

Summary
While giving a quick look to the code I noticed that the hostMatches function used to verify if a given host is in the config.enterprise_domains array is weak and could be easily bypassed.
Description
While visiting a website the extension reads the current hostname and calls the getDomainType function in order to understand if, among the others, a green badge should be displayed or not, indicating that the website is a corporate one and should be trusted.
The getDomainType calls under the hood the hostMatches:
https://github.com/palantir/phishcatch/blob/07b0b359d7a662c69d10b7f9364433c07cb4ec17/extension/src/lib/getDomainType.ts#L34-L47
It basically loops over all the domains stored in config.enterprise_domains and:

If the stored domain matches the visited one it returns true.
If the stored domain is a wildcard one (i.e. *.google.com) it checks that the visited one ends with the wildcard domain without the *..

This approach is very weak because it would mark as an enterprise domain any domain ending with (in my example) google.com (i.e. nomoregoogle.com).
It should be also pointed out that using fake domains ending with the legit one is a very common phishing technique.
PoC

Install the Phishcatch extension
Set as enterprise_domains: ["*.google.com"]
Visit https://nomoregoogle.com
Notice that the green badge on the Phishcatch extension appears

Addendum
While writing this issue I also realized that as enterprise_domains are threated as RegExp then the . character is evaluated as a wildcard. This means that if the enterprise_domains contains ["*.nomor.google.com"] then nomoregoogle.com would be matched as an enterprise domain.

Good find. Will have this fixed later today.

The fix looks good on my side.


Write a TypeScript program to find sum of n natural numbers using formula

Description
Write a TypeScript program to find sum of n natural numbers using formula
formula: n(n+1)/2
Input  : 5
Output : 15

How to contribute

Save the solution in FindSumOfNNaturalNumbersUsingFormula.ts file
Add FindSumOfNNaturalNumbersUsingFormula.ts file in program/find-sum-of-n-natural-numbers-using-formula folder

!assign


fix fix memory leak of FE because of the ExportJob

What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When an Export job has finished or cancelled, ExportMgr will maintain the reference of the ExportJob object. So we need to clear these no longer used stuff, otherwise it'll cause memory leak of FE.
Release note
None
Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[x] Other reason: It can not be figured out in neither Unit Test nor Regression test.

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall


[BUG] - Improve Wifi Roaming (AutoTunnel delay)

Describe the bug
Was running 3.4.8 from play store a few days and noticed that sometimes the tunnel was turned on, also in trusted networks.
That's because I have two access points (Unifi UAP-AC-LR) and when I am moving in my apartment my phone roams between the two.
As stated by @zaneschepke there is currently a 1 second delay for switching an no recheck.
Smartphone (please complete the following information):

Device: Pixel 8 Pro
Android Version: Android 14
App Version: 3.4.8

To Reproduce
Steps to reproduce the behavior:

Use Wifi with more access points
Move between those accespoints (so phone will auto roam)
Sometimes see the issue that tunnel is active but phone connected to trusted wifi

Expected behavior
not activate (or deactivate) the tunnel when on trusted network
Additional context
There are two solutions/workarounds to this:

increase the 1 second delay -> better: make an setting with default value (maybe 3 seconds?)
do a recheck, say after ~10 seconds (in my case it would activate the tunnel after the second (sometimes) and deactivates it after ~10 seconds).

I prefer the first solution/workaround.
Please let me know your thoughts.
I think this would improve reliability of auto tunneling further!

Hey! I'm increasing to 3 seconds as requested.
The reason there is no recheck is so people can override auto tunneling if they want to turn the tunnel off without auto tunneling turning it back on.

Thx, I think that would help.

I'm going to mark this one as closed as I think the increase has fixed the issue. If it comes up again let me know and we can reopen.

@zaneschepke yes, totally fixed the issue. With the newest play versions. I did not had the issue.
Thx


idk how to play offline by downloaded files on mobile

I wanna play pokerogue by downloaded files on mobile app, but when I run pokerogue offline, I cannot click offline button. Is there any solution for this?

You need to download files first with one of the two buttons below it.

when I click 'play offline' button bt downloaded files in that way, game stops.


Central Lifecycle State stuck at connected

When a peripheral device stops advertising/gets disconnected, the central's lifecycle state is stuck at connected.

When a peripheral device stops advertising/gets disconnected, the central's lifecycle state is stuck at connected.

Hello, MG-LSJ. The issue mentioned above is something I am aware of and considering when updating the plugin. I apologize for the delayed response. Thank you for your interest in the plugin. I plan to keep the issue open until it's resolved, and when the problem is fixed during the update, I'll leave a message regarding the issue. However, I'm not sure until when this will be possible, but I'll do my best. Thank you.


UPDATE Training TIPS

Now that the 0428 update has been applied, I will modify some of my training tips.
I aim to create the Japanese and English versions in April.

Thanks. I think you mean May?

I will create a draft this Saturday and Sunday. Reflection may be in May, but we will start as soon as possible.


Change footer style

Change the style of the footer as shown in the following image ⬇

I would like to work on this issue

I would like to work on this issue

Will assign you when you complete the other one.

I would like to work on this issue

I would like to work on this issue as a LGM-SOC participant. I have designed footers

I would like to work on this issue as a LGM-SOC participant. I have designed footers

Hey @Kumud-869231165 someone is already assigned to this issue.


[WHISPER] edit shared file from someone else

Unable to change shared file in whisper. If it is my own file I can edit it without problems.

The route was missing a token and {status: 2}, so it never got passed the checks.


Allow unnamed trailing lambda

I added the parameter on the annotation because I'm not checking to see if the lambda is actually trailing. If I do that (and I think I could) then I can remove that parameter.


Can a custom control be used with multiple maps?

Sorry to bother again...
hope you can help, otherwise, please feel free to ignore this message.
I am interested in adding a custom control outside my maps as you did with app-mouse-position.
My goal is to have a single control that can be used with multiple maps to (e.g.) list the number of layers wthin the clicked map somewhere. This control will be placed in a target outside the maps.
However, am I supposed to add it to use setMap() upon creation, or shall I simply define it and use it when I need it?
I see from your app-component.html that you define your app-mouse-postion twice, once with a mapId attribute and once without. May I ask you why? I would be interested in how the one without mapId could be used for my case.
<!-- Define control outside the map -->
<app-mouse-position></app-mouse-position>
<app-mouse-position mapId="map1"></app-mouse-position>

I think my main problem is that I will have to switch map in my control with setMap() every time I click on a different map, while in your example I guess the mouse coordinates can be taken from either of the two maps as they are in sync, am I correct?

Hello,
A control is associated with only one map. So you have to create one control per map (as mouse position in the example).
The trick is to hide the control when the map is not concerned and show only one at a time.
You can use setMap to switch the control map when a map is active.
But don't have to use it, you can add a control per map and you just have to show / hide the control when the map is active or not (if the mouse is on the viewport or if a map is clicked).
@+

Thank you so much again for your precious feedback!
I was able to implement the outside controls.
What I did was:

create one control per each map and associate each of them to one map
draw them concurrently BUT one on top of the other, to give the impression that it's just one control
create a service that, after clicking one control (they actually are all buttons in my case), handles the activation/deactivation of all other similar controls underneath
activation/deactivation of controls also implies adding/removing the click event listener to each maps the controls are associated with (i.e. by using e.g. this.clickKey = map.on('click', whatever)to a variable on activation and usingunByKey(this.clickKey)` when deactivating

Again, thankyou so much for clatrifying the 1 control -> 1 map rule, and to give me a suggestion for solving the problem!
Closing now :+1:


Record page

The saved recordings page is now fully functional and all code is documented. Could you please review and merge this branch into master?

Seems all good to me


AUI-1997 Test

Just started reviewing :) :octocat: Sent from GH.

Can you add the entry to the scheduler HISTORY file?

Done. All changes were applied to the same branch so you can fetch it again now.

Just started reviewing :) :octocat: Sent from GH.

Pull request submitted to https://github.com/mairatma/alloy-ui/pull/251. See changes here. :octocat: Sent from GH.


Can cached_property be a subclass of property?

There are certain pieces of code in some libraries, linters and static analyzers that check things like
if isinstance(attr, property):
    do_something()

This is especially important for use in metaclasses.
Obviously this fails with cached property; would it be possible to derive it from property so isinstance/issubclass checks work as expected?

That's a fun idea! There isn't a stupid-quick fix for this: I quickly checked and if we inherit all the cached-property classes from Python's property built-in, then a third of the unit tests fail.
But I'm pretty certain there's a way to do it.

since the python property is a data-property, that would mean always having a slow implementation
the properties with annotations/ttl however look like a good candidate for that

Inheriting from property also seems to fix #27


Upgraded electron to '11.4.4'

Description
Upgraded electron to 11.4.4
Motivation and Context
Important security fixes
Note: If you are going to approve and merge #1308 - then this PR can be closed without merging. If that is going to take time, please merge this one for the security fixes.
Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

cc @kytwb @vantezzen - because of the slew of security fixes, can we get this PR merged quickly please?

tx for the quick turnaround @kytwb !


Hyper not starting after reboot or sleep

If i reboot or put PC to sleep, then wake it up, i can't call Hyper visor with a hotkey, i need to start the app first.

I don't know about Hyper Visor since that's a whole other plugin found here and it is made for Hyperterm which is the v1.x version of the terminal whereas v2.x is just called Hyper.
As for rebooting, that makes sense. Plugins like hyper-overlay and hyperterm-visor rely on hyper having been executed at least once since they are plugins not program.
As for sleeping, I cannot reproduce this. When I put my (Win10) PC to sleep, wake it up again then unlock it Hyper is still there. What version of Hyper are you using? The latest stable is v2.0.0

I remain at not being able to reproduce this. Whenever I wake my PC after extended sleep the Hyper window will still be there and so will the plugin. Likewise if I close Hyper then put it to sleep the overlay will still be in my tray and summoned on hotkey.

Are you using WSL Bash? Or just windows PS/CMD?

I have my Hyper set to Git Bash as shell. here is my config

I'm using WSL Bash. Try it :)

Sorry, no. I'm not going to install WSL and reconfigure my Hyper just for this niche plugin and to debug something. If you want to debug it and resolve the code then by all means do and make a PR but I'm not going to jump through that many hoops for this.

I'm having a similar problem @Favna and I'm also using WSL.
Also I don't think Heihachi88 was trying to make you jump through any hoops, it's just WSL is really powerful and I think they meant the suggestion in good spirits :)

I have no doubts that WSL is very powerful however I remain at what I said before. That said, if you want to debug and potentially resolve it yourself you are totally free to PR it and I'll be sure to accept it.


Reorganize branches

There is a demand for a bugfix release for a long time ago. With the new version upcoming, we have to clear the state of this repository. The development branch is nextrelease for now, but this should be the master branch when we release the library. Since the two branches are quite far from each other, I intend to do the following (as @frederikbosch suggested):

Rename the current master branch to 1.x
Rename nextrelease to master

I really like this idea, however many other libraries are using this one, many of them rely on the master branch. With this change those won't work anymore. Should we care about this scenario? Notify them somehow?
Or just proceed? It is unstable after all, people should not just rely on the master branch.
Once this one is addressed, bugfix release can be tagged and #43, #109 can be closed.

Thinking about it, I have another option to consider. Why not make a new branch: 3.x which pulls from nextrelease. Then make the 3.x branch the default branch on github. This ensures when people arrive on this project's page, they will see how to use Money the new way. My suggestion would be to split #137 and create an issue for only the README.md update. That one should be fixed in order to proceed.
Then we can release 3.0.0. New development should be done in the 3.x branch, where as the master and nextrelease branches will be retained (and locked/closed).
This way we will not break current installation while still being able to move forward.

@sagikazarmark I just created my final set of PRs for 3.0.0. If we solve the negative amount issue in those PRs, I think it should be ready for shipment.

I think leaving master as is can be confusing. Nevertheless being 3.x the default, it's still master's role. So I think we should try to contact authors relying on master.
Relying on master is a bad idea anyway.

@sagikazarmark What is stopping you from merging the 4 open PRs?
Do you have the ability to tag a new version? Or do we need Mathias for that?

Lack of time, sorry. :cry:

Development is happening on master branch now.

:+1: