[CP Staging] Fix crash on task settings

Details

Fix crash on task settings
Fixed Issues

$ https://github.com/Expensify/App/issues/29334
$ https://github.com/Expensify/App/issues/29450
PROPOSAL: https://github.com/Expensify/App/issues/29334#issuecomment-1758044351
Tests

Go to any report.
Create a new task.
Click on task header => Choose Settings.
Verify that app is not crashed.

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests.
QA Steps

Go to any report.
Create a new task.
Click on task header => Choose Settings.
Verify that app is not crashed.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/16502320/b268daf7-7f56-4f04-89a4-d6f7321b2e48

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16502320/f37a610e-8271-4ec0-894e-c86b938c2c41

Mobile Web - Safari

https://github.com/Expensify/App/assets/16502320/d0aaa4a7-e632-4426-93f1-49c6c906b765

Desktop

https://github.com/Expensify/App/assets/16502320/bb04d436-72e9-424d-a5ea-b1b4bd8965f6

iOS
https://github.com/Expensify/App/assets/16502320/5514357e-32d6-40ca-88a5-5d9056cc0fe9

Android

https://github.com/Expensify/App/assets/16502320/f37a610e-8271-4ec0-894e-c86b938c2c41

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[X] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/16493223/85a026d3-ad19-4d22-9883-538864c70b17

Mobile Web - Chrome

https://github.com/Expensify/App/assets/16493223/ee8832ae-3dfa-4e08-97c3-a532abb0339d

Mobile Web - Safari

https://github.com/Expensify/App/assets/16493223/9d997e58-6261-44f7-9285-3fb807673bae

Desktop

https://github.com/Expensify/App/assets/16493223/5ca77285-9089-48b7-ade4-0d57bb09b615

iOS

https://github.com/Expensify/App/assets/16493223/90e0c167-7d6f-4a6f-8c9f-d9ec3da61b2b

Android

https://github.com/Expensify/App/assets/16493223/4be67413-f1dc-4251-ae78-d0d1077d2921

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.83-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform
result

🤖 android 🤖
skipped 🚫

🖥 desktop 🖥
skipped 🚫

🍎 iOS 🍎
skipped 🚫

🕸 web 🕸
skipped 🚫

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.85-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


[C++][Parquet] Implement Parquet to Thrift schema conversion

Implement the conversion of a Parquet schema tree to std::vector<parquet::format::SchemaElement>.
Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
Note: This issue was originally created as PARQUET-583. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Issue resolved by pull request 87
https://github.com/apache/parquet-cpp/pull/87

Uwe Korn / @xhochy:
PR: https://github.com/apache/parquet-cpp/pull/87


[Modules] Added CMK to Net-App module & updated API version

Description

Added suport for CMK
Added support for volumne encryption (default would be 'Single')

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change
Please delete options that are not relevant.

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update to documentation

Moving to draft due to 'Preview Feature' status

@AlexanderSehr ==> added this as a reference issue ==> https://github.com/Azure/ResourceModules/issues/2991


Fix non-ascii encoding problems in the whole generated report

This time an issue has been encountered in a progress ticket subject line.

@OleksandrOrlov

Great!


Katib docker no longer has access to mnist

Bug Description
I'm running the katib-integration tests and it's failing while running the experiment. Looking into the logs I see that the docker container is failing trying to download mnist from  http://data.mxnet.io/data/mnist/train-labels-idx1-ubyte.gz because of 403. I also tried changing the image from "image": "docker.io/kubeflowkatib/mxnet-mnist:v0.14.0" to kubeflowkatib/mxnet-mnist:latest, but it also has 403.
We should rewrite this test to use a different container or dataset
To Reproduce
Run the notebook katib-integration.ipynb
Environment
Kubeflow 1.8
Relevant Log Output
ubuntu@infra-1-medma:~$ kubectl logs cmaes-example-8smpss6l-vdzr4 -n admin -cmetrics-logger-and-collector
I0228 13:30:45.434582      14 main.go:396] Trial Name: cmaes-example-8smpss6l
I0228 13:30:46.900976      14 main.go:139] 2024-02-28T13:30:46Z INFO     start with arguments Namespace(num_classes=10, num_examples=60000, add_stn=False, image_shape='1, 28, 28', network='mlp', num_layers=4, gpus=None, kv_store='device', num_epochs=1, lr=0.04188612100654, lr_factor=0.1, lr_step_epochs='10', initializer='default', optimizer='ftrl', mom=0.9, wd=0.0001, batch_size=64, disp_batches=100, model_prefix=None, save_period=1, monitor=0, load_epoch=None, top_k=0, loss='', test_io=0, dtype='float32', gc_type='none', gc_threshold=0.5, macrobatch_size=0, warmup_epochs=5, warmup_strategy='linear', profile_worker_suffix='', profile_server_suffix='', use_imagenet_data_augmentation=0)
I0228 13:30:46.903526      14 main.go:139] 2024-02-28T13:30:46Z DEBUG    Starting new HTTP connection (1): data.mxnet.io:80
I0228 13:30:46.946262      14 main.go:139] 2024-02-28T13:30:46Z DEBUG    http://data.mxnet.io:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 301 290
I0228 13:30:46.951439      14 main.go:139] 2024-02-28T13:30:46Z DEBUG    Starting new HTTP connection (1): data.mxnet.io.s3-website-us-west-1.amazonaws.com:80
I0228 13:30:47.294289      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    http://data.mxnet.io.s3-website-us-west-1.amazonaws.com:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 403 303
I0228 13:30:47.299424      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    Starting new HTTP connection (1): data.mxnet.io:80
I0228 13:30:47.332742      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    http://data.mxnet.io:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 301 290
I0228 13:30:47.337229      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    Starting new HTTP connection (1): data.mxnet.io.s3-website-us-west-1.amazonaws.com:80
I0228 13:30:47.685118      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    http://data.mxnet.io.s3-website-us-west-1.amazonaws.com:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 403 303
I0228 13:30:47.689962      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    Starting new HTTP connection (1): data.mxnet.io:80
I0228 13:30:47.722428      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    http://data.mxnet.io:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 301 290
I0228 13:30:47.727552      14 main.go:139] 2024-02-28T13:30:47Z DEBUG    Starting new HTTP connection (1): data.mxnet.io.s3-website-us-west-1.amazonaws.com:80
I0228 13:30:48.072144      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    http://data.mxnet.io.s3-website-us-west-1.amazonaws.com:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 403 303
I0228 13:30:48.076939      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    Starting new HTTP connection (1): data.mxnet.io:80
I0228 13:30:48.108880      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    http://data.mxnet.io:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 301 290
I0228 13:30:48.113631      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    Starting new HTTP connection (1): data.mxnet.io.s3-website-us-west-1.amazonaws.com:80
I0228 13:30:48.442373      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    http://data.mxnet.io.s3-website-us-west-1.amazonaws.com:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 403 303
I0228 13:30:48.447381      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    Starting new HTTP connection (1): data.mxnet.io:80
I0228 13:30:48.480701      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    http://data.mxnet.io:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 301 290
I0228 13:30:48.485165      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    Starting new HTTP connection (1): data.mxnet.io.s3-website-us-west-1.amazonaws.com:80
I0228 13:30:48.828342      14 main.go:139] 2024-02-28T13:30:48Z DEBUG    http://data.mxnet.io.s3-website-us-west-1.amazonaws.com:80 "GET /data/mnist/train-labels-idx1-ubyte.gz HTTP/1.1" 403 303
I0228 13:30:48.829544      14 main.go:139] download failed, retrying, 4 attempts left
I0228 13:30:48.829584      14 main.go:139] download failed, retrying, 3 attempts left
I0228 13:30:48.829603      14 main.go:139] download failed, retrying, 2 attempts left
I0228 13:30:48.829612      14 main.go:139] download failed, retrying, 1 attempt left
I0228 13:30:48.829637      14 main.go:139] Traceback (most recent call last):
I0228 13:30:48.829646      14 main.go:139]   File "/opt/mxnet-mnist/mnist.py", line 86, in <module>
I0228 13:30:48.829662      14 main.go:139]     fit.fit(args, sym, get_mnist_iter)
I0228 13:30:48.829670      14 main.go:139]   File "/opt/mxnet-mnist/common/fit.py", line 185, in fit
I0228 13:30:48.830415      14 main.go:139]     (train, val) = data_loader(args, kv)
I0228 13:30:48.830453      14 main.go:139]   File "/opt/mxnet-mnist/mnist.py", line 44, in get_mnist_iter
I0228 13:30:48.830473      14 main.go:139]     mnist = mx.test_utils.get_mnist()
I0228 13:30:48.830482      14 main.go:139]   File "/usr/local/lib/python3.9/site-packages/mxnet/test_utils.py", line 1906, in get_mnist
I0228 13:30:48.832462      14 main.go:139]     (train_lbl, train_img) = read_data(
I0228 13:30:48.832514      14 main.go:139]   File "/usr/local/lib/python3.9/site-packages/mxnet/test_utils.py", line 1894, in read_data
I0228 13:30:48.834964      14 main.go:139]     with gzip.open(mx.test_utils.download(label_url)) as flbl:
I0228 13:30:48.834997      14 main.go:139]   File "/usr/local/lib/python3.9/site-packages/mxnet/test_utils.py", line 1812, in download
I0228 13:30:48.835757      14 main.go:139]     raise e
I0228 13:30:48.835810      14 main.go:139]   File "/usr/local/lib/python3.9/site-packages/mxnet/test_utils.py", line 1803, in download
I0228 13:30:48.836867      14 main.go:139]     assert r.status_code == 200, "failed to open %s" % url
I0228 13:30:48.836889      14 main.go:139] AssertionError: failed to open http://data.mxnet.io/data/mnist/train-labels-idx1-ubyte.gz
F0228 13:30:49.437866      14 main.go:421] Failed to wait for worker container: training container is failed. Unable to read file /var/log/katib/7.pid for pid 7, error: open /var/log/katib/7.pid: no such file or directory

Additional Context
No response

This is an issue in the upstream too https://github.com/kubeflow/katib/issues/2261.We should follow how it's resolved since maybe we could follow that for this UAT too.

Wait, its a bit more nuanced.  They removed the test we were using, but updated the example we were using to use a different test.  So we can just follow their changes here as well.


Makefile is not working with latest go 1.18.1

It fails with the following message:
build/env.sh go get -v ./...
go: go.mod file not found in current directory or any parent directory.
	'go get' is no longer supported outside a module.
	To build and install a command, use 'go install' with a version,
	like 'go install example.com/cmd@latest'
	For more information, see https://golang.org/doc/go-get-install-deprecation
	or run 'go help get' or 'go help install'.
make: *** [Makefile:6: all] Error 1

asia2.ethermine.org

The same here...
pi@rpi:~/stratum-ping $ go version
go version go1.19.8 linux/arm64

pi@rpi:~/stratum-ping $ make
build/env.sh go get -v ./...
go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.
make: *** [Makefile:6: all] Error 1

updated


Please provide an architectural diagram to clarify the setup of Azure components

Please provide an architectural diagram to clarify the setup of Azure components.
Is there a recommended file size for this to perform as good as possible?
Which file format is recommended for best performance if the data will be updated and transformed using Databricks?
It also would be amazing if you could share a working example on github.
Is it possible to use this with Delta?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73240074-0a45-666d-bc8b-0c9a469f6f6e
Version Independent ID: 558c36c5-30f7-69c8-a7d3-ed2e29ffd08d
Content: Optimized Azure Blob Storage File Source with Azure Queue Storage - Azure Databricks
Content Source: databricks/spark/latest/structured-streaming/aqs.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@isamllr  Thanks for the feedback! I have assigned the issue to the content author to review further and update the document as appropriate.

Thanks for you feedback @isamllr. I have added this doc update to our backlog, but I do not have a timeline for when it will be complete. I will try to respond here once the doc has been updated.
#please-close


Why are the  contents of /bin /sbin /usr/bin /usr/sbin the same?

The commands in these folders are the same.
This should not be the case under normal circumstances.

It is an Arch Linux specification.
Please read this:
https://wiki.archlinux.org/index.php/Frequently_asked_questions#Does_Arch_follow_the_Linux_Foundation

It is an Arch Linux specification.
Please read this:
https://wiki.archlinux.org/index.php/Frequently_asked_questions#Does_Arch_follow_the_Linux_Foundation's_Filesystem_Hierarchy_Standard_(FHS)%3F

Thank you!


Map Geocoding Errors

The Geocoding on the Map seems to be wrong
Locations shown in bangalore, USA and many other places
Your environment
using on the map
Steps to reproduce

Expected behaviour
Tell us what and how exactly is it supposed to  happen
Actual behaviour
Tell us what happens instead or what went wrong
Can fix using google geocoding with district specifc hints

duplicate of  #125 #225 #232 #248 #249 #252


Allow pinning of infrastructure package versions

In order to assist with providing a supportable and predictable infrastructure, it would be useful to be able to pin infrastructure (eg: mariadb, rabbitmq, lxc, libvirt, elasticsearch, logstash) packages to specific versions.

This is status dev-done; can we close it?
Did this come from somewhere else?

@b3rnard0 any idea if we can close this?

@d34dh0r53 This was from the old board so go ahead and close it.


Properly copies the FrameworkValidation scripts into the distribution.

This pull request introduces 5 alerts - view on lgtm.com
new alerts:

1 for Import of deprecated module
1 for Suspicious unused loop iteration variable
1 for Variable defined multiple times
1 for Wrong number of arguments in a call
1 for Potentially uninitialized local variable

Comment posted by lgtm.com

Mitigated.


Isis 1976 rethink object adapters

Key changes so far ...
Interface AdapterManger which allowed read/write access to the ObjectAdapter - cache/map is now gone.
This is replaced by new interface ObjectAdapterProvider, which does not expose the (if any) ObjectAdapter - cache/map.
This affects a lot of facet classes within the metamodel.

Also just discovered a StackOverFlow in the context of the RecreatableObjectFacet, which of course needs fixing:
Call-Cycle
o.a.i.c.runtime.system.persistence.PersistenceSession5.newIdentifier(PersistenceSession5.java:1222)
o.a.i.c.runtime.system.persistence.PersistenceSession5.createTransientOrViewModelOid(PersistenceSession5.java:1194)
o.a.i.c.runtime.system.persistence.adaptermanager.ObjectAdapterContext_ObjectAdapterProvider.adapterFor(ObjectAdapterContext_ObjectAdapterProvider.java:77)
o.a.i.c.metamodel.adapter.ObjectAdapterProvider$Delegating.adapterFor(ObjectAdapterProvider.java:71)
o.a.i.c.metamodel.adapter.ObjectAdapterProvider$Delegating.adapterFor(ObjectAdapterProvider.java:71)
o.a.i.c.metamodel.facets.object.recreatable.RecreatableObjectFacetDeclarativeInitializingAbstract.memento(RecreatableObjectFacetDeclarativeInitializingAbstract.java:115)

o.a.i.c.runtime.system.persistence.PersistenceSession5.newIdentifier(PersistenceSession5.java:1222)
o.a.i.c.runtime.system.persistence.PersistenceSession5.createTransientOrViewModelOid(PersistenceSession5.java:1194)
o.a.i.c.runtime.system.persistence.adaptermanager.ObjectAdapterContext_ObjectAdapterProvider.adapterFor(ObjectAdapterContext_ObjectAdapterProvider.java:77)
o.a.i.c.metamodel.adapter.ObjectAdapterProvider$Delegating.adapterFor(ObjectAdapterProvider.java:71)
o.a.i.c.metamodel.adapter.ObjectAdapterProvider$Delegating.adapterFor(ObjectAdapterProvider.java:71)
o.a.i.c.metamodel.facets.object.recreatable.RecreatableObjectFacetDeclarativeInitializingAbstract.memento(RecreatableObjectFacetDeclarativeInitializingAbstract.java:115)

I think this PR is fine to merge.
To me it seems that mostly this is just moving functionality about ... the OidAdapterMap and PojoAdapterMap are still present, but relocated to ObjectAdapterContext.
The most significant change is that ObjectAdapter#rootOid is now final, and so the replacePojo stuff has gone, instead the ObjectAdapter is copied if the rootOid changes.  This seems ok to me - or at least will be once we get to the stage where ObjectAdapters are instantiated as required and then discarded immediately afterwards.
The ObjectAdapterProvider#specificationForViewModel(...) - which returns an ObjectAdapter - looks a bit odd; I've created a separate comment for that.  I suspect this is work in progress so happy to see how it plays out, but this code does look weird at the moment.


v3.1.1

Coverage decreased (-0.0002%) to 99.359% when pulling 3e748b9ce8906f3870870fa9c0fc71bee6672738 on release-candidate into 13002bb4584f16b62427b771bd3e107b6f7b1109 on v3.


added kandi resources link

It contains a curated list of awesome iOS ecosystem

Project URL
Awesome-ios
Category
resources
Description
curated list of awesome iOS ecosystem
Why it should be included to awesome-ios (mandatory)
Checklist

[x ] Has 50 GitHub stargazers or more
[x ] Only one project/change is in this pull request
[x ] Isn't an archived project
[ x] Has more than one contributor
[x ] Has unit tests, integration tests or UI tests
[x ] Addition in chronological order (bottom of category)
[x ] Supports iOS 9 / tvOS 10 or later
[ x] Supports Swift 4 or later
[ x] Has a commit from less than 2 years ago
[ x] Has a clear README in English

@absterjr
Thanks for contributing!


[SPARK-33815][SQL] Migrate ALTER TABLE ... SET [SERDE|SERDEPROPERTIES] to use UnresolvedTable to resolve the identifier

What changes were proposed in this pull request?

This PR proposes to migrate ALTER TABLE ... SET [SERDE|SERDEPROPERTIES to use UnresolvedTable to resolve the table identifier. This allows consistent resolution rules (temp view first, etc.) to be applied for both v1/v2 commands. More info about the consistent resolution rule proposal can be found in JIRA or proposal doc.
Note that ALTER TABLE ... SET [SERDE|SERDEPROPERTIES] is not supported for v2 tables.
Why are the changes needed?

The PR makes the resolution consistent behavior consistent. For example,
sql("CREATE DATABASE test")
sql("CREATE TABLE spark_catalog.test.t (id bigint, val string) USING csv PARTITIONED BY (id)")
sql("CREATE TEMPORARY VIEW t AS SELECT 2")
sql("USE spark_catalog.test")
sql("ALTER TABLE t SET SERDE 'serdename'") // works fine

, but after this PR:
sql("ALTER TABLE t SET SERDE 'serdename'")
org.apache.spark.sql.AnalysisException: t is a temp view. 'ALTER TABLE ... SET [SERDE|SERDEPROPERTIES\' expects a table; line 1 pos 0

, which is the consistent behavior with other commands.
Does this PR introduce any user-facing change?

After this PR, t in the above example is resolved to a temp view first instead of spark_catalog.test.t.
How was this patch tested?

Updated existing tests.

Test build #132911 has started for PR 30813 at commit b59a7d7.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37513/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37513/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37513/

cc @cloud-fan

thanks, merging to master!

Test build #132911 has finished for PR 30813 at commit b59a7d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132911/


skips in .bandit file are ignored

Bandit version
bandit 1.7.0
  python version = 3.6.9 (default, Jan 26 2021, 15:33:00) [GCC 8.4.0]

.bandit file
[bandit]
exclude: /venv
skips: B602,B603,B605,B607,B404,B101,B314,B405,B410

But I am still seeing B404 and all other issues:
ubuntu@/home/user/bandit_test$ bandit -r src -c
>> Issue: [B404:blacklist] Consider possible security implications associated with subprocess module.
   Severity: Low   Confidence: High
   Location: src/utils/model.py:7
   More Info: https://bandit.readthedocs.io/en/latest/blacklists/blacklist_imports.html#b404-import-subprocess
6       import pathlib
7       import subprocess
8
9

Any idea why skips are completely ignored?

Any update here?

I have found the reason.
.bandit file should be located in src directory.


@OnProgressChanged listener binding?

Hi, is there any way to leverage Butterknife for a SeekBar?
I am looking for an @OnProgressChanged listener annotation and don't see one in the API.
Thanks!

Dupe of #441.


Deprecation Policy

It looks like rgd_client.rgdc.RasterDownload was removed and after about 45 minutes of investigation I figured out it now lives in a different module: rgd_imagery_client.
While reorganization like this is probably for the best, it would help end-users like myself if there was some sort of deprecation warning when something like this occurred in the future. It would be fine if this worked in Python 3.7+ only, because they you could just define a module level __getattr__.
It could be as simple as

def __getattr__(key):
    if key == 'RasterDownload':
        raise Exception('RasterDownload was moved to rgd_imagery_client.RasterDownload, please use that instead')

Of course, an even nicer solution might do something like

def __getattr__(key):
    if key == 'RasterDownload':
        import warnings
        warnings.warn('RasterDownload has moved to rgd_imagery_client.RasterDownload, please use that instead. This warning willl become an error in version X.Y.Z', DeprecationWarning)
        from rgd_imagery_client import RasterDownload
        return RasterDownload
    else:
        raise AttributeError

where it warns the user that deprecation is about to happen, but it still functions for a few more versions.
Something along these lines would help smoothly transition between versions.

Hey @Erotemic, I understand your frustration with the rapidly changing API and lack of deprecation warnings. Unfortunately, we are moving rapidly and we are just now getting to a point where we can call the API "stable" -- a cost of this rapid movement is a lack of deprecation warnings when things change.
Moving forward, we will include deprecation warnings in the Python client as we are now reaching a point of "stability".
To mitigate this in the future, let's implement some tests specific to your workflow and specific to how RGD is being used in WATCH so that we catch these issues upstream before you see them.
Further, please reach out directly to me or @AlmightyYakob next time you run into an issue with the Python client since you/WATCH are our primary users.

Moving forward, we will work to include deprecation errors. That's the new policy, thanks for bringing this up.
@AlmightyYakob, please keep this in mind moving forward


os: Rename does not overwrite existing files on Plan 9

TestRenameOverwriteDest should not need an exception for Plan 9.

/cc @0intro

This restriction is not the only difference between Plan 9 and other
operating systems in the os.Rename function.
For example, on Plan 9 you can only rename a file located
in the same directory.
Should we change os.Rename to handle both of these cases like other operating systems?
Renaming a file to a different directory could be done by copying the
file and removing the source file. However, if the source file is a directory,
the situation would be a bit more complex.

Everyone expects that there are limitations on when you can rename across
directories. Even Unix doesn't let you do that if directories are on
different file systems. But people do expect rename in a single directory
to work. I clarified in the docs.


logbook and history tabs are empty.

Home Assistant release (hass --version):
0.63
0.63.1
0.63.2
Python release (python3 --version):
3.5.3
Component/platform:
recorder, logbook
Description of problem:
after update to 0.63.x the recorder and logbook are no longer updated, and the historic data is not available i either the logbook or the history tab.
Each time I access logbook or history traceback below is added to the logfile.
when I downgrade to 0.62.1 data i recorded again and the historic data is available again, the scenario is the same for each of the 0.63.x versions.
Problem-relevant configuration.yaml entries and steps to reproduce:
  exclude:
    entities:
      - sensor.time
recorder:
  purge_interval: 2
  purge_keep_days: 31
  db_url: mysql://_!secret_:_!secret_@<IP_ADDRESS>:3307/hass?charset=utf8

###  History  ###
history:
  exclude:
    domains:
    - automation
    - media_player
    - scene
    - group
    - script
    - updater
    entities:
    - sun.sun   # Don't record sun data
    - sensor.last_boot
    - sensor.date

Traceback (if applicable):
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web_protocol.py", line 416, in start
    resp = yield from self._request_handler(request)
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web.py", line 302, in _handle
    match_info = yield from self._router.resolve(request)
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web_urldispatcher.py", line 831, in resolve
    match_dict, allowed = yield from resource.resolve(request)
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web_urldispatcher.py", line 314, in resolve
    match_dict = self._match(request.rel_url.raw_path)
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web_urldispatcher.py", line 432, in _match
    match.groupdict().items()}
  File "/usr/local/lib/python3.5/dist-packages/aiohttp/web_urldispatcher.py", line 431, in <dictcomp>
    for key, value in
TypeError: build() got an unexpected keyword argument 'encoded'

Additional info:
Home-assistant is running on af fully updated Raspberry Pi 3
Database is MariaDB 10 on a synology nas

It seems like you don't have the correct version of yarl installed. The currently required (and automatically installed) version of yarl has an encoded attribute, whereas older versions do not → this might be the error.

Please post the output of pip3 freeze | grep yarl
How did you install Home Assistant? The correct version of yarl should have been installed automatically...

"yarl=0.12.0"
is it installed manually using pip3 install ... the installation is about 2 years old

The setup file actually requires yarl==1.1.0 (hass doesn't work with yarl==0.12.0 anymore) and pip should automatically install that version for you.
https://github.com/home-assistant/home-assistant/blob/1f041d54d9db4100831df2053a244db27cdb3d25/setup.py#L59
It seems as though somehow during your Home Assistant updates, the yarl package was never updated. How do you update Home Assistant?  If you use pip3 install -U homeassistant, it should install the correct dependency versions.

I use sudo pip3 install -U homeassistant. btw "sudo pip3 freeze | grep yarl" results in yarl=1.1.0

Same error here, no graph displayed neither and 1 error pops at every web connection.
Tried multiple successfull pip reinstallations without cache => no progress.
Bumping to aiohttp==3.0.1 => brings even more errors.
My setup: raspbian on Pi3 with localhost mysql/mariadb, pip3 install homeassistant installation mode.

@hsk-dk Ok, I think now I know. To explain: for pip, the user who installs a package matters. If you run sudo pip3 install -U homeassistant, pip will happily install all dependencies globally (for all users). The root user therefore has yarl==1.1.0 installed.
However, your pi user has has yarl installed, this time with version 0.12.0. This causes the global version to be overridden by the local version. So if you then start Home Assistant, it will use the global homeassistant==0.62.x, but the locally-overridden yarl==1.1.0, therefore causing an error.
This is a configuration issue, but to solve it either:

Remove all pip packages from the pi user: https://stackoverflow.com/a/11250821/8924614
Install home assistant locally for the pi user: pip3 install -U homeassistant (without sudo; this can potentially fail depending on your setup)
Run home assistant with the root user: sudo hass (⚠ dangerous -> security threat)

@jinjeul That's because aiohttp==3.0.1 isn't supported by Home Assistant just yet. In general, you have to have the correct dependency versions installed in order to expect Home Assistant to work properly.
(Side note: I notice lots of RPi users use sudo liberally; root/sudo is dangerous if used incorrectly and can cause all sorts of problems down the line; I personally either exclusively use root or exclusively use the local user)

I was unable to uninstall the packages from the pi user (permission error) but
"sudo pip3 install --upgrade homeassistant--ignore-installed" fixed the issue

I'm having a very similar problem. Key differences:

Python 3.6.4
Run on MacOS
Do not run HASS as sudo ... run HASS as a normal user via launchctl.
command pip3 freeze lists the correct requirements Yarl (1.1.0) and aiohttp (2.3.10)
I tried to uninstall and reinstall home assistant
I tried to seperately uninstall yarn and aiohttp / reinstalled with --verbose option which did not indicate any error or permission related issues.

Would be grateful for any help

I have done as such but openzwave was also updated to a new version as part of 0.63 so I have had to change the openzwave requirements in 0.62.1 as well to keep it all working....
Does anyone have a more long term fix? Or anything else I should be investigating

i’m having the same problem and (exactly) the same setup as @ajghb.
after installing 0.63.3, reloading a page other than /states results in a error 500 and this log entry.
[31m2018-02-18 15:46:21 ERROR (MainThread) [aiohttp.server] Error handling request[0m
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 416, in start
    resp = yield from self._request_handler(request)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web.py", line 302, in _handle
    match_info = yield from self._router.resolve(request)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py", line 831, in resolve
    match_dict, allowed = yield from resource.resolve(request)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py", line 314, in resolve
    match_dict = self._match(request.rel_url.raw_path)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py", line 432, in _match
    match.groupdict().items()}
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/aiohttp/web_urldispatcher.py", line 431, in <dictcomp>
    for key, value in
TypeError: build() got an unexpected keyword argument 'encoded'[0m

I also reverted to 0.62.1 and that fixed the issue (also allowed homebridge to function again - not sure if related - but probably, because it was reporting a 500 error).

I have yarl v.1.1.0 on both root and my user. However, I still get an error in history and logbook. Reverting back to 0.62.1 fixed it. I noticed all the log information was still being saved although i couldn't view it in .2 or .3.

OK, the only fix I found, to use 0.63.3, is to delete the deps folder and have it rebuild itself. I feel like I may have made an edit awhile ago to fix another issue in there, and rebuilding it seems to have fixed the issue.
I copied the folder just in case ;)

moving the deps folder out of the .homeassistant folder and letting it rebuild itself helped make 0.63.3 run smoothly for me. on yosemite HA couldn’t install the dependencies for the tradfri and broadlink dependencies. i had to move them into the new deps folder from the old, which fixed that. other than than, it runs smoothly now, thanks @joshuapack.
seems the problem really might be a problem with removing old dependencies, when new ones are installed?

@diplix how did you let it rebuild itself? I moved it elsewhere and did the pip install command and now hass isn't starting back up correctly


Allow use "all" as string for server filtering

Hi!
Sorry I called it a bug but I do not know if it was a feature.
Using capistrano I ran into a extrange behaviour, defined roles can be user as symbol or string for filtering, but special role all only could be specified as symbol
See relevant pry session at https://gist.github.com/theist/9ebf13d8aaee8a7ec01e
So wrote a test to match the behaviour I wanted and modify the Filter class code to pass it

I believe that was actually by design, but it does rather look like it was confusing. Could you cleanup your commits based on the CONTRIBUTING guidelines (I see you touched the changelog) but nice commit messages are important, maybe rebase them into one commit, and include the contents of the gist in the commit message body, and use "Allow use "all" as string in additional to a symbol for server filtering"

Sorry, I've checked your contibuting gidelines but seems I didn't understood them completly.
I've rebased my branch (or, at least I hope I did it, if I did not, blame the google god)

Sorry, I've checked your contibuting gidelines but seems I didn't understood them completly.

It's alright, it's more like a book!

I've rebased my branch (or, at least I hope I did it, if I did not, blame the google god)

Rebase looks good, it's scary the first few times you use it.  Git garbage collects" itself every ~30 days or something, but in that window, you can usually always recover from a rebase implosion!


Add tests for handling override keyword

This adds some failing tests for functions that use the override keyword. See the expected value for the proposed structure of the AST for this nodes.

Added the missing test mentioned by @nicholaspai and also implemented the functionality.
@GNSPS could you take a look?

@GNSPS friendly ping


Invisible Facades with transparent blocks

EnderIO 1.7.10-<IP_ADDRESS>5-beta
Forge <IP_ADDRESS>2
So, when I try to use transparent blocks, they appear to be invisible:
http://i.imgur.com/hLR988B.png
http://i.imgur.com/SZNAVHT.png
I'd assume this is a bug, since it works in the "old" EnderIO versions 2.2.x.

What do you expect it to be?

uh... I expect there to be some sort of texture.
I gave the facade the same texture as the glass block which you can see in the WAILA tooltip and placed the facade on that conduit I point at.

@XFactHD see #2737 for how it should look.
BTW: @SanAndreasP Did you try with vanilla glass, too?

yes
http://i.imgur.com/UooXPf0.png

Sorry to ask for another test, but I didn't notice your texture pack earlier: Could you try without it, just to see if it renders then? Thanks!

There you go:
http://i.imgur.com/qUkpF8p.png
I've removed Fastcraft and FPSPlus as well and still not showing up.
(btw, the texture pack is CoterieCraft)

@HenryLoenwind thanks for pointing that out to me, I thought that a facade painted with glass would make the whole block invisible.

Likely caused by #2812


Renders resource even when error. Fix search related reducers so that…

… trigger renders due to state change.
refs #1730

This addresses 2 problems related to #1730:

After creating a resource from a resource template and returning to the resource template page, resource template search wasn't working.
User request to not "lose" an entire resource when there was an error from a nested resource template.

Also, fixed an html id that was set on a table that could have multiple instances (so the id was not unique).


Verification System

Proposal:
Proposal written by Milchreis#8855
What is the title of your proposal?: Verification System
Is it a suggestion for the website or for the bot?: Bot
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): You make a msg Like:
If you click this reaction you'll get the Role 'verified'
{Reaction} :white_check_mark:
Why we should add this feature?: because it can show Server owners who is an active user
ReportID: 32

➤ LenoxBot commented:
Approve:
Agree with Dadi
Nickkel#6515

➤ LenoxBot commented:
Approve:
i think this is a good feature for the bot
Dadi#7808

➤ LenoxBot commented:
Approve:
I agree with the two Boys
Denarioyt#3352


coverage test

Codecov Report

Merging #3 into master will increase coverage by 1.06%.
The diff coverage is 5.97%.

@@             Coverage Diff             @@
##             master      #3      +/-   ##
===========================================
+ Coverage      3.77%   4.83%   +1.06%
- Complexity       37      74      +37
===========================================
  Files           130     189      +59
  Lines          3735    6057    +2322
  Branches        353     623     +270
===========================================
+ Hits            141     293     +152
- Misses         3583    5739    +2156
- Partials         11      25      +14


All previous releases and tags are gone

I was considering updating Windows Terminal from the 2201 package to 2209, but the lack of tags and releases makes that somewhat impossible. Was this intentional? Can it be fixed?

I'm not familiar with that package naming scheme. How are you consuming WIL?

Sorry, I was using a (not agreed-upon in advance) shorthand. I was referring to 1.0.220201.1 and 1.0.220914.1 by their embedded year and month.

I assume that's the nuget package? What's the issue here?

Yes, the NuGet package. I'm reporting that there are no tags on this repository, nor releases on the releases page, for historical releases.

This leaves consumers no point of reference for an older release such as a commit ID that can be mapped to a version, for example to audit the changes between that version and another newer version.
Contrast cppwinrt, cpprestsdk, etc:

cppwinrt
--
The presence and veracity of tags pointing to earlier versions is important for a maintainable SBOM, especially among people who are not consuming WIL via a package manager. I must have misremembered that they used to exist on this repository! :smile:

WIL has no "official" releases. It's more of a "live at head" philosophy (though the periodic nuget releases muddy that a bit). Prior to the most recent nuget package, no releases/tags have been created. We did start this recently (the one release you pointed to), which does contain the commit used. This is still mostly a lie as it only accounts for nuget.

Ah, that makes sense. Thanks! 🙂


Add NPEP for new CIDRGroup object peer

This NPEP captures the use cases for having a better CIDRGrouper for easier management of CIDR peers in addition to inline CIDR peers
Closes #182

@joestringer and @networkop PTAL, I have tried to include the uses cases you had proposed to see if we can also have this way of expressing CIDR peers.

/remove-lifecycle stale

/reopen

/remove-lifecycle rotten


tests: mem_protect: Add description and doxygen groups

Add descriptions and doxygen groups for app_memory,
stack_protection, stack_randomization and
obj_validation test cases.
Signed-off-by: Spoorthi K<EMAIL_ADDRESS>

Codecov Report

Merging #9182 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9182   +/-   ##
=======================================
  Coverage   52.72%   52.72%
=======================================
  Files         201      201
  Lines       25277    25277
  Branches     5279     5279
=======================================
  Hits        13328    13328
  Misses       9823     9823
  Partials     2126     2126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e828b...5cf8690. Read the comment docs.


BeanConfig classes() now shouldn't return classes outside specified l…

…ist of packages (https://github.com/swagger-api/swagger-core/issues/2127).

Maybe. The issue is #2127. How do I "add" the issue... except from linking to it as above?
Yes. I can make a test case that will break without the fix.

@KeldOelykke do you have a test that we can add to this PR?

@fehguy Yes. I have added a new test resource 'org.myles' and a new test case in BeanConfigTest that tests that 'org.my' now doesn't include 'org.myles'. Without the fix that wouldn't be possible. Cheers!


port: [#4530] Add support for meeting participants added/removed events

Fixes #4530
Description
This PR ports the changes in PR#6677 to add support for the new meeting participants join/leave events.
Specific Changes

Added support for 2 new activity types - application/vnd.microsoft.meetingParticipantJoin and application/vnd.microsoft.meetingParticipantLeave.
Added functions to register handlers for when teams meeting participants are joined/left.
Added unit tests for every case.

Testing
This image shows the implementation tested with a sample.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 1 file are covered.
82 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.4%) to 84.508%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

libraries/botframework-streaming/src/utilities/createNodeServer.ts
1
78.57%

libraries/botframework-streaming/src/namedPipe/namedPipeServer.ts
12
50.68%

libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts
17
34.09%

libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts
51
3.92%

Totals

Change from base Build<PHONE_NUMBER>:
-0.4%

Covered Lines:
20095

Relevant Lines:
22528

💛  - Coveralls


Support for Django 1.7 migrations

Will fix #339

Thank you for fixing this @ionelmc  :+1:
Now if someone could, please, release this as soon as possible so I don't have to install from a git branch...
Thanks!

+1 on releasing this. Very much appreciated.

Odd, I've pushed them to master but this wasn't closed automatically


Mute subscriber that tries to write to closed output

Request details

Probably caused by: https://github.com/dzikoysk/reposilite/blob/main/reposilite-backend/src/main/kotlin/com/reposilite/console/infrastructure/ConsoleWebSocketHandler.kt#L69

@dzikoysk I would like to do this.. but don't know how to solve this... please guide

I think that simple try-catch around ctx.send() for ClosedChannelException could be enough, this error is pretty random and it's hard to reproduce it, we will just observe the result :)

I think that simple try-catch around ctx.send() for ClosedChannelException could be enough, this error is pretty random and it's hard to reproduce it, so we will just observe the result :)

Maybe I could not do it.. you better to assign someone else.. sorry to bother 😢

Can I be assigned I think I could solve it

What should be done when the exception is caught?

I think we can safely mute it by just logging it at DEBUG level? 🤔


Auto index ABIs

What is needed?
ABIs are added manually to the database, we would like them to be indexed from Etherscan/Sourcify.

For which networks will this work? Mainnet and Rinkeby? How about xdai?
Are the ABIs shared across networks?

Currently every network is supported via Sourcify. Etherscan supports Mainnet, Rinkeby and Binance and Blockscout supports Xdai, Matic, Mumbai, EWC and Volta.
More networks should be very easy to add as long as there's an etherscan or blockscout running instance, but must be added manually.
Abi sharing across networks is a more complex thing and will be addressed in #277

* Etherscan supports Mainnet, Rinkeby and Binance

Etherscan also supports Polygon (https://polygonscan.com/). Did you add it already or do you want me to create a separate issue for this?

* Etherscan supports Mainnet, Rinkeby and Binance

Etherscan also supports Polygon (https://polygonscan.com/). Did you add it already or do you want me to create a separate issue for this?

I was not aware of it, I just added it and test it


There is an extra step "Initial throughout capacity" when creating a collection for an attached "Serverless" SQL account

OS: Win10
Build Version: 20221101.1
Regression: Not a regression
Repro steps:

Create a SQL account with Serverless capacity model.
Attach it.
Right click the attached SQL account -> Create Database... -> Enter a name -> Enter an id for the collection -> Enter a partition key.
Check whether there is no extra step.

Expect:
There is no extra step.
Actual:

There is an extra step "Initial throughout capacity".

Fail to create a collection.

Details in Output:

8:46:22 AM: Error: Setting offer throughput or autopilot on container is not supported for serverless accounts.
ActivityId: 1e7e6a91-9ca0-4fc1-bc09-e45f673c7a93, Microsoft.Azure.Documents.Common/2.14.0

More Info:
Before attaching, there is no extra step "Initial throughout capacity" when creating a collection.

This seems related to how we handle "attached" accounts specifically.


Enable k3s automatic updates

Setup converge to do initial install of k3s and then switch over to unattended upgrades using the upgrade operator to prevent fighting over control over k3s version.
Things to consider:

Role still controls systems unit configuration
If the systemd unit changes the service needs to restart
The change detection should be reliable
The TLS SAN inclusion of privacy IPV6 address likely causes the unit to change every time, may need to use hostnames only for additional SANs

longhorn manager drain settings will need to be adjusted to allow this.


Update default config location

Partitions labels needs to be specified since https://github.com/rancher-sandbox/cOS-toolkit/pull/894

Build passes, merging


Automated tests for KFP Plugin

Python script that runs the KFP plugin on a set (of currently just 2) Metaflow files
Checks for both compile time and run time issues -> waits for a running pipeline to fully complete before reporting it was successful

@talebzeghmi I have a bunch of tests for the foreach case, but I left them out of this PR because foreach hasn't been implemented yet. Shall I add those tests in this PR, or separately once foreach has been implemented?

@alexlatchford @cloudw I've used Ray (https://github.com/ray-project/ray) to parallelize these tests because we wait a long time for the KFP runs to complete - an opportune situation to parallelize.

Closing as this is subsumed in (https://github.com/zillow/metaflow/pull/28).


Label not defined

Hello,
I face following error:
ReferenceError: label is not defined
at getFilteredShoppingProducts (Code:112:13)
at main (Code:70:7)
It seems to me based on the error, that there is no label for ramped up products. But it is there by dafult.
Could you please check or help me with troubleshooting?
Thank you

Hi @robkecz,
I wonder if you copied and pasted low_volume_skus.js or if you modified the file.
If you modified the file it would be easier to help you, if you shared your version of the script.
Regards

Hello Peter,
thank you for you reply. It should be copy/paste, but with a modification of custom label to 2 from 4. I could have made typo, but after checking I haven't found it. Here is the script.
Thanks for checking!
Robert
CZ.txt


Invoke error on template building

Hi there @Yajo .
First of all, I want to thank Tecnativa for this awesome job.
I'm using:

Ubuntu 18.04 Bionic Beaver (clean install)
git 2.27.0
invoke 0.11.1
copier 3.2.0
pre-commit 2.5.1

After installing all required packages, run copier copy gh:... and answer all required questions I get the following error.
I couldn't dig deeper as I'm new to this tools:
 > Running task 1 of 1: invoke develop
'develop' did not receive all required positional arguments!
Something went wrong. Removing destination folder.
Traceback (most recent call last):
  File "/home/lsoto/.local/bin/copier", line 8, in <module>
    sys.exit(CopierApp.run())
  File "/home/lsoto/.local/lib/python3.6/site-packages/plumbum/cli/application.py", line 577, in run
    inst, retcode = subapp.run(argv, exit=False)
  File "/home/lsoto/.local/lib/python3.6/site-packages/plumbum/cli/application.py", line 572, in run
    retcode = inst.main(*tailargs)
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/cli.py", line 17, in _wrapper
    return method(*args, **kwargs)
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/cli.py", line 158, in main
    self.parent._copy(template_src, destination_path)
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/cli.py", line 121, in _copy
    **kwargs,
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/main.py", line 142, in copy
    copy_local(conf=conf)
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/main.py", line 196, in copy_local
    conf, render, [{"task": t, "extra_env": {"STAGE": "task"}} for t in conf.tasks]
  File "/home/lsoto/.local/lib/python3.6/site-packages/copier/main.py", line 369, in run_tasks
    subprocess.run(task_cmd, shell=use_shell, check=True, env=local.env)
  File "/usr/lib/python3.6/subprocess.py", line 438, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command 'invoke develop' returned non-zero exit status 1.

Any hint?
Thank you in advance.
P.D.: I couldn't install required packages with pipx as it seems there are some dependencies incompatibilities with virtualenv, so I went straight with pip.

Your invoke is too old, please install with pipx.


More features

Added more features in PeekPokeTester including:

Add a flag(--noUpdate) not to propagate the output values of sequential logics
Add a flag(--logFile) and a parameter to dump the tester logs to a file instead of the screen
Add a flag(--waveform) and a parameter to change the waveform file name

Included in #14


[Doc] Add official instruction and examples of brokerload from Azure blobstore to Starrocks doc

Enhancement
It seems that broker load from Azure blobstore is supported in 3.0?
Can we add the document for Azure blobstore as with other blobstores
https://docs.starrocks.io/en-us/3.0/sql-reference/sql-statements/data-manipulation/BROKER LOAD

FYI, here is what I learned from @Smith-Cruise about this load sql
https://github.com/StarRocks/starrocks/issues/18342#issuecomment-1496874460

I will push it

This has been done long ago. See https://docs.starrocks.io/en-us/latest/sql-reference/sql-statements/data-manipulation/BROKER_LOAD#microsoft-azure-storage & https://docs.starrocks.io/en-us/latest/loading/cloud_storage_load#load-data-from-microsoft-azure-storage


get_mysonos and play_mysonos access to all of My Sonos favourite's

More of a feature request than an issue but it'd be great if get_mysonos and play_mysonos could access all of My Sonos favourite's rather than just TuneIn stations.
Specifically, I have a local Icecast server which streams audio and I have added it to My Sonos favourite's via Manage > Add Radio Station in the Windows Sonos Controller App. The stations is shown as though it is a TuneIn station within the Windows Controller once it is added but obviously isn't actually coming from TuneIn as it is local to my LAN only. I'd love to be able to access the station via the get_mysonos and play_mysonos command but it isn't currently returned as part of the array.
Also, I have playlists and individual songs from Spotify, Google Music, Mixcloud etc included in My Sonos favourites that do not get returned as part of the get_mysonos command. Having them included would be appreciated too.

After a bit of playing around I've managed to work out how to combine the flush_queue , insert_uri and activate_queue against the manage queue node, instead of manage radio, to get all of the above working.
It would be nice to have the custom stations visible via get_mysonos in manage radio if possible as it was my initial expectation that would be where to find it but I've worked out an alternative.

Great that you found a work around. The SONOS queue system is very flexible!
I restricted the My Sonos items to those, where I know how to handle them. Currently, the Amazon Prime and TuneIn radio stations are implemented and the default playlists. Amazon Prime playlist is in work.  Spotify is different and will come later.
Let's start with Icecast. Can you send me an example of uri? That one what works with insert_uri.  With the next update, I will provide the possibility to get a list of all My Sonos items. If there is a way to identify the Icecast radio station in the list I can add it to the code and launch the uri (if in the list) .

I now added the "get_mysonosall" to the radio node. If you like you can send me the output and tell me, what radio stations come for icecast. In that output hopefully there is also the URI. You can try to play that with a hidden command in the "control player" node. It is named "set_avtransport" and accepts as topic an uri.

Thanks. I'm not at home this week so can't test it properly for a little while.
I'll have a play around with the new commands once I get the chance but once I worked out that it's relatively straightforward to add individual songs and playlists from both Google Music and Spotify to Sonos playlists which can then in turn be added to the queue using insert_uri I've managed to do what I wanted. It may just be worth explaining this a little more explicitly in the documentation as it passed me by initially.

Could you please send a description of your "workarounds" - especially for Google Music and Spotify. I would like to add that to the Wiki. It could help others.

It's not ideal but as I only want a limited number of.playlists and single tracks available for automation.purposes, from the Sonos app I went into the Spotify/Google Music sections and found the particular playlists or tracks I wanted to use for automating. Push the three dots button to the right of the relevant playlist/track and (you may have to choose 'more' first, I can't remember) you have the option to add/creates a Sonos playlist. This adds the content of the Spotify/Google selection to a Sonos playlist (but I doubt it updates it dynamically if/when updated in Spotify/Google). Then the standard play_mysonos call can be used to queue the newly created Sonos playlist ready for playing.
Ideally, being able to interact directly with Spotify/Google playlists would be great as it would deal with shared playlists which I follow and are regularly updated by others but for my purposes making a new Sonos playlist that is a copy of the Spotify/Google one will suffice.
Does that make sense?


Sourcemaps issue

Resolves https://github.com/Financial-Times/polyfill-service/issues/820
Before this PR:
When requesting minified polyfill bundle we would return all required polyfills concatenated together. The issue with this approach is some third-party polyfills include a sourcemap comment at the end of their code, this causes our bundle to end execution early.
After this PR:
When requesting minified polyfill bundle we would return all required polyfills concatenated together with a new line between each polyfill. This will stop the issue of a comment at the end of a polyfill file from commenting out the rest of the bundle.

This is the PR which introduced the sourcemap in Intl. @caridy, do you think this is better solved here (what this PR proposes) or by Intl?

yeah, that should work just fine, but ideally we can just get the sourcemap annotation removed from the polyfills when they are added to the service, there are a couple of npm pkgs that can do that as part of the build process.

https://github.com/thlorenz/convert-source-map#removecommentssrc

Great idea @caridy, thanks for suggesting the package, it works as expected. I've updated the PR with your recommendation :-)

@JakeChampion I couldn't make this code work for me, either in QA or locally, or in a simple reduced test case.  Weird.  I ended up doing this:
https://github.com/Financial-Times/polyfill-service/compare/v3.9.0...v3.9.2
If you're happy with that, I'll make the same change to master.

This problem is happening for us still when hitting
https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en&unknown=polyfill
With UA: Mozilla/5.0 (Linux; Android 6.0.1; SAMSUNG-SM-G920A Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/4.0 Chrome/44.0.2403.133 Mobile Safari/537.36
Service version states 3.11.0 when hitting non-minified version.


European Portuguese Translation

Description
Added European Portuguese translations. Cleaned locales folders as of Laravel folder structure.

Hi Dan. I guess it will be a breaking change for people already using pt_PT locale. I tried following laravel's i18n structure and leveraging filament's and laravel's community translations. Let me know if you assistance on this issue, I'll gladly help you.

Please rename the locale back to what it was, otherwise we can't merge this


BokehRenderer not validating inputs properly

The BokehRenderer class on the bokeh branch is not calling the _validate method of Renderer class as it should. This leaves the rest of __call__ to process the render formats without the appropriate validation.
This should be very easy to address and if there is some problem using the Renderer._validate method, it should be rewritten to be usable across backends.

The fix has been implemented in ba43e65 and seems to be working. For this reason, I shall now close this issue.


Change in domain templates

/kind feature
Describe the solution you'd like
We would like to have an enhancement to the domain template used in KServe. Currently, it's defined as {{ .Name }}-{{ .Namespace }}.{{ .IngressDomain }}.
Changing it to {{ .Name }}.{{ .Namespace }}.{{ .IngressDomain }} will make the AuthConfigs more specific, allowing for the creation of a configuration for *.{{.Namespace}} directly instead of monitoring all models and creating new "hosts".

@bartoszmajsak To be clear what we should do with this ticket, I have some questions.
is this request to change this configuraton:https://github.com/opendatahub-io/kserve/blob/master/config/configmap/inferenceservice.yaml#L181 to {{ .Name }}.{{ .Namespace }}.{{ .IngressDomain }}  for AuthConfig?

@bartoszmajsak To be clear what we should do with this ticket, I have some questions. is this request to change this configuraton:master/config/configmap/inferenceservice.yaml#L181 to {{ .Name }}.{{ .Namespace }}.{{ .IngressDomain }} for AuthConfig?

Technically speaking more about this https://github.com/opendatahub-io/kserve/blob/b6eac44afc395f864f10ee77c3d0a5636d9c1575/config/configmap/inferenceservice.yaml#L451 #88
@aslakknutsen can you confirm?

domainTemplateis part of the KServe configuration. On the Authorino side we canonly bind AuthConfigs to "hosts" with wildcard levels(.x.y), not partly wildcards(-x.y).
This change would allow us to handle 1 domain pattern between all models in a odh-project(namespace) without the need for additional listeners to update the host lists or filters to manipulate the  incoming host name.

@aslakknutsen can you confirm?

Not 100% sure of the source of this configuration in the kserve world and how that is moved to osd-manifests etc, but that certainly would look like it.

@aslakknutsen @bartoszmajsak Do you need to change only the InferenceService public domain? Or would you also need a similar change to the domain of the KNative services?

@aslakknutsen In KServe, when you create an InferenceService, it creates KNative services for you to deploy the models.
The ksvcs can also be publicly exposed with their own URL with a similar pattern that also seems to be {{ .Name }}-{{ .Namespace }}.{{ .IngressDomain }} by default.
So, several routes can be involved:

The route for the ISVC itself.
But we can also have several KNative routes.

My understanding is that you would want (1) changed, but not sure if routes in (2) would be relevant.
In any case, I was looking at doc comments in the inferenceservice-config ConfigMap, and it looks like the template is only applicable to RawDeployment which, at the moment, we are not using. See: https://github.com/opendatahub-io/kserve/blob/799e12122f4b6d3ca85f67f145706df6d43ffa18/config/configmap/inferenceservice.yaml#L215-L223.
I haven't tested, but from those doc comments, my understanding is that changing that template won't have any impact on the generated URLs for KServe Serverless installation. It seems that KNative is the component that is controlling the URL template. However, I couldn't find any docs for configuring KNative's URL template.
So, my perception is that is not as easy as changing the template. It may be an enhancement that needs to be done to KServe.


fix: remove regex replacement for lib mode

Description
Fix #14065 lib mode hanging for umd build, by removing regex replacements
Additional context
The original fix #7948 used regex for string replacement to avoid global esbuild helpers. However, it seems these can be removed now, because all the tests pass without them, probably due to updated esbuild (0.14.27 then vs 0.18.10 now).
The regex approach also doesn't completely fix the original issue, some reproductions with the latest vite (4.4.9):

UMD build, minify: true https://stackblitz.com/edit/vitejs-vite-9frvl5?file=vite.config.ts,index.tsx&terminal=build
UMD build, minify: false https://stackblitz.com/edit/vitejs-vite-z5wdig?file=vite.config.ts,index.ts&terminal=build

Given numerous preivous attemps #8110 #8741 #10905 at fixing regex performance, I think this is an indication that regex isn't the right solution in this scenario, and we should probably remove it altogether to avoid future performance issues.
In conclusion, we need a better fix for the global esbuild helpers. Removing regex for now appears to be safe because a). all tests pass and b). the original issue is still largely unfixed (easily reproducable - probably already in many people's builds)

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

🤦♂seems I forgot to run build before running tests locally.. I'll investigate more for a proper fix, closing for now


native-or-bluebird is deprecated. please switch to any-promise

https://github.com/kevinbeaty/any-promise
this implementation supports more promise implementations and allows the end-user to configure the promise implementation.

https://github.com/blakeembrey/popsicle-cache/releases/tag/v3.1.0 :+1:


Add vcpkg build instruction

Add vcpkg build instruction

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


The weather dataset could be further specified

Hi,
Thank you for the great work.
This is more of a suggestion than an issue.
Different papers use different weather datasets. So far I have found two: one is from USA weather stations with one-hour aggregation and the other is from Max Plank institute with 10 mins aggregation. Moreover, it looks like different authors are using the Max Plank dataset differently. For example, some of them are using 2 years of data while others are only using one.
I thought about bringing this up in case you want to bring this level of detail. If you want I could help :)
Best.

Hi,
Sorry for the late reply! It's my fault that the dataset description is not clear. The same problem also occurs on other datasets such as the NYC dataset. I think I'll do something to separate them later when I have more free time in the future. I even want to arrange a separate page for all the details of the datasets to show.


Failed calling webhook

Hello,
Recently we have done the setup of Connaisseur along with Cosign for signing images in our firm.
Today I was doing some test for pods as part of testing. While creating pod with signed image from Cosign and pod without sign. I am getting some error as below -
Errors:

For signed image:
Error from server (InternalError): erro when creating "STDIN": Internal error occurred: failed calling webhook "connaisseur-svc.connaisseur.svc": failed to call webhook: Post "https://connaisseur-svc.connaisseur.svc:443/mutate?timeout=30s": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

For unsigned image:
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "connaisseur-svc.connaisseur.svc": failed to call webhook: Post "https://connaisseur-svc.connaisseur.svc:443/mutate?timeout=30s": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

It will be of great help if I can get some idea how to resolve this error.

It seems that Connaisseur takes too long to do the signature verification. It has max 30 seconds to do so, as this is the max amount Kubernetes allows and at some point during that time Connaisseur gets stuck in your case.
Maybe try to check the logs and see where Connaisseur gets stuck to find the culprit. Also consider enabling debug mode (set debug field inside the helm values.yaml).


Doc: Enums, a coma is missing

After 'Pending', a coma should be written.

Hi @SebConejo can I work on this?

@Tjs002 of course 👍

After 'WorkInProgress' a coma should also be written, right?

I have opened a PR you can check it @SebConejo.


Add a 'Turtle' Program

More a fun one. Implement an example program in minilogo that draws an actual turtle, as an homage to 'Turtle' itself from python.

Closed by #6


[CSBindings] Couple of small PotentialBindings cleanups

Use int instead of unsigned int to represent # of non-defaultable bindings.
Because the formula is -(Total - Defaultable) which could only be 0 or negative.

Increase number of defaultable bindings iff the binding is accepted.

@swift-ci please smoke test

@swift-ci please smoke test Linux platform

@swift-ci please test source compatibility

@rudkx Only failures are in Tagged which is unrelated to these changes.


Upgrade Escrow from UsingRegistry V1 to V2

Description of Changes

Adds UsingRegistryV2WithStorageSlot.sol to enable backwards compatible upgrade to URV2 for core contracts
Updates varname registry -> registryContract in UsingRegistryV2 (since it's not being used yet, in order to not break release tooling when adding back registry to UsingRegistryV2WithStorageSlot
Upgrades Escrow to use UsingRegistryV2WithStorageSlot
Changes FederatedAttestations to use UsingRegistryV2 (new contract, so no need for empty storage slot)
Updated tests by following the method used in this previous PR
in FA tests, also incremented all test accounts used to add in owner = accounts[0] (since this is used by default in assumeOwnership, and to minimize impact of changes in other parts of the codebase)
Adds governanceConfig entry & release8 data for FederatedAttestations

Notes/questions

since we now require governance to have been migrated before running tests, we need to migrate all core contracts + governance + elect validators (which implicitly creates the account needed to then use when assuming ownership) when running tests locally (i.e. quicktest for both escrow & federatedattestations is not so quick anymore)

is there another way of doing this?

I will probably need to debug the build in CI for a little while but early feedback is welcome anyways :)

Hmmm, this is a tricky one. I've been diving into this a bit and can't really come up with a solution that I like. The only thing that I haven't looked into is whether we can touch the release tooling in any way. But yeah let me summarise my current understanding of what's happening here:
We made two design choices when developing UsingRegistry back in the day that make our life difficult:

It holds the address of the registry in storage (which in reality is static 0xce10).
By being a contract that gets imported into all contracts that rely on it, we essentially created the situation in which any change to it would result in the need to redeploy all contracts that import it, making it essentially impractical to upgrade.

When implementing cREAL we added UsingRegistryV2 which solves (1) but doesn't really address (2), and because we didn't actually use UsingRegistryV2 anywhere at that point we didn't come up with a strategy to upgrade from UsingRegistry to UsingRegistryV2, otherwise, we would have seen this issue that comes from the missing storage slot in V2.
Now with that in mind, the solution that you came up with is to create a new contract UsingRegistryV2WithStorageSlot which has the storage slot for backward compatibility. On this note, I would maybe call something like UsingRegistryV2BackwardCompatible, just because the point of it is to be backward compatible, having a storage slot is just the way it achieves that - but that's just being a bit nitpicky.
Now it gets a bit funky because if would name that storage variable _deprecated_registry_slot_for_storage_compatibility (verbosity overkill) on the EVM side everything would be hunky-dory but our tooling doesn't allow it at the moment. Unless I'm missing something, the storage layout doesn't depend on the variable names, and everything would be 100% identical, but we have tooling that ensures the storage variables don't change between upgrades to avoid foot-gun situations.
I wonder if there's any way to massage tooling so that we don't have to do the registryContract variable rename, or if you've gone down that road and came back thinking: "Nope, registryContract it is."

I went a bit verbose on this but writing helps me put my thoughts in order 😹


Remove Address from Contract.call and move into Params

So user has the easy choice of baking the contract address into the generated contract code.

This is probably the wrong decision on the api, would make it more difficult when mapping over a list of contract addresses.


Ctrl + E panel overflow main screen

System information:

Operating system Win10 10.0.16299.1029
DBeaver version <IP_ADDRESS>906091949
Java version JDK 1.8.0_171
Additional extensions No

Describe the problem you're observing:
I have 2 external monitor, when i press CTRL + E the panel overflow the main screen.

The monitors have different resolutions.
The laptop has a Full-HD monitor, while the left monitor is Full-HD widescreen and the right monitor is SXGA (1280×1024).
Dragging dbeaver from one monitor to another cause this issue because seems to save the previous monitor resolution. If I try to close and re-open dbeaver on the main monitor, the bug is still present.
Steps to reproduce, if exist:

Add two external monitor (it happens also with one monitor)
Open dbeaver
Open multiple scripts
Move dbeaver to another monitor
Press CTRL + E and ESC
Move dbeaver to the previous monitor
Press CTRL + E -> Bug

Include any warning/errors/backtraces from the logs
No errors or warnings from the logs

Thanks for the bug report

verified

Hi guys,
Sorry to come back on this issue but I've just downloaded and tested with 6.1.2 (<IP_ADDRESS>907061627) and the bug is still present, video in attachment.
dbeaver_panel_bug.zip

@uslss Could you please re-open this issue?

@uslss Could you please re-open this issue?


Update reduced-performance-after-smb-encryption-signing.md

"introduced with": this makes it more clear that the SMB version in casu als resides in newer Windows versions.
SMB 3.0 is introduced in Windows 8, not Windows 8.1 AFAIK.

@DaPadrePedro : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update extract review letterbox docs

Changelog Description
Update Extract Review - Letter Box section in Docs. Letterbox type description is removed.
Additional info
Screenshot is replaced with the one from the latest build (3.15.9)

Thank you


Add peaking equalizer filter

Add peaking equalizer filter in functional.py and test it in test_functional_filter.py.

Thanks for working on this! For convenience, let's also add a reference in the pull request to the other one: #260.

This PR also raises questions around general jit support, since many of the referenced and surrounding functions don't seem to be decorated as such.
However, overall, it's in tune with the current setup and seems correct. I'm happy to merge this!


PipelineX Prepare tasks in parallel

Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run buildall


Draft dust compatibility fix for 1.14.5

It appears 1.14.4 didn't change relay dust requirements, so we need 1.14.5 to be compatible in how it enforces penalties on dust outputs.
I'm aware the plan was to reduce dust so low that the penalty math basically never happened - suggest we actually just rip it out for future compatibility.
This is a quick draft for visibility, need to check this actually works, then will move out of draft status.

@rnicoll can you help me understand where in 1.14.4 source the COIN fee gets added during relay instead of minRelayTxFeeRate?

@rnicoll can you help me understand where in 1.14.4 source the COIN fee gets added during relay instead of minRelayTxFeeRate?

This comes from a bug report about the dust implementation, but I think in the end the values in 1.14.4 are correct, just if we change the IsDust() threshold it needs to happen in a relay-only value first, then in the calculated value. Let me build up a reproduction case, this mostly exists because I had people asking about it, hadn't expected anyone to look at it yet.

Oh also the bit where I wanted to take the calculation out entirely in this PR is just nonsense, I'll revert that shortly (it should be its own PR).

This comes from a bug report about the dust implementation

Can we see the report?

As said, wouldn't burn cycles on this until I have a recreation case for/against.

Okay. Done a live relay test with:

1.14.4 miner
1.14.4 node in the middle
1.14.5 transaction creator

1.14.5 creates a transaction with a 0.1 Doge output and a <1 Doge fee, which 1.14.4 doesn't relay. Not sure why yet, though.
010000000136acdab3b109c952aafc4b4c0c3a9f21be20bd23f2761ecf8b2cd7e9a3aac028000000006a473044022073b9a544bb246a710bb8e1cb165fdfaca7e252e700df94ad85f94f9b118f4e570220730d18a2c3286127049bc072792631720b239df97a72d41533acb4522aad60b20121039004b999717755276d213fa90f64679770781c8d1c85d49fb0130c9c03ac2212feffffff0280969800000000001976a9143404dba50cf4fa0046b9806d879a37631bf608fd88acb0d75905000000001976a914a0291cd23740f7f38de32e373e4fe4db401b99a888ac44593300 for the 1.14.5 generated transaction if you're curious

1.14.4 version v<IP_ADDRESS>-3ce34f6e6, might be worth double checking that's the shipping version. Going to try adding debugging detail to 1.14.4 and go from there, because if we can't identify where it's dropping the transaction, can't fix it

For my notes tomorrow; think 1.14.4 expects dust penalties if the output is <1 DOGE, and 1.14.5 only applies them well below that value. Transaction above has a fee of 0.00226 DOGE, I would expect 0.01226 DOGE I think (i.e. with a 0.01 DOGE penalty applied).


Bump der-parser to 9.0

This also removes syn 1.0 from the crate tree.

Hi @rainliu  -- any chance you could authorize this to run GitHub actions? It compiles OK locally but I'd like to check it against your actual CI.

Thanks. Just triggered it

Thank you!


Android configuration generates incorrect Makefile

Pull request #8103 introduced usage of ANDROID_NDK_HOME variable for Android build. But it seems to be an error here now.
https://github.com/openssl/openssl/blob/b2aea0e3d9a15e30ebce8b6da213df4a3f346155/Configurations/15-android.conf#L25-L30
Variable $ndk_var is used in the foreach loop. But in this case it's localized to the loop. So, this variable will be empty after the loop.
It causes generation incorrect -sysroot and -isystem parameters later in the code.
https://github.com/openssl/openssl/blob/b2aea0e3d9a15e30ebce8b6da213df4a3f346155/Configurations/15-android.conf#L135-L136
https://github.com/openssl/openssl/blob/b2aea0e3d9a15e30ebce8b6da213df4a3f346155/Configurations/15-android.conf#L141
I used next command to generate Makefile:
./Configure android-arm -D__ANDROID_API__=24

Result Makefile contains some incorrect file paths. For example:
-isystem $()/sysroot/usr/include

So, current Android configuration file should be fixed.

Fix was pushed to master. Close issue.


feat(sdk): DID creator supports did:jwk

Signed-off-by: Filip Burlacu<EMAIL_ADDRESS>

Codecov Report
Base: 90.16% // Head: 89.30% // Decreases project coverage by -0.87% :warning:

Coverage data is based on head (3737d93) compared to base (28738c1).
Patch coverage: 51.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   90.16%   89.30%   -0.87%
==========================================
  Files          40       40
  Lines        1617     1636      +19
==========================================
+ Hits         1458     1461       +3
- Misses        109      125      +16
  Partials       50       50

Impacted Files
Coverage Δ

pkg/did/creator/creator.go
82.75% <51.35%> (-13.12%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update Tier 3 HCR, and code for setting TACs w/ 1year projection

Update how Tier 3 HCR was being computed,
Update how TACs should be set (1 year projection),
Add threshold cap control ruel

Note that I made a change in afscOM, so we need to commit those changes first, before this can be pulled through (just allowing for the output of an F vector).
Also, lines 281 - 283 in sablefish_OM.R should be updated, where the selectivities should be weighted by the F in the terminal year and then summed and standardized - I didn't update since I didn't have enough time, but will make an issue as well.

@chengmatt Check to make sure this runs correctly on your end


compatible versions for gem "faraday"

Bundler could not find compatible versions for gem "faraday". This gem requires minimum v0.12 for faraday and I am using some other gems which require lesser version for faraday, due to which I am unable to install it in my rails application.

Hi There!
The best advice I could give you is to determine which gems have incompatible faraday versions and attempt to update them to a newer version that depends on a more modern version of faraday. If you can't do that, the best course of action would be for you to send a patch to those gems to update their dependency.
From our perspective, we don't directly depend on faraday, specifically:

this library depends on google-gax (~> 1.4)
google-gax depends on googleauth
googleauth resolves to faraday minimum at 0.12

As such,


Synced settings don't respect existing indentation amount or type

After syncing this morning in the conflict resolution state the indentation was all off which I don't doesn't happen when you add new settings via settings UI.
{
  (lots of settings indented with 2 spaces),
  "terminal.integrated.windowsEnableConpty": false,
  "terminal.integrated.rendererType": "experimentalWebgl",

  "terminal.integrated.minimumContrastRatio": 11,
"terminal.integrated.commandsToSkipShell": [
	"workbench.action.toggleSidebarVisibility"
],
"terminal.integrated.enableBell": true,
"debug.toolBarLocation": "docked",
"git.enableStatusBarSync": false,
"remote.SSH.enableHostsExplorer": true,
"terminal.integrated.splitCwd": "initial",
"workbench.statusBar.visible": true,
"editor.accessibilitySupport": "off",
"a": {
	(snip)
},
"editor.fontSize": 13,
"terminal.integrated.fontSize": 13,
"explorer.compressSingleChildFolders": true,
"workbench.dialogs.useSimplified": "true"
}

Currently I am hardcoding the indentation to tab and hence it is. I would probably read the indentation config from settings and use it.

Also right now it's really mangling my settings file. The order and indentation of settings is important to me, even more so than for keybindings as that's how I manage them.

Moved that to https://github.com/microsoft/vscode/issues/85716 as it's different to indentation


Merge CLI binaries

Pull Request Description

Remove enso-build4 (which seems to have only contained testing file)
Move enso-remove-draft-releases and enso-disable-wasm-opt to the main CLI

This may be undesirable, since these are commands that should rarely, if ever, be run. I don't think it is a security issue though?
The goal of these changes is to save ~13GB by avoiding duplicated dependencies (each of the four CLIs weigh in at ~500MB each), and make the build process for the build script less RAM intensive (the four large CLIs tend to build in parallel at the end of re-compilation)

Extract common parts of the cargo build command in the ./run scripts into a Cargo [alias], as suggested

Important Notes

The current implementation is very messy - it almost certainly needs changes before it's suitable for merging.
I've tested ./run disable-wasm-opt, and verified that pwsh run.ps1 (without arguments) runs successfully on Linux. I haven't tested on other systems, however
I think something to look into in the future though, is whether we can make the build script as a whole smaller, because 600MB is pretty big for something that (I assume) only manage build processes
I didn't find any code that depends on the extra binaries, so I'm assuming no further action needs to be taken elsewhere in the codebase.

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

there are some other things i think could be cleaned up? but they're probably out of scope for this PR.
e.g. i'm not sure whether this is a typo, or intentional
https://github.com/enso-org/enso/blob/44f2f425c0bcb2f7805c76ca26a8f176e7c780a8/build/ci_utils/src/program/command.rs#L493
there is also commented code in at least one place:
https://github.com/enso-org/enso/blob/44f2f425c0bcb2f7805c76ca26a8f176e7c780a8/build/ci_utils/src/program/command.rs#L536-L589

upon further investigation... it turns out that the majority of the binary's size comes from debug symbols (the binary size goes from 623MB to 43MB when debug symbols are disabled.)
it's entirely possible that we do want the debug symbols though, so i haven't disabled them here - it should be very simple to do it later anyway
https://github.com/enso-org/enso/blob/44f2f425c0bcb2f7805c76ca26a8f176e7c780a8/Cargo.toml#L73-L78