Feature/landing page UI refresh #13

Refreshed home page with new ui.
Currently only a placeholder from countdown, may need to open a new issue to get implemented
Mostly responsive, with only the nav bar needing work, but may be a separate issue as well.

Love the design of index.html. Keep up the good work! If about.html has no use it may as well just be removed rather than leave it there with filler content

Consider carefully when overriding and/or not using the bootstrap classes, specifically containers, rows and columns. The look you are going for should be possible using the Bootstrap classes and the Bootstrap grid system so where possible use these classes if you can as it will help prevent any unintended side effects.
https://getbootstrap.com/docs/5.0/layout/grid/

The diff for this PR is saying 2,651 changes were made to static/styles/bootstrap/css/bootstrap.css. Could you provide some context for this? It looks like it's mostly formatting so I assume it was either updated or formatted by something such as an IDE.

In anticipation of future webpage content, perhaps images should be stored in static/images to keep the static folder neat and tidy?

No worries thank you for your feedback! I will get on these changes as soon as I can. I think I should change the monkey image to a different variation. To avoid any more confusion...
Unless you really like the monkey? @NickoOwen :D

No problem @BasilDimopoulos. Your call re monkey, I don't mind 😆

Closing this pull request as it has been implemented as part of https://github.com/NickoOwen/bananabot/pull/22
The new UI looks FANTASTIC! Thanks again for all your hard work on that @BasilDimopoulos


Error definition location convention

As brought up in #78 here there are arguments for and against the location of errors (interface vs implementation), a repository wide convention must be decided and refactors executed to enforce the convention.

will likely be resolved with https://github.com/BreadchainCoop/breadchain/issues/89


submit a test claim for verification

@OR13I was following the main readme to create a PR, is there any chance you could approve?

Thanks! lets see if it worked properly! lol.

You PR does not use a JWT, this demo only supports JWTs at this time.

try doing this:
https://api.did.actor/issue

I think the confusing part is the UI in https://api.did.actor/issue as I am not clear if it just generates an example or actually creates/saves something.
How do I go from the UI to having a JSON containing  the JWT? Is it one of the commands npm run claim:prepare?
More explanations in the readme would be much appreciated

thanks! I will update the readme.

I tried to update the instructions here, and include an example I built following them: https://github.com/OR13/endor/pull/9
feel free to CR that PR if you think its not clear enough


Fixing $authors$ to $author$

nuget pack for a csproj only works when $author$ is used in the nuspec and the [AssemblyCompany] is populated.  $authors$ does not work.  This resolves content feedback items https://github.com/NuGet/docs.microsoft.com-nuget/issues/1226 and should revert the changes made in https://github.com/NuGet/docs.microsoft.com-nuget/issues/1072

OPS Build status updates of commit e8e6e09:
:clock10: Preparing: average preparing time is 41 sec(s)

OPS Build status updates of commit e8e6e09:
:clock10: Incremental building: average incremental building time is 21 sec(s)

OPS Build status updates of commit e8e6e09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/nuspec.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@StingyJack thank you for your contribution!


Fix libwebp Node struct shadowing Godot's Node class in MSVC debugger

I was having an issue when debugging on Visual Studio that sometimes the struct Node contents from libwebp quant_enc.c such as int8_t prev were showing up in the debugger instead of the godot Node class (for example, when clicking on the parent of Node3D to access the node's name in the debugger).
This renames the struct using a #define. it should have no effect, other than to prevent a conflicting/shadowing struct Node from showing up in the debug data.

Maybe clarify this is about webp in the commit, hard to tell what this is about by just looking at it

I think the commit is already ok here, but I've amended the PR title for extra clarity.

Cherry-picked for 4.0.4.


How to not update updated_at for some specific operations?

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
go version go1.13.1 linux/amd64
Which database and its version are you using?
mysql5.7
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/mssql"
	_ "github.com/jinzhu/gorm/dialects/mysql"
	_ "github.com/jinzhu/gorm/dialects/postgres"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

var db *gorm.DB

func init() {
	var err error
	db, err = gorm.Open("sqlite3", "test.db")
	// db, err = gorm.Open("postgres", "user=gorm password=gorm DB.name=gorm port=9920 sslmode=disable")
	// db, err = gorm.Open("mysql", "gorm:gorm@tcp(localhost:9910)/gorm?charset=utf8&parseTime=True")
	// db, err = gorm.Open("mssql", "sqlserver://gorm:LoremIpsum86@localhost:9930?database=gorm")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}

func main() {
	exp := gorm.Expr("sort + 1")
	if err = db.Model(&model.Test{}).Where("id = ?", 1).Update("sort", exp).Error; err != nil {
		logger.Error(err)
		return
	}
}

for some operations, I don't want to update "updated_at" field, is it possible?
The sql quest above is :
UPDATE `test` SET `sort` = sort + 1, `updated_at` = '2019-12-11 17:08:59'  WHERE (id = 1)

what I want is:
UPDATE `test` SET `sort` = sort + 1  WHERE (id = 1)

For those who haven't found it:
https://gorm.io/docs/update.html#Without-Hooks-x2F-Time-Tracking
u := User{
  ID: 111,
  Name: "hello",
  Age: 18,
}

db.Model(&user).Save(&u)
// UPDATE users SET name='hello', age=18, updated_at='2013-11-17 21:34:10' WHERE id=111;

db.Model(&user).UpdateColumns(User{Name: "hello", Age: 18})
// UPDATE users SET name='hello', age=18 WHERE id = 111;


Navbar not appearing on mobile view

Description:  The navbar is not visible in mobile views.
To Reproduce please execute the steps
1 - Start Template
2 - Change the resolution to 1048x445 (responsive) or bigger - Navbar is there:

3 - Using a lower resolution, the navbar is not visible anymore - Iphone X screen ratio:

4 - Using responsive 972 x 1156 ratio - navbar is not displayed:

Expected behavior
Navbar should be accessible on all resolutions as a full expanded menu or burger menu on lower resolutions
Desktop tests:

OS: Windows 10 - Browser Chrome Latest
OS: Windows 10 - Browser Firefox Latest

same issue here ... any help would be much appreciated ! I spent hours and days working on this theme template, then realized it ain't displaying fine on mobile phones ... it's a shame because it's a great template. Thanks chaps for your help :-)

@jossgillet These steps are for this Flask template. But it shouldn't be much different regarding the HTML. Just add it directly instead of doing step 2.

Add this to navigation.html:

Then, in base.html add:

{% include 'includes/navigation.html' %}

So that it is below this line:

{% include 'includes/sidebar.html' %}

That should be all for the mobile top bar to appear. Let me know if it works for you.

@Teraskull I'm working with the Django template, and this almost worked 100% for me.
With that navigation.html I was getting the following:

first
second
third

I fixed it by also adding this to styles.css:
@media only screen and (max-width: 991px) {
  .pcoded-header {
    width: 100%;
    margin-left: 0;
  }
}

After:

This is resolved in latest version. Thanks for reporting.


Swift 2.1 Update

Note* - Quick Select is not working due to the following error:
swapping a location with itself is not supported
Looked into this briefly but couldn't see a quick workaround. The following link seems promising
http://stackoverflow.com/questions/24026510/how-do-i-shuffle-an-array-in-swift

Also took a stab at implementing this for Swift 2.1from  the implementation here both as a generic and as a function: http://rosettacode.org/wiki/Quickselect_algorithm?section=35#Swift
func quickSelect<T where T : Comparable>(var elements: [T], n: Int) -> T {
  var r = elements.indices
  while true {
    let pivotIndex = elements.partition(r)
    if n == pivotIndex {
      return elements[pivotIndex]
    } else if n < pivotIndex {
      r.endIndex = pivotIndex
    } else {
      r.startIndex = pivotIndex+1
    }
  }
}

func quickSelect(n: Int, var arr: [Int]) -> Int {
  var r = arr.indices
  while true {
    let pivotIndex = arr.partition(r)
    if n == pivotIndex {
      return arr[pivotIndex]
    } else if n < pivotIndex {
      r.endIndex = pivotIndex
    } else {
      r.startIndex = pivotIndex + 1
    }
  }
}

for i in 0 ..< 10 {
  let a = [9, 8, 7, 6, 5, 0, 1, 2, 3, 4]
  print("\(quickSelect(i, arr: a))", terminator: "")
  if i < 9 { print(", ", terminator: "") } else { print("") }
}

However the output I'm getting is not correct:
/* Begin Program */
var n: Int
var element: Int
var randomNumbers = [9, -1, 8, 2, 4, 100, -9, 0, 2, 5, 55, 13,74, 3]

n = 3
element = quickSelect(n, arr: randomNumbers)
print("The nth element, (n = \(n)) is: \(element)")

randomNumbers = [9, -1, 8, 2, 4, 100, -9, 0, 2, 5, 55, 13,74, 3]
n = 0
element = quickSelect(n, arr: randomNumbers)
print("The nth element, (n = \(n)) is: \(element)")

randomNumbers = [9, -1, 8, 2, 4, 100, -9, 0, 2, 5, 55, 13,74, 3]
n = 5
element = quickSelect(n, arr: randomNumbers)
print("The nth element, (n = \(n)) is: \(element)")

randomNumbers = [9, -1, 8, 2, 4, 100, -9, 0, 2, 5, 55, 13,74, 3]
n = randomNumbers.count - 1
element = quickSelect(n, arr: randomNumbers)
print("The nth element, (n = \(n)) is: \(element)")

0, 1, 2, 3, 4, 5, 6, 7, 8, 9
The nth element, (n = 3) is: 2
The nth element, (n = 0) is: -9
The nth element, (n = 5) is: 3
The nth element, (n = 13) is: 100


add conditions for ci workflow

Signed-off-by: Di Xu<EMAIL_ADDRESS>
What type of PR is this?
kind/workflow
What this PR does / why we need it:
add conditions for ci workflows to avoid running operations that are exclusive in clusternet org
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Codecov Report

Merging #246 (bc7bdaa) into main (cfa3c2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   10.46%   10.46%
=======================================
  Files          39       39
  Lines        4260     4260
=======================================
  Hits          446      446
  Misses       3781     3781
  Partials       33       33

Impacted Files
Coverage Δ

...ernet/clusternet/pkg/hub/apiserver/shadow/utils.go
89.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa3c2c...bc7bdaa. Read the comment docs.


add support for deleting mock data with a command, without restarting mock server

Is your feature request related to a problem? Please describe.
Small issue: when I need to reset the mock data via command line (rm ./amplify/mock-data/dynamodb/fake_us-fake-1.db) I then need to manually restart the mock API server, which is a bit boring.
Describe the solution you'd like
add to the mock API a route '/resetFakeData' (or anything else) which will remove the fake data without having to restart the server.

@anisg would you rather have a command that resets the mock Api server?

@ammarkarachi yes that would work too.

another thing that would make sense too is to add a button "Reset Data" in the GraphiQL Explorer.

In the user's perspective, the most intuitive way is to simply tab on the Reset Data button in GraphiQL to clear all data.

It would also be helpful to move the ADD NEW row to the top left instead of being at bottom left on the Explorer panel. Considered all the buttons are at top, it is a bit counterproductive to ADD NEW row at the bottom and click run on top. It is a simple fix in code, which is just swapping the two divs block and a line of CSS to fix the border.

Hi, could I pick this up?


Make http example non-blocking

I modified the http example to have non-blocking behavior. Composure blocks on deferreds unless we extend Renderable.
The difference can be seen when benchmarking with :executor :none
Before:
$ wrk -t 1 -c 250 -d 10 http://localhost:10000/delayed_hello
Running 10s test @ http://localhost:10000/delayed_hello
  1 threads and 250 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
Latency     1.05s    45.93ms   1.10s    68.75%
Req/Sec    15.33      1.00    17.00     66.67%
  144 requests in 10.05s, 22.36KB read
  Socket errors: connect 0, read 0, write 0, timeout 112
Requests/sec:     14.32
Transfer/sec:      2.22KB

After:
$ wrk -t 1 -c 250 -d 10 http://localhost:10000/delayed_hello
Running 10s test @ http://localhost:10000/delayed_hello
  1 threads and 250 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.01s    12.00ms   1.05s    88.58%
    Req/Sec   437.40    685.35     2.38k    90.00%
  2237 requests in 10.05s, 347.35KB read
  Socket errors: connect 0, read 0, write 0, timeout 13
Requests/sec:    222.51
Transfer/sec:     34.55KB

Thanks, this is something I had meant to add myself.


[SPARK-43838][SQL] Fix subquery on single table with having clause can't be optimized

What changes were proposed in this pull request?
Eg:
sql("create view t(c1, c2) as values (0, 1), (0, 2), (1, 2)")

sql("select c1, c2, (select count(*) cnt from t t2 where t1.c1 = t2.c1 " +
"having cnt = 0) from t t1").show()

The error will throw:
[PLAN_VALIDATION_FAILED_RULE_IN_BATCH] Rule org.apache.spark.sql.catalyst.optimizer.RewriteCorrelatedScalarSubquery in batch Operator Optimization before Inferring Filters generated an invalid plan: The plan becomes unresolved: 'Project [toprettystring(c1#224, Some(America/Los_Angeles)) AS toprettystring(c1)#238, toprettystring(c2#225, Some(America/Los_Angeles)) AS toprettystring(c2)#239, toprettystring(cnt#246L, Some(America/Los_Angeles)) AS toprettystring(scalarsubquery(c1))#240]
+- 'Project [c1#224, c2#225, CASE WHEN isnull(alwaysTrue#245) THEN 0 WHEN NOT (cnt#222L = 0) THEN null ELSE cnt#222L END AS cnt#246L]
   +- 'Join LeftOuter, (c1#224 = c1#224#244)
      :- Project [col1#226 AS c1#224, col2#227 AS c2#225]
      :  +- LocalRelation [col1#226, col2#227]
      +- Project [cnt#222L, c1#224#244, cnt#222L, c1#224, true AS alwaysTrue#245]
         +- Project [cnt#222L, c1#224 AS c1#224#244, cnt#222L, c1#224]
            +- Aggregate [c1#224], [count(1) AS cnt#222L, c1#224]
               +- Project [col1#228 AS c1#224]
                  +- LocalRelation [col1#228, col2#229]The previous plan: Project [toprettystring(c1#224, Some(America/Los_Angeles)) AS toprettystring(c1)#238, toprettystring(c2#225, Some(America/Los_Angeles)) AS toprettystring(c2)#239, toprettystring(scalar-subquery#223 [c1#224 && (c1#224 = c1#224#244)], Some(America/Los_Angeles)) AS toprettystring(scalarsubquery(c1))#240]
:  +- Project [cnt#222L, c1#224 AS c1#224#244]
:     +- Filter (cnt#222L = 0)
:        +- Aggregate [c1#224], [count(1) AS cnt#222L, c1#224]
:           +- Project [col1#228 AS c1#224]
:              +- LocalRelation [col1#228, col2#229]
+- Project [col1#226 AS c1#224, col2#227 AS c2#225]
   +- LocalRelation [col1#226, col2#227]

The reason of error is the unresolved expression in Join node which generate by subquery decorrelation. The duplicateResolved in Join node are false. That's meaning the Join left and right have same Attribute, in this eg is c1#224. The right c1#224 Attribute generated by having Inputs, because there are wrong having Inputs.
This problem only occurs when there contain having clause.
also do some code format fix.

Why are the changes needed?
Fix subquery bug on single table when use having clause

Does this PR introduce any user-facing change?
No

How was this patch tested?
Add new test

cc @cloud-fan @jchen5

I think a better fix is to let DeduplicateRelations handle Project with alias as well, which is also a source of conflicting attribute ids.

I think a better fix is to let DeduplicateRelations handle Project with alias as well, which is also a source of conflicting attribute ids.

@cloud-fan Hi, I already implement DeduplicateRelations to handle with Project. Should I revert change from RewriteCorrelatedScalarSubquery? I think it's a hidden danger

cc @jchen5

The k8s failure is unrelated, I'm merging it to master, thanks!


fix(examples/fireworks): sample explosion_direction uniformly on 3d sphere

In examples/fireworks/main.rs, I believe explosion_direction is not sampled uniformly on the 3d sphere, resulting in non-uniform initial velocities of particles
Here is the result of the current sampling (I increased the number of particles to make it clearer):

The code I suggest returns the following:

The idea is to sample theta in arcos(unif(-1, 1)) instead of unif(0, pi). More details can be found here: https://stats.stackexchange.com/a/232256

Nice, thanks for the contribution 👍


[TypeSpec Requirement] Fail if spec contains OpenAPI generated from TypeSpec, but no tspconfig.yaml

Fixes #27268

Validation build: https://github.com/Azure/azure-rest-api-specs/pull/28444/checks?check_run_id=23085385602

Related PR:

https://github.com/Azure/azure-rest-api-specs/pull/28464


docs(config): clarify version format

From peeking at the source:
https://github.com/TooTallNate/vercel-deno/blob/f4d56565b15c1adc1729612360c9bfb9d12e11dd/src/index.ts#L161-L163
it looks like the runtime prefixes any argument provided to --version with a "v" unless it already starts with one
https://github.com/TooTallNate/vercel-deno/blob/f4d56565b15c1adc1729612360c9bfb9d12e11dd/src/build.sh#L15
then uses this value as the release tag when installing Deno.
This PR adds documentation guidance for what is a valid version format.

Hi @TooTallNate
Have any feedback about this?


Upgrade to Gradle 7.6

Upgrade to Gradle 7.6 and update all Gradle Wrapper files to the newest version.

@sconvent Thank you for signing the Contributor License Agreement!

Sagan will be soon retired. A note has been added to the README.
We don't accept contributions anymore as a result.
Thanks for your help!


Insiders- Hot Exit - Cannot Open User Settings (property fsPath is null)

VSCode Version: 1.7.0-Insider. Date: 2016-10-21
OS Version: Windows 10

Steps to Reproduce:

Attempt to open user settings (this also happens when attempting to open other random files, but isn't as easily reproducible)
NB. This is with Hot Exit enabled. Hot Exit also doesn't appear to be working properly as I still receive a prompt to save files before closing the editor. (Only mentioning it in case it's relevant.)

File fails to open and displays this error:

Unable to open 'settings.json': Cannot read property 'fsPath' of null.

Dev Tools logging:
messageService.ts:128Unable to open 'settings.json': Cannot read property 'fsPath' of null.: Error: Unable to open 'settings.json': Cannot read property 'fsPath' of null.     at t.doHandleSetInputError (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:115:1919)     at file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:115:1525     at Object.v [as _notify] (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:9991)     at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:13496)     at _run (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:14817)     at _chainedError (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:14176)     at n (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:11999)     at then (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:15626)     at Object.enter (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:12068)     at _run (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:14817)     at _setCompleteValue (file:///C:/Program Files (x86)/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:31:14511)e.doShow @ messageService.ts:128

I ran through a bunch of different cache deletion things to finally work around this. First I removed the user setting from the file, then it seems like opening a new window, opening a folder, closing the application, opening the application, opening a folder, and then going to settings let me edit settings again. The same error could be seen when clicking "Reopen Closed Editor" if that helps at all as well.

I've reverted the changes responsible and will queue a new build. This will stay open until it's verified to be fixed on the feature branch.

The new builds will have to wait until this DNS DDoS attack is over.

It looks like this is related to a workspace, I believe this has since been fixed on the feature branch as it's changed quite a bit since this occurred and couldn't repro on LInux.


Changed imgur title grabbing to be less reliant on site style

I changed how it gets the album title in getAlbumTitle to use meta tags instead of html parsing. Hopefully this means that when imgur changes their html layout it won't break album title saving

Fair enough. They could always change this as well, but it's less likely to change at any rate. Thanks!


how to add a card with rss feed?

I want to import an RSS feed into a new deck. How do I do this?

What have you tried?

The feed will import into the currently selected deck.  If you have trouble with any of those steps, let me know.


Replace os.FileMode with fs.FileMode once Go 1.18 is used in CI.

Is your feature request related to a problem? Please describe.

fs.FileMode replaces os.FileMode from Go 1.16.
Currently the CI builds the latest patch versions of the last 3 minor versions of the configured major version (1).
This requires os.FileMode to be used until every CI version is at least Go 1.16.
Describe the solution you'd like to see

Search and replace os.FileMode with fs.FileMode.
Describe alternatives you've considered

Additional context

Decided to use only the latest Go version in CI, so I'm going to do this immediately.


Add hg38 support (resolves #161)

resolves #161

Jenkins, test this please.

Jenkins, test this please.


Pip install fails on multiple python versions (Ubuntu)

I tried multiple python versions but keep running into compatibility issues across the different required libraries:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gradient 2.0.6 requires click<9.0,>=8.0.1, but you have click 7.1.2 which is incompatible.
sentence-transformers 2.2.2 requires huggingface-hub>=0.4.0, but you have huggingface-hub 0.0.12 which is incompatible.
Successfully installed click-7.1.2 datasets-1.7.0 huggingface-hub-0.0.12 nltk-3.6.6 pyarrow-3.0.0 scikit-learn-1.0.2 summac-0.0.3 tokenizers-0.10.3 tqdm-4.49.0 transformers-4.8.1 xlrd-1.2.0
Can you dump a pip freeze somewhere that has all of the python library versions you are using, along with the python version? Then i can hopefully install it.

I have managed to use it by cloning the repository and installing the dependencies with requirements.txt.

Hey @simonhughes22 & @BiliBraker ,
Thanks for the help with this, an update to the requirements.txt was overdue.
I've now updated the package to version 0.0.4 and have installed the package successfully on python 3.9 and python 3.10 environments.
If summac is still relevant to what you do, I'd love to see if the problem is resolved on your end with the new version!
Philippe

As I wrote in #8, it solved the issue! :) Thank you!


How to get data from 2-way binding component

Since lit-element use unidirectional data binding, for ex:
${myprops}
 . How do I get a data from a component which in its pattern use 2-way binding in LitElement? for example in routing <app-route/> component with PolymerElement
<app-route
    route="{{route}}"
    pattern="/:page"
    data="{{pageRoute}}">
</app-route>

And the data is propagated (I dont exactly know how this works) to pageRoute.page,
<iron-pages selected="[[pageRoute.page]]" attr-for-selected="page-name" fallback-selection="fallback">

Test

Not found

</iron-pages>

HI,
you should listen for event : https://github.com/PolymerElements/app-route#integrating-with-other-routing-code and set properties.
in that particular case there's many other way to do this :
_render({page}) {
 return html`${page =="test" ? html`
Test
` :  html`
Not found
`}`;
}

_render({page}) {
  if(page =="test") return html`<div page-name="test">Test</div>`
  else return html `<div page-name="fallback">Not found</div>`
}

but you should take a look to the pwa starter kit https://github.com/Polymer/pwa-starter-kit wich use some pwa helpers https://github.com/Polymer/pwa-helpers#routerjs to achieve this.

@eskan is correct. 2-way binding is a Polymer-specific concept. https://github.com/Polymer/pwa-starter-kit is a great starting point for learning how it could be possible to propagate data based on lit-element. Of course you are free to choose your own way, like listening to events and react accordingly.


Add support for knex 0.21.x

Drop CI execution on Node 8 (knex no longer supports it)
Add CI execution on Node 14

Would love to see this merged.


access sub.domain.com/panel domain not found

hi i have setup laraveladmin in subdomain. buat /panel seems to be not found.
The requested URL /panel was not found on this server.
how can i fix it ?
thanks in advance

sorry, i forgot enable mod_rewrite on apache.


I want to adjust  width according to our device

how to adjust according to device and any operating system

Hey, @krishraiturkar
Your question may not be related to the current project.
You may find better assistance on stackoverflow.com or another platform.

Thanks

Hi bro you are right
On Thu, 6 Apr 2023, 21:05 Vinicius Cainelli, @.***>
wrote:

Hey, @krishraiturkar https://github.com/krishraiturkar
Your question may not be related to the current project.
You may find better assistance on stackoverflow.com or another platform.
—
Reply to this email directly, view it on GitHub
https://github.com/shadcn/ui/issues/143#issuecomment-1499261772, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5KP6TIGR6TOFKMQ24NZKA3W73PDZANCNFSM6AAAAAAWKWWWTE
.
You are receiving this because you were mentioned.Message ID:
@.***>

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


Sharding rename

Hello,
Wanted to know what happens if I rename one of my shard? Will this break the sharding? Or what should I consider when renaming a shard?
Thanks in advanced!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 050bb1fd-56ca-63bc-b105-17a56e3b0362
Version Independent ID: ce84d0a7-3596-e259-dfc3-a9789efd9948
Content: Sharding pattern - Cloud Design Patterns
Content Source: docs/patterns/sharding.md
Service: guidance
GitHub Login: @dragon119
Microsoft Alias: pnp

Hi @fcobo95 Since we haven't heard back, we will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


brew upgrade protop errors on Linux

$ brew install protop
Error: No available formula with the name "protop"
==> Searching for a previously deleted formula (in the last month)...
Error: No previously deleted formula found.
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.

$ brew upgrade protop
Error: No available formula or cask with the name "protop"

Is this after tapping protop-io/protop? (This is specified in the main
protop repo’s readme but not this one, so that should be added)
On Sun, Aug 2, 2020 at 12:48 PM Noel Yap<EMAIL_ADDRESS>wrote:

$ brew upgrade protop
Error: No available formula or cask with the name "protop"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/protop-io/protop/issues/25, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG2JTQBTSVBPSBWLUTLN3R6WRG3ANCNFSM4PSU6QUA
.

--
Jeffery Shivers
github.com/jefferyshivers
linkedin.com/in/jeffery-shivers

As an additional thought, it would be nice to get the plugin into homebrew officially at this point since the prerequisite to use the tap isn’t ideal.

Sorry, I had missed that very first line in the readme.


Building, serving/loading and hot reloading

In general, all assets (scripts, models, sounds etc.) have three "phases" in Tilt;

Building: We take a source asset (.fbx, .wav, a rust crate, etc.) and turn it into a format consumable by Tilt
Serving/loading: That asset is loaded into memory by Tilt
Hot reloading: The source asset has changed, so we re-run the two first steps and update the game with the new asset

Building
The core idea here is that conceptually we always run a full build. However, the build consist of "build nodes", for instance we might have a PipeImage node which takes a source image, transforms it (resize for instance) and then outputs the result in the target directory. The build node can check if the output file(s) is newer than the input file(s), and if that's the case it can skip that build node.
Builds can be triggered in a number of ways, such as running tilt build or by the hot-reload watcher detecting that any of the source input files have changed
Serving/Loading
Once the assets have been built, they can be served. The important thing here though is that we have to assume that they are served over the network. We also have to assume that they might be served from a static http content server. More over, the assets are normally also cached on the client side (see BytesFromUrl).
Hot reloading
Hot reloading consists of two parts; on the server side we need to detect when anything changes in the source files, and then we should run a full build. And then once the build has finished, we need to figure out which output assets have changed, and then notify all clients (including the running server) which assets have been invalidated. They then need to re-load those assets, potentially with some cache breaking (like for instance adding ?cache_break=random_id to the url).

There are several levels of hot reloading:
I think one pain point in development currently (without an editor) is that when adjusting certain parameters, constant values, or initial values, we have to keep recompiling (or is there a solution already?). If these initial values could be stored in a file (like ambint.toml ) and refreshed immediately once changed, it would be much more comfortable experience.

There's currently a hack in place for hot-reloading WASM modules that will ignore the asset cache and always fetch the latest version when [client_]module_from_url changes. We should remove that hack once we get hot-reloading in proper.


Is it possible to print a  dimensions of the extracted mesh

thank you for your work
I am a mechanical engineering student and new to this area, so I don't know much about it yet.
Currently, we are working on meshing the images taken by the 3d scanner hardware we made with sdfstudio and printing them with a 3d printer.(Of course, we're still not reconstructing our objects properly, but...)
I was wondering if it is possible to print the dimensions of the extracted mesh (even if it is from a previous train).
I'm not sure what part of the current docker container needs to be modified to add the ability to print dimensions.
Finally, I was wondering if I could extract only the parts of the mesh I wanted. Like the viewer of instant-ngp, I can adjust the bounding box to extract only the part I want.

Currently, my results overlap the object I want and most of the pedestal, so I can't get just the object I want.

If you know the bbox for the object, you can just specify it during mesh extraction like --bounding-box-min -2.0 -2.0 -2.0 --bounding-box-max 2.0 2.0 2.0

If you know the bbox for the object, you can just specify it during mesh extraction like --bounding-box-min -2.0 -2.0 -2.0 --bounding-box-max 2.0 2.0 2.0

@niujinshuchong  thanks   how do i know bbox??


Area and time cleaning piids change

@harisma-git  I'm not sure how you are doing your pull request, but I think you are still not doing it correctly.
You need to clone the repo (ensure you clone the master branch) to your local machine, make the changes and then create a pull request.
I recommend installing the GitHub desktop app to do this: https://desktop.github.com/
It will make it much easier.
Thanks!


[FEATURE]add security analytics support

Is your feature request related to a problem?
no security analytics support by the provider.
What solution would you like?
are there plans to implement support for security analytics. For our use case we would like to be able to create detectors and use alerts.
What alternatives have you considered?
Using the api directly for now.

[Untraige]
Thanks @karel0707 for bringing this up, will look into this enhancement, please let me know if you are interested in contributing to this feature.
Thanks
Adding @bbarani @rblcoder @premkirank @afrodidact

@prudhvigodithi I would like to work on this. Can I get more details here?

Hello everyone,
Just checking if anyone started to work on it.
Thank you,

Hey @premkirank can you please let us know if you are still open to contribute to support security analytics? Also @givilleneuve please let us know if you are open to contribute, I can add you to the assignee.
Thanks
@bbarani @rblcoder


Let EditorPlugins set editor/distraction-free mode

Give plugin creators the ability to manipulate which main screen editor is displayed and whether the editor takes up the window's space or not. This also applies to a plugin's custom editor.

I have swapped the p_name == "" check around and added ERR_FAIL commands in to produce visible errors in the erroneous use cases. I also updated the name in the EditorPlugin/scripting API to not use the _by_name suffix. However, the EditorNode has an _editor_select() method that accepts an index into the list of toolbuttons at the top. Since plugins don't know where they fall within that list, I thought it better to let them switch contexts based on the name of the context/editor rather than its position in the list, hence the addition of the _by_name suffix for the EditorNode method.
Let me know what you think.


HLS Player Not supported

Package isn't working with HLS player as showed in the docs

i'm running m3u8 perfect without any problem. Just repeat the documentation.


No Notifications in Android P

Version 2.0.1 on Android P PPP2.180412.013
Unable to turn Notifications on - the app makes no notifications, and in App Info it is set to off.

I have also noticed this on 8.1.0(OPM4.171019.016.B1) running on a Pixel 2 also on Keybase 2.0.1.


feat!: make data commitments end exclusive

Description
excludes the end block for data commitments
#1008

changed all names to start, end https://github.com/celestiaorg/celestia-core/pull/1012/commits/ea8978b759913b26169a4455ba17abe74146735b

good catch! https://github.com/celestiaorg/celestia-core/pull/1012/commits/df2f6483678fe5072132e1625a5585347718373e


Is it possible to have multiple models in RxTableViewSectionedReloadDataSource?

Hi
Consider the following scenario: I have a table view that contains 2 sections. Section 1 contains multiple products (Product model) and Section 2 contains multiple payment methods (PaymentMethod model). How can I create an Rx-based DataSource that contains both models so that I can display their appropriate cells/data in the tableview?
Thanks for the great library. It's awesome!
—Kishyr

Hi @kishyr ,
you can model your sections and items as enums :) That would solve your issues I believe.

Hi @kzaher,
Thanks for replying! The problem comes in when trying to bind a ViewModel to a TableView using rx_itemsWithDataSource.
For example, given RxTableViewSectionedReloadDataSource<SectionModel<String, Product>> as a datasource, and a PublishSubject<[SectionModal<String, Product>]> as a ViewModel, I'm not sure how to use enums in this instance. How would I bind/send/set the products, and payment methods to the tableview?

Hi @kishyr ,
I would suggest taking a look at example app inside this repo, or maybe providing a more detail explanation of problem you are experiencing.

Hi, guys
Looks like this is pretty common problem, for users of the library :) I remember couple weeks ago some guys asked this question on the main repo.
Maybe we could implement this in the example app, what do you think @kzaher? I could spend some time this week to do this:)

@sergdort that would be fantastic!
I tried to create an enum type which conformed to SequenceType and set that as array-type item in the SectionModel (CheckoutReviewItem below), but because it's expecting an array, and not something that conforms to SequenceType, it doesn't work.
var reviewDataSource = RxTableViewSectionedReloadDataSource<SectionModel<String, CheckoutReviewItem>>()
var reviewTableViewModel = PublishSubject<[SectionModel<String, CheckoutReviewItem>]>()
...
let productsModel = SectionModel(model: "Products", items: CheckoutReviewItem.Product(products))
let pricesModel = SectionModel(model: "Payment Methods", items: CheckoutReviewItem.PaymentMethod(paymentMethods))
self?.reviewTableViewModel.onNext([productsModel, pricesModel])

(products and paymentMethods are arrays)
Basically, the second parameter of SectionModel is what I'm confused about. If I need to send each tableview section a different array of objects (in my case, arrays of Product and PaymentMethod), how could it be done?

Thanks @sergdort! This is exactly what I was looking for :-)

Hey guys,
Struggling to do something similar to this, although I want to add cells of different types to one section. Is this possible? My confiureCells isnt being called.
Tom


Remove docker dependencies from Makefile

We should remove any dependencies from docker in the Makefile. In case we need to take care of a "non standard" environment or a specific need than we will have to isolate the required changes:

either creating a different Makefile (for example Makefile.docker)
or adding specific rules
or - finally - adding ad-hoc directives and variables
Default rules and standard behavior for the Makefile should work on a "normal" Linux system.

Maybe we can try compiling locally if VERTICA_VERSION and OSTAG are not set.  Then, if it fails, we can suggest to set VERTICA_VERSION and OSTAG.

The result of compilation should be the result of a precise and conscious choice of the user. I want to obtain THIS rather than THAT. Different Makefiles with different names are probably easier to maintain but also a single makefile with different rules is OK because the user will decide "make this" rather than "make that".

I think it might be simpler to build locally unless the user says to build to a specific version/OS.  I'll make a PR and see if you like it.


⚠ ClamAV has degraded performance

In 0efb6cb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 196 ms

Resolved: ClamAV performance has improved in 78880bb.


[Accessibility][Functional - Settings -Onboarding]: No action is performed on activating Onboarding 'Enabled' toggle button.

User Experience:
For keyboard users it is difficult to perform the task if any control does not perform its functionality.
Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19569.1000)
Microsoft Edge Version: 82.0.436.0 (Official build) canary (64-bit)
Test URL: http://localhost:3000/home
Repro Steps:

Open URL: http://localhost:3000/home
"Bot Framework Composer" homepage will gets opened.
Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
Select 'Settings' from left navigation.
Select 'Onboarding' button available under 'Configuration'.
Observe the issue on activating Onboarding 'Enabled' toggle button.

Actual Result:
No action is performed on activating Onboarding 'Enabled' toggle button. As it is mentioned in text that 'Enabling Onboarding will restart the product tour' but no actioned is performed.
Expected Result:
Action should be performed on activating Onboarding 'Enabled' toggle button.
Attachment:
Functional_Settings_Onboarding.zip

I don't believe this scenario prompts a restart of the app. My understanding is that onboarding is re-enabled, and prompts will show up again on the UI. (when navigating to other parts of the app)
I believe this trigger should have an screenreader announcement saying it is enabled or disabled, but there is no need to cause a refresh.
Could a developer confirm the expected behavior here? :) In terms confirming visually the change, I'm not quite sure what the ideal solution would be.
Would it be beneficial to have a toast as a confirmation that the setting has changed? This would provide extra visual feedback, and provide a placeholder of the aria-live text for the screenreader to announce the change in state.

I'll take a stab at this - I see something that should be useful here, although I'll want a designer to take a look at it to confirm it works well and looks good.

As checked and verified on below environment, the issue is fixed now. So, we are closing the issue.
Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here


Drop test coverage for Ruby 1.9

Ruby 1.9 went end-of-life over a year ago. This PR drops Travis dependency for Ruby 1.9, although it may continue to work.

:+1:


Show with a quote not recognized

When the show name contains a quote (Marvel's, Grey's Anatomy, ...) it's not recognized correctly.

Should be fixed in 2.0.0

Oops, actually fixed in 2.0.1


use json endpoints to avoid redirection

depends on https://github.com/crowbar/crowbar-core/pull/453 (and its backport, https://github.com/crowbar/crowbar-core/pull/454 which doesn't exist yet)

retriggered upgrade gating, as dependent PR is merged

Awesome job, cool +1

:+1:


Mouseover pause

When I wanted to use this awesome code I missed a pause on mouseover!
I forked your code to add this. My first pull request on Git so if you have tips or tops i'm open.

Nice work!
It's always a good feeling to get your first contribution underway!


Automated Package Upgrade

:tada: This PR is included in version 25.3.477 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Preparing rollup to use firebase-notifications

Added rollup-plugin-node-resolve to improve package resolution
Added rollup-plugin-commonjs to make rollup compatible with
commonjs module.export style (used by firebase)

@ithinkihaveacat I'm adding this to pave the way to add firebase to the frontend. PTAL.


Ui scroll behaviour is funky

As with #6272 the Ui coordinate system changes from #6000 have caused the Ui scroll behaviour to be flipped. Noticeable in the ui example.

Aside from scrolling in the wrong direction, when a line of text is partially visible it aligns to the bottom which is incorrect/different to the prior behaviour

This should be closed as per #6290.

No, the issue in https://github.com/bevyengine/bevy/issues/6287#issuecomment-1281828797 remains


Optimalization, unit tests.

Should fix #142.
Need more unit tests for plugin manager but that can be done in other PR.
I was doing that on top of #145.

I can't figure out how to submit corrections, so instead I'll just bounce these back to you to patch. (Man, I really need to improve my git-fu.)
https://github.com/8r2y5/StarryPy/blob/feature/142/plugins/poi_plugin/poi_plugin.py#L25
replace
with open(os.path.join('config', 'pois.json')) as f:

with
with open(os.path.join('config', 'pois.json'), 'r') as f:

https://github.com/8r2y5/StarryPy/blob/feature/142/plugins/poi_plugin/poi_plugin.py#L98
Remove this line, correct the indentation on the line below it to match.
https://github.com/8r2y5/StarryPy/blob/feature/142/plugins/poi_plugin/poi_plugin.py#L176
replace
with open(os.path.join('config' 'pois.json', 'wb')) as f:

with
with open(os.path.join('config', 'pois.json'), 'wb') as f:


Bug: Registration doesn't work: "$user->id is null. You should not use the incomplete User object."

PHP Version
8.1
CodeIgniter4 Version
4.3.2
Shield Version
latest dev branch c561109
Which operating systems have you tested for this bug?
Linux
Which server did you use?
apache
Database
MySQL
Did you customize Shield?
No
What happened?
When you try to register via the default registration form, an error occurs:
CRITICAL - 2023-03-02 18:35:46 --> "$user->id" is null. You should not use the incomplete User object.
in /home/mydir/vendor/codeigniter4/shield/src/Models/UserIdentityModel.php on line 85.
1 /home/mydir/vendor/codeigniter4/shield/src/Models/UserIdentityModel.php(235): CodeIgniter\Shield\Models\UserIdentityModel->checkUserId(Object(CodeIgniter\Shield\Entities\User))
2 /home/mydir/vendor/codeigniter4/shield/src/Entities/User.php(87): CodeIgniter\Shield\Models\UserIdentityModel->getIdentities(Object(CodeIgniter\Shield\Entities\User))
3 /home/mydir/vendor/codeigniter4/shield/src/Entities/User.php(101): CodeIgniter\Shield\Entities\User->populateIdentities()
4 /home/mydir/vendor/codeigniter4/shield/src/Entities/User.php(72): CodeIgniter\Shield\Entities\User->getIdentities('email_password')
5 /home/mydir/vendor/codeigniter4/shield/src/Entities/User.php(140): CodeIgniter\Shield\Entities\User->getIdentity('email_password')
6 /home/mydir/vendor/codeigniter4/shield/src/Entities/User.php(220): CodeIgniter\Shield\Entities\User->getEmailIdentity()
7 SYSTEMPATH/Entity/Entity.php(493): CodeIgniter\Shield\Entities\User->getEmail()
8 /home/mydir/vendor/codeigniter4/shield/src/Authentication/Passwords/NothingPersonalValidator.php(58): CodeIgniter\Entity\Entity->__get('email')
9 /home/mydir/vendor/codeigniter4/shield/src/Authentication/Passwords/NothingPersonalValidator.php(27): CodeIgniter\Shield\Authentication\Passwords\NothingPersonalValidator->isNotPersonal('nh8tve37abhcfux', Object(CodeIgniter\Shield\Entities\User))
10 /home/mydir/vendor/codeigniter4/shield/src/Authentication/Passwords.php(103): CodeIgniter\Shield\Authentication\Passwords\NothingPersonalValidator->check('nh8tve37abhcfux', Object(CodeIgniter\Shield\Entities\User))
11 /home/mydir/vendor/codeigniter4/shield/src/Authentication/Passwords/ValidationRules.php(45): CodeIgniter\Shield\Authentication\Passwords->check('nH8tve37abHCfUX', Object(CodeIgniter\Shield\Entities\User))
12 SYSTEMPATH/Validation/Validation.php(311): CodeIgniter\Shield\Authentication\Passwords\ValidationRules->strong_password('nH8tve37abHCfUX', null)
13 SYSTEMPATH/Validation/Validation.php(170): CodeIgniter\Validation\Validation->processRules('password', 'Auth.password', 'nH*8tve37abHCfUX', [...], [...])
14 SYSTEMPATH/Controller.php(140): CodeIgniter\Validation\Validation->run()
15 /home/mydir/vendor/codeigniter4/shield/src/Controllers/RegisterController.php(102): CodeIgniter\Controller->validate([...])
16 SYSTEMPATH/CodeIgniter.php(934): CodeIgniter\Shield\Controllers\RegisterController->registerAction()
17 SYSTEMPATH/CodeIgniter.php(499): CodeIgniter\CodeIgniter->runController(Object(CodeIgniter\Shield\Controllers\RegisterController))
18 SYSTEMPATH/CodeIgniter.php(368): CodeIgniter\CodeIgniter->handleRequest(null, Object(Config\Cache), false)
19 FCPATH/index.php(67): CodeIgniter\CodeIgniter->run()
Steps to Reproduce

Comment out email from $validFields array in Config/Auth.php
Keep/Add NothingPersonalValidator to $passwordValidators in the same file
Try to register as a new user

Expected Output
The registration to be completed successfully.
Anything else?
No response

Okay so I did some debugging and it seems like the issue only occurs when:
You comment out "email" from $validFields array in Config/Auth.php, and also have NothingPersonalValidator class added to the $passwordValidators array.

At least you need to use Codeigniter v4.2.7 or later.
https://github.com/codeigniter4/shield/blob/develop/docs/install.md#requirements

the problem seems to be that when you comment out email from $validFields array, then it is not added to the User entity object because of this function:
src/Authentication/Passwords/ValidationRules.php:
protected function prepareValidFields(): array
    {
        $config   = config('Auth');
        $fields   = array_merge($config->validFields, $config->personalFields);
        $fields[] = 'password';

        return $fields;
    }

since this returns all the valid fields that can be in the post request as keys, and email is commented out, it is not added here. Hence when a User entity is created, the email field is left out (or set to empty as default value in the User class itself). Here is the function which creates this User object:
src/Authentication/Passwords/ValidationRules.php:
protected function buildUserFromRequest(): User
    {
        $fields = $this->prepareValidFields();

        /** @var IncomingRequest $request */
        $request = service('request');

        $data = $request->getPost($fields);

        return new User($data);
    }

Now, the NothingPersonalValidator requires an email to be present and not empty. And if it is not present then it tries to search for the user's email in the database which at this point is not there as the user is just registering.
src/Authentication/Passwords/NothingPersonalValidator.php
`public function check(string $password, ?User $user = null): Result
{
$password = strtolower($password);
    if ($valid = $this->**isNotPersonal**($password, $user) === true) {
        $valid = $this->isNotSimilar($password, $user);
    }

    return new Result([
        'success'   => $valid,
        'reason'    => $this->error,
        'extraInfo' => $this->suggestion,
    ]);
}`

protected function isNotPersonal(string $password, ?User $user): bool     {         $userName = strtolower($user->username ?? '');         $email    = strtolower(**$user->email**);         $valid    = true;         // rest of the code of this function
$user->email points to this:

*src/Entities/User.php*
public function getEmail(): ?string
    {
        if ($this->email === null) {
            $this->email = $this->**getEmailIdentity**()->secret ?? null;
        }

        return $this->email;
    }

At least you need to use Codeigniter v4.2.7 or later. https://github.com/codeigniter4/shield/blob/develop/docs/install.md#requirements

sorry for the confusion, i am already using 4.3.2. i entered an incorrect version in my op. updated it now.

Something like this?
--- a/src/Authentication/Passwords/ValidationRules.php
+++ b/src/Authentication/Passwords/ValidationRules.php
@@ -89,10 +89,9 @@ protected function buildUserFromData(array $data = []): User
      */
     protected function prepareValidFields(): array
     {
-        $config   = config('Auth');
-        $fields   = array_merge($config->validFields, $config->personalFields);
-        $fields[] = 'password';
+        $config = config('Auth');
+        $fields = array_merge($config->validFields, $config->personalFields, ['email', 'password']);

-        return $fields;
+        return array_unique($fields);
     }
 }

Something like this?
--- a/src/Authentication/Passwords/ValidationRules.php
+++ b/src/Authentication/Passwords/ValidationRules.php
@@ -89,10 +89,9 @@ protected function buildUserFromData(array $data = []): User
      */
     protected function prepareValidFields(): array
     {
-        $config   = config('Auth');
-        $fields   = array_merge($config->validFields, $config->personalFields);
-        $fields[] = 'password';
+        $config = config('Auth');
+        $fields = array_merge($config->validFields, $config->personalFields, ['email', 'password']);

-        return $fields;
+        return array_unique($fields);
     }
 }

yes i was thinking the same.. 👍🏻

I have a question.
I want to register users using a username, not an email.
There is a similar issue as mentioned.
Can the source code mentioned as @liamsyh solve this problem?
Do I need to wait for it to be included in the release?

PHP Version
7.4.9
CodeIgniter4 Version
4.4.1
Shield Version
v1.0.0-beta.6
I recently started using Shield. I need a feature to log in using a username instead of an email. I tried the following method from this link: https://github.com/codeigniter4/shield/discussions/323.
I also tried the method mentioned in the issue above. When registering, I encounter the following error:
"$user->id" is null. You should not use the incomplete User object.
I've tried various solutions, and it seems to be a problem with the code in these locations:
In vendor\codeigniter4\shield\src\Entities\User.php:
public function setEmail(?string $email): void
{
    $this->email = $email;
}

In vendor\codeigniter4\shield\src\Models\UserIdentityModel.php:
private function checkUserId(User $user): void
{
    if ($user->id === null) {
        throw new LogicException(
            '"$user->id" is null. You should not use the incomplete User object.'
        );
    }
}

It appears that the issue lies in these code sections. Specifically, it seems that the recent update to Shield has caused the login using a username instead of an email to not work at all.
Could someone please provide guidance on how to make the login using a username work in the latest version where it has been successful for someone else?

@yuyake shield does not allow you to send an empty email field. This is because the email field must be unique. When you try to send an empty field, there will be a problem in the second registration because two null fields are registered in the table.
https://github.com/codeigniter4/shield/blob/306616cb8486f8715f40d633d9089abe6f6dd7b7/src/Database/Migrations/2020-12-28-223112_create_auth_tables.php#L72-L72
I suggest that if you don't want to receive email from the user, send some email incognito.
for e.g.
<EMAIL_ADDRESS>see(https://codeigniter.com/user_guide/helpers/text_helper.html#id2)
Regarding login with username, $validFields , as its name suggests, allows login with fields, not allows registration with a specific field.
https://github.com/codeigniter4/shield/blob/306616cb8486f8715f40d633d9089abe6f6dd7b7/src/Config/Auth.php#L276-L285
The image below shows login with username.
https://github.com/codeigniter4/shield/assets/9530214/86a85c25-f87e-4f3f-8719-5deeb2c52d5a

@yuyake shield does not allow you to send an empty email field. This is because the email field must be unique. When you try to send an empty field, there will be a problem in the second registration because two null fields are registered in the table.
https://github.com/codeigniter4/shield/blob/306616cb8486f8715f40d633d9089abe6f6dd7b7/src/Database/Migrations/2020-12-28-223112_create_auth_tables.php#L72-L72
I suggest that if you don't want to receive email from the user, send some email incognito.
for e.g<EMAIL_ADDRESS>see(https://codeigniter.com/user_guide/helpers/text_helper.html#id2)
Regarding login with username, $validFields , as its name suggests, allows login with fields, not allows registration with a specific field.
https://github.com/codeigniter4/shield/blob/306616cb8486f8715f40d633d9089abe6f6dd7b7/src/Config/Auth.php#L276-L285
The image below shows login with username.
Recording.2023-09-06.175417.mp4

Here is the translation in English:
Thank you for your response.
My issue has been resolved.
For the login method that doesn't use email, I also assumed that it wouldn't involve using email during user registration. I will follow your suggested method to register with a random email.
Thank you once again!

I sent a PR to fix this bug: #829


Add constructor argument to the deprecation warning

I feel it would be helpful if the #1407 deprecation warning printed to the console also indicated the failing argument passed to the constructor – particularly for cases where moment.js is minified in a production build and debugging is not readily available.
I would guess this would be changing warn(msg) to also print the constructor argument passed, but it's not clear what effect that may have on other deprecation warnings.
:beers:

I think that makes sense. Would take a PR!

This issue should be closed, its been resolved in #2723

Thanks @aysark —  I'll close this on the basis of your comment, but of course please feel free to re-open if I'm mistaken or there's a need.
Cheers.

Well... i was going to work on it and then checked the code and looks like @calebcauthon solved it.
It may not be in the production release yet however.


spec runner depends on libxml

To run specs, you need to require spec which includes junit_formatter. That formatter requires xml which depends on libxml2 being available. That package is not installed by default - at least not on Debian/Ubuntu or homebrew (the APT package has it as a a suggested dependecy). Didn't check others but I don't expect them to be different.
This means, right after installing Crystal using the provided packages, you're not able to run specs. Instead the compiler will print a very cryptic error message (like posted in #5658):
/usr/bin/ld: cannot find -lxml2
collect2: error: ld returned 1 exit status
Error: execution of command failed with code: 1: `cc "${@}" -o '/home/Mead/.cache/crystal/crystal-run-spec.tmp'  -rdynamic  -lxml2 -lpcre -lm -lgc -lpthread /usr/share/crystal/src/ext/libcrystal.a -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

For beginners, this is not trivial to understand. The error message could obviously be improved (see #5291) but that won't solve the problem that you can't use a major feature without manually installing additional libraries.
This is especially iffy considering the JUnit formatter is a very specific feature and won't be needed for most use cases at all.
A possible solution would be to include libxml2 in the dependencies of the OS packages for Crystal. But I don't think that's the best way because many developers probably won't really use xml anyway so it'd just add an unneccesary dependency.
I think it would be better to make the junit formatter optional. Specs are usually compiled and run using crystal spec, so it should be possible to only require junit_formatter in the code being compiled if it is configured to use that formatter (as CLI argument).
Or remove it entirely from the stdlib into a shard as suggested in #5215.
Related to #5291

No, go ahead ;)

@luislavena any news here? it seems we get more people running into this issue

@bararchy my first attempt was to refactor spec runner in #5763 but didn't move forward due bad reception from the team.
It seems #6004 proposes a direct change to the formatter, which most likely will get merged before mine.
Cheers.

@bararchy my first attempt was to refactor spec runner in #5763 but didn't move forward due bad reception from the team.

To be correct, just from @RX14, not the whole team. Given the positive number of 👍/ ❤ it received I reckon it should be followed up upon.

@Sija not criticizing, but definitely will send a RFC about complete changes in Spec CLI to be able to test and hook it more easily.
But will do that once I have time, lately busy with real life 😁

Yeah, I guess it makes sense to discuss some ideas about further improvements for specs first :+1:


Document Unreal Engine support

Cryptomatte renders are now supported in Unreal Engine 4.26, addresses
issue #130.
Signed-off-by: Jean-Francois Panisset<EMAIL_ADDRESS>

Thanks JF! This is already done in the dev branch (in fact, verbatim). It'll be in the next release.


Use yaml.v3 library instead of yaml.v2

🚀 Feature Request
Relevant Package

 This feature request is for core-metadata
Description
We have a dependency using yaml.v3 and our code is using yaml.v2, so we have both library in our build.
We should use only one of them.

hold this issue until yaml v3 is official released

hold this issue until yaml v3 is official released


AngularJS - xdLocalStorageProvider.init() is called after the module.run() and controller initialize

Hello :)
I am trying to use xdlocalstorage with angular an controller but it seems like the iframe is being loaded after the app has run and controller has initialized causing the error
can you please provide some guidance
here is my code, that is based on the xdlocalstorage documentation
var module = angular.module('app', ['xdLocalStorage'])
.config(function (xdLocalStorageProvider) {
xdLocalStorageProvider.init(
{
/* required */
iframeUrl: "http://localhost:58935/iframe.html",
//an option function to be called right after the iframe was loaded and ready for action
initCallback: function () {
console.log('Got iframe ready');
xdLocalStorage.setItem('iframe', 'iframe');
}
});
}).run(function () {
console.log("Hello from app run");
}
).controller('IndexController', ['xdLocalStorage', function (xdLocalStorage) {
console.log("Hello from index controller");
xdLocalStorage.getItem('iframe'); // throw init error

}]
);
and here is the console log
Hello from app run
Hello from index controller
You must call xdLocalStorage.init() before using it.
Got iframe ready

Hi @reggieboyYEAH , thanks for pointing out the problem. I did a new major release (version 2.0.0) and now the angular service xdLocalStorage uses promises instead of ugly callbacks :).
I also moved the init function to the regular run because I needed it to resolve the iframe load promise.
I updated the docs so u can take a look in the new implementation. I hope it will help u. LMK otherwise.

Hello @ofirdagan, first of all thanks for updating the framework :+1:
But im still having issues, the iframe loads very late in the process causing undefined variables.
here is my code
var module = angular.module('app', ['xdLocalStorage'])
.config(function (xdLocalStorageProvider) {
}).run([
    'xdLocalStorage', function(xdLocalStorage) {
        console.log("Hello from app run");
        xdLocalStorage.init(
        {   /* required */
            iframeUrl: 'http://localhost:58935/iframe.html'
        }).then(function() {
            //an option function to be called once the iframe was loaded and ready for action
            console.log('Got iframe ready');
        });

    }
]).controller('IndexController', [
        'xdLocalStorage', function(xdLocalStorage) {
            console.log("Hello from index controller");

            ////xdLocalStorage.setItem('iframe', 'iframe');

            xdLocalStorage.getItem('iframe').then(function(response) {
                console.log(response.value);
            });

        }
    ]
);

and the output will be
Hello from app run index.js:18
Hello from index controller
angular.js:12116 TypeError: Cannot read property 'contentWindow' of undefined
at buildMessage (ng-xdLocalStorage.min.js:78)
at window.xdLocalStorage.window.xdLocalStorage.getItem (ng-xdLocalStorage.min.js:137)
at ng-xdLocalStorage.min.js:193
at angular.js:14347
at m.$get.m.$eval (angular.js:15574)
at m.$get.m.$digest (angular.js:15385)
at m.$get.m.$apply (angular.js:15679)
at angular.js:1582
at Object.e [as invoke] (angular.js:4379)
at d (angular.js:1580)(anonymous function) @ angular.js:12116$get @ angular.js:8976(anonymous function) @ angular.js:14355$get.m.$eval @ angular.js:15574$get.m.$digest @ angular.js:15385$get.m.$apply @ angular.js:15679(anonymous function) @ angular.js:1582e @ angular.js:4379d @ angular.js:1580uc @ angular.js:1600Td @ angular.js:1494(anonymous function) @ angular.js:27867a @ angular.js:2927c @ angular.js:3201
index.js:12
Got iframe ready
It seems like an angular issue. The angular.run() does not wait for a promise to be resolved.
https://github.com/angular/angular.js/issues/4003
i think the workaround is to bootstrap angular manually.
Not sure if there is a way that we can integrate that in the framework.
Do you have any recommendations?
I will try some approach and will let you know.
Cheers!

Hey @reggieboyYEAH , I didn't know about this issue but a nice solution can be using the resolve option when u create IndexController. I'm guessing that u use routing of some sort.
Check out this video which explains it.
https://www.youtube.com/watch?v=Kr1qZ8Ik9G8&feature=player_embedded
I hope it helps :)

Hi @ofirdagan, I tried the routing resolve approach but unfortunately it didn't work for me. It does not resolve values from xdlocalstorage.
I ended up using the deferred bootstrap approach.
https://github.com/philippd/angular-deferred-bootstrap
And now it works.
Thanks for the help! Appreciated :)


mvn clean package  target

编译这个 为什么会出现
Unknown lifecycle phase "target".
You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, generate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1]

target 是 输出路径 不是mvn的参数


Improve the storage API

See: https://github.com/mohiva/play-silhouette/issues/326

Coverage increased (+2.82%) to 100.0% when pulling 53c4da9c92a14524ec35ad165d91add7afaf32c7 on akkie:storage-api-improvements into 33662e14fd72429291b1a4fb98ebd96ac934cab5 on mohiva:master.

Perfect, I'm definitely looking forward to this. Looks like you also decided in favor of the repository pattern, which does the job of keeping the API clear.
Based on the changes, am I correct in assuming that this change will require Play 2.4?

@nadirabid Yes, all new features will go into the next 3.0 release which addresses mainly Play 2.4.


RF: Increase the dataset size of dev-check test

Does this fix the sporadic IC/DC issues that we have been seeing with RF?

I hope so. I tried over 3000 runs with this fix in and did not get a single error.

in that case LGTM


[SP-3701] Backport of PDI-13227 - join rows step - after changing the steps on incoming hops, step gets into undefined / not working state (6.1 Suite)

backport of #4147

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f core/build.xml clean-all resolve jacoco && ant -f core/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  core/src/org/pentaho/di/core/Condition.java
  core/test-src/org/pentaho/di/core/ConditionTest.java

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.core.Condition

Branch Change:  + 5.41%
Complexity Change:  + .73%
Instruction Change:  + 5.27%
Line Change:  + 6.72%
Method Change:  + 1.92%

@pamval @mchen-len-son @mbatchelor @stepanovdg please review


Borders and Decorations

Allow users to add borders or other decorative elements to their ASCII art.

I add a  function on allowing users to add borders to their ASCII art.

Could you please explain more on how did you work on that?

I've added a function add_border which takes the ASCII art and a border character, then adds a border made of that character around the ASCII art. The main function has been updated to ask the user if they want to add a border and, if so, what character to use for the border.

okey, thanks so much!! I will verify it.


Add billing query for VSHN PostgreSQL standalone

Summary
This PR adds a query so that we can bill VSHN managed PostgreSQL on APPUiO Cloud-
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update tests.

For aldebaran this is more of an informational review request that you are aware of this addition.


fix(rules/Set Setuid or Setgid bit): use chmod syscalls instead of chmod command

Signed-off-by: Lorenzo Fontana<EMAIL_ADDRESS>What type of PR is this?
/kind bug
/kind rule-update
Any specific area of the project related to this PR?
/area rules
What this PR does / why we need it:
The "Set Setuid or Setgid bit" rule is using a check on the invocation of the chmod command in order to check if a suid or sgid flag is applied to a file.
That method is ineffective because anyone using the raw syscall or glibc can bypass that.
For example:
#include <sys/stat.h>
#include <fcntl.h>

int main ()
{
  fchmodat(AT_FDCWD, "/tmp/yo", S_ISUID, 0);
}

This PR uses the newly added fchmod, chmod, fchmodat syscalls (to sysdig)
in order to avoid that.
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Only works if sysdig PR https://github.com/draios/sysdig/pull/1472 is merged. It adds support to the chmod syscalls we are using here.
Does this PR introduce a user-facing change?:
rule(Set Setuid or Setgid bit): syscalls are used to detect suid and sgid

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kaizhe I noticed that the previous rule used a macro consider_all_chmods to disable it. I added the same macro I'm just unsure if we still need it. Can you confirm why we need it? Thanks

/assign @Kaizhe

I would also increment the required engine version, as you depend on the changes in https://github.com/draios/sysdig/pull/1472 to be effective. Once the sysdig PR is merged you’ll have to increment the falco engine and checksum anyway.

@fntlnz good changes, couple requests here:

Post the rule triggered output here to make sure the rule still works as expected.
I would like to to turn it on, so replace never_true to always_true
Add a customized macro user_known_chmod_applications

Here is the outputs @Kaizhe
Rule output examples
chmod
Syscall
chmod("/tmp/test", 04000)

Output
19:30:43.073551187: Notice Setuid or setgid bit is set via chmod (fd=<NA> filename=/tmp/test mode=S_ISUID user=ubuntu command=a.out container_id=host container_name=host image=<NA>:<NA>)

fchmodat
Syscall
fchmodat(AT_FDCWD, "/tmp/ciao", 04000)

Output
19:31:04.851600216: Notice Setuid or setgid bit is set via chmod (fd=<NA> filename=/tmp/ciao mode=S_ISUID user=ubuntu command=a.out container_id=host container_name=host image=<NA>:<NA>)

fchmod
openat(AT_FDCWD, "/tmp/test", O_RDWR)   = 3
fchmod(3, 04000)

Syscall
19:31:52.570751037: Notice Setuid or setgid bit is set via chmod (fd=<f>/tmp/test filename=<NA> mode=S_ISUID user=ubuntu command=a.out container_id=host container_name=host image=<NA>:<NA>)

/lgtm

LGTM label has been added.  Git tree hash: ed88949aef039cf5a7a9463e3af82a935a69718a

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Kaizhe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [Kaizhe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Kaizhe, leodido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

rules/OWNERS [Kaizhe,leodido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can't generate recource Ore

I'm running on TC 2.8.0 and Spigot 1.9.2-R0.1-SNAPSHOT.
And I am trying to generate a new Ore. For this I have added the line "Ore (GLOWSTONE, 2,1,20.0,0,64, STONE)" in each Biome. But no Glowstone is generated.

(We must have missed this issue. I don't think @Wolf2323 is still interested in a solution, but I'm replying here anyways in case someone with a similar problem finds this page using a Google search.)
I think the space between Ore and the ( is the problem.
I would just copy the line with the DIRT ore from one biome, then put it into your biome, and replace DIRT with GLOWSTONE.


Python 3.11/3.12 support

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Currently CG support up to Python 3.10
Describe the solution you'd like
A clear and concise description of what you want to happen.
Need to add support for Python 3.11/3.12, specially in unittest and integration
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Refer to PR# 794


interface that extends Generic class

React + Typescript
TS: 3.5.2
React: 16.8
@types/react: 16.8.22
Any Class component extends  the next type from @types/React
type JSXElementConstructor<P> = (new (props: P) => Component<P, any>)
What type is extending any  Generic class component
ex. class Card<T extends 'div' | 'p'>  extends React.Component<CardProps<T>> {...}
application:

in conditional types
transfer constructor function as props
extract props types of component

Please follow one of the available templates and provide more context and detail in the report.


fix:1305 Update user serverside on edit profile

Description
Add a server mutation on EditProfile
Related Ticket

Resolves #1305

Closing this as it's super stale.. User tests will hopefully expose any issues here


using the new TensorFlow SavedModel API

This solves the problem from Microsoft/MMdnn#117 plus it is the recommended way to save a model in TensorFlow which is described in their documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: marvinrichter sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the contribution. Already changed in current version.


PDF to text extraction quality

Multiple columns
other std. issues

New requirement:

extract text by paragraph
group by page


Update quickstart-linux.md

Raspbian has some additional prerequisites which are not documented here. They are documented on pypi, but are not very discoverable. We've had requests to add the information to this document so more people will see it.

@damonbarry : Thanks for your contribution! The author, @kgremban, has been notified to review your proposed change.

Thanks @damonbarry
#sign-off

@damonbarry : Thanks for your contribution! The author, @kgremban, has been notified to review your proposed change.


Unstable E2E: checkout-as-persistent-user.e2e-spec.ts

regression/checkout-as-persistent-user.e2e-spec.ts failed when running locally.
1) 576p resolution - Checkout with persistent user Checkout Flow should display summary page:
    CypressError: Timed out retrying: Expected to find element: '.cx-page-title', but never found it.

Cannot repro and unsure what the issue is.
Closing.


docs is missing

add few comments to start work on that

Docs will be added ASAP. Do contribute to the project once we finalize functions of the CLI.

Sure, well i have some previous experience working on Docs for angularJS, ReactJS Translation.


Enhancement to Download to CSV

When you have made a selection of curves in a log (including the edge case that you have selected all curves), then you click the "Download all as .csv" button (already implemented). You will then get a popup window with options:
For the selected Log Curves:

Download all data (not only first 10000 as displayed)
Download the interval of data between the start and end index in the Content Window
Download selected index values

The user will select from these 3 options and hit OK or Cancel button.

Download options:

Download shown interval
Download selected
Download all data (minIndex to maxIndex for all listed mnemonics, max 5'000'000 datapoints)


How can we integrate with spring security

How can we wire netty-socketio to use spring security . We need to use JSESSIONID to identify the user but how do we get the id from  netty-socketio. I think netty-socketio generates its own UUID can  we make it use JSESSIONID instead if so how do we do it

This involves exposing the JSESSIONID to the client which is incredibly insecure. Is there no better way?

@Sinistralis you need an access to httpheaders?

@mrniko I'm honestly not sure. I pulled down sources and was mucking around in the AuthorizationHandler in your Netty Pipeline and it was not receiving the JSESSIONID in that header at all. That might be an implementation fault on my own end though. My suspicion is that since the server runs on a separate port than the HTTP server, the request doesn't pass up the cookie/header, which is something I'm not sure how to work around.

After some more experimenting, I found a way to get context of the JSESSIONID from the HTTP request, but I'm not sure if I like it or how viable it is outside of localhost.
The JSESSIONID specifically wants a hostname and contextpath match. The port doesn't matter, so as long as you connect to the same domain and path as your spring security root, you will have context of the JSESSIONID on the AuthorizeHandler (which needs forwarded to the AuthorizationListener).
Example:
www.domain.com/index (HTTP site root)
www.domain.com:8070/index (Netty-SocketIO Server Context)
At channelRead in the AuthorizeHandler, msg will contain your JSESSIONID.

Of course now the question is how to get the context

Do you mean the /index part of the url?

Oh no. I meant the session context since netty uses a custom http request
object. I don't think this would be a job for this library. Having the http
request in the AuthorizationListener would be awesome though. Want me to
put that together?
On Jul 10, 2015 2:38 AM, "Nikita Koksharov"<EMAIL_ADDRESS>wrote:

Of course now the question is how to get the context
Do you mean the /index part of the url?
—
Reply to this email directly or view it on GitHub
https://github.com/mrniko/netty-socketio/issues/110#issuecomment-120249697
.

Has there been any updates with this? Would be nice to see a small example of how to utilize spring security with this project as it's the security cornerstone of my project.


Pre lags 129

This feature branch will need to be checked out before running composer update - in order to pull in the updated idc-ui-theme and idc_ui_module code. The changes here are purely configurations to update the solr index, adjust the islandora object's default fields, set up a Date facet (*based off of the Solr Years value that is processed by the idc_ui_module).
This is for https://jhulibraries.atlassian.net/browse/LAGS-185 and https://jhulibraries.atlassian.net/browse/LAGS-129

After looking at the tests and a lot of discussions we feel like it's best to move forwards with this PR even with the test failing. A new ticket was created to address the issues with the tests. https://jhulibraries.atlassian.net/browse/LAGS-265


upgraded the databases to handle concurrent task state updates

closes #476
I opted to only enforce version checks for the state events for now. If we need to expanded it to all event types the pieces are now there to make it easy.
I ended up abstracting the retrier from the storage package into a general utility.

@buchanae since I generalized the retrier in this PR should I also address #475 since that code is changing here anyways?


New release of c-lightning-REST v0.10.0

There is new release of c-lightning-REST v0.10.0 - https://github.com/Ride-The-Lightning/c-lightning-REST/releases/tag/v0.10.0.
Core Lightning bonus guide likely needs to be updated. By somebody who uses CLN with RaspiBolt.

Ping @blckbx

There's some breaking changes in Core Lightning v22.11.0+, c-lightning-REST needs to be updated to v0.10.1. https://github.com/Ride-The-Lightning/c-lightning-REST/releases/tag/v0.10.1

PR updated, hotfix relates to offer api.

PR updated, hotfix relates to offer api.

Noticed Core Lightning bonus guide has v0.11.2 currently. Guess that also should be updated to newer version.

Noticed Core Lightning bonus guide has v0.11.2 currently. Guess that also should be updated to newer version.

Yes, that's mentioned in CLN-rest PR. PR is still waiting for approval (#1210)

Noticed Core Lightning bonus guide has v0.11.2 currently. Guess that also should be updated to newer version.

Yes, that's mentioned in CLN-rest PR. PR is still waiting for approval (#1210)

Sorry, missed that!

Nobody's fault. I was hoping for some testers.


Fix compatibility with Serverless v2.x.x

When using this plugin, it informs that "Serverless step offline requires Serverless v1.x.x but found 2.6.0"

Is there any information from the maintainer regarding upgrading this plugin to serverless > 2.0?

I'm getting a similar Serverless Error on the cli at runtime. "Serverless step offline requires Serverless v1.x.x but found 2.47.0"
It's a bit confusing as to what steps to take to fix the error.. downgrading Serverless main package?

Any news on this issue? Thanks!

Any news? getting the same with v3
Serverless step offline requires Serverless v1.x.x but found 3.21.0

Getting similar issue
Offline requires Serverless v1.x.x but found 3.22.0. Exiting.
Any luck?

yarn add serverless-offline@lts did it for me

Hi, just following up on this as it seems to keep failing even with the 12.0.4 serverless offline version and I'm getting the same error that people mentioned above


no_matching_hook_found on VerneMQ 1.7.1

Environment

VerneMQ Version: 1.7.1
OS: centos 7
VerneMQ configuration (vernemq.conf) or the changes from the default
Cluster size/standalone: 3 nodes

Behavior
This issue may refers to #1073 , but it happended on VerneMQ 1.7.1.
Vernemq.conf
Related content :
allow_anonymous = off
plugins.vmq_passwd = off
plugins.vmq_acl = off
plugins.vmq_diversity = on
plugins.vmq_webhooks = on
vmq_diversity.auth_redis.enabled = on

Detail logs
Some sensitive content was removed.
console.log
error.log
crash.log
erl_crash.dump.log

Hi, before diving into the logs could you explain what you are doing to get to this problem?

This problem appeared after a high server memory usage caused by another process, before this, the vmq service is normal.
The erl_crash.dump.log may help.

Hi, sorry for not getting back to this - judging from other issues I'd suppose you've found a workaround/solution for this - closing for now - feel free to reopen.

Hi, This problem arises again.  Since it comes unpredictablely, so I can't find a way to reproduce it.

Hi, without a way to reproduce it or more information helping us with this there's not much we can do here. There were some fixes done on the master branch which should make the Lua states handle errors better. Perhaps that helps.


Filterbar pass placeholder var

Hey Rati,
I added
<filter-bar placeholder="Search for brick"> to show correct tip in filter input. It also would be nice to add 'unit' var to <vuetable-pagination-info units="bricks"> so it will show Displaying 0 to 0 of 1352 bricks
I can send you a pull req.

@marekkaczkowski You can actually do that via info-template prop.
  <vuetable-pagination-info
    info-template="Displaying {from} to {to} of {total} bricks"
  ></vuetable-pagination-info>

Ah I missed that. :ok_hand:
Thank you for your time Rati!

Ah I missed that :ok_hand:
Thank you for your comment Rati!


Single runtime with multiple contexts - disposing context and avoiding memory leak

I am testing the chakra engine using the c# wrapper provided here. I have created a single runtime and I am then creating a new context for each script execution. (I have a requirement to run each script within a clean context). Unless I'm missing something, there doesn't seem to be a way to dispose of the context when I'm finished with it? As a result the process memory rockets up with each script invocation. At the moment I'm working around this by creating (and then disposing of) a new runtime for each script call but I imagine this creates an unnecessary (and probably quite heavy) performance overhead. It does however clean up memory!
Thanks,
Stuart

Hey @globeport. You don't have to explicitly dispose contexts are they are subject to GC. Chakra pins the current context (specified by JsSetCurrentContext) for you, and once you switch to a different context with another JsSetCurrentContext call, the previous context can be collected unless you explicitly pin it through JsAddRef (you can negate JsAddRef with JsRelease if you wish to dispose the context later).

Thanks for clarifying liminzhu. Each time i run a new script i set the current context to a new context, and at the end i call jssetcurrentcontext to clear the context. I had suspected that the context should be garbage collected (im not adding any references to it) but this doesnt happen. If i explicitly call collectgarbage on the runtime there is no reclaim of memory. I simplified things whereby i only run one script before dallocating the context. Still the runtime seems to be hanging on to it. Hmmm well it helps to know that it should be garbage collected when the current context is changed and that there is no requirement to formally dispose of it. Ill investigate a bit more.

No problem @globeport. If you still can't get the contexts to be collected and can create a small repo, I'm happy to take a look.

Thanks @liminzhu. I refactored my ChakraHost a little and now everything seems to be working. Memory is being freed just fine. So I don't know what I was doing. Thanks for you help in clarifying things!

No problem.


Support for jQuery 3 in dependencies

Hi,
We are using jQuery 3 in our project. But when resolving dependencies, NPM complains that angular-eonasdan-datetimepicker depends on jquery ~2. Can the dependency be changed to ">=2" instead? I currently see no problem. Or is there any?
Thanks in advance :)

Can't be, because the library does not support jQuery 3.

Well, currently using jQuery 3 with eodasan picker in the project with Your angular wrapper, and the picker behaves as expected. In Eonasdan picker, actually, they use jQuery ">=1.8.3" which, as Inderstand would allow jQ v3. Or am I missing something?

Picker.
https://github.com/Eonasdan/bootstrap-datetimepicker/issues/1751


⚠ Fortnite has degraded performance

In a416dd7, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1567 ms

Resolved: Fortnite performance has improved in 7e74d2a.


chore: remove execute from test fixtures

Adding changelog-ignore since the file mode of test fixtures is not really a user facing concern :)


use a binary in PATH

Feature Description
I would like to use gitlab.nvim with a prebuild binary "bin" (I dont have go in PATH). Is there a way to tell the plugin the path to the binary or have the plugin use the binary in PATH (but this may imply to change the name as "bin" is awkard)

Hey,
Having Go in your path is kind of a prerequisite for this plugin to work, because every time we release a new version (bug fixes, new features, etc) or you install the plugin, it'll rebuild the binary on your machine. If you're missing Go from your path then we can't trigger that build step.
You might be able to get around this by removing the build line from your configuration, and then changing into the directory of the Go source code (will depend on whether you're using Packer or Lazy) and building it yourself -- but in that case you're going to have to build the plugin on your machine using Go anyway.
We could try to support shipping binaries along with the plugin in the future, but that'd be a new feature (it would remove the Go dependency but would introduce a lot of complexity for different operating systems).

:wave:
Thank you for this awesome plugin!
I was wondering what was the motivations to have a Go server instead of using pure Lua to perform HTTP requests to the Gitlab instance, hence reducing external dependencies?
Was there a technical challenge that needed a middleware between Nvim and Gitlab? Or maybe is it just easier to implement the requests to Gitlab (e.g. using existing open source library like go-gitlab)?
Just curious, not asking to change anything :wink:

Hey @teto would you take a look at the attached MR and let me know whether this addresses your use case?
I'd like to avoid distributing binaries in the repository itself for the Go server if possible, since I think they may confuse the majority of users who are using the plugin as originally intended (allowing Lazy or Packer to rebuild the binary automatically).

@harrisoncramer ideally I install vim plugins with dependencies via my package manager nix https://nixos.org/. It has a lot of advantages compared to lazy.nvim & co (it's reproducible, I can cache binaries etc).
I like to configure the plugin without or complementary to nix though because it's easier to iterate on configuration. So I would like to be able to split my configuration for instance such that nix can assign the path to the binary in a generated init.lua via vim.g.gitlab.bin_path = .../bin while the rest of my config lives my init-manual.lua . The setup paradigm doesnt help in that regard, you can read https://mrcjkb.dev/posts/2023-08-22-setup.html for instance.
Alternatives that we use to package vim plugins in nix:

wrap the nvim executable with a PATH that contain the executable: works only if the plugin looks for executable in PATH
hardcode the path as done here for instance https://github.com/NixOS/nixpkgs/blob/d26c4cb24dbe52fac1fa660f21a561b25f711a5d/pkgs/applications/editors/vim/plugins/overrides.nix#L211

Okay! This isn't something I'm going to continue working on, but if you wanted to submit a PR to this repository that adds/enables your desired installation functionality alongside the existing installation options, I'd be happy to review it; I'm not a user of NixOS and probably not the right person to implement what you want.