Fix: QAM channel scan is unreliable; often reports many channels as DTV-x-y

This behavior is observed when using Hauppauge HVR 1250, 1600, 1800 & 2250 tuners, although it likely occurs with any BDA (internal, non-network) tuner.  A non-Sage channel scan (TV, HDHR, or  Hauppauge WinTv app, or TsReader) confirms that the correct channel info is present in the data stream.  The issue was introduced in Sage7 and didn't occur with Sage6.  Possibly related to another old issue; see comment in ChannelScan.c re: 'QAM stream carries DVB-C PSI in Lubbock TX'.
Suddenlink cable (clear QAM, in Truckee, Calif) carries some ATSC streams with a 12:1 ratio of DVB to ATSC packets.  This mixture of packets (which arrive in no particular order) caused the channel scanner to get confused.  Depending upon when it started looking at the pkt stream, stream_format might get set to either DVB_STREAM or ATSC_STREAM, causing programs to be reported as "DTV-x-y" instead of e.g, "KCRA", or dropped entirely.  Scan results were often inconsistent, resulting in the need to manually remap a large number of channels. Subsequent scans gave wildly different scan results.  In a system with multiple tuners using the same channel lineup, it was impossible to obtain convergence.
This commit changes the algorithm for "guessing" the stream type by giving higher weight to ATSC packets, based on a ratio of 16:1.  To guard against spurious ATSC detection, we still need to see >= 2 ATSC packets to decide it's an ATSC stream.
Pkt stream test case: 15 (DVB), 1 (ATSC), 15 (DVB), 1 (ATSC) : result=ATSC Stream detected
This commit also bumps the SageTv.exe version # from <IP_ADDRESS> to <IP_ADDRESS>
I intend to encourage wider testing of this change by posting TSSplitter.ax (for both Sage7 & Sage9) on the forums after the code has been reviewed.

Could you build x86 and x64 DLLs to put on forum to have users test?

I'll be posting 2 versions of TSSplitter.ax (which contains the fix).  One is built for Sage7 (using the pre-vs2015 C runtime libraries).  The other is for installations running the full set of Sage9 binaries, using the newer vs2015 UniversalCRT runtime libraries.  Both are 32-bit.  The VS Solution isn't able to build anything for 64-bit yet.

It's better post a VS2015 redistribution installation as well or a link for
users.
On Tue, Dec 8, 2015 at 3:38 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

I'll be posting 2 versions of TSSplitter.ax (which contains the fix). One
is built for Sage7 (using the pre-vs2015 C runtime libraries). The other is
for installations running the full set of Sage9 binaries, using the newer
vs2015 UniversalCRT runtime libraries. Both are 32-bit. The VS Solution
isn't able to build anything for 64-bit yet.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/pull/62#issuecomment-163057374.

The .ax files have been posted to the forums here: http://forums.sagetv.com/forums/showthread.php?p=581552#post581552
It's anybody's guess how long before there's feedback. In the meantime, unless there's a known reason it's a bad fix, I'd like to get the change pulled into the repo.  We can easily back it out later if there are reports of regression.

Do you know what the signs would be if there were problems so we'd be able
to identify this commit as the bad one? If that's somewhat solid; then I'd
be fine with committing it...I know how that helps if you're working on
this area of the code. :)
On Tue, Dec 8, 2015 at 11:36 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

The .ax files have been posted to the forums here:
http://forums.sagetv.com/forums/showthread.php?p=581552#post581552
It's anybody's guess how long before there's feedback. In the meantime,
unless there's a known reason it's a bad fix, I'd like to get the change
pulled into the repo. We can easily back it out later if there are reports
of regression.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/pull/62#issuecomment-163106975.

--
Jeffrey Kardatzke
<EMAIL_ADDRESS>Google, Inc.

I think after 10 users in different area testing without problem, we may
check in. since we probably can't get 100% QAM working correctly, keep
updating new DLLs on forum to improve after releasing.
On Tue, Dec 8, 2015 at 8:53 PM Jeffrey Kardatzke<EMAIL_ADDRESS>wrote:

Do you know what the signs would be if there were problems so we'd be able
to identify this commit as the bad one? If that's somewhat solid; then I'd
be fine with committing it...I know how that helps if you're working on
this area of the code. :)
On Tue, Dec 8, 2015 at 11:36 PM, Keith Fischer<EMAIL_ADDRESS>wrote:

The .ax files have been posted to the forums here:
http://forums.sagetv.com/forums/showthread.php?p=581552#post581552
It's anybody's guess how long before there's feedback. In the meantime,
unless there's a known reason it's a bad fix, I'd like to get the change
pulled into the repo. We can easily back it out later if there are
reports
of regression.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/pull/62#issuecomment-163106975.

--
Jeffrey Kardatzke
<EMAIL_ADDRESS>Google, Inc.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/pull/62#issuecomment-163108508.

@Narflex: Should be fairly easy to identify.  My change only affects channel scan.  Symptoms of a bad fix will be identical to what's in the title of this pull request, seen on systems that previously didn't have that problem.

Now that you already made that post...let's give it a few days and see if
some responses are made with confirmation it works OK. I'd at least like to
get a couple other confirmations of it working fine...but if no one
provides assistance by the beginning of next week, then we can go ahead and
commit it.
On Wed, Dec 9, 2015 at 10:51 AM, Keith Fischer<EMAIL_ADDRESS>wrote:

@Narflex https://github.com/Narflex: Should be fairly easy to identify.
My change only affects channel scan. Symptoms of a bad fix will be
identical to what's in the title of this pull request, seen on systems that
previously didn't have that problem.
—
Reply to this email directly or view it on GitHub
https://github.com/google/sagetv/pull/62#issuecomment-163299679.

--
Jeffrey Kardatzke
<EMAIL_ADDRESS>Google, Inc.

Sounds reasonable to me.   Normally, I get a bit concerned about delayed pulls and subsequent issues with merge-in.  But with the low volume of changes to the native code, there's little likelihood of bit-rot setting in.

It's been over a month since the binaries were posted on the forum.  No feedback that the change has broken anything.  Time to pull it into the repo?

I agree...it is now merged. :)


Slow compiler makes loading times longer when rendering views

This is an awesome project, and I'd like to use it to convert some of the components I currently have written in slim to pug. This is because there is a frontend module in the app that has to render the same components but with javascript (with a webpack loader pug works very well).
However I noticed that any additional Pug.compile ... (or Jade.compile for that matter) takes an extra few milliseconds and if you end up having 20+ of these in one view the page takes a couple of seconds to load which makes the experience much worse than using native slim templates.
Is there a way to compile a template once and then render it with different locals? Because that's essentially the biggest issue, I have 20+ of the same component (the template) with different contents. When you compile a pug template in Javascript you can then call the render function with different locals, is there a way to do this with this library?
Thanks

Hi!
Thank you for the feedback.
I understand your issue good. I think you are using Pug compiler which you have installed with NPM. In that case every time you compile the template pug-ruby invokes command line (https://github.com/yivo/pug-ruby/blob/master/lib/jade-pug/system-compiler.rb#L38) by passing your template, locals, options etc. For sure this means every time you compile template Node.js needs to parse and evaluate every Pug JavaScript dependency and the compiler itself. It is very very slow but this method exists and is supported because it provides access to almost full list of Pug features.
The second method is to use libv8 engine which is shipped as Ruby gem and evaluate prebuilt web version of Pug compiler (https://github.com/yivo/pug-ruby/blob/master/vendor/pug-2.0.0-rc.4.min.js) to compile your template. In this case the compiler code is evaluated only once and compilation works fast. But this method has drawbacks which stops you from using some Pug features (see README).
Please, try Pug.use "2.0.0-rc.4" and see how fast it will be.
There is additional solution: you can compile Pug template as client side (get JS function) and use ExecJS to evaluate it with your locals.
I am also going to add Pug 2.0.x sources which was released in March so you can do Pug.use "2.0.3".

@nicmosc please try the snippet below:
require "pug-ruby"

Pug.use "2.0.0-rc.4"

template_source   = File.read("template.pug")
template_function = ExecJS.compile "var compile = #{Pug.compile(template_source, client: true)};"
template_locals   = {}
rendered_template = template_function.call(:compile, template_locals)

I recommend to use https://github.com/discourse/mini_racer as JS runtime.

@yivo thanks for the snippet, it works like a charm! Super fast 🤘 I'll let you know should I have more issues but looks good for now!


connection-parameters options bug

I was developing and testing some additional functionality which uses options instead of connection string in SOCI and found out a bug while searching for an option.
get_option() failed to find option by name since map matches const char* pointer value instead of option name. By changing the type to std::string the issue is resolved.
This PR also resolves compiler warning fixes in test-mysql.h. ( caused by merge of #356 )

Oops, thanks for fixing this. I think we might keep char const* arguments though, for compatibility, just using std::string for the map key type should be enough to fix the problem, shouldn't it?

Of course. I have reverted the changes to both functions.

@ravselj Is this PR ready to merge?

Yes. The initial code contained some unnecessary changes( upper comment from @vadz ) which were removed by last push.

Thanks!


Reorganize 'tests' folder

The tests folder has been a mess forever and isn't intuitive. I think it's a good idea to clean this up and merge it to master with the working bash build.

I reorganized this a bit and am going to PR it to develop.
I can't fully test this because it changes a bit of the docker build for tests, and I'll need to merge to master for that to work with travis and such. My plan is to merge this to master along with the code for working bash, test, and then update the containers on docker hub.

This has been reorganized and merged to master


Acceptance test output/backtrace

Months ago I started using the new capybara's DSL for acceptance tests, however every time a spec fails I have to reproduce the problem by hand in order to determine what is happening because capybara is unable to catch the exception and the message is printed on response body. So the rspec output/backtrace is pretty useless because it just tells which spec fails instead of the broken app piece. How do you deal with this situation?

#329 looks like a duplicate.

I have the same problem using the rack driver.

This definitely seems like what I was dealing with in #329.
As a monkey-patch-hack, I put something like this in either spec/support or features/support
require 'thin'
Thin::Connection.class_eval do
  def handle_error_with_raise
    raise $!
  ensure
    handle_error_without_raise
  end
  alias_method_chain :handle_error, :raise
end

That is, if you're using Capybara's Thin app server... you could probably do something similar for mongrel.

I don't use thin or mongrel -- rack-test doesn't use a webserver -- and I still get this backtrace-hiding problem.

@joevandyk -- I think that's a separate issue.
There are two outstanding issues regarding exceptions in Capybara. One has to do with webservers.
The other... well I haven't looked too deeply into it, but it sounds like it has something to do with how rails rescues from exceptions in controllers. I know with previous versions of rails/rspec/cucumber, you used to have to manually specify when you want Rails to handle errors and when to not.
E.g., in Cucumber, you can set a tag @allow-rescue before a scenario so you can test Rails's internal handling of exception handling: https://github.com/cucumber/cucumber-rails/blob/master/lib/cucumber/rails/action_controller.rb
https://github.com/rails/rails/blob/v3.1.1/actionpack/lib/action_controller/test_case.rb#L510

Awesome, using this code made capybara start showing exceptions during acceptance tests with rack-test: https://github.com/cucumber/cucumber-rails/blob/master/lib/cucumber/rails/action_controller.rb
Any reason why capybara doesn't do something like that automatically?

Well it really doesn't have much to do with Capybara at all. It's something that both RSpec and Cucumber deal with, and they make you deal with it manually. The reason it is not automatic is that sometimes you want Rails to spit the error back at you and sometimes you want to see how rails will deal with the error. There's no one-size-fits-all solution to this.
For example, if you put this in your Cucumber env.rb file:
ActionController::Base.allow_rescue = false

and you're testing this controller:
class FooController < ActionController::Base
  rescue_from ActiveRecord::RecordNotFound do
    # Some cool logic you want to test
  end

  def some_action
    # some code that sometimes might raise ActiveRecord::RecordNotFound.
    # e.g. Foo.find(params[:id])
  end
end

you'll find that if your code tests FooController#some_action, which raises ActiveRecord::RecordNotFound, Cucumber will spit the error back to the screen. Now, let's say you want to actually test the code that happens in # Some cool logic you want to test. In order to do this, you'll have to override the ActionController::Base.allow_rescue = false setting you have in env.rb by tagging the Scenario with @allow-rescue.
Of course, you can do things the other way around, and start with ActionController::Base.allow_rescue = true...
In the case of RSpec, please refer to: https://www.relishapp.com/rspec/rspec-rails/docs/controller-specs/bypass-rescue

I know we went through this in #329... but I'm thinking the only way for Capybara to gracefully handle this is to insert a piece of middleware similar to Capybara::Server::Identify like this:
module Capybara
  class Server
    class ErrorHandler
      def initialize(app)
        @app = app
      end

      def call(env)
        begin
          @app.call(env)
        rescue Exception => e
           Capybara.save_error(e)
           [500, {}, ""]
        end
      end
    end
end

And then have the visit method check for the error saved by Capybara.save_error. But that certainly does not cover the case of when ajax is triggered by JS on a page and generates an exception in the app. Perhaps there's a better place than visit? It's hard to say the best way to do this. I mean Capybara could handle the first have -- the error capturing, and then the developer could handle where she might want to access any saved errors. E.g. when using RSpec,
Rspec.configure do |config|
  config.after(:each) do
    raise Capyabara.last_saved_error if Capyabara.last_saved_error
  end
end

agibralter that code works nicely for me. thanks, this issue has been driving me crazy.

I don't really think this is fixable in Capybara. It's a tough call whether this is desirable behaviour or not. The proposed solutions seem way too brittle and overengineered to me. I would really just like to close this. What do you guys think?

@JonnieCache are you sure that causes firefox to hang? I found that usually happens when my version of selenium-webdriver is outdated or is not compatible with my version of FF. Anyway... that hack has worked quite nicely for me for a while.
And, yes @jnicklas -- there doesn't seem to be an elegant way to handle this... Maybe it's worth putting a note in the README/wiki saying that exceptions raised in the application will not be raised while running the test suite and link to a gist like mine or something similar?

I agree this should probably be closed, at least as long as there is not a neat solution. In general, I just use save_and_open_page or open the URL in my browser when the app raises an exception.
And as @agibralter said: "Sometimes, you want your app to return a 500 error and you want to test how your JS deals with that situation." So we'd need to add more logic to allow some error pages to pass through.
So I'd say we close this. If someone comes up with a sensible solution for this, we can revisit the issue.


Incorrect Recent Activity

My Recent Activity showed many started repository..., but these were not my repositories. Perhaps this is a misspelling of starred, but if so, these were repositories I removed from my starred list.

Thanks for letting us know! You were right - we made a mistake and should have starred instead of started So sorry about that, our bad!
Repos that showed up in your recent activity were ones you starred before. But we can't tell if you un-starred them or not because of the GitHub API limitations.


create license using MIT license

What does this PR do?

Add license to the repo

Description of Task to be completed?

Add MIT license to the repo

How should this be manually tested?

visit https://github.com/GeekHijabi/More-recipes/blob/development/LICENSE to view the license

Coverage remained the same at 83.407% when pulling 2b9f093e3fb548cc5abeba2502cbcf186163146f on add-license-1 into d1265f011a7649a6c06b6da738e075168564175e on development.


Unable to load timezone info for CEST

I am getting this errormessage in HA log since yesterday:
<This error originated from a custom integration.
Logger: custom_components.meross_lan.mss315_###############################0
Source: custom_components/meross_lan/helpers/init.py:274
integration: Meross LAN (documentation, issues)
First occurred: May 21, 2024 at 20:36:46 (18 occurrences)
Last logged: 10:51:28
Unable to load timezone info for CEST - check your python environment
UnknownTimeZoneError('CEST') in using pytz to build timezone(CEST)
ZoneInfoNotFoundError('No time zone found with key CEST') in building timezone(CEST) info for Appliance.System.Time!-- Before you open a new issue, search through the existing issues to see if others have had the same problem.
HA Versions:
Core
2024.5.4
Supervisor
2024.05.1
Operating System
12.3
Frontend
20240501.1
Meross Version: 5.0.4
seems to be rather a Python Environment problem than an integration problem. Anyone else experiencing this behavior?

Updateted to current version 5.1.0. Problem still current...

Sorry. Was my fault. timezone was not set for one device.


Symbol not found for distributed actors

Description
With latest Xcode 16 (16A5171c) and Swift 6, as soon as you run any code which involves distributed actors it will crash.
Either:
dyld[42881]: Symbol not found: _$s11Distributed0A11ActorSystemP14remoteCallVoid2on6target10invocation8throwingyqd___AA06RemoteE6TargetV17InvocationEncoderQzzqd_0_mtYaKAA0aB0Rd__s5ErrorRd_0_2IDQyd__0bP0Rtzr0_lFTq
  Referenced from: <F327CE9E-6621-3923-9532-66EC24D2AB72> /Users/jaleel/Library/Developer/Xcode/DerivedData/DistributedActorsTest-egpbdgnpzlmyykanlhpooghfofim/Build/Products/Debug/Test
  Expected in:     <F57AFC7A-F9E1-34D8-95B1-798A40E3C256> /usr/lib/swift/libswiftDistributed.dylib

or when whenLocal is used:
Symbol not found: _$s11Distributed0A5ActorPAAE9whenLocalyqd__Sgqd__xYiYaYbqd_0_YKXEYaqd_0_YKs8SendableRd__s5ErrorRd_0_r0_lF
  Referenced from: <6BC5E157-41FB-30B1-B05A-5C13DCCF3FDB> /Users/jaleel/Library/Developer/Xcode/DerivedData/DistributedActorsTest-egpbdgnpzlmyykanlhpooghfofim/Build/Products/Debug/Test
  Expected in:     <F57AFC7A-F9E1-34D8-95B1-798A40E3C256> /usr/lib/swift/libswiftDistributed.dylib

Reproduction
import Distributed

distributed actor DumbDistributedActor {

  typealias ActorSystem = DumbActorSystem

  distributed func sayHello() async throws -> String? {
    await self.whenLocal { _ in
      return "Hello, world!"
    }
//    return "Hello, world!"
  }
}

final class DumbActorSystem: DistributedActorSystem {
  typealias ActorID = String
  typealias InvocationEncoder = ActorInvocationEncoder
  typealias InvocationDecoder = ActorInvocationDecoder
  typealias ResultHandler = ActorResultHandler
  typealias SerializationRequirement = any Codable

  func remoteCallVoid<Act, Err>(on actor: Act, target: RemoteCallTarget, invocation: inout InvocationEncoder, throwing: Err.Type) async throws where Act: DistributedActor, Act.ID == ActorID, Err: Error {}
  func resignID(_ id: String) {}
  func actorReady<Act>(_ actor: Act) where Act : DistributedActor, String == Act.ID {}
  func remoteCall<Act, Err, Res>(on actor: Act, target: RemoteCallTarget, invocation: inout InvocationEncoder, throwing: Err.Type, returning: Res.Type) async throws -> Res where Act: DistributedActor, Act.ID == ActorID, Err: Error, Res: Codable {
    throw DumbError()
  }

  func resolve<Act>(id: String, as actorType: Act.Type) throws -> Act? where Act : DistributedActor, String == Act.ID {
    return .none
  }

  func assignID<Act>(_ actorType: Act.Type) -> String where Act : DistributedActor, String == Act.ID {
    ""
  }

  func makeInvocationEncoder() -> ActorInvocationEncoder {
    ActorInvocationEncoder()
  }
}

struct ActorInvocationEncoder: DistributedTargetInvocationEncoder {
  typealias SerializationRequirement = any Codable

  mutating func recordArgument<Value: Codable>(_ argument: RemoteCallArgument<Value>) throws {}
  func recordErrorType<E>(_ type: E.Type) throws where E : Error {}
  func recordGenericSubstitution<T>(_ type: T.Type) throws {}
  mutating func recordReturnType<Res: Codable>(_ resultType: Res.Type) throws {}
  mutating func doneRecording() throws {}
}

struct ActorInvocationDecoder: DistributedTargetInvocationDecoder {
  typealias SerializationRequirement = any Codable

  mutating func decodeGenericSubstitutions() throws -> [any Any.Type] { [] }
  mutating func decodeErrorType() throws -> (any Any.Type)? { .none }
  mutating func decodeReturnType() throws -> (any Any.Type)? { .none }
  mutating func decodeNextArgument<Argument: Codable>() throws -> Argument { throw DumbError() }
}

struct ActorResultHandler: DistributedTargetInvocationResultHandler {
  typealias SerializationRequirement = any Codable

  func onReturnVoid() async throws {}
  func onThrow<Err>(error: Err) async throws where Err : Error {}
  func onReturn<Success: Codable>(value: Success) async throws {}
}

struct DumbError: Swift.Error {}

let actorSystem = DumbActorSystem()
let actor = DumbDistributedActor(actorSystem: actorSystem)
try await print(actor.sayHello())

Stack dump
* thread #1, stop reason = signal SIGABRT
  * frame #0: 0x0000000182991a50 dyld`__abort_with_payload + 8
    frame #1: 0x000000018299c628 dyld`abort_with_payload_wrapper_internal + 104
    frame #2: 0x000000018299c65c dyld`abort_with_payload + 16
    frame #3: 0x000000018292e6b0 dyld`dyld4::halt(char const*, dyld4::StructuredError const*) + 304
    frame #4: 0x000000018292b258 dyld`dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 3888
    frame #5: 0x0000000182929edc dyld`start + 1844

Expected behavior
App should run.
Environment
macOS 14.5 (23F79) Sonoma with latest Xcode 16 (16A5171c) and Swift 6.
Xcode 16A5171c
Additional information
For whenLocal stack trace is:
* thread #1, stop reason = signal SIGABRT
  * frame #0: 0x0000000182991a50 dyld`__abort_with_payload + 8
    frame #1: 0x000000018299c628 dyld`abort_with_payload_wrapper_internal + 104
    frame #2: 0x000000018299c65c dyld`abort_with_payload + 16
    frame #3: 0x000000018292e6b0 dyld`dyld4::halt(char const*, dyld4::StructuredError const*) + 304
    frame #4: 0x000000018292b258 dyld`dyld4::prepare(dyld4::APIs&, dyld3::MachOAnalyzer const*) + 3888
    frame #5: 0x0000000182929edc dyld`start + 1844

The missing function is
-> % pbpaste | ../build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64/bin/swift-demangle
(extension in Distributed):Distributed.DistributedActor.whenLocal<A, B where A1: Swift.Sendable, B1: Swift.Error>(@Sendable (isolated A) async throws(B1) -> A1) async throws(B1) -> A1?

For the typed throws in whenLocal I wonder if we messed up and the new function must be always emitted into client, that'd make sense.
The Distributed.DistributedActorSystem.remoteCallVoid could be related to those requirements now becoming real protocol requirements... Maybe @xedin has some idea here, we'll investigate.
Thank you for the report

Hm, interesting 🤔 thx for info!

We talked offline, this appears to be a bug caused by some changed we made to distributed actors recently, @ktoso is working on a fix.

rdar://129651474

@ktoso this should be resolved by your changes right?

That's right, seems missed to resolves #... note it. Thank you!


Can i get user's website ,if i only know user id ?

Now i know the userid (pk= 448639377)  ,i want get his page(just like https://www.instagram.com/neckandneck_official/  ) .can you help me ?

Addressed in rewrite or no longer relevant.


:memo: Data model ADR

For #13

@markstur Thanks for the input. I've tried to rephrase to be a bit clearer. The wording was likely too vague in an attempt at generality, but concretely I was imagining we could use data models for any of inference input (say a raw document structure) or output (classification result) or training input (any sort of training record). I tend to associate the word “result” with “output,” which would be a bit constraining.


Determine if positional databases should be optimized

This issue comes from a split of the following issue:
https://github.com/meilisearch/meilisearch/issues/3714
The positional databases (word_position_docids and fid_word_docids) are needed by two ranking rules:

Attributes (word_position_docids + fid_word_docid)
Exactness (word_position_docids)

And they have their prefix cache:

fid_prefix_docid
prefix_position_docids

In Meilisearch v1.2, these databases were reported as time-consuming for indexing. We should determine if they are in the latest version and if we should focus on optimizing them.
Louis suggested to index the books dataset to evaluate it.

Test made these two database are far from being the most time consuming databases, processing word_position_docids + fid_word_docid + word_docids is faster than processing word_pair_proximity_docids.


[FEATURE] Built-in secure transports support

Is your feature request related to a problem? Please describe
OpenSearch core provides the mechanism for a plugins to supply alternative transport protocols (TCP + HTTP) using NetworkPlugin extension point. However, it was designed to support only plain transports without security in mind.
We have the following transport plugins (as of today):

netty4 (default, TCP + HTTP)
nio (TCP + HTTP)
reactor-netty4 (HTTP)

None of them could be configured with secure communication out of the box. The security plugin is trying to close this gap by "hijacking" the netty4 transport and providing own version of it with SSL/TLS configured. Not only nio nor reactor-netty4 are not supported, the general problem is that any other transport needs custom, ad-hoc work  in security plugin to function as expected (the effect of that: switching transport from netty4  to any other with security plugin enabled results in degradation to plain transport).
Describe the solution you'd like
Ideally, the secure transport should be provided by the transport plugins, if and when those support secure communication. The role of the security plugin would be in providing the settings (certificates, keystores, etc) so the respective transport engine could be configured using those. Ideally, the change should be non-breaking and portable to 2.x (1.x?) release lines.
The proposal is to extend NetworkPlugin with 2 additional extension points:
public interface NetworkPlugin {
    // ...

    default Map<String, Supplier<Transport>> getSecureTransports(Collection<SecureSettingProvider> ssps, ...) {
        return Collections.emptyMap();
    }

    default Map<String, Supplier<HttpServerTransport>> getSecureHttpTransports(Collection<SecureSettingProvider> ssps, ...)
        return Collections.emptyMap();
    }
}

The existing Plugin could be extended with 1 additional extension point:
public interface Plugin {
    // ...

    public Collection<SecureSettingProvider> getSecureSettingProviders() {
        return Collections.emptyList();
    }
}

The SecureSettingProvider by itself is not limited to secure transport settings only (however initially it will primarily include those)  but could go beyond that.
interface SecureSettingProvider {
    public Optional<SSLEngine> buildSecureHttpEngine(HttpServerSettings settings) throws SSLException;
    public Optional<SSLEngine> buildSecureServerTransportEngine(ServerTransportSettings settings) throws SSLException;
    public Optional<SSLEngine> buildSecureClientTransportEngine(ClientTransportSettings settings) throws SSLException;
}

NOTE: the APIs are roughly sketched to highlight the idea and are subject to change.
Related component
Plugins
Describe alternatives you've considered
Keep things as is
Additional context

https://github.com/opensearch-project/OpenSearch/issues/9068

@peternied @dblock would @andrross would love your thoughts on the matter folks, thank you

Thanks for writing this up as security in near and dear to my heart - and the way the security plugin engages with the transport layers is less than idea.
I'm not as up to speed as I'd like on the transport system, but if I were to imagine how I'd like the system to operate, there would be no such thing as an insecure transport.  OpenSearch would always use secure-able channels - the level of security for these channels would be modifiable via an extension point - ideally we ship with a minimal functional https system for any of the three transport plugins.
@reta Is that kind of approach feasible? I believe we know how to secure netty4, but I don't know how much effort wrapping the other layers would require.
Aside: I know SSL termination is a consideration for folks running OpenSearch - but if we can I'd like to invert our practices to be secure by default and carefully open only what is needed for this use case.
FYI - @davidlago

Thanks @reta! From your "hijacking" and @peternied's "less than ideal" phrasing it sounds like we have consensus that there is room for improvement in the security plugin integration with the transport layer!

@reta Is that kind of approach feasible? I believe we know how to secure netty4, but I don't know how much effort wrapping the other layers would require.

In JVM, we do have common denominator - JCE / SSL, so whatever transport it is going to be, it will be using those in some form or another (I think). So I do think it is feasible.

Aside: I know SSL termination is a consideration for folks running OpenSearch - but if we can I'd like to invert our practices to be secure by default and carefully open only what is needed for this use case.

That's the beauty of it, we could offload the transport defaults (aka secure by default) to OpenSearch core at zero cost, the initial plan (as I see it in my head) would be to: move code, keep configs. That's would be non-disruptive to our users.

I am with @peternied and would work backwards from "all transports must be secure", aka evolve the transport interface to one with security enabled by default, then implement passthrough/dummy security as needed. I would also deprecate any non-secure transport and require security in 3.0.

I think users do not want an OpenSearch with security turned off by default, they want the opposite. So I am with @peternied and would work backwards from "all transports must be secure", aka evolve the transport interface to one with security enabled by default, then implement passthrough/dummy security as needed. I would also deprecate any non-secure transport and require security in 3.0.

Thanks @dblock , I would argue whatever transport is the default and do we want it or not is not the issue I am trying in scope of this feature request. The problem I am trying to address is that there is no way to bundle secure transport (default or not) with core - any attempt to do so would require dedicated lockstep and ad-hoc support in security plugin - this is not sustainable I think (and the current state of the transports confirms that).
We could  change the default any time, but we need to fill the gap with providing secure transports in principle.

We could change the default any time, but we need to fill the gap with providing secure transports in principle.

Agreed. I am just saying that we should do it as a breaking change in 3.0 and require a secure transport.

[Triage - attendees 1 2 3 4 5 6]
@reta Thanks for filing, looking forward to seeing how this develops.


tests for shallow#props() and prop()

added test ensuring that props() returns props of the root rendered node, not props passed to composite root component
added tests for untested prop() method

I wanted to do the same for mount but apparently the following
      class Foo extends React.Component {
        render() {
          return (
            <div className={this.props.bar} id={this.props.foo} />
          );
        }
      }

      const wrapper = mount(<Foo foo="hi" bar="bye" />);

      expect(wrapper.props()).to.eql({ className: 'bye', id: 'hi' });

is not true for mount. wrapper.props() is actually the props passed in ({foo: 'hi', bar: 'bye'})
Is this on purpose or is this a bug?

@nfcampos I believe that's on purpose. shallow doesn't render the actual top level component, looking back at this comment from @lelandrichardson but mount does.

I'm also curious to see if these changes https://github.com/airbnb/enzyme/pull/385 pass these new tests too.

yeah probably it's on purpose, but it is surprising, anyway it should be tested explicitly either way so I'll open another PR with these same tests for mount (changing these assertions to match the behaviour of mount)

this one is ready to merge I believe

rebased

LGTM


Please add PATCH as HTTP command

Hi,
I was wondering why PATCH is not supported according to your docs. My REST API uses PATCH as it describes what happens better then POST or PUT
Cheers
Thomas

Would you just expect it to work the same way as POST or PUT from Refit's point of view?

Sorry. It isn't mentioned in the docs, but PATCH is supported. Just try using [Patch("/some/resource")] the way you'd use any other attribute.

That's great. Thanks


Default StorageClass/Secret in webhook

Let's initialize them in webhook rather than reconcile loop.

/test openstack-operator-build-deploy-kuttl

/test openstack-operator-build-deploy-kuttl
Possible fix for the last failure in install yamls Pr#443 just merged

/test openstack-operator-build-deploy-kuttl
rerunning to confirm if failure is consistently same


Fix AnimationPlayer cumulative speed_scale

Fixes #77484
get_playing_speed() returns custom speed multiplied by AnimationPlayer's speed and it was being supplied as custom speed, thus applying AnimationPlayer's speed each time.

Thanks!

Cherry-picked for 4.0.4.


namespace: namespace flags are not working

namespace: namespace flags are not working
cluster namespace and operator namespace needs
better handling. It was throwing an error and was exited
when namespace args are passed.
Now, the default cluster ns is rook-ceph, and for
operator it is empty but we check later in the code
that if CephClusterNamespace != "" && OperatorNamespace == ""
then assign the cluster ns to operator ns.
ci: add CI to test the plugin in different namespace
Signed-off-by: subhamkrai<EMAIL_ADDRESS>fixes: #129

Maybe early next week we can plan on releasing v0.5.1, in case any other fixes are needed as well

Maybe early next week we can plan on releasing v0.5.1, in case any other fixes are needed as well

yes, since the issue with then namespace is really annoying.


clean up usage costs

Scope & Purpose
Split Index::UsageCosts into FilterCosts and SortCosts

[x] Bug-Fix for devel-branch (i.e. no need for backports?)
[x] Strictly new functionality (i.e. a new feature / new option, no need for porting)
[x] The behaviour change can only be verified via automatic tests

Enterprise companion PR: https://github.com/arangodb/enterprise/pull/262
Testing & Verification
This change is already covered by existing tests, such as all AQL tests which pick indexes.
https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4824/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4850/

https://jenkins.arangodb.biz/job/arangodb-matrix-pr/4876/

https://jenkins.arangodb.biz/job/arangodb-matrix-pr-linux/6476/

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/4879/

https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/4886/

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/4960/


Switch native keyboard bindings?

I work across multiple OSs but would like to avoid having to learn three separate sets of keybindings.
Is there a clean way to say, e.g. on Windows, "use the Linux key bindings"?  I know I could copy all of them to my user settings, but that seems... a bit clunky?  Also, it would mean the bindings could diverge over time etc.
Thank you.

I agree this would be nice to have. CLion offers this and it's great.


Update deps to make it work on Node 18

This PR fixes #20.
node-canvas has been released with pre-built binaries for Node 18, which was the last bit left to make it runnable on all platforms.

Hey, all done, although I don't think it's preferable at all. Not pinning canvas would have removed the need for this PR. Now we have overrides in package.json so it's fine, but we don't benefit from the tests of this repo.


hyperparameters.csv change task to method, change algo to model name

https://github.com/marrlab/DomainLab/pull/732


[SPARK-49050] Enabling deleteIfExists operator in TWS with Virtual Column Families

What changes were proposed in this pull request?

Fully integrating the TransformWithState operator with Virtual Column Families by adding support for the deleteIfExists operator. In RocksDB.scala, return the columnFamilyId if it exists in removeColFamilyIfExists so that we can remove all the keys for the corresponding columnFamily once deleteIfExists is called.
Why are the changes needed?

To add support for the deleteIfExists operator with VCF, as this functionality was not working when virtual column families were introduced.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Enabled previously disabled unit test
Was this patch authored or co-authored using generative AI tooling?

No

@HeartSaVioR PTAL, thanks!

Thanks! Merging to master.


The dapp is also showing the same link as install option

What version of Wallet are you using?
Don't know
What is happening?
The dapp is not showing
steps to reproduce
It should connect wi my wallet for test a transanction
How it should behave?
It's completely not working
What os are you seeing the problem on?
Windows Desktop
What browser?
None
What is your browser version?
Windows 11

@pppkartik  Can you point to what DApp you are testing?

Fuel wallet dapp sir


please update latest tag on npm

npm info gaze dist-tags.latest
npm http request GET https://registry.npmjs.org/gaze
npm http 304 https://registry.npmjs.org/gaze
0.5.1

should probably be 0.6.4.

0.6.4 doesn't work with io.js or node v0.12 among some other issues (it's the version where I switched to native bindings). The navelgazer branch is taking awhile for me to complete which will provide support.
So, atm, 0.5.1 is more stable and works with io.js and node v0.12, although slower and more CPU intensive. I've tagged latest to 0.5.1 to minimize friction until I can get the navelgazer branch green.

:+1: Yes please!

@shama, over at node-sass we are getting suggestions to switch to chokidar or alternative file watchers (https://github.com/sass/node-sass/issues/636, not to mention those also have issues and limitations which glaze overcame long time ago). If this is still under active development and the future is gonna glow brighter with gaze, I will vote to stay. :)

@am11 Yep gaze is still under active development, I am just slow. The latest version of chokidar is looking good though and now supports glob patterns. Feel free to use whichever library works best for you.

Is 0.5.* still considered the most stable version? I'm getting warnings that a deprecated version of lodash is used when installing node-sass and they won't update their version of gaze untill til dist-tag is uppdated. Just curious about how it's looking, thanks!

Maybe a v0.5.3 that updates lodash?

How about this, let's release an updated 0.5 as 1.0.0 stable. This will fix the confusion with why 0.5 is tagged latest and let us fix these things so nobody has to wait for the navelgazer branch to land, sound good?
Any objections? /cc @joshperry

Sounds like a great plan! The only downside is that it will require other modules to actively upgrade their deps but in the long run having a nice and stable 1.0 and no 0.5/0.6 confusion is preferable.

@shama: any progress on this?

Latest is 1.1.0


swift-23 branch doesn't build on Xcode 7.3.1

5 errors
Lines 165, 167 & 210 of SSLSecurity.swift because of

Type 'SecTrustResultType' (aka 'UInt32') has no member 'Unspecified'
Lines 255 & 313 of WebSocket.swift because of
Cannot force unwrap value of non-optional type 'String'

It shouldn't build, see https://github.com/daltoniam/Starscream/pull/258


Optimize call db query for product page

In this PR I optimized working with db.
For /product/ page I decreased count from 43 to 31 queries (~28%).
You could see screenshots below as proof
Before

After

Please recheck PR


chore: bdd-spring-1584722898 to 0.0.1

chore: Promote bdd-spring-1584722898 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Connectivity.iOS.IsRemoteReachable timeout issue

This is a

[x] Bug

Which plugin does this impact:

[x] Connectivity

Version Number of Plugin: 2.1.2
Simulator Tested On: iPhone 4s iOS 9.0 (13A344)
Expected Behavior
When on wifi without internet, calling CrossConnectivity.Current.IsRemoteReachable() with msTimeout set to 8000 should return false after 8000 seconds.
Actual Behavior
When on wifi without internet, line socket.ConnectAsync(socketEventArg); inside CrossConnectivity.Current.IsRemoteReachable() always takes 30 seconds, although it should only start the connection and not wait for anything.
Suggested fix
calling the line through this function solves the issue but I am not sure if it is good practice:
public static async Task RunBlockingFuncOnOtherThread(Action function, int msTimeout)
        {
            var tcs = new TaskCompletionSource<bool>();
            new System.Threading.Thread(() =>
            {
                function.Invoke();
                if (!tcs.Task.IsCompleted)
                    tcs.TrySetResult(true);
            }).Start();

            Task.Run(async () =>
            {
                await Task.Delay(msTimeout);
                if (!tcs.Task.IsCompleted)
                {
                    Console.WriteLine("RunBlockingFuncOnOtherThread() timed out");
                    tcs.TrySetResult(false);
                }
            });

            await tcs.Task;
        }

If you think it's good solution, I can implement it and create pull request.

I've just tested that it does not happen on iPhone 4 iOS 7. The issue might be related only to the specific situation I created with the wifi - I disabled IPv4 on my wireless network in windows settings so that the Mac gets wifi but no internet. Maybe it's something that can't really happen in real world and maybe it can be ignored. You can try to reproduce it or close the issue if you think it can be ignored :) Just wanted to let you know, don't currently have much time to do some deep investigation and figuring out different ways to create wifi without internet for my simulator.

Can confirm this issue. If you have a device acting as a hotspot but with no Internet connectivity, the timeout doesn't work. In fact the timeout just adds time. I am trying rihadavid's solution.
Our setup has three devices:
Electric fan that pressurizes/depressurizes a room.
A digital gauge that controls the fan.
A Xamarin app on an iOS device that controls the gauge.
In situations (like a new construction project) where wifi is not available, the gauge acts as a hotspot so the iOS device can connect and control the gauge.
IS this the best solution? (I know this ticket is closed)

Same here +1.


NOAA weather example no longer working

The timeline shows as not available. Did NOAA change something on their end?

I can confirm that this stopped working.  Any changes?  Any fix?

Hi!
There is a problem with the GetCapabilites request. NOAA's server returns a '403 Forbidden' to this request: https://nowcoast.noaa.gov/arcgis/services/nowcoast/radar_meteo_imagery_nexrad_time/MapServer/WMSServer?request=GetCapabilities&service=WMS&version=1.3.0 (when requested from the server)
So I've changed the example, and now it defines the availabletimes without requesting this info from GetCapabilities.

Confirmed working again. Thanks for the quick fix!


Liquid Stargates

When the output stargate reaches pipe block the input continues to draw liquid and they are lost into the void. Is that supposed to happen?
I am using the liquid tank to avoid pipe block now.

It actually does go to an infinite storage but not all of the time. i was doing some tests in debug =) Thanks!

I fixed some bugs. It works fine for me now. Just to know is that the infinite storage is lost when you save/load the game.


re-frisk dependency update

re-frisk 0.3.2 has been released.

Thanks! Just bumped the re-frisk version


Reference file has not been found

Hi,
I have implemented reference file in my Nunit project and have placed it in the same folder where my TestSuite file is. But when running the testsuite, it throws an error that my settings file is not found

This feature has a bug in v1.10. Have you tried the version 1.11-beta?

I will try soon

No news, good news: closing the issue


Remove unsupported indent option

Indent is no longer supported as of v2.5.0[0].
[0] https://github.com/jshint/jshint/issues/655

Merged to master at commit 56527c7b7946070aa309ad37d70f0413b5f9a0cc. Thanks!


test: create e2e tests for package, fix found errors

I think the contract on how to use log functions with extra parameters is unclear

@ssukienn I also think so, but Nest decided to use it like that :P

btw. the contract is defined here https://github.com/nestjs/nest/blob/master/packages/common/services/logger.service.ts i cannot change it


Paired-end read support

Hi,
HiChip paper ( http://bmcbioinformatics.biomedcentral.com/articles/10.1186/1471-2105-15-280 ) describes how they added paired-end support to Sicer:
For paired-end reads, the HiChIP pipeline keeps the first end and extends by the fragment length estimated from mapping positions of the two ends, rather than by the average fragment length of the library. Given the variability of fragment lengths across a complex genome like human genome, the use of actual coordinates of mapped pairs is expected to achieve better resolution in signal visualization. The bed file is then used to generate a bedGraph file by the genomeCoverageBed command from BEDTools.
Best wishes,
Michal

Thanks. It is definitely on my todo-list (I just had to find PE libs online, since we have no ChIP-seq PE libs ourselves). I will start experimenting with it soon.

epic now fully supports paired end data, but you need to convert bam them to bedpe first.
bedtools bamtobed -pe -i name_sorted_paired_end.bam > file.bedpe


e-shuushuu.net support

I suggest you to add e-shuushuu.net as source in Grabber. You did well with anime-pictures, it would be good to add this one too.
pluses:
+rich tag system
+over 900 000 images
+already supported in IQDB, so it probably have a suitable API
+images has a same md5 which they have on boorus(important for merged results)
minuses:
-this is not a typical booru after all

Indeed, I've taken a look at it a while back and I remember that the only thing stopping it from being added easily is the fact that they don't have an API to search images by a given tag.
One first needs to convert the tags into their IDs before searching (ex: blonde_hair -> 169).
With the new tag database system it would be easier to implement, but I'd much prefer a proper API. Do you know which url IQDB uses for searching? Or does it simply use http://e-shuushuu.net/search/similar/?

@Bionus maybe http://e-shuushuu.net/search/advanced/ will help you?


Not setting for new files

The detection works quite well for existing files but doesn't work for newly created files.
One way to tackle this would be to use BufWritePost:
" Every time any Buffer is written (allows to change the indent after a file is written)
autocmd BufWritePost * lua IndentOMatic()
" Only once per new Buffer
autocmd BufNew * autocmd BufWritePost * ++once lua IndentOMatic()

What do you think of those changes?

I think those are some very good changes! I can see it being very useful for copy-n-pasting some code into a new file
The once per buffer way seems better imo, but shouldn't it be made local to a buffer to avoid it being executed on another buffer by mistake?:
au BufNew * au BufWritePost <buffer=abuf> ++once lua IndentOMatic()

At least that's how I understood those commands as a beginner, feel free to correct me if I'm wrong!

That is completely true. Missed the buffer local autocmd.
What do you think of a :IndentOMatic command?

I don't see it as a necessity rn, I personally use :lua IndentOMatic() for testing everything
But maybe people would prefer if I provided :IndentOMatic for maybe their config? Would it be better to have this command too?

The idea is that when the indent is incorrectly detected you can fix the first line and run a command. You can obviously run a lua function instead but command completion is faster.

I see, I'll add it then. Thanks a lot!


fix Bucketizer.owns

What issues does this solve?

Compilation fails if parent allocator has owns method.

@japplegame So is it possible for a unit test to be made for this problem?

@JackStouffer
Yes. I slightly updated Bucketizer unittest.

:white_check_mark:

Why don't you take this one ? It's a bug fix and it's been green for a full month !


urllib3.exceptions.InvalidHeader exception leak

In some cases urlib3.exceptions.InvalidHeader exception is not being replaced with requests.InvalidHeader and leaks.
Expected Result
Raise requests.exceptions.InvalidHeader(RequestException, ValueError).
Actual Result
urllib3.exceptions.InvalidHeader is raised.
Stack trace
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 515, in get
return self.request('GET', url, **kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 502, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 612, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 440, in send
timeout=timeout
File "/usr/lib/python2.7/dist-packages/urllib3/connectionpool.py", line 616, in urlopen
**response_kw)
File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 467, in from_httplib
**response_kw)
File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 155, in __init__
self.length_remaining = self._init_length(request_method)
File "/usr/lib/python2.7/dist-packages/urllib3/response.py", line 229, in _init_length
"unmatching values (%s)" % length)

exception.type: InvalidHeader
exception.value: Content-Length contained multiple unmatching values (0, 9929)

System Information
{
  "chardet": {
    "version": "3.0.4"
  },
  "cryptography": {
    "version": ""
  },
  "implementation": {
    "name": "CPython",
    "version": "2.7.14"
  },
  "platform": {
    "release": "4.12.0-2-amd64",
    "system": "Linux"
  },
  "pyOpenSSL": {
    "openssl_version": "",
    "version": null
  },
  "requests": {
    "version": "2.18.1"
  },
  "system_ssl": {
    "version": "1010006f"
  },
  "urllib3": {
    "version": "1.21.1"
  },
  "using_pyopenssl": false
}

Thanks for opening this issue, @piotrjurkiewicz! It does seem like we should try to wrap this in the Requests exception namespace. It looks like the HTTPError funnel in adapters.py raises everything it doesn't recognize (here)[https://github.com/requests/requests/blob/5eb0811ef82244afbcd865a19b796a76cdecfd71/requests/adapters.py#L523]. There are actually a few newer exceptions from urllib3 I'm not sure we're accounting for in this case.
I'm not positive what the best approach is since we'll end up with an increasingly growing exception conditional list  if urllib3 continues to add more exceptions. Alternatively, we could return a more generic wrapper exception but that'll likely make debugging harder.  I'm sure one of the other maintainers will have a leaning on which direction to go here.

Same here. Recieving an exception in console:
urllib3.exceptions.InvalidHeader: Content-Length contained multiple unmatching values (1526, 4578)


feat(SetTheory/Cardinal/Arithmetic): cardinality of supremum is at most sum of cardinalities

Thanks! :tada:
bors merge


Update README.md

This document looks not good enough without pull request! So I decide to do it. =)

What I can say? Let's do it.


focus() does not work on a controlled textarea input

Describe the bug and the expected behavior
I am trying to focus a textarea input using focus(), but it does not do anything.
Conform version
v1.2.2
Steps to Reproduce the Bug or Issue
() => {
  const historyState = useHistoryState<string>('');

  const fetcher = useFetcher<typeof action>();

  const [form, fields] = useForm({
    defaultValue: {
      message: '',
    },
    lastResult: fetcher.data?.submission,
  });

  const formRef = useRef<HTMLFormElement>(null);

  const messageInputControl = useInputControl(fields.message);

  const formProps = getFormProps(form);

  useEffect(() => {
    if (historyState.state !== messageInputControl.value) {
      messageInputControl.change(historyState.state);
    }
  }, [messageInputControl, historyState.state]);

  useEffect(() => {
    if (!chatSession.focused) {
      return;
    }

    console.log('this fires');

    messageInputControl.focus();
  }, [chatSession.focused, messageInputControl]);

  return (
    <fetcher.Form
      action={getPath('/api/chat/:uid/send-message', {
        uid: chatSession.uid,
      })}
      method="post"
      ref={formRef}
      {...formProps}
    >
      <textarea
        className={css({
          _focus: {
            border: '1px solid #00d992',
            boxShadow: 'none',
          },
        })}
        {...getTextareaProps(fields.message)}
      />
    </fetcher.Form>
  );
};

What browsers are you seeing the problem on?
No response
Screenshots or Videos
No response
Additional context
I am seeing the "this fires" event logged, but textarea is never focused.

Hi @punkpeye, thanks for your question! It looks like there was some confusion about the focus() method from useInputControl(). The key thing to note is that input.focus() simulates the browser's focus and focusin events, but it does not actually move the focus to the input element itself.
If you want to programmatically move the focus to an input field, you'll need to use the native DOM method, like inputElement.focus(), e.g.
function Example() {
  const textareaRef = useRef();

  useEffect(() => {
    if (!chatSession.focused) {
      return;
    }

    textareaRef.current.focus();
  }, [chatSession.focused, messageInputControl]);

  return (
      <textarea
        className={css({
          _focus: {
            border: '1px solid #00d992',
            boxShadow: 'none',
          },
        })}
        {...getTextareaProps(fields.message)}
        ref={textareaRef}
      />
  );
};

I've also created a PR to improve the documentation based on this, so feel free to take a look and let me know if it's still confusing or if you have more suggestions. I appreciate the feedback!
Let me know if that clears things up or if you have more questions!

This makes sense. Documentation improvements definitely help.


Running for web from macos got stuck

Description
Browser got stuck when trying to run this script from a macOS. Also flet opens the system default browser and should open Chrome as Flutter does as default.
Only happens when trying to run on web.
Run normally when using:
flet.app(target=main)

Code example to reproduce the issue:
import flet
from flet import IconButton, Page, Row, TextField, icons

def main(page: Page):
    page.title = 'Flet counter example'
    page.vertical_alignment = 'center'
    txt_number = TextField(value='0', text_align='right', width=100)

    def minus_click(e):
        txt_number.value = int(txt_number.value) - 1
        page.update()

    def plus_click(e):
        txt_number.value = int(txt_number.value) + 1
        page.update()

    page.add(
        Row(
            [
                IconButton(icons.REMOVE, on_click=minus_click),
                txt_number,
                IconButton(icons.ADD, on_click=plus_click),
            ],
            alignment='center',
        )
    )

flet.app(
    target=main,
    view=flet.WEB_BROWSER,
    web_renderer="html",
    route_url_strategy="path",
)

Describe the results you received:

Describe the results you expected:
Should open Chrome and not the system default browser.
Should appear a page with two icons and a textfield.

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
0.1.60

Operating system:
macOS
12.3.1

Additional environment details:
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.3.2, on macOS 12.3.1 21E258 darwin-arm, locale
    en-ES)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.71.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

What is your system default browser? Are there any errors in JS console of browser developers tools?

I am not a Flutter guy, but can you please explain why this is required?
And btw, what if Chrome is not installed?

I am not a Flutter guy, but can you please explain why this is explicitly required?
And btw, what if Chrome is not installed?

First, as dev I would want to run Flutter web on my MacBook as I do normally with Flutter apps. So maybe is a hidden bug that could appear in other base system
Flutter documentation says that u need chrome for debugging
https://docs.flutter.dev/get-started/web

What is your system default browser? Are there any errors in JS console of browser developers tools?

I'm using Firefox as system default.
There are no errors in browser console and terminal. Btw if I paste the deployed local url in Chrome also didn't work

What do you have on Network tab then, what resources are being loaded?

What do you have on Network tab then, what resources are being loaded?


Add missing call to example code

Add missing call to the example code for multivariate data interpolation

Indeed. Thank you @michaelbratsch !


:wrench:  add eslint rules to enfore code styling

Description
Set of @typescript-eslint rules to enforce coding style.
Checklist

[x] My changes follow the contributing guidelines of this project.
[x] I have performed a self-review of my code.
[ ] I have made corresponding changes to the documentation.
[ ] I have added tests that prove my fix is effective or that my changes work.
[x] New and existing unit tests pass locally with my changes.

coverage: 94.13%. remained the same when pulling 3657efc79e1f2ce90c4d57aeed81b90a3f2f262f on chore/extend-eslint-rules into 3cdb26ede1a629c98c498cf495bd7e29d05d109d on main.


Update extension API examples

https://github.com/lensapp/lens-extension-samples

Extension installed following tutorial https://api-docs.k8slens.dev/v5.3.4/extensions/guides/generator/ results:

@bukowa thanks for the notification. That certainly should be fixed.


Pdf Js(v 2.9.359) - Canvas images not getting generated from the pdf pages.

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version:
Operating system and its version:
PDF.js version:
Is a browser extension:

Steps to reproduce the problem:
1.
2.
What is the expected behavior? (add screenshot)
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

When opening an issue, please provide all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md since a title alone isn't anywhere near enough information to make an issue actionable.
Please also see https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md (emphasis mine):

If you are developing a custom solution, first check the examples at https://github.com/mozilla/pdf.js#learning and search existing issues. If this does not help, please prepare a short well-documented example that demonstrates the problem and make it accessible online on your website, JS Bin, GitHub, etc. before opening a new issue or contacting us in the Matrix room -- keep in mind that just code snippets won't help us troubleshoot the problem.


Change find-def behavior to match Leo's nav pane UI results.

Remove find-var and change find-def behavior to match Leo's nav pane UI results, showing results in the goto panel.

Done in devel!


chore: Remove metadata.json (storage/mysql-single-server) (auto-generated)

This PR was created by a script. Please review the changes and merge if they look good.

/azp run

/azp run

/azp run


CRUD service

Warning !!
Return bad request when you delete a service if an employee is assigned
Model

id
name

Use cases

create a service
list all services
get one service
delete a service if no user is associated

TODO

Refactor services as departments


Could we have a docker image to run this

Would it be useful to package this in a docker image to make it easier to test without installing node.js and other dependencies?

Hi @mikeysan, great idea 👍 !
Yes, in my opinion, it would make it easier on new contributors to test the app locally and mess around. Currently we are thinking about changing Firebase Firestore into another DB (you can check out the discussion here).
So, we might postpone this idea of dockerizing EddieBotUI for later. What do you think @mikeysan ?

Hey, @BOLT04 sounds like a great idea to postpone it. I believe Eddie mentioned something to that effect, but I thought I would open the issue while I still remembered to do so.

EddieBot has a Docker PR by @stemount which looks great. I just need to switch some envars around. Once we have 1 dockerised, it will be easier to do more 👍 .


Error Https > Error code: SEC_ERROR_BAD_SIGNATURE

I have an error like this:
Firefox:
Secure Connection Failed
An error occurred during a connection to support.mozilla.org. Peer’s certificate has an invalid signature.
Error code: SEC_ERROR_BAD_SIGNATURE
Chrome:
Your connection is not private
Attackers might be trying to steal your information from www.google.com (for example, passwords, messages, or credit cards). Learn more
NET::ERR_CERT_AUTHORITY_INVALID
can you lead me?
`
    public static void Main(string[] args)
    {
        var proxyServer = new ProxyServer();
        proxyServer.ProxyAuthenticationRealm = "";

        Func<SessionEventArgsBase, string, string, Task<bool>> p = async (args, userName, password) =>
                          {
                              return true;
                          };
        proxyServer.ProxyBasicAuthenticateFunc = p;

        proxyServer.CertificateManager.CertificateEngine = Titanium.Web.Proxy.Network.CertificateEngine.BouncyCastle;

        var explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 81, true)
        {
            // Use self-issued generic certificate on all https requests
            // Optimizes performance by not creating a certificate for each https-enabled domain
            // Useful when certificate trust is not required by proxy clients
            // GenericCertificate = new X509Certificate2(Path.Combine(System.IO.Path.GetDirectoryName(System.Reflection.Assembly.GetExecutingAssembly().Location), "genericcert.pfx"), "password")
        };

        proxyServer.AddEndPoint(explicitEndPoint);
        proxyServer.Start();

    }

`

I see this same problem, but only on Linux. Works fine on Mac and Windows. Bug in BouncyCastle maybe?

I'm receiving this problem as well with latest version.

_proxyServer.CertificateManager.CertificateEngine = Titanium.Web.Proxy.Network.CertificateEngine.BouncyCastle;  _proxyServer.CertificateManager.CertificateValidDays = 365;  _rootCertificate = _proxyServer.CertificateManager.RootCertificate;  File.WriteAllBytes($"wwwroot/Cert/ProxyManRootCert.cer", _rootCertificate.Export(X509ContentType.Cert));
work well in windows / mac /liunx  （add ProxyManRootCert.cer by ca-certificates in liunx）
titanium-web-proxy version is 3.1.1397

This error is you have to decrypt ssl and create a new self-sign, and you dont install a self-sign root certificate after start proxy.
Change ExplicitEnpoint to:
var explicitEndPoint = new ExplicitProxyEndPoint(IPAddress.Any, 81, false);


Flagd provider

https://github.com/open-feature/golang-sdk-contrib/issues/2

Can I get added as reviewer ?


Service-Catalog appears to not be passing valid broker auth credentials

The meta azure service broker's catalog endpoint returns with the following JSON (abridged):
{
	"services": [{
		"id": "3befc561-4f0c-4df3-ab26-48ac4e366b1c",
		"name": "azure-documentdb",
		"description": "Azure DocumentDb Service",
		"bindable": true,
		"plans": [{...}]
        }]
}

This appears to be a valid catalog response body, but when the (v0.0.10) controller hits it, the Broker gets the following condition set on it:
    message: Error syncing catalog from Broker. Error getting catalog payload for
      broker "masb"; received zero services; at least one service is required
    reason: ErrorSyncingCatalog

More debugging details to come here. I have reproduced this issue with the steps outlined at https://github.com/arschles/meta-azure-service-broker-helm, using the v0.0.10 version of the controller.

If you get the exact json, we can try and make a test case out of it.

Additional detail:
When no basic auth credentials are passed to the Azure broker, it returns a 401 and {} in the response body. This behavior is spec-compliant, according to the authentication section.
The response body explains the ErrorSyncingCatalog status.
I'm not sure why no auth creds are being passed. If the secret with broker basic auth credentials were missing, that should be returned in the error condition. Otherwise, the auth secret credentials should be fetched and passed appropriately. I have verified that the Azure broker is receiving invalid credentials:
info: [Meta Azure Service Broker] handleCatalogRequest - ::ffff:<IP_ADDRESS>:54326
info: [common] 401 - GET - /v2/catalog
error: [Meta Azure Service Broker] Invalid auth credentials for requests.

... and that the basic auth secret that the Broker references -- masb-meta-azure-service-broker-auth in the masb namespace -- exists:
admins-MacBook-Pro:service-catalog aaschles$ k get secret -n masb -o yaml masb-meta-azure-service-broker-auth
apiVersion: v1
data:
  password: cGFzc3dvcmQ=
  username: dXNlcm5hbWU=
kind: Secret
metadata:
  creationTimestamp: 2017-06-16T22:28:55Z
  labels:
    app: masb-meta-azure-service-broker
    chart: meta-azure-service-broker-0.1.0
    heritage: Tiller
    release: masb
  name: masb-meta-azure-service-broker-auth
  namespace: masb
  resourceVersion: "44272"
  selfLink: /api/v1/namespaces/masb/secrets/masb-meta-azure-service-broker-auth
  uid: 2efb0399-52e3-11e7-aedb-000d3a73d7db
type: Opaque

I have also verified that this works properly on v0.0.9.

Also, since the nature of this issue has changed, I've changed the title accordingly.

On the hint of diff between versions, I looked at https://github.com/kubernetes-incubator/service-catalog/compare/v0.0.9...v0.0.10
The only obvious candidate from commit messages (YAY GOOD COMMIT MESSAGES) was https://github.com/kubernetes-incubator/service-catalog/commit/066159de54ac8f314422165320067fc66cae61fd
Inside of that the auth format of the yaml changed, as well as validation. Could be either or both.
Is there a test that would have caught this, or is it an API change that we made that self corrected?

@MHBauer I believe that it's 066159d as you said. I'll test to verify.
I don't think there'd be a test to cover the transition, since we would have changed all of the Broker resources too.
However, the authInfo field defaults to empty (because of the omitEmpty struct tag here), and that's not spec-compliant ("The marketplace MUST authenticate with the service broker using HTTP basic authentication"). I will submit a PR to fix that, and that fix should at least make a better error arise in this situation.

yay!

@MHBauer see https://github.com/kubernetes-incubator/service-catalog/pull/956 for a fix

Given that auth will hopefully soon be optional, what does that mean for this issue?


project simulation

Hi Radhikha Myneni,
I am new to SAS EM.  I went through your uploaded materials and it is very clear.
I am trying to replicate the flow as per your materials.  It would be great if you can share any step by step instructions or user guide for a beginner like me.
Best,
Arul
<EMAIL_ADDRESS>+65-94569429

Hi Arul,
The examples in this repository are xml files that can be imported as a diagram into SAS Enterprise Miner. As documented in the instructions of the repository READMEhttps://github.com/sassoftware/dm-flow/blob/master/README.md, you have to create a new project and import the XML. The xml files also have a pdf associated with them in the same directory that describes the technique implemented in more detail.
For more details or introduction about SAS Enterprise Miner, here is the documentation page to start with:
http://support.sas.com/documentation/onlinedoc/miner/index.html
Hope this helps,
Radhikha
From: okarul<EMAIL_ADDRESS>Sent: Friday, March 30, 2018 10:08 PM
To: sassoftware/dm-flow<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [sassoftware/dm-flow] project simulation (#3)
EXTERNAL
Hi Radhikha Myneni,
I am new to SAS EM. I went through your uploaded materials and it is very clear.
I am trying to replicate the flow as per your materials. It would be great if you can share any step by step instructions or user guide for a beginner like me.
Best,
Arul
okarul<EMAIL_ADDRESS>+65-94569429
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/sassoftware/dm-flow/issues/3, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALtOihEx_Ow1_eaEiPK3VllzTJcHf-2cks5tjuT0gaJpZM4TCSv7.


⚠ PrivateHD has degraded performance

In 41970c9, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2089 ms

Resolved: PrivateHD performance has improved in b21a32b.


fix(08-wasm)!: use concrete types for json serialization

Description
TODO: sanity check type assertions bool values
closes: #4908

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md).
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/).
[ ] Added relevant godoc comments.
[ ] Provide a commit message to be used for the changelog entry in the PR description for review.
[ ] Re-reviewed Files changed in the Github PR explorer.
[ ] Review Codecov Report in the comment section below once CI passes.

With this PR, I could successfully get a test scaffolding together like this for VerifyMembership


Can't specify kafka configuration revision

    Message:               create failed: cannot create Cluster in AWS: InvalidParameter: 1 validation error(s) found.
- missing required field, CreateClusterInput.ConfigurationInfo.Revision.

When MSK is deployed via UI, it requires a revision of the configuration be selected.

It's in the example


Open Info Window when load map

Bug
I need open info window tool tip while opening map but currently my code shows tool tip only press on that icon.Kindly give me any code or idea for open info window with out onpress
My Code
<Marker coordinate={{ latitude:Number(this.state.latitude), longitude:Number(this.state.longitude)}}  >
<Thumbnail square style={{ width: 40, height: 40 }} source={require('/marker.png')} ></Thumbnail>
 <Callout tooltip={true}>
   <View  style={styles.View2}>
     <Text style={styles.popup}>Description</Text>
    </View>
  </Callout>
</Marker>

Environment info
react-native : 0.61
react-native-maps: 0.26.1

I think you are looking for showCallout https://github.com/react-native-community/react-native-maps/blob/master/docs/marker.md#methods
You can probably just save a ref to the marker and open it once the map is ready, something like this
<Map
  onMapReady={() => { this.defaultMarker.showCallout() }
>
  <Marker ref={(ref) => this.defaultMarker = ref} />
</Map>

I think you are looking for showCallout https://github.com/react-native-community/react-native-maps/blob/master/docs/marker.md#methods
You can probably just save a ref to the marker and open it once the map is ready, something like this
<Map
  onMapReady={() => { this.defaultMarker.showCallout() }
>
  <Marker ref={(ref) => this.defaultMarker = ref} />
</Map>

Its working but onMapReady not work.So I have using onRegionChange instead of onMapReady.
Thanks @kriscarle


Trying to commit but it error: cannot spawn .husky/pre-commit: No such file or directory

Summary
Getting error: cannot spawn .husky/pre-commit: No such file or directory when trying to commit, previously ran npm install.
This started to happen when I upgraded to sfdx-cli/7.111.0.
Today I  updated SFDX CLI but the error continues.
Steps To Reproduce:

Run npm install
Make some changes
Git add .
Git commit -m "Test this"

Repository to reproduce: NotificationApp

Run npm install
Make some changes to the files
Run git add .
Run git commit -m "Test this"

Expected result
Commit successfully with no errors.
Actual result
error: cannot spawn .husky/pre-commit: No such file or directory when trying to commit.
System Information
{
        "cliVersion": "sfdx-cli/7.112.0",
        "architecture": "win32-x64",
        "nodeVersion": "node-v14.17.4",
        "pluginVersions": [
                "@oclif/plugin-autocomplete 0.3.0 (core)",
                "@oclif/plugin-commands 1.3.0 (core)",
                "@oclif/plugin-help 3.2.2 (core)",
                "@oclif/plugin-not-found 1.2.4 (core)",
                "@oclif/plugin-plugins 1.10.1 (core)",
                "@oclif/plugin-update 1.4.0-3 (core)",
                "@oclif/plugin-warn-if-update-available 1.7.0 (core)",
                "@oclif/plugin-which 1.0.3 (core)",
                "@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
                "@salesforce/sfdx-trust 3.6.0 (core)",
                "alias 1.1.10 (core)",
                "apex 0.2.3 (core)",
                "auth 1.7.1 (core)",
                "config 1.2.14 (core)",
                "custom-metadata 1.0.12 (core)",
                "data 0.6.0 (core)",
                "etcopydata 0.5.7",
                "generator 1.1.7 (core)",
                "limits 1.2.1 (core)",
                "org 1.6.7 (core)",
                "salesforce-alm 52.2.2 (core)",
                "schema 1.0.8 (core)",
                "sfdx-cli 7.112.0 (core)",
                "source 1.0.6 (core)",
                "telemetry 1.2.3 (core)",
                "templates 52.1.0 (core)",
                "user 1.4.0 (core)"
        ],
        "osVersion": "Windows_NT 10.0.19042"
}

Additional information
package.json file
{
  "name": "salesforce-app",
  "private": true,
  "version": "1.0.0",
  "description": "Salesforce App",
  "scripts": {
    "lint": "npm run lint:lwc && npm run lint:aura",
    "lint:aura": "eslint **/aura/**",
    "lint:lwc": "eslint **/lwc/**",
    "test": "npm run test:unit",
    "test:unit": "sfdx-lwc-jest",
    "test:unit:watch": "sfdx-lwc-jest --watch",
    "test:unit:debug": "sfdx-lwc-jest --debug",
    "test:unit:coverage": "sfdx-lwc-jest --coverage",
    "prettier": "prettier --write \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}\"",
    "prettier:verify": "prettier --list-different \"**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}\"",
    "postinstall": "husky install",
    "precommit": "lint-staged"
  },
  "devDependencies": {
    "@lwc/eslint-plugin-lwc": "^1.0.1",
    "@prettier/plugin-xml": "^0.13.1",
    "@salesforce/eslint-config-lwc": "^2.0.0",
    "@salesforce/eslint-plugin-aura": "^2.0.0",
    "@salesforce/eslint-plugin-lightning": "^0.1.1",
    "@salesforce/sfdx-lwc-jest": "^0.13.0",
    "eslint": "^7.29.0",
    "eslint-config-prettier": "^8.3.0",
    "eslint-plugin-import": "^2.23.4",
    "eslint-plugin-jest": "^24.3.6",
    "husky": "^6.0.0",
    "lint-staged": "^11.0.0",
    "prettier": "^2.3.1",
    "prettier-plugin-apex": "^1.9.1"
  },
  "lint-staged": {
    "**/*.{cls,cmp,component,css,html,js,json,md,page,trigger,xml,yaml,yml}": [
      "prettier --write"
    ],
    "**/{aura,lwc}/**": [
      "eslint"
    ]
  }
}

did you add husky or did it come from project:create ?  What's in .husky folder or .huskyrc.js?

a quick solution would be to run force:project:create somewhere else and then move over the .husky directory that it creates to this project

did you add husky or did it come from project:create ? What's in .husky folder or .huskyrc.js?
When was the project created?

It came from project:create.

I just tested this:
Created the project using sfdx:project:create, initialized a github repo using git init, created git repo using gh repo create, added files using git add ., committed changes via git commit -m "<MSG>", it worked fine, then I ran npm install, made some changes and repeated the process to commit and it errored.
@mshanemc

I can't get the error to appear.
Does the error reproduce for you only if you gh repo create or is that step irrelevant?

Hi @icrm-af, let's try to reproduce the issue with the simplest scenario.
Can you run these four commands:
sfdx force:project:create -n test
cd test
git init
git commit -a -m "Initial commit"

In order to figure out what's wrong, we need to see the output of these commands.
Can you save them and share them here?

Log for:
sfdx force:project:create -n test
{
  "status": 0,
  "result": {
    "outputDir": "C:\\Users\\myUser\\Desktop\\VSCode Projects",
    "created": [
      "test\\config\\project-scratch-def.json",
      "test\\README.md",
      "test\\sfdx-project.json",
      "test\\.husky\\pre-commit",
      "test\\.vscode\\extensions.json",
      "test\\.vscode\\launch.json",
      "test\\.vscode\\settings.json",
      "test\\force-app\\main\\default\\lwc\\.eslintrc.json",
      "test\\force-app\\main\\default\\aura\\.eslintrc.json",
      "test\\scripts\\soql\\account.soql",
      "test\\scripts\\apex\\hello.apex",
      "test\\.eslintignore",
      "test\\.forceignore",
      "test\\.gitignore",
      "test\\.prettierignore",
      "test\\.prettierrc",
      "test\\jest.config.js",
      "test\\package.json"
    ],
    "rawOutput": "target dir = C:\\Users\\myUser\\Desktop\\VSCode Projects\n   create test\\config\\project-scratch-def.json\n   create test\\README.md\n   create test\\sfdx-project.json\n   create test\\.husky\\pre-commit\n   create test\\.vscode\\extensions.json\n   create test\\.vscode\\launch.json\n   create test\\.vscode\\settings.json\n   create test\\force-app\\main\\default\\lwc\\.eslintrc.json\n   create test\\force-app\\main\\default\\aura\\.eslintrc.json\n   create test\\scripts\\soql\\account.soql\n   create test\\scripts\\apex\\hello.apex\n   create test\\.eslintignore\n   create test\\.forceignore\n   create test\\.gitignore\n   create test\\.prettierignore\n   create test\\.prettierrc\n   create test\\jest.config.js\n   create test\\package.json\n"
  }
}

Log for:
git init
Initialized empty Git repository in C:/Users/myUser/Desktop/VSCode Projects/test/.git/
Log for:
npm install
`

<EMAIL_ADDRESS>postinstall C:\Users\myUser\Desktop\VSCode Projects\test\node_modules\core-js
node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!
The project needs your help! Please consider supporting of core-js:
> https://opencollective.com/core-js
> https://patreon.com/zloirock
> https://paypal.me/zloirock
> bitcoin: bc1qlea7544qtsmj2rayg0lthvza9fau63ux0fstcz
Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

<EMAIL_ADDRESS>postinstall C:\Users\myUser\Desktop\VSCode Projects\test
husky install

husky - Git hooks installed
added 961 packages from 378 contributors and audited 963 packages in 866.328s
89 packages are looking for funding
run npm fund for details
found 0 vulnerabilities
`
Output for git commit:
git commit -a -m "Initial commit" >> git_commit_log.txt
error: cannot spawn .husky/pre-commit: No such file or directory

@pozil

I can't get the error to appear.
Does the error reproduce for you only if you gh repo create or is that step irrelevant?

That step is irrelevant.

I'll uninstall and install everything again.

I uninstalled Git, SFDX CLI, Node, Heroku, and many other tools, ran a cleanup, installed everything again, and the same issue, I know is related to my computer but I would like to find a way to fix this instead of living with it or reinstall my OS.

Thanks for sharing your logs @icrm-af, everything looks normal.
I saw that Husky updated it's commit hook template but I'm not sure if this has an impact.
Can you replace the content of .husky/pre-commit with the following (the second line is new):
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run precommit

Once the file is updated, try to commit something to check if this fixes the pre-commit hook.

Thanks for sharing your logs @icrm-af, everything looks normal.
I saw that Husky updated it's commit hook template but I'm not sure if this has an impact.
Can you replace the content of .husky/pre-commit with the following (the second line is new):
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run precommit

Once the file is updated, try to commit something to check if this fixes the pre-commit hook.

@pozil that worked.
But seems to be something wrong with my environment, because it doesn't fail in other instances.

Thanks for the update. I'm pushing this change to the new DX project template just in case.

My fix has been incorporated in the DX project template and should be available in the upcoming Salesforce CLI release.
@mshanemc we can close this issue.

@pozil issue came back, but now I'm on a different computer, clean OS.
After I do npm install on a fresh project and then try to commit changes, error: cannot spawn .husky/pre-commit: No such file or directory appears.

Damn :(
My proposed fix hasn't landed on the CLI GA branch yet so I'm wondering if there's something else to it.
Can you apply it manually (edit .husky/pre-commit) and check if it helps?


Partially broken high-contrast support in Poedit

From v1.7 I think, Poedit's UI started having problems supporting the high-contrast color mode in Windows. Even though my OS is set to use the high-contrast black color theme in Windows 10, some controls in Poedit's UI refuses to obey the colors defined in Windows and uses his own ones. Version 1.6 of Poedit does not have such issues. I'll attach a few screenshots. The first one is from Poedit v1.6 and the other two - from Poedit v2.0.2.
Steps to reproduce it:

Install Poedit v2.0.2.
Go to Windows Settings -> Ease of Access -> High Contrast and from the "High-Contrast Theme" combo box choose "High-Contrast Black". Then click "Apply".
Open a .po file in Poedit v2.0.2 and look around the UI of Poedit.

Expected results:
Poedit should use the colors defined in the selected Windows theme for all of its components. In this case - black background and white text.
Actual results:
Poedit uses white background (and in some cases - black text) for some of its controls.
Test environment:

Operating system: Windows 10 Pro version 1703 (build 15063.483), 64-bit, in Bulgarian with all locale settings set to "Bulgarian".
Poedit version: 2.0.2, in english.

Can this be fixed?
Thanks much in advance!

I'm aware. See also #273, which is the same thing on Linux. I hoped for a proper fix with dynamically reacting to settings changes, but I suppose static support is better than none.

So, is it fixable or not?

Did I say anything about not being able to fix it? Did I close the bug as WONTFIX? There's your answer.

OK, sorry for the misunderstanding.

The problem seams to be almost completely fixed. The only incorrect color now is the color of the text for a selected item in the translations list. See attached screenshot - in it, the correct color should be black, as it is for the highlighted menu item, but in the translations list the text for a highlighted item is white, making it hard to read.

Oops, forgot the attachment. Here it is.


feat: add icons to the set

Resolves #25027

Adds more icons.

Revise to alphabetical order for ease of use (adds alphabetical hashes for searchability)

Removes List to avoid naming conflict. It looks like ListOutline and List. If approved, will rename List  to ListOutline

Removes List to avoid naming conflict. It looks like ListOutline and List. If approved, will rename List to ListOutline

Typically not good practice to remove something as it requires a major bump.

Removes List to avoid naming conflict. It looks like ListOutline and List. If approved, will rename List to ListOutline

Typically not good practice to remove something as it requires a major bump.

@mikeldking ah - List is not originally in this library, only ListOutline. So instead of remove, I think omit is a better term

Removes List to avoid naming conflict. It looks like ListOutline and List. If approved, will rename List to ListOutline

Typically not good practice to remove something as it requires a major bump.

@mikeldking ah - List is not originally in this library, only ListOutline. So instead of remove, I think omit from the migration is a better term. Would the impact still be the same?

Ah I see - yeah better to name outline vs filled. Let's leave as is. Thanks @kryskirkland


Auto Hide keyboard on clicking outside & on opening navigation drawer.

@mananwason @championswimmer
Automatically hide the keyboard if user touches outside it or opens the navigation drawer.
This fixes #222 and #198.
This is a better alternative to  #249 as there are fewer lines of code and it fixes both issues at once.
Cheers.

This looks better to me
On 04-Apr-2016 3:28 pm, "Harshit Dwivedi"<EMAIL_ADDRESS>wrote:

@mananwason https://github.com/mananwason @championswimmer
https://github.com/championswimmer
Automatically hide the keyboard if user touches outside it or opens the
navigation drawer.
This fixes #222
https://github.com/fossasia/open-event-android/issues/222 and #198
https://github.com/fossasia/open-event-android/pull/198.
This is a better alternative to #249
https://github.com/fossasia/open-event-android/pull/249 as there are
fewer lines of code and it fixes both issues at once.
Cheers.
You can view, comment on, or merge this pull request online at:
https://github.com/fossasia/open-event-android/pull/329
Commit Summary

Auto Hide keyboard on clicking outside & on opening nav drawer.

File Changes

M
app/src/main/java/org/fossasia/openevent/activities/MainActivity.java
https://github.com/fossasia/open-event-android/pull/329/files#diff-0
(21)

Patch Links:

https://github.com/fossasia/open-event-android/pull/329.patch
https://github.com/fossasia/open-event-android/pull/329.diff

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/fossasia/open-event-android/pull/329

ok i am using this right now, and feels a bit clunky.
if I change the cursor in the textbox, the keyboard goes away too.
maybe just doing it for navdrawer is ok, not for the everything-outside-the-rectangle thing.

@championswimmer I just tried it and did not face such problem.
Could you let me know which fragment caused this issue?
I have attached the gif depicting the same. (2.9m)
Cheers.

Please have a look in #249 DISCUSSION in #198

@championswimmer works nicely on my device too. @opticod yours doesn't work when we click on the navigation drawer

@mananwason , it can be easily added by KeyboardHelper.hideKeyboard(this, findViewById(R.id.<element_ID>)); , an my PR was opened before this Navigation drawer issue.

@opticod I know that but I saw in the code that you have already used it on
the navigation drawer but it's still not working.
On 09-Apr-2016 2:32 PM, "Anupam Das"<EMAIL_ADDRESS>wrote:

@mananwason https://github.com/mananwason , it can be easily added by KeyboardHelper.hideKeyboard(this,
findViewById(R.id.<element_ID>)); , an my PR was opened before this Navigation
drawer issue.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/fossasia/open-event-android/pull/329#issuecomment-207750124

@opticod yeah I do understand that yours is older, but imo,  mine fixes the issue in fewer lines of code and it fixes both of the issues at once.
Cheers.

@mananwason , yah I have implemented in slight different way, if in the navigation drawer

we tried to scroll
or we clicked any item in the drawer,
then it will automatically hide else on clicking outside the drawer retains the Keyboard for more inputs.

@opticod When I tried your version, it wasn't hiding the keyboard when I opened the drawer.

@mananwason , i repeat, I have implemented in different way

I haven't incorporate to hide the keyboard on opening the drawer , as to me while creating the PR , was not the normal behavior.

But after opening the drawer , if we click on any items inside the drawer( also include the red-hat image) or tried to scroll, then it will auto-hide else if we click outside the drawer, it will keep the keyboard open , as the user may want to enter more texts.

@opticod it works when you scroll but it's not working when I click on a drawer item. Check this out.

@mananwason , right, I haven't set the keyboard to hide on fragment transactions.

@mananwason , Should I update my PR to add this feature too?

@mananwason , I have also added it.

@mananwason @championswimmer Shall i merge this?


Synthetic event error in TopAppBarNavigationIcon

What RMWC Version are you using [major.minor.patch]: 5.7.0

Name your build system [Webpack, Rollup...]: Webpack

Describe the bug with as much detail as possible:
Clicking the icon of <TopAppBarNavigationIcon /> results in a console warning

Warning: This synthetic event is reused for performance reasons. If you're seeing this, you're accessing the property `type` on a released/nullified synthetic event. This is set to null. If you must keep the original synthetic event around, use event.persist(). See https://fb.me/react-event-pooling for more information.

What happened, and what was supposed to happen:
The warning appears when toggling state and is probably related to the icon being changed to the onIcon and vice versa. However, as you can see in the CodeSandBox example it happens even when onIcon is not used.

https://codesandbox.io/s/rmwc-sandbox-g3ou0
Since TopAppBarNavigationIcon is meant to be an instance of IconButton, I also added an IconButton to the right side of the bar which toggles without an error.
I will try to find some time to narrow it down to a specific line.

The code sandbox you sent is set on the 6.0.0 alpha version actually. The issue doesn't appear to be in 5.7.x. Are you running v6?

nvm, repoed it

Released and fixed in 5.7.2

That was fast. Works like a charm, thanks :)


Add command to check merkle root

Closes: #48
I added the chatty Calculate ... outputs to show some progress to the user. For the current test, the root calculation by the airdrop file (400k addresses) needs ~1:30min. Without any output for such a long time, the user could become skeptical.

Codecov Report

Merging #62 into master will increase coverage by 1.8%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #62     +/-   ##
=========================================
+ Coverage   76.41%   78.22%   +1.8%
=========================================
  Files           7        7
  Lines         301      326     +25
=========================================
+ Hits          230      255     +25
  Misses         71       71

Impacted Files
Coverage Δ

merkle_drop/cli.py
96.09% <100%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578c2ad...6737d4c. Read the comment docs.


support sasl_mechanisms config

What does this parameter used for?
Configuration property: "sasl.mechanisms"
Usage: SASL mechanism to use for authentication. Supported: GSSAPI, PLAIN, SCRAM-SHA-256, SCRAM-SHA-512, OAUTHBEARER. NOTE: Despite the name only one mechanism must be configured.
Why add it?
when connecting to the Kafka in confluent.cloud, this parameter is a mandatory property.
Here is an example to connect confluent kafka.
# ruby code

config = {
  :"bootstrap.servers" => "pkc-pgq85.us-west-2.aws.confluent.cloud:9092",
  :"group.id" => "ruby-test",
  :"security.protocol" => "SASL_SSL",
  :"sasl.mechanisms" => "PLAIN",
  :"sasl.username" => 'your username',
  :"sasl.password" => 'your password'
}
consumer = Rdkafka::Config.new(config).consumer
consumer.subscribe("core.onboarding.employees")

consumer.each do |message|
  puts "Message received: #{message}"
end

Reference:
https://docs.confluent.io/platform/current/clients/librdkafka/html/md_CONFIGURATION.html
Related Issue
https://github.com/zendesk/racecar/issues/254

racecar has already supported sasl.mechanism, which is an alias of ``sasl.mechanisms`. You can use the following example code to connect to kafka.
config = {
  :"bootstrap.servers" => "your-kafka.us-west-2.aws.confluent.cloud:9092",
  :"group.id" => "ruby-test",
  :"security.protocol" => "SASL_SSL",
  :"sasl.mechanism" => "PLAIN",
  :"sasl.username" => 'your username',
  :"sasl.password" => 'your password'

}
consumer = Rdkafka::Config.new(config).consumer
consumer.subscribe("core.onboarding.employees")

consumer.each do |message|
  puts "Message received: #{message}"
end


Implement to_csv for Dataset

cc @thomwolf
to_csv supports passing either a file path or a binary file object
The writing is batched to avoid loading the whole table in memory

@lhoestq I stumbled upon an interesting failure when adding tests for CSV serialization of ArrayXD features (see the failing unit tests in the CI)
It's due to the fact that booleans cannot be converted from arrow format to numpy with copy: https://arrow.apache.org/docs/python/generated/pyarrow.Array.html#pyarrow.Array.to_numpy

Good catch ! I must be able to fix that one by allowing copies for this kind of arrays.
This is the kind of surprise you get sometimes when playing with arrow x)

Raising this error for booleans was introduced in https://issues.apache.org/jira/browse/ARROW-2871?jql=text ~ "boolean to_numpy" without much explanations unfortunately.
So "no copy" only works for primitive types - except booleans.
This is confirmed in the source code at https://github.com/wesm/arrow/blob/c07b9b48cf3e0bbbab493992a492ae47e5b04cad/python/pyarrow/array.pxi#L621
I'm opening a PR to allow copies for booleans...

I just merged the fix for boolean ArrayXD, feel free to merge from master to see if it fixes the ci :)

@lhoestq unfirtunately, arrays of strings (or any other non-primitive type) require a copy too
A list of primitive types can be found here: https://github.com/wesm/arrow/blob/c07b9b48cf3e0bbbab493992a492ae47e5b04cad/python/pyarrow/types.pxi#L821
pyarrow provides a is_primitive function to check whether a type is primitive , I used it to set zero_copy_only
Also, PandasArrayExtensionArray.isna was using numpy.isnan which fails for arrays of strings. I replaced it with pandas.isna. Let me know what you think! :)