fixing some documentation, adding skeleton for spice lessons

Coverage remained the same at 95.11% when pulling 310cfb59da99e97df1acdca0277cae619edc4a51 on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.

Coverage remained the same at 95.11% when pulling 8ebd4397ca00e1049b2906befda37f1df30ba30b on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.

Coverage remained the same at 95.11% when pulling<PHONE_NUMBER>83dad0fc28f3daff68fb7c4a6bae09 on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.

Coverage remained the same at 95.11% when pulling 8eae2c1142b2f0e41b13d20b93e9cebf9f23694f on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.

Coverage remained the same at 95.11% when pulling 136af0d7916676b8286d61f132a4b232ed466ae5 on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.

Coverage decreased (-0.03%) to 95.077% when pulling f03d312aaf68bebca72ee5a8ddcb3f6665b5b291 on adding_lessons into 596debfae2fdb5776c0f660ea44c42cfcf8270f9 on master.


Update codebase

Update codebase for the existing Graphs with the latest functionalities
Add Process Behaviour Graphs

CI cries

CI cries

Fixing it


Fixes 4745 : Add bookmarked items to suggested depictions

Description (required)
Fixes #4745
What changes did you make and why?
Since bookmarked items are probably things that the user has an interest in, I append them when suggesting depictions.
Tests performed (required)
Tested ProdDebug on Pixel 3 with API level 30.

I will start reviewing this after https://github.com/commons-app/apps-android-commons/pull/4725 (which is higher priority) is perfected and merged, thanks for both! :-)

@nicolas-raoul As #4725 is merged, you can review it now.


docs(atomic): hide a component

In the release, I noticed this atomic commerce component that should be hidden, so here you go 🙂
https://coveord.atlassian.net/browse/KIT-3723

The add generated file automatic commit doesn't re trigger the CI. It's a small bug we have. You can use git commit --allow-empty -m "Trigger Build" to trigger it with an empty commit


Postman Web is now out. It might be great to find a USP for Postwoman

Hi. Just read an announcement about Postman for Web: https://web.postman.co/
Like postwoman for its design, being open source and light, but may be its time to find the USP now that postman has released the web version.

Okay. Cool.

Lol this exactly took ticket 1000 😅😂


Minimal manual translation for Home screen

Localization effort is WIP, doing minimal translation of home page string manually before the full localization and translation to Serbian is ready

Wrong branch for PR, sorry!


User input starting with a slash is interpreted as an intent

Rasa version: 1.6.1
Python version: 3.6
Operating system (windows, osx, ...): Ubuntu
Issue:
When a user enters an input with a slash such as /start, Rasa NLU recognizes this input as the intent start with 100% confidence even though the intent does not exist in the domain file.
I tried adding /start in the NLU training data for another intent (greeting) but it still recognizes it as start.
Note that the same thing happens with inputs such as / start, / get started (recognized intent: get started), etc.
Error (including full traceback):
Entering /start in the Rasa shell returns:
{
  "text": "/start",
  "intent": {
    "name": "start",
    "confidence": 1.0
  },
  "intent_ranking": [
    {
      "name": "start",
      "confidence": 1.0
    }
  ],
  "entities": []
}

while entering start in the Rasa shell correctly returns:
{
  "intent": {
    "name": "greeting",
    "confidence": 0.9929155111312866
  },
  "entities": [],
  },
  "intent_ranking": [
    {
      "name": "greeting",
      "confidence": 0.9929155111312866
    },
    ...
  ],
  "text": "start"
}

Command or request that led to error:
rasa shell nlu
/start

Content of configuration file (config.yml) (if relevant):
language: "en"
pipeline:
  - name: "SpacyNLP"
    case_sensitive: true
  - name: "SpacyTokenizer"
  - name: "SpacyEntityExtractor"
    dimensions: [...]
  - name: "DucklingHTTPExtractor"
    url: ...
    dimensions: ["time", ...]
    timezone: "America/New_York"
  - name: "RegexFeaturizer"
  - name: "SpacyFeaturizer"
  - name: "CRFEntityExtractor"
    features: [...]
  - name: "EntitySynonymMapper"
  - name: "EmbeddingIntentClassifier"

Content of domain file (domain.yml) (if relevant):
start is not present in the domain file

This is expected and we need this special treatment of these kind of messages. It is possible to modify the used character / to something else though (constant INTENT_MESSAGE_PREFIX).


⚠ BroadcasTheNet has degraded performance

In a265d5d, BroadcasTheNet ($BTN) experienced degraded performance:

HTTP code: 200
Response time: 1257 ms

Resolved: BroadcasTheNet performance has improved in f6d4742 after 26 minutes.


CLI Installation Checklist updates, typo fixes

Signed-off-by: anaxceron<EMAIL_ADDRESS>
Added sentence re: Status column
Removed text from Status columns
Fixed typos

@anaxceron
This PR looks good to me.  However, I detected a few 404s on links from the Roadmap article. Let's fix them with this PR.
Specifically:
https://docs.zowe.org/stable/user-guide/user-roadmap-zowe-cli#fundamentals - the first two bullets
https://docs.zowe.org/stable/user-guide/user-roadmap-zowe-cli#quick-start - first bullet
I checked the other links on this page and did not find any other 404s.  Perhaps we need just another set of eyes to check.

Fixed broken links; Added Excel spreadsheet


[Feature Request] Add homebrew formula

Is your feature request related to a problem? Please describe.
Add homebrew formula so it's easier to install
Describe the solution you'd like
brew install screentogif

Describe alternatives you've considered
Manual download
Additional context
N/A

Is brew supported on Windows?


Support Amqp Sequence, Data, and Value for message body

Currently, we only support the Amqp Body.

PR is out, just need approval from @KrzysztofCwalina
https://github.com/Azure/azure-sdk-for-net/pull/12572

Closing this and opening https://github.com/Azure/azure-sdk-for-net/issues/13022


Uncaught Error: [remote-sync] invalid transport: undefined in /Users/jesus/path/to/project/.remote-sync.json

[Enter steps to reproduce below:]

...
...

Atom Version: 1.0.0
System: Mac OS X 10.10.4
Thrown From: remote-sync package, v3.1.2
Stack Trace
Uncaught Error: [remote-sync] invalid transport: undefined in /Users/jesus/path/to/project/.remote-sync.json
At /Users/jesus/.atom/packages/remote-sync/lib/RemoteSync.coffee:104

Error: [remote-sync] invalid transport: undefined in /Users/jesus/path/to/project/.remote-sync.json
  at RemoteSync.createTransport (/Users/jesus/.atom/packages/remote-sync/lib/RemoteSync.coffee:104:17)
  at RemoteSync.getTransport (/Users/jesus/.atom/packages/remote-sync/lib/RemoteSync.coffee:110:19)
  at RemoteSync.uploadFile (/Users/jesus/.atom/packages/remote-sync/lib/RemoteSync.coffee:70:37)
  at handleEvent (/Users/jesus/.atom/packages/remote-sync/index.coffee:38:14)
  at atom-workspace.disposables.add.atom.commands.add.remote-sync:upload-file (/Users/jesus/.atom/packages/remote-sync/index.coffee:76:40)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61)
  at CommandRegistry.module.exports.CommandRegistry.dispatch (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/command-registry.js:156:19)
  at [object Object].jQuery.fn.trigger (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/space-pen-extensions.js:64:23)
  at EventEmitter.<anonymous> (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:75:67)
  at emitTwo (events.js:87:13)
  at EventEmitter.emit (events.js:169:7)
  at EventEmitter.ipc.sendSync (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/ipc.js:21:31)
  at BrowserWindow.RemoteMemberFunction [as emit] (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/atom.asar/renderer/api/lib/remote.js:110:29)
  at ContextMenuManager.module.exports.ContextMenuManager.showForEvent (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/context-menu-manager.js:170:31)
  at HTMLDocument.<anonymous> (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:150:33)
  at HTMLDocument.handler (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/src/space-pen-extensions.js:112:34)
  at HTMLDocument.jQuery.event.dispatch (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/space-pen/vendor/jquery.js:4681:9)
  at HTMLDocument.elemData.handle (/opt/homebrew-cask/Caskroom/atom/latest/Atom.app/Contents/Resources/app.asar/node_modules/space-pen/vendor/jquery.js:4359:46)

Commands
     -0:55.4.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -0:55.1.0 editor:select-to-end-of-line (atom-text-editor.editor.is-focused)
     -0:52.2.0 core:paste (atom-text-editor.editor.is-focused)
     -0:51.9.0 core:save (atom-text-editor.editor.is-focused)
     -0:50.6.0 core:close (atom-text-editor.editor.is-focused)
     -0:15.1.0 core:save (atom-text-editor.editor.is-focused)
  7x -0:08.9.0 core:move-up (atom-text-editor.editor.is-focused)
     -0:07.6.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:07.4.0 core:select-down (atom-text-editor.editor.is-focused)
     -0:07.1.0 editor:select-to-end-of-line (atom-text-editor.editor.is-focused)
     -0:05.7.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:05.5.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -0:05.2.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:05.0 core:save (atom-text-editor.editor.is-focused)
     -0:04.3.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:04.3.0 core:cancel (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store",
      ".idea",
      ".sublime",
      ".sass-cache",
      "node_modules"
    ],
    "disabledPackages": [
      "background-tips",
      "welcome",
      "whitespace",
      "toggle-quotes",
      "package-generator",
      "open-on-github",
      "open-in-browser",
      "link",
      "image-view",
      "dev-live-reload",
      "deprecation-cop"
    ]
  }
}

Installed Packages
# User
go-plus, v3.3.12
remote-sync, v3.1.2

# Dev
No dev packages

I had a similar error after editing the .remote-sync.json file manually.  The error went away when I used the Remote Sync -> Configure option by right clicking the project.

The transport  in .remote-sync.json can only be scp or ftp.

Why closes @yongkangchen ?
@jesusgalvan show the code in your .remote-sync.json file, please!


eslint 0.10.18 installed but not present eslint.run

I have installed eslint 0.10.18 but the setting eslint.run is not present.
running on (linux ubuntu 16.04)
thanks!

@brunocasado this will come with the next ESLint update planed for the next days.


Change RankedTensorType to ShapedType in verifyKernelShape().

This updates PR #908 a bit. Just change a line from RankedTensorType to ShapedType in verifyKernelShape().
This verification failed when filterOperand was memref type.
Signed-off-by: Haruki Imai<EMAIL_ADDRESS>

Jenkins Linux s390x Build #2316 [push] Change RankedTensorType ... passed after 1 hr 8 min

Jenkins Linux ppc64le Build #1426 [push] Change RankedTensorType ... passed after 1 hr 29 min


chore: Update K8s Version for E2E

Description
Changes proposed in this pull request:

Update K8S version in E2E tests to 1.28.7

Related issue(s)

/tests


uses BufferWriter to compose format string

Draft PR

What do we want to do about the error case?
We can simply truncate the format string. This will not produce a visible error, but may result in odd-looking logs some relevant output followed by a split format string %.

Going to PR this to apache.


[HOTFIX][ZEPPELIN-2013] Exceeded size of logs makes CI failed

What is this PR for?
avoiding failure of CI due to exceeded limit of log size. https://s3.amazonaws.com/archive.travis-ci.org/jobs/195087823/log.txt
What type of PR is it?
[Bug Fix]
Todos

[x] - Changed level of logs

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2013

How should this be tested?
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

LGTM

Will merge it onto master and branch-0.7


MenuBar sample should show what was invoked

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

[ ] New sample
[x] Addition to existing sample
[ ] Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
MenuBar
Describe the sample

Some of the samples, like MenuFlyout and AppBarButton, show you when you invoke a button. For example in CommandBarFlyout when you invoke Resize the sample updates to say "You clicked: Resize".
It would help for the MenuBar sample to do this too, especially the sample with keyboard accelerators, so ex you could see that Control+S does something.
Is your sample request related to a problem? Please describe it

Additional context

I'm handling this

That fixes it for you, would you like to test and see if that's what you want?

https://github.com/microsoft/Xaml-Controls-Gallery/pull/305 and https://github.com/microsoft/Xaml-Controls-Gallery/pull/306 done to address the issue above.


🐛 Fix smart selection of propery signatures having JSDoc comments

Fixes #39618

Thank you! The result looks right and the code change is very simple so I’m happy to merge this. However, if you’re up for it, I would encourage you to see if there’s a more general solution in light of #49807. JSDoc can be attached to the beginning of nodes of all kinds and it seems like there may be a systemic failure to consider that in the smart select logic.

I've updated the fix. This now covers both cases mentioned in #49807.
@andrewbranch Could you please review this again?


[Bug]: TimeoutError no matter how much I increase the time!

Minimal, reproducible example
import puppeteer from "puppeteer";

export const httpCreatePDF = async(req: Request, res:Response)=>{

    const url = req.body.url;
    const prevPublicURL = req.body.prevPublicURL;
    const tripId = req.body.tripId;
    res.sendStatus(200);

  try {

    const browser = await puppeteer.launch({ headless: true,
    executablePath: 'google-chrome-stable',
    args: ['--no-sandbox', ],
    });

    const page = await browser.newPage();
    page.setDefaultNavigationTimeout(70000)

    await page.goto(url,  {waitUntil: 'networkidle0', timeout: 60000});

    const pdf = await page.pdf({ format: 'A4', });

    await browser.close();

    //delete prev pdf if it exist in cloudinary

    if(prevPublicURL){
        await deleteAllFiles({filesToDelete: [prevPublicURL]});
    };

    //upload the file to cloudinary
    const uploadResponse =  await cloudinaryBufferUpload(pdf) as any;

    const response = {
        pdfImageURL: uploadResponse?.secure_url,
        pdfPublicURL: uploadResponse?.public_id,
        tripId: tripId
    }

    const webHookReq = await axios.post(sanitizedConfig.WEBHOOK_URL_PDF, response);

        if(webHookReq?.status === 200){

            return
        }

        return console.log(response)
  } catch (error) {

    console.log(error)
  }
}

Error string
TimeoutError: Navigation timeout of 70000 ms exceeded
Bug behavior

[ ] Flaky
[X] PDF

Background
I just want to use puppeteer to generate pdf from a dynamic page. This page was built with Next.js and the content was fetched using getServerSideProps method from Nextjs. The nextjs page is hosted on varcel. Everything for now is on free acount as we are still test developing! The puppeteer server is on back4app while our main API is on render.
No matter how I increase the time, I will still get the error. I have also tried timeout: 0, didn't work.
We separated the puppeteer server code from our main API. Our main API makes a request to the it and gets result via webhook when puppeteer completes the task or fails.
The entire process works well locally on my Windows 11 machine. However, when deployed via docker, I gets this issue.
when puppeteer is on my local machine, I also tried passing the targeted url directly from varcel and it was successfully converted to pdf.
Also, I can convert the homepage, contact page, etc to pdf when puppeteer is deployed via docker but the page we really need converted to pdf always fail with timeout error. I really don't know how to resolve this!
Here is my docker file:
`FROM node:slim
WORKDIR /app
copy configs to /app folder
COPY package*.json ./
COPY tsconfig.json ./
copy source code to /app/src folder
COPY src /app/src
RUN npm install axios bcrypt cloudinary cookie-parser cors dotenv express jsonwebtoken mongoose puppeteer
RUN npm install typescript --save-dev
RUN npm run build
FROM node:slim
RUN apt-get update && apt-get install -y gnupg
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true
RUN apt-get update
&& apt-get install -y wget gnupg
&& wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -
&& sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
&& apt-get update
&& apt-get install -y google-chrome-stable fonts-ipafont-gothic fonts-wqy-zenhei fonts-thai-tlwg fonts-kacst fonts-freefont-ttf libxss1
--no-install-recommends
&& rm -rf /var/lib/apt/lists/*
WORKDIR /app
COPY package*.json ./
RUN npm install axios bcrypt cloudinary cookie-parser cors dotenv express jsonwebtoken mongoose puppeteer
COPY --from=0 /app/build ./build
RUN npm uninstall typescript
USER node
CMD [ "npm", "start"]
EXPOSE 6000
`
If I use  await page.goto(url,  {waitUntil: 'networkidle0', timeout: 60000});, the network error disappears, pdf gets created but with an error from varcel stating that 'This Serverless Function has timed out.'
Here is the url we are targeting. It is dyanmic. This is just one of it:
https://bookingapp-mocha.vercel.app/builder/live/64e3aaba042c8f73316d13f1-Experience-the-Cairo-vibes
Expectation
To generate pdf from the url
Reality
Throws serveice time out error
Puppeteer configuration file (if used)
No response
Puppeteer version
21.4.1
Node version
16.18.1
Package manager
npm
Package manager version
9.6.4
Operating system
Windows

Could you try using the official docker image? https://github.com/puppeteer/puppeteer/pkgs/container/puppeteer What you describe sounds like the browser fails to start/run because the docker image does not have all dependencies (or misconfigured sandbox). You can use dumpio: true flag to see if the browser logs contain any errors.

@sparkmediatech you would need to evaluate security concerns on your own depending on your use case. Disabling the sandbox also has the security considerations + it is not how the browser regularly runs. Also see https://pptr.dev/troubleshooting#setting-up-chrome-linux-sandbox (we do not recommend running without a sandbox).

If I use the official image, will I still care about what was talked about in the link you provided? The url we generate the PDF are ours. We are only generating from our own URL and this URL is properly verified in our main API before we send to puppeteer API to generate a pdf of it. I really appreciate your time responding to my query. Thank you so much.

The issue is not reproducible. As a suggestion, use the full node image as the node slim image might be missing some dependencies.


Pipenv install not working

Clean pipenv install didn't work on MacOS. Here's the stack trace
$ pipenv install scitools-iris
Installing scitools-iris…
Error:  An error occurred while installing scitools-iris!
Error text: Collecting scitools-iris
  Using cached scitools_iris-2.4.0-py3-none-any.whl (2.3 MB)
Collecting dask[array]>=1.2.0
  Using cached dask-2.22.0-py3-none-any.whl (828 kB)
Collecting six
  Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Collecting cartopy
  Using cached Cartopy-0.18.0.tar.gz (14.4 MB)

    ERROR: Command errored out with exit status 1:
     command: /Users/niall/.local/share/virtualenvs/Projects-PTYlTbKT/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-install-zir3_v5j/cartopy/setup.py'"'"'; __file__='"'"'/private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-install-zir3_v5j/cartopy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-pip-egg-info-sp58ptt2
         cwd: /private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-install-zir3_v5j/cartopy/
    Complete output (12 lines):
    Traceback (most recent call last):
      File "/private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-install-zir3_v5j/cartopy/setup.py", line 43, in <module>
        import numpy as np
    ModuleNotFoundError: No module named 'numpy'

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/gn/lb9wdf291_d3nc2cq41mc1qw0000gp/T/pip-install-zir3_v5j/cartopy/setup.py", line 45, in <module>
        raise ImportError('NumPy 1.10+ is required to install cartopy.')
    ImportError: NumPy 1.10+ is required to install cartopy.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

This is likely caused by a bug in scitools-iris. Report this to its maintainers.
✘ Installation Failed

@niallrobinson Thanks for taking the time to report this. We clearly need to address some requirement issues for the PyPI package.
Ideally we'll need to address this as part of the iris 3.0 release, with in pending.

thanks Bill. For a bit of context about why not conda: I'm trying to deploy this on a serverless AWS deployment, and the deploy tools (Zappa) work with pipenvs

interestingly I just tried this inside an Amazon Linux Docker container and it has seemed to work. I think it's due to the lack of gcc on my mac perhaps?

@niallrobinson Okay, so I've dug a wee bit deeper on this, as I'm currently attempting to rationalise the PyPI and conda dependencies for iris in the pending v3.0.0 release...
So this issue that you're experiencing is relating to a change in cartopy from v0.17 to v0.18, where they decided to pull PEP518 support through the pyproject.toml file. For a history of this, see:

https://github.com/SciTools/cartopy/issues/1584
https://github.com/SciTools/cartopy/issues/1552
https://github.com/SciTools/cartopy/issues/1264

Ideally, it would be great if cartopy used PEP518 and PEP517, as it would resolve this (from my naive perspective).
Your temproary workaround for this, is to first pip install numpy into your environment, then pip install scitools-iris.
I suspect that will only be the beginning of you're woes if your taking the pip route, as you'll then need to get proj, geos, udunits2 et al in the environment to make it "all just work".
HTH

@niallrobinson I'm going to close the PR, as this is really a cartopy issue.


BugFix: Agent NetworkPolicyController handle ipBlocks in NP update.

Codecov Report

Merging #1625 (da969e2) into master (9d3d10b) will decrease coverage by 10.49%.
The diff coverage is 27.47%.

@@             Coverage Diff             @@
##           master    #1625       +/-   ##
===========================================
- Coverage   63.31%   52.82%   -10.50%
===========================================
  Files         170      181       +11
  Lines       14250    15347     +1097
===========================================
- Hits         9023     8107      -916
- Misses       4292     6324     +2032
+ Partials      935      916       -19

Flag
Coverage Δ

kind-e2e-tests
37.32% <19.18%> (-18.07%)
:arrow_down:

unit-tests
40.43% <19.52%> (-0.85%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

cmd/antrea-agent/options.go
21.69% <0.00%> (+0.97%)
:arrow_up:

.../agent/apiserver/handlers/networkpolicy/handler.go
58.33% <ø> (ø)

...gent/controller/noderoute/node_route_controller.go
46.06% <ø> (-0.41%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
28.37% <0.00%> (-0.79%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/proxy/types/groupcounter.go
0.00% <0.00%> (-95.00%)
:arrow_down:

pkg/agent/proxy/types/types.go
0.00% <0.00%> (-84.62%)
:arrow_down:

pkg/agent/stats/collector.go
92.04% <ø> (-5.69%)
:arrow_down:

pkg/antctl/antctl.go
100.00% <ø> (ø)

... and 109 more

Hi @suwang48404 Could you update the PR description on how to reproduce this bug?
I tested with the ToT build using the following spec:
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: egress-np
spec:
  podSelector:
    matchLabels:
      app: web
  policyTypes:
  - Egress
  egress:
  - to:
    - podSelector:
        matchLabels:
          app: client
    - ipBlock:
        cidr: "<IP_ADDRESS>/32"
    ports:
    - protocol: TCP
      port: https

where client Pod has an IP address of <IP_ADDRESS> and port https maps to 443.
I applied this spec, deleted the client Pod to force a rule update event, and the result of rule update looks correct to me.
Before client Pod deletion:
kubectl exec -it antrea-agent-zrvnl -n kube-system -c antrea-ovs -- ovs-ofctl dump-flows br-int table=50
 cookie=0x4000000000000, duration=1152.720s, table=50, n_packets=4530, n_bytes=1086677, priority=210,ct_state=-new+est,ip actions=resubmit(,61)
 cookie=0x4050000000000, duration=4.992s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_src=<IP_ADDRESS> actions=conjunction(1,1/3),conjunction(2,1/3)
 cookie=0x4050000000000, duration=4.992s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_src=<IP_ADDRESS> actions=conjunction(1,1/3),conjunction(2,1/3)
 cookie=0x4050000000000, duration=4.992s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_dst=<IP_ADDRESS> actions=conjunction(2,2/3)
 cookie=0x4050000000000, duration=4.983s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_dst=<IP_ADDRESS> actions=conjunction(1,2/3)
 cookie=0x4050000000000, duration=4.992s, table=50, n_packets=0, n_bytes=0, priority=200,tcp,tp_dst=443 actions=conjunction(2,3/3)
 cookie=0x4050000000000, duration=4.993s, table=50, n_packets=0, n_bytes=0, priority=190,conj_id=2,ip actions=load:0x2->NXM_NX_REG5[],ct(commit,table=61,zone=65520,exec(load:0x2->NXM_NX_CT_LABEL[32..63]))
 cookie=0x4050000000000, duration=4.985s, table=50, n_packets=0, n_bytes=0, priority=190,conj_id=1,ip actions=load:0x1->NXM_NX_REG5[],ct(commit,table=61,zone=65520,exec(load:0x1->NXM_NX_CT_LABEL[32..63]))
 cookie=0x4000000000000, duration=1152.731s, table=50, n_packets=231, n_bytes=17094, priority=0 actions=resubmit(,60)

Something I found alarming is that it seems the policy has been interpreted as 'allow egress traffic to client Pods on port https, and allow egress traffic to <IP_ADDRESS>/32 on any port', which I'm not sure if is correct/by design. cc @abhiraut @tnqn @wenyingd
That being said, after an event which triggers rule update (client Pod deleted), the flows get updated correctly:
kubectl exec -it antrea-agent-zrvnl -n kube-system -c antrea-ovs -- ovs-ofctl dump-flows br-int table=50
 cookie=0x4000000000000, duration=1516.208s, table=50, n_packets=5963, n_bytes=1430937, priority=210,ct_state=-new+est,ip actions=resubmit(,61)
 cookie=0x4050000000000, duration=368.480s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_src=<IP_ADDRESS> actions=conjunction(1,1/3)
 cookie=0x4050000000000, duration=368.480s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_src=<IP_ADDRESS> actions=conjunction(1,1/3)
 cookie=0x4050000000000, duration=368.471s, table=50, n_packets=0, n_bytes=0, priority=200,ip,nw_dst=<IP_ADDRESS> actions=conjunction(1,2/3)
 cookie=0x4050000000000, duration=368.473s, table=50, n_packets=0, n_bytes=0, priority=190,conj_id=1,ip actions=load:0x1->NXM_NX_REG5[],ct(commit,table=61,zone=65520,exec(load:0x1->NXM_NX_CT_LABEL[32..63]))
 cookie=0x4000000000000, duration=1516.219s, table=50, n_packets=303, n_bytes=22422, priority=0 actions=resubmit(,60)

and the isolation rules on table 60 also checked out. I also experimented with egress rule having regular port as opposed to named port, and rule updates also seem to work as expected.

@wenyingd @Dyanngg In my setup, the initial rule creation has failed, the egress update path take if !exists {}, is ur test cover that path too? It seems odd if it works, because as u see ipBlock is not added, how could it work?

@wenyingd @Dyanngg In my setup, the initial rule creation has failed, the egress update path take if !exists {}, is ur test cover that path too? It seems odd if it works, because as u see ipBlock is not added, how could it work?

See https://github.com/vmware-tanzu/antrea/pull/1625#discussion_r537925611. I think  the initial rule creation has failed is something we should look into instead.

@wenyingd @Dyanngg In my setup, the initial rule creation has failed, the egress update path take if !exists {}, is ur test cover that path too? It seems odd if it works, because as u see ipBlock is not added, how could it work?

See #1625 (comment). I think  the initial rule creation has failed is something we should look into instead.

I repurpose networkPolicyController package on another product, it is not on antrea per se. But regardless where the use case may be, it seems NetworkPolicyController logic today seems able to handle rule creation failures, I think the fix just make it more solid, no? Or maybe u have different perspective why this should not be in?

@wenyingd @Dyanngg In my setup, the initial rule creation has failed, the egress update path take if !exists {}, is ur test cover that path too? It seems odd if it works, because as u see ipBlock is not added, how could it work?

See #1625 (comment). I think  the initial rule creation has failed is something we should look into instead.

I repurpose networkPolicyController package on another product, it is not on antrea per se. But regardless where the use case may be, it seems NetworkPolicyController logic today seems able to handle rule creation failures, I think the fix just make it more solid, no? Or maybe u have different perspective why this fix should not be in?

I hear your point on this makes it more solid. On the other hand, given the premise that rule add is handled correctly (if an exception occurred in Antrea, reconcile should have been retried), processing ipBlock in update function might be redundant and lead to performance cost. I'll let @tnqn and @wenyingd comment here since I did not implement this function in the first hand.

@wenyingd @Dyanngg In my setup, the initial rule creation has failed, the egress update path take if !exists {}, is ur test cover that path too? It seems odd if it works, because as u see ipBlock is not added, how could it work?

See #1625 (comment). I think  the initial rule creation has failed is something we should look into instead.

I repurpose networkPolicyController package on another product, it is not on antrea per se. But regardless where the use case may be, it seems NetworkPolicyController logic today seems able to handle rule creation failures, I think the fix just make it more solid, no? Or maybe u have different perspective why this fix should not be in?

I hear your point on this makes it more solid. On the other hand, given the premise that rule add is handled correctly (if an exception occurred in Antrea, reconcile should have been retried), processing ipBlock in update function might be redundant and lead to performance cost. I'll let @tnqn and @wenyingd comment here since I did not implement this function in the first hand.

To summarize,  if addRule fails for any reason (maybe ovs is not ready, maybe something else), the retry logic will call updateRule, and if the rule is egress and consists of ipBlocks, the dst ipBlock will be ignored, That is the bug this PR is trying to address and it is applicable for use cases.

@jianjuns @abhiraut @tnqn can u help review this.
To summarize, if addRule fails for any reason (maybe ovs is not ready, maybe something else), the retry logic will call updateRule, and if the rule is egress and consists of ipBlocks, the dst ipBlock will be ignored, That is the bug this PR is trying to address and it is applicable to antrea agent in CNI deployment or other use cases.

@jianjuns @abhiraut @tnqn can u help review this.
To summarize, if addRule fails for any reason (maybe ovs is not ready, maybe something else), the retry logic will call updateRule, and if the rule is egress and consists of ipBlocks, the dst ipBlock will be ignored, That is the bug this PR is trying to address and it is applicable to antrea agent in CNI deployment or other use cases.

I don't think the retry logic will call update for the rule. If you look at L402
// Record ofID only if its Openflow is installed successfully.
lastRealized.ofIDs[svcKey] = ofRule.FlowID

When installation fails, lastRealized should not contain ruleID, and next time rule is synced, !exist will evaluate to true.

@jianjuns @abhiraut @tnqn can u help review this.
To summarize, if addRule fails for any reason (maybe ovs is not ready, maybe something else), the retry logic will call updateRule, and if the rule is egress and consists of ipBlocks, the dst ipBlock will be ignored, That is the bug this PR is trying to address and it is applicable to antrea agent in CNI deployment or other use cases.

I don't think the retry logic will call update for the rule. If you look at L402
// Record ofID only if its Openflow is installed successfully.
lastRealized.ofIDs[svcKey] = ofRule.FlowID

When installation fails, lastRealized should not contain ruleID, and next time rule is synced, !exist will evaluate to true.

I may not have been clear regarding to ofFlow rule and policy rule.
Let us walk through the steps:

an new egress policy rule with dst IP block was added via add()(L391)
the policy rule is added to cache via computeOFRulesForAdd(L413)
in case that ovs is not ready, add() returns error in L400 without adding ofFlow rule to cache.
in next reconcile cycle, update() (L256) is called  because policy rule has been added in step 2 above, and therefore exists.
a new ofLow rule is created in update() (L604) because *ofFlow rule" is not installed therefore not in cache, and dst IP Block will be ignored. Hence the bug.

Hope this helps, and let me know if I missed anything.
Thx, Su

I may not have been clear regarding to ofFlow rule and policy rule.
Let us walk through the steps:

an new egress policy rule with dst IP block was added via add()(L391)
the policy rule is added to cache via computeOFRulesForAdd(L413)
in case that ovs is not ready, add() returns error in L400 without adding ofFlow rule to cache.
in next reconcile cycle, update() (L256) is called  because policy rule has been added in step 2 above, and therefore exists.
a new ofLow rule is created in update() (L604) because *ofFlow rule" is not installed therefore not in cache, and dst IP Block will be ignored. Hence the bug.

Hope this helps, and let me know if I missed anything.
Thx, Su

Thanks Su for walking through this. So yes this is an issue which is hard to write a testcase for. I'm okay with this change except that I believe to fix it more properly, we need to address the TODO in L411.
// TODO: Handle the case that the following processing fails or partially succeeds.
r.lastRealizeds.Store(rule.ID, lastRealized)

That involves removing rule.ID from lastRealized if flow installation failed at any point. @tnqn

I may not have been clear regarding to ofFlow rule and policy rule.
Let us walk through the steps:

an new egress policy rule with dst IP block was added via add()(L391)
the policy rule is added to cache via computeOFRulesForAdd(L413)
in case that ovs is not ready, add() returns error in L400 without adding ofFlow rule to cache.
in next reconcile cycle, update() (L256) is called  because policy rule has been added in step 2 above, and therefore exists.
a new ofLow rule is created in update() (L604) because *ofFlow rule" is not installed therefore not in cache, and dst IP Block will be ignored. Hence the bug.

Hope this helps, and let me know if I missed anything.
Thx, Su

Thanks Su for walking through this. So yes this is an issue which is hard to write a testcase for. I'm okay with this change except that I believe to fix it more properly, we need to address the TODO in L411.
// TODO: Handle the case that the following processing fails or partially succeeds.
r.lastRealizeds.Store(rule.ID, lastRealized)

That involves removing rule.ID from lastRealized if flow installation failed at any point. @tnqn

I will let u guys decide what to do with 411. I simply fix a bug that for as long as  a rule flow are created in update, the rule flow should include ipBlock, it seems just a obvious omission, seems irrespective of L411.

I may not have been clear regarding to ofFlow rule and policy rule.
Let us walk through the steps:

an new egress policy rule with dst IP block was added via add()(L391)
the policy rule is added to cache via computeOFRulesForAdd(L413)
in case that ovs is not ready, add() returns error in L400 without adding ofFlow rule to cache.
in next reconcile cycle, update() (L256) is called  because policy rule has been added in step 2 above, and therefore exists.
a new ofLow rule is created in update() (L604) because *ofFlow rule" is not installed therefore not in cache, and dst IP Block will be ignored. Hence the bug.

Hope this helps, and let me know if I missed anything.
Thx, Su

Thanks Su for walking through this. So yes this is an issue which is hard to write a testcase for. I'm okay with this change except that I believe to fix it more properly, we need to address the TODO in L411.
// TODO: Handle the case that the following processing fails or partially succeeds.
r.lastRealizeds.Store(rule.ID, lastRealized)

That involves removing rule.ID from lastRealized if flow installation failed at any point. @tnqn

I will let u guys decide what to do with 411. I simply fix a bug that for as long as a rule flow are created in update, the rule flow should include ipBlock, it seems just a obvious omission, seems irrespective of L411.

BTW, I appreciate a detail review process and Q &A, which help produce good quality code. But let us try not to send people to some fishing expedition, that is just going to waste a lot time that we don't have.

BTW, I appreciate a detail review process and Q &A, which help produce good quality code. But let us try not to send people to some fishing expedition, that is just going to waste a lot time that we don't have.

Apologies, that's not our intention here, but quality and robustness is our priority, especially when it comes to a feature like NetworkPolicy. And it's important that the folks who maintain this code such as @Dyanngg have a good understanding of the changes.
Thanks for sharing the detailed sequence. Isn't is pretty straightforward to test this case, by returning an error in ofClient.InstallPolicyRuleFlows, given that this interface is mocked? It seems that a transient failure when adding OVS flows is something we should indeed accommodate for.

I'm good with merging this and I will update the logic for lastRealized as well as adding testcase for this particular scenario

@Dyanngg @antoninbas thx for helping out on testing and further improvements.

I'm good with merging this and I will update the logic for lastRealized as well as adding testcase for this particular scenario

@Dyanngg @antoninbas thx for helping out on testing and further improvements.

@Dyanngg is ur proposed change addresses issue fixed by this PR? I am assuming ur change would remove the need for update() to create new ofFlow rules?  If yes and u plan to work on it promptly, maybe we don't need this PR merged, and instead waiting for ur change along with companion test(s)? Let me know.

@antoninbas @Dyanngg @tnqn
as the fix presented in PR is incomplete.
@tnqn has gracefully agree to help with the issue #1635.
closing this PR, and thank all for helping out.


Lint Previous X Commits

Description
Right now lint-staged is setup in our project, but I am considering taking it out.  Here's why.
Today, a developer got in touch with me because he was working on a emergency production issue where husky/lint-staged/eslint ran and inadvertently introduced a bunch of unwanted changes.

Ok, so we got past that fine, but that was cumbersome.  Another gripe about some of the refactoring tools is that they make it hard to review the functional changes.
What I propose is a lint-last-x-commits.

Developer writes their code.
Developer commits their code.
Husky/lint-staged runs post-commit and lints all files changed in the previous 1 commit
Husky/lint-staged commits all refactoring under a new commit.

I understand --no-verify is a thing, but this is error prone, and once the linter runs, its done. The advantage of something like this is: a developer could defer all of the refactoring until they are ready to open a pull request, and get all of that refactoring in one commit, maximizing the readability of the PR.
New Features, or New Program

By default always lint last commit, and automatically commit it.
Implied is the ability of drop any refactoring commits
Also could include a flag to not refactor the last commit.
Developer can also manually run a command to refactor an arbitrary number of previous commits.

One complexity I can think of is: What happens when a file is partially staged for commit?
I may coach the developer's on --no-verify, but I have found once developers know about that, they ALWAYS USE IT, and don't fix their errors. Sigh.

This sounds to me like a different project, rather than changing how lint-staged works. If you want I can create something like this?
Can I ask what kind of eslint rules you are running that are causing unwanted changes? Maybe it would be worthwhile to add eslint integration into the developers' editors, so that the editor displays warning/error messages in real time, instead of only when committing.
For example, in our project we've integrated eslint-plugin-react-hooks which will error when hooks are using wrong dependencies. It would be dangerous for eslint to auto-fix these during the pre-commit hook, so rather we've configured lint-staged to not auto-fix anything but simply exit with error. This forces the editor to manually check the errors, and hopefully improve their code.

So while this feature set lends itself to a different name.  The intention is very much the same.  I couldn't find another project that lines up better, so I left my comment here.
I am OK with either option.  Also if you want to take the lead of spear heading this project that would be amazing.  I am sure many people are also looking for something like this.
Really our auto formatting is pretty simple, pretty sure it is just white space, and standardizing on quotes, but when you are rushing out a fix, those quotes and white space changes really mess up the code review process.
It's this exact problem of not being able to opt out of unwanted changes that is preventing me from turning on more aggressive auto formatting.

Something like this would probably work:
lint-commits:
#!/usr/bin/env node

# Reset 10 commits to get changed files
git reset --soft HEAD~10

# Get a list of changed files
CHANGED_FILES=$(git diff --diff-filter=ACM --staged --name-only)
# File list needs to have newlines replaced with spaces
CHANGED_FILES_CONCATENATED=$(echo $CHANGED_FILES | tr '\n' ' ')

# Run linter
eslint --fix $CHANGED_FILES_CONCATENATED

# Save diff
git stash save -m "lint-latest-commits autogenerated"
DIFF=$(git stash show -p)

# Reset back to HEAD
git reset --hard HEAD

# Apply diff with changes, rejecting conflicts
# Without running the linter, there won't be any changes, because the diff is only the changes of the 10 latest commits
# Thus, any "actual" diff will be from linter
git apply --whitespace=nowarn --reject --recount --unidiff-zero - $DIFF

# Remove stash
git stash drop


Fix default value explanation for SPLUNK_PROFILER_LOGS_ENDPOINT

OTLP_EXPORTER_OTLP_ENDPOINT doesn't exist

Merging, as it is typo-fix.


[$500] mWeb - Share code - Email with exact length overlaps with suspensory points

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.15-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Pre-requisite: it depends on the device screen size, in the case of the iPhone 13, the account email must be as long as the length of<EMAIL_ADDRESS>
Log in with account that meets the requirements.
Go to Settings > Share code.

Expected Result:
Suspensory points should be fully visible without any issues.
Actual Result:
The email and the suspensory points are overlapping.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f7812b4ecdd3f3b0
Upwork Job ID:<PHONE_NUMBER>319798784
Last Price Increase: 2023-12-21

Proposal
Please re-state the problem that we are trying to solve in this issue
The email and the suspensory points are overlapping.
What is the root cause of that problem?
This happens because numberOfLines={2} is limited to 2.
What changes do you think we should make in order to solve the problem?
Increase the numberOfLines={2} to 3.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Share code - Email with exact length overlaps with suspensory points
What is the root cause of that problem?
Here we have set limit to 2 lines for truncate https://github.com/Expensify/App/blob/9d71a22d4a71005ebc42882e9603cb2e1a03793d/src/components/QRShare/index.js#L57
What changes do you think we should make in order to solve the problem?
We can remove this limit and add a new CSS property here
https://github.com/Expensify/App/blob/9d71a22d4a71005ebc42882e9603cb2e1a03793d/src/styles/index.ts#L3615-L3618
maxWidth: '100%'

What alternative solutions did you explore? (Optional)
NA

@sonialiap
I'm unassigning this one due to low bandwidth please assign a new C+ here, thanks!

@sonialiap I am interested in reviewing this

Issue not reproducible during KI retests. (First week)

Reproducible on Safari

@situchan adding you as the C+ reviewer 🙌

@ZhenjaHorbach have you found any issue posted in upstream?

Still looking for proposals

Looking for proposals

Same

Moving back to external. Shawn confirms we should fix this but it's not high priority and I think can be fixed externally

Looking for proposals

Same

Not overdue

Same

Issue not reproducible during KI retests. (First week)

Not reproducible on safari any more 🎉

@sonialiap issue is in mobile safari, not desktop safari

Will re-test

But fyi, my previous screenshot was from desktop safari

Not reproducible on mobile Safari or on web safari anymore


reddit tracking

On reddit there is an unblocked pixel using Fanboy Ultimate. Would it have any function by itself?
reddit.com/static/pixel.png
blocking it seems to have no ill effect.
Additionally, there is an exception to:
www.google-analytics.com/analytics.js$script
Block as well?

Tested blocking the pixel, reddit remains functional.
Don't know why there is an exception for www.google-analytics.com/analytics.js$script, I block all GA and reddit remains functional.


Update my sections' exercises

Going to update the data model and VTK sections and then will merge

Thanks!


Last row from table displays partial information in page and remaining in next page

Last row from table displays partial information in 1 page and other row details in next page.
Opening the website on different screen resolutions also matters. (Below screenshots are from 16 inch screen)
Here is the github repo link which demonstrates table row issue.  (checkout the readme file)
Repo Link
Prepared some sample code in the above repo.  Below are the direct links for js, css files.
Basic CSS for table styling
CSS
Header, Footer required to reproduce the issue
App.js
Table Display
Table
Image 1

Image 2

Image 3

@PejmanNik  this is the only issue which is blocking the report since the output looks doesn't look good.
Lmk if you need any other details.

Any update on this ticket...

@PejmanNik  Sample code setup is done in codesandbox...
Check the end of each page where partial information is displayed and remaining in next page.
Please check the below link.
https://codesandbox.io/s/report-web-app-mm4l5l?file=/src/views/table/index.js

Thank you, Yes I can reproduce the issue, it is in my plan to fix but I can't provide any ETA right now


Add undo and redo command tests

Codecov Report

Merging #329 (6ab2534) into master (07b9c9b) will increase coverage by 9.19%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master     #329      +/-   ##
============================================
+ Coverage     24.04%   33.24%   +9.19%
- Complexity      236      330      +94
============================================
  Files           114      114
  Lines          2233     2229       -4
  Branches        207      203       -4
============================================
+ Hits            537      741     +204
+ Misses         1636     1395     -241
- Partials         60       93      +33

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/seedu/address/model/ModelManager.java
26.57% <0.00%> (+17.43%)
18.00 <0.00> (+12.00)

...rc/main/java/seedu/address/model/history/Node.java
81.81% <0.00%> (+69.05%)
18.00 <0.00> (+16.00)

...java/seedu/address/logic/commands/RedoCommand.java
100.00% <100.00%> (+100.00%)
3.00 <0.00> (+3.00)

...java/seedu/address/logic/commands/UndoCommand.java
100.00% <100.00%> (+100.00%)
3.00 <0.00> (+3.00)

src/main/java/seedu/address/model/Nusave.java
35.63% <0.00%> (+10.34%)
15.00% <0.00%> (+4.00%)

...ain/java/seedu/address/model/expenditure/Date.java
55.55% <0.00%> (+11.11%)
4.00% <0.00%> (+2.00%)

...ain/java/seedu/address/model/budget/Threshold.java
52.94% <0.00%> (+11.76%)
5.00% <0.00%> (+2.00%)

...in/java/seedu/address/model/expenditure/Price.java
57.14% <0.00%> (+14.28%)
4.00% <0.00%> (+2.00%)

...in/java/seedu/address/model/budget/BudgetList.java
47.61% <0.00%> (+14.28%)
13.00% <0.00%> (+3.00%)

...ain/java/seedu/address/model/expenditure/Name.java
66.66% <0.00%> (+16.66%)
4.00% <0.00%> (+2.00%)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07b9c9b...6ab2534. Read the comment docs.


Update Post “dva-c01-studying-ec2”

Automatically generated by Netlify CMS

👷 Deploy Preview for dazzling-dieffenbachia-448a02 processing.

Name
Link

🔨 Latest commit
61662649c54604dadbf9b99e658ff6f299cb5405

🔍 Latest deploy log
https://app.netlify.com/sites/dazzling-dieffenbachia-448a02/deploys/62c5d6577bb69c000808f6f0


Window created animation; enhancing rules; scratchpad

Good day to you!
Please, share your thoughts about:

created|closed window animation (slide top|bottom|left|right, fade in|out, zoom in|out)
so for example if i have window aligned to left side, i would give slide right on creation, and slide left on closing, or maybe quake terminal effect (slide bottom|top)

conditional, event, regex rules:
ability to create conditional rules on event:
events: created , closed, fullscreen, etc.
conditions: like, if , and, or, then, else
regex: ability to use regex in app_iid (class)

scratchpad:
i saw something in sway. ability to toggle window/process (chat,terminal, etc.) on any workspace

not atm but planned for the future, ja

rules on event - maybe

regex for class already supported, use the C++ regex style

planned for the future

not atm but planned for the future, ja

rules on event - maybe

regex for class already supported, use the C++ regex style
conditional - what? if what? if name? there's already a class field

planned for the future

number 1 added in 694f4433a2b6083cef5a4f43e974f9c70b9857af
that's my implementation of it, and it's probably here to stay.
I might add more styles in the future.

good.
i've read the wiki and tried an example for windows

but i can't configure animation for sliding, iit still uses default zooming from center
maybe i missing something?

animation=windows,1,10,default,slide

the wiki entry is a bit misleading yea, the 4th param is the CURVE, and the 5th is STYLE

got it worked.
is there any plans for applying animation with rules?
windowrules=animation slide <top/right/bottom/left>, util

maybe. unsure yet.

added window animation rules in d7ad80e6a2ee25bdc524c0012937d73725f5ad2f
see the wiki for more info.
example:
windowrule=animation slide right,kitty

tried window animation rules.
it is good

close for extracting scratchpad as separate issue
#114


Ssal grant application

Project Abstract
Ssal introduces a blockchain-based commodities exchange platform, designed to operate within the Polkadot ecosystem using smart contracts. Ssal aims to enhance transparency and trust in commodity trading while reducing entry barriers for producers and consumers in emerging markets. It leverages blockchain technology to provide real-time price transparency, decentralized price discovery, improved risk management, enhanced liquidity, and quality assurance through partnerships with local businesses. The project's primary objective is to bring equitable and efficient financial services to underserved economies, particularly in West Africa.
The development roadmap can be broken into three main sections each requiring one month of work: development, testing, and implementation. Through the first two months our team will be working out of San Diego to develop and test our application, while the last month will be spent implementing, refining, and documenting our process. Future plans involve enhancing infrastructure for continuous integration, adding customizable Automated Market Makers (AMMs), and implementing a governance system for dispute resolution. The project aligns with the Web3 Foundation's interest in funding projects that expand the use case for ink Smart Contracts and aims to benefit both its user base and the broader ecosystem by open-sourcing its code and fostering decentralized commerce development. The team has diverse expertise in blockchain, fintech, mathematics, and computer science, and we have previously worked together on projects for social good through our non-profit organization, COMPASS.
Overall, Ssal represents a promising initiative to transform commodity trading by harnessing the capabilities of blockchain technology and reducing market inefficiencies while addressing the unique needs of emerging markets.
Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[x] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @matteo-p:matrix.org (change the homeserver if you use a different one)

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Please submit the following text as a separate comment:
I have read and hereby sign the Contributor License Agreement.
You can retrigger this bot by commenting recheck in this Pull Request

I have read and hereby sign the Contributor License Agreement.

recheck

I have read and hereby sign the Contributor License Agreement.

Recheck

recheck

Thanks for the adjustments @MatteoPerona I will mark as ready for review and ping the rest of the committee.


osVersion is null?

Using ripple on a Mac I have this error (gif)

Hi @CKGrafico,
Thank you for opening this issue.
Can you please give me the output of the following code:
console.log(navigator.userAgent)

Please reopen this issue if you still get this error with the latest release 1.4.0.

I will check ASAP


I need a global and upgrade version please

this plugin is created accrording to my own project.So it is not applies to global.I`m so sorry.


Merge last commits from master into dev branch

@emagnier, @pejulian: I still think that this should be in the other way around: first commit to dev, then to test and finally to master branch.

@tukusejssirs what's wrong here? It's important to merge back new commits from master to dev (and test when it will exist), because master could still receive hotfix or minor changes (like here with theses 2 commits, and such as discussed here). I think still accept small PRs like you made on master, will also allow taking our time and test correctly new features from the dev branch, without preventing romcal from moving forward for very small things that have no impact on the romcal's behavior, and which could be fixed quickly. However, for next PRs opened against master, we could still object to reopen them to dev for those we are not confident with what has been modified.
@pejulian I already worked on projects where theses steps were automated (when there is no conflicts). Do you think this could be also automated here at some points?

@tukusejssirs what's wrong here?

Well, I’ve told you a few times my point of view on the merging back to dev. I think that @pejulian agrees with me (but I am not sure, therefore we should wait until he tells us his opinion) that we should not merge back to dev, but rather merge (tested) changes to master. Mind the order and release flow.
I’ve never said the release flow you are used to is wrong. All I do is that I am not really comfortable with it. Now that @pejulian is back I’d like to hear his opinion on this matter. If he, however, agrees with you, then I won’t talk about this matter anymore.

[…] because master could still receive hotfix or minor changes […]

Yes, I agree, but first I think the changes must be done in the dev (and probably test if needed) and only then dev should be merged into master (according to my suggested release flow).

When we will have the opportunity to extract the locales and calendars into a new romcal-database repository, I think it will clarify things. Because the romcal repo will only contain the core codebase, and these minor fixes will be managed separately from here.
In the meantime, if you prefer we could systematically open PRs on dev even for theses small localisation/calendar/typo fixes. But my concern here is why having to wait multiple weeks to get a translation fixed on the master channel?
In the incoming weeks, I plan to implement new features we discussed in the issue tracker, which will require for some of them a major code refactor and API changes. So I also want to take time in the dev/test channel to test them and package them well before doing a new release in the stable channel. But everything else also merged into dev will have to wait that theses major works get ready before be released to master. That reminds me the situation of the romcal-es6 branch where a lot of localisation and calendars stuff were fixed but we weren't able to release them because the build system and code refactor were not ready yet. As a contributor point of view and a user or romcal, I found that a little frustrating.
However, we could always have to make hotfixes on master, it's the life of all development projects. And for theses situation, merging back the commit to test and dev remain a recommended practice on all similar git workflow. It's important to keep the dev branch not too far from the master branch (I mean everything on master should also be on test and dev). But before doing hotfixes, we will have to distinguish what is really a hotfix/urgent and what could wait.
So as I've written at the beginning of my comment, the correct answer for everyone might come when the core of romcal and all localisation and calendar data will be isolated in different repositories.

@tukusejssirs what's wrong here? It's important to merge back new commits from master to dev (and test when it will exist), because master could still receive hotfix or minor changes (like here with theses 2 commits, and such as discussed here). I think still accept small PRs like you made on master, will also allow taking our time and test correctly new features from the dev branch, without preventing romcal from moving forward for very small things that have no impact on the romcal's behavior, and which could be fixed quickly. However, for next PRs opened against master, we could still object to reopen them to dev for those we are not confident with what has been modified.
@pejulian I already worked on projects where theses steps were automated (when there is no conflicts). Do you think this could be also automated here at some points?

Hello @emagnier, if I understand you correctly, perhaps a cron job could be defined in Travis to do nightly merges from one branch to another that aborts on conflict. I'll look into that and see what I can cook up 😄.

@pejulian yes this is exactly that. If there is a conflict we will do the merge manually.

@tukusejssirs what's wrong here?

Well, I’ve told you a few times my point of view on the merging back to dev. I think that @pejulian agrees with me (but I am not sure, therefore we should wait until he tells us his opinion) that we should not merge back to dev, but rather merge (tested) changes to master. Mind the order and release flow.
I’ve never said the release flow you are used to is wrong. All I do is that I am not really comfortable with it. Now that @pejulian is back I’d like to hear his opinion on this matter. If he, however, agrees with you, then I won’t talk about this matter anymore.

[…] because master could still receive hotfix or minor changes […]

Yes, I agree, but first I think the changes must be done in the dev (and probably test if needed) and only then dev should be merged into master (according to my suggested release flow).

Hello @tukusejssirs,
Many great points were raised in this discussion on branching strategy and there's many valid concerns across the table. Absolutely no one is wrong and no one's concerns are not important. I'll try to address these concerns in a way that hopefully everyone can be comfortable with moving forward (at least for now).
We must remind ourselves that we are a relatively new project and it is only in recent months that the pace is picking up in terms of contributions and collaborators. We are at a point where there are many moving parts in our "ecosystem" that need to be established before the product reaches its first stage of maturity.
In this respect, an agile mindset is what we need where the main goal should be to deliver value to our users.
What @tukusejssirs described definitely falls under the "classic" git flow approach. It is systematic and highly structured and should be considered a standard practice in any matured product offering. The trade offs however are that is it not easy to maintain and we will most likely find ourselves cracking our heads over the right way of merging this or that. Plus with so many branching rules. code conflict resolutions may take a lot of time to resolve. The approach works well for a matured product because changes are well organized and come in a organized manner but we are still some way from reaching that state at present.
As @emagnier has illustrated in his comments above, maintainability issues can cause frustrations to contributors especially during a deep development phase (that I see us currently being in). As such, to support our efforts to "deliver", I have to agree with @emagnier that we should always strive to keep test and dev as close to master as possible to reduce code deviation and merge conflicts (or as they call it in some places:- big bang releases). This should mean a greater speed of delivery, which I believe is our main priority at present.
As we now correctly practice, hot fix branches should be created to address critical issues in master as and when needed. These are then PR-ed back to master when ready. What we could do in the near future to address @tukusejssirs concerns is to try and merge that hot fix branch to dev (and test) as well especially if the changes are small. That way, we can avoid merging masterback todev` or other branches and strictly obey the rules of classic git flow.
As I see it, we are now in a somewhat hybrid git flow process where we are neither fully compliant to the classic git flow or fully agile (trunk based). To me, this arrangement is just right for our needs as we have some structure in our git flow and also the flexibility to speed things up when needed. I propose that we keep things this way for now to ensure that feature delivery is as smooth as possible.
If this is agreeable, perhaps @tukusejssirs could add a "Git Flow" item in the backlog so that we remember to revisit this process when we are ready.
Here's a diagram that can help visualize this hot fix PR process that we can use in the future (Ignore the parts that are not relevant to us):

The only reason that I wouldn't implement the hot fix PR process right now is because I would like to first set up a cron job to merge master back to dev to ensure hot fixes get back into our development stream ASAP.  Then when we are ready, we can disable this and look at a safer approach.
Do let me know your thoughts! 😄

@pejulian: I deeply agree with you! Thank you for taking the time to share your point of view, and thanks for your communication skills! On my side, writing in English is taking me a lot of time... Trying not to do too many mistakes and share my ideas is a difficult exercise for me in this language. I really prefer to write code 😄
I know this diagram well, and the article where it comes from. During multiple years I worked on large projects following this git workflow. It was a good experience (especially on large teams), and I'll definitely continue to recommend it!
As you described for romcal, things are a bit different. I started to contribute on it only 3 months ago, this project was sleeping since a long time, and the last version of the codebase required a bit of love to run correctly. At this stage, enforcing practices and procedures too strong and too quickly is just killing efficiency and the motivation (this is why I didn't even share about a hotfix branch, it's clearly too early). We have to go step by step. However since the release of the 1.3 we can see good evolution about continuous integration (a big thank you Julian!).
We have to keep in mind that this project remains a small and a niche project that also need to gain in maturity. So it's important to stay simple and flexible if we want to attract new contributors and don't discourage the existing one.

On a side note, we might also have to create PR on the test branch, if we find bugs on a new feature in the testing period (and because the dev branch will continue to live accepting new commits). In that case, new commits on test should be merged on dev as well.
@pejulian do you prefer we merge that PR, or we close it so you can experiment your cron job (if you plan to do it soon)?

On a side note, we might also have to create PR on the test branch, if we find bugs on a new feature in the testing period (and because the dev branch will continue to live accepting new commits). In that case, new commits on test should be merged on dev as well.
@pejulian do you prefer we merge that PR, or we close it so you can experiment your cron job (if you plan to do it soon)?

I am working on the cron. If all goes without issue, I can push it soon. The cron will run daily on the master branch and attempt to merge code to dev. I'll look into a workflow for test as well.
In regards to this PR, it all seems good to me. Perhaps, we can wait a bit to hear @tukusejssirs's comments on my views since he requested my views on this subject. 😄

@pejulian: I deeply agree with you! Thank you for taking the time to share your point of view, and thanks for your communication skills! On my side, writing in English is taking me a lot of time... Trying not to do too many mistakes and share my ideas is a difficult exercise for me in this language. I really prefer to write code 😄
I know this diagram well, and the article where it comes from. During multiple years I worked on large projects following this git workflow. It was a good experience (especially on large teams), and I'll definitely continue to recommend it!
As you described for romcal, things are a bit different. I started to contribute on it only 3 months ago, this project was sleeping since a long time, and the last version of the codebase required a bit of love to run correctly. At this stage, enforcing practices and procedures too strong and too quickly is just killing efficiency and the motivation (this is why I didn't even share about a hotfix branch, it's clearly too early). We have to go step by step. However since the release of the 1.3 we can see good evolution about continuous integration (a big thank you Julian!).
We have to keep in mind that this project remains a small and a niche project that also need to gain in maturity. So it's important to stay simple and flexible if we want to attract new contributors and don't discourage the existing one.

@emagnier, from my perspective, you and @tukusejssirs write English that is really well understood by me (and I am sure by anyone else reading these threads). No complaints from me whatsoever 😆.

It looks that I am too late, as you have discussed this matter in depth. :smiley:
Anyway, I am happy you two have agreed upon the Git flow (and its future progress).  Even my concerns have disappeared! :smiley:

[@pejulian] If this is agreeable, perhaps @tukusejssirs could add a "Git Flow" item in the backlog so that we remember to revisit this process when we are ready.

Indeed I can create one, but maybe you, @pejulian, can describe it better than me. FYI, @pejulian, the backlog is a milestone (although it won’t be closed ever) and all items there are GitHub issues. Currently, we don’t use GitHub projects (though you did in the past), because I don’t find them that useful in the meantime as the milestones are. Although, I don’t think that a Git flow should be decided in public, if we want to add it to backlog, it should be a GitHub issue. On the other hand, it might be a good think from the transparency point of view.

And back to the topic: I see no problem with this PR. So, if you two have agreed into which branch this PR should be merged, you can merge it.


Default slot returns single static node

Version
3.0.0-beta.14
Reproduction link
https://github.com/sneppy/vue-next-slot-issue.git
Steps to reproduce
npm i
npm run serve

Navigate to http://localhost:8080/ and open developer console. The console should display two lines: the first one is correct while the second one is not.
What is expected?
slots.default() returns a slot for each div. The console output is (3) [{…}, {…}, {…}] in both cases.
What is actually happening?
slots.default() returns a single slot with type: Symbol(Static) and a string with the three divs in the children field.

This is an optimize for many hosited nodes.You can use static vnode as same as normal vnode.

How? I need to access the top elements of the vnodes to register some DOM events; I also need to wrap each node in a custom component. In Vue 2.x I would do it like this:
let elements = this.$slots.default.map((slot) => slot.elm)

and:
let cards = this.$slots.default.map((slot) => h(Card, [slot]))

How am I suppose to do that? Do I have to parse the children string?
I also don't understand why in the first case, no optimization occurs, given that the only differences are three class="title" attributes. There's no optimization either if I use the runtime compiler:
const {createApp, version, defineComponent, onMounted} = require('vue/dist/vue.esm-bundler')

const View = defineComponent({
	setup(_, {slots}) {

		console.log(version) // 3.0.0-beta.14
		onMounted(() => console.log(slots.default()))
	},

	template: `<div><slot/></div>`
})

const App = defineComponent({
	components: {View},

	template: `

		<View>

Installation

Usage

Contributions

		</View>

`
})

createApp(App).mount('#app')

The optimization happend when node count and props count reach the dafalut threshold value.Thi is why first case is diffrent of the second. And The optimization is not support for runtime compiler on now.
For the case let cards = this.$slots.default.map((slot) => h(Card, [slot])), you still can do it with v2.
For the case let elements = this.$slots.default.map((slot) => slot.elm), maybe you can do it with use other method attach event,eg. ref, directive, binding.This is unreliable if you do it, even though it can work with v2 on this case, but sometimes some vnode.elm is null, it is also to v3.

you still can do it with v2

You mean, I can do it with Vue 2.x? Because, of course If i simply do this in Vue 3:
let cards = slots.default().map((slot) => h(Card, [slot]))

I end up with a single Card component which contains the three divs, which is not what I want.

maybe you can do it with use other method attach event,eg. ref, directive, binding

I don't think so. What I'm trying to do is upgrading a plugin I'm using in Vue 2.x so that I can use it in my Vue 3 project. The plugin simply registers a global component that can be easily wrapped around a bunch of elements to create slides. This is what I was doing in the render function:
render(h) {

	// Get children
	let cards = this.$slots.default.map((child) => h(Card, {}, [child]))

	// Create slider
	let style = `transform: translate(${this.transform.x}px, ${this.transform.y}px);`
	let slider = h('div', {class: 'swoosh-slider', style}, cards)

	let on = {
		'touchstart': this.onTouchStart,
		'touchmove': this.onTouchMove,
		'touchend': this.onTouchEnd
	}
	return h('div', {class: 'swoosh-view', on}, [slider])
}

At this point I'm not sure what to do, I probably have to think of some other way of doing this.

It looks like an unsuspected behaviour because this do hoist per div:

Title 1

Title 2

Title 3

but this, do hoist to the whole template

Title 1

Title 2

Title 3

There are some internal heuristics based on amount of nodes with bindings to determine whether a piece of content is static hoisted. However I think it's reasonable to bail on multi-element stringification directly inside a slot. i.e. root level nodes inside a slot should be preserved, but they themselves can stringify their inner content.


Always use update/updateValue with filter.

This examples suggets for new users to make update/updateValue without filtering first. If we have two object in database with primary key- we always receive error "Duplicate entry '...' for key 'PRIMARY'"
Fixes #issue_number
Problem
Explain here the context, and why you're making that change.
What is the problem you're trying to solve?
Solution
Describe the modifications you've done.
Notes
Additional notes.
Checklist

[ ] Unit test all changes
[x] Update README.md if applicable
[ ] Add [WIP] to the pull request title if it's work in progress
[ ] Squash commits that aren't meaningful changes
[ ] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@ajozwik Very good point. Any chance you could please squash these commits? I know it's been a while since you did this PR so I'm sorry about the delay in responding.

@deusaquilus I remove last two commits (not needed). Now it is only filter added to dynamic queries.


Linting and cleanup work

General Checkups

[*] Have you checked that there aren't other open pull requests for the same issue/update/change?
[ ] If your code includes new features and not just bug fixes/copy editing: Did you include new tests?

Description
Did much manual linting and cleanup.
Related Issue
n/a
Example
n/a
Signed-off-by: Mairi Dulaney<EMAIL_ADDRESS>

After further discussion, it seems that I had inadvertently installed an extra plugin to flake8.  Closing for now, as this was mostly a result of that extra plugin.


Lb backend rules not getting configured

Rancher 	v0.35.0-rc3
Cattle 	v0.85.0
User Interface 	v0.45.0
Rancher Compose 	beta/latest
Alena reproduced the issue and suing the setup to debug now.
With fresh 10 acre setup with rc3, no backend rules are getting configured.

This was because wrong cattle (rc2) was built with rc3. Bill is pushing new build now.


Exclude hidden menu items from focus group

Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?

Currently, if ActionMenu contains items that are hidden via hidden: true, these items will still be present in the list of focusable items. This causes the focus trap to be blocked, as it tries to focus onto a item that is currently hidden from view.
This PR adds onto the selector to ensure that the parent is not [hidden].
Screenshots

Before PR; video shows focus trapped being blocked in overflow menu within ActionBar
https://github.com/primer/view_components/assets/26746305/952afe2d-14ab-4738-a208-586af181cb88

Current PR; video shows focus trap looping properly in overflow menu
https://github.com/primer/view_components/assets/26746305/680eb269-7e2e-4ddc-9451-91ef55c7400e

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)
Risk Assessment

[ ] Low risk the change is small, highly observable, and easily rolled back.
[ ] Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
[ ] High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

Fixes axe scan violation - This change fixes an existing axe scan violation.
No new axe scan violation - This change does not introduce any new axe scan violations.
New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

[ ] Added/updated tests
[ ] Added/updated documentation
[ ] Added/updated previews (Lookbook)
[ ] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Would love your opinion here @camertron.
Focus trap currently breaks if there's an item in the group that's hidden. Since we use [hidden] to explicitly hide elements, I added it as something that isn't included within the list of valid focusable elements. This only effects controls that have their direct parent hidden (e.g.
<!-- The `menuitem` is not included in the focus group due to its direct parent being hidden via `[hidden]` -->
<div hidden>
  <button role="menuitem">Menu 1</button>
</div>

If this is a valid solution, then we might want to refine the selectors further to ensure no hidden/non-focusable element is included in the group.

What additional refinements were you considering?

I think there may be cases where we could also include the selector on the individual menu items themselves, but I'm not entirely sure if you can directly apply [hidden] to the menu item, rather than just the parent? We also might want to include aria-hidden, but I haven't seen a use case of this yet, so I think this is good for now!


Bug: When the user is not connected to the internet at startup, Editor does not load.

Category
Bug: Editor
What is the current behavior?
Many times, if the user is not connected to the internet when Gitbook editor is started:

The editor throws an error (Could not load the list of books: 443)
The large blue infinity circle loads.
The window's menu-items load.
The small blue infinity circle loads forever (Waited more than 15 minutes, still no change).
If (connect to the internet again while step 4) { Nothing changes. }

(See Additional information below for the instances in which the issue occurs.)
What is the desired behavior?

An information dialog should inform the user that zhe are not connected to the internet.
The editor should load the books that are saved locally on the user's device.

Additional information
- Operating System: Windows 10 Anniversary Update
- Editor Version: 7.0.8

- Instances:
    - When loading the editor the first time after restarting the computer.
    - After exiting the editor, disconnecting from the internet, and then reopening the editor.
    - In both instances above, sometimes the issue occurs 5+ times before working correctly.
    - This only happens when the computer is not connected to the internet at the time of editor start-up.

This also ties in with #404


fix: Saving values with special chars in env file

Also included some refactoring to fix several compile time warnings and lint errors, including proper formatting.
Fixes #13335.

/ok-to-test sha=da0eddc


Unable to create or update action

Git revision: git version 2.13.6 (Apple Git-96)
OS Version: MacOS - 10.12.6

Steps to Reproduce:

wsk action init

wsk action create

The same issue occurs when using wsk action update
Screencaps: (use recordit or something comparable)

Note that all the other commands are working fine. Also wsk properties have been set for api, namespace and auth.

Closing as project is being archived.


some mistakes

Executing..!
SYNC    include/config/auto.conf.cmd
UPD     include/config/kernel.release
GEN     debian
dpkg-buildpackage --build=binary --no-pre-clean --unsigned-changes -r'fakeroot -u' -a$(cat debian/arch)
dpkg-buildpackage: info: source package linux-upstream
dpkg-buildpackage: info: source version 6.5.8-1
dpkg-buildpackage: info: source distribution bookworm
dpkg-buildpackage: info: source changed by lindongbin<EMAIL_ADDRESS>dpkg-buildpackage: info: host architecture arm64
dpkg-source --before-build .
dpkg-checkbuilddeps: error: Unmet build dependencies: rsync
dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting
dpkg-buildpackage: warning: (Use -d flag to override.)
make[2]: *** [scripts/Makefile.package:139: bindeb-pkg] Error 3
make[1]: *** [/home/lindongbin/Downloads/kernel/Makefile:1659: bindeb-pkg] Error 2
make: *** [Makefile:234: __sub-make] Error 2
real    0m2.919s
user    0m2.034s
sys     0m0.855s

apt install rsync


Show test results on CI

Codecov Report
Patch and project coverage have no change.

Comparison is base (75fbf9f) 77.68% compared to head (e107e8c) 77.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   77.68%   77.68%
=======================================
  Files          12       12
  Lines        1035     1035
=======================================
  Hits          804      804
  Misses        171      171
  Partials       60       60

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update package.json of current plugins with additional metadata and set sane defaults for future plugisn

Goal
A new plugin is populated with a package.json that is missing some important metadata. Please make sure these values are populated for existing plugins and make sure the values are also pre-populated for new plugins.
Please read NPM documentation and suggest metadata that should be populated. Please invent a way how to populate these values for new plugins via native tools.
What problem does this solve? Please describe.
Less maintenance, more standardization etc.
Acceptance criteria

[ ] All current plugins have package.json updated
[ ] New future plugins will receive the same metadata

Additional context
Good first issue - learn about NPM, Yarn and backstage cli

missing metadata we need:

repository : github:janus-idp/backstage-plugins
keywords : look up other npm backstage plugins and follow their keywords
homepage : https://janus-idp.io/
bugs :  https://github.com/janus-idp/backstage-plugins/issues

missing metadata we might need

authors : see backstage authors
contributors : see backstage contributors

missing metadata we need and already know how to automatically add it to new plugins

private :  false --> setting flag with backstage-cli new script

@tumido what about the second part: new future plugins will receive the same metadata?
open a new issue or reopen this again and try to find a solution?


Fix bounds

This implements a bit more logic to avoid errors in some datasets that do not have lon/lat bounds.

Ill go ahead and merge this, but note that CESM-FV still fails on the local cloud test, due to nans in the lon/lat fields. I will address this with a separate PR


[BEAM-4846] Fixing updateOfflineRepository task.

Should still be run with --no-parallel
r: @lukecwik

Run Java PreCommit

Run Java PreCommit

Retest this please

Run Java PreCommit

I only had to run PreCommit 8 times : D

Sweet, didn't think the fix was going to be this easy. Any clue as to why it wasn't working?

No clue : ) - but this is good enough to run ./gradlew updateOfflineRepository --no-parallel and get all dependencies without issues.

Well, it looks like the spotless check for buildSrc passed so feel free to merge this as I only made comment changes.


Events->Streaming Events shows: Jan 1, 1970 1:00 am

Hi,
I got some Events that show epoch 0 times (Jan 1, 1970 1:00 am).
version: 4.3.0-0.okd-2019-11-26-150235
My OKD 4 runs on Proxmox and on vSphere.
Greetings,
Josef

@jomeier Awesome that you got it on Proxmox. Even I am looking for the same. The current okd read me says AWS supported. Any specific using 4.3.0-0.okd-2019-11-26-150235
for bare metal?

@barjahanshaik
It‘s important to understand that you can install OpenShift 4/OKD 4 everywhere if you create the ignition files with the installer and start the VMs manually with them.
The platform type in the install-config.yaml must be „none“ in this case.

"some events" meaning not all? Is there a pattern? Do you have an example of correct date events and the wrong ones?

@vrutkovs:
Some of the Jan 1, 1970 events show 404 errors if I click on them, some others show details page.
https://imgur.com/a/CJNt8l9
I can't find a pattern. But it seems as if new events are affected.

@vrutkovs:
In my Proxmox insallation with: 4.3.0-0.okd-2019-11-26-150235  I dont see this effect anymore.
On my vSphere Installation with 4.3.0-0.okd-2019-10-15-xxxxx I see it.
I don't understand, why my cluster with the older version (2019-10-15) doesn't update automatically at least to 2019-11-26 but maybe someone has removed that version from the update channel.
I will continue to observe if the newer version shows this wrong dates again.

There is no automatic upgrade (yet), so you have to click "Update cluster" yourself.
Please close this if its no longer reproducible in the latest version

In the last hours I saw this wrong timestamps again in version 4.3.0-0.okd-2019-11-26-150235.
I'm asking myself what you mean with "click Update cluster". Is this already possible with OKD 4? Were can I click for the update?
I was wondering for days why one of my clusters updated itself automatically to version 2019-11-26 and the other cluster stays at 2019-10-15. Even if I call this:
curl --silent --header 'Accept: application/json' 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=stable-4.3&arch=amd64'

or instead of stable-4.3 -> fast-4.3 I get back an empty graph JSON.
Where did my preview-1 cluster get its update to 2019-11-26 from :-) ?

@jomeier Can you please help me know how you created the rhcos vm in proxmox? Is it through cloud-init? I am trying to use it through cloud-init but no luck. Is this the process you approached to spin rhcos vms manually? Thanks in advance

@jomeier Can you please help me know how you created the rhcos vm in proxmox? Is it through cloud-init? I am trying to use it through cloud-init but no luck. Is this the process you approached to spin rhcos vms manually? Thanks in advance

https://github.com/openshift/okd/issues/27

@jomeier You are awesome. I will try it Thanks a lot.


Please add a license file

Pretty much like https://github.com/Igalia/WPEBackend-fdo/issues/2 .. please add a license file :)

https://github.com/Igalia/WPEBackend-fdo/commit/c2bdbea9eaec91e7b0dd83f9f1d9ce5b48f21f93


dashboard

Dashboard support limitations should be added somewhere and clarified.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36ecef62-68f2-9e81-f4b6-da2b49d1a653
Version Independent ID: a6c2c35a-8a12-a9de-0a4e-669cf8506892
Content: Support policies for Azure Kubernetes Service (AKS)
Content Source: articles/aks/support-policies.md
Service: container-service
GitHub Login: @jnoller
Microsoft Alias: jenoller

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

I don't understand this issue or what is being asked. This feedback is non-actionable without specific questions to address.

Please close as won't fix without additional details


Fixes currently failing ce custom runtime build

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

I found this error some time ago and added this fix : https://github.com/lithops-cloud/lithops/blob/master/lithops/config.py#L191-L192
so I wonder, In what circumstances do you still see the error?

I found this error some time ago and added this fix : https://github.com/lithops-cloud/lithops/blob/master/lithops/config.py#L191-L192
so I wonder, In what circumstances do you still see the error?

It fails exactly in that line. If backend not exist in the config, backend == None at that point.
And None not in {} produces True.
And then it crashes on KeyError in the or config_data[backend]

Already fixed in https://github.com/lithops-cloud/lithops/pull/777


Speed

Any chance to get the monitor a bit faster? Mobile notifications are about 2 seconds faster

I don't believe there is anything I can do about speed in the current build, because it's build using twit which does the job of streaming the timeline, whatever speed they are capable of us what I am able to use. Maybe I can rebuild or make a new version using requests which allows you to use proxies if requested.

Mobile notifications come about 2 seconds earlier then in discord, is there any chance to speed it up?
Thank you

No, sorry. It could be rebuilt by using requests and proxies allowing for a faster refresh rate making it result in faster responses. Some of the delays is simply Discord and we can't really do anything about that part of it. Definitely space for someone to rebuild and have speed increases.

Closing this issue, I don't plan on open-sourcing speed improvements. I will mentor anyone trying to do so by answer questions to my best ability. DM on Twitter for the fastest response. Thank you!


Produce ActivitySource events

.NET 5 introduced a new way to create distributed tracing activities - ActivitySource. We've been using an older system, DiagnosticSource, to expose distributing tracing data to ApplicationInsights. OpenTelemetry uses ActivitySource to collect its distributing tracing event.
This PR adds ActivitySource support to Azure SDKs. ActivitySource support means that we also support OpenTelemetry. We put ActivitySource support behind an experimental AppContext flag. Many specs that describe the kinds and shapes of OpenTelemetry telemetry spans are still experimental. We don't want customers taking an accidental dependency on names/attributes/parent-child relationships etc.
ActivitySource support is abstracted behind ClientDiagnostics/DiagnosticScope infrastructure the same way as DiagnosticSource was before. Clients authors don't have to make changes to the library code; the entire feature is handled in the shared code.
A bit more details in the upcoming blog post https://github.com/Azure/azure-sdk-blog/pull/168

left some comments, but looks good overall

Would you be willing to write a description for the PR so people with affected libraries can understand what the change is and why it's needed?

It's the least I can do while tagging the entire world on the PR.


Ensure code is documented to support Microsoft Docs documentation

Ensure Code decoration supports automatic documentation
In order to ensure that Microsoft Documentation is complete, the source code annotation for generated documentation must be adhered to at checkin time by policy.
We need to:

Scan repo for missing annotations and bring them up to documentation quality bar
Enforce annotation (e.g. function headers) during code reviews.

Example
See the following:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.bot.builder.activityhandler.onmembersaddedasync?view=botbuilder-dotnet-stable

As written, this isn't actionable. Closing as part of 4.5.


Suggestions and view progress buttons disappear on small screens

Hi there, awesome project!
I just played a bit around with it and found that when using smaller screens, the buttons for the suggestions and for the view progress will simply disappear so that you can't track your progress from a mobile phone for example. Maybe the buttons also just move to somewhere else, but I simply can't find them. Would appreciate an answer and if applicable a fix for this 😊. Thank you!
Large screens

Small screens

Hey, thanks a lot for the report! I will of course fix it as soon as possible :)


Implementing additional SHA256-based hasher

This is a very first PR from my side. It has following goals:

to get taste of actual communication/collaboration with the team;
get deeper understanding of the merkletree codebase including small details;
start unit-testing of SHA256 based Merkle Tree that is used in Filecoin 32Gb sectors (in production).

Here I added new hasher based on SHA-256 additionally to the existing XOR128. I re-used unit tests (by making them generic) specified mostly in test_xor128.rs source file which seems to be the main point of testing. For simplicity I used only trees with VecStore storage layer and extending tests to other storages is left for future work.

@vmx, thank you for reviewing!
Regarding conversation about rust-crypto dependency, I agree that by default we should not require any crypto-providers as library dependencies, because it is a task for high-level caller (like rust-fit-proofs) to implement particular hasher. At the same time, I think that this is also true for ring dependency. It seems that introducing features to this library is actually legacy from original repository and it has no relevance to how this library is utilised by Filecoin. I would propose introducing reorganisation from https://github.com/filecoin-project/merkletree/pull/97#discussion_r832086949 and removing legacy features unless you or other engineers are aware whether it is needed somewhere at higher level.