onAdClosed problem

Hi, when you close app before full screen ad loaded. And when i reopen app and fullscreen ad apperas. If i close ad its returning this error.
com.tns.NativeScriptException: Calling js method onAdClosed failed
TypeError: Cannot read property 'setAdListener' of null
File: "file:///data/data/com.ttt.mmm/files/app/tns_modules/nativescript-admob/admob.js, line: 162, column: 32
StackTrace:
Frame: function:'onAdClosed', file:'file:///data/data/com.ttt.mmm/files/app/tns_modules/nativescript-admob/admob.js', line: 162, column: 33
  at com.tns.Runtime.callJSMethodNative(Native Method:0)
  at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1021)
  at com.tns.Runtime.callJSMethodImpl(Runtime.java:903)
  at com.tns.Runtime.callJSMethod(Runtime.java:890)
  at com.tns.Runtime.callJSMethod(Runtime.java:874)
  at com.tns.Runtime.callJSMethod(Runtime.java:866)
  at com.tns.gen.com.google.android.gms.ads.AdListener_fes_app_tns_modules_nativescript-admob_admob_l153_c74__.onAdClosed(com.google.android.gms.ads.AdListener.java:0)

I am facing the same issue. Have you found any solution?

I was never able to reproduce this issue, but I've added a guard to prevent this from happening nonetheless. Available in 1.4.3.


Create Carthage school

I hope that this is added so my class mates can use the amazing tools.
School url: http://www.carthagetigers.org/

The address is @carthagetigermail.com

We require

an academic institution providing higher education in tertiary, quaternary or any other kind of post-secondary education in any country in the world.

This is a high school - it cannot be included in this repository at this time.


Added constant kernel

A constant kernel as referenced in https://github.com/GPflow/GPflow/issues/40.

Current coverage is 97.93%

Merging #45 into master will decrease coverage by -0.43% as of 0264693

@@            master     #45   diff @@
======================================
  Files           20      20
  Stmts         1104    1113     +9
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1086    1090     +4
  Partial          0       0
- Missed          18      23     +5

Review entire Coverage Diff as of 0264693

Powered by Codecov. Updated on successful CI builds.

Nice work @markvdw , but we already have this kernel!  I call it the Bias kernel, following Neil's naming convention.
If we want to cover both naming conventions (I'm happy to), then perhaps a cleaner solution is
class Constant(Bias):
    pass

This has the advantage that the naming of the constant in the model will be constant, i.e.
k = GPflow.kernels.Linear(1) + GPflow.kernels.Constant(1)
m = GPflow.gpr.GPR(X, Y, kern=k)
m.kern.constant.variance = 7.3  # for example

Hah! I completely missed that! I interpreted Alex's comment on a constant kernel being feasible as it not existing yet.
I would err on only keeping one naming convention and class for a particular functionality. It probably causes more confusion than it's worth to have two names for the same thing.

Right, but I kind of prefer Constant to Bias!
On 17 April 2016 at 19:15, Mark van der Wilk<EMAIL_ADDRESS>wrote:

Hah! I completely missed that! I interpreted Alex's comment on a constant
kernel being feasible as it not existing yet.
I would err on only keeping one naming convention and class for a
particular functionality. It probably causes more confusion than it's worth
to have two names for the same thing.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/GPflow/GPflow/pull/45#issuecomment-211074878

Me too, as it was the name I was trying to find in kernels.py. I would vote to change it to constant :) But I'd leave the decision up to you and Alex.

@alexggmatthews , do you have any preference for the naming of this kernel?

No.

So I fixed this by adding a Constant class, and was then confused because pushes to  my constant_kernel branch wouldn't show up here. Now that's I've pushed to constant-kernel, I think we're ready to merge.
@alexggmatthews , could you take a quick  look when you have time?

@jameshensman push issue not your fault I don't think. GitHub are "investigating reports of delayed notifications and delayed inbound commit processing."

Oh, It was my fault. note the hyphen/underscore discrepancy! :)


Working with pivot tables

This and the XLS libraries have been lifesavers!  I can only imagine the blood, sweat and tears that went into this.
I want to be able to see the pivot tables in a workbook. Is that possible?  I didn't see any options for it.

+1 For this feature, at least would there be a workarround to be able to work with a workbook without loosing the existing pivot Table ?

+1 this is the only feature stopping me from moving to JS

Is there any update on this? This would be great to have!

We offer this in the Pro compendium.  Since companies have paid for the features already, it would be unfair to them if we turned around and made it available as open source.  We have a longer comment in a gist.


Issue rendering report with edr command - dbt tree structure not showing

Describe the bug
When I generate dashboard with edr command I do not see the dbt tree structure anymore when I navigate in lineage tab.
To Reproduce
This problem appears randomly, I had the tree structure before
Expected behavior
I should be able to navigate in the DBT tree structure
Screenshots

Environment (please complete the following information):

edr Version: 0.13.2
dbt package Version: 0.13.1

Hi @mattxxi !
Thanks for opening this issue and sorry for the delayed response, we are currently in the process of reviewing our open issues and improving our process there.
Since the issue has been open for over 3 months I'm going go ahead to close it - please feel free to re-open if still relevant.
Thanks!
Itamar


Adding HoloLens demo fit and cleaning guide

Creates new documentation for fit and cleaning guide.
Adds new document to TOC.

Note: A full build takes more time than an incremental build.  This is the expected behavior of the build system.

OPS Build status updates of commit 90c677a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

  This is the expected behavior of the build system.

OPS Build status updates of commit 7f6af5d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.
Line 26: [Warning] Invalid file link:(~/images/FitGuideStep5.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 4114ebe:
:clock10: Preparing: average preparing time is 49 sec(s)

OPS Build status updates of commit 4114ebe:
:clock10: Incremental building: average incremental building time is 27 sec(s)

OPS Build status updates of commit 4114ebe:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.
Line 26: [Warning] Invalid file link:(~/images/FitGuideStep5.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 5879f9d:
:clock10: Preparing: average preparing time is 49 sec(s)

OPS Build status updates of commit 5879f9d:
:clock10: Incremental building: average incremental building time is 27 sec(s)

OPS Build status updates of commit 5879f9d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.
Line 26: [Warning] Invalid file link:(~/images/FitGuideStep5.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit c7f8a54:
:clock10: Preparing: average preparing time is 49 sec(s)

OPS Build status updates of commit c7f8a54:
:clock10: Incremental building: average incremental building time is 27 sec(s)

OPS Build status updates of commit c7f8a54:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit b182ba6:
:clock10: Preparing: average preparing time is 49 sec(s)

OPS Build status updates of commit b182ba6:
:clock10: Incremental building: average incremental building time is 27 sec(s)

OPS Build status updates of commit b182ba6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/holoLens-demo-guide.md
:warning:Warning
View
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md

[Warning] Author Jesse McCulloch cannot be recognized in GitHub.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 6080c1a:
:clock10: Preparing: average preparing time is 50 sec(s)

OPS Build status updates of commit 6080c1a:
:clock10: Incremental building: average incremental building time is 27 sec(s)

OPS Build status updates of commit 6080c1a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

  This is the expected behavior of the build system.

OPS Build status updates of commit c4786be:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/holoLens-demo-guide.md
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideSetep5.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep1.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep2.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep3.png
:white_check_mark:Succeeded
View

mixed-reality-docs/images/FitGuideStep4.png
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Version reconcile only fails if there is no version info in the status

Description
We don't want to block a reconciliation if we fail to refresh the version information for a given component.
So we only fail the version reconcile for a component if there is nothing to fall back to; otherwise, we log the error (for specific components that even have a condition VerificationFailed) and move on.
How can this be tested?
The unit test is pretty straightforward, otherwise, you can:
Deploy a Dyankube that will do some "version-reconciling","" check that I didn't break the default behavior.
Then, somehow try to break the few requests we do for version reconciling. (one way would be to lower the latest oneagent in the tenant, so the downgrade check will fail)
And notice that everything is fine because we just fallback to the previous version.
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.11%. Comparing base (266040b) to head (c9f3ded).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2917   +/-   ##
=======================================
  Coverage   67.11%   67.11%
=======================================
  Files         260      260
  Lines       14139    14142    +3
=======================================
+ Hits         9489     9492    +3
  Misses       3837     3837
  Partials      813      813

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update to bevy 0.11

Thanks for the lovely PR @Luminoth!
Just one small request, could you split it in two commits with the following messages:
feat: bump bevy to v0.11

and
v0.3.0

Second commit should only include version bump in Cargo.toml (see https://github.com/umut-sahin/bevy-persistent/commit/a8b086f4589e55e3a68492edd8fceff256aa1237) and the first commit should contain everything else.
This is to have a consistent commit style (see https://github.com/umut-sahin/bevy-persistent/commits/main).
Once the PR is updated, I'll enable the CI, and then merge once the CI is green!

Or maybe let's not bump to v0.3.0, I have a few things that I want to change. I'll apply those changes as well, bump to v0.3.0, and then do the release.

Yep, can do! Should be good to go without the crate version bump now.

Could you please run:
git reset --soft HEAD~2
git commit -m "feat: bump bevy to v0.11"
git push -f

in your branch please?
Then I'll run the CI and merge :+1:

Yep, should be good to go.

Some WebAssembly tests are failing, could you update those as well?
(could you commit using git commit --amend --no-edit and then git push -f :relaxed:)

Just realized, README needs updating as well :sweat_smile:
If it's too much, I can create a branch and apply the changes. Of course I'll set you as the commit author, and add you to Cargo.toml :wink:

Just making sure I'm on the same page - for both the wasm tests and the README, it's just the LControl KeyCode update?

It seems to be the case, yes!

For some reason CI isn't running :thinking:
Also, there are conflicts with the new main after some changes I've made today :sleepy:
Honestly, let me know if you want me to do the update and commit for you :stuck_out_tongue:

I'm good with whichever 😁 since we're hitting conflicts now it may be easier for you to patch it?

I've created https://github.com/umut-sahin/bevy-persistent/pull/18 :partying_face:
Let's continue from there!


print to html，then print to pdf，code shows different in Chrome and Edge

There is a paragraph of code like this：

hello

% Acc,NMI,RI,Precision,Recall,Error_rate,specificity,F_value,Jaccard,E_value
function [Accuracy,NMI_value,A_correct,P_correct,R_correct,Error_rate,Spe_value,F_value,J_value,E_value,array_,correct,ncorrect]=self_Evaluation(Idx,label) %返回正确率以及正确个数

    [Label_H, Label_L]=size(label);
    if(Label_H==1)
        label=label';
        [Label_H,Label_L]=size(label);
    end

After print to html
print in Chrome

print in Edge

question

why the <pre class="hljs">  in  Chrome can not change line automatically？
waht's more, the line below the # maybe too black, I think grey is better.

ps
Thank you for the support of math.  :) 👍

Edge also doesn't wrap line on my laptop

You can add your own rule white-space: pre-wrap to change the default behavior

Again, you can apply border-color: gray to h1 tags (overriding the vscode default styles)

In summary, you need a CSS file containing
pre {
    white-space: pre-wrap;
}

h1 {
    border-color: gray;
}

and then apply it using vscode setting markdown.styles

It works, thanks!


Removing old (v0.9.0) documentation from search indexing

📚 Documentation
When I search for multi-gpu training pytorch lightning in google, the first result turns out to be documentation for v0.9.0 which is different from the latest documentation. It will be nice if the older versions are removed from search indexing as it will prevent confusion (In my case, v0.9.0 had different arguments for multi-gpu training compared to the latest, causing confusion). I presume there must be something like noindex which when setup, prevents the page from getting indexed.
cc @borda

@adamjkuhn ^^ pls :)

Hi, is there a specific file I need to go through to replace the tags?


9800x3D is not recognized

Can  you provide a photo what is showing in your display ?

Can you please tell me what information is showing in your nzxt devices panel ?
like mine:

I have just googled and sounds like your processor is having some trouble with nzxt:
https://www.reddit.com/r/NZXT/comments/1gral2l/9800x3d_not_recognized_by_cam/
maybe a future update gonna fix it.


Feature .net 5

Description

Moves Lean to net5 target
Removes mono
Removes FXCM due to incompatibility with IKVM
Adjust and fix regression algorithms

Option assignment order is now deterministic
Rolling Averaged Population statistics is calculated using doubles believe it's the cause for the same differences

Update readme, removing references to mono adding references to CLI (vs skylight)
Add missing Py.Gil lock
Update QuantConnect.IBAutomater.dll

Related Issue

Closes https://github.com/QuantConnect/Lean/issues/447
Closes https://github.com/QuantConnect/Lean/issues/452
Closes https://github.com/QuantConnect/Lean/issues/3783
Closes https://github.com/QuantConnect/Lean/issues/5010
Closes https://github.com/QuantConnect/Lean/issues/5288
Closes https://github.com/QuantConnect/Lean/issues/5468
Motivation and Context

Makes Lean faster, more stable and cross platform removes the need for using Mono
Requires Documentation Change

Yes
How Has This Been Tested?

Unit and regression tests. Cloud testing, backtesting, research, live deployments
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which improves implementation)
[x] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

This is super awesome and works like a charm!
I needed to do some minor modifications to get rid of the warnings in Rider:
diff --git a/Algorithm.Framework/QuantConnect.Algorithm.Framework.csproj b/Algorithm.Framework/QuantConnect.Algorithm.Framework.csproj
index 956b156b6..8df19fba8 100644
--- a/Algorithm.Framework/QuantConnect.Algorithm.Framework.csproj
+++ b/Algorithm.Framework/QuantConnect.Algorithm.Framework.csproj
@@ -10,7 +10,7 @@
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <DocumentationFile>bin\$(Configuration)\QuantConnect.Algorithm.Framework.xml</DocumentationFile>
     <PackageTags>Library</PackageTags>
-    <LangVersion>6</LangVersion>
+    <LangVersion>9</LangVersion>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
     <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects>
diff --git a/Common/QuantConnect.csproj b/Common/QuantConnect.csproj
index 790b43cac..80befa3d5 100644
--- a/Common/QuantConnect.csproj
+++ b/Common/QuantConnect.csproj
@@ -7,7 +7,7 @@
     <AssemblyName>QuantConnect.Common</AssemblyName>
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
     <RestorePackages>true</RestorePackages>
-    <LangVersion>6</LangVersion>
+    <LangVersion>9</LangVersion>
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <OutputPath>bin\$(Configuration)\</OutputPath>
diff --git a/ToolBox/QuantConnect.ToolBox.csproj b/ToolBox/QuantConnect.ToolBox.csproj
index e8badc201..ab8dd9293 100644
--- a/ToolBox/QuantConnect.ToolBox.csproj
+++ b/ToolBox/QuantConnect.ToolBox.csproj
@@ -6,7 +6,7 @@
     <RootNamespace>QuantConnect.ToolBox</RootNamespace>
     <AssemblyName>QuantConnect.ToolBox</AssemblyName>
     <TargetFramework>net5.0</TargetFramework>
-    <LangVersion>6</LangVersion>
+    <LangVersion>9</LangVersion>
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <OutputPath>bin\$(Configuration)\</OutputPath>


Windows Update installing version 1.0.26 fails with 0x80070643 / Manual install ask for disc

Environment
Windows build number: 10.0.22000.160
Your Distribution version: Ubuntu 20.04
Your WSLg version: 1.0.24

Steps to reproduce
Use Windows Update to install the latest WSLg Update.
or
Use wsl --update to install the latest WSLg Update.
or
Download the released msi file and use that to install the latest update.
WSL logs:
wsl-logs.zip
Expected behavior
The update should install without an error code and without asking for any additional input.
Actual behavior
The installation of the update 1.0.26 is failing since it's release. Windows Update made multiple attempts.
If I try to install it manually using wsl --update it will ask me for an installation source (literally it is asking for a disc) but will not accept the msi of version 1.0.26. Without the source it will fail.

The same problem bothers me too. It asks for a disc when I want to update or uninstall WSL and WSLg.
OS Version: 22000.194

Thank you, @usamoi! I used the program you linked to and it suggested an uninstall of WSLg. I followed the suggestion and it solved the problem: after the uninstall I could run wsl --update without any problems and now WSLg is up to date.
Maybe a normal uninstall would have helped as well - I do not remember if I tried that before reporting here. Anyways, the problem is gone and I will go ahead and close the issue.


Advanced debugging interference of VaultInventorServer and Inventor App

Advanced debugging (Visual Studio) of iLogic Jobs impacts Inventor logging while having Inventor.exe and VaultInventorServer on a single machine.

fixed in update 2<IP_ADDRESS>

fixed in update 2<IP_ADDRESS>


IPFS links is being banned by Twitter

Thanks to Chris Burniske for discovering this issue.
I made a test here and here's a message I got

@kasstawi can you confirm quickly that this is resolved? Didn't know if that was why you closed this issue.

Yes. It was resolved https://twitter.com/ammori/status/1003330613175255042?s=21

On Jun 4, 2018, at 12:09 AM, Kyle Drake<EMAIL_ADDRESS>wrote:
@kasstawi can you confirm quickly that this is resolved? Didn't know if that was why you closed this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Fix markup link to cucumber-html-reporter

Thanks!

Thank you for maintaining a sweet project!
On Wed, Nov 8, 2017 at 4:45 PM, Dirk Rombauts<EMAIL_ADDRESS>wrote:

Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/picklesdoc/docs/pull/19#issuecomment-342970838, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAIJq5ctDtUc_1vdodw8Col5hip5o6eks5s0iEPgaJpZM4QXApM
.

--
/ Dave


[Improvement]: Report connectivity to Ballerina Central

Description
When running a bal program in a docker container, I was getting module not found errors but only for specific versions of libs. This was due to the way ballerina fetches dependencies when the versions are out of the preset range.
Instead of sending a compile time error it would be good to know that the bal command is unable to reach bal central and will cause issues. ,
Describe your problem(s)
running ballerina project in an air-gapped environment gave unclear errors.
Describe your solution(s)
Add feedback to the user when ballerina can't call out to bal central.
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

@azinneera Please have a look on this.


db_test: fix 'recieve' typo

Tiny typo fix :book: :mag:

Coverage remained the same at 92.244% when pulling d18cd653749ed5b19377733d21e1aeba053b5b42 on cpu:cpu-typo-fix into 7b2203ccca5109361bcc9717e62c54bb88fb660b on joohoi:master.

Thanks! recieve is my oldest and most persistent nemesis in written English ;)


Available for Apex 4.2.x

Hi,
Is it possible to use the plugin wiht Apex 4.2.x as well?
Thanks

Hi @hairpin666
unfortunately this is not possible, a plugin that is developed with APEX 5 is not backward compatible to a 4.2.x release. Therefore I have to create the whole plugin for this release completely again...
I don´t even have a 4.2.x instance which I can use...
Sorry for that, best is to upgrade your instances!;)

Hi @hairpin666 ,
I created a version for APEX 4.2, you can find it here:
https://github.com/Dani3lSun/apex-plugin-dropzone/releases/tag/v1.9.2
Note: Thus APEX 4.2 doesn´t support folders in the plugin files section you have to upload the (js/css/img) folder to your webserver! A note.txt is included...

Thanks, I gonna test it and give feedback!

Hi,
did some quick testing, everything works except if I want to upload files which are bigger than 1MB, even thou the limit is set high enough. Is that a bug or do I have to consider sth. else?
Thanks

Hi @hairpin666
I tested it just now on my APEX 4.2 instance with theme 25/26 and everything works as expected...
The max filesize parameter works for every value I put into this (tested from 1 to 5 MB) and all files get uploaded except the ones that are bigger than the max. allowed size...Tested with ORDS 2.0.10 and Webtier OHS 11g as webserver...Are all plugin files right in place? Any messages in console log? For better debugging you can set the logging param of the plugin to true, after that you see all values logged to console...

Hi,
There are no error messages in the console everything looks fine. I even added some console.log calls in the apexdropzone.js to see whats going on. The ajax success function is called after the upload but the file never arrives in the collection or in the custom insert statement.
We are using Tomcat 7 with ORDS 3.0 on it.
What else could the problem be?
Thanks

Hi,
your first problem was that files bigger than 1MB don´t get uploaded, so the upload was working earlier, except these files? Have you changed anything in the plugin plsql code section? The default code inserts into a collection, if something is missing there, it won´t function well...
If you make changes (console.log entries) in the apexdropzone.js file, it only works if you set your APEX app into debug mode, only then this file is taken, in normal mode the minified version (apexdropzone.min.js) is used...
Can you please test it with a fresh workspace or fresh blank app and of course a not modified plugin file?
Very difficult for me to figure out what the problem could be, on all my instances it works well...Are you using a standard theme or some custom one?

Can you please import this sample app and check if it works?
It only has 1 page with the dropzone plugin. The only thing you have to do is to adjust the PLUGIN_PREFIX path in the dropzone plugin settings under shared components --> plugins
f100_dropzone_test_apex42.sql.zip

Anything new on this topic? Does it work? If so I will close the issue...

Hi,
Sorry for the late reply.
I tested it again also with your plain application. Same problem here.
Seems like all files smaller than 5MB get uploaded everything bigger does not get through.
Could it be any preferences within the workspace / tomcaat / listener?

Hi @hairpin666
no problem. Just now I could reproduce your issue, because I updated last week to ORDS3+Tomcat.
Large files work with my old settings (ORDS2 standalone + Apache) and OHS11g. But I solved the issue with setting maxPostSize in server.xml of tomcat server (default max size is 2MB)
My tomcat connector looks like this for a maximum of 15MB:
<Connector port="8009" protocol="AJP/1.3" redirectPort="8443" address="<IP_ADDRESS>" maxPostSize="15728640" />

Just add the maxPostSize parameter with a byte value to it and it should work! I will add this hint to the readme file...

Great! Works perfectly fine now.
Great plugin!!!

This is great! Have fun!;)


Unable to exclude files from my coverage report

I am just trying to get the basic exclude functionality working on my project but so far I cannot.
I am using Cypress to run e2e test on my react.js application. My coverage report seems to be working fine other than it not ignoring the files in my exclude array.
I have tried adding this to my package.json file:
"nyc": {
        "exclude": [
            "AddressFormatter.js"
        ]
    }

I have tried including the full path name src/components/AddressFormatter as well as **/AddressFormatter.js.
I have also tried using a .nycrc.json with the following content:
{
    "reporter": ["lcov", "text-summary"],
    "sourceMap": true,
    "instrument": true,
    "temp-dir": "app/test/.nyc_output",
    "report-dir": "app/test/coverage",
    "all": true,
    "exclude": ["**/AddressFormatter.js"],
    "check-coverage": true
}

The steps I took to find this problem. From the terminal I ran
yarn add -D @cypress/code-coverage
Then I ran
yarn add -D nyc
Next I ran
nyc instrument ./src ./coverage
Lastly I updated the package.json start script with
"start": "react-scripts -r @cypress/instrument-cra start"
After this I tried all of the methods above to get my coverage report to ignore different files.
So far I have had no success ignoring this file.  Any suggestions would be appreciated.

having the same issue.

I had similar issues.
See official documentation:
| nyc will instrument all files if the --all flag is set or if running nyc instrument. In this case all files will appear in the coverage report and contribute to coverage statistics.
Try to remove "all": true, from your .nycrc.json and run without instrument parameter
For me, it helped to explicit add the include/exclude (in addition to the config file) to command like:
nyc --include=lib/* --exclude=**/to_exclude_folder/**


v1.7.1 changelog and removing unused fixtures

Release changes for v1.7.1
Also updated the release guide and removed unused fixtures,

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.91%. Comparing base (bb1739a) to head (91dab8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   62.19%   61.91%   -0.29%
==========================================
  Files         144      144
  Lines       11817    11817
==========================================
- Hits         7350     7316      -34
- Misses       3998     4028      +30
- Partials      469      473       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Optional node ordering in each layer

This commit attempts to solve the issue #12 to set the ordering of selected nodes.

Codecov Report

Merging #17 (2f2ed0a) into main (946c304) will decrease coverage by 0.46%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   92.72%   92.26%   -0.47%
==========================================
  Files           4        4
  Lines         165      168       +3
==========================================
+ Hits          153      155       +2
- Misses         12       13       +1

Impacted Files
Coverage Δ

src/zarate.jl
89.56% <83.33%> (-0.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946c304...2f2ed0a. Read the comment docs.

Sorry I have been super busy, but I am on leave this week so I will look at your PRs.

Hi, just checking back on this.
We still need tests right?

I close this pull request to change the branch


I have question about hstego-master

Is it work in vscode?

I’m not sure; I haven’t tested it in VSCode.


Feature/gearbest sensor

Description:
The gearbest sensor will track price of a product from Gearbest. This information can be used in e.g. automations to notify you when a price drops. The update interval for every item is currently set to 2 hours.
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.github.io#3973
Example entry for configuration.yaml:
Example configuration.yaml entry
sensor:

platform: gearbest
currency: EUR
items:

url: https://www.gearbest.com/3d-printers-3d-printer-kits/pp_779174.html?wid=21
name: Creality CR-10 upgraded
currency: USD
id: 779174
name: Creality CR-10 upgraded #2
currency: EUR

Checklist:
If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[X] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[X] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[X] New dependencies are only imported inside functions that use them ([example][ex-import]).
[X] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[X] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Don't we have the scrape sensor for this?

@covrig I haven't tried it, but can we achieve similar results using the scrape sensor? The Gearbest component parses everything and even returns the entity_picture.

@arsaboo I wonder, why don't we work on developing the scrape sensor even further instead of developing a new sensor? I think excluding the entity_picture everything else could be obtained with the scrape sensor.
Why stop at Gearbest? There are so many websites that could be integrated in here.


Add Prerequisites to the README

It would be great if we had the Prerequisites under or before the Install  section.
https://github.com/make-software/ces-js-parser#install

@Vladimir-Kuchinskiy Any ideas about the prerequiites? Compatible node version(s)? Anything else?


zoxide: 0.5.0 -> 0.6.0; fix darwin build

Motivation for this change
version update and broken darwin build
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@cole-h thank you for taking the time to review.
I initially used nixpkgs-update to try to make an automatic update, that is why the hash were formatted in that way.
I'll try to remember to format them differently next time.
I think this is ready to merge. Let me know if anything else.

@cole-h thanks for the explanation!
squashed the commits.

## [0.6.0] - 2021-04-09

### Added

- Support for [Nushell](https://www.nushell.sh/).
- Support for [Elvish](https://elv.sh/).

### Changed

- `z` now excludes the current directory from search results.

### Fixed

- Removed backtraces on Rust nightly.
- Generated shell code avoids using aliased builtins.
- Handle broken pipe errors gracefully when writing to streams.
- NUL file appearing in working directory on Windows.
- Accidental redefinition of hooks when initialized twice on some shells.
- zoxide unable to find itself on Xonsh shells.

### Removed

- Aliases: `za`, `zq`, `zqi`, `zr`, `zri`. These are trivial aliases to zoxide that can easily be defined manually, and aren't very useful to most users.

Out of curiosity, do you know why libiconv is necessary on macOS?

I don't know why it's required, when I compiled, it complained about not having libiconv.
I'll try to build the PR you are referencing.


Improve the error message when valid policy paths are given but no policies are found

The current error message when we specify a valid policy paths that doesn't has any policies in inside is:
Error: no policies found in [/home/runner/_work/ruby-reposaur/ruby-reposaur/policy]

This error can be further improved by providing the user with suggestions such as "make sure your policy files have the the .rego extension". Maybe other suggestions would be also good like if we find .go files suggesting if it shouldn't be .rego.
Looking for feedback on this one.

I'd suggest creating an error with a specific suggestion list besides the error message. You could even pass the file list to the error so you could properly check and suggest accordingly.
As valid suggestions I pretty much agree with what you propose, I'd say you could build a bigger error message such as the one that follows
Error: no policies found in [/home/runner/_work/yadayada/policy]
Possible causes:
- Make sure your policy files have the .rego extension
- The files present have a .go extension
- There is no file present in the given path

The only downfall I see is the logs becoming a bit verbose
type PolicyFileError struct {
    Path string
    FoundFiles []string
}

func (e *PolicyFileError) Error() string {
  //actual code to build the error based on the path and the files
}

Good idea! 💡
I'd just do some adjustments to the causes copy:
- The files present don't have a `.rego` extension
^ - combines the first two sentences into one
- No files found in the given path
^ - just shorter version of the sentence

Alternatively we could present the causes conditionally based on the actual files we've found instead of just throwing all possible causes to the user.
I think it's better for the error to be named PolicyLoaderError since it is related with the loading process and not with a particular policy file.
Would you like to pick this one? 💪🏼

@crqra yes, I'll assign it to myself. Sounds like a good first issue 👍🏼 I agree with the adjustments also


Conducting Image Change Detection to Enhance Understanding - needs slides and videos posted

for Ops Server release
Deadline 9Oct
see email for post location
@helyx-amcmillan

The slides have already been posted.

Video has been posted.


Pokémon Showdown own Pastebin-like service

Will be nice can upload a team or browse other uploaded teams directly from PS client.

Please post your ideas in the suggestions thread in the Pokemon Showdown forum instead of opening issues here.


SDK should track registry consistency

The SDK should keep track locally of what the registry changes are it's expecting and update keeping consistent with that.
It should remember the last revision number it used, rather than trust skynet to give it the strictly latest revision.
That gets trickier if you assume the user has multiple windows open for the same app on multiple machines, because the SDK has to coordinate now, but that gets a lot easier once websockets are done.

This is implemented and live with SkyDB v2.


Not applicable to folders in mapped network drivers

I found it not applicable to folders in mapped network drivers... Was it coded this way or maybe I missed any configuration...

Can you be more descriptive?
Clearly what is the problem, how can I reproduce the problem?

When I tried to apply to the folders in mapped network driver (which you can see the snap attached), the color of the folder was not changed. Refreshing was no help. This network driver was mapped from my NAS via Samba. I just tried with another networked driver mapped from other PC, not working either.

I see. Can you check to see if the remote folder has a "desktop.ini" in it?
In Windows explorer you have to go into the "Folder Options" and under "View" and uncheck the "Hide protected operating system files (Recommended)".
That would be the first problem. Not sure if Windows will allow setting (creating if doesn't exist) these "desktop.ini" remotely.
Might not help either that your NAS server is probably Linux using Ext4 not NTFS.
But I'm not so sure this is the problem. It's really getting into OS factors though.
Would mind checking to see if Folcolor is able to write (through the Windows API) a "desktop.ini" in the destination folder?
If it doesn't try setting the color for a local folder and then copy the "desktop.ini" from that folder over to the remote folder.
Although still probably the file would be need to have the "system" attribute.
If it was local you can use "attrib" to set the "system" attribute to a file. And since the remote OS might be Ext4, this still might not work.
For Linux you could use "chattr" to change permissions (Microsoft uses the name "attributes") and Linux doesn't even have a "system" permission.

I copied the "desktop.ini" file to the folder in remote driver from my local folder. I set "system" attribute to the remote folder, then the folder turned into the same color as the original local folder. However, I have to manually set attribute to specified remote folder in cmd  and modify the number code in the "desktop.ini" file, and press "refresh" everytime.
It basically worked after all. Thanks a lot.

Okay, good to know it will at least work this way.
Already it takes administrator privilege's to even set these "desktop.ini" files, etc.
Must be some trick, like some missing flag or something to allow it to happen over a network.
I'll look into it to see if there is a solution to avoid having to do those manual steps.

hi @kweatherman! Wondering if you have any update on the issue with mapped folders? I saw the manual solution above but it's too time consuming for to my needs since I change status (color) of folders too often.


ONC G10 Dry Run - documentation and data preparation

Test script - internal only
Need to document the following:

Documentation on how to set up Inferno and run it off of app.medplum.com
Confirm that all test tool scenarios have been pre-tested
Document which version of testing will be accomplished in session
US Core Version:☐  US Core 3.1.1/USCDI v1☐  US Core 4.0.0/USCDI v1☐  US Core 5.0.1/USCDI v2SMART App Launch Version:☐  SMART App Launch 1.0.0☐  SMART App Launch 2.0.0Bulk Data Version:☐  Bulk Data 1.0.1☐  Bulk Data 2.0.0
Document the publicly accessible URL for access
Provide link to API documentation
Link to Terms of Use
Machine readable base URL for listing. The Service Base URL must be a machine readable FHIR resources endpoint that will be used for the ONC Lantern Project.

Related: #1291, #1140

Setup a Medplum project for testing

Setup your Practitioner resources with address, email, phone number, and profile picture
Invite a Patient user with address, email, phone number, and profile picture (you will need to sign in as this Patient)
Setup 2 ClientApplication resources with "Redirect URI" set to "https://inferno.healthit.gov/suites/custom/smart/redirect"

Setup ONC Inferno project

Use "US Core 5.0.1 / USCDI v2"
Use "SMART App Launch 2.0.0"
Use "Bulk Data 2.0.0"

Running tests
1. Standalone Patient App

Select "1. Standalone Patient App"
Click "Run Tests"
a. FHIR Endpoint:  https://api.medplum.com/fhir/R4
b. Standalone Client ID:  Client ID created above
c. Standalone Client Secret: Client secret created above
d. Standalone Scope: Use defaults, but you may need to add "patient/ServiceRequest.rs"
e. Click "Submit"
Click on "Follow this link to authorize..."
Sign in as the Patient you created above
a. Click "Remember me"
b. Click "Sign in"
c. Accept all scopes and click "Set scope"

2. Limited Access App

Select "2. Limited Access App"
Click "Run tests"
a. Accept all defaults.  Note the expected resources "Patient, Condition, Observation"
b. Click "Submit"
Click on "Follow this link to authorize..."
Sign in as the Patient you created above
a. Click "Remember me"
b. Click "Sign in"
c. Keep the OpenID scopes "launch/patient", "openid", "fhirUser", and "offline_access"
d. Uncheck all of the "patient/x" scopes except for  "Patient, Condition, Observation"
e. Click "Set Scope"

Linking to draft data bundle for reference.  This will need revision, but putting current working set here for reference.

Developer Documentation must include the following:
API syntax;
function names;
required and optional parameters and their data types;
return variables and their types/structures; and
exceptions and exception handling methods and their returns
Mandatory software components;
Mandatory software configurations; and
All technical requirements and attributes necessary for registration.

Documentation checklist: https://docs.google.com/document/d/1fi51zoL-FmYPKC2gB4TXSFGWw_0OO-Pe/edit?usp=sharing&ouid=115651930576812038339&rtpof=true&sd=true

These are the materials sent by Drummond that we will pre-review Jan. 24

Post review feedback is as follows:

Some tactical updates based on changes to the USCDI Data classes recently released.
Create drafts of all forms for review
Submit documentation checklist for feedback
Team rehearsal scheduled for 1/27

Live testing success!  @reshmakh Ready to close this out, or do you want to wait until all documentation is complete?

Closing this out, sent configuration report and Inferno report in to the proctor.


feat: add krew and krew bot support

Signed-off-by: Engin Diri<EMAIL_ADDRESS>Hi,
I added the krew and krew bot support. unfortunatly are there one manual step, only you can do:

Inital PR to krew-index

Once you’ve run through the checklist above, create a pull request to the krew-index repository with your plugin manifest file (e.g. example.yaml) to the plugins/ directory.

so the file split.yaml is the file you need to PR into the https://github.com/kubernetes-sigs/krew-index repo.
Then you can delete the file from this repo.

i added the .krew.yaml template file and the github action according the docs. Should work for the next release, when you did 1. -> https://github.com/rajatjindal/krew-release-bot

Hope it helps. If you want, we can work on the brew and gofish to, if you want your own tap or rig.
Let me know

Wow this is amazing, thank you very much!
We started a conversation in the Krew Index repo because there seems to be another app that already has a similar name and does something similar -- although there's some major differences which I documented in the README here.
split as a plugin name might not be accepted for being too generic, and split-yaml is taken by the previously submitted app. @ahmetb was kind enough to provide some guidance via Twitter on this regard, so before merging this here, I think the discussion over the krew side needs to be wrapped up.
I hope you don't mind if we hold off this PR for a few until there's some light to that discussion. Still though, appreciate your help adding support for krew!

@patrickdappollonio, no problem! If its clear with the name let me know via Twitter-DM or this issue to update the files!
Cool that @ahmetb is helping you sorting the naming issue! Hero!


feature: generate openqasm from result types

Issue #, if available:
#332
Description of changes:
Add openqasm generation for result types
Testing done:
unit and manual
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Force pushed to coordinate git history with another PR. To review, only look at changes after the result types feature commit: https://github.com/aws/amazon-braket-sdk-python/pull/396/commits/795987a4c7d7939b7642b4b4131ae9ca67f21c1a


Bug: Background color is limited to the screen size only

Bug description
Background height is fixed to 100% only, which leads to the background color filling until the screen's size only.

Reproduction steps

Go to the home page
Scroll down
You will see a partition of 2 colors, a black and a grey

[Alternatively]

Go to your Stats Page
Check your stats in a format where the size of the screen exceeds
Scroll down and you will notice the issue

Expected behavior
The background color should be there until the bottom of the page.

Screenshots

Check the bottom of the Screenshot

Additional context

[x]  I make sure that a similar issue is not opened
[x] I would like to work on this issue.

Thanks for Checking out!
In the case of my issue, the root cause is the height set to 100%.
But in the #41 case, the data is overflowing, what are your thoughts on its cause?
Note: I tried fixing my issue but it is not fixing #41

Ok then, we can keep them separate :)


Skydns refactor

Including an option in netmaster to deploy DNS container (default is enabled)
Added additional checks during tenant create and network create to deal with failure cases
To ensure HA for DNS containers, introduced a restart policy so that it is always restarted

Explanation of changes with output

When started with -dns-enable=false, creation of tenant does not start skydns container

vagrant@netplugin-node1:~$ netctl tenant list
Name
------
tenant1
default

vagrant@netplugin-node1:~$ docker ps
CONTAINER ID        IMAGE                          COMMAND             CREATED             STATUS              PORTS               NAMES

Starting netmaster without any options, starts off skydns containers per tenant by default

vagrant@netplugin-node1:~$ netctl tenant list
Name
------
tenant1
default

vagrant@netplugin-node1:~$ docker ps
CONTAINER ID        IMAGE                          COMMAND             CREATED             STATUS              PORTS               NAMES
ff729f5a4130        skynetservices/skydns:latest   "/skydns"           9 minutes ago       Up 9 minutes        53/tcp, 53/udp      defaultdns
2afb234c7f92        skynetservices/skydns:latest   "/skydns"           8 minutes ago       Up 8 minutes        53/tcp, 53/udp      tenant1dns

During network attach:

If the tenant-dns is missing

DNS container is started off and the attach is tried again

If this fails, the network creation continues after a warning is issued

If the tenant-dns is in stopped state

A restart of the dns container is attempted

If this fails, network creation continues after a warning is issued

When starting a skydns container:

If the skydns image is missing on the node

A pull of skydns image is attempted

If the skydns pull fails, a warning is issued and tenant creation proceeds

To ensure that the HA of DNS provider, the skydns container is started off with "always" restart-policy. With this policy, docker tries to bring back the skydns container whenever it fails/docker restarts.

Changes look fine.
Lets sync up about globally disabling dns mode when skydns on single tenant fails..

@DivyaVavili Another note before i forget. Can you look into DNS server implementation in latest libnetwork? I'm wondering if we should embed lightweight DNS server into netplugin/netmaster similar to libnetwork. This might avoid lot of dependency issues with skydns..
We should also look at kubernetes/mesos requirements for service discovery and see how we can unify our code across all three..

I'm wondering if we should embed lightweight DNS server into netplugin/netmaster similar to libnetwork. This might avoid lot of dependency issues with skydns..

I am wondering if we need dns-server at all now that libnetwork/k8s/mesos have built in dns for container workloads.

@jainvipin: I'm trying out the embedded DNS option with docker 1.10. Running into a couple of issues with that. Will try it out and we could move to that option as required. These changes should help till then to sort out any issues.

LGTM, other than the minor comments

LGTM
We can merge this once sanity passes..


Spike: Auto-unseal with transient secrets mechanism for Hashicorp Vault

Is your feature request related to a problem? Please describe.
We need to provide secure method for automatic unsealing Hashicorp Vault in some scenarios.
Describe the solution you'd like
I want to use transient secrets for Spike scenario to assess such possibility. This scenario is well described here:
https://learn.hashicorp.com/vault/day-one/autounseal-transit
Describe alternatives you've considered
For development purpose we can use script that is already in Epiphany, but it would be better to have also other options to perform unseal operation.
Additional context
No additional context.

Closing because of deprecation of Hashicorp Vault component.


Support for multiple periodic commands

Adds the ability to have multiple periodic commands registered.

The build broke with a race condition, can you please run the tests with -race flag and fix it? Thanks.

@fabioxgn Sorry about that, still new to go. I changed startPeriodicCommands to not be async anymore.

@zachomedia thanks, please send a new PR when you are done.
I also noticed that some plugins are broken and were breaking the build, so I removed then from the build process, will try to fix the build process in the PRs which are broken.

PR #51 submitted with the fix


Sublime plugin_host exiting unexpectedly when starting pyls

LSP: starting ['pyls']
LSP:  --> initialize
LSP: window 2 added session pyls
error: plugin_host has exited unexpectedly, plugin functionality won't be available until Sublime Text has been restarted

Originally posted by @AmjadHD in https://github.com/tomv564/LSP/issues/414#issuecomment-425674342

I see this also on Windows with a recent pyls, both stdio and tcp mode. My typescript server works fine, and only starting pyls is also fine.
I suspect the initialize request makes the server crash, right after it logs about preloading modules. Plugin_host exiting sounds similar to an open ST3 issue.
Can someone try to narrow down a pyls or lsp version this started happening with?

Looking at the python language server changelog, it is something new in 0.21.
pip uninstall python-language-server
pip install python-language-server==0.20

After this downgrade the crash went away.


Back to Basics

It would be very helpful to have a link to the documentation for rolling back to default SharePoint/removing all customization in this document.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20221104-c118-99fd-8a84-9704d6c51e53
Version Independent ID: 4f60a86f-a539-c57c-c29e-3b7cd189af13
Content: Master pages, the Master Page Gallery, and page layouts in SharePoint
Content Source: docs/general-development/master-pages-the-master-page-gallery-and-page-layouts-in-sharepoint.md
Service: unspecified
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Not clear... as in referencing an existing page? I'm not aware of an existing page that demonstrates this...
It's basically "undo the customizations you did"...


can't send request

Subject: can't send request
Description:
I completed my profile but I can't send a request
Results:
there is a message to complete may profile
Backend version: develop-c3dbc14a
Frontend version: develop-c3dbc14a
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0
Page: https://couchers.org/preview
User: bspeechy (46985)

tested this and its not correct, the request works once profile had a certain amount of content.


godep breaks local development?

Expected behavior
Thanks for making this great tool available!  :-)
I don't understand how to use godep for local development of my own go app that depends both on external third party go packages as well as my own packages.  I've googled and searched the README and I can't find any help on this.  Can somebody please help?  :-)
I've laid out my workspace according to go standards (multiple of my own go packages in the same git repo):
github.com/mystuff/mycli
github.com/mystuff/mycore
OK, I commit all my code to git and then I run godep save ./... in the mycli dir which creates directories
github.com/mystuff/mycli/Godeps
github.com/mystuff/mycli/vendor
and all is well.  I can deploy to Heroku, AWS, etc.  Great.
Then I edit some of my files locally in mycore, for example adding a new type Foo.  Then I edit some files in mycli to use my new type Foo.  Note that I've made changes locally and these changes are not committed to git yet (because I need to verify that they build and work correctly before committing them).
However, now my build is totally broken.  Any attempt to build mycore with the new type Foo succeeds.  Any attempt to build mycli results in a syntax error ./main.go:48: undefined: mycore.Foo (I updated mycli/main.go to reference the new type Foo).  This is not true, mycore.Foo is perfectly well defined and compiles just fine when I go build in the mycore dir.
I was stuck unable to build my code, until I did
cd github.com/mystuff/mycli/
mv Godeps gd
mv vendor ve

# Now stuff builds just find and Foo is no longer "undefined"

So it seems that godep was somehow hiding my local changes?    But no, I can't do that - I'm not going to commit stuff in mycore and mycli just to see if it works properly in mycli - I need to build and test before committing.
So I don't understand, it seems like godep breaks local development?  How, during local development, do I tell godep "hey, just use the version of mycli and mycore that are locally on disk, forget about what you think you should use from Godeps.json or vendor for my own code, but still use those fixed versions for other packages".
How do I do that?  I'm a go and godep newbie, so apologies if I missed something obvious or some convention - if somebody can help me out I'd be happy to create a PR to update docs to make this more clear.
But I just can't afford to mv the godep and vendor dirs each time I need to test local changes to my own code or commit those changes before build.  That's just too slow ...
Actual behavior
godep should allow local development to use local changes to my own code without interference from Godeps or vendor.
Steps to reproduce behavior
See above.
godep version output
godep v79 (darwin/amd64/go1.8)
go version output
go version go1.8 darwin/amd64
Contents of Godeps.json file
{
        "ImportPath": "github.com/mystuff/mycli",
        "GoVersion": "go1.8",
        "GodepVersion": "v79",
        "Packages": [
                "./..."
        ],
        "Deps": [
                {
                        "ImportPath": "github.com/google/uuid",
                        "Comment": "0.2-3-g6a5e285",
                        "Rev": "6a5e28554805e78ea6141142aba763936c4761c0"
                },
                {
                        "ImportPath": "github.com/mystuff/mycore",
                        "Rev": "1e2145d04ab6e124671d65990e65da5038bef84f"
                },
                {
                        "ImportPath": "github.com/pressly/chi",
                        "Comment": "v2.0.0-26-g5b7406a",
                        "Rev": "5b7406a71dbb35d4f59b0b48e68cd9f9256f5262"
                },
                {
                        "ImportPath": "github.com/pressly/chi/middleware",
                        "Comment": "v2.0.0-26-g5b7406a",
                        "Rev": "5b7406a71dbb35d4f59b0b48e68cd9f9256f5262"
                },
                {
                        "ImportPath": "github.com/pressly/chi/render",
                        "Comment": "v2.0.0-26-g5b7406a",
                        "Rev": "5b7406a71dbb35d4f59b0b48e68cd9f9256f5262"
                }
        ]
}

Bump.  Any updates?

Bump.  Any updates?  Can somebody please help ... Thanks!  :-)

i guess you need to use "godep go build -o main" instead of "go build -o main"

Thanks @fforootd !
But I'm not using godep to build.  I'm doing my builds inside of LiteIDE for rapid development and iteration.  However, I need godep for deployment to heroku.  I just need godep to not break my builds in LiteIDE.  Any ideas?

I am closing this issue because the repo is going to be archived.


Graphviz interpreter fails on syntax error?

this line is typical of other lines in graphviz generated files that begin with subgraph,
subgraph "cluster[{"type":"MemberAccess","expression":{"type":"Identifier","name":"pending"},"memberName":"to"}]"

except that the naming convention isn't maintained.
instead of:
subgraph "clusterArrays" {
graph [...]
}

subgraph "clusterAddress" {
graph [...]
}

subgraph "clusterReentrancyGuard" {
graph [...]
}

we have
subgraph "cluster[{"type":"MemberAccess","expression":{"type":"Identifier","name":"pending"},"memberName":"to"}]" {
graph [...]
}

so it violates the observed naming convention in this autogenerated file, which returns a syntax error when run through dot -Tpng

why is this closed if it still does not work?

Has this happened to you in the latest version, @guylando?
Could you please point me to a code example where I could reproduce this crash?

@GNSPS
just running
npm install -g surya
surya inheritance MyContract.sol
produces exactly the problem described here

But do you happen to have the source for "MyContract.sol"? 😊
If you call it with an inexistent file as a parameter it should error out automatically and not output any Graphviz DAG.

https://github.com/guylando/EthereumSmartContracts/blob/master/SafeUpgradeableTokenERC20/contracts/SafeUpgradeableTokenERC20.sol
"If you call it with an inexistent file as a parameter it should error out automatically and not output any Graphviz DAG.", oh really?! surprising!

So the "MyContract.sol" is actually a placeholder for the name of the contract whose inheritance you want to graph!
Surya is actually working with your example contract. What I did:
$ git clone git@github.com:guylando/EthereumSmartContracts.git
$ cd SafeUpgradeableTokenERC20/contracts
$ surya inheritance SafeUpgradeableTokenERC20.sol
And it outputs a Graphviz valid file.
There are other options to run Surya on your codebase, though. Some examples are:
$ surya inheritance contracts/**/*.sol <- calling it with a glob pattern will pass along a list of files to be fed to Surya that will all be processed together
$ surya inheritance -i SafeUpgradeableTokenERC20.sol <- using the -i (or --importer) flag actually fetches all the files that are imported in the files passed along automatically

This being said I don't think there actually is a bug here! 😄


Implement write feature

This PR implement the write functionality of a parquet file
the method requires a path and a Record class to let the plugin know about the internal structure of the file to create

@pditommaso @bentsherman can you take a look to this pr? Would be great to have v0.0.1 of this plugin published

It looks fine to me, as long as you have tests that are passing. Do you not have the ability to merge?
Also, out of curiosity, does this library work only with record types or can it work with any class?

It looks fine to me, as long as you have tests that are passing. Do you not have the ability to merge?

No, I can't merge:(

Also, out of curiosity, does this library work only with record types or can it work with any class?

Exactly,  it works only with records. To read you can use Map (so it will read all fields) but a record is required to write

@pditommaso I'm fine with giving Jorge merge permissions on this repo, what do you think

hi folks
sorry to be missing for a while, if you don't mind I would like to continue with this project and work on it so we can publish soon a first release version

Jorge, think you are an admin of this project

due some issues couldnt accept the invitation link and it expired


add log module to build aggregate

I noticed the log module wasn't being published, but I found it useful while I was playing with the library. I think with these changes, it should be published during the next release.

oh no, I didn't see this 😢 @bpholt if you don't mind, my solution to the mapValues problem involved less code (and zero version-specific code), so maybe let's merge that instead? #74
(also, circe 0.12 got old real quick)

I don’t mind at all! I’ll close this one.


全部都安装上了 一直说找不到 npm: ERR! 404 Not Found: wechaty_puppet@latest

PS F:\ayzb\wechaty-puppet-padchat> npm start

<EMAIL_ADDRESS>start F:\ayzb\wechaty-puppet-padchat
node examples/starter-bot.js

15:20:01 INFO Wechaty <wechaty_puppet> start() v0.22.6 is starting...
15:20:01 INFO PuppetManager install(wechaty_puppet@latest) please wait ...
npm: npm
npm:  ERR! code E404
npm
npm: ERR! 404 Not Found: wechaty_puppet@latest
npm:
npm: npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-02-28T07_20_09_908Z-debug.log
{ Error: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-02-28T07_20_09_908Z-debug.log
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:182:13)
at ChildProcess.EventEmitter.emit (domain.js:441:20)
at maybeClose (internal/child_process.js:962:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

killed: false,
code: 1,
signal: null,
cmd: 'npm install wechaty_puppet@latest ' }
15:20:10 ERR Wechaty start() exception: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-02-28T07_20_09_908Z-debug.log
{ Error: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-02-28T07_20_09_908Z-debug.log
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:182:13)
at ChildProcess.EventEmitter.emit (domain.js:441:20)
at maybeClose (internal/child_process.js:962:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

killed: false,
code: 1,
signal: null,
cmd: 'npm install wechaty_puppet@latest ' }
PS F:\ayzb\wechaty-puppet-padchat>

Could you describe your issue as the following template? Thanks!

Important：Please file the issue follow the template, or we won't help you to solve the problem.

0. Report Issue Guide

Please run the following command and check whether the problem has been fixed：

rm -rf package-lock.json
rm -rf node_modules
npm install

Please search in FAQ List first, and make sure your problem has not been solved before.

Please search in the issue first, and make sure your problem had not been reported before

1. Versions

What is your wechaty version?
Answer:

Which puppet are you using for wechaty? (padchat/puppeteer/padpro/...)
Answer:

What is your wechaty-puppet-XXX（padchat/puppeteer/） version?
Answer:

What is your node version? (run node --version)
Answer:

What os are you using
Answer:

2. Describe the bug
Give a clear and concise description of what the bug is.
3. To Reproduce
This part is very important: if you can not provide any reproduce steps, then the problem will be very hard to be recognized.
Steps to reproduce the behavior:

run '...'
...
...

4. Expected behavior
Give a clear and concise description of what you expected to happen.
5. Actual behavior
If applicable, add screenshots to help explain your problem. But do not paste log screenshots here.
6. Full Output Logs
Set env WECHATY_LOG=silly in order to set log level to silly, then we can get the full log (If you dosen't set log env, log level is info as default, we cannot get the full log)
We need full log instead of log screenshot or log fragments!

Show Logs

$ WECHATY_LOG=silly node yourbot.js

Question: Paste your FULL(DO NOT ONLY PROVIDE FRAGMENTS) log messages
Answer:

7. Additional context
Add any other context about the problem here.
[bug]

Try the following command
rm -rf package-lock.json
rm -rf node_modules
npm install wechaty
npm instal wechaty-puppet-padchat@next
npm start

请尝试以下命令
rm -rf package-lock.json
rm -rf node_modules
npm install wechaty
npm instal wechaty-puppet-padchat @ next
npm start

以上命令解决不了问题
Windows PowerShell
版权所有 (C) Microsoft Corporation。保留所有权利。
PS F:\ayzb\wechaty-puppet-padchat> rm -rf package-lock.json
Remove-Item : 找不到与参数名称“rf”匹配的参数。
所在位置 行:1 字符: 4

rm -rf package-lock.json

+ CategoryInfo          : InvalidArgument: (:) [Remove-Item]，ParameterBindingException
+ FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

PS F:\ayzb\wechaty-puppet-padchat> rm -rf node_modules
Remove-Item : 找不到与参数名称“rf”匹配的参数。
所在位置 行:1 字符: 4

rm -rf node_modules

+ CategoryInfo          : InvalidArgument: (:) [Remove-Item]，ParameterBindingException
+ FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

PS F:\ayzb\wechaty-puppet-padchat>

Please delete file package-lock.json and folder node_modules

Please delete file package-lock.json and folder node_modules. Then try again.

每一步都按照你说的做的，还是这个log，能帮忙看一下吗
PS F:\ayzb\we2\wechaty-getting-started> npm start

<EMAIL_ADDRESS>start F:\ayzb\we2\wechaty-getting-started
node examples/starter-bot.js

15:07:43 INFO Wechaty <wechaty_puppet> start() v0.22.6 is starting...
15:07:43 INFO PuppetManager install(wechaty_puppet@latest) please wait ...
npm: npm
npm: ERR! code E404
npm
npm:  ERR! 404 Not Found: wechaty_puppet@latest
npm:
npm: npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-03-04T07_07_46_081Z-debug.log
{ Error: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-03-04T07_07_46_081Z-debug.log
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:182:13)
at ChildProcess.EventEmitter.emit (domain.js:441:20)
at maybeClose (internal/child_process.js:962:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

killed: false,
code: 1,
signal: null,
cmd: 'npm install wechaty_puppet@latest ' }
15:07:46 ERR Wechaty start() exception: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-03-04T07_07_46_081Z-debug.log
{ Error: Command failed: npm install wechaty_puppet@latest
npm ERR! code E404
npm ERR! 404 Not Found: wechaty_puppet@latest
npm ERR!      D:\Develop\nodejs\node_cache_logs\2019-03-04T07_07_46_081Z-debug.log
at ChildProcess.exithandler (child_process.js:294:12)
at ChildProcess.emit (events.js:182:13)
at ChildProcess.EventEmitter.emit (domain.js:441:20)
at maybeClose (internal/child_process.js:962:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)

killed: false,
code: 1,
signal: null,
cmd: 'npm install wechaty_puppet@latest ' }
PS F:\ayzb\we2\wechaty-getting-started>

删除 package-lock.json 和 node_modules
安装 wechaty
安装 wechaty-puppet-padchat

删除 package-lock.json 和 node_modules
安装 wechaty
安装 wechaty-puppet-padchat

你好 我就是按照你说的做的 先删除package-lock.json 和 node_modules
然后npm install wechaty
接着npm install wechaty-puppet-padchat
最后npm start
还是报的上面的错 环境变量也配置了

你可以重新创建个目录，然后每一步按照我的操作，都附上相关的日志么？ 每操作一步，放一步日志。

楼主解决了吗，我也是同样的问题

It should not be wechaty_puppet, but wechaty-puppet-puppeteer, or wechaty-puppet-padpro, etc.
Learn more from: https://github.com/Chatie/wechaty-puppet/wiki/Directory


Document Celery checks on installation

We need a troubleshooting.md file that asks users to check if the admin has loaded the Periodic Tasks.
When installing, indexing will only happen if Celery started after the database was ready.

Fixed.


Feature Request: full automatic installation

I think the installation can be fully automatic if modda provides a way to record the the question and answer from the user. It should only stop when it encountered unanswered questions.
If it can be fully automatic, we will have wabbajack for BG.

I acknowledge your request and consider it sensible.
It's probably possible to have something like that though I couldn't tell exactly in what form.
But I probably won't be able to look at it in the short term.


Issue event types documentation lacks details for several event types that can be found in the API

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/developers/webhooks-and-events/events/issue-event-types
What part(s) of the article would you like to see updated?
There are several issue event types that can be encountered when using the issue/timeline events REST API that are not documented in the aforementioned page. Some examples are added_to_merge_queue, auto_merge_disabled, auto_merge_enabled, auto_squash_enabled, but there are others...
As @felicitymay rightly pointed out in #35045, auto-generating the content of the article would be the best way to ensure it stays up-to-date as new events are introduced.
Additional information
No response

@Fs00 Thank you for raising this issue! I'll get this triaged for review :sparkles: Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛


Created Burger of the Day applet

"Burger of the Day" applet, based on the burger board behind the counter at Bob's Burgers! It shows a set burger each day. It can also be configured to show a random burger every cycle, or a custom burger if a user has an idea for their own punny burger.

I have read the CLA Document and I hereby sign the CLA

This is going to be AMAZING!


Update README

Signed-off-by: Omar Shrit<EMAIL_ADDRESS>

I think we can update readme at this level


ci: merge staging to master

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

Pipeline Attempt on<PHONE_NUMBER> for 1bce13632fdb1dababf513e3df0ac19c459a4eed
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1037605391

Pipeline Succeeded on<PHONE_NUMBER> for 1bce13632fdb1dababf513e3df0ac19c459a4eed
https://gitlab.com/MatrixAI/open-source/js-mdns/-/pipelines/1037605391


optimize device to cpu in ut

Signed-off-by: ChengZi<EMAIL_ADDRESS>

Codecov Report

Merging #884 (9219ffb) into main (e7d4b65) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   69.73%   69.72%   -0.02%
==========================================
  Files         200      200
  Lines        8678     8678
  Branches     1424     1424
==========================================
- Hits         6052     6051       -1
- Misses       2206     2208       +2
+ Partials      420      419       -1

Impacted Files
Coverage Δ

towhee/hub/repo_manager.py
80.18% <0.00%> (-0.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d4b65...9219ffb. Read the comment docs.

/lgtm
/approve


Enum type ignores modelsuffix

If I add modelSuffix option then only objects generated with suffix.
Looking into the code I found this line in Swift code fornatter
return escapeType("\(modelPrefix)\(name.upperCamelCased())")

Shall we add enum suffix support?

Yeah I can see value in that. How do you use the modelPrefix? For organisational namespacing, or avoiding collisions?


Add 'ignore_malformed' to MappingLimitSettings

Closes https://github.com/elastic/elasticsearch-specification/issues/1566

Thanks Tomas, I'll merge once we get a passing CI.


Replace prebuilt KTX with a build step.

This removes the samples/envs folder and replaces these KTX files with a
build step that is driven by CMake / gradle / bash, depending on
platform.
This makes it easier to use IBL files that are generated by the latest
and greatest version of cmake.

Thanks for updating the iOS projects! I'll verify that the changes work today.

Thanks Ben.  Do you prefer that I merge this or wait?

Feel free to merge now and I can update the projects in a separate PR.


Headers compatibility

Currently, the semantics of Headers class is incompatible with the Fetch Standard. Merely fixing those incompatibilities is trivial, but whether we want to do so needs a discussion, since

We might break existing applications using node-fetch
We might break compatibility with GitHub's fetch browser polyfill
We might break compatibility with existing native browser implementations (e.g. Google Chrome and Firefox)

I've compiled a list of potential issues, its behaviors on a specific platform, and my recommendation.
Compatibility chart
Status quo:
Issue | Spec | GitHub | Browsers
--------|:------:|:-----------:|:------:|:-----:
ctor array | :x: | :white_check_mark: | :x:
ctor non-enum prop |    | :x: | :white_check_mark:
ctor array prop | :x: | :x: | :x:
append/set array | :x: | :x: | :x:
forEach/getAll | :exclamation: | :white_check_mark: | :white_check_mark:
get | :x: | :white_check_mark: | :white_check_mark:
iterable | :x:  | :x:  | :x:
illegal chars | :x: | :white_check_mark: | :x:
Using the proposed default behavior:
Issue | Spec | GitHub | Browsers | Behavior changed?
--------|:------:|:-----------:|:------:|:-----:|:---------:
ctor array | :white_check_mark: | :x: | :white_check_mark: | Yes
ctor non-enum prop |    | :x: | :white_check_mark: | No
ctor array prop | :white_check_mark:  | :white_check_mark: | :white_check_mark: | Yes
append/set array | :white_check_mark: | :white_check_mark: | :white_check_mark: | Yes
forEach/getAll | :exclamation: | :white_check_mark: | :white_check_mark: | No
get | :x: |  :white_check_mark: | :white_check_mark: | No
iterable | :x: | :white_check_mark: | :white_check_mark: | Yes
illegal chars | :white_check_mark: | :x: | :white_check_mark: | Yes
Using the proposed FOLLOW_SPEC mode:
Issue | Spec | GitHub | Browsers | Behavior changed?
--------|:------:|:-----------:|:------:|:-----:|:---------:
get | :white_check_mark: | :x: | :x: | Yes
iterable | :white_check_mark: | :x: | :x: | Yes
Constructor with array
var h = new Headers([['My-Header', 'first'], ['My-Header2', 'second']]);
console.log(h.get('My-Header'));
console.log(h.get('My-Header2'));

Spec: For every elements within the array, use the first element as the name and the second as the value ('first'; 'second')
Current: No support at all (null; null)
GitHub: No support at all (null; null)
Chrome, Firefox: Follows spec ('first'; 'second')
My opinion: Follows spec ('first'; 'second')
Constructor with object with non-enumerable properties
var a = {};
Object.defineProperties(a, {
  one: {enumerable: true, value: 'one'},
  two: {enumerable: false, value: 'two'},
});
var h = new Headers(a);
console.log(h.get('one'));
console.log(h.get('two'));

Spec: Ambiguous ("open-ended dictionary" is not defined anywhere)
Current: Ignores non-enumerable properties ('one'; null)
GitHub: Treats non-enumerable properties the same way as regular properties ('one'; 'two')
Chrome & Firefox: Ignores non-enumerable properties ('one'; null)
My opinion: Maintain current behavior ('one'; null)
Constructor with object properties whose values are arrays
var h = new Headers({ 'My-Header': [ 'first', 'second' ] });
console.log(h.getAll('My-Header'));

Spec: The array needs to first be converted to ByteString using the .toString() method of the array, which is equivalent to joining with comma ([ 'first,second' ])
Current: The individual elements are treated as separate headers ([ 'first', 'second' ])
GitHub: Follows spec ([ 'first,second' ])
Chrome, Firefox: Follows spec ([ 'first,second' ])
My opinion: Follows spec ([ 'first,second' ])
append() and set() with array
var h = new Headers({ 'My-Header': 'zeroeth' });
h.append('My-Header', ['first', 'second']);
h.set('My-Header2', ['first', 'second']);
console.log(h.getAll('My-Header'));
console.log(h.getAll('My-Header2'));

// Note: `getAll` is removed in spec, but for the express purpose of
// showing this problem let's pretend it still exists.

Spec: The array needs to first be converted to ByteString using the .toString() method of the array, which is equivalent to joining with comma ([ 'zeroeth', 'first,second' ]; [ 'first,second' ])
Current: The conversion to string never happens, causing some inconsistent behaviors ([ 'zeroeth', [ 'first', 'second' ] ], [ [ 'first', 'second' ] ])
GitHub: Follows spec ([ 'zeroeth', 'first,second' ]; [ 'first,second' ])
Chrome, Firefox: Follows spec ([ 'zeroeth', 'first,second' ]; [ 'first,second' ])
My opinion: Follows spec ([ 'zeroeth', 'first,second' ]; [ 'first,second' ])
forEach() and getAll()
Spec: The two methods are removed.
Current: Still exist
GitHub: Still exist
Chrome, Firefox: Still exist
My opinion: Keep them
get() with multiple values for the same header
var h = new Headers;
h.append('My-Header', 'first');
h.append('My-Header', 'second');
console.log(h.get('My-Header'));

Spec: Return the "combined value" of all headers of the specified name, which means all headers of the name are joined using a comma ('first,second')
Current: Returns the first header only ('first')
GitHub: Returns the first header only ('first')
Chrome, Firefox: Returns the first header only ('first')
My opinion: Maintain current behavior by default, but offer an option to follow spec ('first')
Iterable interface
var h = new Headers;
h.append('z', 'first');
h.append('a', 'second');
h.append('a', 'third');
h.append('z', 'fourth');
console.log(Array.from(h));

Spec: The "return value of running sort and combine with the header list." ([ [ 'a', 'second,third' ], [ 'z', 'first,fourth' ] ])
Current: Not yet implemented; #180 implements the GitHub behavior
GitHub: Order of addition of header name, then of header ([ [ 'z', 'first'], [ 'z', 'fourth' ], [ 'a', 'second' ], [ 'a', 'third' ] ])
Chrome, Firefox: Order of addition of header ([ [ 'z', 'first'], [ 'a', 'second' ], [ 'a', 'third' ], [ 'z', 'fourth' ] ])
My opinion: Use GitHub's implementation, but offer an option to follow spec ([ [ 'z', 'first'], [ 'z', 'fourth' ], [ 'a', 'second' ], [ 'a', 'third' ] ])
Illegal characters in header name
new Headers({ '\n': 'hey' });

Spec: Throws a TypeError
Current: Allowed
GitHub: Allowed
Chrome & Firefox: Follows spec; throws a TypeError
My opinion:  Follow spec; throw a TypeError
Option to follow spec
For the following two issues, I propose adding an option either enabling the spec or (by default) disabling the spec behavior.

get() with multiple values for the same header
Iterable interface

This option could be module-wide, so to change it would be
require('node-fetch/lib/headers.js').FOLLOW_SPEC = true;

I have read through it and it looks good to me.
In general I think browsers did a good job following spec and keeping compatibility with existing code in the wild.

get() with multiple values for the same header
Spec: Return the "combined value" of all headers of the specified name, which means all headers of the name are joined using a comma ('first,second')

Looks like the spec changed, I have no idea why they did that, maybe during the drop of getAll().

Iterable interface

Now that I think of it, maybe there wasn't a sort-and-combine requirement in spec when I was implementing them, so this might again be a breaking spec change.

Option to follow spec

I think this is the right approach, since spec changes rapidly (and doesn't seem to care about breaking changes). We should warn users, using this flag may face more breakage.

One drawback with Option to follow spec approach is maintenance cost, but I guess you know that already.

One drawback with Option to follow spec approach is maintenance cost, but I guess you know that already.

Indeed. In #185 I made the test suite run twice -- once with the option enabled and once disabled. That should be able to help matters.

Fixed in #185.


Recent change broke inserting values into PostgreSQL columns

Environment
Knex version: 2.4.0
Database + version: PostgreSQL 14
OS: macOS 13.1
Bug
Failing to insert rows on tables with, for example text[] type.
Presumably this is due to a regression from this change https://github.com/knex/knex/pull/5321
Error message
malformed array literal: "[]"

Will happily add example code if needed.

Ah, just saw an earlier report.. Sorry, closing.


Es2015plus

After my messy attempt to contribute some fixes ~2 weeks ago, I went back over what I had on my end. Since I'm trying to use Backbone with an ES2015+ project; and the assorted online guides about trying such date back 3+ years with mixed results; I figured I'd try to make a conversion effort. ESLint & Deep Code were particularly helpful. I figured you all could do something with this on your own time; hence the separate branch. Thanks.

Hi,
Is there a reason you decided to go this road and not take (and possibly improve) this https://github.com/typhonjs-backbone/backbone-es6 ?

I didn't even see that come up in my searches on the topic before. Thanks
for bringing it to my attention.
That particular effort looks moribund ATM, and I was able to spin out this
effort based on reference materials & heavy code linting. I also wanted it
to be as close to the original as possible: I don't have good unit testing
of my own, but was able to try fixing up the testing in this batch.
On Wed, May 16, 2018, 5:08 PM noobiek<EMAIL_ADDRESS>wrote:

Hi,
Is there a reason you decided to go this road and not take (and possibly
improve) this https://github.com/typhonjs-backbone/backbone-es6 ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jashkenas/backbone/pull/4196#issuecomment-389703681,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9fv033MKUmF20UgQvw8KSXexNkpM7Gks5tzL-DgaJpZM4UAqIQ
.

Moribund.... Really? ;P Uh.. I don't do anything w/ it until this repo actually decides to pull the trigger on a release, so 1.3.3 compatible. If 1.4 is actually released I'd update backbone-es6. ;P Please release! ;P

@typhonrt @noobiek I've got some personal stuff going on the next few days, so I won't have time to compare my yeoman effort here; against what you guys came up with. I'd be willing to put in some effort to help out whomever wants the help: I just want https://github.com/unquietwiki/floorplan to work right; I'm having trouble passing a Backbone.Collection from the browser into a series of ES2015+ classes. You might also want to look at what linters I set up to get this far. Thanks!

So far I did not have any problems using BB in ES6 webpack builds.

Or did you miss that one too?
If your problems were with something else - can you be more specific where you had problems and what these problems were?

@typhonrt why not move forward, branching off BB to something else? Give BB a second life perhaps, and integrate bb.stickit into it (they are looking for maintainers, btw). I like the way bb.stickit handles views updates so much!

Hey I've heard you were discussing BB as es6 modules so I came to throw my version into the mix
https://github.com/HuasoFoundries/backbone_es6/
It's just old method extract refactoring technique, along with es6 named imports and finally rollup.js to bundle it out. I make sure my build passes the official repo tests.

@amenadiel Do you tested to see if tree shaking worked?
We did the same with Marionette but tree shaking nor uglify dead code elimination worked even using ES modules. Tested with webpack 4x
I found that extending the prototype after the class constructor avoided tree shaking or dead code elimination
The only way to remove unused class from the bundle would be using ES6 class or wrapping all definition in a iif with a  /#PURE/ annotation.
Related:
https://github.com/babel/babel/issues/5632
https://github.com/mishoo/UglifyJS2/issues/1261

@blikblum tree shaking works for some components, like View for example. (module is 11Kb vs 73Kb of the full Backbone module)
In other cases, like Collection, it depends on Model, so you can't really import collection by itself.

Hey everyone. Sorry for the belated followup: got married, and also been recovering from a cold.
(ponders)
@typhonrt Your attempt at this is a lot in line with what I was trying to do. However, I'm unclear how to actually try to use it; let alone help clean that up. I have attached the linting rules I used for mine; as for building, the process needs refinement.
eslintrc.txt
@amenadiel I like that yours is on NPM, and has a bit more current documentation on it. However, when you say you can't use classes with it; that would seem to defeat what Typhon and I want to do?
@noobiek Aside from what we've posted here thus far, I also found https://github.com/maratfakhreev/backbone-es6-promise from @maratfakhreev , and https://github.com/lukasolson/backbone-super from @lukasolson . It would seem from what I wanted to do; and what everyone else has tried to do already; it seems like there has to be some kind of solution here? The stumbling blocks I am aware of overall include proper super/this inheritance, proper use of arguments, and seeing if any of this works in the latest browsers without being Babelized (which would help determine how to make that work).
Some related reading material I found trying to understand this stuff.

https://zendev.com/2018/05/09/understanding-spread-operator-in-javascript.html
https://medium.freecodecamp.org/here-are-examples-of-everything-new-in-ecmascript-2016-2017-and-2018-d52fa3b5a70e

https://github.com/unquietwiki/floorplan I have my latest code updated for the project I'm working on; did set it to use backbone_es6 from @amenadiel . My Backbone classes in the browser still can't properly consume collections for some reason. :-/

@unquietwiki currently the common way is to do
var messageModel = Backbone.Model.extend({
   ...
});

So... you'd like to be able to do
class MyModel extends Backbone.Model {
  ...
}

It doesn't sound like a big deal. If we rewrite Model, View, Controller to become classes, then extending them would be transparent.
However, to keep the compatibility with current projects, extend should be kept as a static method with takes me to the bottomline: I have yet to learn to implement a static method capable to perform prototypical inheritance from a class to a plain object.

https://github.com/unquietwiki/floorplan/blob/master/references.md Check
there: I dug up a number of updated JS references that might help.
On Tue, Jun 5, 2018, 8:30 PM Felipe Figueroa<EMAIL_ADDRESS>wrote:

@unquietwiki https://github.com/unquietwiki currently the common way is
to do
var messageModel = Backbone.Model.extend({
...
});
So... you'd like to be able to do
class MyModel extends Backbone.Model {
...
}
It doesn't sound like a big deal. If we rewrite Model, View, Controller to
become classes, then extending them would be transparent.
However, to keep the compatibility with current projects, extend should
be kept as a static method with takes me to the bottomline: I have yet to
learn to implement a static method capable to perform prototypical
inheritance from a class to a plain object.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jashkenas/backbone/pull/4196#issuecomment-394928864,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA9fv2t8kDA5Xg7huUrQ_NgKc05aFupUks5t50zFgaJpZM4UAqIQ
.

How the classical extend is handled in my effort which is separated out in:
https://github.com/typhonjs-backbone/backbone-es6/blob/master/src/extend.js
and the module runtime entry point:
https://github.com/typhonjs-backbone/backbone-es6/blob/master/src/ModuleRuntime.js#L36-L37


Define write destination

This handler is just what I was looking for except for one issue: we can't provide the destination writer. It'd be helpful if the following existed:
func New(writer io.Writer, options slog.HandlerOptions) {}

Use case:
I want to use this library for verbose logging to stderr while my application writes final rendered output to stdout.

That's a good suggestion and I like it. I am currently in an incredibly busy period so wouldn't be able to tackle this in the next few weeks, but I'd happily accept a PR if you wanted to help with this feature?

🎉 congratulations!
If I'm able to get to it before you, I'll submit a PR. Technically, I'm not clear if I can create such a PR from this account and may need to try and remember to do it on personal time.


unable to get the text from the image

I am trying the photo recognition function but unable to process the image and get the text from it. please follow the below code
  const processImageToText = async () => {     try{       if (!sourceUri) {         return;       }       const result = await PhotoRecognizer({           uri:sourceUri,       })       if(result){         setTextFromImage(result)       }     }catch(error){       console.log(error, "error")     }   };
"dependencies": {<EMAIL_ADDRESS>"^3.0.10",     "react": "18.2.0",     "react-native": "0.74.2",     "react-native-image-picker": "^7.1.2",     "react-native-vision-camera": "^4.3.2",     "react-native-vision-camera-text-recognition": "^3.0.4",     "react-native-worklets-core": "^1.3.3"   }
I am getting below error
this is the file path which I am trying get the text : file:///data/user/0/com.cameraapp/cache/rn_image_picker_lib_temp_2cf51127-b739-4e9b-8469-b042b72a5df0.png
out put is this [Error: Error processing image] error

I am updated logic and now it's work without @bam.tech/react-native-image-resizer. Your problem is from permissions.