[CLEANUP] Remove priority from Batch attributes

Description

Remove priority from batch attributes
Refactor tests payloads to remove priority
Leave priority in responses as it is still sent by public-apis

Remaining Tasks

Related PRs in other projects (PASQAL developers only)

Additional merge criteria

Breaking changes

Checklist

[x] The title of the PR follows the right format: [{Label}] {Short Message}. Label examples: IMPROVEMENT, FIX, REFACTORING... Short message is about what your PR changes.

Versioning (PASQAL developers only)

[x] Update the version of pasqal-cloud in _version.py following the changes in your PR and by using semantic versioning.

Documentation

[x] Update CHANGELOG.md with a description explaining briefly the changes to the users.

Tests

[x] Unit tests have been added or adjusted.
[x] Tests were run locally.

Internal tests pipeline (PASQAL developers only)

[ ] Update and run the internal tests while targeting the branch of this PR.
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.

After updating the version (PASQAL developers only)

[ ] Open a PR on the internal tests that updates the version used for the pasqal-cloud backward compatibility tests.

LGTM. Honestly we could decide not to release a full version for this. To do that you can just keep the version unchanged and the release will fail


Recompilation doesn't work when Xcode path contains spaces

Hey there! Love this library, thanks so much!
Noticed one issue: I have my Xcode versions in different folders, and the folders have a space in them. When I hit the inject button, I get this error:

The relevant lines are:
Building iOSInjectionProject/InjectionBundle.xcodeproj
/Applications/Xcode 7.2/Xcode.app/Contents/Developer/usr/bin/xcodebuild  -configuration Debug -arch x86_64 -sdk iphonesimulator

sh: /Applications/Xcode: No such file or directory

Looks like it's try to invoke xcodebuild without quotes, which doesn't work with spaces in the path.
Doesn't sound like a difficult problem to fix, if you wanted to point me in the right direction I can come back with a pull request.

Thanks for the report - Didn’t think of that. It was a simple fix (when you know Perl!) and I’ve pushed it if you want to resync and try.

🎉 I've installed through Alcatraz, would re-installing from there bring in the fix? Happy to test for reproduction :bow:

uninstaling it and reinstalling with Alcatraz should do the trick. It’s was only a script change so you won’t need to restart Xcode.

Seeing another error now, may be unrelated (I had moved Xcode in the meantime since I didn't expect such a fast turnaround  :wink:). I know Xcode is sensitive to this, will reboot and report back :+1:

OK, other error was unrelated, this is fixed, thanks! :tada:


docs(v2): add social-embed to showcase

Loving the project.
Motivation
Add https://social-embed.git-pull.com to the v2 showcase
Have you read the Contributing Guidelines on pull requests?
Yes, and the header of src/data/user.js

thanks ;)


[sfml] Build error on x64-linux

Copy issue body from /home/mcw/vcpkg/installed/vcpkg/issue_body.mdThese can be installed on Ubuntu systems via apt-get install libx11-dev libxrandr-dev libxcursor-dev libxi-dev libudev-dev libgl1-mesa-dev
-- Found external ninja('1.11.1').
-- Configuring x64-linux
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
Command failed: /usr/local/bin/ninja -v
Working Directory: /home/mcw/vcpkg/buildtrees/sfml/x64-linux-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
/home/mcw/vcpkg/buildtrees/sfml/config-x64-linux-dbg-CMakeCache.txt.log
/home/mcw/vcpkg/buildtrees/sfml/config-x64-linux-rel-CMakeCache.txt.log
/home/mcw/vcpkg/buildtrees/sfml/config-x64-linux-out.log
Call Stack (most recent call first):
installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:252 (vcpkg_execute_required_process)
ports/sfml/portfile.cmake:17 (vcpkg_cmake_configure)
scripts/ports.cmake:175 (include)
error: building sfml:x64-linux failed with: BUILD_FAILED
Elapsed time to handle sfml:x64-linux: 1.6 s
Please ensure you're using the latest port files with git pull and vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+sfml
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[sfml]+Build+error+on+x64-linux&body=Copy+issue+body+from+%2Fhome%2Fmcw%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md

Please see #30604 for how to report an issue.
Please provide the error log /home/mcw/vcpkg/buildtrees/sfml/config-x64-linux-out.log.

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


Compatibility with Narrator Tools Toolbar Button

Narrator Tools (https://github.com/elizeuangelo/fvtt-module-narrator-tools/) has a weird use of toolbar button. It applies switch logic to a button in the primary toolbar which is not done by any other mod, and therefore it isn't supported by Dorako UI. Thus, the button appears weird when turned off and turned on:
When turned off, the button appears without any border

When turned on, the button appears as a normal button that isn't turned on

The proper logic would be to apply the classes for switches to it, and ensure in turned off state it looks like a normal button.

Didn't even see this issue, but fix'd in next release.
Do you know whether this used to work? I could have sworn I've fixed this before.

Sorry, I don't remember seeing it fixed in the past.


Fix/wait init migrations lack env var

Description
Fixes FL-1589
How has this been tested?

Checklist

[ ] changelog was updated with notable changes
[ ] documentation was updated

/e2e --tests sdk,substrafl

End to end tests: :hourglass_flowing_sand: STARTING

/e2e --tests sdk,substrafl,documentation

End to end tests: :hourglass_flowing_sand: STARTING

CI running there: https://github.com/owkin/substra-ci/actions/runs/9447284050/job/26018770683


Piping, new attributes, new events, and more

A big mix of stuff I've added. Kept telling myself that it was suited for one big PR but uhh this PR is a bit of a mess. Sorry for anyone who's reading it. You can see more thorough explanations of piping and new attributes on my fork's wiki, but this PR summarizes it pretty well.
Before you ask, I've tested this with plugins that are for 3.2.2 or below and they have worked without error. Nobody's reported anything in tester discussions so I would assume no one's had issues.
Pipes

Added piping: allows plugins to integrate in an intuitive manner with support for enabled/disabled plugins. Recommended to see example plugin for use.

Added attributes Pipe.... These refer to 'exported' members (including PipeEvent as it 'exports its subscription' to the event).
Added attribute PipeLink. This is what allows plugins to import other members. PipeLink members will be null if the export is not found and can be set null mid-round if a plugin is disabled.
Added Plugin.Pipes. Allows for plugins to get pipe exports at run-time instead of using attributes.

Lang

Added support for comments using # at the start of the line.
Changed separation from = (spaces are around the = as well) to : (no whitespace around it)
Changed new values to be added as lower_snake_case (this and the changes above are to make it more like a normal config file)
Added whitespace support for the key (it gets trimmed off), but value's whitespace will not be trimmed unless it is at the start.
Added support for the separator character to be in the value of the entry.

Configs

Cleaned and optimized GetConfig...  methods.
Added ConfigOption attribute. Fields of any accessibility, readonly or not, can use it. It automatically creates an UPPER_SNAKE_CASE key from the variable. It will get the value of the field before Register() and register that key and value as a config option, with the prefix from the new configPrefix. If you want to override the prefix and key, you can specify it in the constructor. This config will automatically be refreshed before WaitingForPlayersEvent, unless the plugin is disabled in which is resets the config back to default.
Obsoleted and replaced current ConfigSetting constructors since SettingType was not needed (if you need the config type just use Default.GetType() 🤷♂). SettingType has not been removed so plugins do not die.
Added LiveConfig<T> (and base class LiveConfig). These are used the same as fields with the ConfigOption attribute on them, but the type is a LiveConfig<T> in which T is the type of your config value. These are read at run time, and as such should only be used for randomized values.

Plugins

Added more properties as a shortcut to managers and replaced preexisting usage of long names with these shortcuts.
Obsoleted camelCase readonly fields that conflicted with preexisting PascalCase properties.

General Attributes

Added string configPrefix and string langFile to PluginDetails
Added LangOption attribute. Does the same exact thing as ConfigOption but for translations instead. There is currently no support for refreshing the lang files so they will be the same the whole time the server is up.

Enabling/disabling/registering

Changed run behavior of Register() and OnEnable(). Previously Register() ran right before OnEnable() when a plugin was being enabled, serving no functional difference. Now, Register() runs after a plugin has been instantiated and has been registered with core features (configs, langs, etc). OnEnable() runs after all plugins have been loaded or when a plugin is manually enabled/disabled.
Fixed exception logging when a plugin was being loaded. Since the config file was not loaded, running Logger.Debug always didn't print because getting sm_debug always returned false. Now exceptions when a plugin are loading use Logger.Error. Also provided exception type name in the log.
Fixed enable/disabling plugins so they wont break when re-enabled
Added a ton of debug logs to enabling/disabling plugins just in case (probs should remove this in the future if stuff isn't broken).
Added snapshots to core features, any configs, langs, or commands registered in Register() are saved and re-enabled when the plugin is re-enabled. Anything registered to those core features our of Register() is trashed upon disabling.
Fixed PluginManager.GetDisabledPlugin. Now it will actually search disabled plugins instead of enabled.
Fixed PluginManager.EnablePlugin and PluginManager.DisablePlugin. They will now update the dictionaries properly so a plugin is not in a state of forever enabled/disabled since it was disabled manually instead of as a batch.
Fixed command PluginManager command pm. Now it will actually get disabled plugins to enable instead of already enabled plugins.

Events

Added WarheadChangeLeverEvent: fires when the lever in nuke silo gets flipped. Can be denied using bool Allow.
Added WarheadKeycardAccessEvent: fires when a player attempts to lift the cover off of the nuke terminal on surface using a CONT_LVL_3 keycard (clientside check 😢). Can be denied using bool Allow.

Misc

Bumped version to 3.3.1 A. Not sure if it should've been 3.3.0 B but I guess I'll hear if it should have.
Added GetComponent(), GetGameObject(), or GetClass() (TeamRole) to more API objects.
Added method Server.GetAppFolder. Just a wrapper for FileManager.GetAppFolder in game.
Updated example plugin with new piping and attributes
Obsoleted Server.Verified and Server.Visible. Previously they just had comments saying they were obsolete, now new plugins cannot compile using them and existing plugins will not break still.
Obsoleted PluginManager methods FindPlugins, FindEnabledPlugins, and FindDisabledPlugins in favor of GetEnabledPlugins, GetDisabledPlugins, and GetMatchingPlugins. Besides FindDisabledPlugins being broken, it searched for any plugin with an author or name containing the argument. This could be problematic if an author has another author's name but with something extra on it, like "devbuddy" and "devbuddy's competitor". Both of their plugins in this scenario would be selected. The new methods search exactly (except for description, which allows for 1/3 of the description) and have support for flaggable enums, meaning it can search by (nearly) any detail of a plugin or multiple if flagged.

Wouldn't be surprised if you want me to revert some of these changes, but hopefully most of these are for good. Just thought I would propose some possibly controversial changes that I believe would improve Smod instead of not saying anything at all.

Fixed indentation and other issues.


finnish translation updated. added otherRequiredError text to localiz…

finnish translation updated. added otherRequiredError text to localization

I have missed the text in "question_baseselect.ts" indeed!
Thank you!


CronJob minimum resource allocations

Issue Ref: Fixes https://github.com/kubeless/cronjob-trigger/issues/4
Description:
Adding the minimum resource as below to pass through the quota restrictions of the namespace for the trigger pod initialization. Background provided in the following issues:

https://github.com/kubeless/cronjob-trigger/issues/4
https://github.com/kubeless/kubeless/issues/960

+ 	Resources: v1.ResourceRequirements{
+		Limits: v1.ResourceList{
+			v1.ResourceMemory: resource.MustParse("32Ki"),
+			v1.ResourceCPU:    resource.MustParse("1m"),
+		},
+		Requests: v1.ResourceList{
+			v1.ResourceMemory: resource.MustParse("32Ki"),
+			v1.ResourceCPU:    resource.MustParse("1m"),
+		},
+	},

TODOs:

[X] Ready to review
[ ] Automated Tests
[ ] Docs

/assign @andresmgot

Hi @gkarthiks, thanks for the PR!
Do you mind to rebase master to fix the issue with the CI?
Also, how did you choose the values for the memory and CPU? Does it work properly for you? (1m for CPU seems a bit low)

@andresmgot  yeah, so this trigger pods functionality is nothing but to just execute a curl command I chose that minimal value.
On OpenShift with my observations, this trigger pod doesn't even utilize 1m core of cpu and 32Ki of memory. But if you suggest any other number I will update that.

Hi @andresmgot, changed the memory as requested.


Hebrew translation (100% complete)

This Translation is about #224.
files translated:

[x] def/he/about.cson
[x] def/he/context.cson
[x] def/he/menu_darwin.cson
[x] def/he/menu_linux.cson
[x] def/he/menu_win32.cson
[x] def/he/settings.cson
[x] def/he/welcome.cson

validation

[ ] I've validated my translation locally by running

npm run validation -- --locale MY_LOCALE

For some reason, every time I have tried to run the npm run validation command I got the same error, for a couple of files. This error message keeps appearing for almost every line in my translated files. How can I fix this error message?
AssertionError:   invalid or missing hotkey hint in XXX (every time for a different 'hotkey hint')


global.Date is undefined when using the npm package in a browser environment

When requiring the npm package 'asmcrypto.js' from a browser environment using a bundle (fusebox more specifically) global.Date is not available and therefore global.Date.now fails.
The same code runs without issues on 0.0.11.

Also the new version seems to polyfill window.crypto on the browser, making the native window.crypto.subtle.digest unavailable on chrome.

Fixed with 0.16.0


Fix build with Qt6

I need to check what parts needs conditional compiling for older qt.

I am sorry, I was so happy that it finally with Qt 6 that I forgot to make sure that it works also with previous version. I will fix that soon.


Heya

Im following the development of the plugin since you created the repo.
When we are going to see documentation and what are the future plans for it as i can see you are actively developing this one

Currently I'm in the process of testing the plugin, so the documentation (ConVars and commands namely) will be provided as soon as I feel we reached a stable state. I'll probably deleting all the releases and restart at v1 as I did with Inventory Simulator at that point.
Currently it's pretty usable for scrims, but I'm still testing the match system, and will be reworking some logic now that the core is working well.


[Feature Request] Add option to launch settings page for app

From @jamesmontemagno on May 27, 2016 17:43
This is a

[x] Feature Request

Which plugin does this impact:

[x] Settings

Request
Would be nice to have 1 cross platform call to launch the settings page for the different platforms. iOS can launch into the app specifically, and Android is an intent.
Copied from original issue: jamesmontemagno/Xamarin.Plugins#317

:+1: This would be great!!

I actually include this into: https://github.com/jamesmontemagno/PermissionsPlugin
So I will probably close this for now. Could be worth adding in the future though.

What's the motivation to have the appsettings open on a permission plugin instead of settings plugin?
sounds strange at least, in my current app, I don't use/need a permission plugin but I do use the settings plugin and do open the system settings app.

I'll put it in v 3 :)

thank you :)

Any info if there is a UWP way to do it... figure I would ask before I research.

Implemented in 3.1.0-beta


301 Moved Permanently

so i'm getting 301 Moved Permanently when i attempt to use the following code:
import cloudscraper
scraper = cloudscraper.create_scraper()  # returns a CloudScraper instance
print(scraper.get("http://javlibrary.com").content)

Thanks for the heads up, I added a 302 fix in the dev branch the other day, as Cloudflare recently changed their challenge / solve procedure... I will add in 301 fix into the dev branch right now

you're awesome!

Commited 687713700f35936b18c2fff485cc98390a7a7f5a in dev branch, which will resolve this issue.


[v1.1][ISSUE-254]update config for sda

What changes were proposed in this pull request?
change argument name
Why are the changes needed?
be make the config name more explainable
How was this patch tested?
using existing SDA UT

@zigzagcai @Jian-Zhang , please help to review, this PR will rename sigopt_config to hpo_config

LGTM


Update for new glib::Value::get signature

... in consequence of gtk-rs/glib#513
For the Result<_, _>::expect behaviour, please see the following discussion: https://github.com/gtk-rs/gir/pull/825#pullrequestreview-272474063. TLDR: the argument for expect should refer to the context (or the reason why it shouldn't panic), the error will be automatically added in the panic message (using the Debug trait unfortunately).
For the method names, please see: https://github.com/gtk-rs/glib/pull/513#pullrequestreview-271892055 and then https://github.com/gtk-rs/glib/pull/513#issuecomment-519547950. TLDR: get allows writing generic code, get_some is the best name we could think of to get the actual value for a non-optional Type without the need to unwrap an Ok output of get.

Please, repase it to pending branch and Edit PR

@fengalin Thanks

\o/

@GuillaumeGomez looks all good now :)

Indeed! Thanks @fengalin !


[Node 4.x] Update the packager's version check message for Node 4.0

Users should use Node 4.0 instead of io.js. This isn't a hard requirement since io.js still works but it's simpler if everyone is on the latest version.
Test Plan: Launch the packager while running io.js 3.3.0 and get the update message.

@facebook-github-bot shipit


Use a more recent version of Ubuntu as the Linux runner

This PR updates the defaults so that it uses the latest LTS version of Ubuntu 24.04, instead of 20.04 which will be EOL'd next year.

We definitely can't bump up to 24.04 -- we need to be using the oldest possible to ensure people's linux builds run as many machines as possible, per this recent blog post:
https://blog.axo.dev/2024/08/glibc
I am monitoring the 20.04 situation. It will only start its deprecation process when 24.04 becomes the default ("latest") ubuntu runner, but it's still in beta (aiui due to some compat issues they're still hammering out).
When 20.04 is marked as deprecated we'll bump the default runner to 22.04.
If, for whatever reason, you need to Not be on 20.04 Right Now, you can use the custom runner feature.

@Gankra thanks for the explanation, makes total sense to keep with the oldest available Ubuntu distro.


summary plots of my landings (kg and value) per month and a summary for the year

As a fisherman, the types of 'outputs' that would be useful include summary plots of my landings (kg and value) per month and a summary for the year, so that I can quickly see which was the 'biggest month' in terms of landings.https://github.com/StAResComp/sifids/issues/6, https://github.com/StAResComp/sifids/issues/7

Should


Add missing functionallity

Fixes #4
This PR tries to implement the missing functionality in this library to enable the CLI to fully work as intended.
Edit: Updates for the status of the PR will be done in the issue. The TODO list there gives us a better method of measuring the progress.

The missing functionality is there but it breaks the test cases. The reason why this is still in draft mode is the following observation: https://github.com/cobbler/cobblerclient/issues/4#issuecomment-1402503157
For ideas and discussion please use the issue.

After https://github.com/cobbler/cobbler/pull/3293 was merged. This PR will get attention again.

This PR is a lost cause IMHO. I never got it working and as such it is useless. It will be superseded by a new one that I got working.


Warning: preg_match(): Unknown modifier '/' in SetCookie.php on line 352

Hi! I've got some Error using a simple Request
$values["region"]` = "12345_DE";
$cookieJar = CookieJar::fromArray(
    $values,
    "https://www.allyouneedfresh.de"
);

$client = new \GuzzleHttp\Client(['cookies' => $cookieJar]);
$response = $client->get(
    "https://www.allyouneedfresh.de"
);

This results in
Warning: preg_match(): Unknown modifier '/'
() at /home/alex/foodle/vendor/guzzlehttp/guzzle/src/Cookie/SetCookie.php:352
 GuzzleHttp\Cookie\SetCookie->matchesDomain() at /home/foodle/vendor/guzzlehttp/guzzle/src/Cookie/CookieJar.php:234
...

The Error is thrown for every URL i tried.  Any Suggestions? Did I miss something?
Thank you!

The cookie jar domain must be without the schema part, so:
$cookieJar = CookieJar::fromArray(
    $values,
    "www.allyouneedfresh.de"
);

Thank you for that!


Support new interview events and add logic to track interview stage

Follows https://github.com/zwave-js/zwave-js-server/pull/181

It occurs to me that there is an interviewStage parameter that gets sent to us in the node state dump. Right now we store the enum value, but per conversation with Al, we shouldn't rely on the enum value (int) to be stable. So perhaps the best way to do this is to provide the enum name as interviewStage instead and then update that when we handle these events.
But if we want to do that, we will have to introduce a new schema which may not be worth it for this single change. Thoughts?

We shouldn't rely on things that aren't stable in zwave-js. That will break sooner or later. I think a schema bump is ok, but we can wait with the bump until closer to the next Core release and maybe more things will have changed requiring a new schema by then.

We shouldn't rely on things that aren't stable in zwave-js. That will break sooner or later. I think a schema bump is ok, but we can wait with the bump until closer to the next Core release and maybe more things will have changed requiring a new schema by then.

The approach of waiting is fine, but with the current approach, nothing would break because we aren't using interviewStage in this logic, we're storing the name of the stage as a string so if the stage names or enums change, it doesn't affect the logic.

Won't potential breakage depend on how we depend on the stageName string?

I don't think we should introduce any dependencies on the stageName string. interview started and interview completed will affect the ready flag which is what we should rely on. The is_being_interviewed property I added is dependent on the ready property and a status that is internally set when an interview fails, and is thus safe to use.
The only utility of the stageName string IMO is to display the stage in the UI for the user to track the progress.

Yeah. It's important that we make sure the GUI doesn't introduce any dependencies on this string then. Eg translation or extra description.

upstream has been merged so this is ready for review

are you aware of any outstanding issues with schema 3? The next release for zwave-js-server will add schema 4 support, so I think this is safe to merge unless you foresee any hotfixes needed for our current iteration of the integration.
Separately, I am wondering if we should consider maintaining branches as we switch schemas, so that we can move forward with developing for new schemas but maintain a path to release hot fixes for old ones


Cannot exclude subfolder

What version of Sass Lint are you using?
1.12.1
Please include any relevant parts of your configuration
files:
  include: 'src/stylesheets/**/*.s+(a|c)ss'
  ignore:
    - 'src/stylesheets/vendor/**/*.s+(a|c)ss'

What did you do? Please include the actual source code causing the issue.
Trying to exclude vendors folder.
What did you expect to happen?
Only subfolder Vendor folder to be ignored.
What actually happened? Please include any error messages given to you by Sass Lint.
No output. No error messages.
If you're using a IDE plugin have you tried the CLI too?

Hi :)
Thanks for using sass-lint, i tried to reproduce your error, didn't succeed :/ Can you show me the command you're tryin to execute ?
Cheerz


"points race" mode is not selecting the winner correctly? (5.1.2-pre1)

(5.1.2-pre1 on 1.20.4)
Twice during Phedran's stream today we used the "points race" mode, and both times it announced the wrong winner?

And for completeness, it was 3 teams of 1 player each.

Game today with 5 teams of 1 player each.
Second place was announced as the winner.
I wonder if this is an off-by-1 error, like referencing [1] instead of [0] somewhere.

Second game got it right lol

Yeah, im pretty sure it's arbitrary. https://github.com/NeunEinser/bingo/blob/dd43f89cdf21a2a3482a8de952b799e0b5dfeea5/datapack/data/fetchr/functions/item_detection/goals/points/find_winners.mcfunction iterates over a temporary copy of the teams array, but in the calling function that temporary array is never actually copied/created.
So, I think it just grabs some garbage data from whatever team happens to have been operated on last, maybe it's the last team that got an item, or something.
I haven't had time to check if this fixes it, and it doesn't happen in singleplayer, but I think I might have ways to reproduce it still.

Will test and provide feedback, pending next hosted multiplayer session with Phedran and her patrons.

Three more rounds tonight with Phedran's patrons. Correct winner(s) selected every time. I consider this fixed.


feat: sidebar dropdown toggle with subpages #1427

I've fixed the drop down issue with sub-pages in documentation (closes #1427).
This changes improves the user experience when user tries to navigate quickly. Currently, the user has to scroll all the way down.
I have used React state to handle the toggle based on the activePaths. The demo is attached below.

@ashiishme I've deployed it here https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/install.
Something funny is happening with the active state:

that what I've managed to do after clicking around

@ashiishme I've deployed it here https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/install.
Something funny is happening with the active state:

that what I've managed to do after clicking around

Or like this:

Or like this:

Also, a few other concerns:

Looks like now sections stay in the expanded mode when I jump between them
May be it's fine, but we need to have a click on the arrow support I think, that doesn't take you to the page, but only collapeses/expands the section. We should make them active on hover (bigger?)

Also, a few other concerns:

Looks like now sections stay in the expanded mode when I jump between them
May be it's fine, but we need to have a click on the arrow support I think, that doesn't take you to the page, but only collapeses/expands the section. We should make them active on hover (bigger?)

Or like this:

😄 Didn't notice the active style, I should have tested in more detail.

Or like this:

😄 Didn't notice the active style, I should have tested in more detail.

Good attempt! Thanks for the PR, but there are some bugs and some other changes that are needed here.

Thank you, I will fix the bug and update as you have requested.

Good attempt! Thanks for the PR, but there are some bugs and some other changes that are needed here.

Thank you, I will fix the bug and update as you have requested.

Looks like now sections stay in the expanded mode when I jump between them

I think we should collapse the previously expanded section if you click on another one for now. Just having that ability is already an improvement and would also take care of the bug where you click on an open section head, it collapses it, but takes you to that page.

Looks like now sections stay in the expanded mode when I jump between them

I think we should collapse the previously expanded section if you click on another one for now. Just having that ability is already an improvement and would also take care of the bug where you click on an open section head, it collapses it, but takes you to that page.

@jorgeorpinel  @shcheklein
I am able to fix the bug but need your suggestion as well.
Now, I am using the arrow to only collapse the menu, it will not expand it as well as not take user to any page. The expand functionality is as same as it now in production. This fixes the both active style & page jump issue.
But, I am not sure if it is okay when the user is inside the nested page, and rather collapse the parent item, the style will be remove but user remains at the same page. This is the expected behavior if we need to collapse but let me know about your thoughts. You can see the example in video.
https://user-images.githubusercontent.com/18111862/104105723-30cbac80-52d8-11eb-853d-02b131f37834.mp4

@jorgeorpinel  @shcheklein
I am able to fix the bug but need your suggestion as well.
Now, I am using the arrow to only collapse the menu, it will not expand it as well as not take user to any page. The expand functionality is as same as it now in production. This fixes the both active style & page jump issue.
But, I am not sure if it is okay when the user is inside the nested page, and rather collapse the parent item, the style will be remove but user remains at the same page. This is the expected behavior if we need to collapse but let me know about your thoughts. You can see the example in video.
https://user-images.githubusercontent.com/18111862/104105723-30cbac80-52d8-11eb-853d-02b131f37834.mp4

I have increased the size of arrow button by 2px on active. I am using span tag so for accessibility purpose, the outline doesn't look that good and the icon too when it is large. I am not sure what to do with it?

I have increased the size of arrow button by 2px on active. I am using span tag so for accessibility purpose, the outline doesn't look that good and the icon too when it is large. I am not sure what to do with it?

the outline doesn't look that good

yep, look pretty ugly :( - better do some glow effect?
Rearding the dynamics - it's better now. A few improvements that come to my mind:

when you click the expanded section main title we can collapse it
when you click arrow it should serve as collapse/expand - I'm not sure how to combine it with auto-collapse. For now we can collapse everything I think (except the page you open)

the outline doesn't look that good

yep, look pretty ugly :( - better do some glow effect?
Rearding the dynamics - it's better now. A few improvements that come to my mind:

when you click the expanded section main title we can collapse it
when you click arrow it should serve as collapse/expand - I'm not sure how to combine it with auto-collapse. For now we can collapse everything I think (except the page you open)

Agree with Ivan, no need for special arrow behavior (it's kind of unintuitive).

Agree with Ivan, no need for special arrow behavior (it's kind of unintuitive).

but thanks for addressing the previous issues!

but thanks for addressing the previous issues!

when you click the expanded section main title we can collapse it

Same as before right when we click the title adding the toggle effect?

when you click arrow it should serve as collapse/expand - I'm not sure how to combine it with auto-collapse. For now we can collapse everything I think (except the page you open)

It will allow us to expand & collapse from both title or the arrow icon isn't it?

when you click the expanded section main title we can collapse it

Same as before right when we click the title adding the toggle effect?

when you click arrow it should serve as collapse/expand - I'm not sure how to combine it with auto-collapse. For now we can collapse everything I think (except the page you open)

It will allow us to expand & collapse from both title or the arrow icon isn't it?

@shcheklein  I think we might not need arrow toggle as mentioned by @jorgeorpinel  because with the menu title toggle, it feels completely unnecessary.
Now, we can expand / collapse menu item also the previous bugs are addressed.
This is how it works now:
If we are inside the child pages:

Parent
Child ( active )
Child

The user can navigate back to Parent page without collapsing.
If we are in parent page:

Parent ( active )
Child
Child

The user can collapse by clicking the parent menu title.
Please check the video:
https://user-images.githubusercontent.com/18111862/104121308-391df900-5365-11eb-9f1d-911c9fdec6d9.mp4

@shcheklein  I think we might not need arrow toggle as mentioned by @jorgeorpinel  because with the menu title toggle, it feels completely unnecessary.
Now, we can expand / collapse menu item also the previous bugs are addressed.
This is how it works now:
If we are inside the child pages:

Parent
Child ( active )
Child

The user can navigate back to Parent page without collapsing.
If we are in parent page:

Parent ( active )
Child
Child

The user can collapse by clicking the parent menu title.
Please check the video:
https://user-images.githubusercontent.com/18111862/104121308-391df900-5365-11eb-9f1d-911c9fdec6d9.mp4

@ashiishme it looks smooth and great!
I still think that click to arrows to expand/collapse w/o activating the page itself makes sense. E.g. I'm on the https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/user-guide/dvc-internals and I click on the User Guide to collapse it to see other side bar items - no way I can do it now, w/o switching to the page. And I have to click twice actually.

@ashiishme it looks smooth and great!
I still think that click to arrows to expand/collapse w/o activating the page itself makes sense. E.g. I'm on the https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/user-guide/dvc-internals and I click on the User Guide to collapse it to see other side bar items - no way I can do it now, w/o switching to the page. And I have to click twice actually.

@ashiishme it looks smooth and great!
I still think that click to arrows to expand/collapse w/o activating the page itself makes sense. E.g. I'm on the https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/user-guide/dvc-internals and I click on the User Guide to collapse it to see other side bar items - no way I can do it now, w/o switching to the page. And I have to click twice actually.

Yeah, now it make sense to me. I will enable the arrow toggle.

@ashiishme it looks smooth and great!
I still think that click to arrows to expand/collapse w/o activating the page itself makes sense. E.g. I'm on the https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/user-guide/dvc-internals and I click on the User Guide to collapse it to see other side bar items - no way I can do it now, w/o switching to the page. And I have to click twice actually.

Yeah, now it make sense to me. I will enable the arrow toggle.

@shcheklein  @jorgeorpinel I have updated with arrow toggle now.

@shcheklein  @jorgeorpinel I have updated with arrow toggle now.

@ashiishme great! we are getting there!
I see two strange issues right now:

Open https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/api-reference/open. Click arrow to collapse. Arrow doesn't work to expand anymore
Arrows do not work to expand on other (inactive) sections

@ashiishme great! we are getting there!
I see two strange issues right now:

Open https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/api-reference/open. Click arrow to collapse. Arrow doesn't work to expand anymore
Arrows do not work to expand on other (inactive) sections

@ashiishme great! we are getting there!
I see two strange issues right now:

Open https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/api-reference/open. Click arrow to collapse. Arrow doesn't work to expand anymore
Arrows do not work to expand on other (inactive) sections

Looks like the state issue when directly visiting the specific page. Will check this :smile:

@ashiishme great! we are getting there!
I see two strange issues right now:

Open https://dvc-landing-fix-dropdow-hdyck8.herokuapp.com/doc/api-reference/open. Click arrow to collapse. Arrow doesn't work to expand anymore
Arrows do not work to expand on other (inactive) sections

Looks like the state issue when directly visiting the specific page. Will check this :smile:

@shcheklein It seems not possible or maybe I am not able to figure it out to auto collapse with arrow because of the re-render when the path matches the activePaths lists. So, what I did is, when I am on page A and I want to use arrow for collapse / expand, the first click on arrow will work same as the page navigation when clicking on the title which means, the user will be taken to that page, but after that, the arrow will only work to collapse / expand and this seems to work as expected without creating any further issues.
Can you please review now.

@shcheklein It seems not possible or maybe I am not able to figure it out to auto collapse with arrow because of the re-render when the path matches the activePaths lists. So, what I did is, when I am on page A and I want to use arrow for collapse / expand, the first click on arrow will work same as the page navigation when clicking on the title which means, the user will be taken to that page, but after that, the arrow will only work to collapse / expand and this seems to work as expected without creating any further issues.
Can you please review now.

with arrow because of the re-render when the path matches the activePaths lists

but expanding/collapsing on the arrow should not be changing activePath, right?

which means, the user will be taken to that page

it breaks to some extent the "exploration" flow - I'd like to see the pages, may be I don't even want to go the next page, just see the full list.

with arrow because of the re-render when the path matches the activePaths lists

but expanding/collapsing on the arrow should not be changing activePath, right?

which means, the user will be taken to that page

it breaks to some extent the "exploration" flow - I'd like to see the pages, may be I don't even want to go the next page, just see the full list.

but expanding/collapsing on the arrow should not be changing activePath, right?

Yes, it shouldn't as per our discussion and it does work but for the first click, it is necessary to re-render to collapse others. If I am at Page A which is expanded & I want to see the content of Page B. When I click the arrow, it will take me to the page and after that the arrow will just expand & collapse only. The way the sidebar menu is configured, it requires re-render to work well with Collapse component.

it breaks to some extent the "exploration" flow - I'd like to see the pages, may be I don't even want to go the next page, just see the full list.

It does break the exploration flow. I think we have two option now, the one that I have applied recently or the one where user can collapse / expand without visiting the page ( keeps the exploration flow without any issue ) but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).
What do you say?

but expanding/collapsing on the arrow should not be changing activePath, right?

Yes, it shouldn't as per our discussion and it does work but for the first click, it is necessary to re-render to collapse others. If I am at Page A which is expanded & I want to see the content of Page B. When I click the arrow, it will take me to the page and after that the arrow will just expand & collapse only. The way the sidebar menu is configured, it requires re-render to work well with Collapse component.

it breaks to some extent the "exploration" flow - I'd like to see the pages, may be I don't even want to go the next page, just see the full list.

It does break the exploration flow. I think we have two option now, the one that I have applied recently or the one where user can collapse / expand without visiting the page ( keeps the exploration flow without any issue ) but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).
What do you say?

@ashiishme

but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).

could you clarify, not sure I understand exactly.

it is necessary to re-render to collapse others.

I'm not sure I understand why do we have to re-render anything to collapse/expand anything.

@ashiishme

but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).

could you clarify, not sure I understand exactly.

it is necessary to re-render to collapse others.

I'm not sure I understand why do we have to re-render anything to collapse/expand anything.

could you clarify, not sure I understand exactly.

When I expand dropdown 1 and use arrow button to expand another dropdown, the dropdown 1 will be in expand state together with another dropdown. It will only collapse / expand when the same arrow button is toggle by user. Currenlty with the pages title click, when I am at page 1 which is expanded, and I click on page 2 title, the page 1 auto collapse and the page 2 is expand. Let me know if you understand it now, or I will attach a demo today evening if you like.

I'm not sure I understand why do we have to re-render anything to collapse/expand anything.

The child components wrapped by Collapse component renders based on the activePath isn't it? So, to collapse or expand we will need to render again into view or remove it again from the view.

could you clarify, not sure I understand exactly.

When I expand dropdown 1 and use arrow button to expand another dropdown, the dropdown 1 will be in expand state together with another dropdown. It will only collapse / expand when the same arrow button is toggle by user. Currenlty with the pages title click, when I am at page 1 which is expanded, and I click on page 2 title, the page 1 auto collapse and the page 2 is expand. Let me know if you understand it now, or I will attach a demo today evening if you like.

I'm not sure I understand why do we have to re-render anything to collapse/expand anything.

The child components wrapped by Collapse component renders based on the activePath isn't it? So, to collapse or expand we will need to render again into view or remove it again from the view.

@ashiishme

The child components wrapped by Collapse component renders based on the activePath isn't it?

it might be, I don't know. From the product perspective I don't see why would re-render is needed. If changes to the way components are done needed - so be it, right? Or is there some fundamental reason?
What I'm trying here is to clarify/specify the best behavior from the end user perspective first. Then think how can it be implemented.

the one where user can collapse / expand without visiting the page ( keeps the exploration flow without any issue ) but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).
Let me know if you understand it now, or I will attach a demo today evening if you like.

Still not sure exactly. Demo would be helpful :)

@ashiishme

The child components wrapped by Collapse component renders based on the activePath isn't it?

it might be, I don't know. From the product perspective I don't see why would re-render is needed. If changes to the way components are done needed - so be it, right? Or is there some fundamental reason?
What I'm trying here is to clarify/specify the best behavior from the end user perspective first. Then think how can it be implemented.

the one where user can collapse / expand without visiting the page ( keeps the exploration flow without any issue ) but it will not collapse other when using arrow button. Only toggles when user interacts ( no auto collapse ).
Let me know if you understand it now, or I will attach a demo today evening if you like.

Still not sure exactly. Demo would be helpful :)

@rogermparent it looks good to from the product perspective, could you review the PR from the JS/TS perspective, please?

@rogermparent it looks good to from the product perspective, could you review the PR from the JS/TS perspective, please?

A few things I noticed playing around with this:

sometimes mouse pointer goes a bit below the arrow symbol and it trigger the page to be activated
i think since arrows now can be clicked we should highlight them on hover - so that users understand that they can be clicked

A few things I noticed playing around with this:

sometimes mouse pointer goes a bit below the arrow symbol and it trigger the page to be activated
i think since arrows now can be clicked we should highlight them on hover - so that users understand that they can be clicked

sometimes mouse pointer goes a bit below the arrow symbol and it trigger the page to be activated

The click listener for arrow depends on the span inside anchor tag so, outside the arrow will trigger the click of anchor tag. This also creates the accessibility issue because a click listener inside anchor tag. I will try to find a better way to cover both issues after reviewed by Roger.

i think since arrows now can be clicked we should highlight them on hover - so that users understand that they can be clicked

Sure, will do this.

sometimes mouse pointer goes a bit below the arrow symbol and it trigger the page to be activated

The click listener for arrow depends on the span inside anchor tag so, outside the arrow will trigger the click of anchor tag. This also creates the accessibility issue because a click listener inside anchor tag. I will try to find a better way to cover both issues after reviewed by Roger.

i think since arrows now can be clicked we should highlight them on hover - so that users understand that they can be clicked

Sure, will do this.

@ashiishme hey, sorry for the delay here! What is the status now for this PR?

Closing this as stale. @ashiishme please, feel free to get back to it and finalize when/if you have time. Thanks 🙏

@shcheklein Hi Ivan, I have made some changes based on Roger's review, can you please reopen this PR?

Just on first view I can see you totally addressed the feedback! I'll pull this down to make sure it runs well as well.

It got deployed, I still see a few issue:

when section that has an index page (e.g. User Guide) is opened, one of the pages inside I can't open the index page anymore. Open https://dvc-org-fix-dropdown-to-qdss4m.herokuapp.com/doc/user-guide/dvc-internals -> click User Guide
chanegelog icon (dot) disappeared in the main menu
we still need to add now some effect on hover on the arrows so that people understand there is some functionality to them

Some small nitpicks alongside what @shcheklein already pointed out:
Both arrow animations and slide-out don't work on the way back.
I think this one can be fixed by simply tweaking the CSS animation transition rules.
The "slide-out" animation stops working both ways after the first expansion.
This issue looks a little different from the former, as it seems to involve the state

It got deployed, I still see a few issue:

when section that has an index page (e.g. User Guide) is opened, one of the pages inside I can't open the index page anymore. Open https://dvc-org-fix-dropdown-to-qdss4m.herokuapp.com/doc/user-guide/dvc-internals -> click User Guide
chanegelog icon (dot) disappeared in the main menu
we still need to add now some effect on hover on the arrows so that people understand there is some functionality to them

@rogermparent  I have checked why the the index page doesn't open after visiting it's child ( point 1 of Ivan's review), I found out that after replacing the current page condition with isActive it doesn't seems to work. I am not sure why because we need the condition to be true and isActive does returns true but the menu is being collapsed. So, I have reverted it with the old condition the solves the point 1.

@shcheklein  I have addressed all the issues mentioned by you. I have added scale to the icon when hover. What do you say?
Also, should I fix the animation in this PR or address it on new issue?

@ashiishme no, not a blocker for sure, thank you! LGTM, I will let @rogermparent do the final review and merge.


Passing props to steps

I am incorporating your library in a project I'm doing. In this project I am converting a one-pager for into a multi-step form. The <MultiStep /> component is rendered by another component which should pass props to the slides. I tried to pass it through <MultiStep steps={steps} user={user} /> but user didn't pass to the steps.
I couldn't find a documentation that explains how to do it.
Would appreciate your help on this subject :)

i implement steps data in state
incase new props coming or change use componentWillReceiveProps instead

Thanks :)
On Sun, Dec 15, 2019, 08:34 Angga Andrean<EMAIL_ADDRESS>wrote:

i implement steps data in state
incase new props coming or change use componentWillReceiveProps instead
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/srdjan/react-multistep/issues/55?email_source=notifications&email_token=AJ72X2T6YHBUWSUHGG2XXEDQYXFYLA5CNFSM4JV3D7Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4SQHA#issuecomment-565782556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ72X2TDZK64XVMFZNVK4ELQYXFYLANCNFSM4JV3D7ZQ
.

thanks @anggaand123 !


Add flowconfig to SampleApp

Added .flowconfig template (and a test for it!)
Test Plan:
$ ./scripts/e2e-test.sh

@bhosmer - does .flowconfig look good?

@frantic LGTM - passes w/0 errors, right?

On Flow's side would it be possible to transitively include .flowconfigs of [include]'d directories and require()'d npm packages? It would let projects customize their .flowconfig files while keeping an up-to-date reference to React Native's .flowconfig and other projects' .flowconfig files if Flow gains more adoption. I opened an issue over at https://github.com/facebook/flow/issues/308 if that's a better place to make progress.

@ide James, note that such an include wouldn't come in handy here - the project has its own copy of everything, it's not reaching back to the original React Native dir. That said, we've talked about some sort of include feature, but it would be more a way to include raw content than a deep "subproject" sort of feature, at least for now. Will update 308 with any progress.

the project has its own copy of everything
Yeah. It would be nice if individual projects could each import one React Native .flowconfig into each of their own .flowconfig files.


Port bug fix for GVCF block merging.

See https://github.com/broadinstitute/gsa-unstable/pull/1431.

Also see broadinstitute/gsa-unstable#1440.

@lbergelson were these fixes ported?

@samuelklee I don't think so, not by me at least.

@samuelklee Would you like me to do the port? It will require both gatk and gatk-protected changes.

If you don't mind, @ronlevine---I probably won't get around to it for a bit.  Not high priority though, I was just going through and cleaning up issues.

Will do.

Closing since https://github.com/broadinstitute/gatk/pull/2619 is merged.

Reopening since need to do the protected part.

Also note that https://github.com/broadinstitute/gsa-unstable/pull/1451 should be included in this port.

The HaplotypeCaller tests that compare the output GVCFs between the current code and GATK 3.5 will not pass. This is due the block merging fix. So, I generated output files with with a version of GATK 3 that has this fix, 3.7-42-gbe6a37c. If it's premature for these tests, I can disable them.

Please don't either disable these tests or move them to GATK 3.7 outputs just yet -- this would be disruptive to my current efforts to figure out what's behind some annotation differences in the GATK4 HaplotypeCaller. I do plan to migrate the tests to 3.7 outputs soon, but I need to study the diffs a bit first.

Issue moved to broadinstitute/gatk #2870 via ZenHub


Add iPhone SE, 7 and 7 Plus simulator support

Added iPhone SE, 7 and 7 Plus in the list of enabled simulators

Thanks @MariusCiocanel!


Remove github.com requirement

Currently, there is a GitHub SDK within the code. If there is no .sail/Dockerfile, the base codercom/ubuntu-dev image should be used.

/cc @nathanpotter @ammario
What are your thoughts on this?
Re: #196

I think it'd be better to just verify that the repo host is github before making the call to the API

will throw together a PR tomorrow.

This might be tricky since you'll have to parse the .git folder in the project for the host

Can't we just add a regex for github.com?

I think that sets a bad precedent if we want to add logic based on the host

I think this will actually be kind of tricky now that you bring it up.

I think a good first step would be to see how janky extracting the host from the .git folder would be

wouldn't we be able to just run:
git remote -v

This would display all of the hosts, we could split by \n, then use the endpoints there?

.git/config is where git stores all of the remotes in a format that seems ini-ish:
...
[remote "origin"]
        url = git@github.com:cdr/sail.git
        fetch = +refs/heads/*:refs/remotes/origin/*
...

I think it'd be much easier to just parse the output of git directly as roberthmiller pointed out, as if they're working with Git in the first place it's very likely that they have git installed on their system.

We could always check (although, a prerequisite to sail is git)

git remote -v sounds good to me
On Fri, May 24, 2019 at 6:11 AM Robert M<EMAIL_ADDRESS>wrote:

We could always check (although, a prerequisite to sail is git)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/cdr/sail/issues/197?email_source=notifications&email_token=ABQJ7BY3UFHBCLLOPZZR363PW7EONA5CNFSM4HPKE6K2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWE62OY#issuecomment-495578427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQJ7BZOFBRIQQQ2AYVHIRDPW7EONANCNFSM4HPKE6KQ
.

So, what do you think that the solution should be? Should we have a regex for the remotes? If there is a GitHub* remote, we should use it. Is that an ideal solution? Although, this solution is not very good since you can have a remote that looks like git:cdr/sail and it would be aliased as github.com in the ssh config. What are your thoughts on this?

I think just parse the output of git remote -v if git is exists, and if it has a URL beginning with https://github.com/ or<EMAIL_ADDRESS>then try to get the language from GitHub. If people have aliased GitHub to something else it won't work, but I don't think many people do that anyways.

ok, I will put together a PR together when I get sail to work on my mac (since I am away from my desktop).

hi . I have two site but cant com up in دانلود آهنگ جدید . please help . sites are faazmusic.com And ahangejadid.com

@kami1019 Not sure what your problem is... Can you elaborate a little bit?


Add min_temp and max_temp to MQTT climate device

Description:
min_temp and max_temp now work with the MQTT climate device.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#5455
Example entry for configuration.yaml (if applicable):
climate:
  - platform: mqtt
    name: Study
    min_temp: 40
    max_temp: 90
    current_temperature_topic: /sensors/hvac_study/current_temp
    temperature_command_topic: /sensors/hvac_study/target_temp

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

I wish I could say it was my cleverness, but I was simply doing some copypasta from the generic thermostat class. Any suggestions are welcome.

Perhaps let's open a separate ticket/PR and fix the superclass issue (and refactor subclasses) in that?

@dgomes Perhaps something like this?

Would replace the super().min_temp with the imported DEFAULT_MIN_HUMITIDY.
This would make things more explicit

Cool; I'll take a crack at it once this one gets merged.

I see things the other way round.
The other PR should come first, then you rebase this one according to the changes, then this gets approved.

OK, see #14721


fix(list): memoize-one build

memoize-one cannot be resolved because of how it exports it's files. This lead to unit test failures. Also when running npm run build, the clean step would delete the memoize-one/dist/ directory, resulting in a build failure.

Codecov Report

Merging #833 into rc0.12.0 will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           rc0.12.0     #833   +/-   ##
=========================================
  Coverage     94.47%   94.47%
=========================================
  Files            81       81
  Lines          3475     3475
  Branches        532      532
=========================================
  Hits           3283     3283
  Misses           66       66
  Partials        126      126

Impacted Files
Coverage Δ

packages/list/index.tsx
94.82% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c5233...b3b13c1. Read the comment docs.


Clarify encoding of ints in spec

MessagePack has some ambiguity in encoding numbers, so clarify
that the version numbers and mode should be encoded as positive fixnums.
Also add test.

Coverage remained the same at 84.502% when pulling 9ba6280d6dc329a9668f8b46756bee4616439f7a on akalin/spec-int into 282df2166aa71f1283de12d39a10addbb30bafb4 on master.

Coverage remained the same at 84.502% when pulling 9ba6280d6dc329a9668f8b46756bee4616439f7a on akalin/spec-int into 282df2166aa71f1283de12d39a10addbb30bafb4 on master.

You might also say that all encodings must use the minimal number of bytes. This might be more general.  For instance isn’t it allowed to encode a one element array in several ways? Of course the smallest representation is the one we expect.

Ah, you're right! Let me rework this PR, then...

Okay, added some wording re. encoding strings, byte arrays, and arrays. Turns out we still have to specify int encodings, though -- in general, there are multiply ways to encode some ints minimally, so we have to at least clarify that the ints we have are small enough to fit in 1 byte.


Support multiple project folders

Tries to open a gulpfile from the first project folder only and fails if its not found. I swapped around the folders and it worked.
Can we support multiple gulpfile(s), one per project folder? The task list display could either show task names prefixed with the project folder name, or have sections per project folder.

+1
I have a similar issue. I have a gulpfile at the root of my project which is correctly found and works as expected. However, I also have a gulpfile in a deeper sub folder which is not exposed through the gulp control package because gulp control stops at the one at the root of my project.

+1
I added more than one project folders to Atom and it only finds / uses the first one.

:+1:


Enable linters

Update all the linters
Update golang version
Various issues and bugs related to what was found by linters
It'd be great to enable linters in CI by default

Would like to remove some imports used as constants2 "github.com/xxx" , tendermint2 "github.com/xx"

will do.

Could someone recheck tests locally? I strongly believe I still have yet stable tests in the master branch.

Would like to remove some imports used as constants2 "github.com/xxx" , tendermint2 "github.com/xx"

Done

@avkr003 @puneet2019 Could you check code starting commit c378f73
I removed global DB, separated unit tests, make them run in parallel, enable units and binary build in CI. And it's all "green" :) At least so far.

good to go from my side, only wanted to make sure the database is passed top-down when removing global DB, and no other part of the orchestrator is trying to initialize it again.

@avkr003 @puneet2019 Could you check code starting commit c378f73
I removed global DB, separated unit tests, make them run in parallel, enable units and binary build in CI. And it's all "green" :) At least so far.

good to go from my side, only wanted to make sure the database is passed top-down when removing global DB, and no other part of the orchestrator is trying to initialize it again.

The first part is solvable with tests, the second with sync.Once.


Have a component wait for rehydration from localstorage to complete?

Hi there,
I'm using vuex-persistedstate (great project!) with Nuxt.js, but I don't think Nuxt is a factor here. It's more about the vue lifecycle and such.
I'm storing a JWT token in my vuex store and letting vuex-persistedstate keep it around after a reload. However, the component that needs the token runs mounted() before the store data is rehydrated.
Is the only option here to have a watch function keep an eye on the state token value and then firing when it's not null?

I would move the JWT out of Vuex and just make it a localStorage.getItem() call.

Old issue I know, but I found that if I avoid wrapping the setup in the call to window.onNuxtReady, then the state is rehydrated before my components initialize. This seems to solve the problem for me. Is there any downside to this approach?

Old issue I know, but I found that if I avoid wrapping the setup in the call to window.onNuxtReady, then the state is rehydrated before my components initialize. This seems to solve the problem for me. Is there any downside to this approach?
(FWIW, we are running in spa mode)

Have you found any drawbacks to this? I also figured out after hours of debugging that onNuxtReady only allows you to rehydrate state in computed properties and not in any methods or lifecycle hooks.

I have the same problem, do any of you cause problems by not having window.onNuxtReady?

I have the same problem, do any of you cause problems by not having window.onNuxtReady?

I had the same problem with vuex-persist plugin as well. But updating to the latest Nuxt version fixed it.
If updating to the latest Nuxt version does not fix it for this plugin, i suggest trying this other plugin, they do the same thing and the issue is not there anymore.
https://github.com/championswimmer/vuex-persist/issues/153

Any solution to this? I can't use the store in my pages because it hasn't been restored by the time it mounts the page, therefore I have errors all over my website.


Update MockFactory.ts

fix mock overrides

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Feature Request] show Accessibility checks visually

Something similar to https://developer.android.com/guide/topics/ui/accessibility/testing#accessibility-scanner
Perhaps on failing accessibility checks, overlay the screenshot with the bounding box of the failure
https://developer.android.com/guide/topics/ui/accessibility/testing#accessibility-scanner

example
    // Rethrow the Accessibility exception once screenshots have passed
    if (accessibilityException != null) {
        accessibilityException.results.forEachIndexed { index, check ->
            val viewImage = check.viewImage
            if (viewImage is BitmapImage) {
                FileOutputStream(
                    "build/outputs/roborazzi/" +
                        "${screenshotName}_${deviceName}_$index.png",
                ).use {
                    viewImage.bitmap.compress(PNG, 100, it)
                }
            }
        }

        throw accessibilityException
    }

I think we can use AwtRoboCanvas to save images while respecting user settings, such as image extensions, and to write text and frames.


"Faraoani" commune is listed in the drop-down menu

Description:
The commune is listed in the drop-down menu according to the law
Preconditions :the website (https://peviitor-ro.github.io/ui.orase/) is up and runing.
After every step delete the text you typed from the search bar.

Step 1
Type "Faraoani" in the search bar.
Expected results
The location is listed in the drop-down menu as "Faraoani, Bacău"


added row.first and result.fetch_first methods allowing for the first value of a column to be retrieved in a nicer way

Many CQL queries return only a single column, and we're not interested in the column name, but only the column value. For instance, in order to fetch the type of a given CF in the system keyspace, we can do the following query:
type = system.execute("SELECT type FROM schema_columnfamilies WHERE keyspace_name = ? and columnfamily_name = ?, "system", "HintsColumnFamily").fetch_row[0]

Since the programmer knows beforehand the result will only result a single column, and is interested only in the column value, we added the syntactic sugar "fetch_first", which will encapsulate the array access, so the above code will look like:
type = system.execute("SELECT type FROM schema_columnfamilies WHERE keyspace_name = ? and columnfamily_name = ?, "system", "HintsColumnFamily").fetch_first

Furthermore, if for some reason, that query result is empty, the fetch_row[0] acess will throw a "NoMethodError: undefined method `[]' for nil:NilClass", while the fetch_first will return "nil", allowing the programmer to use something like:
type =  system.execute("SELECT type FROM schema_columnfamilies WHERE keyspace_name = ? and columnfamily_name = ?, "system", "HintsColumnFamily").fetch_first or "defaultType"

Another use case for the fetch_first method is when the client is iterating over a result set but is only interested in the first column value returned. For instance, to retrieve all column family names from the system table, you can use the following code:
system.execute("SELECT columnfamily_name FROM schema_columnfamilies WHERE keyspace_name = ?", "system").fetch_array { |col|
    puts col[0]
}

With the fetch_first, that array access is abstracted and the programmer will be able to use the column value directly during the iteration:
system.execute("SELECT columnfamily_name FROM schema_columnfamilies WHERE keyspace_name = ?", "system").fetch_first { |col|
    puts col
}

I honestly have no idea why I'm just seeing this now, but it seems like a fine addition.


New resnet50 issues on WH

on wormhole:

[ ] b=8
[x] b=16
[ ] b=20 -- needs https://github.com/tenstorrent/tt-metal/issues/7770

Stale. Closing


[IOTDB-1514] Support null in insertTablet

Use Bitmap to support null value in basic types' TVList, so user can insert null in insertTablet method.

I just come up with another idea on the train. :) Is it necessary to maintain bitmaps in normal TVList?
The insertTablet logic in TVList is actually calls the System.arrayCopy to copy the timestamps and values array into TVList. If we check the bitmap passed from outside here and split the arrays accordingly, skip copying the range that the bitmap marked. Then we don’t even need to change the sort, encoding and query logic anymore.
How do you think? Should we do some experiment to compare the current implement in this pr and the idea above?

I just come up with another idea on the train. :) Is it necessary to maintain bitmaps in normal TVList?
The insertTablet logic in TVList is actually calls the System.arrayCopy to copy the timestamps and values array into TVList. If we check the bitmap passed from outside here and split the arrays accordingly, skip copying the range that the bitmap marked. Then we don’t even need to change the sort, encoding and query logic anymore.
How do you think? Should we do some experiment to compare the current implement in this pr and the idea above?

I think it is ok to remove bitmaps in normal TVList, the write performance may a little bit worse than current implement, but more space is saved and the sort performance is much more better.
Should I implement this in another PR?

How do you think? @qiaojialin

Coverage increased (+0.009%) to 67.429% when pulling 57320c4140416ef7926d69569723a685684c7819 on HeimingZ:IOTDB-1514(support_null_in_insertTablet) into 6dc45c6c4210f117099a1a31b50288f868630ddc on apache:master.


Add an AI chat experience to Windows Terminal, powered by the user's Azure OpenAI resource

Summary of the Pull Request
Adds an AI chatbot to Windows Terminal. Currently we do not ship with our own LLM, the user needs to provide their own Azure OpenAI subscription to be able to use this feature.

A new settings page has been added where the user can input their Azure OpenAI endpoint and key
A new palette has been added to the dropdown, called Terminal Chat
From Terminal Chat, the user can make queries to the provided endpoint for assistance with shell commands
We let the endpoint know about the user's current shell so that (hopefully) the commands received are relevant to the user's context
Received commands can be clicked from within the palette to be input into the user's active shell
The system prompt, alongside Azure OpenAI's in-built safeguards, should prevent strange/inappropriate replies from the LLM

Validation Steps Performed

References and Relevant Issues
#15000
PR Checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

If checked, please file a pull request on our docs repo and link it here: #xxx

[ ] Schema updated (if necessary)

@check-spelling-bot Report
🔴 Please review
See the 📂 files view or the 📜action log for details.
Unrecognized words (6)
CVS desploy endpt gpt hyperlinked openai
Previously acknowledged words that are now absent
To accept ✔ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands
Pattern suggestions ✂ (1)
Warnings (1)
✏ Contributor please read this

We definitely got to fix that "desploy", I think everything else that the spell-bot detected is fine though.

Notes:

Issues:

We hardcoded the colors so light mode doesn't work
The only assets we have are dark mode, and xaml doesn't support the theme-light qualifier. I had to switch to SVGs for the menu and settings.
Our resource string structure, with strings split into two or more pieces, does not work well for localization.

I forced us into dark mode to fix 1.
I removed all Audit and Fuzzing configurations for this project from the SLN.
I removed all AnyCPU configurations from the SLN.
The tracelogging was emitting different payloads (EndpointSet / EndpointStored)
The tracelogging didn't know endpoints were set because it didn't request the endpoint from the app...
We no longer crash inserting an answer into the settings UI

Kept the branch so Pankaj can see my changes


While running, memory consumption grows to the point of crashing python

Tested as well with the unaltered codebase and the training example given in the readme. Over time, memory consumed grows to using up all available ram (nearly 16GBs), at which point either: - Python throws an error and stops the execution, or - Malmo becomes unreachable, throwing a specific error message every step (I can't recall which one, will edit when it occurs again).
I believe this wasn't the case for earlier versions of the codebase as I was previously able to run for days on end without issue.
I'm curious if you recognise this behaviour, and what part of the code might be responsible.

This could be due to the replay memory, as this is the only section in which we store data (which isn't thrown away).
The following params could be the cause:

retain rgb - each state is x3 larger
success replay memory - an additional replay memory which stores only success trajectories
replay memory size - the size itself of the replay memory

it could be this commit: ffe029ec7e9438cc0df528f4d6663cafbd6d0fa9

Hmm I'll give it a try learning with a smaller replay memory size. The increase from 5K to 100K seems pretty significant. Do you reckon setting it back to something like 5K, and enabling both the success replay memory & the prioritized experience replay might be a worthwhile setting?
Thanks for the quick answer!

I think most problems in Minecraft are rather "simple" meaning short trajectories in a small domain - so this should be fine. Just remember that you need a large enough replay memory so the samples will be as diverse as possible.

Allright I did some testing and by playing with the parameters (most importantly keeping the memory smaller) the memory is no longer an issue, thanks!
However, as I was testing this with the single_room domain, it has not managed to achieve any reliable success percentage above 5%, even after 400k steps. Image:

This uses the unchanged master branch code. I ran two versions, one with prioritized replay and success replay:
python main.py qr_dqn single_room --number_of_atoms 200 --number_of_agents 1 --malmo_ports 10000 --retain_rgb --save_name qr-dqn-test_extra-replay --replay_memory_size 5000 --success_replay_memory --prioritized_experience_replay
And one without:
python main.py qr_dqn single_room --number_of_atoms 200 --number_of_agents 1 --malmo_ports 10000 --retain_rgb --save_name qr-dqn-test --replay_memory_size 5000
Both ran for over 460k steps, and both achieving similar results as the image shown.
However, when I tested the single_room domain with the unmodified codebase and the parameters from the readme a while back, it performed much better, reaching a near 100% success rate after only 150k steps. Image:

I am wondering what kind of reliable performance you get out of the single_room domain and with what kind of parameters.

From what commit did the test run properly? I'll try and find what I broke in the process.

Unfortunately I am not sure of the exact commit, but it was at least shortly before 050800edaace4b2a6b3303fa4bbf08a13773bb74
I'm running a single-room test with the parameters from the readme now on commit 90e2eaeb0ee878785a2005a7fc7c8ecaf1ba01ad

OK, thanks.
I'll take a look at this on Sunday. If you have any updates by then regarding your current test, please share :)

Thanks, Will do!
Out of curiosity, have you run the single-room (or any other domain I can test as well) any time lately? What kind of performance do you get with it?

I think the issue is due to the success replay memory probability decay. Default parameter is decay steps = 0 and when decay steps is 0, it falls back to the final probability (defaults to 0%).
Making sure this is the issue, then I'll push a quick fix.

Pushed a fix. I see on my end that it solves within 50k steps.
The commandline I used:
python3.6 main.py qr_dqn single_room --number_of_agents 1 --malmo_ports 10000 --ms_per_tick 75 --save_name qr_single_room --number_of_atoms 200 --double_dqn --epsilon_decay 20000 --success_replay_memory --replay_memory_size 10000

Oh that sounds like great performance! I am still running on commit 90e2eae, and it's unly just now starting to pick up success percentage after >350k steps..

I'll give it a try.

Pushed a fix. I see on my end that it solves within 50k steps.
The commandline I used:
python3.6 main.py qr_dqn single_room --number_of_agents 1 --malmo_ports 10000 --ms_per_tick 75 --save_name qr_single_room --number_of_atoms 200 --double_dqn --epsilon_decay 20000 --success_replay_memory --replay_memory_size 10000

Interestingly enough, using the exact same command line on the latest commit, after 210k steps mine still hadn't finished... :

I am going to run it some more times, but I'm wondering what might cause this discrepancy with your results.

Ran two more times for over >150k steps on two different machines, I get very similar results to my first try.

@tesslerc What do you think might cause this difference in performance between you and me?

This is really weird behavior...
Can you also try with the flag '--normalize_reward'
While in theory, this shouldn't change anything... it might help convergence due to the network learning values on a lower scale.

I'll try that now and will report back.

I was away for the weekend, so can only report back now.

As you can see, it definitely performs better with --normalize_reward (the first ~0.8 success spike being at 80k steps), but still has never attained 100% success, even after 600k steps... I ran this on two different machines again with similar results.
I'm frankly stumped as to what might cause this difference between you and me. Any ideas? Are you running it on Windows or on Linux?

This does seem weird... This should converge as it is a simple problem.
I'm running on Ubuntu (linux).
Try under 'https://github.com/tesslerc/malmo_rl/blob/master/agents/single_room.py' to change the supported_actions so as to not include 'move -1'. This reduces the complexity of the problem. This isn't a proper fix, but it might help.

I will do a run that way on one machine, and try to do a regular run on Ubuntu on another machine. I'll let you know my findings.

A tad late, but reporting my findings from this nonetheless: The regular run on Ubuntu was not much more successful than the others (after nearly 200k steps average around 0.6). I ran it also without move -1 on ubuntu and there after 100k steps it managed to stabalize to virtually 1.0 (so 100%) success. So that's something at least. Right now I'm running some experiments of my own again (on domains like the subskill rooms), but not too great results there either...
I'm not sure how to tackle this issue except for continuing to toy around with parameters and policies. If you have some enlightening insight, that would still be very welcome.

This is really puzzling... I assume the issue is with 'move -1' being a "confusing" action.
I think what might happen is that the agent walks backwards and touches the block (finishing the mission) yet without seeing it.
This might be causing instability.
I'm glad that you were able to find some configuration which worked well.
I suggest to drop this actions and only allow actions correlated to what the agent is seeing (i.e. move forward, interact with objects it can see, turn right/left).

The agent walks backwards and touches the block without seeing it. This might be causing instability.

Yeah since the state is only related to what it sees, without very adequate short term state memory, it
would be difficult for an agent to understand why a state would suddenly result in a reward.
However, in the subskill domains I'm training now, (e.g. the nav2 and pickup from your paper), I already check for that, but the results thus far are not encouraging either. For example, here is the success rate of nav2 (with qr-dqn), which I both tested with and without retain_rgb for very similar results.
 And the pickup-training run (currently at 100k) is performing even worse.
So there are two main distinct things that are giving me pause here.

You stated that you were able to solve the single_room domain with move -1 relatively quickly, whereas that didn't at all work as smoothly for me. So maybe your 50k solve was a very lucky anomaly? I just don't know.
When I'm training the subskill domains, the main difference in the simulation from your paper (as far as I can think of), is that the agent turns in 90° instead of 30°, which might result in skipping over visual cues in the peripheral area. To emulate that, I might try to implement a 45° turn instead, and do manual movements, which would however make the agent a bit more cumbersome (30° would a mess for discrete movements, and with 45° I can somewhat cheat the movement and still put it in the center of the next diagonal square).

If you'd like, you can check out my agents to see if I coded anything fishy. For completeness, I ran it with these parameters: python3.6 main.py qr_dqn subskill_nav2 --number_of_agents 1 --malmo_ports 10000 --ms_per_tick 75 --save_name qr_subskill_nav2_test2_c5b1f3 --number_of_atoms 200 --double_dqn --epsilon_decay 20000 --success_replay_memory --replay_memory_size 10000 --normalize_reward --retain_rgb
How are your experiments holding up? Are they learning just fine? Do you have more visual cues maybe?

I am somewhat unsure, as I tested again with move -1 and it also didn't work well. It could be that my previous run was without move -1.
But I will take a look at your agents. I believe pickup should learn easily and the navigation2 domain might be a tad harder as it has some partial observability issues (pillars block the line of sight).
** We were able to turn 30 degrees, as we didn't use Malmo in the paper. I really hope this isn't the issue :\

I am somewhat unsure, as I tested again with move -1 and it also didn't work well. It could be that my previous run was without move -1.

Ah that might explain a lot.

But I will take a look at your agents.

Thanks!

OK, not sure this is the issue but it might be.
For example look at the subskill_pickup.py.
In order to define success, you perform the following check:
`
Check if the agent was already touching the block
    if self.touching_block:
        # Check if the agent is facing the block
        if(((grid[10] == u'gold_block' and yaw == 'north')  or
            (grid[14] == u'gold_block' and yaw == 'east' )  or
            (grid[16] == u'gold_block' and yaw == 'south')  or
            (grid[12] == u'gold_block' and yaw == 'west' )) and
            action_command == 'move 1'):
            # If the agent executed dummy action 'move 1', the agent succeeded
            return self.reward_from_success, True, state, False, True

`
I had some issues with this before, and I moved to using the built-in behavior from Malmo as you can see here: https://github.com/tesslerc/malmo_rl/blob/master/agents/domains/single_room.xml
Basically, you tell Malmo to provide a large positive reward for success and you check if the reward > 0. If so, the agent has reached the goal.
Additionally, I tend to prefer a zero reward upon success and a negative reward per step. This ensures the Q is strictly negative for any state-action pair which prevents any positive feedback loops which can occur due to estimation issues. Empirically, I saw better results in this configuration.

Hey, thanks for the follow up.
For the pickup one, I was looking for a way to give control to Malmo, but none of the available QuitFrom-commands provide a way to do exactly what the original research did (i.e. requiring a specific action to pickup), I'm afraid. I could use AgentQuitFromCollectingItem with just the spawned item in the middle of the room instead of the block. Then I stay more true to the minecraft-world, but it misses the separate action to pick it up, and the object might be relatively small in the peripheral vision / the visual success state might be confusing for the network since the success state visually doesn't show why it suddenly was a success (the item immediately despawn on pickup).
What are your thoughts on this?
Also, I have been training subskill_nav2 -- which does have the mission success checks controlled by Malmo -- for 500k steps with qr-dqn, and it doesn't show any learning progress either. The success rate just randomly fluctuates between 0.0 and 0.2.
So I'm also not sure how that should be remedied.
I will change the reward structure to be zero upon success.

Maybe you can combine AgentQuitFromCollectingItem with breaking the block?
If breaking the block causes the agent to pick it up, this could fix your problem.
Though an alternative is to ignore the whole "pickup action" and just require that the agent touch the block (similar to the simple room in this git).

Yes I was thinking about that as well.
And for the breaking (since I don't want to be breaking everything with the discretecommands), Is there an easy way to check that I'm targeting the correct type of block before attacking? I could override the def perform_action from the agent base class (and copy all the method's code) to put an observation check there (using self.agent_host.peekWorldState() to get the current observation before performing the command, without influencing anything), right?

That sounds correct. Though you can remove the assert (action_command in self.supported_actions or action_command == 'new game') from perform_action function.
Then overload perform_action in your new agent class checking if to allow the attack 1 command or not. If not, change the command to jump or some other no-op. Finally use super to call the original perform_action with the new command.
This is if you prefer to do less copy-pasting.

Ah yes that would be better, I'll implement it like that. It might be a logical addition anyway to remove that check from the base agent and always have a perform_action method functioning like you said in new agents, for more control over the environment.


Add xscratchcsw/xscratchcswl  read and write pseudocode

The specification includes pseudocode for accesses to xscratchscw and xscratchscwl using read-modify-write accesses. For clarity, please also add pseudocode for read accesses and write accesses.

We will discuss this further in our discussion group.

Kevin's email:
Hi,
In our recent group meeting, we discussed about Jame’s github issue #51 but decided to get more feedback here because the answer seems somewhat unintuitive.
This issue asks about the behavior (pseudocode) of “pure reading” and “pure writing” xscratchcsw/xscratchcswl CSRs. These 2 CSRs are designed to speed up the initialization of the stack pointer by conditionally swapping the stack pointer with xscratch. Therefore, their intended/typical usage is read-modify-write (i.e., swap):  csrrw sp, mscratchcsw, sp
The pseudo code for “csrrw rd, mscratchcsw, rs1” (conditional swap) is the following:
// Pseudocode operation.
if (mcause.mpp != M-mode) then {
t = rs1; rd = mscratch; mscratch = t;
} else {
rd = rs1; // mscratch unchanged.
}
If we follow the same spirit of “conditional swap,” the write access seems to also become a “conditional write” with the following pseudocode:
csrrw x0, mscratchcsw, rs1
// Pseudocode operation.
if (mcause.mpp != M-mode) then {
mscratch = rs1;
} else {
// mscratch unchanged.
}
Similarly, read access seems to become a conditional read:
csrrs rd, mscratchcsw, x0
// Pseudocode operation.
if (mcause.mpp!=M-mode) then {
rd = mscratch;
} else {
// rd unchanged
}
Are these the desired behavior/definition for writing and reading xscratchcsw/xscratchcswl? Although pure reading or pure writing these CSRs may not be very useful, we need to define them clearly to get consistent results/implementation. In practice, the only useful access for these 2 CSRs should be read-modify-write (swap).
Thanks.
    Regards,
    Kevin

In TG meeting, we decided to write out all the behaviors of the CSR variants, but could just possibly simply declare the non CSRRW variants as "reserved".

If we follow the same spirit of “conditional swap”, read access should become a conditional read:
csrrs rd, mscratchcsw, x0
// Pseudocode operation.
if (mcause.mpp!=M-mode) then {
rd = mscratch;
} else {
// rd unchanged
}
However, a senior member indicated that keeping the value unchanged (in false clause) will require an extra GPR read-port in an out-of-order CPU. This is quite expensive so another member suggested to always write the destination with x0 (i.e., rs1/source GPR). Nevertheless, for set/clear CSR instructions (csrrs/csrrc), directly copying the source GPR to the destination GPR will require an complete new datapath/MUX which did not exist before. This extra datapath and circuit may slow down the CPU max frequency.
In practice, only the read-modify-write (swap/CSRRW) operation is useful for xscratchcsw/xscratchcswl. In contrast, the “pure read” and “pure write” operations are meaningless and not useful at all. Therefore, we could just possibly simply declare the non CSRRW variants as "reserved". In the meantime, we will still try to write out all the behaviors of the CSR variants for further discussion.

added pull request #119.  please review.  Thanks!

Updated the spec with commit 646310a5e4ae055964b4680f12c1c04a7cc0dd56.


RGBW Dimmer: Can't control white

Version
Build/Run method

[ ] Docker
[ ] PKG
[X] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: 1.0.0-rc.0
Describe the bug
White does not show up on the color picker for an RGBW dimmer (Zooz zen31)
To Reproduce
Steps to reproduce the behavior:

Get set up with the 1.0.0-rc.0 zwavejs2mqtt
Rediscover a zooz zen31 RGBW dimmer
Open the RGB dimmer control
Observe that only the color dial is present, the white control is missing

Expected behavior
I would expect that there would be a white control on the display
Additional context
node_25_rc.zip
How this dimmer shows up:

How I would expect it to appear (this is a tasmota RGBW wifi light, not my image)

FYI, Z-Wave supports warm white and cold white, so you might wanna support both. And Amber, Cyan and Purple if you want to get really funky. And theoretically, a device could just support Red and Blue, bot not Green 🤷🏻♂

FYI, Z-Wave supports warm white and cold white, so you might wanna support both. And Amber, Cyan and Purple if you want to get really funky. And theoretically, a device could just support Red and Blue, bot not Green 🤷🏻♂

HA does support those alternatives too (well, at least warm vs cool white), my rgb tuneable white zigbee bulbs have a slider for color temperature instead of a white level adjustment

HA does support those alternatives too (well, at least warm vs cool white), my rgb tuneable white zigbee bulbs have a slider for color temperature instead of a white level adjustment

With #290 there is now a white control, but it does not adjust the white level of this dimmer.

With #290 there is now a white control, but it does not adjust the white level of this dimmer.

@jcam check stack overflow to help me debug this

@jcam check stack overflow to help me debug this


Strike system

a !strike command for inside modmail threads for user for example messaging the bot for no real reason or whatever. you do !strike
and each time he messages the bot it will say
This user has 1 previous modmail threads. Use !logs to see them.
and 2 strikes. for whatever reason. would like to see that
keep up the great work

This is probably better managed with one of the many extant moderation bots. This is more for contacting staff. I, for one, would tend to want to keep all moderation records centralised, rather than split between modmail and my actual moderation bot.
v / r
Robert Klebes
Mobile:<PHONE_NUMBER>
https://keybase.io/sporkwitch
https://www.linkedin.com/in/klebes
On September 5, 2019 4:32:43 PM EDT, "Raz❥"<EMAIL_ADDRESS>wrote:

a !strike command for inside modmail threads for user for example
messaging the bot for no real reason or whatever. you do !strike
and each time he messages the bot it will say
This user has 1 previous modmail threads. Use !logs to see them.
and 2 strikes. for whatever reason. would like to see that
keep up the great work
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Dragory/modmailbot/issues/347

Agreed. I keep a "Case Files" channel. And a logs channel seperate for the specific reason of wanting to go back later to view it

Like @sporkwitch mentioned, this will probably not be implemented as a first party feature since it's not integral to the purpose of the bot (and that's why I'm also closing this issue). That being said, someone could implement it as a plugin! Take a look at the Plugins section in the README.


Added Coveralls script to the Travis CI

Changes Unknown when pulling c3da5099bcaf363b49d47dde10a1773e4f401f65 on coveralls-integration into ** on master**.


Apps: change provider_path option to provider-path.

The applications use '-' in options not '_'.

[x] documentation is added or updated
[x] tests are added or updated

This pull request is ready to merge

Merged to master, thanks.

Lots still exist; cmp is new in 3.0, right? Worth adding aliases for all the others?
; g grep -c '{".*_.*OPT_'
ca.c:8
ciphers.c:3
cmp.c:42
cms.c:19
crl.c:1
dgst.c:1
ec.c:4
ecparam.c:5
fipsinstall.c:5
include/opt.h:21
ocsp.c:18
pkcs7.c:1
pkcs8.c:3
pkey.c:3
pkeyutl.c:2
req.c:2
rsa.c:2
s_client.c:38
s_server.c:44
s_time.c:3
speed.c:1
ts.c:3
verify.c:2
x509.c:9
;

I'm not sure, it would be nice to have aliases but it adds clutter to the code base.  Removing the _ versions would be nigh on impossible.

The cmp command is new for 3.0 and perhaps should be fixed.


Add Jaspreet Singh to Contributors list

Awesome @singh19196. Congrats on your first PR. Best wishes on your future endeavours.


Fix sample in FAISS section

This PR fixes a sample in the FAISS section in the reference docs.

thanks @izeye!


Verify that "Vinerea" is listed in the dropdown menu when searched

Description:
"Vinerea" should appear in the dropdown menu with correct spelling and locality information.
Preconditions:
The website is up and running.

Step 2
Observe the dropdown menu.
Expected results:
"Vinerea" is displayed and selectable from the dropdown menu.


[android]Keyboard with hide button

On samsung s10 when settings->General management->keyboard list and default->show button to hide keyboard is ON appear over the keyboard a line witch is same height that the bottom bar what add that function.
When it with single scroll view its be non transparent, but if no scroll view its transparent. (you can see the oversize warning is not next to the keyboard)
You can see the last photo when i switch off, disappear the line.
I use Flutter 1.26.0-17.8.pre

My simple code:
`import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);
  final String title;
  TextEditingController tec;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    List<Widget> children=[];
    for(int i=0;i<55;i++){
      children.add(Text("asdasdasdasdasdasd"));
    }
    children.add(TextFormField(controller: widget.tec,));
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: SingleChildScrollView(child: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: children,
        ),
      ),
      //floatingActionButton: Continer,
    ));
  }
}

`

@fehencke
Not sure if I understood the issue correctly.  I have S10, but when you mentioned s10 when settings->General management->keyboard list and default->show button, I couldn't exactly find it on my phone. Under General Management, I see below:

Can you properly describe the issue with detailed steps and what's the expected vs actual behavior ?
Also, can you upgrade to latest version and try again to see if issue persists ?

For me like that, but now i see samsung will ugrade the UI version to 3.1 maybe you have that?
Or baybe i see different the menu because use Gboard keyboar.
I'll check in 2 days with the newest build.
But if you find the function what i marked with red circle, and use my simple code will see over the keyboard appear a tarnsparent space. And after i add singlescrollview on body ilthats space be non-transparent. Thats why at my original first picture you not see the text just the top of d letters.

S10 I've shows One UI 2.5.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


sample 4: update permission

What this PR changes/adds
It updates the permission in the transfer-file module of sample 04.0. It changes the permission's action from idsc:USE to USE and adds a permission target.
Why it does that
Currently, upon description request the transformer throws an error when transforming the permission from sample 4 due to a missing target and an unknown action type. While the description request is not required for sample 4 to run successfully, people might look at this sample and define their policies in the same way, which would then lead to these errors.

Codecov Report

Merging #970 (deec5b4) into main (d429b6c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #970   +/-   ##
=========================================
  Coverage     62.05%   62.05%
  Complexity     2395     2395
=========================================
  Files           616      616
  Lines         13166    13166
  Branches        935      935
=========================================
  Hits           8170     8170
  Misses         4562     4562
  Partials        434      434

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d429b6c...deec5b4. Read the comment docs.