HDDS-1441. Remove usage of getRetryFailureException. (swagle)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
218
Maven dependency ordering for branch

+1
mvninstall
1147
trunk passed

+1
compile
1289
trunk passed

+1
checkstyle
180
trunk passed

+1
mvnsite
266
trunk passed

+1
shadedclient
1271
branch has no errors when building and testing our client artifacts.

+1
findbugs
106
trunk passed

+1
javadoc
69
trunk passed

_ Patch Compile Tests _

0
mvndep
24
Maven dependency ordering for patch

+1
mvninstall
58
the patch passed

+1
compile
1129
the patch passed

+1
javac
1129
the patch passed

+1
checkstyle
168
the patch passed

+1
mvnsite
94
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
826
patch has no errors when building and testing our client artifacts.

+1
findbugs
130
the patch passed

+1
javadoc
72
the patch passed

_ Other Tests _

+1
unit
37
client in the patch passed.

+1
unit
96
ozone-manager in the patch passed.

+1
asflicense
68
The patch does not generate ASF License warnings.

7128

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 30eab6f7f5c5 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a5ceed2

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/1/testReport/

Max. process+thread count
371 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thanks, @bshashikant  for your review comments. Updated the patch with suggested changes.
Although, wouldn't it be better to have a generic exception class in Ratis that can have derived classes on the server side? It would allow separation of concerns for server and client vs now any new type exception will break the client side code in at runtime. Its not like we are doing anything with the exception, only wrapping it up.

I just verified that with Ratis-518, the exception field in RaftClientReply is already exposed. We can just wrap the exception inside RaftClientReply to completionException instead of checking for any specific exceptions. To acheive this, Ratis version needs to be updated inside Ozone.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
32
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
276
Maven dependency ordering for branch

+1
mvninstall
1046
trunk passed

+1
compile
962
trunk passed

+1
checkstyle
130
trunk passed

+1
mvnsite
109
trunk passed

+1
shadedclient
970
branch has no errors when building and testing our client artifacts.

+1
findbugs
99
trunk passed

+1
javadoc
69
trunk passed

_ Patch Compile Tests _

0
mvndep
21
Maven dependency ordering for patch

+1
mvninstall
60
the patch passed

+1
compile
898
the patch passed

+1
javac
898
the patch passed

+1
checkstyle
136
the patch passed

+1
mvnsite
80
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
675
patch has no errors when building and testing our client artifacts.

+1
findbugs
101
the patch passed

+1
javadoc
47
the patch passed

_ Other Tests _

+1
unit
24
client in the patch passed.

+1
unit
41
ozone-manager in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

5834

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 427845516e5b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / be6c801

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/3/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
820
Maven dependency ordering for branch

+1
mvninstall
1059
trunk passed

+1
compile
967
trunk passed

+1
checkstyle
140
trunk passed

+1
mvnsite
107
trunk passed

+1
shadedclient
997
branch has no errors when building and testing our client artifacts.

+1
findbugs
102
trunk passed

+1
javadoc
74
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

+1
mvninstall
60
the patch passed

+1
compile
923
the patch passed

+1
javac
923
the patch passed

+1
checkstyle
142
the patch passed

+1
mvnsite
80
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
690
patch has no errors when building and testing our client artifacts.

+1
findbugs
117
the patch passed

+1
javadoc
70
the patch passed

_ Other Tests _

+1
unit
37
client in the patch passed.

+1
unit
56
ozone-manager in the patch passed.

+1
asflicense
49
The patch does not generate ASF License warnings.

6573

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 3feb6c7539b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / be6c801

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/2/testReport/

Max. process+thread count
436 (vs. ulimit of 5500)

modules
C: hadoop-hdds/client hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
26
Docker mode activated.

_ Prechecks _

+1
@author
1
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
73
Maven dependency ordering for branch

+1
mvninstall
1063
trunk passed

+1
compile
1102
trunk passed

+1
checkstyle
132
trunk passed

+1
mvnsite
330
trunk passed

+1
shadedclient
1169
branch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

+1
findbugs
84
trunk passed

+1
javadoc
205
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
35
hadoop-hdds in the patch failed.

-1
mvninstall
10
client in the patch failed.

-1
mvninstall
15
hadoop-ozone in the patch failed.

-1
mvninstall
10
ozone-manager in the patch failed.

+1
compile
1036
the patch passed

+1
javac
1036
the patch passed

+1
checkstyle
136
the patch passed

-1
mvnsite
26
hadoop-hdds in the patch failed.

-1
mvnsite
19
client in the patch failed.

-1
mvnsite
22
hadoop-ozone in the patch failed.

-1
mvnsite
20
ozone-manager in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
654
patch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

-1
findbugs
19
client in the patch failed.

-1
findbugs
20
ozone-manager in the patch failed.

-1
javadoc
21
hadoop-hdds in the patch failed.

-1
javadoc
19
client in the patch failed.

-1
javadoc
23
hadoop-ozone in the patch failed.

-1
javadoc
20
ozone-manager in the patch failed.

_ Other Tests _

-1
unit
24
hadoop-hdds in the patch failed.

-1
unit
19
client in the patch failed.

-1
unit
21
hadoop-ozone in the patch failed.

-1
unit
17
ozone-manager in the patch failed.

+1
asflicense
36
The patch does not generate ASF License warnings.

6200

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux f341cca78ccd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / df76cdc

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvninstall-hadoop-hdds_client.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvninstall-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvnsite-hadoop-hdds.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvnsite-hadoop-hdds_client.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvnsite-hadoop-ozone.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-findbugs-hadoop-hdds_client.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-javadoc-hadoop-hdds_client.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-javadoc-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-unit-hadoop-hdds_client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-unit-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
61
Docker mode activated.

_ Prechecks _

+1
@author
1
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
314
Maven dependency ordering for branch

+1
mvninstall
1437
trunk passed

+1
compile
1384
trunk passed

+1
checkstyle
167
trunk passed

+1
mvnsite
461
trunk passed

+1
shadedclient
1411
branch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

+1
findbugs
95
trunk passed

+1
javadoc
221
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
39
hadoop-hdds in the patch failed.

-1
mvninstall
12
client in the patch failed.

-1
mvninstall
16
hadoop-ozone in the patch failed.

-1
mvninstall
12
ozone-manager in the patch failed.

+1
compile
915
the patch passed

+1
javac
915
the patch passed

+1
checkstyle
141
the patch passed

-1
mvnsite
26
hadoop-hdds in the patch failed.

-1
mvnsite
21
client in the patch failed.

-1
mvnsite
26
hadoop-ozone in the patch failed.

-1
mvnsite
22
ozone-manager in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
707
patch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

-1
findbugs
21
client in the patch failed.

-1
findbugs
21
ozone-manager in the patch failed.

-1
javadoc
23
hadoop-hdds in the patch failed.

-1
javadoc
21
client in the patch failed.

-1
javadoc
23
hadoop-ozone in the patch failed.

-1
javadoc
22
ozone-manager in the patch failed.

_ Other Tests _

-1
unit
28
hadoop-hdds in the patch failed.

-1
unit
23
client in the patch failed.

-1
unit
24
hadoop-ozone in the patch failed.

-1
unit
22
ozone-manager in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

7423

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux 76c5899e4a1b 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / a54c1e3

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvninstall-hadoop-hdds_client.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvninstall-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvnsite-hadoop-hdds.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvnsite-hadoop-hdds_client.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvnsite-hadoop-ozone.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-findbugs-hadoop-hdds_client.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-javadoc-hadoop-hdds_client.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-javadoc-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-unit-hadoop-hdds_client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-unit-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/testReport/

Max. process+thread count
341 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
503
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
69
Maven dependency ordering for branch

+1
mvninstall
1075
trunk passed

+1
compile
991
trunk passed

+1
checkstyle
142
trunk passed

+1
mvnsite
350
trunk passed

+1
shadedclient
1219
branch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

+1
findbugs
101
trunk passed

+1
javadoc
248
trunk passed

_ Patch Compile Tests _

0
mvndep
23
Maven dependency ordering for patch

-1
mvninstall
30
hadoop-hdds in the patch failed.

-1
mvninstall
13
client in the patch failed.

-1
mvninstall
17
hadoop-ozone in the patch failed.

-1
mvninstall
14
ozone-manager in the patch failed.

+1
compile
940
the patch passed

+1
javac
940
the patch passed

+1
checkstyle
143
the patch passed

-1
mvnsite
36
hadoop-hdds in the patch failed.

-1
mvnsite
31
client in the patch failed.

-1
mvnsite
32
hadoop-ozone in the patch failed.

-1
mvnsite
30
ozone-manager in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
2
The patch has no ill-formed XML file.

+1
shadedclient
685
patch has no errors when building and testing our client artifacts.

0
findbugs
0
Skipped patched modules with no Java source: hadoop-hdds hadoop-ozone

-1
findbugs
29
client in the patch failed.

-1
findbugs
30
ozone-manager in the patch failed.

-1
javadoc
33
hadoop-hdds in the patch failed.

-1
javadoc
30
client in the patch failed.

-1
javadoc
32
hadoop-ozone in the patch failed.

-1
javadoc
31
ozone-manager in the patch failed.

_ Other Tests _

-1
unit
37
hadoop-hdds in the patch failed.

-1
unit
30
client in the patch failed.

-1
unit
33
hadoop-ozone in the patch failed.

-1
unit
30
ozone-manager in the patch failed.

+1
asflicense
51
The patch does not generate ASF License warnings.

6842

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle  xml

uname
Linux ac00b42338c9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 43b2a4b

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvninstall-hadoop-hdds_client.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvninstall-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvninstall-hadoop-ozone_ozone-manager.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvnsite-hadoop-hdds.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvnsite-hadoop-hdds_client.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvnsite-hadoop-ozone.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-mvnsite-hadoop-ozone_ozone-manager.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-findbugs-hadoop-hdds_client.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-findbugs-hadoop-ozone_ozone-manager.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-javadoc-hadoop-hdds_client.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-javadoc-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-javadoc-hadoop-ozone_ozone-manager.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-unit-hadoop-hdds_client.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-unit-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/artifact/out/patch-unit-hadoop-ozone_ozone-manager.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/testReport/

Max. process+thread count
410 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
28
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
405
trunk passed

+1
compile
203
trunk passed

+1
checkstyle
47
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
796
branch has no errors when building and testing our client artifacts.

+1
javadoc
122
trunk passed

0
spotbugs
234
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
417
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
38
hadoop-hdds in the patch failed.

-1
mvninstall
15
hadoop-ozone in the patch failed.

-1
compile
18
hadoop-hdds in the patch failed.

-1
compile
16
hadoop-ozone in the patch failed.

-1
javac
18
hadoop-hdds in the patch failed.

-1
javac
16
hadoop-ozone in the patch failed.

-0
checkstyle
17
The patch fails to run checkstyle in hadoop-hdds

-0
checkstyle
14
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
628
patch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-hdds in the patch failed.

-1
javadoc
17
hadoop-ozone in the patch failed.

-1
findbugs
30
hadoop-hdds in the patch failed.

-1
findbugs
18
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
24
hadoop-hdds in the patch failed.

-1
unit
17
hadoop-ozone in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

3067

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 007e5e55bb1d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 12b7059

Default Java
1.8.0_191

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/7/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
29
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
63
Maven dependency ordering for branch

+1
mvninstall
409
trunk passed

+1
compile
201
trunk passed

+1
checkstyle
54
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
822
branch has no errors when building and testing our client artifacts.

+1
javadoc
129
trunk passed

0
spotbugs
233
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
412
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
37
hadoop-hdds in the patch failed.

-1
mvninstall
20
hadoop-ozone in the patch failed.

-1
compile
24
hadoop-hdds in the patch failed.

-1
compile
17
hadoop-ozone in the patch failed.

-1
javac
24
hadoop-hdds in the patch failed.

-1
javac
17
hadoop-ozone in the patch failed.

-0
checkstyle
16
The patch fails to run checkstyle in hadoop-hdds

-0
checkstyle
15
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
650
patch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-hdds in the patch failed.

-1
javadoc
18
hadoop-ozone in the patch failed.

-1
findbugs
30
hadoop-hdds in the patch failed.

-1
findbugs
18
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
26
hadoop-hdds in the patch failed.

-1
unit
17
hadoop-ozone in the patch failed.

+1
asflicense
30
The patch does not generate ASF License warnings.

3203

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 4d958e09fd2f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f257497

Default Java
1.8.0_191

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/testReport/

Max. process+thread count
441 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/8/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
541
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
70
Maven dependency ordering for branch

+1
mvninstall
415
trunk passed

+1
compile
194
trunk passed

+1
checkstyle
45
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
759
branch has no errors when building and testing our client artifacts.

+1
javadoc
124
trunk passed

0
spotbugs
238
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
417
trunk passed

_ Patch Compile Tests _

0
mvndep
25
Maven dependency ordering for patch

-1
mvninstall
38
hadoop-hdds in the patch failed.

-1
mvninstall
19
hadoop-ozone in the patch failed.

-1
compile
23
hadoop-hdds in the patch failed.

-1
compile
17
hadoop-ozone in the patch failed.

-1
javac
23
hadoop-hdds in the patch failed.

-1
javac
17
hadoop-ozone in the patch failed.

-0
checkstyle
17
The patch fails to run checkstyle in hadoop-hdds

-0
checkstyle
15
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
658
patch has no errors when building and testing our client artifacts.

-1
javadoc
20
hadoop-hdds in the patch failed.

-1
javadoc
17
hadoop-ozone in the patch failed.

-1
findbugs
30
hadoop-hdds in the patch failed.

-1
findbugs
17
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
26
hadoop-hdds in the patch failed.

-1
unit
18
hadoop-ozone in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3656

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 58a8cc4d18f6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 2d8282b

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/testReport/

Max. process+thread count
426 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/9/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks @swagle for working on this. Patch looks good to me. I will e rep-triggering the tests to see it comes clean.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
515
trunk passed

+1
compile
279
trunk passed

+1
checkstyle
67
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
784
branch has no errors when building and testing our client artifacts.

+1
javadoc
136
trunk passed

0
spotbugs
197
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
74
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

0
mvndep
27
Maven dependency ordering for patch

-1
mvninstall
36
hadoop-hdds in the patch failed.

-1
mvninstall
23
hadoop-ozone in the patch failed.

-1
compile
23
hadoop-hdds in the patch failed.

-1
compile
17
hadoop-ozone in the patch failed.

-1
javac
23
hadoop-hdds in the patch failed.

-1
javac
17
hadoop-ozone in the patch failed.

-0
checkstyle
15
The patch fails to run checkstyle in hadoop-hdds

-0
checkstyle
15
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
616
patch has no errors when building and testing our client artifacts.

-1
javadoc
20
hadoop-hdds in the patch failed.

-1
javadoc
20
hadoop-ozone in the patch failed.

-1
findbugs
33
hadoop-hdds in the patch failed.

-1
findbugs
18
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
27
hadoop-hdds in the patch failed.

-1
unit
16
hadoop-ozone in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

5517

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 4a990de1d159 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ff5691c

Default Java
1.8.0_212

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/branch-findbugs-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/10/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

/retest

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

0
mvndep
64
Maven dependency ordering for branch

+1
mvninstall
523
trunk passed

+1
compile
278
trunk passed

+1
checkstyle
77
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
876
branch has no errors when building and testing our client artifacts.

+1
javadoc
162
trunk passed

0
spotbugs
288
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
476
trunk passed

_ Patch Compile Tests _

0
mvndep
32
Maven dependency ordering for patch

-1
mvninstall
45
hadoop-hdds in the patch failed.

-1
mvninstall
31
hadoop-ozone in the patch failed.

-1
compile
33
hadoop-hdds in the patch failed.

-1
compile
24
hadoop-ozone in the patch failed.

-1
javac
33
hadoop-hdds in the patch failed.

-1
javac
24
hadoop-ozone in the patch failed.

-0
checkstyle
25
The patch fails to run checkstyle in hadoop-hdds

-0
checkstyle
19
The patch fails to run checkstyle in hadoop-ozone

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
3
The patch has no ill-formed XML file.

+1
shadedclient
676
patch has no errors when building and testing our client artifacts.

-1
javadoc
30
hadoop-hdds in the patch failed.

-1
javadoc
26
hadoop-ozone in the patch failed.

-1
findbugs
38
hadoop-hdds in the patch failed.

-1
findbugs
25
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
34
hadoop-hdds in the patch failed.

-1
unit
25
hadoop-ozone in the patch failed.

+1
asflicense
42
The patch does not generate ASF License warnings.

6426

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/745

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 0867764ea142 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ff5691c

Default Java
1.8.0_212

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-compile-hadoop-ozone.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-hdds.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-745/out/maven-patch-checkstyle-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-javadoc-hadoop-ozone.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-findbugs-hadoop-hdds.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-findbugs-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/testReport/

Max. process+thread count
445 (vs. ulimit of 5500)

modules
C: hadoop-hdds hadoop-hdds/client hadoop-ozone hadoop-ozone/ozone-manager U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-745/11/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@swagle , i think the ratis snapshot version is incorrect as it leads to compilation failure. There are some more critical issues in Ratis which need to e addressed before we create a new snapshot and update the same in Ozone. Let's wait for the required fixes to go in Ratis and then update here.

Changes included in HDDS-1555: https://github.com/apache/hadoop/pull/846


Implement wake_event_loop method for Android

Implement wake_event_loop method. Required to implement WindowProxy on Glutin for Android. Tested on Servo for Android ;)

This is the PR I'll do to version of glutin used in servo when this one is merged: https://github.com/MortimerGoro/glutin/commit/87d291efc8b0af09961315d57d8bf273309d31ad
I'll submit the PR to glutin upstream too

R+, will merge when travis passes.

Hi tomaka ¿Could you bump version and publish the crate? I need to merge the new version in Servo

Please submit a PR that bumps the version and I'll merge and publish it.


New resource for web development

Idea Contribution

[X] I have read all the feature request issues.

Explain feature request
I want to add a web development playlist from youtube in the web development content assign me this issue under gssoc'24
Explain your solution
No response
Any alternative approaches/features
No response
Additional Context
No response

Assigned to you


feat(sqli): add endpoint /api/products/views vulnerable via the header parameter

Embed the x-product-name header parameter directly into the query, leaving the endpoint /api/products/views vulnerable to SQL injection attacks. Attackers can exploit this vulnerability to update the views_count column for the specified product.

@tamirGer make sure to use imperative present tenses and active voice in both the PR title and body. The commit scope should be short and without spaces. For details please see the contributing guide at https://team-1602965683919.atlassian.net/wiki/spaces/TEST/pages/256180295/How+to+contribute+to+Bright#Commit-Message-Format

@derevnjuk thanks for the review. The changes have been applied


EOS-21257: Support DTM0 service and config parameters

This patch adds DTM0 service for client and server
processes. Also parameters are supported for services
to be passed to m0d configuration, 'in-volatile' and
'in-persistent' parameters are added for DTM0 client
and server services correspondingly.
Signed-off-by: Sergey Shilov<EMAIL_ADDRESS>

@sergey-shilov , it would be good if you can post the output of a successful bootstrap with this patch and the corresponding confd.xc.

The output:
INFO: Bootstrapping the cluster using Hare...
2021-06-22 10:51:39: Generating cluster configuration... OK
2021-06-22 10:51:40: Starting Consul server on this node......... OK
2021-06-22 10:51:47: Importing configuration into the KV store... OK
2021-06-22 10:51:47: Starting Consul on other nodes... OK
2021-06-22 10:51:47: Updating Consul configuraton from the KV store... OK
2021-06-22 10:51:49: Waiting for the RC Leader to get elected..... OK
2021-06-22 10:51:51: Starting Motr (phase1, mkfs)... OK
2021-06-22 10:51:59: Starting Motr (phase1, m0d)... OK
2021-06-22 10:52:01: Starting Motr (phase2, mkfs)... OK
2021-06-22 10:52:20: Starting Motr (phase2, m0d)... OK
2021-06-22 10:52:28: Checking health of services... OK

[95:  {0x74| ((^t|1:0), 1, ^t|1:0, ^o|1:88, ^v|1:80, 1, [0], [1: ^n|1:3], [1: ^S|1:1], [3: ^o|1:58, ^o|1:73, ^o|1:88], [1: ^p|1:95], [0])},  {0x53| ((^S|1:1), [1: ^a|1:2], [3: ^v|1:59, ^v|1:80, ^v|1:89])},  {0x61| ((^a|1:2), [1: ^e|1:4], [3: ^v|1:59, ^v|1:80, ^v|1:89])},  {0x6e| ((^n|1:3), 0x1e8b, 2, 0, 0, [6: ^r|1:6, ^r|1:9, ^r|1:12, ^r|1:26, ^r|1:40, ^r|1:54])},  {0x65| ((^e|1:4), ^n|1:3, [1: ^c|1:5], [3: ^v|1:59, ^v|1:80, ^v|1:89])},  {0x63| ((^c|1:5), [9: ^k|1:16, ^k|1:18, ^k|1:30, ^k|1:32, ^k|1:44, ^k|1:46, ^k|1:75, ^k|1:77, ^k|1:79], [3: ^v|1:59, ^v|1:80, ^v|1:89])},  {0x72| ((^r|1:6), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:1:1", [2: ^s|1:7, ^s|1:8])},  {0x73| ((^s|1:7), @M0_CST_HA, [1: "<IP_ADDRESS>@tcp:12345:1:1"], [0], [0])},  {0x73| ((^s|1:8), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:1:1"], [0], [0])},  {0x72| ((^r|1:9), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:2:1", [2: ^s|1:10, ^s|1:11])},  {0x73| ((^s|1:10), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:2:1"], [0], [0])},  {0x73| ((^s|1:11), @M0_CST_CONFD, [1: "<IP_ADDRESS>@tcp:12345:2:1"], [0], [0])},  {0x72| ((^r|1:12), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:2:2", [9: ^s|1:13, ^s|1:14, ^s|1:19, ^s|1:20, ^s|1:21, ^s|1:22, ^s|1:23, ^s|1:24, ^s|1:25])},  {0x73| ((^s|1:13), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:14), @M0_CST_IOS, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [2: ^d|1:15, ^d|1:17])},  {0x64| ((^d|1:15), 0, 2, 1, 0x1000, 0x40000000, 0, 0, "/dev/loop0")},  {0x6b| ((^k|1:16), ^d|1:15, [2: ^v|1:59, ^v|1:89])},  {0x64| ((^d|1:17), 1, 2, 1, 0x1000, 0x40000000, 0, 0, "/dev/loop1")},  {0x6b| ((^k|1:18), ^d|1:17, [1: ^v|1:59])},  {0x73| ((^s|1:19), @M0_CST_SNS_REP, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:20), @M0_CST_SNS_REB, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:21), @M0_CST_ADDB2, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:22), @M0_CST_CAS, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [1: ^d|1:74])},  {0x73| ((^s|1:23), @M0_CST_ISCS, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:24), @M0_CST_FDMI, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [0], [0])},  {0x73| ((^s|1:25), @M0_CST_DTM0, [1: "<IP_ADDRESS>@tcp:12345:2:2"], [1: "origin:in-persistent"], [0])},  {0x72| ((^r|1:26), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:2:3", [9: ^s|1:27, ^s|1:28, ^s|1:33, ^s|1:34, ^s|1:35, ^s|1:36, ^s|1:37, ^s|1:38, ^s|1:39])},  {0x73| ((^s|1:27), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:28), @M0_CST_IOS, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [2: ^d|1:29, ^d|1:31])},  {0x64| ((^d|1:29), 2, 2, 1, 0x1000, 0x40000000, 0, 0, "/dev/loop2")},  {0x6b| ((^k|1:30), ^d|1:29, [1: ^v|1:59])},  {0x64| ((^d|1:31), 3, 2, 1, 0x1000, 0x40000000, 0, 0, "/dev/loop3")},  {0x6b| ((^k|1:32), ^d|1:31, [1: ^v|1:59])},  {0x73| ((^s|1:33), @M0_CST_SNS_REP, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:34), @M0_CST_SNS_REB, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:35), @M0_CST_ADDB2, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:36), @M0_CST_CAS, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [1: ^d|1:76])},  {0x73| ((^s|1:37), @M0_CST_ISCS, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:38), @M0_CST_FDMI, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [0], [0])},  {0x73| ((^s|1:39), @M0_CST_DTM0, [1: "<IP_ADDRESS>@tcp:12345:2:3"], [1: "origin:in-persistent"], [0])},  {0x72| ((^r|1:40), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:2:4", [9: ^s|1:41, ^s|1:42, ^s|1:47, ^s|1:48, ^s|1:49, ^s|1:50, ^s|1:51, ^s|1:52, ^s|1:53])},  {0x73| ((^s|1:41), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:42), @M0_CST_IOS, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [2: ^d|1:43, ^d|1:45])},  {0x64| ((^d|1:43), 4, 2, 1, 0x1000, 0x40000000, 0, 0, "/dev/loop4")},  {0x6b| ((^k|1:44), ^d|1:43, [1: ^v|1:59])},  {0x64| ((^d|1:45), 5, 2, 1, 0x1000, 0x10000100000, 0, 0, "/dev/loop5")},  {0x6b| ((^k|1:46), ^d|1:45, [1: ^v|1:59])},  {0x73| ((^s|1:47), @M0_CST_SNS_REP, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:48), @M0_CST_SNS_REB, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:49), @M0_CST_ADDB2, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:50), @M0_CST_CAS, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [1: ^d|1:78])},  {0x73| ((^s|1:51), @M0_CST_ISCS, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:52), @M0_CST_FDMI, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [0], [0])},  {0x73| ((^s|1:53), @M0_CST_DTM0, [1: "<IP_ADDRESS>@tcp:12345:2:4"], [1: "origin:in-persistent"], [0])},  {0x72| ((^r|1:54), [2: 1, 1], 0x8000000, 0x7a2c00, 0x7a2c00, 0x7a2c00, "<IP_ADDRESS>@tcp:12345:4:1", [2: ^s|1:55, ^s|1:56])},  {0x73| ((^s|1:55), @M0_CST_RMS, [1: "<IP_ADDRESS>@tcp:12345:4:1"], [0], [0])},  {0x73| ((^s|1:56), @M0_CST_DTM0, [1: "<IP_ADDRESS>@tcp:12345:4:1"], [1: "origin:in-volatile"], [0])},  {0x6f| ((^o|1:58), 0, [4: ^v|1:59, ^v|0x40000000000001:70, ^v|0x40000000000001:71, ^v|0x40000000000001:72])},  {0x76| ((^v|1:59), {0| (1, 1, 1, 6, [5: 0, 0, 0, 0, 1], [1: ^j|1:64])})},  {0x6a| ((^j|1:60), ^k|1:16, [0])},  {0x6a| ((^j|1:61), ^c|1:5, [6: ^j|1:60, ^j|1:65, ^j|1:66, ^j|1:67, ^j|1:68, ^j|1:69])},  {0x6a| ((^j|1:62), ^e|1:4, [1: ^j|1:61])},  {0x6a| ((^j|1:63), ^a|1:2, [1: ^j|1:62])},  {0x6a| ((^j|1:64), ^S|1:1, [1: ^j|1:63])},  {0x6a| ((^j|1:65), ^k|1:18, [0])},  {0x6a| ((^j|1:66), ^k|1:30, [0])},  {0x6a| ((^j|1:67), ^k|1:32, [0])},  {0x6a| ((^j|1:68), ^k|1:44, [0])},  {0x6a| ((^j|1:69), ^k|1:46, [0])},  {0x76| ((^v|0x40000000000001:70), {1| (0, ^v|1:59, [5: 0, 0, 0, 0, 1])})},  {0x76| ((^v|0x40000000000001:71), {1| (1, ^v|1:59, [5: 0, 0, 0, 1, 0])})},  {0x76| ((^v|0x40000000000001:72), {1| (2, ^v|1:59, [5: 0, 0, 0, 1, 1])})},  {0x6f| ((^o|1:73), 0, [1: ^v|1:80])},  {0x64| ((^d|1:74), 6, 2, 1, 1, 0x400, 0, 0, "/dev/null")},  {0x6b| ((^k|1:75), ^d|1:74, [1: ^v|1:80])},  {0x64| ((^d|1:76), 7, 2, 1, 1, 0x400, 0, 0, "/dev/null")},  {0x6b| ((^k|1:77), ^d|1:76, [1: ^v|1:80])},  {0x64| ((^d|1:78), 8, 2, 1, 1, 0x400, 0, 0, "/dev/null")},  {0x6b| ((^k|1:79), ^d|1:78, [1: ^v|1:80])},  {0x76| ((^v|1:80), {0| (1, 1, 1, 3, [5: 0, 0, 0, 1, 0], [1: ^j|1:85])})},  {0x6a| ((^j|1:81), ^k|1:75, [0])},  {0x6a| ((^j|1:82), ^c|1:5, [3: ^j|1:81, ^j|1:86, ^j|1:87])},  {0x6a| ((^j|1:83), ^e|1:4, [1: ^j|1:82])},  {0x6a| ((^j|1:84), ^a|1:2, [1: ^j|1:83])},  {0x6a| ((^j|1:85), ^S|1:1, [1: ^j|1:84])},  {0x6a| ((^j|1:86), ^k|1:77, [0])},  {0x6a| ((^j|1:87), ^k|1:79, [0])},  {0x6f| ((^o|1:88), 0, [1: ^v|1:89])},  {0x76| ((^v|1:89), {0| (1, 0, 0, 1, [5: 0, 0, 0, 1, 0], [1: ^j|1:94])})},  {0x6a| ((^j|1:90), ^k|1:16, [0])},  {0x6a| ((^j|1:91), ^c|1:5, [1: ^j|1:90])},  {0x6a| ((^j|1:92), ^e|1:4, [1: ^j|1:91])},  {0x6a| ((^j|1:93), ^a|1:2, [1: ^j|1:92])},  {0x6a| ((^j|1:94), ^S|1:1, [1: ^j|1:93])},  {0x70| ((^p|1:95), [3: ^o|1:58, ^o|1:73, ^o|1:88])}]

confd.xc.txt


Bump to v0.22.1

This needs to wait for #2684 though, right?  Just getting prepped here...

This needs to wait for #2684 though, right? Just getting prepped here...

Exactly!


Fixed popper dot command

No more prompts for secrets during popper dot.

@ivotron Can't understand why the build failed in this case ?

Can't understand why the build failed in this case ?

not sure either... hmm, maybe a transient issue?

Can't understand why the build failed in this case ?

not sure either... hmm, maybe a transient issue?

Ya maybe

@ivotron Somehow the arrangement of imports again got disturbed, so fixed that.


Unable to enable Performance diagnostics in SLES 12 SP4 with the error message "Unsupported operating system: SLES 12.4". However, SLES 12 SP4 is in the supported Linux list.

I check the status of the extension, AzurePerformanceDiagnosticsLinux, and find it’s “Provisioning failed”. This extension is used by the feature, Performance diagnostics. The error message is “Unsupported operating system: SLES 12.4”. The detailed error message can be checked in the file, /var/log/azure/Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux/extension.log.
2021/01/15 07:12:14 [Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux-1.1.17] sequence number is 0
2021/01/15 07:12:14 [Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux-1.1.17] setting file path is/var/lib/waagent/Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux-1.1.17/config/0.settings
…
2021/01/15 07:12:16 [Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux-1.1.17] Config decoded correctly.
2021/01/15 07:12:16 [Microsoft.Azure.Performance.Diagnostics.AzurePerformanceDiagnosticsLinux-1.1.17] Enable,failed,50,Unsupported operating system: SLES 12.4
However, this OS is under the supported list.
https://docs.microsoft.com/en-us/azure/virtual-machines/troubleshooting/performance-diagnostics#linux
In additional, the tool, perfInsights, can still work in SLES 12.4.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 70ed8599-3bc1-6246-ccfa-4478a3061d56
Version Independent ID: f7019695-1c99-500f-e1fb-de8cc2280011
Content: Performance diagnostics for Azure virtual machines - Azure Virtual Machines
Content Source: articles/virtual-machines/troubleshooting/performance-diagnostics.md
Service: virtual-machines-windows
GitHub Login: @anandhms
Microsoft Alias: anandh

@SnoWolfT we'll review your feedback and get back to you shortly. Thanks.

@SnoWolfT we'll review your feedback and get back to you shortly. Thanks.

Hi @SnoWolfT , Thank you for using Azure Performance Diagnostics and for reporting this issue. Our team is working on a fix. We expect to release updated versions (with the fix) on the Azure Portal and on the Microsoft Download center in a few days. I will update this thread when they are released. Thank you once again. Best Regards, Pooja Harjani

Hi @SnoWolfT , Thank you for using Azure Performance Diagnostics and for reporting this issue. Our team is working on a fix. We expect to release updated versions (with the fix) on the Azure Portal and on the Microsoft Download center in a few days. I will update this thread when they are released. Thank you once again. Best Regards, Pooja Harjani

Hi @SnoWolfT, Our team has released the updated versions of Azure Performance Diagnostics (PerfInsights) on the Azure Portal and on the Microsoft Download Center. You would now be able to use it on SLES 12 SP4 and other supported operating systems via both the Azure Portal and the download center. If you have any feedback, please let us know. We appreciate you taking the time to report the issue and thank you for helping us improve our product. Best Regards, Pooja Harjani

Hi @SnoWolfT, Our team has released the updated versions of Azure Performance Diagnostics (PerfInsights) on the Azure Portal and on the Microsoft Download Center. You would now be able to use it on SLES 12 SP4 and other supported operating systems via both the Azure Portal and the download center. If you have any feedback, please let us know. We appreciate you taking the time to report the issue and thank you for helping us improve our product. Best Regards, Pooja Harjani

@Pooja-Harjani Thanks for sharing the update.
@SnoWolfT Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please let us know. I will reopen it and we will continue the discussion.

@Pooja-Harjani Thanks for sharing the update.
@SnoWolfT Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please let us know. I will reopen it and we will continue the discussion.


Improve/fix a few things

Add .nvmrc for convenience
Fix gulpfile syntax for Gulp v4 upgrade
Remove extraneous type alias
Upgrade typedoc

Done, thanks for the extra push to do that @fainashalts!


Documentation VB.NET Tuple Returns incorrect

In the code snippers of the documentation for VB.NET about Tuples, I found a small error.
Snippet 3 outputs the original string that is being parsed, rather than the output. It should output the result, as it is also being outputted in snippet 1 (the "original" version, before using the new language features). Another minor thing : the variable name of the "to be parsed string" maybe should match the original version?
Code to be changed:
    Private Sub MethodCallWithTuple()
        ' <Snippet3>
        Dim number As String = "123,456"
        Dim result = ParseInteger(number)
        Console.WriteLine($"{IIf(result.Success, $"Success: {number:N0}", "Failure")}")
        Console.ReadLine()
        '      Output: Success: 123,456
        ' </Snippet3>
    End Sub

Into:
    Private Sub MethodCallWithTuple()
        ' <Snippet3>
        Dim numericString As String = "123,456"
        Dim result = ParseInteger(numericString)
        Console.WriteLine($"{IIf(result.Success, $"Success: {result.Number:N0}", "Failure")}")
        Console.ReadLine()
        '      Output: Success: 123,456
        ' </Snippet3>
    End Sub

Also : sample does not work when using a non-US culture. Maybe specify in Snippet 2 invariant culture info?
Code to be changed:
' <Snippet2>
Imports System.Globalization

Public Module NumericLibrary
    Public Function ParseInteger(value As String) As (Success As Boolean, Number As Int32)
        Dim number As Integer
        Return (Int32.TryParse(value, NumberStyles.Any, Nothing, number), number)
    End Function
End Module
' </Snippet2>

Into:
' <Snippet2>
Imports System.Globalization

Public Module NumericLibrary
    Public Function ParseInteger(value As String) As (Success As Boolean, Number As Int32)
        Dim number As Integer
        Return (Int32.TryParse(value, NumberStyles.Any, CultureInfo.InvariantCulture, number), number)
    End Function
End Module
' </Snippet2>

Do you want to create a Pull Request with these changes?

Currently I cannot sign the CLA, as I first neet to be approved by my company's legal department (which can take a long time). For that, I had to make an issue ticket (because I don't want this "mistake" to be lost).
I'm sorry for the inconvenience.

@Styxxy thanks for submitting PR #3166 and starting the process for the CLA.  That PR was small enough that a CLA wasn't necessary. I've already reviewed and merged it.

@BillWagner Thanks! I opened the issue as I thought that I needed a CLA. But I initiated the process anywa for maybe future pull requests.


A way to enforce MFA when using oauth2/v2.0/authorize or change authorize endpoint

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.0.2
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
3.0.2
Public or Confidential Client?
Public
Description
I'm trying to enforce MFA during the /authorize request using amr_values=ngcmfa, but I get the following error, since it's not supported in the v2.0 of Microsoft Identity Platform.

AADSTS901002: The 'amr_values' request parameter is not supported.

Is there a way to enforce my user to have performed MFA, or is there a way to use the v1.0 endpoints in this library?
MSAL Configuration
auth: {
    clientId: '<client-id>',
    authority: 'https://login.microsoftonline.com/common',
    redirectUri: `${location.origin}`,
  },
  cache: {
    cacheLocation: 'localStorage',
    storeAuthStateInCookie: false
  },
  system: {
    allowNativeBroker: false
  }

Relevant Code Snippets
No response
Identity Provider
None
Source
External (Customer)

MFA enforcement should be done with Conditional Access policies rather than request parameters. We are unfortunately not experts on this so I would recommend opening a support ticket if you need assistance.


Adding S3 nuke support

This PR adds support to delete S3 buckets as requested in https://github.com/gruntwork-io/cloud-nuke/issues/58
It ensures that the AWS S3 list bucket operation - which lists all buckets irrespective of region - is not called multiple times for each region and uses cached entries as highlighted in the above issue discussion.
Deletion also uses WaitUntilBucketNotExists to ensure bucket is deleted. It also supports edge cases where in bucket is deleted by some other means after listing but before deletion.
Demo:

Added s3 to list of resources

go run main.go aws --list-resource-types | grep s3

s3

Run S3 related tests:

go test -run S3 -v ./...

=== RUN   TestListS3Buckets
time="2020-02-29T22:52:35+08:00" level=info msg="Random region chosen: ap-northeast-1"
time="2020-02-29T22:52:42+08:00" level=info msg="Awaiting creation - Bucket: cloud-nuke-test-gnd7gn"
time="2020-02-29T22:52:47+08:00" level=info msg="Deleting - 1 S3 Buckets in region ap-northeast-1"
time="2020-02-29T22:52:47+08:00" level=info msg="Deleting - 1/1 - S3 Bucket: cloud-nuke-test-gnd7gn"
time="2020-02-29T22:52:48+08:00" level=info msg="Awaiting deletion - 1/1 - Bucket: cloud-nuke-test-gnd7gn"
time="2020-02-29T22:52:48+08:00" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-gnd7gn - deleted"
--- PASS: TestListS3Buckets (13.35s)

TestListS3Buckets - creates, verifies S3 bucket existence, deletes and verifies S3 bucket non existence.
=== RUN   TestNukeS3Buckets
time="2020-02-29T22:52:52+08:00" level=info msg="Random region chosen: ca-central-1"
time="2020-02-29T22:52:55+08:00" level=info msg="Awaiting creation - Bucket: cloud-nuke-test-npymlv"
time="2020-02-29T22:52:56+08:00" level=info msg="Deleting - 1 S3 Buckets in region ca-central-1"
time="2020-02-29T22:52:56+08:00" level=info msg="Deleting - 1/1 - S3 Bucket: cloud-nuke-test-npymlv"
time="2020-02-29T22:52:57+08:00" level=info msg="Awaiting deletion - 1/1 - Bucket: cloud-nuke-test-npymlv"
time="2020-02-29T22:52:57+08:00" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-npymlv - deleted"
time="2020-02-29T22:53:14+08:00" level=info msg="Deleting - 1 S3 Buckets in region ca-central-1"
time="2020-02-29T22:53:15+08:00" level=info msg="S3 Bucket cloud-nuke-test-npymlv exists check error code - NotFound"
time="2020-02-29T22:53:15+08:00" level=warning msg="Failed to find bucket - cloud-nuke-test-npymlv - ignoring as bucket might be deleted."
--- PASS: TestNukeS3Buckets (27.44s)
PASS

TestNukeS3Buckets - creates, deletes and verifies S3 bucket deletion - it also tries to delete the same bucket twice to try out the case of bucket present during listing but deleted by some other means before deletion through cloud-nuke.

Run S3 deletion with dry run:

go run main.go aws --resource-type s3 --region ap-northeast-1 --dry-run

INFO[2020-02-29T23:00:41+08:00] Retrieving active AWS resources in [ap-northeast-1]
INFO[2020-02-29T23:00:41+08:00] Checking region [1/1]: ap-northeast-1
INFO[2020-02-29T23:00:46+08:00] The following AWS resources are going to be nuked:
INFO[2020-02-29T23:00:46+08:00] * test-bucket-1-ap-northeast-1

INFO[2020-02-29T23:00:46+08:00] * test-bucket-2-ap-northeast-1

INFO[2020-02-29T23:00:46+08:00] Not taking any action as dry-run set to true.

Run S3 deletion without dry-run:

go run main.go aws --resource-type s3 --region ap-northeast-1

INFO[2020-02-29T23:00:41+08:00] Retrieving active AWS resources in [ap-northeast-1]
INFO[2020-02-29T23:00:41+08:00] Checking region [1/1]: ap-northeast-1
INFO[2020-02-29T23:00:46+08:00] The following AWS resources are going to be nuked:
INFO[2020-02-29T23:00:46+08:00] * s3-test-bucket-1-ap-northeast-1

INFO[2020-02-29T23:00:46+08:00] * s3-test-bucket-2-ap-northeast-1

THE NEXT STEPS ARE DESTRUCTIVE AND COMPLETELY IRREVERSIBLE, PROCEED WITH CAUTION!!!

Are you sure you want to nuke all listed resources? Enter 'nuke' to confirm (or exit with ^C): nuke

INFO[2020-02-29T23:01:06+08:00] Terminating 2 resources in batches
INFO[2020-02-29T23:01:06+08:00] Deleting - 2 S3 Buckets in region ap-northeast-1
INFO[2020-02-29T23:01:07+08:00] Deleting - 1/2 - S3 Bucket: test-bucket-1
INFO[2020-02-29T23:01:08+08:00] Awaiting deletion - 1/2 - Bucket: test-bucket-1
INFO[2020-02-29T23:01:08+08:00] [OK] - 1/2 - Bucket: test-bucket-1 - deleted
INFO[2020-02-29T23:01:08+08:00] Deleting - 2/2 - S3 Bucket: test-bucket-2
INFO[2020-02-29T23:01:09+08:00] Awaiting deletion - 2/2 - Bucket: test-bucket-2
INFO[2020-02-29T23:01:09+08:00] [OK] - 2/2 - Bucket: test-bucket-2 - deleted
INFO[2020-02-29T23:01:09+08:00] [OK] - 2/2 - S3 bucket(s) deleted in ap-northeast-1

Thanks for the feedback @yorinasub17 and @brikis98. I will make the changes and update this thread.

@yorinasub17 @brikis98 - updated as per feedback with 2 items pending. Highlights:
Done:

Refactored s3_test.go to have separate tests for nuking empty bucket, bucket with items.
Refactored s3.go accordingly and cleaned up main nukeAllS3Buckets function to call nukeAllS3BucketObjects and nukeEmptyS3Bucket
Updated aws.go as per nit-pick feedback.

Pending:

Current code does not support deleting versioned bucket with objects. I couldn't find a good batch delete way for versioned buckets. Will probably detect bucket type and use right type of nuking.
Preventing deletion based on hard coded tag means adding metadata to the buckets returned by getAllS3Buckets to know bucket properties. As it is to find if bucket is versioned or not, we will have to add that metadata.

Will work on the pending items in the next few days and update.

Updated codebase as per the above feedback. Deleting S3 buckets has the following features:

Support to delete empty, non-empty and versioned buckets.
Ability to filter out buckets tagged with "cloud-nuke-excluded=true" flag.
Batched deletion and deletion as per max AWS limits (1000 objects per deletion run). The batched deletion number is internal to the code and is not exposed to the end user.
Deleting buckets having specific substring. This feature is also internal to the code and is not exposed to the end user. It was added to make testing easier.

All the above features have been verified via the following test cases. All the tests try to ensure deletion of the bucket in the end - hence there are some messages which are errors related to deleting duplicate buckets but they are not tied to test failure.

List S3 buckets for deletion when no filter tag (cloud-nuke-excludeded=true) is present:

=== RUN   TestListEmptyS3BucketWithoutFilterTag
time="2020-03-10T16:23:31+05:30" level=info msg="Random region chosen: us-east-2"
time="2020-03-10T16:23:33+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:23:38+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:23:38+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - empty - skipping object deletion"
time="2020-03-10T16:23:39+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
--- PASS: TestListEmptyS3BucketWithoutFilterTag

List S3 buckets for deletion when filter tag is present:

=== RUN   TestListEmptyS3BucketWithFilterTag
time="2020-03-10T16:23:41+05:30" level=info msg="Random region chosen: ap-northeast-1"
time="2020-03-10T16:23:42+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:23:46+05:30" level=info msg="Skipping - Bucket cloud-nuke-test-xxxx - matched tag filter"
time="2020-03-10T16:23:46+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:23:47+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - empty - skipping object deletion"
time="2020-03-10T16:23:48+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
--- PASS: TestListEmptyS3BucketWithFilterTag

Deleting empty bucket:

=== RUN   TestNukeEmptyS3Bucket
time="2020-03-10T16:23:49+05:30" level=info msg="Random region chosen: us-east-2"
time="2020-03-10T16:23:49+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:23:52+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:23:53+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - empty - skipping object deletion"
time="2020-03-10T16:23:54+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:23:54+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:23:54+05:30" level=error msg="[Failed] - 1/1 - Bucket: cloud-nuke-test-xxxx - object deletion error - NoSuchBucket: The specified bucket does not exist\n\tstatus code: 404, request id: xxxx, host id: xxxx"
--- PASS: TestNukeEmptyS3Bucket

Deleting non-empty bucket - without any object versioning - deletion batch size (1000) > number of objects (10):

=== RUN   TestNukeS3BucketWithoutVersioningAllObjects
time="2020-03-10T16:23:59+05:30" level=info msg="Random region chosen: sa-east-1"
time="2020-03-10T16:23:59+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:24:03+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 0-0"
time="2020-03-10T16:24:03+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 0-1"
time="2020-03-10T16:24:03+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 0-2"
time="2020-03-10T16:24:04+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f3.txt - content: 0-3"
.
.
time="2020-03-10T16:24:06+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 0-9"
time="2020-03-10T16:24:06+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:08+05:30" level=info msg="Deleting - Bucket: cloud-nuke-test-xxxx - objects: 10"
time="2020-03-10T16:24:09+05:30" level=info msg="[OK] - 1-10 objects of batch 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:11+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:11+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:12+05:30" level=error msg="[Failed] - 1/1 - Bucket: cloud-nuke-test-xxxx - object deletion error - NoSuchBucket: The specified bucket does not exist\n\tstatus code: 404, request id: xxxx, host id: xxxx"
--- PASS: TestNukeS3BucketWithoutVersioningAllObjects

Deleting non-empty bucket - without any object versioning - deletion batch size (2) < number of objects (10):

=== RUN   TestNukeS3BucketWithoutVersioningBatchObjects
time="2020-03-10T16:24:14+05:30" level=info msg="Random region chosen: eu-west-1"
time="2020-03-10T16:24:14+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:24:17+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 0-0"
time="2020-03-10T16:24:17+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 0-1"
time="2020-03-10T16:24:18+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 0-2"
time="2020-03-10T16:24:18+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f3.txt - content: 0-3"
.
.
.
time="2020-03-10T16:24:21+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 0-9"
time="2020-03-10T16:24:21+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:23+05:30" level=info msg="Deleting - Bucket: cloud-nuke-test-xxxx - objects: 10"
time="2020-03-10T16:24:23+05:30" level=info msg="[OK] - 1-2 objects of batch 1/5 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:25+05:30" level=info msg="[OK] - 3-4 objects of batch 2/5 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:27+05:30" level=info msg="[OK] - 5-6 objects of batch 3/5 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:28+05:30" level=info msg="[OK] - 7-8 objects of batch 4/5 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:29+05:30" level=info msg="[OK] - 9-10 objects of batch 5/5 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:31+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:32+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:32+05:30" level=error msg="[Failed] - 1/1 - Bucket: cloud-nuke-test-xxxx - object deletion error - NoSuchBucket: The specified bucket does not exist\n\tstatus code: 404, request id: xxxx, host id: xxxxx"
--- PASS: TestNukeS3BucketWithoutVersioningBatchObjects (20.60s)

Deleting non-empty bucket - with object versioning - deletion batch size (1000) > number of objects (30):

Versioned objects are created by add the same object multiple times with different content.
=== RUN   TestNukeS3BucketWithVersioningAllObjects
time="2020-03-10T16:24:33+05:30" level=info msg="Random region chosen: ca-central-1"
time="2020-03-10T16:24:33+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"
time="2020-03-10T16:24:37+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 0-0"
time="2020-03-10T16:24:38+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 0-1"
time="2020-03-10T16:24:38+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 0-2"
.
.
time="2020-03-10T16:24:41+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 0-9"

time="2020-03-10T16:24:41+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 1-0"
time="2020-03-10T16:24:41+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 1-1"
time="2020-03-10T16:24:42+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 1-2"
.
.
time="2020-03-10T16:24:45+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 1-9"

time="2020-03-10T16:24:45+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 2-0"
time="2020-03-10T16:24:45+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 2-1"
time="2020-03-10T16:24:46+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 2-2"
.
.
time="2020-03-10T16:24:48+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 2-9"

time="2020-03-10T16:24:49+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:54+05:30" level=info msg="Deleting - Bucket: cloud-nuke-test-xxxx - objects: 30"
time="2020-03-10T16:24:55+05:30" level=info msg="[OK] - 1-30 objects of batch 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:57+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:24:58+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:24:58+05:30" level=error msg="[Failed] - 1/1 - Bucket: cloud-nuke-test-xxxx - object deletion error - NoSuchBucket: The specified bucket does not exist\n\tstatus code: 404, request id: xxxx, host id: xxxx"
--- PASS: TestNukeS3BucketWithVersioningAllObjects

Deleting non-empty bucket - with object versioning - deletion batch size (3) < number of objects (30):

=== RUN   TestNukeS3BucketWithVersioningBatchObjects
time="2020-03-10T16:25:00+05:30" level=info msg="Random region chosen: us-east-2"
time="2020-03-10T16:25:00+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - creating"

time="2020-03-10T16:25:04+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 0-0"
time="2020-03-10T16:25:04+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 0-1"
time="2020-03-10T16:25:04+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 0-2"
.
.
time="2020-03-10T16:25:07+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 0-9"

time="2020-03-10T16:25:08+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 1-0"
time="2020-03-10T16:25:08+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 1-1"
time="2020-03-10T16:25:08+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 1-2"
.
.
time="2020-03-10T16:25:11+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 1-9"

time="2020-03-10T16:25:12+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f0.txt - content: 2-0"
time="2020-03-10T16:25:12+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f1.txt - content: 2-1"
time="2020-03-10T16:25:12+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f2.txt - content: 2-2"
.
.
time="2020-03-10T16:25:15+05:30" level=info msg="Bucket: cloud-nuke-test-xxxx - adding object: l1/l2/l3/f9.txt - content: 2-9"

time="2020-03-10T16:25:16+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:25:22+05:30" level=info msg="Deleting - Bucket: cloud-nuke-test-xxxx - objects: 30"

time="2020-03-10T16:25:23+05:30" level=info msg="[OK] - 1-3 objects of batch 1/10 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:25:24+05:30" level=info msg="[OK] - 4-6 objects of batch 2/10 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:25:26+05:30" level=info msg="[OK] - 7-9 objects of batch 3/10 - Bucket: cloud-nuke-test-xxxx - deleted"
.
.
time="2020-03-10T16:25:37+05:30" level=info msg="[OK] - 28-30 objects of batch 10/10 - Bucket: cloud-nuke-test-xxxx - deleted"

time="2020-03-10T16:25:39+05:30" level=info msg="[OK] - 1/1 - Bucket: cloud-nuke-test-xxxx - deleted"
time="2020-03-10T16:25:41+05:30" level=info msg="Deleting - 1 S3 Buckets in region us-east-2"
time="2020-03-10T16:25:41+05:30" level=error msg="[Failed] - 1/1 - Bucket: cloud-nuke-test-xxxx - object deletion error - NoSuchBucket: The specified bucket does not exist\n\tstatus code: 404, request id: xxxx, host id: xxxx"
--- PASS: TestNukeS3BucketWithVersioningBatchObjects

@brikis98 @yorinasub17  - can you please review the code and let me know if this looks good?

@yorinasub17 @brikis98  - squashed the commits related to DeleteMarker, shouldIncludeBucket and single call for getting all objects and versions as per feedback. Can you please review it and let me know if it looks good?

Found a bug - if the passed in session object to getAllS3Buckets is different from bucket's target region - then the call to get bucket tags fails because it expects the S3 client to be in target region. Hence added code to maintain an internal cache of reusable per region s3 clients while collecting the buckets and updated test cases to pass in random sessions to test scenarios where default region != target bucket region. This bug was undetected till now because in the test cases we were passing in sessions which were same as bucket's target region. Also renamed  session var to awsSession to avoid confusion with the session package of the SDK.
Will squash the fix once reviewed.

Thanks for working through the fixes! I am a bit buried right now to take a look, but will try to carve out time before the end of the week. Thanks for your patience!

@brikis98 @yorinasub17 - just wanted to follow up on this and wanted to know if it looks good. Btw, checked AWS landing zone - looks great.

@saurabh-hirani sorry haven't had a chance to take a look yet, but this hasn't dropped off my radar. Should have time to look in the next few days.

@yorinasub17 updated as per feedback. Please check the latest commit and if it looks good - I will squash the changes so that it can be merged.

No need to squash! This looks ready to merge once the tests pass, but as mentioned this will break our environment so I needed to extend it in https://github.com/gruntwork-io/cloud-nuke/pull/101.
Note that this PR will autoclose as merged when that PR merges (because all the commits are still there).

Thanks for sticking with this! This is now merged and released as https://github.com/gruntwork-io/cloud-nuke/releases/tag/v0.1.17. Binaries will show up shortly.

Thanks for the feedback and code reviews @yorinasub17 @brikis98 @zackproser!

Thanks for the feedback and code reviews @yorinasub17 @brikis98 @zackproser!

Thank you, @saurabh-hirani ! :clap:


Your request to provision "Microsoft 365 learning pathways" template failed!

correlation ID: 85c2cf72-da4d-4042-b4e4-6d9e93d9b238

Hi, Thanks for your feedback. I'm closing this item because it is now outdated.


[SPARK-25944][R][BUILD] AppVeyor change to latest R version (3.6.0)

What changes were proposed in this pull request?
R 3.5.1 is released 2019-04-26. This PR targets to change R version from 3.5.1 to 3.6.0 in AppVeyor.
How was this patch tested?
AppVeyor

Test build #105810 has started for PR 24716 at commit 5584dd6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11066/
Test PASSed.

Test build #105810 has finished for PR 24716 at commit 5584dd6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105810/
Test PASSed.

Test build #105832 has started for PR 24716 at commit 5b64c89.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11088/
Test PASSed.

Test build #105832 has finished for PR 24716 at commit 5b64c89.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105832/
Test PASSed.

BTW, @HyukjinKwon . Could you fix the PR description?

R 3.5.1 is released 2019-04-26.

It seems to be a typo of 3.6.0 because

R version 3.6.0 (Planting of a Tree) has been released on 2019-04-26.
R version 3.5.3 (Great Truth) has been released on 2019-03-11.

Oops, thanks

Merged to master.


Memory error of adj_mat.todense()

Dear programmer, sorry to interrupt you but, I have a problem with a large gene interaction network and its corresponding  adjacency matrix. The error that occurs is the following:
Traceback (most recent call last):
  File "/home/pyNBS/network_propagation.py", line 14, in normalize_network
    subgraph_norm = normalize_network(network, symmetric_norm=False)
  File "/home/pyNBS/network_propagation.py", line 17, in normalize_network
    tmp_dense = adj_mat.todense()
  File "/home/anaconda2/lib/python2.7/site-packages/scipy/sparse/base.py", line 721, in todense
    return np.asmatrix(self.toarray(order=order, out=out))
  File "/home/anaconda2/lib/python2.7/site-packages/scipy/sparse/compressed.py", line 964, in toarray
    return self.tocoo(copy=False).toarray(order=order, out=out)
  File "/home/anaconda2/lib/python2.7/site-packages/scipy/sparse/coo.py", line 252, in toarray
    B = self._process_toarray_args(order, out)
  File "/home/anaconda2/lib/python2.7/site-packages/scipy/sparse/base.py", line 1039, in _process_toarray_args
    return np.zeros(self.shape, dtype=self.dtype, order=order)
MemoryError

Using the commands:
print type(adj_mat)
print adj_mat.shape

I retrieved that the adj_mat is:
<class 'scipy.sparse.csr.csr_matrix'>
(119290, 119290)

The packages of interest are the following (attached there is the full list of packages):
packages_conda.txt
scipy                     0.19.0              np112py27_0
numpy                     1.12.1                   py27_0
networkx                  1.11                     py27_0
I think that the matrix that should be returned by toDense() should require at least 113GB of memory that I do not have. In case it wouldn't be possible to solve the problem using at most 64GB of ram, should be possible to involve the space in the hard disk?

Hi Luca,
I am sorry about this issue. The reason we convert the matrix to a dense array here is that in certain cases it may improve the speed of some of the matrix multiplications performed in the algorithm if you have a machine with multiple threads that can be utilized. However, I believe it is possible to keep the matrix as a sparse object to perform the matrix multiplications, but I am unsure if the matrix inversion that will need to take place is possible on that sparse matrix. Additionally, the sparse object is useful for the adjacency matrix at first (generally biological networks are sparse), however, after the propagation step, the matrix will become dense. I know this is probably not the answer you are looking for, my best suggestion at this time is to find a bigger machine (unfortunately), unless someone else has a better solution...


Websocket getcontext didn't return the right ptr?

std::shared_ptr shared = std::make_shared();
wsConnPtr->setContext(shared);
the ptr of shared  is ->0x7fffec007460
after this ,when I try to get the context
auto shared = wsConnPtr->getContextRef<std::shared_ptr>();
in debug, I saw the wsConnPtr hold the right ptr;
but now,the shared ptr is ->0x7fffec006af0,the returned shared is a new object ,and its datas are all initial

the same as getContext


If both metadata.rb and metadata.json are present in a cookbook we should show metadata.rb

Describe the bug
metadata.rb is the human readable form of the cookbook metadata. We parse this into metdata.json and upload both depending on tools and chef version. If both are present we should not be displaying the json variety since that's not meant for the user.
To Reproduce
Steps to reproduce the behavior:

Using a modern (last 2-3 years) version of knife upload a cookbook.
From the automate UI

Select infrastructure
Select Chef Infra Servers
Select the server
Select the org
Select the cookbook tab
Select that cookbook

Expected behavior
Only metadata.rb should be displayed
Screenshots

Versions (please complete the following information):

OS: macOS
Browser Firefox
Automate Build Number<PHONE_NUMBER>1414

Point to Note:
Manage still shows both the files.
This is a new business logic and not a bug.

@kalroy this is a bug in Manage as well. We should not be judging bug or not based on Manage behavior.


[Feature] Refactor Login Success Response With More Data

Feature Idea
Ever since the transition from a bearer token to server side cookies, the actual login response of the microservice does not return any useful data the can be used client side, at least for basic information. Because the cookies are HTTPOnly, data extraction is not possible.
Feature Need
The client side of the system needs at least some basic information about the user, similar to what's actually contain on the JWT tokens themselves.
Potential Solution (Optional)
1: Return a new DTO on login success with data such as "Email", "Username", "ID", and perhaps roles and expiration time.
2: Another good idea is to implement potentially a cookie (that is not HTTPOnly) to simply represent if a user is logged in.

It did just occur to me that I could reuse the clients credentials (username, email) on success but for the sake of consistency, design, and reliability I shall continue with this solution.


Orchard.Workflows - No IsDirty check when navigating away from workflow with unsaved changes

v1.9.1 / master
When I have unsaved changes on the workflow and click on sidebar links or notification links (like you need to setup smtp) the page navigates away without prompting me to save my workflow changes.
It should have an "are you sure?" prompt like Orchard.Layouts has.

I thought we already had that.

There is a message saying you have to save when you make a change.


Update readme to help new developers

In this PR:

[x] Tidy up the heading levels so that it follows in order
[x] Put all the badges together in group
[x] Add a note for new developers to run locally without running the API service locally

jazakAllah khairan


Problems with feign and Oauth2RestTemplate

When the default RestTemplate send request is used, zipkin can track my request link. However, when using Oauth2RestTemplate to send a request to an Oauth2 protected service, zipkin cannot track it. And when using Feign, it is also impossible to track.

Can you tell us what versions you are using? How is the OAuth2RestTemplate created? We need more details.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Update pruning documentation in network-spec

See #3495.

Some of it was updated in #3309 . #3495 It is still needed to be taken into account.

I think this can be closed, no?

The following paragraph:
To solve this problem, when a connection is transitioned from DuplexState to InboundState Duplex (via
DemotedToColdDuplex Local ), for example, the connection manager will check if the server hard limit was exceeded. If
that happened, the connection manager will reset an arbitrary connection (with some preference).

should be rephrased as:
To solve this problem, in any of the above transitions the connection manager will check ...

There might be other places as well which require a review.


winston transport.console error on opening file

const { createLogger, transports } = require('winston');

const logger = createLogger({
    transports: [new transports.Console()],
    levels: {
        emerg: 0,
        alert: 1,
        crit: 2,
        error: 3,
        warning: 4,
        notice: 5,
        info: 6,
        debug: 7
    }
})

new transport.Console gives me this error
Module build failed: Error: ENOENT: no such file or directory, open '~/project/node_modules/winston/lib/winston/transports.js

Maybe the dependencies weren't installed correctly? The transports.js existed in the 2.x.x version of winston, but it doesn't exists in the 3.x.x versions.

Yes this seems like an npm install issue. If it persists please reach out to npm support folks on Twitter.


Static milestone information

Is your feature request related to a problem? Please describe.
First draft of resume milestones to include.
Describe the solution you'd like
Static text documents with descriptions of life to be displayed in the game. Structure it like a timeline with timestamps or keys to access specific text parts easily.
Additional context
Consider the format and structure for easy reading.

Blocked by #6


LAB 04, Exercise 2, Task 2, VPN Gateway deployment fails "Basic IP configuration for VPN Virtual Network Gateways is not supported"

Module/Lab: 04
Exercise: 02
Task: 02
Step: 03
Description of issue
Shortly after clicking the Create button to create an Azure Network Adapter in WAC I receive the following error:
Short error: Basic IP configuration for VPN Virtual Network Gateways is not supported.
In the error message is provided a link to documentation where it mentions that Basic IP is not supported except for Basic SKU gateways. It seems that Microsoft once again changed a requirement and labs as always are slow to change.
Please see full error in screenshot below.
Relevant screenshots

Hi, Thanks for reporting the issue. We'll investigate it and get back to you with a solution as soon as possible.