.NET 5 update progress

The update to .NET 5 has been a long journey so far. Development is mostly done in the feat/net5 branch.

[x] Update TFM to net5.0
[x] Update GitHub actions to build the .NET 5 version
[x] Remove all Fody references from the repository (Fody is no longer needed as it's being replaced with single file publishing)
[x] Use single file publishing
[x] Integrate DebugHelper code into the main Blish HUD project (and remove the separate executable build) (done separately in #427)
[x] Decide what to do with CSCore and if it's removed, update the code to no longer depend on it (CSCore doesn't have a .NET Standard/Core build, and while it technically should still work, it does still depend on .NET Framework, despite Blish HUD itself being fully .NET 5 instead)
[ ] Check (and fix if necessary) what's causing the version to be included in the settings.json file, and causing the local VS build to throw an exception (and discard the settings) when it's loaded after using the CI build at least once (some settings.json overhaul is being done on the net5-settings branch, a.k.a. moving away from Newtonsoft.Json to System.Text.Json)
[ ] Decide whether to use the portable build, or the self-contained build (and if trimming is an option, albeit still kinda experimental)
[ ] Testing...
[ ] Update module template to use .NET 5
[ ] Maybe find a way to support modules made in .NET Framework 4.8 for backwards compatibility?
[ ] Probably update to .NET 6

Do we want to try and backport some of these changes into the framework version in preparation?  For example, embedding the debug hook stuff or including the setting changes?

I think that's possible, unless I did something very .NET 5 dependent that I can't remember at the moment. We can try to backport the DebugHelper, CSCore (once that's done, or before this) and the settings JSON. Do you have similar stuff in mind?

I had a look at swapping the CSCore-dependent code to use NAudio.Wasapi - It's a fairly painless swap as they expose basically the same APIs. The code is at https://github.com/eksime/Blish-HUD/tree/feat/naudio if it's any use for task 6.

Dang, that's pretty sweet!  Would definitely be a great way to get this process moving again since it was originally going to mean ripping out quite a bit and that was a bit tiring to think about.  😅

I can submit a PR if wanted - I wasn't 100% sure on the AudioEndpointNotificationReceiver class, or whether it'd be better to implement IMMNotificationClient directly on the AudioIntegration service 🤔
I've also just seen that NAudio was removed a while back in favour of CSCore, was there a reason naudio wasn't suitable for other stuff?

If we can get this rolling, that would be awesome 😄

I can submit a PR if wanted - I wasn't 100% sure on the AudioEndpointNotificationReceiver class, or whether it'd be better to implement IMMNotificationClient directly on the AudioIntegration service 🤔 I've also just seen that NAudio was removed a while back in favour of CSCore, was there a reason naudio wasn't suitable for other stuff?

I like what you ended up doing.  We only moved to CSCore as I was unfamiliar with naudio having what we needed at the time.

Am I correct in understanding that a successful migration to .NET 5 would mean support for running BlishHUD on Linux?  I believe .NET 5 supports Linux, but I'm both overwhelmingly confused by the versioning conventions of .NET, and also unsure if there would be more work required beyond targeting .NET 5 to get Linux compatibility.

Am I correct in understanding that a successful migration to .NET 5 would mean support for running BlishHUD on Linux? I believe .NET 5 supports Linux, but I'm both overwhelmingly confused by the versioning conventions of .NET, and also unsure if there would be more work required beyond targeting .NET 5 to get Linux compatibility.

It's certainly a first step in native support without needing to rely on Wine, but the "overlay" aspect of Blish HUD that allows us to draw on a transparent window currently utilizes some WinApi crimes which would need adapted quite a bit before it'd be usable on Linux.
This is in fact the current problem when using Blish HUD via Wine.  It should actually run just fine (when we've disabled the audio pipeline in custom builds) but the windows do not properly acknowledge the transparent window and so it is left opaque with a black background.
Ultimately, I believe we are a pretty long way away from truly supporting Linux, but this is a step in the direction of making that easier.

The latest releases do run on Linux, but are still opaque due to the issue I mentioned above. This guide below provides a way for those on Linux with certain configurations to now use Blish HUD without native support.
https://gist.github.com/martinlabate/c4e6f08880a009f88dc1edaa4c6cd87a
It does involve some jank, but for those that really want it, it's an option.

There is a portion in the guide related to making Blish HUD not intercept mouse input.
In any case, we aren't really able to provide Linux assistance. You may be able to get help asking for help on the guide itself.

The latest releases do run on Linux, but are still opaque due to the issue I mentioned above. This guide below provides a way for those on Linux with certain configurations to now use Blish HUD without native support.
https://gist.github.com/martinlabate/c4e6f08880a009f88dc1edaa4c6cd87a
It does involve some jank, but for those that really want it, it's an option.
Running on Linux is likely not to be a direct goal of the core rewrite now as there are other difficulties running natively (such as dealing with mumble).

Bare minimum support for Linux would allow many people to use this software. With .net5 migration I'd assume transparency would be properly handled on Linux with compositors(maybe specific backend?) with should be enough to play comfortably with the overlay always on. There are many utilities in Blish that make big difference in the enjoyment of the game. I've played a lot with Blish on steam deck and all addons I needed worked just fine. The issue was with properly setting it up so the controls don't get intercepted by Blish. This means core functionality works fine on Linux and the issue is with:

overlay transparency not being handled properly by compositors( which can be partially solved by telling compositor to reduce opacity of specific window - Blish and then increase gamma ingame)
focus being stolen by overlay ( this is the biggest issue preventing actually using the Blish )
overlay not staying on top or not attaching to Guild Wars 2 window due to being a separate window(not an issue on tiling window manager like i3wm as Blish can "float" above Guild Wars 2 window)

The guide you referred to requires kwin(KDE compositor) rule to not accept any focus by Blish overlay and to keep Guild Wars 2 window always below the overlay which might but usually can't be accomplished by other compositors.
Maybe there is a possibility to include Blish setting to accept focus when key combination gets pressed? I've seen this behavior being useful in differentiating focus target here: https://github.com/SnosMe/electron-overlay-window . There is a demo included maybe worth looking into this to support Linux? Looking at implementation it seems to attach to a process by title without being a separate window which would solve issues with windows fighting who's on top.
As for dealing with mumble - as long as Blish runs on same prefix(pfx in case of steam) and wineserver version then it's fine with all communication.
On steam deck guide for Blish the script starts Blish with the same prefix and wineserver version so mumble communication works.
For it to work on PC there are few ways:

create similar script to run alongside the game (annoying if we want to run game without the overlay as currently with overlay we need to adjust gamma due to translucent black tint overlay)
run after Guild Wars 2 starts(wineserver hangs if its in reverse order). There is a guide on how to run application using same prefix and wineserver and wine/proton version on Burrito page https://burrito.orthogonalprojects.com . Guide is for lutris but it's easy to adjust it to work with steam once config gets generated for the guide that's why I mentioned pfx earlier. (better way as overlay can be run on demand)
run with steamtinkerlaunch?

The latest releases do run on Linux, but are still opaque due to the issue I mentioned above. This guide below provides a way for those on Linux with certain configurations to now use Blish HUD without native support.
https://gist.github.com/martinlabate/c4e6f08880a009f88dc1edaa4c6cd87a
It does involve some jank, but for those that really want it, it's an option.
Running on Linux is likely not to be a direct goal of the core rewrite now as there are other difficulties running natively (such as dealing with mumble).

Bare minimum support for Linux would allow many people to use this software. With .net5 migration I'd assume transparency would be properly handled on Linux with compositors(maybe specific backend?) with should be enough to play comfortably with the overlay always on. There are many utilities in Blish that make big difference in the enjoyment of the game. I've played a lot with Blish on steam deck and all addons I needed worked just fine. The issue was with properly setting it up so the controls don't get intercepted by Blish. This means core functionality works fine on Linux and the issue is with:

overlay transparency not being handled properly by compositors( which can be partially solved by telling compositor to reduce opacity of specific window - Blish and then increase gamma ingame)
focus being stolen by overlay ( this is the biggest issue preventing actually using the Blish )
overlay not staying on top or not attaching to Guild Wars 2 window due to being a separate window(not an issue on tiling window manager like i3wm as Blish can "float" above Guild Wars 2 window)

The guide you referred to requires kwin(KDE compositor) rule to not accept any focus by Blish overlay and to keep Guild Wars 2 window always below the overlay which might but usually can't be accomplished by other compositors.
Maybe there is a possibility to include Blish setting to accept focus when key combination gets pressed? I've seen this behavior being useful in differentiating focus target here: https://github.com/SnosMe/electron-overlay-window . There is a demo included maybe worth looking into this to support Linux? Looking at implementation it seems to attach to a process by title without being a separate window which would solve issues with windows fighting who's on top.
As for dealing with mumble - as long as Blish runs on same prefix(pfx in case of steam) and wineserver version then it's fine with all communication. On steam deck guide for Blish the script starts Blish with the same prefix and wineserver version so mumble communication works. For it to work on PC there are few ways:

create similar script to run alongside the game (annoying if we want to run game without the overlay as currently with overlay we need to adjust gamma due to translucent black tint overlay)
run after Guild Wars 2 starts(wineserver hangs if its in reverse order). There is a guide on how to run application using same prefix and wineserver and wine/proton version on Burrito page https://burrito.orthogonalprojects.com . Guide is for lutris but it's easy to adjust it to work with steam once config gets generated for the guide that's why I mentioned pfx earlier. (better way as overlay can be run on demand)
run with steamtinkerlaunch?

Please see the comments in this thread:
https://github.com/blish-hud/Blish-HUD/discussions/873#discussioncomment-6298349
Running native on Linux is not the hard part nor is it the immediate solution, I'm afraid.


click events on gridCharacters

I'd like to enable clicking on a character and having something happen.  I can register 'pointerdown' events to the character's sprite but then I can't access information about the grid character itself (e.g., .getPosition())
here's an example which does register the click but I can't access the identity of the character:
this.gridEngine.gridCharacters.get('pumpkin0').sprite.on('pointerdown', function(pointer) {
     console.log('clicked on this character, but I only know the identity of the sprite');
});

but this doesn't work:
this.gridEngine.gridCharacters.get('pumpkin0').on('pointerdown', function(pointer) {
     console.log('clicked on this character, and with I could access the position!', this.getPosition());
});

Is there a recommendation or way to pass click events upwards to the character from the character's sprite?
Thanks!
update
Something like this works so I guess if I manually ensured there was some "key" associated with the character's sprite that was the same id used by GridEngine then it could work.
 this.gridEngine.gridCharacters.get('pumpkin0').sprite.on('pointerdown', function(pointer) {
    console.log('clicked on this character', this.scene.gridEngine.getPosition('pumpkin0'));
});

Your last solution would be the recommended one. If you want to access data about a character the preferred way is over the public methods of the plugin, providing the character Id.
A sprite is just one aspect of a character along with its position, facing direction etc.
This brings me to another recommendation: don't use the gridCharacters property. In the typescript code it is a private property and it is not part of the documentation. It is intended for internal use only (just like the character objects it holds). Its name and structure might change anytime. So it is best to access a characters properties with the corresponding documented methods.
There is none at the moment for retrieving the sprite. The reason is, that the sprite is created outside of the plugin so it should be easy to keep a reference to it outside grid-engine.
However, it might be a good idea for us to provide a method to get a characters sprite, so you don't need to keep track of the references yourself.

I created an issue for this #170

thank you for your help and advice!


RTP error

Hi, I tried use the DownloadRecordings.py but met with this error.
I am able to download 1 hour of recording before this error occurs.
This is the last line before the error
Downloading F:\2023-07-25 16_00_00-2023-07-25 17_44_02.mp4: 4096.14 / 6242
File "C:\Users\UserName\AppData\Local\Programs\Python\pytapo\lib\site-packages\rtp\rtp.py", line 165, in sequenceNumber
   raise ValueError("SequenceNumber must be in range 0-2**16")
ValueError: SequenceNumber must be in range 0-2**16

How big are the individual recordings?

Each file is slight more than 1 hour. It's 1 hour 6 minutes.

Can the recording length be changed to smaller chunks in the app? This script will not work with such a long periods.

I am unable to change the recording length as I set it to continuous recording. I will change the recording mode to detection only for smaller chunks. Thanks!


Incorrect diagnostics: Unsupported format remaining for map value

Tact compiler allows specifying remaining as a serialization format for map values, despite that it doesn't actually do anything and default still applies. Consider the following example:
contract Example {
    m: map<Int, Cell as remaining>; // ← compiles fine,
                                    // albeit as `dict<uint8, ^cell>`, and not
                                    // `dict<uint8, remainder<cell>>` as one might expect
}

However, tact-vscode considers it an error, showing Unsupported format remaining for map value, while the code compiles just fine under Tact v1.4.0 and newest dev versions, see: https://github.com/tact-lang/tact/issues/569#issuecomment-2247221601

I am waiting for https://github.com/tact-lang/tact-vscode/issues/36, fixes are not at marketplace yet


Concordance

text: Aggravated damage done to a vampire with Concordance is still aggravated but handled as normal damage during damage resolution
link: https://groups.google.com/g/rec.games.trading-cards.jyhad/c/0UGI9W2sSpk/m/An-ZYLIxAiwJ

This sounds just like the card text to me. "The damage is aggravated but it is handled as normal during damage resolution" is just a longer way to say "treats aggravated damage as normal damage", no? What is it that this additional ruling would clarify exactly? Maybe an example?


Bugs on Avatar, Dropdown and Button.

Hey folks 👋, I'm reporting here several bugs of the components that are mentioned in the title.
Avatar:
The problem with the "Avatar" component is the "Color" property that can't even change the color of the "border" and always stays gray. It is in the video running this problem and the code I have is as follows:
<Avatar img={discordImage} rounded bordered color='purple' />

Dropdown:
This problem only happens in safari and not in Google Chrome, which is "Toggle", if I click on the area outside the "Dropdown Menu" nothing happens unless I go and click on the "Dropdown Button" again. As you can see in the video, I make several clicks on the "body" and it starts selecting text and the menu don't disappear.
Button:
As you can see in the video, when I am in google chrome and if I click on the button the "blur" doesn't disappear and stays as it is "focused", but when I do it in safari, it already has the normal behavior. Now you must be asking, and what happens when you are browsing the official flowbite website? The behavior is normal and just seems to only happen when I have it hosted on my computer and even I have tested it with starter project and it has the same problem. It must be because Google Chrome has some special setting for localhost urls, maybe for debug/testing? The truth is, I have searched and found nothing like this on the internet.
Video:
https://user-images.githubusercontent.com/38193239/205129550-e2656f64-ad9c-4dc4-b7e4-0f7b929f7b1a.mov
Project information:

Tailwind: 3.2.4
Flowbite: 1.5.4
Flowbite React: 0.3.5
Type: NextJS (Without Turbopack)

It seems that the file I uploaded is not working properly, anyway I uploaded it to youtube, click me to see.

I have the problem of clicking outside of the dropdown menu and the component is not closing also in Google Chrome, but it only occurs the second time you click on it (the first time it works well).
Steps to reproduce:

Click on the dropdown button to show the dropdown menu
Click outside of the component: it will close the dropdown menu
Click again on the dropdown button to show the dropdown menu
Click outside of the component: the dropdown menu will remain open until you click again the dropdown button

Project information:
Tailwind: 3.2.4
Flowbite: 1.6.5
Flowbite React: 0.4.10

I hope this isn't working anymore, so, I'm closing it.


Detect if a TestXYZ is skipped

Hi all,
I want to send a metric to report if a test is failing/successful.
The problem is-labels act upon features, and so the test is marked as successful even if we skip all the features inside it.
For example, given this snippet
	testenv.AfterEachTest(func(ctx context.Context, c *envconf.Config, t *testing.T) (context.Context, error) {
		t.Logf("Test %s is skipped: %v", t.Name(), t.Skipped())
		t.Logf("Test %s is failed: %v", t.Name(), t.Failed())
		return ctx, nil
	})

I get
❯ go test -v ./... -args -labels category=pod-native
=== RUN   TestAzureRemoteVolume
=== PAUSE TestAzureRemoteVolume
=== RUN   TestPodNative
=== PAUSE TestPodNative
=== CONT  TestAzureRemoteVolume
=== CONT  TestPodNative
=== RUN   TestPodNative/basic_pod_native
=== RUN   TestAzureRemoteVolume/azure_remote_volume
=== RUN   TestPodNative/basic_pod_native/check_injected_environment_variables
=== NAME  TestAzureRemoteVolume/azure_remote_volume
    env.go:431: Skipping feature "azure remote volume": unmatched label "category=pod-native"
=== NAME  TestAzureRemoteVolume
    main_test.go:93: Test TestAzureRemoteVolume is skipped: false
    main_test.go:94: Test TestAzureRemoteVolume is failed: false
2023/02/24 11:55:46 Not reporting metrics to Datadog, ReportMetrics is disabled.
--- PASS: TestAzureRemoteVolume (0.00s)
    --- SKIP: TestAzureRemoteVolume/azure_remote_volume (0.00s)
=== NAME  TestPodNative
    main_test.go:93: Test TestPodNative is skipped: false
    main_test.go:94: Test TestPodNative is failed: false
2023/02/24 11:55:52 Not reporting metrics to Datadog, ReportMetrics is disabled.
--- PASS: TestPodNative (6.05s)
    --- PASS: TestPodNative/basic_pod_native (6.05s)
        --- PASS: TestPodNative/basic_pod_native/check_injected_environment_variables (6.05s)

So as you can see we can't detected between a skipped and failed test and we're reporting skewed metrics.
Do you have any suggestions about how we can fix/work around this? I could use -run regexp to select only the TestXYZ I'm interested about but then I'm losing all the benefit of labelling the tests and I would need a strong naming convention to do it.
I also looked into sending a metric per feature, but I don't think there is an easy way to say if that feature is successful or not.

@maruina I did a quick scan and we do call the t.Skipf handlers in the execFeature which should have marked the right indicator for the Skip cases. Let me take a look and see if this needs a fix.

@harshanarayana thank you, please let me know if/how I can help

@harshanarayana did you have time to look into this? Is there anything I can do to help?

Sorry I got a bit caught up with some personal work.. Will look into this over the weekend. In the mean time, if you can spare some time, please feel free to check the part where we perform t skips..

I think I know why your expectations are not working.
package tskip_test

import (
	"context"
	"testing"

	"sigs.k8s.io/e2e-framework/pkg/envconf"
	"sigs.k8s.io/e2e-framework/pkg/features"
)

func TestOne(t *testing.T) {
	f1 := features.New("one").WithLabel("label", "abc").
		Assess("a1", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
			return ctx
		}).Assess("a2", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
		return ctx
	}).Feature()

	testEnv.Test(t, f1)
}

func TestTwo(t *testing.T) {
	f2 := features.New("two").WithLabel("label", "xyz").
		Assess("b1", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
			return ctx
		}).Assess("b2", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
		return ctx
	}).Feature()
	testEnv.Test(t, f2)
}

Take the above for example. With the Main defined as follwing
func TestMain(m *testing.M) {

	cfg, err := envconf.NewFromFlags()
	if err != nil {
		log.Fatalf("failed to load env config: %s", err)
	}

	testEnv = env.NewWithConfig(cfg)

	testEnv.AfterEachTest(func(ctx context.Context, c *envconf.Config, t *testing.T) (context.Context, error) {
		klog.InfoS("Test completed", "t", t.Name(), "skip", t.Skipped())
		return ctx, nil
	})

	os.Exit(testEnv.Run(m))
}

The AfterEachTest  if you read the documentation says,

// AfterEachTest registers environment funcs that are executed
// after each Env.Test(...).

So it kicks in only once for each test.
=== RUN   TestOne
=== RUN   TestOne/one
=== RUN   TestOne/one/a1
    env.go:451: Skipping assessment: "a1": name matched
=== RUN   TestOne/one/a2
I0326 18:22:08.279936   43302 main_test.go:26] "Test completed" t="TestOne" skip=false
--- PASS: TestOne (0.00s)
    --- PASS: TestOne/one (0.00s)
        --- SKIP: TestOne/one/a1 (0.00s)
        --- PASS: TestOne/one/a2 (0.00s)
=== RUN   TestTwo
=== RUN   TestTwo/two
=== RUN   TestTwo/two/b1
=== RUN   TestTwo/two/b2
I0326 18:22:08.280171   43302 main_test.go:26] "Test completed" t="TestTwo" skip=false
--- PASS: TestTwo (0.00s)
    --- PASS: TestTwo/two (0.00s)
        --- PASS: TestTwo/two/b1 (0.00s)
        --- PASS: TestTwo/two/b2 (0.00s)
PASS
ok  	sigs.k8s.io/e2e-framework/examples/tskip	1.350s

So I went around digging for a it a bit more by adding some more log and context.
diff --git a/pkg/env/env.go b/pkg/env/env.go
index ad23f10..a4483af 100644
--- a/pkg/env/env.go
+++ b/pkg/env/env.go
@@ -210,6 +210,7 @@ func (e *testEnv) processTestFeature(t *testing.T, featureName string, feature t
 	// execute feature test
 	e.ctx = e.execFeature(e.ctx, t, featureName, feature)

+	klog.InfoS("After test exec feature", "t", t.Name(), "test", fmt.Sprintf("%p", t), "skip", t.Skipped())
 	// execute afterEachFeature actions
 	e.processFeatureActions(t, feature, e.getAfterFeatureActions())
 }
@@ -428,10 +429,10 @@ func (e *testEnv) execFeature(ctx context.Context, t *testing.T, featName string
 	// feature-level subtest
 	t.Run(featName, func(t *testing.T) {
 		skipped, message := e.requireFeatureProcessing(f)
+		klog.InfoS("Execute Feature", "test", t.Name(), "t", fmt.Sprintf("%p", t))
 		if skipped {
 			t.Skipf(message)
 		}
-
 		// setups run at feature-level
 		setups := features.GetStepsByLevel(f.Steps(), types.LevelSetup)
 		ctx = e.executeSteps(ctx, t, setups)
@@ -447,6 +448,7 @@ func (e *testEnv) execFeature(ctx context.Context, t *testing.T, featName string
 			}
 			t.Run(assessName, func(t *testing.T) {
 				skipped, message := e.requireAssessmentProcessing(assess, i+1)
+				klog.InfoS("Execute Assessment", "test", t.Name(), "t", fmt.Sprintf("%p", t))
 				if skipped {
 					t.Skipf(message)
 				}

// some_test.go
func TestOne(t *testing.T) {
	klog.InfoS("Starting Test", "test", t.Name(), "t", fmt.Sprintf("%p", t))
	f1 := features.New("one").WithLabel("label", "abc").
		Assess("a1", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
			return ctx
		}).Assess("a2", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
		return ctx
	}).Feature()

	testEnv.Test(t, f1)
}

func TestTwo(t *testing.T) {
	klog.InfoS("Starting Test", "test", t.Name(), "t", fmt.Sprintf("%p", t))
	f2 := features.New("two").WithLabel("label", "xyz").
		Assess("b1", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
			return ctx
		}).Assess("b2", func(ctx context.Context, t *testing.T, c *envconf.Config) context.Context {
		return ctx
	}).Feature()
	testEnv.Test(t, f2)
}

# main_test.go
func TestMain(m *testing.M) {

	cfg, err := envconf.NewFromFlags()
	if err != nil {
		log.Fatalf("failed to load env config: %s", err)
	}

	testEnv = env.NewWithConfig(cfg)

	testEnv.BeforeEachTest(func(ctx context.Context, c *envconf.Config, t *testing.T) (context.Context, error) {
		klog.InfoS("Before Each Test", "t", t.Name(), "skip", t.Skipped(), "test", fmt.Sprintf("%p", t))
		return ctx, nil
	})

	testEnv.BeforeEachFeature(func(ctx context.Context, c *envconf.Config, t *testing.T, f features.Feature) (context.Context, error) {
		klog.InfoS("Before Each Feature", "t", t.Name(), "skip", t.Skipped(), "test", fmt.Sprintf("%p", t))
		return ctx, nil
	})

	testEnv.AfterEachTest(func(ctx context.Context, c *envconf.Config, t *testing.T) (context.Context, error) {
		klog.InfoS("After Each Test", "t", t.Name(), "skip", t.Skipped(), "test", fmt.Sprintf("%p", t))
		return ctx, nil
	})

	testEnv.AfterEachFeature(func(ctx context.Context, c *envconf.Config, t *testing.T, f features.Feature) (context.Context, error) {
		klog.InfoS("After Each Feature", "t", t.Name(), "skip", t.Skipped(), "test", fmt.Sprintf("%p", t))
		return ctx, nil
	})

	os.Exit(testEnv.Run(m))
}

And here is what I found
❯ go test -v . -args --skip-labels "label=abc"
=== RUN   TestOne
I0327 14:24:39.175823   89197 some_test.go:14] "Starting Test" test="TestOne" t="0xc000802ea0"
I0327 14:24:39.176072   89197 main_test.go:28] "Before Each Test" t="TestOne" skip=false test="0xc000802ea0"
I0327 14:24:39.176081   89197 main_test.go:33] "Before Each Feature" t="TestOne" skip=false test="0xc000802ea0"
=== RUN   TestOne/one
I0327 14:24:39.176172   89197 env.go:432] "Execute Feature" test="TestOne/one" t="0xc0008031e0"
    env.go:434: Skipping feature "one": matched label provided in --skip-lables "label=[abc]"
I0327 14:24:39.176220   89197 env.go:213] "After test exec feature" t="TestOne" test="0xc000802ea0" skip=false
I0327 14:24:39.176228   89197 main_test.go:43] "After Each Feature" t="TestOne" skip=false test="0xc000802ea0"
I0327 14:24:39.176233   89197 main_test.go:38] "After Each Test" t="TestOne" skip=false test="0xc000802ea0"
--- PASS: TestOne (0.00s)
    --- SKIP: TestOne/one (0.00s)
=== RUN   TestTwo
I0327 14:24:39.176281   89197 some_test.go:26] "Starting Test" test="TestTwo" t="0xc000803520"
I0327 14:24:39.176298   89197 main_test.go:28] "Before Each Test" t="TestTwo" skip=false test="0xc000803520"
I0327 14:24:39.176308   89197 main_test.go:33] "Before Each Feature" t="TestTwo" skip=false test="0xc000803520"
=== RUN   TestTwo/two
I0327 14:24:39.176370   89197 env.go:432] "Execute Feature" test="TestTwo/two" t="0xc0008036c0"
=== RUN   TestTwo/two/b1
I0327 14:24:39.176405   89197 env.go:451] "Execute Assessment" test="TestTwo/two/b1" t="0xc000803860"
=== RUN   TestTwo/two/b2
I0327 14:24:39.176430   89197 env.go:451] "Execute Assessment" test="TestTwo/two/b2" t="0xc000803ba0"
I0327 14:24:39.176445   89197 env.go:213] "After test exec feature" t="TestTwo" test="0xc000803520" skip=false
I0327 14:24:39.176454   89197 main_test.go:43] "After Each Feature" t="TestTwo" skip=false test="0xc000803520"
I0327 14:24:39.176462   89197 main_test.go:38] "After Each Test" t="TestTwo" skip=false test="0xc000803520"
--- PASS: TestTwo (0.00s)
    --- PASS: TestTwo/two (0.00s)
        --- PASS: TestTwo/two/b1 (0.00s)
        --- PASS: TestTwo/two/b2 (0.00s)
PASS
ok  	sigs.k8s.io/e2e-framework/examples/tskip	0.675s

The t passed to the TestOne is getting passed down to the env.go until execFeature
In execFeature handler the t.Skip is done on a closure handler so it is an entirely different object that is actually getting skipped than the one being passed to the AfterEach{context} handlers

I am not still done with this analysis. Will post a bit more context today or tomorrow. This is not fully done yet.

@harshanarayana @maruina this sound like an issue we need to keep an eye on. If you have any update, please post.

Hey @vladimirvivien, I don't have any update yet but I'll ping you when I have time to look into this

@harshanarayana and @maruina
This seems like it fell off the radar.
/remove-lifecycle stale

@maruina and @harshanarayana should this be kept out of stale state?


Metadata panel – enhancements

[ ] Add fetching of dimension's values descriptions
[ ] Fix focus issue on the homepage, when a panel is open in the first chart, and the user tries to open another panel in the second chart
[ ] Add links to open metadata panel from the tables (but keep them for dataset preview table)
[ ] Add E2E tests

Remove Icons
Add "Show more" link to each item

Hey @bprusinowski Please find below my feedback in the screenshots. It's mainly design adjustments.
In general the metadata should be structured via the Textstyling. I think we could get rid of those grey lines and instead style the text as title and main text. Currently its a bit of a mix. See screenshots.
I'd also reintroduce the underline to make it more clear that metadata is hidden under some labels. Can we influence here the spacing between the underline and the text? The standard one I find a bit too narrow.
We could also try - instead of using the Textlink for the "Metadata" Label - to use a Secondary Contained Button to make the Metadata more visible.
I couldn't test the Metadata Panel in the published version as it always crashes.


Ex 051 - Unable to download QT - critical analysis test results

The issue
As an admin working on exercise JAC00051 – Deputy District Judge (Magistrates’ Court), I am unable to download the responses the JAC staff dry run of our QT critical analysis test that was held on 1/03/21.
We also held a JAC staff dry run QT situational judgement test on the same day and we are able to download those results.
Describe the solution you would like
I would like to be able to download the results from the QT critical analysis test – JAC staff dry run held on 1/3/21.

To test -

Log into Admin, go to an active exercise, create a Qualifying test, invite test candidates.
Log into Apply as test candidates, complete the test.
Log into Admin, go to the created Qualifying Test, click on Responses and click on Export responses button. (Apply test script, Admin test script)
Make sure it is possible to download responses, check negative behaviour (i.e.skipping questions in a test etc) as well as positive.
Make sure all data is present.

Have reviewed code and approved - with a suggestion for simplifying.
Have also tested against the prod data and it enables ex 51 data to be downloaded

Hi @mbrookeswebdev @warrensearle
If this code change is all ok can it be merged as a priority please?
I ask as we are working on the following item at the moment, which will effect this export/download:
#1100 - Exports should be prepared server-side
Locally, I have already created a feature branch off of develop for #1100. Let me know once this pull request has been merged though and I will merge develop into my local feature branch for #1100 to help avoid any merge conflicts coming up when its time to review #1100 ;)
Thanks


Create the HTTP Response wrapper types

For the same reason that the request wrapper types were created in #3059, this PR establishes the response wrapper types and refactors existing code to use them.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Additionally, what is our strategy for when http reaches version 1.x? Will we revert to using the types defined by http directly and convert our new Request/Response types into type aliases? Or do we plan on introducing into_http1x?

These wrapper types are forever, unfortunately. We will just change the insides of them to use http 1 at that time. You can read more in the RFC: https://github.com/smithy-lang/smithy-rs/blob/main/design/src/rfcs/rfc0037_http_wrapper.md


add dragula definition

dragula/dragula.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/dragula
http://bower.io/search/?q=dragula
others?

[X] has a test file? (dragula/dragula-tests.ts or others)
[ ] pass the Travic-CI test?

@pwelter34 thanks mate!


consider integrating StrongBox support

It may not be wise to replace the TEE-based key and attestation. It would be nicer to have an additional StrongBox attestation alongside it, but it would cause a substantial increase in the size of the attestation message which would likely be painful / impractical with QR codes.

This is implemented but not enabled by default.


Overflow auto sizing bug on Safari

One of the CSS rules on line 113 (.resize-triggers > div { overflow: auto; }) causes Safari to set overflow on contract-trigger and expand-trigger to auto, obviously.  When used with a scrollable div, Safari gives these two divs a smaller width (because of the overflow: auto generates space for an invisible scrollbar)  This causes the vertical scrollbar on the div to be un-clickable.
As a fix, I simply removed the overflow: auto rule from the plugin, but am now obviously worried about unknown side-effects.  What was the original purpose of this rule?
I'll try to attach a jsbin or something ASAP.

I've also run into this issue. An alternative I'm testing is adding the .resize-triggers element to the first child of the parent element (rather than the last child like is currently).
This seems to achieve the same outcome (Safari's scrollbars don't block clicks from the other content.


Remove mkdirp in favor of fs-extra

Changed:

Remove mkdirp and rimraf in source
Remove mkdirp in deps list (can't remove rimraf because it is used in cli too)
Move fs-extra to deps instead of devDeps (hopefully this will solve #117)

Nice.


Cells ordering in FlatRow#getCells()

in FlatRow implementation when calling FlatRow#getCells(), can we rely that list of cells is ordered by Cell#timestamp ? Or the caller needs to sort Cells by timestamp?

Cells are ordered as follows:

Column Family, lexicographically ascending
Qualifier, lexicographically
timestamp, descending

@sduskis Thanks a lot for explanation


Updating "Transfer or seize FSMO roles in Active Directory Domain Services" document

Re-ordering FSMO role table to match netdom query fsmo output
Adding another exception to the seize commands

@aidenmitchell : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Update CI badge

The CI Badge was invalid on the main readme page. this is fixing the issue

@peterhuene are you the only one to do review /accept PR ?
is there anyone else to ping ?

Hi @fforjan.
Thanks very much for the PRs!
As I no longer work on Wasmtime or wasm-related projects, I don't consider myself a maintainer of this repo anymore.
I have pinged the BA maintainers on Zulip to find a replacement maintainer that can review and merge your PRs; I hope someone will pick it up shortly.

@peterhuene thanks for the info.
Hopefully this project will continue!

@peterhuene thanks for the info.
Hopefully this project will continue!

@peterhuene  did you get any update of who will own this in the future ? I cannot recommend this for my company with the current state :(

I wasn't able to locate one yet.
Pinging the @bytecodealliance/tsc for visibility.

LGTM
Started looking into while CI is failing in #315 so we can unblock merging the PRs


Update Ui

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     72.52%   72.52%
  Complexity      474      474
=========================================
  Files            77       77
  Lines          1503     1503
  Branches        182      182
=========================================
  Hits           1090     1090
  Misses          346      346
  Partials         67       67

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/ui/AttractionCard.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38a2d2...5144ce8. Read the comment docs.

LGTM


Add keymaster-lib demo

It should be possible to change the keymaster web app (API demo) into a non-custodial wallet (lib demo) that works OK on mobile.
This could be deployed by the gatekeeper service in the same way that the keymaster service deploys the API demo.

The UI and logic would be the same in both cases, the main difference is the wallet would be stored in browser local storage rather than the server's file system.

@macterra - updated this Issue as next Big Rock for iteration 7


Fixes #4503

The major change here is to change the default parameters for the SMILES and SMARTS parsers to parse molecule names by default.
This shouldn't break any existing code unless someone has written code which depends on SMILES including whitespace being parsed without having a _Name property set, but that seems unlikely.
Regardless, this is flagged as a backwards-incompatible change.
There's also a bit of refactoring in there.

Also, I'm curious about the parsing behavior when we have edge cases with spaces in the CX string, like, e.g., when we have an R-group that is an embedded CXSMILES.

that might be problematic. Do you have an example I could look at?

Also, I'm curious about the parsing behavior when we have edge cases with spaces in the CX string, like, e.g., when we have an R-group that is an embedded CXSMILES.

that might be problematic. Do you have an example I could look at?

I (fortunately) haven't seen any of those in the wild, but there's an example in R-groups section of https://docs.chemaxon.com/display/docs/chemaxon-extended-smiles-and-smarts-cxsmiles-and-cxsmarts.md#src-1806633-chemaxonextendedsmilesandsmarts-cxsmilesandcxsmarts-r-groups:
Cl[*](br)I |$;_R1;;$,RG:_R1={*CCCC(C*)CC* |$_AP3;;;;;;_AP2;;;_AP1$|},{*CCCN(C*)CC* |$_AP3;;;;;;_AP2;;;_AP1$|},LO:1:0.2.3|

Those are going to fail. The CXSmiles parser wouldn't be able to do anything sensible with the contents anyway. If we ever end up supporting that then we'll have to revisit the way the SMILES/SMARTS is tokenized.

Ok, I that's what I suspected.

@ricrogz : the most recent commits improve the way whitespace is handled, add some more tests, and document things.

@ricrogz : the most recent commits improve the way whitespace is handled, add some more tests, and document things.

LGTM, Greg. Thanks!


Issues with bun

Describe the bug
When using dissectMatch from "r6-dissect" (from npm) you get the following error:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x188 pc=0x7ff117dd1a97]

goroutine 17 [running, locked to thread]:
github.com/redraskal/r6-dissect/dissect.(*Reader).PlayerStats(0x0)
        /github/workspace/dissect/stats.go:82 +0xb7
github.com/redraskal/r6-dissect/dissect.(*MatchReader).Data(0xc0001df280)
        /github/workspace/dissect/match.go:236 +0xbc
main.dissect_read(0x0?)
        /github/workspace/exports/exports.go:57 +0xd4
Aborted

When using dissect from "r6-dissect" you get the following error:
invalid input: magic number mismatch
To Reproduce
Steps to reproduce the behavior:

Import the latest "r6-dissect" from NPM, using bun i r6-dissect
Import the dissect/dissectMatch from "r6-dissect" (as one would normally with bun)
Try to read the data of a Match directory / round .rec file; example const { data, error } = await dissectMatch("Match-2023-12-27_20-41-51-74/");
Observe the error in console.

Expected behavior
I feel like the expected behavior is quite apparent but, I would expect it to console.log(data.matchID)
Additional context
This is running on Ubuntu 22.04 LTS via WSL
This is using the Latest Release of r6-dissect via NPM
This is also a fresh install of Ubuntu.

@Annabxlla try the latest npm release, should be fixed. i think this was due to an outdated binary included in that release. i might change the workflow for the bun package to download (and cache) on runtime as opposed to including the binaries in releases


Unset focal distance by default in thin lens camera

To repro:

Create a new project in appleseed.studio.
Change the camera model to Thin Lens.
Notice that both a focal distance and an autofocus target are set; these are conflicting.
Render and notice that a warning is emitted:while defining camera "scene/camera": autofocus is enabled; "focal_distance" parameter will be ignored.


⚠ Bofrost.es has degraded performance

In 60fc1da, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1293 ms

Resolved: Bofrost.es performance has improved in 96fb7b6 after 6 minutes.


Keyword arguments may need further categorization (a.k.a. misleading options formatting)

Just as cmake_parse_arguments distincts between "options", "one-value keywords", and "multi-value keywords", cmake-tidy may need to as well. Currently, formatting may yield odd results for e.g. add_executable or add_library.
Input (source files list shortened for the purposes of this issue):
add_executable(foo WIN32
    bar
    baz)

add_library(foo STATIC
    bar
    baz)

Expected output: same as input (?)
Actual output:
add_executable(foo
    WIN32
        bar
        baz)

add_library(foo
    STATIC
        bar
        baz)

Although the results looks kind of okay, they are inconsistent with other formatting in that they give an impression that "bar" and "baz" are values of WIN32 and STATIC keywords which is not true.
With decent CMake version one may want to workaround this by using target_sources which would be formatted properly, as in
add_executable(foo WIN32)

target_sources(foo
    PRIVATE
        bar
        baz)

Hi,
I agree that this is an issue and it needs some action. I thought some time about it and first I would need a bit more investigation about the problem before choosing a solution (eg. cmake_parse_arguments approach).
Some points that need to be taken into account:
(Sorry that the points are quite unsystematic - there are mainly notes made during the day)

Keywords change meaning for different commands.
Example:

INTERFACE as option:

add_library(a_library INTERFACE)

INTERFACE as multi-value keyword:

target_sources(a_target
    INTERFACE
        a_header.hpp
        another_one.hpp
)

This means that cmake-tidy would need to have information about keyword type connected to each command. Which leads to couple of next questions:

Maintaining the information. #144 gave quite a nice idea about generating list of properties, similarly acquiring command names should be easy - but getting all keywords with type (option/argument keyword) will be more complex problem.
User defined functions/macros formatting - how to handle it? Manual definition of settings in configuration file (with type distinction) can be quite complex.

Reasonable defaults? Inheriting from existing builtin command?
There could be a convenience script that would generate it based on cmake_parse_arguments.
Remark: It is (at least for now) not a goal for the tool to resolve includes and find proper definitions of user-defined functions/macros

CMake changes in builtin commands (adding/deprecating keywords) - how will they affect formatting with older/newer version of cmake-tidy

cmake_parse_arguments handling is not enough to properly format all cases (for builtin commands):
example https://cmake.org/cmake/help/latest/command/install.html#command:installinstall(TARGETS mylib
    LIBRARY
        COMPONENT Libraries
        NAMELINK_COMPONENT Development
        PERMISSIONS GROUP_READ OWNER_WRITE
    PUBLIC_HEADER
        COMPONENT Development
)

Change of handling cmake_parse_arguments command handling by CMake will most likely result in breaking change for users of cmake-tidy at least for configurations.

I will play around with the idea on a branch and come back with some more thoughts/answers.


sympy generator fix and AST validation backend switch to python3 type hinting

Closes #7.
I also switched the AST backend from my custom hack to the python3 type hinting (since we are dropping python2 support). I'm using pycharm to perform the type checking and I finally got it so there are no errors. Also, now that we are using standard type hinting autocomplete works now in pycharm, which makes our lives a lot easier. @jbaayen .

Coverage increased (+8.2%) to 78.222% when pulling bc09c366fea5ed107c8ec3c6eef2cbd92d531899 on dev into c1a79842be2e9f1a8f96a5b9b22dba058e7660ed on master.


Introduce customizable PrivateKey

This is the current approach I took to tackle #199.
Using a dynamic object turned out not to be an option, mainly because I couldn't figure out serialization without breaking object safety.
Other approaches that I could think off that avoid having users specify a PrivateKey type:

Hiding the PrivateKey associated type somewhere else, for example in Group or KeyExchange
Introduce a default associated type () with the help of some hacks, because it isn't stable yet
Put the type in ServerSetup and pass it down to corresponding functions instead of putting it in CipherSuite

I decided to take the last approach, now the user-facing API almost doesn't change at all.

I managed to implement a custom error type to SecretKey without any breaking changes actually. I had to change a result type in the KeyExchange trait, but the trait was never exposed publicly, so no issues there.
The way I did that is that to add a Custom variant to InternalPakeError, with the default being Infallible, it turned out to be quiet messy because of conversions and what not, but it works. I'm open to any suggestions, I tried my best to keep it user friendly and not to big of a change.

The tests are failing because the newest version of zeroize has a MSRV of 1.51.

This is fantastic, thanks for putting all of the effort into the change. As a follow-up, it would be great to add documentation to the lib.rs for how to use remote keys (probably under Advanced Usage). Creating https://github.com/novifinancial/opaque-ke/issues/214 to track this

The tests are failing because the newest version of zeroize has a MSRV of 1.51.

I'd like to understand better why this is the case... how come the newest version of zeroize is being pulled in here?

If you don't specify otherwise, Cargo will use the caret requirement (ref):
zeroize = "1.1.1" is really zeroize = "^1.1.1"
The caret requirement is described like this (ref):

Caret requirements allow SemVer compatible updates to a specified version. An update is allowed if the new version number does not modify the left-most non-zero digit in the major, minor, patch grouping.

Basically what happened is that zeroize didn't consider bumping the MSRV a breaking change, a lot of crates do this. Do solve this issue here you can either specify a different requirement, most likely what we are looking for here is the tilde requirement, or bump the MSRV.

I added further documentation under "Advanced usage" to deal with #214. I can add a full example later when we do more progress in Custodian to have actual support for remote keys or find a different library that does that already.


XCode Target + opts (swift/objc/link)

Adding more context here from our offline discussion.

include Swift and Objc opts into the Target data structure

    func genCode(_ target: Target) -> String {
  swift_libray(
    opt = [
      target.swift_opt
    ]
  )
}


numberpicker not found in App

Hi, i add the plugin using: tns plugin add nativescript-numberpicker, and add code in my view
xmlns:numberpicker="nativescript-numberpicker"
and
<numberpicker:NumberPicker value="3" minValue="2" maxValue="6" id="np"/>
But i receive error: NumberPicker not found in /app/tns-modules/numberpicker
Plataform: Android
NS: 3.2 (last version)
I found folder nativescript-numberpicker  in npm-modules.
What do i do wrong?

Hi @denerFernandes.
I haven't been working with nativescript for quite a while now, and haven't had time to test things out with the current level of work.
@jogboms has been experimenting with this. Could you help out here?

Still working on it Mr @Robophil. I'll forward a PR once i make head way


Indexer storage trait

Stack:

#368
#367
#366 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

✓ Commit merged in pull request #368


Bump minimum PHP version to 8.1 & misc maintenance

Summary

Bump minimum PHP version to 8.1 & misc maintenance
Laravel 10 doesn't support 8.0 anyway and our github actions already reflect that and don't test this version
Remove phpunit 9
It's not required anymore, Laravel 10+ support phpunit 10+
gha: remove unused matrix dimension dependency-version (we use stability)
gha: bump runner os to ubuntu-22.04
tests: remove outdated version checks

I also took the library and adapted the CHANGELOG slightly, to make it also clear that doctrine/dbal removal actually means Laravel 9 goes out of support, too.

[x] Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

[ ] Existing tests have been adapted and/or new tests have been added
[x] Add a CHANGELOG.md entry
[ ] Update the README.md
[ ] Code style has been fixed via composer fix-style

Hmm let's hold off on the RC for just a bit, maybe we want some breaking changes. Was playing around with the phpdoc parser.


install

how do i install??? i need help

First go into your addons directory. That will be <library folder>/steamapps/common/GarrysMod/garrysmod/addons. Inside of there, put the addon folder. If you don't have git installed, then you can download the ZIP (top right on the main page) and extract the folder into there. If you do have git installed, you can simply do git clone https://github.com/Mee12345/GMod-Seamless-Portals.git inside of the addons folder.
After you've done either of those things, you should have a folder called GMod-Seamless-Portals inside of your "addons" folder. GMod doesn't like special characters and capital letters, so rename it to something like seamless_portals.
Assuming this works, make sure to close the issue by pressing the button at the bottom of the thread.

Click here if you're struggling with finding the zip

should release to workshop in a couple days anyway

git clone https://github.com/Mee12345/GMod-Seamless-Portals.git

i dont get it what the git clone https://github.com/Mee12345/GMod-Seamless-Portals.git ???? where??? also when i added the mod to addons folder and renamed its still not appearing


Add threadpool threadcap for AArch64 builds

Runs thread pool with one thread less when number of cores == num_threads and num_threads >= 16. This fixes a performance degradation issue on AArch64 builds when using max threads on systems with a large amount of cores.

@penpornk

Hi @penpornk, Can you please review this PR ? Thank you!

Thank you for the PR and sorry for the delay! Could you please paste some microbenchmarks/end-to-end model performance results before and after the changes?
cc: @cantonios

Please find attached benchmarks on image classification models before and after this PR. It improves performance up to 8% with an average of a 4.5% improvement.

Hi @penpornk are there any other changes required on my end to get this PR merged? Thanks.

Hi @penpornk and @cantonios. Would it be possible to get this merged in soon so that it makes it for the next release? Thank you.

@davsva01 Sorry for the delay! Our auto-import tool failed with TSL-only changes. I'll try to manually import the changes.


less number of rows in result set than expected

Describe the bug
Debug log show rows processed: 12
array of results shows only two rows scanned (length = 2)
running generated sql directly on database shows 12 rows results. Seems to be problem in scanning
Any way to debug how scan works ?
Environment (please complete the following information):

OS: linux
Database: postgres
Database driver: pgx
Jet version [2.9.0]

Expected behavior
result set should have 12 rows

If destination is array of complex structs, array length can be less then the number of rows processed.
Could you share your query and destination?

@msonawane ?


What is this licensed under?

Super cool project and I'm interested in using it, but I couldn't find any information on what license it is released under. I just wanted to clarify whether that was an oversight or if the project is explicitly not under an open source license.
More info: https://choosealicense.com/no-permission/
Relevant bit:

If you find software that doesn’t have a license, that generally means you have no permission from the creators of the software to use, modify, or share the software. Although a code host such as GitHub may allow you to view and fork the code, this does not imply that you are permitted to use, modify, or share the software for any purpose

Feel free to use it however you like. If you do create new cool features make sure to open a PR to enable other people to use it as well ;)


list: include header file to allow compilation

Fixes #15754

This is not the right fix. The functions.h is included from progs.h if it is properly generated.

Closing this as wrong.


[Fate] New feature - Added filtering support for the Extras section

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
The Extras section of the sheet can get unruly if you have many Extras defined. This update adds a filtering feature; type in a search string, and any element that does NOT follow a title that matches your search will be hidden. Works in both editing and displaying modes.

Character Sheet Info Roll20 Internal Use only.


Valgrind reports leak

Actually, there are two problems:

when ci_build_and_test.py is run with python2 on linux (which is a case for CI build servers), this test: if sys.platform == "linux": returns false. In python2 sys.platform equals "linux2". As a result, valgrind is not automatically checked by CI.
this leads to a second problem, which was hidden by previous one: valgrind reports memory leak:

==26821==
==26821== HEAP SUMMARY:
==26821==     in use at exit: 72,704 bytes in 1 blocks
==26821==   total heap usage: 7,521 allocs, 7,520 frees, 361,451 bytes allocated
==26821==
==26821== 72,704 bytes in 1 blocks are still reachable in loss record 1 of 1
==26821==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26821==    by 0x5DEF975: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.26)
==26821==    by 0x40106B9: call_init.part.0 (dl-init.c:72)
==26821==    by 0x40107CA: call_init (dl-init.c:30)
==26821==    by 0x40107CA: _dl_init (dl-init.c:120)
==26821==    by 0x4000C69: ??? (in /lib/x86_64-linux-gnu/ld-2.23.so)
==26821==
==26821== LEAK SUMMARY:
==26821==    definitely lost: 0 bytes in 0 blocks
==26821==    indirectly lost: 0 bytes in 0 blocks
==26821==      possibly lost: 0 bytes in 0 blocks
==26821==    still reachable: 72,704 bytes in 1 blocks
==26821==         suppressed: 0 bytes in 0 blocks
==26821==
==26821== For counts of detected and suppressed errors, rerun with: -v
==26821== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0)

Note, that still reachable are not "real" leaks (see this answer), so maybe it'll be enough to just make valgrind ignore it, so the build doesn't fail.

Note, that still reachable

Actually there is already suppression file for this kind of "leak":
https://github.com/Dushistov/rust_swig/blob/master/c%2B%2B_tests/valgrind.supp
but looks like version of libstdc++ changed since last time it works.


Time input in seconds

In the modal I would like to have a time input field with the format hh:mm:ss. But I can't get this to work. Am i looking over someting?

did you try the datetimepicker?

Yes I did try it but it looks like a normal textfield and there is no popup. With the time input there is a popup to set the time.

This is quite an old question, but I think that type="time" may give what you want. Not working in IE, of course.


/v2/spaces//summary produces "-1" running_instances for all apps, instead of actual # instances

Issue
We upgraded to cf-deployment v24.1.0, which brings CAPI v1.142.0.
After the upgrade it appears that  /v2/spaces/<spaceguid>/summary | jq .apps[].running_instances shows mostly “-1”.
Other calls that show the process states (like /v3/apps/<appguid>/processes/web/stats) do show the correct state "RUNNING".
Context
The issue is prominently shown when using the prometheus boshrelease, a CFAppUnHealthy alert fires for each app, since cf_exporter uses the /v2/spaces/<spaceguid>/summary a lot.
Steps to Reproduce

Target any space that has one or more running apps.
Find the space guid (cf space <spacename> --guid)
Issue:  cf curl /v2/spaces/<spaceguid>/summary | jq '.apps[].running_instances'

Expected result
The number of running instances for each app.
Current result
The result will be a "-1" for each app.
Possible Fix
I have no idea

cross referencing https://github.com/cloudfoundry/cloud_controller_ng/issues/3109 since seems like root cause is similar

hey, just noticed that capi-release 1.143.0 was released yesterday which reverts the code which introduced this feature.
just tested in my env and we don't get -1 anymore

yup, same here, problem fixed.
Thanks!


selectedRowStyle not effect the Text Color !!

first :thanks for your component 👍
when in want style my row with selectedRowStyle={{backgroundColor:'gray'}} it's OK
but when try to
selectedRowStyle={{backgroundColor:'gray',color:'red'}}
it doesn't effect the row color

You'll need to pass selectedLabelStyle={{ color: 'red' }} to colour the text

thanks 👍


[New]: Rock-paper-scissors game

Framework/code-stack
Native (HTML, CSS, and JS)
Description
It will give choice to the user to take any of the three that is Rock/Paper/Scissor and then any one is chosen by the computer too and then the result is given of the match
Similar challenges
No
Screenshots

Additional Context
No response

pls assign this issue to me @sadanandpai


Updated starter tutorial

Note -- will update again when updated default progress_bar=True is live @johnjosephhorton

@rbyh it's live

I did manual readthedocs build so it should be live soon on docs


Normalize headings

I'm considering normalizing headings in some way after all. Mainly because I caught myself out while developing a project which used HTML5 elements, because of the way modern Firefox and Chrome resize h1 (coincidently to the size I needed) when nested within sectioning elements...while other browsers do not.
It would be pretty simple, just use the existing defaults and it will override the -webkit-any() / -moz-any() rules and kill off h1 resizing in sectioning elements. But then one might as well normalize all the headings and margins too, I suppose. It's likely that every project is going to modify these styles to match the design.
Thoughts?
h1 {
    font-size: 2em;
    margin: 0.67em 0;
}

h2 {
    font-size: 1.5em;
    margin: 0.83em 0;
}

h3 {
    font-size: 1.17em;
    margin: 1em 0;
}

h4 {
    font-size: 1em;
    margin: 1.33em 0;
}

h5 {
    font-size: 0.83em;
    margin: 1.67em 0;
}

h6 {
    font-size: 0.75em;
    margin: 2.33em 0;
}

@necolas I do, but if the default sizes in a browser get me to where I want to be, then I don’t change them…except once I get to IE, which has different defaults, and things look bad, and I end up having to go look up what the reference browser defaults are and manually fix it.

Thanks everyone. I've added some heading normalizations to avoid some of the issues discussed here and in other issues.


Uncaught ReferenceError: VueTables is not defined

I compiled the package myself and I am getting this error. Uncaught ReferenceError: VueTables is not defined. I think I am getting this error because I have this code no where: var VueTables = require('vue-tables'); But I'm not sure where to put it. I can't put it on my webpage so I need to put it somewhere where browserify goes over it. Could you tell me where to put it?
Little context:
I converted the plugin with browserify and stringify. I'm trying to build a frontend table with a custom html template.
I hope you can tell me where to put the var VueTables = require('vue-tables');

Already fixed it with a laracasts video I found, thanks anyway!
For other people having this problem: https://laracasts.com/series/learning-vuejs/episodes/9


[otbn,dv] Document insns that can cause multiple errors in DV doc

We are going to add a coverage point for each. The first step is to
carefully write down what we're trying to cover.
This is a tidied-up version of the list at https://github.com/lowRISC/opentitan/issues/7809#issuecomment-917008650.

@GregAC I'd appreciate if you could read through the list, you probably remember the details better than I do.

There's also no mention of the various fatal errors. E.g. you could get a fatal register read or a fatal dmem read along with some other errors.

Hmm, that's a good point. I think we should probably spec that behaviour out somewhere, but I'm not really inclined to write a test case for every possible combination with fatal register reads: we'd see something for most instructions, I think! How does a fatal register read look: similar to a call stack underflow, so it squashes anything using the value?
At least a fatal dmem read is restricted to just LW and BN.LID. I guess the only thing that could interact with is call stack overflow?

Hi @imphil and @GregAC: Are you happy with this as a step in the right direction? I've got a PR that hits these coverage points waiting and I'd rather merge this before pushing it up if it's ready for merge anyway.


Passing example GainPluginAudioProcessor by reference

I was getting this error when trying to compile the example GainPlugin:
PluginProcessor.cpp
Error:(200, 24) no matching constructor for initialization of 'blueprint::BlueprintGenericEditor'
Note:(33, 9) candidate constructor not viable: no known conversion from 'GainPluginAudioProcessor *' to 'juce::AudioProcessor &' for 1st argument; dereference the argument with *
Note:(65, 55) candidate constructor not viable: requires 1 argument, but 3 were provided
On line 200 of PluginProcessor.cpp seems like the GainPluginAudioProcessor is being passed by pointer (this) to the BlueprintGenericEditor, which wants a reference. Fixed this by changing line 200 (the Github diff seems to have gone weird here, that's the only change in this commit):
auto* editor = new blueprint::BlueprintGenericEditor(*this, bundle, &params);
Maybe I've misinterpreted something? But that's how I got the gain plugin example working so thought I'd submit it

Thanks! All working now :)


Fix #191: Workers are not unique

This fixes the bug reported in #191 Using enqueueUniquePeriodicWork() makes sure we don't schedule a new worker every time we open the app. This should reduce the load in EU member national backends by running the sync only once a day per client.

Cyprus is affected by this, we have noticed the same.  Following.


top and base in model dataset

The model datasets contain the top and botm variables which describe the modellayer geometry and the kh and kv variables for the horizontal and vertical conductivities. I find it would be easier to query the dataset if it would contain top and base of each modellayer instead of 1 top value and the base (botm) for each layer. Top and botm as required by Modflow 6 discretization packages could also be computed when writing the package file. However this is probably a design choice.

Sometimes it indeed is useful to have a top and bottom of each layer. However, we decided to follow the MODFLOW-schematisation, of defining only the model top (2d) and the botm of each layer (3d). In this way, the layer model stays consistent, and we do not introduce gaps in our layer model. To avoid these gaps, we would have to make sure the botm of each layer remains equal to the top of the layer beneath.
We do make sure the botm of each layer is defined everywhere, also at locations where a layer is not present, so you can always take the botm of the previous (upper) layer to get the layer top. You can also use the method nlmod.layers.calculate_thickness(ds) to calculate the thickness of all layers, and add this to botm, to get a 3d top.
Maybe we should make a method of this procedure, that transforms the top to a 3d-array (like the regis-data), which you can use for visualisation or other purposes.


grada_plot_bar(_full) ERROR in KILLS

There is an error if all adapters are found and skipped = TRUE in the plot function
it will ask to delete NULL from a table - a check if NULL is neccessary!
Pleas FIX!

fixed


Monitor DNSSEC

Closes #17

FYI, I did the following to test this:

Broke DNSSEC on the test redirect domain (derploidtest.click) by disabling its KSK’s CMK
Observed the DNSSEC alarm enter ALARM state and send an email after the next 4-hour period
Re-enabled the CMK and observed the alarm revert to OK state (actually it took almost another 24 hours cause I also had to re-enable the KSK itself, and thought it was just stuck on a cached value or something).


use a channel for stdin and SIGWINCH

note
I have only tested this on macOS. If someone can test it on linux for me, I'd appreciate it!

By using a channel, we can remove the need for calling libc::poll on the stdin pipe. This doesn't work on the Mac: when we redirect tty to stdin, it breaks the original stdin pipe (fd 0), such that libc::poll on it returns instantly, with an revents of POLLNVAL (invalid pipe). Also, macOS doesn't support libc::poll on devices, so we can't poll tty directly.
Instead, we spawn two threads: one just reads stdin forever, and the other uses the socket to listen for SIGWINCH events as before (using libc::poll). These both write to a channel, and the TuiInput simply reads from this channel.
There's no attempt to interrupt or join the two threads: they both just go on as long as the program does. I can add a "stop listening" signal if you like, but that felt like unnecessary complication given the current flow.
This fixes #2.

Update: I also removed the pipe from the SIGWINCH side of things, so that we don't have any pipes/sockets at all. Each path just grabs its events as simply as possible (for stdin, just read forever; for sigwinch, using the Signals iterator) and sends them to the mpsc channel.

@PaulJuliusMartinez any thoughts on this one? Even if you don't release a new version of jless, it'd be nice to just get this PR off my queue if it's acceptable to you. (Or to close it if it's not.)

Closing this PR for lack of development on the project. @PaulJuliusMartinez feel free to reopen and merge if you want.


AppManager suppport local app repo store

The purpose of the feature
like ood-daemon, app-manager also can support local repo and sync-repo param.
it may let single-machine-multi-ood system quickly init a new ood instance

finish at 94d8f7a4


Document suggested platform names

The documentation for storage:platform links to a chapter about the platforms, but the values given there don't correspond to the values given in examples. What platform names should be used for common/popular platforms? This would improve interoperability and clients could link to more useful information if a common set of values would have been agreed on.

I ran into this as I was implementing this extension in PySTAC for stac-utils/pystac#734. The JSON schema uses an enum but it's not clear from the README that you have to use one of these values.


[BUG] Data Loss in Visualization

Data loss happens when graphs get updated. A hacky fix is to click the edit button and it may be refreshed. However, this fix does not work when the run is finished. This seems to be more likely when more data is logged.
Example:

Hey @6etacat , thanks for reporting. We're looking into this.

Hey @6etacat for performance reasons we randomly sample more than 5k data points to 5k data points in the UI.  The data is still stored and the full resolution data can be accessed via our api with the scan_history method: https://docs.wandb.com/library/api/examples#export-metrics-from-a-large-single-run-without-sampling

I'm wondering how I will be able to visualize things normally? This happens to data charts that have very few data points as well. I can't work with a graph like this, and I have no way to make it look normal again. Sure I can extract the data and visualize it with matplotlib or some other tool, but then what's the point of using wandb anymore?

Hi @6etacat could you please email<EMAIL_ADDRESS>to set up a quick call so we can get this fixed for you

Hi @6etacat could you please email<EMAIL_ADDRESS>to set up a quick call so we can get this fixed for you

hey guys i still run into this to this day, seems likely with longer runs, I think it is the resampling that you guys are doing but it also happens with data-points that are fewer than 5k for sure, just as @6etacat reports. What kind of fix did you guys arrive at because this is definitely still an ongoing issue for me

For anyone googling this, I fixed this by editing the charts and reverting to the original step on the x axis instead of any other metric like wall time or a user defined step, which I had been using.


Adding index file content

Fixing the issue described in https://github.com/hubot-scripts/hubot-freshdesk/issues/1

Hey,
Sorry for not responding! I missed this notification.
Thanks a lot for your PR. 👍


setHeader uses proprietary templating for SpEL

The setHeader interceptor uses ${<SpEL>} as its template for SpEL expressions, but why not use the actual #{<SpEL>} template so it integrates with the SpEL context given in the proxies.xml file?

Good point. We have lots of samples, we should therefore move slowy. @t-burch can you support both #{} and ${}. Can you also rewrite the setHeader examples?
In 6.0.0 we can remove the support for ${}.

No examples use setHeader at the moment, so the only task would be to remove $ once 6.0 rolls out


Improve UX when not enough credits for publishing/channel creation

Right now we show a bar on top, but don't allow any text input. A user was confused that something was broken with the page.

Using #698 even though this one was first


7.4 required :(

Hello,
I was trying to test abapGitServer but got some errors related to code specific to 7.4. Our system is still 7.31. Since it looks like there are very few places with code specific for 7,4... any chance to downgrade it to be more widely compatible?
Thanks,
Nuno

I'm planning support down to "Releases 7.02 and 7.03/7.31 (Kernelpatch 116)" ref
However I've been lazy and some 7.4 syntax sneaked into the code.
I've spent the last month or so on abaplint, which will sometime in the future help identifying the places with 7.4 code, which will make it easier to downport.
Also feel free to change the code and submit a pull request if you are up for it.

do you have constant if_sxml=>co_xt_json in your system? It is required for the abapGitServer web stuff to work.

I do have that constant ;)
I'll try to downgrade it and submit a pull request.
But I have another issue which I need to solve first. I was going to report
it as an issue: zif_swag_handler is not found and I can't find it in the
repository's list of objects.
On Thu, Sep 1, 2016 at 12:17 PM, Lars Hvam<EMAIL_ADDRESS>wrote:

do you have constant if_sxml=>co_xt_json in your system? It is required
for the abapGitServer web stuff to work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/larshp/abapGitServer/issues/25#issuecomment-244037283,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgeUWPUP10L39oPUk7-odcfiXQlIzU-ks5qlqZAgaJpZM4JygBj
.

it is listed under requirements in the README, you can install it from https://github.com/larshp/ABAP-Swagger

I've added a feature to abaplintref so it can find non-702 statements, found 1 statement in abapGitServer and 8 places in the Swagger code, will fix these today :smile:

done
https://github.com/larshp/abapGitServer/commit/b084d4ed72c5019967b99d9f7e3a0397783f36a2
https://github.com/larshp/ABAP-Swagger/commit/885340fabdf9cce229d43a8b47ef7faf4fb87fbe
I dont have access to a 731 system with json support, so it is difficult to do more fixes. Feel free to submit a PR, or post the syntax errors here


Fix a condition to do not create duplicated armeriaClient

Motivations:
CentralDogmaConfiguration always creates clientFactory bean due to
the missing condition checking when retrieved methodMetadata is not a type of StandardMethodMetadata
Modifications:

Rename to CentralDogmaClientAutoConfiguration
Move the configuration condition
Rename armeriaClientFactory to avoid bean overriding due to the
common name

Result:

Do not duplicate @ForCentralDogma annotated armeria client factory
Easy to understand the role of the configuration class
Enable to load the configuration context when it is necessary only

Codecov Report

Merging #165 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   63.47%   63.47%   +<.01%
==========================================
  Files         273      273
  Lines        9451     9449       -2
  Branches     1065     1064       -1
==========================================
- Hits         5999     5998       -1
+ Misses       2829     2828       -1
  Partials      623      623

Impacted Files
Coverage Δ

...nt/spring/CentralDogmaClientAutoConfiguration.java
72.72% <100%> (ø)

...rver/internal/command/CreateRepositoryCommand.java
50% <0%> (-14.29%)
:arrow_down:

...ernal/storage/repository/git/CommitIdDatabase.java
73.27% <0%> (+1.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bf7fd...d9438d9. Read the comment docs.

Thanks @julnamoo


Add Website's sitemap

This website lacks a sitemap file! Sitemaps can help robots index your content more thoroughly and quickly. Read more on Google's guidelines for implementing the sitemap protocol.

Done.


Intellisense in pull requests

It would be really cool if this extension worked in pull requests as that would make reviewing things a lot more efficient. Is this possible at all?

Good idea.


Model provides different results for different Python versions

I have two python virtual environments, where just the Python version are different. I have the first with Python 3.7.9 and the second with Python 3.8. Xgboost 2.0.3 is installed on both, together with other libraries, all the same, the only difference is the python version.
For some reason, I'm having different predictions from the xgboost model when I train it on these different enviroments.
Already tried: set seed value to a fixed value (1), subsample to 1, colsample_bytree to 1.0, nthread to 1, and I keep getting different results for my models models in these two environments. I would appreciate if someone can bring some light in why this is happening.

Hi, thank you for raising the issue. Could you please provide a reproducible example that I can run on my machine?

Feel free to reopen if there's further information.


[WIP]:  Remove addon-knobs

As this is kind of deprecated with the new control prop

Since the removal of addon-knobs is a part of new features of storybook, we decided that it makes sense to do some other upgrade things in the same PR 🤫

Since the removal of addon-knobs is a part of new features of storybook, we decided that it makes sense to do some other upgrade things in the same PR 🤫


Clean up old links

Update an OMOP concept level csv link (the current link is 404)
Drop link to a post suggesting that Cerner doesn't have DiagnosticReports, since they do now

(Just doing some drive-by minor tweaks I noticed)

Thanks Mike!


⚠ Bofrost.lu has degraded performance

In 8372cfe, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1996 ms

Resolved: Bofrost.lu performance has improved in 303f608 after 6 minutes.


New version: ajeetdsouza.zoxide version 0.9.2

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115249&drop=dogfoodAlpha

@wingetbot run

@wingetbot waivers Add Validation-Executable-Error


Adding my small stable of scripts

I've got a couple others that I posted on the wiki, but they're either not as on-par with these, or I know there exist superior scripts that do the same thing.

Note that this pull is renaming /sendChat as a Player or Character. I figured since I was credited with the snippet, I'd update it and make it more useful should this eventually get automatically distributed; a partial script isn't very good in that case, but a function is.

Your pull request is deleting the "sendChat as a Player or Character" folder. Can you please resolve that and resubmit. The rest looks good.

Never mind, I realized you wrote that example and have another script that does it.


Notification portlet sample

Hi István,
Please check this, it works fine with dxp 7.4 for me. If you can find any error, typo, please let me know.

Just started reviewing.


Add support for SSSCC commenting

Support SSSCC commenting with leading #
This is helpful for adding/removing certain casts, turning them more into a "toggle" rather than an entry (which needs to be remembered between different files).

Using open (as r or w)
Pandas
Numpy? Numpy.genfromtxt()

During ARC01 we'll want to standardize what we use to read any/all CSV files from.
** Identified locations of CSV parsing **
process_ctd.py get_ssscc_list

ssscc file
with: open

rinko.py calibrate_oxy

ssscc group files
pandas read_csv()

odf_io.py _salt_loader

salt files
csv.reader

Addressed in PR #100.


LCMethod edits to views and templates

Summary Change Description
Updated/added views for LCMethod.  See the issue's issue owner section for decisions on field and record naming conventions I established with this PR.
Affected Issues/Pull Requests

Resolves #704

Review Notes
See comments in-line.
Checklist
This pull request will be merged once the following requirements are met.  The
author and/or reviewers should uncheck any unmet requirements:

Review requirements

Minimum approvals: 1
No changes requested
All blocking issues resolved by reviewers
Specific reviewers: @add_username_here
Review period: 2 days

Associated issue/pull request requirements:

[x] All requirements in affected issues marked "resolved" are satisfied
[x] All required pull requests are merged (or none)

Basic requirements

[x] All linters pass
[ ] All tests pass

The tests are broken due to the new MSRun.lc_method field being null=False (and blank=False).  The load scripts try to create MSRun records without a value for lc_method (because that's a later issue).  Before I toggled those values from True to False, there were only 4 failing tests having to do with not being able to map MSRun.lc_method.id (which is None) to a specific lcmethod_detail page.

[x] All conflicts resolved

Overhead requirements

[x] New/changed method tests implemented/updated (or no change)
[x] Added changes to Unreleased section of changelog.md
[x] Migrations created & committed (or no change)

This seems to handle some of the views, but I'm not sure all references to msrun_protocols have been replaced. For example, in the search views etc. I also had a question about the migration. I'm just commenting for now since I may be misunderstanding the goal of the PR.

I think it's clear now from our slack discussion why I left those msrun_protocol records and their presence in the views, but just to re-iterate, I was expecting the ion mode component to be preserved at some point later in this transition to a new schema organization.  Before I modify this PR, I would like to have a complete picture of how or whether my remaining concerns on this topic are planned to be dealt with.

Before I modify this PR, I would like to have a complete picture of how or whether my remaining concerns on this topic are planned to be dealt with.

OK, I've answered on Slack.

@lparsons - All the issues have been addressed.  The tests fail due to the loading not having been implemented, but that's all fixed in #768.

Merged main, so the tests should be able to pass now.  However, I am seeing errors referring to msrun_protocol. Something about the merge must've gotten something wrong.  I'm setting it aside ATM, but will fix it, perhaps tomorrow.


added kubelogin

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

The manifest version is 1.4.0 as I need to use nested portable installer. So it won't be conformed to 1.2.0 manifest. Would that be a problem?

marking it as Draft since this is blocked on winget 1.4 release

@msftbot .zip

@wingetbot run

[Policy] Reset Feedback


[HUDI-4865] Optimize HoodieAvroUtils#isMetadataField to use O(1) comp…

…lexity
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level: none | low | medium | high
Choose one. If medium or high, explain what verification was done to mitigate the risks.
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@danny0405 could you update the PR description to add relevant info and remove the template content?


Click lightbulb context menu && How to register a command with the specified id?

hi，@akosyakov  could you give me some idea?
Click lightbulb context menu && How to register a command with the specified id?

@vincentLiuxiang Which version of Monaco and monaco-languageclient are you using?
Please paste your package.json file here.

@rcjsuen I clone the latest version from this repo today.
and import monaco-editor from
https://microsoft.github.io/monaco-editor/node_modules/monaco-editor/min/vs/editor/editor.main.js
monaco vesion: 0.11.6.
And then, could you compile the package vscode-base-languageclient from ts to es5? or My project will uglify failed!
Because of this reason I have to compile vscode-base-languageclient and  monaco-languageclient package with source.

@vincentLiuxiang Please put debugging print statements or whatever and see what commands get registered in the MonacoCommands class.
https://github.com/TypeFox/monaco-languageclient/blob/557ef39258b05da48c4e403b39465094c3d3f86a/src/commands.ts#L11-L16

@vincentLiuxiang you can implement this command with https://github.com/TypeFox/monaco-languageclient/blob/master/src/workspace.ts#L94 and register it for Monaco

And then, could you compile the package vscode-base-languageclient from ts to es5? or My project will uglify failed! Because of this reason I have to compile vscode-base-languageclient and monaco-languageclient package with source.

You are welcome to open a PR.


Updating prefix field in the comments.json

The current comments.json file as a typo in the prefix field. This means that the function DevSkimLanguages.GetCommentPrefix returns empty string.

/azp run

I think this is a subset of the changes in #427. If its not urgent to merge this separately, I am happy to take #427 - with changes based on my feedback so this PR may be moot.
Let me know if I've misunderstood and this covers something other than what appears to already be in #427.

@gfs I'm happy to close this. It was for speeding up the fix, but we can take the change in the other PR.


Mitie Multiple Intents

Hi, Is there any way to display multiple intents(assume top 10 intents based on probability) using mitie-classifier ? If not can you please explain the reason behind this.

Hi. Unfortunately, no as MITIE classifier only output the probability for the predicted class

Can i tweak the code some where to output different classes probability? As probability is usually generated for each class and it outputs the one with maximum probability.

You have to get your hands dirty into dlib and make a PR.


Avoid recursive fileGrp's in section II, 5.3.5

A recommendation is prohibiting explicitly from embedding recursively  sections, which is possible in METS. Only one level of s should be allowed for interoperability purposes.
Section: II, 5.3.5

Do we make a recommendation here and tighten the language / add a SHOULD warning, or do we want to make a requirement and explicitly disallow / add an MUST error?

Amend filesec/index.md/ (section 5.3.5 text) to add we don't encourage (SHOULD) nested file group. Also (if SHOULD) we add a warning level requirement disbarring fileGrp/fileGrp`.


/traits call uses a "observationVariableDbId" filter which is not in the returned properties

The "observationVariableDbId" property, as it can be used as filter, should appear in the returned properties.

The relationship beteen observation variable and trait is many to one. A rait can have multiple observation variables associated with it. So it would not be appropreate to return all the observartion variables for a trait in the response. It is better to use the observationVariables endpoint with the trailDbId/traitName/traitPUI filter.


Trouble using com.mysema.scalagen:scalagen_2.10.1 module via Gradle

I'm getting the following error trying to use the scalagen_2.10.1 module via gradle. When I add this dependency I see this error:
org.gradle.api.internal.artifacts.ivyservice.ivyresolve.parser.MetaDataParseException:
inconsistent module metadata found.
Descriptor: com.mysema.scalagen:scalagen_2.9.3:0.3.2
Errors: bad module name: expected='scalagen_2.10.1' found='scalagen_2.9.3'

I think the problem here is the way the scalagen module users a property, defined by its own profiles to define the artifactid. So the artifact is resolved, but the scala-2.9.x profile defined in that same pom.xml and set as active by default then changes the id of the artifact itself.
I've tried various techniques, including:

seting scala.version explicitly in my own pom.xml;
disabling the scala-2.9.x profile
setting the scala-2.10.x profile active by default in my own pom.xml

but no matter what I try I get the same error. I don't believe it's possible to use this module without someone having to set -Pscala-2.10.x on all builds.
So I'm planning to fork this library and modify the artifactid to remove this property. I'll package a modified version of this library as a module of my own project, and .

Sorry, my mistake. I had a cached pom.xml in my local maven repo and so when I set scala.version as a property in my own pom.xml this was not taking effect. I've cleaned this correctly now and I can use the 2.10.1 artifactid by simply setting these properties in my parent pom.xml:
        <scala.version>2.10.1</scala.version>
        <scalaArm.scalaVersion>2.10</scalaArm.scalaVersion>

I thought I had this solved, but the problem persists.


Add AddAuthorizeAttribute

Add AddAuthorizeAttribute Method

Have you tested it ? Is it applicable to 3. x and 2. x project

y

This is very difficult?

It is applicable to 3. x and 2. x project

Thanks , I whill check this

Thanks a lot


swupdate: scarthgap fixes

Backport of https://github.com/OE4T/tegra-demo-distro/pull/305 to scarthgap, in an attempt to resolve https://github.com/OE4T/tegra-demo-distro/issues/303
I left out https://github.com/OE4T/tegra-demo-distro/pull/305/commits/cf54e8924fdc6de733e9a28af9af20834d998990 and kept tegra194 references for the time being since based on discussion in last month's meeting it may be possible for tegra194 to ultimately be supported on Jetpack 6 through the community layer.

Verified build succeeds for the jetson-agx-orin-devkit machine, although I don't have one handy for testing.  Perhaps someone who does have it could confirm this change works.


cn_apply() Error in predict.randomForest

Hi Patrick,
I am trying to apply my trained cnProc on my query data by the following piece of code:
cnRes <- cn_apply(expList, stQuery, cnProc)
The error message that I get is the following, I cannot figure out what this is related to:
"Error in predict.randomForest(classList[[ctt]], t(expDat[xgenes, ]), type = "prob") :
variables in the training data missing in newdata"
I have been using this function successfully on other query data, but now I get this error. I believe this should be about my processor. However, when I trained the processor, everything went well.
Do you have any suggestions on how I could avoid this error and what exactly this is about?
I appreciate your help.
Rebeka

I finally figured it out, and it seems the reason why I got this error was that I used the wrong expList data in the cn_apply() function. So not the one that I used for training the processor (I tested 2 different training datasets). I hope this helps others if encounter the same error.

If you could elaborate on how you sorted this out, that would be very helpful.  I'm trying to work from the example human data, and having no luck figuring out how to get past this error.

We have now created a web application that takes as input an expression matrix (counts, TPM, or FPKM), and sample meta-data, and performs CellNet analysis. Additionally, this tool includes analysis of many state-of-the-art differentiation protocols, so that you can benchmark your results against those commonly used methds:
https://cahanlab.org/agnosticCellNet_web/

We run into the same problem. When we reconstruct the CellNet object using the expTrain and the stTrain from the downloaded cnProc (cnProc_HS_RS_Jun_20_2017.rda) object, we get a new cnProc object that fails to execute cn_apply, giving the error:
"Error in predict.randomForest(classList[[ctt]], t(expDat[xgenes, ]), type = "prob") :
variables in the training data missing in newdata"
When we run cn_apply with the original, downloaded cnProc object, this error does not occur.
@rebekabato rebekabato
could you elaborate on what you mean by  'the reason why I got this error was that I used the wrong expList'? Was the expQuery data in the wrong format / datatype? Because that does not seem to be the problem for me (when I use the same expQuery data with the downloaded cnProc_HS_RS_Jun_20_2017.rda object, the error does not occur, only when I run it with by own-made cnProc object).


Dev funding

Context: https://blog.opencollective.com/beyond-post-install/
I would like to replace our post-install message in pixi.js bundle with funding fields in pixi.js, pixi.js-legacy and @pixi/core. This is better for users in general and aligns with a community-supported approach to funding.

Codecov Report

Merging #6207 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #6207   +/-   ##
=======================================
  Coverage   76.68%   76.68%
=======================================
  Files         202      202
  Lines       10240    10240
=======================================
  Hits         7853     7853
  Misses       2387     2387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf96b4...98cb843. Read the comment docs.


⚠ Bofrost.at has degraded performance

In 94a7601, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1694 ms

Resolved: Bofrost.at performance has improved in 5489043.


Add Completed Status to Tasks

Add Task Status enum
Add Task Status to Task and to TaskListCard Display

Add task status to edit of task
Updated UG
Add space behind prefixes to enforce spacing


the index.html includes http URL couldnt show in internal network

Describe the feature:

yanagishima version:12.0
presto version:0.202
conf/yanagishima.properties:
jetty.port=38080
presto.query.max-run-time-seconds=1800
presto.max-result-file-byte-size=1073741824
presto.datasources=dev
auth.your-presto=false
presto.coordinator.server.dev=http://node101:28080
presto.redirect.server.dev=http://node101:28080
catalog.dev=hive
schema.dev=default
select.limit=500
audit.http.header.name=some.auth.header
use.audit.http.header.name=false
to.values.query.limit=500
check.datasource=false
hive.jdbc.url.your-hive=jdbc:hive2://node101:10000/default;auth=noSasl
hive.jdbc.user.your-hive=root
hive.jdbc.password.your-hive=root
hive.query.max-run-time-seconds=3600
hive.query.max-run-time-seconds.your-hive=3600
resource.manager.url.your-hive=http://node101:8088
sql.query.engines=presto
hive.datasources=your-hive
hive.disallowed.keywords.your-hive=insert,drop
hive.max-result-file-byte-size=1073741824
hive.setup.query.path.your-hive=/opt/app/hive/conf/
cors.enabled=false
JVM version (java -version):1.8.0_151
Server OS version (uname -a if on a Unix-like system): CentOS 7.2
Client OS versionCENTOS 7.2
Browser:Google Chrome v63
Description of the problem including expected versus actual behavior: I'm not sure if this is a bug or feature. So, I post as a bug first. In my environment, the presto was deploy in internal network. The server counldn't access Internet. When I visit the  yanagishima service by browser, it shows blank page. The reason is the browser can't get the ccs or js files. For example, the URL in the "link href=" line. Is it possbile include these js/css files in next releases? Such as, ace.js, bootstrap.min.js, and etc.
Steps to reproduce: put the service in internal network
Please include a minimal but complete recreation of the problem, including
(e.g.) query execution, bookmark, settings, hisotry etc.  The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

Provide logs (if relevant):NA
Provide screenshots (if relevant):NA

Sorry for replying so late.
I've wanted to include js/css files someday but I haven't been able to yet.

Sorry for replying so late.
I've wanted to include js/css files someday but I haven't been able to yet.

Is this problem solved now?


Feature/add focus gained and focus lost hooks

This PR adds a focusGained and focusLost hooks to oni. The events themselves pass in the lastActiveBuffer on focusLost and on focusGained.
Also subscribed the Oni git plugin to this event so in the case of changing git branch etc outside oni the plugin is correctly updated on returning to oni.
Fixes #1109

Just tested this out - looks great, @Akin909 ! 👍 Will bring it in now.
Thanks for the contribution, and happy new year's eve! 🎉


Update license-check.yml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

what‘s this for?


Monthly Chat Agenda May 2024 (2024-05-06 and 2024-05-20)

The agenda for the next meeting is being edited in the wiki at https://github.com/coreruleset/coreruleset/wiki/Agenda-Next
It will be copied here right before the meeting.

See #3694. I'll close this one here.


Improve Github workflow

There are two commits.
The first one will just fix warnings that the workflow currently produces by updating the actions versions.
The second one adds more improvements - the workflow will run on both main branch and PRs and it will also test that the python script(s) can run.

@happybhati thanks for approving, but as you can see, it's not working yet ;) Marking as Draft now.

Hmm, the docker login action fails on:
Error: Username and password required

That's because when the pull_request event triggers the workflow and it's run in a fork, Github will not pass the secrets.
One option would be to use the pull_request_target event:
https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks

In order to solve this, we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request.

So it would be more complicated to do. I will close this for now and revisit later.