Updates to notebook API

For https://github.com/microsoft/vscode-python/issues/15638

Updates to the notebook API

This PR is safe for the release, in fact I would highly recommend it for the VS Code Insider users & for the next VS Code release.

The changes will work with current stable & the VS Code insiders.
Removed unnecessary code that was in python extension (unblocks Insiders)
Using the cell document language instead of language in cell (the document.languageId always existed, hence this change will work in current vs code stable)
Using the cell document uri instead of uri in cell (the document.uri always existed, hence this change will work in current vs code stable)

Codecov Report

Merging #15639 (384d5ee) into main (f04e60f) will increase coverage by 0%.
The diff coverage is 13%.

@@          Coverage Diff           @@
##            main   #15639   +/-   ##
======================================
  Coverage     64%      64%
======================================
  Files        557      557
  Lines      26867    26824   -43
  Branches    3911     3906    -5
======================================
- Hits       17403    17402    -1
+ Misses      8730     8688   -42
  Partials     734      734

Impacted Files
Coverage Δ

src/client/common/application/types.ts
100% <ø> (ø)

...t/jupyter/languageserver/notebookConcatDocument.ts
5% <0%> (-1%)
:arrow_down:

...client/jupyter/languageserver/notebookConverter.ts
1% <0%> (ø)

src/client/common/application/notebook.ts
20% <100%> (+12%)
:arrow_up:


MergeQueryHs explicit H warning when no explicit Hs were actually used

I'm assuming that the following smarts actually doesn't have an explicit H
Chem.MergeQueryHs(Chem.MolFromSmarts("C-[O-,OH]"))

[20:12:40] WARNING: merging explicit H queries involved in ORs is not supported. This query will not be merged
Description
* idx 0
AtomAnd
  AtomAtomicNum 6 = val
  AtomIsAliphatic 1 = val

* idx 1
AtomOr
  AtomAnd
    AtomAnd
      AtomAtomicNum 8 = val
      AtomIsAliphatic 1 = val
    AtomFormalCharge -1 = val
  AtomAnd
    AtomAnd
      AtomAtomicNum 8 = val
      AtomIsAliphatic 1 = val
    AtomHCount 1 = val

Interestingly, removing the C- doesn't have the error:
Chem.MergeQueryHs(Chem.MolFromSmarts("[O-,OH]"))

Description:
* 0
AtomOr
  AtomAnd
    AtomAnd
      AtomAtomicNum 8 = val
      AtomIsAliphatic 1 = val
    AtomFormalCharge -1 = val
  AtomAnd
    AtomAnd
      AtomAtomicNum 8 = val
      AtomIsAliphatic 1 = val
    AtomHCount 1 = val

@greglandrum  I think this is a bug, should I add the "bug" label and start hunting it down?

The warning occurs because mergeQueryHs() is being called and there's an atom with degree higher than one that has an H query and an OR query.
It doesn't really need to show up since none of the neighbors of the O are actually Hs.
A fix to avoid the unnecessary warning would be to check in isQueryH() for a neighbor that actually is an H before showing the warning. This would be a bit slower, but this code likely isn't on the critical path for most applications.

Here are some examples from the internal Brenk set that all have the same pathology.
Brenk pattern #29 SX3[O-,OH]
Brenk pattern #31 S(=O)(=O)[O-,OH]
this one should give the warning:
Brenk pattern #46 C(=O)O[C,H1].C(=O)O[C,H1].C(=O)O[C,H1]
Brenk pattern #65 c1c([OH])c([OH,NH2,NH])ccc1
Brenk pattern #94 [OH]c1ccc([OH,NH2,NH])cc1


Drawcrowd issue

Can't seem to download from drawcrowd. I tried from other sites and it works perfectly.

+1

https://github.com/RipMeApp/ripme/issues/304


Changing existing models and training them

❓ Questions
Hello! Could you tell my, how can I change your models (24 kHz and 48 kHz) to 16 kHz, 8 kHz, because sometime we don't use audio sample rate (24 kHz and 48 kHz).
Also, how can I train models?

Hello, have you got the idea how to train the model and is there any pre-trained model?


New mobile phome pattern for Monaco (MC)

Hello!
This is filled template for metadata issue:
Country/region affected (e.g., "US"): MC
Example number(s) affected ("+1<PHONE_NUMBER>"): +377 46 180820
The phone number range(s) to which the issue applies ("+1 555 555-XXXX"): +37746XXXXXX
The type of the number(s) ("fixed-line", "mobile", "short code", etc.): mobile
The cost, if applicable ("toll-free", "premium rate", "shared cost"):
Supporting evidence (for example, national numbering plan, announcement from mobile carrier, news article):
BR! Dragan Ilic

@ildra,
Thank you for taking the time to improve libphonenumber! For your next metadata issue, we invite
you to file issues in Google's new Issue Tracker, which we're currently testing.
We can't connect to +377 46 180820. Did you have a typo?
Please share any working numbers or evidence you may have. See our guidelines.

Hello kkeshava,
No I did not have any typo. I tried to call on this number (+37746180820, from Slovenia I called<PHONE_NUMBER>820) and connected successfully. Could You try one ore time?
Thank you.
BR! Dragan

Hello,
Could you try call +377 46 18 08 20. I don't know if format  (spaces between numbers) influent on calling this number).
BR! Dragan

@ildra,
We were able to connect to +377 46 18 08 20 today not sure why it din't work yesterday, but we can't find official evidence for the actual ranges that are valid. We can't support single numbers, we need
context about the prefix that makes them valid. Please share any official evidence you may have. See our guidelines.

@kkeshava
Thank you. We will try get official evidency from our customers and context about the prefix and iform you.

Hello @kkeshava!
Any news here? Do you need any additional information?
BR! Dragan
PS: I also added this issue on  Issue Tracker application.

For further updates on this, please refer our Issue Tracker https://b.corp.google.com/issues/74225062
Closing this bug.


Opacity in fill of d3-funnel

I am trying to add rgba value to the data but in the background, it is getting converted to hex code, leaving the opacity.
How can I fix it?

This is my data array value.

Hey there. This library does not support rgba values as of this moment. Much of the color-related calculations assume a hex format. Although it is reasonable to consider adding support for rgb/rgba values in the future, it is easier for now to just add proper support for opacity. I will add this as a future enhancement.
Side note: the format you are using for data conforms to the deprecated array-style.

@jakezatecky thanks.


Notes for civic.json implementation

Mozilla uses a contributors.json for https://www.contributejson.org/ via @CaptainCalliope
Also, need to make it really easy, as this will end up being one of the main ways non-code projects get included.

@tmaybe had the idea of using a README badge for storing this info, rather than another file ...


Is the information panel we refer to as File Offset the RVA?

Describe the bug :
As stated in the subject line, I am looking for the Copy RVA feature, but I am not reaching the correct result
To Reproduce :

Expected behavior :
To provide the correct RVA value.
Screenshots

Environment (please complete the following information):

OS: [Windows 10 22H2]
Java Version: [17.0.9]
Ghidra Version: [11.1.2]
Ghidra Origin: [e.g. official GitHub distro, third party distro, locally built]

No, the File Offset is not the RVA.  Generally speaking, the RVA is (Address - Imagebase).  We don't have a field for that, but if you hover on an address, it is listed as Imagebase Offset.

Then let's change the topic to a feature request. We are looking forward to 'GO TO RVA' and 'COPY RVA' features. Good luck.


Load mushroom dataset via URL

genfromtxt can also read data from URL. Data downloads in ~1sec
Makes the tutorial more convenient.

That is more convenient, thank you.


💥  new build system => publish from ./dist :octocat:

♻ (packages)

NPM build from ./dist
tsup.config.ts
Refactor package.json scripts
new copy.sh scripts
updated clean.sh script
Add LICENSE to npm
Updated release.config.cjs

This is still a bit hacky

💚 on custom copy make sure to change dir
💚 release.config.cjs
💚 copy.sh testing w/ :octocat:
💚  sed differences b/t osx|linux 🍏 :octocat:
👷  remove ci/npm-dist
Technically this only potentially broke a few packages, however, good to level set (and plus all files were touched in the build system).
Upgrade Path
@jeromefitz/codestyle

Change import to @jeromefitz/codestyle/lint-staged.config.js

@jeromefitz/conventional-gitmoji

N/A

@jeromefitz/git-cz

N/A

@jeromefitz/notion

N/A

@jeromefitz/semantic

Change import to @jeromefitz/semantic/changelog.config.js

@jeromefitz/semantic-config

This reworked release.config.js throughout, but is internal to packages

@jeromefitz/scripts

Eh, moved to .ts files but did not test anything as I have not used this to set up a repo in awhile.
🏷 types are very much needed (everywhere, haha)

@jeromefitz/spotify

N/A

BREAKING CHANGE: 💥 Check your imports as all packages now npm publish from ./dist

All builds verified off of<EMAIL_ADDRESS>


Not Production-Ready / SemVer compliance

Hi. I'd like to know when will this be ready for production use?
Thanks. Any response is much appreciated.
Also, I suggest you use SemVer (as composer recommends) for your release version pattern.

Your API is good and sufficient, I hope my email response from<EMAIL_ADDRESS>could be subjected to be answered for later purposes. :)


Jmps java 9

Adding JPMS module définition to picocli.
Adding new subproject picocli-core-module

I went ahead and merged the PR.
Thank you for the hard work!
With the version check the build now passes on Java 8, so it's looking good!

Link to the original issue:
https://github.com/remkop/picocli/issues/495

I went ahead and merged the PR, and already made the above changes. I'll put further comments on #495.


Camera remains on after setting "tracker" to false.

I'm not sure what's happening, but it seems like tracker= doesn't work for me:
const [stopDecoding, setStopDecoding] = useState(false);
... code ....
<QrScanner
            stopDecoding={stopDecoding}
            tracker={false} // tracker={stopDecoding} <-- I tried using false in purpose to see how would this act. Camera remains on.
            onScan={(value) => {
            console.log({ value });
         }}
     onError={handleError}
     aspectRatio="1:1"
/>

Please try the new beta release 2.0.0-beta.8. There are breaking changes for this beta release.


After searching and replacing text the text font size of the replaced text is set to 12pt

I am using docx and regex to find and substitute certain keywords from the word doc. The finding and substituting is working fine. When the word is replaced it is set to a much smaller font than before, sometimes. This behavior is inconsistent - on some sections the text is replaced with the correct (matching previous text) font size.
I have not been able to find anything on this topic. Can anyone explain if this is expected behavior and if so how I can correct it?
I have tried inspecting the font size of the text before and after the substitution. According to the logs they are the same size but in the actual saved document they are not.
all fonts = Times New Roman
Original [docx] File:

[name, city, state, date] :: [font size]
[26, 12, 12, 13]

Saved [docx] File:

[12, 12, 12, 12]

Logs from Python:

  'after: \t\t        Pat  : 152400',

  'before:                                          courseCity, courseState : None',

  'after:                                          San Francisco, courseState : None',

  'before:                                          San Francisco, courseState : None',

  'after:                                          San Francisco, CA : None',

  'before:     \t\t\t       courseDate : 152400',

  'after:     \t\t\t       June 39, 2023 : 152400',

and the code itself (log points @ line 25 and 27):

#--- input from server ---#

task = sys.argv[1]

// parse as JSON in python to enable dict-like action on the student objects contained in the students array
students = json.loads(sys.argv[2])

#--- current date ---#

currentDate = time.strftime("%B %d, %Y")

## -------------- CORE FUNCTIONS ------------ ##

def findAndReplace(student, body):
    if 'currentDate' in body.text:
        find = re.compile("currentDate")
        body.text = find.sub(currentDate, body.text)
    for studentInfo in student:
        if studentInfo in body.text:
            find = re.compile(studentInfo)
            print('before: ' + str(body.text) + ' : ' + str(body.style.font.size))
            body.text = find.sub(student[studentInfo], body.text)
            print('after: ' + str(body.text) + ' : ' + str(body.style.font.size))

def newDoc(task):
    for student in students:

        # open a new template document for each student to prevent overlap
        document = docx.Document("./AutomationTemplates/" + task + "_template.docx")

        # check paragraph text
        for paragraph in document.paragraphs:
            findAndReplace(student, paragraph)

        # check table cells
        for table in document.tables:
            for row in table.rows:
                for cell in row.cells:
                    findAndReplace(student, cell)

        # save the document when finished
        document.save("./AutomationResults/"+ task + "/" + student["studentName"] + "_" + task + ".docx")

    print(task + "s created in /AutomationResults/" + task)

## ------ CALL THE NEW DOC PASSING THE AUTOMATION TASK -------- ##

newDoc(task)

The inconsistency can be seen in my other file that I used for testing automation. In that file all the font that was replaced remained the correct font size and family.

Using the Paragraph.text property to replace text is convenient, but a bit of a brute force method. All the text formatting is specified at the run level, and it all gets nuked when you assign to Paragraph.text because that call removes all the existing runs before adding a single new one containing the assigned text.
It's a pretty hard problem in the fully general case, but what I usually do that works well almost all the time is to remove all the runs in the paragraph except the first one, and set its text to what I want. Generally, the first run is formatted the way you want, in my experience at least.
def set_cell_text_while_retaining_text_formatting(table_cell, text)
    # ---replace text of first run with new cell value---
    runs = table_cell.text_frame.paragraphs[0].runs
    runs[0].text = text
    # ---delete all remaining runs---
    for run in runs[1:]:
        r = run._element
        r.getparent().remove(r)

Thank you @scanny I will have to try this function. I am a bit confused - I came across this repo which says it is now merged with python-openxml. If that is the case than are these features available? I dont see anywhere in the documentation how to use them.
https://github.com/mikemaccana/python-docx
Editing documents
Thanks to the awesomeness of the lxml module, we can:
Search and replace
Extract plain text of document
Add and delete items anywhere within the document
Change document properties
Run xpath queries against particular locations in the document - useful for retrieving data from user-completed templates.

That repo is the legacy version of python-docx, version 0.2. It was rewritten from the ground up for various reasons, a big one was to make it object oriented. None of the original code survived and the API is completely different. There are one or two things it tried to do that we haven't implemented yet in this version, search and replace being one of them. However I think you'll find it didn't really work in that earlier version, except for perhaps some very narrow use cases.

I had a similar issue when trying to substitute parts of text found via regex.  My template document was font size 10, but the somehow the replaced text got set to font size 11.
To preserve the original size, here is an adapted solution pertaining to paragraphs (not tables as seen above).  While iterating document.paragraphs,  remove paragraph.text = text and call this function in the loop.
def set_text_preserving_text_formatting(paragraph, text):
    """Return None; remove all but the first run object from a paragraph."""
    # Replace text of first run paragraph
    runs = paragraph.runs
    if not runs:
        return

    runs[0].text = text

    # Delete all remaining runs
    for run in runs[1:]:
        r = run._element
        r.getparent().remove(r)

Note, I have not tested this extensively.  @scanny Thank you.  Your code saved the day.

This function can reliably replace a certain word or phrase with another in a paragraph, retaining the formatting of the original word: https://github.com/python-openxml/python-docx/issues/30#issuecomment-879593691


build: Allow to specify compression type of the result image

BuildKit v0.10 will introduce some improvements for image compression. https://github.com/moby/buildkit/releases/tag/v0.10.0-rc1
This includes support for zstd and estargz compression types and support for --force-compression option.
It would be great for nerdctl build to have support for compression types.
nerdctl build -t test --compression=estargz --force-compression /tmp/ctx

Why not use --output

Because --output doesn't support loading images  to containerd, IIUC.

Because --output doesn't support loading images to containerd, IIUC.

Can we just implement rootless containerd worker and use --output type=image?

Can we just implement rootless containerd worker and use --output type=image?

SGTM


WR 1582 french banner editable in cms

This branch requires some manual configuration due to "config_ignore" settings.
Go to /admin/structure/block
Click 'Place block' button next to 'Hidden (For Blocks and Paragraphs'
Find 'WorkBC Switch Language Block - WorkBC' and click 'Place block'
Ensure machine name is 'workbcswitchlanguageblock'
Uncheck 'Display title' in block configuration
Check 'Page' under 'Content type' tab
Click 'Save blocks'

Basic testing worked well, thanks. Some comments:

Make sure this system works for WorkBC Centres out of the box (i.e. the new block is enabled for WorkBC Centres and works as expected there)

Provide a migration path for the existing pages that are hard-coded to contain French links (as evidenced by their custom blocks in the attached screenshot). For example:

Disable the shown blocks
Write a migration for these pages to populate their multilingual fields
OR Write a recipe on adding links to these page explicitly

Make sure that the theming for the links is consistent. Attached is the same link rendered for pages with and without hero images:

To enable multilingual support for WorkBC Centre content type:
Go to /admin/structure/block
Click 'Configure' for WorkBC switch language block
Check 'WorkBC Centre' under 'Content type' tab
Click 'Save blocks'

WorkBC Locations now work out of the box

Removing original French Link section in Page twig file resolves the inconsistent link rendering b/w Hero Image and no Hero Image pages.  NOTE: This will result in links to French pages to disappear.  The appropriate pages will need to be edited to add the appropriate links.

The following pages and their corresponding French pages need to be edited to use the new Multilingual functionality.

Contact Us
Online Employment Services
Employment Services
Who Should Visit Workbc Centre
Self Serve Services
Workbc Centre Locations

For each page:

Edit English page
Search and select corresponding French page in Multilingual Page -> URL field
Enter appropriate text in Multilingual Page -> Link text field
Save page
Edit corresponding French page
Search and select corresponding English page in Multilingual Page -> URL field
Enter appropriate text in Multilingual Page -> Link text field
Remove "Service in English" button/link from Body field (if desired).
Save page

Both pages should now display a link to the other page.


IP Restriction plugin: support range IP format

It would be useful to support IP format with network mask like this:

<IP_ADDRESS>/22
<IP_ADDRESS>/22
<IP_ADDRESS>/22
<IP_ADDRESS>/12
<IP_ADDRESS>/18

@AndrewDryga this was done in a fork, https://github.com/edenlabllc/annon.api/pull/3. Maybe it can get merged upstream too? Here's the patch you can apply manually: https://github.com/edenlabllc/annon.api/pull/3.patch


[FLINK-28902][tests] rename FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add Internal to test methods part

What is the purpose of the change
rename FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add Internal to test methods part
Brief change log

rename FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add Internal to test methods part

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change changed one test class for naming convetion and can be verified as follows:

mvn clean verify

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@flinkbot run azure

Thanks for review. I created another PR https://github.com/apache/flink/pull/20845 .

@tonyzhu918 For the next time: You don't have to close PRs. Updating the corresponding branch is good enough. The benefit of using a single PR is to have all the discussion around code changes in one place.

@XComp got it and thanks!


fix: Visual bugs when using the bridge + sending two transactions instead of one

Describe the bug
Hello!

When using the bridge, after a successful transaction, the site still won't let me send a new transaction through the bridge (as if the past transaction didn't end).

As you can see, in MetaMask the transaction passed, but still not on the site. And so for a very long time after the transaction in MM.

After sending the transaction I wanted to speed it up, so I have visually generated two different transactions

As you can see, I have two transactions of 0.05 ETH, but I sent only one.
Tx of the transactions is also backed up, but one of them doesn't work.
Tx of a normal transaction: 0x513cd2d896965dece18b1a9519f87703a8eb048941387fa4bbae86f2a1e3c087
Tx of the repeated transaction: 0x24b3e3fa5adea07831ab5a4c19d861072638a8aa0ee6ea7eadf562ec1f8be5e5
(explorer does not find it, but it is nevertheless displayed in the bridge interface)
Steps to reproduce
No response
Additional context
No response

cc @shadab-taiko wonder if this is still an issue? we did make a fix for it, so maybe you found an edge case here.

cc @shadab-taiko wonder if this is still an issue? we did make a fix for it, so maybe you found an edge case here. we can also close this if we are doing the bridge-overhaul, it may no longer be relevant. but tagging you for visibility

If necessary, I can try to repeat the same errors and test their reappearance

@jscriptcoder could you triage this issue?

After some polishing on the bridge and better error handling, I can no longer reproduce this issues.


Wrong Representation of Lists in Preview

When making a numbered list that is written as:
1.
2.
3.
etc...
the preview shows these first as correct, but once text is added after the period(regardless of if space is left between the period and the first character) it will change the preview to be a bullet point instead the proper number.

This is a known issue #45. Not much I can do about it unfortunately...


New widget: RangeInput

In react-instantsearch, there is a RangeInput widget to be able to set a range with two inputs. We can implement with connectRangeSlider. In the process, we should probably alias connectRangeSlider to connectRange and deprecate connectRangeSlider.

I looked into the existing components and I found that PriceRanges is pretty much the same as the RangeInput. Basically the PriceRanges is a composition of a RangeInput with a list of ranges.
So instead of using the connectRangeSlider as connector, we might use the connectPriceRanges to implement the RangeInput widget and reuse the RangeInput component inside PriceRanges. With this we can remove the logic for the inputs in PriceRanges and handle only the refinement on ranges.
As a side note, we can also rename the PriceRanges widget (& connector) for a more generic name like RangeInputList (any ideas?) because it's not strictly limited to a range of prices. We can imagine it with sizes, weights...
What do you think about it?

Nice comments @samouss 👍 I have a few questions remarks:

ok if the the connectPriceRanges makes more let's go for it
do you suggest to remove the inputs in the price ranges?
ok for changing the name. However I would still alias the new names to the old so that we don't introduce a breaking change here, add a deprecation notice and drop the deprecated names when we move to a new major version.

@bobylito Yes, I suggest to remove the inputs and replace them with the RangeInput component built for the RangeInput widget (without changing the behavior of PriceRanges).

Ok then as long as we don't break the public API that's perfectly fine! 👍

Thank you for the proposition @samouss I was having the same thoughts at some point and it goes into the direction to have the same widgets name on every instantsearch.js library 👍


Extract definitions from names.py to config files

Extract the definitions from names.py for the additional flexibility it would provide and more generic code it would produce.

Agree that we want to move the naming dicts out of the code probably into yaml files.
We don't have a space for these files, would that be a new subdirectory? Maybe data/names.yml
And just to be sure, we are talking about those fields?
lst = "LST"
mst = "MST"
sct = "SCT"
sst = "SST"
hess = "HESS"
magic = "MAGIC"
veritas = "VERITAS"

all_telescope_class_names = {
    lst: ["lst"],
    mst: ["mst"],
    sct: ["sct"],
    sst: ["sst"],
    hess: ["hess"],
    magic: ["magic"],
    veritas: ["veritas"],
}

all_camera_names = {
    "SST": ["sst"],
    "ASTRI": ["astri"],
    "GCT": ["gct", "gct-s"],
    "1M": ["1m"],
    "FlashCam": ["flashcam", "flash-cam"],
    "NectarCam": ["nectarcam", "nectar-cam"],
    "SCT": ["sct"],
    "LST": ["lst"],
}

Also note here that DPPS / ACADA also introduce a numerical telescope identifier, see this gitlab page

I am wondering if we still want to do that: having the name definition in parameter files is not much different to having them directly in the code. I would rather move towards using the database for certain entries in name.py (especially for all_model_version_names).

For the dictionaries I agree it might be useful to use the DB, but for such simple parameter name definition such as lst = "LST" we don't need to overcomplicate and get it from the database.

We have discussed this again in the context of issue #797 and PR #761 , and introduced a simpler naming of telescopes. I suggest therefor to close this issue and leave the naming as dictionaries in names.py.

This has been addressed in #889 - all telescope naming is removed from names.py


[Test] Disabled distributed_actor_remoteCall.swift.

To unblock PR testing.

We need to limit it to OS=macox instead of disabling everything, I'm going to open a PR for that.

It was blocking PR testing, so it got disabled.

Please ping me next time this happens, I'm going to take care of it.


non-integer thresholds

After talking with the middle school teachers some more, I'm convinced that we should avoid using integer thresholds in problems. Students get confused by the fact that the neuron uses strict inequality (greater than, not greater than or equal to), which leads to misunderstandings. These can be avoided by using fractional thresholds.
For all problems where the threshold is 0, set it to 0.5.
For all problems where the threshold is 1, set it to 1.5.

Verified.


Issue #60: Pull contributor list from Github

Contributor list now pulled from Github, listed in About screen
Tapping on name redirects to Github profile instead of Reddit
Added some mocks for FakeSelfUpdater, not sure how to handle changing to mockDebug flavour though, I've just been hardcoding a switch to test:

        SelfUpdaterModule s = new SelfUpdaterModule();
        if (BuildConfig.FLAVOR.equals("mockDebug")) {
            //selfUpdater = s.provideSelfUpdater();
        } else {
            selfUpdater = s.provideSelfUpdater(new UserAgentInterceptor(this));
        }

Added some mocks for FakeSelfUpdater, not sure how to handle changing to mockDebug flavour though, I've just been hardcoding a switch to test:

See this example, our AppComponent says that there is a ScraperModule.class which should be used to fulfil dependencies.
And then we have two implementions of that ScraperModule.class:

one in the mock build variant
one in the production build variant

Depending on the setting in Android Studio or the gradlew build command that is issues, one build variant is used, and depending on which one, the ScraperModule provides a different implementation of our MediaScraper.

Oops, my bad, accidentally deleted it, naming branches after issue numbers seems to not be a great idea

If this implementation is okay, could you merge so that I can try to do #44 without conflicting with this PR? It doesn't seem too complicated and I should be able to put it together fairly quickly as part of 0.7.0
Thanks so much for taking the time to help!

Looks good.

Why is it called SelfUpdater ? Sounds like something apk update related.

It was originally there just to check for the latest version of the app on GitHub, but since it could handle the get contributors request with just a few extra lines of code, I opted to just expand its functionality. I was thinking about refactoring it to githubRepository or something more appropriate like that, but didn't get around to it - should I make a separate PR to do that?

AH right, makes more sense now. PR's are always welcome, for any kind of positive change.


Code highlighting does not exist

:tada: This issue has been resolved in version 0.107.0 :tada:
The release is available on:

v0.107.0
GitHub release

Your semantic-release bot :package::rocket:


Change maxDigitsPerRequest to higher value.

Searching for values inside PI sequence would be very faster after changing this limit.

This API is a demo and it's not intended to be used to scan a lot of digits. For bulk access, consider downloading directly from the Cloud Storage bucket: https://storage.googleapis.com/pi100t/index.html


feat(paymaster-proxy): add basic in-memory rate limiting

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #52

PR #54

PR #55

PR #57

PR #58   👈

This stack of pull requests is managed by Graphite.


Remove organization member read permission from GitHub App

We can lessen the permission that our GitHub App requests, by removing the organization level permission "Members: read".
Background
In order for a user to enroll and own a provider, we want to ensure that they are an owner of the GitHub organization that's associated with the provider.
When initially designing the GitHub App flow, we intended to use the organization members API to ensure that the user is a member and has the correct role.
Instead, we came up with an alternative implementation, which fetches the app installations that the user has access to and validates that the user has permissions on the installation, implying that they have the right permissions on the GitHub org.

I removed the organization permission from the "Minder (Staging)" GitHub App first. I'll keep an eye on it and run some tests before doing the same with the production app.


Missing dependency issue: bluebird

I love the idea of a promise based API wrapper for Fastbill automatic, but there seems to be a missing dependency issue in the current version:
Error: Cannot find module 'bluebird'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:289:25)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (C:\Users\Sebastian\snapaddy\snapaddy-payment\node_modules\node-fastbill-automatic\build\lib\utils\http.js:35:17)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:313:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)

Hi Sebastian,
Thanks a lot for reporting the issue. It should be fixed now!
There was indeed an old bluebird import to mock Promises non-natively from back it was needed.
Regards,
Max


PayPal donation link doesn't work.

Description
PayPal donation link doesn't work.
Please update the PayPal link at FUNDING.yml
Thank you

Hi @ofir-bar. First of all thanks for your issue. You are right it's wrong because I change it in this time :). I appreciate your interest on the donation, but I created this project in terms of inspire people to combine different new technologies on android with a modular architecture. Designing in this way scalable, maintainable and last but least testable. Obviously, nothing is perfect and this project isn't. Are a lot of things to improve and iteration for me is the key.
I'll be more than happy if this one helps you to inspire/apply some of the practices used for you current or next project ;)

Oh.. be sure my friend, this helps a ton for me.
Thank you


Configuration files

Originally reported by: Carsten Burstedde (Bitbucket: cburstedde, GitHub: cburstedde)

Some people like to call apps with a relative path, meaning that they have to change the .ini file in the current directory every time they want to run a different app. When make installing forestclaw, the .ini files will all end up in one directory. These points suggest that all .ini files throughout the source should have different names. What about the following logic:
There is a file defaults.ini that every program loads.
Then the program loads programname_defaults.ini, without the fclaw*_ prefix.
The location where these ini files are searched in order of precedence:

Current directory
Same directory as the binary being called
Directory in $FCLAW_INI_DIR environment variable
Directory where the .ini files are make installed in (which must not be the directory where the binaries are installed in)

Does this cover all cases? We'd need a directory for defaults.ini.
What about the fclaw_clawpack.ini file? Please suggest an analog logic. Do we need application specific .ini files at all in this case?

Bitbucket: https://bitbucket.org/donnaaboise/forestclaw/issue/66

While still important to think about this, it isn't a priority right now.


feat: Adding Decorative + Shadow Colors / Fix Background.discount

Changes description
Adding Decorative + Shadow Colors / Fix Background.discount
Context
Needed new colors for my project
Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[x] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.

Does this introduce a breaking change?

No

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@baptistedajon feel free to fix conflicts.
Can you please take this opportunity by taking this issue: https://github.com/Decathlon/vitamin-ios/issues/23?
Thanks

@lauthieb : I made the last changes, resolved the conflicts, and integrated the missing refacto from #23 (some of them had already been integrated before)
I also linked the corresponding issues to this PR
Whenever @florentlotthepro or @baptistedajon approves, I will be able to merge it
@florentlotthepro : I did not write any new comment, there should be no typos this time ;)


Offer command to go ahead and install all needed binaries

As a DevOp, I would love for cargo-run-bin to offer a simple command that goes ahead and proactively installs all of the CLI tools available in any of the Cargo.toml dev dependency subtrees. For example, I may have limited Internet access, and so I want to get all the tool installations over and done with early.
Some tools, especially linter tools, may inherently fail during their first (cargo run bin) execution, if a given project has linter warnings. This complicates error handling logic in development environment provisioning code, such as when preparing a Docker image.
You might suggest, "Just run the equivalent cargo run bin <tool> commands early." Well, unfortunately, as a DevOp, that is not so maintainable. It's fine if exactly one tool is involved. But some projects involve many dozens of linters and other tools. It quickly becomes a hassle to have to type out the commands one by one.
One workaround involves writing a document or shell script with all of the cargo run bin <tool> commands, one after the other. But a document, or a shell script, would be writing the same information down twice, when we already have it available in Cargo.toml. And a shell script means fragility, it means deviating from Rust/Cargo workflows, it means having to install additional non-Rust tools just to lint the shell script. It means breaking support for Windows software developers who don't spend 100% of their time in WSL. It means forcing WSL, or batsh, or fish, or Cygwin, or other junk... which grows the software stack unnecessarily.
Please, something like cargo run bin --install that proactively installs all of the Cargo.toml dev binaries, would be lovely!

Fixed in v1.0.0. Thanks for the recommendation!

The tool will no longer look for binaries within [dependencies] and [dev-dependencies]. All crates must be configured within package.metadata.bin

Has the Rust convention changed?
Are cargo run bin users expected to declare dev dependencies twice?
How can we modify cargo run bin to integrate with conventional dependencies and dev dependency Cargo.toml sections?

@mcandre executable dependencies are not dev dependencies.
What integration are you looking for?


How to use test.mock if result is a Union type

In this example in my code, the query returns always empty:
it('Should return store by id', () => {
   const query = `
     query($id: ID, $slug: String) {
       store(id: $id, slug: $slug) {
         ... on Store {
           id
           name
           slug
         }
       }
     }
   `;

   const fixture = {
     data: {
       store: {
         id: '1',
         name: 'AnyoneStore'
       }
     }
   };

   const variables = {
     id: "1"
   };

   const { data: { store } } = tester.mock({ query, fixture, variables });

  // store
 / / {}

Can you share your schema please, so I can reproduce it locally?
As you can see here it should be working fine for unions,


[BUG] springboot2.0 monitor health  "status": "DOWN"  No Metrics Data

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
springboot2.0 monitor health { "status": "DOWN" }  collected donotwork and show No Metrics Data
but  "status": "UP" collected work
Expected Behavior
No response
Steps To Reproduce
No response
Environment
HertzBeat version(s):
1.2.3

Debug logs
No response
Anything else?
No response

i think is the http code problem
can i edit app-springboot2.yml config file ignore this 503 code to collected DOWN data?

can i edit app-springboot2.yml config file ignore this 503 code to collected DOWN data?

@jvhuaxia current not support. weclome to update collecting metrics code to implement this.

Design Http Collect YML Format.
Add successCode field, the successCode means what http response status code we consider it collect success.
    http:
      host: ^_^host^_^
      port: ^_^port^_^
      url: ^_^base_path^_^/health
      method: GET
      ssl: ^_^ssl^_^
      successCode: 200,503
      parseType: default

maybe I can work on this, pls asign to me

hi welcome @l646505418 , i think we should update the http protocol file https://github.com/dromara/hertzbeat/blob/master/common/src/main/java/org/dromara/hertzbeat/common/entity/job/protocol/HttpProtocol.java
Add Field.

    /**
     * http success status code. default 200
     * successCode means what http response status code we consider it collect success.
     */
    private List<Integer> successCode = List.of(200);

And update http collecting implment.  https://github.com/dromara/hertzbeat/blob/master/collector/src/main/java/org/dromara/hertzbeat/collector/collect/http/HttpCollectImpl.java#L118


lnwire: fixing buffer size and cleaning up uint16/32 conversion

This PR removes an unnecessarely large 32 byte buffer in favor of a small 2 byte buffer and cleans up type conversion between uint16 and uint32 values.

@bhandras needs squash

@bhandras needs squash

done! :)


Request for Support of All Groq Models

Would it be possible to support the other models available on groq cloud not just mixtral? It would be great to be able to use llama3

Yes! Had it on my todo list already 🙂
Just released 0.6 which includes support for all models from Groq, Ollama, OpenAI, and Anthropic!
Let me know if something doesn't work as expected!

Add Groq Llama3 is actually the new default! The speed of Groq and the capabilities of Llama3 is just an awesome combo!


Is Async really Async and for an in memory database on a phone is there any advantage in using it ?

I refer specifically to this article here and would appreciate feedback and comments:
https://xleon.net/xamarin/dotnet/sqlite-net/async/2017/02/15/sqlite-net-async-vs-sync/
https://www.sqlite.org/asyncvfs.html

async is not a panacea, in the right places it does it's job properly, by far the biggest performance improvement I got was not from async on phone development but leaving database connections open forever, sometimes synchronous code is what is needed a bit like sometimes there is a need for a denormalised table, just flat no joins etc.
All about the use case, but as a general rule keeping processing off the ui thread is a good thing.


FR: Expand shell variables in

This is a really neat tool! It would be great if shell variable expansion (or something similar) would be possible in the config file. For example, it would be nice if the following worked:
{
    "openai_api_key": "$OPENAI_API_KEY"
}

This would make it easier to store the config file in git.

now it will read env var as default value https://github.com/egoist/shell-ask/blob/main/docs/config.md#openai_api_key-optional

Really great, thanks!


GPU NMS kernel in TF 1.15rc0 was not fixed

This commit:
https://github.com/tensorflow/tensorflow/commit/9480262cbbfc2430b0c53424f0fc133418d7ae3f
was included in TF 1.15rc0.
However, this commit has a bug as pointed out in https://github.com/tensorflow/tensorflow/pull/28745#issuecomment-512949342.
The bug is fixed in https://github.com/tensorflow/tensorflow/commit/5d6158e0d4a736a8ad2fc98b717fed519e4080f0, which is not included in TF 1.15rc0.
I expect TF 1.15rc0 to include the bugfix for the GPU version of NMS kernel.

Can you make a cherry-pick of https://github.com/tensorflow/tensorflow/commit/5d6158e0d4a736a8ad2fc98b717fed519e4080f0 please? Assign to me


CSS libraries added

issue #637
Please review @rupali-codes @CBID2

@rupali-codes @CBID2  done check it again

done @CBID2


docs: update predeploy section with latest predeploys

Seems https://specs.optimism.io/protocol/predeploys.html does not contain all predeploys like Multicall3 and SafeSingletonFactory
https://github.com/ethereum-optimism/optimism/blob/develop/op-bindings/predeploys/addresses.go#L9-L38

These are known as preinstalls so are in a separate section. We use this terminology to differentiate from standard OP Stack predeploys because preinstalls are written by third party developers and consequently we can't assume they have the same security guarantees.
However:

The create2deployer is in the predeploys section, but should be moved to preinstalls
The preinstalls are missing an entry from the specification overview (screenshot below)

So I'll leave this issue open to account for those

thanks @mds1 - closing


Convert public headers to doxygen style

Addresses #1059
(Replaces #1307)

Thanks for your work on this @zachlewis . Much appreciated.

Hi @zachlewis, thanks for reviewing the documentation as that's important for the new release. What is the status of the pull request?

Heya @hodoulp -- this PR should be good to merge -- the public headers have been converted to doxygen style.

Hi @zachlewis, when you will have some time could you fix the merge conflict & fix the @doug-walker comment?

Hi @zachlewis, when you will have some time could you fix the merge conflict & fix the @doug-walker comment?

Done and done!


Automated cherry pick of #1178: virtual resource details rename domain to project_domain

Cherry pick of #1178 on release/2.10.0.
#1178: virtual resource details rename domain to project_domain

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@09f6a06). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1179   +/-   ##
================================================
  Coverage                  ?   7.93%
================================================
  Files                     ?     365
  Lines                     ?   57198
  Branches                  ?       0
================================================
  Hits                      ?    4540
  Misses                    ?   52259
  Partials                  ?     399

Flag
Coverage Δ

#aFlag
7.93% <0%> (?)

Impacted Files
Coverage Δ

pkg/cloudcommon/db/virtualresource.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f6a06...ed46ba9. Read the comment docs.

/lgtm
/approve


Add query-runs attribute to repeat all queries in sequence

Repeating the same query multiple times can yield inaccurate benchmark results because the JVM can optimize for it. This is not reflecting real-life usage. By allowing to repeat all queries in a sequence, benchmark results should better reflect the actual performance.

@sopel39 PTAL

Could add in the description a motivation to do it?

I just realized I added the extra loop too deep, I was confused by a benchmark having getQueries() method where we usually have a single query there and multiple benchmarks.

Replaced with #56


Index type has wrong data type..

changed param description from T to Text, due to wrong caption..

Thanks for the feedback and contribution. We cannot take in your PR because it modifies the section which is generated from the source code. We'll open a bug instead. Closing this PR. The topic will be refreshed once the bug is fixed. Thanks.

Hello, an update on this. We will add the following remark to the topic. T is a dynamic type and can be either an Integer or a Text. We're adding the following:
Remarks
The type T is a dynamic type. When List is of type Text then T will change to Text. When List is of type Integer, then T will change to Integer.


build(openapi): upgrade openapi-generator version

Commit to be reviewed

build(openapi): upgrade openapi-generator version
Primary Changes
---------------
1. Updated openapitools.json file

Secondary Changes
----------------
1. Some of the generated kotlin files are updated with the new code

Signed-off-by: jagpreetsinghsasan<EMAIL_ADDRESS>

@petermetz I have created this PR to upgrade the openapi-generator (Some kotlin generated files got updated in the process, waiting for the CI to see if it breaks anything or not)
Now the openapi-generator-cli uses the new 5.2.1v of openapi-generator, thanks for pointing the relevant file for this change

This version upgrade was necessary, as while generating kotlin clients for all the plugins #468, there was an issue with the openapi-generator, https://github.com/OpenAPITools/openapi-generator/pull/10070, which was merged in v5.2.1, hence the necessary upgrade.
As suggested by @petermetz , I upgraded the version across all relevant files, to maintain version uniformity across various dependent packages.


[ami]:modify arm based ami

During artifacts-ami-test-arm in 4.6 we got the following error:
Launch Failed
The instance configuration for this AWS Marketplace product is not supported. Please see the AWS Marketplace site for more information about supported instance types, regions, and operating systems.

@benipeled pointed out that we are using a worng based ami for arm.
Fixes: 	https://github.com/scylladb/scylla-pkg/issues/2659

Verified by building new ami image (https://jenkins.scylladb.com/job/scylla-4.6/job/releng-testing/job/ami/6/) and running https://jenkins.scylladb.com/job/scylla-4.6/job/releng-testing/job/ami/6/

/cc @benipeled

@fruch yes i will do it


DEV: Fluid Reports: Mapping - Ingesting the Mapping

EPIC:
#491 Fluids Report Implementation
PARENT:
#493 Add to Store (C) Fluids Report Object
SIZE:
4 hours = 1/2 day = 1 point (confirm size with TS)
Ingestion Mapping for ADD to Store

Update: All CRUD Objects will ingest the mapping. Since this is inherent in the objects' design, I will close this card as "understood that this is happening this week, and as each CRUD object closes, it will be done."


deferred_allocs consistently fails with the UCX backend when separate channels are used for small vs. large messages

https://gitlab.com/StanfordLegion/legion/-/merge_requests/950
https://gitlab.com/StanfordLegion/legion/-/jobs/5240234828
The deferred_allocs test incorrectly depends on the order of active messages sent/received by the network module. When we use 2 separate workers (channels/end points) to separate small messages form the large ones, the test consistently fails with `
test/realm/deferred_allocs.cc:178: void directed_test_memory(const TestConfig&, Realm::Memory, Realm::Processor, const char*, const char*): Assertion `ii.alloc_result' failed.

Will disable the test for now as per suggestion from @streichler

This should probably be added to #1305


Final ACCURACY

Thank you for your great work!
I understand that there is eval_ucf101.py to get the overall accuracy. I am not sure how to use it though. I read that i can use it like the activity net classification and also I have been reading that there is ucf101_01.json which I think it the groundtruth of ucf101 but also I dont know where I get it from.
I would appreciate anybody's help.

Closing this issue as I had to use this command line.
python utils/ucf101_json.py annotation_dir_path

What is "pandas" in the import line? I get error of "pandas" module not found.


[DOC] dead links

What do you want to do?

[ ] Request a change to existing documentation
[ ] Add new documentation
[x] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
There are multiple 404s in the documentation, wouldn't it be useful to run a robot through it collecting them and give a list to fix?
Anyway, my specific one is
https://opensearch.org/docs/latest/search-plugins/sql/ppl/index
which links to
https://opensearch.org/search-plugins/sql/ppl/functions/
which does not exist. I guess /docs/ is missing.

(I can run a link verifier if you'd like me to, but I am very new around so shouldn't just offer to actually fix them.)

@Naarcha-AWS may I take this one?

Which version are you running? We know that in earlier versions of the documentation we have several link issues. See https://github.com/opensearch-project/documentation-website/issues/5472.
We do run a link checker with each build, so the latest documentation should be dead link-free.

@hdhalter,
Just created PR #5528. They problem was very minor. prefix {{site.url}}{{site.baseurl}} was not included in the link Commands under the PPL commands section.

(Yes but I think I have seen some other dead links in the course of installing, including ones referenced from dashboards' help.)

@grinapo,
Please try to gather all those dead links you find and open a separate issue or update this one. I will take a look at them and compare it with issue #5472 mentioned by @hdhalter.

Please open a new issue if you find other broken links or feel free to submit a PR for a quicker fix. : ) Thanks.

Please try to gather all those dead links you find and open a separate issue or update this one.

Responding here, since my linkchecker told me that there are no further dead links in /docs/latest/. Thanks!
2732 links in 2734 URLs checked, no errors


getChannel().getVideos() method doesnt work in some channels

Steps to reproduce
Chill Beat channel with channel_id = "UC_oeV58JVVXtxxs09oK1dLg"
when we call getChannel().getVideos(), returns just one video but channel has 78 videos.
Failure Logs
in result.current_tab.content result is:

RichGrid {
  type: 'RichGrid',
  header: FeedFilterChipBar {
    type: 'FeedFilterChipBar',
    contents: [ [ChipCloudChip], [ChipCloudChip], [ChipCloudChip] ]
  },
  contents: [
    RichItem { type: 'RichItem', content: [Video] },
    ContinuationItem {
      type: 'ContinuationItem',
      trigger: 'CONTINUATION_TRIGGER_ON_ITEM_SHOWN',
      endpoint: [NavigationEndpoint]
    }
  ]
}

while videos list in content is one video

Expected behavior
expected presents all of videos in page one.
Current behavior
just one video in contents:

[
RichItem {
type: 'RichItem',
content: Video {
type: 'Video',
id: '6LHVpSKoXfI',
title: [Text],
description_snippet: [Text],
expandable_metadata: null,
thumbnails: [Array],
thumbnail_overlays: [Array],
rich_thumbnail: [Array],
author: [Author],
badges: [],
endpoint: [NavigationEndpoint],
published: [Text],
view_count: [Text],
short_view_count: [Text],
duration: [Object],
show_action_menu: false,
is_watched: false,
menu: [Menu]
}
},
ContinuationItem {
type: 'ContinuationItem',
trigger: 'CONTINUATION_TRIGGER_ON_ITEM_SHOWN',
endpoint: NavigationEndpoint {
type: 'NavigationEndpoint',
payload: [Object],
metadata: [Object]
}
}
]

Version
Default
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Can't reproduce it on my side unfortunately. What happens if you try to fetch the continuation (Channel#getContinuation())?
Tab {
  type: 'Tab',
  title: 'Videos',
  selected: true,
  endpoint: NavigationEndpoint {
    type: 'NavigationEndpoint',
    payload: {
      browseId: 'UC_oeV58JVVXtxxs09oK1dLg',
      params: 'EgZ2aWRlb3PyBgQKAjoA',
      canonicalBaseUrl: '/@chillbeatphonk'
    },
    metadata: {
      url: '/@chillbeatphonk/videos',
      page_type: 'WEB_PAGE_TYPE_CHANNEL',
      api_url: 'browse'
    }
  },
  content: RichGrid {
    type: 'RichGrid',
    header: FeedFilterChipBar { type: 'FeedFilterChipBar', contents: [Array] },
    contents: [
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [RichItem],         [RichItem],
      [ContinuationItem]
    ]
  }
}

in await getChannel(id).videos works right, but if:

channelSession = await innertube.getChannel(id)
videos = await channelSession.getVideos()

in this case number of videos is 1.
it have a pagination token and continuation but second page is the same but with 4,5 videos and likewise, as far as sum of number of all pages videos are 7,8

oh i undrestood!
it because enable_safety_mode in Innertube config was true!
i chenged it to false and represented all videos!


Manifest for 3.8 not found

I'm getting errors when trying to build from the 3.8 tag with either alpine:3.8 or gliderlabs/alpine:3.8 even though docker hub is listing 3.8 as latest.
> docker pull alpine:3.8
Error response from daemon: manifest for alpine:3.8 not found

> docker pull gliderlabs/alpine:3.8
Error response from daemon: manifest for gliderlabs/alpine:3.8 not found

If you look on https://hub.docker.com/r/library/alpine/tags/ the tags that are available are over a month old where the repo info is saying it is available at https://hub.docker.com/r/library/alpine/
It would be great if the tags could be updated.

Same issue.   But the offical images repo has been updated. https://github.com/docker-library/official-images/blob/master/library/alpine https://github.com/docker-library/official-images/commit/d754738b6f42bd95c794511d9210f5c1a3ad4da8

https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/alpine/44/
I think the build is stuck.
@ncopa @yosifkit Any ideas what is going on?

Manifest is there but when it comes to linux/amd64:

3.8: Pulling from library/alpine
no matching manifest for linux/amd64 in the manifest list entries

Same here
Using default tag: latest
latest: Pulling from library/alpine
no matching manifest for linux/amd64 in the manifest list entries

Manifest. Manifest. Where are you?
Using default tag: latest
latest: Pulling from library/alpine
no matching manifest for linux/amd64 in the manifest list entries

All of the builds that relied on the latest version of the alpine image now fail, is there a way to address that problem?

@MrLokans Never use lastest version...? Just pin it to 3.7, and update the pin as soon as 3.8 is out.

still seeing this:
docker pull alpine:latest
latest: Pulling from library/alpine
no matching manifest for linux/amd64 in the manifest list entries

@frenck this issue was opened because the 3.8 image was broken not because the latest tag was being abused.
I for one don't want to be updating in excess of 1000 docker files when a new version of the alpine image is released and I want my builds to start screaming when something new comes along and breaks them.

@jakekeeys I know.
I was replying to @MrLokans, who asked for a way to address his currently failing builds, so my answer was perfectly valid for his issue and was in no way a solution for the missing manifest.
You choose not to pin, that is fine (as long that is a conscious choice). I currently actively maintain 250+ containers and pin everything. It is the only way to guarantee the resulting images works as tested and intended. Yes, it adds extra maintenance.
About the issue at hand, I hope it gets addressed soon 👍

Build 45 for amd64 has been triggered and succeeded:
https://doi-janky.infosiftr.net/job/multiarch/job/amd64/job/alpine/45/console

Was experiencing this but looks like the build finishing resolved it.

We had a temporary issue with our main amd64 build host that I've now corrected (as you've noticed).  Build was successful, manifest lists should be pushed soon (or already). :+1:


Missing "dispose" method for Offcanvas in Documentation

Hello everyone.
I've noticed missing documentation for "dispose" method in Offcanvas Documentation in Official website docs.
Offcanvas
But here this method exists on Code
dispose Method declaration in source
Can anyone confirm this please?

Good catch @MeeDNite, thanks for reporting this issue. It's going to be fixed by https://github.com/twbs/bootstrap/pull/39340.


Delete old ocdskingfisher

All old scrapers have been ported, with the exception of two whose sources are offline: #62 #60
This means we can delete the old Kingfisher system, which by my understanding includes:

ocdskingfisher/
ocdskingfisher-old-cli
metaalembic.ini
sample_old_config.ini
docs/old.rst

And some lines in:

requirements.in
setup.py
docs/use-hosted.rst

For posterity, this is a link to the two unported scrapers: https://github.com/open-contracting/kingfisher-scrape/tree/6e2629b/ocdskingfisher/sources
In the deploy repo, we can delete:

salt/ocdskingfisherold.sls
salt/ocdskingfisher/config.ini
salt/postgres/ocdskingfisher_.pgpass

There are also a SQL database, SQL users, and a Linux user with home directory, specific to the old system. (We can check with analysts before removing all this.)

Should we also delete the kingfisher-private repo? It uses the old pipeline, and the only unique content is a Georgia scraper for a source that is now unreacheable.

I'm deleting the kingfisher-private repo. I have a local copy of all branches in case it needs to be restored – though I can't see any reason why, as described above.


Nmz Plugin - Fix area check to exclude KBD lair

Fixes #3692

We should also update the Discord plugin to recognize the difference as it currently thinks players in KBD's lair are in Nightmare Zone.


Mock eccodes

Mock eccodes to allow autodoc to import the library without eccodes installed

Did you try to use this autodoc_mock_imports? https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_mock_imports

No I didn't try it. The action also only runs on merge to main so it's a bit difficult to test.

I would give the sphinx configuration a try. Could also modify the github action to run on this branch temporarily, change back before merge?


python312Packages.photutils: init at 1.12.0

Description of changes
Astropy package for source detection and photometry
https://github.com/astropy/photutils
Fixes #321298

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 321474 run on x86_64-linux 1

24 packages built:

python311Packages.asdf-astropy
python311Packages.asdf-astropy.dist
python311Packages.asdf-coordinates-schemas
python311Packages.asdf-coordinates-schemas.dist
python311Packages.asdf-wcs-schemas
python311Packages.asdf-wcs-schemas.dist
python311Packages.extension-helpers
python311Packages.extension-helpers.dist
python311Packages.gwcs
python311Packages.gwcs.dist
python311Packages.photutils
python311Packages.photutils.dist
python312Packages.asdf-astropy
python312Packages.asdf-astropy.dist
python312Packages.asdf-coordinates-schemas
python312Packages.asdf-coordinates-schemas.dist
python312Packages.asdf-wcs-schemas
python312Packages.asdf-wcs-schemas.dist
python312Packages.extension-helpers
python312Packages.extension-helpers.dist
python312Packages.gwcs
python312Packages.gwcs.dist
python312Packages.photutils
python312Packages.photutils.dist


Continuation of #250 - testing a browser matrix with Sauce

My stab at dusting this off and seeing where it goes. I had no trouble installing Travis, so maybe it'll just work now?
#250

@nein09 hello! I'm finally taking a look at this (I was away in a dark cave for the latter half of 2020). Do you happen to recall how you installed the Travis CLI? That seems to be my next step.


Fix wrong method call to get username and wrong parameter assignment

What changes are proposed in this pull request?

Use the correct method to get the username for cache.
Correct assignment to Group and Owner.

Why are the changes needed?

Currently, using the getGroupName method to get the username, the getUserName method should be used.
The option parameter assignment is reversed.

Does this PR introduce any user facing changes?
no

alluxio-bot, merge this please


Instructions generated non working self signed certificate consistently.

[Enter feedback here]
As mentioned in the Support request ID<PHONE_NUMBER>000129, the following 2 commands in the instructions generated a NON working self signed certificate for our Azure Application Gateway. As mentioned, I had tried multiple times on MacOS and via bash scripts and also tried it with Microsoft Tek Support, Yeudin Hidalgo, on both Azure Cloud Shell and Bash.
openssl req -x509 -sha256 -nodes -days 365 -newkey rsa:2048 -keyout privateKey.key -out appgwcert.crt

openssl pkcs12 -export -out appgwcert.pfx -inkey privateKey.key -in appgwcert.crt

I hereby request your team to verify the instructions and update accordingly.
Best regards,
~James M Nguyen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0c673aeb-a45a-a6a3-390c-899a35050bf1
Version Independent ID: 44f0b776-de4b-aa34-0e3a-ce4941532337
Content: TLS termination using CLI - Azure Application Gateway
Content Source: articles/application-gateway/tutorial-ssl-cli.md
Service: application-gateway
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for your feedback! We will review and update as appropriate.


fix(docker-compose): address "role root does not exist" errors arising from postgres health check

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

Fixes #6577.
How did you test it?

Checklist

[ ] I formatted the code cargo +nightly fmt --all
[ ] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

@Shark-Firewall Can you please attach a screenshot of how you'd tested it: you can include the error being printed before and include a screenshot that no errors are being printed now?

Before changes:

After changes:


perf: sysbench throughput is much lower than expection

The performance of sysbench is much lower than our manual test… For example, the throughput of point-select is ~800 QPS while in https://singularity-data.quip.com/9racAbR17zmC/SysBench-For-RisingWave it was ~70K. This seems to be far beyond the impact due to different hardware configurations

Previously discussed in https://risingwave-labs.slack.com/archives/C04879XJ36C/p1672716819131519?thread_ts=1672711831.022119&cid=C04879XJ36C

The execution is deployed by https://github.com/risingwavelabs/kube-bench/tree/main/manifests/benchmarks/sysbench

[benchmark]
--
  | namespace = "sysbench-daily-test-20221230"
  |
  | [benchmark.aws]
  | ask_before_proceed = false
  |
  | [benchmark.job]
  | name = "benchmark-job"
  | type = "sysbench"
  |
  | [benchmark.sysbench]
  | threads = "16"
  | report_interval = 1
  | events = 0
  | time = 10
  | percentile = 99
  | auto_inc = false
  | table_size = "10000000"
  | db_ps_mode = "disable"
  | skip_trx = true
  | range_size = 1
  | # Possible values are oltp_point_select.lua, select_random_points.lua, select_random_ranges.lua and oltp_read_only.lua
  | task = "oltp_point_select.lua"
  | image = { tag = "latest" }
  |
  | [benchmark.risingwave]
  | version = "nightly-20221229"
  |
  | [benchmark.risingwave.replicas]
  | meta = 1
  | frontend = 1
  | compute = "3"
  | compactor = 1
  |
  | [benchmark.risingwave.resources]
  | cpu = { limit = "8", request = "8" }
  | mem = { limit = "16Gi", request = "16Gi" }
  |
  | [benchmark.risingwave.storage]
  | type = "s3"
  |
  | [benchmark.risingwave.storage.s3]
  | region = "ap-southeast-1"
  | access_key = ""
  | access_secret = ""
  | bucket = "sysbench-daily-test-20221230-2796"
  | data_directory = "hummock_001"
  |
  | [benchmark.s3.bucket]
  | create_enabled = true
  | delete_enabled = true
  |
  | [benchmark.kafka]
  | enabled = false

Buildkite URL: https://buildkite.com/risingwave-test/sysbench/builds/131#0185646d-30fe-44c1-a675-22bb61f978b1

In Dylan's report,
the setting is a single EC2 Machine (c5.12xlarge 48c96G) and run the SysBench program on another EC2 (c5.12xlarge 48c96G) in the same VPC.

After checking with @hzxa21 together, it's caused by two problems:

Due to the limitation of write throughtput, we are still processing writes when reading, so this is essentially read/write performance.
Block cache miss. We found that 63% of reads didn't hit block cache.

So, given the current data size, we should go with 2 changes:

Wait several minutes after inserts, or execute SET RW_IMPLICIT_FLUSH TO true; just like our e2e test.
Increase block cache size to 2G.

Still not stable. Leave it open.

After using isolated environment, the performance is much stable now. Let's close it.


Advanced Filter: Slider in advanced filter broke in V1.2.0

Description
This looks like a regression. The test file below in V1.1.11 is working when setting up a filter with a slider but causes an error in V1.2.0 and the slider doesn't render at all.
Version
Data-grid: V1.2.0
Browser: Chrome
Screenshots

Code
https://gist.github.com/ppeyro/4c6e5620672bd5e3237abe416e7f85e8

@ppeyro - was this fixed with 1.2.1?

This is fixed in 1.2.1. Closing


Possible memory leak when using Queue

Hi,
I'm not sure if this is related to how Queue works, or is it related to other react structures.
Here is my script:
use Clue\React\Mq\Queue;
use MemoryTest\Counter;
use React\Http\Browser;

require_once __DIR__ . '/vendor/autoload.php';

$file = fopen('memory.csv', 'w');
fputcsv($file, [memory_get_usage(true), memory_get_usage(), 0]);

$loop = React\EventLoop\Loop::get();
$browser = new Browser($loop);

$queue = new Queue(
    10,
    null,
    function($url) use ($browser) {
    return $browser->get($url);
});

fputcsv($file, [memory_get_usage(true), memory_get_usage(), 0]);

$requestsSent = new Counter();

for ($i=1; $i <= 500; $i++) {
    $queue('https://webhook.site/d3759f23-aa81-4961-81e9-8d8270d07b95')->then(
        static function (\Psr\Http\Message\ResponseInterface $response) use ($requestsSent) {
            $requestsSent->counter++;
            echo '.';
        }
    );
}

$loop->addPeriodicTimer(5, function () use ($file, $requestsSent) {
    fputcsv($file, [memory_get_usage(true), memory_get_usage(), $requestsSent->counter]);
});

Results:
| 2097152 | 700432 | 0  |
| 2097152 | 1488680 | 0 |
| 10485760 | 7584792 | 10 |
| 10485760 | 7402712 | 30 |
| 10485760 | 7220632 | 50 |
| 10485760 | 7038552 | 70 |
| 10485760 | 6856472 | 90 |
| 10485760 | 6674392 | 110 |
| 10485760 | 6827344 | 130 |
| 10485760 | 6413880 | 141 |
| 10485760 | 6219192 | 160 |
| 10485760 | 6037112 | 180 |
| 10485760 | 5855032 | 200 |
| 10485760 | 5672952 | 220 |
| 10485760 | 5490872 | 240 |
| 10485760 | 5308792 | 260 |
| 10485760 | 5126712 | 280 |
| 10485760 | 5090808 | 300 |
| 10485760 | 4817176 | 314 |
| 10485760 | 4800952 | 334 |
| 10485760 | 4520448 | 350 |
| 10485760 | 4368984 | 368 |
| 10485760 | 4205512 | 388 |
| 10485760 | 4010624 | 406 |
| 10485760 | 3837648 | 425 |
| 10485760 | 3624552 | 445 |
| 10485760 | 3442472 | 465 |
| 10485760 | 3260392 | 485 |
| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |

The results of memory_get_usage(true) are in the first column - then memory_get_usage() and a number of finished requests.
My question is - why memory is not released after performing requests? The amount of allocated memory is always related to the number of requests in a Queue. Shouldn't it be released, or am I doing something wrong?

Hey @wnuQq, thanks for bringing this up :+1:
I don't believe this is a memory leak, this is actually the expected behavior. When running your script, PHP starts to instantiate all classes, interfaces etc. needed for your script to run properly and will keep those in your memory. For example take the first two lines of your file output:
| 2097152 | 700432 | 0  |
| 2097152 | 1488680 | 0 |

You didn't even send out a request yet and memory is already growing, this is caused by PHP and the expected behavior in this case. In the third line (| 10485760 | 7584792 | 10 |) your memory grows, because all your planned requests are now in memory too (caused by the clue/reactphp-mq project, also expected). Progressing further your memory shrinks with every request being handled after a while. The rest you see at the end is all the PHP stuff again. You never see your memory dropping further down, because you only track your memory usage while your PHP script is running.
In conclusion, this is not a bug in  clue/reactphp-mq or reactphp/http. You can also try out the same example with only one request instead of 500 and see the same amount of memory in the end.
I think this should answer your question, so I will close this ticket for now. If something comes up or needs some further investigation, we can always reopen.
I hope this helps!

Hi @SimonFrings
Thanks for your answer. Unfortunately, I'm not convinced ;)
I will try to be more specific, maybe this will help you to understand my concerns, or you will be able to point out in which point I'm wrong.

| 2097152 | 700432 | 0  |
| 2097152 | 1488680 | 0 |

Everything as you said: PHP starts to instantiate all classes etc.

| 10485760 | 7584792 | 10 |

At this point - as you said: "all your planned requests are now in memory" - agreed! And it is no surprise that allocated memory depends on how many requests are in the queue. So when we have 500 PHP uses ~ 7584792 and this will be 10485760 of the total memory allocated.

| 10485760 | 6413880 | 141 |
| 10485760 | 6219192 | 160 |
| 10485760 | 6037112 | 180 |
| 10485760 | 5855032 | 200 |
| 10485760 | 5672952 | 220 |

"Progressing further your memory shrinks with every request being handled after a while" - yup. I can see that PHP does not require all this memory anymore and I'm waiting for it to release the allocated memory (first column: 10485760).

| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |
| 10485760 | 2520152 | 500 |

...but it looks like it's not going to happen. Allocated 10485760, when 2520152 is needed. I was testing for more extensive data sets. I'm running similar code on production and I can see clearly that allocated memory (first column) never goes down.
I think I was wrong when I called it a leak because memory is not leaking - it is needed at some point during the script is running but after processing messages which caused this spike I expect memory will be released, but it is not.

This way PHP wouldn't have to communicate back and forth with your system, but that's just my assumption.

That assumption is correct, PHP will increase the allocated amount of memory with the system as your memory usage goes up. It tends to go in bigger blocks than you request and it indeed never goes down. Not sure why but it could be a relic from when PHP was mostly run as a request handle and there was no need to free memory because requests didn't last long.

Hi @WyriHaximus,
Not sure what you mean by "never" :)
Take a look aaat this beauty ;)
`
$array = [];
$i = 0;
$string  = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvvvvvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvvvvvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvvvvvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvvvvvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaavaaaaaaaaaaaaaaaaaaaaaaaavvvvvvaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
$file = fopen(DIR . '/memorySimple.csv', 'w');
fputcsv($file, [memory_get_usage(true), memory_get_usage()]);
while (true) {
$i++;
$array[$i] = $string . $string . $string . $string . $string . $string . $string . $string . $string . $i;
if ($i % 100 === 0) {

    fputcsv($file, [memory_get_usage(true), memory_get_usage()]);

    if ($i >= 1000) {
        $array = array_slice($array, 150);
        echo count($array) . PHP_EOL;
    }
}

}
And results:
| 2097152 |  407384 |  ***
| 6291456 |  5330832 |
| 12582912 |  10250128 |
| 16777216 |  15173520 |
| 20971520 |  20088720 |
| 27262976 |  25003920 |
| 31457280 |  29935504 |
| 35651584 |  34850704 |
| 41943040 |  39765904 |
| 46137344 |  44681104 |
| 52428800 |  49596304 |
| 48234496 |  47171504 |
| 46137344 |  44713904 |
| 44040192 |  42256304 |
| 41943040 |  39798704 |
| 39845888 |  37341104 |
| 37748736 |  34883504 |
| 33554432 |  32425904 |
| 31457280 |  29939632 |
| 29360128 |  27482032 |
| 27262976 |  25003952 |
| 27262976 |  22546352 |
| 25165824 |  20088752 |
| 23068672 |  17631152 |
| 18874368 |  15173552 |
| 14680064 |  12707760 |
| 12582912 |  10250160 |
| 8388608 |  7792560 |
| 6291456 |  5330864 |
| 2097152 |  407384 |   ***
Memory was released. Every unset (array_splice) works as expected. You can try it also this way:
...
if ($i % 2 === 0) {
    fputcsv($file, [memory_get_usage(true), memory_get_usage()]);

    if ($i >= 1000) {
        $array = array_slice($array, 3);

...
`
It shows that PHP releases memory in the same way it allocates it - in chunks. So my suspicion is that something in Queue is not releasing memory - allocated chunks cannot be released as something is still there.

Hi @WyriHaximus, Not sure what you mean by "never" :)

As in never for the duration of the process is running. But that might have changed in recent PHP versions.


[Android][Windows][0.25.1] FileWatcher timeout error message not show in terminal

After my project includes more and more js files and node modules, I suddenly found that the packager  not detect my changes when Reload JS, I have to stop and run start again. After researching I finally found the root cause is FileWatcher failed to launch caused by MAX_WAIT_TIME reaches. But why error/waring messages not show in terminal? It will puzzle new developers.

I sent a pull request long ago to fix this issue and some others that are related to it:
https://github.com/facebook/node-haste/pull/63
... but it seems the author expects us to do all the work instead of just fixing the module with those ideas suggested on the pull request.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/androidwindows0251-filewatcher-timeout-error-message-not-show-in-terminal
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Support new HTMLBars-style bound attributes

Got the following deprecation a lot when I upgraded to Ember 1.13:
Ember 1.13: DEPRECATION: The `bind-attr` helper is deprecated in favor of HTMLBars-style bound attributes.

I'm assuming it's because emblem still outputs {{bind-attr}}. Is there a workaround in place? Thanks!

whoops wrong repo, sorry!


Automated cherry pick of #2780: snapshotpolicy and disk should have same domain and project in snapshotpolicydisks

Cherry pick of #2780 on release/2.11.
#2780: snapshotpolicy and disk should have same domain and project in snapshotpolicydisks

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@ecb9fd2). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #2781   +/-   ##
==============================================
  Coverage                ?   7.21%
==============================================
  Files                   ?     470
  Lines                   ?   74495
  Branches                ?       0
==============================================
  Hits                    ?    5374
  Misses                  ?   68669
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.21% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb9fd2...766f605. Read the comment docs.

/lgtm
/approve


Revert "ESLint: Remove ts-ignore comments"

Reverts apache/incubator-superset#10933

Hoping not to use this... would prefer to merge https://github.com/apache/incubator-superset/pull/10989


Add new user setting: Format Elixir code when evaluated

This PR adds a new user setting: Format focused Elixir cell on evaluation. (I went back and forth on 3-4 different labels for this and this was the best I could come up with for now.)

Screenshot & GIF

Formatting only occurs for the focused cell, so if you eval an entire section, or all stale cells, non-focused cells will not be formatted.
Discussion thread. I mentioned format-on-save as well, but in addition to being trickier to implement, I don't think it's necessary after playing with format-on-eval, since you're almost always evaluating your cells before saving anyways.

Hey @zachallaun! I understand the motivation behind this, but my main concern is that this requires additional roundtrip to the server before evaluation and this can be noticeable when running Livebook in the cloud. Note that we do format all cells on save, and it can be disabled per-cell basis, so I wouldn't worry about formatting the code that eagerly. Basically if you intentionally write misformatted code and want to formatter to do the job, you will likely remember to use the shortcut; and if the code does not scream misformatted then format on save will finish the job :) @josevalim thoughts?

Another big concern is collaborative editing where we may generate conflicts if it happens very frequently. So I am unsure.

Very fair points! To be clear, I implemented this to be sure it was doable and am totally fine with the addition being rejected.
That said, my personal, biased thoughts:

While I certainly don't use Livebook as much as y'all, I'm probably at the relatively high end of experience using it, and I still often forget the shortcut for formatting. VSCode uses ctrl-shift-i, for instance, though I never use that because of format on save :).
While formatting the livemd file when it's saved is certainly useful/desired, I expect we all agree that formatting as you work on something is very helpful.
Collab editing is certainly an important use case (though I don't personally use it). Is there a larger chance of conflicts here than when just using the shortcut? It's not really any fundamentally different than alt-shift-f immediately followed by ctrl-enter, right?
The round trip is definitely something to be considered. It wasn't something I noticed much of when playing with it on the PR deployment, but I can see it being problematic.

For simplicity, this is entirely client-side (like all other user settings). I haven't looked too deeply at the evaluator, but would it be theoretically possible to implement this on the server instead? If this is set, eval would produce the eval result & formatted code in a single round trip. This should reduce the latency issues and likelihood of collab conflicts.

I haven't looked too deeply at the evaluator, but would it be theoretically possible to implement this on the server instead?

We can't easily merge these as they are two entirely different paths. When you say "evaluate this cell" it tells the server to evaluate the code it has (the shared state), on the other hand formatting request sends the user code and receives edits, because we want the edits to be applied "by the user" and part of their editor history (so they can undo the operation).

@jonatanklosko we could send it to the server only if the code has changed, so we don’t play the price on every roundtrip. Although I can also see it being confusing: imagine you eval to get feedback and then things change. You’re call @jonatanklosko. :)

Yeah, currently I'm not convinced we should do this.

Thank you @zachallaun !

An alternative that would leave me satisfied would be making the alt-shift-f shortcut a universal shortcut instead of just in insert mode. This would at least allow for easy formatting of existing cells while navigating with j/k. 🙂

@zachallaun that works for me. @jonatanklosko?

Sounds good :)

@zachallaun can you please send another PR then? I think you may also need to change the shortcut settings bits.

Yup! Will work on this when I get some time, hopefully later tonight.
Zach
On Mon, Jul 17, 2023 at 11:11 AM José Valim @.***>
wrote:

@zachallaun https://github.com/zachallaun can you please send another
PR then? I think you may also need to change the shortcut settings bits.
—
Reply to this email directly, view it on GitHub
https://github.com/livebook-dev/livebook/pull/2077#issuecomment-1638348560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD3BAWD4TAJD46GW2HVS3DXQVIYHANCNFSM6AAAAAA2L7LYKE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Upgrade to egui 0.29

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes
Upgraded to egui 0.29.
Related Issues
Fixes #233

How well have you tested this?

How well have you tested this?

To be honest with you.. Not at all :)
I plan to test this out on my own project when I find the time, so until then, unless someone else do some testing, we let this PR rest here..

I tested it on my project (while bumping egui, egui-wgpu and egui-winit from 0.28.1 to 0.29.1) and haven't seen any issue so far. It even seems to be running faster but I haven't benchmarked properly.

I have now at least tried to run puffin and things are looking ok.
Will get back to you when I have done more extensive testing on my end.

I have been using this with my own project for some time now and I have not found any issues with it.
From my end this looks good to go

@emilk I have been using this version with my game engine since egui 0.29 was released. It seems to be working fine

Shall we?

This update somehow breaks profiling and puffin integration
Only puffin_egui::puffin reexport works.
I use for testing this example https://github.com/aclysma/profiling/tree/master/demo-puffin
and this changes to Cargo.toml
puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}

but with regular
puffin_egui = "0.29.0"

Expected result

this is toml for broken version
[workspace]
# This is not part of the workspace in the profiling git repository because it causes the puffin feature to be enabled
# in examples, which we don't want.

[package]
name = "demo-puffin"
version = "0.1.0"
authors = ["Philip Degarmo<EMAIL_ADDRESS>edition = "2018"
description = "Example using puffin and the profiling crate"
license = "MIT OR Apache-2.0"
readme = "../README.md"
repository = "https://github.com/aclysma/profiling"
homepage = "https://github.com/aclysma/profiling"
keywords = ["performance", "profiling"]
categories = ["development-tools::profiling"]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }

puffin = "0.19.1"
puffin_egui = { version = "0.29.0", git = "https://github.com/tedsteen/puffin", rev = "11771ebe00fd257aedbb545df3339ad597b1cc34"}
egui = "0.29.1"
# wgpu also works fine here
eframe = { version = "0.29.1", default-features = false, features = ["glow"] }

log = "0.4"
env_logger = "0.11"

this is the working variant
[dependencies]
profiling = { path = "../profiling", features = ["profile-with-puffin"] }

puffin = "0.19.1"
puffin_egui = "0.29.0"
egui = "0.28.1"
# wgpu also works fine here
eframe = { version = "0.28.1", default-features = false, features = ["glow"] }

Its already needs to be updated to egui 0.30.0

I forked puffin and updated the egui, egui_extras and eframe to 0.29.0. Everything works fine it seems.
I don't understand why puffin_egui's own version is set to 0.29.0 when the egui version it uses is 0.28.0.

Upgraded to egui 0.30. This required an upgrade of the toolchain to 0.81

I forked puffin and updated the egui, egui_extras and eframe to 0.29.0. Everything works fine it seems on my own project.
I don't understand why puffin_egui's own version is set to 0.29.0 when the egui version it uses is 0.28.0.

That's because puffin_egui is part of this PR and is not yet released/merged


To-Do List: Create and manage task lists for fitness routines and goals.

As a user, I want to create and manage a task list for my fitness routines and goals.

✅ The feature is implemented with all implementations.


Issue 241: Clarified the way to customize EurekaInstanceConfigBean for a AWS deployment

This is related to issue 241 - I have added in documentation related the way to customize EurekaInstanceConfigBean for a deployment to an AWS environment.

@bijukunjummen have you signed the contributor agreement?

Yes @spencergibb , I have signed the Contributor agreement.

Merge in 2c68806


Start/stop hooks?

It would be great if Toggl had an option for executing an arbitrary command (always the same command) when clicking Start, and another arbitrary command when clicking Stop.
I would use it to integrate with a local tool that records screenshots.

on what os would you use it?

Windows.
On 18 May 2015 at 21:25, Tanel Lebedev<EMAIL_ADDRESS>wrote:

on what os would you use it?
—
Reply to this email directly or view it on GitHub
https://github.com/toggl/toggldesktop/issues/1320#issuecomment-103292872
.

We have decided not to implement this feature into Toggl Desktop. Thank you for your feedback.


Bump version of data-coordinator dependency for secondary watcher.

soql-postgres-adapter #488 SUCCESS
This pull request looks good

Can one of the admins verify this patch?

ok to test

Can one of the admins verify this patch?

:+1:


Update changelog and version

What? and Why?

What does this pull request change/fix? Why was it necessary?

Checklist

[ ] CHANGELOG.md updated? (if required)

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   75.71%   75.71%
=======================================
  Files           9        9
  Lines         626      626
=======================================
  Hits          474      474
  Misses        152      152

Impacted Files
Coverage Δ

transform/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 478e1bd...dd9f532. Read the comment docs.


Handling of very large size stroke-width

in examples/Stroke.cpp
    auto shape1 = tvg::Shape::gen();
    shape1->appendRect(50, 50, 200, 200);
    shape1->fill(50, 50, 50);
    shape1->strokeFill(255, 255, 255);            //color: r, g, b
    shape1->strokeJoin(tvg::StrokeJoin::Bevel);   //default is Bevel
    shape1->strokeWidth(100000000);                       //width: 100000000 or 10000000

There can be cases where the stroke width size is abnormally large.
If the stroke is not drawn on the actual screen or fills the screen even if drawn, the user expect processing speed appropriate to the screen size.
However, it seems to calculate the entire width size.

@JSUYA hello, it's about performance?

@JSUYA hello, it's about performance?

Hi @hermet I think this is a bug. It takes a long time to calculate, as if it is stuck in an infinite loop.

There is more case.
The while loop of tvgSwRle.cpp: _cubicTo() runs for a very long time.
If there are more many paths with such large numbers, the app look like stopped.
    /* Circle */
    auto cx = 550.0f;
    auto cy = 550.0f;
    auto radius = 125.0f;
    auto halfRadius = radius * 0.552284f;

    //Prepare Path Commands
    tvg::PathCommand cmds2[6];
    cmds2[0] = tvg::PathCommand::MoveTo;
    cmds2[1] = tvg::PathCommand::CubicTo;
    cmds2[2] = tvg::PathCommand::CubicTo;
    cmds2[5] = tvg::PathCommand::Close;

    //Prepare Path Points
    tvg::Point pts2[13];
    pts2[0] = {cx, cy - radius};    //MoveTo
    //CubicTo 1
    pts2[1] = {20000000000,<PHONE_NUMBER>0};      //Ctrl1
    pts2[2] = {cx + radius, cy - halfRadius};      //Ctrl2
    pts2[3] = {cx + radius, cy};                   //To
    //CubicTo 2
    pts2[4] = {cx + radius, cy + halfRadius};      //Ctrl1
    pts2[5] = {cx + halfRadius, cy + radius};      //Ctrl2
    pts2[6] = {cx, cy+ radius};                    //To

    auto shape2 = tvg::Shape::gen();
    shape2->appendPath(cmds2, 6, pts2, 13);     //copy path data
    shape2->fill(255, 255, 0);
    if (canvas->push(std::move(shape2)) != tvg::Result::Success) return;