Enhancement: Customization Features

Hello @Rishabh-Raghunath ,
We need customization feature for Android;

Most importantly: Change Color. There is a method for iOS : setThemeColorForiOS, but there is no method for Android.

Other Customizations for both Android & iOS:

Change Description text.
Change Start Chat text.
Change Messages tab text.
Change FAQs tab text.

Thanks,

Hi @ibrahimdevs,

We need customization feature for Android;

We do have support and you can refer to our customization help doc for whole theme changes and component-level customizations.

Other Customizations for both Android & iOS:

For Android:
We do have a separate section for strings customization Reference link. You can customize the strings inside strings.xml.

Change Description text.
Component name - livechat.conversation.emptystate
Example:  <string name="livechat.conversation.emptystate"> Your own content </string>

Change Start Chat text.
Component name - livechat.conversation.startchat
Example:  <string name="livechat.conversation.startchat"> Your own content </string>

Change Messages tab text.
Component name - livechat.conversation.title
or
You can also make use of our internal API .setConversationListTitle.

Change FAQs tab text.
Component name - livechat.article.title
or
You can also customize this string at the portal level. Settings > Brands > {Brand name} > Personalisation > Specify a name for the knowledge base in visitor chat windows

For iOS:

Change Description text.
This is currently not supported in iOS but we have this coming in our roadmap.

Change Start Chat text.
This is currently not supported in iOS but we have this coming in our roadmap.

Change Messages tab text.
You can make use of our internal API .setConversationListTitle.

Change FAQs tab text.
You can customize this string at the portal level. Settings > Brands > {Brand name} > Personalisation > Specify a name for the knowledge base in visitor chat windows.

@Angu-G thanks for your detailed response.

It is better, If you could add these customization options to Flutter documentation (https://www.zoho.com/salesiq/help/developer-guides/flutter-sdk-installation.html) At least a description and redirection to links.
Android - 2 - "livechat.conversation.startchat" not affecting.
Android - 4 - "livechat. article. title" not affecting.
I'm waiting for iOS 1 & 2.
iOS 4 - it is better to provide another option to set this text. Because we need multi-language support, if we change it from dashboard, there is no multi-language support.

Hello @ibrahimdevs
We have reviewed and updated your recent requests. Please find the details and solutions below:
1. Android - 2 and 4:

The issues have been fixed. Please update to the latest version of 6.1.0 and use the same key.
For Android - 4, you can customize the title from the portal:
Settings -> Brands -> Personalization -> Knowledgebase -> Tab Name

2. iOS - 1 and 2:

For iOS 1 and 2, please refer to the following API documentation to customize the title as needed:
.registerLocalizationFileForiOS()

3. iOS - 4:

If you want to customize the knowledge base tab title with multilingual support, you can set it from the portal with the corresponding languages:
Settings -> Brands -> Personalization -> Knowledgebase -> Tab Name -> Translate Name

I hope this helps. Please feel free to write back to us at<EMAIL_ADDRESS>in case of any queries.
Regards,
Venkatesh R
Zoho SalesIQ.


Why are keybindings repeated in new keybindings editor?

Ah, In Mac left ones are shown using symbols, hence I added the labels. Also I could able to show highlights only in labels.

I will remove the labels by default
When filters are applied, I will show the labels for highlights until I add highlights to symbols.


Remove withRootStore, switch to getRootStore

@mazenchami and I ran into a problem with strict TypeScript where using withRootStore on substores will result in the error:
Type 'RootStore' recursively references itself as a base type. ts(2310)

I am not really a fan of hanging the rootStore reference as a view off of every store anyway, so I'm proposing we replace the withRootStore extension with a very similar getRootStore helper function.
- import { withRootStore } from "./extensions/with-root-store"
+ import { getRootStore } from "./helpers/get-root-store"

const MyStore = types.model("MyStore")
- .extend(withRootStore)
.views((store) => ({
  get someProp() {
-    return store.rootStore.someProp
+    return getRootStore(store).someProp
  }
})

The implementation should be very similar (actually, simpler) to the existing extension.

In some situations I still get the error for Type 'RootStore' recursively references itself as a base type. ts(2310) when using a getRootStore() helper function.
It occurs when trying to return a value that was dependent on a value pulled from another store. I think mobx-state-tree only wants actions to update values in the store and to not return them.
So an example where this occurs is if you have an action that takes in a userId, stored in another store, and uses it to fetch data from an API and then return something with the data.
`
getDatabasedOnuser: flow(function* (): Type {
const { userId } = getRootStore(self).UserModel;
try {
const SomeFeetchedObject = self.environment.api.fetchSomething(userId);
self.storeProperty = SomeFeetchedObject;
return SomeFeetchedObject.id;
} catch (e) { ....... }
}
`
Remove the return and the error goes away. I'm sure it can occur in other situations but this has been the one that I've been running into.

@FlanaganSe Have you tried explicitly adding a return type to the view?
You can also try reordering views above actions to see if that will auto type it.


OutOfMemoryError

java.lang.OutOfMemoryError
at android.graphics.Bitmap.nativeCreate(Native Method)
at android.graphics.Bitmap.createBitmap(Bitmap.java:640)
at android.graphics.Bitmap.createBitmap(Bitmap.java:575)
at android.graphics.Bitmap.createBitmap(Bitmap.java:501)
at com.edmodo.cropper.CropImageView.getCroppedImage(CropImageView.java:357)

by using below code, it works fine. :
final BitmapFactory.Options options = new BitmapFactory.Options();
//If set to a value > 1,requests the decoder to subsample the
//original image, returning a smaller image to save memory.
options.inSampleSize = 2;
    Bitmap photo = BitmapFactory.decodeFile("/storage/emulated/0/DCIM/Camera/20150113_190354.jpg",options);
    cropImageView.setImageBitmap(photo);

Code of S-Masoud-Emamian seems to be working

Code of @S-Masoud-Emamian does not address the issue with getCroppedImage(). I would like to run his code on the CROPPED version of the picture that I took, not on just any picture. And getCroppedImage() still returns null so..where's the solution in that?


Recalculate StickyBox position with custom trigger

Can I force StickyBox to recalculate its top position?
I'm displaying an expandable list in a sidebar. When the list expands, the StickyBox sticks nicely when necessary. However, when I click the button at the bottom of the list to collapse it back into showing the top 10 items only, the StickyBox disappears off-screen. This is because the content is now much less high, and its top position is still offset from its longer previous height.
I'd like to be able to trigger a recalculation of the top position after collapsing my list. Is there a way to do that? I've thought about faking a browser window resize event, but that seems very dirty...

Yes, that seems like a valid point. There's no official api to do this yet, but something like this should work:
class MyComp extends Component {

  handleRef = n => this.stickyBoxInstance = n

  recalculatePosition = () => {
    this.stickyBoxInstance.latestScrollY = -1
    this.stickyBoxInstance.handleScroll()
  }

  render() {
    return <StickyBox ref={this.handleRef}>{content}</StickyBox>
  }

}

recalculatePosition simulates a scroll event. Setting latestScrollY to -1 implies that the handleScroll event will behave as if you scrolled down.

I've tried implementing your suggestion, but maybe I'm not doing it right. I'm trying to call recalculatePosition() from a child component, like so:
export default class extends Component {

    [... stuff omitted for brevity ...]

    // Recalculate StickyBox position with custom trigger
    // https://github.com/codecks-io/react-sticky-box/issues/16
    filterStickyBoxRef = n => this.stickyBoxInstance = n;
    recalculatePosition = () => {
        console.log( "recalc called" );
        this.stickyBoxInstance.latestScrollY = -1;
        this.stickyBoxInstance.handleScroll();
    }

    render() {
        return (

                <StickyBox className="sidebar small" ref={ this.filterStickyBoxRef } offset={ 56 }>
                    <Filter
                        filter={ this.state.query }
                        onFilterChange={ this.filterChanged }
                        onRelationChange={ this.relationChanged }
                        onCollapse={ this.recalculatePosition }
                        { ...this.props }
                    />
                </StickyBox>

                   [...]

                <StickyBox className="sidebar medium" offset={ 56 }>

                </StickyBox>

        );
    }

Then inside <Filter /> I'm calling this.props.onCollapse(). I've confirmed that this works because the console logs "recalc called" when the list collapses, but the list doesn't appear back on the screen. When I scroll a little bit, it immediately jumps back into the right position. So the idea is good, but I'm not executing it right.

It might be that simulating scrollDown might be the wrong event in your context. So what you could try instead is replacing this.stickyBoxInstance.latestScrollY = -1 with a very high value to simulate a scroll down.
Thinking about it, you probably also need to wait with calling this method until the filterChange is flushed to the DOM. So you might want to try putting the call in a componentDidUpdate.
I'm well aware that all this is all quite hacky and I'm very open to having a clean API that "just works". But this process definitely helps understanding the problem space!

Inside <Filter />, I only proceeded with calling this.props.onCollapse() after the state (expanded / collapsed) was changed. I do this using the setState callback.
<button
    className="expand"
    onClick={ () => this.setState({ genresHidden : !this.state.genresHidden }, () => this.props.onCollapse() ) }
>
    Show { this.state.genresHidden ? 'all' : 'less' } genres
</button>

Do you think this is still too early to call it?

I'm not too certain about this part of the life cycle. But you could test it by adding a timeout of like 20ms. If it makes a difference, then the setState callback might not be the best place for this.

A 20ms timeout does the trick, but it's still a dirty hack ;)
I'd love to see something official for this. I have a second use case for it, too:
When I click items in the sidebar filter, I reload the page results and scroll the page back to the top. But the sidebar is fixed to its previous location. Also here, a manual trigger to recalculate the new sidebar position would be excellent!

I just released v0.7.1 which automatically should do the right thing if the the sticky box's contents change in size. You can try out the behaviour in the new docs. Maybe this solves your underlying issue as well?

I just added that button to the full page example. And I could reproduce it for the behaviour: 'instant' case.
I've added a section in the troubleshooting that solved the problem for me.

Excellent, I will report my findings when I implement 0.7.1 (or 0.7.2) later this week.

My findings so far, using 0.7.2:
Does not work:
window.scrollTo(0, 0);
window.dispatchEvent(new Event('scroll'));

Works:
window.scrollTo({top: 0, behaviour: 'smooth'});

Repositioning the StickyBox after collapsing its contents does not seem to work on my end. I've tried examining your setup and you don't seem to call an API to StickyBox anywhere, it's simply the content that disappears?
My initial setup was like this (pseudo):
{ this.state.loading ? null : topTenItems }

    {
        this.state.loading ? null : this.state.filters.genre
            .slice( 10 )
            .map( genre => <Item key={ `genre-${ genre.id }` } name={ genre.name } /> ))
    }

{ this.expandButton() }

And so I thought, maybe it's because the additional items that can be collapsed are tucked in a container. I made them direct siblings, but it's still not affecting the StickyBox position.
{ this.state.loading ? null : topTenItems }
{
    this.state.loading || this.state.genresHidden ? null : this.state.filters.genre
        .slice( 10 )
        .map( genre => <Item key={ `genre-${ genre.id }` } name={ genre.name } /> ))
}
{ this.expandButton() }

Can you try cloning my repo and reproduce it?

Clone https://github.com/mdingena/tjoonz-client
You will need to use some Code-Fu if you don't have a Font Awesome Pro subscription 🤐
npm install
npm start
Navigate to http://localhost:3000/search
Scroll down / load more results to increase the page height
Expand the genres and scroll further down
Collapse the genres
StickyBox does not reposition

You're right, didn't even notice that. It happens because body { position: absolute } which must have been a brainfart many commits back. I can't really justify why I need(ed) that, so I'm taking it out.
However, even after taking it out, and also even after adding html { height: 100vh; }, StickyBox is not behaving as intended.

Interesting! What browser have you been using? I was checking it out on chrome. When using your master branch, the sticky box wouldn't move at all, because of the height=0 issue. All I then changed was adding the min-height: 100vh; and removing all reposition logic and it seemed to work as expected.

Here's the changes I made you can try and run: https://github.com/danielberndt/tjoonz-client/tree/sticky-box-fix
(sorry it's a bit messy due to me removing all icons to make it work. (and prettier remformatting every file I've touched)

Sorry, it would've been better to commit the reformatted files first, then commit your changes. They are in the same commit now, and I can't really figure out the lines you changed. Could you add some comments to it? I will run a test with 0.7.3 later this week.

Yeah, sorry, I didn't pay too much attention here, since I didn't attend to publish and just wanted to make it work.
I've added two comments to my commit indicating where I changed things.

I've upgraded to 0.7.5, taken out all the hacks from before, and it seems to work out of the box now. Great, thanks!


docs: setup conventional-changelog

Setup conventional-changelog for releases and update documentation

I didn't want to do an "empty" release. The next time we do a release the CHANGELOG will be generated.


Disable MacOS validation for pull requests

Save on runners and reduce flakiness by not running PR validations on MacOS

Fixed by #869
Also see #868 for longer term plan


[raz] Skeletons of Raz Client and S3 FileSystem via RAZ

Focused on end to end
Goal is list buckets and list keys methods first
Tests mocking RAZ signed URL generation via Boto2 generate_url
Unmarshalling XML back from requests call to S3 via Boto2 (might require
a connection)
Unclear if all the FS calls we need are mappable to a signed url with
boto2
boto3 URL generation feels simpler and documents all the possible call
Live Test trying to talk to a RAZ for a list bucket S3 token
Live Test listing buckets via a self signed S3 URL and unmarshalling it
Good next steps:

Polish RAZ Client to get a token for real
Investigate how to implement the list keys with prefix in a bucket
On top of bucket/key listing, download/upload/delete/new file as MVP
Decide on the simplest way to unmarshall into the boto2 Python objects
currently used by the S3 Browser lib

This is a WIP getting close, but looking for feedback on the approaches.

Follows


Fixed struct array initialization #264

Reverted code from newDeclStmt and moved the array initialization
logic to the transpileInitListExpr function
Ref: #264

This change is

@elliotchance Let me know if there is anything to change.

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

ast/init_list_expr_test.go, line 15 at r1 (raw file):

			ChildNodes: []Node{},
		},
		`InitListExpr 0x32017f0 <col:24, col:41> 'struct node [2]'`: &InitListExpr{

I'm surprised this actually worked (matched the regex) with the InitListExpr  prefix. Please remove that prefix so it is the same as all the rest of our tests (and the one below).

Comments from Reviewable

Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion.

ast/init_list_expr_test.go, line 15 at r1 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
I'm surprised this actually worked (matched the regex) with the InitListExpr  prefix. Please remove that prefix so it is the same as all the rest of our tests (and the one below).

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Update high level architecture intro

This updates the current high-level system architecture documents, doing the following

mention GRPC alongside VSS
Using the new official VSS logo
Making it databroker/val-server agnostic, just always talking about the "kuksa.val" component

In case the diff is not easy to read, here is how it would/will look like
https://github.com/boschresearch/kuksa.val/blob/feature/update_arch_pictures/doc/system-architecture.md
ECA check will probably fail because it was done using drawio, but I will squash accordingly
Please also give it a quick read through @argerus

Looks good to me.


Added ignoring staff to Antimalware check.

As all other checks already have staff ignore, so I added here too. Closes #767 .

@MarkKoz It's now fixed


Provide warnings when vulnerable code is detected

This project seems well positioned to help new Solidity developers avoid known vulnerabilities. It seems like one thing that browser-solidity could do is to detect calls to send and provide a warning.
Are there other vulnerabilities we could point out?

Good idea!

We just wrote a bytecode analyzer for this at MetaMask earlier this week!
Feel free to use our code:
https://twitter.com/metamask_io/status/743644432000417793

Given #107 was closed with

Similar warnings have been added directly to the compiler, so I'm closing this PR.

Should this issue be considered closed?


Faulty/inactive collections need to respect activation point on era initialization.

Just like newly_slashed (to be renamed new_equivocators, since there is no slashing), the equivocators and inactive collections need to avoid using information from before the activation point.
Since slashed is always empty and the proposal exclusion for inactive validators is new, this is not a problem in 1.2.0.
In dev, it means that validators who were inactive in the era just before an upgrade would be excluded from proposing blocks after the upgrade. In general it's safer to apply the same rules as for the other collections, and we don't apply banning across upgrades.

Closing, as it it doesn't actually cause any issues.
This code will be cleaner once #1588 is done.


upload file

Is it possible to upload a file to a  rest server.
My file will be a csv file.

Ok I figured it out, I will convert the file to a json string and POST that.


Some bridged discord users are not invited to matrix rooms

Hi, I just installed mx-puppet-discord together with a fresh synapse server. Afterwards I bridged two guilds.
I have the problem that not every Discord user got invited to the linked matrix rooms, it seems like the bot tries to invite them but it fails. Many of this actions get logged which leads to a 1,5GB log size every day.
Any suggestions on this?
Here are some logs (multiple rooms and users are affected from this issue)
Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.759 [bot-sdk-MatrixLiteClient] #033[32minfo#033[39m: (REQ-34) PUT http://matrix-synapse:8008/_matrix/client/r0/rooms/!UUSskcYvVUZMXlRfzn%3Afopnu.pw/state/m.room.member/%40_discordpuppet__925399527853273109%3Afopnu.pw Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.762 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.763 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>38551838... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.763 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.764 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>45018132... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.765 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.765 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>98967552... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.766 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.766 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>47225128... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.767 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.767 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>76130887... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.769 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.769 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>09540116... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.770 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.770 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>70205264... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.771 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.771 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>30249738... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.772 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.772 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>89629244... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.773 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.773 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>24945262... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.774 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.774 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>50830140... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.776 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.776 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>08450048... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.777 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.777 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>18591273... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.779 [bot-sdk-MatrixLiteClient] #033[31merror#033[39m: (REQ-24) {"errcode":"M_FORBIDDEN","error":"You are not invited to this room."} Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.780 [ReactionHandler] #033[32minfo#033[39m: Received reaction from<PHONE_NUMBER>53273109 to send to<PHONE_NUMBER>75446020, message<PHONE_NUMBER>48887326 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.782 [bot-sdk-MatrixLiteClient] #033[31merror#033[39m: (REQ-25) {"errcode":"M_FORBIDDEN","error":"You are not invited to this room."}
Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.809 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>87312394... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.809 [bot-sdk-MatrixLiteClient] #033[32minfo#033[39m: (REQ-36) PUT http://matrix-synapse:8008/_matrix/client/r0/rooms/!tbzHkwyDQNiYsPJmot%3Afopnu.pw/state/m.room.member/%40_discordpuppet__925399527853273109%3Afopnu.pw Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.815 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.815 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>10668875... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.816 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.817 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>81973289... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.818 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.818 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>73329193... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.819 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.820 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>75106570... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.821 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.821 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>61133874... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.824 [Util] #033[32minfo#033[39m: Updating new display name Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.824 [UserSync] #033[32minfo#033[39m: Setting room override for puppet 2<PHONE_NUMBER>53273109 in<PHONE_NUMBER>71430164... Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.827 [UserSync] #033[32minfo#033[39m: Fetching client for -1 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.828 [UserSync] #033[32minfo#033[39m: old user info<PHONE_NUMBER>53273109 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.829 [UserSync] #033[32minfo#033[39m: no property name exists for<PHONE_NUMBER>53273109 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.830 [RoomSync] #033[32minfo#033[39m: Fetching mxid for roomId<PHONE_NUMBER>75446020 and puppetId -1 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.832 [ReactionHandler] #033[32minfo#033[39m: Removing reaction from<PHONE_NUMBER>53273109 in<PHONE_NUMBER>75446020, message<PHONE_NUMBER>48887326 Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.834 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.835 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.836 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.837 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.837 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.838 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.839 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.840 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.841 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.842 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.843 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.843 [UserSync] #033[33mwarn#033[39m: Room MXID not found Mar 29 13:48:01 matrix matrix-mx-puppet-discord[19162]: Mar-29 11:48:01.844 [UserSync] #033[33mwarn#033[39m: Room MXID not found

It seems like this project is abandoning Github in favor of Gitlab and I filed something similar over there: https://gitlab.com/mx-puppet/discord/mx-puppet-discord/-/issues/205

Thanks for simplifying my work! Yes, tracked by the issue noted above. I will close all issues on github and point to their related gitlab issues.


PROGMEM edit is broken

There are two entries that add an action for /edit:
https://github.com/toblum/McLighting/blob/090bddd32b2705f5edb7ec999cb26c50dc470151/Arduino/McLighting/McLighting.ino#L588-L590
vs
https://github.com/toblum/McLighting/blob/090bddd32b2705f5edb7ec999cb26c50dc470151/Arduino/McLighting/McLighting.ino#L682-L690
The first one is deprecated as it cannot handle PROGMEM edit.htm and should be removed.
Currently the first entry is used and this resulting in 404.

Hi @sehraf,
thank you for reporting. I'll add that in the next version 2.2.5.
Regards
Tobias

@sehraf I just published the new release: https://github.com/toblum/McLighting/releases/tag/v2.2.5


Acknowledgements for Documentation Code Reuse

Let's add the appropriate acknowledgements for the documentation code under the 'Acknowledgements' section in the Developer Guide.

Fixed


404 at /in

I found a broken link : https://docs.docker.com/in
I arrived on this page through: https://ssh.cloud.google.com/

Thanks for reporting; this looks to be a broken link from https://ssh.cloud.google.com/, which is not something we can fix in our docs 😅


Fix values not being removed when updating Include/Exclude Lists

Closes #1775
Resolves the comment: https://github.com/CarnegieLearningWeb/UpGrade/issues/1775#issuecomment-2337286655

@bcb37 @VivekFitkariwala I can confirm that simply updating segment: segment.id to segment: segment for querying the users to delete fixes the issue. The values in the Include/Exclude list are properly updated, even when values are deleted. Please feel free to approve this PR.


Update aspnetcore/security/authorization/razor-pages-authorization/sa…

AuthenticateUser() now uses the passed in email parameter, instead of the Input class property.
When checking the user entered email address, the AuthenticateUser() method was using the bound property Input, which is incorrect, the method must use the email parameter that is passed into the method.
PS: This is my first pull request, so is the above enough information?

Thank you for your contribution, @CodefridgeVan! Your change will go live within the next 24 hours.


explicit understanding of “timezone hell”

I rule and have completed some work on Case Manager that's ready for review!
(brief, plain english overview of your changes here)
This pull request makes the following changes:

Help us understand Audit trails "timezone hell"

(If there are changes to the views, please include a screenshot so we know what to look for!)
Should fix this test so it actually passes late at night EST

Will probably fail tommorrow morning.

Oh dear

(ps nice to see you @Kevin-Wei !)

Last night's build seemed to choke on some timezones. Trying the rebuild now to see what happens.
The danger period is 8pm to midnight EST, yeah? (Or maybe 3 hours right now since we're in EDT I think?)

The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   89.04%   93.62%   +4.57%
==========================================
  Files          60       60
  Lines        1333     1333
==========================================
+ Hits         1187     1248      +61
+ Misses        146       85      -61

Impacted Files
Coverage Δ

app/models/user.rb
100% <0%> (+1.11%)
:arrow_up:

app/controllers/external_pledges_controller.rb
100% <0%> (+3.7%)
:arrow_up:

app/models/event.rb
96.66% <0%> (+10%)
:arrow_up:

app/controllers/application_controller.rb
100% <0%> (+11.11%)
:arrow_up:

app/lib/reporting/patient.rb
66.66% <0%> (+11.11%)
:arrow_up:

app/controllers/users_controller.rb
90.9% <0%> (+14.54%)
:arrow_up:

app/controllers/patients_controller.rb
100% <0%> (+29.33%)
:arrow_up:

app/models/concerns/exportable.rb
96.29% <0%> (+37.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f1621...02b28de. Read the comment docs.

Done in #1300 to avoid CircleCI throw-ups


[dv/hmac] new coverage exclusion

To sign off V3 stage, add new coverage exclusion files
Add more annotations to the exclusion file
Most of them are just changing orders, new items I will make a comment on it.
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

Hi @sriyerg @eunchan @weicaiyang, this coverage exclusion file is almost the same as the previous one besides:
1). Some lines changed order
2). One more chunk of exclusion I have already commented on the code
3). Added more annotations
4). Correctly a few annotations due to new design implementation
Please take a look and let me know what you think. Thanks for your time.


expirations into the UI

I guess it would be nice to get some info of what would happen if expires the email (And how much time takes to expire). ( Just saw the contracts ). Also If I reject the transaction in MetaMask I got a non-descriptive error.

done in latest pr merge!


Fixing a few spelling mistakes in the docs

Thanks for your work on this!

Closing in favor of https://github.com/wix/react-native-notifications/pull/262


Generate Scons Pipeline Debug Script

What does this PR do?
It generate with not very useful scons-report.txt, very useful scons-debug.sh or scons-debug.bat (for Win), that simplified debugging of Scons build process, experimenting with compiler switches, fastly catching nontrivial bugs in build environment without need to run Nuitka part of code generation as discussed here https://github.com/Nuitka/Nuitka/issues/792#issuecomment-1601361367
Unfortunately, I still cannot see a reliable way to do it as a plugin, to fix exactly that environment variables and switches from SCons Pipeline, without putting this couple of lines closer (just before) SCons pipeline call.
Why was it initiated? Any relevant Issues?
https://github.com/Nuitka/Nuitka/issues/792#issuecomment-1601361367
PR Checklist

[x] Correct base branch selected? Should be develop branch.
[x] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[v] All tests still pass. Check the Developer Manual about Running the Tests.

Actually, some python 2.7 / 2.6 tests fail on my desktop (+AssertionError: gdbm  ), even then I run it with --skip-cpython27-tests + --skip-cpython26-tests, and even if I run them against pure develop branch.

I promise to add docs and tests, if it OK to include.

I think I like it, I believe it's OK to not have dedicated tests added. I think you also need to persist the environment variables, that Nuitka passes properly quoted. For Python, using repr makes this dead easy. Having the Python values go through any shell, is seriously bad.
So, my wish would be, for you to create a .bat file or .sh file that launches a Python file in the same directory. The Windows launchers nuitka.bat are using %~dp0 to get that scripts directory, for shell there has got to be similar, Stackoverflow will tell us that, and then generate that Python script by template, and have it use subprocess.call and pass its result to the outside.
Given that, I think I will myself benefit a bunch from having this.

this should have to be a python script that is generated and usable or use the "scons_python "-c" in your script.
So, my wish would be, for you to create a .bat file or .sh file that launches a Python file in the same directory.

Hmm. If you are OK with generation of two new files instead of one, OK.
My point is that shell files are more convinient to ad-hoc editing, like changing environment variables, adding some adhoc commands, etc.  Using of scons_python etc means dependency on this version nuitka on this script... But this can be OK for me.

I am actually contemplating to have an option where Nuitka calls this script, and then does post-processing though. Not sure now, if it's feasible, but having a "frozen" build folder, could allow to not run Nuitka repeatedly in some scenarios. Like e.g. when I am now doing Python 3.12 development, there isn't so much a use of doing the Python level stuff, only to see C changes. However, there is also a huge risk to misunderstand when to use this option.
I bet we will see reports from people that use it and have things no working. But I can make a big red flag warning for them, no problem I guess.

One educational thing maybe, subprocess accepts an env argument.

Yes, sorry, I used it my code, but forgot about it here.  ¯\_(ツ)_/¯

However, there is also a huge risk to misunderstand when to use this option.

You mean that people will try compile generated sources by this script and  skip Nuitka phases of adding resources?
For me  https://github.com/Nuitka/Nuitka/issues/792 can be closed,
but theoretically following usecase still looks very promising:

Developer provided only Nuitka generated sources (c/cpp/xml/const/obfuscated bytecode....) without disclosing source python code
Someone can build executable from generated sources without access to python code.

That's an interesting idea, however, this still hard codes a lot of things, so I don't think that will happen. Also DLL inclusion, etc. will need information, but having post processing at all, would be a good first step indeed.

Part of the 2.1.4 hotfix release.


fmt: 7.1.3 -> 8.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fmt/versions.
meta.description for fmt is: "Small, safe and fast formatting library"
meta.homepage for fmt is: "http://fmtlib.net/"
meta.changelog for fmt is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 8.0.0 in filename of file in /nix/store/35268mcw2qfi5pach9i87n4x391mvpqn-fmt-8.0.0

directory tree listing: https://gist.github.com/eb718c1d18bf3b57c5be9752589ac774

du listing: https://gist.github.com/65f43f309f686fe6a479339aa8e4494d

Rebuild report (if merged into master) (click to expand)

267 total rebuild path(s)

83 package rebuild(s)

83 x86_64-linux rebuild(s)
70 i686-linux rebuild(s)
43 x86_64-darwin rebuild(s)
71 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adlplug
bareos
bear
blender
ceph
ceph-client
ceph-dev
cherrytree
d-seams
far2l
fcitx5
fcitx5-chinese-addons
fcitx5-configtool
fcitx5-gtk
fcitx5-lua
fcitx5-m17n
fcitx5-mozc
fcitx5-rime
fcitx5-table-extra
fcitx5-table-other
fcitx5-with-addons
fmt
fmt_7
folly
gerbera
hal-hardware-analyzer
kodi
kodi-gbm
kodi-wayland
kodiPackages.a4ksubtitles
kodiPackages.inputstream-adaptive
kodiPackages.inputstream-ffmpegdirect
kodiPackages.inputstream-rtmp
kodiPackages.joystick
kodiPackages.kodi
kodiPackages.kodi-platform
kodiPackages.netflix
kodiPackages.pvr-hdhomerun
kodiPackages.pvr-hts
kodiPackages.pvr-iptvsimple
kodiPackages.steam-controller
kodiPackages.vfs-libarchive
kodiPackages.vfs-sftp
libceph
libime
libsForQt5.fcitx5-qt
libsForQt512.fcitx5-qt
libsForQt514.fcitx5-qt
libsForQt515.fcitx5-qt
lizardfs

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/35268mcw2qfi5pach9i87n4x391mvpqn-fmt-8.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fmt https://github.com/r-ryantm/nixpkgs/archive/f02c5cb31ecdc26db465d0e188cc20456cec97dd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/35268mcw2qfi5pach9i87n4x391mvpqn-fmt-8.0.0
ls -la /nix/store/35268mcw2qfi5pach9i87n4x391mvpqn-fmt-8.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @jeroendehaas for testing.

Result of nixpkgs-review pr 127742 at f02c5cb3 run on aarch64-linux 1

17 packages failed to build:

adlplug
fcitx5-gtk
fcitx5-with-addons
nrfutil
opnplug
pc-ble-driver
python38Packages.pc-ble-driver-py
python38Packages.qiskit-aer
python38Packages.qiskit-ibmq-provider
python39Packages.qiskit
python39Packages.qiskit-aer
python39Packages.qiskit-aqua
python39Packages.qiskit-ibmq-provider
python39Packages.qiskit-ignis
spdlog (spdlog_1)
yuzu-ea
yuzu-mainline

36 packages skipped due to time constraints:

bareos
bear
ceph (ceph-dev)
ceph-client
far2l
fcitx5-chinese-addons
gerbera
hal-hardware-analyzer
kodi (kodiPackages.kodi)
kodi-gbm
...

12 packages built successfully:

fcitx5
fcitx5-configtool
fcitx5-lua
fcitx5-m17n
fcitx5-mozc
fcitx5-rime
fcitx5-table-extra
fcitx5-table-other
fmt (fmt_7)
libime
libsForQt5.fcitx5-qt (libsForQt515.fcitx5-qt ,plasma5Packages.fcitx5-qt)
libsForQt514.fcitx5-qt

1 suggestion:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/development/libraries/fmt/default.nix:1:33:
  |
1 | { lib, stdenv, fetchFromGitHub, fetchpatch, cmake
  |                                 ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Yes, numerous breakages here, darwin and nixos.

fmt_8 is a thing now, we'll still want to switch the fmt attr to point to that but we'll do it in a separate pr


[main] [core] Remove in-spec source checksum definitions

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

We inherited a lot of %define sha1 <hash> lines in our specs from Photon. In the Mariner build system, these declarations are vestigial since we store source checksums in a separate signatures file. So, let's get rid of the remainder of these lines!
Change Log

Remove in-spec source checksums in atftp, cppunit, expect, gnuplot, gperf, hdparm, i2c-tools, libevent, libgssglue, libnetfilter_cthelper, libnetfilter_cttimeout, libnfnetlink, libssh2, libtool, lshw, mlocate, perl-DBD-SQLite, python-setuptools_scm, tmux, tree, which, xmlto

Does this affect the toolchain?

YES
Test Methodology

N/A, low risk change due to the nature of the changes within each package. Toolchain changes should be sufficiently validated by the toolchain manifest check

I love it that you did that. If you're looking for a quick way to download and extract the sources now to check the licenses, try using one of the dev scripts:
toolkit/scripts/download_spec_sources.sh cgmanifest.json [space-separated list of spec names]

Neat script! Worked great and saved me some time, thanks!


Add a TO-DO List Extension

Hey @ridsuteri, imagine someone codes on leetcode for hours and how much easy would be for him to organize his whole day with an extension. So here I am with the TO-DO List extension and for sure it would help every coder to keep a distance from his/her phone to again and again look for the next task.

Hey, Assigne this to me!

looks great @Atharv-110, go ahead :)

@kalashvasaniya issues are being assigned on first comes first served basis :)

Hey @ridsuteri can you please label this in GSSoC'22

closing this issue since the PR is merged


orthogonal regularization loss useless?

because the codebooks are not registered as trainable parameters, and the orthogonal loss is only a function of the codebooks, is the orthogonal loss entirely useless?

@GallagherCommaJack Hey Jack, thank you for catching this! Can you let me know if https://github.com/lucidrains/vector-quantize-pytorch/commit/ebce893fff695845f7fe0f04d1400d2c29b94f98 works?


[BUG] Node driver cluster type changes to Custom cluster after editing the config as yaml.

Setup

Rancher version: v2.9.0-alpha5
Rancher UI Extensions:
Browser type & version: Firefox

Describe the bug
Node Driver cluster type changes to Custom Cluster after editing the config as yaml and creating cluster.
To Reproduce

Create a rancher server v2.9.0-alpha5
Try creating Amazon EC2 Node Driver RKE2 cluster for AWS Out of Tree cloud provider testing by following these steps.
Follow the instructions to edit config as yaml.
Once the config is ready, create a cluster.

Result

RKE2 Node Driver cluster type changes to Custom Cluster.

Expected Result
RKE2 Node Driver cluster provisions successfully with Amazon Cloud Provider.

@vivek-shilimkar Would you know if this is a regression in 2.9.0?

If this is not a regression, we should push it to 2.9.next1 @gaktive

@gaktive Need someone to determine if this is a regression and take a look if it is.

@vivek-shilimkar I'm not able to repro this behavior on either v2.9-head(v2.9-a57f7025abdd80a2912f7fe53247ef7e1d4993de-head) or v2.8-head(v2.8-d7d0d9d854247d61f4018728e9a414cecf4fbb0e-head). Do you have a more in-depth reproduction example that I can use?

@vivek-shilimkar We can not reproduce - please check and if you are still able, please update this issue with more detailed instructions.
FYI @gaktive

Retested the issue. Issue is not reproducible. I may removed or changed the fields in the YAML unintentionally.
Since the issue doesn't exists, closing the issue.


[feat]: Pagination Logic in Docs

Feature description
In the pagination component documentation, the example implementation should also include logic.
Affected component/components
Pagination
Additional Context
Here is my current proposed implementation.
export interface PaginationProps {
  totalPages: number;
  totalPagesToDisplay?: number;
  currentPage: number;
  setCurrentPage: React.Dispatch<React.SetStateAction<number>>;
}

export const Pagination: React.FC<PaginationProps> = ({
  totalPages,
  totalPagesToDisplay = 5,
  currentPage,
  setCurrentPage,
}: PaginationProps) => {
  const showLeftEllipsis = currentPage - 1 > totalPagesToDisplay / 2;
  const showRightEllipsis = totalPages - currentPage + 1 > totalPagesToDisplay / 2;
  const getPageNumbers = () => {
    if (totalPages <= totalPagesToDisplay) {
      return Array.from({ length: totalPages }, (_, i) => i + 1);
    } else {
      const half = Math.floor(totalPagesToDisplay / 2);
      // To ensure that the current page is always in the middle
      let start = currentPage - half;
      let end = currentPage + half;
      // If the current page is near the start
      if (start < 1) {
        start = 1;
        end = totalPagesToDisplay;
      }
      // If the current page is near the end
      if (end > totalPages) {
        start = totalPages - totalPagesToDisplay + 1;
        end = totalPages;
      }
      // If showLeftEllipsis is true, add an ellipsis before the start page
      if (showLeftEllipsis) {
        start++;
      }
      // If showRightEllipsis is true, add an ellipsis after the end page
      if (showRightEllipsis) {
        end--;
      }
      return Array.from({ length: end - start + 1 }, (_, i) => start + i);
    }
  };

  const renderPaginationItems = () => {
    const pageNumbers = getPageNumbers();
    return pageNumbers.map((pageNumber) => (
      <PaginationItem key={pageNumber}>
        <PaginationLink
          href='#'
          isActive={pageNumber === currentPage}
          onClick={() => setCurrentPage(pageNumber)}
        >
          {pageNumber}
        </PaginationLink>
      </PaginationItem>
    ));
  };

  return (
    <PaginationNav>
      <PaginationContent>
        <PaginationItem>
          <PaginationPrevious
            href='#'
            onClick={() => currentPage > 1 && setCurrentPage(currentPage - 1)}
            aria-disabled={currentPage === 1}
          />
        </PaginationItem>
        {showLeftEllipsis && (
          <PaginationItem>
            <PaginationEllipsis />
          </PaginationItem>
        )}
        {renderPaginationItems()}
        {showRightEllipsis && (
          <PaginationItem>
            <PaginationEllipsis />
          </PaginationItem>
        )}
        <PaginationItem>
          <PaginationNext
            href='#'
            onClick={() =>
              currentPage < totalPages && setCurrentPage(currentPage + 1)
            }
            aria-disabled={currentPage === totalPages}
          />
        </PaginationItem>
      </PaginationContent>
    </PaginationNav>
  );
};

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues and PRs

Cool! When we need pagination, we value logic more and don't want to repeatedly implement a bunch of logic. However, the documentation only covers the UI. So i want to say: your work is excellent!

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


questions on Q-learning applied for racetrack

hi @aoboturov @kentan @ndvanforeest @vfdev-5 @datahaki :
I have tried implement standard Q-learning and Sarsa algorithm on a simple racetrack map. And it's very strange that while Sarsa converge very quick but Q-learning is so hard to converge in nearly same iterations(5000~10000) under same environment. WHY???
The code for generating episodes is always the same and I limit each episode in 200 time steps.
I initialize two policy with tabular form. one is for generating episode, named 'mu',it's e-greedy; another is target policy,named 'pi',it's deterministic. In every step of one episode, I keep updating 'mu' every time after I updating current Q(s,a), and set the target policy 'pi' with greedy form.
Here is my Q-learning code:
`
ep_idx = 0 	avg_ep_return_list = [] 	while ep_idx < episode_num:              '''evaluation part: Every 'eval_interval' episodes, use target policy pi generate one episode to see the total return''' 		if ep_idx % eval_interval == 0: 			eval_ep = agent.episode_generator(self.pi,max_timestep,False) 			print("eval episode length:%d" %(len(eval_ep)/3)) 			c_avg_return = agent.avg_return_per_episode(eval_ep) 			avg_ep_return_list.append(c_avg_return) 			print("assessing return:%f" %c_avg_return) 			print "avg return list length:",len(avg_ep_return_list)  		ep_idx += 1  		agent.c_state = agent.getInitState() 		agent.next_state = agent.c_state  		n = 0 		while n < max_timestep:  			agent.c_state  = agent.next_state  			c_action_idx = np.random.choice(self.action_num,1,p=self.mu[agent.c_state])[0]  			agent.c_state, agent.c_action, agent.c_reward, agent.next_state = agent.oneStep_generator()   			if agent.isTerminated(): 				Qmax = 0 			else: 				Qmax = np.amax(self.Q[agent.next_state])  			self.Q[agent.c_state][c_action_idx] += alpha * ( 			agent.c_reward + gamma * Qmax - self.Q[agent.c_state][c_action_idx])  			c_best_action_idx = np.argmax(self.Q[agent.c_state]) 			                              # --------behavior policy update at each step---------# 			for action_idx in range(self.action_num): 				if action_idx == next_best_action_idx: 					self.mu[agent.c_state][action_idx] = 1 - epsilon + epsilon/self.action_num 				else: 					self.mu[agent.c_state][action_idx] = epsilon/self.action_num   			# --------target policy update at each step---------# 			for action_idx in range(self.action_num): 				if action_idx == c_best_action_idx: 					self.pi[agent.c_state][action_idx] = 1.0 				else: 					self.pi[agent.c_state][action_idx] = 0.0  			n += 1  	return avg_ep_return_list`
`

In principle I only respond to bugs or improvements about my python implementations here. For general RL question or environment unrelated to the book, Quora or mathoverflow may be a better place. So I'm sorry I'll close this issue.


Catch base fee error and rethrow as ignition error

fixes #594
screenshot (with redacted file system info in stack trace):

Can you add a set of reproduction steps so I can test the error?

@kanej
Steps to reproduce:

set the hardhat.config.js of an example to:

hardhat: {
      mining: {
        auto: false,
      },
      blockGasLimit: 1,
      initialBaseFeePerGas: 1_000_000_000,
    },

run npx hardhat node
deploy the example module with --network localhost


Reconnecting to WhatsApp fails

Describe the bug
Connection to WhatsApp drops, and reconnect fails in similar ways until I restart entirely.
To Reproduce
Run the bridge for a long time. This may be due to a dodgy connection (I'm running the bridge on the same phone as whatsapp in termux since I didn't want to bother with a VM); it could be on wifi drop/reconnect.
Expected behavior
Reconnecting should work.
Screenshots/debug logs
Sorry, no debug logs yet. Will get soon.
[2020-04-16T23:31:31Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:31:31Z]  INFO whatsapp:     Waiting 5.347314976s...
[2020-04-16T23:31:36Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:31:37Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:31:37Z]  INFO whatsapp:     Waiting 2.823465695s...
[2020-04-16T23:31:39Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:31:40Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:31:40Z]  INFO whatsapp:     Waiting 25.543962211s...
[2020-04-16T23:32:05Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:32:05Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:32:05Z]  INFO whatsapp:     Waiting 40.051916178s...
[2020-04-16T23:32:45Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:32:46Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:32:46Z]  INFO whatsapp:     Waiting 2m2.466199038s...
[2020-04-16T23:34:48Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:34:48Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:34:48Z]  INFO whatsapp:     Waiting 42.859659648s...
[2020-04-16T23:35:31Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:35:31Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:35:31Z]  INFO whatsapp:     Waiting 5m0s...
[2020-04-16T23:40:31Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:40:32Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:40:32Z]  INFO whatsapp:     Waiting 5m0s...
[2020-04-16T23:41:19Z]  INFO zulip:        got a bad event queue id error, reconnecting
[2020-04-16T23:45:32Z]  INFO whatsapp:     Reconnecting...
[2020-04-16T23:45:32Z] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:40199-><IP_ADDRESS>:443: read: connection timed out
[2020-04-16T23:45:32Z]  INFO whatsapp:     Waiting 5m0s...

Environment (please complete the following information):

OS: android 6
Matterbridge version: 1.17.3-dev (I did a go get install, because the arm binaries don't work on android)

; git rev-parse HEAD
976fbcd07f61a8d030722a32dfc7ccc9b632399e

Additional context
[discord.---]
Token="..."
Server="..."
RemoteNickFormat="[{PROTOCOL}] {NICK} "
WebHookURL="..."

[zulip.---]
Token="..."
<EMAIL_ADDRESS>Server="https://---.zulipchat.com"
RemoteNickFormat="[{PROTOCOL}] <{NICK}> "

[whatsapp.---]
Label="---"
Number="---"
SessionFile="whatsapp----.gob"
QrOnWhiteTerminal=false
RemoteNickFormat="@{NICK}: "

[[gateway]]
name="gateway1"
enable=true

[[gateway.inout]]
account="discord.---"
channel="whatsapp"

[[gateway.inout]]
account="zulip.---"
channel="discord-whatsapp/topic:bridge"

[[gateway.inout]]
account="whatsapp.---"
channel="..."

Confusingly, this is now not happening. Feel free to close. I'm still see regular connection drops, but reconnection usually succeeds. But I think these disconnections are simply to do with the network connection on the phone, since it's happening to discord as well. Exactly every 30 minutes.
One confusing thing I would note is that in this 'reconnection' situation there's never a success message (from any of the 3 bridges - only a notification that they're reconnecting).

The connection time out means it couldn't reach the destination, this is a network issue.
I'm going to close this.
Cool that you run it on android though :-) 👍

I mean, I'm not entirely convinced it was a 'normal' connection issue, because discord/zulip weren't spitting errors (like they do on an ordinary connection drop), I would be surprised if whatsapp was down for > 15 minutes, and when I stopped and restarted it connected immediately. Perhaps it's not respecting the DNS TTL or something? But yes, without more evidence I agree this bug report is pretty useless, sorry.

Happened again today. Capped retries at 5 minutes and never managed to reconnect.
Reconnected immediately as soon as I stopped and restarted process.

Added debug logs. WhatsApp just seems extremely unreliable at reconnecting. I'm wondering if the issue is:
https://github.com/42wim/matterbridge/blob/master/bridge/whatsapp/whatsapp.go#L176
What seems to happen is that it thinks it needs to reconnect, but it's actually still connected. You can see this in odd sequence like:
[13147]  INFO whatsapp:     Waiting 5m0s...
[13447]  INFO whatsapp:     Reconnecting...
[13447] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42855-><IP_ADDRESS>:443: r
ead: connection timed out
[13447]  INFO whatsapp:     Waiting 5m0s...
[13597] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42875-><IP_ADDRESS>:443: r
ead: connection timed out
[13597]  INFO whatsapp:     Waiting 1s...
[13598]  INFO whatsapp:     Reconnecting...
[13598] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42875-><IP_ADDRESS>:443: read: connection timed out
[13598]  INFO whatsapp:     Waiting 1.033250665s...
[13599]  INFO whatsapp:     Reconnecting...
[13599] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42875-><IP_ADDRESS>:443: read: connection timed out
[13599]  INFO whatsapp:     Waiting 2.770223304s...
[13601]  INFO whatsapp:     Reconnecting...
[13604] ERROR whatsapp:     error processing data: error decoding binary: could not decode binary: invalid string with tag 174
[13747]  INFO whatsapp:     Reconnecting...
[13747] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42855-><IP_ADDRESS>:443: read: connection timed out
[13747]  INFO whatsapp:     Waiting 5m0s...
[14047]  INFO whatsapp:     Reconnecting...
[14047] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42855-><IP_ADDRESS>:443: read: connection timed out
[14047]  INFO whatsapp:     Waiting 5m0s...
[14347]  INFO whatsapp:     Reconnecting...
[14347] ERROR whatsapp:     Connection failed, underlying error: connection to WhatsApp servers failed: read tcp <IP_ADDRESS>:42855-><IP_ADDRESS>:443: read: connection timed out

Where is seems like it's on a 5 minute back-off, but suddenly jumps in a says 1 sec reconnecting (and then still keeps printing messages about 5 minute back-off). I've also received messages while it looks like it's disconnected - although sometimes messages are missed (?).

(you can get a rought sense of the timing because of the numbering - I've excluded Zulip's regular heartbeat message)

I've got the same error. As soon as I restart the Matterbridge service / docker container it works again. Did you find out what the problem was?


use refget for hashing

Can you see if this makes sense to you?

I intend them to be functions and already started this conversion in refget, but perhaps didn't complete it.
these functions do not need the RefDB object so I've moved them off it. they are static functions.

There you go, that should clean them up.

If this works for you, I say we just go with this for now.

ok, works. ready to merge?


Change bot login session name and OS

The login session of the bot on the telegram account is like this:

It looks so obvious that this can be problematic!
Is there any way that we can change how the bot introduces itself to the server and pretends to be a native Telegram Android app or anything less suspicious?

Так если ты не парился при создании ключей API, чья это проблема?

Так если ты не парился при создании ключей API, чья это проблема?

I'm using google translator and I do not get exactly what you meant
I just did exactly as instructed in README.md file of the bot.
I created an API token and added that to .env file. Then created a session...
Whas there any options to edit the way bot introduces itself to server?

Так если ты не парился при создании ключей API, чья это проблема?

I'm using google translator and I do not get exactly what you meant
I just did exactly as instructed in README.md file of the bot.
I created an API token and added that to .env file. Then created a session...
Whas there any options to edit the way bot introduces itself to server?

"He meant that when creating API keys(from README.md instruction), you had the option to create keys that weren't tied to your IP. There are many ways to do this, but if you really want to, you can go through the trouble."

Так если ты не парился при создании ключей API, чья это проблема?

I'm using google translator and I do not get exactly what you meant
I just did exactly as instructed in README.md file of the bot.
I created an API token and added that to .env file. Then created a session...
Whas there any options to edit the way bot introduces itself to server?

He meant that when creating API keys(from README.md instruction), you had the option to create keys that weren't tied to your IP. There are many ways to do this, but if you really want to, you can go through the trouble.

Thanks for the clarification,
I have no issue getting bot to work. I'm trying to make my activity look more stealth and normal to the server. Using a login session assigned to a Pyrogram is so screaming!

Если ты хочешь сделать свою активность похожей на человека , то тут нужно использовать токены и хэдеры с реального  девайса вместо авторизации через сессию pyrogram

If you want to make your activity look like a person, then you need to use tokens and headers from a real device instead of authorization through a pyrogram session

THANKS
is it something I can do without deep know how of PYROGRAM?
I'd developer but not expert in python and have never heard of pyrogram before!
Is it possible for you to guide me through this?

Дак а как ещё работать с сессий телеграмма если не через пирограм насколько я знаю других библиотек нету ( а сеанс пирограм выглядит именно так

So how else to work with telegram sessions if not through Pyrogram, as far as I know there are no other libraries (and a Pyrogram session looks exactly like this

Isn't there any way PYROGRAM introduces itself as official telegram app of at least something less suspicious? Like telegram web login?

Ну как мне кажется тебе надо доставать api id и api hach от оф приложений а у них там по-любому какая то защита на то что ты просто так эти данные не заюзаешь

Вот ознакомься как я и говорил https://lolz.live/threads/6194755/

Если тебе хочется это сделать  поизучай кастомным клиенты по типу экстра Грам у которых код открыт они

device_model = "Samsung Galaxy S24 Ultra"
app_version = "11.1.3"

BRILLIANT
THANK YOU
For the record:
After editing registrator.py I got this:

Then I changed App Title and Short Name of the API token I got from my.telegram.org (No need to re issue):

Then I got the ideal result:

Thanks again
Are you co-author of this bot?

Thanks again Are you co-author of this bot?

Glad it helped No, I'm not.

Good to have you around ...

Good to have you around ...

I'm not even a contributor. Just sitting here like on Reddit 😀

With the modifications you instructed, login session was successful but after running the bot suddenly device name and version changed back to what it was:

I think other than registratory.py there is another file that needs modification.
My guess is \venv\Lib\site-packages\pyrogram
What do you think?
Please just investigate into it if it doesn't take much time...
Thanks again

Here's where you need to add those params
https://github.com/shamhi/HamsterKombatBot/blob/1cd3cc4aae899d74c914f3ea7ba05a9dd67ab3ef/bot/core/registrator.py#L29

With the modifications you instructed, login session was successfully crated but after running the bot suddenly device name and version changed back to what it was:
I think other than registrator.py there is another file that needs modification. My guess is \venv\Lib\site-packages\pyrogram What do you think? Please just investigate into it if it doesn't take much time... Thanks again

I have found this:

Should I override them with hardcoded text?

tg_clients = [Client(

WOW
IT WORKED LIKE A CHARM!
Too much for a like Reddit watcher!!!
You gotta be watching deeeep man...
Thanks again and again and again....
Can I have your telegram ID please?


Add recordGaugeDelta in StatsDClient.

Resolves issue: https://github.com/DataDog/java-dogstatsd-client/issues/36
Interface name recordGaugeDelta is made similar from: https://github.com/tim-group/java-statsd-client/blob/ec75702a61af3daabd9c826f687243a3ee6fcde9/src/main/java/com/timgroup/statsd/StatsDClient.java#L111
StatsD gauge delta specification can be found here: https://github.com/statsd/statsd/blob/master/docs/metric_types.md#gauges

Closing this temporarily as it seems that this is not supported by design


AttributeError: 'FileChooser' object has no attribute 'display'

    fc = FileChooser('C:\\Users\\rfresh1011\\Documents\\pEdit')
    display(fc)

AttributeError: 'FileChooser' object has no attribute 'display'

Can you please provide some additional details? Are you running this in Jupyter Lab or Jupyter Notebook (and which versions)? Can you provide more of the code you're trying to run so I can try and replicate?


Update therubyracer gem from v0.12.1 to v0.12.2

Updating to version 0.12.2 which was released with PR FIX: severe memory leak in WeakValueMap

I'd argue we should drop this dependency altogether. ExecJS will find a JavaScript runtime and I'd wager most (if not all) developers have a recent node.js and our app servers have node.js out-of-the-box.
There's prior art for dropping this dependency elsewhere also.

I'm not sure, I think in the short term, this might help with the memory issues we are seeing on smart answers, and brings therubyracer version inline with what's running in frontend etc.

Maybe relevant? https://github.com/reactjs/react-rails/pull/290

Dropping the dependency altogether will remove it from memory entirely :confused:
This has been done before (in examples below and several others including alphagov/whitehall) and we're not seeing any issues.
alphagov/calendars#104
alphagov/publisher#438

@erikse If this is causing issues currently and needs resolving quickly, feel free to merge and bring up the discussion after.

I'm not sure it'll make much of a difference, I can't find any explicit dependency on therubyracer in the smart answers code, so I guess it's just used for compiling the sass/assets

This PR has been superseded by #2260


Can’t win by removing stones

On reomving all opponent’s stones the game goes on allowing the opponent to roll his die and move selected—1st player’s—stone. Only then does the game ends resulting in opponent winning.

Done


Create BEM NEW BUILDING VERIFICATION METHODOLOGY

First draft meant for initial review by Steering Committee.

Is it me or is the file to review incomplete? (the one I can see stops quite abruptly and the overall layout is quite peculiar)

Going to close for now and re-open once its been completed and reformatted.


View menu checkmark does not respond to manual fullscreen.

My Setup

Operating System: macOS 10.15.4
App Version: 2.17.7
Installation type: dmg

[x] I have tested with the latest version
[x] I can simulate the issue easily

Description

The "Full screen" option in the View menu on the top does not work properly. This is a minor UI issue for the checkmark that shows if you click the "Full screen" option or use the "cmd+ctrl+F" shortcut the checkmark appears and disappears as expected but doing it manually using the window buttons does not make the checkmark appear or disappear.
The menu and checkmark are:

Current Behavior

When I use the window buttons to exit fullscreen.

The checkmark is still there when the app is not in fullscreen mode.

Expected Behavior

The checkmark should not be shown anymore. Vice versa for when going into fullscreen using the window fullscreen button.

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Add a tutorial to push the build result to GitHub Pages

fix #14

Not at all how I'd do it these days: GitHub Pages now provide GitHub Actions so you can have your eleventy site built and deployed in a GitHub Action: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow (which also means that you could setup a scheduled build and GitHub Secret to retrieve new tweets from Twitter and publish the new site automatically; just make sure you also correctly configure the @actions/cache action)

PR welcome @tbroyer

I'll try it on my repo and contribute back when I confirmed it works :+1:

It currently can't work for large collections of tweets:

#4

Well, it can: limit is now 100MB for "regular" files and you can use LFS for larger files.
(mine is "only" 30MB)
The documentation could also list both approaches.

Here's my take on it: https://github.com/tbroyer/tweetback/blob/main/.github/workflows/deploy.yml, deployed at https://tbroyer.github.io/tweetback/
I probably overthought the caching a bit, and I prepared but didn't setup automatic fetching of new tweets from the Twitter API.
Also note that I committed my package-lock.json so this is using npm ci for more reproducible builds (see also https://github.com/tweetback/tweetback/discussions/16)
WDYT?

@tbroyer could you please open an issue or a PR for a new doc file named docs/deploy-to-github-pages-with-github-actions.md or similar?
I think both ways to publish to GitHub Pages can be interesting, just like we have many options to deploy Eleventy sites.

Is there a way to update the page updating from the API? so we don't have to push every so often with new data.


[Tizen] Implement "MediaStream" manifest permission check.

To implement "MediaStream" manifest permission check for Tizen Crosswalk. This patch is one of series of patches to resolve bug XWALK-553.
Spec:
https://github.com/crosswalk-project/crosswalk-website/wiki/zzz_archive-[Manifest-permissions]
Test case:
As the attached xpk in the followed comment, if the manifest includes
"xwalk_permissions": [ "MediaStream"]
Then,  the JS call "navigator.getUserMedia" will trigger permission check.
Bug:
BUG=https://crosswalk-project.org/jira/browse/XWALK-553

Closing, Tizen is out of scope now.


Hypercorn HTTP/2 Testing

Overview

Add testing for Hypercorn serving over HTTP/2.
Add testing infrastructure for sending HTTP/2 and HTTP/3 requests.
Add niquests dependency to hypercorn tests for a clean interface for newer HTTP requests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.27%. Comparing base (b550b0d) to head (2785530).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
- Coverage   81.36%   81.27%   -0.10%
==========================================
  Files         199      199
  Lines       21834    21834
  Branches     3462     3462
==========================================
- Hits        17766    17746      -20
- Misses       2925     2944      +19
- Partials     1143     1144       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Play video files from a folder

Really enjoy this module! Thank you Snille
It is possible to play videos from a local folder where video files placed?

Good to hear! :)
Yes, just add the files to the "local" video-folder:  "MMM-Videoplayer/video/"
Then add the following under the config part of the MMM-Videoplayer:
videolist: ["/modules/MMM-Videoplayer/video/yourvideo01.mp4", "/modules/MMM-Videoplayer/video/yourvideo02.mp4"]
Just add more files as you want to the line remember the comma in between the files... :)
I hope that works... :)

Is it possible to play videos from an external drive, like a usb stick?

Hi @Cheese041, well, sort of.. :) If you make sure that the USB-stick (or drive) is mounted somewhere in the MM:s modules folder. The videoplayer can play files from anywhere inside the modules folders or from URL:s. So it's not as easy as to plug in a USB-stick and point to that folder (that would usually be /media/something (if you use Rasbian) but the MM modules can not access the files and folders outside the MM:s boundaries. (it's not allowed within the MM-system). So you have to mount the USB-stick (or drive) to somewhere in the MM:s modules folder...  :)
Here is a guide for Rasbian: https://www.raspberrypi-spy.co.uk/2014/05/how-to-mount-a-usb-flash-disk-on-the-raspberry-pi/
But remember to create the "mount point" in step 3 to somewhere inside your MM:s modules folder (maybe do something like this: "/home/pi/MagicMirror/modules/MMM-Videoplayer/video/usb-stick" if you are using a RPi...) Then use that mount point in the rest of the guide... :)

It worked. Thank you so much!


feat(coverage): use yaml file for codecov.io

Fixes #661

[Current coverage][cc-pull] is 82.21%

Merging [#693][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master       #693   diff @@
==========================================
  Files            29         29
  Lines          2557       2557
  Methods           0          0
  Messages          0          0
  Branches        397        397
==========================================
  Hits           2102       2102
  Misses          327        327
  Partials        128        128

Powered by Codecov. Last updated by [2c04868...86b0fa4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/controller/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/controller/compare/2c04868058f4ebcb4925389345d58797ab3b4604...86b0fa4a38fbbe1b0a475f7490e06cba8f504307
[cc-pull]: https://codecov.io/gh/deis/controller/pull/693?src=pr


⚠ 广电VRBT has degraded performance

In 4948add, 广电VRBT (https://vrbt.10099.com.cn/#/home) experienced degraded performance:

HTTP code: 200
Response time: 19582 ms

Resolved: 广电VRBT performance has improved in f56f522 after 9 minutes.


Update setup.py for automatic listing by Lektor website

As laid out in https://github.com/lektor/lektor-website/issues/203 and associated issues linked there, the Lektor project's website is changing to pull plugin lists automatically from PyPI. For this to work, plugins need to have proper information registered in PyPI, which is done with a few changes to setup.py.
Updating the metadata in PyPI requires bumping the version number.
cc @nixjdm - could you take a look over this and make sure I've ticked all the right boxes?

LGTM! So you know, you can optionally add project_urls (if any - personal / company website?) and keywords. getlektor.com doesn't use those (at least right now), but pypi.org does. It's fine without that though.


[LinearProgress] Indeterminate/Query animations do not loop properly

The animations for indeterminate/query modes do not loop properly. Basically the animation ends empty and starts half-filled.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The animation loop should be seamless, as in here:
https://material.io/guidelines/components/progress-activity.html#progress-activity-types-of-indicators
https://getmdl.io/components/index.html#loading-section
Current Behavior

The animation loop is not smooth, as in the demo page: https://material-ui-1dab0.firebaseapp.com/demos/progress/
Steps to Reproduce (for bugs)

Open the demo page: https://material-ui-1dab0.firebaseapp.com/demos/progress/
Context

Your Environment

Tech
Version

Material-UI
latest beta

React
15

browser
Chrome 61

Notice the same issue. Also the start for the animation take a bit too long or is it really loading that long?
Using it like this:
<Button raised color="primary" type="submit" className={classes.button} disabled={registerInProgress}>
  Register
</Button>
{ registerInProgress &&
  <LinearProgress />
}

Also the start for the animation take a bit too long or is it really loading that long?

Looks like this has been fixed as well via https://github.com/callemall/material-ui/pull/8146/commits/f6acea90d38abb9cef08cb6f6a9248440c06dfec Thanks!

@Skaronator this is good to know :).

Progress component still don't work on Safari 10 (iOS 10.3),  Safari 10.1 (Mac OSX 10), Chrome 61 on iOS 10.3. I can't go anywhere when visit Progress demo page.
It work well on Chrome 60 on Mac OS X.
I tested with 7b4b53a60bb4659d9864cc5328dad2fb624b446e

Progress component still don't work on Chrome 61 on iOS 10.3, Safari on Mac OSX and iOS. But work well with Chrome 61 on Mac OSX. I can't navigate anywhere when visit Progress demo page.
I tested with a5002c8a7

@wellbeck190 Are you referring to #5524?

Sorry, I read and understand why this bug hasn't fixed yet.
Thanks @oliviertassinari


Add is-string solution

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     14
  Lines         215    217    +2
  Branches       38     35    -3
=====================================
+ Hits          215    217    +2

Impacted Files
Coverage Δ

src/functions/is-string.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ed93d...ae491ba. Read the comment docs.

I've already added this solution and opened PR for this: https://github.com/Acanguven/rapidash/pull/31

I am sorry @ilker0, @yavuzkoca opened a pull request for this method before you :(


Philosophy

Taking notes on some ideas to reference when making decisions on picking tools and designing APIs...

foo.use(() =>) can be a common way to mixin functionality
foo.on('bar baz', () =>) can be a way to hook into lifecycle/events/scoped-things
Arrow functions all around, avoiding classes and this
Async/await over callbacks/generators/plain-promises
Middleware as a common composition pattern
Standard format linted
Stage 4 approved, Node-first universal, JS (e.g. Avoiding transpiled additions like JSX, flow, webpack loaders or browserify transforms)
Solve for 80% of use cases with obvious escape hatches for the other 20%
minimal > proper
obvious > pure
pragmatic > the right way
composition > inheritence
fun > jargon
explict > implicit
wrapping modules > convention > configuration
stand on shoulders of tall people > re-invent the wheel

Some articles that feels aligned in some ways:

http://www.christianalfoni.com/articles/2016_09_11_The-case-for-function-tree
http://www.christianalfoni.com/articles/2015_11_16_Flux-vs-Single-State-Tree
https://github.com/yoshuawuyts/choo#philosophy
http://staltz.com/some-problems-with-react-redux.html
https://medium.com/javascript-scene/the-two-pillars-of-javascript-ee6f3281e7f3
https://www.infoq.com/presentations/Simple-Made-Easy

If moving popularity up the list of importance...
Language/Core

babel-core
babel-plugin-transform-runtime
babel-preset-latest
webpack + babel-transform > babelify
webpack-??? > brfs-babel
lodash

Loader

dotenv
webpack-env > envify
webpack-hotloader > hotglue
express > koa

Controller

fetch > lokka
fetch > lokka-transport-http
redux > universal-tree

Model

graphql.js + mongoose > mojol

Router

react-router + express > unikoa
react-router + express > unikoa-react-render

View

react > veact
reeeset


Add installation and usage instructions to the Readme

Expected Behavior
The Readme should include the basic step required to install and setup a new project.
The most difficult part of connecting with a new project is often the setup, and if there are a list of simple steps to follow that helps new users a lot.
Current Behavior
The Readme is not helpful to new users.
Possible Solution
Two new sections should be added:

Installation

Usage, or creation of a basic project

Alternatively, if there is already a document describing these steps elsewhere, the Readme should link to it.

I think we need to distinguish between two types of documents.

Documentation that explains how to use dav-js to build something.
A CONTRIBUTING.md document which explains how to get started contributing to and modifying dav-js itself.

The first is available in our developers site, although it is still lacking a section explaining the basics of how to get started with it.
The second is definitely needed and it would be great if you could create.


Set icon label's aria label

Fixes #189784
@meganrogge I wasn't sure how to do audio cues or if that's something we want, but I've set the aria label to match that of the title attribute so screen readers can benefit

Didn't test but LGTM. Did you try w a screen reader to make sure it's read as expected?


Update devcontainer.json

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[x] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

That part

@rllane17 thanks for your contribution! I noticed that your PR is not targeting our main branch. Also it's not clear what is the purpose of your changes.  Could you please improve this PR by adding a better description?


Add a warning for unknown default profiles

Summary
This PR addresses #388:

Introduces NextestConfigImpl::DEFAULT_PROFILES, a const containing all the nextest defined profiles (at the moment this only includes default and default-miri)
Looks through all profiles in a project's config for profiles with the default- prefix that are not in NextestConfigImpl::DEFAULT_PROFILES and produces a warning for each of them

Note that I ended up doing this in nextest-runner/src/config.rs instead of in cargo-nextest since AFAICT this is where a lot of the early validation of config files is being done and similar warnings were already being emitted there. Happy to move if you still feel the binary (e.g. somewhere in nextest-runner/src/dispatch.rs?) is a better place for this.
Test Plan

Ran cargo xfmt

Ran cargo nextest run --all-features. Saw integration-tests failures but they seem unrelated to my changes and they repro on base rev, hopefully CI will tell me if they're legit.

Set up a dummy library project with some profiles that should and some that shouldn't trigger this warning.

[profile.default-unknown]
fail-fast = false

[profile.default-yet-another-unknown]
fail-fast = false

[profile.not-default-unknown]
fail-fast = true

Then ran the tests with my changes, verified that only the expected profiles trigger the warning
➜  nextest-test git:(main) ✗ nt.local nextest run
warning: found unknown profiles in the reserved default- namespace in .config/nextest.toml:
warning:   default-unknown
warning:   default-yet-another-unknown
    Finished test [unoptimized + debuginfo] target(s) in 0.00s
    Starting 2 tests across 1 binaries
        PASS [   0.006s] nextest-test tests::test_bar
        PASS [   0.006s] nextest-test tests::test_foo
------------
     Summary [   0.009s] 2 tests run: 2 passed, 0 skipped

Renamed all profiles to no longer have the default- prefix, verified that no warnings are triggered
➜  nextest-test git:(main) ✗ nt.local nextest run
    Finished test [unoptimized + debuginfo] target(s) in 0.00s
    Starting 2 tests across 1 binaries
        PASS [   0.006s] nextest-test tests::test_bar
        PASS [   0.006s] nextest-test tests::test_foo
------------
     Summary [   0.009s] 2 tests run: 2 passed, 0 skipped

Looks good, thank you!

Looks good, thank you!

Should #388 be closed?


Initial surface alignment TMOP capability

This is the initial surface fitting code that was used in our IMR paper. Further improvements of the fitting capabilities will require restructuring, i.e., most likely there will be another miniapp, but this code is a good starting point to have before starting the in-depth work.
There are some changes in the output format, and there are two new sample runs. The autotests will have to be updated.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1915
@vladotomov
@tzanio
@tzanio + @kmittal2 + @jandrej
09/29/21
⌛due 10/13/21
⌛due 10/20/21

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

@jandrej, are you interested in reviewing this?


Comply with scikit-learn convention

Let's use the sklearn convention: https://scikit-learn.org/stable/developers/contributing.html#coding-guidelines
Specifically, the API of scikit-learn objects should be very closely followed.
It might be best to just use this repository: https://github.com/scikit-learn-contrib/project-template/

Dear Prof. @nipunbatra
Could you enable GitHub pages for the package? I was thinking to test the documentations created by sphinx.

Please create a docs folder and I will enable pages on /docs


Approval events on transferFrom and burnFrom

With this extension, an application should be able to just listen for Approval events and still keep track of the allowances for all accounts.
Should we add a comment in the code emphasizing the fact that the standard doesn't require the event to be emitted, and other compliant tokens may not do it?
Closes #707.

Yes I would add a comment in the code or in the inline docs or both.


Added gcc-7

Pull Request Test Coverage Report for Build 804969193

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 804489526:
0.0%

Covered Lines:
325

Relevant Lines:
325

💛  - Coveralls

Pull Request Test Coverage Report for Build 804969193

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 804489526:
0.0%

Covered Lines:
325

Relevant Lines:
325

💛  - Coveralls

Needs more informative error message in core17_generated.hpp

@apolukhin i'm finished

/usr/bin/../lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/tuple:807:33: error: implicit instantiation of undefined template 'std::tuple_size<my_struct>'
    : integral_constant<size_t, tuple_size<_Tp>::value> { };
                                ^
./boost/pfr/detail/core17_generated.hpp:57:9: note: in instantiation of template class 'std::tuple_size<const my_struct>' requested here
  auto& [a,b,c] = val; // ====================> Boost.PFR: User-provided type is not a SimpleAggregate.

another day, troubles are the same

/usr/bin/../lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/tuple:807:33: error: implicit instantiation of undefined template 'std::tuple_size<my_struct>'
    : integral_constant<size_t, tuple_size<_Tp>::value> { };
                                ^
./boost/pfr/detail/core17_generated.hpp:57:9: note: in instantiation of template class 'std::tuple_size<const my_struct>' requested here
  auto& [a,b,c] = val; // ====================> Boost.PFR: User-provided type is not a SimpleAggregate.

another day, troubles are the same

i suppose, i know how to fix it https://godbolt.org/z/hWzsojGe6

Closed because it's not actual.
Actual PR here: https://github.com/boostorg/pfr/pull/116


Neutral tonemapping does not implement exposure.

Recently introduced "neutral" tonemapper, does have exposure uniform in shader, but does not use it in implementation, so exposure does not affect materials' look.

Thanks, fix incoming!


I want use a-h/templ to write a go code template for my gogen program. How to write curly braces without them being recognized as variables?

I want use a-h/templ to write a go code template for my gogen program. How to write curly braces without them being recognized as variables?

This is not recommended, templ is a HTML templating language.

Sorry, what I'm trying to say is that you shouldn't write Go code templates using templ, it's for HTML.


Improving e2e test

Added a more complex multi-tenant test case #108
Added simple chaos testing by randomly deleting runner pod #115
Added some labels to the runner pod

Something I observed that the runner pod stays alive indefinitely for each Terraform object. If the user has a lot of Terraforms, then there will be a lot of long-living pods. Anything we should do to address this?

Something I observed that the runner pod stays alive indefinitely for each Terraform object. If the user has a lot of Terraforms, then there will be a lot of long-living pods. Anything we should do to address this?

Yes, we'll address it by #104


Use theia-latest instead of theia-next in samples

This PR replaces usage of the theia-next devfile URI (which is now broken) with the theia-latest devfile URI for all samples that were using theia-next.
I also modified the names of the sample workspaces so that they would all be unique, preventing any conflicts when applying multiple samples at the same time. This isn't necessary (though I've found it useful in the past) and the commit for it can be removed if desired.
What issues does this PR fix or reference?
Fix #992
Is it tested? How?

Deploy DWO
kubectl apply -f  the following samples:

theia-latest.yaml
theia-latest-contributions.yaml
pod-overrides.yaml
ephemeral-storage.yaml
per-workspace-storage.yaml
git-clone-sample.yaml

Ensure they all start up sucessfully with kubectl get dw -w

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)

[ ] v8-devworkspace-operator-e2e: DevWorkspace e2e test
[ ] v8-che-happy-path: Happy path for verification integration with Che

No idea why codecov is reporting that code coverage decreases with this PR

Before I merge this, I also need to update the README since it mentions the flattened_theia-next sample


Additive cacheHeaders API

Currently fun <T> MutableExecutionOptions<T>.cacheHeaders(cacheHeaders: CacheHeaders) replaces the cache headers with the new value - we may also need an additive API, like the one we have with http headers.
Original discussion on Slack here

Resolved by #50


Updated validations.py python script.

Updated validations.py script.
Fixed behaviour of validate_user to get required output.
Fixes #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


Add Instruction how to run Android and set it up

Go to the folder for Android where the name of the folder should be the name of the language itself. Inside the folder should be the Hello World! code of the file (there will be quite a few files there).
Your task is to create a README for the same and make sure it covers all instructions on how to set up Android Dev Environment.
The README should also contain steps to install that language on various OSs like Mac, Linux and Windows. If you don't know any of these steps, kindly ping back in the comments so that I can help you out.
Ground rules:

Whoever claims the Issue first, should send a Pull Request within 24 hours else it'll be assigned to another claimant and further Pull Requests regarding that issue will not be entertained.
Pull Requests sent without claiming and referencing the Issue will not be entertained.
Make sure your Pull Requests have just one commit in them. Squash multiple commits into one if you have to.

Best of luck. Let the Hacktoberfest begin!!

I will work on this

@sachincool sure go ahead!

should i send the pr  now ? or wait till 1st october   . as its my first hacktoberfest .

@sachincool Wait till October first if you want this to be counted in the Hacktoberfest :slightly_frowning_face:

will i still have this issue assigned  till 1st october ? As it said you have to submit pr within 24 hours :cry:

Umm no! Issue reassigned every 24 hours! FCFS Applied here!

@salman-bhai Oh ! thanks I'll wait  for the 1st oct then :+1:  you may  put the label "up for grabs" again .

Hey!

Claiming the issue :D

Claiming the  Issue :1st_place_medal:

please Look over it and feel free to point out any important details  which i may have missed :+1: @salman-bhai


fix: changed DP and other things

changed brobot's DP and refractored the code

@alias-rahil can you use the @all-contributors bot (just add another comment on this issue) to add whoever worked on the logo as a contributor? Mention the contribution as design

@all-contributors please add @siddhanttk for design

@all-contributors please add @ashikka for docs


while starting the server

Hi,
I am getting this error while starting the server  :  listen EADDRINUSE: address already in use :::8081
Can you tell me the reason for this error?? and also after successfully getting this should we type in some command before starting the client??

try this: lsof -ti :8081 | xargs kill -9
refer to this stackoverflow comment for more info: https://stackoverflow.com/a/4086015