Providing client connection metadata for service event filtering purpose

Is there anyway to provide some metadata (client id, device type...) for a client connection so that Feathers services on backend can use them as event filtering purpose?
This will be quite useful for service events to be received for particular device or client only.

The server has to keep the client metadata and that requires the server be stateful, which is something we would try to avoid.
Both socket.io and primus allow data to be retained per WebSocket connection, and its better to use that than roll our own. It however would not be a good idea to keep too much data per client.
The straightforward way to transmit the data from the client would be to emit an event on the socket.
The following code does this for socketio (tested a bit) and primus (not tested). Feathers saves some of its own data on the socket object, and the code places its data within Feathers data. That may or may not be a good idea.
Client:
const serverUrl = 'http://localhost:3030';
const socket = io(serverUrl);
const feathersApp = feathers()
  .configure(feathers.socketio(socket));

setTimeout(() => {
  socket.emit('add-offline-filter', { serviceName: 'remoteService', query: { dept: 'a' } });
  socket.emit('remove-offline-filter', { serviceName: 'remoteService' });
  socket.emit('add-offline-filter', { serviceName: 'remoteService', query: { dept: 'b' } });

  const service = feathersApp.service('remote-service');
  service.create({ name: 'nick' })
    .then(data => console.log(data));
}, 1000);

Server:
const app = require('../../common/src2/app');
const debug = require('debug')('feathers-state:index');

const port = app.get('port');
const server = app.listen(port);

server.on('listening', () =>
  logger.info(`Feathers application started on ${app.get('host')}:${port}`)
);

// Set up handling of socket events from the client
const socket1 = {
  socketio,
  primus,
};

const options1 = {};

// Socket.io middleware
if (app.io) {
  debug('registering Socket.io authentication middleware');
  app.io.on('connection', socket1.socketio(app, options1));
}

// Primus middleware
if (app.primus) {
  debug('registering Primus authentication middleware');
  app.primus.on('connection', socket1.primus(app, options1));
}

// The actual service event filtering
const service = app.service('remote-service');

service.filter((data, connection, hook) => {
  console.log('filter data', data);
  console.log('filter connection', connection);
  console.log('filter method', hook.method);
});

// Helpers

function socketio(app, options = {}) {
  debug('Setting up Socket.io authentication middleware with options:', options);

  const providerSettings = {
    provider: 'socketio',
    emit: 'emit',
    disconnect: 'disconnect',
    feathersParams: {
      get: socket => socket.feathers,
      set: (socket, data) => { socket.feathers = data },
    }
  };

  return setupSocketHandler(app, options, providerSettings);
}

function primus(app, options = {}) {
  debug('Setting up Primus authentication middleware with options:', options);

  const providerSettings = {
    provider: 'primus',
    emit: 'send',
    disconnect: 'end',
    feathersParams: {
      get: socket => socket.request.feathers,
      set: (socket, data) => { socket.request.feathers = data },
    }
  };

  return setupSocketHandler(app, options, providerSettings);
}

function setupSocketHandler(app, options, { feathersParams, provider, emit, disconnect }) {
  return function socketHandler(socket) {
    socket.on('add-offline-filter', addOfflineFilter);
    socket.on('remove-offline-filter', removeOfflineFilter);
    //socket.on(disconnect, logout);
    //socket.on('logout', logout);

    function addOfflineFilter({ serviceName, query}, callback = () => {}) {
      console.log('add-offline-filter', serviceName, query);
      let params = feathersParams.get(socket);

      if (!params._offline) {
        params._offline = {};
      }

      params._offline[serviceName] = query;
      feathersParams.set(socket, params);

      console.log(params);
      callback(null, params);
    }

    function removeOfflineFilter({ serviceName }, callback = () => {}) {
      console.log('remove-offline-filter', serviceName);
      let params = feathersParams.get(socket);

      if (!params._offline) {
        return callback(null);
      }

      delete params._offline[serviceName];
      feathersParams.set(socket, params);

      console.log(params);
      callback(null, params);
    }

    function logout(callback = () => {}) {
      const params = feathersParams.get(socket);

      callback(null, params);
    }
  }
}

I'm not willing to maintain this code, so you'll have to sweat the details yourself.

@eddyystop This is really helpful. Thanks a lot!


Passing authorization Parameters : Trino

We use trino (interact via REST API of trino)  and trying to understand how we can pass on params like user name/pwd (or other auth params)  and other params trino support when sending query to execute. Below is link to examples but it was not clear how it would work? (Trino through ranger serves as our RBAC )
https://github.com/bazooka720/dj/tree/main/datajunction-query#executing-queries

Hi @bazooka720! The query service is a pluggable piece of the architecture (talked about a little in the docs here), meaning you can implement the query service however you'd like including any sort of authorization. Then the core API will connect to it using any dependency injected query service client that has the expected spec (see here). So a typical enterprise setup today would use the pure OSS version of the core datajunction service with an internal custom query service and query service client that plugs into the core service.
I'd really like to see a robust OSS offering of a query service that's fully integrated to work with Trino that people can just configure, deploy, and use out of the box, but I don't think we're there yet. Let me know if you want to collaborate on something like that!

Thanks @samredai. Just to confirm, currently you don't support Trino? (In the picture i saw trino but was not sure). Is IBIS a potential option

To be completely accurate, the query service implementation that exists in the repo today does support sqlalchemy and allows you to pass in any sqlalchemy uri with any additional parameters to the sqlalchemy engine initialization. I've made a note to document this more clearly and add it to the repo.
What I was really trying to get at is that there is still work to be done to make it a richer experience. For example, you mentioned you're using RBAC via Ranger which implies you'll need user info to flow through to the queries submitted to the query service. We support plugging in authentication to the main service but the OSS query service does not have any support for various authorization schemes. The OSS query service assumes all queries will be submitted to Trino using a generic set of credentials that were provided for initializing the sqlalchemy engine instance.

I see now. New to DJ, I really love the approach (albeit i have so many questions and trying to understand how it's all coming together). Regarding the authorization, yes...we would ideally need more of dynamic approach as our current interaction with Trino itself is via its REST API and every query sent is authorized. Is this something feasible? One alternative for us is to deploy via isolated serverless may be?

Isolated serverless would probably be slightly easier than implementing and maintaining your own query service but it doesn't solve the main issue which is that we don't include the user in the request to the query service (unless you intend to automatically inject that into the header). This should be a small change since we already have current_user in scope when we make that call. Then yes, presumably you could just instantiate a client for that particular user in the serverless function and the rest of the authorization flow would take effect!
It's also worth mentioning that you'd need a gateway that matches the spec for the query service API but that's only 3 simple endpoints--submit a query, get a query by id, and get column metadata for a specific table.

We shall try and get back

Hi @bazooka720! If you're interested in implementing an internal query service API that matches the spec expected by the core DJ API, you can follow the spec for these two API endpoints in the OSS query service:

submit_query
read_query

How you do either of those tasks is up to you, and the Trino authentication + querying piece can certainly be implemented with Ibis. In fact, if you're up for contributing to the OSS query service and want to use Ibis, that would be great. Unfortunately we don't have full support for Trino at the moment.

Another thing I would add is that if you are running this in conjunction with the core DJ API, you should deploy the API with a SQL transpilation library so that the queries generated by DJ can always be transpiled correctly to the Trino dialect. This is done by running the server with this .env config:
SQL_TRANSPILATION_LIBRARY=sqlglot

Sounds good. Will have this tried by my team member very soon
On Wed, Jun 19, 2024, 12:58 AM Yian @.***> wrote:

Another thing I would add is that if you are running this in conjunction
with the core DJ API, you should deploy the API with a SQL transpilation
library so that the queries generated by DJ can always be transpiled
correctly to the Trino dialect. This is done by running the server with
this .env config:
SQL_TRANSPILATION_LIBRARY=sqlglot
—
Reply to this email directly, view it on GitHub
https://github.com/DataJunction/dj/issues/1064#issuecomment-2177744956,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGVA56SGWWLJVE2CJQB6Y4LZIEFW3AVCNFSM6AAAAABJRCFTH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXG42DIOJVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

One question I had (I posted in discussion section) ..how do you differ
from cube.dev I mean in terms of semantic later capabilities? Can it
connect (or rather planned to implement) ability to connect to BI platforms
like power bi, tableeau etc?
On Wed, Jun 19, 2024, 1:07 AM Krish C @.***> wrote:

Sounds good. Will have this tried by my team member very soon
On Wed, Jun 19, 2024, 12:58 AM Yian @.***> wrote:

Another thing I would add is that if you are running this in conjunction
with the core DJ API, you should deploy the API with a SQL transpilation
library so that the queries generated by DJ can always be transpiled
correctly to the Trino dialect. This is done by running the server with
this .env config:
SQL_TRANSPILATION_LIBRARY=sqlglot
—
Reply to this email directly, view it on GitHub
https://github.com/DataJunction/dj/issues/1064#issuecomment-2177744956,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGVA56SGWWLJVE2CJQB6Y4LZIEFW3AVCNFSM6AAAAABJRCFTH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXG42DIOJVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

The primary difference between our approach and cube.dev is that the latter is very cube-centric, so a lot of the dimensional modeling is done on a per-cube basis, and is hard to reuse outside of that cube (in a different cube). However, the approach DJ takes is that we store the entire dimensional graph of relationships between entities, so users should only need to model their data once, and it can be shareable across the business.
Another difference is that for cube.dev, the expectation is that any SQL transformations needed for data modeling have been done upstream. However, in our approach, we provide an optional SQL transformation layer (through the transform node), in case you need to do lightweight data transformations here. This can be useful for deeper lineage into metrics.
We do plan on implementing the ability to connect to other BI platforms. @betodealmeida previously worked on a connection to Superset, but we need some more work to revive that connection.

Thanks. So reg Trino, can we use trino to also be used for materialization through iceberg catalogs (HIVe) which we have (Trino Iceberg MV through Hive have capability for cache too)? Regarding materialization, what are automatically (on a schedule done) managed ? (i.e. what are are objects that are materialized). Any chance we can have different refresh schedules for different cubes

For generating of SQL for trino, any changes we need to make (if we want DJ to generate and then execute for input of metrics, filters and time grains). ?

For generating SQL for Trino, the only thing you would need is to set up the sql transpilation lib as I mentioned in  https://github.com/DataJunction/dj/issues/1064#issuecomment-2177744956
The core DJ API has support for configuring materialization, where you can set things on a schedule, and there are different materialization types (iceberg tables for transforms, iceberg + druid for cubes). However, you would again need to implement the appropriate endpoints on the query service in order for this to work.

Right. We need to configure the end-points to interact with Trino REST API. We don't use druid. What options exist as alternative for iceberg+druid?

@bazooka720 if you're interested, I think it would be great if you could join the community sync that's held every other Wednesday at 9am PT. I've created a google group to make it easier to find and get invited. https://groups.google.com/g/datajunction-community

Absolutely. Will join. Just one thing on this is regarding materialized views and trino. As of now this doesn't support automated Materialized Views of all Cube measures and source nodes using trino as the engine and into iceberg based tables?

Absolutely. Will join. Just one thing on this is regarding materialized views and trino. As of now this doesn't support automated Materialized Views of all Cube measures and source nodes using trino as the engine and into iceberg based tables?

Nope, at the moment there's no automated materialized views creation.


Add new ScanResult fields to results

Restore missing timestamp ScanResult field, and add the three new fields for >= Marshmallow:

centerFreq0
centerFreq1
channelWidth

If the Android version is < Marshmallow, the new fields will have a null value.
Also (obviously) adds the Android version number for use in the check.
Tested on Android 4.4.2, 5.0.1, 6.0, 7.0, 7.1.1.

Is there any chance on getting this pull request merged?

@degendra You can try email the maintainer, but it seems like development has stopped on this project. You can always fork the repo and build your own, though, as I did!


Change http status code on interceptor

I have a simple controller:
@Post("/user")
public void add(User user) {
 userDao.add(user);
 result.use(status()).created();
}

But there is a HibernateTransactionInterceptor that commits the database transaction at the end of the request. But if there is some error commiting the request, I want to change the response status:
@AroundCall
    public void intercept(SimpleInterceptorStack stack) {
        try {
            stack.next();
        } catch(Exception e) {
            logger.error("Unexpected exception", e);
            result.use(status()).internalServerError();
        }
    }

But the response was already commited and then the returned http code is the created(201) that was configured in the controller.
Is there any way to fix it? @Turini

I got it fixed here by overriding GsonSerializer class to avoid flushQuietly(writer); method to be called. This call commits the HttpServletResponse before it should be committed, because interceptors could still make changes in it.
@csokol @Turini let's change those classes to do not flush the HttpServletResponse's OutputStream?

@nykolaslima that sounds reasonable to me... i'm just not sure if it'll break any expected
behaviour. Can we just remove the flushQuietly call and everything will work just fine?

From the tests I've made everything works fine. I believe that flush is already called somewhere, maybe it should be called from application server and not from application code. @Turini

@nykolaslima, I guess overriding GsonSerializer only fixes the case in which you're using Results#json, right? Does it solve the issue with Result#status?

I guess it solves the Result#status problem too. Because the response isn't forced to flush in the GsonSerializer.

Huum, strange, why is Result#status related with json serialization?
On Mon, Dec 7, 2015 at 12:01 PM Nykolas Laurentino de Lima <
<EMAIL_ADDRESS>wrote:

I guess it solves the Result#status problem too. Because the response
isn't forced to flush in the GsonSerializer.
—
Reply to this email directly or view it on GitHub
https://github.com/caelum/vraptor4/issues/1035#issuecomment-162531372.

Sorry @csokol, you are right.
Just using #Result.status works fine. The problem is in flush.


ask

What is the version of pyg？
Can you tell the version of the package in the conda environment？

You can check them on the 'geometric.yaml' file.


Implements loading variable length packets from CSV

Purpose
Add support for loading variable length packets from CSV, resolving #115
Packet array shaped can be defined in the data type as uint(expand) for expanding fields or uint(OPMODE) for a reference type, where OPMODE is another field.
Changes to codebase

added some new example CSVs to load as variable length packets
renamed the existing CSVs to reflect the new "basic" versus "extended" nomenclature
added and used _parse_csv_array_shape to handle the more complicated array shape logic
added test for when _parse_csv_array_shape should fail
added test to confirm proper parsing of array_shape
added test to confirm variable length packets load from CSV
updated the documentation to reflect these changes
required pytest no be less than version 8.1.0

Todos

[x] resolve failing CI
[x] add test for failure cases to make codecov happy
[ ] unpin pytest version since it appears plugin issue is resolved with new release

Notes
I think I've implemented all the expected features. I haven't tested extensively, so I can add some more tests if you think it's appropriate. As always, I'm open to suggestions.

@ddasilva the CI failing seems to be because of the release of pytest 8.1.0 a few hours ago and plugins not having updated releases to match necessary changes, namely pytest-filter-subpackages(https://github.com/pytest-dev/pytest/issues/11779). You can see the last release of pytest-filter-subpackages was in 2022. It looks like a release is under consideration. The simplest solution for now is to not allow pytest 8.1.0 in the CI, but there may be better options.

@ddasilva the CI failing seems to be because of the release of pytest 8.1.0 a few hours ago and plugins not having updated releases to match necessary changes, namely pytest-filter-subpackages(pytest-dev/pytest#11779). You can see the last release of pytest-filter-subpackages was in 2022. It looks like a release is under consideration. The simplest solution for now is to not allow pytest 8.1.0 in the CI, but there may be better options.

Totally reasonable. Feel free to edit your branch to pin a version of pytest and repush.  It would be on this line:
https://github.com/CCSDSPy/ccsdspy/blob/main/pyproject.toml#L36

Can you write a couple examples in the top comment of this PR? I will send the PR around to some missions that would use this feature to get their feedback.

@ehsteve Feel free to comment

I pinged a few of our collaborators over email from Europa Clipper / MMS / Canadian Space Agency to get their thoughts on this new feature. Even if they don't have much to say, it will be good to raise their awareness!
Daniel

Thanks @jmbhughes !


About CompanyCruiserFix

https://thunderstore.io/c/lethal-company/p/DiFFoZ/CompanyCruiserFix
could not load this mod bc that mod load ahead of LLL

Thanks, fixed in v1.0.1


Mod2 VM Template

https://github.com/MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions/blob/c-release/Instructions/Labs/dotnet/Mod02/20532C_LAB_AK_02.md#task-2-create-a-virtual-machine
Visual Studio Community 2015 with Azure SDK 2.9 on Windows Server 2012 R2 is no longer available, we must now use the following version and update the instructions
Visual Studio Community 2015 Update 3 with Azure SDK 2.9 on Windows Server 2012 R2

Thanks @ramsamdam . Can you make a patch for that?

I have patched the ARM template but haven't done the instructions yet due to a US holiday. Will get to that as soon as I am able

From: Concrete Gannet<EMAIL_ADDRESS>Sent: Thursday, November 24, 2016 4:29:31 PM
To: MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions
Subject: Re: [MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions] Mod2 VM Template (#153)
Thanks @ramsamdamhttps://github.com/ramsamdam . Can you make a patch for that?

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftLearning/20532-DevelopingMicrosoftAzureSolutions/issues/153#issuecomment-262846686, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE1SiYPKg-8uBNNVpd0k5aS5a1Y4NyHBks5rBgG7gaJpZM4K79gq.


BUG: Waterfall feature names IndexError

Issue Description
When a shapley explainer is given an nxn feature matrix, the waterfall plot fails to be created because the feature names are not a list of the n feature names, but only the single feature at the sample position given.
The Explanation object has this code in __init__:
        if len(_compute_shape(feature_names)) == 1: # TODOsomeday: should always be an alias once slicer supports per-row aliases
            if len(values_shape) >= 1 and len(feature_names) == values_shape[0]:
                feature_names = Alias(list(feature_names), 0)
            elif len(values_shape) >= 2 and len(feature_names) == values_shape[1]:
                feature_names = Alias(list(feature_names), 1)

The Alias dim of the feature_names is set to 0 when the features and samples match which results in just the single feature "Feature_1" instead of the list of features "['Feature_1', 'Feature_2', 'Feature_x']". The Explanation object then saves the Slicer object in self._s which when the waterfall plot is created with just a single sample shap_explainer[0], __get_item__ is called and then the slice uses the dim from above to either select the index given (in this case 0) when dim=0, or slice(None, None, None) for dim=1.
Minimal Reproducible Example
import pandas as pd
import numpy as np
import shap
import xgboost

model = xgboost.XGBClassifier()
n_samples, n_features = 400, 30
df = pd.DataFrame(np.random.random((n_samples, n_features)), columns=[f"Feature_{i}" for i in range(n_features)])

model.fit(df, np.random.choice([0, 1], n_samples))

explainer = shap.TreeExplainer(model)
shap_explainer = explainer(df.sample(n_features))

shap.plots.waterfall(shap_explainer[0])

Traceback
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/luke/oxcan-fs/venv/lib/python3.10/site-packages/shap/plots/_waterfall.py", line 139, in waterfall
    yticklabels[rng[i]] = format_value(float(features[order[i]]), "%0.03f") + " = " + feature_names[order[i]]
IndexError: string index out of range

Expected Behavior
The slice should always get the full set of features when creating a waterfall plot.
Bug report checklist

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest release of shap.
[X] I have confirmed this bug exists on the master branch of shap.
[ ] I'd be interested in making a PR to fix this bug

Installed Versions
0.42.1

I cannot reproduce this. This works for me on the latest master.


Fix integration test: AADB2CIT.testSignIn()

https://github.com/Azure/azure-sdk-for-java/blob/859f357c4a8566f61c9cdb77dfcb4d0d136dfc23/sdk/spring/azure-spring-boot-test-aad-b2c/src/test/java/com/azure/test/aad/b2c/selenium/AADB2CIT.java#L42

Closing this issue because PR merged.


XD-2923 [Sprint: 47] [master + backport] Spark streaming module to bind pubsub consumer

Fix the spark streaming MessageBusReceiver to bind
to the pubsub consumer if the underlying input channel is of pub/sub.

Since this PR has already been merged into master a06668d2af0ac620672c46e63f992f6594312620, I will close this PR and re-issue one for 1.1.x. I have also pushed the fixes to the comments that were added recently fdcccd867c67eb71ef61a06fe6cc78be54660ad8


Community notes are missing the point of sarcasm.

Is your feature request related to a problem? Please describe.
Its annoying that when a tweet is clearly sarcastic (for example a football player is 41 years old -clearly old for football - and someone says "he is 59 years old 😅😅😅😅" from the point of community notes, its a lie but actually the intention of the tweeter is not lying, just joking.
Describe the solution you'd like
Maybe twitter can asks to the tweeter about the tone of the tweet by detecting the possibility of sarcasm with AI or something by checking if the tweet seems sarcastic, let the user set the intention, so that community notes can be written will be more accurate.
Describe alternatives you've considered
While rejecting a community note, and choosing "Other" in the list, a free text can be set and we can describe why we are rejecting a community note.
Additional context

Agree that sarcasm has its place in the world. This should not be limited to the English version of X (Second sentence is just banter).
I think the option below best fits in these cases:


Documentation for RichSuggestBox control

Docs for Toolkit PR #3650
What changes to the docs does this PR provide?

Add documentation for the new RichSuggestBox control.
PR Checklist
Please check if your PR fulfills the following requirements:

[x] Correctly picked the right branch to base the change off (dev for new features, master for typos/improvements)
[x] For new pages, used the provided template
[x] For new features, added an entry in the Table of Contents
[x] Ran against a spell and grammar checker
[x] Contains NO breaking changes

Other information

Docs Build status updates of commit 458350e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:warning:Warning
View
Details

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/controls/RichSuggestBox.md

Line 70, Column 130: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/dotnet/api/system.char.ispunctuation' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 119, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.autosuggestbox' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 120, Column 3: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.richeditbox' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 70, Column 130: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/dotnet/api/system.char.ispunctuation' will be broken in isolated environments. Replace with a relative link.
Line 119, Column 3: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.autosuggestbox' will be broken in isolated environments. Replace with a relative link.
Line 120, Column 3: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.richeditbox' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 248842a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:bulb:Suggestion
View
Details

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/controls/RichSuggestBox.md

Line 70, Column 130: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/dotnet/api/system.char.ispunctuation' will be broken in isolated environments. Replace with a relative link.
Line 119, Column 3: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/uwp/api/windows.ui.xaml.controls.autosuggestbox' will be broken in isolated environments. Replace with a relative link.
Line 120, Column 3: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/uwp/api/windows.ui.xaml.controls.richeditbox' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 50e615f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f36c5d9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 606e4af:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a86e7d6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 2031e70:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 65e9865:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 133f8f6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/RichSuggestBox.md
:white_check_mark:Succeeded
View

docs/resources/images/Controls/RichSuggestBox.gif
:white_check_mark:Succeeded
View

docs/toc.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Support custom CA

From: https://github.com/flutter/flutter/issues/35868#issuecomment-1399467971 Fixes #24

app-arm64-v8a-release.zip


Server crashing

Its allways another Entity, i sadly dont know why :C. But it seems to be Gobber, which causes that.
crash-2024-07-07_22.44.28-server.txt

That version of Gobber requires NeoForge 21.0.74 or higher due to a breaking change made by the Neo folks.

Ty! :D


Proposed edits

3 commits:

Citation for Moravec's Paradox wiki
slight change of words in beginning paragraph
re-word sentence in 4th paragraph to add context to the statement.

There is a typo in [ac18b2a](https://github.com/daveshap/PostLaborEconomics/pull/15/commits/ac18b2a61a6f3e60ac22fc7384d217c22f536c27): "effect" -> "affect".

Would you like me to re-do the pull request with the correct word of "affect"?  I checked the box for allowing edits by maintainers.

Made the new commit with fixes.


Disabling sdk feature

Issue #, if available:
Description of changes:
Added environment variable support to disable SDK feature.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

for anyone interested in testing this change, add this line to your go.mod:
replace github.com/aws/aws-xray-sdk-go => github.com/bhautikpip/aws-xray-sdk-go Disable-SDK

and then run:
go mod tidy


marcel-soln

I don't think this is quite right.  If you put in the same word for both the word and the string, it will return :no.


Handling dependencies properly

The project pulls in js files from https://cdn.jsdelivr.net/npm/ instead of using a local copy, so if that cdn is down e.g. because of a ddos attack, then the markdown won't work or the page will wait a lot for that js file. I would rather consider a module bundler like webpack or browserify or add the extra dependencies as script tags and check their existence instead of trying to reinventing the wheel and injecting them with your code. This is not just a little inconvenience, but a security issue.

Apart from loss of availability, do you see any other security issue occurring. Specifically, do you see a possible loss of confidentiality or loss of integrity? If so, would you please spell out the details of how such a security issue might be exploited?

@susam
The whole thing is a security issue. You cannot make the decision that our webpages must rely on this CDN service and hide the other dependencies from the package.json. This is a very bad default. At least NPM would warn about the vulnerabilities of these dependencies. Not to mention that a properly set content security policy will kill them when you try to load them with your code.
Another issue I found meanwhile that you override window.onload by renderOnLoad=true instead of registering an event listener with addEventListener. This can easily interfere with other js code running on a site.
It would be better to solve just a single thing instead of trying to write a module loader and deciding what the webpage does on load. An example should look something like this without a module bundler like webpack, though I have no idea how to load these dependencies properly:
<!DOCTYPE html>
<html lang="en">
<title>Notes on Euler's Identity</title>
<script<EMAIL_ADDRESS><script src="https://cdn.jsdelivr.net/npm/mathjax@3"></script>
<script<EMAIL_ADDRESS><script>
window.onload = function () {
    texme.renderPage({
        commonmark: commonmarkInstance,
        mathjax: mathjaxInstance
    });
}
</script>
<textarea>

# Euler's Identity

In mathematics, **Euler's identity** is the equality
$$ e^{i \pi} + 1 = 0. $$

## Explanation

Euler's identity is a special case of Euler's formula from complex
analysis, which states that for any real number $ x $,
$$ e^{ix} = \cos x + i \sin x. $$

</textarea>

The whole thing is a security issue.

Please provide specific examples. What exactly is a security issue? How does a user get compromised?

You cannot make the decision that

I am not making any decisions for you. This is a free and open source project provided "as is", without warranty of any kind, express or implied. You are free to use this project as-is or fork it and modify it to suit your needs. See LICENSE.md for more details.

our webpages must rely on this CDN service

Your webpages can load the dependencies from any CDN URL or even your own web server. The CDN URLs are configurable. See configuration options commonmarkURL and MathJaxURL in the Configuration Options section.

and hide the other dependencies from the package.json.

When this package is used in an NPM-based project as a library, that is, as an NPM dependency, no resource from any external CDN is pulled in. When the caller calls texme.render(), this function merely masks all LaTeX snippets, renders Markdown, and then unmasks the LaTeX snippets. The only external library that it depends on then is commonmark and that is spelled out in package.json (see package.json#L24), so commonmark is pulled in as a dependency as part of npm install, not via CDN. Also, see Use TeXMe as a Library for more details.
When you use TeXMe in a web page, yes, it pulls in dependencies from CDN. That is because TeXMe caters to users who want to write standalone self-rendering HTML pages with minimal markup. The code example you have provided in your comment is not a problem TeXMe is trying to solve.

Another issue I found meanwhile that you override window.onload by renderOnLoad=true instead of registering an event listener with addEventListener.

This is true only for the primary and intended usage of TeXMe, that is, self-rendering documents written as per the Get Started guide. For other use cases where someone is loading TeXMe in their page which contains other JavaScript code that TeXMe might conflict with, skip automatic rendering on load with window.texme = { renderOnLoad: false }. See Skip Automatic Rendering on Load for details.

It would be better to solve just a single thing instead of trying to write a module loader and deciding what the webpage does on load.

Since TeXMe was created to offer a way of writing standalone HTML files with Markdown + LaTeX + minimal HTML markup that starts rendering itself as soon as it loads, TeXMe must decide what the web page does on load.

@susam The things I mentioned are security basics. If you don't understand them, then I think I give up and use something else.

The last comment from @inf3rno has been deleted and this thread has been locked. Hostility of any form will not be tolerated here. If there is a genuine security issue, please report it with specific technical details and the exact steps to reproduce the security issue.
This is a free and open-source project developed to satisfy first and foremost my own requirements. In addition to that this project has been made open-source, so that others who find this useful can also use or even modify it for their purpose for free. Users and collaborators who report issues and do so with proper etiquette are very welcome.


Design an unambiguous notation for isomiRs species relative to a given canonical miRNA

Provided that we won't be working with an isomiR annotation file the naming has to be done as we go by. In addition, names can not be pre-defined due to the larger amount of possible isomiRs we can have; only considering isomiRs with a shift of $n$ leads to have $(2n + 1)^2$ possible isomiRs and not all of
them would be seen.
To do the labeling on-the-spot, a naming strategy is needed. The name must include the both 5p and 3p  shifts and the mismatches ad indels found.
An idea would be to use a notation that borrows from the MD string notations.

MIND that the MD string does not include a notation for insertions so it has to be defined - a suggestion is to use @ and the insertion sequence i.e. @GT.

Think a notation that covers all angles and makes easier for users to find a given isomiR in the counting table.

The format for the isomiRs notation will be name-canonical(s)|5p-shift|3p-shift|CIGAR|MD


[$500] Mweb - BA - When user selects "State", the drop down list gets scrolled

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.6-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/
Tap profile icon
Tap Workspaces
Tap on a Workspace
Tap Bank account
Tap connect manually
Enter all fields and tap next
Select a state
Tap on state again and select any other state from the list

Expected Result:
When user selects "State", the drop down list must not be scrolled
Actual Result:
When user selects "State", the drop down list gets scrolled
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ecf2ae5d-99f8-4eca-b0c7-8ba6bce5b69b

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b6d7a0421d65ccee
Upwork Job ID:<PHONE_NUMBER>339785216
Last Price Increase: 2023-12-12

I don't understand the issue since there is no drop down menu for selecting state. In the video, the scrolling occurs due to the user scrolling up, right?

I don't think this is a bug or problem as it is useful as of UX perspective.

I agree, I don't think this is a bug - there's a search at the top of the page when selecting a state so the user could search for a different state if they don't see it in the drop-down. Why would it help to have the list start over once you've selected a state? Closing without action.

Hi @bernhardoj thanks for the information. I'm still not sure what the bug is. Here's the video of what I see.
Maybe the "issue" is that there are states listed above the one selected?
https://github.com/Expensify/App/assets/51066321/20be13ba-ad52-4087-970a-4605ee3e013e
Where do you see a country selection that I can test?

Ah okay, I do see that it looks like the state scroll to the top once a state is selected - thanks for pointing that out @bernhardoj
However, I don't think that is something we need to focus on fixing. Do you see any reason why that would impact the use of the product? It's really hard to even notice and I don't think it deters from the functionality but I'm not an engineer so maybe it's doing something else on the backend?
@eVoloshchak or @bernhardoj why should this be fixed?

Okay sounds good - asking the team for their thoughts!

I think this could be part of Wave 6 so I'm just checking with the team to see what our workflow should be to associate the bug with a wave - https://expensify.slack.com/archives/C01SKUP7QR0/p1702404266022039?thread_ts=1701355181.491179&cid=C01SKUP7QR0

Hi @greg-schroeder! I added this to the Wave 6 project because I think the issue could be addressed with those changes. I think this is a low-priority fix (as it's very difficult to catch the issue from the user side) but it is still a UX issue. Let me know your thoughts. Thank you!!

Based on this convo in Slack about this bug - I'm moving this from Wave 6 to Wave 9 - https://expensify.slack.com/archives/C01SKUP7QR0/p1702490762698629?thread_ts=1702322692.823169&cid=C01SKUP7QR0

Added this GH to be evaluated as part of Wave 9 - asking the team if this should be moved to weekly - https://expensify.slack.com/archives/C01SKUP7QR0/p1702585175582119?thread_ts=1702341886.807759&cid=C01SKUP7QR0

nope - keeping this daily

I think we're good to review these proposals @eVoloshchak! let me know if you want to see more!

@eVoloshchak can you review the provided proposals and let me know if you'd like to see more?

@bernhardoj, I can still reproduce the issue when testing your proposal, could you double-check that please?
https://github.com/Expensify/App/assets/9059945/120b8b9b-fc97-476b-bfdc-2ee7380b7f87

It looks like we're discussing proposals.
@eVoloshchak not sure if you have a chance to look at this - https://github.com/Expensify/App/issues/32305#issuecomment-1868195001

@neonbhai's proposal looks good to me.
There's no need to scroll the list on selection if user can select only a single item
🎀👀🎀 C+ reviewed!

Should we make this its own property, like scrollToTopOnSelect or something?

I'm going ooo this week so going to add a buddy to this to monitor.
Status - we're reviewing - https://github.com/Expensify/App/issues/32305#issuecomment-1876012164

Thinking we might want this behavior at some point for multi select lists. https://github.com/Expensify/App/issues/32305#issuecomment-1877735649
@eVoloshchak @neonbhai

Should we make this its own property, like scrollToTopOnSelect or something?

@rlinoz, yeah, I think it's a good suggestion

Thanks all, assigning @neonbhai!

The solution here did caused a regression and got reverted as pointed out here.
@neonbhai @eVoloshchak

@neonbhai, looks like this has caused a regression (https://github.com/Expensify/App/issues/35374)
How can we resolve it and fix this issue?

One thing that seems to work is that Pushing State Selector to a Page

Those 3 bugs look pretty bad, so if can resolve those while resolving this issue - that would be great.
But I think first we need to figure out why Pushing State Selector to a Page does resolve our issue
We need to know the root cause of this. Applying a workaround would work in this case, but the bug could potentially come back in case we refactor those pages (use different navigation lib, use modals, etc.) in the future
cc: @neonbhai

just checking in here, are we working on a regression? Or can I pay this out?

Hey @neonbhai were you able to move forward with this?

Bumping ^
@neonbhai

Can't reproduce in staging either.

Ah okay, if it's not reproducible, I assume that means we can pay this out?
Here's the payment summary here - it notes the 50% regression penalty - let me know if there's something different with that.
Also does this need a regression test @eVoloshchak?

Ah okay, if it's not reproducible, I assume that means we can pay this out?

@Christinadobrzyn, this was fixed, but not by this PR (since it was reverted)
I don't think we're eligible for any payment in this case

Ah okay, thank you for confirming @eVoloshchak! I will close this but let me know if I'm missing anything!


RGB+D streams reading is around 6 FPS, could this be faster?

I am using the example program "save-to-disk" to read the RGB frame and DEPTH frame at the same time, but the reading speed is too slow.
Is there anyway I could read data stream faster?

Hi @YuzheHao
You can read the data of the sensor at 30 and 60 frames per second (for depth exclusively it goes even higher). What you do with the data after receiving it is up to you and your application. Save to disk can be bottle-necked by the PNG writer or disk write speed (I would still check that you are building the example and the SDK with optimizations enabled)
One faster way to record data to disk is using the recorder (please check the rs-playback-record example). Even then, in order to handle the full bandwidth of the camera you need an SSD drive, on a regular hard-drive you will loose some frames (just based on the disk write speeds vs frame sizes)

Creating new threads to write png may help because IO operations are really time consuming. Something like:
std::vector<std::thread> threads;
while(1)
{
   //get frame
  threads.emplace_back(...);    //... refers to the write function & data
}
for (auto&& t : threads) t.join();

1. Saving method in rs-save-to-disk
The saving method in my example program is this:
stbi_write_png(png_file.str().c_str(), vf.get_width(), vf.get_height(),
               vf.get_bytes_per_pixel(), vf.get_data(), vf.get_stride_in_bytes());

Is this taking too much time that makes the later frames could not be reviced on time?
2. Try for rs-record-playback
And I try to run "rs-record-playback.cpp" as @dorodnic said, but it failed and the debug report is like below. some reference like gluPerspective,gluLookAt,gluPerspective could not be found. Whether this means I still have some package that forget to intall?
====================[ Build | rs-record-playback | Debug ]======================
/work/yuzhe/apps/clion-2019.3.1/bin/cmake/linux/bin/cmake --build /work/yuzhe/librealsense/cmake-build-debug --target rs-record-playback -- -j 4
[  1%] Built target fw
[ 12%] Built target glfw
[ 22%] Built target tm
[ 35%] Built target realsense-file
[ 96%] Built target realsense2
[ 98%] Linking CXX executable rs-record-playback
CMakeFiles/rs-record-playback.dir/rs-record-playback.cpp.o: In function `draw_pointcloud(float, float, glfw_state&, rs2::points&)':
/work/yuzhe/librealsense/examples/record-playback/../example.hpp:773: undefined reference to `gluPerspective'
/work/yuzhe/librealsense/examples/record-playback/../example.hpp:777: undefined reference to `gluLookAt'
CMakeFiles/rs-record-playback.dir/rs-record-playback.cpp.o: In function `draw_pointcloud_wrt_world(float, float, glfw_state&, rs2::points&, rs2_pose&, float*, std::vector<rs2_vector, std::allocator<rs2_vector> >&)':
/work/yuzhe/librealsense/examples/record-playback/../example.hpp:839: undefined reference to `gluPerspective'
collect2: error: ld returned 1 exit status
examples/record-playback/CMakeFiles/rs-record-playback.dir/build.make:134: recipe for target 'examples/record-playback/rs-record-playback' failed
make[3]: *** [examples/record-playback/rs-record-playback] Error 1
CMakeFiles/Makefile2:1126: recipe for target 'examples/record-playback/CMakeFiles/rs-record-playback.dir/all' failed
make[2]: *** [examples/record-playback/CMakeFiles/rs-record-playback.dir/all] Error 2
CMakeFiles/Makefile2:1133: recipe for target 'examples/record-playback/CMakeFiles/rs-record-playback.dir/rule' failed
make[1]: *** [examples/record-playback/CMakeFiles/rs-record-playback.dir/rule] Error 2
Makefile:424: recipe for target 'rs-record-playback' failed
make: *** [rs-record-playback] Error 2

3. Another trying for rs-record
I think this program also doesn't work well, cause I see couldn't any windows and GUI while it is runing. Just a sentence is telling me the recording time in console.
Recording t = 9s
Finished

Process finished with exit code 15

Is this normal?


How can I use it with Rx Java ?

I am trying to use the api client with rx java but stucked. Can you help?

You would need to write Rx java wrappers around the google api client. What particular example would you like to know? Maybe I can help you out

@Laimiux   Im trying to use rxjs to make Gapi calls thats a "snap" of my code can u gimme some help?
function listData(){
    Rx.Observable.fromPromise(list()).subscribe(
     function(x){
       console.log(x);
     },
     function(err){
       console.log(err);
     },
    function(){
      console.log("completed");
    });

    function list(){
       gapi.client.****.****.list().execute();
    }

@PedroDava I'm not familiar with the javascript side of rx and google apis, so I'm not sure if I can be helpful.
From quick look into it, it seems that google api provides something similar to a promise, but not quite.
https://developers.google.com/api-client-library/javascript/reference/referencedocs#gapiclientrequest
You might need to use Rx.Observable.create
https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/create.md
where you will create google api request and delegate the response to observer passed in the create method

@Laimiux  Managed to  make the call using rxjs. thnk you
Rx.Observable.fromPromise(
function (){
return   gapi.client...list()
.then(
function(response){
return response;
},
function(err){
return err;
});
}).subscribe(
function(x){
console.log(x);
},
function(err){
console.log(err);
},
    function()
    {console.log("Success");
    });

callCinemas:function(){
    Rx.Observable.fromPromise(
      function (){
        return   gapi.client.***.***.list()
          .then(
          function(response){
            return response;
          },
          function(err){
            return err;
        });
    })
      .subscribe(
    function(x){
      console.log(x);
    },
    function(err){
      console.log(err);
    },

    function()
    {console.log("Success");
    });

  },

@Laimiux  thnk you managed to make the request work....

It looks like a member of our great community answered your questions. Thanks Community! Please feel free to reopen if you have any more questions.


auto-complete shows up when typing in comments (PY and TS)

Closing in favor of https://github.com/microsoft/pxt-microbit/issues/4264


The integration test may not be following the pattern of all the others #1145

I am reviewing this

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

tests/integration/components/sl-span-test.js, line 14 [r1] (raw file):
We do not need to include this since we have decided to only test positive assertions.

tests/integration/components/sl-span-test.js, line 20 [r1] (raw file):
We do not need to include this since we have decided to only test positive assertions.

tests/integration/components/sl-span-test.js, line 26 [r1] (raw file):
We do not need to include this since we have decided to only test positive assertions.

tests/integration/components/sl-span-test.js, line 34 [r1] (raw file):
Lets change this message to: '"value" defaults to null'

tests/integration/components/sl-span-test.js, line 40 [r1] (raw file):
Lets change this message to: '"tagName" property defaults to "span"'
Notice that the word "property" is misspelled above.

tests/integration/components/sl-span-test.js, line 51 [r1] (raw file):
Lets update this to a more descriptive message. Maybe, '"value' text is displayed'

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.

tests/integration/components/sl-span-test.js, line 14 [r1] (raw file):
Done.

tests/integration/components/sl-span-test.js, line 20 [r1] (raw file):
Done.

tests/integration/components/sl-span-test.js, line 26 [r1] (raw file):
Done.

tests/integration/components/sl-span-test.js, line 34 [r1] (raw file):
Done.

tests/integration/components/sl-span-test.js, line 40 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.

tests/integration/components/sl-span-test.js, line 51 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

@notmessenger: this is ready to merge

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

tests/integration/components/sl-span-test.js, line 19 [r2] (raw file):
This should be in the unit test case

Comments from the review on Reviewable.io

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

tests/integration/components/sl-span-test.js, line 19 [r2] (raw file):
Done.

Comments from the review on Reviewable.io

@notmessenger: work on this is completed.

Comments from the review on Reviewable.io

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.

Comments from the review on Reviewable.io

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from the review on Reviewable.io


[TCK Challenge]: ee.jakarta.tck.data.standalone.persistence.PersistenceEntityTests in non-standalone mode

Specification
tck guide
Assertion
tck setup issue
TCK Version
SNAPSHOT (Locally built)
Implementation being tested
WildFly
Challenge Scenario
Claims that a test is not portable or depends on a particular implementation.
Full Description
When running in a non-standalone mode in some EE profile, the standalone tests are still deployed as JARs rather than WARs. There is no universal support for this especially when EE components like entities are being deployed. Most of the tests just happen to work because WildFly can deploy them as service jars, but deploying the PersistenceEntityTests does not. This needs a persistence.xml descriptor and WildFly will not process a bare jar as a potential persistence unit deployment.
Additional Context
The deploy method on PersistenceEntityTests should only return a JavaArchive when running in standalone mode. In any non-standalone mode it should return a WebArchive. It is possible that all @Standalone annotated tests should use this approach.
Is there an existing challenge for this?

[X] I have searched the existing issues

There is a simple fix for this, update the createDeployment() method to:
@Standalone
@Persistence
public class PersistenceEntityTests {

    @Deployment
    public static Archive<?> createDeployment() {
        if(TestPropertyUtility.isStandalone()) {
            return ShrinkWrap.create(JavaArchive.class).addClasses(Product.class, Catalog.class);
        } else {
            return ShrinkWrap.create(WebArchive.class).addClasses(Product.class, Catalog.class);
        }
    }
 ...

and the test pass on WildFly:
starksm@Scotts-Mac-Studio runner-web % mvn test -Dtest=ee.jakarta.tck.data.standalone.persistence.PersistenceEntityTests
[INFO] Scanning for projects...
[INFO]
[INFO] -------------< org.hibernate:hiberate-data-tck-web-runner >-------------
[INFO] Building Hibernate Jakarta Data TCK Web Runner 1.0
...
[INFO] Results:
[INFO]
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  8.352 s
[INFO] Finished at: 2024-04-17T02:52:29-05:00
[INFO] ------------------------------------------------------------------------


OSF V2 API: Support for JSON-API 1.0 Compound Documents

It seems that the OSF v2 API doesn't quite support the idea of JSON-API compound documents:

To reduce the number of HTTP requests, servers MAY allow responses that include related resources along with the requested primary resources. Such responses are called compound documents.
In a compound document, all included resources MUST be represented as an array of resource objects in a top-level included member.
Compound documents require full linkage, meaning that every included resource MUST be identified by at least one resource identifier object in the same document. These resource identifier objects could either be primary data or represent resource linkage contained within primary or included resources.

The OSF v2 embed HTTP query parameter seems to support the spirit of compound documents, but not the letter.  For example, the embeds object seems to be an analog of the JSON-API 1.0 includedobject, but the embeds object occurs at the wrong level in the response document.  As a consequence, linking between included data and relationships doesn't occur as specified in JSON-API 1.0.
If the OSF v2 API were to support compound documents as specified by the JSON-API, existing clients like the JSON-API Converter would be able to consume the OSF v2 API.

We've wrapped this into an existing Jira issue for resolution after the JSON API team finalizes their extension spec.


Cannot install from source https://git.apache.org/ is down

Same issue like here https://github.com/kubernetes/minikube/issues/5245
Adding that line fixed it for me

Hi,
Thanks! Fixed in v2.5.0


Pgadmin 6.11

Description of changes
Update pgadmin4 to 6.11.
Release Notes
Noteworthy changes: Added capability to deploy PostgreSQL servers on Microsoft Azure.
Also, since the update of postgresql from 14.3 -> 14.4 one of the regression sql test fails for pgadmin. This is unrelated to this update. A bugreport has been filed upstream and meanwhile the test is skipped for now. AFAIK, this should not impact any performance or functionality.
This PR also includes the fix of the hash of ua-parser from my PR #179865. pgadmin4 depends on it and will not build otherwise.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please rebase

@dotlambda rebased :+1:

Maybe I'm holding it wrong but the test fails to evaluate:
[nix-shell:~/.cache/nixpkgs-review/pr-179994]$ nix-build nixpkgs/nixos/tests/pgadmin4.nix
error: value is a list while a set was expected

       at /home/symphorien/.cache/nixpkgs-review/pr-179994/nixpkgs/nixos/tests/pgadmin4.nix:49:15:

           48|               # test suite package requirements
           49|               pythonPackages.testscenarios
             |               ^
           50|               pythonPackages.selenium
(use '--show-trace' to show detailed location information)

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 179994 run on x86_64-linux 1

1 package built:

pgadmin4

thank you for your explanation


Question about dataset_generation for ARM, MIPS architecture

In get_calling_context.py (line 68), the code use 'CALL' to judge function calls is only suitable for x86 and x64. In ARM, the instructions of function calls are bl, blx, bx, and in MIPS, the instructions of function calls are jal

Thanks for pointing out this problem. This should be fixed in: https://github.com/OSUSecLab/SymLM/commit/34d86a5aff431629ff838e6e6478caece1ee399c


Ensure function pointers passed to flecs are marked with UnmangedCallersOnly

An application sometimes crashes with signal SIGSEGV: address not mapped to object due to passing managed function pointers to flecs. This crash happens occasionally in normal applications but will instantly crash when compiled with NativeAOT. Function pointers passed to flecs must be marked with the UnmangedCallersOnly attribute.
The UnmangedCallersOnly attribute cannot be added to generic methods, so a workaround is needed to allow system callbacks and type hooks to be invoked. The current work-around I'm looking into is to store function pointers to generic methods in the binding context and use an UnmangedCallersOnly method to invoke it from a managed environment.
public static unsafe class Program
{
    // This is passed to flecs
    [UnmanagedCallersOnly]
    public static void InvokeManagedPointer(ecs_iter_t* iter)
    {
        delegate*<ecs_iter_t*, void> callback = (delegate*<ecs_iter_t*, void>)iter->binding_ctx;
        callback(iter);
    }

    // We'll store this method's function pointer in the binding context.
    public static void GenericMethod<T>(ecs_iter_t* iter)
    {
        // ...
    }
}

Fixed by #54


Improves contribution guidance

Resolves #202.

I believe that with https://github.com/jenkins-infra/plugin-health-scoring/pull/203/commits/fa9acb06e42b203536fa5c3fd3affe315b5f4bc9 I'm answering #199.


[FX-4635] Pass data-private to some components manually

[FX-NNNN]
Description
Some components pass {...rest} to a particular DOM element, however data-private sometimes has to be set for different DOM elements (for example, for Checkbox, label has to be private, not the checkbox itself).
This PR adresses most problems we found.
How to test

Temploy
Tests should pass
Code should look good, attributes should be passed to proper elements

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers


[Unity] Relax dataflow oattern language (matching)

The dataflow pattern language for Relax (originally from https://github.com/tlc-pack/relax/pull/163).
The implementation splits patterns into two parts:

Match an Expression: match an expression syntactically (MatchExprPattern, i.e., DFPatternMatcher);
Match a Graph: match a graph (cross multiple VarBinding) topologically (MatchGraphPattern);

Credit also given to relay pattern lang authors and reviewers of https://github.com/tlc-pack/relax/pull/163.
cc: @YuchenJin

When testing pytest tests/python/relax/test_dataflow_pattern.py, it throws a warning like "DeprecationWarning: T.var is deprecated, use T.{dtype} instead". So seems it's better to update the test-case somehow?

When testing pytest tests/python/relax/test_dataflow_pattern.py, it throws a warning like "DeprecationWarning: T.var is deprecated, use T.{dtype} instead". So seems it's better to update the test-case somehow?

Yes, updating the test case would be great!

Thanks @ganler . please fix the lint error


The application panicked (crashed).

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (477b345 2023-12-18T00:22:09.434601489Z)
What command(s) is the bug in?
forge test, forge clean, forge update, and maybe more
Operating System
Windows
Describe the bug
Problem
When attempting to execute forge test on my project, an unexpected error occurred, resulting in the following messages:
The application panicked (crashed).
Message:  failed to extract foundry config:
foundry.toml error: Input/output error (os error 5)
 in foundry.toml TOML file

Location: crates/config/src/lib.rs:465

This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
Aborted

Additionally, when including RUST_BACKTRACE=FULL, the extended result is:
The application panicked (crashed).
Message:  failed to extract foundry config:
foundry.toml error: Input/output error (os error 5)
 in foundry.toml TOML file

Location: crates/config/src/lib.rs:465

This is a bug. Consider reporting it at https://github.com/foundry-rs/foundry

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __libc_start_main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
Aborted

Even after executing forge clean and forge update, the issue persists. Furthermore, when navigating to other projects, the same error messages continue to appear. I am currently using Windows 11 and running Foundry with WSL.

hmm, could you share your foundry.toml file?

Here is my foundry.toml
[profile.default]
src = 'src'
out = 'out'
libs = ['lib']
solc_version = "0.8.20"
optimizer = true
optimizer_runs = 200
fs_permissions = [{ access = "read", path = "./out"}]

ignored_error_codes = ["license", "unused-param", "unused-var"]

[invariant]
runs = 64
depth = 64
fail_on_revert = true

[fmt]
line_length = 80

# See more config options https://github.com/foundry-rs/foundry/tree/master/config

Additionally, I needed to install Foundry from scratch since I couldn't really do anything. Now it works well, though.

Interesting, so, confirming a reinstall fixed the issue? @rasyidred

@Evalir Yes, a reinstall fixed the issue. Unfortunately, however, I couldn't replicate the error.

Let's close for now—this could've been some installation error that might not be worth tracking down. If this appears again we'll reopen


Release/v4.0

-------------- components/spi_flash/include/esp_flash_spi_init.h --------------
index 4a26a4fd1..075b8f786 100644
@@ -17,6 +17,10 @@
#include "hal/spi_types.h"
#include "esp_flash.h"
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/// Configurations for the SPI Flash to init
typedef struct {
spi_host_device_t host_id;      ///< Bus to use
@@ -53,3 +57,6 @@ esp_err_t spi_bus_add_flash_device(esp_flash_t **out_chip, const esp_flash_spi_d
*/
esp_err_t spi_bus_remove_flash_device(esp_flash_t *chip);
+#ifdef __cplusplus
+}
+#endif

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 15 committers have signed the CLA.:white_check_mark: mahavirj:white_check_mark: dobairoland:white_check_mark: projectgus:white_check_mark: X-Ryl669:white_check_mark: Dazza0:white_check_mark: igrr:x: KonstantinKondrashov:x: jack0c:x: ganeshlandge:x: dhrishi:x: david-cermak:x: prasad-alatkar:x: suda-morris:x: lly:x: ESP-Mariuslly seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


The cvat server will be connected  failed after a while, why this happen?

when start the cvat by docker-compose,  the localhost:8080  was working in the beginning , but after a while,  it mat cant connect the server in to the gui, but the  Control panel(admin page) is working fine.  every time i want to use cvat，I need to docker down and restart cvat server.  I want to know the solutions

Please, fill the issue template and attach logs. Without them it impossible to make any suggestions.


some error

PhaseScriptExecution [CP]\ Check\ Pods\ Manifest.lock /Users/lidongbo/Library/Developer/Xcode/DerivedData/WorkbenchApp-dgtjoqzlxpktrcecqklbgccrmkoj/Build/Intermediates.noindex/RCTBaiduMap.build/Debug-iphonesimulator/RCTBaiduMap.build/Script-F94669FC245B52F58812BA9A.sh (in target 'RCTBaiduMap' from project 'RCTBaiduMap')
cd /Users/lidongbo/WorkBentch/ReactNative/sinosig/workbench-app/node_modules/react-native-baidu-map/ios
/bin/sh -c /Users/lidongbo/Library/Developer/Xcode/DerivedData/WorkbenchApp-dgtjoqzlxpktrcecqklbgccrmkoj/Build/Intermediates.noindex/RCTBaiduMap.build/Debug-iphonesimulator/RCTBaiduMap.build/Script-F94669FC245B52F58812BA9A.sh
diff: /Podfile.lock: No such file or directory
diff: /Manifest.lock: No such file or directory
error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.

老版本参考 https://github.com/lovebing/react-native-baidu-map-examples 中的 v59


Fix two bitReader read bugs.

Fix read bug where stringbuilder object is returned instead of string. Fix bug where check for if type is a IBitWritable failed and placed check for is IBitWritable last in the if chain.

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master    #121   +/-   ##
======================================
  Coverage    8.54%   8.54%
======================================
  Files          48      48
  Lines        8082    8082
  Branches     1254    1254
======================================
  Hits          691     691
  Misses       7333    7333
  Partials       58      58

Impacted Files
Coverage Δ

...PI/NetworkingManagerComponents/Binary/BitReader.cs
40.56% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336bed4...94f1241. Read the comment docs.


UCO-415 Database Record Representation

Addresses UCO-415 by adding database representation.
Coordination

[x] Pull Request is against correct branch
[ ] Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed.
[ ] CI passes in (CASE/UCO) feature branch
[ ] CI passes in UCO current unstable branch (merge-commit)
[ ] CI passes in CASE current unstable branch tracking UCO's unstable as submodule (merge-commit)
[ ] Impact on SHACL validation reviewed for CASE-Examples
[ ] Impact on SHACL validation remediated for CASE-Examples
[ ] Impact on SHACL validation reviewed for casework.github.io
[ ] Impact on SHACL validation remediated for casework.github.io
[ ] Milestone linked
[ ] Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

Converting to draft until Solutions Approval is logged.


Docs 6399 Azure Service Bus Timeout Issue

Closing because it looks like a ton of files were pulled in.


SyntaxError: Missing parentheses in call to 'print

Hey,
after recent upgrade from 2.0.3 to 2.0.6 I'm recievening this error message:
[user@localhost ~]$ ptc2
Traceback (most recent call last):
File "/usr/bin/ptc2", line 9, in
load_entry_point('PTCAccount2==2.0.6', 'console_scripts', 'ptc2')()
File "/usr/lib/python3.4/site-packages/pkg_resources/init.py", line 558, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python3.4/site-packages/pkg_resources/init.py", line 2682, in load_entry_point
return ep.load()
File "/usr/lib/python3.4/site-packages/pkg_resources/init.py", line 2355, in load
return self.resolve()
File "/usr/lib/python3.4/site-packages/pkg_resources/init.py", line 2361, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/lib/python3.4/site-packages/ptcaccount2/console.py", line 83
print "Appended to file accounts.txt"
^
SyntaxError: Missing parentheses in call to 'print'
[user@localhost ~]$
sapphire

#27 should fix this. Until it's merged you could just fix it yourself, by opening console.py and editing line 83:
replace print "Appended to file accounts.txt"
with
print("Appended to file accounts.txt")

Hello,
first of all, I'd like to thanks for such a quick response.
[user@localhost ptcaccount2]$ ptc2
Traceback (most recent call last):
File "/usr/bin/ptc2", line 9, in
load_entry_point('PTCAccount2==2.0.6', 'console_scripts', 'ptc2')()
File "/usr/lib/python3.4/site-packages/ptcaccount2/console.py", line 60, in entry
if len(args.email) > 75:
TypeError: object of type 'NoneType' has no len()
[sapphire@localhost ptcaccount2]$ sudo nano console.py
[sapphire@localhost ptcaccount2]$ ptc2 -h
usage: ptc2 [-h] [-u USERNAME] [-p PASSWORD] [-e EMAIL] [-b BIRTHDAY]
[-m MULTIPLE] [--compact] [--tofile] [--email-tag]
Is it correct here? https://github.com/Kitryn/PTCAccount2/commit/573195ce3d68fb46c7698b16c405b6d81782bb18
It doesnt even work in python 2.
Is it now mandatory to specify email adress?
Thanks.
sapphire

Yeah looks like the console entry has an error there. Internally it's still possible to use a random address, I'll look into it tomorrow :)
Though I would recommend using a real email address (and activate the "email tag", if you're creating multiple accounts) because the PTC accounts will be sea deaktivated after 2 days if you don't click the link.

Thanks @diveflo


Single select problem

(Required) Version Number:
8.0.2
Description
it's possible to cancel a single select in JTACMonthView？I found not API to support this. pls help, thx very much!

calendarView.DeselectDate(...)
calendarView.DeselectAll()

It's worked!  thank you for your help


Better support protobuf's ByteString in ByteArray.

The ByteArray type uses protobuf's ByteString under the hood, but doesn't allow an outside user to turn a ByteString into a ByteArray (or vice versa) without making an explicit copy. Given that both ByteString and ByteArray are immutable, I can't see a reason why this should not be possible. For example, a ByteArray.wrap(ByteString) and ByteArray.asByteString() method seem appropriate. Those would come in very handy when using the client libraries within a gRPC service.
Could someone please explain why this is the case? If there is no reason, I would be happy to open a PR. Thanks!
P.S. I did notice that the class is non-final and by subclassing one can expose the protected constructor and getByteString() method, but that seems silly.

@vkedia , what do you think?

This has been added to our feature backlog: https://github.com/GoogleCloudPlatform/google-cloud-java/wiki/Feature-backlog . This issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.


GdxSetup: Update generated main class to look more modern

The project that is generated by GdxSetup looks quite dated with its bright red background and the pixelated Bad Logic Games logo.
I updated it to make it look more modern.
Before:

After:

Could define position on one line as float imgPosX, imgPosY, though I'm not saying you should. Since then we get into the weeds of "oh but what about access modifiers" and all that. Speaking of which...
If we're doing this, as much as I love how iconic the eye-bleeding red is, I'm really tempted to ScreenViewport it up to stay centred rather than stretch on resize. Even wrapping it as an  Image and tossing it in a Stage if we're feeling rambunctious, in which case an action can be applied to give it some movement.
If MyGdxGame extends Game, the code can go in a ScreenAdapter, giving the dispose method a purpose (since you conceivably might want to dispose a screen; never found reason to dispose at the application level since resources will be freed by the OS). You can see why I've never made a pull request for that myself - the scope just keeps increasing.

I was thinking about doing something similiar as Phaser which has the logo bouncing around with a particle effect.

You can just paste the hello world code into an html to see for youself: https://phaser.io/tutorials/getting-started-phaser3/part5
But that would require a bit more code so I opted for the simpler solution that is still a big improvement imo.

Vector2 is safe to construct before create().

Sounds good. I changed it.

Can alternatively use a Sprite if storing position separately is too messy. This is not a suggestion, just a thought - I don't know how much you've libGDX'd before.
// create
img = new Sprite(new Texture("logo_dark.png"));
img.setCenterX(Gdx.graphics.getWidth() / 2f);
img.setCenterY(Gdx.graphics.getHeight() / 2f);

// render
img.draw(batch);

// dispose (seems pointless)
img.getTexture().dispose();

Underscores in filenames can be a bit sketchy if they're ever run through Texture Packer, so often dashes are used instead. E.g. bob_version_2 would by default become region bob_version with index 2. I may or may not have been bitten by that the other day. This image is unaffected since dark is not a number. Though I realise this is the filename used for the website.
I should leave this place now, as I could go on indefinitely. It's such a difficult thing, knowing what's ideal to have in the main class. Something that says "it is working; welcome to libGDX."

gdx-setup was retired in favour of gdx-liftoff, so this PR is obsolete.


docs: Explain commit summary example explicitly.

Adds an example to address common mistakes with capitalization,
missing the trailing period, and prefixing with a subsystem name.
Fixes #1535.

Good summaries:
Notice how the first example starts with a capital letter "I", ends with a
period ".", and the name of the subsystem starts with a lowerecase letter
"p" followed by a colon ":" and a single space " " after the colon.
provision: Improve performance of installing npm.

Added link to Zulip's Git pre-commit hook setup instructions.

Nice, merged as ed409e80718c73171e8122fb2b447dee3809858c, thanks @drrosa!


Feature request: support of Xray test environment field

Hello @csvtuda ,
it would be great if we can add the test environment for the test execution result. It is an Xray field, not a Jira one.
Thanks in advance!
Best,
Zoltan

Hey @ztarsoly,
thanks for the suggestion, this sounds like a good addition! I will try to add it as soon as possible.

I just released version 5.2.0, which added test environment support. You should now be able to set test environments (documentation) to associate with each test execution.

Warning
Please be aware that if you reuse existing test execution issues, Xray will replace all existing test environments with the ones you provide to the plugin.

It works like a charm. Thank you for your effort!


fix(Accordion): solve the shift between buttons when they are opened

#364

@benjamincanac done

Is there a way to solve Vercel's action? It's noisy to see that it always shows ❌. However, I give it permissions.

I've disabled Vercel Git Fork Protection, we'll see if it fixes the issues! I've pushed a small fix to harmonize the panel spacing.
Besides that, it does fix the shifting issue, thanks 😊


Vitest failing to bundle nested dependency while Vite succeeds

Describe the bug
We have a component library that imports "react-focus-lock". When our component library is imported by a consumer in a Vitest test it resolves "react-focus-lock" as { default: FocusLockComponent } rather than FocusLockComponent, while this might be an issue with how these packages are defining their package.exports the config currently works in Vite so I found it strange that it didn't work in Vitest.
I have been able to work around the issue by defining includes like mentioned here
The issue does appear when running the code in Node so I get why it's failing in Vitest but I think it's still unexpected that it fails in Vitest but not Vite.
Right now our solution is to tell the consumer to include
"@components/react", "@components/modal", "react-focus-lock", "prop-types" in their deps.include arrays
Reproduction
https://github.com/brynshanahan/Vitejs-Vite-forked
System Info
System:
    OS: macOS 14.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 106.64 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 21.7.2 - /usr/local/bin/node
    Yarn: 3.4.1 - /usr/local/bin/yarn
    npm: 10.5.0 - /usr/local/bin/npm
    pnpm: 8.11.0 - ~/Library/pnpm/pnpm
    bun: 1.0.26 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.183
    Edge: 126.0.2592.102
    Safari: 17.5

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vitest doesn't bundle anything, it uses Vite dev server. The optimizer is disabled by default because we cannot "reload" the page when a dependency is bundled when running tests.
Unfortunately, this is expected behaviour. Dependencies that are not inlined go through Node.js module resolution, not Vite one, for performance reasons.  If you do not care for performance, you can enable test.server.deps.inline: true.
If you need 1-to-1 parity with Vite, use Browser Mode and run tests in the actual browser.

Yeah that makes sense, thanks for the quick reply!


Remove qq.com from disposable emails list

"qq dot com is an e-mail service provided by Chinese Tencent company. It is very much like hotmail/gmail. The qq dot com address can also be used to login for other services like the free 10 TB cloud disk offered by Tencent, Weiyun dot com. So it is definitely not intended for disposable/temporary emails."
http://www.quora.com/Are-email-addresses-for-qq-com-permanent

I'd like to keep the automated way of getting the domains, but custom exceptions make sense. Working on it.

Fixed in https://github.com/lavab/disposable/tree/v0.1.0


aerofc: Add and use a new I2C bus

To this work is necessary also update the FPGA RTL(https://github.com/intel-aero/intel-aero-fpga/pull/2)

Overall LGTM. Some minor comments above.

Please merge when all things are ready including the FPGA image for a complete upgrade.

Note that we will need this in for the v1.6 release. Do you have the FPGA image and a BSP update ready?

This shouldn't be in 1.6 yet. The latest release of the BSP doesn't contain the needed changes.

Btw last BSP is 1.3.1: https://github.com/intel-aero/meta-intel-aero/releases
Should be available for download next Monday.

@lucasdemarchi now should be a good time to get back to this? I just rebased and tested this

Yes. And remember to leave the current i2c bus as is

Yes. And remember to leave the current i2c bus as is
It was already fixed.

FPGA firmware updated and binary sent to be integrated on Aero image.
https://github.com/intel-aero/meta-intel-aero/pull/226

@LorenzMeier @lucasdemarchi ping

@zehortigoza Could you explain how this should be merged? If we merge now, does master work with the latest Aero BSP or where should we point users?

@LorenzMeier PX4 will boot and run ok with the FPGA firmware from the latest Aero BSP release(1.4v) but the user will lose GPS. Users can download the updated FPGA firmware before the release from here: https://github.com/intel-aero/meta-intel-aero/tree/master/recipes-support/jam-stapl/jam-stapl

@LorenzMeier I don't have powers in this repo to merge this. Can you do so, please?

Sorry for the oversight - and we can certainly talk about a more central role in the maintenance team. It would be good to have you being able to do more.


add compatibility should item

Addressing #77
I continue to think compatibility an important issue and that the definition is by far the most powerful venue this group has, so should (heh) be mentioned there.
We have other shoulds in the definition, this one is as important.
I've kept this very brief:

The license should be compatible with other open licenses.

Some obvious ways to extend:

The license should be compatible with other open licenses to the maximum extent possible given its policy ends.

or

The license should be compatible with other open licenses, in particular one or more of the most commonly used copyleft licenses.

However I tend to think generality is good here, message should not prompt thinking of excuses (which ...policy ends... does) nor narrowness (which ...copyleft licesnes does).

sent also to mailing list:
My inclination is to word it sort of like:
"The license should aim for compatibility with…"
and perhaps
"The license should avoid [extraneous] conditions that would create
incompatibilities with other Open licenses"
Basically, the point is something like "Any clause that creates
incompatibilities should require justification and careful consideration."
Essentially, "consider compatibility with other Open licenses as a high
priority, and do not carelessly introduce incompatible terms."
I hope some of this perspective and writing can be used / adapted into
this concern which I basically agree with.

Closing as we don't need renumbering, will use the added text in section 2 intro


Create issue_template.md

This is to fix issue raise in #147
Purpose
this pull request is to resolve the issue raised in issue #147
Proposed changes
the file for an issue template was missing but referenced in various places, this will restore that fiel wiht a basic template ready for other to improve later
Open Questions and Pre-Merge TODOs

[x] Use github checklists. When solved, check the box and explain the answer.

Types of changes
What types of changes does your code introduce to hypertrons-crx?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Approach
this has added the file for an issue template to be used when someone raises a new issue
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments (Optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Links to blog posts, patterns, libraries or addons used to solve this problem

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @liambrewster for your great job!


⚠ GazelleGames has degraded performance

In e3438e7, GazelleGames ($GGN) experienced degraded performance:

HTTP code: 200
Response time: 5589 ms

Resolved: GazelleGames performance has improved in 010be8c.


When bundling custom connector image with solution, the image is replaced with the default one

When the iconblob is set to a valid PNG file, the default custom connector icon is still used.
The image is bundled in the solution ZIP file and customizations.xml contain the XML below which has correct paths as well:
<?xml version="1.0" encoding="utf-8"?>
<Connector xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <connectorid>59918c08-cc28-44b4-bf4f-edb5365517fd</connectorid>
  <description></description>
  <displayname>TALXIS_Connectors_XXXX</displayname>
  <iconbrandcolor>#007ee5</iconbrandcolor>
  <name>talxis_connectorsxxxx</name>
  <connectortype>1</connectortype>
  <openapidefinition>/Connector/talxis_xxxx_openapidefinition.json</openapidefinition>
  <connectionparameters>/Connector/talxis_xxxx_connectionparameters.json</connectionparameters>
  <policytemplateinstances>/Connector/talxis_xxxx_policytemplateinstances.json</policytemplateinstances>
  <iconblob>/Connector/talxis_xxxx_iconblob.png</iconblob>
</Connector>

Hi @hajekj do you mind providing more context on what you're trying to do here? We don't use xml files.

Hi
I can confirm this happens. We have a connector that we built to talk to the Microsoft Graph API for Teams and AAD Groups.
In our Dev environment it looks like this:

The connector is exported from Dataverse in a managed or unmanaged solution zip file. The file contains these files:

[Content_Types].xml
customizations.xml
solution.xml

And a folder Connector that has the actual connector files:

tpg_5Ftpg-20teams-20connector_connectionparameters.json
tpg_5Ftpg-20teams-20connector_iconblob.Png
tpg_5Ftpg-20teams-20connector_openapidefinition.json
tpg_5Ftpg-20teams-20connector_policytemplateinstances.json

The only reference to the Png file is in the customizations.xml file, in the iconblob node. This looks the same as what @hajekj gave, except I inserted the entire file:

<ImportExportXml xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <Entities></Entities>
  <Roles></Roles>
  <Workflows></Workflows>
  <FieldSecurityProfiles></FieldSecurityProfiles>
  <Templates />
  <EntityMaps />
  <EntityRelationships />
  <OrganizationSettings />
  <optionsets />
  <CustomControls />
  <EntityDataProviders />
  <Connectors>
    <Connector>
      <connectorid>76434d40-ff76-4b61-9407-d59b618f6cd7</connectorid>
      <description>TPG Microsoft Teams custom connector that allows creating and managing Microsoft Teams.</description>
      <displayname>TPG Teams Connector</displayname>
      <iconbrandcolor>#be0b1d</iconbrandcolor>
      <name>tpg_5Ftpg-20teams-20connector</name>
      <connectortype>1</connectortype>
      <openapidefinition>/Connector/tpg_5Ftpg-20teams-20connector_openapidefinition.json</openapidefinition>
      <connectionparameters>/Connector/tpg_5Ftpg-20teams-20connector_connectionparameters.json</connectionparameters>
      <policytemplateinstances>/Connector/tpg_5Ftpg-20teams-20connector_policytemplateinstances.json</policytemplateinstances>
      <iconblob>/Connector/tpg_5Ftpg-20teams-20connector_iconblob.Png</iconblob>
    </Connector>
  </Connectors>
  <Languages>
    <Language>1033</Language>
    <Language>1036</Language>
    <Language>1031</Language>
  </Languages>
</ImportExportXml>

When the solution is imported into a different environment, the icon doesn't show in the environment:

This issue was the only search result I could find that referenced that node apart from the certification topic, and the Dataverse documentation about the Connector table.


Files created in root for umbrella projects

From https://github.com/phoenixframework/tailwind/issues/33#issuecomment-1225921916, we still see this issue constantly.
In umbrella projects tailwind generate sassets files in root when installing. It's very easy to reproduce. Just remove the tailwind bin file and Tailwind library will create assets files in root. This would also be an issue if you are using non-standard path for assets for whatever reason.
I opened a PR half a year ago to not auto generate files when watching the assets: https://github.com/phoenixframework/tailwind/pull/53
But maybe it's better to just deal with it using the :cd config: https://github.com/phoenixframework/tailwind/pull/78

I added --no-assets to disable the assets generation. :)