Package name redeclared when shadowing packages and using pkg flag

This probably doesn't affect many people, and it isn't super important, but let's say you create a package with a name that is the same as a package it uses. Eg I might make github.com/xxx/myapp/http and inside of it use the net/http package.
package http

//go:generate moq -pkg http_test -out thing_moq_test.go . Thing

type Thing interface {
  Blah(w http.ResponseWriter, r *http.Request)
}

If I do this AND use the -pkg flag, the following is generated:
import (
  "github.com/xxx/myapp/http"
  "net/http"
  "sync"
)

And this doesn't work 😢
This isn't urgent at all as I can just NOT use the -pkg flag and make it work. I'm just pointing it out because I ran into it today.

This could be related to #92 . If you want you could try pull request #93 to verify if it fixes the issue.

Does #93 introduce named imports? Because that is really the only fix here. One of the two http packages needs to be named. Eg:
import (
  myapp_http "github.com/xxx/myapp/http"
  "net/http"
  "sync"
)

Including both imports isn't actually a bug; it is necessary for the code to work.

You are right both imports are required. #92 happens because an unnecessary import is made. So probably it's not related.

@joncalhoun @omarkohl I know it may look like advertisement and it surely is :) but take a look at minimock Most of the issues you guys create here either never existed in minimock or solved long time ago.

Same thing happening here :-)

This error can be resolved by fmt=goimports

Closed via #141.


some bug fixes

I am still in the process of reading the chatterbot and gettting more familiar slowly .
I found some bugs like in conversations.py 's Statement class function detect_sentiment
def detect_sentiment():
        """
        A property that describes hows the
        """

        if self.sentiment:
            return self.sentiment

        # Evaluate the sentiment of the statement
        #else:

not sure if we are using this function anywhere however it still miss a self i.e. correct one should be
def detect_sentiment(self):
        """
        A property that describes hows the
        """

        if self.sentiment:
            return self.sentiment

        # Evaluate the sentiment of the statement
        #else:

similarly something wrong in
def get_sentiment(name):
        """
        Returns the average sentiment for a single user throughout a
        conversation.
        """
        sentiment = []
        for statement in self:
            if statement.name == name:
                sentiment.append(statement)

        return "" #TODO: return the average sentiment

can i do a change in it and add it in a new brach or is it best to raise a similar issue here

These methods aren't being used. Feel free to create a branch and make the changes as needed.


Performance Terrible - Unusable experience

Issue Type: Performance Issue
Performance is really bad today.  I don't know what happened.  Scrolling is really bad, and moving the caret position with the keyboard has a slight delay.  Very annoying - even unusable.  Tried multiple projects and they all have the same issue.
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.17692

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.93GB (10.81GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    4	   131	 15308	code main
    4	   150	 11888	   gpu-process
    3	    82	 14440	   window (Issue Reporter)
    0	   223	 14744	   window (my-view1.html - PlaybookFiddle - Visual Studio Code)
    0	    11	 14556	     watcherService
    0	    12	 14108	       console-window-host (Windows internal process)
    0	    63	 16120	     extensionHost
    0	    86	  4516	       electron_node htmlServerMain.js
    0	    74	 14752	   shared-process

Workspace Info
|  Window (my-view1.html - PlaybookFiddle - Visual Studio Code)
|    Folder (PlaybookFiddle): 22 files
|      File types: html(12) json(3) js(2) png(2) gitignore(1) md(1) svg(1)
|      Conf files:;

Extensions (1)

Extension
Author (truncated)
Version

remote-vscode
raf
1.1.0

Does it go away if you completely close out of VS Code and then restart it? If you are looking at the Task Manager is VS Code at something like 100% utilization of one core (so on a 4-core machine it sits at 25%)?
(I am having a performance issue which may be similar: performance seems to slowly degrade over time, but "snaps back" when reloading VS code. During this the delay is definitely CPU-bound.)

I have been having a ton of performance issues. I noticed that there are a ton of Issues are being found with styling stuff in the problem tab. I removed the linting extensions but it still kept finding css and scss stuff wrong.  If I close and reload it seems like its very busy and super slow finding problems.

this seems to have helped in the settings, though im not sure if its a long term solution
"scss.validate": false,
"css.validate": false

@ChrisDrostUSE No, I've restarted VS Code a few times and even restarted my computer, and it still has performance issues.

The issue magically went away today.  I have no idea why this was happening.  I haven't used my computer since last seeing the issue, so I'm not sure how it just stopped occurring.  I am going to close this issue.


Error flutter outline

Version information

IDEA AI-201.87<IP_ADDRESS>99119
2.12.3
AI-201.87<IP_ADDRESS>99119, JRE 1.8.0_242-release-1644-b01x64 JetBrains s.r.o, OS Windows 10(amd64) v10.0 , screens 1536x960
I don't know where is my outline?

Can you explain in more detail what your problem is?

No replies so far, will close the issue as cannot reproduce due to insufficient information.
Please feel free to reopen it if a reproduction with  more information is available.


Drag and drop releases randomly on large items

So this issue post compose update to 1.7.0.
When trying to drag large items somehow it releases automaticly and drops randomly.
In video I use:

Android 13
5.3 720x1480 screen size
Maximized display item size and text

I used other resolutions for testing and the same bug appears.
Screen_recording_20241106_080151.webm
Screen_recording_20241106_080015.webm

What's the version of compose in your project and which version of this library are you using?

It's your demo project:

activityCompose = "1.9.3"
agp = "8.3.2"
compose = "1.7.0"
kotlin = "2.0.0"
mavenPublish = "0.29.0"
precompose = "1.6.1"
uiTooling = "1.7.5"

group = "sh.calvin.reorderable"
version = "2.4.0"

It seems that the main thing is the size (or maybe zoom(display item size maximization))

Hmm I'll take a look. I thought it was solved already

Sorry last issue that I opened just did not have time at that moment to provide more information. My bad.

Hey, did you managed to reproduce the issues? Any update?

It's a busy week. I'll try to take a deeper look soon. It's not immediately obvious in the code what's wrong.

We got the same issue.
Happens also with the sample project, if you do this:
`package sh.calvin.reorderable.demo
data class Item(val id: Int, val text: String, val size: Int)
val items = (0..200).map {
Item(id = it, text = "Item #$it", size = if (it % 2 == 0) 70 else if(it == 15) 1000 else 100)
}
`
Debugged it a big, it seems like in fun Modifier.draggable for some reason the DisposableEffect is called and then everything is getting cleared. Maybe some behavior changes in the new compose version?
Did you maybe get some insights @Calvin-LL?

So the problem is the dragging item's actual position on the list can't be moved off screen. Once it's moved off screen, LazyColumn disposes it. I had something in the stroller to make sure a dragging item is never scrolled off screen but I'm not sure why it's not working. I'll have to wait till I have a free day to take a deeper look. Feel free to dig into it and see if you can solve it.

Hello, any updates on this issue?

I think I finally figured out what's wrong with it but I've been too busy to dig into it 😢

@Calvin-LL don't want to push you or something, but do you know when will you have some time to dig more into it?

I think this weekend hopefully. Ask me again next week if I haven't.

Hello, @Calvin-LL any updates?

Having the same issue with scrolling the Large item to the top. Any updates on this Calvin?

Thank y'all for reminding me. Took a deep look today and I think I have a fix. Will polish and push an update tomorrow.

v2.4.1 is out

It works better now, however, it's not completely fixed.
If you have big items, e.g. 800 dp or bigger, it still releases sometimes.
Not sure, if there is a workaround you can do, since it's something google should fix.
Filled a bug there as well https://issuetracker.google.com/issues/380805022

There's a limit to what it can handle with large items. Lazy Layouts only compose items that are on the screen, and this library offsets them to achieve dragging. If the items are so big that only one is rendered on screen, and the dragging item's original location is no longer on screen, then the item will disappear under your finger.


hubble/relay: fix report of unavailable nodes

This commit fixes reporting of unavailable nodes. The previous code
incorrectly assumed that nodes were unavailable only when their
associated ClientConn is nil. However, a peer may still be
unavailable if its ClientConn is not healthy. The connection state can
be checked by using the GetState() which is what the new helper
function does. Any state that is not Ready or Idle is assumed to be
non-healthy.

test-me-please

Coverage decreased (-0.02%) to 37.169% when pulling d0581cd96e1f99aecc942eca25d249d8165d5906 on pr/rolinh/hubble-relay/fix-unavailable-nodes into 4e11ae1bb82d3e3f1cde535405e5e79f9ce1606e on master.


Suggestion: ExpectChange cop applied on negated matcher

On RSpec one can do:
expect { ... }.to change { ... }
              .and change { ... }

But it is not possible to do
expect { ... }.not_to change { ... }
              .and_not change { ... }

A common solution for this is defining a negated matcher for change:
RSpec::Matchers.define_negated_matcher :not_change, :change

...
expect { ... }.to not_change { ... }
              .and not_change { ... }

On doing this however, we lose the ExpectChange cop usefulness. I thought of creating a custom cop for it for my needs, as not_change is not standard. However, being it a common practice, I think that it would be nice for the ExpectChange cop to have an option where you'd explicit the negated matcher method.
e.g.:
RSpec/ExpectChange:
  NegatedMatcher: not_change

What do you think?

Seems closely related to https://github.com/rubocop-hq/rubocop-rspec/issues/333


Restake token amount 12 December strange data

@bro-n-bro-2, @bro-n-bro-0  DB issue (if it's issue), checked code, view data and direct sql query have equal values

@iljagrabar14
check this day, what happenned
check restake message, find why did this restake , check this accounts

The same issue


Ignore mysql startup failure

in some cases mysql might already be started and the command fails, which aborts chef client
Not sure if it might be better to stop and start mysql instead

:purple_heart: :yellow_heart: :heart: :blue_heart: :green_heart:
That hack is only in place due to some issues with the testing containers and mysql not starting. If the change makes the hack better (== not breaking stuff) then it does not really matter how that is achieved :D


[BUG] Android SDK - At times joins different meetings

When users join a meeting with the same meeting ID sometimes it seems that they are in two different room. No one can see each other or hear each other. The user count in the room is 1 (suppose to be more than 1). But when a user leaves the room and joins again (with the same meeting ID) then they both can see each other.
To Reproduce
Two users join meeting room at the same time.
Expected behavior
They should be able to talk to each other and be on the same channel.
Setup (please complete the following information):

OS: Android 8 or above
IDE : Android Studio
1.2.0, 2.0.0, 2.0.0-beta.1

Hi @rahatur, thank you for bringing this to our attention. Could you take a look @jsaurezlee-msft? Thanks :)

@rahatur
Hi is this teems meeting or group call?
For me, group calls are created as separate calls when using the same join id?

Note: We have noticed that the issue seems to be occurring more on unstable connections and when device switches between wifi and mobile data (even when both are stable).


feat: remove manager grpc proxy

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Remove manager grpc proxy.

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1113 (077b333) into main (373a037) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   45.36%   45.32%   -0.05%
==========================================
  Files         130      130
  Lines        9966     9966
==========================================
- Hits         4521     4517       -4
- Misses       4917     4921       +4
  Partials      528      528

Flag
Coverage Δ

Object-compatibility-e2etests
?

unittests
45.32% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cdn/supervisor/progress/progress.go
91.04% <0.00%> (-5.98%)
:arrow_down:

client/daemon/peer/peertask_conductor.go
57.31% <0.00%> (ø)


Fix broken link in docs/related.md

What this PR does / why we need it:
One of the external blog links in docs/related.md is broken, likely a result of hackernoon moving off of Medium.
Special notes for your reviewer:
For your convenience here's the change I made:
Previous (broken) link: https://hackernoon.com/the-missing-ci-cd-kubernetes-component-helm-package-manager-1fe002aac680#.691sk2zhu
Updated link: https://medium.com/@gajus/the-missing-ci-cd-kubernetes-component-helm-package-manager-1fe002aac680
If applicable:

[x] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Say, @bacongobbler - are we holding this on the basis of the circleci test failure? It doesn't look like there's anything wrong with this PR itself - thanks.

nope! Just forgot to merge this one. Thanks for following up.


Macro data seems to be counted incorrectly under show-profiles

expandedNodes and expansionNanos are always 0 in the output generated when the show-profiles flag is enabled.
Example code:
import io.circe.generic.semiauto._
import io.circe.generic.auto._
object Main {
  case class T(f1: Either[List[List[List[Int]]],Option[String]])
  def main(args: Array[String]): Unit = deriveCodec[T]
}

Output:
[info] time spent in macroExpand     : 180 spans, ()344.558ms (88.6%)
[info] Macro data per call-site:
[info] Map(
[info]   NoPosition -> MacroInfo(expandedMacros = 6, expandedNodes = 0, expansionNanos = 0L),
[info]   source-testproj/src/main/scala/Main.scala,line-7,offset=198 -> MacroInfo(
[info]     expandedMacros = 58,
[info]     expandedNodes = 0,
[info]     expansionNanos = 0L
[info]   )
[info] )
[info] Macro data per file:
[info] HashMap(
[info]   Main.scala -> MacroInfo(expandedMacros = 58, expandedNodes = 0, expansionNanos = 0L),
[info]   <no source file> -> MacroInfo(expandedMacros = 6, expandedNodes = 0, expansionNanos = 0L)
[info] )
[info] Macro data in total:
[info] MacroInfo(expandedMacros = 64, expandedNodes = 0, expansionNanos = 0L)

This is occurring in both 2.12 and 2.13 for me.

Did a bit of digging to see if I could find a cause, ProfilingImpl contains this bit of code:
val treeSize = 0 // macroInfo.expandedNodes + guessTreeSize(expanded)

// Use 0L for the timer because it will be filled in by the caller `apply`
macroInfos.put(callSitePos, MacroInfo(expandedMacros, treeSize, 0L))
expanded

... But the timer never actually gets filled.
pluginsMacroExpand used to contain a function that updated the timers, but it got removed in https://github.com/scalacenter/scalac-profiling/commit/6000f5eddefbcd4cc8277f09717b0319e5b8ae8a:
def updateExpansionTime(desugared: Tree, start: statistics.TimerSnapshot): Unit = {
  statistics.stopTimer(preciseMacroTimer, start)
  val (nanos0, _) = start
  val timeNanos = (preciseMacroTimer.nanos - nanos0)
  val callSitePos = desugared.pos
  // Those that are not present failed to expand
  macroInfos.get(callSitePos).foreach { found =>
    val updatedInfo = found.copy(expansionNanos = timeNanos)
    macroInfos(callSitePos) = updatedInfo
  }
}

As I wrote in #133, expansionNanoss should become more plausible, but the issue with the blank expandedNodess is still present. That's why I think the current issue should be open. Disregarding the matter of whether expandedNodes is required to have in general.


Difficult to integrate graphql-ruby with graphql schema loaded from a .graphql file

The README shows how to integrate this gem with your project by calling use from within a GraphQL::Schema subclass:
class MySchema < GraphQL::Schema
  query MyQueryType
  mutation MyMutationType

  use GraphQL::Batch
end

However, for our project, we do not have a schema class; instead we are loading our schema at boot time from a .graphql file:
schema  = GraphQL::Schema.from_definition(graphql_schema_string, default_resolve: ->(*args) { MyResolver.resolve(*args) })

I did some digging through the source code of the graphql gem and this gem, and found that I could integrate this gem by doing the following:
GraphQL::Define::DefinedObjectProxy.new(schema).use(GraphQL::Batch)

GraphQL::Define::DefinedObjectProxy is the only way I could figure out to get this to work, given GraphQL::Batch#use calls target, which, as afar as I can tell, is only defined on GraphQL::Define::DefinedObjectProxy.  This works, but took a lot of digging, and it feels like I'm using a private API as I don't think the author of the graphql gem intends DefinedObjectProxy to be something that end-users directly instantiate like this.
Am I missing a simpler way to integrate graphql-batch with my project?  Or is there a simple change that could be made to graphql-batch to support GraphQL::Batch.use(schema) or something similar?

use is the official "plugin" API of the graphql gem so I'm not sure this gem should offer anything else. I think the real solution to this would be upstream in graphql itself. Otherwise every plugin would have to offer an alternative method. I'd suggest opening an issue there regarding this.
One other thing you could do is just create a simple object which responds to target instead of DefinedObjectProxy. ie:
TargetWrapper = Struct.new(:target)

schema  = GraphQL::Schema.from_definition(graphql_schema_string, default_resolve: ->(*args) { MyResolver.resolve(*args) })
wrapped = TargetWrapper.new(schema)
wrapped.use(GraphQL::Batch)

Thanks!  I'll give that a shot and report this to the graphql gem as well.

Opened a PR on the graphql gem itself: https://github.com/rmosolgo/graphql-ruby/issues/2307


MERN_MongoDB: 1.1 What is MongoDB?(A)

Description
What is MongoDB?
Provide the .md file containing the drive link for MP3 audio explaining "Introduction to MongoDB in MERN stack".
Project directory
Branch MERN>MERN/Topic/Backend/MongoDB/
File Name
1.1_What_is_MongoDB?(A).md
Domain
MERN
Type of Contribution
Audio
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

hey @NimeshJohari02, whats the status for this issue?

I am working on it. I had exams recently . it'll be done in a few days.
On Tue, 28 Sep, 2021, 10:35 pm Saloni Subedi, @.***>
wrote:

hey @NimeshJohari02 https://github.com/NimeshJohari02, whats the status
for this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/girlscript/winter-of-contributing/issues/2251#issuecomment-929413885,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO35ZXIVH22XL4U7LWHX7STUEHYUTANCNFSM5ETYNHDA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

ok, thanks for clarifying


Doesn't support Channels

Currently the RSocket implementation does not support requestChannel.

I'm going to start looking at this. We have several use cases for it at Netifi so this is quickly becoming a blocker.

I have a branch that works but I don't have authority to push it to this repo - do I need to fork and link from there or something?

@kbahr Yeah please fork and submit a PR. I'm on vacation next week but @josephsavona might have time to take a look before that.

I hope you had a good vacation @lexs . Poke you and @josephsavona :)

What's the release process for you guys? I'm definitely eager to start integrating with this.

@kbahr It's pretty ad-hoc, I'll make a release tomorrow for you.

Thanks very much, @lexs!
On Thu, Aug 9, 2018 at 10:15 AM Alexander Blom<EMAIL_ADDRESS>wrote:

@kbahr https://github.com/kbahr It's pretty ad-hoc, I'll make a release
tomorrow for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rsocket/rsocket-js/issues/14#issuecomment-411831620,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADtqFtQUxuO_hRpoTGz83xc4WhG5NgJpks5uPG4igaJpZM4VPUui
.

@kbahr I tested the new code (yours + a few commits) and ran into issues caused by https://github.com/rsocket/rsocket-js/commit/8441b584492c6877b30043824cdc3b89fbbeb118. We'll see if we can fix this on Monday or if we have to revert. So no release for now. I'll update you on Monday.

Thanks for the heads up, @lexs. Also, there was a change merged to add a
TLS client - is that included in the changes you plan to release?
On Fri, Aug 10, 2018 at 9:47 AM Alexander Blom<EMAIL_ADDRESS>wrote:

@kbahr https://github.com/kbahr I tested the new code (yours + a few
commits) and ran into issues caused by 8441b58
https://github.com/rsocket/rsocket-js/commit/8441b584492c6877b30043824cdc3b89fbbeb118.
We'll see if we can fix this on Monday or if we have to revert. So no
release for now. I'll update you on Monday.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rsocket/rsocket-js/issues/14#issuecomment-412140248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADtqFtDuvkv-8RwTvImgEy912UVYIPffks5uPbkXgaJpZM4VPUui
.

@lexs any update on this? We're hung up waiting on the TLS and Channels support. Also it would probably be productive to have a face to face meeting at some point since we plan to make heavy use (and contribute back) to this project.

@kbahr Found the problem and fixed, just published 0.0.9 with the latest master (which will get pushed as soon as the code fully lands).
I'm in MPK/SF next week so timezones align if you want set something up. Let me know what time works over email.

@kbahr Didn't receive any email :O, can you send it to blom@ fb.com?

Ah indeed, my mail client barfed - I've sent it to your FB email now.
On Tue, Aug 14, 2018 at 9:29 AM Alexander Blom<EMAIL_ADDRESS>wrote:

@kbahr https://github.com/kbahr Didn't receive any email :O, can you
send it to blom@ fb.com?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rsocket/rsocket-js/issues/14#issuecomment-412933625,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADtqFou2jp9veybNVba1hea3evZg8XNHks5uQvrogaJpZM4VPUui
.


[alpine] Update Jenkins to 2.46.1

This PR updates jenkins-alpine to 2.46.1

No need to create extra PRs for alpine. Already merged from master.


add test coverage

Coverage increased (+2.3%) to 8.599% when pulling 474cb91028157621e4ddc7cd8772c0a573972764 on cv/add_tests into cf81b8936652f5ece8e2cc26becb668d761d49b2 on master.


Document pnpm install's --no-lockfile option

https://pnpm.io/cli/install doesn't currently list this option.
References:

pnpm/pnpm/pkg-manager/plugin-commands-installation/src/install.ts#L122-L125
pnpm/pnpm/pnpm/test/install/misc.ts#L50-L58

It is documented here: https://pnpm.io/npmrc#lockfile

@zkochan I'm not sure but I think there might be a bit of confusion here 🤔 the --no-lockfile option that this PR is adding to the documentation is not documented on the url that you're linking to.
I mean I might have missed it but I did a "find in page" for --no-lockfile and I didn't see anything


updated loggable exceptions to sanitize internal data

Ticket numbers are useful in github too.

Why don't you just use a real simple regex?

Why don't you just use a real simple regex?

The ticket number: INFRA-2077: Don't log password when an exception occurs during log in


Bumped development RELEASE for 1.23-3

Bumped development RELEASE for 1.23-3
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/appove

/lgtm


integrate github-release into build process

reference: https://github.com/aktau/github-release

release rate is fairly low


Should have luis authoringKey and authoringRegion when lu file not empty

Describe the bug
When trying to publish a bot which is not using LUIS at all, I get the following error:
Should have luis authoringKey and authoringRegion when lu file not empty
Version
v1.1.1
Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

Expected behavior
It should be possible to publish a bot which is not using LUIS at all (all .lu files are empty) without providing LUIS information

Hi, I am getting this error while publishing my bot. I can publish my bot using v1.0.2. Is there any changes in the new version of bot composer?
please let me know how to resolve this issue. I have given all keys and endpoint URL in the settings

In the new version of bot composer, we should provide one more field called "authoringRegion":"westus" to resolve this error.
issue solved.

Issue is not solved IMHO as I'm not using LUIS in my bot at all...

@stephanbisser , could you zip your bot and share with us? We can help to debug it.

I fixed this issue after removing the "luisResource" key from the bot's settings @luhan2017


CHAOS-4278 fix dead links

Fix dead links

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65cd9a6c31cf5167ff583b13--harness-developer.netlify.app


does gcredstash put support reading from file?

Hello,
When using credstash put, one can reference a file to read the value from with @path/to/file. When using that with gcredstash put, I get a value of @path/to/file in the dynamodb.
What is the correct way to read from file?

Looks like I figured it out, though this could be better documented (I'll see if I can send in a PR).
For anyone who happens upon this later:
ᐅ gcredstash put -a my/key - role=foo < secrets/my/key

use - and then < file.


osinfo-db: 20180416 -> 20180502

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/osinfo-db/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 20180502 with grep in /nix/store/xsgfilzqf0fkahxgp24ivs90xy8mz6rs-osinfo-db-20180502
directory tree listing: https://gist.github.com/38c69c0bcc2f185f90e5c56f329dc980

cc @bjornfor for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: osinfo-db
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


Feature Request: Browserify feathers-rx for angular2

Hi feathers team,
I'd like to use the rx-extension also in the browser (in an angular2 application). Currently there is no possibility as it seems to me.
I already tried to use browserify in the same way as the feathers-client does, but sadly without a usable result. Does someone know how to achieve this?

Hey @netzwerch, feathers-rx absolutely works in the browser! You'll have to build the files from the ES6 source (download repo, npm install, npm run compile) but once you've done that you should be good to go!
Normally feathers repositories have this /lib folder committed and ready to go, but since feathers-rx is still highly experimental we're waiting for an initial release to do that and list it on npm. Expect this within a week, I hope.

Thx @harangue, thats a good info. I tried but wasn't able to use it in angular2. I assume it's either because of the compilation to a CommonJS module (I currently use the angular2 quickstart that uses SystemJS), or that there is a TypeScript definition missing.
I'll keep digging into that and report what I find out.

I just published the first version of this module to npm as feathers-rx and a browserified version can be found in the dist/ folder. It currently includes RxJS (which we probably want to change for the next release) but it should be usable. The direct CDN link is<EMAIL_ADDRESS>


2.13.0 makes my app crash using withThrowingTaskGroup

Bug report
Hello,
Seems I have a crash when I have updated SDK to the last version, probably because of the addition of Task helpers or maybe I'm doing something wrong but it seems I cannot use withThrowingTaskGroup like this example
let images = try await withThrowingTaskGroup(of: Story.self, returning: [Story].self) { taskGroup in
            let stories = try await client.stories(userId: profileId)
            for story in stories {
                if client.checkIfValidStory(date: story.date) {
                    taskGroup.addTask { try await client.story(userId: profileId, info: story)! }
                }
            }

            var images = [Story]()
            for try await result in taskGroup {
                images.append(result)
            }
            return images.sortedByDate()
        }

This basically calls 2 func that uses storage api, one to list all files and second to download file

[x] I confirm this is a bug with Supabase, not with my own application.
[x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug
Cannot use withThrowingTaskGroup
To Reproduce
Use withThrowingTaskGroup
Expected behavior
Should work as before concurrently
Screenshots
If applicable, add screenshots to help explain your problem.
System information
//
Additional context

Hi @florianmari
Thanks for bringing up this, what is happening is that we're now using task locals for the internal logging of the library.
Doing some research I found a few issues on Swift compiler referencing this:

https://github.com/apple/swift/issues/73217

We should not use task locals within the withThrowingTaskGroup's body, that happens at the line let stories = try await client.stories(userId: profileId).
In your code I think if you move that above line out of the withThrowingTaskGroup's body it will work.
let stories = try await client.stories(userId: profileId) // this line was moved

let images = try await withThrowingTaskGroup(of: Story.self, returning: [Story].self) { taskGroup in
  for story in stories {
    if client.checkIfValidStory(date: story.date) {
      taskGroup.addTask { try await client.story(userId: profileId, info: story)! }
    }
  }

  var images = [Story]()
  for try await result in taskGroup {
    images.append(result)
  }
  return images.sortedByDate()
}

This Swift bug has been fixed in https://github.com/apple/swift/pull/73978 but unfortunately that will land only on Swift 6.0.
If the issue persists after you change your code to the suggestion above, I'll revert that task locals change from the logging layer.
Thank you!

 Thank you!


Feat: initial draft for a comprehensive contribution guidelines

Update the draft for all the TODO sections marked in the comments
and create new subsections for missing instructions or Guidelines.

I have a contribution guide in the works. Will try to push it next week

I would suggest people attach a complete test case, including inputs and expected outputs, when they submit bugs so that we could reproduce quickly.

I did need a non-trivial amount of experimentation to figure out how to build and set up my development environment with triton, without relying on pip, so here are my 2 cents on setting that up, which can hopefully make it easier for others, and possibly help @ptillet with the guide:
# this will create the following directory structure:
#
# triton
# ├── bin  (binary dependencies)
# │   └── llvm-14
# ├── build  (build directory)
# │   ├── llvm-project
# │   └── triton
# ├── deps
# │   └── llvm-project  (github.com/llvm/llvm-project)
# └── src  (github.com/openai/triton)

# system/build dependencies (for Debian)
sudo apt install ninja-build  # optional, better build system to compile faster
sudo apt install pybind11-dev  # only needed if you want to build the python module

# Get and build llvm-14
# instructions from https://llvm.org/docs/CMake.html
mkdir -p triton/deps
cd triton/deps
# triton depends on llvm-14, newer versions won't work, see PR #1070 for an updated version
git clone https://github.com/llvm/llvm-project.git --branch llvmorg-14.0.0 --depth 1
mkdir -p ../build/llvm-project
cd ../build/llvm-project
# omit -G Ninja if you haven't installed it - but builds will be slow
# s/Release/Debug if you want a debug build of MLIR
cmake ../../deps/llvm-project/llvm/ -G Ninja -DLLVM_ENABLE_PROJECTS="mlir" -DCMAKE_BUILD_TYPE=Release
cmake --build .
# install LLVM in a local folder, using the build folder directly doesn't work
cmake -DCMAKE_INSTALL_PREFIX=$PWD/../../bin/llvm-14 -P cmake_install.cmake

# Get and build Triton
cd ../../
git clone https://github.com/openai/triton.git src
mkdir -p build/triton
cd build/triton
# remove -G Ninja if you dont have it
# remove -DTRITON_BUILD_PYTHON_MODULE=ON if you don't want python bindings
cmake ../../src -G Ninja -DMLIR_DIR=$PWD/../../bin/llvm-14/lib/cmake/mlir/ -DTRITON_BUILD_PYTHON_MODULE=ON
cmake --build .

./bin/triton-opt --version   # \o/

Writing this from memory / shell history, so there might be misspellings and wrong paths here and there. I haven't experimented with the python frontend yet, so there's likely some more setup to be done there.
Also have the triton/.vscode/settings.json file that configures the build system to work with this directory structure, so I can quickly rebuild my changes from VSCode (this is assuming that the triton folder is your VSCode workspace root):
{
  "cmake.sourceDirectory": "${workspaceFolder}/src",
  "cmake.buildDirectory": "${workspaceFolder}/build/triton",
  "cmake.generator": "Ninja",
  "cmake.configureSettings": {
    "MLIR_DIR": "${workspaceFolder}/bin/llvm-14/lib/cmake/mlir/",
    "TRITON_BUILD_PYTHON_MODULE": "ON",
  },
  "cmake.configureOnOpen": true,
  "cmake.copyCompileCommands": "${workspaceFolder}/compile_commands.json",
}

@ptillet any update on the topic
Best Regards,
Nishant

I can reproduce your procedure,  just remind others if they want to follow this guidelines,  looks the master branch is not compatible with llvm14,  branch phil/last-llvm-14 is good to work.

Closing. Let's use https://github.com/openai/triton/blob/main/CONTRIBUTING.md for now.


Use YAML object for app configuration values

Same as https://github.com/giantswarm/default-apps-aws/pull/380
context: https://gigantic.slack.com/archives/C01BYMF6RN0/p1704989737078779

/run cluster-test-suites

@fiunchinho Can you fix the conflict ?

@fiunchinho Can you fix the conflict ?

done


Datepicker: Unable to clear out modus date-picker internal error state 'Invalid date range'

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have read the contributing guidelines

Describe the issue
In our 'Field Data' application, inside filter panel, we are using modus date-picker component. This component maintains an internal error state 'Invalid date range', when an user selects invalid 'from and to date range'. While we have tried to clear out this date range on our own, the date range got cleared out but the message 'Invalid date range' is still appearing

Reduced test cases
No response
What operating system(s) are you seeing the problem on?
No response
What browser(s) are you seeing the problem on?
No response
What is the issue regarding ?
@trimble-oss/modus-web-components
What version of npm package are you using ?
No response
Priority
High
What product/project are you using Modus Components for ?
Field Data
What is your team/division name ?
Geospatial - CPD
Are you willing to contribute ?
None
Are you using Modus Web Components in production ?
No response

See if we can re-validate by listening to the valueChange event of the date inputs.

This issue has been resolved after adding errorText field to modus-date-picker component.


Improvement: split _predefined.scss

It would be useful for customize own site.
For example:

_theme.scss (for theme colors)
_fonts.scss (for fonts)
_admonition.scss (for colors and background-colors)
_variables.scss (for some variables, like dimmed opacity value)

mixins must be moved from this file forever.

So if a developer wants to change something, he doesn't override the full _predefined, just a small part.

Hi @vanodevium,
Somehow that makes perfect sense.
I am currently looking into it.

Hi,
I was able to decouple colors, admonition and fonts, but didn't find a good way to remove mixins, which needs to be checked thoroughly.
For now _predefined remains with the mixin, and it needs testing.

@1bl4z3r
Let me help you with this, I'll make pull request

You @vanodevium, kind sir, have my utmost respect.
Closing this issue.


Test coverage

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[X] No

Other information

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[stable/kube-state-metrics] add readiness probe

add same readiness probe that is present in kubernetes/kube-state-metrics deployment manifest

/ok-to-test

/lgtm


Port #12879 to 3.1

Fixes https://github.com/aspnet/AspNetCore/issues/13925.

Canceling in favor of https://github.com/aspnet/AspNetCore/pull/14638.


Failure to Connect (via Hoobs) to Tuya-Based Smart Ceiling Fan

Hello there...
First of all, this is my first HOOBS integration, and I've learned a LOT from your documentation - thank you!
Unfortunately, I'm stuck, and for the life of me, can't figure out what's wrong.  Hoping that you or someone can help if there's an obvious error in my work.
So I have a KlassFan Modulo ceiling fan [link] that is WiFi/app-enabled via the Tuya platform.
I have a HOOBS unit (physical) [link] connected to my home router, and have successfully followed the instructions installing the homebridge-tuya-lan plugin [link].
I've successfully created an account on Tuya's IoT platform, registered my account on it, run the 'tuya-cli wizard', and found the device's ID and local  Key, which I've successfully incorporated into the plugin's configuration:

{
    "platform": "TuyaLan",
    "devices": [
        {
            "name": "Smart Ceiling Fan",
            "type": "???????",
            "manufacturer": "KlassFan",
            "model": "Modulo",
            "id": "bf48................i8nf",
            "key": "6e5d.............4cdc"
        }
    ]
}

Two problems:

Unreachable - In spite of the fact that I've successfully linked my Tuya app (with the Smart Ceiling Fan successfully paired and working) to the IoT Cloud Platform, my HOOBS bridge can't seem to see it on the network; and
Device Type - There isn't a Device Type for "ceiling fan" that I can find, so my Homebridge can't identify the device on the network (see below).  I've tried "AirConditioner", "Fan", "SimpleFan", "Convector", "CeilingFan" - none make any difference.

This is the resulting content from the log file:
18/04/2021, 19:46:29 [4/18/2021, 12:46:29 PM] Registering platform 'homebridge-tuya-lan.TuyaLan'
18/04/2021, 19:46:29 Loading 1 platforms...
18/04/2021, 19:46:29 [TuyaLan] Initializing TuyaLan platform...
18/04/2021, 19:46:29 [TuyaLan] Marked Bedroom Ceiling Fan unreachable by faulting Service.Bedroom Ceiling Fan.Active
18/04/2021, 19:46:29 [TuyaLan] Smart Ceiling Fan (bf48................i8nf) doesn't have a valid type defined.
18/04/2021, 19:46:29 [TuyaLan] No valid configured devices found.
18/04/2021, 19:46:29 Preparing Advertiser for 'HOOBS Bridge 06CD' using bonjour-hap backend!
18/04/2021, 19:46:29 Starting to advertise 'HOOBS Bridge 06CD' using bonjour-hap backend!
18/04/2021, 19:46:29 Bridge is running on port 51826.

The device does show up in the iOS Home app (via the linked HOOBS Bridge), but the 'Controls' screen only says "Ceiling Fan: This accessory is not responding." and gives me an empty scroll wheel interface (that can't be interacted with).
I've checked and double-checked the "id" and "key" to make sure that they're correct, and current, and made sure that the ceiling fan itself is online and working on the local network both with the included remote, and the Tuya app.
Don't know what else to add, but happy to provide any more detail that might help clarify the issue!
Thanks!
A.

Hi, I have the same issue as you. Did you find a solution?

Not yet…I’m beginning to think that going to the Hoobs forums would be better than Github.  Just haven’t had the time, and I’m not a programmer, so don’t know how to fix it myself!

On 5 Jul 2021, at 13:21, GEDE35 @.***> wrote:
Hi, I have the same issue as you. Did you find a solution?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/AMoo-Miki/homebridge-tuya-lan/issues/238#issuecomment-874070287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC4F77247RYZZSNRKW3OWBLTWGPS5ANCNFSM43ERT2KA.


Support increasing zoom and locking focus

We've been using this in our app since May 2017

hey @lickel thanks for the PR and the project interest! ✌


feat: custom fonts

fixes #34

CITY (:

wdym?

Hehe this was used in Layer5 org it means (Cool I trust you)


Logger error with apt mirrors

Description of the issue:
Link to Gist Containing Build Logs:
    logger: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E
    logger: :
    logger: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-updates/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E
    logger: :
    logger: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-backports/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E
    logger: :
    logger: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-security/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E
    logger: :
    logger: Some index files failed to download. They have been ignored, or old ones used instead.
    logger: [02:21:36]: [TEST] Validating that suricata is correctly installed...
    logger: dpkg-query: no path found matching pattern *suricata*
    logger: [-] suricata was not found. Attempting to reinstall.
    logger: E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-updates/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-backports/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E: Failed to fetch mirror://mirrors.ubuntu.com/mirrors.txt/dists/xenial-security/main/i18n/Translation-en  302  Found [Mirror: http://mirror.lcsee.wvu.edu/ubuntu/]
    logger: E: Some index files failed to download. They have been ignored, or old ones used instead.
    logger: [X] Unable to install suricata even after a retry. Exiting.

Should be fixed by https://github.com/clong/DetectionLab/pull/340


[Spec] Tracers should reference an InstrumentationLibrary rather than a Resource

Spec PR merged: https://github.com/open-telemetry/opentelemetry-specification/pull/616
@mwear since you wrote the spec do you want to take this? If so, please assign yourself. If there is nothing to do, feel free to close this ticket.

It's somewhat in limbo based on: https://github.com/open-telemetry/opentelemetry-proto/pull/150. I think we can move forward with these changes, and make updates if and when the protos are changed.


Minor typo

webemention.io -> webmention.io

Thank you :)

:tada: This PR is included in version 1.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


documentation around high level architecture

I think it would be nice to have a high level architecture doc to explain the different pieces/stages of fuzz introspector (LTO pass, analysis, html generation etc). This will make it easier for other contributors to implement new features or integrate into other systems/languages.

Fixed in https://github.com/ossf/fuzz-introspector/pull/243


Expression Parser Strictness

While Player is strict about syntactically invalid expressions, it should still be allowed to execute them if the implementation desires. This change exposes the Expression Parser's strict attribute on the Expression Evaluator's hook to allow it to be set via the resolveOptions hook. This change also changes the behavior around throwing those errors to only throw recoverable errors if strict is true.
Change Type (required)
Indicate the type of change your pull request is:

[x] patch
[ ] minor
[ ] major

Release Notes
Expose Expression Parser's strictness option via the resolveOptions hook

/canary


Tilesets visible across all objects, not just objects that have the tileset as a material.

At the moment, if you add a tileset to one object and another tileset to another object, both tilesets will be visible regardless of the object you are focused on in the hierarchy. In order to add an existing tileset to an object, you need to add it as a new material to an object. It would be convenient to be able to hide inaccessible tilesets for a particular object so that they do not clutter the selectable tilesets for a given object.

Showing all the tilemaps is how sprytile normally works. I agree it can be inconvenient because currently you have to manually add the tilemap you are trying to use to the object materials in case it doesn't have it yet. The best approach would probably be to make this happen automatically when you start using the tilemap, but unfortunately I didn't have the time to implement it. (See here on how to manually add the materials: https://itch.io/post/1158224)

Yep, manually adding them works and that's how I've been doing it!
I just don't think I need to see all the tilesets when my objects only use some of them ;)

The beta11 I just released introduces a bunch of improvements in this area. Sprytile will now handle adding absent materials for you, so no need to do it manually. And among the filtering options (which were already there but not functional before this release, like they weren't in the original sprytile) there's now an option to only show the materials added to the selected object, which is what you were asking for. (Default is off, because old sprytile users probably expect to see all the scene materials as usual)

Enjoy!


Correction for raw affiliation Department Research Center STIS, M2CS, National Graduate School of Arts and Crafts of Rabat (ENSAM), Biomedical Engineering, Mohammed V University in Rabat, Rabat, MOROCCO

Correction needed for raw affiliation Department Research Center STIS, M2CS, National Graduate School of Arts and Crafts of Rabat (ENSAM), Biomedical Engineering, Mohammed V University in Rabat, Rabat, MOROCCO
raw_affiliation_name: Department Research Center STIS, M2CS, National Graduate School of Arts and Crafts of Rabat (ENSAM), Biomedical Engineering, Mohammed V University in Rabat, Rabat, MOROCCO
new_rors: 00r8w8f84;02b3gqy34
previous_rors: 00r8w8f84;02b3gqy34;018pp1107
works_examples: W4386541999
contact: df2171217861ff65f767a362d8d86601:f96791795cbb68e0f810a7fc89 @ ensam.eu

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Safe area not covered at the bottom on "Find in Page"

App version:
<IP_ADDRESS>
Device model:
iPhone 11 Pro
iOS version:
iOS 13.4.1
Steps to reproduce the bug:

Go to find "Find in Page"
Search something
Scroll down, or hide keyboard (on iPad Pro)

Expected behavior:
You cannot see the website content behind the home indicator/safe area
Actual behavior:
You can see the website content behind the home indicator/safe area

Tracking this internally at https://app.asana.com/0/inbox/392891325557408/1195769562482255/1195785915763848

Hello! 🙂 Could I help you with it as Hacktoberfest participating?

Hi @pankova - yes, thank you.

Hey @pankova - do you have a timescale for your fix?   Thanks!

Hey @pankova - do you have a timescale for your fix?   Thanks!

Hello! Yes, I faced signing trouble. It seems, I couldn't provide group id. If there is some other way to build project or some test configuration data for external developers, it would be great!

Please see the Developer details section in the readme.  Let me know if you have any further problems.  Thanks!

Hi @pankova - how are you getting on?

Hi @pankova - how are you getting on?

Hello! Sorry, I'm a little overworking, but I plan to finish it!

Hi @pankova - just wondering if you've been able to make any progress?
Since Hacktoberfest finishes on the 31st and we have another PR ready for this fix, can you please submit your PR by the end of October 30.
Or if you're unable to finish this by then, that's fine, we just need to know.
Thanks.

Hi @pankova - just wondering if you've been able to make any progress?
Since Hacktoberfest finishes on the 31st and we have another PR ready for this fix, can you please submit your PR by the end of October 30.
Or if you're unable to finish this by then, that's fine, we just need to know.
Thanks.

Hello! I have made PR some minutes ago :)

Fixed by #761 - thank you @pankova !


KAFKA-2825, KAFKA-2851: Controller failover tests added to ducktape replication tests and fix to temp dir

I closed an original pull request that contained previous comments by Geoff (which are already addressed here), because I got into bad rebase situation. So, I created a new branch and cherry-picked my commits + merged with Ben's changes to fix MiniKDC tests to run on Virtual Box. That change was conflicting with my changes, where I was copying MiniKDC files with new scp method, and temp file was created inside that method. To merge Ben's changes, I added two optional parameters to scp(): 'pattern' and 'subst' to optionally substitute string while spp'ing files, which is needed for krb5.conf file.

@apovzner A few minor comments, and needs rebasing, but this looks good.

@granders I just pushed the changes to address your comments.

Conflicts need resolving on this again unfortunately.

@apovzner, it looks like this was merged via different PRs, would you mind closing this one please?

Closed because the code in this PR was two KAFKA JIRAs so I separated it into two separate PRs and already merged.

I closed an original pull request that contained previous comments by Geoff (which are already addressed here), because I got into bad rebase situation. So, I created a new branch and cherry-picked my commits + merged with Ben's changes to fix MiniKDC tests to run on Virtual Box. That change was conflicting with my changes, where I was copying MiniKDC files with new scp method, and temp file was created inside that method. To merge Ben's changes, I added two optional parameters to scp(): 'pattern' and 'subst' to optionally substitute string while spp'ing files, which is needed for krb5.conf file.


Empty string passed to gh command

Issue Description
Type: bug report
Previewers for issues and prs not working properissue list and pr list results in
gh: Expected NAME, actual: UNKNOWN_CHAR ("") at [49, 35]
when using defaults_to_projects_v2 = true in the config
It seems that the project section of the query that is inserted for the previewer query contains \n characters which might be causing an issue.
Describe what you expected to happen
Old behavior
How to reproduce it (as minimally and precisely as possible)

Set defaults_to_projects_v2 = true in your config
Octo issue list or Octo pr list

Tell us your environment
NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1725453128
gh version 2.55.0 (2024-08-20)
defaults_to_projects_v2 = true in the config

Thanks for reporting @wd60622 Seems like this is caused by #589 so reverting it for now.


Add anonymization transformer

User story
As a user of the smartnoise-synth library, I frequently want to anonymize personally identifiable information (PII) in the data.
Detailed description
To prevent leakage of sensitive information PII is anonymized by an analyst when preprocessing the data. Generating fake data is a solution because it discards existing values and instead uses entirely new ones. The most popular library for this is Faker.
Proposed solution
One possibility would be to follow the idea of the Synthetic Data Vault (SDV) implementation. It integrates Faker and allows a user to pass an anonymize_fields keyword argument. This maps a column to a corresponding provider. Even though that is quite user-friendly, it restricts the usage of more complex generation ideas, e.g. providing a custom implementation.
Therefore, I suggest not to integrate Faker directly, but instead let the user pass a function for generating fake data. Since data transforms can be provided in a TableTransformer object, I suggest implementing a new ColumnTransformer class for anonymization.
Feel free to make suggestions. I will implement the functionality soon.

That's a great idea.  I think it's OK to take a dependency on faker for their built-ins, but I also like the idea of allowing overrides.  As you suggest, this should be possible by deriving snsynth.transform.base.ColumnTransformer .  Since it will be assuming the column is PII, it shouldn't be necessary to implement anything for _fit, just for _transform and _inverse_transform.  Presumably the _transform just scrubs the value, and _inverse_transform generates fake PII when reversing the transform.
The current ColumnTransformer design allows _transform to map from 1 to n columns, with _inverse_transform mapping back from n to 1.  I'm not entirely sure the best way to handle this with, for example, a single column of PII.  Conceptually, the whole PII column is dropped, but then we have nothing to invert back (we can't map 1-->0 and then 0<--1).  An easy choice would be for _transform on the anonymizing ColumnTransformer to emit a column of None that the TableTransformer can then ignore when feeding the synthesizers (and re-inject on reverse transform).  So, the anonymizing column transformer would only emit the column of None when operating standalone or in a ChainTransformer.
Of course, I am assuming that the synthesizers don't want to train on fake PII, so it's best to drop those inbound and add the fakes outbound.  However, there might be cases where someone wants to replace real PII with fakes in both directions, in which case _transform could add fakes.
I'm assuming some of the more common types of PII could be specified when creating the column transformer:
anon = TheNewColumnTransformer(some_prop_to_specify_fake_type='email')
assert(anon.fit_complete)
scrubbed = anon.transform(my_email_list)
reversed_emails = anon.inverse_transform(scrubbed)
assert(len(reversed_emails) == len(my_email_list))

And then maybe that could also take a caller-provided function per your proposal?
If you get the ColumnTransformer implemented, I can plug it in to TableTransformer and the data type inference stuff.  This would actually unblock a feature we want to add for SQL as well, so we can auto-generate metadata.

Thanks for your feedback. I agree on the proposed functionality / API and will start implementing the ColumnTransformer subclass.

Thanks @joshua-oss for implementing the tests and basic PII inference in #515.
I think it is important for a user to be able to read the documented API / examples. Can you rebuild the synthesizers / transforms documentation with the latest additions?


Add Discord and STACK icon

Added icons for the following issuers:

Discord
STACK

Hi @frozenshadow, thanks for the PR! I'm currently on vacation and won't have time to review it for a while. Thanks so much for understanding.

Sure, no problem. Enjoy your vacation!

Hi @frozenshadow, sorry for the delay. I've reviewed and tested this locally and it works great. Thanks so much for contributing!


Error: Steam: user is not authenricate

Hello,
i become follow error
Steam: user is not authenricate

What happens if you go to Addons > Extension Settings > Libraries > Steam and then re-authenticate your account?

What happens if you go to Addons > Extension Settings > Libraries > Steam and then re-authenticate your account?

This works, thanks for the tip

If you haven't already, I also suggest that when you authenticate you check the option to remember the current device. I had issues with SuccessStory randomly failing authentication until I did that.


With tooltips disabled, TypeError: Cannot read property 'update' of undefined

There is a bug if the chart is configured to have disabled tooltips (options: { plugins: { tooltip: { enabled: false } } }):
chartjs-plugin-dragdata.js:1531 Uncaught TypeError: Cannot read property 'update' of undefined
    at Object.beforeEvent (chartjs-plugin-dragdata.js:1531)
    at callback (helpers.segment.js:92)
    at PluginService._notify (chart.esm.js:4922)
    at PluginService.notify (chart.esm.js:4909)
    at Chart.notifyPlugins (chart.esm.js:6047)
    at Chart._eventHandler (chart.esm.js:6069)
    at Chart.update (chart.esm.js:5641)
    at updateData (chartjs-plugin-dragdata.js:1476)
    at HTMLCanvasElement.<anonymous> (chartjs-plugin-dragdata.js:1524)
    at Dispatch.call (chartjs-plugin-dragdata.js:63)```

It seems like the call there does not check whether `chart.tooltip` is nullish.

Good find @artus9033! Issues like this one constantly remind me of why I need to work on #40...
Also thanks for the PR, will merge ASAP

Published in 2.2.4


General enhancement suggestions

Citizens.php:

Is it really useful to test for both GET and POST, it seems to me that this file is requested from only one of this two methods? This is also the case in participation.php, proposal.php, publication.php and publications.php (the function should maybe be put at a common place): https://github.com/directdemocracy-vote/notary/blob/3016e22070eaa5dbeb1859c05fad2a24e3ef0b59/httpdocs/api/citizens.php#L11
The distance seems to be in km but it is specified here that the unit is meter:
https://github.com/directdemocracy-vote/notary/blob/3016e22070eaa5dbeb1859c05fad2a24e3ef0b59/httpdocs/api/citizens.php#L52
Is there a reason to use HAVING instead of WHERE?
https://github.com/directdemocracy-vote/notary/blob/3016e22070eaa5dbeb1859c05fad2a24e3ef0b59/httpdocs/api/citizens.php#L77

endorsements.php: As we do not check on citizen, won't this cause an error if citizen is emtpy:
https://github.com/directdemocracy-vote/notary/blob/3016e22070eaa5dbeb1859c05fad2a24e3ef0b59/httpdocs/api/endorsements.php#L28
Can we remove old_participants.php ?
It would be nice to have a small description at the top of the .php files indicating what they do, like it exists in proposals.php, otherwise it is a bit tedious to understand what they do.
proposals.php: Not clear to me what the deadline is because of the open and year argument
https://github.com/directdemocracy-vote/notary/blob/3016e22070eaa5dbeb1859c05fad2a24e3ef0b59/httpdocs/api/proposals.php#L14
propose.html:

We cannot change the center of the area, so not possible to put the correct village. For example, it was detected that I was in Interlaken whereas it was not the case at all.
A cryptographic key was just forged in in x seconds: it is not clear what it is, what is the use of it, especially as the whole thing is aimed at non-tech people. I would either hide it, or put more information with a link. This remark is also valid in the application when creating a new citizen.

citizen.html:

Error thrown when the judge url does not exist (terminal)

proposal.html:

Can take several seconds to load
The title is not really align and is very small compared to directdemocraty

The .js files have a lot of copy pasted code between them: findGetParameter, parse judge url. initialize map. It could benefit from a refactor.
findGetParameter: simpler way to do it with

const queryString = window.location.search;
const urlParams = new URLSearchParams(queryString);
const param = urlParams.get(parameterName)

For inline defined function, like polyon.forEach or document.getElementById('action-button').addEventListener('click', function(variable) {...});, I prefer the variable => {...} syntax which I find lighter but this is personal.
Referendumand Petition it is possible to create several time the exact same object.
Referendum and petition only display 10 items, a system of pages should be implemented to be able to browse through all referendum and not only 10.

Redirection not working for petition when first trying an incorrect one (for example with 22023 as year) then correcting and validating again: FIXED
-... appears below the judge URL when refreshing for judge-endorsement. From what I could read in citizen.js it is supposed to display something but it does not seem to work: FIXED
Are counting.php and registrations.php used? I could not find any place where they are called: DELETED


Paste/Run cmd as soon as terminal is open

Description
artificialDelayMilliseconds only delays terminal startup, and all commands are pasted at the same time
Setup
I have multiple .Net projects that I need to run for my local dev env
I should cd into each project and execute dotnet run on them to build and run each project
Expected Behavior

First terminal shows up, and runs the command
Wait for artificialDelayMilliseconds
Start second terminal, and go on

Actual Behavior

Terminals are open one by one after artificialDelayMilliseconds and kept empty
All commands get pasted at once
Build issues occur due to concurrency

Config
{
  "restoreTerminals.artificialDelayMilliseconds": 1000,
  "restoreTerminals.terminals": [
    { "splitTerminals": [{ "commands": [" cd ProjectA", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectB", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectC", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectD", "dotnet run"] }] }
  ]
}

Update:
I edited my config to use sleep inside the terminal
{
  "restoreTerminals.artificialDelayMilliseconds": 36,
  "restoreTerminals.terminals": [
    { "splitTerminals": [{ "commands": [" cd ProjectA", " sleep 0", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectB", " sleep 1", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectC", " sleep 2", "dotnet run"] }] },
    { "splitTerminals": [{ "commands": [" cd ProjectD", " sleep 3", "dotnet run"] }] }
  ]
}


Persistence

Tracking ticket for all things that need to be persisted.

[ ] Persist authenticated dynamic dictionaries #275.
[ ] Store blocks in RocksDB and fetch them #9.
[ ] Persist the blockchain between node restarts #113.
[ ] Persist state of the world between node restarts #61.

https://www.pivotaltracker.com/epic/show/3784797


Looks like an amamzing paper! When is the code release?

We are working on releasing the code in the next couple of weeks. Sorry for the wait. I can update you here when it's released.

Great work! Let us know if we can help to make the code release smooth. We'd be glad to chip in as needed.

good work，the code will be released next week？

期待发布！加油！

Thank you, when the pretrained model will be released?

Thank you for your patience. We have put out an initial release, including our pretrained model. To get the model and other thirdparty checkpoints, please refer to the "Prepare data" in the README.


I can't generate the kindsl file  from my urdf file.

I use this tool to generate robcogen file but I get an error:
roslaunch urdf2robcogen cheetah2code.launch
... logging to /home/zpl/.ros/log/0d0dd772-d0a7-11ea-987e-3413e89875f1/roslaunch-work-4531.log
Checking log directory for disk usage. This may take a while.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.

xacro: in-order processing became default in ROS Melodic. You can drop the option.
started roslaunch server http://work:33891/

SUMMARY
========

PARAMETERS
 * /robot_description: <?xml version="1....
 * /rosdistro: melodic
 * /rosversion: 1.14.6
 * /urdf2robcogen/description_name: robot_description
 * /urdf2robcogen/output_folder: /home/zpl/local/s...
 * /urdf2robcogen/robot_name: cheetah
 * /urdf2robcogen/verbose: True

NODES
  /
    urdf2robcogen (urdf2robcogen/urdf2robcogen_node)

auto-starting new master
process[master]: started with pid [4544]
ROS_MASTER_URI=http://localhost:11311

setting /run_id to 0d0dd772-d0a7-11ea-987e-3413e89875f1
process[rosout-1]: started with pid [4555]
started core service [/rosout]
process[urdf2robcogen-2]: started with pid [4558]
[urdf2robcogen] Start generating files.
urdf2robcogen_node: /home/zpl/local/src/cheetah_catkin_ws/src/urdf2robcogen/src/Utils.cpp:63: Eigen::Matrix3d expressInertiaFromFrameAInComFrame(Eigen::Matrix3d, double, PoseInWorld, PoseInWorld): Assertion `isValidInertiaMatrix(C_I_C)' failed.
[urdf2robcogen-2] process has died [pid 4558, exit code -6, cmd /home/zpl/local/src/cheetah_catkin_ws/devel/lib/urdf2robcogen/urdf2robcogen_node __name:=urdf2robcogen __log:=/home/zpl/.ros/log/0d0dd772-d0a7-11ea-987e-3413e89875f1/urdf2robcogen-2.log].
log file: /home/zpl/.ros/log/0d0dd772-d0a7-11ea-987e-3413e89875f1/urdf2robcogen-2*.log

why this error urdf2robcogen_node: /home/zpl/local/src/cheetah_catkin_ws/src/urdf2robcogen/src/Utils.cpp:63: Eigen::Matrix3d expressInertiaFromFrameAInComFrame(Eigen::Matrix3d, double, PoseInWorld, PoseInWorld): Assertion isValidInertiaMatrix(C_I_C)' failed.` occur?
The urdf file is correct when I spawn it to gazebo.
How can I solve this?

Hi,
thanks for reporting the issue. The failing assertion checks that the inertia matrix makes sense physically, e.g., that there is a positive rotational inertia in all directions.
Quick workaround: Disable assertions by compiling in release mode. Note that wrong inertias can make your simulation unstable.
Proposed solution: Check that your URDF does not contain any bodies with invalid inertia tensors. Typically this happens when you specify zero inertia along at least one axis. You may post your URDF so I can take a look.


Deep linking and page URL

From tenfour-archive created by caharding: ushahidi/tenfour-archive#1126

@dale to add spec and estimate

@dalezak is this necessary for the next version of mobile apps? Or can it wait?

The loadDeepLinks method in TenFourApp will need to be updated to the new URL scheme /#/checkins, etc to load the appropriate page in the mobile app and pass the parameters.
We'll also need to investigate how the Deep Links native plugin works with the new routes, since previously we didn't define segment for pages.


did these insane filenames break psarc?

not sure why it cant just be ~merged.pak (or whatnot) at some point ntfs is going to lose its mind over this.

QUESTIONS * Questions are better asked in NMS Discord: "No Man's Sky Modding" channel, "amumss-lua" room: https://discord.gg/HFjnmnwe67
We have channel #amumss-lua dedicated to AMUMSS/NMSPE with helpful modders and Wbertro#8596 (aka TheBossBoy)

FOR HELP WITH INSTALLATION: Refer to https://www.nexusmods.com/nomanssky/mods/2626

Always read the README, it is there for a reason.

That being said:
Follow the INSTALLATION guidelines and that should resolve your problems.  NEVER install in the game folders!!
Wbertro


Fix quark.setLaunchAtLogin in sandbox

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/8672197-fix-quark-setlaunchatlogin-in-sandbox?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F899498&utm_medium=issues&utm_source=github).

Should be fixed in f155883.


Update search.js DOM text reinterpreted as HTML

By using textContent, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

Hi @odbol Could You please Review This PR
Thanks

Hi @odbol or @andreasnilsson  Could You Please Review This PR
Thanks

Hi @odbol Could You Please Review This PR
Thanks

Hi  @andreasnilsson Could You Please Review This PR
Thanks

Hi Shivam, you still haven't shown how this is a vulnerability. Please show some evidence that this fix is necessary, by showing how an attacker can use the vulnerability to gain access. I'm pretty sure it's not possible with this code, because it is not accepting input from the user.
Also please do not keep spamming the issue with comments to look at the PR. Continued spamming will earn a block.


Update idebugengineprogram2-stop.md

The text "No debug event is sent in response to this method." contradicts the text on https://docs.microsoft.com/en-us/visualstudio/extensibility/debugger/reference/idebugstopcompleteevent2 which says that a StopCompleteEvent is sent in response to a program being Stopped in a multi-program debugging situation.
(You can replace all of this text with your description.)
Before creating your pull request, please check your content against these quality criteria:

Did you consider search engine optimization (SEO) when you chose the title in the metadata section and the H1 heading (i.e. the displayed title that starts with a single #)?
For new articles, did you add it to the table of contents?
Did you update the "ms.date" metadata for new or significantly updated articles?
Are technical terms and concepts introduced and explained, and are acronyms spelled out on first mention?
Should this page be linked to from other pages or Microsoft web sites?

For more information about creating content for docs.microsoft.com, see the contributor guide at https://docs.microsoft.com/contribute/.

@snalexp : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@madskristensen Could you review this pull request?
Thanks.

#sign-off


Preset library should watch for new presets

Use a file system watcher and then update the list

Fixed in 9ebc4ea9ab6d384384f2ba3f37e28a3d6908242c


Testing src/app and created skyAppLink directive.

Adjusted testing setup and procedures to include src/app.
Wrote tests for src/app/app.component.ts (not currently at 100%).
Created skyAppLink directive.
Refactored multiple instances of passing envid/svcid into RuntimeConfigParams class.

Codecov Report

Merging #159 into master will not change coverage.
The diff coverage is 100%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update babe3f1...0ef1879. Read the comment docs.


gfootball no obs module

ModuleNotFoundError: No module named 'dizoo.gfootball.envs.ob

The module you mentioned dizoo.gfootball.envs.obs exists here.
Maybe you should check the installation and import codes. If you still have problems, you can add your related screenshot in this issue. We will provide further support.


Partial modernization of docs

This PR aims to improve the docs in two ways.

The standard doxygen design is replaced with a more modern design (https://jothepro.github.io/doxygen-awesome-css/index.html).
I try to improve the doc strings for all integrators and error estimators by using latex instead of ascii. Unicode docs are mostly left untouched for now.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3688
@termi-official
@tzanio
@tzanio + @mlstowell + @acfisher + @v-dobrev
11/29/23
12/13/23
⌛due 12/20/23

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

Is this something we might also want to include in the next release (4.6) or does it require a longer discussion @tzanio @v-dobrev ?

I'll see if I can get the ball rolling on pulling this in.

I just built pulled the branch and built it, and it looks like a significant improvement to the look and feel.

@kmittal2 @psocratis would you be available to review this in the near future?

If things should be done differently feel free to note this here. I think we can work on guidelines for doc strings containing math alongside this PR and update the contributor guidelines to ensure a consistent experience in the docs, as well as a starting point for contributors. But we can also make this a separate issue and PR.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

I like the new Doxygen style in this PR, thanks @termi-official !
Here are some comparisons:

old style
new style

Happy to see that it is not only me liking the style!
Regarding the doc string guidelines, my idea was that we try to enforce tex math and give some examples + the doxygen reference. Regarding unicode math strings, like for example in the doc string for the KellyErrorEstimator, I am not sure if there should be a rule. It gives a slight inconsistens look and feel, but unicode math strings have the advantage that they are easier to read in the source.

I would suggest making the following small change
diff --git a/doc/makefile b/doc/makefile
index 4012074dd..738e223ec 100644
--- a/doc/makefile
+++ b/doc/makefile
@@ -16,7 +16,7 @@ DOXYGEN_CONF = CodeDocumentation.conf
 # doxygen uses: graphviz, latex
 html: $(DOXYGEN_CONF)
 	@# Generate the html documentation
-	@( cat $(DOXYGEN_CONF) ; echo "$(MFEM_DOXYGEN_FLAGS)" ) | doxygen -
+	@( cat $(DOXYGEN_CONF) ; printf "$(MFEM_DOXYGEN_FLAGS)\n" ) | doxygen -
 	@echo "<meta http-equiv=\"REFRESH\" content=\"0;URL=CodeDocumentation/html/index.html\">" > CodeDocumentation.html
 	@cat warnings.log 1>&2
 	@# Generate the log of undocumented methods

which would allow multiple command-line configurations like
make MFEM_DOXYGEN_FLAGS="HAVE_DOT = NO\nHTML_EXTRA_STYLESHEET = "

to make it easy for someone to switch back to the default theme (or to a different theme).

@termi-official -- Do you know what are the customization options for Doxygen Awesome? Can we for example switch dark mode on/off with a button or have the left panel as in https://jothepro.github.io/doxygen-awesome-css/todo.html?

@termi-official -- Do you know what are the customization options for Doxygen Awesome? Can we for example switch dark mode on/off with a button or have the left panel as in https://jothepro.github.io/doxygen-awesome-css/todo.html?

Sorry @tzanio I am not sure if I understand the first question correctly, but I think you are asking for what can be put into the "custom.css" file. In this file you can basically just overwrite all existing css options made by Doxygen Awesome (and hence Doxygen) found here https://github.com/jothepro/doxygen-awesome-css/blob/df88fe4fdd97714fadfd3ef17de0b4401f804052/doxygen-awesome.css#L30. The docs page is here https://jothepro.github.io/doxygen-awesome-css/md_docs_2customization.html and some examples can be found here https://github.com/jothepro/doxygen-awesome-css/discussions/13 .
Regarding the dark mode toggle, see my last commit for support. Some extensions and installation instructions are described here https://github.com/jothepro/doxygen-awesome-css/blob/main/docs/extensions.md . Does this answer the latter question?

Works locally for me. I think we should leave it to Default for now and can introduce a sidebar later, if there are plans for a more involved docs structure which beneifts from it. Without the sidebar the docs also fit better on half of a screen (if you work with multiple parallel windows per screen).

@v-dobrev, @jandrej and @pazner -- do you think we should go forward with this?

We may need to update the doxygen versions we use in CI and for the nightly tests. Is v1.9.8 the minimal version we need (as specified in the new CodeDocumentation.conf.in)? The github action uses v1.9.1 and ends up ignoring and removing a number of options from the new config file, e.g. see https://github.com/mfem/mfem/actions/runs/7133157275/job/19425233629?pr=3688#step:4:29.

With the current configuration, yes, 1.9.8 is the compat bound (see https://www.doxygen.nl/manual/changelog.html#log_1_9_8). If that does not work then we can also tweak the config to some older version. However, I would prefer to update doxygen here if possible, since we already upgrade the docs, also because 1.9.1 is already almost 3 years old and includes a good chunk of bugfixes.

Is this the only place we need to change the Doxygen version for the CI?
Is there an easy way to see what Doxygen packages are available in the GH image we are using for testing?

The official Ubuntu packages do not have newer version of doxygen for jammy (22.04 LTS), see https://packages.ubuntu.com/search?keywords=doxygen.

@v-dobrev, the doxygen version requirement is now mentioned in https://github.com/mfem/mfem/pull/3688/commits/a8b0b35c1d58a5dbacc821b2880d6816299790cd

Can I get more approvals, please?

Merged in next for testing...

I see that the CI for the merge failed, but I cannot see any explicit error. Is this some Github server hiccup or am I missing something else?

I see that the CI for the merge failed, but I cannot see any explicit error. Is this some Github server hiccup or am I missing something else?

I think the CI for the merge commit into next was just canceled because there was another commit to next before all the jobs finished. Everything looks OK to me.

Thanks for suggesting this refresh, @termi-official!
Let's keep pushing on the documentation to make it better 👍


Create alias to the current file

I describe my problem here, basically, I have a file in Dart that looks like this:
library myLibrary;

bool myFunction(String s) => s == null;

extension StringExtensions on String {
  bool get myFunction=> myFunction(this);
}

Where I want to add extensions to previous existing functions, with the same name.
The Dart compiler complains about this, as it can't see the outer myFunction() name, just the getter, inside StringExtensions.
I would like to suggest a feature were we could alias the current file, maybe using library myLibrary as a; so then we could use a for fixing name collisions.

You can just use import the file by name:
import "my_library.dart" as prefix;

bool myFunction(String s) => s == null;

extension StringExtensions on String {
  bool get myFunction=> prefix.myFunction(this);
}

This only works for public (exported) names. For private names, you can rename them without that breaking anyone, so it's not a big issue. For imported names, you are already importing, so importing also with a prefix is not a big change.
All in all, I think the functionality is already available, so all we can add is more convenience. I'm not convinced the problem occurs often enough that it's worth the effort of a language feature.


Ryan Liu Individual Review

Blog Post/Meeting CPT Requirements
Video

Grade: 0.94/1
Feedback:

For your blog, it'd be nice to see some images of what the code acutally does on the frontend
Video is very good, showed input, output, subtitles effectively communicate what is happening
maybe try changing styling so it doesn't look like the teacher repo

Grade: 0.92/1
Feedback:

Blog was very easy to understand. However, the images were not always aligned with the requirement collumn. for example, the image under the "Code that creates like/dislike buttons and updates with each click." I am assuming contributes to the second collegeboard requirement. However, it looks like it is there to answer the "At least one procedure that contributed to the program’s intened purpose where you have defined: the name, return type, one or more parameters:" which it fails to do. I would format the page better and put more space in between images to make it more clear which image connects to which requirement.
The video was well made, however at some points it went way too fast, and I would reccomend adding more captions. For example, at 25 seconds, You went incredibly quick pressing public and search, and I have no idea why or what that does. Add more captions at 25 seconds to explain that portion of the video.


ORC-799: Remove Ubuntu 16 docker test

What changes were proposed in this pull request?
This PR aims to delete Ubuntu 16 docker test.
Why are the changes needed?
According to Ubuntu LTS lifecycle, End of Standard Support of Ubuntu 16 was April 2021. Although End Of Life is still 2024, we can delete it from our test environment for Apache ORC 1.7.0.
How was this patch tested?
N/A (This is a removal of test coverage).

cc @omalley , @wgtmac , @pgaref , @williamhyun .

Thank you, @wgtmac . Merged to master for Apache ORC 1.7.0.


[Question] - What is shaka-player-embedded?

I found the repo: https://github.com/google/shaka-player-embedded
What is it?

I think we created the project today, so you found that fast.
It is a new project to give the features of Shaka Player to native apps (i.e. iOS).  This will be a Framework that allows an iOS app to play streaming media the same as the browser.  It will have a similar looking API as JavaScript and it will be just as easy to use.  You will be able to load a manifest and play the video/audio without any work in your app.

Coming soon!  ;-)

Case closed! Congrats to the attentive detectives :)


Fix npm install failing to download Node headers in run_tests.py

This fixes #3823. When you run node-gyp for the first time for any given Node installation, the first thing it does is download headers for that version of Node. This can fail sometimes due to network issues, so I have moved the step of downloading those files to the pre-build step, which is retried multiple times.

LGTM. Will wait for Jenkins. Maybe I will rebase my PR on top of this once this looks good.

You shouldn't have to. That failure seems pretty rare.

Now it fails with this
Now using node v0.12.7 (npm v2.11.3)
Warning! PATH is not properly set up, '/usr/local/rvm/gems/ruby-2.1.5/bin' is not at first place,
         usually this is caused by shell initialization files - check them for 'PATH=...' entries,
         it might also help to re-add RVM to your dotfiles: 'rvm get stable --auto-dotfiles',
         to fix temporarily in this shell session run: 'rvm use ruby-2.1.5'.
Using /usr/local/rvm/gems/ruby-2.1.5
START: node-gyp-install
Traceback (most recent call last):
  File "tools/run_tests/run_tests.py", line 893, in <module>
    xml_report=args.xml_report)
  File "tools/run_tests/run_tests.py", line 808, in _build_and_run
    newline_on_success=newline_on_success, travis=travis):
  File "/var/local/git/grpc/tools/run_tests/jobset.py", line 391, in run
    if not js.start(cmdline):
  File "/var/local/git/grpc/tools/run_tests/jobset.py", line 312, in start
    self._xml_report))
  File "/var/local/git/grpc/tools/run_tests/jobset.py", line 187, in __init__
    self.start()
  File "/var/local/git/grpc/tools/run_tests/jobset.py", line 200, in start
    env=env)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory


SingleInflight cause response with the wrong ID

package main

import (
	"fmt"

	"github.com/miekg/dns"
)

var c = &dns.Client{
	SingleInflight: true,
}

func main() {
	ch := make(chan *dns.Msg, 3)
	go query(ch)
	go query(ch)
	go query(ch)
	<-ch
	<-ch
	<-ch
}

func query(result chan<- *dns.Msg) {
	m := new(dns.Msg)
	m.SetQuestion(dns.Fqdn("google.com"), dns.TypeA)
	r, _, err := c.Exchange(m, "<IP_ADDRESS>:53")
	if err != nil {
		fmt.Println(err)
		result <- nil
		return
	}
	fmt.Printf("Request ID: %d, Got response ID: %d\n", m.Id, r.Id)
	result <- r
}

Got output:
Request ID: 13836, Got response ID: 13836
Request ID: 24357, Got response ID: 13836
Request ID: 56620, Got response ID: 13836

https://github.com/miekg/dns/blob/34cecfe1b489442934480cec58277b4b39b1a1cd/client.go#L150-L165
Line 161, Should we copy request ID to the new response after we got the copy of response?

Yes, we might actually need to do this. Wonder why this hasn't been flagged
before. People don't care?
Could this be a documentation issue or is it more fundamental?
On Sat, 8 Aug 2020, 17:18 Liming Jin<EMAIL_ADDRESS>wrote:

package main
import (
"fmt"
"github.com/miekg/dns"
)
var c = &dns.Client{
SingleInflight: true,
}
func main() {
ch := make(chan *dns.Msg, 3)
go query(ch)
go query(ch)
go query(ch)
<-ch
<-ch
<-ch
}
func query(result chan<- *dns.Msg) {
m := new(dns.Msg)
m.SetQuestion(dns.Fqdn("google.com"), dns.TypeA)
r, _, err := c.Exchange(m, "<IP_ADDRESS>:53")
if err != nil {
fmt.Println(err)
result <- nil
return
}
fmt.Printf("Request ID: %d, Got response ID: %d\n", m.Id, r.Id)
result <- r
}
https://github.com/miekg/dns/blob/34cecfe1b489442934480cec58277b4b39b1a1cd/client.go#L150-L165
Line 161, Should we copy request ID to the new response after we got the
copy of response?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/issues/1145, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWIWYEFVJ4GTNVUCWV6SLR7VUGFANCNFSM4PYWPR5Q
.

        if resp != nil && shared {
		resp = resp.Copy()
		resp.Id = req.Id
	}

I actually copy this and I don't have any problem.

/close
On Sat, 8 Aug 2020, 18:45 Yasar Alev<EMAIL_ADDRESS>wrote:

    if resp != nil && shared {
  resp = resp.Copy()
  resp.Id = req.Id

}
I actually copy this and I don't have any problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/issues/1145#issuecomment-670949333, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWIW6EDOP5HX7ILGZVO3DR7V6J7ANCNFSM4PYWPR5Q
.

will this fix in next release?


Fix FontAwesome version

Link to the correct FontAwesome version is added

this does not fixes anything, beside we still using old font libraries