[DOC] SlidingWindowSplitter start_with_window default value not consistent

Describe the issue linked to the documentation
https://github.com/alan-turing-institute/sktime/blob/139b9291fb634cce367f714a6132212b0172e199/sktime/forecasting/model_selection/_split.py#L174
It looks like the default value of start_with_window=False, but documentation states that it is True. Not sure which one was intended.
https://github.com/alan-turing-institute/sktime/blob/139b9291fb634cce367f714a6132212b0172e199/sktime/forecasting/model_selection/_split.py#L183
Suggest a potential alternative/fix
Change either the documentation or the default argument to match the other one

Hi @ngupta23 - thanks for raising the issue!
I'd appreciate a PR that changes the docs.

Ok, no problem. What default would you like it to be: True or False?

I'd say we keep the code and adjust the docs, so default should be False.


Attempt to make the examples match their description

The description before the examples state "example of a VM with 1 CPU", but then the cloud properties have "cpu: 2". I assume that this should be "cpu: 1". Both the vSphere and vCloud examples have the same description and cloud properties for the example.

CLA has been received. This PR is cleared to be accepted if appropriate.


Move DynamoDB-specific test to aws directory

Clean up the test added in #791 by adding another package that both users can import.
Cuts out a check on the test name string, and an interface.
The mtime.NowReset() lines are needed to meet the assumption of the chunk fixture.

Also LGTM!


Publish on MELPA

http://melpa.org/

Currently I want to create a small playable game that is look more or less finished as quickly as possible and publish it on MELPA. After that we will gradually implement the rest of the things and gradually publish them as well.
I will link all the necessary issues for that to this issue.

We are finally ready for this! Oh my gosh! I'm so nervous! :)

The PR https://github.com/milkypostman/melpa/pull/3199

The submission is accepted! Let's wait for the next build MELPA and check if everything's ok.


fix: add swagger validate

Signed-off-by: codejuan<EMAIL_ADDRESS>
1.Describe what this PR did

Fixes apis/swagger.yml
Add swagger validate in Makefile

2.Does this pull request fix one issue?

Fixes #125
3.Describe how you did it

Fixes apis/swagger.yml
Add go get swagger in Dockerfile
Add swagger validate in Makefile

4.Describe how to verify it
5.Special notes for reviews

Thanks a lot, @CodeJuan
CI passes, and I think this is OK. But I would like that you come to double check this. @sunyuan3 @Letty5411

LGTM


Write null counts in Parquet statistics when they are known

Describe the bug
The Rust parquet writer writes the thrift equivalent of None when the null count is zero rather than the thrift equivalent of Some(0)
This is inconsistent with the spec and other major implementations (Java and C++)
To Reproduce

Expected behavior
Write Some(0) when null count is known to be zero
Additional context
Part of https://github.com/apache/arrow-rs/issues/6256, but we split out the read/write changes into smaller PRs so adding a special issue here to track it / show up in the release notes

Fixed by @etseidl  in https://github.com/apache/arrow-rs/pull/6490


[BUG] Access denied for guest users

Describe the bug
A clear and concise description of what the bug is.
If you have a guest account and try to access any page , returns an Access Denied.
To Reproduce
Steps to reproduce the behavior:

Create a guest account in your tenant
Add the Mona Administrator role to the user
Log in with your guest email credentials
Receives Access Denied page

Expected behavior
A clear and concise description of what you expected to happen.
Expected to be able to access the page
Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser Chrome
Version 106.0.5249.119

Additional context
Add any other context about the problem here.

Thanks for sharing, @MatheusJacob!
I'm leaning toward not allowing guest users to access Mona admin functions. I know that this seems somewhat limiting but it would be the easiest feature to implement and document. Many Azure services prevent guest users from having access to administrative functions so there's some platform precedence here as well.
Would this design decision be a blocker for you and your team? Do you have a member account in the applicable Azure Active Directory tenant?

Thanks for the answer @caseywatson
Not a blocker on my team, we worked around that already by just logging in with the actual tenant credentials. But not gonna lie, was an annoy error to deal with due to the lack of a specific error message.

We've decided that only workplace/school accounts will be allowed. Any MSA/guest account will return an access denied page. This has been addressed in PRs (#100 and #87)


Switch to use GAPIC build.gradle for Java

Toolkit PR: https://github.com/googleapis/toolkit/pull/1292

LGTM

@lukesneeringer The CI is currently failing (I don't think it is related to my PR) but it is blocking me from merging.


Error when running az appservice ase list-addresses -n ASEName

This is autogenerated. Please review and update as needed.
Describe the bug
When running this command a list of VIP addresses should be the output.  This worked on az cli verison 2.0.78 but started failing when I upgraded to 2.4
Command Name
az appservice ase list-addresses
Errors:
'AppServiceEnvironmentsOperations' object has no attribute 'list_vips'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 631, in execute
    raise ex
cli/core/commands/__init__.py, ln 695, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
azure/cli/core/__init__.py, ln 574, in default_command_handler
    return op(**command_args)
cli/command_modules/appservice/appservice_environment.py, ln 100, in list_appserviceenvironment_addresses
    return ase_client.list_vips(resource_group_name, name)
AttributeError: 'AppServiceEnvironmentsOperations' object has no attribute 'list_vips'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az appservice ase list-addresses -n {}

Expected Behavior
Expected outcome based on command ran in previous versions of AZ CLI (replaced IP addresses with ##):
{
"internalIpAddress": null,
"outboundIpAddresses": [
"##"
],
"serviceIpAddress": "##",
"vipMappings": [
{
"inUse": false,
"internalHttpPort": 20003,
"internalHttpsPort": 20001,
"serviceName": null,
"virtualIp": "##"
},
{
"inUse": false,
"internalHttpPort": 20004,
"internalHttpsPort": 20002,
"serviceName": null,
"virtualIp": "##"
}
]
}
Environment Summary
Linux-4.4.0-18362-Microsoft-x86_64-with-debian-buster-sid
Python 3.6.5
Installer: DEB

azure-cli 2.4.0

Extensions:
application-insights 0.1.1

Additional Context

appservice

bug

Is there any update to the timeline on when this fix will be complete?

@madsd FYI,

closing this since the fix is merged


Update gitignore to be default github for more extensive list of files.

Hey - before merging, can you add back the .DS_Store to the gitignore? It's a file that macOS generates automatically, and I'm on a Mac.

@2231puppy should be good to go now, surprised it was missing those other files but should be good to go now.

Ok, thanks!


Make mocha depend upon scripts, not styles.

Mocha tests don't depend upon proper styling being generated. The scripts however, are the requirement. This addresses that and simplifies the default and all  tasks to take this into account.

After discussion on commit, LGTM. Would like another ACK to make sure I’m not missing anything.

Although, just testing some upgrades locally, Gulp 4 isn't stable yet.


Ensure LFE track is ready for v2 launch

There are a number of things we're going to want to check before the v2 site goes live. There are notes below that flesh out all the checklist items.

[ ] The track has a page on the v2 site: https://v2.exercism.io/tracks/lfe
[ ] The track page has a short description under the name (not starting with TODO)
[ ] The "About" section is a friendly, colloquial, compelling introduction
[ ] The "About" section follows the formatting guidelines
[ ] The code example gives a good taste of the language and fits within the boundaries of the background image
[ ] There are exercises marked as core
[ ] Exercises have rough estimates of difficulty
[ ] Exercises have topics associated with them
[ ] The first exercise is auto_approve: true

Track landing page
The v2 site has a landing page for each track, which should make people want to join it. If the track page is missing, ping @kytrinyx to get it added.
Blurb
If the header of the page starts with TODO, then submit a pull request to https://github.com/exercism/lfe/blob/master/config.json with a blurb key.  Remember to get configlet and run configlet fmt . from the root of the track before submitting.
About section
If the "About" section feels a bit dry, then submit a pull request to https://github.com/exercism/lfe/blob/master/docs/ABOUT.md with suggested tweaks.
Formatting guidelines
In order to work well with the design of the new site, we're restricting the formatting of the ABOUT.md. It can use:

Bold
Italics
Links
Bullet lists
Number lists

Additionally:

Each sentence should be on its own line
Paragraphs should be separated by an empty line
Explicit <br/> can be used to split a paragraph into lines without spacing between them, however this is discouraged.

Code example
If the code example is too short or too wide or too long or too uninteresting, submit a pull request to https://github.com/exercism/ocaml/blob/master/docs/SNIPPET.txt with a suggested replacement.
Exercise metadata
Where the v1 site has a long, linear list of exercises, the v2 site has organized exercises into a small set of required exercises ("core").
If you update the track config, remember to get configlet and run configlet fmt . from the root of the track before submitting.
Topic and difficulty
Core exercises unlock optional additional exercises, which can be filtered by topic an difficulty, however that will only work if we add topics and difficulties to the exercises in the track config, which is in https://github.com/exercism/lfe/blob/master/config.json
Auto-approval
We've currently made any hello-world exercises auto-approved in the backend of v2. This means that you don't need mentor approval in order to move forward when you've completed that exercise.
Not all tracks have a hello-world, and some tracks might want to auto approve other (or additional) exercises.
Track mentors
There are no bullet points for this one :)
As we move towards the launch of the new version of Exercism we are going to be ramping up on actively recruiting people to help provide feedback. Our goal is to get to 100%: everyone who submits a solution and wants feedback should get feedback. Good feedback.
If you're interested in helping mentor the track, check out http://mentoring.exercism.io/

When all of the boxes are ticked off, please close the issue.
Tracking progress in https://github.com/exercism/meta/issues/104

Things that can already be checked off:

The track has a page on the v2 site: https://v2.exercism.io/tracks/lfe
The track page has a short description under the name (not starting with TODO)

Things that need to be completed:

Updating the about section to follow the new guidelines (being worked on in #73)
Set ~8 exercises as core, and set unlocked_by on non-core exercises
Add difficulties to exercises
Add topics to exercises
Add auto_approve to the first exercise (I'm not sure which one this should be, as there is no hello-world exercise for LFE)
Change the code example to fit within the bounds of the display on the track page (see https://v2.exercism.io/tracks/lfe)


CORS issue

There seems to be a CORS issue with the .json end point. I am simply using the end point as a reference for my GitHub README.md Stats. https://github.com/guylepage3
From issue #27.

@brunobritodev, your end point seems to be causing some CORS issues. Is there a way to expose your endpoints to be raw .json data?

The new version #31  are allowing cors from any origin.

Originally posted by @brunobritodev in https://github.com/brunobritodev/awesome-github-stats/issues/27#issuecomment-1496911880
Here's a screencapture to show the issue

Hi @guylepage3,
The cors seems to be working now, it was a misconfiguration at azure app service.

Hi @guylepage3 ,
The cors seems to be working now. It was a misconfiguration at Azure App Service.

Thanks @brunobritodev


Avoiding Memory leaks issues

To use it in really long scripts just reset the object so memory will be freed

@cmorillo thanks for the pr.

Thank you for this project, quite handy.
Cheers


[We See a Way] - Card List block

this issue has been implmented.
https://main--danaher-ls-aem--hlxsites.hlx.page/us/en/we-see-a-way
https://main--danaher-ls-aem--hlxsites.hlx.page/us/en/we-see-a-way/details


Model library

@ethanwhite, @henrykironde and I were discussing that as the number of trained models increase, we probably want some more refined way of versioning them and calling them. Right now they are saved alongside the release tags. Each new model would get a  "use_release" method, with redundant code, etc.
An example release looks like:
https://github.com/weecology/DeepForest/releases/tag/1.0.0
Which is fine. When use_release is called, the model checks github for the latest release. A couple problems.

It doesn't ask the user if they want to use the new release, so any update to the model should be considered breaking. That seems like a big problem and we should atleast ask if we should update.
The metadata doesn't live alongside the model in python. There is a link, but not alot of info.

from deepforest import main
m = main.deepforest()
Reading config file: deepforest_config.yml
m.use_release()
Model from DeepForest release https://github.com/weecology/DeepForest/releases/tag/1.0.0 was already downloaded. Loading model from file.
Loading pre-built model: https://github.com/weecology/DeepForest/releases/tag/1.0.0
m.__release_version__
'https://github.com/weecology/DeepForest/releases/tag/1.0.0'

Torchvision recently released some API improvements. I think they are largely redundant with pytorch lightning.
https://pytorch.org/blog/introducing-torchvision-new-multi-weight-support-api/
I have not read deeply enough to know if they can be used in parallel.

Hey  @bw4sz , I would like to work on this issue, Can you please guide me?

What have you done so far?

It seems like moving to Hugging Face for model distribution is the most common solution here. If we use the pytorch integration:
https://huggingface.co/docs/hub/models-uploading#upload-a-pytorch-model-using-huggingfacehub
then we can use the from_pretrained() method and pass in any of our models (and potentially others models as well; we can wrap from_pretained in use_release as well for backward compatibility):
model.from_pretrained("weecology/deepforest-trees")

I setup an org account https://huggingface.co/weecology and can add @bw4sz & @henrykironde if this sounds like the general way to go.

@henrykironde this will be an issue i'll connect to alive/dead model.

What we want

[ ] a single function that loads models from hugging face that replaces https://github.com/weecology/DeepForest/blob/290062c47a98edc329ca252558d5a4d69198b5b1/deepforest/utilities.py#L55 and https://github.com/weecology/DeepForest/blob/290062c47a98edc329ca252558d5a4d69198b5b1/deepforest/utilities.py#L122
[ ] versioning of the models that takes in a url


Implement sorting for stream

[ ] If this is non-trivial feature, paste the links/URLs to the design doc.

[ ] Update the documentation to include this new feature.

[x] Tests(including UT, IT, E2E) are added to verify the new feature.

[ ] If it's UI related, attach the screenshots below.

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#11474.

[ ] Update the CHANGES log.

You need to resolve the conflicts to make CI running.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (stream-column@c0b259c). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff                @@
##             stream-column     #363   +/-   ##
================================================
  Coverage                 ?   44.93%
================================================
  Files                    ?      169
  Lines                    ?    19222
  Branches                 ?        0
================================================
  Hits                     ?     8637
  Misses                   ?     9821
  Partials                 ?      764

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Is it OK for having the CI fails?


Feature request: Support rfc6570 uri templates

RFC 6570 defines a syntax for uri templates. So that one can declaratively compute uri from variables instead of complex building.
It would be great addition to iri_string.

Already implemented as template module.
Feel free to update and reopen this ticket if you have additional request.

Thanks and sorry. Should have checked docs properly.

Never mind. Happens to everyone.


Supernova Engine in this list?

Supernova is a game engine for 2D and 3D projects with entity component system (ECS) and data-oriented design.
https://github.com/supernovaengine/supernova
https://supernovaengine.org/
Thanks.

hey @eduardodoria can you open a PR adding it to the list? Thanks!


No promot for creating custom config

I tried to install nvchad with this command
git clone https://github.com/NvChad/starter ~/.config/nvim

After installing it Lazy started installing plugins but it didn't ask for creating an example custom config.

that is your config, no custom config from v2.5


Added files for flexible fulfillment and TFW

Summary of the Pull Request

PR Checklist

[ ] Closes Issue #xxx
[ ] Code of Conduct signed. If not, go to Code of Conduct.

Validation Steps Performed

Under review. Please do not merge.

Team will be reviewing this PR on Friday 10th June 2022.
Linting errors are related to usage of the word "websites". We need to use this verbiage as this is what's used across Clarity's public-facing documentation and in the app itself.

Addresses issue https://github.com/microsoft/industry/issues/266


[pattgen] V2.5 TODOs

Description
TODOs defined in pattgen Effort Scoping
D2.5 / V2.5 TODO links (1 d .. 2 d)
dv/tb.sv#L51 connect test bench up and check values (1 d .. 2 d)

Deprioritizing so that we can focus on more important blocks.
CC @moidx

The TODO tracked above was pretty trivial (I think) and should be removed by #22582.
Annoyingly, that's not the only hit when I grep in the block! pattgen_base_vseq.sv contains:
  // TODO: consider optimize the base_vseq to make each channel
  // cfg, start, stop independently with semaphore (PR #4040)

I've had a bit of a look at the PR in question and the discussion is here: https://github.com/lowRISC/opentitan/pull/4040#discussion_r517052156. The background is that @weicaiyang was pointing out that the existing DV code didn't really allow the channels to start/stop across each other. I'm not sure how important this is really, but it's probably less than a day's work to sort out so maybe worth doing.

Marking as a triage priority because I believe this is really a V3 issue (removing a TODO).

Since this is a V3 issue, moving to M7.


Requesting support for Typescript

Kindly requesting the library authors to provide Typescript support

+1

+1

+1


[ACM-11300] Enhance discovery controller to support MultiClusterEngineHCP type discovered clusters

Description
Please provide a brief description of the purpose of this pull request.
Related Issue
https://issues.redhat.com/browse/ACM-11300
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/retest

/retest

/retest

/cc @cameronmwall @ngraham20


Create Remove_duplicates.py

It contains a python program to remove all duplicate words from a string.

Terminal Output:

Great. merged 😊


Add BannedApiAnalyzer and ban direct use of Diagnostic.Create

This is another preparatory refactoring change.
In order to start cleaning up our existing analyzers and making them consistent, add the BannedApiAnalyzer and add a basic BannedSymbols.txt that applies to everything in //src/.
The first thing banned is direct use of Diagnostic.Create() in favor of our DiagnosticExtensions.CreateDiagnostic() extension methods.

There's not a stable package of the banned API analyzer we can use?

There's 3.3.4 from a year ago we can switch to if you'd like.


admin feature: re-cache a protocol

add a feature from the admin page to recache a single protocol, or all protocols in a single step. the current process is to log into the server and initiate a re-caching of protocols.

When calling the cache_subjects directly from the web interface, the call would time out because in come cases caching a protocol will take up to 20 minutes. This function has been updated to remotely trigger a Jenkins job which will cache the given protocol selected by user. This Jenkins job is essentially calling python manage.py cache_subject <protocol # or 'all'>


Autocomplete: suggest procedure/function/package parameters

When you autocomplete a procedure with parameters, it would be great to have pre-filled parameters (like it happens for eclipse with java). For example if I have
CREATE PROCEDURE PROC(FOO IN VARCHAR, BAR IN VARCHAR) AS
--procedure body here
END

I would like to be able to write PR -> CTRL+space -> select PROC  and get
PROC(FOO, BAR)

currently I would get
PROC()

Alternatively (or in addition), there should be a tooltip indicating the list of parameters with their types (Datagrip-like)

Hi @p91paul ,
Seems like this is allmost same  with my issue: #1552.


fix testHelpLink

Type of change

Bugfix

Description

Checklist

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests testcase=io.enmasse.systemtest.isolated.web.FirefoxConsoleTest#testHelpLink

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: pr
TEST_CASE: io.enmasse.systemtest.isolated.web.FirefoxConsoleTest#testHelpLink
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 80


loklak.net and www.loklak.net though are the same hit a CORS error while creating walls

The walls only work on loklak.net and not with www.loklak.net they'll forever load, Would it be possible to redirect all traffic from www.loklak.net => loklak.net from the DNS settings ?

Or probably just in nginx

server {
    server_name www.loklak.net;
    rewrite ^/(.*)$ http://loklak.net/$1 permanent;
}

Should be enough for a 301 redirect from www to non-www, What do you think @treba123 @Orbiter


KFImage won't load image if EmptyView is a placeholder

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
The view I work with is quite complicated, but the whole problem comes down to this:
KFImage(url)
    .placeholder {
        EmptyView()
    }

This placeholder is used here and wrapped with a Group. For the Group only with EmptyView a callback for onAppear won't be called. This causes the image to not be loaded.
Other Comment
Sample code of onAppear behaviour
struct ContentView: View {
    var body: some View {
        Group {
            Color.clear
                .onAppear {
                    print("color clear in group ✅")
                }
            EmptyView()
                .onAppear {
                    print("empty view in group 🔴")
                }
        }
        .onAppear {
            print("group ✅")
        }

        Group {
            EmptyView()
                .onAppear {
                    print("empty view in group 🔴")
                }
        }
        .onAppear {
            print("group 🔴")
        }
    }
}

@damian-rzeszot Nice catch and thank you for reporting this. Does #1973 (the [fix/empty-placeholder-loading](https://github.com/onevcat/Kingfisher/tree/fix/empty-placeholder-loading) branch)  work for you?

Yes, it works great. Thanks for this quick fix :shipit:

After some checking, the same "issue" also happens in SwiftUI's AsyncImage. As Apple mentions in its documentation of EmptyView:

You will rarely, if ever, need to create an EmptyView directly. Instead, EmptyView represents the absence of a view.

I am now wondering if it is a bit anti-pattern to use an EmptyView as the placeholder.
A new PR #1975 was created to fix some broken layout behavior introduced in #1973, while keeping the ability of trigering a loading by EmptyView placeholder. However, I am still suggesting not to use that and maybe try to have a Color.clear placeholder instead.

In my case I got EmptyView from optional Image


remove GOMAXPROCS setting

We don't need set GOMAXPROCS anymore after go 1.6 version

You are right, thanks. Got to remove it for my other repos as well.


Dev

Added Skip and Limit closes #1

Coverage increased (+0.3%) to 83.849% when pulling d49b87c719e343952fcd510a8be4df394645c7b1 on dev into 10cd81b83b3505d18861c2c5a8af9d80703813ed on master.


[GSSOC'23] new feature allows users to create separate lists for dogs, cats, and other pets for easier browsing

I am planning to add a feature to PetMe that would allow users to create separate lists for dogs, cats, and other types of pets. This could be a useful feature for users who are interested in adopting a specific type of pet . Can U please assign Me this project under GSSOC'23

can u assign me this isssue

No I can't assign you this issue , It is my idea

I am interested to work on this issue under GSSoC 2023 as a contributor

No, it is my idea


Use container host's IP:port if we're connected to a swarm master

This PR completes support for Swarm cluster.
This will also pick up any containers running on a remote host that is in the Swarm cluster and uses the host address/port instead of container address/port.

LGTM
That being said, this section of the template is getting to be pretty unmaintainable. It might be nice to use {{define}} and {{template}} to streamline some of the repetitive parts, though I'm not sure how much that would help.

@md5 +1.
I started off by assigning the address object to a chosenAddr variable and doing swarm logic outside the if-else, but couldn't get it to work.

Ping.
Added {{define}} & {{template}} for upstream block.
Added {{define}} & {{template}} for upstream block. Also a simplification
to coalesce .Env.VIRTUAL_PORT "80" to reduce an else block (check commit
diffs).
—
Reply to this email directly or view it on GitHub
https://github.com/jwilder/nginx-proxy/pull/192#issuecomment-120509387.

@viranch Haven't had a chance to test this yet but want to get it merged. @md5 Thanks for reviewing.  If anyone else could help test this PR out with their existing setup that would be very useful.

If it helps, I'm using this patch in production, after thorough testing of course :)

Thanks @viranch!


ModuleNotFoundError: No module named 'settings'

ModuleNotFoundError                       Traceback (most recent call last)
 in ()
1 from chatterbot import ChatBot
----> 2 from settings import GITTER
ModuleNotFoundError: No module named 'settings

You have to create a file called settings.py and put a dictionary in it called GITTER. Your values will look different, but here is an example of what it should look like.
Be sure to replace xxx with a valid Gitter API access token for your account.
In this example, chatter_bot/test_room is the Gitter room designation.
GITTER = {
    'API_TOKEN': 'xxx',
    'ROOM': 'chatter_bot/test_room'
}


Decide on UI/CSS framework

A decision needs to be made on the front end visual framework to be used. Good candidates should either be purely CSS, or be component based and integrate well with React.
A few possibilities:
Material Design - https://material.io/ - or possibly the React component based Material UI http://www.material-ui.com/#/
Bulma - https://bulma.io/
Pure.css - https://purecss.io/

Material Design

I'm open to it, but it seems like it can get pretty heavy. If we kept the styling simple, I think we could make it work

Bulma

Pretty simple to use but we wouldn't be challenging ourselves too much.

Pure.css

From the quick peek I took, I kinda like it so far.

I think using pieces of Pure.css, especially the grid system, and then writing further custom styles could be an interesting approach.
Since we aren't going to be depending upon a huge amount of traditional elements and our game interface will need to be customized anyway, choosing individual components from an existing framework and building what we need would probably be the way to go.

Pure.css looks nice to me from a few minutes of skimming the docs.

Well, then I guess Pure.css it is!

I dig!
It turns out Pure.css is written in plain CSS and doesn't have source available in Sass or Less.
Fortunately we can use SCSS, which is a superset of CSS (meaning that any valid CSS is already valid SCSS).
Pure.css is available as the npm package purecss and can be imported module-by-module something like this:
@import 'purecss/forms';
@import 'purecss/grids';
@import 'purecss/tables';

I'll close this for now because I think we've settled on https://github.com/yahoo/pure
This issue can be reopened if we want to change to a different one later

I think Material Icons would help us make a great interface - https://material.io/icons/
If anyone has any other icon sets they think would be good you should link them here!


Atetelman  bundler

Pull Request Test Coverage Report for Build 45

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 39:
0.0%

Covered Lines:
307

Relevant Lines:
307

💛  - Coveralls

Pull Request Test Coverage Report for Build 45

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 39:
0.0%

Covered Lines:
307

Relevant Lines:
307

💛  - Coveralls

Pull Request Test Coverage Report for Build 45

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 39:
0.0%

Covered Lines:
307

Relevant Lines:
307

💛  - Coveralls

Pull Request Test Coverage Report for Build 45

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 39:
0.0%

Covered Lines:
307

Relevant Lines:
307

💛  - Coveralls

More fixes for https://github.com/arkadiyt/aws_public_ips/issues/5


knexjs.org has expired or otherwise inaccessible

knexjs.org currently just shows the default Namecheap parking page?

Seeing that too.
https://www.isitdownrightnow.com/knexjs.org.html

Is the website source on github? Any suggestion to use the docs offline?

You can access the domain knexjs.org over HTTP (instead of HTTPS where connection times out).

This domain was recently registered at Namecheap.com. Please check back later!
Let's hope the domain hadn't expired and is squatted now...

cc @kibertoad

I'll look into this, thank you.

while this gets sorted out, for anyone else landing here: https://web.archive.org/web/20220307202010/http://knexjs.org/
PS: thanks for a wonderful library!

@tgriesser Do you have any visibility into what happened? I would be happy to pay for knex domain, but it doesn't seem to be available.

@elhigu @OlivierCavadenti I'm considering moving our webpage to GitHub pages, similarly to https://vincit.github.io/objection.js/
what do you think?

As a quick fix, I've updated package.json and and README to point to GitHub URL, and also registered knexjs.net just in case. Waiting to hear from the rest of Knex org before making any further steps.

Ah sorry about this, it was supposed to be on autorenew with the registrar but something seems to have broken there. Just renewed it & figuring out getting it back online, not sure how long that change takes to propagate

Ok this is fixed now, sorry for the trouble - will make sure this doesn't happen again

Thank you!


Obsolate first, then start removing blocking sync looking methods?

Of course, also make sure its async version is available.
Channel 9: Async Library Methods Shouldn't Lie

Libraries shouldn't lie. That's not why they're called "lie-braries"...

For example it is really confusing that I had sync and async RPC methods. In order to became clear to me which ones was the clean implementation, I had to look into the source code.
@NicolasDorier What do you think?

There is no lie, the async methods are really async.  The sync methods are using .GetAwaiter().GetResult() but this can't provoke a deadlock in an event loop because I use ConfigureAwait(false); everywhere.
The synchronous versions are convenience methods I use in unit test because it makes my life easier to write and debug.

Stephen Toub: Should I expose synchronous wrappers for asynchronous methods?

If you expose an asynchronous endpoint from your library, avoid exposing a synchronous method that just wraps the asynchronous implementation. Doing so hides from the consumer the true nature of the implementation, and it should be left up to the consumer how they want to consume the implementation. If the consumer chooses to block waiting for the asynchronous implementation to complete, that’s up to the caller, and they can do so with their eyes wide open.
This is even more important for the “sync over async” case than it is for the “async over sync” case, because for “sync over async,” it can lead to significant problems with the application, such as hangs.

Btw This is perfectly valid:
[Fact]
async Task FooTestAsync()
{
  await BarAsync();
}

and take lot's of keystroke compared to the sync version. In my experiences, tests are painful to debug with async everywhere, as you can't easily see the stack trace and debugger get step bugs.
I think the synchronous versions are very useful for tests and showing simple code to people who don't understand well C#. This is useful convenience methods.

Alright.


Update to streamlit 1.30

In streamlit v1.30 experimental_get_query_params got replaced with query_params that works a little bit different.
I updated the code so it works with a new query_params

Closing in favour of https://github.com/franekp/streamlit-permalink/pull/6


Fix little typo in the documentation

I mean, I was a little confused after copying and paste the code examples into my project ;)

Thank you for the fix


Reverse reverse index

I'm wanting to look up the terms for a given document, that is Document -> Field -> Terms. Something like what term vectors provide in Lucene. (However, I see positions are already stored a little different in Tantivy.)
The use case is things like analysing the term distributions in a document, (for text classification, summarization, highlighting query terms) and copying an individual, indexed documents to another index.
I'm thinking of this like a HashMap<DocId, Vec<Term>> where Term (somehow) is a reference to the Term in the termdict and there will be one of these HashMap<,>  reverse reverse indexes per reverse index segment so we (somehow) need to participate in the merge process. I notice that Lucene.NET has an interface 'IntervedDocConsumer' which is how term vectors (and something called 'freqprox') hook into the indexing chain so maybe that's a place to draw inspiration.
Edit: It looks like Recorder might be the right interface in Tantivy for writing to this new index. For example, TermFrequenceRecorder.
Can you share any initial thoughts in how you might approach this? Even the very first things that come to your mind will likely greatly accelerate me if I am to try and extend Tantivy to support this kind of index.

Some notes as I poke around Tantivy.
Storing terms as a fastfield
I thought this might be implemented with fastfields (columnar storage) which "is designed for the fast random access of some document fields given a document id". However, I can't see a way to actually reading a fastfield for a given document id. Maybe I want something row-oriented instead?
https://github.com/quickwit-oss/tantivy/pull/1325, implementation of fastfield for strings, is likely relevant for writing. However, it looks like the codebase has changed a lot since this PR. (For example, the postings writer no longer seems to pass an 'unordered_term_id' to the fastfield module. )
Getting the terms per document
The token stream for a document is processed into terms in PostingsWriter.index_test
https://github.com/quickwit-oss/tantivy/blob/2f5a269c70855afb983fa3fb5d299fa0001f713f/src/postings/postings_writer.rs#L138-L155
PostingsWriters must implement a subscribe function to handle the doc and term.
https://github.com/quickwit-oss/tantivy/blob/2f5a269c70855afb983fa3fb5d299fa0001f713f/src/postings/postings_writer.rs#L201-L221
SpecializedPostingsWriter<>, for example, instantiates and calls a recorder for each term. However, a recorder does not (currently) have access to the specific term.
https://github.com/quickwit-oss/tantivy/blob/2f5a269c70855afb983fa3fb5d299fa0001f713f/src/postings/recorder.rs#L49-L85
Exposing as an option
This could be exposed as another (or a different kind of) IndexRecordOption which should work if we implement a new recorder or need implement a whole different PostingsWriter.
https://github.com/quickwit-oss/tantivy/blob/2f5a269c70855afb983fa3fb5d299fa0001f713f/src/postings/per_field_postings_writer.rs#L33-L46
Alternatively, it might be nice to enable this per document. For example, so I can just keep this kinda index for the latest ~20% of documents. In which case, maybe this could be implemented as a new field type.

You could load the document from the docstore and tokenize the text to get the terms

You could load the document from the docstore and tokenize the text to get the terms

Ah, but I am not storing this (quite large) text field

The fast field version should work too I think, but the dictionary is not shared between the inverted index and the columnar storage

The fast field (columnar) version should work too I think, but the dictionary is not shared between the inverted index and the columnar storage

Did it used to be shared? I see your contribution here is passing an UnorderedTermId to a column writer.

It can't be shared anymore since a different tokenizer can be defined now


getcurrent position for insteon open/close blinds accessorie

Hello,
first of all I think this is the best plugin for blinds in homebridge.
Is simple, reliable and it works fine also in homekit app with iOS 12.
I was thinking about the "problem" of current status for insteon accessories.
And I wrote this piece of code to retrieve current status for insteon device.
In insteon devices status of a blinds is saved in a buffstatus.xml after  the device is called with a request code 0x19.
example:
http://xxxxx:xxxxx@ip_address:25105/3?02623296C20F1900=I=3
in buff status you will find in BS tag element a string where in a position you will have FF is the blinds is open and 00 if the blinds is closed.
If someone has the time to take a look and give me some hints how to integrate in homebridge-blinds will be awesome, anywise thank you for the great job.
Standalone code is working fine, but I have some problem to integrate in this code.
var XMLHttpRequest = require('node-http-xhr');
var btoa = require('btoa');
var xhttp = new XMLHttpRequest();

xhttp.onreadystatechange = function() {
    if (this.readyState == 3 && this.status == 200) {
        myFunction(this);
    }
};
xhttp.open("GET", "http://ip_address:25105/buffstatus.xml", true);
xhttp.setRequestHeader("Authorization", "Basic " + btoa("xxx:xxxxxx"));
xhttp.withCredentials = true;
xhttp.send();

function myFunction(xml) {
    var xmlDoc = xml.responseText;
    console.log("risultato:" + xmlDoc.substring(52,54));
    if (xmlDoc.substring(52,54)== 'FF')
    {
        this.lastPosition= 1;

    }
}

@xuncia See my changes here: https://github.com/zwerch/homebridge-blinds/pull/22
I think your idea could be integrated quite easily.
I'm wondering if something as simple as modifying the getCurrentPosition function would do it. Instead of sending this.lastPosition you could just amend this the value you like. Also, see #14. If you make progress using this idea we can try to integrate it into the plugin.
BlindsHTTPAccessory.prototype.getCurrentPosition = function(callback) {
    if (this.verbose) {
        this.log(`Requested CurrentPosition: ${this.lastPosition}%`);
    }
    callback(null, this.lastPosition);
}

@xuncia. In the latest release, I've added a feature (position_url) which should accommodate this. I'm not sure how it would work with the polling frequency, but if you decide to revert to this plugin, I'd be happy to continue tuning it.
I'm going to close the issue for now.


Access repos by their ids

closes #1295
closes #648
TODO

[x] add new routes with :repoID
[x] load repo in middleware using :repoID if present
[x] update UI routes :owner/:name to :repoID
[x] load repos using id in UI
[x] add lookup endpoint :owner/:name to :repoID
[x] redirect :owner/:name to :repoID in UI
[x] use badge with :repoID route in UI
[x] update woodpecker-go
[x] check cli
[x] add migrations / deprecation notes
[x] check if #648 got solved directly
[x] Test

[x] create repo
[x] repo pages
[x] ui redirects
[x] forge status links

Codecov Report
Patch coverage: 1.06% and project coverage change: -0.08 :warning:

Comparison is base (f3074dd) 39.26% compared to head (28165a1) 39.19%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   39.26%   39.19%   -0.08%
==========================================
  Files         169      169
  Lines       10815    10824       +9
==========================================
- Hits         4247     4242       -5
- Misses       6292     6307      +15
+ Partials      276      275       -1

Impacted Files
Coverage Δ

cli/internal/util.go
11.94% <0.00%> (+0.67%)
:arrow_up:

cmd/agent/agent.go
4.56% <0.00%> (-0.28%)
:arrow_down:

cmd/agent/main.go
0.00% <0.00%> (ø)

pipeline/backend/docker/docker.go
0.00% <0.00%> (ø)

server/forge/common/status.go
34.09% <0.00%> (ø)

server/forge/gitlab/gitlab.go
18.67% <ø> (+0.11%)
:arrow_up:

server/model/repo.go
0.00% <ø> (ø)

server/store/datastore/feed.go
100.00% <ø> (ø)

woodpecker-go/woodpecker/client.go
11.78% <0.00%> (-0.19%)
:arrow_down:

server/store/datastore/pipeline.go
70.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I think UI routes with org/name should NOT be deprecated and still used as primary (at least for gitea/github) as they makes it so much easier to use for multiple reasons:

You can easily enter them manually if you know them or just change git domain to woodpecker and get to the build list
In my company we heavily use README etc templates and badge URL can be pregenerated in readme as org/name is same as new repositories even before enabling it in woodpecker

☝

I see you point and also thought how it could still be possible to access repos via their name, so I have added the redirect using the lookup endpoint.
On the other hand I can not image that a lot of users are really entering the woodpecker repo url on their own. I would rather say 99% is using links from the status checks of the forge etc, the base url of woodpecker and navigating via UI or the browser history.
There are some problems with the named routes which apply for all forges which are really annoying IMO. When renaming a repo / moving the org, the url changes and therefore all pointing urls in the status checks for example are broken, we would not be able to determine different forges and repos with special names containing slashes like gitlab subprojects are not supported.

I have no problem with gitlab behaving differently as it also uses repo id's in some of their own urls and I don't use it so I don't mind 😆
I'm also fine with changing things on repo if I rename it. But currently our company uses a lot of templates like:

This would be very breaking change for me it these routes would be deprecated 😞

@lafriks Would leaving the badge endpoint supporting both versions and the UI redirect work for you (as it currently is solved in this PR)?

Why not leave it to work both ways without redirect? But that wont be deal breaker for me

I've tried supporting both at the beginning, but it became a mess and was pretty hard to handle. Biggest issue is the slash between owner and repo-name in the route which makes parameter matching in go gin and vue pretty difficult.

Maybe they could use different routes: /<owner>/<repo> and /repos/<id>?

Tried that at the beginning. One issue was that the links of the repo views need to distinguish pointing to the owner-repo or the repo-id route, so we would need to duplicate those views / add some routing helper or always use the repo-id in links again which would result in almost the same way as directly redirecting

@lafriks I changed some parts and removed some deprecation plannings. Would these changes be fine for you:

api routes via id only + lookup endpoint to find repo id
badges via id and owner/name combination
UI via id, owner/name combination will be redirected


Implement add student

As a TA, I can add students to TAPA so that I can know which students are taking my classes.

For this function, I think we can sort the students in alphabetical order after each insert/update, so that we can list them in an alphabetical order easily.


Fix HTTP request errors returned as connectivity errors

Patch

Fix HTTP request errors returned as connectivity errors

poke @tbrebant @olombart

Updated


video upload dont

the possibility to upload the video does not appear, can someone help me? thank you very much

You probably want the Load Video (Upload) node. This one is for (Path).
If you have further issues with that node it should be reported to the corresponding project: https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite


Added unit tests for rotated mnist and adult

Added two tests based on previous pull request #666
Kelvin

added docstrings/ checked files with pyflakes

Travis is failing still because multiple docstring errors

I'll fix.

Ideally we need more through tests epescially for mnist. But since it's been used less we can go as it is for now.
One more comment is, if you're fixing minor issues you can avoid making new commits by using git --amend.
Would you mind cleaning your commit history with git rebase. Git commits should be divided based on the logic not the author's work progress. You need to force push after you clean the history, then it should be ready for merge.

Thanks for the comments, I'll keep that in mind in the future.

Thx!


changes my footer's layout

Hello. My site is at https://denotation.pages.dev
and the source in https://github.com/ribosomerocker/site/blob/master/output/blog.html
The footer changes between pages that contain giscus and pages that don't.
For an example:
https://denotation.pages.dev/posts/sample-post
versus
https://denotation.pages.dev

https://github.com/ribosomerocker/site/blob/e066a3a4ab359a16aed70a4eaf6e66443eacde18/web/templates/post.html#L15-L35
Your template is invalid HTML. The <div id="page"> never gets closed, thus the included footer.html will be in that div. This has nothing to do with giscus.


Don't hide test failures

This is an attempt to solve the issue of a non-blocking failing test.
We (the Guardian) have encountered issues when using the embedded version of sbt. The observed behaviour is that in the case of a test failure the build process continues and produce an artefact. The expected behaviour would be to stop on test failure.
This has been documented at least here, here and here.
I have found that ticket describing what were these lines supposed to do in the first place, but the ticket doesn't explain why it should.
Since I can't find a good justification, and given the potential production issues the current version can cause, I am rising the current PR in the hope it will be merged and released.
I successfully tested the change using @jsancio 's repo but didn't push the change to teamcity to test it in situ as it's not the most obvious set-up to make.
Please let me know if I missed anything obvious and if there's a good reason to hide "Process exited with code 1" as I don't know teamcity very well.
Thanks for your help

@shkate we see you introduced the functionality this PR amends to fix the problem of failing tests not stopping the build process. Do you have any views on how these issues might be reconciled?
https://youtrack.jetbrains.com/issue/TW-47698
Thanks!


Exit visual mode after kommentary_visual_default

hey @b3nj5m1n it would be cool if kommentary_visual_default auto exit visual mode like vim-commentary.
Thanks

Hi, this has already been discussed in #20.


Update APIs to latest

Include logic to apply diffs to known issues
Fixes https://github.com/google/googleapis.dart/issues/218
Fixes https://github.com/google/googleapis.dart/issues/237

ps. consider making config.yaml and CHANGELOG.md changes in a commit separate from the actual generated code.. that way it's possible to review it :D

ps. for future reference consider making config.yaml and CHANGELOG.md changes in a commit separate from the actual generated code.. that way it's possible to review it :D

I'm sorry. I will do better next time.


Adding to "participating-projects" with information on the "toqito" project.

Pull request for adding information on the toqito project for unitaryHack.

Thanks @vprusso, looking forward to it!


[ Question ] Promise (async / await)

2 classes
ClientData and Client
The function client in the ClientData returns an Object with [string]: string.
But the function me in the Client returns an Object (ClientType) with id: number.
The Flow does not warn me I am returning id as a number.
It is a bug?
ClientData.js
class ClientData {
  async client ($: { clientId: string, }): Promise<{ [string]: string, }> {
    const { clientId, } = $;

    const query = `
      SELECT
        *
      FROM
        public.client
      WHERE
        id = $1;
    `;

    return (await this.query(query, [ clientId, ])).rows[0];
  }
}

Client.js
type ClientType = {
  id: number,
};

class Client {
  data: ClientData;

  constructor ($: {}) {
    this.data = new ClientData($);
  }

  async me (): Promise<ClientType> {
    return (await this.data.client({ clientId: this.data.clientId, }));
  }
}

by removing the (useless, here) async and await in Client.me, the error gets thrown.

Not enough info to repro


Remove "plugin initialized" message

Is it possible to turn off the "[nvim-devdocs] Plugin initialized" message on startup?

It should only appear in debug mode, do you have DEBUG_PLENARY set or notification minimal level to debug?

$DEBUG_PLENARY is unset for me, how can I check the notification level?


compatibility

Is not native code currently does not support 1.5 weight loading

Can you post a reproducible snippet? This is too vague of a description.

Let's track CogVideoX1.5 here: https://github.com/a-r-r-o-w/cogvideox-factory/issues/85


Update package.nls.zh-cn.json

For # 使翻译更精准

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

wow, i think it is good

python.command.python.sortImports.title is the name of the command to launch isort on the current file. The effect of this depends on how isort is configured. We cannot take the change the way it is currently suggested.

Closing this since there has been no further updates on this.


MPD: Add Troubleshooting for NodeJS version

@ksuess I am unsure what you intend for my remaining uncommitted comment. Would you please review and clarify? Thank you!

Thank you!

Thanks for reviewing. I should have switched the PR to draft.
The node version needs to be fixed in Volto generator or this training instructions needs to be updated as node lts is not a friend of Volto generator.
I take a snack and revert or update the instructions.

Oops, sorry about that. Is this related?
https://github.com/plone/training/pull/567

https://github.com/plone/training/pull/570


add a Celluloid::Probe.stop() method

For me, this is so tests can shutdown cleanly without spamming the logs with actor crashes, fanout notification failures, etc.
Depends on: https://github.com/celluloid/celluloid/issues/355

@e2 this, I am a big fan of :+1:


Update clusterhq-repo without downloading and re-uploading all its packages

Modify admin/upload-rpms to avoid having to download all the existing RPMs before re-generating the repo metadata.
@tomprince  wrote:

Unfortunately, createrepo needs all the RPMs that will be in the repository present, to build the appropriate metatdata. (I was asking about this in #yum last night, and it appears it might be possible to get around this with the python API).

This may also invalidate the caveat in our release process about not running the pre-populate step unless new dependency packages are required.

http://docs.clusterhq.com/en/latest/gettinginvolved/infrastructure/release-process.html#preliminary-step-pre-populating-rpm-repository

We are moving our development planning to JIRA. This issue is now being tracked at https://clusterhq.atlassian.net/browse/FLOC-863. You are welcome to file additional issues in GitHub if that's easier for you.


2.x support for rxjava2 with 1.6 support, (dont merge)

I've attempted a change as well but run into trouble.

First of all this should target branch 2.x but there is none yet.
The nebula plugin rejects version changes greater than 1, i.e., 0.27.0 -> 2.0.0 crashes the gradle build very early on
I'm not in favor of many design decisions RxSwing took.

Yes, i can not push 2.x, someone would have to pull it and push it from my branch.
The library is still small so changing the design could be done, what is your suggestion @akarnokd ?

Yes, i can not push 2.x, someone would have to pull it and push it from my branch.

This can only work if there is an 1.x branch created and released so git has a 1.x.y tag in its history. Then a new branch out of 1.x can be named 2.x and can be replaced with v2 code.

The library is still small so changing the design could be done, what is your suggestion

I'm still evaluating the design options.


Delete flax.optim.rst

This module no longer exists
What does this PR do?

Fixes # (issue)
Checklist

[x] This PR fixes a minor issue (e.g.: typo or small bug) or improves the docs (you can dismiss the other
checks if that's the case).
[ ] This change is discussed in a Github issue/
discussion (please add a
link).
[x] The documentation and docstrings adhere to the
documentation guidelines.
[ ] This change includes necessary high-coverage tests.
(No quality testing = no merge!)

@andsteing can we delete this now?

cc @jheek @levskaya @IvyZX

@cgarciae - I see some doctest failures of the form AttributeError: module 'jax.test_util' has no attribute 'check_eq' <-- is this a new issue cropping up?

@levskaya never seen this. Is it happening on main too?


Position for Text widget

Hi,
Thank you for this great library!
I am facing position issue for text widget when used it for image editor which has zoom feature.
The text widget cursor position is not visible when image is zoomed in and panned somewhere not in the center of the image. So can we provide option to pass the position for TextDrawable from PainterController?
Thanks.

Closing this issue due to inactivity.


Program crash unable to start

When value of mindailyrate is change to 0.001 as doge rate is too LOW now please fix my half a million doge sitting idle

Try using coinconfig specifically for DOGE, coinconfig doesn't have the strict limitations.
coinconfig = ["DOGE:0.001:2"]

Tried still giving at 0.01 when config was set to 0.0001

coinconfig - coin names must be in CAPS.


⚠ Bofrost.de has degraded performance

In 81c307a, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1952 ms

Resolved: Bofrost.de performance has improved in 5c39307 after 50 minutes.


close buffers safely if an exception is thrown

Closes #2348
Signed-off-by: Rong Ou<EMAIL_ADDRESS>

Hmm why do we have separate close and free calls? When the refcount goes to 0, shouldn't a buffer be automatically freed?

why do we have separate close and free calls?

Because there's a semantic difference between "I'm done with this buffer" and "I want this buffer to release its contents ASAP", and I didn't want to rely on arbitrary users of the spill buffer to get the ref counting correct (it is quite easy to accidentally double-close).  If we go solely off the ref count then a user who accidentally double-closes ends up freeing the buffer too soon rather than getting a double-close error as they do today.

This seems pretty confusing as we are mixing metaphors with c-style free() and java-style AutoCloseable/try-with-resources. And the underlying DeviceMemoryBuffer does free on last close.


Specify explicit types for middleware in test/middleware_test.dart

Currently, the correct list types are inferred from the context.
However, an upcoming Dart 2.0 language change
(https://github.com/dart-lang/sdk/issues/32152) will break the
connection between callable classes and their corresponding function
types, which will prevent type inference from being able to infer
these list types anymore.
To prepare for the language change, we need to specify the list types
explicitly.

Looks good, thanks for helping out :)


Lerna icon is too dark (dark theme)

[x] I'm sure this issue is not a duplicate?

We should provide a better icon for dark themes.

hbs icon also too dark in vscode dark theme ..

@rohithramachandran Please make a new issue.

@JimiC Sure ..
Thanks


Merge branch 'main' of https://github.com/abhiwand/transformers into …

…tile.resolvegithub
What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Semi-valid syntax is parsed without error in the playground, but not when run normally.

Sample Code:
require "json"
require "spec"

module Time::Span::SecondConverter
  extend self

  def from_json(pull)
    Span.new seconds: pull.read_int, nanoseconds: 0
  end

  def to_json(span, builder)
    builder.number(span.total_seconds)
  end
end

module Time::Span::NanosecondConverter
  extend self

  def from_json(pull)
    Span.new nanoseconds: pull.read_int
  end

  def to_json(span, builder)
    builder.number(span.total_nanoseconds)
  end
end

struct Message
  JSON.mapping({"source"    => String,
                "timestamp" => {type: Time::Span?,
                                converter: Time::Span::SecondConverter}})
end

describe Message do
  describe ".from_json" do
    it "works" do
      subject = Message.new JSON::PullParser.new <<-JSON
  { "source": "https://example.com/path/to/video.mp4",
    "command": "play",
    "timestamp": 353 }
JSON
      subject.source.should eq "https://example.com/path/to/video.mp4"
      subject.timestamp.should eq 353.seconds
    end
  end
end

struct SerializeMessage
  include JSON::Serializable
  # the link to the video that is being streamed.
  property source : String
  # The play and pause commands need to send their timestamps
  # to aid in resynchronizing a stream which has potentially fallen out of
  # sync.
  @[JSON::Field(converter : Time::Span::SecondConverter)]
  property timestamp : Time::Span?
end

describe SerializeMessage do
  describe ".from_json" do
    it "works" do
      subject = Message.new JSON::PullParser.new <<-JSON
  { "source": "https://example.com/path/to/video.mp4",
    "command": "play",
    "timestamp": 353 }
JSON
      subject.source.should eq "https://example.com/path/to/video.mp4"
      subject.timestamp.should eq 353.seconds
    end
  end
end

Both specs pass, despite the extra space on line 55 ...Field(converter : Time.... When I tried reducing the code sample to something minimal (sample below), as expected it did not work.
require "json"
require "spec"

module Time::Span::SecondConverter
  extend self

  def from_json(pull)
    Span.new seconds: pull.read_int, nanoseconds: 0
  end

  def to_json(span, builder)
    builder.number(span.total_seconds)
  end
end

describe Message do
  describe ".from_json" do
    it "works" do
      subject = Message.new JSON::PullParser.new <<-JSON
  { "source": "https://example.com/path/to/video.mp4",
    "command": "play",
    "timestamp": 353 }
JSON
      subject.source.should eq "https://example.com/path/to/video.mp4"
      subject.timestamp.should eq 353.seconds
    end
  end
end

struct Message
  include JSON::Serializable
  # the link to the video that is being streamed.
  property source : String
  # The play and pause commands need to send their timestamps
  # to aid in resynchronizing a stream which has potentially fallen out of
  # sync.
  @[JSON::Field(converter : Time::Span::SecondConverter)]
  property timestamp : Time::Span?
end

@dscottboggs please can you reduce code? This will help to identify where is the problem.

no this was my mistake. It's just that thing crystal does where if you never call out to your code it never gets parsed. I messed up my sample code on line 62.
An error is raised as expected when the sample spec actually calls out to the correct code.


Update styles.css

[ ] Solved an issue/task
Fixed #1595
What is the new behavior?
Added class red css in styles.css
Other information

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


ISSUE INSTALLING SAMI IN LARAVEL5.2.3

I am trying to write documentation for a laravel 5.2.3 project and I intend to use Sami to acheive this.
I followed the the git hub link https://github.com/FriendsOfPHP/Sami and I tried to install using composer
composer require sami/sami
But I keep getting the error,
Using version ^3.3 for sami/sami ./composer.json has been updated Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages.
Problem 1 - Installation request for sami/sami ^3.3 -> satisfiable by sami/sami[v3.3.0]. - Conclusion: remove symfony/console v3.1.5 - Conclusion: don't install symfony/console v3.1.5 - sami/sami v3.3.0 requires symfony/console ~2.1 -> satisfiable by symfony/console[v2.1.0, v2.1.1, v2.1.10, v2.1.11, v2.1.12, v2.1.13, v2.1.2, v2.1.3, v2.1.4, v2.1.5, v2.1.6, v2.1.7, v2.1.8, v2.1.9, v2.2.0, v2.2.1, v2.2.10, v2.2.11, v2.2.2, v2.2.3, v2.2.4, v2.2.5, v2.2.6, v2.2.7, v2.2.8, v2.2.9, v2.3.0, v2.3.1, v2.3.10, v2.3.11, v2.3.12, v2.3.13, v2.3.14, v2.3.15, v2.3.16, v2.3.17, v2.3.18, v2.3.19, v2.3.2, v2.3.20, v2.3.21, v2.3.22, v2.3.23, v2.3.24, v2.3.25, v2.3.26, v2.3.27, v2.3.28, v2.3.29, v2.3.3, v2.3.30, v2.3.31, v2.3.32, v2.3.33, v2.3.34, v2.3.35, v2.3.36, v2.3.37, v2.3.38, v2.3.39, v2.3.4, v2.3.40, v2.3.41, v2.3.42, v2.3.5, v2.3.6, v2.3.7, v2.3.8, v2.3.9, v2.4.0, v2.4.1, v2.4.10, v2.4.2, v2.4.3, v2.4.4, v2.4.5, v2.4.6, v2.4.7, v2.4.8, v2.4.9, v2.5.0, v2.5.1, v2.5.10, v2.5.11, v2.5.12, v2.5.2, v2.5.3, v2.5.4, v2.5.5, v2.5.6, v2.5.7, v2.5.8, v2.5.9, v2.6.0, v2.6.1, v2.6.10, v2.6.11, v2.6.12, v2.6.13, v2.6.2, v2.6.3, v2.6.4, v2.6.5, v2.6.6, v2.6.7, v2.6.8, v2.6.9, v2.7.0, v2.7.1, v2.7.10, v2.7.11, v2.7.12, v2.7.13, v2.7.14, v2.7.15, v2.7.16, v2.7.17, v2.7.18, v2.7.19, v2.7.2, v2.7.3, v2.7.4, v2.7.5, v2.7.6, v2.7.7, v2.7.8, v2.7.9, v2.8.0, v2.8.1, v2.8.10, v2.8.11, v2.8.12, v2.8.2, v2.8.3, v2.8.4, v2.8.5, v2.8.6, v2.8.7, v2.8.8, v2.8.9]. - Can only install one of: symfony/console[v2.3.10, v3.1.5]. - Can only install one of: symfony/console[v2.3.11, v3.1.5]. - Can only install one of: symfony/console[v2.3.12, v3.1.5]. - Can only install one of: symfony/console[v2.3.13, v3.1.5]. - Can only install one of: symfony/console[v2.3.14, v3.1.5]. - Can only install one of: symfony/console[v2.3.15, v3.1.5]. - Can only install one of: symfony/console[v2.3.16, v3.1.5]. - Can only install one of: symfony/console[v2.3.17, v3.1.5]. - Can only install one of: symfony/console[v2.3.18, v3.1.5]. - Can only install one of: symfony/console[v2.3.19, v3.1.5]. - Can only install one of: symfony/console[v2.3.20, v3.1.5]. - Can only install one of: symfony/console[v2.3.21, v3.1.5]. - Can only install one of: symfony/console[v2.3.22, v3.1.5]. - Can only install one of: symfony/console[v2.3.23, v3.1.5]. - Can only install one of: symfony/console[v2.3.24, v3.1.5]. - Can only install one of: symfony/console[v2.3.25, v3.1.5]. - Can only install one of: symfony/console[v2.3.26, v3.1.5]. - Can only install one of: symfony/console[v2.3.27, v3.1.5]. - Can only install one of: symfony/console[v2.3.28, v3.1.5]. - Can only install one of: symfony/console[v2.3.29, v3.1.5]. - Can only install one of: symfony/console[v2.3.30, v3.1.5]. - Can only install one of: symfony/console[v2.3.31, v3.1.5]. - Can only install one of: symfony/console[v2.3.32, v3.1.5]. - Can only install one of: symfony/console[v2.3.33, v3.1.5]. - Can only install one of: symfony/console[v2.3.34, v3.1.5]. - Can only install one of: symfony/console[v2.3.35, v3.1.5]. - Can only install one of: symfony/console[v2.3.36, v3.1.5]. - Can only install one of: symfony/console[v2.3.37, v3.1.5]. - Can only install one of: symfony/console[v2.3.38, v3.1.5]. - Can only install one of: symfony/console[v2.3.39, v3.1.5]. - Can only install one of: symfony/console[v2.3.40, v3.1.5]. - Can only install one of: symfony/console[v2.3.41, v3.1.5]. - Can only install one of: symfony/console[v2.3.42, v3.1.5]. - Can only install one of: symfony/console[v2.4.10, v3.1.5]. - Can only install one of: symfony/console[v2.4.2, v3.1.5]. - Can only install one of: symfony/console[v2.4.3, v3.1.5]. - Can only install one of: symfony/console[v2.4.4, v3.1.5]. - Can only install one of: symfony/console[v2.4.5, v3.1.5]. - Can only install one of: symfony/console[v2.4.6, v3.1.5]. - Can only install one of: symfony/console[v2.4.7, v3.1.5]. - Can only install one of: symfony/console[v2.4.8, v3.1.5]. - Can only install one of: symfony/console[v2.4.9, v3.1.5]. - Can only install one of: symfony/console[v2.5.0, v3.1.5]. - Can only install one of: symfony/console[v2.5.1, v3.1.5]. - Can only install one of: symfony/console[v2.5.10, v3.1.5]. - Can only install one of: symfony/console[v2.5.11, v3.1.5]. - Can only install one of: symfony/console[v2.5.12, v3.1.5]. - Can only install one of: symfony/console[v2.5.2, v3.1.5]. - Can only install one of: symfony/console[v2.5.3, v3.1.5]. - Can only install one of: symfony/console[v2.5.4, v3.1.5]. - Can only install one of: symfony/console[v2.5.5, v3.1.5]. - Can only install one of: symfony/console[v2.5.6, v3.1.5]. - Can only install one of: symfony/console[v2.5.7, v3.1.5]. - Can only install one of: symfony/console[v2.5.8, v3.1.5]. - Can only install one of: symfony/console[v2.5.9, v3.1.5]. - Can only install one of: symfony/console[v2.6.0, v3.1.5]. - Can only install one of: symfony/console[v2.6.1, v3.1.5]. - Can only install one of: symfony/console[v2.6.10, v3.1.5]. - Can only install one of: symfony/console[v2.6.11, v3.1.5]. - Can only install one of: symfony/console[v2.6.12, v3.1.5]. - Can only install one of: symfony/console[v2.6.13, v3.1.5]. - Can only install one of: symfony/console[v2.6.2, v3.1.5]. - Can only install one of: symfony/console[v2.6.3, v3.1.5]. - Can only install one of: symfony/console[v2.6.4, v3.1.5]. - Can only install one of: symfony/console[v2.6.5, v3.1.5]. - Can only install one of: symfony/console[v2.6.6, v3.1.5]. - Can only install one of: symfony/console[v2.6.7, v3.1.5]. - Can only install one of: symfony/console[v2.6.8, v3.1.5]. - Can only install one of: symfony/console[v2.6.9, v3.1.5]. - Can only install one of: symfony/console[v2.7.0, v3.1.5]. - Can only install one of: symfony/console[v2.7.1, v3.1.5]. - Can only install one of: symfony/console[v2.7.10, v3.1.5]. - Can only install one of: symfony/console[v2.7.11, v3.1.5]. - Can only install one of: symfony/console[v2.7.12, v3.1.5]. - Can only install one of: symfony/console[v2.7.13, v3.1.5]. - Can only install one of: symfony/console[v2.7.14, v3.1.5]. - Can only install one of: symfony/console[v2.7.15, v3.1.5]. - Can only install one of: symfony/console[v2.7.16, v3.1.5]. - Can only install one of: symfony/console[v2.7.17, v3.1.5]. - Can only install one of: symfony/console[v2.7.18, v3.1.5]. - Can only install one of: symfony/console[v2.7.19, v3.1.5]. - Can only install one of: symfony/console[v2.7.2, v3.1.5]. - Can only install one of: symfony/console[v2.7.3, v3.1.5]. - Can only install one of: symfony/console[v2.7.4, v3.1.5]. - Can only install one of: symfony/console[v2.7.5, v3.1.5]. - Can only install one of: symfony/console[v2.7.6, v3.1.5]. - Can only install one of: symfony/console[v2.7.7, v3.1.5]. - Can only install one of: symfony/console[v2.7.8, v3.1.5]. - Can only install one of: symfony/console[v2.7.9, v3.1.5]. - Can only install one of: symfony/console[v2.8.0, v3.1.5]. - Can only install one of: symfony/console[v2.8.1, v3.1.5]. - Can only install one of: symfony/console[v2.8.10, v3.1.5]. - Can only install one of: symfony/console[v2.8.11, v3.1.5]. - Can only install one of: symfony/console[v2.8.12, v3.1.5]. - Can only install one of: symfony/console[v2.8.2, v3.1.5]. - Can only install one of: symfony/console[v2.8.3, v3.1.5]. - Can only install one of: symfony/console[v2.8.4, v3.1.5]. - Can only install one of: symfony/console[v2.8.5, v3.1.5]. - Can only install one of: symfony/console[v2.8.6, v3.1.5]. - Can only install one of: symfony/console[v2.8.7, v3.1.5]. - Can only install one of: symfony/console[v2.8.8, v3.1.5]. - Can only install one of: symfony/console[v2.8.9, v3.1.5]. - Can only install one of: symfony/console[v2.1.0, v3.1.5]. - Can only install one of: symfony/console[v2.1.1, v3.1.5]. - Can only install one of: symfony/console[v2.1.10, v3.1.5]. - Can only install one of: symfony/console[v2.1.11, v3.1.5]. - Can only install one of: symfony/console[v2.1.12, v3.1.5]. - Can only install one of: symfony/console[v2.1.13, v3.1.5]. - Can only install one of: symfony/console[v2.1.2, v3.1.5]. - Can only install one of: symfony/console[v2.1.3, v3.1.5]. - Can only install one of: symfony/console[v2.1.4, v3.1.5]. - Can only install one of: symfony/console[v2.1.5, v3.1.5]. - Can only install one of: symfony/console[v2.1.6, v3.1.5]. - Can only install one of: symfony/console[v2.1.7, v3.1.5]. - Can only install one of: symfony/console[v2.1.8, v3.1.5]. - Can only install one of: symfony/console[v2.1.9, v3.1.5]. - Can only install one of: symfony/console[v2.2.0, v3.1.5]. - Can only install one of: symfony/console[v2.2.1, v3.1.5]. - Can only install one of: symfony/console[v2.2.10, v3.1.5]. - Can only install one of: symfony/console[v2.2.11, v3.1.5]. - Can only install one of: symfony/console[v2.2.2, v3.1.5]. - Can only install one of: symfony/console[v2.2.3, v3.1.5]. - Can only install one of: symfony/console[v2.2.4, v3.1.5]. - Can only install one of: symfony/console[v2.2.5, v3.1.5]. - Can only install one of: symfony/console[v2.2.6, v3.1.5]. - Can only install one of: symfony/console[v2.2.7, v3.1.5]. - Can only install one of: symfony/console[v2.2.8, v3.1.5]. - Can only install one of: symfony/console[v2.2.9, v3.1.5]. - Can only install one of: symfony/console[v2.3.0, v3.1.5]. - Can only install one of: symfony/console[v2.3.1, v3.1.5]. - Can only install one of: symfony/console[v2.3.2, v3.1.5]. - Can only install one of: symfony/console[v2.3.3, v3.1.5]. - Can only install one of: symfony/console[v2.3.4, v3.1.5]. - Can only install one of: symfony/console[v2.3.5, v3.1.5]. - Can only install one of: symfony/console[v2.3.6, v3.1.5]. - Can only install one of: symfony/console[v2.3.7, v3.1.5]. - Can only install one of: symfony/console[v2.3.8, v3.1.5]. - Can only install one of: symfony/console[v2.3.9, v3.1.5]. - Can only install one of: symfony/console[v2.4.0, v3.1.5]. - Can only install one of: symfony/console[v2.4.1, v3.1.5]. - Installation request for symfony/console (locked at v3.1.5) -> satisfiable by symfony/console[v3.1.5].
Is Sami not compatible with Laravel 5.2.3? Because I also tried adding a lower sympony version(~2.6) but an error was displayed indicating the minimum sympony version for laravel 5.2.3 is 3.1.5.
What should i do?

I was having this issue earlier today. What worked for me was this:

Deleting the vendor directory
Deleting the composer.lock file
Adding "sami/sami": "3.3.*" to the "require-dev" key in composer.json
Running composer install to install all the dependencies from scratch

Then I realized I didn't want to have to re-install Sami as a dependency in each project so I just downloaded the .phar file through cURL, placed it in my PATH, and then I was able to execute "sami" from anywhere on my filesystem.

Closing as you should use the phar instead of adding Sami as a dependency in your project.


Find in Files not Working in Folder with Multiple Large Files

Issue Type: Bug
I am searching logs for an error string (using Cmd+Shift+F) in my folder workspace, which has ~30 files each at around 100,000 lines. I know what I am searching for is present in these files, yet searching for it via this method returns no results. When I do regular Cmd+F in one file at a time, I find 5 occurrences.
~Cmd+Shift+F finds some results when I search a small piece of the error. For example "getReturn" find many results, but "getReturnR" (R is just the next letter of the function name) returns zero results. There are actually many occurrences of this function throughout the logs though.~ Updated info about this here.
VS Code version: Code 1.31.1 (1b8e8302e405050205e69b59abb3559592bb9e60, 2019-02-12T02:16:38.656Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2700)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.97GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I forgot to include that I tried this on the Insiders version and it was the same result.

So this isn't a regex search right? Is it possible that there is a hidden character or something else in that file? Would be awesome if you can upload the file and the search string. Being a large file is probably not the issue.
Or we can try to reduce it, e.g. delete everything around that function name, check if it still happens, and then upload the file.

I have something to add: The Cmd+Shift+F search does not work when there are no editors open. As soon as a file with the search string is opened into an editor, it will find the results in the file. It's not a big revelation as I already put that Cmd+F works which implies an open editor to begin with.

So... nope, it is not a regex search. There is definitely no hidden character(s), in fact if I delete it out of the log and manually type it back in to the same line, it still shows no results.
If I copy the line into a separate file, it comes up in the results.
If I copy the error to the top of the same log, the search finds that error I copied (line 2) but not the original. (The original in this one particular log happens on like 33,704).

I found out something in relation to my original comment where I stated "getReturn" vs "getReturnR" having results vs no results.
Just "getReturn" finds many results but still DOES NOT return results for my desired line. This took a long time to find out because there were an extreme number of matches on getReturn but there's only 5 expected "getReturnR..." search results. In other words, the last 'R' really has no bearing on the search working or not and has turned out to be a misleading piece of information.

Okay so I figured out a part of the issue but discovered another facet of this problem.

The good news) You were right about hidden characters, I was only thinking to search for them inside the line my search string was looking for. But about 32,000 lines beforehand are two hidden null characters (0x00). So my assumption is it's causing a preemptively null-terminated string that is used in the search logic. Removing this line causes "getReturnR" to show results inside the file now as expected.

The bad news) I discovered that adding any characters from the line above my expected search result makes the search to work correctly - and that's with the null characters still present. So I have no idea why the null character wouldn't still break that search.
For example, it goes something like this:

line 33684: <timedate stamp> Class.function() java.lang.NullPointerException
line 33685: (tab)at com.blah.blah.blah.Class.getReturnRecognition(Class.java:100)

If I copy it and search for:
java.lang.NullPointerException(newline)
(tab)at com.blah.blah.blah.Class.getReturnRecognition(Class.java:100)

It finds results.
Even if I just search for the last 'n' of of the word "exception" to the 'a' in "at", it works.
n(newline)
(tab)a

Shows all my expected search results.

Thanks for the investigation, yes, a null byte would explain it. When ripgrep enounters a null byte, it decides that the file is binary data and silently stops searching it.
I'm not sure why you still got a result from the line before. rg is probably searching the file in chunks in parallel, and the behavior may not be 100% predictable here.
Also note that if the file is open it's searched by the editor, and you will probably always get results then, so make sure you aren't comparing a search where the file was open to one where it was not.

For future reference, I was not comparing an open editor to a closed editor. Unfortunate that it turns out to be an intended feature of ripgrep, but it does seem that it contains a flag to allow searching of binary files. Hopefully this can be possibly supported in the future.

Hey @rebornix I'm curious, how does the editor decide that a file is a binary file? I guess one annoying thing is that ripgrep and the editor have different definitions so that the file renders fine in the editor but isn't searched by ripgrep.
I'm not sure I can enable that flag on rg anyway since it might change how normal newlines are processed,

Enabling this option causes ripgrep to use NUL as a line terminator instead of the default of '\n'.

And it would end up spending a lot of time searching all the .pngs or whatever in a workspace.

@roblourens AFAIK the file/editor service will treat the file as Binary if the auto detection failed, and that's probably when it disagrees with ripgrep on whether the file is binary or not https://github.com/microsoft/vscode/blob/master/src/vs/workbench/services/files/node/fileService.ts#L517 .


Add p-top to common models parameter

Add p-top (here is OpenAI docs on p-top) as a param in BaseLLMAPIClient.text_completion.
You can take a look at this great PR done by @EyalPaz-700 and see how he added max_tokens and temperature into BaseLLMAPIClient.text_completion params

https://github.com/uripeled2/llm-client-sdk/pull/29


Non-informative incorrect behaviour when using bad token (at least on windows x64)

The cli says the login was successful whether the token is valid or not.
Steps to reproduce:
ipinfo login
Write any random string. The CLI does not validate it. It will say the token was configured.
ipinfo <IP_ADDRESS>
The CLI informs the credentials and the token is incorrect, even though the login subcommand previously informed the token is correct.

Thanks for flagging this. The login command should definitely confirm it's a valid token by making a requests.

Would we wanna check against the normal, core API, or introduce a new API for this just to check token validity? (with rate limits to prevent brute force token enumeration)

@UmanShahzad one option would be to just make a request with the input token and look for errors. Like checking the client's IP.

True. If that quota is really a concern, we could have tokens signed with a HMAC or could addapt the site to generate JWTs, wich are already signed. The CLI could contain the public key and the server could sign them with a private key using asymetric cryptography, like RSA or ECDSA. However, I imagine changing the entire process for generating tokens might be overkill if we just want to prevent one request being discounted from the quota.

That is definitely overkill. Introducing an API that returns "true" or "false" for a token's validity sounds easier.
I'll get on it next week.

You can hit /me to check if the token is valid without using quota

I think a new API wouldn't even be neccesary. You could check a random IP address, or myip and check if there are any auth errors.

@coderholic Ah I was thinking we never properly publicized that API, but if you're okay with it then let's use that.
@eacp If the token was valid in that case, it would use up quota, going back to the original issue.

So, should I make a PR to use the /me api?

@eacp If you could that'd be great!

@UmanShahzad Done https://github.com/ipinfo/cli/pull/58


track down problem in the CUDA stream implementation of bulk

See the nvexec/reduce example in the nvexec-bulk-bug branch for a repro, or just run the tests.
Attached is a dump from compute-sanitizer.
error.log

Reproducer from the branch:
      // ...
  |   stdexec::let_value(
          [](std::span<double> out){ return stdexec::just(out); })
  |   stdexec::bulk(nelems,
          [](std::size_t i, std::span<double> out){ out[i] = 2.0 * out[i]; });

What's happening on the implementation side:

gpu: invokes return stdexec::just(out);
cpu: copies resulting sender from gpu to cpu
cpu: connects resulting sender and starts operation state
cpu: stdexec::just operation state passes rvalue reference to completion channel
cpu: nvexec::bulk invokes kernel with lvalue reference to span stored in cpu memory
gpu: nvexec::bulk kernel accesses lvalue reference to span stored in cpu memory -> issue

cpu: copies resulting sender from gpu to cpu

Where in the code is that copy happening?

cpu: copies resulting sender from gpu to cpu

Where in the code is that copy happening?

It's happening in the pointer dereferencing after stream synchronization.

Reproducer from the branch:
      // ...
  |   stdexec::let_value(
          [](std::span<double> out){ return stdexec::just(out); })
  |   stdexec::bulk(nelems,
          [](std::size_t i, std::span<double> out){ out[i] = 2.0 * out[i]; });

What's happening on the implementation side:

gpu: invokes return stdexec::just(out);
cpu: copies resulting sender from gpu to cpu
cpu: connects resulting sender and starts operation state
cpu: stdexec::just operation state passes rvalue reference to completion channel
cpu: nvexec::bulk invokes kernel with lvalue reference to span stored in cpu memory
gpu: nvexec::bulk kernel accesses lvalue reference to span stored in cpu memory -> issue

@senior-zero, thanks. At each step here, the types are doing reasonable things, IMO. I can imagine this sort of thing happening a lot. What do you think about storing the whole operation state in pinned memory rather than on the (host) stack in sync_wait?

@ericniebler I think storing the operation state in pinned memory should fix the issue.

once we have all the operation states in pinned memory (needs to be done also for split and ensure_started), then all the little bits of temp storage we allocate in pinned memory can become data members of the operation state, saving a significant number of allocations.

@ericniebler I don't think this is the goal for all senders. If we consider then(return_val) | then(accept_val), I'd expect there to be no host/device traffic. If the temporary storage for then return value is in pinned memory, every access from GPU is going to happen through PCIe.


SRS Review: Revision History Date

"Date 2" should be an actual date.

Thank you, Lesley! Date 2 Updated.


Update Java -> Bedrock mapping for 1.18 biomes.

Update the java to bedrock mappings for 1.18 biomes, also removed old biomes from the json. Part of the fix for GeyserMC/Geyser#2704.

GeyserMC/Geyser#2718 also needs to be merged to avoid crashes otherwise invalid biome ids will be sent to the Client.


Enhance testing suite

Moved from https://github.com/nilsgawlik/gdmc_http_client_python/issues/61, by @Flashing-Blinkenlights:

Currently testing is done by a single script and the tests cover very little functionality. Ideally we should make use of better-suited tools and extend the range of tests to encompass the entire codebase.
It might be sensible to do this sooner rather than later
Pro:

Will significantly improve project stability
Will speed up testing and debugging time

Con:

Will take a lot of time to implement

PR #56 has removed the testing script this referred to.
This issue has been replaced with #57.


update to 2.12.1

Version Bump  to 2.12.1

update SHA256
Amendments to About section links

Linter check failed, with the following output:
The following problems have been found:
ERROR: /tmp/abs_ad9uzzcvax/clone/recipe/meta.yaml:9: invalid_url: https://download.savannah.gnu.org/releases/freetype/freetype-2.12.1.tar.gz : URL domain redirect download.savannah.gnu.org ->  bigsearcher.com
ERROR: /tmp/abs_ad9uzzcvax/clone/recipe/meta.yaml:39: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: GPL-2.0-only
Errors were found

Linter check failed, with the following output:
The following problems have been found:
ERROR: /tmp/abs_95ao03wmig/clone/recipe/meta.yaml:9: invalid_url: https://download.savannah.gnu.org/releases/freetype/freetype-2.12.1.tar.gz : URL domain redirect download.savannah.gnu.org ->  bigsearcher.com
ERROR: /tmp/abs_95ao03wmig/clone/recipe/meta.yaml:39: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: GPL-2.0-only
Errors were found


Folder jumping

Simple implemation with the adding in git-module (gogits/git-module#7) for implementing  #1149
Certainly not the best implementation in  term of efficiency.

Maybe a better choice could be to edit the TreeEntry struct and a JumpedFolder attribute relink the treeentry to the pointing file. In this case the treeEntry would reflect the real pointed file and not the folder. It could also limite the calculation to one time.

I tested this in my local install, latest master + this merge. It worked fine, but the performance impact was huge, loading times went up A LOT.

I rebase code since it was base on old version and i did some measures. (done with sqlite for db and gogs as repo with some folders to jump)
Before Rebase :
Gogs Version: <IP_ADDRESS>6 Page: 740ms Template: 10ms
Gogs Version (with PR): <IP_ADDRESS>6 Page: 1119ms Template: 14ms
After rebase :
Gogs Version: <IP_ADDRESS>6 Page: 725ms Template: 4ms
Gogs Version (with PR): <IP_ADDRESS>6 Page: 1011ms Template: 4ms

Very nice :+1:

I find the performance impact of the current solution very high. On a small Java project (3 MB code) the response times went from 270ms to 4200ms. Java projects often have a lot of empty folders because of the package names and this sums up to a lot of loops in the code.

@mhartkorn you are right on this, gogs would benefit from caching at a few places. On our KVM hosted gogs even loading the mainpage takes ~1 second for rendering.

@xor-gate In theory gogs supports redis and memcached but they don't seem to be used at all. But even if gogs was able to use redis for folder structures, a 4 second page load for every single folder in a repository for people that don't use redis is too long to be considered useful in my opinion. Maybe this feature can be an option.

People could benefit if in-memory cache works for this long operations. IMHO 4 seconds is crazy for a repo of 3 megabyte. Seems a little performance regression here probably. Even when the disk cache is not warmed up it should not take 4 seconds.

Just a note Gogs has unified cache interface, it does not matter you use in-memory, redis or memcache.


Overide save in model to compress the image will not save the file

Hi
im trying to implement compress to my imagefield. But for some reason it will not upload the image. when I check the image in B2 using ftp. it have 0 bytes. Do you perhaps know why it behave like that?
Model.py
def compress(image):
    temp_name = image.name.split(".")[1]
    im = Image.open(image)
    if im.mode != "RGB":
        im = im.convert("RGB")
    im_io = BytesIO()
    im.save(im_io, "JPEG", optimize=True, quality=50)
    new_image = File(im_io, name=image.name)

    return new_image

class Program(models.Model):
  image = models.ImageField(
          upload_to="program_cover",
          blank=False,
          null=False,
          storage=LoggedInStorage,
)
def save(self, *args, **kwargs):
        new_image = compress(self.image)
        self.image = new_image
        super().save(*args, **kwargs)

Thanks

Hmm... I'm not exactly sure, as I'm not familiar with Image is that Pillow?
You could try compressing files as a wrapper directly in the way django-storages does?
https://github.com/jschneier/django-storages/blob/master/storages/compress.py#L9

Thanks for replying. I will check on the repo above.


WIP: reorganizing DGMulti mesh types

Todo:

[x] Replace VertexMappedMesh with DGMultiMesh
[ ] Introduce CartesianMesh constructor

The docs should be updated, too - for example, "Simplicial mesh" should probably become "DGMulti mesh"?

The docs should be updated, too - for example, "Simplicial mesh" should probably become "DGMulti mesh"?

Yes, definitely. Thanks for the reminder.

@ranocha @sloede I think I've addressed most of the comments. Once this and https://github.com/trixi-framework/Trixi.jl/pull/1014 are merged, I'll submit one more PR to introduce some new DGMulti mesh types before the next release.

@ranocha I'll add tests for the periodic SBP operators tomorrow morning and ping you when that's done.
I think I'll also clean up the type parameters since I don't appear to be using some of them...

@ranocha I'll add tests for the periodic SBP operators tomorrow morning and ping you when that's done.
I think I'll also clean up the type parameters since I don't appear to be using some of them...

Sounds good to me, thanks :+1: You could also consider removing the type parameters from the docstrings to avoid making breaking changes when you adapt them later.

@ranocha I'll add tests for the periodic SBP operators tomorrow morning and ping you when that's done.
I think I'll also clean up the type parameters since I don't appear to be using some of them...

Sounds good to me, thanks 👍 You could also consider removing the type parameters from the docstrings to avoid making breaking changes when you adapt them later.

To me, this sounds like this process would involve

removing type parameters from docs
releasing a new version
Modifying type parameters
releasing another (technically non breaking :trollface:) version

Is that what you’re envisioning?

Basically yes. For example, I'm thinking about a docstring such as
    DGMultiMesh{NDIMS, ElemType, Nboundaries, Tv, Ti} <: AbstractMeshData{NDIMS, ElemType}

You could, for example, remove the implementation details Nboundaries, Tv, Ti from this docstring. Then, they are not part of the public API and can be changed without introducing breaking changes.

Found a bug, FDSBP doesn't seem to converge if the domain is not [-1, 1]. Working on figuring out what's going on

Found a bug, FDSBP doesn't seem to converge if the domain is not [-1, 1]. Working on figuring out what's going on

Please ping me when I shall have a look, too. (I will not be able to do it right now but maybe later, this afternoon or so.) Which setup did you use to find this problems?

I had some time to debug this and pushed a fix. Please check whether everything looks good to you, @jlchan

@ranocha thanks for catching those!

@ranocha I'm just cleaning up DGMultiMesh type parameters now and then it should be ready for another review.

Sounds good. Please ping me and @sloede when you're ready.
Do I remember correctly that you wanted to make another PR before we tag a new version of Trixi?

Sounds good. Please ping me and @sloede when you're ready.
Do I remember correctly that you wanted to make another PR before we tag a new version of Trixi?

I shouldn't need to. I think we can release these features first then I can fix the rest of the mesh system afterwards.

Odd, why didn't my commit editing make.jl show up?
Thanks for adding that on your end @ranocha.


Plugin doesnt work work with<EMAIL_ADDRESS>or greater.

This function CDV_IsIPad() has been removed at<EMAIL_ADDRESS>. The function should be replaced with UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad

👍  This worked for me

I changed the function in APPPrinter.m but I still get:
Undefined symbols for architecture i386:
  "_CDV_IsIPad", referenced from:
      -[APPPrinter presentPrintController:fromRect:] in APPPrinter.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

What am I doing wrong?

You have to remove the ios platform and add it again

Has been fixed


Avoid lawsuits by mentioning cookies thing.

IMHO there's no need for this, and more so if it bothers the authenticity of the XP experience 🤷♂
I don't believe anyone would seriously consider litigation against such an artistic/innocent project, especially considering no data is being collected.